Timeline


and

09/05/10:

23:50 Changeset [66812] by commit-queue@webkit.org
  • 7 edits
    1 delete in trunk

2010-09-05 Peter Kasting <pkasting@google.com>

Reviewed by Adam Barth.

Make Chromium/Mac generate continuous mousewheel events with the same wheelDelta values as Safari/Mac.
https://bugs.webkit.org/show_bug.cgi?id=45155

  • fast/events/continuous-platform-wheelevent-in-scrolling-div-expected.txt:
  • fast/events/continuous-platform-wheelevent-in-scrolling-div.html:
  • platform/chromium/fast/events: Removed.
  • platform/chromium/fast/events/continuous-platform-wheelevent-in-scrolling-div-expected.txt: Removed.

2010-09-05 Peter Kasting <pkasting@google.com>

Reviewed by Adam Barth.

Make Chromium/Mac generate continuous mousewheel events with the same wheelDelta values as Safari/Mac.
https://bugs.webkit.org/show_bug.cgi?id=45155

  • src/mac/WebInputEventFactory.mm: (WebKit::WebInputEventFactory::mouseWheelEvent):

2010-09-05 Peter Kasting <pkasting@google.com>

Reviewed by Adam Barth.

Make Chromium/Mac generate continuous mousewheel events with the same wheelDelta values as Safari/Mac.
https://bugs.webkit.org/show_bug.cgi?id=45155

  • DumpRenderTree/chromium/EventSender.cpp: Modify Chromium DRT mousewheel event generation to match new behavior on Mac. (EventSender::handleMouseWheel):
23:14 Changeset [66811] by yurys@chromium.org
  • 8 edits in trunk

2010-09-05 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Joseph Pecoraro.

Web Inspector: remove WebDevToolsAgentClient::forceRepaint which is not used
https://bugs.webkit.org/show_bug.cgi?id=45179

  • public/WebDevToolsAgentClient.h:
  • src/DebuggerAgentImpl.cpp: (WebKit::DebuggerAgentImpl::debuggerOutput):
  • src/WebDevToolsAgentImpl.cpp:
  • src/WebDevToolsAgentImpl.h:

2010-09-05 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Joseph Pecoraro.

Web Inspector: remove WebDevToolsAgentClient::forceRepaint which is not used
https://bugs.webkit.org/show_bug.cgi?id=45179

  • DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
  • DumpRenderTree/chromium/DRTDevToolsAgent.h:
22:39 Changeset [66810] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

2010-09-05 Kent Tamura <tkent@chromium.org>

Unreviewed, test expectation update.

  • platform/chromium/drt_expectations.txt: Fix a duplication with test_expectations.txt in Chromium tree.
21:53 Changeset [66809] by kbr@google.com
  • 2 edits
    1 add in trunk/WebKit/chromium

2010-09-05 Kenneth Russell <kbr@google.com>

Reviewed by Darin Fisher.

Add unit tests for interval tree
https://bugs.webkit.org/show_bug.cgi?id=45161

  • WebKit.gyp:
  • tests/PODIntervalTreeTest.cpp: Added. (WebCore::valueToString): (WebCore::TEST): (WebCore::UserData1::valueToString): (WebCore::EndpointType1::valueToString):
21:38 Changeset [66808] by kbr@google.com
  • 7 edits
    4 adds in trunk

2010-09-05 Kenneth Russell <kbr@google.com>

Reviewed by Darin Fisher.

Add unit tests for red-black tree and (POD) arena
https://bugs.webkit.org/show_bug.cgi?id=45060

  • WebKit.gyp:
  • tests/PODArenaTest.cpp: Added. (WebCore::TestClass1::TestClass2::TestClass2): (WebCore::TEST_F):
  • tests/PODRedBlackTreeTest.cpp: Added. (WebCore::TEST):
  • tests/TreeTestHelpers.cpp: Added. (WebCore::TreeTestHelpers::generateSeed): (WebCore::TreeTestHelpers::initRandom): (WebCore::TreeTestHelpers::nextRandom):
  • tests/TreeTestHelpers.h: Added.

2010-09-05 Kenneth Russell <kbr@google.com>

Reviewed by Darin Fisher.

Add unit tests for red-black tree and (POD) arena
https://bugs.webkit.org/show_bug.cgi?id=45060

  • platform/graphics/gpu/PODArena.h: Made DefaultChunkSize public so unit tests can access it. Fixed copyright header.
  • platform/graphics/gpu/PODInterval.h: Fixed copyright header.
  • platform/graphics/gpu/PODIntervalTree.h: Fixed copyright header.
  • platform/graphics/gpu/PODRedBlackTree.h: Fixed copyright header.
19:29 Changeset [66807] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

2010-09-05 Kent Tamura <tkent@chromium.org>

Unreviewed, test expectation update.

  • platform/chromium/drt_expectations.txt: Apply recent failures.
18:55 Changeset [66806] by tkent@chromium.org
  • 2 edits
    726 adds in trunk/LayoutTests

2010-09-05 Kent Tamura <tkent@chromium.org>

Unreviewed, test expectation update.

Add svg/dynamic-update/ image results for Chromium-win and Chromium-linux.

  • platform/chromium-linux/svg/dynamic-updates/SVGCircleElement-dom-cx-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGCircleElement-dom-cx-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGCircleElement-dom-cy-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGCircleElement-dom-cy-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGCircleElement-dom-r-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGCircleElement-dom-r-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGCircleElement-svgdom-cx-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGCircleElement-svgdom-cx-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGCircleElement-svgdom-cy-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGCircleElement-svgdom-cy-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGCircleElement-svgdom-r-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGCircleElement-svgdom-r-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGClipPath-influences-hitTesting-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGClipPath-influences-hitTesting-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGClipPathElement-dom-clipPathUnits-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGClipPathElement-dom-clipPathUnits-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGClipPathElement-svgdom-clipPathUnits-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGClipPathElement-svgdom-clipPathUnits-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGCursorElement-dom-x-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGCursorElement-dom-x-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGCursorElement-dom-y-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGCursorElement-dom-y-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGCursorElement-svgdom-x-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGCursorElement-svgdom-x-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGCursorElement-svgdom-y-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGCursorElement-svgdom-y-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGEllipseElement-dom-cx-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGEllipseElement-dom-cx-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGEllipseElement-dom-cy-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGEllipseElement-dom-cy-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGEllipseElement-dom-rx-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGEllipseElement-dom-rx-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGEllipseElement-dom-ry-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGEllipseElement-dom-ry-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGEllipseElement-svgdom-cx-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGEllipseElement-svgdom-cx-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGEllipseElement-svgdom-cy-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGEllipseElement-svgdom-cy-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGEllipseElement-svgdom-rx-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGEllipseElement-svgdom-rx-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGEllipseElement-svgdom-ry-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGEllipseElement-svgdom-ry-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-diffuseConstant-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-diffuseConstant-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-in-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-in-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-lighting-color-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-lighting-color-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-surfaceScale-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-surfaceScale-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDiffuseLightingElement-lighting-color-css-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDiffuseLightingElement-lighting-color-css-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-diffuseConstant-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-diffuseConstant-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-in-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-in-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-surfaceScale-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-surfaceScale-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEOffsetElement-dom-dx-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEOffsetElement-dom-dx-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEOffsetElement-dom-dy-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEOffsetElement-dom-dy-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEOffsetElement-dom-in-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEOffsetElement-dom-in-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEOffsetElement-svgdom-dx-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEOffsetElement-svgdom-dx-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEOffsetElement-svgdom-dy-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEOffsetElement-svgdom-dy-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEOffsetElement-svgdom-in-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEOffsetElement-svgdom-in-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpotLightElement-dom-limitingConeAngle-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpotLightElement-dom-limitingConeAngle-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtX-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtX-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtY-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtY-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtZ-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtZ-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpotLightElement-dom-specularExponent-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpotLightElement-dom-specularExponent-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpotLightElement-dom-x-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpotLightElement-dom-x-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpotLightElement-dom-y-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpotLightElement-dom-y-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpotLightElement-dom-z-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpotLightElement-dom-z-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpotLightElement-svgdom-limitingConeAngle-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpotLightElement-svgdom-limitingConeAngle-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtX-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtX-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtY-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtY-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtZ-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtZ-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpotLightElement-svgdom-specularExponent-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpotLightElement-svgdom-specularExponent-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpotLightElement-svgdom-x-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpotLightElement-svgdom-x-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpotLightElement-svgdom-y-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpotLightElement-svgdom-y-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpotLightElement-svgdom-z-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpotLightElement-svgdom-z-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterElement-dom-filterRes-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterElement-dom-filterRes-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterElement-dom-filterUnits-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterElement-dom-filterUnits-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterElement-dom-height-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterElement-dom-height-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterElement-dom-primitiveUnits-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterElement-dom-primitiveUnits-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterElement-dom-width-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterElement-dom-width-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterElement-dom-x-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterElement-dom-x-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterElement-dom-y-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterElement-dom-y-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterElement-svgdom-filterRes-call-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterElement-svgdom-filterRes-call-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterElement-svgdom-filterResX-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterElement-svgdom-filterResX-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterElement-svgdom-filterResY-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterElement-svgdom-filterResY-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterElement-svgdom-filterUnits-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterElement-svgdom-filterUnits-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterElement-svgdom-height-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterElement-svgdom-height-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterElement-svgdom-primitiveUnits-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterElement-svgdom-primitiveUnits-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterElement-svgdom-width-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterElement-svgdom-width-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterElement-svgdom-x-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterElement-svgdom-x-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterElement-svgdom-y-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterElement-svgdom-y-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-height-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-height-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-result-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-result-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-width-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-width-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-x-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-x-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-y-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-y-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-height-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-height-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-result-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-result-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-width-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-width-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-x-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-x-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-y-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-y-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGForeignObjectElement-dom-height-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGForeignObjectElement-dom-height-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGForeignObjectElement-dom-width-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGForeignObjectElement-dom-width-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGForeignObjectElement-dom-x-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGForeignObjectElement-dom-x-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGForeignObjectElement-dom-y-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGForeignObjectElement-dom-y-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGForeignObjectElement-svgdom-height-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGForeignObjectElement-svgdom-height-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGForeignObjectElement-svgdom-width-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGForeignObjectElement-svgdom-width-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGForeignObjectElement-svgdom-x-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGForeignObjectElement-svgdom-x-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGForeignObjectElement-svgdom-y-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGForeignObjectElement-svgdom-y-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGImageElement-dom-height-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGImageElement-dom-height-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGImageElement-dom-width-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGImageElement-dom-width-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGImageElement-dom-x-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGImageElement-dom-x-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGImageElement-dom-y-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGImageElement-dom-y-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGImageElement-svgdom-x-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGImageElement-svgdom-x-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGImageElement-svgdom-y-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGImageElement-svgdom-y-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLineElement-dom-x1-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLineElement-dom-x1-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLineElement-dom-x2-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLineElement-dom-x2-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLineElement-dom-y1-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLineElement-dom-y1-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLineElement-dom-y2-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLineElement-dom-y2-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLineElement-svgdom-x1-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLineElement-svgdom-x1-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLineElement-svgdom-x2-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLineElement-svgdom-x2-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLineElement-svgdom-y1-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLineElement-svgdom-y1-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLineElement-svgdom-y2-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLineElement-svgdom-y2-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLinearGradientElement-dom-gradientTransform-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLinearGradientElement-dom-gradientTransform-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLinearGradientElement-dom-gradientUnits-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLinearGradientElement-dom-gradientUnits-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLinearGradientElement-dom-x1-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLinearGradientElement-dom-x1-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLinearGradientElement-dom-x2-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLinearGradientElement-dom-x2-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLinearGradientElement-dom-y1-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLinearGradientElement-dom-y1-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLinearGradientElement-dom-y2-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLinearGradientElement-dom-y2-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientTransform-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientTransform-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientUnits-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientUnits-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLinearGradientElement-svgdom-x1-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLinearGradientElement-svgdom-x1-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLinearGradientElement-svgdom-x2-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLinearGradientElement-svgdom-x2-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLinearGradientElement-svgdom-y1-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLinearGradientElement-svgdom-y1-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLinearGradientElement-svgdom-y2-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLinearGradientElement-svgdom-y2-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMarkerElement-dom-markerHeight-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMarkerElement-dom-markerHeight-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMarkerElement-dom-markerUnits-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMarkerElement-dom-markerUnits-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMarkerElement-dom-markerWidth-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMarkerElement-dom-markerWidth-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMarkerElement-dom-orient-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMarkerElement-dom-orient-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMarkerElement-dom-refX-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMarkerElement-dom-refX-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMarkerElement-dom-refY-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMarkerElement-dom-refY-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMarkerElement-svgdom-markerHeight-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMarkerElement-svgdom-markerHeight-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMarkerElement-svgdom-markerUnits-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMarkerElement-svgdom-markerUnits-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMarkerElement-svgdom-markerWidth-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMarkerElement-svgdom-markerWidth-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMarkerElement-svgdom-orientAngle-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMarkerElement-svgdom-orientAngle-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMarkerElement-svgdom-orientType-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMarkerElement-svgdom-orientType-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMarkerElement-svgdom-refX-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMarkerElement-svgdom-refX-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMarkerElement-svgdom-refY-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMarkerElement-svgdom-refY-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMarkerElement-svgdom-setOrientToAngle-call-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMarkerElement-svgdom-setOrientToAngle-call-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMarkerElement-svgdom-setOrientToAuto-call-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMarkerElement-svgdom-setOrientToAuto-call-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMaskElement-dom-height-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMaskElement-dom-height-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMaskElement-dom-maskContentUnits-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMaskElement-dom-maskContentUnits-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMaskElement-dom-maskUnits-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMaskElement-dom-maskUnits-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMaskElement-dom-width-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMaskElement-dom-width-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMaskElement-dom-x-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMaskElement-dom-x-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMaskElement-dom-y-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMaskElement-dom-y-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMaskElement-svgdom-height-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMaskElement-svgdom-height-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMaskElement-svgdom-maskContentUnits-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMaskElement-svgdom-maskContentUnits-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMaskElement-svgdom-maskUnits-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMaskElement-svgdom-maskUnits-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMaskElement-svgdom-width-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMaskElement-svgdom-width-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMaskElement-svgdom-x-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMaskElement-svgdom-x-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMaskElement-svgdom-y-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMaskElement-svgdom-y-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPatternElement-dom-height-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPatternElement-dom-height-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPatternElement-dom-patternContentUnits-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPatternElement-dom-patternContentUnits-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPatternElement-dom-patternTransform-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPatternElement-dom-patternTransform-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPatternElement-dom-patternUnits-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPatternElement-dom-patternUnits-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPatternElement-dom-width-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPatternElement-dom-width-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPatternElement-dom-x-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPatternElement-dom-x-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPatternElement-dom-y-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPatternElement-dom-y-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPatternElement-svgdom-height-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPatternElement-svgdom-height-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPatternElement-svgdom-patternContentUnits-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPatternElement-svgdom-patternContentUnits-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPatternElement-svgdom-patternTransform-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPatternElement-svgdom-patternTransform-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPatternElement-svgdom-patternUnits-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPatternElement-svgdom-patternUnits-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPatternElement-svgdom-width-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPatternElement-svgdom-width-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPatternElement-svgdom-x-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPatternElement-svgdom-x-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPatternElement-svgdom-y-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPatternElement-svgdom-y-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-dom-cx-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-dom-cx-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-dom-cy-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-dom-cy-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-dom-fx-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-dom-fx-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-dom-fy-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-dom-fy-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-dom-gradientTransform-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-dom-gradientTransform-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-dom-gradientUnits-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-dom-gradientUnits-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-dom-r-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-dom-r-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-svgdom-cx-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-svgdom-cx-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-svgdom-cy-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-svgdom-cy-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-svgdom-fx-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-svgdom-fx-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-svgdom-fy-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-svgdom-fy-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientTransform-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientTransform-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientUnits-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientUnits-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-svgdom-r-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-svgdom-r-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRectElement-dom-height-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRectElement-dom-height-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRectElement-dom-width-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRectElement-dom-width-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRectElement-dom-x-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRectElement-dom-x-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRectElement-dom-y-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRectElement-dom-y-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRectElement-svgdom-height-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRectElement-svgdom-height-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRectElement-svgdom-width-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRectElement-svgdom-width-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRectElement-svgdom-x-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRectElement-svgdom-x-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRectElement-svgdom-y-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRectElement-svgdom-y-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGTRefElement-dom-href-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGTRefElement-dom-href-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGTextElement-dom-transform-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGTextElement-dom-transform-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGTextElement-svgdom-transform-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGTextElement-svgdom-transform-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGCircleElement-dom-cx-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGCircleElement-dom-cx-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGCircleElement-dom-cy-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGCircleElement-dom-cy-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGCircleElement-dom-r-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGCircleElement-dom-r-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGCircleElement-svgdom-cx-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGCircleElement-svgdom-cx-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGCircleElement-svgdom-cy-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGCircleElement-svgdom-cy-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGCircleElement-svgdom-r-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGCircleElement-svgdom-r-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGClipPath-influences-hitTesting-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGClipPath-influences-hitTesting-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGClipPathElement-dom-clipPathUnits-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGClipPathElement-dom-clipPathUnits-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGClipPathElement-svgdom-clipPathUnits-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGClipPathElement-svgdom-clipPathUnits-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGCursorElement-dom-x-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGCursorElement-dom-x-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGCursorElement-dom-y-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGCursorElement-dom-y-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGCursorElement-svgdom-x-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGCursorElement-svgdom-x-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGCursorElement-svgdom-y-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGCursorElement-svgdom-y-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGEllipseElement-dom-cx-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGEllipseElement-dom-cx-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGEllipseElement-dom-cy-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGEllipseElement-dom-cy-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGEllipseElement-dom-rx-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGEllipseElement-dom-rx-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGEllipseElement-dom-ry-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGEllipseElement-dom-ry-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGEllipseElement-svgdom-cx-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGEllipseElement-svgdom-cx-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGEllipseElement-svgdom-cy-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGEllipseElement-svgdom-cy-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGEllipseElement-svgdom-rx-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGEllipseElement-svgdom-rx-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGEllipseElement-svgdom-ry-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGEllipseElement-svgdom-ry-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-diffuseConstant-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-diffuseConstant-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-in-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-in-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-lighting-color-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-lighting-color-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-surfaceScale-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-surfaceScale-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEDiffuseLightingElement-lighting-color-css-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEDiffuseLightingElement-lighting-color-css-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-diffuseConstant-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-diffuseConstant-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-in-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-in-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-surfaceScale-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-surfaceScale-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEOffsetElement-dom-dx-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEOffsetElement-dom-dx-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEOffsetElement-dom-dy-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEOffsetElement-dom-dy-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEOffsetElement-dom-in-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEOffsetElement-dom-in-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEOffsetElement-svgdom-dx-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEOffsetElement-svgdom-dx-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEOffsetElement-svgdom-dy-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEOffsetElement-svgdom-dy-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEOffsetElement-svgdom-in-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEOffsetElement-svgdom-in-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFESpotLightElement-dom-limitingConeAngle-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFESpotLightElement-dom-limitingConeAngle-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtX-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtX-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtY-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtY-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtZ-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtZ-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFESpotLightElement-dom-specularExponent-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFESpotLightElement-dom-specularExponent-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFESpotLightElement-dom-x-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFESpotLightElement-dom-x-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFESpotLightElement-dom-y-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFESpotLightElement-dom-y-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFESpotLightElement-dom-z-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFESpotLightElement-dom-z-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFESpotLightElement-svgdom-limitingConeAngle-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFESpotLightElement-svgdom-limitingConeAngle-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtX-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtX-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtY-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtY-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtZ-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtZ-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFESpotLightElement-svgdom-specularExponent-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFESpotLightElement-svgdom-specularExponent-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFESpotLightElement-svgdom-x-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFESpotLightElement-svgdom-x-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFESpotLightElement-svgdom-y-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFESpotLightElement-svgdom-y-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFESpotLightElement-svgdom-z-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFESpotLightElement-svgdom-z-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterElement-dom-filterRes-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterElement-dom-filterRes-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterElement-dom-filterUnits-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterElement-dom-filterUnits-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterElement-dom-height-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterElement-dom-height-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterElement-dom-primitiveUnits-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterElement-dom-primitiveUnits-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterElement-dom-width-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterElement-dom-width-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterElement-dom-x-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterElement-dom-x-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterElement-dom-y-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterElement-dom-y-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterElement-svgdom-filterRes-call-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterElement-svgdom-filterRes-call-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterElement-svgdom-filterResX-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterElement-svgdom-filterResX-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterElement-svgdom-filterResY-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterElement-svgdom-filterResY-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterElement-svgdom-filterUnits-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterElement-svgdom-filterUnits-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterElement-svgdom-height-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterElement-svgdom-height-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterElement-svgdom-primitiveUnits-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterElement-svgdom-primitiveUnits-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterElement-svgdom-width-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterElement-svgdom-width-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterElement-svgdom-x-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterElement-svgdom-x-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterElement-svgdom-y-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterElement-svgdom-y-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-height-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-height-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-result-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-result-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-width-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-width-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-x-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-x-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-y-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-y-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-height-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-height-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-result-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-result-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-width-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-width-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-x-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-x-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-y-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-y-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGForeignObjectElement-dom-height-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGForeignObjectElement-dom-height-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGForeignObjectElement-dom-width-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGForeignObjectElement-dom-width-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGForeignObjectElement-dom-x-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGForeignObjectElement-dom-x-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGForeignObjectElement-dom-y-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGForeignObjectElement-dom-y-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGForeignObjectElement-svgdom-height-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGForeignObjectElement-svgdom-height-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGForeignObjectElement-svgdom-width-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGForeignObjectElement-svgdom-width-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGForeignObjectElement-svgdom-x-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGForeignObjectElement-svgdom-x-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGForeignObjectElement-svgdom-y-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGForeignObjectElement-svgdom-y-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGImageElement-dom-height-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGImageElement-dom-height-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGImageElement-dom-width-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGImageElement-dom-width-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGImageElement-dom-x-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGImageElement-dom-x-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGImageElement-dom-y-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGImageElement-dom-y-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGImageElement-svgdom-x-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGImageElement-svgdom-x-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGImageElement-svgdom-y-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGImageElement-svgdom-y-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLineElement-dom-x1-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLineElement-dom-x1-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLineElement-dom-x2-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLineElement-dom-x2-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLineElement-dom-y1-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLineElement-dom-y1-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLineElement-dom-y2-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLineElement-dom-y2-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLineElement-svgdom-x1-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLineElement-svgdom-x1-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLineElement-svgdom-x2-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLineElement-svgdom-x2-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLineElement-svgdom-y1-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLineElement-svgdom-y1-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLineElement-svgdom-y2-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLineElement-svgdom-y2-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLinearGradientElement-dom-gradientTransform-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLinearGradientElement-dom-gradientTransform-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLinearGradientElement-dom-gradientUnits-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLinearGradientElement-dom-gradientUnits-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLinearGradientElement-dom-x1-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLinearGradientElement-dom-x1-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLinearGradientElement-dom-x2-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLinearGradientElement-dom-x2-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLinearGradientElement-dom-y1-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLinearGradientElement-dom-y1-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLinearGradientElement-dom-y2-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLinearGradientElement-dom-y2-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientTransform-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientTransform-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientUnits-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientUnits-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLinearGradientElement-svgdom-x1-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLinearGradientElement-svgdom-x1-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLinearGradientElement-svgdom-x2-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLinearGradientElement-svgdom-x2-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLinearGradientElement-svgdom-y1-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLinearGradientElement-svgdom-y1-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLinearGradientElement-svgdom-y2-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLinearGradientElement-svgdom-y2-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMarkerElement-dom-markerHeight-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMarkerElement-dom-markerHeight-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMarkerElement-dom-markerUnits-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMarkerElement-dom-markerUnits-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMarkerElement-dom-markerWidth-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMarkerElement-dom-markerWidth-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMarkerElement-dom-orient-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMarkerElement-dom-orient-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMarkerElement-dom-refX-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMarkerElement-dom-refX-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMarkerElement-dom-refY-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMarkerElement-dom-refY-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMarkerElement-svgdom-markerHeight-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMarkerElement-svgdom-markerHeight-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMarkerElement-svgdom-markerUnits-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMarkerElement-svgdom-markerUnits-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMarkerElement-svgdom-markerWidth-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMarkerElement-svgdom-markerWidth-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMarkerElement-svgdom-orientAngle-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMarkerElement-svgdom-orientAngle-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMarkerElement-svgdom-orientType-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMarkerElement-svgdom-orientType-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMarkerElement-svgdom-refX-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMarkerElement-svgdom-refX-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMarkerElement-svgdom-refY-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMarkerElement-svgdom-refY-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMarkerElement-svgdom-setOrientToAngle-call-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMarkerElement-svgdom-setOrientToAngle-call-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMarkerElement-svgdom-setOrientToAuto-call-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMarkerElement-svgdom-setOrientToAuto-call-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMaskElement-dom-height-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMaskElement-dom-height-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMaskElement-dom-maskContentUnits-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMaskElement-dom-maskContentUnits-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMaskElement-dom-maskUnits-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMaskElement-dom-maskUnits-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMaskElement-dom-width-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMaskElement-dom-width-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMaskElement-dom-x-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMaskElement-dom-x-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMaskElement-dom-y-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMaskElement-dom-y-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMaskElement-svgdom-height-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMaskElement-svgdom-height-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMaskElement-svgdom-maskContentUnits-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMaskElement-svgdom-maskContentUnits-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMaskElement-svgdom-maskUnits-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMaskElement-svgdom-maskUnits-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMaskElement-svgdom-width-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMaskElement-svgdom-width-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMaskElement-svgdom-x-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMaskElement-svgdom-x-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMaskElement-svgdom-y-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMaskElement-svgdom-y-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPatternElement-dom-height-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPatternElement-dom-height-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPatternElement-dom-patternContentUnits-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPatternElement-dom-patternContentUnits-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPatternElement-dom-patternTransform-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPatternElement-dom-patternTransform-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPatternElement-dom-patternUnits-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPatternElement-dom-patternUnits-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPatternElement-dom-width-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPatternElement-dom-width-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPatternElement-dom-x-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPatternElement-dom-x-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPatternElement-dom-y-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPatternElement-dom-y-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPatternElement-svgdom-height-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPatternElement-svgdom-height-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPatternElement-svgdom-patternContentUnits-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPatternElement-svgdom-patternContentUnits-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPatternElement-svgdom-patternTransform-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPatternElement-svgdom-patternTransform-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPatternElement-svgdom-patternUnits-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPatternElement-svgdom-patternUnits-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPatternElement-svgdom-width-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPatternElement-svgdom-width-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPatternElement-svgdom-x-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPatternElement-svgdom-x-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPatternElement-svgdom-y-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPatternElement-svgdom-y-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-dom-cx-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-dom-cx-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-dom-cy-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-dom-cy-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-dom-fx-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-dom-fx-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-dom-fy-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-dom-fy-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-dom-gradientTransform-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-dom-gradientTransform-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-dom-gradientUnits-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-dom-gradientUnits-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-dom-r-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-dom-r-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-svgdom-cx-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-svgdom-cx-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-svgdom-cy-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-svgdom-cy-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-svgdom-fx-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-svgdom-fx-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-svgdom-fy-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-svgdom-fy-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientTransform-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientTransform-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientUnits-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientUnits-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-svgdom-r-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-svgdom-r-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRectElement-dom-height-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRectElement-dom-height-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRectElement-dom-width-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRectElement-dom-width-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRectElement-dom-x-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRectElement-dom-x-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRectElement-dom-y-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRectElement-dom-y-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRectElement-svgdom-height-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRectElement-svgdom-height-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRectElement-svgdom-width-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRectElement-svgdom-width-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRectElement-svgdom-x-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRectElement-svgdom-x-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRectElement-svgdom-y-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRectElement-svgdom-y-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGTRefElement-dom-href-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGTRefElement-dom-href-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGTextElement-dom-transform-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGTextElement-dom-transform-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGTextElement-svgdom-transform-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGTextElement-svgdom-transform-prop-expected.png: Added.
  • platform/chromium/drt_expectations.txt:
18:39 Changeset [66805] by tkent@chromium.org
  • 3 edits
    5 adds in trunk/LayoutTests

2010-09-05 Kent Tamura <tkent@chromium.org>

Unreviewed, test expectation update.

Update Chromium-mac results for dynamic-updates.

  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientTransform-prop-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGPatternElement-svgdom-patternTransform-prop-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientTransform-prop-expected.checksum: Added.
  • platform/chromium/drt_expectations.txt:
  • platform/chromium/test_expectations.txt:
16:26 WebKit Team edited by andreas.kling@nokia.com
(diff)
16:20 Changeset [66804] by andreas.kling@nokia.com
  • 2 edits in trunk/WebKitTools

2010-09-05 Andreas Kling <andreas.kling@nokia.com>

Rubber-stamped by Daniel Bates.

Adding myself as reviewer.

  • Scripts/webkitpy/common/config/committers.py:
09:30 Changeset [66803] by commit-queue@webkit.org
  • 4 edits in trunk

2010-09-05 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r66801.
http://trac.webkit.org/changeset/66801
https://bugs.webkit.org/show_bug.cgi?id=45242

'breaks editing/pasteboard/onpaste-text-html.html' (Requested
by mwenge4 on #webkit).

  • platform/qt/Skipped:

2010-09-05 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r66801.
http://trac.webkit.org/changeset/66801
https://bugs.webkit.org/show_bug.cgi?id=45242

'breaks editing/pasteboard/onpaste-text-html.html' (Requested
by mwenge4 on #webkit).

  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::addMessageToConsole):
08:08 Changeset [66802] by jorlow@chromium.org
  • 22 edits
    2 adds in trunk

2010-09-05 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Steve Block.

Add IndexedDB objects' constructors to window
https://bugs.webkit.org/show_bug.cgi?id=44599

Beef up keyRange test to verify we're actualy operating
on the interface rather than an instance.

Add a test to verify the constants.

  • storage/indexeddb/constants.html:
  • storage/indexeddb/constants-expected.txt:
  • storage/indexeddb/keyrange-expected.txt:
  • storage/indexeddb/script-tests/keyrange.js: ():

2010-09-05 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Nate Chapin.

Add the concept of class methods to bindings (for IndexedDB's IDBKeyRange).
https://bugs.webkit.org/show_bug.cgi?id=45044

IndexedDB's IDBKeyRange has what, in other languages, are called class
methods. In javaScript terms, these are methods only accessible from their
constructor and not instances. This change adds such support to V8. There
are already other features required for IndexedDB that JSC doesn't yet
support, so I'll add this to the list of todo items in the master bug
for that.

The bindings tests cover this. My next patch will change WebCore to use
this and it'll have associated layout tests.

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/scripts/test/CPP/WebDOMTestObj.cpp: (WebDOMTestObj::classMethod): (WebDOMTestObj::classMethodWithOptional):
  • bindings/scripts/test/CPP/WebDOMTestObj.h:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: (webkit_dom_test_obj_class_method): (webkit_dom_test_obj_class_method_with_optional):
  • bindings/scripts/test/GObject/WebKitDOMTestObj.h:
  • bindings/scripts/test/JS/JSTestObj.cpp: (WebCore::jsTestObjPrototypeFunctionStaticMethod): (WebCore::jsTestObjPrototypeFunctionStaticMethodWithOptional):
  • bindings/scripts/test/JS/JSTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.mm: (-[DOMTestObj classMethod]): (-[DOMTestObj classMethodWithOptional:]):
  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/V8/V8TestObj.cpp: (WebCore::TestObjInternal::classMethodCallback): (WebCore::TestObjInternal::classMethodWithOptionalCallback): (WebCore::ConfigureV8TestObjTemplate):
  • storage/IDBKeyRange.idl:
07:28 Changeset [66801] by robert@webkit.org
  • 4 edits in trunk

2010-09-05 Robert Hogan <robert@webkit.org>

Reviewed by Antonio Gomes.

[Qt] utf8 encoding of console() messages

Unskip:
http/tests/security/xssAuditor/embed-tag-null-char.html
http/tests/security/xssAuditor/object-embed-tag-null-char.html

https://bugs.webkit.org/show_bug.cgi?id=45240

  • platform/qt/Skipped:

2010-09-05 Robert Hogan <robert@webkit.org>

Reviewed by Antonio Gomes.

[Qt] utf8 encoding of console() messages

http/tests/security/xssAuditor/embed-tag-null-char.html
http/tests/security/xssAuditor/object-embed-tag-null-char.html

both fail because ChromeClientQt::addMessageToConsole() is
casting String to QString rather than String::utf8().data()

https://bugs.webkit.org/show_bug.cgi?id=45240

  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::addMessageToConsole):

09/04/10:

18:12 Changeset [66800] by dbates@webkit.org
  • 5 edits in trunk/WebKitTools

2010-09-04 Daniel Bates <dbates@rim.com>

Reviewed by Martin Robinson.

Teach svn-apply/unapply about svn:mergeinfo
https://bugs.webkit.org/show_bug.cgi?id=45236

Recognize the svn:mergeinfo property and ignore it for now.

Currently, svn-apply/unapply recognize only '+' and '-'
property changes within a diff. We should add support
to recognize "Merged" and "Reverse-merged" changes as well.
Because svn:mergeinfo is metadata that is used only by SVN
and tends to be error-prone and/or nuisance (*), we will ignore
it for now.
(*) See "Parting Thoughts" of <http://www.collab.net/community/subversion/articles/merge-info.html>.

  • Scripts/VCSUtils.pm:
    • Modified parseSvnProperty() to recognize "Merged" and "Reverse-merged" as the start of a property value.
  • Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffFooter.pl:
    • Added the following unit tests: "simple: add svn:mergeinfo" "simple: delete svn:mergeinfo" "simple: modified svn:mergeinfo"
  • Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
    • Added the following unit tests: "simple: add svn:mergeinfo" "simple: delete svn:mergeinfo" "simple: modified svn:mergeinfo" "simple: modified svn:mergeinfo using SVN 1.4 syntax" "'Merged' change followed by 'Merged' change" "'Reverse-merged' change followed by 'Reverse-merged' change"
  • Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
    • Added the following unit tests: "'Merged' change" "'Reverse-merged' change" "'Reverse-merged' change followed by 'Merge' change" "'Merged' change followed by 'Merge' change" "'Reverse-merged' change followed by 'Reverse-merged' change" "'Reverse-merged' change followed by 'Reverse-merged' change followed by 'Merged' change"
17:19 Changeset [66799] by weinig@apple.com
  • 8 edits in trunk/WebKit2

Allow passing null to postMessage API functions
https://bugs.webkit.org/show_bug.cgi?id=45234

Reviewed by Anders Carlsson.

  • Shared/APIObject.h: Add TypeNull to enum. This is only used

for serialization purposes, and does not represent a concrete subclass
of APIObject.

  • Shared/CoreIPCSupport/WebPageProxyMessageKinds.h: Remove WillSubmitFormWithUserData

now that it is not needed.

  • Shared/UserMessageCoders.h:

(WebKit::UserMessageEncoder::baseEncode):
(WebKit::UserMessageDecoder::baseDecode):
Add explicit encoding/decoding of null for user messages.

  • UIProcess/WebContextUserMessageCoders.h:

(WebKit::WebContextUserMessageEncoder::encode):
(WebKit::WebContextUserMessageDecoder::decode):

  • WebProcess/InjectedBundle/InjectedBundleUserMessageCoders.h:

(WebKit::InjectedBundleUserMessageEncoder::encode):
(WebKit::InjectedBundleUserMessageDecoder::decode):
Update UserMessageCoders subclasses to call the base class in the correct
way to work with null messages. This means moving the encoding/decoding
of the type down to the base class, which is a nice cleanup.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didReceiveMessage):
Remove now redundant WillSubmitFormWithUserData implementation.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchWillSubmitForm):
Ditto.

16:28 Changeset [66798] by steveblock@google.com
  • 2 edits in trunk/LayoutTests

2010-09-04 Steve Block <steveblock@google.com>

Reviewed by Martin Robinson.

GTK Skipped list should allow a directory to be listed when a feature is not supported
https://bugs.webkit.org/show_bug.cgi?id=45229

This change updates the comment in the GTK Skipped list to make this
clear and applies the new policy for the DeviceOrientation and
DeviceMotion tests.

  • platform/gtk/Skipped:
15:04 Changeset [66797] by commit-queue@webkit.org
  • 5 edits
    1 move
    2 adds in trunk

2010-09-04 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Move test browser to WebKitTools directory
https://bugs.webkit.org/show_bug.cgi?id=45212

Follow other ports like QT and GTK which moved the test browser to
WebKitTools directory.

  • CMakeLists.txt: Include test browser if port defines one.

2010-09-04 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Move test browser to WebKitTools directory
https://bugs.webkit.org/show_bug.cgi?id=45212

Follow other ports like QT and GTK which moved the test browser to
WebKitTools directory.

  • CMakeListsEfl.txt: Remove build for test browser.
  • EWebLauncher/main.c: Removed.

2010-09-04 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Move test browser to WebKitTools directory
https://bugs.webkit.org/show_bug.cgi?id=45212

Follow other ports like QT and GTK which moved the test browser to
WebKitTools directory.

  • CMakeListsEfl.txt: Added.
  • EWebLauncher/main.c: Added. (print_history): (zoom_level_set): (on_ecore_evas_resize): (title_set): (viewport_set): (on_title_changed): (on_progress): (on_load_finished): (on_toolbars_visible_set): (on_toolbars_visible_get): (on_statusbar_visible_set): (on_statusbar_visible_get): (on_scrollbars_visible_set): (on_scrollbars_visible_get): (on_menubar_visible_set): (on_menubar_visible_get): (on_tooltip_text_set): (on_inputmethod_changed): (on_viewport_changed): (on_mouse_down): (on_focus_out): (on_focus_in): (on_resized): (on_key_down): (on_browser_del): (on_closeWindow): (quit): (browserCreate): (browserDestroy): (closeWindow): (main_signal_exit): (findThemePath): (main):
09:24 Changeset [66796] by jschuh@chromium.org
  • 2 edits
    2 adds in trunk/LayoutTests

2010-09-04 Justin Schuh <jschuh@chromium.org>

Unreviewed. Build fix.

Updated platform test to account for xml parser differences

  • platform/mac-leopard/svg/custom/use-invalid-style-expected.txt: Added.
  • platform/qt/svg/custom/use-invalid-style-expected.txt: Added.
  • svg/custom/use-invalid-style-expected.txt:
08:45 Changeset [66795] by jschuh@chromium.org
  • 3 edits
    2 adds in trunk

2010-09-04 Justin Schuh <jschuh@chromium.org>

Reviewed by Nikolas Zimmermann.

Prevent premature deletion of svg use shadow tree
https://bugs.webkit.org/show_bug.cgi?id=43260

Test: svg/custom/use-invalid-style.svg

  • svg/SVGUseElement.cpp: (WebCore::SVGUseElement::insertedIntoDocument): (WebCore::SVGUseElement::removedFromDocument): (WebCore::SVGUseElement::detach):

2010-09-04 Justin Schuh <jschuh@chromium.org>

Reviewed by Nikolas Zimmermann.

Check for premature deletion of svg use shadow style element
https://bugs.webkit.org/show_bug.cgi?id=43260

  • svg/custom/use-invalid-style-expected.txt: Added.
  • svg/custom/use-invalid-style.svg: Added.
07:48 Changeset [66794] by diegohcg@webkit.org
  • 34 edits
    3 copies
    1 add in trunk

Add NetworkingContext to avoid layer violations
https://bugs.webkit.org/show_bug.cgi?id=42292

Patch by Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> on 2010-09-03
Reviewed by Darin Adler.

WebCore:

Create and provide access to NetworkingContext in FrameLoader.

In the WebKit layer we added specific implementations of FrameNetworkingContext
so each port's FrameLoaderClient can add any port specific information to NetworkingContext
The NetworkingContext is, therefore, created by a FrameLoaderClient and stored
in the FrameLoader for each frame created. People must always use it
by calling FrameLoader::networkingContext() and never through their FrameLoaderClient.
The lifetime cycle of NetworkingContext is kept by a RefPtr, so the object is RefCounted.

It is still a preparation to NetworkingContext to be activated and
work for all ports.

  • WebCore.exp.in:
  • loader/EmptyClients.h:

(WebCore::EmptyFrameLoaderClient::createNetworkingContext):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::~FrameLoader):
(WebCore::FrameLoader::init):
(WebCore::FrameLoader::networkingContext):

  • loader/FrameLoader.h:
  • loader/FrameLoaderClient.h:

WebKit/chromium:

Add Chromium's implementation of NetworkingContext.

  • src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::createNetworkingContext):

  • src/FrameLoaderClientImpl.h:

WebKit/efl:

Add createNetworkingContext to EFL's FrameLoaderClient.

  • WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore::FrameLoaderClientEfl::createNetworkingContext):

  • WebCoreSupport/FrameLoaderClientEfl.h:

WebKit/gtk:

Add GTK's specific implementation of FrameNetworkingContext.

  • WebCoreSupport/FrameLoaderClientGtk.cpp:

(WebKit::FrameLoaderClient::createNetworkingContext):

  • WebCoreSupport/FrameLoaderClientGtk.h:

WebKit/mac:

Add Mac's specific implementation of FrameNetworkingContext.

  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm:
  • WebCoreSupport/WebFrameNetworkingContext.mm:

(WebFrameNetworkingContext::needsSiteSpecificQuirks):
(WebFrameNetworkingContext::localFileContentSniffingEnabled):
(WebFrameNetworkingContext::scheduledRunLoopPairs):
(WebFrameNetworkingContext::blockedError):

WebKit/qt:

Add Qt's specific implementation of NetworkingContext.

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::setFrame):
(WebCore::FrameLoaderClientQt::createNetworkingContext):

  • WebCoreSupport/FrameLoaderClientQt.h:
  • WebCoreSupport/FrameNetworkingContextQt.cpp:

(WebCore::FrameNetworkingContextQt::FrameNetworkingContextQt):
(WebCore::FrameNetworkingContextQt::create):
(WebCore::FrameNetworkingContextQt::originatingObject):
(WebCore::FrameNetworkingContextQt::networkAccessManager):

WebKit/win:

Add Win's specific implementation of NetworkingContext.

  • WebCoreSupport/WebFrameNetworkingContext.cpp:

(WebFrameNetworkingContext::create):
(WebFrameNetworkingContext::userAgent):
(WebFrameNetworkingContext::referrer):

  • WebFrame.cpp:

(WebFrame::createNetworkingContext):

  • WebFrame.h:

WebKit2:

Add FrameNetworkingContext implementation.

  • WebKit2.pro:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::createNetworkingContext):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
  • WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:

(WebKit::WebFrameNetworkingContext::needsSiteSpecificQuirks):
(WebKit::WebFrameNetworkingContext::localFileContentSniffingEnabled):
(WebKit::WebFrameNetworkingContext::scheduledRunLoopPairs):
(WebKit::WebFrameNetworkingContext::blockedError):

  • WebProcess/WebCoreSupport/qt/WebFrameNetworkingContext.cpp: Added.

(WebCore::WebFrameNetworkingContext::WebFrameNetworkingContext):
(WebCore::WebFrameNetworkingContext::create):
(WebCore::WebFrameNetworkingContext::originatingObject):
(WebCore::WebFrameNetworkingContext::networkAccessManager):

  • WebProcess/WebCoreSupport/qt/WebFrameNetworkingContext.h: Added.
  • WebProcess/WebCoreSupport/win/WebFrameNetworkingContext.cpp: Added.
  • WebProcess/WebCoreSupport/win/WebFrameNetworkingContext.h: Added.

(WebFrameNetworkingContext::create):
(WebFrameNetworkingContext::WebFrameNetworkingContext):

  • win/WebKit2.vcproj:
  • win/WebKit2Common.vsprops:
05:31 Changeset [66793] by steveblock@google.com
  • 1 edit
    1 delete in trunk/LayoutTests

Unreviewed.

Remove platform/android/Skipped which was erroneously added in
http://trac.webkit.org/changeset/66251. Android does not use a Skipped list.

  • platform/android/Skipped: Removed.

09/03/10:

23:25 Changeset [66792] by loislo@chromium.org
  • 2 edits in trunk/LayoutTests

2010-09-03 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed.

Cleanup outdated entries in test_expectations.

BUGWK44996 WIN : inspector/report-API-errors.html = TEXT
BUGWK44996 WIN : inspector/report-protocol-errors.html = TEXT
BUGWK45184 WIN : inspector/elements-panel-xhtml-structure.xhtml = TIMEOUT

  • platform/chromium/test_expectations.txt:
21:25 Changeset [66791] by kinuko@chromium.org
  • 6 edits in trunk/WebCore

2010-09-03 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by Darin Adler.

V8/JS bindings should not perform type checks if the parameter has Callback attribute
https://bugs.webkit.org/show_bug.cgi?id=45143

No new tests, should not affect existing idls.

  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/scripts/test/JS/JSTestObj.cpp: (WebCore::jsTestObjPrototypeFunctionOverloadedMethod5): (WebCore::jsTestObjPrototypeFunctionOverloadedMethod):
  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/V8/V8TestObj.cpp: (WebCore::TestObjInternal::overloadedMethod5Callback): (WebCore::TestObjInternal::overloadedMethodCallback):
20:26 Changeset [66790] by weinig@apple.com
  • 1 edit in trunk/WebKit2/ChangeLog

Fix reviewer.

20:24 Changeset [66789] by weinig@apple.com
  • 12 edits in trunk/WebKit2

Add ability to send UserData to willSubmitForm
https://bugs.webkit.org/show_bug.cgi?id=45222

Reviewed by Adam Barth.

  • Adds a willSubmitForm callback to the BundlePageFormClient with an out parameter WKTypeRef* parameter.
  • That out parameter gets serialized and then passed to the PageFormClient's willSubmitForm, which now has WKTypeRef parameter.
  • Temporarily adds a new WillSubmitFormWithUserData message kind. This will be replaced by the ability to explicitly serialize null as a UserMessage.
  • Platform/CoreIPC/Arguments.h:

(CoreIPC::Arguments6::Arguments6):
(CoreIPC::Arguments6::encode):
(CoreIPC::Arguments6::decode):
(CoreIPC::In):
(CoreIPC::Out):

  • Shared/CoreIPCSupport/WebPageProxyMessageKinds.h:
  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebFormClient.cpp:

(WebKit::WebFormClient::willSubmitForm):

  • UIProcess/WebFormClient.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didReceiveMessage):
(WebKit::WebPageProxy::willSubmitForm):

  • UIProcess/WebPageProxy.h:
  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/InjectedBundle/InjectedBundlePageFormClient.cpp:

(WebKit::InjectedBundlePageFormClient::textFieldDidBeginEditing):
(WebKit::InjectedBundlePageFormClient::textFieldDidEndEditing):
(WebKit::InjectedBundlePageFormClient::textDidChangeInTextField):
(WebKit::InjectedBundlePageFormClient::textDidChangeInTextArea):
(WebKit::InjectedBundlePageFormClient::willSubmitForm):

  • WebProcess/InjectedBundle/InjectedBundlePageFormClient.h:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchWillSubmitForm):

19:54 Changeset [66788] by kbr@google.com
  • 2 edits in trunk/WebCore

2010-09-03 Kenneth Russell <kbr@google.com>

Unreviewed, Chromium build fix. Fix breakage on Windows after
r66787 / https://bugs.webkit.org/show_bug.cgi?id=45223 .

  • platform/graphics/chromium/FontChromiumWin.cpp: (WebCore::Font::drawGlyphs):
19:31 Changeset [66787] by jamesr@google.com
  • 3 edits in trunk/WebCore

2010-09-03 James Robinson <jamesr@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Text sometimes fails to display in accelerated 2d canvases
https://bugs.webkit.org/show_bug.cgi?id=45223

Calls PlatformContextSkia::prepareForSoftwareDraw() before drawing glyphs
using skia to ensure that the backing store state is consistent.

  • platform/graphics/chromium/FontChromiumWin.cpp: (WebCore::Font::drawGlyphs):
  • platform/graphics/chromium/FontLinux.cpp: (WebCore::Font::drawGlyphs):
18:40 Changeset [66786] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

Not reviewed, attempted layout test fix.

Report correct (unzoomed) image sizes for zoomed images.
https://bugs.webkit.org/show_bug.cgi?id=42089

  • fast/images/resources/oval.png: Tweak to try to avoid cryptic ImageIO errors.
18:24 Changeset [66785] by jamesr@google.com
  • 5 edits in trunk/WebCore

2010-09-03 Kenneth Russell <kbr@google.com>

Reviewed by Darin Fisher.

Add thirdparty directory and incorporate GLU tessellator
https://bugs.webkit.org/show_bug.cgi?id=44707

This directory is intended to contain copies of third-party libraries used
by WebCore, in particular those which may require some modification in
order to incorporate.

No tests at this time; these sources are being added in preparation for
incorporating other code which uses them, at which point the code will be
exercised and testable.

  • thirdparty: Added.
  • thirdparty/README.txt: Added.
  • thirdparty/glu: Added.
  • thirdparty/glu/LICENSE.txt: Added.
  • thirdparty/glu/README.webkit: Added.
  • thirdparty/glu/gluos.h: Added.
  • thirdparty/glu/internal_glu.h: Added.
  • thirdparty/glu/libtess: Added.
  • thirdparty/glu/libtess/GNUmakefile: Added.
  • thirdparty/glu/libtess/Imakefile: Added.
  • thirdparty/glu/libtess/README: Added.
  • thirdparty/glu/libtess/alg-outline: Added.
  • thirdparty/glu/libtess/dict-list.h: Added.
  • thirdparty/glu/libtess/dict.c: Added.
  • thirdparty/glu/libtess/dict.h: Added.
  • thirdparty/glu/libtess/geom.c: Added.
  • thirdparty/glu/libtess/geom.h: Added.
  • thirdparty/glu/libtess/memalloc.c: Added.
  • thirdparty/glu/libtess/memalloc.h: Added.
  • thirdparty/glu/libtess/mesh.c: Added.
  • thirdparty/glu/libtess/mesh.h: Added.
  • thirdparty/glu/libtess/normal.c: Added.
  • thirdparty/glu/libtess/normal.h: Added.
  • thirdparty/glu/libtess/priorityq-heap.c: Added.
  • thirdparty/glu/libtess/priorityq-heap.h: Added.
  • thirdparty/glu/libtess/priorityq-sort.h: Added.
  • thirdparty/glu/libtess/priorityq.c: Added.
  • thirdparty/glu/libtess/priorityq.h: Added.
  • thirdparty/glu/libtess/render.c: Added.
  • thirdparty/glu/libtess/render.h: Added.
  • thirdparty/glu/libtess/sweep.c: Added.
  • thirdparty/glu/libtess/sweep.h: Added.
  • thirdparty/glu/libtess/tess.c: Added.
  • thirdparty/glu/libtess/tess.h: Added.
  • thirdparty/glu/libtess/tessmono.c: Added.
  • thirdparty/glu/libtess/tessmono.h: Added.
18:19 Changeset [66784] by kbr@google.com
  • 1 edit
    36 adds in trunk/WebCore

2010-09-03 Kenneth Russell <kbr@google.com>

Reviewed by Darin Fisher.

Add thirdparty directory and incorporate GLU tessellator
https://bugs.webkit.org/show_bug.cgi?id=44707

This directory is intended to contain copies of third-party libraries used
by WebCore, in particular those which may require some modification in
order to incorporate.

No tests at this time; these sources are being added in preparation for
incorporating other code which uses them, at which point the code will be
exercised and testable.

  • thirdparty: Added.
  • thirdparty/README.txt: Added.
  • thirdparty/glu: Added.
  • thirdparty/glu/LICENSE.txt: Added.
  • thirdparty/glu/README.webkit: Added.
  • thirdparty/glu/gluos.h: Added.
  • thirdparty/glu/internal_glu.h: Added.
  • thirdparty/glu/libtess: Added.
  • thirdparty/glu/libtess/GNUmakefile: Added.
  • thirdparty/glu/libtess/Imakefile: Added.
  • thirdparty/glu/libtess/README: Added.
  • thirdparty/glu/libtess/alg-outline: Added.
  • thirdparty/glu/libtess/dict-list.h: Added.
  • thirdparty/glu/libtess/dict.c: Added.
  • thirdparty/glu/libtess/dict.h: Added.
  • thirdparty/glu/libtess/geom.c: Added.
  • thirdparty/glu/libtess/geom.h: Added.
  • thirdparty/glu/libtess/memalloc.c: Added.
  • thirdparty/glu/libtess/memalloc.h: Added.
  • thirdparty/glu/libtess/mesh.c: Added.
  • thirdparty/glu/libtess/mesh.h: Added.
  • thirdparty/glu/libtess/normal.c: Added.
  • thirdparty/glu/libtess/normal.h: Added.
  • thirdparty/glu/libtess/priorityq-heap.c: Added.
  • thirdparty/glu/libtess/priorityq-heap.h: Added.
  • thirdparty/glu/libtess/priorityq-sort.h: Added.
  • thirdparty/glu/libtess/priorityq.c: Added.
  • thirdparty/glu/libtess/priorityq.h: Added.
  • thirdparty/glu/libtess/render.c: Added.
  • thirdparty/glu/libtess/render.h: Added.
  • thirdparty/glu/libtess/sweep.c: Added.
  • thirdparty/glu/libtess/sweep.h: Added.
  • thirdparty/glu/libtess/tess.c: Added.
  • thirdparty/glu/libtess/tess.h: Added.
  • thirdparty/glu/libtess/tessmono.c: Added.
  • thirdparty/glu/libtess/tessmono.h: Added.
18:15 Changeset [66783] by jamesr@google.com
  • 7 edits
    1 delete in trunk/WebCore

2010-09-03 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r66781.
http://trac.webkit.org/changeset/66781
https://bugs.webkit.org/show_bug.cgi?id=45220

Breaks the build. Adds a mac-specific file to
platform/graphics without #if PLATFORM() guards and changes
the GraphicsContext3D interface without updating all
implementations (Requested by jamesr on #webkit).

  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • html/canvas/WebGLObject.cpp: (WebCore::WebGLObject::deleteObject):
  • platform/graphics/ANGLEWebKitBridge.h:
  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/GraphicsContext3DOpenGL.cpp: Removed.
  • platform/graphics/mac/GraphicsContext3DMac.mm: (WebCore::GraphicsContext3D::validateAttributes): (WebCore::GraphicsContext3D::makeContextCurrent): (WebCore::GraphicsContext3D::paintRenderingResultsToCanvas): (WebCore::GraphicsContext3D::reshape): (WebCore::ensureContext): (WebCore::GraphicsContext3D::prepareTexture): (WebCore::GraphicsContext3D::activeTexture): (WebCore::GraphicsContext3D::attachShader): (WebCore::GraphicsContext3D::bindAttribLocation): (WebCore::GraphicsContext3D::bindBuffer): (WebCore::GraphicsContext3D::bindFramebuffer): (WebCore::GraphicsContext3D::bindRenderbuffer): (WebCore::GraphicsContext3D::bindTexture): (WebCore::GraphicsContext3D::blendColor): (WebCore::GraphicsContext3D::blendEquation): (WebCore::GraphicsContext3D::blendEquationSeparate): (WebCore::GraphicsContext3D::blendFunc): (WebCore::GraphicsContext3D::blendFuncSeparate): (WebCore::GraphicsContext3D::bufferData): (WebCore::GraphicsContext3D::bufferSubData): (WebCore::GraphicsContext3D::checkFramebufferStatus): (WebCore::GraphicsContext3D::clearColor): (WebCore::GraphicsContext3D::clear): (WebCore::GraphicsContext3D::clearDepth): (WebCore::GraphicsContext3D::clearStencil): (WebCore::GraphicsContext3D::colorMask): (WebCore::GraphicsContext3D::compileShader): (WebCore::GraphicsContext3D::copyTexImage2D): (WebCore::GraphicsContext3D::copyTexSubImage2D): (WebCore::GraphicsContext3D::cullFace): (WebCore::GraphicsContext3D::depthFunc): (WebCore::GraphicsContext3D::depthMask): (WebCore::GraphicsContext3D::depthRange): (WebCore::GraphicsContext3D::detachShader): (WebCore::GraphicsContext3D::disable): (WebCore::GraphicsContext3D::disableVertexAttribArray): (WebCore::GraphicsContext3D::drawArrays): (WebCore::GraphicsContext3D::drawElements): (WebCore::GraphicsContext3D::enable): (WebCore::GraphicsContext3D::enableVertexAttribArray): (WebCore::GraphicsContext3D::finish): (WebCore::GraphicsContext3D::flush): (WebCore::GraphicsContext3D::framebufferRenderbuffer): (WebCore::GraphicsContext3D::framebufferTexture2D): (WebCore::GraphicsContext3D::frontFace): (WebCore::GraphicsContext3D::generateMipmap): (WebCore::GraphicsContext3D::getActiveAttrib): (WebCore::GraphicsContext3D::getActiveUniform): (WebCore::GraphicsContext3D::getAttachedShaders): (WebCore::GraphicsContext3D::getAttribLocation): (WebCore::GraphicsContext3D::getContextAttributes): (WebCore::GraphicsContext3D::getError): (WebCore::GraphicsContext3D::getString): (WebCore::GraphicsContext3D::hint): (WebCore::GraphicsContext3D::isBuffer): (WebCore::GraphicsContext3D::isEnabled): (WebCore::GraphicsContext3D::isFramebuffer): (WebCore::GraphicsContext3D::isProgram): (WebCore::GraphicsContext3D::isRenderbuffer): (WebCore::GraphicsContext3D::isShader): (WebCore::GraphicsContext3D::isTexture): (WebCore::GraphicsContext3D::lineWidth): (WebCore::GraphicsContext3D::linkProgram): (WebCore::GraphicsContext3D::pixelStorei): (WebCore::GraphicsContext3D::polygonOffset): (WebCore::GraphicsContext3D::readPixels): (WebCore::GraphicsContext3D::releaseShaderCompiler): (WebCore::GraphicsContext3D::renderbufferStorage): (WebCore::GraphicsContext3D::sampleCoverage): (WebCore::GraphicsContext3D::scissor): (WebCore::GraphicsContext3D::shaderSource): (WebCore::GraphicsContext3D::stencilFunc): (WebCore::GraphicsContext3D::stencilFuncSeparate): (WebCore::GraphicsContext3D::stencilMask): (WebCore::GraphicsContext3D::stencilMaskSeparate): (WebCore::GraphicsContext3D::stencilOp): (WebCore::GraphicsContext3D::stencilOpSeparate): (WebCore::GraphicsContext3D::texParameterf): (WebCore::GraphicsContext3D::texParameteri): (WebCore::GraphicsContext3D::uniform1f): (WebCore::GraphicsContext3D::uniform1fv): (WebCore::GraphicsContext3D::uniform2f): (WebCore::GraphicsContext3D::uniform2fv): (WebCore::GraphicsContext3D::uniform3f): (WebCore::GraphicsContext3D::uniform3fv): (WebCore::GraphicsContext3D::uniform4f): (WebCore::GraphicsContext3D::uniform4fv): (WebCore::GraphicsContext3D::uniform1i): (WebCore::GraphicsContext3D::uniform1iv): (WebCore::GraphicsContext3D::uniform2i): (WebCore::GraphicsContext3D::uniform2iv): (WebCore::GraphicsContext3D::uniform3i): (WebCore::GraphicsContext3D::uniform3iv): (WebCore::GraphicsContext3D::uniform4i): (WebCore::GraphicsContext3D::uniform4iv): (WebCore::GraphicsContext3D::uniformMatrix2fv): (WebCore::GraphicsContext3D::uniformMatrix3fv): (WebCore::GraphicsContext3D::uniformMatrix4fv): (WebCore::GraphicsContext3D::useProgram): (WebCore::GraphicsContext3D::validateProgram): (WebCore::GraphicsContext3D::vertexAttrib1f): (WebCore::GraphicsContext3D::vertexAttrib1fv): (WebCore::GraphicsContext3D::vertexAttrib2f): (WebCore::GraphicsContext3D::vertexAttrib2fv): (WebCore::GraphicsContext3D::vertexAttrib3f): (WebCore::GraphicsContext3D::vertexAttrib3fv): (WebCore::GraphicsContext3D::vertexAttrib4f): (WebCore::GraphicsContext3D::vertexAttrib4fv): (WebCore::GraphicsContext3D::vertexAttribPointer): (WebCore::GraphicsContext3D::viewport): (WebCore::GraphicsContext3D::getBooleanv): (WebCore::GraphicsContext3D::getBufferParameteriv): (WebCore::GraphicsContext3D::getFloatv): (WebCore::GraphicsContext3D::getFramebufferAttachmentParameteriv): (WebCore::GraphicsContext3D::getIntegerv): (WebCore::GraphicsContext3D::getProgramiv): (WebCore::GraphicsContext3D::getProgramInfoLog): (WebCore::GraphicsContext3D::getRenderbufferParameteriv): (WebCore::GraphicsContext3D::getShaderiv): (WebCore::GraphicsContext3D::getShaderInfoLog): (WebCore::GraphicsContext3D::getShaderSource): (WebCore::GraphicsContext3D::getTexParameterfv): (WebCore::GraphicsContext3D::getTexParameteriv): (WebCore::GraphicsContext3D::getUniformfv): (WebCore::GraphicsContext3D::getUniformiv): (WebCore::GraphicsContext3D::getUniformLocation): (WebCore::GraphicsContext3D::getVertexAttribfv): (WebCore::GraphicsContext3D::getVertexAttribiv): (WebCore::GraphicsContext3D::getVertexAttribOffset): (WebCore::GraphicsContext3D::texImage2D): (WebCore::GraphicsContext3D::texSubImage2D): (WebCore::GraphicsContext3D::createBuffer): (WebCore::GraphicsContext3D::createFramebuffer): (WebCore::GraphicsContext3D::createProgram): (WebCore::GraphicsContext3D::createRenderbuffer): (WebCore::GraphicsContext3D::createShader): (WebCore::GraphicsContext3D::createTexture): (WebCore::GraphicsContext3D::deleteBuffer): (WebCore::GraphicsContext3D::deleteFramebuffer): (WebCore::GraphicsContext3D::deleteProgram): (WebCore::GraphicsContext3D::deleteRenderbuffer): (WebCore::GraphicsContext3D::deleteShader): (WebCore::GraphicsContext3D::deleteTexture): (WebCore::GraphicsContext3D::sizeInBytes): (WebCore::GraphicsContext3D::synthesizeGLError):
17:58 Changeset [66782] by jamesr@google.com
  • 3 edits in trunk/WebCore

2010-09-03 James Robinson <jamesr@chromium.org>

Reviewed by Kenneth Russell.

Force 2d canvases to be rendered in software when the composite operation isn't source-over
https://bugs.webkit.org/show_bug.cgi?id=45216

The current accelerated 2d canvas implementation is very slow for composite operations other
than the default. This patch forces a canvas to be rendered in software if any other operation
is set until we accelerate the rest.

Tested by any of the fast/canvas tests that use a non-default globalCompositeOperation.

  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::setGlobalCompositeOperation):
  • platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::setSharedGraphicsContext3D):
17:49 Changeset [66781] by cmarrin@apple.com
  • 7 edits
    1 copy in trunk/WebCore

2010-09-03 Paul Sawaya <psawaya@apple.com>

Reviewed by Chris Marrin.

Refactored out Mac specific code for platform/graphics/mac/GraphicsContext3D.mm file.
Left general OpenGL code in platform/graphics/GraphicsContext3DOpenGL.cpp.
https://bugs.webkit.org/show_bug.cgi?id=30625

17:36 Changeset [66780] by commit-queue@webkit.org
  • 4 edits in trunk/WebCore

2010-09-03 James Robinson <jamesr@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Null out Canvas2DLayerChromium's back reference to DrawingBuffer on destruction
https://bugs.webkit.org/show_bug.cgi?id=45187

Canvas2DLayerChromium keeps a back reference to a DrawingBuffer. This has to be a raw pointer
because the DrawingBuffer holds a RefPtr to the Canvas2DLayerChromium. Since the layer can
outlive the buffer, this back reference has to be explicitly cleared when the DrawingBuffer
is destroyed.

  • platform/graphics/chromium/Canvas2DLayerChromium.cpp: (WebCore::Canvas2DLayerChromium::setDrawingBuffer):
  • platform/graphics/chromium/Canvas2DLayerChromium.h:
  • platform/graphics/chromium/DrawingBufferChromium.cpp: (WebCore::DrawingBuffer::~DrawingBuffer):
17:24 Changeset [66779] by kbr@google.com
  • 2 edits
    2 adds in trunk/WebCore

2010-09-03 Kenneth Russell <kbr@google.com>

Reviewed by Darin Fisher.

Add interval tree capable of holding plain old data (POD)
https://bugs.webkit.org/show_bug.cgi?id=45160

Adding an interval tree currently capable of holding types which
do not require their destructors to be called. POD is a slight
misnomer which will be corrected soon, hopefully by removing this
restriction.

This class is based on the augmentable property of the red/black
tree integrated under bug 45059.

Unit tests for the PODIntervalTree will be integrated separately
under bug 45161.

  • WebCore.gypi:
  • platform/graphics/gpu/PODInterval.h: Added. (WebCore::PODInterval::PODInterval): (WebCore::PODInterval::low): (WebCore::PODInterval::high): (WebCore::PODInterval::data): (WebCore::PODInterval::overlaps): (WebCore::PODInterval::operator<): (WebCore::PODInterval::operator==): (WebCore::PODInterval::maxHigh): (WebCore::PODInterval::setMaxHigh): (WebCore::PODInterval::toString):
  • platform/graphics/gpu/PODIntervalTree.h: Added. (WebCore::PODIntervalTree::PODIntervalTree): (WebCore::PODIntervalTree::allOverlaps): (WebCore::PODIntervalTree::createInterval): (WebCore::PODIntervalTree::checkInvariants): (WebCore::PODIntervalTree::init): (WebCore::PODIntervalTree::searchForOverlapsFrom): (WebCore::PODIntervalTree::updateNode): (WebCore::PODIntervalTree::checkInvariantsFromNode): (WebCore::valueToString):
16:40 Changeset [66778] by simon.fraser@apple.com
  • 2 edits in trunk/WebKitTools

2010-09-03 Simon Fraser <simon.fraser@apple.com>

Reviewed by Adam Roben.

Set project dependencies so that they build serially. This fixes
issues when running run-webkit-tests if DRT is not built yet.

  • DumpRenderTree/DumpRenderTree.sln:
16:24 Changeset [66777] by vangelis@chromium.org
  • 7 edits in trunk

2010-09-02 Vangelis Kokkevis <vangelis@chromium.org>

Reviewed by Darin Fisher.

[chromium] Revert to software compositing if the accelerated
compositor fails to initialize. If we tried to initialize the compositor
for this WebView and failed, next time the associated chrome client is
asked whether it can do accelerated compositing it will return false.
https://bugs.webkit.org/show_bug.cgi?id=45124


  • src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::allowsAcceleratedCompositing):
  • src/ChromeClientImpl.h:
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::WebViewImpl): (WebKit::WebViewImpl::paint): (WebKit::WebViewImpl::allowsAcceleratedCompositing): (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): (WebKit::WebViewImpl::getOnscreenGLES2Context):
  • src/WebViewImpl.h:

2010-09-02 Vangelis Kokkevis <vangelis@chromium.org>

Reviewed by Darin Fisher.

[chromium] Gracefully switch over to software compositing if the accelerated
compositor fails to initialize. LayerRendererChromium::create() will now return 0
if the GLES2Context passed to it is NULL or the LayerRendererChromium failed to initialize
hardware rendering.
https://bugs.webkit.org/show_bug.cgi?id=45124


Tested by forcing the creation of the gles2 context to fail and loading pages that normally trigger
the compositor.

  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::create): (WebCore::LayerRendererChromium::LayerRendererChromium): (WebCore::LayerRendererChromium::makeContextCurrent):
16:04 Changeset [66776] by commit-queue@webkit.org
  • 7 edits
    3 adds in trunk

2010-09-03 Peter Kasting <pkasting@google.com>

Reviewed by Simon Fraser.

Report correct (unzoomed) image sizes for zoomed images.
https://bugs.webkit.org/show_bug.cgi?id=42089

  • fast/images/resources/oval.png: Added.
  • fast/images/zoomed-img-size-expected.txt: Added.
  • fast/images/zoomed-img-size.html: Added.

2010-09-03 Peter Kasting <pkasting@google.com>

Reviewed by Simon Fraser.

Report correct (unzoomed) image sizes for zoomed images.
https://bugs.webkit.org/show_bug.cgi?id=42089

Test: fast/images/zoomed-img-size.html

  • css/CSSPrimitiveValue.cpp: Factor rounding code out to a templatized function so it can be shared. (WebCore::CSSPrimitiveValue::computeLengthInt): (WebCore::CSSPrimitiveValue::computeLengthIntForLength): (WebCore::CSSPrimitiveValue::computeLengthShort):
  • css/CSSPrimitiveValue.h: Factor rounding code out to a templatized function so it can be shared. (WebCore::roundForImpreciseConversion):
  • html/HTMLImageElement.cpp: Report unzoomed size to script that queries an image's width or height. (WebCore::HTMLImageElement::width): (WebCore::HTMLImageElement::height):
  • loader/ImageDocument.cpp: Report unzoomed size in the page title when viewing a standalone image. (WebCore::ImageDocumentParser::finish):
  • rendering/RenderObject.h: Use shared rounding code from CSSPrimitiveValue to compensate for inexactness in zoomed sizes. (WebCore::adjustForAbsoluteZoom):
15:56 Changeset [66775] by zmo@google.com
  • 2 edits in trunk/LayoutTests

2010-09-03 Zhenyao Mo <zmo@google.com>

Unreviewed.

Add flaky test inspector/dom-breakpoints.html to test_expectations.

  • platform/chromium/test_expectations.txt:
15:46 Changeset [66774] by abarth@webkit.org
  • 16 edits
    4 deletes in trunk/WebCore

2010-09-03 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r66770.
http://trac.webkit.org/changeset/66770
https://bugs.webkit.org/show_bug.cgi?id=45200

Broke Windows in a way I can't figure out now to fix
(Requested by abarth on #webkit).

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/generic/BindingDOMWindow.h: (WebCore::::completeURL):
  • bindings/generic/BindingFrame.h: Removed.
  • bindings/generic/BindingLocation.h: Removed.
  • bindings/generic/GenericBinding.h:
  • bindings/js/JSBinding.h: Removed.
  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/JSDOMBinding.cpp: (WebCore::shouldAllowNavigation): (WebCore::toLexicalFrame): (WebCore::toDynamicFrame): (WebCore::processingUserGesture): (WebCore::completeURL):
  • bindings/js/JSLocationCustom.cpp: (WebCore::navigateIfAllowed): (WebCore::JSLocation::replace):
  • bindings/js/specialization/JSBindingState.cpp: Removed.
  • bindings/js/specialization/JSBindingState.h: Removed.
  • bindings/v8/V8Binding.h:
  • bindings/v8/V8Utilities.cpp: (WebCore::completeURL): (WebCore::navigateIfAllowed):
  • bindings/v8/custom/V8LocationCustom.cpp: (WebCore::V8Location::replaceCallback):
  • bindings/v8/specialization/V8BindingState.cpp:
  • bindings/v8/specialization/V8BindingState.h:
14:59 Changeset [66773] by jianli@chromium.org
  • 7 edits in trunk

REGRESSION (r66452): Sending of multipart forms with files is broken.
https://bugs.webkit.org/show_bug.cgi?id=45159

Reviewed by Darin Adler.

WebCore:

  • platform/network/FormData.cpp:

(WebCore::FormData::appendKeyValuePairItems):

LayoutTests:

Updated related tests to include dumping content type.

  • http/tests/local/formdata/send-form-data-expected.txt:
  • http/tests/local/formdata/send-form-data-with-sliced-file-expected.txt:
  • http/tests/local/formdata/upload-events-expected.txt:
  • http/tests/xmlhttprequest/resources/multipart-post-echo.php:
14:54 Changeset [66772] by zmo@google.com
  • 2 edits in trunk/LayoutTests

2010-09-03 Zhenyao Mo <zmo@google.com>

Unreviewed.

Clean up the outdated entries in test_expectations.

  • platform/chromium/test_expectations.txt:
14:25 Changeset [66771] by crogers@google.com
  • 36 edits
    1 copy
    3 deletes in branches/audio/WebCore

audio branch: commit recent changes made to land patches in trunk

  • general cleanup
  • remove AudioConfig.h
  • rename AudioFloatBuffer.h to AudioBuffer.h and add more methods
  • FFTFrame cleanup: make FFTFrame.h expose the interface correctly (get rid of FFTFrameMac.h)
  • HRTF classes general cleanup
  • AudioPannerNode, Panner, PassThroughPanner, EqualPowerPanner cleanup
14:11 Changeset [66770] by commit-queue@webkit.org
  • 16 edits
    5 copies
    1 add in trunk/WebCore

2010-09-03 Dominic Cooney <dominicc@google.com>

Reviewed by Adam Barth.

Moves location.replace bindings logic into bindings/generic and
instantiates it for JSC and V8.

https://bugs.webkit.org/show_bug.cgi?id=44891

Covered by existing location.replace tests.

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/generic/BindingDOMWindow.h: (WebCore::::createWindow): (WebCore::::open):
  • bindings/generic/BindingFrame.h: Added. (WebCore::::navigateIfAllowed):
  • bindings/generic/BindingLocation.h: Added. (WebCore::::replace):
  • bindings/generic/GenericBinding.h: (WebCore::completeURL):
  • bindings/js/JSBinding.h: Added.
  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/JSDOMBinding.cpp: (WebCore::shouldAllowNavigation): (WebCore::toLexicalFrame): (WebCore::toDynamicFrame): (WebCore::processingUserGesture): (WebCore::completeURL):
  • bindings/js/JSLocationCustom.cpp: (WebCore::navigateIfAllowed): (WebCore::JSLocation::replace):
  • bindings/js/specialization/JSBindingState.cpp: Added. (WebCore::::getActiveFrame): (WebCore::::getFirstFrame): (WebCore::::processingUserGesture): (WebCore::::allowsAccessFromFrame):
  • bindings/js/specialization/JSBindingState.h: Added.
  • bindings/v8/V8Binding.h:
  • bindings/v8/V8Utilities.cpp: (WebCore::completeURL): (WebCore::navigateIfAllowed):
  • bindings/v8/custom/V8LocationCustom.cpp: (WebCore::V8Location::replaceCallback):
  • bindings/v8/specialization/V8BindingState.cpp: (WebCore::::allowsAccessFromFrame):
  • bindings/v8/specialization/V8BindingState.h:
13:53 Changeset [66769] by weinig@apple.com
  • 3 edits in trunk/WebKit2

Change WKDictionaryIsMutable to take a WKDictionaryRef instead of a WKMutableDictionaryRef.
If the type is already states it is mutable, there would be no reason for the check.

Reviewed by Gavin Barraclough.

  • UIProcess/API/C/WKMutableDictionary.cpp:

(WKDictionaryIsMutable):

  • UIProcess/API/C/WKMutableDictionary.h:
13:43 Changeset [66768] by dglazkov@chromium.org
  • 4 edits in trunk

2010-09-03 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Tony Chang.

[Chromium] Make sure that the width of the menu list is always constant under layout tests.
https://bugs.webkit.org/show_bug.cgi?id=45196

  • platform/chromium/drt_expectations.txt: Remove now-passing tests.

2010-09-03 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Tony Chang.

[Chromium] Make sure that the width of the menu list is always constant under layout tests.
https://bugs.webkit.org/show_bug.cgi?id=45196

  • rendering/RenderThemeChromiumWin.cpp: (WebCore::menuListButtonWidth): Added. (WebCore::RenderThemeChromiumWin::paintMenuList): Use menuListButtonWidth instead of always querying system metrics.
13:39 Changeset [66767] by aroben@apple.com
  • 2 edits in trunk/WebKit/win

Attempt to fixing Windows nightlies again

The fix in r66438 should be sufficient, but we have to touch
WebKit.idl to force that change to be picked up by the build.

  • Interfaces/WebKit.idl: Touched this file to force a build.
13:28 Changeset [66766] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2010-09-03 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed.

Added new expected result that wasn't committed in r66764.

  • editing/style/push-down-implicit-styles-around-list-expected.txt:
13:22 Changeset [66765] by commit-queue@webkit.org
  • 7 edits in trunk/WebCore

2010-09-03 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r66732.
http://trac.webkit.org/changeset/66732
https://bugs.webkit.org/show_bug.cgi?id=45195

the patch is not matched with general publish/subscribe scheme
implemented in the Inspector API (Requested by loislo on
#webkit).

  • inspector/CodeGeneratorInspector.pm:
  • inspector/Inspector.idl:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::pushChildNodesToFrontend): (WebCore::InspectorDOMAgent::getChildNodes):
  • inspector/InspectorDOMAgent.h:
  • inspector/front-end/DOMAgent.js: (WebInspector.DOMAgent.prototype.getChildNodesAsync.mycallback): (WebInspector.DOMAgent.prototype.getChildNodesAsync):
  • inspector/front-end/WorkersSidebarPane.js: (WebInspector.WorkersSidebarPane.prototype.reset):
13:08 Changeset [66764] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2010-09-03 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Tony Chang.

Fixed a test committed in r66743.

  • editing/style/script-tests/push-down-implicit-styles-around-list.js: (selectLastWord):
13:04 Changeset [66763] by jamesr@google.com
  • 2 edits in trunk/WebKit/chromium

2010-09-03 James Robinson <jamesr@chromium.org>

[chromium] Add one more include to fix the mac compile.

  • src/GraphicsContext3D.cpp:
12:48 Changeset [66762] by jamesr@google.com
  • 4 edits in trunk

2010-09-03 James Robinson <jamesr@chromium.org>

[chromium] Compile fixes for 66746

  • platform/graphics/gpu/SharedGraphicsContext3D.cpp: (WebCore::SharedGraphicsContext3D::texImage2D): (WebCore::SharedGraphicsContext3D::texSubImage2D):

2010-09-03 James Robinson <jamesr@chromium.org>

[chromium] Compile fixes for 66746.

  • src/GraphicsContext3D.cpp: (WebCore::GraphicsContext3DInternal::paintRenderingResultsToCanvas):
12:44 Changeset [66761] by dglazkov@chromium.org
  • 2 edits in trunk/WebKitTools

2010-09-03 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Adam Barth.

Fix reading configuraiton in NWRT to work on Windows.
https://bugs.webkit.org/show_bug.cgi?id=45180

  • Scripts/webkitpy/layout_tests/port/base.py: Added 'perl' argument, because Windows doesn't know what to do

with the file otherwise.

12:33 Changeset [66760] by mitz@apple.com
  • 2 edits in trunk/LayoutTests

[Qt] fast/text/decomposed-after-stacked-diacritics.html fails on Qt Linux
https://bugs.webkit.org/show_bug.cgi?id=45194

Rubber-stamped by Anders Carlsson.

  • platform/qt/Skipped: Skip fast/text/decomposed-after-stacked-diacritics.html
12:26 WebKit Team edited by zmo@google.com
(diff)
12:24 Changeset [66759] by crogers@google.com
  • 1 edit
    2 adds in trunk/WebCore

2010-09-03 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

Add AudioParam files
https://bugs.webkit.org/show_bug.cgi?id=44995

No new tests since audio API is not yet implemented.

  • webaudio: Added.
  • webaudio/AudioParam.h: Added. (WebCore::AudioParam::create): (WebCore::AudioParam::AudioParam): (WebCore::AudioParam::value): (WebCore::AudioParam::setValue): (WebCore::AudioParam::name): (WebCore::AudioParam::minValue): (WebCore::AudioParam::maxValue): (WebCore::AudioParam::defaultValue): (WebCore::AudioParam::units): (WebCore::AudioParam::smoothedValue): (WebCore::AudioParam::smooth): (WebCore::AudioParam::resetSmoothedValue): (WebCore::AudioParam::setSmoothingConstant):
  • webaudio/AudioParam.idl: Added.
12:19 Changeset [66758] by crogers@google.com
  • 1 edit
    2 adds in trunk/WebCore

2010-09-03 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

audio engine: add AudioChannel files
https://bugs.webkit.org/show_bug.cgi?id=44921

No new tests since audio API is not yet implemented.

  • platform/audio/AudioChannel.cpp: Added. (WebCore::AudioChannel::scale): (WebCore::AudioChannel::copyFrom): (WebCore::AudioChannel::copyFromRange): (WebCore::AudioChannel::sumFrom): (WebCore::AudioChannel::maxAbsValue):
  • platform/audio/AudioChannel.h: Added. (WebCore::AudioChannel::AudioChannel): (WebCore::AudioChannel::set): (WebCore::AudioChannel::length): (WebCore::AudioChannel::data): (WebCore::AudioChannel::zero):
12:16 Changeset [66757] by zmo@google.com
  • 2 edits in trunk/LayoutTests

2010-09-03 Zhenyao Mo <zmo@google.com>

Unreviewed.

Add failing test (in Chromium Linux) fast/text/decomposed-after-stacked-diacritics.html to test_expectations.

  • platform/chromium/test_expectations.txt:
12:14 Changeset [66756] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-09-03 Patrick Gansterer <paroga@paroga.com>

Reviewed by Adam Roben.

[WINCE] Remove usage of ce_textcodecs.h
https://bugs.webkit.org/show_bug.cgi?id=45169

ce_textcodecs.h was a non public header for (not required)
additonal codecs in the original Torch Mobile port.

  • platform/text/wince/TextCodecWinCE.cpp: (WebCore::LanguageManager::LanguageManager): (WebCore::decode):
12:10 Changeset [66755] by crogers@google.com
  • 1 edit
    3 adds in trunk/WebCore

2010-09-03 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

Initial patch for audio engine: AudioBus and helper classes
https://bugs.webkit.org/show_bug.cgi?id=34452

No new tests since audio API is not yet implemented.

  • platform/audio/AudioBus.cpp: Added. (WebCore::AudioBus::AudioBus): (WebCore::AudioBus::setChannelMemory): (WebCore::AudioBus::zero): (WebCore::AudioBus::channelByType): (WebCore::AudioBus::topologyMatches): (WebCore::AudioBus::createBufferFromRange): (WebCore::AudioBus::maxAbsValue): (WebCore::AudioBus::normalize): (WebCore::AudioBus::scale): (WebCore::AudioBus::copyFrom): (WebCore::AudioBus::sumFrom): (WebCore::AudioBus::processWithGainFromMonoStereo): (WebCore::AudioBus::processWithGainFrom): (WebCore::AudioBus::copyWithGainFrom): (WebCore::AudioBus::sumWithGainFrom):
  • platform/audio/AudioBus.h: Added. (WebCore::AudioBus::numberOfChannels): (WebCore::AudioBus::channel): (WebCore::AudioBus::length): (WebCore::AudioBus::sampleRate): (WebCore::AudioBus::setSampleRate): (WebCore::AudioBus::setGain): (WebCore::AudioBus::gain): (WebCore::AudioBus::reset): (WebCore::AudioBus::AudioBus):
  • platform/audio/AudioSourceProvider.h: Added. (WebCore::AudioSourceProvider::~AudioSourceProvider):
12:07 Changeset [66754] by zmo@google.com
  • 2 edits in trunk/LayoutTests

2010-09-03 Zhenyao Mo <zmo@google.com>

Unreviewed.

Add failing test (chromium linux) editing/style/push-down-implicit-styles-around-list.html to test_expectations.

  • platform/chromium/test_expectations.txt:
12:04 Changeset [66753] by crogers@google.com
  • 1 edit
    2 adds in trunk/WebCore

2010-09-03 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

Add Panner files
https://bugs.webkit.org/show_bug.cgi?id=45076

No new tests since audio API is not yet implemented.

  • platform/audio/Panner.cpp: Added. (WebCore::Panner::create):
  • platform/audio/Panner.h: Added. (WebCore::Panner::~Panner): (WebCore::Panner::panningModel): (WebCore::Panner::Panner):
12:03 Changeset [66752] by tony@chromium.org
  • 12 edits in trunk/WebKit/chromium

2010-09-03 Tony Chang <tony@chromium.org>

Unreviewed, remove svn:executable flag from images and css files.

  • src/js/Images/segmentChromium.png: Removed property svn:executable.
  • src/js/Images/segmentHoverChromium.png: Removed property svn:executable.
  • src/js/Images/segmentHoverEndChromium.png: Removed property svn:executable.
  • src/js/Images/segmentSelectedChromium.png: Removed property svn:executable.
  • src/js/Images/segmentSelectedEndChromium.png: Removed property svn:executable.
  • src/js/Images/statusbarBackgroundChromium.png: Removed property svn:executable.
  • src/js/Images/statusbarBottomBackgroundChromium.png: Removed property svn:executable.
  • src/js/Images/statusbarButtonsChromium.png: Removed property svn:executable.
  • src/js/Images/statusbarMenuButtonChromium.png: Removed property svn:executable.
  • src/js/Images/statusbarMenuButtonSelectedChromium.png: Removed property svn:executable.
  • src/js/devTools.css: Removed property svn:executable.
11:57 Changeset [66751] by crogers@google.com
  • 2 edits in trunk/WebKitTools

2010-09-03 Chris Rogers <crogers@google.com>

Unreviewed

Add myself to the committers list
https://bugs.webkit.org/show_bug.cgi?id=45189

  • Scripts/webkitpy/common/config/committers.py:
11:51 Changeset [66750] by crogers@google.com
  • 1 edit
    3 adds in trunk/WebCore

2010-09-03 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

Add AudioListener files
https://bugs.webkit.org/show_bug.cgi?id=45006

No new tests since audio API is not yet implemented.

  • webaudio: Added.
  • webaudio/AudioListener.cpp: Added. (WebCore::AudioListener::AudioListener):
  • webaudio/AudioListener.h: Added. (WebCore::AudioListener::create): (WebCore::AudioListener::setPosition): (WebCore::AudioListener::position): (WebCore::AudioListener::setOrientation): (WebCore::AudioListener::orientation): (WebCore::AudioListener::setUpVector): (WebCore::AudioListener::upVector): (WebCore::AudioListener::setVelocity): (WebCore::AudioListener::velocity): (WebCore::AudioListener::setDopplerFactor): (WebCore::AudioListener::dopplerFactor): (WebCore::AudioListener::setSpeedOfSound): (WebCore::AudioListener::speedOfSound):
  • webaudio/AudioListener.idl: Added.
11:50 Changeset [66749] by caseq@chromium.org
  • 1 edit in trunk/LayoutTests/ChangeLog

Unreviewed. Updated LayoutTests/ChangeLog to include more detailed description for r66735.

11:46 Changeset [66748] by crogers@google.com
  • 1 edit
    2 adds in trunk/WebCore

2010-09-03 Chris Rogers <crogers@google.com>

Unreviewed

Add WebCore/webaudio and WebCore/platform/audio/mac directories in preparation for landing reviewed patches
https://bugs.webkit.org/show_bug.cgi?id=45185

  • platform/audio/mac: Added.
  • webaudio: Added.
11:46 Changeset [66747] by zmo@google.com
  • 2 edits in trunk/LayoutTests

2010-09-03 Zhenyao Mo <zmo@google.com>

Uneviewed.

Add TIMEOUT test inspector/elements-panel-xhtml-structure.xhtml to chromium test_expectations.

  • platform/chromium/test_expectations.txt:
11:38 Changeset [66746] by jamesr@google.com
  • 31 edits
    3 copies
    6 adds in trunk

2010-09-03 James Robinson <jamesr@chromium.org>

Reviewed by Chris Marrin.

Multiple accelerated 2D canvases should be able to use the same GraphicsContext3D
https://bugs.webkit.org/show_bug.cgi?id=44926

This allows many accelerated 2d canvases to render using a single underlying GraphicsContext3D.
It introduces a new class SharedGraphicsContext3D that manages several callers. This class could
also cache the current state to avoid issuing redundant calls, although in this first cut it doesn't.
The SharedGraphicsContext3D is provided through the ChromeClient so that its lifetime can be tied to that
of the platform-specific compositor infrastructure.

Accelerated 2d canvases maintain a reference to a SharedGraphicsContext3D and have ownership of a CanvasFramebuffer,
which represents the canvas's rendering target. The compositing layer for an accelerated 2d canvas is
aware only of the canvas's CanvasFramebuffer. This means that WebGL and 2d canvases are no longer treated
as the same time of layer by the compositor.

Covered by existing canvas tests.

  • WebCore.gypi:
  • html/canvas/CanvasRenderingContext.cpp:
  • html/canvas/CanvasRenderingContext.h: (WebCore::CanvasRenderingContext::paintsIntoCanvasBuffer): (WebCore::CanvasRenderingContext::platformLayer):
  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::CanvasRenderingContext2D): (WebCore::CanvasRenderingContext2D::paintsIntoCanvasBuffer): (WebCore::CanvasRenderingContext2D::reset): (WebCore::CanvasRenderingContext2D::didDraw): (WebCore::CanvasRenderingContext2D::platformLayer):
  • html/canvas/CanvasRenderingContext2D.h:
  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::paintsIntoCanvasBuffer):
  • html/canvas/WebGLRenderingContext.h: (WebCore::WebGLRenderingContext::graphicsContext3D): (WebCore::WebGLRenderingContext::platformLayer):
  • loader/EmptyClients.h: (WebCore::EmptyChromeClient::attachRootGraphicsLayer): (WebCore::EmptyChromeClient::setNeedsOneShotDrawingSynchronization): (WebCore::EmptyChromeClient::scheduleCompositingLayerSync):
  • page/ChromeClient.h: (WebCore::ChromeClient::getSharedGraphicsContext3D):
  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::setSharedGraphicsContext3D): (WebCore::GraphicsContext::syncSoftwareCanvas):
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/chromium/Canvas2DLayerChromium.cpp: Added. (WebCore::Canvas2DLayerChromium::create): (WebCore::Canvas2DLayerChromium::Canvas2DLayerChromium): (WebCore::Canvas2DLayerChromium::~Canvas2DLayerChromium): (WebCore::Canvas2DLayerChromium::updateContents): (WebCore::Canvas2DLayerChromium::setTextureChanged): (WebCore::Canvas2DLayerChromium::textureId):
  • platform/graphics/chromium/Canvas2DLayerChromium.h: Added. (WebCore::Canvas2DLayerChromium::drawsContent):
  • platform/graphics/chromium/CanvasLayerChromium.cpp: (WebCore::CanvasLayerChromium::CanvasLayerChromium): (WebCore::CanvasLayerChromium::~CanvasLayerChromium): (WebCore::CanvasLayerChromium::draw):
  • platform/graphics/chromium/CanvasLayerChromium.h:
  • platform/graphics/chromium/DrawingBufferChromium.cpp: Added. (WebCore::generateColorTexture): (WebCore::DrawingBuffer::DrawingBuffer): (WebCore::DrawingBuffer::~DrawingBuffer): (WebCore::DrawingBuffer::publishToPlatformLayer): (WebCore::DrawingBuffer::reset): (WebCore::DrawingBuffer::platformLayer):
  • platform/graphics/chromium/GLES2Canvas.cpp: (WebCore::GLES2Canvas::GLES2Canvas): (WebCore::GLES2Canvas::~GLES2Canvas): (WebCore::GLES2Canvas::bindFramebuffer): (WebCore::GLES2Canvas::clearRect): (WebCore::GLES2Canvas::fillRect): (WebCore::GLES2Canvas::drawTexturedRect): (WebCore::GLES2Canvas::drawTexturedRectTile): (WebCore::GLES2Canvas::drawQuad): (WebCore::GLES2Canvas::createTexture): (WebCore::GLES2Canvas::getTexture):
  • platform/graphics/chromium/GLES2Canvas.h: (WebCore::GLES2Canvas::context): (WebCore::GLES2Canvas::drawingBuffer):
  • platform/graphics/chromium/GraphicsLayerChromium.cpp: (WebCore::GraphicsLayerChromium::setContentsToCanvas):
  • platform/graphics/chromium/GraphicsLayerChromium.h:
  • platform/graphics/chromium/WebGLLayerChromium.cpp: Added. (WebCore::WebGLLayerChromium::create): (WebCore::WebGLLayerChromium::WebGLLayerChromium): (WebCore::WebGLLayerChromium::updateContents): (WebCore::WebGLLayerChromium::setContext):
  • platform/graphics/chromium/WebGLLayerChromium.h: Added. (WebCore::WebGLLayerChromium::drawsContent):
  • platform/graphics/gpu/DrawingBuffer.cpp: Added. (WebCore::DrawingBuffer::create): (WebCore::DrawingBuffer::bind): (WebCore::DrawingBuffer::setWillPublishCallback):
  • platform/graphics/gpu/DrawingBuffer.h: Added. (WebCore::DrawingBuffer::size):
  • platform/graphics/gpu/SharedGraphicsContext3D.cpp: Added. (WebCore::SharedGraphicsContext3D::create): (WebCore::SharedGraphicsContext3D::SharedGraphicsContext3D): (WebCore::SharedGraphicsContext3D::~SharedGraphicsContext3D): (WebCore::SharedGraphicsContext3D::makeContextCurrent): (WebCore::SharedGraphicsContext3D::scissor): (WebCore::SharedGraphicsContext3D::enable): (WebCore::SharedGraphicsContext3D::disable): (WebCore::SharedGraphicsContext3D::clearColor): (WebCore::SharedGraphicsContext3D::clear): (WebCore::SharedGraphicsContext3D::drawArrays): (WebCore::SharedGraphicsContext3D::getError): (WebCore::SharedGraphicsContext3D::getIntegerv): (WebCore::SharedGraphicsContext3D::createFramebuffer): (WebCore::SharedGraphicsContext3D::createTexture): (WebCore::SharedGraphicsContext3D::deleteFramebuffer): (WebCore::SharedGraphicsContext3D::deleteTexture): (WebCore::SharedGraphicsContext3D::framebufferTexture2D): (WebCore::SharedGraphicsContext3D::texParameteri): (WebCore::SharedGraphicsContext3D::texImage2D): (WebCore::SharedGraphicsContext3D::texSubImage2D): (WebCore::SharedGraphicsContext3D::readPixels): (WebCore::SharedGraphicsContext3D::supportsBGRA): (WebCore::SharedGraphicsContext3D::getTexture): (WebCore::SharedGraphicsContext3D::applyCompositeOperator): (WebCore::SharedGraphicsContext3D::useQuadVertices): (WebCore::SharedGraphicsContext3D::setActiveTexture): (WebCore::SharedGraphicsContext3D::bindTexture): (WebCore::SharedGraphicsContext3D::useFillSolidProgram): (WebCore::SharedGraphicsContext3D::useTextureProgram): (WebCore::SharedGraphicsContext3D::bindFramebuffer): (WebCore::SharedGraphicsContext3D::setViewport): (WebCore::SharedGraphicsContext3D::paintsIntoCanvasBuffer):
  • platform/graphics/gpu/SharedGraphicsContext3D.h: Added.
  • platform/graphics/gpu/Texture.cpp:
  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::syncSoftwareCanvas): (WebCore::GraphicsContext::setSharedGraphicsContext3D):
  • platform/graphics/skia/ImageSkia.cpp:
  • platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::~PlatformContextSkia): (WebCore::WillPublishCallbackImpl::create): (WebCore::WillPublishCallbackImpl::willPublish): (WebCore::WillPublishCallbackImpl::WillPublishCallbackImpl): (WebCore::PlatformContextSkia::setSharedGraphicsContext3D): (WebCore::PlatformContextSkia::uploadSoftwareToHardware): (WebCore::PlatformContextSkia::readbackHardwareToSoftware):
  • platform/graphics/skia/PlatformContextSkia.h:
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration):

2010-09-03 James Robinson <jamesr@chromium.org>

Reviewed by Chris Marrin.

Multiple accelerated 2D canvases should be able to use the same GraphicsContext3D
https://bugs.webkit.org/show_bug.cgi?id=44926

Adds a SharedContext3D to WebViewImpl. The SharedContext3D has to live on WebViewImpl to be
tied to the lifetime of the compositor context.

  • src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::getSharedGraphicsContext3D):
  • src/ChromeClientImpl.h:
  • src/GraphicsContext3D.cpp: (WebCore::GraphicsContext3DInternal::initialize): (WebCore::GraphicsContext3DInternal::platformLayer): (WebCore::GraphicsContext3D::platformLayer):
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::getSharedGraphicsContext3D):
  • src/WebViewImpl.h:
11:32 Changeset [66745] by crogers@google.com
  • 1 edit
    2 adds in trunk/WebCore

2010-09-03 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

Add audio distance effect files
https://bugs.webkit.org/show_bug.cgi?id=44705

No new tests since audio API is not yet implemented.

  • platform/audio/Distance.cpp: Added. (WebCore::DistanceEffect::DistanceEffect): (WebCore::DistanceEffect::gain): (WebCore::DistanceEffect::linearGain): (WebCore::DistanceEffect::inverseGain): (WebCore::DistanceEffect::exponentialGain):
  • platform/audio/Distance.h: Added. (WebCore::DistanceEffect::model): (WebCore::DistanceEffect::setModel): (WebCore::DistanceEffect::setRefDistance): (WebCore::DistanceEffect::setMaxDistance): (WebCore::DistanceEffect::setRolloffFactor): (WebCore::DistanceEffect::refDistance): (WebCore::DistanceEffect::maxDistance): (WebCore::DistanceEffect::rolloffFactor):
11:31 Changeset [66744] by zmo@google.com
  • 1 edit
    20 adds in trunk/LayoutTests

2010-09-03 Zhenyao Mo <zmo@google.com>

Unreviewed.

Rebaseline after r66731.

  • platform/chromium-linux/svg/custom/mouse-move-on-svg-container-expected.checksum: Added.
  • platform/chromium-linux/svg/custom/mouse-move-on-svg-container-expected.txt: Added.
  • platform/chromium-linux/svg/custom/mouse-move-on-svg-container-standalone-expected.checksum: Added.
  • platform/chromium-linux/svg/custom/mouse-move-on-svg-container-standalone-expected.txt: Added.
  • platform/chromium-linux/svg/custom/mouse-move-on-svg-root-expected.checksum: Added.
  • platform/chromium-linux/svg/custom/mouse-move-on-svg-root-expected.txt: Added.
  • platform/chromium-linux/svg/custom/mouse-move-on-svg-root-standalone-expected.checksum: Added.
  • platform/chromium-linux/svg/custom/mouse-move-on-svg-root-standalone-expected.txt: Added.
  • platform/chromium-win/svg/custom/mouse-move-on-svg-container-expected.checksum: Added.
  • platform/chromium-win/svg/custom/mouse-move-on-svg-container-expected.png: Added.
  • platform/chromium-win/svg/custom/mouse-move-on-svg-container-expected.txt: Added.
  • platform/chromium-win/svg/custom/mouse-move-on-svg-container-standalone-expected.checksum: Added.
  • platform/chromium-win/svg/custom/mouse-move-on-svg-container-standalone-expected.png: Added.
  • platform/chromium-win/svg/custom/mouse-move-on-svg-container-standalone-expected.txt: Added.
  • platform/chromium-win/svg/custom/mouse-move-on-svg-root-expected.checksum: Added.
  • platform/chromium-win/svg/custom/mouse-move-on-svg-root-expected.png: Added.
  • platform/chromium-win/svg/custom/mouse-move-on-svg-root-expected.txt: Added.
  • platform/chromium-win/svg/custom/mouse-move-on-svg-root-standalone-expected.checksum: Added.
  • platform/chromium-win/svg/custom/mouse-move-on-svg-root-standalone-expected.png: Added.
  • platform/chromium-win/svg/custom/mouse-move-on-svg-root-standalone-expected.txt: Added.
11:21 Changeset [66743] by rniwa@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

2010-09-03 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Kent Tamura.

Can't unbold bolded list item when list is surrounded by <b> tag
https://bugs.webkit.org/show_bug.cgi?id=25086

Added a regression test for the bug because the bug has been fixed by http://trac.webkit.org/changeset/66324.
The test ensures WebKit removes implicitly styled element such as b around list element
when style is toggled inside the list.

  • editing/style/push-down-implicit-styles-around-list-expected.txt: Added.
  • editing/style/push-down-implicit-styles-around-list.html: Added.
  • editing/style/script-tests/push-down-implicit-styles-around-list.js: Added. (testSingleToggle): (selectAll): (selectTest): (selectFirstWord): (selectSecondWord): (selectLastTwoWords):
11:21 Changeset [66742] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-09-03 Johnny Ding <jnd@chromium.org>

Reviewed by Adam Barth.

Save the gesture state to track the user gesture state across async form submission.
https://bugs.webkit.org/show_bug.cgi?id=44969

fast/events/popup-blocked-to-post-blank.html can cover the test in WebKit.
A UI test will be added in chromium to address chromium's bug.

  • loader/RedirectScheduler.cpp: (WebCore::ScheduledFormSubmission::ScheduledFormSubmission): (WebCore::ScheduledFormSubmission::fire): (WebCore::RedirectScheduler::scheduleFormSubmission):
11:02 Changeset [66741] by ap@apple.com
  • 2 edits in trunk/JavaScriptCore

2010-09-03 Alexey Proskuryakov <ap@apple.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=45135
<rdar://problem/7823714> TCMalloc_PageHeap doesn't hold a mutex while manipulating shared data

  • wtf/FastMalloc.cpp: (WTF::TCMalloc_PageHeap::initializeScavenger): Make sure to create a non-recursive mutex regardless of platform default, so that we can assert that it's held (this is for platforms that don't have libdispatch). (WTF::TCMalloc_PageHeap::signalScavenger): Assert that the mutex is held, so we can look at m_scavengeThreadActive. For platforms that have libdispatch, assert that pageheap_lock is held. (WTF::TCMalloc_PageHeap::periodicScavenge): Make sure that pageheap_lock is held before manipulating m_scavengeThreadActive. Otherwise, there is an obvious race condition, and we can make unbalanced calls to dispatch_resume().
10:56 Changeset [66740] by mitz@apple.com
  • 3 edits
    2 adds in trunk

2010-09-03 Dan Bernstein <mitz@apple.com>

Reviewed by Anders Carlsson.

<rdar://problem/8392655> REGRESSION (r57215): Decomposed diacritics render incorrectly when preceded by stacked diacritics
https://bugs.webkit.org/show_bug.cgi?id=45182

Test: fast/text/decomposed-after-stacked-diacritics.html

  • platform/graphics/Font.cpp: (WebCore::Font::codePath): Do not bail out if the run contains stacked diacritics, since it may also contain characters that require the complex text code path.

2010-09-03 Dan Bernstein <mitz@apple.com>

Reviewed by Anders Carlsson.

<rdar://problem/8392655> REGRESSION (r57215): Decomposed diacritics render incorrectly when preceded by stacked diacritics
https://bugs.webkit.org/show_bug.cgi?id=45182

  • fast/text/decomposed-after-stacked-diacritics-expected.txt: Added.
  • fast/text/decomposed-after-stacked-diacritics.html: Added.
10:42 Changeset [66739] by mnaganov@chromium.org
  • 6 edits
    1 add in trunk/WebCore

2010-09-03 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Cleanup after r66117 - extract heap snapshot
view styles into a dedicated .css

https://bugs.webkit.org/show_bug.cgi?id=45178

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/heapProfiler.css: Added. (.heap-snapshot-sidebar-tree-item .icon): (.heap-snapshot-sidebar-tree-item.small .icon): (.heap-snapshot-view): (.heap-snapshot-view.visible): (.heap-snapshot-view .data-grid): (.heap-snapshot-view .data-grid th.count-column): (.heap-snapshot-view .data-grid td.count-column): (.heap-snapshot-view .data-grid th.size-column): (.heap-snapshot-view .data-grid td.size-column): (.heap-snapshot-view .data-grid th.countDelta-column): (.heap-snapshot-view .data-grid td.countDelta-column): (.heap-snapshot-view .data-grid th.sizeDelta-column): (.heap-snapshot-view .data-grid td.sizeDelta-column): (#heap-snapshot-summary-container): (.heap-snapshot-summary): (.heap-snapshot-summary canvas.summary-graph): (.heap-snapshot-summary-label):
  • inspector/front-end/inspector.css:
  • inspector/front-end/inspector.html:
10:07 Changeset [66738] by demarchi@webkit.org
  • 7 edits
    1 move in trunk

2010-09-03 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Reviewed by Martin Robinson.

[EFL] Regression (66531) Build break with Glib Support
https://bugs.webkit.org/show_bug.cgi?id=45011

Move GtkTypedefs.h to GTypedefs.h and let it inside gobject directory
since when glib is enabled, EFL port needs it, too.

  • CMakeListsEfl.txt: Include gobject directory to find new header file.
  • GNUmakefile.am: Ditto.
  • wtf/CMakeListsEfl.txt: Ditto.
  • wtf/Platform.h: Include header if port is EFL and glib support is enabled.
  • wtf/gtk/GtkTypedefs.h: Removed.
  • wtf/gobject/GTypedefs.h: Added. Sections specific to GTK are now guarded by PLATFORM(GTK).

2010-09-03 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Reviewed by Martin Robinson.

[EFL] Regression (66531) Build break with Glib Support
https://bugs.webkit.org/show_bug.cgi?id=45011

Move GtkTypedefs.h to GTypedefs.h and let it inside gobject directory
since when glib is enabled, EFL port needs it, too.

  • CMakeListsEfl.txt: Include gobject directory to find new header file.
09:56 Changeset [66737] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

2010-09-03 Mihai Parparita <mihaip@chromium.org>

Reviewed by Tony Chang.

play-state.html and suspend-resume-animaton.html now pass on Chromium
https://bugs.webkit.org/show_bug.cgi?id=45158

Two animation tests now pass reliably with both test_shell and Chromium
DRT due to r66641 and http://crrev.com/58369.

  • platform/chromium/drt_expectations.txt:
  • platform/chromium/test_expectations.txt:
09:15 Changeset [66736] by jchaffraix@webkit.org
  • 2 edits in trunk/WebCore

[GTK] compilation issue with JSTimeRanges when video turned off
https://bugs.webkit.org/show_bug.cgi?id=44249

Patch by Zaheer Ahmad <zaheer.mot@gmail.com> on 2010-09-03
Reviewed by Darin Adler.

Move the JSTimeRanges outside ENABLE_VIDEO in GNUMakefile.am

  • WebCore/GNUMakefile.am
09:00 Changeset [66735] by caseq@chromium.org
  • 10 edits
    1 add
    3 deletes in trunk

2010-09-03 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Yury Semikhatsky.

http/tests/inspector/console-xhr-logging.html and http/tests/inspector/resource-har-conversion.html are failing on chromium win bot
Changed MIME type for .js to application/x-javascript for consistency with apache used on other platforms.
https://bugs.webkit.org/show_bug.cgi?id=45137

  • Scripts/webkitpy/layout_tests/port/lighttpd.conf:

2010-09-03 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Yury Semikhatsky.

http/tests/inspector/console-xhr-logging.html and http/tests/inspector/resource-har-conversion.html are failing on chromium win bot
Use CGI as target for POST request to prevent HTTP 405 on certain platforms.
Changed MIME type for .js to application/x-javascript in lighttpd.conf for
consistency with apache used on other platforms.
https://bugs.webkit.org/show_bug.cgi?id=45137

  • http/tests/inspector/console-xhr-logging-expected.txt:
  • http/tests/inspector/console-xhr-logging.html:
  • http/tests/inspector/resource-har-conversion-expected.txt:
  • http/tests/inspector/resource-har-conversion.html:
  • http/tests/inspector/resource-parameters-expected.txt:
  • http/tests/inspector/resource-parameters.html:
  • http/tests/inspector/resources/post-target.cgi: Added.
  • platform/chromium-win/http/tests/inspector/resource-parameters-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
  • platform/win/http/tests/inspector/console-xhr-logging-expected.txt: Removed.
  • platform/win/http/tests/inspector/resource-parameters-expected.txt: Removed.
08:56 Changeset [66734] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit/efl

2010-09-03 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Reviewed by Antonio Gomes.

[EFL] Install default theme
https://bugs.webkit.org/show_bug.cgi?id=45154

Since a theme is needed in order to create a new browser, install the
default one to serve as example and fall-back.

  • CMakeListsEfl.txt:
08:29 Changeset [66733] by sullivan@apple.com
  • 2 edits in trunk/WebKit/mac

https://bugs.webkit.org/show_bug.cgi?id=45175
[WebView unmarkAllTextMatches] will crash if the webview is already closed

Reviewed by Dan Bernstein.

Made this and related methods robust against being called when the WebView is closed.

  • WebView/WebView.mm:

(-[WebView markAllMatchesForText:caseSensitive:highlight:limit:]):
Bail out if the WebView is closed.
(-[WebView countMatchesForText:caseSensitive:highlight:limit:markMatches:]):
Ditto.
(-[WebView unmarkAllTextMatches]):
Ditto.
(-[WebView rectsForTextMatches]):
Ditto.

08:17 Changeset [66732] by loislo@chromium.org
  • 7 edits in trunk/WebCore

2010-09-03 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: cleanup inspector api. getChildNodes should return array of child nodes as an output value.

The current implementation of the inspector api has some unnecessary complexity.
As example WebInspector is requesting child nodes of a node by getChildNodes
but DOM agent is actually pushing the child nodes via setChildNodes event call and
send back an empty response message.

https://bugs.webkit.org/show_bug.cgi?id=45172

  • inspector/CodeGeneratorInspector.pm:
  • inspector/Inspector.idl:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::getChildNodesArray): (WebCore::InspectorDOMAgent::pushChildNodesToFrontend): (WebCore::InspectorDOMAgent::getChildNodes):
  • inspector/InspectorDOMAgent.h:
  • inspector/front-end/DOMAgent.js: (WebInspector.DOMAgent.prototype.getChildNodesAsync.mycallback): (WebInspector.DOMAgent.prototype.getChildNodesAsync):
  • inspector/front-end/WorkersSidebarPane.js: (WebInspector.WorkersSidebarPane.prototype.reset):
07:26 Changeset [66731] by zimmermann@webkit.org
  • 3 edits
    16 adds in trunk

2010-09-03 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

SVG atlas map slider doesn't work properly
https://bugs.webkit.org/show_bug.cgi?id=45107

SVG 1.1 2nd edition relaxes hit testing rules. The outermost <svg> should react
to mouse events, in standalone and compound documents, if the mouse location is
within the intrinsic boundaries of the <svg> element.

Tests: svg/custom/mouse-move-on-svg-container-standalone.svg

svg/custom/mouse-move-on-svg-container.xhtml
svg/custom/mouse-move-on-svg-root-standalone.svg
svg/custom/mouse-move-on-svg-root.xhtml

  • rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::nodeAtPoint):

2010-09-03 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

SVG atlas map slider doesn't work properly
https://bugs.webkit.org/show_bug.cgi?id=45107

  • platform/mac/svg/custom/mouse-move-on-svg-container-expected.checksum: Added.
  • platform/mac/svg/custom/mouse-move-on-svg-container-expected.png: Added.
  • platform/mac/svg/custom/mouse-move-on-svg-container-expected.txt: Added.
  • platform/mac/svg/custom/mouse-move-on-svg-container-standalone-expected.checksum: Added.
  • platform/mac/svg/custom/mouse-move-on-svg-container-standalone-expected.png: Added.
  • platform/mac/svg/custom/mouse-move-on-svg-container-standalone-expected.txt: Added.
  • platform/mac/svg/custom/mouse-move-on-svg-root-expected.checksum: Added.
  • platform/mac/svg/custom/mouse-move-on-svg-root-expected.png: Added.
  • platform/mac/svg/custom/mouse-move-on-svg-root-expected.txt: Added.
  • platform/mac/svg/custom/mouse-move-on-svg-root-standalone-expected.checksum: Added.
  • platform/mac/svg/custom/mouse-move-on-svg-root-standalone-expected.png: Added.
  • platform/mac/svg/custom/mouse-move-on-svg-root-standalone-expected.txt: Added.
  • svg/custom/mouse-move-on-svg-container-standalone.svg: Added.
  • svg/custom/mouse-move-on-svg-container.xhtml: Added.
  • svg/custom/mouse-move-on-svg-root-standalone.svg: Added.
  • svg/custom/mouse-move-on-svg-root.xhtml: Added.
07:01 Changeset [66730] by commit-queue@webkit.org
  • 16 edits in trunk

2010-09-03 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: provide more information to front-end when breaking on DOM event
https://bugs.webkit.org/show_bug.cgi?id=44679

  • http/tests/inspector/debugger-test2.js: (initialize_DebuggerTest.InspectorTest._pausedScript):

2010-09-03 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: provide more information to front-end when breaking on DOM event
https://bugs.webkit.org/show_bug.cgi?id=44679

  • dom/ContainerNode.cpp: (WebCore::ContainerNode::insertBefore): (WebCore::ContainerNode::parserInsertBefore): (WebCore::ContainerNode::replaceChild): (WebCore::ContainerNode::appendChild): (WebCore::ContainerNode::parserAddChild): (WebCore::notifyChildInserted): (WebCore::dispatchChildRemovalEvents):
  • dom/Element.cpp: (WebCore::Element::setAttribute): (WebCore::Element::removeAttribute):
  • inspector/Inspector.idl:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::willInsertDOMNodeImpl): (WebCore::InspectorController::didInsertDOMNodeImpl): (WebCore::InspectorController::willRemoveDOMNodeImpl): (WebCore::InspectorController::didRemoveDOMNodeImpl): (WebCore::InspectorController::willModifyDOMAttrImpl): (WebCore::InspectorController::didModifyDOMAttrImpl):
  • inspector/InspectorController.h: (WebCore::InspectorController::willInsertDOMNode): (WebCore::InspectorController::didInsertDOMNode): (WebCore::InspectorController::willRemoveDOMNode): (WebCore::InspectorController::willModifyDOMAttr): (WebCore::InspectorController::didModifyDOMAttr): (WebCore::InspectorController::inspectorControllerForNode):
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::~InspectorDOMAgent): (WebCore::InspectorDOMAgent::shouldBreakOnNodeInsertion): (WebCore::InspectorDOMAgent::shouldBreakOnNodeRemoval): (WebCore::InspectorDOMAgent::shouldBreakOnAttributeModification): (WebCore::InspectorDOMAgent::didInsertDOMNode): (WebCore::InspectorDOMAgent::didRemoveDOMNode): (WebCore::InspectorDOMAgent::didModifyDOMAttr): (WebCore::InspectorDOMAgent::createBreakpoint):
  • inspector/InspectorDOMAgent.h:
  • inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent): (WebCore::InspectorDebuggerAgent::~InspectorDebuggerAgent): (WebCore::InspectorDebuggerAgent::didPause): (WebCore::InspectorDebuggerAgent::breakProgram):
  • inspector/InspectorDebuggerAgent.h:
  • inspector/InspectorValues.h: (WebCore::InspectorValue::isNull):
  • inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.BreakpointItem): (WebInspector.BreakpointItem.prototype._enableChanged):
  • inspector/front-end/Script.js: (WebInspector.Script.prototype.get linesCount):
  • inspector/front-end/inspector.js: (WebInspector.pausedScript):
06:57 Changeset [66729] by ossy@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-09-03 Csaba Osztrogonác <ossy@webkit.org>

Reviewed by Simon Hausmann.

Fix warning in wtf/ByteArray.h
https://bugs.webkit.org/show_bug.cgi?id=44672

  • wtf/ByteArray.h: Use maximal sized array for MSVC and unsized array for other compilers.
06:15 Changeset [66728] by jorlow@chromium.org
  • 3 edits in trunk/LayoutTests

2010-09-03 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Steve Block.

Fix and beef up IndexedDB layout test
https://bugs.webkit.org/show_bug.cgi?id=45035

Implement some fixmes and such.

  • storage/indexeddb/database-basics-expected.txt:
  • storage/indexeddb/script-tests/database-basics.js: (openSuccess): (setVersionAgain): (createObjectStore): (checkObjectStore):
06:00 Changeset [66727] by abecsi@webkit.org
  • 4 edits
    1 add in trunk/WebKitTools

2010-09-03 Gabor Rapcsanyi <rgabor@inf.u-szeged.hu>

Reviewed by Eric Seidel.

Add feature detection support to NRWT.
https://bugs.webkit.org/show_bug.cgi?id=41842

  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/qt.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Added.
05:53 Changeset [66726] by jorlow@chromium.org
  • 13 edits in trunk

2010-08-31 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Steve Block.

IDBCursor.continue() should reuse the .openCursor's IDBRequest object
https://bugs.webkit.org/show_bug.cgi?id=44953

  • storage/indexeddb/objectstore-cursor.html:

2010-08-31 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Steve Block.

IDBCursor.continue() should reuse the .openCursor's IDBRequest object
https://bugs.webkit.org/show_bug.cgi?id=44953

This is to match the spec. This requires a modification to IDBRequest so
that multiple events can be queued up.

Note that the initial state for IDBRequest was removed from the spec.

Test: modified existing test to verify new behavior.

  • storage/IDBAny.cpp: (WebCore::IDBAny::createInvalid): (WebCore::IDBAny::createNull): (WebCore::IDBAny::setNull):
  • storage/IDBAny.h: (WebCore::IDBAny::create):
  • storage/IDBCursor.cpp: (WebCore::IDBCursor::IDBCursor): (WebCore::IDBCursor::continueFunction):
  • storage/IDBCursor.h: (WebCore::IDBCursor::create):
  • storage/IDBCursor.idl:
  • storage/IDBRequest.cpp: (WebCore::IDBRequest::IDBRequest): (WebCore::IDBRequest::~IDBRequest): (WebCore::IDBRequest::resetReadyState): (WebCore::IDBRequest::onError): (WebCore::IDBRequest::onSuccess): (WebCore::IDBRequest::abort): (WebCore::IDBRequest::timerFired): (WebCore::IDBRequest::scheduleEvent):
  • storage/IDBRequest.h:
  • storage/IDBRequest.idl:

2010-08-31 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Steve Block.

IDBCursor.continue() should reuse the .openCursor's IDBRequest object
https://bugs.webkit.org/show_bug.cgi?id=44953

  • src/WebIDBCallbacksImpl.cpp: (WebCore::WebIDBCallbacksImpl::onError): (WebCore::WebIDBCallbacksImpl::onSuccess):
05:42 Changeset [66725] by xan@webkit.org
  • 2 edits in trunk/WebKit/gtk

2010-09-03 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Dialog separators are gone in GTK+ 3.x.

  • webkit/webkitsoupauthdialog.c: (show_auth_dialog):
05:39 Changeset [66724] by antonm@chromium.org
  • 3 edits in trunk/LayoutTests

2010-09-03 Anton Muhin <antonm@chromium.org>

Unreviewed fix, updating Chromium's exectations.

  • platform/chromium-linux/plugins/embed-attributes-style-expected.checksum:
  • platform/chromium-linux/plugins/embed-attributes-style-expected.png:
05:12 Changeset [66723] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-09-03 Bharathwaaj Srinivasan <bharathwaaj.s@gmail.com>

Reviewed by Xan Lopez.

Initialize keyboard events before passing plugins.
https://bugs.webkit.org/show_bug.cgi?id=44771

No new tests needed since this is a trivial fix.

  • plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::handleKeyboardEvent):
04:48 Changeset [66722] by yurys@chromium.org
  • 2 edits in trunk/WebCore

2010-09-03 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Fix Qt compilation.

  • html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::parametersForPlugin):
03:36 Changeset [66721] by commit-queue@webkit.org
  • 12 edits
    4 adds in trunk

2010-09-03 Hironori Bono <hbono@chromium.org>

Reviewed by Kent Tamura.

Adds textInputController.hasSpellingMarker() to avoid using pixel tests for spellchecking tests
and implements it for Mac.
https://bugs.webkit.org/show_bug.cgi?id=41832

  • editing/spelling/spelling-contenteditable-expected.txt: Added the expected result for spelling-contenteditable.html.
  • editing/spelling/spelling-contenteditable.html: Added a text test of spellcheker APIs for contenteditable <div> elements.
  • editing/spelling/spelling-textarea-expected.txt: Added the expected result for spelling-textarea.html.
  • editing/spelling/spelling-textarea.html: Added a text test of spellchecker APIs for <textarea> elements.
  • platform/chromium/test_expectations.txt: Skipped the new tests because textInputController.hasSpelingMarker() is not implemented.
  • platform/gtk/Skipped: ditto.
  • platform/qt/Skipped: ditto.
  • platform/win/Skipped: ditto.

2010-09-03 Hironori Bono <hbono@chromium.org>

Reviewed by Kent Tamura.

Adds textInputController.hasSpellingMarker() to avoid using pixel tests for spellchecking tests
and implements it for Mac.
https://bugs.webkit.org/show_bug.cgi?id=41832

Tests: editing/spelling/spelling-contenteditable.html

editing/spelling/spelling-textarea.html

  • WebCore.exp.in: Exported symbols used by [WebFrame hasSpellingMarker:length:].

2010-09-03 Hironori Bono <hbono@chromium.org>

Reviewed by Kent Tamura.

Adds textInputController.hasSpellingMarker() to avoid using pixel tests for spellchecking tests
and implements it for Mac.
https://bugs.webkit.org/show_bug.cgi?id=41832

  • WebView/WebFrame.mm: Implemented [WebFrame hasSpellingMarker:length:]. (spellingNode): (-[WebFrame hasSpellingMarker:length:]):
  • WebView/WebFramePrivate.h: Added [WebFrame hasSpellingMarker:length:] so TextInputController can use it.

2010-09-03 Hironori Bono <hbono@chromium.org>

Reviewed by Kent Tamura.

Adds textInputController.hasSpellingMarker() to avoid using pixel tests for spellchecking tests
and implements it for Mac.
https://bugs.webkit.org/show_bug.cgi?id=41832

  • DumpRenderTree/mac/TextInputController.m: Added [TextInputController hasSpellingMarker:length:] and bind it so we can call it from JavaScript. (+[TextInputController isSelectorExcludedFromWebScript:]): (+[TextInputController webScriptNameForSelector:]): (-[TextInputController hasSpellingMarker:length:]):
03:09 Changeset [66720] by yurys@chromium.org
  • 24 edits in trunk

2010-09-02 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

REGRESSION: Crash occurs at objc_msgSend when closing a window that is displaying the web inspector
https://bugs.webkit.org/show_bug.cgi?id=44230

  • inspector/Inspector.idl:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::inspectedPageDestroyed): (WebCore::InspectorController::close):
  • inspector/InspectorFrontendClient.h:
  • inspector/InspectorFrontendHost.cpp: (WebCore::InspectorFrontendHost::disconnectFromBackend): don't try to notify InspectorController that frontend closes if InspectorController triggered the action.
  • inspector/InspectorFrontendHost.h:
  • inspector/InspectorFrontendHost.idl:
  • inspector/front-end/InspectorFrontendHostStub.js: (.WebInspector.InspectorFrontendHostStub.prototype.disconnectFromBackend):
  • inspector/front-end/inspector.js: (WebInspector.disconnectFromBackend):

2010-09-02 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

REGRESSION: Crash occurs at objc_msgSend when closing a window that is displaying the web inspector
https://bugs.webkit.org/show_bug.cgi?id=44230

  • WebCoreSupport/WebInspectorClient.h:
  • WebCoreSupport/WebInspectorClient.mm: (WebInspectorFrontendClient::closeWindow): (WebInspectorFrontendClient::disconnectFromBackend): (-[WebInspectorWindowController windowShouldClose:]): (-[WebInspectorWindowController destroyInspectorView:]):
02:50 Changeset [66719] by girish@forwardbias.in
  • 2 edits in trunk/WebCore

Passing a 32-bit depth X pixmap to NPAPI windowless plugins is too inefficient.
Instead, pass a X Pixmap that has same depth as the screen depth since graphics
operations are optimized for this depth.

https://bugs.webkit.org/show_bug.cgi?id=45167

Reviewed by Simon Hausmann.

  • plugins/PluginPackage.cpp:

(WebCore::PluginPackage::determineQuirks):

00:44 Changeset [66718] by philn@webkit.org
  • 2 edits in trunk/LayoutTests

2010-09-03 Philippe Normand <pnormand@igalia.com>

Unreviewed, updated GTK baselines of a mathml test.

Use correct minus glyphs in MathML operators
https://bugs.webkit.org/show_bug.cgi?id=43629

  • platform/gtk/mathml/presentation/mo-expected.txt:
00:03 Changeset [66717] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-09-02 Kwang Yul Seo <skyul@company100.net>

Reviewed by Kent Tamura.

Add ENABLE(DATABASE) guard to DatabaseAuthorizer.cpp
https://bugs.webkit.org/show_bug.cgi?id=45152

DatabaseAuthorizer is used only with ENABLE(DATABASE).

  • storage/DatabaseAuthorizer.cpp:

09/02/10:

23:20 Changeset [66716] by commit-queue@webkit.org
  • 5 edits in trunk

2010-09-02 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Reviewed by Antonio Gomes.

[EFL] Name install directories according to library name
https://bugs.webkit.org/show_bug.cgi?id=45126

  • cmake/OptionsEfl.cmake: Use library name in order to define the data directory.

2010-09-02 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Reviewed by Antonio Gomes.

[EFL] Name install directories according to library name
https://bugs.webkit.org/show_bug.cgi?id=45126

  • CMakeListsEfl.txt: include diretory follows library name.
  • ewebkit.pc.in: Ditto.
23:03 Changeset [66715] by commit-queue@webkit.org
  • 2 edits in trunk

2010-09-02 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Reviewed by Antonio Gomes.

[EFL] Do not override custom compile flags
https://bugs.webkit.org/show_bug.cgi?id=45125

Set a default build type if and only if user did not define one as
command line options and he did not give custom CFLAGS or CXXFLAGS.
Otherwise, flags from default build type would override user-defined
ones.

  • CMakeLists.txt:
22:41 Changeset [66714] by commit-queue@webkit.org
  • 3 edits in trunk

2010-09-02 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Reviewed by Antonio Gomes.

[EFL] Fix double addition of -fPIC
https://bugs.webkit.org/show_bug.cgi?id=45122

When SHARED_CORE=ON, -fPIC is automatically added because all
libraries are dynamic. Only when static libraries are built that
-fPIC needs to be manually inserted (because the final library,
libewebkit.so, is dynamic).

  • cmake/OptionsCommon.cmake: Remove -fPIC flag.
  • cmake/WebKitHelpers.cmake: Add -fPIC flags iff SHARED_CORE=ON.
22:22 Changeset [66713] by satish@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-09-02 Satish Sampath <satish@chromium.org>

Reviewed by Jeremy Orlow.

Remove obsolete public/API methods in chromium port
https://bugs.webkit.org/show_bug.cgi?id=45108

  • public/WebSpeechInputController.h: (WebKit::WebSpeechInputController::startRecognition):
22:18 DeveloperTips edited by mihaip@chromium.org
(diff)
22:05 Changeset [66712] by commit-queue@webkit.org
  • 9 edits in trunk

2010-09-02 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: add page reload test to dom-breakpoints.html
https://bugs.webkit.org/show_bug.cgi?id=44837

  • inspector/dom-breakpoints-expected.txt:
  • inspector/dom-breakpoints.html:

2010-09-02 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: persist DOM breakpoints between page reloads
https://bugs.webkit.org/show_bug.cgi?id=44837

  • inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.DOMBreakpointItem):
  • inspector/front-end/DOMAgent.js: (WebInspector.DOMNode.prototype.path): (WebInspector.DOMNode.prototype.setBreakpoint): (WebInspector.DOMNode.prototype.hasBreakpoint): (WebInspector.DOMNode.prototype.removeBreakpoint): (WebInspector.DOMNode.prototype.removeBreakpoints): (WebInspector.DOMAgent.prototype._setDocument): (WebInspector.DOMAgent.prototype._childNodeRemoved): (WebInspector.DOMAgent.prototype._removeBreakpoints): (WebInspector.DOMBreakpointManager): (WebInspector.DOMBreakpointManager.prototype.setBreakpoint): (WebInspector.DOMBreakpointManager.prototype.removeBreakpointsForNode): (WebInspector.DOMBreakpointManager.prototype._breakpointRemoved): (WebInspector.DOMBreakpointManager.prototype.restoreBreakpoints.restoreBreakpointsForNode): (WebInspector.DOMBreakpointManager.prototype.restoreBreakpoints): (WebInspector.DOMBreakpoint): (WebInspector.DOMBreakpoint.prototype.get nodeId): (WebInspector.DOMBreakpoint.prototype.get type): (WebInspector.DOMBreakpoint.prototype.set enabled): (WebInspector.DOMBreakpoint.prototype.remove):
  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.reset): (WebInspector.ElementsPanel.prototype.setDocument):
  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype._populateTagContextMenu):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._showPopup.showObjectPopup):
21:49 Changeset [66711] by eric@webkit.org
  • 11 edits in trunk/WebCore

2010-09-02 Eric Seidel <eric@webkit.org>

Reviewed by Dimitri Glazkov.

Move updateWidget into FrameView from RenderEmbeddedObject
https://bugs.webkit.org/show_bug.cgi?id=45065

I also made updateWidget() virtual on HTMLPlugInImageElement.
I'm not yet sure that updateWidget belongs on HTMLElement since
I'm not sure that HTMLMediaElement's use of the updateWidget
infrastructure is correct.

I also got rid of the strange !m_replacementText.isEmpty() checks
by making a pluginCrashedOrWasMissing() call which seems to embody
the idea behind that check and hides the screwy details.

I noticed a couple methods on HTMLPlugInImageElement were public
which did not need to be. Fixed.

No functional change, thus no tests.

  • html/HTMLEmbedElement.h:
  • html/HTMLObjectElement.h:
  • html/HTMLPlugInImageElement.cpp: (WebCore::HTMLPlugInImageElement::updateWidgetIfNecessary):
  • html/HTMLPlugInImageElement.h: (WebCore::HTMLPlugInImageElement::serviceType): (WebCore::HTMLPlugInImageElement::url):
  • page/FrameView.cpp: (WebCore::FrameView::updateWidget): (WebCore::FrameView::updateWidgets):
  • page/FrameView.h:
  • rendering/RenderEmbeddedObject.cpp: (WebCore::RenderEmbeddedObject::pluginCrashedOrWasMissing): (WebCore::RenderEmbeddedObject::paint): (WebCore::RenderEmbeddedObject::paintReplaced):
  • rendering/RenderEmbeddedObject.h:
21:28 Changeset [66710] by eric@webkit.org
  • 10 edits in trunk/WebCore

2010-09-02 Eric Seidel <eric@webkit.org>

Reviewed by Dimitri Glazkov.

Move updateWidget implementations into the DOM
https://bugs.webkit.org/show_bug.cgi?id=45058

Unfortunately it's not yet possible to share an updateWidget
implementation between <embed> and <object>. That would amount to
(positive) functional changes for <embed> which I'd will separate
into a later patch. I will also have to untangle <object>'s <param>
walk from its url/serviceType calculations.

However after this patch it's slap-you-across-the-face obvious that
RenderEmbeddedObject::updateWidget was the wrong place for this code.
RenderEmbeddedObject::updateWidget still exists, but only as a
pseudo-virtual-method dispatcher. Unless we add updateWidget() to
HTMLElement, we won't be able to use real virtual dispatch.

I may need to consider making "having a widget" a has-a relationship
with some sort of WidgetContainer object which Media and Plugin can
share. Or its also possible that Media's use of the widget code here
is just wrong. Certainly now that updateWidget was moved into HTMLMediaElement
it becomes obvious that HTMLMediaElement has duplicate code for updating widgets.

No functional changes, thus no tests.

  • html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::updateWidget):
  • html/HTMLEmbedElement.h:
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::updateWidget):
  • html/HTMLMediaElement.h:
  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::updateWidget):
  • html/HTMLObjectElement.h: (WebCore::HTMLObjectElement::useFallbackContent):
  • html/HTMLPlugInImageElement.h: (WebCore::HTMLPlugInImageElement::needsWidgetUpdate): (WebCore::HTMLPlugInImageElement::setNeedsWidgetUpdate):
  • loader/FrameLoader.cpp:
  • rendering/RenderEmbeddedObject.cpp: (WebCore::RenderEmbeddedObject::updateWidget):
21:04 Changeset [66709] by eric@webkit.org
  • 8 edits in trunk/WebCore

2010-09-02 Eric Seidel <eric@webkit.org>

Reviewed by Dimitri Glazkov.

Move more code from RenderEmbeddedObject into the DOM
https://bugs.webkit.org/show_bug.cgi?id=45055

No logic changes here, just taking the code which
I ripped out of RenderEmbeddedObject::updateWidget
into static methods before and moving it into
the applicable DOM classes.

HTMLObjectElement::parametersForPlugin does too much
but in order to fix it I may need to add a PluginParameters
class so we can ask things about the parameters. <object>
needs to get multiple bits of information out of its parameters
array. Right now it does it all in one walk. In order to share
code with HTMLEmbedElement, we need the "generate the params array"
code to be separate from the "make advanced <object> specific decision
from the params array". But that will need to be in a later patch.

No functional changes, thus no tests.

  • html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::parametersForPlugin):
  • html/HTMLEmbedElement.h:
  • html/HTMLObjectElement.cpp: (WebCore::createClassIdToTypeMap): (WebCore::serviceTypeForClassId): (WebCore::mapDataParamToSrc): (WebCore::HTMLObjectElement::parametersForPlugin): (WebCore::HTMLObjectElement::hasFallbackContent):
  • html/HTMLObjectElement.h:
  • html/HTMLPlugInImageElement.cpp: (WebCore::HTMLPlugInImageElement::allowedToLoadFrameURL): (WebCore::HTMLPlugInImageElement::wouldLoadAsNetscapePlugin): (WebCore::HTMLPlugInImageElement::detach): (WebCore::HTMLPlugInImageElement::updateWidgetIfNecessary): (WebCore::HTMLPlugInImageElement::updateWidgetCallback):
  • html/HTMLPlugInImageElement.h:
  • rendering/RenderEmbeddedObject.cpp: (WebCore::updateWidgetForObjectElement): (WebCore::updateWidgetForEmbedElement): (WebCore::RenderEmbeddedObject::updateWidget):
20:45 Changeset [66708] by commit-queue@webkit.org
  • 9 edits in trunk

2010-09-02 François Sausset <sausset@gmail.com>

Reviewed by Darin Adler.

MathML mo element should render "hyphen-minus" as "minus sign" (Unicode glyph names).
https://bugs.webkit.org/show_bug.cgi?id=43629

  • mathml/presentation/mo.xhtml:
  • platform/mac/mathml/presentation/mo-expected.checksum:
  • platform/mac/mathml/presentation/mo-expected.png:
  • platform/mac/mathml/presentation/mo-expected.txt:

2010-09-02 François Sausset <sausset@gmail.com>

Reviewed by Darin Adler.

MathML mo element should render "hyphen-minus" as "minus sign" (Unicode glyph names).
https://bugs.webkit.org/show_bug.cgi?id=43629

Test: mathml/presentation/mo.xhtml

  • mathml/RenderMathMLOperator.cpp: (WebCore::RenderMathMLOperator::RenderMathMLOperator): (WebCore::RenderMathMLOperator::updateFromElement):
  • mathml/RenderMathMLOperator.h: (WebCore::convertHyphenMinusToMinusSign):
  • platform/text/CharacterNames.h:
20:16 Changeset [66707] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-09-02 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Add a unit test for commit-queue retries
https://bugs.webkit.org/show_bug.cgi?id=45162

I think commit-queue retries are not correctly avoiding
build and test on retries. So I started testing the code.
Unfortunately this test did not find the bug. But now
that we have the test we might as well keep it.
I also fixed a broken import in validate-committer-lists.

  • Scripts/validate-committer-lists:
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
19:21 DeveloperTips edited by yuzo@google.com
(diff)
19:16 Changeset [66706] by abarth@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-09-02 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Actually parse a URL from ParsedURL
https://bugs.webkit.org/show_bug.cgi?id=45080

This patch only handles standard URLs. At some point we'll need to
distinguish between standard URLs and other kinds of URLs.

  • wtf/url/api/ParsedURL.cpp: (WTF::ParsedURL::ParsedURL):
19:14 DeveloperTips edited by yuzo@google.com
(diff)
19:11 Changeset [66705] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

2010-09-02 Kent Tamura <tkent@chromium.org>

Unreviewed, test expectation update.

  • platform/chromium/drt_expectations.txt: Remove another duplicate.
19:11 AddToPrivateHeaders.png attached to DeveloperTips by yuzo@google.com
19:10 Changeset [66704] by kbr@google.com
  • 2 edits
    2 adds in trunk/WebCore

2010-09-02 Kenneth Russell <kbr@google.com>

Reviewed by Darin Fisher.

Add red-black tree capable of holding plain old data (POD)
https://bugs.webkit.org/show_bug.cgi?id=45059

Adding an augmentable red-black tree capable of holding Plain Old
Data (POD), or classes bottoming out into only POD, and an
associated PODArena. Note that the PODArena will be used by other
classes to allocate temporary structures, which is why it is not
just an implementation detail of the red-black tree.

These classes are being placed under WebCore/platform/graphics/gpu
for the time being. If they are generalized to hold even data
types which internally perform dynamic memory allocation, we may
consider moving them to WTF in the future.

Unit tests for the PODRedBlackTree will be integrated separately
under bug 45060.

  • WebCore.gypi:
  • platform/graphics/gpu/PODArena.h: Added. (WebCore::PODArena::Allocator::~Allocator): (WebCore::PODArena::FastMallocAllocator::create): (WebCore::PODArena::FastMallocAllocator::allocate): (WebCore::PODArena::FastMallocAllocator::free): (WebCore::PODArena::FastMallocAllocator::FastMallocAllocator): (WebCore::PODArena::create): (WebCore::PODArena::allocateObject): (WebCore::PODArena::~PODArena): (WebCore::PODArena::PODArena): (WebCore::PODArena::minAlignment): (WebCore::PODArena::roundUp): (WebCore::PODArena::Chunk::Chunk): (WebCore::PODArena::Chunk::~Chunk): (WebCore::PODArena::Chunk::allocate):
  • platform/graphics/gpu/PODRedBlackTree.h: Added. (WebCore::PODRedBlackTree::Visitor::~Visitor): (WebCore::PODRedBlackTree::PODRedBlackTree): (WebCore::PODRedBlackTree::~PODRedBlackTree): (WebCore::PODRedBlackTree::add): (WebCore::PODRedBlackTree::remove): (WebCore::PODRedBlackTree::contains): (WebCore::PODRedBlackTree::visitInorder): (WebCore::PODRedBlackTree::size): (WebCore::PODRedBlackTree::setNeedsFullOrderingComparisons): (WebCore::PODRedBlackTree::checkInvariants): (WebCore::PODRedBlackTree::dump): (WebCore::PODRedBlackTree::setVerboseDebugging): (WebCore::PODRedBlackTree::Node::Node): (WebCore::PODRedBlackTree::Node::~Node): (WebCore::PODRedBlackTree::Node::color): (WebCore::PODRedBlackTree::Node::setColor): (WebCore::PODRedBlackTree::Node::data): (WebCore::PODRedBlackTree::Node::copyFrom): (WebCore::PODRedBlackTree::Node::left): (WebCore::PODRedBlackTree::Node::setLeft): (WebCore::PODRedBlackTree::Node::right): (WebCore::PODRedBlackTree::Node::setRight): (WebCore::PODRedBlackTree::Node::parent): (WebCore::PODRedBlackTree::Node::setParent): (WebCore::PODRedBlackTree::root): (WebCore::PODRedBlackTree::updateNode): (WebCore::PODRedBlackTree::treeSearch): (WebCore::PODRedBlackTree::treeSearchNormal): (WebCore::PODRedBlackTree::treeSearchFullComparisons): (WebCore::PODRedBlackTree::treeInsert): (WebCore::PODRedBlackTree::treeSuccessor): (WebCore::PODRedBlackTree::treeMinimum): (WebCore::PODRedBlackTree::propagateUpdates): (WebCore::PODRedBlackTree::leftRotate): (WebCore::PODRedBlackTree::rightRotate): (WebCore::PODRedBlackTree::insertNode): (WebCore::PODRedBlackTree::deleteFixup): (WebCore::PODRedBlackTree::deleteNode): (WebCore::PODRedBlackTree::visitInorderImpl): (WebCore::PODRedBlackTree::Counter::Counter): (WebCore::PODRedBlackTree::Counter::visit): (WebCore::PODRedBlackTree::Counter::count): (WebCore::PODRedBlackTree::checkInvariantsFromNode): (WebCore::PODRedBlackTree::logIfVerbose): (WebCore::PODRedBlackTree::dumpFromNode):
19:04 DeveloperTips created by yuzo@google.com
18:58 Changeset [66703] by abarth@webkit.org
  • 2 edits
    4 adds in trunk/JavaScriptCore

2010-09-02 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add ParsedURL and URLString to WTFURL API
https://bugs.webkit.org/show_bug.cgi?id=45078

Currently there's no actual URL parsing going on, but this patch is a
start to sketching out the API.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • wtf/url/api/ParsedURL.cpp: Added. (WTF::ParsedURL::ParsedURL): (WTF::ParsedURL::scheme): (WTF::ParsedURL::username): (WTF::ParsedURL::password): (WTF::ParsedURL::host): (WTF::ParsedURL::port): (WTF::ParsedURL::path): (WTF::ParsedURL::query): (WTF::ParsedURL::fragment): (WTF::ParsedURL::segment):
  • wtf/url/api/ParsedURL.h: Added. (WTF::ParsedURL::spec):
  • wtf/url/api/URLString.h: Added. (WTF::URLString::URLString): (WTF::URLString::string):
18:53 Changeset [66702] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

2010-09-02 Kent Tamura <tkent@chromium.org>

Unreviewed, test expectation update.

  • platform/chromium/drt_expectations.txt: Remove a duplicated entry I made in the prior commit.
18:51 Changeset [66701] by tkent@chromium.org
  • 13 edits
    2 copies in trunk

2010-09-02 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[DRT/Chromium] Remove dependency to base/task.h and base/timer.h
https://bugs.webkit.org/show_bug.cgi?id=45091

  • DEPS: Roll Chromium revision to 58277 in order to have webkit_support::PostDelayedTask().

2010-09-02 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[DRT/Chromium] Remove dependency to base/task.h and base/timer.h
https://bugs.webkit.org/show_bug.cgi?id=45091

Task.{cpp,h} introduces a simpler version of Chromium
base/task.h. It doesn't have TupleN and Method.

  • DumpRenderTree/DumpRenderTree.gypi: Add Task.cpp and Task.h
  • DumpRenderTree/chromium/DRTDevToolsAgent.cpp: (DRTDevToolsAgent::DRTDevToolsAgent): (DRTDevToolsAgent::reset): (DRTDevToolsAgent::asyncCall): (DRTDevToolsAgent::frontendLoaded):
  • DumpRenderTree/chromium/DRTDevToolsAgent.h: (DRTDevToolsAgent::taskList): Added to use MethodTask<T>.
  • DumpRenderTree/chromium/DRTDevToolsClient.cpp: (DRTDevToolsClient::DRTDevToolsClient): (DRTDevToolsClient::~DRTDevToolsClient): (DRTDevToolsClient::reset): (DRTDevToolsClient::asyncCall):
  • DumpRenderTree/chromium/DRTDevToolsClient.h: (DRTDevToolsClient::taskList): Added to use MethodTask<T>.
  • DumpRenderTree/chromium/EventSender.cpp: (EventSender::EventSender): (EventSender::reset): (EventSender::scheduleAsynchronousClick):
  • DumpRenderTree/chromium/EventSender.h: (EventSender::taskList): Added to use MethodTask<T>.
  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::WorkQueue::processWorkSoon): (LayoutTestController::waitUntilDone): (LayoutTestController::notifyDone): (LayoutTestController::reset):
  • DumpRenderTree/chromium/LayoutTestController.h: (LayoutTestController::taskList): Added to use MethodTask<T>. (LayoutTestController::WorkQueue::taskList): Added to use MethodTask<T>.
  • DumpRenderTree/chromium/NotificationPresenter.cpp: (deferredDisplayDispatch): (NotificationPresenter::show):
  • DumpRenderTree/chromium/Task.cpp: Added.
  • DumpRenderTree/chromium/Task.h: Added.
18:51 WikiStart edited by yuzo@google.com
(diff)
18:38 Changeset [66700] by commit-queue@webkit.org
  • 4 edits
    2 moves in trunk/WebCore

2010-09-02 Rafael Antognolli <antognolli@profusion.mobi>

Reviewed by Martin Robinson.

[Cairo] Remove glib dependency (caused by use of GOwnPtr)
https://bugs.webkit.org/show_bug.cgi?id=45053

Use OwnPtr instead of GOwnPtr to keep track of Fc* references
in FontCacheCairo.cpp.

No features added, so no new tests.

  • CMakeListsEfl.txt: Updating build system to look for GOwnPtrCairo.*
  • GNUmakefile.am: Ditto.
  • platform/graphics/cairo/FontCacheCairo.cpp: Using OwnPtr instead of GOwnPtr. (WebCore::FontCache::createFontPlatformData):
  • platform/graphics/cairo/GOwnPtrCairo.cpp: Removed.
  • platform/graphics/cairo/GOwnPtrCairo.h: Removed.
  • platform/graphics/cairo/OwnPtrCairo.cpp: Added. (WTF::FcPattern): (WTF::FcObjectSet): (WTF::FcFontSet):
  • platform/graphics/cairo/OwnPtrCairo.h: Added.
18:20 Changeset [66699] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

2010-09-02 Kent Tamura <tkent@chromium.org>

Unreviewed, update test expectation.

  • platform/chromium/drt_expectations.txt:
18:08 Changeset [66698] by kinuko@chromium.org
  • 2 edits in trunk/WebCore

2010-09-02 Kinuko Yasuda <kinuko@chromium.org>

Unreviewed, updating binding-tests expectations (for changeset 66521).

  • bindings/scripts/test/V8/V8TestObj.cpp: (WebCore::TestObjInternal::stringAttrAttrSetter): (WebCore::TestObjInternal::reflectedStringAttrAttrSetter): (WebCore::TestObjInternal::reflectedURLAttrAttrSetter): (WebCore::TestObjInternal::reflectedNonEmptyURLAttrAttrSetter): (WebCore::TestObjInternal::reflectedCustomURLAttrAttrSetter): (WebCore::TestObjInternal::reflectedCustomNonEmptyURLAttrAttrSetter): (WebCore::TestObjInternal::stringAttrWithGetterExceptionAttrSetter): (WebCore::TestObjInternal::stringAttrWithSetterExceptionAttrSetter):
17:55 Changeset [66697] by zmo@google.com
  • 2 edits in trunk/LayoutTests

2010-09-02 Zhenyao Mo <zmo@google.com>

Unreviewed.

Updateing chromium test_expectations for flaky http/tests/security/xssAuditor/dom-write-innerHTML.html.

  • platform/chromium/test_expectations.txt:
17:47 Changeset [66696] by zmo@google.com
  • 2 edits in trunk/LayoutTests

2010-09-02 Zhenyao Mo <zmo@google.com>

Unreviewed.

Updateing chromium test_expectations for flaky editing/selection/extend-selection.html.

  • platform/chromium/test_expectations.txt:
17:01 Changeset [66695] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

2010-09-02 James Robinson <jamesr@chromium.org>

Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=37830

Fix an ordering issue in this test. The isSuccessfullyParsed
function is not defined until the onload event, so avoid running
the script body until this point.

  • fast/events/touch/script-tests/send-oncancel-event.js: (window.onload):
16:57 Changeset [66694] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

2010-09-02 Tony Chang <tony@chromium.org>

Unreviewed, updating chromium test_expectations for a failure
introduced in r66689.

  • platform/chromium/test_expectations.txt:
16:57 Changeset [66693] by weinig@apple.com
  • 4 edits in trunk/WebKit2

Add ability to send WKDictionaryRefs via post message.
https://bugs.webkit.org/show_bug.cgi?id=45151

Reviewed by Anders Carlsson.

  • Shared/ImmutableDictionary.cpp:

(WebKit::ImmutableDictionary::ImmutableDictionary):

  • Shared/ImmutableDictionary.h:

(WebKit::ImmutableDictionary::adopt): Remove tag, it wasn't doing anything.
(WebKit::ImmutableDictionary::isMutable):
(WebKit::ImmutableDictionary::map): Add accessor of internal
map for encoder.

  • Shared/UserMessageCoders.h:

(WebKit::UserMessageEncoder::baseEncode):
(WebKit::UserMessageDecoder::baseDecode):
Add encoder/decoder.

16:47 Changeset [66692] by jianli@chromium.org
  • 2 edits in trunk/LayoutTests

Skip one time-out test for now.

  • platform/mac/Skipped:
16:26 Changeset [66691] by zmo@google.com
  • 2 edits in trunk/LayoutTests

2010-09-02 Zhenyao Mo <zmo@google.com>

Unreviewed. Flag a few flaky tests:
fast/forms/select-baseline.html
fast/forms/input-spinbutton-capturing.html
fast/forms/input-number-events.html
fast/replaced/embed-display-none.html
media/video-timeupdate-during-playback.html

  • platform/chromium/test_expectations.txt:
16:14 Changeset [66690] by jianli@chromium.org
  • 8 edits
    1 add
    3 deletes in trunk/LayoutTests

Improve tests for blob URL.
https://bugs.webkit.org/show_bug.cgi?id=45132

Reviewed by Darin Fisher.

Change apply-blob-url-to-xhr.html to produce text based result. Also
add the test case for revokeBlobURL in apply-blob-url-to-xhr.html
and work-apply-blob-url-to-xhr.html.

  • fast/files/apply-blob-url-to-img-expected.txt: Added.
  • fast/files/apply-blob-url-to-img.html:
  • fast/files/apply-blob-url-to-xhr-expected.txt:
  • fast/files/apply-blob-url-to-xhr.html:
  • fast/files/workers/resources/worker-apply-blob-url-to-xhr.js:

(sendXMLHttpRequest):
(onmessage):

  • fast/files/workers/worker-apply-blob-url-to-xhr-expected.txt:
  • platform/chromium/test_expectations.txt:
  • platform/mac/Skipped:
  • platform/mac/fast/files/apply-blob-url-to-img-expected.checksum: Removed.
  • platform/mac/fast/files/apply-blob-url-to-img-expected.png: Removed.
  • platform/mac/fast/files/apply-blob-url-to-img-expected.txt: Removed.
15:57 Changeset [66689] by tony@chromium.org
  • 4 edits
    2 adds in trunk

2010-09-02 Adam Langley <agl@chromium.org>

Reviewed by Adam Barth.

[chromium] fix memory corruption in Khmer rendering.

  • fast/text/khmer-crash-expected.txt: Added.
  • fast/text/khmer-crash.html: Added.

2010-09-02 Adam Langley <agl@chromium.org>

Reviewed by Adam Barth.

[chromium] fix memory corruption in Khmer rendering.

https://bugs.webkit.org/show_bug.cgi?id=44960

Test: fast/text/khmer-crash.html

  • platform/graphics/chromium/FontLinux.cpp: (WebCore::TextRunWalker::shapeGlyphs): The Khmer shaper has a bug where it would request larger output buffers, but request a zero increase in size. Because of this we add one to the requested size. (WebCore::TextRunWalker::setGlyphXPositions): The Khmer shaper is outputing cluster logs which suggest that some output glyphs appear from nowhere (i.e. have no input codepoints). I don't know Khmer, so maybe that's correct, but it broke the assumptions of this code, causing a read out-of-bounds.
  • platform/graphics/chromium/HarfbuzzSkia.cpp: (WebCore::stringToGlyphs): The Harfbuzz interfaces aren't documented, but it appears that the output array to stringToGlyphs isn't sized and that Harfbuzz expects us to detect when the input is too long.
15:52 Changeset [66688] by weinig@apple.com
  • 6 edits
    3 copies in trunk/WebKit2

Share the common parts of UserMessage coding between both processes.
https://bugs.webkit.org/show_bug.cgi?id=45139

Reviewed by Anders Carlsson.

Add base classes UserMessageEncoder and UserMessageDecoder which implement
encoding/decoding of ImmutableArray and String (soon to be others as well, such
as ImmutableDictionary, Data, etc.) and add derived classes which implement the
process specific bits such as Page -> BundlePage conversion.

  • Shared/UserMessageCoders.h: Copied from WebProcess/InjectedBundle/InjectedBundle.cpp.

(WebKit::UserMessageEncoder::baseEncode):
(WebKit::UserMessageEncoder::UserMessageEncoder):
(WebKit::UserMessageDecoder::baseDecode):
(WebKit::UserMessageDecoder::UserMessageDecoder):

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::postMessageToInjectedBundle):
(WebKit::WebContext::didReceiveMessage):

  • UIProcess/WebContextUserMessageCoders.h: Copied from UIProcess/WebContext.cpp.

(WebKit::WebContextUserMessageEncoder::WebContextUserMessageEncoder):
(WebKit::WebContextUserMessageEncoder::encode):
(WebKit::WebContextUserMessageDecoder::WebContextUserMessageDecoder):
(WebKit::WebContextUserMessageDecoder::decode):

  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::postMessage):
(WebKit::InjectedBundle::didReceiveMessage):

  • WebProcess/InjectedBundle/InjectedBundleUserMessageCoders.h: Copied from WebProcess/InjectedBundle/InjectedBundle.cpp.

(WebKit::InjectedBundleUserMessageEncoder::InjectedBundleUserMessageEncoder):
(WebKit::InjectedBundleUserMessageEncoder::encode):
(WebKit::InjectedBundleUserMessageDecoder::InjectedBundleUserMessageDecoder):
(WebKit::InjectedBundleUserMessageDecoder::decode):

  • win/WebKit2.vcproj:
15:24 Changeset [66687] by zmo@google.com
  • 2 edits in trunk/LayoutTests

2010-09-02 Zhenyao Mo <zmo@google.com>

Unreviewed, add two failing tests (http/tests/inspector/console-xhr-logging.html and http/tests/inspector/resource-har-conversion.html) to platform/chromium/test_expectations.txt.

  • platform/chromium/test_expectations.txt:
14:35 Changeset [66686] by rniwa@webkit.org
  • 4 edits
    3 adds
    30 deletes in trunk/LayoutTests

2010-09-02 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Tony Chang.

dumpAsText conversion: editing/pasteboard/select-element-1.html, editing/deleting/delete-br-012.html, and editing/deleting/delete-select-all-001.html
https://bugs.webkit.org/show_bug.cgi?id=45121

Converted tests.

  • editing/deleting/delete-br-012-expected.txt: Added.
  • editing/deleting/delete-br-012.html:
  • editing/deleting/delete-select-all-001-expected.txt: Added.
  • editing/deleting/delete-select-all-001.html:
  • editing/pasteboard/select-element-1-expected.txt: Added.
  • editing/pasteboard/select-element-1.html:
  • platform/chromium-linux/editing/deleting/delete-br-012-expected.checksum: Removed.
  • platform/chromium-linux/editing/deleting/delete-br-012-expected.png: Removed.
  • platform/chromium-linux/editing/deleting/delete-select-all-001-expected.checksum: Removed.
  • platform/chromium-linux/editing/pasteboard/select-element-1-expected.checksum: Removed.
  • platform/chromium-linux/editing/pasteboard/select-element-1-expected.png: Removed.
  • platform/chromium-linux/editing/pasteboard/select-element-1-expected.txt: Removed.
  • platform/chromium-win/editing/deleting/delete-br-012-expected.checksum: Removed.
  • platform/chromium-win/editing/deleting/delete-br-012-expected.png: Removed.
  • platform/chromium-win/editing/deleting/delete-br-012-expected.txt: Removed.
  • platform/chromium-win/editing/deleting/delete-select-all-001-expected.checksum: Removed.
  • platform/chromium-win/editing/deleting/delete-select-all-001-expected.png: Removed.
  • platform/chromium-win/editing/deleting/delete-select-all-001-expected.txt: Removed.
  • platform/chromium-win/editing/pasteboard/select-element-1-expected.checksum: Removed.
  • platform/chromium-win/editing/pasteboard/select-element-1-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/select-element-1-expected.txt: Removed.
  • platform/gtk/editing/deleting/delete-select-all-001-expected.txt: Removed.
  • platform/mac-leopard/editing/pasteboard/select-element-1-expected.checksum: Removed.
  • platform/mac-leopard/editing/pasteboard/select-element-1-expected.png: Removed.
  • platform/mac/editing/deleting/delete-br-012-expected.checksum: Removed.
  • platform/mac/editing/deleting/delete-br-012-expected.png: Removed.
  • platform/mac/editing/deleting/delete-br-012-expected.txt: Removed.
  • platform/mac/editing/deleting/delete-select-all-001-expected.checksum: Removed.
  • platform/mac/editing/deleting/delete-select-all-001-expected.png: Removed.
  • platform/mac/editing/deleting/delete-select-all-001-expected.txt: Removed.
  • platform/mac/editing/pasteboard/select-element-1-expected.checksum: Removed.
  • platform/mac/editing/pasteboard/select-element-1-expected.png: Removed.
  • platform/mac/editing/pasteboard/select-element-1-expected.txt: Removed.
  • platform/qt/editing/deleting/delete-br-012-expected.txt: Removed.
  • platform/qt/editing/deleting/delete-select-all-001-expected.txt: Removed.
  • platform/qt/editing/pasteboard/select-element-1-expected.txt: Removed.
14:27 BuildingQtOnLinux edited by ademar.reis@openbossa.org
improve list of deps on fedora (diff)
14:22 Changeset [66685] by steveblock@google.com
  • 10 edits
    9 adds in trunk

2010-09-02 Steve Block <steveblock@google.com>

Reviewed by Adam Barth.

Hook up LayoutTestController.setMockDeviceOrientation() on Mac.
https://bugs.webkit.org/show_bug.cgi?id=43181

  • WebKit.xcodeproj/project.pbxproj:

2010-09-02 Steve Block <steveblock@google.com>

Reviewed by Adam Barth.

Hook up LayoutTestController.setMockDeviceOrientation() on Mac.
https://bugs.webkit.org/show_bug.cgi?id=43181

This patch hooks up the mock device orientation client on Mac for use
in DumpRenderTree.

The patch adds a new WebDeviceOrientationClient for Mac. This client acts
as a proxy to either a real or mock device orientation provider, both of
which implement a new WebDeviceOrientationProvider interface.

The provider is created by the embedder and passed to the WebView, from
where WebDeviceOrientationClient can access it.

The mock provider, WebDeviceOrientationProviderMock, is a wrapper around
the existing WebCore mock.

  • WebCoreSupport/WebDeviceOrientationClient.h: Added.
  • WebCoreSupport/WebDeviceOrientationClient.mm: Added. (WebDeviceOrientationClient::WebDeviceOrientationClient): (WebDeviceOrientationClient::setController): (WebDeviceOrientationClient::startUpdating): (WebDeviceOrientationClient::stopUpdating): (WebDeviceOrientationClient::lastOrientation):
  • WebKit.exp:
  • WebView/WebDeviceOrientation.h: Added.
  • WebView/WebDeviceOrientation.mm: Added. (-[WebDeviceOrientation initWithCoreDeviceOrientation:WebCore::]): (core): (-[WebDeviceOrientation initWithCanProvideAlpha:alpha:canProvideBeta:beta:canProvideGamma:gamma:]): (-[WebDeviceOrientation dealloc]):
  • WebView/WebDeviceOrientationInternal.h: Added.
  • WebView/WebDeviceOrientationProvider.h: Added.
  • WebView/WebDeviceOrientationProviderMock.h: Added.
  • WebView/WebDeviceOrientationProviderMock.mm: Added. (-[WebDeviceOrientationProviderMockInternal setOrientation:]): (-[WebDeviceOrientationProviderMockInternal setController:]): (-[WebDeviceOrientationProviderMockInternal startUpdating]): (-[WebDeviceOrientationProviderMockInternal stopUpdating]): (-[WebDeviceOrientationProviderMockInternal lastOrientation]): (-[WebDeviceOrientationProviderMock init]): (-[WebDeviceOrientationProviderMock dealloc]): (-[WebDeviceOrientationProviderMock setOrientation:]): (-[WebDeviceOrientationProviderMock setController:]): (-[WebDeviceOrientationProviderMock startUpdating]): (-[WebDeviceOrientationProviderMock stopUpdating]): (-[WebDeviceOrientationProviderMock lastOrientation]):
  • WebView/WebDeviceOrientationProviderMockInternal.h: Added.
  • WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]): (-[WebView _setDeviceOrientationProvider:]): (-[WebView _deviceOrientationProvider]):
  • WebView/WebViewData.h:
  • WebView/WebViewPrivate.h:

2010-09-02 Steve Block <steveblock@google.com>

Reviewed by Adam Barth.

Hook up LayoutTestController.setMockDeviceOrientation() on Mac.
https://bugs.webkit.org/show_bug.cgi?id=43181

  • DumpRenderTree/mac/DumpRenderTree.mm: (createWebViewAndOffscreenWindow):
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setMockDeviceOrientation):
13:45 Changeset [66684] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2010-09-02 Matthew Willis <lilmatt@flock.com>

Reviewed by Eric Seidel.

Attempt to fix flaxy test that contains setTimeout() by adding
layoutTestController.waitUntilDone() and ...notifyDone()
https://bugs.webkit.org/show_bug.cgi?id=45097

  • fast/css/disabled-author-styles.html:
13:23 Applications using WebKit edited by lilmatt@flock.com
add Flock (diff)
13:15 Changeset [66683] by aroben@apple.com
  • 2 edits in trunk/WebCore

Fill the scroll corner with white when shouldPaintCustomScrollbars is false

Previously we were only filling with white when
shouldPaintCustomScrollbars was true but the ChromeClient didn't paint
any custom scrollbars.

Reviewed by Sam Weinig.

  • platform/ScrollbarThemeComposite.cpp:

(WebCore::ScrollbarThemeComposite::paintScrollCorner):

13:14 Changeset [66682] by aroben@apple.com
  • 2 edits in trunk/WebKitTools

Fix flashiness when resizing the browser window on Windows

Reviewed by Sam Weinig.

  • MiniBrowser/win/BrowserWindow.cpp:

(BrowserWindow::wndProc): Override WM_ERASEBKGND so Windows won't
periodically fill the window with white.

13:10 Changeset [66681] by eric@webkit.org
  • 3 edits
    2 deletes in trunk/LayoutTests

2010-09-02 Eric Seidel <eric@webkit.org>

Reviewed by Alexey Proskuryakov.

fast/loader/recursive-before-unload-crash.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=43840

Removed the frame loader callbacks as Brady suggested in
https://bugs.webkit.org/show_bug.cgi?id=38928#c27
This should stop the flake. As an added bonus this test no longer
needs platform specific results.

  • fast/loader/recursive-before-unload-crash-expected.txt:
  • fast/loader/recursive-before-unload-crash.html:
  • platform/chromium-linux/fast/loader/recursive-before-unload-crash-expected.txt: Removed.
  • platform/mac-tiger/fast/loader/recursive-before-unload-crash-expected.txt: Removed.
12:16 Changeset [66680] by tony@chromium.org
  • 2 edits
    2 adds in trunk/LayoutTests

2010-09-02 Tony Chang <tony@chromium.org>

Unreviewed, update chromium test expectations.

  • platform/chromium/fast/events/continuous-platform-wheelevent-in-scrolling-div-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
12:11 Changeset [66679] by weinig@apple.com
  • 8 edits in trunk/WebKit2

Simplify ownership semantics of some WebKit2 types
https://bugs.webkit.org/show_bug.cgi?id=45120

Reviewed by Anders Carlsson.

  • Make ImmutableArray and MutableArray use a Vector<RefPtr<APIObject> > and therefore ref any items it takes in.
  • Make the PostMessageDecoder operate on a RefPtr<APIObject>& to avoid the odd leaking semantics.
  • Shared/ImmutableArray.cpp:

(WebKit::ImmutableArray::ImmutableArray): This constructor now uses a for-loop
instead of memcpy to ref each item.
(WebKit::ImmutableArray::~ImmutableArray): No longer necessary to manually deref.

  • Shared/ImmutableArray.h:

(WebKit::ImmutableArray::adopt):
(WebKit::ImmutableArray::at):
Changes to accommodate entries being changed to a Vector<RefPtr<APIObject> >.

  • Shared/ImmutableDictionary.cpp:

(WebKit::ImmutableDictionary::keys):
Build a Vector<RefPtr<APIObject> >.

  • UIProcess/WebBackForwardList.cpp:

(WebKit::WebBackForwardList::backListAsImmutableArrayWithLimit):
(WebKit::WebBackForwardList::forwardListAsImmutableArrayWithLimit):
Ditto.

  • UIProcess/WebContext.cpp:

(WebKit::PostMessageEncoder::PostMessageDecoder::PostMessageDecoder):
(WebKit::PostMessageEncoder::PostMessageDecoder::decode):
(WebKit::WebContext::didReceiveMessage):
APIObject>& to avoid the odd leaking semantics.

  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::PostMessageEncoder::PostMessageDecoder::PostMessageDecoder):
(WebKit::PostMessageEncoder::PostMessageDecoder::decode):
(WebKit::InjectedBundle::didReceiveMessage):
Ditto.

  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::childFrames):
Build a Vector<RefPtr<APIObject> >.

12:06 Changeset [66678] by rniwa@webkit.org
  • 5 edits
    4 adds
    39 deletes in trunk/LayoutTests

2010-09-02 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Kent Tamura.

dumpAsText/Markup conversion: editing/style/block-style-004.html through block-style-006.html and editing/style/fontsize-1.html
https://bugs.webkit.org/show_bug.cgi?id=45050

  • editing/style/block-style-004-expected.txt: Added.
  • editing/style/block-style-004.html:
  • editing/style/block-style-005.html:
  • editing/style/block-style-006.html:
  • editing/style/fontsize-1.html:
  • platform/chromium-linux/editing/style/block-style-004-expected.checksum: Removed.
  • platform/chromium-linux/editing/style/block-style-004-expected.png: Removed.
  • platform/chromium-linux/editing/style/block-style-005-expected.checksum: Removed.
  • platform/chromium-linux/editing/style/block-style-005-expected.png: Removed.
  • platform/chromium-linux/editing/style/block-style-006-expected.checksum: Removed.
  • platform/chromium-linux/editing/style/block-style-006-expected.png: Removed.
  • platform/chromium-linux/editing/style/fontsize-1-expected.checksum: Removed.
  • platform/chromium-linux/editing/style/fontsize-1-expected.png: Removed.
  • platform/chromium-win/editing/style/block-style-004-expected.checksum: Removed.
  • platform/chromium-win/editing/style/block-style-004-expected.png: Removed.
  • platform/chromium-win/editing/style/block-style-004-expected.txt: Removed.
  • platform/chromium-win/editing/style/block-style-005-expected.checksum: Removed.
  • platform/chromium-win/editing/style/block-style-005-expected.png: Removed.
  • platform/chromium-win/editing/style/block-style-005-expected.txt: Removed.
  • platform/chromium-win/editing/style/block-style-006-expected.checksum: Removed.
  • platform/chromium-win/editing/style/block-style-006-expected.png: Removed.
  • platform/chromium-win/editing/style/block-style-006-expected.txt: Removed.
  • platform/chromium-win/editing/style/fontsize-1-expected.checksum: Removed.
  • platform/chromium-win/editing/style/fontsize-1-expected.png: Removed.
  • platform/chromium-win/editing/style/fontsize-1-expected.txt: Removed.
  • platform/gtk/editing/style/fontsize-1-expected.txt: Removed.
  • platform/mac-leopard/editing/style/fontsize-1-expected.checksum: Removed.
  • platform/mac-leopard/editing/style/fontsize-1-expected.png: Removed.
  • platform/mac/editing/style/block-style-004-expected.checksum: Removed.
  • platform/mac/editing/style/block-style-004-expected.png: Removed.
  • platform/mac/editing/style/block-style-004-expected.txt: Removed.
  • platform/mac/editing/style/block-style-005-expected.checksum: Removed.
  • platform/mac/editing/style/block-style-005-expected.png: Removed.
  • platform/mac/editing/style/block-style-005-expected.txt: Removed.
  • platform/mac/editing/style/block-style-006-expected.checksum: Removed.
  • platform/mac/editing/style/block-style-006-expected.png: Removed.
  • platform/mac/editing/style/block-style-006-expected.txt: Removed.
  • platform/mac/editing/style/fontsize-1-expected.checksum: Removed.
  • platform/mac/editing/style/fontsize-1-expected.png: Removed.
  • platform/mac/editing/style/fontsize-1-expected.txt: Removed.
  • platform/qt/editing/style/block-style-004-expected.txt: Removed.
  • platform/qt/editing/style/block-style-005-expected.txt: Removed.
  • platform/qt/editing/style/block-style-006-expected.txt: Removed.
  • platform/qt/editing/style/fontsize-1-expected.txt: Removed.
11:55 Changeset [66677] by japhet@chromium.org
  • 8 edits in trunk

2010-09-02 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r66671.
http://trac.webkit.org/changeset/66671
https://bugs.webkit.org/show_bug.cgi?id=45115

http/tests/misc/redirect-to-about-blank.html is failing on
several platforms (Requested by japhet on #webkit).

  • WebCore.exp.in:
  • dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::updateURLForPushOrReplaceState):
  • loader/DocumentWriter.cpp: (WebCore::DocumentWriter::begin):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::iconURL): (WebCore::FrameLoader::didOpenURL): (WebCore::FrameLoader::didExplicitOpen): (WebCore::FrameLoader::receivedFirstData): (WebCore::FrameLoader::setURL): (WebCore::FrameLoader::startIconLoader): (WebCore::FrameLoader::commitIconURLToIconDatabase): (WebCore::FrameLoader::finishedParsing): (WebCore::FrameLoader::checkIfDisplayInsecureContent): (WebCore::FrameLoader::checkIfRunInsecureContent): (WebCore::FrameLoader::updateFirstPartyForCookies): (WebCore::FrameLoader::loadInSameDocument): (WebCore::FrameLoader::commitProvisionalLoad): (WebCore::FrameLoader::open): (WebCore::FrameLoader::shouldScrollToAnchor):
  • loader/FrameLoader.h: (WebCore::FrameLoader::url):
11:32 Changeset [66676] by weinig@apple.com
  • 9 edits
    4 adds in trunk/WebKit2

Add WKMutableDictionary API for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=45117

Reviewed by Anders Carlsson.

Add WKMutableDictionary API that inherits from WKDictionaryRef
the same way WKMutableArrayRef inherits from WKArrayRef.

  • Shared/ImmutableDictionary.h:

(WebKit::ImmutableDictionary::get):
(WebKit::ImmutableDictionary::isMutable):

  • Shared/MutableDictionary.cpp: Added.

(WebKit::MutableDictionary::MutableDictionary):
(WebKit::MutableDictionary::~MutableDictionary):
(WebKit::MutableDictionary::add):
(WebKit::MutableDictionary::set):

  • Shared/MutableDictionary.h: Added.

(WebKit::MutableDictionary::create):
(WebKit::MutableDictionary::isMutable):

  • UIProcess/API/C/WKAPICast.h:

(toWK):

  • UIProcess/API/C/WKBase.h:
  • UIProcess/API/C/WKMutableDictionary.cpp: Added.

(WKMutableDictionaryCreate):
(WKDictionaryIsMutable):
(WKDictionaryAddItem):
(WKDictionarySetItem):

  • UIProcess/API/C/WKMutableDictionary.h: Added.
  • UIProcess/API/C/WebKit2.h:
  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:
  • win/WebKit2Generated.make:
10:54 Changeset [66675] by zmo@google.com
  • 69 edits
    4 adds
    1 delete in trunk

2010-09-01 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Roll ANGLE under webkit to r402
https://bugs.webkit.org/show_bug.cgi?id=45004

  • platform/graphics/mac/GraphicsContext3DMac.mm: Update the code to use newer ANGLE interface. (WebCore::GraphicsContext3D::GraphicsContext3D):

2010-09-01 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Roll ANGLE under webkit to r402
https://bugs.webkit.org/show_bug.cgi?id=45004

  • ANGLE.xcodeproj/project.pbxproj:
  • include/GLES2/gl2ext.h:
  • include/GLSLANG/ResourceLimits.h: Removed.
  • include/GLSLANG/ShaderLang.h:
  • src/compiler/BaseTypes.h: (getPrecisionString): (getBasicString): (IsSampler): (getQualifierString):
  • src/compiler/Initialize.cpp: (BuiltInConstants): (IdentifyBuiltIns):
  • src/compiler/Initialize.h:
  • src/compiler/InitializeDll.cpp: (InitProcess): (DetachProcess): (InitThread): (DetachThread):
  • src/compiler/InitializeDll.h:
  • src/compiler/InitializeParseContext.h:
  • src/compiler/Intermediate.cpp: (GetHigherPrecision): (TIntermediate::addBinaryMath): (TIntermediate::setAggregateOperator): (TIntermediate::addComma): (TIntermediate::postProcess): (TIntermBinary::promote): (CompareStruct):
  • src/compiler/OutputGLSL.cpp: (TOutputGLSL::writeFunctionParameters): (TOutputGLSL::visitUnary): (TOutputGLSL::visitBranch):
  • src/compiler/OutputHLSL.cpp: (sh::OutputHLSL::header): (sh::OutputHLSL::visitBinary): (sh::OutputHLSL::visitAggregate): (sh::OutputHLSL::handleExcessiveLoop): (sh::OutputHLSL::addConstructor):
  • src/compiler/ParseHelper.cpp: (TParseContext::constructorErrorCheck): (TParseContext::samplerErrorCheck): (TParseContext::paramErrorCheck): (TParseContext::findFunction): (TParseContext::executeInitializer): (TParseContext::addConstructor): (TParseContext::addConstStruct): (FreeParseContextIndex): (GetGlobalParseContext):
  • src/compiler/PoolAlloc.h: (TPoolAllocator::tHeader::tHeader): (pool_allocator::allocate): (pool_allocator::deallocate):
  • src/compiler/ShaderLang.cpp: (ShInitialize): (ShFinalize): (ShInitBuiltInResource):
  • src/compiler/SymbolTable.cpp: (TType::getStructSize):
  • src/compiler/SymbolTable.h: (TVariable::setQualifier):
  • src/compiler/Types.h: (TType::TType): (TType::getBasicType): (TType::setBasicType): (TType::getPrecision): (TType::setPrecision): (TType::getQualifier): (TType::setQualifier): (TType::getNominalSize): (TType::setNominalSize): (TType::isMatrix): (TType::setMatrix): (TType::isArray): (TType::getArraySize): (TType::setArraySize): (TType::getMaxArraySize): (TType::setMaxArraySize): (TType::clearArrayness): (TType::setArrayInformationType): (TType::getArrayInformationType): (TType::isVector): (TType::isScalar): (TType::setStruct): (TType::getTypeName): (TType::setTypeName): (TType::isField): (TType::getFieldName): (TType::setFieldName): (TType::getBasicString): (TType::getPrecisionString): (TType::getQualifierString):
  • src/compiler/glslang.l:
  • src/compiler/glslang.y:
  • src/compiler/intermediate.h: (TIntermNode::getLine): (TIntermNode::setLine): (TIntermTyped::getAsTyped): (TIntermTyped::setType): (TIntermTyped::getType): (TIntermTyped::getTypePointer): (TIntermTyped::getBasicType): (TIntermTyped::getQualifier): (TIntermTyped::getPrecision): (TIntermTyped::getNominalSize): (TIntermTyped::isMatrix): (TIntermTyped::isArray): (TIntermTyped::isVector): (TIntermTyped::isScalar): (TIntermTyped::getBasicString): (TIntermTyped::getQualifierString): (TIntermSymbol::getId): (TIntermSymbol::getSymbol): (TIntermOperator::setOp): (TIntermBinary::setLeft): (TIntermBinary::setRight): (TIntermBinary::getLeft): (TIntermBinary::getRight): (TIntermUnary::setOperand): (TIntermUnary::getOperand): (TIntermAggregate::getAsAggregate): (TIntermAggregate::getSequence): (TIntermAggregate::setName): (TIntermAggregate::getName): (TIntermAggregate::setUserDefined): (TIntermAggregate::isUserDefined): (TIntermAggregate::getQualifier): (TIntermAggregate::setOptimize): (TIntermAggregate::setDebug): (TIntermSelection::getCondition): (TIntermSelection::getTrueBlock): (TIntermSelection::getFalseBlock): (TIntermSelection::getAsSelectionNode):
  • src/compiler/parseConst.cpp: (TConstTraverser::TConstTraverser):
  • src/compiler/preprocessor/atom.c: (InitAtomTable):
  • src/compiler/preprocessor/atom.h:
  • src/compiler/preprocessor/compile.h:
  • src/compiler/preprocessor/cpp.c:
  • src/compiler/preprocessor/cpp.h:
  • src/compiler/preprocessor/cppstruct.c:
  • src/compiler/preprocessor/memory.c:
  • src/compiler/preprocessor/memory.h:
  • src/compiler/preprocessor/parser.h:
  • src/compiler/preprocessor/preprocess.h:
  • src/compiler/preprocessor/scanner.c:
  • src/compiler/preprocessor/scanner.h:
  • src/compiler/preprocessor/slglobals.h:
  • src/compiler/preprocessor/symbols.c: (NewSymbol):
  • src/compiler/preprocessor/symbols.h:
  • src/compiler/preprocessor/tokens.c: (RecordToken):
  • src/compiler/preprocessor/tokens.h:
  • src/libEGL/Display.cpp: (egl::Display::Display): (egl::Display::initialize): (egl::Display::terminate): (egl::Display::createDevice): (egl::Display::createWindowSurface): (egl::Display::createContext): (egl::Display::getMultiSampleSupport): (egl::Display::getCompressedTextureSupport):
  • src/libEGL/Display.h:
  • src/libEGL/Surface.cpp: (egl::Surface::Surface): (egl::Surface::resetSwapChain): (egl::Surface::getWindowHandle): (egl::Surface::writeRecordableFlipState): (egl::Surface::applyFlipState): (egl::Surface::releaseRecordedState): (egl::Surface::checkForWindowResize): (egl::Surface::swap):
  • src/libEGL/Surface.h:
  • src/libEGL/libEGL.cpp:
  • src/libEGL/libEGL.vcproj:
  • src/libGLESv2/Blit.cpp: (gl::Blit::setVertexShader): (gl::Blit::setPixelShader): (gl::Blit::setFormatConvertShaders):
  • src/libGLESv2/Buffer.cpp: (gl::Buffer::Buffer):
  • src/libGLESv2/Buffer.h:
  • src/libGLESv2/Context.cpp: (gl::Context::Context): (gl::Context::~Context): (gl::Context::makeCurrent): (gl::Context::markAllStateDirty): (gl::Context::getReadFramebufferHandle): (gl::Context::getDrawFramebufferHandle): (gl::Context::getRenderbufferHandle): (gl::Context::getArrayBufferHandle): (gl::Context::setVertexAttribState): (gl::Context::createBuffer): (gl::Context::createProgram): (gl::Context::createShader): (gl::Context::createTexture): (gl::Context::createRenderbuffer): (gl::Context::deleteBuffer): (gl::Context::deleteShader): (gl::Context::deleteProgram): (gl::Context::deleteTexture): (gl::Context::deleteRenderbuffer): (gl::Context::getBuffer): (gl::Context::getShader): (gl::Context::getProgram): (gl::Context::getTexture): (gl::Context::getRenderbuffer): (gl::Context::getReadFramebuffer): (gl::Context::getDrawFramebuffer): (gl::Context::bindArrayBuffer): (gl::Context::bindElementArrayBuffer): (gl::Context::bindTexture2D): (gl::Context::bindTextureCubeMap): (gl::Context::bindReadFramebuffer): (gl::Context::bindDrawFramebuffer): (gl::Context::bindRenderbuffer): (gl::Context::useProgram): (gl::Context::setFramebufferZero): (gl::Context::setRenderbufferStorage): (gl::Context::getFramebuffer): (gl::Context::getArrayBuffer): (gl::Context::getElementArrayBuffer): (gl::Context::getCurrentProgram): (gl::Context::getTexture2D): (gl::Context::getTextureCubeMap): (gl::Context::getSamplerTexture): (gl::Context::getFloatv): (gl::Context::getIntegerv): (gl::Context::getQueryParameterInfo): (gl::Context::applyRenderTarget): (gl::Context::applyState): (gl::Context::applyIndexBuffer): (gl::Context::readPixels): (gl::Context::clear): (gl::Context::finish): (gl::Context::flush): (gl::Context::supportsShaderModel3): (gl::Context::getMaxSupportedSamples): (gl::Context::getNearestSupportedSamples): (gl::Context::supportsCompressedTextures): (gl::Context::detachBuffer): (gl::Context::detachTexture): (gl::Context::detachFramebuffer): (gl::Context::detachRenderbuffer): (gl::Context::getIncompleteTexture): (gl::Context::initExtensionString): (gl::Context::blitFramebuffer):
  • src/libGLESv2/Context.h: (gl::AttributeState::AttributeState):
  • src/libGLESv2/Framebuffer.cpp: (gl::Framebuffer::Framebuffer): (gl::Framebuffer::~Framebuffer): (gl::Framebuffer::lookupRenderbuffer): (gl::Framebuffer::setColorbuffer): (gl::Framebuffer::setDepthbuffer): (gl::Framebuffer::setStencilbuffer): (gl::Framebuffer::detachTexture): (gl::Framebuffer::detachRenderbuffer): (gl::Framebuffer::getRenderTargetSerial): (gl::Framebuffer::getRenderTarget): (gl::Framebuffer::getDepthStencil): (gl::Framebuffer::getDepthbufferSerial): (gl::Framebuffer::getStencilbufferSerial): (gl::Framebuffer::getColorbuffer): (gl::Framebuffer::getDepthbuffer): (gl::Framebuffer::getStencilbuffer): (gl::Framebuffer::getColorbufferHandle): (gl::Framebuffer::getDepthbufferHandle): (gl::Framebuffer::getStencilbufferHandle): (gl::Framebuffer::hasStencil): (gl::Framebuffer::isMultisample): (gl::Framebuffer::completeness): (gl::DefaultFramebuffer::DefaultFramebuffer): (gl::Framebuffer::getSamples): (gl::DefaultFramebuffer::completeness):
  • src/libGLESv2/Framebuffer.h:
  • src/libGLESv2/Program.cpp: (gl::Program::Program): (gl::Program::~Program): (gl::Program::attachShader): (gl::Program::detachShader): (gl::Program::linkVaryings): (gl::Program::link): (gl::Program::unlink): (gl::Program::release): (gl::Program::addRef): (gl::Program::getRefCount): (gl::Program::getDxViewportLocation):
  • src/libGLESv2/Program.h:
  • src/libGLESv2/RefCountObject.cpp: Added. (gl::RefCountObject::RefCountObject): (gl::RefCountObject::~RefCountObject): (gl::RefCountObject::addRef): (gl::RefCountObject::release): (gl::RefCountObjectBindingPointer::set):
  • src/libGLESv2/RefCountObject.h: Added. (gl::RefCountObject::id): (gl::RefCountObjectBindingPointer::RefCountObjectBindingPointer): (gl::RefCountObjectBindingPointer::~RefCountObjectBindingPointer): (gl::RefCountObjectBindingPointer::get): (gl::RefCountObjectBindingPointer::id): (gl::RefCountObjectBindingPointer::operator ! ): (gl::BindingPointer::set): (gl::BindingPointer::get): (gl::BindingPointer::operator -> ):
  • src/libGLESv2/Renderbuffer.cpp: (gl::Renderbuffer::Renderbuffer): (gl::Renderbuffer::~Renderbuffer): (gl::Renderbuffer::isColorbuffer): (gl::Renderbuffer::isDepthbuffer): (gl::Renderbuffer::isStencilbuffer): (gl::Renderbuffer::getRenderTarget): (gl::Renderbuffer::getDepthStencil): (gl::Renderbuffer::getWidth): (gl::Renderbuffer::getHeight): (gl::Renderbuffer::getFormat): (gl::Renderbuffer::getD3DFormat): (gl::Renderbuffer::getSerial): (gl::Renderbuffer::setStorage): (gl::RenderbufferStorage::RenderbufferStorage): (gl::RenderbufferStorage::~RenderbufferStorage): (gl::RenderbufferStorage::isColorbuffer): (gl::RenderbufferStorage::isDepthbuffer): (gl::RenderbufferStorage::isStencilbuffer): (gl::RenderbufferStorage::getRenderTarget): (gl::RenderbufferStorage::getDepthStencil): (gl::RenderbufferStorage::getWidth): (gl::RenderbufferStorage::getHeight): (gl::RenderbufferStorage::setSize): (gl::RenderbufferStorage::getFormat): (gl::RenderbufferStorage::getD3DFormat): (gl::RenderbufferStorage::getSamples): (gl::RenderbufferStorage::getSerial): (gl::RenderbufferStorage::issueSerial): (gl::Colorbuffer::Colorbuffer): (gl::Colorbuffer::isColorbuffer): (gl::Colorbuffer::getRedSize): (gl::Colorbuffer::getGreenSize): (gl::Colorbuffer::getBlueSize): (gl::Colorbuffer::getAlphaSize): (gl::DepthStencilbuffer::DepthStencilbuffer): (gl::DepthStencilbuffer::~DepthStencilbuffer): (gl::DepthStencilbuffer::isDepthbuffer): (gl::DepthStencilbuffer::isStencilbuffer): (gl::DepthStencilbuffer::getDepthSize): (gl::DepthStencilbuffer::getStencilSize): (gl::DepthStencilbuffer::getDepthStencil): (gl::Depthbuffer::Depthbuffer): (gl::Depthbuffer::~Depthbuffer): (gl::Depthbuffer::isDepthbuffer): (gl::Depthbuffer::isStencilbuffer): (gl::Stencilbuffer::Stencilbuffer): (gl::Stencilbuffer::~Stencilbuffer): (gl::Stencilbuffer::isDepthbuffer): (gl::Stencilbuffer::isStencilbuffer):
  • src/libGLESv2/Renderbuffer.h: (gl::Renderbuffer::getStorage):
  • src/libGLESv2/ResourceManager.cpp: Added. (gl::ResourceManager::ResourceManager): (gl::ResourceManager::~ResourceManager): (gl::ResourceManager::addRef): (gl::ResourceManager::release): (gl::ResourceManager::createBuffer): (gl::ResourceManager::createShader): (gl::ResourceManager::createProgram): (gl::ResourceManager::createTexture): (gl::ResourceManager::createRenderbuffer): (gl::ResourceManager::deleteBuffer): (gl::ResourceManager::deleteShader): (gl::ResourceManager::deleteProgram): (gl::ResourceManager::deleteTexture): (gl::ResourceManager::deleteRenderbuffer): (gl::ResourceManager::getBuffer): (gl::ResourceManager::getShader): (gl::ResourceManager::getTexture): (gl::ResourceManager::getProgram): (gl::ResourceManager::getRenderbuffer): (gl::ResourceManager::setRenderbuffer): (gl::ResourceManager::checkBufferAllocation): (gl::ResourceManager::checkTextureAllocation): (gl::ResourceManager::checkRenderbufferAllocation):
  • src/libGLESv2/ResourceManager.h: Added.
  • src/libGLESv2/Shader.cpp: (gl::Shader::Shader): (gl::Shader::addRef): (gl::Shader::release): (gl::Shader::getRefCount): (gl::Shader::parseVaryings): (gl::VertexShader::VertexShader): (gl::FragmentShader::FragmentShader):
  • src/libGLESv2/Shader.h:
  • src/libGLESv2/Texture.cpp: (gl::Texture::Image::Image): (gl::Texture::Texture): (gl::Texture::getBlitter): (gl::Texture::selectFormat): (gl::Texture::loadImageData): (gl::Texture::loadAlphaImageData): (gl::Texture::loadLuminanceImageData): (gl::Texture::loadLuminanceAlphaImageData): (gl::Texture::loadRGBUByteImageData): (gl::Texture::loadRGB565ImageData): (gl::Texture::loadRGBAUByteImageData): (gl::Texture::loadRGBA4444ImageData): (gl::Texture::loadRGBA5551ImageData): (gl::Texture::loadBGRAImageData): (gl::Texture::createSurface): (gl::Texture::setImage): (gl::Texture::setCompressedImage): (gl::Texture::subImage): (gl::Texture::subImageCompressed): (gl::Texture2D::Texture2D): (gl::Texture2D::getFormat): (gl::Texture2D::setCompressedImage): (gl::Texture2D::subImage): (gl::Texture2D::subImageCompressed): (gl::Texture2D::copyImage): (gl::Texture2D::copySubImage): (gl::Texture2D::isCompressed): (gl::Texture2D::getColorbuffer): (gl::TextureCubeMap::TextureCubeMap): (gl::TextureCubeMap::getFormat): (gl::TextureCubeMap::setCompressedImage): (gl::TextureCubeMap::subImage): (gl::TextureCubeMap::subImageCompressed): (gl::TextureCubeMap::isCompressed): (gl::TextureCubeMap::copyImage): (gl::TextureCubeMap::copySubImage): (gl::TextureCubeMap::getColorbuffer): (gl::Texture::TextureColorbufferProxy::addRef): (gl::Texture::TextureColorbufferProxy::release): (gl::Texture::TextureColorbufferProxy::getWidth): (gl::Texture::TextureColorbufferProxy::getHeight): (gl::Texture::TextureColorbufferProxy::getFormat):
  • src/libGLESv2/Texture.h:
  • src/libGLESv2/libGLESv2.cpp:
  • src/libGLESv2/libGLESv2.def:
  • src/libGLESv2/libGLESv2.vcproj:
  • src/libGLESv2/main.h:
  • src/libGLESv2/utilities.cpp: (gl::ComputeCompressedPitch): (gl::ComputeCompressedSize): (gl::IsCompressed): (gl::ComputePixelSize): (gl::CheckTextureFormatType): (es2dx::ConvertRenderbufferFormat): (es2dx::GetSamplesFromMultisampleType): (es2dx::GetMultisampleTypeFromSamples):
  • src/libGLESv2/utilities.h:
10:10 Changeset [66674] by loislo@chromium.org
  • 2 edits in trunk/WebCore

2010-09-02 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

WebInspector: Timeline instrumentation code can crash browser.

Steps:
1) load the site
2) open inspector
3) start timeline recording
4) reload inspected page
got NPE

https://bugs.webkit.org/show_bug.cgi?id=45098

  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::didReceiveResponse): (WebCore::ResourceLoader::didReceiveData):
09:31 Changeset [66673] by jberlin@webkit.org
  • 3 edits in trunk/WebKit2

2010-09-02 Jessie Berlin <jberlin@apple.com>

Windows build fix. Unreviewed.

  • UIProcess/API/win/WKAPICastWin.h: (toWK):
  • UIProcess/API/win/WKBaseWin.h:
09:30 Changeset [66672] by caseq@chromium.org
  • 4 edits
    2 deletes in trunk/LayoutTests

2010-09-02 Andrey Kosyakov <caseq@chromium.org>

Unreviewed test fix.
Add size & bodySize to list of non-deterministic fields for HAR tests, as those tend to vary by platform
in error responses.
Remove platform-specific expectations that were previously added because of this.

  • http/tests/inspector/resource-har-conversion-expected.txt:
  • http/tests/inspector/resource-har-conversion.html:
  • http/tests/inspector/resource-test2.js:
  • platform/chromium-win/inspector/resource-har-conversion-expected.txt: Removed.
  • platform/win/http/tests/inspector/resource-har-conversion-expected.txt: Removed.
09:19 Changeset [66671] by japhet@chromium.org
  • 8 edits in trunk

2010-09-02 Nate Chapin <japhet@chromium.org>

Reviewed by Adam Barth.

Remove m_URL from FrameLoader and instead depend on Document's url.
FrameLoader::url() will be removed in a later patch.

http://bugs.webkit.org/show_bug.cgi?id=41165

No new tests, since this predominantly a refactor. Updating
fast/dom/early-frame-url.html.

  • WebCore.exp.in:
  • dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::updateURLForPushOrReplaceState):
  • loader/DocumentWriter.cpp: (WebCore::DocumentWriter::begin):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::iconURL): (WebCore::FrameLoader::didOpenURL): (WebCore::FrameLoader::didExplicitOpen): (WebCore::FrameLoader::receivedFirstData): (WebCore::FrameLoader::url): (WebCore::FrameLoader::setOutgoingReferrer): (WebCore::FrameLoader::startIconLoader): (WebCore::FrameLoader::commitIconURLToIconDatabase): (WebCore::FrameLoader::finishedParsing): (WebCore::FrameLoader::checkIfDisplayInsecureContent): (WebCore::FrameLoader::checkIfRunInsecureContent): (WebCore::FrameLoader::updateFirstPartyForCookies): (WebCore::FrameLoader::loadInSameDocument): (WebCore::FrameLoader::commitProvisionalLoad): (WebCore::FrameLoader::open): (WebCore::FrameLoader::shouldScrollToAnchor):
  • loader/FrameLoader.h:
08:45 Changeset [66670] by tonyg@chromium.org
  • 14 edits
    28 adds in trunk

2010-09-01 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Adam Barth.

Support <script defer> as specified by HTML5
https://bugs.webkit.org/show_bug.cgi?id=40934

  • fast/dom/HTMLScriptElement/defer-double-defer-write-expected.txt: Added.
  • fast/dom/HTMLScriptElement/defer-double-defer-write.html: Added. Tests that a write of a deferred script from a deferred script will execute when the document is closed. The explicit close is necessary because this is a script created parser.
  • fast/dom/HTMLScriptElement/defer-double-write-expected.txt: Added.
  • fast/dom/HTMLScriptElement/defer-double-write.html: Added. Tests that a script block written from a deferred script will write into the new document.
  • fast/dom/HTMLScriptElement/defer-inline-script-expected.txt: Added.
  • fast/dom/HTMLScriptElement/defer-inline-script.html: Added. Tests that inline scripts are not deferred. This is consistent with HTML5 and inconsistent with IE.
  • fast/dom/HTMLScriptElement/defer-onbeforeload-expected.txt: Added.
  • fast/dom/HTMLScriptElement/defer-onbeforeload.html: Added. Tests that the beforeload event is fired immediately and is cancellable.
  • fast/dom/HTMLScriptElement/defer-script-invalid-url-expected.txt: Added.
  • fast/dom/HTMLScriptElement/defer-script-invalid-url.html: Added. Tests that deferred scripts with invalid URLs are ignored and that subsequent deferred scripts will be run.
  • fast/dom/HTMLScriptElement/defer-write-expected.txt: Added.
  • fast/dom/HTMLScriptElement/defer-write.html: Added. Tests that a basic write from a deferred script blows away the document.
  • fast/dom/HTMLScriptElement/resources/defer.js: Added.
  • fast/dom/HTMLScriptElement/resources/external.js: Added.
  • fast/dom/HTMLScriptElement/resources/shouldnotexecute.js: Added.
  • fast/dom/HTMLScriptElement/shouldnotexecute.js: Added.
  • fast/dom/HTMLScriptElement/two-defer-writes-expected.txt: Added.
  • fast/dom/HTMLScriptElement/two-defer-writes.html: Added. Tests that when a document.write from the first deferred script blows away the document, subsequent deferred scripts are not executed.
  • http/tests/misc/resources/defer-script.js: Added.
  • http/tests/misc/resources/external-script.js: Added.
  • http/tests/misc/resources/script-debug-body-background.js: Added.
  • http/tests/misc/resources/script-write-slow-stylesheet.js: Added.
  • http/tests/misc/resources/slow-defer-script.cgi: Added.
  • http/tests/misc/resources/slow-stylesheet.cgi: Added.
  • http/tests/misc/script-defer-after-slow-stylesheet-expected.txt: Added.
  • http/tests/misc/script-defer-after-slow-stylesheet.html: Added. Tests that deferred scripts respect blocking stylesheets.
  • http/tests/misc/script-defer-expected.txt: Added.
  • http/tests/misc/script-defer.html: Added. Tests basic ordering of deferred scripts.

2010-09-01 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Adam Barth.

Support <script defer> as specified by HTML5
https://bugs.webkit.org/show_bug.cgi?id=40934

Tests: fast/dom/HTMLScriptElement/defer-double-defer-write.html

fast/dom/HTMLScriptElement/defer-double-write.html
fast/dom/HTMLScriptElement/defer-inline-script.html
fast/dom/HTMLScriptElement/defer-onbeforeload.html
fast/dom/HTMLScriptElement/defer-script-invalid-url.html
fast/dom/HTMLScriptElement/defer-write.html
fast/dom/HTMLScriptElement/two-defer-writes.html
http/tests/misc/script-defer-after-slow-stylesheet.html
http/tests/misc/script-defer.html

  • dom/Document.cpp: (WebCore::Document::open): Allow implicit open for writes() while executing deferred scripts.
  • dom/DocumentParser.cpp: (WebCore::DocumentParser::DocumentParser): (WebCore::DocumentParser::startParsing): (WebCore::DocumentParser::prepareToStopParsing): If called when stopped or detached, it shouldn't reset to stopping. (WebCore::DocumentParser::stopParsing): (WebCore::DocumentParser::detach):
  • dom/DocumentParser.h: (WebCore::DocumentParser::isParsing): (WebCore::DocumentParser::isActive): (WebCore::DocumentParser::isStopping): (WebCore::DocumentParser::isDetached):
  • dom/RawDataDocumentParser.h: (WebCore::RawDataDocumentParser::finish):
  • dom/XMLDocumentParser.cpp: (WebCore::XMLDocumentParser::append): (WebCore::XMLDocumentParser::exitText):
  • dom/XMLDocumentParserLibxml2.cpp: (WebCore::XMLDocumentParser::doWrite): (WebCore::XMLDocumentParser::startElementNs): (WebCore::XMLDocumentParser::endElementNs): (WebCore::XMLDocumentParser::characters): (WebCore::XMLDocumentParser::error): (WebCore::XMLDocumentParser::processingInstruction): (WebCore::XMLDocumentParser::cdataBlock): (WebCore::XMLDocumentParser::comment): (WebCore::XMLDocumentParser::internalSubset): (WebCore::XMLDocumentParser::initializeParserContext): (WebCore::XMLDocumentParser::doEnd):
  • html/parser/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::prepareToStopParsing): (WebCore::HTMLDocumentParser::pumpTokenizerIfPossible): (WebCore::HTMLDocumentParser::pumpTokenizer): (WebCore::HTMLDocumentParser::insert): (WebCore::HTMLDocumentParser::append): (WebCore::HTMLDocumentParser::end): (WebCore::HTMLDocumentParser::attemptToEnd): (WebCore::HTMLDocumentParser::endIfDelayed): (WebCore::HTMLDocumentParser::notifyFinished):
  • html/parser/HTMLDocumentParser.h:
  • html/parser/HTMLScriptRunner.cpp: (WebCore::HTMLScriptRunner::~HTMLScriptRunner): (WebCore::HTMLScriptRunner::executeParsingBlockingScript): (WebCore::HTMLScriptRunner::executePendingScriptAndDispatchEvent): (WebCore::HTMLScriptRunner::executeScriptsWaitingForParsing): (WebCore::HTMLScriptRunner::requestDeferredScript): (WebCore::HTMLScriptRunner::runScript):
  • html/parser/HTMLScriptRunner.h:
  • loader/ImageDocument.cpp: (WebCore::ImageDocumentParser::finish):
08:29 Changeset [66669] by caseq@chromium.org
  • 8 edits
    4 adds in trunk

2010-09-02 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: HAR converter fails on POST requests with non-form content type.
https://bugs.webkit.org/show_bug.cgi?id=45109

  • inspector/front-end/HAREntry.js: (WebInspector.HAREntry.prototype._buildPostData):

2010-09-02 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: HAR converter fails on POST requests with non-form content type.
Migrated HAR tests to inspector-test2.js, enabled resource tracking, added test for XHR POST request.
https://bugs.webkit.org/show_bug.cgi?id=45109

  • http/tests/inspector/resource-har-conversion-expected.txt:
  • http/tests/inspector/resource-har-conversion.html:
  • http/tests/inspector/resource-parameters-expected.txt:
  • http/tests/inspector/resource-test2.js: Added. (initialize_ResourceTest.InspectorTest.resourceURLComparer): (initialize_ResourceTest):
  • platform/chromium-win/http/tests/inspector/resource-parameters-expected.txt:
  • platform/chromium-win/http/tests/inspector/resource-har-conversion-expected.txt: Added.
  • platform/win/http/tests/inspector/console-xhr-logging-expected.txt: Added.
  • platform/win/http/tests/inspector/resource-har-conversion-expected.txt: Added.
  • platform/win/http/tests/inspector/resource-parameters-expected.txt:
06:35 Changeset [66668] by abarth@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-09-02 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add WTFURL to the JavaScriptCore build on Mac
https://bugs.webkit.org/show_bug.cgi?id=45075

Building code is good.

06:25 Changeset [66667] by andreas.kling@nokia.com
  • 4 edits in trunk

2010-09-02 Andreas Kling <andreas.kling@nokia.com>

Rubber-stamped by Simon Hausmann.

[Qt] REGRESSION(r62898): tst_QWebFrame crashing
https://bugs.webkit.org/show_bug.cgi?id=43039

Rolling out the offending change <http://trac.webkit.org/changeset/62898>

  • tests/qwebframe/tst_qwebframe.cpp: (tst_QWebFrame::evalJSV):

2010-09-02 Andreas Kling <andreas.kling@nokia.com>

Rubber-stamped by Simon Hausmann.

[Qt] REGRESSION(r62898): tst_QWebFrame crashing
https://bugs.webkit.org/show_bug.cgi?id=43039

Rolling out the offending change <http://trac.webkit.org/changeset/62898>

  • bridge/qt/qt_instance.cpp: (JSC::Bindings::QtInstance::markAggregate):
06:14 Changeset [66666] by commit-queue@webkit.org
  • 7 edits in trunk

2010-09-02 Peter Kasting <pkasting@google.com>

Reviewed by Dimitri Glazkov.

Implement [continuous]MouseScrollBy() on Chromium, and partly on GTK.
https://bugs.webkit.org/show_bug.cgi?id=45073

  • platform/chromium/test_expectations.txt: Unskip tests that should now pass.
  • platform/gtk/scrollbars/overflow-scrollbar-horizontal-wheel-scroll.html: Convert mouseWheelTo() to mouseScrollBy().

2010-09-02 Peter Kasting <pkasting@google.com>

Reviewed by Dimitri Glazkov.

Implement [continuous]MouseScrollBy() on Chromium, and partly on GTK.
https://bugs.webkit.org/show_bug.cgi?id=45073

  • DumpRenderTree/chromium/EventSender.cpp: (EventSender::EventSender): (EventSender::mouseScrollBy): (EventSender::continuousMouseScrollBy): (EventSender::sendCurrentTouchEvent): (EventSender::handleMouseWheel):
  • DumpRenderTree/chromium/EventSender.h:
  • DumpRenderTree/gtk/EventSender.cpp: (mouseScrollByCallback): (continuousMouseScrollByCallback):
05:57 Changeset [66665] by ap@apple.com
  • 6 edits in trunk/JavaScriptCore

2010-09-02 Alexey Proskuryakov <ap@apple.com>

Reviewed by Oliver Hunt.

https://bugs.webkit.org/show_bug.cgi?id=43230
<rdar://problem/8254215> REGRESSION: Memory leak within JSParser::JSParser

One can't delete a ThreadSpecific object that has data in it. It's not even possible to
enumerate data objects in all threads, much less destroy them from a thread that's destroying
the ThreadSpecific.

  • parser/JSParser.cpp: (JSC::JSParser::JSParser):
  • runtime/JSGlobalData.h:
  • wtf/WTFThreadData.cpp: (WTF::WTFThreadData::WTFThreadData):
  • wtf/WTFThreadData.h: (WTF::WTFThreadData::approximatedStackStart): Moved stack guard tracking from JSGlobalData to WTFThreadData.
  • wtf/ThreadSpecific.h: Made destructor unimplemented. It's dangerous, and we probably won't ever face a situation where we'd want to delete a ThreadSpecific object.
05:29 Changeset [66664] by antonm@chromium.org
  • 2 edits in trunk/WebCore

2010-09-02 Anton Muhin <antonm@chromium.org>

Reviewed by Tony Chang.

Fix indentation.
https://bugs.webkit.org/show_bug.cgi?id=44678

  • bindings/scripts/CodeGeneratorV8.pm:
05:09 Changeset [66663] by loislo@chromium.org
  • 4 edits in trunk/LayoutTests

2010-09-01 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

WebInspector: protocol related Inspector's tests are failing in Chromium.

The expectation is different because Chromium tests use test_shell.
1) a lot of console messages automaticaly published by test_shell;
2) debugger was enabled by default;
3) for (i in an_array) produces some garbage.

The solution:
1) override reportProtocolError and console.error functions;
2) debugger was explicitly disabled;
3) just fixed.

https://bugs.webkit.org/show_bug.cgi?id=44996

  • inspector/report-API-errors.html:
  • inspector/report-protocol-errors.html:
  • LayoutTests/platform/chromium/test_expectations.txt
04:46 Changeset [66662] by andreas.kling@nokia.com
  • 1 edit
    3 deletes in trunk/LayoutTests

2010-09-02 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r66656.
http://trac.webkit.org/changeset/66656
https://bugs.webkit.org/show_bug.cgi?id=45105

won't pass after 66655 rollout (Requested by kling on
#webkit).

  • fast/dom/Selection/script-tests/wrong-document-err.js: Removed.
  • fast/dom/Selection/wrong-document-err-expected.txt: Removed.
  • fast/dom/Selection/wrong-document-err.html: Removed.
04:45 Changeset [66661] by andreas.kling@nokia.com
  • 2 edits in trunk/WebCore

2010-09-02 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r66655.
http://trac.webkit.org/changeset/66655
https://bugs.webkit.org/show_bug.cgi?id=45104

broke some editing tests (Requested by kling on #webkit).

  • page/DOMSelection.cpp: (WebCore::DOMSelection::collapse): (WebCore::DOMSelection::selectAllChildren):
04:43 Changeset [66660] by commit-queue@webkit.org
  • 14 edits
    28 deletes in trunk

2010-09-02 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r66649.
http://trac.webkit.org/changeset/66649
https://bugs.webkit.org/show_bug.cgi?id=45103

It broke ~2000 tests on Qt bot (Requested by Ossy on #webkit).

  • fast/dom/HTMLScriptElement/defer-double-defer-write-expected.txt: Removed.
  • fast/dom/HTMLScriptElement/defer-double-defer-write.html: Removed.
  • fast/dom/HTMLScriptElement/defer-double-write-expected.txt: Removed.
  • fast/dom/HTMLScriptElement/defer-double-write.html: Removed.
  • fast/dom/HTMLScriptElement/defer-inline-script-expected.txt: Removed.
  • fast/dom/HTMLScriptElement/defer-inline-script.html: Removed.
  • fast/dom/HTMLScriptElement/defer-onbeforeload-expected.txt: Removed.
  • fast/dom/HTMLScriptElement/defer-onbeforeload.html: Removed.
  • fast/dom/HTMLScriptElement/defer-script-invalid-url-expected.txt: Removed.
  • fast/dom/HTMLScriptElement/defer-script-invalid-url.html: Removed.
  • fast/dom/HTMLScriptElement/defer-write-expected.txt: Removed.
  • fast/dom/HTMLScriptElement/defer-write.html: Removed.
  • fast/dom/HTMLScriptElement/resources/defer.js: Removed.
  • fast/dom/HTMLScriptElement/resources/external.js: Removed.
  • fast/dom/HTMLScriptElement/resources/shouldnotexecute.js: Removed.
  • fast/dom/HTMLScriptElement/shouldnotexecute.js: Removed.
  • fast/dom/HTMLScriptElement/two-defer-writes-expected.txt: Removed.
  • fast/dom/HTMLScriptElement/two-defer-writes.html: Removed.
  • http/tests/misc/resources/defer-script.js: Removed.
  • http/tests/misc/resources/external-script.js: Removed.
  • http/tests/misc/resources/script-debug-body-background.js: Removed.
  • http/tests/misc/resources/script-write-slow-stylesheet.js: Removed.
  • http/tests/misc/resources/slow-defer-script.cgi: Removed.
  • http/tests/misc/resources/slow-stylesheet.cgi: Removed.
  • http/tests/misc/script-defer-after-slow-stylesheet-expected.txt: Removed.
  • http/tests/misc/script-defer-after-slow-stylesheet.html: Removed.
  • http/tests/misc/script-defer-expected.txt: Removed.
  • http/tests/misc/script-defer.html: Removed.

2010-09-02 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r66649.
http://trac.webkit.org/changeset/66649
https://bugs.webkit.org/show_bug.cgi?id=45103

It broke ~2000 tests on Qt bot (Requested by Ossy on #webkit).

  • dom/Document.cpp: (WebCore::Document::open):
  • dom/DocumentParser.cpp: (WebCore::DocumentParser::DocumentParser): (WebCore::DocumentParser::detach):
  • dom/DocumentParser.h: (WebCore::DocumentParser::isDetached): (WebCore::DocumentParser::stopParsing):
  • dom/RawDataDocumentParser.h: (WebCore::RawDataDocumentParser::finish):
  • dom/XMLDocumentParser.cpp: (WebCore::XMLDocumentParser::append): (WebCore::XMLDocumentParser::exitText):
  • dom/XMLDocumentParserLibxml2.cpp: (WebCore::XMLDocumentParser::doWrite): (WebCore::XMLDocumentParser::startElementNs): (WebCore::XMLDocumentParser::endElementNs): (WebCore::XMLDocumentParser::characters): (WebCore::XMLDocumentParser::error): (WebCore::XMLDocumentParser::processingInstruction): (WebCore::XMLDocumentParser::cdataBlock): (WebCore::XMLDocumentParser::comment): (WebCore::XMLDocumentParser::internalSubset): (WebCore::XMLDocumentParser::initializeParserContext): (WebCore::XMLDocumentParser::doEnd):
  • dom/XMLDocumentParserQt.cpp: (WebCore::XMLDocumentParser::initializeParserContext): (WebCore::XMLDocumentParser::doEnd): (WebCore::XMLDocumentParser::parse):
  • html/parser/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::pumpTokenizerIfPossible): (WebCore::HTMLDocumentParser::pumpTokenizer): (WebCore::HTMLDocumentParser::insert): (WebCore::HTMLDocumentParser::append): (WebCore::HTMLDocumentParser::end): (WebCore::HTMLDocumentParser::attemptToEnd): (WebCore::HTMLDocumentParser::endIfDelayed): (WebCore::HTMLDocumentParser::notifyFinished):
  • html/parser/HTMLDocumentParser.h:
  • html/parser/HTMLScriptRunner.cpp: (WebCore::HTMLScriptRunner::~HTMLScriptRunner): (WebCore::HTMLScriptRunner::executeParsingBlockingScript): (WebCore::HTMLScriptRunner::executePendingScriptAndDispatchEvent): (WebCore::HTMLScriptRunner::runScript):
  • html/parser/HTMLScriptRunner.h:
  • loader/ImageDocument.cpp: (WebCore::ImageDocumentParser::finish):
04:29 Changeset [66659] by eric@webkit.org
  • 7 edits in trunk/WebCore

2010-09-02 Eric Seidel <eric@webkit.org>

Reviewed by Dimitri Glazkov.

Share more code between HTMLObjectElement and HTMLEmbedElement
https://bugs.webkit.org/show_bug.cgi?id=45054

This pushes more of HTMLObjectElement code down into
HTMLPlugInImageElement so that it can be shared with
HTMLEmbedElement.

The most notable changes are:

  • HTMLEmbedElement now "delays" updating the widget until all of its children are parsed (this matches HTMLObjectElement). However, since HTMLEmbedElement can't have children, this is actually no delay.
  • useFallbackContent is now virtual, allowing HTMLEmbedElement and HTMLObjectElement to share the same code paths, and the <embed> case to just always return false for useFallbackContent().

This is the final (fourth) part of this change.

No functional change, thus no tests.

  • html/HTMLEmbedElement.cpp:
  • html/HTMLEmbedElement.h:
  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::rendererIsNeeded):
  • html/HTMLObjectElement.h:
  • html/HTMLPlugInImageElement.cpp: (WebCore::HTMLPlugInImageElement::HTMLPlugInImageElement): (WebCore::HTMLPlugInImageElement::recalcStyle): (WebCore::HTMLPlugInImageElement::attach): (WebCore::HTMLPlugInImageElement::detach): (WebCore::HTMLPlugInImageElement::finishParsingChildren):
  • html/HTMLPlugInImageElement.h:
04:02 Changeset [66658] by abarth@webkit.org
  • 4 edits in trunk/WebCore

2010-09-02 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Move takeAllChildrenFrom to ContainerNode
https://bugs.webkit.org/show_bug.cgi?id=45066

We're going to reuse this method for XMLDocumentLoader, so it's better
to put it in a more general location.

  • dom/ContainerNode.cpp: (WebCore::ContainerNode::takeAllChildrenFrom):
  • dom/ContainerNode.h:
  • html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::FragmentParsingContext::finished):
03:58 Changeset [66657] by eric@webkit.org
  • 9 edits in trunk/WebCore

2010-09-02 Eric Seidel <eric@webkit.org>

Reviewed by Dimitri Glazkov.

Share more code between HTMLObjectElement and HTMLEmbedElement
https://bugs.webkit.org/show_bug.cgi?id=45054

This pushes more of HTMLObjectElement code down into
HTMLPlugInImageElement so that it can be shared with HTMLEmbedElement.

This patch was originally written in one piece and reviewed by Dimitri.
I'm landing it as four separate changes for easier readability and less
chance of regression.

No functional change, thus no tests.

  • html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::HTMLEmbedElement): (WebCore::HTMLEmbedElement::create):
  • html/HTMLEmbedElement.h:
  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::HTMLObjectElement):
  • html/HTMLObjectElement.h:
  • html/HTMLPlugInImageElement.cpp: (WebCore::HTMLPlugInImageElement::HTMLPlugInImageElement): (WebCore::HTMLPlugInImageElement::detach): (WebCore::HTMLPlugInImageElement::finishParsingChildren):
  • html/HTMLPlugInImageElement.h:
  • html/HTMLTagNames.in:
03:54 Changeset [66656] by andreas.kling@nokia.com
  • 1 edit
    3 adds in trunk/LayoutTests

2010-09-02 Andreas Kling <andreas.kling@nokia.com>

Unreviewed, forgot to add the new layout test in last commit.

  • fast/dom/Selection/script-tests/wrong-document-err.js: Added.
  • fast/dom/Selection/wrong-document-err-expected.txt: Added.
  • fast/dom/Selection/wrong-document-err.html: Added.
03:49 Changeset [66655] by andreas.kling@nokia.com
  • 3 edits in trunk

2010-09-01 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Darin Adler.

DOM Selection: collapse() and selectAllChildren() should throw WRONG_DOCUMENT_ERR if node belongs to other document
https://bugs.webkit.org/show_bug.cgi?id=44595

Spec links:
http://www.whatwg.org/specs/web-apps/current-work/#dom-selection-collapse
http://www.whatwg.org/specs/web-apps/current-work/#dom-selection-selectallchildren

Test: fast/dom/Selection/wrong-document-err.html

  • page/DOMSelection.cpp: (WebCore::DOMSelection::collapse): (WebCore::DOMSelection::selectAllChildren):

2010-09-01 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Darin Adler.

DOM Selection: collapse() and selectAllChildren() should throw WRONG_DOCUMENT_ERR if node belongs to other document
https://bugs.webkit.org/show_bug.cgi?id=44595

Spec links:
http://www.whatwg.org/specs/web-apps/current-work/#dom-selection-collapse
http://www.whatwg.org/specs/web-apps/current-work/#dom-selection-selectallchildren

  • fast/dom/Selection/script-tests/wrong-document-err.js: Added.
  • fast/dom/Selection/wrong-document-err-expected.txt: Added.
  • fast/dom/Selection/wrong-document-err.html: Added.
03:18 Changeset [66654] by mnaganov@chromium.org
  • 1 edit in trunk/WebKit/chromium/src/js/DevTools.js

[Chromium DevTools] Unreviewed DevTools tests fix after r66637.

03:05 Changeset [66653] by eric@webkit.org
  • 9 edits in trunk/WebCore

2010-09-02 Eric Seidel <eric@webkit.org>

Reviewed by Dimitri Glazkov.

Share more code between HTMLObjectElement and HTMLEmbedElement
https://bugs.webkit.org/show_bug.cgi?id=45054

This pushes more of HTMLObjectElement code down into
HTMLPlugInImageElement so that it can be shared with HTMLEmbedElement.

I also moved a little code from HTMLPluginElement to HTMLPlugInImageElement
since HTMLAppletElement does not need to share this same widget update logic.
This is a small correction from the previous change.

This patch was originally written in one piece and reviewed by Dimitri.
I'm landing it as three separate changes for easier readability and less
chance of regression.

No functional change, thus no tests.

  • html/HTMLEmbedElement.cpp:
  • html/HTMLEmbedElement.h:
  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::attach): (WebCore::HTMLObjectElement::finishParsingChildren): (WebCore::HTMLObjectElement::detach): (WebCore::HTMLObjectElement::recalcStyle): (WebCore::HTMLObjectElement::childrenChanged): (WebCore::HTMLObjectElement::renderFallbackContent):
  • html/HTMLObjectElement.h: (WebCore::HTMLObjectElement::useFallbackContent):
  • html/HTMLPlugInElement.cpp:
  • html/HTMLPlugInElement.h:
  • html/HTMLPlugInImageElement.cpp: (WebCore::HTMLPlugInImageElement::createRenderer): (WebCore::HTMLPlugInImageElement::updateWidget): (WebCore::HTMLPlugInImageElement::updateWidgetCallback):
  • html/HTMLPlugInImageElement.h: (WebCore::HTMLPlugInImageElement::canLazyAttach): (WebCore::HTMLPlugInImageElement::useFallbackContent):
02:32 Changeset [66652] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-09-02 Jer Noble <jer.noble@apple.com>

Reviewed by Darin Adler.

WebKit should not accept PDFs as video.
https://bugs.webkit.org/show_bug.cgi?id=45013

The code in MediaPlayerPrivate::createQTMovie has been re-arranged.
First, the component disabling is done only once. In 64-bit QTKit will
store the list of disabled components and disable them once QTKitServer
starts, so there is no need to disable them repeatedly. However,
because of a bug in 64-bit QTKit, additional requests of the exact same
component description will be ignored if QTKitServer is not yet running.
To work around this, we must provide the exact component flags for each
eat/PDF and grip/PDF component we wish to disable.

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::disableComponentsOnce): Added. (WebCore::MediaPlayerPrivate::createQTMovie): Moved the component

disabling code into disableComponentsOnce.

02:17 Changeset [66651] by philn@webkit.org
  • 2 edits in trunk/WebCore

2010-09-02 Philippe Normand <pnormand@igalia.com>

Unreviewed, GTK build fix.

  • platform/graphics/gstreamer/GStreamerGWorld.cpp: (WebCore::GStreamerGWorld::enterFullscreen):
02:10 Changeset [66650] by eric@webkit.org
  • 12 edits in trunk/WebCore

2010-09-02 Eric Seidel <eric@webkit.org>

Reviewed by Dimitri Glazkov.

Share more code between HTMLObjectElement and HTMLEmbedElement
https://bugs.webkit.org/show_bug.cgi?id=45054

This pushes more of HTMLObjectElement code down into
HTMLPlugInImageElement so that it can be shared with HTMLEmbedElement.

I also moved a little code from HTMLPluginElement to HTMLPlugInImageElement
since HTMLAppletElement does not need to share this same widget update logic.
This is a small correction from the previous change.

This patch was originally written in one piece and reviewed by Dimitri.
I'm landing it as two separate changes for easier readability and less
chance of regression.

No functional change, thus no tests.

  • html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::HTMLEmbedElement): (WebCore::HTMLEmbedElement::mapToEntry): (WebCore::HTMLEmbedElement::parseMappedAttribute): (WebCore::HTMLEmbedElement::rendererIsNeeded): (WebCore::HTMLEmbedElement::attach): (WebCore::HTMLEmbedElement::updateWidget): (WebCore::HTMLEmbedElement::insertedIntoDocument): (WebCore::HTMLEmbedElement::removedFromDocument): (WebCore::HTMLEmbedElement::attributeChanged):
  • html/HTMLEmbedElement.h:
  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::HTMLObjectElement): (WebCore::HTMLObjectElement::parseMappedAttribute): (WebCore::HTMLObjectElement::rendererIsNeeded): (WebCore::HTMLObjectElement::attach): (WebCore::HTMLObjectElement::updateWidget): (WebCore::HTMLObjectElement::finishParsingChildren): (WebCore::HTMLObjectElement::detach): (WebCore::HTMLObjectElement::insertedIntoDocument): (WebCore::HTMLObjectElement::removedFromDocument): (WebCore::HTMLObjectElement::recalcStyle): (WebCore::HTMLObjectElement::childrenChanged): (WebCore::HTMLObjectElement::renderFallbackContent):
  • html/HTMLObjectElement.h:
  • html/HTMLPlugInElement.cpp:
  • html/HTMLPlugInElement.h:
  • html/HTMLPlugInImageElement.cpp: (WebCore::HTMLPlugInImageElement::HTMLPlugInImageElement): (WebCore::HTMLPlugInImageElement::renderEmbeddedObject):
  • html/HTMLPlugInImageElement.h: (WebCore::HTMLPlugInImageElement::needsWidgetUpdate): (WebCore::HTMLPlugInImageElement::setNeedsWidgetUpdate):
  • loader/SubframeLoader.cpp: (WebCore::SubframeLoader::requestObject): (WebCore::SubframeLoader::loadPlugin):
  • loader/SubframeLoader.h:
  • rendering/RenderEmbeddedObject.cpp: (WebCore::updateWidgetForObjectElement): (WebCore::updateWidgetForEmbedElement):
02:05 Changeset [66649] by tonyg@chromium.org
  • 14 edits
    28 adds in trunk

2010-09-02 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Adam Barth.

Support <script defer> as specified by HTML5
https://bugs.webkit.org/show_bug.cgi?id=40934

  • fast/dom/HTMLScriptElement/defer-double-defer-write-expected.txt: Added.
  • fast/dom/HTMLScriptElement/defer-double-defer-write.html: Added. Tests that a write of a deferred script from a deferred script will execute when the document is closed. The explicit close is necessary because this is a script created parser.
  • fast/dom/HTMLScriptElement/defer-double-write-expected.txt: Added.
  • fast/dom/HTMLScriptElement/defer-double-write.html: Added. Tests that a script block written from a deferred script will write into the new document.
  • fast/dom/HTMLScriptElement/defer-inline-script-expected.txt: Added.
  • fast/dom/HTMLScriptElement/defer-inline-script.html: Added. Tests that inline scripts are not deferred. This is consistent with HTML5 and inconsistent with IE.
  • fast/dom/HTMLScriptElement/defer-onbeforeload-expected.txt: Added.
  • fast/dom/HTMLScriptElement/defer-onbeforeload.html: Added. Tests that the beforeload event is fired immediately and is cancellable.
  • fast/dom/HTMLScriptElement/defer-script-invalid-url-expected.txt: Added.
  • fast/dom/HTMLScriptElement/defer-script-invalid-url.html: Added. Tests that deferred scripts with invalid URLs are ignored and that subsequent deferred scripts will be run.
  • fast/dom/HTMLScriptElement/defer-write-expected.txt: Added.
  • fast/dom/HTMLScriptElement/defer-write.html: Added. Tests that a basic write from a deferred script blows away the document.
  • fast/dom/HTMLScriptElement/resources/defer.js: Added.
  • fast/dom/HTMLScriptElement/resources/external.js: Added.
  • fast/dom/HTMLScriptElement/resources/shouldnotexecute.js: Added.
  • fast/dom/HTMLScriptElement/shouldnotexecute.js: Added.
  • fast/dom/HTMLScriptElement/two-defer-writes-expected.txt: Added.
  • fast/dom/HTMLScriptElement/two-defer-writes.html: Added. Tests that when a document.write from the first deferred script blows away the document, subsequent deferred scripts are not executed.
  • http/tests/misc/resources/defer-script.js: Added.
  • http/tests/misc/resources/external-script.js: Added.
  • http/tests/misc/resources/script-debug-body-background.js: Added.
  • http/tests/misc/resources/script-write-slow-stylesheet.js: Added.
  • http/tests/misc/resources/slow-defer-script.cgi: Added.
  • http/tests/misc/resources/slow-stylesheet.cgi: Added.
  • http/tests/misc/script-defer-after-slow-stylesheet-expected.txt: Added.
  • http/tests/misc/script-defer-after-slow-stylesheet.html: Added. Tests that deferred scripts respect blocking stylesheets.
  • http/tests/misc/script-defer-expected.txt: Added.
  • http/tests/misc/script-defer.html: Added. Tests basic ordering of deferred scripts.

2010-09-02 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Adam Barth.

Support <script defer> as specified by HTML5
https://bugs.webkit.org/show_bug.cgi?id=40934

Tests: fast/dom/HTMLScriptElement/defer-double-defer-write.html

fast/dom/HTMLScriptElement/defer-double-write.html
fast/dom/HTMLScriptElement/defer-inline-script.html
fast/dom/HTMLScriptElement/defer-onbeforeload.html
fast/dom/HTMLScriptElement/defer-script-invalid-url.html
fast/dom/HTMLScriptElement/defer-write.html
fast/dom/HTMLScriptElement/two-defer-writes.html
http/tests/misc/script-defer-after-slow-stylesheet.html
http/tests/misc/script-defer.html

  • dom/Document.cpp: (WebCore::Document::open): Allow implicit open for writes() while executing deferred scripts.
  • dom/DocumentParser.cpp: (WebCore::DocumentParser::DocumentParser): (WebCore::DocumentParser::startParsing): (WebCore::DocumentParser::prepareToStopParsing): If called when stopped or detached, it shouldn't reset to stopping. (WebCore::DocumentParser::stopParsing): (WebCore::DocumentParser::detach):
  • dom/DocumentParser.h: (WebCore::DocumentParser::isParsing): (WebCore::DocumentParser::isActive): (WebCore::DocumentParser::isStopping): (WebCore::DocumentParser::isDetached):
  • dom/RawDataDocumentParser.h: (WebCore::RawDataDocumentParser::finish):
  • dom/XMLDocumentParser.cpp: (WebCore::XMLDocumentParser::append): (WebCore::XMLDocumentParser::exitText):
  • dom/XMLDocumentParserLibxml2.cpp: (WebCore::XMLDocumentParser::doWrite): (WebCore::XMLDocumentParser::startElementNs): (WebCore::XMLDocumentParser::endElementNs): (WebCore::XMLDocumentParser::characters): (WebCore::XMLDocumentParser::error): (WebCore::XMLDocumentParser::processingInstruction): (WebCore::XMLDocumentParser::cdataBlock): (WebCore::XMLDocumentParser::comment): (WebCore::XMLDocumentParser::internalSubset): (WebCore::XMLDocumentParser::initializeParserContext): (WebCore::XMLDocumentParser::doEnd):
  • html/parser/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::prepareToStopParsing): (WebCore::HTMLDocumentParser::pumpTokenizerIfPossible): (WebCore::HTMLDocumentParser::pumpTokenizer): (WebCore::HTMLDocumentParser::insert): (WebCore::HTMLDocumentParser::append): (WebCore::HTMLDocumentParser::end): (WebCore::HTMLDocumentParser::attemptToEnd): (WebCore::HTMLDocumentParser::endIfDelayed): (WebCore::HTMLDocumentParser::notifyFinished):
  • html/parser/HTMLDocumentParser.h:
  • html/parser/HTMLScriptRunner.cpp: (WebCore::HTMLScriptRunner::~HTMLScriptRunner): (WebCore::HTMLScriptRunner::executeParsingBlockingScript): (WebCore::HTMLScriptRunner::executePendingScriptAndDispatchEvent): (WebCore::HTMLScriptRunner::executeScriptsWaitingForParsing): (WebCore::HTMLScriptRunner::requestDeferredScript): (WebCore::HTMLScriptRunner::runScript):
  • html/parser/HTMLScriptRunner.h:
  • loader/ImageDocument.cpp: (WebCore::ImageDocumentParser::finish):
01:25 Changeset [66648] by philn@webkit.org
  • 2 edits in trunk/LayoutTests

2010-09-02 Philippe Normand <pnormand@igalia.com>

Unreviewed, skipping new failing media test.

[Qt] media/media-can-play-mpeg4-video.html fails
https://bugs.webkit.org/show_bug.cgi?id=45093

  • platform/qt/Skipped:
00:52 Changeset [66647] by commit-queue@webkit.org
  • 7 edits in trunk

2010-09-02 Ilya Sherman <isherman@google.com>

Reviewed by Eric Seidel.

Decompose computing an element's inherited language, expose this
capability to clients (in particular, for Chromium).
https://bugs.webkit.org/show_bug.cgi?id=44803

No new tests -- just refactoring + exposing code.

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
  • dom/Element.cpp: (WebCore::Element::computeInheritedLang):
  • dom/Element.h:

2010-09-02 Ilya Sherman <isherman@google.com>

Reviewed by Eric Seidel.

Exposing computing an element's inherited language, per the DOM, in the
Chromium API -- primarily for use with autofill i18n.
https://bugs.webkit.org/show_bug.cgi?id=44803

  • public/WebElement.h:
  • src/WebElement.cpp: (WebKit::WebElement::computeInheritedLanguage):
00:07 Changeset [66646] by philn@webkit.org
  • 3 edits
    2 adds in trunk

2010-08-31 Philippe Normand <pnormand@igalia.com>

Reviewed by Eric Carlson.

[GStreamer] can't play m4v videos
https://bugs.webkit.org/show_bug.cgi?id=44951

Fixed registration of the m4v media type in the hashtable used by
the player to report if it supports a given media type.

Test: media/media-can-play-mpeg4-video.html

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::mimeTypeCache):

LayoutTests:

Reviewed by Eric Carlson.

[GStreamer] can't play m4v videos
https://bugs.webkit.org/show_bug.cgi?id=44951

Test similar to media-can-play-mpeg-audio.html but for videos. For
now only m4v and mp4 types are tested.

  • media/media-can-play-mpeg4-video-expected.txt: Added.
  • media/media-can-play-mpeg4-video.html: Added.

09/01/10:

23:49 Changeset [66645] by philn@webkit.org
  • 2 edits in trunk/WebCore

2010-09-01 Philippe Normand <pnormand@igalia.com>

Reviewed by Martin Robinson.

[GTK] warning: unused variable "queryResult"
https://bugs.webkit.org/show_bug.cgi?id=44998

Fix the misbehavior introduced in r66573. The gst_element_query()
call needs to be done whatever the GStreamer version used.

  • platform/graphics/gstreamer/GStreamerGWorld.cpp: (WebCore::GStreamerGWorld::enterFullscreen):
23:45 Changeset [66644] by mitz@apple.com
  • 3 edits in trunk

Updated Radar link

23:43 Changeset [66643] by mitz@apple.com
  • 27 edits in trunk

Add support for autocorrection UI on Mac OS X.
https://bugs.webkit.org/show_bug.cgi?id=44958
<rdar://problem/7299621>

Patch by Jia Pu <jpu@apple.com> on 2010-09-01
Reviewed by Dan Bernstein.

WebCore:

Several new member methods are added to EditorClient for communication
between WebCore and WebKit. A new handler, executeCancelOperation(), is
added to EditorCommand.cpp so that WebCore can intercept the ESC key event
to dismiss autocorrection UI. A new DocumentMarker value, RejectedCorrection,
is added to keep track of the corrections that user has rejected, so that it
will not be suggested again later. The autocorrection is driven by a timer.
Every time the editor inserts a new letter, the timer is reset. If the timer
fires, it means neither has user entered any new letter for current word, nor
has he entered whitespace or punctuation to complete the word. In this case,
we query for autocorrection.

  • WebCore.exp.in: Updated
  • dom/DocumentMarker.h: Added RejectedCorrection to indicate word on which user has rejected autocorrection.
  • editing/Editor.cpp:

(WebCore::Editor::Editor): Initialize autocorrection timer.
(WebCore::Editor::~Editor): Make sure autocorrection UI is dismissed before

destroying Editor object.

(WebCore::Editor::markMisspellingsAfterTypingToPosition): Adopted new signature

of markAllMisspellingsAndBadGrammarInRanges().

(WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): Consolidated all

boolean arguments into one bitfield. This improves readability and allows us to
pass in a bit to indicate whether we want to show autocorrection UI. Also added
code to show autocorrection UI if it is necessary.

(WebCore::Editor::markMisspellingsAndBadGrammar): Adopted new signature of

markAllMisspellingsAndBadGrammarInRanges().

(WebCore::Editor::correctionPanelTimerFired): Check to see if we should show

autocorrection UI when user pauses during typing.

(WebCore::Editor::handleRejectedCorrection): Update user dictionary when an autocorrection is rejected.
(WebCore::Editor::startCorrectionPanelTimer): Start autocorrection timer.
(WebCore::Editor::handleCancelOperation): Dismiss autocorrection UI when ESC key is pressed.

  • editing/Editor.h: Added autocorrection related member methods and variables.
  • editing/EditorCommand.cpp:

(WebCore::executeCancelOperation): Handle ESC key event. Dismiss autocorrection UI.
(WebCore::createCommandMap): Updated for executeCancelOperation().

  • editing/TypingCommand.cpp:

(WebCore::TypingCommand::markMisspellingsAfterTyping): Reset autocorrection timer after insertion.

  • loader/EmptyClients.h:

(WebCore::EmptyEditorClient::showCorrectionPanel): Dummy implementation.
(WebCore::EmptyEditorClient::dismissCorrectionPanel): Ditto

  • page/EditorClient.h: Added methods for communication between WebCore and WebKit regarding autocorrection.
  • page/Frame.cpp:

(WebCore::Frame::respondToChangedSelection): Remove Replacement marker where we used to only remove Spelling

mark, because whenever we need to remove spelling underline we also should remove autocorrection underline.

  • platform/graphics/GraphicsContext.h: Added enum TextCheckingLineStyle to specify the underline for different type of text checking result. Replaced drawLineForMisspellingOrBadGrammar() with drawLineForTextChecking(), which allows autocorrection to have different indication from misspelling and grammatical error.
  • platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::GraphicsContext::drawLineForTextChecking): Replaced drawLineForMisspellingOrBadGrammar() with drawLineForTextChecking().

  • platform/graphics/haiku/GraphicsContextHaiku.cpp:

(WebCore::GraphicsContext::drawLineForTextChecking): Ditto

  • platform/graphics/mac/GraphicsContextMac.mm:

(WebCore::GraphicsContext::drawLineForTextChecking): Ditto

  • platform/graphics/openvg/GraphicsContextOpenVG.cpp:

(WebCore::GraphicsContext::drawLineForTextChecking): Ditto

  • platform/graphics/qt/GraphicsContextQt.cpp:

(WebCore::GraphicsContext::drawLineForTextChecking): Ditto

  • platform/graphics/skia/GraphicsContextSkia.cpp:

(WebCore::GraphicsContext::drawLineForTextChecking): Ditto

  • platform/graphics/win/GraphicsContextCGWin.cpp:

(WebCore::GraphicsContext::drawLineForTextChecking): Ditto

  • platform/graphics/wince/GraphicsContextWince.cpp:

(WebCore::GraphicsContext::drawLineForTextChecking): Ditto

  • platform/graphics/wx/GraphicsContextWx.cpp:

(WebCore::GraphicsContext::drawLineForTextChecking): Ditto

  • rendering/InlineTextBox.cpp:

(WebCore::textCheckingLineStyleForMarkerType): Return line style for a given document marker type.
(WebCore::InlineTextBox::paintSpellingOrGrammarMarker): Replaced drawLineForMisspellingOrBadGrammar() with drawLineForTextChecking().
(WebCore::InlineTextBox::paintDocumentMarkers): Handle new marker value, RejectedCorrection.

WebKit/mac:

See detailed high level description in WebCore/ChangeLog.

  • WebCoreSupport/WebEditorClient.h: Added new member methods declared in EditorClient. Added m_correctionPanelTag to store the ID of current autocorrection UI object.
  • WebCoreSupport/WebEditorClient.mm:

(WebEditorClient::WebEditorClient): Initialize m_correctionPanelTag.
(WebEditorClient::~WebEditorClient): Make sure the autocorrection UI is

dismissed before destroying the object.

(WebEditorClient::respondToChangedSelection): Dismiss autocorrection UI whenever the selection changes.
(WebEditorClient::showCorrectionPanel): Show autocorrection UI.
(WebEditorClient::dismissCorrectionPanel): Dismiss autocorrection UI.

WebKit2:

See detailed high level description in WebCore/ChangeLog.

  • WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::WebEditorClient::showCorrectionPanel): Dummy implementation.
(WebKit::WebEditorClient::dismissCorrectionPanel): Ditto

  • WebProcess/WebCoreSupport/WebEditorClient.h: Added new methods declared in base class.
23:17 Changeset [66642] by kinuko@chromium.org
  • 4 edits in trunk/WebCore

2010-09-01 Kinuko Yasuda <kinuko@google.com>

Reviewed by Adam Barth.

[V8] Support readonly Date attribute
https://bugs.webkit.org/show_bug.cgi?id=43943

Adds Date to non_wrapper_types in CodeGeneratorV8.pm.

New tests will be added for Metadata when we add FileSystem implementation.

  • bindings/scripts/CodeGeneratorV8.pm:
  • fileapi/Metadata.h:
  • fileapi/Metadata.idl:
22:27 Changeset [66641] by commit-queue@webkit.org
  • 5 edits in trunk

2010-09-01 Mihai Parparita <mihaip@chromium.org>

Reviewed by Chris Marrin.

animations/suspend-resume-animation.html does not pass when accelerated compositing is off
https://bugs.webkit.org/show_bug.cgi?id=45057

animations/suspend-resume-animation.html now passes with the Chromium DRT
(it still fails with test_shell, since that doesn't have the suspend/resumeAnimations
API implemented)

  • platform/chromium/drt_expectations.txt:
  • platform/chromium/test_expectations.txt:

2010-09-01 Mihai Parparita <mihaip@chromium.org>

Reviewed by Chris Marrin.

animations/suspend-resume-animation.html does not pass when accelerated compositing is off
https://bugs.webkit.org/show_bug.cgi?id=45057

Fix incorrect logic when resuming the animation (KeyframeAnimation::startAnimation
and RenderLayerBacking::startAnimation return true when running an accelerated
animation).

  • page/animation/AnimationBase.cpp: (WebCore::AnimationBase::updateStateMachine):
21:47 Changeset [66640] by dpranke@chromium.org
  • 11 edits
    4 adds in trunk/WebKitTools

2010-09-01 Dirk Pranke <dpranke@chromium.org>

Reviewed by Tony Chang.

Land a patched version of r66542 - change TestRunner to have an
separate cleanup method and fix the ordering of cleanup between
TestRunner and the printing module, and then wrap everything in a
try/finally block to ensure reliable cleanup without needing to
rely on stuff happening in the destructor of the TestRunner.

Also refactor run_webkit_tests.run() to be much smaller and cleaner
by creating a bunch of helper methods and moving more stuff into
the TestRunner class.

This fixes the crash at the end of the linux test run of
new-run-webkit-tests (and undoes the rollout in 66547).

https://bugs.webkit.org/show_bug.cgi?id=44902

  • Scripts/webkitpy/layout_tests/data/failures/expected/exception.html: Added.
  • Scripts/webkitpy/layout_tests/data/failures/expected/keyboard.html: Added.
  • Scripts/webkitpy/layout_tests/data/passes/error-expected.txt: Added.
  • Scripts/webkitpy/layout_tests/data/passes/error.html: Added.
  • Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
  • Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
  • Scripts/webkitpy/layout_tests/layout_package/printing.py:
  • Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/test.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
21:00 Changeset [66639] by weinig@apple.com
  • 6 edits in trunk/WebKit2

Fix the build.

As with CF, const struct OpaqueType* should be the default type
so that const_casts are not necessary in user code.

  • UIProcess/API/C/WKArray.cpp:

(WKArrayCreate):

  • UIProcess/API/C/WKBase.h:
  • UIProcess/API/C/WKType.cpp:

(WKGetTypeID):
(WKRetain):
(WKRelease):

  • WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:

(toWK):

  • WebProcess/InjectedBundle/API/c/WKBundleBase.h:
20:37 Changeset [66638] by weinig@apple.com
  • 8 edits
    4 adds in trunk/WebKit2

Add mutable array API to WebKit2
https://bugs.webkit.org/show_bug.cgi?id=45082

Reviewed by Adam Roben.

Add a mutable API to WebKit2 called WKMutableArrayRef. Make it "inherit" from
WKArrayRef in the same way JSObjectRef can inherit from JSValueRef in the JSC
API, by abusing the c type system (WKArrayRef is defined as a const version of
WKMutableArrayRef). Add very basic mutable API to go along with it.

  • Shared/ImmutableArray.h:

(WebKit::ImmutableArray::isMutable):
Add ability to ask it an array is mutable.

  • Shared/MutableArray.cpp: Added.

(WebKit::MutableArray::MutableArray):
(WebKit::MutableArray::~MutableArray):
(WebKit::MutableArray::append):

  • Shared/MutableArray.h: Added.

(WebKit::MutableArray::create):
(WebKit::MutableArray::isMutable):
Sketch out the mutable array interface.

  • UIProcess/API/C/WKAPICast.h:

(toWK):
Now that the opaque types can be const, use template magic to const_cast
it away.

  • UIProcess/API/C/WKBase.h:

Add new type and re-type WKArrayRef as const.

  • UIProcess/API/C/WKMutableArray.cpp: Added.

(WKMutableArrayCreate):
(WKArrayIsMutable):
(WKArrayAppendItem):

  • UIProcess/API/C/WKMutableArray.h: Added.

Fill in basic API.

  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:
  • win/WebKit2Generated.make:

Add files.

20:31 Changeset [66637] by mnaganov@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-09-01 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Yury Semikhatsky.

Remove dependency on JS files for V8 logs processing.

https://bugs.webkit.org/show_bug.cgi?id=45045

  • WebKit.gyp:
20:14 Changeset [66636] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit2

2010-09-01 Balazs Kelemen <kb@inf.u-szeged.hu>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Implement PluginInfoStore for UNIX
https://bugs.webkit.org/show_bug.cgi?id=45038

This implementation is generally just reusing the logic in WebCore since
there is no way to get informations from a UNIX plugin without loading it

  • in contrast to mac bundles and windows dll-s.
  • UIProcess/Plugins/qt/PluginInfoStoreQt.cpp: (WebKit::PluginInfoStore::pluginsDirectories): (WebKit::PluginInfoStore::pluginPathsInDirectory): (WebKit::PluginInfoStore::getPluginInfo): (WebKit::PluginInfoStore::shouldUsePlugin):
19:57 Changeset [66635] by commit-queue@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

2010-09-01 Matthew Willis <lilmatt@flock.com>

Reviewed by Alexey Proskuryakov.

Add tests to ensure any h1-h6 element can close any other h1-h6 element.
https://bugs.webkit.org/show_bug.cgi?id=15136
<rdar://problem/5762882>

  • fast/html/numbered-header-element-expected.txt: Added.
  • fast/html/numbered-header-element.html: Added.
  • fast/html/script-tests/numbered-header-element.js: Added.
19:23 Changeset [66634] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

Fix TestNetscapePlugIn to compile without access to QuickDraw private headers.

Reviewed by Adam Roben.

  • DumpRenderTree/TestNetscapePlugIn/main.cpp:
19:23 Changeset [66633] by mrowe@apple.com
  • 4 edits
    1 add in trunk/WebKit/mac

<rdar://problem/8374711> WebKit needs to compile without access to QuickDraw private headers.

Reviewed by Adam Roben.

  • Carbon/HIViewAdapter.m:
  • Carbon/HIWebView.mm:
  • Misc/QuickDrawCompatibility.h: Added.
  • Plugins/WebNetscapePluginView.mm:
19:13 Changeset [66632] by eric.carlson@apple.com
  • 2 edits in trunk/WebCore

2010-09-01 Eric Carlson <eric.carlson@apple.com>

Reviewed by Darin Adler.

Question mark QuickTime icon when navigating to this MP3 file
https://bugs.webkit.org/show_bug.cgi?id=44846

Do not disable 'tmet' movie tracks, they carry meta data.

No DRT test because I am not sure it is possible to have one of these tracks in
non-streaming movie. I will add a test later if I figure out how to create a movie.

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::disableUnsupportedTracks):
19:11 Changeset [66631] by eric@webkit.org
  • 14 edits in trunk/WebCore

2010-09-01 Eric Seidel <eric@webkit.org>

Reviewed by Dimitri Glazkov.

Remove rendering types from SubframeLoader and split RenderEmbeddedObject::updateWidget in preparation for moving to DOM
https://bugs.webkit.org/show_bug.cgi?id=45007

This is just moving around code (and attempting to make it more sane).
I also tried to use more specific types where possible.
The SubframeLoader no longer uses any rendering types in its API.

I split RenderEmbeddedObject::updateWidget into a bunch of functions.
It was obvious before, but now super-obvious after the split that these
new functions do not belong in RenderEmbeddedObject. Instead they
need to be moved to their respective DOM classes. I've added FIXMEs
next to each of the functions which should be moved, but I've not moved
any of the logic out of RenderEmbeddedObject.cpp yet in an effort to
keep this patch as simple as possible.

No functional change, thus no tests.

  • html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::updateWidget):
  • html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::attach): (WebCore::HTMLFrameElementBase::width): (WebCore::HTMLFrameElementBase::height):
  • html/HTMLFrameOwnerElement.cpp: (WebCore::HTMLFrameOwnerElement::renderPart):
  • html/HTMLFrameOwnerElement.h:
  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::renderWidgetForJSBindings): (WebCore::HTMLObjectElement::createRenderer): (WebCore::HTMLObjectElement::updateWidget):
  • html/HTMLPlugInElement.cpp: (WebCore::HTMLPlugInElement::renderEmbeddedObject):
  • html/HTMLPlugInElement.h:
  • loader/PluginDocument.cpp: (WebCore::PluginDocumentParser::appendBytes):
  • loader/SubframeLoader.cpp: (WebCore::SubframeLoader::requestObject): (WebCore::SubframeLoader::document): (WebCore::SubframeLoader::loadPlugin):
  • loader/SubframeLoader.h:
  • rendering/RenderEmbeddedObject.cpp: (WebCore::isNetscapePlugin): (WebCore::hasFallbackContent): (WebCore::parametersFromObject): (WebCore::updateWidgetForObjectElement): (WebCore::parametersFromEmbed): (WebCore::updateWidgetForEmbedElement): (WebCore::updateWidgetForMediaElement): (WebCore::RenderEmbeddedObject::updateWidget):
  • rendering/RenderEmbeddedObject.h: (WebCore::RenderEmbeddedObject::setHasFallbackContent):
  • rendering/RenderLayerCompositor.h:
19:03 Changeset [66630] by bweinstein@apple.com
  • 2 edits in trunk/WebKitTools

Have kill-old-processes kill debug and release variants of WebKit2WebWebProcess
and WebKitTestRunner.

Reviewed by Adam Roben.

  • BuildSlaveSupport/win/kill-old-processes:
18:20 Changeset [66629] by kinuko@chromium.org
  • 3 edits in trunk/WebCore

2010-09-01 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by Jian Li.

Add more FileError and FileException code for FileWriter and FileSystem API
https://bugs.webkit.org/show_bug.cgi?id=45048

Adding SYNTAX_ERR for FileWriter.
http://dev.w3.org/2009/dap/file-system/file-writer.html

Adding INVALID_STATE_ERR, INVALID_MODIFICATION_ERR and QUOTA_EXCEEDED_ERR for FileSystem.
http://dev.w3.org/2009/dap/file-system/file-dir-sys.html

Adding NO_MODIFICATION_ALLOWED_ERR (to FileException) for both.

  • fileapi/FileError.idl:
  • fileapi/FileException.idl:
18:00 Changeset [66628] by commit-queue@webkit.org
  • 23 edits
    6 adds in trunk

2010-09-01 Mihai Parparita <mihaip@chromium.org>

Reviewed by Brady Eidson.

popstate event is not fired until document opts in by calling pushstate.
https://bugs.webkit.org/show_bug.cgi?id=41372

Add two tests to check how often popstate is being fired (for both
fragment changes and page changes, especially with the page cache
enabled).

Update existing state object tests to handle popstate being fired for
the page being navigated to (right after onload).

  • fast/loader/stateobjects/document-destroyed-navigate-back-with-fragment-scroll.html:
  • fast/loader/stateobjects/document-destroyed-navigate-back.html:
  • fast/loader/stateobjects/popstate-after-load-complete-addeventlistener.html:
  • fast/loader/stateobjects/popstate-after-load-complete-body-attribute.html:
  • fast/loader/stateobjects/popstate-after-load-complete-body-inline-attribute.html:
  • fast/loader/stateobjects/popstate-after-load-complete-window-attribute.html:
  • fast/loader/stateobjects/popstate-fires-on-history-traversal-expected.txt: Added.
  • fast/loader/stateobjects/popstate-fires-on-history-traversal.html: Added.
  • fast/loader/stateobjects/popstate-fires-with-page-cache-expected.txt: Added.
  • fast/loader/stateobjects/popstate-fires-with-page-cache.html: Added.
  • fast/loader/stateobjects/pushstate-object-types.html:
  • fast/loader/stateobjects/pushstate-then-replacestate.html:
  • fast/loader/stateobjects/pushstate-with-fragment-urls-and-hashchange.html:
  • fast/loader/stateobjects/replacestate-in-iframe.html:
  • fast/loader/stateobjects/replacestate-then-pushstate.html:
  • fast/loader/stateobjects/resources/popstate-fires-with-page-cache-1.html: Added.
  • fast/loader/stateobjects/resources/popstate-fires-with-page-cache-2.html: Added.
  • fast/loader/stateobjects/resources/replacestate-in-iframe-window-child.html:

2010-09-01 Mihai Parparita <mihaip@chromium.org>

Reviewed by Brady Eidson.

popstate event is not fired until document opts in by calling pushstate.
https://bugs.webkit.org/show_bug.cgi?id=41372

Fire popstate even when we don't have a state object when a page is
loaded (for both regular loads and those from the page cache). Also
fire popstate when doing in-document navigation via fragment changes.
This is consistent with both Gecko and recent the HTML5 spec change:
http://html5.org/tools/web-apps-tracker?from=5376&to=5377

Tests: fast/loader/stateobjects/popstate-fires-on-history-traversal.html

fast/loader/stateobjects/popstate-fires-with-page-cache.html

  • bindings/js/SerializedScriptValue.cpp:
  • bindings/js/SerializedScriptValue.h: (WebCore::SerializedScriptValue::create):
  • bindings/v8/SerializedScriptValue.cpp:
  • bindings/v8/SerializedScriptValue.h:
  • dom/Document.cpp: (WebCore::Document::implicitClose):
  • dom/Document.h:
  • history/CachedFrame.cpp: (WebCore::CachedFrameBase::restore):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::loadInSameDocument): (WebCore::FrameLoader::transitionToCommitted):
  • loader/HistoryController.cpp: (WebCore::HistoryController::pushState): (WebCore::HistoryController::replaceState):
17:25 Changeset [66627] by tkent@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-09-01 Kent Tamura <tkent@chromium.org>

Unreviewed, rolling out r66576.
http://trac.webkit.org/changeset/66576
https://bugs.webkit.org/show_bug.cgi?id=45016

This change is not needed.

  • public/WebKitClient.h:
17:20 Changeset [66626] by mrowe@apple.com
  • 2 edits in trunk/WebKit2

Allow the web process to load frameworks other than WebKit2.framework from the build directory
when running engineering builds.

Reviewed by Sam Weinig.

  • WebProcess/mac/WebProcessMainMac.mm:

(WebKit::WebProcessMain): Pass the path containing WebKit2.framework to the sandbox rather than
the path of the WebKit2.framework itself.

16:26 Changeset [66625] by joepeck@webkit.org
  • 2 edits in trunk/LayoutTests

2010-09-01 Matthew Willis <lilmatt@flock.com>

Reviewed by Joseph Pecoraro.

Fix failing test: inspector/console-format.html (regression from r66616)
https://bugs.webkit.org/show_bug.cgi?id=45067

  • inspector/console-format-expected.txt:
16:18 Changeset [66624] by rniwa@webkit.org
  • 3 edits
    2 adds in trunk

2010-09-01 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Dimitri Glazkov.

REGRESSION(r66431): WebCore::Editor::selectionStartCSSPropertyValue crashes if no background color is specified
https://bugs.webkit.org/show_bug.cgi?id=45068

The crash was caused by the assumption that every node has an ancestor with some background color,
which was obviously false. Fixed this by adding a null for ancestor.

Test: editing/execCommand/backcolor-crash.html

  • editing/Editor.cpp: (WebCore::Editor::selectionStartCSSPropertyValue):

2010-09-01 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Dimitri Glazkov.

REGRESSION(r66431): WebCore::Editor::selectionStartCSSPropertyValue crashes if no background color is specified
https://bugs.webkit.org/show_bug.cgi?id=45068

Added a test to ensure WebKit doesn't crash when backColor is queried on a node without any ancestors
with a background color.

  • editing/execCommand/backcolor-crash-expected.txt: Added.
  • editing/execCommand/backcolor-crash.html: Added.
16:14 Changeset [66623] by jberlin@webkit.org
  • 2 edits in trunk/WebKit/win

2010-09-01 Jessie Berlin <jberlin@apple.com>

Reviewed by Adam Roben.

WebViews should allow their parent windows to handle WM_MOUSEACTIVATE messages.
https://bugs.webkit.org/show_bug.cgi?id=45047

  • WebView.cpp: (WebView::WebViewWndProc):
15:55 Changeset [66622] by jer.noble@apple.com
  • 3 edits
    3 adds in trunk

2010-08-31 Jer Noble <jer.noble@apple.com>

Reviewed by Darin Adler.

WebKit should not accept PDFs as video.
https://bugs.webkit.org/show_bug.cgi?id=45013


QuickTime will accept a PDF as the source for a movie, and happily
convert that PDF into a .mov. WebKit should disable the eat and grip
PDF components which allow this.

Test: http/tests/media/pdf-served-as-pdf.html

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::createQTMovie): Add PDF eat and grip components to the components which are disabled before opening a QTMovie.

2010-08-31 Jer Noble <jer.noble@apple.com>

Reviewed by Darin Adler.

WebKit should not accept PDFs as video.
https://bugs.webkit.org/show_bug.cgi?id=45013


Added a new test, similar to the text-served-as-text.html test, which
expects an error thrown when a PDF is set as the source of a <video>
element.

  • http/tests/media/pdf-served-as-pdf-expected.txt: Added.
  • http/tests/media/pdf-served-as-pdf.html: Added.
  • http/tests/media/resources/test.pdf: Added.
15:35 Changeset [66621] by weinig@apple.com
  • 10 edits in trunk/WebKit2

Change ImmutableArray to be backed by a Vector
https://bugs.webkit.org/show_bug.cgi?id=45064

Reviewed by John Sullivan.

Change ImmutableArray to be backed by a Vector to work toward having
a mutable subclass and to improve the API when working with it in WebKit2
itself.

  • Also remove WKArrayCreateAdoptingValues which was confusing and unused.
  • Shared/ImmutableArray.cpp:

(WebKit::ImmutableArray::ImmutableArray):
(WebKit::ImmutableArray::~ImmutableArray):

  • Shared/ImmutableArray.h:

(WebKit::ImmutableArray::adopt):
(WebKit::ImmutableArray::at):
(WebKit::ImmutableArray::size):

  • Shared/ImmutableDictionary.cpp:

(WebKit::ImmutableDictionary::keys):

  • UIProcess/API/C/WKArray.cpp:
  • UIProcess/API/C/WKArray.h:
  • UIProcess/WebBackForwardList.cpp:

(WebKit::WebBackForwardList::backListAsImmutableArrayWithLimit):
(WebKit::WebBackForwardList::forwardListAsImmutableArrayWithLimit):

  • UIProcess/WebContext.cpp:

(WebKit::PostMessageEncoder::PostMessageDecoder::decode):

  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::PostMessageEncoder::PostMessageDecoder::decode):

  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::childFrames):

15:00 Changeset [66620] by tony@chromium.org
  • 3 edits in trunk/LayoutTests

2010-09-01 Tony Chang <tony@chromium.org>

Unreviewed, updating a chromium baseline, the only difference is in
the anti-aliasing of the rounded border (a result of r66615).

  • platform/chromium-win/fast/borders/border-radius-huge-assert-expected.checksum:
  • platform/chromium-win/fast/borders/border-radius-huge-assert-expected.png:
14:36 Changeset [66619] by weinig@apple.com
  • 8 edits
    11 adds in trunk/WebKit2

Add URLResponse API for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=45062

Reviewed by Anders Carlsson.

Add WebURLResponse class and WKURLResponseRef C API to go with it. Right now,
instance of WKURLResponseRef are manipulated via platform types just like
WKURLRequestRef.

This just adds the type and conversion functions, no uses yet.

  • Shared/APIObject.h:
  • Shared/WebCoreArgumentCoders.h:
  • Shared/WebURLResponse.cpp: Added.

(WebKit::WebURLResponse::WebURLResponse):

  • Shared/WebURLResponse.h: Added.

(WebKit::WebURLResponse::create):
(WebKit::WebURLResponse::resourceResponse):
(WebKit::WebURLResponse::type):

  • Shared/mac/WebCoreArgumentCodersMac.mm:

(CoreIPC::encodeWithNSKeyedArchiver):
(CoreIPC::decodeWithNSKeyedArchiver):
(CoreIPC::encodeResourceRequest):
(CoreIPC::decodeResourceRequest):

  • Shared/mac/WebURLResponseMac.mm: Added.

(WebKit::WebURLResponse::WebURLResponse):
(WebKit::WebURLResponse::platformResponse):

  • Shared/qt/WebURLResponseQt.cpp: Added.

(WebKit::WebURLResponse::WebURLResponse):
(WebKit::WebURLResponse::platformResponse):

  • Shared/win/WebURLResponseWin.cpp: Added.

(WebKit::WebURLResponse::WebURLResponse):
(WebKit::WebURLResponse::platformResponse):

  • UIProcess/API/C/WKURLResponse.cpp: Added.

(WKURLResponseGetTypeID):

  • UIProcess/API/C/WKURLResponse.h: Added.
  • UIProcess/API/C/cf/WKURLResponseCF.cpp: Added.

(WKURLResponseCreateWithCFURLResponse):
(WKURLResponseCopyCFURLResponse):

  • UIProcess/API/C/cf/WKURLResponseCF.h: Added.
  • UIProcess/API/C/mac/WKURLResponseNS.h: Added.
  • UIProcess/API/C/mac/WKURLResponseNS.mm: Added.

(WKURLResponseCreateWithNSURLResponse):
(WKURLResponseCopyNSURLResponse):

  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:
  • win/WebKit2Generated.make:
14:35 Changeset [66618] by crogers@google.com
  • 48 edits
    1 copy
    2 adds in branches/audio/WebCore

audio branch: lots of miscellaneous changes for code reviews - landing in trunk

14:06 Changeset [66617] by tony@chromium.org
  • 4 edits
    1 delete in trunk/LayoutTests

2010-09-01 Tony Chang <tony@chromium.org>

Unreviewed, updating chromium test expectations.

  • platform/chromium-mac/fast/js/kde/RegExp-expected.txt: Rebaseline
  • platform/chromium-win/fast/forms/focus2-expected.txt: Removed because it's wrong.
  • platform/chromium-win/fast/js/kde/RegExp-expected.txt: Rebaseline
  • platform/chromium/test_expectations.txt:
13:16 Changeset [66616] by barraclough@apple.com
  • 13 edits in trunk

JavaScriptCore: Ecma-262 15.11.1.1 states that if the argument is undefined then an
Error object's message property should be set to the empty string.

Rubber stamped by Oliver Hunt.

  • runtime/ErrorInstance.cpp:

(JSC::ErrorInstance::ErrorInstance):
(JSC::ErrorInstance::create):

  • runtime/ErrorInstance.h:
  • runtime/ErrorPrototype.cpp:

(JSC::ErrorPrototype::ErrorPrototype):

LayoutTests: Fix three tests in fast/js/kde are failing; fix them.

Rubber stamped by Oliver Hunt.

exceptions.js:

This is failing because it redefines the method 'should be'.
Rename the test's version of this method.

RegExp.js:

This tests erroneously expects a failed match to update the
cached results on the RegExp object; these are only updated
on a successful match.

evil-n.js:

This test erroneously expects the message property of a newly
constructed Error with no arguments to be undefined; the ECMA
262-5 spec requires this to be "". Two sputnik tests contain
the same error (the sputnik tests is actually testing 262-3
compatibility, which is not what we're interested in).

  • fast/js/kde/RegExp-expected.txt:
  • fast/js/kde/evil-n-expected.txt:
  • fast/js/kde/exceptions-expected.txt:
  • fast/js/kde/script-tests/RegExp.js:
  • fast/js/kde/script-tests/evil-n.js:
  • fast/js/kde/script-tests/exceptions.js:

(kdeShouldBe):
(testThrow):
(testThrow2):
(testReferenceError):
(testFunctionError):
(testMathFunctionError):
(testWhileAbortion):

  • fast/js/sputnik/Conformance/15_Native_Objects/15.11_Error/15.11.1/S15.11.1.1_A1_T1.html:
  • fast/js/sputnik/Conformance/15_Native_Objects/15.11_Error/15.11.2/S15.11.2.1_A1_T1.html:
12:51 Changeset [66615] by rwlbuis@webkit.org
  • 14 edits in trunk

2010-09-01 Rob Buis <rwlbuis@gmail.com>

Reviewed by Darin Adler.

Support for Percentage Values in border-radius
https://bugs.webkit.org/show_bug.cgi?id=38354

Support percentage values on the border-radius family
of CSS properties.

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::getBorderRadiusCornerValue):
  • css/CSSParser.cpp: (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseBorderRadius):
  • css/CSSPrimitiveValue.cpp:
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
  • page/animation/AnimationBase.cpp: (WebCore::AnimationBase::ensurePropertyMap):
  • platform/Length.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::repaintAfterLayoutIfNeeded):
  • rendering/style/BorderData.h: (WebCore::BorderData::BorderData): (WebCore::BorderData::hasBorderRadius): (WebCore::BorderData::topLeft): (WebCore::BorderData::topRight): (WebCore::BorderData::bottomLeft): (WebCore::BorderData::bottomRight):
  • rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::getBorderRadiiForRect): (WebCore::RenderStyle::getInnerBorderRadiiForRectWithBorderWidths):
  • rendering/style/RenderStyle.h: (WebCore::InheritedFlags::borderTopLeftRadius): (WebCore::InheritedFlags::borderTopRightRadius): (WebCore::InheritedFlags::borderBottomLeftRadius): (WebCore::InheritedFlags::borderBottomRightRadius): (WebCore::InheritedFlags::setBorderTopLeftRadius): (WebCore::InheritedFlags::setBorderTopRightRadius): (WebCore::InheritedFlags::setBorderBottomLeftRadius): (WebCore::InheritedFlags::setBorderBottomRightRadius): (WebCore::InheritedFlags::setBorderRadius): (WebCore::InheritedFlags::initialBorderRadius):
12:45 Changeset [66614] by tony@chromium.org
  • 2 edits
    6 adds in trunk/LayoutTests

2010-09-01 Tony Chang <tony@chromium.org>

Unreviewed, add chromium win/linux baselines for fast/multicol/float-paginate.html.

  • platform/chromium-linux/fast/multicol/float-paginate-expected.checksum: Added.
  • platform/chromium-linux/fast/multicol/float-paginate-expected.png: Added.
  • platform/chromium-linux/fast/multicol/float-paginate-expected.txt: Added.
  • platform/chromium-win/fast/multicol/float-paginate-expected.checksum: Added.
  • platform/chromium-win/fast/multicol/float-paginate-expected.png: Added.
  • platform/chromium-win/fast/multicol/float-paginate-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
12:37 Changeset [66613] by caseq@chromium.org
  • 2 edits in trunk/WebCore

2010-09-01 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: webInspector.inspectedWindow.evaluate() should not fail if not passed callback.
https://bugs.webkit.org/show_bug.cgi?id=45037

  • inspector/front-end/ExtensionAPI.js: (WebInspector.injectedExtensionAPI.InspectedWindow.prototype.evaluate):
11:14 Changeset [66612] by hyatt@apple.com
  • 3 edits
    4 adds
    4 deletes in trunk

WebCore: https://bugs.webkit.org/show_bug.cgi?id=44963, overhanging floats aren't positioned properly when they occur
in multi-column layout. Don't let floats overhang in multi-column blocks, since they are part of the column layout.

Reviewed by Dan Bernstein and Simon Fraser.

fast/multicol/float-pagination-failure now succeeds, so will rename and move it.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::addOverhangingFloats):

LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=44963, rename the float-paginate-failure test since it now
succeeds.

Reviewed by Dan Bernstein and Simon Fraser.

  • fast/multicol/float-paginate-failure.html: Removed.
  • fast/multicol/float-paginate.html: Added.
  • platform/mac/fast/multicol/float-paginate-expected.checksum: Added.
  • platform/mac/fast/multicol/float-paginate-expected.png: Added.
  • platform/mac/fast/multicol/float-paginate-expected.txt: Added.
  • platform/mac/fast/multicol/float-paginate-failure-expected.checksum: Removed.
  • platform/mac/fast/multicol/float-paginate-failure-expected.png: Removed.
  • platform/mac/fast/multicol/float-paginate-failure-expected.txt: Removed.
09:59 Changeset [66611] by kbr@google.com
  • 3 edits in trunk/WebCore

2010-08-31 Kenneth Russell <kbr@google.com>

Reviewed by Simon Fraser.

Add helpers to FloatRect to compute bounding box from points
https://bugs.webkit.org/show_bug.cgi?id=45015

Added fitToPoints, including a few overloaded variants for the
cases of two, three and four points. I opted not to add a
generalized version taking const FloatRect* or Vector<FloatRect>
at the present time because for my own purposes they are
unnecessary, and the specific versions can be more tightly coded.
Also added left() and top() for symmetry with right() and bottom().
These changes have been tested with new code to be added later.

  • platform/graphics/FloatRect.cpp: (WebCore::FloatRect::intersect): (WebCore::FloatRect::unite): (WebCore::FloatRect::fitToPoints):
  • platform/graphics/FloatRect.h: (WebCore::FloatRect::left): (WebCore::FloatRect::top): (WebCore::FloatRect::setLocationAndSizeFromEdges):
09:50 Changeset [66610] by antonm@chromium.org
  • 2 edits in trunk/WebCore

2010-09-01 Anton Muhin <antonm@chromium.org>

Reviewed by Dimitri Glazkov.

[v8] Use Vector and DEFINE_STATIC_LOCAL instead of plain static array.
https://bugs.webkit.org/show_bug.cgi?id=45040

By code guidelines all the statics should be wrapped into appropriate macro.

  • bindings/v8/V8Binding.cpp: (WebCore::int32ToWebCoreString):
09:34 Changeset [66609] by commit-queue@webkit.org
  • 2 edits in trunk

2010-09-01 Ryuan Choi <ryuan.choi@samsung.com>

Reviewed by Antonio Gomes.

[EFL] Need to check LibSoup version
https://bugs.webkit.org/show_bug.cgi?id=44658

Add version check of LibSoup.

  • cmake/FindLibSoup2.cmake:
09:18 Changeset [66608] by alex@webkit.org
  • 1 edit in trunk/LayoutTests/ChangeLog

2010-09-01 Alejandro G. Castro <alex@igalia.com>

Reviewed by Martin Robinson.

[Gtk] very slow page scrolling on big -webkit-box-shadow areas
https://bugs.webkit.org/show_bug.cgi?id=39582

Add a new drawTiledShadow method to render a big shadow doing
tiling of parts of a smaller shadow. We create the minimum shadow
required to get the tiles we will use to render the real shadow
and we use drawPattern with those tiles to create the shadow.

Pixel tests added.

  • platform/gtk/fast/box-shadow/basic-shadows-expected.checksum:
  • platform/gtk/fast/box-shadow/basic-shadows-expected.png:
  • platform/gtk/fast/css/shadow-multiple-expected.checksum:
  • platform/gtk/fast/css/shadow-multiple-expected.png:
  • platform/gtk/svg/css/stars-with-shadow-expected.checksum:
  • platform/gtk/svg/css/stars-with-shadow-expected.png:
09:10 Changeset [66607] by alex@webkit.org
  • 11 edits in trunk

2010-09-01 Alejandro G. Castro <alex@igalia.com>

Reviewed by Martin Robinson.

[Gtk] very slow page scrolling on big -webkit-box-shadow areas
https://bugs.webkit.org/show_bug.cgi?id=39582

Add a new drawTiledShadow method to render a big shadow doing
tiling of parts of a smaller shadow. We create the minimum shadow
required to get the tiles we will use to render the real shadow
and we use drawPattern with those tiles to create the shadow.

  • platform/graphics/GraphicsContext.h:
  • platform/graphics/cairo/FontCairo.cpp: (WebCore::Font::drawGlyphs):
  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::drawPathShadow): (WebCore::drawBorderlessRectShadow): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::applyPlatformShadow): (WebCore::GraphicsContext::createShadowMask): (WebCore::getPhase): (WebCore::GraphicsContext::drawTiledShadow): (WebCore::GraphicsContext::fillRoundedRect):
  • platform/graphics/cairo/ImageCairo.cpp: (WebCore::BitmapImage::draw):
09:01 Changeset [66606] by mrobinson@webkit.org
  • 2 edits in trunk/LayoutTests

2010-09-01 Martin Robinson <mrobinson@igalia.com>

Updating one more baseline, which seems to differ on the bots.

  • platform/gtk/fast/frames/onlyCommentInIFrame-expected.txt:
08:29 Changeset [66605] by mrobinson@webkit.org
  • 2 edits
    43 adds in trunk/LayoutTests

2010-09-01 Martin Robinson <mrobinson@igalia.com>

Add baselines and unskip non-failing tests in preparation for
landing scrollbar theme changes.

  • platform/gtk/Skipped:
  • platform/gtk/fast/dynamic/window-resize-scrollbars-test-expected.checksum: Added.
  • platform/gtk/fast/dynamic/window-resize-scrollbars-test-expected.png: Added.
  • platform/gtk/fast/dynamic/window-resize-scrollbars-test-expected.txt: Added.
  • platform/gtk/fast/dynamic/window-scrollbars-test-expected.checksum: Added.
  • platform/gtk/fast/dynamic/window-scrollbars-test-expected.png: Added.
  • platform/gtk/fast/dynamic/window-scrollbars-test-expected.txt: Added.
  • platform/gtk/fast/events/attempt-scroll-with-no-scrollbars-expected.txt: Added.
  • platform/gtk/fast/frames/001-expected.txt: Added.
  • platform/gtk/fast/frames/002-expected.txt: Copied from LayoutTests/platform/mac/fast/frames/002-expected.txt.
  • platform/gtk/fast/frames/calculate-fixed-expected.txt: Copied from LayoutTests/platform/qt/fast/frames/calculate-fixed-expected.txt.
  • platform/gtk/fast/frames/calculate-order-expected.txt: Copied from LayoutTests/platform/qt/fast/frames/calculate-order-expected.txt.
  • platform/gtk/fast/frames/calculate-percentage-expected.txt: Copied from LayoutTests/platform/qt/fast/frames/calculate-percentage-expected.txt.
  • platform/gtk/fast/frames/calculate-relative-expected.txt: Copied from LayoutTests/platform/qt/fast/frames/calculate-relative-expected.txt.
  • platform/gtk/fast/frames/calculate-round-expected.txt: Copied from LayoutTests/platform/mac/fast/frames/calculate-round-expected.txt.
  • platform/gtk/fast/frames/content-opacity-1-expected.txt: Copied from LayoutTests/platform/mac/fast/frames/content-opacity-1-expected.txt.
  • platform/gtk/fast/frames/content-opacity-2-expected.txt: Copied from LayoutTests/platform/mac/fast/frames/content-opacity-2-expected.txt.
  • platform/gtk/fast/frames/contentWindow_Frame-expected.txt: Added.
  • platform/gtk/fast/frames/contentWindow_iFrame-expected.txt: Added.
  • platform/gtk/fast/frames/empty-cols-attribute-expected.txt: Copied from LayoutTests/platform/mac/fast/frames/empty-cols-attribute-expected.txt.
  • platform/gtk/fast/frames/empty-frame-src-expected.txt: Copied from LayoutTests/platform/mac/fast/frames/empty-frame-src-expected.txt.
  • platform/gtk/fast/frames/frame-element-name-expected.txt: Added.
  • platform/gtk/fast/frames/frame-navigation-expected.txt: Added.
  • platform/gtk/fast/frames/frame-scrolling-attribute-expected.checksum: Added.
  • platform/gtk/fast/frames/frame-scrolling-attribute-expected.png: Added.
  • platform/gtk/fast/frames/frame-scrolling-attribute-expected.txt: Added.
  • platform/gtk/fast/frames/frame-set-whitespace-attributes-expected.txt: Copied from LayoutTests/platform/mac/fast/frames/frame-set-whitespace-attributes-expected.txt.
  • platform/gtk/fast/frames/frame-src-attribute-expected.txt: Added.
  • platform/gtk/fast/frames/frameElement-frame-expected.txt: Added.
  • platform/gtk/fast/frames/frameElement-iframe-expected.txt: Added.
  • platform/gtk/fast/frames/frameset-style-recalc-expected.txt: Added.
  • platform/gtk/fast/frames/iframe-option-crash-expected.txt: Added.
  • platform/gtk/fast/frames/iframe-scrolling-attribute-expected.checksum: Added.
  • platform/gtk/fast/frames/iframe-scrolling-attribute-expected.png: Added.
  • platform/gtk/fast/frames/iframe-scrolling-attribute-expected.txt: Added.
  • platform/gtk/fast/frames/iframe-text-contents-expected.txt: Copied from LayoutTests/platform/mac/fast/frames/iframe-text-contents-expected.txt.
  • platform/gtk/fast/frames/iframe-with-frameborder-expected.txt: Added.
  • platform/gtk/fast/frames/inline-object-inside-frameset-expected.txt: Added.
  • platform/gtk/fast/frames/invalid-expected.txt: Copied from LayoutTests/platform/qt/fast/frames/invalid-expected.txt.
  • platform/gtk/fast/frames/no-frame-borders-expected.txt: Copied from LayoutTests/platform/mac/fast/frames/no-frame-borders-expected.txt.
  • platform/gtk/fast/frames/onlyCommentInIFrame-expected.txt: Added.
  • platform/gtk/fast/frames/valid-expected.txt: Copied from LayoutTests/platform/qt/fast/frames/valid-expected.txt.
  • platform/gtk/fast/frames/viewsource-attribute-expected.txt: Added.
  • platform/gtk/fast/frames/viewsource-on-image-file-expected.txt: Added.
08:16 Changeset [66604] by antonm@chromium.org
  • 2 edits in trunk/LayoutTests

2010-09-01 Anton Muhin <antonm@chromium.org>

Unreviewed fix to update test expectations to recent SVG changes.

  • platform/chromium/test_expectations.txt:
08:04 Changeset [66603] by antonm@chromium.org
  • 2 edits in trunk/LayoutTests

2010-09-01 'Anton Muhin' <antonm@chromium.org>

Unreviewed expectations fix.

Due to recent changes in V8, Chromium now passes more ietestcentertests.

  • platform/chromium/test_expectations.txt:
07:46 Changeset [66602] by abecsi@webkit.org
  • 2 edits in trunk/WebKitTools

2010-09-01 Gabor Rapcsanyi <rgabor@inf.u-szeged.hu>

Reviewed by Antonio Gomes.

[Qt] Remove obsolete include path from DumpRenderTree.pro

  • DumpRenderTree/qt/DumpRenderTree.pro:
07:19 Changeset [66601] by caseq@chromium.org
  • 10 edits
    4 adds in trunk

2010-09-01 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector, Extension API: Panel.onSelectionChanged event is never fired
Added command line API to the lexical context of code evaluated by webInspector.inspectedWindow.evaluate()
Fixed webInspector.inspectedWindow.evaluate() to return object rather than its stringified representation
https://bugs.webkit.org/show_bug.cgi?id=44957

Test: inspector/extensions-eval.html

  • inspector/front-end/ExtensionAPI.js: (WebInspector.injectedExtensionAPI.InspectedWindow.prototype.evaluate):
  • inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer.prototype._onEvaluateOnInspectedPage):

2010-09-01 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector, Extension API: Panel.onSelectionChanged event is never fired
Added tests for webInspector.inspectedWindow.eval() and event dispatchers.
https://bugs.webkit.org/show_bug.cgi?id=44957

  • inspector/extensions-eval-expected.txt: Added.
  • inspector/extensions-eval.html: Added.
  • inspector/extensions-expected.txt:
  • inspector/extensions.html:
  • inspector/resources/extension-main.js: (fetchTests.callback): (fetchTests):
  • platform/chromium/test_expectations.txt:
07:12 Changeset [66600] by philn@webkit.org
  • 3 edits in trunk/WebCore

2010-08-27 Philippe Normand <pnormand@igalia.com>

Reviewed by Xan Lopez.

[GStreamer] ImageGStreamer doesn't need to hold a Cairo surface
https://bugs.webkit.org/show_bug.cgi?id=44757

Pass the cairo surface to the BitmapImage constructor which will
handle its life-cycle.

  • platform/graphics/gstreamer/ImageGStreamer.h:
  • platform/graphics/gstreamer/ImageGStreamerCairo.cpp: (ImageGStreamer::ImageGStreamer): (ImageGStreamer::~ImageGStreamer):
07:01 Changeset [66599] by zimmermann@webkit.org
  • 19 edits in trunk

2010-08-30 Patrick Gansterer <paroga@paroga.com>

Reviewed by Dirk Schulze.

RenderImage::imageChanged invalidates wrong area
https://bugs.webkit.org/show_bug.cgi?id=43779

Remove RenderImage inheritance from RenderSVGImage, it now inherits from RenderSVGModelObject.

  • rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::RenderSVGImage): (WebCore::RenderSVGImage::~RenderSVGImage): (WebCore::RenderSVGImage::layout): (WebCore::RenderSVGImage::paint): (WebCore::RenderSVGImage::imageChanged):
  • rendering/RenderSVGImage.h: (WebCore::RenderSVGImage::imageResource):
  • rendering/RenderSVGModelObject.h:
  • svg/SVGImageElement.cpp:

2010-09-01 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

RenderImage::imageChanged invalidates wrong area
https://bugs.webkit.org/show_bug.cgi?id=43779

Rebaseline SVG image dumpAsText() tests.
A newline is gone from each of the results, after switching from RenderImage to RenderSVGModelObject in RenderSVGImage.

  • svg/custom/loadevents-capturing-expected.txt:
  • svg/custom/loadevents-externalresourcesrequired-expected.txt:
  • svg/custom/loadevents-normal-expected.txt:
  • svg/dynamic-updates/SVGImageElement-dom-height-attr-expected.txt:
  • svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.txt:
  • svg/dynamic-updates/SVGImageElement-dom-width-attr-expected.txt:
  • svg/dynamic-updates/SVGImageElement-dom-x-attr-expected.txt:
  • svg/dynamic-updates/SVGImageElement-dom-y-attr-expected.txt:
  • svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.txt:
  • svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.txt:
  • svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.txt:
  • svg/dynamic-updates/SVGImageElement-svgdom-x-prop-expected.txt:
  • svg/dynamic-updates/SVGImageElement-svgdom-y-prop-expected.txt:
05:32 Changeset [66598] by zimmermann@webkit.org
  • 21 edits in trunk/WebCore

2010-09-01 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Add culling to RenderSVGContainer
https://bugs.webkit.org/show_bug.cgi?id=44896

Cache object/strokeBoundingBox and repaintRectInLocalCoordinates() in RenderSVGContainer & RenderSVGRoot, just like it's done in RenderPath.
Propagate boundary changes up the render tree, in layout phase, in order to notify parents that they should update their cached boundaries.

This is a huge speed benefit when interacting with an already layouted document, as there's no need anymore to traverse all children
of any container or <svg> element, just to retrieve the repaint rect.

  • rendering/RenderForeignObject.cpp: (WebCore::RenderForeignObject::layout): Propagate boundary changes to parent, if neeeded.
  • rendering/RenderObject.cpp: (WebCore::RenderObject::setNeedsBoundariesUpdate): Ditto.
  • rendering/RenderObject.h:
  • rendering/RenderObjectChildList.cpp: (WebCore::RenderObjectChildList::removeChildNode): Ditto.
  • rendering/RenderPath.cpp: (WebCore::RenderPath::layout): Ditto. (WebCore::RenderPath::paint): Use new helper function to intersect the paintInfo.rect with the repaintRectInLocalCoordinates().
  • rendering/RenderPath.h: Remove styleWillChange(), it's in RenderSVGModelObject now. (WebCore::RenderPath::setNeedsBoundariesUpdate): Mark as virtual, just like in RenderObject.
  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::RenderSVGContainer): Initialize m_needsBoundariesUpdate to true. (WebCore::RenderSVGContainer::layout): Only update cached boundaries, if needed, once by traversing the child tree. (WebCore::RenderSVGContainer::paint): Use new helper function to intersect the paintInfo.rect with the repaintRectInLocalCoordinates(). (WebCore::RenderSVGContainer::updateCachedBoundaries): Ask children for their boundaries, and cache them.
  • rendering/RenderSVGContainer.h: (WebCore::RenderSVGContainer::setNeedsBoundariesUpdate): Set m_needsBoundariesUpdate when called. (WebCore::RenderSVGContainer::objectBoundingBox): Inlined, just returns a member variable now. (WebCore::RenderSVGContainer::strokeBoundingBox): Ditto. (WebCore::RenderSVGContainer::repaintRectInLocalCoordinates): Ditto. (WebCore::RenderSVGContainer::calculateLocalTransform): Changed to return a boolean, wheter the transform was modified.
  • rendering/RenderSVGGradientStop.h: (WebCore::RenderSVGGradientStop::strokeBoundingBox): Add missing default implementation, return just FloatRect().
  • rendering/RenderSVGHiddenContainer.cpp: Remove repaintRectInLocalCoordinates() override, it's now needed for painting markers.
  • rendering/RenderSVGHiddenContainer.h: (WebCore::RenderSVGHiddenContainer::clippedOverflowRectForRepaint): Inlined, returning IntRect().
  • rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::layout): Propagate boundary changes to parent, if neeeded.
  • rendering/RenderSVGRoot.cpp: Cache boundaries here as well, just like in RenderSVGContainer. (WebCore::RenderSVGRoot::RenderSVGRoot): (WebCore::RenderSVGRoot::layout): (WebCore::RenderSVGRoot::updateCachedBoundaries):
  • rendering/RenderSVGRoot.h: (WebCore::RenderSVGRoot::setNeedsBoundariesUpdate): (WebCore::RenderSVGRoot::setNeedsTransformUpdate): (WebCore::RenderSVGRoot::objectBoundingBox): (WebCore::RenderSVGRoot::strokeBoundingBox): (WebCore::RenderSVGRoot::repaintRectInLocalCoordinates):
  • rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::layout): Propagate boundary changes to parent, if neeeded.
  • rendering/RenderSVGTransformableContainer.cpp: (WebCore::RenderSVGTransformableContainer::calculateLocalTransform): Return true, if the localTransform changed.
  • rendering/RenderSVGTransformableContainer.h:
  • rendering/RenderSVGViewportContainer.cpp: (WebCore::RenderSVGViewportContainer::calcViewport): Propagate boundary changes to parent, if neeeded.
  • rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderSupport::computeContainerBoundingBoxes): Helper function calculating object/strokeBoundingBox and repaintRectInLocalCoordinates in one shot. (WebCore::SVGRenderSupport::paintInfoIntersectsRepaintRect): Moved from RenderPath to share the culling functionality.
  • rendering/SVGRenderSupport.h:
05:31 Changeset [66597] by commit-queue@webkit.org
  • 15 edits
    2 adds in trunk

2010-09-01 Mahesh Kulkarni <mahesh.kulkarni@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] QWebPage::allowGeolocationRequest should be async API
https://bugs.webkit.org/show_bug.cgi?id=41364

Enable all geolocation delayed permission layout test for Qt port

  • platform/qt/Skipped:

2010-09-01 Mahesh Kulkarni <mahesh.kulkarni@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] QWebPage::allowGeolocationRequest should be async API
https://bugs.webkit.org/show_bug.cgi?id=41364

Adding GeolocationPermissionClientQt.cpp/h to build script

  • WebCore.pro:

2010-09-01 Mahesh Kulkarni <mahesh.kulkarni@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] QWebPage::allowGeolocationRequest should be async API
https://bugs.webkit.org/show_bug.cgi?id=41364

Provides a new async API for geolocation permission. Using
Notification API approach from qtwebkit. GeolocationPermissionClientQt
maintains list of pending requests from WebCore and intimates them
when client either allowes/denies the request. Also implements
ChromeClientQt::cancelGeolocationPermissionRequestForFrame.

  • Api/qwebpage.cpp: (QWebPage::setUserPermission):
  • Api/qwebpage.h:
  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::requestGeolocationPermissionForFrame): (WebCore::ChromeClientQt::cancelGeolocationPermissionRequestForFrame):
  • WebCoreSupport/ChromeClientQt.h:
  • WebCoreSupport/GeolocationPermissionClientQt.cpp: Added. (WebCore::GeolocationPermissionClientQt::geolocationPermissionClient): (WebCore::GeolocationPermissionClientQt::GeolocationPermissionClientQt): (WebCore::GeolocationPermissionClientQt::~GeolocationPermissionClientQt): (WebCore::GeolocationPermissionClientQt::requestGeolocationPermissionForFrame): (WebCore::GeolocationPermissionClientQt::cancelGeolocationPermissionRequestForFrame): (WebCore::GeolocationPermissionClientQt::setPermission):
  • WebCoreSupport/GeolocationPermissionClientQt.h: Added.
  • tests/qwebpage/tst_qwebpage.cpp: (JSTestPage::requestPermission): (tst_QWebPage::geolocationRequestJS):

2010-09-01 Mahesh Kulkarni <mahesh.kulkarni@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] QWebPage::allowGeolocationRequest should be async API
https://bugs.webkit.org/show_bug.cgi?id=41364

Implements new async API for geolocation permission similar to
Notification. WebPage maintains list of geolocation permission request
QtWebkit and set's when LayoutTestController gets the access from test JS

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::WebPage): (WebCore::WebPage::resetSettings): (WebCore::WebPage::requestPermission): (WebCore::WebPage::cancelPermission): (WebCore::WebPage::permissionSet): (WebCore::DumpRenderTree::DumpRenderTree): (WebCore::DumpRenderTree::processLine): (WebCore::DumpRenderTree::geolocationPermissionSet):
  • DumpRenderTree/qt/DumpRenderTreeQt.h:
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::reset): (LayoutTestController::setGeolocationPermission): (LayoutTestController::setGeolocationPermissionCommon):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
05:13 Changeset [66596] by commit-queue@webkit.org
  • 30 edits
    1 delete in trunk/LayoutTests

2010-09-01 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: move debugger tests to the new test harness
https://bugs.webkit.org/show_bug.cgi?id=44939

  • http/tests/inspector/debugger-test.js: Removed.
  • http/tests/inspector/debugger-test2.js: (initialize_DebuggerTest.InspectorTest.startDebuggerTest.startTest): (initialize_DebuggerTest.InspectorTest.startDebuggerTest): (initialize_DebuggerTest.InspectorTest.completeDebuggerTest.disableDebugger): (initialize_DebuggerTest.InspectorTest.runTestFunctionAndWaitUntilPaused): (initialize_DebuggerTest.InspectorTest.waitUntilPaused): (initialize_DebuggerTest.InspectorTest.waitUntilResumed): (initialize_DebuggerTest.InspectorTest.resumeExecution): (initialize_DebuggerTest.InspectorTest.captureStackTrace): (initialize_DebuggerTest.InspectorTest._pausedScript): (initialize_DebuggerTest.InspectorTest._resumedScript): (initialize_DebuggerTest.InspectorTest.waitUntilCurrentSourceFrameIsLoaded): (initialize_DebuggerTest.InspectorTest._showScriptSource): (initialize_DebuggerTest.InspectorTest.expandProperties.expandNextPath): (initialize_DebuggerTest.InspectorTest.expandProperties): (initialize_DebuggerTest.InspectorTest._expandProperty): (initialize_DebuggerTest.InspectorTest._findChildPropertyTreeElement): (initialize_DebuggerTest):
  • http/tests/inspector/inspector-test2.js: (initialize_InspectorTest.InspectorTest.completeTest): (initialize_InspectorTest.InspectorTest.evaluateInPage): (initialize_InspectorTest.InspectorTest.addResult.addResultToPage): (initialize_InspectorTest.InspectorTest.addResult): (initialize_InspectorTest.InspectorTest.addObject): (initialize_InspectorTest.InspectorTest.reloadPage): (initialize_InspectorTest.InspectorTest.pageReloaded): (initialize_InspectorTest.InspectorTest.runAfterPendingDispatches): (initialize_InspectorTest.InspectorTest.enableResourceTracking): (initialize_InspectorTest.InspectorTest.disableResourceTracking): (initialize_InspectorTest.InspectorTest._addSniffer): (runTest.runTestInFrontend): (runTest): (didEvaluateForTestInFrontend):
  • inspector/debugger-breakpoints-not-activated-on-reload.html:
  • inspector/debugger-cyclic-ref-expected.txt:
  • inspector/debugger-cyclic-ref.html:
  • inspector/debugger-eval-while-paused-expected.txt:
  • inspector/debugger-eval-while-paused.html:
  • inspector/debugger-no-nested-pause-expected.txt:
  • inspector/debugger-no-nested-pause.html:
  • inspector/debugger-pause-in-eval-script-expected.txt:
  • inspector/debugger-pause-in-eval-script.html:
  • inspector/debugger-pause-on-debugger-statement-expected.txt:
  • inspector/debugger-pause-on-debugger-statement.html:
  • inspector/debugger-proto-property-expected.txt:
  • inspector/debugger-proto-property.html:
  • inspector/debugger-step-in-expected.txt:
  • inspector/debugger-step-in.html:
  • inspector/debugger-step-out-expected.txt:
  • inspector/debugger-step-out.html:
  • inspector/debugger-step-over-expected.txt:
  • inspector/debugger-step-over.html:
  • inspector/dom-breakpoints-expected.txt:
  • inspector/dom-breakpoints.html:
  • inspector/extensions-api-expected.txt:
  • inspector/extensions-audits-api-expected.txt:
  • inspector/extensions-audits-expected.txt:
  • inspector/extensions-expected.txt:
  • inspector/report-protocol-errors.html:
  • platform/chromium/inspector/debugger-step-in-expected.txt:
04:36 Changeset [66595] by antonm@chromium.org
  • 7 edits
    3 adds in trunk/LayoutTests

2010-09-01 Anton Muhin <antonm@chromium.org>

Unreviewed, updating expected results for Chromium.

  • platform/chromium-linux/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt
  • platform/chromium-linux/fast/css/getComputedStyle/computed-style-expected.txt
  • platform/chromium-linux/svg/css/getComputedStyle-basic-expected.txt
  • platform/chromium-mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt
  • platform/chromium-mac/fast/css/getComputedStyle/computed-style-expected.txt
  • platform/chromium-mac/svg/css/getComputedStyle-basic-expected.txt
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt
  • platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt
04:30 Changeset [66594] by antonm@chromium.org
  • 1 edit
    8 adds in trunk/LayoutTests

2010-09-01 Anton Muhin <antonm@chromium.org>

Unreviewed, updating expected results for Chromium.

04:01 Changeset [66593] by loislo@chromium.org
  • 2 edits in trunk/LayoutTests

2010-09-01 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

WebInspector: disable inspector tests on mac-wk2.
The tests should be skipped until https://bugs.webkit.org/show_bug.cgi?id=42318 get fixed.

https://bugs.webkit.org/show_bug.cgi?id=44975

  • platform/mac-wk2/Skipped:
03:55 Changeset [66592] by abecsi@webkit.org
  • 5 edits
    1 add
    1 delete in trunk

2010-09-01 Andras Becsi <abecsi@webkit.org>

Reviewed by Antti Koivisto.

[Qt] Auto-generate WebKit2 forwarding headers
https://bugs.webkit.org/show_bug.cgi?id=44692

  • MiniBrowser/qt/BrowserWindow.h: use source style includes
  • MiniBrowser/qt/MiniBrowser.pro: add missing include paths
  • Scripts/enumerate-included-framework-headers: Removed.

2010-09-01 Andras Becsi <abecsi@webkit.org>

Reviewed by Antti Koivisto.

[Qt] Auto-generate WebKit2 forwarding headers
https://bugs.webkit.org/show_bug.cgi?id=44692

  • DerivedSources.pro: let the generate-forwarding-headers.pl script generate forwarding headers.
  • generate-forwarding-headers.pl: Added.
03:37 Changeset [66591] by ossy@webkit.org
  • 3 edits in trunk/LayoutTests

Unreviewed, updating expected results for r66581.

  • platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
03:23 Changeset [66590] by andreas.kling@nokia.com
  • 5 edits
    3 adds in trunk

2010-09-01 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Darin Adler.

DOM Selection: collapseToStart() and collapseToEnd() should throw INVALID_STATE_ERR if there's no selection
https://bugs.webkit.org/show_bug.cgi?id=44598

Spec links:
http://www.whatwg.org/specs/web-apps/current-work/#dom-selection-collapsetostart
http://www.whatwg.org/specs/web-apps/current-work/#dom-selection-collapsetoend

Test: fast/dom/Selection/collapseToX-empty-selection.html

  • page/DOMSelection.cpp: (WebCore::DOMSelection::collapseToEnd): (WebCore::DOMSelection::collapseToStart):
  • page/DOMSelection.h:
  • page/DOMSelection.idl:

2010-09-01 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Darin Adler.

DOM Selection: collapseToStart() and collapseToEnd() should throw INVALID_STATE_ERR if there's no selection
https://bugs.webkit.org/show_bug.cgi?id=44598

Spec links:
http://www.whatwg.org/specs/web-apps/current-work/#dom-selection-collapsetostart
http://www.whatwg.org/specs/web-apps/current-work/#dom-selection-collapsetoend

  • fast/dom/Selection/collapseToX-empty-selection-expected.txt: Added.
  • fast/dom/Selection/collapseToX-empty-selection.html: Added.
  • fast/dom/Selection/script-tests/collapseToX-empty-selection.js: Added.
02:35 Changeset [66589] by alex@webkit.org
  • 4 edits in trunk/LayoutTests

2010-09-01 Alejandro G. Castro <alex@igalia.com>

Unreviewed, updating expected results for r66581.

  • editing/pasteboard/onpaste-text-html-expected.txt:
  • fast/events/ondrop-text-html-expected.txt:
  • platform/gtk/svg/css/getComputedStyle-basic-expected.txt:
01:20 Changeset [66588] by kinuko@chromium.org
  • 2 edits in trunk/WebCore

2010-09-01 Kinuko Yasuda <kinuko@chromium.org>

Unreviewed; another build fix.

  • WebCore.pri:
01:15 Changeset [66587] by kinuko@chromium.org
  • 2 edits in trunk/WebCore

2010-09-01 Kinuko Yasuda <kinuko@chromium.org>

Unreviewed; qt build fix.

  • CMakeLists.txt:
01:05 Changeset [66586] by kinuko@chromium.org
  • 7 edits
    38 moves in trunk/WebCore

2010-08-31 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by Adam Barth.

Move FileSystem related files from WebCore/html to WebCore/fileapi.
https://bugs.webkit.org/show_bug.cgi?id=44925

No new tests; there should be no functional changes.

  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • fileapi/DOMFilePath.cpp: Renamed from WebCore/storage/DOMFilePath.cpp.
  • fileapi/DOMFilePath.h: Renamed from WebCore/storage/DOMFilePath.h.
  • fileapi/DOMFileSystem.cpp: Renamed from WebCore/storage/DOMFileSystem.cpp.
  • fileapi/DOMFileSystem.h: Renamed from WebCore/storage/DOMFileSystem.h.
  • fileapi/DOMFileSystem.idl: Renamed from WebCore/storage/DOMFileSystem.idl.
  • fileapi/DirectoryEntry.cpp: Renamed from WebCore/storage/DirectoryEntry.cpp.
  • fileapi/DirectoryEntry.h: Renamed from WebCore/storage/DirectoryEntry.h.
  • fileapi/DirectoryEntry.idl: Renamed from WebCore/storage/DirectoryEntry.idl.
  • fileapi/DirectoryReader.cpp: Renamed from WebCore/storage/DirectoryReader.cpp.
  • fileapi/DirectoryReader.h: Renamed from WebCore/storage/DirectoryReader.h.
  • fileapi/DirectoryReader.idl: Renamed from WebCore/storage/DirectoryReader.idl.
  • fileapi/EntriesCallback.h: Renamed from WebCore/storage/EntriesCallback.h.
  • fileapi/EntriesCallback.idl: Renamed from WebCore/storage/EntriesCallback.idl.
  • fileapi/Entry.cpp: Renamed from WebCore/storage/Entry.cpp.
  • fileapi/Entry.h: Renamed from WebCore/storage/Entry.h.
  • fileapi/Entry.idl: Renamed from WebCore/storage/Entry.idl.
  • fileapi/EntryArray.cpp: Renamed from WebCore/storage/EntryArray.cpp.
  • fileapi/EntryArray.h: Renamed from WebCore/storage/EntryArray.h.
  • fileapi/EntryArray.idl: Renamed from WebCore/storage/EntryArray.idl.
  • fileapi/EntryCallback.h: Renamed from WebCore/storage/EntryCallback.h.
  • fileapi/EntryCallback.idl: Renamed from WebCore/storage/EntryCallback.idl.
  • fileapi/ErrorCallback.h: Renamed from WebCore/storage/ErrorCallback.h.
  • fileapi/ErrorCallback.idl: Renamed from WebCore/storage/ErrorCallback.idl.
  • fileapi/FileEntry.cpp: Renamed from WebCore/storage/FileEntry.cpp.
  • fileapi/FileEntry.h: Renamed from WebCore/storage/FileEntry.h.
  • fileapi/FileEntry.idl: Renamed from WebCore/storage/FileEntry.idl.
  • fileapi/FileSystemCallback.h: Renamed from WebCore/storage/FileSystemCallback.h.
  • fileapi/FileSystemCallback.idl: Renamed from WebCore/storage/FileSystemCallback.idl.
  • fileapi/FileSystemCallbacks.cpp: Renamed from WebCore/storage/FileSystemCallbacks.cpp.
  • fileapi/FileSystemCallbacks.h: Renamed from WebCore/storage/FileSystemCallbacks.h.
  • fileapi/Flags.h: Renamed from WebCore/storage/Flags.h.
  • fileapi/Flags.idl: Renamed from WebCore/storage/Flags.idl.
  • fileapi/LocalFileSystem.cpp: Renamed from WebCore/storage/LocalFileSystem.cpp.
  • fileapi/LocalFileSystem.h: Renamed from WebCore/storage/LocalFileSystem.h.
  • fileapi/Metadata.h: Renamed from WebCore/storage/Metadata.h.
  • fileapi/Metadata.idl: Renamed from WebCore/storage/Metadata.idl.
  • fileapi/MetadataCallback.h: Renamed from WebCore/storage/MetadataCallback.h.
  • fileapi/MetadataCallback.idl: Renamed from WebCore/storage/MetadataCallback.idl.
00:43 Changeset [66585] by justin.garcia@apple.com
  • 5 edits in trunk/LayoutTests

Unreviewed, updating expected results for recent check-in.

  • editing/execCommand/5770834-1-expected.txt:
  • fast/css/getComputedStyle/computed-style-expected.txt:
  • fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • svg/css/getComputedStyle-basic-expected.txt:
00:15 Changeset [66584] by zimmermann@webkit.org
  • 13 edits in trunk/WebCore

2010-08-31 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Prepare RenderSVGContainer culling patch
https://bugs.webkit.org/show_bug.cgi?id=44955

Add styleWillChange methods for all SVG renderers, that call setNeedsBoundariesUpdate().
It's currently a no-op, but will be used once the containers cache their boundaries, which
happens in a follow-up patch.

  • rendering/RenderSVGBlock.cpp: (WebCore::RenderSVGBlock::styleWillChange): Call setNeedsBoundariesUpdate().
  • rendering/RenderSVGBlock.h:
  • rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::styleWillChange): Ditto.
  • rendering/RenderSVGImage.h:
  • rendering/RenderSVGInline.cpp: (WebCore::RenderSVGInline::styleWillChange): Ditto.
  • rendering/RenderSVGInline.h:
  • rendering/RenderSVGModelObject.cpp: (WebCore::RenderSVGModelObject::styleWillChange): Ditto.
  • rendering/RenderSVGModelObject.h:
  • rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::styleWillChange): Ditto.
  • rendering/RenderSVGRoot.h:
  • rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderSupport::computeContainerBoundingBox): Skip hidden containers, not necessary to traverse them.
  • rendering/style/SVGRenderStyle.cpp: (WebCore::SVGRenderStyle::diff): svg-shadow changes need to cause relayouts, not only repaints, once container bounds are cached.
Note: See TracTimeline for information about the timeline view.