Timeline


and

09/08/10:

23:58 Changeset [67067] by yurys@chromium.org

2010-09-08 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Joseph Pecoraro.

Web Inspector: add a sanity test for DOM storage view in the storage panel
https://bugs.webkit.org/show_bug.cgi?id=45294

  • inspector/storage-panel-dom-storage-expected.txt: Added.
  • inspector/storage-panel-dom-storage.html: Added.

2010-09-08 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Joseph Pecoraro.

Web Inspector: add a sanity test for DOM storage view in the storage panel
https://bugs.webkit.org/show_bug.cgi?id=45294

  • src/js/Tests.js: removed testStoragePanel which was superseded by inspector layout tests.
23:53 Changeset [67066] by zherczeg@webkit.org

Removing doneSemicolon label in the lexer
https://bugs.webkit.org/show_bug.cgi?id=45289

Reviewed by Darin Adler.

As a side effect of moving the multiline comment parsing
to a separate function, an opportunity raised to simplify
the single line comment parsing, and removing doneSemicolon
label. Slight performance increase on --parse-only
tests (from 32.8ms to 31.5ms)

  • parser/Lexer.cpp:

(JSC::Lexer::lex):

23:43 Changeset [67065] by xan@webkit.org

2010-09-08 Xan Lopez <xlopez@igalia.com>

Reviewed by Alexey Proskuryakov.

Remove accessor for private member variable in JSParser
https://bugs.webkit.org/show_bug.cgi?id=45378

m_token is private to JSParser, so it does not seem to be useful
to have an accessor for it. On top of that, the file was both
using the accessor and directly accessing the member variable,
only one style should be used.

23:32 Changeset [67064] by rniwa@webkit.org

2010-09-08 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Tony Chang.

MarkupAccumulator should be broken down into two classes
https://bugs.webkit.org/show_bug.cgi?id=44854

Extracted wrapWithNode, wrapWithStyleNode, stringValueForRange, renderedText, removeExteriorStyles,
shouldAnnotate, m_shouldAnnotate, and m_reversedPrecedingMarkup from MarkupAccumulator to create
StyledMarkupAccumulator in order to isolate annotation related code and prepending of text.

Isolating MarkupAccumulator as a separate class has two advantages:

  1. Isolated serialization code is easier to understand and easier to security-review.
  2. Embedder can use MarkupAccumulator to implement "Save as" feature.

Also made takeResults, appendText, and appendElement in MarkupAccumulator virtual to override in
StyledMarkupAccumulator because prepending text requires overriding takeResults, appendText needs
to append only rendered text when shouldAnnotate() is true, and appendElement requires a different
behavior when shouldAnnotate() is true or when called inside wrapWithNode with convertBlocksToInlines = true.

No new tests are added since this is a cleanup.

  • editing/markup.cpp: (WebCore::MarkupAccumulator::MarkupAccumulator): Removed shouldAnnotate from argument. (WebCore::MarkupAccumulator::~MarkupAccumulator): Added. (WebCore::StyledMarkupAccumulator::): Added. (WebCore::StyledMarkupAccumulator::StyledMarkupAccumulator): Added. (WebCore::StyledMarkupAccumulator::appendElement): Added to support annotation. (WebCore::StyledMarkupAccumulator::shouldAnnotate): Moved from MarkupAccumulator. (WebCore::MarkupAccumulator::appendStartTag): No longer takes convertBlocksToInlines and RangeFullySelectsNode. (WebCore::StyledMarkupAccumulator::wrapWithStyleNode): Moved from MarkupAccumulator. (WebCore::MarkupAccumulator::takeResults): No longer accumulates prepended text, and made virtual. (WebCore::StyledMarkupAccumulator::takeResults): Added to support prepended text. (WebCore::MarkupAccumulator::shouldAddNamespaceAttribute): Takes a reference to Attribute instead of a pointer. (WebCore::MarkupAccumulator::entityMaskForText): Extracted from appendText. (WebCore::MarkupAccumulator::appendText): No longer deals with annotation. (WebCore::StyledMarkupAccumulator::appendText): Added to support annotation. (WebCore::StyledMarkupAccumulator::stringValueForRange): Moved from MarkupAccumulator. (WebCore::StyledMarkupAccumulator::renderedText): Moved from MarkupAccumulator. (WebCore::MarkupAccumulator::appendElement): No longer deals with annotation. (WebCore::StyledMarkupAccumulator::wrapWithNode): Moved from MarkupAccumulator. (WebCore::StyledMarkupAccumulator::removeExteriorStyles): Moved from MarkupAccumulator. (WebCore::MarkupAccumulator::appendOpenTag): Added. (WebCore::MarkupAccumulator::appendCloseTag): Added. (WebCore::MarkupAccumulator::appendAttribute): Added. (WebCore::MarkupAccumulator::appendStartMarkup): No longer takes convertBlocksToInlines and RangeFullySelectsNode. (WebCore::serializeNodes): Takes StyledMarkupAccumulator. (WebCore::createMarkup): Range version uses StyledMarkupAccumulator and node version uses MarkupAccumulator.
22:57 Changeset [67063] by ukai@chromium.org

Unreviewed.

Rebaseline chromium-mac image: WebKit r67049 starts showing spelling marker under foo or so.

  • platform/chromium-mac/editing/execCommand/outdent-selection-expected.checksum: Added.
  • platform/chromium-mac/editing/execCommand/outdent-selection-expected.png: Added.
  • platform/chromium-mac/editing/inserting/insert-3907422-fix-expected.checksum: Added.
  • platform/chromium-mac/editing/inserting/insert-3907422-fix-expected.png: Added.
  • platform/chromium-mac/editing/pasteboard/interchange-newline-1-expected.checksum: Added.
  • platform/chromium-mac/editing/pasteboard/interchange-newline-1-expected.png: Added.
  • platform/chromium-mac/editing/pasteboard/merge-after-delete-1-expected.checksum: Added.
  • platform/chromium-mac/editing/pasteboard/merge-after-delete-1-expected.png: Added.
  • platform/chromium-mac/editing/pasteboard/merge-after-delete-2-expected.checksum: Added.
  • platform/chromium-mac/editing/pasteboard/merge-after-delete-2-expected.png: Added.
  • platform/chromium-mac/editing/pasteboard/merge-after-delete-expected.checksum: Added.
  • platform/chromium-mac/editing/pasteboard/merge-after-delete-expected.png: Added.
  • platform/chromium-mac/editing/pasteboard/merge-end-4-expected.checksum: Added.
  • platform/chromium-mac/editing/pasteboard/merge-end-4-expected.png: Added.
  • platform/chromium-mac/editing/pasteboard/merge-end-blockquote-expected.checksum: Added.
  • platform/chromium-mac/editing/pasteboard/merge-end-blockquote-expected.png: Added.
  • platform/chromium-mac/editing/pasteboard/merge-end-list-expected.checksum: Added.
  • platform/chromium-mac/editing/pasteboard/merge-end-list-expected.png: Added.
  • platform/chromium-mac/editing/pasteboard/merge-end-table-expected.checksum: Added.
  • platform/chromium-mac/editing/pasteboard/merge-end-table-expected.png: Added.
  • platform/chromium-mac/editing/style/create-block-for-style-011-expected.checksum: Added.
  • platform/chromium-mac/editing/style/create-block-for-style-011-expected.png: Added.
  • platform/chromium-mac/editing/style/create-block-for-style-012-expected.checksum: Added.
  • platform/chromium-mac/editing/style/create-block-for-style-012-expected.png: Added.
22:35 Changeset [67062] by ossy@webkit.org

2010-09-08 Csaba Osztrogonác <ossy@webkit.org>

Reviewed by Oliver Hunt.

[Qt] REGRESSION(63348): jsc is broken
https://bugs.webkit.org/show_bug.cgi?id=42818

Need fastcall conventions on Qt/Win/MinGW.
Based on patches of Gavin Barraclough: r63947 and r63948.

  • jit/JITStubs.cpp:
  • jit/JITStubs.h:
22:26 Changeset [67061] by ossy@webkit.org

LayoutTest regressions due to http://trac.webkit.org/changeset/67001
https://bugs.webkit.org/show_bug.cgi?id=45411

  • platform/qt/Skipped: Unskip tests, because bug fixed in r67052.
22:18 Changeset [67060] by commit-queue@webkit.org

2010-09-08 Mihai Parparita <mihaip@chromium.org>

Reviewed by Dimitri Glazkov.

pushstate-clears-forward-history.html crashes with Chromium DRT
https://bugs.webkit.org/show_bug.cgi?id=45351

pushstate-clears-forward-history.html would appear to crash with the
Chromium DRT. The crash was actually caused by the test that preceded
it, popstate-fires-with-page-cache.html, added with r66628. That test
would close a popup window during a popstate event handler, triggering
bug 36202 (popstate fires sychronously instead of asynchronously),
leading to asserts firing.

The workaround is to simulate popstate being async by wrapping the
cleanup code in a timeout (fixing 36202 itself is also on my radar).

  • fast/loader/stateobjects/popstate-fires-with-page-cache.html:
  • platform/chromium/drt_expectations.txt:
21:30 Changeset [67059] by morrita@google.com

2010-09-08 MORITA Hajime <morrita@google.com>

Unreviewed, Added 1 test failures on Win to test_expectations.txt

  • platform/chromium/test_expectations.txt:
21:14 Changeset [67058] by morrita@google.com

2010-09-08 MORITA Hajime <morrita@google.com>

Unreviewed, Added newly failing test to skipped list.

  • platform/gtk/Skipped:
21:11 Changeset [67057] by tony@chromium.org

2010-09-08 Tony Chang <tony@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] remove Skipped file from google-chrome-linux64
https://bugs.webkit.org/show_bug.cgi?id=45320

The file is not used by chromium. Also add a README files to try to
make this less confusing.

  • platform/google-chrome-linux32/README: Added.
  • platform/google-chrome-linux64/README: Added.
  • platform/google-chrome-linux64/Skipped: Removed.
21:00 Changeset [67056] by ukai@chromium.org

Unreviewed.

Rebaseline for chromium-win. console message diffs in JavaScript engine.

  • platform/chromium-win/inspector/debugger-autocontinue-on-syntax-error-expected.txt: Added.
20:34 Changeset [67055] by ukai@chromium.org

Unreviewed.

Fixed typo: s/fixd/fixed/

  • platform/chromium/test_expectations.txt:
20:26 Changeset [67054] by morrita@google.com

2010-09-08 MORITA Hajime <morrita@google.com>

Unreviewed, Added newly failing test to skipped list.

  • platform/qt/Skipped:
20:18 Changeset [67053] by pkasting@chromium.org

Merge 67052 - Not reviewed, layout test fix.

Fix flaky layout test results caused by not initializing members correctly.
https://bugs.webkit.org/show_bug.cgi?id=45411

  • platform/ScrollAnimator.cpp:

(WebCore::ScrollAnimator::ScrollAnimator):
(WebCore::ScrollAnimator::~ScrollAnimator):

  • platform/ScrollAnimator.h:

TBR=pkasting@chromium.org
Review URL: http://codereview.chromium.org/3305022

20:15 Changeset [67052] by pkasting@chromium.org

Not reviewed, layout test fix.

Fix flaky layout test results caused by not initializing members correctly.
https://bugs.webkit.org/show_bug.cgi?id=45411

  • platform/ScrollAnimator.cpp:

(WebCore::ScrollAnimator::ScrollAnimator):
(WebCore::ScrollAnimator::~ScrollAnimator):

  • platform/ScrollAnimator.h:
19:50 Changeset [67051] by jamesr@google.com

2010-09-08 Mihai Parparita <mihaip@chromium.org>

Reviewed by James Robinson.

http/tests/navigation/anchor-frames.html doesn't pass with TestShell
https://bugs.webkit.org/show_bug.cgi?id=45430

Check scroll position in a timeout, otherwise TestShell will report 0
for it.

  • http/tests/navigation/resources/frame-with-anchor.html:
19:18 Changeset [67050] by mjs@apple.com

Not reviewed, fixing trivial typo.

Fix typo in my last commit (.htm should be .html)

  • platform/mac-wk2/Skipped:
19:05 Changeset [67049] by morrita@google.com

2010-09-08 MORITA Hajime <morrita@google.com>

Reviewed by Tony Chang.

spelling underline gets lost on backspace
https://bugs.webkit.org/show_bug.cgi?id=41423

  • editing/spelling/script-tests/TEMPLATE.html: Copied from LayoutTests/editing/selection/script-tests/TEMPLATE.html.
  • editing/spelling/script-tests/spelling-backspace-between-lines.js: Added.
  • editing/spelling/spelling-backspace-between-lines-expected.txt: Added.
  • editing/spelling/spelling-backspace-between-lines.html: Added.

2010-09-08 MORITA Hajime <morrita@google.com>

Reviewed by Tony Chang.

spelling underline gets lost on backspace
https://bugs.webkit.org/show_bug.cgi?id=41423

moveParagraphs() did make a DOM range by serializing source range
and deserializing it back, and markers are gone during the process.
This change marks that DOM range again.

Test: editing/spelling/spelling-backspace-between-lines.html

  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::moveParagraphs):
  • editing/Editor.cpp: (WebCore::Editor::clearMisspellingsAndBadGrammar): Added. (WebCore::Editor::markMisspellingsAndBadGrammar): Added.
  • editing/Editor.h:

2010-09-08 MORITA Hajime <morrita@google.com>

Reviewed by Tony Chang.

spelling underline gets lost on backspace
https://bugs.webkit.org/show_bug.cgi?id=41423

Switched to use a anchorNode of the selection instead of a focused
node for finer control of node selection in spellingNode():
With the focused node, we cannot select other nodes but the first
child of that node. In some case, we need to inspect these.

The API is only for LayoutTests, and the change is compatible for
existing test cases.

  • WebView/WebFrame.mm: (spellingNode):
18:57 Changeset [67048] by ukai@chromium.org

Unreviewed.

Add 4 tests failures on Win to test_expectations.txt

  • editing/input/page-up-down-scrolls.html
  • fast/events/remove-child-onscroll.html
  • fast/events/scroll-event-does-not-bubble.html
  • fast/repaint/fixd-move-after-keyboard-scroll.html
  • platform/chromium/test_expectations.txt:
18:43 Changeset [67047] by weinig@apple.com

WebKit2 needs a way to box numbers (for Array, Dictionary, etc.)
<rdar://problem/8408844>
https://bugs.webkit.org/show_bug.cgi?id=45429

Reviewed by Dan Bernstein.

This adds a generic WebNumber class that can be used for any scalar
numeric type. Right now, we are only exposing a double version, but it
is designed to allow more.

  • Shared/APIObject.h:
  • Shared/WebNumber.h: Added.

(WebKit::WebNumber::create):
(WebKit::WebNumber::value):
(WebKit::WebNumber::setValue):
(WebKit::WebNumber::WebNumber):
(WebKit::WebNumber::type):

  • UIProcess/API/C/WKAPICast.h:
  • UIProcess/API/C/WKBase.h:
  • UIProcess/API/C/WKNumber.cpp: Added.

(WKDoubleGetTypeID):
(WKDoubleCreate):
(WKDoubleGetValue):
(WKDoubleSetValue):

  • UIProcess/API/C/WKNumber.h: Added.
  • UIProcess/API/C/WebKit2.h:
  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:
  • win/WebKit2Generated.make:
18:31 Changeset [67046] by ukai@chromium.org

Unreviewed.

Add fast/dom/dataset-gc.html to test_expectations.txt

  • platform/chromium/test_expectations.txt:
18:25 Changeset [67045] by ukai@chromium.org

Unreviewed.

Add svg/dynamic-updates/SVGFEDiffuseLightingElement-lighting-color-css-prop.html to test_expectations.txt

  • platform/chromium/test_expectations.txt:
18:09 Changeset [67044] by tony@chromium.org

2010-09-08 Tony Chang <tony@chromium.org>

Unreviewed. Remove compositing results because we skip these
tests in chromium-linux.

  • platform/chromium-linux/compositing: Removed.
  • platform/chromium-linux/compositing/generated-content-expected.checksum: Removed.
  • platform/chromium-linux/compositing/generated-content-expected.png: Removed.
  • platform/chromium-linux/compositing/overflow: Removed.
  • platform/chromium-linux/compositing/overflow/overflow-positioning-expected.checksum: Removed.
  • platform/chromium-linux/compositing/overflow/overflow-positioning-expected.png: Removed.
  • platform/chromium-linux/compositing/repaint: Removed.
  • platform/chromium-linux/compositing/repaint/become-overlay-composited-layer-expected.checksum: Removed.
18:01 Changeset [67043] by tony@chromium.org

2010-09-08 Tony Chang <tony@chromium.org>

Unreviewed. Adding png files for chromium-linux tests that have
.checksum files but no png files. Also remove 4 checksums where
there is no corresponding png file, but we're failing the tests so
I didn't want to check in a bad png file.

  • platform/chromium-linux/editing/deleting/collapse-whitespace-3587601-fix-expected.png: Copied from LayoutTests/platform/chromium-win/editing/deleting/collapse-whitespace-3587601-fix-expected.png.
  • platform/chromium-linux/editing/deleting/delete-at-start-or-end-expected.png: Copied from LayoutTests/platform/chromium-win/editing/deleting/delete-at-start-or-end-expected.png.
  • platform/chromium-linux/editing/deleting/delete-block-contents-001-expected.png: Copied from LayoutTests/platform/chromium-win/editing/deleting/delete-block-contents-001-expected.png.
  • platform/chromium-linux/editing/deleting/delete-block-contents-002-expected.png: Copied from LayoutTests/platform/chromium-win/editing/deleting/delete-block-contents-002-expected.png.
  • platform/chromium-linux/editing/deleting/delete-image-004-expected.png: Copied from LayoutTests/platform/chromium-win/editing/deleting/delete-image-004-expected.png.
  • platform/chromium-linux/editing/deleting/delete-select-all-002-expected.png: Copied from LayoutTests/platform/chromium-win/editing/deleting/delete-select-all-002-expected.png.
  • platform/chromium-linux/editing/deleting/delete-select-all-003-expected.png: Copied from LayoutTests/platform/chromium-win/editing/deleting/delete-select-all-003-expected.png.
  • platform/chromium-linux/editing/pasteboard/innerText-inline-table-expected.png: Added.
  • platform/chromium-linux/editing/pasteboard/paste-table-cells-expected.png: Added.
  • platform/chromium-linux/editing/selection/selectNode-expected.png: Added.
  • platform/chromium-linux/editing/selection/selectNodeContents-expected.png: Added.
  • platform/chromium-linux/editing/undo/5378473-expected.png: Copied from LayoutTests/platform/chromium-win/editing/undo/5378473-expected.png.
  • platform/chromium-linux/editing/undo/undo-misspellings-expected.png: Copied from LayoutTests/platform/chromium-win/editing/undo/undo-misspellings-expected.png.
  • platform/chromium-linux/fast/backgrounds/bgCompositeCopy-expected.png: Copied from LayoutTests/platform/chromium-win/fast/backgrounds/bgCompositeCopy-expected.png.
  • platform/chromium-linux/fast/backgrounds/svg-as-background-2-expected.png: Copied from LayoutTests/platform/chromium-win/fast/backgrounds/svg-as-background-2-expected.png.
  • platform/chromium-linux/fast/block/basic/quirk-percent-height-table-cell-expected.png: Copied from LayoutTests/platform/chromium-win/fast/block/basic/quirk-percent-height-table-cell-expected.png.
  • platform/chromium-linux/fast/block/float/014-expected.png: Added.
  • platform/chromium-linux/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png: Added.
  • platform/chromium-linux/fast/borders/svg-as-border-image-2-expected.png: Added.
  • platform/chromium-linux/fast/borders/svg-as-border-image-expected.png: Added.
  • platform/chromium-linux/fast/canvas/canvas-as-image-incremental-repaint-expected.png: Copied from LayoutTests/platform/chromium-win/fast/canvas/canvas-as-image-incremental-repaint-expected.png.
  • platform/chromium-linux/fast/canvas/canvas-text-baseline-expected.png: Added.
  • platform/chromium-linux/fast/canvas/quadraticCurveTo-expected.png: Added.
  • platform/chromium-linux/fast/css-generated-content/table-row-group-to-inline-expected.png: Added.
  • platform/chromium-linux/fast/css-generated-content/table-row-group-with-before-expected.png: Added.
  • platform/chromium-linux/fast/css-generated-content/table-row-with-before-expected.png: Added.
  • platform/chromium-linux/fast/css-generated-content/table-with-before-expected.png: Added.
  • platform/chromium-linux/fast/css/001-expected.png: Added.
  • platform/chromium-linux/fast/css/background-shorthand-invalid-url-expected.png: Added.
  • platform/chromium-linux/fast/css/value-list-out-of-bounds-crash-expected.png: Added.
  • platform/chromium-linux/fast/css/variables/image-test-expected.png: Added.
  • platform/chromium-linux/fast/doctypes/001-expected.png: Added.
  • platform/chromium-linux/fast/doctypes/002-expected.png: Added.
  • platform/chromium-linux/fast/doctypes/004-expected.png: Added.
  • platform/chromium-linux/fast/forms/preserveFormDuringResidualStyle-expected.png: Added.
  • platform/chromium-linux/fast/inline-block/14498-positionForCoordinates-expected.png: Added.
  • platform/chromium-linux/fast/inline/emptyInlinesWithinLists-expected.png: Added.
  • platform/chromium-linux/fast/invalid/016-expected.png: Added.
  • platform/chromium-linux/fast/layers/add-layer-with-nested-stacking-expected.png: Copied from LayoutTests/platform/chromium-win/fast/layers/add-layer-with-nested-stacking-expected.png.
  • platform/chromium-linux/fast/layers/self-painting-outline-expected.png: Copied from LayoutTests/platform/chromium-win/fast/layers/self-painting-outline-expected.png.
  • platform/chromium-linux/fast/layers/video-layer-expected.png: Added.
  • platform/chromium-linux/fast/lists/005-expected.png: Added.
  • platform/chromium-linux/fast/lists/big-list-marker-expected.png: Added.
  • platform/chromium-linux/fast/lists/scrolled-marker-paint-expected.png: Added.
  • platform/chromium-linux/fast/parser/parseCommentsInTitles-expected.png: Added.
  • platform/chromium-linux/fast/repaint/background-generated-expected.png: Copied from LayoutTests/platform/chromium-win/fast/repaint/background-generated-expected.png.
  • platform/chromium-linux/fast/repaint/background-misaligned-expected.png: Copied from LayoutTests/platform/chromium-win/fast/repaint/background-misaligned-expected.png.
  • platform/chromium-linux/fast/repaint/block-selection-gap-in-table-cell-expected.png: Copied from LayoutTests/platform/chromium-win/fast/repaint/block-selection-gap-in-table-cell-expected.png.
  • platform/chromium-linux/fast/repaint/block-selection-gap-stale-cache-expected.png: Added.
  • platform/chromium-linux/fast/repaint/button-spurious-layout-hint-expected.png: Copied from LayoutTests/platform/chromium-win/fast/repaint/button-spurious-layout-hint-expected.png.
  • platform/chromium-linux/fast/repaint/clip-with-layout-delta-expected.png: Added.
  • platform/chromium-linux/fast/repaint/content-into-overflow-expected.png: Copied from LayoutTests/platform/chromium-win/fast/repaint/content-into-overflow-expected.png.
  • platform/chromium-linux/fast/repaint/float-in-new-block-with-layout-delta-expected.png: Copied from LayoutTests/platform/chromium-win/fast/repaint/float-in-new-block-with-layout-delta-expected.png.
  • platform/chromium-linux/fast/repaint/float-new-in-block-expected.png: Copied from LayoutTests/platform/chromium-win/fast/repaint/float-new-in-block-expected.png.
  • platform/chromium-linux/fast/repaint/focus-ring-expected.png: Copied from LayoutTests/platform/chromium-win/fast/repaint/focus-ring-expected.png.
  • platform/chromium-linux/fast/repaint/inline-relative-positioned-expected.png: Added.
  • platform/chromium-linux/fast/repaint/intermediate-layout-position-clip-expected.png: Copied from LayoutTests/platform/chromium-win/fast/repaint/intermediate-layout-position-clip-expected.png.
  • platform/chromium-linux/fast/repaint/intermediate-layout-position-expected.png: Copied from LayoutTests/platform/chromium-win/fast/repaint/intermediate-layout-position-expected.png.
  • platform/chromium-linux/fast/repaint/multicol-repaint-expected.png: Copied from LayoutTests/platform/chromium-win/fast/repaint/multicol-repaint-expected.png.
  • platform/chromium-linux/fast/repaint/outline-inset-expected.png: Copied from LayoutTests/platform/chromium-win/fast/repaint/outline-inset-expected.png.
  • platform/chromium-linux/fast/repaint/overflow-into-content-expected.png: Copied from LayoutTests/platform/chromium-win/fast/repaint/overflow-into-content-expected.png.
  • platform/chromium-linux/fast/repaint/positioned-document-element-expected.png: Added.
  • platform/chromium-linux/fast/repaint/selection-clear-expected.png: Copied from LayoutTests/platform/chromium-win/fast/repaint/selection-clear-expected.png.
  • platform/chromium-linux/fast/repaint/table-outer-border-expected.png: Copied from LayoutTests/platform/chromium-win/fast/repaint/table-outer-border-expected.png.
  • platform/chromium-linux/fast/repaint/table-section-repaint-expected.png: Copied from LayoutTests/platform/chromium-win/fast/repaint/table-section-repaint-expected.png.
  • platform/chromium-linux/fast/repaint/table-two-pass-layout-overpaint-expected.png: Copied from LayoutTests/platform/chromium-win/fast/repaint/table-two-pass-layout-overpaint-expected.png.
  • platform/chromium-linux/fast/repaint/transform-disable-layoutstate-expected.png: Copied from LayoutTests/platform/chromium-win/fast/repaint/transform-disable-layoutstate-expected.png.
  • platform/chromium-linux/fast/repaint/transform-replaced-shadows-expected.png: Copied from LayoutTests/platform/chromium-win/fast/repaint/transform-replaced-shadows-expected.png.
  • platform/chromium-linux/fast/replaced/image-sizing-expected.png: Added.
  • platform/chromium-linux/fast/runin/generated4-expected.png: Added.
  • platform/chromium-linux/fast/selectors/001-expected.png: Added.
  • platform/chromium-linux/fast/selectors/013-expected.png: Added.
  • platform/chromium-linux/fast/selectors/015-expected.png: Added.
  • platform/chromium-linux/fast/table/border-collapsing/equal-precedence-resolution-expected.png: Copied from LayoutTests/platform/chromium-win/fast/table/border-collapsing/equal-precedence-resolution-expected.png.
  • platform/chromium-linux/fast/table/giantRowspan-expected.png: Copied from LayoutTests/platform/chromium-win/fast/table/giantRowspan-expected.png.
  • platform/chromium-linux/fast/table/multiple-percent-height-rows-expected.png: Copied from LayoutTests/platform/chromium-win/fast/table/multiple-percent-height-rows-expected.png.
  • platform/chromium-linux/scrollbars/listbox-scrollbar-combinations-expected.png: Added.
  • platform/chromium-linux/svg/batik/masking/maskRegions-expected.checksum: Removed.
  • platform/chromium-linux/svg/custom/bug45331-expected.png: Added.
  • platform/chromium-linux/svg/custom/clone-element-with-animated-svg-properties-expected.png: Added.
  • platform/chromium-linux/svg/custom/control-points-for-S-and-T-expected.png: Copied from LayoutTests/platform/chromium-win/svg/custom/control-points-for-S-and-T-expected.png.
  • platform/chromium-linux/svg/custom/deep-dynamic-updates-expected.png: Added.
  • platform/chromium-linux/svg/custom/dynamic-empty-path-expected.png: Copied from LayoutTests/platform/chromium-win/svg/custom/dynamic-empty-path-expected.png.
  • platform/chromium-linux/svg/custom/feDisplacementMap-01-expected.png: Copied from LayoutTests/platform/chromium-win/svg/custom/feDisplacementMap-01-expected.png.
  • platform/chromium-linux/svg/custom/fill-opacity-hsl-expected.png: Copied from LayoutTests/platform/chromium-win/svg/custom/fill-opacity-hsl-expected.png.
  • platform/chromium-linux/svg/custom/fill-opacity-rgba-expected.png: Copied from LayoutTests/platform/chromium-win/svg/custom/fill-opacity-rgba-expected.png.
  • platform/chromium-linux/svg/custom/glyph-transformation-with-hkern-expected.png: Added.
  • platform/chromium-linux/svg/custom/gradient-stop-corner-cases-expected.png: Copied from LayoutTests/platform/chromium-win/svg/custom/gradient-stop-corner-cases-expected.png.
  • platform/chromium-linux/svg/custom/grayscale-gradient-mask-expected.checksum: Removed.
  • platform/chromium-linux/svg/custom/group-opacity-expected.png: Copied from LayoutTests/platform/chromium-win/svg/custom/group-opacity-expected.png.
  • platform/chromium-linux/svg/custom/image-with-transform-clip-filter-expected.png: Added.
  • platform/chromium-linux/svg/custom/js-repaint-rect-on-path-with-stroke-expected.png: Copied from LayoutTests/platform/chromium-win/svg/custom/js-repaint-rect-on-path-with-stroke-expected.png.
  • platform/chromium-linux/svg/custom/js-update-container-expected.png: Copied from LayoutTests/platform/chromium-win/svg/custom/js-update-container-expected.png.
  • platform/chromium-linux/svg/custom/js-update-container2-expected.png: Copied from LayoutTests/platform/chromium-win/svg/custom/js-update-container2-expected.png.
  • platform/chromium-linux/svg/custom/js-update-polygon-changes-expected.png: Copied from LayoutTests/platform/chromium-win/svg/custom/js-update-polygon-changes-expected.png.
  • platform/chromium-linux/svg/custom/js-update-polygon-removal-expected.png: Copied from LayoutTests/platform/chromium-win/svg/custom/js-update-polygon-removal-expected.png.
  • platform/chromium-linux/svg/custom/js-update-style-expected.png: Copied from LayoutTests/platform/chromium-win/svg/custom/js-update-style-expected.png.
  • platform/chromium-linux/svg/custom/js-update-transform-addition-expected.png: Copied from LayoutTests/platform/chromium-win/svg/custom/js-update-transform-addition-expected.png.
  • platform/chromium-linux/svg/custom/marker-referencePoint-expected.png: Copied from LayoutTests/platform/chromium-win/svg/custom/marker-referencePoint-expected.png.
  • platform/chromium-linux/svg/custom/mouse-move-on-svg-container-expected.png: Added.
  • platform/chromium-linux/svg/custom/mouse-move-on-svg-container-standalone-expected.png: Added.
  • platform/chromium-linux/svg/custom/mouse-move-on-svg-root-expected.png: Added.
  • platform/chromium-linux/svg/custom/mouse-move-on-svg-root-standalone-expected.png: Added.
  • platform/chromium-linux/svg/custom/non-scaling-stroke-expected.checksum: Removed.
  • platform/chromium-linux/svg/custom/pattern-cycle-detection-expected.png: Added.
  • platform/chromium-linux/svg/custom/pattern-deep-referencing-expected.png: Added.
  • platform/chromium-linux/svg/custom/pattern-with-transformation-expected.png: Added.
  • platform/chromium-linux/svg/custom/pattern-y-offset-expected.png: Copied from LayoutTests/platform/chromium-win/svg/custom/pattern-y-offset-expected.png.
  • platform/chromium-linux/svg/custom/repaint-moving-svg-and-div-expected.png: Copied from LayoutTests/platform/chromium-win/svg/custom/repaint-moving-svg-and-div-expected.png.
  • platform/chromium-linux/svg/custom/repaint-stroke-width-changes-expected.png: Copied from LayoutTests/platform/chromium-win/svg/custom/repaint-stroke-width-changes-expected.png.
  • platform/chromium-linux/svg/custom/stroked-pattern-expected.checksum: Removed.
  • platform/chromium-linux/svg/custom/svg-fonts-with-no-element-reference-expected.png: Added.
  • platform/chromium-linux/svg/custom/text-dom-removal-expected.png: Copied from LayoutTests/platform/chromium-win/svg/custom/text-dom-removal-expected.png.
  • platform/chromium-linux/svg/custom/text-linking-expected.png: Added.
  • platform/chromium-linux/svg/custom/use-forward-refs-expected.png: Copied from LayoutTests/platform/chromium-win/svg/custom/use-forward-refs-expected.png.
  • platform/chromium-linux/svg/filters/feComposite-expected.png: Added.
  • platform/chromium-linux/svg/filters/filter-on-tspan-expected.png: Added.
  • platform/chromium-linux/svg/filters/filter-width-update-expected.png: Added.
  • platform/chromium-linux/svg/filters/sourceAlpha-expected.png: Added.
  • platform/chromium-linux/svg/foreignObject/no-crash-with-svg-content-in-html-document-expected.png: Added.
  • platform/chromium-linux/svg/foreignObject/svg-document-as-direct-child-expected.png: Added.
  • platform/chromium-linux/svg/foreignObject/svg-document-in-html-document-expected.png: Added.
  • platform/chromium-linux/svg/hixie/data-types/001-expected.png: Copied from LayoutTests/platform/chromium-win/svg/hixie/data-types/001-expected.png.
  • platform/chromium-linux/svg/zoom/text/absolute-sized-document-no-scrollbars-expected.png: Copied from LayoutTests/platform/chromium-win/svg/zoom/text/absolute-sized-document-no-scrollbars-expected.png.
  • platform/chromium-linux/svg/zoom/text/absolute-sized-document-scrollbars-expected.png: Copied from LayoutTests/platform/chromium-win/svg/zoom/text/absolute-sized-document-scrollbars-expected.png.
  • platform/chromium-linux/svg/zoom/text/relative-sized-document-scrollbars-expected.png: Copied from LayoutTests/platform/chromium-win/svg/zoom/text/relative-sized-document-scrollbars-expected.png.
  • platform/chromium-linux/tables/mozilla/bugs/bug106795-expected.png: Copied from LayoutTests/platform/chromium-win/tables/mozilla/bugs/bug106795-expected.png.
  • platform/chromium-linux/tables/mozilla/bugs/bug11026-expected.png: Added.
  • platform/chromium-linux/tables/mozilla/bugs/bug1296-expected.png: Added.
  • platform/chromium-linux/tables/mozilla/bugs/bug131020-2-expected.png: Copied from LayoutTests/platform/chromium-win/tables/mozilla/bugs/bug131020-2-expected.png.
  • platform/chromium-linux/tables/mozilla/bugs/bug13169-expected.png: Copied from LayoutTests/platform/chromium-win/tables/mozilla/bugs/bug13169-expected.png.
  • platform/chromium-linux/tables/mozilla/bugs/bug133948-expected.png: Copied from LayoutTests/platform/chromium-win/tables/mozilla/bugs/bug133948-expected.png.
  • platform/chromium-linux/tables/mozilla/bugs/bug15544-expected.png: Added.
  • platform/chromium-linux/tables/mozilla/bugs/bug1818-1-expected.png: Copied from LayoutTests/platform/chromium-win/tables/mozilla/bugs/bug1818-1-expected.png.
  • platform/chromium-linux/tables/mozilla/bugs/bug1818-2-expected.png: Copied from LayoutTests/platform/chromium-win/tables/mozilla/bugs/bug1818-2-expected.png.
  • platform/chromium-linux/tables/mozilla/bugs/bug1818-3-expected.png: Copied from LayoutTests/platform/chromium-win/tables/mozilla/bugs/bug1818-3-expected.png.
  • platform/chromium-linux/tables/mozilla/bugs/bug1818-4-expected.png: Copied from LayoutTests/platform/chromium-win/tables/mozilla/bugs/bug1818-4-expected.png.
  • platform/chromium-linux/tables/mozilla/bugs/bug219693-1-expected.png: Copied from LayoutTests/platform/chromium-win/tables/mozilla/bugs/bug219693-1-expected.png.
  • platform/chromium-linux/tables/mozilla/bugs/bug219693-2-expected.png: Copied from LayoutTests/platform/chromium-win/tables/mozilla/bugs/bug219693-2-expected.png.
  • platform/chromium-linux/tables/mozilla/bugs/bug26553-expected.png: Copied from LayoutTests/platform/chromium-win/tables/mozilla/bugs/bug26553-expected.png.
  • platform/chromium-linux/tables/mozilla/bugs/bug32447-expected.png: Added.
  • platform/chromium-linux/tables/mozilla/bugs/bug34538-expected.png: Added.
  • platform/chromium-linux/tables/mozilla/bugs/bug56201-expected.png: Copied from LayoutTests/platform/chromium-win/tables/mozilla/bugs/bug56201-expected.png.
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug23847-expected.png: Copied from LayoutTests/platform/chromium-win/tables/mozilla_expected_failures/bugs/bug23847-expected.png.
17:45 Changeset [67042] by andersca@apple.com

Don't include the std namespace in a header. This hopefully fixes the Windows build.

  • Shared/WebCoreArgumentCoders.h:
17:18 Changeset [67041] by abarth@webkit.org

2010-09-08 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

text/plain documents that start with \n trigger ASSERT
https://bugs.webkit.org/show_bug.cgi?id=45409

Because the TextDocumentParser uses a <pre> element to show the text,
it ran into a requirement from HTML5 to skip any initial \n character
tokens inside a <pre> element. We don't want the behavior for
TextDocuments, so I've loosened our ASSERTs and added a comment and a
test to document the correct behavior.

Test: fast/tokenizer/text-plain.html

  • html/parser/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::nextToken):

2010-09-08 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

text/plain documents that start with \n trigger ASSERT
https://bugs.webkit.org/show_bug.cgi?id=45409

  • fast/tokenizer/resources/text.txt: Added.
  • fast/tokenizer/text-plain.html: Added.
17:14 QtWebKitWebGL edited by andreas.kling@nokia.com
(diff)
17:03 Changeset [67040] by yurys@chromium.org

2010-09-08 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Joseph Pecoraro.

Web Inspector: test that debugger won't pause on syntax errors
https://bugs.webkit.org/show_bug.cgi?id=45388

  • inspector/debugger-autocontinue-on-syntax-error-expected.txt: Added.
  • inspector/debugger-autocontinue-on-syntax-error.html: Added.

2010-09-08 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Joseph Pecoraro.

Web Inspector: test that debugger won't pause on syntax errors
https://bugs.webkit.org/show_bug.cgi?id=45388

  • src/js/Tests.js: removed testAutoContinueOnSyntaxError which is now covered by inspector/debugger-autocontinue-on-syntax-error.html layout test
16:54 Changeset [67039] by jamesr@google.com

2010-09-08 James Robinson <jamesr@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Always do 2d canvas clearRect() in hardware
https://bugs.webkit.org/show_bug.cgi?id=45415

r67003 forced Canvas 2d's clearRect() to happen in software if a gradient/shadow/etc was
active. This is subtly wrong for mixed mode rendering since it results in only the
software backing store being cleared and not the hardware. This forces clearRect() to
happen in hardware. Since we upload mixed mode results before doing any hardware draw
this means we always clear everything.

  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::clearRect):
16:52 Changeset [67038] by bweinstein@apple.com

Updated expected results for computed-style and prototype-inheritance tests on Windows.

Rubber-stamped by Steve Falkenburg.

  • platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/win/fast/dom/prototype-inheritance-2-expected.txt:
16:37 Changeset [67037] by andersca@apple.com

Suggested and reviewed by Darin Adler.

Fix an overflow bug in bufferIsLargeEnoughToContain.

  • Platform/CoreIPC/ArgumentDecoder.h:

(CoreIPC::ArgumentDecoder::bufferIsLargeEnoughToContain):

16:37 Changeset [67036] by dino@apple.com

2010-09-08 Dean Jackson <dino@apple.com>

Unreviewed attempt to fix the Mac builds.

  • css/CSSParser.cpp: (WebCore::CSSParser::parseAnimationTimingFunction):
16:28 Changeset [67035] by dino@apple.com

2010-09-08 Dean Jackson <dino@apple.com>

Unreviewed attempt to fix QT build.

  • platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::solveStepsFunction): (WebCore::applyTimingFunction):
16:26 Changeset [67034] by andersca@apple.com

Improve CoreIPC encoding of strings
https://bugs.webkit.org/show_bug.cgi?id=45418

Reviewed by Darin Adler.

Encode and decode null Strings. Check that the string length isn't bogus.

  • Platform/CoreIPC/ArgumentCoders.h:
  • Platform/CoreIPC/ArgumentDecoder.cpp:

(CoreIPC::ArgumentDecoder::bufferIsLargeEnoughToContain):

  • Platform/CoreIPC/ArgumentDecoder.h:

(CoreIPC::ArgumentDecoder::bufferIsLargeEnoughToContain):

  • Shared/WebCoreArgumentCoders.h:
16:20 Changeset [67033] by dglazkov@chromium.org

http/tests/navigation/anchor-frames.html should not be diffing images
https://bugs.webkit.org/show_bug.cgi?id=45307

Patch by Mihai Parparita <mihaip@chromium.org> on 2010-09-08
Reviewed by Dimitri Glazkov.

anchor-frames.html is a pretty straightforward test that makes sure that we
scroll to named anchors when they're used as frame sources. There's no need
for it to be a pixel test with per-platform expectations (which are currently
missing for Chromium Mac in any case).

  • http/tests/navigation/anchor-frames-expected.txt: Added.
  • http/tests/navigation/anchor-frames.html:
  • http/tests/navigation/resources/frame-with-anchor.html: Added.
  • platform/chromium-linux/http/tests/navigation/anchor-frames-expected.checksum: Removed.
  • platform/chromium-linux/http/tests/navigation/anchor-frames-expected.png: Removed.
  • platform/chromium-linux/http/tests/navigation/anchor-frames-expected.txt: Removed.
  • platform/chromium-win/http/tests/navigation/anchor-frames-expected.checksum: Removed.
  • platform/chromium-win/http/tests/navigation/anchor-frames-expected.png: Removed.
  • platform/chromium-win/http/tests/navigation/anchor-frames-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
  • platform/mac/http/tests/navigation/anchor-frames-expected.checksum: Removed.
  • platform/mac/http/tests/navigation/anchor-frames-expected.png: Removed.
  • platform/mac/http/tests/navigation/anchor-frames-expected.txt: Removed.
16:06 Changeset [67032] by dino@apple.com

2010-09-08 Dean Jackson <dino@apple.com>

Reviewed by Simon Fraser.

Implement steps() timing function for animations
https://bugs.webkit.org/show_bug.cgi?id=44541

Tests: animations/timing-functions.html

transitions/steps-timing-function.html

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::getTimingFunctionValue):
    • when creating computed style we now test what type of timing function it being used
  • css/CSSParser.cpp: (WebCore::CSSParser::parseCubicBezierTimingFunctionValue):
    • rename this method from parseTimingFunctionValue

(WebCore::CSSParser::parseAnimationTimingFunction):

  • support parsing the steps() function
  • css/CSSParser.h:
    • method rename
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::mapAnimationTimingFunction):
    • handle 'step-start' and 'step-end' identifiers. Also now use ::create when constructing objects
  • css/CSSTimingFunctionValue.cpp: (WebCore::CSSLinearTimingFunctionValue::cssText): (WebCore::CSSCubicBezierTimingFunctionValue::cssText): (WebCore::CSSStepsTimingFunctionValue::cssText):
    • new text output for computed style. We now produce the text 'linear' when appropriate.
  • css/CSSTimingFunctionValue.h: (WebCore::CSSTimingFunctionValue::isLinearTimingFunctionValue): (WebCore::CSSTimingFunctionValue::isCubicBezierTimingFunctionValue): (WebCore::CSSTimingFunctionValue::isStepsTimingFunctionValue): (WebCore::CSSTimingFunctionValue::CSSTimingFunctionValue): (WebCore::CSSTimingFunctionValue::isTimingFunctionValue): (WebCore::CSSLinearTimingFunctionValue::create): (WebCore::CSSLinearTimingFunctionValue::isLinearTimingFunctionValue): (WebCore::CSSLinearTimingFunctionValue::CSSLinearTimingFunctionValue): (WebCore::CSSCubicBezierTimingFunctionValue::create): (WebCore::CSSCubicBezierTimingFunctionValue::isCubicBezierTimingFunctionValue): (WebCore::CSSCubicBezierTimingFunctionValue::CSSCubicBezierTimingFunctionValue): (WebCore::CSSStepsTimingFunctionValue::create): (WebCore::CSSStepsTimingFunctionValue::numberOfSteps): (WebCore::CSSStepsTimingFunctionValue::stepAtStart): (WebCore::CSSStepsTimingFunctionValue::isStepsTimingFunctionValue): (WebCore::CSSStepsTimingFunctionValue::CSSStepsTimingFunctionValue):
    • CSSTimingFunction is now a pure virtual ref-counted base class, with subclasses for each of the three supported timing functions.
  • css/CSSValueKeywords.in:
    • new keywords step-start and step-end
  • page/animation/AnimationBase.cpp: (WebCore::solveStepsFunction):
    • produces the output value from a stepping function

(WebCore::AnimationBase::progress):

  • now has to switch based on timing function type
  • page/animation/KeyframeAnimation.cpp: (WebCore::KeyframeAnimation::fetchIntervalEndpointsForProperty):
    • use ref-counted access
  • platform/animation/Animation.cpp: (WebCore::Animation::animationsMatch):
    • change timing function comparison for operator==
  • platform/animation/Animation.h: (WebCore::Animation::timingFunction): (WebCore::Animation::setTimingFunction): (WebCore::Animation::initialAnimationTimingFunction):
    • move to ref-counted timing function class
  • platform/animation/TimingFunction.h: (WebCore::TimingFunction::~TimingFunction): (WebCore::TimingFunction::isLinearTimingFunction): (WebCore::TimingFunction::isCubicBezierTimingFunction): (WebCore::TimingFunction::isStepsTimingFunction): (WebCore::TimingFunction::TimingFunction): (WebCore::LinearTimingFunction::create): (WebCore::LinearTimingFunction::~LinearTimingFunction): (WebCore::LinearTimingFunction::operator==): (WebCore::LinearTimingFunction::LinearTimingFunction): (WebCore::CubicBezierTimingFunction::create): (WebCore::CubicBezierTimingFunction::~CubicBezierTimingFunction): (WebCore::CubicBezierTimingFunction::operator==): (WebCore::CubicBezierTimingFunction::CubicBezierTimingFunction): (WebCore::StepsTimingFunction::create): (WebCore::StepsTimingFunction::~StepsTimingFunction): (WebCore::StepsTimingFunction::operator==): (WebCore::StepsTimingFunction::numberOfSteps): (WebCore::StepsTimingFunction::stepAtStart): (WebCore::StepsTimingFunction::StepsTimingFunction):
    • TimingFunction is now a ref-counted pure virtual base class, with three subclasses representing the types of timing functions that are supported.
  • platform/graphics/GraphicsLayer.h: (WebCore::AnimationValue::AnimationValue): (WebCore::FloatAnimationValue::FloatAnimationValue): (WebCore::TransformAnimationValue::TransformAnimationValue):
    • use PassRefPtr in function parameters
  • platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::solveStepsFunction): (WebCore::applyTimingFunction): (WebCore::AnimationQt::AnimationQt): (WebCore::AnimationQt::updateCurrentTime):
    • implement the timing function switch for QT
  • platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::getCAMediaTimingFunction):
    • update for new timing function interface

(WebCore::animationHasStepsTimingFunction):

  • new method to make sure animations with steps() functions never try to execute in Core Animation

(WebCore::GraphicsLayerCA::addAnimation):

  • test for steps() timing function

(WebCore::GraphicsLayerCA::timingFunctionForAnimationValue):

  • rendering/style/RenderStyleConstants.h:
    • remove old RenderStyle enum for timing function types
16:01 Changeset [67031] by ossy@webkit.org

Unreviewed trivial fix after r66960.

  • WebCore.pro: loader/TextDocument.h renamed to html/TextDocument.h
15:46 Changeset [67030] by abarth@webkit.org

2010-09-08 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

move-during-parse-parent.html crashes
https://bugs.webkit.org/show_bug.cgi?id=45210

When inserting elements into the tree, they need to be associated with
their parent's document, not the document for which the parser is
running. These two are different when the parent has been moved to a
different document during parsing.

Test: fast/parser/move-during-parsing.html

  • html/parser/HTMLConstructionSite.cpp: (WebCore::HTMLConstructionSite::insertComment): (WebCore::HTMLConstructionSite::insertCommentOnHTMLHtmlElement): (WebCore::HTMLConstructionSite::insertScriptElement): (WebCore::HTMLConstructionSite::insertTextNode): (WebCore::HTMLConstructionSite::createElement): (WebCore::HTMLConstructionSite::createHTMLElement):

2010-09-08 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

move-during-parse-parent.html crashes
https://bugs.webkit.org/show_bug.cgi?id=45210

  • fast/parser/move-during-parsing-expected.txt: Added.
  • fast/parser/move-during-parsing.html: Added.
  • fast/parser/resources/move-during-parsing-iframe.html: Added.
15:44 Changeset [67029] by mjs@apple.com

Add newly failing test to skipped list.

Rubber stamped by John Honeycutt.

  • platform/mac-wk2/Skipped:
15:43 Changeset [67028] by loki@webkit.org

2010-09-08 Gabor Loki <loki@webkit.org>

Reviewed by Andreas Kling.

Fix increases required alignment of target type warning on ARM
https://bugs.webkit.org/show_bug.cgi?id=45301

No new tests needed.

  • bindings/js/SerializedScriptValue.cpp: (WebCore::CloneDeserializer::readLittleEndian): (WebCore::CloneDeserializer::readString):
  • plugins/PluginDatabase.cpp: (WebCore::readTime):
15:37 Changeset [67027] by crogers@google.com

audio branch: sync with trunk version of WebCore/html/canvas/TypedArrayBase.h

15:30 Changeset [67026] by ossy@webkit.org

LayoutTest regressions due to http://trac.webkit.org/changeset/67001
https://bugs.webkit.org/show_bug.cgi?id=45411

  • platform/qt/Skipped: Skip some flakey tests to make buildbot green.
15:16 Changeset [67025] by tonikitoo@webkit.org

Make FocusController::focusedOrMainFrame method const
https://bugs.webkit.org/show_bug.cgi?id=45406

Reviewed by Daniel Bates.
Patch by Antonio Gomes <agomes@rim.com>

No new tests once it is not a behavior change.

  • page/FocusController.cpp:

(WebCore::FocusController::focusedOrMainFrame):

  • page/FocusController.h:
15:15 Changeset [67024] by victorw@chromium.org

2010-09-08 Victor Wang <victorw@chromium.org>

Reviewed by Ojan Vafai.

[Chromium] Fix test results server to make sure
it does not have corrupted data.

results.json file size coulbe be >1M and we split
the data into multiple data store entries in this
case. This patch fixes the issue that the data may
be corrupted if data store error happens in the middle
of saving multiple entries.

https://bugs.webkit.org/show_bug.cgi?id=45063

  • TestResultServer/model/datastorefile.py:
15:10 Changeset [67023] by pkasting@chromium.org

Not reviewed, build fix.

  • WebScrollBar.cpp:

(WebScrollBar::setScrollOffsetFromAnimation):
Merge 67022 - Not reviewed, build fix.

  • WebScrollBar.cpp:

(WebScrollBar::setScrollOffsetFromAnimation):

TBR=pkasting@chromium.org
Review URL: http://codereview.chromium.org/3309012

15:10 Changeset [67022] by pkasting@chromium.org

Not reviewed, build fix.

  • WebScrollBar.cpp:

(WebScrollBar::setScrollOffsetFromAnimation):

15:07 Changeset [67021] by pkasting@chromium.org

Not reviewed, build fix.

  • WebScrollBar.cpp:

(WebScrollBar::scrollSize):
(WebScrollBar::setScrollOffsetFromAnimation):
Merge 67020 - Not reviewed, build fix.

  • WebScrollBar.cpp:

(WebScrollBar::scrollSize):
(WebScrollBar::setScrollOffsetFromAnimation):

TBR=pkasting@chromium.org
Review URL: http://codereview.chromium.org/3332014

15:05 Changeset [67020] by pkasting@chromium.org

Not reviewed, build fix.

  • WebScrollBar.cpp:

(WebScrollBar::scrollSize):
(WebScrollBar::setScrollOffsetFromAnimation):

14:51 Changeset [67019] by pkasting@chromium.org

Merge 67018 - Not reviewed, build fix.

  • WebScrollBar.cpp:

(WebScrollBar::setValue):
(WebScrollBar::scrollSize):
(WebScrollBar::setScrollOffsetFromAnimation):

  • WebScrollBar.h:

TBR=pkasting@chromium.org
Review URL: http://codereview.chromium.org/3357018

14:49 Changeset [67018] by pkasting@chromium.org

Not reviewed, build fix.

  • WebScrollBar.cpp:

(WebScrollBar::setValue):
(WebScrollBar::scrollSize):
(WebScrollBar::setScrollOffsetFromAnimation):

  • WebScrollBar.h:
14:40 Changeset [67017] by jianli@chromium.org

Fix a problem in createCanonicalUUIDString that causes the last digit
missing on Linux.
https://bugs.webkit.org/show_bug.cgi?id=45412

Reviewed by Darin Adler.

WebCore:

This is caused by not including the final null character into the count
that is provided to fgets.

This is covered by the existing test: send-form-data-with-sliced-file.html.

  • platform/UUID.cpp:

(WebCore::createCanonicalUUIDString):

LayoutTests:

Remove the test that is now passing on Linux for chromium.

  • platform/chromium/test_expectations.txt:
14:27 Changeset [67016] by aroben@apple.com

Add a way to cause the web process to crash at a random time

Setting the WEBKIT2_CRASH_WEB_PROCESS_RANDOMLY environment variable
will cause the web process to crash at a random point up to 3 minutes
after launching.

Fixes <http://webkit.org/b/43058> <rdar://problem/8240150>

Reviewed by Darin Adler.

  • WebProcess/WebProcess.cpp:

(WebKit::sleep): Added an implementation of this function for Windows.
It just calls through to ::Sleep.
(WebKit::randomCrashThread): Added. Sleeps for a random amount of time
up to 3 minutes, then crashes.
(WebKit::startRandomCrashThreadIfRequested): Added. Starts the crash
thread if the WEBKIT2_CRASH_WEB_PROCESS_RANDOMLY environment variable
is set.
(WebKit::WebProcess::initialize): Added a call to
startRandomCrashThreadIfRequested.

14:25 Changeset [67015] by thakis@chromium.org

2010-09-08 Nico Weber <thakis@chromium.org>

Reviewed by Dimitri Glazkov.

chromium/mac: Fix overrelease in ImageLayerChromium
https://bugs.webkit.org/show_bug.cgi?id=45360

Only release colorSpace if we created it.

  • platform/graphics/chromium/ImageLayerChromium.cpp: (WebCore::ImageLayerChromium::updateContents):
14:17 Changeset [67014] by aroben@apple.com

Fix potential ref-counting issues with WorkItemWin

Reviewed by Anders Carlsson.

  • Platform/WorkQueue.h: Changed WorkItemWin to inherit from

ThreadSafeShared instead of RefCounted so that its ref-count will stay
consistent when used on multiple threads.

14:16 Changeset [67013] by aroben@apple.com

Teach WorkQueue how to stop waiting on objects on Windows

WorkQueue now uses a subclass of WorkItemWin, HandleWorkItem, to hold
the waited-upon HANDLE and its corresponding wait handle. When a
HANDLE is unregistered, we use the HandleWorkItem to cancel the wait
and destroy the HANDLE.

Fixes <http://webkit.org/b/42826> <rdar://problem/8222253> Crash in
thread pool because WorkQueue keeps waiting on closed HANDLEs

Reviewed by Anders Carlsson.

  • Platform/CoreIPC/win/ConnectionWin.cpp:

(CoreIPC::Connection::platformInvalidate): Changed to call
WorkQueue::unregisterAndCloseHandle instead of closing our handles
manually.

(CoreIPC::Connection::readEventHandler):
(CoreIPC::Connection::writeEventHandler):
Handle cases where the pipe has already closed by just bailing out.
This can happen if a WorkItem to call one of these functions has
already been scheduled before platformInvalidate is called.

  • Platform/WorkQueue.h: Gave WorkItemWin a virtual destructor, added

HandleWorkItem, changed m_handles to hold HandleWorkItems, and added
functions for unregistering waits.

  • Platform/win/WorkQueueWin.cpp:

(WorkQueue::WorkItemWin::~WorkItemWin): Added. This virtual destructor
ensures that HandleWorkItem's destructor gets called.

(WorkQueue::HandleWorkItem::HandleWorkItem):
(WorkQueue::HandleWorkItem::createByAdoptingHandle):
Added simple constructor/creator.

(WorkQueue::HandleWorkItem::~HandleWorkItem): Closes the handle we
adopted.
(WorkQueue::registerHandle): Changed to create a HandleWorkItemWin and
to store the wait handle in it.
(WorkQueue::unregisterAndCloseHandle): Added. Removes the
HandleWorkItem for this HANDLE from m_handles and then schedules its
wait to be unregistered and the item to be destroyed.
(WorkQueue::platformInvalidate): Added an assertion and removed an
obsolete FIXME.
(WorkQueue::unregisterWaitAndDestroyItemSoon): Added. Calls
unregisterWaitAndDestroyItemCallback on a worker thread, passing it
ownership of the HandleWorkItem.
(WorkQueue::unregisterWaitAndDestroyItemCallback): Added. Adopts the
passed-in HandleWorkItem, then unregisters the handle's wait, then
destroys the HandleWorkItem when the RefPtr holding it goes out of
scope. Destroying the HandleWorkItem closes the handle.

13:57 Changeset [67012] by robert@webkit.org

2010-09-08 Robert Hogan <robert@webkit.org>

Reviewed by Antonio Gomes.

Remove some unnecessary duplicate calls to string functions

https://bugs.webkit.org/show_bug.cgi?id=45314

  • wtf/text/WTFString.cpp: (WTF::String::format):

2010-09-08 Robert Hogan <robert@webkit.org>

Reviewed by Antonio Gomes.

Remove some unnecessary duplicate calls to string functions

https://bugs.webkit.org/show_bug.cgi?id=45314

  • platform/network/curl/ResourceHandleManager.cpp: (WebCore::parseDataUrl):
  • websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::send):
13:51 Changeset [67011] by demarchi@webkit.org

2010-09-08 Ryuan Choi <ryuan.choi@samsung.com>

Unreviewed build fix.

[EFL] Need to add custom dependencies.
https://bugs.webkit.org/show_bug.cgi?id=45247

Add WebKit_Theme into WebKit_SOURCES to make it while building.

  • CMakeListsEfl.txt:
13:37 Changeset [67010] by pkasting@chromium.org

Merge 67009 - WebCore: Not reviewed, fallout from http://trac.webkit.org/changeset/67001

Fix compile failures and add svn:eol-style on two new files.

  • platform/ScrollAnimator.h: Added property svn:eol-style.
  • platform/ScrollAnimatorWin.cpp: Added property svn:eol-style.
  • platform/win/PopupMenuWin.cpp: Fix compile errors.

(WebCore::PopupMenuWin::scrollToRevealSelection):
(WebCore::PopupMenuWin::scrollSize):

LayoutTests: Not reviewed, skip failing layout tests.

https://bugs.webkit.org/show_bug.cgi?id=45411

  • platform/qt/Skipped:

TBR=pkasting@chromium.org
Review URL: http://codereview.chromium.org/3334011

13:33 Changeset [67009] by pkasting@chromium.org

WebCore: Not reviewed, fallout from http://trac.webkit.org/changeset/67001

Fix compile failures and add svn:eol-style on two new files.

  • platform/ScrollAnimator.h: Added property svn:eol-style.
  • platform/ScrollAnimatorWin.cpp: Added property svn:eol-style.
  • platform/win/PopupMenuWin.cpp: Fix compile errors.

(WebCore::PopupMenuWin::scrollToRevealSelection):
(WebCore::PopupMenuWin::scrollSize):

LayoutTests: Not reviewed, skip failing layout tests.

https://bugs.webkit.org/show_bug.cgi?id=45411

  • platform/qt/Skipped:
13:32 Changeset [67008] by pkasting@chromium.org

Merge 67001 - 2010-09-08 Peter Kasting <pkasting@google.com>

Reviewed by David Hyatt.

Add smooth scrolling framework, and a Windows implementation.
https://bugs.webkit.org/show_bug.cgi?id=32356

  • wscript: Add Windows ScrollAnimator.

2010-09-08 Peter Kasting <pkasting@google.com>

Reviewed by David Hyatt.

Add smooth scrolling framework, and a Windows implementation.
https://bugs.webkit.org/show_bug.cgi?id=32356

  • CMakeLists.txt: Add ScrollAnimator.
  • GNUmakefile.am: Add ScrollAnimator.
  • WebCore.gyp/WebCore.gyp: Add Windows ScrollAnimator.
  • WebCore.gypi: Add ScrollAnimator.
  • WebCore.pro: Add ScrollAnimator.
  • WebCore.vcproj/WebCore.vcproj: Add ScrollAnimator.
  • WebCore.xcodeproj/project.pbxproj: Add ScrollAnimator.
  • platform/ScrollAnimator.cpp: Added base implementation that does no animation. (WebCore::ScrollAnimator::create): (WebCore::ScrollAnimator::scroll): (WebCore::ScrollAnimator::setScrollPositionAndStopAnimation):
  • platform/ScrollAnimator.h: Added base implementation that does no animation. (WebCore::ScrollAnimator::ScrollAnimator): (WebCore::ScrollAnimator::~ScrollAnimator):
  • platform/ScrollAnimatorWin.cpp: Added Windows subclass that animates scrolls. (WebCore::ScrollAnimator::create): (WebCore::ScrollAnimatorWin::PerAxisData::PerAxisData): (WebCore::ScrollAnimatorWin::ScrollAnimatorWin): (WebCore::ScrollAnimatorWin::~ScrollAnimatorWin): (WebCore::ScrollAnimatorWin::scroll): (WebCore::ScrollAnimatorWin::setScrollPositionAndStopAnimation): (WebCore::ScrollAnimatorWin::accelerationTime): (WebCore::ScrollAnimatorWin::animationTimerFired): (WebCore::ScrollAnimatorWin::stopAnimationTimerIfNeeded): (WebCore::ScrollAnimatorWin::animateScroll):
  • platform/ScrollAnimatorWin.h: Added Windows subclass that animates scrolls.
  • platform/ScrollView.cpp: Implement new ScrollbarClient functions. Allow wheel scrolls to be animated. (WebCore::ScrollView::scrollSize): (WebCore::ScrollView::setScrollOffsetFromAnimation): (WebCore::ScrollView::updateScrollbars): (WebCore::ScrollView::wheelEvent):
  • platform/ScrollView.h: Implement new ScrollbarClient functions.
  • platform/Scrollbar.cpp: Allow ScrollAnimator to handle scrolls if present. (WebCore::Scrollbar::setValue): (WebCore::Scrollbar::scroll): (WebCore::Scrollbar::moveThumb): (WebCore::Scrollbar::setCurrentPos): (WebCore::Scrollbar::mouseMoved):
  • platform/Scrollbar.h:
  • platform/ScrollbarClient.cpp: Added to avoid having to make ScrollAnimator.h non-private. (WebCore::ScrollbarClient::ScrollbarClient): (WebCore::ScrollbarClient::~ScrollbarClient): (WebCore::ScrollbarClient::scroll): (WebCore::ScrollbarClient::setScrollPositionAndStopAnimation):
  • platform/ScrollbarClient.h: Add hooks for ScrollAnimator. (WebCore::ScrollbarClient::convertFromScrollbarToContainingView): (WebCore::ScrollbarClient::convertFromContainingViewToScrollbar):
  • platform/gtk/MainFrameScrollbarGtk.cpp: (MainFrameScrollbarGtk::gtkValueChanged):
  • platform/qt/ScrollbarQt.cpp: Use scroll() in preference to setValue(). (WebCore::Scrollbar::contextMenu):
  • platform/win/PopupMenuWin.cpp: Implement new ScrollbarClient functions. (WebCore::PopupMenuWin::scrollSize): (WebCore::PopupMenuWin::setScrollOffsetFromAnimation):
  • platform/win/PopupMenuWin.h: Implement new ScrollbarClient functions.
  • rendering/RenderDataGrid.cpp: Implement new ScrollbarClient functions. (WebCore::RenderDataGrid::scrollSize): (WebCore::RenderDataGrid::setScrollOffsetFromAnimation):
  • rendering/RenderDataGrid.h: Implement new ScrollbarClient functions.
  • rendering/RenderLayer.cpp: Implement new ScrollbarClient functions. (WebCore::RenderLayer::scrollToOffset): (WebCore::RenderLayer::scrollSize): (WebCore::RenderLayer::setScrollOffsetFromAnimation): (WebCore::RenderLayer::updateScrollInfoAfterLayout):
  • rendering/RenderLayer.h: Implement new ScrollbarClient functions.
  • rendering/RenderListBox.cpp: Implement new ScrollbarClient functions. (WebCore::RenderListBox::scrollToRevealElementAtListIndex): (WebCore::RenderListBox::scrollSize): (WebCore::RenderListBox::setScrollOffsetFromAnimation): (WebCore::RenderListBox::setScrollTop):
  • rendering/RenderListBox.h: Implement new ScrollbarClient functions.

2010-09-08 Peter Kasting <pkasting@google.com>

Reviewed by David Hyatt.

Add smooth scrolling framework, and a Windows implementation.
https://bugs.webkit.org/show_bug.cgi?id=32356

  • src/WebScrollbarImpl.cpp: Plumb new ScrollbarClient functions. Allow wheel scrolls to be animated. (WebKit::WebScrollbarImpl::setLocation): (WebKit::WebScrollbarImpl::setValue): (WebKit::WebScrollbarImpl::scroll): (WebKit::WebScrollbarImpl::onMouseWheel): (WebKit::WebScrollbarImpl::onKeyDown): (WebKit::WebScrollbarImpl::setScrollOffsetFromAnimation):
  • src/WebScrollbarImpl.h: Plumb new ScrollbarClient functions.
  • src/win/WebInputEventFactory.cpp: Update comments now that we have smooth scrolling. (WebKit::WebInputEventFactory::mouseWheelEvent):

2010-09-08 Peter Kasting <pkasting@google.com>

Reviewed by David Hyatt.

Add smooth scrolling framework, and a Windows implementation.
https://bugs.webkit.org/show_bug.cgi?id=32356

  • Api/qwebframe.cpp: (QWebFrame::setScrollBarValue):

TBR=commit-queue@webkit.org
Review URL: http://codereview.chromium.org/3364013

13:24 Changeset [67007] by mrobinson@webkit.org

2010-09-08 Martin Robinson <mrobinson@igalia.com>

Skip websocket tests until the GLib/GIO situation on the
Debug bots can be sorted out.

  • platform/gtk/Skipped: Skip websocket tests.
13:18 Changeset [67006] by mjs@apple.com

2010-09-08 Maciej Stachowiak <mjs@apple.com>

Reviewed by Anders Carlsson.

Add some entries to the WebKit2 skipped list, based on the buildbot
https://bugs.webkit.org/show_bug.cgi?id=45380

  • platform/mac-wk2/Skipped:
13:14 Changeset [67005] by aroben@apple.com

Remove WKSerializedScriptValue.cpp/h from the Copy Files build phase

  • WebKit2.xcodeproj/project.pbxproj:
12:56 Changeset [67004] by tonikitoo@webkit.org

2010-09-08 Antonio Gomes <agomes@rim.com>

Unreviewed: adding my new commit email to committers.py

  • Scripts/webkitpy/common/config/committers.py:
12:38 Changeset [67003] by jamesr@google.com

2010-09-08 James Robinson <jamesr@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Force canvas 2d draw calls to happen in software if a gradient, pattern, shadow, or clip are active
https://bugs.webkit.org/show_bug.cgi?id=45405

This forces all draw calls to happen in software instead of hardware if there is a fill pattern, gradient,
shadow, or clip applied; at least until we can handle these in hardware. Otherwise the pattern/gradient/etc
is completely ignored by the hardware drawing routine and we render incorrectly.

The test is slightly convervative - for example it will force drawImage() calls to happen in software if a
fill gradient is set even though it's irrelevant. This doesn't seem to be an issue in practice and we
can tighten the checks later if needed.

Tested by fast/canvas/canvas-incremental-repaint.html.

  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::canvasClip): (WebCore::GraphicsContext::fillRect):
  • platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::ImageBuffer::draw):
  • platform/graphics/skia/ImageSkia.cpp: (WebCore::BitmapImage::draw): (WebCore::BitmapImageSingleFrameSkia::draw):
  • platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::State::State): (WebCore::PlatformContextSkia::canvasClipPath): (WebCore::PlatformContextSkia::canAccelerate):
  • platform/graphics/skia/PlatformContextSkia.h:
12:38 Changeset [67002] by demarchi@webkit.org

2010-09-08 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Export data directory through pkg-config
https://bugs.webkit.org/show_bug.cgi?id=45385

Using pkg-config it's possible for a browser to know the location of
installed themes. When compiling the browser, a variable might be
defined with the datadir, like below:

gcc -o browser browser.c $(pkg-config --libs --cflags ewebkit) \

-DEWEBKIT_DATA_DIR=$(pkg-config --variable=datadir)

  • ewebkit.pc.in: Export datadir variable.
12:31 Changeset [67001] by commit-queue@webkit.org

2010-09-08 Peter Kasting <pkasting@google.com>

Reviewed by David Hyatt.

Add smooth scrolling framework, and a Windows implementation.
https://bugs.webkit.org/show_bug.cgi?id=32356

  • wscript: Add Windows ScrollAnimator.

2010-09-08 Peter Kasting <pkasting@google.com>

Reviewed by David Hyatt.

Add smooth scrolling framework, and a Windows implementation.
https://bugs.webkit.org/show_bug.cgi?id=32356

  • CMakeLists.txt: Add ScrollAnimator.
  • GNUmakefile.am: Add ScrollAnimator.
  • WebCore.gyp/WebCore.gyp: Add Windows ScrollAnimator.
  • WebCore.gypi: Add ScrollAnimator.
  • WebCore.pro: Add ScrollAnimator.
  • WebCore.vcproj/WebCore.vcproj: Add ScrollAnimator.
  • WebCore.xcodeproj/project.pbxproj: Add ScrollAnimator.
  • platform/ScrollAnimator.cpp: Added base implementation that does no animation. (WebCore::ScrollAnimator::create): (WebCore::ScrollAnimator::scroll): (WebCore::ScrollAnimator::setScrollPositionAndStopAnimation):
  • platform/ScrollAnimator.h: Added base implementation that does no animation. (WebCore::ScrollAnimator::ScrollAnimator): (WebCore::ScrollAnimator::~ScrollAnimator):
  • platform/ScrollAnimatorWin.cpp: Added Windows subclass that animates scrolls. (WebCore::ScrollAnimator::create): (WebCore::ScrollAnimatorWin::PerAxisData::PerAxisData): (WebCore::ScrollAnimatorWin::ScrollAnimatorWin): (WebCore::ScrollAnimatorWin::~ScrollAnimatorWin): (WebCore::ScrollAnimatorWin::scroll): (WebCore::ScrollAnimatorWin::setScrollPositionAndStopAnimation): (WebCore::ScrollAnimatorWin::accelerationTime): (WebCore::ScrollAnimatorWin::animationTimerFired): (WebCore::ScrollAnimatorWin::stopAnimationTimerIfNeeded): (WebCore::ScrollAnimatorWin::animateScroll):
  • platform/ScrollAnimatorWin.h: Added Windows subclass that animates scrolls.
  • platform/ScrollView.cpp: Implement new ScrollbarClient functions. Allow wheel scrolls to be animated. (WebCore::ScrollView::scrollSize): (WebCore::ScrollView::setScrollOffsetFromAnimation): (WebCore::ScrollView::updateScrollbars): (WebCore::ScrollView::wheelEvent):
  • platform/ScrollView.h: Implement new ScrollbarClient functions.
  • platform/Scrollbar.cpp: Allow ScrollAnimator to handle scrolls if present. (WebCore::Scrollbar::setValue): (WebCore::Scrollbar::scroll): (WebCore::Scrollbar::moveThumb): (WebCore::Scrollbar::setCurrentPos): (WebCore::Scrollbar::mouseMoved):
  • platform/Scrollbar.h:
  • platform/ScrollbarClient.cpp: Added to avoid having to make ScrollAnimator.h non-private. (WebCore::ScrollbarClient::ScrollbarClient): (WebCore::ScrollbarClient::~ScrollbarClient): (WebCore::ScrollbarClient::scroll): (WebCore::ScrollbarClient::setScrollPositionAndStopAnimation):
  • platform/ScrollbarClient.h: Add hooks for ScrollAnimator. (WebCore::ScrollbarClient::convertFromScrollbarToContainingView): (WebCore::ScrollbarClient::convertFromContainingViewToScrollbar):
  • platform/gtk/MainFrameScrollbarGtk.cpp: (MainFrameScrollbarGtk::gtkValueChanged):
  • platform/qt/ScrollbarQt.cpp: Use scroll() in preference to setValue(). (WebCore::Scrollbar::contextMenu):
  • platform/win/PopupMenuWin.cpp: Implement new ScrollbarClient functions. (WebCore::PopupMenuWin::scrollSize): (WebCore::PopupMenuWin::setScrollOffsetFromAnimation):
  • platform/win/PopupMenuWin.h: Implement new ScrollbarClient functions.
  • rendering/RenderDataGrid.cpp: Implement new ScrollbarClient functions. (WebCore::RenderDataGrid::scrollSize): (WebCore::RenderDataGrid::setScrollOffsetFromAnimation):
  • rendering/RenderDataGrid.h: Implement new ScrollbarClient functions.
  • rendering/RenderLayer.cpp: Implement new ScrollbarClient functions. (WebCore::RenderLayer::scrollToOffset): (WebCore::RenderLayer::scrollSize): (WebCore::RenderLayer::setScrollOffsetFromAnimation): (WebCore::RenderLayer::updateScrollInfoAfterLayout):
  • rendering/RenderLayer.h: Implement new ScrollbarClient functions.
  • rendering/RenderListBox.cpp: Implement new ScrollbarClient functions. (WebCore::RenderListBox::scrollToRevealElementAtListIndex): (WebCore::RenderListBox::scrollSize): (WebCore::RenderListBox::setScrollOffsetFromAnimation): (WebCore::RenderListBox::setScrollTop):
  • rendering/RenderListBox.h: Implement new ScrollbarClient functions.

2010-09-08 Peter Kasting <pkasting@google.com>

Reviewed by David Hyatt.

Add smooth scrolling framework, and a Windows implementation.
https://bugs.webkit.org/show_bug.cgi?id=32356

  • src/WebScrollbarImpl.cpp: Plumb new ScrollbarClient functions. Allow wheel scrolls to be animated. (WebKit::WebScrollbarImpl::setLocation): (WebKit::WebScrollbarImpl::setValue): (WebKit::WebScrollbarImpl::scroll): (WebKit::WebScrollbarImpl::onMouseWheel): (WebKit::WebScrollbarImpl::onKeyDown): (WebKit::WebScrollbarImpl::setScrollOffsetFromAnimation):
  • src/WebScrollbarImpl.h: Plumb new ScrollbarClient functions.
  • src/win/WebInputEventFactory.cpp: Update comments now that we have smooth scrolling. (WebKit::WebInputEventFactory::mouseWheelEvent):

2010-09-08 Peter Kasting <pkasting@google.com>

Reviewed by David Hyatt.

Add smooth scrolling framework, and a Windows implementation.
https://bugs.webkit.org/show_bug.cgi?id=32356

  • Api/qwebframe.cpp: (QWebFrame::setScrollBarValue):
12:24 Changeset [67000] by rniwa@webkit.org

2010-09-08 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Tony Chang.

applyInlineStyleToRange needs cleanup
https://bugs.webkit.org/show_bug.cgi?id=45008

Removed rangeIsEmpty and extracted the entire loop into applyInlineStyleToNodeRange.
applyInlineStyleToRange is now a wrapper that fixes range and passes it on to applyInlineStyleToNodeRange.

No new tests are added since this is a cleanup.

  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyInlineStyleToRange): Cleaned up. (WebCore::ApplyStyleCommand::applyInlineStyleToNodeRange): Extracted from applyInlineStyleToRange.
  • editing/ApplyStyleCommand.h:
12:20 Changeset [66999] by aroben@apple.com

Get rid of WorkQueue::m_performWorkEvent

We were signaling m_performWorkEvent to spawn a worker thread. We can
use ::QueueUserWorkItem to spawn the thread instead.

Fixes <http://webkit.org/b/45407> WorkQueue::m_performWorkEvent is
unnecessary

Reviewed by Anders Carlsson.

  • Platform/WorkQueue.h: Removed m_performWorkEvent.
  • Platform/win/WorkQueueWin.cpp:

(WorkQueue::workThreadCallback): Replaced eventCallback with this
function. Its functionality is unchanged.

(WorkQueue::platformInitialize):
(WorkQueue::platformInvalidate):
Removed code to set up and clean up m_performWorkEvent.

(WorkQueue::scheduleWork): Use ::QueueUserWorkItem instead of
signaling m_performWorkEvent to spawn a worker thread.

11:41 Changeset [66998] by aroben@apple.com

Fix WebKit2Common.vsprops line-endings

  • win/WebKit2Common.vsprops: Made all line-endings be CRLF, as this is

the format Visual Studio wants.

11:17 Changeset [66997] by aestes@apple.com

Incorporate additional feedback from
https://bugs.webkit.org/show_bug.cgi?id=45364.

Rubber-stamped by Darin Adler.

  • html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::parametersForPlugin): Rename urlParam to
urlParameter.

  • loader/SubframeLoader.h: Add argument names to the definition of

SubframeLoader::resourceWillUsePlugin().

11:07 Changeset [66996] by yurys@chromium.org

2010-09-08 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Joseph Pecoraro.

Web Inspector: remove some obsolete interactive tests
https://bugs.webkit.org/show_bug.cgi?id=45371

  • src/js/Tests.js:
10:58 Changeset [66995] by oliver@apple.com

2010-09-07 Oliver Hunt <oliver@apple.com>

Reviewed by Anders Carlsson.

Support SerializedScriptValue in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=45340

Add a new constructor that allows WebKit2 to create a SerializedScriptValue
directly from serialized data.

  • WebCore.exp.in:
  • bindings/js/SerializedScriptValue.h: (WebCore::SerializedScriptValue::adopt): (WebCore::SerializedScriptValue::data):

2010-09-07 Oliver Hunt <oliver@apple.com>

Reviewed by Anders Carlsson.

Support SerializedScriptValue in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=45340

Add wrappers and IPC serialization for SerializedScriptValue

  • Shared/APIObject.h:
  • Shared/UserMessageCoders.h: (WebKit::UserMessageEncoder::baseEncode): (WebKit::UserMessageDecoder::baseDecode):
  • Shared/WebSerializedScriptValue.h: Added. (WebKit::WebSerializedScriptValue::create): (WebKit::WebSerializedScriptValue::adopt): (WebKit::WebSerializedScriptValue::deserialize): (WebKit::WebSerializedScriptValue::data): (WebKit::WebSerializedScriptValue::WebSerializedScriptValue): (WebKit::WebSerializedScriptValue::type):
  • UIProcess/API/C/WKAPICast.h:
  • UIProcess/API/C/WKBase.h:
  • UIProcess/API/C/WKSerializedScriptValue.cpp: Added. (WKSerializedScriptValueGetTypeID): (WKSerializedScriptValueCreate): (WKSerializedScriptValueDeserialize):
  • UIProcess/API/C/WKSerializedScriptValue.h: Added.
  • WebKit2.xcodeproj/project.pbxproj:
10:44 Changeset [66994] by dglazkov@chromium.org

Added drover (http://dev.chromium.org/developers/how-tos/drover) configuration to the chromium branch root.

10:13 Changeset [66993] by dglazkov@chromium.org

Added code review settings file to branch.

10:08 Changeset [66992] by aestes@apple.com

2010-09-08 Andy Estes <aestes@apple.com>

Reviewed by Eric Carlson.

Fallback content should be rendered when an <object> doesn't specify a
data, type or classid attribute.
https://bugs.webkit.org/show_bug.cgi?id=45364
<rdar://problem/8375816>

HTML5 says that if no data or type attribute is specified on an <object>,
fallback content should be rendered. However, WebKit has traditionally
supported specifying a URL and MIME type in <param> elements.

To more closely match the spec while maintaining compatibility with
content that relied on our old behavior, we will continue to load
a resource specified by <param> elements if we can determine a priori
that it will be handled by a plug-in.

If we can't make this determination, and the <object> element has no
"data" or "type" attribute, the <param> elements will be ignored and
fallback content will be rendered. Otherwise, there is no change in
behavior.

  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::parametersForPlugin): If an empty url is passed to this function and a <param> exists that specifies a url that references a plug-in resource, set it to url, making it the url that will be loaded by the <object> element. (WebCore::HTMLObjectElement::updateWidget): If no type attribute was specified, but there is a classid attribute, try to map the classid to a MIME type. This needs to be done before calling HTMLObjectElement::parametersForPlugin().
  • loader/SubframeLoader.cpp: (WebCore::SubframeLoader::resourceWillUsePlugin): Make a public method that determines if a resource will load a plug-in based on its url and MIME type. This is equivalent to calling SubframeLoader::shouldUsePlugin(), but does not burden the caller with the details of fallback content.
  • loader/SubframeLoader.h:

2010-09-08 Andy Estes <aestes@apple.com>

Reviewed by Eric Carlson.

Fallback content should be rendered when an <object> doesn't specify a
data, type or classid attribute.
https://bugs.webkit.org/show_bug.cgi?id=45364
<rdar://problem/8375816>

  • fast/replaced/object-param-url-control-char.html:
  • fast/replaced/object-with-embed-url-param-expected.txt:
  • fast/replaced/object-with-embed-url-param.html:
09:52 Changeset [66991] by jocelyn.turcotte@nokia.com

2010-09-08 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>

Reviewed by Andreas Kling.

Re-Disable JIT for MSVC 64bit to fix the build on this compiler.
https://bugs.webkit.org/show_bug.cgi?id=45382

It was enabled in the cleanup made in r64176, though it is still
not implemented.

  • wtf/Platform.h:
09:35 Changeset [66990] by ossy@webkit.org

Unreviewed buildfix after r66972.

[Qt] Treat warnings as errors by default for gcc
https://bugs.webkit.org/show_bug.cgi?id=43191

  • WebKit.pri: Don't add -Werror for maemo platforms.
09:11 Changeset [66989] by commit-queue@webkit.org

2010-09-08 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: add breakpoints to source frame after content is loaded.
https://bugs.webkit.org/show_bug.cgi?id=43056

  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._resourceLoadingFinished): (WebInspector.ScriptsPanel.prototype._showScriptOrResource):
  • inspector/front-end/SourceView.js: (WebInspector.SourceView.prototype._contentLoaded):
09:07 Changeset [66988] by andreas.kling@nokia.com

2010-09-08 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Canvas: Remove unnecessary null-check of canvas() in getImageData()
https://bugs.webkit.org/show_bug.cgi?id=45394

canvas() is already dereferenced earlier in the function so there is
no use in checking it for null later.

  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::getImageData):
08:55 Changeset [66987] by philn@webkit.org

2010-09-08 Philippe Normand <pnormand@igalia.com>

Reviewed by Eric Carlson.

[GStreamer] cache media duration in READY instead of PLAYING
https://bugs.webkit.org/show_bug.cgi?id=39053

New cacheDuration private method used to in updateStates() and
durationChanged().

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::updateStates): (WebCore::MediaPlayerPrivateGStreamer::cacheDuration): (WebCore::MediaPlayerPrivateGStreamer::durationChanged):
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
08:27 Changeset [66986] by mrobinson@webkit.org

2010-09-08 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Need a WebSocket implementation
https://bugs.webkit.org/show_bug.cgi?id=45197

  • configure.ac: Enable WebSocket by default.

2010-09-08 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Need a WebSocket implementation
https://bugs.webkit.org/show_bug.cgi?id=45197

Add a GIO-based WebSocket implementation.

  • wtf/gobject/GRefPtr.cpp: Added PlatformRefPtr support for GSource. (WTF::refPlatformPtr): (WTF::derefPlatformPtr):
  • wtf/gobject/GRefPtr.h: Added new template specialization declarations.
  • wtf/gobject/GTypedefs.h: Add some more GLib/GIO forward declarations.

2010-09-08 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Need a WebSocket implementation
https://bugs.webkit.org/show_bug.cgi?id=45197

  • platform/gtk/Skipped: Unskip all WebSocket tests, as they are passing.

2010-09-08 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Need a WebSocket implementation
https://bugs.webkit.org/show_bug.cgi?id=45197

Add a GIO-based WebSocket implementation. This does not yet support
SSL sockets or proxies, but these should be possible to add as support
arrives in GLib/GIO for them.

  • platform/network/soup/SocketStreamHandle.h:
  • platform/network/soup/SocketStreamHandleSoup.cpp: Add a GIO-based WebSocket implementation. (WebCore::isActiveHandle): Added. (WebCore::deactivateHandle): Added. (WebCore::SocketStreamHandle::SocketStreamHandle): Filled out stub. (WebCore::SocketStreamHandle::~SocketStreamHandle): Ditto. (WebCore::SocketStreamHandle::connected): Added. (WebCore::SocketStreamHandle::readBytes): Added. (WebCore::SocketStreamHandle::writeReady): Added. (WebCore::SocketStreamHandle::platformSend): Filled out stub. (WebCore::SocketStreamHandle::platformClose): Filled out stub. (WebCore::SocketStreamHandle::beginWaitingForSocketWritability): Added. (WebCore::SocketStreamHandle::stopWaitingForSocketWritability): (WebCore::connectedCallback): Added. (WebCore::readReadyCallback): Added. (WebCore::writeReadyCallback): Added.
08:18 Changeset [66985] by commit-queue@webkit.org

2010-09-08 Sergio Villar Senin <svillar@igalia.com>

Reviewed by Adam Barth.

Errors in LayoutTests/http/tests/security/xss-DENIED-mime-type-execute-as-html.html
https://bugs.webkit.org/show_bug.cgi?id=45377

The test passes a MIME type as argument of a URL. A PHP code uses
that MIME type to fill the Content-Type of the response. If the
MIME type is application/rss+xml the php decodes the '+' as a
blank space and thus the returned content type is incorrectly set
to "rss xml" instead of "rss+xml".

  • http/tests/security/resources/send-mime-types.php:
  • http/tests/security/xss-DENIED-mime-type-execute-as-html.html:
08:11 Changeset [66984] by ossy@webkit.org

Fix ignoring return value warning in case of gcc 4.4.4
https://bugs.webkit.org/show_bug.cgi?id=45384

Patch by Peter Varga <pvarga@inf.u-szeged.hu> on 2010-09-08
Reviewed by Kenneth Rohde Christiansen.

  • DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:

(testPostURLFile):
If fwrite have written zero byte then the testPostURLFile function
returns with false as tempFile can't be opened.

  • DumpRenderTree/qt/ImageDiff.cpp:

(main):
Put fwrite function into an if condition without body to avoid
warning. It is safe because this function writes to the stdout.

07:47 Changeset [66983] by mrobinson@webkit.org

2010-09-07 Martin Robinson <mrobinson@igalia.com>

Reviewed by Dirk Schulze.

[Cairo] Actually use the antialias parameter of GraphicsContext::clipConvexPolygon
https://bugs.webkit.org/show_bug.cgi?id=45355

Rebaseline all differing border tests and unskip any border tests without results.

  • platform/gtk/Skipped: Unskip all border tests.
  • platform/gtk/fast/borders/block-mask-overlay-image-expected.checksum: Added.
  • platform/gtk/fast/borders/block-mask-overlay-image-expected.png: Added.
  • platform/gtk/fast/borders/block-mask-overlay-image-expected.txt: Added.
  • platform/gtk/fast/borders/border-color-inherit-expected.checksum: Added.
  • platform/gtk/fast/borders/border-color-inherit-expected.png: Added.
  • platform/gtk/fast/borders/border-color-inherit-expected.txt: Added.
  • platform/gtk/fast/borders/border-fit-expected.checksum: Added.
  • platform/gtk/fast/borders/border-fit-expected.png: Added.
  • platform/gtk/fast/borders/border-fit-expected.txt: Added.
  • platform/gtk/fast/borders/border-image-01-expected.checksum: Added.
  • platform/gtk/fast/borders/border-image-01-expected.png: Added.
  • platform/gtk/fast/borders/border-image-01-expected.txt: Added.
  • platform/gtk/fast/borders/border-image-border-radius-expected.checksum: Added.
  • platform/gtk/fast/borders/border-image-border-radius-expected.png: Added.
  • platform/gtk/fast/borders/border-image-border-radius-expected.txt: Added.
  • platform/gtk/fast/borders/border-image-omit-right-slice-expected.checksum: Added.
  • platform/gtk/fast/borders/border-image-omit-right-slice-expected.png: Added.
  • platform/gtk/fast/borders/border-image-omit-right-slice-expected.txt: Copied from LayoutTests/platform/mac/fast/borders/border-image-omit-right-slice-expected.txt.
  • platform/gtk/fast/borders/border-image-rotate-transform-expected.checksum: Added.
  • platform/gtk/fast/borders/border-image-rotate-transform-expected.png: Added.
  • platform/gtk/fast/borders/border-image-rotate-transform-expected.txt: Added.
  • platform/gtk/fast/borders/border-image-scale-transform-expected.checksum: Added.
  • platform/gtk/fast/borders/border-image-scale-transform-expected.png: Added.
  • platform/gtk/fast/borders/border-image-scale-transform-expected.txt: Added.
  • platform/gtk/fast/borders/border-radius-circle-expected.checksum:
  • platform/gtk/fast/borders/border-radius-circle-expected.png:
  • platform/gtk/fast/borders/border-radius-constraints-expected.checksum: Added.
  • platform/gtk/fast/borders/border-radius-constraints-expected.png: Added.
  • platform/gtk/fast/borders/border-radius-constraints-expected.txt: Added.
  • platform/gtk/fast/borders/border-radius-groove-01-expected.checksum:
  • platform/gtk/fast/borders/border-radius-groove-01-expected.png:
  • platform/gtk/fast/borders/border-radius-groove-02-expected.checksum:
  • platform/gtk/fast/borders/border-radius-groove-02-expected.png:
  • platform/gtk/fast/borders/border-radius-groove-03-expected.checksum:
  • platform/gtk/fast/borders/border-radius-groove-03-expected.png:
  • platform/gtk/fast/borders/border-radius-huge-assert-expected.checksum: Added.
  • platform/gtk/fast/borders/border-radius-huge-assert-expected.png: Added.
  • platform/gtk/fast/borders/border-radius-huge-assert-expected.txt: Added.
  • platform/gtk/fast/borders/border-radius-split-inline-expected.checksum: Added.
  • platform/gtk/fast/borders/border-radius-split-inline-expected.png: Added.
  • platform/gtk/fast/borders/border-radius-split-inline-expected.txt: Added.
  • platform/gtk/fast/borders/border-radius-wide-border-01-expected.checksum:
  • platform/gtk/fast/borders/border-radius-wide-border-01-expected.png:
  • platform/gtk/fast/borders/border-radius-wide-border-02-expected.checksum:
  • platform/gtk/fast/borders/border-radius-wide-border-02-expected.png:
  • platform/gtk/fast/borders/border-radius-wide-border-03-expected.checksum:
  • platform/gtk/fast/borders/border-radius-wide-border-03-expected.png:
  • platform/gtk/fast/borders/border-radius-wide-border-04-expected.checksum:
  • platform/gtk/fast/borders/border-radius-wide-border-04-expected.png:
  • platform/gtk/fast/borders/borderRadiusAllStylesAllCorners-expected.checksum: Added.
  • platform/gtk/fast/borders/borderRadiusAllStylesAllCorners-expected.png: Added.
  • platform/gtk/fast/borders/borderRadiusAllStylesAllCorners-expected.txt: Added.
  • platform/gtk/fast/borders/borderRadiusArcs01-expected.checksum: Added.
  • platform/gtk/fast/borders/borderRadiusArcs01-expected.png: Added.
  • platform/gtk/fast/borders/borderRadiusArcs01-expected.txt: Added.
  • platform/gtk/fast/borders/borderRadiusDashed01-expected.checksum: Added.
  • platform/gtk/fast/borders/borderRadiusDashed01-expected.png: Added.
  • platform/gtk/fast/borders/borderRadiusDashed01-expected.txt: Added.
  • platform/gtk/fast/borders/borderRadiusDashed02-expected.checksum: Added.
  • platform/gtk/fast/borders/borderRadiusDashed02-expected.png: Added.
  • platform/gtk/fast/borders/borderRadiusDashed02-expected.txt: Added.
  • platform/gtk/fast/borders/borderRadiusDashed03-expected.checksum: Added.
  • platform/gtk/fast/borders/borderRadiusDashed03-expected.png: Added.
  • platform/gtk/fast/borders/borderRadiusDashed03-expected.txt: Added.
  • platform/gtk/fast/borders/borderRadiusDashed04-expected.checksum:
  • platform/gtk/fast/borders/borderRadiusDashed04-expected.png:
  • platform/gtk/fast/borders/borderRadiusDashed05-expected.checksum:
  • platform/gtk/fast/borders/borderRadiusDashed05-expected.png:
  • platform/gtk/fast/borders/borderRadiusDashed06-expected.checksum:
  • platform/gtk/fast/borders/borderRadiusDashed06-expected.png:
  • platform/gtk/fast/borders/borderRadiusDotted01-expected.checksum: Added.
  • platform/gtk/fast/borders/borderRadiusDotted01-expected.png: Added.
  • platform/gtk/fast/borders/borderRadiusDotted01-expected.txt: Added.
  • platform/gtk/fast/borders/borderRadiusDotted02-expected.checksum: Added.
  • platform/gtk/fast/borders/borderRadiusDotted02-expected.png: Added.
  • platform/gtk/fast/borders/borderRadiusDotted02-expected.txt: Added.
  • platform/gtk/fast/borders/borderRadiusDotted03-expected.checksum: Added.
  • platform/gtk/fast/borders/borderRadiusDotted03-expected.png: Added.
  • platform/gtk/fast/borders/borderRadiusDotted03-expected.txt: Added.
  • platform/gtk/fast/borders/borderRadiusDotted04-expected.checksum:
  • platform/gtk/fast/borders/borderRadiusDotted04-expected.png:
  • platform/gtk/fast/borders/borderRadiusDotted05-expected.checksum:
  • platform/gtk/fast/borders/borderRadiusDotted05-expected.png:
  • platform/gtk/fast/borders/borderRadiusDotted06-expected.checksum:
  • platform/gtk/fast/borders/borderRadiusDotted06-expected.png:
  • platform/gtk/fast/borders/borderRadiusDouble01-expected.checksum: Added.
  • platform/gtk/fast/borders/borderRadiusDouble01-expected.png: Added.
  • platform/gtk/fast/borders/borderRadiusDouble01-expected.txt: Added.
  • platform/gtk/fast/borders/borderRadiusDouble02-expected.checksum: Added.
  • platform/gtk/fast/borders/borderRadiusDouble02-expected.png: Added.
  • platform/gtk/fast/borders/borderRadiusDouble02-expected.txt: Added.
  • platform/gtk/fast/borders/borderRadiusDouble03-expected.checksum: Added.
  • platform/gtk/fast/borders/borderRadiusDouble03-expected.png: Added.
  • platform/gtk/fast/borders/borderRadiusDouble03-expected.txt: Added.
  • platform/gtk/fast/borders/borderRadiusDouble04-expected.checksum:
  • platform/gtk/fast/borders/borderRadiusDouble04-expected.png:
  • platform/gtk/fast/borders/borderRadiusDouble05-expected.checksum:
  • platform/gtk/fast/borders/borderRadiusDouble05-expected.png:
  • platform/gtk/fast/borders/borderRadiusDouble06-expected.checksum:
  • platform/gtk/fast/borders/borderRadiusDouble06-expected.png:
  • platform/gtk/fast/borders/borderRadiusDouble07-expected.checksum:
  • platform/gtk/fast/borders/borderRadiusDouble07-expected.png:
  • platform/gtk/fast/borders/borderRadiusDouble08-expected.checksum:
  • platform/gtk/fast/borders/borderRadiusDouble08-expected.png:
  • platform/gtk/fast/borders/borderRadiusDouble09-expected.checksum:
  • platform/gtk/fast/borders/borderRadiusDouble09-expected.png:
  • platform/gtk/fast/borders/borderRadiusGroove01-expected.checksum: Added.
  • platform/gtk/fast/borders/borderRadiusGroove01-expected.png: Added.
  • platform/gtk/fast/borders/borderRadiusGroove01-expected.txt: Added.
  • platform/gtk/fast/borders/borderRadiusGroove02-expected.checksum: Added.
  • platform/gtk/fast/borders/borderRadiusGroove02-expected.png: Added.
  • platform/gtk/fast/borders/borderRadiusGroove02-expected.txt: Added.
  • platform/gtk/fast/borders/borderRadiusInset01-expected.checksum: Added.
  • platform/gtk/fast/borders/borderRadiusInset01-expected.png: Added.
  • platform/gtk/fast/borders/borderRadiusInset01-expected.txt: Added.
  • platform/gtk/fast/borders/borderRadiusInvalidColor-expected.checksum: Added.
  • platform/gtk/fast/borders/borderRadiusInvalidColor-expected.png: Added.
  • platform/gtk/fast/borders/borderRadiusInvalidColor-expected.txt: Added.
  • platform/gtk/fast/borders/borderRadiusOutset01-expected.checksum: Added.
  • platform/gtk/fast/borders/borderRadiusOutset01-expected.png: Added.
  • platform/gtk/fast/borders/borderRadiusOutset01-expected.txt: Added.
  • platform/gtk/fast/borders/borderRadiusRidge01-expected.checksum: Added.
  • platform/gtk/fast/borders/borderRadiusRidge01-expected.png: Added.
  • platform/gtk/fast/borders/borderRadiusRidge01-expected.txt: Added.
  • platform/gtk/fast/borders/borderRadiusSolid01-expected.checksum: Added.
  • platform/gtk/fast/borders/borderRadiusSolid01-expected.png: Added.
  • platform/gtk/fast/borders/borderRadiusSolid01-expected.txt: Added.
  • platform/gtk/fast/borders/borderRadiusSolid02-expected.checksum: Added.
  • platform/gtk/fast/borders/borderRadiusSolid02-expected.png: Added.
  • platform/gtk/fast/borders/borderRadiusSolid02-expected.txt: Added.
  • platform/gtk/fast/borders/borderRadiusSolid03-expected.checksum: Added.
  • platform/gtk/fast/borders/borderRadiusSolid03-expected.png: Added.
  • platform/gtk/fast/borders/borderRadiusSolid03-expected.txt: Added.
  • platform/gtk/fast/borders/borderRadiusSolid04-expected.checksum: Added.
  • platform/gtk/fast/borders/borderRadiusSolid04-expected.png: Added.
  • platform/gtk/fast/borders/borderRadiusSolid04-expected.txt: Added.
  • platform/gtk/fast/borders/different-color-borders-expected.checksum:
  • platform/gtk/fast/borders/different-color-borders-expected.png:
  • platform/gtk/fast/borders/fieldsetBorderRadius-expected.checksum: Added.
  • platform/gtk/fast/borders/fieldsetBorderRadius-expected.png: Added.
  • platform/gtk/fast/borders/fieldsetBorderRadius-expected.txt: Copied from LayoutTests/platform/mac/fast/borders/fieldsetBorderRadius-expected.txt.
  • platform/gtk/fast/borders/inline-mask-overlay-image-expected.checksum: Added.
  • platform/gtk/fast/borders/inline-mask-overlay-image-expected.png: Added.
  • platform/gtk/fast/borders/inline-mask-overlay-image-expected.txt: Added.
  • platform/gtk/fast/borders/outline-offset-min-assert-expected.checksum: Added.
  • platform/gtk/fast/borders/outline-offset-min-assert-expected.png: Added.
  • platform/gtk/fast/borders/outline-offset-min-assert-expected.txt: Copied from LayoutTests/platform/mac/fast/borders/outline-offset-min-assert-expected.txt.
  • platform/gtk/fast/borders/svg-as-border-image-2-expected.checksum: Added.
  • platform/gtk/fast/borders/svg-as-border-image-2-expected.png: Added.
  • platform/gtk/fast/borders/svg-as-border-image-2-expected.txt: Added.
  • platform/gtk/fast/borders/svg-as-border-image-expected.checksum: Added.
  • platform/gtk/fast/borders/svg-as-border-image-expected.png: Added.
  • platform/gtk/fast/borders/svg-as-border-image-expected.txt: Added.

2010-09-07 Martin Robinson <mrobinson@igalia.com>

Reviewed by Dirk Schulze.

[Cairo] Actually use the antialias parameter of GraphicsContext::clipConvexPolygon
https://bugs.webkit.org/show_bug.cgi?id=45355

r63864 added an additional boolean parameter to GraphicsContext::clipConvexPolygon,
which determines whether or not to render the render the clip with anti-aliasing
or not. The Cairo implementation now uses that parameter to determine the argument
to pass to cairo_set_antialias(...) when clipping.

Test: This is tested by many tests in fast/borders.

  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::clipConvexPolygon): Actually use the boolean antialias parameter.
07:39 Changeset [66982] by mrobinson@webkit.org

2010-09-08 Martin Robinson <mrobinson@igalia.com>

Rebaseline mathml/presentation/attributes.xhtml.

  • platform/gtk/mathml/presentation/attributes-expected.txt:
07:37 Changeset [66981] by weinig@apple.com

Would like WKBundleFrameRef to turn into WKFrameRef across postMessage boundary, a la PageRef
<rdar://problem/8402804>
https://bugs.webkit.org/show_bug.cgi?id=45370

Reviewed by Jon Honeycutt.

  • UIProcess/WebContextUserMessageCoders.h:

(WebKit::WebContextUserMessageEncoder::encode):
(WebKit::WebContextUserMessageDecoder::decode):

  • WebProcess/InjectedBundle/InjectedBundleUserMessageCoders.h:

(WebKit::InjectedBundleUserMessageEncoder::encode):
(WebKit::InjectedBundleUserMessageDecoder::decode):

07:28 Changeset [66980] by commit-queue@webkit.org

2010-09-08 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Support to enable HTML5's Video based on gstreamer in WebKit-EFL
https://bugs.webkit.org/show_bug.cgi?id=44098

To support video of HTML5 based on gstreamer, add cmake files for gstreamer.

  • cmake/FindGStreamer-App.cmake: Added.
  • cmake/FindGStreamer-Base.cmake: Added.
  • cmake/FindGStreamer-Interfaces.cmake: Added.
  • cmake/FindGStreamer-Pbutils.cmake: Added.
  • cmake/FindGStreamer-Plugins-Base.cmake: Added.
  • cmake/FindGStreamer-Video.cmake: Added.
  • cmake/FindGStreamer.cmake: Added.
  • cmake/OptionsEfl.cmake:

2010-09-08 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Support to enable HTML5's Video based on gstreamer in WebKit-EFL
https://bugs.webkit.org/show_bug.cgi?id=44098

To support video of HTML5 based on gstreamer, add files regarding gstreamer to
CMakeListsEfl.txt.

  • CMakeListsEfl.txt:
07:07 Changeset [66979] by commit-queue@webkit.org

2010-09-08 Jan E Hanssen <jhanssen@sencha.com>

Reviewed by Dirk Schulze.

Add a test for getting a point beyond the length of the path
https://bugs.webkit.org/show_bug.cgi?id=43837

  • svg/dom/path-pointAtLength-expected.txt:
  • svg/dom/script-tests/path-pointAtLength.js:

2010-09-08 Jan E Hanssen <jhanssen@sencha.com>

Reviewed by Dirk Schulze.

[Qt] PathQt should use the QPainterPath functionality for calculations
https://bugs.webkit.org/show_bug.cgi?id=43837

Change PathQt to use the built-in functionality of QPainterPath for
calculating length(), pointAtLength() and normalAngleAtLength().

  • platform/graphics/Path.cpp:
  • platform/graphics/qt/PathQt.cpp: (WebCore::Path::length): (WebCore::Path::pointAtLength): (WebCore::Path::normalAngleAtLength):
06:46 Changeset [66978] by commit-queue@webkit.org

2010-09-08 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Dirk Schulze.

[WML] Remove create() function in WMLTaskElement because of build break.
https://bugs.webkit.org/show_bug.cgi?id=44954

Remove create() function in WMLTaskElement.cpp because of build breaks.

  • wml/WMLTaskElement.cpp:
  • wml/WMLTaskElement.h:
06:27 Changeset [66977] by commit-queue@webkit.org

2010-09-08 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Dirk Schulze.

[WML] Add create functions to WML.
https://bugs.webkit.org/show_bug.cgi?id=44950

There are missing definitions of create function in WML area.
So, there are build breaks when enabling WML. The create functions and the construction
are added. In addition, a style error and duplicated adoptRef usage are fixed.

  • wml/WMLDocument.h: (WebCore::WMLDocument::create):
  • wml/WMLFormControlElement.h:
  • wml/WMLIntrinsicEvent.cpp: (WebCore::WMLIntrinsicEvent::WMLIntrinsicEvent):
  • wml/WMLIntrinsicEvent.h:
06:16 Changeset [66976] by hans@chromium.org

2010-09-08 Hans Wennborg <hans@chromium.org>

Reviewed by Jeremy Orlow.

Plug leak in WebDeviceOrientationClientMock
https://bugs.webkit.org/show_bug.cgi?id=45305

WebDeviceOrientationClientMock is responsible for destroying the
WebDeviceOrientationController object pointed to by the argument
passed to the setController() member function.

Also use the new WebPrivateOnwPtr for m_clientMock.

  • public/WebDeviceOrientationClientMock.h:
  • src/WebDeviceOrientationClientMock.cpp: (WebKit::WebDeviceOrientationClientMock::setController): (WebKit::WebDeviceOrientationClientMock::initialize): (WebKit::WebDeviceOrientationClientMock::reset):
06:02 Changeset [66975] by thakis@chromium.org

2010-09-08 Nico Weber <thakis@chromium.org>

Reviewed by Kenneth Russell.

chromium/mac: Fix crash with compositor due to missing current NSGraphicsContext
https://bugs.webkit.org/show_bug.cgi?id=45354

  • platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::updateContents): Set a current local context.
05:38 Changeset [66974] by yael.aharon@nokia.com

2010-09-08 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Antonio Gomes.

Missing EOL in expected test results
https://bugs.webkit.org/show_bug.cgi?id=45352

Add the missing EOL.

  • fast/notifications/notifications-click-event-expected.txt:
05:08 Changeset [66973] by jschuh@chromium.org

2010-09-08 Justin Schuh <jschuh@chromium.org>

Reviewed by Nikolas Zimmermann.

NULL deref when use target is reset, then set to display:none
https://bugs.webkit.org/show_bug.cgi?id=45345

  • svg/custom/use-display-none-expected.txt: Added.
  • svg/custom/use-display-none.svg: Added.

2010-09-08 Justin Schuh <jschuh@chromium.org>

Reviewed by Nikolas Zimmermann.

NULL deref when use target is reset, then set to display:none
https://bugs.webkit.org/show_bug.cgi?id=45345

Move the NULL check on shadowRoot earlier in SVGUseElement::recalcStyle

Test: svg/custom/use-display-none.svg

  • svg/SVGUseElement.cpp: (WebCore::SVGUseElement::recalcStyle):
05:05 MathML 3 testsuite results edited by sausset@gmail.com
(diff)
04:34 Changeset [66972] by ossy@webkit.org

2010-09-08 Csaba Osztrogonác <ossy@webkit.org>

Reviewed by Andreas Kling.

[Qt] Treat warnings as errors by default for gcc
https://bugs.webkit.org/show_bug.cgi?id=43191

  • WebKit.pri: -Werror added to QMAKE_CXXFLAGS for x86 Linux platforms
04:33 Changeset [66971] by satish@chromium.org

Adding myself to committers list.

04:25 Changeset [66970] by hans@chromium.org

2010-09-08 Hans Wennborg <hans@chromium.org>

Unreviewed.

Adding myself as a committer in committers.py.

  • Scripts/webkitpy/common/config/committers.py:
04:18 Changeset [66969] by zoltan@webkit.org

[Qt] Refactor MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=45173

Reviewed by Simon Hausmann.

Split BrowserWindow into two source files and headers. Remove unnecessary header includes.

  • MiniBrowser/qt/BrowserView.cpp: Added.

(createNewPage):
(BrowserView::BrowserView):
(BrowserView::resizeEvent):
(BrowserView::load):
(BrowserView::view):

  • MiniBrowser/qt/BrowserView.h: Added.

(BrowserView::~BrowserView):

  • MiniBrowser/qt/BrowserWindow.cpp:
  • MiniBrowser/qt/BrowserWindow.h:
  • MiniBrowser/qt/MiniBrowser.pro:
04:08 Changeset [66968] by mjs@apple.com

2010-08-30 Maciej Stachowiak <mjs@apple.com>

Reviewed by Darin Adler.

Handle MediaQueryExp memory management exclusively with smart pointers
https://bugs.webkit.org/show_bug.cgi?id=44874


Implemented a non-copying sort function to make it possible to sort a Vector
of OwnPtrs (which cannot be copied). This is required for the above.

  • wtf/NonCopyingSort.h: Added. (WTF::nonCopyingSort): It's secretly heapsort. (WTF::heapSort): heapsort implementation. (WTF::siftDown): Helper function for heapsort. (WTF::heapify): ditto

Adjust build systems.


2010-08-30 Maciej Stachowiak <mjs@apple.com>

Reviewed by Darin Adler.

Handle MediaQueryExp memory management exclusively with smart pointers
https://bugs.webkit.org/show_bug.cgi?id=44874

Gace MediaQueryExp a create function, made the constructor private, and followed
the implications. The one tricky bit was using a non-copying sort to sort
the Vector<OwnPtr<MediaQueryExp> > in the MediaQuery constructor.


  • ForwardingHeaders/wtf/NonCopyingSort.h: Added.
  • css/CSSGrammar.y:
  • css/CSSParser.cpp: (WebCore::CSSParser::~CSSParser): (WebCore::CSSParser::createFloatingMediaQueryExp): (WebCore::CSSParser::createFloatingMediaQueryExpList): (WebCore::CSSParser::sinkFloatingMediaQueryExpList): (WebCore::CSSParser::createFloatingMediaQuery):
  • css/CSSParser.h:
  • css/MediaList.cpp:
  • css/MediaQuery.cpp: (WebCore::expressionCompare): (WebCore::MediaQuery::MediaQuery): (WebCore::MediaQuery::~MediaQuery):
  • css/MediaQuery.h: (WebCore::MediaQuery::expressions):
  • css/MediaQueryEvaluator.cpp: (WebCore::MediaQueryEvaluator::eval):
  • css/MediaQueryExp.h: (WebCore::MediaQueryExp::create):
04:01 Changeset [66967] by abarth@webkit.org

2010-09-08 Adam Barth <abarth@webkit.org>

Reviewed by Maciej Stachowiak.

Remove unused member variable from DecodedDocumentParser
https://bugs.webkit.org/show_bug.cgi?id=45379

This member variable isn't used because of the recent split of
TextDocumentParser and TextViewSourceParser.

  • dom/DecodedDataDocumentParser.cpp: (WebCore::DecodedDataDocumentParser::DecodedDataDocumentParser):
  • dom/DecodedDataDocumentParser.h:
  • dom/ScriptableDocumentParser.cpp: (WebCore::ScriptableDocumentParser::ScriptableDocumentParser):
  • dom/ScriptableDocumentParser.h:
03:58 Changeset [66966] by abarth@webkit.org

2010-09-08 Adam Barth <abarth@webkit.org>

Attempted Window build fix.

  • WebDataSource.cpp: (WebDataSource::subresourceForURL):
03:48 Changeset [66965] by ossy@webkit.org

2010-09-08 Csaba Osztrogonác <ossy@webkit.org>

Reviewed by Andreas Kling.

Fix warning in rendering/RenderBlock.cpp.
https://bugs.webkit.org/show_bug.cgi?id=45373

  • rendering/RenderBlock.cpp:
(WebCore::RenderBlock::hitTestColumns): Suggested parentheses added around && within
03:29 Changeset [66964] by commit-queue@webkit.org

2010-09-08 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Martin Robinson.

[Gtk] A list item's number/bullet should not be a child of that list item
https://bugs.webkit.org/show_bug.cgi?id=45190

Ignore list markers and prefix them to the text for the item

  • accessibility/gtk/AccessibilityObjectAtk.cpp: (WebCore::AccessibilityObject::accessibilityPlatformIncludesObject): Make list markers ignore accessibility for the GTK port.
  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_text_get_text): Prefix the text of a marker along with the accessible text for its list item's AtkObject

2010-09-08 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Martin Robinson.

[Gtk] A list item's number/bullet should not be a child of that list item
https://bugs.webkit.org/show_bug.cgi?id=45190

New unit test added.

  • tests/testatk.c: (testWebkitAtkListsOfItems): New test to check ordered/unordered list of items are properly exposed to AT technologies. (main):
03:26 Changeset [66963] by abarth@webkit.org

2010-09-08 Adam Barth <abarth@webkit.org>

Rubber-stamped by Eric Seidel.

Rename DocLoader to CachedResourceLoader because that's what it does.

  • WebDataSource.cpp:

2010-09-08 Adam Barth <abarth@webkit.org>

Rubber-stamped by Eric Seidel.

Rename DocLoader to CachedResourceLoader because that's what it does.

  • WebView/WebFrame.mm:

2010-09-08 Adam Barth <abarth@webkit.org>

Rubber-stamped by Eric Seidel.

Rename DocLoader to CachedResourceLoader because that's what it does.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSCursorImageValue.cpp: (WebCore::CSSCursorImageValue::cachedImage):
  • css/CSSCursorImageValue.h:
  • css/CSSFontFaceSource.cpp: (WebCore::CSSFontFaceSource::getFontData):
  • css/CSSFontSelector.cpp: (WebCore::CSSFontSelector::cachedResourceLoader): (WebCore::CSSFontSelector::addFontFaceRule):
  • css/CSSFontSelector.h:
  • css/CSSImageValue.cpp: (WebCore::CSSImageValue::cachedImage):
  • css/CSSImageValue.h:
  • css/CSSImportRule.cpp: (WebCore::CSSImportRule::insertedIntoParent):
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::loadPendingImages):
  • css/CSSStyleSheet.h:
  • dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::~Document): (WebCore::Document::implicitClose):
  • dom/Document.h: (WebCore::Document::cachedResourceLoader):
  • dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::checkStyleSheet):
  • dom/ScriptElement.cpp: (WebCore::ScriptElementData::requestScript):
  • dom/XMLDocumentParser.cpp:
  • dom/XMLDocumentParser.h:
  • dom/XMLDocumentParserLibxml2.cpp: (WebCore::matchFunc): (WebCore::shouldAllowExternalLoad): (WebCore::openFunc): (WebCore::XMLDocumentParser::doWrite): (WebCore::XMLDocumentParser::endElementNs): (WebCore::XMLDocumentParser::initializeParserContext): (WebCore::XMLDocumentParser::doEnd): (WebCore::xmlDocPtrForString):
  • dom/XMLDocumentParserQt.cpp: (WebCore::XMLDocumentParser::parseEndElement):
  • dom/XMLDocumentParserScope.cpp: (WebCore::XMLDocumentParserScope::XMLDocumentParserScope): (WebCore::XMLDocumentParserScope::~XMLDocumentParserScope):
  • dom/XMLDocumentParserScope.h:
  • editing/Editor.cpp: (WebCore::Editor::paste):
  • editing/mac/EditorMac.mm: (WebCore::Editor::paste):
  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::process):
  • html/parser/CSSPreloadScanner.cpp: (WebCore::CSSPreloadScanner::emitRule):
  • html/parser/HTMLPreloadScanner.cpp: (WebCore::HTMLNames::PreloadTask::preload):
  • html/parser/HTMLScriptRunner.cpp: (WebCore::HTMLScriptRunner::requestPendingScript):
  • inspector/InspectorResource.cpp: (WebCore::InspectorResource::cachedResource):
  • loader/Cache.cpp: (WebCore::Cache::requestResource): (WebCore::Cache::requestUserCSSStyleSheet): (WebCore::Cache::revalidateResource): (WebCore::Cache::addCachedResourceLoader): (WebCore::Cache::removeCachedResourceLoader):
  • loader/Cache.h:
  • loader/CachedCSSStyleSheet.h:
  • loader/CachedFont.cpp: (WebCore::CachedFont::load): (WebCore::CachedFont::beginLoadIfNeeded):
  • loader/CachedFont.h:
  • loader/CachedImage.cpp: (WebCore::CachedImage::load): (WebCore::CachedImage::maximumDecodedImageSize):
  • loader/CachedImage.h:
  • loader/CachedResource.cpp: (WebCore::CachedResource::CachedResource): (WebCore::CachedResource::~CachedResource): (WebCore::CachedResource::load):
  • loader/CachedResource.h: (WebCore::CachedResource::load): (WebCore::CachedResource::setCachedResourceLoader):
  • loader/CachedResourceLoader.cpp: Copied from WebCore/loader/DocLoader.cpp. (WebCore::CachedResourceLoader::CachedResourceLoader): (WebCore::CachedResourceLoader::~CachedResourceLoader): (WebCore::CachedResourceLoader::frame): (WebCore::CachedResourceLoader::checkForReload): (WebCore::CachedResourceLoader::requestImage): (WebCore::CachedResourceLoader::requestFont): (WebCore::CachedResourceLoader::requestCSSStyleSheet): (WebCore::CachedResourceLoader::requestUserCSSStyleSheet): (WebCore::CachedResourceLoader::requestScript): (WebCore::CachedResourceLoader::requestXSLStyleSheet): (WebCore::CachedResourceLoader::requestLinkPrefetch): (WebCore::CachedResourceLoader::canRequest): (WebCore::CachedResourceLoader::requestResource): (WebCore::CachedResourceLoader::printAccessDeniedMessage): (WebCore::CachedResourceLoader::setAutoLoadImages): (WebCore::CachedResourceLoader::cachePolicy): (WebCore::CachedResourceLoader::removeCachedResource): (WebCore::CachedResourceLoader::setLoadInProgress): (WebCore::CachedResourceLoader::checkCacheObjectStatus): (WebCore::CachedResourceLoader::incrementRequestCount): (WebCore::CachedResourceLoader::decrementRequestCount): (WebCore::CachedResourceLoader::requestCount): (WebCore::CachedResourceLoader::preload): (WebCore::CachedResourceLoader::checkForPendingPreloads): (WebCore::CachedResourceLoader::requestPreload): (WebCore::CachedResourceLoader::clearPreloads): (WebCore::CachedResourceLoader::clearPendingPreloads): (WebCore::CachedResourceLoader::printPreloadStats):
  • loader/CachedResourceLoader.h: Copied from WebCore/loader/DocLoader.h.
  • loader/CachedScript.h:
  • loader/CachedXSLStyleSheet.h:
  • loader/DocLoader.cpp: Removed.
  • loader/DocLoader.h: Removed.
  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::isLoadingInAPISense): (WebCore::DocumentLoader::subresource): (WebCore::DocumentLoader::getSubresources):
  • loader/FrameLoader.cpp: (WebCore::numRequests): (WebCore::FrameLoader::stopLoading): (WebCore::FrameLoader::didBeginDocument):
  • loader/HistoryController.cpp: (WebCore::HistoryController::createItem):
  • loader/ImageLoader.cpp: (WebCore::ImageLoader::updateFromElement):
  • loader/Request.cpp: (WebCore::Request::Request):
  • loader/Request.h: (WebCore::Request::cachedResourceLoader):
  • loader/loader.cpp: (WebCore::Loader::load): (WebCore::Loader::cancelRequests): (WebCore::Loader::Host::servePendingRequests): (WebCore::Loader::Host::didFinishLoading): (WebCore::Loader::Host::didFail): (WebCore::Loader::Host::didReceiveResponse): (WebCore::Loader::Host::cancelPendingRequests): (WebCore::Loader::Host::cancelRequests):
  • loader/loader.h:
  • page/DragController.cpp: (WebCore::DragController::concludeEditDrag):
  • page/Frame.cpp:
  • page/FrameView.cpp: (WebCore::FrameView::checkStopDelayingDeferredRepaints): (WebCore::FrameView::updateDeferredRepaintDelay):
  • page/Settings.cpp: (WebCore::setLoadsImagesAutomaticallyInAllFrames):
  • platform/android/TemporaryLinkStubs.cpp: (WebCore::CheckCacheObjectStatus):
  • platform/network/android/ResourceHandleAndroid.cpp: (WebCore::ResourceHandle::start):
  • platform/network/cf/ResourceHandleCFNet.cpp:
  • platform/network/curl/ResourceHandleCurl.cpp:
  • platform/network/mac/ResourceHandleMac.mm:
  • platform/network/qt/ResourceHandleQt.cpp:
  • platform/network/soup/ResourceHandleSoup.cpp:
  • platform/network/win/ResourceHandleWin.cpp:
  • svg/SVGFEImageElement.cpp: (WebCore::SVGFEImageElement::requestImageResource):
  • svg/SVGFontFaceUriElement.cpp: (WebCore::SVGFontFaceUriElement::loadFont):
  • workers/Worker.cpp:
  • xml/XSLImportRule.cpp: (WebCore::XSLImportRule::loadSheet):
  • xml/XSLStyleSheet.h:
  • xml/XSLStyleSheetLibxslt.cpp: (WebCore::XSLStyleSheet::cachedResourceLoader): (WebCore::XSLStyleSheet::parseString):
  • xml/XSLStyleSheetQt.cpp: (WebCore::XSLStyleSheet::cachedResourceLoader):
  • xml/XSLTProcessor.cpp:
  • xml/XSLTProcessorLibxslt.cpp: (WebCore::docLoaderFunc): (WebCore::setXSLTLoadCallBack): (WebCore::xmlDocPtrFromNode): (WebCore::XSLTProcessor::transformToString):

2010-09-08 Adam Barth <abarth@webkit.org>

Rubber-stamped by Eric Seidel.

Rename DocLoader to CachedResourceLoader because that's what it does.

  • Scripts/do-webcore-rename:
02:59 Changeset [66962] by zherczeg@webkit.org

Refactoring multiline comments in the lexer
https://bugs.webkit.org/show_bug.cgi?id=45289

Reviewed by Darin Adler.

MultiLine comment parsing is moved to a separate function.

Slight performance increase on --parse-only tests (from 33.6ms to 32.8ms)
SunSpider reports no change (from 523.1ms to 521.2ms).

  • parser/Lexer.cpp:

(JSC::Lexer::parseMultilineComment):
(JSC::Lexer::lex):

  • parser/Lexer.h:
02:18 Changeset [66961] by vestbo@webkit.org

Add mediaPlayerPlaybackStateChanged to MediaPlayerClient

Reviewed by Eric Carlson.

https://bugs.webkit.org/show_bug.cgi?id=45263

The platform backend may change state, for example as a result
of an external plugin controlling the backend, so we need to
react to this situation by syncing up the WebCore state with the
platform backend.

We call playInternal()/pauseInternal() depending on the backend
state, to trigger the corresponding DOM events to match the state.

updatePlayState() is then refactored to take into account the
situation where the backend is already in the correct state but
WebCore is not, so that we update the playback progress timer
and set m_playing correctly.

updatePlayState() changes Should be covered by existing tests.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::mediaPlayerPlaybackStateChanged):
(WebCore::HTMLMediaElement::updatePlayState):

  • html/HTMLMediaElement.h:
  • platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::playbackStateChanged):

  • platform/graphics/MediaPlayer.h:

(WebCore::MediaPlayerClient::mediaPlayerPlaybackStateChanged):

02:06 Changeset [66960] by abarth@webkit.org

2010-09-08 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

TextDocument doesn't belong in WebCore/loader
https://bugs.webkit.org/show_bug.cgi?id=45346

TextDocument has nothing to do with loading. It turns out that it
should be in WebCore/html because TextDocument is actually a subclass
of HTMLDocument (in quirks mode, no less).

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/TextDocument.cpp: Renamed from WebCore/loader/TextDocument.cpp. (WebCore::TextDocument::TextDocument): (WebCore::TextDocument::createParser):
  • html/TextDocument.h: Renamed from WebCore/loader/TextDocument.h. (WebCore::TextDocument::create):
02:04 Changeset [66959] by abarth@webkit.org

2010-09-08 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Create TextViewSourceParser
https://bugs.webkit.org/show_bug.cgi?id=45343

Rather than have the view source document set a flag on
HTMLViewSourceParser to indicate whether we're parsing a text document,
this patch creates a TextViewSourceParser for parsing text documents in
view-source mode. Like the TextDocumentParser, the
TextViewSourceParser implements this functionality by subclassing its
HTML counterpart.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::createParser):
  • html/parser/HTMLViewSourceParser.cpp:
  • html/parser/HTMLViewSourceParser.h: (WebCore::HTMLViewSourceParser::tokenizer):
  • html/parser/TextViewSourceParser.cpp: Added. (WebCore::TextViewSourceParser::TextViewSourceParser): (WebCore::TextViewSourceParser::~TextViewSourceParser):
  • html/parser/TextViewSourceParser.h: Added. (WebCore::TextViewSourceParser::create):
01:59 Changeset [66958] by abarth@webkit.org

2010-09-08 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Move HTMLInputStream to WebCore/html/parser
https://bugs.webkit.org/show_bug.cgi?id=45339

I forgot to move this file before.

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/parser/HTMLInputStream.h: Renamed from WebCore/html/HTMLInputStream.h. (WebCore::HTMLInputStream::HTMLInputStream): (WebCore::HTMLInputStream::appendToEnd): (WebCore::HTMLInputStream::insertAtCurrentInsertionPoint): (WebCore::HTMLInputStream::hasInsertionPoint): (WebCore::HTMLInputStream::markEndOfFile): (WebCore::HTMLInputStream::haveSeenEndOfFile): (WebCore::HTMLInputStream::current): (WebCore::HTMLInputStream::splitInto): (WebCore::HTMLInputStream::mergeFrom): (WebCore::InsertionPointRecord::InsertionPointRecord): (WebCore::InsertionPointRecord::~InsertionPointRecord):
01:52 Changeset [66957] by abarth@webkit.org

2010-09-08 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

TextDocument should come in from the cold
https://bugs.webkit.org/show_bug.cgi?id=45334

Previously, TextDocument reinvented the wheel to parse text. This
patch replaces TextDocument's hand-rolled parser with a parser built on
the HTML parser infrustructure, which gives us that stuff for free. I
also disentangled TextDocument from HTMLViewSourceDocument.

In a future patch, I'll move TextDocument out of the "loader" directory.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::createParser):
  • html/HTMLViewSourceDocument.h:
  • html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::constructTreeFromToken): (WebCore::HTMLTreeBuilder::constructTreeFromAtomicToken):
  • html/parser/HTMLTreeBuilder.h:
  • html/parser/HTMLViewSourceParser.cpp: (WebCore::HTMLViewSourceParser::forcePlaintext):
  • html/parser/HTMLViewSourceParser.h:
  • html/parser/TextDocumentParser.cpp: Added. (WebCore::TextDocumentParser::TextDocumentParser): (WebCore::TextDocumentParser::~TextDocumentParser): (WebCore::TextDocumentParser::insertFakePreElement):
  • html/parser/TextDocumentParser.h: Added. (WebCore::TextDocumentParser::create):
  • loader/TextDocument.cpp:
  • loader/TextDocument.h:
01:32 Changeset [66956] by vestbo@webkit.org

Implement MediaPlayerPrivate::platformMedia() for the Qt port

Reviewed by Andreas Kling.

https://bugs.webkit.org/show_bug.cgi?id=45264

00:23 Changeset [66955] by zherczeg@webkit.org

An individual renderer should be assigned to each SVGFE*Element class
https://bugs.webkit.org/show_bug.cgi?id=43954

Reviewed by Dirk Schulze.

WebCore:

RenderSVGResourceFilterPrimitive renderer is added to
the project, and assigned to each object, which class is
derived from SVGFilterPrimitiveStandardAttributes. The patch
mainly contains build system changes, and it fixes one layout
test in svg/dynamic-updates.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • rendering/RenderObject.h:

(WebCore::RenderObject::isSVGResourceFilterPrimitive):

  • rendering/RenderSVGResourceFilterPrimitive.cpp: Added.

(WebCore::RenderSVGResourceFilterPrimitive::RenderSVGResourceFilterPrimitive):

  • rendering/RenderSVGResourceFilterPrimitive.h: Added.

(WebCore::RenderSVGResourceFilterPrimitive::isSVGResourceFilterPrimitive):

  • rendering/SVGRenderTreeAsText.cpp:

(WebCore::writeSVGContainer):

  • svg/SVGFEDiffuseLightingElement.cpp:

(WebCore::SVGFEDiffuseLightingElement::svgAttributeChanged):

  • svg/SVGFELightElement.cpp:

(WebCore::SVGFELightElement::svgAttributeChanged):
(WebCore::SVGFELightElement::childrenChanged):

  • svg/SVGFEOffsetElement.cpp:

(WebCore::SVGFEOffsetElement::svgAttributeChanged):

  • svg/SVGFilterElement.h:
  • svg/SVGFilterPrimitiveStandardAttributes.cpp:

(WebCore::SVGFilterPrimitiveStandardAttributes::svgAttributeChanged):
(WebCore::SVGFilterPrimitiveStandardAttributes::childrenChanged):
(WebCore::SVGFilterPrimitiveStandardAttributes::createRenderer):

  • svg/SVGFilterPrimitiveStandardAttributes.h:

(WebCore::SVGFilterPrimitiveStandardAttributes::invalidate):

LayoutTests:

The layout test below is fixed by this patch.

  • platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-lighting-color-css-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-lighting-color-css-prop-expected.png:

09/07/10:

22:56 Changeset [66954] by weinig@apple.com

DatasetDOMStringMap does not have the right memory model
https://bugs.webkit.org/show_bug.cgi?id=45358

Reviewed by Dan Bernstein.

WebCore:

Test: fast/dom/dataset-gc.html

  • bindings/js/JSElementCustom.cpp:

(WebCore::JSElement::markChildren):
Mark the dataset if it exists.

  • dom/Element.cpp:

(WebCore::Element::optionalDataset):

  • dom/Element.h:

Expose a way to get the dataset or null (depending on if anyone thing
has forced its creation yet).

LayoutTests:

Test that the dataset persists gc.

  • fast/dom/dataset-gc-expected.txt: Added.
  • fast/dom/dataset-gc.html: Added.
  • fast/dom/script-tests/dataset-gc.js: Added.
22:54 Changeset [66953] by kinuko@chromium.org

2010-09-07 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by Ojan Vafai.

Enable incremental results.json generation for non-layout tests.
https://bugs.webkit.org/show_bug.cgi?id=45315

  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: Enable generate_incremental_results=True by default. (This still keeps to generate results.json.) Also add a code to upload results json files to the app-engine server. Need a chromium change to actually start the uploading.
  • TestResultServer/model/jsonresults.py: Make sure we save the file with test_type for incremental cases too.
22:30 Changeset [66952] by mrowe@apple.com

Versioning.

22:28 Changeset [66951] by mrowe@apple.com

New tag.

21:58 Changeset [66950] by kinuko@chromium.org

2010-09-07 Kinuko Yasuda <kinuko@chromium.org>

Unreviewed, another Qt release build fix attempt.

  • UIProcess/API/cpp/qt/WKURLQt.cpp:
21:52 Changeset [66949] by kinuko@chromium.org

2010-09-07 Kinuko Yasuda <kinuko@chromium.org>

Unreviewed, attempt to fix Qt release build.

  • UIProcess/API/cpp/qt/WKStringQt.cpp:
21:02 Changeset [66948] by commit-queue@webkit.org

2010-09-07 Jan E Hanssen <jhanssen@sencha.com>

Reviewed by Andreas Kling.

[Qt] Added test case for Path::length()
https://bugs.webkit.org/show_bug.cgi?id=45331

Also removed test case for Path::pointAtLength() that is now passing

  • platform/qt/svg/dom/path-pointAtLength-expected.txt: Removed.
  • svg/dom/path-totalLength-expected.txt: Added.
  • svg/dom/path-totalLength.html: Added.
  • svg/dom/script-tests/path-totalLength.js: Added. (getTotalLength):

2010-09-07 Jan E Hanssen <jhanssen@sencha.com>

Reviewed by Andreas Kling.

[Qt] Add a separate Path::closeCanvasSubpath() function for canvas paths
https://bugs.webkit.org/show_bug.cgi?id=45331

This is needed due to an adverse effect of the fix in 44061 that causes
certain paths not to be closed. This is not important for canvas paths
but it is for SVG paths, so splitting up the code in a generic (SVG)
case and one specialized for canvas.

Test: svg/dom/path-totalLength.html

  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::closePath):
  • platform/graphics/Path.h: (WebCore::Path::closeCanvasSubpath):
  • platform/graphics/qt/PathQt.cpp: (WebCore::Path::closeSubpath): (WebCore::Path::closeCanvasSubpath):
20:01 Changeset [66947] by dpranke@chromium.org

2010-09-07 Dirk Pranke <dpranke@chromium.org>

Unreviewed, build fix

Missed one test in mac_unittest.py in previous change; for some
reason the method is listed twice. I will fix both for now, but will
figure this out in a later, not-time-sensitive patch.

https://bugs.webkit.org/show_bug.cgi?id=45357

  • Scripts/webkitpy/layout_tests/port/mac_unittest.py:
19:56 Changeset [66946] by tkent@chromium.org

2010-09-07 Kent Tamura <tkent@chromium.org>

Reviewed by Tony Chang.

test-webkitpy: Fix load error of
webkitpy/layout_tests/port/factory_unittest.py on Win32 Python
https://bugs.webkit.org/show_bug.cgi?id=45356 Need a short

  • Scripts/webkitpy/layout_tests/port/server_process.py: Avoid to import fcntl on win32. Win32 Python doesn't have fcntl and we don't use server_process.py on Win32 Python. However unittest.py tries to load everything in a module.
19:23 Changeset [66945] by dpranke@chromium.org

2010-09-07 Dirk Pranke <dpranke@chromium.org>

Reviewed by Kent Tamura.

Fix regression introduced in previous change to new-run-webkit-tests
(bug 45090) to not try to run unittests for the Mac implementation
of the Port interface if we aren't running on a Mac.

Also fix the overrides implementation mock in the chromium unittests
to fix the case where there are overrides checked in that cause
problems.

https://bugs.webkit.org/show_bug.cgi?id=45357

  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  • Scripts/webkitpy/layout_tests/port/mac_unittest.py:
  • Scripts/webkitpy/layout_tests/port/port_testcase.py:
18:26 Changeset [66944] by ojan@chromium.org

2010-09-07 Ojan Vafai <ojan@chromium.org>

Reviewed by Kent Tamura.

Markup.waitUntilDone does not call Markup.noAutoDump without LayoutTestController
https://bugs.webkit.org/show_bug.cgi?id=45123

  • resources/dump-as-markup.js: (Markup.waitUntilDone):
18:15 Changeset [66943] by jamesr@google.com

2010-09-07 James Robinson <jamesr@chromium.org>

Compile fix attempt for windows.

18:10 Changeset [66942] by simon.fraser@apple.com

2010-09-07 Simon Fraser <simon.fraser@apple.com>

Reviewed by Chris Marrin.

Transform animations always run in software now
https://bugs.webkit.org/show_bug.cgi?id=45341

After r66339 we always fell into software animation, because we
failed to detect transform or opacity properties in the keyframes,
so would send an empty list of values to the GraphicsLayer.

Fixed by using CSSProperty values, rather than GraphicsLayer
values, when detecting the presence of properties in the keyframes.

Test: manual-tests/transition-accelerated.html

  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::startAnimation):
18:02 Changeset [66941] by crogers@google.com

2010-09-07 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

audio engine: add FFTFrame files
https://bugs.webkit.org/show_bug.cgi?id=34827

No new tests since audio API is not yet implemented.

  • platform/audio/FFTFrame.cpp: Added. (WebCore::FFTFrame::doPaddedFFT): (WebCore::FFTFrame::createInterpolatedFrame): (WebCore::FFTFrame::interpolateFrequencyComponents): (WebCore::FFTFrame::extractAverageGroupDelay): (WebCore::FFTFrame::addConstantGroupDelay): (WebCore::FFTFrame::print):
  • platform/audio/FFTFrame.h: Added. (WebCore::FFTFrame::fftSize): (WebCore::FFTFrame::log2FFTSize): (WebCore::FFTFrame::dspSplitComplex):
  • platform/audio/mac/FFTFrameMac.cpp: Added. (WebCore::FFTFrame::FFTFrame): (WebCore::FFTFrame::~FFTFrame): (WebCore::FFTFrame::multiply): (WebCore::FFTFrame::doFFT): (WebCore::FFTFrame::doInverseFFT): (WebCore::FFTFrame::fftSetupForSize): (WebCore::FFTFrame::cleanup): (WebCore::FFTFrame::realData): (WebCore::FFTFrame::imagData):
17:54 Changeset [66940] by jamesr@google.com

2010-09-07 Mihai Parparita <mihaip@chromium.org>

Reviewed by James Robinson.

Fix Windows build after r66936
https://bugs.webkit.org/show_bug.cgi?id=45348

Add symbol names that were missing from r66936.

17:50 Changeset [66939] by bfulgham@webkit.org

WebCore: Build fix, no review.

Provide stubs to allow WebKit.dll to build
for the WinCairo port.

  • platform/network/curl/ResourceRequest.h:

(WebCore::ResourceRequest::ResourceRequest):

  • platform/network/curl/ResourceResponse.h:

(WebCore::ResourceResponse::cfURLResponse):

WebKit2: Build correction, no review.

  • win/WebKit2.vcproj: Disable two unused files for

the WinCairo target.

17:48 Changeset [66938] by crogers@google.com

2010-09-07 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

Add AudioArray.h
https://bugs.webkit.org/show_bug.cgi?id=45204

No new tests since audio API is not yet implemented.

  • platform/audio/AudioArray.h: Added. (WebCore::AudioArray::AudioArray): (WebCore::AudioArray::zero): (WebCore::AudioArray::zeroRange): (WebCore::AudioArray::copyToRange):
17:46 Changeset [66937] by dpranke@chromium.org

2010-09-01 Dirk Pranke <dpranke@chromium.org>

Reviewed by Ojan Vafai.

new-run-webkit-tests: still more unit tests

Clean up and remove unnecessary code. Biggest notable change is
moving the chromium-specific imagediff code from port/base to
port/chromium.

Add more unit tests for run_webkit_tests.py, port/base.py,
port/factory.py, port/dryrun.py, and
layout_package/dump_render_tree_thread.py

This covers almost all of the generic and test code paths except for
a few error paths involving invalid or port-specific command line
arguments, and the code path for uploading results files to the
buildbots.

https://bugs.webkit.org/show_bug.cgi?id=45090

  • Scripts/webkitpy/layout_tests/data/failures/expected/hang.html: Added.
  • Scripts/webkitpy/layout_tests/data/http/tests/passes/text-expected.txt: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text-expected.txt.
  • Scripts/webkitpy/layout_tests/data/http/tests/passes/text.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text.html.
  • Scripts/webkitpy/layout_tests/data/http/tests/ssl/text-expected.txt: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text-expected.txt.
  • Scripts/webkitpy/layout_tests/data/http/tests/ssl/text.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text.html.
  • Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
  • Scripts/webkitpy/layout_tests/data/websocket/tests/passes/text-expected.txt: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text-expected.txt.
  • Scripts/webkitpy/layout_tests/data/websocket/tests/passes/text.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text.html.
  • Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
  • Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread_unittest.py: Added.
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/base_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/dryrun.py:
  • Scripts/webkitpy/layout_tests/port/factory_unittest.py:
  • Scripts/webkitpy/layout_tests/port/mac_unittest.py:
  • Scripts/webkitpy/layout_tests/port/port_testcase.py: Added.
  • Scripts/webkitpy/layout_tests/port/server_process.py:
  • Scripts/webkitpy/layout_tests/port/test.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
17:33 Changeset [66936] by commit-queue@webkit.org

2010-09-07 Mihai Parparita <mihaip@chromium.org>

Reviewed by Oliver Hunt.

pushState and replaceState do not clone RegExp objects correctly
https://bugs.webkit.org/show_bug.cgi?id=44718

Move internal representation of JSC::RegExp (which depends on wether
YARR and YARR_JIT is enabled) into RegExpRepresentation which can live
in the implementation only. This makes it feasible to use RegExp in
WebCore without bringing in all of YARR.

  • JavaScriptCore.exp: Export RegExp and RegExpObject functions that are needed inside WebCore's JSC bindings.
  • runtime/RegExp.cpp: (JSC::RegExpRepresentation::~RegExpRepresentation): (JSC::RegExp::RegExp): (JSC::RegExp::~RegExp): (JSC::RegExp::compile): (JSC::RegExp::match):
  • runtime/RegExp.h:

2010-09-07 Mihai Parparita <mihaip@chromium.org>

Reviewed by Oliver Hunt.

pushState and replaceState do not clone RegExp objects correctly
https://bugs.webkit.org/show_bug.cgi?id=44718

Make RegExp test of pushstate-object-types.html actually test a RegExp
value with flags.

Also adds ImageData since it can be serialized as of r54646.

  • fast/loader/stateobjects/pushstate-object-types-expected.txt:
  • fast/loader/stateobjects/pushstate-object-types.html:

2010-09-07 Mihai Parparita <mihaip@chromium.org>

Reviewed by Oliver Hunt.

pushState and replaceState do not clone RegExp objects correctly
https://bugs.webkit.org/show_bug.cgi?id=44718

Add RegExp support to the JSC implementation of SerializedScriptValue
(it stores the pattern and flags read from a RegExpObject, and creates
a new one on deserialization).

Tests: fast/loader/stateobjects/pushstate-object-types.html

  • ForwardingHeaders/runtime/RegExp.h: Added.
  • ForwardingHeaders/runtime/RegExpObject.h: Added.
  • bindings/js/SerializedScriptValue.cpp: (WebCore::CloneSerializer::dumpIfTerminal): (WebCore::CloneDeserializer::readTerminal):
17:32 Changeset [66935] by andersca@apple.com

Fix clang++ build.

Reviewed by Oliver Hunt.

  • Misc/WebLocalizableStrings.h:

Fix a struct/tag mismatch.

  • WebView/WebDeviceOrientationProviderMock.mm:

(-[WebDeviceOrientationProviderMock init]):
Remove stray semicolon.

  • WebView/WebViewData.h:

Remove unused class forward declaration.

16:56 Changeset [66934] by kbr@google.com

2010-09-07 Kenneth Russell <kbr@google.com>

Reviewed by James Robinson.

Fix OpenGL error reporting in WebGL layout test utilities
https://bugs.webkit.org/show_bug.cgi?id=45336

  • fast/canvas/webgl/resources/webgl-test.js: (getGLErrorAsString):
16:51 Changeset [66933] by andersca@apple.com

Fix clang++ build.

Reviewed by Sam Weinig.

  • UIProcess/API/C/WKAPICast.h:

Move all functions into the WebKit namespace.

  • UIProcess/API/C/cf/WKStringCF.cpp:

Add using namespace WebKit.

  • WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:

Move all functions into the WebKit namespace.

16:43 Changeset [66932] by tony@chromium.org

2010-09-07 Tony Chang <tony@chromium.org>

Unreviewed, updating chromium linux test expectations.

  • platform/chromium/drt_expectations.txt: Adding back a test removed in r66924 that is still failing.
16:40 WebKit Team edited by jamesr@google.com
(diff)
16:37 Changeset [66931] by jamesr@google.com

2010-09-07 James Robinson <jamesr@chromium.org>

Reviewed by Kenneth Russell.

Fix compile errors in DrawingBuffer if USE(ACCELERATED_COMPOSITING) is not set
https://bugs.webkit.org/show_bug.cgi?id=45324

Adds appropriate #if guards around code that has to deal directly with the compositor.
DrawingBuffer can still be used without the compositor as an off-screen rendering
region.

To test, compile without USE(ACCELERATED_COMPOSITING).

  • platform/graphics/chromium/DrawingBufferChromium.cpp: (WebCore::DrawingBuffer::~DrawingBuffer): (WebCore::DrawingBuffer::reset):
  • platform/graphics/gpu/DrawingBuffer.h:
16:34 Changeset [66930] by joepeck@webkit.org

2010-09-07 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by Darin Adler.

Provide a way to trigger a <select multiple> onchange event on changes
https://bugs.webkit.org/show_bug.cgi?id=45192

Testing the DOMHTMLSelectElement interface for selecting an
index in a <select> and triggering a "change" event. This also
tests for allowing multiple selections.

  • platform/mac/fast/objc/dom-html-select-activate-expected.txt: Added.
  • platform/mac/fast/objc/dom-html-select-activate.html: Added.

2010-09-07 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by Darin Adler.

Provide a way to trigger a <select multiple> onchange event on changes
https://bugs.webkit.org/show_bug.cgi?id=45192

Adds a selector on ObjCController for testing
-[DOMHTMLSelectElement _activateItemAtIndex:allowMultipleSelection:] and
its different uses.

  • DumpRenderTree/mac/ObjCController.m: (+[ObjCController isSelectorExcludedFromWebScript:]): (+[ObjCController webScriptNameForSelector:]): (-[ObjCController setSelectElement:selectedIndex:allowingMultiple:]):
16:33 Changeset [66929] by joepeck@webkit.org

2010-09-03 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by Darin Adler.

Provide a way to trigger a <select multiple> onchange event on changes
https://bugs.webkit.org/show_bug.cgi?id=45192

Test: LayoutTests/platform/mac/fast/objc/dom-html-select-activate.html

This provides a way for a WebKit client using the Obj-C DOM bindings to
trigger the "change" on a listbox select (<select multiple> or <select>
with size > 1). This is because when a select is rendered as a listbox
"change" events are triggered by mouse down events.

This adds -[DOMHTMLSelectElement _activateItemAtIndex:allowMultipleSelection:]
to allow for handling multiple selections if the select element is a
multi-select.

  • bindings/objc/DOMHTML.mm: (-[DOMHTMLSelectElement _activateItemAtIndex:allowMultipleSelection:]):
  • bindings/objc/DOMPrivate.h: unified the Category name. Was "FormsAutocomplete" now all are "FormAutocomplete".
  • dom/SelectElement.h:
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::setSelectedIndexByUser): listboxs need to be treated specially to fire their "change" event.
  • html/HTMLSelectElement.h:
  • wml/WMLSelectElement.cpp: (WebCore::WMLSelectElement::setSelectedIndexByUser):
16:28 Changeset [66928] by simon.fraser@apple.com

2010-09-07 Simon Fraser <simon.fraser@apple.com>

Reviewed by Darin Adler.

Minor WKCACFLayerRenderer cleanup
https://bugs.webkit.org/show_bug.cgi?id=45201

Call initD3DGeometry() from createRenderer, rather than duplicating the code.

No behavior changes.

  • platform/graphics/win/WKCACFLayerRenderer.cpp: (WebCore::WKCACFLayerRenderer::createRenderer):
16:27 Changeset [66927] by jamesr@google.com

2010-09-07 James Robinson <jamesr@chromium.org>

Rubber-stamped by Dimitri Glazkov.

Move myself from the committer to the reviewer list.

  • Scripts/webkitpy/common/config/committers.py:
16:26 Changeset [66926] by tony@chromium.org

2010-09-07 Tony Chang <tony@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] removing tests that pass after switch the bot back to hardy
https://bugs.webkit.org/show_bug.cgi?id=45327

  • platform/chromium/drt_expectations.txt:
16:19 Changeset [66925] by dglazkov@chromium.org

2010-09-07 Dimitri Glazkov <dglazkov@chromium.org>

[Chromium/DRT] Remove now-passing tests.

  • platform/chromium/drt_expectations.txt: A few more tests now pass, yay!
16:10 Changeset [66924] by tony@chromium.org

2010-09-07 Tony Chang <tony@chromium.org>

Reviewed by Kent Tamura.

turn off php output buffering in multipart tests
https://bugs.webkit.org/show_bug.cgi?id=45232

This was causing hanging multipart resources to not output anything.
On Lucid, the output buffer is enabled by default, but it's not enabled on Hardy.
http://www.php.net/manual/en/function.ob-end-flush.php

  • http/tests/multipart/resources/multipart-wait-before-boundary.php:
  • http/tests/multipart/resources/multipart.php:
  • platform/chromium/drt_expectations.txt:
16:05 Changeset [66923] by vangelis@chromium.org

2010-09-07 Vangelis Kokkevis <vangelis@chromium.org>

Reviewed by Darin Fisher.

[chromium] Reset the owner of PlatformLayer's once the GraphicsLayer they are associated with
gets destroyed.
https://bugs.webkit.org/show_bug.cgi?id=45329

Test: Fixes UI test failures downstream for all the Media tests when run on the buildbots (machines without GPUs).

  • platform/graphics/chromium/GraphicsLayerChromium.cpp: (WebCore::GraphicsLayerChromium::~GraphicsLayerChromium):
16:03 Changeset [66922] by zmo@google.com

2010-09-07 Zhenyao Mo <zmo@google.com>

Unreviewed.

Add fast/canvas/webgl/gl-teximage.html (failing on chromium mac bot) to chromium/test_expectations.

  • platform/chromium/test_expectations.txt:
15:46 Changeset [66921] by dglazkov@chromium.org

2010-09-07 Dimitri Glazkov <dglazkov@chromium.org>

Unreviewed, trivial expectations update.

[Chromium/DRT] Remove expectation of crash for
fast/js/date-preserve-milliseconds.html. It's now passing.

  • platform/chromium/drt_expectations.txt: Remove now-passing test.
15:43 Changeset [66920] by crogers@google.com

audio branch: more code cleanup in preparation for landing in trunk

15:43 Changeset [66919] by crogers@google.com

audio branch: massive munge to use adoptPtr() instead of naked operator new

15:42 Changeset [66918] by abarth@webkit.org

2010-09-07 Adam Barth <abarth@webkit.org>

Minor tweaks to the reviewtool UI.

Rename Cancel to Discard to make it more clear what the button does.
Also, move the style declaration for the focus ring later in the sheet
so it works.

  • PrettyPatch/PrettyPatch.rb:
  • code-review.js:
15:37 Changeset [66917] by dglazkov@chromium.org

2010-09-07 Dimitri Glazkov <dglazkov@chromium.org>

Unreviewed, trivial test move.

[Chromium/DRT] Correct a mistake made eons ago (probably by me)
and make the test expectations agnostic to the flavor of Windows.

  • platform/chromium-win-xp/fast/multicol/client-rects-expected.checksum: Removed.
  • platform/chromium-win-xp/fast/multicol/client-rects-expected.png: Removed.
  • platform/chromium-win/fast/multicol/client-rects-expected.checksum: Updated.
  • platform/chromium-win/fast/multicol/client-rects-expected.png: Updated.
15:35 Changeset [66916] by andersca@apple.com

<rdar://problem/8381749> -Wcast-align warning emitted when building with clang

Reviewed by Darin Adler.

JavaScriptCore:

Remove the -Wcast-align-warning since it isn't really useful, and clang is more aggressive about warning than gcc.

  • Configurations/Base.xcconfig:

JavaScriptGlue:

Remove the -Wcast-align-warning since it isn't really useful, and clang is more aggressive about warning than gcc.

  • Configurations/Base.xcconfig:

WebCore:

Remove the -Wcast-align-warning since it isn't really useful, and clang is more aggressive about warning than gcc.

  • Configurations/Base.xcconfig:

WebKit/mac:

Remove the -Wcast-align-warning since it isn't really useful, and clang is more aggressive about warning than gcc.

  • Configurations/Base.xcconfig:

WebKit2:

Remove the -Wcast-align-warning since it isn't really useful, and clang is more aggressive about warning than gcc.

  • Configurations/Base.xcconfig:
15:21 Changeset [66915] by zmo@google.com

2010-09-07 Zhenyao Mo <zmo@google.com>

Unreviewed.

Remove passing tests from chromium/test_expectations.

  • platform/chromium/test_expectations.txt:
15:21 Changeset [66914] by tony@chromium.org

2010-09-07 Tony Chang <tony@chromium.org>

Reviewed by Darin Fisher.

[chromium] Make a public flag for how DRT generates bitmaps on Linux
https://bugs.webkit.org/show_bug.cgi?id=45133

This is so it's possible for me to fix
http://code.google.com/p/chromium/issues/detail?id=21386 .

  • public/WebKit.h: Add areLayoutTestImagesOpaque()
  • src/WebKit.cpp: (WebKit::areLayoutTestImagesOpaque):

2010-09-07 Tony Chang <tony@chromium.org>

Reviewed by Darin Fisher.

[chromium] Make a public flag for how DRT generates bitmaps on Linux
https://bugs.webkit.org/show_bug.cgi?id=45133

  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::dumpImage):
15:08 Changeset [66913] by dglazkov@chromium.org

Create branch for Chromium 517.

15:07 Changeset [66912] by dglazkov@chromium.org

Create a directory for Chromium branches

14:57 Changeset [66911] by inferno@chromium.org

2010-09-07 Abhishek Arya <inferno@chromium.org>

Reviewed by Darin Adler.

Remove redundant bounds check in originalText(). Add bounds check
to previousCharacter(). No need of start() > 0 check since m_start
is unsigned and we already do start() null check inside function.
https://bugs.webkit.org/show_bug.cgi?id=45303

Test: fast/text/one-letter-transform-crash.html

  • rendering/RenderTextFragment.cpp: (WebCore::RenderTextFragment::originalText): (WebCore::RenderTextFragment::previousCharacter):

2010-09-07 Abhishek Arya <inferno@chromium.org>

Reviewed by Darin Adler.

Tests that we dont hit assert i < m_length when trying to read
previousCharacter for text fragments.
https://bugs.webkit.org/show_bug.cgi?id=45303

  • fast/text/one-letter-transform-crash-expected.txt: Added.
  • fast/text/one-letter-transform-crash.html: Added.
14:53 Changeset [66910] by zmo@google.com

2010-09-07 Zhenyao Mo <zmo@google.com>

Unreviewed.

Remove passing tests from chromium/test_expectations.

  • platform/chromium/test_expectations.txt:
14:50 Changeset [66909] by dglazkov@chromium.org

2010-09-07 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by David Levin.

Remove flakiness expectation for tests, fixed by r66861.
https://bugs.webkit.org/show_bug.cgi?id=45311

  • platform/chromium/drt_expectations.txt: Removed tests.
14:24 Changeset [66908] by kbr@google.com

2010-09-07 Kenneth Russell <kbr@google.com>

Reviewed by Dimitri Glazkov.

Regression in JPEG texture uploads on Mac OS X
https://bugs.webkit.org/show_bug.cgi?id=45316

Fixed regression introduced in
https://bugs.webkit.org/show_bug.cgi?id=44566 . Added regression
test covering this case to gl-teximage.html in Khronos repository
and synced test with WebKit's version.

  • platform/graphics/cg/GraphicsContext3DCG.cpp: (WebCore::GraphicsContext3D::getImageData):

2010-09-07 Kenneth Russell <kbr@google.com>

Reviewed by Dimitri Glazkov.

Regression in JPEG texture uploads on Mac OS X
https://bugs.webkit.org/show_bug.cgi?id=45316

Fixed regression introduced in
https://bugs.webkit.org/show_bug.cgi?id=44566 . Added regression
test covering this case to gl-teximage.html in Khronos repository
and synced test with WebKit's version.

  • fast/canvas/webgl/gl-teximage-expected.txt:
  • fast/canvas/webgl/gl-teximage.html:
  • fast/canvas/webgl/resources/blue-1x1.jpg: Added.
14:07 Changeset [66907] by weinig@apple.com

Another windows fix.

  • UIProcess/win/WebView.cpp:
14:00 Changeset [66906] by tkent@chromium.org

2010-09-07 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[DRT/Chromium] Implement --check-layout-test-sys-deps
https://bugs.webkit.org/show_bug.cgi?id=45283

  • DumpRenderTree/chromium/DumpRenderTree.cpp: (main): Check --check-layout-test-sys-deps and call checkLayoutTestSystemDependencies().
  • DumpRenderTree/chromium/TestShell.h: Declare checkLayoutTestSystemDependencies().
  • DumpRenderTree/chromium/TestShellGtk.cpp: (checkLayoutTestSystemDependencies): Add an empty implementation.
  • DumpRenderTree/chromium/TestShellMac.mm: (checkLayoutTestSystemDependencies): Add an empty implementation.
  • DumpRenderTree/chromium/TestShellWin.cpp: (checkLayoutTestSystemDependencies): Port similar function of test_shell.
13:59 Changeset [66905] by weinig@apple.com

Try and fix windows.

  • UIProcess/WebEditCommandProxy.h:
13:18 Changeset [66904] by mrobinson@webkit.org

2010-09-07 Martin Robinson <mrobinson@igalia.com>

Add rendering/ColumnInfo.h to the sources list.

  • GNUmakefile.am:
13:07 BuildBot edited by tony@chromium.org
(diff)
12:59 Changeset [66903] by hyatt@apple.com

https://bugs.webkit.org/show_bug.cgi?id=45317, encapsulate multi-column rectangle information.

Reviewed by Beth Dakin.

  • WebCore.xcodeproj/project.pbxproj:
  • rendering/ColumnInfo.h: Added.

(WebCore::ColumnInfo::ColumnInfo):
(WebCore::ColumnInfo::desiredColumnWidth):
(WebCore::ColumnInfo::setDesiredColumnWidth):
(WebCore::ColumnInfo::desiredColumnCount):
(WebCore::ColumnInfo::setDesiredColumnCount):
(WebCore::ColumnInfo::columnCount):
(WebCore::ColumnInfo::columnRectAt):
(WebCore::ColumnInfo::clearColumns):
(WebCore::ColumnInfo::addColumnRect):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paintColumnRules):
(WebCore::RenderBlock::paintColumnContents):
(WebCore::RenderBlock::lowestPosition):
(WebCore::RenderBlock::rightmostPosition):
(WebCore::RenderBlock::leftmostPosition):
(WebCore::RenderBlock::hitTestColumns):
(WebCore::RenderBlock::setDesiredColumnCountAndWidth):
(WebCore::RenderBlock::desiredColumnWidth):
(WebCore::RenderBlock::desiredColumnCount):
(WebCore::RenderBlock::columnInfo):
(WebCore::RenderBlock::layoutColumns):
(WebCore::RenderBlock::adjustPointToColumnContents):
(WebCore::RenderBlock::adjustRectForColumns):
(WebCore::RenderBlock::adjustForColumns):

  • rendering/RenderBlock.h:
  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintChildLayerIntoColumns):
(WebCore::RenderLayer::hitTestChildLayerColumns):

12:56 Changeset [66902] by bfulgham@webkit.org

2010-09-07 Brent Fulgham <bfulgham@webkit.org>

Reviewed by Adam Roben.

Clean up a potential resource leak.
https://bugs.webkit.org/show_bug.cgi?id=45198

Several bitmap device context were being created and used,
and destroyed without returning the context to its original
state. This showed up as bitmap leaks in BoundsChecker.

  • FullscreenVideoController.cpp:
  • WebView.cpp: (WebView::scrollBackingStore): (WebView::paint):
12:44 BuildBot edited by tony@chromium.org
(diff)
12:41 Changeset [66901] by weinig@apple.com

Fix incorrect parameter name.

Reviewed by Darin Adler.

  • UIProcess/API/mac/PageClientImpl.mm:
12:40 Changeset [66900] by mitz@apple.com

<rdar://problem/7794761> Floats inside of multicol fail to hit test
https://bugs.webkit.org/show_bug.cgi?id=44730

Reviewed by Dave Hyatt.

WebCore:

Test: fast/multicol/hit-test-float.html

Factored float hit-testing out of nodeAtPoint so that hitTestColumns could
call it with column-adjusted coordinates.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::nodeAtPoint):
(WebCore::RenderBlock::hitTestFloats):
(WebCore::RenderBlock::hitTestColumns):

  • rendering/RenderBlock.h:

LayoutTests:

  • fast/multicol/hit-test-float-expected.txt: Added.
  • fast/multicol/hit-test-float.html: Added.
12:31 Changeset [66899] by commit-queue@webkit.org

2010-09-07 François Sausset <sausset@gmail.com>

Reviewed by Beth Dakin.

Update to test the display attribute on the math element.
https://bugs.webkit.org/show_bug.cgi?id=44206

  • mathml/presentation/attributes.xhtml:
  • platform/mac/mathml/presentation/attributes-expected.checksum:
  • platform/mac/mathml/presentation/attributes-expected.png:
  • platform/mac/mathml/presentation/attributes-expected.txt:

2010-09-07 François Sausset <sausset@gmail.com>

Reviewed by Beth Dakin.

<math> element should be centered when display attribute set to block.
https://bugs.webkit.org/show_bug.cgi?id=44206

Test: mathml/presentation/attributes.xhtml

  • css/mathml.css: (math[display="block"]):
12:21 Changeset [66898] by jberlin@webkit.org

2010-09-07 Jessie Berlin <jberlin@apple.com>

Unreviewed. Mac build fix.

  • MiniBrowser/mac/WebBundle/WebBundleMain.m: (didClearWindowObjectForFrame):
12:18 Changeset [66897] by weinig@apple.com

Add support for Undo/Redo
<rdar://problem/7660519>
https://bugs.webkit.org/show_bug.cgi?id=42781

Reviewed by Darin Adler.

Adds platform independent parts of Undo/Redo support and the mac
platform support.

To work around the common assumption made by platforms, that a redo
item will be added synchronously while an undo is in progress, we
ignore the calls from WebCore to add redo items, and instead add add
them after telling WebCore to unapply the EditCommand. We similarly
need to ignore undos, that take place during a redo, and force the
addition ourselves.

  • Shared/CoreIPCSupport/WebPageMessageKinds.h:
  • Shared/CoreIPCSupport/WebPageProxyMessageKinds.h:

Add new messages.

  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm:

(-[WebEditCommandObjC initWithWebEditCommandProxy:WebKit::]):
(-[WebEditCommandObjC WebKit::]):
(-[WebEditorUndoTargetObjC undoEditing:]):
(-[WebEditorUndoTargetObjC redoEditing:]):
(WebKit::PageClientImpl::PageClientImpl):
(WebKit::nameForEditAction):
(WebKit::PageClientImpl::registerEditCommand):
(WebKit::PageClientImpl::clearAllEditCommands):

  • UIProcess/API/qt/qwkpage.cpp:

(QWKPagePrivate::registerEditCommand):
(QWKPagePrivate::clearAllEditCommands):

  • UIProcess/API/qt/qwkpage_p.h:
  • UIProcess/PageClient.h:
  • UIProcess/win/WebView.cpp:

(WebKit::WebView::registerEditCommand):
(WebKit::WebView::clearAllEditCommands):

  • UIProcess/win/WebView.h:

Add platform specific hooks for undo/redo.

  • UIProcess/WebEditCommandProxy.cpp: Added.

(WebKit::WebEditCommandProxy::WebEditCommandProxy):
(WebKit::WebEditCommandProxy::~WebEditCommandProxy):
(WebKit::WebEditCommandProxy::unapply):
(WebKit::WebEditCommandProxy::reapply):

  • UIProcess/WebEditCommandProxy.h: Added.

(WebKit::WebEditCommandProxy::create):
(WebKit::WebEditCommandProxy::commandID):
(WebKit::WebEditCommandProxy::editAction):
(WebKit::WebEditCommandProxy::invalidate):
A proxy for the WebEditCommands in the WebProcess. These are owned
by the platform back/forward list, with a weak reference back to the
WebPageProxy (which holds a weakset of live WebEditCommandProxys).

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::close):
(WebKit::WebPageProxy::didReceiveMessage):
(WebKit::WebPageProxy::registerEditCommandForUndo):
(WebKit::WebPageProxy::clearAllEditCommands):
(WebKit::WebPageProxy::registerEditCommandForRedo):
(WebKit::WebPageProxy::addEditCommand):
(WebKit::WebPageProxy::removeEditCommand):
(WebKit::WebPageProxy::processDidExit):

  • UIProcess/WebPageProxy.h:

Forward messages.

  • WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::WebEditorClient::registerCommandForUndo):
(WebKit::WebEditorClient::registerCommandForRedo):
(WebKit::WebEditorClient::clearUndoRedoOperations):
Send undo/redo registration and clearing to the UIProcess.

  • WebProcess/WebPage/WebEditCommand.cpp: Added.

(WebKit::generateCommandID):
(WebKit::WebEditCommand::WebEditCommand):

  • WebProcess/WebPage/WebEditCommand.h: Added.

(WebKit::WebEditCommand::create):
(WebKit::WebEditCommand::command):
(WebKit::WebEditCommand::commandID):
Wrapper for WebCore::EditCommand, with an added unique ID.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):
(WebKit::WebPage::webEditCommand):
(WebKit::WebPage::addWebEditCommand):
(WebKit::WebPage::removeWebEditCommand):
(WebKit::WebPage::unapplyEditCommand):
(WebKit::WebPage::reapplyEditCommand):
(WebKit::WebPage::didRemoveEditCommand):
(WebKit::WebPage::didReceiveMessage):

  • WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::isInRedo):
Forward messages.

  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:

Add new files.

11:46 Changeset [66896] by simon.fraser@apple.com

2010-09-07 Simon Fraser <simon.fraser@apple.com>

Reviewed by Chris Marrin.

Avoid use of CA plugin in compositing tests so that they work on Windows
https://bugs.webkit.org/show_bug.cgi?id=45312

Convert tests to use <video> rather than a plugin, so that they have similar
compositing behavior on Windows.

  • compositing/geometry/limit-layer-bounds-clipping-ancestor-expected.txt:
  • compositing/geometry/limit-layer-bounds-clipping-ancestor.html:
  • compositing/geometry/limit-layer-bounds-fixed-positioned-expected.txt:
  • compositing/geometry/limit-layer-bounds-fixed-positioned.html:
  • compositing/geometry/limit-layer-bounds-overflow-repaint.html:
  • compositing/geometry/limit-layer-bounds-overflow-root-expected.txt:
  • compositing/geometry/limit-layer-bounds-overflow-root.html:
  • compositing/geometry/limit-layer-bounds-positioned-expected.txt:
  • compositing/geometry/limit-layer-bounds-positioned-transition-expected.txt:
  • compositing/geometry/limit-layer-bounds-positioned-transition.html:
  • compositing/geometry/limit-layer-bounds-positioned.html:
  • compositing/geometry/limit-layer-bounds-transformed-expected.txt:
  • compositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt:
  • compositing/geometry/limit-layer-bounds-transformed-overflow.html:
  • compositing/geometry/limit-layer-bounds-transformed.html:
  • platform/mac/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.txt:
11:29 Changeset [66895] by eric.carlson@apple.com

2010-09-07 Eric Carlson <eric.carlson@apple.com>

Reviewed by Darin Adler.

Media elements should derive from ActiveDOMObjects
https://bugs.webkit.org/show_bug.cgi?id=45306
<rdar://problem/7929062>

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement): Initialize ActiveDOMObject (WebCore::HTMLMediaElement::stop): Call suspend, we want to do the same thing in both cases. (WebCore::HTMLMediaElement::suspend): Rename from documentWillBecomeInactive. (WebCore::HTMLMediaElement::resume): Rename from documentDidBecomeActive. (WebCore::HTMLMediaElement::hasPendingActivity): Return true if the event queue is not empty so the element can't be collected before they are sent.
  • html/HTMLMediaElement.h: (WebCore::HTMLMediaElement::canSuspend):
11:14 ImprovingLifeOnWindows edited by aroben@apple.com
Removed the item about copying to %TMP%, since we don't do that anymore. (diff)
11:09 Changeset [66894] by jberlin@webkit.org

2010-09-07 Jessie Berlin <jberlin@apple.com>

Reviewed by Darin Adler.

Indicate which one of the ScriptWorlds for a Frame the Window Object has been cleared for
https://bugs.webkit.org/show_bug.cgi?id=45217

WebKit2:

  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp: (WebKit::InjectedBundlePageLoaderClient::didClearWindowObjectForFrame):
  • WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::dispatchDidClearWindowObjectInWorld):

WebKitTools:

Make WebKitTestRunner work with this change.

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::didClearWindowForFrame): Make sure the ScriptWorld here is the normal world, since that is no longer being done in WebFrameLoaderClient.
  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
11:02 Changeset [66893] by zmo@google.com

2010-09-07 Zhenyao Mo <zmo@google.com>

Unreviewed.

Add fast/text/atsui-spacing-features.html to test_expectations (failing on LINUX).

  • platform/chromium/test_expectations.txt:
10:38 Changeset [66892] by dglazkov@chromium.org

2010-09-07 Dimitri Glazkov <dglazkov@chromium.org>

Unreviewed, rolling out r66886.
http://trac.webkit.org/changeset/66886
https://bugs.webkit.org/show_bug.cgi?id=45112

Made

  • platform/chromium/GeolocationServiceChromium.cpp:
  • platform/chromium/GeolocationServiceChromium.h:

2010-09-07 Dimitri Glazkov <dglazkov@chromium.org>

Unreviewed, rolling out r66886.
http://trac.webkit.org/changeset/66886
https://bugs.webkit.org/show_bug.cgi?id=45112

Made

  • public/WebGeolocationService.h:
  • src/WebGeolocationServiceBridgeImpl.cpp: (WebKit::WebGeolocationServiceBridgeImpl::WebGeolocationServiceBridgeImpl): (WebKit::WebGeolocationServiceBridgeImpl::~WebGeolocationServiceBridgeImpl): (WebKit::WebGeolocationServiceBridgeImpl::startUpdating): (WebKit::WebGeolocationServiceBridgeImpl::stopUpdating): (WebKit::WebGeolocationServiceBridgeImpl::suspend): (WebKit::WebGeolocationServiceBridgeImpl::resume): (WebKit::WebGeolocationServiceBridgeImpl::attachBridgeIfNeeded): (WebKit::WebGeolocationServiceBridgeImpl::setIsAllowed): (WebKit::WebGeolocationServiceBridgeImpl::setLastPosition): (WebKit::WebGeolocationServiceBridgeImpl::setLastError): (WebKit::WebGeolocationServiceBridgeImpl::getWebViewClient): (WebKit::WebGeolocationServiceBridgeImpl::onWebGeolocationServiceDestroyed):
  • src/WebGeolocationServiceMock.cpp:
10:22 Changeset [66891] by zmo@google.com

2010-09-07 Zhenyao Mo <zmo@google.com>

Unreviewed.

Rebaseline WIN LINUX for a few svg/dynamic-updates tests.

  • platform/chromium-linux/svg/dynamic-updates/SVGFEPointLightElement-dom-x-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEPointLightElement-dom-x-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEPointLightElement-dom-y-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEPointLightElement-dom-y-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEPointLightElement-dom-z-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEPointLightElement-dom-z-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEPointLightElement-svgdom-x-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEPointLightElement-svgdom-x-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEPointLightElement-svgdom-y-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEPointLightElement-svgdom-y-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEPointLightElement-svgdom-z-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEPointLightElement-svgdom-z-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEPointLightElement-dom-x-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEPointLightElement-dom-x-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEPointLightElement-dom-y-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEPointLightElement-dom-y-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEPointLightElement-dom-z-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEPointLightElement-dom-z-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEPointLightElement-svgdom-x-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEPointLightElement-svgdom-x-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEPointLightElement-svgdom-y-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEPointLightElement-svgdom-y-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEPointLightElement-svgdom-z-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEPointLightElement-svgdom-z-prop-expected.png: Added.
10:13 Changeset [66890] by mrobinson@webkit.org

2010-09-07 Martin Robinson <mrobinson@igalia.com>

Small build fix. Remove libWebCoreJS from CLEAN_FILES, as it
is no longer built.

  • GNUmakefile.am: Remove reference to libWebCoreJS.
10:10 Changeset [66889] by mrobinson@webkit.org

2010-09-07 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] [REGRESSION] r66848 caused a crash in testwebview
https://bugs.webkit.org/show_bug.cgi?id=45298

No new tests as this fixes a test failure.

  • platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollView::setGtkAdjustments): Don't actually attach the scrollbar adjustments unless this is a main frame ScrollView. If we do Scrollbars will be cast incorrectly to MainFrameScrollbarGtk, causing a segfault.
09:44 Changeset [66888] by commit-queue@webkit.org

2010-09-07 Kristian Monsen <kristianm@google.com>

Reviewed by Steve Block.

Compile fix for Android.
https://bugs.webkit.org/show_bug.cgi?id=45292
Explicitly add needed header for
STRING_TO_V8PARAMETER_EXCEPTION_BLOCK as they do not get
included through other headers on Android.

No new tests, just a compile fix.

  • bindings/scripts/CodeGeneratorV8.pm:
09:40 Changeset [66887] by mrobinson@webkit.org

2010-09-07 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Fix some feature guards
https://bugs.webkit.org/show_bug.cgi?id=45302

No new tests as this is just a build change.

  • platform/graphics/gstreamer/DataSourceGStreamer.cpp: Guard with #if ENABLE(VIDEO)
  • platform/graphics/gstreamer/DataSourceGStreamer.h: Ditto.
  • platform/graphics/gstreamer/GOwnPtrGStreamer.cpp: Ditto.
  • platform/graphics/gstreamer/GOwnPtrGStreamer.h: Ditto.
  • platform/graphics/gstreamer/GStreamerGWorld.cpp: Ditto.
  • platform/graphics/gstreamer/GStreamerGWorld.h: Ditto.
  • platform/graphics/gstreamer/ImageGStreamer.h: Ditto.
  • platform/graphics/gstreamer/ImageGStreamerCG.mm: Ditto.
  • platform/graphics/gstreamer/ImageGStreamerCairo.cpp: Ditto.
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: Ditto.
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h: Ditto.
  • platform/graphics/gstreamer/PlatformVideoWindow.h: Ditto.
  • platform/graphics/gstreamer/PlatformVideoWindowEfl.cpp: Ditto.
  • platform/graphics/gstreamer/PlatformVideoWindowGtk.cpp: Ditto.
  • platform/graphics/gstreamer/VideoSinkGStreamer.cpp: Ditto.
  • platform/graphics/gstreamer/VideoSinkGStreamer.h: Ditto.
  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp: Ditto.
  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.h: Ditto.
  • platform/gtk/GeolocationServiceGtk.cpp: Guard with ENABLE(GEOLOCATION)
  • platform/gtk/GeolocationServiceGtk.h: Ditto.

2010-09-07 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Fix some feature guards
https://bugs.webkit.org/show_bug.cgi?id=45302

  • webkit/webkitprivate.h: Add ENABLE(VIDEO) guards for video specific members.
09:02 Changeset [66886] by jorlow@chromium.org

2010-09-07 Jonathan Dixon <joth@chromium.org>

Reviewed by Jeremy Orlow.

Access to out-of-scope WebGeolocationServiceBridgeImpl
https://bugs.webkit.org/show_bug.cgi?id=45112

Add missing virtual destructor to the abstract base class.

  • platform/chromium/GeolocationServiceChromium.cpp: (WebCore::GeolocationServiceBridge::~GeolocationServiceBridge):
  • platform/chromium/GeolocationServiceChromium.h:

2010-09-07 Jonathan Dixon <joth@chromium.org>

Reviewed by Jeremy Orlow.

Access to out-of-scope WebGeolocationServiceBridgeImpl
https://bugs.webkit.org/show_bug.cgi?id=45112

Keep the WebGeolocationService pointer for lifetime of the bridge, to
ensure it can be detached reliably

  • public/WebGeolocationServiceBridge.h: (WebKit::WebGeolocationServiceBridge::~WebGeolocationServiceBridge):
  • src/WebGeolocationServiceBridgeImpl.cpp: (WebKit::WebGeolocationServiceBridgeImpl::WebGeolocationServiceBridgeImpl): (WebKit::WebGeolocationServiceBridgeImpl::~WebGeolocationServiceBridgeImpl): (WebKit::WebGeolocationServiceBridgeImpl::startUpdating): (WebKit::WebGeolocationServiceBridgeImpl::stopUpdating): (WebKit::WebGeolocationServiceBridgeImpl::suspend): (WebKit::WebGeolocationServiceBridgeImpl::resume): (WebKit::WebGeolocationServiceBridgeImpl::attachBridgeIfNeeded):
08:55 Changeset [66885] by mrobinson@webkit.org

2010-09-07 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] [REGRESSION] r66848 caused a crash in testwebview
https://bugs.webkit.org/show_bug.cgi?id=45298

No new tests as this fixes a test failure.

  • platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollView::setGtkAdjustments): Don't actually attach the scrollbar adjustments unless this is a main frame ScrollView. If we do Scrollbars will be cast incorrectly to MainFrameScrollbarGtk, causing a segfault.
08:55 Changeset [66884] by satish@chromium.org

2010-09-07 Satish Sampath <satish@chromium.org>

Reviewed by Jeremy Orlow.

Disable a timing out speech input test for generated clicks.
https://bugs.webkit.org/show_bug.cgi?id=45297

  • platform/chromium/test_expectations.txt:
08:15 Changeset [66883] by zoltan@webkit.org

2010-09-07 Zoltan Horvath <zoltan@webkit.org>

Reviewed by Darin Adler.

REGRESSION(66741): Undefined pthread macros
https://bugs.webkit.org/show_bug.cgi?id=45246

PTHREAD_MUTEX_NORMAL and PTHREAD_MUTEX_DEFAULT (introduced in r60487) are not defined on Linux,
but used in a statement. Add an additional check to test this.

  • wtf/FastMalloc.cpp: (WTF::TCMalloc_PageHeap::initializeScavenger):
07:53 Changeset [66882] by agl@chromium.org

2010-09-07 Adam Langley <agl@chromium.org>

Reviewed by Tony Chang.

[chromium] Fix complex text word spacing on Linux.

I broke complex text word spacing with r66689. I misnamed a
variable in the original code |glyphIndex| when it was
actually indexing code points. That meant that I compared it
against the wrong limit when working around Harfbuzz issues
and neatly disabled word spacing.

https://bugs.webkit.org/show_bug.cgi?id=45191

Test: fast/text/atsui-spacing-features.html

  • platform/graphics/chromium/FontLinux.cpp: (WebCore::TextRunWalker::setGlyphXPositions):
07:07 Changeset [66881] by commit-queue@webkit.org

2010-09-07 Renata Hodovan <reni@inf.u-szeged.hu>

Reviewed by Dirk Schulze.

SVGFilterElement & SVGFE*Element don't support dynamic invalidation, when attributes change.
https://bugs.webkit.org/show_bug.cgi?id=42244

Adding layout tests for fePointLight dynamic changes.
feSpotLight svgAttributeChanged covered the pointLight case as well so we don't need new C++ code.

  • platform/mac/svg/dynamic-updates/SVGFEPointLightElement-dom-x-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEPointLightElement-dom-x-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEPointLightElement-dom-y-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEPointLightElement-dom-y-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEPointLightElement-dom-z-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEPointLightElement-dom-z-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEPointLightElement-svgdom-x-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEPointLightElement-svgdom-x-prop-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEPointLightElement-svgdom-y-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEPointLightElement-svgdom-y-prop-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEPointLightElement-svgdom-z-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEPointLightElement-svgdom-z-prop-expected.png: Added.
  • svg/dynamic-updates/SVGFEPointLightElement-dom-x-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGFEPointLightElement-dom-x-attr.html: Added.
  • svg/dynamic-updates/SVGFEPointLightElement-dom-y-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGFEPointLightElement-dom-y-attr.html: Added.
  • svg/dynamic-updates/SVGFEPointLightElement-dom-z-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGFEPointLightElement-dom-z-attr.html: Added.
  • svg/dynamic-updates/SVGFEPointLightElement-svgdom-x-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFEPointLightElement-svgdom-x-prop.html: Added.
  • svg/dynamic-updates/SVGFEPointLightElement-svgdom-y-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFEPointLightElement-svgdom-y-prop.html: Added.
  • svg/dynamic-updates/SVGFEPointLightElement-svgdom-z-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFEPointLightElement-svgdom-z-prop.html: Added.
  • svg/dynamic-updates/script-tests/SVGFEPointLightElement-dom-x-attr.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFEPointLightElement-dom-y-attr.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFEPointLightElement-dom-z-attr.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFEPointLightElement-svgdom-x-prop.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFEPointLightElement-svgdom-y-prop.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFEPointLightElement-svgdom-z-prop.js: Added. (executeTest):
06:44 Changeset [66880] by commit-queue@webkit.org

2010-09-07 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: disable debugger tests on qt
https://bugs.webkit.org/show_bug.cgi?id=45290

  • platform/gtk/Skipped:
  • platform/qt/Skipped:
06:27 Changeset [66879] by satish@chromium.org

2010-09-07 Satish Sampath <satish@chromium.org>

Reviewed by Steve Block.

Fix speech button's hit test logic for RTL rendering.
https://bugs.webkit.org/show_bug.cgi?id=45288

  • fast/speech/input-text-speechbutton.html: Added RTL test case and merged JS code.
  • fast/speech/script-tests/input-text-speechbutton.js: Removed.

2010-09-07 Satish Sampath <satish@chromium.org>

Reviewed by Steve Block.

Fix speech button's hit test logic for RTL rendering.
https://bugs.webkit.org/show_bug.cgi?id=45288

  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::forwardEvent):
05:47 Changeset [66878] by satish@chromium.org

2010-09-07 Satish Sampath <satish@chromium.org>

Reviewed by Jeremy Orlow.

Ignore programmatic clicks on speech input button for security reasons.
https://bugs.webkit.org/show_bug.cgi?id=45181

  • fast/speech/speech-button-ignore-generated-events-expected.txt: Added.
  • fast/speech/speech-button-ignore-generated-events.html: Added.

2010-09-07 Satish Sampath <satish@chromium.org>

Reviewed by Jeremy Orlow.

Ignore programmatic clicks on speech input button for security reasons.
https://bugs.webkit.org/show_bug.cgi?id=45181

Test: fast/speech/speech-button-ignore-generated-events.html

  • rendering/TextControlInnerElements.cpp: (WebCore::InputFieldSpeechButtonElement::defaultEventHandler):
05:28 Changeset [66877] by commit-queue@webkit.org

2010-09-07 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: upstream two debugger tests
https://bugs.webkit.org/show_bug.cgi?id=45262

  • inspector/debugger-pause-on-breakpoint-expected.txt: Added.
  • inspector/debugger-pause-on-breakpoint.html: Added.
  • inspector/debugger-pause-on-exception-expected.txt: Added.
  • inspector/debugger-pause-on-exception.html: Added.
  • platform/chromium/inspector/debugger-pause-on-exception-expected.txt: Added.

2010-09-07 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: upstream two debugger tests
https://bugs.webkit.org/show_bug.cgi?id=45262

  • src/js/Tests.js:
05:11 Changeset [66876] by steveblock@google.com

2010-09-07 Steve Block <steveblock@google.com>

Reviewed by Jeremy Orlow.

Provide DeviceOrientation LayoutTests
https://bugs.webkit.org/show_bug.cgi?id=39590

Adds several new DeviceOrientation tests. Also fixes some style in existing tests.

  • fast/dom/DeviceOrientation/add-listener-from-callback.html: Added.
  • fast/dom/DeviceOrientation/script-tests/add-listener-from-callback.js: Added.
  • fast/dom/DeviceOrientation/add-listener-from-callback-expected.txt: Added.
  • fast/dom/DeviceOrientation/multiple-frames.html: Added.
  • fast/dom/DeviceOrientation/script-tests/multiple-frames.js: Added.
  • fast/dom/DeviceOrientation/multiple-frames-expected.txt: Added.
  • fast/dom/DeviceOrientation/no-synchronous-events.html: Added.
  • fast/dom/DeviceOrientation/script-tests/no-synchronous-events.js: Added.
  • fast/dom/DeviceOrientation/no-synchronous-events-expected.txt: Added.
  • fast/dom/DeviceOrientation/null-values.html: Added.
  • fast/dom/DeviceOrientation/script-tests/null-values.js: Added.
  • fast/dom/DeviceOrientation/null-values-expected.txt: Added.
  • fast/dom/DeviceOrientation/updates.html: Added.
  • fast/dom/DeviceOrientation/script-tests/updates.js: Added.
  • fast/dom/DeviceOrientation/updates-expected.txt: Added.
  • fast/dom/DeviceOrientation/script-tests/basic-operation.js:
  • fast/dom/DeviceOrientation/script-tests/create-event.js:
  • fast/dom/DeviceOrientation/script-tests/optional-event-properties.js:
  • fast/dom/DeviceOrientation/script-tests/window-property.js:
04:14 Changeset [66875] by kent.hansen@nokia.com

2010-09-07 Kent Hansen <kent.hansen@nokia.com>

Reviewed by Andreas Kling.

[Qt] tst_QWebFrame::connectAndDisconnect() fails on WebKit trunk because qt_sender is never set
https://bugs.webkit.org/show_bug.cgi?id=44697

When the signal handler is a JS function, qt_sender is stuffed into a temporary
object that's pushed onto the function's scope before the function is invoked, and
popped again afterwards.

We were pushing this new scope object _after_ calling JSFunction::getCallData(),
and relying on JSC::call() to use the fresh scope chain from the function object.
However, this is no longer the case; JSC::call() uses the scope chain passed in
the CallData argument. Hence, we need to set up the scope before the function's
CallData is queried.

  • bridge/qt/qt_runtime.cpp: (JSC::Bindings::QtConnectionObject::execute):
03:22 Changeset [66874] by ossy@webkit.org

[Qt] Add platform specific expected results for new passing tests.
Compared to Mac png files and Mac expected files.

  • platform/qt/fast/css/percent-top-relative-container-height-unspecified-expected.checksum: Added.
  • platform/qt/fast/css/percent-top-relative-container-height-unspecified-expected.png: Added.
  • platform/qt/fast/css/percent-top-relative-container-height-unspecified-expected.txt: Added.
  • platform/qt/fast/forms/placeholder-stripped-expected.checksum: Added.
  • platform/qt/fast/forms/placeholder-stripped-expected.png: Added.
  • platform/qt/fast/forms/placeholder-stripped-expected.txt: Added.
  • platform/qt/fast/gradients/radial-centered-expected.checksum: Added.
  • platform/qt/fast/gradients/radial-centered-expected.png: Added.
  • platform/qt/fast/gradients/radial-centered-expected.txt: Added.
  • platform/qt/fast/multicol/float-paginate-expected.checksum: Added.
  • platform/qt/fast/multicol/float-paginate-expected.png: Added.
  • platform/qt/fast/multicol/float-paginate-expected.txt: Added.
  • platform/qt/fast/multicol/paginate-block-replaced-expected.checksum: Added.
  • platform/qt/fast/multicol/paginate-block-replaced-expected.png: Added.
  • platform/qt/fast/multicol/paginate-block-replaced-expected.txt: Added.
  • platform/qt/fast/repaint/multicol-repaint-expected.checksum: Added.
  • platform/qt/fast/repaint/multicol-repaint-expected.png: Added.
  • platform/qt/fast/repaint/multicol-repaint-expected.txt: Added.
  • platform/qt/fast/repaint/view-background-from-body-1-expected.checksum: Copied from LayoutTests/platform/mac/fast/repaint/view-background-from-body-1-expected.checksum.
  • platform/qt/fast/repaint/view-background-from-body-1-expected.png: Copied from LayoutTests/platform/qt/svg/custom/use-property-synchronization-crash-expected.png.
  • platform/qt/fast/repaint/view-background-from-body-1-expected.txt: Copied from LayoutTests/platform/gtk/fast/repaint/view-background-from-body-1-expected.txt.
  • platform/qt/fast/repaint/view-background-from-body-2-expected.checksum: Copied from LayoutTests/platform/mac/fast/repaint/view-background-from-body-2-expected.checksum.
  • platform/qt/fast/repaint/view-background-from-body-2-expected.png: Added.
  • platform/qt/fast/repaint/view-background-from-body-2-expected.txt: Copied from LayoutTests/platform/gtk/fast/repaint/view-background-from-body-2-expected.txt.
  • platform/qt/svg/batik/paints/patternRegions-positioned-objects-expected.checksum: Added.
  • platform/qt/svg/batik/paints/patternRegions-positioned-objects-expected.png: Added.
  • platform/qt/svg/batik/paints/patternRegions-positioned-objects-expected.txt: Added.
  • platform/qt/svg/css/composite-shadow-text-expected.checksum: Added.
  • platform/qt/svg/css/composite-shadow-text-expected.png: Added.
  • platform/qt/svg/css/composite-shadow-text-expected.txt: Added.
  • platform/qt/svg/custom/bug45331-expected.checksum: Added.
  • platform/qt/svg/custom/bug45331-expected.png: Added.
  • platform/qt/svg/custom/bug45331-expected.txt: Added.
  • platform/qt/svg/custom/getscreenctm-in-scrollable-div-area-expected.checksum: Added.
  • platform/qt/svg/custom/getscreenctm-in-scrollable-div-area-expected.png: Added.
  • platform/qt/svg/custom/getscreenctm-in-scrollable-div-area-expected.txt: Added.
  • platform/qt/svg/custom/getscreenctm-in-scrollable-div-area-nested-expected.checksum: Added.
  • platform/qt/svg/custom/getscreenctm-in-scrollable-div-area-nested-expected.png: Added.
  • platform/qt/svg/custom/getscreenctm-in-scrollable-div-area-nested-expected.txt: Added.
  • platform/qt/svg/custom/getscreenctm-in-scrollable-svg-area-expected.checksum: Added.
  • platform/qt/svg/custom/getscreenctm-in-scrollable-svg-area-expected.png: Added.
  • platform/qt/svg/custom/getscreenctm-in-scrollable-svg-area-expected.txt: Added.
  • platform/qt/svg/custom/marker-empty-path-expected.checksum: Copied from LayoutTests/platform/mac/svg/custom/marker-empty-path-expected.checksum.
  • platform/qt/svg/custom/marker-empty-path-expected.png: Added.
  • platform/qt/svg/custom/marker-empty-path-expected.txt: Added.
  • platform/qt/svg/custom/mouse-move-on-svg-container-expected.checksum: Added.
  • platform/qt/svg/custom/mouse-move-on-svg-container-expected.png: Added.
  • platform/qt/svg/custom/mouse-move-on-svg-container-expected.txt: Added.
  • platform/qt/svg/custom/mouse-move-on-svg-container-standalone-expected.checksum: Added.
  • platform/qt/svg/custom/mouse-move-on-svg-container-standalone-expected.png: Added.
  • platform/qt/svg/custom/mouse-move-on-svg-container-standalone-expected.txt: Added.
  • platform/qt/svg/custom/mouse-move-on-svg-root-expected.checksum: Added.
  • platform/qt/svg/custom/mouse-move-on-svg-root-expected.png: Added.
  • platform/qt/svg/custom/mouse-move-on-svg-root-expected.txt: Added.
  • platform/qt/svg/custom/mouse-move-on-svg-root-standalone-expected.checksum: Added.
  • platform/qt/svg/custom/mouse-move-on-svg-root-standalone-expected.png: Added.
  • platform/qt/svg/custom/mouse-move-on-svg-root-standalone-expected.txt: Added.
  • platform/qt/svg/custom/non-scaling-stroke-markers-expected.checksum: Copied from LayoutTests/platform/mac/svg/custom/non-scaling-stroke-markers-expected.checksum.
  • platform/qt/svg/custom/non-scaling-stroke-markers-expected.png: Added.
  • platform/qt/svg/custom/non-scaling-stroke-markers-expected.txt: Added.
  • platform/qt/svg/custom/pattern-incorrect-tiling-expected.checksum: Added.
  • platform/qt/svg/custom/pattern-incorrect-tiling-expected.png: Added.
  • platform/qt/svg/custom/pattern-incorrect-tiling-expected.txt: Added.
  • platform/qt/svg/custom/pattern-no-pixelation-expected.checksum: Added.
  • platform/qt/svg/custom/pattern-no-pixelation-expected.png: Added.
  • platform/qt/svg/custom/pattern-no-pixelation-expected.txt: Added.
  • platform/qt/svg/custom/use-font-face-crash-expected.checksum: Added.
  • platform/qt/svg/custom/use-font-face-crash-expected.png: Added.
  • platform/qt/svg/custom/use-font-face-crash-expected.txt: Added.
  • platform/qt/svg/transforms/text-with-mask-with-svg-transform-expected.checksum: Added.
  • platform/qt/svg/transforms/text-with-mask-with-svg-transform-expected.png: Added.
  • platform/qt/svg/transforms/text-with-mask-with-svg-transform-expected.txt: Added.
  • platform/qt/transitions/svg-text-shadow-transition-expected.checksum: Added.
  • platform/qt/transitions/svg-text-shadow-transition-expected.png: Added.
  • platform/qt/transitions/svg-text-shadow-transition-expected.txt: Added.
03:12 Changeset [66873] by philn@webkit.org

2010-09-07 Philippe Normand <pnormand@igalia.com>

Unreviewed, build fix.

webkit-patch command to find the ports covering a specific layout test
https://bugs.webkit.org/show_bug.cgi?id=42832

  • Scripts/webkitpy/layout_tests/port/chromium.py: Don't assume the tests are present when building the expectations. This is needed for the unittests.
02:53 Changeset [66872] by philn@webkit.org

2010-09-06 Philippe Normand <pnormand@igalia.com>

Reviewed by Adam Barth.

webkit-patch command to find the ports covering a specific layout test
https://bugs.webkit.org/show_bug.cgi?id=42832

To use it: webkit-patch skipped-ports some/layout/test.html

  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/base_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  • Scripts/webkitpy/layout_tests/port/factory.py:
  • Scripts/webkitpy/layout_tests/port/factory_unittest.py:
  • Scripts/webkitpy/layout_tests/port/test.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
  • Scripts/webkitpy/tool/commands/queries.py:
  • Scripts/webkitpy/tool/commands/queries_unittest.py:
  • Scripts/webkitpy/tool/main.py:
  • Scripts/webkitpy/tool/mocktool.py:
02:20 Changeset [66871] by tkent@chromium.org

2010-09-07 Kent Tamura <tkent@chromium.org>

Unreviewed, test expectation update.

  • platform/chromium/drt_expectations.txt: Remove a duplicated entry.
02:12 Changeset [66870] by commit-queue@webkit.org

2010-09-07 Arno Renevier <arno@renevier.net>

Reviewed by Holger Freyther.

gitignore *~ files and gtk *.pot files
https://bugs.webkit.org/show_bug.cgi?id=45129

  • .gitignore:
01:51 Changeset [66869] by commit-queue@webkit.org

2010-09-07 Kwang Yul Seo <skyul@company100.net>

Reviewed by Kent Tamura.

Add ENABLE(INSPECTOR) guard in InspectorController::inspectorControllerForNode
https://bugs.webkit.org/show_bug.cgi?id=45272

Build fix.

  • inspector/InspectorController.h: (WebCore::InspectorController::inspectorControllerForNode):
01:50 Changeset [66868] by ukai@chromium.org

Unreviewed. Build fix.

Update test expectations for Chromium.

  • platform/chromium-linux/svg/custom/use-invalid-pattern-expected.txt: Added.
  • platform/chromium-mac/svg/custom/use-invalid-pattern-expected.txt: Added.
  • platform/chromium-win/svg/custom/use-invalid-pattern-expected.txt: Added.
01:38 Changeset [66867] by tkent@chromium.org

2010-09-07 Kent Tamura <tkent@chromium.org>

Reviewed by Ojan Vafai.

Fix wrong position calculation of fast/forms/listbox-selection.html
https://bugs.webkit.org/show_bug.cgi?id=45285

  • fast/forms/script-tests/listbox-selection.js: (mouseDownOnSelect): Refer window.pageYOffset after sl.focus() call because focus() might scroll the page.
  • platform/chromium/test_expectations.txt:
01:35 Changeset [66866] by tkent@chromium.org

2010-09-07 Kent Tamura <tkent@chromium.org>

Unreviewed, test expectation update.

Update DRT/Chromium expectations, and skip meter-percent-size.html
for platforms without <meter> support.

  • platform/chromium/drt_expectations.txt:
  • platform/gtk/Skipped:
  • platform/win/Skipped:
01:28 Changeset [66865] by commit-queue@webkit.org

2010-09-07 Joerg Bornemann <joerg.bornemann@nokia.com>

Reviewed by Ariya Hidayat.

Fix QtWebKit linker error on Windows CE 6.
https://bugs.webkit.org/show_bug.cgi?id=43442

Doesn't affect any tests.

  • WebCore.pro:
01:12 Changeset [66864] by commit-queue@webkit.org

2010-09-07 James Kozianski <koz@chromium.org>

Reviewed by Kent Tamura.

Adds tests for percent-based attributes on the <meter> element.

  • fast/dom/HTMLMeterElement/meter-percent-size-expected.txt: Added.
  • fast/dom/HTMLMeterElement/meter-percent-size.html: Added.

2010-09-07 James Kozianski <koz@chromium.org>

Reviewed by Kent Tamura.

Crash rendering <meter/> with percent padding
https://bugs.webkit.org/show_bug.cgi?id=45081

Avoids a crash caused by RenderMeter checking its own dimensions to
determine whether it needs layout. The crash is avoided by removing
the check and always calling setNeedsLayout(true).

Test: fast/dom/HTMLMeterElement/meter-percent-size.html

  • rendering/RenderIndicator.cpp: (WebCore::RenderIndicator::updateFromElement):
  • rendering/RenderIndicator.h:
00:30 Changeset [66863] by commit-queue@webkit.org

2010-09-07 Gabor Rapcsanyi <rgabor@inf.u-szeged.hu>

Reviewed by Eric Seidel.

[NRWT] Add temp directory to all running drivers.
https://bugs.webkit.org/show_bug.cgi?id=45261

  • Scripts/webkitpy/layout_tests/port/webkit.py:

09/06/10:

21:06 Changeset [66862] by abarth@webkit.org

2010-09-06 Adam Barth <abarth@webkit.org>

Reviewed by Sam Weinig.

OOB read with svg polyline
https://bugs.webkit.org/show_bug.cgi?id=45279

In principle, attributeChanged can do anything. If we supported more
DOM mutation events, it could even run JavaScript. That means we need
to be prepared for the attribute map to change when running
attributeChanged. This patch makes this loop resilient to the
attribute map changing by storing the list of changed attributes on the
stack.

Test: fast/parser/changing-attrbutes-crash.html

  • dom/Element.cpp: (WebCore::Element::setAttributeMap):

2010-09-06 Adam Barth <abarth@webkit.org>

Reviewed by Sam Weinig.

OOB read with svg polyline
https://bugs.webkit.org/show_bug.cgi?id=45279

Test what happens when SVG changes the attribute map out from under us.

  • fast/parser/changing-attrbutes-crash-expected.txt: Added.
  • fast/parser/changing-attrbutes-crash.html: Added.
20:13 Changeset [66861] by dglazkov@chromium.org

2010-09-06 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Kent Tamura.

[Chromium/DRT] Empty out user stylesheet after each test run.
https://bugs.webkit.org/show_bug.cgi?id=45282

This should significantly cut down on the number of the mysterious flaky tests
whose diffs looked like the page was blown up to a very lage size. This
was indeed the dirty work of platform/mac/fast/loader/user-stylesheet-fast-path.html,
which set the base body font to 100px.

Since the user stylesheet was never reset, _all_ pixel tests that ran after it in
the same thread failed.

  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::resetWebSettings): Set user stylesheet to an empty URL.
20:05 Changeset [66860] by tkent@chromium.org

2010-09-06 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[DRT/Chromium] Do not generate pixel results for text/plain resources
https://bugs.webkit.org/show_bug.cgi?id=45253

  • platform/chromium/drt_expectations.txt: Remove slow-utf8-text.pl failure.

2010-09-06 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[DRT/Chromium] Do not generate pixel results for text/plain resources
https://bugs.webkit.org/show_bug.cgi?id=45253

  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::dump): Clear shouldGeneratePixelResults flag for text/plain.
19:09 UsingGitWithWebKit edited by ojan@chromium.org
(diff)
19:05 Changeset [66859] by ojan@chromium.org

2010-09-06 Ojan Vafai <ojan@chromium.org>

Reviewed by Kent Tamura.

print out correct error when a DRT thread dies in NRWT
https://bugs.webkit.org/show_bug.cgi?id=45281

Not sure why, but with the parens, python 2.6.5 on Linux
gives an error that raise takes 5 arguments and 0 were given.
Didn't test other platforms or python versions, but putting it
all on one line fixes it and correctly prints the exception
from the DRT thread.

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
17:31 Changeset [66858] by eric@webkit.org

2010-09-06 Eric Seidel <eric@webkit.org>

Unreviewed, just adding some emails from lists.webkit.org.

Update committers.py to include emails from lists.webkit.org
as found by the validate-committer-lists script.

  • Scripts/webkitpy/common/config/committers.py:
16:46 Changeset [66857] by abarth@webkit.org

2010-09-06 Adam Barth <abarth@webkit.org>

Small UI tweak to the reviewtool. Make the Ok/Cancel buttons a bit
bigger.

  • PrettyPatch/PrettyPatch.rb:
16:44 Changeset [66856] by oliver@apple.com

Windows build fix

16:39 Changeset [66855] by abarth@webkit.org

2010-09-06 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

[reviewtool] Add a quick animation for opening/closing comment boxes
https://bugs.webkit.org/show_bug.cgi?id=45278

The 200ms animation slides in and out the line-by-line comment box.

  • code-review.js:
16:31 Changeset [66854] by oliver@apple.com

Windows build fix

16:00 Changeset [66853] by diegohcg@webkit.org

2010-09-06 Diego Gonzalez <diegohcg@webkit.org>

Reviewed by Antonio Gomes.

[Qt] Update NetworkAccessManager in Qt FrameNetworkingContext
https://bugs.webkit.org/show_bug.cgi?id=45231

Make possible to get the current QNAM when NetwokingContext request it.

  • WebCoreSupport/FrameNetworkingContextQt.cpp: (WebCore::FrameNetworkingContextQt::networkAccessManager):
15:53 Changeset [66852] by oliver@apple.com

Windows build fix

15:35 Changeset [66851] by jschuh@chromium.org

2010-09-06 Justin Schuh <jschuh@chromium.org>

Unreviewed. Build fix.

Update test expectations for Leopard.

  • platform/mac-leopard/svg/custom/use-invalid-pattern-expected.txt: Added.
14:29 Changeset [66850] by oliver@apple.com

2010-09-05 Oliver Hunt <oliver@apple.com>

Reviewed by Sam Weinig.

SerializedScriptValue needs to use a flat storage mechanism
https://bugs.webkit.org/show_bug.cgi?id=45244

Export JSArray::put

2010-09-05 Oliver Hunt <oliver@apple.com>

Reviewed by Sam Weinig.

SerializedScriptValue needs to use a flat storage mechanism
https://bugs.webkit.org/show_bug.cgi?id=45244

Add a few more test cases to cover the new branches in the
rewritten serialization logic.

  • fast/dom/Window/window-postmessage-clone-expected.txt:
  • fast/dom/Window/window-postmessage-clone.html:

2010-09-05 Oliver Hunt <oliver@apple.com>

Reviewed by Sam Weinig.

SerializedScriptValue needs to use a flat storage mechanism
https://bugs.webkit.org/show_bug.cgi?id=45244

Rewrite the old tree to tree serialization logic to use
flat storage. Unfortunately this basically required a
complete rewrite.

  • bindings/js/SerializedScriptValue.cpp: (WebCore::CloneBase::CloneBase): (WebCore::CloneBase::shouldTerminate): (WebCore::CloneBase::ticksUntilNextCheck): (WebCore::CloneBase::didTimeOut): (WebCore::CloneBase::throwStackOverflow): (WebCore::CloneBase::throwInterruptedException): (WebCore::CloneBase::fail): (WebCore::CloneSerializer::serialize): (WebCore::CloneSerializer::CloneSerializer): (WebCore::CloneSerializer::isArray): (WebCore::CloneSerializer::startObject): (WebCore::CloneSerializer::startArray): (WebCore::CloneSerializer::endObject): (WebCore::CloneSerializer::getSparseIndex): (WebCore::CloneSerializer::getProperty): (WebCore::CloneSerializer::dumpImmediate): (WebCore::CloneSerializer::dumpString): (WebCore::CloneSerializer::dumpIfTerminal): (WebCore::CloneSerializer::write): (WebCore::CloneSerializer::writeLittleEndian): (WebCore::CloneSerializer::writeStringIndex): (WebCore::CloneDeserializer::deserializeString): (WebCore::CloneDeserializer::deserialize): (WebCore::CloneDeserializer::CloneDeserializer): (WebCore::CloneDeserializer::throwValidationError): (WebCore::CloneDeserializer::isValid): (WebCore::CloneDeserializer::readLittleEndian): (WebCore::CloneDeserializer::read): (WebCore::CloneDeserializer::readStringIndex): (WebCore::CloneDeserializer::readString): (WebCore::CloneDeserializer::readStringData): (WebCore::CloneDeserializer::readTag): (WebCore::CloneDeserializer::putProperty): (WebCore::CloneDeserializer::readFile): (WebCore::CloneDeserializer::readTerminal): (WebCore::SerializedScriptValue::~SerializedScriptValue): (WebCore::SerializedScriptValue::SerializedScriptValue): (WebCore::SerializedScriptValue::create): (WebCore::SerializedScriptValue::toString): (WebCore::SerializedScriptValue::deserialize): (WebCore::SerializedScriptValue::nullValue):
  • bindings/js/SerializedScriptValue.h:
  • dom/MessagePortChannel.cpp: (WebCore::MessagePortChannel::EventData::EventData):
  • workers/WorkerMessagingProxy.cpp: (WebCore::MessageWorkerContextTask::MessageWorkerContextTask): (WebCore::MessageWorkerTask::MessageWorkerTask):
14:09 Changeset [66849] by abarth@webkit.org

2010-09-06 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

[reviewtool] Add a field for overall comments
https://bugs.webkit.org/show_bug.cgi?id=45273

This patch does a couple logically separate things that could be
separated into smaller patches:

1) This patch adds an "overall comments" field where you can enter

overall comments about the patch. These comments appear at the top
of the bugzilla posting. Currently, these aren't redisplayed when
viewing the patch, but I plan to add that in a future patch.

2) This patch renames some of the CSS classes to more consistently

follow the camelCase style that PrettyPatch uses.

3) This patch moves the "prepare comments" button to the left of the

toolbar and renames is to "publish comments". This makes more sense
when you scroll to the bottom of the page and enter in some overall
comments.

4) When you attempt to add a comment to a line that already has a

"frozen" comment, we now unfreeze the comment instead of doing
nothing. The old behavior was kind of frustrating if you didn't
know that you could unfreeze a comment by clicking on it.

  • PrettyPatch/PrettyPatch.rb:
    • Update CSS.
  • code-review.js:
14:04 Changeset [66848] by mrobinson@webkit.org

2010-09-06 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] ScrollbarThemeGtk should be enabled for interior frame scrollbars
https://bugs.webkit.org/show_bug.cgi?id=45046

Make interior frame scrollbars "fully-fake," which means they do not rely
at all on GTK+ for painting or behavior, but instead are typical WebCore
scrollbars drawn according to the GTK+ theme. Move ScrollbarGtk to
MainFrameScrollbarGtk and remove all logic in that file dealing with interior
frame scrollbars.

No new tests, as this is already covered by pixel tests for scrollbars,
which were added in r66605.

  • GNUmakefile.am: Update sources list.
  • platform/ScrollView.h: Change the adjustment members to be smart pointers.
  • platform/Scrollbar.cpp: Enable THUMB_POSITION_AFFECTS_BUTTONS for GTK+ as well.
  • platform/gtk/MainFrameScrollbarGtk.cpp: Added. (MainFrameScrollbarGtk::create): Create a MainFrameScrollbarGtk instead of ScrollbarGtk. (MainFrameScrollbarGtk::MainFrameScrollbarGtk): (MainFrameScrollbarGtk::~MainFrameScrollbarGtk): (MainFrameScrollbarGtk::attachAdjustment): (MainFrameScrollbarGtk::detachAdjustment): (MainFrameScrollbarGtk::updateThumbPosition): (MainFrameScrollbarGtk::updateThumbProportion): (MainFrameScrollbarGtk::gtkValueChanged): (MainFrameScrollbarGtk::paint):
  • platform/gtk/MainFrameScrollbarGtk.h: Added.
  • platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollView::platformInit): Remove unnecessary initialization because of smart pointer change. (WebCore::ScrollView::createScrollbar): Instead of creating ScrollbarGtk for interior frame scrollbars, create a normal WebCore scrollbar. (WebCore::ScrollView::setGtkAdjustments): Added an extra assert which ensures that this method is never called with a non-null adjustment on an interior frame scrollbar. (WebCore::ScrollView::platformAddChild): Remove logic for interior frame scrollbars. (WebCore::ScrollView::platformRemoveChild): Remove logic for interior frame scrollbars. (WebCore::ScrollView::visibleContentRect): Use a more accurate guard for detecting transitionary states when accessing parent widgets. Explcitly guard against interior frame ScrollView's trying to determine size based on parent widgets. (WebCore::ScrollView::setScrollbarModes): This method was out of sync with the one it copy-and-pasted from. Update it and change the logic to do the right thing for interior frame scrollbars.
  • platform/gtk/ScrollbarGtk.cpp: Removed.
  • platform/gtk/ScrollbarGtk.h: Removed.
14:00 Changeset [66847] by jschuh@chromium.org

2010-09-06 Justin Schuh <jschuh@chromium.org>

Reviewed by Nikolas Zimmermann.

Make SVG PendingResources use RefPtr
https://bugs.webkit.org/show_bug.cgi?id=43587

Convert SVGDocumentExtensions::m_pendingResources to use a RefPtr for
pending elements instead of a raw pointer so that pending elements can't
be freed prematurely.

Test: svg/custom/use-invalid-pattern.svg

  • rendering/RenderSVGResourceContainer.cpp: (WebCore::RenderSVGResourceContainer::registerResource):
  • svg/SVGDocumentExtensions.cpp: (WebCore::SVGDocumentExtensions::addPendingResource): (WebCore::SVGDocumentExtensions::removePendingResource):
  • svg/SVGDocumentExtensions.h:
  • svg/SVGElement.cpp: (WebCore::SVGElement::insertedIntoDocument):

2010-09-06 Justin Schuh <jschuh@chromium.org>

Reviewed by Nikolas Zimmermann.

Test that an invalid pending resource pattern doesn't crash
https://bugs.webkit.org/show_bug.cgi?id=43587

  • platform/mac-snowleopard/svg: Added.
  • platform/mac-snowleopard/svg/custom: Added.
  • platform/mac-snowleopard/svg/custom/use-invalid-pattern-expected.txt: Added.
  • svg/custom/use-invalid-pattern.svg: Added.
13:29 Changeset [66846] by commit-queue@webkit.org

2010-09-06 Chao-ying Fu <fu@mips.com>

Reviewed by Oliver Hunt.

Support JSVALUE32_64 on MIPS
https://bugs.webkit.org/show_bug.cgi?id=43999

Add missing functions to support JSVALUE32_64 on MIPS.
Remove JSVALUE32 as the default for MIPS.

  • assembler/MIPSAssembler.h: (JSC::MIPSAssembler::divd): (JSC::MIPSAssembler::mthc1): (JSC::MIPSAssembler::cvtwd):
  • assembler/MacroAssemblerMIPS.h: (JSC::MacroAssemblerMIPS::neg32): (JSC::MacroAssemblerMIPS::branchOr32): (JSC::MacroAssemblerMIPS::set8): (JSC::MacroAssemblerMIPS::loadDouble): (JSC::MacroAssemblerMIPS::divDouble): (JSC::MacroAssemblerMIPS::convertInt32ToDouble): (JSC::MacroAssemblerMIPS::branchDouble): (JSC::MacroAssemblerMIPS::branchConvertDoubleToInt32): (JSC::MacroAssemblerMIPS::zeroDouble):
  • jit/JIT.h:
  • jit/JITOpcodes32_64.cpp: (JSC::JIT::privateCompileCTINativeCall):
  • jit/JITPropertyAccess32_64.cpp: (JSC::JIT::privateCompilePutByIdTransition):
  • jit/JITStubs.cpp: (JSC::JITThunks::JITThunks):
  • jit/JITStubs.h:
  • wtf/Platform.h:
12:49 Changeset [66845] by mrobinson@webkit.org

2010-09-06 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] ScrollbarThemeGtk should support secondary steppers
https://bugs.webkit.org/show_bug.cgi?id=44791

Add support to ScrollbarThemeGtk for drawing alternate steppers. Adjust
the algorithms for calculating forward and back button rects, if they
are active in the theme. Expose this information via GtkScrollbarMetrics.

  • platform/gtk/ScrollbarThemeGtk.cpp: (WebCore::ScrollbarThemeGtk::updateThemeProperties): Access the secondary stepper properties of GtkScrollbarMetrics when updating the style cache. (WebCore::ScrollbarThemeGtk::backButtonRect): Account for alternate steppers. (WebCore::ScrollbarThemeGtk::forwardButtonRect): Ditto. (WebCore::ScrollbarThemeGtk::trackRect): Ditto. (WebCore::ScrollbarThemeGtk::paintButton): Ditto.
  • platform/gtk/ScrollbarThemeGtk.h:
  • platform/gtk/gtk2drawing.c: Expose whether or not the style uses alternate steppers via GtkScrollbarMetrics.
  • platform/gtk/gtkdrawing.h: Added fields to GtkScrollbarMetrics.
12:38 Changeset [66844] by robert@webkit.org

Fix compile failure in r66843

Revert to original patch in bugzilla. Leave bug open for
discussion on potential removal of double utf8 conversion.

https://bugs.webkit.org/show_bug.cgi?id=45240

12:11 Changeset [66843] by robert@webkit.org

2010-09-06 Robert Hogan <robert@webkit.org>

Reviewed by Andreas Kling.

[Qt] utf8 encoding of console() messages

Unskip:
http/tests/security/xssAuditor/embed-tag-null-char.html
http/tests/security/xssAuditor/object-embed-tag-null-char.html

Both tests failed because Qt's implementation of String::format()
is casting a utf8 result to String, which assumes latin1 in
its constructor. So instead of casting a QString to a String, use
StringImpl::create() instead. Unfortunately, this involves a lot
of extra casts but the end result is correct.

https://bugs.webkit.org/show_bug.cgi?id=45240

  • wtf/text/WTFString.cpp: (WTF::String::format):

2010-09-06 Robert Hogan <robert@webkit.org>

Reviewed by Andreas Kling.

[Qt] utf8 encoding of console() messages

Unskip:
http/tests/security/xssAuditor/embed-tag-null-char.html
http/tests/security/xssAuditor/object-embed-tag-null-char.html

Both tests failed because Qt's implementation of String::format()
is casting a utf8 result to String, which assumes latin1 in
its constructor. So instead of casting a QString to a String, use
StringImpl::create() instead. Unfortunately, this involves a lot
of extra casts but the end result is correct.

https://bugs.webkit.org/show_bug.cgi?id=45240

  • platform/qt/Skipped:
11:52 Changeset [66842] by jschuh@chromium.org

2010-09-06 Justin Schuh <jschuh@chromium.org>

Unreviewed. Build fix.

Update test expectations for Chromium Mac.

  • platform/chromium-mac/svg/custom/use-invalid-style-expected.txt: Added.
11:32 Changeset [66841] by tonyg@chromium.org

2010-09-06 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Adam Barth.

Implement HTML5 definition of document.readyState
https://bugs.webkit.org/show_bug.cgi?id=45119

  • fast/dom/Document/readystate-expected.txt: Added.
  • fast/dom/Document/readystate.html: Added. Reads readyState inline script, external script, deferred script, DOMContentLoaded, onload, and dynamic post-onload script.

2010-09-06 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Adam Barth.

Implement HTML5 definition of document.readyState
https://bugs.webkit.org/show_bug.cgi?id=45119

The legacy behavior was "loading" -> "loaded" -> "complete". The new
HTML5 behavior is "loading" -> "interactive" -> "complete". There is
some potential for this to cause compat problems if for instance a
page expects readyState to be "loaded" during the DOMContentLoaded event.

Test: fast/dom/Document/readystate.html

  • dom/Document.cpp: (WebCore::Document::Document): Initial value is Complete because according to http://www.whatwg.org/specs/web-apps/current-work/#dom-document-readystate, when a Document is created the initial value is "complete" unless it has a parser associated with it, in which case it is "loading". So the ctor starts it Complete, and when the parser is created it is flipped to Loading. (WebCore::Document::readyState): (WebCore::Document::setReadyState): (WebCore::Document::implicitOpen): (WebCore::Document::finishedParsing): Ensure that XML and HTML parser have transition to Stopping state.
  • dom/Document.h:
  • dom/DocumentParser.cpp: (WebCore::DocumentParser::prepareToStopParsing): Previously this was being called when parsing had stopped. It is better to ensure it is only called while parsing.
  • dom/XMLDocumentParser.cpp: (WebCore::XMLDocumentParser::end): Transition to stopping before calling document finishedParsiong().
  • html/parser/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::prepareToStopParsing): Set state to interactive before running deferred scripts. This method is also called when parsing fragments, so we need to ensure it isn't done in that case. (WebCore::HTMLDocumentParser::attemptToRunDeferredScriptsAndEnd): Added. Break out this part s that notifyFinished doesn't go through the additional steps of pumping tokenizer, setting the state, etc. (WebCore::HTMLDocumentParser::notifyFinished): Now that prepareToStopParsing is split up, we must protect. It also makes sense to add a couple of ASSERTs.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::stopLoading): It looks like an aborted load should never transition to "complete" according the HTML5. I've left the legacy behavior for now though. (WebCore::FrameLoader::checkCompleted): The FrameLoader now sets the state on the Document instead of the Document polling the FrameLoader.
10:46 Changeset [66840] by antonm@chromium.org

2010-09-06 Anton Muhin <antonm@chromium.org>

Reviewed by Adam Barth.

[v8] Inline hot methods for V8 to WebCore and back conversions
https://bugs.webkit.org/show_bug.cgi?id=45270

Inline fast paths of hot functions performing conversions from V8 wrappers
to WebCore native objects and back.
That slightly increases the size of binary (within 0.1% for both Ubuntu
and Windows, but those builds are slightly different from official ones),
but gives performance boost (3--5% on Windows, up to 8% on Ubuntu).

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/V8DOMWindowShell.cpp: (WebCore::V8DOMWindowShell::initContextIfNeeded):
  • bindings/v8/V8DOMWindowShell.h:
  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getWrapperSlow):
  • bindings/v8/V8DOMWrapper.h: (WebCore::V8DOMWrapper::getWrapper):
  • bindings/v8/custom/V8NodeCustom.cpp: (WebCore::toV8Slow):
10:30 Changeset [66839] by commit-queue@webkit.org

2010-09-06 Ryuan Choi <ryuan.choi@samsung.com>

Unreviewed build fix.

[EFL] REGRESSION(66794) Need to fix build break.
https://bugs.webkit.org/show_bug.cgi?id=45241

Add dummy class(FrameNetworkingContextEfl) like GTK+ port and implement
as EFL style.

  • WebCoreSupport/FrameLoaderClientEfl.cpp: (WebCore::FrameLoaderClientEfl::createNetworkingContext):
  • WebCoreSupport/FrameNetworkingContextEfl.h: Added. (WebCore::FrameNetworkingContextEfl::create): (WebCore::FrameNetworkingContextEfl::coreFrame): (WebCore::FrameNetworkingContextEfl::FrameNetworkingContextEfl):
10:19 Changeset [66838] by abarth@webkit.org

2010-09-06 Adam Barth <abarth@webkit.org>

[reviewtool] Tweak the ok button to cancel the comment if the comment
is empty. Previously we would get into a bad state where a line had a
comment but there was no longer any way to access it.

  • code-review.js:
10:09 Changeset [66837] by commit-queue@webkit.org

2010-09-06 Jonathan Dixon <joth@chromium.org>

Reviewed by Jeremy Orlow.

Add new interface and empty impl. as precursor to bug 45112
https://bugs.webkit.org/show_bug.cgi?id=45257

  • public/WebGeolocationServiceBridge.h: (WebKit::WebGeolocationServiceBridge::~WebGeolocationServiceBridge):
  • src/WebGeolocationServiceBridgeImpl.cpp: (WebKit::WebGeolocationServiceBridgeImpl::onWebGeolocationServiceDestroyed):
09:51 Changeset [66836] by commit-queue@webkit.org

2010-09-06 Shane Stephens <shanestephens@google.com>

Reviewed by Dimitri Glazkov.

[Crash] <animateMotion> element directly inside <symbol> element causes crash when referenced by <use>
https://bugs.webkit.org/show_bug.cgi?id=44750

Added test case to demonstrate crash bug.

  • svg/dom/symbol-embeddedAnimation-expected.txt: Added.
  • svg/dom/symbol-embeddedAnimation.svg: Added.

2010-09-06 Shane Stephens <shanestephens@google.com>

Reviewed by Dimitri Glazkov.

[Crash] <animateMotion> element directly inside <symbol> element causes crash when referenced by <use>
https://bugs.webkit.org/show_bug.cgi?id=44750

Fixes crash by checking for null transforms and skipping update step
when appropriate.

Test: svg/dom/symbol-embeddedAnimation.svg

  • svg/SVGAnimateMotionElement.cpp: (WebCore::SVGAnimateMotionElement::applyResultsToTarget):
09:42 Changeset [66835] by ossy@webkit.org

2010-09-06 Csaba Osztrogonác <ossy@webkit.org>

Reviewed by Antonio Gomes.

Web Inspector: Tests crash on Qt bots revealed by r66720
https://bugs.webkit.org/show_bug.cgi?id=45256

  • WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorClientQt::InspectorClientQt): m_frontendClient must be initialized by constructor
09:14 Changeset [66834] by mrobinson@webkit.org

2010-09-06 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Small code cleanup in DumpRenderTreeGtk.cpp
https://bugs.webkit.org/show_bug.cgi?id=45213

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (initializeFonts): Made this function do nothing for non-X11 platforms, so we don't have to surround the invocation with #ifdefs. (useLongRunningServerMode): Added. (runTestingServerLoop): Added. (initializeGlobalsFromCommandLineOptions): Added. (runTest): Removed ifdefs. (main): Use new helper functions.
09:12 Changeset [66833] by mrobinson@webkit.org

2010-09-06 Martin Robinson <mrobinson@igalia.com>

Unskip a couple of plugin tests which are now passing.

  • platform/gtk/Skipped:
08:38 Changeset [66832] by loislo@chromium.org

2010-09-06 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed build fix.

  • inspector/report-API-errors.html:
08:29 Changeset [66831] by xan@webkit.org

2010-09-06 Xan Lopez <xlopez@igalia.com>

Rubber-stamped by Tor Arne Vestbø.

WebCore already generates a focus-{out,in} events on its setFocus
method, there's no need to duplicate it here. Previously this was
needed because we were not catching all possible names of focus
events in PluginView::handleEvent and were missing the ones
WebCore does, but this has been fixed in r66827.

  • plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::setFocus):
08:01 Changeset [66830] by ossy@webkit.org

Unreviewed, rolling out r66823.
http://trac.webkit.org/changeset/66823
https://bugs.webkit.org/show_bug.cgi?id=45266

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2010-09-06
Windows build fails with unknown reason (Requested by zherczeg
on #webkit).

WebCore:

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • rendering/RenderObject.h:
  • rendering/RenderSVGResourceFilterPrimitive.cpp: Removed.
  • rendering/RenderSVGResourceFilterPrimitive.h: Removed.
  • rendering/SVGRenderTreeAsText.cpp:

(WebCore::writeSVGContainer):

  • svg/SVGFEDiffuseLightingElement.cpp:

(WebCore::SVGFEDiffuseLightingElement::svgAttributeChanged):

  • svg/SVGFELightElement.cpp:

(WebCore::SVGFELightElement::svgAttributeChanged):
(WebCore::SVGFELightElement::childrenChanged):

  • svg/SVGFEOffsetElement.cpp:

(WebCore::SVGFEOffsetElement::svgAttributeChanged):

  • svg/SVGFilterElement.h:

(WebCore::SVGFilterElement::invalidateFilter):

  • svg/SVGFilterPrimitiveStandardAttributes.cpp:

(WebCore::SVGFilterPrimitiveStandardAttributes::svgAttributeChanged):
(WebCore::SVGFilterPrimitiveStandardAttributes::childrenChanged):

  • svg/SVGFilterPrimitiveStandardAttributes.h:

(WebCore::SVGFilterPrimitiveStandardAttributes::rendererIsNeeded):

LayoutTests:

  • platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-lighting-color-css-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-lighting-color-css-prop-expected.png:
07:44 Changeset [66829] by mrobinson@webkit.org

2010-09-06 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] EventSender should support modifier keys with mouseDown and mouseUp events
https://bugs.webkit.org/show_bug.cgi?id=45235

  • platform/gtk/Skipped: Unskip a test which is now passing.

2010-09-06 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] EventSender should support modifier keys with mouseDown and mouseUp events
https://bugs.webkit.org/show_bug.cgi?id=45235

Add support for interpreting the modifier key arguments to the mouseDown and mouseUp
methods of the EventSender.

  • DumpRenderTree/gtk/EventSender.cpp: (prepareMouseButtonEvent): Allow passing in a modifier bitmask, which will be OR'd with the current modifiers. (contextClickCallback): Always send no modifiers when preparing the mouse event. (gdkModifersFromJSValue): Added, converts a JSValue array into a GDK modifier bitmask. (mouseDownCallback): Send in the requested modifiers to prepareMouseButtonEvent. (mouseUpCallback): Ditto.
07:42 Changeset [66828] by mrobinson@webkit.org

2010-09-06 Martin Robinson <mrobinson@igalia.com>

Reviewed by Antonio Gomes.

Convert editing/selection/shift-click.html to use setEditingBehavior
https://bugs.webkit.org/show_bug.cgi?id=45233

  • editing/selection/script-tests/shift-click.js: (shiftClick): Take only one expected string. (assertSelectionString): Take only one expected string. (runShiftClickTest): Added. Runs the test with a particular editing behavior.
  • editing/selection/shift-click-expected.txt: Updated to reflect new results.
  • platform/win/editing/selection/shift-click-expected.txt: Removed.
07:38 Changeset [66827] by xan@webkit.org

WebCore:

2010-09-06 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Provide Keyboard Events to Windowless plugins
https://bugs.webkit.org/show_bug.cgi?id=44613

Fix keyboard event delivery for windowless plugins.

Based on a patch by Bharathwaaj.

  • plugins/PluginView.cpp: (WebCore::PluginView::handleEvent): also take into account focused{in,out} events
  • plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::handleKeyboardEvent): we want the keyval here, not the hardware keycode (WebCore::PluginView::handleMouseEvent): focus the pluginview on mouse events

LayoutTests:

2010-09-06 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Provide Keyboard Events to Windowless plugins
https://bugs.webkit.org/show_bug.cgi?id=44613

Unskip passing test.

  • platform/gtk/Skipped:
07:31 Changeset [66826] by loislo@chromium.org

2010-09-06 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

WebInspector: it'd be nice to be able to pass undefined argument as a callback to InspectorBackend functions.

There are some places where callback is passing via some wrapper. In that case sendMessageToBackend
will be called with additional argument for callback but with undefined value.

https://bugs.webkit.org/show_bug.cgi?id=45265

  • inspector/CodeGeneratorInspector.pm:
06:36 Changeset [66825] by commit-queue@webkit.org

2010-09-06 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: fix chromium devtools tests
https://bugs.webkit.org/show_bug.cgi?id=45258

  • src/js/Tests.js: (.TestSuite.prototype._waitForScriptPause):
06:29 Changeset [66824] by yurys@chromium.org

2010-09-06 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Attempt to fix random test crashes after r66720.

  • WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorFrontendClientQt::~InspectorFrontendClientQt):
  • WebCoreSupport/InspectorClientQt.h:
06:26 Changeset [66823] by zherczeg@webkit.org

An individual renderer should be assigned to each SVGFE*Element class
https://bugs.webkit.org/show_bug.cgi?id=43954

Reviewed by Dirk Schulze.

WebCore:

RenderSVGResourceFilterPrimitive renderer is added to
the project, and assigned to each object, which class is
derived from SVGFilterPrimitiveStandardAttributes. The patch
mainly contains build system changes, and it fixes one layout
test in svg/dynamic-updates.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • rendering/RenderObject.h:

(WebCore::RenderObject::isSVGResourceFilterPrimitive):

  • rendering/RenderSVGResourceFilterPrimitive.cpp: Added.

(WebCore::RenderSVGResourceFilterPrimitive::RenderSVGResourceFilterPrimitive):

  • rendering/RenderSVGResourceFilterPrimitive.h: Added.

(WebCore::RenderSVGResourceFilterPrimitive::isSVGResourceFilterPrimitive):

  • rendering/SVGRenderTreeAsText.cpp:

(WebCore::writeSVGContainer):

  • svg/SVGFEDiffuseLightingElement.cpp:

(WebCore::SVGFEDiffuseLightingElement::svgAttributeChanged):

  • svg/SVGFELightElement.cpp:

(WebCore::SVGFELightElement::svgAttributeChanged):
(WebCore::SVGFELightElement::childrenChanged):

  • svg/SVGFEOffsetElement.cpp:

(WebCore::SVGFEOffsetElement::svgAttributeChanged):

  • svg/SVGFilterElement.h:
  • svg/SVGFilterPrimitiveStandardAttributes.cpp:

(WebCore::SVGFilterPrimitiveStandardAttributes::svgAttributeChanged):
(WebCore::SVGFilterPrimitiveStandardAttributes::childrenChanged):
(WebCore::SVGFilterPrimitiveStandardAttributes::createRenderer):

  • svg/SVGFilterPrimitiveStandardAttributes.h:

(WebCore::SVGFilterPrimitiveStandardAttributes::invalidate):

LayoutTests:

The layout test below is fixed by this patch.

  • platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-lighting-color-css-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-lighting-color-css-prop-expected.png:
06:20 Changeset [66822] by commit-queue@webkit.org

2010-09-06 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Dirk Schulze.

[WML] Use RenderImageResource in WMLImageElement.cpp
https://bugs.webkit.org/show_bug.cgi?id=44952

The hasImage() and setCachedImage() were moved to RenderImageResource class.
So, WML also should use the functions from RenderImageResource.

  • wml/WMLImageElement.cpp: (WebCore::WMLImageElement::attach):
06:19 MathML 3 testsuite results edited by sausset@gmail.com
(diff)
05:59 Changeset [66821] by abarth@webkit.org

2010-09-06 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

[reviewtool] Add an "ok" button that collapses review comments
https://bugs.webkit.org/show_bug.cgi?id=45255

Many folks (including myself) are too trigger-happy with the "delete"
button that we end up deleting perfectly good review comments. This
patch adds an "ok" button to absorb these clicks (and renames "delete"
to "cancel"). When you click the ok button, the comment becomes
non-editable and the box shrinks to fit the text. You can click the
text to get back to the editable version.

  • code-review.js:
03:33 Changeset [66820] by jorlow@chromium.org

2010-08-26 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Steve Block.

Add index insertion support to IndexedDB.
https://bugs.webkit.org/show_bug.cgi?id=44695

  • storage/indexeddb/objectstore-basics-expected.txt:
  • storage/indexeddb/script-tests/objectstore-basics.js: (createSuccess): (addIndexSuccess): (getSuccess):

2010-08-26 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Steve Block.

Add index insertion support to IndexedDB.
https://bugs.webkit.org/show_bug.cgi?id=44695

Whenever you insert an item into an ObjectStore, it should use all
indexes' key paths to insert corresponding entries into each index.
Also data should be deleted out of the index when it goes away.

Not much testing yet since there's no way to directly observe indexes.
More will be in next patch.

  • storage/IDBDatabaseBackendImpl.cpp: (WebCore::IDBDatabaseBackendImpl::removeObjectStore):
  • storage/IDBFactoryBackendImpl.cpp: (WebCore::createTables):
  • storage/IDBIndex.idl:
  • storage/IDBIndexBackendImpl.cpp: (WebCore::whereClause): (WebCore::bindWhereClause): (WebCore::IDBIndexBackendImpl::addingKeyAllowed):
  • storage/IDBIndexBackendImpl.h: (WebCore::IDBIndexBackendImpl::id):
  • storage/IDBKey.cpp: (WebCore::IDBKey::whereSyntax): (WebCore::IDBKey::bind): (WebCore::IDBKey::bindWithNulls):
  • storage/IDBKey.h:
  • storage/IDBObjectStore.idl:
  • storage/IDBObjectStoreBackendImpl.cpp: (WebCore::whereClause): (WebCore::bindWhereClause): (WebCore::IDBObjectStoreBackendImpl::get): (WebCore::fetchKeyFromKeyPath): (WebCore::putObjectStoreData): (WebCore::putIndexData): (WebCore::IDBObjectStoreBackendImpl::put): (WebCore::IDBObjectStoreBackendImpl::remove): (WebCore::IDBObjectStoreBackendImpl::createIndex): (WebCore::doDelete): (WebCore::IDBObjectStoreBackendImpl::removeIndex): (WebCore::IDBObjectStoreBackendImpl::openCursor):
  • storage/IDBObjectStoreBackendImpl.h:

2010-08-26 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Steve Block.

Add index insertion support to IndexedDB.
https://bugs.webkit.org/show_bug.cgi?id=44695

Add asserts on the [] operator.

  • public/WebVector.h: (WebKit::WebVector::operator[]):
03:19 MathML 3 testsuite results edited by sausset@gmail.com
(diff)
03:09 MathML 3 testsuite results edited by sausset@gmail.com
(diff)
02:56 Changeset [66819] by commit-queue@webkit.org

2010-09-06 Robin Qiu <robin.qiu@torchmobile.com.cn>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=43982
This js file seems to be a popular script for detecting mobile WebKit but
it has a flaw that makes it fail on Android and BlackBerry.

The issue is that it looks for "Mobile/" but Android and BlackBerry
use "Mobile" with no numbering after it.
Changed RegExp pattern " Mobile/" to " Mobile
b".

  • misc/WebKitDetect.js: (WebKitDetect.isMobile):
01:31 Changeset [66818] by antonm@chromium.org

2010-09-06 Anton Muhin <antonm@chromium.org>

Reviewed by Adam Barth.

[v8] bypass caches when query memory usage from post GC and in crash handler.
https://bugs.webkit.org/show_bug.cgi?id=45036

Add Chromium-specific API to query actual memory usage which bypasses any caches.

  • platform/chromium/ChromiumBridge.h:

2010-09-06 Anton Muhin <antonm@chromium.org>

Reviewed by Adam Barth.

[v8] bypass caches when query memory usage from post GC and in crash handler.
https://bugs.webkit.org/show_bug.cgi?id=45036

Add Chromium-specific API to query actual memory usage which bypasses any caches.

  • public/WebKitClient.h: (WebKit::WebKitClient::actualMemoryUsageMB):
  • src/ChromiumBridge.cpp: (WebCore::ChromiumBridge::actualMemoryUsageMB):
01:31 Changeset [66817] by philn@webkit.org

2010-09-06 Philippe Normand <pnormand@igalia.com>

Unreviewed, skipping a crashing media test.

[GStreamer] multiple <video> elements + PulseAudio are crash-prone
https://bugs.webkit.org/show_bug.cgi?id=44235

  • platform/gtk/Skipped: Skip media/controls-styling.html
01:14 Changeset [66816] by rolandsteiner@chromium.org

2010-09-06 Roland Steiner <rolandsteiner@chromium.org>

Unreviewed: upstream Chromium SVG test_expectations

  • platform/chromium/test_expectations.txt:
00:59 Changeset [66815] by abarth@webkit.org

2010-09-06 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Rename SecurityOrigin::canLoad to canDisplay
https://bugs.webkit.org/show_bug.cgi?id=45214

canLoad is a pretty opaque name. This function is really about whether
you can display the contents of the URL in an iframe, an image, or a
plugin.

  • WebCore.exp.in:
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::isSafeToLoadURL):
  • loader/Cache.cpp: (WebCore::Cache::requestResource):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::loadFrameRequest):
  • loader/PingLoader.cpp: (WebCore::PingLoader::loadImage):
  • loader/SubframeLoader.cpp: (WebCore::SubframeLoader::loadMediaPlayerProxyPlugin): (WebCore::SubframeLoader::createJavaAppletWidget): (WebCore::SubframeLoader::loadSubframe): (WebCore::SubframeLoader::loadPlugin):
  • loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::create):
  • page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::canDisplay):
  • page/SecurityOrigin.h:
  • plugins/PluginView.cpp: (WebCore::PluginView::load):

2010-09-06 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Rename SecurityOrigin::canLoad to canDisplay
https://bugs.webkit.org/show_bug.cgi?id=45214

Propagate name change.

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::loadRequest):
  • Plugins/WebNetscapePluginStream.mm: (WebNetscapePluginStream::WebNetscapePluginStream):
  • Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
  • Plugins/WebPluginContainerCheck.mm: (-[WebPluginContainerCheck _isForbiddenFileLoad]):
  • WebView/WebFrame.mm: (-[WebFrame _allowsFollowingLink:]):

2010-09-06 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Rename SecurityOrigin::canLoad to canDisplay
https://bugs.webkit.org/show_bug.cgi?id=45214

Propagate name change.

  • WebFrame.cpp: (WebFrame::allowsFollowingLink):

2010-09-06 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Rename SecurityOrigin::canLoad to canDisplay
https://bugs.webkit.org/show_bug.cgi?id=45214

Propagate name change.

  • WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::performFrameLoadURLRequest):
00:24 Changeset [66814] by abarth@webkit.org

2010-09-06 Adam Barth <abarth@webkit.org>

Update expected results to match change in test. Qt's behavior is
unchanged. It's just the redundant expectations in the test that are
changing.

  • platform/qt/fast/events/continuous-platform-wheelevent-in-scrolling-div-expected.txt:
00:12 Changeset [66813] by yurys@chromium.org

2010-08-31 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Joseph Pecoraro.

Web Inspector: browser crashes on attempt to evaluate "alert(1)" while staying on a breakpoint
https://bugs.webkit.org/show_bug.cgi?id=44943

Test: inspector/debugger-suspend-active-dom-objects.html

  • page/PageGroupLoadDeferrer.cpp: (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):

2010-08-31 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Joseph Pecoraro.

Web Inspector: browser crashes on attempt to evaluate "alert(1)" while staying on a breakpoint
https://bugs.webkit.org/show_bug.cgi?id=44943

  • inspector/debugger-suspend-active-dom-objects-expected.txt: Added.
  • inspector/debugger-suspend-active-dom-objects.html: Added.

09/05/10:

23:50 Changeset [66812] by commit-queue@webkit.org

2010-09-05 Peter Kasting <pkasting@google.com>

Reviewed by Adam Barth.

Make Chromium/Mac generate continuous mousewheel events with the same wheelDelta values as Safari/Mac.
https://bugs.webkit.org/show_bug.cgi?id=45155

  • fast/events/continuous-platform-wheelevent-in-scrolling-div-expected.txt:
  • fast/events/continuous-platform-wheelevent-in-scrolling-div.html:
  • platform/chromium/fast/events: Removed.
  • platform/chromium/fast/events/continuous-platform-wheelevent-in-scrolling-div-expected.txt: Removed.

2010-09-05 Peter Kasting <pkasting@google.com>

Reviewed by Adam Barth.

Make Chromium/Mac generate continuous mousewheel events with the same wheelDelta values as Safari/Mac.
https://bugs.webkit.org/show_bug.cgi?id=45155

  • src/mac/WebInputEventFactory.mm: (WebKit::WebInputEventFactory::mouseWheelEvent):

2010-09-05 Peter Kasting <pkasting@google.com>

Reviewed by Adam Barth.

Make Chromium/Mac generate continuous mousewheel events with the same wheelDelta values as Safari/Mac.
https://bugs.webkit.org/show_bug.cgi?id=45155

  • DumpRenderTree/chromium/EventSender.cpp: Modify Chromium DRT mousewheel event generation to match new behavior on Mac. (EventSender::handleMouseWheel):
23:14 Changeset [66811] by yurys@chromium.org

2010-09-05 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Joseph Pecoraro.

Web Inspector: remove WebDevToolsAgentClient::forceRepaint which is not used
https://bugs.webkit.org/show_bug.cgi?id=45179

  • public/WebDevToolsAgentClient.h:
  • src/DebuggerAgentImpl.cpp: (WebKit::DebuggerAgentImpl::debuggerOutput):
  • src/WebDevToolsAgentImpl.cpp:
  • src/WebDevToolsAgentImpl.h:

2010-09-05 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Joseph Pecoraro.

Web Inspector: remove WebDevToolsAgentClient::forceRepaint which is not used
https://bugs.webkit.org/show_bug.cgi?id=45179

  • DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
  • DumpRenderTree/chromium/DRTDevToolsAgent.h:
22:39 Changeset [66810] by tkent@chromium.org

2010-09-05 Kent Tamura <tkent@chromium.org>

Unreviewed, test expectation update.

  • platform/chromium/drt_expectations.txt: Fix a duplication with test_expectations.txt in Chromium tree.
21:53 Changeset [66809] by kbr@google.com

2010-09-05 Kenneth Russell <kbr@google.com>

Reviewed by Darin Fisher.

Add unit tests for interval tree
https://bugs.webkit.org/show_bug.cgi?id=45161

  • WebKit.gyp:
  • tests/PODIntervalTreeTest.cpp: Added. (WebCore::valueToString): (WebCore::TEST): (WebCore::UserData1::valueToString): (WebCore::EndpointType1::valueToString):
21:38 Changeset [66808] by kbr@google.com

2010-09-05 Kenneth Russell <kbr@google.com>

Reviewed by Darin Fisher.

Add unit tests for red-black tree and (POD) arena
https://bugs.webkit.org/show_bug.cgi?id=45060

  • WebKit.gyp:
  • tests/PODArenaTest.cpp: Added. (WebCore::TestClass1::TestClass2::TestClass2): (WebCore::TEST_F):
  • tests/PODRedBlackTreeTest.cpp: Added. (WebCore::TEST):
  • tests/TreeTestHelpers.cpp: Added. (WebCore::TreeTestHelpers::generateSeed): (WebCore::TreeTestHelpers::initRandom): (WebCore::TreeTestHelpers::nextRandom):
  • tests/TreeTestHelpers.h: Added.

2010-09-05 Kenneth Russell <kbr@google.com>

Reviewed by Darin Fisher.

Add unit tests for red-black tree and (POD) arena
https://bugs.webkit.org/show_bug.cgi?id=45060

  • platform/graphics/gpu/PODArena.h: Made DefaultChunkSize public so unit tests can access it. Fixed copyright header.
  • platform/graphics/gpu/PODInterval.h: Fixed copyright header.
  • platform/graphics/gpu/PODIntervalTree.h: Fixed copyright header.
  • platform/graphics/gpu/PODRedBlackTree.h: Fixed copyright header.
19:29 Changeset [66807] by tkent@chromium.org

2010-09-05 Kent Tamura <tkent@chromium.org>

Unreviewed, test expectation update.

  • platform/chromium/drt_expectations.txt: Apply recent failures.
18:55 Changeset [66806] by tkent@chromium.org

2010-09-05 Kent Tamura <tkent@chromium.org>

Unreviewed, test expectation update.

Add svg/dynamic-update/ image results for Chromium-win and Chromium-linux.

  • platform/chromium-linux/svg/dynamic-updates/SVGCircleElement-dom-cx-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGCircleElement-dom-cx-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGCircleElement-dom-cy-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGCircleElement-dom-cy-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGCircleElement-dom-r-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGCircleElement-dom-r-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGCircleElement-svgdom-cx-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGCircleElement-svgdom-cx-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGCircleElement-svgdom-cy-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGCircleElement-svgdom-cy-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGCircleElement-svgdom-r-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGCircleElement-svgdom-r-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGClipPath-influences-hitTesting-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGClipPath-influences-hitTesting-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGClipPathElement-dom-clipPathUnits-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGClipPathElement-dom-clipPathUnits-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGClipPathElement-svgdom-clipPathUnits-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGClipPathElement-svgdom-clipPathUnits-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGCursorElement-dom-x-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGCursorElement-dom-x-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGCursorElement-dom-y-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGCursorElement-dom-y-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGCursorElement-svgdom-x-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGCursorElement-svgdom-x-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGCursorElement-svgdom-y-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGCursorElement-svgdom-y-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGEllipseElement-dom-cx-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGEllipseElement-dom-cx-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGEllipseElement-dom-cy-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGEllipseElement-dom-cy-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGEllipseElement-dom-rx-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGEllipseElement-dom-rx-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGEllipseElement-dom-ry-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGEllipseElement-dom-ry-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGEllipseElement-svgdom-cx-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGEllipseElement-svgdom-cx-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGEllipseElement-svgdom-cy-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGEllipseElement-svgdom-cy-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGEllipseElement-svgdom-rx-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGEllipseElement-svgdom-rx-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGEllipseElement-svgdom-ry-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGEllipseElement-svgdom-ry-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-diffuseConstant-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-diffuseConstant-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-in-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-in-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-lighting-color-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-lighting-color-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-surfaceScale-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-surfaceScale-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDiffuseLightingElement-lighting-color-css-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDiffuseLightingElement-lighting-color-css-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-diffuseConstant-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-diffuseConstant-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-in-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-in-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-surfaceScale-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-surfaceScale-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEOffsetElement-dom-dx-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEOffsetElement-dom-dx-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEOffsetElement-dom-dy-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEOffsetElement-dom-dy-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEOffsetElement-dom-in-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEOffsetElement-dom-in-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEOffsetElement-svgdom-dx-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEOffsetElement-svgdom-dx-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEOffsetElement-svgdom-dy-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEOffsetElement-svgdom-dy-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEOffsetElement-svgdom-in-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEOffsetElement-svgdom-in-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpotLightElement-dom-limitingConeAngle-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpotLightElement-dom-limitingConeAngle-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtX-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtX-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtY-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtY-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtZ-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtZ-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpotLightElement-dom-specularExponent-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpotLightElement-dom-specularExponent-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpotLightElement-dom-x-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpotLightElement-dom-x-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpotLightElement-dom-y-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpotLightElement-dom-y-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpotLightElement-dom-z-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpotLightElement-dom-z-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpotLightElement-svgdom-limitingConeAngle-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpotLightElement-svgdom-limitingConeAngle-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtX-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtX-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtY-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtY-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtZ-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtZ-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpotLightElement-svgdom-specularExponent-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpotLightElement-svgdom-specularExponent-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpotLightElement-svgdom-x-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpotLightElement-svgdom-x-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpotLightElement-svgdom-y-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpotLightElement-svgdom-y-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpotLightElement-svgdom-z-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFESpotLightElement-svgdom-z-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterElement-dom-filterRes-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterElement-dom-filterRes-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterElement-dom-filterUnits-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterElement-dom-filterUnits-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterElement-dom-height-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterElement-dom-height-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterElement-dom-primitiveUnits-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterElement-dom-primitiveUnits-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterElement-dom-width-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterElement-dom-width-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterElement-dom-x-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterElement-dom-x-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterElement-dom-y-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterElement-dom-y-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterElement-svgdom-filterRes-call-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterElement-svgdom-filterRes-call-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterElement-svgdom-filterResX-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterElement-svgdom-filterResX-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterElement-svgdom-filterResY-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterElement-svgdom-filterResY-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterElement-svgdom-filterUnits-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterElement-svgdom-filterUnits-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterElement-svgdom-height-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterElement-svgdom-height-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterElement-svgdom-primitiveUnits-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterElement-svgdom-primitiveUnits-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterElement-svgdom-width-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterElement-svgdom-width-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterElement-svgdom-x-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterElement-svgdom-x-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterElement-svgdom-y-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterElement-svgdom-y-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-height-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-height-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-result-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-result-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-width-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-width-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-x-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-x-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-y-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-y-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-height-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-height-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-result-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-result-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-width-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-width-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-x-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-x-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-y-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-y-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGForeignObjectElement-dom-height-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGForeignObjectElement-dom-height-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGForeignObjectElement-dom-width-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGForeignObjectElement-dom-width-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGForeignObjectElement-dom-x-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGForeignObjectElement-dom-x-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGForeignObjectElement-dom-y-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGForeignObjectElement-dom-y-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGForeignObjectElement-svgdom-height-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGForeignObjectElement-svgdom-height-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGForeignObjectElement-svgdom-width-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGForeignObjectElement-svgdom-width-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGForeignObjectElement-svgdom-x-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGForeignObjectElement-svgdom-x-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGForeignObjectElement-svgdom-y-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGForeignObjectElement-svgdom-y-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGImageElement-dom-height-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGImageElement-dom-height-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGImageElement-dom-width-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGImageElement-dom-width-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGImageElement-dom-x-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGImageElement-dom-x-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGImageElement-dom-y-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGImageElement-dom-y-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGImageElement-svgdom-x-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGImageElement-svgdom-x-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGImageElement-svgdom-y-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGImageElement-svgdom-y-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLineElement-dom-x1-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLineElement-dom-x1-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLineElement-dom-x2-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLineElement-dom-x2-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLineElement-dom-y1-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLineElement-dom-y1-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLineElement-dom-y2-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLineElement-dom-y2-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLineElement-svgdom-x1-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLineElement-svgdom-x1-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLineElement-svgdom-x2-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLineElement-svgdom-x2-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLineElement-svgdom-y1-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLineElement-svgdom-y1-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLineElement-svgdom-y2-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLineElement-svgdom-y2-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLinearGradientElement-dom-gradientTransform-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLinearGradientElement-dom-gradientTransform-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLinearGradientElement-dom-gradientUnits-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLinearGradientElement-dom-gradientUnits-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLinearGradientElement-dom-x1-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLinearGradientElement-dom-x1-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLinearGradientElement-dom-x2-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLinearGradientElement-dom-x2-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLinearGradientElement-dom-y1-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLinearGradientElement-dom-y1-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLinearGradientElement-dom-y2-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLinearGradientElement-dom-y2-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientTransform-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientTransform-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientUnits-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientUnits-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLinearGradientElement-svgdom-x1-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLinearGradientElement-svgdom-x1-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLinearGradientElement-svgdom-x2-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLinearGradientElement-svgdom-x2-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLinearGradientElement-svgdom-y1-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLinearGradientElement-svgdom-y1-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLinearGradientElement-svgdom-y2-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLinearGradientElement-svgdom-y2-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMarkerElement-dom-markerHeight-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMarkerElement-dom-markerHeight-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMarkerElement-dom-markerUnits-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMarkerElement-dom-markerUnits-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMarkerElement-dom-markerWidth-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMarkerElement-dom-markerWidth-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMarkerElement-dom-orient-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMarkerElement-dom-orient-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMarkerElement-dom-refX-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMarkerElement-dom-refX-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMarkerElement-dom-refY-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMarkerElement-dom-refY-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMarkerElement-svgdom-markerHeight-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMarkerElement-svgdom-markerHeight-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMarkerElement-svgdom-markerUnits-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMarkerElement-svgdom-markerUnits-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMarkerElement-svgdom-markerWidth-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMarkerElement-svgdom-markerWidth-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMarkerElement-svgdom-orientAngle-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMarkerElement-svgdom-orientAngle-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMarkerElement-svgdom-orientType-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMarkerElement-svgdom-orientType-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMarkerElement-svgdom-refX-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMarkerElement-svgdom-refX-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMarkerElement-svgdom-refY-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMarkerElement-svgdom-refY-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMarkerElement-svgdom-setOrientToAngle-call-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMarkerElement-svgdom-setOrientToAngle-call-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMarkerElement-svgdom-setOrientToAuto-call-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMarkerElement-svgdom-setOrientToAuto-call-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMaskElement-dom-height-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMaskElement-dom-height-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMaskElement-dom-maskContentUnits-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMaskElement-dom-maskContentUnits-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMaskElement-dom-maskUnits-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMaskElement-dom-maskUnits-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMaskElement-dom-width-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMaskElement-dom-width-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMaskElement-dom-x-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMaskElement-dom-x-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMaskElement-dom-y-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMaskElement-dom-y-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMaskElement-svgdom-height-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMaskElement-svgdom-height-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMaskElement-svgdom-maskContentUnits-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMaskElement-svgdom-maskContentUnits-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMaskElement-svgdom-maskUnits-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMaskElement-svgdom-maskUnits-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMaskElement-svgdom-width-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMaskElement-svgdom-width-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMaskElement-svgdom-x-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMaskElement-svgdom-x-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMaskElement-svgdom-y-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGMaskElement-svgdom-y-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPatternElement-dom-height-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPatternElement-dom-height-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPatternElement-dom-patternContentUnits-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPatternElement-dom-patternContentUnits-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPatternElement-dom-patternTransform-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPatternElement-dom-patternTransform-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPatternElement-dom-patternUnits-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPatternElement-dom-patternUnits-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPatternElement-dom-width-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPatternElement-dom-width-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPatternElement-dom-x-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPatternElement-dom-x-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPatternElement-dom-y-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPatternElement-dom-y-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPatternElement-svgdom-height-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPatternElement-svgdom-height-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPatternElement-svgdom-patternContentUnits-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPatternElement-svgdom-patternContentUnits-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPatternElement-svgdom-patternTransform-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPatternElement-svgdom-patternTransform-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPatternElement-svgdom-patternUnits-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPatternElement-svgdom-patternUnits-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPatternElement-svgdom-width-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPatternElement-svgdom-width-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPatternElement-svgdom-x-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPatternElement-svgdom-x-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPatternElement-svgdom-y-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPatternElement-svgdom-y-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-dom-cx-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-dom-cx-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-dom-cy-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-dom-cy-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-dom-fx-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-dom-fx-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-dom-fy-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-dom-fy-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-dom-gradientTransform-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-dom-gradientTransform-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-dom-gradientUnits-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-dom-gradientUnits-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-dom-r-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-dom-r-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-svgdom-cx-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-svgdom-cx-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-svgdom-cy-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-svgdom-cy-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-svgdom-fx-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-svgdom-fx-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-svgdom-fy-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-svgdom-fy-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientTransform-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientTransform-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientUnits-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientUnits-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-svgdom-r-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-svgdom-r-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRectElement-dom-height-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRectElement-dom-height-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRectElement-dom-width-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRectElement-dom-width-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRectElement-dom-x-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRectElement-dom-x-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRectElement-dom-y-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRectElement-dom-y-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRectElement-svgdom-height-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRectElement-svgdom-height-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRectElement-svgdom-width-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRectElement-svgdom-width-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRectElement-svgdom-x-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRectElement-svgdom-x-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRectElement-svgdom-y-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRectElement-svgdom-y-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGTRefElement-dom-href-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGTRefElement-dom-href-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGTextElement-dom-transform-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGTextElement-dom-transform-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGTextElement-svgdom-transform-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGTextElement-svgdom-transform-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGCircleElement-dom-cx-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGCircleElement-dom-cx-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGCircleElement-dom-cy-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGCircleElement-dom-cy-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGCircleElement-dom-r-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGCircleElement-dom-r-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGCircleElement-svgdom-cx-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGCircleElement-svgdom-cx-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGCircleElement-svgdom-cy-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGCircleElement-svgdom-cy-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGCircleElement-svgdom-r-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGCircleElement-svgdom-r-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGClipPath-influences-hitTesting-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGClipPath-influences-hitTesting-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGClipPathElement-dom-clipPathUnits-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGClipPathElement-dom-clipPathUnits-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGClipPathElement-svgdom-clipPathUnits-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGClipPathElement-svgdom-clipPathUnits-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGCursorElement-dom-x-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGCursorElement-dom-x-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGCursorElement-dom-y-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGCursorElement-dom-y-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGCursorElement-svgdom-x-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGCursorElement-svgdom-x-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGCursorElement-svgdom-y-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGCursorElement-svgdom-y-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGEllipseElement-dom-cx-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGEllipseElement-dom-cx-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGEllipseElement-dom-cy-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGEllipseElement-dom-cy-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGEllipseElement-dom-rx-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGEllipseElement-dom-rx-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGEllipseElement-dom-ry-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGEllipseElement-dom-ry-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGEllipseElement-svgdom-cx-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGEllipseElement-svgdom-cx-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGEllipseElement-svgdom-cy-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGEllipseElement-svgdom-cy-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGEllipseElement-svgdom-rx-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGEllipseElement-svgdom-rx-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGEllipseElement-svgdom-ry-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGEllipseElement-svgdom-ry-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-diffuseConstant-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-diffuseConstant-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-in-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-in-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-lighting-color-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-lighting-color-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-surfaceScale-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-surfaceScale-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEDiffuseLightingElement-lighting-color-css-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEDiffuseLightingElement-lighting-color-css-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-diffuseConstant-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-diffuseConstant-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-in-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-in-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-surfaceScale-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-surfaceScale-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEOffsetElement-dom-dx-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEOffsetElement-dom-dx-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEOffsetElement-dom-dy-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEOffsetElement-dom-dy-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEOffsetElement-dom-in-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEOffsetElement-dom-in-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEOffsetElement-svgdom-dx-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEOffsetElement-svgdom-dx-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEOffsetElement-svgdom-dy-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEOffsetElement-svgdom-dy-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEOffsetElement-svgdom-in-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEOffsetElement-svgdom-in-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFESpotLightElement-dom-limitingConeAngle-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFESpotLightElement-dom-limitingConeAngle-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtX-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtX-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtY-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtY-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtZ-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtZ-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFESpotLightElement-dom-specularExponent-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFESpotLightElement-dom-specularExponent-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFESpotLightElement-dom-x-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFESpotLightElement-dom-x-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFESpotLightElement-dom-y-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFESpotLightElement-dom-y-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFESpotLightElement-dom-z-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFESpotLightElement-dom-z-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFESpotLightElement-svgdom-limitingConeAngle-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFESpotLightElement-svgdom-limitingConeAngle-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtX-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtX-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtY-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtY-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtZ-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtZ-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFESpotLightElement-svgdom-specularExponent-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFESpotLightElement-svgdom-specularExponent-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFESpotLightElement-svgdom-x-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFESpotLightElement-svgdom-x-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFESpotLightElement-svgdom-y-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFESpotLightElement-svgdom-y-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFESpotLightElement-svgdom-z-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFESpotLightElement-svgdom-z-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterElement-dom-filterRes-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterElement-dom-filterRes-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterElement-dom-filterUnits-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterElement-dom-filterUnits-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterElement-dom-height-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterElement-dom-height-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterElement-dom-primitiveUnits-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterElement-dom-primitiveUnits-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterElement-dom-width-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterElement-dom-width-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterElement-dom-x-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterElement-dom-x-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterElement-dom-y-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterElement-dom-y-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterElement-svgdom-filterRes-call-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterElement-svgdom-filterRes-call-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterElement-svgdom-filterResX-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterElement-svgdom-filterResX-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterElement-svgdom-filterResY-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterElement-svgdom-filterResY-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterElement-svgdom-filterUnits-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterElement-svgdom-filterUnits-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterElement-svgdom-height-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterElement-svgdom-height-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterElement-svgdom-primitiveUnits-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterElement-svgdom-primitiveUnits-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterElement-svgdom-width-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterElement-svgdom-width-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterElement-svgdom-x-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterElement-svgdom-x-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterElement-svgdom-y-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterElement-svgdom-y-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-height-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-height-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-result-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-result-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-width-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-width-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-x-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-x-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-y-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-y-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-height-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-height-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-result-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-result-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-width-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-width-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-x-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-x-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-y-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-y-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGForeignObjectElement-dom-height-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGForeignObjectElement-dom-height-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGForeignObjectElement-dom-width-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGForeignObjectElement-dom-width-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGForeignObjectElement-dom-x-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGForeignObjectElement-dom-x-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGForeignObjectElement-dom-y-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGForeignObjectElement-dom-y-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGForeignObjectElement-svgdom-height-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGForeignObjectElement-svgdom-height-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGForeignObjectElement-svgdom-width-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGForeignObjectElement-svgdom-width-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGForeignObjectElement-svgdom-x-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGForeignObjectElement-svgdom-x-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGForeignObjectElement-svgdom-y-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGForeignObjectElement-svgdom-y-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGImageElement-dom-height-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGImageElement-dom-height-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGImageElement-dom-width-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGImageElement-dom-width-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGImageElement-dom-x-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGImageElement-dom-x-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGImageElement-dom-y-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGImageElement-dom-y-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGImageElement-svgdom-x-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGImageElement-svgdom-x-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGImageElement-svgdom-y-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGImageElement-svgdom-y-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLineElement-dom-x1-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLineElement-dom-x1-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLineElement-dom-x2-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLineElement-dom-x2-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLineElement-dom-y1-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLineElement-dom-y1-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLineElement-dom-y2-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLineElement-dom-y2-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLineElement-svgdom-x1-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLineElement-svgdom-x1-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLineElement-svgdom-x2-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLineElement-svgdom-x2-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLineElement-svgdom-y1-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLineElement-svgdom-y1-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLineElement-svgdom-y2-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLineElement-svgdom-y2-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLinearGradientElement-dom-gradientTransform-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLinearGradientElement-dom-gradientTransform-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLinearGradientElement-dom-gradientUnits-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLinearGradientElement-dom-gradientUnits-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLinearGradientElement-dom-x1-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLinearGradientElement-dom-x1-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLinearGradientElement-dom-x2-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLinearGradientElement-dom-x2-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLinearGradientElement-dom-y1-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLinearGradientElement-dom-y1-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLinearGradientElement-dom-y2-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLinearGradientElement-dom-y2-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientTransform-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientTransform-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientUnits-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientUnits-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLinearGradientElement-svgdom-x1-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLinearGradientElement-svgdom-x1-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLinearGradientElement-svgdom-x2-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLinearGradientElement-svgdom-x2-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLinearGradientElement-svgdom-y1-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLinearGradientElement-svgdom-y1-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLinearGradientElement-svgdom-y2-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLinearGradientElement-svgdom-y2-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMarkerElement-dom-markerHeight-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMarkerElement-dom-markerHeight-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMarkerElement-dom-markerUnits-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMarkerElement-dom-markerUnits-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMarkerElement-dom-markerWidth-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMarkerElement-dom-markerWidth-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMarkerElement-dom-orient-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMarkerElement-dom-orient-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMarkerElement-dom-refX-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMarkerElement-dom-refX-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMarkerElement-dom-refY-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMarkerElement-dom-refY-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMarkerElement-svgdom-markerHeight-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMarkerElement-svgdom-markerHeight-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMarkerElement-svgdom-markerUnits-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMarkerElement-svgdom-markerUnits-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMarkerElement-svgdom-markerWidth-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMarkerElement-svgdom-markerWidth-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMarkerElement-svgdom-orientAngle-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMarkerElement-svgdom-orientAngle-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMarkerElement-svgdom-orientType-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMarkerElement-svgdom-orientType-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMarkerElement-svgdom-refX-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMarkerElement-svgdom-refX-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMarkerElement-svgdom-refY-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMarkerElement-svgdom-refY-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMarkerElement-svgdom-setOrientToAngle-call-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMarkerElement-svgdom-setOrientToAngle-call-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMarkerElement-svgdom-setOrientToAuto-call-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMarkerElement-svgdom-setOrientToAuto-call-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMaskElement-dom-height-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMaskElement-dom-height-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMaskElement-dom-maskContentUnits-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMaskElement-dom-maskContentUnits-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMaskElement-dom-maskUnits-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMaskElement-dom-maskUnits-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMaskElement-dom-width-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMaskElement-dom-width-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMaskElement-dom-x-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMaskElement-dom-x-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMaskElement-dom-y-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMaskElement-dom-y-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMaskElement-svgdom-height-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMaskElement-svgdom-height-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMaskElement-svgdom-maskContentUnits-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMaskElement-svgdom-maskContentUnits-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMaskElement-svgdom-maskUnits-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMaskElement-svgdom-maskUnits-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMaskElement-svgdom-width-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMaskElement-svgdom-width-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMaskElement-svgdom-x-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMaskElement-svgdom-x-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMaskElement-svgdom-y-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGMaskElement-svgdom-y-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPatternElement-dom-height-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPatternElement-dom-height-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPatternElement-dom-patternContentUnits-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPatternElement-dom-patternContentUnits-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPatternElement-dom-patternTransform-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPatternElement-dom-patternTransform-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPatternElement-dom-patternUnits-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPatternElement-dom-patternUnits-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPatternElement-dom-width-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPatternElement-dom-width-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPatternElement-dom-x-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPatternElement-dom-x-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPatternElement-dom-y-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPatternElement-dom-y-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPatternElement-svgdom-height-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPatternElement-svgdom-height-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPatternElement-svgdom-patternContentUnits-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPatternElement-svgdom-patternContentUnits-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPatternElement-svgdom-patternTransform-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPatternElement-svgdom-patternTransform-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPatternElement-svgdom-patternUnits-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPatternElement-svgdom-patternUnits-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPatternElement-svgdom-width-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPatternElement-svgdom-width-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPatternElement-svgdom-x-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPatternElement-svgdom-x-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPatternElement-svgdom-y-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPatternElement-svgdom-y-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-dom-cx-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-dom-cx-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-dom-cy-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-dom-cy-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-dom-fx-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-dom-fx-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-dom-fy-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-dom-fy-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-dom-gradientTransform-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-dom-gradientTransform-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-dom-gradientUnits-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-dom-gradientUnits-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-dom-r-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-dom-r-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-svgdom-cx-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-svgdom-cx-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-svgdom-cy-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-svgdom-cy-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-svgdom-fx-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-svgdom-fx-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-svgdom-fy-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-svgdom-fy-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientTransform-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientTransform-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientUnits-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientUnits-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-svgdom-r-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-svgdom-r-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRectElement-dom-height-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRectElement-dom-height-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRectElement-dom-width-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRectElement-dom-width-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRectElement-dom-x-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRectElement-dom-x-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRectElement-dom-y-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRectElement-dom-y-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRectElement-svgdom-height-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRectElement-svgdom-height-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRectElement-svgdom-width-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRectElement-svgdom-width-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRectElement-svgdom-x-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRectElement-svgdom-x-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRectElement-svgdom-y-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRectElement-svgdom-y-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGTRefElement-dom-href-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGTRefElement-dom-href-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGTextElement-dom-transform-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGTextElement-dom-transform-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGTextElement-svgdom-transform-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGTextElement-svgdom-transform-prop-expected.png: Added.
  • platform/chromium/drt_expectations.txt:
18:39 Changeset [66805] by tkent@chromium.org

2010-09-05 Kent Tamura <tkent@chromium.org>

Unreviewed, test expectation update.

Update Chromium-mac results for dynamic-updates.

  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientTransform-prop-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGPatternElement-svgdom-patternTransform-prop-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientTransform-prop-expected.checksum: Added.
  • platform/chromium/drt_expectations.txt:
  • platform/chromium/test_expectations.txt:
16:26 WebKit Team edited by andreas.kling@nokia.com
(diff)
16:20 Changeset [66804] by andreas.kling@nokia.com

2010-09-05 Andreas Kling <andreas.kling@nokia.com>

Rubber-stamped by Daniel Bates.

Adding myself as reviewer.

  • Scripts/webkitpy/common/config/committers.py:
09:30 Changeset [66803] by commit-queue@webkit.org

2010-09-05 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r66801.
http://trac.webkit.org/changeset/66801
https://bugs.webkit.org/show_bug.cgi?id=45242

'breaks editing/pasteboard/onpaste-text-html.html' (Requested
by mwenge4 on #webkit).

  • platform/qt/Skipped:

2010-09-05 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r66801.
http://trac.webkit.org/changeset/66801
https://bugs.webkit.org/show_bug.cgi?id=45242

'breaks editing/pasteboard/onpaste-text-html.html' (Requested
by mwenge4 on #webkit).

  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::addMessageToConsole):
08:08 Changeset [66802] by jorlow@chromium.org

2010-09-05 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Steve Block.

Add IndexedDB objects' constructors to window
https://bugs.webkit.org/show_bug.cgi?id=44599

Beef up keyRange test to verify we're actualy operating
on the interface rather than an instance.

Add a test to verify the constants.

  • storage/indexeddb/constants.html:
  • storage/indexeddb/constants-expected.txt:
  • storage/indexeddb/keyrange-expected.txt:
  • storage/indexeddb/script-tests/keyrange.js: ():

2010-09-05 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Nate Chapin.

Add the concept of class methods to bindings (for IndexedDB's IDBKeyRange).
https://bugs.webkit.org/show_bug.cgi?id=45044

IndexedDB's IDBKeyRange has what, in other languages, are called class
methods. In javaScript terms, these are methods only accessible from their
constructor and not instances. This change adds such support to V8. There
are already other features required for IndexedDB that JSC doesn't yet
support, so I'll add this to the list of todo items in the master bug
for that.

The bindings tests cover this. My next patch will change WebCore to use
this and it'll have associated layout tests.

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/scripts/test/CPP/WebDOMTestObj.cpp: (WebDOMTestObj::classMethod): (WebDOMTestObj::classMethodWithOptional):
  • bindings/scripts/test/CPP/WebDOMTestObj.h:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: (webkit_dom_test_obj_class_method): (webkit_dom_test_obj_class_method_with_optional):
  • bindings/scripts/test/GObject/WebKitDOMTestObj.h:
  • bindings/scripts/test/JS/JSTestObj.cpp: (WebCore::jsTestObjPrototypeFunctionStaticMethod): (WebCore::jsTestObjPrototypeFunctionStaticMethodWithOptional):
  • bindings/scripts/test/JS/JSTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.mm: (-[DOMTestObj classMethod]): (-[DOMTestObj classMethodWithOptional:]):
  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/V8/V8TestObj.cpp: (WebCore::TestObjInternal::classMethodCallback): (WebCore::TestObjInternal::classMethodWithOptionalCallback): (WebCore::ConfigureV8TestObjTemplate):
  • storage/IDBKeyRange.idl:
07:28 Changeset [66801] by robert@webkit.org

2010-09-05 Robert Hogan <robert@webkit.org>

Reviewed by Antonio Gomes.

[Qt] utf8 encoding of console() messages

Unskip:
http/tests/security/xssAuditor/embed-tag-null-char.html
http/tests/security/xssAuditor/object-embed-tag-null-char.html

https://bugs.webkit.org/show_bug.cgi?id=45240

  • platform/qt/Skipped:

2010-09-05 Robert Hogan <robert@webkit.org>

Reviewed by Antonio Gomes.

[Qt] utf8 encoding of console() messages

http/tests/security/xssAuditor/embed-tag-null-char.html
http/tests/security/xssAuditor/object-embed-tag-null-char.html

both fail because ChromeClientQt::addMessageToConsole() is
casting String to QString rather than String::utf8().data()

https://bugs.webkit.org/show_bug.cgi?id=45240

  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::addMessageToConsole):

09/04/10:

18:12 Changeset [66800] by dbates@webkit.org

2010-09-04 Daniel Bates <dbates@rim.com>

Reviewed by Martin Robinson.

Teach svn-apply/unapply about svn:mergeinfo
https://bugs.webkit.org/show_bug.cgi?id=45236

Recognize the svn:mergeinfo property and ignore it for now.

Currently, svn-apply/unapply recognize only '+' and '-'
property changes within a diff. We should add support
to recognize "Merged" and "Reverse-merged" changes as well.
Because svn:mergeinfo is metadata that is used only by SVN
and tends to be error-prone and/or nuisance (*), we will ignore
it for now.
(*) See "Parting Thoughts" of <http://www.collab.net/community/subversion/articles/merge-info.html>.

  • Scripts/VCSUtils.pm:
    • Modified parseSvnProperty() to recognize "Merged" and "Reverse-merged" as the start of a property value.
  • Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffFooter.pl:
    • Added the following unit tests: "simple: add svn:mergeinfo" "simple: delete svn:mergeinfo" "simple: modified svn:mergeinfo"
  • Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
    • Added the following unit tests: "simple: add svn:mergeinfo" "simple: delete svn:mergeinfo" "simple: modified svn:mergeinfo" "simple: modified svn:mergeinfo using SVN 1.4 syntax" "'Merged' change followed by 'Merged' change" "'Reverse-merged' change followed by 'Reverse-merged' change"
  • Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
    • Added the following unit tests: "'Merged' change" "'Reverse-merged' change" "'Reverse-merged' change followed by 'Merge' change" "'Merged' change followed by 'Merge' change" "'Reverse-merged' change followed by 'Reverse-merged' change" "'Reverse-merged' change followed by 'Reverse-merged' change followed by 'Merged' change"
17:19 Changeset [66799] by weinig@apple.com

Allow passing null to postMessage API functions
https://bugs.webkit.org/show_bug.cgi?id=45234

Reviewed by Anders Carlsson.

  • Shared/APIObject.h: Add TypeNull to enum. This is only used

for serialization purposes, and does not represent a concrete subclass
of APIObject.

  • Shared/CoreIPCSupport/WebPageProxyMessageKinds.h: Remove WillSubmitFormWithUserData

now that it is not needed.

  • Shared/UserMessageCoders.h:

(WebKit::UserMessageEncoder::baseEncode):
(WebKit::UserMessageDecoder::baseDecode):
Add explicit encoding/decoding of null for user messages.

  • UIProcess/WebContextUserMessageCoders.h:

(WebKit::WebContextUserMessageEncoder::encode):
(WebKit::WebContextUserMessageDecoder::decode):

  • WebProcess/InjectedBundle/InjectedBundleUserMessageCoders.h:

(WebKit::InjectedBundleUserMessageEncoder::encode):
(WebKit::InjectedBundleUserMessageDecoder::decode):
Update UserMessageCoders subclasses to call the base class in the correct
way to work with null messages. This means moving the encoding/decoding
of the type down to the base class, which is a nice cleanup.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didReceiveMessage):
Remove now redundant WillSubmitFormWithUserData implementation.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchWillSubmitForm):
Ditto.

16:28 Changeset [66798] by steveblock@google.com

2010-09-04 Steve Block <steveblock@google.com>

Reviewed by Martin Robinson.

GTK Skipped list should allow a directory to be listed when a feature is not supported
https://bugs.webkit.org/show_bug.cgi?id=45229

This change updates the comment in the GTK Skipped list to make this
clear and applies the new policy for the DeviceOrientation and
DeviceMotion tests.

  • platform/gtk/Skipped:
15:04 Changeset [66797] by commit-queue@webkit.org

2010-09-04 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Move test browser to WebKitTools directory
https://bugs.webkit.org/show_bug.cgi?id=45212

Follow other ports like QT and GTK which moved the test browser to
WebKitTools directory.

  • CMakeLists.txt: Include test browser if port defines one.

2010-09-04 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Move test browser to WebKitTools directory
https://bugs.webkit.org/show_bug.cgi?id=45212

Follow other ports like QT and GTK which moved the test browser to
WebKitTools directory.

  • CMakeListsEfl.txt: Remove build for test browser.
  • EWebLauncher/main.c: Removed.

2010-09-04 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Move test browser to WebKitTools directory
https://bugs.webkit.org/show_bug.cgi?id=45212

Follow other ports like QT and GTK which moved the test browser to
WebKitTools directory.

  • CMakeListsEfl.txt: Added.
  • EWebLauncher/main.c: Added. (print_history): (zoom_level_set): (on_ecore_evas_resize): (title_set): (viewport_set): (on_title_changed): (on_progress): (on_load_finished): (on_toolbars_visible_set): (on_toolbars_visible_get): (on_statusbar_visible_set): (on_statusbar_visible_get): (on_scrollbars_visible_set): (on_scrollbars_visible_get): (on_menubar_visible_set): (on_menubar_visible_get): (on_tooltip_text_set): (on_inputmethod_changed): (on_viewport_changed): (on_mouse_down): (on_focus_out): (on_focus_in): (on_resized): (on_key_down): (on_browser_del): (on_closeWindow): (quit): (browserCreate): (browserDestroy): (closeWindow): (main_signal_exit): (findThemePath): (main):
09:24 Changeset [66796] by jschuh@chromium.org

2010-09-04 Justin Schuh <jschuh@chromium.org>

Unreviewed. Build fix.

Updated platform test to account for xml parser differences

  • platform/mac-leopard/svg/custom/use-invalid-style-expected.txt: Added.
  • platform/qt/svg/custom/use-invalid-style-expected.txt: Added.
  • svg/custom/use-invalid-style-expected.txt:
08:45 Changeset [66795] by jschuh@chromium.org

2010-09-04 Justin Schuh <jschuh@chromium.org>

Reviewed by Nikolas Zimmermann.

Prevent premature deletion of svg use shadow tree
https://bugs.webkit.org/show_bug.cgi?id=43260

Test: svg/custom/use-invalid-style.svg

  • svg/SVGUseElement.cpp: (WebCore::SVGUseElement::insertedIntoDocument): (WebCore::SVGUseElement::removedFromDocument): (WebCore::SVGUseElement::detach):

2010-09-04 Justin Schuh <jschuh@chromium.org>

Reviewed by Nikolas Zimmermann.

Check for premature deletion of svg use shadow style element
https://bugs.webkit.org/show_bug.cgi?id=43260

  • svg/custom/use-invalid-style-expected.txt: Added.
  • svg/custom/use-invalid-style.svg: Added.
07:48 Changeset [66794] by diegohcg@webkit.org

Add NetworkingContext to avoid layer violations
https://bugs.webkit.org/show_bug.cgi?id=42292

Patch by Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> on 2010-09-03
Reviewed by Darin Adler.

WebCore:

Create and provide access to NetworkingContext in FrameLoader.

In the WebKit layer we added specific implementations of FrameNetworkingContext
so each port's FrameLoaderClient can add any port specific information to NetworkingContext
The NetworkingContext is, therefore, created by a FrameLoaderClient and stored
in the FrameLoader for each frame created. People must always use it
by calling FrameLoader::networkingContext() and never through their FrameLoaderClient.
The lifetime cycle of NetworkingContext is kept by a RefPtr, so the object is RefCounted.

It is still a preparation to NetworkingContext to be activated and
work for all ports.

  • WebCore.exp.in:
  • loader/EmptyClients.h:

(WebCore::EmptyFrameLoaderClient::createNetworkingContext):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::~FrameLoader):
(WebCore::FrameLoader::init):
(WebCore::FrameLoader::networkingContext):

  • loader/FrameLoader.h:
  • loader/FrameLoaderClient.h:

WebKit/chromium:

Add Chromium's implementation of NetworkingContext.

  • src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::createNetworkingContext):

  • src/FrameLoaderClientImpl.h:

WebKit/efl:

Add createNetworkingContext to EFL's FrameLoaderClient.

  • WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore::FrameLoaderClientEfl::createNetworkingContext):

  • WebCoreSupport/FrameLoaderClientEfl.h:

WebKit/gtk:

Add GTK's specific implementation of FrameNetworkingContext.

  • WebCoreSupport/FrameLoaderClientGtk.cpp:

(WebKit::FrameLoaderClient::createNetworkingContext):

  • WebCoreSupport/FrameLoaderClientGtk.h:

WebKit/mac:

Add Mac's specific implementation of FrameNetworkingContext.

  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm:
  • WebCoreSupport/WebFrameNetworkingContext.mm:

(WebFrameNetworkingContext::needsSiteSpecificQuirks):
(WebFrameNetworkingContext::localFileContentSniffingEnabled):
(WebFrameNetworkingContext::scheduledRunLoopPairs):
(WebFrameNetworkingContext::blockedError):

WebKit/qt:

Add Qt's specific implementation of NetworkingContext.

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::setFrame):
(WebCore::FrameLoaderClientQt::createNetworkingContext):

  • WebCoreSupport/FrameLoaderClientQt.h:
  • WebCoreSupport/FrameNetworkingContextQt.cpp:

(WebCore::FrameNetworkingContextQt::FrameNetworkingContextQt):
(WebCore::FrameNetworkingContextQt::create):
(WebCore::FrameNetworkingContextQt::originatingObject):
(WebCore::FrameNetworkingContextQt::networkAccessManager):

WebKit/win:

Add Win's specific implementation of NetworkingContext.

  • WebCoreSupport/WebFrameNetworkingContext.cpp:

(WebFrameNetworkingContext::create):
(WebFrameNetworkingContext::userAgent):
(WebFrameNetworkingContext::referrer):

  • WebFrame.cpp:

(WebFrame::createNetworkingContext):

  • WebFrame.h:

WebKit2:

Add FrameNetworkingContext implementation.

  • WebKit2.pro:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::createNetworkingContext):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
  • WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:

(WebKit::WebFrameNetworkingContext::needsSiteSpecificQuirks):
(WebKit::WebFrameNetworkingContext::localFileContentSniffingEnabled):
(WebKit::WebFrameNetworkingContext::scheduledRunLoopPairs):
(WebKit::WebFrameNetworkingContext::blockedError):

  • WebProcess/WebCoreSupport/qt/WebFrameNetworkingContext.cpp: Added.

(WebCore::WebFrameNetworkingContext::WebFrameNetworkingContext):
(WebCore::WebFrameNetworkingContext::create):
(WebCore::WebFrameNetworkingContext::originatingObject):
(WebCore::WebFrameNetworkingContext::networkAccessManager):

  • WebProcess/WebCoreSupport/qt/WebFrameNetworkingContext.h: Added.
  • WebProcess/WebCoreSupport/win/WebFrameNetworkingContext.cpp: Added.
  • WebProcess/WebCoreSupport/win/WebFrameNetworkingContext.h: Added.

(WebFrameNetworkingContext::create):
(WebFrameNetworkingContext::WebFrameNetworkingContext):

  • win/WebKit2.vcproj:
  • win/WebKit2Common.vsprops:
05:31 Changeset [66793] by steveblock@google.com

Unreviewed.

Remove platform/android/Skipped which was erroneously added in
http://trac.webkit.org/changeset/66251. Android does not use a Skipped list.

  • platform/android/Skipped: Removed.
Note: See TracTimeline for information about the timeline view.