Timeline


and

09/14/10:

23:41 Changeset [67538] by kinuko@chromium.org

2010-09-14 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by Dumitru Daniliuc.

Add custom binding code for DirectoryEntry to allow JSON parameters for Flags
https://bugs.webkit.org/show_bug.cgi?id=45724

No new tests; tests will be added later.

  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDirectoryEntryCustom.cpp: Added. (WebCore::JSDirectoryEntry::getFile): (WebCore::JSDirectoryEntry::getDirectory):
  • bindings/v8/custom/V8DirectoryEntryCustom.cpp: Added. (WebCore::V8DirectoryEntry::getDirectoryCallback): (WebCore::V8DirectoryEntry::getFileCallback):
  • fileapi/DirectoryEntry.h:
  • fileapi/DirectoryEntry.idl:
22:59 Changeset [67537] by johnnyg@google.com

2010-09-14 John Gregg <johnnyg@google.com>

Unreviewed, chromium rebaseline to fix build.

[chromium] rebaselines for bug16012.html after font-size changes
https://bugs.webkit.org/show_bug.cgi?id=45805

  • platform/chromium-linux/tables/mozilla/bugs/bug16012-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug16012-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/bugs/bug16012-expected.txt: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug16012-expected.checksum: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug16012-expected.png: Added.
  • platform/chromium-win/tables/mozilla/bugs/bug16012-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug16012-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug16012-expected.txt:
22:26 Changeset [67536] by johnnyg@google.com

2010-09-14 John Gregg <johnnyg@google.com>

Unreviewed, chromium rebaseline.

Rebaseline xss-DENIED-frame-name-expected.txt
https://bugs.webkit.org/show_bug.cgi?id=45795

  • platform/chromium-linux/http/tests/security/xss-DENIED-frame-name-expected.txt: Added.
  • platform/chromium-mac/http/tests/security/xss-DENIED-frame-name-expected.txt: Added.
  • platform/chromium-win/http/tests/security/xss-DENIED-frame-name-expected.txt: Added.
22:03 Changeset [67535] by abarth@webkit.org

2010-09-14 Adam Barth <abarth@webkit.org>

Attempt to fix test failure on Qt and Gtk. It's tricky to write a test
for an API that supposed to report the current date and time without a
timezone. This patch increases the allowably time window to a day +
one hour, which should be enough to account for any timezone issues.

  • http/tests/misc/no-last-modified.html:
21:38 Changeset [67534] by commit-queue@webkit.org

2010-09-14 Jia Pu <jpu@apple.com>

Reviewed by Dan Bernstein.

Only intercept ESC key press when autocorrection UI is visible.
https://bugs.webkit.org/show_bug.cgi?id=45071

Only intercept ESC key when autocorrection panel is shown. Otherwise pressing
ESC will cancel current loading like usual.

  • editing/Editor.cpp: (WebCore::Editor::isShowingCorrectionPanel): Query editor client whether autocorrection panel is shown.
  • editing/Editor.h: Added declaration of isShowingCorrectionPanel().
  • editing/EditorCommand.cpp: (WebCore::supportedDismissCorrectionPanel): Only support executeCancelOperation() when autocorrection panel is shown. (WebCore::createCommandMap): Replaced isSupported function pointer for executeCancelOperation() command with supportedDismissCorrectionPanel().
  • loader/EmptyClients.h: (WebCore::EmptyEditorClient::isShowingCorrectionPanel): Dummy implementation of new member method declared in base class.
  • page/EditorClient.h: Declared new member method isShowingCorrectionPanel().

2010-09-14 Jia Pu <jpu@apple.com>

Reviewed by Dan Bernstein.

Only intercept ESC key press when autocorrection UI is visible.
https://bugs.webkit.org/show_bug.cgi?id=45071

  • WebCoreSupport/WebEditorClient.h: Added declaration of isShowingCorrectionPanel(), which provides an inteface to query whether autocorrection panel is shown.
  • WebCoreSupport/WebEditorClient.mm: (WebEditorClient::WebEditorClient): Defined a constant, InvalidCorrectionPanelTag, for invalid correction panel tag. Replaced -1 with this constant. (WebEditorClient::dismissCorrectionPanel): Ditto (WebEditorClient::isShowingCorrectionPanel): Query whether autocorrection panel is shown.

2010-09-14 Jia Pu <jpu@apple.com>

Reviewed by Dan Bernstein.

Only intercept ESC key press when autocorrection UI is visible.
https://bugs.webkit.org/show_bug.cgi?id=45071

  • WebProcess/WebCoreSupport/WebEditorClient.cpp: (WebKit::WebEditorClient::isShowingCorrectionPanel): Dummy implementation.
  • WebProcess/WebCoreSupport/WebEditorClient.h: Adopt new method delcared in base class.
21:09 Changeset [67533] by commit-queue@webkit.org

2010-09-14 Jia Pu <jpu@apple.com>

Reviewed by Dan Bernstein.

WebKit should use system wide spell checking preference when application specific one isn't set.
https://bugs.webkit.org/show_bug.cgi?id=45789

  • WebView/WebView.mm: (+[WebView initialize]): Use system wide autocorrection and text substitution preferences

when the application level preferences are not set.

20:47 Changeset [67532] by commit-queue@webkit.org

2010-09-14 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r67503.
http://trac.webkit.org/changeset/67503
https://bugs.webkit.org/show_bug.cgi?id=45802

This patch broke GTK builds (Requested by jianli_ on #webkit).

  • fast/files/apply-blob-url-to-img.html:
  • platform/mac/Skipped:

2010-09-14 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r67503.
http://trac.webkit.org/changeset/67503
https://bugs.webkit.org/show_bug.cgi?id=45802

This patch broke GTK builds (Requested by jianli_ on #webkit).

  • fileapi/ThreadableBlobRegistry.cpp: (WebCore::BlobRegistryContext::BlobRegistryContext):
  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::resourceData): (WebCore::ResourceLoader::addData):
  • platform/network/BlobResourceHandle.cpp:
  • platform/network/BlobResourceHandle.h:
  • platform/network/ResourceHandle.h:
  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::bufferedData):

2010-09-14 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r67503.
http://trac.webkit.org/changeset/67503
https://bugs.webkit.org/show_bug.cgi?id=45802

This patch broke GTK builds (Requested by jianli_ on #webkit).

  • src/ResourceHandle.cpp:
20:37 Changeset [67531] by commit-queue@webkit.org

2010-09-14 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Zoom factor for checkboxes and radios.
https://bugs.webkit.org/show_bug.cgi?id=45776

RenderThemeQt does not consider RenderStyle::effectiveZoom when calculating sizes of
checkboxes and radios.

Even with this change the used QStyle must support different sizes for radios and checkboxes.
QWindowStyle and QMacStyle, for example, do not.

  • platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::computeSizeBasedOnStyle):
20:19 Changeset [67530] by crogers@google.com

2010-09-14 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

audio engine: add AudioFileReader files (Mac implementation)
https://bugs.webkit.org/show_bug.cgi?id=36475

No new tests since audio API is not yet implemented.

  • platform/audio/AudioFileReader.h: Added.
  • platform/audio/mac/AudioFileReaderMac.cpp: Added. (WebCore::createAudioBufferList): (WebCore::destroyAudioBufferList): (WebCore::AudioFileReader::AudioFileReader): (WebCore::AudioFileReader::~AudioFileReader): (WebCore::AudioFileReader::readProc): (WebCore::AudioFileReader::getSizeProc): (WebCore::AudioFileReader::createBus): (WebCore::createBusFromAudioFile): (WebCore::createBusFromInMemoryAudioFile):
  • platform/audio/mac/AudioFileReaderMac.h: Added. (WebCore::AudioFileReader::data): (WebCore::AudioFileReader::dataSize):
19:31 Changeset [67529] by commit-queue@webkit.org

2010-09-14 Hyung Song <beergun@company100.net>

Reviewed by Kent Tamura.

[BREWMP] Add IMemGroup and IMemSpace to OwnPtr type.
https://bugs.webkit.org/show_bug.cgi?id=44764

  • wtf/OwnPtrCommon.h:
  • wtf/brew/OwnPtrBrew.cpp: (WTF::deleteOwnedPtr):
19:04 Changeset [67528] by abarth@webkit.org

2010-09-14 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

bugs.webkit.org should autocomplete WebKit Committers and Reviewers
https://bugs.webkit.org/show_bug.cgi?id=45799

This patch implements an autocomplete dropdown that helps users type
the names of WebKit committers and reviewers. The script grabs the
data from SVN now that wms set up CORS for http://svn.webkit.org.
Security technology for the win.

This script is based on (well, essentially copied from) the popular
autocomplete extension:

https://chrome.google.com/extensions/detail/olaabhcgdogcbcoiolomlcodkngnemfb

I asked Ojan, and said he was fine licensing the code under the BSD
license. I'm not sure how the patch interacts with the extension, but
we can retire the extension if they interact poorly.

  • committers-autocomplete.js: Added.
  • template/en/default/global/footer.html.tmpl:
    • Add the script to every page on bugs.webkit.org
18:59 Changeset [67527] by abarth@webkit.org

2010-09-14 Mihai Parparita <mihaip@chromium.org>

Reviewed by Adam Barth.

Send webkit accessibility notifications to Chromium
https://bugs.webkit.org/show_bug.cgi?id=45156

Move printf inside shouldDumpAccessibilityNotifications check.

  • DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::postAccessibilityNotification):
18:55 Changeset [67526] by simon.fraser@apple.com

2010-09-14 Simon Fraser <simon.fraser@apple.com>

Reviewed by Oliver Hunt.

Drawing an image outside the bounds of a canvas still causes repaints
https://bugs.webkit.org/show_bug.cgi?id=45792

Some canvas examples, such as http://www.phoboslab.org/biolab/, draw
images outide the bounds of the canvas. If the canvas already had a
non-empty m_dirtyRect, such draws would cause us to do a repaint of
m_dirtyRect again (which goes through the platform-specific invalidation
machinery, which can be slow).

Optimize this by avoiding extra invalidation when the dirty rect
does not intersect the canvas bounds.

Not testable because this avoids additional repaints of m_dirtyRect, but
m_dirtyRect has to be non-empty for this to benefit.

  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::didDraw):
18:42 Changeset [67525] by yurys@chromium.org

2010-09-14 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Links from "Profiles" don't lead to "Scripts"
https://bugs.webkit.org/show_bug.cgi?id=45756

  • inspector/front-end/ProfileDataGridTree.js: (WebInspector.ProfileDataGridNode.prototype.createCell): use standard routine to create resource link
  • inspector/front-end/inspector.js: code cleanup: removed no-op method (WebInspector.addMainEventListeners):

2010-09-14 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Links from "Profiles" don't lead to "Scripts"
https://bugs.webkit.org/show_bug.cgi?id=45756

  • src/js/DevTools.js: remove obsolete code
18:26 BuildingGtk edited by tonyg@chromium.org
(diff)
18:25 Changeset [67524] by tony@chromium.org

2010-09-14 Tony Chang <tony@chromium.org>

Reviewed by Kent Tamura.

[chromium] fix http/tests/security/local-user-CSS-from-remote.html
https://bugs.webkit.org/show_bug.cgi?id=45788

  • platform/chromium/test_expectations.txt:

2010-09-14 Tony Chang <tony@chromium.org>

Reviewed by Kent Tamura.

[chromium] fix http/tests/security/local-user-CSS-from-remote.html
https://bugs.webkit.org/show_bug.cgi?id=45788

  • DEPS: Include webkit_support::LocalFileToDataURL

2010-09-14 Tony Chang <tony@chromium.org>

Reviewed by Kent Tamura.

[chromium] fix http/tests/security/local-user-CSS-from-remote.html
https://bugs.webkit.org/show_bug.cgi?id=45788

  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::setUserStyleSheetLocation): use a base64 url like in Chrome
18:23 Changeset [67523] by commit-queue@webkit.org

2010-09-14 Patrick Gansterer <paroga@paroga.com>

Reviewed by Adam Roben.

[WINCE] Use codePage instead of TextEncoding
https://bugs.webkit.org/show_bug.cgi?id=45466

Use codePage as member variable to avoid repeated lookup.

  • platform/text/wince/TextCodecWinCE.cpp: (WebCore::newTextCodecWinCE): (WebCore::TextCodecWinCE::TextCodecWinCE): (WebCore::decode): (WebCore::TextCodecWinCE::decode): (WebCore::TextCodecWinCE::encode):
  • platform/text/wince/TextCodecWinCE.h:
17:48 Changeset [67522] by abarth@webkit.org

2010-09-14 Adam Barth <abarth@webkit.org>

Add a license block to the reviewtool. I should have added this from
the start. According to the SVN log, I'm the only one to have ever
touched this file.

  • code-review.js:
17:45 Changeset [67521] by tony@chromium.org

2010-09-14 Tony Chang <tony@chromium.org>

Reviewed by Ojan Vafai.

[chromium] Remove WebKit::areLayoutTestImagesOpaque since it's no longer needed
https://bugs.webkit.org/show_bug.cgi?id=45768

  • public/WebKit.h:
  • src/WebKit.cpp:

2010-09-14 Tony Chang <tony@chromium.org>

Reviewed by Ojan Vafai.

[chromium] Remove WebKit::areLayoutTestImagesOpaque since it's no longer needed
https://bugs.webkit.org/show_bug.cgi?id=45768

  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::dumpImage): new baselines are checked in and Linux will match Windows going forward.
17:36 Changeset [67520] by abarth@webkit.org

2010-09-14 Adam Barth <abarth@webkit.org>

Attempted Chromium build fix. The compiler can't tell that
ASSERT_NOT_REACHED is not reached and so it demands an initialization
of this variable.

  • html/HTMLFontElement.cpp: (WebCore::HTMLFontElement::parseMappedAttribute):
17:34 Changeset [67519] by commit-queue@webkit.org

2010-09-14 Ryuan Choi <ryuan.choi@samsung.com>

Reviewed by Kenneth Rohde Christiansen.

[EFL] ewk_frame_view_create_for_view set null as theme.
https://bugs.webkit.org/show_bug.cgi?id=45741

Add theme in ewk_view to use instead of frame's theme which is null in
ewk_frame_view_create_for_view.

  • ewk/ewk_frame.cpp: (ewk_frame_view_create_for_view):
  • ewk/ewk_view.cpp: (ewk_view_theme_set): (ewk_view_theme_get):
17:19 Changeset [67518] by mrowe@apple.com

Part of <rdar://problem/8420003>. Make it possible to override the version number used in linked-in-or-after checks.

Reviewed by John Sullivan.

  • Misc/WebKitVersionChecks.h: Remove two unused functions from the header and add a method to set the overriden version.
  • Misc/WebKitVersionChecks.m:

(WebKitLinkedOnOrAfter):
(setWebKitLinkTimeVersion): Set the overridden version.
(WebKitLinkTimeVersion): Return the overridden version if set, otherwise do the old thing.

  • WebView/WebPreferences.mm:

(+[WebPreferences setWebKitLinkTimeVersion:]): Call through to set the overridden version.

  • WebView/WebPreferencesPrivate.h:
17:19 Changeset [67517] by tony@chromium.org

2010-09-14 Mihai Parparita <mihaip@chromium.org>

Reviewed by Tony Chang.

blob: URL scheme does not work with Chromium DRT
https://bugs.webkit.org/show_bug.cgi?id=45772

Remove blob-related tests that now pass.

  • platform/chromium/drt_expectations.txt:

2010-09-14 Mihai Parparita <mihaip@chromium.org>

Reviewed by Tony Chang.

blob: URL scheme does not work with Chromium DRT
https://bugs.webkit.org/show_bug.cgi?id=45772

Roll Chromium forward to r59406, which registers the blob
URL scheme for the Chromium DRT too.

  • DEPS:
16:53 Changeset [67516] by andreas.kling@nokia.com

2010-09-14 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Ariya Hidayat.

[Qt] Wheeling over windowed plugins sometimes cause them to disappear

  • plugins/qt/PluginContainerQt.cpp: (PluginClientWrapper::x11Event): Pass on captured mouse wheel events to the effective native window rather than the grandparent widget. We were calling QWidget::winId() which caused a new X11 window to be created for the grandparent widget and generally mess things up.
16:46 Changeset [67515] by kevino@webkit.org

[wx] Build fixes after recent changes.

16:32 Changeset [67514] by abarth@webkit.org

2010-09-14 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Handle <font size=0> as <font size=1> like any other browser
https://bugs.webkit.org/show_bug.cgi?id=39148

Update font size parser to match HTML5 spec. The main difference here
is the handling of 0, which now maps to 1 instead of 3.

  • html/HTMLFontElement.cpp: (WebCore::parseFontSize): (WebCore::HTMLFontElement::cssValueFromFontSizeNumber):

2010-09-14 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Handle <font size=0> as <font size=1> like any other browser
https://bugs.webkit.org/show_bug.cgi?id=39148

Update tests and results to match new behavior.

  • editing/execCommand/query-font-size-expected.txt:
  • fast/dom/HTMLFontElement/script-tests/size-attribute.js:
  • fast/dom/HTMLFontElement/size-attribute-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug16012-expected.txt:
16:29 Changeset [67513] by abarth@webkit.org

2010-09-14 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

document.lastModified gives no output if the response doesn't have a Last-Modified header
https://bugs.webkit.org/show_bug.cgi?id=8475

Implement document.lastModified as per HTML5.

Tests: http/tests/misc/last-modified-parsing.html

http/tests/misc/no-last-modified.html

  • dom/Document.cpp: (WebCore::Document::lastModified):

2010-09-14 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

document.lastModified gives no output if the response doesn't have a Last-Modified header
https://bugs.webkit.org/show_bug.cgi?id=8475

  • http/tests/misc/last-modified-parsing-expected.txt: Added.
  • http/tests/misc/last-modified-parsing.html: Added.
    • Tests some details of our date parsing and serialization. The serialization format is kind of goofy, but that's what the spec seems to want.
  • http/tests/misc/no-last-modified-expected.txt: Added.
  • http/tests/misc/no-last-modified.html: Added.
    • Test was happens if the server doesn't send a Last-Modified header. We're supposed to use the current date and time.
  • http/tests/resources/last-modified.php: Added.
    • PHP helper script.
16:27 Changeset [67512] by abarth@webkit.org

2010-09-14 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

document.compatMode is undefined when using application/xhtml+xml
https://bugs.webkit.org/show_bug.cgi?id=44422

Moving the compatMode IDL attribute from HTMLDocument.idl to
Document.idl fixes this bug and improve compliance with HTML5.

Test: fast/parser/compatMode-in-xhtml.xhtml

  • dom/Document.cpp: (WebCore::Document::compatMode):
  • dom/Document.h:
  • dom/Document.idl:
  • html/HTMLDocument.cpp:
  • html/HTMLDocument.h:

2010-09-14 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

document.compatMode is undefined when using application/xhtml+xml
https://bugs.webkit.org/show_bug.cgi?id=44422

Test the value of compatMode in XHTML. I'm terrible at XML, but this
test seems to work.

  • fast/parser/compatMode-in-xhtml-expected.txt: Added.
  • fast/parser/compatMode-in-xhtml.xhtml: Added.
16:15 Changeset [67511] by commit-queue@webkit.org

2010-09-14 James Kozianski <soulplant@gmail.com>

Reviewed by Ojan Vafai.

Setting of CSSStyleDeclaration.prototype.foo on outer window affects prototype of inner window
https://bugs.webkit.org/show_bug.cgi?id=18447

Add a test for CSSStyleDeclaration.prototype.foo leaking into inner
windows.

  • fast/frames/css-style-declaration-isolation-expected.txt: Added.
  • fast/frames/css-style-declaration-isolation.html: Added.
16:13 Changeset [67510] by weinig@apple.com

Fix windows build.

  • win/WebKit2Generated.make:
16:12 Changeset [67509] by abarth@webkit.org

2010-09-14 Adam Barth <abarth@webkit.org>

Reviewed by Nate Chapin.

V8 security checks don't account for shadowing named frames
https://bugs.webkit.org/show_bug.cgi?id=45700

Test: http/tests/security/xss-DENIED-frame-name.html

  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8DOMWindow::namedSecurityCheck):
    • If the property name exists on the object, it will shadow the named property lookup on the window object. That means we need to block access if there's shadowing going on.

(WebCore::V8DOMWindow::indexedSecurityCheck):

  • I made the corresponding change to this function too, but I don't think this one can actually be triggered because JavaScript variable names need to start with a non-digit.

2010-09-14 Adam Barth <abarth@webkit.org>

Reviewed by Nate Chapin.

V8 security checks don't account for shadowing named frames
https://bugs.webkit.org/show_bug.cgi?id=45700

Test whether cross-origin observers can see global variables shadowing
named frames.

  • http/tests/security/resources/frame-for-parent-name.html: Added.
  • http/tests/security/xss-DENIED-frame-name-expected.txt: Added.
  • http/tests/security/xss-DENIED-frame-name.html: Added.
16:12 Changeset [67508] by dglazkov@chromium.org

Merge 67418 - 2010-09-13 Chris Guillory <chris.guillory@google.com>

Reviewed by Chris Fleizach.

WebAccessibilityCacheImpl needs to handle invalid accessibility object ids.
https://bugs.webkit.org/show_bug.cgi?id=45572

  • public/WebAccessibilityObject.h:
  • src/WebAccessibilityCacheImpl.cpp: (WebKit::WebAccessibilityCacheImpl::addOrGetId):
  • src/WebAccessibilityObject.cpp: (WebKit::WebAccessibilityObject::isAxObjectIdValid):

TBR=ctguil@chromium.org
Review URL: http://codereview.chromium.org/3398006

15:53 Changeset [67507] by weinig@apple.com

Remove WKBundleNodeRef, replacing uses with WKBundleNodeHandleRef.
https://bugs.webkit.org/show_bug.cgi?id=45785

Reviewed by Anders Carlsson.

WebKit2:

  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:

Remove files.

  • WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:
  • WebProcess/InjectedBundle/API/c/WKBundleBase.h:
  • WebProcess/InjectedBundle/API/c/WKBundleNode.cpp: Removed.
  • WebProcess/InjectedBundle/API/c/WKBundleNode.h: Removed.
  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/InjectedBundle/API/c/WKBundleRange.cpp:

(WKBundleRangeCopyStartContainer):
(WKBundleRangeCopyEndContainer):

  • WebProcess/InjectedBundle/API/c/WKBundleRange.h:
  • WebProcess/InjectedBundle/InjectedBundlePageEditorClient.cpp:

(WebKit::InjectedBundlePageEditorClient::shouldInsertNode):
Change to be in terms of WKBundleNodeHandleRef.

WebKitTools:

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::propertyValue):
(WTR::numericWindowPropertyValue):
(WTR::dumpPath):
(WTR::toStr):
(WTR::operator<<):
(WTR::InjectedBundlePage::InjectedBundlePage):
(WTR::InjectedBundlePage::shouldInsertNode):
(WTR::InjectedBundlePage::shouldBeginEditing):
(WTR::InjectedBundlePage::shouldEndEditing):
(WTR::InjectedBundlePage::shouldInsertText):
(WTR::InjectedBundlePage::shouldDeleteRange):
(WTR::InjectedBundlePage::shouldChangeSelectedRange):
(WTR::InjectedBundlePage::shouldApplyStyle):

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
15:53 Changeset [67506] by abarth@webkit.org

2010-09-14 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

incorrect tabindex parsing
https://bugs.webkit.org/show_bug.cgi?id=21076

Updated our integer parsing for tabindex to use the algorithm from the
HTML5 spec.

Test: fast/parser/tabindex-parsing-2.html

  • html/HTMLElement.cpp: (WebCore::HTMLElement::parseMappedAttribute):
  • html/parser/HTMLParserIdioms.cpp: (WebCore::parseHTMLInteger):
  • html/parser/HTMLParserIdioms.h:

2010-09-14 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

incorrect tabindex parsing
https://bugs.webkit.org/show_bug.cgi?id=21076

  • fast/parser/tabindex-parsing-2-expected.txt: Added.
  • fast/parser/tabindex-parsing-2.html: Added.
    • Test a bunch of corner cases in tabindex parsing.
  • fast/parser/tabindex-parsing-expected.txt:
  • fast/parser/tabindex-parsing.html:
    • Update expected result. This case is actually the one that the original reporter was complaining about.
15:48 Changeset [67505] by bfulgham@webkit.org

Build correction, no review.

  • WebCore.vcproj/WebCore.vcproj: Exclude OwnPtrCairo.cpp from

non-Cairo based builds.

15:38 Changeset [67504] by abarth@webkit.org

2010-09-14 Adam Barth <abarth@webkit.org>

Fix two typos in commit-queue. The first is harmless. The second
causes the queue to reject patches when the build is broken. :(

  • Scripts/webkitpy/tool/commands/queues.py:
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
15:26 Changeset [67503] by jianli@chromium.org

fast/files/apply-blob-url-to-img.html timeout on Leopard
https://bugs.webkit.org/show_bug.cgi?id=45576

Reviewed by David Levin.

WebCore:

The failure on Leopard is caused by the static method
ResourceHandle::supportsBufferedData that returns true to indicate that
the buffered data support is enabled for blob resource. However,
BlobResourceHandle does not support this and we need to override this.

The fix is to change supportsBufferedData method from static to virtual
so that we can override the default behavior in BlobResourceHandle.

  • fileapi/ThreadableBlobRegistry.cpp: Copy BlobData to make it cross-thread.

(WebCore::BlobRegistryContext::BlobRegistryContext):

  • loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::resourceData):
(WebCore::ResourceLoader::addData):

  • platform/network/BlobResourceHandle.cpp:

(WebCore::BlobResourceHandle::supportsBufferedData): Override the default
behavior.

  • platform/network/BlobResourceHandle.h:
  • platform/network/ResourceHandle.h: Made supportsBufferedData virtual.
  • platform/network/mac/ResourceHandleMac.mm:

(WebCore::ResourceHandle::bufferedData):

WebKit/chromium:

  • src/ResourceHandle.cpp: Remove the no longer applicable static comment.

LayoutTests:

Update the test to compute the right coordinates to drag the file to.
This fixes the problem that onInputFileChange() is not called on
Leopard.

  • fast/files/apply-blob-url-to-img.html:
  • platform/mac/Skipped: Remove the passing test from Skipped list.
15:19 Changeset [67502] by victorw@chromium.org

2010-09-14 Victor Wang <victorw@chromium.org>

Reviewed by Dimitri Glazkov.

[Chromium] Remove the wrong chromium-win-vista expectations.

Layout test results generated from Chromium vista bots match
the expectations in chromium-win. These baselines are either
wrong or out of date. Need to be cleaned up so chromium
vista bots can pass on these tests.

https://bugs.webkit.org/show_bug.cgi?id=45766

  • platform/chromium-win-vista/css2.1/t0805-c5519-brdr-r-01-e-expected.checksum: Removed.
  • platform/chromium-win-vista/css2.1/t0805-c5519-brdr-r-01-e-expected.png: Removed.
  • platform/chromium-win-vista/css2.1/t0805-c5519-brdr-r-01-e-expected.txt: Removed.
  • platform/chromium-win-vista/css2.1/t0905-c414-flt-fit-01-d-g-expected.checksum: Removed.
  • platform/chromium-win-vista/css2.1/t0905-c414-flt-fit-01-d-g-expected.png: Removed.
  • platform/chromium-win-vista/css2.1/t0905-c414-flt-fit-01-d-g-expected.txt: Removed.
  • platform/chromium-win-vista/css2.1/t0905-c5525-fltblck-00-d-ag-expected.checksum: Removed.
  • platform/chromium-win-vista/css2.1/t0905-c5525-fltblck-00-d-ag-expected.png: Removed.
  • platform/chromium-win-vista/css2.1/t0905-c5525-fltblck-00-d-ag-expected.txt: Removed.
  • platform/chromium-win-vista/css2.1/t0905-c5525-flthw-00-c-g-expected.checksum: Removed.
  • platform/chromium-win-vista/css2.1/t0905-c5525-flthw-00-c-g-expected.png: Removed.
  • platform/chromium-win-vista/css2.1/t0905-c5525-flthw-00-c-g-expected.txt: Removed.
  • platform/chromium-win-vista/css2.1/t0905-c5526-flthw-00-c-g-expected.checksum: Removed.
  • platform/chromium-win-vista/css2.1/t0905-c5526-flthw-00-c-g-expected.png: Removed.
  • platform/chromium-win-vista/css2.1/t0905-c5526-flthw-00-c-g-expected.txt: Removed.
  • platform/chromium-win-vista/css2.1/t1202-counter-09-b-expected.checksum: Removed.
  • platform/chromium-win-vista/css2.1/t1202-counter-09-b-expected.png: Removed.
  • platform/chromium-win-vista/css2.1/t1202-counters-09-b-expected.checksum: Removed.
  • platform/chromium-win-vista/css2.1/t1202-counters-09-b-expected.png: Removed.
  • platform/chromium-win-vista/fast/gradients/radial-centered-expected.checksum: Removed.
  • platform/chromium-win-vista/fast/gradients/radial-centered-expected.png: Removed.
  • platform/chromium-win-vista/fast/gradients/radial-centered-expected.txt: Removed.
  • platform/chromium-win-vista/svg/custom/text-linking-expected.checksum: Removed.
  • platform/chromium-win-vista/svg/custom/text-linking-expected.png: Removed.
15:00 Changeset [67501] by jberlin@webkit.org

2010-09-14 Jessie Berlin <jberlin@apple.com>

Reviewed by Adam Roben.

Exceptions are getting ignored on 64-bit Windows in the Web Process
https://bugs.webkit.org/show_bug.cgi?id=45779

WebKit2:

WebKitSite:

  • building/tools.html: Add instructions about how to optionally get hotfix 976038.
14:55 Changeset [67500] by ggaren@apple.com

Not reviewed.

Fixed layout test failure seen on buildbot by correcting expected results.

It looks like Darin accidentally checked in the wrong expected results.

  • fast/css/visited-link-hang-expected.txt:
14:43 Changeset [67499] by bfulgham@webkit.org

Build correction, no review.

WebCore:

  • WebCore.vcproj/WebCore.vcproj: Add missing OwnPtrCairo.cpp implementation file.
  • platform/graphics/cairo/OwnPtrCairo.cpp: Add missing include for <cairo.h>

WebKit2:

  • win/WebKit2.vcproj: Disable build for Cairo targets of

the WebURLRequestWin.cpp and WebURLResponseWin.cpp files.

14:29 Changeset [67498] by abarth@webkit.org

2010-09-14 Chris Guillory <chris.guillory@google.com>

Reviewed by Chris Fleizach.

Send all accessibility notifications to Chromium.
https://bugs.webkit.org/show_bug.cgi?id=45156


Use postAccessibilityNotification to pass accessibility notifications
to chromium.

  • WebKit.gyp:
  • public/WebAccessibilityNotification.h: Added.
  • public/WebViewClient.h: (WebKit::WebViewClient::postAccessibilityNotification):
  • src/AssertMatchingEnums.h: Added.
  • src/ChromeClientImpl.cpp: (WebKit::toWebAccessibilityNotification): (WebKit::ChromeClientImpl::didChangeAccessibilityObjectChildren): (WebKit::ChromeClientImpl::postAccessibilityNotification):
  • src/ChromeClientImpl.h:

2010-09-14 Chris Guillory <chris.guillory@google.com>

Reviewed by Chris Fleizach.

Send all accessibility notifications to Chromium.
https://bugs.webkit.org/show_bug.cgi?id=45156


Use postAccessibilityNotification to pass accessibility notifications
to chromium.

Tests: platform/chromium/accessibility/post-notification-ActiveDescendantChanged.html

platform/chromium/accessibility/post-notification-CheckedStateChanged.html
platform/chromium/accessibility/post-notification-ChildrenChanged.html
platform/chromium/accessibility/post-notification-FocusedUIElementChanged.html
platform/chromium/accessibility/post-notification-LayoutComplete.html
platform/chromium/accessibility/post-notification-LiveRegionChanged.html
platform/chromium/accessibility/post-notification-LoadComplete.html
platform/chromium/accessibility/post-notification-MenuListValueChanged.html
platform/chromium/accessibility/post-notification-RowCollapsed.html
platform/chromium/accessibility/post-notification-RowCountChanged.html
platform/chromium/accessibility/post-notification-RowExpanded.html
platform/chromium/accessibility/post-notification-ScrolledToAnchor.html
platform/chromium/accessibility/post-notification-SelectedChildrenChanged.html
platform/chromium/accessibility/post-notification-SelectedTextChanged.html
platform/chromium/accessibility/post-notification-ValueChanged.html

  • accessibility/chromium/AXObjectCacheChromium.cpp: (WebCore::AXObjectCache::postPlatformNotification):
  • page/chromium/ChromeClientChromium.h:

2010-09-14 Chris Guillory <chris.guillory@google.com>

Reviewed by Chris Fleizach.

Send all accessibility notifications to Chromium.
https://bugs.webkit.org/show_bug.cgi?id=45156

  • platform/chromium/accessibility/children-changed-notification-expected.txt: Removed.
  • platform/chromium/accessibility/children-changed-notification.html: Removed.
  • platform/chromium/accessibility/post-notification-ActiveDescendantChanged-expected.txt: Added.
  • platform/chromium/accessibility/post-notification-ActiveDescendantChanged.html: Added.
  • platform/chromium/accessibility/post-notification-CheckedStateChanged-expected.txt: Added.
  • platform/chromium/accessibility/post-notification-CheckedStateChanged.html: Added.
  • platform/chromium/accessibility/post-notification-ChildrenChanged-expected.txt: Added.
  • platform/chromium/accessibility/post-notification-ChildrenChanged.html: Added.
  • platform/chromium/accessibility/post-notification-FocusedUIElementChanged-expected.txt: Added.
  • platform/chromium/accessibility/post-notification-FocusedUIElementChanged.html: Added.
  • platform/chromium/accessibility/post-notification-LayoutComplete-expected.txt: Added.
  • platform/chromium/accessibility/post-notification-LayoutComplete.html: Added.
  • platform/chromium/accessibility/post-notification-LiveRegionChanged-expected.txt: Added.
  • platform/chromium/accessibility/post-notification-LiveRegionChanged.html: Added.
  • platform/chromium/accessibility/post-notification-LoadComplete-expected.txt: Added.
  • platform/chromium/accessibility/post-notification-LoadComplete.html: Added.
  • platform/chromium/accessibility/post-notification-MenuListValueChanged-expected.txt: Added.
  • platform/chromium/accessibility/post-notification-MenuListValueChanged.html: Added.
  • platform/chromium/accessibility/post-notification-RowCollapsed-expected.txt: Added.
  • platform/chromium/accessibility/post-notification-RowCollapsed.html: Added.
  • platform/chromium/accessibility/post-notification-RowCountChanged-expected.txt: Added.
  • platform/chromium/accessibility/post-notification-RowCountChanged.html: Added.
  • platform/chromium/accessibility/post-notification-RowExpanded-expected.txt: Added.
  • platform/chromium/accessibility/post-notification-RowExpanded.html: Added.
  • platform/chromium/accessibility/post-notification-ScrolledToAnchor-expected.txt: Added.
  • platform/chromium/accessibility/post-notification-ScrolledToAnchor.html: Added.
  • platform/chromium/accessibility/post-notification-SelectedChildrenChanged-expected.txt: Added.
  • platform/chromium/accessibility/post-notification-SelectedChildrenChanged.html: Added.
  • platform/chromium/accessibility/post-notification-SelectedTextChanged-expected.txt: Added.
  • platform/chromium/accessibility/post-notification-SelectedTextChanged.html: Added.
  • platform/chromium/accessibility/post-notification-ValueChanged-expected.txt: Added.
  • platform/chromium/accessibility/post-notification-ValueChanged.html: Added.
  • platform/chromium/accessibility/post-notification.js: Added. (enumAccessibilityObjects): (testDone): (test):
  • platform/chromium/drt_expectations.txt:
  • platform/chromium/test_expectations.txt:

2010-09-14 Chris Guillory <chris.guillory@google.com>

Reviewed by Chris Fleizach.

Send all accessibility notifications to Chromium.
https://bugs.webkit.org/show_bug.cgi?id=45156

  • DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::postAccessibilityNotification):
  • DumpRenderTree/chromium/WebViewHost.h:
14:22 Changeset [67497] by adachan@apple.com

Reviewed by Adam Roben.

Add an IWebFramePrivate API to load string as plain text into the WebFrame.
https://bugs.webkit.org/show_bug.cgi?id=45782

  • Interfaces/IWebFramePrivate.idl:
  • Interfaces/WebKit.idl: Touch the file.
  • WebFrame.cpp: (WebFrame::loadPlainTextString):
  • WebFrame.h:
14:10 Changeset [67496] by darin@apple.com

2010-09-14 Darin Adler <darin@apple.com>

Reviewed by Geoffrey Garen.

Hang processing href attribute containing a million slashes
https://bugs.webkit.org/show_bug.cgi?id=45767

Test: fast/css/visited-link-hang.html

  • platform/LinkHash.cpp: (WebCore::findSlashDotDotSlash): Added a start position argument and changed types to use size_t consistently instead of a mix. (WebCore::findSlashSlash): Ditto. (WebCore::findSlashDotSlash): Ditto. (WebCore::squeezeOutNullCharacters): Added. (WebCore::cleanSlashDotDotSlashes): Added. Factored out part of cleanPath (see below). (WebCore::mergeDoubleSlashes): Ditto. (WebCore::cleanSlashDotSlashes): Ditto. (WebCore::cleanPath): Changed algorithm to not remove as we go to avoid N2 behavior; instead replace with null characters and then do a squeeze operation after the fact. Also moved the body of the function out of line since we normally don't have to do any cleaning. This whole thing should go at some point -- it's not the right algorithm -- but this should eliminate the performance problems without changing behavior.

2010-09-14 Darin Adler <darin@apple.com>

Reviewed by Geoffrey Garen.

Hang processing href attribute containing a million slashes
https://bugs.webkit.org/show_bug.cgi?id=45767

  • fast/css/visited-link-hang-expected.txt: Added.
  • fast/css/visited-link-hang.html: Added.
14:07 Changeset [67495] by abarth@webkit.org

2010-09-14 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

commit-queue is slow during the day
https://bugs.webkit.org/show_bug.cgi?id=45780

Thanks to the new logging, we've noticed that checkout-is-out-of-date
errors in the first pass of landing don't retry the land. Instead,
they're treated as failures and cause the commit-queue to do two more
builds before really trying to land the patch. Worse, in the second
build, we can get bitten by a flaky test.

This patch takes a slightly different approach to the commit-queue's
main control logic. We now use a separate subprocess for building and
testing and for landing. This means we should very rarely see the
checkout-is-out-of-date error, and when we do see it, we should retry
more quickly. If my understanding is correct, this should be a big
speed win for the commit-queue.

  • Scripts/webkitpy/tool/commands/download.py:
  • Scripts/webkitpy/tool/commands/queues.py:
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
14:06 Changeset [67494] by darin@apple.com

2010-09-14 Darin Adler <darin@apple.com>

Reviewed by Geoffrey Garen.

Sort with non-numeric custom sort function fails on array with length but no values
https://bugs.webkit.org/show_bug.cgi?id=45781

  • runtime/JSArray.cpp: (JSC::JSArray::sort): Replaced early exit for an array of length zero to instead exit for any array without values, even if it has a non-0 length.

2010-09-14 Darin Adler <darin@apple.com>

Reviewed by Geoffrey Garen.

Sort with non-numeric custom sort function fails on array with length but no values
https://bugs.webkit.org/show_bug.cgi?id=45781

  • fast/js/script-tests/sort-large-array.js: Added test cases.
  • fast/js/sort-large-array-expected.txt: Updated.
14:02 Changeset [67493] by thakis@chromium.org

2010-09-14 Nico Weber <thakis@chromium.org>

Reviewed by Kenneth Russell.

[chromium]: On Mac, let image layer data row order match skia.
https://bugs.webkit.org/show_bug.cgi?id=45400

Make CoreGraphics texture row order match skia's row order, remove all
code that worked around this difference. This also fixes a problem where
image layers would be drawn upside down.

Covered by existing layout tests, but we don't run these with
compositing yet.

  • platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::SharedValues::SharedValues): (WebCore::ContentLayerChromium::updateContents): (WebCore::ContentLayerChromium::updateTextureRect):
  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::setRootLayerCanvasSize): (WebCore::LayerRendererChromium::drawLayers):
13:45 Changeset [67492] by sfalken@apple.com

Merge r67482.

13:41 Changeset [67491] by sfalken@apple.com

Versioning.

13:29 Changeset [67490] by rniwa@webkit.org

2010-09-14 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Tony Chang.

applyInlineStyleToNodeRange does not extend run properly
https://bugs.webkit.org/show_bug.cgi?id=45616

The bug was caused by applyInlineStyleToNodeRange's skipping a node whenever it has children.
Fixed the bug by only skipping a node that contains the past end node, contains non-editable region,
or has a non-editable parent node. Also fixed a bug that applyInlineStyleToNodeRange does not remove
styled elements in a run that are identical to the one added. addInlineStyleIfNeeded now removes
all styled elements in a run using removeStyleFromRunBeforeApplyingStyle before calling addInlineStyleIfNeeded.

Test: editing/style/inline-style-extend-run.html

  • editing/ApplyStyleCommand.cpp: (WebCore::containsNonEditableRegion): Added. (WebCore::ApplyStyleCommand::applyInlineStyleToNodeRange): See above. (WebCore::ApplyStyleCommand::removeStyleFromRunBeforeApplyingStyle): Added, see above. (WebCore::ApplyStyleCommand::removeInlineStyleFromElement): Added support for RemoveAlways. (WebCore::ApplyStyleCommand::removeImplicitlyStyledElement): Replaced RemoveAttributesAndElements by RemoveIfNeeded. (WebCore::ApplyStyleCommand::extractInlineStyleToPushDown): Replaced RemoveAttributesAndElements by RemoveIfNeeded.
  • editing/ApplyStyleCommand.h:

2010-09-14 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Tony Chang.

applyInlineStyleToNodeRange does not extend a run properly
https://bugs.webkit.org/show_bug.cgi?id=45616

Added a test to ensure WebKit adds just one element when applying inline style and removes redundant styled elements.
Rebaseline of other tests are required because WebKit now generates less elements.

  • editing/execCommand/script-tests/toggle-style-3.js: Merged two b elements.
  • editing/execCommand/toggle-style-3-expected.txt: Ditto.
  • editing/execCommand/unlink-expected.txt: Changed the order in which span and anchor appear.
  • editing/style/inline-style-extend-run-expected.txt: Added.
  • editing/style/inline-style-extend-run.html: Added.
  • editing/style/script-tests/inline-style-extend-run.js: Added. (testSingleToggle):
  • editing/style/script-tests/make-text-writing-direction-inline.js: Merged two spans.
  • fast/events/event-input-contentEditable-expected.txt: Merged two anchor elements.
  • fast/events/event-input-contentEditable.html: Ditto.
13:27 Changeset [67489] by sfalken@apple.com

New tag.

13:08 Changeset [67488] by andreas.kling@nokia.com

2010-09-14 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] V8 port: Get inspector up and running
https://bugs.webkit.org/show_bug.cgi?id=45771

  • WebCoreSupport/InspectorClientQt.cpp: (WebCore::ensureDebuggerScriptLoaded): Added, loads DebuggerScript.js into ScriptDebugServer. (WebCore::InspectorClientQt::openInspectorFrontend): Ensure that DebuggerScript.js is loaded before opening an inspector.

2010-09-14 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] V8 port: Get inspector up and running
https://bugs.webkit.org/show_bug.cgi?id=45771

  • inspector/front-end/WebKit.qrc: Add DebuggerScript.js
12:56 Changeset [67487] by tony@chromium.org

2010-09-14 Tony Chang <tony@chromium.org>

Unreviewed, fix chromium win compile.

  • public/WebView.h:
12:48 Changeset [67486] by oliver@apple.com

PPC Build fix.

12:44 Changeset [67485] by commit-queue@webkit.org

2010-09-14 Kwang Yul Seo <skyul@company100.net>

Reviewed by Andreas Kling.

[chromium] Remove unused ICU headers
https://bugs.webkit.org/show_bug.cgi?id=45698

Remove unused headers.

  • platform/graphics/chromium/FontCacheLinux.cpp:
12:23 Changeset [67484] by abarth@webkit.org

2010-09-14 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

HTML5 spec violation: </><!doctype html> or </x><!doctype html> SHOULD NOT imply standards mode
https://bugs.webkit.org/show_bug.cgi?id=17722

I believe our behavior matches the HTML5 spec. When we see a </x>, we
correctly kick out of standards mode. In the </> case, however, the
tokenizer just eats the bytes, without emitting a token, which means we
don't get kicked out of standards mode. Our behavior matches Minefield.

  • fast/parser/strange-doctype-compatmode-1-expected.txt: Added.
  • fast/parser/strange-doctype-compatmode-1.html: Added.
  • fast/parser/strange-doctype-compatmode-2-expected.txt: Added.
  • fast/parser/strange-doctype-compatmode-2.html: Added.
12:02 Changeset [67483] by andreas.kling@nokia.com

2010-09-14 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Antonio Gomes.

[Qt] Numpad Enter key returns keyCode 0 instead of 13
https://bugs.webkit.org/show_bug.cgi?id=45014

Original patch by Jarred Nicholls <jarred.nicholls@gmail.com>

There is a missing case statement in the PlatformKeyboardEventQt.cpp
file to handle the Enter button on the number pad. Because it is not
handled, the keyCode returned in a JavaScript event is 0 rather than 13.

Test: manual-tests/qt/numpad-enter-key.html

  • manual-tests/qt/numpad-enter-key.html: Added.
  • platform/qt/PlatformKeyboardEventQt.cpp: (WebCore::windowsKeyCodeForKeyEvent):
11:49 Changeset [67482] by sfalken@apple.com

Windows production build fix.
Roll out r65143.

11:15 Changeset [67481] by evan@chromium.org

2010-09-14 Evan Martin <evan@chromium.org>

Reviewed by Darin Fisher.

[chromium] building without debug syms broke after recent refactoring
https://bugs.webkit.org/show_bug.cgi?id=45720

Now that we build WebCore as multiple libraries, we need to adjust the
flags to turn off debug symbols for all of these libraries.

No new tests; should only affect an uncommon build flag.

  • WebCore.gyp/WebCore.gyp:
10:59 Changeset [67480] by tony@chromium.org

2010-09-14 Tony Chang <tony@chromium.org>

Unreviewed, remove tests that are now passing after Noel Gordon's
fix to test_shell delete key handling.

  • platform/chromium/test_expectations.txt:
10:38 Changeset [67479] by tony@chromium.org

2010-09-14 Tony Chang <tony@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] implement layoutTestController.setDomainRelaxationForbiddenForURLScheme
https://bugs.webkit.org/show_bug.cgi?id=45762

  • platform/chromium/test_expectations.txt:

2010-09-14 Tony Chang <tony@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] implement layoutTestController.setDomainRelaxationForbiddenForURLScheme
https://bugs.webkit.org/show_bug.cgi?id=45762

  • public/WebView.h: add WebView::setDomainRelaxationForbidden
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::setDomainRelaxationForbidden):
  • src/WebViewImpl.h:

2010-09-14 Tony Chang <tony@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] implement layoutTestController.setDomainRelaxationForbiddenForURLScheme
https://bugs.webkit.org/show_bug.cgi?id=45762

  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
  • DumpRenderTree/chromium/LayoutTestController.h:
10:27 Changeset [67478] by tony@chromium.org

2010-09-14 Tony Chang <tony@chromium.org>

Unreviewed, fix chromium compile.

  • platform/graphics/chromium/ImageLayerChromium.h:
10:16 Changeset [67477] by thakis@chromium.org

2010-09-14 Nico Weber <thakis@chromium.org>

Reviewed by Darin Fisher.

[chromium]: crash less in compositor mode on mac
https://bugs.webkit.org/show_bug.cgi?id=45714

The contents image can go away when the dom is updated. Since the
layer tree is updated asynchronously, it needs to ref the native image,
else it will hold on to a stale object.

This still needs to be done for skia, too.

  • platform/graphics/chromium/ImageLayerChromium.h:
  • platform/graphics/chromium/ImageLayerChromium.cpp:
10:04 Changeset [67476] by leandro@webkit.org

2010-09-14 Leandro Pereira <leandro@profusion.mobi>

[EFL] Unreviewed build fix: remove "virtual" keyword from
implementation file.

  • WebCoreSupport/FrameLoaderClientEfl.cpp: (WebCore::FrameLoaderClientEfl::canShowMIMETypeAsHTML):
09:49 Changeset [67475] by commit-queue@webkit.org

2010-09-14 Kwang Yul Seo <skyul@company100.net>

Reviewed by Darin Adler.

Share UnicodeMacrosFromICU.h
https://bugs.webkit.org/show_bug.cgi?id=45710

glib, qt4 and wince use the same macros from ICU.
Remove the code duplication and use the same header file.

  • wtf/unicode/UnicodeMacrosFromICU.h: Copied from JavaScriptCore/wtf/unicode/glib/UnicodeMacrosFromICU.h.
  • wtf/unicode/glib/UnicodeMacrosFromICU.h: Removed.
  • wtf/unicode/qt4/UnicodeQt4.h:
  • wtf/unicode/wince/UnicodeWince.h:
09:30 Changeset [67474] by caseq@chromium.org

2010-09-14 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [Resources panel] [HAR] Need a way to save timing data.
Added support for resource timings to HAREntry.
https://bugs.webkit.org/show_bug.cgi?id=45663

2010-09-14 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [Resources panel] [HAR] Need a way to save timing data.
https://bugs.webkit.org/show_bug.cgi?id=45663

  • http/tests/inspector/resource-har-conversion-expected.txt:
  • http/tests/inspector/resource-parameters-expected.txt:
  • http/tests/inspector/resource-test2.js: Added entire timings object to list of non-deterministic fields.
  • http/tests/inspector/resource-tests.js: Ditto.
09:19 Changeset [67473] by commit-queue@webkit.org

2010-09-14 Kwang Yul Seo <skyul@company100.net>

Reviewed by Kent Tamura.

[BREWMP] Always set LeftButton in PlatformMouseEvent
https://bugs.webkit.org/show_bug.cgi?id=45705

AEE_POINTER_GET_MOUSE_MODIFIERS always returns 0, so it is impossible to know
which button is pressed or released. The current code erroneously sets NoButton.
Set LeftButton unconditionally because Brew MP usually runs on touch device.

  • platform/brew/PlatformMouseEventBrew.cpp: (WebCore::PlatformMouseEvent::PlatformMouseEvent):
08:40 Changeset [67472] by yurys@chromium.org

2010-09-14 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Andreas Kling.

Move DebuggerScript.js from WebKit/chromium/src/js to WebCore/bindings/v8
https://bugs.webkit.org/show_bug.cgi?id=45739

  • bindings/v8/DebuggerScript.js: Added.

2010-09-14 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Andreas Kling.

Move DebuggerScript.js from WebKit/chromium/src/js to WebCore/bindings/v8
https://bugs.webkit.org/show_bug.cgi?id=45739

  • WebKit.grd:
  • WebKit.gypi:
  • src/js/DebuggerScript.js: Removed.
  • src/js/DevToolsHostStub.js: Removed.
08:31 Changeset [67471] by hans@chromium.org

2010-09-14 Hans Wennborg <hans@chromium.org>

Reviewed by Jeremy Orlow.

Rebaseline DeviceOrientation related layout tests for Chromium.
https://bugs.webkit.org/show_bug.cgi?id=45542

Some DeviceOrientation layout tests need Chromium-specific
baselines because of differences between JSC and V8.

Also enable prototype-inheritance.html again and unfork its
expectations.

  • fast/dom/script-tests/prototype-inheritance.js:
  • platform/chromium-linux/fast/dom/DeviceOrientation/window-property-expected.txt: Added.
  • platform/chromium-linux/fast/dom/Window/window-properties-device-orientation-expected.txt: Added.
  • platform/chromium-mac/fast/dom/DeviceOrientation/window-property-expected.txt: Added.
  • platform/chromium-mac/fast/dom/Window/window-properties-device-orientation-expected.txt: Added.
  • platform/chromium-mac/fast/dom/prototype-inheritance-expected.txt: Removed.
  • platform/chromium-win/fast/dom/DeviceOrientation/window-property-expected.txt: Added.
  • platform/chromium-win/fast/dom/Window/window-properties-device-orientation-expected.txt: Added.
  • platform/chromium-win/fast/dom/prototype-inheritance-expected.txt: Removed.
  • platform/chromium/fast/dom/prototype-inheritance-expected.txt:
  • platform/chromium/test_expectations.txt:
08:18 Changeset [67470] by yurys@chromium.org

2010-09-14 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

[Chromium] add new tests from r67463 to expectations
https://bugs.webkit.org/show_bug.cgi?id=45753

  • platform/chromium/test_expectations.txt:
07:59 Changeset [67469] by apavlov@chromium.org

2010-09-10 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Implement on-demand reporting of empty CSS rules matched for a node by WebCore
https://bugs.webkit.org/show_bug.cgi?id=45530

WebCore:

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::matchRules): (WebCore::CSSStyleSelector::matchRulesForList): (WebCore::CSSStyleSelector::matchUARules): (WebCore::CSSStyleSelector::styleForElement): (WebCore::CSSStyleSelector::pseudoStyleForElement): (WebCore::CSSStyleSelector::styleRulesForElement): (WebCore::CSSStyleSelector::pseudoStyleRulesForElement):
  • css/CSSStyleSelector.h:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::getStyles): (WebCore::InspectorDOMAgent::buildArrayForPseudoElements):

LayoutTests:

  • inspector/elements-panel-styles-expected.txt:
  • inspector/resources/elements-panel-styles.css: (.foo): (.foo::before):
07:42 Changeset [67468] by commit-queue@webkit.org

2010-09-14 Hyung Song <beergun@company100.net>

Reviewed by Darin Adler.

[BREWMP] Set m_size in SharedBuffer::createWithContentsOfFile();
https://bugs.webkit.org/show_bug.cgi?id=45701

SharedBuffer::createWithContentsOfFile() reads file content and saves to
result.m_buffer directly, leaving result.m_size unchanged.

  • platform/brew/SharedBufferBrew.cpp: (WebCore::SharedBuffer::createWithContentsOfFile):
07:25 Changeset [67467] by abarth@webkit.org

2010-09-14 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Move adjustLexerState to the HTMLTokenizer
https://bugs.webkit.org/show_bug.cgi?id=45649

This function used let us share code between the tree builder and the
two other users of the HTMLTokenizer. However, now that the tree
builder is all grown up, it can't use this code anymore. The other
users would much rather this code lived on HTMLTokenizer and understood
<script>. This patch attempts to make them happy.

  • html/parser/HTMLPreloadScanner.cpp: (WebCore::HTMLPreloadScanner::processToken):
  • html/parser/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::updateStateFor):
  • html/parser/HTMLTokenizer.h:
  • html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::scriptEnabled):
  • html/parser/HTMLTreeBuilder.h:
  • html/parser/HTMLViewSourceParser.cpp: (WebCore::HTMLViewSourceParser::updateTokenizerState):
07:06 Changeset [67466] by commit-queue@webkit.org

2010-09-14 Mihai Parparita <mihaip@chromium.org>

Reviewed by Dimitri Glazkov.

post-basic.html and post-frames.html in http/tests/navigation should not be pixel tests
https://bugs.webkit.org/show_bug.cgi?id=45610

post-basic.html and post-frames.html would be a lot simpler if
they weren't pixel tests (post-frames.html doesn't even have the right
expectations for Chromium/Mac). Since all they test is that form
POSTs are handled correctly, they can just use dumpAsText.

  • http/tests/navigation/post-basic-expected.txt: Added.
  • http/tests/navigation/post-basic.html:
  • http/tests/navigation/post-frames-expected.txt: Added.
  • http/tests/navigation/post-frames.html:
  • http/tests/navigation/resources/form-target.pl: Added
  • http/tests/navigation/resources/page-that-posts.html: Added.
  • platform/chromium-linux/http/tests/navigation/post-basic-expected.checksum: Removed.
  • platform/chromium-linux/http/tests/navigation/post-basic-expected.png: Removed.
  • platform/chromium-linux/http/tests/navigation/post-frames-expected.checksum: Removed.
  • platform/chromium-linux/http/tests/navigation/post-frames-expected.png: Removed.
  • platform/chromium-win/http/tests/navigation/post-basic-expected.checksum: Removed.
  • platform/chromium-win/http/tests/navigation/post-basic-expected.png: Removed.
  • platform/chromium-win/http/tests/navigation/post-basic-expected.txt: Removed.
  • platform/chromium-win/http/tests/navigation/post-frames-expected.checksum: Removed.
  • platform/chromium-win/http/tests/navigation/post-frames-expected.png: Removed.
  • platform/chromium-win/http/tests/navigation/post-frames-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
  • platform/mac/http/tests/navigation/post-basic-expected.checksum: Removed.
  • platform/mac/http/tests/navigation/post-basic-expected.png: Removed.
  • platform/mac/http/tests/navigation/post-basic-expected.txt: Removed.
  • platform/mac/http/tests/navigation/post-frames-expected.checksum: Removed.
  • platform/mac/http/tests/navigation/post-frames-expected.png: Removed.
  • platform/mac/http/tests/navigation/post-frames-expected.txt: Removed.
07:04 Changeset [67465] by abecsi@webkit.org

2010-09-14 Andras Becsi <abecsi@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt] qmake doesn't generate correct dependencies for rcc resource files
https://bugs.webkit.org/show_bug.cgi?id=45747

  • WebKit.pri: add OUT_PWD to DEPENDPATH
06:33 Changeset [67464] by antonm@chromium.org

2010-09-14 Anton Muhin <antonm@chromium.org>

Unreviewed cleanup of test expectations for Chromium.

ietestcenter/Javascript/15.4.4.15-3-14.html, ietestcenter/Javascript/15.4.4.15-3-29.html and
ietestcenter/Javascript/15.4.4.15-3-8.html are passing now.

  • platform/chromium/test_expectations.txt:
06:25 Changeset [67463] by commit-queue@webkit.org

2010-09-14 Pierre-Antoine LaFayette <plafayet@codeaurora.org>

Reviewed by Darin Adler.

REGRESSION (r52839): Incomplete repaint of IMG with text-align:center
https://bugs.webkit.org/show_bug.cgi?id=40142

Add pixel tests to verify proper repaint of RenderReplaced as well as non-inline children.

  • fast/repaint/block-layout-inline-children-float-positioned.html: Added.
  • fast/repaint/block-layout-inline-children-replaced.html: Added.
  • platform/mac/fast/repaint/block-layout-inline-children-float-positioned-expected.checksum: Added.
  • platform/mac/fast/repaint/block-layout-inline-children-float-positioned-expected.png: Added.
  • platform/mac/fast/repaint/block-layout-inline-children-float-positioned-expected.txt: Added.
  • platform/mac/fast/repaint/block-layout-inline-children-replaced-expected.checksum: Added.
  • platform/mac/fast/repaint/block-layout-inline-children-replaced-expected.png: Added.
  • platform/mac/fast/repaint/block-layout-inline-children-replaced-expected.txt: Added.

2010-09-14 Pierre-Antoine LaFayette <plafayet@codeaurora.org>

Reviewed by Darin Adler.

REGRESSION (r52839): Incomplete repaint of IMG with text-align:center
https://bugs.webkit.org/show_bug.cgi?id=40142

http://trac.webkit.org/changeset/52839 didn't really deal with the inline replaced element case. This just generalizes to all inline content.

Patch by: Dave Hyatt

Tests: fast/repaint/block-layout-inline-children-float-positioned.html

fast/repaint/block-layout-inline-children-replaced.html

  • rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::layoutInlineChildren):
06:20 Changeset [67462] by hans@chromium.org

2010-09-14 Hans Wennborg <hans@chromium.org>

Reviewed by Jeremy Orlow.

Make WebDeviceOrientationClientMock constructor private.
https://bugs.webkit.org/show_bug.cgi?id=45743

Clients should use the create member function instead. DumpRenderTree
and the Chromium test_shell have previously been updated to call create.

  • public/WebDeviceOrientationClientMock.h: (WebKit::WebDeviceOrientationClientMock::WebDeviceOrientationClientMock):
06:16 Changeset [67461] by abecsi@webkit.org

2010-09-14 Balazs Kelemen <kb@inf.u-szeged.hu>

Reviewed by Andreas Kling.

[Qt] Cookie operations should use NetworkingContext
https://bugs.webkit.org/show_bug.cgi?id=45745
No new functionality so no new tests.

  • platform/qt/CookieJarQt.cpp: (WebCore::cookieJar): Use the NetworkingContext for obtaining the QNetworkAccessManager instead of directly accessing the FrameLoaderClient.
05:38 Changeset [67460] by caseq@chromium.org

2010-09-14 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

[Chromium] mark fast/frames/frame-limit.html as DEBUG SLOW CRASH
https://bugs.webkit.org/show_bug.cgi?id=45738

  • platform/chromium/test_expectations.txt:
05:26 Changeset [67459] by commit-queue@webkit.org

2010-09-14 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r67449.
http://trac.webkit.org/changeset/67449
https://bugs.webkit.org/show_bug.cgi?id=45746

This change makes tree red. (Requested by pfeldman on
#webkit).

  • editing/execCommand/script-tests/toggle-style-3.js:
  • editing/execCommand/toggle-style-3-expected.txt:
  • editing/execCommand/unlink-expected.txt:
  • editing/style/inline-style-extend-run-expected.txt: Removed.
  • editing/style/inline-style-extend-run.html: Removed.
  • editing/style/script-tests/inline-style-extend-run.js: Removed.
  • editing/style/script-tests/make-text-writing-direction-inline.js:

2010-09-14 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r67449.
http://trac.webkit.org/changeset/67449
https://bugs.webkit.org/show_bug.cgi?id=45746

This change makes tree red. (Requested by pfeldman on
#webkit).

  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyInlineStyleToNodeRange): (WebCore::ApplyStyleCommand::removeInlineStyleFromElement): (WebCore::ApplyStyleCommand::removeImplicitlyStyledElement): (WebCore::ApplyStyleCommand::extractInlineStyleToPushDown):
  • editing/ApplyStyleCommand.h:
04:07 Changeset [67458] by eric@webkit.org

2010-09-14 Eric Seidel <eric@webkit.org>

Unreviewed, reverting changes r67451 and r67451.
Broke lots of builders.

Only intercept ESC key press when autocorrection UI is visible.
https://bugs.webkit.org/show_bug.cgi?id=45071

  • editing/Editor.cpp:
  • editing/Editor.h:
  • editing/EditorCommand.cpp: (WebCore::createCommandMap):
  • loader/EmptyClients.h:
  • page/EditorClient.h:

2010-09-14 Eric Seidel <eric@webkit.org>

Unreviewed, reverting changes r67451 and r67451.
Broke lots of builders.

Only intercept ESC key press when autocorrection UI is visible.
https://bugs.webkit.org/show_bug.cgi?id=45071

  • WebCoreSupport/WebEditorClient.h:
  • WebCoreSupport/WebEditorClient.mm: (WebEditorClient::WebEditorClient): (WebEditorClient::dismissCorrectionPanel):

2010-09-14 Eric Seidel <eric@webkit.org>

Unreviewed, reverting changes r67451 and r67451.
Broke lots of builders.

Only intercept ESC key press when autocorrection UI is visible.
https://bugs.webkit.org/show_bug.cgi?id=45071

  • WebProcess/WebCoreSupport/WebEditorClient.cpp: (WebKit::WebEditorClient::dismissCorrectionPanel):
  • WebProcess/WebCoreSupport/WebEditorClient.h:
02:52 Changeset [67457] by ossy@webkit.org

Adding myself as a reviewer.

  • Scripts/webkitpy/common/config/committers.py:
02:46 Changeset [67456] by zoltan@webkit.org

[Qt] Build-webkit shows a warning when WebKitBuild directory is not exist
https://bugs.webkit.org/show_bug.cgi?id=45736

Reviewed by Kenneth Rohde Christiansen.

Build-webkit has showed a warning when WebKitBuild didn't exist, add
an additional condition to avoid it.

  • Scripts/build-webkit:
02:23 Changeset [67455] by kinuko@chromium.org

2010-09-14 Kinuko Yasuda <kinuko@chromium.org>

Unreviewed; an attempt to fix Chromium Windows build.

  • fileapi/FileEntry.cpp:
02:10 Changeset [67454] by caseq@chromium.org

2010-09-13 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: provide support for opening external navigation for links within certain elements
Use default handling for clicks on links that have target="_blank"
Add option for external navigation to URL audit formatter.
https://bugs.webkit.org/show_bug.cgi?id=45671

  • inspector/front-end/AuditFormatters.js: (WebInspector.AuditFormatters.url):
  • inspector/front-end/inspector.js:
01:26 Changeset [67453] by andreas.kling@nokia.com

2010-09-14 Enrico Ros <eros@codeaurora.org>

Reviewed by Andreas Kling.

[Qt] Respect title attribute on option elements
https://bugs.webkit.org/show_bug.cgi?id=45084

Set the tooltip in the combo box model, so it's reflected in the view.

  • WebCoreSupport/QtFallbackWebPopup.cpp: (WebCore::QtFallbackWebPopup::populate):
01:03 Changeset [67452] by mitz@apple.com

Build fix.

  • editing/EditorCommand.cpp:
00:50 Changeset [67451] by mitz@apple.com

Only intercept ESC key press when autocorrection UI is visible.
https://bugs.webkit.org/show_bug.cgi?id=45071

Patch by Jia Pu <jpu@apple.com> on 2010-09-14
Reviewed by Dan Bernstein.

WebCore:

Only intercept ESC key when autocorrection panel is shown. Otherwise pressing
ESC will cancel current loading like usual.

  • editing/Editor.cpp:

(WebCore::Editor::isShowingCorrectionPanel): Query editor client whether autocorrection

panel is shown.

  • editing/Editor.h: Added declaration of isShowingCorrectionPanel().
  • editing/EditorCommand.cpp:

(WebCore::supportedDismissCorrectionPanel): Only support executeCancelOperation()

when autocorrection panel is shown.

(WebCore::createCommandMap): Replaced isSupported function pointer for

executeCancelOperation() command with supportedDismissCorrectionPanel().

  • loader/EmptyClients.h:

(WebCore::EmptyEditorClient::isShowingCorrectionPanel): Dummy implementation of

new member method declared in base class.

  • page/EditorClient.h: Declared new member method isShowingCorrectionPanel().

WebKit/mac:

  • WebCoreSupport/WebEditorClient.h: Added declaration of isShowingCorrectionPanel(), which provides an inteface to query whether autocorrection panel is shown.
  • WebCoreSupport/WebEditorClient.mm:

(WebEditorClient::WebEditorClient): Defined a constant, InvalidCorrectionPanelTag,

for invalid correction panel tag. Replaced -1 with this constant.

(WebEditorClient::dismissCorrectionPanel): Ditto
(WebEditorClient::isShowingCorrectionPanel): Query whether autocorrection panel is shown.

WebKit2:

  • WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::WebEditorClient::isShowingCorrectionPanel): Dummy implementation.

  • WebProcess/WebCoreSupport/WebEditorClient.h: Adopt new method delcared in base class.
00:40 Changeset [67450] by commit-queue@webkit.org

2010-09-14 Kwang Yul Seo <skyul@company100.net>

Reviewed by Kent Tamura.

[BREWMP] Remove TextBreakIteratorInternalICUBrew.cpp
https://bugs.webkit.org/show_bug.cgi?id=45691

Brew MP no longer depends on ICU for internationalization.
Remove TextBreakIteratorInternalICUBrew.cpp.

  • platform/text/brew/TextBreakIteratorInternalICUBrew.cpp: Removed.
00:12 Changeset [67449] by rniwa@webkit.org

2010-09-14 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Tony Chang.

applyInlineStyleToNodeRange does not extend run properly
https://bugs.webkit.org/show_bug.cgi?id=45616

The bug was caused by applyInlineStyleToNodeRange's skipping a node whenever it has children.
Fixed the bug by only skipping a node that contains the past end node, contains non-editable region,
or has a non-editable parent node. Also fixed a bug that applyInlineStyleToNodeRange does not remove
styled elements in a run that are identical to the one added. addInlineStyleIfNeeded now removes
all styled elements in a run using removeStyleFromRunBeforeApplyingStyle before calling addInlineStyleIfNeeded.

Test: editing/style/inline-style-extend-run.html

  • editing/ApplyStyleCommand.cpp: (WebCore::containsNonEditableRegion): Added. (WebCore::ApplyStyleCommand::applyInlineStyleToNodeRange): See above. (WebCore::ApplyStyleCommand::removeStyleFromRunBeforeApplyingStyle): Added, see above. (WebCore::ApplyStyleCommand::removeInlineStyleFromElement): Added support for RemoveAlways. (WebCore::ApplyStyleCommand::removeImplicitlyStyledElement): Replaced RemoveAttributesAndElements by RemoveIfNeeded. (WebCore::ApplyStyleCommand::extractInlineStyleToPushDown): Replaced RemoveAttributesAndElements by RemoveIfNeeded.
  • editing/ApplyStyleCommand.h:

2010-09-14 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Tony Chang.

applyInlineStyleToNodeRange does not extend a run properly
https://bugs.webkit.org/show_bug.cgi?id=45616

Added a test to ensure WebKit adds just one element when applying inline style and removes redundant styled elements.
Rebaseline of other tests are required because WebKit now generates less elements.

  • editing/execCommand/script-tests/toggle-style-3.js: Merged two b elements.
  • editing/execCommand/toggle-style-3-expected.txt: Ditto.
  • editing/execCommand/unlink-expected.txt: Changed the order in which span and anchor appear.
  • editing/style/inline-style-extend-run-expected.txt: Added.
  • editing/style/inline-style-extend-run.html: Added.
  • editing/style/script-tests/inline-style-extend-run.js: Added. (testSingleToggle):
  • editing/style/script-tests/make-text-writing-direction-inline.js: Merged two spans.

09/13/10:

23:51 Changeset [67448] by tkent@chromium.org

2010-09-13 Yuta Kitamura <yutak@chromium.org>

Reviewed by Kent Tamura.

Add one #if guard block to fix Qt builds.

Web Inspector: WebSocket in Resources tab
https://bugs.webkit.org/show_bug.cgi?id=40768

  • inspector/InspectorResource.cpp:
23:27 Changeset [67447] by commit-queue@webkit.org

2010-09-13 Yuta Kitamura <yutak@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: WebSocket in Resources tab
https://bugs.webkit.org/show_bug.cgi?id=40768

  • inspector/extensions-api-expected.txt: Added a new resource type.

2010-09-13 Yuta Kitamura <yutak@chromium.org>

Reviewed by Pavel Feldman.

Add WebSocket resource type to Web Inspector.

When a new WebSocket connection is established, a line for that connection
will appear in Web Inspector's Resources tab. If the resource name is
clicked, the details of handshake request and response will be shown.

Web Inspector: WebSocket in Resources tab
https://bugs.webkit.org/show_bug.cgi?id=40768

  • inspector/InspectorController.cpp: (WebCore::InspectorController::addResource): WebSocket resource does not have an associated loader, thus frame might be null. Need to check it. (WebCore::InspectorController::removeResource): Ditto. (WebCore::InspectorController::didCreateWebSocket): (WebCore::InspectorController::willSendWebSocketHandshakeRequest): (WebCore::InspectorController::didReceiveWebSocketHandshakeResponse): (WebCore::InspectorController::didCloseWebSocket):
  • inspector/InspectorController.h:
  • inspector/InspectorResource.cpp: Add null checks of m_loader and m_frame, because WebSocket does not have a loader and we need to allow null for these variables. (WebCore::createReadableStringFromBinary): (WebCore::InspectorResource::InspectorResource): (WebCore::InspectorResource::create): Factory function of regular (non-WebSocket) resources. (WebCore::InspectorResource::createWebSocket): Factory function of WebSocket resources. (WebCore::InspectorResource::updateWebSocketRequest): (WebCore::InspectorResource::updateWebSocketResponse): (WebCore::InspectorResource::updateScriptObject): m_frame->document() becomes available when Frame::setDocument() is called. We cannot obtain documentURL during the constructor or updateRequest() function, because m_frame->document() is not available yet at that point and documentURL will contain a wrong URL. As far as I know, updateScriptObject() is the only place where we can safely obtain documentURL. (WebCore::InspectorResource::cachedResource): (WebCore::InspectorResource::type): (WebCore::InspectorResource::resourceData):
  • inspector/InspectorResource.h: (WebCore::InspectorResource::): (WebCore::InspectorResource::markWebSocket):
  • inspector/front-end/Resource.js: (WebInspector.Resource.Type.toString): (WebInspector.Resource.prototype.set type): (WebInspector.Resource.prototype._mimeTypeIsConsistentWithType):
  • inspector/front-end/ResourceView.js: (WebInspector.ResourceView.prototype._refreshRequestHeaders): (WebInspector.ResourceView.prototype._refreshResponseHeaders): (WebInspector.ResourceView.prototype._refreshHeaders):
  • inspector/front-end/inspector.css: (.resources-category-websockets, .resources-category-other): (.resources-category-websockets .resources-graph-bar): (.resources-category-websockets.resource-cached .resources-graph-bar):
  • inspector/front-end/inspector.js: (WebInspector.loaded): (WebInspector.updateResource):
  • websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::WebSocketChannel): (WebCore::WebSocketChannel::disconnect): (WebCore::WebSocketChannel::didOpen): (WebCore::WebSocketChannel::didClose): (WebCore::WebSocketChannel::processBuffer): (WebCore::WebSocketChannel::identifier):
  • websockets/WebSocketChannel.h:
23:17 WebKit Team edited by kinuko@chromium.org
(diff)
23:06 Changeset [67446] by commit-queue@webkit.org

2010-09-13 Eric Uhrhane <ericu@chromium.org>

Reviewed by Darin Fisher.

Add Chromium API for FileWriter
https://bugs.webkit.org/show_bug.cgi?id=44360

Build file changes.

  • WebKit.gyp:

Added a way to get a WebFileWriter.

  • public/WebFileSystem.h: (WebKit::WebFileSystem::createFileWriter):

WebFileWriter writes and truncates files.

  • public/WebFileWriter.h: Added.

WebFileWriterClient reports success/failure and progress events.

  • public/WebFileWriterClient.h: Added.

AsyncFileWriterChromium is a connector that links FileWriter and WebFileWriter, FileWriterClient and WebFileWriterClient.

  • src/AsyncFileWriterChromium.cpp: Added.
  • src/AsyncFileWriterChromium.h: Added.
22:26 Changeset [67445] by commit-queue@webkit.org

2010-09-13 W. James MacLean <wjmaclean@google.com>

Reviewed by Darin Fisher.

[chromium] Thumbnails not generated for GPU Rendered Pages
https://bugs.webkit.org/show_bug.cgi?id=44127

Replicates existing functionality, use existing tests.
Adds pixel-readback for GPU composited pages to allow for thumbnailing,
printing and other services to work with GPU rendered pages.

  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::getFramebufferPixels):
  • platform/graphics/chromium/LayerRendererChromium.h: (WebCore::LayerRendererChromium::rootLayerTextureSize):

2010-09-13 W. James MacLean <wjmaclean@google.com>

Reviewed by Darin Fisher.

[chromium] Thumbnails not generated for GPU Rendered Pages
https://bugs.webkit.org/show_bug.cgi?id=44127

Modified WebViewImpl::paint() to detect non-null canvas pointers when
accelerated compositing is active, and instead fills the pixel buffer
from the GPU framebuffer. Includes re-scaling support when provided
canvas does not match size of current render layer. Limits pixel
readback to rect passed to paint(), clipped by size of rootLayerTexture.

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::doPixelReadbackToCanvas): (WebKit::WebViewImpl::paint):
  • src/WebViewImpl.h:
22:05 Changeset [67444] by kinuko@chromium.org

2010-09-13 Kinuko Yasuda <kinuko@chromium.org>

Unreviewed, build fix for Gtk.

  • bindings/js/JSEntryCustom.cpp:
21:59 Changeset [67443] by kinuko@chromium.org

2010-09-13 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by Adam Barth.

Make FileEntry and DirectoryEntry methods accessible via Entry instance
https://bugs.webkit.org/show_bug.cgi?id=45553

FileEntry- and DirectoryEntry- specific methods must be available on Entry object based on its internal type.

Added custom toJS/toV8 implementation to Entry interface.

No new tests; test will be added later when we have complete implementation for the API.

  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSEntryCustom.cpp: Added. (WebCore::toJS):
  • bindings/v8/custom/V8EntryCustom.cpp: Added. (WebCore::toV8):
  • fileapi/DirectoryEntry.h: Nits fix.
  • fileapi/DirectoryEntry.idl: Added ConvertUndefinedOrNullToString to path parameter.
  • fileapi/Entry.idl: Added CustomToJS attribute.
  • fileapi/FileEntry.cpp: (WebCore::FileEntry::createWriter): (WebCore::FileEntry::file):
  • fileapi/FileEntry.h:
  • fileapi/FileEntry.idl:
21:29 Changeset [67442] by dbates@webkit.org

2010-09-13 Daniel Bates <dbates@rim.com>

https://bugs.webkit.org/show_bug.cgi?id=45732

Fix the Qt build. I missed this when reviewing the patch
for Bug #45732.

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::suspendActiveDOMObjects): Change enum value ActiveDOMObject::JavaScriptPaused to ActiveDOMObject::JavaScriptDebuggerPaused
21:18 Changeset [67441] by rniwa@webkit.org

2010-09-13 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

REGRESSION: In Gmail, a crash occurs at getDoubleValue() when applying a text color to a new line
https://bugs.webkit.org/show_bug.cgi?id=45632

Test: editing/execCommand/query-font-size-with-typing-style.html

The crash was caused by selectionStartCSSPropertyValue's deleting nodeToRemove before
retrieving the font-size property. Fixed the bug by moving the removal code to the end of the function.

  • editing/Editor.cpp: (WebCore::Editor::selectionStartCSSPropertyValue):

2010-09-13 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

REGRESSION: In Gmail, a crash occurs at getDoubleValue() when applying a text color to a new line
https://bugs.webkit.org/show_bug.cgi?id=45632

Added a test to ensure WebKit does not crash when querying font size even if there is a typing style.

  • editing/execCommand/query-font-size-with-typing-style-expected.txt: Added.
  • editing/execCommand/query-font-size-with-typing-style.html: Added.
21:17 Changeset [67440] by eric.carlson@apple.com

2010-09-13 Eric Carlson <eric.carlson@apple.com>

Reviewed by Daniel Bates.

[Qt] DumpRenderTreeSupportQt::suspendActiveDOMObjects needs a new parameter
https://bugs.webkit.org/show_bug.cgi?id=45732

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::suspendActiveDOMObjects): Pass ActiveDOMObject::JavaScriptPaused to suspendActiveDOMObjects.
21:08 Changeset [67439] by jamesr@google.com

2010-09-13 James Robinson <jamesr@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] Return NULL from getSharedGraphicsContext3D if we couldn't initialize
https://bugs.webkit.org/show_bug.cgi?id=45731

If we can't create a GraphicsContext3D, return NULL from getSharedGraphicsContext3D rather
than an object with NULL internal pointers. Callers know how to handle a null return value
but not one that has inconsistent internal state.

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::getSharedGraphicsContext3D):
21:00 Changeset [67438] by commit-queue@webkit.org

2010-09-13 Kwang Yul Seo <skyul@company100.net>

Reviewed by Darin Adler.

[BREWMP] Remove WebCore namespace in SSLKeyGeneratorBrew.cpp
https://bugs.webkit.org/show_bug.cgi?id=45690

WebCore namespace is not required because getSupportedKeySizes and signedPublicKeyAndChallengeString are already
in namespace WebCore block.

  • platform/brew/SSLKeyGeneratorBrew.cpp: (WebCore::getSupportedKeySizes): (WebCore::signedPublicKeyAndChallengeString):
20:40 Changeset [67437] by weinig@apple.com

URL in address bar doesn't update when navigating to http://webkit.org/new-bug when using WebKit2
<rdar://problem/8272775>
https://bugs.webkit.org/show_bug.cgi?id=45729

Reviewed by Jon Honeycutt.

Pass an updated provisional url while notifying the UIProcess of
didReceiveServerRedirectForProvisionalLoadForFrame.

  • UIProcess/WebFrameProxy.cpp:

(WebKit::WebFrameProxy::didReceiveServerRedirectForProvisionalLoad):

  • UIProcess/WebFrameProxy.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didReceiveMessage):
(WebKit::WebPageProxy::didReceiveServerRedirectForProvisionalLoadForFrame):

  • UIProcess/WebPageProxy.h:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad):

20:23 Changeset [67436] by weinig@apple.com

Fix windows build.

  • UIProcess/Launcher/win/ProcessLauncherWin.cpp:
20:15 Changeset [67435] by commit-queue@webkit.org

2010-09-13 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Code simplification needed in Atk Wrapper
https://bugs.webkit.org/show_bug.cgi?id=45687

Use TextIterator::rangeLength() to calculate endOffset

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (getSelectionOffsetsForObject): Don't manually iterate over a artificial new range but just call TextIterator::rangeLength on the range created between the start and end positions.
19:54 Changeset [67434] by weinig@apple.com

Clean up xcode project.

Reviewed by Alice Liu.

  • WebCore.xcodeproj/project.pbxproj:
19:48 Changeset [67433] by weinig@apple.com

Threaded mode should work in WebKit2 MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=45727

Reviewed by Jon Honeycutt.

  • Make starting the web thread more like starting a new process (encapsulate it in a thread launcher class).
  • Make the call to didFinishLaunching asynchronous so that WebProcess is fully constructed before it is called.
  • Platform/WorkItem.h:

(MemberFunctionWorkItem1::MemberFunctionWorkItem1):
(MemberFunctionWorkItem1::~MemberFunctionWorkItem1):
(MemberFunctionWorkItem1::execute):
(WorkItem::create):

  • UIProcess/Launcher/ProcessLauncher.h:
  • UIProcess/Launcher/ThreadLauncher.cpp: Added.

(WebKit::ThreadLauncher::ThreadLauncher):
(WebKit::ThreadLauncher::launchThread):
(WebKit::ThreadLauncher::didFinishLaunchingThread):
(WebKit::ThreadLauncher::invalidate):

  • UIProcess/Launcher/ThreadLauncher.h: Added.

(WebKit::ThreadLauncher::Client::~Client):
(WebKit::ThreadLauncher::create):
(WebKit::ThreadLauncher::isLaunching):

  • UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::ProcessLauncher::terminateProcess):

  • UIProcess/Launcher/mac/ThreadLauncherMac.mm: Added.

(WebKit::webThreadBody):
(WebKit::ThreadLauncher::createWebThread):

  • UIProcess/Launcher/qt/ProcessLauncherQt.cpp:
  • UIProcess/Launcher/qt/ThreadLauncherQt.cpp: Added.

(WebKit::webThreadBody):
(WebKit::ProcessLauncher::createWebThread):

  • UIProcess/Launcher/win/ProcessLauncherWin.cpp:
  • UIProcess/Launcher/win/ThreadLauncherWin.cpp: Added.

(WebKit::webThreadBody):
(WebKit::ProcessLauncher::createWebThread):

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::~WebProcessProxy):
(WebKit::WebProcessProxy::connect):
(WebKit::WebProcessProxy::isLaunching):
(WebKit::WebProcessProxy::didFinishLaunching):

  • UIProcess/WebProcessProxy.h:
  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:
19:41 Changeset [67432] by eric.carlson@apple.com

2010-09-13 Eric Carlson <eric.carlson@apple.com>

Reviewed by Geoff Garen.

JavaScript dialog should not deactivate media element
https://bugs.webkit.org/show_bug.cgi?id=45688

Test: http/tests/media/reload-after-dialog.html

  • bindings/generic/ActiveDOMCallback.cpp: (WebCore::ActiveDOMObjectCallbackImpl::suspend): Add ReasonForSuspension parameter.
  • bindings/js/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::setJavaScriptPaused): Pass new parameter to suspendActiveDOMObjects.
  • dom/ActiveDOMObject.cpp: (WebCore::ActiveDOMObject::suspend): Add ReasonForSuspension parameter.
  • dom/ActiveDOMObject.h:
  • dom/ScriptExecutionContext.cpp: (WebCore::ScriptExecutionContext::suspendActiveDOMObjects): Ditto.
  • dom/ScriptExecutionContext.h:
  • history/CachedFrame.cpp: (WebCore::CachedFrame::CachedFrame): Pass new parameter to suspendActiveDOMObjects.
  • html/HTMLMarqueeElement.cpp: (WebCore::HTMLMarqueeElement::suspend): Add ReasonForSuspension parameter.
  • html/HTMLMarqueeElement.h:
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::stop): Deal with element being suspended. (WebCore::HTMLMediaElement::suspend): Do nothing unless reason for suspension is document becoming inactive.
  • html/HTMLMediaElement.h:
  • page/PageGroupLoadDeferrer.cpp: (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer): Pass WillShowDialog to suspendActiveDOMObjects.
  • page/SuspendableTimer.cpp: (WebCore::SuspendableTimer::suspend): Add ReasonForSuspension parameter.
  • page/SuspendableTimer.h:
  • websockets/WebSocket.cpp: (WebCore::WebSocket::suspend): Ditto.
  • websockets/WebSocket.h:
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::suspend): Ditto.
  • xml/XMLHttpRequest.h:

2010-09-13 Eric Carlson <eric.carlson@apple.com>

Reviewed by Geoff Garen.

JavaScript dialog should not deactivate media element
https://bugs.webkit.org/show_bug.cgi?id=45688

  • http/tests/media/reload-after-dialog-expected.txt: Added.
  • http/tests/media/reload-after-dialog.html: Added.
19:15 Changeset [67431] by weinig@apple.com

Fix the mac build.

  • page/mac/EventHandlerMac.mm:

(WebCore::EventHandler::passMousePressEventToSubframe):

19:03 Changeset [67430] by weinig@apple.com

Can't scroll on Bugzilla patch review pages on Mac with WebKit2
https://bugs.webkit.org/show_bug.cgi?id=43555

Reviewed by Anders Carlsson.

<rdar://problem/8421386> WebKit2: gmail.com is completely unresponsive to clicks
<rdar://problem/8276298> Can't scroll on Bugzilla patch review pages on Mac with WebKit2 (43555)

  • page/mac/EventHandlerMac.mm:

(WebCore::EventHandler::passWheelEventToWidget):
(WebCore::frameHasPlatformWidget):
(WebCore::EventHandler::passMousePressEventToSubframe):
(WebCore::EventHandler::passMouseMoveEventToSubframe):
(WebCore::EventHandler::passMouseReleaseEventToSubframe):
Add WebKit2 mode for these functions based on the presence of a platform widget for a
FrameView.

18:38 Changeset [67429] by eric@webkit.org

2010-09-13 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

commit-queue should log when it's retrying due to checkout out of date error
https://bugs.webkit.org/show_bug.cgi?id=45725

This will allow us to better track how often we see these errors
and how long it takes the queue to recover from them.

In order to pass the tests, I had to correct an error
from a previous change. The UnitTestPort should not have
ever been using the base port method as that will read
a file from disk. If the unit tests haven't passed the contents
it should raise an IOError as though the file doesn't exist.

  • Scripts/webkitpy/layout_tests/port/base_unittest.py:
  • Scripts/webkitpy/tool/commands/queues.py:
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
18:37 Changeset [67428] by commit-queue@webkit.org

2010-09-13 Mihai Parparita <mihaip@chromium.org>

Reviewed by Adam Barth.

Upload results when cq patch landing fails
https://bugs.webkit.org/show_bug.cgi?id=45683

Include script errors when CommitQueue._land fails.

  • Scripts/webkitpy/tool/commands/queues.py:
18:10 Changeset [67427] by commit-queue@webkit.org

2010-09-13 Patrick Gansterer <paroga@paroga.com>

Reviewed by Kenneth Rohde Christiansen.

[WINCE] Buildfix for ViewportArguments.cpp
https://bugs.webkit.org/show_bug.cgi?id=45678

Use fabs() instead of abs().
This patch also fixes the return value, when
the value is between -1 and 1.

  • dom/ViewportArguments.cpp: (WebCore::findUserScalableValue):
18:02 Changeset [67426] by dpranke@chromium.org

2010-09-13 Dirk Pranke <dpranke@chromium.org>

Unreviewed, build fix.

Fix duplicate entries in expectations file; we really need to fix
the checkin trigger to catch these.

  • platform/chromium/test_expectations.txt:
17:56 Changeset [67425] by dpranke@chromium.org

2010-09-13 Dirk Pranke <dpranke@chromium.org>

Unreviewed, expectations change.

Add some suppressions back in - it looks like we are probably tripping
over some debug asserts that I need to triage downstream.

  • platform/chromium/test_expectations.txt:
17:29 Changeset [67424] by commit-queue@webkit.org

2010-09-13 Rafael Antognolli <antognolli@profusion.mobi>

Unreviewed build fix.

[EFL] Fix build break when enabling HTML5 video support
https://bugs.webkit.org/show_bug.cgi?id=45674

The correct include variable for LibXml2 in cmake is
LIBXML2_INCLUDE_DIR instead of LIBXML2_INCLUDE_DIRS.

  • CMakeListsEfl.txt:
16:42 Changeset [67423] by darin@apple.com

2010-09-13 Darin Adler <darin@apple.com>

Reviewed by Adam Barth.

Preparation for eliminating deprecatedParseURL
https://bugs.webkit.org/show_bug.cgi?id=45695

  • wtf/text/WTFString.h: Added isAllSpecialCharacters, moved here from the HTML tree builder.

2010-09-13 Darin Adler <darin@apple.com>

Reviewed by Adam Barth.

Preparation for eliminating deprecatedParseURL
https://bugs.webkit.org/show_bug.cgi?id=45695

  • DOM/WebDOMOperations.mm: (-[DOMDocument webFrame]): Get rid of unneeded local variable. (-[DOMDocument URLWithAttributeString:]): Remove unhelpful comment.

2010-09-13 Darin Adler <darin@apple.com>

Reviewed by Adam Barth.

Preparation for eliminating deprecatedParseURL
https://bugs.webkit.org/show_bug.cgi?id=45695

Added new HTMLParserIdioms source file, with a name inspired by the HTML
specification, which has a section defining things like "space character"
that talks about common parser idioms. These are idioms for the main HTML
parser and for parsers for various microlanguages as well.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj: Added HTMLParserIdioms.
  • css/CSSHelper.h: Fixed indentation and comments here. Point to the new stripLeadingAndTrailingHTMLSpaces function.
  • html/parser/HTMLParserIdioms.cpp: Added.
  • html/parser/HTMLParserIdioms.h: Added.
  • html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::skipLeadingWhitespace): (WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::takeLeadingWhitespace): (WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::takeLeadingNonWhitespace): (WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::takeRemainingWhitespace): Updated for name changes.
  • html/parser/HTMLTreeBuilder.h: Moved functions to HTMLParserIdioms.h.
  • html/HTMLInputElement.cpp:
  • html/HTMLMeterElement.cpp:
  • html/HTMLProgressElement.cpp:
  • html/StepRange.cpp:
  • rendering/RenderSlider.cpp: Updated includes.
  • svg/SVGImageLoader.cpp: (WebCore::SVGImageLoader::sourceURI): Fixed incorrect use of deprecatedParseURL. This is for use on the attribute value before building the URL, not on the URL after building it. I did not add a test case; this is an obscure corner and soon we will be moving to stripLeadingAndTrailingHTMLSpaces anyway.
  • wml/WMLImageLoader.cpp: (WebCore::WMLImageLoader::sourceURI): Ditto.
16:27 Changeset [67422] by cfleizach@apple.com

AX: REGRESSION: WebKit does not report label of web popup buttons
https://bugs.webkit.org/show_bug.cgi?id=45715

Reviewed by Darin Adler.

WebCore:

Test: platform/mac/accessibility/popup-button-title.html

  • WebCore.xcodeproj/project.pbxproj:
  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::title):

LayoutTests:

  • platform/mac/accessibility/popup-button-title-expected.txt: Added.
  • platform/mac/accessibility/popup-button-title.html: Added.
16:14 Changeset [67421] by kinuko@chromium.org

2010-09-13 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by Dumitru Daniliuc.

Expose Flags constructor if FileSystem API is Enabled
https://bugs.webkit.org/show_bug.cgi?id=45165

This change also includes:

No new tests; tests will be added when we fully expose the interface.

  • bindings/v8/V8DOMWindowCustom.cpp: Added custom getter for FlagsConstructor.
  • fileapi/Flags.idl: Changed attribute names to camelCase.
  • page/DOMWindow.idl: Exposed Flags constructor.
  • bindings/scripts/CodeGenerator.pm: Updated the WK_lcfirst hack to work around getter method for 'create' (create() should be avoided as it's widely used to instantiate an object).
  • bindings/scripts/CodeGeneratorV8.pm: Added EnabledAtRuntime=FeatureName support.
  • bindings/scripts/test/CPP/WebDOMTestObj.cpp: (WebDOMTestObj::create): (WebDOMTestObj::setCreate):
  • bindings/scripts/test/CPP/WebDOMTestObj.h:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: (webkit_dom_test_obj_set_property): (webkit_dom_test_obj_get_property): (webkit_dom_test_obj_class_init):
  • bindings/scripts/test/GObject/WebKitDOMTestObj.h:
  • bindings/scripts/test/JS/JSTestObj.cpp:
  • bindings/scripts/test/ObjC/DOMTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.mm:
  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/V8/V8TestObj.cpp: (WebCore::TestObjInternal::createAttrGetter): (WebCore::TestObjInternal::createAttrSetter): (WebCore::TestObjInternal::enabledAtRuntimeAttr1AttrGetter): (WebCore::TestObjInternal::enabledAtRuntimeAttr1AttrSetter): (WebCore::TestObjInternal::enabledAtRuntimeAttr2AttrGetter): (WebCore::TestObjInternal::enabledAtRuntimeAttr2AttrSetter): (WebCore::TestObjInternal::enabledAtRuntimeMethod1Callback): (WebCore::TestObjInternal::enabledAtRuntimeMethod2Callback): (WebCore::ConfigureV8TestObjTemplate):
16:10 Changeset [67420] by abarth@webkit.org

2010-09-13 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

"Implement" EOF processing in AfterBodyMode and AfterAfterBodyMode
https://bugs.webkit.org/show_bug.cgi?id=45647

Implements the notImplemented by doing nothing, which is the proper
behavior according to the spec.

  • html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processEndOfFile):
16:08 Changeset [67419] by abarth@webkit.org

2010-09-13 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

More trivial EOF handling in tree builder
https://bugs.webkit.org/show_bug.cgi?id=45648

The spec says to treat these modes like the InBodyMode, which is what
this patch does. Doing so is indistinguishable from our current
behavior, which is why we didn't catch this based on tests.

  • html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processEndOfFile):
15:59 Changeset [67418] by commit-queue@webkit.org

2010-09-13 Chris Guillory <chris.guillory@google.com>

Reviewed by Chris Fleizach.

WebAccessibilityCacheImpl needs to handle invalid accessibility object ids.
https://bugs.webkit.org/show_bug.cgi?id=45572

  • public/WebAccessibilityObject.h:
  • src/WebAccessibilityCacheImpl.cpp: (WebKit::WebAccessibilityCacheImpl::addOrGetId):
  • src/WebAccessibilityObject.cpp: (WebKit::WebAccessibilityObject::isAxObjectIdValid):
15:58 Changeset [67417] by dpranke@chromium.org

2010-09-13 Dirk Pranke <dpranke@chromium.org>

Unreviewed, expectations change.

Remove a bunch of tests that are now passing.

  • platform/chromium/test_expectations.txt:
15:27 Changeset [67416] by dpranke@chromium.org

2010-09-13 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

[Chromium] rebaseline two svg tests after r67200
https://bugs.webkit.org/show_bug.cgi?id=45665

  • platform/chromium-linux/svg/batik/text/textPosition-expected.txt:
  • platform/chromium-linux/svg/batik/text/textPosition2-expected.txt:
  • platform/chromium/test_expectations.txt:
15:26 Changeset [67415] by dpranke@chromium.org

2010-09-13 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

[Chromium] mark fast/files/read-blob-async.html as CRASH PASS on linux
https://bugs.webkit.org/show_bug.cgi?id=45672

  • platform/chromium/test_expectations.txt:
15:10 Changeset [67414] by dpranke@chromium.org

2010-09-13 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Dimitri Glazkov.

[Chromium] fix broken dependency in ImageDiff
https://bugs.webkit.org/show_bug.cgi?id=45684

  • WebKit.gyp:
15:05 Changeset [67413] by commit-queue@webkit.org

2010-09-13 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Add setting API for enabling page cache
https://bugs.webkit.org/show_bug.cgi?id=44931

  • ewk/ewk_view.cpp: (_ewk_view_priv_new): (ewk_view_setting_page_cache_get): Added. (ewk_view_setting_page_cache_set): Added.
  • ewk/ewk_view.h:
14:39 Changeset [67412] by jamesr@google.com

2010-09-13 James Robinson <jamesr@chromium.org>

Reviewed by Kenneth Russell.

SharedGraphicsContext3D's texture cache holds on to images after free
https://bugs.webkit.org/show_bug.cgi?id=45706

Each SharedGraphicsContext3D keeps a cache of uploaded textures keyed by NativeImagePtrs.
Whenever the backing native image is deleted it needs to let the SharedGraphicsContext3D know
so that the cache entry and associated texture can also be removed.

  • platform/graphics/gpu/SharedGraphicsContext3D.cpp: (WebCore::SharedGraphicsContext3D::SharedGraphicsContext3D): (WebCore::SharedGraphicsContext3D::~SharedGraphicsContext3D): (WebCore::SharedGraphicsContext3D::removeTextureFor): (WebCore::SharedGraphicsContext3D::removeTexturesFor): (WebCore::SharedGraphicsContext3D::allContexts):
  • platform/graphics/gpu/SharedGraphicsContext3D.h:
  • platform/graphics/skia/NativeImageSkia.cpp: (WebCore::NativeImageSkia::~NativeImageSkia):
  • platform/graphics/skia/NativeImageSkia.h:
14:23 Changeset [67411] by weinig@apple.com

didFinishDocumentLoadForFrame() is not being sent by WebKit2
<rdar://problem/8424171>

Reviewed by Anders Carlsson.

Finish wiring up didFinishDocumentLoad to the UIProcess.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDidFinishDocumentLoad):

14:08 Changeset [67410] by darin@chromium.org

Merge 67401 - 210-09-13 Darin Fisher <darin@chromium.org>

Reviewed by David Levin.

Add option to conditionally compile smooth scrolling support.
https://bugs.webkit.org/show_bug.cgi?id=45689

The OS(WINDOWS) conditional becomes unnecessary since
ENABLE(SMOOTH_SCROLLING) should only be specified on
platforms that have a smooth scrolling implementation.

  • platform/ScrollAnimator.cpp:
  • platform/ScrollAnimatorWin.cpp:
  • platform/ScrollAnimatorWin.h:

TBR=darin@chromium.org
Review URL: http://codereview.chromium.org/3290027

14:08 Changeset [67409] by enrica@apple.com

One more attempt at fixing the Windows build.
Not reviewed.

14:06 Changeset [67408] by cfleizach@apple.com

AX: accessibilityIsIgnored is returning nil when return value expects a BOOL
https://bugs.webkit.org/show_bug.cgi?id=45548

Reviewed by David Kilzer.

WebCore:

Test: platform/mac/accessibility/element-is-ignored.html

  • accessibility/mac/AccessibilityObjectWrapper.mm:

(-[AccessibilityObjectWrapper accessibilityIsIgnored]):

WebKitTools:

  • DumpRenderTree/AccessibilityUIElement.cpp:

(isIgnoredCallback):
(AccessibilityUIElement::getJSClass):

  • DumpRenderTree/AccessibilityUIElement.h:
  • DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:

(AccessibilityUIElement::isIgnored):

  • DumpRenderTree/mac/AccessibilityUIElementMac.mm:

(AccessibilityUIElement::isIgnored):

  • DumpRenderTree/win/AccessibilityUIElementWin.cpp:

(AccessibilityUIElement::isIgnored):

LayoutTests:

  • platform/mac/accessibility/element-is-ignored-expected.txt: Added.
  • platform/mac/accessibility/element-is-ignored.html: Added.
13:55 Changeset [67407] by cfleizach@apple.com

CrashTracer: 874 crashes in Safari at com.apple.WebCore: WebCore::AccessibilityTable::isTableExposableThroughAccessibility + 663
https://bugs.webkit.org/show_bug.cgi?id=45697

Reviewed by Darin Adler.

WebCore:

Inside of AccessibilityTableRow, parentTable() should not use getOrCreate() on the parent table, because the render table may
be in a bad state and accessing internal variables can lead to a crash.

Test: platform/mac/accessibility/updating-attribute-in-table-row-crash.html

  • accessibility/AccessibilityTableRow.cpp:

(WebCore::AccessibilityTableRow::parentTable):

LayoutTests:

  • platform/mac/accessibility/updating-attribute-in-table-row-crash-expected.txt: Added.
  • platform/mac/accessibility/updating-attribute-in-table-row-crash.html: Added.
13:49 Changeset [67406] by abarth@webkit.org

2010-09-13 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Implement EOF handling in TextMode
https://bugs.webkit.org/show_bug.cgi?id=45644

This patch is actually covered by a bunch of tests. We were just
magically passing the tests before because of some nutty code in
Document.cpp.

  • dom/Document.cpp: (WebCore::Document::implicitClose):
    • This code was masking the notImplemented in the tree builder. I also removed the use of the setting because it wasn't working properly anyway. I'll implement a working version shortly.
  • html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processEndOfFile):
    • Implement per the spec.
13:43 Changeset [67405] by enrica@apple.com

Fixing Windows build.
Not reviewed.

12:40 Changeset [67404] by tony@chromium.org

2010-09-13 Tony Chang <tony@chromium.org>

Unreviewed, removing chromium-linux results that deduplicate-tests says are
unnecessary (mostly due to the checksum computation change last week).

  • platform/chromium-linux/editing/deleting/collapse-whitespace-3587601-fix-expected.checksum: Removed.
  • platform/chromium-linux/editing/deleting/collapse-whitespace-3587601-fix-expected.png: Removed.
  • platform/chromium-linux/editing/deleting/delete-at-start-or-end-expected.checksum: Removed.
  • platform/chromium-linux/editing/deleting/delete-at-start-or-end-expected.png: Removed.
  • platform/chromium-linux/editing/deleting/delete-block-contents-001-expected.checksum: Removed.
  • platform/chromium-linux/editing/deleting/delete-block-contents-001-expected.png: Removed.
  • platform/chromium-linux/editing/deleting/delete-block-contents-002-expected.checksum: Removed.
  • platform/chromium-linux/editing/deleting/delete-block-contents-002-expected.png: Removed.
  • platform/chromium-linux/editing/deleting/delete-image-004-expected.checksum: Removed.
  • platform/chromium-linux/editing/deleting/delete-image-004-expected.png: Removed.
  • platform/chromium-linux/editing/deleting/delete-select-all-002-expected.checksum: Removed.
  • platform/chromium-linux/editing/deleting/delete-select-all-002-expected.png: Removed.
  • platform/chromium-linux/editing/deleting/delete-select-all-003-expected.checksum: Removed.
  • platform/chromium-linux/editing/deleting/delete-select-all-003-expected.png: Removed.
  • platform/chromium-linux/editing/undo/5378473-expected.checksum: Removed.
  • platform/chromium-linux/editing/undo/5378473-expected.png: Removed.
  • platform/chromium-linux/editing/undo/undo-misspellings-expected.checksum: Removed.
  • platform/chromium-linux/editing/undo/undo-misspellings-expected.png: Removed.
  • platform/chromium-linux/fast/backgrounds/bgCompositeCopy-expected.checksum: Removed.
  • platform/chromium-linux/fast/backgrounds/bgCompositeCopy-expected.png: Removed.
  • platform/chromium-linux/fast/backgrounds/svg-as-background-2-expected.checksum: Removed.
  • platform/chromium-linux/fast/backgrounds/svg-as-background-2-expected.png: Removed.
  • platform/chromium-linux/fast/block/basic/quirk-percent-height-table-cell-expected.checksum: Removed.
  • platform/chromium-linux/fast/block/basic/quirk-percent-height-table-cell-expected.png: Removed.
  • platform/chromium-linux/fast/canvas/canvas-as-image-incremental-repaint-expected.checksum: Removed.
  • platform/chromium-linux/fast/canvas/canvas-as-image-incremental-repaint-expected.png: Removed.
  • platform/chromium-linux/fast/css/getComputedStyle/computed-style-expected.txt: Removed.
  • platform/chromium-linux/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Removed.
  • platform/chromium-linux/fast/dom/attr_dead_doc-expected.checksum: Removed.
  • platform/chromium-linux/fast/dom/attr_dead_doc-expected.png: Removed.
  • platform/chromium-linux/fast/frames/content-opacity-1-expected.checksum: Removed.
  • platform/chromium-linux/fast/frames/content-opacity-1-expected.png: Removed.
  • platform/chromium-linux/fast/frames/content-opacity-2-expected.checksum: Removed.
  • platform/chromium-linux/fast/frames/content-opacity-2-expected.png: Removed.
  • platform/chromium-linux/fast/frames/iframe-text-contents-expected.checksum: Removed.
  • platform/chromium-linux/fast/frames/iframe-text-contents-expected.png: Removed.
  • platform/chromium-linux/fast/layers/add-layer-with-nested-stacking-expected.checksum: Removed.
  • platform/chromium-linux/fast/layers/add-layer-with-nested-stacking-expected.png: Removed.
  • platform/chromium-linux/fast/layers/self-painting-outline-expected.checksum: Removed.
  • platform/chromium-linux/fast/layers/self-painting-outline-expected.png: Removed.
  • platform/chromium-linux/fast/repaint/background-generated-expected.checksum: Removed.
  • platform/chromium-linux/fast/repaint/background-generated-expected.png: Removed.
  • platform/chromium-linux/fast/repaint/background-misaligned-expected.checksum: Removed.
  • platform/chromium-linux/fast/repaint/background-misaligned-expected.png: Removed.
  • platform/chromium-linux/fast/repaint/block-selection-gap-in-table-cell-expected.checksum: Removed.
  • platform/chromium-linux/fast/repaint/block-selection-gap-in-table-cell-expected.png: Removed.
  • platform/chromium-linux/fast/repaint/block-selection-gap-stale-cache-expected.checksum: Removed.
  • platform/chromium-linux/fast/repaint/block-selection-gap-stale-cache-expected.png: Removed.
  • platform/chromium-linux/fast/repaint/button-spurious-layout-hint-expected.checksum: Removed.
  • platform/chromium-linux/fast/repaint/button-spurious-layout-hint-expected.png: Removed.
  • platform/chromium-linux/fast/repaint/clip-with-layout-delta-expected.checksum: Removed.
  • platform/chromium-linux/fast/repaint/clip-with-layout-delta-expected.png: Removed.
  • platform/chromium-linux/fast/repaint/content-into-overflow-expected.checksum: Removed.
  • platform/chromium-linux/fast/repaint/content-into-overflow-expected.png: Removed.
  • platform/chromium-linux/fast/repaint/float-in-new-block-with-layout-delta-expected.checksum: Removed.
  • platform/chromium-linux/fast/repaint/float-in-new-block-with-layout-delta-expected.png: Removed.
  • platform/chromium-linux/fast/repaint/float-new-in-block-expected.checksum: Removed.
  • platform/chromium-linux/fast/repaint/float-new-in-block-expected.png: Removed.
  • platform/chromium-linux/fast/repaint/focus-ring-expected.checksum: Removed.
  • platform/chromium-linux/fast/repaint/focus-ring-expected.png: Removed.
  • platform/chromium-linux/fast/repaint/inline-relative-positioned-expected.checksum: Removed.
  • platform/chromium-linux/fast/repaint/inline-relative-positioned-expected.png: Removed.
  • platform/chromium-linux/fast/repaint/intermediate-layout-position-clip-expected.checksum: Removed.
  • platform/chromium-linux/fast/repaint/intermediate-layout-position-clip-expected.png: Removed.
  • platform/chromium-linux/fast/repaint/intermediate-layout-position-expected.checksum: Removed.
  • platform/chromium-linux/fast/repaint/intermediate-layout-position-expected.png: Removed.
  • platform/chromium-linux/fast/repaint/multicol-repaint-expected.checksum: Removed.
  • platform/chromium-linux/fast/repaint/multicol-repaint-expected.png: Removed.
  • platform/chromium-linux/fast/repaint/outline-inset-expected.checksum: Removed.
  • platform/chromium-linux/fast/repaint/outline-inset-expected.png: Removed.
  • platform/chromium-linux/fast/repaint/overflow-into-content-expected.checksum: Removed.
  • platform/chromium-linux/fast/repaint/overflow-into-content-expected.png: Removed.
  • platform/chromium-linux/fast/repaint/selection-clear-expected.checksum: Removed.
  • platform/chromium-linux/fast/repaint/selection-clear-expected.png: Removed.
  • platform/chromium-linux/fast/repaint/table-outer-border-expected.checksum: Removed.
  • platform/chromium-linux/fast/repaint/table-outer-border-expected.png: Removed.
  • platform/chromium-linux/fast/repaint/table-section-repaint-expected.checksum: Removed.
  • platform/chromium-linux/fast/repaint/table-section-repaint-expected.png: Removed.
  • platform/chromium-linux/fast/repaint/table-two-pass-layout-overpaint-expected.checksum: Removed.
  • platform/chromium-linux/fast/repaint/table-two-pass-layout-overpaint-expected.png: Removed.
  • platform/chromium-linux/fast/repaint/transform-disable-layoutstate-expected.checksum: Removed.
  • platform/chromium-linux/fast/repaint/transform-disable-layoutstate-expected.png: Removed.
  • platform/chromium-linux/fast/repaint/transform-replaced-shadows-expected.checksum: Removed.
  • platform/chromium-linux/fast/repaint/transform-replaced-shadows-expected.png: Removed.
  • platform/chromium-linux/fast/table/border-collapsing/equal-precedence-resolution-expected.checksum: Removed.
  • platform/chromium-linux/fast/table/border-collapsing/equal-precedence-resolution-expected.png: Removed.
  • platform/chromium-linux/fast/table/giantRowspan-expected.checksum: Removed.
  • platform/chromium-linux/fast/table/giantRowspan-expected.png: Removed.
  • platform/chromium-linux/fast/table/multiple-percent-height-rows-expected.checksum: Removed.
  • platform/chromium-linux/fast/table/multiple-percent-height-rows-expected.png: Removed.
  • platform/chromium-linux/svg/css/getComputedStyle-basic-expected.txt: Removed.
  • platform/chromium-linux/svg/custom/control-points-for-S-and-T-expected.checksum: Removed.
  • platform/chromium-linux/svg/custom/control-points-for-S-and-T-expected.png: Removed.
  • platform/chromium-linux/svg/custom/dynamic-empty-path-expected.checksum: Removed.
  • platform/chromium-linux/svg/custom/dynamic-empty-path-expected.png: Removed.
  • platform/chromium-linux/svg/custom/feDisplacementMap-01-expected.checksum: Removed.
  • platform/chromium-linux/svg/custom/feDisplacementMap-01-expected.png: Removed.
  • platform/chromium-linux/svg/custom/fill-opacity-hsl-expected.checksum: Removed.
  • platform/chromium-linux/svg/custom/fill-opacity-hsl-expected.png: Removed.
  • platform/chromium-linux/svg/custom/fill-opacity-rgba-expected.checksum: Removed.
  • platform/chromium-linux/svg/custom/fill-opacity-rgba-expected.png: Removed.
  • platform/chromium-linux/svg/custom/gradient-stop-corner-cases-expected.checksum: Removed.
  • platform/chromium-linux/svg/custom/gradient-stop-corner-cases-expected.png: Removed.
  • platform/chromium-linux/svg/custom/group-opacity-expected.checksum: Removed.
  • platform/chromium-linux/svg/custom/group-opacity-expected.png: Removed.
  • platform/chromium-linux/svg/custom/js-repaint-rect-on-path-with-stroke-expected.checksum: Removed.
  • platform/chromium-linux/svg/custom/js-repaint-rect-on-path-with-stroke-expected.png: Removed.
  • platform/chromium-linux/svg/custom/js-update-container-expected.checksum: Removed.
  • platform/chromium-linux/svg/custom/js-update-container-expected.png: Removed.
  • platform/chromium-linux/svg/custom/js-update-container2-expected.checksum: Removed.
  • platform/chromium-linux/svg/custom/js-update-container2-expected.png: Removed.
  • platform/chromium-linux/svg/custom/js-update-polygon-changes-expected.checksum: Removed.
  • platform/chromium-linux/svg/custom/js-update-polygon-changes-expected.png: Removed.
  • platform/chromium-linux/svg/custom/js-update-polygon-removal-expected.checksum: Removed.
  • platform/chromium-linux/svg/custom/js-update-polygon-removal-expected.png: Removed.
  • platform/chromium-linux/svg/custom/js-update-style-expected.checksum: Removed.
  • platform/chromium-linux/svg/custom/js-update-style-expected.png: Removed.
  • platform/chromium-linux/svg/custom/js-update-transform-addition-expected.checksum: Removed.
  • platform/chromium-linux/svg/custom/js-update-transform-addition-expected.png: Removed.
  • platform/chromium-linux/svg/custom/marker-referencePoint-expected.checksum: Removed.
  • platform/chromium-linux/svg/custom/marker-referencePoint-expected.png: Removed.
  • platform/chromium-linux/svg/custom/mask-changes-expected.checksum: Removed.
  • platform/chromium-linux/svg/custom/mask-changes-expected.png: Removed.
  • platform/chromium-linux/svg/custom/pattern-y-offset-expected.checksum: Removed.
  • platform/chromium-linux/svg/custom/pattern-y-offset-expected.png: Removed.
  • platform/chromium-linux/svg/custom/repaint-moving-svg-and-div-expected.checksum: Removed.
  • platform/chromium-linux/svg/custom/repaint-moving-svg-and-div-expected.png: Removed.
  • platform/chromium-linux/svg/custom/repaint-stroke-width-changes-expected.checksum: Removed.
  • platform/chromium-linux/svg/custom/repaint-stroke-width-changes-expected.png: Removed.
  • platform/chromium-linux/svg/custom/text-dom-removal-expected.checksum: Removed.
  • platform/chromium-linux/svg/custom/text-dom-removal-expected.png: Removed.
  • platform/chromium-linux/svg/custom/use-forward-refs-expected.checksum: Removed.
  • platform/chromium-linux/svg/custom/use-forward-refs-expected.png: Removed.
  • platform/chromium-linux/svg/hixie/data-types/001-expected.checksum: Removed.
  • platform/chromium-linux/svg/hixie/data-types/001-expected.png: Removed.
  • platform/chromium-linux/svg/zoom/text/absolute-sized-document-no-scrollbars-expected.checksum: Removed.
  • platform/chromium-linux/svg/zoom/text/absolute-sized-document-no-scrollbars-expected.png: Removed.
  • platform/chromium-linux/svg/zoom/text/absolute-sized-document-scrollbars-expected.checksum: Removed.
  • platform/chromium-linux/svg/zoom/text/absolute-sized-document-scrollbars-expected.png: Removed.
  • platform/chromium-linux/svg/zoom/text/relative-sized-document-scrollbars-expected.checksum: Removed.
  • platform/chromium-linux/svg/zoom/text/relative-sized-document-scrollbars-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/bugs/bug106795-expected.checksum: Removed.
  • platform/chromium-linux/tables/mozilla/bugs/bug106795-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/bugs/bug131020-2-expected.checksum: Removed.
  • platform/chromium-linux/tables/mozilla/bugs/bug131020-2-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/bugs/bug13169-expected.checksum: Removed.
  • platform/chromium-linux/tables/mozilla/bugs/bug13169-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/bugs/bug133948-expected.checksum: Removed.
  • platform/chromium-linux/tables/mozilla/bugs/bug133948-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/bugs/bug137388-1-expected.checksum: Removed.
  • platform/chromium-linux/tables/mozilla/bugs/bug137388-1-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/bugs/bug137388-3-expected.checksum: Removed.
  • platform/chromium-linux/tables/mozilla/bugs/bug137388-3-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/bugs/bug1818-1-expected.checksum: Removed.
  • platform/chromium-linux/tables/mozilla/bugs/bug1818-1-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/bugs/bug1818-2-expected.checksum: Removed.
  • platform/chromium-linux/tables/mozilla/bugs/bug1818-2-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/bugs/bug1818-3-expected.checksum: Removed.
  • platform/chromium-linux/tables/mozilla/bugs/bug1818-3-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/bugs/bug1818-4-expected.checksum: Removed.
  • platform/chromium-linux/tables/mozilla/bugs/bug1818-4-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/bugs/bug219693-1-expected.checksum: Removed.
  • platform/chromium-linux/tables/mozilla/bugs/bug219693-1-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/bugs/bug219693-2-expected.checksum: Removed.
  • platform/chromium-linux/tables/mozilla/bugs/bug219693-2-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/bugs/bug26553-expected.checksum: Removed.
  • platform/chromium-linux/tables/mozilla/bugs/bug26553-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/bugs/bug50695-2-expected.checksum: Removed.
  • platform/chromium-linux/tables/mozilla/bugs/bug50695-2-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla/bugs/bug56201-expected.checksum: Removed.
  • platform/chromium-linux/tables/mozilla/bugs/bug56201-expected.png: Removed.
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug23847-expected.checksum: Removed.
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug23847-expected.png: Removed.
12:16 Changeset [67403] by enrica@apple.com

Paste should be implemented in WebCore like Copy and Cut for Mac also.
https://bugs.webkit.org/show_bug.cgi?id=45494
<rdar://problem/7660537>

WebCore:

Reviewed by Sam Weining.

On the Mac platform, the implementation of the paste operation is all done
at the WebKit level. In order to support it on WebKit2 it is necessary to
refactor the code and move this functionality at the level of WebCore like
we already have on Windows.
The original code relies on some in AppKit functions that call back into
WebKit causing problems in WebKit2. All this functionality has been moved
at the level of the editor client where it can be dealt with appropriately.

  • editing/Editor.cpp:

(WebCore::Editor::shouldInsertFragment):

  • editing/mac/EditorMac.mm: extended to support Mail specific scenarios.

(WebCore::Editor::pasteWithPasteboard):

  • loader/EmptyClients.h:

(WebCore::EmptyFrameLoaderClient::canShowMIMETypeAsHTML): Added.
(WebCore::EmptyEditorClient::documentFragmentFromAttributedString): Added.
(WebCore::EmptyEditorClient::setInsertionPasteboard): Added to support Mail.

  • loader/FrameLoaderClient.h:
  • page/EditorClient.h:
  • platform/Pasteboard.h:
  • platform/mac/PasteboardMac.mm:

(WebCore::Pasteboard::writeSelection): replaced call to Appkit with one that
doesn't calll back into WebKit.
(WebCore::Pasteboard::documentFragmentWithImageResource): Re-implemented at the
WebCore level.
(WebCore::Pasteboard::documentFragmentWithRtf): Re-implemented at the
WebCore level.
(WebCore::uniqueURLWithRelativePart): Added.
(WebCore::Pasteboard::documentFragment): Extended to include all the functionality
provided in documentFragmentFromPasteboard in WebHTMLView.mm.

WebKit/chromium:

Reviewed by Sam Weinig.

On the Mac platform, the implementation of the paste operation is all done
at the WebKit level. In order to support it on WebKit2 it is necessary to
refactor the code and move this functionality at the level of WebCore like
we already have on Windows.
The original code relies on some in AppKit functions that call back into
WebKit causing problems in WebKit2. All this functionality has been moved
at the level of the editor client where it can be dealt with appropriately.

  • src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::canShowMIMETypeAsHTML): Added stub.

  • src/FrameLoaderClientImpl.h:

WebKit/efl:

Reviewed by Sam Weinig.

On the Mac platform, the implementation of the paste operation is all done
at the WebKit level. In order to support it on WebKit2 it is necessary to
refactor the code and move this functionality at the level of WebCore like
we already have on Windows.
The original code relies on some in AppKit functions that call back into
WebKit causing problems in WebKit2. All this functionality has been moved
at the level of the editor client where it can be dealt with appropriately.

  • WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore::FrameLoaderClientEfl::canShowMIMETypeAsHTML): Added stub.

  • WebCoreSupport/FrameLoaderClientEfl.h:

WebKit/gtk:

Reviewed by Sam Weinig.

On the Mac platform, the implementation of the paste operation is all done
at the WebKit level. In order to support it on WebKit2 it is necessary to
refactor the code and move this functionality at the level of WebCore like
we already have on Windows.
The original code relies on some in AppKit functions that call back into
WebKit causing problems in WebKit2. All this functionality has been moved
at the level of the editor client where it can be dealt with appropriately.

  • WebCoreSupport/FrameLoaderClientGtk.cpp:

(WebKit::FrameLoaderClient::canShowMIMETypeAsHTML): Added stub.

  • WebCoreSupport/FrameLoaderClientGtk.h:

WebKit/haiku:

Reviewed by Sam Weinig.

On the Mac platform, the implementation of the paste operation is all done
at the WebKit level. In order to support it on WebKit2 it is necessary to
refactor the code and move this functionality at the level of WebCore like
we already have on Windows.
The original code relies on some in AppKit functions that call back into
WebKit causing problems in WebKit2. All this functionality has been moved
at the level of the editor client where it can be dealt with appropriately.

  • WebCoreSupport/FrameLoaderClientHaiku.cpp:

(WebCore::FrameLoaderClientHaiku::canShowMIMETypeAsHTML): Added stub.

  • WebCoreSupport/FrameLoaderClientHaiku.h:

WebKit/mac:

Reviewed by Sam Weinig.

On the Mac platform, the implementation of the paste operation is all done
at the WebKit level. In order to support it on WebKit2 it is necessary to
refactor the code and move this functionality at the level of WebCore like
we already have on Windows.
The original code relies on some in AppKit functions that call back into
WebKit causing problems in WebKit2. All this functionality has been moved
at the level of the editor client where it can be dealt with appropriately.

  • WebCoreSupport/WebEditorClient.h:
  • WebCoreSupport/WebEditorClient.mm:

(excludedElementsForAttributedStringConversion):
(WebEditorClient::documentFragmentFromAttributedString): Added.
(WebEditorClient::setInsertionPasteboard):

  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::canShowMIMETypeAsHTML): Re-implemented at the level
of the editor client.

  • WebView/WebHTMLView.mm: Removed paste method.

WebKit/qt:

Reviewed by Sam Weinig.

On the Mac platform, the implementation of the paste operation is all done
at the WebKit level. In order to support it on WebKit2 it is necessary to
refactor the code and move this functionality at the level of WebCore like
we already have on Windows.
The original code relies on some in AppKit functions that call back into
WebKit causing problems in WebKit2. All this functionality has been moved
at the level of the editor client where it can be dealt with appropriately.

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::canShowMIMETypeAsHTML): Added stub.

  • WebCoreSupport/FrameLoaderClientQt.h:

WebKit/win:

Reviewed by Sam Weinig.

On the Mac platform, the implementation of the paste operation is all done
at the WebKit level. In order to support it on WebKit2 it is necessary to
refactor the code and move this functionality at the level of WebCore like
we already have on Windows.
The original code relies on some in AppKit functions that call back into
WebKit causing problems in WebKit2. All this functionality has been moved
at the level of the editor client where it can be dealt with appropriately.

  • WebFrame.cpp:

(WebFrame::canShowMIMETypeASHTML): Added.

WebKit/wx:

Reviewed by Sam Weinig.

On the Mac platform, the implementation of the paste operation is all done
at the WebKit level. In order to support it on WebKit2 it is necessary to
refactor the code and move this functionality at the level of WebCore like
we already have on Windows.
The original code relies on some in AppKit functions that call back into
WebKit causing problems in WebKit2. All this functionality has been moved
at the level of the editor client where it can be dealt with appropriately.

  • WebKitSupport/FrameLoaderClientWx.cpp:

(WebCore::FrameLoaderClientWx::canShowMIMETypeAsHTML): Added stub.

  • WebKitSupport/FrameLoaderClientWx.h:

WebKit2:

Reviewed by Sam Weinig.

On the Mac platform, the implementation of the paste operation is all done
at the WebKit level. In order to support it on WebKit2 it is necessary to
refactor the code and move this functionality at the level of WebCore like
we already have on Windows.
The original code relies on some in AppKit functions that call back into
WebKit causing problems in WebKit2. All this functionality has been moved
at the level of the editor client where it can be dealt with appropriately.

  • WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::WebEditorClient::documentFragmentFromAttributedString): Added.
(WebKit::WebEditorClient::setInsertionPasteboard): Added.

  • WebProcess/WebCoreSupport/WebEditorClient.h:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::canShowMIMETypeAsHTML): Added.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
12:05 Changeset [67402] by alex@webkit.org

2010-09-13 Alejandro G. Castro <alex@igalia.com>

Reviewed by Kenneth Rohde Christiansen.

[Gtk] Reduce the size of the shadow buffer in the paths using the clip region
https://bugs.webkit.org/show_bug.cgi?id=44699

Intersect the clip bounding rect with the path that we are going
to use to create the shadow in order to reduce the region we have
to blur.

  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::drawPathShadow):
11:56 Changeset [67401] by darin@chromium.org

210-09-13 Darin Fisher <darin@chromium.org>

Reviewed by David Levin.

Add option to conditionally compile smooth scrolling support.
https://bugs.webkit.org/show_bug.cgi?id=45689

The OS(WINDOWS) conditional becomes unnecessary since
ENABLE(SMOOTH_SCROLLING) should only be specified on
platforms that have a smooth scrolling implementation.

  • platform/ScrollAnimator.cpp:
  • platform/ScrollAnimatorWin.cpp:
  • platform/ScrollAnimatorWin.h:
11:45 Changeset [67400] by agl@chromium.org

2010-09-13 Adam Langley <agl@chromium.org>

Unreviewed. Layout test re-baseline.

After r66882, complex text word spacing changed due to a bug fix. This
rebaselines the layout test for that case.

https://bugs.webkit.org/show_bug.cgi?id=45191

  • platform/chromium-linux/fast/text/atsui-spacing-features-expected.checksum:
  • platform/chromium-linux/fast/text/atsui-spacing-features-expected.png:
  • platform/chromium-linux/fast/text/atsui-spacing-features-expected.txt:
  • platform/chromium/test_expectations.txt:
11:41 Changeset [67399] by rniwa@webkit.org

2010-09-13 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Kent Tamura.

Move functions of StyledMarkupAccumulator below that of MarkupAccumulator
https://bugs.webkit.org/show_bug.cgi?id=45624

Moved the declaration of StyledMarkupAccumulator and the definitions of its member functions
to below the definitions of MarkupAccumulator's member functions.

No new tests are added since this is a cleanup.

  • editing/markup.cpp: (WebCore::StyledMarkupAccumulator::StyledMarkupAccumulator): (WebCore::StyledMarkupAccumulator::appendElement): (WebCore::StyledMarkupAccumulator::shouldAnnotate): (WebCore::StyledMarkupAccumulator::wrapWithNode): (WebCore::StyledMarkupAccumulator::wrapWithStyleNode): (WebCore::StyledMarkupAccumulator::takeResults): (WebCore::StyledMarkupAccumulator::appendText): (WebCore::StyledMarkupAccumulator::renderedText): (WebCore::StyledMarkupAccumulator::stringValueForRange): (WebCore::styleFromMatchedRulesForElement): (WebCore::StyledMarkupAccumulator::removeExteriorStyles): (WebCore::needInterchangeNewlineAfter): (WebCore::styleFromMatchedRulesAndInlineDecl): (WebCore::removeEnclosingMailBlockquoteStyle): (WebCore::removeDefaultStyles):
11:34 Changeset [67398] by alex@webkit.org

2010-09-13 Alejandro G. Castro <alex@igalia.com>

Reviewed by Martin Robinson.

[GTK] Leak in the GraphicsContextCairo drawPathShadow
https://bugs.webkit.org/show_bug.cgi?id=44959

Fix a leak of the cairo_path.

  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::drawPathShadow):
  • platform/graphics/cairo/OwnPtrCairo.cpp: (WTF::cairo_path_t):
  • platform/graphics/cairo/OwnPtrCairo.h:
11:28 WinCE edited by paroga@paroga.com
(diff)
11:25 Changeset [67397] by mrowe@apple.com

Build fix. Clear the executable bit on files that should not be executable.

11:15 WinCE edited by paroga@paroga.com
(diff)
10:40 Changeset [67396] by abarth@webkit.org

2010-09-13 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Fix </sarcasm>
https://bugs.webkit.org/show_bug.cgi?id=45645

Test that </sarcasm> works properly.

  • html5lib/resources/webkit02.dat:

2010-09-13 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Fix </sarcasm>
https://bugs.webkit.org/show_bug.cgi?id=45645

Umm... Yeah.

  • html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processEndTagForInBody):
10:21 Changeset [67395] by commit-queue@webkit.org

2010-09-13 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Darin Adler.

[WML] Fix build breaks when WML is enabled
https://bugs.webkit.org/show_bug.cgi?id=45628

There are build breaks by Bug 22382 when WML is enabled. The handleLinkClick() has an event parameter.
So, we need to set an event when wml invoke the handleLinkClick(). And, doTextFieldCommandFromEvent()
was moved to editor. So, we need to mofidy the invocation in WMLInputElement.cpp

  • wml/WMLAElement.cpp: (WebCore::WMLAElement::defaultEventHandler):
  • wml/WMLInputElement.cpp: (WebCore::WMLInputElement::defaultEventHandler):
10:00 Changeset [67394] by yurys@chromium.org

2010-09-13 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Rebaseline inspector/extensions-events.html

  • inspector/extensions-events-expected.txt:
09:32 Changeset [67393] by sullivan@apple.com

https://bugs.webkit.org/show_bug.cgi?id=45677
[WebView canMarkAllTextMatches] can crash if called after [WebView close]

Reviewed by Adam Roben.

<rdar://problem/8404890>

  • WebView/WebView.mm:

(-[WebView canMarkAllTextMatches]):
Return NO immediately if the webview has already been closed. This was an overlooked
case from the fix for 45175.

09:26 Changeset [67392] by mrobinson@webkit.org

2010-09-13 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] When a feature is disabled by default, the source necessary to build it are not included in the distribution
https://bugs.webkit.org/show_bug.cgi?id=45230

No new tests as this is just a build change.

  • GNUmakefile.am: Move as many sources as possible to the SOURCES primary. Others should be moved over time as we solve issues with them.
09:17 Changeset [67391] by ossy@webkit.org

2010-09-13 Csaba Osztrogonác <ossy@webkit.org>

Reviewed by Andreas Kling.

jscPath() is incorrect in Windows' cmd.exe shell
https://bugs.webkit.org/show_bug.cgi?id=45651

  • Scripts/webkitdirs.pm: Add ".exe" suffix to $jscName on Windows.
09:03 Changeset [67390] by cfleizach@apple.com

REGRESSION (r64816-r64889): Crash in WebCore::AccessibilityRenderObject
https://bugs.webkit.org/show_bug.cgi?id=43807

Reviewed by Darin Adler.

WebCore:

Ensure that visiblePositionForPoint can handle non RenderBoxModelObject types.

Test: platform/mac/accessibility/visible-position-crash-for-text-node.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::visiblePositionForPoint):

WebKitTools:

  • DumpRenderTree/AccessibilityUIElement.cpp:

(textMarkerForPointCallback):
(AccessibilityUIElement::textMarkerForPoint):
(AccessibilityUIElement::getJSClass):

  • DumpRenderTree/AccessibilityUIElement.h:
  • DumpRenderTree/mac/AccessibilityUIElementMac.mm:

(AccessibilityUIElement::textMarkerForPoint):

LayoutTests:

  • platform/mac/accessibility/visible-position-crash-for-text-node-expected.txt: Added.
  • platform/mac/accessibility/visible-position-crash-for-text-node.html: Added.
08:25 Changeset [67389] by mrobinson@webkit.org

2010-09-13 Martin Robinson <mrobinson@igalia.com>

Reviewed by Andreas Kling.

[Qt] DOM listeners get wrong keycodes for some keys
https://bugs.webkit.org/show_bug.cgi?id=43365

  • platform/qt/Skipped: Unskip tests that are now passing.

2010-09-13 Martin Robinson <mrobinson@igalia.com>

Reviewed by Andreas Kling.

[Qt] DOM listeners get wrong keycodes for some keys
https://bugs.webkit.org/show_bug.cgi?id=43365

Produce the proper keycodes for the print screen key as well as the
keypad insert and delete keys.

  • platform/qt/PlatformKeyboardEventQt.cpp: (WebCore::windowsKeyCodeForKeyEvent): Fix keycode translation for the mentioned keys.
08:13 Changeset [67388] by aroben@apple.com

Copy JavaScriptCore's generated sources to the right directory

07:20 Changeset [67387] by commit-queue@webkit.org

2010-09-13 Jonathan Dixon <joth@chromium.org>

Reviewed by Steve Block.

[chromium] Port test shell geolocation fixes to DRT
https://bugs.webkit.org/show_bug.cgi?id=45313

Remove exceptions for tests that now pass (in DRT and downstream test_shell)

  • platform/chromium/drt_expectations.txt:
  • platform/chromium/test_expectations.txt:

2010-09-13 Jonathan Dixon <joth@chromium.org>

Reviewed by Steve Block.

[chromium] Port test shell geolocation fixes to DRT
https://bugs.webkit.org/show_bug.cgi?id=45313

Also re-apply rolled out patch http://trac.webkit.org/changeset/66886 :-
Add missing virtual destructor to the abstract base class.

  • platform/chromium/GeolocationServiceChromium.cpp: (WebCore::GeolocationServiceBridge::~GeolocationServiceBridge):
  • platform/chromium/GeolocationServiceChromium.h:

2010-09-13 Jonathan Dixon <joth@chromium.org>

Reviewed by Steve Block.

[chromium] Port test shell geolocation fixes to DRT
https://bugs.webkit.org/show_bug.cgi?id=45313

Ports over fixes from test shell:

Resets state between service instances, which fixes delayed-permission-allowed-for-multiple-requests.html

Also re-apply rolled out patch http://trac.webkit.org/changeset/66886 :-
Access to out-of-scope WebGeolocationServiceBridgeImpl
https://bugs.webkit.org/show_bug.cgi?id=45112

Keep the WebGeolocationService pointer for lifetime of the bridge, to
ensure it can be detached reliably

Includes follow-up review comment to rename onWebGeolocationServiceDestroyed to didDestroyGeolocationService

  • public/WebGeolocationService.h: (WebKit::WebGeolocationService::~WebGeolocationService):
  • public/WebGeolocationServiceBridge.h: (WebKit::WebGeolocationServiceBridge::onWebGeolocationServiceDestroyed):
  • public/WebGeolocationServiceMock.h:
  • src/WebGeolocationServiceBridgeImpl.cpp: (WebKit::WebGeolocationServiceBridgeImpl::WebGeolocationServiceBridgeImpl): (WebKit::WebGeolocationServiceBridgeImpl::~WebGeolocationServiceBridgeImpl): (WebKit::WebGeolocationServiceBridgeImpl::startUpdating): (WebKit::WebGeolocationServiceBridgeImpl::stopUpdating): (WebKit::WebGeolocationServiceBridgeImpl::suspend): (WebKit::WebGeolocationServiceBridgeImpl::resume): (WebKit::WebGeolocationServiceBridgeImpl::attachBridgeIfNeeded): (WebKit::WebGeolocationServiceBridgeImpl::setIsAllowed): (WebKit::WebGeolocationServiceBridgeImpl::setLastPosition): (WebKit::WebGeolocationServiceBridgeImpl::setLastError): (WebKit::WebGeolocationServiceBridgeImpl::didDestroyGeolocationService): (WebKit::WebGeolocationServiceBridgeImpl::isAttached):
  • src/WebGeolocationServiceMock.cpp: (WebKit::WebGeolocationServiceMock::setMockGeolocationPermission): (WebKit::WebGeolocationServiceMockImpl::WebGeolocationServiceMockImpl): (WebKit::WebGeolocationServiceMockImpl::~WebGeolocationServiceMockImpl): (WebKit::WebGeolocationServiceMockImpl::setMockGeolocationPermission): (WebKit::WebGeolocationServiceMockImpl::requestPermissionForFrame): (WebKit::WebGeolocationServiceMockImpl::notifyPendingPermissions):
07:17 Changeset [67386] by yurys@chromium.org

2010-09-13 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Skip new debugger test on Qt.

  • platform/qt/Skipped:
06:39 Changeset [67385] by yurys@chromium.org

2010-09-13 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: upstream testExpandScope debugger test
https://bugs.webkit.org/show_bug.cgi?id=45260

Test that scope sections in Scripts panel are expandable and
contain correct data.

  • inspector/debugger-expand-scope-expected.txt: Added.
  • inspector/debugger-expand-scope.html: Added.
  • platform/chromium/inspector/debugger-expand-scope-expected.txt: Added.

2010-09-13 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: upstream testExpandScope debugger test
https://bugs.webkit.org/show_bug.cgi?id=45260

Test: inspector/debugger-expand-scope.html

  • inspector/front-end/InjectedScript.js: return "Arguments" as class name for arguments variable in v8. (injectedScriptConstructor.):

2010-09-13 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: upstream testExpandScope debugger test
https://bugs.webkit.org/show_bug.cgi?id=45260

  • src/js/DebuggerScript.js: copy scope variables into a new object, but for global scope object, with statement parameter and catch block exception variable pass the object itself to the injected script.
  • src/js/Tests.js: moved testExpandScope to LayoutTests
06:03 Changeset [67384] by caseq@chromium.org

2010-09-13 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

[Chromium] add viewport meta tag tests to expectations
https://bugs.webkit.org/show_bug.cgi?id=45655

  • platform/chromium/test_expectations.txt:
05:29 Changeset [67383] by commit-queue@webkit.org

2010-09-13 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Martin Robinson.

[GTK] ATs should be able to select/unselect text
https://bugs.webkit.org/show_bug.cgi?id=25673

Implement AtkText's setSelection and removeSelection functions

  • accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::visiblePositionRangeForRange): Moved some GTK specific code from a ifdef-endif region to AccessibilityObjectAtk.cpp
  • accessibility/AccessibilityObject.h:
  • accessibility/gtk/AccessibilityObjectAtk.cpp: (WebCore::AccessibilityObject::getLengthForTextRange): New.
  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_text_remove_selection): Implemented following the lead of GAIL's implementation of the AtkText interface. (webkit_accessible_text_set_selection): Implemented following the lead of GAIL's implementation of the AtkText interface. (webkit_accessible_text_set_caret_offset): Changed to directly use visiblePositionRangeForRange now that there's no longer a problem with that, as it was in the past (only worked for text controls).

2010-09-13 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Provide unit tests for AtkText's text selection functions
https://bugs.webkit.org/show_bug.cgi?id=43919

New tests to check getting, setting and removing text selections

  • tests/testatk.c: (testWekitAtkTextSelections): New unit tests to check all the text selection related functions altogether through a single test function. (main):

Make sure that code dependant on getting information from the
clipboard gets executed only when there's a GDK window associated
to the webview widget, as that's not the case when executing the
unit tests (the wedbview is not inside of any toplevel window) and
will make the tests crash if not taken into account.

  • WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::respondToChangedSelection):
05:09 Changeset [67382] by morrita@google.com

2010-09-13 MORITA Hajime <morrita@google.com>

Reviewed by Kent Tamura.

[Chromium][Test] custom-scrollbar-with-incomplete-style.html need expectation files.
https://bugs.webkit.org/show_bug.cgi?id=45646

Added missing expectations.

  • platform/chromium-linux/scrollbars/custom-scrollbar-with-incomplete-style-expected.checksum: Added.
  • platform/chromium-linux/scrollbars/custom-scrollbar-with-incomplete-style-expected.png: Added.
  • platform/chromium-linux/scrollbars/custom-scrollbar-with-incomplete-style-expected.txt: Added.
  • platform/chromium-mac/scrollbars/custom-scrollbar-with-incomplete-style-expected.checksum: Added.
  • platform/chromium-mac/scrollbars/custom-scrollbar-with-incomplete-style-expected.png: Added.
  • platform/chromium-mac/scrollbars/custom-scrollbar-with-incomplete-style-expected.txt: Added.
  • platform/chromium-win/scrollbars/custom-scrollbar-with-incomplete-style-expected.checksum: Added.
  • platform/chromium-win/scrollbars/custom-scrollbar-with-incomplete-style-expected.png: Added.
  • platform/chromium-win/scrollbars/custom-scrollbar-with-incomplete-style-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
05:06 Changeset [67381] by morrita@google.com

2010-09-13 MORITA Hajime <morrita@google.com>

Reviewed by Dirk Schulze.

[chromium] svg/filters/filter-empty-g.svg crashes in linux/mac debug after r63530
https://bugs.webkit.org/show_bug.cgi?id=42486

Removed skip line.
This looks fixed with a fix for http://webkit.org/b/41175.

  • platform/chromium/test_expectations.txt:
04:35 Changeset [67380] by andreas.kling@nokia.com

2010-09-13 Andreas Kling <andreas.kling@nokia.com>

Unreviewed.

[Qt] Skip three viewport meta tag tests that fail on the bot.

  • platform/qt/Skipped:
04:19 Changeset [67379] by andreas.kling@nokia.com

2010-09-13 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] build-webkit: Add --v8 option to build against V8

Note that V8 is picked up from QtScript, so this currently requires building
against the experimental qt-script-v8 branch.

  • Scripts/build-webkit:
04:05 Changeset [67378] by hans@chromium.org

2010-09-13 Hans Wennborg <hans@chromium.org>

Reviewed by Jeremy Orlow.

Add WebDeviceOrientationClientMock::create() and use it from DRT.
https://bugs.webkit.org/show_bug.cgi?id=45650

Since the virtual member functions of WebDeviceOrientationClientMock
are not exported from the DLL, construction of the object must be done inside
the DLL, or else the linker will complain (because the vtable cannot
be set up). Clients should use the create() member function, and the constructor
will be made private in a subsequent patch.

  • public/WebDeviceOrientationClientMock.h: (WebKit::WebDeviceOrientationClientMock::WebDeviceOrientationClientMock):
  • src/WebDeviceOrientationClientMock.cpp: (WebKit::WebDeviceOrientationClientMock::create):

2010-09-13 Hans Wennborg <hans@chromium.org>

Reviewed by Jeremy Orlow.

Add WebDeviceOrientationClientMock::create() and use it from DRT.
https://bugs.webkit.org/show_bug.cgi?id=45650

Do not use the WebDeviceOrientationClientMock constructor directly,
but use the create() member function.

This should fix the linker errors for the multi-DLL Chromium DRT build.

  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::setMockDeviceOrientation): (LayoutTestController::deviceOrientationClient):
03:58 Changeset [67377] by apavlov@chromium.org

2010-09-13 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

[Chromium] update test expectations for tests that pass after rolling out r67328
https://bugs.webkit.org/show_bug.cgi?id=45642

  • platform/chromium/test_expectations.txt:
03:37 Changeset [67376] by kenneth@webkit.org

WebCore: Update support for the viewport meta tag algorithm, to
match the following draft spec:

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2010-08-27
Reviewed by Antti Koivisto.

http://people.opera.com/rune/TR/ED-css-viewport-20100806/

Add common handling of viewport meta tag based on new Opera spec
https://bugs.webkit.org/show_bug.cgi?id=44201

Tests: fast/viewport/viewport-1.html

fast/viewport/viewport-10.html
fast/viewport/viewport-100.html
fast/viewport/viewport-101.html
fast/viewport/viewport-102.html
fast/viewport/viewport-103.html
fast/viewport/viewport-104.html
fast/viewport/viewport-105.html
fast/viewport/viewport-106.html
fast/viewport/viewport-107.html
fast/viewport/viewport-108.html
fast/viewport/viewport-109.html
fast/viewport/viewport-11.html
fast/viewport/viewport-110.html
fast/viewport/viewport-111.html
fast/viewport/viewport-112.html
fast/viewport/viewport-113.html
fast/viewport/viewport-114.html
fast/viewport/viewport-115.html
fast/viewport/viewport-116.html
fast/viewport/viewport-117.html
fast/viewport/viewport-118.html
fast/viewport/viewport-119.html
fast/viewport/viewport-12.html
fast/viewport/viewport-120.html
fast/viewport/viewport-121.html
fast/viewport/viewport-122.html
fast/viewport/viewport-123.html
fast/viewport/viewport-124.html
fast/viewport/viewport-125.html
fast/viewport/viewport-126.html
fast/viewport/viewport-127.html
fast/viewport/viewport-13.html
fast/viewport/viewport-14.html
fast/viewport/viewport-15.html
fast/viewport/viewport-16.html
fast/viewport/viewport-17.html
fast/viewport/viewport-18.html
fast/viewport/viewport-19.html
fast/viewport/viewport-2.html
fast/viewport/viewport-20.html
fast/viewport/viewport-21.html
fast/viewport/viewport-22.html
fast/viewport/viewport-23.html
fast/viewport/viewport-24.html
fast/viewport/viewport-25.html
fast/viewport/viewport-26.html
fast/viewport/viewport-27.html
fast/viewport/viewport-28.html
fast/viewport/viewport-29.html
fast/viewport/viewport-3.html
fast/viewport/viewport-30.html
fast/viewport/viewport-31.html
fast/viewport/viewport-32.html
fast/viewport/viewport-33.html
fast/viewport/viewport-34.html
fast/viewport/viewport-35.html
fast/viewport/viewport-36.html
fast/viewport/viewport-37.html
fast/viewport/viewport-38.html
fast/viewport/viewport-39.html
fast/viewport/viewport-4.html
fast/viewport/viewport-40.html
fast/viewport/viewport-41.html
fast/viewport/viewport-42.html
fast/viewport/viewport-43.html
fast/viewport/viewport-44.html
fast/viewport/viewport-45.html
fast/viewport/viewport-46.html
fast/viewport/viewport-47.html
fast/viewport/viewport-48.html
fast/viewport/viewport-49.html
fast/viewport/viewport-5.html
fast/viewport/viewport-50.html
fast/viewport/viewport-51.html
fast/viewport/viewport-52.html
fast/viewport/viewport-53.html
fast/viewport/viewport-54.html
fast/viewport/viewport-55.html
fast/viewport/viewport-56.html
fast/viewport/viewport-57.html
fast/viewport/viewport-58.html
fast/viewport/viewport-59.html
fast/viewport/viewport-6.html
fast/viewport/viewport-60.html
fast/viewport/viewport-61.html
fast/viewport/viewport-62.html
fast/viewport/viewport-63.html
fast/viewport/viewport-64.html
fast/viewport/viewport-65.html
fast/viewport/viewport-66.html
fast/viewport/viewport-67.html
fast/viewport/viewport-68.html
fast/viewport/viewport-69.html
fast/viewport/viewport-7.html
fast/viewport/viewport-70.html
fast/viewport/viewport-71.html
fast/viewport/viewport-72.html
fast/viewport/viewport-73.html
fast/viewport/viewport-74.html
fast/viewport/viewport-75.html
fast/viewport/viewport-76.html
fast/viewport/viewport-77.html
fast/viewport/viewport-78.html
fast/viewport/viewport-79.html
fast/viewport/viewport-8.html
fast/viewport/viewport-80.html
fast/viewport/viewport-81.html
fast/viewport/viewport-82.html
fast/viewport/viewport-83.html
fast/viewport/viewport-84.html
fast/viewport/viewport-85.html
fast/viewport/viewport-86.html
fast/viewport/viewport-87.html
fast/viewport/viewport-88.html
fast/viewport/viewport-9.html
fast/viewport/viewport-90.html

  • dom/ViewportArguments.cpp:

(WebCore::findConfigurationForViewportData):
(WebCore::findSizeValue):
(WebCore::findScaleValue):
(WebCore::findUserScalableValue):
(WebCore::findTargetDensityDPIValue):
(WebCore::setViewportFeature):

  • dom/ViewportArguments.h:

(WebCore::ViewportArguments::):
(WebCore::ViewportArguments::ViewportArguments):
(WebCore::ViewportArguments::hasCustomArgument):

WebKit/qt: Add a Qt API for the viewport meta tag support based on the
following draft spec:

Reviewed by Antti Koivisto.

http://people.opera.com/rune/TR/ED-css-viewport-20100806/

Add common handling of viewport meta tag based on new Opera spec
https://bugs.webkit.org/show_bug.cgi?id=44201

  • Api/qwebframe_p.h:

(QWebFramePrivate::QWebFramePrivate):

  • Api/qwebpage.cpp:

(QWebPage::ViewportConfiguration::ViewportConfiguration):
(QWebPage::ViewportConfiguration::~ViewportConfiguration):
(QWebPage::ViewportConfiguration::operator=):
(QWebPage::viewportConfigurationForSize):
(QWebPage::setPreferredContentsSize):

  • Api/qwebpage.h:
  • Api/qwebpage_p.h:

(QtViewportConfigurationPrivate::QtViewportConfigurationPrivate):

  • WebCoreSupport/ChromeClientQt.cpp:

(WebCore::ChromeClientQt::didReceiveViewportArguments):

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(DumpRenderTreeSupportQt::viewportAsText):

  • WebCoreSupport/DumpRenderTreeSupportQt.h:
  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::dispatchDidCommitLoad):
(WebCore::FrameLoaderClientQt::dispatchDidFirstLayout):

WebKitTools: Add support for testing the viewport meta tag algorithm,
based on the following draft spec:

Reviewed by Antti Koivisto.

http://people.opera.com/rune/TR/ED-css-viewport-20100806/

Add common handling of viewport meta tag based on new Opera spec
https://bugs.webkit.org/show_bug.cgi?id=44201

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:

(LayoutTestController::dumpConfigurationForViewport):

  • DumpRenderTree/qt/LayoutTestControllerQt.h:

LayoutTests: Add tests for the viewport meta tag algorithm and parsing,
based on a test suite developed by Opera employees
Rune Lillesveen and Øyvind Stenhaug.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2010-08-27
Reviewed by Antti Koivisto.

  • fast/viewport/viewport-1-expected.txt: Added.
  • fast/viewport/viewport-1.html: Added.
  • fast/viewport/viewport-10-expected.txt: Added.
  • fast/viewport/viewport-10.html: Added.
  • fast/viewport/viewport-100-expected.txt: Added.
  • fast/viewport/viewport-100.html: Added.
  • fast/viewport/viewport-101-expected.txt: Added.
  • fast/viewport/viewport-101.html: Added.
  • fast/viewport/viewport-102-expected.txt: Added.
  • fast/viewport/viewport-102.html: Added.
  • fast/viewport/viewport-103-expected.txt: Added.
  • fast/viewport/viewport-103.html: Added.
  • fast/viewport/viewport-104-expected.txt: Added.
  • fast/viewport/viewport-104.html: Added.
  • fast/viewport/viewport-105-expected.txt: Added.
  • fast/viewport/viewport-105.html: Added.
  • fast/viewport/viewport-106-expected.txt: Added.
  • fast/viewport/viewport-106.html: Added.
  • fast/viewport/viewport-107-expected.txt: Added.
  • fast/viewport/viewport-107.html: Added.
  • fast/viewport/viewport-108-expected.txt: Added.
  • fast/viewport/viewport-108.html: Added.
  • fast/viewport/viewport-109-expected.txt: Added.
  • fast/viewport/viewport-109.html: Added.
  • fast/viewport/viewport-11-expected.txt: Added.
  • fast/viewport/viewport-11.html: Added.
  • fast/viewport/viewport-110-expected.txt: Added.
  • fast/viewport/viewport-110.html: Added.
  • fast/viewport/viewport-111-expected.txt: Added.
  • fast/viewport/viewport-111.html: Added.
  • fast/viewport/viewport-112-expected.txt: Added.
  • fast/viewport/viewport-112.html: Added.
  • fast/viewport/viewport-113-expected.txt: Added.
  • fast/viewport/viewport-113.html: Added.
  • fast/viewport/viewport-114-expected.txt: Added.
  • fast/viewport/viewport-114.html: Added.
  • fast/viewport/viewport-115-expected.txt: Added.
  • fast/viewport/viewport-115.html: Added.
  • fast/viewport/viewport-116-expected.txt: Added.
  • fast/viewport/viewport-116.html: Added.
  • fast/viewport/viewport-117-expected.txt: Added.
  • fast/viewport/viewport-117.html: Added.
  • fast/viewport/viewport-118-expected.txt: Added.
  • fast/viewport/viewport-118.html: Added.
  • fast/viewport/viewport-119-expected.txt: Added.
  • fast/viewport/viewport-119.html: Added.
  • fast/viewport/viewport-12-expected.txt: Added.
  • fast/viewport/viewport-12.html: Added.
  • fast/viewport/viewport-120-expected.txt: Added.
  • fast/viewport/viewport-120.html: Added.
  • fast/viewport/viewport-121-expected.txt: Added.
  • fast/viewport/viewport-121.html: Added.
  • fast/viewport/viewport-122-expected.txt: Added.
  • fast/viewport/viewport-122.html: Added.
  • fast/viewport/viewport-123-expected.txt: Added.
  • fast/viewport/viewport-123.html: Added.
  • fast/viewport/viewport-124-expected.txt: Added.
  • fast/viewport/viewport-124.html: Added.
  • fast/viewport/viewport-125-expected.txt: Added.
  • fast/viewport/viewport-125.html: Added.
  • fast/viewport/viewport-126.html: Added.
  • fast/viewport/viewport-127.html: Added.
  • fast/viewport/viewport-13-expected.txt: Added.
  • fast/viewport/viewport-13.html: Added.
  • fast/viewport/viewport-14-expected.txt: Added.
  • fast/viewport/viewport-14.html: Added.
  • fast/viewport/viewport-15-expected.txt: Added.
  • fast/viewport/viewport-15.html: Added.
  • fast/viewport/viewport-16-expected.txt: Added.
  • fast/viewport/viewport-16.html: Added.
  • fast/viewport/viewport-17-expected.txt: Added.
  • fast/viewport/viewport-17.html: Added.
  • fast/viewport/viewport-18-expected.txt: Added.
  • fast/viewport/viewport-18.html: Added.
  • fast/viewport/viewport-19-expected.txt: Added.
  • fast/viewport/viewport-19.html: Added.
  • fast/viewport/viewport-2-expected.txt: Added.
  • fast/viewport/viewport-2.html: Added.
  • fast/viewport/viewport-20-expected.txt: Added.
  • fast/viewport/viewport-20.html: Added.
  • fast/viewport/viewport-21-expected.txt: Added.
  • fast/viewport/viewport-21.html: Added.
  • fast/viewport/viewport-22-expected.txt: Added.
  • fast/viewport/viewport-22.html: Added.
  • fast/viewport/viewport-23-expected.txt: Added.
  • fast/viewport/viewport-23.html: Added.
  • fast/viewport/viewport-24-expected.txt: Added.
  • fast/viewport/viewport-24.html: Added.
  • fast/viewport/viewport-25-expected.txt: Added.
  • fast/viewport/viewport-25.html: Added.
  • fast/viewport/viewport-26-expected.txt: Added.
  • fast/viewport/viewport-26.html: Added.
  • fast/viewport/viewport-27-expected.txt: Added.
  • fast/viewport/viewport-27.html: Added.
  • fast/viewport/viewport-28-expected.txt: Added.
  • fast/viewport/viewport-28.html: Added.
  • fast/viewport/viewport-29-expected.txt: Added.
  • fast/viewport/viewport-29.html: Added.
  • fast/viewport/viewport-3-expected.txt: Added.
  • fast/viewport/viewport-3.html: Added.
  • fast/viewport/viewport-30-expected.txt: Added.
  • fast/viewport/viewport-30.html: Added.
  • fast/viewport/viewport-31-expected.txt: Added.
  • fast/viewport/viewport-31.html: Added.
  • fast/viewport/viewport-32-expected.txt: Added.
  • fast/viewport/viewport-32.html: Added.
  • fast/viewport/viewport-33-expected.txt: Added.
  • fast/viewport/viewport-33.html: Added.
  • fast/viewport/viewport-34-expected.txt: Added.
  • fast/viewport/viewport-34.html: Added.
  • fast/viewport/viewport-35-expected.txt: Added.
  • fast/viewport/viewport-35.html: Added.
  • fast/viewport/viewport-36-expected.txt: Added.
  • fast/viewport/viewport-36.html: Added.
  • fast/viewport/viewport-37-expected.txt: Added.
  • fast/viewport/viewport-37.html: Added.
  • fast/viewport/viewport-38-expected.txt: Added.
  • fast/viewport/viewport-38.html: Added.
  • fast/viewport/viewport-39-expected.txt: Added.
  • fast/viewport/viewport-39.html: Added.
  • fast/viewport/viewport-4-expected.txt: Added.
  • fast/viewport/viewport-4.html: Added.
  • fast/viewport/viewport-40-expected.txt: Added.
  • fast/viewport/viewport-40.html: Added.
  • fast/viewport/viewport-41-expected.txt: Added.
  • fast/viewport/viewport-41.html: Added.
  • fast/viewport/viewport-42-expected.txt: Added.
  • fast/viewport/viewport-42.html: Added.
  • fast/viewport/viewport-43-expected.txt: Added.
  • fast/viewport/viewport-43.html: Added.
  • fast/viewport/viewport-44-expected.txt: Added.
  • fast/viewport/viewport-44.html: Added.
  • fast/viewport/viewport-45-expected.txt: Added.
  • fast/viewport/viewport-45.html: Added.
  • fast/viewport/viewport-46-expected.txt: Added.
  • fast/viewport/viewport-46.html: Added.
  • fast/viewport/viewport-47-expected.txt: Added.
  • fast/viewport/viewport-47.html: Added.
  • fast/viewport/viewport-48-expected.txt: Added.
  • fast/viewport/viewport-48.html: Added.
  • fast/viewport/viewport-49-expected.txt: Added.
  • fast/viewport/viewport-49.html: Added.
  • fast/viewport/viewport-5-expected.txt: Added.
  • fast/viewport/viewport-5.html: Added.
  • fast/viewport/viewport-50-expected.txt: Added.
  • fast/viewport/viewport-50.html: Added.
  • fast/viewport/viewport-51-expected.txt: Added.
  • fast/viewport/viewport-51.html: Added.
  • fast/viewport/viewport-52-expected.txt: Added.
  • fast/viewport/viewport-52.html: Added.
  • fast/viewport/viewport-53-expected.txt: Added.
  • fast/viewport/viewport-53.html: Added.
  • fast/viewport/viewport-54-expected.txt: Added.
  • fast/viewport/viewport-54.html: Added.
  • fast/viewport/viewport-55-expected.txt: Added.
  • fast/viewport/viewport-55.html: Added.
  • fast/viewport/viewport-56-expected.txt: Added.
  • fast/viewport/viewport-56.html: Added.
  • fast/viewport/viewport-57-expected.txt: Added.
  • fast/viewport/viewport-57.html: Added.
  • fast/viewport/viewport-58-expected.txt: Added.
  • fast/viewport/viewport-58.html: Added.
  • fast/viewport/viewport-59-expected.txt: Added.
  • fast/viewport/viewport-59.html: Added.
  • fast/viewport/viewport-6-expected.txt: Added.
  • fast/viewport/viewport-6.html: Added.
  • fast/viewport/viewport-60-expected.txt: Added.
  • fast/viewport/viewport-60.html: Added.
  • fast/viewport/viewport-61-expected.txt: Added.
  • fast/viewport/viewport-61.html: Added.
  • fast/viewport/viewport-62-expected.txt: Added.
  • fast/viewport/viewport-62.html: Added.
  • fast/viewport/viewport-63-expected.txt: Added.
  • fast/viewport/viewport-63.html: Added.
  • fast/viewport/viewport-64-expected.txt: Added.
  • fast/viewport/viewport-64.html: Added.
  • fast/viewport/viewport-65.html: Added.
  • fast/viewport/viewport-66-expected.txt: Added.
  • fast/viewport/viewport-66.html: Added.
  • fast/viewport/viewport-67-expected.txt: Added.
  • fast/viewport/viewport-67.html: Added.
  • fast/viewport/viewport-68-expected.txt: Added.
  • fast/viewport/viewport-68.html: Added.
  • fast/viewport/viewport-69-expected.txt: Added.
  • fast/viewport/viewport-69.html: Added.
  • fast/viewport/viewport-7-expected.txt: Added.
  • fast/viewport/viewport-7.html: Added.
  • fast/viewport/viewport-70-expected.txt: Added.
  • fast/viewport/viewport-70.html: Added.
  • fast/viewport/viewport-71-expected.txt: Added.
  • fast/viewport/viewport-71.html: Added.
  • fast/viewport/viewport-72-expected.txt: Added.
  • fast/viewport/viewport-72.html: Added.
  • fast/viewport/viewport-73-expected.txt: Added.
  • fast/viewport/viewport-73.html: Added.
  • fast/viewport/viewport-74-expected.txt: Added.
  • fast/viewport/viewport-74.html: Added.
  • fast/viewport/viewport-75-expected.txt: Added.
  • fast/viewport/viewport-75.html: Added.
  • fast/viewport/viewport-76-expected.txt: Added.
  • fast/viewport/viewport-76.html: Added.
  • fast/viewport/viewport-77-expected.txt: Added.
  • fast/viewport/viewport-77.html: Added.
  • fast/viewport/viewport-78-expected.txt: Added.
  • fast/viewport/viewport-78.html: Added.
  • fast/viewport/viewport-79-expected.txt: Added.
  • fast/viewport/viewport-79.html: Added.
  • fast/viewport/viewport-8-expected.txt: Added.
  • fast/viewport/viewport-8.html: Added.
  • fast/viewport/viewport-80-expected.txt: Added.
  • fast/viewport/viewport-80.html: Added.
  • fast/viewport/viewport-81-expected.txt: Added.
  • fast/viewport/viewport-81.html: Added.
  • fast/viewport/viewport-82.html: Added.
  • fast/viewport/viewport-83-expected.txt: Added.
  • fast/viewport/viewport-83.html: Added.
  • fast/viewport/viewport-84.html: Added.
  • fast/viewport/viewport-85-expected.txt: Added.
  • fast/viewport/viewport-85.html: Added.
  • fast/viewport/viewport-86-expected.txt: Added.
  • fast/viewport/viewport-86.html: Added.
  • fast/viewport/viewport-87.html: Added.
  • fast/viewport/viewport-88-expected.txt: Added.
  • fast/viewport/viewport-88.html: Added.
  • fast/viewport/viewport-9-expected.txt: Added.
  • fast/viewport/viewport-9.html: Added.
  • fast/viewport/viewport-90-expected.txt: Added.
  • fast/viewport/viewport-90.html: Added.
  • platform/gtk/Skipped: Skip tests due to missing DRT support.
  • platform/mac/Skipped: Skip tests due to missing DRT support.
  • platform/win/Skipped: Skip tests due to missing DRT support.
  • platform/qt/Skipped: Skip failing tests.
03:15 Changeset [67375] by andreas.kling@nokia.com

2010-09-13 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Don't add empty strings to list of supported image MIME types
https://bugs.webkit.org/show_bug.cgi?id=45643

After <http://trac.webkit.org/changeset/67355> getMIMETypeForExtension()
returns an empty string instead of "application/octet-stream" for unsupported
extensions. Don't add these to the list of supported types, and clean out
the logic that removed "application/octet-stream" from supported types.

Fixes crash in initializeMIMETypeRegistry() due to inserting String() into
a HashSet<String>.

  • platform/MIMETypeRegistry.cpp: (WebCore::initializeSupportedImageMIMETypes): (WebCore::initializeSupportedImageMIMETypesForEncoding):
03:12 Changeset [67374] by mjs@apple.com

2010-09-12 Maciej Stachowiak <mjs@apple.com>

Reviewed by Dan Bernstein.

Re-skip some layout tests that fail on the bots but not on my system
https://bugs.webkit.org/show_bug.cgi?id=45626

  • platform/mac-wk2/Skipped:
02:50 Changeset [67373] by abarth@webkit.org

2010-09-13 Adam Barth <abarth@webkit.org>

Attempted Qt build fix.

  • html/parser/HTMLElementStack.cpp:
02:19 Changeset [67372] by abarth@webkit.org

2010-09-13 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Apply spec changes to InForeignContentMode
https://bugs.webkit.org/show_bug.cgi?id=45636

Add some tests of breaking out of foreign content.

  • html5lib/resources/webkit01.dat:

2010-09-13 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Apply spec changes to InForeignContentMode
https://bugs.webkit.org/show_bug.cgi?id=45636

Now breaking out of foreign content doesn't always bring you back to
HTML. If you have a foreign content element that can contain HTML, you
just get brought back to that element.

  • html/parser/HTMLElementStack.cpp: (WebCore::HTMLNames::isForeignContentScopeMarker): (WebCore::HTMLElementStack::popUntilForeignContentScopeMarker):
  • html/parser/HTMLElementStack.h:
  • html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTag): (WebCore::HTMLTreeBuilder::processEndOfFile):
01:58 Changeset [67371] by commit-queue@webkit.org

2010-09-13 Kwang Yul Seo <skyul@company100.net>

Reviewed by Kent Tamura.

[BREWMP] Don't call _msize
https://bugs.webkit.org/show_bug.cgi?id=45556

Because Brew MP uses its own memory allocator, it is not correct to use
_msize in fastMallocSize. Add !PLATFORM(BREWMP) guard.

  • wtf/FastMalloc.cpp: (WTF::fastMallocSize):
01:39 Changeset [67370] by abarth@webkit.org

2010-09-13 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Convert notImplemented() to ASSERT_NOT_REACHED
https://bugs.webkit.org/show_bug.cgi?id=45639

The reason we never implemented this state is because it's not actually
reachable.

  • html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTag):
01:20 Changeset [67369] by commit-queue@webkit.org

2010-09-13 Patrick Gansterer <paroga@paroga.com>

Reviewed by Kenneth Rohde Christiansen.

[WINCE] Buildfix for ScrollAnimatorWin
https://bugs.webkit.org/show_bug.cgi?id=45595

Use fabs() instead of abs().

  • platform/ScrollAnimatorWin.cpp: (WebCore::ScrollAnimatorWin::scroll): (WebCore::ScrollAnimatorWin::animateScroll):
01:03 Changeset [67368] by commit-queue@webkit.org

2010-09-13 Patrick Gansterer <paroga@paroga.com>

Reviewed by Kenneth Rohde Christiansen.

Add FrameNetworkingContextWinCE
https://bugs.webkit.org/show_bug.cgi?id=45474

  • WebCoreSupport/FrameNetworkingContextWinCE.cpp: Added. (WebKit::FrameNetworkingContextWinCE::FrameNetworkingContextWinCE): (WebKit::FrameNetworkingContextWinCE::userAgent): (WebKit::FrameNetworkingContextWinCE::referrer):
  • WebCoreSupport/FrameNetworkingContextWinCE.h: Added. (WebKit::FrameNetworkingContextWinCE::create):
00:22 Changeset [67367] by abarth@webkit.org

2010-09-13 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Remove fixed FIXME
https://bugs.webkit.org/show_bug.cgi?id=45637

The spec made assertions that were false. Hixie fixed the spec by
removing the assertions. There's no need to keep these FIXMEs in the
code.

  • html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processEndTagForInCell):

09/12/10:

23:43 Changeset [67366] by abarth@webkit.org

2010-09-12 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Remove FIXME now that the HTML5 spec has been updated
https://bugs.webkit.org/show_bug.cgi?id=45634

Add tests recommended by Hixie.

  • fast/parser/form-pointer-1-expected.txt: Added.
  • fast/parser/form-pointer-1.html: Added.
  • fast/parser/form-pointer-2-expected.txt: Added.
  • fast/parser/form-pointer-2.html: Added.
  • fast/parser/form-pointer-3-expected.txt: Added.
  • fast/parser/form-pointer-3.html: Added.
  • fast/parser/form-pointer-4-expected.txt: Added.
  • fast/parser/form-pointer-4.html: Added.

2010-09-12 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Remove FIXME now that the HTML5 spec has been updated
https://bugs.webkit.org/show_bug.cgi?id=45634

The spec changed to say what we do here so this FIXME isn't needed
anymore.

Tests: fast/parser/form-pointer-1.html

fast/parser/form-pointer-2.html
fast/parser/form-pointer-3.html
fast/parser/form-pointer-4.html

  • html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTagForInTable):
23:24 Changeset [67365] by commit-queue@webkit.org

2010-09-12 Robin Qiu <robin.qiu@torchmobile.com.cn>

Reviewed by Antonio Gomes.

https://bugs.webkit.org/show_bug.cgi?id=18768
Fixed a bug in scroll flow. When we don't have scrollbars, we need to
repaintFixedElementsAfterScrolling(), sendScrollEvent() ... as well as
scrollContents();

  • scrollbars/resources/scrollable-iframe.html: Added.
  • scrollbars/scrollevent-iframe-no-scrolling-expected.txt: Added.
  • scrollbars/scrollevent-iframe-no-scrolling-wheel-expected.txt: Added.
  • scrollbars/scrollevent-iframe-no-scrolling-wheel.html: Added.
  • scrollbars/scrollevent-iframe-no-scrolling.html: Added.

2010-09-12 Robin Qiu <robin.qiu@torchmobile.com.cn>

Reviewed by Antonio Gomes.

https://bugs.webkit.org/show_bug.cgi?id=18768
Fixed a bug in scroll flow. When we don't have scrollbars, we need to
repaintFixedElementsAfterScrolling(), sendScrollEvent() ... as well as
scrollContents();

Tests: scrollbars/scrollevent-iframe-no-scrolling-wheel.html

scrollbars/scrollevent-iframe-no-scrolling.html

  • page/FrameView.cpp: (WebCore::FrameView::valueChanged): Added.
  • page/FrameView.h: Added a new method.
  • platform/ScrollView.cpp: (WebCore::ScrollView::valueChanged): Added. (WebCore::ScrollView::updateScrollbars):
  • platform/ScrollView.h: Added a new method.
22:45 Changeset [67364] by abarth@webkit.org

2010-09-12 Adam Barth <abarth@webkit.org>

Revert mistaken changes to test baselines.

  • platform/mac/http/tests/navigation/post-goback1-expected.txt:
  • platform/mac/http/tests/navigation/postredirect-basic-expected.txt:
  • platform/mac/http/tests/navigation/postredirect-frames-expected.txt:
  • platform/mac/http/tests/navigation/postredirect-goback1-expected.txt:
21:21 Changeset [67363] by tkent@chromium.org

2010-09-12 Kent Tamura <tkent@chromium.org>

Reviewed by Tony Chang.

[DRT/Chromium] Remove dependency to base/string16.h and gfx/codec/png_codec.h
https://bugs.webkit.org/show_bug.cgi?id=45517

  • DEPS: Roll Chromium revision to r59033 to have webkit_support_gfx.h.
  • WebKit.gyp:

2010-09-12 Kent Tamura <tkent@chromium.org>

Reviewed by Tony Chang.

[DRT/Chromium] Remove dependency to base/string16.h and gfx/codec/png_codec.h
https://bugs.webkit.org/show_bug.cgi?id=45517

Use webkit_support_gfx.h for PNG encoding/decoding instead of png_codec.h

  • DumpRenderTree/chromium/ImageDiff.cpp: (Image::craeteFromStdin): (Image::createFromFilename): (diffImages):
  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::dumpImage):
21:21 Changeset [67362] by morrita@google.com

2010-09-10 MORITA Hajime <morrita@google.com>

Reviewed by Tony Chang.

[Chromium] Implement textInputController.hasSpellingMarker() for Chromium
https://bugs.webkit.org/show_bug.cgi?id=45441

Add an note for API readiness.

  • platform/chromium/test_expectations.txt:

2010-09-10 MORITA Hajime <morrita@google.com>

Reviewed by Tony Chang.

[Chromium] Implement textInputController.hasSpellingMarker() for Chromium
https://bugs.webkit.org/show_bug.cgi?id=45441

Added an API for testing marker state.
We locate this here instead of DRT for sharing the logic between
multiple ports.

  • WebCore.exp.in:
  • editing/Editor.cpp: (WebCore::Editor::selectionStartHasSpellingMarkerFor):
  • editing/Editor.h:

2010-09-10 MORITA Hajime <morrita@google.com>

Reviewed by Tony Chang.

[Chromium] Implement textInputController.hasSpellingMarker() for Chromium
https://bugs.webkit.org/show_bug.cgi?id=45441

Exported Frame::selectionStartHasSpellingMarkerFor() for DRT use.

  • public/WebFrame.h:
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::selectionStartHasSpellingMarkerFor):
  • src/WebFrameImpl.h:

2010-09-10 MORITA Hajime <morrita@google.com>

Reviewed by Tony Chang.

[Chromium] Implement textInputController.hasSpellingMarker() for Chromium
https://bugs.webkit.org/show_bug.cgi?id=45441

Moved the actual logic of hasSpellingMarker into WebCore to share
it with other ports.

  • WebView/WebFrame.mm: (-[WebFrame hasSpellingMarker:length:]):

2010-09-10 MORITA Hajime <morrita@google.com>

Reviewed by Tony Chang.

[Chromium] Implement textInputController.hasSpellingMarker() for Chromium
https://bugs.webkit.org/show_bug.cgi?id=45441

Added TextInputController::hasSpellingMarker().

  • DumpRenderTree/chromium/TextInputController.cpp: (TextInputController::TextInputController): (TextInputController::hasSpellingMarker):
  • DumpRenderTree/chromium/TextInputController.h:
20:30 Changeset [67361] by dpranke@chromium.org

2010-09-12 Dirk Pranke <dpranke@chromium.org>

Unreviewed, expectations change.

Think this is the last set.

  • platform/chromium/test_expectations.txt:
20:19 Changeset [67360] by dpranke@chromium.org

2010-09-12 Dirk Pranke <dpranke@chromium.org>

Unreviewed, expectations change.

Suppress some more failures so I can triage the WebKit roll
without the tree being red.

  • platform/chromium/test_expectations.txt:
19:39 Changeset [67359] by dpranke@chromium.org

2010-09-12 Dirk Pranke <dpranke@chromium.org>

Unreviewed, expectations change. Suppress some failures so I can
triage the WebKit roll without the tree being red.

  • platform/chromium/test_expectations.txt:
18:09 Changeset [67358] by dpranke@chromium.org

2010-09-12 Dirk Pranke <dpranke@chromium.org>

Unreviewed, expectations change. Fix a duplicate expectation and
remove some passing tests.

  • platform/chromium/test_expectations.txt:
18:04 Changeset [67357] by abarth@webkit.org

2010-09-12 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Adoption agency should use takeAllChildrenFrom
https://bugs.webkit.org/show_bug.cgi?id=45570

Before this patch, we were using an unsafe pattern of walking the
sibling list without grabbing references. Instead, we should use the
shiny new takeAllChildrenFrom method that shoves the children into a
vector first. Also, update takeAllChildrenFrom to handle the case
where the old parent is attached.

  • dom/ContainerNode.cpp: (WebCore::ContainerNode::takeAllChildrenFrom):
  • html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::callTheAdoptionAgency):
  • html/parser/HTMLTreeBuilder.h:

2010-09-12 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Adoption agency should use takeAllChildrenFrom
https://bugs.webkit.org/show_bug.cgi?id=45570

More test cases.

  • html5lib/resources/webkit01.dat:
17:42 Changeset [67356] by abarth@webkit.org

2010-09-12 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

isParsingFragment assert hit in new treebuilder
https://bugs.webkit.org/show_bug.cgi?id=45621

Add new tests and (minor) test progression.

  • html5lib/resources/webkit01.dat:
  • html5lib/runner-expected.txt:

2010-09-12 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

isParsingFragment assert hit in new treebuilder
https://bugs.webkit.org/show_bug.cgi?id=45621

Update our list of special tags to match the spec.

  • html/parser/HTMLTreeBuilder.cpp:
17:19 Changeset [67355] by robert@webkit.org

2010-09-12 Robert Hogan <robert@webkit.org>

Reviewed by Andreas Kling.

[Qt] Fix http/tests/navigation/reload-subframe-object.html

Unskip http/tests/navigation/reload-subframe-object.html

https://bugs.webkit.org/show_bug.cgi?id=45613

  • platform/qt/Skipped:

2010-09-12 Robert Hogan <robert@webkit.org>

Reviewed by Andreas Kling.

[Qt] Fix http/tests/navigation/reload-subframe-object.html

We need to bring our use of getMimeTypeForPath() and
getMimeTypeForExtension() into line with WebCore expectations.

We should use MIMETypeRegistry::getMIMETypeForExtension() for cases
where an empty mimetype should be returned if no match is found, and
MIMETypeRegistry::getMIMETypeForPath() for cases where
'application/octet-stream' should be returned if no match is found.

Fixes http/tests/navigation/reload-subframe-object.html

Based on findings in webkit.org/b/31398 and webkit.org/b/15554.

https://bugs.webkit.org/show_bug.cgi?id=45613

  • platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
  • platform/qt/MIMETypeRegistryQt.cpp: (WebCore::MIMETypeRegistry::getMIMETypeForExtension):
17:02 Changeset [67354] by mjs@apple.com

2010-09-12 Maciej Stachowiak <mjs@apple.com>

Reviewed by James Robinson.

Remove some tests from the WebKit2 skipped list that are now passing
https://bugs.webkit.org/show_bug.cgi?id=45625

  • platform/mac-wk2/Skipped:
16:40 Changeset [67353] by dpranke@chromium.org

2010-09-12 Dirk Pranke <dpranke@chromium.org>

Unreviewed, expectations change.

  • platform/chromium/test_expectations.txt:
16:37 Changeset [67352] by dpranke@chromium.org

2010-09-12 Dirk Pranke <dpranke@chromium.org>

Unreviewed, build fix.

My last change accidentally contained a local change to the
rebaselinig script; webkit-patch land picked it up without telling
me and committed it :(

  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
16:34 Changeset [67351] by dpranke@chromium.org

2010-09-12 Dirk Pranke <dpranke@chromium.org>

Unreviewed, expectations change.

  • platform/chromium/test_expectations.txt:
16:04 Changeset [67350] by mitz@apple.com

Neglect unlikely hyphenation opportunities
https://bugs.webkit.org/show_bug.cgi?id=45606

Reviewed by Adele Peterson.

Avoid looking for hyphenation points in about 40% of the cases at the cost of missing about
3% of the hyphenation opportunities.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::tryHyphenating): Bail out if the widest the prefix before the hyphen can be is no more
than 5/4 the font size.

15:58 Changeset [67349] by jamesr@google.com

2010-09-12 James Robinson <jamesr@chromium.org>

Unreviewed, rolling out r67328.
http://trac.webkit.org/changeset/67328
https://bugs.webkit.org/show_bug.cgi?id=45610

Broke layout tests on mac and chromium.

  • http/tests/navigation/post-basic-expected.txt: Removed.
  • http/tests/navigation/post-basic.html:
  • http/tests/navigation/post-frames-expected.txt: Removed.
  • http/tests/navigation/post-frames.html:
  • http/tests/navigation/resources/page-that-posts.html: Removed.
  • http/tests/navigation/resources/postresult.pl:
  • platform/chromium-linux/http/tests/navigation/post-basic-expected.checksum: Added.
  • platform/chromium-linux/http/tests/navigation/post-basic-expected.png: Added.
  • platform/chromium-linux/http/tests/navigation/post-frames-expected.checksum: Added.
  • platform/chromium-linux/http/tests/navigation/post-frames-expected.png: Added.
  • platform/chromium-win/http/tests/navigation/post-basic-expected.checksum: Added.
  • platform/chromium-win/http/tests/navigation/post-basic-expected.png: Added.
  • platform/chromium-win/http/tests/navigation/post-basic-expected.txt: Added.
  • platform/chromium-win/http/tests/navigation/post-frames-expected.checksum: Added.
  • platform/chromium-win/http/tests/navigation/post-frames-expected.png: Added.
  • platform/chromium-win/http/tests/navigation/post-frames-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
  • platform/mac/http/tests/navigation/post-basic-expected.checksum: Copied from LayoutTests/platform/mac/http/tests/navigation/post-goback1-expected.checksum.
  • platform/mac/http/tests/navigation/post-basic-expected.png: Copied from LayoutTests/platform/mac/http/tests/navigation/post-goback1-expected.png.
  • platform/mac/http/tests/navigation/post-basic-expected.txt: Added.
  • platform/mac/http/tests/navigation/post-frames-expected.checksum: Added.
  • platform/mac/http/tests/navigation/post-frames-expected.png: Added.
  • platform/mac/http/tests/navigation/post-frames-expected.txt: Added.
14:19 Changeset [67348] by hausmann@webkit.org

doc: Changed the title so lists of contents sort better.

Patch by Martin Smith <martin.smith@nokia.com> on 2010-09-12
Reviewed by Simon Hausmann.

  • docs/qtwebkit.qdoc:
14:08 Changeset [67347] by hausmann@webkit.org

Doc: More work on the QML documentation.

Patch by David Boddie <david.boddie@nokia.com> on 2010-09-12
Reviewed by Simon Hausmann.

  • declarative/qdeclarativewebview.cpp:
13:58 Changeset [67346] by hausmann@webkit.org

[Qml] Ensure WebView gets focus when an editable node is clicked on.

Patch by Martin Jones <martin.jones@nokia.com> on 2010-09-12
Reviewed by Simon Hausmann.

Task-number: QTBUG-13342

  • declarative/qdeclarativewebview.cpp:

(GraphicsWebView::mousePressEvent):

13:56 Changeset [67345] by hausmann@webkit.org

Doc: qdoc fixes.

Patch by David Boddie <david.boddie@nokia.com> on 2010-09-12
Reviewed by Simon Hausmann.

  • declarative/qdeclarativewebview.cpp:
13:53 Changeset [67344] by hausmann@webkit.org

[Qt] fix qt_webkit_version.pri install for in-Qt builds

Patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2010-09-12
Reviewed by Simon Hausmann.

Always add the target, even if building inside Qt - as opposed to the
headers and libraries, there are no rules for that coming from
qbase.pri.

Task-number: QTBUG-13306

  • WebCore.pro:
13:50 Changeset [67343] by hausmann@webkit.org

WebCore: [Qt] Let QtWebKit inject itself into the qt configuration

Patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2010-09-12
Reviewed by Simon Hausmann.

i.e., don't explicitly deal with qt_webkit_version.pri outside of the
webkit source directory.

Task-number: QTBUG-12379

  • WebCore.pro:

WebKit/qt: [Qt] let WebKit inject itself into the qt configuration

Patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2010-09-12
Reviewed by Simon Hausmann.

Task-number: QTBUG-12379

  • qt_webkit_version.pri: Use the faster + instead of *

operator to add webkit to the config.

13:44 Changeset [67342] by hausmann@webkit.org

[Qt] Fix group of declarative web view in QML docs.

Patch by Martin Smith <martin.smith@nokia.com> on 2010-09-12
Reviewed by Simon Hausmann.

  • declarative/qdeclarativewebview.cpp:
12:08 Changeset [67341] by hausmann@webkit.org

[Qt] Rebase a bunch of tests after r67200.

Reviewed by Antonio Gomes.

  • platform/qt/svg/zoom/text/zoom-hixie-mixed-008-expected.txt:
  • platform/qt/svg/zoom/text/zoom-hixie-mixed-009-expected.txt:
  • platform/qt/svg/zoom/text/zoom-hixie-rendering-model-004-expected.txt:
  • platform/qt/svg/zoom/text/zoom-svg-float-border-padding-expected.txt:
11:40 Changeset [67340] by hausmann@webkit.org

[Qt] Build fix.

  • WebCore.pro: Re-add erroneously removed sources.
11:35 Changeset [67339] by andreas.kling@nokia.com

2010-09-12 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Remove Path::closeSubpath() workaround for broken miter joins
https://bugs.webkit.org/show_bug.cgi?id=45618

Removed Path::closeCanvasSubpath() and share the logic between Canvas and SVG
paths. The problem was actually in Qt's path stroker and has been fixed for Qt 4.7.1.

  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::closePath):
  • platform/graphics/Path.h:
  • platform/graphics/qt/PathQt.cpp:

2010-09-12 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Remove Path::closeSubpath() workaround for broken miter joins
https://bugs.webkit.org/show_bug.cgi?id=45618

Skip fast/canvas/canvas-closePath-single-point.html - it can be unskipped again
once the bot is upgraded to Qt 4.7.1.

  • platform/qt/Skipped:
11:32 Changeset [67338] by hausmann@webkit.org

Fix the Gtk and minimal builds.

  • plugins/PluginView.cpp:

(WebCore::PluginView::npObject): Correct the #ifdefs.
(WebCore::PluginView::bindingInstance): Moved npErr variable
into npObject() function where it is used.

11:28 Changeset [67337] by hausmann@webkit.org

[Qt] Prospective build fix for minimal build.

  • plugins/PluginView.cpp: Guard newly added function

by ENABLE_NETSCAPE_PLUGIN feature.
(WebCore::PluginView::npObject):

  • plugins/PluginView.h:
11:21 Changeset [67336] by hausmann@webkit.org

[Qt] Partial implementation of Qt bridge using V8 and QtScript.

Reviewed by Andreas Kling.

  • Api/qwebelement.cpp:

(QWebElement::evaluateJavaScript): Stub it out for now,
to compile, until we have a conversion path between v8::Object
and QScriptValue.

  • Api/qwebframe.cpp:

(QWebFrame::addToJavaScriptWindowObject): Implemented using
few lines of QtScript code.
(QWebFrame::evaluateJavaScript): Ditto.

11:19 Changeset [67335] by hausmann@webkit.org

[Qt] Add support for binding QtWebKit to a QScriptEngine.

Reviewed by Andreas Kling.

The ScriptController owns the V8 context, and this patch
for the Qt build also gives it a QScriptEngine, that has
been instructed to adopt the V8 context.

This is the enabler for the QObject bindings, used in
the API and DRT.

  • WebCore.pro:
  • bindings/v8/ScriptController.cpp: Include QScriptEngine

for the Qt build, to let the ~ScriptController destructor
find the QScriptEngine destructor (via OwnPtr).

  • bindings/v8/ScriptController.h: Declare getters.
  • bindings/v8/ScriptControllerQt.cpp: Added.

(WebCore::ScriptController::qtScriptEngine): Implement
engine adoption.

11:15 Changeset [67334] by hausmann@webkit.org

[Qt] Last bits and pieces for a V8 build.

Reviewed by Andreas Kling.

When building with V8, get it from QtScript.

  • WebCore.pro: Use QtScript, removed non-existant

bridge files from the build.

11:12 Changeset [67333] by hausmann@webkit.org

[Qt] Add PlatformBridge for V8 build.

Reviewed by Andreas Kling.

Add the minimalisting platform bridge with the two
methods needed by NPV8Object.cpp.

  • WebCore.pro:
  • platform/qt/PlatformBridge.h: Added.
  • platform/qt/PlatformBridgeQt.cpp: Added.

(WebCore::PlatformBridge::popupsAllowed):
(WebCore::PlatformBridge::pluginScriptableObject):

  • plugins/PluginView.cpp: Refactor the plugin object

retrieval code into a separate function, called by
bindingInstance() and PlatformBridge.
(WebCore::PluginView::npObject):
(WebCore::PluginView::bindingInstance):

  • plugins/PluginView.h:
11:08 Changeset [67332] by hausmann@webkit.org

Fix the build with V8.

Reviewed by Andreas Kling.

This is a temporary kludge until the scriptworld stuff is properly
ported, as part of the upcoming DRT work.

  • Api/qwebscriptworld.cpp:

(QWebScriptWorld::QWebScriptWorld):

11:08 Changeset [67331] by hausmann@webkit.org

Fix compilation of the V8 bindings on X11 with Qt.

Reviewed by Andreas Kling.

This changes brings the file in sync with its copy in bridge/,
adding additional conflicting X11 keywords to undef. This is
a temporary fix until the file is removed altogether, which is
tracked in https://bugs.webkit.org/show_bug.cgi?id=45617

  • bindings/v8/npruntime_internal.h:
10:38 Changeset [67330] by jer.noble@apple.com

2010-09-11 Jer Noble <jer.noble@apple.com>

Reviewed by Eric Carlson.

http/tests/media/text-served-as-text.html failing on Windows (Debug+Release)
https://bugs.webkit.org/show_bug.cgi?id=45603

Disable the eat/text components under Windows the same way as we do on the Mac.

  • platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
  • platform/graphics/win/QTMovie.cpp:
  • platform/graphics/win/QTMovie.h:
09:57 Changeset [67329] by hausmann@webkit.org

Fix compilation of the V8 bindings on X11 with Qt.

Reviewed by Andreas Kling.

These headers include npruntime, which drag on X11Resources.h, which
among other things #define's None and Boolean. Later on v8.h is included,
which declares these in enums and therefore conflicts. npruntime_internal.h
was introduced exactly to address this problem by including npruntime.h
and undeff'ing the offending constants.

  • bindings/v8/V8Helpers.h:
  • bindings/v8/V8NPObject.h:
  • bindings/v8/V8NPUtils.h:
08:11 Changeset [67328] by dglazkov@chromium.org

2010-09-12 Mihai Parparita <mihaip@chromium.org>

Reviewed by Dimitri Glazkov.

post-basic.html and post-frames.html in http/tests/navigation should not be pixel tests
https://bugs.webkit.org/show_bug.cgi?id=45610

post-basic.html and post-frames.html would be a lot simpler if
they weren't pixel tests (post-frames.html doesn't even have the right
expectations for Chromium/Mac). Since all they test is that form
POSTs are handled correctly, they can just use dumpAsText.

  • http/tests/navigation/post-basic-expected.txt: Added.
  • http/tests/navigation/post-basic.html:
  • http/tests/navigation/post-frames-expected.txt: Added.
  • http/tests/navigation/post-frames.html:
  • http/tests/navigation/resources/page-that-posts.html: Added.
  • http/tests/navigation/resources/postresult.pl:
  • platform/chromium-linux/http/tests/navigation/post-basic-expected.checksum: Removed.
  • platform/chromium-linux/http/tests/navigation/post-basic-expected.png: Removed.
  • platform/chromium-linux/http/tests/navigation/post-frames-expected.checksum: Removed.
  • platform/chromium-linux/http/tests/navigation/post-frames-expected.png: Removed.
  • platform/chromium-win/http/tests/navigation/post-basic-expected.checksum: Removed.
  • platform/chromium-win/http/tests/navigation/post-basic-expected.png: Removed.
  • platform/chromium-win/http/tests/navigation/post-basic-expected.txt: Removed.
  • platform/chromium-win/http/tests/navigation/post-frames-expected.checksum: Removed.
  • platform/chromium-win/http/tests/navigation/post-frames-expected.png: Removed.
  • platform/chromium-win/http/tests/navigation/post-frames-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
  • platform/mac/http/tests/navigation/post-basic-expected.checksum: Removed.
  • platform/mac/http/tests/navigation/post-basic-expected.png: Removed.
  • platform/mac/http/tests/navigation/post-basic-expected.txt: Removed.
  • platform/mac/http/tests/navigation/post-frames-expected.checksum: Removed.
  • platform/mac/http/tests/navigation/post-frames-expected.png: Removed.
  • platform/mac/http/tests/navigation/post-frames-expected.txt: Removed.
07:47 Changeset [67327] by hausmann@webkit.org

Gtk build fix.

Use false instead of False after
http://trac.webkit.org/changeset/67323

  • plugins/gtk/PluginViewGtk.cpp:

(WebCore::PluginView::updatePluginWidget):
(WebCore::PluginView::paint):

07:28 Changeset [67326] by hausmann@webkit.org

[Qt] Fix the compilation of V8Binding.cpp when compiling with Qt.

Reviewed by Andreas Kling.

  • bindings/v8/V8Binding.cpp:

(WebCore::WebCoreStringResource::WebCoreStringResource): In this
line an AtomicString should be converted to a WTF::String. The former
has a conversion operator to the latter, to be able to call the
WTF::String copy constructor. When compiling with Qt, then AtomicString
also has a conversion operator to QString _and_ WTF::String has an
implicit constructor that takes a QString. Therefore the compiler is
confused and not sure which conversion to prefer, the one that isn't
actually a conversion - going to WTF::String - or the conversion from
AtomicString to QString and then constructing the WTF::String from
a QString. To resolve this ambiguity we explicitly call the string()
helper function on the AtomicString, which is equivalent to the
operator WTF::String().

06:57 Changeset [67325] by hausmann@webkit.org

Fix the build without JSC.

Reviewed by Andreas Kling.

Complement http://trac.webkit.org/changeset/59826 and
add missing JSC guards.

  • plugins/PluginView.cpp:

(WebCore::PluginView::bindingInstance):
(WebCore::PluginView::privateBrowsingStateChanged):

  • plugins/qt/PluginViewQt.cpp:

(WebCore::PluginView::dispatchNPEvent):
(WebCore::PluginView::setNPWindowIfNeeded):
(WebCore::PluginView::platformStart):

06:57 Changeset [67324] by hausmann@webkit.org

Fix compilation with V8 and XPath enabled.

Reviewed by Andreas Kling.

V8XPathNSResolver.cpp includes V8XPathNSResolver.h,
which includes V8DOMWrapper.h as its first header.
V8DOMWrapper.h then uses V8XPathNSResolver in an inline
function, and gcc doesn't seem to like this, because
at this point the type isn't known ("V8XPathNSResolver
has not been declared"). Forward declaring the type
doesn't help unfortunately: "incomplete type
'WebCore::V8XPathNSResolver' used in nested name
specifier".

To resolve this circular dependency, this patch moves
the inline function into the .cpp file.

  • bindings/v8/V8DOMWrapper.cpp:

(WebCore::V8DOMWrapper::getXPathNSResolver):

  • bindings/v8/V8DOMWrapper.h:
06:33 Changeset [67323] by hausmann@webkit.org

[Qt][X11] Fix build with V8 against X11 headers.

Reviewed by Andreas Kling.

Added "True" and "False" to the list of words
we free from the X11 macro jail.

  • bridge/npruntime_internal.h:
  • config.h: The V8 bindings end up indirectly pulling

in X11 headers and they use True/False. There's no
central header apart from this one, so include the
x11 fixing header here for Qt/X11/V8.

  • plugins/qt/PluginViewQt.cpp:

(WebCore::PluginView::paint): Use false instead of False
since False isn't available anymore.

06:28 Changeset [67322] by hausmann@webkit.org

[Qt] Fix compilation with V8 and Qt.

Reviewed by Andreas Kling.

Use WebKit's page cache for ScriptCachedFrameData.

  • bindings/v8/ScriptCachedFrameData.h:
06:25 Changeset [67321] by hausmann@webkit.org

Fix compiler warning.

Reviewed by Andreas Kling.

NPClass has 13 members, the last one (NPConstructFunctionPtr construct) wasn't
initialized explicitly.

  • bindings/v8/NPV8Object.cpp:
04:16 Changeset [67320] by commit-queue@webkit.org

2010-09-12 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Martin Robinson.

[Gtk] get_n_selections and get_selection fail when selecting text across object boundaries
https://bugs.webkit.org/show_bug.cgi?id=26991

Fix AtkText getNSelections() and getSelection() to work properly

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (selectionBelongsToObject): Check that both the selection intersects the node AND that the selection is not just "touching" one of the boundaries for the selected node. We want to check whether the node is actually inside the region, at least partially (getSelectionOffsetsForObject): New function to get the start and end offsets of a selection for a given accessible object. (webkit_accessible_text_get_selection): Return zero when both start and end offsets are equal, following the lead of GAIL.
00:37 Changeset [67319] by mjs@apple.com

2010-09-11 Maciej Stachowiak <mjs@apple.com>

Reviewed by Adam Barth.

Animations don't seem to run in multiple WebKit2 animation tests
https://bugs.webkit.org/show_bug.cgi?id=42137

  • platform/mac-wk2/Skipped: These tests no longer fail, so simply unskip them.

09/11/10:

23:37 Changeset [67318] by dbates@webkit.org

2010-09-11 Daniel Bates <dbates@rim.com>

Attempt to fix the Qt Linux Release build after changeset 67312 <http://trac.webkit.org/changeset/67312>.

  • UIProcess/API/qt/qwkpage.cpp: (QWKPage::QWKPage): Add missing ',' in WKPageUIClient initialization list.
21:58 Changeset [67317] by mjs@apple.com

2010-09-11 Maciej Stachowiak <mjs@apple.com>

Reviewed by Anders Carlsson.

Attempt to fix Windows MiniBrowser build (untested)
https://bugs.webkit.org/show_bug.cgi?id=45609

  • MiniBrowser/win/BrowserView.cpp: (runJavaScriptConfirm): (runJavaScriptPrompt):
19:28 Changeset [67316] by abarth@webkit.org

2010-09-11 Adam Barth <abarth@webkit.org>

Reviewed by Sam Weinig.

Make SecurityOrigin::canDisplay an instance function
https://bugs.webkit.org/show_bug.cgi?id=45219

This function was secretly an instance function because callers needed
to pass in a document (which owns a SecurityOrigin). Only the
FrameLoader actually needs the method to be static.

  • WebCore.exp.in:
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::isSafeToLoadURL):
  • loader/Cache.cpp: (WebCore::Cache::requestResource):
    • Notice that DocLoader::doc() can never be 0.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::loadFrameRequest):
  • loader/PingLoader.cpp: (WebCore::PingLoader::loadImage):
  • loader/SubframeLoader.cpp: (WebCore::SubframeLoader::loadMediaPlayerProxyPlugin): (WebCore::SubframeLoader::createJavaAppletWidget): (WebCore::SubframeLoader::loadSubframe): (WebCore::SubframeLoader::loadPlugin):
  • loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::create):
  • page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::canDisplay): (WebCore::SecurityOrigin::deprecatedCanDisplay):
  • page/SecurityOrigin.h:
  • plugins/PluginView.cpp: (WebCore::PluginView::load):

2010-09-11 Adam Barth <abarth@webkit.org>

Reviewed by Sam Weinig.

Make SecurityOrigin::canDisplay an instance function
https://bugs.webkit.org/show_bug.cgi?id=45219

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::loadRequest):
  • Plugins/WebNetscapePluginStream.mm: (WebNetscapePluginStream::WebNetscapePluginStream):
  • Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
  • Plugins/WebPluginContainerCheck.mm: (-[WebPluginContainerCheck _isForbiddenFileLoad]):
  • WebView/WebFrame.mm: (-[WebFrame _allowsFollowingLink:]):

2010-09-11 Adam Barth <abarth@webkit.org>

Reviewed by Sam Weinig.

Make SecurityOrigin::canDisplay an instance function
https://bugs.webkit.org/show_bug.cgi?id=45219

  • WebFrame.cpp: (WebFrame::allowsFollowingLink):

2010-09-11 Adam Barth <abarth@webkit.org>

Reviewed by Sam Weinig.

Make SecurityOrigin::canDisplay an instance function
https://bugs.webkit.org/show_bug.cgi?id=45219

  • WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::performFrameLoadURLRequest):
19:17 Changeset [67315] by mjs@apple.com

2010-09-11 Maciej Stachowiak <mjs@apple.com>

Reviewed by Sam Weinig.

Remove nonexistent test from skipped list
https://bugs.webkit.org/show_bug.cgi?id=45608

  • platform/mac-wk2/Skipped:
19:15 Changeset [67314] by weinig@apple.com

Fix zoom related tests when testing WebKit2.

Reviewed by Maciej Stachowiak.

  • WebKitTestRunner/InjectedBundle/EventSendingController.cpp:

(WTR::EventSendingController::zoomPageIn): Zoom in and zoom out are not the same.

19:08 Changeset [67313] by mjs@apple.com

2010-09-11 Maciej Stachowiak <mjs@apple.com>

Reviewed by Sam Weinig.

Skip some new tests that depend on APIs missing from WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=45607

  • platform/mac-wk2/Skipped:
18:50 Changeset [67312] by weinig@apple.com

Implement WebKit2 callback equivalent to - [WebUIDelegate webView:setStatusText:]
<rdar://problem/8359252>
https://bugs.webkit.org/show_bug.cgi?id=45605

Reviewed by Dan Bernstein.

WebKit2:

  • Shared/CoreIPCSupport/WebPageProxyMessageKinds.h:
  • UIProcess/API/C/WKPage.h:
  • UIProcess/API/qt/qwkpage.cpp:

(QWKPage::QWKPage):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didReceiveMessage):
(WebKit::WebPageProxy::setStatusText):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebUIClient.cpp:

(WebKit::WebUIClient::setStatusText):

  • UIProcess/WebUIClient.h:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::setStatusbarText):

WebKitTools:

  • MiniBrowser/mac/BrowserWindowController.m:

(setStatusText):
(contentsSizeChanged):
(-[BrowserWindowController awakeFromNib]):

  • MiniBrowser/win/BrowserView.cpp:

(runJavaScriptConfirm):
(runJavaScriptPrompt):
(setStatusText):
(contentsSizeChanged):
(BrowserView::create):

  • WebKitTestRunner/TestController.cpp:

(WTR::createOtherPage):
(WTR::TestController::initialize):

18:17 Changeset [67311] by weinig@apple.com

Add callback mechanism for the getting the source of a frame
<rdar://problem/8364681>
https://bugs.webkit.org/show_bug.cgi?id=45604

Reviewed by Dan Bernstein.

WebKit2:

  • Shared/CoreIPCSupport/WebPageMessageKinds.h:
  • Shared/CoreIPCSupport/WebPageProxyMessageKinds.h:
  • UIProcess/API/C/WKPage.cpp:

(WKPageGetSourceForFrame):
(callGetSourceForFrameBlockBlockAndDispose):
(WKPageGetSourceForFrame_b):

  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::close):
(WebKit::WebPageProxy::getSourceForFrame):
(WebKit::WebPageProxy::didReceiveMessage):
(WebKit::WebPageProxy::didGetSourceForFrame):
(WebKit::WebPageProxy::processDidExit):

  • UIProcess/WebPageProxy.h:
  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::source):

  • WebProcess/WebPage/WebFrame.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::getSourceForFrame):
(WebKit::WebPage::didReceiveMessage):

  • WebProcess/WebPage/WebPage.h:

WebKitTools:

Add ability to dump the main frame's source to the console.

  • MiniBrowser/mac/BrowserWindowController.h:
  • MiniBrowser/mac/BrowserWindowController.m:

(-[BrowserWindowController dumpSourceToConsole:]):

  • MiniBrowser/mac/MainMenu.xib:
16:25 Changeset [67310] by eric@webkit.org

2010-09-11 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Remove unneeded Empty Queue messages
https://bugs.webkit.org/show_bug.cgi?id=45602

We already have a /gc job to delete these.
recentstatus.py is already smart enough to use the
most recent of the workitems last update or the most recent status,
so removing these should not change the _last_status_date() return
value more than a few milliseconds.

These messages just spam the recent status log.

  • Scripts/webkitpy/tool/commands/queues.py:
12:15 Changeset [67309] by hausmann@webkit.org

Unreviewed.

[Qt] Trivial V8 build fix.

  • WebCore.pri: Add storage, workers and css to the include paths for the

JS code generator.

11:28 Changeset [67308] by andreas.kling@nokia.com

2010-09-11 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Simon Hausmann.

[Qt] V8 port: Fix "WTF::String::utf8" returns incomplete type WTF::CString
https://bugs.webkit.org/show_bug.cgi?id=45157

Include CString.h where necessary. Chromium builds would get it from
KURLGooglePrivate.h so this is only an issue for Qt + V8.

  • bindings/v8/V8Proxy.cpp:
  • inspector/InspectorDebuggerAgent.cpp:
  • inspector/InspectorProfilerAgent.cpp:
  • plugins/PluginDatabase.cpp:
11:22 Changeset [67307] by hausmann@webkit.org

[Qt] V8 port: webkit project files changes
https://bugs.webkit.org/show_bug.cgi?id=45140

Reviewed by Andreas Kling.

.:

building with v8.

WebCore:

  • WebCore.pro: Removed unecessary common.pri inclusion from earlier patch.
11:11 Changeset [67306] by hausmann@webkit.org

JavaScriptCore: [Qt] V8 port: webcore project files changes
https://bugs.webkit.org/show_bug.cgi?id=45141

Reviewed by Andreas Kling.

so that they can also be used from WebCore.pro for v8 builds.

  • wtf/wtf.pri: Added.

WebCore: [Qt] V8 port: webcore project files changes
https://bugs.webkit.org/show_bug.cgi?id=45141

Reviewed by Andreas Kling.

Modify webcore project files to include V8 javascript engine. By default disabled.

  • WebCore.pri:
  • WebCore.pro:
  • features.pri:
11:09 Changeset [67305] by andreas.kling@nokia.com

2010-09-11 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Simon Hausmann.

Web Inspector: Include CString.h in generated files

This is necessary for generated code that uses the CString
returned by String::utf8() (from generateBackendDispatcher)

Chromium builds already get CString.h from KURLGooglePrivate.h
so this issue only occurs when building Qt against V8.

  • inspector/CodeGeneratorInspector.pm:
10:44 Changeset [67304] by andreas.kling@nokia.com

2010-09-11 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Simon Hausmann.

[Qt] V8 port for Qt platform: Qt WebCoreSupport changes
https://bugs.webkit.org/show_bug.cgi?id=45149

Original patch by Vlad Burlik <volodimir.burlik@nokia.com>

Implemented the V8 specifics needed in DumpRenderTreeSupportQt and
FrameLoaderClientQt.

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::javaScriptObjectsCount): (DumpRenderTreeSupportQt::garbageCollectorCollect): (DumpRenderTreeSupportQt::garbageCollectorCollectOnAlternateThread): (DumpRenderTreeSupportQt::evaluateScriptInIsolatedWorld):
  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::didCreateScriptContextForFrame): (WebCore::FrameLoaderClientQt::didDestroyScriptContextForFrame): (WebCore::FrameLoaderClientQt::didCreateIsolatedScriptContext): (WebCore::FrameLoaderClientQt::createDocumentLoader):
  • WebCoreSupport/FrameLoaderClientQt.h:
10:42 Changeset [67303] by mrobinson@webkit.org

2010-09-11 Martin Robinson <mrobinson@igalia.com>

Add a platform-specific result after r67281.

  • platform/gtk/fast/dynamic/first-letter-display-change-expected.txt: Added.
10:09 Changeset [67302] by commit-queue@webkit.org

2010-09-11 Mihai Parparita <mihaip@chromium.org>

Reviewed by Adam Barth.

Fix Python exception when generating synthetic patch IDs
https://bugs.webkit.org/show_bug.cgi?id=45592

Can't concatenate strings and numbers directly.

  • QueueStatusServer/handlers/queuestatus.py:
10:06 Changeset [67301] by andreas.kling@nokia.com

2010-09-11 Vlad Burlik <volodimir.burlik@nokia.com>

Reviewed by Andreas Kling.

[Qt] V8 port for QT platform: QT API implementation changes
https://bugs.webkit.org/show_bug.cgi?id=45148

V8 Implementation of QWebFrame::addToJavaScriptWindowObject()
and QWebFrame::evaluateJavaScript()

  • Api/qwebelement.cpp: (setupScriptContext): JSC and V8 variations (QWebElement::evaluateJavaScript):
  • Api/qwebelement.h:
  • Api/qwebframe.cpp: QObject injection to V8 world (QWebFrame::addToJavaScriptWindowObject): (QWebFrame::evaluateJavaScript):
  • Api/qwebpage.cpp: Use ScriptController type definitions instead of direct references to JSC or V8 (QWebPagePrivate::QWebPagePrivate):
09:25 Changeset [67300] by xan@webkit.org

2010-09-11 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Make introspection work with g-o-i 0.9.5
https://bugs.webkit.org/show_bug.cgi?id=45590

Bump required gobject-introspection version to 0.9.5.

  • configure.ac:

WebKit/gtk:

2010-09-11 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Make introspection work with g-o-i 0.9.5
https://bugs.webkit.org/show_bug.cgi?id=45590

Use new type syntax and bump version number of the gir file.

  • JSCore.gir.in:
09:19 Changeset [67299] by eric@webkit.org

2010-09-10 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

chromium fast/dom/replaceChild.html regression by r67182
https://bugs.webkit.org/show_bug.cgi?id=45527

Turns out this is a progression! Our new images
match minefield (and sanity). The old image had a
border drawn which should have been removed when the
iframe was replaced.

Other platforms may need to update their results as well.

  • platform/mac/fast/dom/replaceChild-expected.checksum:
  • platform/mac/fast/dom/replaceChild-expected.png:
09:09 Changeset [67298] by robert@webkit.org

2010-09-11 Robert Hogan <robert@webkit.org>

Unreviewed, unskip passing test.

Test fixed by http://trac.webkit.org/changeset/56511

See https://bugs.webkit.org/show_bug.cgi?id=36492

  • platform/qt/Skipped:
08:04 Changeset [67297] by commit-queue@webkit.org

2010-09-11 Ryuan Choi <ryuan.choi@samsung.com>

Reviewed by Antonio Gomes.

[EFL] Fix EFL build after r67274
https://bugs.webkit.org/show_bug.cgi?id=45584

Remove include of ZoomMode.h and change setZoomFactor and zoomFactor
to proper apis chaged by r67264.

  • ewk/ewk_frame.cpp: (ewk_frame_zoom_get): (ewk_frame_zoom_set): (ewk_frame_zoom_text_only_get): (ewk_frame_zoom_text_only_set):
06:20 Changeset [67296] by adele@apple.com

Fix for https://bugs.webkit.org/show_bug.cgi?id=45587
Move line clamp code to its own function.

Reviewed by Sam Weinig.

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutVerticalBox):
(WebCore::RenderFlexibleBox::applyLineClamp):

  • rendering/RenderFlexibleBox.h:
03:06 Changeset [67295] by commit-queue@webkit.org

2010-09-11 Mihai Parparita <mihaip@chromium.org>

Reviewed by Adam Barth.

Group statuses in queue status by patch ID
https://bugs.webkit.org/show_bug.cgi?id=45588

Group statuses by patch ID so that the status page is easier
to scan.

  • QueueStatusServer/handlers/queuestatus.py:
  • QueueStatusServer/stylesheets/dashboard.css: (.status-group): (.status-bug): (.status-group ul): (.status-group ul li): (.status-group ul li:hover): (.status-cell): (.status-cell:hover): (.status-cell.pass): (.status-cell.fail): (.status-cell.pending): (.status-cell.error):
  • QueueStatusServer/templates/dashboard.html:
  • QueueStatusServer/templates/queuestatus.html:
02:48 Changeset [67294] by commit-queue@webkit.org

2010-09-11 Mihai Parparita <mihaip@chromium.org>

Reviewed by Tony Chang.

Implement layoutTestController.dumpResourceResponseMIMETypes in Chromium DRT
https://bugs.webkit.org/show_bug.cgi?id=45479

Remove tests from Chromium expectations that now pass. Add
Chromium/Linux expectations for the script test, since it reports a
different MIME type (application/javascript vs.
application/x-javascript).

  • platform/chromium-linux/fast/dom/HTMLLinkElement/prefetch-expected.txt: Removed.
  • platform/chromium-linux/fast/preloader/script-expected.txt: Added.
  • platform/chromium-mac/fast/dom/HTMLLinkElement/prefetch-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:

2010-09-11 Mihai Parparita <mihaip@chromium.org>

Reviewed by Tony Chang.

Implement layoutTestController.dumpResourceResponseMIMETypes in Chromium DRT
https://bugs.webkit.org/show_bug.cgi?id=45479

Implement layoutTestController.dumpResourceResponseMIMETypes (modelled after
implementation in ResourceLoadDelegate in the Mac port).

  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::dumpResourceResponseMIMETypes): (LayoutTestController::reset):
  • DumpRenderTree/chromium/LayoutTestController.h: (LayoutTestController::setShouldDumpResourceResponseMIMETypes): (LayoutTestController::shouldDumpResourceResponseMIMETypes):
  • DumpRenderTree/chromium/TestShell.h: (TestShell::shouldDumpResourceResponseMIMETypes):
  • DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::didReceiveResponse):
02:32 Changeset [67293] by tony@chromium.org

2010-09-11 Tony Chang <tony@chromium.org>

Reviewed by Kent Tamura.

[chromium] remove passing test svg/custom/transform-ignore-after-invalid.svg
https://bugs.webkit.org/show_bug.cgi?id=45579

  • platform/chromium/test_expectations.txt:
01:59 Changeset [67292] by commit-queue@webkit.org

2010-09-11 Mihai Parparita <mihaip@chromium.org>

Reviewed by Adam Barth.

URIs in styles created via innerHTML are not resolved against the document's base URI
https://bugs.webkit.org/show_bug.cgi?id=45565

Add test to read back the background image URL from an element that was
created via innerHTML (reduction of http://crbug.com/55023).

  • fast/innerHTML/innerHTML-uri-resolution-expected.txt: Added.
  • fast/innerHTML/innerHTML-uri-resolution.html: Added.

2010-09-11 Mihai Parparita <mihaip@chromium.org>

Reviewed by Adam Barth.

URIs in styles created via innerHTML are not resolved against the document's base URI
https://bugs.webkit.org/show_bug.cgi?id=45565

The dummy document used for fragment parsing created by
FragmentParsingContext should use the base URI of the fragment's
document. Since (HTML)Document doesn't expose a setter for the base URI
(and shouldn't), we allow it to be set by the constructor/create
function.

Also remove some obsolete code that references the legacy tree builder
from HTMLElement that I happened to notice.

Test: fast/innerHTML/innerHTML-uri-resolution.html

  • dom/Document.cpp: (WebCore::Document::Document):
  • dom/Document.h:
  • html/HTMLDocument.cpp: (WebCore::HTMLDocument::HTMLDocument):
  • html/HTMLDocument.h: (WebCore::HTMLDocument::create):
  • html/HTMLElement.cpp: (WebCore::createFragmentFromSource): (WebCore::HTMLElement::setInnerHTML):
  • html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::FragmentParsingContext::FragmentParsingContext):
00:54 Changeset [67291] by diegohcg@webkit.org

Add NetworkingContext to avoid layer violations https://bugs.webkit.org/show_bug.cgi?id=42292

Patch by Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> on 2010-09-10
Reviewed by Darin Adler.

WebCore:

Activate NetworkingContext:

Since the ResourceHandle::create, ResourceHandle::start and
ResourceHandle::loadResourceSynchronously API's were modified,
having their Frame* parameter substituted by a NetworkingContext*,
all implementations of them were also modified.
This patch also modifies all functions that were calling the above
ones.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadResourceSynchronously):

  • loader/FrameLoader.h:
  • loader/MainResourceLoader.cpp:

(WebCore::MainResourceLoader::loadNow):

  • loader/PingLoader.cpp:

(WebCore::PingLoader::PingLoader):

  • loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::load):

  • loader/appcache/ApplicationCacheGroup.cpp:

(WebCore::ApplicationCacheGroup::createResourceHandle):

  • loader/icon/IconFetcher.cpp:

(WebCore::IconFetcher::loadEntry):

  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(webKitWebSrcStart):

  • platform/network/ResourceHandle.cpp:

(WebCore::ResourceHandle::create):

  • platform/network/ResourceHandle.h:
  • platform/network/ResourceHandleInternal.h:

(WebCore::ResourceHandleInternal::ResourceHandleInternal):

  • platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::loadResourceSynchronously):

  • platform/network/curl/ResourceHandleCurl.cpp:

(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::loadResourceSynchronously):

  • platform/network/mac/ResourceHandleMac.mm:

(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::loadResourceSynchronously):

  • platform/network/qt/QNetworkReplyHandler.cpp:

(WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
(WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
(WebCore::QNetworkReplyHandler::start):

  • platform/network/qt/ResourceHandleQt.cpp:

(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::willLoadFromCache):
(WebCore::ResourceHandle::loadResourceSynchronously):

  • platform/network/soup/ResourceHandleSoup.cpp:
  • platform/network/win/ResourceHandleWin.cpp:

(WebCore::ResourceHandle::start):

WebKit/chromium:

  • src/ResourceHandle.cpp:

(WebCore::ResourceHandle::create):
(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::loadResourceSynchronously):

WebKit/gtk:

  • webkit/webkitdownload.cpp:

(webkit_download_start):

  • webkit/webkitprivate.cpp:

(currentToplevelCallback):

WebKit/win:

  • WebCoreSupport/WebFrameNetworkingContext.cpp:

(WebFrameNetworkingContext::blockedError):

  • WebCoreSupport/WebFrameNetworkingContext.h:

WebKit2:

  • WebProcess/WebCoreSupport/win/WebFrameNetworkingContext.cpp:
  • WebProcess/WebCoreSupport/win/WebFrameNetworkingContext.h:

(WebFrameNetworkingContext::create):

00:23 Changeset [67290] by eric@webkit.org

2010-09-11 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

queues.webkit.org should expose /remote_api for data upload/download
https://bugs.webkit.org/show_bug.cgi?id=45559

  • QueueStatusServer/app.yaml:
    • /remote_api is a standard app-engine service which allows use of the bulk uploader for data upload/download. Exposing this (for admin access only) allows us to use
00:07 Changeset [67289] by commit-queue@webkit.org

2010-09-10 yi shen <yi.4.shen@nokia.com>

Reviewed by Antonio Gomes.

[Qt] selected text gets deleted when qgraphicswebview losts focus
https://bugs.webkit.org/show_bug.cgi?id=45539

  • Api/qwebpage.cpp: (QWebPagePrivate::inputMethodEvent):
  • tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::inputMethods):

09/10/10:

23:52 Changeset [67288] by jer.noble@apple.com

No review; build fix only.

<CoreGraphics/CGAffineTransform.h> isn't on the build bots either. Wrap
all references to m_movieTransform in #if USE(ACCELERATED_COMPOSITING) guards.

  • platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:

(WebCore::MediaPlayerPrivateQuickTimeVisualContext::MediaPlayerPrivateQuickTimeVisualContext):
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::naturalSize):
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::retrieveAndResetMovieTransform):

  • platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.h:
23:45 Changeset [67287] by weinig@apple.com

Add zoom support to WebKit2 API
<rdar://problem/7660657>
https://bugs.webkit.org/show_bug.cgi?id=45585

Reviewed by Dan Bernstein.

WebKit2:

  • Add UIProcess API for setting zoom factors.
  • Change bundle zoom API to be in terms of doubles for consistency.
  • Shared/CoreIPCSupport/WebPageMessageKinds.h:
  • UIProcess/API/C/WKPage.cpp:

(WKPageGetTextZoomFactor):
(WKPageSetTextZoomFactor):
(WKPageGetPageZoomFactor):
(WKPageSetPageZoomFactor):
(WKPageSetPageAndTextZoomFactors):

  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::setTextZoomFactor):
(WebKit::WebPageProxy::setPageZoomFactor):
(WebKit::WebPageProxy::setPageAndTextZoomFactors):

  • UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::textZoomFactor):
(WebKit::WebPageProxy::pageZoomFactor):

  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageGetTextZoomFactor):
(WKBundlePageSetTextZoomFactor):
(WKBundlePageGetPageZoomFactor):
(WKBundlePageSetPageZoomFactor):

  • WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::textZoomFactor):
(WebKit::WebPage::setTextZoomFactor):
(WebKit::WebPage::pageZoomFactor):
(WebKit::WebPage::setPageZoomFactor):
(WebKit::WebPage::setPageAndTextZoomFactors):
(WebKit::WebPage::didReceiveMessage):

  • WebProcess/WebPage/WebPage.h:

WebKitTools:

  • Add zoom options to MiniBrowser that mimic Safari's options using the new WebKit2 zoom APIs.
  • Switch uses of float for the zoom APIs to use double.
  • MiniBrowser/mac/BrowserWindowController.h:
  • MiniBrowser/mac/BrowserWindowController.m:

(-[BrowserWindowController initWithPageNamespace:]):
(-[BrowserWindowController validateMenuItem:]):
(-[BrowserWindowController validateUserInterfaceItem:]):
(-[BrowserWindowController currentZoomFactor]):
(-[BrowserWindowController setCurrentZoomFactor:]):
(-[BrowserWindowController canZoomIn]):
(-[BrowserWindowController zoomIn:]):
(-[BrowserWindowController canZoomOut]):
(-[BrowserWindowController zoomOut:]):
(-[BrowserWindowController canResetZoom]):
(-[BrowserWindowController resetZoom:]):
(-[BrowserWindowController toggleZoomMode:]):

  • MiniBrowser/mac/MainMenu.xib:
  • WebKitTestRunner/InjectedBundle/EventSendingController.cpp:

(WTR::EventSendingController::textZoomIn):
(WTR::EventSendingController::textZoomOut):
(WTR::EventSendingController::zoomPageIn):
(WTR::EventSendingController::zoomPageOut):

23:36 Changeset [67286] by jer.noble@apple.com

No review; build fix only.

<CoreGraphics/CGFloat.h> does not exist on the build bots. Replace
instances of CGFAbs() with abs().

  • platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:

(WebCore::MediaPlayerPrivateQuickTimeVisualContext::naturalSize):

23:24 Changeset [67285] by jer.noble@apple.com

2010-09-10 Jer Noble <jer.noble@apple.com>

Reviewed by Simon Fraser.

Movies with track or movie matrices don't display in <video> elements (Safari 5/Windows)
https://bugs.webkit.org/show_bug.cgi?id=45333


The rootChild layer must be set as flipped, otherwise transformed movies will appear
incorrectly rotated.

  • FullscreenVideoController.cpp: (FullscreenVideoController::enterFullscreen):

2010-09-10 Dan Bernstein <mitz@apple.com>

Reviewed by Darin Adler.

<rdar://problem/8414282> Can’t dynamically change first-letter to/from floating

Test: fast/dynamic/first-letter-display-change.html

  • rendering/RenderBlock.cpp: (WebCore::styleForFirstLetter): Factored this helper function out. (WebCore::RenderBlock::updateFirstLetter): Renamed variables so that the “update style” and “create new” branches use the same terminology. In the update case, if the style change requires a new renderer, handle it.
  • rendering/RenderTextFragment.h: (WebCore::toRenderTextFragment): Added.
23:19 Changeset [67284] by ap@apple.com

2010-09-10 Alexey Proskuryakov <ap@apple.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=45563
Assertion failure: useTransforms when scrolling to an SVG element

This has been indirectly fixed in r63633, just adding a test.

  • svg/custom/scroll-to-svg-element-assertion-expected.txt: Added.
  • svg/custom/scroll-to-svg-element-assertion.html: Added.
22:57 Changeset [67283] by weinig@apple.com

Fix chromium build.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setZoomLevel):

22:55 Changeset [67282] by robert@webkit.org

2010-09-10 Robert Hogan <robert@webkit.org>

Reviewed by Andreas Kling.

[Qt] Fix crash in DRT in standalone mode

https://bugs.webkit.org/show_bug.cgi?id=45454

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::loadNextTestInStandAloneMode):
22:55 Changeset [67281] by mitz@apple.com

<rdar://problem/8414282> Can’t dynamically change first-letter to/from floating

Reviewed by Darin Adler.

WebCore:

Test: fast/dynamic/first-letter-display-change.html

  • rendering/RenderBlock.cpp:

(WebCore::styleForFirstLetter): Factored this helper function out.
(WebCore::RenderBlock::updateFirstLetter): Renamed variables so that the
“update style” and “create new” branches use the same terminology. In the
update case, if the style change requires a new renderer, handle it.

  • rendering/RenderTextFragment.h:

(WebCore::toRenderTextFragment): Added.

LayoutTests:

  • fast/dynamic/first-letter-display-change-expected.checksum: Added.
  • fast/dynamic/first-letter-display-change-expected.png: Added.
  • fast/dynamic/first-letter-display-change-expected.txt: Added.
  • fast/dynamic/first-letter-display-change.html: Added.
22:50 Changeset [67280] by rniwa@webkit.org

2010-09-10 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed, speculative chromium build fix.

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::setZoomLevel):
22:31 Changeset [67279] by rniwa@webkit.org

2010-09-10 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed.

Added editing/style/style-3690704-fix.html to the gtk's skipped list
since the test requires editing delegates, which hasn't been implemented in gtk.

  • platform/gtk/Skipped:
22:21 Changeset [67278] by commit-queue@webkit.org

2010-09-10 Balazs Kelemen <kb@inf.u-szeged.hu>

Reviewed by Andreas Kling.

Application cache directory should be checked before sending to the web process
https://bugs.webkit.org/show_bug.cgi?id=45462

  • UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::WebProcessProxy): Check the return value of m_context->applicationCacheDirectoy() to avoid sending a null string to the web process what makes it asserting.
22:08 Changeset [67277] by rniwa@webkit.org

2010-09-10 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Tony Chang.

editing/inserting/insert-3659587-fix.html and editing/style/style-3690704-fix.html should use runDumpAsTextEditingTest
https://bugs.webkit.org/show_bug.cgi?id=45578

Modified insert-3659587-fix.html and style-3690704-fix.html to use runDumpAsTextEditingTest().

  • editing/inserting/insert-3659587-fix-expected.txt: Added.
  • editing/inserting/insert-3659587-fix.html:
  • editing/style/style-3690704-fix-expected.txt: Added.
  • editing/style/style-3690704-fix.html:
  • platform/chromium-linux/editing/inserting/insert-3659587-fix-expected.checksum: Removed.
  • platform/chromium-linux/editing/inserting/insert-3659587-fix-expected.png: Removed.
  • platform/chromium-linux/editing/style/style-3690704-fix-expected.checksum: Removed.
  • platform/chromium-linux/editing/style/style-3690704-fix-expected.png: Removed.
  • platform/chromium-win/editing/inserting/insert-3659587-fix-expected.checksum: Removed.
  • platform/chromium-win/editing/inserting/insert-3659587-fix-expected.png: Removed.
  • platform/chromium-win/editing/inserting/insert-3659587-fix-expected.txt: Removed.
  • platform/chromium-win/editing/style/style-3690704-fix-expected.checksum: Removed.
  • platform/chromium-win/editing/style/style-3690704-fix-expected.png: Removed.
  • platform/chromium-win/editing/style/style-3690704-fix-expected.txt: Removed.
  • platform/gtk/editing/inserting/insert-3659587-fix-expected.txt: Removed.
  • platform/gtk/editing/style/style-3690704-fix-expected.txt: Removed.
  • platform/mac/editing/inserting/insert-3659587-fix-expected.checksum: Removed.
  • platform/mac/editing/inserting/insert-3659587-fix-expected.png: Removed.
  • platform/mac/editing/inserting/insert-3659587-fix-expected.txt: Removed.
  • platform/mac/editing/style/style-3690704-fix-expected.checksum: Removed.
  • platform/mac/editing/style/style-3690704-fix-expected.png: Removed.
  • platform/mac/editing/style/style-3690704-fix-expected.txt: Removed.
  • platform/qt/editing/inserting/insert-3659587-fix-expected.txt: Removed.
  • platform/qt/editing/style/style-3690704-fix-expected.txt: Removed.
21:11 Changeset [67276] by weinig@apple.com

Fix Qt build.

  • Api/qwebsettings.cpp:

(QWebSettingsPrivate::apply):

21:09 Changeset [67275] by weinig@apple.com

Fix GTK build.

  • webkit/webkitwebview.cpp:

(webkit_web_view_set_full_content_zoom):

21:01 Changeset [67274] by weinig@apple.com

Remove unnecessary constraint in WebCore of choosing either text zoom or full page zoom.
Precursor to <rdar://problem/7660657>
https://bugs.webkit.org/show_bug.cgi?id=45522

Reviewed by Darin Adler.

WebCore:

  • GNUmakefile.am:
  • WebCore.exp.in:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:

Remove ZoomMode.h

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):
(WebCore::CSSStyleSelector::getComputedSizeFromSpecifiedSize):
Remove uses of shouldApplyTextZoom(), it had turned into just a compare to 1.0f.

  • html/HTMLBodyElement.cpp:

(WebCore::adjustForZoom):
(WebCore::HTMLBodyElement::setScrollLeft):
(WebCore::HTMLBodyElement::setScrollTop):
Convert these to use the explicit pageZoomFactor() function, it made no sense for text zoom
anyway.

  • page/Frame.h:

Remove include of ZoomMode.h

  • page/FrameView.cpp:

(WebCore::parentPageZoomFactor):
(WebCore::parentTextZoomFactor):
(WebCore::FrameView::FrameView):
(WebCore::FrameView::setPageZoomFactor):
(WebCore::FrameView::setTextZoomFactor):
(WebCore::FrameView::setPageAndTextZoomFactors):

  • page/FrameView.h:

(WebCore::FrameView::pageZoomFactor):
(WebCore::FrameView::textZoomFactor):
Change FrameView to store two values for zoom, one for page zoom and one for text zoom.

  • page/Settings.cpp:

(WebCore::Settings::Settings):

  • page/Settings.h:

Removed zoom mode.

  • page/ZoomMode.h: Removed.
  • rendering/RenderView.cpp:

(WebCore::RenderView::zoomFactor):
Remove now unnecessary call to shouldApplyPageZoom since it will be 1 if it should
be ignored.

  • svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::setCurrentScale):
Use explicit setPageZoomFactor function.

WebKit/chromium:

  • src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::createPlugin):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::setZoomLevel):

  • src/WebViewImpl.h:

(WebKit::WebViewImpl::zoomTextOnly):
Move tracking of text only zoom here from WebCore.

WebKit/gtk:

  • webkit/webkitwebview.cpp:

(webkit_web_view_get_zoom_level):
(webkit_web_view_apply_zoom_level):
(webkit_web_view_set_full_content_zoom):

WebKit/mac:

  • WebView/WebView.mm:

(-[WebView _preferencesChangedNotification:]):
(-[WebView _setZoomMultiplier:isTextOnly:]):
(-[WebView _realZoomMultiplierIsTextOnly]):

  • WebView/WebViewData.h:
  • WebView/WebViewData.mm:

(-[WebViewPrivate init]):
Move tracking of text only zoom here from WebCore.

WebKit/qt:

  • Api/qwebframe.cpp:

(QWebFrame::setTextSizeMultiplier):
(QWebFrame::textSizeMultiplier):
(QWebFrame::setZoomFactor):
(QWebFrame::zoomFactor):

  • Api/qwebframe_p.h:

(QWebFramePrivate::QWebFramePrivate):
Move tracking of text only zoom here from WebCore.

WebKit/win:

  • WebFrame.cpp:
  • WebFrame.h:

Remove dead code.

  • WebView.cpp:

(WebView::WebView):
(WebView::setZoomMultiplier):
(WebView::zoomMultiplier):
(WebView::canMakeTextLarger):
(WebView::makeTextLarger):
(WebView::canMakeTextSmaller):
(WebView::makeTextSmaller):
(WebView::notifyPreferencesChanged):

  • WebView.h:

Move tracking of text only zoom here from WebCore.

WebKit2:

Now that WebCore doesn't require a mode, change the bundle API for zoom to not
require one either.

  • WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:
  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageStopLoading):
(WKBundlePageGetTextZoomFactor):
(WKBundlePageSetTextZoomFactor):
(WKBundlePageGetPageZoomFactor):
(WKBundlePageSetPageZoomFactor):

  • WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):
(WebKit::WebPage::textZoomFactor):
(WebKit::WebPage::setTextZoomFactor):
(WebKit::WebPage::pageZoomFactor):
(WebKit::WebPage::setPageZoomFactor):

  • WebProcess/WebPage/WebPage.h:

WebKitTools:

Update for changes to the Bundle API to allow separate control of page and text zoom
levels.

  • WebKitTestRunner/InjectedBundle/EventSendingController.cpp:

(WTR::EventSendingController::textZoomIn):
(WTR::EventSendingController::textZoomOut):
(WTR::EventSendingController::zoomPageIn):
(WTR::EventSendingController::zoomPageOut):

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::reset):

20:59 Changeset [67273] by commit-queue@webkit.org

2010-09-10 Balazs Kelemen <kb@inf.u-szeged.hu>

Reviewed by Andreas Kling.

[Qt] Implement port specific part of WebKit::InjectedBundle
https://bugs.webkit.org/show_bug.cgi?id=45541

  • WebProcess/InjectedBundle/InjectedBundle.h: Typedef PlatformBundle as QLibrary for qt.
  • WebProcess/InjectedBundle/qt/InjectedBundleQt.cpp: (WebKit::InjectedBundle::load): Implemented.
20:42 Changeset [67272] by yael.aharon@nokia.com

2010-09-10 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Andreas Kling.

[Qt] Support click event for notifications
https://bugs.webkit.org/show_bug.cgi?id=44836

  • fast/notifications/notifications-click-event-expected.txt:
  • platform/qt/Skipped:

2010-09-10 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Andreas Kling.

[Qt] Support click event for notifications
https://bugs.webkit.org/show_bug.cgi?id=44836

Propagate click events to JavaScript from either the
platform plugn or from QSystemTrayIcon.
Also added the method NotificationWrapper::openerPageUrl so that
if the platform plugin can reopen the page that created the
notification directly, when the user clicks the notification.

Added DumpRenderTreeSupportQt::simulateDesktopNotificationClick
for testing purpose.

  • Api/qwebkitplatformplugin.h:
  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::simulateDesktopNotificationClick):
  • WebCoreSupport/DumpRenderTreeSupportQt.h:
  • WebCoreSupport/NotificationPresenterClientQt.cpp: (WebCore::NotificationWrapper::openerPageUrl): (WebCore::NotificationWrapper::notificationClicked): (WebCore::NotificationPresenterClientQt::displayNotification): (WebCore::NotificationPresenterClientQt::notificationClicked):
  • WebCoreSupport/NotificationPresenterClientQt.h:
  • examples/platformplugin/WebNotificationPresenter.cpp: (WebNotificationWidget::event):
  • examples/platformplugin/WebNotificationPresenter.h: (WebNotificationPresenter::WebNotificationPresenter):
  • examples/platformplugin/qwebkitplatformplugin.h:

2010-09-10 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Andreas Kling.

[Qt] Support click event for notifications
https://bugs.webkit.org/show_bug.cgi?id=44836

Add support for simulateDesktopNotificationClick by calling
back to DumpRenderTreeSupportQt.cpp.

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::simulateDesktopNotificationClick):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
20:25 Changeset [67271] by commit-queue@webkit.org

2010-09-10 Fridrich Strba <fridrich.strba@bluewin.ch>

Reviewed by Andreas Kling.

Add a define missing when building with glib unicode backend
https://bugs.webkit.org/show_bug.cgi?id=45544

  • wtf/unicode/glib/UnicodeMacrosFromICU.h:
19:47 Changeset [67270] by commit-queue@webkit.org

2010-09-10 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] Fix warnings because of bad assignments in testatk.c
https://bugs.webkit.org/show_bug.cgi?id=45538

Use AtkObject and AtkText instances properly in the code.

  • tests/testatk.c: (testWebkitAtkListsOfItems):
19:33 Changeset [67269] by abarth@webkit.org

2010-09-10 Mihai Parparita <mihaip@chromium.org>

Reviewed by Eric Seidel.

Update queue status when patches fail their first land attempt
https://bugs.webkit.org/show_bug.cgi?id=45583

Add a few more _update_status calls to make it more obvious if a patch is
being retried because tests failed.

  • Scripts/webkitpy/tool/commands/queues.py:
19:28 Changeset [67268] by abarth@webkit.org

2010-09-10 Adam Barth <abarth@webkit.org>

Attempt to fix the failign Qt tests. This patch adapts code from
Chromium. The long-term fix is to remove the need for this code, but
that's a bit too complicated for a buildfix patch.

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::FrameLoaderClientQt): (WebCore::FrameLoaderClientQt::makeRepresentation): (WebCore::FrameLoaderClientQt::revertToProvisionalState): (WebCore::FrameLoaderClientQt::finishedLoading):
  • WebCoreSupport/FrameLoaderClientQt.h:
19:27 Changeset [67267] by commit-queue@webkit.org

2010-09-10 Ryuan Choi <ryuan.choi@samsung.com>

Unreviewed build fix for EFL.

[EFL] REGRESSION(67167) build break because of newly added JSBindingState.cpp
https://bugs.webkit.org/show_bug.cgi?id=45537

  • CMakeLists.txt:
18:56 Changeset [67266] by commit-queue@webkit.org

2010-09-10 Balazs Kelemen <kb@inf.u-szeged.hu>

Reviewed by Andreas Kling.

[Qt] MiniBrowser crashes with multiply windows when closing one of them
https://bugs.webkit.org/show_bug.cgi?id=45536

  • UIProcess/API/qt/qwkpage.cpp: (QWKPage::~QWKPage): Do not call WKPageTerminate since this is designed to terminate the web process. We are correctly detaching the page without this call anyway.

2010-09-10 Balazs Kelemen <kb@inf.u-szeged.hu>

Reviewed by Andreas Kling.

[Qt] MiniBrowser crashes with multiply windows when closing one of them
https://bugs.webkit.org/show_bug.cgi?id=45536

  • MiniBrowser/qt/BrowserView.cpp: (BrowserView::BrowserView): Reference the context instead of adopting it because it can be shared across different views.
18:40 Changeset [67265] by slewis@apple.com

JavaScriptCore: Refactor JavaScriptCore memory statistics so that WebKit doesn't need to know
about the JIT and other implementation details of JavaScriptCore. Necessary
to fix PPC build.

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=45528

(JSC::memoryStatistics):

  • runtime/MemoryStatistics.h: Added.

WebKit/mac: Refactor JavaScriptCore memory statistics so that WebKit doesn't need to know about the JIT and
other implementation details of JavaScriptCore. Necessary to fix PPC build.

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=45528

  • Misc/WebCoreStatistics.mm:

(+[WebCoreStatistics memoryStatistics]):

18:28 Changeset [67264] by darin@apple.com

2010-09-10 Darin Adler <darin@apple.com>

Reviewed by Sam Weinig.

Move some Dashboard stuff from WebCore to WebKit along with a bit more FrameMac cleanup
https://bugs.webkit.org/show_bug.cgi?id=45582

  • WebKit.xcodeproj/project.pbxproj: Added WebDashboardRegion.h/mm and also gave the header private visibility so it will get installed in the PrivateHeaders directory.

2010-09-10 Darin Adler <darin@apple.com>

Reviewed by Sam Weinig.

Move some Dashboard stuff from WebCore to WebKit along with a bit more FrameMac cleanup
https://bugs.webkit.org/show_bug.cgi?id=45582

  • MigrateHeaders.make: Removed WebDashboardRegion.h from the set of header to copy.
  • WebCoreSupport/WebChromeClient.mm: (WebChromeClient::dashboardRegionsChanged): Changed this to call -[WebView _dashboardRegions] so we don't have two copies of that code.
  • WebView/WebDashboardRegion.h: Copied from WebCore/page/mac/WebDashboardRegion.h.
  • WebView/WebDashboardRegion.mm: Copied from WebCore/page/mac/WebDashboardRegion.m.
  • WebView/WebView.mm: (-[WebView _dashboardRegions]): Moved the code from Frame::dashboardRegions here.

2010-09-10 Darin Adler <darin@apple.com>

Reviewed by Sam Weinig.

Move some Dashboard stuff from WebCore to WebKit along with a bit more FrameMac cleanup
https://bugs.webkit.org/show_bug.cgi?id=45582

  • WebCore.exp.in: Updated.
  • WebCore.xcodeproj/project.pbxproj: Removed WebDashboardRegion.h/m.
  • page/mac/WebDashboardRegion.h: Removed.
  • page/mac/WebDashboardRegion.m: Removed.
  • page/Frame.h: Removed unneeded #if. Removed dashboardRegionsDictionary function, now handled in WebKit. Removed searchForNSLabelsAboveCell function, which had become dead code.
  • page/mac/FrameMac.mm: Ditto. Also tweaked a place that said "int unsigned".
18:27 Changeset [67263] by pkasting@chromium.org

Merge 67261 - Make middle clicks not fire DOM onclick events.
https://bugs.webkit.org/show_bug.cgi?id=22382

Reviewed by Darin Adler.

WebCore:

  • html/HTMLAnchorElement.cpp: Explicitly include middle-clicks in the

computation of what constitutes a link click, since they're no longer
implicitly included.
(WebCore::isLinkClick):

  • html/HTMLInputElement.cpp: Removed unneeded checks that click events

are coming from the left mouse button, since they all are now.
(WebCore::HTMLInputElement::preDispatchEventHandler):
(WebCore::HTMLInputElement::postDispatchEventHandler):
(WebCore::HTMLInputElement::defaultEventHandler):

  • page/EventHandler.cpp: Changed logic to send a click event only for

the left button.
(WebCore::EventHandler::handleMouseDoubleClickEvent):
(WebCore::EventHandler::handleMouseReleaseEvent):

LayoutTests:

  • fast/events/mouse-click-events-expected.txt:
  • fast/events/script-tests/mouse-click-events.js:

TBR=pkasting@chromium.org
Review URL: http://codereview.chromium.org/3325025

18:24 Changeset [67262] by pkasting@chromium.org

Merge 67246 - 2010-09-109 Peter Kasting <pkasting@google.com>

Reviewed by Darin Adler.

Cleanup and simplification in advance of making middle clicks not send a
click event.
https://bugs.webkit.org/show_bug.cgi?id=22382

  • editing/DeleteButton.cpp:

(WebCore::DeleteButton::defaultEventHandler): Removed unneeded code to
check if the event is a MouseEvent. Any click event will do.

  • html/HTMLAnchorElement.cpp:

(WebCore::appendServerMapMousePosition): Added. Factors out the
modifications to the URL to add the mouse position to make the default
event handler function easier to read.
(WebCore::HTMLAnchorElement::defaultEventHandler): Reorganized to make
the enter key logic separate from the link clicking logic and simplify
the function. This makes minor functional changes like not calling
FrameLoader::urlSelected() for fake "keydown" events constructed from
JavaScript.
(WebCore::HTMLAnchorElement::isLiveLink): Refactored to use new shared
implementation in treatLinkAsLiveForEventType().
(WebCore::eventType): Factors out event type calculation (for
treatLinkAsLiveForEventType()) from the default event handler to make it
easier to read.
(WebCore::HTMLAnchorElement::treatLinkAsLiveForEventType):
Implementation of the portions of isLiveLink() that are common with the
checks defaultEventHandler() wants to do.
(WebCore::isEnterKeyKeydownEvent): Added. Shared by the default
event handlers for all three anchor elements.
(WebCore::isMiddleMouseButtonEvent): Added. Shared by the isLinkClick
function below and some code in SVG. Later we can make this private to
this source file once we remove the unneeded SVG code.
(WebCore::isLinkClick): Added. Shared by the default event handlers for
all three anchor elements.
(WebCore::handleLinkClick): Ditto.

  • html/HTMLAnchorElement.h: Added the new functions.
  • svg/SVGAElement.cpp:

(WebCore::SVGAElement::defaultEventHandler): Removed lots of unneeded
logic and streamlined the code to more closely match the
HTMLAnchorElement code and share functions with it.

  • wml/WMLAElement.cpp:

(WebCore::WMLAElement::defaultEventHandler): Ditto.

TBR=pkasting@chromium.org
Review URL: http://codereview.chromium.org/3366025

18:16 Changeset [67261] by pkasting@chromium.org

Make middle clicks not fire DOM onclick events.
https://bugs.webkit.org/show_bug.cgi?id=22382

Reviewed by Darin Adler.

WebCore:

  • html/HTMLAnchorElement.cpp: Explicitly include middle-clicks in the

computation of what constitutes a link click, since they're no longer
implicitly included.
(WebCore::isLinkClick):

  • html/HTMLInputElement.cpp: Removed unneeded checks that click events

are coming from the left mouse button, since they all are now.
(WebCore::HTMLInputElement::preDispatchEventHandler):
(WebCore::HTMLInputElement::postDispatchEventHandler):
(WebCore::HTMLInputElement::defaultEventHandler):

  • page/EventHandler.cpp: Changed logic to send a click event only for

the left button.
(WebCore::EventHandler::handleMouseDoubleClickEvent):
(WebCore::EventHandler::handleMouseReleaseEvent):

LayoutTests:

  • fast/events/mouse-click-events-expected.txt:
  • fast/events/script-tests/mouse-click-events.js:
18:07 Changeset [67260] by bweinstein@apple.com

Windows Build Fix. Fix some fallout from r67238, currentForm is now off of
SelectionController instead of frame. Also fix a style issue.

  • WebFrame.cpp:

(WebFrame::currentForm):

18:03 Changeset [67259] by crogers@google.com

audio branch: lots of cleanup for moving to trunk

  • Biquad
  • ArrayBufferView, TypedArrayBase, AudioBuffer
  • Lots of general cleanup in AudioNode, AudioNodeInput, AudioNodeOutput, AudioContext
  • AudioSourceNode
18:03 Changeset [67258] by crogers@google.com

audio branch: cleanup of HRTF-related files

18:03 Changeset [67257] by abarth@webkit.org

2010-09-10 Adam Barth <abarth@webkit.org>

Attempted build fix for Qt Minimal.

  • dom/Element.cpp: (WebCore::Element::getBoundingClientRect):
17:58 Changeset [67256] by dpranke@chromium.org

2010-09-10 Dirk Pranke <dpranke@chromium.org>

Unreviewed, expectations change.

Need to rebaseline a bunch of files resulting from the SVG change
in r67200.

https://bugs.webkit.org/show_bug.cgi?id=45580

  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-40-t-expected.txt
  • platform/chromium-win/svg/W3C-SVG-1.1/text-text-04-t-expected.txt
  • platform/chromium-win/svg/W3C-SVG-1.1/text-text-05-t-expected.txt
  • platform/chromium-win/svg/W3C-SVG-1.1/text-text-06-t-expected.txt
  • platform/chromium-win/svg/W3C-SVG-1.1/text-text-07-t-expected.txt
  • platform/chromium-win/svg/W3C-SVG-1.1/text-tspan-01-b-expected.txt
  • platform/chromium-win/svg/batik/text/textAnchor2-expected.txt
  • platform/chromium-win/svg/batik/text/textAnchor3-expected.txt
  • platform/chromium-win/svg/batik/text/textLayout-expected.txt
  • platform/chromium-win/svg/batik/text/textLayout2-expected.txt
  • platform/chromium-win/svg/batik/text/textOnPathSpaces-expected.txt
  • platform/chromium-win/svg/batik/text/textPosition-expected.txt
  • platform/chromium-win/svg/batik/text/textPosition2-expected.txt
  • platform/chromium-win/svg/custom/text-letter-spacing-expected.txt
  • platform/chromium-win/svg/custom/text-x-dx-lists-expected.txt
  • platform/chromium-win/svg/custom/text-x-override-in-tspan-child-expected.txt
  • platform/chromium-win/svg/text/select-x-list-1-expected.txt
  • platform/chromium-win/svg/text/select-x-list-2-expected.txt
  • platform/chromium-win/svg/text/select-x-list-3-expected.txt
  • platform/chromium-win/svg/text/select-x-list-4-expected.txt
  • platform/chromium-win/svg/text/select-x-list-with-tspans-1-expected.txt
  • platform/chromium-win/svg/text/select-x-list-with-tspans-2-expected.txt
  • platform/chromium-win/svg/text/select-x-list-with-tspans-3-expected.txt
  • platform/chromium-win/svg/text/select-x-list-with-tspans-4-expected.txt
  • platform/chromium-win/svg/text/text-text-04-t-expected.txt
  • platform/chromium-win/svg/text/text-text-05-t-expected.txt
  • platform/chromium-win/svg/text/text-text-06-t-expected.txt
  • platform/chromium-win/svg/text/text-text-07-t-expected.txt
  • platform/chromium-win/svg/text/text-tspan-01-b-expected.txt
  • platform/chromium/test_expectations.txt:
17:53 Changeset [67255] by mitz@apple.com

2010-09-10 Dan Bernstein <mitz@apple.com>

Reviewed by Anders Carlsson.

Pseudostyle resolution corrupts cached child index values
https://bugs.webkit.org/show_bug.cgi?id=45574

Covered by fast/dom/firstline-fixed-crash.html and fast/dom/firstletter-tablecell-crash.html.

RenderBlock::updateFirstLetter() calls getCachedPseudoStyle() passing as the parent style the
style of the parent of the first letter, which is not always the parent of the element for
which we are getting :first-letter style. As a result, style resolution caches childIndex values
in the wrong element’s style.

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::pseudoStyleForElement): Create the new style and inherit from the parent style before matching rules, to avoid corrupting the parent style itself. (WebCore::CSSStyleSelector::checkSelector): Always pass the element’s parent style as the parent style here.
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::updateFirstLetter): Removed the null check that was added in r67183.
  • rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::findNextLineBreak): Removed the null check that was added in r67184.

2010-09-10 Dan Bernstein <mitz@apple.com>

Reviewed by Anders Carlsson.

Pseudostyle resolution corrupts cached child index values
https://bugs.webkit.org/show_bug.cgi?id=45574

  • fast/dom/firstline-fixed-crash-expected.txt: Updated results.
17:50 Changeset [67254] by jer.noble@apple.com

No review; build fix only.

Touch mediaControlsQuickTime in order to trigger the UserAgentStyleSheet.h to be rebuilt.

  • css/mediaControlsQuickTime.css:

(audio::-webkit-media-controls-volume-slider-mute-button, video::-webkit-media-controls-volume-slider-mute-button):

17:49 Changeset [67253] by abarth@webkit.org

2010-09-10 Adam Barth <abarth@webkit.org>

Reviewed by Darin Fisher.

Move code from WebKit-layer to DocumentLoader
https://bugs.webkit.org/show_bug.cgi?id=45569

  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::committedLoad):
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::commitDocumentData):

2010-09-10 Adam Barth <abarth@webkit.org>

Reviewed by Darin Fisher.

Move code from WebKit-layer to DocumentLoader
https://bugs.webkit.org/show_bug.cgi?id=45569

This code didn't know that setEncoding can be called multiple times.

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::FrameLoaderClientQt): (WebCore::FrameLoaderClientQt::finishedLoading): (WebCore::FrameLoaderClientQt::setMainDocumentError): (WebCore::FrameLoaderClientQt::committedLoad): (WebCore::FrameLoaderClientQt::dispatchDidReceiveResponse): (WebCore::FrameLoaderClientQt::dispatchDidFailLoading):
  • WebCoreSupport/FrameLoaderClientQt.h:

2010-09-10 Adam Barth <abarth@webkit.org>

Reviewed by Darin Fisher.

Move code from WebKit-layer to DocumentLoader
https://bugs.webkit.org/show_bug.cgi?id=45569

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::committedLoad):

2010-09-10 Adam Barth <abarth@webkit.org>

Reviewed by Darin Fisher.

Move code from WebKit-layer to DocumentLoader
https://bugs.webkit.org/show_bug.cgi?id=45569

  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::committedLoad):
  • WebCoreSupport/WebFrameLoaderClient.h:

2010-09-10 Adam Barth <abarth@webkit.org>

Reviewed by Darin Fisher.

Move code from WebKit-layer to DocumentLoader
https://bugs.webkit.org/show_bug.cgi?id=45569

  • WebKitSupport/FrameLoaderClientWx.cpp: (WebCore::FrameLoaderClientWx::committedLoad):

2010-09-10 Adam Barth <abarth@webkit.org>

Reviewed by Darin Fisher.

Move code from WebKit-layer to DocumentLoader
https://bugs.webkit.org/show_bug.cgi?id=45569

This code is the most confused, but now should be a bit cleaner.
There's still a magical fake-setting for creating renderers that needs
to be cleaned up, but we can do that in a separate patch.

  • WebView/WebFrame.mm: (-[WebFrame _commitData:]):
  • WebView/WebFrameInternal.h:
  • WebView/WebHTMLRepresentation.mm: (-[WebHTMLRepresentation receivedData:withDataSource:]): (-[WebHTMLRepresentation finishedLoadingWithDataSource:]):

2010-09-10 Adam Barth <abarth@webkit.org>

Reviewed by Darin Fisher.

Move code from WebKit-layer to DocumentLoader
https://bugs.webkit.org/show_bug.cgi?id=45569

  • WebCoreSupport/FrameLoaderClientHaiku.cpp: (WebCore::FrameLoaderClientHaiku::committedLoad):

2010-09-10 Adam Barth <abarth@webkit.org>

Reviewed by Darin Fisher.

Move code from WebKit-layer to DocumentLoader
https://bugs.webkit.org/show_bug.cgi?id=45569

This code didn't know that setEncoding could be called multiple times
safely.

  • WebCoreSupport/FrameLoaderClientEfl.cpp: (WebCore::FrameLoaderClientEfl::FrameLoaderClientEfl): (WebCore::FrameLoaderClientEfl::committedLoad): (WebCore::FrameLoaderClientEfl::dispatchDidReceiveResponse): (WebCore::FrameLoaderClientEfl::finishedLoading): (WebCore::FrameLoaderClientEfl::dispatchDidFailLoading): (WebCore::FrameLoaderClientEfl::setMainDocumentError):
  • WebCoreSupport/FrameLoaderClientEfl.h:

2010-09-10 Adam Barth <abarth@webkit.org>

Reviewed by Darin Fisher.

Move code from WebKit-layer to DocumentLoader
https://bugs.webkit.org/show_bug.cgi?id=45569

There's a bunch of code that's copy/pasted (poorly) across all the
ports that really belongs in WebCore. This patch moves that logic into
DocumentLoader. This patch is a step on the path to having
DocumentLoader own DocumentWriter.

  • WebCore.exp.in:
  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::commitData):
  • loader/DocumentLoader.h:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::finishedLoadingDocument):

2010-09-10 Adam Barth <abarth@webkit.org>

Reviewed by Darin Fisher.

Move code from WebKit-layer to DocumentLoader
https://bugs.webkit.org/show_bug.cgi?id=45569

This code looks copy/pasted from Mac. It's unclear whether whether all
the complexity is needed here, but I don't have a good way to find out.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::committedLoad):
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
17:47 Changeset [67252] by commit-queue@webkit.org

2010-09-10 Cosmin Truta <ctruta@chromium.org>

Reviewed by Nikolas Zimmermann.

getBoundingClientRect Broken for SVG Elements
https://bugs.webkit.org/show_bug.cgi?id=42815

Added tests for getBoundingClientRect applied to SVG elements.

  • svg/custom/getBoundingClientRect.xhtml: Added
  • svg/custom/getBoundingClientRect-expected.txt: Added

2010-09-10 Cosmin Truta <ctruta@chromium.org>

Reviewed by Nikolas Zimmermann.

getBoundingClientRect Broken for SVG Elements
https://bugs.webkit.org/show_bug.cgi?id=42815

Use getBBox to retrieve the bounding rectangle for SVG elements.

Test: svg/dom/getBoundingClientRect.xhtml

  • dom/Element.cpp: (Element::getBoundingClientRect):
16:56 Changeset [67251] by jer.noble@apple.com

2010-09-09 Jer Noble <jer.noble@apple.com>

Reviewed by Eric Carlson.

Adopt shared control drawing for <video> controls on Windows
https://bugs.webkit.org/show_bug.cgi?id=45490

  • win/lib/WebKitSystemInterface.lib:
  • win/lib/WebKitSystemInterface_debug.lib:

2010-09-09 Jer Noble <jer.noble@apple.com>

Reviewed by Eric Carlson.

Adopt shared control drawing for <video> controls on Windows
https://bugs.webkit.org/show_bug.cgi?id=45490


  • DerivedSources.make: Remove the OS check around mediaControlsQuickTime.css.
  • rendering/RenderMediaControls.cpp: (WebCore::determineState): Use WKMediaControllerThemeState flags instead of SafariTheme ones. (WebCore::getUnzoomedRectAndAdjustCurrentContext): Added. Copied verbatim from RenderMediaMac.mm. (WebCore::RenderMediaControls::adjustMediaSliderThumbSize): Use wkMeasureMediaUIPart to adjust the thumb size. (WebCore::RenderMediaControls::paintMediaControlsPart): Use wkDrawMediaUIPart instead of paintThemePart. (WebCore::RenderMediaControls::volumeSliderOffsetFromMuteButton): Added. Copied verbatim from RenderMediaMac.mm.
  • rendering/RenderMediaControls.h:
  • rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::adjustSliderThumbSize): Adjust both sliders and volume sliders. (WebCore::RenderThemeWin::extraMediaControlsStyleSheet): Added. Returns the mediaControlsQuickTime sheet. (WebCore::RenderThemeWin::paintMediaRewindButton): Added. Pass through to RenderMediaControls. (WebCore::RenderThemeWin::paintMediaControlsBackground): Added. Pass through to RenderMediaControls. (WebCore::RenderThemeWin::paintMediaVolumeSliderContainer): Added. Pass through to RenderMediaControls. (WebCore::RenderThemeWin::paintMediaVolumeSliderTrack): Added. Pass through to RenderMediaControls. (WebCore::RenderThemeWin::paintMediaVolumeSliderThumb): Added. Pass through to RenderMediaControls. (WebCore::RenderThemeWin::volumeSliderOffsetFromMuteButton): Added. Pass through to RenderMediaControls.
  • rendering/RenderThemeWin.h:

2010-09-109 Peter Kasting <pkasting@google.com>

Reviewed by Darin Adler.

Cleanup and simplification in advance of making middle clicks not send a
click event.
https://bugs.webkit.org/show_bug.cgi?id=22382

  • editing/DeleteButton.cpp: (WebCore::DeleteButton::defaultEventHandler): Removed unneeded code to check if the event is a MouseEvent. Any click event will do.
  • html/HTMLAnchorElement.cpp: (WebCore::appendServerMapMousePosition): Added. Factors out the modifications to the URL to add the mouse position to make the default event handler function easier to read. (WebCore::HTMLAnchorElement::defaultEventHandler): Reorganized to make the enter key logic separate from the link clicking logic and simplify the function. This makes minor functional changes like not calling FrameLoader::urlSelected() for fake "keydown" events constructed from JavaScript. (WebCore::HTMLAnchorElement::isLiveLink): Refactored to use new shared implementation in treatLinkAsLiveForEventType(). (WebCore::eventType): Factors out event type calculation (for treatLinkAsLiveForEventType()) from the default event handler to make it easier to read. (WebCore::HTMLAnchorElement::treatLinkAsLiveForEventType): Implementation of the portions of isLiveLink() that are common with the checks defaultEventHandler() wants to do. (WebCore::isEnterKeyKeydownEvent): Added. Shared by the default event handlers for all three anchor elements. (WebCore::isMiddleMouseButtonEvent): Added. Shared by the isLinkClick function below and some code in SVG. Later we can make this private to this source file once we remove the unneeded SVG code. (WebCore::isLinkClick): Added. Shared by the default event handlers for all three anchor elements. (WebCore::handleLinkClick): Ditto.
  • html/HTMLAnchorElement.h: Added the new functions.
  • svg/SVGAElement.cpp: (WebCore::SVGAElement::defaultEventHandler): Removed lots of unneeded logic and streamlined the code to more closely match the HTMLAnchorElement code and share functions with it.
  • wml/WMLAElement.cpp: (WebCore::WMLAElement::defaultEventHandler): Ditto.
16:47 Changeset [67250] by tony@chromium.org

2010-09-10 Tony Chang <tony@chromium.org>

Unreviewed, fix chromium compile after r67238.

shouldChangeSelection was removed from Frame.

  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::selectWordAroundPosition):
16:40 Changeset [67249] by jianli@chromium.org

Update mac/Skipped to include the bug numbers for newly added skip entries.

  • platform/mac/Skipped:
16:31 Changeset [67248] by commit-queue@webkit.org

2010-09-10 Mike Lawther <mikelawther@chromium.org>

Reviewed by Ojan Vafai.

[Chromium] Rebaseline transitions/opacity-transition-zindex.html
https://bugs.webkit.org/show_bug.cgi?id=45515

Difference was off-by-one on the green channel.

  • platform/chromium-win/transitions/opacity-transition-zindex-expected.checksum: Added.
  • platform/chromium-win/transitions/opacity-transition-zindex-expected.png: Added.
  • platform/chromium/test_expectations.txt:
15:52 Changeset [67247] by andersca@apple.com

WebKit2: Set the visible name for the web process
https://bugs.webkit.org/show_bug.cgi?id=45564
<rdar://problem/8416970>

Reviewed by Mark Rowe and Darin Adler.

  • UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::processName):
Add a thread safe implementation of -[NSProcessInfo processName].

(WebKit::ProcessLauncher::launchProcess):
Pass the process name to the child process.

  • WebProcess/mac/WebProcessMainMac.mm:

(WebKit::WebProcessMain):
Set the visible name.

WebKitLibraries: WebKitSystemInterface part of:
Set the visible name for the web process
https://bugs.webkit.org/show_bug.cgi?id=45564
<rdar://problem/8416970>

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
15:42 Changeset [67246] by pkasting@chromium.org

2010-09-109 Peter Kasting <pkasting@google.com>

Reviewed by Darin Adler.

Cleanup and simplification in advance of making middle clicks not send a
click event.
https://bugs.webkit.org/show_bug.cgi?id=22382

  • editing/DeleteButton.cpp:

(WebCore::DeleteButton::defaultEventHandler): Removed unneeded code to
check if the event is a MouseEvent. Any click event will do.

  • html/HTMLAnchorElement.cpp:

(WebCore::appendServerMapMousePosition): Added. Factors out the
modifications to the URL to add the mouse position to make the default
event handler function easier to read.
(WebCore::HTMLAnchorElement::defaultEventHandler): Reorganized to make
the enter key logic separate from the link clicking logic and simplify
the function. This makes minor functional changes like not calling
FrameLoader::urlSelected() for fake "keydown" events constructed from
JavaScript.
(WebCore::HTMLAnchorElement::isLiveLink): Refactored to use new shared
implementation in treatLinkAsLiveForEventType().
(WebCore::eventType): Factors out event type calculation (for
treatLinkAsLiveForEventType()) from the default event handler to make it
easier to read.
(WebCore::HTMLAnchorElement::treatLinkAsLiveForEventType):
Implementation of the portions of isLiveLink() that are common with the
checks defaultEventHandler() wants to do.
(WebCore::isEnterKeyKeydownEvent): Added. Shared by the default
event handlers for all three anchor elements.
(WebCore::isMiddleMouseButtonEvent): Added. Shared by the isLinkClick
function below and some code in SVG. Later we can make this private to
this source file once we remove the unneeded SVG code.
(WebCore::isLinkClick): Added. Shared by the default event handlers for
all three anchor elements.
(WebCore::handleLinkClick): Ditto.

  • html/HTMLAnchorElement.h: Added the new functions.
  • svg/SVGAElement.cpp:

(WebCore::SVGAElement::defaultEventHandler): Removed lots of unneeded
logic and streamlined the code to more closely match the
HTMLAnchorElement code and share functions with it.

  • wml/WMLAElement.cpp:

(WebCore::WMLAElement::defaultEventHandler): Ditto.

15:38 Changeset [67245] by tonyg@chromium.org

2010-09-10 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Eric Seidel.

Implement HTML5 definition of script for-event neutering
https://bugs.webkit.org/show_bug.cgi?id=45493

  • fast/dom/HTMLScriptElement/script-for-attribute-unexpected-execution-expected.txt:
  • fast/dom/HTMLScriptElement/script-tests/script-for-attribute-unexpected-execution.js: Beef up test with some more cases, change style to be more readable, and remove obsolete comments about supporting for-event.

2010-09-10 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Eric Seidel.

Implement HTML5 definition of script for-event neutering
https://bugs.webkit.org/show_bug.cgi?id=45493

  • dom/ScriptElement.cpp: (WebCore::ScriptElementData::shouldExecuteAsJavaScript): Same behavior, but reads more like the spec. Removed obsolete comments about supporting for-event.
  • html/parser/HTMLScriptRunner.cpp: (WebCore::HTMLScriptRunner::executeScript): Moved to runScript. (WebCore::HTMLScriptRunner::runScript): Checking shouldExecuteAsJavaScript() here means that external scripts which fail the check will never be requested.
15:33 Changeset [67244] by darin@chromium.org

2010-09-10 Nat Duca <nduca@chromium.org>

Reviewed by Darin Fisher.

[chromium] Accelerated Compositing: screen garbage when scrolling
https://bugs.webkit.org/show_bug.cgi?id=45092

Split LayerRenderChromium::drawLayers into several different
functions, responsible for preparing the backbuffer, updating the
root texture, compositing and performing the final
swapbuffers. This are then used by the new
WebViewImpl::composite rendering path.

  • platform/graphics/chromium/LayerChromium.cpp: (WebCore::LayerChromium::setBounds): (WebCore::LayerChromium::setFrame): (WebCore::LayerChromium::setNeedsDisplay): (WebCore::LayerChromium::resetNeedsDisplay):
  • platform/graphics/chromium/LayerChromium.h: (WebCore::LayerChromium::dirtyRect):
  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::prepareToDrawLayers): (WebCore::LayerRendererChromium::updateRootLayerTextureRect): (WebCore::LayerRendererChromium::drawLayers): (WebCore::LayerRendererChromium::present):
  • platform/graphics/chromium/LayerRendererChromium.h:
15:26 Changeset [67243] by rniwa@webkit.org

2010-09-10 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Eric Seidel.

execCommand("fontsize") on certain selected html generates too many SPAN tags.
https://bugs.webkit.org/show_bug.cgi?id=28968

Added a test to ensure only one font element is added when applying font-size
to multiple inline nodes.

  • editing/style/apply-font-size-to-multiple-nodes-expected.txt: Added.
  • editing/style/apply-font-size-to-multiple-nodes.html: Added.
15:24 Changeset [67242] by tony@chromium.org

2010-09-10 Tony Chang <tony@chromium.org>

Unreviewed, rolling out r67241.
http://trac.webkit.org/changeset/67241
https://bugs.webkit.org/show_bug.cgi?id=44709

Accidentally committed.

  • Scripts/webkitpy/layout_tests/deduplicate_tests.py:
  • Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
15:16 Changeset [67241] by tony@chromium.org

2010-09-10 Tony Chang <tony@chromium.org>

Reviewed by Ojan Vafai.

deduplicate-tests should be runnable from any WebKit directory
https://bugs.webkit.org/show_bug.cgi?id=44709

  • Scripts/webkitpy/layout_tests/deduplicate_tests.py:
  • Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
15:16 Changeset [67240] by inferno@chromium.org

2010-09-10 David Holloway <dhollowa@chromium.org>

Reviewed by Adam Barth.

Change WebKit::WebFormElement::wasUserSubmitted to use WebCore::HTMLFormElement::submittedByUserGesture
instead of WebCore::HTMLFormElement::submissionTrigger.
Chromium AutoFill feature semantics changed with respect to what we mean by "user submitted" form. A
more accurate measure of the user manually submitting a form is via user gesture.
https://bugs.webkit.org/show_bug.cgi?id=45128

  • src/WebFormElement.cpp: (WebKit::WebFormElement::wasUserSubmitted):

2010-09-10 David Holloway <dhollowa@chromium.org>

Reviewed by Adam Barth.

Replace WebCore::HTMLFormElement::submissionTrigger with WebCore::HTMLFormElement::submittedByUserGesture.
Chromium AutoFill feature semantics changed with respect to what we mean by "user submitted" form. A
more accurate measure of the user manually submitting a form is via user gesture.
https://bugs.webkit.org/show_bug.cgi?id=45128

No new tests as this is only used by the Chromium WebKit API.

  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::HTMLFormElement): (WebCore::HTMLFormElement::prepareSubmit): (WebCore::HTMLFormElement::submit): (WebCore::HTMLFormElement::submittedByUserGesture):
  • html/HTMLFormElement.h:
15:08 Changeset [67239] by abarth@webkit.org

2010-09-10 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Remove mention of "part" from Document.cpp
https://bugs.webkit.org/show_bug.cgi?id=45566

This is an old KHTML name that's lingering around.

  • dom/Document.cpp: (WebCore::Document::parentDocument):
15:06 Changeset [67238] by darin@apple.com

2010-09-09 Darin Adler <darin@apple.com>

Reviewed by Adam Barth.

Move functions from Frame to SelectionController as planned
https://bugs.webkit.org/show_bug.cgi?id=45508

  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::selectionBoundsRect): Call functions on selection().

2010-09-09 Darin Adler <darin@apple.com>

Reviewed by Adam Barth.

Move functions from Frame to SelectionController as planned
https://bugs.webkit.org/show_bug.cgi?id=45508

  • WebView.cpp: (WebView::selectionRect): (WebView::centerSelectionInVisibleArea): Call functions on selection().

2010-09-09 Darin Adler <darin@apple.com>

Reviewed by Adam Barth.

Move functions from Frame to SelectionController as planned
https://bugs.webkit.org/show_bug.cgi?id=45508

  • WebView/WebFrame.mm: (-[WebFrame _selectionGranularity]): (-[WebFrame _insertParagraphSeparatorInQuotedContent]): (-[WebFrame _typingStyle]): (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
  • WebView/WebHTMLRepresentation.mm: (-[WebHTMLRepresentation currentForm]):
  • WebView/WebHTMLView.mm: (-[WebHTMLView jumpToSelection:]): (-[WebHTMLView centerSelectionInVisibleArea:]): (-[WebHTMLView _canSmartCopyOrDelete]): (-[WebHTMLView _lookUpInDictionaryFromMenu:]): (-[WebHTMLView selectionRect]): (-[WebHTMLView selectionTextRects]): (-[WebHTMLView selectionImageRect]):
  • WebView/WebView.mm: (-[WebView setEditable:]): Call functions on selection().

2010-09-09 Darin Adler <darin@apple.com>

Reviewed by Adam Barth.

Move functions from Frame to SelectionController as planned
https://bugs.webkit.org/show_bug.cgi?id=45508

Also removed Frame::dragCaretController since it just called Page::dragCaretController.

  • editing/SelectionController.cpp: (WebCore::SelectionController::setSelection): (WebCore::SelectionController::modify): (WebCore::SelectionController::selectFrameElementInParentIfFullySelected): (WebCore::SelectionController::selectAll): (WebCore::SelectionController::focusedOrActiveStateChanged): (WebCore::SelectionController::notifyRendererOfSelectionChange): (WebCore::isFrameElement): (WebCore::SelectionController::setFocusedNodeIfNeeded): (WebCore::SelectionController::paintDragCaret): (WebCore::SelectionController::shouldDeleteSelection): (WebCore::SelectionController::selectionBounds): (WebCore::SelectionController::selectionTextRects): (WebCore::scanForForm): (WebCore::SelectionController::currentForm): (WebCore::SelectionController::revealSelection): (WebCore::SelectionController::setSelectionFromNone): (WebCore::SelectionController::shouldChangeSelection):
  • editing/SelectionController.h: Moved functions here from Frame.
  • page/Frame.cpp:
  • page/Frame.h: Moved functions to SelectionController. Reorganized header to be easier to read and a bit more logical.
  • WebCore.exp.in: Updated.
  • dom/Document.cpp: (WebCore::Document::nodeChildrenWillBeRemoved): (WebCore::Document::nodeWillBeRemoved): Call Page::dragCaretController directly.
  • dom/Element.cpp: (WebCore::Element::updateFocusAppearance):
  • dom/InputElement.cpp: (WebCore::InputElement::updateFocusAppearance):
  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::editingStyleAtPosition):
  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::calculateTypingStyleAfterDelete):
  • editing/Editor.cpp: (WebCore::Editor::canSmartCopyOrDelete): (WebCore::Editor::textDirectionForSelection): (WebCore::Editor::appliedEditing): (WebCore::Editor::insertTextWithoutSendingTextEvent): (WebCore::Editor::advanceToNextMisspelling): (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): (WebCore::Editor::revealSelectionAfterEditingOperation): (WebCore::Editor::transpose): (WebCore::Editor::changeSelectionAfterCommand): (WebCore::Editor::computeAndSetTypingStyle): (WebCore::Editor::selectionComputedStyle): (WebCore::Editor::styleForSelectionStart): (WebCore::Editor::findString):
  • editing/EditorCommand.cpp: (WebCore::executeDelete):
  • editing/InsertLineBreakCommand.cpp: (WebCore::InsertLineBreakCommand::doApply):
  • editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::input):
  • editing/RemoveFormatCommand.cpp: (WebCore::RemoveFormatCommand::doApply):
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply):
  • editing/TypingCommand.cpp: (WebCore::TypingCommand::insertTextRunWithoutNewlines): (WebCore::TypingCommand::deleteKeyPressed): (WebCore::TypingCommand::forwardDeleteKeyPressed):
  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::updateFocusAppearance):
  • page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected):
  • page/DragController.cpp: (WebCore::DragController::concludeEditDrag): (WebCore::dragLocForSelectionDrag):
  • page/EventHandler.cpp: (WebCore::EventHandler::selectClosestWordFromMouseEvent): (WebCore::EventHandler::selectClosestWordOrLinkFromMouseEvent): (WebCore::EventHandler::handleMousePressEventTripleClick): (WebCore::EventHandler::handleMousePressEventSingleClick): (WebCore::EventHandler::updateSelectionForMouseDrag): (WebCore::EventHandler::handleMouseReleaseEvent):
  • page/FocusController.cpp: (WebCore::FocusController::advanceFocusInDocumentOrder):
  • page/chromium/EventHandlerChromium.cpp: (WebCore::EventHandler::passMousePressEventToSubframe):
  • page/chromium/FrameChromium.cpp: (WebCore::Frame::dragImageForSelection):
  • page/mac/FrameMac.mm: (WebCore::Frame::selectionImage):
  • platform/mac/ClipboardMac.mm: (WebCore::ClipboardMac::writeRange):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintCaret): Call functions on selection().
15:04 Changeset [67237] by simon.fraser@apple.com

2010-09-10 Simon Fraser <simon.fraser@apple.com>

Re-enable some Windows compositing tests that no longer assert.

  • platform/win/Skipped:
15:00 Changeset [67236] by jschuh@chromium.org

2010-09-10 Justin Schuh <jschuh@chromium.org>

Reviewed by Darin Adler.

SVGGElement::rendererIsNeeded should return false when parent isn't SVG
https://bugs.webkit.org/show_bug.cgi?id=45562

Test: svg/custom/g-outside-svg.html

  • svg/SVGGElement.cpp: (WebCore::SVGGElement::rendererIsNeeded):
  • svg/SVGGElement.h:

2010-09-10 Justin Schuh <jschuh@chromium.org>

Reviewed by Darin Adler.

SVGGElement::rendererIsNeeded should return false when parent isn't SVG
https://bugs.webkit.org/show_bug.cgi?id=45562

  • svg/custom/g-outside-svg-expected.txt: Added.
  • svg/custom/g-outside-svg.html: Added.
14:31 Changeset [67235] by jianli@chromium.org

Skip file api tests for workers that could crash occasionally before
we figure out how to fix them.

  • platform/mac/Skipped:
14:29 Changeset [67234] by abarth@webkit.org

2010-09-10 Adam Barth <abarth@webkit.org>

Chromium build fix (one hopes!)

  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::commitDocumentData):
14:25 Changeset [67233] by abarth@webkit.org

2010-09-10 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

REGRESSION (HTML Parser): CNN's Money site is not formatted correctly with AdBlock installed
https://bugs.webkit.org/show_bug.cgi?id=41371

Drop support for closing comments with "-- >". This was an attempt to
be more IE-like in comment parsing, but it turns out to cause problems
for some high-profile sites. Firefox 4 is dropping support as well.
We expect the spec to change soon too.

  • html/parser/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::nextToken):
  • html/parser/HTMLTokenizer.h:

2010-09-10 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

REGRESSION (HTML Parser): CNN's Money site is not formatted correctly with AdBlock installed
https://bugs.webkit.org/show_bug.cgi?id=41371

Update test results for new behavior.

  • fast/parser/comments-expected.txt:
  • fast/parser/comments.html:
    • Removed the redundant in-test expectations.
  • html5lib/runner-expected.txt:
    • We now "fail" these two tests. We'll pass them again once the spec changes and HTML5lib updates its expectations.
14:22 Changeset [67232] by simon.fraser@apple.com

2010-09-10 Simon Fraser <simon.fraser@apple.com>

Reviewed by Adam Roben.

compositing/iframes/iframe-src-change.html test fails on Windows
https://bugs.webkit.org/show_bug.cgi?id=45554

This test had the wrong behavior. It never actually entered compositing mode.
Now give it a chance to do so (and test for it), and then test that the layers
disappeared.

  • compositing/iframes/iframe-src-change-expected.txt:
  • compositing/iframes/iframe-src-change.html:
14:10 Changeset [67231] by cmarrin@apple.com

Restored a Changelog entry for a change that was reverted. I mistakenly thought reverted changes should be removed.

14:04 Changeset [67230] by aroben@apple.com

Give expected results files the right names

  • platform/win/fast/text/hyphenate-first-word-expected.txt: Renamed from LayoutTests/platform/win/fast/text/hyphenate-first-word-actual.txt.
  • platform/win/fast/text/hyphenate-locale-expected.txt: Renamed from LayoutTests/platform/win/fast/text/hyphenate-locale-actual.txt.
  • platform/win/html5lib/runner-expected.txt: Renamed from LayoutTests/platform/win/html5lib/runner-actual.txt.
14:02 Changeset [67229] by cmarrin@apple.com

2010-09-10 Chris Marrin <cmarrin@apple.com>

Unreviewed.

Adding file that should have been in http://trac.webkit.org/changeset/67226 but
I forgot to svn add.


  • platform/graphics/opengl: Added.
  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp: Copied from platform/graphics/mac/GraphicsContext3DMac.mm.
13:56 Changeset [67228] by cmarrin@apple.com

one more typo fix in Changelog

13:54 Changeset [67227] by cmarrin@apple.com

fixed typo in Changelog

13:51 Changeset [67226] by cmarrin@apple.com

2010-09-10 Paul Sawaya <psawaya@apple.com>

Reviewed by Chris Marr.

Refactored non-Mac specific code into GraphicsContext3DOpenGL.


Moving this file into platform/graphics/mac for now, and only building on Mac.


https://bugs.webkit.org/show_bug.cgi?id=30625

13:28 Changeset [67225] by oliver@apple.com

Qt build fix.

13:01 Changeset [67224] by abarth@webkit.org

2010-09-10 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Remove useless FrameLoader method
https://bugs.webkit.org/show_bug.cgi?id=45492

This method has one caller, and that caller already has a more direct
way of accessing the correct DocumentLoader.

  • loader/FrameLoader.cpp:
  • loader/FrameLoader.h:
  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::addData):
12:54 Changeset [67223] by abarth@webkit.org

2010-09-10 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Main resource bytes shouldn't bounce through FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=45496

After the MainResourceLoader hands the bytes for the main resource to
the DocumentLoader, the DocumentLoader hands the bytes to the
FrameLoaderClient. The FrameLoaderClient, in turn, returns the bytes
to WebCore. Prior to this patch, the FrameLoaderClient returned the
bytes to the FrameLoader. However, the FrameLoader was actually adding
any value.

In this patch, we change the FrameLoaderClient to return the bytes to
the DocumentLoader directly. In a future patch, we'll cut out the
FrameLoaderClient middleman and handle the bytes internally in the
DocumentLoader.

  • WebCore.exp.in:
  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::addData):
  • loader/DocumentLoader.h:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::finishedLoadingDocument):
  • loader/FrameLoader.h:

2010-09-10 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Main resource bytes shouldn't bounce through FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=45496

Now return the bytes to the DocumentLoader.

Also, removed comment about wrong code in the Mac port.

  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::commitDocumentData):

2010-09-10 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Main resource bytes shouldn't bounce through FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=45496

Now return the bytes to the DocumentLoader.

  • WebCoreSupport/FrameLoaderClientEfl.cpp: (WebCore::FrameLoaderClientEfl::committedLoad):

2010-09-10 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Main resource bytes shouldn't bounce through FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=45496

Now return the bytes to the DocumentLoader.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::committedLoad):

2010-09-10 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Main resource bytes shouldn't bounce through FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=45496

Now return the bytes to the DocumentLoader.

  • WebCoreSupport/FrameLoaderClientHaiku.cpp: (WebCore::FrameLoaderClientHaiku::committedLoad):

2010-09-10 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Main resource bytes shouldn't bounce through FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=45496

Now return the bytes to the DocumentLoader.

Previously, we were checking the document for null. However, Frame can
never have a null document, so this check is no longer needed.

  • WebView/WebFrame.mm: (-[WebFrame _addData:]):

2010-09-10 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Main resource bytes shouldn't bounce through FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=45496

Now return the bytes to the DocumentLoader.

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::committedLoad):

2010-09-10 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Main resource bytes shouldn't bounce through FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=45496

Now return the bytes to the DocumentLoader.

  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::receivedData):

2010-09-10 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Main resource bytes shouldn't bounce through FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=45496

Now return the bytes to the DocumentLoader.

  • WebKitSupport/FrameLoaderClientWx.cpp: (WebCore::FrameLoaderClientWx::committedLoad):

2010-09-10 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Main resource bytes shouldn't bounce through FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=45496

Now return the bytes to the DocumentLoader.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::receivedData):
12:52 Changeset [67222] by oliver@apple.com

2010-09-10 Oliver Hunt <oliver@apple.com>

Reviewed by Darin Adler.

Speed up deserialisation of strings
https://bugs.webkit.org/show_bug.cgi?id=45555

Rather than building a list of Identifiers for the string pool
we now build a list of a tuple of UString and JSString*. This
doesn't hurt the property name case as ustring->identifier conversion
is essentially free if the ustring has already been converted to
an Identifier, but saves an unnecessary Identifier creation for
strings we only ever use to create JSStrings. We also reduce
GC pressure for duplicate strings by caching the JSStrings.

  • bindings/js/SerializedScriptValue.cpp: (WebCore::CloneDeserializer::CachedString::CachedString): (WebCore::CloneDeserializer::CachedString::jsString): (WebCore::CloneDeserializer::CachedString::ustring): (WebCore::CloneDeserializer::readStringData): (WebCore::CloneDeserializer::putProperty): (WebCore::CloneDeserializer::readFile): (WebCore::CloneDeserializer::readTerminal): (WebCore::CloneDeserializer::deserialize):
12:40 Changeset [67221] by rniwa@webkit.org

2010-09-10 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Antonio Gomes.

REGRESSION(r67176): editing/selection/doubleclick-inline-first-last-contenteditable.html crashes
https://bugs.webkit.org/show_bug.cgi?id=45525

The crash was caused by ancestorToRetainStructureAndAppearance not taking into consideration
the case where there is no common block ancestor. Fixed this by adding a null check.

Test: editing/pasteboard/copy-without-common-block-crash.html

  • editing/markup.cpp: (WebCore::ancestorToRetainStructureAndAppearance): Added a null check.

2010-09-10 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Antonio Gomes.

REGRESSION(r67176): editing/selection/doubleclick-inline-first-last-contenteditable.html crashes
https://bugs.webkit.org/show_bug.cgi?id=45525

Added a test to ensure WebKit does not crash when copying a region that doesn't have any common block ancestor.
Also removed doubleclick-inline-first-last-contenteditable.html from the qt's skipped list since
this test should not crash anymore.

  • editing/pasteboard/copy-without-common-block-crash-expected.txt: Added.
  • editing/pasteboard/copy-without-common-block-crash.html: Added.
  • platform/qt/Skipped: Removed doubleclick-inline-first-last-contenteditable.html from the list.
11:43 Changeset [67220] by kinuko@chromium.org

2010-09-09 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by Dumitru Daniliuc.

[FileSystem] Do not call EntriesCallback more than once if there're no entries.
https://bugs.webkit.org/show_bug.cgi?id=45498

No new tests, layout-tests that confirm the behavior will be added in later patches.

  • fileapi/FileSystemCallbacks.cpp: (WebCore::EntriesCallbacks::EntriesCallbacks): (WebCore::EntriesCallbacks::didReadDirectoryEntry): (WebCore::EntriesCallbacks::didReadDirectoryEntries):
11:34 Changeset [67219] by cfleizach@apple.com

WebCore: Use String::fromUTF8 instead of UTF8Encoding().decode
in the libxml XMLDocumentParser
https://bugs.webkit.org/show_bug.cgi?id=45488

Patch by Patrick Gansterer <paroga@paroga.com> on 2010-09-10
Reviewed by Darin Adler.

  • dom/XMLDocumentParserLibxml2.cpp:

(WebCore::toString):

LayoutTests: Land new expected results for some tests on Windows

Patch by Adam Roben <aroben@apple.com> on 2010-09-10
Rubber-stamped in advance by Simon Fraser.

  • platform/win/fast/text/hyphenate-first-word-actual.txt: Added.
  • platform/win/fast/text/hyphenate-locale-actual.txt: Added.

Windows doesn't support hyphenation.

  • platform/win/html5lib/runner-actual.txt: Added.

We don't implement <keygen> on Windows, so we pass some tests that
expect <keygen> to have no child elements (on Mac, the child elements
are real DOM elements, rather than living in the shadow DOM tree like
HTML5 mandates, so the tests fail).

11:31 Changeset [67218] by tony@chromium.org

2010-09-10 Tony Chang <tony@chromium.org>

Unreviewed, rolling out r67216.
http://trac.webkit.org/changeset/67216
https://bugs.webkit.org/show_bug.cgi?id=44709

Broke

  • Scripts/webkitpy/layout_tests/deduplicate_tests.py:
  • Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
11:21 Changeset [67217] by aroben@apple.com

Land new expected results for some tests on Windows

Rubber-stamped in advance by Simon Fraser.

  • platform/win/fast/text/hyphenate-first-word-actual.txt: Added.
  • platform/win/fast/text/hyphenate-locale-actual.txt: Added.

Windows doesn't support hyphenation.

  • platform/win/html5lib/runner-actual.txt: Added.

We don't implement <keygen> on Windows, so we pass some tests that
expect <keygen> to have no child elements (on Mac, the child elements
are real DOM elements, rather than living in the shadow DOM tree like
HTML5 mandates, so the tests fail).

11:10 Changeset [67216] by tony@chromium.org

2010-09-10 Tony Chang <tony@chromium.org>

Reviewed by Ojan Vafai.

deduplicate-tests should be runnable from any WebKit directory
https://bugs.webkit.org/show_bug.cgi?id=44709

  • Scripts/webkitpy/layout_tests/deduplicate_tests.py:
  • Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
11:04 Changeset [67215] by mrobinson@webkit.org

2010-09-10 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Placement new / manual destructor invocation should be used on private GObject memory
https://bugs.webkit.org/show_bug.cgi?id=45550

GLib allocates and deallocates GObject private data structs itself. When
those structs contain C++ members, their constructors and destructors are not
called. This is not only dangerous, it makes RefPtr-type smart pointers much
less useful. We can fix this problem by calling placement new on the private
data struct during instance initialization and calling the destructor during
finalization.

This patch takes that approach and switches plain char* members of
WebKitWebView (with manual memory allocation) to use CString.

  • webkit/webkitprivate.h: Switch char* members to CString.
  • webkit/webkitwebview.cpp: (webkit_web_view_finalize): Manually call the destructor on the private data. Remove manual deallocation of members which are now CString. (webkit_web_view_query_tooltip): Update to reflect CString change. (webkit_web_view_init): Use placement new to initialize C++ members of the private data section. (webkit_web_view_get_encoding): Update to reflect CString change. (webkit_web_view_get_custom_encoding): Ditto. (webkit_web_view_add_resource): Ditto. (webkit_web_view_get_resource): Ditto. (webkit_web_view_clear_resources): Ditto. (webkit_web_view_set_tooltip_text): Ditto. (webkit_web_view_get_icon_uri): Ditto.
10:44 Changeset [67214] by commit-queue@webkit.org

2010-09-10 Patrick Gansterer <paroga@paroga.com>

Reviewed by Darin Adler.

Use String::fromUTF8 instead of UTF8Encoding().decode
in the libxml XMLDocumentParser
https://bugs.webkit.org/show_bug.cgi?id=45488

  • dom/XMLDocumentParserLibxml2.cpp: (WebCore::toString):
10:39 Changeset [67213] by joepeck@webkit.org

2010-09-09 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by Andreas Kling.

Clean Up Some Expected Results for Missing Tests
https://bugs.webkit.org/show_bug.cgi?id=45489

Test was removed in r35456 but expected results were missed.

  • http/tests/xmlhttprequest/access-control-basic-exclude-expected.txt: Removed.

Results were added in r19036 but the test was never added. No record of the test.

  • editing/pasteboard/4944770-expected.txt: Removed.
  • platform/mac/editing/pasteboard/4944770-expected.checksum: Removed.
  • platform/mac/editing/pasteboard/4944770-expected.png: Removed.
10:29 BuildingOnWindows edited by aroben@apple.com
Simplify symbol path a bit (diff)
10:15 Changeset [67212] by simon.fraser@apple.com

2010-09-10 Simon Fraser <simon.fraser@apple.com>

Reviewed by Chris Marrin.

Update Windows LayoutTest/compositing results
https://bugs.webkit.org/show_bug.cgi?id=45323

Fix up some windows compositing test results.

  • platform/win/compositing/iframes/composited-parent-iframe-expected.txt: Removed.
  • platform/win/compositing/iframes/iframe-resize-expected.txt: Removed.
  • platform/win/compositing/iframes/leave-compositing-iframe-expected.txt: Removed.
  • platform/win/compositing/iframes/overlapped-iframe-expected.txt: Removed.
  • platform/win/compositing/plugins/composited-plugin-expected.txt: Added.
  • platform/win/compositing/plugins/small-to-large-composited-plugin-expected.txt: Copied from LayoutTests/compositing/iframes/leave-compositing-iframe-expected.txt.
10:14 Changeset [67211] by kov@webkit.org

2010-09-10 Gustavo Noronha Silva <gns@gnome.org>

Reviewed by Martin Robinson.

[GTK] Google sites do not like WebKitGTK+
https://bugs.webkit.org/show_bug.cgi?id=39617

Special-case Google domains, and spoof User-Agent when talking to
them, to stop being treated as a second-class citizen.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::initializeDomainsList): (WebKit::isGoogleDomain): (WebKit::FrameLoaderClient::userAgent): If enable-site-specific-quirks is enabled, send the standard WebKit User-Agent string, disregarding the custom one set by the browser for Google domains.
  • webkit/webkitprivate.h:
  • webkit/webkitwebsettings.cpp: (webkitPlatform): Fix style, and simplify. (webkitOSVersion): Ditto. (webkitUserAgent): Add the Version/x.y string Safari has been using since Safari 2.2.
09:49 Changeset [67210] by yurys@chromium.org

2010-09-10 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

[Chromium] rebaseline SVGFEDiffuseLightingElement-lighting-color-css-prop.html
https://bugs.webkit.org/show_bug.cgi?id=45540

  • platform/chromium-linux/svg/dynamic-updates/SVGFEDiffuseLightingElement-lighting-color-css-prop-expected.checksum:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDiffuseLightingElement-lighting-color-css-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEDiffuseLightingElement-lighting-color-css-prop-expected.checksum:
  • platform/chromium-win/svg/dynamic-updates/SVGFEDiffuseLightingElement-lighting-color-css-prop-expected.png:
09:38 Changeset [67209] by cfleizach@apple.com

Mail crashes with searching for next misspelled word with VoiceOver
https://bugs.webkit.org/show_bug.cgi?id=45501

Reviewed by David Kilzer.

WebCore:

Test: platform/mac/accessibility/crash-in-element-for-text-marker.html

  • accessibility/mac/AccessibilityObjectWrapper.mm:

(-[AccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):

Check that the AX object is not nil before asking for the wrapper().

LayoutTests:

  • platform/mac/accessibility/crash-in-element-for-text-marker-expected.txt: Added.
  • platform/mac/accessibility/crash-in-element-for-text-marker.html: Added.
09:19 Changeset [67208] by commit-queue@webkit.org

2010-09-10 Michael Nordman <michaeln@google.com>

Reviewed by Dumitru Daniliuc.

Decouple Blob from ScriptExecutionContext.
https://bugs.webkit.org/show_bug.cgi?id=45410

  • Removed ScriptExecutionContext pointers from Blob and File constructors.
  • Removed ScriptExecutionContext's collection of Blobs instance in that context.
  • Refactored BlobURL to make a distinction between 'public' blob urls and 'internal' urls that are used solely as identifiers. The former requires a SecurityOrigin to to manufacture, the latter does not.
  • Added a constant and accessor for the blob protocol scheme on the BlobURL class.

No new tests are added since this is a cleanup.

  • bindings/js/SerializedScriptValue.cpp: (WebCore::CloneDeserializer::readFile): (WebCore::CloneDeserializer::readTerminal):
  • bindings/v8/SerializedScriptValue.cpp: (WebCore::ZigZag::Reader::readBlob): (WebCore::ZigZag::Reader::readFile): (WebCore::ZigZag::Reader::readFileList):
  • dom/ScriptExecutionContext.cpp: (WebCore::ScriptExecutionContext::~ScriptExecutionContext): (WebCore::ScriptExecutionContext::createPublicBlobURL): (WebCore::ScriptExecutionContext::revokePublicBlobURL):
  • dom/ScriptExecutionContext.h:
  • fileapi/Blob.cpp: (WebCore::Blob::Blob): (WebCore::Blob::~Blob): (WebCore::Blob::slice):
  • fileapi/Blob.h: (WebCore::Blob::create): (WebCore::Blob::url):
  • fileapi/Blob.idl:
  • fileapi/BlobBuilder.cpp: (WebCore::BlobBuilder::getBlob):
  • fileapi/BlobBuilder.h:
  • fileapi/BlobBuilder.idl:
  • fileapi/BlobURL.cpp: (WebCore::BlobURL::createPublicURL): (WebCore::BlobURL::createInternalURL): (WebCore::BlobURL::getOrigin): (WebCore::BlobURL::getIdentifier): (WebCore::BlobURL::createBlobURL):
  • fileapi/BlobURL.h: (WebCore::BlobURL::blobProtocol): (WebCore::BlobURL::BlobURL):
  • fileapi/File.cpp: (WebCore::File::File):
  • fileapi/File.h: (WebCore::File::create):
  • fileapi/FileReader.cpp: Register a public url to perform the read. (WebCore::FileReader::cleanup): (WebCore::FileReader::start): (WebCore::FileReader::didFinishLoading): (WebCore::FileReader::failed):
  • fileapi/FileReader.h: Added m_urlForReading data member.
  • fileapi/FileReaderSync.cpp: (WebCore::FileReaderSync::read): Register a public url to perform the read.
  • fileapi/ThreadableBlobRegistry.cpp: (WebCore::ThreadableBlobRegistry::registerBlobURL): (WebCore::ThreadableBlobRegistry::unregisterBlobURL):
  • fileapi/ThreadableBlobRegistry.h:
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::appendFormData): (WebCore::HTMLInputElement::setFileListFromRenderer):
  • page/SecurityOrigin.cpp: Use BlobURL.blobProtocol(). (WebCore::SecurityOrigin::create): (WebCore::SecurityOrigin::canRequest): (WebCore::SecurityOrigin::canDisplay):
  • platform/chromium/ClipboardChromium.cpp: (WebCore::ClipboardChromium::files):
  • platform/gtk/ClipboardGtk.cpp: (WebCore::ClipboardGtk::files):
  • platform/mac/ClipboardMac.mm: (WebCore::ClipboardMac::files):
  • platform/win/ClipboardWin.cpp: (WebCore::ClipboardWin::files):
09:16 Changeset [67207] by xan@webkit.org

2010-09-10 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

GDK_DISPLAY was removed in GTK+ 3.x, re-declare it when built
against that.

  • platform/gtk/GtkVersioning.h:
09:16 Changeset [67206] by xan@webkit.org

WebCore:

2010-09-10 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

Fix compilation with GTK+ 3.x.

GDK key macros were renamed from GDK_FOO to GDK_KEY_FOO, we need
to include the compat header provided if we want to keep using the
old names.

  • platform/gtk/GtkVersioning.h: add the compatibility header.
  • platform/gtk/KeyEventGtk.cpp: include GtkVersioning.h

WebKit/gtk:

2010-09-10 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

Fix compilation with GTK+ 3.x.

GDK key macros were renamed from GDK_FOO to GDK_KEY_FOO, we need
to include the compat header provided if we want to keep using the
old names.

  • WebCoreSupport/FullscreenVideoController.cpp: include GtkVersioning.h
09:13 Changeset [67205] by vestbo@webkit.org

Skip a few media tests that started randomly failing after r66961

Reviewed by Eric Carlson.

  • platform/mac-leopard/Skipped:
09:03 Changeset [67204] by tonyg@chromium.org

2010-09-09 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Eric Seidel.

Factor out the NestingLevelIncrementer
https://bugs.webkit.org/show_bug.cgi?id=45471

No new tests because no new functionality.

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/parser/HTMLDocumentParser.cpp:
  • html/parser/HTMLDocumentParser.h:
  • html/parser/HTMLScriptRunner.cpp:
  • html/parser/NestingLevelIncrementer.h: Added. (WebCore::NestingLevelIncrementer::NestingLevelIncrementer): (WebCore::NestingLevelIncrementer::~NestingLevelIncrementer):
09:02 Changeset [67203] by zimmermann@webkit.org

2010-09-10 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Fix wrong gtk baseline for select-x-list-1.svg.

  • platform/gtk/svg/text/select-x-list-1-expected.txt:
08:50 Changeset [67202] by aroben@apple.com

Don't crash when a frame is destroyed after the UI process has disconnected

Fixes <http://webkit.org/b/45535> <rdar://problem/8412928> Crash in
WebProcess::removeWebFrame on exit with WebKit2 (Release builds only)

Reviewed by Darin Adler.

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::removeWebFrame): Null-check m_connection before
dereferencing it.

08:47 Changeset [67201] by mrobinson@webkit.org

2010-09-10 Martin Robinson <mrobinson@igalia.com>

Slight skipped list reorganization.

  • platform/gtk/Skipped: Group one more test in the beginDragWithFiles section.
08:35 Changeset [67200] by zimmermann@webkit.org

2010-09-10 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

SVG text chunk concept needs to be integrated in the InlineBox structure
https://bugs.webkit.org/show_bug.cgi?id=45533

Begin rewriting the SVG text layout code. As first step move the text chunk concept right into the inline box structure.
This obsoletes the whole text chunk part concept (see SVGTextChunkLayoutInfo.h for details), and will soon simplify the
whole layout code a lot. Previously we hacked around the fact that a single InlineTextBox could contain multiple text chunks
For example: <text x="20 30 40">ABC</text> only led to the creation of one InlineTextBox containing three chunks. When
painting such an InlineTextBox, we had to do nasty hacks (same for text selection etc.)


This is finally fixed by incorporating the knownledge about text chunks into the line layout algorithm.
Note, this has no impact on HTML at all, no worries.

It's even required to do it this way as BiDi reordering shouldn't happen across text chunks.
These are only the first bits, and currently slows down text layouting. Follow-up patches will remove the old layout
algorithm, and will rely on the stored SVGTextLayoutAttributes in the RenerSVGInlineText renderers (instead of computing again).

  • Android.mk: Add rendering/svg/SVGTextLayoutAttributes.* & rendering/svg/SVGTextLayoutBuilder.* to build.
  • CMakeLists.txt: Ditto.
  • GNUmakefile.am: Ditto.
  • WebCore.gyp/WebCore.gyp: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.vcproj/WebCoreCommon.vsprops: Ditto. (Recognize new rendering/svg directory.)
  • WebCore.vcproj/copyForwardingHeaders.cmd: Ditto. (Copy forwarding headers from rendering/svg directory.)
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • rendering/RenderBlockLineLayout.cpp: This is the key of the new concept, take text chunks into account when building the InlineBox structure. (WebCore::RenderBlock::findNextLineBreak): Split midpointState, if we encounter the beginning of a new text chunk.
  • rendering/RenderObject.h: (WebCore::RenderObject::isSVGInline): New method, which will be used to identify RenderSVGInline objects.
  • rendering/RenderSVGInline.h: (WebCore::RenderSVGInline::isSVGInline): Return true.
  • rendering/RenderSVGInlineText.cpp: (WebCore::RenderSVGInlineText::linesBoundingBox): Overriden, to simplify the calculations for SVG. (WebCore::RenderSVGInlineText::characterStartsNewTextChunk): Determines wheter the given position starts a new text chunk.
  • rendering/RenderSVGInlineText.h: (WebCore::RenderSVGInlineText::storeLayoutAttributes): Stores the layout attributes calculated in the text layout process (will be used everywhere in follow-up patches).
  • rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::layout): Invoke SVGTextLayoutBuilder before creating the inline box tree, so we can decide which characters start new text chunks.
  • rendering/RenderText.h: Made linesBoundingBox() virtual so RenderSVGInlineText can override it.
  • rendering/svg: Added.
  • rendering/svg/SVGTextLayoutAttributes.cpp: Added. Holds x/y/dx/dy/rotate values and all kerning/ligature information used during layout.
  • rendering/svg/SVGTextLayoutAttributes.h: Added.
  • rendering/svg/SVGTextLayoutBuilder.cpp: Added.
  • rendering/svg/SVGTextLayoutBuilder.h: Added.

2010-09-10 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

SVG text chunk concept needs to be integrated in the InlineBox structure
https://bugs.webkit.org/show_bug.cgi?id=45533

Updated all tests containing text chunks, to reflect the fact that more SVGInlineTextBoxes are created now.
All 'startOffset' dumps now begin at 0, indicating that there's only one chunk contained in a single SVGInlineTextBox.
These dumps will be removed in follow-up patches, as they don't make any sense anymore in the new concept.

  • platform/gtk/svg/text/select-x-list-1-expected.txt:
  • platform/gtk/svg/text/select-x-list-2-expected.txt:
  • platform/gtk/svg/text/select-x-list-3-expected.txt:
  • platform/gtk/svg/text/select-x-list-4-expected.txt:
  • platform/gtk/svg/text/select-x-list-with-tspans-1-expected.txt:
  • platform/gtk/svg/text/select-x-list-with-tspans-2-expected.txt:
  • platform/gtk/svg/text/select-x-list-with-tspans-3-expected.txt:
  • platform/gtk/svg/text/select-x-list-with-tspans-4-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-40-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-text-04-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-text-05-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-text-06-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-text-07-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-tspan-01-b-expected.txt:
  • platform/mac/svg/batik/text/textAnchor2-expected.txt:
  • platform/mac/svg/batik/text/textAnchor3-expected.txt:
  • platform/mac/svg/batik/text/textLayout-expected.txt:
  • platform/mac/svg/batik/text/textLayout2-expected.txt:
  • platform/mac/svg/batik/text/textOnPathSpaces-expected.txt:
  • platform/mac/svg/batik/text/textPosition-expected.txt:
  • platform/mac/svg/batik/text/textPosition2-expected.txt:
  • platform/mac/svg/custom/text-letter-spacing-expected.txt:
  • platform/mac/svg/custom/text-x-dx-lists-expected.txt:
  • platform/mac/svg/custom/text-x-override-in-tspan-child-expected.txt:
  • platform/mac/svg/text/select-x-list-1-expected.txt:
  • platform/mac/svg/text/select-x-list-2-expected.txt:
  • platform/mac/svg/text/select-x-list-3-expected.txt:
  • platform/mac/svg/text/select-x-list-4-expected.txt:
  • platform/mac/svg/text/select-x-list-with-tspans-1-expected.txt:
  • platform/mac/svg/text/select-x-list-with-tspans-2-expected.txt:
  • platform/mac/svg/text/select-x-list-with-tspans-3-expected.txt:
  • platform/mac/svg/text/select-x-list-with-tspans-4-expected.txt:
  • platform/mac/svg/text/text-text-04-t-expected.txt:
  • platform/mac/svg/text/text-text-05-t-expected.txt:
  • platform/mac/svg/text/text-text-06-t-expected.txt:
  • platform/mac/svg/text/text-text-07-t-expected.txt:
  • platform/mac/svg/text/text-tspan-01-b-expected.txt:
  • svg/custom/glyph-transformation-with-hkern-expected.txt:
  • platform/qt/svg/text/select-x-list-1-expected.txt:
  • platform/qt/svg/text/select-x-list-2-expected.txt:
  • platform/qt/svg/text/select-x-list-3-expected.txt:
  • platform/qt/svg/text/select-x-list-4-expected.txt:
  • platform/qt/svg/text/select-x-list-with-tspans-1-expected.txt:
  • platform/qt/svg/text/select-x-list-with-tspans-2-expected.txt:
  • platform/qt/svg/text/select-x-list-with-tspans-3-expected.txt:
  • platform/qt/svg/text/select-x-list-with-tspans-4-expected.txt:
07:41 Changeset [67199] by ossy@webkit.org

Unreviewed fix after r67085.

  • WebCore.pro: Fix previously moved filenames.
07:30 Changeset [67198] by abarth@webkit.org

2010-09-10 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Inline FrameLoader::committedLoad into its one caller
https://bugs.webkit.org/show_bug.cgi?id=45481

This saves one round-trip through the FrameLoader when loading
documents.

  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::commitLoad):
  • loader/FrameLoader.cpp:
  • loader/FrameLoader.h:
07:05 Changeset [67197] by commit-queue@webkit.org

2010-09-10 Patrick Gansterer <paroga@paroga.com>

Reviewed by Adam Roben.

[WINCE] Remove ImageBuffer::toDataURL implementation
https://bugs.webkit.org/show_bug.cgi?id=45478

At the moment ImageBuffer::toDataURL uses JPEGEncoder.h and PNGEncoder.h.
Both files are not in the repository. So remove the implementation for now.

  • platform/graphics/wince/ImageBufferWince.cpp: (WebCore::ImageBuffer::toDataURL):
06:44 Changeset [67196] by antonm@chromium.org

2010-09-10 Anton Muhin <antonm@chromium.org>

Unreview fixed.

Remove duplicate test expectations for media/media-can-play-mpeg4-video.html.

06:36 Changeset [67195] by apavlov@chromium.org

2010-09-10 Alexander Pavlov <apavlov@chromium.org>

Unreviewed, build fix.

  • inspector/elements-panel-rewrite-href.html:
05:54 Changeset [67194] by andreas.kling@nokia.com

2010-09-10 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Antonio Gomes.

WebGL: Fix GCC warnings about suggested parentheses around && within

https://bugs.webkit.org/show_bug.cgi?id=45534

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::getVertexAttrib): (WebCore::WebGLRenderingContext::readPixels): (WebCore::WebGLRenderingContext::texParameter): (WebCore::WebGLRenderingContext::handleNPOTTextures):
05:50 Changeset [67193] by hans@chromium.org

2010-09-10 Hans Wennborg <hans@chromium.org>

Reviewed by Jeremy Orlow.

Un-skip DeviceOrientation layout tests for Chromium.
https://bugs.webkit.org/show_bug.cgi?id=45531

fast/dom/DeviceOrientation/window-property.html and
fast/dom/Window/window-properties-device-orientation.html need to be
rebaselined, which will be done in a subsequent patch.

  • platform/chromium/test_expectations.txt:
05:28 Changeset [67192] by antonm@chromium.org

2010-09-10 Anton Muhin <antonm@chromium.org>

Reviewed by Kent Tamura.

[Chromium] media/media-can-play-mpeg4-video.html fails under Chromium
https://bugs.webkit.org/show_bug.cgi?id=45102

Chromium is not going to support mpeg, so media/media-can-play-mpeg4-video.html
is expected to fail.

  • platform/chromium/test_expectations.txt:
05:08 Changeset [67191] by apavlov@chromium.org

2010-09-09 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Add navigation items into the Elements panel context menu.

For all anchors that have the class of "webkit-html-resource-link" or "webkit-html-external-link",
a custom context menu with the items "Open Link in New Window" (invokes InspectorBackend.openInInspectedWindow() with
the related URL) and "Open Link in Resources Panel" (opens the related resource in the Resources panel) is shown
(the latter item is displayed only if the corresponding resource is known to the Web Inspector).
https://bugs.webkit.org/show_bug.cgi?id=34250

  • English.lproj/localizedStrings.js:
  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.populateHrefContextMenu):
  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeOutline.prototype._contextMenuEventFired): (WebInspector.ElementsTreeElement.prototype._attributeHTML):
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype._contextMenuEventFired):
  • inspector/front-end/inspector.js: (WebInspector.openResource): (WebInspector.resourceURLForRelatedNode):
05:01 Changeset [67190] by andreas.kling@nokia.com

2010-09-10 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Tor Arne Vestbø.

[Qt] Unskip canvas/philip/tests/2d.text.draw.fontface.repeat.html

This test was fixed by <http://trac.webkit.org/changeset/62016>

  • platform/qt/Skipped:
04:48 Changeset [67189] by zherczeg@webkit.org

An individual renderer should be assigned to each SVGFE*Element class
https://bugs.webkit.org/show_bug.cgi?id=43954

Reviewed by Nikolas Zimmermann.

Updating the description of the following test (it does not fail anymore):

  • platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-lighting-color-css-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-lighting-color-css-prop-expected.png:
  • svg/dynamic-updates/SVGFEDiffuseLightingElement-lighting-color-css-prop-expected.txt:
  • svg/dynamic-updates/script-tests/SVGFEDiffuseLightingElement-lighting-color-css-prop.js:
04:36 Changeset [67188] by darin@apple.com

2010-09-08 Darin Adler <darin@apple.com>

Reviewed by Adam Barth.

Move functions from Frame to Editor as planned
https://bugs.webkit.org/show_bug.cgi?id=45218

  • src/ContextMenuClientImpl.cpp: (WebKit::selectMisspelledWord): (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::find): (WebKit::WebFrameImpl::stopFinding): (WebKit::WebFrameImpl::scopeStringMatches):
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::caretOrSelectionBounds): Changed call sites to use editor().
03:57 Changeset [67187] by commit-queue@webkit.org

2010-09-10 Kwang Yul Seo <skyul@company100.net>

Reviewed by James Robinson.

Make sure skia is not Chromium specific
https://bugs.webkit.org/show_bug.cgi?id=39672

Move Image::loadPlatformResource to platform/graphics/chromium/ImageChromium.cpp.
Other ports can use ImageSkia.cpp.

No new tests because this is pure refacotring.

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • platform/graphics/chromium/ImageChromium.cpp: Added. (WebCore::Image::loadPlatformResource):
  • platform/graphics/skia/ImageSkia.cpp:
03:31 Changeset [67186] by ukai@chromium.org

Unreviewed. expectations update.

fast/dom/replaceChild.html image failure.

  • platform/chromium/test_expectations.txt:
03:18 Changeset [67185] by loislo@chromium.org

2010-09-09 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Joseph Pecoraro.

WebInspector: Selecting 'inspect element' always shows body in inspector instead of clicked element.

  1. Open any page
  2. Right-click on any element, select "Inspect Element"
  3. Web Inspector is opened but the <body> element (for HTML) is focused rather than the selected element
  4. Inspect the Web Inspector. An error message is logged in the console.

The regression was introduced in http://trac.webkit.org/changeset/66012 - focusNode() is invoked in
InspectorController::populateScriptObjects() before the main document is set for the InspectorDOMAgent
instance (which makes focusNode() bail out prematurely).

https://bugs.webkit.org/show_bug.cgi?id=45374

  • inspector/InspectorController.cpp: (WebCore::InspectorController::populateScriptObjects):
03:04 Changeset [67184] by commit-queue@webkit.org

2010-09-10 Cris Neckar <cdn@chromium.org>

Reviewed by Chris Fleizach.

Test for null deref in RenderBlock::updateFirstLetter().
https://bugs.webkit.org/show_bug.cgi?id=45404

  • fast/dom/firstletter-tablecell-crash-expected.txt: Added.
  • fast/dom/firstletter-tablecell-crash.html: Added.

2010-09-10 Cris Neckar <cdn@chromium.org>

Reviewed by Chris Fleizach.

Null deref in RenderBlock::updateFirstLetter(). Check for null psuedo style.
https://bugs.webkit.org/show_bug.cgi?id=45404

Test: fast/dom/firstletter-tablecell-crash.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::updateFirstLetter):
02:45 Changeset [67183] by commit-queue@webkit.org

2010-09-10 Cris Neckar <cdn@chromium.org>

Reviewed by Chris Fleizach.

Test for null deref in RenderBlock::findNextLineBreak().
https://bugs.webkit.org/show_bug.cgi?id=45350

  • fast/dom/firstline-fixed-crash-expected.txt: Added.
  • fast/dom/firstline-fixed-crash.html: Added.

2010-09-10 Cris Neckar <cdn@chromium.org>

Reviewed by Chris Fleizach.

Null deref in RenderBlock::findNextLineBreak(). Check for null style with
first-line style and fixed position.
https://bugs.webkit.org/show_bug.cgi?id=45350

Test: fast/dom/firstline-fixed-crash.html

  • rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::findNextLineBreak):
02:12 Changeset [67182] by eric@webkit.org

2010-09-10 Eric Seidel <eric@webkit.org>

Reviewed by Dimitri Glazkov.

Remove support for non-lazy attach and fix frames to load from insertedIntoDocument instead of attach
https://bugs.webkit.org/show_bug.cgi?id=45365

  • fast/dom/beforeload/remove-frame-in-beforeload-listener.html:
    • Add a comment to make clear that this test intentionally does not cancel the load in the beforeload event, but rather relies on WebCore's own Node::willRemove() implementation to cancel the load when the frame is removed. (The load is not actually directly canceled per say, but the loading logic checks to see if the frame is still in the frame tree right after creating the frame and aborts if its not. HTMLFrameOwnerElement::willRemove clears the frame owner pointer causing the frame to be removed from the tree.)

2010-09-10 Eric Seidel <eric@webkit.org>

Reviewed by Dimitri Glazkov.

Remove support for non-lazy attach and fix frames to load from insertedIntoDocument instead of attach
https://bugs.webkit.org/show_bug.cgi?id=45365

This change is the last piece of the puzzle which was preventing us from
removing all eager-attach logic and moving WebCore to using an entirely
recalcStyle-driven, on-demand renderer creation system, instead of every
element being synchronously attached during parsing, regardless of whether
it was ever going to be displayed or not.

This does not change the places we call lazyAttach vs. attach. This only
changes the behavior of frame/plugin elements when lazyAttach is called.
Previously lazyAttach would eager-attach those elements (and their ancestors)
because they were marked as canLazyAttach() { return false; }.

This is a very tricky change, please review carefully.

Mostly I'm moving logic which used to be in attach() into
insertedIntoDocument. Once it was there, there was no longer any reason
why frame elements couldn't lazyAttach, thus removing the need
for the non-lazy attach code path entirely.
We've not yet converted all callsites over to using lazyAttach() instead
of attach() however.

In order to move frame loading logic into insertedIntoDocument
instead of attach, I needed to make sure that any javascript calls
during the load would see an attached element. Thus I needed to mark
the element as needing style resolve so that it would attach itself
if needed.

I was not able to just call lazyAttach() from insertedIntoDocument directly
due to two conflicting assumptions in the rendering tree:

  1. ContainerNode::attach() assumes its "safe" to call attach on all children without checking first if the child is already attached. This seems sane since its strange to think of a subtree as being attached w/o ancestors already being attached. Although it is a hard rule that subtrees may not have renderers w/o ancestors also having renderers, I do not believe it's a hard rule that subtrees may not be attached. Remember, attached() does not imply renderer()! It's possible ContainerNode::attach()'s assumption is wrong here.
  2. Node::attach() asserts !attached(). This makes sense and I would not want to remove this assert, however it means that if insertedIntoDocument were to call lazyAttach() (thus marking the element as attached()) then all callers would need to check if the element was already attached after insertedIntoDocument (called by appendChild, parserAppendChild, etc.) before calling attach or lazyAttach(). The following example: element.innerHTML = "<span><iframe></span>" is one case where this ASSERT would be hit if insertedIntoDocument called lazyAttach, since ContainerNode::attach() (called on the span by in appendChild(DocumentFragment) code) does not check if iframe is already attached.

Note: One subtle change here is that synchronous javascript which results
from javascript: or beforeload is now run as part of insertedIntoDocument
(thus any insert/append call *even* parserAddChild) instead of being
run during attach (technically in the post-attach callbacks).

This is covered by numerous layout tests.

  • dom/ContainerNode.cpp: (WebCore::willRemoveChild): (WebCore::willRemoveChildren):
    • Since insertedIntoDocument starts a load and yet does not mark the element as attached, we need to always call willRemove(). See note above as to why we don't just mark attached() in insertedIntoDocument.
  • dom/Node.cpp: (WebCore::Node::markAncestorsWithChildNeedsStyleRecalc):
    • Share some code between lazyAttach and setNeedsStyleRecalc.

(WebCore::Node::setNeedsStyleRecalc):

  • Use the new markAncestorsWithChildNeedsStyleRecalc

(WebCore::Node::lazyAttach):

  • Remove the non-lazy code path, and use markAncestorsWithChildNeedsStyleRecalc.
  • Add an option to lazyAttach without marking attached(), used by HTMLFrameElementBase::insertedIntoDocument.
  • dom/Node.h:
  • html/HTMLFrameElementBase.cpp:
    • m_shouldOpenURLAfterAttach is no longer needed, yay!
    • m_checkAttachedTimer no longer has anything to do with attached(), so renamed it. I also documented that the newly named m_checkInDocumentTimer is all about the "magic iframe" performance quirk. (Which is actually speced in HTML5). I was initially baffled by this code, so I documented it.

(WebCore::HTMLFrameElementBase::HTMLFrameElementBase)
(WebCore::HTMLFrameElementBase::insertedIntoDocument):

  • This is the meat of this change, see discussion above.

(WebCore::HTMLFrameElementBase::attach):

  • Code deleted or moved to insertedIntoDocument.

(WebCore::HTMLFrameElementBase::width):

  • Fixed a bug in height()/width() which was probably causing crashes and was causing incorrect behavior after this change. renderBox() is not necessarily valid unless layout is up to date. Updating layout, can cause renderBox() to go invalid, thus this could have been a null-pointer crash.

(WebCore::HTMLFrameElementBase::height): see width()
(WebCore::HTMLFrameElementBase::setRemainsAliveOnRemovalFromTree): Timer rename.
(WebCore::HTMLFrameElementBase::checkInDocumentTimerFired): Timer rename.

  • html/HTMLFrameElementBase.h:
  • html/HTMLFrameOwnerElement.cpp: (WebCore::HTMLFrameOwnerElement::willRemove):
    • Disconnecting the owner element removes the frame from the frame tree. frameDetached() calls Page::frameCount which expects that the frame is already gone at this point and asserts when it's not. It's unclear how this worked before, except that the frame removal was likely done in the post-attach callback, so the frameCount was wrong (too high) during frameDetached(), but was fixed up in the post-detach callback.
  • html/parser/HTMLConstructionSite.cpp: (WebCore::HTMLConstructionSite::attachAtSite):
    • Simplified this code, and added a check for the case when the node was already removed. Since the load logic is now run during insertedIntoDocument instead of attach(), synchronous javascript is now running during insertedIntoDocument and we need to make sure that the child is still in the tree.
02:04 Changeset [67181] by tkent@chromium.org

2010-09-10 Kent Tamura <tkent@chromium.org>

Unreviewed, test expectation update.

  • platform/chromium/drt_expectations.txt: Add some comments and sort.
01:16 Changeset [67180] by rniwa@webkit.org

2010-09-10 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed.

Added editing/selection/doubleclick-inline-first-last-contenteditable.html to the qt's skipped list.
See https://bugs.webkit.org/show_bug.cgi?id=45525 for the detail.

  • platform/qt/Skipped:
00:48 Changeset [67179] by dpranke@chromium.org

2010-09-10 Dirk Pranke <dpranke@chromium.org>

Unreviewed, rolling out r67178.
http://trac.webkit.org/changeset/67178
https://bugs.webkit.org/show_bug.cgi?id=45524

re-roll-out patch to put original changes back in

  • fast/replaced/object-param-url-control-char.html:
  • fast/replaced/object-with-embed-url-param-expected.txt:
  • fast/replaced/object-with-embed-url-param.html:

2010-09-10 Dirk Pranke <dpranke@chromium.org>

Unreviewed, rolling out r67178.
http://trac.webkit.org/changeset/67178
https://bugs.webkit.org/show_bug.cgi?id=45524

re-roll-out patch to put original changes back in

  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::parametersForPlugin): (WebCore::HTMLObjectElement::updateWidget):
  • loader/SubframeLoader.cpp: (WebCore::SubframeLoader::resourceWillUsePlugin):
  • loader/SubframeLoader.h:
00:45 Changeset [67178] by dpranke@chromium.org

2010-09-10 Dirk Pranke <dpranke@chromium.org>

Reviewed by Kent Tamura.

roll out r66992 and r66997 - possibly introduced a perf slowdown in chromium tests
https://bugs.webkit.org/show_bug.cgi?id=45524

  • fast/replaced/object-param-url-control-char.html:
  • fast/replaced/object-with-embed-url-param-expected.txt:
  • fast/replaced/object-with-embed-url-param.html:

2010-09-10 Dirk Pranke <dpranke@chromium.org>

Reviewed by Kent Tamura.

roll out r66992 and r66997 - possibly introduced a perf slowdown in chromium tests
https://bugs.webkit.org/show_bug.cgi?id=45524

  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::parametersForPlugin): (WebCore::HTMLObjectElement::updateWidget):
  • loader/SubframeLoader.cpp: (WebCore::SubframeLoader::requestFrame):
  • loader/SubframeLoader.h:
00:16 Changeset [67177] by hans@chromium.org

2010-09-09 Hans Wennborg <hans@chromium.org>

Reviewed by Jeremy Orlow.

Hook up LayoutTestController.setMockDeviceOrientation() in Chromium DumpRenderTree.
https://bugs.webkit.org/show_bug.cgi?id=45460

This enables DumpRenderTree to run layout tests for DeviceOrientation.

Also declare the LayoutTestController destructor out-of-line.
Otherwise the implicit destructor would cause compiler errors because
of the OwnPtr<WebKit::WebDeviceOrientationClientMock> member.

  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::~LayoutTestController): (LayoutTestController::setMockDeviceOrientation): (LayoutTestController::deviceOrientationClient):
  • DumpRenderTree/chromium/LayoutTestController.h:
  • DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::deviceOrientationClient):
  • DumpRenderTree/chromium/WebViewHost.h:
00:13 Changeset [67176] by rniwa@webkit.org

2010-09-10 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Tony Chang.

Extract the code to find special ancestors in createMarkup into a function
https://bugs.webkit.org/show_bug.cgi?id=45449

Extracted the code to find special common ancestors in createMarkup as highestAncestorToWrapMarkup.
Also isolated the code to find ancestors required to retain structure and appearance into
ancestorToRetainStructureAndAppearance.

No new tests are added since this is a cleanup.

  • editing/markup.cpp: (WebCore::ancestorToRetainStructureAndAppearance): Added. (WebCore::propertyMissingOrEqualToNone): Moved. (WebCore::isElementPresentational): Moved. (WebCore::shouldIncludeWrapperForFullySelectedRoot): Added. isSpecialAncestorBlock is merged into this function. (WebCore::highestAncestorToWrapMarkup): Extracted from createMarkup. (WebCore::createMarkup): Calls highestAncestorToWrapMarkup.
00:03 Changeset [67175] by rniwa@webkit.org

2010-09-10 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed.

Added editing/spelling/spelling-backspace-between-lines.html to the skipped list for WebKit2
since the test uses textInputController, which hasn't been implemented yet in WebKitTestRunner.

  • platform/mac-wk2/Skipped:
Note: See TracTimeline for information about the timeline view.