Timeline


and

09/20/10:

23:54 Changeset [67928] by philn@webkit.org
  • 38 edits
    2 adds in trunk

2010-09-20 Philippe Normand <pnormand@igalia.com>

Reviewed by Eric Carlson.

[GTK] enhanced context menu for media elements
https://bugs.webkit.org/show_bug.cgi?id=45021

New items in the media Element context menu:

  • play/pause
  • mute/unmute
  • controls display control
  • switch to fullscreen (for video only)
  • loop playback control
  • copy media url to clipboard
  • open in new window

Test: media/context-menu-actions.html

  • page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected):
  • platform/ContextMenu.cpp: (WebCore::ContextMenu::populate): (WebCore::ContextMenu::checkOrEnableIfNeeded):
  • platform/ContextMenuItem.h:
  • platform/LocalizationStrategy.h:
  • platform/LocalizedStrings.cpp: (WebCore::contextMenuItemTagOpenVideoInNewWindow): (WebCore::contextMenuItemTagOpenAudioInNewWindow): (WebCore::contextMenuItemTagCopyVideoLinkToClipboard): (WebCore::contextMenuItemTagCopyAudioLinkToClipboard): (WebCore::contextMenuItemTagToggleMediaControls): (WebCore::contextMenuItemTagToggleMediaLoop): (WebCore::contextMenuItemTagEnterVideoFullscreen): (WebCore::contextMenuItemTagMediaPlay): (WebCore::contextMenuItemTagMediaPause): (WebCore::contextMenuItemTagMediaMute):
  • platform/LocalizedStrings.h:
  • platform/android/LocalizedStringsAndroid.cpp: (WebCore::contextMenuItemTagOpenVideoInNewWindow): (WebCore::contextMenuItemTagOpenAudioInNewWindow): (WebCore::contextMenuItemTagCopyVideoLinkToClipboard): (WebCore::contextMenuItemTagCopyAudioLinkToClipboard): (WebCore::contextMenuItemTagToggleMediaControls): (WebCore::contextMenuItemTagToggleMediaLoop): (WebCore::contextMenuItemTagEnterVideoFullscreen): (WebCore::contextMenuItemTagMediaPlay): (WebCore::contextMenuItemTagMediaPause): (WebCore::contextMenuItemTagMediaMute):
  • platform/brew/LocalizedStringsBrew.cpp: (WebCore::contextMenuItemTagOpenVideoInNewWindow): (WebCore::contextMenuItemTagOpenAudioInNewWindow): (WebCore::contextMenuItemTagCopyVideoLinkToClipboard): (WebCore::contextMenuItemTagCopyAudioLinkToClipboard): (WebCore::contextMenuItemTagToggleMediaControls): (WebCore::contextMenuItemTagToggleMediaLoop): (WebCore::contextMenuItemTagEnterVideoFullscreen): (WebCore::contextMenuItemTagMediaPlay): (WebCore::contextMenuItemTagMediaPause): (WebCore::contextMenuItemTagMediaMute):
  • platform/efl/LocalizedStringsEfl.cpp: (WebCore::contextMenuItemTagOpenVideoInNewWindow): (WebCore::contextMenuItemTagOpenAudioInNewWindow): (WebCore::contextMenuItemTagCopyVideoLinkToClipboard): (WebCore::contextMenuItemTagCopyAudioLinkToClipboard): (WebCore::contextMenuItemTagToggleMediaControls): (WebCore::contextMenuItemTagToggleMediaLoop): (WebCore::contextMenuItemTagEnterVideoFullscreen): (WebCore::contextMenuItemTagMediaPlay): (WebCore::contextMenuItemTagMediaPause): (WebCore::contextMenuItemTagMediaMute):
  • platform/gtk/ContextMenuItemGtk.cpp: (WebCore::gtkStockIDFromContextMenuAction):
  • platform/gtk/LocalizedStringsGtk.cpp: (WebCore::contextMenuItemTagOpenVideoInNewWindow): (WebCore::contextMenuItemTagOpenAudioInNewWindow): (WebCore::contextMenuItemTagCopyVideoLinkToClipboard): (WebCore::contextMenuItemTagCopyAudioLinkToClipboard): (WebCore::contextMenuItemTagToggleMediaControls): (WebCore::contextMenuItemTagToggleMediaLoop): (WebCore::contextMenuItemTagEnterVideoFullscreen): (WebCore::contextMenuItemTagMediaPlay): (WebCore::contextMenuItemTagMediaPause): (WebCore::contextMenuItemTagMediaMute):
  • platform/haiku/LocalizedStringsHaiku.cpp: (WebCore::contextMenuItemTagOpenVideoInNewWindow): (WebCore::contextMenuItemTagOpenAudioInNewWindow): (WebCore::contextMenuItemTagCopyVideoLinkToClipboard): (WebCore::contextMenuItemTagCopyAudioLinkToClipboard): (WebCore::contextMenuItemTagToggleMediaControls): (WebCore::contextMenuItemTagToggleMediaLoop): (WebCore::contextMenuItemTagEnterVideoFullscreen): (WebCore::contextMenuItemTagMediaPlay): (WebCore::contextMenuItemTagMediaPause): (WebCore::contextMenuItemTagMediaMute):
  • platform/wx/LocalizedStringsWx.cpp: (WebCore::contextMenuItemTagOpenVideoInNewWindow): (WebCore::contextMenuItemTagOpenAudioInNewWindow): (WebCore::contextMenuItemTagCopyVideoLinkToClipboard): (WebCore::contextMenuItemTagCopyAudioLinkToClipboard): (WebCore::contextMenuItemTagToggleMediaControls): (WebCore::contextMenuItemTagToggleMediaLoop): (WebCore::contextMenuItemTagEnterVideoFullscreen): (WebCore::contextMenuItemTagMediaPlay): (WebCore::contextMenuItemTagMediaPause): (WebCore::contextMenuItemTagMediaMute):
  • rendering/HitTestResult.cpp: (WebCore::HitTestResult::absoluteMediaURL): (WebCore::HitTestResult::mediaSupportsFullscreen): (WebCore::HitTestResult::mediaElement): (WebCore::HitTestResult::toggleMediaControlsDisplay): (WebCore::HitTestResult::toggleMediaLoopPlayback): (WebCore::HitTestResult::enterFullscreenForVideo): (WebCore::HitTestResult::mediaControlsEnabled): (WebCore::HitTestResult::mediaLoopEnabled): (WebCore::HitTestResult::mediaPlaying): (WebCore::HitTestResult::toggleMediaPlayState): (WebCore::HitTestResult::mediaHasAudio): (WebCore::HitTestResult::mediaMuted): (WebCore::HitTestResult::toggleMediaMuteState):
  • rendering/HitTestResult.h:

LayoutTests:

Reviewed by Eric Carlson.

[GTK] enhanced context menu for media elements
https://bugs.webkit.org/show_bug.cgi?id=45021

New test checking the actions that can be triggered by activating
the contex-menu of the media element. Skipped on mac, qt and win
because of lack of DRT support.

  • media/context-menu-actions-expected.txt: Added.
  • media/context-menu-actions.html: Added.
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:

WebKit:

Reviewed by Eric Carlson.

[GTK] enhanced context menu for media elements
https://bugs.webkit.org/show_bug.cgi?id=45021

Updated localizable strings.

  • English.lproj/Localizable.strings:

WebKit/chromium:

Reviewed by Eric Carlson.

[GTK] enhanced context menu for media elements
https://bugs.webkit.org/show_bug.cgi?id=45021

New localized strings for the media element context-menu.

  • src/LocalizedStrings.cpp: (WebCore::contextMenuItemTagOpenVideoInNewWindow): (WebCore::contextMenuItemTagOpenAudioInNewWindow): (WebCore::contextMenuItemTagCopyVideoLinkToClipboard): (WebCore::contextMenuItemTagCopyAudioLinkToClipboard): (WebCore::contextMenuItemTagToggleMediaControls): (WebCore::contextMenuItemTagToggleMediaLoop): (WebCore::contextMenuItemTagEnterVideoFullscreen): (WebCore::contextMenuItemTagMediaPlay): (WebCore::contextMenuItemTagMediaPause): (WebCore::contextMenuItemTagMediaMute):

WebKit/mac:

Reviewed by Eric Carlson.

[GTK] enhanced context menu for media elements
https://bugs.webkit.org/show_bug.cgi?id=45021

New localized strings for the media element context-menu.

  • WebCoreSupport/WebPlatformStrategies.h:
  • WebCoreSupport/WebPlatformStrategies.mm: (WebPlatformStrategies::contextMenuItemTagOpenVideoInNewWindow): (WebPlatformStrategies::contextMenuItemTagOpenAudioInNewWindow): (WebPlatformStrategies::contextMenuItemTagCopyVideoLinkToClipboard): (WebPlatformStrategies::contextMenuItemTagCopyAudioLinkToClipboard): (WebPlatformStrategies::contextMenuItemTagToggleMediaControls): (WebPlatformStrategies::contextMenuItemTagToggleMediaLoop): (WebPlatformStrategies::contextMenuItemTagEnterVideoFullscreen): (WebPlatformStrategies::contextMenuItemTagMediaPlay): (WebPlatformStrategies::contextMenuItemTagMediaPause): (WebPlatformStrategies::contextMenuItemTagMediaMute):

Webkit/qt:

Reviewed by Eric Carlson.

[GTK] enhanced context menu for media elements
https://bugs.webkit.org/show_bug.cgi?id=45021

  • WebCoreSupport/WebPlatformStrategies.cpp:
  • WebCoreSupport/WebPlatformStrategies.h: (WebPlatformStrategies::contextMenuItemTagOpenVideoInNewWindow): (WebPlatformStrategies::contextMenuItemTagOpenAudioInNewWindow): (WebPlatformStrategies::contextMenuItemTagCopyVideoLinkToClipboard): (WebPlatformStrategies::contextMenuItemTagCopyAudioLinkToClipboard): (WebPlatformStrategies::contextMenuItemTagToggleMediaControls) (WebPlatformStrategies::contextMenuItemTagToggleMediaLoop) (WebPlatformStrategies::contextMenuItemTagEnterVideoFullscreen) (WebPlatformStrategies::contextMenuItemTagMediaPlay) (WebPlatformStrategies::contextMenuItemTagMediaPause) (WebPlatformStrategies::contextMenuItemTagMediaMute)

WebKit/win:

Reviewed by Eric Carlson.

[GTK] enhanced context menu for media elements
https://bugs.webkit.org/show_bug.cgi?id=45021

New localized strings for the media element context-menu.

  • WebCoreSupport/WebPlatformStrategies.cpp: (WebPlatformStrategies::contextMenuItemTagOpenVideoInNewWindow): (WebPlatformStrategies::contextMenuItemTagOpenAudioInNewWindow): (WebPlatformStrategies::contextMenuItemTagCopyVideoLinkToClipboard): (WebPlatformStrategies::contextMenuItemTagCopyAudioLinkToClipboard): (WebPlatformStrategies::contextMenuItemTagToggleMediaControls): (WebPlatformStrategies::contextMenuItemTagToggleMediaLoop): (WebPlatformStrategies::contextMenuItemTagEnterVideoFullscreen): (WebPlatformStrategies::contextMenuItemTagMediaPlay): (WebPlatformStrategies::contextMenuItemTagMediaPause): (WebPlatformStrategies::contextMenuItemTagMediaMute):
  • WebCoreSupport/WebPlatformStrategies.h:

WebKit2:

Reviewed by Eric Carlson.

[GTK] enhanced context menu for media elements
https://bugs.webkit.org/show_bug.cgi?id=45021

New localized strings for the media element context-menu.

  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp: (WebKit::WebPlatformStrategies::contextMenuItemTagOpenVideoInNewWindow): (WebKit::WebPlatformStrategies::contextMenuItemTagOpenAudioInNewWindow): (WebKit::WebPlatformStrategies::contextMenuItemTagCopyVideoLinkToClipboard): (WebKit::WebPlatformStrategies::contextMenuItemTagCopyAudioLinkToClipboard): (WebKit::WebPlatformStrategies::contextMenuItemTagToggleMediaControls): (WebKit::WebPlatformStrategies::contextMenuItemTagToggleMediaLoop): (WebKit::WebPlatformStrategies::contextMenuItemTagEnterVideoFullscreen): (WebKit::WebPlatformStrategies::contextMenuItemTagMediaPlay): (WebKit::WebPlatformStrategies::contextMenuItemTagMediaPause): (WebKit::WebPlatformStrategies::contextMenuItemTagMediaMute): (WebKit::WebPlatformStrategies::contextMenuItemTagMediaUnMute):
  • WebProcess/WebCoreSupport/WebPlatformStrategies.h:

WebKitTools:

Reviewed by Eric Carlson.

[GTK] enhanced context menu for media elements
https://bugs.webkit.org/show_bug.cgi?id=45021

EventSender::contextClick() now returns an array of js
objects. Each object has a title property and a click() method.

  • DumpRenderTree/gtk/EventSender.cpp: (getMenuItemTitleCallback): (setMenuItemTitleCallback): (menuItemClickCallback): (getMenuItemClass): (contextClickCallback):
23:44 Changeset [67927] by darin@apple.com
  • 3 edits in trunk/BugsSite

2010-09-20 Darin Adler <darin@apple.com>

Reviewed by Adam Barth.

Add Preview button and link to bug to patch review bar
https://bugs.webkit.org/show_bug.cgi?id=46153

  • PrettyPatch/PrettyPatch.rb: Bump version number to make caches happy.
  • code-review.js: Added Preview button and link to bug.
22:44 Changeset [67926] by hayato@chromium.org
  • 2 edits in trunk/WebKitTools

2010-09-20 Hayato Ito <hayato@chromium.org>

Unreviewed.
Adding myself to the committers list.

  • Scripts/webkitpy/common/config/committers.py:
22:25 Changeset [67925] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-09-20 Kwang Yul Seo <skyul@company100.net>

Reviewed by Daniel Bates.

[BREWMP] Handle tab key
https://bugs.webkit.org/show_bug.cgi?id=46104

In Brew MP, AVK_FUNCTION is the key code for tab.
Process AVK_FUNCTION as tab in PlatformKeyboardEvent.

  • platform/brew/PlatformKeyboardEventBrew.cpp: (WebCore::keyIdentifierForBrewKeyCode): (WebCore::windowsKeyCodeForKeyEvent):
22:06 Changeset [67924] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2010-09-20 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium test_expectations.txt update.

All of the fill-mode tests that used to fail on Windows were fixed by
r67877. change-one-anim.html and combo-transform-translate+scale.html
haven't failed in the past 750 runs.

  • platform/chromium/test_expectations.txt:
21:50 Changeset [67923] by mihaip@chromium.org
  • 4 edits in trunk/LayoutTests

2010-09-20 Mihai Parparita <mihaip@chromium.org>

Unreviewed expectations update for Windows for r67898.

  • platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/win/fast/dom/prototype-inheritance-expected.txt:
  • platform/win/fast/js/global-constructors-expected.txt:
21:36 Changeset [67922] by commit-queue@webkit.org
  • 3 edits
    1 move in trunk/WebCore

2010-09-20 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r67918.
http://trac.webkit.org/changeset/67918
https://bugs.webkit.org/show_bug.cgi?id=46162

Broke chromium win compile (Requested by jamesr on #webkit).

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • platform/graphics/chromium/GlyphPageTreeNodeLinux.cpp: Renamed from WebCore/platform/graphics/skia/GlyphPageTreeNodeSkia.cpp. (WebCore::GlyphPage::fill):
21:27 Changeset [67921] by dbates@webkit.org
  • 2 edits in trunk/WebCore

2010-09-20 Daniel Bates <dbates@rim.com>

Reviewed by Dan Bernstein.

Cleanup: Extract common border radii expansion code in
RenderBoxModelObject::paintBoxShadow() into function
https://bugs.webkit.org/show_bug.cgi?id=45934

Extracted code for expanding and clamping the border radii
into common function to remove duplicate code.

No functionality was changed. So, no new tests.

  • rendering/RenderBoxModelObject.cpp: (WebCore::uniformlyExpandBorderRadii): Added. (WebCore::RenderBoxModelObject::paintBoxShadow): Moved common code to uniformlyExpandBorderRadii().
21:07 Changeset [67920] by dglazkov@chromium.org
  • 18 edits
    18 adds in trunk/LayoutTests

2010-09-20 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Ojan Vafai.

Create Chromium/Skia baselines for tests, affected by http://trac.webkit.org/changeset/65665.
https://bugs.webkit.org/show_bug.cgi?id=46062

  • platform/chromium-linux/svg/batik/paints/patternRegions-expected.checksum:
  • platform/chromium-linux/svg/batik/paints/patternRegions-expected.png:
  • platform/chromium-linux/svg/batik/paints/patternRegions-positioned-objects-expected.checksum: Added.
  • platform/chromium-linux/svg/batik/paints/patternRegions-positioned-objects-expected.png: Added.
  • platform/chromium-linux/svg/batik/paints/patternRegions-positioned-objects-expected.txt: Added.
  • platform/chromium-linux/svg/custom/js-late-pattern-and-object-creation-expected.checksum:
  • platform/chromium-linux/svg/custom/js-late-pattern-and-object-creation-expected.png:
  • platform/chromium-linux/svg/custom/js-late-pattern-creation-expected.checksum:
  • platform/chromium-linux/svg/custom/js-late-pattern-creation-expected.png:
  • platform/chromium-linux/svg/custom/pattern-incorrect-tiling-expected.checksum: Added.
  • platform/chromium-linux/svg/custom/pattern-incorrect-tiling-expected.png: Added.
  • platform/chromium-linux/svg/custom/pattern-incorrect-tiling-expected.txt: Added.
  • platform/chromium-linux/svg/custom/pattern-no-pixelation-expected.checksum: Added.
  • platform/chromium-linux/svg/custom/pattern-no-pixelation-expected.png: Added.
  • platform/chromium-linux/svg/custom/stroked-pattern-expected.checksum: Added.
  • platform/chromium-linux/svg/custom/stroked-pattern-expected.png: Added.
  • platform/chromium-win/svg/batik/paints/patternRegions-expected.checksum:
  • platform/chromium-win/svg/batik/paints/patternRegions-expected.png:
  • platform/chromium-win/svg/batik/paints/patternRegions-positioned-objects-expected.checksum: Added.
  • platform/chromium-win/svg/batik/paints/patternRegions-positioned-objects-expected.png: Added.
  • platform/chromium-win/svg/batik/paints/patternRegions-positioned-objects-expected.txt: Added.
  • platform/chromium-win/svg/custom/js-late-pattern-and-object-creation-expected.checksum:
  • platform/chromium-win/svg/custom/js-late-pattern-and-object-creation-expected.png:
  • platform/chromium-win/svg/custom/js-late-pattern-creation-expected.checksum:
  • platform/chromium-win/svg/custom/js-late-pattern-creation-expected.png:
  • platform/chromium-win/svg/custom/non-scaling-stroke-expected.checksum:
  • platform/chromium-win/svg/custom/non-scaling-stroke-expected.png:
  • platform/chromium-win/svg/custom/pattern-incorrect-tiling-expected.checksum: Added.
  • platform/chromium-win/svg/custom/pattern-incorrect-tiling-expected.png: Added.
  • platform/chromium-win/svg/custom/pattern-incorrect-tiling-expected.txt: Added.
  • platform/chromium-win/svg/custom/pattern-no-pixelation-expected.checksum: Added.
  • platform/chromium-win/svg/custom/pattern-no-pixelation-expected.png: Added.
  • platform/chromium-win/svg/custom/stroked-pattern-expected.checksum:
  • platform/chromium-win/svg/custom/stroked-pattern-expected.png:
  • platform/chromium/test_expectations.txt:
20:51 Changeset [67919] by thakis@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-09-20 Nico Weber <thakis@chromium.org>

Reviewed by James Robinson.

[chromium] Trivial clang warning fix
https://bugs.webkit.org/show_bug.cgi?id=46143

  • src/WebFileSystemCallbacksImpl.h:
20:45 Changeset [67918] by commit-queue@webkit.org
  • 3 edits
    1 move in trunk/WebCore

2010-09-20 Kwang Yul Seo <skyul@company100.net>

Reviewed by James Robinson.

Make sure skia is not Chromium specific
https://bugs.webkit.org/show_bug.cgi?id=39672

GGlyphPageTreeNodeLinux does not depend on Linux or Chromium.
Move GGlyphPageTreeNodeLinux to platform/graphics/skia and rename it to
GlyphPageTreeNodeSkia.cpp so that other ports can use it.

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • platform/graphics/chromium/GlyphPageTreeNodeLinux.cpp: Removed.
  • platform/graphics/skia/GlyphPageTreeNodeSkia.cpp: Added.
20:37 Changeset [67917] by kinuko@chromium.org
  • 9 edits in trunk/WebCore

2010-09-20 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by David Levin.

Add NoStaticTables attributes to IDLs of FileSystem API for Worker support
https://bugs.webkit.org/show_bug.cgi?id=46021

Added NoStaticTables attributes to IDLs except for ones for Callbacks.
(As NoStaticTables only affects non-callback interfaces.)

  • fileapi/DOMFileSystem.idl:
  • fileapi/DirectoryEntry.idl:
  • fileapi/DirectoryReader.idl:
  • fileapi/Entry.idl:
  • fileapi/EntryArray.idl:
  • fileapi/FileEntry.idl:
  • fileapi/Flags.idl:
  • fileapi/Metadata.idl:
20:24 Changeset [67916] by abarth@webkit.org
  • 10 edits in trunk/WebKitTools

2010-09-20 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

The tool member variable should be called _tool
https://bugs.webkit.org/show_bug.cgi?id=46160

Created by find-and-replace.

  • Scripts/webkitpy/tool/commands/download.py:
  • Scripts/webkitpy/tool/commands/openbugs.py:
  • Scripts/webkitpy/tool/commands/queries.py:
  • Scripts/webkitpy/tool/commands/queues.py:
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
  • Scripts/webkitpy/tool/commands/rebaseline.py:
  • Scripts/webkitpy/tool/commands/sheriffbot.py:
  • Scripts/webkitpy/tool/commands/upload.py:
  • Scripts/webkitpy/tool/multicommandtool.py:
20:08 Changeset [67915] by thakis@chromium.org
  • 3 edits in trunk/WebCore

2010-09-20 Nico Weber <thakis@chromium.org>

Reviewed by Adam Barth.

Fix "operands of ? are integers of different signs" clang warnings
https://bugs.webkit.org/show_bug.cgi?id=46157

  • platform/graphics/mac/ComplexTextController.cpp: (WebCore::ComplexTextController::advance):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::calcHeight):
19:52 Changeset [67914] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-09-20 Adam Barth <abarth@webkit.org>

I ran the tests before landing but ignored the fact that they failed. :(

  • Scripts/webkitpy/tool/commands/queues.py:
19:45 Changeset [67913] by abarth@webkit.org
  • 5 edits
    2 adds in trunk/WebKitTools

2010-09-20 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add a feeder queue that polls bugs.webkit.org for the commit-cluster
https://bugs.webkit.org/show_bug.cgi?id=46141

The feeder-queue polls bugs.webkit.org every 30 seconds and updates the
list of work items on the status server. The individual commit-cluster
nodes then grab the patches from the server and process them.

  • Scripts/webkitpy/tool/bot/feeders.py: Added.
  • Scripts/webkitpy/tool/bot/feeders_unittest.py: Added.
  • Scripts/webkitpy/tool/commands/queues.py:
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
  • Scripts/webkitpy/tool/commands/queuestest.py:
19:12 Changeset [67912] by vangelis@chromium.org
  • 3 edits in trunk/WebCore

2010-09-20 Vangelis Kokkevis <vangelis@chromium.org>

Unreviewed, rolling out r67906.
http://trac.webkit.org/changeset/67906
https://bugs.webkit.org/show_bug.cgi?id=46139

Change causes chromium to crash when switching pages

  • platform/graphics/chromium/ContentLayerChromium.h:
  • platform/graphics/chromium/LayerChromium.h:
19:07 Changeset [67911] by commit-queue@webkit.org
  • 3 edits in trunk/WebKitTools

2010-09-20 Leandro Pereira <leandro@profusion.mobi>

Reviewed by Darin Adler.

build-webkit: Add support for CMake build system
https://bugs.webkit.org/show_bug.cgi?id=44979

  • Scripts/build-webkit: Add "--efl" command-line option to build the EFL port of WebKit.
  • Scripts/webkitdirs.pm: Define buildCMakeProject() and buildEflCMakeProject() subroutines.
19:03 Changeset [67910] by commit-queue@webkit.org
  • 1 edit in trunk/WebKit/chromium

Update svn:ignore to ignore more Chromium specific files that are not part of the repository

18:51 Changeset [67909] by tonikitoo@webkit.org
  • 4 edits in trunk/WebCore

2010-09-19 Antonio Gomes <agomes@rim.com>

Reviewed by Ojan Vafai.

SelectionController::modify should ask EditingBehavior for platform specific behavior
https://bugs.webkit.org/show_bug.cgi?id=41975

As a follow up of the refactoring work in bug 39854, patch makes SelectionController::modify()
stop accessing EditingBehaviorType values directly, and replaces its use by the EditingBehavior class.

Since the "Settings*" parameter of the private SelectionController::modify() method becomes unneeded
with this change (it was used to query the editingBehaviorType), patch merges two modify() methods.

No behavior change, so no new tests.

  • editing/EditingBehavior.h: (WebCore::EditingBehavior::shouldAlwaysGrowSelectionWhenExtendingToBoundary):
  • editing/SelectionController.cpp: (WebCore::SelectionController::modify):
  • editing/SelectionController.h:
18:45 Changeset [67908] by atwilson@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed expectations update for r67898.

  • platform/chromium/fast/dom/prototype-inheritance-expected.txt:

Updated to reflect r67898.

18:38 Changeset [67907] by mihaip@chromium.org
  • 9 edits in trunk/LayoutTests

2010-09-20 Mihai Parparita <mihaip@chromium.org>

Reviewed by James Robinson.

Rebaseline tests after HashChangeEvent was added by r67898
https://bugs.webkit.org/show_bug.cgi?id=46155

GTK and Qt changes that mirror the changes from r67898, plus a missed
test window-property-descriptors from the original change.

  • fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/gtk/fast/dom/prototype-inheritance-expected.txt:
  • platform/gtk/fast/js/global-constructors-expected.txt:
  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-expected.txt:
  • platform/qt/fast/js/global-constructors-expected.txt:
18:35 Changeset [67906] by vangelis@chromium.org
  • 3 edits in trunk/WebCore

2010-09-20 Vangelis Kokkevis <vangelis@chromium.org>

Reviewed by James Robinson.

[chromium] Making destructors of LayerChromium and ContentLayerChromium virtual
so that the derived class' destructor code gets called.
https://bugs.webkit.org/show_bug.cgi?id=46139

  • platform/graphics/chromium/ContentLayerChromium.h:
  • platform/graphics/chromium/LayerChromium.h:
18:26 Changeset [67905] by dpranke@chromium.org
  • 9 edits in trunk/WebKitTools

2010-09-20 Dirk Pranke <dpranke@chromium.org>

Reviewed by Ojan Vafai.

new-run-webkit-tests: refactor command line args getting passed to DRT

This change cleans up some argument parsing between functions to get
rid of some overlapping data structures. There should be no functional
changes in this patch; it is pure refactoring in preparation for
landing the Chrome GPU port and adding a generic way to pass
args to DRT/TestShell.

https://bugs.webkit.org/show_bug.cgi?id=46135

  • Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
    • pass the options argument explicitly to the threads and drivers, also consolidate the passing of options to the driver.
    • pass options directly to process_output() to remove a couple parameters (minor cleanup).
  • Scripts/webkitpy/layout_tests/port/base.py:
    • pass the options argument to Port.create_driver().
  • Scripts/webkitpy/layout_tests/port/base_unittest.py:
    • update Port.create_driver() test
  • Scripts/webkitpy/layout_tests/port/chromium.py:
    • pass the options argument to Port.create_driver(), and clean up building of the cmd line for DRT.
  • Scripts/webkitpy/layout_tests/port/dryrun.py:
    • pass the options argument to Port.create_driver()
  • Scripts/webkitpy/layout_tests/port/test.py:
    • pass the options argument to Port.create_driver()
  • Scripts/webkitpy/layout_tests/port/webkit.py:
    • pass the options argument to Port.create_driver(), and clean up building of the cmd line for DRT.
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
    • consolidate args in _get_dump_render_tree_args and rename to _get_test_args(); move all of the command-line args to the Port implementations.
18:11 Changeset [67904] by darin@apple.com
  • 2 edits in trunk

Fix wrong change log! It should have said this:

Deprecate the inputType function on HTMLInputElement
https://bugs.webkit.org/show_bug.cgi?id=46023

Reviewed by James Robinson.

WebCore:

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::HTMLInputElement): Use m_deprecatedTypeNumber.
(WebCore::HTMLInputElement::isValidValue): Use deprecatedInputType.
(WebCore::HTMLInputElement::typeMismatch): Ditto.
(WebCore::HTMLInputElement::valueMissing): Ditto.
(WebCore::HTMLInputElement::rangeUnderflow): Ditto.
(WebCore::HTMLInputElement::rangeOverflow): Ditto.
(WebCore::HTMLInputElement::minimum): Ditto.
(WebCore::HTMLInputElement::maximum): Ditto.
(WebCore::HTMLInputElement::stepBase): Ditto.
(WebCore::HTMLInputElement::stepMismatch): Ditto.
(WebCore::HTMLInputElement::getStepParameters): Ditto.
(WebCore::HTMLInputElement::getAllowedValueStep): Ditto.
(WebCore::HTMLInputElement::isKeyboardFocusable): Ditto.
(WebCore::HTMLInputElement::shouldUseInputMethod): Ditto.
(WebCore::HTMLInputElement::handleBlurEvent): Ditto.
(WebCore::HTMLInputElement::setType): Added a comment.
(WebCore::HTMLInputElement::updateType): Replaced the setInputType function
with this. The type is always the type attribute value, so there is no value
in passing the type string in, and this is an internal implementation detail,
not a public function.
(WebCore::createFormControlTypes): Use deprecatedNumberOfTypes.
(WebCore::HTMLInputElement::formControlType): Use deprecatedInputType.
(WebCore::HTMLInputElement::saveFormControlState): Ditto.
(WebCore::HTMLInputElement::restoreFormControlState): Ditto.
(WebCore::HTMLInputElement::accessKeyAction): Ditto.
(WebCore::HTMLInputElement::mapToEntry): Ditto.
(WebCore::HTMLInputElement::parseMappedAttribute): Ditto.
(WebCore::HTMLInputElement::rendererIsNeeded): Ditto.
(WebCore::HTMLInputElement::createRenderer): Ditto.
(WebCore::HTMLInputElement::attach): Ditto.
(WebCore::HTMLInputElement::isSuccessfulSubmitButton): Ditto.
(WebCore::HTMLInputElement::appendFormData): Ditto.
(WebCore::HTMLInputElement::isTextField): Ditto.
(WebCore::HTMLInputElement::isTextType): Ditto.
(WebCore::HTMLInputElement::setChecked): Ditto.
(WebCore::HTMLInputElement::value): Ditto.
(WebCore::HTMLInputElement::valueWithDefault): Ditto.
(WebCore::HTMLInputElement::setSuggestedValue): Ditto.
(WebCore::HTMLInputElement::setValue): Ditto.
(WebCore::HTMLInputElement::parseToDouble): Ditto.
(WebCore::HTMLInputElement::valueAsDate): Ditto.
(WebCore::HTMLInputElement::setValueAsDate): Ditto.
(WebCore::HTMLInputElement::valueAsNumber): Ditto.
(WebCore::HTMLInputElement::setValueAsNumber): Ditto.
(WebCore::HTMLInputElement::serializeForDateTimeTypes): Ditto.
(WebCore::HTMLInputElement::serialize): Ditto.
(WebCore::HTMLInputElement::setValueFromRenderer): Ditto.
(WebCore::HTMLInputElement::storesValueSeparateFromAttribute): Ditto.
(WebCore::HTMLInputElement::preDispatchEventHandler): Ditto.
(WebCore::HTMLInputElement::postDispatchEventHandler): Ditto.
(WebCore::HTMLInputElement::defaultEventHandler): Ditto.
(WebCore::HTMLInputElement::handleBeforeTextInsertedEvent): Ditto.
(WebCore::HTMLInputElement::files): Ditto.
(WebCore::HTMLInputElement::isAcceptableValue): Ditto.
(WebCore::HTMLInputElement::sanitizeValue): Ditto.
(WebCore::HTMLInputElement::hasUnacceptableValue): Ditto.
(WebCore::HTMLInputElement::needsActivationCallback): Ditto.
(WebCore::HTMLInputElement::isRequiredFormControl): Ditto.
(WebCore::HTMLInputElement::recalcWillValidate): Ditto.
(WebCore::HTMLInputElement::parseToDateComponents): Ditto.
(WebCore::HTMLInputElement::dataList): Ditto.
(WebCore::HTMLInputElement::isSpeechEnabled): Ditto.

  • html/HTMLInputElement.h: Renamed InputType to DeprecatedInputType since it

should not be used outside this class. Renamed numberOfTypes to
dprecatedNumberOfTypes for the same reason. Changed all code to use
deprecatedInputType function instead of m_type. Renamed inputType function
to deprecatedInputType. Replaced public setInputType function with private
updateType function. Renamed m_type data member to m_deprecatedTypeNumber.

  • rendering/MediaControlElements.cpp:

(WebCore::MediaControlInputElement::MediaControlInputElement):

  • rendering/RenderFileUploadControl.cpp:

(WebCore::RenderFileUploadControl::updateFromElement):
Use setType instead of setInputType.

WebKit/chromium:

  • src/WebInputElement.cpp:

(WebKit::WebInputElement::inputType):

  • src/WebPasswordFormUtils.cpp:

(WebKit::findPasswordFormFields):

  • src/WebSearchableFormData.cpp:

(WebCore::HasSuitableTextElement):
Use deprecatedInputType instead of inputType.

18:06 Changeset [67903] by darin@apple.com
  • 9 edits in trunk

2010-09-20 Kenneth Russell <kbr@google.com>

Reviewed by James Robinson.

[chromium] Change compositor to use GraphicsContext3D rather than GLES2Context
https://bugs.webkit.org/show_bug.cgi?id=45912

Switched Chromium's compositor to use GraphicsContext3D to issue
its OpenGL rendering calls rather than the Chromium-specific
GLES2Context and command buffer OpenGL implementation.

The in-process software rendering path for GraphicsContext3D does
not yet work with the compositor, at least not on Mac OS X. This
will be worked on in subsequent bugs.

Tested manually with 3D CSS, WebGL and video content on Mac OS X
and Linux. No new tests.

  • src/GraphicsContext3D.cpp: (WebCore::GraphicsContext3DInternal::initialize): (WebCore::GraphicsContext3DInternal::extractWebGraphicsContext3D): (WebCore::GraphicsContext3D::create):
  • src/GraphicsContext3DInternal.h:
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::resize): (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): (WebKit::WebViewImpl::gles2Context): (WebKit::WebViewImpl::graphicsContext3D):
  • src/WebViewImpl.h:

2010-09-20 Mihai Parparita <mihaip@chromium.org>

Unreviewed; an attempt to fix Windows build.

  • WebCore.vcproj/WebCore.vcproj:
17:51 Changeset [67902] by atwilson@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed expectations changes (added back mistakenly-deleted lines).

  • platform/chromium/test_expectations.txt:
17:46 Changeset [67901] by mihaip@chromium.org
  • 2 edits in trunk/WebCore

2010-09-20 Mihai Parparita <mihaip@chromium.org>

Unreviewed; an attempt to fix Windows build.

  • WebCore.vcproj/WebCore.vcproj:
17:42 Changeset [67900] by simon.fraser@apple.com
  • 3 edits
    4 adds in trunk

2010-09-20 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

When PDF image is directly composited, it does not display
https://bugs.webkit.org/show_bug.cgi?id=46144

In the "direct image compositing" code path, we set the image directly
as the contents of the GraphicsLayer. However, this only works with
bitmap images, so we have to check that the image is a bitmap image.

Test: compositing/images/direct-pdf-image.html

  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::isDirectlyCompositedImage):
17:42 Changeset [67899] by simon.fraser@apple.com
  • 3 edits
    2 adds in trunk

2010-09-20 Simon Fraser <simon.fraser@apple.com>

Reviewed by Darin Adler.

Crash when div with content set to image gets composited (Vimeo).
https://bugs.webkit.org/show_bug.cgi?id=46140

When CSS specifies that the content of an element is an image, we make
a RenderImage, and setStyle() before setting the image resource. In this
case the compositing code can attempt to access the cached image, which
would crash with a null deref.

Fix by null-checking m_imageResource.

Test: compositing/images/content-image.html

  • rendering/RenderImage.h: (WebCore::RenderImage::cachedImage):
17:22 Changeset [67898] by mihaip@chromium.org
  • 21 edits
    4 adds in trunk

2010-09-20 Mihai Parparita <mihaip@chromium.org>

Reviewed by Dimitri Glazkov.

Hashchange event is no longer a simple event, needs to be its own interface
https://bugs.webkit.org/show_bug.cgi?id=36335

Add explicit test for newURL and oldURL properties of hashchange events.
Add HashChangeEvent to expected global objects.
Update stateobjects tests to also check newURL on the hashchange event.

The original version of this patch was written by
Steven Lai <s3lance@hotmail.com>.

  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/prototype-inheritance-expected.txt:
  • fast/js/global-constructors-expected.txt:
  • fast/loader/hashchange-event-properties-expected.txt: Added.
  • fast/loader/hashchange-event-properties.html: Added.
  • fast/loader/stateobjects/document-destroyed-navigate-back-with-fragment-scroll.html:
  • fast/loader/stateobjects/pushstate-with-fragment-urls-and-hashchange.html:

2010-09-20 Mihai Parparita <mihaip@chromium.org>

Reviewed by Dimitri Glazkov.

Hashchange event is no longer a simple event, needs to be its own interface
https://bugs.webkit.org/show_bug.cgi?id=36335

Add HashChangeEvent.idl and supporting files/changes.

Test: fast/loader/hashchange-event-properties.html

The original version of this patch was written by
Steven Lai <s3lance@hotmail.com>.

  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSEventCustom.cpp: (WebCore::toJS):
  • bindings/v8/custom/V8EventCustom.cpp: (WebCore::toV8):
  • dom/Document.cpp: (WebCore::Document::enqueueHashchangeEvent):
  • dom/Event.cpp: (WebCore::Event::isHashChangeEvent):
  • dom/Event.h:
  • dom/HashChangeEvent.h: Added. (WebCore::HashChangeEvent::isHashChangeEvent): (WebCore::HashChangeEvent::create): (WebCore::HashChangeEvent::initHashChangeEvent): (WebCore::HashChangeEvent::oldURL): (WebCore::HashChangeEvent::newURL): (WebCore::HashChangeEvent::HashChangeEvent):
  • dom/HashChangeEvent.idl: Added.
  • page/DOMWindow.idl:
17:18 Changeset [67897] by atwilson@chromium.org
  • 8 edits
    4 deletes in trunk

Revert r67892 (expectations update) as the expectations are out-of-date due to r67879.

  • Scripts/webkitpy/layout_tests/port/base.py:
  • platform/chromium-mac/fast/repaint/table-cell-move-expected.checksum: Removed.
  • platform/chromium-mac/fast/repaint/table-cell-move-expected.png: Removed.
  • platform/chromium-mac/fast/repaint/table-extra-bottom-grow-expected.checksum: Removed.
  • platform/chromium-mac/fast/repaint/table-extra-bottom-grow-expected.png: Removed.
  • platform/chromium-win/fast/repaint/table-cell-move-expected.checksum:
  • platform/chromium-win/fast/repaint/table-cell-move-expected.png:
  • platform/chromium-win/fast/repaint/table-extra-bottom-grow-expected.checksum:
  • platform/chromium-win/fast/repaint/table-extra-bottom-grow-expected.png:
  • platform/chromium/test_expectations.txt:
17:12 Changeset [67896] by mihaip@chromium.org
  • 3 edits in trunk/WebKitTools

2010-09-20 Mihai Parparita <mihaip@chromium.org>

Reviewed by Adam Barth.

Add explicit --force-patch flag to webkitpy tools
https://bugs.webkit.org/show_bug.cgi?id=46103

It wasn't obvious until I read the applypatch.py source code that
--non-interfactive implies passing --force to patch. Add --force-patch
as an alias to the flag, so that this behavior is more discoverable.

  • Scripts/webkitpy/tool/steps/applypatch.py:
  • Scripts/webkitpy/tool/steps/options.py:
17:07 Changeset [67895] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-09-20 Eric Seidel <eric@webkit.org>

Unreviewed, adding a line which got dropped and is trivially correct (and tested).

commit-queue can't land patches
https://bugs.webkit.org/show_bug.cgi?id=46138

Add a line of code I forgot in my last commit.

  • Scripts/webkitpy/common/net/bugzilla.py:
  • Scripts/webkitpy/common/net/bugzilla_unittest.py:
17:04 Changeset [67894] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

Fixed detection of alternative smaller than the first alternative
to only check looping alternatives.
https://bugs.webkit.org/show_bug.cgi?id=46049

Patch by Michael Saboff <msaboff@apple.com> on 2010-09-20
Reviewed by Gavin Barraclough.

  • yarr/RegexJIT.cpp:

(JSC::Yarr::RegexGenerator::generateDisjunction):

16:59 Changeset [67893] by abarth@webkit.org
  • 2 edits
    1 copy in trunk/WebKitTools

2010-09-20 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

The commit-cluster bots still race to lock patch_ids
https://bugs.webkit.org/show_bug.cgi?id=46130

It turns out we need to use a transaction object to make the
read/modify/write lock operation atomic. From reading the AppEngine
documentation, I think this patch should do what we want. It's hard to
test locally because the test instance isn't distributed in the same
way the production instance is.

  • QueueStatusServer/handlers/nextpatch.py:
  • QueueStatusServer/model/activeworkitems.py: Added.
16:57 CommitQueue edited by mihaip@chromium.org
The commit queue no longer blocks on tree redness (as of r66058) (diff)
16:55 Changeset [67892] by atwilson@chromium.org
  • 7 edits
    4 adds in trunk

Unreviewed expectations update for chromium.

  • platform/chromium-mac/fast/repaint/table-cell-move-expected.checksum: Added.
  • platform/chromium-mac/fast/repaint/table-cell-move-expected.png: Added.
  • platform/chromium-mac/fast/repaint/table-extra-bottom-grow-expected.checksum: Added.
  • platform/chromium-mac/fast/repaint/table-extra-bottom-grow-expected.png: Added.
  • platform/chromium-win/fast/repaint/table-cell-move-expected.checksum:
  • platform/chromium-win/fast/repaint/table-cell-move-expected.png:
  • platform/chromium-win/fast/repaint/table-extra-bottom-grow-expected.checksum:
  • platform/chromium-win/fast/repaint/table-extra-bottom-grow-expected.png:
  • platform/chromium/test_expectations.txt:

Removed duplicate expectations entries to allow rebaselining tool to work.
Disabled 2d.imageData.get.source.outside.html test as it fails on Chromium.

16:25 Changeset [67891] by andersca@apple.com
  • 5 edits in trunk/WebKit2

Add a way to delay sending replies to sync requests
https://bugs.webkit.org/show_bug.cgi?id=46117

Reviewed by Adam Roben.

Change the didReceiveSyncMessage client message to return a SyncReplyMode. If the SyncReplyMode is
AutomaticReply, the reply will be sent when the didReceiveSyncMessage function returns. However, if it is
ManualReply, then the client is handed ownership of the reply ArgumentEncoder and can choose to send it
at a later time using Connection::sendSyncReply.

  • Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::sendSyncReply):
Send the message as a sync reply.

(CoreIPC::Connection::dispatchMessages):
Check the return value of didReceiveSyncMessage. If it is AutomaticReply, immediately send the reply.

  • Platform/CoreIPC/Connection.h:

(CoreIPC::Connection::MessageReceiver::didReceiveSyncMessage):
Change return type.

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::didReceiveSyncMessage):

  • UIProcess/WebProcessProxy.h:

Update for changed return type.

16:01 Changeset [67890] by aestes@apple.com
  • 22 edits
    9 adds in trunk

2010-09-20 Andy Estes <aestes@apple.com>

Reviewed by Adam Barth.

REGRESSION (HTML5 Parser): Pages broken due to <tag<tag> parsing changes
https://bugs.webkit.org/show_bug.cgi?id=40961

Implement WebKitUsePreHTML5ParserQuirks preference.

  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm: (+[WebPreferences initialize]): Default WebKitUsePreHTML5ParserQuirks to false. (-[WebPreferences usePreHTML5ParserQuirks]): (-[WebPreferences setUsePreHTML5ParserQuirks:]):
  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]): Update WebCore::Settings with the value of WebKitUsePreHTML5ParserQuirks when a preference changes.

2010-09-20 Andy Estes <aestes@apple.com>

Reviewed by Adam Barth.

REGRESSION (HTML5 Parser): Pages broken due to <tag<tag> parsing changes
https://bugs.webkit.org/show_bug.cgi?id=40961

Add an optional quirk to the HTML5 tokenizer that reverts it to WebKit's
legacy behavior when the start of a new token is encountered before the
current token is finished parsing. The legacy behavior is to emit the
current token as if it were properly closed and being parsing the new
token.

Test: fast/parser/pre-html5-parser-quirks.html

  • html/parser/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::HTMLDocumentParser): Instantiate m_tokenizer with the value of Settings::usePreHTML5ParserQuirks(). (WebCore::usePreHTMLParserQuirks): Add a helper function to return the value of Settings::usePreHTML5ParserQuirks() if Settings is non-NULL.
  • html/parser/HTMLPreloadScanner.cpp: (WebCore::HTMLPreloadScanner::HTMLPreloadScanner): Instantiate m_tokenizer with the value of Settings::usePreHTML5ParserQuirks().
  • html/parser/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::HTMLTokenizer): (WebCore::HTMLTokenizer::nextToken): If the quirk is enabled and an unexpected '<' is encountered in certain states, emit the current token and reprocess the '<' as the start of a new token.
  • html/parser/HTMLTokenizer.h: (WebCore::HTMLTokenizer::create):
  • html/parser/HTMLViewSourceParser.cpp: (WebCore::HTMLViewSourceParser::HTMLViewSourceParser): Instantiate m_tokenizer with the value of Settings::usePreHTML5ParserQuirks().
  • page/Settings.cpp: (WebCore::Settings::Settings):
  • page/Settings.h: (WebCore::Settings::setUsePreHTML5ParserQuirks): (WebCore::Settings::usePreHTML5ParserQuirks):

2010-09-20 Andy Estes <aestes@apple.com>

Reviewed by Adam Barth.

REGRESSION (HTML5 Parser): Pages broken due to <tag<tag> parsing changes
https://bugs.webkit.org/show_bug.cgi?id=40961

  • fast/parser/pre-html5-parser-quirks-expected.txt: Added.
  • fast/parser/pre-html5-parser-quirks.html: Added.
  • fast/parser/resources/pre-html5-parser-quirk-after-attribute-name-state.html: Added.
  • fast/parser/resources/pre-html5-parser-quirk-after-attribute-value-quoted-state.html: Added.
  • fast/parser/resources/pre-html5-parser-quirk-after-attribute-value-unquoted-state.html: Added.
  • fast/parser/resources/pre-html5-parser-quirk-attribute-name-state.html: Added.
  • fast/parser/resources/pre-html5-parser-quirk-before-attribute-name-state.html: Added.
  • fast/parser/resources/pre-html5-parser-quirk-document-fragment.html: Added.
  • fast/parser/resources/pre-html5-parser-quirk-tag-name-state.html: Added.
  • platform/chromium/test_expectations.txt: Skip pre-html5-parser-quirks.html.
  • platform/gtk/Skipped: Skip pre-html5-parser-quirks.html.
  • platform/mac-wk2/Skipped: Skip pre-html5-parser-quirks.html.
  • platform/qt/Skipped: Skip pre-html5-parser-quirks.html.
  • platform/win/Skipped: Skip pre-html5-parser-quirks.html.

2010-09-20 Andy Estes <aestes@apple.com>

Reviewed by Adam Barth.

REGRESSION (HTML5 Parser): Pages broken due to <tag<tag> parsing changes
https://bugs.webkit.org/show_bug.cgi?id=40961

Implement WebKitUsePreHTML5ParserQuirks preference.

  • DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues): Reset WebKitUsePreHTML5ParserQuirks to false after a test finishes.
15:49 Changeset [67889] by hyatt@apple.com
  • 4 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=46132, add an isVerticalBlockFlow() method to RenderStyle and
patch callers so that they don't have to check both top-to-bottom and bottom-to-top block flow.

Reviewed by Dan Bernstein.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::availableLogicalWidth):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::logicalWidth):
(WebCore::RenderStyle::logicalHeight):
(WebCore::RenderStyle::logicalMinWidth):
(WebCore::RenderStyle::logicalMaxWidth):
(WebCore::RenderStyle::logicalMinHeight):
(WebCore::RenderStyle::logicalMaxHeight):
(WebCore::RenderStyle::borderStartWidth):
(WebCore::RenderStyle::borderEndWidth):
(WebCore::RenderStyle::marginStart):
(WebCore::RenderStyle::marginEnd):
(WebCore::RenderStyle::paddingStart):
(WebCore::RenderStyle::paddingEnd):

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::isVerticalBlockFlow):

15:39 Changeset [67888] by aroben@apple.com
  • 2 edits in trunk/WebKitTools

Windows build fix

  • MiniBrowser/Configurations/MiniBrowserCommon.vsprops: Put

$(WebKitOutputDir)\include before $(WebKitLibrariesDir)\include so
we'll pick up the most recent versions of the headers.

15:38 Changeset [67887] by hyatt@apple.com
  • 4 edits
    3 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=46124, add support for logical padding accessors to
RenderBoxModelObject.

Reviewed by Dan Bernstein.

Added fast/blockflow/percentage-padding.html even though it fails, so that when more of layout is patched
we can see it start passing.

WebCore:

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paddingTop):
(WebCore::RenderBoxModelObject::paddingBottom):
(WebCore::RenderBoxModelObject::paddingLeft):
(WebCore::RenderBoxModelObject::paddingRight):
(WebCore::RenderBoxModelObject::paddingBefore):
(WebCore::RenderBoxModelObject::paddingAfter):
(WebCore::RenderBoxModelObject::paddingStart):
(WebCore::RenderBoxModelObject::paddingEnd):

  • rendering/RenderBoxModelObject.h:

LayoutTests:

  • fast/blockflow: Added.
  • fast/blockflow/percentage-padding-expected.txt: Added.
  • fast/blockflow/percentage-padding.html: Added.
15:35 Changeset [67886] by hyatt@apple.com
  • 5 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=46126, add availableLogicalWidth() to RenderBox.

Reviewed by Dan Bernstein.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::availableWidth):
(WebCore::RenderBlock::availableLogicalWidth):

  • rendering/RenderBlock.h:
  • rendering/RenderBox.cpp:

(WebCore::RenderBox::availableLogicalWidth):

  • rendering/RenderBox.h:

(WebCore::RenderBox::availableWidth):

15:28 Changeset [67885] by kbr@google.com
  • 20 edits in trunk

2010-09-20 Kenneth Russell <kbr@google.com>

Reviewed by James Robinson.

[chromium] Change compositor to use GraphicsContext3D rather than GLES2Context
https://bugs.webkit.org/show_bug.cgi?id=45912

Switched Chromium's compositor to use GraphicsContext3D to issue
its OpenGL rendering calls rather than the Chromium-specific
GLES2Context and command buffer OpenGL implementation.

The in-process software rendering path for GraphicsContext3D does
not yet work with the compositor, at least not on Mac OS X. This
will be worked on in subsequent bugs.

Tested manually with 3D CSS, WebGL and video content on Mac OS X
and Linux. No new tests.

  • src/GraphicsContext3D.cpp: (WebCore::GraphicsContext3DInternal::initialize): (WebCore::GraphicsContext3DInternal::extractWebGraphicsContext3D): (WebCore::GraphicsContext3D::create):
  • src/GraphicsContext3DInternal.h:
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::resize): (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): (WebKit::WebViewImpl::gles2Context): (WebKit::WebViewImpl::graphicsContext3D):
  • src/WebViewImpl.h:

2010-09-20 Kenneth Russell <kbr@google.com>

Reviewed by James Robinson.

[chromium] Change compositor to use GraphicsContext3D rather than GLES2Context
https://bugs.webkit.org/show_bug.cgi?id=45912

Switched Chromium's compositor to use GraphicsContext3D to issue
its OpenGL rendering calls rather than the Chromium-specific
GLES2Context and command buffer OpenGL implementation.

The in-process software rendering path for GraphicsContext3D does
not yet work with the compositor, at least not on Mac OS X. This
will be worked on in subsequent bugs.

Tested manually with 3D CSS, WebGL and video content on Mac OS X
and Linux. No new tests.

  • platform/graphics/chromium/Canvas2DLayerChromium.cpp: (WebCore::Canvas2DLayerChromium::~Canvas2DLayerChromium): (WebCore::Canvas2DLayerChromium::updateContents):
  • platform/graphics/chromium/CanvasLayerChromium.cpp: (WebCore::CanvasLayerChromium::SharedValues::SharedValues): (WebCore::CanvasLayerChromium::SharedValues::~SharedValues): (WebCore::CanvasLayerChromium::draw):
  • platform/graphics/chromium/CanvasLayerChromium.h:
  • platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::SharedValues::SharedValues): (WebCore::ContentLayerChromium::SharedValues::~SharedValues): (WebCore::ContentLayerChromium::~ContentLayerChromium): (WebCore::ContentLayerChromium::updateTextureRect): (WebCore::ContentLayerChromium::draw):
  • platform/graphics/chromium/ContentLayerChromium.h:
  • platform/graphics/chromium/DrawingBufferChromium.cpp: (WebCore::DrawingBuffer::publishToPlatformLayer):
  • platform/graphics/chromium/LayerChromium.cpp: (WebCore::loadShader): (WebCore::LayerChromium::SharedValues::SharedValues): (WebCore::LayerChromium::SharedValues::~SharedValues): (WebCore::LayerChromium::createShaderProgram): (WebCore::LayerChromium::layerRendererContext): (WebCore::LayerChromium::drawTexturedQuad): (WebCore::LayerChromium::drawDebugBorder): (WebCore::LayerChromium::drawAsMask): (WebCore::LayerChromium::prepareForDraw):
  • platform/graphics/chromium/LayerChromium.h: (WebCore::LayerChromium::SharedValues::context):
  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::create): (WebCore::LayerRendererChromium::LayerRendererChromium): (WebCore::LayerRendererChromium::context): (WebCore::LayerRendererChromium::debugGLCall): (WebCore::LayerRendererChromium::useShader): (WebCore::LayerRendererChromium::prepareToDrawLayers): (WebCore::LayerRendererChromium::updateRootLayerTextureRect): (WebCore::LayerRendererChromium::drawLayers): (WebCore::LayerRendererChromium::finish): (WebCore::LayerRendererChromium::present): (WebCore::LayerRendererChromium::getFramebufferPixels): (WebCore::LayerRendererChromium::createLayerTexture): (WebCore::LayerRendererChromium::drawLayerIntoStencilBuffer): (WebCore::LayerRendererChromium::drawLayersRecursive): (WebCore::LayerRendererChromium::drawLayer): (WebCore::LayerRendererChromium::scissorToRect): (WebCore::LayerRendererChromium::makeContextCurrent): (WebCore::LayerRendererChromium::resizeOnscreenContent): (WebCore::LayerRendererChromium::initializeSharedObjects): (WebCore::LayerRendererChromium::cleanupSharedObjects):
  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/VideoLayerChromium.cpp: (WebCore::VideoLayerChromium::createTextureRect): (WebCore::VideoLayerChromium::updateTextureRect):
  • platform/graphics/chromium/WebGLLayerChromium.cpp: (WebCore::WebGLLayerChromium::updateContents):
  • platform/graphics/gpu/SharedGraphicsContext3D.cpp: (WebCore::SharedGraphicsContext3D::flush): (WebCore::SharedGraphicsContext3D::supportsCopyTextureToParentTextureCHROMIUM): (WebCore::SharedGraphicsContext3D::copyTextureToParentTextureCHROMIUM):
  • platform/graphics/gpu/SharedGraphicsContext3D.h:
14:35 Changeset [67884] by hyatt@apple.com
  • 3 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=46119, add logical accessors to RenderStyle. Not used by any RenderObjects yet, so no tests
until then.

Reviewed by Dan Bernstein.

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::logicalWidth):
(WebCore::RenderStyle::logicalHeight):
(WebCore::RenderStyle::logicalMinWidth):
(WebCore::RenderStyle::logicalMaxWidth):
(WebCore::RenderStyle::logicalMinHeight):
(WebCore::RenderStyle::logicalMaxHeight):
(WebCore::RenderStyle::borderBeforeWidth):
(WebCore::RenderStyle::borderAfterWidth):
(WebCore::RenderStyle::borderStartWidth):
(WebCore::RenderStyle::borderEndWidth):
(WebCore::RenderStyle::marginBefore):
(WebCore::RenderStyle::marginAfter):
(WebCore::RenderStyle::marginStart):
(WebCore::RenderStyle::marginEnd):
(WebCore::RenderStyle::paddingBefore):
(WebCore::RenderStyle::paddingAfter):
(WebCore::RenderStyle::paddingStart):
(WebCore::RenderStyle::paddingEnd):

  • rendering/style/RenderStyle.h:
14:07 Changeset [67883] by eric.carlson@apple.com
  • 2 edits in trunk/LayoutTests

2010-09-20 Eric Carlson <eric.carlson@apple.com>

Rubber-stamped by by Simon Fraser.

video-served-as-text.html failing on Windows
https://bugs.webkit.org/show_bug.cgi?id=46111

  • platform/win/Skipped: Skip http/tests/media/video-served-as-text.html.
14:03 Changeset [67882] by hyatt@apple.com
  • 8 edits
    2 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=46116, implement block-flow-aware logical properties.

Reviewed by Dan Bernstein.

This patch adds all the logical properties from the CSS3 Writing Mode draft for margins, padding, border,
width and height.

Added fast/css/logical-property-resolution.html

WebCore:

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

  • css/CSSProperty.cpp:

(WebCore::resolveToPhysicalProperty):
(WebCore::CSSProperty::resolveDirectionAwareProperty):

  • css/CSSProperty.h:
  • css/CSSPropertyNames.in:
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyDeclarations):
(WebCore::CSSStyleSelector::applyProperty):

LayoutTests:

  • fast/css/logical-property-resolution-expected.txt: Added.
  • fast/css/logical-property-resolution.html: Added.
14:00 Changeset [67881] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

2010-09-20 James Robinson <jamesr@chromium.org>

Fix mis-merge of chromium mac expectations.

  • platform/chromium/test_expectations.txt:
13:49 Changeset [67880] by eric@webkit.org
  • 7 edits in trunk/WebKitTools

2010-09-20 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

commit-queue should check commit-queue+ again just before committing
https://bugs.webkit.org/show_bug.cgi?id=32679

Added a _revalidate_patch check, right before landing.

Since _revalidate_patch passes the patch_id from the work item
back to bugzilla, I had to fix all of the previous queue tests to
use valid attachment ids (that's the majority of this change).

In order to validate that the bug was still open, I had to teach
bugzilla.Bug about open/closed states.

  • Scripts/webkitpy/common/net/bugzilla.py:
  • Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
  • Scripts/webkitpy/tool/commands/queues.py:
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
  • Scripts/webkitpy/tool/commands/queuestest.py:
  • Scripts/webkitpy/tool/mocktool.py:
13:21 Changeset [67879] by hyatt@apple.com
  • 2 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=46114, two tables repaint tests failing on bots.

Reviewed by Beth Dakin.

Patch layoutRows to apply the layout delta when setting a new cell location prior to laying out the cell.

The layout delta is then removed after layout has happened when the repaint check is done. This change
makes cell layout match block child layout, and now the cells have the correct new location up front
when laying out (a necessity for pagination).

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::layoutRows):

13:20 Changeset [67878] by commit-queue@webkit.org
  • 4 edits in trunk

2010-09-20 Jacob Dinu <dinu.jacob@nokia.com>

Reviewed by Adam Barth.

When loading a cached page, dispatchDidCommitLoad is called after FrameLoader::open so
that all initialzations are done before calling client dispatchDidCommitLoad to avoid
client from accessing incorrect data.
https://bugs.webkit.org/show_bug.cgi?id=41155

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::commitProvisionalLoad): (WebCore::FrameLoader::transitionToCommitted):

2010-09-20 Jacob Dinu <dinu.jacob@nokia.com>

Reviewed by Adam Barth.

Added a new qwebpage test for loading a cached page
https://bugs.webkit.org/show_bug.cgi?id=41155

  • tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::loadCachedPage):
13:19 Changeset [67877] by simon.fraser@apple.com
  • 4 edits
    2 adds in trunk

2010-09-20 Simon Fraser <simon.fraser@apple.com>

Reviewed by Adam Roben.

REGRESSION: alternating animation direction doesn't work on Windows
https://bugs.webkit.org/show_bug.cgi?id=46017

Animation-direction on Windows was broken because bitfields on
Windows are signed.

Fixed by making m_direction an unsigned in the bitfield, and
casting in the accessor.

Test: animations/animation-direction.html

  • platform/animation/Animation.h: (WebCore::Animation::direction):
13:18 WebKit Team edited by mihaip@chromium.org
(diff)
13:09 Changeset [67876] by mihaip@chromium.org
  • 2 edits in trunk/WebKitTools

2010-09-20 Mihai Parparita <mihaip@chromium.org>

Unreviewed.

Adding myself as a comitter.

  • Scripts/webkitpy/common/config/committers.py:
13:01 Changeset [67875] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

2010-09-20 James Robinson <jamesr@chromium.org>

Fix bad merge in chromium test_expectations.txt

  • platform/chromium/test_expectations.txt:
12:59 Changeset [67874] by andersca@apple.com
  • 3 edits in trunk/WebKit2

Don't use bufferIsLargeEnoughToContain for Vectors with variable sized elements
https://bugs.webkit.org/show_bug.cgi?id=46109

Reviewed by Adam Roben.

Add a new VectorArgumentCoder class template, with specializations based on whether the
element is fixed size or not. Then update the ArgumentEncoder<Vector<T>> specialization to choose the
right VectorArgumentCoder specialization. To determine this, we use the "IsArithmetic" type trait,
which holds true for all integer types and all floating point types.

  • Platform/CoreIPC/ArgumentCoders.h:
12:57 Changeset [67873] by kbr@google.com
  • 2 edits in trunk/WebKit/chromium

2010-09-20 Kenneth Russell <kbr@google.com>

Reviewed by Dimitri Glazkov.

[chromium] Roll forward Chromium DEPS to pick up WebGraphicsContext3D implementation changes
https://bugs.webkit.org/show_bug.cgi?id=46115

  • DEPS:
12:49 CommitterTips edited by mihaip@chromium.org
(diff)
12:40 Changeset [67872] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

2010-09-17 James Robinson <jamesr@chromium.org>

Reviewed by Andreas Kling

[chromium] Add specific expectations for canvas/philip tests
https://bugs.webkit.org/show_bug.cgi?id=45991

Instead of marking all of canvas/philip and http/tests/canvas/philip/ as
TEXT failures, this marks each test exactly.

  • platform/chromium/test_expectations.txt:
12:32 Changeset [67871] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-09-20 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Two instances of commit-queue try to process the same patch
https://bugs.webkit.org/show_bug.cgi?id=46113

This patch makes next-patch atomic so that the server won't vend the
same patch twice in the same hour.

  • QueueStatusServer/handlers/nextpatch.py:
12:30 Changeset [67870] by dglazkov@chromium.org
  • 1 edit
    1 move
    1 delete in trunk/LayoutTests

2010-09-20 Dimitri Glazkov <dglazkov@chromium.org>

Fix up the goober from http://trac.webkit.org/changeset/67856.

  • platform/chromium-win-xp/css2.1/hindi-spacing-expected.png: Removed.
  • platform/chromium-win-xp/fast/text/international/hindi-spacing-expected.checksum: Renamed from LayoutTests/platform/chromium-win-xp/css2.1/hindi-spacing-expected.checksum.
12:29 Changeset [67869] by commit-queue@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-09-20 Peter Varga <pvarga@inf.u-szeged.hu>

Reviewed by Geoffrey Garen.

REGRESSION(67790): jsc tests are failed with YARR interpreter
https://bugs.webkit.org/show_bug.cgi?id=46083

Fix the initializing of the lastSubpatternId member of
parentheses.

  • yarr/RegexCompiler.cpp: (JSC::Yarr::RegexPatternConstructor::atomParenthesesEnd):
11:51 Changeset [67868] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2010-09-20 Adam Barth <abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

Attributes not interpreted correctly if there is a syntax error
https://bugs.webkit.org/show_bug.cgi?id=16254

The underlying bug was fixed by the HTML5 parser, but I don't think we
have a test for this particular tokenization behavior.

  • html5lib/resources/webkit01.dat:
11:31 Changeset [67867] by barraclough@apple.com
  • 3 edits
    3 adds in trunk

2010-09-20 Gavin Barraclough <barraclough@apple.com>

Reviewed by Oliver Hunt.

Bug 46077 - ASSERT failure in YARR JIT

We will currently attempt to loop if there are multiple alternatives, they are all
BOL predicated, and the last alternative is longer then the first - however if all
alternatives are BOL predicated the head of loop label will not have been set, and
we'll try to link a jump to an undefined label. Stop doing so.

  • yarr/RegexJIT.cpp: (JSC::Yarr::RegexGenerator::generateDisjunction):

2010-09-20 Gavin Barraclough <barraclough@apple.com>

Reviewed by Oliver Hunt.

Bug 46077 - ASSERT failure in YARR JIT

We will currently attempt to loop if there are multiple alternatives, they are all
BOL predicated, and the last alternative is longer then the first - however if all
alternatives are BOL predicated the head of loop label will not have been set, and
we'll try to link a jump to an undefined label. Stop doing so.

  • fast/js/regexp-norepeat-expected.txt: Added.
  • fast/js/regexp-norepeat.html: Added.
  • fast/js/script-tests/regexp-norepeat.js: Added.
11:18 Changeset [67866] by aroben@apple.com
  • 2 edits in trunk/LayoutTests

Skip some failing animation tests on Windows

The failures are covered by http://webkit.org/b/46017

Rubber-stamped by Simon Fraser.

  • platform/win/Skipped:
11:12 Changeset [67865] by mrobinson@webkit.org
  • 2 edits in trunk/LayoutTests

2010-09-20 Martin Robinson <mrobinson@igalia.com>

Correct a GTK+ baseline. These issues should hopefully be mitigated
by upcoming font fixes.

  • platform/gtk/fast/events/keydown-1-expected.txt: Updated baseline.
11:10 Changeset [67864] by enrica@apple.com
  • 11 edits
    1 add in trunk

Pasteboard doesn't work in WebKit2.
https://bugs.webkit.org/show_bug.cgi?id=42317
<rdar://problem/7660537>

Reviewed by Sam Weinig.

WebCore:

  • loader/EmptyClients.h:

(WebCore::EmptyEditorClient::documentFragmentFromAttributedString): Changed parameter to
be a Vector of RefPtr.

  • page/EditorClient.h:
  • platform/mac/PasteboardMac.mm:

(WebCore::Pasteboard::documentFragmentWithRtf): Stylistic changes.

WebKit/mac:

Some changes to fix style inconsistencies.
Added OBJC 2.0 style enumeration.

  • WebCoreSupport/WebEditorClient.h:
  • WebCoreSupport/WebEditorClient.mm:

(WebEditorClient::userVisibleString):
(createExcludedElementsForAttributedStringConversion):
(WebEditorClient::documentFragmentFromAttributedString): Changed parameter to be
a Vector of RefPtr.
(WebEditorClient::setInsertionPasteboard):
(WebEditorClient::pasteboardTypesForSelection):

WebKit2:

Adding support for RTF, RTFD and NSUrl formats on the Mac.
Still missing the selective enabling of the menu entries.

  • WebKit2.xcodeproj/project.pbxproj: Added WebEditorClientMac.mm.
  • WebProcess/WebCoreSupport/WebEditorClient.cpp: Removed Mac only methods

that are now in WebEditorClientMac.mm

  • WebProcess/WebCoreSupport/WebEditorClient.h: Fixed style and changed parameter

type in documentFragmentFromAttributedString to be a Vector of RefPtr.

  • WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm: Added.

All the following methods have been moved from WebEditorClient.cpp.
(WebKit::WebEditorClient::userVisibleString): Added implementation.
(WebKit::createExcludedElementsForAttributedStringConversion): Added.
(WebKit::WebEditorClient::documentFragmentFromAttributedString): Added implementation.
(WebKit::WebEditorClient::setInsertionPasteboard):
(WebKit::WebEditorClient::pasteboardTypesForSelection):
(WebKit::WebEditorClient::uppercaseWord):
(WebKit::WebEditorClient::lowercaseWord):
(WebKit::WebEditorClient::capitalizeWord):
(WebKit::WebEditorClient::showSubstitutionsPanel):
(WebKit::WebEditorClient::substitutionsPanelIsShowing):
(WebKit::WebEditorClient::toggleSmartInsertDelete):
(WebKit::WebEditorClient::isAutomaticQuoteSubstitutionEnabled):
(WebKit::WebEditorClient::toggleAutomaticQuoteSubstitution):
(WebKit::WebEditorClient::isAutomaticLinkDetectionEnabled):
(WebKit::WebEditorClient::toggleAutomaticLinkDetection):
(WebKit::WebEditorClient::isAutomaticDashSubstitutionEnabled):
(WebKit::WebEditorClient::toggleAutomaticDashSubstitution):
(WebKit::WebEditorClient::isAutomaticTextReplacementEnabled):
(WebKit::WebEditorClient::toggleAutomaticTextReplacement):
(WebKit::WebEditorClient::isAutomaticSpellingCorrectionEnabled):
(WebKit::WebEditorClient::toggleAutomaticSpellingCorrection):
(WebKit::WebEditorClient::checkTextOfParagraph):
(WebKit::WebEditorClient::showCorrectionPanel):
(WebKit::WebEditorClient::dismissCorrectionPanel):
(WebKit::WebEditorClient::isShowingCorrectionPanel):

11:07 Changeset [67863] by paroga@webkit.org
  • 1 edit
    2 adds in trunk/WebKit/wince

2010-09-20 Patrick Gansterer <paroga@paroga.com>

Reviewed by Adam Roben.

Add FrameLoaderClientWinCE
https://bugs.webkit.org/show_bug.cgi?id=45682

  • WebCoreSupport/FrameLoaderClientWinCE.cpp: Added.
  • WebCoreSupport/FrameLoaderClientWinCE.h: Added.
10:55 Changeset [67862] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-09-20 Yong Li <yoli@rim.com>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=39966
Make compareBorders() a consistent compare function which can beused by qsort().

New test case added: LayoutTests/tables/sort-collapsed-border-styles.html

  • rendering/RenderTableCell.cpp: (WebCore::compareBorders): (WebCore::chooseBorder): (WebCore::RenderTableCell::collapsedLeftBorder): (WebCore::RenderTableCell::collapsedRightBorder): (WebCore::RenderTableCell::collapsedTopBorder): (WebCore::RenderTableCell::collapsedBottomBorder): (WebCore::compareBorderStylesForQSort):
10:50 Changeset [67861] by aroben@apple.com
  • 6 edits
    2 adds in trunk/WebKitTools

Make WebKitTestRunner's wait-to-dump watchdog timer work on Windows

We were previously trying to use a CFRunLoopTimer, but since Windows
doesn't use CFRunLoop on most threads this doesn't work. Now we use a
Windows-style timer on Windows.

I also replaced all uses of "watchdog" with "watchdog timer".

Fixes <http://webkit.org/b/46101> WebKitTestRunner's wait-to-dump
watchdog timer doesn't work on Windows

Reviewed by Anders Carlsson.

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::dump): Updated for rename.

  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: Removed

platform-specific functions.
(WTR::LayoutTestController::LayoutTestController): Added call to
platformInitialize.
(WTR::LayoutTestController::waitUntilDone): Changed to call
initializeWaitToDumpWatchdogTimerIfNeeded instead of doing the work
right in this function.
(WTR::LayoutTestController::waitToDumpWatchdogTimerFired): Updated for
rename.

  • WebKitTestRunner/InjectedBundle/LayoutTestController.h: Added new

members needed to support the watchdog timer abstraction. Replaced
some "watchdog"s with "watchdog timer".

  • WebKitTestRunner/InjectedBundle/mac/LayoutTestControllerMac.mm:

Added.
(WTR::LayoutTestController::platformInitialize): Does nothing on this
platform.
(WTR::LayoutTestController::invalidateWaitToDumpWatchdog): Moved here
from LayoutTestController.cpp and changed to use an early return.
(WTR::waitUntilDoneWatchdogTimerFired): Moved here from
LayoutTestController.cpp.
(WTR::LayoutTestController::initializeWaitToDumpWatchdogTimerIfNeeded):
Moved code here from LayoutTestController::waitUntilDone and changed
to use an early return.

  • WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp:

Added.
(WTR::LayoutTestController::platformInitialize): Initialize our
watchdog timer.
(WTR::LayoutTestController::invalidateWaitToDumpWatchdog): Added.
Kills and clears the watchdog timer.
(WTR::waitToDumpWatchdogTimerFired): Added. Calls through to the
LayoutTestController member function of the same name.
(WTR::LayoutTestController::initializeWaitToDumpWatchdogTimerIfNeeded):
Added. Sets up the timer if it isn't already set.

  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Added

LayoutTestControllerMac.mm.

  • WebKitTestRunner/win/InjectedBundle.vcproj: Added

LayoutTestControllerWin.cpp.

10:44 Changeset [67860] by mrobinson@webkit.org
  • 4 edits
    1 add in trunk

2010-09-20 Martin Robinson <mrobinson@igalia.com>

Reviewed by Daniel Bates.

[GTK] fast/forms/listbox-selection.html fails
https://bugs.webkit.org/show_bug.cgi?id=45942

  • platform/gtk/Skipped: Unskip test which is now passing.
  • platform/gtk/fast/events/keydown-1-expected.txt: Added.

2010-09-20 Martin Robinson <mrobinson@igalia.com>

Reviewed by Daniel Bates.

[GTK] fast/forms/listbox-selection.html fails
https://bugs.webkit.org/show_bug.cgi?id=45942

Use the gdkModifersFromJSValue helper to parse all appropriate modifier
strings in keyDownCallback.

  • DumpRenderTree/gtk/EventSender.cpp: (keyDownCallback): Use the gdkModifersFromJSValue instead of duplicating the modifier parsing logic.
10:26 Changeset [67859] by dglazkov@chromium.org
  • 2 edits in trunk/LayoutTests

2010-09-20 Dimitri Glazkov <dglazkov@chromium.org>

Update a win-xp-specific baseline.

  • platform/chromium-win-xp/fast/text/international/hindi-spacing-expected.png: Updated.
10:14 Changeset [67858] by aestes@apple.com
  • 2 edits in trunk/WebKit2

2010-09-20 Andy Estes <aestes@apple.com>

Reviewed by Darin Adler.

Fix a style issue and add a FIXME to make the AppleConnect plug-in
workaround dependent on site-specific quirks being enabled, which
WebKit2 does not yet support in its WebPreferences implementation.
https://bugs.webkit.org/show_bug.cgi?id=45960

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::createPlugin):
09:48 Changeset [67857] by abarth@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2010-09-20 Adam Barth <abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

script element created with html element as parent
https://bugs.webkit.org/show_bug.cgi?id=17023

The underlying bug is fixed by the HTML5 parser. We have lots of tests
for the resulting DOM in this case, but we don't have a test for what
the DOM looks like to a script running inline at that time. Since
that's how the test case attached to the bug was written, it seems
worth adding.

  • fast/parser/parent-of-script-before-head-expected.txt: Added.
  • fast/parser/parent-of-script-before-head.html: Added.
09:20 Changeset [67856] by dglazkov@chromium.org
  • 2 edits
    6 moves
    1 add in trunk/LayoutTests

2010-09-20 Dimitri Glazkov <dglazkov@chromium.org>

Move a few more xp-specific results to win-xp and clean up test expectations.

  • platform/chromium-win-vista/fast/text/international/hindi-whitespace-expected.txt: Copied from LayoutTests/platform/chromium-win-xp/fast/text/international/hindi-whitespace-expected.txt.
  • platform/chromium-win-xp/css2.1/hindi-spacing-expected.checksum: Renamed from LayoutTests/platform/chromium-win/fast/text/international/hindi-spacing-expected.checksum.
  • platform/chromium-win-xp/css2.1/hindi-spacing-expected.png: Renamed from LayoutTests/platform/chromium-win/fast/text/international/hindi-spacing-expected.png.
  • platform/chromium-win-xp/css2.1/t1202-counter-09-b-expected.checksum: Renamed from LayoutTests/platform/chromium-win/css2.1/t1202-counter-09-b-expected.checksum.
  • platform/chromium-win-xp/css2.1/t1202-counter-09-b-expected.png: Renamed from LayoutTests/platform/chromium-win/css2.1/t1202-counter-09-b-expected.png.
  • platform/chromium-win-xp/css2.1/t1202-counters-09-b-expected.checksum: Renamed from LayoutTests/platform/chromium-win/css2.1/t1202-counters-09-b-expected.checksum.
  • platform/chromium-win-xp/css2.1/t1202-counters-09-b-expected.png: Renamed from LayoutTests/platform/chromium-win/css2.1/t1202-counters-09-b-expected.png.
  • platform/chromium/test_expectations.txt:
09:18 Changeset [67855] by aroben@apple.com
  • 2 edits in trunk/JavaScriptCore

Export RegExpObject::info from JavaScriptCore

This allows obj->inherits(&RegExpObject::info) to work correctly from
outside JavaScriptCore.dll on Windows.

Fixes <http://webkit.org/b/46098>
fast/loader/stateobjects/pushstate-object-types.html fails on Windows

Reviewed by John Sullivan.

  • runtime/RegExpObject.h: Added JS_EXPORTDATA to the info member, as

we already have for some other classes whose info members have to be
used from outside the DLL.

09:16 Changeset [67854] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-09-20 Patrick Gansterer <paroga@paroga.com>

Reviewed by Adam Roben.

[WINCE] Buildfix for PluginViewWin.cpp
https://bugs.webkit.org/show_bug.cgi?id=46033

  • plugins/win/PluginViewWin.cpp: (WebCore::PluginView::paintIntoTransformedContext): (WebCore::PluginView::snapshot):
09:12 Changeset [67853] by hyatt@apple.com
  • 6 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=46030, aintitcool.com doesn't paginate correctly when printed.

Reviewed by Sam Weinig.

This happens because the site always has a document width that will exceed the page width.
We incorrectly apply a double scale instead of clipping after the first scale still doesn't fit.
The fix for the issue is to cap the right layout overflow to the page width and to just clip out
any additional excess. This is the code in FrameView.cpp.

This patch also cleans up table cell invalidation to reduce the # of relayouts. This change is not
a correctness fix. It's just performance.

I'm not sure how to write a test for this, since the double scale is an artifact of how WebKit mac calls
back in when really printing.

  • page/FrameView.cpp:

(WebCore::FrameView::forceLayoutForPagination):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlockChild):
(WebCore::RenderBlock::layoutPositionedObjects):
(WebCore::RenderBlock::positionNewFloats):

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::markForPaginationRelayout):

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutHorizontalBox):
(WebCore::RenderFlexibleBox::layoutVerticalBox):

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::layoutRows):

09:07 BuildingGtk edited by mrobinson@webkit.org
(diff)
08:47 Changeset [67852] by loislo@chromium.org
  • 18 edits in trunk

2010-09-20 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: merge Inspector client runtime events into the serialized inspector state object.

Drive-by rename getBackendSettings -> getInspectorState to better reflect the nature of the data.

https://bugs.webkit.org/show_bug.cgi?id=45974

WebCore:

  • inspector/Inspector.idl:
  • inspector/InspectorClient.h: (WebCore::InspectorClient::updateInspectorStateCookie):
  • inspector/InspectorController.cpp: (WebCore::InspectorController::saveApplicationSettings): (WebCore::InspectorController::getInspectorState): (WebCore::InspectorController::updateInspectorStateCookie): (WebCore::InspectorController::restoreInspectorStateFromCookie): (WebCore::InspectorController::getSettings): (WebCore::InspectorController::setMonitoringXHREnabled): (WebCore::InspectorController::restoreDebugger): (WebCore::InspectorController::restoreProfiler): (WebCore::InspectorController::setResourceTrackingEnabled): (WebCore::InspectorController::ensureSettingsLoaded): (WebCore::InspectorController::startTimelineProfiler): (WebCore::InspectorController::stopTimelineProfiler): (WebCore::InspectorController::enableProfiler): (WebCore::InspectorController::disableProfiler): (WebCore::InspectorController::enableDebuggerFromFrontend): (WebCore::InspectorController::disableDebugger):
  • inspector/InspectorController.h:
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype._handleContextMenuEvent):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype._toggleResourceTracking):
  • inspector/front-end/Settings.js: (WebInspector.Settings.initialize):
  • inspector/front-end/inspector.js: (WebInspector.doLoadedDone.populateInspectorState): (WebInspector.doLoadedDone):

WebKit/chromium:

  • src/InspectorClientImpl.cpp: (WebKit::InspectorClientImpl::updateInspectorStateCookie):
  • src/InspectorClientImpl.h:
  • src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::setRuntimeProperty): (WebKit::WebDevToolsAgentImpl::setApuAgentEnabled): (WebKit::WebDevToolsAgentImpl::updateInspectorStateCookie):
  • src/WebDevToolsAgentImpl.h:

LayoutTests:

  • http/tests/inspector/console-xhr-logging.html:
  • inspector/report-API-errors-expected.txt:
  • inspector/report-API-errors.html:
08:18 Changeset [67851] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt]REGRESSION? (r67762): 23 layout tests fail
https://bugs.webkit.org/show_bug.cgi?id=46093

  • platform/qt/Skipped: Skip failing tests until fix.
08:10 Changeset [67850] by aroben@apple.com
  • 1 edit
    1 delete in trunk/LayoutTests

Remove no-longer-needed Windows-specific results for a Sputnik Array.prototype.splice test

Rubber-stamped by Anders Carlsson.

  • platform/win/fast/js/sputnik/Conformance/15_Native_Objects/15.4_Array/15.4.4/15.4.4.12_Array_prototype_splice/S15.4.4.12_A2.1_T3-expected.txt: Removed.
08:08 Changeset [67849] by weinig@apple.com
  • 8 edits in trunk/WebKit2

Add WebKit2 API to load a string as plain text
https://bugs.webkit.org/show_bug.cgi?id=46091

Reviewed by Adam Roben.

  • Shared/CoreIPCSupport/WebPageMessageKinds.h:
  • UIProcess/API/C/WKPage.cpp:

(WKPageLoadPlainTextString):

  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::loadPlainTextString):

  • UIProcess/WebPageProxy.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::loadData):
(WebKit::WebPage::loadHTMLString):
(WebKit::WebPage::loadPlainTextString):
(WebKit::WebPage::didReceiveMessage):

  • WebProcess/WebPage/WebPage.h:
07:56 Changeset [67848] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed, update Qt specific expected result after r67770.

Canvas sizing ignores intrinsic size
https://bugs.webkit.org/show_bug.cgi?id=46024

  • platform/qt/fast/replaced/table-percent-height-expected.txt: Updated.
07:39 Changeset [67847] by krit@webkit.org
  • 55 edits in trunk/WebCore

2010-09-20 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG Filter cleanup
https://bugs.webkit.org/show_bug.cgi?id=45612


All effect inputs are stored in a Vector in FilterEffect instead of passing them via constructors to every effect type.
This simplifies the primitive subregion logic and centralizes it in determineFilterPrimitiveSubregion.
Just SourceGraphic, SourceAlpha and FETile still calculate filter primitive subregions on
their own. Working on it in a followup patch.
The subregions code is SVG specific and moving this calculation to FilterEffect is an
intermediate step before moving it to RenderSVGResourceFilterPrimitive in a following patch.
The new FilterEffectVector will also make it possible to add code to determine the
smallest used region of an effect and will help save memory and resources in the future.
subRegion got renamed to filterPrimitiveSubregion to match the name scheme. scaledSubRegion got
renamed to repaintRectInLocalCoordinates since this is its proper meaning.
Removed unnecessary member variables and functions from FilterEffect.

No new tests added since the functionality didn't change.

  • platform/graphics/cairo/GraphicsContextCairo.cpp: scaledSubRegion was renamed to repaintRectInLocalCoordinates. (WebCore::GraphicsContext::createShadowMask):
  • platform/graphics/filters/FEBlend.cpp: Removed Filter effect inputs from constructor. (WebCore::FEBlend::FEBlend): (WebCore::FEBlend::create): (WebCore::FEBlend::apply): Call inputFilterEffects to get input filter primitives. (WebCore::FEBlend::externalRepresentation): Call inputFilterEffects to get input filter primitives.
  • platform/graphics/filters/FEBlend.h:
  • platform/graphics/filters/FEColorMatrix.cpp: Ditto. (WebCore::FEColorMatrix::FEColorMatrix): (WebCore::FEColorMatrix::create): (WebCore::FEColorMatrix::apply): (WebCore::FEColorMatrix::externalRepresentation):
  • platform/graphics/filters/FEColorMatrix.h:
  • platform/graphics/filters/FEComponentTransfer.cpp: Ditto. (WebCore::FEComponentTransfer::FEComponentTransfer): (WebCore::FEComponentTransfer::create): (WebCore::FEComponentTransfer::apply): (WebCore::FEComponentTransfer::externalRepresentation):
  • platform/graphics/filters/FEComponentTransfer.h:
  • platform/graphics/filters/FEComposite.cpp: Ditto. (WebCore::FEComposite::FEComposite): (WebCore::FEComposite::create): (WebCore::FEComposite::apply): (WebCore::FEComposite::externalRepresentation):
  • platform/graphics/filters/FEComposite.h:
  • platform/graphics/filters/FEGaussianBlur.cpp: Ditto. (WebCore::FEGaussianBlur::FEGaussianBlur): (WebCore::FEGaussianBlur::create): (WebCore::FEGaussianBlur::apply): (WebCore::FEGaussianBlur::externalRepresentation):
  • platform/graphics/filters/FEGaussianBlur.h:
  • platform/graphics/filters/Filter.h: (WebCore::Filter::determineFilterPrimitiveSubregion): Renamed from calculateEffectSubRegion to match name scheme.
  • platform/graphics/filters/FilterEffect.cpp: (WebCore::FilterEffect::FilterEffect): (WebCore::FilterEffect::determineFilterPrimitiveSubregion): The main place for subregion calculation. (WebCore::FilterEffect::calculateDrawingIntRect): Takes repaintRectInLocalCoordinates now. (WebCore::FilterEffect::calculateDrawingRect): ditto. (WebCore::FilterEffect::getEffectContext): Check if ImageBuffer was created.
  • platform/graphics/filters/FilterEffect.h: Changed names to match name scheme. Removed unnecessary member variables and functions.

Seperate SVG specific member variables and functions. Will get removed in followup patches.

(WebCore::FilterEffect::resultImage):
(WebCore::FilterEffect::setEffectBuffer):
(WebCore::FilterEffect::inputEffect):
(WebCore::FilterEffect::inputEffects):
(WebCore::FilterEffect::numberOfinputEffects):
(WebCore::FilterEffect::isAlphaImage):
(WebCore::FilterEffect::setIsAlphaImage):
(WebCore::FilterEffect::repaintRectInLocalCoordinates):
(WebCore::FilterEffect::setRepaintRectInLocalCoordinates):
(WebCore::FilterEffect::isSourceInput):
(WebCore::FilterEffect::hasX):
(WebCore::FilterEffect::setHasX):
(WebCore::FilterEffect::hasY):
(WebCore::FilterEffect::setHasY):
(WebCore::FilterEffect::hasWidth):
(WebCore::FilterEffect::setHasWidth):
(WebCore::FilterEffect::hasHeight):
(WebCore::FilterEffect::setHasHeight):
(WebCore::FilterEffect::filterPrimitiveSubregion):
(WebCore::FilterEffect::setFilterPrimitiveSubregion):
(WebCore::FilterEffect::effectBoundaries):
(WebCore::FilterEffect::setEffectBoundaries):

  • platform/graphics/filters/SourceAlpha.cpp: (WebCore::SourceAlpha::determineFilterPrimitiveSubregion): Renamed to match name scheme.
  • platform/graphics/filters/SourceAlpha.h: (WebCore::SourceAlpha::isSourceInput):
  • platform/graphics/filters/SourceGraphic.cpp: (WebCore::SourceGraphic::determineFilterPrimitiveSubregion): Ditto.
  • platform/graphics/filters/SourceGraphic.h: (WebCore::SourceGraphic::isSourceInput):
  • rendering/RenderSVGResourceFilter.cpp: Adapt to renames in FilterEffect. (WebCore::RenderSVGResourceFilter::applyResource): (WebCore::RenderSVGResourceFilter::postApplyResource):
  • svg/SVGFEBlendElement.cpp: Constructor of FEBlend doesn't take input effects. Adding them afterwards. (WebCore::SVGFEBlendElement::build):
  • svg/SVGFEColorMatrixElement.cpp: Ditto. (WebCore::SVGFEColorMatrixElement::build):
  • svg/SVGFEComponentTransferElement.cpp: Ditto. (WebCore::SVGFEComponentTransferElement::build):
  • svg/SVGFECompositeElement.cpp: Ditto. (WebCore::SVGFECompositeElement::build):
  • svg/SVGFEConvolveMatrixElement.cpp: Ditto. (WebCore::SVGFEConvolveMatrixElement::build):
  • svg/SVGFEDiffuseLightingElement.cpp: Ditto. (WebCore::SVGFEDiffuseLightingElement::build):
  • svg/SVGFEDisplacementMapElement.cpp: Ditto. (WebCore::SVGFEDisplacementMapElement::build):
  • svg/SVGFEGaussianBlurElement.cpp: Ditto. (WebCore::SVGFEGaussianBlurElement::build):
  • svg/SVGFEMergeElement.cpp: Ditto. (WebCore::SVGFEMergeElement::build):
  • svg/SVGFEMorphologyElement.cpp: Ditto. (WebCore::SVGFEMorphologyElement::build):
  • svg/SVGFEOffsetElement.cpp: Ditto. (WebCore::SVGFEOffsetElement::build):
  • svg/SVGFESpecularLightingElement.cpp: Ditto. (WebCore::SVGFESpecularLightingElement::build):
  • svg/SVGFETileElement.cpp: Ditto. (WebCore::SVGFETileElement::build):
  • svg/graphics/filters/SVGFEConvolveMatrix.cpp: Ditto. (WebCore::FEConvolveMatrix::FEConvolveMatrix): (WebCore::FEConvolveMatrix::create): (WebCore::FEConvolveMatrix::apply): (WebCore::FEConvolveMatrix::externalRepresentation):
  • svg/graphics/filters/SVGFEConvolveMatrix.h:
  • svg/graphics/filters/SVGFEDiffuseLighting.cpp: Ditto. (WebCore::FEDiffuseLighting::FEDiffuseLighting): (WebCore::FEDiffuseLighting::create): (WebCore::FEDiffuseLighting::externalRepresentation):
  • svg/graphics/filters/SVGFEDiffuseLighting.h:
  • svg/graphics/filters/SVGFEDisplacementMap.cpp: Ditto. (WebCore::FEDisplacementMap::FEDisplacementMap): (WebCore::FEDisplacementMap::create): (WebCore::FEDisplacementMap::apply): (WebCore::FEDisplacementMap::externalRepresentation):
  • svg/graphics/filters/SVGFEDisplacementMap.h:
  • svg/graphics/filters/SVGFEFlood.cpp: Ditto. (WebCore::FEFlood::apply):
  • svg/graphics/filters/SVGFEImage.cpp: Ditto. (WebCore::FEImage::apply):
  • svg/graphics/filters/SVGFELighting.cpp: Ditto. (WebCore::FELighting::FELighting): (WebCore::FELighting::apply):
  • svg/graphics/filters/SVGFELighting.h:
  • svg/graphics/filters/SVGFEMerge.cpp: Ditto. (WebCore::FEMerge::FEMerge): (WebCore::FEMerge::create): (WebCore::FEMerge::apply): (WebCore::FEMerge::externalRepresentation):
  • svg/graphics/filters/SVGFEMerge.h:
  • svg/graphics/filters/SVGFEMorphology.cpp: Ditto. (WebCore::FEMorphology::FEMorphology): (WebCore::FEMorphology::create): (WebCore::FEMorphology::apply): (WebCore::FEMorphology::externalRepresentation):
  • svg/graphics/filters/SVGFEMorphology.h:
  • svg/graphics/filters/SVGFEOffset.cpp: Ditto. (WebCore::FEOffset::FEOffset): (WebCore::FEOffset::create): (WebCore::FEOffset::apply): (WebCore::FEOffset::externalRepresentation):
  • svg/graphics/filters/SVGFEOffset.h:
  • svg/graphics/filters/SVGFESpecularLighting.cpp: Ditto. (WebCore::FESpecularLighting::FESpecularLighting): (WebCore::FESpecularLighting::create): (WebCore::FESpecularLighting::externalRepresentation):
  • svg/graphics/filters/SVGFESpecularLighting.h:
  • svg/graphics/filters/SVGFETile.cpp: Ditto. (WebCore::FETile::FETile): (WebCore::FETile::create): (WebCore::FETile::determineFilterPrimitiveSubregion): Renamed to match name scheme. (WebCore::FETile::apply): (WebCore::FETile::externalRepresentation):
  • svg/graphics/filters/SVGFETile.h:
  • svg/graphics/filters/SVGFilter.cpp: Renamed itemBox to targetBoundingBox to match name scheme. (WebCore::SVGFilter::SVGFilter): (WebCore::SVGFilter::determineFilterPrimitiveSubregion): Renamed to match name scheme. (WebCore::SVGFilter::create):
  • svg/graphics/filters/SVGFilter.h: (WebCore::SVGFilter::sourceImageRect):
07:28 CommitQueue edited by paroga@webkit.org
(diff)
06:23 Changeset [67846] by jocelyn.turcotte@nokia.com
  • 2 edits in trunk/WebKit/qt

[Qt] Fix forward includes generation for MSVC when sh is in PATH.

Reviewed by Simon Hausmann.

MSVC's nmake isn't affected by having sh in PATH.

  • Api/DerivedSources.pro:
06:13 Changeset [67845] by satish@chromium.org
  • 2 edits
    2 adds in trunk/LayoutTests

2010-09-20 Satish Sampath <satish@chromium.org>

Unreviewed, updating baselines for a layout test and setting expectations for 3 others.

  • platform/chromium-linux/animations/animation-drt-api-expected.checksum: Added.
  • platform/chromium-linux/animations/animation-drt-api-expected.png: Added.
  • platform/chromium/test_expectations.txt:
04:42 Changeset [67844] by commit-queue@webkit.org
  • 5 edits in trunk/WebCore

2010-09-20 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: highlight DOM node when hover on link element or DOM breakpoint
https://bugs.webkit.org/show_bug.cgi?id=45897

04:27 Changeset [67843] by satish@chromium.org
  • 2 edits
    6 adds in trunk/LayoutTests

2010-09-20 Satish Sampath <satish@chromium.org>

Unreviewed, updating baselines for a layout test and adding 5 others to the skip list.

  • platform/chromium-linux/fast/css/preserve-user-specified-zoom-level-on-reload-expected.checksum: Added.
  • platform/chromium-linux/fast/css/preserve-user-specified-zoom-level-on-reload-expected.png: Added.
  • platform/chromium-linux/fast/css/preserve-user-specified-zoom-level-on-reload-expected.txt: Added.
  • platform/chromium-win/fast/css/preserve-user-specified-zoom-level-on-reload-expected.checksum: Added.
  • platform/chromium-win/fast/css/preserve-user-specified-zoom-level-on-reload-expected.png: Added.
  • platform/chromium-win/fast/css/preserve-user-specified-zoom-level-on-reload-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
03:57 Changeset [67842] by ossy@webkit.org
  • 19 edits in trunk/LayoutTests

Unreviewed. Update Qt specific expected results after r67660.

Paginate and column-break at layout time rather than when painting
https://bugs.webkit.org/show_bug.cgi?id=38402

  • platform/qt/fast/multicol/client-rects-expected.txt:
  • platform/qt/fast/multicol/column-count-with-rules-expected.txt:
  • platform/qt/fast/multicol/float-paginate-expected.txt:
  • platform/qt/fast/multicol/layers-in-multicol-expected.txt:
  • platform/qt/fast/multicol/nested-columns-expected.txt:
  • platform/qt/fast/multicol/paginate-block-replaced-expected.txt:
  • platform/qt/fast/multicol/positioned-with-constrained-height-expected.txt:
  • platform/qt/fast/multicol/span/anonymous-style-inheritance-expected.txt:
  • platform/qt/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.txt:
  • platform/qt/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt:
  • platform/qt/fast/multicol/span/span-as-immediate-child-property-removal-expected.txt:
  • platform/qt/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.txt:
  • platform/qt/fast/multicol/span/span-as-immediate-columns-child-expected.txt:
  • platform/qt/fast/multicol/span/span-as-immediate-columns-child-removal-expected.txt:
  • platform/qt/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.txt:
  • platform/qt/fast/multicol/span/span-as-nested-columns-child-expected.txt:
  • platform/qt/fast/multicol/span/span-margin-collapsing-expected.txt:
  • platform/qt/fast/repaint/multicol-repaint-expected.txt:
01:28 Changeset [67841] by pfeldman@chromium.org
  • 5 edits in branches/chromium/517/WebCore

Merge 67709 - 2010-09-17 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: FrameLoader::loadedResourceFromMemoryCache reports
resource as not cached to InspectorController.
https://bugs.webkit.org/show_bug.cgi?id=45961

There is one path in control flow that leads to resources being
reported as not cached. Patch to follow.

  • inspector/InspectorController.cpp: (WebCore::InspectorController::markResourceAsCached):
  • inspector/InspectorController.h:
  • inspector/InspectorResource.cpp: (WebCore::InspectorResource::markAsCached): (WebCore::InspectorResource::updateResponse):
  • inspector/InspectorResource.h:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::loadedResourceFromMemoryCache):

TBR=pfeldman@chromium.org
Review URL: http://codereview.chromium.org/3441018

00:10 Changeset [67840] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

2010-09-20 James Kozianski <koz@chromium.org>

Reviewed by Ojan Vafai.

[chromium] Unskip the canvas philip suite
https://bugs.webkit.org/show_bug.cgi?id=45991

Adds failing mac canvas/philip tests to test_expectations.txt.

  • platform/chromium/test_expectations.txt:

09/19/10:

23:16 Changeset [67839] by abarth@webkit.org
  • 2 edits in trunk/BugsSite

2010-09-19 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

[reviewtool] Publish button should actually publish the review comments
https://bugs.webkit.org/show_bug.cgi?id=46074

Instead of showing the confirmation lightbox, the Publish button now
publishes the comments directly. If there's demand for a "Preview"
button, we can find a way to add that feature.

  • code-review.js:
22:29 Changeset [67838] by weinig@apple.com
  • 2 edits in trunk/WebKit2

Fix windows build.

  • UIProcess/API/C/WKPage.h:
22:23 Changeset [67837] by weinig@apple.com
  • 2 edits in trunk/WebKit2

Attempt to fix Qt build.

  • WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::WebEditorClient::doTextFieldCommandFromEvent):

22:20 Changeset [67836] by weinig@apple.com
  • 5 edits in trunk/WebKit2

Add WebKit2 equivalent of the WebFormDelegate's doCommandBySelector
<rdar://problem/8377088>
https://bugs.webkit.org/show_bug.cgi?id=46073

Reviewed by Anders Carlsson.

Add bundle client to match the behavior of:

  • (BOOL)textField:(DOMHTMLInputElement *)element doCommandBySelector:(SEL)commandSelector inFrame:(WebFrame *)frame;
  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/InjectedBundle/InjectedBundlePageFormClient.cpp:

(WebKit::InjectedBundlePageFormClient::shouldPerformActionInTextField):

  • WebProcess/InjectedBundle/InjectedBundlePageFormClient.h:
  • WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::getActionTypeForKeyEvent):
(WebKit::WebEditorClient::doTextFieldCommandFromEvent):
(WebKit::WebEditorClient::textWillBeDeletedInTextField):

21:26 Changeset [67835] by abarth@webkit.org
  • 3 edits in trunk/BugsSite

2010-09-19 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Move reviewtool to action=review
https://bugs.webkit.org/show_bug.cgi?id=46071

This patch removes the old Review Patch screen and moves the new
reviewtool from Pretty Diff to Review Patch.

  • attachment.cgi:
  • code-review.js:
21:06 Changeset [67834] by weinig@apple.com
  • 10 edits in trunk

WebKit2 decidePolicyForNavigationAction should include mouse button information
<rdar://problem/8413165>
https://bugs.webkit.org/show_bug.cgi?id=46060

Reviewed by Anders Carlsson.

WebKit2:

  • UIProcess/API/C/WKAPICast.h:

(WebKit::toRef):

  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didReceiveMessage):
(WebKit::WebPageProxy::decidePolicyForNavigationAction):
(WebKit::WebPageProxy::decidePolicyForNewWindowAction):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPolicyClient.cpp:

(WebKit::WebPolicyClient::decidePolicyForNavigationAction):
(WebKit::WebPolicyClient::decidePolicyForNewWindowAction):

  • UIProcess/WebPolicyClient.h:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::findMouseEvent):
(WebKit::mouseButtonForNavigationAction):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):

WebKitTools:

  • MiniBrowser/mac/BrowserWindowController.m:

(decidePolicyForNavigationAction):
(decidePolicyForNewWindowAction):

20:05 Changeset [67833] by abarth@webkit.org
  • 2 edits in trunk/BugsSite

2010-09-19 Adam Barth <abarth@webkit.org>

Review tool UI tweak. This patch lengthens the status bubbles so all
the bubble fit (even when they have numbers inside).

  • PrettyPatch/PrettyPatch.rb:
19:41 Changeset [67832] by dbates@webkit.org
  • 2 edits in trunk/WebKitTools

2010-09-19 Daniel Bates <dbates@rim.com>

Reviewed by Martin Robinson.

Add unit tests for diffs that delete or modify a change log entry
or describe changes that are far apart
https://bugs.webkit.org/show_bug.cgi?id=46046

Add additional unit tests to test change log diffs that contain
deletions or changes that are far apart from each other in the
ChangeLog file.

  • Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
    • Added the following unit tests: "fixChangeLogPatch: [no change] In-place change." "fixChangeLogPatch: [no change] Remove first entry." "fixChangeLogPatch: [no change] Remove entry in the middle." "fixChangeLogPatch: [no change] Far apart changes (i.e. more than one chunk)."
19:27 Changeset [67831] by abarth@webkit.org
  • 12 edits in trunk

2010-09-19 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r67749.
http://trac.webkit.org/changeset/67749
https://bugs.webkit.org/show_bug.cgi?id=46068

breaking ToT chromium canary build (Requested by shans on
#webkit).

  • bindings/v8/V8DOMWindowShell.cpp: (WebCore::V8DOMWindowShell::createNewContext):
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::registeredExtensionWithV8): (WebCore::V8Proxy::registerExtension):
  • bindings/v8/V8Proxy.h:
  • loader/EmptyClients.h:
  • loader/FrameLoaderClient.h:

2010-09-19 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r67749.
http://trac.webkit.org/changeset/67749
https://bugs.webkit.org/show_bug.cgi?id=46068

breaking ToT chromium canary build (Requested by shans on
#webkit).

  • public/WebFrameClient.h:
  • public/WebScriptController.h:
  • src/FrameLoaderClientImpl.cpp:
  • src/FrameLoaderClientImpl.h:
  • src/WebScriptController.cpp: (WebKit::WebScriptController::registerExtension):
19:00 Changeset [67830] by dglazkov@chromium.org
  • 1 edit
    16 moves in trunk/LayoutTests

2010-09-19 Dimitri Glazkov <dglazkov@chromium.org>

Move win-xp-specific baselines to their proper places.

  • platform/chromium-win-xp/fast/forms/search-styled-expected.txt: Renamed from LayoutTests/platform/chromium-win/fast/forms/search-styled-expected.txt.
  • platform/chromium-win-xp/fast/text/backslash-to-yen-sign-expected.checksum: Renamed from LayoutTests/platform/chromium-win/fast/text/backslash-to-yen-sign-expected.checksum.
  • platform/chromium-win-xp/fast/text/backslash-to-yen-sign-expected.png: Renamed from LayoutTests/platform/chromium-win/fast/text/backslash-to-yen-sign-expected.png.
  • platform/chromium-win-xp/fast/text/backslash-to-yen-sign-expected.txt: Renamed from LayoutTests/platform/chromium-win/fast/text/backslash-to-yen-sign-expected.txt.
  • platform/chromium-win-xp/fast/text/international/bidi-mirror-he-ar-expected.checksum: Renamed from LayoutTests/platform/chromium-win/fast/text/international/bidi-mirror-he-ar-expected.checksum.
  • platform/chromium-win-xp/fast/text/international/bidi-mirror-he-ar-expected.png: Renamed from LayoutTests/platform/chromium-win/fast/text/international/bidi-mirror-he-ar-expected.png.
  • platform/chromium-win-xp/fast/text/international/bidi-mirror-he-ar-expected.txt: Renamed from LayoutTests/platform/chromium-win/fast/text/international/bidi-mirror-he-ar-expected.txt.
  • platform/chromium-win-xp/fast/text/international/hindi-whitespace-expected.checksum: Renamed from LayoutTests/platform/chromium-win/fast/text/international/hindi-whitespace-expected.checksum.
  • platform/chromium-win-xp/fast/text/international/hindi-whitespace-expected.png: Renamed from LayoutTests/platform/chromium-win/fast/text/international/hindi-whitespace-expected.png.
  • platform/chromium-win-xp/fast/text/international/hindi-whitespace-expected.txt: Renamed from LayoutTests/platform/chromium-win/fast/text/international/hindi-whitespace-expected.txt.
  • platform/chromium-win-xp/fast/text/international/plane2-expected.checksum: Renamed from LayoutTests/platform/chromium-win/fast/text/international/plane2-expected.checksum.
  • platform/chromium-win-xp/fast/text/international/plane2-expected.png: Renamed from LayoutTests/platform/chromium-win/fast/text/international/plane2-expected.png.
  • platform/chromium-win-xp/fast/text/international/plane2-expected.txt: Renamed from LayoutTests/platform/chromium-win/fast/text/international/plane2-expected.txt.
  • platform/chromium-win-xp/svg/text/text-intro-05-t-expected.checksum: Renamed from LayoutTests/platform/chromium-win/svg/text/text-intro-05-t-expected.checksum.
  • platform/chromium-win-xp/svg/text/text-intro-05-t-expected.png: Renamed from LayoutTests/platform/chromium-win/svg/text/text-intro-05-t-expected.png.
  • platform/chromium-win-xp/svg/text/text-intro-05-t-expected.txt: Renamed from LayoutTests/platform/chromium-win/svg/text/text-intro-05-t-expected.txt.
18:59 Changeset [67829] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Windows build fix pt 2.

18:52 Changeset [67828] by abarth@webkit.org
  • 3 edits
    2 deletes in trunk/LayoutTests

2010-09-19 Mihai Parparita <mihaip@chromium.org>

Reviewed by Dimitri Glazkov.

[Chromium] userscripts/user-script-top-frame-only.html has incorrect expectations
https://bugs.webkit.org/show_bug.cgi?id=46064

r62958 added incorrect expectations for this test. Chromium DRT actually
gets this test right if we let it use the base expectations file. Mark
the test as failing with test_shell only.

  • platform/chromium-mac/userscripts/user-script-top-frame-only-expected.txt: Removed.
  • platform/chromium-win/userscripts/user-script-top-frame-only-expected.txt: Removed.
  • platform/chromium/drt_expectations.txt:
  • platform/chromium/test_expectations.txt:
18:43 Changeset [67827] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Windows build fix pt 1.

18:35 Changeset [67826] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Build fix - implicit double-to-int conversion invalid on 32-bit.

  • runtime/DatePrototype.cpp:

(JSC::fillStructuresUsingDateArgs):
(JSC::dateProtoFuncSetYear):

18:23 Changeset [67825] by barraclough@apple.com
  • 12 edits
    3 adds in trunk

Bug 46065 - Unify implementation of ToInt32 and ToUInt32, don't use fmod.

Reviewed by Oliver Hunt.

These methods implement the same conversion (see discussion in the notes
of sections of 9.5 and 9.6 of the spec), only differing in how the result
is interpretted.

JavaScriptCore:

Date prototype is incorrectly using toInt32, and this is causing us to
provide an output value indicating whether the input to ToInt32 was finite
(the corresponding methods on Date are actually spec'ed to use ToInteger,
not ToInt32). This patch partially fixes this in order to remove this
bogus output value, hoewever more work will be require to bring Date
fully up to spec compliance (the constructor is still performing ToInt32
conversions).

(JSC::fillStructuresUsingTimeArgs):
(JSC::fillStructuresUsingDateArgs):
(JSC::dateProtoFuncSetYear):

  • runtime/JSValue.cpp:

(JSC::toInt32):

  • runtime/JSValue.h:

(JSC::toUInt32):
(JSC::JSValue::toInt32):
(JSC::JSValue::toUInt32):

WebCore:

Removing JSValue::toInt32 (since this has weird, non-spec function).
A couple of places in the binding are using this method, so adding
finiteInt32Value to the bindings to maintain current behaviour.

Test: fast/js/toInt32UInt32.html

  • bindings/js/JSDOMBinding.h:

(WebCore::finiteInt32Value):

  • bindings/js/JSHTMLOptionsCollectionCustom.cpp:

(WebCore::JSHTMLOptionsCollection::add):

  • bindings/js/JSSQLResultSetRowListCustom.cpp:

(WebCore::JSSQLResultSetRowList::item):

  • bindings/js/JSSVGPODListCustom.h:

(WebCore::JSSVGPODListCustom::getItem):
(WebCore::JSSVGPODListCustom::insertItemBefore):
(WebCore::JSSVGPODListCustom::replaceItem):
(WebCore::JSSVGPODListCustom::removeItem):

  • bindings/js/JSSVGPathSegListCustom.cpp:

(WebCore::JSSVGPathSegList::getItem):
(WebCore::JSSVGPathSegList::insertItemBefore):
(WebCore::JSSVGPathSegList::replaceItem):
(WebCore::JSSVGPathSegList::removeItem):

LayoutTests:

Add test cases for ToInt32 / ToUInt32 functionality.

  • fast/js/script-tests/toInt32UInt32.js: Added.
  • fast/js/toInt32UInt32-expected.txt: Added.
  • fast/js/toInt32UInt32.html: Added.
16:45 Changeset [67824] by dglazkov@chromium.org
  • 1 edit
    2 moves
    2 deletes in trunk/LayoutTests

2010-09-19 Dimitri Glazkov <dglazkov@chromium.org>

Fix up expectation sadness I introduced in http://trac.webkit.org/changeset/67822, because no sadness is allowed.

  • platform/chromium-win-vista/css2.1/t1202-counter-09-b-expected.checksum: Renamed from LayoutTests/platform/chromium-win-vista/css2.1/t1202-counter-09-b-checksum.png.
  • platform/chromium-win-vista/css2.1/t1202-counters-09-b-expected.checksum: Renamed from LayoutTests/platform/chromium-win-vista/css2.1/t1202-counters-09-b-checksum.png.
  • platform/chromium-win-xp/svg/batik/text/textFeatures-expected.checksum: Removed.
  • platform/chromium-win-xp/svg/batik/text/textFeatures-expected.png: Removed.
15:46 Changeset [67823] by dglazkov@chromium.org
  • 3 edits
    1 add in trunk/LayoutTests

2010-09-19 Dimitri Glazkov <dglazkov@chromium.org>

Create one more text baseline for win-vista.

  • platform/chromium-win-vista/fast/forms/search-styled-expected.txt: Added.
  • platform/chromium/drt_expectations.txt: Removed search-styled as it's now passing.
  • platform/chromium/test_expectations.txt: Removed an errant line break.
15:31 Changeset [67822] by dglazkov@chromium.org
  • 6 edits
    20 adds
    2 deletes in trunk/LayoutTests

2010-09-19 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Adam Barth.

Update win-vista baselines for Chromium to make a few more tests pass.
https://bugs.webkit.org/show_bug.cgi?id=46056

  • platform/chromium-win-vista/css2.1/t1202-counter-09-b-checksum.png: Added.
  • platform/chromium-win-vista/css2.1/t1202-counter-09-b-expected.png: Added.
  • platform/chromium-win-vista/css2.1/t1202-counters-09-b-checksum.png: Added.
  • platform/chromium-win-vista/css2.1/t1202-counters-09-b-expected.png: Added.
  • platform/chromium-win-vista/fast/text/atsui-spacing-features-expected.checksum:
  • platform/chromium-win-vista/fast/text/atsui-spacing-features-expected.png:
  • platform/chromium-win-vista/fast/text/backslash-to-yen-sign-expected.checksum: Added.
  • platform/chromium-win-vista/fast/text/backslash-to-yen-sign-expected.png: Added.
  • platform/chromium-win-vista/fast/text/backslash-to-yen-sign-expected.txt: Added.
  • platform/chromium-win-vista/fast/text/international/bidi-mirror-he-ar-expected.checksum: Added.
  • platform/chromium-win-vista/fast/text/international/bidi-mirror-he-ar-expected.png: Added.
  • platform/chromium-win-vista/fast/text/international/bidi-mirror-he-ar-expected.txt: Added.
  • platform/chromium-win-vista/fast/text/international/hindi-spacing-expected.checksum: Added.
  • platform/chromium-win-vista/fast/text/international/hindi-spacing-expected.png: Added.
  • platform/chromium-win-vista/fast/text/international/hindi-whitespace-expected.checksum: Added.
  • platform/chromium-win-vista/fast/text/international/hindi-whitespace-expected.png: Added.
  • platform/chromium-win-vista/fast/text/international/plane2-expected.checksum: Added.
  • platform/chromium-win-vista/fast/text/international/plane2-expected.png: Added.
  • platform/chromium-win-vista/fast/text/international/plane2-expected.txt: Added.
  • platform/chromium-win-vista/svg/batik/text/textFeatures-expected.checksum: Removed.
  • platform/chromium-win-vista/svg/batik/text/textFeatures-expected.png: Removed.
  • platform/chromium-win-vista/svg/batik/text/verticalText-expected.checksum:
  • platform/chromium-win-vista/svg/batik/text/verticalText-expected.png:
  • platform/chromium-win-vista/svg/text/text-intro-05-t-expected.checksum: Added.
  • platform/chromium-win-vista/svg/text/text-intro-05-t-expected.png: Added.
  • platform/chromium/drt_expectations.txt: Removed expectations of failure, also added more info on remaining Windows failures.
15:09 Changeset [67821] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2010-09-19 Adam Barth <abarth@webkit.org>

Turns out these still fail.

  • platform/chromium/test_expectations.txt:
14:57 Changeset [67820] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2010-09-19 Adam Barth <abarth@webkit.org>

These tests now pass. Go team.

  • platform/chromium/test_expectations.txt:
14:14 Changeset [67819] by andreas.kling@nokia.com
  • 2 edits in trunk/WebCore

2010-09-19 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] clipBoundingRect() should return rect relevant to current layer
https://bugs.webkit.org/show_bug.cgi?id=46059

r65791 inadvertently changed clipBoundingRect() to always use the GC painter
without checking the TransparencyLayer stack first.

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContextPlatformPrivate::p): (WebCore::GraphicsContextPlatformPrivate::clipBoundingRect):
14:10 Changeset [67818] by weinig@apple.com
  • 3 edits in trunk/WebCore

Replace WKBundleRangeRef with WKBundleRangeHandleRef.
https://bugs.webkit.org/show_bug.cgi?id=46054

Reviewed by Anders Carlsson.

  • WebCore.exp.in:
  • WebCore.xcodeproj/project.pbxproj:
14:08 Changeset [67817] by abarth@webkit.org
  • 3 edits in trunk/LayoutTests

2010-09-19 Adam Barth <abarth@webkit.org>

Also update mac-leopard and mac-tiger.
See https://bugs.webkit.org/show_bug.cgi?id=46042

  • platform/mac-leopard/platform/mac/fast/loader/file-url-mimetypes-2-expected.txt:
  • platform/mac-tiger/platform/mac/fast/loader/file-url-mimetypes-2-expected.txt:
12:54 Changeset [67816] by paroga@webkit.org
  • 3 edits in trunk/WebCore

2010-09-19 Patrick Gansterer <paroga@paroga.com>

Unreviewed.

[WINCE] Buildfix for Gradient after r67801.

  • platform/graphics/Gradient.h:
  • platform/graphics/wince/GradientWinCE.cpp: (WebCore::Gradient::getStops):
11:25 Changeset [67815] by ossy@webkit.org
  • 2 edits in trunk/WebKit2

[Qt] Unreviewed buildfix after r67813.

Replace WKBundleRangeRef with WKBundleRangeHandleRef.
https://bugs.webkit.org/show_bug.cgi?id=46054

  • DerivedSources.pro: Add WebCore/generated/JSRange.h to WEBCORE_GENERATED_HEADERS_FOR_WEBKIT2
10:47 Changeset [67814] by ossy@webkit.org
  • 2 edits in trunk/WebKit2

[Qt] Unreviewed buildfix after r67802.

WebKit2: Improve/unify the PageLoadClient interfaces.
https://bugs.webkit.org/show_bug.cgi?id=46043

  • UIProcess/API/qt/ClientImpl.h:
10:40 Changeset [67813] by weinig@apple.com
  • 19 edits
    4 adds
    2 deletes in trunk

Replace WKBundleRangeRef with WKBundleRangeHandleRef.
https://bugs.webkit.org/show_bug.cgi?id=46054

Reviewed by Anders Carlsson.

The new one acts like WKBundleNodeHandleRef and allows for getting a
wrapper in a specific world for the handle.

WebKit2:

  • Shared/APIObject.h:
  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:
  • WebProcess/InjectedBundle/API/c/WKBundleBase.h:
  • WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:

(WKBundleFrameGetJavaScriptWrapperForRangeForWorld):

  • WebProcess/InjectedBundle/API/c/WKBundleFrame.h:
  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/InjectedBundle/API/c/WKBundleRange.cpp: Removed.
  • WebProcess/InjectedBundle/API/c/WKBundleRange.h: Removed.
  • WebProcess/InjectedBundle/API/c/WKBundleRangeHandle.cpp: Added.

(WKBundleRangeHandleGetTypeID):

  • WebProcess/InjectedBundle/API/c/WKBundleRangeHandle.h: Added.
  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:

(WebKit::InjectedBundleNodeHandle::getOrCreate):

  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h:
  • WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.cpp: Added.

(WebKit::domHandleCache):
(WebKit::InjectedBundleRangeHandle::getOrCreate):
(WebKit::InjectedBundleRangeHandle::create):
(WebKit::InjectedBundleRangeHandle::InjectedBundleRangeHandle):
(WebKit::InjectedBundleRangeHandle::~InjectedBundleRangeHandle):
(WebKit::InjectedBundleRangeHandle::coreRange):

  • WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.h: Added.

(WebKit::InjectedBundleRangeHandle::type):

  • WebProcess/InjectedBundle/InjectedBundlePageEditorClient.cpp:

(WebKit::InjectedBundlePageEditorClient::shouldBeginEditing):
(WebKit::InjectedBundlePageEditorClient::shouldEndEditing):
(WebKit::InjectedBundlePageEditorClient::shouldInsertNode):
(WebKit::InjectedBundlePageEditorClient::shouldInsertText):
(WebKit::InjectedBundlePageEditorClient::shouldDeleteRange):
(WebKit::InjectedBundlePageEditorClient::shouldChangeSelectedRange):
(WebKit::InjectedBundlePageEditorClient::shouldApplyStyle):

  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::jsWrapperForWorld):

  • WebProcess/WebPage/WebFrame.h:
  • win/WebKit2.vcproj:
  • win/WebKit2Generated.make:

WebKitTools:

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::propertyValue):
(WTR::propertyValueDouble):
(WTR::propertyValueInt):
(WTR::numericWindowPropertyValue):
(WTR::toStr):
(WTR::InjectedBundlePage::shouldBeginEditing):
(WTR::InjectedBundlePage::shouldEndEditing):
(WTR::InjectedBundlePage::shouldInsertNode):
(WTR::InjectedBundlePage::shouldInsertText):
(WTR::InjectedBundlePage::shouldDeleteRange):
(WTR::InjectedBundlePage::shouldChangeSelectedRange):
(WTR::InjectedBundlePage::shouldApplyStyle):

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
10:37 Changeset [67812] by mitz@apple.com
  • 2 edits in trunk/BugsSite

Fixed a typo.

Reviewed by Anders Carlsson.

  • code-review.js: Changed the label of the OK button from Ok to OK.
06:31 Changeset [67811] by tkent@chromium.org
  • 5 edits in trunk

2010-09-19 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[Chromium] Add is<input type>() functions to WebInputElement
https://bugs.webkit.org/show_bug.cgi?id=46035

  • html/HTMLInputElement.h: (WebCore::HTMLInputElement::isText): Added. It is used by WebKit/chromium.

2010-09-19 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[Chromium] Add is<input type>() functions to WebInputElement
https://bugs.webkit.org/show_bug.cgi?id=46035

We're going to stop exposing HTMLInputElemnt::InputType. So, add
isFoo() functions in order to remove WebInputElement::InputType.

  • public/WebInputElement.h:
  • src/WebInputElement.cpp: (WebKit::WebInputElement::isTextField): (WebKit::WebInputElement::isText): (WebKit::WebInputElement::isPasswordField): (WebKit::WebInputElement::isImageButton):
06:30 Changeset [67810] by tkent@chromium.org
  • 2 edits in trunk/WebKitTools

2010-09-19 Kent Tamura <tkent@chromium.org>

Unreviewed. Fix WebGL test regressions by r67809.

  • DumpRenderTree/chromium/WebPreferences.cpp: (WebPreferences::applyTo): Call setExperimentalWebGLEnabled().
05:55 Changeset [67809] by tkent@chromium.org
  • 7 edits
    2 adds in trunk

2010-09-19 Kent Tamura <tkent@chromium.org>

Reviewed by Adam Barth.

[DRT/Chromium] Fix a WebSettings handling bug
https://bugs.webkit.org/show_bug.cgi?id=45945

  • platform/chromium/drt_expectations.txt: Remove link-opens-new-window.html, which is fixed by this revision.

2010-09-19 Kent Tamura <tkent@chromium.org>

Reviewed by Adam Barth.

[DRT/Chromium] Fix a WebSettings handling bug
https://bugs.webkit.org/show_bug.cgi?id=45945

Before this change, Chromium DRT reset WebSettings for every new
window. It was wrong.
If new window is not the first one, we have to apply the same
settings as the first window. So, we introduce WebPreference to
store the current settings, and apply it to new windows. It's same
as test_shell's behavior.

  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/chromium/LayoutTestController.cpp: Use WebPreferences instead of WebSettings. (LayoutTestController::setUserStyleSheetEnabled): (LayoutTestController::setUserStyleSheetLocation): (LayoutTestController::setAuthorAndUserStylesEnabled): (LayoutTestController::setPopupBlockingEnabled): (LayoutTestController::disableImageLoading): (LayoutTestController::setJavaScriptCanAccessClipboard): (LayoutTestController::setXSSAuditorEnabled): (LayoutTestController::setAllowUniversalAccessFromFileURLs): (LayoutTestController::setAllowFileAccessFromFileURLs): (LayoutTestController::overridePreference): (LayoutTestController::setEditingBehavior):
  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::resetWebSettings): Use WebPreferences. (TestShell::runFileTest): ditto. (TestShell::createNewWindow): Apply existing WebPreferences to a new WebView.
  • DumpRenderTree/chromium/TestShell.h: (TestShell::preferences): (TestShell::applyPreferences):
  • DumpRenderTree/chromium/WebPreferences.cpp: Added.
  • DumpRenderTree/chromium/WebPreferences.h: Added.

09/18/10:

20:12 Changeset [67808] by andreas.kling@nokia.com
  • 3 edits in trunk/WebCore

2010-09-18 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Antonio Gomes.

[Qt] Path: Remove unused member variable
https://bugs.webkit.org/show_bug.cgi?id=46048

Path::m_lastMoveToIndex is not used for anything, so remove it.

  • platform/graphics/Path.h:
  • platform/graphics/qt/PathQt.cpp: (WebCore::Path::Path): (WebCore::Path::operator=): (WebCore::Path::moveTo):
20:01 Changeset [67807] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2010-09-18 Patrick Gansterer <paroga@paroga.com>

Reviewed by Darin Adler.

Use AtomicString insted of String in XMLDocumentParser
https://bugs.webkit.org/show_bug.cgi?id=45990

Create AtomicString as early as possible.
This can avoid unnecessary memcpy of String content.

  • dom/XMLDocumentParser.h:
  • dom/XMLDocumentParserLibxml2.cpp: (WebCore::toAtomicString): (WebCore::handleElementNamespaces): (WebCore::handleElementAttributes): (WebCore::XMLDocumentParser::startElementNs):
18:21 Changeset [67806] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-09-18 Prasad Tammana <prasadt@chromium.org>

Reviewed by David Levin.

update-webkit --chromium spitting out a spurious error
https://bugs.webkit.org/show_bug.cgi?id=45868

  • Scripts/update-webkit-chromium: Use commandExists() function to check for existence of gclient.
18:05 Changeset [67805] by abarth@webkit.org
  • 7 edits in trunk

2010-09-18 Erik Arvidsson <arv@chromium.org>

Reviewed by Nate Chapin.

[Chromium] fast/dom/dataset-gc.html is failing
https://bugs.webkit.org/show_bug.cgi?id=45426

  • platform/chromium/test_expectations.txt:

2010-09-18 Erik Arvidsson <arv@chromium.org>

Reviewed by Nate Chapin.

[Chromium] fast/dom/dataset-gc.html is failing
https://bugs.webkit.org/show_bug.cgi?id=45426

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/custom/V8DOMStringMapCustom.cpp: (WebCore::toV8):
  • dom/DOMStringMap.h:
  • dom/DatasetDOMStringMap.h: (WebCore::DatasetDOMStringMap::element):
17:52 Changeset [67804] by andreas.kling@nokia.com
  • 2 edits in trunk/WebCore

2010-09-18 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Oliver Hunt.

Gradient: Fast-path for the ideal case in sortStopsIfNecessary()
https://bugs.webkit.org/show_bug.cgi?id=46045

Avoid calling std::stable_sort for 2-stop gradients that are already in order.

  • platform/graphics/Gradient.cpp: (WebCore::Gradient::sortStopsIfNecessary):
17:46 Changeset [67803] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-09-18 Kwang Yul Seo <skyul@company100.net>

Reviewed by Andreas Kling.

[BREWMP] Fix a typo in key code name
https://bugs.webkit.org/show_bug.cgi?id=46003

AVK_CLR is the right Brew MP key code name for VK_BACK.

  • platform/brew/PlatformKeyboardEventBrew.cpp: (WebCore::windowsKeyCodeForKeyEvent):
17:30 Changeset [67802] by weinig@apple.com
  • 17 edits in trunk

WebKit2: Improve/unify the PageLoadClient interfaces.
https://bugs.webkit.org/show_bug.cgi?id=46043

Reviewed by Dan Bernstein.

  • Ensure that all the PageLoadClient functions (that are load related) have bundle API equivalents (this meant adding didFirstLayoutForFrame and didFirstVisuallyNonEmptyLayoutForFrame to the BundlePageLoadClient).
  • Add a userData out parameters to all the now paired BundlePageLoadClient functions, and a matching userData parameter to the PageLoadClient ones.
  • UIProcess/API/C/WKPage.h:
  • UIProcess/API/qt/ClientImpl.cpp:

(qt_wk_didStartProvisionalLoadForFrame):
(qt_wk_didReceiveServerRedirectForProvisionalLoadForFrame):
(qt_wk_didFailProvisionalLoadWithErrorForFrame):
(qt_wk_didCommitLoadForFrame):
(qt_wk_didFinishDocumentLoadForFrame):
(qt_wk_didFinishLoadForFrame):
(qt_wk_didFailLoadWithErrorForFrame):
(qt_wk_didReceiveTitleForFrame):
(qt_wk_didFirstLayoutForFrame):
(qt_wk_didFirstVisuallyNonEmptyLayoutForFrame):

  • UIProcess/WebLoaderClient.cpp:

(WebKit::WebLoaderClient::didStartProvisionalLoadForFrame):
(WebKit::WebLoaderClient::didReceiveServerRedirectForProvisionalLoadForFrame):
(WebKit::WebLoaderClient::didFailProvisionalLoadWithErrorForFrame):
(WebKit::WebLoaderClient::didCommitLoadForFrame):
(WebKit::WebLoaderClient::didFinishDocumentLoadForFrame):
(WebKit::WebLoaderClient::didFinishLoadForFrame):
(WebKit::WebLoaderClient::didFailLoadWithErrorForFrame):
(WebKit::WebLoaderClient::didReceiveTitleForFrame):
(WebKit::WebLoaderClient::didFirstLayoutForFrame):
(WebKit::WebLoaderClient::didFirstVisuallyNonEmptyLayoutForFrame):
(WebKit::WebLoaderClient::didStartProgress):
(WebKit::WebLoaderClient::didChangeProgress):
(WebKit::WebLoaderClient::didFinishProgress):
(WebKit::WebLoaderClient::didBecomeUnresponsive):
(WebKit::WebLoaderClient::didBecomeResponsive):
(WebKit::WebLoaderClient::processDidExit):
(WebKit::WebLoaderClient::didChangeBackForwardList):

  • UIProcess/WebLoaderClient.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didReceiveMessage):
(WebKit::WebPageProxy::didStartProvisionalLoadForFrame):
(WebKit::WebPageProxy::didReceiveServerRedirectForProvisionalLoadForFrame):
(WebKit::WebPageProxy::didFailProvisionalLoadForFrame):
(WebKit::WebPageProxy::didCommitLoadForFrame):
(WebKit::WebPageProxy::didFinishDocumentLoadForFrame):
(WebKit::WebPageProxy::didFinishLoadForFrame):
(WebKit::WebPageProxy::didFailLoadForFrame):
(WebKit::WebPageProxy::didReceiveTitleForFrame):
(WebKit::WebPageProxy::didFirstLayoutForFrame):
(WebKit::WebPageProxy::didFirstVisuallyNonEmptyLayoutForFrame):

  • UIProcess/WebPageProxy.h:
  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:

(WebKit::InjectedBundlePageLoaderClient::didStartProvisionalLoadForFrame):
(WebKit::InjectedBundlePageLoaderClient::didReceiveServerRedirectForProvisionalLoadForFrame):
(WebKit::InjectedBundlePageLoaderClient::didFailProvisionalLoadWithErrorForFrame):
(WebKit::InjectedBundlePageLoaderClient::didCommitLoadForFrame):
(WebKit::InjectedBundlePageLoaderClient::didFinishDocumentLoadForFrame):
(WebKit::InjectedBundlePageLoaderClient::didFinishLoadForFrame):
(WebKit::InjectedBundlePageLoaderClient::didFailLoadWithErrorForFrame):
(WebKit::InjectedBundlePageLoaderClient::didReceiveTitleForFrame):
(WebKit::InjectedBundlePageLoaderClient::didFirstLayoutForFrame):
(WebKit::InjectedBundlePageLoaderClient::didFirstVisuallyNonEmptyLayoutForFrame):
(WebKit::InjectedBundlePageLoaderClient::didClearWindowObjectForFrame):
(WebKit::InjectedBundlePageLoaderClient::didCancelClientRedirectForFrame):
(WebKit::InjectedBundlePageLoaderClient::willPerformClientRedirectForFrame):
(WebKit::InjectedBundlePageLoaderClient::didChangeLocationWithinPageForFrame):
(WebKit::InjectedBundlePageLoaderClient::didHandleOnloadEventsForFrame):
(WebKit::InjectedBundlePageLoaderClient::didDisplayInsecureContentForFrame):
(WebKit::InjectedBundlePageLoaderClient::didRunInsecureContentForFrame):

  • WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad):
(WebKit::WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
(WebKit::WebFrameLoaderClient::dispatchDidReceiveTitle):
(WebKit::WebFrameLoaderClient::dispatchDidCommitLoad):
(WebKit::WebFrameLoaderClient::dispatchDidFailProvisionalLoad):
(WebKit::WebFrameLoaderClient::dispatchDidFailLoad):
(WebKit::WebFrameLoaderClient::dispatchDidFinishDocumentLoad):
(WebKit::WebFrameLoaderClient::dispatchDidFinishLoad):
(WebKit::WebFrameLoaderClient::dispatchDidFirstLayout):
(WebKit::WebFrameLoaderClient::dispatchDidFirstVisuallyNonEmptyLayout):

WebKitTools: Improve/unify the PageLoadClient interfaces
https://bugs.webkit.org/show_bug.cgi?id=46043

Reviewed by Dan Bernstein.

  • MiniBrowser/mac/BrowserWindowController.m:

(didStartProvisionalLoadForFrame):
(didReceiveServerRedirectForProvisionalLoadForFrame):
(didFailProvisionalLoadWithErrorForFrame):
(didCommitLoadForFrame):
(didFinishDocumentLoadForFrame):
(didFinishLoadForFrame):
(didFailLoadWithErrorForFrame):
(didReceiveTitleForFrame):
(didFirstLayoutForFrame):
(didFirstVisuallyNonEmptyLayoutForFrame):

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::InjectedBundlePage):
(WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
(WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame):
(WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
(WTR::InjectedBundlePage::didCommitLoadForFrame):
(WTR::InjectedBundlePage::didFinishLoadForFrame):
(WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
(WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
(WTR::InjectedBundlePage::didReceiveTitleForFrame):

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::didReceiveMessageFromInjectedBundle):
(WTR::TestController::didFinishLoadForFrame):

  • WebKitTestRunner/TestController.h:
17:23 Changeset [67801] by andreas.kling@nokia.com
  • 2 edits in trunk/WebCore

2010-09-18 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Oliver Hunt.

Gradient: Pre-reserve space for 2 color stops
https://bugs.webkit.org/show_bug.cgi?id=46044

Most gradients have only 2 color stops, pre-reserve space for these in m_stops
to avoid growing the vector dynamically in the common case.

  • platform/graphics/Gradient.h:
16:54 Changeset [67800] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2010-09-18 Adam Barth <abarth@webkit.org>

Also update the snow-leopard result.

  • platform/mac-snowleopard/platform/mac/fast/loader/file-url-mimetypes-2-expected.txt:
16:48 Changeset [67799] by dglazkov@chromium.org
  • 4 edits
    4 deletes in trunk

2010-09-18 Dimitri Glazkov <dglazkov@chromium.org>

Unreviewed, rolling out r67792.
http://trac.webkit.org/changeset/67792
https://bugs.webkit.org/show_bug.cgi?id=45976

Broke over a hundred SVG tests.

  • canvas/philip/tests/2d.drawImage.negativeOneDest-expected.txt: Removed.
  • canvas/philip/tests/2d.drawImage.negativeOneDest.html: Removed.
  • canvas/philip/tests/2d.drawImage.negativeOneSource-expected.txt: Removed.
  • canvas/philip/tests/2d.drawImage.negativeOneSource.html: Removed.

2010-09-18 Dimitri Glazkov <dglazkov@chromium.org>

Unreviewed, rolling out r67792.
http://trac.webkit.org/changeset/67792
https://bugs.webkit.org/show_bug.cgi?id=45976

Broke over a hundred SVG tests.

  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::drawImage): (WebCore::GraphicsContext::drawImageBuffer):
  • platform/graphics/GraphicsContext.h:
16:28 Changeset [67798] by abarth@webkit.org
  • 3 edits in trunk/LayoutTests

2010-09-18 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

file-url-mimetypes-2.html fails on my Snow Leopard box
https://bugs.webkit.org/show_bug.cgi?id=46042

This line of this test seems to depend on something besides WebKit. It
fails on my Snow Leopard box because it reports text/plain instead of
postscript. This is blocking me from running a commit-cluster machine
on my box.

  • platform/mac/fast/loader/file-url-mimetypes-2-expected.txt:
  • platform/mac/fast/loader/file-url-mimetypes-2.html:
16:02 Changeset [67797] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

2010-09-18 Mihai Parparita <mihaip@chromium.org>

Reviewed by Simon Fraser.

webkitAnimationEnd event doesn't fire when skipping over final iteration
https://bugs.webkit.org/show_bug.cgi?id=46010

Add a test with a short enough animation interval (0.001s) that we
appear to always skip the second iteration.

  • animations/animation-end-event-short-iterations-expected.txt: Added.
  • animations/animation-end-event-short-iterations.html: Added.

2010-09-18 Mihai Parparita <mihaip@chromium.org>

Reviewed by Simon Fraser.

webkitAnimationEnd event doesn't fire when skipping over final iteration
https://bugs.webkit.org/show_bug.cgi?id=46010

It's possible for AnimationBase::fireAnimationEventsIfNeeded to decide
that the animation is ended while we're in the looping state, if the
animation timer never fires during an iteration. That then fails the
assert in AnimationBase::updateStateMachine (we don't expect
AnimationStateInputEndTimerFired while in the looping state). Jump the
state to AnimationStateEnding, which is more accurate.

Test: animations/animation-end-event-short-iterations.html

  • page/animation/AnimationBase.cpp: (WebCore::AnimationBase::fireAnimationEventsIfNeeded):
16:02 Changeset [67796] by darin@apple.com
  • 2 edits in trunk/JavaScriptCore

First step in fixing Windows build.

Removed incorrect symbol. The build will probably still fail,
but the failure will tell us what symbol to add.

15:52 Changeset [67795] by kevino@webkit.org
  • 2 edits in trunk

[wx] Build fix, fix use of wrong case in name.

15:48 Changeset [67794] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-09-18 Kwang Yul Seo <skyul@company100.net>

Reviewed by Andreas Kling.

[BREWMP] Wrong key code type in keyIdentifierForBrewKeyCode
https://bugs.webkit.org/show_bug.cgi?id=46005

The type of key code in Brew MP is uint16. Take uint16 instead of int16 in keyIdentifierForBrewKeyCode.

  • platform/brew/PlatformKeyboardEventBrew.cpp: (WebCore::keyIdentifierForBrewKeyCode):
15:43 Changeset [67793] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2010-09-17 Mihai Parparita <mihaip@chromium.org>

Reviewed by James Robinson.

Remove passing animation tests from Chromium's test_expectations.txt
https://bugs.webkit.org/show_bug.cgi?id=45996

Update Chromium test_expectations.txt to remove tests that now pass:

animations/animation-shorthand-removed.html, animations/
animation-shorthand.html, and transitions/inherit-other-props.html were
fixed by http://trac.webkit.org/changeset/67634.

transforms/2d/transform-value-types.html has not failed in the last
1,500 runs.

animations/animation-drt-api.html was most likely fixed by 66641 (it
hasn't failed in the last 1,500 runs either).

  • platform/chromium/test_expectations.txt:
14:47 Changeset [67792] by commit-queue@webkit.org
  • 4 edits
    4 adds in trunk

2010-09-18 Matthew Delaney <mdelaney@apple.com>

Reviewed by Oliver Hunt.

Canvas drawImage with source or destination widths/heights of -1 renders incorrectly.
https://bugs.webkit.org/show_bug.cgi?id=45976

  • canvas/philip/tests/2d.drawImage.negativeOneDest-expected.txt: Added.
  • canvas/philip/tests/2d.drawImage.negativeOneDest.html: Added. Tests that using -1 for the destination width/height renders correctly.
  • canvas/philip/tests/2d.drawImage.negativeOneSource-expected.txt: Added.
  • canvas/philip/tests/2d.drawImage.negativeOneSource.html: Added. Tests that using -1 for the source width/height renders correctly.

2010-09-18 Matthew Delaney <mdelaney@apple.com>

Reviewed by Oliver Hunt.

Canvas drawImage with source or destination widths/heights of -1 renders incorrectly.
https://bugs.webkit.org/show_bug.cgi?id=45976

Specifying a -1 width or height for either the source or destination rectangle in drawImage
get improperly drawn with -1 replaced as the corresponding image width or height. This was because
the value -1 was being passed around to signal non-specified widths and heights and thus was
interpreted lower down in the drawImage implementation which disallowed any calls that actually
wanted to use -1 as the widths or heights. Fixed this by moving the default logic up and not using
-1 in-band signaling to denote default behavior.

Tests: canvas/philip/tests/2d.drawImage.negativeOneDest.html

canvas/philip/tests/2d.drawImage.negativeOneSource.html

  • platform/graphics/GraphicsContext.cpp: Removed -1 in-band signals and replaced cascased calls to have the desired replaces for unspecified widths and heights earlier on.
  • platform/graphics/GraphicsContext.h: Removed faulty default value.
14:30 Changeset [67791] by eric@webkit.org
  • 1 edit
    1 add in trunk/WebKitTools

2010-09-17 Eric Seidel <eric@webkit.org>

Unreviewed. Adding a shell script I use to run the
commit-queue. Now that multiple machines run the cq,
it makes sense to share the script between them.

  • EWSTools/start-commit-queue.sh: Added.
14:04 Changeset [67790] by msaboff@apple.com
  • 5 edits
    3 adds in trunk

2010-09-18 Michael Saboff <msaboff@apple.com>

Reviewed by Gavin Barraclough.

Added code to unroll regular expressions containing .
Alternatives that begin with
are tagged during parsing
and rolled up in containing sub expression structs.
After parsing, a regular expression flagged as containing
a (a.k.a. BOL) is processed further in optimizeBOL().
A copy of the disjunction is made excluding alternatives that
are rooted with BOL. The original alternatives are flagged
to only be executed once. The copy of the other alternatives are
added to the original expression.
In the case that all original alternatives are flagged, there
won't be any looping alternatives.
The JIT generator will emit code accordingly, executing the
original alternatives once and then looping over the
alternatives that aren't anchored with a BOL (if any).
https://bugs.webkit.org/show_bug.cgi?id=45787

  • yarr/RegexCompiler.cpp: (JSC::Yarr::RegexPatternConstructor::assertionBOL): (JSC::Yarr::RegexPatternConstructor::atomParenthesesEnd): (JSC::Yarr::RegexPatternConstructor::copyDisjunction): (JSC::Yarr::RegexPatternConstructor::copyTerm): (JSC::Yarr::RegexPatternConstructor::optimizeBOL): (JSC::Yarr::compileRegex):
  • yarr/RegexJIT.cpp: (JSC::Yarr::RegexGenerator::generateDisjunction):
  • yarr/RegexPattern.h: (JSC::Yarr::PatternAlternative::PatternAlternative): (JSC::Yarr::PatternAlternative::setOnceThrough): (JSC::Yarr::PatternAlternative::onceThrough): (JSC::Yarr::PatternDisjunction::PatternDisjunction): (JSC::Yarr::RegexPattern::RegexPattern): (JSC::Yarr::RegexPattern::reset):

2010-09-18 Michael Saboff <msaboff@apple.com>

Reviewed by Gavin Barraclough.

Added new tests to check for proper handling of in multiline
regular expressions. Added as part of
https://bugs.webkit.org/show_bug.cgi?id=45787

  • fast/js/regexp-bol-with-multiline-expected.txt: Added.
  • fast/js/regexp-bol-with-multiline.html: Added.
  • fast/js/script-tests/regexp-bol-with-multiline.js: Added.
13:52 Changeset [67789] by dglazkov@chromium.org
  • 1 edit
    4 deletes in trunk/LayoutTests

2010-09-18 Dimitri Glazkov <dglazkov@chromium.org>

Remove duplicate expectations from platform/chromium-win-xp.

  • platform/chromium-win-xp/css2.1/t1202-counter-09-b-expected.checksum: Removed.
  • platform/chromium-win-xp/css2.1/t1202-counter-09-b-expected.png: Removed.
  • platform/chromium-win-xp/css2.1/t1202-counters-09-b-expected.checksum: Removed.
  • platform/chromium-win-xp/css2.1/t1202-counters-09-b-expected.png: Removed.
13:41 Changeset [67788] by paroga@webkit.org
  • 4 edits
    38 moves in trunk

2010-09-18 Patrick Gansterer <paroga@paroga.com>

Reviewed by Darin Adler.

Rename Wince files to WinCE
https://bugs.webkit.org/show_bug.cgi?id=37287

  • wtf/unicode/Unicode.h:
  • wtf/unicode/wince/UnicodeWinCE.cpp: Copied from JavaScriptCore/wtf/unicode/wince/UnicodeWince.cpp.
  • wtf/unicode/wince/UnicodeWinCE.h: Copied from JavaScriptCore/wtf/unicode/wince/UnicodeWince.h.
  • wtf/unicode/wince/UnicodeWince.cpp: Removed.
  • wtf/unicode/wince/UnicodeWince.h: Removed.
  • wtf/wince/FastMallocWinCE.h: Copied from JavaScriptCore/wtf/wince/FastMallocWince.h.
  • wtf/wince/FastMallocWince.h: Removed.

2010-09-18 Ademar de Souza Reis Jr <ademar.reis@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

Enable Platform Strategies on Qt

[Qt] Turn on PLATFORM_STRATEGIES
https://bugs.webkit.org/show_bug.cgi?id=45831

  • WebCore.pro: Adding/removing implementation files
  • platform/qt/Language.cpp: Added, WebCore::defaultLanguage() was moved from platform/qt/Localizations.cpp (WebCore::defaultLanguage): Moved from Localizations.cpp
  • platform/qt/Localizations.cpp: Removed (code is now inside WebCoreSupport/WebPlatformStrategies.cpp)
  • plugins/qt/PluginDataQt.cpp: Removed (idem)
13:15 Changeset [67787] by commit-queue@webkit.org
  • 8 edits
    1 move
    2 adds
    1 delete in trunk

2010-09-18 Ademar de Souza Reis Jr <ademar.reis@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

Enable Platform Strategies on Qt

[Qt] Turn on PLATFORM_STRATEGIES
https://bugs.webkit.org/show_bug.cgi?id=45831

  • wtf/Platform.h: Enable Platform Strategies when building QtWebkit

2010-09-18 Ademar de Souza Reis Jr <ademar.reis@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

Enable Platform Strategies on Qt

[Qt] Turn on PLATFORM_STRATEGIES
https://bugs.webkit.org/show_bug.cgi?id=45831

  • WebCore.pro: Adding/removing implementation files
  • platform/qt/Language.cpp: Added, WebCore::defaultLanguage() was moved from platform/qt/Localizations.cpp (WebCore::defaultLanguage): Moved from Localizations.cpp
  • platform/qt/Localizations.cpp: Removed (code is now inside WebCoreSupport/WebPlatformStrategies.cpp)
  • plugins/qt/PluginDataQt.cpp: Removed (idem)

2010-09-18 Ademar de Souza Reis Jr <ademar.reis@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

Enable Platform Strategies on Qt

[Qt] Turn on PLATFORM_STRATEGIES
https://bugs.webkit.org/show_bug.cgi?id=45831

  • Api/qwebpage.cpp: (QWebPagePrivate::QWebPagePrivate): Initialize the PlatformStrategy singleton.
  • WebCoreSupport/WebPlatformStrategies.cpp: Added, code was moved from platform/qt/Localizations.cpp and plugins/qt/PluginDataQt.cpp (WebPlatformStrategies::initialize): create the singleton, following the same "pattern" used by Mac and Win ports. (WebPlatformStrategies::WebPlatformStrategies): (WebPlatformStrategies::createPluginStrategy): (WebPlatformStrategies::createLocalizationStrategy): (WebPlatformStrategies::createVisitedLinkStrategy): (WebPlatformStrategies::refreshPlugins): (WebPlatformStrategies::getPluginInfo): (WebPlatformStrategies::inputElementAltText): (WebPlatformStrategies::resetButtonDefaultLabel): (WebPlatformStrategies::searchableIndexIntroduction): (WebPlatformStrategies::submitButtonDefaultLabel): (WebPlatformStrategies::fileButtonChooseFileLabel): (WebPlatformStrategies::fileButtonNoFileSelectedLabel): (WebPlatformStrategies::contextMenuItemTagOpenLinkInNewWindow): (WebPlatformStrategies::contextMenuItemTagDownloadLinkToDisk): (WebPlatformStrategies::contextMenuItemTagCopyLinkToClipboard): (WebPlatformStrategies::contextMenuItemTagOpenImageInNewWindow): (WebPlatformStrategies::contextMenuItemTagDownloadImageToDisk): (WebPlatformStrategies::contextMenuItemTagCopyImageToClipboard): (WebPlatformStrategies::contextMenuItemTagOpenFrameInNewWindow): (WebPlatformStrategies::contextMenuItemTagCopy): (WebPlatformStrategies::contextMenuItemTagGoBack): (WebPlatformStrategies::contextMenuItemTagGoForward): (WebPlatformStrategies::contextMenuItemTagStop): (WebPlatformStrategies::contextMenuItemTagReload): (WebPlatformStrategies::contextMenuItemTagCut): (WebPlatformStrategies::contextMenuItemTagPaste): (WebPlatformStrategies::contextMenuItemTagNoGuessesFound): (WebPlatformStrategies::contextMenuItemTagIgnoreSpelling): (WebPlatformStrategies::contextMenuItemTagLearnSpelling): (WebPlatformStrategies::contextMenuItemTagSearchWeb): (WebPlatformStrategies::contextMenuItemTagLookUpInDictionary): (WebPlatformStrategies::contextMenuItemTagOpenLink): (WebPlatformStrategies::contextMenuItemTagIgnoreGrammar): (WebPlatformStrategies::contextMenuItemTagSpellingMenu): (WebPlatformStrategies::contextMenuItemTagShowSpellingPanel): (WebPlatformStrategies::contextMenuItemTagCheckSpelling): (WebPlatformStrategies::contextMenuItemTagCheckSpellingWhileTyping): (WebPlatformStrategies::contextMenuItemTagCheckGrammarWithSpelling): (WebPlatformStrategies::contextMenuItemTagFontMenu): (WebPlatformStrategies::contextMenuItemTagBold): (WebPlatformStrategies::contextMenuItemTagItalic): (WebPlatformStrategies::contextMenuItemTagUnderline): (WebPlatformStrategies::contextMenuItemTagOutline): (WebPlatformStrategies::contextMenuItemTagWritingDirectionMenu): (WebPlatformStrategies::contextMenuItemTagTextDirectionMenu): (WebPlatformStrategies::contextMenuItemTagDefaultDirection): (WebPlatformStrategies::contextMenuItemTagLeftToRight): (WebPlatformStrategies::contextMenuItemTagRightToLeft): (WebPlatformStrategies::contextMenuItemTagInspectElement): (WebPlatformStrategies::searchMenuNoRecentSearchesText): (WebPlatformStrategies::searchMenuRecentSearchesText): (WebPlatformStrategies::searchMenuClearRecentSearchesText): (WebPlatformStrategies::AXWebAreaText): (WebPlatformStrategies::AXLinkText): (WebPlatformStrategies::AXListMarkerText): (WebPlatformStrategies::AXImageMapText): (WebPlatformStrategies::AXHeadingText): (WebPlatformStrategies::AXDefinitionListTermText): (WebPlatformStrategies::AXDefinitionListDefinitionText): (WebPlatformStrategies::AXButtonActionVerb): (WebPlatformStrategies::AXRadioButtonActionVerb): (WebPlatformStrategies::AXTextFieldActionVerb): (WebPlatformStrategies::AXCheckedCheckBoxActionVerb): (WebPlatformStrategies::AXUncheckedCheckBoxActionVerb): (WebPlatformStrategies::AXMenuListActionVerb): (WebPlatformStrategies::AXMenuListPopupActionVerb): (WebPlatformStrategies::AXLinkActionVerb): (WebPlatformStrategies::missingPluginText): (WebPlatformStrategies::crashedPluginText): (WebPlatformStrategies::multipleFileUploadText): (WebPlatformStrategies::unknownFileSizeText): (WebPlatformStrategies::imageTitle): (WebPlatformStrategies::mediaElementLoadingStateText): (WebPlatformStrategies::mediaElementLiveBroadcastStateText): (WebPlatformStrategies::localizedMediaControlElementString): (WebPlatformStrategies::localizedMediaControlElementHelpText): (WebPlatformStrategies::localizedMediaTimeDescription): (WebPlatformStrategies::validationMessageValueMissingText): (WebPlatformStrategies::validationMessageTypeMismatchText): (WebPlatformStrategies::validationMessagePatternMismatchText): (WebPlatformStrategies::validationMessageTooLongText): (WebPlatformStrategies::validationMessageRangeUnderflowText): (WebPlatformStrategies::validationMessageRangeOverflowText): (WebPlatformStrategies::validationMessageStepMismatchText): (WebPlatformStrategies::isLinkVisited): (WebPlatformStrategies::addVisitedLink):
  • WebCoreSupport/WebPlatformStrategies.h: Added, based on Mac and Win versions.

2010-09-18 Ademar de Souza Reis Jr <ademar.reis@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

Enable Platform Strategies on Qt

[Qt] Turn on PLATFORM_STRATEGIES
https://bugs.webkit.org/show_bug.cgi?id=45831

  • WebKit2.pro: Added Added WebPlatformStrategies.{cpp,h}
12:33 Changeset [67786] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

2010-09-18 Mike Lawther <mikelawther@chromium.org>

Reviewed by Nate Chapin.

Remove passing tests from chromium test_expectations
https://bugs.webkit.org/show_bug.cgi?id=45948

Removes tests the flakiness dashboard shows as having passed for a couple of weeks

12:21 Changeset [67785] by commit-queue@webkit.org
  • 3 edits in trunk/WebCore

2010-09-18 Patrick Gansterer <paroga@paroga.com>

Reviewed by Eric Seidel.

Move Plugin*None.cpp from CMakeLists.txt into CMakeListsEfl.txt
https://bugs.webkit.org/show_bug.cgi?id=45900

PluginDataNone.cpp and PluginViewNone.cpp are not used by all port.
Move them into plaform sepcific build system.

  • CMakeLists.txt:
  • CMakeListsEfl.txt:
12:03 Changeset [67784] by wsiegrist@apple.com
  • 1 edit in trunk/WebKitTools/BuildSlaveSupport/build.webkit.org-config/public_html/default.css

2010-09-18 William Siegrist <wsiegrist@apple.com>

Increase alternating row contract in result viewer.

11:16 Changeset [67783] by dbates@webkit.org
  • 2 edits in trunk/LayoutTests

2010-09-18 Daniel Bates <dbates@rim.com>

Rubber-stamped by Sam Weinig.

REGRESSION (r60104): Zoom level is unexpectedly reset on page reload
https://bugs.webkit.org/show_bug.cgi?id=42863

Fix some minor, non-visual typos that do not affect the test result.

  • fast/css/preserve-user-specified-zoom-level-on-reload.html:
10:44 Changeset [67782] by krit@webkit.org
  • 2 edits in trunk/LayoutTests

2010-09-18 Mihai Parparita <mihaip@chromium.org>

Reviewed by Dirk Schulze.

fast/css/preserve-user-specified-zoom-level-on-reload.html does not clean up after itself
https://bugs.webkit.org/show_bug.cgi?id=46040

Delete the sessionStorage property that this test adds once it's complete.
Otherwise it fails when run with --iterations=2 and also causes a diff in
in fast/dom/prototype-inheritance-2.html (which runs after it).

  • fast/css/preserve-user-specified-zoom-level-on-reload.html:
09:37 Changeset [67781] by andreas.kling@nokia.com
  • 2 edits in trunk/WebKit/qt

2010-09-18 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Antonio Gomes.

[Qt] V8 port: Add FrameLoaderClientQt::allowScriptExtension()
https://bugs.webkit.org/show_bug.cgi?id=46034

r67749 added FrameLoaderClient::allowScriptExtension() (V8-specific)
Add a stub implementation that simply returns false for now.

  • WebCoreSupport/FrameLoaderClientQt.h: (WebCore::FrameLoaderClientQt::allowScriptExtension):
08:23 Changeset [67780] by andreas.kling@nokia.com
  • 2 edits in trunk/WebCore

2010-09-18 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Don't copy clip path to TransparencyLayer
https://bugs.webkit.org/show_bug.cgi?id=45965

We don't need to copy the GC's clip path to the TransparencyLayer since it will
clip anyway when ending the layer.

  • platform/graphics/qt/TransparencyLayer.h: (WebCore::TransparencyLayer::TransparencyLayer):
06:55 Changeset [67779] by paroga@webkit.org
  • 2 edits in trunk/WebCore

2010-09-18 Patrick Gansterer <paroga@paroga.com>

Unreviewed.

[WINCE] Buildfix for FrameWince.cpp after r51353, r67762 and r67771.

  • page/wince/FrameWince.cpp: (WebCore::computePageRectsForFrame): (WebCore::imageFromSelection):
05:19 Changeset [67778] by tkent@chromium.org
  • 2 edits in trunk/WebCore

2010-09-18 Kent Tamura <tkent@chromium.org>

Unreviewed, a trivial change.

Run sort-Xcode-project-file.

  • WebCore.xcodeproj/project.pbxproj:
03:04 Changeset [67777] by mitz@apple.com
  • 2 edits in trunk/WebCore

REGRESSION (r67762): Over 160 layout tests failing due to incorrect zoom factors in subframes
https://bugs.webkit.org/show_bug.cgi?id=46031

Reviewed by Eric Seidel.

  • page/Frame.cpp:

(WebCore::parentPageZoomFactor): Return the zoom factor of the parent frame.
(WebCore::parentTextZoomFactor): Ditto.

09/17/10:

23:16 Changeset [67776] by weinig@apple.com
  • 10 edits in trunk

Need a way to load data (as plain text) in a WKPage
<rdar://problem/8424239>

Reviewed by Jon Honeycutt.

WebCore:

  • WebCore.exp.in:

WebKit2:

  • Shared/CoreIPCSupport/WebPageMessageKinds.h:
  • UIProcess/API/C/WKPage.cpp:

(WKPageLoadHTMLString):

  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::loadHTMLString):

  • UIProcess/WebPageProxy.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::loadHTMLString):
(WebKit::WebPage::didReceiveMessage):

  • WebProcess/WebPage/WebPage.h:
22:34 Changeset [67775] by weinig@apple.com
  • 60 edits in trunk/WebKit2

Replace all uses of WTF::String and WTF::AtomicString with
String and AtomicString.

Rubber-stamped by Anders Carlsson.

  • Platform/Module.h:
  • Shared/CommandLine.h:

(WebKit::CommandLine::operator[]):

  • Shared/WebCoreArgumentCoders.h:
  • Shared/WebEvent.h:

(WebKit::WebKeyboardEvent::WebKeyboardEvent):
(WebKit::WebKeyboardEvent::text):
(WebKit::WebKeyboardEvent::unmodifiedText):
(WebKit::WebKeyboardEvent::keyIdentifier):
(WebKit::WebKeyboardEvent::decode):

  • Shared/WebNavigationDataStore.h:
  • Shared/WebPreferencesStore.h:
  • Shared/WebString.h:

(WebKit::WebString::create):
(WebKit::WebString::string):
(WebKit::WebString::WebString):

  • Shared/WebURL.h:

(WebKit::WebURL::create):
(WebKit::WebURL::string):
(WebKit::WebURL::WebURL):

  • UIProcess/API/C/WKAPICast.h:

(WebKit::toRef):
(WebKit::toURLRef):
(WebKit::toCopiedRef):
(WebKit::toCopiedURLRef):
(WebKit::toWTFString):

  • UIProcess/API/C/WKContext.cpp:

(WKContextCreate):

  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::nsStringFromWebCoreString):

  • UIProcess/PageClient.h:
  • UIProcess/Plugins/PluginInfoStore.cpp:

(WebKit::PluginInfoStore::setAdditionalPluginsDirectories):

  • UIProcess/Plugins/PluginInfoStore.h:
  • UIProcess/Plugins/mac/PluginInfoStoreMac.mm:

(WebKit::PluginInfoStore::getPluginInfo):
(WebKit::PluginInfoStore::getMIMETypeForExtension):

  • UIProcess/WebBackForwardListItem.h:

(WebKit::WebBackForwardListItem::create):
(WebKit::WebBackForwardListItem::setOriginalURL):
(WebKit::WebBackForwardListItem::originalURL):
(WebKit::WebBackForwardListItem::setURL):
(WebKit::WebBackForwardListItem::url):
(WebKit::WebBackForwardListItem::setTitle):
(WebKit::WebBackForwardListItem::title):

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext):
(WebKit::WebContext::setAdditionalPluginsDirectory):

  • UIProcess/WebContext.h:

(WebKit::WebContext::injectedBundlePath):

  • UIProcess/WebContextInjectedBundleClient.h:
  • UIProcess/WebFrameProxy.cpp:

(WebKit::WebFrameProxy::didReceiveTitle):

  • UIProcess/WebFrameProxy.h:

(WebKit::WebFrameProxy::url):
(WebKit::WebFrameProxy::provisionalURL):

  • UIProcess/WebHistoryClient.h:
  • UIProcess/WebLoaderClient.cpp:

(WebKit::WebLoaderClient::didReceiveTitleForFrame):

  • UIProcess/WebLoaderClient.h:
  • UIProcess/WebNavigationData.h:

(WebKit::WebNavigationData::title):
(WebKit::WebNavigationData::url):

  • UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::pageTitle):
(WebKit::WebPageProxy::toolTip):
(WebKit::WebPageProxy::urlAtProcessExit):

  • UIProcess/WebPolicyClient.h:
  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::getPluginHostConnection):

  • UIProcess/WebProcessProxy.h:
  • UIProcess/WebUIClient.h:
  • WebProcess/InjectedBundle/InjectedBundle.h:

(WebKit::InjectedBundle::create):
(WebKit::InjectedBundle::setSandboxToken):

  • WebProcess/InjectedBundle/InjectedBundlePageEditorClient.h:
  • WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:

(WebKit::InjectedBundlePageLoaderClient::willPerformClientRedirectForFrame):

  • WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
  • WebProcess/InjectedBundle/InjectedBundlePageUIClient.h:
  • WebProcess/Plugins/NPRuntimeObjectMap.h:
  • WebProcess/Plugins/Netscape/NetscapePlugin.h:
  • WebProcess/Plugins/Netscape/NetscapePluginModule.h:
  • WebProcess/Plugins/Netscape/NetscapePluginStream.cpp:

(WebKit::NetscapePluginStream::start):

  • WebProcess/Plugins/Netscape/NetscapePluginStream.h:
  • WebProcess/Plugins/Plugin.h:
  • WebProcess/Plugins/PluginController.h:
  • WebProcess/Plugins/PluginView.h:
  • WebProcess/WebCoreSupport/WebChromeClient.h:
  • WebProcess/WebCoreSupport/WebContextMenuClient.h:
  • WebProcess/WebCoreSupport/WebDragClient.h:
  • WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::WebEditorClient::showCorrectionPanel):

  • WebProcess/WebCoreSupport/WebEditorClient.h:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
  • WebProcess/WebCoreSupport/WebInspectorClient.h:
  • WebProcess/WebCoreSupport/WebPlatformStrategies.h:
  • WebProcess/WebCoreSupport/WebSearchPopupMenu.cpp:

(WebKit::WebSearchPopupMenu::saveRecentSearches):
(WebKit::WebSearchPopupMenu::loadRecentSearches):

  • WebProcess/WebCoreSupport/WebSearchPopupMenu.h:
  • WebProcess/WebPage/WebFrame.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::runJavaScriptInMainFrame):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::registerURLSchemeAsEmptyDocument):

  • WebProcess/WebProcess.h:
21:09 Changeset [67774] by hyatt@apple.com
  • 3 edits
    2 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=46027, image on gamespot.com paginates without bringing its enclosing border along.

Reviewed by Sam Weinig.

Make sure that unsplittable objects like replaced elements propagate their pagination strut outward to the parent block
when appropriate. An image on a line did this, but a block-level image did not.

Added fast/multicol/image-inside-nested-blocks-with-border.html

WebCore:

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlockChild):

LayoutTests:

  • fast/multicol/image-inside-nested-blocks-with-border-expected.txt: Added.
  • fast/multicol/image-inside-nested-blocks-with-border.html: Added.
20:38 Changeset [67773] by dglazkov@chromium.org
  • 2 edits in trunk/LayoutTests

2010-09-17 Dimitri Glazkov <dglazkov@chromium.org>

Remove passing tests from expectations.

  • platform/chromium/drt_expectations.txt: Removed tests that are now

consistently passing on Chromium Windows DRT.

19:59 Changeset [67772] by dglazkov@chromium.org
  • 2 edits in trunk/WebCore

2010-09-17 Dimitri Glazkov <dglazkov@chromium.org>

Unreviewed, build fix.

Move calls from frameView->pageZoomFactor() to frame->pageZoomFactor().

  • page/EventHandler.cpp: (WebCore::EventHandler::handleTouchEvent): Removed a helper function,

added direct calls to frame->pageZoomFactor().

19:13 Changeset [67771] by hyatt@apple.com
  • 17 edits
    2 deletes in trunk

https://bugs.webkit.org/show_bug.cgi?id=45993, convert printing to the new pagination model.

Reviewed by Simon Fraser.

WebCore:

Make printing store the page height in the RenderView and push that into the layout state to
use the new pagination model. The old pagination model is retained because it is still used
for embedded WebViews.

  • page/FrameView.cpp:

(WebCore::FrameView::reset):
(WebCore::FrameView::layout):
(WebCore::FrameView::forceLayout):
(WebCore::FrameView::forceLayoutForPagination):
(WebCore::FrameView::adjustPageHeight):

  • page/FrameView.h:
  • page/PrintContext.cpp:

(WebCore::PrintContext::computePageRectsWithPageSizeInternal):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paintChildren):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::calcHeight):

  • rendering/RenderImage.cpp:

(WebCore::RenderImage::paintReplaced):

  • rendering/RenderLineBoxList.cpp:

(WebCore::RenderLineBoxList::paint):

  • rendering/RenderVideo.cpp:

(WebCore::RenderVideo::paintReplaced):

  • rendering/RenderView.cpp:

(WebCore::RenderView::RenderView):
(WebCore::RenderView::layout):
(WebCore::RenderView::paint):
(WebCore::RenderView::setBestTruncatedAt):

  • rendering/RenderView.h:

(WebCore::RenderView::popLayoutState):
(WebCore::RenderView::pageHeight):
(WebCore::RenderView::setPageHeight):
(WebCore::RenderView::bestTruncatedAt):
(WebCore::RenderView::truncatedAt):
(WebCore::RenderView::setTruncatedAt):
(WebCore::RenderView::printRect):
(WebCore::RenderView::setPrintRect):
(WebCore::RenderView::pushLayoutState):
(WebCore::LayoutStateMaintainer::LayoutStateMaintainer):
(WebCore::LayoutStateMaintainer::push):
(WebCore::LayoutStateMaintainer::pop):

WebKit/mac:

Make printing store the page height in the RenderView and push that into the layout state to
use the new pagination model. The old pagination model is retained because it is still used
for embedded WebViews.

  • WebView/WebHTMLView.mm:

(-[WebHTMLView _adjustedBottomOfPageWithTop:bottom:limit:]):

LayoutTests:

Remove the overflow test, since the new model treats overflow:auto/scroll as unsplittable.

  • printing/page-break-always-for-overflow-expected.txt: Removed.
  • printing/page-break-always-for-overflow.html: Removed.
19:09 Changeset [67770] by mitz@apple.com
  • 11 edits in trunk

Canvas sizing ignores intrinsic size
https://bugs.webkit.org/show_bug.cgi?id=46024

Reviewed by Simon Fraser.

WebCore:

Updated fast/replaced/table-percent-height.html

  • rendering/RenderEmbeddedObject.cpp:

(WebCore::RenderEmbeddedObject::RenderEmbeddedObject): If this is used as a proxy
for <video>, behave like it has an intrinsic size (e.g. preserve aspect ratio when
width is auto and height is specified).

  • rendering/RenderImage.cpp:

(WebCore::RenderImage::calcAspectRatioWidth): Changed to explicitly invoke
RenderBox::calcReplacedHeight(), now that RenderReplaced has its own implementation
which we don’t want.
(WebCore::RenderImage::calcAspectRatioHeight): Similarly with calcReplacedWidth().

  • rendering/RenderImage.h:
  • rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::RenderReplaced): Initialize m_hasIntrinsicSize.
(WebCore::lengthIsSpecified): Added this helper function, based on RenderImage’s
is{Width,Height}Specified().
(WebCore::RenderReplaced::calcReplacedWidth): Moved from RenderVideo all the way
up here so other replaced objects could use this logic.
(WebCore::RenderReplaced::calcReplacedHeight): Ditto.
(WebCore::RenderReplaced::calcAspectRatioWidth): Ditto.
(WebCore::RenderReplaced::calcAspectRatioHeight): Ditto.
(WebCore::RenderReplaced::calcPrefWidths): Replaced with the RenderImage version
of the logic.
(WebCore::RenderReplaced::setIntrinsicSize): Added an assertion.

  • rendering/RenderReplaced.h:

(WebCore::RenderReplaced::minimumReplacedHeight): Promoted from private to protected
to allow RenderVideo to call through.
(WebCore::RenderReplaced::setHasIntrinsicSize): Added this setter.

  • rendering/RenderVideo.cpp:

(WebCore::RenderVideo::updateIntrinsicSize): Factor zoom into the intrinsic size,
the way other RenderReplaced objects do.
(WebCore::RenderVideo::calcReplacedWidth): Invoke the RenderReplaced implementation,
which matches what used to be here, skipping over the RenderImage implementation.
(WebCore::RenderVideo::calcReplacedHeight): Ditto.
(WebCore::RenderVideo::minimumReplacedHeight): Ditto.

  • rendering/RenderVideo.h:

LayoutTests:

  • fast/replaced/table-percent-height-expected.txt: Updated.
  • fast/replaced/table-percent-height.html: Changed to expect canvas to maintain

its intrinsic ratio.

18:06 Changeset [67769] by oliver@apple.com
  • 7 edits in trunk/JavaScriptCore

2010-09-17 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

Imprecise tracking of variable capture leads to overly pessimistic creation of activations
https://bugs.webkit.org/show_bug.cgi?id=46020

The old logic for track free and captured variables would cause us
to decide we needed an activation in every function along the scope
chain between a variable capture and its declaration. We now track
captured variables precisely which requires a bit of additional work

The most substantial change is that the parsing routine needs to
be passed the list of function parameters when reparsing a function
as when reparsing we don't parse the function declaration itself only
its body.

  • JavaScriptCore.exp:
  • parser/JSParser.cpp: (JSC::JSParser::Scope::Scope): (JSC::JSParser::Scope::needsFullActivation):

We need to distinguish between use of a feature that requires
an activation and eval so we now get this additional flag.

(JSC::JSParser::Scope::collectFreeVariables):
(JSC::JSParser::Scope::getCapturedVariables):

We can't simply return the list of "capturedVariables" now as
is insufficiently precise, so we compute them instead.

(JSC::JSParser::popScope):
(JSC::jsParse):
(JSC::JSParser::JSParser):
(JSC::JSParser::parseProgram):
(JSC::JSParser::parseWithStatement):
(JSC::JSParser::parseTryStatement):
(JSC::JSParser::parseFunctionInfo):
(JSC::JSParser::parseFunctionDeclaration):
(JSC::JSParser::parseProperty):
(JSC::JSParser::parseMemberExpression):

  • parser/JSParser.h:
  • parser/Parser.cpp: (JSC::Parser::parse):
  • parser/Parser.h: (JSC::Parser::parse):
  • runtime/Executable.cpp: (JSC::EvalExecutable::compileInternal): (JSC::ProgramExecutable::checkSyntax): (JSC::ProgramExecutable::compileInternal): (JSC::FunctionExecutable::compileForCallInternal): (JSC::FunctionExecutable::compileForConstructInternal): (JSC::FunctionExecutable::reparseExceptionInfo): (JSC::EvalExecutable::reparseExceptionInfo): (JSC::FunctionExecutable::fromGlobalCode):

Pass function parameters (if available) to the parser.

18:01 Changeset [67768] by bweinstein@apple.com
  • 2 edits in trunk/WebKitTools

The colors on the new build.webkit.org (after upgrading the master to 0.8.1) are
slightly harder to read, so this reverts the previous background colors for various
states, making it easier to read.

Reviewed by Jon Honeycutt.

  • BuildSlaveSupport/build.webkit.org-config/public_html/default.css:

(.success):
(.failure):
(.warnings):
(.exception):
(.start,.running,td.building):
(.offline,td.offline):

18:00 Changeset [67767] by darin@apple.com
  • 2 edits in trunk/WebCore

Build fix for platforms that compile Touch.

  • dom/Touch.cpp:

(WebCore::contentsX):
(WebCore::contentsY):
Get zoom factor from Frame rather than FrameView.

17:57 Changeset [67766] by abarth@webkit.org
  • 1 edit
    5 deletes in trunk/LayoutTests

2010-09-17 Adam Barth <abarth@webkit.org>

Remove Leopard specific expected results because these now match Snow
Leopard.

https://bugs.webkit.org/show_bug.cgi?id=38402

  • platform/mac-leopard/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt: Removed.
  • platform/mac-leopard/fast/multicol/span/span-as-immediate-child-property-removal-expected.txt: Removed.
  • platform/mac-leopard/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.txt: Removed.
  • platform/mac-leopard/fast/multicol/span/span-as-immediate-columns-child-expected.txt: Removed.
  • platform/mac-leopard/fast/multicol/span/span-as-immediate-columns-child-removal-expected.txt: Removed.
17:40 Changeset [67765] by andersca@apple.com
  • 3 edits in trunk/JavaScriptCore

Add IsFloatingPoint and IsArithmetic type traits
https://bugs.webkit.org/show_bug.cgi?id=46018

Reviewed by Sam Weinig.

  • wtf/TypeTraits.h:
  • wtf/TypeTraits.cpp:
17:38 Changeset [67764] by abarth@webkit.org
  • 4 edits in trunk/WebKitTools

2010-09-17 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r67692.
http://trac.webkit.org/changeset/67692
https://bugs.webkit.org/show_bug.cgi?id=46011

broke layout test dashboard (Requested by johnny_g on
#webkit).

  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
17:34 Changeset [67763] by weinig@apple.com
  • 3 edits in trunk/WebKit2

Fix Windows and Qt builds.

  • Shared/qt/PlatformCertificateInfo.h:

(WebKit::PlatformCertificateInfo::decode):

  • Shared/win/PlatformCertificateInfo.h:

(WebKit::PlatformCertificateInfo::decode):

17:32 Changeset [67762] by darin@apple.com
  • 34 edits
    4 adds in trunk

2010-09-17 Darin Adler <darin@apple.com>

Reviewed by Sam Weinig.

REGRESSION (r60104): Zoom level is unexpectedly reset on page reload
https://bugs.webkit.org/show_bug.cgi?id=42863

  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::createPlugin):
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::setZoomLevel): Call functions on Frame instead of FrameView.

2010-09-17 Darin Adler <darin@apple.com>

Reviewed by Sam Weinig.

REGRESSION (r60104): Zoom level is unexpectedly reset on page reload
https://bugs.webkit.org/show_bug.cgi?id=42863

  • Api/qwebframe.cpp: (QWebFrame::setTextSizeMultiplier): (QWebFrame::textSizeMultiplier): (QWebFrame::setZoomFactor): (QWebFrame::zoomFactor): Call functions on Frame instead of FrameView.

2010-09-17 Darin Adler <darin@apple.com>

Reviewed by Sam Weinig.

REGRESSION (r60104): Zoom level is unexpectedly reset on page reload
https://bugs.webkit.org/show_bug.cgi?id=42863

  • webkit/webkitwebview.cpp: (webkit_web_view_get_zoom_level): (webkit_web_view_apply_zoom_level): (webkit_web_view_set_full_content_zoom): Call functions on Frame instead of FrameView.

2010-09-17 Darin Adler <darin@apple.com>

Reviewed by Sam Weinig.

REGRESSION (r60104): Zoom level is unexpectedly reset on page reload
https://bugs.webkit.org/show_bug.cgi?id=42863

  • WebView.cpp: (WebView::setZoomMultiplier): Call functions on Frame instead of FrameView.

2010-09-17 Darin Adler <darin@apple.com>

Reviewed by Sam Weinig.

REGRESSION (r60104): Zoom level is unexpectedly reset on page reload
https://bugs.webkit.org/show_bug.cgi?id=42863

  • WebFrame.cpp: (wxWebFrame::IncreaseTextSize): (wxWebFrame::DecreaseTextSize): (wxWebFrame::ResetTextSize): Call functions on Frame instead of FrameView.

2010-09-17 Darin Adler <darin@apple.com>

Reviewed by Sam Weinig.

REGRESSION (r60104): Zoom level is unexpectedly reset on page reload
https://bugs.webkit.org/show_bug.cgi?id=42863

  • WebView/WebView.mm: (-[WebView _setZoomMultiplier:isTextOnly:]): Call functions on Frame instead of FrameView.

2010-09-17 Darin Adler <darin@apple.com>

Reviewed by Sam Weinig.

REGRESSION (r60104): Zoom level is unexpectedly reset on page reload
https://bugs.webkit.org/show_bug.cgi?id=42863

  • ewk/ewk_frame.cpp: (ewk_frame_zoom_get): (ewk_frame_zoom_set): (ewk_frame_zoom_text_only_set): Call functions on Frame instead of FrameView.

2010-09-17 Darin Adler <darin@apple.com>

Reviewed by Sam Weinig.

REGRESSION (r60104): Zoom level is unexpectedly reset on page reload
https://bugs.webkit.org/show_bug.cgi?id=42863

Moved zoom level back from FrameView to Frame.
I had forgotten that FrameView's lifetime is much shorter than
Frame's, and until that is fixed it's best to leave this on Frame.

  • WebCore.exp.in: Updated.
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::styleForDocument): (WebCore::CSSStyleSelector::applyProperty): (WebCore::CSSStyleSelector::getComputedSizeFromSpecifiedSize):
  • dom/Document.cpp: (WebCore::Document::nodesFromRect): (WebCore::Document::elementFromPoint): (WebCore::Document::caretRangeFromPoint):
  • dom/MouseRelatedEvent.cpp: (WebCore::contentsX): (WebCore::contentsY): (WebCore::pageZoomFactor):
  • dom/Node.cpp: (WebCore::Node::dispatchMouseEvent): (WebCore::Node::dispatchWheelEvent):
  • html/HTMLBodyElement.cpp: (WebCore::adjustForZoom): (WebCore::HTMLBodyElement::scrollLeft): (WebCore::HTMLBodyElement::setScrollLeft): (WebCore::HTMLBodyElement::scrollTop): (WebCore::HTMLBodyElement::setScrollTop): (WebCore::HTMLBodyElement::scrollHeight): (WebCore::HTMLBodyElement::scrollWidth):
  • html/ImageDocument.cpp: (WebCore::pageZoomFactor): (WebCore::ImageDocument::scale): (WebCore::ImageDocument::imageFitsInWindow):
  • page/DOMWindow.cpp: (WebCore::DOMWindow::innerHeight): (WebCore::DOMWindow::innerWidth): (WebCore::DOMWindow::scrollX): (WebCore::DOMWindow::scrollY): (WebCore::DOMWindow::scrollTo):
  • page/DragController.cpp: (WebCore::elementUnderMouse):
  • rendering/RenderView.cpp: (WebCore::RenderView::zoomFactor):
  • svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::currentScale): (WebCore::SVGSVGElement::setCurrentScale): Get zoom factor from Frame rather than FrameView.
  • page/Frame.cpp: (WebCore::parentPageZoomFactor): Moved back here from FrameView. (WebCore::parentTextZoomFactor): Ditto. (WebCore::Frame::Frame): Ditto. (WebCore::Frame::setPageZoomFactor): Ditto. (WebCore::Frame::setTextZoomFactor): Ditto. (WebCore::Frame::setPageAndTextZoomFactors): Ditto.
  • page/Frame.h: Moved functions and data for zooming back here from FrameView.
  • page/FrameView.cpp: (WebCore::FrameView::FrameView):
  • page/FrameView.h: Removed code from here.

2010-09-17 Daniel Bates <dbates@rim.com>

Reviewed by Darin Adler.

REGRESSION (r60104): Zoom level is unexpectedly reset on page reload
https://bugs.webkit.org/show_bug.cgi?id=42863

  • fast/css/preserve-user-specified-zoom-level-on-reload.html: Added.
  • platform/mac/fast/css/preserve-user-specified-zoom-level-on-reload-expected.checksum: Added.
  • platform/mac/fast/css/preserve-user-specified-zoom-level-on-reload-expected.png: Added.
  • platform/mac/fast/css/preserve-user-specified-zoom-level-on-reload-expected.txt: Added.

2010-09-17 Darin Adler <darin@apple.com>

Reviewed by Sam Weinig.

REGRESSION (r60104): Zoom level is unexpectedly reset on page reload
https://bugs.webkit.org/show_bug.cgi?id=42863

  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::textZoomFactor): (WebKit::WebPage::setTextZoomFactor): (WebKit::WebPage::pageZoomFactor): (WebKit::WebPage::setPageZoomFactor): (WebKit::WebPage::setPageAndTextZoomFactors): Call functions on Frame instead of FrameView.
17:23 Changeset [67761] by weinig@apple.com
  • 4 edits in trunk/WebKit2

Resize corner jiggles when resizing slowly in WebKit2
<rdar://problem/7897425>
https://bugs.webkit.org/show_bug.cgi?id=45601

Reviewed by Anders Carlsson.

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::windowResizerRect):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::windowResizerRect):

  • WebProcess/WebPage/WebPage.h:

Move resize corner logic to WebPage and use the FrameView's size instead of the WebPages
stored size, which doesn't get updated at the right time. This is in line with all other
scrollbar metrics which are in terms of the FrameView's size.

17:20 Changeset [67760] by weinig@apple.com
  • 16 edits
    9 adds in trunk/WebKit2

Make certificate data available to the WKFrameRef after it is committed
Part of <rdar://problem/8350189>
https://bugs.webkit.org/show_bug.cgi?id=45998

Reviewed by Anders Carlsson.

  • Shared/APIObject.h:

Add new type.

  • Shared/WebCertificateInfo.h: Added.

(WebKit::WebCertificateInfo::create):
(WebKit::WebCertificateInfo::platformCertificateInfo):
(WebKit::WebCertificateInfo::WebCertificateInfo):
(WebKit::WebCertificateInfo::type):
Add API type for vending.

  • Shared/mac/PlatformCertificateInfo.h: Added.

(WebKit::PlatformCertificateInfo::peerCertificates):

  • Shared/mac/PlatformCertificateInfo.mm: Added.

(WebKit::PlatformCertificateInfo::PlatformCertificateInfo):
(WebKit::PlatformCertificateInfo::encode):
(WebKit::PlatformCertificateInfo::decode):
(WebKit::PlatformCertificateInfo::dump):

  • Shared/qt/PlatformCertificateInfo.h: Added.

(WebKit::PlatformCertificateInfo::PlatformCertificateInfo):
(WebKit::PlatformCertificateInfo::encode):
(WebKit::PlatformCertificateInfo::decode):

  • Shared/win/PlatformCertificateInfo.h: Added.

(WebKit::PlatformCertificateInfo::PlatformCertificateInfo):
(WebKit::PlatformCertificateInfo::encode):
(WebKit::PlatformCertificateInfo::decode):
Add platform specific holder for certificate data and encode/decode functions
to send it over the wire. Right now, this only implemented for the mac.

  • UIProcess/API/C/WKAPICast.h:
  • UIProcess/API/C/WKBase.h:
  • UIProcess/API/C/WKCertificateInfo.cpp: Added.

(WKCertificateInfoGetTypeID):

  • UIProcess/API/C/WKCertificateInfo.h: Added.

Add wrapper for WebCertificateInfo.

  • UIProcess/API/C/WKFrame.cpp:

(WKFrameGetCertificateInfo):

  • UIProcess/API/C/WKFrame.h:

Add getter for a WKCertificateInfo.

  • UIProcess/API/C/mac/WKCertificateInfoMac.h: Added.
  • UIProcess/API/C/mac/WKCertificateInfoMac.mm: Added.

(WKCertificateInfoGetPeerCertificates):
Add mac specific getters for the platform specific certificate
data.

  • UIProcess/WebFrameProxy.cpp:

(WebKit::WebFrameProxy::setCertificateInfo):

  • UIProcess/WebFrameProxy.h:

(WebKit::WebFrameProxy::certificateInfo):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didReceiveMessage):
(WebKit::WebPageProxy::didCommitLoadForFrame):

  • UIProcess/WebPageProxy.h:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDidCommitLoad):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:

Pipe the certificate info through to the WebFrameProxy on
commit.

  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:
  • win/WebKit2Generated.make:

Add new files.

17:09 Changeset [67759] by tony@chromium.org
  • 34 edits in trunk/LayoutTests

2010-09-17 Tony Chang <tony@chromium.org>

Reviewed by Kent Tamura.

[chromium] 16 more chromium linux baselines (scrollbars change)
https://bugs.webkit.org/show_bug.cgi?id=46009

  • platform/chromium-linux/tables/mozilla/bugs/bug137388-2-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug137388-2-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug2479-1-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug2479-1-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug29314-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug29314-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug2997-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug2997-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug32205-2-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug32205-2-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug3977-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug3977-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug43854-1-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug43854-1-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug650-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug650-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug73321-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug73321-expected.png:
  • platform/chromium-linux/tables/mozilla/core/captions-expected.checksum:
  • platform/chromium-linux/tables/mozilla/core/captions-expected.png:
  • platform/chromium-linux/tables/mozilla/core/cell_heights-expected.checksum:
  • platform/chromium-linux/tables/mozilla/core/cell_heights-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-column-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-column-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-row-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-row-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_table_bgcolor_rgb-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/x_table_bgcolor_rgb-expected.png:
  • platform/chromium-linux/tables/mozilla/other/nestedTables-expected.checksum:
  • platform/chromium-linux/tables/mozilla/other/nestedTables-expected.png:
  • platform/chromium-linux/tables/mozilla/other/test3-expected.checksum:
  • platform/chromium-linux/tables/mozilla/other/test3-expected.png:
  • platform/chromium/test_expectations.txt:
16:23 Changeset [67758] by commit-queue@webkit.org
  • 12 edits in trunk

2010-09-17 Matthew Delaney <mdelaney@apple.com>

Reviewed by Simon Fraser.

Reduce minimum DOMTimer interval
https://bugs.webkit.org/show_bug.cgi?id=45362

Reduced the minimum allowed DOMTimer interval to 4ms. This has us matching Chrome,
which hasn't had any problem with 4ms in the past 2 years, as well as increasing our
performance on perf tests that have tight frequent loops such as canvas "animation"
performance tests.

No new tests added. Can't reliably instrument a test in javascript to verify that
the minimum clamped interval time is in fact 4ms.

  • WebCore.exp.in:
  • page/DOMTimer.cpp: Removed old comments.
  • page/DOMTimer.h: Removed old comments.
  • page/Settings.cpp: Exposted new method to set minimum DOMTimer interval.
  • page/Settings.h:

2010-09-17 Matthew Delaney <mdelaney@apple.com>

Reviewed by Simon Fraser.

Reduce minimum DOMTimer interval
https://bugs.webkit.org/show_bug.cgi?id=45362

  • WebView/WebView.mm: Added in a call to set the mimimum allowed DOMTimer to 4ms.

2010-09-17 Matthew Delaney <mdelaney@apple.com>

Reviewed by Simon Fraser.

Reduce minimum DOMTimer interval
https://bugs.webkit.org/show_bug.cgi?id=45362

  • WebView.cpp: Added in a call to set the mimimum allowed DOMTimer to 4ms.

2010-09-17 Matthew Delaney <mdelaney@apple.com>

Reviewed by Simon Fraser.

Reduce minimum DOMTimer interval
https://bugs.webkit.org/show_bug.cgi?id=45362

  • WebProcess/WebPage/WebPage.cpp: Added in a call to set the mimimum allowed DOMTimer to 4ms.
16:12 Changeset [67757] by kbr@google.com
  • 2 edits in trunk/WebKit/chromium

2010-09-17 Kenneth Russell <kbr@google.com>

Reviewed by James Robinson.

[chromium] Roll forward Chromium DEPS to pick up Mesa DRT changes
https://bugs.webkit.org/show_bug.cgi?id=46006

  • DEPS:
15:50 Changeset [67756] by mrowe@apple.com
  • 5 edits in trunk

Versioning.

15:49 Changeset [67755] by mrowe@apple.com
  • 1 copy in tags/Safari-534.8

New tag.

15:48 Changeset [67754] by andersca@apple.com
  • 3 edits in trunk/WebKit2

CoreIPC argument coder improvements
https://bugs.webkit.org/show_bug.cgi?id=45999

Reviewed by Sam Weinig.

  • Platform/CoreIPC/ArgumentCoders.h:

Add explicit specialization for a vector of bytes.

  • Platform/CoreIPC/Arguments.h:

(CoreIPC::Arguments1::decode):
(CoreIPC::Arguments2::decode):
(CoreIPC::Arguments3::decode):
(CoreIPC::Arguments4::decode):
(CoreIPC::Arguments5::decode):
(CoreIPC::Arguments6::decode):
Use the injected class name for less typing.

(CoreIPC::Arguments7::Arguments7):
(CoreIPC::Arguments7::encode):
(CoreIPC::Arguments7::decode):
(CoreIPC::In):
(CoreIPC::Out):
Add Arguments7 class.

15:43 Changeset [67753] by tony@chromium.org
  • 24 edits in trunk/LayoutTests

2010-09-17 Tony Chang <tony@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] rebaseline tests that are only scrollbar differences on Linux
https://bugs.webkit.org/show_bug.cgi?id=46000

  • platform/chromium-linux/css1/basic/containment-expected.checksum:
  • platform/chromium-linux/css1/basic/containment-expected.png:
  • platform/chromium-linux/css1/box_properties/padding_right-expected.checksum:
  • platform/chromium-linux/css1/box_properties/padding_right-expected.png:
  • platform/chromium-linux/css1/font_properties/font_size-expected.checksum:
  • platform/chromium-linux/css1/font_properties/font_size-expected.png:
  • platform/chromium-linux/fast/block/float/nested-clearance-expected.checksum:
  • platform/chromium-linux/fast/block/float/nested-clearance-expected.png:
  • platform/chromium-linux/fast/block/positioning/051-expected.checksum:
  • platform/chromium-linux/fast/block/positioning/051-expected.png:
  • platform/chromium-linux/fast/block/positioning/055-expected.checksum:
  • platform/chromium-linux/fast/block/positioning/055-expected.png:
  • platform/chromium-linux/fast/forms/select-change-listbox-size-expected.checksum:
  • platform/chromium-linux/fast/forms/select-change-listbox-size-expected.png:
  • platform/chromium-linux/fast/frames/iframe-scrolling-attribute-expected.checksum:
  • platform/chromium-linux/fast/frames/iframe-scrolling-attribute-expected.png:
  • platform/chromium-linux/fast/multicol/positioned-with-constrained-height-expected.checksum:
  • platform/chromium-linux/fast/multicol/positioned-with-constrained-height-expected.png:
  • platform/chromium-linux/fast/repaint/overflow-scroll-delete-expected.checksum:
  • platform/chromium-linux/fast/repaint/overflow-scroll-delete-expected.png:
  • platform/chromium-linux/http/tests/navigation/error404-frames-expected.checksum:
  • platform/chromium-linux/http/tests/navigation/error404-frames-expected.png:
  • platform/chromium/test_expectations.txt:
15:36 Changeset [67752] by kbr@google.com
  • 2 edits in trunk/WebKit/chromium

2010-09-17 Kenneth Russell <kbr@google.com>

Reviewed by Dimitri Glazkov.

[chromium] Add mesa as DumpRenderTree dependency
https://bugs.webkit.org/show_bug.cgi?id=46001

  • WebKit.gyp:
15:23 Changeset [67751] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-09-17 Marc-Antoine Ruel <maruel@chromium.org>

Reviewed by Dimitri Glazkov.

[Chromium] Split webcore_platform off webcore_remaining

Further reduce webcore_remaining size by moving platform/ code in its
own static libary.
https://bugs.webkit.org/show_bug.cgi?id=45915

  • WebCore.gyp/WebCore.gyp:
14:59 Changeset [67750] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

2010-09-17 Sergio Villar Senin <svillar@igalia.com>

Reviewed by Martin Robinson.

http/tests/security/xss-DENIED-mime-type-execute-as-html.html fails
https://bugs.webkit.org/show_bug.cgi?id=37540

14:57 Changeset [67749] by mpcomplete@chromium.org
  • 12 edits in trunk

2010-09-13 Matt Perry <mpcomplete@chromium.org>

Reviewed by Darin Fisher.

Have V8DOMWindowShell ask the embedder whether to run a V8 extension
in a particular script context.
https://bugs.webkit.org/show_bug.cgi?id=45721

  • bindings/v8/V8DOMWindowShell.cpp: (WebCore::V8DOMWindowShell::createNewContext):
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::registeredExtensionWithV8): (WebCore::V8Proxy::registerExtension):
  • bindings/v8/V8Proxy.h:
  • loader/EmptyClients.h: (WebCore::EmptyFrameLoaderClient::allowScriptExtension):
  • loader/FrameLoaderClient.h:
14:50 Changeset [67748] by aestes@apple.com
  • 2 edits in trunk/WebKit2

2010-09-17 Andy Estes <aestes@apple.com>

Reviewed by Darin Adler.

<rdar://problem/8440903> WK2: REGRESSION (r66156): Web sites using
AppleConnect fail to log in: "HTTP Status 404 - /ssowebapp/scriptFrame"
https://bugs.webkit.org/show_bug.cgi?id=45960

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::createPlugin):
14:47 Changeset [67747] by commit-queue@webkit.org
  • 6 edits
    2 adds
    7 deletes in trunk/LayoutTests

2010-09-17 Mihai Parparita <mihaip@chromium.org>

Reviewed by Dimitri Glazkov.

http/tests/navigation/post-goback1.html should not be a pixel test
https://bugs.webkit.org/show_bug.cgi?id=45834

Convert post-goback1.html to be a simpler dumpAsText test. It can use
the form-target.pl that was added r67466 with some small modifications.

To be extra safe, clear the back forward list for all the tests that
were converted to use dumpAsText.

  • http/tests/navigation/post-basic.html:
  • http/tests/navigation/post-frames.html:
  • http/tests/navigation/post-goback1-expected.txt: Added.
  • http/tests/navigation/post-goback1.html:
  • http/tests/navigation/resources/form-target.pl:
  • http/tests/navigation/resources/go-back.html: Added.
  • platform/chromium-linux/http/tests/navigation/post-goback1-expected.checksum: Removed.
  • platform/chromium-linux/http/tests/navigation/post-goback1-expected.png: Removed.
  • platform/chromium-win/http/tests/navigation/post-goback1-expected.checksum: Removed.
  • platform/chromium-win/http/tests/navigation/post-goback1-expected.png: Removed.
  • platform/chromium/test_expectations.txt:
  • platform/mac/http/tests/navigation/post-goback1-expected.checksum: Removed.
  • platform/mac/http/tests/navigation/post-goback1-expected.png: Removed.
  • platform/mac/http/tests/navigation/post-goback1-expected.txt: Removed.
14:29 Changeset [67746] by andersca@apple.com
  • 2 edits in trunk/WebCore

REGRESSION (r66711): Plug-in replacement text is never shown
https://bugs.webkit.org/show_bug.cgi?id=45997
<rdar://problem/8446766>

Reviewed by Sam Weinig.

Don't return when the plug-in has replacement text.

  • rendering/RenderEmbeddedObject.cpp:

(WebCore::RenderEmbeddedObject::paintReplaced):

14:27 Changeset [67745] by eric.carlson@apple.com
  • 2 edits in trunk/LayoutTests

2010-09-17 Eric Carlson <eric.carlson@apple.com>

Rubber-stamped by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=45983

  • platform/win/Skipped: Skip media-can-play-mpeg4-video.html.
13:42 Changeset [67744] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

2010-09-17 James Robinson <jamesr@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] Unskip the canvas philip suite
https://bugs.webkit.org/show_bug.cgi?id=45991

  • platform/chromium/test_expectations.txt:
13:27 Changeset [67743] by andersca@apple.com
  • 4 edits in trunk/WebKitLibraries

Reviewed, tweaked, and landed by Anders Carlsson.

Patch by Sam Weinig <sam@webkit.org> on 2010-09-17
Add WKCopyNSURLResponsePeerCertificates.

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
13:17 Changeset [67742] by jianli@chromium.org
  • 2 edits
    2 copies in branches/chromium/517

Merge 67734 - createBlobURL with no argument causes crash.
https://bugs.webkit.org/show_bug.cgi?id=45880

Reviewed by Dmitry Titov.

WebCore:

The fix is to check if the passing blob argument is NULL or not.

Test: fast/files/create-blob-url-crash.html

  • dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::createPublicBlobURL):

  • page/DOMWindow.idl: Add attribute to convert null string to undefined.

LayoutTests:

  • fast/files/create-blob-url-crash-expected.txt: Added.
  • fast/files/create-blob-url-crash.html: Added.

BUG=45880
TEST=create-blob-url-crash.html
TBR=jianli@chromium.org
Review URL: http://codereview.chromium.org/3444009

13:11 Changeset [67741] by weinig@apple.com
  • 4 edits in trunk/WebKit2

Make WebNumbers immutable matching CF.

Reviewed by Anders Carlsson.

  • Shared/WebNumber.h:

(WebKit::WebNumber::value):
(WebKit::WebNumber::WebNumber):

  • UIProcess/API/C/WKNumber.cpp:

(WKUInt64GetValue):

  • UIProcess/API/C/WKNumber.h:
13:04 Changeset [67740] by levin@chromium.org
  • 2 edits in trunk/WebKit/chromium

Remove unimplemented destructor declaration to fix Chromium build.
https://bugs.webkit.org/show_bug.cgi?id=45987

Patch by Eric Uhrhane <ericu@chromium.org> on 2010-09-17
Reviewed by David Levin.

  • src/AsyncFileWriterChromium.h:
13:01 Changeset [67739] by ddkilzer@apple.com
  • 2 edits in trunk/WebKit

<http://webkit.org/b/45989> Add WebArchiveInternal.h to Xcode project

Reviewed by Joseph Pecoraro.

  • WebKit.xcodeproj/project.pbxproj: Added missing

WebArchiveInternal.h header file to the project. It has been
missing since r31281!

12:35 Changeset [67738] by weinig@apple.com
  • 7 edits in trunk/WebKit2

Add bool wrapper for WebKit2 API
https://bugs.webkit.org/show_bug.cgi?id=45985

Reviewed by John Sullivan.

  • Shared/APIObject.h:
  • Shared/WebNumber.h:
  • UIProcess/API/C/WKAPICast.h:
  • UIProcess/API/C/WKBase.h:
  • UIProcess/API/C/WKNumber.cpp:

(WKBooleanGetTypeID):
(WKBooleanCreate):
(WKBooleanGetValue):
(WKBooleanSetValue):

  • UIProcess/API/C/WKNumber.h:
12:25 Changeset [67737] by jianli@chromium.org
  • 5 edits in trunk/LayoutTests

Skip the new test fast/files/create-blob-url-crash.html in unsupported
platforms.

  • platform/gtk/Skipped:
  • platform/mac-wk2/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
12:07 Changeset [67736] by demarchi@webkit.org
  • 2 edits in trunk/WebCore

2010-09-17 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Unreviewed, build fix. Add files missed in r67704.

  • CMakeLists.txt:
12:00 Changeset [67735] by simon.fraser@apple.com
  • 11 edits in trunk

2010-09-17 Simon Fraser <simon.fraser@apple.com>

Reviewed by Chris Marrin.

Remove scroll and clip layers for WKCACFLayerRenderer
https://bugs.webkit.org/show_bug.cgi?id=45922

WKCACFLayerRenderer no longer needs its own layers for managing scrolling
and clipping, because RenderLayerCompositor provides this functionality.

  • platform/graphics/win/MediaPlayerPrivateFullscreenWindow.cpp: (WebCore::MediaPlayerPrivateFullscreenWindow::setRootChildLayer): Remove call to setScrollFrame(). (WebCore::MediaPlayerPrivateFullscreenWindow::wndProc): Ditto.
  • platform/graphics/win/WKCACFLayerRenderer.cpp: Remove references to scroll and clip layers (WebCore::WKCACFLayerRenderer::WKCACFLayerRenderer): (WebCore::WKCACFLayerRenderer::setRootChildLayer): (WebCore::WKCACFLayerRenderer::destroyRenderer): (WebCore::WKCACFLayerRenderer::resize):
  • platform/graphics/win/WKCACFLayerRenderer.h:
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::layerTreeAsText): Dump the layers from the root platform layer. (WebCore::RenderLayerCompositor::requiresScrollLayer): On Windows, always say yes.

2010-09-17 Simon Fraser <simon.fraser@apple.com>

Reviewed by Chris Marrin.

Remove scroll and clip layers for WKCACFLayerRenderer
https://bugs.webkit.org/show_bug.cgi?id=45922

WKCACFLayerRenderer no longer needs its own layers for managing scrolling
and clipping, because RenderLayerCompositor provides this functionality.

  • WebView.cpp: (WebView::sizeChanged): Moved code that handles the WM_SIZE message into this method. Use it to resize the layer renderer. (WebView::WebViewWndProc): Call sizeChanged(). (WebView::updateRootLayerContents): No need to call setScrollFrame() any more. (WebView::layerRendererBecameVisible): Move this from the header (no need to be inline).
  • WebView.h:
11:59 Changeset [67734] by jianli@chromium.org
  • 4 edits
    2 adds in trunk

createBlobURL with no argument causes crash.
https://bugs.webkit.org/show_bug.cgi?id=45880

Reviewed by Dmitry Titov.

WebCore:

The fix is to check if the passing blob argument is NULL or not.

Test: fast/files/create-blob-url-crash.html

  • dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::createPublicBlobURL):

  • page/DOMWindow.idl: Add attribute to convert null string to undefined.

LayoutTests:

  • fast/files/create-blob-url-crash-expected.txt: Added.
  • fast/files/create-blob-url-crash.html: Added.
11:48 Changeset [67733] by tonyg@chromium.org
  • 3 edits
    2 copies in branches/chromium/517

Merge 67627 - 2010-09-16 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Adam Barth.

Crash in WebCore::FrameLoader::shouldInterruptLoadForXFrameOptions
https://bugs.webkit.org/show_bug.cgi?id=45833

  • fast/parser/x-frame-options-detached-document-crash-expected.txt: Added.
  • fast/parser/x-frame-options-detached-document-crash.html: Added. Crashes before this patch.

2010-09-16 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Adam Barth.

Crash in WebCore::FrameLoader::shouldInterruptLoadForXFrameOptions
https://bugs.webkit.org/show_bug.cgi?id=45833

Test: fast/parser/x-frame-options-detached-document-crash.html

  • dom/Document.cpp: (WebCore::Document::processHttpEquiv): Other branches in this method already test for a null frame. So it seems to make sense to test that here as well.

BUG=55598
TBR=tonyg@chromium.org
Review URL: http://codereview.chromium.org/3394006

11:39 Changeset [67732] by tonyg@chromium.org
  • 8 edits
    2 copies in branches/chromium/517

Merge 67292 - 2010-09-11 Mihai Parparita <mihaip@chromium.org>

Reviewed by Adam Barth.

URIs in styles created via innerHTML are not resolved against the document's base URI
https://bugs.webkit.org/show_bug.cgi?id=45565

Add test to read back the background image URL from an element that was
created via innerHTML (reduction of http://crbug.com/55023).

  • fast/innerHTML/innerHTML-uri-resolution-expected.txt: Added.
  • fast/innerHTML/innerHTML-uri-resolution.html: Added.

2010-09-11 Mihai Parparita <mihaip@chromium.org>

Reviewed by Adam Barth.

URIs in styles created via innerHTML are not resolved against the document's base URI
https://bugs.webkit.org/show_bug.cgi?id=45565

The dummy document used for fragment parsing created by
FragmentParsingContext should use the base URI of the fragment's
document. Since (HTML)Document doesn't expose a setter for the base URI
(and shouldn't), we allow it to be set by the constructor/create
function.

Also remove some obsolete code that references the legacy tree builder
from HTMLElement that I happened to notice.

Test: fast/innerHTML/innerHTML-uri-resolution.html

  • dom/Document.cpp: (WebCore::Document::Document):
  • dom/Document.h:
  • html/HTMLDocument.cpp: (WebCore::HTMLDocument::HTMLDocument):
  • html/HTMLDocument.h: (WebCore::HTMLDocument::create):
  • html/HTMLElement.cpp: (WebCore::createFragmentFromSource): (WebCore::HTMLElement::setInnerHTML):
  • html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::FragmentParsingContext::FragmentParsingContext):

BUG=56034
TBR=mihaip@chromium.org
Review URL: http://codereview.chromium.org/3400014

11:35 Changeset [67731] by cmarrin@apple.com
  • 7 edits in trunk

2010-09-17 Chris Marrin <cmarrin@apple.com>

Reviewed by Simon Fraser.

Add WebKitAccelerated2dCanvasEnabled flag to WebKit for Mac
https://bugs.webkit.org/show_bug.cgi?id=45911

11:34 Changeset [67730] by bweinstein@apple.com
  • 1 edit in trunk/LayoutTests/ChangeLog

Fix the bug number in the ChangeLog.

11:32 Changeset [67729] by bweinstein@apple.com
  • 2 edits in trunk/LayoutTests

Skip some userscripts tests that are flaky on Windows (but pass on Mac),
this needs investigation, and is being tracked by <http://webkit.org/b/44199>.

Rubber-stamped by Adam Roben.

  • platform/win/Skipped:
11:04 Changeset [67728] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-09-17 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Adam Barth.

ASSERTION FAILED: m_loadEventDelayCount
https://bugs.webkit.org/show_bug.cgi?id=45790

  • dom/AsyncScriptRunner.cpp: (WebCore::AsyncScriptRunner::timerFired): Protect document before we go running scripts.
11:01 Changeset [67727] by senorblanco@chromium.org
  • 3 edits in trunk/WebCore

2010-09-17 Stephen White <senorblanco@chromium.org>

Reviewed by Kenneth Russell.

[CHROMIUM] GPU-accelerated canvas should work in test_shell.
https://bugs.webkit.org/show_bug.cgi?id=45968

In order for the shaders in GPU-accelerated canvas to work in both the
GraphicsContext3D / GLES2 path as well as chromium's test_shell (which
passes them to the Mesa backend unmodified), the precision specifiers
in the fragment shader have to be wrapped in #if GL_ES.

Soon to be covered by many layout tests.

  • platform/graphics/gpu/SolidFillShader.cpp: (WebCore::SolidFillShader::create):
  • platform/graphics/gpu/TexShader.cpp: (WebCore::TexShader::create):
11:00 Changeset [67726] by wsiegrist@apple.com
  • 2 edits in trunk/WebKitTools/BuildSlaveSupport/build.webkit.org-config

2010-09-17 William Siegrist <wsiegrist@apple.com>

Replaces branches option with ChangeFilter since branches is now deprecated.

10:47 Changeset [67725] by mrobinson@webkit.org
  • 2 edits in trunk/WebCore

2010-09-17 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] [REGRESSION] Listbox rendering is incorrect
https://bugs.webkit.org/show_bug.cgi?id=45941

Only apply the shadow tiling optimization to a layer if the GraphicsContext
has a shadow.

This is covered by manual-tests/select-element-type-select.html.

  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::drawBorderlessRectShadow): Before applying the tiled shadow optimization first check to see if the context has a shadow at all.
10:42 Changeset [67724] by mrobinson@webkit.org
  • 13 edits in trunk

2010-09-17 Martin Robinson <mrobinson@igalia.com>

Reviewed by Oliver Hunt.

[GTK] FontPlatformDataFreeType should use smart pointers to hold its members
https://bugs.webkit.org/show_bug.cgi?id=45917

Added support to PlatformRefPtr for handling HashTableDeletedValue.

  • wtf/PlatformRefPtr.h: (WTF::PlatformRefPtr::PlatformRefPtr): Added a constructor that takes HashTableDeletedValue. (WTF::PlatformRefPtr::isHashTableDeletedValue): Added.

2010-09-17 Martin Robinson <mrobinson@igalia.com>

Reviewed by Oliver Hunt.

[GTK] FontPlatformDataFreeType should use smart pointers to hold its members
https://bugs.webkit.org/show_bug.cgi?id=45917

Have FontPlatformDataFreeType use smart pointers to hold its reference-counted
members. Also move the FcPattern specialization from OwnPtrCairo to PlatformRefPtrCairo
as this type is reference-counted.

No new tests as this should not introduce any functionality changes.

  • platform/graphics/cairo/FontCacheFreeType.cpp: (WebCore::FontCache::getFontDataForCharacters): Updated to reflect smart pointer changes. (WebCore::FontCache::createFontPlatformData): Ditto.
  • platform/graphics/cairo/FontPlatformDataFreeType.cpp: (WebCore::FontPlatformData::FontPlatformData): Ditto. (WebCore::FontPlatformData::operator=): Ditto. (WebCore::FontPlatformData::~FontPlatformData): Ditto. (WebCore::FontPlatformData::isFixedPitch): Ditto. (WebCore::FontPlatformData::operator==): Ditto.
  • platform/graphics/cairo/FontPlatformDataFreeType.h: (WebCore::FontPlatformData::FontPlatformData): Ditto. (WebCore::FontPlatformData::scaledFont): Ditto. (WebCore::FontPlatformData::hash): Ditto. (WebCore::FontPlatformData::isHashTableDeletedValue): Ditto.
  • platform/graphics/cairo/GlyphPageTreeNodeCairo.cpp: (WebCore::GlyphPage::fill): Ditto.
  • platform/graphics/cairo/OwnPtrCairo.cpp: Removed FcPattern specialization.
  • platform/graphics/cairo/OwnPtrCairo.h: Ditto.
  • platform/graphics/cairo/PlatformRefPtrCairo.cpp: Added FcPattern and cairo_scaled_font_t specializations. (WTF::refPlatformPtr): Ditto. (WTF::derefPlatformPtr): Ditto.
  • platform/graphics/cairo/PlatformRefPtrCairo.h: Ditto.
  • platform/graphics/cairo/SimpleFontDataCairo.cpp: (WebCore::SimpleFontData::platformInit): Updated to reflect smart pointer changes. (WebCore::SimpleFontData::containsCharacters): Ditto. (WebCore::SimpleFontData::platformWidthForGlyph): Ditto.
  • platform/graphics/gtk/FontGtk.cpp: (WebCore::setPangoAttributes): Ditto.
10:40 Changeset [67723] by aroben@apple.com
  • 2 edits in trunk/LayoutTests

Land new Windows results for fast/forms/file-input-disabled.html

This corresponds to the changes made in r64712.

Rubber-stamped by John Sullivan.

  • platform/win/fast/forms/file-input-disabled-expected.txt:
10:20 Changeset [67722] by mrobinson@webkit.org
  • 3 edits in trunk/WebKitTools

2010-09-17 Martin Robinson <mrobinson@igalia.com>

Reviewed by Oliver Hunt.

Style bot complains about cairo forward declaration naming
https://bugs.webkit.org/show_bug.cgi?id=45867

Exclude Cairo forward declarations from indentifiers with underscores checks.

  • Scripts/webkitpy/style/checkers/cpp.py: Add exclusion for Cairo forward-declarations.
  • Scripts/webkitpy/style/checkers/cpp_unittest.py: Add some tests for this.
10:16 Changeset [67721] by pfeldman@chromium.org
  • 14 edits in trunk

2010-09-14 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: show status message below call stack when debugger is paused on DOM breakpoint
https://bugs.webkit.org/show_bug.cgi?id=45114

  • English.lproj/localizedStrings.js:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::performSearch): (WebCore::InspectorDOMAgent::shouldBreakOnNodeInsertion): (WebCore::InspectorDOMAgent::shouldBreakOnNodeRemoval): (WebCore::InspectorDOMAgent::shouldBreakOnAttributeModification): (WebCore::InspectorDOMAgent::descriptionForDOMEvent):
  • inspector/InspectorDOMAgent.h:
  • inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::didPause):
  • inspector/front-end/CallStackSidebarPane.js: (WebInspector.CallStackSidebarPane): (WebInspector.CallStackSidebarPane.prototype.updateStatus.formatters.s): (WebInspector.CallStackSidebarPane.prototype.updateStatus.append): (WebInspector.CallStackSidebarPane.prototype.updateStatus):
  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.linkifyNodeById):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.debuggerPaused):
  • inspector/front-end/inspector.css: (.pane > .body .placard + .info):
  • inspector/front-end/inspector.js: (WebInspector.pausedScript): (WebInspector.formatLocalized):

2010-09-14 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: show status message below call stack when debugger is paused on DOM breakpoint
https://bugs.webkit.org/show_bug.cgi?id=45114

  • http/tests/inspector/inspector-test2.js: (initialize_InspectorTest.InspectorTest.evaluateInPageWithTimeout):
10:02 Changeset [67720] by tonyg@chromium.org
  • 1 edit
    2 adds in trunk/WebKitSite

2010-09-16 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Adam Barth.

Adding a timeline screenshot for blocking and defer scripts
https://bugs.webkit.org/show_bug.cgi?id=45933

  • blog-files/timeline-blocking-script.png: Added.
  • blog-files/timeline-defer-script.png: Added.
09:56 Changeset [67719] by inferno@chromium.org
  • 2 edits
    4 copies in branches/chromium/517

Merge 67281
Review URL: http://codereview.chromium.org/3419009

09:47 Changeset [67718] by inferno@chromium.org
  • 1 edit
    3 copies in branches/chromium/517

Merge 67509
Review URL: http://codereview.chromium.org/3452011

09:38 Changeset [67717] by inferno@chromium.org
  • 3 edits in branches/chromium/517

Merge 67240
Review URL: http://codereview.chromium.org/3464001

09:36 Changeset [67716] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

2010-09-17 Johnny Ding <jnd@chromium.org>

Reviewed by Adam Barth.

Stop history reload navigation to bypass WebKit's popup blocker.
Now history reload can only navigate the page in self frame, no matter
what target frame is defined in <base> and no new window can be created.
https://bugs.webkit.org/show_bug.cgi?id=45369

Test: fast/events/popup-blocked-from-history-reload.html

  • loader/RedirectScheduler.cpp: (WebCore::ScheduledNavigation::ScheduledNavigation): (WebCore::ScheduledNavigation::wasUserGesture): Move the m_wasUserGesture to base class ScheduledNavigation. Then all asynchronous navigation situations can restore the correct gesture state during the real navigation process. (WebCore::ScheduledURLNavigation::ScheduledURLNavigation): (WebCore::ScheduledURLNavigation::fire): (WebCore::ScheduledURLNavigation::referrer): (WebCore::ScheduledHistoryNavigation::ScheduledHistoryNavigation): (WebCore::ScheduledHistoryNavigation::fire): (WebCore::ScheduledFormSubmission::ScheduledFormSubmission): (WebCore::ScheduledFormSubmission::fire): (WebCore::RedirectScheduler::scheduleHistoryNavigation):

2010-09-17 Johnny Ding <jnd@chromium.org>

Reviewed by Adam Barth.

Stop history reload navigation to bypass WebKit's popup blocker.
https://bugs.webkit.org/show_bug.cgi?id=45369

  • fast/events/popup-blocked-from-history-reload-expected.txt: Added.
  • fast/events/popup-blocked-from-history-reload.html: Added.
09:30 Changeset [67715] by zmo@google.com
  • 2 edits in trunk/LayoutTests

2010-09-17 Zhenyao Mo <zmo@google.com>

Unreviewed.

Add failing WebGL tests in drt_expectations.txt.

  • platform/chromium/drt_expectations.txt:
09:27 Changeset [67714] by vangelis@chromium.org
  • 2 edits in trunk/WebCore

2010-09-16 Vangelis Kokkevis <vangelis@chromium.org>

Reviewed by James Robinson.

[chromium] Clip the update region of an ImageLayerChromium to actual size
of the image bitmap to prevent uninitialized memory access when uploading
the dirty region to the texture.
https://bugs.webkit.org/show_bug.cgi?id=45937

  • platform/graphics/chromium/ImageLayerChromium.cpp: (WebCore::ImageLayerChromium::updateContents):
09:25 Changeset [67713] by inferno@chromium.org
  • 2 edits
    2 copies in branches/chromium/517

Merge 67236

TBR=jschuh@chromium.org
Review URL: http://codereview.chromium.org/3419008

09:20 Changeset [67712] by inferno@chromium.org
  • 3 edits in branches/chromium/517

Merge 67356

TBR=abarth@webkit.org
Review URL: http://codereview.chromium.org/3402012

09:15 Changeset [67711] by inferno@chromium.org
  • 8 edits in branches/chromium/517

Merge 67357

Review URL: http://codereview.chromium.org/3403012

09:13 Changeset [67710] by dglazkov@chromium.org
  • 2 edits in trunk/WebCore

2010-09-17 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by David Hyatt.

Remove extraneous RenderObject traversal.
https://bugs.webkit.org/show_bug.cgi?id=45821

This code always exits in the first iteration of the loop,
because in the context of this call, node->renderer()->node() != 0
is always true.

No behavior change, covered by existing tests.

  • page/EventHandler.cpp: (WebCore::EventHandler::canMouseDownStartSelect): Removed the loop. (WebCore::EventHandler::canMouseDragExtendSelect): Ditto.
09:02 Changeset [67709] by pfeldman@chromium.org
  • 6 edits in trunk/WebCore

2010-09-17 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: FrameLoader::loadedResourceFromMemoryCache reports
resource as not cached to InspectorController.
https://bugs.webkit.org/show_bug.cgi?id=45961

There is one path in control flow that leads to resources being
reported as not cached. Patch to follow.

  • inspector/InspectorController.cpp: (WebCore::InspectorController::markResourceAsCached):
  • inspector/InspectorController.h:
  • inspector/InspectorResource.cpp: (WebCore::InspectorResource::markAsCached): (WebCore::InspectorResource::updateResponse):
  • inspector/InspectorResource.h:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::loadedResourceFromMemoryCache):
08:52 Changeset [67708] by aroben@apple.com
  • 2 edits in trunk/LayoutTests

Land new Windows results for html5lib/runner.html

This corresponds to the changes made in r67233 and r67356.

Rubber-stamped by Anders Carlsson.

  • platform/win/html5lib/runner-expected.txt:
08:38 Changeset [67707] by aroben@apple.com
  • 2 edits in trunk/LayoutTests

Add some tests failing due to unimplemented DRT APIs to the Windows Skipped file

  • platform/win/Skipped: Added two tests which fail due to

already-known limitations of Windows DRT.

08:11 Changeset [67706] by wsiegrist@apple.com
  • 1 edit in trunk/WebKitTools/BuildSlaveSupport/build.webkit.org-config/public_html/default.css

2010-09-17 William Siegrist <wsiegrist@apple.com>

Remove centering on results directory listing.

08:00 Changeset [67705] by apavlov@chromium.org
  • 2 edits
    2 adds in trunk/WebCore

2010-09-17 Alexander Pavlov <apavlov@chromium.org>

Unreviewed, build fix. Add files missed in the previous commit.

  • GNUmakefile.am:
  • css/CSSPropertySourceData.cpp: Added. (WebCore::SourceRange::SourceRange): (WebCore::SourceRange::operator=): (WebCore::CSSPropertySourceData::CSSPropertySourceData): (WebCore::CSSPropertySourceData::operator=): (WebCore::CSSPropertySourceData::toString): (WebCore::CSSPropertySourceData::hash): (WebCore::CSSPropertySourceData::init):
  • css/CSSPropertySourceData.h: Added. (WebCore::CSSPropertySourceData::~CSSPropertySourceData): (WebCore::CSSStyleSourceData::create):
07:37 Changeset [67704] by apavlov@chromium.org
  • 20 edits in trunk

2010-09-15 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Provide source-based properties for style declarations to CSSParser clients

This change:

  • Enables InspectorCSSStore to extract CSS stylesheet text for all source-based stylesheets, even with the resource tracking turned off.
  • Adds to CSSParser a capability of source-related style declaration data extraction:
    • Start/end source offsets for a declaration, relative to the parent stylesheet start or the "style" attribute value.
    • Start/end source offsets for CSS properties, relative to the declaration start.
    • CSS property data: name, value, priority, WebCore parsability (i.e. if the property is understood by WebCore).
  • Provides the extracted data to the WebInspector frontend via InspectorDOMAgent::getStyleSourceData(). https://bugs.webkit.org/show_bug.cgi?id=44949

WebCore:

  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSGrammar.y:
  • css/CSSMutableStyleDeclaration.h: (WebCore::CSSMutableStyleDeclaration::node):
  • css/CSSParser.cpp: (WebCore::CSSParser::CSSParser): (WebCore::CSSParser::parseSheet): (WebCore::CSSParser::parseDeclaration): (WebCore::CSSParser::createStyleRule): (WebCore::CSSParser::markRuleBodyStart): (WebCore::CSSParser::markPropertyStart): (WebCore::CSSParser::markPropertyEnd):
  • css/CSSParser.h: (WebCore::CSSParser::resetPropertyMarks):
  • css/CSSPropertySourceData.cpp: Added. (WebCore::SourceRange::SourceRange): (WebCore::SourceRange::operator=): (WebCore::CSSPropertySourceData::CSSPropertySourceData): (WebCore::CSSPropertySourceData::operator=): (WebCore::CSSPropertySourceData::toString): (WebCore::CSSPropertySourceData::hash): (WebCore::CSSPropertySourceData::init):
  • css/CSSPropertySourceData.h: Added. (WebCore::CSSPropertySourceData::~CSSPropertySourceData): (WebCore::CSSStyleSourceData::create):
  • inspector/Inspector.idl:
  • inspector/InspectorCSSStore.cpp: (WebCore::InspectorCSSStore::reset): (WebCore::InspectorCSSStore::styleSheetText): (WebCore::InspectorCSSStore::resourceStyleSheetText): (WebCore::InspectorCSSStore::inlineStyleSheetText): (WebCore::InspectorCSSStore::getStyleSourceData): (WebCore::InspectorCSSStore::extractRanges): (WebCore::InspectorCSSStore::getStyleAttributeRanges): (WebCore::InspectorCSSStore::getParentStyleSheet): (WebCore::InspectorCSSStore::inlineStyleElement):
  • inspector/InspectorCSSStore.h:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::resourceContentForURL):
  • inspector/InspectorController.h:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::getStyleSourceData): (WebCore::InspectorDOMAgent::buildObjectForStyle):
  • inspector/InspectorDOMAgent.h:

LayoutTests:

  • inspector/resources/styles-source-offsets.css: (body): (/* comment before selector */body.main1/* comment after selector */): (body.main2):
  • inspector/styles-source-offsets-expected.txt:
  • inspector/styles-source-offsets.html:
06:36 Changeset [67703] by apavlov@chromium.org
  • 3 edits in trunk/WebCore

2010-09-17 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Show node description in inspector highlight
https://bugs.webkit.org/show_bug.cgi?id=20930

  • inspector/InspectorController.cpp: (WebCore::InspectorController::drawNodeHighlight): (WebCore::InspectorController::drawElementTitle):
  • inspector/InspectorController.h:
06:06 Changeset [67702] by alex@webkit.org
  • 3 edits in trunk/LayoutTests

2010-09-17 Alejandro G. Castro <alex@igalia.com>

Unreviewed, GTK+ rebaselines.

  • platform/gtk/fast/repaint/multicol-repaint-expected.txt:
  • platform/gtk/svg/css/getComputedStyle-basic-expected.txt:
04:09 Changeset [67701] by satish@chromium.org
  • 7 edits
    3 copies in trunk/LayoutTests/platform

2010-09-17 Satish Sampath <satish@chromium.org>

Unreviewed, updated chromium baselines and disabled a failing test.

  • platform/chromium-linux/fast/css/getComputedStyle/computed-style-expected.txt
  • platform/chromium-linux/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt
  • platform/chromium-linux/svg/css/getComputedStyle-basic-expected.txt
  • platform/chromium-mac/fast/css/getComputedStyle/computed-style-expected.txt
  • platform/chromium-mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt
  • platform/chromium-mac/svg/css/getComputedStyle-basic-expected.txt
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt
  • platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt
  • platform/chromium/test_expectations.txt
01:15 Changeset [67700] by pfeldman@chromium.org
  • 1 edit in branches/chromium/517/WebCore/inspector/InspectorController.cpp

Merge 67651 - 2010-09-16 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: quick fix for crash in InspectorController::loadBreakpoints caused by empty main resource
https://bugs.webkit.org/show_bug.cgi?id=45901

  • inspector/InspectorController.cpp: (WebCore::InspectorController::breakpointsSettingKey):

TBR=commit-queue@webkit.org
Review URL: http://codereview.chromium.org/3380012

01:13 Changeset [67699] by pfeldman@chromium.org
  • 1 edit in branches/chromium/517/WebCore/inspector/front-end/ResourcesPanel.js

Merge 67629 - 2010-09-16 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: prevent resource timing popover from having scrollers.
https://bugs.webkit.org/show_bug.cgi?id=45883

  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype._showPopover):

TBR=pfeldman@chromium.org
Review URL: http://codereview.chromium.org/3442005

01:10 Changeset [67698] by pfeldman@chromium.org
  • 4 edits in branches/chromium/517

Merge 67623 - 2010-09-16 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [REGRESSION] Scripts disappear from scripts panel after navigation
https://bugs.webkit.org/show_bug.cgi?id=45890

  • inspector/InspectorController.cpp: (WebCore::InspectorController::populateScriptObjects): (WebCore::InspectorController::restoreDebugger): (WebCore::InspectorController::restoreProfiler):
  • inspector/InspectorController.h:

2010-09-16 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [REGRESSION] Scripts disappear from scripts panel after navigation
https://bugs.webkit.org/show_bug.cgi?id=45890

  • src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::setRuntimeProperty): make sure debugger and profiler are initialized when inspected page navigation leads to renderer process change.

TBR=yurys@chromium.org
Review URL: http://codereview.chromium.org/3389017

01:07 Changeset [67697] by pfeldman@chromium.org
  • 2 edits in branches/chromium/517/WebCore/inspector/front-end

Merge 67601 - 2010-09-16 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: console.group(object) does not allow object to be expanded.
https://bugs.webkit.org/show_bug.cgi?id=45806

  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleGroup.prototype.addMessage):
  • inspector/front-end/treeoutline.js: (TreeElement.treeElementToggled):

TBR=pfeldman@chromium.org
Review URL: http://codereview.chromium.org/3429016

00:20 Changeset [67696] by mitz@apple.com
  • 2 edits in trunk/WebKit/mac

WebKit should use system wide spell checking preference when application specific one isn't set.
https://bugs.webkit.org/show_bug.cgi?id=45789
<rdar://problem/8416041>

Patch by Jia Pu <jpu@apple.com> on 2010-09-17
Reviewed by Dan Bernstein.

  • WebView/WebView.mm:

(+[WebView initialize]): Use system wide autocorrection and text substitution preferences

when the application level preferences are not set.

09/16/10:

23:20 Changeset [67695] by tkent@chromium.org
  • 3 edits in trunk/WebCore

2010-09-16 takano takumi <takano1@asia.apple.com>

Reviewed by Kent Tamura.

https://bugs.webkit.org/show_bug.cgi?id=45020
Support "block-flow" and "writing-mode": interpret properties into RenderStyle

Fixed a regression in SVG test introduced by my previous change.

  • css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::operator EWritingMode):
  • css/SVGCSSParser.cpp: (WebCore::CSSParser::parseSVGValue):
22:26 Changeset [67694] by dumi@chromium.org
  • 3 edits in trunk/WebKit/chromium

2010-09-16 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r67693.
http://trac.webkit.org/changeset/67693
https://bugs.webkit.org/show_bug.cgi?id=45946

"Need to pick up a chromium change first" (Requested by dumi
on #webkit).

  • public/WebHTTPBody.h:
  • src/WebHTTPBody.cpp: (WebKit::WebHTTPBody::elementAt): (WebKit::WebHTTPBody::appendFileRange):
21:56 Changeset [67693] by dumi@chromium.org
  • 3 edits in trunk/WebKit/chromium

Remove WebHTTPBody::appendFileRange(..., const WebFileInfo&).

Reviewed by Darin Fisher.

  • public/WebHTTPBody.h:
  • src/WebHTTPBody.cpp:

(WebKit::WebHTTPBody::elementAt):

21:30 Changeset [67692] by kinuko@chromium.org
  • 4 edits in trunk/WebKitTools

2010-09-16 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by Ojan Vafai.

Include detailed test modifiers (e.g. FLAKY) in results.json for failing non-layout tests
https://bugs.webkit.org/show_bug.cgi?id=45408

This change also tries to remove duplicated upload_results_json methods
in run_webkit_tests.py and json_results_generator.py.

  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
21:05 Changeset [67691] by sullivan@apple.com
  • 2 edits in trunk/WebKit/mac

<rdar://problem/8395558>
https://bugs.webkit.org/show_bug.cgi?id=45938
_web_makePluginViewsPerformSelector:: mutates subviews array while iterating it

Reviewed by Darin Adler.

  • WebView/WebHTMLView.mm:

(-[WebHTMLView _web_makePluginSubviewsPerformSelector:withObject:]):
Converted from -[NSArray _web_makePluginViewsPerformSelector:withObject:]. The old method
was only ever called on the result of -[WebHTMLView subviews]. By moving that knowledge into
this helper method, it can't be used incorrectly. Now it makes a copy of [WebHTMLView subviews]
before enumerating it, to ensure that the selector can't mutate the array being enumerated.
(-[WebHTMLView viewWillMoveToHostWindow:]):
Updated for _web_makePluginSubviewsPerformSelector:: signature change.
(-[WebHTMLView viewDidMoveToHostWindow]):
Ditto.

18:53 Changeset [67690] by kbr@google.com
  • 8 edits in trunk

2010-09-16 Kenneth Russell <kbr@google.com>

Reviewed by James Robinson.

Add entry points to GraphicsContext3D needed for Chromium compositor port
https://bugs.webkit.org/show_bug.cgi?id=45939

Added entry points for two Chromium-specific extensions, and added
a flag to the GraphicsContext3D constructor, currently unsupported
by all ports (including Chromium), indicating whether the context
should render directly to the passed HostWindow or off-screen per
the current semantics. The switch to use GraphicsContext3D in
Chromium's compositor will follow in a subsequent patch.

No new tests; functionality is unchanged. Built and tested
Chromium and WebKit on Mac OS X.

  • src/GraphicsContext3D.cpp: (WebCore::GraphicsContext3D::GraphicsContext3D): (WebCore::GraphicsContext3D::create):
  • src/GraphicsContext3DInternal.h:

2010-09-16 Kenneth Russell <kbr@google.com>

Reviewed by James Robinson.

Add entry points to GraphicsContext3D needed for Chromium compositor port
https://bugs.webkit.org/show_bug.cgi?id=45939

Added entry points for two Chromium-specific extensions, and added
a flag to the GraphicsContext3D constructor, currently unsupported
by all ports (including Chromium), indicating whether the context
should render directly to the passed HostWindow or off-screen per
the current semantics. The switch to use GraphicsContext3D in
Chromium's compositor will follow in a subsequent patch.

No new tests; functionality is unchanged. Built and tested
Chromium and WebKit on Mac OS X.

  • platform/graphics/GraphicsContext3D.cpp: (WebCore::GraphicsContext3D::supportsMapSubCHROMIUM): (WebCore::GraphicsContext3D::mapBufferSubDataCHROMIUM): (WebCore::GraphicsContext3D::unmapBufferSubDataCHROMIUM): (WebCore::GraphicsContext3D::mapTexSubImage2DCHROMIUM): (WebCore::GraphicsContext3D::unmapTexSubImage2DCHROMIUM): (WebCore::GraphicsContext3D::supportsCopyTextureToParentTextureCHROMIUM): (WebCore::GraphicsContext3D::copyTextureToParentTextureCHROMIUM):
  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/mac/GraphicsContext3DMac.mm: (WebCore::GraphicsContext3D::create): (WebCore::GraphicsContext3D::GraphicsContext3D):
  • platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3D::create): (WebCore::GraphicsContext3D::GraphicsContext3D):
18:34 Changeset [67689] by tonikitoo@webkit.org
  • 4 edits in trunk/WebKitTools

2010-09-16 Antonio Gomes <tonikitoo@webkit.org>

Reviewed by Andreas Kling.

[Qt] When switching views (WebViewGraphicsBased <--> WebViewTraditional), QWebPage signals and QActions have to be re-set.

Recently r67554 changed the way different views use the WebPage class: it was previously being shared between
different views, but now for each view switch, a new WebPage class is constructed and set. Signals and QAction's
were not being set to the new WebPage though. Patch fix that, by re constructing the toolbar, and then re-hooking
all page specific stuff to the UI.

  • QtTestBrowser/launcherwindow.cpp: (LauncherWindow::initializeView):
  • QtTestBrowser/mainwindow.cpp: (MainWindow::MainWindow): (MainWindow::buildUI): (MainWindow::setPage):
  • QtTestBrowser/mainwindow.h:
18:33 Changeset [67688] by tonikitoo@webkit.org
  • 3 edits in trunk/WebKitTools

2010-09-12 Antonio Gomes <tonikitoo@webkit.org>

Reviewed by Andreas Kling.

Make all accesses to m_item (GraphicsWebView) done by WebViewGraphicsBased class happen though graphicsWebView getter method.

This patch is mostly a preparation for another commit, where the ownership of the m_item/GraphicsWebView
object will move to the qgraphicsscene instead of the qgraphicsview.

  • QtTestBrowser/webview.cpp: (WebViewGraphicsBased::setPage): (WebViewGraphicsBased::setResizesToContents): (WebViewGraphicsBased::resizeEvent): (WebViewGraphicsBased::animatedFlip):
  • QtTestBrowser/webview.h: (WebViewGraphicsBased::setItemCacheMode): (WebViewGraphicsBased::itemCacheMode):
18:32 Changeset [67687] by tonikitoo@webkit.org
  • 2 edits in trunk/WebKitTools

2010-09-12 Antonio Gomes <tonikitoo@webkit.org>

Reviewed by Andreas Kling.

Moved setYRotation method body out of the class (WebViewGraphicsBased) definition.

We usually separate methods whose body are larger the a few lines from the class definition.

  • QtTestBrowser/webview.h: (WebViewGraphicsBased::yRotation): (WebViewGraphicsBased::setYRotation):
18:32 Changeset [67686] by tonikitoo@webkit.org
  • 2 edits in trunk/WebKitTools

2010-09-12 Antonio Gomes <tonikitoo@webkit.org>

Reviewed by Andreas Kling.

Make initializeView method of LauncherWindow private.

No one else needs to be able to call it but LauncherWindow.
Also moving the declation of isGraphicsBased method down in the same file, in order
to better group related methods.

  • QtTestBrowser/launcherwindow.h:
  • QtTestBrowser/launcherwindow.h:
18:31 Changeset [67685] by tonikitoo@webkit.org
  • 3 edits in trunk/WebKitTools

2010-09-12 Antonio Gomes <tonikitoo@webkit.org>

Reviewed by Andreas Kling.

Make the getter 'page' method of MainWindow const.

  • QtTestBrowser/mainwindow.cpp: (MainWindow::page):
  • QtTestBrowser/mainwindow.h:
18:31 Changeset [67684] by tonikitoo@webkit.org
  • 3 edits in trunk/WebKitTools

2010-09-12 Antonio Gomes <tonikitoo@webkit.org>

Reviewed by Andreas Kling.

Remove useless parameter from MainWindow class' constructor.

The parameter defaults to an empty URL and is not being used by any caller. Apart from that
and is also not referred in the constructor body and does not make much sense.

  • QtTestBrowser/mainwindow.cpp: (MainWindow::MainWindow):
  • QtTestBrowser/mainwindow.h:
18:18 Changeset [67683] by oliver@apple.com
  • 5 edits in trunk/JavaScriptCore

2010-09-16 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

Crash due to timer triggered GC on one heap while another heap is active
https://bugs.webkit.org/show_bug.cgi?id=45932
<rdar://problem/8318446>

The GC timer may trigger for one heap while another heap is active. This
is safe, but requires us to ensure that we have temporarily associated the
thread's identifierTable with the heap we're collecting on. Otherwise we
may end up with the identifier tables in an inconsistent state leading to
an eventual crash.

  • runtime/Collector.cpp: (JSC::Heap::allocate): (JSC::Heap::reset): (JSC::Heap::collectAllGarbage):

Add assertions to ensure we have the correct identifierTable active
while collecting.

  • runtime/GCActivityCallbackCF.cpp: (JSC::DefaultGCActivityCallbackPlatformData::trigger):

Temporarily make the expected IdentifierTable active

  • wtf/WTFThreadData.h: (JSC::IdentifierTable::remove):

Make it possible to see when IdentifierTable::remove has succeeded

  • wtf/text/StringImpl.cpp: (WTF::StringImpl::~StringImpl):

CRASH if an StringImpl is an Identifier but isn't present in the
active IdentifierTable. If we get to this state something has
gone wrong and we should just crash immediately.

18:04 Changeset [67682] by simon.fraser@apple.com
  • 35 edits in trunk

2010-09-16 Simon Fraser <simon.fraser@apple.com>

Reviewed by James Robinson.

In layerTreeAsText output, avoid printing properties which have their default values
https://bugs.webkit.org/show_bug.cgi?id=45931

Don't dump properties that have their default values to simplify output.

  • platform/graphics/GraphicsLayer.cpp: (WebCore::GraphicsLayer::dumpProperties):
17:55 Changeset [67681] by johnnyg@google.com
  • 96 edits
    98 adds
    4 deletes in trunk/LayoutTests

2010-09-16 John Gregg <johnnyg@google.com>

Unreviewed, chromium rebaselines.

[chromium] Rebaseline multicol tests
https://bugs.webkit.org/show_bug.cgi?id=45936

  • platform/chromium-linux/fast/multicol/border-padding-pagination-expected.checksum: Added.
  • platform/chromium-linux/fast/multicol/border-padding-pagination-expected.txt: Added.
  • platform/chromium-linux/fast/multicol/client-rects-expected.checksum:
  • platform/chromium-linux/fast/multicol/client-rects-expected.png:
  • platform/chromium-linux/fast/multicol/client-rects-expected.txt: Added.
  • platform/chromium-linux/fast/multicol/column-break-with-balancing-expected.checksum: Added.
  • platform/chromium-linux/fast/multicol/column-break-with-balancing-expected.png: Added.
  • platform/chromium-linux/fast/multicol/column-break-with-balancing-expected.txt: Added.
  • platform/chromium-linux/fast/multicol/column-count-with-rules-expected.checksum:
  • platform/chromium-linux/fast/multicol/column-count-with-rules-expected.png:
  • platform/chromium-linux/fast/multicol/column-rules-expected.checksum:
  • platform/chromium-linux/fast/multicol/column-rules-expected.png:
  • platform/chromium-linux/fast/multicol/column-rules-expected.txt: Added.
  • platform/chromium-linux/fast/multicol/float-avoidance-expected.checksum:
  • platform/chromium-linux/fast/multicol/float-avoidance-expected.png:
  • platform/chromium-linux/fast/multicol/float-avoidance-expected.txt: Added.
  • platform/chromium-linux/fast/multicol/float-multicol-expected.checksum:
  • platform/chromium-linux/fast/multicol/float-multicol-expected.png:
  • platform/chromium-linux/fast/multicol/float-multicol-expected.txt: Added.
  • platform/chromium-linux/fast/multicol/float-paginate-complex-expected.checksum: Added.
  • platform/chromium-linux/fast/multicol/float-paginate-complex-expected.png: Added.
  • platform/chromium-linux/fast/multicol/float-paginate-complex-expected.txt: Added.
  • platform/chromium-linux/fast/multicol/float-paginate-expected.txt:
  • platform/chromium-linux/fast/multicol/layers-in-multicol-expected.checksum:
  • platform/chromium-linux/fast/multicol/layers-in-multicol-expected.png:
  • platform/chromium-linux/fast/multicol/layers-in-multicol-expected.txt: Added.
  • platform/chromium-linux/fast/multicol/margin-collapse-expected.checksum: Added.
  • platform/chromium-linux/fast/multicol/margin-collapse-expected.txt: Added.
  • platform/chromium-linux/fast/multicol/max-height-columns-block-expected.checksum: Added.
  • platform/chromium-linux/fast/multicol/max-height-columns-block-expected.png: Added.
  • platform/chromium-linux/fast/multicol/max-height-columns-block-expected.txt: Added.
  • platform/chromium-linux/fast/multicol/nested-columns-expected.checksum:
  • platform/chromium-linux/fast/multicol/nested-columns-expected.png:
  • platform/chromium-linux/fast/multicol/nested-columns-expected.txt: Added.
  • platform/chromium-linux/fast/multicol/paginate-block-replaced-expected.txt:
  • platform/chromium-linux/fast/multicol/positioned-split-expected.checksum: Added.
  • platform/chromium-linux/fast/multicol/positioned-split-expected.png: Added.
  • platform/chromium-linux/fast/multicol/positioned-split-expected.txt: Added.
  • platform/chromium-linux/fast/multicol/shadow-breaking-expected.checksum: Added.
  • platform/chromium-linux/fast/multicol/shadow-breaking-expected.txt: Added.
  • platform/chromium-linux/fast/multicol/single-line-expected.checksum:
  • platform/chromium-linux/fast/multicol/single-line-expected.png:
  • platform/chromium-linux/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.checksum:
  • platform/chromium-linux/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.png:
  • platform/chromium-linux/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.txt: Added.
  • platform/chromium-linux/fast/multicol/span/span-as-immediate-child-generated-content-expected.checksum:
  • platform/chromium-linux/fast/multicol/span/span-as-immediate-child-generated-content-expected.png:
  • platform/chromium-linux/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt: Added.
  • platform/chromium-linux/fast/multicol/span/span-as-immediate-child-property-removal-expected.checksum:
  • platform/chromium-linux/fast/multicol/span/span-as-immediate-child-property-removal-expected.png:
  • platform/chromium-linux/fast/multicol/span/span-as-immediate-child-property-removal-expected.txt: Added.
  • platform/chromium-linux/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.checksum:
  • platform/chromium-linux/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.png:
  • platform/chromium-linux/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.txt: Added.
  • platform/chromium-linux/fast/multicol/span/span-as-immediate-columns-child-expected.txt: Added.
  • platform/chromium-linux/fast/multicol/span/span-as-immediate-columns-child-removal-expected.checksum:
  • platform/chromium-linux/fast/multicol/span/span-as-immediate-columns-child-removal-expected.png:
  • platform/chromium-linux/fast/multicol/span/span-as-immediate-columns-child-removal-expected.txt: Added.
  • platform/chromium-linux/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.checksum:
  • platform/chromium-linux/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png:
  • platform/chromium-linux/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.txt: Added.
  • platform/chromium-linux/fast/multicol/span/span-as-nested-columns-child-expected.checksum:
  • platform/chromium-linux/fast/multicol/span/span-as-nested-columns-child-expected.png:
  • platform/chromium-linux/fast/multicol/span/span-as-nested-columns-child-expected.txt: Added.
  • platform/chromium-linux/fast/multicol/table-margin-collapse-expected.checksum: Added.
  • platform/chromium-linux/fast/multicol/table-margin-collapse-expected.png: Added.
  • platform/chromium-linux/fast/multicol/table-margin-collapse-expected.txt: Added.
  • platform/chromium-linux/fast/multicol/table-vertical-align-expected.checksum: Added.
  • platform/chromium-linux/fast/multicol/table-vertical-align-expected.png: Added.
  • platform/chromium-linux/fast/multicol/table-vertical-align-expected.txt: Added.
  • platform/chromium-linux/fast/multicol/unsplittable-inline-block-expected.checksum: Added.
  • platform/chromium-linux/fast/multicol/unsplittable-inline-block-expected.png: Added.
  • platform/chromium-linux/fast/multicol/unsplittable-inline-block-expected.txt: Added.
  • platform/chromium-linux/fast/repaint/multicol-repaint-expected.txt:
  • platform/chromium-mac/fast/multicol/client-rects-expected.checksum:
  • platform/chromium-mac/fast/multicol/client-rects-expected.png: Removed.
  • platform/chromium-mac/fast/multicol/column-break-with-balancing-expected.checksum: Added.
  • platform/chromium-mac/fast/multicol/column-break-with-balancing-expected.png: Added.
  • platform/chromium-mac/fast/multicol/column-rules-expected.checksum: Added.
  • platform/chromium-mac/fast/multicol/column-rules-expected.png: Added.
  • platform/chromium-mac/fast/multicol/float-avoidance-expected.checksum:
  • platform/chromium-mac/fast/multicol/float-multicol-expected.checksum: Added.
  • platform/chromium-mac/fast/multicol/float-multicol-expected.png: Added.
  • platform/chromium-mac/fast/multicol/float-paginate-complex-expected.checksum: Added.
  • platform/chromium-mac/fast/multicol/float-paginate-complex-expected.png: Added.
  • platform/chromium-mac/fast/multicol/float-paginate-expected.checksum: Added.
  • platform/chromium-mac/fast/multicol/float-paginate-expected.png: Added.
  • platform/chromium-mac/fast/multicol/layers-in-multicol-expected.checksum:
  • platform/chromium-mac/fast/multicol/layers-in-multicol-expected.png: Added.
  • platform/chromium-mac/fast/multicol/margin-collapse-expected.checksum: Added.
  • platform/chromium-mac/fast/multicol/max-height-columns-block-expected.checksum: Added.
  • platform/chromium-mac/fast/multicol/nested-columns-expected.checksum: Added.
  • platform/chromium-mac/fast/multicol/paginate-block-replaced-expected.checksum: Added.
  • platform/chromium-mac/fast/multicol/positioned-split-expected.checksum: Added.
  • platform/chromium-mac/fast/multicol/shadow-breaking-expected.checksum: Added.
  • platform/chromium-mac/fast/multicol/single-line-expected.checksum: Added.
  • platform/chromium-mac/fast/multicol/span/span-as-immediate-child-generated-content-expected.checksum:
  • platform/chromium-mac/fast/multicol/span/span-as-immediate-child-generated-content-expected.png:
  • platform/chromium-mac/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt: Added.
  • platform/chromium-mac/fast/multicol/span/span-as-immediate-child-property-removal-expected.checksum:
  • platform/chromium-mac/fast/multicol/span/span-as-immediate-child-property-removal-expected.png:
  • platform/chromium-mac/fast/multicol/span/span-as-immediate-child-property-removal-expected.txt: Added.
  • platform/chromium-mac/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.txt: Added.
  • platform/chromium-mac/fast/multicol/span/span-as-immediate-columns-child-expected.checksum:
  • platform/chromium-mac/fast/multicol/span/span-as-immediate-columns-child-expected.png: Removed.
  • platform/chromium-mac/fast/multicol/span/span-as-immediate-columns-child-expected.txt: Added.
  • platform/chromium-mac/fast/multicol/span/span-as-immediate-columns-child-removal-expected.checksum:
  • platform/chromium-mac/fast/multicol/span/span-as-immediate-columns-child-removal-expected.png: Removed.
  • platform/chromium-mac/fast/multicol/span/span-as-immediate-columns-child-removal-expected.txt: Added.
  • platform/chromium-mac/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.checksum:
  • platform/chromium-mac/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png:
  • platform/chromium-mac/fast/multicol/span/span-as-nested-columns-child-expected.checksum:
  • platform/chromium-mac/fast/multicol/span/span-as-nested-columns-child-expected.png:
  • platform/chromium-mac/fast/multicol/span/span-as-nested-columns-child-expected.txt: Removed.
  • platform/chromium-mac/fast/multicol/table-margin-collapse-expected.checksum: Added.
  • platform/chromium-mac/fast/multicol/table-vertical-align-expected.checksum: Added.
  • platform/chromium-mac/fast/multicol/table-vertical-align-expected.png: Added.
  • platform/chromium-mac/fast/multicol/unsplittable-inline-block-expected.checksum: Added.
  • platform/chromium-mac/fast/repaint/multicol-repaint-expected.checksum:
  • platform/chromium-mac/fast/repaint/multicol-repaint-expected.png:
  • platform/chromium-win/fast/multicol/border-padding-pagination-expected.checksum: Added.
  • platform/chromium-win/fast/multicol/border-padding-pagination-expected.png: Added.
  • platform/chromium-win/fast/multicol/border-padding-pagination-expected.txt: Added.
  • platform/chromium-win/fast/multicol/client-rects-expected.checksum:
  • platform/chromium-win/fast/multicol/client-rects-expected.png:
  • platform/chromium-win/fast/multicol/client-rects-expected.txt:
  • platform/chromium-win/fast/multicol/column-break-with-balancing-expected.checksum: Added.
  • platform/chromium-win/fast/multicol/column-break-with-balancing-expected.png: Added.
  • platform/chromium-win/fast/multicol/column-break-with-balancing-expected.txt: Added.
  • platform/chromium-win/fast/multicol/column-count-with-rules-expected.checksum:
  • platform/chromium-win/fast/multicol/column-count-with-rules-expected.png:
  • platform/chromium-win/fast/multicol/column-rules-expected.checksum:
  • platform/chromium-win/fast/multicol/column-rules-expected.png:
  • platform/chromium-win/fast/multicol/column-rules-expected.txt:
  • platform/chromium-win/fast/multicol/float-avoidance-expected.checksum:
  • platform/chromium-win/fast/multicol/float-avoidance-expected.png:
  • platform/chromium-win/fast/multicol/float-avoidance-expected.txt:
  • platform/chromium-win/fast/multicol/float-multicol-expected.checksum:
  • platform/chromium-win/fast/multicol/float-multicol-expected.png:
  • platform/chromium-win/fast/multicol/float-multicol-expected.txt:
  • platform/chromium-win/fast/multicol/float-paginate-complex-expected.checksum: Added.
  • platform/chromium-win/fast/multicol/float-paginate-complex-expected.png: Added.
  • platform/chromium-win/fast/multicol/float-paginate-complex-expected.txt: Added.
  • platform/chromium-win/fast/multicol/float-paginate-expected.txt:
  • platform/chromium-win/fast/multicol/layers-in-multicol-expected.checksum:
  • platform/chromium-win/fast/multicol/layers-in-multicol-expected.png:
  • platform/chromium-win/fast/multicol/layers-in-multicol-expected.txt:
  • platform/chromium-win/fast/multicol/margin-collapse-expected.checksum: Added.
  • platform/chromium-win/fast/multicol/margin-collapse-expected.png: Added.
  • platform/chromium-win/fast/multicol/margin-collapse-expected.txt: Added.
  • platform/chromium-win/fast/multicol/max-height-columns-block-expected.checksum: Added.
  • platform/chromium-win/fast/multicol/max-height-columns-block-expected.png: Added.
  • platform/chromium-win/fast/multicol/max-height-columns-block-expected.txt: Added.
  • platform/chromium-win/fast/multicol/nested-columns-expected.checksum:
  • platform/chromium-win/fast/multicol/nested-columns-expected.png:
  • platform/chromium-win/fast/multicol/nested-columns-expected.txt:
  • platform/chromium-win/fast/multicol/paginate-block-replaced-expected.txt:
  • platform/chromium-win/fast/multicol/positioned-split-expected.checksum: Added.
  • platform/chromium-win/fast/multicol/positioned-split-expected.png: Added.
  • platform/chromium-win/fast/multicol/positioned-split-expected.txt: Added.
  • platform/chromium-win/fast/multicol/shadow-breaking-expected.checksum: Added.
  • platform/chromium-win/fast/multicol/shadow-breaking-expected.png: Added.
  • platform/chromium-win/fast/multicol/shadow-breaking-expected.txt: Added.
  • platform/chromium-win/fast/multicol/single-line-expected.checksum:
  • platform/chromium-win/fast/multicol/single-line-expected.png:
  • platform/chromium-win/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.checksum:
  • platform/chromium-win/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.png:
  • platform/chromium-win/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.txt:
  • platform/chromium-win/fast/multicol/span/span-as-immediate-child-generated-content-expected.checksum:
  • platform/chromium-win/fast/multicol/span/span-as-immediate-child-generated-content-expected.png:
  • platform/chromium-win/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt:
  • platform/chromium-win/fast/multicol/span/span-as-immediate-child-property-removal-expected.checksum:
  • platform/chromium-win/fast/multicol/span/span-as-immediate-child-property-removal-expected.png:
  • platform/chromium-win/fast/multicol/span/span-as-immediate-child-property-removal-expected.txt:
  • platform/chromium-win/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.txt:
  • platform/chromium-win/fast/multicol/span/span-as-immediate-columns-child-expected.txt:
  • platform/chromium-win/fast/multicol/span/span-as-immediate-columns-child-removal-expected.checksum:
  • platform/chromium-win/fast/multicol/span/span-as-immediate-columns-child-removal-expected.png:
  • platform/chromium-win/fast/multicol/span/span-as-immediate-columns-child-removal-expected.txt:
  • platform/chromium-win/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.checksum:
  • platform/chromium-win/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png:
  • platform/chromium-win/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.txt:
  • platform/chromium-win/fast/multicol/span/span-as-nested-columns-child-expected.checksum:
  • platform/chromium-win/fast/multicol/span/span-as-nested-columns-child-expected.png:
  • platform/chromium-win/fast/multicol/span/span-as-nested-columns-child-expected.txt:
  • platform/chromium-win/fast/multicol/table-margin-collapse-expected.checksum: Added.
  • platform/chromium-win/fast/multicol/table-margin-collapse-expected.png: Added.
  • platform/chromium-win/fast/multicol/table-margin-collapse-expected.txt: Added.
  • platform/chromium-win/fast/multicol/table-vertical-align-expected.checksum: Added.
  • platform/chromium-win/fast/multicol/table-vertical-align-expected.png: Added.
  • platform/chromium-win/fast/multicol/table-vertical-align-expected.txt: Added.
  • platform/chromium-win/fast/multicol/unsplittable-inline-block-expected.checksum: Added.
  • platform/chromium-win/fast/multicol/unsplittable-inline-block-expected.png: Added.
  • platform/chromium-win/fast/multicol/unsplittable-inline-block-expected.txt: Added.
  • platform/chromium-win/fast/repaint/multicol-repaint-expected.checksum:
  • platform/chromium-win/fast/repaint/multicol-repaint-expected.png:
  • platform/chromium-win/fast/repaint/multicol-repaint-expected.txt:
17:35 Changeset [67680] by bweinstein@apple.com
  • 3 edits in trunk/LayoutTests

Update Windows-specific results to getComputedStyle tests after r67667.

Rubber-stamped by Jon Honeycutt.

  • platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
16:34 Changeset [67679] by andreas.kling@nokia.com
  • 2 edits in trunk/WebCore

2010-09-16 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Ariya Hidayat.

[Qt] GraphicsContext: Remove unused variable

GraphicsContextPlatformPrivate::redirect wasn't used for anything.

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContextPlatformPrivate::p): (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
16:15 Changeset [67678] by tony@chromium.org
  • 3 edits
    1 add
    8 deletes in trunk/LayoutTests

2010-09-16 Tony Chang <tony@chromium.org>

Reviewed by Ojan Vafai.

convert fast/events/5056619.html to a dump-as-markup test
https://bugs.webkit.org/show_bug.cgi?id=45907

  • fast/events/5056619.html:
  • platform/chromium-linux/fast/events/5056619-expected.checksum: Removed.
  • platform/chromium-linux/fast/events/5056619-expected.png: Removed.
  • platform/chromium-win/fast/events/5056619-expected.checksum: Removed.
  • platform/chromium-win/fast/events/5056619-expected.png: Removed.
  • platform/chromium-win/fast/events/5056619-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
  • platform/mac/fast/events/5056619-expected.checksum: Removed.
  • platform/mac/fast/events/5056619-expected.png: Removed.
  • platform/mac/fast/events/5056619-expected.txt: Removed.
16:03 Changeset [67677] by kbr@google.com
  • 4 edits in trunk/WebKit/chromium

2010-09-16 Kenneth Russell <kbr@google.com>

Reviewed by James Robinson.

[chromium] Add needed entry points to WebGraphicsContext3D for compositor
https://bugs.webkit.org/show_bug.cgi?id=45921

  • public/WebGraphicsContext3D.h:
  • src/WebGraphicsContext3DDefaultImpl.cpp: (WebKit::WebGraphicsContext3DDefaultImpl::initialize): (WebKit::WebGraphicsContext3DDefaultImpl::supportsMapSubCHROMIUM): (WebKit::WebGraphicsContext3DDefaultImpl::mapBufferSubDataCHROMIUM): (WebKit::WebGraphicsContext3DDefaultImpl::unmapBufferSubDataCHROMIUM): (WebKit::WebGraphicsContext3DDefaultImpl::mapTexSubImage2DCHROMIUM): (WebKit::WebGraphicsContext3DDefaultImpl::unmapTexSubImage2DCHROMIUM): (WebKit::WebGraphicsContext3DDefaultImpl::supportsCopyTextureToParentTextureCHROMIUM): (WebKit::WebGraphicsContext3DDefaultImpl::copyTextureToParentTextureCHROMIUM):
  • src/WebGraphicsContext3DDefaultImpl.h:
15:45 Changeset [67676] by tony@chromium.org
  • 10 edits in trunk

2010-09-15 Tony Chang <tony@chromium.org>

Reviewed by Kent Tamura.

[Chromium] Needs DRT queueLoadHTMLString and setDeferMainResourceLoad-implementations
https://bugs.webkit.org/show_bug.cgi?id=42151

  • platform/chromium/test_expectations.txt:

2010-09-15 Tony Chang <tony@chromium.org>

Reviewed by Kent Tamura.

[Chromium] Needs DRT queueLoadHTMLString and setDeferMainResourceLoad-implementations
https://bugs.webkit.org/show_bug.cgi?id=42151

  • public/WebDataSource.h:
  • src/WebDataSourceImpl.cpp: (WebKit::WebDataSourceImpl::applicationCacheHost): (WebKit::WebDataSourceImpl::setDeferMainResourceDataLoad): Added so DRT can set this flag before a load.
  • src/WebDataSourceImpl.h:

2010-09-15 Tony Chang <tony@chromium.org>

Reviewed by Kent Tamura.

[Chromium] Needs DRT queueLoadHTMLString and setDeferMainResourceLoad-implementations
https://bugs.webkit.org/show_bug.cgi?id=42151

  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (WorkItemLoadHTMLString::WorkItemLoadHTMLString): (WorkItemLoadHTMLString::run): (LayoutTestController::queueLoadHTMLString): (LayoutTestController::reset): (LayoutTestController::setDeferMainResourceDataLoad):
  • DumpRenderTree/chromium/LayoutTestController.h: (LayoutTestController::deferMainResourceDataLoad):
  • DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::didCreateDataSource):
15:35 Changeset [67675] by andreas.kling@nokia.com
  • 2 edits in trunk/WebCore

2010-09-16 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Ariya Hidayat.

[Qt] Remove unnecessary QPainter::clipPath() call in TransparencyLayer()
https://bugs.webkit.org/show_bug.cgi?id=45923

QPainter::clipPath() can be very expensive, so use QPainter::hasClipping()
instead of QPainter::clipPath().isEmpty().

  • platform/graphics/qt/TransparencyLayer.h: (WebCore::TransparencyLayer::TransparencyLayer):
15:30 Changeset [67674] by barraclough@apple.com
  • 3 edits in trunk/SunSpider

https://bugs.webkit.org/show_bug.cgi?id=45924

Reviewed by Mark Rowe.

Modify the SunSpider harness to allow a path to be passed to the --suite
argument, supress the normal prepend-"tests/" behaviour for suite names
containing a '/'.

Also wrap the code in an anonymous function to move variables out of global
scope (currently the harness cannot handle running tests the overwrite the
variable 'j').

  • resources/sunspider-standalone-driver.js:
  • sunspider:
15:18 Changeset [67673] by hyatt@apple.com
  • 2 edits in trunk/WebCore

Fix for regression from my previous check-in. Make sure not to move the LayoutRepainter line
below the setHeight(0) call. This meant it snagged the wrong rectangle and we ended up repainting
the world.

Reviewed by Eric Seidel.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlock):

14:58 Changeset [67672] by zmo@google.com
  • 2 edits in trunk/LayoutTests

2010-09-16 Zhenyao Mo <zmo@google.com>

Unreviewed.

Remove passing WebGL tests from platform/chromium/test_expectations.txt
https://bugs.webkit.org/show_bug.cgi?id=45905

Remove passing tests; also, put webgl tests in one place.

  • platform/chromium/test_expectations.txt:
14:53 Changeset [67671] by hyatt@apple.com
  • 1 edit in trunk/WebCore/rendering/ColumnInfo.h

Fix Windows build. Yay for the style review bot telling me to do something that breaks Windows.

14:51 Changeset [67670] by eric@webkit.org
  • 2 edits
    1 add in trunk/LayoutTests

2010-09-16 Eric Seidel <eric@webkit.org>

Unreviewed. Just changing the path to the PNG file.

fast/css/font-face-svg-decoding-error.html can cause later CSS tests to fail
https://bugs.webkit.org/show_bug.cgi?id=45919

Fixing the underlying issue in a separate bug. For now
give this test its own png so to unblock the commit-queue.

  • fast/css/font-face-svg-decoding-error.html:
  • fast/css/resources/invalidfont.png: Copied from LayoutTests/fast/css-generated-content/resources/greenbox.png.
14:44 Changeset [67669] by commit-queue@webkit.org
  • 1 edit
    3 adds in trunk/WebKitTools

2010-09-16 Adrienne Walker <enne@google.com>

Reviewed by Kenneth Russell.

Add script to synchronize WebKit and Khronos WebGL tests
https://bugs.webkit.org/show_bug.cgi?id=42336

  • Scripts/update-webgl-conformance-tests: Added.
  • Scripts/webkitpy/layout_tests/update_webgl_conformance_tests.py: Added.
  • Scripts/webkitpy/layout_tests/update_webgl_conformance_tests_unittest.py: Added.
14:39 Changeset [67668] by mrobinson@webkit.org
  • 11 edits
    38 adds in trunk/LayoutTests

2010-09-16 Martin Robinson <mrobinson@igalia.com>

Update baselines for GTK+ and unskip a test which is passing.

  • platform/gtk/Skipped: Update baselines for GTK+.
  • platform/gtk/fast/css/percent-top-relative-container-height-unspecified-expected.txt: Added.
  • platform/gtk/fast/images/gif-large-checkerboard-expected.txt: Added.
  • platform/gtk/fast/multicol/border-padding-pagination-expected.txt: Added.
  • platform/gtk/fast/multicol/client-rects-expected.txt: Added.
  • platform/gtk/fast/multicol/column-break-with-balancing-expected.txt: Added.
  • platform/gtk/fast/multicol/column-rules-expected.txt: Added.
  • platform/gtk/fast/multicol/column-rules-stacking-expected.txt: Added.
  • platform/gtk/fast/multicol/columns-shorthand-parsing-expected.txt: Added.
  • platform/gtk/fast/multicol/float-avoidance-expected.txt: Added.
  • platform/gtk/fast/multicol/float-multicol-expected.txt: Added.
  • platform/gtk/fast/multicol/float-paginate-complex-expected.txt: Added.
  • platform/gtk/fast/multicol/float-paginate-expected.txt: Added.
  • platform/gtk/fast/multicol/layers-in-multicol-expected.txt:
  • platform/gtk/fast/multicol/margin-collapse-expected.txt: Added.
  • platform/gtk/fast/multicol/max-height-columns-block-expected.txt: Added.
  • platform/gtk/fast/multicol/nested-columns-expected.txt:
  • platform/gtk/fast/multicol/paginate-block-replaced-expected.txt: Added.
  • platform/gtk/fast/multicol/positioned-split-expected.txt: Added.
  • platform/gtk/fast/multicol/positioned-with-constrained-height-expected.txt: Added.
  • platform/gtk/fast/multicol/shadow-breaking-expected.txt: Added.
  • platform/gtk/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt:
  • platform/gtk/fast/multicol/span/span-as-immediate-child-property-removal-expected.txt:
  • platform/gtk/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.txt:
  • platform/gtk/fast/multicol/span/span-as-immediate-columns-child-expected.txt:
  • platform/gtk/fast/multicol/span/span-as-immediate-columns-child-removal-expected.txt:
  • platform/gtk/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.txt:
  • platform/gtk/fast/multicol/span/span-as-nested-columns-child-expected.txt:
  • platform/gtk/fast/multicol/table-margin-collapse-expected.txt: Added.
  • platform/gtk/fast/multicol/table-vertical-align-expected.txt: Added.
  • platform/gtk/fast/multicol/unsplittable-inline-block-expected.txt: Added.
  • platform/gtk/fast/repaint/block-layout-inline-children-float-positioned-expected.txt: Added.
  • platform/gtk/fast/repaint/block-layout-inline-children-replaced-expected.txt: Added.
  • platform/gtk/scrollbars/custom-scrollbar-with-incomplete-style-expected.txt: Added.
  • platform/gtk/svg/css/composite-shadow-with-opacity-expected.txt: Added.
  • platform/gtk/svg/css/shadow-changes-expected.txt: Added.
  • platform/gtk/svg/custom/getscreenctm-in-scrollable-div-area-expected.txt: Added.
  • platform/gtk/svg/custom/getscreenctm-in-scrollable-div-area-nested-expected.txt: Added.
  • platform/gtk/svg/custom/getscreenctm-in-scrollable-svg-area-expected.txt: Added.
  • platform/gtk/svg/custom/mouse-move-on-svg-container-expected.txt: Added.
  • platform/gtk/svg/custom/mouse-move-on-svg-container-standalone-expected.txt: Added.
  • platform/gtk/svg/custom/mouse-move-on-svg-root-expected.txt: Added.
  • platform/gtk/svg/custom/mouse-move-on-svg-root-standalone-expected.txt: Added.
  • platform/gtk/svg/custom/non-scaling-stroke-markers-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/non-scaling-stroke-markers-expected.txt.
  • platform/gtk/svg/custom/use-invalid-pattern-expected.txt: Copied from LayoutTests/platform/mac-snowleopard/svg/custom/use-invalid-pattern-expected.txt.
  • platform/gtk/svg/repaint/filter-repaint-expected.txt: Added.
  • platform/gtk/transitions/svg-text-shadow-transition-expected.txt: Added.
14:37 Changeset [67667] by hyatt@apple.com
  • 17 edits
    2 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=45020
Support "block-flow" and "writing-mode": interpret properties into RenderStyle

Patch by takano takumi <takano1@asia.apple.com> on 2010-09-16
Reviewed by Dave Hyatt.

Added code that interprets "block-flow" property and "writing-mode" property settings
into a RenderStyle object.

WebCore:

Test: fast/text/international/block-flow-parser-test.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator EBlockFlowDirection):

  • css/CSSPropertyNames.in:
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

  • css/CSSValueKeywords.in:
  • css/SVGCSSValueKeywords.in:
  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::diff):

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::setBitDefaults):
(WebCore::InheritedFlags::blockFlow):
(WebCore::InheritedFlags::setBlockFlow):
(WebCore::InheritedFlags::initialBlockFlow):

  • rendering/style/RenderStyleConstants.h:

LayoutTests:

  • fast/css/getComputedStyle/computed-style-expected.txt:
  • fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • fast/text/international/block-flow-parser-test-expected.txt: Added.
  • fast/text/international/block-flow-parser-test.html: Added.
  • svg/css/getComputedStyle-basic-expected.txt:
14:04 Changeset [67666] by weinig@apple.com
  • 15 edits in trunk

Add support for sending synchronous messages from the InjectedBundle to the WKContext
<rdar://problem/8365320>
https://bugs.webkit.org/show_bug.cgi?id=44785

Reviewed by Anders Carlsson.

WebKit2:

  • Shared/CoreIPCSupport/WebContextMessageKinds.h:
  • UIProcess/API/C/WKContext.h:
  • UIProcess/WebContext.cpp:

(WebKit::WebContext::didReceiveSynchronousMessageFromInjectedBundle):
(WebKit::WebContext::didReceiveMessage):
(WebKit::WebContext::didReceiveSyncMessage):

  • UIProcess/WebContext.h:
  • UIProcess/WebContextInjectedBundleClient.cpp:

(WebKit::WebContextInjectedBundleClient::didReceiveSynchronousMessageFromInjectedBundle):

  • UIProcess/WebContextInjectedBundleClient.h:
  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::didReceiveSyncMessage):

  • WebProcess/InjectedBundle/API/c/WKBundle.cpp:

(WKBundlePostSynchronousMessage):

  • WebProcess/InjectedBundle/API/c/WKBundle.h:
  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::postSynchronousMessage):

  • WebProcess/InjectedBundle/InjectedBundle.h:

WebKitTools:

  • MiniBrowser/mac/AppDelegate.m:

(didReceiveSynchronousMessageFromInjectedBundle):
(-[BrowserAppDelegate init]):

  • MiniBrowser/mac/WebBundle/WebBundleMain.m:

(didCreatePage):

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::initialize):

13:55 Changeset [67665] by kbr@google.com
  • 2 edits in trunk/WebKit/chromium

2010-09-16 Kenneth Russell <kbr@google.com>

Reviewed by James Robinson.

Roll forward Chromium DEPS to r59706
https://bugs.webkit.org/show_bug.cgi?id=45916

  • DEPS:
13:51 Changeset [67664] by mrobinson@webkit.org
  • 10 edits in trunk

2010-09-16 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Implement dissolveDragImageToFraction
https://bugs.webkit.org/show_bug.cgi?id=45826

  • wtf/gobject/GTypedefs.h: Added forward declarations for GtkWindow and GdkEventExpose.

2010-09-16 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Implement dissolveDragImageToFraction
https://bugs.webkit.org/show_bug.cgi?id=45826

Convert the drag image from a GdkPixbuf to a Cairo surface. Not only
might this allow code to be shared between Cairo ports it prevents a
full data copy when the image is not resized and makes the implementation
of dissolveDragImageToFraction more straight-forward.

This feature is covered by manual-tests/drag-image.html.

  • page/gtk/DragControllerGtk.cpp: (WebCore::DragController::maxDragImageSize): Make the maximum size of the drag image a little smaller.
  • platform/DragImage.h: Changed the drag image type to be a cairo_surface_t*.
  • platform/gtk/DragImageGtk.cpp: (WebCore::dragImageSize): Reimplemented to reflect new drag image type. (WebCore::deleteDragImage): Ditto. (WebCore::scaleDragImage): Ditto. (WebCore::dissolveDragImageToFraction): Filled the stub of this function. (WebCore::createDragImageFromImage): Reimplemented to reflect new drag image type.
  • platform/gtk/GtkVersioning.h: Added definition for gtk_widget_get_realized for older GTK+s.

2010-09-16 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Implement dissolveDragImageToFraction
https://bugs.webkit.org/show_bug.cgi?id=45826

To support full alpha in the drag icon, changed the drag icon to be a
GtkWindow with an RGBA colormap. Added logic to support painting the drag
image to this window during the expose event.

  • WebCoreSupport/DragClientGtk.cpp: (WebKit::dragIconWindowExposeEventCallback): Added. (WebKit::DragClient::DragClient): Initialize the new drag icon window. (WebKit::DragClient::~DragClient): Disconnect the expose event signal. (WebKit::DragClient::startDrag): Resize the drag icon window the appropriate size and if necessary, set its colormap. (WebKit::DragClient::dragIconWindowExposeEvent): Added.
  • WebCoreSupport/DragClientGtk.h: Added new member and method declarations.
13:42 Changeset [67663] by jianli@chromium.org
  • 2 edits in branches/chromium/517

Merge 67017 - Fix a problem in createCanonicalUUIDString that causes the last digit
missing on Linux.
https://bugs.webkit.org/show_bug.cgi?id=45412

BUG=45412
TEST=none

Reviewed by Darin Adler.

WebCore:

This is caused by not including the final null character into the count
that is provided to fgets.

This is covered by the existing test: send-form-data-with-sliced-file.html.

  • platform/UUID.cpp:

(WebCore::createCanonicalUUIDString):

LayoutTests:

Remove the test that is now passing on Linux for chromium.

  • platform/chromium/test_expectations.txt:

TBR=jianli@chromium.org
Review URL: http://codereview.chromium.org/3389014

13:31 Changeset [67662] by commit-queue@webkit.org
  • 2 edits in trunk/WebKitTools

2010-09-16 Leonid Ebril <leonid.ebril@nokia.com>

Reviewed by Andreas Kling.

[Qt] QtTestBrowser: Disable creation of a new window for screenshot on Symbian platform.
https://bugs.webkit.org/show_bug.cgi?id=45885

Avoid creation of an additional window for screenshot to prevent overlapping with original window.

  • QtTestBrowser/launcherwindow.cpp: (LauncherWindow::screenshot):
13:26 Changeset [67661] by jianli@chromium.org
  • 2 edits in branches/chromium/517

Merge 67646 - BlobData should be copied for it to be used cross-thread in ThreadableBlobRegistry.
https://bugs.webkit.org/show_bug.cgi?id=45909

BUG=55910
TEST=none

Reviewed by David Levin.

WebCore:

  • fileapi/ThreadableBlobRegistry.cpp:

(WebCore::BlobRegistryContext::BlobRegistryContext):

LayoutTests:

Also fix a test issue that we do not calculate the right position to move
mouse to on some platform.

  • fast/files/apply-blob-url-to-img.html:

TBR=jianli@chromium.org
Review URL: http://codereview.chromium.org/3449009

13:20 Changeset [67660] by hyatt@apple.com
  • 74 edits
    42 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=38402, paginate columns at layout time rather than at paint time.

Reviewed by Darin Adler.

WebCore:

This patch adds support for column breaking at layout time rather than at paint time. New variables have been
added to LayoutState and to ColumnInfo to track column information while laying out.

The basic idea behind this patch is to retain the columns' paint-time hackery of transforming one long vertical strip
into multiple columns. Now, however, layout is aware of the columns and will move objects up and down vertically in order
to ensure they don't intersect a break.

Many new tests added in fast/multicol and new results added for existing fast/multicol tests.

  • rendering/ColumnInfo.h:

(WebCore::ColumnInfo::ColumnInfo):
(WebCore::ColumnInfo::columnCount):
(WebCore::ColumnInfo::columnHeight):
(WebCore::ColumnInfo::setColumnCountAndHeight):
(WebCore::ColumnInfo::setColumnHeight):
(WebCore::ColumnInfo::updateMinimumColumnHeight):
(WebCore::ColumnInfo::minimumColumnHeight):
(WebCore::ColumnInfo::forcedBreaks):
(WebCore::ColumnInfo::forcedBreakOffset):
(WebCore::ColumnInfo::maximumDistanceBetweenForcedBreaks):
(WebCore::ColumnInfo::clearForcedBreaks):
(WebCore::ColumnInfo::addForcedBreak):

  • rendering/LayoutState.cpp:

(WebCore::LayoutState::LayoutState):
(WebCore::LayoutState::clearPaginationInformation):
(WebCore::LayoutState::pageY):
(WebCore::LayoutState::addForcedColumnBreak):

  • rendering/LayoutState.h:

(WebCore::LayoutState::LayoutState):
(WebCore::LayoutState::paginatingColumns):
(WebCore::LayoutState::paginated):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::RenderBlock):
(WebCore::RenderBlock::~RenderBlock):
(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::collapseMargins):
(WebCore::RenderBlock::estimateVerticalPosition):
(WebCore::RenderBlock::layoutBlockChild):
(WebCore::RenderBlock::layoutPositionedObjects):
(WebCore::RenderBlock::paintColumnRules):
(WebCore::RenderBlock::paintColumnContents):
(WebCore::RenderBlock::paintChildren):
(WebCore::RenderBlock::insertFloatingObject):
(WebCore::RenderBlock::removeFloatingObjects):
(WebCore::RenderBlock::positionNewFloats):
(WebCore::RenderBlock::positionNewFloatOnLine):
(WebCore::RenderBlock::lowestPosition):
(WebCore::RenderBlock::rightmostPosition):
(WebCore::RenderBlock::leftmostPosition):
(WebCore::RenderBlock::markAllDescendantsWithFloatsForLayout):
(WebCore::RenderBlock::markDescendantBlocksAndLinesForLayout):
(WebCore::RenderBlock::hitTestColumns):
(WebCore::RenderBlock::setDesiredColumnCountAndWidth):
(WebCore::RenderBlock::columnCount):
(WebCore::RenderBlock::columnRectAt):
(WebCore::RenderBlock::layoutColumns):
(WebCore::RenderBlock::adjustPointToColumnContents):
(WebCore::RenderBlock::adjustRectForColumns):
(WebCore::RenderBlock::adjustForColumns):
(WebCore::RenderBlock::setMaxTopMargins):
(WebCore::RenderBlock::setMaxBottomMargins):
(WebCore::RenderBlock::setPaginationStrut):
(WebCore::RenderBlock::setPageY):
(WebCore::RenderBlock::nextPageTop):
(WebCore::inNormalFlow):
(WebCore::RenderBlock::applyBeforeBreak):
(WebCore::RenderBlock::applyAfterBreak):
(WebCore::RenderBlock::adjustForUnsplittableChild):
(WebCore::RenderBlock::adjustLinePositionForPagination):

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::paginationStrut):
(WebCore::RenderBlock::pageY):
(WebCore::RenderBlock::maxTopPosMargin):
(WebCore::RenderBlock::maxTopNegMargin):
(WebCore::RenderBlock::maxBottomPosMargin):
(WebCore::RenderBlock::maxBottomNegMargin):
(WebCore::RenderBlock::initMaxMarginValues):
(WebCore::RenderBlock::FloatingObject::FloatingObject):
(WebCore::RenderBlock::FloatingObject::type):
(WebCore::RenderBlock::RenderBlockRareData::RenderBlockRareData):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::layoutInlineChildren):
(WebCore::RenderBlock::determineStartPosition):
(WebCore::RenderBlock::skipLeadingWhitespace):
(WebCore::RenderBlock::findNextLineBreak):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::mapLocalToContainer):
(WebCore::RenderBox::computeRectForRepaint):
(WebCore::RenderBox::markDescendantBlocksAndLinesForLayout):

  • rendering/RenderBox.h:
  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutBlock):
(WebCore::RenderFlexibleBox::layoutHorizontalBox):
(WebCore::RenderFlexibleBox::layoutVerticalBox):

  • rendering/RenderFlexibleBox.h:
  • rendering/RenderInline.cpp:

(WebCore::RenderInline::computeRectForRepaint):
(WebCore::RenderInline::mapLocalToContainer):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updatePagination):
(WebCore::RenderLayer::paintChildLayerIntoColumns):
(WebCore::RenderLayer::hitTestChildLayerColumns):

  • rendering/RenderLineBoxList.cpp:

(WebCore::RenderLineBoxList::paint):

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::RenderTable):
(WebCore::RenderTable::layout):

  • rendering/RenderTable.h:
  • rendering/RenderTableRow.cpp:

(WebCore::RenderTableRow::layout):

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::layoutRows):

  • rendering/RenderView.cpp:

(WebCore::RenderView::RenderView):
(WebCore::RenderView::pushLayoutState):

  • rendering/RenderView.h:

(WebCore::RenderView::setTruncatedAt):
(WebCore::RenderView::pushLayoutState):
(WebCore::RenderView::popLayoutState):
(WebCore::LayoutStateMaintainer::LayoutStateMaintainer):
(WebCore::LayoutStateMaintainer::push):

  • rendering/RootInlineBox.h:

(WebCore::RootInlineBox::RootInlineBox):
(WebCore::RootInlineBox::paginationStrut):
(WebCore::RootInlineBox::setPaginationStrut):

LayoutTests:

Add many new multicol layout tests that demonstrate new pagination features.

  • fast/multicol/border-padding-pagination.html: Added.
  • fast/multicol/client-rects-expected.checksum:
  • fast/multicol/client-rects-expected.png:
  • fast/multicol/client-rects-expected.txt:
  • fast/multicol/column-break-with-balancing.html: Added.
  • fast/multicol/float-paginate-complex.html: Added.
  • fast/multicol/float-paginate.html:
  • fast/multicol/float-truncation.html:
  • fast/multicol/margin-collapse.html: Added.
  • fast/multicol/max-height-columns-block.html: Added.
  • fast/multicol/positioned-split.html: Added.
  • fast/multicol/shadow-breaking.html: Added.
  • fast/multicol/single-line-expected.checksum:
  • fast/multicol/single-line-expected.png:
  • fast/multicol/table-margin-collapse.html: Added.
  • fast/multicol/table-vertical-align.html: Added.
  • fast/multicol/unsplittable-inline-block.html: Added.
  • platform/mac/fast/multicol/border-padding-pagination-expected.checksum: Added.
  • platform/mac/fast/multicol/border-padding-pagination-expected.png: Added.
  • platform/mac/fast/multicol/border-padding-pagination-expected.txt: Added.
  • platform/mac/fast/multicol/column-break-with-balancing-expected.checksum: Added.
  • platform/mac/fast/multicol/column-break-with-balancing-expected.png: Added.
  • platform/mac/fast/multicol/column-break-with-balancing-expected.txt: Added.
  • platform/mac/fast/multicol/column-count-with-rules-expected.checksum: Added.
  • platform/mac/fast/multicol/column-count-with-rules-expected.png: Added.
  • platform/mac/fast/multicol/column-count-with-rules-expected.txt:
  • platform/mac/fast/multicol/column-rules-expected.checksum:
  • platform/mac/fast/multicol/column-rules-expected.png:
  • platform/mac/fast/multicol/column-rules-expected.txt:
  • platform/mac/fast/multicol/column-rules-stacking-expected.checksum:
  • platform/mac/fast/multicol/column-rules-stacking-expected.png:
  • platform/mac/fast/multicol/columns-shorthand-parsing-expected.checksum:
  • platform/mac/fast/multicol/columns-shorthand-parsing-expected.png:
  • platform/mac/fast/multicol/float-avoidance-expected.checksum:
  • platform/mac/fast/multicol/float-avoidance-expected.png:
  • platform/mac/fast/multicol/float-avoidance-expected.txt:
  • platform/mac/fast/multicol/float-multicol-expected.checksum:
  • platform/mac/fast/multicol/float-multicol-expected.png:
  • platform/mac/fast/multicol/float-multicol-expected.txt:
  • platform/mac/fast/multicol/float-paginate-complex-expected.checksum: Added.
  • platform/mac/fast/multicol/float-paginate-complex-expected.png: Added.
  • platform/mac/fast/multicol/float-paginate-complex-expected.txt: Added.
  • platform/mac/fast/multicol/float-paginate-expected.txt:
  • platform/mac/fast/multicol/layers-in-multicol-expected.checksum:
  • platform/mac/fast/multicol/layers-in-multicol-expected.png:
  • platform/mac/fast/multicol/layers-in-multicol-expected.txt:
  • platform/mac/fast/multicol/margin-collapse-expected.checksum: Added.
  • platform/mac/fast/multicol/margin-collapse-expected.png: Added.
  • platform/mac/fast/multicol/margin-collapse-expected.txt: Added.
  • platform/mac/fast/multicol/max-height-columns-block-expected.checksum: Added.
  • platform/mac/fast/multicol/max-height-columns-block-expected.png: Added.
  • platform/mac/fast/multicol/max-height-columns-block-expected.txt: Added.
  • platform/mac/fast/multicol/nested-columns-expected.checksum:
  • platform/mac/fast/multicol/nested-columns-expected.png:
  • platform/mac/fast/multicol/nested-columns-expected.txt:
  • platform/mac/fast/multicol/paginate-block-replaced-expected.txt:
  • platform/mac/fast/multicol/positioned-split-expected.checksum: Added.
  • platform/mac/fast/multicol/positioned-split-expected.png: Added.
  • platform/mac/fast/multicol/positioned-split-expected.txt: Added.
  • platform/mac/fast/multicol/positioned-with-constrained-height-expected.checksum:
  • platform/mac/fast/multicol/positioned-with-constrained-height-expected.png:
  • platform/mac/fast/multicol/positioned-with-constrained-height-expected.txt:
  • platform/mac/fast/multicol/shadow-breaking-expected.checksum: Added.
  • platform/mac/fast/multicol/shadow-breaking-expected.png: Added.
  • platform/mac/fast/multicol/shadow-breaking-expected.txt: Added.
  • platform/mac/fast/multicol/span/span-as-immediate-child-generated-content-expected.checksum:
  • platform/mac/fast/multicol/span/span-as-immediate-child-generated-content-expected.png:
  • platform/mac/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt:
  • platform/mac/fast/multicol/span/span-as-immediate-child-property-removal-expected.checksum:
  • platform/mac/fast/multicol/span/span-as-immediate-child-property-removal-expected.png:
  • platform/mac/fast/multicol/span/span-as-immediate-child-property-removal-expected.txt:
  • platform/mac/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.checksum:
  • platform/mac/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.png:
  • platform/mac/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.txt:
  • platform/mac/fast/multicol/span/span-as-immediate-columns-child-expected.txt:
  • platform/mac/fast/multicol/span/span-as-immediate-columns-child-removal-expected.txt:
  • platform/mac/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.checksum:
  • platform/mac/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png:
  • platform/mac/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.txt:
  • platform/mac/fast/multicol/span/span-as-nested-columns-child-expected.checksum:
  • platform/mac/fast/multicol/span/span-as-nested-columns-child-expected.png:
  • platform/mac/fast/multicol/span/span-as-nested-columns-child-expected.txt:
  • platform/mac/fast/multicol/table-margin-collapse-expected.checksum: Added.
  • platform/mac/fast/multicol/table-margin-collapse-expected.png: Added.
  • platform/mac/fast/multicol/table-margin-collapse-expected.txt: Added.
  • platform/mac/fast/multicol/table-vertical-align-expected.checksum: Added.
  • platform/mac/fast/multicol/table-vertical-align-expected.png: Added.
  • platform/mac/fast/multicol/table-vertical-align-expected.txt: Added.
  • platform/mac/fast/multicol/unsplittable-inline-block-expected.checksum: Added.
  • platform/mac/fast/multicol/unsplittable-inline-block-expected.png: Added.
  • platform/mac/fast/multicol/unsplittable-inline-block-expected.txt: Added.
13:18 Changeset [67659] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-09-16 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Dimitri Glazkov.

Fix debug crash in HTMLFrameOwnerElement caused by content frame being used after destruction.
https://bugs.webkit.org/show_bug.cgi?id=45737

Test: fast/frames/frame-limit.html

  • html/HTMLFrameOwnerElement.cpp: (WebCore::HTMLFrameOwnerElement::willRemove):
13:15 Changeset [67658] by andersca@apple.com
  • 2 edits in trunk/WebKitTools

Fix clang++ build.

  • MiniBrowser/mac/BrowserWindowController.m:

(-[BrowserWindowController zoomIn:]):
(-[BrowserWindowController zoomOut:]):
(-[BrowserWindowController resetZoom:]):
Remove trailing semicolons.

13:05 Changeset [67657] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-09-16 Thomas Zander <t.zander@nokia.com>

Reviewed by Andreas Kling.

https://bugs.webkit.org/show_bug.cgi?id=45878

[Qt] Fixed incorrect Symbian scoping.

The missing install functionality is only true for mmp based systems.

  • WebCore.pro: limit functionality to mmp systems.
13:00 Changeset [67656] by andersca@apple.com
  • 2 edits in trunk/WebCore

Fix clang build.

  • page/animation/AnimationBase.h:

Fix struct/class mismatch.

12:48 Changeset [67655] by darin@apple.com
  • 4 edits in trunk/WebKit

Fix build.

WebKit/efl:

  • ewk/ewk_view.cpp:

(ewk_view_input_method_state_set): Updated for change
in name of isUrlField to isURLField.

WebKit/qt:

  • WebCoreSupport/EditorClientQt.cpp:

(WebCore::EditorClientQt::setInputMethodState): Updated for change
in name of isUrlField to isURLField.

12:44 Changeset [67654] by levin@chromium.org
  • 1 edit in branches/chromium/517/WebCore/page/chromium/FrameChromium.cpp

Merge 67645 - 2010-09-16 Daniel Cheng <dcheng@chromium.org>

Reviewed by Simon Fraser.

[chromium] Fix incorrect drag node/selection painting.
https://bugs.webkit.org/show_bug.cgi?id=45573

Drag selections were being incorrectly clipped when dragging a selection
near the bottom of a page that was taller than the viewport. To fix
this, we use paintContents() instead of paint().

  • page/chromium/FrameChromium.cpp: (WebCore::Frame::nodeImage): (WebCore::Frame::dragImageForSelection):

TBR=dcheng@chromium.org
Review URL: http://codereview.chromium.org/3422008

12:40 Changeset [67653] by darin@apple.com
  • 21 edits in trunk

2010-09-16 Darin Adler <darin@apple.com>

Reviewed by Andreas Kling.

Reduce use of HTMLInputElement::inputType so we can remove it later
https://bugs.webkit.org/show_bug.cgi?id=45903

  • src/DOMUtilitiesPrivate.cpp: (WebKit::elementHasLegalLinkAttribute): Use isImageButton.
  • src/WebPasswordFormUtils.cpp: (WebKit::findPasswordFormFields): Use isPasswordField.
  • src/WebSearchableFormData.cpp: (WebCore::IsInDefaultState): Use isCheckbox and isRadioButton. (WebCore::HasSuitableTextElement): Use isFileUpload and isPasswordField.

2010-09-16 Darin Adler <darin@apple.com>

Reviewed by Andreas Kling.

Reduce use of HTMLInputElement::inputType so we can remove it later
https://bugs.webkit.org/show_bug.cgi?id=45903

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::elementDoesAutoCompleteForElementWithId): Use isPasswordField.

2010-09-16 Darin Adler <darin@apple.com>

Reviewed by Andreas Kling.

Reduce use of HTMLInputElement::inputType so we can remove it later
https://bugs.webkit.org/show_bug.cgi?id=45903

  • WebFrame.cpp: (WebFrame::elementDoesAutoComplete): Use isPasswordField. (WebFrame::elementIsPassword): Use isPasswordField.

2010-09-16 Darin Adler <darin@apple.com>

Reviewed by Andreas Kling.

Reduce use of HTMLInputElement::inputType so we can remove it later
https://bugs.webkit.org/show_bug.cgi?id=45903

  • WebView/WebHTMLRepresentation.mm: (-[WebHTMLRepresentation elementDoesAutoComplete:]): Use isPasswordField. (-[WebHTMLRepresentation elementIsPassword:]): Use isPasswordField.

2010-09-16 Darin Adler <darin@apple.com>

Reviewed by Andreas Kling.

Reduce use of HTMLInputElement::inputType so we can remove it later
https://bugs.webkit.org/show_bug.cgi?id=45903

  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::isFileUploadButton): Use isFileUpload. (WebCore::AccessibilityRenderObject::isInputImage): Use isImageButton. (WebCore::AccessibilityRenderObject::determineAccessibilityRole): Use isCheckbox and isRadioButton.
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::adjustRenderStyle): Use isImageButton.
  • editing/Editor.cpp: (WebCore::Editor::setBaseWritingDirection): Use isTextField.
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): Use isPasswordField.
  • editing/SelectionController.cpp: (WebCore::SelectionController::isInPasswordField): Use isPasswordField.
  • html/HTMLInputElement.h: Added isFileUpload, isImageButton, and isSubmitButton.
  • page/Chrome.cpp: (WebCore::Chrome::setToolTip): Use isSubmitButton and isFileUpload.
  • page/DragController.cpp: (WebCore::asFileInput): Use isFileUpload.
  • page/EventHandler.cpp: (WebCore::isSubmitImage): Use isImageButton.
  • rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::updateFromElement): Use isFileUpload.
12:33 Changeset [67652] by darin@apple.com
  • 1 edit
    3 adds in trunk/LayoutTests

Mac results for recently-added test.

  • platform/mac/fast/images/gif-large-checkerboard-expected.checksum: Added.
  • platform/mac/fast/images/gif-large-checkerboard-expected.png: Added.
  • platform/mac/fast/images/gif-large-checkerboard-expected.txt: Added.
12:31 Changeset [67651] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-09-16 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: quick fix for crash in InspectorController::loadBreakpoints caused by empty main resource
https://bugs.webkit.org/show_bug.cgi?id=45901

  • inspector/InspectorController.cpp: (WebCore::InspectorController::breakpointsSettingKey):
12:31 Changeset [67650] by kbr@google.com
  • 3 edits
    1 add in trunk/WebKit/chromium

2010-09-16 Kenneth Russell <kbr@google.com>

Reviewed by James Robinson.

[chromium] Expose separate GraphicsContext3DInternal.h
https://bugs.webkit.org/show_bug.cgi?id=45914

  • WebKit.gyp:
  • src/GraphicsContext3D.cpp:
  • src/GraphicsContext3DInternal.h: Added.
12:26 Changeset [67649] by kbr@google.com
  • 4 edits in trunk/WebKit/chromium

2010-09-16 Kenneth Russell <kbr@google.com>

Reviewed by James Robinson.

[chromium] Add WebGraphicsContext3D accessor to WebView
https://bugs.webkit.org/show_bug.cgi?id=45913

  • public/WebView.h:
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::WebViewImpl): (WebKit::WebViewImpl::graphicsContext3D):
  • src/WebViewImpl.h:
12:17 Changeset [67648] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2010-09-16 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Prevent responseReceivedTime from being > endTime in case mixture of WebCore and Network stack info is used.
https://bugs.webkit.org/show_bug.cgi?id=45892

  • inspector/InspectorResource.cpp: (WebCore::InspectorResource::endTiming):
12:13 Changeset [67647] by loislo@chromium.org
  • 16 edits in trunk

2010-09-16 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: move resourceTracking flag under control of BackendSettings.

Four Inspector API methods about resourceTracking flag were removed.
Actual state of the flag is transfered as the response of setResourceTracking request.
Initial state of the flag on the frontend side is obtained from settings.backend.

https://bugs.webkit.org/show_bug.cgi?id=45887

WebCore:

  • inspector/Inspector.idl:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::getBackendSettings): (WebCore::InspectorController::populateScriptObjects): (WebCore::InspectorController::setResourceTracking):
  • inspector/InspectorController.h:
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype._toggleResourceTracking):
  • inspector/front-end/Settings.js: (WebInspector.Settings.initialize.populateBackendSettings): (WebInspector.Settings.initialize):
  • inspector/front-end/inspector.js:

WebKit/chromium:

  • src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::setRuntimeProperty): (WebKit::WebDevToolsAgentImpl::setApuAgentEnabled):

LayoutTests:

  • http/tests/inspector/inspector-test2.js: (initialize_InspectorTest.InspectorTest.enableResourceTracking): (initialize_InspectorTest.InspectorTest.disableResourceTracking):
  • http/tests/inspector/resource-parameters.html:
  • inspector/audits-panel-functional.html:
  • inspector/report-API-errors-expected.txt:
  • inspector/report-API-errors.html:
  • inspector/styles-source-offsets.html:
12:09 Changeset [67646] by jianli@chromium.org
  • 4 edits in trunk

BlobData should be copied for it to be used cross-thread in ThreadableBlobRegistry.
https://bugs.webkit.org/show_bug.cgi?id=45909

Reviewed by David Levin.

WebCore:

  • fileapi/ThreadableBlobRegistry.cpp:

(WebCore::BlobRegistryContext::BlobRegistryContext):

LayoutTests:

Also fix a test issue that we do not calculate the right position to move
mouse to on some platform.

  • fast/files/apply-blob-url-to-img.html:
12:05 Changeset [67645] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-09-16 Daniel Cheng <dcheng@chromium.org>

Reviewed by Simon Fraser.

[chromium] Fix incorrect drag node/selection painting.
https://bugs.webkit.org/show_bug.cgi?id=45573

Drag selections were being incorrectly clipped when dragging a selection
near the bottom of a page that was taller than the viewport. To fix
this, we use paintContents() instead of paint().

  • page/chromium/FrameChromium.cpp: (WebCore::Frame::nodeImage): (WebCore::Frame::dragImageForSelection):
11:55 Changeset [67644] by levin@chromium.org
  • 1 edit
    1 copy in branches/chromium/517/WebCore

Merge 67641 - 2010-09-16 Daniel Cheng <dcheng@chromium.org>

Reviewed by Tony Chang.

Fix incorrect usage of dissolveDragImageToFraction().
https://bugs.webkit.org/show_bug.cgi?id=45835

createDragImageForSelection() was ignoring the return value of
dissolveDragImageToFraction(). This didn't happen to crash on most
platforms, since most implementations simply modified the image that was
passed in. However, Chromium Mac's implementation actually creates a new
image and returns that instead. This caused us to crash when copying the
image from the renderer to the browser process, since the memory had
already been freed.

  • manual-tests/selection-drag-crash.html: Added.
  • platform/DragImage.cpp: (WebCore::createDragImageForSelection):

TBR=tony@chromium.org
Review URL: http://codereview.chromium.org/3452007

11:36 Changeset [67643] by zmo@google.com
  • 2 edits in trunk/LayoutTests

2010-09-16 Zhenyao Mo <zmo@google.com>

Unreviewed, TAG fix for two webgl tests in Linux/Win.

  • platform/chromium/test_expectations.txt:
11:19 Changeset [67642] by commit-queue@webkit.org
  • 5 edits in trunk

2010-09-16 Patrick Gansterer <paroga@paroga.com>

Reviewed by Darin Adler.

[Mac] Always use a valid string when setting WebKitUserStyleSheetLocationPreferenceKey.
https://bugs.webkit.org/show_bug.cgi?id=41510

  • platform/mac/fast/loader/user-stylesheet-fast-path-expected.txt:
  • platform/mac/fast/loader/user-stylesheet-fast-path.html:

2010-09-16 Patrick Gansterer <paroga@paroga.com>

Reviewed by Darin Adler.

Always use a valid string when setting WebKitUserStyleSheetLocationPreferenceKey.
https://bugs.webkit.org/show_bug.cgi?id=41510

This prevents usage of nil value, which would cause an uncaught exception.

  • WebView/WebPreferences.mm: (-[WebPreferences setUserStyleSheetLocation:]):
11:06 Changeset [67641] by commit-queue@webkit.org
  • 2 edits
    1 add in trunk/WebCore

2010-09-16 Daniel Cheng <dcheng@chromium.org>

Reviewed by Tony Chang.

Fix incorrect usage of dissolveDragImageToFraction().
https://bugs.webkit.org/show_bug.cgi?id=45835

createDragImageForSelection() was ignoring the return value of
dissolveDragImageToFraction(). This didn't happen to crash on most
platforms, since most implementations simply modified the image that was
passed in. However, Chromium Mac's implementation actually creates a new
image and returns that instead. This caused us to crash when copying the
image from the renderer to the browser process, since the memory had
already been freed.

  • manual-tests/selection-drag-crash.html: Added.
  • platform/DragImage.cpp: (WebCore::createDragImageForSelection):
10:59 Changeset [67640] by zmo@google.com
  • 2 edits in trunk/LayoutTests

2010-09-16 Zhenyao Mo <zmo@google.com>

Unreviewed, test TAG fix.

  • platform/chromium/test_expectations.txt: should be IMAGE+TEXT, not TEXT+IMAGE.
10:52 Changeset [67639] by mitz@apple.com
  • 5 edits in trunk/WebKit

Reverted the previous change because r67628 has been reverted.

WebKit:

  • English.lproj/Localizable.strings:

WebKit/mac:

  • WebCoreSupport/WebPlatformStrategies.h:
  • WebCoreSupport/WebPlatformStrategies.mm:
10:39 Changeset [67638] by mitz@apple.com
  • 5 edits in trunk/WebKit

WebKit: Updated localizable strings.

  • English.lproj/Localizable.strings:

WebKit/mac: Build fix after r67628. Added context menu item localizable strings for the items
added in r67628, following equivalent menu items in Mac OS X when possible. However,
this set of menu items does not make much sense for Mac OS X, and this should be
addressed separately.

  • WebCoreSupport/WebPlatformStrategies.h:
  • WebCoreSupport/WebPlatformStrategies.mm:

(WebPlatformStrategies::contextMenuItemTagOpenMediaInNewWindow):
(WebPlatformStrategies::contextMenuItemTagCopyMediaLinkToClipboard):
(WebPlatformStrategies::contextMenuItemTagToggleMediaControls):
(WebPlatformStrategies::contextMenuItemTagToggleMediaLoop):
(WebPlatformStrategies::contextMenuItemTagEnterVideoFullscreen):
(WebPlatformStrategies::contextMenuItemTagMediaPlay):
(WebPlatformStrategies::contextMenuItemTagMediaPause):
(WebPlatformStrategies::contextMenuItemTagMediaMute):
(WebPlatformStrategies::contextMenuItemTagMediaUnMute):

10:37 Changeset [67637] by kbalazs@webkit.org
  • 2 edits in trunk/WebKit2

2010-09-16 Balazs Kelemen <kbalazs@webkit.org>

Unreviewed trivial typo fix.

Remove old debug helper code inside |#if 0| from ConnectionQt.cpp

  • Platform/CoreIPC/qt/ConnectionQt.cpp: (CoreIPC::Connection::readyReadHandler):
10:33 Changeset [67636] by mrobinson@webkit.org
  • 2 edits
    1 add in trunk/LayoutTests

2010-09-16 Martin Robinson <mrobinson@igalia.com>

Unskip some tests that are now passing after libxml fixes in r66336.

  • platform/gtk/Skipped: Unskip passing tests.
  • platform/gtk/svg/custom/js-update-stop-linked-gradient-expected.txt: Added.
10:32 Changeset [67635] by commit-queue@webkit.org
  • 22 edits
    2 deletes in trunk

2010-09-16 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r67628.
http://trac.webkit.org/changeset/67628
https://bugs.webkit.org/show_bug.cgi?id=45904

broke the build (Requested by eric_carlson on #webkit).

  • media/context-menu-actions-expected.txt: Removed.
  • media/context-menu-actions.html: Removed.
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:

2010-09-16 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r67628.
http://trac.webkit.org/changeset/67628
https://bugs.webkit.org/show_bug.cgi?id=45904

broke the build (Requested by eric_carlson on #webkit).

  • page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected):
  • platform/ContextMenu.cpp: (WebCore::ContextMenu::populate): (WebCore::ContextMenu::checkOrEnableIfNeeded):
  • platform/ContextMenuItem.h:
  • platform/LocalizationStrategy.h:
  • platform/LocalizedStrings.cpp:
  • platform/LocalizedStrings.h:
  • platform/android/LocalizedStringsAndroid.cpp:
  • platform/brew/LocalizedStringsBrew.cpp:
  • platform/efl/LocalizedStringsEfl.cpp:
  • platform/gtk/ContextMenuItemGtk.cpp: (WebCore::gtkStockIDFromContextMenuAction):
  • platform/gtk/LocalizedStringsGtk.cpp:
  • platform/haiku/LocalizedStringsHaiku.cpp:
  • platform/wx/LocalizedStringsWx.cpp:
  • rendering/HitTestResult.cpp: (WebCore::HitTestResult::absoluteMediaURL):
  • rendering/HitTestResult.h:

2010-09-16 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r67628.
http://trac.webkit.org/changeset/67628
https://bugs.webkit.org/show_bug.cgi?id=45904

broke the build (Requested by eric_carlson on #webkit).

  • DumpRenderTree/gtk/EventSender.cpp: (contextClickCallback):
10:21 Changeset [67634] by andreas.kling@nokia.com
  • 2 edits in trunk/WebCore

2010-09-16 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Simon Fraser.

CSS: Fix crash in getTimingFunctionValue()
https://bugs.webkit.org/show_bug.cgi?id=45896

Use a RefPtr to avoid deleting the TimingFunction prematurely.

This is covered by existing tests, e.g transitions/inherit-other-props.html
but will only actually crash on picky platforms (or in valgrind.)

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::getTimingFunctionValue):
10:15 Changeset [67633] by zmo@google.com
  • 2 edits in trunk/LayoutTests

2010-09-16 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Turn on WebGL layout tests for Chromium win/linux
https://bugs.webkit.org/show_bug.cgi?id=45859

  • platform/chromium/test_expectations.txt: Re-enabling WebGL tests.
10:04 Changeset [67632] by johnnyg@google.com
  • 2 edits in trunk/LayoutTests

2010-09-16 John Gregg <johnnyg@google.com>

Unreviewed; chromium test expectations.

editing/selection/context-menu-on-text.html fails on chromium
https://bugs.webkit.org/show_bug.cgi?id=45898

  • platform/chromium/test_expectations.txt:
09:28 Changeset [67631] by enrica@apple.com
  • 8 edits in trunk/WebKit2

Pasteboard doesn't work in WebKit2.
https://bugs.webkit.org/show_bug.cgi?id=42317
<rdar://problem/7660537>

Reviewed by Sam Weinig.

Initial work to support cut, copy, paste and selectAll in WebKit2.
It still does not support RTF and RTFD format for Mac and the selective
enabling of the editing menu entries.

  • Shared/CoreIPCSupport/WebPageMessageKinds.h: Added messages to support the

new editing commands.

  • UIProcess/API/mac/WKView.mm:

(-[WKView validateUserInterfaceItem:]): Added.
(-[WKView copy:]): Added.
(-[WKView cut:]): Added.
(-[WKView paste:]): Addded.
(-[WKView selectAll:]): Added.

  • UIProcess/WebPageProxy.cpp: Added all the proxy methods.

(WebKit::WebPageProxy::selectAll):
(WebKit::WebPageProxy::copy):
(WebKit::WebPageProxy::cut):
(WebKit::WebPageProxy::paste):

  • UIProcess/WebPageProxy.h:
  • WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::WebEditorClient::documentFragmentFromAttributedString): Added but not
implemented. This is needed to support RTF and RTFD.
(WebKit::WebEditorClient::setInsertionPasteboard): Added but not implemented.
This is needed only to support Mail on the Mac.

  • WebProcess/WebPage/WebPage.cpp: Added all the stub methods.

(WebKit::WebPage::selectAll):
(WebKit::WebPage::copy):
(WebKit::WebPage::cut):
(WebKit::WebPage::paste):
(WebKit::WebPage::didReceiveMessage): Modified to handle the new messages from
the UI process.

  • WebProcess/WebPage/WebPage.h:
09:27 Changeset [67630] by kbalazs@webkit.org
  • 2 edits in trunk/WebKitTools

2010-09-16 Balazs Kelemen <kbalazs@webkit.org>

Unreviewed.

Adding myself as a comitter.

  • Scripts/webkitpy/common/config/committers.py:
09:24 Changeset [67629] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2010-09-16 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: prevent resource timing popover from having scrollers.
https://bugs.webkit.org/show_bug.cgi?id=45883

  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype._showPopover):
09:21 Changeset [67628] by philn@webkit.org
  • 22 edits
    2 adds in trunk

2010-09-15 Philippe Normand <pnormand@igalia.com>

Reviewed by Eric Carlson.

[GTK] enhanced context menu for media elements
https://bugs.webkit.org/show_bug.cgi?id=45021

New items in the media Element context menu:

  • play/pause
  • mute/unmute
  • controls display control
  • switch to fullscreen (for video only)
  • loop playback control
  • copy media url to clipboard
  • open in new window

Test: media/context-menu-actions.html

  • page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected):
  • platform/ContextMenu.cpp: (WebCore::ContextMenu::populate): (WebCore::ContextMenu::checkOrEnableIfNeeded):
  • platform/ContextMenuItem.h:
  • platform/LocalizationStrategy.h:
  • platform/LocalizedStrings.cpp: (WebCore::contextMenuItemTagOpenMediaInNewWindow): (WebCore::contextMenuItemTagCopyMediaLinkToClipboard): (WebCore::contextMenuItemTagToggleMediaControls): (WebCore::contextMenuItemTagToggleMediaLoop): (WebCore::contextMenuItemTagEnterVideoFullscreen): (WebCore::contextMenuItemTagMediaPlay): (WebCore::contextMenuItemTagMediaPause): (WebCore::contextMenuItemTagMediaMute): (WebCore::contextMenuItemTagMediaUnMute):
  • platform/LocalizedStrings.h:
  • platform/android/LocalizedStringsAndroid.cpp: (WebCore::contextMenuItemTagOpenMediaInNewWindow): (WebCore::contextMenuItemTagCopyMediaLinkToClipboard): (WebCore::contextMenuItemTagToggleMediaControls): (WebCore::contextMenuItemTagToggleMediaLoop): (WebCore::contextMenuItemTagEnterVideoFullscreen): (WebCore::contextMenuItemTagMediaPlay): (WebCore::contextMenuItemTagMediaPause): (WebCore::contextMenuItemTagMediaMute): (WebCore::contextMenuItemTagMediaUnMute):
  • platform/brew/LocalizedStringsBrew.cpp: (WebCore::contextMenuItemTagOpenMediaInNewWindow): (WebCore::contextMenuItemTagCopyMediaLinkToClipboard): (WebCore::contextMenuItemTagToggleMediaControls): (WebCore::contextMenuItemTagToggleMediaLoop): (WebCore::contextMenuItemTagEnterVideoFullscreen): (WebCore::contextMenuItemTagMediaPlay): (WebCore::contextMenuItemTagMediaPause): (WebCore::contextMenuItemTagMediaMute): (WebCore::contextMenuItemTagMediaUnMute):
  • platform/efl/LocalizedStringsEfl.cpp: (WebCore::contextMenuItemTagOpenMediaInNewWindow): (WebCore::contextMenuItemTagCopyMediaLinkToClipboard): (WebCore::contextMenuItemTagToggleMediaControls): (WebCore::contextMenuItemTagToggleMediaLoop): (WebCore::contextMenuItemTagEnterVideoFullscreen): (WebCore::contextMenuItemTagMediaPlay): (WebCore::contextMenuItemTagMediaPause): (WebCore::contextMenuItemTagMediaMute): (WebCore::contextMenuItemTagMediaUnMute):
  • platform/gtk/ContextMenuItemGtk.cpp: (WebCore::gtkStockIDFromContextMenuAction):
  • platform/gtk/LocalizedStringsGtk.cpp: (WebCore::contextMenuItemTagOpenMediaInNewWindow): (WebCore::contextMenuItemTagCopyMediaLinkToClipboard): (WebCore::contextMenuItemTagToggleMediaControls): (WebCore::contextMenuItemTagToggleMediaLoop): (WebCore::contextMenuItemTagEnterVideoFullscreen): (WebCore::contextMenuItemTagMediaPlay): (WebCore::contextMenuItemTagMediaPause): (WebCore::contextMenuItemTagMediaMute): (WebCore::contextMenuItemTagMediaUnMute):
  • platform/haiku/LocalizedStringsHaiku.cpp: (WebCore::contextMenuItemTagOpenMediaInNewWindow): (WebCore::contextMenuItemTagCopyMediaLinkToClipboard): (WebCore::contextMenuItemTagToggleMediaControls): (WebCore::contextMenuItemTagToggleMediaLoop): (WebCore::contextMenuItemTagEnterVideoFullscreen): (WebCore::contextMenuItemTagMediaPlay): (WebCore::contextMenuItemTagMediaPause): (WebCore::contextMenuItemTagMediaMute): (WebCore::contextMenuItemTagMediaUnMute):
  • platform/wx/LocalizedStringsWx.cpp: (WebCore::contextMenuItemTagOpenMediaInNewWindow): (WebCore::contextMenuItemTagCopyMediaLinkToClipboard): (WebCore::contextMenuItemTagToggleMediaControls): (WebCore::contextMenuItemTagToggleMediaLoop): (WebCore::contextMenuItemTagEnterVideoFullscreen): (WebCore::contextMenuItemTagMediaPlay): (WebCore::contextMenuItemTagMediaPause): (WebCore::contextMenuItemTagMediaMute): (WebCore::contextMenuItemTagMediaUnMute):
  • rendering/HitTestResult.cpp: (WebCore::HitTestResult::absoluteMediaURL): (WebCore::HitTestResult::mediaSupportsFullscreen): (WebCore::HitTestResult::mediaElement): (WebCore::HitTestResult::toggleMediaControlsDisplay): (WebCore::HitTestResult::toggleMediaLoopPlayback): (WebCore::HitTestResult::enterFullscreenForVideo): (WebCore::HitTestResult::mediaControlsEnabled): (WebCore::HitTestResult::mediaLoopEnabled): (WebCore::HitTestResult::mediaPlaying): (WebCore::HitTestResult::toggleMediaPlayState): (WebCore::HitTestResult::mediaHasAudio): (WebCore::HitTestResult::mediaMuted): (WebCore::HitTestResult::toggleMediaMuteState):
  • rendering/HitTestResult.h:

WebKitTools:

Reviewed by Eric Carlson.

[GTK] enhanced context menu for media elements
https://bugs.webkit.org/show_bug.cgi?id=45021

EventSender::contextClick() now returns an array of js
objects. Each object has a title property and a click() method.

  • DumpRenderTree/gtk/EventSender.cpp: (getMenuItemTitleCallback): (setMenuItemTitleCallback): (menuItemClickCallback): (getMenuItemClass): (contextClickCallback):

LayoutTests:

Reviewed by Eric Carlson.

[GTK] enhanced context menu for media elements
https://bugs.webkit.org/show_bug.cgi?id=45021

New test checking the actions that can be triggered by activating
the contex-menu of the media element. Skipped on mac, qt and win
because of lack of DRT support.

  • media/context-menu-actions-expected.txt: Added.
  • media/context-menu-actions.html: Added.
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
09:12 Changeset [67627] by tonyg@chromium.org
  • 3 edits
    2 adds in trunk

2010-09-16 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Adam Barth.

Crash in WebCore::FrameLoader::shouldInterruptLoadForXFrameOptions
https://bugs.webkit.org/show_bug.cgi?id=45833

  • fast/parser/x-frame-options-detached-document-crash-expected.txt: Added.
  • fast/parser/x-frame-options-detached-document-crash.html: Added. Crashes before this patch.

2010-09-16 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Adam Barth.

Crash in WebCore::FrameLoader::shouldInterruptLoadForXFrameOptions
https://bugs.webkit.org/show_bug.cgi?id=45833

Test: fast/parser/x-frame-options-detached-document-crash.html

  • dom/Document.cpp: (WebCore::Document::processHttpEquiv): Other branches in this method already test for a null frame. So it seems to make sense to test that here as well.
09:06 Changeset [67626] by philn@webkit.org
  • 8 edits
    2 adds in trunk

2010-09-14 Philippe Normand <pnormand@igalia.com>

Reviewed by Eric Carlson and Martin Robinson.

[GTK] eventSender.contextClick() should return the contents of the context menu
https://bugs.webkit.org/show_bug.cgi?id=39102

Make the eventSender use the new private WebKitGtk+ API to
retrieve the context-menu item titles and store them in an array.

  • DumpRenderTree/gtk/EventSender.cpp: (contextClickCallback):

WebKit/gtk:

Reviewed by Eric Carlson and Martin Robinson.

[GTK] eventSender.contextClick() should return the contents of the context menu
https://bugs.webkit.org/show_bug.cgi?id=39102

New private WebView API to retrieve the context-menu widget. This
is used by DRT only.

  • webkit/webkitprivate.h:
  • webkit/webkitwebview.cpp: (webkit_web_view_get_context_menu):

LayoutTests:

Reviewed by Eric Carlson and Martin Robinson.

[GTK] eventSender.contextClick() should return the contents of the context menu
https://bugs.webkit.org/show_bug.cgi?id=39102

New test checking the return value of eventSender.contextClick()
on a non-editable element. Skipped on qt and win.

  • editing/selection/context-menu-on-text-expected.txt: Added.
  • editing/selection/context-menu-on-text.html: Added.
  • platform/qt/Skipped:
  • platform/win/Skipped:
08:58 Changeset [67625] by vangelis@chromium.org
  • 4 edits in trunk/WebCore

2010-09-16 Vangelis Kokkevis <vangelis@chromium.org>

Reviewed by Darin Fisher.

[chromium] ImageLayerChromium needs to keep a ref to the Image it uses
so that it never tries to access an already destroyed Image.
https://bugs.webkit.org/show_bug.cgi?id=45869

  • platform/graphics/chromium/GraphicsLayerChromium.cpp: (WebCore::GraphicsLayerChromium::setContentsToImage):
  • platform/graphics/chromium/ImageLayerChromium.cpp: (WebCore::ImageLayerChromium::setContents): (WebCore::ImageLayerChromium::updateContents):
  • platform/graphics/chromium/ImageLayerChromium.h:
08:57 Changeset [67624] by paroga@webkit.org
  • 1 edit
    1 add in trunk/WebCore

2010-09-16 Patrick Gansterer <paroga@paroga.com>

Reviewed by Adam Roben.

[WINCE] Add platform-specific Image methods
https://bugs.webkit.org/show_bug.cgi?id=28272

  • platform/graphics/wince/ImageWinCE.cpp: Added. (WebCore::RGBA32Buffer::asNewNativeImage): (WebCore::FrameData::clear): (WebCore::BitmapImage::getHBITMAPOfSize): (WebCore::BitmapImage::drawFrameMatchingSourceSize): (WebCore::BitmapImage::draw): (WebCore::Image::drawPattern): (WebCore::BitmapImage::drawPattern): (WebCore::BitmapImage::checkForSolidColor):
08:37 Changeset [67623] by yurys@chromium.org
  • 6 edits in trunk

2010-09-16 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [REGRESSION] Scripts disappear from scripts panel after navigation
https://bugs.webkit.org/show_bug.cgi?id=45890

  • inspector/InspectorController.cpp: (WebCore::InspectorController::populateScriptObjects): (WebCore::InspectorController::restoreDebugger): (WebCore::InspectorController::restoreProfiler):
  • inspector/InspectorController.h:

2010-09-16 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [REGRESSION] Scripts disappear from scripts panel after navigation
https://bugs.webkit.org/show_bug.cgi?id=45890

  • src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::setRuntimeProperty): make sure debugger and profiler are initialized when inspected page navigation leads to renderer process change.
08:33 Changeset [67622] by satish@chromium.org
  • 2 edits in trunk/WebCore

2010-09-16 Satish Sampath <satish@chromium.org>

Unreviewed, fixing a build break with VS 2008.

Fix build break, add the namespace in a friend declaration to get MSVC recognize it properly.
https://bugs.webkit.org/show_bug.cgi?id=45893

  • fileapi/FileWriter.h:
08:30 Changeset [67621] by philn@webkit.org
  • 2 edits in trunk/WebCore

2010-09-15 Philippe Normand <pnormand@igalia.com>

Reviewed by Martin Robinson.

[GStreamer] XOverlay API changes break the build
https://bugs.webkit.org/show_bug.cgi?id=45810

Cope with the GStreamer XOverlay API change for the upcoming
0.10.31 version.
No new tests, build fix only.

  • platform/graphics/gstreamer/GStreamerGWorld.cpp: (WebCore::GStreamerGWorld::setWindowOverlay):
08:24 Changeset [67620] by commit-queue@webkit.org
  • 3 edits in trunk/WebKit/wince

2010-09-16 Patrick Gansterer <paroga@paroga.com>

Reviewed by Adam Roben.

[WINCE] Add missing FrameNetworkingContextWinCE::blockedError
https://bugs.webkit.org/show_bug.cgi?id=45680

  • WebCoreSupport/FrameNetworkingContextWinCE.cpp: (WebKit::FrameNetworkingContextWinCE::blockedError):
  • WebCoreSupport/FrameNetworkingContextWinCE.h:
08:17 Changeset [67619] by andreas.kling@nokia.com
  • 11 edits in trunk/WebCore

2010-09-16 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Tor Arne Vestbø.

[Qt] V8 port: Fix debug build

Add missing inclusion of <wtf/text/CString.h> where necessary for debug builds.

  • history/PageCache.cpp:
  • html/HTMLElement.cpp:
  • html/HTMLMediaElement.cpp:
  • loader/DocumentLoader.cpp:
  • loader/icon/IconDatabase.cpp:
  • loader/icon/IconLoader.cpp:
  • storage/AbstractDatabase.cpp:
  • storage/Database.cpp:
  • storage/DatabaseSync.cpp:
  • storage/DatabaseTracker.cpp:
08:05 Changeset [67618] by ap@apple.com
  • 4 edits
    2 adds in trunk

2010-09-16 Alexey Proskuryakov <ap@apple.com>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=45852
Range::selectNode and selectNodeContents misbehave when argument is in another document

  • fast/dom/Range/select-node-different-document-expected.txt: Added.
  • fast/dom/Range/select-node-different-document.html: Added.

2010-09-16 Alexey Proskuryakov <ap@apple.com>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=45852
Range::selectNode and selectNodeContents misbehave when argument is in another document

Test: fast/dom/Range/select-node-different-document.html

There is nothing in DOM Traversal spec that says this shouldn't work, and it does work in
Firefox.

  • dom/Range.cpp: (WebCore::Range::setDocument): (WebCore::Range::selectNode): (WebCore::Range::selectNodeContents):
  • dom/Range.h:
07:44 Changeset [67617] by satish@chromium.org
  • 1 edit
    1 move
    1 add in trunk/LayoutTests

2010-09-16 Satish Sampath <satish@chromium.org>

Unreviewed, build fix after checking in the wrong location.

Moving a test expectation which should have been under the chromium platform.

  • platform/chromium/fast/images/gif-large-checkerboard-expected.txt: Renamed from LayoutTests/fast/images/gif-large-checkerboard-expected.txt.
07:08 Changeset [67616] by satish@chromium.org
  • 1 edit
    7 adds in trunk/LayoutTests

2010-09-16 Satish Sampath <satish@chromium.org>

Reviewed by Jeremy Orlow.

Add chromium baselines for a recently added layout test.
https://bugs.webkit.org/show_bug.cgi?id=45886

  • fast/images/gif-large-checkerboard-expected.txt: Added.
  • platform/chromium-linux/fast/images/gif-large-checkerboard-expected.checksum: Added.
  • platform/chromium-linux/fast/images/gif-large-checkerboard-expected.png: Added.
  • platform/chromium-mac/fast/images/gif-large-checkerboard-expected.checksum: Added.
  • platform/chromium-mac/fast/images/gif-large-checkerboard-expected.png: Added.
  • platform/chromium-win/fast/images/gif-large-checkerboard-expected.checksum: Added.
  • platform/chromium-win/fast/images/gif-large-checkerboard-expected.png: Added.
06:56 Changeset [67615] by caseq@chromium.org
  • 6 edits in trunk/WebCore

2010-09-16 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Resources panel] [HAR] Need a way to save timing data.
Added support to export HAR to file from Resources panel (conditional on Preferences)
Added support for HARLog (a higher-level aggregate than HAREntry)
https://bugs.webkit.org/show_bug.cgi?id=45663

06:45 Changeset [67614] by commit-queue@webkit.org
  • 49 edits in trunk

2010-09-16 Eric Uhrhane <ericu@chromium.org>

Reviewed by Jian Li.

Unify FILE_SYSTEM and FILE_WRITER enables under the name FILE_SYSTEM.
https://bugs.webkit.org/show_bug.cgi?id=45798

  • configure.ac:

2010-09-16 Eric Uhrhane <ericu@chromium.org>

Reviewed by Jian Li.

Unify FILE_SYSTEM and FILE_WRITER enables under the name FILE_SYSTEM.
https://bugs.webkit.org/show_bug.cgi?id=45798

  • Configurations/FeatureDefines.xcconfig:

2010-09-16 Eric Uhrhane <ericu@chromium.org>

Reviewed by Jian Li.

Unify FILE_SYSTEM and FILE_WRITER enables under the name FILE_SYSTEM.
https://bugs.webkit.org/show_bug.cgi?id=45798

  • CMakeLists.txt:
  • Configurations/FeatureDefines.xcconfig:
  • GNUmakefile.am:
  • WebCore.pro:
  • dom/EventTarget.cpp:
  • dom/EventTarget.h:
  • dom/ExceptionCode.h:
  • dom/ScriptExecutionContext.cpp: (WebCore::ScriptExecutionContext::~ScriptExecutionContext):
  • dom/ScriptExecutionContext.h:
  • fileapi/AsyncFileWriter.h:
  • fileapi/FileEntry.cpp:
  • fileapi/FileEntry.h:
  • fileapi/FileEntry.idl:
  • fileapi/FileError.h:
  • fileapi/FileError.idl:
  • fileapi/FileException.h:
  • fileapi/FileException.idl:
  • fileapi/FileStreamProxy.cpp:
  • fileapi/FileStreamProxy.h:
  • fileapi/FileThread.cpp:
  • fileapi/FileThread.h:
  • fileapi/FileWriter.cpp:
  • fileapi/FileWriter.h:
  • fileapi/FileWriter.idl:
  • fileapi/FileWriterCallback.h:
  • fileapi/FileWriterCallback.idl:
  • fileapi/FileWriterClient.h:
  • page/DOMWindow.idl:
  • platform/AsyncFileStream.h:
  • platform/FileStream.cpp:
  • platform/FileStream.h:
  • platform/FileStreamClient.h:

2010-09-16 Eric Uhrhane <ericu@chromium.org>

Reviewed by Jian Li.

Unify FILE_SYSTEM and FILE_WRITER enables under the name FILE_SYSTEM.
https://bugs.webkit.org/show_bug.cgi?id=45798

  • src/AsyncFileWriterChromium.h:
  • src/AsyncFileWriterChromium.cpp:

2010-09-16 Eric Uhrhane <ericu@chromium.org>

Reviewed by Jian Li.

Unify FILE_SYSTEM and FILE_WRITER enables under the name FILE_SYSTEM.
https://bugs.webkit.org/show_bug.cgi?id=45798

  • Configurations/FeatureDefines.xcconfig:

2010-09-16 Eric Uhrhane <ericu@chromium.org>

Reviewed by Jian Li.

Unify FILE_SYSTEM and FILE_WRITER enables under the name FILE_SYSTEM.
https://bugs.webkit.org/show_bug.cgi?id=45798

  • Configurations/FeatureDefines.xcconfig:

2010-09-16 Eric Uhrhane <ericu@chromium.org>

Reviewed by Jian Li.

Unify FILE_SYSTEM and FILE_WRITER enables under the name FILE_SYSTEM.
https://bugs.webkit.org/show_bug.cgi?id=45798

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:

2010-09-16 Eric Uhrhane <ericu@chromium.org>

Reviewed by Jian Li.

Unify FILE_SYSTEM and FILE_WRITER enables under the name FILE_SYSTEM.
https://bugs.webkit.org/show_bug.cgi?id=45798

  • Scripts/build-webkit:
06:19 Changeset [67613] by satish@chromium.org
  • 1 edit
    1 move in trunk/LayoutTests

Rename an image file to all lower case matching how it is used in the layout test. The original patch and layout test is at https://bugs.webkit.org/show_bug.cgi?id=45322

06:15 Changeset [67612] by robert@webkit.org
  • 13 edits in trunk

2010-09-16 Robert Hogan <robert@webkit.org>

Reviewed by Antonio Gomes.

[Qt] Support globalhistory tests
https://bugs.webkit.org/show_bug.cgi?id=45774

  • platform/qt/Skipped:

2010-09-16 Robert Hogan <robert@webkit.org>

Reviewed by Antonio Gomes.

[Qt] Support globalhistory tests
https://bugs.webkit.org/show_bug.cgi?id=45774

  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::populateVisitedLinks):
  • WebCoreSupport/ChromeClientQt.h:
  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::dumpHistoryCallbacks): (DumpRenderTreeSupportQt::dumpVisitedLinksCallbacks):
  • WebCoreSupport/DumpRenderTreeSupportQt.h:
  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::setTitle): (WebCore::FrameLoaderClientQt::updateGlobalHistory): (WebCore::FrameLoaderClientQt::updateGlobalHistoryRedirectLinks):
  • WebCoreSupport/FrameLoaderClientQt.h:

2010-09-16 Robert Hogan <robert@webkit.org>

Reviewed by Antonio Gomes.

[Qt] Support globalhistory tests
https://bugs.webkit.org/show_bug.cgi?id=45774

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::isGlobalHistoryTest): (WebCore::DumpRenderTree::open):
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::reset): (LayoutTestController::dumpHistoryCallbacks): (LayoutTestController::removeAllVisitedLinks):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
06:03 Changeset [67611] by commit-queue@webkit.org
  • 3 edits in trunk/WebCore

2010-09-16 Marc-Antoine Ruel <maruel@chromium.org>

Reviewed by Dimitri Glazkov.

Convert WebCore.gyp to use regexp to excludes files instead of listing them in sources!.

This is necessary because sources! is processed before sources/. This makes
applying broader pattern in sources/ more difficult since it overrides the files
listed in sources!. Having all them in sources/ permits controlling the ordering
of the regexp, thus the final list of included files.

Fix Harfbuzz and VDMX source files includes in WebCore.gypi and WebCore.gyp

https://bugs.webkit.org/show_bug.cgi?id=45823

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
05:51 Changeset [67610] by commit-queue@webkit.org
  • 5 edits in trunk

2010-09-16 Nat Duca <nduca@chromium.org>

Reviewed by Darin Fisher.

[chromium] Make compositor obey finish flag
https://bugs.webkit.org/show_bug.cgi?id=45552

The compositor should obey the finish flag on doComposite. This
flag causes the compositor to finish rendering before returning,
which is needed when resizing the window to avoid flashes of green.

  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::finish):
  • platform/graphics/chromium/LayerRendererChromium.h:

2010-09-16 Nat Duca <nduca@chromium.org>

Reviewed by Darin Fisher.

[chromium] Make compositor obey finish flag
https://bugs.webkit.org/show_bug.cgi?id=45552

The compositor should obey the finish flag on doComposite. This
flag causes the compositor to finish rendering before returning,
which is needed when resizing the window to avoid flashes of green.

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::composite):
05:47 Changeset [67609] by alex@webkit.org
  • 5 edits in trunk

2010-09-16 Alejandro G. Castro <alex@igalia.com>

Reviewed by Xan Lopez.

GTK+ 3.x. updates, gtk_widget_size_request is deprecated and
"activate-slider" style property for scrollbars is gone.

  • platform/gtk/PopupMenuGtk.cpp: (WebCore::PopupMenuGtk::show):
  • platform/gtk/gtk2drawing.c: (moz_gtk_scrollbar_thumb_paint): (moz_gtk_combo_box_paint):

2010-09-16 Alejandro G. Castro <alex@igalia.com>

Reviewed by Xan Lopez.

GTK+ 3.x. updates, gtk_widget_size_request is deprecated and
"activate-slider" style property for scrollbars is gone.

  • webkit/webkitwebview.cpp: (PopupMenuPositionFunc):
05:38 Changeset [67608] by diegohcg@webkit.org
  • 8 edits in trunk

2010-09-16 Diego Gonzalez <diegohcg@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Remove FrameLoaderClientQt::webFrame() to use NetworkingContext to get the WebFrame to avoid layering violations
https://bugs.webkit.org/show_bug.cgi?id=42293

  • platform/graphics/qt/MediaPlayerPrivateQt.cpp: (WebCore::MediaPlayerPrivate::commitLoad):

2010-09-16 Diego Gonzalez <diegohcg@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Remove FrameLoaderClientQt::webFrame() to use NetworkingContext to get the WebFrame to avoid layering violations
https://bugs.webkit.org/show_bug.cgi?id=42293

  • Api/qwebframe.cpp: (QWebFrame::childFrames): (QWebFramePrivate::kit):
  • Api/qwebpage.cpp: (QWebPage::currentFrame):
  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::runJavaScriptAlert): (WebCore::ChromeClientQt::runJavaScriptConfirm): (WebCore::ChromeClientQt::runJavaScriptPrompt): (WebCore::ChromeClientQt::contentsSizeChanged):
  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::chooseFile):
  • WebCoreSupport/FrameLoaderClientQt.h:
05:07 Changeset [67607] by demarchi@webkit.org
  • 2 edits in trunk/WebCore

2010-09-16 Ryuan Choi <ryuan.choi@samsung.com>

Unreviewed build fix for EFL

[EFL] REGRESSION(67567) FontCacheCairo was removed
https://bugs.webkit.org/show_bug.cgi?id=45858

  • CMakeListsEfl.txt:
04:47 Changeset [67606] by commit-queue@webkit.org
  • 1 edit
    4 adds in trunk/WebCore

2010-09-16 Yong Li <yoli@rim.com>

Reviewed by George Staikos.

https://bugs.webkit.org/show_bug.cgi?id=37117

Add platform-independent JPEG/PNG image encoders that
work with big endian RGBA source data.

There's no layout test because this patch does't make
any port start using the encoders.

  • platform/image-encoders/JPEGImageEncoder.cpp: Added.
  • platform/image-encoders/JPEGImageEncoder.h: Added.
  • platform/image-encoders/PNGImageEncoder.cpp: Added.
  • platform/image-encoders/PNGImageEncoder.h: Added.
04:27 Changeset [67605] by jorlow@chromium.org
  • 11 edits in trunk

2010-09-15 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Steve Block.

Allow the embedder to specify the base path for IndexedDB.
https://bugs.webkit.org/show_bug.cgi?id=45815

Existing tests provide coverage. Use the indexedDBPath parameter that's
already on the group settings object. Pass this parameter into the backend
which will use it rather than a hard coded tmp directory location. If
nothing is specified, assume it should be an in-memory temporary database.
(This is useful for bringup and Chromium's incognito mode.)

  • storage/IDBFactory.cpp: (WebCore::IDBFactory::open):
  • storage/IDBFactoryBackendImpl.cpp: (WebCore::openSQLiteDatabase): (WebCore::createTables): (WebCore::IDBFactoryBackendImpl::open):
  • storage/IDBFactoryBackendImpl.h:
  • storage/IDBFactoryBackendInterface.h:

2010-09-15 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Steve Block.

Allow the embedder to specify the base path for IndexedDB.
https://bugs.webkit.org/show_bug.cgi?id=45815

Need to add the extra .open() parameter to make this all work.

  • public/WebIDBFactory.h: (WebKit::WebIDBFactory::open):
  • src/IDBFactoryBackendProxy.cpp: (WebCore::IDBFactoryBackendProxy::open):
  • src/IDBFactoryBackendProxy.h:
  • src/WebIDBFactoryImpl.cpp: (WebKit::WebIDBFactoryImpl::open):
  • src/WebIDBFactoryImpl.h:
04:16 Changeset [67604] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

2010-09-16 Yong Li <yoli@rim.com>

Reviewed by George Staikos.

Add a test for GIF down sampling.

GIF image down sampling can miss some lines
https://bugs.webkit.org/show_bug.cgi?id=45322

  • fast/images/gif-large-checkerboard.html: Added.
  • fast/images/resources/large-gif-checkerboard.GIF: Added.

2010-09-16 Yong Li <yoli@rim.com>

Reviewed by George Staikos.

Fix the bug that GIF image down sampling can miss some lines.
https://bugs.webkit.org/show_bug.cgi?id=45322

Test: fast/images/gif-large-checkerboard.html

  • platform/image-decoders/gif/GIFImageDecoder.cpp: (WebCore::GIFImageDecoder::haveDecodedRow):
04:13 Changeset [67603] by jorlow@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-09-16 Jeremy Orlow <jorlow@chromium.org>

Speculative build fix.

  • src/IDBIndexBackendProxy.cpp:
03:50 Changeset [67602] by philn@webkit.org
  • 2 edits in trunk/WebCore

2010-09-16 Philippe Normand <pnormand@igalia.com>

Reviewed by Andreas Kling.

[GStreamer] un-needed header includes in MediaPlayerPrivate
https://bugs.webkit.org/show_bug.cgi?id=45877

Include only the headers we need.
No new tests, #includes cleanup only.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
03:41 Changeset [67601] by pfeldman@chromium.org
  • 3 edits in trunk/WebCore

2010-09-16 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: console.group(object) does not allow object to be expanded.
https://bugs.webkit.org/show_bug.cgi?id=45806

  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleGroup.prototype.addMessage):
  • inspector/front-end/treeoutline.js: (TreeElement.treeElementToggled):
03:23 Changeset [67600] by jorlow@chromium.org
  • 34 edits
    4 adds in trunk

2010-09-08 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Steve Block.

Complete index support for IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=45386

  • storage/indexeddb/index-basics-expected.txt: Added.
  • storage/indexeddb/index-basics.html: Added.
  • storage/indexeddb/index-cursor-expected.txt: Added.
  • storage/indexeddb/index-cursor.html: Added.
  • storage/indexeddb/objectstore-basics-expected.txt:
  • storage/indexeddb/objectstore-basics.html:
  • storage/indexeddb/script-tests/objectstore-basics.js: Removed.

2010-09-08 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Steve Block.

Complete index support for IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=45386

Add the rest of the index related API for IndexedDB. This
includes cursor suport. A bunch of code was also refactored
since it is shared between indexes and objectStores.

Tests: storage/indexeddb/index-basics.html

storage/indexeddb/index-cursor.html
+ additions to others.

  • storage/IDBAny.cpp: (WebCore::IDBAny::set):
  • storage/IDBCursor.cpp: (WebCore::IDBCursor::value):
  • storage/IDBCursorBackendImpl.cpp: (WebCore::IDBCursorBackendImpl::IDBCursorBackendImpl): (WebCore::IDBCursorBackendImpl::value): (WebCore::IDBCursorBackendImpl::update): (WebCore::IDBCursorBackendImpl::continueFunction): (WebCore::IDBCursorBackendImpl::remove): (WebCore::IDBCursorBackendImpl::loadCurrentRow): (WebCore::IDBCursorBackendImpl::database):
  • storage/IDBCursorBackendImpl.h: (WebCore::IDBCursorBackendImpl::create):
  • storage/IDBCursorBackendInterface.h:
  • storage/IDBFactoryBackendImpl.cpp: (WebCore::createTables):
  • storage/IDBIndex.cpp: (WebCore::IDBIndex::openObjectCursor): (WebCore::IDBIndex::openCursor): (WebCore::IDBIndex::getObject): (WebCore::IDBIndex::get):
  • storage/IDBIndex.h: (WebCore::IDBIndex::storeName):
  • storage/IDBIndex.idl:
  • storage/IDBIndexBackendImpl.cpp: (WebCore::IDBIndexBackendImpl::storeName): (WebCore::openCursorInternal): (WebCore::IDBIndexBackendImpl::openObjectCursor): (WebCore::IDBIndexBackendImpl::openCursor): (WebCore::getInternal): (WebCore::IDBIndexBackendImpl::getObject): (WebCore::IDBIndexBackendImpl::get):
  • storage/IDBIndexBackendImpl.h: (WebCore::IDBIndexBackendImpl::objectStore):
  • storage/IDBIndexBackendInterface.h:
  • storage/IDBKey.cpp: (WebCore::IDBKey::fromQuery): (WebCore::IDBKey::whereSyntax): (WebCore::IDBKey::leftCursorWhereFragment): (WebCore::IDBKey::rightCursorWhereFragment):
  • storage/IDBKey.h:
  • storage/IDBKeyRange.cpp: (WebCore::IDBKeyRange::leftWhereClauseComparisonOperator): (WebCore::IDBKeyRange::rightWhereClauseComparisonOperator):
  • storage/IDBKeyRange.h:
  • storage/IDBObjectStoreBackendImpl.cpp: (WebCore::IDBObjectStoreBackendImpl::openCursor):
  • storage/IDBRequest.cpp: (WebCore::IDBRequest::timerFired):

2010-09-08 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Steve Block.

Complete index support for IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=45386

  • public/WebIDBCursor.h: (WebKit::WebIDBCursor::direction): (WebKit::WebIDBCursor::key): (WebKit::WebIDBCursor::value): (WebKit::WebIDBCursor::update): (WebKit::WebIDBCursor::continueFunction): (WebKit::WebIDBCursor::remove):
  • public/WebIDBIndex.h: (WebKit::WebIDBIndex::storeName): (WebKit::WebIDBIndex::openObjectCursor): (WebKit::WebIDBIndex::openCursor): (WebKit::WebIDBIndex::getObject): (WebKit::WebIDBIndex::get):
  • public/WebIDBKey.h:
  • src/IDBCursorBackendProxy.cpp: (WebCore::IDBCursorBackendProxy::value):
  • src/IDBCursorBackendProxy.h:
  • src/IDBIndexBackendProxy.cpp: (WebCore::IDBIndexBackendProxy::storeName): (WebCore::IDBIndexBackendProxy::openObjectCursor): (WebCore::IDBIndexBackendProxy::openCursor): (WebCore::IDBIndexBackendProxy::getObject): (WebCore::IDBIndexBackendProxy::get):
  • src/IDBIndexBackendProxy.h:
  • src/WebIDBCursorImpl.cpp: (WebKit::WebIDBCursorImpl::value):
  • src/WebIDBCursorImpl.h:
  • src/WebIDBIndexImpl.cpp: (WebKit::WebIDBIndexImpl::storeName): (WebKit::WebIDBIndexImpl::openCursor): (WebKit::WebIDBIndexImpl::openObjectCursor): (WebKit::WebIDBIndexImpl::getObject): (WebKit::WebIDBIndexImpl::get):
  • src/WebIDBIndexImpl.h:
02:07 Changeset [67599] by commit-queue@webkit.org
  • 1 edit in trunk/ChangeLog

2010-09-15 Commit Queue <commit-queue@webkit.org>

Unreviewed. Test commit for commit-queue@webkit.org.

Note: See TracTimeline for information about the timeline view.