Timeline



Sep 30, 2010:

11:41 PM Changeset in webkit [68866] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-09-30 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

The WebSocket server should flush its logs
https://bugs.webkit.org/show_bug.cgi?id=46946

The WebSocket server logs are truncated because the driver just
terminates the child. It should run Python without buffering so we can
see the end of the log.

  • Scripts/webkitpy/layout_tests/port/websocket_server.py:
10:58 PM Changeset in webkit [68865] by morrita@google.com
  • 6 edits in trunk

2010-09-30 MORITA Hajime <morrita@google.com>

Reviewed by James Robinson.

[Chromium] build fails unless ACCELERATED_2D_CANVAS defined
https://bugs.webkit.org/show_bug.cgi?id=46955

Added ifdef guard around SharedGraphicsContext3D.

No new tests. just a build fix.

  • platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::~PlatformContextSkia): (WebCore::PlatformContextSkia::setSharedGraphicsContext3D): (WebCore::PlatformContextSkia::uploadSoftwareToHardware): (WebCore::PlatformContextSkia::readbackHardwareToSoftware):
  • platform/graphics/skia/PlatformContextSkia.h: (WebCore::PlatformContextSkia::gpuCanvas):

2010-09-30 MORITA Hajime <morrita@google.com>

Reviewed by James Robinson.

[Chromium] build fails unless ACCELERATED_2D_CANVAS defined
https://bugs.webkit.org/show_bug.cgi?id=46955

Added ifdef guard around SharedGraphicsContext3D.

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::getSharedGraphicsContext3D):
  • src/WebViewImpl.h:
10:33 PM WebCoreRendering edited by luxtella@company100.net
(diff)
10:09 PM Changeset in webkit [68864] by tkent@chromium.org
  • 3 edits in trunk/WebCore

2010-09-30 Kent Tamura <tkent@chromium.org>

Reviewed by Chris Fleizach.

[Windows] Implement <input type=number> UI
https://bugs.webkit.org/show_bug.cgi?id=38381

Implement theme drawing for inner-spin-button.
No new tests. Existing tests for type=number will cover this change.

  • rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::RenderThemeWin): Handle m_spinButtonTheme. (WebCore::RenderThemeWin::spinButtonTheme): ditto. (WebCore::RenderThemeWin::close): ditto. (WebCore::RenderThemeWin::determineClassicState): Add ControlSubPart parameter, and add support for InnerSpinButtonPart. (WebCore::RenderThemeWin::determineSpinButtonState): Added. (WebCore::RenderThemeWin::getClassicThemeData): Add ControlSubPart parameter, and handle InnerSpinButtonPart. (WebCore::RenderThemeWin::getThemeData): ditto. (WebCore::RenderThemeWin::adjustInnerSpinButtonStyle): Set SM_CXVSCROLL value to the width. (WebCore::RenderThemeWin::paintInnerSpinButton): Call drawControl() for the upper part and the lower part.
  • rendering/RenderThemeWin.h:
10:05 PM Changeset in webkit [68863] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

2010-09-30 Kent Tamura <tkent@chromium.org>

Unreviewed, test expectation update.

  • platform/chromium/drt_expectations.txt: Add recent failures.
9:51 PM Changeset in webkit [68862] by tkent@chromium.org
  • 2 edits in trunk/WebCore

Unreviewed, Windows build fix for r68854

  • WebCore.vcproj/copyForwardingHeaders.cmd: Copy WebCore/html/parser/*.h.
8:55 PM Changeset in webkit [68861] by Simon Fraser
  • 4 edits in trunk/WebKitTools

2010-09-30 Simon Fraser <Simon Fraser>

Add a button to jump to the next untested test.

  • CSSTestSuiteHarness/harness/harness.css: (.test-type): (.name > button):
  • CSSTestSuiteHarness/harness/harness.html:
  • CSSTestSuiteHarness/harness/harness.js: (Chapter.prototype.description): (Chapter.prototype.untestedCount): (TestSuite.prototype.testInfoDataLoaded): (TestSuite.prototype.fillChapterPopup): (TestSuite.prototype.updateChapterPopup): (TestSuite.prototype.buildTestListForChapter): (TestSuite.prototype.goToNextIncompleteTest): (TestSuite.prototype.firstIncompleteTestIndex): (TestSuite.prototype.testCompletionStateChanged):
8:25 PM Changeset in webkit [68860] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

2010-09-30 Abhishek Arya <inferno@chromium.org>

Reviewed by Dan Bernstein.

While updating :before and :after content, make sure that the generated
container is allowed to add the child type.
https://bugs.webkit.org/show_bug.cgi?id=46106

Test: fast/css-generated-content/text-before-table-col-crash.html

  • rendering/RenderObjectChildList.cpp: (WebCore::RenderObjectChildList::updateBeforeAfterContent):

2010-09-30 Abhishek Arya <inferno@chromium.org>

Reviewed by Dan Bernstein.

Tests that adding text to a :before container that is styled as a
table column group does not result in crash.
https://bugs.webkit.org/show_bug.cgi?id=46106

  • fast/css-generated-content/text-before-table-col-crash-expected.txt: Added.
  • fast/css-generated-content/text-before-table-col-crash.html: Added.
6:35 PM Changeset in webkit [68859] by hclam@chromium.org
  • 2 edits
    41 adds in trunk/LayoutTests

Not reviewed. Build fix.

Adjust test expectations for Chromium.

  • platform/chromium-linux/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-location-htmldom-expected.txt: Added.
  • platform/chromium-linux/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-getAttribute-value-expected.txt: Added.
  • platform/chromium-linux/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-htmldom-expected.txt: Added.
  • platform/chromium-linux/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttribute-expected.txt: Added.
  • platform/chromium-linux/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNS-expected.txt: Added.
  • platform/chromium-linux/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNode-expected.txt: Added.
  • platform/chromium-linux/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNodeNS-expected.txt: Added.
  • platform/chromium-linux/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-getAttribute-value-expected.txt: Added.
  • platform/chromium-linux/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-htmldom-expected.txt: Added.
  • platform/chromium-linux/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttribute-expected.txt: Added.
  • platform/chromium-linux/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNS-expected.txt: Added.
  • platform/chromium-linux/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNode-expected.txt: Added.
  • platform/chromium-linux/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNodeNS-expected.txt: Added.
  • platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-location-htmldom-expected.txt: Added.
  • platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-getAttribute-value-expected.txt: Added.
  • platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-htmldom-expected.txt: Added.
  • platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttribute-expected.txt: Added.
  • platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNS-expected.txt: Added.
  • platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNode-expected.txt: Added.
  • platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNodeNS-expected.txt: Added.
  • platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-getAttribute-value-expected.txt: Added.
  • platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-htmldom-expected.txt: Added.
  • platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttribute-expected.txt: Added.
  • platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNS-expected.txt: Added.
  • platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNode-expected.txt: Added.
  • platform/chromium-mac/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNodeNS-expected.txt: Added.
  • platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-location-htmldom-expected.txt: Added.
  • platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-getAttribute-value-expected.txt: Added.
  • platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-htmldom-expected.txt: Added.
  • platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttribute-expected.txt: Added.
  • platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNS-expected.txt: Added.
  • platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNode-expected.txt: Added.
  • platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNodeNS-expected.txt: Added.
  • platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-getAttribute-value-expected.txt: Added.
  • platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-htmldom-expected.txt: Added.
  • platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttribute-expected.txt: Added.
  • platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNS-expected.txt: Added.
  • platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNode-expected.txt: Added.
  • platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNodeNS-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
6:24 PM Changeset in webkit [68858] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-09-30 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Daniel Bates.

[GTK] Crash on testatk.c unittest because of a call to ASSERT_NOT_REACHED
https://bugs.webkit.org/show_bug.cgi?id=46886

Removed call to ASSERT_NOT_REACHED() from listMarkerSuffix().

So far, this assertion made sense because it was not possible that
a call to listMarkerSuffix() happened when the style of the list
item was one of the following: Asterisks, Circle, Discm Footnotes,
NoneListStyle or Square (it's easy to figure this out by checking
the functions where listMarkerSuffix() was called).

However, since revision 68415 (about bug 45381), there's a new
place where listMarkerSuffix() is being called (the suffix()
public method), regardless of the style of the item being or not
one of those pointed out, so the aforementioned assertion in
listMarkerSuffix() would no longer be correct, as now it's ok to
reach those cases in the switch statement.

  • rendering/RenderListMarker.cpp: (WebCore::listMarkerSuffix): Removed call to ASSERT_NOT_REACHED().
6:22 PM Changeset in webkit [68857] by mrowe@apple.com
  • 5 edits in branches/safari-533.19-branch

Build fixes.

6:13 PM Changeset in webkit [68856] by Beth Dakin
  • 3 edits
    2 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=46948 Crash with all-
whitespace separators for mfenced

Reviewed by Adele Peterson.

WebCore:

Check the size of characters instead of separators in case all the
separators were whitespace.

  • mathml/RenderMathMLFenced.cpp:

(WebCore::RenderMathMLFenced::updateFromElement):

LayoutTests:

  • mathml/fenced-whitespace-separators-crash-expected.txt: Added.
  • mathml/fenced-whitespace-separators-crash.html: Added.
5:39 PM Changeset in webkit [68855] by Simon Fraser
  • 4 edits in trunk/LayoutTests

2010-09-30 Simon Fraser <Simon Fraser>

Reviewed by Jon Honeycutt.

REGRESSION (r65681): Crash in AccessibilityUIElement::addSelection when running platform/win/accessibility/selection-and-focus.html
https://bugs.webkit.org/show_bug.cgi?id=46913

REGRESSION (r65681): platform/win/accessibility/img-alt-attribute.html failing on Windows
https://bugs.webkit.org/show_bug.cgi?id=46914

<rdar://problem/8497332&8497393>

Fix two layout tests that made incorrect assumptions about the structure of the
accessibility tree.

  • platform/win/Skipped:
  • platform/win/accessibility/img-alt-attribute.html:
  • platform/win/accessibility/selection-and-focus.html:
5:04 PM Changeset in webkit [68854] by Darin Adler
  • 75 edits
    2 moves
    1 delete in trunk

2010-09-30 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

Remove remaining calls to deprecatedParseURL
https://bugs.webkit.org/show_bug.cgi?id=26599

  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::dispatchDidFailToStartPlugin): Call stripLeadingAndTrailingHTMLSpaces instead of deprecatedParseURL.

2010-09-30 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

Remove remaining calls to deprecatedParseURL
https://bugs.webkit.org/show_bug.cgi?id=26599

  • DOM/WebDOMOperations.mm: (-[DOMDocument URLWithAttributeString:]):
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::createPlugin): Call stripLeadingAndTrailingHTMLSpaces instead of deprecatedParseURL.

2010-09-30 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

Remove remaining calls to deprecatedParseURL
https://bugs.webkit.org/show_bug.cgi?id=26599

Test: fast/replaced/object-param-spaces.html

  • css/CSSHelper.cpp: Removed.
  • css/CSSHelper.h: Removed deprecatedParseURL.
  • html/parser/HTMLParserIdioms.cpp: (WebCore::stripLeadingAndTrailingHTMLSpaces): Fixed bug where the function would turn the null string into the empty string. Fixed bug where the function would not strip all trailing spaces.
  • html/parser/CSSPreloadScanner.cpp: (WebCore::CSSPreloadScanner::CSSPreloadScanner): Initialize m_state instead of calling the reset function. (WebCore::CSSPreloadScanner::scan): Tweaked coding style. (WebCore::CSSPreloadScanner::tokenize): Use isHTMLSpace instead of an identical local function named isWhitespace. (WebCore::parseCSSStringOrURL): Added. This function does what deprecatedParseURL did before, and this is the only place in WebKit that needs it. The code implements the rules for a string or URL token. The real CSS parser does this with flex and the code to hook flex up to yacc, so the function is not needed there. (WebCore::CSSPreloadScanner::emitRule): Streamlined the code a bit and mae it call parseCSSStringOrURL.
  • bindings/generic/BindingSecurity.h: (WebCore::::allowSettingFrameSrcToJavascriptUrl):
  • bindings/js/JSDOMBinding.cpp: (WebCore::allowSettingSrcToJavascriptURL):
  • bindings/js/JSHTMLFrameElementCustom.cpp: (WebCore::allowSettingJavascriptURL):
  • bindings/objc/DOM.mm: (-[DOMElement _getURLAttribute:]):
  • bindings/objc/DOMHTML.mm: (-[DOMHTMLDocument _createDocumentFragmentWithMarkupString:baseURLString:]):
  • dom/Document.cpp: (WebCore::Document::processBaseElement):
  • dom/Element.cpp: (WebCore::isAttributeToRemove): (WebCore::Element::getURLAttribute): (WebCore::Element::getNonEmptyURLAttribute):
  • html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::defaultEventHandler): (WebCore::HTMLAnchorElement::parseMappedAttribute): (WebCore::HTMLAnchorElement::href):
  • html/HTMLBodyElement.cpp: (WebCore::HTMLBodyElement::parseMappedAttribute):
  • html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::parseMappedAttribute):
  • html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::parseMappedAttribute):
  • html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::parseMappedAttribute):
  • html/HTMLImageLoader.cpp: (WebCore::HTMLImageLoader::sourceURI):
  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::parseMappedAttribute):
  • html/HTMLMediaElement.cpp:
  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::parseMappedAttribute): (WebCore::HTMLObjectElement::parametersForPlugin):
  • html/HTMLTableElement.cpp: (WebCore::HTMLTableElement::parseMappedAttribute):
  • html/HTMLTablePartElement.cpp: (WebCore::HTMLTablePartElement::parseMappedAttribute):
  • html/parser/HTMLPreloadScanner.cpp: (WebCore::HTMLNames::PreloadTask::setUrlToLoad):
  • loader/FormSubmission.cpp: (WebCore::FormSubmission::Attributes::parseAction):
  • platform/chromium/ClipboardChromium.cpp: (WebCore::ClipboardChromium::declareAndWriteDragImage):
  • platform/chromium/PasteboardChromium.cpp: (WebCore::Pasteboard::writeImage):
  • platform/qt/ClipboardQt.cpp: (WebCore::ClipboardQt::declareAndWriteDragImage):
  • platform/win/ClipboardWin.cpp: (WebCore::ClipboardWin::declareAndWriteDragImage):
  • rendering/HitTestResult.cpp: (WebCore::HitTestResult::absoluteImageURL): (WebCore::HitTestResult::absoluteMediaURL): (WebCore::HitTestResult::absoluteLinkURL):
  • svg/SVGAElement.cpp: (WebCore::SVGAElement::defaultEventHandler):
  • svg/SVGImageLoader.cpp: (WebCore::SVGImageLoader::sourceURI):
  • wml/WMLAElement.cpp: (WebCore::WMLAElement::defaultEventHandler):
  • wml/WMLImageLoader.cpp: (WebCore::WMLImageLoader::sourceURI): Call stripLeadingAndTrailingHTMLSpaces instead of deprecatedParseURL.
  • WebCore.exp.in: Updated.
  • Android.mk: Removed CSSHelper.cpp.
  • CMakeLists.txt: Ditto.
  • GNUmakefile.am: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • bindings/js/JSAttrCustom.cpp:
  • bindings/js/JSElementCustom.cpp:
  • bindings/v8/custom/V8ElementCustom.cpp:
  • bindings/v8/custom/V8LocationCustom.cpp:
  • css/CSSParser.cpp:
  • html/HTMLMediaElement.cpp:
  • html/HTMLVideoElement.cpp:
  • loader/ImageLoader.cpp:
  • rendering/style/RenderStyle.h: Removed unneeded include of CSSHelper.h.

2010-09-30 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

Remove remaining calls to deprecatedParseURL
https://bugs.webkit.org/show_bug.cgi?id=26599

  • fast/replaced/object-param-spaces-expected.txt: Copied from LayoutTests/fast/replaced/object-param-url-control-char-expected.txt.
  • fast/replaced/object-param-spaces.html: Copied from LayoutTests/fast/replaced/object-param-url-control-char.html.
  • fast/replaced/object-param-url-control-char-expected.txt: Removed.
  • fast/replaced/object-param-url-control-char.html: Removed. Changed this test to expect HTML standard space trimming, but not the WebKit-only control character stripping we had historically.
  • fast/url/query-expected.txt: Updated to expect the test to pass.
  • fast/url/script-tests/segments-from-data-url.js: Changed expected result to not expect stripping of newline characters.
  • fast/url/script-tests/segments.js: Ditto.
  • fast/url/segments-expected.txt: Updated results.
  • fast/url/segments-from-data-url-expected.txt: Ditto.
  • http/tests/security/javascriptURL/javascriptURL-execution-context-frame-location-htmldom-expected.txt:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-getAttribute-value-expected.txt:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-htmldom-expected.txt:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttribute-expected.txt:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNS-expected.txt:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNode-expected.txt:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNodeNS-expected.txt:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-getAttribute-value-expected.txt:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-htmldom-expected.txt:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttribute-expected.txt:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNS-expected.txt:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNode-expected.txt:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNodeNS-expected.txt: These tests had multiple test cases with embedded control characters. These URLs no longer qualify as javascript URLs, so there are no longer any unsafe JavaScript log messages for them. The test cases themselves need not be changed at this time.
  • http/tests/security/xssAuditor/embed-tag-control-char-expected.txt:
  • http/tests/security/xssAuditor/object-embed-tag-control-char-expected.txt: Updated expected results to reflect the fact that the control character is no longer stripped from the URL in these cases. The test is still valid, but these are not as interesting test cases any more since control characters do not have special handling.
4:41 PM Changeset in webkit [68853] by mrobinson@webkit.org
  • 3 edits
    2 adds in trunk/LayoutTests

2010-09-30 Martin Robinson <mrobinson@igalia.com>

Unskip some tests that are passing and rebaseline a couple others.

  • platform/gtk/Skipped: Unskip tests and do a little reorganization.
  • platform/gtk/fast/dom/Window/window-properties-expected.txt: Rebaselined.
  • platform/gtk/fast/overflow/line-clamp-expected.txt: Added.
4:25 PM Changeset in webkit [68852] by hclam@chromium.org
  • 1 edit
    1 delete in trunk/LayoutTests

Build fix. Not reviewed.

Remove a test expectation since the problem was fixed.

  • platform/chromium-win/editing/execCommand/toggle-compound-styles-expected.txt: Removed.
4:18 PM Changeset in webkit [68851] by Simon Fraser
  • 3 edits in trunk/WebKit2

2010-09-30 Simon Fraser <Simon Fraser>

Reviewed by Darin Adler.

Background doesn't draw when entering accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=45848

LayerBackedDrawingArea::setSize() is normally called in response
to a message from the UI process, so this can come some time after
LayerBackedDrawingArea creation. Depending on the timing, we could
end up being at size 0x0 for the first invalidate and paint, resulting
in missing content.

The fix is to size the backing layer on creation, using the WebView's size.

Also changed various calls to syncCompositingStateForThisLayerOnly()
to do lazy updates via scheduleCompositingLayerSync().

Also add the fix for https://bugs.webkit.org/show_bug.cgi?id=46226 (r68028)
to the WebKit2 code, in scheduleUpdateLayoutRunLoopObserver().

  • WebProcess/WebPage/LayerBackedDrawingArea.cpp: (WebKit::LayerBackedDrawingArea::LayerBackedDrawingArea): (WebKit::LayerBackedDrawingArea::setNeedsDisplay): (WebKit::LayerBackedDrawingArea::setSize):
  • WebProcess/WebPage/mac/LayerBackedDrawingAreaMac.mm: (WebKit::LayerBackedDrawingArea::platformInit): (WebKit::LayerBackedDrawingArea::attachCompositingContext): (WebKit::LayerBackedDrawingArea::detachCompositingContext): (WebKit::LayerBackedDrawingArea::setRootCompositingLayer): (WebKit::LayerBackedDrawingArea::syncCompositingLayers): (WebKit::LayerBackedDrawingArea::scheduleUpdateLayoutRunLoopObserver):
4:17 PM Changeset in webkit [68850] by commit-queue@webkit.org
  • 6 edits in trunk

2010-09-30 Alexey Marinichev <amarinichev@chromium.org>

Reviewed by Chris Marrin.

Add GetGraphicsResetStatusARB entry point from ARB_robustness
extension to GraphicsContext3D
https://bugs.webkit.org/show_bug.cgi?id=46850

Added stubs for GraphicsContext3D::getGraphicsResetStatusARB for
Mac and QT.

  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp: (WebCore::GraphicsContext3D::getGraphicsResetStatusARB):
  • platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3D::getGraphicsResetStatusARB):

2010-09-30 Alexey Marinichev <amarinichev@chromium.org>

Reviewed by Chris Marrin.

Add GetGraphicsResetStatusARB entry point from ARB_robustness
extension to GraphicsContext3D
https://bugs.webkit.org/show_bug.cgi?id=46850

Added a stub for GraphicsContext3D::getGraphicsResetStatusARB.

  • src/GraphicsContext3DChromium.cpp: (WebCore::GraphicsContext3D::getGraphicsResetStatusARB):
4:17 PM Changeset in webkit [68849] by jhoneycutt@apple.com
  • 4 edits in trunk

WebKit2 on Windows should use Windows fonts for the various standard
font families
https://bugs.webkit.org/show_bug.cgi?id=43499
<rdar://problem/8272758>

Reviewed by Adam Roben.

WebKit2:

  • Shared/WebPreferencesStore.cpp:

(WebKit::WebPreferencesStore::WebPreferencesStore):
Use Windows fonts on Windows.

WebKitTools:

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetStateToConsistentValues):
Use the Mac fonts for running tests. This matches DRT behavior.

4:08 PM Changeset in webkit [68848] by hclam@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

Build fix. Not reviewed.

Add test expectations for Chromium.

  • platform/chromium-win/editing/execCommand/toggle-compound-styles-expected.txt: Added.
4:04 PM Changeset in webkit [68847] by hclam@chromium.org
  • 3 edits in trunk/LayoutTests

Build fix. Not reviewed.

Update test expectations for Chromium.

  • platform/chromium-linux/fast/text/international/thai-baht-space-expected.checksum:
  • platform/chromium-linux/fast/text/international/thai-baht-space-expected.png:
3:57 PM Changeset in webkit [68846] by mrowe@apple.com
  • 2 edits in tags/Safari-534.9.1/WebKit/mac

Merge r68266.

3:57 PM Changeset in webkit [68845] by mrowe@apple.com
  • 5 edits in tags/Safari-534.9.1

Versioning.

3:41 PM Changeset in webkit [68844] by beidson@apple.com
  • 3 edits in trunk/WebKit2

https://bugs.webkit.org/show_bug.cgi?id=46774 - Add WKStringIsEqual API

Reviewed by Sam Weinig.

  • Shared/API/c/WKString.cpp:

(WKStringIsEqual):

  • Shared/API/c/WKString.h:
3:35 PM Changeset in webkit [68843] by mrowe@apple.com
  • 1 copy in tags/Safari-534.9.1

New tag.

3:24 PM Changeset in webkit [68842] by hyatt@apple.com
  • 10 edits
    4 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=46938

Reviewed by Sam Weinig.

Rewrite margin collapsing to be block-flow-aware. Eliminate a bunch of the margin functions on RenderBox in favor of a single
master function for grabbing all the margin values for a child: marginValuesForChild on RenderBlock. Introduce a new
MarginValues struct to make returning the collection of 4 margin values easy.

fast/blockflow/inline-direction-positioning.html progresses to have the correct results.
Added fast/blockflow/margin-collapse.html

WebCore:

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::MarginInfo::MarginInfo):
(WebCore::RenderBlock::adjustPositionedBlock):
(WebCore::RenderBlock::collapseMargins):
(WebCore::RenderBlock::clearFloatsIfNeeded):
(WebCore::RenderBlock::setCollapsedBottomMargin):
(WebCore::RenderBlock::layoutBlockChild):
(WebCore::RenderBlock::setMaxMarginBeforeValues):
(WebCore::RenderBlock::setMaxMarginAfterValues):
(WebCore::RenderBlock::marginValuesForChild):

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::MarginValues::MarginValues):
(WebCore::RenderBlock::MarginValues::positiveMarginBefore):
(WebCore::RenderBlock::MarginValues::negativeMarginBefore):
(WebCore::RenderBlock::MarginValues::positiveMarginAfter):
(WebCore::RenderBlock::MarginValues::negativeMarginAfter):
(WebCore::RenderBlock::MarginValues::setPositiveMarginBefore):
(WebCore::RenderBlock::MarginValues::setNegativeMarginBefore):
(WebCore::RenderBlock::MarginValues::setPositiveMarginAfter):
(WebCore::RenderBlock::MarginValues::setNegativeMarginAfter):
(WebCore::RenderBlock::maxPositiveMarginBefore):
(WebCore::RenderBlock::maxNegativeMarginBefore):
(WebCore::RenderBlock::maxPositiveMarginAfter):
(WebCore::RenderBlock::maxNegativeMarginAfter):
(WebCore::RenderBlock::initMaxMarginValues):
(WebCore::RenderBlock::collapsedMarginBefore):
(WebCore::RenderBlock::collapsedMarginAfter):
(WebCore::RenderBlock::MarginInfo::clearMargin):
(WebCore::RenderBlock::MarginInfo::setPositiveMargin):
(WebCore::RenderBlock::MarginInfo::setNegativeMargin):
(WebCore::RenderBlock::MarginInfo::setPositiveMarginIfLarger):
(WebCore::RenderBlock::MarginInfo::setNegativeMarginIfLarger):
(WebCore::RenderBlock::MarginInfo::setMargin):
(WebCore::RenderBlock::MarginInfo::positiveMargin):
(WebCore::RenderBlock::MarginInfo::negativeMargin):
(WebCore::RenderBlock::MarginInfo::margin):
(WebCore::RenderBlock::RenderBlockRareData::RenderBlockRareData):
(WebCore::RenderBlock::RenderBlockRareData::positiveMarginBeforeDefault):
(WebCore::RenderBlock::RenderBlockRareData::negativeMarginBeforeDefault):
(WebCore::RenderBlock::RenderBlockRareData::positiveMarginAfterDefault):
(WebCore::RenderBlock::RenderBlockRareData::negativeMarginAfterDefault):

  • rendering/RenderBox.h:

(WebCore::RenderBox::collapsedMarginBefore):
(WebCore::RenderBox::collapsedMarginAfter):

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutBlock):

LayoutTests:

  • fast/blockflow/margin-collapse.html: Added.
  • platform/mac/fast/blockflow/inline-direction-positioning-expected.checksum:
  • platform/mac/fast/blockflow/inline-direction-positioning-expected.png:
  • platform/mac/fast/blockflow/inline-direction-positioning-expected.txt:
  • platform/mac/fast/blockflow/margin-collapse-expected.checksum: Added.
  • platform/mac/fast/blockflow/margin-collapse-expected.png: Added.
  • platform/mac/fast/blockflow/margin-collapse-expected.txt: Added.
3:19 PM Changeset in webkit [68841] by Patrick Gansterer
  • 2 edits in trunk/WebCore

2010-09-30 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Roben.

[WINCE] Fix InternetGetCookie in CookieJarWin.cpp
https://bugs.webkit.org/show_bug.cgi?id=46929

If the InternetGetCookie fails the output size won't be set.
Set the default size to 0, so we always get the correct size
and check the return value of InternetGetCookie.

  • platform/network/win/CookieJarWin.cpp: (WebCore::cookies):
3:11 PM Changeset in webkit [68840] by rniwa@webkit.org
  • 3 edits in trunk/LayoutTests

2010-09-30 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed rebaseline for Qt and Windows platforms required by r68830.

  • platform/qt/editing/execCommand/toggle-compound-styles-expected.txt: Merged b elements.
  • platform/win/editing/execCommand/toggle-compound-styles-expected.txt: Ditto.
3:08 PM Changeset in webkit [68839] by Patrick Gansterer
  • 2 edits in trunk/WebCore

2010-09-30 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Roben.

[WINCE] Use OwnPtr for HBRUSH and HPEN in GraphicsContext
https://bugs.webkit.org/show_bug.cgi?id=46881

Also add some missing SelectObject calls.

  • platform/graphics/wince/GraphicsContextWinCE.cpp: (WebCore::createPen): (WebCore::createBrush): (WebCore::GraphicsContext::drawRect): (WebCore::GraphicsContext::drawLine): (WebCore::GraphicsContext::drawEllipse): (WebCore::GraphicsContext::strokeArc): (WebCore::GraphicsContext::drawConvexPolygon): (WebCore::GraphicsContext::strokeRect): (WebCore::GraphicsContext::fillRoundedRect): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath):
3:06 PM Changeset in webkit [68838] by hclam@chromium.org
  • 2 edits in trunk/LayoutTests

Build fix. Not reviewed.

Update test expectations for chromium.

  • platform/chromium/test_expectations.txt:
3:03 PM Changeset in webkit [68837] by andersca@apple.com
  • 1 edit in trunk/WebCore/ChangeLog

Add radar number to ChangeLog.

3:00 PM Changeset in webkit [68836] by andersca@apple.com
  • 3 edits in trunk/WebCore

WebCore uses the main thread to process sleep notifications
https://bugs.webkit.org/show_bug.cgi?id=46935

Reviewed by Dan Bernstein and Darin Adler.

Rewrite the old WebCorePowerNotifier to use IOKit directly.

On Snow Leopard, set up power notifications to arrive on a dispatch queue,
so that we can handle them quickly even if the main thread is hung.

(Tiger and Leopard will still get the old behavior).

  • WebCore.xcodeproj/project.pbxproj:

Link with IOKit.

  • platform/mac/SharedTimerMac.mm:

(WebCore::PowerObserver::PowerObserver):
Initialize the IOKit machinery.

(WebCore::PowerObserver::~PowerObserver):
Tear down the IOKit notifications.

(WebCore::PowerObserver::didReceiveSystemPowerNotification):
Acknowledge the event immediately and then call the shared timer functions. On Snow Leopard, we
make sure to call the shared timer functions on the main thread.

2:55 PM Changeset in webkit [68835] by commit-queue@webkit.org
  • 5 edits in trunk

2010-09-30 James Simonsen <simonjam@chromium.org>

Reviewed by Adam Barth.

[Web Timing] Make requestEnd equal to start of response
https://bugs.webkit.org/show_bug.cgi?id=46302

  • fast/dom/script-tests/webtiming.js: (checkTimingBeforeLoad): (checkWebTimingOnLoad): (checkWebTimingAfterLoad):
  • fast/dom/webtiming-expected.txt:

2010-09-30 James Simonsen <simonjam@chromium.org>

Reviewed by Adam Barth.

[Web Timing] Make requestEnd equal to start of response
https://bugs.webkit.org/show_bug.cgi?id=46302

  • page/Timing.cpp: (WebCore::Timing::requestEnd):
2:54 PM Changeset in webkit [68834] by xji@chromium.org
  • 2 edits in trunk/LayoutTests

2010-09-30 Xiaomei Ji <xji@chromium.org>

Unreviewed, updated test_expectations.txt

  • platform/chromium/test_expectations.txt:
2:48 PM Changeset in webkit [68833] by zmo@google.com
  • 4 edits in trunk

2010-09-30 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

fast/canvas/webgl/draw-elements-out-of-bounds.html is crashing on Snow Leopard
https://bugs.webkit.org/show_bug.cgi?id=46870

  • platform/graphics/ANGLEWebKitBridge.cpp: (WebCore::ANGLEWebKitBridge::~ANGLEWebKitBridge): Remove ShFinalize().

2010-09-30 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

fast/canvas/webgl/draw-elements-out-of-bounds.html is crashing on Snow Leopard
https://bugs.webkit.org/show_bug.cgi?id=46870

  • platform/mac-snowleopard/Skipped: Re-enable the test.
2:47 PM Changeset in webkit [68832] by commit-queue@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-09-30 Kwang Yul Seo <skyul@company100.net>

Reviewed by Kent Tamura.

[BREWMP] Add a factory function which returns an instance wrapped in PlatformRefPtr.
https://bugs.webkit.org/show_bug.cgi?id=46373

A Brew MP instance has reference count 1 when it is created, so call adoptPlatformRef
to wrap the instance in PlatformRefPtr.

  • wtf/brew/ShellBrew.h: (WTF::createRefPtrInstance):
2:43 PM Changeset in webkit [68831] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

-[DOMDocument _documentRange] throws an exception if there is no document element
https://bugs.webkit.org/show_bug.cgi?id=46934
<rdar://problem/8169260>

Reviewed by Darin Adler.

If there is no document element, just return an empty range. Otherwise we'll try to call
Range::selectNode with a null Node which will throw a NOT_FOUND exception.

  • DOM/WebDOMOperations.mm:

(-[DOMDocument _documentRange]):

2:37 PM Changeset in webkit [68830] by rniwa@webkit.org
  • 12 edits
    3 adds in trunk

2010-09-30 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Tony Chang.

WebKit nests font element when applying different font styles
https://bugs.webkit.org/show_bug.cgi?id=45568

The bug was caused by fixRangeAndApplyInlineStyle's not including fully selected ancestors,
and addInlineStyleIfNeeded's always surrounding the contents by new elements as supposed to
adding font attributes or style attribute.

Fixed the bug by extending the node range in fixRangeAndApplyInlineStyle and finding
the appropriate container node to add attributes in addInlineStyleIfNeeded.
addInlineStyleIfNeeded now tires to add font and style attributes to the inner most font and
span elements respectively.

Also added an early exit check to removeStyleFromRunBeforeApplyingStyle so that WebKit does not
modify the contents when the entire contents already have the desired style.

Test: editing/style/inline-style-container.html

  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::fixRangeAndApplyInlineStyle): (WebCore::ApplyStyleCommand::removeStyleFromRunBeforeApplyingStyle): (WebCore::ApplyStyleCommand::removeInlineStyleFromElement): (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded):

2010-09-30 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Tony Chang.

WebKit nests font element when applying different font styles
https://bugs.webkit.org/show_bug.cgi?id=45568

Added a test to ensure WebKit does not add extra font elements when the content already has an enclosing font element.
The test also ensures WebKit tries to add style attribute to the inner most span.

  • editing/execCommand/createLink-expected.txt: The ordering of anchor and span changed.
  • editing/execCommand/unlink-expected.txt: Ditto.
  • editing/execCommand/query-font-size-expected.txt: Merged font elements.
  • editing/execCommand/script-tests/toggle-style-2.js: The ordering of s and u elements changed.
  • editing/execCommand/toggle-style-2-expected.txt: Ditto.
  • editing/style/inline-style-container-expected.txt: Added.
  • editing/style/inline-style-container.html: Added.
  • editing/style/make-text-writing-direction-inline-expected.txt: Removed some extraneous spans added by the bug 44359.
  • editing/style/script-tests/inline-style-container.js: Added. (testSingleToggle):
  • editing/style/style-3690704-fix-expected.txt: Merged two b elements.
  • fast/events/event-input-contentEditable-expected.txt: Merged anchor elements.
  • fast/events/script-tests/event-input-contentEditable-expected.txt: Ditto.
2:34 PM Changeset in webkit [68829] by hclam@chromium.org
  • 1 edit
    14 deletes in trunk/LayoutTests

Build fix. Not reviewed.

Remove expectation files in wrong place.

  • platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-in-attr-actual.png: Removed.
  • platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-actual.png: Removed.
  • platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-actual.png: Removed.
  • platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-actual.png: Removed.
  • platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-actual.png: Removed.
  • platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-actual.png: Removed.
  • platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-actual.png: Removed.
  • platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop-actual.png: Removed.
  • platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-actual.png: Removed.
  • platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-actual.png: Removed.
  • platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-actual.png: Removed.
  • platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-actual.png: Removed.
  • platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-actual.png: Removed.
  • platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-actual.png: Removed.
2:33 PM Changeset in webkit [68828] by commit-queue@webkit.org
  • 1 edit
    1 add in trunk/JavaScriptCore

2010-09-30 Kwang Yul Seo <skyul@company100.net>

Reviewed by Kent Tamura.

[BREWMP] Port PlatformRefPtr
https://bugs.webkit.org/show_bug.cgi?id=46370

Implement refPlatformPtr and derefPlatformPtr to use PlatformRefPtr in Brew MP.

  • wtf/brew/RefPtrBrew.h: Added. (WTF::refPlatformPtr): (WTF::derefPlatformPtr):
2:29 PM Changeset in webkit [68827] by abarth@webkit.org
  • 3 edits in trunk/WebKitTools

2010-09-30 Adam Barth <abarth@webkit.org>

Third attempt. We need a better integration test environment.

  • Scripts/webkitpy/common/net/failuremap.py:
  • Scripts/webkitpy/common/net/failuremap_unittest.py:
2:25 PM Changeset in webkit [68826] by hclam@chromium.org
  • 1 edit
    42 moves
    14 adds in trunk/LayoutTests

Build fix. Not reviewed.

Rename test expectations last submitted.

  • platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-in-attr-expected.checksum: Renamed from LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-in-attr-actual.checksum.
  • platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-in-attr-expected.png: Renamed from LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-in-attr-actual.png.
  • platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-expected.checksum: Renamed from LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-actual.checksum.
  • platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-expected.png: Renamed from LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-actual.png.
  • platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-expected.checksum: Renamed from LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-actual.checksum.
  • platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-expected.png: Renamed from LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-actual.png.
  • platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.checksum: Renamed from LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-actual.checksum.
  • platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.png: Renamed from LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-actual.png.
  • platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.checksum: Renamed from LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-actual.checksum.
  • platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.png: Renamed from LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-actual.png.
  • platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.checksum: Renamed from LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-actual.checksum.
  • platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.png: Renamed from LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-actual.png.
  • platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-expected.checksum: Renamed from LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-actual.checksum.
  • platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-expected.png: Renamed from LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-actual.png.
  • platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop-expected.checksum: Renamed from LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop-actual.checksum.
  • platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop-expected.png: Renamed from LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop-actual.png.
  • platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-expected.checksum: Renamed from LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-actual.checksum.
  • platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-expected.png: Renamed from LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-actual.png.
  • platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.checksum: Renamed from LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-actual.checksum.
  • platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.png: Renamed from LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-actual.png.
  • platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.checksum: Renamed from LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-actual.checksum.
  • platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.png: Renamed from LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-actual.png.
  • platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.checksum: Renamed from LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-actual.checksum.
  • platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.png: Renamed from LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-actual.png.
  • platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-expected.checksum: Renamed from LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-actual.checksum.
  • platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-expected.png: Renamed from LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-actual.png.
  • platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.checksum: Renamed from LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-actual.checksum.
  • platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.png: Renamed from LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-actual.png.
  • platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-in-attr-expected.checksum: Renamed from LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-in-attr-actual.checksum.
  • platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-in-attr-expected.png: Copied from LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-in-attr-actual.png.
  • platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-expected.checksum: Renamed from LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-actual.checksum.
  • platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-expected.png: Copied from LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-actual.png.
  • platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-expected.checksum: Renamed from LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-actual.checksum.
  • platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-expected.png: Copied from LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-actual.png.
  • platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.checksum: Renamed from LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-actual.checksum.
  • platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.png: Copied from LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-actual.png.
  • platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.checksum: Renamed from LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-actual.checksum.
  • platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.png: Copied from LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-actual.png.
  • platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.checksum: Renamed from LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-actual.checksum.
  • platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.png: Copied from LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-actual.png.
  • platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-expected.checksum: Renamed from LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-actual.checksum.
  • platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-expected.png: Copied from LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-actual.png.
  • platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop-expected.checksum: Renamed from LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop-actual.checksum.
  • platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop-expected.png: Copied from LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop-actual.png.
  • platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-expected.checksum: Renamed from LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-actual.checksum.
  • platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-expected.png: Copied from LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-actual.png.
  • platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.checksum: Renamed from LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-actual.checksum.
  • platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.png: Copied from LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-actual.png.
  • platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.checksum: Renamed from LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-actual.checksum.
  • platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.png: Copied from LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-actual.png.
  • platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.checksum: Renamed from LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-actual.checksum.
  • platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.png: Copied from LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-actual.png.
  • platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-expected.checksum: Renamed from LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-actual.checksum.
  • platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-expected.png: Copied from LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-actual.png.
  • platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.checksum: Renamed from LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-actual.checksum.
  • platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.png: Copied from LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-actual.png.
2:22 PM Changeset in webkit [68825] by robert@webkit.org
  • 9 edits
    2 adds in trunk

2010-09-30 Robert Hogan <robert@webkit.org>

Reviewed by Andreas Kling.

[Qt] Support for PlainTextController

Unskip editing/text-iterator/basic-iteration.html

https://bugs.webkit.org/show_bug.cgi?id=38805

  • platform/qt/Skipped:

2010-09-30 Robert Hogan <robert@webkit.org>

Reviewed by Andreas Kling.

[Qt] Support for PlainTextController

Unskip editing/text-iterator/basic-iteration.html

https://bugs.webkit.org/show_bug.cgi?id=38805

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::plainText):
  • WebCoreSupport/DumpRenderTreeSupportQt.h:

2010-09-30 Robert Hogan <robert@webkit.org>

Reviewed by Andreas Kling.

[Qt] Support for PlainTextController

Unskip editing/text-iterator/basic-iteration.html

https://bugs.webkit.org/show_bug.cgi?id=38805

  • DumpRenderTree/qt/DumpRenderTree.pro:
  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::DumpRenderTree): (WebCore::DumpRenderTree::initJSObjects):
  • DumpRenderTree/qt/DumpRenderTreeQt.h:
  • DumpRenderTree/qt/PlainTextControllerQt.cpp: Added. (PlainTextController::PlainTextController): (PlainTextController::plainText):
  • DumpRenderTree/qt/PlainTextControllerQt.h: Added.
2:20 PM Changeset in webkit [68824] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-09-30 Jarred Nicholls <jarred@sencha.com>

Reviewed by Darin Adler.

Removed unnecessary calls to ceil() on an int
Removing the call fixes MSVC build errors
https://bugs.webkit.org/show_bug.cgi?id=46931

  • platform/graphics/ContextShadow.cpp: (WebCore::ContextShadow::calculateLayerBoundingRect):
2:17 PM Changeset in webkit [68823] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-09-30 Adam Barth <abarth@webkit.org>

Unreviewed. Second attempt to fix sheriffbot.

  • Scripts/webkitpy/common/net/buildbot.py:
2:12 PM Changeset in webkit [68822] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-09-30 Adam Barth <abarth@webkit.org>

Unreviewed.

This patch should stop the sheriffbot from throwing an exception.

  • Scripts/webkitpy/common/net/buildbot.py:
1:48 PM Changeset in webkit [68821] by mrobinson@webkit.org
  • 2 edits in trunk/LayoutTests

2010-09-30 Martin Robinson <mrobinson@igalia.com>

Unskip websocket tests for GTK+, as the bots should be running
a version of the Linux kernel which has support for SOCK_CLOEXEC.

  • platform/gtk/Skipped: Unskip websocket tests.
1:37 PM Changeset in webkit [68820] by hyatt@apple.com
  • 3 edits in trunk

https://bugs.webkit.org/show_bug.cgi?id=46932

Reviewed by Beth Dakin.

Get fast/blockflow/root-lr-basic.html results to be correct by patching a few more
height() calls to be logicalHeight().

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::collapseMargins):
(WebCore::RenderBlock::handleAfterSideOfBlock):

1:31 PM Changeset in webkit [68819] by jschuh@chromium.org
  • 5 edits
    2 adds in trunk

2010-09-30 Cris Neckar <cdn@chromium.org>

Reviewed by Darin Adler.

Added check to test for removed counter node when calling findPlaceForCounter() in updateCounters().
Added refcounting to counternodes in countermaps.
https://bugs.webkit.org/show_bug.cgi?id=46387

Test: fast/css/counters/counter-traverse-table-cell.html

  • rendering/CounterNode.cpp: (WebCore::CounterNode::create):
  • rendering/CounterNode.h:
  • rendering/RenderCounter.cpp: (WebCore::makeCounterNode): (WebCore::destroyCounterNodeWithoutMapRemoval): (WebCore::RenderCounter::destroyCounterNodes): (WebCore::RenderCounter::destroyCounterNode): (WebCore::updateCounters):

2010-09-30 Cris Neckar <cdn@chromium.org>

Reviewed by Darin Adler.

Tests for crash in counter nodes when traversing table cells.
https://bugs.webkit.org/show_bug.cgi?id=46387

  • fast/css/counters/counter-traverse-table-cell-expected.txt: Added.
  • fast/css/counters/counter-traverse-table-cell.html: Added.
1:01 PM Changeset in webkit [68818] by dumi@chromium.org
  • 3 edits in trunk/WebKit/chromium

Remove WebHTTPBody::appendFileRange(..., const WebFileInfo&).

Reviewed by Darin Fisher.

  • public/WebHTTPBody.h:
  • src/WebHTTPBody.cpp:

(WebKit::WebHTTPBody::elementAt):

1:01 PM Changeset in webkit [68817] by hyatt@apple.com
  • 36 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=46928

Reviewed by Beth Dakin.

Add isLeftToRightDirection() to RenderStyle and change callers that did direction() == LTR and direction() == RTL to use this instead.

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::isLeftPage):
(WebCore::CSSStyleSelector::applyProperty):

  • editing/Editor.cpp:

(WebCore::Editor::hasBidiSelection):

  • editing/VisiblePosition.cpp:

(WebCore::VisiblePosition::leftVisuallyDistinctCandidate):
(WebCore::VisiblePosition::rightVisuallyDistinctCandidate):

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::drawTextInternal):

  • rendering/InlineBox.h:

(WebCore::InlineBox::isLeftToRightDirection):
(WebCore::InlineBox::caretLeftmostOffset):
(WebCore::InlineBox::caretRightmostOffset):

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::determineSpacingForFlowBoxes):
(WebCore::InlineFlowBox::placeBoxesInInlineDirection):
(WebCore::InlineFlowBox::paintTextDecorations):

  • rendering/InlineIterator.h:

(WebCore::InlineIterator::direction):

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::selectionRect):
(WebCore::InlineTextBox::placeEllipsisBox):
(WebCore::InlineTextBox::paint):
(WebCore::InlineTextBox::paintSelection):
(WebCore::InlineTextBox::paintCompositionBackground):
(WebCore::InlineTextBox::paintDecoration):
(WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
(WebCore::InlineTextBox::paintTextMatchMarker):
(WebCore::InlineTextBox::computeRectForReplacementMarker):
(WebCore::InlineTextBox::textPos):
(WebCore::InlineTextBox::offsetForPosition):
(WebCore::InlineTextBox::positionForOffset):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::adjustPositionedBlock):
(WebCore::RenderBlock::determineLogicalLeftPositionForChild):
(WebCore::RenderBlock::paintColumnRules):
(WebCore::RenderBlock::paintColumnContents):
(WebCore::RenderBlock::getHorizontalSelectionGapInfo):
(WebCore::RenderBlock::logicalLeftOffsetForLine):
(WebCore::RenderBlock::logicalRightOffsetForLine):
(WebCore::RenderBlock::rightmostPosition):
(WebCore::RenderBlock::leftmostPosition):
(WebCore::RenderBlock::columnRectAt):
(WebCore::RenderBlock::layoutColumns):
(WebCore::getBorderPaddingMargin):
(WebCore::RenderBlock::localCaretRect):
(WebCore::RenderBlock::marginStartForChild):
(WebCore::RenderBlock::marginEndForChild):
(WebCore::RenderBlock::setMarginStartForChild):
(WebCore::RenderBlock::setMarginEndForChild):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::getBorderPaddingMargin):
(WebCore::RenderBlock::constructLine):
(WebCore::RenderBlock::computeInlineDirectionPositionsForLine):
(WebCore::RenderBlock::determineStartPosition):
(WebCore::RenderBlock::skipTrailingWhitespace):
(WebCore::RenderBlock::skipLeadingWhitespace):
(WebCore::RenderBlock::findNextLineBreak):
(WebCore::RenderBlock::checkLinesForTextOverflow):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::marginStart):
(WebCore::RenderBox::marginEnd):
(WebCore::RenderBox::setMarginStart):
(WebCore::RenderBox::setMarginEnd):
(WebCore::RenderBox::scrollWidth):
(WebCore::RenderBox::computeInlineDirectionMargins):
(WebCore::RenderBox::containingBlockWidthForPositioned):
(WebCore::RenderBox::computePositionedLogicalWidthUsing):
(WebCore::RenderBox::computePositionedLogicalWidthReplaced):
(WebCore::RenderBox::localCaretRect):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::relativePositionOffsetX):

  • rendering/RenderFieldset.cpp:

(WebCore::RenderFieldset::layoutLegend):

  • rendering/RenderFileUploadControl.cpp:

(WebCore::RenderFileUploadControl::paintObject):

  • rendering/RenderFlexibleBox.cpp:

(WebCore::FlexBoxIterator::FlexBoxIterator):
(WebCore::RenderFlexibleBox::layoutHorizontalBox):
(WebCore::RenderFlexibleBox::layoutVerticalBox):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::computeScrollDimensions):

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::paintItemForeground):

  • rendering/RenderListItem.cpp:

(WebCore::RenderListItem::positionListMarker):
(WebCore::RenderListItem::markerTextWithSuffix):

  • rendering/RenderListMarker.cpp:

(WebCore::RenderListMarker::paint):
(WebCore::RenderListMarker::updateMargins):
(WebCore::RenderListMarker::suffix):

  • rendering/RenderMarquee.cpp:

(WebCore::RenderMarquee::computePosition):

  • rendering/RenderMeter.cpp:

(WebCore::RenderMeter::valuePartRect):

  • rendering/RenderProgress.cpp:

(WebCore::RenderProgress::valuePartRect):

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::calcBorderLeft):
(WebCore::RenderTable::calcBorderRight):

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::clippedOverflowRectForRepaint):
(WebCore::RenderTableCell::borderHalfLeft):
(WebCore::RenderTableCell::borderHalfRight):
(WebCore::RenderTableCell::collectBorderStyles):
(WebCore::RenderTableCell::paintCollapsedBorder):

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::layoutRows):
(WebCore::RenderTableSection::recalcOuterBorder):
(WebCore::RenderTableSection::paintObject):
(WebCore::RenderTableSection::nodeAtPoint):

  • rendering/RenderText.cpp:

(WebCore::RenderText::localCaretRect):
(WebCore::RenderText::positionLineBox):

  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::forwardEvent):

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::levelIndicatorFor):
(WebCore::RenderThemeMac::paintProgressBar):

  • rendering/RenderTreeAsText.cpp:

(WebCore::writeTextRun):

  • rendering/SVGInlineTextBox.cpp:

(WebCore::SVGInlineTextBox::measureCharacter):
(WebCore::SVGInlineTextBox::buildLayoutInformation):

  • rendering/SVGRenderTreeAsText.cpp:

(WebCore::writeSVGInlineTextBox):

  • rendering/SVGTextLayoutUtilities.cpp:

(WebCore::svgTextRunForInlineTextBox):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::borderStartWidth):
(WebCore::RenderStyle::borderEndWidth):
(WebCore::RenderStyle::marginStart):
(WebCore::RenderStyle::marginEnd):
(WebCore::RenderStyle::marginStartUsing):
(WebCore::RenderStyle::marginEndUsing):
(WebCore::RenderStyle::paddingStart):
(WebCore::RenderStyle::paddingEnd):

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::isLeftToRightDirection):

  • wml/WMLTableElement.cpp:

(WebCore::WMLTableElement::alignCells):

12:35 PM Changeset in webkit [68816] by hclam@chromium.org
  • 1 edit
    56 adds in trunk/LayoutTests

done

12:27 PM Changeset in webkit [68815] by bweinstein@apple.com
  • 2 edits in trunk/WebKitTools

The same bots shouldn't run both Windows Debug Tests and Windows Release Tests.
https://bugs.webkit.org/show_bug.cgi?id=46926

Reviewed by Adam Roben.

  • BuildSlaveSupport/build.webkit.org-config/config.json: Have two bots running Windows

Release Tests, and two bots running Windows Debug Tests, instead of four running both.

11:54 AM Changeset in webkit [68814] by hyatt@apple.com
  • 4 edits
    4 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=46923

Reviewed by Simon Fraser.

Make determineLogicalLeftPositionForChild block-flow-aware. Rewrite the function so that there aren't
completely separate LTR/RTL cases.

Added fast/blockflow/inline-direction-positioning.html

WebCore:

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::determineLogicalLeftPositionForChild):
(WebCore::RenderBlock::setLogicalLeftForChild):

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::logicalWidthForChild):
(WebCore::RenderBlock::logicalRightOffsetForContent):
(WebCore::RenderBlock::logicalLeftOffsetForContent):

LayoutTests:

  • fast/blockflow/inline-direction-positioning.html: Added.
  • platform/mac/fast/blockflow/inline-direction-positioning-expected.checksum: Added.
  • platform/mac/fast/blockflow/inline-direction-positioning-expected.png: Added.
  • platform/mac/fast/blockflow/inline-direction-positioning-expected.txt: Added.
11:50 AM Changeset in webkit [68813] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-09-30 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

webkit-patch find-flaky-tests should print results URLs
https://bugs.webkit.org/show_bug.cgi?id=46917

Printing out the results URL makes find-flaky-tests more actionable
because you can see what happens when a test fails. The output from
the script is still pretty noisy, but it seems useful.

  • Scripts/webkitpy/tool/commands/queries.py:
11:50 AM Changeset in webkit [68812] by weinig@apple.com
  • 2 edits in trunk/JavaScriptCore

Add additional checks to StringBuffer.
<rdar://problem/7756381>

Reviewed by Darin Adler.

  • wtf/text/StringBuffer.h:

(WTF::StringBuffer::StringBuffer):
(WTF::StringBuffer::resize):

11:42 AM Changeset in webkit [68811] by andersca@apple.com
  • 3 edits in trunk/WebKit2

Forward declare structs with 'struct' in the message headers
https://bugs.webkit.org/show_bug.cgi?id=46925
<rdar://problem/8497940>

Reviewed by Adam Roben.

  • Scripts/webkit2/messages.py:

(struct_or_class): New function which given a type and a namespace returns the correct
forward declaration syntax (struct or class).

  • Scripts/webkit2/messages_unittest.py:

Update expected results.

11:32 AM Changeset in webkit [68810] by thakis@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-09-30 Nico Weber <thakis@chromium.org>

Reviewed by Adam Barth.

[chromium] Fix clang error in KURLTest.cpp
https://bugs.webkit.org/show_bug.cgi?id=46861

  • tests/KURLTest.cpp: (WTF::operator<<):
11:28 AM Changeset in webkit [68809] by Adam Roben
  • 3 edits
    2 adds in trunk

Fix color media queries on Windows

Fixes <http://webkit.org/b/42973> <rdar://problem/8234072> (color:8)
media query does not evaluate to true for 32bpp displays on Windows

Test: fast/media/color-does-not-include-alpha.html

Reviewed by Darin Adler.

WebCore:

  • platform/win/PlatformScreenWin.cpp:

(WebCore::screenDepthPerComponent): Use screenDepth instead of trying
to interpret DEVMODE directly, since screenDepth knows how to correct
for video drivers that return 32 instead of 24.

LayoutTests:

Add test for color:8 media queries

  • fast/media/color-does-not-include-alpha-expected.txt: Added.
  • fast/media/color-does-not-include-alpha.html: Added.
11:27 AM Changeset in webkit [68808] by Adam Roben
  • 5 edits in trunk

Make sure screen.colorDepth/screen.pixelDepth don't include the bits used for alpha

Fixes <http://webkit.org/b/42972> <rdar://problem/8234071>
screen.colorDepth and screen.pixelDepth return 32 on Windows, but
should return 24 (according to CSSOM View and Firefox)

Reviewed by Darin Adler.

WebCore:

  • platform/win/PlatformScreenWin.cpp:

(WebCore::screenDepth): If Windows says there are 32 bits per pixel,
return 24 instead, as 32 includes the alpha component but this
function is supposed to ignore the alpha component.

LayoutTests:

Update screen.colorDepth/screen.pixelDepth test to not allow values
that contain bits for alpha

  • fast/dom/Window/window-screen-properties-expected.txt: Updated

results.

  • fast/dom/Window/window-screen-properties.html: Changed only to

expect 16 or 24.

11:20 AM Changeset in webkit [68807] by commit-queue@webkit.org
  • 15 edits in trunk

2010-09-30 Daniel Cheng <dcheng@chromium.org>

Reviewed by Tony Chang.

[chromium] Refactor ChromiumDataObject to use getters/setters.
https://bugs.webkit.org/show_bug.cgi?id=46559

This is an intermediate step to converting ChromiumDataObject to use
callbacks to the browser to retrieve data.

This is covered by existing tests.

  • editing/chromium/EditorChromium.cpp: (WebCore::Editor::newGeneralClipboard):
  • page/chromium/EventHandlerChromium.cpp: (WebCore::EventHandler::createDraggingClipboard):
  • platform/chromium/ChromiumDataObject.cpp: (WebCore::ChromiumDataObject::clearData): (WebCore::ChromiumDataObject::clearAll): (WebCore::ChromiumDataObject::clearAllExceptFiles): (WebCore::ChromiumDataObject::hasData): (WebCore::ChromiumDataObject::types): (WebCore::ChromiumDataObject::getData): (WebCore::ChromiumDataObject::setData): (WebCore::ChromiumDataObject::ChromiumDataObject):
  • platform/chromium/ChromiumDataObject.h: (WebCore::ChromiumDataObject::create): (WebCore::ChromiumDataObject::urlTitle): (WebCore::ChromiumDataObject::setUrlTitle): (WebCore::ChromiumDataObject::htmlBaseUrl): (WebCore::ChromiumDataObject::setHtmlBaseUrl): (WebCore::ChromiumDataObject::containsFilenames): (WebCore::ChromiumDataObject::filenames): (WebCore::ChromiumDataObject::setFilenames): (WebCore::ChromiumDataObject::fileExtension): (WebCore::ChromiumDataObject::setFileExtension): (WebCore::ChromiumDataObject::fileContentFilename): (WebCore::ChromiumDataObject::setFileContentFilename): (WebCore::ChromiumDataObject::fileContent): (WebCore::ChromiumDataObject::setFileContent):
  • platform/chromium/ClipboardChromium.cpp: (WebCore::normalizeType): (WebCore::ClipboardChromium::clearData): (WebCore::ClipboardChromium::clearAllData): (WebCore::ClipboardChromium::getData): (WebCore::ClipboardChromium::setData): (WebCore::ClipboardChromium::types): (WebCore::ClipboardChromium::files): (WebCore::writeImageToDataObject): (WebCore::ClipboardChromium::declareAndWriteDragImage): (WebCore::ClipboardChromium::writeURL): (WebCore::ClipboardChromium::writeRange): (WebCore::ClipboardChromium::writePlainText):
  • platform/chromium/ClipboardChromiumWin.cpp: (WebCore::ClipboardChromium::validateFileName):
  • platform/chromium/ClipboardMimeTypes.cpp:
  • platform/chromium/ClipboardMimeTypes.h:
  • platform/chromium/DragDataChromium.cpp: (WebCore::containsHTML): (WebCore::DragData::containsURL): (WebCore::DragData::asURL): (WebCore::DragData::containsFiles): (WebCore::DragData::asFilenames): (WebCore::DragData::containsPlainText): (WebCore::DragData::asPlainText): (WebCore::DragData::canSmartReplace): (WebCore::DragData::asFragment):
  • platform/chromium/ReadableDataObject.cpp: (WebCore::ReadableDataObject::getURL): (WebCore::ReadableDataObject::getHTML):
  • platform/chromium/WritableDataObject.cpp: (WebCore::WritableDataObject::clearData): (WebCore::WritableDataObject::setData): (WebCore::WritableDataObject::setURL): (WebCore::WritableDataObject::setHTML):

2010-09-30 Daniel Cheng <dcheng@chromium.org>

Reviewed by Tony Chang.

[chromium] Refactor ChromiumDataObject to use getters/setters.
https://bugs.webkit.org/show_bug.cgi?id=46559

This is an intermediate step to converting ChromiumDataObject to use
callbacks to the browser to retrieve data.

  • public/WebDragData.h:
  • src/WebDragData.cpp: (WebKit::WebDragData::initialize): (WebKit::WebDragData::url): (WebKit::WebDragData::setURL): (WebKit::WebDragData::urlTitle): (WebKit::WebDragData::setURLTitle): (WebKit::WebDragData::downloadMetadata): (WebKit::WebDragData::setDownloadMetadata): (WebKit::WebDragData::fileExtension): (WebKit::WebDragData::setFileExtension): (WebKit::WebDragData::hasFileNames): (WebKit::WebDragData::fileNames): (WebKit::WebDragData::setFileNames): (WebKit::WebDragData::appendToFileNames): (WebKit::WebDragData::plainText): (WebKit::WebDragData::setPlainText): (WebKit::WebDragData::htmlText): (WebKit::WebDragData::setHTMLText): (WebKit::WebDragData::htmlBaseURL): (WebKit::WebDragData::setHTMLBaseURL): (WebKit::WebDragData::fileContentFileName): (WebKit::WebDragData::setFileContentFileName): (WebKit::WebDragData::fileContent): (WebKit::WebDragData::setFileContent):
11:12 AM Changeset in webkit [68806] by zmo@google.com
  • 5 edits
    81 adds in trunk

2010-09-29 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

glsl-conformance.html on khronos will crash chromium --in-process-webgl
https://bugs.webkit.org/show_bug.cgi?id=46863

  • src/WebGraphicsContext3DDefaultImpl.cpp: Make ShaderSourceMap as <ShaderID, ShaderSourceEntry*>, so map resizing will be efficient and we don't need to worry about pointer copying. (WebKit::WebGraphicsContext3DDefaultImpl::~WebGraphicsContext3DDefaultImpl): (WebKit::WebGraphicsContext3DDefaultImpl::compileShader): (WebKit::WebGraphicsContext3DDefaultImpl::getShaderiv): (WebKit::WebGraphicsContext3DDefaultImpl::getShaderInfoLog): (WebKit::WebGraphicsContext3DDefaultImpl::getShaderSource): (WebKit::WebGraphicsContext3DDefaultImpl::shaderSource): (WebKit::WebGraphicsContext3DDefaultImpl::createShader): (WebKit::WebGraphicsContext3DDefaultImpl::deleteShader):
  • src/WebGraphicsContext3DDefaultImpl.h: Ditto. (WebKit::WebGraphicsContext3DDefaultImpl::ShaderSourceEntry::ShaderSourceEntry):

2010-09-29 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

glsl-conformance.html on khronos will crash chromium --in-process-webgl
https://bugs.webkit.org/show_bug.cgi?id=46863

  • fast/canvas/webgl/glsl-conformance-expected.txt: Added.
  • fast/canvas/webgl/glsl-conformance.html: Added.
  • fast/canvas/webgl/resources/webgl-test-utils.js: Add a function to turn off console output. (WebGLTestUtils.): (WebGLTestUtils):
  • fast/canvas/webgl/shaders: Added.
  • fast/canvas/webgl/shaders/00_shaders.txt: Added.
  • fast/canvas/webgl/shaders/implicit: Added.
  • fast/canvas/webgl/shaders/implicit/00_shaders.txt: Added.
  • fast/canvas/webgl/shaders/implicit/add_int_float.vert: Added.
  • fast/canvas/webgl/shaders/implicit/add_int_mat2.vert: Added.
  • fast/canvas/webgl/shaders/implicit/add_int_mat3.vert: Added.
  • fast/canvas/webgl/shaders/implicit/add_int_mat4.vert: Added.
  • fast/canvas/webgl/shaders/implicit/add_int_vec2.vert: Added.
  • fast/canvas/webgl/shaders/implicit/add_int_vec3.vert: Added.
  • fast/canvas/webgl/shaders/implicit/add_int_vec4.vert: Added.
  • fast/canvas/webgl/shaders/implicit/add_ivec2_vec2.vert: Added.
  • fast/canvas/webgl/shaders/implicit/add_ivec3_vec3.vert: Added.
  • fast/canvas/webgl/shaders/implicit/add_ivec4_vec4.vert: Added.
  • fast/canvas/webgl/shaders/implicit/assign_int_to_float.vert: Added.
  • fast/canvas/webgl/shaders/implicit/assign_ivec2_to_vec2.vert: Added.
  • fast/canvas/webgl/shaders/implicit/assign_ivec3_to_vec3.vert: Added.
  • fast/canvas/webgl/shaders/implicit/assign_ivec4_to_vec4.vert: Added.
  • fast/canvas/webgl/shaders/implicit/construct_struct.vert: Added.
  • fast/canvas/webgl/shaders/implicit/divide_int_float.vert: Added.
  • fast/canvas/webgl/shaders/implicit/divide_int_mat2.vert: Added.
  • fast/canvas/webgl/shaders/implicit/divide_int_mat3.vert: Added.
  • fast/canvas/webgl/shaders/implicit/divide_int_mat4.vert: Added.
  • fast/canvas/webgl/shaders/implicit/divide_int_vec2.vert: Added.
  • fast/canvas/webgl/shaders/implicit/divide_int_vec3.vert: Added.
  • fast/canvas/webgl/shaders/implicit/divide_int_vec4.vert: Added.
  • fast/canvas/webgl/shaders/implicit/divide_ivec2_vec2.vert: Added.
  • fast/canvas/webgl/shaders/implicit/divide_ivec3_vec3.vert: Added.
  • fast/canvas/webgl/shaders/implicit/divide_ivec4_vec4.vert: Added.
  • fast/canvas/webgl/shaders/implicit/equal_int_float.vert: Added.
  • fast/canvas/webgl/shaders/implicit/equal_ivec2_vec2.vert: Added.
  • fast/canvas/webgl/shaders/implicit/equal_ivec3_vec3.vert: Added.
  • fast/canvas/webgl/shaders/implicit/equal_ivec4_vec4.vert: Added.
  • fast/canvas/webgl/shaders/implicit/function_int_float.vert: Added.
  • fast/canvas/webgl/shaders/implicit/function_ivec2_vec2.vert: Added.
  • fast/canvas/webgl/shaders/implicit/function_ivec3_vec3.vert: Added.
  • fast/canvas/webgl/shaders/implicit/function_ivec4_vec4.vert: Added.
  • fast/canvas/webgl/shaders/implicit/greater_than.vert: Added.
  • fast/canvas/webgl/shaders/implicit/greater_than_equal.vert: Added.
  • fast/canvas/webgl/shaders/implicit/less_than.vert: Added.
  • fast/canvas/webgl/shaders/implicit/less_than_equal.vert: Added.
  • fast/canvas/webgl/shaders/implicit/multiply_int_float.vert: Added.
  • fast/canvas/webgl/shaders/implicit/multiply_int_mat2.vert: Added.
  • fast/canvas/webgl/shaders/implicit/multiply_int_mat3.vert: Added.
  • fast/canvas/webgl/shaders/implicit/multiply_int_mat4.vert: Added.
  • fast/canvas/webgl/shaders/implicit/multiply_int_vec2.vert: Added.
  • fast/canvas/webgl/shaders/implicit/multiply_int_vec3.vert: Added.
  • fast/canvas/webgl/shaders/implicit/multiply_int_vec4.vert: Added.
  • fast/canvas/webgl/shaders/implicit/multiply_ivec2_vec2.vert: Added.
  • fast/canvas/webgl/shaders/implicit/multiply_ivec3_vec3.vert: Added.
  • fast/canvas/webgl/shaders/implicit/multiply_ivec4_vec4.vert: Added.
  • fast/canvas/webgl/shaders/implicit/not_equal_int_float.vert: Added.
  • fast/canvas/webgl/shaders/implicit/not_equal_ivec2_vec2.vert: Added.
  • fast/canvas/webgl/shaders/implicit/not_equal_ivec3_vec3.vert: Added.
  • fast/canvas/webgl/shaders/implicit/not_equal_ivec4_vec4.vert: Added.
  • fast/canvas/webgl/shaders/implicit/subtract_int_float.vert: Added.
  • fast/canvas/webgl/shaders/implicit/subtract_int_mat2.vert: Added.
  • fast/canvas/webgl/shaders/implicit/subtract_int_mat3.vert: Added.
  • fast/canvas/webgl/shaders/implicit/subtract_int_mat4.vert: Added.
  • fast/canvas/webgl/shaders/implicit/subtract_int_vec2.vert: Added.
  • fast/canvas/webgl/shaders/implicit/subtract_int_vec3.vert: Added.
  • fast/canvas/webgl/shaders/implicit/subtract_int_vec4.vert: Added.
  • fast/canvas/webgl/shaders/implicit/subtract_ivec2_vec2.vert: Added.
  • fast/canvas/webgl/shaders/implicit/subtract_ivec3_vec3.vert: Added.
  • fast/canvas/webgl/shaders/implicit/subtract_ivec4_vec4.vert: Added.
  • fast/canvas/webgl/shaders/implicit/ternary_int_float.vert: Added.
  • fast/canvas/webgl/shaders/implicit/ternary_ivec2_vec2.vert: Added.
  • fast/canvas/webgl/shaders/implicit/ternary_ivec3_vec3.vert: Added.
  • fast/canvas/webgl/shaders/implicit/ternary_ivec4_vec4.vert: Added.
  • fast/canvas/webgl/shaders/reserved: Added.
  • fast/canvas/webgl/shaders/reserved/00_shaders.txt: Added.
  • fast/canvas/webgl/shaders/reserved/_webgl_field.vert: Added.
  • fast/canvas/webgl/shaders/reserved/_webgl_function.vert: Added.
  • fast/canvas/webgl/shaders/reserved/_webgl_struct.vert: Added.
  • fast/canvas/webgl/shaders/reserved/_webgl_variable.vert: Added.
  • fast/canvas/webgl/shaders/reserved/webgl_field.vert: Added.
  • fast/canvas/webgl/shaders/reserved/webgl_function.vert: Added.
  • fast/canvas/webgl/shaders/reserved/webgl_struct.vert: Added.
  • fast/canvas/webgl/shaders/reserved/webgl_variable.vert: Added.
11:04 AM Changeset in webkit [68805] by Adam Roben
  • 2 edits in trunk/LayoutTests

Add some tests to the Windows Skipped list

These all have bugs filed about them.

  • platform/win/Skipped:
10:59 AM Changeset in webkit [68804] by cmarrin@apple.com
  • 1 edit in trunk/WebCore/platform/graphics/gpu/DrawingBuffer.h

Fixed chrome build issue in DrawingBuffer.h

10:57 AM Changeset in webkit [68803] by andreip@google.com
  • 3 edits in trunk/WebKit/chromium

2010-09-30 Andrei Popescu <andreip@google.com>

Reviewed by Jeremy Orlow.

[Chromium] WebIDBDatabase and WebIDBObjectStore are missing methods called from Chromium land.
https://bugs.webkit.org/show_bug.cgi?id=46922

The missing functions were removed in r68795.

  • public/WebIDBDatabase.h: (WebKit::WebIDBDatabase::createObjectStore): (WebKit::WebIDBDatabase::removeObjectStore):
  • public/WebIDBObjectStore.h: (WebKit::WebIDBObjectStore::createIndex): (WebKit::WebIDBObjectStore::removeIndex):
10:43 AM Changeset in webkit [68802] by cmarrin@apple.com
  • 21 edits
    2 adds in trunk

2010-09-30 Chris Marrin <cmarrin@apple.com>

Reviewed by Simon Fraser.

Make 2D accelerated canvas rendering build on Mac
https://bugs.webkit.org/show_bug.cgi?id=46007

Add accelerated 2D rendering files to Mac build, fix build errors,
add ifdefs to compile only when the ACCELERATED_2D_CANVAS flag is
enabled, and add a skeleton of the mac specific file so it builds.

DrawingBufferMac.mm, the Mac specific file does nothing right now
other than initialize and create a layer. The rest will be added
when I do the actual implementation.

The most significant change was to SharedGraphicsContext3D, which
had a static local OwnPtr in one of the methods. This was causing
the exit time destructor warning. Getting rid of the OwnPtr fixed
the problem. Since the pointer that was being wrapped was to a
static object that would never get destroyed, the OwnPtr was not
necessary.

I also added the ACCELERATED_2D_CANVAS flag to build-webkit
and FeatureDefines.xcconfig for WebCore, WebKit and JavaScriptCore.
But right now the flag is off by default.

10:36 AM Changeset in webkit [68801] by kbr@google.com
  • 11 edits in trunk

2010-09-29 Kenneth Russell <kbr@google.com>

Reviewed by Dimitri Glazkov.

[chromium] Add accelerated compositing support to DumpRenderTree and test_shell
https://bugs.webkit.org/show_bug.cgi?id=46849

Added offscreen code path for WebGraphicsContext3DDefaultImpl which
works with the compositor integration in both DumpRenderTree and
test_shell, since both pass a non-null WebCanvas* to WebViewImpl::paint
and thereby trigger the compositor's readback code path. Added support
for --enable-accelerated-compositing to DumpRenderTree.

Tested in both test_shell and DumpRenderTree on Linux, the latter by
modifying a compositing layout test, dumping the pixels and verifying
that they matched the output when the compositor was active.

  • src/WebGraphicsContext3DDefaultImpl.cpp: (WebKit::WebGraphicsContext3DDefaultImpl::WebGraphicsContext3DDefaultImpl): (WebKit::WebGraphicsContext3DDefaultImpl::initialize): (WebKit::WebGraphicsContext3DDefaultImpl::resolveMultisampledFramebuffer): (WebKit::WebGraphicsContext3DDefaultImpl::getPlatformTextureId): (WebKit::WebGraphicsContext3DDefaultImpl::prepareTexture): (WebKit::WebGraphicsContext3DDefaultImpl::readBackFramebuffer): (WebKit::WebGraphicsContext3DDefaultImpl::copyTexImage2D): (WebKit::WebGraphicsContext3DDefaultImpl::copyTexSubImage2D): (WebKit::WebGraphicsContext3DDefaultImpl::readPixels):
  • src/WebGraphicsContext3DDefaultImpl.h:

2010-09-29 Kenneth Russell <kbr@google.com>

Reviewed by Dimitri Glazkov.

[chromium] Add accelerated compositing support to DumpRenderTree and test_shell
https://bugs.webkit.org/show_bug.cgi?id=46849

Added offscreen code path for WebGraphicsContext3DDefaultImpl which
works with the compositor integration in both DumpRenderTree and
test_shell, since both pass a non-null WebCanvas* to WebViewImpl::paint
and thereby trigger the compositor's readback code path. Added support
for --enable-accelerated-compositing to DumpRenderTree.

Tested in both test_shell and DumpRenderTree on Linux, the latter by
modifying a compositing layout test, dumping the pixels and verifying
that they matched the output when the compositor was active.

  • DumpRenderTree/chromium/DumpRenderTree.cpp: (main):
  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::TestShell): (TestShell::resetWebSettings):
  • DumpRenderTree/chromium/TestShell.h: (TestShell::setAcceleratedCompositingEnabled):
  • DumpRenderTree/chromium/WebPreferences.cpp: (WebPreferences::reset): (WebPreferences::applyTo):
  • DumpRenderTree/chromium/WebPreferences.h:
  • DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::scheduleComposite):
  • DumpRenderTree/chromium/WebViewHost.h:
10:35 AM Changeset in webkit [68800] by kevino@webkit.org
  • 2 edits in trunk

[wx] Fix typo in build script.

10:35 AM Changeset in webkit [68799] by kevino@webkit.org
  • 2 edits in trunk/JavaScriptCore

[wx] wxMSW build fix. Make sure we copy the compiler flags and remove exception handling from
the copy so as not to alter global settings.

10:23 AM Changeset in webkit [68798] by Adam Roben
  • 3 edits in trunk/LayoutTests

Make Windows match the Mac fallback font for the hyphen character in two tests

Fixes <http://webkit.org/b/46909> <rdar://problem/8497214> REGRESSION
(r68551): fast/text/midword-break-after-breakable-char.html and
fast/text/basic/014.html are failing on Windows

Rubber-stamped by Dan Bernstein.

  • fast/text/basic/014.html:
  • fast/text/midword-break-after-breakable-char.html:

Added a little @font-face magic to force the font for the hyphen
character.

10:21 AM Changeset in webkit [68797] by commit-queue@webkit.org
  • 4 edits
    70 adds in trunk

2010-09-30 Renata Hodovan <reni@inf.u-szeged.hu>

Reviewed by Dirk Schulze.

SVGFECompositeElement doesn't support dynamic invalidation, when attributes change.
https://bugs.webkit.org/show_bug.cgi?id=46902

Adding layout tests for feComposite dynamic changes.

  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-in-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-in-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.png: Added.
  • svg/dynamic-updates/SVGFECompositeElement-dom-in-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGFECompositeElement-dom-in-attr.html: Added.
  • svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr.html: Added.
  • svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr.html: Added.
  • svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr.html: Added.
  • svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr.html: Added.
  • svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr.html: Added.
  • svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr.html: Added.
  • svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop.html: Added.
  • svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop.html: Added.
  • svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop.html: Added.
  • svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop.html: Added.
  • svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop.html: Added.
  • svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop.html: Added.
  • svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop.html: Added.
  • svg/dynamic-updates/script-tests/SVGFECompositeElement-dom-in-attr.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFECompositeElement-dom-in2-attr.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFECompositeElement-dom-k1-attr.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFECompositeElement-dom-k2-attr.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFECompositeElement-dom-k3-attr.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFECompositeElement-dom-k4-attr.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFECompositeElement-dom-operator-attr.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFECompositeElement-svgdom-in-prop.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFECompositeElement-svgdom-in2-prop.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFECompositeElement-svgdom-k1-prop.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFECompositeElement-svgdom-k2-prop.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFECompositeElement-svgdom-k3-prop.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFECompositeElement-svgdom-k4-prop.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFECompositeElement-svgdom-operator-prop.js: Added. (executeTest):

2010-09-30 Renata Hodovan <reni@inf.u-szeged.hu>

Reviewed by Dirk Schulze.

SVGFECompositeElement doesn't support dynamic invalidation, when attributes change.
https://bugs.webkit.org/show_bug.cgi?id=46902

Tests: svg/dynamic-updates/SVGFECompositeElement-dom-in-attr.html

svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr.html
svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr.html
svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr.html
svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr.html
svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr.html
svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr.html
svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop.html
svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop.html
svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop.html
svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop.html
svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop.html
svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop.html
svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop.html

  • svg/SVGFECompositeElement.cpp: (WebCore::SVGFECompositeElement::svgAttributeChanged):
  • svg/SVGFECompositeElement.h:
10:16 AM Changeset in webkit [68796] by mitz@apple.com
  • 3 edits in trunk/WebKit/mac

Add printing SPI allowing full control over shrink-to-fit
https://bugs.webkit.org/show_bug.cgi?id=46877

Reviewed by John Sullivan.

  • WebView/WebHTMLView.mm:

(-[WebHTMLView _beginPrintModeWithMinimumPageWidth:height:maximumPageWidth:]): Added.

  • WebView/WebHTMLViewPrivate.h:
9:55 AM Changeset in webkit [68795] by jorlow@chromium.org
  • 79 edits in trunk

2010-09-29 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Steve Block.

Finished IDBTransaction for IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=46823

A bit of cleanup + use setVersion transactions for all of our work.

  • storage/indexeddb/database-basics.html:
  • storage/indexeddb/index-basics.html:
  • storage/indexeddb/index-cursor.html:
  • storage/indexeddb/objectstore-basics.html:
  • storage/indexeddb/objectstore-cursor.html:
  • storage/indexeddb/objectstore-removeobjectstore.html:
  • storage/indexeddb/open-cursor.html:
  • storage/indexeddb/transaction-basics.html:

2010-09-29 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Steve Block.

Finished IDBTransaction for IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=46823

Switch the rest of IndexedDB to use transactions.
Implement most of setVersion.
Add IDBTransactions to IDBAny, IDBCursor, IDBRequest, etc.
Switch to using the standard cross thread task stuff.
Make everything threadsafe so it works with cross thread copy

(will be useful in the future).

Fix some subtle bugs in transactions.

Various bits of clean up (when I couldn't resist).

  • bindings/js/JSIDBAnyCustom.cpp: (WebCore::toJS):
  • bindings/v8/IDBBindingUtilities.cpp: (WebCore::LocalContext::LocalContext): (WebCore::LocalContext::~LocalContext): (WebCore::createIDBKeyFromSerializedValueAndKeyPath):
  • bindings/v8/SerializedScriptValue.cpp: (WebCore::SerializedScriptValue::release): (WebCore::SerializedScriptValue::SerializedScriptValue):
  • bindings/v8/SerializedScriptValue.h:
  • bindings/v8/custom/V8IDBAnyCustom.cpp: (WebCore::toV8):
  • platform/CrossThreadCopier.cpp:
  • storage/IDBAny.cpp: (WebCore::IDBAny::idbFactory): (WebCore::IDBAny::idbTransaction): (WebCore::IDBAny::set):
  • storage/IDBAny.h:
  • storage/IDBCallbacks.h:
  • storage/IDBCursor.cpp: (WebCore::IDBCursor::IDBCursor): (WebCore::IDBCursor::update): (WebCore::IDBCursor::continueFunction): (WebCore::IDBCursor::remove):
  • storage/IDBCursor.h: (WebCore::IDBCursor::create):
  • storage/IDBCursorBackendImpl.cpp: (WebCore::IDBCursorBackendImpl::IDBCursorBackendImpl): (WebCore::IDBCursorBackendImpl::update): (WebCore::IDBCursorBackendImpl::updateInternal): (WebCore::IDBCursorBackendImpl::continueFunction): (WebCore::IDBCursorBackendImpl::continueFunctionInternal): (WebCore::IDBCursorBackendImpl::remove): (WebCore::IDBCursorBackendImpl::removeInternal):
  • storage/IDBCursorBackendImpl.h: (WebCore::IDBCursorBackendImpl::create):
  • storage/IDBDatabase.cpp: (WebCore::IDBDatabase::setSetVersionTransaction): (WebCore::IDBDatabase::createObjectStore): (WebCore::IDBDatabase::removeObjectStore): (WebCore::IDBDatabase::setVersion): (WebCore::IDBDatabase::close):
  • storage/IDBDatabase.h:
  • storage/IDBDatabase.idl:
  • storage/IDBDatabaseBackendImpl.cpp: (WebCore::IDBDatabaseBackendImpl::createObjectStore): (WebCore::IDBDatabaseBackendImpl::createObjectStoreInternal): (WebCore::IDBDatabaseBackendImpl::removeObjectStore): (WebCore::IDBDatabaseBackendImpl::removeObjectStoreInternal): (WebCore::IDBDatabaseBackendImpl::setVersion): (WebCore::IDBDatabaseBackendImpl::setVersionInternal): (WebCore::IDBDatabaseBackendImpl::close):
  • storage/IDBDatabaseBackendImpl.h:
  • storage/IDBDatabaseBackendInterface.h:
  • storage/IDBFactory.cpp: (WebCore::IDBFactory::open):
  • storage/IDBIndex.cpp: (WebCore::IDBIndex::IDBIndex): (WebCore::IDBIndex::openObjectCursor): (WebCore::IDBIndex::openCursor): (WebCore::IDBIndex::getObject): (WebCore::IDBIndex::get):
  • storage/IDBIndex.h: (WebCore::IDBIndex::create):
  • storage/IDBIndexBackendImpl.cpp: (WebCore::IDBIndexBackendImpl::openCursorInternal): (WebCore::IDBIndexBackendImpl::openObjectCursor): (WebCore::IDBIndexBackendImpl::openCursor): (WebCore::IDBIndexBackendImpl::getInternal): (WebCore::IDBIndexBackendImpl::getObject): (WebCore::IDBIndexBackendImpl::get):
  • storage/IDBIndexBackendImpl.h:
  • storage/IDBIndexBackendInterface.h:
  • storage/IDBKey.cpp: (WebCore::IDBKey::IDBKey):
  • storage/IDBKey.h:
  • storage/IDBKeyRange.h:
  • storage/IDBObjectStore.cpp: (WebCore::IDBObjectStore::IDBObjectStore): (WebCore::IDBObjectStore::add): (WebCore::IDBObjectStore::put): (WebCore::IDBObjectStore::remove): (WebCore::IDBObjectStore::createIndex): (WebCore::IDBObjectStore::index): (WebCore::IDBObjectStore::removeIndex): (WebCore::IDBObjectStore::openCursor):
  • storage/IDBObjectStore.idl:
  • storage/IDBObjectStoreBackendImpl.cpp: (WebCore::IDBObjectStoreBackendImpl::get): (WebCore::IDBObjectStoreBackendImpl::getInternal): (WebCore::IDBObjectStoreBackendImpl::put): (WebCore::IDBObjectStoreBackendImpl::putInternal): (WebCore::IDBObjectStoreBackendImpl::remove): (WebCore::IDBObjectStoreBackendImpl::removeInternal): (WebCore::IDBObjectStoreBackendImpl::createIndex): (WebCore::IDBObjectStoreBackendImpl::createIndexInternal): (WebCore::IDBObjectStoreBackendImpl::removeIndex): (WebCore::IDBObjectStoreBackendImpl::removeIndexInternal): (WebCore::IDBObjectStoreBackendImpl::openCursor): (WebCore::IDBObjectStoreBackendImpl::openCursorInternal):
  • storage/IDBObjectStoreBackendImpl.h:
  • storage/IDBObjectStoreBackendInterface.h:
  • storage/IDBRequest.cpp: (WebCore::IDBRequest::IDBRequest): (WebCore::IDBRequest::resetReadyState): (WebCore::IDBRequest::onSuccess): (WebCore::IDBRequest::timerFired):
  • storage/IDBRequest.h: (WebCore::IDBRequest::create):
  • storage/IDBTransactionBackendImpl.cpp: (WebCore::IDBTransactionBackendImpl::IDBTransactionBackendImpl): (WebCore::IDBTransactionBackendImpl::scheduleTask): (WebCore::IDBTransactionBackendImpl::didCompleteTaskEvents): (WebCore::IDBTransactionBackendImpl::run): (WebCore::IDBTransactionBackendImpl::start): (WebCore::IDBTransactionBackendImpl::commit): (WebCore::IDBTransactionBackendImpl::timerFired):
  • storage/IDBTransactionBackendImpl.h:

2010-09-29 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Steve Block.

Finished IDBTransaction for IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=46823

Plumbing.

  • public/WebIDBCallbacks.h: (WebKit::WebIDBCallbacks::onSuccess):
  • public/WebIDBDatabase.h: (WebKit::WebIDBDatabase::createObjectStore): (WebKit::WebIDBDatabase::removeObjectStore): (WebKit::WebIDBDatabase::close):
  • public/WebIDBIndex.h: (WebKit::WebIDBIndex::openObjectCursor): (WebKit::WebIDBIndex::openCursor): (WebKit::WebIDBIndex::getObject): (WebKit::WebIDBIndex::get):
  • public/WebIDBObjectStore.h: (WebKit::WebIDBObjectStore::get): (WebKit::WebIDBObjectStore::put): (WebKit::WebIDBObjectStore::remove): (WebKit::WebIDBObjectStore::createIndex): (WebKit::WebIDBObjectStore::removeIndex): (WebKit::WebIDBObjectStore::openCursor):
  • public/WebIDBTransaction.h: (WebKit::WebIDBTransaction::id): (WebKit::WebIDBTransaction::getIDBTransactionBackendInterface):
  • src/IDBCallbacksProxy.cpp: (WebCore::IDBCallbacksProxy::onSuccess):
  • src/IDBCallbacksProxy.h:
  • src/IDBDatabaseProxy.cpp: (WebCore::IDBDatabaseProxy::createObjectStore): (WebCore::IDBDatabaseProxy::removeObjectStore): (WebCore::IDBDatabaseProxy::close):
  • src/IDBDatabaseProxy.h:
  • src/IDBIndexBackendProxy.cpp: (WebCore::IDBIndexBackendProxy::openObjectCursor): (WebCore::IDBIndexBackendProxy::openCursor): (WebCore::IDBIndexBackendProxy::getObject): (WebCore::IDBIndexBackendProxy::get):
  • src/IDBIndexBackendProxy.h:
  • src/IDBObjectStoreProxy.cpp: (WebCore::IDBObjectStoreProxy::put): (WebCore::IDBObjectStoreProxy::remove): (WebCore::IDBObjectStoreProxy::createIndex): (WebCore::IDBObjectStoreProxy::removeIndex): (WebCore::IDBObjectStoreProxy::openCursor):
  • src/IDBObjectStoreProxy.h:
  • src/IDBTransactionBackendProxy.cpp: (WebCore::IDBTransactionBackendProxy::IDBTransactionBackendProxy):
  • src/WebIDBCallbacksImpl.cpp: (WebCore::WebIDBCallbacksImpl::onSuccess):
  • src/WebIDBCallbacksImpl.h:
  • src/WebIDBDatabaseImpl.cpp: (WebKit::WebIDBDatabaseImpl::createObjectStore): (WebKit::WebIDBDatabaseImpl::removeObjectStore): (WebKit::WebIDBDatabaseImpl::close):
  • src/WebIDBDatabaseImpl.h:
  • src/WebIDBIndexImpl.cpp: (WebKit::WebIDBIndexImpl::openCursor): (WebKit::WebIDBIndexImpl::openObjectCursor): (WebKit::WebIDBIndexImpl::getObject): (WebKit::WebIDBIndexImpl::get):
  • src/WebIDBIndexImpl.h:
  • src/WebIDBObjectStoreImpl.cpp: (WebKit::WebIDBObjectStoreImpl::put): (WebKit::WebIDBObjectStoreImpl::remove): (WebKit::WebIDBObjectStoreImpl::createIndex): (WebKit::WebIDBObjectStoreImpl::removeIndex): (WebKit::WebIDBObjectStoreImpl::openCursor):
  • src/WebIDBObjectStoreImpl.h:
9:46 AM Changeset in webkit [68794] by Adam Roben
  • 2 edits in trunk/LayoutTests

Skip a crashing test on Windows

  • platform/win/Skipped: Skip

fast/frames/iframe-reparenting-adopt-node.html. There's already a bug
filed about the issue.

9:40 AM Changeset in webkit [68793] by Adam Roben
  • 3 edits in trunk/WebKitTools

Ensure that QueueEngine cleans up its log files when its delegate tells it to stop processing work

Reviewed by Adam Barth.

Fixes <http://webkit.org/b/46891> <rdar://problem/8496638> Many tests
in webkitpy.tool.bot.queueengine_unittest.QueueEngineTest crash on
Windows

  • Scripts/webkitpy/tool/bot/queueengine.py:

(QueueEngine.run): Stop ourselves normally (including cleaning up log
files) when the delegate tells us to stop processing work.

  • Scripts/webkitpy/tool/bot/queueengine_unittest.py:

(LoggingDelegate.init): Moved code here from
RaisingDelegate.init.
(LoggingDelegate.expeced_callbacks): Added the stop_work_queue
callback.
(LoggingDelegate.stop_work_queue): Moved here from RaisingDelegate.
(RaisingDelegate.init): Removed code that LoggingDelegate takes
care of for us now.
(QueueEngineTest.test_trivial): Make sure we got the expected stop
message.
(QueueEngineTest.test_not_safe_to_proceed): Changed to explicitly
remove the callbacks that are related to processing a single work
item, rather than removing all callbacks after a certain point, as
there are now more callbacks we expect to receive at the end.

9:39 AM Changeset in webkit [68792] by Adam Roben
  • 2 edits in trunk/WebKitTools

Fix path -> URL conversion on Cygwin

Reviewed by Adam Barth.

Fixes <http://webkit.org/b/46890> <rdar://problem/8496637> Many tests
in webkitpy.layout_tests.run_webkit_tests_unittest assert on Windows

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.filename_to_uri): Treat Cygwin like other UNIX-y platforms by
assuming paths already have a leading slash.

9:31 AM Changeset in webkit [68791] by wsiegrist@apple.com
  • 1 edit in trunk/WebKitTools/BuildSlaveSupport/build.webkit.org-config/config.json

2010-09-30 William Siegrist <wsiegrist@apple.com>

Fix syntax error in r68744.

9:30 AM Changeset in webkit [68790] by wsiegrist@apple.com
  • 1 edit in trunk/WebKitTools/BuildSlaveSupport/build.webkit.org-config/master.cfg

2010-09-30 William Siegrist <wsiegrist@apple.com>

Set cache values for master.

9:16 AM Changeset in webkit [68789] by Adam Roben
  • 2 edits in trunk/LayoutTests

Skip a test that fails on Windows due to lack of SSL support

  • platform/win/Skipped: Added

http/tests/navigation/ping-cross-origin-from-https.html.

9:11 AM Changeset in webkit [68788] by kenneth@webkit.org
  • 2 edits in trunk/WebKit2

Original patch by Zalan Bujtas.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2010-09-30
Reviewed by Antti Koivisto.

The m_readBuffer might be smaller than the incoming message size and
thus result in memory corruption. Do a similar fix as the win port,
resizing the m_readBuffer to have room for the message.

  • Platform/CoreIPC/qt/ConnectionQt.cpp:

(CoreIPC::Connection::readyReadHandler):

8:45 AM Changeset in webkit [68787] by Csaba Osztrogonác
  • 2 edits in trunk/WebCore

2010-09-30 Csaba Osztrogonác <Csaba Osztrogonác>

Reviewed by Martin Robinson.

[Gtk] build still broken since r68521
https://bugs.webkit.org/show_bug.cgi?id=46795

makevalues.pl and makeprop.pl generate 3 files in one run.
Double or triple target is incorrect, because on a multicore
machine make processes targets in parallel.

Setting a->b->c dependencies for 3 generated files guarantees
that make doesn't execute the recipe of the rule more than one.

  • GNUmakefile.am: Dependencies and missing headers added.
8:39 AM Changeset in webkit [68786] by Adam Roben
  • 2 edits in trunk/LayoutTests

Rebaseline fast/layers/video-layer.html on Windows

Fixes <http://webkit.org/b/46903> <rdar://problem/8496933> REGRESSION
(r67251): fast/layers/video-layer.html failing on Windows

  • platform/win/fast/layers/video-layer-expected.txt:
8:18 AM Changeset in webkit [68785] by Adam Roben
  • 2 edits in trunk/WebKitTools

Teach WindowGeometryInitializedBeforeSetWindow that NPP_SetWindow can be called more than once

The NPP_SetWindow call made when the plugin is torn down was confusing
us, and was causing us to spew an error into the next test.

Fixes <http://webkit.org/b/46900> <rdar://problem/8496888> REGRESSION
(r68520): plugins/access-after-page-destroyed.html failing on Windows

Reviewed by Anders Carlsson.

  • DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowGeometryInitializedBeforeSetWindow.cpp:

(WindowGeometryInitializedBeforeSetWindow::WindowGeometryInitializedBeforeSetWindow):
Initialize member.
(WindowGeometryInitializedBeforeSetWindow::NPP_SetWindow): Bail if
this isn't the first time this is called.

7:55 AM Changeset in webkit [68784] by Adam Roben
  • 8 edits in trunk/LayoutTests

Rebaseline Windows results for recent-ish changes

  • platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/win/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/win/fast/dom/prototype-inheritance-expected.txt:
  • platform/win/fast/js/global-constructors-expected.txt:
  • platform/win/html5lib/runner-expected.txt:
6:50 AM Changeset in webkit [68783] by caseq@chromium.org
  • 1 edit in trunk/WebCore/WebCore.xcodeproj/project.pbxproj

Fixup for the previous commit that accidently only had ChangeLog.

6:44 AM Changeset in webkit [68782] by caseq@chromium.org
  • 1 edit in trunk/WebCore/ChangeLog

2010-09-30 Andrey Kosyakov <caseq@chromium.org>

Unreviewed build fix (marked ResourceRawHeaders.h as private).

  • WebCore.xcodeproj/project.pbxproj:
5:53 AM Changeset in webkit [68781] by caseq@chromium.org
  • 19 edits
    2 copies
    1 add in trunk

2010-09-29 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: display headers actually used by network stack in Resources tab
https://bugs.webkit.org/show_bug.cgi?id=46092

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::willSendRequest): enable raw headers reporting if front-end is visible.
  • inspector/InspectorResource.cpp: (WebCore::InspectorResource::updateResponse):
  • platform/network/ResourceRawHeaders.h: Added.
  • platform/network/ResourceRequestBase.h: Added flag to enable raw headers reporting. (WebCore::ResourceRequestBase::reportRawHeaders): (WebCore::ResourceRequestBase::setReportRawHeaders): (WebCore::ResourceRequestBase::ResourceRequestBase):
  • platform/network/ResourceResponseBase.cpp: Added support for raw headers. (WebCore::ResourceResponseBase::resourceRawHeaders): (WebCore::ResourceResponseBase::setResourceRawHeaders):
  • platform/network/ResourceResponseBase.h:

2010-09-29 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: display headers actually used by network stack in Resources tab
Added plumbing for raw headers flag and response field between chromium and WebCore.
https://bugs.webkit.org/show_bug.cgi?id=46092

  • WebKit.gyp:
  • public/WebResourceRawHeaders.h: Added.
  • public/WebURLRequest.h:
  • public/WebURLResponse.h:
  • src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::willSendRequest):
  • src/WebResourceRawHeaders.cpp: Added. (WebKit::WebResourceRawHeaders::WebResourceRawHeaders): (WebKit::WebResourceRawHeaders::~WebResourceRawHeaders): (WebKit::WebResourceRawHeaders::operator WTF::PassRefPtr<WebCore::ResourceRawHeaders>): (WebKit::addHeader): (WebKit::WebResourceRawHeaders::addRequestHeader): (WebKit::WebResourceRawHeaders::addResponseHeader):
  • src/WebURLRequest.cpp: (WebKit::WebURLRequest::setReportRawHeaders): (WebKit::WebURLRequest::reportRawHeaders):
  • src/WebURLResponse.cpp: (WebKit::WebURLResponse::resourceRawHeaders): (WebKit::WebURLResponse::setResourceRawHeaders):
  • src/WebURLResponsePrivate.h:
5:47 AM Changeset in webkit [68780] by andreas.kling@nokia.com
  • 4 edits in trunk

2010-09-30 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Tor Arne Vestbø.

[Qt] V8 port: Unbreak build

Add missing <wtf/text/CString.h> include.

  • WebCoreSupport/InspectorServerQt.cpp:

2010-09-30 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Tor Arne Vestbø.

[Qt] V8 port: Unbreak build

Add missing <wtf/text/CString.h> include.

  • loader/PingLoader.cpp:
5:45 AM Changeset in webkit [68779] by loislo@chromium.org
  • 4 edits in trunk/WebCore

2010-09-29 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: assign the resource loading finish time which was obtained from the network stack
as the end time for the corresponding event in Timeline.
See related change for Resources panel https://bugs.webkit.org/show_bug.cgi?id=45664

https://bugs.webkit.org/show_bug.cgi?id=46789

  • inspector/InspectorController.cpp: (WebCore::InspectorController::didFinishLoading): (WebCore::InspectorController::didFailLoading):
  • inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::didFinishLoadingResource):
  • inspector/InspectorTimelineAgent.h:
5:42 AM Changeset in webkit [68778] by pfeldman@chromium.org
  • 10 edits in trunk/WebCore

2010-09-29 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: implement sorting by timeline in network panel + filtering.
https://bugs.webkit.org/show_bug.cgi?id=45657

A number of drive-by fixes, sorting by timeline added,
0-based timeline for duration added, filters added,
more love for detailed view + nice headers.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/DataGrid.js: (WebInspector.DataGrid): (WebInspector.DataGrid.prototype.markColumnAsSortedBy): (WebInspector.DataGrid.prototype.headerTableHeader):
  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel): (WebInspector.NetworkPanel.prototype.get statusBarItems): (WebInspector.NetworkPanel.prototype._createTable): (WebInspector.NetworkPanel.prototype._makeHeaderInnerHTML): (WebInspector.NetworkPanel.prototype._createSortingFunctions): (WebInspector.NetworkPanel.prototype._sortByTimeline): (WebInspector.NetworkPanel.prototype._sortItems): (WebInspector.NetworkPanel.prototype._createFilterPanel): (WebInspector.NetworkPanel.prototype._showCategory): (WebInspector.NetworkPanel.prototype._hideCategory): (WebInspector.NetworkPanel.prototype._updateFilter): (WebInspector.NetworkPanel.prototype._filter): (WebInspector.NetworkPanel.prototype._updateDividersIfNeeded): (WebInspector.NetworkPanel.prototype.reset): (WebInspector.NetworkPanel.prototype._setLargerResources): (WebInspector.NetworkDataGridNode.prototype.createCells): (WebInspector.NetworkDataGridNode.prototype._createDivInTD): (WebInspector.NetworkDataGridNode.prototype._refreshURLCell): (WebInspector.NetworkDataGridNode.prototype._refreshStatusCell): (WebInspector.NetworkDataGridNode.prototype._appendSubtitle): (WebInspector.NetworkDataGridNode.SizeComparator): (WebInspector.NetworkDataGridNode.ResourcePropertyComparator):
  • inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel): (WebInspector.ProfilesPanel.prototype.updateMainViewWidth):
  • inspector/front-end/StoragePanel.js: (WebInspector.StoragePanel):
  • inspector/front-end/TimelineGrid.js: (WebInspector.TimelineGrid.prototype.updateDividers):
  • inspector/front-end/TimelineOverviewPane.js: (WebInspector.TimelineOverviewPane): (WebInspector.TimelineOverviewPane.prototype.updateMainViewWidth):
  • inspector/front-end/inspector.css: (.data-grid th.sort-ascending > div::after): (.data-grid th.sort-descending > div::after): (.status-bar-items):
  • inspector/front-end/networkPanel.css: (.network.panel .data-grid td): (.network.panel .data-grid th): (.network.panel .data-grid.small th): (.network.panel .data-grid .data-container): (.network.panel .data-grid.small .data-container): (.network.panel .data-grid select): (.network.panel .data-grid td.time-column): (.network-cell-subtitle): (.network-header-subtitle): (.network-event-divider): (.network.panel .network-timeline-grid.small .network-event-divider): (.network.panel .resources-dividers-label-bar): (.network.panel .network-timeline-grid.small .resources-dividers-label-bar): (.network.panel .resources-divider-label): (.network.panel .resources-dividers-label-bar .resources-divider): (.network.panel .network-timeline-grid.small .resources-dividers-label-bar .resources-divider): (.network.panel .resources-divider.first .resources-divider-label): (.network.panel .resources-dividers-label-bar .resources-divider.first): (#network-filter): (.data-grid table.data tr.revealed.network-category-websockets, .data-grid table.data tr.revealed.network-category-other): (.data-grid.filter-all table.data tr.revealed.network-category-other, .data-grid.filter-other table.data tr.revealed.network-category-other):
5:29 AM Changeset in webkit [68777] by vestbo@webkit.org
  • 3 edits in trunk/WebCore

[Qt] Ensure we always report a valid size for the video

Reviewed by Simon Hausmann.

Some QtMultimedia-backends require a paint before even giving us
a size, so we start out by using the default video size, and then
update it once QtMultimedia starts feeding us valid sizes.

  • platform/graphics/qt/MediaPlayerPrivateQt.cpp:

(WebCore::MediaPlayerPrivateQt::MediaPlayerPrivateQt):
(WebCore::MediaPlayerPrivateQt::nativeSizeChanged):
(WebCore::MediaPlayerPrivateQt::setSize):
(WebCore::MediaPlayerPrivateQt::naturalSize):

  • platform/graphics/qt/MediaPlayerPrivateQt.h:
5:04 AM Changeset in webkit [68776] by Nikolas Zimmermann
  • 1 edit in trunk/WebCore/ChangeLog

Correct reviewer, Andreas was faster!

5:03 AM Changeset in webkit [68775] by Nikolas Zimmermann
  • 3 edits in trunk/WebCore

2010-09-30 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

RenderSVGTextPath lacks isSVGTextPath() method
https://bugs.webkit.org/show_bug.cgi?id=46888

Make RenderSVGTextPath objects easily detectable, using a isSVGTextPath() method, like all other SVG renderers have.

  • rendering/RenderObject.h: (WebCore::RenderObject::isSVGTextPath): Return false.
  • rendering/RenderSVGTextPath.h: Changed indentation of whole file. (WebCore::RenderSVGTextPath::isSVGTextPath): Return true. (WebCore::RenderSVGTextPath::renderName): (WebCore::toRenderSVGTextPath): Add helper casting methods.
5:00 AM Changeset in webkit [68774] by vestbo@webkit.org
  • 2 edits in trunk/WebCore

[Qt] Ensure that the media player backend does not leave any resources around

Reviewed by Simon Hausmann.

  • platform/graphics/qt/MediaPlayerPrivateQt.cpp:

(WebCore::MediaPlayerPrivateQt::~MediaPlayerPrivateQt):

4:51 AM Changeset in webkit [68773] by Nikolas Zimmermann
  • 3 edits in trunk/WebCore

2010-09-30 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

AffineTransform should expose methods calculating the x/y scale factors
https://bugs.webkit.org/show_bug.cgi?id=46887

Expose methods calculating the x/y scale factors for an AffineTransform.

  • platform/graphics/transforms/AffineTransform.cpp: (WebCore::affineTransformDecompose): Move xScale / yScale calculations in their own functions. (WebCore::AffineTransform::xScale): (WebCore::AffineTransform::yScale):
  • platform/graphics/transforms/AffineTransform.h:
4:50 AM Changeset in webkit [68772] by vestbo@webkit.org
  • 2 edits in trunk/WebCore

Minor cleanup of MediaPlayerPrivateQt

Reviewed by Simon Hausmann.

  • platform/graphics/qt/MediaPlayerPrivateQt.cpp:

(WebCore::MediaPlayerPrivateQt::MediaPlayerPrivateQt):
(WebCore::MediaPlayerPrivateQt::currentTime):
(WebCore::MediaPlayerPrivateQt::positionChanged):
(WebCore::MediaPlayerPrivateQt::paint):

4:44 AM Changeset in webkit [68771] by commit-queue@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-09-30 Peter Varga <pvarga@inf.u-szeged.hu>

Reviewed by Gavin Barraclough.

The case-insensitivity backreference checking isn't working with YARR
Interpreter
https://bugs.webkit.org/show_bug.cgi?id=46882

Add ignorecase checking to the Interpreter::tryConsumeBackReference() function.

  • yarr/RegexInterpreter.cpp: (JSC::Yarr::Interpreter::tryConsumeBackReference):
3:29 AM Changeset in webkit [68770] by commit-queue@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-09-30 Kwang Yul Seo <skyul@company100.net>

Reviewed by Andreas Kling.

[BREWMP] Leave initializeRandomNumberGenerator empty.
https://bugs.webkit.org/show_bug.cgi?id=46851

On Brew MP, AEECLSID_RANDOM initializes itself.

  • wtf/RandomNumberSeed.h: (WTF::initializeRandomNumberGenerator):
2:36 AM Changeset in webkit [68769] by jochen@chromium.org
  • 3 edits in trunk/WebCore

2010-09-30 Jochen Eisinger <jochen@chromium.org>

Reviewed by Jeremy Orlow.

Mark unused parameters as such.
https://bugs.webkit.org/show_bug.cgi?id=46880

  • inspector/InspectorDOMAgent.cpp:
  • page/Geolocation.cpp: (WebCore::Geolocation::clearWatch):
2:26 AM Changeset in webkit [68768] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-09-30 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

webkit-patch upload warns that I'm using Xcode when I'm not
https://bugs.webkit.org/show_bug.cgi?id=46869

String.find returns -1 when not found, so switched to "in".

  • Scripts/webkitpy/common/system/user.py:
  • Scripts/webkitpy/common/system/user_unittest.py:
2:15 AM Changeset in webkit [68767] by podivilov@chromium.org
  • 15 edits
    2 adds in trunk/WebCore

2010-09-29 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: extract Inspector Instrumentation API as a class.
https://bugs.webkit.org/show_bug.cgi?id=46614

  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSXMLHttpRequestCustom.cpp: (WebCore::JSXMLHttpRequest::send):
  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp: (WebCore::V8XMLHttpRequest::sendCallback):
  • dom/CharacterData.cpp: (WebCore::CharacterData::dispatchModifiedEvent):
  • dom/ContainerNode.cpp: (WebCore::ContainerNode::insertBefore): (WebCore::ContainerNode::parserInsertBefore): (WebCore::ContainerNode::replaceChild): (WebCore::ContainerNode::appendChild): (WebCore::ContainerNode::parserAddChild): (WebCore::notifyChildInserted): (WebCore::dispatchChildRemovalEvents):
  • dom/Element.cpp: (WebCore::Element::setAttribute): (WebCore::Element::removeAttribute):
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::~InspectorController): (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::disconnectFrontend): (WebCore::InspectorController::instrumentWillSendXMLHttpRequest):
  • inspector/InspectorController.h:
  • inspector/InspectorInstrumentation.cpp: Added. (WebCore::InspectorInstrumentation::willInsertDOMNodeImpl): (WebCore::InspectorInstrumentation::didInsertDOMNodeImpl): (WebCore::InspectorInstrumentation::willRemoveDOMNodeImpl): (WebCore::InspectorInstrumentation::didRemoveDOMNodeImpl): (WebCore::InspectorInstrumentation::willModifyDOMAttrImpl): (WebCore::InspectorInstrumentation::didModifyDOMAttrImpl): (WebCore::InspectorInstrumentation::characterDataModifiedImpl): (WebCore::InspectorInstrumentation::instrumentWillSendXMLHttpRequestImpl):
  • inspector/InspectorInstrumentation.h: Added. (WebCore::InspectorInstrumentation::frontendCreated): (WebCore::InspectorInstrumentation::frontendDeleted): (WebCore::InspectorInstrumentation::hasFrontends): (WebCore::InspectorInstrumentation::willInsertDOMNode): (WebCore::InspectorInstrumentation::didInsertDOMNode): (WebCore::InspectorInstrumentation::willRemoveDOMNode): (WebCore::InspectorInstrumentation::willModifyDOMAttr): (WebCore::InspectorInstrumentation::didModifyDOMAttr): (WebCore::InspectorInstrumentation::characterDataModified): (WebCore::InspectorInstrumentation::instrumentWillSendXMLHttpRequest): (WebCore::InspectorInstrumentation::inspectorControllerForScriptExecutionContext): (WebCore::InspectorInstrumentation::inspectorControllerForDocument): (WebCore::InspectorInstrumentation::inspectorControllerForPage):
  • workers/SharedWorker.cpp:
2:12 AM Changeset in webkit [68766] by eric@webkit.org
  • 4 edits in trunk/WebKitTools

2010-09-30 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

webkit-patch failure-reason dies if non-trunk commits are in the blame range
https://bugs.webkit.org/show_bug.cgi?id=46866

I also made failure-reason use RegressionWindow in a cleaner way.

  • Scripts/webkitpy/tool/commands/queries.py:
1:50 AM Changeset in webkit [68765] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit/chromium

2010-09-30 Avi Drissman <avi@google.com>

Reviewed by Kenneth Russell.

[Chromium] Tabbing into page doesn't always select the first element
https://bugs.webkit.org/show_bug.cgi?id=46856

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::setInitialFocus):
1:37 AM Changeset in webkit [68764] by loki@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-09-30 Gabor Loki <loki@webkit.org>

Reviewed by Csaba Osztrogonác.

Remove unnecessary cacheFlush calls from Thumb-2
https://bugs.webkit.org/show_bug.cgi?id=46702

  • assembler/ARMv7Assembler.h: (JSC::ARMv7Assembler::relinkCall): (JSC::ARMv7Assembler::repatchInt32): (JSC::ARMv7Assembler::repatchPointer):
1:22 AM Changeset in webkit [68763] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-09-30 Kwang Yul Seo <skyul@company100.net>

Reviewed by Darin Adler.

Build fix: Add ENABLE(INSPECTOR) guard
https://bugs.webkit.org/show_bug.cgi?id=46852

Page does not have inspectorController() when ENABLE(INSPECTOR) is 0.

  • inspector/InspectorController.h: (WebCore::InspectorController::inspectorControllerForDocument):
12:48 AM Changeset in webkit [68762] by commit-queue@webkit.org
  • 22 edits
    1 copy in trunk/WebCore

2010-09-30 Michael Nordman <Michael Nordman>

Reviewed by David Levin.

Make it possible to copy platform specific data members of ResourceRequest and ResourceResponse
across threads and to compare platform specific data members of ResourceRequest.

  • Added two instance methods to the platform specific subclasses: doPlatformAdopt and doPlatformCopyData.
  • Also added a "shadowable" static method for platformCompare to ResourceRequestBase, a similar method is already present on ResourceResponseBase.
  • Converted the cross thread structs defined in ResourceRequest/ResponseBase.h to base classes and extended those base classes in the platform specific headers to provide a place to hold additional fields.
  • Used this mechanism to have the chromium port's data members make the hop. https://bugs.webkit.org/show_bug.cgi?id=46430

No new tests. Just plumbing.

  • WebCore.exp.in: removed the symbol for the now inlined == operator
  • WebCore.gypi: added chromium/ResourceResponse.cpp
  • platform/network/ResourceRequestBase.cpp: (WebCore::ResourceRequestBase::adopt): (WebCore::ResourceRequestBase::copyData): (WebCore::ResourceRequestBase::compare):
  • platform/network/ResourceRequestBase.h: (WebCore::ResourceRequestBase::platformCompare): (WebCore::operator==): (WebCore::operator!=):
  • platform/network/ResourceResponseBase.cpp: (WebCore::ResourceResponseBase::asResourceResponse): (WebCore::ResourceResponseBase::adopt): (WebCore::ResourceResponseBase::copyData):
  • platform/network/ResourceResponseBase.h:
  • platform/network/android/ResourceRequest.h: (WebCore::ResourceRequest::doPlatformCopyData): (WebCore::ResourceRequest::doPlatformAdopt):
  • platform/network/android/ResourceResponse.h: (WebCore::ResourceResponse::doPlatformCopyData): (WebCore::ResourceResponse::doPlatformAdopt):
  • platform/network/cf/ResourceRequest.h: (WebCore::ResourceRequest::doPlatformCopyData): (WebCore::ResourceRequest::doPlatformAdopt):
  • platform/network/cf/ResourceResponse.h: (WebCore::ResourceResponse::doPlatformCopyData): (WebCore::ResourceResponse::doPlatformAdopt):
  • platform/network/chromium/ResourceRequest.cpp: (WebCore::ResourceRequest::doPlatformCopyData): (WebCore::ResourceRequest::doPlatformAdopt):
  • platform/network/chromium/ResourceRequest.h:
  • platform/network/chromium/ResourceResponse.cpp: Added. (WebCore::ResourceResponse::doPlatformCopyData): (WebCore::ResourceResponse::doPlatformAdopt):
  • platform/network/chromium/ResourceResponse.h:
  • platform/network/curl/ResourceRequest.h: (WebCore::ResourceRequest::doPlatformCopyData): (WebCore::ResourceRequest::doPlatformAdopt):
  • platform/network/curl/ResourceResponse.h: (WebCore::ResourceResponse::doPlatformCopyData): (WebCore::ResourceResponse::doPlatformAdopt):
  • platform/network/mac/ResourceRequest.h: (WebCore::ResourceRequest::doPlatformCopyData): (WebCore::ResourceRequest::doPlatformAdopt):
  • platform/network/mac/ResourceResponse.h: (WebCore::ResourceResponse::doPlatformCopyData): (WebCore::ResourceResponse::doPlatformAdopt):
  • platform/network/qt/ResourceRequest.h: (WebCore::ResourceRequest::doPlatformCopyData): (WebCore::ResourceRequest::doPlatformAdopt):
  • platform/network/qt/ResourceResponse.h: (WebCore::ResourceResponse::doPlatformCopyData): (WebCore::ResourceResponse::doPlatformAdopt):
  • platform/network/soup/ResourceRequest.h: (WebCore::ResourceRequest::doPlatformCopyData): (WebCore::ResourceRequest::doPlatformAdopt):
  • platform/network/soup/ResourceResponse.h: (WebCore::ResourceResponse::doUpdateResourceResponse): (WebCore::ResourceResponse::doPlatformCopyData): (WebCore::ResourceResponse::doPlatformAdopt):
12:22 AM Changeset in webkit [68761] by benjamin.poulain@nokia.com
  • 4 edits in trunk/WebKit/qt

2010-09-30 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Andreas Kling.

[Qt] Crash if an scene with accelerated compositing layout during the paint event
https://bugs.webkit.org/show_bug.cgi?id=46812

Delay the deletion of the overlay after the current event is processed.

Removing the overlay can sometimes be done inside the rendering code of
the overlay itself. When the rendering code is using the reference after
the deletion of the overlay, WebKit crashes.

  • Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::overlay):
  • WebCoreSupport/PageClientQt.cpp: (WebCore::PageClientQGraphicsWidget::~PageClientQGraphicsWidget): (WebCore::PageClientQGraphicsWidget::createOrDeleteOverlay):
  • WebCoreSupport/PageClientQt.h: (WebCore::PageClientQGraphicsWidget::PageClientQGraphicsWidget):
12:10 AM Changeset in webkit [68760] by benjamin.poulain@nokia.com
  • 2 edits in trunk/WebKit/qt

2010-09-30 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Andreas Kling.

[Qt] Fix tst_QWebPage::geolocationRequestJS()
https://bugs.webkit.org/show_bug.cgi?id=46814

Disable the test. This test cannot pass with a
standard build of WebKit, it is disabled until the API is finilized.

  • tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::geolocationRequestJS):
12:08 AM Changeset in webkit [68759] by commit-queue@webkit.org
  • 2 edits
    1 move in trunk/WebKit/chromium

2010-09-30 Alexey Marinichev <amarinichev@chromium.org>

Reviewed by Kenneth Russell.

Rename chromium's GraphicsContext3D.cpp to match others.
https://bugs.webkit.org/show_bug.cgi?id=46771

  • WebKit.gyp:
  • src/GraphicsContext3DChromium.cpp: Renamed from WebKit/chromium/src/GraphicsContext3D.cpp.

Sep 29, 2010:

11:52 PM Changeset in webkit [68758] by commit-queue@webkit.org
  • 2 edits
    2 adds in trunk/LayoutTests

2010-09-29 W. James MacLean <wjmaclean@chromium.org>

Reviewed by James Robinson.

Rebaseline image-rescale.svg results for chromium-win
https://bugs.webkit.org/show_bug.cgi?id=46818

  • platform/chromium-win/svg/custom/image-rescale-expected.checksum: Copied from LayoutTests/platform/chromium-linux/svg/custom/image-rescale-expected.checksum.
  • platform/chromium-win/svg/custom/image-rescale-expected.png: Copied from LayoutTests/platform/chromium-linux/svg/custom/image-rescale-expected.png.
  • platform/chromium/test_expectations.txt:
11:49 PM Changeset in webkit [68757] by crogers@google.com
  • 3 edits in trunk/WebCore

2010-09-29 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

Put default initialize() and uninitialize() methods in AudioNode
https://bugs.webkit.org/show_bug.cgi?id=46767

No new tests since audio API is not yet implemented.

  • webaudio/AudioNode.cpp: (WebCore::AudioNode::initialize): (WebCore::AudioNode::uninitialize):
  • webaudio/AudioNode.h:
11:34 PM Changeset in webkit [68756] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2010-09-29 Adam Barth <abarth@webkit.org>

Unreviewed. See comments in the Skipped file.

  • platform/mac/Skipped:
11:29 PM Changeset in webkit [68755] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-09-29 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

webkit-patch find-flaky-tests
https://bugs.webkit.org/show_bug.cgi?id=46876

This command helps us find flaky tests so we can squash them.

  • Scripts/webkitpy/tool/commands/queries.py:
11:26 PM Changeset in webkit [68754] by bweinstein@apple.com
  • 2 edits in trunk/LayoutTests

Skip plugins/plugin-document-load-prevented-userscript.html on Qt, because it doesn't
support window.layoutTestController.addUserScript yet.

Rubber-stamped by Adam Barth.

  • platform/qt/Skipped:
11:24 PM Changeset in webkit [68753] by alex
  • 2 edits in trunk/LayoutTests

2010-09-29 Alejandro G. Castro <alex@igalia.com>

Unreviewed, LayoutTestController::addUserScript not supported in
GTK+, skip plugin-document-load-prevented-userscript.html.

  • platform/gtk/Skipped:
10:56 PM Changeset in webkit [68752] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2010-09-29 MORITA Hajime <morrita@google.com>

Unreviewed, updated test_expectations.txt

  • platform/chromium/test_expectations.txt:
10:27 PM Changeset in webkit [68751] by Simon Fraser
  • 2 edits in trunk/WebKitTools

2010-09-29 Simon Fraser <Simon Fraser>

Fix export to use '?' instead of 'null' for
tests with no results.

  • CSSTestSuiteHarness/harness/harness.js:
9:41 PM Changeset in webkit [68750] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2010-09-29 MORITA Hajime <morrita@google.com>

Unreviewed, updated test_expectations.txt

  • platform/chromium/test_expectations.txt:
9:22 PM Changeset in webkit [68749] by tkent@chromium.org
  • 6 edits in trunk

2010-09-29 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

Refactor HTMLInputElement: Make DeprecatedInputType private.
https://bugs.webkit.org/show_bug.cgi?id=46791

No new tests because this doesn't change any behavior.

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::createTypeMap):
  • html/HTMLInputElement.h: Move DeprecatedInputType, deprecatedInputType() and parseToDateComponents() to the private section, make createTypeMap() a member function of HTMLInputElement. (WebCore::HTMLInputElement::deprecatedInputType):

2010-09-29 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

Refactor HTMLInputElement: Make DeprecatedInputType private.
https://bugs.webkit.org/show_bug.cgi?id=46791

  • src/WebPasswordFormUtils.cpp: (WebKit::findPasswordFormFields): Accept any text field types as a username field.
  • src/WebSearchableFormData.cpp: (WebCore::HasSuitableTextElement): Accept any text field types as a search query field.
9:14 PM Changeset in webkit [68748] by Simon Fraser
  • 4 edits in trunk/WebKitTools

2010-09-29 Simon Fraser <Simon Fraser>

Add a warning when a test requires special steps.
Add a Print Preview button for 'paged' tests that
brings up the print dialog, allowing the user to
judge paged media tests.

  • CSSTestSuiteHarness/harness/harness.css:
  • CSSTestSuiteHarness/harness/harness.html:
  • CSSTestSuiteHarness/harness/harness.js: (TestSuite.prototype.loadTest): (TestSuite.prototype.processFlags):
9:07 PM Changeset in webkit [68747] by abarth@webkit.org
  • 4 edits in trunk/WebKitTools

2010-09-29 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Remove revisions_casuing_failures
https://bugs.webkit.org/show_bug.cgi?id=46872

This function exists only to be unit tested.

  • Scripts/webkitpy/common/net/failuremap.py:
  • Scripts/webkitpy/common/net/failuremap_unittest.py:
  • Scripts/webkitpy/tool/mocktool.py:
8:57 PM Changeset in webkit [68746] by abarth@webkit.org
  • 12 edits in trunk/WebKitTools

2010-09-29 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

SheriffBot should post the list of failing tests to bugs
https://bugs.webkit.org/show_bug.cgi?id=46871

  • Scripts/webkitpy/common/net/buildbot.py:
  • Scripts/webkitpy/common/net/failuremap.py:
  • Scripts/webkitpy/common/net/regressionwindow.py:
  • Scripts/webkitpy/tool/bot/sheriff.py:
  • Scripts/webkitpy/tool/bot/sheriff_unittest.py:
  • Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
  • Scripts/webkitpy/tool/commands/sheriffbot.py:
  • Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
  • Scripts/webkitpy/tool/commands/upload_unittest.py:
  • Scripts/webkitpy/tool/mocktool.py:
8:42 PM Changeset in webkit [68745] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2010-09-29 Eric Seidel <eric@webkit.org>

Unreviewed. Skipping crashing test to green the tree.
This crash started when I skipped some canvas tests
as part of rolling out r68568.

fast/canvas/webgl/draw-elements-out-of-bounds.html is crashing on Snow Leopard
https://bugs.webkit.org/show_bug.cgi?id=46870

  • platform/mac-snowleopard/Skipped:
8:33 PM Changeset in webkit [68744] by bfulgham@webkit.org
  • 5 edits in trunk/WebKitTools

[WinCairo] Adds a build slave.
https://bugs.webkit.org/show_bug.cgi?id=46360

Patch by Brent Fulgham <bfulgham@webkit.org> on 2010-09-29
Reviewed by Martin Robinson, Eric Seidel, and Mark Rowe.

  • BuildSlaveSupport/build.webkit.org-config/config.json: Add

entries for a debug build of the WinCairo port.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg: Add

platform flag to configuration for wincairo (like gtk, chromium, etc.)

  • Scripts/build-webkit: Change 'cairo-win32' labeling to 'wincairo'
  • Scripts/webkitdirs.pm: Change 'cairo-win32' labeling to 'wincairo'
8:27 PM Changeset in webkit [68743] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2010-09-29 MORITA Hajime <morrita@google.com>

Unreviewed, updated test_expectations.txt

  • platform/chromium/test_expectations.txt:
8:06 PM Changeset in webkit [68742] by mihaip@chromium.org
  • 5 edits
    4 adds in trunk

2010-09-29 Mihai Parparita <mihaip@chromium.org>

Reviewed by Darin Fisher.

REGRESSION: page reload on back button after history.pushState with appearing/disappearing iframes
https://bugs.webkit.org/show_bug.cgi?id=46324

Add test which uses pushState to generate history entries while also
changing the frames that are present in the document between history
states. Add a similar test that uses fragment changes.

  • fast/history/same-document-iframes-changing-fragment-expected.txt: Added.
  • fast/history/same-document-iframes-changing-fragment.html: Added.
  • fast/history/same-document-iframes-changing-pushstate-expected.txt: Added.
  • fast/history/same-document-iframes-changing-pushstate.html: Added.

2010-09-29 Mihai Parparita <mihaip@chromium.org>

Reviewed by Darin Fisher.

REGRESSION: page reload on back button after history.pushState with appearing/disappearing iframes
https://bugs.webkit.org/show_bug.cgi?id=46324

Revert same document check to the way it was before r66238 for history
entries created by pushState or fragment changes. Logic fror determining
if same document navigation should be used is moved to HistoryItem.

Tests: fast/history/same-document-iframes-changing-fragment.html

fast/history/same-document-iframes-changing-pushstate.html

  • history/HistoryItem.cpp: (WebCore::HistoryItem::shouldDoSameDocumentNavigationTo): (WebCore::HistoryItem::hasSameDocumentTree): (WebCore::HistoryItem::hasSameFrames):
  • history/HistoryItem.h:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::loadItem):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::loadItem):
8:01 PM Changeset in webkit [68741] by kinuko@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-09-29 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by Dumitru Daniliuc.

Add removeRecursively to WebKit WebFileSystem API
https://bugs.webkit.org/show_bug.cgi?id=46842

  • public/WebFileSystem.h: (WebKit::WebFileSystem::removeRecursively): Added.
7:53 PM Changeset in webkit [68740] by abarth@webkit.org
  • 7 edits
    1 add in trunk/WebKitTools

2010-09-29 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Move more SheriffBot smarts into FailureMap
https://bugs.webkit.org/show_bug.cgi?id=46703

This patch pushes the FailureMap model object further into the
SheriffBot machine. In addition, it moves a couple operations on this
object from SheriffBot itself to the model.

Eventually, FailureMap will be the canonical context object for
SheriffBot operations. FailureMap represents a map of the current
failures on the bots that might require remediation.

  • Scripts/webkitpy/common/net/failuremap.py:
  • Scripts/webkitpy/common/net/regressionwindow.py:
  • Scripts/webkitpy/tool/commands/queries.py:
  • Scripts/webkitpy/tool/commands/sheriffbot.py:
  • Scripts/webkitpy/tool/mocktool.py:
7:49 PM Changeset in webkit [68739] by abarth@webkit.org
  • 1 edit
    1 copy
    1 move in trunk/LayoutTests

2010-09-29 Adam Barth <abarth@webkit.org>

This test result seems to be platform specific.

  • platform/mac-leopard/plugins/plugin-initiate-popup-window-expected.txt: Renamed from LayoutTests/plugins/plugin-initiate-popup-window-expected.txt.
  • platform/mac/plugins/plugin-initiate-popup-window-expected.txt: Added.
7:34 PM Changeset in webkit [68738] by morrita@google.com
  • 2 edits in trunk/WebCore

2010-09-29 MORITA Hajime <morrita@google.com>

Unreviewed build fix.

WebCore::ESpeak causes missing symbol with no ENABLE_SVG
https://bugs.webkit.org/show_bug.cgi?id=46865

Moves ESpeak related function definitions outside ENABLE_SVG block.

  • css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): (WebCore::CSSPrimitiveValue::operator ESpeak): (WebCore::CSSPrimitiveValue::operator EVectorEffect):
7:24 PM Changeset in webkit [68737] by eric@webkit.org
  • 71 edits in trunk/LayoutTests

2010-09-29 Eric Seidel <eric@webkit.org>

Unreviewed, rolling out r68568.
http://trac.webkit.org/changeset/68568
https://bugs.webkit.org/show_bug.cgi?id=46439

Failing tests on both Leopard and Snow Leopard

  • canvas/philip/tests/2d.composite.operation.darker-expected.txt:
  • canvas/philip/tests/2d.composite.operation.highlight-expected.txt:
  • canvas/philip/tests/2d.composite.uncovered.fill.copy-expected.txt:
  • canvas/philip/tests/2d.composite.uncovered.fill.destination-atop-expected.txt:
  • canvas/philip/tests/2d.composite.uncovered.fill.destination-in-expected.txt:
  • canvas/philip/tests/2d.composite.uncovered.fill.source-in-expected.txt:
  • canvas/philip/tests/2d.composite.uncovered.fill.source-out-expected.txt:
  • canvas/philip/tests/2d.composite.uncovered.image.copy-expected.txt:
  • canvas/philip/tests/2d.composite.uncovered.image.destination-atop-expected.txt:
  • canvas/philip/tests/2d.composite.uncovered.image.destination-in-expected.txt:
  • canvas/philip/tests/2d.composite.uncovered.image.source-in-expected.txt:
  • canvas/philip/tests/2d.composite.uncovered.image.source-out-expected.txt:
  • canvas/philip/tests/2d.composite.uncovered.pattern.copy-expected.txt:
  • canvas/philip/tests/2d.composite.uncovered.pattern.destination-atop-expected.txt:
  • canvas/philip/tests/2d.composite.uncovered.pattern.destination-in-expected.txt:
  • canvas/philip/tests/2d.composite.uncovered.pattern.source-in-expected.txt:
  • canvas/philip/tests/2d.composite.uncovered.pattern.source-out-expected.txt:
  • canvas/philip/tests/2d.drawImage.incomplete-expected.txt:
  • canvas/philip/tests/2d.drawImage.null-expected.txt:
  • canvas/philip/tests/2d.fillStyle.parse.current.basic-expected.txt:
  • canvas/philip/tests/2d.fillStyle.parse.current.changed-expected.txt:
  • canvas/philip/tests/2d.fillStyle.parse.current.removed-expected.txt:
  • canvas/philip/tests/2d.fillStyle.parse.system-expected.txt:
  • canvas/philip/tests/2d.gradient.radial.cone.front-expected.txt:
  • canvas/philip/tests/2d.gradient.radial.cone.top-expected.txt:
  • canvas/philip/tests/2d.gradient.radial.inside2-expected.txt:
  • canvas/philip/tests/2d.gradient.radial.inside3-expected.txt:
  • canvas/philip/tests/2d.gradient.radial.negative-expected.txt:
  • canvas/philip/tests/2d.gradient.radial.outside1-expected.txt:
  • canvas/philip/tests/2d.imageData.create1.type-expected.txt:
  • canvas/philip/tests/2d.imageData.create2.type-expected.txt:
  • canvas/philip/tests/2d.imageData.get.source.negative-expected.txt:
  • canvas/philip/tests/2d.imageData.get.type-expected.txt:
  • canvas/philip/tests/2d.line.cap.closed-expected.txt:
  • canvas/philip/tests/2d.line.join.parallel-expected.txt:
  • canvas/philip/tests/2d.line.miter.lineedge-expected.txt:
  • canvas/philip/tests/2d.missingargs-expected.txt:
  • canvas/philip/tests/2d.path.rect.winding-expected.txt:
  • canvas/philip/tests/2d.pattern.image.broken-expected.txt:
  • canvas/philip/tests/2d.pattern.image.incomplete-expected.txt:
  • canvas/philip/tests/2d.pattern.image.null-expected.txt:
  • canvas/philip/tests/2d.pattern.image.undefined-expected.txt:
  • canvas/philip/tests/2d.shadow.enable.blur-expected.txt:
  • canvas/philip/tests/2d.shadow.enable.x-expected.txt:
  • canvas/philip/tests/2d.shadow.enable.y-expected.txt:
  • canvas/philip/tests/2d.shadow.gradient.alpha-expected.txt:
  • canvas/philip/tests/2d.shadow.gradient.basic-expected.txt:
  • canvas/philip/tests/2d.shadow.gradient.transparent.2-expected.txt:
  • canvas/philip/tests/2d.strokeRect.zero.4-expected.txt:
  • canvas/philip/tests/2d.text.draw.baseline.bottom-expected.txt:
  • canvas/philip/tests/2d.text.draw.baseline.hanging-expected.txt:
  • canvas/philip/tests/2d.text.draw.baseline.ideographic-expected.txt:
  • canvas/philip/tests/2d.text.draw.baseline.middle-expected.txt:
  • canvas/philip/tests/2d.text.draw.baseline.top-expected.txt:
  • canvas/philip/tests/2d.text.draw.fill.maxWidth.fontface-expected.txt:
  • canvas/philip/tests/2d.text.draw.space.collapse.end-expected.txt:
  • canvas/philip/tests/2d.text.draw.space.collapse.nonspace-expected.txt:
  • canvas/philip/tests/2d.text.draw.space.collapse.other-expected.txt:
  • canvas/philip/tests/2d.text.draw.space.collapse.space-expected.txt:
  • canvas/philip/tests/2d.text.draw.space.collapse.start-expected.txt:
  • canvas/philip/tests/2d.text.font.parse.basic-expected.txt:
  • canvas/philip/tests/2d.text.font.parse.complex-expected.txt:
  • canvas/philip/tests/2d.text.font.parse.invalid-expected.txt:
  • canvas/philip/tests/2d.text.font.parse.size.percentage-expected.txt:
  • canvas/philip/tests/2d.text.font.parse.size.percentage.default-expected.txt:
  • canvas/philip/tests/2d.text.font.parse.system-expected.txt:
  • canvas/philip/tests/2d.text.measure.width.space-expected.txt:
  • canvas/philip/tests/toDataURL.jpeg.alpha-expected.txt:
  • canvas/philip/tests/type.prototype-expected.txt:
  • platform/mac/Skipped:
6:27 PM Changeset in webkit [68736] by crogers@google.com
  • 1 edit
    3 adds in trunk/WebCore

2010-09-29 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

Add AudioChannelSplitter files
https://bugs.webkit.org/show_bug.cgi?id=46290

No new tests since audio API is not yet implemented.

  • webaudio/AudioChannelSplitter.cpp: Added. (WebCore::AudioChannelSplitter::AudioChannelSplitter): (WebCore::AudioChannelSplitter::process): (WebCore::AudioChannelSplitter::reset):
  • webaudio/AudioChannelSplitter.h: Added. (WebCore::AudioChannelSplitter::create):
  • webaudio/AudioChannelSplitter.idl: Added.
6:16 PM Changeset in webkit [68735] by kinuko@chromium.org
  • 15 edits
    5 adds in trunk

2010-09-29 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by David Levin.

Fix DirectoryReader's behavior to trigger only one EntriesCallback per readEntries
https://bugs.webkit.org/show_bug.cgi?id=46563

  • src/WebFileSystemCallbacksImpl.cpp: (WebKit::WebFileSystemCallbacksImpl::didReadDirectory):

2010-09-29 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by David Levin.

Fix DirectoryReader's behavior to trigger only one EntriesCallback per readEntries
https://bugs.webkit.org/show_bug.cgi?id=46563

Test: fast/filesystem/read-directory.html

  • fileapi/DOMFileSystem.cpp: (WebCore::DOMFileSystem::readDirectory): Changed to take DirectoryReader as a parameter.
  • fileapi/DOMFileSystem.h: (WebCore::DOMFileSystem::scheduleCallback): Added.
  • fileapi/DirectoryReader.cpp: (WebCore::DirectoryReader::DirectoryReader): Added initializer for m_hasMore flag. (WebCore::DirectoryReader::readEntries): Changed to schedule EntriesCallback with an empty array if m_hasMore flag is set false.
  • fileapi/DirectoryReader.h: (WebCore::DirectoryReader::filesystem): Added. (WebCore::DirectoryReader::setHasMore): Added.
  • fileapi/FileSystemCallbacks.cpp: (WebCore::EntriesCallbacks::create): (WebCore::EntriesCallbacks::EntriesCallbacks): Changed to take DirectoryReader as a parameter. (WebCore::EntriesCallbacks::didReadDirectoryEntry): (WebCore::EntriesCallbacks::didReadDirectoryEntries): Changed 1) not to trigger the second callback when hasMore is false, and 2) to update the DirectoryReader's m_hasMore flag.
  • fileapi/FileSystemCallbacks.h:

2010-09-29 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by David Levin.

Fix DirectoryReader's behavior to trigger only one EntriesCallback per readEntries
https://bugs.webkit.org/show_bug.cgi?id=46563

  • fast/filesystem/flags-passing.html: Updated to make it match with the updated TEMPLATE.html.
  • fast/filesystem/flags-passing-expected.txt: Updated.
  • fast/filesystem/read-directory.html: Added.
  • fast/filesystem/read-directory-expected.txt: Added.
  • fast/filesystem/resources/fs-test-util.js: Added for common test utilities.
  • fast/filesystem/script-tests/TEMPLATE.html: Updated to include fs-test-util.js.
  • fast/filesystem/script-tests/flags-passing.js: Updated to use jsTestIsAsync and finishJSTest (so that all the tests look alike).
  • fast/filesystem/script-tests/read-directory.js: Added.
6:12 PM Changeset in webkit [68734] by crogers@google.com
  • 1 edit
    3 adds in trunk/WebCore

2010-09-29 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

Add AudioGainNode files
https://bugs.webkit.org/show_bug.cgi?id=46286

No new tests since audio API is not yet implemented.

  • webaudio/AudioGainNode.cpp: Added. (WebCore::AudioGainNode::AudioGainNode): (WebCore::AudioGainNode::process): (WebCore::AudioGainNode::reset): (WebCore::AudioGainNode::checkNumberOfChannelsForInput):
  • webaudio/AudioGainNode.h: Added. (WebCore::AudioGainNode::create): (WebCore::AudioGainNode::gain):
  • webaudio/AudioGainNode.idl: Added.
6:07 PM Changeset in webkit [68733] by morrita@google.com
  • 3 edits in trunk/LayoutTests

2010-09-29 MORITA Hajime <morrita@google.com>

Unreviewed, updated expectations.

  • platform/chromium-mac/plugins/netscape-plugin-property-access-exception-expected.txt:
  • platform/chromium-win/plugins/netscape-plugin-property-access-exception-expected.txt:
5:55 PM Changeset in webkit [68732] by crogers@google.com
  • 1 edit
    3 adds in trunk/WebCore

2010-09-29 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

Add AudioChannelMerger files
https://bugs.webkit.org/show_bug.cgi?id=46291

No new tests since audio API is not yet implemented.

  • webaudio/AudioChannelMerger.cpp: Added. (WebCore::AudioChannelMerger::AudioChannelMerger): (WebCore::AudioChannelMerger::process): (WebCore::AudioChannelMerger::reset):
  • webaudio/AudioChannelMerger.h: Added. (WebCore::AudioChannelMerger::create):
  • webaudio/AudioChannelMerger.idl: Added.
5:45 PM Changeset in webkit [68731] by andersca@apple.com
  • 2 edits in trunk/WebKit2

Calling Connection::send/sendSync from Connection::Client::didClose should always fail
https://bugs.webkit.org/show_bug.cgi?id=46859
<rdar://problem/8212583>

Reviewed by Simon Fraser.

  • Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::dispatchConnectionDidClose):

5:31 PM Changeset in webkit [68730] by Chris Fleizach
  • 2 edits in trunk/WebCore

No review. Missed file for patch.

AX: implement CSS3 Speech "speak"
https://bugs.webkit.org/show_bug.cgi?id=46827

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

5:30 PM Changeset in webkit [68729] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533.19-branch

Merge r68340.

5:14 PM Changeset in webkit [68728] by Chris Fleizach
  • 4 edits in trunk/LayoutTests

No review. Update layout tests after new CSS property.

AX: implement CSS3 Speech "speak"
https://bugs.webkit.org/show_bug.cgi?id=46827

  • platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • svg/css/getComputedStyle-basic-expected.txt:
5:11 PM Changeset in webkit [68727] by enrica@apple.com
  • 2 edits in trunk/WebCore

Crash at lineBreakExistsAtPosition + 125
<rdar://problem/7028809>
https://bugs.webkit.org/show_bug.cgi?id=46770

Reviewed by Darin Adler.

lineBreakExistsAtPosition is called from InsertTextCommand::input,
where we compute the downstream position of the endingSelection().
Downstream can return the original position, that comes from a VisibleSelection
but there is no guarantee that its renderer is still there. Everywhere we dereference
a renderer we check if it's null.

There is no regression test.

  • editing/htmlediting.cpp:

(WebCore::lineBreakExistsAtPosition): Added check that the renderer is not null
before dereferencing it.

5:10 PM Changeset in webkit [68726] by Simon Fraser
  • 2 edits in trunk/WebKit2

2010-09-29 Simon Fraser <Simon Fraser>

Reviewed by Anders Carlsson.

Assertion then crash closing WebKit2 window with accelerated compositing in
https://bugs.webkit.org/show_bug.cgi?id=46857

Fix two issues when closing a WebKit2 window using accelerated
compositing.

The first is that the response to the sync DidChangeAcceleratedCompositing message
sent by changeAcceleratedCompositingMode() may be empty, because the corresponding
page may have been destroyed already in the UI process. In that case newDrawingAreaInfo
is not filled in, so we get a DrawingArea::Type of None. Don't attempt to make a new
drawing area in that case.

We then have to null-check the drawing area in WebPage::didReceiveMessage(),
in the case where the UI process is calling back with a SuspendPainting message,
before our page has gone away.

  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::changeAcceleratedCompositingMode): (WebKit::WebPage::didReceiveMessage):
5:10 PM Changeset in webkit [68725] by mrowe@apple.com
  • 6 edits
    2 adds in branches/safari-533.19-branch

Merge r66028.

5:08 PM Changeset in webkit [68724] by mrowe@apple.com
  • 3 edits in branches/safari-533.19-branch/WebCore

Merge r67288.

5:08 PM Changeset in webkit [68723] by mrowe@apple.com
  • 2 edits in branches/safari-533.19-branch/WebCore

Merge r67286.

5:08 PM Changeset in webkit [68722] by mrowe@apple.com
  • 9 edits
    2 adds in branches/safari-533.19-branch

Merge r67285.

5:00 PM Changeset in webkit [68721] by mrowe@apple.com
  • 2 edits in branches/safari-533.19-branch/WebCore

Merge r68278.

4:59 PM Changeset in webkit [68720] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533.19-branch

Merge r68158.

4:57 PM Changeset in webkit [68719] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533.19-branch

Merge r68485.

4:55 PM Changeset in webkit [68718] by mrowe@apple.com
  • 4 edits
    2 adds in branches/safari-533.19-branch

Merge r68408.

4:52 PM Changeset in webkit [68717] by mrowe@apple.com
  • 6 edits
    3 adds in branches/safari-533.19-branch

Merge r64780.

4:52 PM Changeset in webkit [68716] by andersca@apple.com
  • 5 edits in trunk

plugins/npruntime/invoke-failure.html fails in WebKit2 due to slightly different exception being thrown
https://bugs.webkit.org/show_bug.cgi?id=46715
<rdar://problem/8485909>

Reviewed by Darin Adler.

WebCore:

Remove exclamation points from exceptions.

  • bindings/v8/V8NPObject.cpp:

(WebCore::npObjectInvokeImpl):

  • bridge/c/c_instance.cpp:

(JSC::Bindings::CInstance::invokeMethod):
(JSC::Bindings::CInstance::invokeDefaultMethod):
(JSC::Bindings::CInstance::invokeConstruct):

LayoutTests:

Remove exclamation point.

  • plugins/npruntime/invoke-failure-expected.txt:
4:51 PM Changeset in webkit [68715] by weinig@apple.com
  • 4 edits in trunk/WebCore

Add additional checks to StringBuilder.
<rdar://problem/7761248>

Reviewed by Darin Adler.

  • platform/text/StringBuilder.cpp:

(WebCore::checkAppend):
(WebCore::StringBuilder::append):
(WebCore::StringBuilder::toString):
(WebCore::StringBuilder::clear):
(WebCore::StringBuilder::length):

  • platform/text/StringBuilder.h:

(WebCore::StringBuilder::StringBuilder):
(WebCore::StringBuilder::setNonNull):
(WebCore::StringBuilder::isNull):

4:51 PM Changeset in webkit [68714] by Chris Fleizach
  • 2 edits in trunk/LayoutTests

Unreviewed. Update test results.

AX: implement CSS3 Speech "speak"
https://bugs.webkit.org/show_bug.cgi?id=46827

Rebaseline GTK test after CSS change.

  • platform/gtk/svg/css/getComputedStyle-basic-expected.txt:
4:42 PM Changeset in webkit [68713] by mrowe@apple.com
  • 4 edits
    4 adds in branches/safari-533.19-branch

Merge r65900.

4:31 PM Changeset in webkit [68712] by mrowe@apple.com
  • 6 edits
    2 adds in branches/safari-533.19-branch

Merge r68096.

4:22 PM Changeset in webkit [68711] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533.19-branch

Merge r61709.

4:20 PM Changeset in webkit [68710] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533.19-branch

Merge r62873.

4:19 PM Changeset in webkit [68709] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533.19-branch

Merge r67967.

4:13 PM Changeset in webkit [68708] by mrowe@apple.com
  • 4 edits
    2 adds in branches/safari-533.19-branch

Merge r68461.

4:09 PM Changeset in webkit [68707] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533.19-branch

Merge r67407.

4:07 PM Changeset in webkit [68706] by mrowe@apple.com
  • 5 edits
    2 adds in branches/safari-533.19-branch

Merge r61622.

4:05 PM Changeset in webkit [68705] by andersca@apple.com
  • 2 edits in trunk/WebCore

Add additional check to Text::wholeText.
<rdar://problem/8304795>

Reviewed by Darin Adler.

  • dom/Text.cpp:

(WebCore::Text::wholeText):

4:05 PM Changeset in webkit [68704] by mrowe@apple.com
  • 3 edits in branches/safari-533.19-branch/WebCore

Merge r65313.

4:04 PM Changeset in webkit [68703] by mrowe@apple.com
  • 4 edits
    3 adds in branches/safari-533.19-branch

Merge r65135.

3:59 PM Changeset in webkit [68702] by bweinstein@apple.com
  • 6 edits
    4 adds in trunk

REGRESSION (r66129): Loading full-frame .swf file crashes with flash blocker extension enabled
<https://bugs.webkit.org/show_bug.cgi?id=46773>
<rdar://problem/8390975>

Reviewed by Brady Eidson.

WebCore:

After r66129, start scripts were run on plugin documents, and cancelling the load of a plugin
document could cause Safari to crash.

If a plugin load on an initial document is cancelled, we cancel the main resource load (where the
main resource is the plugin), and if the load is restarted and allowed, we don't go through the manual
loading path like we do on the initial load of a plugin in a plugin document.

Tests: plugins/plugin-document-load-prevented-userscript.html

plugins/plugin-document-willSendRequest-null.html

  • html/HTMLEmbedElement.cpp:

(WebCore::HTMLEmbedElement::updateWidget): If the plugin load was cancelled, and this is in a

plugin document, call a function on PluginDocument that cancels the main resource load, and
sets a plugin document flag.

  • html/PluginDocument.cpp:

(WebCore::PluginDocumentParser::appendBytes): Null check the widget's renderer, because it could be

null if the load was cancelled.

(WebCore::PluginDocument::PluginDocument): Initialize the new variable.
(WebCore::PluginDocument::cancelManualPluginLoad): Cancel the main resource load of the plugin document

(which is a plugin in the case of a plugin document).

  • html/PluginDocument.h:

(WebCore::PluginDocument::shouldLoadPluginManually): Returns whether or not we should load the plugin

manually.

(WebCore::PluginDocument::setShouldLoadPluginManually): Set whether or not we should load the plugin

manually.

(WebCore::toPluginDocument):

  • loader/SubframeLoader.cpp:

(WebCore::SubframeLoader::loadPlugin): Check if we should load the plugin manually according to the plugin

document.

LayoutTests:

Add tests testing how plugin documents behave when the loading of their plugins are cancelled.

  • plugins/plugin-document-load-prevented-userscript-expected.txt: Added.
  • plugins/plugin-document-load-prevented-userscript.html: Added. Tests cancelling the load of a

plugin in a plugin document using beforeload and preventDefault.

  • plugins/plugin-document-willSendRequest-null-expected.txt: Added.
  • plugins/plugin-document-willSendRequest-null.html: Added. Tests cancelling the load of a plugin

in a plugin document by having willSendRequest return null.

3:58 PM Changeset in webkit [68701] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533.19-branch

Merge r63138.

3:53 PM Changeset in webkit [68700] by tony@chromium.org
  • 8 edits in trunk

2010-09-29 Tony Chang <tony@chromium.org>

Reviewed by James Robinson.

[chromium] enable -Werror for DRT and webkit_unit_tests on Linux
https://bugs.webkit.org/show_bug.cgi?id=46829

  • WebKit.gyp:
  • tests/ArenaTestHelpers.h: (WebCore::ArenaTestHelpers::TrackedAllocator::free):
  • tests/IDBKeyPathTest.cpp: (WebCore::checkKeyPath):

2010-09-29 Tony Chang <tony@chromium.org>

Reviewed by James Robinson.

[chromium] enable -Werror for DRT and webkit_unit_tests on Linux
https://bugs.webkit.org/show_bug.cgi?id=46829

  • DumpRenderTree/chromium/DRTDevToolsClient.cpp: (DRTDevToolsClient::DRTDevToolsClient):
  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::TestShell):
  • DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::postAccessibilityNotification): (WebViewHost::WebViewHost):
3:52 PM Changeset in webkit [68699] by mrowe@apple.com
  • 2 edits in branches/safari-533.19-branch/WebCore

Merge r63836.

3:52 PM Changeset in webkit [68698] by mrowe@apple.com
  • 6 edits
    7 adds in branches/safari-533.19-branch

Merge r63834.

3:51 PM Changeset in webkit [68697] by mrowe@apple.com
  • 4 edits
    8 adds in branches/safari-533.19-branch

Merge r59185.

3:22 PM Changeset in webkit [68696] by hyatt@apple.com
  • 3 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=46844, make estimateLogicalTopPosition
block-flow-aware.

Reviewed by Sam Weinig.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::estimateLogicalTopPosition):
(WebCore::RenderBlock::collapsedMarginBeforeForChild):
(WebCore::RenderBlock::collapsedMarginAfterForChild):

  • rendering/RenderBlock.h:
3:22 PM Changeset in webkit [68695] by crogers@google.com
  • 5 edits in branches/audio/WebCore

audio branch: fixes for landing in trunk

  • AudioContext fix to avoid deleting very large number of AudioNodes all at once
  • HRTFPanner and DelayDSPKernel cleanup
3:11 PM Changeset in webkit [68694] by mrowe@apple.com
  • 2 edits in branches/safari-533.19-branch/JavaScriptCore

Merge r66119.

3:08 PM Changeset in webkit [68693] by mrowe@apple.com
  • 6 edits
    1 add in branches/safari-533.19-branch

Merge r65947.

3:06 PM Changeset in webkit [68692] by crogers@google.com
  • 2 edits in trunk/WebCore

2010-09-29 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

Minor cleanup to AudioContext
https://bugs.webkit.org/show_bug.cgi?id=46843

No new tests since audio API is not yet implemented

  • webaudio/AudioContext.cpp: (WebCore::AudioContext::lock): (WebCore::AudioContext::handleDeferredFinishDerefs):
3:06 PM Changeset in webkit [68691] by tony@chromium.org
  • 3 edits in trunk/WebKit/chromium

2010-09-29 Tony Chang <tony@chromium.org>

Reviewed by James Robinson.

[chromium] enable -Werror on chromium linux webkit
https://bugs.webkit.org/show_bug.cgi?id=46821

  • WebKit.gyp:
  • src/gtk/WebInputEventFactory.cpp:
3:02 PM Changeset in webkit [68690] by senorblanco@chromium.org
  • 3 edits in trunk

2010-09-29 MORITA Hajime <morrita@google.com>

Reviewed by Eric Seidel.

Assertion failed when accessing -webkit-margin-top-collapse via computed style.
https://bugs.webkit.org/show_bug.cgi?id=46798


There was a switch statement which missed enum entries in getPropertyCSSValue().
This change added these entries to prevent the leak.
It also added extra case statements to encourage the compiler's help.

Test: fast/css/getComputedStyle/margin-top-bottom-collapse-alias.html

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

2010-09-29 MORITA Hajime <morrita@google.com>

Reviewed by Eric Seidel.

Assertion failed when accessing -webkit-margin-top-collapse via computed style.
https://bugs.webkit.org/show_bug.cgi?id=46798

  • fast/css/getComputedStyle/margin-top-bottom-collapse-alias-expected.txt: Added.
  • fast/css/getComputedStyle/margin-top-bottom-collapse-alias.html: Added.
  • fast/css/getComputedStyle/script-tests/margin-top-bottom-collapse-alias.js: Added.
2:56 PM Changeset in webkit [68689] by crogers@google.com
  • 2 edits in trunk/WebCore

2010-09-29 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

Limit number of AudioNode deletions per render quantum in AudioContext
https://bugs.webkit.org/show_bug.cgi?id=46834

No new tests since audio API is not yet implemented.

  • webaudio/AudioContext.cpp: (WebCore::AudioContext::handlePostRenderTasks): (WebCore::AudioContext::deleteMarkedNodes):
2:46 PM Changeset in webkit [68688] by mihaip@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-09-29 Mihai Parparita <mihaip@chromium.org>

Unreviewed removal of unused #define from WebHistory.h.
Chromium usage of WEBKIT_BUG_40451_IS_FIXED was removed with
http://crrev.com/50642.

  • public/WebHistoryItem.h:
2:45 PM Changeset in webkit [68687] by hyatt@apple.com
  • 5 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=46838

Reviewed by Simon Fraser.

Get rid of the marginXXXUsing/setMarginXXXUsing methods on RenderBox. I'm inverting the way these are called
and putting the methods on RenderBlock instead. The methods can be named better this way and the getters
can operate on RenderBoxModelObjects instead of just RenderBoxes.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlockChild):
(WebCore::RenderBlock::marginBeforeForChild):
(WebCore::RenderBlock::marginAfterForChild):
(WebCore::RenderBlock::marginStartForChild):
(WebCore::RenderBlock::marginEndForChild):
(WebCore::RenderBlock::setMarginStartForChild):
(WebCore::RenderBlock::setMarginEndForChild):
(WebCore::RenderBlock::setMarginBeforeForChild):
(WebCore::RenderBlock::setMarginAfterForChild):

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::logicalHeightForChild):
(WebCore::RenderBlock::logicalTopForChild):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::marginBefore):
(WebCore::RenderBox::marginAfter):
(WebCore::RenderBox::marginStart):
(WebCore::RenderBox::marginEnd):
(WebCore::RenderBox::setMarginStart):
(WebCore::RenderBox::setMarginEnd):
(WebCore::RenderBox::setMarginBefore):
(WebCore::RenderBox::setMarginAfter):
(WebCore::RenderBox::computeLogicalWidth):
(WebCore::RenderBox::computeInlineDirectionMargins):
(WebCore::RenderBox::computeBlockDirectionMargins):

  • rendering/RenderBox.h:

(WebCore::RenderBox::setMarginTop):
(WebCore::RenderBox::setMarginBottom):
(WebCore::RenderBox::setMarginLeft):
(WebCore::RenderBox::setMarginRight):

2:39 PM Changeset in webkit [68686] by andersca@apple.com
  • 14 edits
    2 adds in trunk/WebKit2

Implement more of PluginProxy and PLuginControllerProxy.

Reviewed by Sam Weinig.

  • Platform/CoreIPC/ArgumentDecoder.cpp:

(CoreIPC::ArgumentDecoder::decodeBytes):

  • Platform/CoreIPC/ArgumentDecoder.h:

Add new overload that takes a DataReference. Wrap the debug function in #ifndef NDEBUG.

  • Platform/CoreIPC/ArgumentEncoder.cpp:
  • Platform/CoreIPC/ArgumentEncoder.h:

Wrap the debug function in #ifndef NDEBUG.

  • Platform/CoreIPC/Arguments.h:

Add new typedefs.

  • Platform/CoreIPC/DataReference.cpp:
  • Platform/CoreIPC/DataReference.h:

Add a DataReference class.

  • Platform/CoreIPC/HandleMessage.h:

(CoreIPC::handleMessage):
Add new overload.

  • PluginProcess/PluginControllerProxy.cpp:

(WebKit::PluginControllerProxy::didEvaluateJavaScript):
(WebKit::PluginControllerProxy::streamDidReceiveResponse):
(WebKit::PluginControllerProxy::streamDidReceiveData):
(WebKit::PluginControllerProxy::streamDidFinishLoading):
(WebKit::PluginControllerProxy::streamDidFail):
call Plugin member functions.

  • PluginProcess/PluginControllerProxy.messages.in:

Add new messages.

  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:

Add DataReference.cpp and DataReference.h

  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::didEvaluateJavaScript):
(WebKit::PluginProxy::streamDidReceiveResponse):
(WebKit::PluginProxy::streamDidReceiveData):
(WebKit::PluginProxy::streamDidFinishLoading):
(WebKit::PluginProxy::streamDidFail):
Send messages.

2:21 PM Changeset in webkit [68685] by senorblanco@chromium.org
  • 10 edits in trunk/LayoutTests

2010-09-29 Stephen White <senorblanco@chromium.org>

Unreviewed; updated test results.

[CHROMIUM] New test results after r68680.

  • platform/chromium-linux/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-linux/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-linux/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-mac/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-mac/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
2:12 PM Changeset in webkit [68684] by andersca@apple.com
  • 2 edits in trunk/WebKit2

Update expected results.

  • Scripts/webkit2/messages_unittest.py:
2:12 PM Changeset in webkit [68683] by mitz@apple.com
  • 3 edits in trunk/WebCore

Removed input type site-specific quirk for mail.google.com
https://bugs.webkit.org/show_bug.cgi?id=46836

Reviewed by Sam Weinig.

  • bindings/js/JSHTMLInputElementCustom.cpp:

(WebCore::needsGmailQuirk): Removed.
(WebCore::JSHTMLInputElement::type): Removed this custom getter.

  • html/HTMLInputElement.idl: Removed the JSCCustomGetter custom attribute

from the type attribute.

1:56 PM Changeset in webkit [68682] by Joseph Pecoraro
  • 2 edits in trunk/WebCore

2010-09-29 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Simon Fraser.

CRASH at WebCore::HTMLSourceElement::scheduleErrorEvent
https://bugs.webkit.org/show_bug.cgi?id=46777

It should not be possible to get to be in the LoadingFromSourceElement
state with a null current source node. This was a possible scenario
where the current source node was cleared but the load state was not
cleared as well. Tried and could not create a test case for this.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::userCancelledLoad): clear the load state because we also clear the current source node.
1:12 PM Changeset in webkit [68681] by hyatt@apple.com
  • 9 edits in trunk

WebCore: https://bugs.webkit.org/show_bug.cgi?id=46835, patch a few more height/logicalHeights. Rename stretchesToViewHeight.

Reviewed by Dan Bernstein.

  • page/FrameView.cpp:

(WebCore::FrameView::layout):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlock):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::layoutInlineChildren):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeLogicalHeight):

  • rendering/RenderBox.h:

(WebCore::RenderBox::stretchesToViewport):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::relativePositionOffsetY):

LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=46835, patch a few more height/logicalHeights.

Reviewed by Dan Bernstein.

  • platform/mac/fast/blockflow/root-lr-basic-expected.txt:
12:59 PM Changeset in webkit [68680] by Chris Fleizach
  • 19 edits
    2 adds in trunk

AX: implement CSS3 Speech "speak"
https://bugs.webkit.org/show_bug.cgi?id=46827

Reviewed by Darin Adler.

WebCore:

Support the "speak" style as defined in
http://www.w3.org/TR/css3-speech/#speak

This puts all the pieces in place for a platform to support this ability, but there's no platform implementation yet.

Test: platform/mac/accessibility/css-speech-speak.html

  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::speakProperty):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::speakProperty):

  • accessibility/AccessibilityRenderObject.h:
  • accessibility/mac/AccessibilityObjectWrapper.mm:

(-[AccessibilityObjectWrapper accessibilityAttributeValue:]):

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator ESpeak):

  • css/CSSPropertyNames.in:
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

  • css/CSSValueKeywords.in:
  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::speak):
(WebCore::InheritedFlags::setSpeak):
(WebCore::InheritedFlags::initialSpeak):

  • rendering/style/RenderStyleConstants.h:
  • rendering/style/StyleRareInheritedData.cpp:

(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):

  • rendering/style/StyleRareInheritedData.h:

WebKitTools:

  • DumpRenderTree/AccessibilityUIElement.cpp:

(speakCallback):
(AccessibilityUIElement::speak):
(AccessibilityUIElement::getJSClass):

  • DumpRenderTree/AccessibilityUIElement.h:
  • DumpRenderTree/mac/AccessibilityUIElementMac.mm:

(AccessibilityUIElement::speak):

LayoutTests:

  • platform/mac/accessibility/css-speech-speak-expected.txt: Added.
  • platform/mac/accessibility/css-speech-speak.html: Added.
12:33 PM Changeset in webkit [68679] by commit-queue@webkit.org
  • 3 edits in trunk/WebCore

2010-09-29 João Paulo Rechi Vita <jprvita@profusion.mobi>

Reviewed by Antonio Gomes.

[Curl] Fix unused and unitialized warnings.
https://bugs.webkit.org/show_bug.cgi?id=46831

No new tests since no new funcionality has been added.

  • platform/network/curl/ResourceHandleCurl.cpp: (WebCore::allowsAnyHTTPSCertificateHosts):
  • platform/network/curl/ResourceHandleManager.cpp: (WebCore::ResourceHandleManager::ResourceHandleManager): (WebCore::handleLocalReceiveResponse): (WebCore::ResourceHandleManager::downloadTimerCallback): (WebCore::ResourceHandleManager::initializeHandle):
12:32 PM Changeset in webkit [68678] by hyatt@apple.com
  • 6 edits in trunk

https://bugs.webkit.org/show_bug.cgi?id=46824

Reviewed by Sam Weinig.

Convert layoutBlockChild (but not the functions it calls) to be block-flow-aware.

fast/blockflow/root-lr.html progresses as a result of this change.

WebCore:

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::estimateLogicalTopPosition):
(WebCore::RenderBlock::determineLogicalLeftPositionForChild):
(WebCore::RenderBlock::setLogicalTopForChild):
(WebCore::RenderBlock::layoutBlockChild):

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::logicalHeightForChild):
(WebCore::RenderBlock::logicalTopForChild):

  • rendering/RenderBox.h:

LayoutTests:

  • platform/mac/fast/blockflow/root-lr-basic-expected.txt:
12:17 PM Changeset in webkit [68677] by andersca@apple.com
  • 11 edits in trunk/WebKit2

Implement LoadURL
https://bugs.webkit.org/show_bug.cgi?id=46826

Reviewed by Sam Weinig.

  • Platform/CoreIPC/ArgumentCoders.h:

Move String argument coder here from WebCoreArgumentCoders.h. Add
argument coder for AtomicString.

  • Platform/CoreIPC/Arguments.h:

Add typedefs for Arguments7.

  • Platform/CoreIPC/HandleMessage.h:

(CoreIPC::handleMessage):
Add handleMessage overload that takes 7 parameters.

  • PluginProcess/PluginControllerProxy.cpp:

(WebKit::PluginControllerProxy::loadURL):
Send the LoadURL message.

  • Scripts/webkit2/messages.py:

(parse_parameter_string): Use rsplit in case the type name contains spaces.
(argument_coder_headers_for_type): Special case Vector.

  • Scripts/webkit2/messages_unittest.py:

Update results.

  • Shared/WebCoreArgumentCoders.h:

Add argument coder for HTTPHeaderMap.

  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::loadURL):
Ask the plug-in controller to load the URL.

  • WebProcess/Plugins/PluginProxy.messages.in:

Add LoadURL message.

12:12 PM Changeset in webkit [68676] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

2010-09-29 Stephen White <senorblanco@chromium.org>

Unreviewed; test expectations fix.

[CHROMIUM] Update test_expectations to better reflect the state of the
build.

  • platform/chromium/test_expectations.txt:
12:08 PM Changeset in webkit [68675] by kinuko@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-09-29 Kinuko Yasuda <kinuko@chromium.org>

Unreviewed, adding one more missing change from the last patch.
https://bugs.webkit.org/show_bug.cgi?id=46524

  • WebKit.gyp:
12:08 PM Changeset in webkit [68674] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk/po

2010-09-29 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Martin Robinson.

Avoid touching the po files automatically during the build
process. The maintainers still have the option of forcing an
update with make update-po.

  • GNUmakefile.am:
12:07 PM Changeset in webkit [68673] by mihaip@chromium.org
  • 11 edits
    1 copy in trunk/WebKitTools

2010-09-29 Mihai Parparita <mihaip@chromium.org>

Reviewed by Adam Barth.

Record bot ID when updating queue status
https://bugs.webkit.org/show_bug.cgi?id=46764

Since we now have multiple bots handling patches from the commit queue,
we need to differentiate status updates from them, so that we can group
the queue status page in a less confusing way.

  • QueueStatusServer/handlers/updatestatus.py: Accept bot_id as input
  • QueueStatusServer/model/queuestatus.py: Add bot_id property
  • QueueStatusServer/templates/updatestatus.html: Add bot_id input
  • Scripts/webkitpy/common/net/bugzilla_unittest.py: Extract MockBrowser
  • Scripts/webkitpy/common/net/statusserver.py: Add bot_id
  • Scripts/webkitpy/common/net/statusserver_unittest.py: Added.
  • Scripts/webkitpy/tool/main.py: Add --bot-id
  • Scripts/webkitpy/tool/mocktool.py: Add MockBrowser
12:04 PM Changeset in webkit [68672] by kinuko@chromium.org
  • 1 edit
    2 adds in trunk/WebKit/chromium

2010-09-29 Kinuko Yasuda <kinuko@chromium.org>

Unreviewed, adding the new files that were supposed to be added
but I missed to include in my previous patch.
https://bugs.webkit.org/show_bug.cgi?id=46524

  • src/WorkerAsyncFileSystemChromium.cpp: Added.
  • src/WorkerAsyncFileSystemChromium.h: Added.
11:47 AM Changeset in webkit [68671] by rniwa@webkit.org
  • 2 edits in trunk

Fixed reviewer names.

11:44 AM Changeset in webkit [68670] by rniwa@webkit.org
  • 5 edits
    3 adds in trunk

2010-09-29 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

queryCommandValue "formatBlock" always returns false
https://bugs.webkit.org/show_bug.cgi?id=21305

Implemented queryCommandValue('formatBlock'). We match the Firefox's behavior exactly
because Firefox and Internet Explorer support the same set of elements
(address, h1, h2, h3, h4, h5, h6, and p) and Firefox's behavior is more compatible with Opera.
See the bug for the detailed discussion.

WebKit's implementation returns the local name of the lowest common ancestor
of the selection with the tag name address, h1, h2, h3, h4, h5, h6, or p.
It returns "" when there is no such an ancestor or there is no selection.

Test: editing/execCommand/query-format-block.html

  • editing/Editor.cpp: (WebCore::isElementForFormatBlockCommand): (WebCore::Editor::elementForFormatBlockCommand):
  • editing/Editor.h:
  • editing/EditorCommand.cpp: (WebCore::valueFormatBlock): (WebCore::createCommandMap):

2010-09-29 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

queryCommandValue "formatBlock" always returns false
https://bugs.webkit.org/show_bug.cgi?id=21305

Added a test for queryCommandValue('formatBlock').

  • editing/execCommand/query-format-block-expected.txt: Added.
  • editing/execCommand/query-format-block.html: Added.
  • editing/execCommand/script-tests/query-format-block.js: Added. (queryFormatBlock): (selectFirstPosition): (selectMiddleOfHelloWorld):
11:12 AM Changeset in webkit [68669] by kinuko@chromium.org
  • 9 edits in trunk/WebKit/chromium

2010-09-29 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by David Levin.

Bridge all FileSystem operations on Workers to the MainThread
https://bugs.webkit.org/show_bug.cgi?id=46524

  • src/LocalFileSystemChromium.cpp: (WebCore::LocalFileSystem::requestFileSystem): Changed the worker case code to create WebFileSystemCallbacksImpl with the current ScriptExecutionContext (WorkerContext).
  • src/WebFileSystemCallbacksImpl.cpp: (WebKit::WebFileSystemCallbacksImpl::WebFileSystemCallbacksImpl): Added a new constructor that takes ScriptExecutionContext (WorkerContext) for workers. (WebKit::WebFileSystemCallbacksImpl::didOpenFileSystem): Added the code for workers that creates WorkerAsyncFileSystemChromium.
  • src/WebFileSystemCallbacksImpl.h:
  • src/WorkerAsyncFileSystemChromium.cpp: Added.
  • src/WorkerAsyncFileSystemChromium.h: Added.
  • src/WorkerFileSystemCallbacksBridge.cpp: Added methods for regular file system operations to proxy them to the main thread. (WebKit::WorkerFileSystemCallbacksBridge::createForOpenFileSystem): (WebKit::WorkerFileSystemCallbacksBridge::createForMove): (WebKit::WorkerFileSystemCallbacksBridge::createForCopy): (WebKit::WorkerFileSystemCallbacksBridge::createForRemove): (WebKit::WorkerFileSystemCallbacksBridge::createForReadMetadata): (WebKit::WorkerFileSystemCallbacksBridge::createForCreateFile): (WebKit::WorkerFileSystemCallbacksBridge::createForCreateDirectory): (WebKit::WorkerFileSystemCallbacksBridge::createForFileExists): (WebKit::WorkerFileSystemCallbacksBridge::createForDirectoryExists): (WebKit::WorkerFileSystemCallbacksBridge::createForReadDirectory): (WebKit::MainThreadFileSystemCallbacks::didSucceed): (WebKit::MainThreadFileSystemCallbacks::didReadMetadata): (WebKit::MainThreadFileSystemCallbacks::didReadDirectory): (WebKit::WorkerFileSystemCallbacksBridge::openFileSystemOnMainThread): (WebKit::WorkerFileSystemCallbacksBridge::moveOnMainThread): (WebKit::WorkerFileSystemCallbacksBridge::copyOnMainThread): (WebKit::WorkerFileSystemCallbacksBridge::removeOnMainThread): (WebKit::WorkerFileSystemCallbacksBridge::readMetadataOnMainThread): (WebKit::WorkerFileSystemCallbacksBridge::createFileOnMainThread): (WebKit::WorkerFileSystemCallbacksBridge::createDirectoryOnMainThread): (WebKit::WorkerFileSystemCallbacksBridge::fileExistsOnMainThread): (WebKit::WorkerFileSystemCallbacksBridge::directoryExistsOnMainThread): (WebKit::WorkerFileSystemCallbacksBridge::readDirectoryOnMainThread): (WebKit::WorkerFileSystemCallbacksBridge::didSucceedOnMainThread): (WebKit::WorkerFileSystemCallbacksBridge::didReadMetadataOnMainThread): (WebKit::WorkerFileSystemCallbacksBridge::didReadDirectoryOnMainThread): (WebKit::WorkerFileSystemCallbacksBridge::didSucceedOnWorkerThread): (WebKit::WorkerFileSystemCallbacksBridge::didReadMetadataOnWorkerThread): (WebKit::WorkerFileSystemCallbacksBridge::didReadDirectoryOnWorkerThread): (WebKit::WorkerFileSystemCallbacksBridge::derefIfWorkerIsStopped):
  • src/WorkerFileSystemCallbacksBridge.h:
11:08 AM Changeset in webkit [68668] by commit-queue@webkit.org
  • 3 edits in trunk/WebKit/gtk/po

2010-09-29 Miloš Popović <gpopac@gmail.com>

Reviewed by Gustavo Noronha Silva.

Serbian translations update.

11:01 AM Changeset in webkit [68667] by inferno@chromium.org
  • 1 edit
    2 copies in branches/chromium/517

Merge 68485

BUG=56621
Review URL: http://codereview.chromium.org/3520007

11:01 AM Changeset in webkit [68666] by mpcomplete@chromium.org
  • 7 edits in trunk

2010-09-29 Matt Perry <mpcomplete@chromium.org>

Reviewed by Darin Fisher.

Remove obsolete registerExtension variants from chromium port.
https://bugs.webkit.org/show_bug.cgi?id=46683

  • bindings/v8/V8DOMWindowShell.cpp: (WebCore::V8DOMWindowShell::createNewContext):
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::registeredExtensionWithV8): (WebCore::V8Proxy::registerExtension):
  • bindings/v8/V8Proxy.h:

2010-09-29 Matt Perry <mpcomplete@chromium.org>

Reviewed by Darin Fisher.

Remove obsolete registerExtension variants from chromium port.
https://bugs.webkit.org/show_bug.cgi?id=46683

  • public/WebScriptController.h:
  • src/WebScriptController.cpp:
10:58 AM Changeset in webkit [68665] by mrobinson@webkit.org
  • 5 edits in trunk

2010-09-29 Martin Robinson <mrobinson@igalia.com>

Reviewed by Chris Fleizach.

[GTK] editing/selection/selection-modify-crash.html crashes when run in Xvfb
https://bugs.webkit.org/show_bug.cgi?id=46822

  • platform/gtk/Skipped: Unskip a test which is no longer crashing.

2010-09-29 Martin Robinson <mrobinson@igalia.com>

Reviewed by Chris Fleizach.

[GTK] editing/selection/selection-modify-crash.html crashes when run in Xvfb
https://bugs.webkit.org/show_bug.cgi?id=46822

When parentObjectUnignored returns null in objectAndOffsetUnignored consider that
a failure case. Handle this failure appropriately at all call sites.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_text_get_caret_offset): Handle the failure of objectAndOffsetUnignored. (objectAndOffsetUnignored): Always check the return value of parentObjectUnignored and return 0 to indicate failure when that happens.
  • editing/gtk/SelectionControllerGtk.cpp: (WebCore::SelectionController::notifyAccessibilityForSelectionChange): Handle the failure case of objectAndOffsetUnignored.
10:56 AM Changeset in webkit [68664] by inferno@chromium.org
  • 2 edits
    2 copies in branches/chromium/517

Merge 68408

BUG=56692
Review URL: http://codereview.chromium.org/3559003

10:52 AM Changeset in webkit [68663] by inferno@chromium.org
  • 1 edit
    2 copies in branches/chromium/517

Merge 68340

BUG=56796
Review URL: http://codereview.chromium.org/3521003

10:46 AM Changeset in webkit [68662] by andersca@apple.com
  • 12 edits in trunk/WebKit2

Handle getting the user agent in the plug-in process
https://bugs.webkit.org/show_bug.cgi?id=46819

Reviewed by Sam Weinig.

  • Platform/CoreIPC/HandleMessage.h:

(CoreIPC::handleMessage):
Add new handleMessage overload.

  • PluginProcess/PluginControllerProxy.cpp:

(WebKit::PluginControllerProxy::create):
(WebKit::PluginControllerProxy::PluginControllerProxy):
Pass the user agent to the plug-in controller proxy.

(WebKit::PluginControllerProxy::userAgent):
Return the user agent.

  • PluginProcess/WebProcessConnection.cpp:

(WebKit::WebProcessConnection::createPlugin):
Pass the user agent when creating the plug-in controller proxy.

  • PluginProcess/WebProcessConnection.messages.in:

Add userAgent.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::userAgent):

  • WebProcess/Plugins/PluginController.h:

Remove the URL parameter to userAgent.

  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::initialize):
Pass the user agent to WebProcessConnection::CreatePlugin.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::userAgent):
Remove url parameter.

10:46 AM Changeset in webkit [68661] by commit-queue@webkit.org
  • 14 edits
    2 deletes in trunk/WebCore

2010-09-29 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r68657.
http://trac.webkit.org/changeset/68657
https://bugs.webkit.org/show_bug.cgi?id=46820

reason "Breaks win debug build" (Requested by podivilov on
#webkit).

  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSXMLHttpRequestCustom.cpp: (WebCore::JSXMLHttpRequest::send):
  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp: (WebCore::V8XMLHttpRequest::sendCallback):
  • dom/CharacterData.cpp: (WebCore::CharacterData::dispatchModifiedEvent):
  • dom/ContainerNode.cpp: (WebCore::ContainerNode::insertBefore): (WebCore::ContainerNode::parserInsertBefore): (WebCore::ContainerNode::replaceChild): (WebCore::ContainerNode::appendChild): (WebCore::ContainerNode::parserAddChild): (WebCore::notifyChildInserted): (WebCore::dispatchChildRemovalEvents):
  • dom/Element.cpp: (WebCore::Element::setAttribute): (WebCore::Element::removeAttribute):
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::~InspectorController): (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::disconnectFrontend): (WebCore::InspectorController::willInsertDOMNodeImpl): (WebCore::InspectorController::didInsertDOMNodeImpl): (WebCore::InspectorController::willRemoveDOMNodeImpl): (WebCore::InspectorController::didRemoveDOMNodeImpl): (WebCore::InspectorController::willModifyDOMAttrImpl): (WebCore::InspectorController::didModifyDOMAttrImpl): (WebCore::InspectorController::characterDataModifiedImpl): (WebCore::InspectorController::instrumentWillSendXMLHttpRequestImpl):
  • inspector/InspectorController.h: (WebCore::InspectorController::willInsertDOMNode): (WebCore::InspectorController::didInsertDOMNode): (WebCore::InspectorController::willRemoveDOMNode): (WebCore::InspectorController::willModifyDOMAttr): (WebCore::InspectorController::didModifyDOMAttr): (WebCore::InspectorController::characterDataModified): (WebCore::InspectorController::instrumentWillSendXMLHttpRequest): (WebCore::InspectorController::inspectorControllerForScriptExecutionContext): (WebCore::InspectorController::inspectorControllerForNode): (WebCore::InspectorController::inspectorControllerForDocument):
  • inspector/InspectorInstrumentation.cpp: Removed.
  • inspector/InspectorInstrumentation.h: Removed.
  • workers/SharedWorker.cpp:
10:32 AM Changeset in webkit [68660] by xji@chromium.org
  • 2 edits in trunk/WebCore

2010-09-29 Xiaomei Ji <xji@chromium.org>

Reviewed by David Levin.

Performance improvement for FontLinux.
https://bugs.webkit.org/show_bug.cgi?id=46374

Reduce new/delete operations by storing the maximum capacity of the glyph
array and use that value in subsequent HB_ShapeItem calls. (Note that a
call to HB_ShapeItem may reduce the value of m_item.num_glyphs below the
capacity.)

Also be consistent with zero'ing the glyph arrays before calling
HB_ShapeItem.

There is no functionality changes so no new tests are added.

  • platform/graphics/chromium/FontLinux.cpp: (WebCore::TextRunWalker::createGlyphArrays): (WebCore::TextRunWalker::resetGlyphArrays): (WebCore::TextRunWalker::shapeGlyphs):
10:23 AM Changeset in webkit [68659] by andersca@apple.com
  • 9 edits in trunk

Implement more PluginProxy member functions
https://bugs.webkit.org/show_bug.cgi?id=46815

Reviewed by Sam Weinig.

  • Platform/CoreIPC/HandleMessage.h:

(CoreIPC::handleMessage):

  • PluginProcess/PluginControllerProxy.cpp:

(WebKit::PluginControllerProxy::handleMouseEvent):
(WebKit::PluginControllerProxy::handleWheelEvent):
(WebKit::PluginControllerProxy::handleMouseEnterEvent):
(WebKit::PluginControllerProxy::handleMouseLeaveEvent):
(WebKit::PluginControllerProxy::setFocus):
(WebKit::PluginControllerProxy::windowFocusChanged):
(WebKit::PluginControllerProxy::windowFrameChanged):
(WebKit::PluginControllerProxy::windowVisibilityChanged):
Call the appropriate Plugin member functions.

  • PluginProcess/PluginControllerProxy.messages.in:

Add new messages.

  • PluginProcess/WebProcessConnection.cpp:

(WebKit::WebProcessConnection::didReceiveMessage):
It's OK to get a message for a plug-in controller proxy that has gone away.

(WebKit::WebProcessConnection::didReceiveSyncMessage):
Forward the message to the PluginControllerProxy handler.

  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::handleMouseEvent):
(WebKit::PluginProxy::handleWheelEvent):
(WebKit::PluginProxy::handleMouseEnterEvent):
(WebKit::PluginProxy::handleMouseLeaveEvent):
(WebKit::PluginProxy::setFocus):
(WebKit::PluginProxy::windowFocusChanged):
(WebKit::PluginProxy::windowFrameChanged):
(WebKit::PluginProxy::windowVisibilityChanged):
Send messages to the plug-in process.

(WebKit::PluginProxy::controller):
Return the plug-in controller.

10:19 AM Changeset in webkit [68658] by commit-queue@webkit.org
  • 4 edits in trunk/WebKit/chromium

2010-09-29 Chris Guillory <chris.guillory@google.com>

Reviewed by Dimitri Glazkov.

Add method which checks if a WebAccessibilityObject is in the cache.
https://bugs.webkit.org/show_bug.cgi?id=46605

  • public/WebAccessibilityCache.h:
  • src/WebAccessibilityCacheImpl.cpp: (WebKit::WebAccessibilityCacheImpl::isCached):
  • src/WebAccessibilityCacheImpl.h:
10:19 AM Changeset in webkit [68657] by podivilov@chromium.org
  • 14 edits
    2 adds in trunk/WebCore

2010-09-29 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: extract Inspector Instrumentation API as a class.
https://bugs.webkit.org/show_bug.cgi?id=46614

  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSXMLHttpRequestCustom.cpp: (WebCore::JSXMLHttpRequest::send):
  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp: (WebCore::V8XMLHttpRequest::sendCallback):
  • dom/CharacterData.cpp: (WebCore::CharacterData::dispatchModifiedEvent):
  • dom/ContainerNode.cpp: (WebCore::ContainerNode::insertBefore): (WebCore::ContainerNode::parserInsertBefore): (WebCore::ContainerNode::replaceChild): (WebCore::ContainerNode::appendChild): (WebCore::ContainerNode::parserAddChild): (WebCore::notifyChildInserted): (WebCore::dispatchChildRemovalEvents):
  • dom/Element.cpp: (WebCore::Element::setAttribute): (WebCore::Element::removeAttribute):
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::~InspectorController): (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::disconnectFrontend): (WebCore::InspectorController::instrumentWillSendXMLHttpRequest):
  • inspector/InspectorController.h:
  • inspector/InspectorInstrumentation.cpp: Added. (WebCore::InspectorInstrumentation::willInsertDOMNodeImpl): (WebCore::InspectorInstrumentation::didInsertDOMNodeImpl): (WebCore::InspectorInstrumentation::willRemoveDOMNodeImpl): (WebCore::InspectorInstrumentation::didRemoveDOMNodeImpl): (WebCore::InspectorInstrumentation::willModifyDOMAttrImpl): (WebCore::InspectorInstrumentation::didModifyDOMAttrImpl): (WebCore::InspectorInstrumentation::characterDataModifiedImpl): (WebCore::InspectorInstrumentation::instrumentWillSendXMLHttpRequestImpl):
  • inspector/InspectorInstrumentation.h: Added. (WebCore::InspectorInstrumentation::frontendCreated): (WebCore::InspectorInstrumentation::frontendDeleted): (WebCore::InspectorInstrumentation::hasFrontends): (WebCore::InspectorInstrumentation::willInsertDOMNode): (WebCore::InspectorInstrumentation::didInsertDOMNode): (WebCore::InspectorInstrumentation::willRemoveDOMNode): (WebCore::InspectorInstrumentation::willModifyDOMAttr): (WebCore::InspectorInstrumentation::didModifyDOMAttr): (WebCore::InspectorInstrumentation::characterDataModified): (WebCore::InspectorInstrumentation::instrumentWillSendXMLHttpRequest): (WebCore::InspectorInstrumentation::inspectorControllerForScriptExecutionContext): (WebCore::InspectorInstrumentation::inspectorControllerForDocument): (WebCore::InspectorInstrumentation::inspectorControllerForPage):
10:15 AM Changeset in webkit [68656] by commit-queue@webkit.org
  • 7 edits in trunk

2010-09-29 Anantanarayanan G Iyengar <ananta@chromium.org>

Reviewed by Darin Fisher.

[chromium] Honor z-index specified by a plugin
https://bugs.webkit.org/show_bug.cgi?id=46223

The Chromium plugin code which implements the iframe shim technique
for overlaying a windowed plugin with content on the page should
honor the z-index specified on the plugin widget. If the z-index
here is greater than the enclosing iframe shim then the plugin
should be displayed over the iframe. Updated the layout test to test
for this case. Skipped the plugins/iframe-shims.html layout test on
platforms which don't support it.

  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • plugins/iframe-shims.html:

2010-09-29 Anantanarayanan G Iyengar <ananta@chromium.org>

Reviewed by Darin Fisher.

[chromium] Honor z-index specified by a plugin
https://bugs.webkit.org/show_bug.cgi?id=46223

The Chromium plugin code which implements the iframe shim technique
for overlaying a windowed plugin with content on the page should
honor the z-index specified on the plugin widget. If the z-index
here is greater than the enclosing iframe shim then the plugin
should be displayed over the iframe. Updated the layout test to test
for this case. Skipped the plugins/iframe-shims.html layout test on
platforms which don't support it.

  • src/WebPluginContainerImpl.cpp:
10:10 AM Changeset in webkit [68655] by Simon Fraser
  • 2 edits in trunk/WebKitTools

2010-09-29 Simon Fraser <Simon Fraser>

No review.

References always refert to a file in .xht format, even
for HTML tests, so fix their loading.

  • CSSTestSuiteHarness/harness/harness.js: (TestSuite.prototype.loadRef):
10:00 AM Changeset in webkit [68654] by hyatt@apple.com
  • 4 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=46786, convert layoutBlockChild (but not any functions it calls)
to be block-flow-aware.

Reviewed by Sam Weinig.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::handleAfterSideOfBlock):
(WebCore::RenderBlock::layoutBlockChildren):

  • rendering/RenderBlock.h:
  • rendering/RenderBox.h:

(WebCore::RenderBox::scrollbarLogicalHeight):

9:46 AM Changeset in webkit [68653] by andreas.kling@nokia.com
  • 2 edits in trunk/WebKit/qt

2010-09-29 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Ariya Hidayat.

[Qt] Don't keep local reference to QGraphicsItemOverlay in QGWVPrivate
https://bugs.webkit.org/show_bug.cgi?id=46812

Get the QGraphicsItemOverlay* via the QWebPageClient (d->page->d->client)
instead of keeping a local pointer to it.

This is cleanup for a follow-up patch.

  • Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::overlay): (QGraphicsWebView::paint): (QGraphicsWebView::setPage): (QGraphicsWebView::updateGeometry): (QGraphicsWebView::setGeometry):
9:43 AM Changeset in webkit [68652] by commit-queue@webkit.org
  • 4 edits in trunk

2010-09-29 João Paulo Rechi Vita <jprvita@profusion.mobi>

Reviewed by Antonio Gomes.

[EFL] General small fixes.
https://bugs.webkit.org/show_bug.cgi?id=46813

This commit spots a comparison between signed and unsigned integer
expressions, a missing return and a never-called function.

No new tests since no new funcionality has been added.

  • platform/efl/SharedBufferEfl.cpp: (WebCore::SharedBuffer::createWithContentsOfFile):

2010-09-29 João Paulo Rechi Vita <jprvita@profusion.mobi>

Reviewed by Antonio Gomes.

[EFL] General small fixes.
https://bugs.webkit.org/show_bug.cgi?id=46813

This commit spots a comparison between signed and unsigned integer
expressions, a missing return and a never-called function.

  • WebCoreSupport/FullscreenVideoControllerEfl.cpp: (FullscreenVideoController::canPlay):
9:31 AM Changeset in webkit [68651] by commit-queue@webkit.org
  • 10 edits in trunk/JavaScriptCore/qt

2010-09-29 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>

Reviewed by Andreas Kling.

[Qt] QScriptEngine should have an API for creating Date objects
https://bugs.webkit.org/show_bug.cgi?id=41667

Implement newDate(), isDate() and toDateTime() functions. Use the
QDateTime::{to,set}MSecsSinceEpoch() functions to do the
calculations.

  • api/qscriptengine.cpp: (QScriptEngine::newDate):
  • api/qscriptengine.h:
  • api/qscriptengine_p.cpp: (QScriptEnginePrivate::newDate):
  • api/qscriptengine_p.h: (QScriptEnginePrivate::isDate):
  • api/qscriptoriginalglobalobject_p.h: (QScriptOriginalGlobalObject::QScriptOriginalGlobalObject): need to keep track of Date Constructor and Prototype. (QScriptOriginalGlobalObject::~QScriptOriginalGlobalObject): ditto. (QScriptOriginalGlobalObject::isDate): use the Date Constructor and Prototype to identify Date values.
  • api/qscriptvalue.cpp: (QScriptValue::isDate): (QScriptValue::toDateTime):
  • api/qscriptvalue.h:
  • api/qscriptvalue_p.h: (QScriptValuePrivate::isDate): (QScriptValuePrivate::toDateTime):
  • tests/qscriptengine/tst_qscriptengine.cpp: (tst_QScriptEngine::newDate):
9:06 AM Changeset in webkit [68650] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2010-09-29 Philippe Normand <pnormand@igalia.com>

Unreviewed, updated baselines of
svg/css/getComputedStyle-basic.xhtml after the css properties
were renamed in r68561.

  • platform/gtk/svg/css/getComputedStyle-basic-expected.txt:
8:55 AM Changeset in webkit [68649] by Patrick Gansterer
  • 2 edits in trunk/JavaScriptCore

2010-09-29 Patrick Gansterer <Patrick Gansterer>

Unreviewed.

Next try to fix cygwin build.

  • wtf/Assertions.cpp:
8:44 AM Changeset in webkit [68648] by Patrick Gansterer
  • 2 edits in trunk/JavaScriptCore

2010-09-29 Patrick Gansterer <Patrick Gansterer>

Unreviewed.

Build fix for cygwin #2. Oops, it's OS(WINDOWS), not OS(WIN).

  • wtf/Assertions.cpp:
8:35 AM Changeset in webkit [68647] by Patrick Gansterer
  • 2 edits in trunk/JavaScriptCore

2010-09-29 Patrick Gansterer <Patrick Gansterer>

Unreviewed.

Build fix for cygwin.

  • wtf/Assertions.cpp:
8:34 AM Changeset in webkit [68646] by Adam Roben
  • 2 edits in trunk/WebKit2

Look for WebKit.dll (not WebKit_debug.dll) when launching the web process in Debug builds

Fixes <http://webkit.org/b/46809> <rdar://problem/8491809> REGRESSION
(r67979): All tests crashing on Windows WebKit2 test bot

Reviewed by Sam Weinig.

  • UIProcess/Launcher/win/ProcessLauncherWin.cpp: WebKit_debug.dll is

only used in Debug_All builds (but WebKit2WebProcess_debug.exe is used
in all non-Debug_Internal debug-style builds).

8:11 AM Changeset in webkit [68645] by Philippe Normand
  • 2 edits in trunk/WebCore

2010-09-29 Philippe Normand <pnormand@igalia.com>

Reviewed by Gustavo Noronha Silva.

build still broken since r68521
https://bugs.webkit.org/show_bug.cgi?id=46795

Call make-values.pl once only. It seems calling it multiple times
in the same build produces a wrong CSSValueKeywordsHash.h which
has a duplicate declaration of its valueList variable. The double
call is triggered by the double targets in the Makefile rules and
makevalues.pl generates one of them, which screws up the build. A
more proper fix should be done with the advices on
http://www.cmcrossroads.com/cm-basics/12905-rules-with-multiple-outputs-in-gnu-make

  • GNUmakefile.am:
8:06 AM Changeset in webkit [68644] by Patrick Gansterer
  • 3 edits in trunk/JavaScriptCore

2010-09-29 Patrick Gansterer <Patrick Gansterer>

Reviewed by Andreas Kling.

[WINCE] Buildfix for Assertions.cpp after r68511.
https://bugs.webkit.org/show_bug.cgi?id=46807

Some, but not all WinCE environments have support for IsDebuggerPresent().
Add HAVE(ISDEBUGGERPRESENT) to make this a build option.
HAVE(ISDEBUGGERPRESENT) will be 1 for all OS(WIN) by default.

  • wtf/Assertions.cpp:
  • wtf/Platform.h:
7:46 AM Changeset in webkit [68643] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-09-29 João Paulo Rechi Vita <jprvita@profusion.mobi>

Unreviewed build fix.

Fix CMake build for ENABLE_PROGRESS_TAG.
https://bugs.webkit.org/show_bug.cgi?id=46808

No new tests since it's a build fix.

  • CMakeLists.txt:
6:56 AM Changeset in webkit [68642] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk/po

2010-09-29 Reinout van Schouwen <reinouts@gnome.org>

Reviewed by Gustavo Noronha.

[GTK] Updated Dutch translation
https://bugs.webkit.org/show_bug.cgi?id=46050

  • nl.po:
6:46 AM Changeset in webkit [68641] by yurys@chromium.org
  • 2 edits in trunk/WebCore

2010-09-29 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

[v8] Use generic mechanism to report exceptions in V8CustomVoidCallback
https://bugs.webkit.org/show_bug.cgi?id=46803

No new tests. It's covered by existing tests under LayoutTests/storage

  • bindings/v8/custom/V8CustomVoidCallback.cpp: (WebCore::invokeCallback):
6:45 AM Changeset in webkit [68640] by satish@chromium.org
  • 14 edits in trunk

2010-09-29 Satish Sampath <satish@chromium.org>

Reviewed by Jeremy Orlow.

Rename the input element's @speech attribute to @webkitspeech since it is still experimental.
https://bugs.webkit.org/show_bug.cgi?id=46799

  • fast/speech/input-appearance-numberandspeech.html:
  • fast/speech/input-appearance-searchandspeech.html:
  • fast/speech/input-appearance-speechbutton.html:
  • fast/speech/input-text-speechbutton.html:
  • fast/speech/speech-button-ignore-generated-events.html:

2010-09-29 Satish Sampath <satish@chromium.org>

Reviewed by Jeremy Orlow.

Rename the input element's @speech attribute to @webkitspeech since it is still experimental.
https://bugs.webkit.org/show_bug.cgi?id=46799

  • bindings/generic/RuntimeEnabledFeatures.h: (WebCore::RuntimeEnabledFeatures::webkitspeechEnabled): Rename the runtime feature flag getter.
  • css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
  • css/CSSValueKeywords.in: Rename the css style name.
  • css/html.css: Rename the css style name. (input::-webkit-input-speech-button):
  • html/HTMLAttributeNames.in: Rename the @speech attribute.
  • html/HTMLInputElement.cpp: Update code using the attribute. (WebCore::HTMLInputElement::parseMappedAttribute): (WebCore::HTMLInputElement::isSpeechEnabled):
  • html/HTMLInputElement.idl: Rename the @speech attribute.
5:45 AM Changeset in webkit [68639] by commit-queue@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-09-29 Peter Varga <pvarga@inf.u-szeged.hu>

Reviewed by Csaba Osztrogonác.

JSC compile fails on 32bit platform when Regexp Tracing is enabled
https://bugs.webkit.org/show_bug.cgi?id=46713

Fix the cast of pointer in regexp tracing to avoid the warning.

  • runtime/RegExp.cpp: (JSC::RegExp::match):
5:17 AM Changeset in webkit [68638] by morrita@google.com
  • 3 edits
    1 add in trunk/WebCore

2010-09-29 MORITA Hajime <morrita@google.com>

[Chromium] failed to build without ACCELERATED_COMPOSITING
https://bugs.webkit.org/show_bug.cgi?id=46793

Moved constant definitions from inside ACCELERATED_COMPOSITING to
outside of the condition.

  • WebCore.gypi:
  • platform/graphics/chromium/VideoFrameChromium.cpp: Added just for defining constants.
  • platform/graphics/chromium/VideoLayerChromium.cpp:
3:35 AM Changeset in webkit [68637] by Simon Hausmann
  • 2 edits in trunk

[Qt] Fix the build on non-x86 platforms with gcc

Reviewed by Csaba Osztrogonác.

Don't disable -Werror on arm, that doesn't work when QT_ARCH is
for example armv6. Instead change the condition as the comment says,
enable -Werror on x86/gcc where we know it passes. On other platforms
gcc produces difference warnings, and when they're fixed we can add
them to the whitelist of -Werror-supported architectures.

  • WebKit.pri:
2:14 AM Changeset in webkit [68636] by pfeldman@chromium.org
  • 10 edits
    3 adds in trunk/WebCore

2010-09-28 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: [Resources panel] Need more visible "at a glance".
https://bugs.webkit.org/show_bug.cgi?id=45657

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/DataGrid.js: (WebInspector.DataGrid): (WebInspector.DataGrid.prototype.updateWidths): (WebInspector.DataGrid.prototype.sortNodes): (WebInspector.DataGrid.prototype._resizerDragging): (WebInspector.DataGrid.prototype._endResizerDragging): (WebInspector.DataGridNode.prototype.selectable.true.get element): (WebInspector.DataGridNode.prototype.createCells): (WebInspector.DataGridNode.prototype.refresh):
  • inspector/front-end/Images/networkIcon.png: Copied from WebCore/inspector/front-end/Images/resourcesIcon.png.
  • inspector/front-end/NetworkPanel.js: Added.
  • inspector/front-end/Settings.js:
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.css: (.toolbar-item.network .toolbar-icon): (.data-grid .data-container):
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js: (WebInspector._createPanels): (WebInspector.updateResource):
  • inspector/front-end/networkPanel.css: Added.
12:59 AM Changeset in webkit [68635] by loislo@chromium.org
  • 7 edits in trunk/WebCore

2010-09-28 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: move pauseOnExceptionState under control of InspectorState
It is Inspector Protocol cleanup activity.
The actual state of this flag can be obtained as a return value of setPauseOnExceptionState command
or as a value in InspectorState object.

https://bugs.webkit.org/show_bug.cgi?id=46724

  • inspector/Inspector.idl:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::getInspectorState): (WebCore::InspectorController::populateScriptObjects):
  • inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::setPauseOnExceptionsState): (WebCore::InspectorDebuggerAgent::pauseOnExceptionsState):
  • inspector/InspectorDebuggerAgent.h:
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._togglePauseOnExceptions):
  • inspector/front-end/inspector.js: (WebInspector.doLoadedDone.populateInspectorState): (WebInspector.doLoadedDone): (WebInspector.reportProtocolError):
12:09 AM Changeset in webkit [68634] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

2010-09-29 James Kozianski <koz@chromium.org>

Reviewed by James Robinson.

Update test_expectations.txt from the flakiness dashboard.
https://bugs.webkit.org/show_bug.cgi?id=46787

Updates some canvas/philip tests in test_expectations.txt that have
started passing on the flakiness dashboard.

  • platform/chromium/test_expectations.txt:

Sep 28, 2010:

11:55 PM Changeset in webkit [68633] by Csaba Osztrogonác
  • 1 edit
    17 adds in trunk/LayoutTests

Unreviewed fix after r68568. Add Qt specific expected files for passing tests.

Unskip remaining canvas layout tests so that they can track progressions/regressions
https://bugs.webkit.org/show_bug.cgi?id=46439

  • platform/qt/canvas: Added.
  • platform/qt/canvas/philip: Added.
  • platform/qt/canvas/philip/tests: Added.
  • platform/qt/canvas/philip/tests/2d.gradient.radial.cone.front-expected.txt: Added.
  • platform/qt/canvas/philip/tests/2d.gradient.radial.inside2-expected.txt: Added.
  • platform/qt/canvas/philip/tests/2d.gradient.radial.inside3-expected.txt: Added.
  • platform/qt/canvas/philip/tests/2d.gradient.radial.outside1-expected.txt: Added.
  • platform/qt/canvas/philip/tests/2d.line.cap.closed-expected.txt: Added.
  • platform/qt/canvas/philip/tests/2d.line.join.parallel-expected.txt: Added.
  • platform/qt/canvas/philip/tests/2d.shadow.enable.blur-expected.txt: Added.
  • platform/qt/canvas/philip/tests/2d.shadow.enable.x-expected.txt: Added.
  • platform/qt/canvas/philip/tests/2d.shadow.enable.y-expected.txt: Added.
  • platform/qt/canvas/philip/tests/2d.shadow.gradient.alpha-expected.txt: Added.
  • platform/qt/canvas/philip/tests/2d.shadow.gradient.basic-expected.txt: Added.
  • platform/qt/canvas/philip/tests/2d.shadow.gradient.transparent.2-expected.txt: Added.
  • platform/qt/canvas/philip/tests/2d.strokeRect.zero.4-expected.txt: Added.
  • platform/qt/canvas/philip/tests/toDataURL.jpeg.alpha-expected.txt: Added.
11:50 PM Changeset in webkit [68632] by Philippe Normand
  • 23 edits in trunk

2010-09-28 Philippe Normand <pnormand@igalia.com>

Reviewed by Martin Robinson.

check USE(GSTREAMER) instead of ENABLE(VIDEO) in gstreamer/ files
https://bugs.webkit.org/show_bug.cgi?id=46717

Define WTF_USE_GSTREAMER if configure found the gstreamer
development files and add the macro in the gcc command-line if needed.

  • GNUmakefile.am:
  • configure.ac:

WebCore:

Reviewed by Martin Robinson.

check USE(GSTREAMER) instead of ENABLE(VIDEO) in gstreamer/ files
https://bugs.webkit.org/show_bug.cgi?id=46717

Guard the gstreamer/ files with USE(GSTREAMER), which is more
explicit than ENABLE(VIDEO).

  • GNUmakefile.am: Define WTF_USE_GSTREAMER only if GStreamer support is enabled.
  • platform/graphics/gstreamer/DataSourceGStreamer.cpp:
  • platform/graphics/gstreamer/DataSourceGStreamer.h:
  • platform/graphics/gstreamer/GOwnPtrGStreamer.cpp:
  • platform/graphics/gstreamer/GOwnPtrGStreamer.h:
  • platform/graphics/gstreamer/GStreamerGWorld.cpp:
  • platform/graphics/gstreamer/GStreamerGWorld.h:
  • platform/graphics/gstreamer/ImageGStreamer.h:
  • platform/graphics/gstreamer/ImageGStreamerCG.mm:
  • platform/graphics/gstreamer/ImageGStreamerCairo.cpp:
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
  • platform/graphics/gstreamer/PlatformVideoWindow.h:
  • platform/graphics/gstreamer/PlatformVideoWindowEfl.cpp:
  • platform/graphics/gstreamer/PlatformVideoWindowGtk.cpp:
  • platform/graphics/gstreamer/VideoSinkGStreamer.cpp:
  • platform/graphics/gstreamer/VideoSinkGStreamer.h:
  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.h:
11:30 PM Changeset in webkit [68631] by tkent@chromium.org
  • 2 edits in trunk/WebCore

2010-09-28 Kent Tamura <tkent@chromium.org>

Unreviewed, windows build fix for r68629.

  • WebCore.vcproj/WebCore.vcproj: Add TimeInputType.{cpp,h}
11:27 PM Changeset in webkit [68630] by commit-queue@webkit.org
  • 15 edits
    3 adds in trunk

2010-09-28 Johnny Ding <jnd@chromium.org>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=41292
Some windowed plugins did not handle events through EventHandler, so we
never set right gesture state for those events.
This change is to set right allowPopupsFromPlugin flag to current
execution frame, so WeKit can always get right gesture state on Mac.
From Mac Snow Leopard, the plugin is run under "WebKitPluginHost,app"
process, that process passes the allowPopupsFromPlugin flag to
WKPCEvaluate(in NetscapePluginHostProxy.mm), then flag is set in
NetscapePluginInstanceProxy::evaluate.

  • Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView sendEvent:isDrawRect:]):

2010-09-28 Johnny Ding <jnd@chromium.org>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=41292
Pass the right popupAllowed flag to current execution frame,
so WebKit can get right gesture status for popups initiated
from plugins.
This also makes v8 binding's ScriptController::processingUserGesture
match what jsc version.

Test: plugins/plugin-initiate-popup-window.html

  • bindings/v8/NPV8Object.cpp: (_NPN_EvaluateHelper):
  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::ScriptController): (WebCore::ScriptController::processingUserGesture):
  • bindings/v8/ScriptController.h: (WebCore::ScriptController::setAllowPopupsFromPlugin): (WebCore::ScriptController::allowPopupsFromPlugin):

2010-09-28 Johnny Ding <jnd@chromium.org>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=41292.
Add a test to initiate popup windows from plugin during plugin is
handling mouse/keyboard event.
Disable this test on gtk/qt/win since the test plugin in those platforms
didn't implement NPP_HandleEvent.

  • platform/chromium-win/plugins/plugin-initiate-popup-window-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • plugins/plugin-initiate-popup-window-expected.txt: Added.
  • plugins/plugin-initiate-popup-window.html: Added.

2010-09-28 Johnny Ding <jnd@chromium.org>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=41292
Add a new parameter to the test plugin to allow specifying a script
and a mouse/keyboard event. The specified script will be evaluated
in the browser when the specified event is received by the plugin.

  • DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp: (pluginAllocate):
  • DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
  • DumpRenderTree/TestNetscapePlugIn/main.cpp: (NPP_New): (handleEventCarbon): (handleEventCocoa):
11:18 PM Changeset in webkit [68629] by tkent@chromium.org
  • 10 edits
    54 adds in trunk/WebCore

Refactor HTMLInputElement: Introducing InputType class and classes
for each input element types.
https://bugs.webkit.org/show_bug.cgi?id=45872

Reviewed by Darin Adler.

No new tests because this doesn't change any behavior.

  • Android.mk: Add new files.
  • CMakeLists.txt: ditto.
  • GNUmakefile.am: ditto.
  • WebCore.gypi: ditto.
  • WebCore.pro: ditto.
  • WebCore.vcproj/WebCore.vcproj: ditto.
  • WebCore.xcodeproj/project.pbxproj: ditto.
  • html/BaseTextInputType.cpp: Added.

(WebCore::BaseTextInputType::isTextType):
(WebCore::BaseTextInputType::patternMismatch):

  • html/BaseTextInputType.h: Added.

(WebCore::BaseTextInputType::BaseTextInputType):

  • html/ButtonInputType.cpp: Added.

(WebCore::ButtonInputType::create):
(WebCore::ButtonInputType::formControlType):

  • html/ButtonInputType.h: Added.

(WebCore::ButtonInputType::ButtonInputType):

  • html/CheckboxInputType.cpp: Added.

(WebCore::CheckboxInputType::create):
(WebCore::CheckboxInputType::formControlType):

  • html/CheckboxInputType.h: Added.

(WebCore::CheckboxInputType::CheckboxInputType):

  • html/ColorInputType.cpp: Added.

(WebCore::ColorInputType::create):
(WebCore::ColorInputType::formControlType):

  • html/ColorInputType.h: Added.

(WebCore::ColorInputType::ColorInputType):

  • html/DateInputType.cpp: Added.

(WebCore::DateInputType::create):
(WebCore::DateInputType::formControlType):

  • html/DateInputType.h: Added.

(WebCore::DateInputType::DateInputType):

  • html/DateTimeInputType.cpp: Added.

(WebCore::DateTimeInputType::create):
(WebCore::DateTimeInputType::formControlType):

  • html/DateTimeInputType.h: Added.

(WebCore::DateTimeInputType::DateTimeInputType):

  • html/DateTimeLocalInputType.cpp: Added.

(WebCore::DateTimeLocalInputType::create):
(WebCore::DateTimeLocalInputType::formControlType):

  • html/DateTimeLocalInputType.h: Added.

(WebCore::DateTimeLocalInputType::DateTimeLocalInputType):

  • html/EmailInputType.cpp: Added.

(WebCore::EmailInputType::create):
(WebCore::EmailInputType::formControlType):

  • html/EmailInputType.h: Added.

(WebCore::EmailInputType::EmailInputType):

  • html/FileInputType.cpp: Added.

(WebCore::FileInputType::create):
(WebCore::FileInputType::formControlType):

  • html/FileInputType.h: Added.

(WebCore::FileInputType::FileInputType):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::HTMLInputElement): Initialize m_inputType.
(WebCore::HTMLInputElement::patternMismatch): Delegate to InputType.
(WebCore::HTMLInputElement::updateType): Update m_inputType with new type.
(WebCore::HTMLInputElement::formControlType): Delegate to InputType.
(WebCore::HTMLInputElement::isTextField): ditto.
(WebCore::HTMLInputElement::isTextType): ditto.

  • html/HTMLInputElement.h:
  • html/HiddenInputType.cpp: Added.

(WebCore::HiddenInputType::create):
(WebCore::HiddenInputType::formControlType):

  • html/HiddenInputType.h: Added.

(WebCore::HiddenInputType::HiddenInputType):

  • html/ImageInputType.cpp: Added.

(WebCore::ImageInputType::create):
(WebCore::ImageInputType::formControlType):

  • html/ImageInputType.h: Added.

(WebCore::ImageInputType::ImageInputType):

  • html/InputType.cpp: Added.

(WebCore::createInputTypeFactoryMap):
(WebCore::InputType::create):
(WebCore::InputType::createText):
(WebCore::InputType::~InputType):
(WebCore::InputType::isTextField):
(WebCore::InputType::isTextType):
(WebCore::InputType::patternMismatch):
(WebCore::InputTypeNames::button):
(WebCore::InputTypeNames::checkbox):
(WebCore::InputTypeNames::color):
(WebCore::InputTypeNames::date):
(WebCore::InputTypeNames::datetime):
(WebCore::InputTypeNames::datetimelocal):
(WebCore::InputTypeNames::email):
(WebCore::InputTypeNames::file):
(WebCore::InputTypeNames::hidden):
(WebCore::InputTypeNames::image):
(WebCore::InputTypeNames::isindex):
(WebCore::InputTypeNames::month):
(WebCore::InputTypeNames::number):
(WebCore::InputTypeNames::password):
(WebCore::InputTypeNames::radio):
(WebCore::InputTypeNames::range):
(WebCore::InputTypeNames::reset):
(WebCore::InputTypeNames::search):
(WebCore::InputTypeNames::submit):
(WebCore::InputTypeNames::telephone):
(WebCore::InputTypeNames::text):
(WebCore::InputTypeNames::time):
(WebCore::InputTypeNames::url):
(WebCore::InputTypeNames::week):

  • html/InputType.h: Added.

(WebCore::InputType::InputType):
(WebCore::InputType::element):

  • html/IsIndexInputType.cpp: Added.

(WebCore::IsIndexInputType::create):
(WebCore::IsIndexInputType::formControlType):

  • html/IsIndexInputType.h: Added.

(WebCore::IsIndexInputType::IsIndexInputType):

  • html/MonthInputType.cpp: Added.

(WebCore::MonthInputType::create):
(WebCore::MonthInputType::formControlType):

  • html/MonthInputType.h: Added.

(WebCore::MonthInputType::MonthInputType):

  • html/NumberInputType.cpp: Added.

(WebCore::NumberInputType::create):
(WebCore::NumberInputType::formControlType):

  • html/NumberInputType.h: Added.

(WebCore::NumberInputType::NumberInputType):

  • html/PasswordInputType.cpp: Added.

(WebCore::PasswordInputType::create):
(WebCore::PasswordInputType::formControlType):

  • html/PasswordInputType.h: Added.

(WebCore::PasswordInputType::PasswordInputType):

  • html/RadioInputType.cpp: Added.

(WebCore::RadioInputType::create):
(WebCore::RadioInputType::formControlType):

  • html/RadioInputType.h: Added.

(WebCore::RadioInputType::RadioInputType):

  • html/RangeInputType.cpp: Added.

(WebCore::RangeInputType::create):
(WebCore::RangeInputType::formControlType):

  • html/RangeInputType.h: Added.

(WebCore::RangeInputType::RangeInputType):

  • html/ResetInputType.cpp: Added.

(WebCore::ResetInputType::create):
(WebCore::ResetInputType::formControlType):

  • html/ResetInputType.h: Added.

(WebCore::ResetInputType::ResetInputType):

  • html/SearchInputType.cpp: Added.

(WebCore::SearchInputType::create):
(WebCore::SearchInputType::formControlType):

  • html/SearchInputType.h: Added.

(WebCore::SearchInputType::SearchInputType):

  • html/SubmitInputType.cpp: Added.

(WebCore::SubmitInputType::create):
(WebCore::SubmitInputType::formControlType):

  • html/SubmitInputType.h: Added.

(WebCore::SubmitInputType::SubmitInputType):

  • html/TelephoneInputType.cpp: Added.

(WebCore::TelephoneInputType::create):
(WebCore::TelephoneInputType::formControlType):

  • html/TelephoneInputType.h: Added.

(WebCore::TelephoneInputType::TelephoneInputType):

  • html/TextFieldInputType.cpp: Added.

(WebCore::TextFieldInputType::isTextField):

  • html/TextFieldInputType.h: Added.

(WebCore::TextFieldInputType::TextFieldInputType):

  • html/TextInputType.cpp: Added.

(WebCore::TextInputType::create):
(WebCore::TextInputType::formControlType):

  • html/TextInputType.h: Added.

(WebCore::TextInputType::TextInputType):

  • html/TimeInputType.cpp: Added.

(WebCore::TimeInputType::create):
(WebCore::TimeInputType::formControlType):

  • html/TimeInputType.h: Added.

(WebCore::TimeInputType::TimeInputType):

  • html/URLInputType.cpp: Added.

(WebCore::URLInputType::create):
(WebCore::URLInputType::formControlType):

  • html/URLInputType.h: Added.

(WebCore::URLInputType::URLInputType):

  • html/WeekInputType.cpp: Added.

(WebCore::WeekInputType::create):
(WebCore::WeekInputType::formControlType):

  • html/WeekInputType.h: Added.

(WebCore::WeekInputType::WeekInputType):

10:59 PM Changeset in webkit [68628] by hyatt@apple.com
  • 4 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=46782, rename the top and bottom margin quirk getters/setters.

Reviewed by Maciej Stachowiak.

Also do a bit of cleanup for block flow roots. Make sure they don't try to propagate overhanging floats out
to ancestors.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::collapseMargins):
(WebCore::RenderBlock::setCollapsedBottomMargin):
(WebCore::RenderBlock::addOverhangingFloats):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::RenderObject):

  • rendering/RenderObject.h:

(WebCore::RenderObject::isMarginBeforeQuirk):
(WebCore::RenderObject::isMarginAfterQuirk):
(WebCore::RenderObject::setMarginBeforeQuirk):
(WebCore::RenderObject::setMarginAfterQuirk):

10:59 PM Changeset in webkit [68627] by Simon Fraser
  • 2 edits in trunk/WebKitTools

2010-09-28 Simon Fraser <Simon Fraser>

Fix export by adding missing argument.

  • CSSTestSuiteHarness/harness/harness.js: (TestSuite.prototype.showResultsForAllTests):
10:38 PM Changeset in webkit [68626] by hyatt@apple.com
  • 7 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=46780

Reviewed by Sam Weinig.

Rename the pos/neg/collapsed margin methods. Rename all the members of the RenderBlockRareData struct.
No logical changes. Just renames.

  • editing/TextIterator.cpp:

(WebCore::shouldEmitExtraNewlineForNode):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::MarginInfo::MarginInfo):
(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::collapseMargins):
(WebCore::RenderBlock::clearFloatsIfNeeded):
(WebCore::RenderBlock::estimateVerticalPosition):
(WebCore::RenderBlock::setCollapsedBottomMargin):
(WebCore::RenderBlock::layoutBlockChild):
(WebCore::RenderBlock::paintChildren):
(WebCore::RenderBlock::lowestPosition):
(WebCore::RenderBlock::setMaxMarginBeforeValues):
(WebCore::RenderBlock::setMaxMarginAfterValues):
(WebCore::RenderBlock::absoluteRects):
(WebCore::RenderBlock::absoluteQuads):
(WebCore::RenderBlock::rectWithOutlineForRepaint):
(WebCore::RenderBlock::addFocusRingRects):

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::maxPosMarginBefore):
(WebCore::RenderBlock::maxNegMarginBefore):
(WebCore::RenderBlock::maxPosMarginAfter):
(WebCore::RenderBlock::maxNegMarginAfter):
(WebCore::RenderBlock::initMaxMarginValues):
(WebCore::RenderBlock::maxMarginBefore):
(WebCore::RenderBlock::maxMarginAfter):
(WebCore::RenderBlock::RenderBlockRareData::RenderBlockRareData):
(WebCore::RenderBlock::RenderBlockRareData::beforePosDefault):
(WebCore::RenderBlock::RenderBlockRareData::beforeNegDefault):
(WebCore::RenderBlock::RenderBlockRareData::afterPosDefault):
(WebCore::RenderBlock::RenderBlockRareData::afterNegDefault):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeLogicalHeight):

  • rendering/RenderBox.h:

(WebCore::RenderBox::collapsedMarginBefore):
(WebCore::RenderBox::collapsedMarginAfter):
(WebCore::RenderBox::maxMarginBefore):
(WebCore::RenderBox::maxMarginAfter):

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutBlock):

10:14 PM Changeset in webkit [68625] by Simon Fraser
  • 3 edits in trunk/WebKitTools

2010-09-28 Simon Fraser <Simon Fraser>

No review

Show which tests have been run by dimming them out in the test list.

Adjust some element sizes.

  • CSSTestSuiteHarness/harness/harness.css: (#test-list > option.untested): (#test-list > option.completed): (#output): (.output-options):
  • CSSTestSuiteHarness/harness/harness.js: (Test): (TestSuite.prototype.fillTestList): (TestSuite.prototype.updateTestList): (TestSuite.prototype.setSelectedChapter): (TestSuite.prototype.recordResult): (TestSuite.prototype.markTestCompleted): (TestSuite.prototype.testCompletionStateChanged): (TestSuite.prototype.loadTestStatus):
9:35 PM Changeset in webkit [68624] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2010-09-28 MORITA Hajime <morrita@google.com>

Unreviewed; update test expectations.

  • platform/chromium/test_expectations.txt:
9:10 PM Changeset in webkit [68623] by kevino@webkit.org
  • 2 edits in trunk/WebKitTools

[wx] Build fix, add missing import.

9:06 PM Changeset in webkit [68622] by kevino@webkit.org
  • 3 edits in trunk/WebCore

[wx] wxMSW build fix. Don't use multiple inheritance in PopupMenuWx to avoid debug build
compiler error about ambiguity over which new override (wx's or FastAllocBase's) to use.

9:00 PM Changeset in webkit [68621] by Simon Fraser
  • 2 edits in trunk/WebKitTools

2010-09-28 Simon Fraser <Simon Fraser>

No review.

Implement export of various queries on the test database, sharing
code with that which displays results inline.

  • CSSTestSuiteHarness/harness/harness.js: (): (TestSuite.prototype.exportResultsCompletion.var): (TestSuite.prototype.exportResultsCompletion): (TestSuite.prototype.showResultsForCompletedTests): (TestSuite.prototype.exportResultsForCompletedTests): (TestSuite.prototype.showResultsForAllTests): (TestSuite.prototype.exportResultsForAllTests): (TestSuite.prototype.exportResultsForTestsNotRun): (TestSuite.prototype.exportResultsForTestsWithStatus): (TestSuite.prototype.exportResultsForTestsWithMismatchedResults):
7:43 PM Changeset in webkit [68620] by morrita@google.com
  • 1 edit
    2 adds in trunk/LayoutTests

2010-09-28 MORITA Hajime <morrita@google.com>

Unreviewed; new test baselines.

  • platform/chromium-win/animations/opacity-transform-animation-expected.checksum: Added.
  • platform/chromium-win/animations/opacity-transform-animation-expected.png: Added.
6:37 PM Changeset in webkit [68619] by mihaip@chromium.org
  • 3 edits
    3 adds in trunk/LayoutTests

2010-09-28 Mihai Parparita <mihaip@chromium.org>

Reviewed by Simon Fraser.

[Chromium] animations/opacity-transform-animation.html fails on Chromium
https://bugs.webkit.org/show_bug.cgi?id=46557

Make transition from .7 opacity to 1.0 (instead of .8 to .9). The
mid-point (where the pixel dump is done) is the same, but the overall
change is more obvious, so failures are more noticeable.

Update Chromium baselines (it has a slightly different intermediate
color; (38, 109, 0) vs. (32, 110, 0) for the Mac port, albeit one which
agrees with the expected interpolated value better).

  • animations/opacity-transform-animation.html:
  • platform/chromium/animations/opacity-transform-animation-expected.checksum: Added.
  • platform/chromium/animations/opacity-transform-animation-expected.png: Added.
  • platform/chromium/test_expectations.txt:
6:36 PM Changeset in webkit [68618] by xji@chromium.org
  • 2 edits in trunk/WebCore

2010-09-28 Xiaomei Ji <xji@chromium.org>

Reviewed by NOBODY (revert unsquashed git commits)

Revert change sets 68583 to 68590, which are un-squashed git-commits: Performance improvement for FontLinux regarding issue 46374.
https://bugs.webkit.org/show_bug.cgi?id=46374

6:20 PM Changeset in webkit [68617] by Simon Fraser
  • 2 edits in trunk/WebKitTools

2010-09-28 Simon Fraser <Simon Fraser>

No review.

Work around uncertainty about the order of database
transactions when creating the database, so that we don't
try to query the table before it has been created.

  • CSSTestSuiteHarness/harness/harness.js: (TestSuite): (TestSuite.prototype.databaseCreated): (TestSuite.prototype.storeTestResult): (TestSuite.prototype.populateDatabaseFromTestInfoData): (TestSuite.prototype.queryDatabaseForTestsWithStatus): (TestSuite.prototype.queryDatabaseForTestsWithMixedStatus): (TestSuite.prototype.queryDatabaseForCompletedTests): (TestSuite.prototype.queryDatabaseForTestsNotRun):
5:45 PM Changeset in webkit [68616] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

2010-09-28 Stephen White <senorblanco@chromium.org>

Unreviewed; update test expectations.

[CHROMIUM] Update Chromium/Linux test expectations.

  • platform/chromium/test_expectations.txt:
5:44 PM Changeset in webkit [68615] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-09-28 Marc-Antoine Ruel <maruel@chromium.org>

Reviewed by Tony Chang.

Split webcore_html off webcore_remaining.

webcore_remaining is still too large for certain 32 bits toolsets.
https://bugs.webkit.org/show_bug.cgi?id=46445

  • WebCore.gyp/WebCore.gyp:
5:23 PM Changeset in webkit [68614] by senorblanco@chromium.org
  • 5 edits
    5 adds in trunk/LayoutTests

2010-09-28 Stephen White <senorblanco@chromium.org>

Unreviewed; update test expectations.

[CHROMIUM] Add some new test baselines and expectations.

  • platform/chromium-linux/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-mac/canvas: Added.
  • platform/chromium-mac/canvas/philip: Added.
  • platform/chromium-mac/canvas/philip/tests: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.drawImage.null-expected.txt: Added.
  • platform/chromium-mac/canvas/philip/tests/2d.pattern.image.null-expected.txt: Added.
  • platform/chromium-mac/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium/test_expectations.txt:
5:14 PM Changeset in webkit [68613] by commit-queue@webkit.org
  • 3 edits in trunk/WebCore

2010-09-28 Jia Pu <jpu@apple.com>

Reviewed by Dan Bernstein.

Delete and forward delete shouldn't start autocorrection panel timer.
https://bugs.webkit.org/show_bug.cgi?id=46679
<rdar://problem/8463917>

  • editing/TypingCommand.cpp: (WebCore::TypingCommand::markMisspellingsAfterTyping): Only start correction panel timer when the editing command is InsertText. (WebCore::TypingCommand::typingAddedToOpenCommand): Add an argument to pass in command type.
  • editing/TypingCommand.h: Add an argument to typingAddedToOpenCommand().
5:13 PM Changeset in webkit [68612] by andersca@apple.com
  • 8 edits
    1 add in trunk/WebKit2

Paint the plug-in backing store into the WebProcess backing store
https://bugs.webkit.org/show_bug.cgi?id=46768

Reviewed by Sam Weinig.

  • DerivedSources.make:

Add PluginProxy.

  • Platform/CoreIPC/MessageID.h:

Add PluginProxy message class.

  • PluginProcess/PluginControllerProxy.cpp:

(WebKit::PluginControllerProxy::paint):
Let the web process know that we've painted.

  • WebKit2.xcodeproj/project.pbxproj:

Add new files.

  • WebProcess/Plugins/PluginProcessConnection.cpp:

(WebKit::PluginProcessConnection::didReceiveMessage):
Pass the message on to a plug-in proxy.

  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::paint):
Paint our backing store into the graphics context.

(WebKit::PluginProxy::controller):
Add notImplemented().

(WebKit::PluginProxy::update):
Blit the plug-in backing store into the local backing store and tell the plug-in
controller that we want to repaint.

  • WebProcess/Plugins/PluginProxy.messages.in: Added.
5:04 PM Changeset in webkit [68611] by crogers@google.com
  • 32 edits
    2 copies in branches/audio/WebCore

audio branch: changes in preparation for moving code to trunk

  • split out DelayDSPKernel from DelayProcessor file
  • HRTFDatabase and HRTFDatabaseLoader (as landed in trunk)
  • HRTFPanner, AudioChannelMerger, AudioChannelSplitter, AudioGainNode cleanup
  • implemented basic versions of initialize() and uninitialize() in AudioNode - made m_isInitialized private
  • fix AudioContext to use newest HRTFDatabaseLoader API
  • fix AudioParam to reject NAN and INF values.
  • fix CachedAudio to not crash and instead call onerror handler if audio file data is invalid.
4:53 PM Changeset in webkit [68610] by andersca@apple.com
  • 12 edits
    1 add in trunk

Begin hooking up painting in the plug-in process
https://bugs.webkit.org/show_bug.cgi?id=46766

Reviewed by Sam Weinig.

JavaScriptCore:

Add tryFastRealloc, used by WebKit2.

WebKit2:

  • DerivedSources.make:

Add PluginControllerProxy.

  • Platform/CoreIPC/MessageID.h:

Add a MessageClassPluginControllerProxy message class.

  • PluginProcess/PluginControllerProxy.cpp:

(WebKit::PluginControllerProxy::PluginControllerProxy):
Initialize the paint timer.

(WebKit::PluginControllerProxy::paint):
Create a graphics context referencing our backing store and paint into it.

(WebKit::PluginControllerProxy::invalidate):
Update the dirty rect and start the paint timer if necessary.

(WebKit::PluginControllerProxy::geometryDidChange):
If we're passed a new backing store handle, reinitialize the backing store.

  • PluginProcess/PluginControllerProxy.messages.in: Added.
  • PluginProcess/WebProcessConnection.cpp:

(WebKit::WebProcessConnection::didReceiveMessage):
If the message has a destination ID, forward it to the plug-in controller proxy.

  • Scripts/webkit2/messages.py:

Always include WebCoreArgumentCoders.h if the type is in the WebCore namespace.

  • WebKit2.xcodeproj/project.pbxproj:

Add new files.

  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::geometryDidChange):
Update the size of the backing store. Create a new plug-in backing store if needed and send
it over to the plug-in process.

4:50 PM Changeset in webkit [68609] by mihaip@chromium.org
  • 3 edits
    6 adds in trunk

2010-09-28 Mihai Parparita <mihaip@chromium.org>

Reviewed by Dimitri Glazkov.

No back/forward list entry added when submitting a form via an onclick handler inside a frame
https://bugs.webkit.org/show_bug.cgi?id=44140

Add tests for user-gesture initiated form submissions inside iframes to
make sure that they generate back/forward list entries.

  • fast/history/form-submit-in-frame-expected.txt: Added.
  • fast/history/form-submit-in-frame-via-onclick-expected.txt: Added.
  • fast/history/form-submit-in-frame-via-onclick.html: Added.
  • fast/history/form-submit-in-frame.html: Added.
  • fast/history/resources/form-with-input-submit.html: Added.
  • fast/history/resources/form-with-onclick-submit.html: Added.

2010-09-28 Mihai Parparita <mihaip@chromium.org>

Reviewed by Dimitri Glazkov.

No back/forward list entry added when submitting a form via an onclick handler inside a frame
https://bugs.webkit.org/show_bug.cgi?id=44140

Lock the back/forward list for JavaScript form submissions inside frames
only if they're not in response to user gestures.

Tests: fast/history/form-submit-in-frame-via-onclick.html

fast/history/form-submit-in-frame.html

  • loader/RedirectScheduler.cpp: (WebCore::RedirectScheduler::scheduleFormSubmission):
4:42 PM Changeset in webkit [68608] by senorblanco@chromium.org
  • 1 edit
    16 adds in trunk/LayoutTests

2010-09-28 Stephen White <senorblanco@chromium.org>

Unreviewed; new Chromium/Win test baselines.

[CHROMIUM] These are tests we were passing on Chrome, but are now listed as failing due to r68568. Adding platform-specific baselines should make us pass them again.

  • platform/chromium-win/canvas: Added.
  • platform/chromium-win/canvas/philip: Added.
  • platform/chromium-win/canvas/philip/tests: Added.
  • platform/chromium-win/canvas/philip/tests/2d.drawImage.null-expected.txt: Added.
  • platform/chromium-win/canvas/philip/tests/2d.gradient.radial.cone.front-expected.txt: Added.
  • platform/chromium-win/canvas/philip/tests/2d.gradient.radial.inside2-expected.txt: Added.
  • platform/chromium-win/canvas/philip/tests/2d.gradient.radial.inside3-expected.txt: Added.
  • platform/chromium-win/canvas/philip/tests/2d.gradient.radial.outside1-expected.txt: Added.
  • platform/chromium-win/canvas/philip/tests/2d.line.cap.closed-expected.txt: Added.
  • platform/chromium-win/canvas/philip/tests/2d.line.join.parallel-expected.txt: Added.
  • platform/chromium-win/canvas/philip/tests/2d.line.miter.lineedge-expected.txt: Added.
  • platform/chromium-win/canvas/philip/tests/2d.pattern.image.null-expected.txt: Added.
  • platform/chromium-win/canvas/philip/tests/2d.shadow.enable.x-expected.txt: Added.
  • platform/chromium-win/canvas/philip/tests/2d.shadow.enable.y-expected.txt: Added.
  • platform/chromium-win/canvas/philip/tests/2d.strokeRect.zero.4-expected.txt: Added.
  • platform/chromium-win/canvas/philip/tests/toDataURL.jpeg.alpha-expected.txt: Added.
4:34 PM Changeset in webkit [68607] by mrowe@apple.com
  • 4 edits in branches/safari-533.19-branch/WebKitTools

Build fix. Roll out some DRT changes that lack the necessary infrastructure to build correctly.

4:34 PM Changeset in webkit [68606] by vangelis@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-09-28 Vangelis Kokkevis <vangelis@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Keep the accelerated compositor around even after a page is
done using it to avoid startup costs in pages that frequently switch
the compositor on and off.
https://bugs.webkit.org/show_bug.cgi?id=45845

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
4:19 PM Changeset in webkit [68605] by hyatt@apple.com
  • 2 edits in trunk/WebCore

Fix typo in previous checkin.

Reviewed by Sam Weinig.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::MarginInfo::MarginInfo):

4:04 PM Changeset in webkit [68604] by commit-queue@webkit.org
  • 7 edits in trunk

2010-09-28 Nat Duca <nduca@chromium.org>

Reviewed by James Robinson.

[chromium] invalidateRootLayerRect needs to schedule compositor
https://bugs.webkit.org/show_bug.cgi?id=46219

Update comments on LayerChromium commit/display functions to clarify
their limitations. Remove unused dirtying logic from
LayerRendererChromium.

  • platform/graphics/chromium/LayerChromium.cpp: (WebCore::LayerChromium::setNeedsCommit): (WebCore::LayerChromium::setNeedsDisplay):
  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::LayerRendererChromium): (WebCore::LayerRendererChromium::present):
  • platform/graphics/chromium/LayerRendererChromium.h:

2010-09-28 Nat Duca <nduca@chromium.org>

Reviewed by James Robinson.

[chromium] invalidateRootLayerRect needs to schedule compositor
https://bugs.webkit.org/show_bug.cgi?id=46219

Make sure setRootLayerNedsDisplay is called by root invalidation.
To avoid confusion about root-layer versus non-root-layer
behavior, move the root layer damage state to the WebView.

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::setRootLayerNeedsDisplay): (WebKit::WebViewImpl::scrollRootLayerRect): (WebKit::WebViewImpl::invalidateRootLayerRect): (WebKit::WebViewImpl::doComposite):
  • src/WebViewImpl.h:
4:02 PM Changeset in webkit [68603] by mrowe@apple.com
  • 4 edits
    2 adds in branches/safari-533.19-branch

Merge r67236.

4:00 PM Changeset in webkit [68602] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533.19-branch

Merge r63865.

3:58 PM Changeset in webkit [68601] by mrowe@apple.com
  • 3 edits
    6 adds in branches/safari-533.19-branch

Merge r65329.

3:56 PM Changeset in webkit [68600] by mrowe@apple.com
  • 5 edits
    9 adds in branches/safari-533.19-branch

Merge r60608.

3:55 PM Changeset in webkit [68599] by tony@chromium.org
  • 6 edits in trunk/WebKitTools

2010-09-28 Tony Chang <tony@chromium.org>

Reviewed by Eric Seidel.

add python keyring support to webkit-patch
https://bugs.webkit.org/show_bug.cgi?id=41269

  • Scripts/webkitpy/common/net/credentials.py: Add the ability to read passwords using

the python keyring module

  • Scripts/webkitpy/common/net/credentials_unittest.py:
  • Scripts/webkitpy/common/system/user.py: Allow confirm() to default to no and add testing params.
  • Scripts/webkitpy/common/system/user_unittest.py:
  • Scripts/webkitpy/tool/mocktool.py:
3:53 PM Changeset in webkit [68598] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533.19-branch

Merge r66911.

3:52 PM Changeset in webkit [68597] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533.19-branch

Merge r66052.

3:52 PM Changeset in webkit [68596] by arv@chromium.org
  • 2 edits in trunk/LayoutTests

2010-09-28 Erik Arvidsson <arv@chromium.org>

Reviewed by Ojan Vafai.

Fix perf/class-list-remove test
https://bugs.webkit.org/show_bug.cgi?id=46745

Make sure we precompute the className in the setup functions and that
we reset it before calling classList.remove.

  • perf/class-list-remove.html:
3:50 PM Changeset in webkit [68595] by senorblanco@chromium.org
  • 7 edits in trunk/LayoutTests

2010-09-28 Stephen White <senorblanco@chromium.org>

Unreviewed; new test baselines.

[CHROMIUM] Update test baselines after r68561.

  • platform/chromium-linux/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-linux/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-mac/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
3:50 PM Changeset in webkit [68594] by mrowe@apple.com
  • 2 edits in branches/safari-533.19-branch/WebCore

Merge r64158.

3:48 PM Changeset in webkit [68593] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533.19-branch

Merge r65748.

3:47 PM Changeset in webkit [68592] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533.19-branch

Merge r65090.

3:44 PM Changeset in webkit [68591] by mrowe@apple.com
  • 4 edits in branches/safari-533.19-branch

Merge r65280.

3:43 PM Changeset in webkit [68590] by xji@chromium.org
  • 1 edit in trunk/WebCore/ChangeLog

Performance improvement for FontLinux.

3:43 PM Changeset in webkit [68589] by xji@chromium.org
  • 1 edit in trunk/WebCore/ChangeLog

Performance improvement for FontLinux.

3:43 PM Changeset in webkit [68588] by xji@chromium.org
  • 1 edit in trunk/WebCore/platform/graphics/chromium/FontLinux.cpp

Performance improvement for FontLinux.

3:43 PM Changeset in webkit [68587] by xji@chromium.org
  • 1 edit in trunk/WebCore/ChangeLog

Performance improvement for FontLinux.

3:43 PM Changeset in webkit [68586] by xji@chromium.org
  • 1 edit in trunk/WebCore/platform/graphics/chromium/FontLinux.cpp

Performance improvement for FontLinux.

3:43 PM Changeset in webkit [68585] by xji@chromium.org
  • 1 edit in trunk/WebCore/platform/graphics/chromium/FontLinux.cpp

Performance improvement for FontLinux.

3:43 PM Changeset in webkit [68584] by xji@chromium.org
  • 1 edit in trunk/WebCore/ChangeLog

Performance improvement for FontLinux.

3:42 PM Changeset in webkit [68583] by xji@chromium.org
  • 1 edit in trunk/WebCore/platform/graphics/chromium/FontLinux.cpp

Performance improvment for FontLinux

3:42 PM Changeset in webkit [68582] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533.19-branch

Merge r64293.

3:40 PM Changeset in webkit [68581] by mrowe@apple.com
  • 2 edits in branches/safari-533.19-branch/WebCore

Merge r63622.

3:38 PM Changeset in webkit [68580] by mrowe@apple.com
  • 3 edits
    5 adds in branches/safari-533.19-branch

Merge r64077.

3:35 PM Changeset in webkit [68579] by mrowe@apple.com
  • 5 edits
    2 adds in branches/safari-533.19-branch

Merge r63773.

3:33 PM Changeset in webkit [68578] by mrowe@apple.com
  • 7 edits
    2 adds in branches/safari-533.19-branch

Merge r64083.

3:33 PM Changeset in webkit [68577] by mrowe@apple.com
  • 3 edits in branches/safari-533.19-branch/WebCore

Merge r64028.

3:27 PM Changeset in webkit [68576] by commit-queue@webkit.org
  • 34 edits in trunk

2010-09-28 Jenn Braithwaite <jennb@chromium.org>

Reviewed by Dmitry Titov.

Added oldPage param to FrameLoaderClient::didTransferChildFrameToNewDocument.
https://bugs.webkit.org/show_bug.cgi?id=46663

No new tests. API addition only. Will be used in separate patch.

  • loader/EmptyClients.h: (WebCore::EmptyFrameLoaderClient::didTransferChildFrameToNewDocument):
  • loader/FrameLoaderClient.h:
  • page/Frame.cpp: (WebCore::Frame::transferChildFrameToNewDocument): Pass former page to didTransferChildFrameToNewDocument.

2010-09-28 Jenn Braithwaite <jennb@chromium.org>

Reviewed by Dmitry Titov.

Added oldPage param to FrameLoaderClient::didTransferChildFrameToNewDocument.
https://bugs.webkit.org/show_bug.cgi?id=46663

  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::didTransferChildFrameToNewDocument):
  • src/FrameLoaderClientImpl.h:

2010-09-28 Jenn Braithwaite <jennb@chromium.org>

Reviewed by Dmitry Titov.

Added oldPage param to FrameLoaderClient::didTransferChildFrameToNewDocument.
https://bugs.webkit.org/show_bug.cgi?id=46663

  • WebCoreSupport/FrameLoaderClientEfl.cpp: (WebCore::FrameLoaderClientEfl::didTransferChildFrameToNewDocument):
  • WebCoreSupport/FrameLoaderClientEfl.h:

2010-09-28 Jenn Braithwaite <jennb@chromium.org>

Reviewed by Dmitry Titov.

Added oldPage param to FrameLoaderClient::didTransferChildFrameToNewDocument.
https://bugs.webkit.org/show_bug.cgi?id=46663

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::didTransferChildFrameToNewDocument):
  • WebCoreSupport/FrameLoaderClientGtk.h:

2010-09-28 Jenn Braithwaite <jennb@chromium.org>

Reviewed by Dmitry Titov.

Added oldPage param to FrameLoaderClient::didTransferChildFrameToNewDocument.
https://bugs.webkit.org/show_bug.cgi?id=46663

  • WebCoreSupport/FrameLoaderClientHaiku.cpp: (WebCore::FrameLoaderClientHaiku::didTransferChildFrameToNewDocument):
  • WebCoreSupport/FrameLoaderClientHaiku.h:

2010-09-28 Jenn Braithwaite <jennb@chromium.org>

Reviewed by Dmitry Titov.

Added oldPage param to FrameLoaderClient::didTransferChildFrameToNewDocument.
https://bugs.webkit.org/show_bug.cgi?id=46663

  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::didTransferChildFrameToNewDocument):

2010-09-28 Jenn Braithwaite <jennb@chromium.org>

Reviewed by Dmitry Titov.

Added oldPage param to FrameLoaderClient::didTransferChildFrameToNewDocument.
https://bugs.webkit.org/show_bug.cgi?id=46663

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::didTransferChildFrameToNewDocument):
  • WebCoreSupport/FrameLoaderClientQt.h:

2010-09-28 Jenn Braithwaite <jennb@chromium.org>

Reviewed by Dmitry Titov.

Added oldPage param to FrameLoaderClient::didTransferChildFrameToNewDocument.
https://bugs.webkit.org/show_bug.cgi?id=46663

  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::didTransferChildFrameToNewDocument):
  • WebCoreSupport/WebFrameLoaderClient.h:

2010-09-28 Jenn Braithwaite <jennb@chromium.org>

Reviewed by Dmitry Titov.

Added oldPage param to FrameLoaderClient::didTransferChildFrameToNewDocument.
https://bugs.webkit.org/show_bug.cgi?id=46663

  • WebCoreSupport/FrameLoaderClientWinCE.cpp: (WebKit::FrameLoaderClientWinCE::didTransferChildFrameToNewDocument):
  • WebCoreSupport/FrameLoaderClientWinCE.h:

2010-09-28 Jenn Braithwaite <jennb@chromium.org>

Reviewed by Dmitry Titov.

Added oldPage param to FrameLoaderClient::didTransferChildFrameToNewDocument.
https://bugs.webkit.org/show_bug.cgi?id=46663

  • WebKitSupport/FrameLoaderClientWx.cpp: (WebCore::FrameLoaderClientWx::didTransferChildFrameToNewDocument):
  • WebKitSupport/FrameLoaderClientWx.h:

2010-09-28 Jenn Braithwaite <jennb@chromium.org>

Reviewed by Dmitry Titov.

Added oldPage param to FrameLoaderClient::didTransferChildFrameToNewDocument.
https://bugs.webkit.org/show_bug.cgi?id=46663

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::didTransferChildFrameToNewDocument):
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
3:26 PM Changeset in webkit [68575] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533.19-branch

Merge r65826.

3:26 PM Changeset in webkit [68574] by commit-queue@webkit.org
  • 4 edits
    8 adds in trunk

2010-09-28 W. James MacLean <wjmaclean@chromium.org>

Reviewed by James Robinson.

Scaled Resized images are blurred when sent to Skia
https://bugs.webkit.org/show_bug.cgi?id=42370

  • platform/chromium-linux/svg/custom/image-rescale-expected.checksum: Added.
  • platform/chromium-linux/svg/custom/image-rescale-expected.png: Added.
  • platform/chromium-linux/svg/custom/image-rescale-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
  • platform/mac/svg/custom/image-rescale-expected.checksum: Added.
  • platform/mac/svg/custom/image-rescale-expected.png: Added.
  • platform/mac/svg/custom/image-rescale-expected.txt: Added.
  • svg/custom/image-rescale.svg: Added.
  • svg/custom/resources/image-rescale.jpg: Added.

2010-09-28 W. James MacLean <wjmaclean@chromium.org>

Reviewed by James Robinson.

Scaled Resized images are blurred when sent to Skia
https://bugs.webkit.org/show_bug.cgi?id=42370

This patch modifies ImageSkia.cpp to fix the calculation of resampled
bitmap sizes so as to include the transform matrix of the canvas.

Test: svg/custom/image-rescale.svg

  • platform/graphics/skia/ImageSkia.cpp: (WebCore::computeResamplingMode): (WebCore::drawResampledBitmap):
3:24 PM Changeset in webkit [68573] by mrowe@apple.com
  • 7 edits
    2 adds in branches/safari-533.19-branch

Merge r67390.

3:19 PM Changeset in webkit [68572] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533.19-branch

Merge r68108.

3:19 PM Changeset in webkit [68571] by jamesr@google.com
  • 2 edits in trunk/WebCore

2010-09-28 James Robinson <jamesr@chromium.org>

[chromium] Decrease warning level on chromium linux temporarily. This is causing failures on some bots

  • WebCore.gyp/WebCore.gyp:
3:14 PM Changeset in webkit [68570] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533.19-branch

Merge r67209.

3:11 PM Changeset in webkit [68569] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533.19-branch

Merge r63466.

3:10 PM Changeset in webkit [68568] by commit-queue@webkit.org
  • 71 edits in trunk/LayoutTests

2010-09-28 Matthew Delaney <mdelaney@apple.com>

Reviewed by Adele Peterson.

Unskip remaining canvas layout tests so that they can track progressions/regressions
https://bugs.webkit.org/show_bug.cgi?id=46439

3:08 PM Changeset in webkit [68567] by mrowe@apple.com
  • 2 edits in branches/safari-533.19-branch/JavaScriptCore

Merge r65847.

3:08 PM Changeset in webkit [68566] by mrowe@apple.com
  • 14 edits
    3 adds in branches/safari-533.19-branch

Merge r62896.

2:49 PM Changeset in webkit [68565] by senorblanco@chromium.org
  • 16 edits
    7 adds in trunk/LayoutTests

2010-09-28 Stephen White <senorblanco@chromium.org>

Unreviewed; new test baselines.

[CHROMIUM] New chromium baselines post-r68334.

  • platform/chromium-linux/fast/text/basic/014-expected.checksum:
  • platform/chromium-linux/fast/text/basic/014-expected.png:
  • platform/chromium-linux/fast/text/basic/014-expected.txt: Added.
  • platform/chromium-linux/fast/text/capitalize-boundaries-expected.checksum:
  • platform/chromium-linux/fast/text/capitalize-boundaries-expected.png:
  • platform/chromium-linux/fast/text/capitalize-boundaries-expected.txt:
  • platform/chromium-linux/fast/text/midword-break-after-breakable-char-expected.checksum:
  • platform/chromium-linux/fast/text/midword-break-after-breakable-char-expected.png:
  • platform/chromium-linux/fast/text/softHyphen-expected.txt: Added.
  • platform/chromium-linux/fast/text/word-break-soft-hyphen-expected.txt: Added.
  • platform/chromium-mac/fast/text/basic/014-expected.checksum: Added.
  • platform/chromium-mac/fast/text/midword-break-after-breakable-char-expected.checksum: Added.
  • platform/chromium-mac/fast/text/midword-break-after-breakable-char-expected.png: Added.
  • platform/chromium-mac/fast/text/word-break-soft-hyphen-expected.checksum: Added.
  • platform/chromium-win/fast/text/basic/014-expected.checksum:
  • platform/chromium-win/fast/text/basic/014-expected.png:
  • platform/chromium-win/fast/text/basic/014-expected.txt:
  • platform/chromium-win/fast/text/midword-break-after-breakable-char-expected.checksum:
  • platform/chromium-win/fast/text/midword-break-after-breakable-char-expected.png:
  • platform/chromium-win/fast/text/midword-break-after-breakable-char-expected.txt:
  • platform/chromium-win/fast/text/softHyphen-expected.txt:
  • platform/chromium-win/fast/text/word-break-soft-hyphen-expected.txt:
2:48 PM Changeset in webkit [68564] by jamesr@google.com
  • 10 edits in trunk/WebCore

2010-09-27 James Robinson <jamesr@chromium.org>

Reviewed by Tony Chang.

[chromium] Increase warning level for chromium linux build
https://bugs.webkit.org/show_bug.cgi?id=46687

This sets the chromium_code gyp variable to 1 for the chromium
linux WebCore build and fixes the warnings that exposes. This
matches the chromium mac build's compiler settings more closely
and should cut down on the number of patches that break mac but
compile cleaning on linux.

  • WebCore.gyp/WebCore.gyp:
  • platform/chromium/ScrollbarThemeChromiumLinux.cpp: (WebCore::ScrollbarThemeChromiumLinux::paintButton):
  • platform/graphics/chromium/FontLinux.cpp: (WebCore::TextRunWalker::nextScriptRun): (WebCore::TextRunWalker::getTextRun): (WebCore::TextRunWalker::getNormalizedTextRun): (WebCore::TextRunWalker::setGlyphXPositions): (WebCore::glyphIndexForXPositionInScriptRun): (WebCore::Font::offsetForPositionForComplexText): (WebCore::Font::selectionRectForComplexText):
  • platform/graphics/chromium/HarfbuzzSkia.cpp: (WebCore::getOutlinePoint):
  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::updateRootLayerTextureRect):
  • platform/graphics/gpu/Texture.cpp: (WebCore::copySubRect):
  • platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::readbackHardwareToSoftware):
  • platform/image-decoders/gif/GIFImageDecoder.cpp: (WebCore::GIFImageDecoder::setSize):
  • platform/image-decoders/gif/GIFImageDecoder.h:
2:35 PM Changeset in webkit [68563] by Csaba Osztrogonác
  • 4 edits in trunk/WebCore

Fix for r68521 to build on VS2008/Release.

Patch by Stephen White <senorblanco@chromium.org> on 2010-09-28
Reviewed by Csaba Osztrogonác.

  • html/DocTypeStrings.gperf:

Don't emit "#include <string.h>" here, since we're inside a namespace.

  • make-hash-tools.pl:

Emit #include <string.h> manually where required.

  • platform/ColorData.gperf:

Don't emit "#include <string.h>" here, since we're inside a namespace.

2:27 PM Changeset in webkit [68562] by andersca@apple.com
  • 4 edits in trunk/WebKit2

ASSERT when launching the plugin process
https://bugs.webkit.org/show_bug.cgi?id=46754
<rdar://problem/8484570>

Reviewed by Sam Weinig.

  • UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::ProcessLauncher::launchProcess):
Don't assert if we fail to launch the process. Instead, set the connection identifier
and process ID to null and deallocate the port we created.

  • UIProcess/Plugins/PluginProcessProxy.cpp:

(WebKit::PluginProcessProxy::pluginProcessCrashedOrFailedToLaunch):
Move all code from didClose here.

(WebKit::PluginProcessProxy::didClose):
Call pluginProcessCrashedOrFailedToLaunch.

(WebKit::PluginProcessProxy::didFinishLaunching):
If we failed to launch, call pluginProcessCrashedOrFailedToLaunch.

2:16 PM Changeset in webkit [68561] by hyatt@apple.com
  • 16 edits in trunk

Right now we have two properties named margin-top-collapse and margin-after-collapse. They are proprietary and only used by Safari RSS.

Reviewed by Sam Weinig.

I am adding margin-before-collapse and margin-after-collapse and just aliasing the old properties to the new ones.
This way we have some names that are directionally independent.

Note that these properties aren't like other directional properties. They are about what to do with the before side and after side of
your block's margins when collapsing with adjacent blocks. The meaning of before/after depend on the block-flow directionality
of the containing block.

Computed style tests all changed and the remove-shorthand.html test covers manipulation of the shorthand.

WebCore:

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

  • css/CSSPropertyLonghand.cpp:

(WebCore::initShorthandMap):

  • css/CSSPropertyNames.in:
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::MarginInfo::MarginInfo):
(WebCore::RenderBlock::isSelfCollapsingBlock):
(WebCore::RenderBlock::collapseMargins):
(WebCore::RenderBlock::layoutBlockChild):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::diff):

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::marginBeforeCollapse):
(WebCore::InheritedFlags::marginAfterCollapse):
(WebCore::InheritedFlags::setMarginBeforeCollapse):
(WebCore::InheritedFlags::setMarginAfterCollapse):
(WebCore::InheritedFlags::initialMarginBeforeCollapse):
(WebCore::InheritedFlags::initialMarginAfterCollapse):

  • rendering/style/StyleRareNonInheritedData.cpp:

(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):

  • rendering/style/StyleRareNonInheritedData.h:

LayoutTests:

  • fast/css/remove-shorthand-expected.txt:
  • platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • svg/css/getComputedStyle-basic-expected.txt:
2:15 PM Changeset in webkit [68560] by kevino@webkit.org
  • 2 edits in trunk

[wx] Build fix, build sources that used to be built as part of other sources.

2:00 PM Changeset in webkit [68559] by andersca@apple.com
  • 3 edits in trunk/WebKit2

Differentiate waitForSyncReply from waitForReply
https://bugs.webkit.org/show_bug.cgi?id=46752

Reviewed by Sam Weinig.

Since waitForSyncReply is going to need to dispatch incoming sync messages while
waiting for the correct reply, we need to add a new waitForSyncReply function that
can do this.

  • Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::sendSyncMessage):
Push the pending sync reply information on the m_pendingSyncReplies stack,
send the message, wait for a reply and pop the information off the stack.

(CoreIPC::Connection::waitForSyncReply):
Block while waiting for a reply to the sync message with the given ID.

(CoreIPC::Connection::processIncomingMessage):
If the incoming message is a sync reply, set the didReceiveReply flag and the replyDecoder
members in the pending sync reply and signal the client thread to wakeup.

  • Platform/CoreIPC/Connection.h:

Add a stack of PendingSyncReply structs.

1:45 PM Changeset in webkit [68558] by mrobinson@webkit.org
  • 5 edits
    4 adds in trunk

2010-09-28 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[Cairo] FreeType fonts should obey FontConfig hinting/anti-aliasing settings
https://bugs.webkit.org/show_bug.cgi?id=46740

Added a test adapted from platform/chromium/fast/text/chromium-linux-fontconfig-renderstyle.html
which verifies that when rendering text the GTK+ port follows FontConfig settings.

  • platform/gtk/fonts/fontconfig-aliasing-settings-expected.checksum: Added.
  • platform/gtk/fonts/fontconfig-aliasing-settings-expected.png: Added.
  • platform/gtk/fonts/fontconfig-aliasing-settings-expected.txt: Added.
  • platform/gtk/fonts/fontconfig-aliasing-settings.html: Added.

2010-09-28 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[Cairo] FreeType fonts should obey FontConfig hinting/anti-aliasing settings
https://bugs.webkit.org/show_bug.cgi?id=46740

When creating a font from a FontConfig pattern, use the FontConfig pattern's
hinting and anti-aliasing settings. This follows the Chromium Linux approach
of having FontConfig settings take precedence over GTK+ settings, as GTK+
settings cannot be configured per-font and per-font-size.

Test: platform/gtk/fonts/fontconfig-aliasing-settings.html

  • platform/graphics/cairo/FontPlatformDataFreeType.cpp: (WebCore::convertFontConfigSubpixelOrder): Added this helper which converts the FontConfig subpixel order into the cairo equivalent. (WebCore::convertFontConfigHintStyle): Added this helper which converts the FontConfig hint style into the cairo equivalent. (WebCore::setCairoFontOptionsFromFontConfigPattern): Added this helper which reads the font rendering settings from a pattern and translates them into the appropriate cairo_font_options_t settings. (WebCore::FontPlatformData::FontPlatformData): When creating a font from a FontConfig pattern use setCairoFontOptionsFromFontConfigPattern to get the appropriate rendering options for the font.

2010-09-28 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[Cairo] FreeType fonts should obey FontConfig hinting/anti-aliasing settings
https://bugs.webkit.org/show_bug.cgi?id=46740

  • DumpRenderTree/gtk/fonts/fonts.conf: Add specialized variants of common fonts which can be used to fully test FontConfig rendering settings.
1:31 PM Changeset in webkit [68557] by weinig@apple.com
  • 11 edits in trunk

Vertical scroll bar on apple.com is too short with WebKit2
<rdar://problem/8379230>
https://bugs.webkit.org/show_bug.cgi?id=46739

Reviewed by Darin Adler and Dave Hyatt.

WebCore:

Adds a function to recalculate the scrollbars to take advantage of
a changed window re-sizer rect.

  • WebCore.exp.in:
  • platform/ScrollView.cpp:

(WebCore::ScrollView::windowResizerRectChanged):

  • platform/ScrollView.h:

WebKit2:

This gets us most of the way to having correct scroll corner behavior. We should
follow this up by moving to painting the window re-sizer in WebCore.

  • UIProcess/API/mac/WKView.mm:

(-[WKView _ownsWindowGrowBox]):
(-[WKView _updateGrowBoxForWindowFrameChange]): Calculate whether we should
be taking the scroll corner into account when laying out scrollbars.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::setWindowResizerSize):

  • UIProcess/WebPageProxy.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setWindowResizerSize):
(WebKit::WebPage::windowResizerRect): This now returns IntRect() for
non-mac platforms (or any platform that never sends a setWindowResizerSize
message).

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
1:28 PM Changeset in webkit [68556] by hyatt@apple.com
  • 3 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=46750

Reviewed by Sam Weinig.

Rename the MarginInfo members and functions to be block-flow independent.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::MarginInfo::MarginInfo):
(WebCore::RenderBlock::adjustPositionedBlock):
(WebCore::RenderBlock::adjustFloatingBlock):
(WebCore::RenderBlock::collapseMargins):
(WebCore::RenderBlock::clearFloatsIfNeeded):
(WebCore::RenderBlock::estimateVerticalPosition):
(WebCore::RenderBlock::setCollapsedBottomMargin):
(WebCore::RenderBlock::handleBottomOfBlock):
(WebCore::RenderBlock::layoutBlockChild):
(WebCore::RenderBlock::applyAfterBreak):

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::MarginInfo::setAtBeforeSideOfBlock):
(WebCore::RenderBlock::MarginInfo::setAtAfterSideOfBlock):
(WebCore::RenderBlock::MarginInfo::setMarginBeforeQuirk):
(WebCore::RenderBlock::MarginInfo::setMarginAfterQuirk):
(WebCore::RenderBlock::MarginInfo::setDeterminedMarginBeforeQuirk):
(WebCore::RenderBlock::MarginInfo::atBeforeSideOfBlock):
(WebCore::RenderBlock::MarginInfo::canCollapseWithMarginBefore):
(WebCore::RenderBlock::MarginInfo::canCollapseWithMarginAfter):
(WebCore::RenderBlock::MarginInfo::canCollapseMarginBeforeWithChildren):
(WebCore::RenderBlock::MarginInfo::canCollapseMarginAfterWithChildren):
(WebCore::RenderBlock::MarginInfo::determinedMarginBeforeQuirk):
(WebCore::RenderBlock::MarginInfo::marginBeforeQuirk):
(WebCore::RenderBlock::MarginInfo::marginAfterQuirk):

1:19 PM Changeset in webkit [68555] by mitz@apple.com
  • 2 edits in trunk/LayoutTests

Updated expected result to include the soft hyphen character in the plain text output.

  • fast/encoding/charset-xuser-defined-expected.txt:
1:15 PM Changeset in webkit [68554] by mrobinson@webkit.org
  • 2 edits in trunk/WebKitTools

2010-09-28 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[gtk] Fedora has a different path for the liberation fonts
https://bugs.webkit.org/show_bug.cgi?id=46709

When searching for DRT fonts, also look in the path where those fonts
are commonly found on Fedora systems.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (initializeFonts): Include logic for looking for Fedora-style font paths.
1:14 PM Changeset in webkit [68553] by mitz@apple.com
  • 1 edit
    1 add in trunk/LayoutTests

Added Qt-specific results for the test added in the previous change. Qt doesn’t use ICU so
it fails the test.

  • platform/qt/fast/text/find-soft-hyphen-expected.txt: Added.
12:51 PM Changeset in webkit [68552] by mrobinson@webkit.org
  • 4 edits in trunk/WebKitTools

2010-09-28 Martin Robinson <mrobinson@igalia.com>

Reviewed by Andreas Kling.

run-webkit-tests needs an updated list of directories with webgl tests
https://bugs.webkit.org/show_bug.cgi?id=46747

Update the list of directories containing WebGL tests and a unit test
which depends on this list.

  • Scripts/old-run-webkit-tests: Update the list of directories.
  • Scripts/webkitpy/layout_tests/port/webkit.py: Ditto.
  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Update the expected result.
12:38 PM Changeset in webkit [68551] by mitz@apple.com
  • 30 edits
    3 adds in trunk

WebCore: Improved the handling of soft hyphens in Copy and Find operations, addressing the following
bugs:

Reviewed by Darin Adler.

<rdar://problem/7938878> Soft hyphenation and the clipboard
https://bugs.webkit.org/show_bug.cgi?id=11154

window.getSelection().toString() breaks soft hyphen &shy;
https://bugs.webkit.org/show_bug.cgi?id=26774

<rdar://problem/5640505> soft hyphen breaks search function
https://bugs.webkit.org/show_bug.cgi?id=16675

Test: fast/text/find-soft-hyphen.html

Changed line layout code to not skip over soft hyphens but rather include them in the text
boxes. Changed font code to render the soft hyphen character as a zero width space, so that
the former change will not affect rendering of soft hyphens in the middle of the line. Also
changed line layout code to mark text boxes where hyphenation occurred due to a soft hyphen
as hyphenated, so that the hyphen string specified in CSS will be appended to them.

Not omitting the soft hyphens from the text boxes makes the text iterator emit them, which
solves the Copy and plain-text conversion issues. Previously, the iterator would emit a space
to account for non-rendered characters between adjacent boxes, which was wrong in this case.

To make Find work, soft hyphens are folded into 0, which is ignorable in the collation used
for Find.

  • editing/TextIterator.cpp:

(WebCore::foldQuoteMarkOrSoftHyphen): Renamed foldQuoteMark() to this and added folding of
soft hyphen to 0.
(WebCore::foldQuoteMarksAndSoftHyphens): Renamed foldQuoteMarks() to thid and added folding
of soft hyphen to 0.
(WebCore::SearchBuffer::SearchBuffer): Updated for renames.
(WebCore::SearchBuffer::append): Ditto.

  • platform/graphics/Font.h:

(WebCore::Font::treatAsSpace): Replaced number literal with name.
(WebCore::Font::treatAsZeroWidthSpace): Added softHyphen.

  • platform/graphics/GlyphPageTreeNode.cpp:

(WebCore::GlyphPageTreeNode::initializePage): Get the zero width space glyph for soft hyphen.

  • platform/graphics/mac/ComplexTextController.cpp:

(WebCore::ComplexTextController::collectComplexTextRuns): Removed special handling that made
a trailing soft hyphen render as hyphen-minus. All soft hyphens are now rendered as zero width
spaces, and where a line break actually occurs at a soft hyphen, rendering code appends the
CSS-specified hyphenate character to the text run that is passed to us here.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::chopMidpointsAt): Removed this function, which was only used for skipping over soft
hyphens.
(WebCore::checkMidpoints): Removed code related to skipping over soft hyphens.
(WebCore::RenderBlock::findNextLineBreak): Removed code to skip over soft hyphens. Ignore
a line break opportunity at a soft hyphen if the style specifies 'hyphens: none'. Set
'hyphenated' to true if a line break occurs at a soft hyphen.

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::hyphenString): Changed the assertion to allow querying for the hyphen
string for 'hyphens: manual'.

LayoutTests: Improved the handling of soft hyphens in copy and find operations, addressing the following
bugs:

Reviewed by Darin Adler.

<rdar://problem/7938878> Soft hyphenation and the clipboard
https://bugs.webkit.org/show_bug.cgi?id=11154

window.getSelection().toString() breaks soft hyphen &shy;
https://bugs.webkit.org/show_bug.cgi?id=26774

<rdar://problem/5640505> soft hyphen breaks search function
https://bugs.webkit.org/show_bug.cgi?id=16675

  • fast/text/find-soft-hyphen-expected.txt: Added.
  • fast/text/find-soft-hyphen.html: Added.
  • fast/text/script-tests/find-soft-hyphen.js: Added.

(canFind):

  • platform/mac/fast/text/basic/014-expected.checksum:
  • platform/mac/fast/text/basic/014-expected.png:
  • platform/mac/fast/text/basic/014-expected.txt:
  • platform/mac/fast/text/capitalize-boundaries-expected.checksum:
  • platform/mac/fast/text/capitalize-boundaries-expected.png:
  • platform/mac/fast/text/capitalize-boundaries-expected.txt:
  • platform/mac/fast/text/hyphens-expected.checksum:
  • platform/mac/fast/text/hyphens-expected.png:
  • platform/mac/fast/text/hyphens-expected.txt:
  • platform/mac/fast/text/midword-break-after-breakable-char-expected.checksum:
  • platform/mac/fast/text/midword-break-after-breakable-char-expected.png:
  • platform/mac/fast/text/midword-break-after-breakable-char-expected.txt:
  • platform/mac/fast/text/soft-hyphen-2-expected.png:
  • platform/mac/fast/text/soft-hyphen-2-expected.txt:
  • platform/mac/fast/text/soft-hyphen-3-expected.png:
  • platform/mac/fast/text/soft-hyphen-3-expected.txt:
  • platform/mac/fast/text/softHyphen-expected.checksum:
  • platform/mac/fast/text/softHyphen-expected.png:
  • platform/mac/fast/text/softHyphen-expected.txt:
  • platform/mac/fast/text/word-break-soft-hyphen-expected.checksum:
  • platform/mac/fast/text/word-break-soft-hyphen-expected.png:
  • platform/mac/fast/text/word-break-soft-hyphen-expected.txt:
12:33 PM Changeset in webkit [68550] by mrobinson@webkit.org
  • 2 edits in trunk/WebCore

2010-09-28 Martin Robinson <mrobinson@igalia.com>

More GTK+ build fixes after r68521.

  • GNUmakefile.am: Added proper dependency tracking for some new autogenerated files.
12:19 PM Changeset in webkit [68549] by andreas.kling@nokia.com
  • 3 edits
    3 adds in trunk

2010-09-28 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Text drawing taints GraphicsContext's QPainter::pen()
https://bugs.webkit.org/show_bug.cgi?id=46744

Test: fast/canvas/canvas-style-intact-after-text.html

  • platform/graphics/qt/FontQt.cpp: (WebCore::drawTextCommon): Make sure the QPainter's pen is restored after filling and/or stroking text.

2010-09-28 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Text drawing taints GraphicsContext's QPainter::pen()
https://bugs.webkit.org/show_bug.cgi?id=46744

Add test to check that strokeText() doesn't break the fillStyle
and fillText() doesn't break the strokeStyle.

  • fast/canvas/canvas-style-intact-after-text-expected.txt: Added.
  • fast/canvas/canvas-style-intact-after-text.html: Added.
  • fast/canvas/script-tests/canvas-style-intact-after-text.js: Added.
12:14 PM Changeset in webkit [68548] by abarth@webkit.org
  • 5 edits
    1 add in trunk/WebKitTools

2010-09-28 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Introduce FailureMap to summaries the failures status of all the bots
https://bugs.webkit.org/show_bug.cgi?id=46700

This patch gives the SheriffBot a handle on the list of failing tests.

  • Scripts/webkitpy/common/net/buildbot.py:
  • Scripts/webkitpy/common/net/failuremap.py: Added.
  • Scripts/webkitpy/tool/commands/queries.py:
  • Scripts/webkitpy/tool/commands/sheriffbot.py:
  • Scripts/webkitpy/tool/mocktool.py:
11:48 AM Changeset in webkit [68547] by commit-queue@webkit.org
  • 3 edits in trunk/WebCore

2010-09-28 Jia Pu <jpu@apple.com>

Reviewed by Dan Bernstein.

Autocorrection panel is shown at incorrect location when WebView is scrolled.
https://bugs.webkit.org/show_bug.cgi?id=46531
<rdar://problem/8455376>

  • dom/Range.h: Make getBorderAndTextQuads() public so that it can be used by Editor.
  • editing/Editor.cpp: (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): Replaced call to textQuads() with getBorderAndTextQuads().
11:28 AM Changeset in webkit [68546] by andreip@google.com
  • 15 edits in trunk

2010-09-28 Andrei Popescu <andreip@google.com>

Reviewed by Jeremy Orlow.

IDBRequest should not have a method called abort.
https://bugs.webkit.org/show_bug.cgi?id=46720

  • storage/indexeddb/basics-expected.txt:
  • storage/indexeddb/database-basics-expected.txt:
  • storage/indexeddb/index-basics-expected.txt:
  • storage/indexeddb/index-cursor-expected.txt:
  • storage/indexeddb/objectstore-basics-expected.txt:
  • storage/indexeddb/objectstore-cursor-expected.txt:
  • storage/indexeddb/objectstore-removeobjectstore-expected.txt:
  • storage/indexeddb/open-cursor-expected.txt:
  • storage/indexeddb/resources/shared.js: (verifyEventCommon): (verifyResult):
  • storage/indexeddb/transaction-basics-expected.txt:

2010-09-28 Andrei Popescu <andreip@google.com>

Reviewed by Jeremy Orlow.

IDBRequest should not have a method called abort.
https://bugs.webkit.org/show_bug.cgi?id=46720

IDBRequest::abort() was dropped from the spec following discussion in
http://www.w3.org/Bugs/Public/show_bug.cgi?id=10165

  • storage/IDBRequest.cpp: (WebCore::IDBRequest::IDBRequest): (WebCore::IDBRequest::~IDBRequest): (WebCore::IDBRequest::resetReadyState): (WebCore::IDBRequest::timerFired): (WebCore::IDBRequest::scheduleEvent):
  • storage/IDBRequest.h:
  • storage/IDBRequest.idl:
11:12 AM Changeset in webkit [68545] by andersca@apple.com
  • 7 edits in trunk/WebKit2

Implement PluginProxy::destroy
https://bugs.webkit.org/show_bug.cgi?id=46737

Reviewed by Adam Roben.

  • Platform/CoreIPC/HandleMessage.h:

(CoreIPC::handleMessage):
Add overload for a sync message with one in parameter and no out parameters.

  • PluginProcess/WebProcessConnection.cpp:

(WebKit::WebProcessConnection::destroyPluginControllerProxy):
Rename this to avoid conflicts with the destroyPlugin message handler.

(WebKit::WebProcessConnection::destroyPlugin):
Call destroyPluginControllerProxy.

  • PluginProcess/WebProcessConnection.messages.in:

Add DestroyPlugin message.

  • WebProcess/Plugins/PluginProcessConnection.cpp:

(WebKit::PluginProcessConnection::didClose):

  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::PluginProxy):
(WebKit::PluginProxy::~PluginProxy):
Don't add and/the plug-in proxy from the map in the constructor/destructor. Instead,
do it in initialize/destroy, since otherwise we could be calling pluginProcessCrashed on a
PluginController that had already been freed.

(WebKit::PluginProxy::initialize):
(WebKit::PluginProxy::destroy):
send the DestroyPlugin message.

11:10 AM Changeset in webkit [68544] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2010-09-28 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed.

Added editing/pasteboard/paste-table-001.html to the skipped list of gtk platforms
because the test requires editing delegates dump and gtk does not implement it yet.

  • platform/gtk/Skipped:
11:08 AM Changeset in webkit [68543] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

2010-09-28 Stephen White <senorblanco@chromium.org>

Unreviewed; expectations update.

[CHROMIUM] Mark window-geometry-initialized-before-set-window as failing.

  • platform/chromium/test_expectations.txt:
11:05 AM Changeset in webkit [68542] by kevino@webkit.org
  • 2 edits in trunk

[wx] One more build fix for Win.

10:59 AM Changeset in webkit [68541] by Chris Fleizach
  • 8 edits
    2 adds in trunk

CrashTracer: 1,382 crashes in Safari at com.apple.WebCore: WebCore::VisiblePosition::canonicalPosition + 78
https://bugs.webkit.org/show_bug.cgi?id=45927

Reviewed by Beth Dakin.

WebCore:

AXTextMarkers store pointers to Nodes without any retain or reference. If a Node is deallocated and then
a client tries to use a text marker that references that node, it leads to this crash.

The AXObjectCache instance now keeps a HashSet of Node's being used. When a node becomes deallocated, it removes itself
from the HashSet. When creating a VisiblePosition from an AXTextMarker, the cache can then check if the node is valid
before proceeding.

Test: platform/mac/accessibility/crash-invalid-text-marker-node.html

  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::visiblePositionForTextMarkerData):
(WebCore::AXObjectCache::textMarkerDataForVisiblePosition):

Modify to check whether a node is valid before proceeeding.

  • accessibility/AXObjectCache.h:

(WebCore::AXObjectCache::setNodeInUse):
(WebCore::AXObjectCache::removeNodeForUse):
(WebCore::AXObjectCache::isNodeInUse):

Methods for managing whether a node is in use by text markers.

  • accessibility/mac/AccessibilityObjectWrapper.mm:

(textMarkerForVisiblePosition):
(-[AccessibilityObjectWrapper textMarkerForVisiblePosition:]):
(visiblePositionForTextMarker):
(-[AccessibilityObjectWrapper visiblePositionForTextMarker:]):
(visiblePositionForStartOfTextMarkerRange):
(visiblePositionForEndOfTextMarkerRange):
(-[AccessibilityObjectWrapper doAXAttributedStringForTextMarkerRange:]):
(textMarkerRangeFromVisiblePositions):
(-[AccessibilityObjectWrapper textMarkerRangeFromVisiblePositions:endPosition:]):
(-[AccessibilityObjectWrapper visiblePositionRangeForTextMarkerRange:]):
(-[AccessibilityObjectWrapper textMarkerRangeForSelection]):
(-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
(-[AccessibilityObjectWrapper doAXAttributedStringForRange:]):
(-[AccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):

Change these calls so that the axObjectCache() can be passed in to create the visible position.

  • dom/Document.cpp:

(WebCore::Document::axObjectCacheExists):

  • dom/Document.h:
  • dom/Node.cpp:

(WebCore::Node::~Node):

If accessibility is enabled, inform the axObjectCache() that this node is disappearing.

LayoutTests:

  • platform/mac/accessibility/crash-invalid-text-marker-node-expected.txt: Added.
  • platform/mac/accessibility/crash-invalid-text-marker-node.html: Added.
10:55 AM Changeset in webkit [68540] by crogers@google.com
  • 1 edit
    3 adds in trunk/WebCore

2010-09-28 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

Add AudioDestinationNode files
https://bugs.webkit.org/show_bug.cgi?id=45009

No new tests since audio API is not yet implemented.

  • webaudio/AudioDestinationNode.cpp: Added. (WebCore::AudioDestinationNode::AudioDestinationNode): (WebCore::AudioDestinationNode::~AudioDestinationNode): (WebCore::AudioDestinationNode::initialize): (WebCore::AudioDestinationNode::uninitialize): (WebCore::AudioDestinationNode::provideInput):
  • webaudio/AudioDestinationNode.h: Added. (WebCore::AudioDestinationNode::create): (WebCore::AudioDestinationNode::process): (WebCore::AudioDestinationNode::reset): (WebCore::AudioDestinationNode::currentTime): (WebCore::AudioDestinationNode::sampleRate): (WebCore::AudioDestinationNode::numberOfChannels):
  • webaudio/AudioDestinationNode.idl: Added.
10:43 AM Changeset in webkit [68539] by crogers@google.com
  • 1 edit
    3 adds in trunk/WebCore

2010-09-28 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

audio engine: audio output classes
https://bugs.webkit.org/show_bug.cgi?id=34716

No new tests since audio API is not yet implemented.

  • platform/audio/AudioDestination.h: Added. (WebCore::AudioDestination::~AudioDestination):
  • platform/audio/mac/AudioDestinationMac.cpp: Added. (WebCore::AudioDestination::create): (WebCore::AudioDestination::hardwareSampleRate): (WebCore::AudioDestinationMac::AudioDestinationMac): (WebCore::AudioDestinationMac::~AudioDestinationMac): (WebCore::AudioDestinationMac::configure): (WebCore::AudioDestinationMac::start): (WebCore::AudioDestinationMac::stop): (WebCore::AudioDestinationMac::render): (WebCore::AudioDestinationMac::inputProc):
  • platform/audio/mac/AudioDestinationMac.h: Added. (WebCore::AudioDestinationMac::isPlaying): (WebCore::AudioDestinationMac::sampleRate):
10:43 AM Changeset in webkit [68538] by Adam Roben
  • 19 edits
    5 copies in trunk

Tell the UI client when a key event is not handled

When the web process receives an event, it sends a
WebPageProxyMessage::DidReceiveEvent message back to the UI process.
That message is now sent after handling the event, and includes a
boolean signifying whether or not the event was actually handled.

Every time WebPageProxy receives a key event, it adds it to a queue.
When it receives a WebPageProxyMessage::DidReceiveEvent for a key
event, the event is removed from the queue. If the event was not
handled, we tell the UI client.

Fixes <http://webkit.org/b/46660> <rdar://problem/8483465> Need API to
tell a WebKit2 client application that a key event was not handled

Reviewed by Kenneth Rohde Christiansen and Sam Weinig.

WebKit2:

  • Shared/NativeWebKeyboardEvent.h: Added. This class wraps a

WebKeyboardEvent and the native event that was used to construct it.
(WebKit::NativeWebKeyboardEvent::nativeEvent): Simple getter.

  • Shared/WebEvent.h: Made isKeyboardEventType public for

WebPageProxy's benefit.

  • Shared/mac/NativeWebKeyboardEventMac.mm: Added.

(WebKit::NativeWebKeyboardEvent::NativeWebKeyboardEvent):

  • Shared/qt/NativeWebKeyboardEventQt.cpp: Added.

(WebKit::NativeWebKeyboardEvent::NativeWebKeyboardEvent):

  • Shared/win/NativeWebKeyboardEventWin.cpp: Added.

(WebKit::NativeWebKeyboardEvent::NativeWebKeyboardEvent):
The constructor creates a WebKeyboardEvent and stores the native
event.

  • UIProcess/API/C/WKNativeEvent.h: Added.
  • UIProcess/API/C/WKPage.h: Added WKPageDidNotHandleKeyEventCallback

and WKPageUIClient::didNotHandleKeyEvent.

  • UIProcess/API/mac/WKView.mm:

(-[WKView keyUp:]):
(-[WKView keyDown:]):

  • UIProcess/win/WebView.cpp:

(WebKit::WebView::onKeyEvent):

  • UIProcess/API/qt/qwkpage.cpp:

(QWKPagePrivate::keyPressEvent):
(QWKPagePrivate::keyReleaseEvent):
Changed to use NativeWebKeyboardEvent.

(QWKPage::QWKPage): Updated for addition of didNotHandleKeyEvent.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::handleKeyboardEvent): Changed to take a
NativeWebKeyboardEvent and to add it to m_keyEventQueue.
(WebKit::WebPageProxy::didReceiveMessage): Changed to expect a boolean
parameter in WebPageProxyMessage::DidReceiveEvent.
(WebKit::WebPageProxy::didReceiveEvent): Added a boolean "handled"
parameter. If the event was a keyboard event, we remove it from
m_keyEventQueue, and if it wasn't handled by WebCore, we tell the UI
client.

  • UIProcess/WebPageProxy.h: Added m_keyEventQueue.
  • UIProcess/WebUIClient.cpp:

(WebKit::WebUIClient::didNotHandleKeyEvent):

  • UIProcess/WebUIClient.h:

Added. Just calls through to the WKPageUIClient.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::handleMouseEvent):
(WebKit::WebPage::mouseEvent):
(WebKit::handleWheelEvent):
(WebKit::WebPage::wheelEvent):
(WebKit::handleKeyEvent):
(WebKit::WebPage::keyEvent):
(WebKit::handleTouchEvent):
(WebKit::WebPage::touchEvent):
Moved code from the *Event functions into new helper handle*Event
functions, and changed to pass a boolean to
WebPageProxyMessage::DidReceiveEvent signaling whether the event was
handled or not.

  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:
  • win/WebKit2Generated.make:

Added WKNativeEvent.h and NativeWebKeyboardEvent.

WebKitTools:

Update for the addition of WKPageUIClient::didNotHandleKeyEvent

  • MiniBrowser/mac/BrowserWindowController.m:

(-[BrowserWindowController awakeFromNib]):

  • MiniBrowser/win/BrowserView.cpp:

(BrowserView::create):

  • WebKitTestRunner/TestController.cpp:

(WTR::createOtherPage):
(WTR::TestController::initialize):

Conflicts:

WebKit2/WebKit2.xcodeproj/project.pbxproj

10:41 AM Changeset in webkit [68537] by crogers@google.com
  • 1 edit
    2 adds in trunk/WebCore

2010-09-28 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

Add AudioGain files
https://bugs.webkit.org/show_bug.cgi?id=46285

No new tests since audio API is not yet implemented.

  • webaudio/AudioGain.h: Added. (WebCore::AudioGain::create): (WebCore::AudioGain::AudioGain):
  • webaudio/AudioGain.idl: Added.
10:33 AM Changeset in webkit [68536] by rniwa@webkit.org
  • 4 edits
    3 adds
    30 deletes in trunk/LayoutTests

2010-09-28 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Kent Tamura.

dump-as-markup conversion: editing/pasteboard/paste-4039777-fix.html, paste-list-001.html, and paste-table-001.html
https://bugs.webkit.org/show_bug.cgi?id=46545

Converted the following tests to dump-as-markup tests:
editing/pasteboard/paste-4039777-fix.html
editing/pasteboard/paste-list-001.html
editing/pasteboard/paste-table-001.html

  • editing/pasteboard/paste-4039777-fix-expected.txt: Added.
  • editing/pasteboard/paste-4039777-fix.html:
  • editing/pasteboard/paste-list-001-expected.txt: Added.
  • editing/pasteboard/paste-list-001.html:
  • editing/pasteboard/paste-table-001-expected.txt: Added.
  • editing/pasteboard/paste-table-001.html:
  • platform/chromium-linux/editing/pasteboard/paste-4039777-fix-expected.checksum: Removed.
  • platform/chromium-linux/editing/pasteboard/paste-4039777-fix-expected.png: Removed.
  • platform/chromium-linux/editing/pasteboard/paste-list-001-expected.checksum: Removed.
  • platform/chromium-linux/editing/pasteboard/paste-list-001-expected.png: Removed.
  • platform/chromium-linux/editing/pasteboard/paste-table-001-expected.checksum: Removed.
  • platform/chromium-linux/editing/pasteboard/paste-table-001-expected.png: Removed.
  • platform/chromium-mac/editing/pasteboard/paste-4039777-fix-expected.checksum: Removed.
  • platform/chromium-mac/editing/pasteboard/paste-table-001-expected.checksum: Removed.
  • platform/chromium-win/editing/pasteboard/paste-4039777-fix-expected.checksum: Removed.
  • platform/chromium-win/editing/pasteboard/paste-4039777-fix-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/paste-4039777-fix-expected.txt: Removed.
  • platform/chromium-win/editing/pasteboard/paste-list-001-expected.checksum: Removed.
  • platform/chromium-win/editing/pasteboard/paste-list-001-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/paste-list-001-expected.txt: Removed.
  • platform/chromium-win/editing/pasteboard/paste-table-001-expected.checksum: Removed.
  • platform/chromium-win/editing/pasteboard/paste-table-001-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/paste-table-001-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/paste-table-001-expected.txt: Removed.
  • platform/mac/editing/pasteboard/paste-4039777-fix-expected.checksum: Removed.
  • platform/mac/editing/pasteboard/paste-4039777-fix-expected.png: Removed.
  • platform/mac/editing/pasteboard/paste-4039777-fix-expected.txt: Removed.
  • platform/mac/editing/pasteboard/paste-list-001-expected.checksum: Removed.
  • platform/mac/editing/pasteboard/paste-list-001-expected.png: Removed.
  • platform/mac/editing/pasteboard/paste-list-001-expected.txt: Removed.
  • platform/mac/editing/pasteboard/paste-table-001-expected.checksum: Removed.
  • platform/mac/editing/pasteboard/paste-table-001-expected.png: Removed.
  • platform/mac/editing/pasteboard/paste-table-001-expected.txt: Removed.
  • platform/qt/editing/pasteboard/paste-4039777-fix-expected.txt: Removed.
  • platform/qt/editing/pasteboard/paste-list-001-expected.txt: Removed.
  • platform/qt/editing/pasteboard/paste-table-001-expected.txt: Removed.
10:31 AM Changeset in webkit [68535] by crogers@google.com
  • 2 edits in trunk/WebCore

2010-09-28 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

Fix possible illegal float values in AudioParam
https://bugs.webkit.org/show_bug.cgi?id=46681

No new tests since audio API is not yet implemented.

  • webaudio/AudioParam.h: (WebCore::AudioParam::setValue):
10:30 AM Changeset in webkit [68534] by andersca@apple.com
  • 7 edits in trunk/WebKit2

Improve plug-in process lifecycle handling
https://bugs.webkit.org/show_bug.cgi?id=46734

Reviewed by Adam Roben.

  • PluginProcess/WebProcessConnection.cpp:

(WebKit::WebProcessConnection::destroyPlugin):
Destroy and delete the plug-in.

(WebKit::WebProcessConnection::didClose):
Our web process crashed, go through and delete all plug-in instances.

  • UIProcess/Plugins/PluginProcessProxy.cpp:

(WebKit::PluginProcessProxy::didClose):
The plug-in process crashed. Go through all pending replies and send them so the
web processes won't be blocked waiting for a reply.

(WebKit::PluginProcessProxy::didCreateWebProcessConnection):
We need to remove the pending reply connection once we've sent the reply.

  • WebProcess/Plugins/PluginProcessConnection.cpp:

(WebKit::PluginProcessConnection::didClose):
The plug-in process crashed. Iterate over all proxies and let them know that the plug-in
process has crashed.

  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::pluginProcessCrashed):
Tell our controller that the plug-in process crashed.

(WebKit::PluginProxy::destroy):
Null out the controller.

10:21 AM WebKitGtkLayoutTests edited by mrobinson@webkit.org
Updated to reflect new font requirements and calling convention (diff)
10:14 AM Changeset in webkit [68533] by vestbo@webkit.org
  • 1 edit in trunk/WebCore/platform/graphics/qt/MediaPlayerPrivatePhonon.cpp

Fix the Qt build

10:03 AM Changeset in webkit [68532] by vestbo@webkit.org
  • 3 edits in trunk/WebCore

[Qt] Rename member variable in MediaPlayerPrivateQt

Reviewed by Simon Hausmann.

  • platform/graphics/qt/MediaPlayerPrivateQt.cpp:
  • platform/graphics/qt/MediaPlayerPrivateQt.h:
9:54 AM Changeset in webkit [68531] by andersca@apple.com
  • 5 edits in trunk/WebKit2

Implement PluginControllerProxy::initialize and have it create a plug-in
https://bugs.webkit.org/show_bug.cgi?id=46731

Reviewed by Adam Roben.

  • PluginProcess/PluginControllerProxy.cpp:

(WebKit::PluginControllerProxy::initialize):
Create the plug-in and try to initialize it.

(WebKit::PluginControllerProxy::destroy):
Destroy the plug-in.

  • PluginProcess/WebProcessConnection.cpp:

(WebKit::WebProcessConnection::addPluginControllerProxy):
Add the given plug-in controller proxy to the map and assume ownership of it.

(WebKit::WebProcessConnection::removePluginControllerProxy):
Remove the given plug-in controller proxy from the map and delete it.

(WebKit::WebProcessConnection::createPlugin):
Create a plug-in controller proxy and try to initialize it.

9:49 AM Changeset in webkit [68530] by Simon Fraser
  • 3 edits in trunk/WebKitTools

2010-09-28 Simon Fraser <Simon Fraser>

Unreviewed.

Update the CSSTestSuiteHarness to not scrape the XHTML chapter files
for the test order, but instead use information from testinfo.data.

  • CSSTestSuiteHarness/harness/harness.html:
  • CSSTestSuiteHarness/harness/harness.js:
9:46 AM Changeset in webkit [68529] by abecsi@webkit.org
  • 2 edits in trunk/WebCore

2010-09-28 Andras Becsi <abecsi@webkit.org>

[Gtk] Build fix. Remove leftover trailing backslash.

  • GNUmakefile.am:
9:41 AM Changeset in webkit [68528] by abecsi@webkit.org
  • 2 edits in trunk/WebCore

2010-09-28 Andras Becsi <abecsi@webkit.org>

Unreviewed.

[Gtk] Build fix after r68521

No new tests needed.

  • GNUmakefile.am:
9:39 AM Changeset in webkit [68527] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

2010-09-28 Stephen White <senorblanco@chromium.org>

Unreviewed; expectations fix.

[CHROMIUM] Fix duplicate expectations (again).

  • platform/chromium/test_expectations.txt:
9:21 AM Changeset in webkit [68526] by vestbo@webkit.org
  • 6 edits in trunk/WebCore

[Qt] Rename MediaPlayerPrivate to MediaPlayerPrivateQt/Phonon

Reviewed by Andreas Kling.

https://bugs.webkit.org/show_bug.cgi?id=36663

  • platform/graphics/MediaPlayer.cpp:
  • platform/graphics/qt/MediaPlayerPrivateQt.cpp:
  • platform/graphics/qt/MediaPlayerPrivateQt.h:
  • platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:
  • platform/graphics/qt/MediaPlayerPrivatePhonon.h:
9:20 AM Changeset in webkit [68525] by andreas.kling@nokia.com
  • 3 edits in trunk/WebKit/qt

2010-09-28 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Clean up QWebPage::ViewportConfiguration API
https://bugs.webkit.org/show_bug.cgi?id=46730

  • Pass QSize parameter as const-reference
  • Style fixes
  • Api/qwebpage.cpp: (QWebPage::viewportConfigurationForSize):
  • Api/qwebpage.h:
9:17 AM Changeset in webkit [68524] by kevino@webkit.org
  • 5 edits in trunk

[wx] Build fixes for recent changes.

9:14 AM Changeset in webkit [68523] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

2010-09-28 Stephen White <senorblanco@chromium.org>

Unreviewed; expectations fix.

[CHROMIUM] Fix duplicate expectations.

  • platform/chromium/test_expectations.txt:
9:07 AM Changeset in webkit [68522] by andersca@apple.com
  • 4 edits
    1 copy
    1 add in trunk/WebKit2

Add PluginControllerProxy class
https://bugs.webkit.org/show_bug.cgi?id=46728

Reviewed by Adam Roben.

  • PluginProcess/PluginControllerProxy.cpp: Added.
  • PluginProcess/PluginControllerProxy.h: Added.

Add stubbed out PluginControllerProxy class.

  • PluginProcess/WebProcessConnection.cpp:

(WebKit::WebProcessConnection::~WebProcessConnection):
Assert that we don't have any live plug-in controller proxies.

(WebKit::WebProcessConnection::addPluginControllerProxy):
Add the plug-in controller proxy to the map.

(WebKit::WebProcessConnection::removePluginControllerProxy):
Remove the plug-in controller proxy from the map. If the last plug-in controller
proxy went away, invalidate the connection.

  • WebKit2.xcodeproj/project.pbxproj:

Add files.

9:01 AM Changeset in webkit [68521] by abecsi@webkit.org
  • 18 edits in trunk

2010-09-28 Andras Becsi <abecsi@webkit.org>

Reviewed by Csaba Osztrogonác.

Undefined reference errors when linking due to gperf and inlining.
webkit.org/b/29244

EFL CMake changes by Leandro Pereira <leandro@profusion.mobi>

Refactor gperf code generation and usage to fix the debug build with gcc>4.4.
Hitherto gperf generated C code, these files were included in multiple C++ files across WebCore
to access the functionality provided. This resulted in debug build failure with newer gcc versions
because of a behaviour change of gcc, which disables C style inlining in debug mode.
The make-hash-tools.pl script lets gperf generate C++ code for all gperf files now, which are compiled
in their own compilation unit.
The functionality provided by the generated code is wrapped behind HashTools.h, so there is no need
for multiple inclusions of generated C files to access these functions.

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::createPlugin):

2010-09-28 Andras Becsi <abecsi@webkit.org>

Reviewed by Csaba Osztrogonác.

Undefined reference errors when linking due to gperf and inlining.
webkit.org/b/29244

EFL CMake changes by Leandro Pereira <leandro@profusion.mobi>

Refactor gperf code generation and usage to fix the debug build with gcc>4.4.
Hitherto gperf generated C code, these files were included in multiple C++ files across WebCore
to access the functionality provided. This resulted in debug build failure with newer gcc versions
because of a behaviour change of gcc, which disables C style inlining in debug mode.
The make-hash-tools.pl script lets gperf generate C++ code for all gperf files now, which are compiled
in their own compilation unit.
The functionality provided by the generated code is wrapped behind HashTools.h, so there is no need
for multiple inclusions of generated C files to access these functions.

No new tests needed.

  • CMakeLists.txt:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.pri:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSParser.cpp:
  • css/makeprop.pl:
  • css/makevalues.pl:
  • html/DocTypeStrings.gperf:
  • html/HTMLDocument.cpp:
  • make-hash-tools.pl:
  • platform/ColorData.gperf:
  • platform/graphics/Color.cpp:

2010-09-28 Andras Becsi <abecsi@webkit.org>

Reviewed by Csaba Osztrogonác.

Undefined reference errors when linking due to gperf and inlining.
webkit.org/b/29244

EFL CMake changes by Leandro Pereira <leandro@profusion.mobi>

Refactor gperf code generation and usage to fix the debug build with gcc>4.4.
Hitherto gperf generated C code, these files were included in multiple C++ files across WebCore
to access the functionality provided. This resulted in debug build failure with newer gcc versions
because of a behaviour change of gcc, which disables C style inlining in debug mode.
The make-hash-tools.pl script lets gperf generate C++ code for all gperf files now, which are compiled
in their own compilation unit.
The functionality provided by the generated code is wrapped behind HashTools.h, so there is no need
for multiple inclusions of generated C files to access these functions.

  • cmake/WebKitMacros.cmake:
8:44 AM Changeset in webkit [68520] by Adam Roben
  • 8 edits
    4 adds in trunk

Don't call NPP_SetWindow until the plugin's HWND has been sized/positioned

Test: platform/win/plugins/window-geometry-initialized-before-set-window.html

Reviewed by Anders Carlsson.

Fixes <http://webkit.org/b/46716> <rdar://problem/8482014> Full-page
Adobe Reader does not paint until window is resized

WebKit2:

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::geometryDidChange): Call NPP_SetWindow after
updating the platform (HWND) geometry.

WebKitTools:

Test that a plugin's HWND is sized/positioned before NPP_SetWindow is called

Reviewed by Anders Carlsson.

  • DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:

(PluginTest::NPP_SetWindow): Added. Just returns NPERR_NO_ERROR at
this level.

  • DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Declared

NPP_SetWindow.

  • DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowGeometryInitializedBeforeSetWindow.cpp: Added.

(WindowGeometryInitializedBeforeSetWindow::NPP_SetWindow): Checks that
the plugin's HWND has a non-zero size and that its size/position
matches that specified in the NPWindow.

  • DumpRenderTree/TestNetscapePlugIn/main.cpp:

(NPP_SetWindow): Call through to the PluginTest.

  • DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:

Added WindowGeometryInitializedBeforeSetWindow.cpp, and let VS reorder
the files as it saw fit.

LayoutTests:

Test that a plugin's HWND is sized/positioned before NPP_SetWindow is called

  • platform/win/plugins/window-geometry-initialized-before-set-window-expected.txt: Added.
  • platform/win/plugins/window-geometry-initialized-before-set-window.html: Added.
8:43 AM Changeset in webkit [68519] by Adam Roben
  • 2 edits in trunk/LayoutTests

Start running plugins tests in WebKit2 on Windows

Fixes <http://webkit.org/b/46675> <rdar://problem/8484269>

Reviewed by John Sullivan.

  • platform/win-wk2/Skipped: Removed the plugins and

platform/win/plugins directories and added individual failing tests.
plugins/geturlnotify-during-document-teardown.html and
plugins/mouse-events-fixedpos.html will also fail on SnowLeopard, but
they're already skipped there on both WebKit1 and WebKit2 thanks to
platform/mac-snowleopard/Skipped.

8:29 AM Changeset in webkit [68518] by andersca@apple.com
  • 2 edits in trunk/WebKit2

Out of process plug-ins shouldn't be turned on just yet...

  • WebKit2Prefix.h:
8:09 AM Changeset in webkit [68517] by andreas.kling@nokia.com
  • 13 edits in trunk/WebKit/qt

2010-09-28 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Andreas Kling.

[Qt] Remove support for Qt 4.5
https://bugs.webkit.org/show_bug.cgi?id=46718

Remove the code for versions of Qt prior to 4.6.

  • Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::updateResizesToContentsForPage): (QGraphicsWebView::QGraphicsWebView): (QGraphicsWebView::sceneEvent): (QGraphicsWebViewPrivate::detachCurrentPage):
  • Api/qwebframe.cpp: (QWebFrame::load):
  • Api/qwebpage.cpp: (QWebPagePrivate::QWebPagePrivate): (QWebPagePrivate::handleSoftwareInputPanel): (QWebPagePrivate::inputMethodEvent): (QWebPagePrivate::touchEvent): (QWebPage::inputMethodQuery): (QWebPage::view): (QWebPage::event):
  • Api/qwebpage_p.h:
  • Api/qwebview.cpp: (QWebView::QWebView): (QWebViewPrivate::detachCurrentPage): (QWebView::event):
  • WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::setInputMethodState):
  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::createPlugin):
  • WebCoreSupport/PageClientQt.cpp: (WebCore::PageClientQWidget::setInputMethodHints): (WebCore::PageClientQGraphicsWidget::setInputMethodEnabled): (WebCore::PageClientQGraphicsWidget::inputMethodEnabled): (WebCore::PageClientQGraphicsWidget::setInputMethodHints):
  • WebCoreSupport/PageClientQt.h: (WebCore::QGraphicsItemOverlay::page):
  • tests/qwebframe/tst_qwebframe.cpp:
  • tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::inputMethods_data): (inputMethodHints): (inputMethodEnabled): (tst_QWebPage::inputMethods): (tst_QWebPage::originatingObjectInNetworkRequests):
  • tests/qwebview/tst_qwebview.cpp: (tst_QWebView::reusePage):
7:57 AM Changeset in webkit [68516] by Philippe Normand
  • 5 edits in trunk/JavaScriptCore

2010-09-28 Philippe Normand <pnormand@igalia.com>

Reviewed by Martin Robinson.

Guard GRefPtr/GOwnPtr files with ENABLE(GLIB_SUPPORT)
https://bugs.webkit.org/show_bug.cgi?id=46721

Enable GOwnPtr/GRefPtr build only if glib support has been
explicitly enabled using the WTF_ENABLE_GLIB_SUPPORT macro.

  • wtf/gobject/GOwnPtr.cpp:
  • wtf/gobject/GOwnPtr.h:
  • wtf/gobject/GRefPtr.cpp:
  • wtf/gobject/GRefPtr.h:
7:51 AM Changeset in webkit [68515] by abecsi@webkit.org
  • 2 edits in trunk/WebKit2

2010-09-28 Andras Becsi <abecsi@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] ProcessLauncherHelper should not leave stray socket files in /tmp.
https://bugs.webkit.org/show_bug.cgi?id=46722

  • UIProcess/Launcher/qt/ProcessLauncherQt.cpp: (WebKit::ProcessLauncherHelper::~ProcessLauncherHelper): close the socket. (WebKit::ProcessLauncherHelper::ProcessLauncherHelper): delete the helper on exit.
7:40 AM Changeset in webkit [68514] by benjamin.poulain@nokia.com
  • 9 edits in trunk/WebKitTools

2010-09-28 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Andreas Kling.

[Qt] Remove support for Qt 4.5
https://bugs.webkit.org/show_bug.cgi?id=46718

Remove the code for versions of Qt prior to 4.6.

  • DumpRenderTree/qt/EventSenderQt.cpp: (EventSender::addTouchPoint): (EventSender::updateTouchPoint): (EventSender::setTouchModifier): (EventSender::touchStart): (EventSender::touchMove): (EventSender::touchEnd): (EventSender::clearTouchPoints): (EventSender::releaseTouchPoint): (EventSender::sendTouchEvent):
  • DumpRenderTree/qt/EventSenderQt.h:
  • DumpRenderTree/qt/TextInputControllerQt.cpp: (TextInputController::setMarkedText):
  • QtTestBrowser/launcherwindow.cpp: (LauncherWindow::LauncherWindow): (LauncherWindow::initializeView): (LauncherWindow::createChrome): (LauncherWindow::sendTouchEvent): (LauncherWindow::eventFilter): (LauncherWindow::applyZoom): (LauncherWindow::setTouchMocking):
  • QtTestBrowser/launcherwindow.h:
  • QtTestBrowser/utils.cpp: (urlFromUserInput):
  • QtTestBrowser/webview.cpp: (WebViewGraphicsBased::animatedFlip): (WebViewGraphicsBased::animatedYFlip):
  • QtTestBrowser/webview.h: (WebViewGraphicsBased::setYRotation):
7:24 AM Changeset in webkit [68513] by andreas.kling@nokia.com
  • 3 edits
    3 adds in trunk

2010-09-28 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Canvas: Crash when setting a font with size in 'ex' units
https://bugs.webkit.org/show_bug.cgi?id=46538

update() the style's font after setting the style's font description.
Needed because CSSPrimitiveValue::computeLengthDouble() later assumes
that the style's font is properly initialized (for xHeight().)

Fixes crash on IE test center's canvas-text-font-002 test.

  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::setFont):

2010-09-28 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Canvas: Crash when setting a font with size in 'ex' units
https://bugs.webkit.org/show_bug.cgi?id=46538

  • fast/canvas/canvas-font-ex-units-crash-expected.txt: Added.
  • fast/canvas/canvas-font-ex-units-crash.html: Added.
  • fast/canvas/script-tests/canvas-font-ex-units-crash.js: Added.
7:23 AM Changeset in webkit [68512] by benjamin.poulain@nokia.com
  • 4 edits in trunk/WebKit2

2010-09-28 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Andreas Kling.

[Qt] Remove support for Qt 4.5
https://bugs.webkit.org/show_bug.cgi?id=46718

Remove the code for versions of Qt prior to 4.6.

  • UIProcess/API/qt/qgraphicswkview.cpp: (QGraphicsWKView::event):
  • UIProcess/API/qt/qwkpage.cpp:
  • UIProcess/API/qt/qwkpage_p.h:
7:14 AM Changeset in webkit [68511] by andreas.kling@nokia.com
  • 6 edits in trunk

2010-09-28 İsmail Dönmez <ismail@namtrac.org>

Reviewed by Andreas Kling.

Test for WINCE instead of WINCEBASIC, compiler always defines WINCE.
Remove reference to unexisting path JavaScriptCore/os-wince.

2010-09-28 İsmail Dönmez <ismail@namtrac.org>

Reviewed by Andreas Kling.

Fix DRT compilation on WinCE. Introduce a WCECOMPAT variable
which should point to wcecompat installation. Needs wcecompat
library from http://github.com/mauricek/wcecompat .

  • DumpRenderTree/qt/DumpRenderTree.pro:
  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
7:09 AM Changeset in webkit [68510] by benjamin.poulain@nokia.com
  • 6 edits in trunk/WebCore

2010-09-28 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Remove support for Qt 4.5
https://bugs.webkit.org/show_bug.cgi?id=46718

Remove the code for versions of Qt prior to 4.6.

  • WebCore.pro:
  • features.pri:
  • platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::QNetworkReplyHandler): (WebCore::QNetworkReplyHandler::start):
  • platform/network/qt/ResourceRequestQt.cpp: (WebCore::ResourceRequest::toNetworkRequest):
  • platform/qt/QWebPageClient.h:
5:52 AM Changeset in webkit [68509] by satish@chromium.org
  • 2 edits in trunk/LayoutTests

2010-09-28 Satish Sampath <satish@chromium.org>

Unreviewed, enable a couple of speech input layout tests in chromium as they run successfully now.

  • platform/chromium/test_expectations.txt:
5:30 AM Changeset in webkit [68508] by vestbo@webkit.org
  • 3 edits in trunk/WebKit/qt

Clean up QWebPage initialization

Reviewed by Simon Hausmann.

  • Api/qwebpage.cpp:
  • Api/qwebpage_p.h:
5:18 AM Changeset in webkit [68507] by benjamin.poulain@nokia.com
  • 2 edits in trunk/WebKit/qt

2010-09-28 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] tst_QWebPage::testStopScheduledPageRefresh() fails on MeeGo handset
https://bugs.webkit.org/show_bug.cgi?id=46706

The test require the network to succeed or fail in order to work.
On MeeGo, the network can simply timeout the because of the netword access
management. This patch makes the test use local URLs to avoid the
problem.

  • tests/qwebpage/tst_qwebpage.cpp: (TestNetworkManager::TestNetworkManager):
4:40 AM Changeset in webkit [68506] by vestbo@webkit.org
  • 2 edits in trunk/BugsSite

Convert verbatim unicode values in comitter names to characters

Reviewed by Csaba Osztrogonác.

  • committers-autocomplete.js:
4:13 AM Changeset in webkit [68505] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed.

[Qt] 3 media tests fail with Qt version 4.6.3 and 4.7.0
https://bugs.webkit.org/show_bug.cgi?id=46249

  • platform/qt/Skipped: 3 failing media tests added until fix.
3:52 AM Changeset in webkit [68504] by andreip@google.com
  • 2 edits in trunk/WebKit/chromium

2010-09-28 Andrei Popescu <andreip@google.com>

Reviewed by Jeremy Orlow.

[Chromium] Linking error due to wrong guard in WebIDBTransaction.h
https://bugs.webkit.org/show_bug.cgi?id=46710

Remove the wrong guard.

  • public/WebIDBTransaction.h: (WebKit::WebIDBTransaction::getIDBTransactionBackendInterface):
3:52 AM Changeset in webkit [68503] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2010-09-28 MORITA Hajime <morrita@google.com>

Unreviewed, added an expectation.

  • platform/chromium/test_expectations.txt:
3:35 AM Changeset in webkit [68502] by abecsi@webkit.org
  • 2 edits in trunk/WebKit2

2010-09-28 Andras Becsi <abecsi@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt] Fix generation of WebPageMessages.h and WebPageMessageReceiver.cpp
to avoid rebuilding them every time.

  • DerivedSources.pro: add target to extra compilers.
2:39 AM Changeset in webkit [68501] by alex
  • 4 edits in trunk/LayoutTests

2010-09-28 Alejandro G. Castro <alex@igalia.com>

Unreviewed, GTK+ rebaselines.

  • platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/gtk/fast/dom/prototype-inheritance-expected.txt:
  • platform/gtk/fast/js/global-constructors-expected.txt:
2:36 AM Changeset in webkit [68500] by tkent@chromium.org
  • 2 edits in trunk/WebCore

2010-09-28 Kent Tamura <tkent@chromium.org>

Unreviewed, run sort-Xcode-project-file

  • WebCore.xcodeproj/project.pbxproj:
2:26 AM Changeset in webkit [68499] by commit-queue@webkit.org
  • 6 edits
    6 adds in trunk

2010-09-28 Huahui Wu <mediadependent@gmail.com>

Reviewed by Steve Block.

Add two multi-touch tests for Android.
https://bugs.webkit.org/show_bug.cgi?id=45221

The original tests (touch-target.html and basic-multi-touch-events.html)
requires the system being able to release one point while maintain another point.
Current Android system can not provide this to browser, hence these tests are
slightly modified for Android. Since these are limited version of the original ones,
other platforms should pass these tests if they can pass the original ones.

  • fast/events/touch/basic-multi-touch-events-limited-expected.txt: Added.
  • fast/events/touch/basic-multi-touch-events-limited.html: Added.
  • fast/events/touch/script-tests/basic-multi-touch-events-limited.js: Added. (touchEventCallback): (verifyTouchEvent): (verifyTouchPoint): (verifyTouch): (multiTouchSequence):
  • fast/events/touch/script-tests/touch-target-limited.js: Added. (touchStartHandler): (touchMoveHandler):
  • fast/events/touch/touch-target-limited-expected.txt: Added.
  • fast/events/touch/touch-target-limited.html: Added.

2010-09-28 Huahui Wu <mediadependent@gmail.com>

Reviewed by Steve Block.

Add multi-touch for Android.
https://bugs.webkit.org/show_bug.cgi?id=45221

The Android touch event used to take one point as the touch point,
it's now changed to a vector of points to support multi-touch.

Tests: fast/events/touch/basic-multi-touch-events-limited.html

fast/events/touch/touch-target-limited.html

  • platform/PlatformTouchEvent.h:
  • platform/PlatformTouchPoint.h:
  • platform/android/PlatformTouchEventAndroid.cpp: (WebCore::PlatformTouchEvent::PlatformTouchEvent):
  • platform/android/PlatformTouchPointAndroid.cpp: (WebCore::PlatformTouchPoint::PlatformTouchPoint):
2:24 AM Changeset in webkit [68498] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2010-09-28 MORITA Hajime <morrita@google.com>

Unreviewed, added an expectation.

  • platform/chromium/test_expectations.txt:
1:32 AM Changeset in webkit [68497] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2010-09-28 MORITA Hajime <morrita@google.com>

Unreviewed, removed some expectations.

  • platform/chromium/test_expectations.txt:
12:25 AM Changeset in webkit [68496] by dbates@webkit.org
  • 11 edits in trunk/WebKitTools

2010-09-28 Daniel Bates <dbates@rim.com>

Rollout changeset 68493 <http://trac.webkit.org/changeset/68493>
<https://bugs.webkit.org/show_bug.cgi?id=39136>

Rollout changeset 68493 because it broke Sheriffbot's rollout feature.
In particular, this change caused Sheriffbot to raise an exception when
trying to parse the bug id on a bug page. We need to look into this
some more.

  • Scripts/webkitpy/common/net/bugzilla.py:
  • Scripts/webkitpy/common/net/bugzilla_unittest.py:
  • Scripts/webkitpy/tool/bot/sheriff.py:
  • Scripts/webkitpy/tool/commands/download.py:
  • Scripts/webkitpy/tool/commands/queues.py:
  • Scripts/webkitpy/tool/commands/upload.py:
  • Scripts/webkitpy/tool/steps/closebug.py:
  • Scripts/webkitpy/tool/steps/obsoletepatches.py:
  • Scripts/webkitpy/tool/steps/preparechangelog.py:
  • Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
12:21 AM Changeset in webkit [68495] by abarth@webkit.org
  • 5 edits in trunk/WebKitTools

2010-09-28 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Move RegressionWindow further up the dependency chain
https://bugs.webkit.org/show_bug.cgi?id=46698

Baby steps towards pushing this information into bug posts.

  • Scripts/webkitpy/common/net/buildbot.py:
  • Scripts/webkitpy/common/net/buildbot_unittest.py:
  • Scripts/webkitpy/common/net/regressionwindow.py:
  • Scripts/webkitpy/tool/commands/queries.py:
12:09 AM Changeset in webkit [68494] by tkent@chromium.org
  • 4 edits
    2 adds in trunk

Fix assertion failure in a case that the dirty flag of a textarea element is changed
https://bugs.webkit.org/show_bug.cgi?id=45681

Reviewed by Alexey Proskuryakov.

WebCore:

We need to call setNeedsValidityCheck() after updating m_isDirty.

Test: fast/forms/textarea-checkValidity-crash.html

  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::setValue):
(WebCore::HTMLTextAreaElement::setNonDirtyValue):
(WebCore::HTMLTextAreaElement::setValueCommon):

  • html/HTMLTextAreaElement.h:

LayoutTests:

  • fast/forms/textarea-checkValidity-crash-expected.txt: Added.
  • fast/forms/textarea-checkValidity-crash.html: Added.

Sep 27, 2010:

11:39 PM Changeset in webkit [68493] by dbates@webkit.org
  • 11 edits in trunk/WebKitTools

2010-09-27 Daniel Bates <dbates@rim.com>

Reviewed by Adam Barth.

sheriffbot can't roll out security patches
https://bugs.webkit.org/show_bug.cgi?id=39136

Make SheriffBot determine if it's authorized to view a bug
whose change it wants to rollout before it tries to rollout
the change.

Moreover, make both webkit-patch and Sheriffbot provide human-
readable error messages when they are not authorized to view
a bug and when a bug number is invalid.

Currently, Sheriffbot does not parse Bugzilla bugs for
<bug error="...">, which indicates an error when retrieving
a bug. In particular, error="NotPermitted" if a person (or bot)
is not authorized to view a bug. For such error="NotPermitted" bugs,
Sheriffbot raises an exception when parsing the bug report and
this exception does not explicitly indicate Sheriffbot's lack
of authorization. Instead, Sheriffbot should explicitly check
for the presence <bug error="..."> before operating on a bug
and error with a human-readable message if it's not permitted
to view it.

  • Scripts/webkitpy/common/net/bugzilla.py: Added BugzillaError class.
  • Scripts/webkitpy/common/net/bugzilla_unittest.py:
    • Added unit test test_bug_parsing_for_bugzilla_not_permitted_error().
    • Added unit test test_bug_parsing_for_bugzilla_not_found_error().
    • Added unit test test_bug_parsing_for_bugzilla_invalid_bug_id_error().
  • Scripts/webkitpy/tool/bot/sheriff.py: Modified to catch BugzillaError.
  • Scripts/webkitpy/tool/commands/download.py: Ditto.
  • Scripts/webkitpy/tool/commands/queues.py: Ditto.
  • Scripts/webkitpy/tool/commands/upload.py: Ditto.
  • Scripts/webkitpy/tool/steps/closebug.py: Ditto.
  • Scripts/webkitpy/tool/steps/obsoletepatches.py: Ditto.
  • Scripts/webkitpy/tool/steps/preparechangelog.py: Ditto.
  • Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py: Ditto.
11:22 PM Changeset in webkit [68492] by abarth@webkit.org
  • 4 edits
    1 add in trunk/WebKitTools

2010-09-27 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Expose more more failure information from Buildbot to SheriffBot
https://bugs.webkit.org/show_bug.cgi?id=46697

This patch moves the information about what tests failured closer to
SheriffBot. There are still a couple more patches to go before
SheriffBot can post this information to bugs, but this is a step in
that direction. Yay for unit tests, which caught some bugs in earlier
versions of this patch.

  • Scripts/webkitpy/common/net/buildbot.py:
  • Scripts/webkitpy/common/net/buildbot_unittest.py:
  • Scripts/webkitpy/common/net/regressionwindow.py: Added.
  • Scripts/webkitpy/tool/commands/queries.py:
11:04 PM Changeset in webkit [68491] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-09-27 Eric Seidel <eric@webkit.org>

Unreviewed. Fixing 500 error seen in the status server.

It turns out that a = b = []; b.append(1); then a[0] will be 1!
This should have been obvious to me, I guess, but it was not what I was expecting.

  • QueueStatusServer/model/activeworkitems.py:
11:04 PM Changeset in webkit [68490] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed fix after r68460.

  • platform/qt/Skipped: Add http/tests/canvas/webgl/origin-clean-conformance.html, because 3D canvas is disabled by default.
10:42 PM Changeset in webkit [68489] by Csaba Osztrogonác
  • 1 edit
    1 copy in trunk/LayoutTests

Unreviewed fix after r68444. Add Qt specific expected files.

  • platform/qt/fast/repaint/repaint-svg-after-style-change-expected.txt: Copied from LayoutTests/fast/repaint/repaint-svg-after-style-change-expected.txt.
10:36 PM Changeset in webkit [68488] by Csaba Osztrogonác
  • 5 edits in trunk/LayoutTests

Unreviewed fix after r68440. Update Qt specific expected files.

  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-expected.txt:
  • platform/qt/fast/js/global-constructors-expected.txt:
10:29 PM Changeset in webkit [68487] by morrita@google.com
  • 3 edits in trunk/LayoutTests

2010-09-27 MORITA Hajime <morrita@google.com>

Unreviewed, added an expectation.

  • platform/chromium/fast/dom/prototype-inheritance-expected.txt:
  • platform/chromium/test_expectations.txt:
10:18 PM Changeset in webkit [68486] by mihaip@chromium.org
  • 9 edits in branches/chromium/517

Merge 68345 - document.nodesFromRect() needs to be removed from Document.idl
https://bugs.webkit.org/show_bug.cgi?id=46492

Reviewed by Kenneth Christiansen and Andreas Kling.
Patch by Antonio Gomes <agomes@rim.com>

WebCore:

As discussed with Sam Weinig on IRC, it was decided to removed
nodesFromRect() from the Document.idl, and that way, not exposing
it to Web content.

Reason: there is no plan to make it standard at the moment, and at the
very least, the method should had been originally added with the "webkit"
prefix, which was not the case.

  • dom/Document.idl:

LayoutTests:

Skip the tests relying on document.nodesFromRect in all platform for
the moment, and adjusting the expected results tests also accordingly.

  • fast/dom/Window/window-properties-expected.txt:
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/win/Skipped:

TBR=jamesr@chromium.org
BUG=57110
Review URL: http://codereview.chromium.org/3509008

10:01 PM Changeset in webkit [68485] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

2010-09-27 Abhishek Arya <inferno@chromium.org>

Reviewed by Dan Bernstein.

When the block RunIn is destroyed, its line box tree is not deleted. As a result, it
gets later used during dirtying of inline text boxes step where this deleted parent is
accessed. The fix is to delete the line box tree before destroying the runin block.

https://bugs.webkit.org/show_bug.cgi?id=46376

Test: fast/text/dirty-inline-textbox-crash.html

  • rendering/RenderText.cpp: (WebCore::RenderText::dirtyLineBoxes):

2010-09-27 Abhishek Arya <inferno@chromium.org>

Reviewed by Dan Bernstein.

Tests we do not crash on ASSERT(!m_hasBadParent) when dirtying
the inline textboxes.
https://bugs.webkit.org/show_bug.cgi?id=46376

  • fast/text/dirty-inline-textbox-crash-expected.txt: Added.
  • fast/text/dirty-inline-textbox-crash.html: Added.
9:45 PM Changeset in webkit [68484] by abarth@webkit.org
  • 3 edits in trunk/WebKitTools

2010-09-27 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

commit-queue should reject patches that fail to land
https://bugs.webkit.org/show_bug.cgi?id=46694

This can happen, for example, if there's no reviewer. Without this
patch, we'll keep retrying the patch.

  • Scripts/webkitpy/tool/bot/commitqueuetask.py:
  • Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
9:28 PM Changeset in webkit [68483] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-09-27 Eric Uhrhane <ericu@chromium.org>

Reviewed by David Levin.

Fix event sequencing in FileWriter
https://bugs.webkit.org/show_bug.cgi?id=46544

Only set readyState to DONE when we're about to send the last progress
event associated with an operation. Make sure all progress events come
from backend calls, and aren't ever fired synchronously in response to
user JS method calls.

No new tests, as none of this is fully implemented yet.

  • fileapi/FileWriter.cpp: (WebCore::FileWriter::write): (WebCore::FileWriter::truncate): (WebCore::FileWriter::abort): (WebCore::FileWriter::didWrite): (WebCore::FileWriter::didTruncate): (WebCore::FileWriter::didFail):
8:49 PM Changeset in webkit [68482] by morrita@google.com
  • 1 edit
    1 add in trunk/LayoutTests

2010-09-27 MORITA Hajime <morrita@google.com>

Unreviewed, added an expectation.

  • platform/chromium-mac/fast/forms/input-button-sizes-expected.checksum: Added.
8:27 PM Changeset in webkit [68481] by crogers@google.com
  • 1 edit
    2 adds in trunk/WebCore

2010-09-27 Chris Rogers <crogers@google.com>

Reviewed by James Robinson.

Add HRTFDatabase files
https://bugs.webkit.org/show_bug.cgi?id=46233

No new tests since audio API is not yet implemented.

  • platform/audio/HRTFDatabase.cpp: Added. (WebCore::HRTFDatabase::create): (WebCore::HRTFDatabase::HRTFDatabase): (WebCore::HRTFDatabase::getKernelsFromAzimuthElevation): (WebCore::HRTFDatabase::indexFromElevationAngle):
  • platform/audio/HRTFDatabase.h: Added. (WebCore::HRTFDatabase::numberOfAzimuths): (WebCore::HRTFDatabase::sampleRate):
8:22 PM Changeset in webkit [68480] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2010-09-27 MORITA Hajime <morrita@google.com>

Unreviewed, added an expectation.

  • platform/chromium/test_expectations.txt:
8:11 PM WebKit Team edited by webkit@mattlilek.com
(diff)
8:03 PM Changeset in webkit [68479] by Simon Fraser
  • 1 edit
    5 adds in trunk/WebKitTools

2010-09-27 Simon Fraser <Simon Fraser>

Rubber-stamped by Adele Peterson.

Add a harness for running the CSS 2.1 test suite.

This harness assumes that you've got a local a copy of the suite
adjacent to the 'harness' directory.

The harness lets you go through the tests in chapter order,
denoting pass/fail/skipped for each test.

It uses a client-side database to store the results of testing.

  • CSSTestSuiteHarness/harness/harness.css: Added.
  • CSSTestSuiteHarness/harness/harness.html: Added.
  • CSSTestSuiteHarness/harness/harness.js: Added.
7:53 PM Changeset in webkit [68478] by hclam@chromium.org
  • 2 edits in trunk/WebKit/chromium

Build fix. Not reviewed.

Use if instead of switch to avoid compilation error.

  • src/VideoFrameChromiumImpl.cpp:

(WebKit::VideoFrameChromiumImpl::requiredTextureSize):

7:37 PM Changeset in webkit [68477] by hclam@chromium.org
  • 4 edits in trunk

Build fix. Not reviewed.

WebCore:

Move constant definitions to VideoLayerChromium.cpp.
A proper fix should come later.

  • platform/graphics/chromium/VideoLayerChromium.cpp:

WebKit/chromium:

Remove constant definitions from this file.

  • src/VideoFrameChromiumImpl.cpp:
7:37 PM Changeset in webkit [68476] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2010-09-27 MORITA Hajime <morrita@google.com>

Unreviewed, added an expectation.

  • platform/chromium/test_expectations.txt:
7:28 PM Changeset in webkit [68475] by tonikitoo@webkit.org
  • 22 edits in trunk

Make Document::nodesFromRect more flexible
https://bugs.webkit.org/show_bug.cgi?id=46336

Patch by Antonio Gomes <agomes@rim.com> on 2010-09-23
Reviewed by Kenneth Christiansen.

The patch changes the API for the Document::nodesFromRect() method as follows:

from

  • RefPtf<NodeList> nodesFromRect(int x, int y, unsigned horizontalPadding, unsigned verticalPadding, bool ignoreClipping)

to

  • RefPtf<NodeList> nodesFromRect(int x, int y, unsigned topPadding, unsigned rightPadding, unsigned bottomPadding,

unsigned leftPadding, bool ignoreClipping)

Previously the method was receiving as parameter horizontal and vertical padding values.
In practice, the horizontal padding was being used to expand a given center point in both
right and left directions, while vertical padding was expanding it to the top and bottom directions.

Although this design makes it possible to improve the touch experience on mobile devices
(Document::nodesFromRect exposes the rect based hit testing system), empirical experiments
showed that, specially in capacitive touch screens, users tend to tap below elements. So
for even more accurate results (which means here the possibility of pleasant tapping experience),
it makes sense to use a region that is offset more above the touch point, favoring elements
above the touch point.

The patch basically implements that, increasing the API flexible and power by making it possible
to specify different padding values for each direction in a given orientation.

Changes were made accordingly to the HitTestResult, RenderLayer, RenderImage and RenderLineBoxList
classes.

WebCore:

  • WebCore.exp.in:
  • dom/Document.cpp:

(WebCore::Document::nodesFromRect):

  • dom/Document.h:
  • page/EventHandler.cpp:

(WebCore::EventHandler::hitTestResultAtPoint): For simplicity, I did not change the signature

but the way the padding value passed in as parameter is being used to construct a HitTestResult.

  • rendering/HitTestResult.cpp: Changed the rect-based bits from using IntSize (padding) to separated paddings

for each direction.

(WebCore::HitTestResult::HitTestResult): Ditto.
(WebCore::HitTestResult::operator=): Ditto.
(WebCore::HitTestResult::rectFromPoint): Ditton.

  • rendering/HitTestResult.h:

(WebCore::HitTestResult::topPadding): getter for the top padding.
(WebCore::HitTestResult::rightPadding): getter for the right padding.
(WebCore::HitTestResult::bottomPadding): getter for the bottom padding.
(WebCore::HitTestResult::leftPadding): getter for the left padding.
(WebCore::HitTestResult::rectFromPoint): Added a static method that given a center point and padding values for

each direction, returns the rect that is going to be used in WebCore's hit testing processing.

  • rendering/RenderImage.cpp: Changed the rect-based bits from using IntSize (padding) to separated paddings for each direction.

(WebCore::RenderImage::nodeAtPoint): Ditto.

  • rendering/RenderLayer.cpp: Ditto.

(WebCore::RenderLayer::hitTestLayer): Ditto.
(WebCore::RenderLayer::hitTestList): Ditto.

  • rendering/RenderLineBoxList.cpp: Ditto.

(WebCore::RenderLineBoxList::hitTest): Ditto.

LayoutTests:

  • fast/dom/nodesFromRect-basic-expected.txt:
  • fast/dom/nodesFromRect-basic.html:
  • fast/dom/resources/nodesFromRect.js:

(check):

7:21 PM Changeset in webkit [68474] by eric@webkit.org
  • 4 edits in trunk/WebKitTools

2010-09-27 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Patch locks should expire if a patch is marked for retry
https://bugs.webkit.org/show_bug.cgi?id=46682

This was part Adam's original CommitQueueTask design,
but support for it was missing from the server.
I added the support, but triggering lock-release based on this
special "retry" status feels a bit strange so I added a FIXME.

I also changed the text in queuestatus.html to say "Lock Acquired"
since "Last Activity" isn't really true. We only update the lock
date when the patch is started, not on every status update.

I also noticed an exception in next-patch, which I fixed by re-writing
the unzip logic in activeworkitems.py again.

  • QueueStatusServer/handlers/updatestatus.py:
  • QueueStatusServer/model/activeworkitems.py:
  • QueueStatusServer/templates/queuestatus.html:
7:20 PM Changeset in webkit [68473] by morrita@google.com
  • 1 edit
    6 adds in trunk/LayoutTests

2010-09-27 MORITA Hajime <morrita@google.com>

Unreviewed, added missing expectations.

[Chromium] fast/forms/input-button-sizes.html failing since r68459
https://bugs.webkit.org/show_bug.cgi?id=46686

  • platform/chromium-linux/fast/forms/input-button-sizes-expected.checksum: Added.
  • platform/chromium-linux/fast/forms/input-button-sizes-expected.png: Added.
  • platform/chromium-linux/fast/forms/input-button-sizes-expected.txt: Added.
  • platform/chromium-win/fast/forms/input-button-sizes-expected.checksum: Added.
  • platform/chromium-win/fast/forms/input-button-sizes-expected.png: Added.
  • platform/chromium-win/fast/forms/input-button-sizes-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
7:17 PM Changeset in webkit [68472] by hclam@chromium.org
  • 2 edits in trunk/WebKit/chromium

Build fix. Not reviewed.

Fix warnings again.

  • src/VideoFrameChromiumImpl.cpp:

(WebKit::VideoFrameChromiumImpl::requiredTextureSize):

7:15 PM Changeset in webkit [68471] by beidson@apple.com
  • 3 edits in trunk/WebKit2

https://bugs.webkit.org/show_bug.cgi?id=46688 - Add an API to get the WKBackForwardItem at an arbitrary index.

Reviewed by Sam Weinig.

  • UIProcess/API/C/WKBackForwardList.cpp:

(WKBackForwardListGetItemAtIndex):

  • UIProcess/API/C/WKBackForwardList.h:
7:08 PM Changeset in webkit [68470] by crogers@google.com
  • 1 edit
    2 adds in trunk/WebCore

2010-09-27 Chris Rogers <crogers@google.com>

Reviewed by James Robinson.

Add HRTFDatabaseLoader files
https://bugs.webkit.org/show_bug.cgi?id=46234

No new tests since audio API is not yet implemented.

  • platform/audio/HRTFDatabaseLoader.cpp: Added. (WebCore::HRTFDatabaseLoader::createAndLoadAsynchronouslyIfNecessary): (WebCore::HRTFDatabaseLoader::HRTFDatabaseLoader): (WebCore::HRTFDatabaseLoader::~HRTFDatabaseLoader): (WebCore::databaseLoaderEntry): (WebCore::HRTFDatabaseLoader::load): (WebCore::HRTFDatabaseLoader::loadAsynchronously): (WebCore::HRTFDatabaseLoader::isLoaded): (WebCore::HRTFDatabaseLoader::defaultHRTFDatabase):
  • platform/audio/HRTFDatabaseLoader.h: Added. (WebCore::HRTFDatabaseLoader::database): (WebCore::HRTFDatabaseLoader::databaseSampleRate):
6:52 PM Changeset in webkit [68469] by msaboff@apple.com
  • 2 edits in trunk/JavaScriptCore

2010-09-27 Michael Saboff <msaboff@apple.com>

Reviewed by Geoffrey Garen.

Changed the initialization of JSArray objects to have space for
3 elements for the constructor that takes a ArgList argument.
This improves v8-deltablue performance by about 2.8% by reducing
the number of realloc() calls.
https://bugs.webkit.org/show_bug.cgi?id=46664

  • runtime/JSArray.cpp: (JSC::JSArray::JSArray):
6:50 PM Changeset in webkit [68468] by hclam@chromium.org
  • 2 edits in trunk/WebKit/chromium

Build fix. Not reviewed.

Add a default for unhandled cases for switch statement.

  • src/VideoFrameChromiumImpl.cpp:

(WebKit::VideoFrameChromiumImpl::requiredTextureSize):

6:44 PM Changeset in webkit [68467] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2010-09-27 MORITA Hajime <morrita@google.com>

Unreviewed, add an expectation.

  • platform/chromium/test_expectations.txt:
6:40 PM Changeset in webkit [68466] by tony@chromium.org
  • 2 edits in trunk/WebKitTools

2010-09-27 Tony Chang <tony@chromium.org>

Reviewed by David Levin.

[chromium] fix a warning when compiling DRT on 32-bit linux
https://bugs.webkit.org/show_bug.cgi?id=46641

  • DumpRenderTree/chromium/TestEventPrinter.cpp: (DRTPrinter::handleImage):
6:22 PM Changeset in webkit [68465] by rniwa@webkit.org
  • 4 edits
    3 adds in trunk

2010-09-27 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

queryCommandState with justifyCenter, justifyLeft, and justifyRight always return false
https://bugs.webkit.org/show_bug.cgi?id=45910

Implemented queryCommandState for justifyCenter, justifyLeft, and justifyRight commands.
Added getTextAlignment to convert -webkit-center, -webkit-left, and -webkit-right to
center, left, and right respectively because they can be treated equally for editing purposes.

Test: editing/execCommand/query-text-alignment.html

  • editing/ApplyStyleCommand.cpp: (WebCore::getTextAlignment): Added. (WebCore::getPropertiesNotIn): Uses getTextAlignment.
  • editing/EditorCommand.cpp: (WebCore::stateJustifyCenter): Added. (WebCore::stateJustifyLeft): Added. (WebCore::stateJustifyRight): Added. (WebCore::createCommandMap): Refers to stateJustifyCenter, stateJustifyLeft, and stateJustifyRight.

2010-09-27 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

queryCommandState with justifyCenter, justifyLeft, and justifyRight always return false
https://bugs.webkit.org/show_bug.cgi?id=45910

Added tests for queryCommandState with justifyCenter, justifyLeft, and justifyRight commands.

  • editing/execCommand/query-text-alignment-expected.txt: Added.
  • editing/execCommand/query-text-alignment.html: Added.
  • editing/execCommand/script-tests/query-text-alignment.js: Added. (queryTextAlignment): (selectFirstPosition): (selectMiddleOfHelloWorld): (runRangeTests):
6:18 PM Changeset in webkit [68464] by hclam@chromium.org
  • 3 edits in trunk/WebCore

Unreviewed. Build fix.

Reorder member declarations and fix other warnings.

  • platform/graphics/chromium/VideoLayerChromium.cpp:

(WebCore::VideoLayerChromium::VideoLayerChromium):
(WebCore::VideoLayerChromium::~VideoLayerChromium):
(WebCore::VideoLayerChromium::updateContents):
(WebCore::VideoLayerChromium::determineTextureFormat):
(WebCore::VideoLayerChromium::allocateTexturesIfNeeded):

  • platform/graphics/chromium/VideoLayerChromium.h:
6:18 PM Changeset in webkit [68463] by jamesr@google.com
  • 2 edits
    1 copy
    1 add in trunk/LayoutTests

2010-09-27 James Robinson <jamesr@chromium.org>

Update baselines for fast/repaint/repaint-svg-after-style-change.html

  • fast/repaint/repaint-svg-after-style-change-expected.txt:
  • platform/chromium/fast/repaint/repaint-svg-after-style-change-expected.txt: Added.
6:00 PM Changeset in webkit [68462] by kbr@google.com
  • 2 edits in trunk/WebCore

2010-09-27 Kenneth Russell <kbr@google.com>

Unreviewed, Qt build fix. Stub out CanvasRenderingContext::checkOrigin(const HTMLVideoElement*)
on platforms that don't support video after r68460.

  • html/canvas/CanvasRenderingContext.cpp: (WebCore::CanvasRenderingContext::checkOrigin):
5:43 PM Changeset in webkit [68461] by Chris Fleizach
  • 4 edits
    2 adds in trunk

CrashTracer: 1,803 crashes in Safari at com.apple.WebCore: -[AccessibilityObjectWrapper accessibilityIsIgnored] + 56
https://bugs.webkit.org/show_bug.cgi?id=46662

Reviewed by Beth Dakin.

WebCore:

Before calling updateBackingStore(), the wrapper object needs to be retained, lest it be invalidated during
the updateBackingStore call. This consolidates all calls to updateBackingStore().

Test: platform/mac/accessibility/removing-textarea-after-edit-crash.html

  • accessibility/mac/AXObjectCacheMac.mm:

(WebCore::AXObjectCache::postPlatformNotification):

Use an ASSERT here to catch the crash because DRT won't cause AppKit to post notifications.

  • accessibility/mac/AccessibilityObjectWrapper.mm:

(-[AccessibilityObjectWrapper prepareAccessibilityMethod]):
(-[AccessibilityObjectWrapper accessibilityActionNames]):
(-[AccessibilityObjectWrapper accessibilityAttributeNames]):
(-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
(-[AccessibilityObjectWrapper accessibilityFocusedUIElement]):
(-[AccessibilityObjectWrapper accessibilityHitTest:]):
(-[AccessibilityObjectWrapper accessibilityIsAttributeSettable:]):
(-[AccessibilityObjectWrapper accessibilityIsIgnored]):
(-[AccessibilityObjectWrapper accessibilityParameterizedAttributeNames]):
(-[AccessibilityObjectWrapper accessibilityPerformPressAction]):
(-[AccessibilityObjectWrapper accessibilityPerformIncrementAction]):
(-[AccessibilityObjectWrapper accessibilityPerformDecrementAction]):
(-[AccessibilityObjectWrapper accessibilityPerformAction:]):
(-[AccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):
(-[AccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):
(-[AccessibilityObjectWrapper accessibilityIndexOfChild:]):
(-[AccessibilityObjectWrapper accessibilityArrayAttributeCount:]):
(-[AccessibilityObjectWrapper accessibilityArrayAttributeValues:index:maxCount:]):

LayoutTests:

  • platform/mac/accessibility/removing-textarea-after-edit-crash-expected.txt: Added.
  • platform/mac/accessibility/removing-textarea-after-edit-crash.html: Added.
5:41 PM Changeset in webkit [68460] by kbr@google.com
  • 9 edits
    3 adds in trunk

2010-09-27 Adrienne Walker <enne@google.com>

Reviewed by Adam Barth.

WebGL's readPixels doesn't respect origin-clean flag

Push CanvasRenderingContext2D checkOrigin logic into base class so it can be shared between different kinds of canvas contexts.
https://bugs.webkit.org/show_bug.cgi?id=45718

Test: LayoutTests/http/tests/canvas/webgl/origin-clean-conformance.html

  • html/canvas/CanvasRenderingContext.cpp: (WebCore::CanvasRenderingContext::checkOrigin):
  • html/canvas/CanvasRenderingContext.h: (WebCore::CanvasRenderingContext::~CanvasRenderingContext): (WebCore::CanvasRenderingContext::canvas): (WebCore::CanvasRenderingContext::is2d): (WebCore::CanvasRenderingContext::is3d): (WebCore::CanvasRenderingContext::isAccelerated): (WebCore::CanvasRenderingContext::paintRenderingResultsToCanvas): (WebCore::CanvasRenderingContext::paintsIntoCanvasBuffer): (WebCore::CanvasRenderingContext::platformLayer):
  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::setStrokeStyle): (WebCore::CanvasRenderingContext2D::setFillStyle): (WebCore::CanvasRenderingContext2D::drawImage): (WebCore::CanvasRenderingContext2D::drawImageFromRect):
  • html/canvas/CanvasRenderingContext2D.h:
  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::readPixels): (WebCore::WebGLRenderingContext::texImage2D): (WebCore::WebGLRenderingContext::videoFrameToImage): (WebCore::WebGLRenderingContext::texSubImage2D):
  • html/canvas/WebGLRenderingContext.h:
  • html/canvas/WebGLRenderingContext.idl:

2010-09-27 Adrienne Walker <enne@google.com>

Reviewed by Adam Barth.

WebGL's readPixels doesn't respect origin-clean flag

Add new test by converting Khronos conformance test to be able to run within LayoutTests/http.
https://bugs.webkit.org/show_bug.cgi?id=45718

  • http/tests/canvas/webgl/origin-clean-conformance-expected.txt: Added.
  • http/tests/canvas/webgl/origin-clean-conformance.html: Added.
5:40 PM Changeset in webkit [68459] by Darin Adler
  • 3 edits
    1 copy
    7 adds in trunk

2010-09-27 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

REGRESSION (r68054): Buttons no longer render at correct sizes
https://bugs.webkit.org/show_bug.cgi?id=46513

Test: fast/forms/input-button-sizes.html

The setUpButtonCell function was running only once, but needed to run every time
through the button function.

  • platform/mac/ThemeMac.mm: (WebCore::leakButtonCell): Added. Separate one-time initialization code. (WebCore::setUpButtonCell): Removed the first-time initialization part of this function. (WebCore::button): Merged the three functions back into one.

2010-09-27 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

REGRESSION (r68054): Buttons no longer render at correct sizes
https://bugs.webkit.org/show_bug.cgi?id=46513

  • fast/forms/input-button-sizes.html: Copied from LayoutTests/fast/forms/button-sizes.html. Turned into a distinct test of <input type=button>; old test was for <button>.
  • platform/mac/fast/forms/input-button-sizes-expected.checksum: Added.
  • platform/mac/fast/forms/input-button-sizes-expected.png: Added.
  • platform/mac/fast/forms/input-button-sizes-expected.txt: Added.
  • platform/mac/fast/forms/disabled-select-change-index-expected.checksum: Added.
  • platform/mac/fast/forms/disabled-select-change-index-expected.png: Added.
  • platform/mac/fast/forms/file-input-disabled-expected.checksum: Added.
  • platform/mac/fast/forms/file-input-disabled-expected.png: Added.
5:31 PM Changeset in webkit [68458] by zmo@google.com
  • 2 edits in trunk/LayoutTests

2010-09-27 Zhenyao Mo <zmo@google.com>

Unreviewed, fix a typo.

  • platform/chromium/test_expectations.txt:
5:31 PM Changeset in webkit [68457] by kenneth@webkit.org
  • 6 edits in trunk/WebKit/qt

[Qt] Remove setDeviceSize methods
https://bugs.webkit.org/show_bug.cgi?id=46347

Reviewed by Antonio Gomes.

Remove our setDeviceHeight() API and obtain it automatically from the
system. Also for testing purposes, make it possible to override the
values via two newly introduced environment variables.

  • Api/qgraphicswebview.cpp:
  • Api/qgraphicswebview.h:
  • Api/qwebpage.cpp:

(getintenv):
(queryDeviceSizeForScreenContainingWidget):
(QWebPage::viewportConfigurationForSize):

  • WebCoreSupport/PageClientQt.cpp:

(WebCore::PageClientQGraphicsWidget::windowRect):

  • symbian/eabi/QtWebKitu.def:
5:27 PM Changeset in webkit [68456] by andersca@apple.com
  • 2 edits in trunk/WebKit2

Turns out people other than me might want to build this thing.

  • WebKit2.xcodeproj/project.pbxproj:
5:25 PM Changeset in webkit [68455] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Bug 46680 - Inlining string concatenation can regress interpreter performance
<rdar://problem/8362752> REGRESSION: ~6.4% sunspider regression in interpreter
Do not inline calls to string concatenation in the interpret loop.

Reviewed by Darin Adler.

  • interpreter/Interpreter.cpp:

(JSC::concatenateStrings):
(JSC::Interpreter::privateExecute):

5:16 PM Changeset in webkit [68454] by Darin Adler
  • 2 edits in trunk/WebKit2
  • Scripts/webkit2: Added property svn:ignore.
5:14 PM Changeset in webkit [68453] by eric@webkit.org
  • 4 edits in trunk/WebKitTools

2010-09-27 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

queue-status should report when the patch was last locked to a queue
https://bugs.webkit.org/show_bug.cgi?id=46674

This isn't necessarily the best way to expose this information
but having this accessible via the web interface is very
useful until we come up with a nicer way to display this.

I also cleaned up the code in activeworkitems.py a little
to use list comprehensions and to have the code work with
pairs instead of two lists at once. Eventually I think those
item/time pairs need to be their own little helper class.

  • QueueStatusServer/handlers/queuestatus.py:
  • QueueStatusServer/model/activeworkitems.py:
  • QueueStatusServer/templates/queuestatus.html:
5:14 PM Changeset in webkit [68452] by andersca@apple.com
  • 8 edits in trunk/WebKit2
  • Platform/CoreIPC/Connection.h:

(CoreIPC::Connection::sendSync):
Add new sendSync overload that takes a message struct.

Reviewed by Sam Weinig.

  • PluginProcess/WebProcessConnection.cpp:

(WebKit::WebProcessConnection::didReceiveSyncMessage):
Call didReceiveSyncWebProcessConnectionMessage.

  • WebProcess/Plugins/PluginProcessConnection.cpp:

(WebKit::PluginProcessConnection::addPluginProxy):
Add the plug-in proxy to the map.

(WebKit::PluginProcessConnection::removePluginProxy):
Remove the plug-in proxy from the map. If the map is empty, disconnect from the
plug-in process.

  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::generatePluginInstanceID):
Generate a unique plug-in instance ID.

(WebKit::PluginProxy::PluginProxy):
Add the plug-in proxy to the map.

(WebKit::PluginProxy::~PluginProxy):
Remove the plug-in proxy from the map.

(WebKit::PluginProxy::initialize):
Ask the plug-in process to create a plug-in.

5:04 PM Changeset in webkit [68451] by tony@chromium.org
  • 2 edits in trunk/WebKitTools

2010-09-27 Tony Chang <tony@chromium.org>

Reviewed by David Levin.

[chromium] fix detection of missing fonts on DRT
https://bugs.webkit.org/show_bug.cgi?id=46651

  • DumpRenderTree/chromium/TestShellGtk.cpp: (setupFontconfig): Only print an error message if lohit isn't found in both locations.
5:01 PM Changeset in webkit [68450] by tony@chromium.org
  • 3 edits in trunk/WebKitTools

2010-09-27 Tony Chang <tony@chromium.org>

Reviewed by Dimitri Glazkov.

add webkit unit tests to the chromium testers
https://bugs.webkit.org/show_bug.cgi?id=46669

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:
  • Scripts/run-chromium-webkit-unit-tests: Fix a bug where we weren't using the right configuration.
4:55 PM Changeset in webkit [68449] by kseo@webkit.org
  • 2 edits in trunk/WebKitTools

Unreviewed.

Adding myself to the committers list.

  • Scripts/webkitpy/common/config/committers.py:
4:52 PM Changeset in webkit [68448] by zmo@google.com
  • 2 edits in trunk/LayoutTests

2010-09-27 Zhenyao Mo <zmo@google.com>

Unreviewed. Three webgl tests TIMEOUT after hooking up ANGLE with in-process-webgl port.

  • platform/chromium/test_expectations.txt:
4:47 PM Changeset in webkit [68447] by commit-queue@webkit.org
  • 9 edits in trunk

2010-09-27 Victoria Kirst <vrk@google.com>

Reviewed by James Robinson.

Modifies VideoLayerChromium to do YUV to RGB color conversion in the
GPU. Also adds support for RGBA video frame formats, though this code
path is currently never run because the video frames are in YV12
format.
https://bugs.webkit.org/show_bug.cgi?id=45069

  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::initializeSharedObjects): (WebCore::LayerRendererChromium::cleanupSharedObjects):
  • platform/graphics/chromium/LayerRendererChromium.h: (WebCore::LayerRendererChromium::videoLayerSharedValues):
  • platform/graphics/chromium/VideoLayerChromium.cpp: (WebCore::VideoLayerChromium::SharedValues::SharedValues): (WebCore::VideoLayerChromium::SharedValues::~SharedValues): (WebCore::VideoLayerChromium::VideoLayerChromium): (WebCore::VideoLayerChromium::~VideoLayerChromium): (WebCore::VideoLayerChromium::updateContents): (WebCore::VideoLayerChromium::updateYUVContents): (WebCore::VideoLayerChromium::allocateYUVTextures): (WebCore::VideoLayerChromium::updateYUVTextures): (WebCore::VideoLayerChromium::updateRGBAContents): (WebCore::VideoLayerChromium::allocateTexture): (WebCore::VideoLayerChromium::updateTexture): (WebCore::VideoLayerChromium::updateContentsCompleted): (WebCore::VideoLayerChromium::draw): (WebCore::VideoLayerChromium::drawYUV): (WebCore::VideoLayerChromium::drawRGBA):
  • platform/graphics/chromium/VideoLayerChromium.h: (WebCore::VideoLayerChromium::drawsContent): (WebCore::VideoLayerChromium::SharedValues::yuvShaderProgram): (WebCore::VideoLayerChromium::SharedValues::rgbaShaderProgram): (WebCore::VideoLayerChromium::SharedValues::yuvShaderMatrixLocation): (WebCore::VideoLayerChromium::SharedValues::rgbaShaderMatrixLocation): (WebCore::VideoLayerChromium::SharedValues::yuvWidthScaleFactorLocation): (WebCore::VideoLayerChromium::SharedValues::rgbaWidthScaleFactorLocation): (WebCore::VideoLayerChromium::SharedValues::yTextureLocation): (WebCore::VideoLayerChromium::SharedValues::uTextureLocation): (WebCore::VideoLayerChromium::SharedValues::vTextureLocation): (WebCore::VideoLayerChromium::SharedValues::yuvAlphaLocation): (WebCore::VideoLayerChromium::SharedValues::rgbaTextureLocation): (WebCore::VideoLayerChromium::SharedValues::ccMatrixLocation): (WebCore::VideoLayerChromium::SharedValues::initialized):

2010-09-27 Victoria Kirst <vrk@google.com>

Reviewed by James Robinson.

Fixing constants in VideoFrameChromiumImpl so that it overloads the
VideoFrameChromium const declarations. Also adding logic such that a
VideoFrameChromium understands what size its texture should be based
on frame format.
https://bugs.webkit.org/show_bug.cgi?id=45069

  • src/VideoFrameChromiumImpl.cpp:
4:44 PM Changeset in webkit [68446] by pkasting@chromium.org
  • 7 edits
    3 adds in trunk

WebCore: ImageDecoderSkia.cpp needs to check for allocator failure when copying
bitmaps.
https://bugs.webkit.org/show_bug.cgi?id=46437

Reviewed by James Robinson.

  • manual-tests/large-size-image-crash.html: Added.
  • manual-tests/resources/large-size-image-crash.gif: Added.
  • platform/image-decoders/ImageDecoder.cpp:

(WebCore::RGBA32Buffer::copyBitmapData):

  • platform/image-decoders/ImageDecoder.h:
  • platform/image-decoders/gif/GIFImageDecoder.cpp:

(WebCore::GIFImageDecoder::initFrameBuffer):

  • platform/image-decoders/qt/RGBA32BufferQt.cpp:

(WebCore::RGBA32Buffer::copyBitmapData):

  • platform/image-decoders/skia/ImageDecoderSkia.cpp:

(WebCore::RGBA32Buffer::copyBitmapData):

LayoutTests: This resource should have been in r62399; without it the test no-ops.
https://bugs.webkit.org/show_bug.cgi?id=41487

Reviewed by James Robinson.

  • fast/images/resources/large-size-image-crash.jpeg: Added.
4:38 PM Changeset in webkit [68445] by andersca@apple.com
  • 9 edits
    1 add in trunk/WebKit2

Add WebProcessConnection CreatePlugin message
https://bugs.webkit.org/show_bug.cgi?id=46668

Reviewed by Adam Roben.

  • DerivedSources.make:

Add WebProcessConnection.

  • Platform/CoreIPC/HandleMessage.h:

Add handleMessage overload for a sync message with two input parameters
and one output parameter.

(CoreIPC::handleMessage):

  • Platform/CoreIPC/MessageID.h:

Add MessageClassWebProcessConnection.

  • PluginProcess/WebProcessConnection.cpp:

(WebKit::WebProcessConnection::createPlugin):
Add stub.

  • PluginProcess/WebProcessConnection.messages.in: Added.
  • Scripts/webkit2/messages.py:

Include headers directly for types that we believe are nested structs.

  • Scripts/webkit2/messages_unittest.py:

Update expected results.

  • WebKit2.xcodeproj/project.pbxproj:

Add new files.

4:38 PM Changeset in webkit [68444] by jamesr@google.com
  • 8 edits
    4 adds in trunk

2010-09-27 James Robinson <jamesr@chromium.org>

Reviewed by Simon Fraser.

Repaint test for dynamically changing an SVG element's style attribute
https://bugs.webkit.org/show_bug.cgi?id=46499

  • fast/repaint/repaint-svg-after-style-change-expected.checksum: Added.
  • fast/repaint/repaint-svg-after-style-change-expected.png: Added.
  • fast/repaint/repaint-svg-after-style-change-expected.txt: Added.
  • fast/repaint/repaint-svg-after-style-change.html: Added.

2010-09-27 James Robinson <jamesr@chromium.org>

Reviewed by Simon Fraser.

Revert r63307, it broke repainting dynamically changed SVG content
https://bugs.webkit.org/show_bug.cgi?id=46499

This patch reverts r63307 and adds a regression test for what broke.

Test: fast/repaint/repaint-svg-after-style-change.html

  • rendering/RenderForeignObject.cpp: (WebCore::RenderForeignObject::layout):
  • rendering/RenderPath.cpp: (WebCore::RenderPath::layout):
  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::layout):
  • rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::layout):
  • rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::layout):
  • rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::layout):
4:35 PM Changeset in webkit [68443] by mrobinson@webkit.org
  • 2 edits
    1 add in trunk/LayoutTests

2010-09-27 Martin Robinson <mrobinson@igalia.com>

Unskip a test that just needed a platform-specific baseline and add a baseline for it.

  • platform/gtk/Skipped: Unskip test with new baseline.
  • platform/gtk/editing/selection/extend-selection-expected.txt: Added.
4:35 PM Changeset in webkit [68442] by vangelis@chromium.org
  • 10 edits in trunk

2010-09-27 Vangelis Kokkevis <vangelis@chromium.org>

Reviewed by James Robinson.

[chromium] WebViewImpl now holds a ref counted pointer to the LayerRendererChromium
to ensure that the compositor does not get destroyed before the layers used
by it do. This was done to ensure that layers properly clean up their texture
resources on destruction.
https://bugs.webkit.org/show_bug.cgi?id=46139

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
  • src/WebViewImpl.h:

2010-09-27 Vangelis Kokkevis <vangelis@chromium.org>

Reviewed by James Robinson.

[chromium] Making LayerChromium's destructor virtual so that the appropriate
derived class destructors get called when the layer tree is taken down.
ContentLayerChromium and its derived types (ImageLayerChromium for now) will
free up the texture allocated for their contents upon destruction. To avoid
having the LayerRendererChromium destructor getting called before the layers
are destroyed and thus leaving their textures orphaned, the layers now hold
a ref counted pointer to the renderer that uses them.
https://bugs.webkit.org/show_bug.cgi?id=46139

  • platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::~ContentLayerChromium): (WebCore::ContentLayerChromium::setLayerRenderer): (WebCore::ContentLayerChromium::cleanupResources):
  • platform/graphics/chromium/ContentLayerChromium.h:
  • platform/graphics/chromium/LayerChromium.cpp: (WebCore::LayerChromium::setLayerRenderer):
  • platform/graphics/chromium/LayerChromium.h: (WebCore::LayerChromium::layerRenderer):
  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::create): (WebCore::LayerRendererChromium::deleteLayerTexture): (WebCore::LayerRendererChromium::cleanupSharedObjects):
  • platform/graphics/chromium/LayerRendererChromium.h:
4:28 PM Changeset in webkit [68441] by commit-queue@webkit.org
  • 1 edit
    4 adds in trunk/LayoutTests

2010-09-27 Alexey Marinichev <amarinichev@chromium.org>

Reviewed by David Levin.

Test that scrolls a checkerboard pattern. If the hardware compositor
miscalculates texture coordinates, corruption is very likely to occur.

  • compositing/checkerboard.html: Added.
  • compositing/checkerboard-expected.checksum: Added.
  • compositing/checkerboard-expected.png: Added.
  • compositing/checkerboard-expected.txt: Added.
4:12 PM Changeset in webkit [68440] by arv@chromium.org
  • 32 edits
    14 adds in trunk

2010-09-27 Erik Arvidsson <arv@chromium.org>

Reviewed by Darin Adler.

Implement HTML 5's HTMLElement.classList property
https://bugs.webkit.org/show_bug.cgi?id=20709

  • fast/dom/HTMLElement/class-list-expected.txt: Added.
  • fast/dom/HTMLElement/class-list-gc-expected.txt: Added.
  • fast/dom/HTMLElement/class-list-gc.html: Added.
  • fast/dom/HTMLElement/class-list-quirks-expected.txt: Added.
  • fast/dom/HTMLElement/class-list-quirks.html: Added.
  • fast/dom/HTMLElement/class-list.html: Added.
  • fast/dom/HTMLElement/script-tests/class-list-gc.js: Added. (gc):
  • fast/dom/HTMLElement/script-tests/class-list.js: Added. (createElement):
  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/Window/window-property-descriptors-expected.txt:
  • fast/dom/prototype-inheritance-2-expected.txt:
  • fast/dom/prototype-inheritance-expected.txt:
  • fast/js/global-constructors-expected.txt:
  • perf/class-list-remove-expected.txt: Added.
  • perf/class-list-remove.html: Added.

2010-09-27 Erik Arvidsson <arv@chromium.org>

Reviewed by Darin Adler.

Implement HTML 5's HTMLElement.classList property
https://bugs.webkit.org/show_bug.cgi?id=20709

This adds a DOMTokenList class that is used for the classList property. DOMTokenList uses a SpaceSplitString for fast
contains check. In standards mode the existing classNames is used but in quirks mode we use an internal SpaceSplitString
because classList is always case sensitive.

Tests: fast/dom/HTMLElement/class-list-gc.html

fast/dom/HTMLElement/class-list-quirks.html
fast/dom/HTMLElement/class-list.html
perf/class-list-remove.html

  • Android.derived.jscbindings.mk:
  • Android.derived.v8bindings.mk:
  • Android.jscbindings.mk:
  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/gobject/GNUmakefile.am:
  • bindings/js/JSElementCustom.cpp: (WebCore::JSElement::markChildren): Make sure that we keep the wrapper while the element is alive.
  • bindings/scripts/CodeGeneratorJS.pm: DOMTokenList has a string indexed getter.
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/custom/V8DOMTokenListCustom.cpp: Added. (WebCore::toV8):
  • dom/Element.cpp: (WebCore::Element::classList): (WebCore::Element::optionalClassList):
  • dom/Element.h:
  • dom/ElementRareData.h: This now has an OwnPtr to a ClassList if the Element::classList is ever called.
  • dom/SpaceSplitString.h: (WebCore::SpaceSplitString::isNull):
  • dom/StyledElement.cpp: (WebCore::StyledElement::classAttributeChanged): Update the classList if it exists.
  • dom/StyledElement.h:
  • html/DOMTokenList.cpp: Added. (WebCore::validateToken): (WebCore::DOMTokenList::DOMTokenList): (WebCore::DOMTokenList::ref): (WebCore::DOMTokenList::deref): (WebCore::DOMTokenList::length): (WebCore::DOMTokenList::item): (WebCore::DOMTokenList::contains): (WebCore::DOMTokenList::containsInternal): The internal methods do no validation of the token. (WebCore::DOMTokenList::add): (WebCore::DOMTokenList::addInternal): (WebCore::DOMTokenList::remove): (WebCore::DOMTokenList::removeInternal): (WebCore::DOMTokenList::toggle): (WebCore::DOMTokenList::toString): (WebCore::DOMTokenList::reset): (WebCore::DOMTokenList::classNames):
  • html/DOMTokenList.h: Added. (WebCore::DOMTokenList::create): (WebCore::DOMTokenList::element):
  • html/DOMTokenList.idl: Added.
  • html/HTMLElement.idl:
  • page/DOMWindow.cpp:
  • page/DOMWindow.idl:
4:07 PM Changeset in webkit [68439] by kbr@google.com
  • 1 edit
    2 adds in trunk/WebCore

2010-09-27 Kenneth Russell <kbr@google.com>

Reviewed by James Robinson.

Add local triangulation of cubic curve control points
https://bugs.webkit.org/show_bug.cgi?id=45252

(Re-landing; I neglected to actually add the new files in
http://trac.webkit.org/changeset/68045 .)

Adding a localized triangulation algorithm which takes as input
the four control points of a cubic curve segment and provides both
triangles as well as the ability to walk the interior edges. The
latter will be used later to fill the interior of shapes bounded
by these cubic curves, quadratic curves and line segments.

  • platform/graphics/gpu/LoopBlinnLocalTriangulator.cpp: Added. (WebCore::LoopBlinnLocalTriangulator::Triangle::contains): (WebCore::LoopBlinnLocalTriangulator::Triangle::nextVertex): (WebCore::LoopBlinnLocalTriangulator::Triangle::indexForVertex): (WebCore::LoopBlinnLocalTriangulator::Triangle::makeCounterClockwise): (WebCore::LoopBlinnLocalTriangulator::LoopBlinnLocalTriangulator): (WebCore::LoopBlinnLocalTriangulator::reset): (WebCore::LoopBlinnLocalTriangulator::triangulate): (WebCore::LoopBlinnLocalTriangulator::triangulateHelper): (WebCore::LoopBlinnLocalTriangulator::addTriangle): (WebCore::LoopBlinnLocalTriangulator::addInteriorVertex): (WebCore::LoopBlinnLocalTriangulator::isSharedEdge):
  • platform/graphics/gpu/LoopBlinnLocalTriangulator.h: Added. (WebCore::LoopBlinnLocalTriangulator::Vertex::Vertex): (WebCore::LoopBlinnLocalTriangulator::Vertex::xyCoordinates): (WebCore::LoopBlinnLocalTriangulator::Vertex::klmCoordinates): (WebCore::LoopBlinnLocalTriangulator::Vertex::set): (WebCore::LoopBlinnLocalTriangulator::Vertex::end): (WebCore::LoopBlinnLocalTriangulator::Vertex::setEnd): (WebCore::LoopBlinnLocalTriangulator::Vertex::marked): (WebCore::LoopBlinnLocalTriangulator::Vertex::setMarked): (WebCore::LoopBlinnLocalTriangulator::Vertex::interior): (WebCore::LoopBlinnLocalTriangulator::Vertex::setInterior): (WebCore::LoopBlinnLocalTriangulator::Vertex::resetFlags): (WebCore::LoopBlinnLocalTriangulator::Triangle::Triangle): (WebCore::LoopBlinnLocalTriangulator::Triangle::getVertex): (WebCore::LoopBlinnLocalTriangulator::Triangle::setVertices): (WebCore::LoopBlinnLocalTriangulator::getVertex): (WebCore::LoopBlinnLocalTriangulator::numberOfTriangles): (WebCore::LoopBlinnLocalTriangulator::getTriangle): (WebCore::LoopBlinnLocalTriangulator::numberOfInteriorVertices): (WebCore::LoopBlinnLocalTriangulator::getInteriorVertex):
4:00 PM Changeset in webkit [68438] by crogers@google.com
  • 1 edit
    3 adds in trunk/WebCore

2010-09-27 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

Add AudioNode files
https://bugs.webkit.org/show_bug.cgi?id=45571

No new tests since audio API is not yet implemented.

  • webaudio/AudioNode.cpp: Added. (WebCore::AudioNode::AudioNode): (WebCore::AudioNode::~AudioNode): (WebCore::AudioNode::setType): (WebCore::AudioNode::lazyInitialize): (WebCore::AudioNode::addInput): (WebCore::AudioNode::addOutput): (WebCore::AudioNode::input): (WebCore::AudioNode::output): (WebCore::AudioNode::connect): (WebCore::AudioNode::disconnect): (WebCore::AudioNode::processIfNecessary): (WebCore::AudioNode::pullInputs): (WebCore::AudioNode::ref): (WebCore::AudioNode::deref): (WebCore::AudioNode::finishDeref): (WebCore::AudioNode::printNodeCounts):
  • webaudio/AudioNode.h: Added. (WebCore::AudioNode::context): (WebCore::AudioNode::type): (WebCore::AudioNode::isInitialized): (WebCore::AudioNode::numberOfInputs): (WebCore::AudioNode::numberOfOutputs): (WebCore::AudioNode::sampleRate): (WebCore::AudioNode::checkNumberOfChannelsForInput):
  • webaudio/AudioNode.idl: Added.
3:58 PM Changeset in webkit [68437] by mrowe@apple.com
  • 5 edits in branches/safari-533.19-branch

Versioning.

3:58 PM Changeset in webkit [68436] by hyatt@apple.com
  • 4 edits
    5 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=46665

Reviewed by Sam Weinig.

Patch RenderView's layout and computeLogicalWidth/Height methods to be block-flow-aware.

Added fast/root-lr-basic.html

WebCore:

  • rendering/RenderView.cpp:

(WebCore::RenderView::computeLogicalHeight):
(WebCore::RenderView::computeLogicalWidth):
(WebCore::RenderView::layout):

  • rendering/RenderView.h:

(WebCore::RenderView::viewLogicalWidth):
(WebCore::RenderView::viewLogicalHeight):

LayoutTests:

  • fast/blockflow/root-lr-basic.html: Added.
  • platform/mac/fast/blockflow: Added.
  • platform/mac/fast/blockflow/root-lr-basic-expected.checksum: Added.
  • platform/mac/fast/blockflow/root-lr-basic-expected.png: Added.
  • platform/mac/fast/blockflow/root-lr-basic-expected.txt: Added.
3:55 PM Changeset in webkit [68435] by weinig@apple.com
  • 8 edits in trunk/WebKit2

Add remaining event handlers to WKView.

Reviewed by Anders Carlsson.

Also fixes <rdar://problem/8467058>
Does not get decidePolicyForNavigationAction callback when middle clicking a link

  • Adds otherButton and rightButton NSResponder event handlers to WKView.
  • Renames WebPageProxy event handlers to use the handle prefix.
  • Uses a macro to reduce duplicate code for WKView event handlers.
  • Add view parameter to WebEventFactory::createWebKeyboardEvent on the mac for uniformity.
  • Shared/mac/WebEventFactory.h:
  • Shared/mac/WebEventFactory.mm:

(WebKit::WebEventFactory::createWebKeyboardEvent):

  • UIProcess/API/mac/WKView.mm:
  • UIProcess/API/qt/qwkpage.cpp:

(QWKPagePrivate::keyPressEvent):
(QWKPagePrivate::keyReleaseEvent):
(QWKPagePrivate::mouseMoveEvent):
(QWKPagePrivate::mousePressEvent):
(QWKPagePrivate::mouseReleaseEvent):
(QWKPagePrivate::mouseDoubleClickEvent):
(QWKPagePrivate::wheelEvent):
(QWKPagePrivate::touchEvent):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::handleMouseEvent):
(WebKit::WebPageProxy::handleWheelEvent):
(WebKit::WebPageProxy::handleKeyboardEvent):
(WebKit::WebPageProxy::handleTouchEvent):

  • UIProcess/WebPageProxy.h:
  • UIProcess/win/WebView.cpp:

(WebKit::WebView::onMouseEvent):
(WebKit::WebView::onWheelEvent):
(WebKit::WebView::onKeyEvent):

3:51 PM Changeset in webkit [68434] by zmo@google.com
  • 6 edits in trunk

2010-09-24 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Hook up ANGLE with chromium --in-process-webgl port
https://bugs.webkit.org/show_bug.cgi?id=44309

  • WebKit.gyp: Add angle dependency.
  • src/WebGraphicsContext3DDefaultImpl.cpp: Using angle for shader validation and translation. (WebKit::WebGraphicsContext3DDefaultImpl::WebGraphicsContext3DDefaultImpl): (WebKit::WebGraphicsContext3DDefaultImpl::~WebGraphicsContext3DDefaultImpl): (WebKit::WebGraphicsContext3DDefaultImpl::initialize): (WebKit::WebGraphicsContext3DDefaultImpl::compileShader): (WebKit::WebGraphicsContext3DDefaultImpl::getIntegerv): Using defined const instead. (WebKit::WebGraphicsContext3DDefaultImpl::getShaderiv): (WebKit::WebGraphicsContext3DDefaultImpl::getShaderInfoLog): (WebKit::WebGraphicsContext3DDefaultImpl::getShaderSource): (WebKit::WebGraphicsContext3DDefaultImpl::shaderSource): (WebKit::WebGraphicsContext3DDefaultImpl::createShader): (WebKit::WebGraphicsContext3DDefaultImpl::deleteShader): (WebKit::WebGraphicsContext3DDefaultImpl::angleCreateCompilers): (WebKit::WebGraphicsContext3DDefaultImpl::angleDestroyCompilers): (WebKit::WebGraphicsContext3DDefaultImpl::angleValidateShaderSource):
  • src/WebGraphicsContext3DDefaultImpl.h: Add necessary data and functions for angle stuff. (WebKit::WebGraphicsContext3DDefaultImpl::ShaderSourceEntry::ShaderSourceEntry): (WebKit::WebGraphicsContext3DDefaultImpl::ShaderSourceEntry::~ShaderSourceEntry):

2010-09-24 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Hook up ANGLE with chromium --in-process-webgl port
https://bugs.webkit.org/show_bug.cgi?id=44309

  • platform/graphics/GraphicsContext3D.h: Move Angle stuff inside MAC only section.
3:47 PM Changeset in webkit [68433] by mrowe@apple.com
  • 1 copy in branches/safari-533.19-branch

New branch.

3:42 PM Changeset in webkit [68432] by mihaip@chromium.org
  • 2 edits in trunk/WebKitTools

2010-09-27 Mihai Parparita <mihaip@chromium.org>

Reviewed by Eric Seidel.

webkitpy.common.system.user_unittest.UserTest.test_prompt_with_list spams the console
https://bugs.webkit.org/show_bug.cgi?id=46634

Use OutputCapture to prevent console spam (and also check for expected
output).

  • Scripts/webkitpy/common/system/user_unittest.py:
3:41 PM Changeset in webkit [68431] by zmo@google.com
  • 2 edits in trunk/LayoutTests

2010-09-27 Zhenyao Mo <zmo@google.com>

Unreviewed, add fast/canvas/webgl/object-deletion-behaviour.html to test_expectations.txt (failing on Win/Linux).

  • platform/chromium/test_expectations.txt:
3:32 PM Changeset in webkit [68430] by hyatt@apple.com
  • 2 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=46659

Reviewed by Sam Weinig.

Patch the width/height/x/y calls in layoutBlock() to be their logical equivalents instead.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlock):

3:10 PM Changeset in webkit [68429] by mrowe@apple.com
  • 2 edits in trunk/WebKit2

<rdar://problem/8348990> / <http://webkit.org/b/46633> Make it possible to disable sandboxing of
web process via runtime flag.

Patch by Ivan Krstić <ike@apple.com> on 2010-09-27
Reviewed by Mark Rowe.

Enable sandboxing of the web process only if the DisableSandbox user default is not set for the
web process.

  • WebProcess/mac/WebProcessMainMac.mm:

(WebKit::WebProcessMain):

3:01 PM Changeset in webkit [68428] by andersca@apple.com
  • 3 edits in trunk/WebKit2

Add support for autogenerating synchronous message handlers
https://bugs.webkit.org/show_bug.cgi?id=46654

Reviewed by Adam Roben.

  • Scripts/webkit2/messages.py:

(reply_type): Renamed from reply_base_class.
(delayed_reply_type): Renamed from delayed_reply_base_class.
(message_to_struct_declaration): Add a Reply type typedef.
(async_case_statement): Rename from case_statement.
(generate_message_handler): Generate a sync message handler as well.

  • Scripts/webkit2/messages_unittest.py:

Update expected results.

2:56 PM Changeset in webkit [68427] by hyatt@apple.com
  • 12 edits in trunk

https://bugs.webkit.org/show_bug.cgi?id=46649, fix failing layout tests.

Reviewed by Sam Weinig.

The implementation of setting the before/after margins was wrong and poking the wrong margin values.

Once I made them set the correct values, it revealed that one of the new block flow tests wasn't
actually working. In order to fix it, I had to make the block direction margin computation actually
use the containing block's block-flow in order to return the right answer. This involved cleaning
up computeBlockDirectionMargins to be more like computeInlineDirectionMargins.

fast/css/logical-property-resolution.html also caught the bug. Its results are now correct.

WebCore:

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::adjustPositionedBlock):
(WebCore::RenderBlock::determineHorizontalPosition):
(WebCore::RenderBlock::layoutBlockChild):
(WebCore::RenderBlock::insertFloatingObject):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::setMarginBeforeUsing):
(WebCore::RenderBox::setMarginAfterUsing):
(WebCore::RenderBox::computeLogicalWidth):
(WebCore::RenderBox::computeInlineDirectionMargins):
(WebCore::RenderBox::computeLogicalHeight):
(WebCore::RenderBox::computeBlockDirectionMargins):

  • rendering/RenderBox.h:
  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutHorizontalBox):
(WebCore::RenderFlexibleBox::layoutVerticalBox):

  • rendering/RenderObject.h:
  • rendering/RenderTable.cpp:

(WebCore::RenderTable::computeLogicalWidth):

  • rendering/RenderTableRow.cpp:

(WebCore::RenderTableRow::layout):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::marginBeforeUsing):
(WebCore::RenderStyle::marginAfterUsing):

  • rendering/style/RenderStyle.h:

LayoutTests:

  • fast/css/logical-property-resolution-expected.txt:
2:54 PM Changeset in webkit [68426] by andersca@apple.com
  • 2 edits in trunk/JavaScriptCore

Fix thinko.

  • runtime/JSCell.h:
2:48 PM Changeset in webkit [68425] by andersca@apple.com
  • 2 edits in trunk/JavaScriptCore

Try to fix Windows build.

Reviewed by Adam Roben.

  • runtime/JSCell.h:

(JSC::MSVCBugWorkaround::MSVCBugWorkaround):
(JSC::MSVCBugWorkaround::~MSVCBugWorkaround):

2:27 PM Changeset in webkit [68424] by zmo@google.com
  • 12 edits
    2 adds in trunk

2010-09-14 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Textures and renderbuffers should be detached first before deletion if they are attached to framebuffers
https://bugs.webkit.org/show_bug.cgi?id=43942

Test: fast/canvas/webgl/object-deletion-behaviour.html

  • html/canvas/WebGLBuffer.cpp: (WebCore::WebGLBuffer::deleteObjectImpl): Delete the object only once.
  • html/canvas/WebGLFramebuffer.cpp: Use RefPtr for attachment WebGLObjects. (WebCore::WebGLFramebuffer::WebGLFramebuffer): (WebCore::WebGLFramebuffer::removeAttachment): Remove an attachment data ref. (WebCore::WebGLFramebuffer::onAttachedObjectChange): (WebCore::WebGLFramebuffer::getColorBufferFormat): (WebCore::WebGLFramebuffer::deleteObjectImpl): (WebCore::WebGLFramebuffer::initializeRenderbuffers):
  • html/canvas/WebGLFramebuffer.h: Declare removeAttachment().
  • html/canvas/WebGLObject.cpp: (WebCore::WebGLObject::setObject): Make it protected and can only be called when initializing.
  • html/canvas/WebGLObject.h: (WebCore::WebGLObject::onDetached): Fix a bug. (WebCore::WebGLObject::isDeleted): Expose the delete flag.
  • html/canvas/WebGLProgram.cpp: (WebCore::WebGLProgram::deleteObjectImpl): Detach shaders when deleting a program.
  • html/canvas/WebGLRenderbuffer.cpp: (WebCore::WebGLRenderbuffer::deleteObjectImpl): Delete the object only once.
  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::deleteFramebuffer): Bind to internal fbo when deleting the currently-bound fbo. (WebCore::WebGLRenderingContext::deleteRenderbuffer): Remove renderbuffer from currently-bound fbo upon deletion. (WebCore::WebGLRenderingContext::deleteTexture): Remove texture from currently-bound fbo upon deletion. (WebCore::WebGLRenderingContext::useProgram): Fix a condition.
  • html/canvas/WebGLShader.cpp: (WebCore::WebGLShader::deleteObjectImpl): Delete the object only once.
  • html/canvas/WebGLTexture.cpp: (WebCore::WebGLTexture::deleteObjectImpl): Ditto.

2010-09-14 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Textures and renderbuffers should be detached first before deletion if they are attached to framebuffers
https://bugs.webkit.org/show_bug.cgi?id=43942

  • fast/canvas/webgl/object-deletion-behaviour-expected.txt: Added.
  • fast/canvas/webgl/object-deletion-behaviour.html: Added.
2:10 PM Changeset in webkit [68423] by rniwa@webkit.org
  • 4 edits
    3 adds in trunk

2010-09-27 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Antonio Gomes.

stateStyle (@EditorCommand.cpp) should ask EditingBehavior for platform specific behavior
https://bugs.webkit.org/show_bug.cgi?id=41989

queryCommandState returns true even when in the mixed state
https://bugs.webkit.org/show_bug.cgi?id=46382

Fixed stateStyle so that it calls selectionStartHasStyle when shouldToggleStyleBasedOnStartOfSelection
is true (Mac platforms) and calls selectionHasStyle otherwise (non-Mac platforms).

Also fixed queryCommandState so that it only returns true when the state is TrueTriState
as supposed to returning true whenever the state is not FalseTriState. New behavior matches that of
other browsers such as Firefox and Internet Explorer.

  • dom/Document.cpp: (WebCore::Document::queryCommandState):
  • editing/EditorCommand.cpp: (WebCore::executeToggleStyle): (WebCore::stateStyle):

2010-09-27 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Antonio Gomes.

stateStyle (@EditorCommand.cpp) should ask EditingBehavior for platform specific behavior
https://bugs.webkit.org/show_bug.cgi?id=41989

Added a test to ensure queryCommandState returns correct values on Mac and Windows.

  • editing/execCommand/query-command-state-expected.txt: Added.
  • editing/execCommand/script-tests/query-command-state.js: Added. (testQueryCommandState): (selectAll): (selectSecondWord): (selectFirstTwoWords): (runTests):
1:43 PM Changeset in webkit [68422] by arv@chromium.org
  • 4 edits in trunk/JavaScriptCore

2010-09-27 Erik Arvidsson <arv@chromium.org>

Reviewed by Darin Adler.

Add operator == for AtomicString and Vector<Uchar>
https://bugs.webkit.org/show_bug.cgi?id=46509

  • JavaScriptCore.exp:
  • wtf/text/AtomicString.cpp: (WTF::operator==):
  • wtf/text/AtomicString.h: (WTF::operator==): (WTF::operator!=):
1:21 PM Changeset in webkit [68421] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-09-27 Eric Seidel <eric@webkit.org>

Reviewed by James Robinson.

start-commit-queue should abort any rebases in progress
https://bugs.webkit.org/show_bug.cgi?id=46640

webkit-patch commit-queue would do this itself, but this just
helps ensure that the commit-queue script is properly updated
before we run it (in the case where a previous rebase is in
progress the git svn rebase would not work before we run the
commit-queue).

  • EWSTools/start-commit-queue.sh:
1:16 PM Changeset in webkit [68420] by hyatt@apple.com
  • 3 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=46647, add getters/setters for the logical position of a box.

Reviewed by Dan Bernstein.

Also made all of the logicalWidth/Height getters/setters inline for performance.

  • rendering/RenderBox.cpp:
  • rendering/RenderBox.h:

(WebCore::RenderBox::logicalLeft):
(WebCore::RenderBox::logicalTop):
(WebCore::RenderBox::logicalWidth):
(WebCore::RenderBox::logicalHeight):
(WebCore::RenderBox::setLogicalLeft):
(WebCore::RenderBox::setLogicalTop):
(WebCore::RenderBox::setLogicalWidth):
(WebCore::RenderBox::setLogicalHeight):
(WebCore::RenderBox::setLogicalLocation):

1:02 PM Changeset in webkit [68419] by andersca@apple.com
  • 2 edits in trunk/JavaScriptCore

Try to fix the Windows build.

  • wtf/Noncopyable.h:
12:46 PM Changeset in webkit [68418] by mrobinson@webkit.org
  • 18 edits in trunk/LayoutTests

2010-09-27 Martin Robinson <mrobinson@igalia.com>

Rebaseline some tests where results differ between my machines
and the bots. Also skip two tests which, combined with r68406
exposed existing bugs.

  • platform/gtk/Skipped: Skip two tests with recently exposed bugs.
  • platform/gtk/fast/events/keydown-1-expected.txt:
  • platform/gtk/fast/frames/onlyCommentInIFrame-expected.txt:
  • platform/gtk/media/audio-controls-rendering-expected.txt:
  • platform/gtk/media/audio-no-installed-engines-expected.txt:
  • platform/gtk/media/controls-after-reload-expected.txt:
  • platform/gtk/media/controls-strict-expected.txt:
  • platform/gtk/media/video-display-toggle-expected.txt:
  • platform/gtk/media/video-empty-source-expected.txt:
  • platform/gtk/media/video-no-audio-expected.txt:
  • platform/gtk/media/video-replaces-poster-expected.txt:
  • platform/gtk/media/video-zoom-expected.txt:
  • platform/gtk/svg/batik/paints/patternRegions-positioned-objects-expected.txt:
  • platform/gtk/svg/custom/relative-sized-inner-svg-expected.txt:
  • platform/gtk/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.txt:
  • platform/gtk/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt:
  • platform/gtk/svg/zoom/text/zoom-coords-viewattr-01-b-expected.txt:
12:42 PM Changeset in webkit [68417] by hyatt@apple.com
  • 11 edits
    6 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=46639, make computeLogicalHeight block-flow-aware.

Reviewed by Sam Weinig.

This patch does the following:

(1) Makes computeLogicalHeight block-flow-aware (patching all helper functions as needed to make this work).
(2) Makes block flow roots (blocks whose parent has a different block-flow directionality) establish new block formatting contexts.
(This causes them to not collapse their margins with their children and to avoid floats).
(3) Patch all occurrences of setHeight in block and line layout to setLogicalHeight so that height doesn't get incorrectly
overwritten for lr/rl block-flow. This is necessary to write tests that examine the width/height of the blocks.


Added multiple new tests in fast/blockflow.
fast/css/logical-property-resolution gives the correct results now.

WebCore:

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::MarginInfo::MarginInfo):
(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::expandsToEncloseOverhangingFloats):
(WebCore::RenderBlock::adjustFloatingBlock):
(WebCore::RenderBlock::collapseMargins):
(WebCore::RenderBlock::clearFloatsIfNeeded):
(WebCore::RenderBlock::determineHorizontalPosition):
(WebCore::RenderBlock::handleBottomOfBlock):
(WebCore::RenderBlock::layoutBlockChildren):
(WebCore::RenderBlock::layoutBlockChild):
(WebCore::RenderBlock::positionNewFloatOnLine):
(WebCore::RenderBlock::newLine):
(WebCore::RenderBlock::logicalLeftOffsetForLine):
(WebCore::RenderBlock::logicalRightOffsetForContent):
(WebCore::RenderBlock::logicalRightOffsetForLine):
(WebCore::RenderBlock::getClearDelta):
(WebCore::RenderBlock::layoutColumns):

  • rendering/RenderBlock.h:
  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::computeBlockDirectionPositionsForLine):
(WebCore::RenderBlock::layoutInlineChildren):
(WebCore::RenderBlock::determineStartPosition):
(WebCore::RenderBlock::fitBelowFloats):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::marginBefore):
(WebCore::RenderBox::marginBeforeUsing):
(WebCore::RenderBox::marginAfter):
(WebCore::RenderBox::marginAfterUsing):
(WebCore::RenderBox::setMarginBefore):
(WebCore::RenderBox::setMarginAfter):
(WebCore::RenderBox::setMarginBeforeUsing):
(WebCore::RenderBox::setMarginAfterUsing):
(WebCore::RenderBox::computeLogicalHeight):
(WebCore::RenderBox::computeLogicalHeightUsing):
(WebCore::RenderBox::computePercentageLogicalHeight):
(WebCore::RenderBox::computeReplacedHeightUsing):
(WebCore::RenderBox::availableLogicalHeight):
(WebCore::RenderBox::availableLogicalHeightUsing):
(WebCore::RenderBox::computeBlockDirectionMargins):
(WebCore::RenderBox::avoidsFloats):

  • rendering/RenderBox.h:

(WebCore::RenderBox::contentLogicalWidth):
(WebCore::RenderBox::contentLogicalHeight):
(WebCore::RenderBox::stretchesToViewHeight):
(WebCore::RenderBox::availableLogicalWidth):
(WebCore::RenderBox::availableWidth):
(WebCore::RenderBox::availableHeight):
(WebCore::RenderBox::isBlockFlowRoot):

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::computeLogicalWidth):

LayoutTests:

  • fast/blockflow/auto-margins-across-boundaries-expected.txt: Added.
  • fast/blockflow/auto-margins-across-boundaries.html: Added.
  • fast/blockflow/block-formatting-context-expected.txt: Added.
  • fast/blockflow/block-formatting-context.html: Added.
  • fast/blockflow/percentage-padding.html:
  • fast/blockflow/relative-positioning-percentages-expected.txt: Added.
  • fast/blockflow/relative-positioning-percentages.html: Added.
  • fast/css/logical-property-resolution-expected.txt:
12:41 PM Changeset in webkit [68416] by kinuko@chromium.org
  • 2 edits in trunk/LayoutTests

2010-09-27 Kinuko Yasuda <kinuko@chromium.org>

Unreviewed, updating chromium test_expectations for passing tests.

  • platform/chromium/test_expectations.txt:
12:35 PM Changeset in webkit [68415] by commit-queue@webkit.org
  • 8 edits in trunk

2010-09-27 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Chris Fleizach.

[Gtk] Adjust atk_text_get_text_at_offset to account for bullets/numbers in list items
https://bugs.webkit.org/show_bug.cgi?id=45381

Ensure list markers are consistently used in the Atk wrapper.

This patch does two things (both needed to fix the bug): It
improves the way list items markers are exposed through the Atk
Wrapper (by exposing the exact text in the marker, including the
marker suffix, if any) and makes sure the marker is consistently
considered and treated in those methods of the AtkText interface
that would need it (like atk_text_get_character_count or
atk_text_get_run_attributes, for instance).

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (textForObject):

Append/prepend list marker when needed.

(webkit_accessible_text_get_text):

Use the new function markerTextWithSuffix() to expose a more
accurate value.

(accessibilityObjectLength):

Consider list items marker to return the length of an object,
if needed. Also, added some extra checks.

(webkit_accessible_text_get_character_count):

Just delegate on accessibilityObjectLength, to make it
cleaner and more consistent.

  • rendering/RenderListItem.cpp: (WebCore::RenderListItem::markerTextWithSuffix):

New public function to return a single string with the
marker associated to the item and its suffix, considering
text direction (LTR or RTL).

  • rendering/RenderListItem.h:
  • rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::suffix):

New public function to return a String with the suffix
associated to the marker.

  • rendering/RenderListMarker.h:

2010-09-27 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Chris Fleizach.

[Gtk] Adjust atk_text_get_text_at_offset to account for bullets/numbers in list items
https://bugs.webkit.org/show_bug.cgi?id=45381

Updated test to match the new exposure of list item markers.

Also, added some extra assertions in that test to make sure the
accessible objects associated to the items implement AtkText.

  • tests/testatk.c: (testWebkitAtkListsOfItems): (main):
12:18 PM Changeset in webkit [68414] by andersca@apple.com
  • 4 edits in trunk/JavaScriptCore

Add WTF_MAKE_NONCOPYABLE macro
https://bugs.webkit.org/show_bug.cgi?id=46589

Reviewed by Alexey Proskuryakov and Adam Barth.

Going forward, we'd like to get rid of the Noncopyable and FastAllocBase classes. The
reason for this is that the Itanium C++ ABI states that no empty classes of the same type
can be laid out at the same offset in the class. This can result in objects getting larger
which leads to memory regressions. (One example of this is the String class which grew by
sizeof(void*) when both its base class and its first member variable inherited indirectly
from FastAllocBase).

  • wtf/Noncopyable.h:

Add a WTF_MAKE_NONCOPYABLE macro and get rid of NoncopyableCustomAllocated.

  • runtime/JSCell.h:
  • wtf/RefCounted.h:

Don't inherit from NoncopyableCustomAllocated. Instead, use WTF_MAKE_NONCOPYABLE.

12:17 PM Changeset in webkit [68413] by andersca@apple.com
  • 3 edits
    2 adds in trunk/WebKit2

Add PluginProxy class
https://bugs.webkit.org/show_bug.cgi?id=46586

Reviewed by Sam Weinig.

  • WebKit2.xcodeproj/project.pbxproj:

Add files.

  • WebProcess/Plugins/PluginProxy.cpp: Added.
  • WebProcess/Plugins/PluginProxy.h: Added.
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::createPlugin):
Create a PluginProxy wrapper.

12:16 PM Changeset in webkit [68412] by commit-queue@webkit.org
  • 3 edits in trunk/WebCore

2010-09-27 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r68389.
http://trac.webkit.org/changeset/68389
https://bugs.webkit.org/show_bug.cgi?id=46637

test_shell is crashing on chromium Win (Requested by loislo on
#webkit).

  • inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::InspectorTimelineAgent): (WebCore::InspectorTimelineAgent::pushGCEventRecords): (WebCore::InspectorTimelineAgent::didGC): (WebCore::InspectorTimelineAgent::~InspectorTimelineAgent): (WebCore::InspectorTimelineAgent::willCallFunction): (WebCore::InspectorTimelineAgent::didCallFunction): (WebCore::InspectorTimelineAgent::willDispatchEvent): (WebCore::InspectorTimelineAgent::didDispatchEvent): (WebCore::InspectorTimelineAgent::willLayout): (WebCore::InspectorTimelineAgent::didLayout): (WebCore::InspectorTimelineAgent::willRecalculateStyle): (WebCore::InspectorTimelineAgent::didRecalculateStyle): (WebCore::InspectorTimelineAgent::willPaint): (WebCore::InspectorTimelineAgent::didPaint): (WebCore::InspectorTimelineAgent::willWriteHTML): (WebCore::InspectorTimelineAgent::didWriteHTML): (WebCore::InspectorTimelineAgent::didInstallTimer): (WebCore::InspectorTimelineAgent::didRemoveTimer): (WebCore::InspectorTimelineAgent::willFireTimer): (WebCore::InspectorTimelineAgent::didFireTimer): (WebCore::InspectorTimelineAgent::willChangeXHRReadyState): (WebCore::InspectorTimelineAgent::didChangeXHRReadyState): (WebCore::InspectorTimelineAgent::willLoadXHR): (WebCore::InspectorTimelineAgent::didLoadXHR): (WebCore::InspectorTimelineAgent::willEvaluateScript): (WebCore::InspectorTimelineAgent::didEvaluateScript): (WebCore::InspectorTimelineAgent::didScheduleResourceRequest): (WebCore::InspectorTimelineAgent::willSendResourceRequest): (WebCore::InspectorTimelineAgent::willReceiveResourceData): (WebCore::InspectorTimelineAgent::didReceiveResourceData): (WebCore::InspectorTimelineAgent::willReceiveResourceResponse): (WebCore::InspectorTimelineAgent::didReceiveResourceResponse): (WebCore::InspectorTimelineAgent::didFinishLoadingResource): (WebCore::InspectorTimelineAgent::didMarkTimeline): (WebCore::InspectorTimelineAgent::didMarkDOMContentEvent): (WebCore::InspectorTimelineAgent::didMarkLoadEvent): (WebCore::InspectorTimelineAgent::reset): (WebCore::InspectorTimelineAgent::resetFrontendProxyObject): (WebCore::InspectorTimelineAgent::addRecordToTimeline): (WebCore::InspectorTimelineAgent::setHeapSizeStatistic): (WebCore::InspectorTimelineAgent::didCompleteCurrentRecord): (WebCore::InspectorTimelineAgent::pushCurrentRecord):
  • inspector/InspectorTimelineAgent.h: (WebCore::InspectorTimelineAgent::TimelineRecordEntry::TimelineRecordEntry): (WebCore::InspectorTimelineAgent::GCEvent::GCEvent):
12:05 PM Changeset in webkit [68411] by kinuko@chromium.org
  • 10 edits in trunk

2010-09-27 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by Adam Barth.

[Cleanup] Add create method to FileSystemCallbacks to get rid of naked new's
https://bugs.webkit.org/show_bug.cgi?id=46561

Also cleanup the callbacks layering to pass AsyncFileSystemCallbacks
object to LocalFileSystem::requestFileSystem (rather than
FileSystemCallback and ErrorCallback) so that all the callbacks class
we pass from WebCore to WebKit/chromium/src will be
AsyncFileSystemCallbacks.

  • src/LocalFileSystemChromium.cpp: (WebCore::LocalFileSystem::requestFileSystem): Changed to take AsyncFileSystemCallbacks as (a) callback argument(s).

2010-09-27 Kinuko Yasuda <kinuko@google.com>

Reviewed by Adam Barth.

[Cleanup] Add create method to FileSystemCallbacks to get rid of naked new's
https://bugs.webkit.org/show_bug.cgi?id=46561

Also cleanup the callbacks layering to pass AsyncFileSystemCallbacks
object to LocalFileSystem::requestFileSystem (rather than
FileSystemCallback and ErrorCallback) so that all the callbacks class
we pass from WebCore to WebKit/chromium/src will be
AsyncFileSystemCallbacks.

No new tests; this patch is only for cleanup and there should be no functionality changes.

  • fileapi/DOMFileSystem.cpp: (WebCore::DOMFileSystem::getMetadata): (WebCore::DOMFileSystem::move): (WebCore::DOMFileSystem::copy): (WebCore::DOMFileSystem::remove): (WebCore::DOMFileSystem::getParent): (WebCore::DOMFileSystem::getFile): (WebCore::DOMFileSystem::getDirectory): (WebCore::DOMFileSystem::createWriter): (WebCore::DOMFileSystem::readDirectory):
  • fileapi/FileSystemCallbacks.cpp: (WebCore::EntryCallbacks::create): Added. (WebCore::EntriesCallbacks::create): Added. (WebCore::FileSystemCallbacks::create): Added. (WebCore::MetadataCallbacks::create): Added. (WebCore::FileWriterCallbacks::create): Added. (WebCore::VoidCallbacks::create): Added.
  • fileapi/FileSystemCallbacks.h:
  • fileapi/LocalFileSystem.cpp: (WebCore::openFileSystem): (WebCore::LocalFileSystem::requestFileSystem): Changed to take AsyncFileSystemCallbacks as (a) callback argument(s).
  • fileapi/LocalFileSystem.h:
  • page/DOMWindow.cpp: (WebCore::DOMWindow::requestFileSystem): Made a corresponding change to LocalFileSystem::requestFileSystem.
  • workers/WorkerContext.cpp: (WebCore::WorkerContext::requestFileSystem): Made a corresponding change to LocalFileSystem::requestFileSystem.
11:48 AM Changeset in webkit [68410] by tony@chromium.org
  • 2 edits
    2 deletes in trunk/WebKit/chromium

2010-09-24 Tony Chang <tony@chromium.org>

Reviewed by Kent Tamura.

[chromium] remove unused gtk WebScreenInfoFactory
https://bugs.webkit.org/show_bug.cgi?id=46526

AFAICT these files aren't referenced in code or by gyp.

  • WebKit.gyp: Remove duplicate filename.
  • public/gtk/WebScreenInfoFactory.h: Removed.
  • src/gtk/WebScreenInfoFactory.cpp: Removed.
11:26 AM Changeset in webkit [68409] by Csaba Osztrogonác
  • 2 edits in trunk/WebKit2

2010-09-27 Andras Becsi <abecsi@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt] Make generate-forwarding-headers.pl aware of moved headers
https://bugs.webkit.org/show_bug.cgi?id=46621

  • generate-forwarding-headers.pl:
11:18 AM Changeset in webkit [68408] by inferno@chromium.org
  • 4 edits
    2 adds in trunk

2010-09-27 Abhishek Arya <inferno@chromium.org>

Reviewed by Dave Hyatt.

Fix memory safety issue during positioning list marker as a result of assuming
that list item's parent can always be casted to a RenderBox. The display of the parent
can be manipluated using css as Inline which causes a bad cast.

https://bugs.webkit.org/show_bug.cgi?id=46384

Test: fast/lists/parent-box-not-box-crash.html

  • rendering/RenderListItem.cpp: (WebCore::RenderListItem::positionListMarker):
  • rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::layout):

2010-09-27 Abhishek Arya <inferno@chromium.org>

Reviewed by Dave Hyatt.

Tests that positioning the list marker whose parent (child div) is not
a box (inline because of the run-in style) does not result in crash.
https://bugs.webkit.org/show_bug.cgi?id=46384

  • fast/lists/parent-box-not-box-crash-expected.txt: Added.
  • fast/lists/parent-box-not-box-crash.html: Added.
11:11 AM Changeset in webkit [68407] by caseq@chromium.org
  • 2 edits in trunk/LayoutTests

2010-09-27 Andrey Kosyakov <caseq@chromium.org>

Unreviewed.
Marked svg/custom/clip-path-referencing-use2.svg & svg/custom/circular-marker-reference-4.svg flaky under linux.

  • platform/chromium/test_expectations.txt:
11:00 AM Changeset in webkit [68406] by mrobinson@webkit.org
  • 737 edits
    5 adds in trunk

2010-09-27 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] Wrong font instantiated from an unknown font family
https://bugs.webkit.org/show_bug.cgi?id=36548

Rebaseline tests which have new results now that they use different fonts.

  • platform/gtk/animations/animation-drt-api-expected.txt:
  • platform/gtk/animations/animation-drt-api-multiple-keyframes-expected.txt:
  • platform/gtk/animations/state-at-end-event-expected.txt:
  • platform/gtk/css1/basic/class_as_selector-expected.txt:
  • platform/gtk/css1/basic/comments-expected.txt:
  • platform/gtk/css1/basic/containment-expected.txt:
  • platform/gtk/css1/basic/contextual_selectors-expected.txt:
  • platform/gtk/css1/basic/grouping-expected.txt:
  • platform/gtk/css1/basic/id_as_selector-expected.txt:
  • platform/gtk/css1/basic/inheritance-expected.txt:
  • platform/gtk/css1/box_properties/border-expected.txt:
  • platform/gtk/css1/box_properties/border_bottom-expected.txt:
  • platform/gtk/css1/box_properties/border_bottom_inline-expected.txt:
  • platform/gtk/css1/box_properties/border_bottom_width-expected.txt:
  • platform/gtk/css1/box_properties/border_bottom_width_inline-expected.txt:
  • platform/gtk/css1/box_properties/border_color-expected.txt:
  • platform/gtk/css1/box_properties/border_color_inline-expected.txt:
  • platform/gtk/css1/box_properties/border_inline-expected.txt:
  • platform/gtk/css1/box_properties/border_left-expected.txt:
  • platform/gtk/css1/box_properties/border_left_inline-expected.txt:
  • platform/gtk/css1/box_properties/border_left_width-expected.txt:
  • platform/gtk/css1/box_properties/border_left_width_inline-expected.txt:
  • platform/gtk/css1/box_properties/border_right-expected.txt:
  • platform/gtk/css1/box_properties/border_right_inline-expected.txt:
  • platform/gtk/css1/box_properties/border_right_width-expected.txt:
  • platform/gtk/css1/box_properties/border_right_width_inline-expected.txt:
  • platform/gtk/css1/box_properties/border_style-expected.txt:
  • platform/gtk/css1/box_properties/border_style_inline-expected.txt:
  • platform/gtk/css1/box_properties/border_top-expected.txt:
  • platform/gtk/css1/box_properties/border_top_inline-expected.txt:
  • platform/gtk/css1/box_properties/border_top_width-expected.txt:
  • platform/gtk/css1/box_properties/border_top_width_inline-expected.txt:
  • platform/gtk/css1/box_properties/border_width-expected.txt:
  • platform/gtk/css1/box_properties/border_width_inline-expected.txt:
  • platform/gtk/css1/box_properties/clear-expected.txt:
  • platform/gtk/css1/box_properties/clear_float-expected.txt:
  • platform/gtk/css1/box_properties/float-expected.txt:
  • platform/gtk/css1/box_properties/float_elements_in_series-expected.txt:
  • platform/gtk/css1/box_properties/float_margin-expected.txt:
  • platform/gtk/css1/box_properties/float_on_text_elements-expected.txt:
  • platform/gtk/css1/box_properties/height-expected.txt:
  • platform/gtk/css1/box_properties/margin-expected.txt:
  • platform/gtk/css1/box_properties/margin_bottom-expected.txt:
  • platform/gtk/css1/box_properties/margin_bottom_inline-expected.txt:
  • platform/gtk/css1/box_properties/margin_inline-expected.txt:
  • platform/gtk/css1/box_properties/margin_left-expected.txt:
  • platform/gtk/css1/box_properties/margin_left_inline-expected.txt:
  • platform/gtk/css1/box_properties/margin_right-expected.txt:
  • platform/gtk/css1/box_properties/margin_right_inline-expected.txt:
  • platform/gtk/css1/box_properties/margin_top-expected.txt:
  • platform/gtk/css1/box_properties/margin_top_inline-expected.txt:
  • platform/gtk/css1/box_properties/padding-expected.txt:
  • platform/gtk/css1/box_properties/padding_bottom-expected.txt:
  • platform/gtk/css1/box_properties/padding_bottom_inline-expected.txt:
  • platform/gtk/css1/box_properties/padding_inline-expected.txt:
  • platform/gtk/css1/box_properties/padding_left-expected.txt:
  • platform/gtk/css1/box_properties/padding_left_inline-expected.txt:
  • platform/gtk/css1/box_properties/padding_right-expected.txt:
  • platform/gtk/css1/box_properties/padding_right_inline-expected.txt:
  • platform/gtk/css1/box_properties/padding_top-expected.txt:
  • platform/gtk/css1/box_properties/padding_top_inline-expected.txt:
  • platform/gtk/css1/box_properties/width-expected.txt:
  • platform/gtk/css1/cascade/cascade_order-expected.txt:
  • platform/gtk/css1/cascade/important-expected.txt:
  • platform/gtk/css1/classification/display-expected.txt:
  • platform/gtk/css1/classification/list_style-expected.txt:
  • platform/gtk/css1/classification/list_style_image-expected.txt:
  • platform/gtk/css1/classification/list_style_position-expected.txt:
  • platform/gtk/css1/classification/list_style_type-expected.txt:
  • platform/gtk/css1/classification/white_space-expected.txt:
  • platform/gtk/css1/color_and_background/background-expected.txt:
  • platform/gtk/css1/color_and_background/background_attachment-expected.txt:
  • platform/gtk/css1/color_and_background/background_color-expected.txt:
  • platform/gtk/css1/color_and_background/background_image-expected.txt:
  • platform/gtk/css1/color_and_background/background_position-expected.txt:
  • platform/gtk/css1/color_and_background/background_repeat-expected.txt:
  • platform/gtk/css1/color_and_background/color-expected.txt:
  • platform/gtk/css1/conformance/forward_compatible_parsing-expected.txt:
  • platform/gtk/css1/font_properties/font-expected.txt:
  • platform/gtk/css1/font_properties/font_family-expected.txt:
  • platform/gtk/css1/font_properties/font_size-expected.txt:
  • platform/gtk/css1/font_properties/font_style-expected.txt:
  • platform/gtk/css1/font_properties/font_variant-expected.txt:
  • platform/gtk/css1/font_properties/font_weight-expected.txt:
  • platform/gtk/css1/formatting_model/canvas-expected.txt:
  • platform/gtk/css1/formatting_model/floating_elements-expected.txt:
  • platform/gtk/css1/formatting_model/height_of_lines-expected.txt:
  • platform/gtk/css1/formatting_model/horizontal_formatting-expected.txt:
  • platform/gtk/css1/formatting_model/inline_elements-expected.txt:
  • platform/gtk/css1/formatting_model/replaced_elements-expected.txt:
  • platform/gtk/css1/formatting_model/vertical_formatting-expected.txt:
  • platform/gtk/css1/pseudo/anchor-expected.txt:
  • platform/gtk/css1/pseudo/firstletter-expected.txt:
  • platform/gtk/css1/pseudo/firstline-expected.txt:
  • platform/gtk/css1/pseudo/multiple_pseudo_elements-expected.txt:
  • platform/gtk/css1/pseudo/pseudo_elements_in_selectors-expected.txt:
  • platform/gtk/css1/text_properties/letter_spacing-expected.txt:
  • platform/gtk/css1/text_properties/line_height-expected.txt:
  • platform/gtk/css1/text_properties/text_align-expected.txt:
  • platform/gtk/css1/text_properties/text_decoration-expected.txt:
  • platform/gtk/css1/text_properties/text_indent-expected.txt:
  • platform/gtk/css1/text_properties/text_transform-expected.txt:
  • platform/gtk/css1/text_properties/vertical_align-expected.txt:
  • platform/gtk/css1/text_properties/word_spacing-expected.txt:
  • platform/gtk/css1/units/color_units-expected.txt:
  • platform/gtk/css1/units/length_units-expected.txt:
  • platform/gtk/css1/units/percentage_units-expected.txt:
  • platform/gtk/css1/units/urls-expected.txt:
  • platform/gtk/css3/css3-modsel-33-expected.txt:
  • platform/gtk/css3/css3-modsel-35-expected.txt:
  • platform/gtk/css3/css3-modsel-36-expected.txt:
  • platform/gtk/css3/css3-modsel-37-expected.txt:
  • platform/gtk/dom/xhtml/level3/core/documentgetinputencoding03-expected.txt:
  • platform/gtk/dom/xhtml/level3/core/entitygetinputencoding02-expected.txt:
  • platform/gtk/dom/xhtml/level3/core/entitygetxmlversion02-expected.txt:
  • platform/gtk/dom/xhtml/level3/core/nodegetbaseuri05-expected.txt:
  • platform/gtk/dom/xhtml/level3/core/nodegetbaseuri07-expected.txt:
  • platform/gtk/dom/xhtml/level3/core/nodegetbaseuri09-expected.txt:
  • platform/gtk/dom/xhtml/level3/core/nodegetbaseuri10-expected.txt:
  • platform/gtk/dom/xhtml/level3/core/nodegetbaseuri11-expected.txt:
  • platform/gtk/dom/xhtml/level3/core/nodegetbaseuri15-expected.txt:
  • platform/gtk/dom/xhtml/level3/core/nodegetbaseuri17-expected.txt:
  • platform/gtk/dom/xhtml/level3/core/nodegetbaseuri18-expected.txt:
  • platform/gtk/dom/xhtml/level3/core/nodelookupnamespaceuri01-expected.txt:
  • platform/gtk/dom/xhtml/level3/core/nodelookupprefix19-expected.txt:
  • platform/gtk/editing/deleting/4922367-expected.txt:
  • platform/gtk/editing/deleting/5026848-1-expected.txt:
  • platform/gtk/editing/deleting/5026848-2-expected.txt:
  • platform/gtk/editing/deleting/5026848-3-expected.txt:
  • platform/gtk/editing/deleting/5032066-expected.txt:
  • platform/gtk/editing/deleting/5091898-expected.txt:
  • platform/gtk/editing/deleting/5099303-expected.txt:
  • platform/gtk/editing/deleting/5115601-expected.txt:
  • platform/gtk/editing/deleting/5126166-expected.txt:
  • platform/gtk/editing/deleting/5156801-2-expected.txt:
  • platform/gtk/editing/deleting/5206311-1-expected.txt:
  • platform/gtk/editing/deleting/5206311-2-expected.txt:
  • platform/gtk/editing/deleting/5272440-expected.txt:
  • platform/gtk/editing/deleting/5300379-expected.txt:
  • platform/gtk/editing/deleting/5369009-expected.txt:
  • platform/gtk/editing/deleting/5390681-2-expected.txt:
  • platform/gtk/editing/deleting/5390681-expected.txt:
  • platform/gtk/editing/deleting/5433862-2-expected.txt:
  • platform/gtk/editing/deleting/5483370-expected.txt:
  • platform/gtk/editing/deleting/collapse-whitespace-3587601-fix-expected.txt:
  • platform/gtk/editing/deleting/delete-3608430-fix-expected.txt:
  • platform/gtk/editing/deleting/delete-3608445-fix-expected.txt:
  • platform/gtk/editing/deleting/delete-3608462-fix-expected.txt:
  • platform/gtk/editing/deleting/delete-3775172-fix-expected.txt:
  • platform/gtk/editing/deleting/delete-3800834-fix-expected.txt:
  • platform/gtk/editing/deleting/delete-3959464-fix-expected.txt:
  • platform/gtk/editing/deleting/delete-and-undo-expected.txt:
  • platform/gtk/editing/deleting/delete-block-contents-001-expected.txt:
  • platform/gtk/editing/deleting/delete-block-contents-002-expected.txt:
  • platform/gtk/editing/deleting/delete-block-contents-003-expected.txt:
  • platform/gtk/editing/deleting/delete-block-merge-contents-010-expected.txt:
  • platform/gtk/editing/deleting/delete-block-merge-contents-012-expected.txt:
  • platform/gtk/editing/deleting/delete-block-merge-contents-013-expected.txt:
  • platform/gtk/editing/deleting/delete-block-merge-contents-014-expected.txt:
  • platform/gtk/editing/deleting/delete-block-merge-contents-015-expected.txt:
  • platform/gtk/editing/deleting/delete-block-merge-contents-016-expected.txt:
  • platform/gtk/editing/deleting/delete-block-merge-contents-017-expected.txt:
  • platform/gtk/editing/deleting/delete-br-001-expected.txt:
  • platform/gtk/editing/deleting/delete-br-002-expected.txt:
  • platform/gtk/editing/deleting/delete-br-003-expected.txt:
  • platform/gtk/editing/deleting/delete-br-004-expected.txt:
  • platform/gtk/editing/deleting/delete-br-005-expected.txt:
  • platform/gtk/editing/deleting/delete-br-006-expected.txt:
  • platform/gtk/editing/deleting/delete-br-007-expected.txt:
  • platform/gtk/editing/deleting/delete-br-010-expected.txt:
  • platform/gtk/editing/deleting/delete-br-013-expected.txt:
  • platform/gtk/editing/deleting/delete-by-word-001-expected.txt:
  • platform/gtk/editing/deleting/delete-contiguous-ws-001-expected.txt:
  • platform/gtk/editing/deleting/delete-image-004-expected.txt:
  • platform/gtk/editing/deleting/delete-leading-ws-001-expected.txt:
  • platform/gtk/editing/deleting/delete-line-001-expected.txt:
  • platform/gtk/editing/deleting/delete-line-002-expected.txt:
  • platform/gtk/editing/deleting/delete-line-005-expected.txt:
  • platform/gtk/editing/deleting/delete-line-006-expected.txt:
  • platform/gtk/editing/deleting/delete-line-007-expected.txt:
  • platform/gtk/editing/deleting/delete-line-008-expected.txt:
  • platform/gtk/editing/deleting/delete-line-009-expected.txt:
  • platform/gtk/editing/deleting/delete-line-010-expected.txt:
  • platform/gtk/editing/deleting/delete-line-011-expected.txt:
  • platform/gtk/editing/deleting/delete-line-012-expected.txt:
  • platform/gtk/editing/deleting/delete-line-013-expected.txt:
  • platform/gtk/editing/deleting/delete-line-014-expected.txt:
  • platform/gtk/editing/deleting/delete-line-end-ws-001-expected.txt:
  • platform/gtk/editing/deleting/delete-line-end-ws-002-expected.txt:
  • platform/gtk/editing/deleting/delete-listitem-001-expected.txt:
  • platform/gtk/editing/deleting/delete-listitem-002-expected.txt:
  • platform/gtk/editing/deleting/delete-select-all-002-expected.txt:
  • platform/gtk/editing/deleting/delete-tab-002-expected.txt:
  • platform/gtk/editing/deleting/delete-tab-004-expected.txt:
  • platform/gtk/editing/deleting/delete-to-end-of-paragraph-expected.txt:
  • platform/gtk/editing/deleting/delete-to-select-table-expected.txt:
  • platform/gtk/editing/deleting/delete-trailing-ws-002-expected.txt:
  • platform/gtk/editing/deleting/delete-ws-fixup-001-expected.txt:
  • platform/gtk/editing/deleting/delete-ws-fixup-002-expected.txt:
  • platform/gtk/editing/deleting/forward-delete-expected.txt:
  • platform/gtk/editing/deleting/merge-whitespace-pre-expected.txt:
  • platform/gtk/editing/deleting/move-nodes-001-expected.txt:
  • platform/gtk/editing/deleting/smart-delete-003-expected.txt:
  • platform/gtk/editing/deleting/smart-delete-004-expected.txt:
  • platform/gtk/editing/deleting/type-delete-after-quote-expected.txt:
  • platform/gtk/editing/execCommand/4580583-1-expected.txt:
  • platform/gtk/editing/execCommand/4580583-2-expected.txt:
  • platform/gtk/editing/execCommand/4747450-expected.txt:
  • platform/gtk/editing/execCommand/4786404-1-expected.txt:
  • platform/gtk/editing/execCommand/4786404-2-expected.txt:
  • platform/gtk/editing/execCommand/4916402-expected.txt:
  • platform/gtk/editing/execCommand/4916541-expected.txt:
  • platform/gtk/editing/execCommand/4920488-expected.txt:
  • platform/gtk/editing/execCommand/4920742-1-expected.txt:
  • platform/gtk/editing/execCommand/4924441-expected.txt:
  • platform/gtk/editing/execCommand/5049671-expected.txt:
  • platform/gtk/editing/execCommand/5080333-1-expected.txt:
  • platform/gtk/editing/execCommand/5080333-2-expected.txt:
  • platform/gtk/editing/execCommand/5136770-expected.txt:
  • platform/gtk/editing/execCommand/5138441-expected.txt:
  • platform/gtk/editing/execCommand/5142012-1-expected.txt:
  • platform/gtk/editing/execCommand/5142012-2-expected.txt:
  • platform/gtk/editing/execCommand/5190926-expected.txt:
  • platform/gtk/editing/execCommand/5481523-expected.txt:
  • platform/gtk/editing/execCommand/5482023-expected.txt:
  • platform/gtk/editing/execCommand/5569741-expected.txt:
  • platform/gtk/editing/execCommand/5573879-expected.txt:
  • platform/gtk/editing/inserting/12882-expected.txt:
  • platform/gtk/editing/inserting/4840662-expected.txt:
  • platform/gtk/editing/inserting/4875189-1-expected.txt:
  • platform/gtk/editing/inserting/4875189-2-expected.txt:
  • platform/gtk/editing/inserting/4959067-expected.txt:
  • platform/gtk/editing/inserting/4960120-2-expected.txt:
  • platform/gtk/editing/inserting/5002441-expected.txt:
  • platform/gtk/editing/inserting/5058163-1-expected.txt:
  • platform/gtk/editing/inserting/5058163-2-expected.txt:
  • platform/gtk/editing/inserting/5156401-2-expected.txt:
  • platform/gtk/editing/inserting/5418891-expected.txt:
  • platform/gtk/editing/inserting/5510537-expected.txt:
  • platform/gtk/editing/inserting/5549929-2-expected.txt:
  • platform/gtk/editing/inserting/5549929-3-expected.txt:
  • platform/gtk/editing/inserting/6703873-expected.txt:
  • platform/gtk/editing/inserting/editable-inline-element-expected.txt:
  • platform/gtk/editing/inserting/edited-whitespace-1-expected.txt:
  • platform/gtk/editing/inserting/insert-3654864-fix-expected.txt:
  • platform/gtk/editing/inserting/insert-3775316-fix-expected.txt:
  • platform/gtk/editing/inserting/insert-3800346-fix-expected.txt:
  • platform/gtk/editing/inserting/insert-3851164-fix-expected.txt:
  • platform/gtk/editing/inserting/insert-3907422-fix-expected.txt:
  • platform/gtk/editing/inserting/insert-after-delete-001-expected.txt:
  • platform/gtk/editing/inserting/insert-br-005-expected.txt:
  • platform/gtk/editing/inserting/insert-div-001-expected.txt:
  • platform/gtk/editing/inserting/insert-div-002-expected.txt:
  • platform/gtk/editing/inserting/insert-div-003-expected.txt:
  • platform/gtk/editing/inserting/insert-div-004-expected.txt:
  • platform/gtk/editing/inserting/insert-div-005-expected.txt:
  • platform/gtk/editing/inserting/insert-div-009-expected.txt:
  • platform/gtk/editing/inserting/insert-div-024-expected.txt:
  • platform/gtk/editing/inserting/insert-space-in-empty-doc-expected.txt:
  • platform/gtk/editing/inserting/insert-text-with-newlines-expected.txt:
  • platform/gtk/editing/inserting/redo-expected.txt:
  • platform/gtk/editing/inserting/typing-001-expected.txt:
  • platform/gtk/editing/inserting/typing-002-expected.txt:
  • platform/gtk/editing/inserting/typing-003-expected.txt:
  • platform/gtk/editing/inserting/typing-around-br-001-expected.txt:
  • platform/gtk/editing/inserting/typing-around-image-001-expected.txt:
  • platform/gtk/editing/pasteboard/4076267-2-expected.txt:
  • platform/gtk/editing/pasteboard/4076267-3-expected.txt:
  • platform/gtk/editing/pasteboard/4076267-expected.txt:
  • platform/gtk/editing/pasteboard/5032095-expected.txt:
  • platform/gtk/editing/pasteboard/5071074-2-expected.txt:
  • platform/gtk/editing/pasteboard/5075944-3-expected.txt:
  • platform/gtk/editing/pasteboard/5089327-expected.txt:
  • platform/gtk/editing/pasteboard/5134759-expected.txt:
  • platform/gtk/editing/pasteboard/5156401-1-expected.txt:
  • platform/gtk/editing/pasteboard/5387578-expected.txt:
  • platform/gtk/editing/pasteboard/5483567-expected.txt:
  • platform/gtk/editing/pasteboard/7955-expected.txt:
  • platform/gtk/editing/pasteboard/cut-text-001-expected.txt:
  • platform/gtk/editing/pasteboard/drag-drop-dead-frame-expected.txt:
  • platform/gtk/editing/pasteboard/drag-drop-modifies-page-expected.txt:
  • platform/gtk/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.txt:
  • platform/gtk/editing/pasteboard/drag-selected-image-to-contenteditable-expected.txt:
  • platform/gtk/editing/pasteboard/drop-text-without-selection-expected.txt:
  • platform/gtk/editing/pasteboard/innerText-inline-table-expected.txt:
  • platform/gtk/editing/pasteboard/paste-blockquote-1-expected.txt:
  • platform/gtk/editing/pasteboard/paste-blockquote-2-expected.txt:
  • platform/gtk/editing/pasteboard/paste-blockquote-3-expected.txt:
  • platform/gtk/editing/pasteboard/paste-blockquote-after-blockquote-expected.txt:
  • platform/gtk/editing/pasteboard/paste-blockquote-into-blockquote-2-expected.txt:
  • platform/gtk/editing/pasteboard/paste-blockquote-into-blockquote-3-expected.txt:
  • platform/gtk/editing/pasteboard/paste-blockquote-into-blockquote-4-expected.txt:
  • platform/gtk/editing/pasteboard/paste-blockquote-into-blockquote-expected.txt:
  • platform/gtk/editing/pasteboard/paste-table-001-expected.txt:
  • platform/gtk/editing/pasteboard/paste-text-001-expected.txt:
  • platform/gtk/editing/pasteboard/paste-text-002-expected.txt:
  • platform/gtk/editing/pasteboard/paste-text-003-expected.txt:
  • platform/gtk/editing/pasteboard/paste-text-004-expected.txt:
  • platform/gtk/editing/pasteboard/paste-text-005-expected.txt:
  • platform/gtk/editing/pasteboard/paste-text-006-expected.txt:
  • platform/gtk/editing/pasteboard/paste-text-007-expected.txt:
  • platform/gtk/editing/pasteboard/paste-text-008-expected.txt:
  • platform/gtk/editing/pasteboard/paste-text-009-expected.txt:
  • platform/gtk/editing/pasteboard/paste-text-010-expected.txt:
  • platform/gtk/editing/pasteboard/paste-text-015-expected.txt:
  • platform/gtk/editing/pasteboard/paste-xml-expected.txt:
  • platform/gtk/editing/pasteboard/subframe-dragndrop-1-expected.txt:
  • platform/gtk/editing/selection/13804-expected.txt:
  • platform/gtk/editing/selection/4818145-expected.txt:
  • platform/gtk/editing/selection/4866671-expected.txt:
  • platform/gtk/editing/selection/4889598-expected.txt:
  • platform/gtk/editing/selection/4895428-2-expected.txt:
  • platform/gtk/editing/selection/4960116-expected.txt:
  • platform/gtk/editing/selection/4960137-expected.txt:
  • platform/gtk/editing/selection/4983858-expected.txt:
  • platform/gtk/editing/selection/5007143-2-expected.txt:
  • platform/gtk/editing/selection/5007143-expected.txt:
  • platform/gtk/editing/selection/5057506-2-expected.txt:
  • platform/gtk/editing/selection/5057506-expected.txt:
  • platform/gtk/editing/selection/5076323-1-expected.txt:
  • platform/gtk/editing/selection/5076323-2-expected.txt:
  • platform/gtk/editing/selection/5076323-3-expected.txt:
  • platform/gtk/editing/selection/5081257-1-expected.txt:
  • platform/gtk/editing/selection/5081257-2-expected.txt:
  • platform/gtk/editing/selection/5099303-expected.txt:
  • platform/gtk/editing/selection/5109817-expected.txt:
  • platform/gtk/editing/selection/5131716-1-expected.txt:
  • platform/gtk/editing/selection/5131716-2-expected.txt:
  • platform/gtk/editing/selection/5131716-3-expected.txt:
  • platform/gtk/editing/selection/5131716-4-expected.txt:
  • platform/gtk/editing/selection/5232159-expected.txt:
  • platform/gtk/editing/selection/5234383-1-expected.txt:
  • platform/gtk/editing/selection/5234383-2-expected.txt:
  • platform/gtk/editing/selection/5333725-expected.txt:
  • platform/gtk/editing/selection/addRange-expected.txt:
  • platform/gtk/editing/selection/drag-in-iframe-expected.txt:
  • platform/gtk/editing/selection/drag-select-1-expected.txt:
  • platform/gtk/editing/selection/drag-text-delay-expected.txt:
  • platform/gtk/editing/selection/drag-to-contenteditable-iframe-expected.txt:
  • platform/gtk/editing/selection/extend-by-character-002-expected.txt:
  • platform/gtk/editing/selection/extend-by-character-003-expected.txt:
  • platform/gtk/editing/selection/extend-by-character-004-expected.txt:
  • platform/gtk/editing/selection/extend-by-character-005-expected.txt:
  • platform/gtk/editing/selection/fake-drag-expected.txt:
  • platform/gtk/editing/selection/iframe-expected.txt:
  • platform/gtk/editing/selection/inline-table-expected.txt:
  • platform/gtk/editing/selection/mixed-editability-6-expected.txt:
  • platform/gtk/editing/selection/mixed-editability-7-expected.txt:
  • platform/gtk/editing/selection/move-backwords-by-word-001-expected.txt:
  • platform/gtk/editing/selection/move-between-blocks-no-001-expected.txt:
  • platform/gtk/editing/selection/move-between-blocks-yes-001-expected.txt:
  • platform/gtk/editing/selection/move-by-character-001-expected.txt:
  • platform/gtk/editing/selection/move-by-character-002-expected.txt:
  • platform/gtk/editing/selection/move-by-character-003-expected.txt:
  • platform/gtk/editing/selection/move-by-character-004-expected.txt:
  • platform/gtk/editing/selection/move-by-character-005-expected.txt:
  • platform/gtk/editing/selection/move-by-sentence-001-expected.txt:
  • platform/gtk/editing/selection/move-by-sentence-linebreak-expected.txt:
  • platform/gtk/editing/selection/move-past-trailing-space-expected.txt:
  • platform/gtk/editing/selection/range-between-block-and-inline-expected.txt:
  • platform/gtk/editing/selection/select-box-expected.txt:
  • platform/gtk/editing/selection/select-text-overflow-ellipsis-expected.txt:
  • platform/gtk/editing/selection/selectNode-expected.txt:
  • platform/gtk/editing/selection/selectNodeContents-expected.txt:
  • platform/gtk/editing/selection/selection-actions-expected.txt:
  • platform/gtk/editing/selection/wrapped-line-caret-1-expected.txt:
  • platform/gtk/editing/selection/wrapped-line-caret-2-expected.txt:
  • platform/gtk/editing/spelling/spelling-expected.txt:
  • platform/gtk/editing/spelling/spelling-linebreak-expected.txt:
  • platform/gtk/editing/style/4916887-expected.txt:
  • platform/gtk/editing/style/5017613-1-expected.txt:
  • platform/gtk/editing/style/5017613-2-expected.txt:
  • platform/gtk/editing/style/5046875-1-expected.txt:
  • platform/gtk/editing/style/5046875-2-expected.txt:
  • platform/gtk/editing/style/5084241-expected.txt:
  • platform/gtk/editing/style/5228141-expected.txt:
  • platform/gtk/editing/style/5279521-expected.txt:
  • platform/gtk/editing/style/block-style-003-expected.txt:
  • platform/gtk/editing/style/highlight-expected.txt:
  • platform/gtk/editing/style/relative-font-size-change-001-expected.txt:
  • platform/gtk/editing/style/style-3681552-fix-001-expected.txt:
  • platform/gtk/editing/style/style-3681552-fix-002-expected.txt:
  • platform/gtk/editing/style/typing-style-001-expected.txt:
  • platform/gtk/editing/style/typing-style-002-expected.txt:
  • platform/gtk/editing/style/unbold-in-bold-expected.txt:
  • platform/gtk/editing/undo/4063751-expected.txt:
  • platform/gtk/editing/undo/5378473-expected.txt:
  • platform/gtk/editing/undo/redo-typing-001-expected.txt:
  • platform/gtk/editing/undo/undo-combined-delete-boundary-expected.txt:
  • platform/gtk/editing/undo/undo-combined-delete-expected.txt:
  • platform/gtk/editing/undo/undo-delete-boundary-expected.txt:
  • platform/gtk/editing/undo/undo-delete-expected.txt:
  • platform/gtk/editing/undo/undo-forward-delete-boundary-expected.txt:
  • platform/gtk/editing/undo/undo-forward-delete-expected.txt:
  • platform/gtk/editing/undo/undo-misspellings-expected.txt:
  • platform/gtk/fast/backgrounds/001-expected.txt:
  • platform/gtk/fast/backgrounds/animated-gif-as-background-expected.txt:
  • platform/gtk/fast/backgrounds/animated-svg-as-background-expected.txt:
  • platform/gtk/fast/backgrounds/background-inherit-color-bug-expected.txt:
  • platform/gtk/fast/backgrounds/background-origin-root-element-expected.txt:
  • platform/gtk/fast/backgrounds/background-position-1-expected.txt:
  • platform/gtk/fast/backgrounds/background-position-rounding-expected.txt:
  • platform/gtk/fast/backgrounds/body-generated-image-propagated-to-root-expected.txt:
  • platform/gtk/fast/backgrounds/mask-composite-expected.txt:
  • platform/gtk/fast/backgrounds/opacity-on-document-element-expected.txt:
  • platform/gtk/fast/backgrounds/quirks-mode-line-box-backgrounds-expected.txt:
  • platform/gtk/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.txt:
  • platform/gtk/fast/backgrounds/repeat/negative-offset-repeat-expected.txt:
  • platform/gtk/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.txt:
  • platform/gtk/fast/backgrounds/repeat/noRepeatCorrectClip-expected.txt:
  • platform/gtk/fast/backgrounds/size/backgroundSize15-expected.txt:
  • platform/gtk/fast/backgrounds/size/backgroundSize16-expected.txt:
  • platform/gtk/fast/backgrounds/size/zero-expected.txt:
  • platform/gtk/fast/backgrounds/solid-color-context-restore-expected.txt:
  • platform/gtk/fast/backgrounds/svg-as-background-1-expected.txt:
  • platform/gtk/fast/backgrounds/svg-as-background-2-expected.txt:
  • platform/gtk/fast/backgrounds/svg-as-background-3-expected.txt:
  • platform/gtk/fast/backgrounds/svg-as-background-4-expected.txt:
  • platform/gtk/fast/backgrounds/svg-as-background-5-expected.txt:
  • platform/gtk/fast/backgrounds/svg-as-background-6-expected.txt:
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/001-expected.txt:
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/002-expected.txt:
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/003-expected.txt:
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/004-expected.txt:
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/005-expected.txt:
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/006-expected.txt:
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/010-expected.txt:
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/011-expected.txt:
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/012-expected.txt:
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/015-expected.txt:
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/016-expected.txt:
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/017-expected.txt:
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/018-expected.txt:
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/019-expected.txt:
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/020-expected.txt:
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/021-expected.txt:
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/022-expected.txt:
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/025-expected.txt:
  • platform/gtk/fast/block/positioning/absolute-positioning-no-scrollbar-expected.txt:
  • platform/gtk/fast/block/positioning/relative-positioned-inline-container-expected.txt:
  • platform/gtk/fast/borders/block-mask-overlay-image-expected.txt:
  • platform/gtk/fast/borders/border-color-inherit-expected.txt:
  • platform/gtk/fast/borders/border-fit-expected.txt:
  • platform/gtk/fast/borders/border-image-01-expected.txt:
  • platform/gtk/fast/borders/border-image-border-radius-expected.txt:
  • platform/gtk/fast/borders/border-image-rotate-transform-expected.txt:
  • platform/gtk/fast/borders/border-image-scale-transform-expected.txt:
  • platform/gtk/fast/borders/border-radius-constraints-expected.txt:
  • platform/gtk/fast/borders/border-radius-huge-assert-expected.txt:
  • platform/gtk/fast/borders/border-radius-split-inline-expected.txt:
  • platform/gtk/fast/borders/borderRadiusAllStylesAllCorners-expected.txt:
  • platform/gtk/fast/borders/borderRadiusArcs01-expected.txt:
  • platform/gtk/fast/borders/borderRadiusDashed01-expected.txt:
  • platform/gtk/fast/borders/borderRadiusDashed02-expected.txt:
  • platform/gtk/fast/borders/borderRadiusDashed03-expected.txt:
  • platform/gtk/fast/borders/borderRadiusDotted01-expected.txt:
  • platform/gtk/fast/borders/borderRadiusDotted02-expected.txt:
  • platform/gtk/fast/borders/borderRadiusDotted03-expected.txt:
  • platform/gtk/fast/borders/borderRadiusDouble01-expected.txt:
  • platform/gtk/fast/borders/borderRadiusDouble02-expected.txt:
  • platform/gtk/fast/borders/borderRadiusDouble03-expected.txt:
  • platform/gtk/fast/borders/borderRadiusGroove01-expected.txt:
  • platform/gtk/fast/borders/borderRadiusGroove02-expected.txt:
  • platform/gtk/fast/borders/borderRadiusInset01-expected.txt:
  • platform/gtk/fast/borders/borderRadiusInvalidColor-expected.txt:
  • platform/gtk/fast/borders/borderRadiusOutset01-expected.txt:
  • platform/gtk/fast/borders/borderRadiusRidge01-expected.txt:
  • platform/gtk/fast/borders/borderRadiusSolid01-expected.txt:
  • platform/gtk/fast/borders/borderRadiusSolid02-expected.txt:
  • platform/gtk/fast/borders/borderRadiusSolid03-expected.txt:
  • platform/gtk/fast/borders/borderRadiusSolid04-expected.txt:
  • platform/gtk/fast/borders/different-color-borders-expected.txt:
  • platform/gtk/fast/borders/inline-mask-overlay-image-expected.txt:
  • platform/gtk/fast/borders/svg-as-border-image-2-expected.txt:
  • platform/gtk/fast/borders/svg-as-border-image-expected.txt:
  • platform/gtk/fast/box-shadow/basic-shadows-expected.txt:
  • platform/gtk/fast/box-shadow/border-radius-big-expected.txt:
  • platform/gtk/fast/box-shadow/inset-expected.txt:
  • platform/gtk/fast/box-shadow/transform-fringing-expected.txt:
  • platform/gtk/fast/canvas/setWidthResetAfterForcedRender-expected.txt:
  • platform/gtk/fast/canvas/shadow-offset-1-expected.txt:
  • platform/gtk/fast/canvas/shadow-offset-2-expected.txt:
  • platform/gtk/fast/canvas/shadow-offset-3-expected.txt:
  • platform/gtk/fast/canvas/shadow-offset-4-expected.txt:
  • platform/gtk/fast/canvas/shadow-offset-5-expected.txt:
  • platform/gtk/fast/canvas/shadow-offset-6-expected.txt:
  • platform/gtk/fast/canvas/shadow-offset-7-expected.txt:
  • platform/gtk/fast/canvas/toDataURL-alpha-expected.txt:
  • platform/gtk/fast/css-generated-content/after-duplicated-after-split-expected.txt:
  • platform/gtk/fast/css/compare-content-style-expected.txt:
  • platform/gtk/fast/css/css3-space-in-nth-and-lang-expected.txt:
  • platform/gtk/fast/css/first-letter-first-line-hover-expected.txt:
  • platform/gtk/fast/css/font-face-in-shadow-DOM-expected.txt:
  • platform/gtk/fast/css/getComputedStyle/marginComputedStyle-expected.txt:
  • platform/gtk/fast/css/inline-element-line-break-expected.txt:
  • platform/gtk/fast/css/input-search-padding-expected.txt:
  • platform/gtk/fast/css/non-standard-checkbox-size-expected.txt:
  • platform/gtk/fast/css/percent-top-relative-container-height-unspecified-expected.txt:
  • platform/gtk/fast/css/preserve-user-specified-zoom-level-on-reload-expected.txt: Added.
  • platform/gtk/fast/css/pseudo-element-line-break-expected.txt:
  • platform/gtk/fast/css/shadow-multiple-expected.txt:
  • platform/gtk/fast/css/text-input-with-webkit-border-radius-expected.txt:
  • platform/gtk/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.txt:
  • platform/gtk/fast/dom/HTMLProgressElement/progress-element-expected.txt:
  • platform/gtk/fast/dynamic/float-in-trailing-whitespace-after-last-line-break-2-expected.txt:
  • platform/gtk/fast/dynamic/window-resize-scrollbars-test-expected.txt:
  • platform/gtk/fast/dynamic/window-scrollbars-test-expected.txt:
  • platform/gtk/fast/events/event-sender-mouse-moved-expected.txt:
  • platform/gtk/fast/events/mouseout-dead-node-expected.txt:
  • platform/gtk/fast/events/standalone-image-drag-to-editable-expected.txt:
  • platform/gtk/fast/forms/box-shadow-override-expected.txt:
  • platform/gtk/fast/forms/button-style-color-expected.txt:
  • platform/gtk/fast/forms/input-text-drag-down-expected.txt:
  • platform/gtk/fast/forms/placeholder-stripped-expected.txt:
  • platform/gtk/fast/forms/range-thumb-height-percentage-expected.txt:
  • platform/gtk/fast/forms/slider-padding-expected.txt:
  • platform/gtk/fast/forms/slider-thumb-shared-style-expected.txt:
  • platform/gtk/fast/forms/slider-thumb-stylability-expected.txt:
  • platform/gtk/fast/forms/thumbslider-crash-expected.txt:
  • platform/gtk/fast/forms/thumbslider-no-parent-slider-expected.txt:
  • platform/gtk/fast/frames/001-expected.txt:
  • platform/gtk/fast/frames/contentWindow_Frame-expected.txt:
  • platform/gtk/fast/frames/contentWindow_iFrame-expected.txt:
  • platform/gtk/fast/frames/frame-element-name-expected.txt:
  • platform/gtk/fast/frames/frame-navigation-expected.txt:
  • platform/gtk/fast/frames/frame-scrolling-attribute-expected.txt:
  • platform/gtk/fast/frames/frame-src-attribute-expected.txt:
  • platform/gtk/fast/frames/frameElement-frame-expected.txt:
  • platform/gtk/fast/frames/frameElement-iframe-expected.txt:
  • platform/gtk/fast/frames/frameset-style-recalc-expected.txt:
  • platform/gtk/fast/frames/iframe-option-crash-expected.txt:
  • platform/gtk/fast/frames/iframe-scrolling-attribute-expected.txt:
  • platform/gtk/fast/frames/iframe-with-frameborder-expected.txt:
  • platform/gtk/fast/frames/inline-object-inside-frameset-expected.txt:
  • platform/gtk/fast/frames/take-focus-from-iframe-expected.txt:
  • platform/gtk/fast/frames/viewsource-attribute-expected.txt:
  • platform/gtk/fast/frames/viewsource-on-image-file-expected.txt:
  • platform/gtk/fast/gradients/radial-centered-expected.txt:
  • platform/gtk/fast/images/svg-background-partial-redraw-expected.txt:
  • platform/gtk/fast/inline/continuation-outlines-with-layers-2-expected.txt:
  • platform/gtk/fast/layers/remove-only-this-layer-update-expected.txt:
  • platform/gtk/fast/lists/drag-into-marker-expected.txt:
  • platform/gtk/fast/multicol/border-padding-pagination-expected.txt:
  • platform/gtk/fast/multicol/client-rects-expected.txt:
  • platform/gtk/fast/multicol/column-break-with-balancing-expected.txt:
  • platform/gtk/fast/multicol/column-count-with-rules-expected.txt:
  • platform/gtk/fast/multicol/column-rules-expected.txt:
  • platform/gtk/fast/multicol/column-rules-stacking-expected.txt:
  • platform/gtk/fast/multicol/columns-shorthand-parsing-expected.txt:
  • platform/gtk/fast/multicol/float-avoidance-expected.txt:
  • platform/gtk/fast/multicol/float-multicol-expected.txt:
  • platform/gtk/fast/multicol/float-paginate-complex-expected.txt:
  • platform/gtk/fast/multicol/float-paginate-expected.txt:
  • platform/gtk/fast/multicol/layers-in-multicol-expected.txt:
  • platform/gtk/fast/multicol/layers-split-across-columns-expected.txt:
  • platform/gtk/fast/multicol/margin-collapse-expected.txt:
  • platform/gtk/fast/multicol/max-height-columns-block-expected.txt:
  • platform/gtk/fast/multicol/nested-columns-expected.txt:
  • platform/gtk/fast/multicol/paginate-block-replaced-expected.txt:
  • platform/gtk/fast/multicol/positioned-split-expected.txt:
  • platform/gtk/fast/multicol/positioned-with-constrained-height-expected.txt:
  • platform/gtk/fast/multicol/shadow-breaking-expected.txt:
  • platform/gtk/fast/multicol/single-line-expected.txt:
  • platform/gtk/fast/multicol/span/anonymous-style-inheritance-expected.txt:
  • platform/gtk/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.txt:
  • platform/gtk/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt:
  • platform/gtk/fast/multicol/span/span-as-immediate-child-property-removal-expected.txt:
  • platform/gtk/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.txt:
  • platform/gtk/fast/multicol/span/span-as-immediate-columns-child-expected.txt:
  • platform/gtk/fast/multicol/span/span-as-immediate-columns-child-removal-expected.txt:
  • platform/gtk/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.txt:
  • platform/gtk/fast/multicol/span/span-as-nested-columns-child-expected.txt:
  • platform/gtk/fast/multicol/span/span-margin-collapsing-expected.txt:
  • platform/gtk/fast/multicol/table-margin-collapse-expected.txt:
  • platform/gtk/fast/multicol/table-vertical-align-expected.txt:
  • platform/gtk/fast/multicol/unsplittable-inline-block-expected.txt:
  • platform/gtk/fast/repaint/block-layout-inline-children-float-positioned-expected.txt:
  • platform/gtk/fast/repaint/block-layout-inline-children-replaced-expected.txt:
  • platform/gtk/fast/repaint/block-no-inflow-children-expected.txt:
  • platform/gtk/fast/repaint/fixed-child-move-after-scroll-expected.txt:
  • platform/gtk/fast/repaint/fixed-child-of-fixed-move-after-scroll-expected.txt:
  • platform/gtk/fast/repaint/fixed-child-of-transformed-move-after-scroll-expected.txt:
  • platform/gtk/fast/repaint/fixed-move-after-keyboard-scroll-expected.txt:
  • platform/gtk/fast/repaint/fixed-move-after-scroll-expected.txt:
  • platform/gtk/fast/repaint/inline-relative-positioned-expected.txt:
  • platform/gtk/fast/repaint/layout-state-scrolloffset-expected.txt:
  • platform/gtk/fast/repaint/layout-state-scrolloffset2-expected.txt:
  • platform/gtk/fast/repaint/layout-state-scrolloffset3-expected.txt:
  • platform/gtk/fast/repaint/multicol-repaint-expected.txt:
  • platform/gtk/fast/repaint/selection-clear-expected.txt:
  • platform/gtk/fast/repaint/selection-gap-overflow-scroll-2-expected.txt:
  • platform/gtk/fast/repaint/stacked-diacritics-expected.txt:
  • platform/gtk/fast/table/early-table-layout-expected.txt:
  • platform/gtk/fast/table/fixed-table-with-percent-inside-percent-table-expected.txt:
  • platform/gtk/fast/table/fixed-table-with-percent-width-inside-auto-table-expected.txt:
  • platform/gtk/fast/table/fixed-table-with-percent-width-inside-div-expected.txt:
  • platform/gtk/fast/table/fixed-table-with-percent-width-inside-extra-large-div-expected.txt:
  • platform/gtk/fast/table/fixed-table-with-percent-width-inside-fixed-width-table-expected.txt:
  • platform/gtk/fast/table/fixed-table-with-small-percent-width-expected.txt:
  • platform/gtk/fast/text/backslash-to-yen-sign-dynamic-expected.txt:
  • platform/gtk/fast/text/backslash-to-yen-sign-euc-expected.txt:
  • platform/gtk/fast/text/backslash-to-yen-sign-expected.txt:
  • platform/gtk/fast/text/format-control-expected.txt:
  • platform/gtk/fast/text/international/bidi-mirror-he-ar-expected.txt:
  • platform/gtk/fast/text/international/bold-bengali-expected.txt:
  • platform/gtk/fast/text/international/plane2-expected.txt:
  • platform/gtk/fast/text/shadow-no-blur-expected.txt:
  • platform/gtk/fast/text/shadow-translucent-fill-expected.txt:
  • platform/gtk/fast/text/stroking-expected.txt:
  • platform/gtk/http/tests/misc/slow-loading-image-in-pattern-expected.txt:
  • platform/gtk/mathml/presentation/attributes-expected.txt:
  • platform/gtk/mathml/presentation/fenced-expected.txt:
  • platform/gtk/mathml/presentation/fractions-expected.txt:
  • platform/gtk/mathml/presentation/fractions-vertical-alignment-expected.txt:
  • platform/gtk/mathml/presentation/mo-expected.txt:
  • platform/gtk/mathml/presentation/over-expected.txt:
  • platform/gtk/mathml/presentation/roots-expected.txt:
  • platform/gtk/mathml/presentation/row-alignment-expected.txt:
  • platform/gtk/mathml/presentation/row-expected.txt:
  • platform/gtk/mathml/presentation/style-expected.txt:
  • platform/gtk/mathml/presentation/subsup-expected.txt:
  • platform/gtk/mathml/presentation/tokenElements-expected.txt:
  • platform/gtk/mathml/presentation/under-expected.txt:
  • platform/gtk/mathml/presentation/underover-expected.txt:
  • platform/gtk/scrollbars/basic-scrollbar-expected.txt:
  • platform/gtk/scrollbars/custom-scrollbar-with-incomplete-style-expected.txt:
  • platform/gtk/scrollbars/disabled-scrollbar-expected.txt:
  • platform/gtk/scrollbars/listbox-scrollbar-combinations-expected.txt:
  • platform/gtk/scrollbars/overflow-scrollbar-combinations-expected.txt:
  • platform/gtk/scrollbars/scrollbar-buttons-expected.txt:
  • platform/gtk/scrollbars/scrollbar-orientation-expected.txt:
  • platform/gtk/svg/batik/text/textDecoration-expected.txt:
  • platform/gtk/svg/css/composite-shadow-text-expected.txt:
  • platform/gtk/svg/css/group-with-shadow-expected.txt:
  • platform/gtk/svg/css/shadow-changes-expected.txt:
  • platform/gtk/svg/css/text-shadow-multiple-expected.txt:
  • platform/gtk/svg/custom/broken-internal-references-expected.txt:
  • platform/gtk/svg/custom/bug45331-expected.txt:
  • platform/gtk/svg/custom/clone-element-with-animated-svg-properties-expected.txt:
  • platform/gtk/svg/custom/empty-mask-expected.txt:
  • platform/gtk/svg/custom/getscreenctm-in-scrollable-div-area-expected.txt:
  • platform/gtk/svg/custom/getscreenctm-in-scrollable-div-area-nested-expected.txt:
  • platform/gtk/svg/custom/getscreenctm-in-scrollable-svg-area-expected.txt:
  • platform/gtk/svg/custom/js-update-stop-linked-gradient-expected.txt:
  • platform/gtk/svg/custom/mask-invalidation-expected.txt:
  • platform/gtk/svg/custom/mouse-move-on-svg-container-expected.txt:
  • platform/gtk/svg/custom/mouse-move-on-svg-container-standalone-expected.txt:
  • platform/gtk/svg/custom/mouse-move-on-svg-root-expected.txt:
  • platform/gtk/svg/custom/mouse-move-on-svg-root-standalone-expected.txt:
  • platform/gtk/svg/custom/pattern-incorrect-tiling-expected.txt:
  • platform/gtk/svg/custom/recursive-gradient-expected.txt:
  • platform/gtk/svg/custom/recursive-pattern-expected.txt:
  • platform/gtk/svg/custom/relative-sized-content-expected.txt:
  • platform/gtk/svg/custom/relative-sized-content-with-resources-expected.txt:
  • platform/gtk/svg/custom/relative-sized-deep-shadow-tree-content-expected.txt:
  • platform/gtk/svg/custom/relative-sized-shadow-tree-content-expected.txt:
  • platform/gtk/svg/custom/stroke-width-large-expected.txt:
  • platform/gtk/svg/custom/svg-curve-with-relative-cordinates-expected.txt:
  • platform/gtk/svg/custom/svg-fonts-without-missing-glyph-expected.txt:
  • platform/gtk/svg/custom/text-rotated-gradient-expected.txt:
  • platform/gtk/svg/custom/text-xy-updates-SVGList-expected.txt:
  • platform/gtk/svg/custom/text-zoom-expected.txt:
  • platform/gtk/svg/custom/use-font-face-crash-expected.txt:
  • platform/gtk/svg/filters/filter-on-filter-for-text-expected.txt:
  • platform/gtk/svg/filters/filter-on-tspan-expected.txt:
  • platform/gtk/svg/filters/filter-width-update-expected.txt:
  • platform/gtk/svg/foreignObject/no-crash-with-svg-content-in-html-document-expected.txt:
  • platform/gtk/svg/foreignObject/svg-document-as-direct-child-expected.txt:
  • platform/gtk/svg/foreignObject/svg-document-in-html-document-expected.txt:
  • platform/gtk/svg/foreignObject/text-tref-02-b-expected.txt:
  • platform/gtk/svg/in-html/by-reference-expected.txt: Copied from LayoutTests/platform/chromium-linux/svg/in-html/by-reference-expected.txt.
  • platform/gtk/svg/in-html/circle-expected.txt:
  • platform/gtk/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-auto-expected.txt:
  • platform/gtk/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults-expected.txt:
  • platform/gtk/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-hidden-expected.txt:
  • platform/gtk/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-scroll-expected.txt:
  • platform/gtk/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-visible-expected.txt:
  • platform/gtk/svg/repaint/filter-repaint-expected.txt:
  • platform/gtk/svg/text/foreignObject-text-clipping-bug-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacing-squeeze-1-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacing-squeeze-2-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacing-squeeze-3-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacing-squeeze-4-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacing-stretch-1-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacing-stretch-2-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacing-stretch-3-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacing-stretch-4-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-squeeze-1-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-squeeze-2-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-squeeze-3-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-squeeze-4-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-stretch-1-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-stretch-2-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-stretch-3-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.txt:
  • platform/gtk/svg/text/select-x-list-1-expected.txt:
  • platform/gtk/svg/text/select-x-list-2-expected.txt:
  • platform/gtk/svg/text/select-x-list-3-expected.txt:
  • platform/gtk/svg/text/select-x-list-4-expected.txt:
  • platform/gtk/svg/text/select-x-list-with-tspans-1-expected.txt:
  • platform/gtk/svg/text/select-x-list-with-tspans-2-expected.txt:
  • platform/gtk/svg/text/select-x-list-with-tspans-3-expected.txt:
  • platform/gtk/svg/text/select-x-list-with-tspans-4-expected.txt:
  • platform/gtk/svg/text/selection-background-color-expected.txt:
  • platform/gtk/svg/text/selection-doubleclick-expected.txt:
  • platform/gtk/svg/text/selection-styles-expected.txt:
  • platform/gtk/svg/text/selection-tripleclick-expected.txt:
  • platform/gtk/svg/zoom/page/zoom-foreignObject-expected.txt:
  • platform/gtk/svg/zoom/page/zoom-hixie-mixed-008-expected.txt:
  • platform/gtk/svg/zoom/page/zoom-hixie-mixed-009-expected.txt:
  • platform/gtk/svg/zoom/page/zoom-hixie-rendering-model-004-expected.txt:
  • platform/gtk/svg/zoom/page/zoom-svg-float-border-padding-expected.txt:
  • platform/gtk/svg/zoom/text/zoom-foreignObject-expected.txt:
  • platform/gtk/svg/zoom/text/zoom-hixie-mixed-008-expected.txt:
  • platform/gtk/svg/zoom/text/zoom-hixie-rendering-model-004-expected.txt:
  • platform/gtk/svg/zoom/text/zoom-svg-float-border-padding-expected.txt:
  • platform/gtk/tables/layering/paint-test-layering-1-expected.txt:
  • platform/gtk/tables/layering/paint-test-layering-2-expected.txt:
  • platform/gtk/transforms/2d/compound-transforms-vs-containers-expected.txt:
  • platform/gtk/transforms/2d/hindi-rotated-expected.txt:
  • platform/gtk/transforms/2d/transform-borderbox-expected.txt:
  • platform/gtk/transforms/2d/transform-fixed-container-expected.txt:
  • platform/gtk/transforms/2d/transform-origin-borderbox-expected.txt:
  • platform/gtk/transforms/2d/zoom-menulist-expected.txt:
  • platform/gtk/transforms/no_transform_hit_testing-expected.txt:
  • platform/gtk/transforms/svg-vs-css-expected.txt:
  • platform/gtk/transitions/move-after-transition-expected.txt:
  • platform/gtk/transitions/svg-text-shadow-transition-expected.txt:
  • platform/gtk/transitions/transition-drt-api-expected.txt:

2010-09-19 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] Wrong font instantiated from an unknown font family
https://bugs.webkit.org/show_bug.cgi?id=36548

When FontConfig returns a match for a particular family name, ensure that
the family name matches the configured alias for the original pattern. This
should prevent selecting FontConfig fallbacks in situations where the next
font on the CSS fallback list should be used. This requires moving all FontConfig
matching logic into FontCacheFreeType and out of FontPlatformDataFreeType.
It should be there anyway.

Test: platform/gtk/fonts/font-family-fallback.html

  • platform/graphics/cairo/FontCacheFreeType.cpp: (WebCore::FontCache::platformInit): Simply call FcInit here instead of deferring to FontPlatformData. (WebCore::FontCache::getLastResortFallbackFont): The last resort font should be a fallback font or else the new FontConfig logic may result in null font data if it cannot find an appropriate match. (WebCore::getFamilyNameStringFromFontDescriptionAndFamily): Added. Helper function which converts WebCore fallback names into ones that FontConfig understands. (WebCore::isFallbackFontAllowed): Added. Helper function that allows FontConfig fallbacks to be used when generic family names are specified. (WebCore::FontCache::createFontPlatformData): Move all FontConfig matching logic here and prevent against the situation where FontConfig returns a different family name than we asked for.
  • platform/graphics/cairo/FontCustomPlatformData.cpp: Updated FontPlatformData constructor.
  • platform/graphics/cairo/FontPlatformDataFreeType.cpp: Update the constructor to take the FcPattern returned and the original FontDescription. We no longer need the other arguments, because the selection is now done by FontCacheFreeType. (WebCore::FontPlatformData::FontPlatformData): Remove the FontConfig selection logic from this code.
  • platform/graphics/cairo/FontPlatformDataFreeType.h: Updated method definitions.
  • platform/graphics/cairo/GlyphPageTreeNodeCairo.cpp: Fixed includes.
  • platform/graphics/cairo/PlatformRefPtrCairo.cpp: Added a PlatformRefPtr specialization for cairo_font_face_t. (WTF::refPlatformPtr): Added. (WTF::derefPlatformPtr): Added.
  • platform/graphics/cairo/PlatformRefPtrCairo.h: Updated method definitons.
  • platform/graphics/cairo/SimpleFontDataCairo.cpp: (WebCore::SimpleFontData::smallCapsFontData): Fixed FontPlatformData constructor.
10:53 AM Changeset in webkit [68405] by Philippe Normand
  • 4 edits in trunk

2010-09-27 Philippe Normand <pnormand@igalia.com>

Reviewed by Martin Robinson.

[GTK] use ENABLE(GLIB_SUPPORT)
https://bugs.webkit.org/show_bug.cgi?id=46630

Enabling GLIB_SUPPORT on all ports that use GLib to simplify
checks.

  • GNUmakefile.am: Enabled the GLIB_SUPPORT define.

JavaScriptCore:

Reviewed by Martin Robinson.

[GTK] use ENABLE(GLIB_SUPPORT)
https://bugs.webkit.org/show_bug.cgi?id=46630

  • wtf/Platform.h: Include GTypedefs.h only if glib support is explicitly enabled.
10:50 AM Changeset in webkit [68404] by Philippe Normand
  • 6 edits in trunk

2010-09-27 Philippe Normand <pnormand@igalia.com>

Reviewed by Martin Robinson.

[GTK] Doesn't build with gtk+ 2.14
https://bugs.webkit.org/show_bug.cgi?id=46565

Fixed the build for GTK+ 2.14 by adding backward compatible
a backward-compatible function for gtk_menu_item_get_label and a
utility function to create a blank mouse cursor. Those functions
are used in the fullscreen video controller and in the DRT
EventSender.

  • platform/gtk/GtkVersioning.c: (gdk_window_get_root_coords): (blankCursor): (gtk_menu_item_get_label):
  • platform/gtk/GtkVersioning.h:

WebKit/gtk:

Reviewed by Martin Robinson.

[GTK] Doesn't build with gtk+ 2.14
https://bugs.webkit.org/show_bug.cgi?id=46565

Fixed the build for GTK+ 2.14. Don't use gdk_window_get_cursor()
for that GTK+ version as I found no acceptable way to work-around
its absence.

  • WebCoreSupport/FullscreenVideoController.cpp: (FullscreenVideoController::showHud): (FullscreenVideoController::hideHud): (FullscreenVideoController::enterFullscreen):
10:50 AM Changeset in webkit [68403] by mrobinson@webkit.org
  • 4 edits
    3 adds
    1 delete in trunk/WebKitTools

2010-09-18 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] Clean up the DRT fonts.conf and switch to Liberation
https://bugs.webkit.org/show_bug.cgi?id=46038

Switch to Liberation fonts for GTK+ layout tests. This will make our
test results metric-compatible with many Windows/Chromium results. It
also simplifies the fonts.conf that we load and prepares the way for
fixing many font bugs.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (initializeFonts): Initialize a known list of fonts instead of loading every font in the WEBKIT_TESTFONTS directory.
  • DumpRenderTree/gtk/fonts.conf: Removed.
  • DumpRenderTree/gtk/fonts/AHEM.TTF: Copied from WebKitTools/DumpRenderTree/qt/fonts/AHEM.TTF.
  • DumpRenderTree/gtk/fonts/fonts.conf: Added.
  • GNUmakefile.am: Modify FONTS_CONF_FILE to be FONTS_CONF_DIR, so that we can load both fonts.conf and AHEM.TTF from this location.
  • Scripts/old-run-webkit-tests: Remove the check for WEBKIT_TESTFONTS, since it is no longer used.
10:44 AM Changeset in webkit [68402] by senorblanco@chromium.org
  • 4 edits in trunk/WebCore

2010-09-23 Stephen White <senorblanco@chromium.org>

Reviewed by James Robinson.

[CHROMIUM] Fix for canvas clearRect() with clipping active, when
--enable-accelerated-2d-canvas is on.
https://bugs.webkit.org/show_bug.cgi?id=46412

Covered by layout test http://philip.html5.org/tests/canvas/suite/tests/2d.clearRect.clip.html.

  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::clearRect): Check if a clip is active during clipRect(), and force to software if so. Force a readback in this case, since clearRect() is not compatible with mixed-mode rendering.
  • platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::canvasClipApplied):
  • platform/graphics/skia/PlatformContextSkia.h: Implement accessor to check if a clip is active.
10:23 AM Changeset in webkit [68401] by zmo@google.com
  • 5 edits in trunk

2010-09-14 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

drawElements with count=0 and offset = 0 should not generate GL error or crash
https://bugs.webkit.org/show_bug.cgi?id=45769

  • html/canvas/WebGLRenderingContext.cpp: Deal with count=0 case. (WebCore::WebGLRenderingContext::validateIndexArrayConservative): (WebCore::WebGLRenderingContext::validateIndexArrayPrecise): (WebCore::WebGLRenderingContext::drawElements):

2010-09-14 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

drawElements with count=0 and offset = 0 should not generate GL error or crash
https://bugs.webkit.org/show_bug.cgi?id=45769

  • fast/canvas/webgl/draw-elements-out-of-bounds-expected.txt: Test count=0 cases.
  • fast/canvas/webgl/draw-elements-out-of-bounds.html: Ditto.
10:07 AM Changeset in webkit [68400] by zmo@google.com
  • 5 edits
    2 adds in trunk

2010-09-16 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Fold getString into getParameter and implement new queries
https://bugs.webkit.org/show_bug.cgi?id=40321

Test: fast/canvas/webgl/gl-getstring.html

  • html/canvas/WebGLRenderingContext.cpp: Merge getString enums into getParameter. (WebCore::WebGLRenderingContext::getParameter):
  • html/canvas/WebGLRenderingContext.h: Remove getString.
  • html/canvas/WebGLRenderingContext.idl: Remove getString.

2010-09-16 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Fold getString into getParameter and implement new queries
https://bugs.webkit.org/show_bug.cgi?id=40321

  • fast/canvas/webgl/gl-getstring-expected.txt: Added.
  • fast/canvas/webgl/gl-getstring.html: Added.
10:01 AM Changeset in webkit [68399] by zmo@google.com
  • 6 edits in trunk

2010-09-24 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

gl-teximage fails on chrome mac bot
https://bugs.webkit.org/show_bug.cgi?id=45332

Add support for alpha first pixel formats.

  • platform/graphics/GraphicsContext3D.cpp: (WebCore::doPacking):
  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/cg/GraphicsContext3DCG.cpp: (WebCore::GraphicsContext3D::getImageData):

2010-09-24 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

gl-teximage fails on chrome mac bot
https://bugs.webkit.org/show_bug.cgi?id=45332

  • platform/chromium/test_expectations.txt: Re-enabling gl-textimage.html with the fix.
9:55 AM Changeset in webkit [68398] by yurys@chromium.org
  • 7 edits
    2 adds in trunk/WebCore

2010-09-17 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: implement go-to-line feature
https://bugs.webkit.org/show_bug.cgi?id=45166

  • English.lproj/localizedStrings.js:
  • inspector/front-end/GoToLineDialog.js: Added. (WebInspector.GoToLineDialog): (WebInspector.GoToLineDialog.show): (WebInspector.GoToLineDialog.prototype._hide): (WebInspector.GoToLineDialog.prototype._onKeyDown): (WebInspector.GoToLineDialog.prototype._onBlur):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._registerShortcuts): (WebInspector.ScriptsPanel.prototype.jumpToPreviousSearchResult): (WebInspector.ScriptsPanel.prototype.showGoToLineDialog):
  • inspector/front-end/goToLineDialog.css: Added. (.go-to-line-dialog):
  • inspector/front-end/inspector.html:
9:52 AM Changeset in webkit [68397] by weinig@apple.com
  • 11 edits
    1 add in trunk/WebKit2

The mouseDidMoveOverElement callback in the injected bundle should include modifier info
https://bugs.webkit.org/show_bug.cgi?id=46629

Reviewed by Anders Carlsson.

  • Moves event related API enums to WKEvent.h which can be shared between both the bundle and the main API.
  • Shared/API/c/WKEvent.h: Added.
  • Shared/API/c/WKSharedAPICast.h:

(WebKit::toRef):

  • UIProcess/API/C/WKAPICast.h:
  • UIProcess/API/C/WKPage.h:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:

(WebKit::InjectedBundlePageUIClient::mouseDidMoveOverElement):

  • WebProcess/InjectedBundle/InjectedBundlePageUIClient.h:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::mouseDidMoveOverElement):

  • win/WebKit2.vcproj:
  • win/WebKit2Generated.make:
9:38 AM WebKit Team edited by skyul@company100.net
(diff)
9:20 AM Changeset in webkit [68396] by Adam Roben
  • 2 edits in trunk/WebKit2

Give mouse wheel events the right coordinates on Windows

Fixes <http://webkit.org/b/46625> <rdar://problem/8481161> Placing
mouse cursor inside a scrollable area and scrolling the mouse wheel
generally doesn't scroll the area

Reviewed by Sam Weinig.

  • Shared/win/WebEventFactory.cpp:

(WebKit::point): Renamed from positionForEvent. The old name implied
that all events used the same relative origin, which is untrue.
(WebKit::WebEventFactory::createWebMouseEvent): Changed to use point
and ::ClientToScreen explicitly rather than relying on
positionForEvent/globalPositionForEvent.
(WebKit::WebEventFactory::createWebWheelEvent): Changed to use point
and ::ScreenToClient. The old code was assuming that wheel event
points are relative to the client area, but they are in fact relative
to the screen.

9:08 AM Changeset in webkit [68395] by podivilov@chromium.org
  • 13 edits
    1 add in trunk/WebCore

2010-09-24 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: add XHR breakpoints sidebar pane to front-end
https://bugs.webkit.org/show_bug.cgi?id=46483

  • English.lproj/localizedStrings.js:
  • WebCore.gypi:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::instrumentWillSendXMLHttpRequestImpl):
  • inspector/InspectorTimelineAgent.h:
  • inspector/front-end/BreakpointManager.js: (WebInspector.BreakpointManager): (WebInspector.BreakpointManager.prototype._setBreakpointOnBackend): (WebInspector.BreakpointManager.prototype.createXHRBreakpoint): (WebInspector.BreakpointManager.prototype._xhrBreakpointRemoved): (WebInspector.Breakpoint.prototype.compareTo): (WebInspector.XHRBreakpoint): (WebInspector.XHRBreakpoint.prototype.get enabled): (WebInspector.XHRBreakpoint.prototype.set enabled): (WebInspector.XHRBreakpoint.prototype.get url): (WebInspector.XHRBreakpoint.prototype.formatLabel): (WebInspector.XHRBreakpoint.prototype.compareTo): (WebInspector.XHRBreakpoint.prototype.remove): (WebInspector.XHRBreakpoint.prototype._setOnBackend.didSet): (WebInspector.XHRBreakpoint.prototype._setOnBackend): (WebInspector.XHRBreakpoint.prototype._removeFromBackend):
  • inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.XHRBreakpointsSidebarPane): (WebInspector.XHRBreakpointsSidebarPane.prototype._showEditBreakpointDialog): (WebInspector.XHRBreakpointsSidebarPane.prototype._hideEditBreakpointDialog): (WebInspector.BreakpointItem.prototype.compareTo): (WebInspector.BreakpointItem.prototype._checkboxClicked): (WebInspector.BreakpointItem.prototype._enableChanged): (WebInspector.BreakpointItem.prototype._breakpointClicked): (WebInspector.XHRBreakpointItem):
  • inspector/front-end/CallStackSidebarPane.js: (WebInspector.CallStackSidebarPane.prototype.updateStatus.formatters.s): (WebInspector.CallStackSidebarPane.prototype.updateStatus.append): (WebInspector.CallStackSidebarPane.prototype.updateStatus):
  • inspector/front-end/DOMAgent.js: (WebInspector.DOMBreakpoint.prototype.compareTo):
  • inspector/front-end/Images/paneAddButtons.png: Added.
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype.reset):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.css: (.pane > .title > button.add): (.pane > .title > button.add:hover): (.pane > .title > button.add:active): (.pane > .body .breakpoint-condition):
  • inspector/front-end/inspector.js: (WebInspector.createXHRBreakpointsSidebarPane.breakpointAdded): (WebInspector.createXHRBreakpointsSidebarPane):
8:59 AM Changeset in webkit [68394] by pfeldman@chromium.org
  • 7 edits
    1 delete in trunk/WebCore

2010-09-27 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Merge AbstractTimelinePanel into ResourcesPanel.
https://bugs.webkit.org/show_bug.cgi?id=46612

I am refactoring resources panel and would like to merge abstract
one back in since it is not use anywhere else.

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/AbstractTimelinePanel.js: Removed.
  • inspector/front-end/ResourceCategory.js: (WebInspector.ResourceCategory): (WebInspector.ResourceCategory.prototype.toString):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel): (WebInspector.ResourcesPanel.prototype.get items): (WebInspector.ResourcesPanel.prototype.createInterface): (WebInspector.ResourcesPanel.prototype.createFilterPanel.createFilterElement): (WebInspector.ResourcesPanel.prototype.createFilterPanel): (WebInspector.ResourcesPanel.prototype.showCategory): (WebInspector.ResourcesPanel.prototype.hideCategory): (WebInspector.ResourcesPanel.prototype.filter): (WebInspector.ResourcesPanel.prototype._updateFilter): (WebInspector.ResourcesPanel.prototype._updateDividersLabelBarPosition): (WebInspector.ResourcesPanel.prototype.get needsRefresh): (WebInspector.ResourcesPanel.prototype.set needsRefresh): (WebInspector.ResourcesPanel.prototype.refreshIfNeeded): (WebInspector.ResourcesPanel.prototype.resize): (WebInspector.ResourcesPanel.prototype.invalidateAllItems): (WebInspector.ResourcesPanel.prototype.get calculator): (WebInspector.ResourcesPanel.prototype.set calculator): (WebInspector.ResourcesPanel.prototype.addItem): (WebInspector.ResourcesPanel.prototype.removeItem): (WebInspector.ResourcesPanel.prototype.refreshItem): (WebInspector.ResourcesPanel.prototype.revealAndSelectItem): (WebInspector.ResourcesPanel.prototype.sortItems): (WebInspector.ResourcesPanel.prototype.adjustScrollPosition): (WebInspector.ResourcesPanel.prototype.addEventDivider): (WebInspector.ResourcesPanel.prototype.hideEventDividers): (WebInspector.ResourcesPanel.prototype.showEventDividers): (WebInspector.ResourcesPanel.prototype.show): (WebInspector.ResourcesPanel.prototype.refresh): (WebInspector.ResourcesPanel.prototype.reset): (WebInspector.ResourcesPanel.prototype.updateGraphDividersIfNeeded): (WebInspector.ResourcesPanel.prototype.updateMainViewWidth): (WebInspector.ResourceBaseCalculator): (WebInspector.ResourceBaseCalculator.prototype.computeSummaryValues): (WebInspector.ResourceBaseCalculator.prototype.computeBarGraphPercentages): (WebInspector.ResourceBaseCalculator.prototype.computeBarGraphLabels): (WebInspector.ResourceBaseCalculator.prototype.get boundarySpan): (WebInspector.ResourceBaseCalculator.prototype.updateBoundaries): (WebInspector.ResourceBaseCalculator.prototype.reset): (WebInspector.ResourceBaseCalculator.prototype._value): (WebInspector.ResourceBaseCalculator.prototype.formatValue): (WebInspector.ResourceTimeCalculator): (WebInspector.ResourceTransferSizeCalculator):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
8:56 AM Changeset in webkit [68393] by diegohcg@webkit.org
  • 3 edits
    1 move in trunk/WebCore

2010-09-27 Ragner Magalhaes <ragner.magalhaes@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] New input style for Qt Mobile theme
https://bugs.webkit.org/show_bug.cgi?id=46461

Rename themeQtMaemo5.css to themeQtMobile.css since it is the theme for all Qt mobile platform.
Adjust new input style.

  • WebCore.pri:
  • css/themeQtMobile.css: Renamed from css/themeQtMaemo5.css (select): (select:disabled): (select:active): (select:active:disabled): (textarea): (textarea:disabled): (textarea:active):
  • platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::extraDefaultStyleSheet): Renamed themeQtMaemo5UserAgentStyleSheet to themeQtMobileUserAgentStyleSheet to match renamed file.
8:19 AM Changeset in webkit [68392] by weinig@apple.com
  • 2 edits in trunk/WebKit2

Opening links in a new window asserts while decoding decidePolicyForNewWindowAction.
<rdar://problem/8479445>
https://bugs.webkit.org/show_bug.cgi?id=46623

Reviewed by Adam Roben.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didReceiveMessage): Fix the order of decoding to
match the order of encoding. (Swapping url and mouseButton).

8:12 AM Changeset in webkit [68391] by Adam Roben
  • 6 edits in trunk/WebKit2

Stop leaking the web process's process handle on Windows

Fixes <http://webkit.org/b/46133> <rdar://problem/8455343>

Reviewed by Anders Carlsson.

  • UIProcess/Launcher/ProcessLauncher.cpp:

(WebKit::ProcessLauncher::invalidate): Call platformInvalidate.

  • UIProcess/Launcher/ProcessLauncher.h: Added platformInvalidate.
  • UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::ProcessLauncher::platformInvalidate):

  • UIProcess/Launcher/qt/ProcessLauncherQt.cpp:

(WebKit::ProcessLauncher::platformInvalidate):
Stubbed out.

  • UIProcess/Launcher/win/ProcessLauncherWin.cpp:

(WebKit::ProcessLauncher::platformInvalidate): Close the process
handle like MSDN says we should.

7:54 AM Changeset in webkit [68390] by Girish Ramakrishnan
  • 8 edits in trunk

2010-09-27 Girish Ramakrishnan <Girish Ramakrishnan>

Reviewed by Antonio Gomes.

[Qt] Enable local rendering of NPAPI plugins on Maemo6.

https://bugs.webkit.org/show_bug.cgi?id=46618

  • WebCore.pro:
  • bridge/npapi.h:
  • plugins/PluginView.cpp: (WebCore::PluginView::setValue): (WebCore::PluginView::PluginView):
  • plugins/PluginView.h:
  • plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::updatePluginWidget): (WebCore::PluginView::paint): (WebCore::PluginView::platformGetValueStatic):
  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::createPlugin):
6:59 AM Changeset in webkit [68389] by loislo@chromium.org
  • 3 edits in trunk/WebCore

2010-09-27 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: divide InspectorTimelineAgent into two parts.

We have an idea to split InspectorTimelineAgent into two parts.
The first part is an instrumentation API which can be used for DOM breakpoints too.
The other is the real Timeline agent which do a transformation of raw data into timeline data.

https://bugs.webkit.org/show_bug.cgi?id=46611

  • inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent2::TimelineRecordEntry::TimelineRecordEntry): (WebCore::InspectorTimelineAgent2::GCEvent::GCEvent): (WebCore::InspectorTimelineAgent2::InspectorTimelineAgent2): (WebCore::InspectorTimelineAgent2::~InspectorTimelineAgent2): (WebCore::InspectorTimelineAgent2::didGC): (WebCore::InspectorTimelineAgent2::addRecordToTimeline): (WebCore::InspectorTimelineAgent2::setHeapSizeStatistic): (WebCore::InspectorTimelineAgent2::startNewRecord): (WebCore::InspectorTimelineAgent2::completeCurrentRecord): (WebCore::InspectorTimelineAgent2::asyncRecord): (WebCore::InspectorTimelineAgent2::atomicRecord): (WebCore::InspectorTimelineAgent2::getTopRecordData): (WebCore::InspectorTimelineAgent2::reset): (WebCore::InspectorTimelineAgent2::resetFrontendProxyObject): (WebCore::InspectorTimelineAgent2::pushGCEventRecords): (WebCore::InspectorTimelineAgent::InspectorTimelineAgent): (WebCore::InspectorTimelineAgent::~InspectorTimelineAgent): (WebCore::InspectorTimelineAgent::reset): (WebCore::InspectorTimelineAgent::willCallFunction): (WebCore::InspectorTimelineAgent::didCallFunction): (WebCore::InspectorTimelineAgent::willDispatchEvent): (WebCore::InspectorTimelineAgent::didDispatchEvent): (WebCore::InspectorTimelineAgent::willLayout): (WebCore::InspectorTimelineAgent::didLayout): (WebCore::InspectorTimelineAgent::willRecalculateStyle): (WebCore::InspectorTimelineAgent::didRecalculateStyle): (WebCore::InspectorTimelineAgent::willPaint): (WebCore::InspectorTimelineAgent::didPaint): (WebCore::InspectorTimelineAgent::willWriteHTML): (WebCore::InspectorTimelineAgent::didWriteHTML): (WebCore::InspectorTimelineAgent::didInstallTimer): (WebCore::InspectorTimelineAgent::didRemoveTimer): (WebCore::InspectorTimelineAgent::willFireTimer): (WebCore::InspectorTimelineAgent::didFireTimer): (WebCore::InspectorTimelineAgent::willChangeXHRReadyState): (WebCore::InspectorTimelineAgent::didChangeXHRReadyState): (WebCore::InspectorTimelineAgent::willLoadXHR): (WebCore::InspectorTimelineAgent::didLoadXHR): (WebCore::InspectorTimelineAgent::willEvaluateScript): (WebCore::InspectorTimelineAgent::didEvaluateScript): (WebCore::InspectorTimelineAgent::didScheduleResourceRequest): (WebCore::InspectorTimelineAgent::willSendResourceRequest): (WebCore::InspectorTimelineAgent::willReceiveResourceData): (WebCore::InspectorTimelineAgent::didReceiveResourceData): (WebCore::InspectorTimelineAgent::willReceiveResourceResponse): (WebCore::InspectorTimelineAgent::didReceiveResourceResponse): (WebCore::InspectorTimelineAgent::didFinishLoadingResource): (WebCore::InspectorTimelineAgent::didMarkTimeline): (WebCore::InspectorTimelineAgent::didMarkDOMContentEvent): (WebCore::InspectorTimelineAgent::didMarkLoadEvent): (WebCore::InspectorTimelineAgent::resetFrontendProxyObject):
  • inspector/InspectorTimelineAgent.h:
6:36 AM Changeset in webkit [68388] by apavlov@chromium.org
  • 6 edits
    2 adds in trunk

2010-09-27 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Sam Weinig.

Implement CSSStyleRule::setSelectorText()

This involves removing the "selectorText" "setter raises(DOMException)" clause from the IDL files,
since the setter no longer raises the exception, as per http://dev.w3.org/csswg/cssom/#dom-cssstylerule-selectortext
https://bugs.webkit.org/show_bug.cgi?id=46487

Test: fast/css/css-set-selector-text.html

WebCore:

  • css/CSSPageRule.idl:
  • css/CSSStyleRule.cpp: (WebCore::CSSStyleRule::setSelectorText):
  • css/CSSStyleRule.h:
  • css/CSSStyleRule.idl:

LayoutTests:

  • fast/css/css-set-selector-text-expected.txt: Added.
  • fast/css/css-set-selector-text.html: Added.
6:28 AM Changeset in webkit [68387] by Adam Roben
  • 3 edits in trunk/WebKit2

Don't double-free CERT_CONTEXTs when copying PlatformCertificateInfos on Windows

Fixes <http://webkit.org/b/46536> <rdar://problem/8477292> REGRESSION
(r68260): Crash in PlatformCertificateInfo::~PlatformCertificateInfo
when navigating away from Gmail

Reviewed by Sam Weinig.

  • Shared/win/PlatformCertificateInfo.cpp:

(WebKit::PlatformCertificateInfo::PlatformCertificateInfo):
(WebKit::PlatformCertificateInfo::operator=):

  • Shared/win/PlatformCertificateInfo.h:

Added a copy constructor and assigment operator to handle correctly
reffing/dereffing the CERT_CONTEXTs when copying a
PlatformCertificateInfo.

6:09 AM Changeset in webkit [68386] by caseq@chromium.org
  • 2 edits
    1 copy
    2 adds in trunk/LayoutTests

2010-09-27 Andrey Kosyakov <caseq@chromium.org>

Unreviewed. Updated chromium expectations for ifast/block/basic/016.html (mac expectations changed in r68362)

  • platform/chromium-linux/fast/block/basic/016-expected.txt: Added.
  • platform/chromium-mac/fast/block/basic/016-expected.checksum: Added.
  • platform/chromium-win/fast/block/basic/016-expected.txt:
5:55 AM Changeset in webkit [68385] by zherczeg@webkit.org
  • 5 edits in trunk/WebCore

Filter builder should be able to follow the filter object dependencies
https://bugs.webkit.org/show_bug.cgi?id=45812

Reviewed by Dirk Schulze.

To propagate the changes of a primitive object, a data structure
is needed which stores the dependent primitive objects. (Those
who use the resulting image.) This data structure is implemented
as a hash map, which contains primitive object and set of primitive
objects <key,value> pairs. The hash map is able to follow the
dynamic topology changes.

  • rendering/RenderSVGResourceFilter.cpp:

(WebCore::RenderSVGResourceFilter::buildPrimitives):

  • rendering/RenderSVGResourceFilterPrimitive.h:

(WebCore::RenderSVGResourceFilterPrimitive::renderName):
(WebCore::RenderSVGResourceFilterPrimitive::isSVGResourceFilterPrimitive):

  • svg/graphics/filters/SVGFilterBuilder.cpp:

(WebCore::SVGFilterBuilder::SVGFilterBuilder):
(WebCore::SVGFilterBuilder::appendEffectToEffectReferences):
(WebCore::SVGFilterBuilder::clearEffects):

  • svg/graphics/filters/SVGFilterBuilder.h:

(WebCore::SVGFilterBuilder::getEffectReferences):
(WebCore::SVGFilterBuilder::addBuiltinEffects):

5:31 AM Changeset in webkit [68384] by caseq@chromium.org
  • 2 edits in trunk/WebKit/win

2010-09-27 Andrey Kosyakov <caseq@chromium.org>

Unreviewed build fix (win; broken in r68371)

  • WebFrame.cpp: remove include <WebCore/ResourceHandleWin.h>
5:20 AM Changeset in webkit [68383] by caseq@chromium.org
  • 1 edit
    30 adds in trunk/LayoutTests

2010-09-27 Andrey Kosyakov <caseq@chromium.org>

Unreviewed. Added chromium expectations for SVGFEBlendElement* tests.

  • platform/chromium-linux/svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.png: Added.
4:48 AM Changeset in webkit [68382] by benjamin.poulain@nokia.com
  • 2 edits in trunk/WebKit/qt

2010-09-27 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Andreas Kling.

[Qt] tst_QWebFrame::popupFocus() randomly fail on MeeGo handset because the focus is not set on the window
https://bugs.webkit.org/show_bug.cgi?id=46617

This patch avoid the race condition by waiting for the window
to be mapped on screen before attempting any actions.

  • tests/qwebframe/tst_qwebframe.cpp:
4:45 AM Changeset in webkit [68381] by andreas.kling@nokia.com
  • 2 edits in trunk/WebCore

2010-09-27 Andreas Kling <andreas.kling@nokia.com>

Rubber-stamped by Kenneth Rohde Christiansen.

[Qt] 32-bit Flash crashes on repeated SetWindow calls
https://bugs.webkit.org/show_bug.cgi?id=46616

Re-enable PluginQuirkDontCallSetWindowMoreThanOnce for Qt on x86 Unix.

We incorrectly thought this was fixed in Flash 10, but it turns out it
was just never broken on 64-bit.

  • plugins/PluginPackage.cpp: (WebCore::PluginPackage::determineQuirks):
2:43 AM Changeset in webkit [68380] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2010-09-27 Philippe Normand <pnormand@igalia.com>

Unreviewed, unskip fixed test. See also r68126

  • platform/gtk/Skipped: Unskip media/video-controls-with-mutation-event-handler.html
2:38 AM Changeset in webkit [68379] by zecke@webkit.org
  • 2 edits in trunk/JavaScriptCore

jsc: Document the strcat opcode.

https://bugs.webkit.org/show_bug.cgi?id=46571

2:30 AM Changeset in webkit [68378] by zecke@webkit.org
  • 2 edits in trunk/JavaScriptCore

make-bytecode-docs.pl: Add a comment to the generated HTML

https://bugs.webkit.org/show_bug.cgi?id=46570

Generate an HTML Comment that this file was generated from
Interpreter.cpp with the make-bytecode-docs.pl script.

2:00 AM Changeset in webkit [68377] by andreas.kling@nokia.com
  • 2 edits in trunk/WebCore

2010-09-27 İsmail Dönmez <ismail@namtrac.org>

Reviewed by Andreas Kling.

Add PluginView::setJavaScriptPaused(bool) stub for WinCE.

  • platform/qt/TemporaryLinkStubsQt.cpp: (PluginView::setJavaScriptPaused):
1:25 AM Changeset in webkit [68376] by commit-queue@webkit.org
  • 2 edits
    1 add in trunk/LayoutTests

2010-09-27 James Kozianski <koz@chromium.org>

Reviewed by Adam Barth.

[Chromium] fast/dom/anchor-origin.html failing since r68354
https://bugs.webkit.org/show_bug.cgi?id=46597

Adding expectations needed for Chrome due to URL parsing differences
between KURL and GURL. Once a spec for URL parsing is defined we can
update these expectations to conform to it.

  • platform/chromium/fast/dom/anchor-origin-expected.txt: Added.
1:06 AM Changeset in webkit [68375] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-09-27 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Dirk Schulze.

Bug 46607 - [WML] Fix a build break when WML is enabled

Fix a build break when WML is enabled.

  • wml/WMLElement.cpp: Include HTMLParserIdioms.h (WebCore::WMLElement::parseMappedAttribute): Add additional parameter to invoke parseHTMLInteger() function.
12:04 AM Changeset in webkit [68374] by Patrick Gansterer
  • 3 edits in trunk/JavaScriptCore

2010-09-27 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Barth.

Remove WTF::stringHash functions
https://bugs.webkit.org/show_bug.cgi?id=46520

Since r68289 the stringHash functions are only wrappers around StringHasher::createHash.
So use StringHasher::createHash directly and remove stringHash.

  • wtf/StringHashFunctions.h:
  • wtf/text/StringImpl.h: (WTF::StringImpl::computeHash): Use WTF::StringHasher::createHash directly.

Sep 26, 2010:

11:24 PM Changeset in webkit [68373] by commit-queue@webkit.org
  • 4 edits
    4 adds in trunk

2010-09-26 Jenn Braithwaite <jennb@chromium.org>

Reviewed by Adam Barth.

GTK client needs updating when live iframe element is moved
between pages.
https://bugs.webkit.org/show_bug.cgi?id=46300

This test case fails on mac (see related bug 44713), which will
be fixed in a separate patch.

  • fast/frames/iframe-reparenting-adopt-node-expected.txt: Added.
  • fast/frames/iframe-reparenting-adopt-node.html: Added.
  • fast/frames/resources/iframe-reparenting-adopt-node-iframe-content.html: Added.
  • fast/frames/resources/iframe-reparenting-adopt-node-new-page.html: Added.
  • platform/mac/Skipped:

2010-09-26 Jenn Braithwaite <jennb@chromium.org>

Reviewed by Adam Barth.

GTK client needs updating when live iframe element is moved
between pages.
https://bugs.webkit.org/show_bug.cgi?id=46300

Test: fast/frames/iframe-reparenting-adopt-node.html

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::didTransferChildFrameToNewDocument): Update the webView for the frame to match the parent frame's webView.
11:11 PM Changeset in webkit [68372] by victorw@chromium.org
  • 3 edits
    2 deletes in trunk/LayoutTests

2010-09-26 Victor Wang <victorw@chromium.org>

Reviewed by Adam Barth.

Update layout test notification-replace.html to be platform independent.

This layout test fails on windows if it is not running from C drive.
This is caused by local icon urls used by the test and this makes the
test becomes platform dependent. Change the icon urls so that the test
results are same for all platforms.

https://bugs.webkit.org/show_bug.cgi?id=45824

  • fast/notifications/notifications-replace-expected.txt:
  • fast/notifications/notifications-replace.html:
  • platform/chromium-linux/fast/notifications: Removed.
  • platform/chromium-linux/fast/notifications/notifications-replace-expected.txt: Removed.
  • platform/chromium-win/fast/notifications: Removed.
  • platform/chromium-win/fast/notifications/notifications-replace-expected.txt: Removed.
11:05 PM Changeset in webkit [68371] by Patrick Gansterer
  • 4 edits
    1 delete in trunk/WebCore

2010-09-26 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Barth.

Remove dead code and fix header includes in ResourceHandleWin
https://bugs.webkit.org/show_bug.cgi?id=46479

Also add missing member varibale from r68167.

  • platform/network/ResourceHandle.h:
  • platform/network/ResourceHandleInternal.h: (WebCore::ResourceHandleInternal::ResourceHandleInternal):
  • platform/network/win/ResourceHandleWin.cpp: (WebCore::ResourceHandleInternal::~ResourceHandleInternal): (WebCore::ResourceHandle::~ResourceHandle): (WebCore::ResourceHandle::onRequestComplete):
  • platform/network/win/ResourceHandleWin.h: Removed.
10:59 PM Changeset in webkit [68370] by andreip@google.com
  • 2 edits in trunk/LayoutTests

2010-09-26 Andrei Popescu <andreip@google.com>

Reviewed by Adam Barth.

[Chromium] storage/indexeddb/transaction-basics.html is expected to fail but actually passes.
https://bugs.webkit.org/show_bug.cgi?id=46484

  • platform/chromium/test_expectations.txt:
10:28 PM Changeset in webkit [68369] by Patrick Gansterer
  • 5 edits in trunk

2010-09-26 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Barth.

Add WTF::StringHasher::createBlobHash
https://bugs.webkit.org/show_bug.cgi?id=46514

Add this function for hashing FormElementKey and QualifiedNameComponents.

  • wtf/StringHashFunctions.h: (WTF::StringHasher::createBlobHash):

2010-09-26 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Barth.

Add WTF::StringHasher::createBlobHash
https://bugs.webkit.org/show_bug.cgi?id=46514

Add this function for hashing FormElementKey and QualifiedNameComponents.

  • dom/Document.cpp: (WebCore::FormElementKeyHash::hash):
  • dom/QualifiedName.h: (WebCore::hashComponents): (WebCore::QualifiedNameHash::hash):
10:09 PM Changeset in webkit [68368] by Patrick Gansterer
  • 2 edits in trunk/JavaScriptCore

2010-09-26 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Barth.

REGRESSION (r68289): Assertion failure in StringHasher::addCharacter() (ch != invalidCharacterValue)
running websocket/tests/bad-sub-protocol-non-ascii.html
https://bugs.webkit.org/show_bug.cgi?id=46553

Because we use StringHasher for binary data too, so the check for invalid unicode input is wrong.
Add an additional member variable to indicate if we have an pending character
instead of only using an invalid character for this purpose.

  • wtf/StringHashFunctions.h: (WTF::StringHasher::StringHasher): (WTF::StringHasher::addCharacters): (WTF::StringHasher::addCharacter): (WTF::StringHasher::hash):
9:56 PM Changeset in webkit [68367] by mihaip@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-09-26 Mihai Parparita <mihaip@chromium.org>

Reviewed by Adam Barth.

[Chromium] Remove no longer used WebView member functions
https://bugs.webkit.org/show_bug.cgi?id=46515

With http://crrev.com/60526 there's no longer any Chromium code calling
the non-static versions of addUserScript and addUserStyleSheet.

  • public/WebView.h:
9:35 PM Changeset in webkit [68366] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

2010-09-26 Shane Stephens <shanestephens@google.com>

Reviewed by Adam Barth.

[Chromium] Test expectations update to green canary bots.
https://bugs.webkit.org/show_bug.cgi?id=46604

https://bugs.webkit.org/show_bug.cgi?id=46596 and
https://bugs.webkit.org/show_bug.cgi?id=46597

  • platform/chromium/test_expectations.txt:
7:58 PM Changeset in webkit [68365] by mihaip@chromium.org
  • 3 edits in trunk/WebKitTools

2010-09-26 Mihai Parparita <mihaip@chromium.org>

Reviewed by Ojan Vafai.

new-run-webkit-httpd fails if Perl is not installed
https://bugs.webkit.org/show_bug.cgi?id=46602

Make Port._read_configuration catch all exceptions, since trying to run
perl (because of _webkit_build_directory) when it's not installed throws
a WindowsError or OSError, not an IOError (this became an issue after
r68268, since ChromiumPort ends up calling Port.default_configuration in
its constructor, which means that we're ending up on this codepath in
non-NRWT cases too, e.g. for the Chromium NaCl tests, which use
new-run-webkit-httpd).

  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/base_unittest.py:
7:53 PM Changeset in webkit [68364] by weinig@apple.com
  • 3 edits in trunk/WebKit2

MiniBrowser crashes when opening main menu item
https://bugs.webkit.org/show_bug.cgi?id=46588

Reviewed by Simon Fraser.

  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::setEditCommandState): Don't allow default
String -> NSString conversion to take place, and use the increasingly
misnamed nsStringFromWebCoreString instead.

7:43 PM Changeset in webkit [68363] by commit-queue@webkit.org
  • 5 edits in trunk

2010-09-26 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Antonio Gomes.

[EFL] Add setting API to set a local storage database path.
https://bugs.webkit.org/show_bug.cgi?id=45446

Add a setting API to set local storage database path.

  • ewk/ewk_view.cpp: (_ewk_view_priv_new): (_ewk_view_priv_del): (ewk_view_setting_local_storage_database_path_get): Added. (ewk_view_setting_local_storage_database_path_set): Added.
  • ewk/ewk_view.h:

2010-09-26 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Antonio Gomes.

[EFL] Add setting API to set a local storage database path.
https://bugs.webkit.org/show_bug.cgi?id=45446

Add a setting API to set local storage database path.

  • EWebLauncher/main.c: (on_key_down): (browserCreate): (main):
7:09 PM Changeset in webkit [68362] by hyatt@apple.com
  • 13 edits in trunk

https://bugs.webkit.org/show_bug.cgi?id=46519

Reviewed by Sam Weinig.

Convert the implementation of computeLogicalWidth to work with block-flow.

WebCore:

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::determineHorizontalPosition):
Patched to call the new computeMarginsInContainingBlockInlineDirection. Eventually determineHorizontalPosition will
be placing children along the inline direction of the containing block, and those children may have mismatched
block flows. The new computeMarginsInContainingBlockInlineDirection function is designed to handle that.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::marginStart):
(WebCore::RenderBox::marginStartUsing):
(WebCore::RenderBox::marginEnd):
(WebCore::RenderBox::marginEndUsing):
(WebCore::RenderBox::setMarginStart):
(WebCore::RenderBox::setMarginEnd):
(WebCore::RenderBox::setMarginStartUsing):
(WebCore::RenderBox::setMarginEndUsing):
Helpers that allow for marginStart/End access and that also allow for marginStart/End to be computed based off another
element's block-flow and direction (typically the containing block).

(WebCore::RenderBox::computeBorderBoxLogicalWidth):
(WebCore::RenderBox::computeBorderBoxLogicalHeight):
(WebCore::RenderBox::computeContentBoxLogicalWidth):
(WebCore::RenderBox::computeContentBoxLogicalHeight):
Patched to use logical border/padding widths and heights.

(WebCore::RenderBox::perpendicularContainingBlockLogicalHeight):
A function for returning the available logical height of a perpendicular containing block. If a child has vertical
text for example and its block-flow is "lr", its available logical width is determined by the logical
height of the containing block when that containing block is perpendicular, e.g. "tb".

(WebCore::RenderBox::computeLogicalWidth):
(WebCore::RenderBox::computeLogicalWidthUsing):
Patched to be block-flow-aware and to use logical width values everywhere.

(WebCore::RenderBox::sizesToIntrinsicLogicalWidth):
Patched to use logical widths.

(WebCore::RenderBox::computeMarginsInContainingBlockInlineDirection):
A new function that is directionally abstract and that can handle the computation of margins in the containing
block's inline direction. This function is written such that a perpendicular child block flow can still be
pushed to the center, left or right in the containing block's inline direction.

(WebCore::RenderBox::computePositionedLogicalWidth):
This function is still largely unpatched. A future patch will address positioend elements.

  • rendering/RenderBox.h:

(WebCore::RenderBox::stretchesToMinIntrinsicLogicalWidth):

  • rendering/RenderFieldset.h:

(WebCore::RenderFieldset::stretchesToMinIntrinsicLogicalWidth):
Renames.

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::computeLogicalWidth):
Renames, but not converted yet. Tables will happen in a future patch.

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::marginStartUsing):
(WebCore::RenderStyle::marginEndUsing):

  • rendering/style/RenderStyle.h:

Added helpers for accessing marginStart and End using another style's direction and block flow (typically will
be the containing block's).

fast/block/basic/016.html changed, since centering now always awards the extra pixel for odd widths to the end margin
instead of the right margin. This is a progression.

fast/css/logical-property-values.html is now reporting garbage results, which is expected now that some of the core layout
functions have been patched.

Horizontal block flows are untestable still, since the normal layout process incorrectly blows away any computed height values.

LayoutTests:

  • fast/css/logical-property-resolution-expected.txt:
  • platform/mac/fast/block/basic/016-expected.checksum:
  • platform/mac/fast/block/basic/016-expected.png:
  • platform/mac/fast/block/basic/016-expected.txt:
6:56 PM Changeset in webkit [68361] by weinig@apple.com
  • 2 edits in trunk/WebKit2

Another windows build fix windows attempt.

  • win/WebKit2Common.vsprops:
6:47 PM Changeset in webkit [68360] by weinig@apple.com
  • 2 edits in trunk/WebKit2

Another windows build fix windows attempt.

  • win/WebKit2Generated.make:
6:34 PM Changeset in webkit [68359] by weinig@apple.com
  • 2 edits in trunk/WebKit2

Attempt to fix windows build.

  • win/WebKit2Common.vsprops:
6:31 PM Changeset in webkit [68358] by weinig@apple.com
  • 2 edits in trunk/WebKit2

Attempt to fix Qt build.

  • WebKit2.pro:
6:22 PM Changeset in webkit [68357] by weinig@apple.com
  • 19 edits
    6 copies
    33 moves
    4 adds
    2 deletes in trunk

Move shared WebKit2 API (used by both bundle and main API) to WebKit2/Shared/API
https://bugs.webkit.org/show_bug.cgi?id=46587

Reviewed by Anders Carlsson.

WebKit2:

  • Moves shared types (WKArrayRef, WKDictionaryRef, etc) to Shared/API/c.
  • Removes WKBundleBase.h and moves all opaque type declarations to WKBase.h (which moves to Shared/API/c).
  • Adds WKSharedAPICast.h which includes shared API casting logic and is included by both WKAPICast.h and WKBundleAPICast.h now. Moved to using macros for API mappings to reduce verbosity.
  • Move windows c API files from UIProcess/API/win to UIProcess/API/C/win.
  • Shared/API: Added.
  • Shared/API/c: Added.
  • Shared/API/c/WKArray.cpp: Copied from UIProcess/API/C/WKArray.cpp.
  • Shared/API/c/WKArray.h: Copied from UIProcess/API/C/WKArray.h.
  • Shared/API/c/WKBase.h: Copied from UIProcess/API/C/WKBase.h.
  • Shared/API/c/WKCertificateInfo.cpp: Copied from UIProcess/API/C/WKCertificateInfo.cpp.
  • Shared/API/c/WKCertificateInfo.h: Copied from UIProcess/API/C/WKCertificateInfo.h.
  • Shared/API/c/WKData.cpp: Copied from UIProcess/API/C/WKData.cpp.
  • Shared/API/c/WKData.h: Copied from UIProcess/API/C/WKData.h.
  • Shared/API/c/WKDictionary.cpp: Copied from UIProcess/API/C/WKDictionary.cpp.
  • Shared/API/c/WKDictionary.h: Copied from UIProcess/API/C/WKDictionary.h.
  • Shared/API/c/WKError.cpp: Copied from UIProcess/API/C/WKError.cpp.
  • Shared/API/c/WKError.h: Copied from UIProcess/API/C/WKError.h.
  • Shared/API/c/WKMutableArray.cpp: Copied from UIProcess/API/C/WKMutableArray.cpp.
  • Shared/API/c/WKMutableArray.h: Copied from UIProcess/API/C/WKMutableArray.h.
  • Shared/API/c/WKMutableDictionary.cpp: Copied from UIProcess/API/C/WKMutableDictionary.cpp.
  • Shared/API/c/WKMutableDictionary.h: Copied from UIProcess/API/C/WKMutableDictionary.h.
  • Shared/API/c/WKNumber.cpp: Copied from UIProcess/API/C/WKNumber.cpp.
  • Shared/API/c/WKNumber.h: Copied from UIProcess/API/C/WKNumber.h.
  • Shared/API/c/WKSerializedScriptValue.cpp: Copied from UIProcess/API/C/WKSerializedScriptValue.cpp.
  • Shared/API/c/WKSerializedScriptValue.h: Copied from UIProcess/API/C/WKSerializedScriptValue.h.
  • Shared/API/c/WKSharedAPICast.h: Copied from UIProcess/API/C/WKAPICast.h.
  • Shared/API/c/WKString.cpp: Copied from UIProcess/API/C/WKString.cpp.
  • Shared/API/c/WKString.h: Copied from UIProcess/API/C/WKString.h.
  • Shared/API/c/WKType.cpp: Copied from UIProcess/API/C/WKType.cpp.
  • Shared/API/c/WKType.h: Copied from UIProcess/API/C/WKType.h.
  • Shared/API/c/WKURL.cpp: Copied from UIProcess/API/C/WKURL.cpp.
  • Shared/API/c/WKURL.h: Copied from UIProcess/API/C/WKURL.h.
  • Shared/API/c/WKURLRequest.cpp: Copied from UIProcess/API/C/WKURLRequest.cpp.
  • Shared/API/c/WKURLRequest.h: Copied from UIProcess/API/C/WKURLRequest.h.
  • Shared/API/c/WKURLResponse.cpp: Copied from UIProcess/API/C/WKURLResponse.cpp.
  • Shared/API/c/WKURLResponse.h: Copied from UIProcess/API/C/WKURLResponse.h.
  • Shared/API/c/cf: Copied from UIProcess/API/C/cf.
  • Shared/API/c/mac: Copied from UIProcess/API/C/mac.
  • Shared/API/c/win: Added.
  • Shared/API/c/win/WKBaseWin.h: Copied from UIProcess/API/win/WKBaseWin.h.
  • Shared/API/c/win/WKCertificateInfoWin.cpp: Copied from UIProcess/API/C/win/WKCertificateInfoWin.cpp.
  • Shared/API/c/win/WKCertificateInfoWin.h: Copied from UIProcess/API/C/win/WKCertificateInfoWin.h.
  • UIProcess/API/C/WKAPICast.h: Replaced.
  • UIProcess/API/C/WKArray.cpp: Removed.
  • UIProcess/API/C/WKArray.h: Removed.
  • UIProcess/API/C/WKBase.h: Removed.
  • UIProcess/API/C/WKCertificateInfo.cpp: Removed.
  • UIProcess/API/C/WKCertificateInfo.h: Removed.
  • UIProcess/API/C/WKData.cpp: Removed.
  • UIProcess/API/C/WKData.h: Removed.
  • UIProcess/API/C/WKDictionary.cpp: Removed.
  • UIProcess/API/C/WKDictionary.h: Removed.
  • UIProcess/API/C/WKError.cpp: Removed.
  • UIProcess/API/C/WKError.h: Removed.
  • UIProcess/API/C/WKMutableArray.cpp: Removed.
  • UIProcess/API/C/WKMutableArray.h: Removed.
  • UIProcess/API/C/WKMutableDictionary.cpp: Removed.
  • UIProcess/API/C/WKMutableDictionary.h: Removed.
  • UIProcess/API/C/WKNumber.cpp: Removed.
  • UIProcess/API/C/WKNumber.h: Removed.
  • UIProcess/API/C/WKSerializedScriptValue.cpp: Removed.
  • UIProcess/API/C/WKSerializedScriptValue.h: Removed.
  • UIProcess/API/C/WKString.cpp: Removed.
  • UIProcess/API/C/WKString.h: Removed.
  • UIProcess/API/C/WKType.cpp: Removed.
  • UIProcess/API/C/WKType.h: Removed.
  • UIProcess/API/C/WKURL.cpp: Removed.
  • UIProcess/API/C/WKURL.h: Removed.
  • UIProcess/API/C/WKURLRequest.cpp: Removed.
  • UIProcess/API/C/WKURLRequest.h: Removed.
  • UIProcess/API/C/WKURLResponse.cpp: Removed.
  • UIProcess/API/C/WKURLResponse.h: Removed.
  • UIProcess/API/C/cf: Removed.
  • UIProcess/API/C/cf/WKStringCF.cpp: Removed.
  • UIProcess/API/C/cf/WKStringCF.h: Removed.
  • UIProcess/API/C/cf/WKURLCF.cpp: Removed.
  • UIProcess/API/C/cf/WKURLCF.h: Removed.
  • UIProcess/API/C/cf/WKURLRequestCF.cpp: Removed.
  • UIProcess/API/C/cf/WKURLRequestCF.h: Removed.
  • UIProcess/API/C/cf/WKURLResponseCF.cpp: Removed.
  • UIProcess/API/C/cf/WKURLResponseCF.h: Removed.
  • UIProcess/API/C/mac: Removed.
  • UIProcess/API/C/mac/WKCertificateInfoMac.h: Removed.
  • UIProcess/API/C/mac/WKCertificateInfoMac.mm: Removed.
  • UIProcess/API/C/mac/WKURLRequestNS.h: Removed.
  • UIProcess/API/C/mac/WKURLRequestNS.mm: Removed.
  • UIProcess/API/C/mac/WKURLResponseNS.h: Removed.
  • UIProcess/API/C/mac/WKURLResponseNS.mm: Removed.
  • UIProcess/API/C/win/WKAPICastWin.h: Copied from UIProcess/API/win/WKAPICastWin.h.
  • UIProcess/API/C/win/WKBaseWin.h: Copied from UIProcess/API/win/WKBaseWin.h.
  • UIProcess/API/C/win/WKCertificateInfoWin.cpp: Removed.
  • UIProcess/API/C/win/WKCertificateInfoWin.h: Removed.
  • UIProcess/API/C/win/WKView.cpp: Copied from UIProcess/API/win/WKView.cpp.
  • UIProcess/API/C/win/WKView.h: Copied from UIProcess/API/win/WKView.h.
  • UIProcess/API/win: Removed.
  • UIProcess/API/win/WKAPICastWin.h: Removed.
  • UIProcess/API/win/WKBaseWin.h: Removed.
  • UIProcess/API/win/WKView.cpp: Removed.
  • UIProcess/API/win/WKView.h: Removed.
  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/InjectedBundle/API/c/WKBundle.h:
  • WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:
  • WebProcess/InjectedBundle/API/c/WKBundleBase.h: Removed.
  • WebProcess/InjectedBundle/API/c/WKBundleFrame.h:
  • WebProcess/InjectedBundle/API/c/WKBundleFramePrivate.h:
  • WebProcess/InjectedBundle/API/c/WKBundleHitTestResult.h:
  • WebProcess/InjectedBundle/API/c/WKBundleInitialize.h:
  • WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.h:
  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:
  • WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
  • WebProcess/InjectedBundle/API/c/WKBundleRangeHandle.h:
  • WebProcess/InjectedBundle/API/c/WKBundleScriptWorld.h:
  • win/WebKit2.vcproj:
  • win/WebKit2Generated.make:

WebKitTools:

  • WebKitTestRunner/InjectedBundle/InjectedBundle.h:
5:23 PM Changeset in webkit [68356] by tonikitoo@webkit.org
  • 16 edits in trunk

[Mac][DRT] Implement LayoutTestController::nodesFromRect
https://bugs.webkit.org/show_bug.cgi?id=46580

Patch by Antonio Gomes <agomes@rim.comg> on 2010-09-26
Reviewed by Kenneth Christiansen.

WebCore:

Symbol files updated.

  • WebCore.exp.in: Added symbols to Document::nodesFromRect and bits of JSDocument now

needed in WebKit/mac.

  • WebCore.xcodeproj/project.pbxproj: Set both JSDocument.h and JSNodeList as private headers

now that they are referred in WebKit/mac.

WebKit/mac:

Implement nodesFromRect as a private method to access non-exposed Document
methods, similarly to computedStyleIncludingVisitedInfo.

  • WebView/WebView.mm: Added JSDocument.h and JSNodeList.h to the include list.

These headers makes it possible to:
1) Get a Document off of a JSDocument;
2) Call toJS function, defined in JSNodeList.cpp|h so we can convert RefPtr<NodeList>
gotten from Document::nodesFromRect to JS bindings.
(-[WebView _nodesFromRect:forDocument:x:y:hPadding:vPadding:ignoreClipping:]):

  • WebView/WebViewPrivate.h: Added nodesFromRect method to access methods of the

Document class not exposed to JavaScript. It works similarly to computedStyleIncludingVisitedInfo.

WebKitTools:

Implements LayoutTestController::nodesFromRect for Mac DRT, and
adding stubs for GTK+ and Windows.

  • DumpRenderTree/LayoutTestController.cpp:

(nodesFromRectCallback):
(LayoutTestController::staticFunctions):

  • DumpRenderTree/LayoutTestController.h:

(LayoutTestController::LayoutTestController::nodesFromRect):

  • DumpRenderTree/mac/LayoutTestControllerMac.mm:

(LayoutTestController::nodesFromRect):

LayoutTests:

Unskipping fast/dom/nodesFromRect-based.html on Mac, and changes it
so that it calls layoutTestController.nodesFromRect() instead of
document.nodesFromRect().

  • fast/dom/resources/nodesFromRect.js:

(check):

  • platform/mac/Skipped:
3:59 PM Changeset in webkit [68355] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2010-09-26 Adam Barth <abarth@webkit.org>

Rebaseline Qt results.

  • platform/qt/fast/dom/Window/window-properties-expected.txt:
3:22 PM Changeset in webkit [68354] by abarth@webkit.org
  • 11 edits
    4 adds in trunk

2010-09-26 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Implement location.origin and HTMLAnchorElement.origin
https://bugs.webkit.org/show_bug.cgi?id=46558

Test the origin attribute of Location and HTMLAnchorElement.

  • fast/dom/anchor-origin-expected.txt: Added.
  • fast/dom/anchor-origin.html: Added.
  • http/tests/misc/location-origin-expected.txt: Added.
  • http/tests/misc/location-origin.html: Added.

2010-09-26 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Implement location.origin and HTMLAnchorElement.origin
https://bugs.webkit.org/show_bug.cgi?id=46558

These attributes are part of my proposed URL API:
https://docs.google.com/document/edit?id=1r_VTFKApVOaNIkocrg0z-t7lZgzisTuGTXkdzAk4gLU&hl=en

Hixie thought we should implement as much of this API as makes sense on
Location and HTMLAnchorElement as well. I'm starting with the origin
attribute, because that seems like the biggest bang for the buck.

Tests: fast/dom/anchor-origin.html

http/tests/misc/location-origin.html

  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::origin):
  • html/HTMLAnchorElement.h:
  • html/HTMLAnchorElement.idl:
  • page/Location.cpp: (WebCore::Location::origin):
  • page/Location.h:
  • page/Location.idl:
3:11 PM Changeset in webkit [68353] by andersca@apple.com
  • 3 edits in trunk/WebKit2

Fix non-Mac builds.

  • Platform/SharedMemory.h:
  • Platform/mac/SharedMemoryMac.cpp:

(WebKit::SharedMemory::Handle::isNull):

2:48 PM Changeset in webkit [68352] by andersca@apple.com
  • 3 edits in trunk/WebKit2

Make it possible to encode null SharedMemory::Handle objects
https://bugs.webkit.org/show_bug.cgi?id=46585

Reviewed by Sam Weinig.

  • Platform/SharedMemory.h:

(WebKit::SharedMemory::Handle::isNull):
Add isNull.

  • Platform/mac/SharedMemoryMac.cpp:

(WebKit::SharedMemory::Handle::encode):
Remove asserts.

(WebKit::SharedMemory::create):
Bail if we see a null handle. Also work around a kernel bug where
mach_vm_map fails if the given address to map is already mapped, even if
VM_FLAG_ANYWHERE is set.

2:48 PM Changeset in webkit [68351] by andersca@apple.com
  • 2 edits
    3 adds in trunk/WebKit2

Add BackingStore class
https://bugs.webkit.org/show_bug.cgi?id=46584

Reviewed by Sam Weinig.

  • Shared/BackingStore.cpp: Added.

(WebKit::BackingStore::create):
Create a backing store backed by fastMalloc memory.

(WebKit::BackingStore::createSharable):
Create a backing store backed by shared memory.

(WebKit::BackingStore::createHandle):
Create a handle that can be sent over the wire.

(WebKit::BackingStore::resize):
Resize the backing store memory.

(WebKit::BackingStore::data):
Return the backing store data.

  • Shared/mac/BackingStoreMac.mm: Added.

(WebKit::BackingStore::createGraphicsContext):
Create a graphics context that will paint into the backing store.

(WebKit::BackingStore::paint):
Paint the backing store in a graphics context.

  • WebKit2.xcodeproj/project.pbxproj:

Add files.

2:48 PM Changeset in webkit [68350] by andersca@apple.com
  • 11 edits in trunk/WebKit2

Establish a connection between the plug-in process and the web process
https://bugs.webkit.org/show_bug.cgi?id=46583

Reviewed by Sam Weinig.

  • PluginProcess/PluginProcess.cpp:

(WebKit::PluginProcess::didReceiveMessage):
Call the auto-generated didReceivePluginProcessMessage.

  • PluginProcess/PluginProcess.h:

Add didReceivePluginProcessMessage declaration.

  • PluginProcess/PluginProcess.messages.in:

Add new "CreateWebProcessConnection" message.

  • PluginProcess/WebProcessConnection.cpp:

(WebKit::WebProcessConnection::didReceiveMessage):
(WebKit::WebProcessConnection::didReceiveSyncMessage):
(WebKit::WebProcessConnection::didClose):
(WebKit::WebProcessConnection::didReceiveInvalidMessage):
Add stubbed out member functions.

  • UIProcess/Plugins/PluginProcessManager.cpp:

(WebKit::PluginProcessManager::getPluginProcessConnection):
Ask the plug-in process proxy to create a connection.

  • UIProcess/Plugins/PluginProcessProxy.cpp:

(WebKit::PluginProcessProxy::createWebProcessConnection):
Add the WebProcessProxy and the reply encoder to the queue of pending replies.
If the process is still launching, keep track of how many pending requests we have, otherwise
just send the request.

(WebKit::PluginProcessProxy::didReceiveMessage):
Call the auto-generated didReceivePluginProcessMessage.

(WebKit::PluginProcessProxy::didFinishLaunching):
Send all pending connection requests.

(WebKit::PluginProcessProxy::didCreateWebProcessConnection):
Get the first pending reply and send it with the mach port.

  • WebKit2.xcodeproj/project.pbxproj:

Actually compile PluginProcessMessageReceiver.

  • WebProcess/Plugins/PluginProcessConnection.cpp:

(WebKit::PluginProcessConnection::PluginProcessConnection):
Create a CoreIPC connection.

(WebKit::PluginProcessConnection::didReceiveMessage):
(WebKit::PluginProcessConnection::didClose):
(WebKit::PluginProcessConnection::didReceiveInvalidMessage):
Add stubbed out member functions.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::createPlugin):
Ask the plug-in process connection manager for a connection.

2:47 PM Changeset in webkit [68349] by andersca@apple.com
  • 3 edits in trunk/WebKit2

Generated message handlers should include argument coder headers for some types
https://bugs.webkit.org/show_bug.cgi?id=46582

Reviewed by Sam Weinig.

  • Scripts/webkit2/messages.py:

When determining which headers to use when generating a message handler, consider the
argument coder headers.

  • Scripts/webkit2/messages_unittest.py:

Update test result.

2:38 PM Changeset in webkit [68348] by commit-queue@webkit.org
  • 5 edits in trunk

2010-09-26 Mark Hahnenberg <mhahnenb@gmail.com>

Reviewed by Oliver Hunt.

valueOf called in wrong order in atan2 and date constructors.
https://bugs.webkit.org/show_bug.cgi?id=26978

Fixed the bug where the arguments to atan2 were being evaluated
out of order.

  • runtime/MathObject.cpp: (JSC::mathProtoFuncATan2):

2010-09-26 Mark Hahnenberg <mhahnenb@gmail.com>

Reviewed by Oliver Hunt.

valueOf called in wrong order in atan2 and date constructors.
https://bugs.webkit.org/show_bug.cgi?id=26978

Regression test for the issue where the arguments to atan2 were
evaluated out of order.

  • fast/js/math-expected.txt:
  • fast/js/script-tests/math.js: (v.valueOf): (w.valueOf):
2:26 PM Changeset in webkit [68347] by commit-queue@webkit.org
  • 5 edits in trunk

2010-09-26 Mark Hahnenberg <mhahnenb@gmail.com>

Reviewed by Oliver Hunt.

valueOf called in wrong order in atan2 and date constructors.
https://bugs.webkit.org/show_bug.cgi?id=26978

Fixed the issue where the parameters to the Date constructor
were being evaluated to numbers more than once.

  • runtime/DateConstructor.cpp: (JSC::constructDate): (JSC::dateUTC):

2010-09-26 Mark Hahnenberg <mhahnenb@gmail.com>

Reviewed by Oliver Hunt.

valueOf called in wrong order in atan2 and date constructors.
https://bugs.webkit.org/show_bug.cgi?id=26978

Added regression test for the Date constructor issue.

  • fast/js/date-constructor-expected.txt:
  • fast/js/script-tests/date-constructor.js: (year.valueOf): (month.valueOf): (date.valueOf): (hours.valueOf): (minutes.valueOf): (seconds.valueOf): (ms.valueOf):
12:21 PM Changeset in webkit [68346] by andreas.kling@nokia.com
  • 3 edits
    3 deletes in trunk

2010-09-26 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r68343.
http://trac.webkit.org/changeset/68343
https://bugs.webkit.org/show_bug.cgi?id=46581

broke GTK+ (Requested by kling on #webkit).

  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::setFont):

2010-09-26 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r68343.
http://trac.webkit.org/changeset/68343
https://bugs.webkit.org/show_bug.cgi?id=46581

broke GTK+ (Requested by kling on #webkit).

  • fast/canvas/canvas-font-ex-units-crash-expected.txt: Removed.
  • fast/canvas/canvas-font-ex-units-crash.html: Removed.
  • fast/canvas/script-tests/canvas-font-ex-units-crash.js: Removed.
12:00 PM Changeset in webkit [68345] by tonikitoo@webkit.org
  • 9 edits in trunk

document.nodesFromRect() needs to be removed from Document.idl
https://bugs.webkit.org/show_bug.cgi?id=46492

Reviewed by Kenneth Christiansen and Andreas Kling.
Patch by Antonio Gomes <agomes@rim.com>

WebCore:

As discussed with Sam Weinig on IRC, it was decided to removed
nodesFromRect() from the Document.idl, and that way, not exposing
it to Web content.

Reason: there is no plan to make it standard at the moment, and at the
very least, the method should had been originally added with the "webkit"
prefix, which was not the case.

  • dom/Document.idl:

LayoutTests:

Skip the tests relying on document.nodesFromRect in all platform for
the moment, and adjusting the expected results tests also accordingly.

  • fast/dom/Window/window-properties-expected.txt:
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/win/Skipped:
10:45 AM Changeset in webkit [68344] by commit-queue@webkit.org
  • 4 edits
    30 adds in trunk

2010-09-26 Renata Hodovan <reni@inf.u-szeged.hu>

Reviewed by Dirk Schulze.

SVGFEBlendElement doesn't support dynamic invalidation, when attributes change.
https://bugs.webkit.org/show_bug.cgi?id=46464
Adding layout tests for feBlend dynamic changes.

  • platform/mac/svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.png: Added.
  • svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGFEBlendElement-dom-in-attr.html: Added.
  • svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr.html: Added.
  • svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr.html: Added.
  • svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop.html: Added.
  • svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop.html: Added.
  • svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop.html: Added.
  • svg/dynamic-updates/script-tests/SVGFEBlendElement-dom-in-attr.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFEBlendElement-dom-in2-attr.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFEBlendElement-dom-mode-attr.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFEBlendElement-svgdom-in-prop.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFEBlendElement-svgdom-in2-prop.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFEBlendElement-svgdom-mode-prop.js: Added. (executeTest):

2010-09-26 Renata Hodovan <reni@inf.u-szeged.hu>

Reviewed by Dirk Schulze.

SVGFEBlendElement doesn't support dynamic invalidation, when attributes change.
https://bugs.webkit.org/show_bug.cgi?id=46464

Tests: svg/dynamic-updates/SVGFEBlendElement-dom-in-attr.html

svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr.html
svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr.html
svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop.html
svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop.html
svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop.html

  • svg/SVGFEBlendElement.cpp: (WebCore::SVGFEBlendElement::svgAttributeChanged):
  • svg/SVGFEBlendElement.h:
10:39 AM Changeset in webkit [68343] by andreas.kling@nokia.com
  • 3 edits
    3 adds in trunk

2010-09-26 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Dan Bernstein.

Canvas: Crash when setting a font with size in 'ex' units
https://bugs.webkit.org/show_bug.cgi?id=46538

update() the style's font after setting the style's font description.
Needed because CSSPrimitiveValue::computeLengthDouble() later assumes
that the style's font is properly initialized (for xHeight().)

Fixes crash on IE test center's canvas-text-font-002 test.

  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::setFont):

2010-09-26 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Dan Bernstein.

Canvas: Crash when setting a font with size in 'ex' units
https://bugs.webkit.org/show_bug.cgi?id=46538

  • fast/canvas/canvas-font-ex-units-crash-expected.txt: Added.
  • fast/canvas/canvas-font-ex-units-crash.html: Added.
  • fast/canvas/script-tests/canvas-font-ex-units-crash.js: Added.
10:25 AM Changeset in webkit [68342] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-09-26 Kwang Yul Seo <skyul@company100.net>

Reviewed by Eric Seidel.

[BREWMP] Don't pass PassOwnPtr in makeAllDirectories
https://bugs.webkit.org/show_bug.cgi?id=42058

Change makeAllDirectories to take a raw FileMgr pointer
because it is not safe to pass PassOwnPtr recursively.

  • platform/brew/FileSystemBrew.cpp: (WebCore::makeAllDirectories):
6:12 AM Changeset in webkit [68341] by robert@webkit.org
  • 4 edits in trunk

2010-09-26 Robert Hogan <robert@webkit.org>

Reviewed by Andreas Kling.

[Qt] fix http/tests/uri/escaped-entity.html

Replace invalid encodings with the appropriate escaped entity.

See also http://bugreports.qt.nokia.com/browse/QTBUG-13412

https://bugs.webkit.org/show_bug.cgi?id=45245

  • platform/qt/Skipped:

2010-09-26 Robert Hogan <robert@webkit.org>

Reviewed by Andreas Kling.

[Qt] fix http/tests/uri/escaped-entity.html

Replace invalid encodings with the appropriate escaped entity.

See also http://bugreports.qt.nokia.com/browse/QTBUG-13412

https://bugs.webkit.org/show_bug.cgi?id=45245

  • platform/text/qt/TextCodecQt.cpp: (WebCore::TextCodecQt::encode):
Note: See TracTimeline for information about the timeline view.