Timeline



Oct 7, 2010:

11:36 PM Changeset in webkit [69380] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-10-07 Daniel Cheng <dcheng@chromium.org>

Reviewed by Kent Tamura.

[chromium] Fix indentation in ChromiumDataObject.h
https://bugs.webkit.org/show_bug.cgi?id=47396

Just a cleanup patch to make followup diffs smaller.

  • platform/chromium/ChromiumDataObject.h: (WebCore::ChromiumDataObject::create): (WebCore::ChromiumDataObject::copy): (WebCore::ChromiumDataObject::urlTitle): (WebCore::ChromiumDataObject::setUrlTitle): (WebCore::ChromiumDataObject::htmlBaseUrl): (WebCore::ChromiumDataObject::setHtmlBaseUrl): (WebCore::ChromiumDataObject::containsFilenames): (WebCore::ChromiumDataObject::filenames): (WebCore::ChromiumDataObject::setFilenames): (WebCore::ChromiumDataObject::fileExtension): (WebCore::ChromiumDataObject::setFileExtension): (WebCore::ChromiumDataObject::fileContentFilename): (WebCore::ChromiumDataObject::setFileContentFilename): (WebCore::ChromiumDataObject::fileContent): (WebCore::ChromiumDataObject::setFileContent):
11:08 PM Changeset in webkit [69379] by Martin Robinson
  • 3 edits in trunk/LayoutTests

2010-10-07 Martin Robinson <mrobinson@igalia.com>

Rebaseline failing GTK+ tests.

  • platform/gtk/fonts/fontconfig-synthetic-bold-expected.txt:
  • platform/gtk/fonts/fontconfig-synthetic-oblique-expected.txt:
10:47 PM Changeset in webkit [69378] by tkent@chromium.org
  • 23 edits in trunk/WebCore

2010-10-07 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

Refactor HTMLInputElement: Move valueAsDate and valueAsNumber implementations
https://bugs.webkit.org/show_bug.cgi?id=47327

Move the content of HTMLInputElement::valueAsDate(), setValueAsDate(),
valueAsNumber(), and setValueAsNumber() to InputType, and move
serialize() and serializeForDateTimeTypes() too

  • html/BaseDateAndTimeInputType.cpp: (WebCore::BaseDateAndTimeInputType::valueAsDate): (WebCore::BaseDateAndTimeInputType::setValueAsDate): (WebCore::BaseDateAndTimeInputType::valueAsNumber): (WebCore::BaseDateAndTimeInputType::setValueAsNumber): (WebCore::BaseDateAndTimeInputType::serialize):
  • html/BaseDateAndTimeInputType.h:
  • html/DateInputType.cpp: (WebCore::DateInputType::setMillisecondToDateComponents):
  • html/DateInputType.h:
  • html/DateTimeInputType.cpp: (WebCore::DateTimeInputType::setMillisecondToDateComponents):
  • html/DateTimeInputType.h:
  • html/DateTimeLocalInputType.cpp: (WebCore::DateTimeLocalInputType::valueAsDate): (WebCore::DateTimeLocalInputType::setValueAsDate): (WebCore::DateTimeLocalInputType::setMillisecondToDateComponents):
  • html/DateTimeLocalInputType.h:
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::valueAsDate): (WebCore::HTMLInputElement::setValueAsDate): (WebCore::HTMLInputElement::valueAsNumber): (WebCore::HTMLInputElement::setValueAsNumber): (WebCore::HTMLInputElement::stepUpFromRenderer):
  • html/HTMLInputElement.h:
  • html/InputType.cpp: (WebCore::InputType::valueAsDate): (WebCore::InputType::setValueAsDate): (WebCore::InputType::valueAsNumber): (WebCore::InputType::setValueAsNumber): (WebCore::InputType::serialize):
  • html/InputType.h:
  • html/MonthInputType.cpp: (WebCore::MonthInputType::valueAsDate): (WebCore::MonthInputType::setValueAsDate): (WebCore::MonthInputType::setMillisecondToDateComponents):
  • html/MonthInputType.h:
  • html/NumberInputType.cpp: (WebCore::NumberInputType::valueAsNumber): (WebCore::NumberInputType::setValueAsNumber): (WebCore::NumberInputType::serialize):
  • html/NumberInputType.h:
  • html/RangeInputType.cpp: (WebCore::RangeInputType::valueAsNumber): (WebCore::RangeInputType::setValueAsNumber): (WebCore::RangeInputType::serialize):
  • html/RangeInputType.h:
  • html/TimeInputType.cpp: (WebCore::TimeInputType::setMillisecondToDateComponents):
  • html/TimeInputType.h:
  • html/WeekInputType.cpp: (WebCore::WeekInputType::setMillisecondToDateComponents):
  • html/WeekInputType.h:
10:36 PM Changeset in webkit [69377] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

2010-10-07 Kent Tamura <tkent@chromium.org>

Unreviewed, test expectation update.

  • platform/chromium/drt_expectations.txt: Add recent failures.
9:43 PM Changeset in webkit [69376] by commit-queue@webkit.org
  • 4 edits in trunk/WebKit/efl

2010-10-07 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Antonio Gomes.

[EFL] Implement pageRect() function
https://bugs.webkit.org/show_bug.cgi?id=47395

Implement pageRect() in ChromeClientEfl using frameRect().

  • CMakeListsEfl.txt:
  • WebCoreSupport/ChromeClientEfl.cpp: (WebCore::ChromeClientEfl::pageRect):
  • ewk/ewk_private.h:
  • ewk/ewk_view.cpp: (ewk_view_page_rect_get): Added.
9:43 PM Changeset in webkit [69375] by zmo@google.com
  • 2 edits in trunk/LayoutTests

2010-10-07 Zhenyao Mo <zmo@google.com>

Unreviewerd, update DRT WebGL test expectations.

  • platform/chromium/drt_expectations.txt
9:31 PM Changeset in webkit [69374] by noam.rosenthal@nokia.com
  • 1 edit
    6 adds in trunk/WebCore

2010-10-07 No'am Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Texmap] [Qt] Texture mapper initial implementation
Texture Mapper is an implementation of accelerated compositing that doesn't require a
platform specific scenegraph library like CA or QGraphicsView. The idea is that with
time this would replace GraphicsLayerQt, and could serve as an implementation for other
platforms that don't have a scenegraph library. The first stage of this is to add all the code to trunk,
and enable it in Qt with an opt-in build flag so that it can be easily tested. Once it reaches
an adequate level of stability, we can enable it by default and eventually have it replace GraphicsLayerQt.

This change includes only the common new files and the Qt backend; Still to come: the GL backend and integration layer.

  • platform/graphics/qt/TextureMapperQt.cpp: Added.
  • platform/graphics/texmap/GraphicsLayerTextureMapper.cpp: Added.
  • platform/graphics/texmap/GraphicsLayerTextureMapper.h: Added.
  • platform/graphics/texmap/TextureMapper.h: Added.
  • platform/graphics/texmap/TextureMapperPlatformLayer.h: Added.
8:53 PM Changeset in webkit [69373] by tonikitoo@webkit.org
  • 12 edits in trunk

[Mac] [DRT] implement setSpatialNavigationEnabled
https://bugs.webkit.org/show_bug.cgi?id=47291

Patch by Antonio Gomes <agomes@rim.com> on 2010-10-07
Reviewed by Simon Fraser.

WebCore:

Added Settings::setSpatialNavigationEnabled symbols to WebKit.exp.in
so it can be used from WebKit/mac.

  • WebCore.exp.in:

WebKit/mac:

Added the needed bits to make it possible to enabled spatial navigation
for the Mac port. For now it is being only used by DRT.

  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]):
(-[WebPreferences isSpatialNavigationEnabled]):
(-[WebPreferences setSpatialNavigationEnabled:]):

  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm:

(-[WebView _preferencesChangedNotification:]):

WebKitTools:

Implemented LayoutTestController::setSpatialNavigationEnabled for Mac's DRT
so it can track regression on the existing implementation and future improvements
we are making.

  • DumpRenderTree/mac/LayoutTestControllerMac.mm:

(LayoutTestController::setSpatialNavigationEnabled):

LayoutTests:

Unskiping all spatial-navigation tests in fast/events/spatial-navigation but two
(snav-iframe-with-offscreen-focusable-element.html and snav-unit-overflow-and-scroll-in-direction.html).
These will be fixed on their own bugs.

  • platform/mac/Skipped:
8:16 PM Changeset in webkit [69372] by commit-queue@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-10-07 David Goodwin <david_goodwin@apple.com>

Reviewed by Oliver Hunt.

ARM JIT generates undefined operations due to partially uninitialized ShiftTypeAndAmount
https://bugs.webkit.org/show_bug.cgi?id=47356

  • assembler/ARMv7Assembler.h:
7:31 PM Changeset in webkit [69371] by zmo@google.com
  • 2 edits in trunk/WebKit/chromium

2010-10-07 Zhenyao Mo <zmo@google.com>

Unreviewed, roll chromium to r61902.

  • DEPS
7:03 PM Changeset in webkit [69370] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-10-07 Eric Uhrhane <ericu@chromium.org>

Reviewed by Jian Li

[V8] Add FileWriter to active DOM map
https://bugs.webkit.org/show_bug.cgi?id=47380

It's an ActiveDOMObject; it needs to be in the map.

  • bindings/scripts/CodeGeneratorV8.pm:
6:51 PM Changeset in webkit [69369] by thakis@chromium.org
  • 3 edits in trunk/WebCore

2010-10-07 Nico Weber <thakis@chromium.org>

Reviewed by James Robinson.

[chromium] Make sure to update the current graphics context when calling out to AppKit.
https://bugs.webkit.org/show_bug.cgi?id=47387

This ports r57741 to ThemeChromiumMac. It also reverts r66975, which is
now no longer necessary.

Should be covered by existing tests. The checkbox at
http://webkit.org/blog-files/3d-transforms/morphing-cubes.html should
now show up correctly.

  • platform/chromium/ThemeChromiumMac.mm: (WebCore::paintCheckbox): (WebCore::paintRadio): Create current context.
  • platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::updateContents): Remove LocalCurrentContext, it's now no longer necessary.
6:44 PM Changeset in webkit [69368] by inferno@chromium.org
  • 2 edits in trunk/LayoutTests

2010-10-07 Abhishek Arya <inferno@chromium.org>

Unreviewed.

Skipping failing test on qt because of incorrect behavior.
https://bugs.webkit.org/show_bug.cgi?id=47388

  • platform/qt/Skipped:
6:18 PM Changeset in webkit [69367] by Martin Robinson
  • 2 edits in trunk/LayoutTests

2010-10-07 Martin Robinson <mrobinson@igalia.com>

Very small reorganization of the GTK+ skipped list.

  • platform/gtk/Skipped: Moved to the formdata skipped line to the beginDragWithFiles section.
6:00 PM Changeset in webkit [69366] by Martin Robinson
  • 2 edits
    21 moves in trunk/LayoutTests

2010-10-07 Martin Robinson <mrobinson@igalia.com>

Move GTK+ specific baselines to the platform-specific directories. In my
last commit I mistakenly added these to the platform-independent locations.
Also fix another baseline which seems to differ on the bots because they
have a different version of DejaVu Serif than my machine.

  • platform/gtk/fast/blockflow/block-level-images-expected.txt: Renamed from LayoutTests/fast/blockflow/block-level-images-expected.txt.
  • platform/gtk/fast/blockflow/fieldsets-expected.txt: Renamed from LayoutTests/fast/blockflow/fieldsets-expected.txt.
  • platform/gtk/fast/blockflow/floats-in-block-layout-expected.txt: Renamed from LayoutTests/fast/blockflow/floats-in-block-layout-expected.txt.
  • platform/gtk/fast/blockflow/inline-direction-positioning-expected.txt: Renamed from LayoutTests/fast/blockflow/inline-direction-positioning-expected.txt.
  • platform/gtk/fast/blockflow/margin-collapse-expected.txt: Renamed from LayoutTests/fast/blockflow/margin-collapse-expected.txt.
  • platform/gtk/fast/blockflow/root-lr-basic-expected.txt: Renamed from LayoutTests/fast/blockflow/root-lr-basic-expected.txt.
  • platform/gtk/fast/blockflow/self-collapsing-block-expected.txt: Renamed from LayoutTests/fast/blockflow/self-collapsing-block-expected.txt.
  • platform/gtk/fast/css/first-letter-punctuation-expected.txt: Renamed from LayoutTests/fast/css/first-letter-punctuation-expected.txt.
  • platform/gtk/fast/css/font-face-opentype-expected.txt: Renamed from LayoutTests/fast/css/font-face-opentype-expected.txt.
  • platform/gtk/fast/css/rtl-to-viewport-expected.txt: Renamed from LayoutTests/fast/css/rtl-to-viewport-expected.txt.
  • platform/gtk/fast/css/transformed-mask-expected.txt: Renamed from LayoutTests/fast/css/transformed-mask-expected.txt.
  • platform/gtk/fast/fonts/fontconfig-synthetic-bold-exepcted.txt: Updated baseline.
  • platform/gtk/fast/forms/input-button-sizes-expected.txt: Renamed from LayoutTests/fast/forms/input-button-sizes-expected.txt.
  • platform/gtk/fast/forms/input-placeholder-focus-twice-expected.txt: Renamed from LayoutTests/fast/forms/input-placeholder-focus-twice-expected.txt.
  • platform/gtk/inspector/console-uncaught-exception-expected.txt: Renamed from LayoutTests/inspector/console-uncaught-exception-expected.txt.
  • platform/gtk/svg/custom/image-rescale-expected.txt: Renamed from LayoutTests/svg/custom/image-rescale-expected.txt.
  • platform/gtk/svg/custom/text-rotation-expected.txt: Renamed from LayoutTests/svg/custom/text-rotation-expected.txt.
  • platform/gtk/svg/custom/text-x-dy-lists-expected.txt: Renamed from LayoutTests/svg/custom/text-x-dy-lists-expected.txt.
  • platform/gtk/svg/custom/use-invalid-style-expected.txt: Renamed from LayoutTests/svg/custom/use-invalid-style-expected.txt.
  • platform/gtk/svg/filters/filterRes1-expected.txt: Renamed from LayoutTests/svg/filters/filterRes1-expected.txt.
  • platform/gtk/svg/filters/filterRes2-expected.txt: Renamed from LayoutTests/svg/filters/filterRes2-expected.txt.
  • platform/gtk/svg/filters/filterRes3-expected.txt: Renamed from LayoutTests/svg/filters/filterRes3-expected.txt.
5:54 PM Changeset in webkit [69365] by zmo@google.com
  • 2 edits in trunk/WebKit/chromium

2010-10-07 Zhenyao Mo <zmo@google.com>

Reviewed by Tony Chang.

Copy mesa lib into DumpRenderTree bundle in Mac
https://bugs.webkit.org/show_bug.cgi?id=47385

  • WebKit.gyp:
5:49 PM Changeset in webkit [69364] by jianli@chromium.org
  • 5 edits in trunk/LayoutTests

Unreviewed. Skip the new test in those unsupported platforms.

  • platform/gtk/Skipped:
  • platform/mac-wk2/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
5:48 PM Changeset in webkit [69363] by dpranke@chromium.org
  • 3 edits
    2 adds in trunk/WebKitTools

2010-10-07 Dirk Pranke <dpranke@chromium.org>

Reviewed by Adam Barth.

rebaseline-chromium-webkit-tests relied on the filename_to_uri()
hook in the Port infrastructure to generate URIs for the files
in its summary HTML report; however, that method is supposed to only
be used for test files (and should really be renamed), so this would
crash.

This change adds a new "path" module to the system package with a
routine called abspath_to_uri() that handles converting paths to
file: URIs independently of anything in the layout_tests package,
and changes the code to use this. At some point in the near future
the layout_tests/port/* code should use this as well.

This change also deletes a bunch of unused code and fixes some
comments in rebaseline_chromium_webkit_tests.py.

https://bugs.webkit.org/show_bug.cgi?id=47319

  • Scripts/webkitpy/common/system/path.py: Added.
  • Scripts/webkitpy/common/system/path_unittest.py: Added.
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
5:47 PM Changeset in webkit [69362] by inferno@chromium.org
  • 1 edit in trunk/LayoutTests/ChangeLog

2010-10-07 Cris Neckar <cdn@chromium.org>

Reviewed by Adam Barth.

Tests for crash when multiple objects tags with bad image content are nested as fallback content.
https://bugs.webkit.org/show_bug.cgi?id=46921

  • fast/html/object-image-nested-fallback-expected.txt: Added.
  • fast/html/object-image-nested-fallback.html: Added.
5:41 PM Changeset in webkit [69361] by jer.noble@apple.com
  • 3 edits in trunk/WebKit/mac

Fix the Leopard 64-bit build.

  • Configurations/WebKit.xcconfig: Add CoreServices.framework/Frameworks to the

framework search path.

  • WebView/WebVideoFullscreenController.mm: Explicitly import <OSStatus/Power.h>.
5:35 PM Changeset in webkit [69360] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

2010-10-07 Cris Neckar <cdn@chromium.org>

Reviewed by Adam Barth.

Postpone clearing the imageLoader when rendering certain fallback content for objects until after the attach().
https://bugs.webkit.org/show_bug.cgi?id=46921

Test: fast/html/object-image-nested-fallback.html

  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::renderFallbackContent):

2010-10-07 Cris Neckar <cdn@chromium.org>

Reviewed by Adam Barth.

Tests for crash when multiple objects tags with bad image content are nested as fallback content.
https://bugs.webkit.org/show_bug.cgi?id=46921

  • accessibility/plugin.html:
  • fast/html/object-image-nested-fallback-expected.txt: Added.
  • fast/html/object-image-nested-fallback.html: Added.
5:31 PM Changeset in webkit [69359] by Martin Robinson
  • 1 edit
    60 adds in trunk/LayoutTests

2010-10-07 Martin Robinson <mrobinson@igalia.com>

Add some GTK+ specific baselines.

  • fast/blockflow/block-level-images-expected.txt: Copied from LayoutTests/platform/mac/fast/blockflow/block-level-images-expected.txt.
  • fast/blockflow/fieldsets-expected.txt: Added.
  • fast/blockflow/floats-in-block-layout-expected.txt: Copied from LayoutTests/platform/mac/fast/blockflow/floats-in-block-layout-expected.txt.
  • fast/blockflow/inline-direction-positioning-expected.txt: Copied from LayoutTests/platform/mac/fast/blockflow/inline-direction-positioning-expected.txt.
  • fast/blockflow/margin-collapse-expected.txt: Copied from LayoutTests/platform/mac/fast/blockflow/margin-collapse-expected.txt.
  • fast/blockflow/root-lr-basic-expected.txt: Copied from LayoutTests/platform/mac/fast/blockflow/root-lr-basic-expected.txt.
  • fast/blockflow/self-collapsing-block-expected.txt: Copied from LayoutTests/platform/mac/fast/blockflow/self-collapsing-block-expected.txt.
  • fast/css/first-letter-punctuation-expected.txt: Added.
  • fast/css/font-face-opentype-expected.txt: Added.
  • fast/css/rtl-to-viewport-expected.txt: Added.
  • fast/css/transformed-mask-expected.txt: Added.
  • fast/forms/input-button-sizes-expected.txt: Added.
  • fast/forms/input-placeholder-focus-twice-expected.txt: Added.
  • inspector/console-uncaught-exception-expected.txt: Added.
  • platform/gtk/fast/blockflow/block-level-images-expected.checksum: Added.
  • platform/gtk/fast/blockflow/block-level-images-expected.png: Added.
  • platform/gtk/fast/blockflow/fieldsets-expected.checksum: Added.
  • platform/gtk/fast/blockflow/fieldsets-expected.png: Added.
  • platform/gtk/fast/blockflow/floats-in-block-layout-expected.checksum: Copied from LayoutTests/platform/mac/fast/blockflow/floats-in-block-layout-expected.checksum.
  • platform/gtk/fast/blockflow/floats-in-block-layout-expected.png: Added.
  • platform/gtk/fast/blockflow/inline-direction-positioning-expected.checksum: Copied from LayoutTests/platform/mac/fast/blockflow/inline-direction-positioning-expected.checksum.
  • platform/gtk/fast/blockflow/inline-direction-positioning-expected.png: Added.
  • platform/gtk/fast/blockflow/margin-collapse-expected.checksum: Copied from LayoutTests/platform/mac/fast/blockflow/margin-collapse-expected.checksum.
  • platform/gtk/fast/blockflow/margin-collapse-expected.png: Added.
  • platform/gtk/fast/blockflow/root-lr-basic-expected.checksum: Copied from LayoutTests/platform/mac/fast/blockflow/root-lr-basic-expected.checksum.
  • platform/gtk/fast/blockflow/root-lr-basic-expected.png: Added.
  • platform/gtk/fast/blockflow/self-collapsing-block-expected.checksum: Copied from LayoutTests/platform/mac/fast/blockflow/self-collapsing-block-expected.checksum.
  • platform/gtk/fast/blockflow/self-collapsing-block-expected.png: Added.
  • platform/gtk/fast/css/first-letter-punctuation-expected.checksum: Added.
  • platform/gtk/fast/css/first-letter-punctuation-expected.png: Added.
  • platform/gtk/fast/css/font-face-opentype-expected.checksum: Added.
  • platform/gtk/fast/css/font-face-opentype-expected.png: Added.
  • platform/gtk/fast/css/rtl-to-viewport-expected.checksum: Added.
  • platform/gtk/fast/css/rtl-to-viewport-expected.png: Added.
  • platform/gtk/fast/css/transformed-mask-expected.checksum: Added.
  • platform/gtk/fast/css/transformed-mask-expected.png: Added.
  • platform/gtk/fast/forms/input-button-sizes-expected.checksum: Added.
  • platform/gtk/fast/forms/input-button-sizes-expected.png: Added.
  • platform/gtk/fast/forms/input-placeholder-focus-twice-expected.checksum: Added.
  • platform/gtk/fast/forms/input-placeholder-focus-twice-expected.png: Added.
  • platform/gtk/svg/custom/image-rescale-expected.checksum: Copied from LayoutTests/platform/chromium-linux/svg/custom/image-rescale-expected.checksum.
  • platform/gtk/svg/custom/image-rescale-expected.png: Added.
  • platform/gtk/svg/custom/text-rotation-expected.checksum: Added.
  • platform/gtk/svg/custom/text-rotation-expected.png: Added.
  • platform/gtk/svg/custom/text-x-dy-lists-expected.checksum: Added.
  • platform/gtk/svg/custom/text-x-dy-lists-expected.png: Added.
  • platform/gtk/svg/filters/filterRes1-expected.checksum: Copied from LayoutTests/platform/chromium-win/svg/filters/filterRes1-expected.checksum.
  • platform/gtk/svg/filters/filterRes1-expected.png: Added.
  • platform/gtk/svg/filters/filterRes2-expected.checksum: Added.
  • platform/gtk/svg/filters/filterRes2-expected.png: Added.
  • platform/gtk/svg/filters/filterRes3-expected.checksum: Copied from LayoutTests/platform/chromium-win/svg/filters/filterRes3-expected.checksum.
  • platform/gtk/svg/filters/filterRes3-expected.png: Added.
  • svg/custom/image-rescale-expected.txt: Copied from LayoutTests/platform/chromium-linux/svg/custom/image-rescale-expected.txt.
  • svg/custom/text-rotation-expected.txt: Added.
  • svg/custom/text-x-dy-lists-expected.txt: Added.
  • svg/custom/use-invalid-style-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/use-invalid-style-expected.txt.
  • svg/filters/filterRes1-expected.txt: Copied from LayoutTests/platform/mac/svg/filters/filterRes1-expected.txt.
  • svg/filters/filterRes2-expected.txt: Copied from LayoutTests/platform/mac/svg/filters/filterRes2-expected.txt.
  • svg/filters/filterRes3-expected.txt: Copied from LayoutTests/platform/mac/svg/filters/filterRes3-expected.txt.
5:28 PM Changeset in webkit [69358] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-10-07 Rafael Antognolli <antognolli@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Fix shared timers on EFL port - make them thread safe.
https://bugs.webkit.org/show_bug.cgi?id=47383

Using ecore_timer_add to create a timer from a thread that is
not the main thread isn't safe. Now we add a pipe that is used
to request a timer to be added in the main thread.

In order to reduce some delay on timers that are added with a
very small interval, the timer callback is called immediately
if the interval is smaller than the mainloop frame time.

No new features, so no tests added.

  • platform/efl/SharedTimerEfl.cpp: (WebCore::setSharedTimerFiredFunction): (WebCore::timerEvent): (WebCore::processTimers): (WebCore::pipeHandlerCb): (WebCore::stopSharedTimer): (WebCore::addNewTimer): (WebCore::setSharedTimerFireTime):
5:16 PM Changeset in webkit [69357] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

2010-10-07 James Kozianski <koz@chromium.org>

Reviewed by Adam Barth.

getPropertyValue('border') is incorrect after border-top-width is set
https://bugs.webkit.org/show_bug.cgi?id=45949

CSSMutableStyleDeclaration::getCommonValue() was ignoring values from
properties that were implicitly set, which led to erroneous results
from getPropertyValue().

  • fast/dom/css-shorthand-common-value-expected.txt: Added.
  • fast/dom/css-shorthand-common-value.html: Added.

2010-10-07 James Kozianski <koz@chromium.org>

Reviewed by Adam Barth.

getPropertyValue('border') is incorrect after border-top-width is set
https://bugs.webkit.org/show_bug.cgi?id=45949

Test: fast/dom/css-shorthand-common-value.html

CSSMutableStyleDeclaration::getCommonValue() was ignoring values from
properties that were implicitly set, which led to erroneous results
from getPropertyValue().

  • css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::getCommonValue):
5:07 PM Changeset in webkit [69356] by mrowe@apple.com
  • 3 edits in trunk/WebKit2

<rdar://problem/8349882> Many WebProcess sandbox violations during basic browsing operations.

Patch by Ivan Krstić <ike@apple.com> on 2010-10-07
Reviewed by Mark Rowe.

  • WebProcess/com.apple.WebProcess.sb:
  • WebProcess/mac/WebProcessMainMac.mm:

(WebKit::WebProcessMain):

4:57 PM Changeset in webkit [69355] by Martin Robinson
  • 4 edits in trunk

2010-10-07 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] The FreeType backend does not respect the FC_EMBOLDEN property
https://bugs.webkit.org/show_bug.cgi?id=46216

Fix a baseline that was merged improperly.

  • platform/gtk/fonts/fontconfig-synthetic-bold-expected.txt: Fix baseline.

2010-10-07 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] The FreeType backend does not respect the FC_EMBOLDEN property
https://bugs.webkit.org/show_bug.cgi?id=46216

Fix my latest commit, as it contained some bad changes from a merge gone wrong.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (initializeFonts): Also initialize the DevaVu Sans font.
4:55 PM Changeset in webkit [69354] by rniwa@webkit.org
  • 9 edits
    4 adds in trunk

2010-10-07 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Tony Chang.

REGRESSION: Indenting pre duplicates content
https://bugs.webkit.org/show_bug.cgi?id=47233

The bug was caused by our not splitting text nodes properly.

In new approach, we split text nodes in each iteration. Added rangeForParagraphSplitingTextNodesIfNeeded
to split text nodes at the start and at the end of paragraph, which also adjusts start and end positions
for moveParagraphWithClones. Added endOfNextParagrahSplittingTextNodesIfNeeded to adjust endOfNextParagraph,
start, and end to work-around moveParagraphWithClones's removing a line feed.

Tests: editing/execCommand/indent-pre-list.html

editing/execCommand/indent-pre-paragraphs.html

  • editing/ApplyBlockElementCommand.cpp: (WebCore::ApplyBlockElementCommand::formatSelection): See above. (WebCore::isNewLineAtPosition): (WebCore::renderStyleOfEnclosingTextNode): Added. (WebCore::ApplyBlockElementCommand::rangeForParagraphSplittingTextNodesIfNeeded): Added. (WebCore::ApplyBlockElementCommand::endOfNextParagrahSplittingTextNodesIfNeeded): Added.
  • editing/ApplyBlockElementCommand.h:
  • editing/FormatBlockCommand.cpp: (WebCore::FormatBlockCommand::formatRange): Takes two Positions instead of one VisiblePosition.
  • editing/FormatBlockCommand.h:
  • editing/IndentOutdentCommand.cpp: (WebCore::IndentOutdentCommand::tryIndentingAsListItem): Ditto. (WebCore::IndentOutdentCommand::indentIntoBlockquote): Ditto. (WebCore::IndentOutdentCommand::formatRange): Ditto.
  • editing/IndentOutdentCommand.h:

2010-10-07 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Tony Chang.

REGRESSION: Indenting pre duplicates content
https://bugs.webkit.org/show_bug.cgi?id=47233

Added tests to ensure WebKit indents texts inside pre correctly.

  • editing/execCommand/indent-pre-expected.txt: This test passes if WebKit does not crash.
  • editing/execCommand/indent-pre-list-expected.txt: Added.
  • editing/execCommand/indent-pre-list.html: Added.
  • editing/execCommand/indent-pre-paragraphs-expected.txt: Added.
  • editing/execCommand/indent-pre-paragraphs.html: Added.
4:45 PM Changeset in webkit [69353] by ajwong@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed. Build fix.

Reflecting move of autocorrection tests made in r69351.

  • platform/chromium/test_expectations.txt:
4:38 PM Changeset in webkit [69352] by ajwong@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed. Build fix.

The breakage of r69334 fast/css/transformed-mask.svg

  • platform/chromium/test_expectations.txt:
4:32 PM Changeset in webkit [69351] by bweinstein@apple.com
  • 5 edits
    4 adds
    4 deletes in trunk/LayoutTests

Autocorrection panel regression tests fail on Windows
https://bugs.webkit.org/show_bug.cgi?id=47341
<rdar://problem/8523631>

Patch by Jia Pu <jpu@apple.com> on 2010-10-07
Reviewed by Adele Peterson.

Move Mac specific tests to platform/mac directory.

  • editing/spelling/autocorrection-delete.html: Removed.
  • editing/spelling/autocorrection-removing-underline-after-paste.html: Removed.
  • editing/spelling/autocorrection-removing-underline.html: Removed.
  • editing/spelling/autocorrection-simple.html: Removed.
  • platform/mac-leopard/Skipped:
  • platform/mac-snowleopard/Skipped:
  • platform/mac-tiger/Skipped:
  • platform/mac-wk2/Skipped:
  • platform/mac/editing/spelling/autocorrection-delete.html: Added.
  • platform/mac/editing/spelling/autocorrection-removing-underline-after-paste.html: Added.
  • platform/mac/editing/spelling/autocorrection-removing-underline.html: Added.
  • platform/mac/editing/spelling/autocorrection-simple.html: Added.
4:31 PM Changeset in webkit [69350] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed.

[Qt] http/tests/local/formdata/send-form-data-constructed-from-form.html
introduced in r69349, but eventSender.beginDragWithFiles is unimplemented.

  • platform/qt/Skipped: http/tests/local/formdata/send-form-data-constructed-from-form.html added.
3:57 PM Changeset in webkit [69349] by jianli@chromium.org
  • 7 edits
    3 adds in trunk

Support generating a FormData object based on the data in an existing <form>.
https://bugs.webkit.org/show_bug.cgi?id=45929

Reviewed by Adam Barth.

WebCore:

Test: http/tests/local/formdata/send-form-data-constructed-from-form.html

  • bindings/js/JSDOMFormDataCustom.cpp:

(WebCore::toHTMLFormElement):
(WebCore::JSDOMFormDataConstructor::constructJSDOMFormData):

  • bindings/v8/custom/V8DOMFormDataCustom.cpp:

(WebCore::V8DOMFormData::constructorCallback):

  • html/DOMFormData.cpp:

(WebCore::DOMFormData::DOMFormData):

  • html/DOMFormData.h:

(WebCore::DOMFormData::create):

  • html/DOMFormData.idl:

LayoutTests:

Add a new test to test this functionality.

  • http/tests/local/formdata/resources/test.txt: Copied from LayoutTests/fast/files/resources/UTF8.txt.
  • http/tests/local/formdata/send-form-data-constructed-from-form-expected.txt: Added.
  • http/tests/local/formdata/send-form-data-constructed-from-form.html: Added.
3:51 PM Changeset in webkit [69348] by beidson@apple.com
  • 3 edits in trunk/WebKit2

Build fix.

GCC continued to mask the fact that I still hadn't declared the correct symbol.

  • Platform/Logging.cpp:

(initializeLogChannel):

  • Platform/Logging.h:
3:36 PM Changeset in webkit [69347] by bweinstein@apple.com
  • 2 edits in trunk/WebKit2

Build Fix. Fix the vcproj to make it valid and openable by Visual Studio.

  • win/WebKit2.vcproj:
3:04 PM Changeset in webkit [69346] by commit-queue@webkit.org
  • 7 edits in trunk

2010-10-07 Daniel Cheng <dcheng@chromium.org>

Reviewed by Tony Chang.

[chromium] Minor naming cleanup in WebDragData, part 2
https://bugs.webkit.org/show_bug.cgi?id=47227

Chromium no longer uses the deprecated methods, so delete them.

  • DEPS:
  • public/WebDragData.h:
  • src/WebDragData.cpp:

2010-10-07 Daniel Cheng <dcheng@chromium.org>

Reviewed by Tony Chang.

[chromium] Minor naming cleanup in WebDragData, part 2
https://bugs.webkit.org/show_bug.cgi?id=47227

Update DRT to use the renamed methods.

  • DumpRenderTree/chromium/EventSender.cpp: (EventSender::beginDragWithFiles):
  • DumpRenderTree/chromium/WebViewHost.cpp: (addDRTFakeFileToDataObject):
3:00 PM Changeset in webkit [69345] by inferno@chromium.org
  • 4 edits
    2 adds in trunk

2010-10-07 Abhishek Arya <inferno@chromium.org>

Reviewed by Dave Hyatt.

Set the m_selectedChildren flag on the root inline box if one of the leaf
inline box from the bidi runs walk has a selection state. Remove the flag
setting logic from addToLine, since line boxes created in createLinesBoxes
should not be propagating selection state to root inline box.
https://bugs.webkit.org/show_bug.cgi?id=47201

Test: editing/selection/root-inlinebox-selected-children-crash.html

  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::addToLine):
  • rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::constructLine):

2010-10-07 Abhishek Arya <inferno@chromium.org>

Reviewed by Dave Hyatt.

Tests that we don't crash while setting selected children on the root inline box.
https://bugs.webkit.org/show_bug.cgi?id=47201

  • editing/selection/root-inlinebox-selected-children-crash-expected.txt: Added.
  • editing/selection/root-inlinebox-selected-children-crash.html: Added.
2:51 PM Changeset in webkit [69344] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-10-07 Benjamin Otte <otte@gnome.org>

Reviewed by Martin Robinson.

[GTK] Code cleanup in PluginViewGtk.cpp for transparent plugins
https://bugs.webkit.org/show_bug.cgi?id=47361

Reduce some code in PluginViewGtk.cpp by doing things with Cairo instead
of directly with X11. This should work fine with GDK double-buffering, but
if we ever disable it, we'll need to verify that this is still functioning
properly.

  • plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::paint): Do a bit of code cleanup.
2:49 PM Changeset in webkit [69343] by andersca@apple.com
  • 17 edits
    3 copies
    2 adds in trunk

Add a WKPageFindClient, hook up WKPageCountStringMatches
https://bugs.webkit.org/show_bug.cgi?id=47373

Reviewed by Sam Weinig.

WebCore:

Export find related symbols needed by WebKit2.

  • WebCore.exp.in:

WebKit2:

  • Shared/APIClient.h: Added.

Add an APIClient class template which can be used to reduce duplicated
code in the client wrappers.

  • UIProcess/API/C/WKPage.cpp:

(WKPageSetPageFindClient):
Initialize the page find client.

  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebFindClient.cpp: Added.

(WebKit::WebFindClient::didCountStringMatches):
Call the WKPageFindClient function.

  • UIProcess/WebFindClient.h: Added.
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::initializeFindClient):
Initialize the WebFindClient.

(WebKit::WebPageProxy::findString):
Send a FindString message.

(WebKit::WebPageProxy::hideFindUI):
Send a HideFindUI message.

(WebKit::WebPageProxy::countStringMatches):
Send a CountStringMatches message.

(WebKit::WebPageProxy::didCountStringMatches):
Call the find client.

  • UIProcess/WebPageProxy.messages.in:

Add new message.

  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:

Add new files.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::findString):
(WebKit::WebPage::hideFindUI):
Add stubs.

(WebKit::WebPage::countStringMatches):
Figure out the number of matches and send them back in the DidCountStringMatches msessage.

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:

Add new messages.

  • win/WebKit2.vcproj:

Add new files.

WebKitTools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:

Remove hard coded paths.

  • TestWebKitAPI/Tests/WTF/VectorBasic.cpp:

(TestWebKitAPI::TEST):
Fix expected result.

  • TestWebKitAPI/Tests/WebKit2/Find.cpp: Added.

(TestWebKitAPI::didFinishLoadForFrame):
(TestWebKitAPI::didCountStringMatches):
(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit2/find.html: Added.

Add test for WKPageCountStringMatches.

2:21 PM Changeset in webkit [69342] by ajwong@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed. Build fix.

r69334 broke Chromium rendering of fast/css/transformed-mask.svg.

  • platform/chromium/test_expectations.txt:
2:16 PM Changeset in webkit [69341] by hyatt@apple.com
  • 7 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=47370

Reviewed by Sam Weinig.

Make line box placement in the inline direction writing-mode-aware. Lines now set their y-position instead of x-position
when vertical.

Refactored shadow overflow to give text-shadow the same helpers in RenderStyle that box-shadow has so that the shadow-walking loop in
placeBoxesInInlineDirection can be replaced with the helper.

Overflow had to be patched to be writing-mode-aware so that the correct physical directions would be set for vertical line
boxes.

Vertical lines are still not testable until they can be placed in the block direction. Then the render tree dumps
become meaningful (even if the pixel results look horrible).

  • rendering/InlineBox.h:

(WebCore::InlineBox::logicalRight):

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::placeBoxesInInlineDirection):

  • rendering/InlineFlowBox.h:

(WebCore::InlineFlowBox::logicalLeftLayoutOverflow):
(WebCore::InlineFlowBox::logicalRightLayoutOverflow):
(WebCore::InlineFlowBox::logicalLeftVisualOverflow):
(WebCore::InlineFlowBox::logicalRightVisualOverflow):
(WebCore::InlineFlowBox::setInlineDirectionOverflowPositions):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::computeInlineDirectionPositionsForLine):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::getShadowExtent):
(WebCore::RenderStyle::getShadowHorizontalExtent):
(WebCore::RenderStyle::getShadowVerticalExtent):

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::getTextShadowExtent):
(WebCore::InheritedFlags::getTextShadowHorizontalExtent):
(WebCore::InheritedFlags::getTextShadowVerticalExtent):
(WebCore::InheritedFlags::getTextShadowInlineDirectionExtent):
(WebCore::InheritedFlags::getBoxShadowExtent):
(WebCore::InheritedFlags::getBoxShadowHorizontalExtent):
(WebCore::InheritedFlags::getBoxShadowVerticalExtent):
(WebCore::InheritedFlags::getBoxShadowInlineDirectionExtent):
(WebCore::InheritedFlags::getShadowInlineDirectionExtent):

2:16 PM Changeset in webkit [69340] by kinuko@chromium.org
  • 2 edits
    1 delete in trunk/LayoutTests

2010-10-07 Kinuko Yasuda <kinuko@chromium.org>

Unreviewed, updating test expectations for chromium.

  • platform/chromium-win/fast/filesystem: Removed.
  • platform/chromium-win/fast/filesystem/async-operations-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
2:10 PM Changeset in webkit [69339] by kinuko@chromium.org
  • 1 edit
    25 adds in trunk/LayoutTests

2010-10-07 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by David Levin.

Add layout tests for FileSystem API
https://bugs.webkit.org/show_bug.cgi?id=44920

Added tests for major Entry operations: copyTo, moveTo, getFile,
getDirectory, remove, createReader.readEntries, getParent.

  • fast/filesystem/op-copy-expected.txt: Added.
  • fast/filesystem/op-copy.html: Added.
  • fast/filesystem/op-get-entry-expected.txt: Added.
  • fast/filesystem/op-get-entry.html: Added.
  • fast/filesystem/op-get-parent-expected.txt: Added.
  • fast/filesystem/op-get-parent.html: Added.
  • fast/filesystem/op-move-expected.txt: Added.
  • fast/filesystem/op-move.html: Added.
  • fast/filesystem/op-read-directory-expected.txt: Added.
  • fast/filesystem/op-read-directory.html: Added.
  • fast/filesystem/op-remove-expected.txt: Added.
  • fast/filesystem/op-remove.html: Added.
  • fast/filesystem/op-restricted-chars-expected.txt: Added.
  • fast/filesystem/op-restricted-chars.html: Added.
  • fast/filesystem/op-restricted-names-expected.txt: Added.
  • fast/filesystem/op-restricted-names.html: Added.
  • fast/filesystem/resources/fs-test-util.js:
  • fast/filesystem/resources/op-copy.js: Added.
  • fast/filesystem/resources/op-get-entry.js: Added.
  • fast/filesystem/resources/op-get-parent.js: Added.
  • fast/filesystem/resources/op-move.js: Added.
  • fast/filesystem/resources/op-read-directory.js: Added.
  • fast/filesystem/resources/op-remove.js: Added.
  • fast/filesystem/resources/op-restricted-chars.js: Added.
  • fast/filesystem/resources/op-restricted-names.js: Added.
  • fast/filesystem/resources/op-tests-helper.js: Added.
2:06 PM Changeset in webkit [69338] by Simon Fraser
  • 2 edits in trunk/WebCore

2010-10-07 Simon Fraser <Simon Fraser>

Reviewed by Beth Dakin.

Use isIdentityOrTranslationOrFlipped() in scrollbar code
https://bugs.webkit.org/show_bug.cgi?id=47378

Replace old code that looked at values in the CGAffineTransform
with nicely named method that does the same test.

  • platform/mac/ScrollbarThemeMac.mm: (WebCore::ScrollbarThemeMac::paint):
2:03 PM Changeset in webkit [69337] by ajwong@chromium.org
  • 2 edits
    2 adds in trunk/LayoutTests

[Chromium] Unreviewed. Build fix. New baseline.

  • platform/chromium-linux/fast/filesystem/async-operations-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
1:59 PM Changeset in webkit [69336] by mitz@apple.com
  • 2 edits in trunk/WebCore

<rdar://problem/8142645> REGRESSION (r47440): Printing Mail messages with large fonts does not fill page
https://bugs.webkit.org/show_bug.cgi?id=47374

Reviewed by Simon Fraser.

In the legacy (paint-time pagination) printing model, when there are overlapping lines,
adjustPageHeightDeprecated() was not idempotent, since the truncation point imposed by line n,
namely the top of line n, was above the bottom of line n-1, so in the next round, line n-1
moved the truncation point up again.

  • rendering/RenderLineBoxList.cpp:

(WebCore::RenderLineBoxList::paint): Consider the top of the next line when deciding if the
current line extends below the truncation point.

1:51 PM Changeset in webkit [69335] by weinig@apple.com
  • 2 edits in trunk/WebKit2

Update unit tests results.

  • Scripts/webkit2/messages_unittest.py:
1:48 PM Changeset in webkit [69334] by Simon Fraser
  • 3 edits
    4 adds in trunk

2010-10-07 Simon Fraser <Simon Fraser>

Reviewed by Beth Dakin.

Edge fringe artifact with transformed, masked elements (including reflections)
https://bugs.webkit.org/show_bug.cgi?id=19179

When drawing the mask images, use a transparency layer if the CTM
has a rotation, scale or skew in it to avoid antialiasing issues at
the edges.

Test: fast/css/transformed-mask.html

  • rendering/RenderBox.cpp: (WebCore::RenderBox::paintMask): Don't bother painting the mask if painting is disabled, which also avoids an assertion in getCTM(). (WebCore::RenderBox::paintMaskImages):
12:59 PM Changeset in webkit [69333] by beidson@apple.com
  • 2 edits in trunk/WebKit2
  • Platform/Logging.cpp:

(initializeLogChannel): GCC optimized out the only caller of this function. Windows doesn't, and is breaking.

Reviewed by BUILD FIX for non-gcc builds.

12:46 PM Changeset in webkit [69332] by ajwong@chromium.org
  • 3 edits
    5 adds in trunk/LayoutTests

[Chromium] Unreviewed. New baselines, and expectations updates.

Changing fast/frames/cached-frame-counter.html to SKIP for DEBUG
platforms since it always times out.

Upstreamed expectation:

http/tests/misc/last-modified-parsing.html

Removed expecations for these as they pass consistently:

svg/batik/text/textProperties.svg
fast/dom/Window/window-screen-properties.html
fast/media/color-does-not-include-alpha.html
fast/events/mouse-focus-imagemap.html
fast/dom/object-embed-plugin-scripting.html
fast/images/imagemap-case.html

Marked as flaky:

svg/hixie/perf/001.xml
svg/hixie/perf/002.xml
svg/W3C-SVG-1.1/animate-elem-03-t.svg

New test missing baseline:

platform/gtk/fonts/fontconfig-synthetic-bold.html

  • platform/chromium-mac/fast/images/imagemap-case-expected.checksum: Added.
  • platform/chromium-mac/fast/images/imagemap-case-expected.png: Added.
  • platform/chromium-win/fast/filesystem/async-operations-expected.txt: Added.
  • platform/chromium-win/media/audio-delete-while-slider-thumb-clicked-expected.txt: Added.
  • platform/chromium-win/svg/custom/struct-use-09-b-expected.png:
  • platform/chromium/test_expectations.txt:
12:41 PM Changeset in webkit [69331] by commit-queue@webkit.org
  • 4 edits in trunk/WebKit/qt

2010-10-07 Andreas Kling <kling@webkit.org>

Reviewed by Simon Hausmann.

[Qt] API: ViewportConfiguration => ViewportArguments
https://bugs.webkit.org/show_bug.cgi?id=47325

  • Api/qwebpage.cpp: (QWebPage::ViewportAttributes::ViewportAttributes): (QWebPage::ViewportAttributes::~ViewportAttributes): (QWebPage::ViewportAttributes::operator=): (QWebPage::viewportAttributesForSize):
  • Api/qwebpage.h:
  • Api/qwebpage_p.h: (QtViewportAttributesPrivate::QtViewportAttributesPrivate):
12:35 PM Changeset in webkit [69330] by Darin Adler
  • 2 edits in trunk/WebKit2

Fix include mistake that makes build fail with non-Objective-C.

  • Shared/API/c/mac/WKCertificateInfoMac.h: Include CoreFoundation.h,

not Foundation.h.

12:32 PM Changeset in webkit [69329] by andersca@apple.com
  • 27 edits
    1 copy
    1 add in trunk/WebKit2

Generate the messages sent to the WebPageProxy
https://bugs.webkit.org/show_bug.cgi?id=47239

Patch by Sam Weinig <sam@webkit.org> on 2010-10-07
Reviewed by Anders Carlsson.

  • DerivedSources.make:
  • DerivedSources.pro:
  • Platform/CoreIPC/Arguments.h:
  • Platform/CoreIPC/HandleMessage.h:

(CoreIPC::handleMessage):

  • Scripts/webkit2/messages.py:
  • Shared/CoreIPCSupport/WebPageProxyMessageKinds.h: Removed.
  • Shared/StringPairVector.h: Added.
  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::registerEditCommand):

  • UIProcess/API/qt/qwkpage.cpp:

(QWKPagePrivate::registerEditCommand):

  • UIProcess/API/qt/qwkpage_p.h:
  • UIProcess/PageClient.h:
  • UIProcess/WebEditCommandProxy.cpp:

(WebKit::WebEditCommandProxy::unapply):
(WebKit::WebEditCommandProxy::reapply):

  • UIProcess/WebFormClient.cpp:

(WebKit::WebFormClient::willSubmitForm):

  • UIProcess/WebFormClient.h:
  • UIProcess/WebPageProxy.cpp:
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in: Added.
  • UIProcess/win/WebView.cpp:

(WebKit::WebView::registerEditCommand):

  • UIProcess/win/WebView.h:
  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:
  • WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::WebEditorClient::registerCommandForUndo):
(WebKit::WebEditorClient::clearUndoRedoOperations):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
  • WebProcess/WebPage/WebBackForwardListProxy.cpp:
  • WebProcess/WebPage/WebPage.cpp:
  • win/WebKit2.vcproj:
12:29 PM Changeset in webkit [69328] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-10-07 Kwang Yul Seo <skyul@company100.net>

Reviewed by Kent Tamura.

[BREWMP] Map non-alphabet key code to Unicode value
https://bugs.webkit.org/show_bug.cgi?id=46002

Non-alphabet key codes are not equal to the unicode values. Add conversion.

  • platform/brew/PlatformKeyboardEventBrew.cpp: (WebCore::singleCharacterString):
12:06 PM Changeset in webkit [69327] by beidson@apple.com
  • 2 edits in trunk/WebKit2

Forgot this to keep the build working.

Reviewed by BUILD FIX.

  • WebKit2Prefix.h:
11:39 AM Changeset in webkit [69326] by Martin Robinson
  • 5 edits
    2 adds in trunk

2010-09-21 Martin Robinson <mrobinson@igalia.com>

Reviewed by Chris Fleizach.

[GTK] The FreeType backend does not respect the FC_EMBOLDEN property
https://bugs.webkit.org/show_bug.cgi?id=46216

Added tests for this issue.

  • platform/gtk/fonts/fontconfig-synthetic-bold-expected.txt: Added.
  • platform/gtk/fonts/fontconfig-synthetic-bold.html: Added.

2010-10-05 Martin Robinson <mrobinson@igalia.com>

Reviewed by Chris Fleizach.

[GTK] The FreeType backend does not respect the FC_EMBOLDEN property
https://bugs.webkit.org/show_bug.cgi?id=46216

Look for the FC_EMBOLDEN property of the FcPattern when constructing
FontPlatformData and use it to enable synthetic bold fonts when necessary.

Test: platform/gtk/fonts/fontconfig-synthetic-bold.html

  • platform/graphics/cairo/FontPlatformDataFreeType.cpp: (WebCore::FontPlatformData::FontPlatformData): Properly handle the FC_EMBOLDEN property.

2010-09-21 Martin Robinson <mrobinson@igalia.com>

Reviewed by Chris Fleizach.

[GTK] The FreeType backend does not respect the FC_EMBOLDEN property
https://bugs.webkit.org/show_bug.cgi?id=46216

  • DumpRenderTree/gtk/fonts/fonts.conf: Add a setting which enables FC_EMBOLDEN for DejaVu Serif when there is no bold version available. This is necessary to properly test the property in layout tests.
11:19 AM Changeset in webkit [69325] by andersca@apple.com
  • 6 edits
    1 add in trunk/WebKit2

Start stubbing out the find API
https://bugs.webkit.org/show_bug.cgi?id=47366
<rdar://problem/8524998>

Reviewed by John Sullivan.

  • Shared/FindOptions.h: Added.
  • UIProcess/API/C/WKAPICast.h:

(WebKit::toFindDirection):
(WebKit::toFindOptions):

  • UIProcess/API/C/WKPage.cpp:

(WKPageFindString):
(WKPageHideFindUI):
(WKPageCountStringMatches):

  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::findString):
(WebKit::WebPageProxy::hideFindUI):
(WebKit::WebPageProxy::countStringMatches):

  • UIProcess/WebPageProxy.h:
11:09 AM Changeset in webkit [69324] by kbalazs@webkit.org
  • 7 edits
    3 adds
    1 delete in trunk

[Qt] Build files for the WTR's InjectedBundle

11:00 AM Changeset in webkit [69323] by beidson@apple.com
  • 4 edits
    2 adds in trunk/WebKit2

Part of https://bugs.webkit.org/show_bug.cgi?id=47354 - Add WebCore/WebKit1 style logging channel mechanism0 to WebKit2,
including the first channel to be used for SessionState work.

Reviewed by Sam Weinig.

  • Platform/Logging.cpp: Added.

(initializeLogChannelsIfNecessary):

  • Platform/Logging.h: Added.
  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:
10:56 AM Changeset in webkit [69322] by kbalazs@webkit.org
  • 6 edits
    1 add in trunk

2010-10-07 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r69315.
http://trac.webkit.org/changeset/69315
https://bugs.webkit.org/show_bug.cgi?id=47363

Forgot to add the new files (Requested by kbalazs on #webkit).

  • DerivedSources.pro:

2010-10-07 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r69315.
http://trac.webkit.org/changeset/69315
https://bugs.webkit.org/show_bug.cgi?id=47363

Forgot to add the new files (Requested by kbalazs on #webkit).

  • Scripts/webkitdirs.pm:
  • WebKitTestRunner/qt/DerivedSources.pro: Added.

2010-10-07 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r69315.
http://trac.webkit.org/changeset/69315
https://bugs.webkit.org/show_bug.cgi?id=47363

Forgot to add the new files (Requested by kbalazs on #webkit).

  • WebKit2.pro:
10:56 AM Changeset in webkit [69321] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-10-07 James Simonsen <simonjam@chromium.org>

Reviewed by Pavel Feldman.

[Web Timing] Use platform definition of responseEnd
https://bugs.webkit.org/show_bug.cgi?id=46306

No new tests. Used existing webtiming test.

  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::didFinishLoading):
10:46 AM Changeset in webkit [69320] by Martin Robinson
  • 4 edits
    4 adds in trunk

2010-10-05 Martin Robinson <mrobinson@igalia.com>

Reviewed by Chris Fleizach.

[Gtk] CSS font-style: italic behavior
https://bugs.webkit.org/show_bug.cgi?id=33299

Added a test to test the FontConfig synthetic oblique behavior.

  • platform/gtk/fonts/fontconfig-synthetic-oblique-expected.checksum: Added.
  • platform/gtk/fonts/fontconfig-synthetic-oblique-expected.png: Added.
  • platform/gtk/fonts/fontconfig-synthetic-oblique-expected.txt: Added.
  • platform/gtk/fonts/fontconfig-synthetic-oblique.html: Added.

2010-10-05 Martin Robinson <mrobinson@igalia.com>

Reviewed by Chris Fleizach.

[Gtk] CSS font-style: italic behavior
https://bugs.webkit.org/show_bug.cgi?id=33299

Properly interpret the FC_MATRIX property from a FontConfig pattern.
FontConfig will use this property when returning fonts which have a
synthetic oblique variant configured in the fonts.conf configuration
file.

Test: platform/gtk/fonts/fontconfig-synthetic-oblique.html

  • platform/graphics/cairo/FontPlatformDataFreeType.cpp: (WebCore::FontPlatformData::FontPlatformData): Added a constructor that takes an existing FontPlatformData and a font size. (WebCore::FontPlatformData::initializeWithFontFace): Added this helper intialization method that properly handles the FC_MATRIX property from the FcPattern.
  • platform/graphics/cairo/FontPlatformDataFreeType.h: Added a declaration to the new constructor and the initializeWithFontFace.
  • platform/graphics/cairo/SimpleFontDataCairo.cpp: (WebCore::SimpleFontData::smallCapsFontData): Use the new FontPlatformData constructor.
10:40 AM Changeset in webkit [69319] by hyatt@apple.com
  • 5 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=47357

Reviewed by Dan Bernstein.

Make findNextLineBreak and some of the helper functions it also calls writing-mode-aware.

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::computeLogicalBoxHeights):
(WebCore::InlineFlowBox::placeBoxesInBlockDirection):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::positionNewFloatOnLine):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::getBorderPaddingMargin):
(WebCore::inlineLogicalWidth):
(WebCore::RenderBlock::computeInlineDirectionPositionsForLine):
(WebCore::inlineFlowRequiresLineBox):
(WebCore::RenderBlock::skipLeadingWhitespace):
(WebCore::RenderBlock::fitBelowFloats):
(WebCore::RenderBlock::findNextLineBreak):

  • rendering/RenderBoxModelObject.h:

(WebCore::RenderBoxModelObject::hasInlineDirectionBordersPaddingOrMargin):
(WebCore::RenderBoxModelObject::hasInlineDirectionBordersOrPadding):

10:39 AM Changeset in webkit [69318] by jer.noble@apple.com
  • 3 edits in trunk/WebKit/mac

2010-10-06 Jer Noble <jer.noble@apple.com>

Reviewed by Darin Adler.

Screensaver starts while watching fullscreen playback.
https://bugs.webkit.org/show_bug.cgi?id=47299
<rdar://problem/8478956>

To disable the Screen Saver, we need to periodically call UpdateSystemActivity().

  • WebView/WebVideoFullscreenController.h: Added _tickleTimer.
  • WebView/WebVideoFullscreenController.mm: (-[WebVideoFullscreenController dealloc]): Invalidate _tickleTimer. (-[WebVideoFullscreenController _enableTickleTimer]): Create _tickleTimer. (-[WebVideoFullscreenController _disableTickleTimer]): Invalidate _tickleTimer. (-[WebVideoFullscreenController _tickleTimerFired]): Call UpdateSystemActivity(). (-[WebVideoFullscreenController updatePowerAssertions]): Call _enableTickleTimer

or _disableTickleTimer.

10:32 AM Changeset in webkit [69317] by weinig@apple.com
  • 14 edits
    1 add in trunk/WebKitTools

Change API tester to ask the executable for the list of all
tests instead of relying on the directory structure.
https://bugs.webkit.org/show_bug.cgi?id=47359

Reviewed by Anders Carlsson.

  • Scripts/run-test-webkit-api: Added.
  • Scripts/webkitdirs.pm:

Add additional script to just launch the api tester with the correct settings.

  • Scripts/run-api-tests:

Change to use the new --dump-tests options to build the list of tests and change
output to reflect a (suite, testcase) tuple for each test. Also adds some color.

  • TestWebKitAPI/Test.h:

(TestWebKitAPI::Test::Register::Register):

  • TestWebKitAPI/Tests/WTF/VectorBasic.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit2/WKString.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp:

(TestWebKitAPI::TEST):
Give each test a suite name in addition to the test name.

  • TestWebKitAPI/TestsController.cpp:

(TestWebKitAPI::TestsController::dumpTestNames):
(TestWebKitAPI::TestsController::runTestNamed):

  • TestWebKitAPI/TestsController.h:
  • TestWebKitAPI/mac/main.mm:

(main):
Add option to print all registered tests.

10:26 AM Changeset in webkit [69316] by commit-queue@webkit.org
  • 7 edits in trunk

2010-10-07 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

Fixing viewport meta tag user-scalable handling
https://bugs.webkit.org/show_bug.cgi?id=47330

user-scalable attribute was not considered in viewport meta tag handling.

  • dom/ViewportArguments.cpp: (WebCore::findConfigurationForViewportData):
  • dom/ViewportArguments.h:

2010-10-07 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

Fixing viewport meta tag user-scalable handling
https://bugs.webkit.org/show_bug.cgi?id=47330

user-scalable attribute was not considered in viewport meta tag handling.

  • Api/qwebpage.cpp: (QWebPage::viewportConfigurationForSize):

2010-10-07 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

Fixing viewport meta tag user-scalable handling
https://bugs.webkit.org/show_bug.cgi?id=47330

user-scalable attribute was not considered in viewport meta tag handling.

  • UIProcess/API/qt/qwkpage.cpp: (QWKPage::viewportConfigurationForSize):
10:12 AM Changeset in webkit [69315] by kbalazs@webkit.org
  • 6 edits
    1 delete in trunk

[Qt] Build files for the WTR's InjectedBundle

9:58 AM Changeset in webkit [69314] by ajwong@chromium.org
  • 14 edits
    5 adds in trunk/LayoutTests

Unreviewed. Chromium build fix.

Add new baselines for svg/hixie/perf/001.xml and
svg/hixie/perf/002.xml. After r69305, which removed the rendering
timestamp from the image, these tests are now more deterministic.

  • platform/chromium-linux/svg/hixie/perf/001-expected.checksum:
  • platform/chromium-linux/svg/hixie/perf/001-expected.png:
  • platform/chromium-linux/svg/hixie/perf/001-expected.txt:
  • platform/chromium-linux/svg/hixie/perf/002-expected.checksum:
  • platform/chromium-linux/svg/hixie/perf/002-expected.png:
  • platform/chromium-linux/svg/hixie/perf/002-expected.txt:
  • platform/chromium-mac/svg/hixie/perf/001-expected.checksum: Added.
  • platform/chromium-mac/svg/hixie/perf/001-expected.png: Added.
  • platform/chromium-mac/svg/hixie/perf/002-expected.checksum: Added.
  • platform/chromium-mac/svg/hixie/perf/002-expected.png: Added.
  • platform/chromium-win/svg/hixie/perf/001-expected.checksum:
  • platform/chromium-win/svg/hixie/perf/001-expected.png:
  • platform/chromium-win/svg/hixie/perf/001-expected.txt:
  • platform/chromium-win/svg/hixie/perf/002-expected.checksum:
  • platform/chromium-win/svg/hixie/perf/002-expected.png:
  • platform/chromium-win/svg/hixie/perf/002-expected.txt:
  • platform/chromium/test_expectations.txt:
9:23 AM Changeset in webkit [69313] by diegohcg@webkit.org
  • 5 edits
    1 copy
    1 add in trunk

[Qt] Hook up accelerometer data via Qt DeviceMotion
https://bugs.webkit.org/show_bug.cgi?id=47105

Reviewed by Andreas Kling.

Get accelerometer necessary data via Qt mobility library using a
provider class. Enable, also the RotationRate using the current device
orientation provider.

WebCore:

  • WebCore.pro:

WebKit/qt:

  • WebCoreSupport/DeviceMotionClientQt.cpp:

(WebCore::DeviceMotionClientQt::DeviceMotionClientQt):
(WebCore::DeviceMotionClientQt::~DeviceMotionClientQt):
(WebCore::DeviceMotionClientQt::startUpdating):
(WebCore::DeviceMotionClientQt::stopUpdating):
(WebCore::DeviceMotionClientQt::currentDeviceMotion):
(WebCore::DeviceMotionClientQt::changeDeviceMotion):

  • WebCoreSupport/DeviceMotionClientQt.h:
  • WebCoreSupport/DeviceMotionProviderQt.cpp: Added.

(WebCore::DeviceMotionProviderQt::DeviceMotionProviderQt):
(WebCore::DeviceMotionProviderQt::~DeviceMotionProviderQt):
(WebCore::DeviceMotionProviderQt::start):
(WebCore::DeviceMotionProviderQt::stop):
(WebCore::DeviceMotionProviderQt::filter):

  • WebCoreSupport/DeviceMotionProviderQt.h: Added.

(WebCore::DeviceMotionProviderQt::currentDeviceMotion):

9:05 AM QtWebKitWeeklyBuilds edited by Csaba Osztrogonác
typo fix (diff)
8:37 AM Changeset in webkit [69312] by commit-queue@webkit.org
  • 8 edits in trunk

2010-10-07 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

Some viewport meta tag api refactoring
https://bugs.webkit.org/show_bug.cgi?id=47334

WebCore::findConfigurationForViewportData renamed to computeViewportAttributes.
WebCore::ViewportAttributes::layoutViewport renamed to layoutSize.

  • dom/ViewportArguments.cpp: (WebCore::computeViewportAttributes):
  • dom/ViewportArguments.h:

2010-10-07 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

Some viewport meta tag api refactoring
https://bugs.webkit.org/show_bug.cgi?id=47334

WebCore::findConfigurationForViewportData renamed to computeViewportAttributes.
WebCore::ViewportAttributes::layoutViewport renamed to layoutSize.

  • Api/qwebpage.cpp: (QWebPage::viewportConfigurationForSize):
  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::viewportAsText):

2010-10-07 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

Some viewport meta tag api refactoring
https://bugs.webkit.org/show_bug.cgi?id=47334

WebCore::findConfigurationForViewportData renamed to computeViewportAttributes.
WebCore::ViewportAttributes::layoutViewport renamed to layoutSize.

  • UIProcess/API/qt/qwkpage.cpp: (QWKPage::viewportConfigurationForSize):
8:08 AM Changeset in webkit [69311] by commit-queue@webkit.org
  • 4 edits
    2 copies in trunk/WebKit/chromium

2010-10-07 Dave Moore <davemoore@chromium.org>

Reviewed by Kent Tamura.

Add WebThemeEngine api for chromium/linux
https://bugs.webkit.org/show_bug.cgi?id=47278
Create new linux specific version of WinThemeEngine.h and move
existing windows specific one to win directory. Keep old top
level file until chromium is updated to use the new ones.

  • WebKit.gyp:
  • public/WebThemeEngine.h:
  • src/ChromiumBridge.cpp:
8:04 AM Changeset in webkit [69310] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

[Qt] Update .def file for Symbian
https://bugs.webkit.org/show_bug.cgi?id=47336
Fix and re-freeze symbols for symbian - viewportConfigurationForSize
API changed, allowGeolocationRequest removed from API, several
DumpRenderTree support calls added.

Patch by Keith Kyzivat <keith.kyzivat@nokia.com> on 2010-10-07
Reviewed by Simon Hausmann.

  • symbian/eabi/QtWebKitu.def:
7:56 AM Changeset in webkit [69309] by jberlin@webkit.org
  • 5 edits in trunk/WebKit2

Bundle should expose a reportException method.
https://bugs.webkit.org/show_bug.cgi?id=46769

Reviewed by John Sullivan.

  • WebProcess/InjectedBundle/API/c/WKBundle.cpp:

(WKBundleReportException):

  • WebProcess/InjectedBundle/API/c/WKBundle.h:
  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::reportException):
Mimic the behavior of WebView::reportException.

  • WebProcess/InjectedBundle/InjectedBundle.h:
7:56 AM Changeset in webkit [69308] by kbalazs@webkit.org
  • 2 edits in trunk/WebKitTools

2010-10-07 Balazs Kelemen <kbalazs@webkit.org>

Unreviewed. Do a renaming that was recommended by the reviewer
(Kenneth) but I forgot to do before landing (http://trac.webkit.org/changeset/69253)

  • WebKitTestRunner/qt/TestControllerQt.cpp: (WTR::RunUntilConditionLoop::start): (WTR::RunUntilConditionLoop::RunUntilConditionLoop): (WTR::TestController::runUntil):
7:44 AM Changeset in webkit [69307] by kbalazs@webkit.org
  • 2 edits
    2 adds in trunk/WebKitTools

2010-10-07 Balazs Kelemen <kbalazs@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Watchdog timer implementation for WTR
https://bugs.webkit.org/show_bug.cgi?id=47337

  • WebKitTestRunner/InjectedBundle/LayoutTestController.h: Factor out the definition of the timer type to a typedef.
  • WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp: Added. Timer implementation with QTimer and a helper QObject class. (WTR::WatchdogTimerHelper::instance): (WTR::WatchdogTimerHelper::timerFired): (WTR::WatchdogTimerHelper::WatchdogTimerHelper): (WTR::LayoutTestController::platformInitialize): (WTR::LayoutTestController::invalidateWaitToDumpWatchdogTimer): (WTR::LayoutTestController::initializeWaitToDumpWatchdogTimerIfNeeded):
7:36 AM Changeset in webkit [69306] by kbalazs@webkit.org
  • 2 edits in trunk

2010-10-07 Balazs Kelemen <kbalazs@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Turn on building WTR
https://bugs.webkit.org/show_bug.cgi?id=47349

  • WebKit.pro:
6:20 AM Changeset in webkit [69305] by Nikolas Zimmermann
  • 31 edits
    24 adds in trunk/LayoutTests

2010-10-07 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Reenable several skipped SVG tests on leopard & snow leopard
https://bugs.webkit.org/show_bug.cgi?id=47340

Following tests can be unskipped, as they work as expected.

On SnowLeopard:
svg/batik/paints/patternRegionA.svg
svg/custom/path-bad-data.svg
svg/custom/pattern-deep-referencing.svg
svg/hixie/perf/007.xml
svg/transforms/text-with-pattern-inside-transformed-html.xhtml
svg/transforms/text-with-pattern-with-svg-transform.svg

On Leopard:
svg/filters/filter-empty-g.svg

On both:
svg/W3C-SVG-1.1/animate-elem-82-t.svg
svg/W3C-SVG-1.1/coords-trans-01-b.svg
svg/css/glyph-orientation-rounding-test.xhtml (not 100% sure about this one, I don't see any rounding problems, we may have to disable it again, if the problem shows up on the bots)
svg/custom/tiling-regular-hexagonal-crash.svg (test needs some fixes though to make sense)
svg/hixie/perf/001.xml (test needs a fix, so it doesn't dump the elapsed time)
svg/hixie/perf/002.xml (ditto)
svg/batik/text/smallFonts.svg (still not correct, but doesn't crash or hang)

  • platform/mac-leopard/Skipped:
  • platform/mac-leopard/svg/W3C-SVG-1.1/animate-elem-82-t-expected.checksum: Added.
  • platform/mac-leopard/svg/W3C-SVG-1.1/animate-elem-82-t-expected.png: Added.
  • platform/mac-leopard/svg/W3C-SVG-1.1/coords-trans-01-b-expected.checksum: Added.
  • platform/mac-leopard/svg/W3C-SVG-1.1/coords-trans-01-b-expected.png: Added.
  • platform/mac-leopard/svg/batik/text/smallFonts-expected.checksum: Added.
  • platform/mac-leopard/svg/batik/text/smallFonts-expected.png: Added.
  • platform/mac-leopard/svg/custom/path-bad-data-expected.checksum: Added.
  • platform/mac-leopard/svg/custom/path-bad-data-expected.png: Added.
  • platform/mac-leopard/svg/custom/path-bad-data-expected.txt: Added.
  • platform/mac-leopard/svg/custom/pattern-deep-referencing-expected.checksum: Added.
  • platform/mac-leopard/svg/custom/pattern-deep-referencing-expected.png: Added.
  • platform/mac-leopard/svg/hixie/perf: Added.
  • platform/mac-leopard/svg/hixie/perf/001-expected.checksum: Added.
  • platform/mac-leopard/svg/hixie/perf/001-expected.png: Added.
  • platform/mac-leopard/svg/hixie/perf/002-expected.checksum: Added.
  • platform/mac-leopard/svg/hixie/perf/002-expected.png: Added.
  • platform/mac-leopard/svg/hixie/perf/007-expected.checksum: Added.
  • platform/mac-leopard/svg/hixie/perf/007-expected.png: Added.
  • platform/mac-leopard/svg/transforms/text-with-pattern-inside-transformed-html-expected.checksum: Added.
  • platform/mac-leopard/svg/transforms/text-with-pattern-inside-transformed-html-expected.png: Added.
  • platform/mac-leopard/svg/transforms/text-with-pattern-with-svg-transform-expected.checksum: Added.
  • platform/mac-leopard/svg/transforms/text-with-pattern-with-svg-transform-expected.png: Added.
  • platform/mac-snowleopard/Skipped:
  • platform/mac/Skipped:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-82-t-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-82-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-82-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/coords-trans-01-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/coords-trans-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/coords-trans-01-b-expected.txt:
  • platform/mac/svg/batik/text/smallFonts-expected.checksum: Added.
  • platform/mac/svg/batik/text/smallFonts-expected.png: Added.
  • platform/mac/svg/batik/text/smallFonts-expected.txt:
  • platform/mac/svg/custom/path-bad-data-expected.checksum:
  • platform/mac/svg/custom/path-bad-data-expected.png:
  • platform/mac/svg/custom/path-bad-data-expected.txt:
  • platform/mac/svg/custom/pattern-deep-referencing-expected.checksum:
  • platform/mac/svg/custom/pattern-deep-referencing-expected.png:
  • platform/mac/svg/hixie/perf/001-expected.checksum:
  • platform/mac/svg/hixie/perf/001-expected.png:
  • platform/mac/svg/hixie/perf/001-expected.txt:
  • platform/mac/svg/hixie/perf/002-expected.checksum:
  • platform/mac/svg/hixie/perf/002-expected.png:
  • platform/mac/svg/hixie/perf/002-expected.txt:
  • platform/mac/svg/hixie/perf/007-expected.checksum:
  • platform/mac/svg/hixie/perf/007-expected.png:
  • platform/mac/svg/transforms/text-with-pattern-inside-transformed-html-expected.checksum:
  • platform/mac/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
  • platform/mac/svg/transforms/text-with-pattern-with-svg-transform-expected.checksum:
  • platform/mac/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
  • svg/custom/tiling-regular-hexagonal-crash.svg: Make the test actually show up the pattern.
  • svg/hixie/perf/001.xml: Don't dump elapsed times, otherwhise results will be inconsistent. Add DRT waitUntilDone/notifyDone logic.
  • svg/hixie/perf/002.xml: Ditto.
6:11 AM Changeset in webkit [69304] by luiz@webkit.org
  • 3 edits
    2 adds in trunk/WebKit2

2010-10-07 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Adam Roben.

[Qt] Webkit2 MacOS build fix
https://bugs.webkit.org/show_bug.cgi?id=47167

There were two problems when building Qt WebKit2 in Mac. The first was that
ld does not support flag -whole-archive and it needed to be replaced by flag -all_load.
The second problem was that APPLE is been used to identify safari builds and, when
building Qt in MacOS, Qt was ending up using the wrong typedef. The solution was to use
a Qt specific WKNativeEvent.h that only has the proper Qt typedef instead of the original one.

  • UIProcess/API/C/qt/WKNativeEvent.h: Added.
  • WebKit2.pri:
  • WebKit2.pro:
6:01 AM Changeset in webkit [69303] by kbalazs@webkit.org
  • 2 edits in trunk/WebKitTools

2010-10-07 Balazs Kelemen <kbalazs@webkit.org>

Unreviewed buildfix for 69297 again

  • WebKitTestRunner/TestController.cpp: (WTR::blankURL):
5:57 AM Changeset in webkit [69302] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit/gtk

2010-10-07 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Xan Lopez.

[GTK] Use draw instead of expose_event in WebView when building with gtk3
https://bugs.webkit.org/show_bug.cgi?id=47338

  • webkit/webkitwebview.cpp: (webkit_web_view_expose_event): (webkit_web_view_draw): (webkit_web_view_class_init):
5:44 AM Changeset in webkit [69301] by commit-queue@webkit.org
  • 5 edits in trunk

2010-10-07 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Xan Lopez.

[GTK] Don't use GtkObject
https://bugs.webkit.org/show_bug.cgi?id=47090

GtkObject has been removed in gtk3.

  • plugins/gtk/gtk2xtbin.c: (gtk_xtbin_class_init): (gtk_xtbin_dispose):

2010-10-07 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Xan Lopez.

[GTK] Don't use GtkObject
https://bugs.webkit.org/show_bug.cgi?id=47090

GtkObject has been removed in gtk3.

  • WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::generateEditorCommands):
  • WebCoreSupport/FullscreenVideoController.cpp: (FullscreenVideoController::createHud):
5:42 AM Changeset in webkit [69300] by podivilov@chromium.org
  • 9 edits in trunk/WebCore

2010-10-07 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: highlight XHR breakpoint when hit.
https://bugs.webkit.org/show_bug.cgi?id=47253

  • inspector/InspectorController.cpp: (WebCore::InspectorController::didCommitLoad): (WebCore::InspectorController::setNativeBreakpoint): (WebCore::InspectorController::removeNativeBreakpoint): (WebCore::InspectorController::findEventListenerBreakpoint): (WebCore::InspectorController::findXHRBreakpoint):
  • inspector/InspectorController.h:
  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::instrumentWillDispatchEventImpl): (WebCore::InspectorInstrumentation::instrumentWillSendXMLHttpRequestImpl):
  • inspector/front-end/BreakpointManager.js: (WebInspector.BreakpointManager.prototype.createEventListenerBreakpoint): (WebInspector.BreakpointManager.prototype.createXHRBreakpoint): (WebInspector.BreakpointManager.prototype._xhrBreakpointRemoved): (WebInspector.BreakpointManager.prototype._removeNativeBreakpoint): (WebInspector.BreakpointManager.prototype._setNativeBreakpointEnabled): (WebInspector.BreakpointManager.prototype._setNativeBreakpointOnBackend.didSetNativeBreakpoint): (WebInspector.BreakpointManager.prototype._setNativeBreakpointOnBackend): (WebInspector.BreakpointManager.prototype._removeNativeBreakpointFromBackend): (WebInspector.BreakpointManager.prototype.debuggerPaused): (WebInspector.BreakpointManager.prototype.debuggerResumed): (WebInspector.NativeBreakpoint): (WebInspector.NativeBreakpoint.prototype.get enabled): (WebInspector.NativeBreakpoint.prototype.set enabled): (WebInspector.NativeBreakpoint.prototype.remove):
  • inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.BreakpointItem): (WebInspector.BreakpointItem.prototype._breakpointClicked): (WebInspector.BreakpointItem.prototype._hitStateChanged):
  • inspector/front-end/CallStackSidebarPane.js: (WebInspector.CallStackSidebarPane.prototype.updateStatus):
  • inspector/front-end/inspector.css: (.breakpoint-list .breakpoint-hit):
  • inspector/front-end/inspector.js: (WebInspector.pausedScript): (WebInspector.resumedScript):
5:34 AM Changeset in webkit [69299] by kbalazs@webkit.org
  • 2 edits in trunk/WebKitTools

Unreviewed build fix for r69297

5:31 AM Changeset in webkit [69298] by commit-queue@webkit.org
  • 2 edits in trunk

2010-10-07 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Xan Lopez.

[GTK] Fix the build for GTK+ 3
https://bugs.webkit.org/show_bug.cgi?id=47249

Bump required gtk+-3 version to 2.91.0

  • configure.ac:
5:30 AM QtWebKitDocContrib edited by Ademar Reis
(diff)
5:23 AM Changeset in webkit [69297] by kbalazs@webkit.org
  • 6 edits in trunk

2010-10-07 Balazs Kelemen <kbalazs@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

WebKitTestRunner should be portable
https://bugs.webkit.org/show_bug.cgi?id=45393

Use only the WebKit API for working with urls.

  • WebKitTestRunner/StringFunctions.h: (WTR::createWKURL):
  • WebKitTestRunner/TestController.cpp: (WTR::blankURL): (WTR::TestController::resetStateToConsistentValues): (WTR::TestController::didFinishLoadForFrame):

2010-10-07 Balazs Kelemen <kbalazs@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

WebKitTestRunner should be portable
https://bugs.webkit.org/show_bug.cgi?id=45393

Introducing additional URL API.

  • Shared/API/c/WKURL.cpp: (WKURLCreateWithUTF8CString): (WKURLIsEqual):
  • Shared/API/c/WKURL.h:
5:20 AM Changeset in webkit [69296] by commit-queue@webkit.org
  • 5 edits in trunk

2010-10-07 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Xan Lopez.

[GTK] Fix the build for GTK+ 3
https://bugs.webkit.org/show_bug.cgi?id=47249

Use GdkVisual instead of GdkColormap. GdkColormap has been removed
in gtk3.

  • plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::platformStart):
  • plugins/gtk/gtk2xtbin.c: (gtk_xtbin_new):

2010-10-07 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Xan Lopez.

[GTK] Fix the build for GTK+ 3
https://bugs.webkit.org/show_bug.cgi?id=47249

Use GdkVisual instead of GdkColormap. GdkColormap has been removed
in gtk3

  • webkit/webkitwebview.cpp: (webkit_web_view_realize):
5:03 AM Changeset in webkit [69295] by caseq@chromium.org
  • 3 edits in trunk/WebKit/chromium

2010-10-07 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Chromium multi-dll build broken due to WebResourceRawHeaders methods lacking WEBKIT_API decl spec
https://bugs.webkit.org/show_bug.cgi?id=47329

  • public/WebResourceRawHeaders.h: (WebKit::WebResourceRawHeaders::WebResourceRawHeaders): (WebKit::WebResourceRawHeaders::~WebResourceRawHeaders): (WebKit::WebResourceRawHeaders::operator =):
  • src/WebResourceRawHeaders.cpp: (WebKit::WebResourceRawHeaders::initialize): (WebKit::WebResourceRawHeaders::reset): (WebKit::WebResourceRawHeaders::assign):
4:58 AM Changeset in webkit [69294] by commit-queue@webkit.org
  • 2 edits in trunk/WebKitTools

2010-10-07 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Xan Lopez.

[GTK] Use gtk_widget_draw() instead of gtk_widget_get_snapshot() in PixelDumpSupportGtk when building with gtk3
https://bugs.webkit.org/show_bug.cgi?id=47332

  • DumpRenderTree/gtk/PixelDumpSupportGtk.cpp: (createBitmapContextFromWebView):
4:46 AM Changeset in webkit [69293] by commit-queue@webkit.org
  • 7 edits in trunk

2010-10-07 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Xan Lopez.

[GTK] Fix the build for GTK+ 3
https://bugs.webkit.org/show_bug.cgi?id=47249

Do not use GdkDrawable deprecated API. Some methods of GdkDrawable
are deprecated in gtk2 and have been removed in gtk3. Equivalent
API has been added to GdkWindow.

  • platform/gtk/GtkVersioning.c: (getDefaultGDKPointerDevice):
  • platform/gtk/GtkVersioning.h:
  • platform/gtk/PlatformScreenGtk.cpp: (WebCore::getVisual): (WebCore::screenAvailableRect):

2010-10-07 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Xan Lopez.

[GTK] Fix the build for GTK+ 3
https://bugs.webkit.org/show_bug.cgi?id=47249

Do not use GdkDrawable deprecated API. Some methods of GdkDrawable
are deprecated in gtk2 and have been removed in gtk3. Equivalent
API has been added to GdkWindow.

  • tests/testcopyandpaste.c: (runPasteTestCallback):
  • webkit/webkitwebview.cpp: (webkit_web_view_button_press_event):
4:42 AM Changeset in webkit [69292] by Nikolas Zimmermann
  • 155 edits
    157 adds in trunk/LayoutTests

2010-10-07 Nikolas Zimmermann <nzimmermann@rim.com>

Rubber stamped by Dirk Schulze.

Finalize SVG pixel test baseline updates. We should have a clean baseline now for Leopard & Snow Leopard, that passes with --tolerance 0 (at least on my 10.5 & 10.6 systems).

  • platform/mac-leopard/svg/batik/masking: Added.
  • platform/mac-leopard/svg/batik/masking/maskRegions-expected.checksum: Added.

...

4:38 AM Changeset in webkit [69291] by vestbo@webkit.org
  • 2 edits in trunk/WebCore

[Qt] Disconnect signals before destroying MediaPlayerPrivateQt

Reviewed by Andreas Kling.

https://bugs.webkit.org/show_bug.cgi?id=47073

  • platform/graphics/qt/MediaPlayerPrivateQt.cpp:
4:34 AM Changeset in webkit [69290] by commit-queue@webkit.org
  • 3 edits in trunk/WebKit/gtk

2010-10-07 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Xan Lopez.

[GTK] Use draw signal instead of expose_event in DragClientGtk when building with gtk3
https://bugs.webkit.org/show_bug.cgi?id=47326

  • WebCoreSupport/DragClientGtk.cpp: (WebKit::dragIconWindowDrawCallback): (WebKit::DragClient::DragClient): (WebKit::DragClient::~DragClient): (WebKit::DragClient::startDrag): (WebKit::DragClient::dragIconWindowDraw):
  • WebCoreSupport/DragClientGtk.h:
4:17 AM Changeset in webkit [69289] by Simon Hausmann
  • 2 edits in trunk

[Qt] Re-enable the web inspector for maemo6 builds

Rubber-stamped by Tor Arne Vestbø.

Yeah, it's strange :), but they really want it.

  • WebKit.pri:
4:14 AM Changeset in webkit [69288] by Nikolas Zimmermann
  • 1 edit
    302 deletes in trunk/LayoutTests

2010-10-07 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed.

Deduplicate some resuts of my last baseline recreations.

  • platform/mac-leopard/svg/W3C-SVG-1.1/animate-elem-03-t-expected.txt: Removed.
  • platform/mac-leopard/svg/W3C-SVG-1.1/animate-elem-08-t-expected.txt: Removed.

...

4:09 AM Changeset in webkit [69287] by apavlov@chromium.org
  • 3 edits in trunk/WebCore

2010-10-07 Alexander Pavlov <apavlov@chromium.org>

Unreviewed, release build fix.

  • inspector/InspectorStyleSheet.cpp: (WebCore::InspectorStyleSheetForInlineStyle::setStyleText):
  • inspector/InspectorStyleSheet.h: (WebCore::InspectorStyleSheetForInlineStyle::styleForId): (WebCore::InspectorStyleSheetForInlineStyle::ruleSourceDataFor):
3:37 AM Changeset in webkit [69286] by podivilov@chromium.org
  • 3 edits in trunk/WebCore

2010-10-07 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, build fix.

Build fix for r69283.

  • dom/Document.cpp: (WebCore::Document::inspectorController):
  • dom/Document.h:
2:55 AM Changeset in webkit [69285] by commit-queue@webkit.org
  • 4 edits in trunk

2010-10-07 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Xan Lopez.

[GTK] Fix the build for GTK+ 3
https://bugs.webkit.org/show_bug.cgi?id=47249

Don't use gtk_size_request_get_size(). It has been removed,
gtk_widget_get_preferred_size() should be used instead

  • platform/gtk/PopupMenuGtk.cpp: (WebCore::PopupMenuGtk::show):

2010-10-07 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Xan Lopez.

[GTK] Fix the build for GTK+ 3
https://bugs.webkit.org/show_bug.cgi?id=47249

Don't use gtk_size_request_get_size(). It has been removed,
gtk_widget_get_preferred_size() should be used instead

  • webkit/webkitwebview.cpp: (PopupMenuPositionFunc):
2:53 AM Changeset in webkit [69284] by apavlov@chromium.org
  • 9 edits
    6 adds in trunk/WebCore

2010-10-06 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Implement handling of CSS operations in InspectorCSSAgent.
Property toggling not implemented yet. The code is not going live.
https://bugs.webkit.org/show_bug.cgi?id=45825

  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/InspectorCSSAgent.cpp: Added. (WebCore::InspectorCSSAgent::buildObjectForStyle): (WebCore::InspectorCSSAgent::parentStyleSheet): (WebCore::InspectorCSSAgent::asCSSStyleRule): (WebCore::InspectorCSSAgent::InspectorCSSAgent): (WebCore::InspectorCSSAgent::~InspectorCSSAgent): (WebCore::InspectorCSSAgent::reset): (WebCore::InspectorCSSAgent::getMatchedRulesForNode2): (WebCore::InspectorCSSAgent::getMatchedPseudoRulesForNode2): (WebCore::InspectorCSSAgent::getAttributeStylesForNode2): (WebCore::InspectorCSSAgent::getInlineStyleForNode2): (WebCore::InspectorCSSAgent::getComputedStyleForNode2): (WebCore::InspectorCSSAgent::getInheritedStylesForNode2): (WebCore::InspectorCSSAgent::getAllStyles2): (WebCore::InspectorCSSAgent::getStyleSheet2): (WebCore::InspectorCSSAgent::setStyleSheetText2): (WebCore::InspectorCSSAgent::setStyleText2): (WebCore::InspectorCSSAgent::toggleProperty2): (WebCore::InspectorCSSAgent::setRuleSelector2): (WebCore::InspectorCSSAgent::addRule2): (WebCore::InspectorCSSAgent::getSupportedCSSProperties): (WebCore::InspectorCSSAgent::inlineStyleElement): (WebCore::InspectorCSSAgent::populateObjectWithStyleProperties): (WebCore::InspectorCSSAgent::shorthandValue): (WebCore::InspectorCSSAgent::shorthandPriority): (WebCore::InspectorCSSAgent::longhandProperties): (WebCore::InspectorCSSAgent::asInspectorStyleSheet): (WebCore::InspectorCSSAgent::elementForId): (WebCore::InspectorCSSAgent::bindStyleSheet): (WebCore::InspectorCSSAgent::viaInspectorStyleSheet): (WebCore::InspectorCSSAgent::styleSheetForId): (WebCore::InspectorCSSAgent::detectOrigin): (WebCore::InspectorCSSAgent::buildArrayForRuleList): (WebCore::InspectorCSSAgent::buildObjectForAttributeStyles): (WebCore::InspectorCSSAgent::didRemoveDocument): (WebCore::InspectorCSSAgent::didRemoveDOMNode):
  • inspector/InspectorCSSAgent.h: Added. (WebCore::InspectorCSSAgent::create):
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::InspectorDOMAgent): (WebCore::InspectorDOMAgent::setDOMListener): (WebCore::InspectorDOMAgent::unbind): (WebCore::InspectorDOMAgent::didRemoveDOMNode): (WebCore::InspectorDOMAgent::getSupportedCSSProperties):
  • inspector/InspectorDOMAgent.h: (WebCore::InspectorDOMAgent::DOMListener::~DOMListener): (WebCore::InspectorDOMAgent::documents):
  • inspector/InspectorStyleSheet.cpp: Added. (ParsedStyleSheet::cssStyleSheet): (ParsedStyleSheet::text): (ParsedStyleSheet::hasText): (ParsedStyleSheet::sourceData): (ParsedStyleSheet::hasSourceData): (ParsedStyleSheet::ParsedStyleSheet): (ParsedStyleSheet::setText): (ParsedStyleSheet::setSourceData): (ParsedStyleSheet::ruleSourceDataAt): (WebCore::InspectorStyleSheet::InspectorStyleSheet): (WebCore::InspectorStyleSheet::~InspectorStyleSheet): (WebCore::InspectorStyleSheet::setText): (WebCore::InspectorStyleSheet::setRuleSelector): (WebCore::InspectorStyleSheet::addRule): (WebCore::InspectorStyleSheet::ruleForId): (WebCore::InspectorStyleSheet::buildObjectForStyleSheet): (WebCore::InspectorStyleSheet::buildObjectForRule): (WebCore::InspectorStyleSheet::buildObjectForStyle): (WebCore::InspectorStyleSheet::styleForId): (WebCore::InspectorStyleSheet::setStyleText): (WebCore::InspectorStyleSheet::ownerDocument): (WebCore::InspectorStyleSheet::ruleSourceDataFor): (WebCore::InspectorStyleSheet::ruleIndexByStyle): (WebCore::InspectorStyleSheet::ensureParsedDataReady): (WebCore::InspectorStyleSheet::text): (WebCore::InspectorStyleSheet::ensureText): (WebCore::InspectorStyleSheet::ensureSourceData): (WebCore::InspectorStyleSheet::innerSetStyleSheetText): (WebCore::InspectorStyleSheet::innerSetStyleText): (WebCore::InspectorStyleSheet::styleSheetTextWithChangedStyle): (WebCore::InspectorStyleSheet::findPageRuleWithStyle): (WebCore::InspectorStyleSheet::fullRuleId): (WebCore::InspectorStyleSheet::revalidateStyle): (WebCore::InspectorStyleSheet::styleSheetText): (WebCore::InspectorStyleSheet::resourceStyleSheetText): (WebCore::InspectorStyleSheet::inlineStyleSheetText): (WebCore::InspectorStyleSheet::buildArrayForRuleList): (WebCore::InspectorStyleSheetForInlineStyle::InspectorStyleSheetForInlineStyle): (WebCore::InspectorStyleSheetForInlineStyle::setStyleText): (WebCore::InspectorStyleSheetForInlineStyle::ownerDocument): (WebCore::InspectorStyleSheetForInlineStyle::ensureParsedDataReady): (WebCore::InspectorStyleSheetForInlineStyle::inlineStyle): (WebCore::InspectorStyleSheetForInlineStyle::getStyleAttributeRanges):
  • inspector/InspectorStyleSheet.h: Added. (WebCore::InspectorStyleSheet::create): (WebCore::InspectorStyleSheet::id): (WebCore::InspectorStyleSheet::pageStyleSheet): (WebCore::InspectorStyleSheet::canBind): (WebCore::InspectorStyleSheet::fullRuleOrStyleId): (WebCore::InspectorStyleSheet::ruleOrStyleId): (WebCore::InspectorStyleSheet::fullStyleId): (WebCore::InspectorStyleSheetForInlineStyle::create): (WebCore::InspectorStyleSheetForInlineStyle::styleForId): (WebCore::InspectorStyleSheetForInlineStyle::ruleSourceDataFor): (WebCore::InspectorStyleSheetForInlineStyle::ruleIndexByStyle):
  • inspector/InspectorUtilities.cpp: Added. (WebCore::InspectorUtilities::resourceContentForURL):
  • inspector/InspectorUtilities.h: Added.
2:43 AM Changeset in webkit [69283] by podivilov@chromium.org
  • 27 edits in trunk/WebCore

2010-10-05 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: extract Inspector Instrumentation API as a class
https://bugs.webkit.org/show_bug.cgi?id=47173

  • bindings/js/JSXMLHttpRequestCustom.cpp: (WebCore::JSXMLHttpRequest::send):
  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::evaluateInWorld):
  • bindings/v8/V8DOMWindowShell.cpp:
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::evaluate): (WebCore::V8Proxy::callFunction):
  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp: (WebCore::V8XMLHttpRequest::sendCallback):
  • dom/Document.cpp: (WebCore::Document::recalcStyle):
  • dom/Document.h:
  • dom/Node.cpp: (WebCore::Node::dispatchGenericEvent):
  • html/parser/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::pumpTokenizer):
  • html/parser/HTMLDocumentParser.h:
  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::hasFrontend): (WebCore::InspectorInstrumentation::retrieveTimelineAgent):
  • inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::hasFrontends): (WebCore::InspectorInstrumentation::inspectorControllerForContext): (WebCore::InspectorInstrumentation::inspectorControllerForDocument): (WebCore::InspectorInstrumentation::inspectorControllerForFrame): (WebCore::InspectorInstrumentation::inspectorControllerForPage):
  • inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::InspectorTimelineAgent): (WebCore::InspectorTimelineAgent::~InspectorTimelineAgent):
  • inspector/InspectorTimelineAgent.h:
  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::didReceiveResponse): (WebCore::ResourceLoader::didReceiveData):
  • loader/loader.cpp: (WebCore::Loader::load):
  • page/DOMTimer.cpp: (WebCore::DOMTimer::install): (WebCore::DOMTimer::removeById): (WebCore::DOMTimer::fired):
  • page/DOMTimer.h:
  • page/DOMWindow.cpp: (WebCore::DOMWindow::dispatchEvent):
  • page/DOMWindow.h:
  • page/FrameView.cpp: (WebCore::FrameView::layout): (WebCore::FrameView::paintContents):
  • page/FrameView.h:
  • page/Page.cpp:
  • page/Page.h:
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::paintContents):
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::callReadyStateChangeListener):
2:11 AM Changeset in webkit [69282] by Simon Hausmann
  • 2 edits in trunk/WebCore

Windowless flash plugin is not rendered in Symbian
https://bugs.webkit.org/show_bug.cgi?id=47172

Patch by Zraly Mike <mike.zraly@nokia.com> on 2010-10-07
Reviewed by Andreas Kling.

  • plugins/symbian/PluginViewSymbian.cpp:

(WebCore::PluginView::platformStart):
Add call to updatePluginWidget() following changes to
platform widget. This is needed to set PluginView's
m_windowRect and m_clipRect members properly after
the proxy widget and its container get created.

2:05 AM Changeset in webkit [69281] by andreas.kling@nokia.com
  • 1855 edits in trunk/LayoutTests

2010-10-06 Andreas Kling <andreas.kling@nokia.com>

Unreviewed, s/RenderPath/RenderSVGPath/
Changeset 2 of 2

1:35 AM Changeset in webkit [69280] by andreas.kling@nokia.com
  • 1132 edits in trunk/LayoutTests

2010-10-06 Andreas Kling <andreas.kling@nokia.com>

Unreviewed, s/RenderPath/RenderSVGPath/
Changeset 1 of 2, since the SVN server keeps 500'ing on me during commit.

12:33 AM Changeset in webkit [69279] by andreas.kling@nokia.com
  • 28 edits
    2 moves in trunk/WebCore

2010-10-07 Andreas Kling <kling@webkit.org>

Reviewed by Nikolas Zimmermann.

Rename (and move) RenderPath to svg/RenderSVGPath
https://bugs.webkit.org/show_bug.cgi?id=47053

Also renamed RenderObject::isRenderPath() to isSVGPath()

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.order:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • rendering/RenderObject.h: (WebCore::RenderObject::isSVGPath):
  • rendering/RenderPath.cpp: Removed.
  • rendering/RenderPath.h: Removed.
  • rendering/RenderSVGHiddenContainer.cpp:
  • rendering/RenderSVGResourceClipper.cpp: (WebCore::RenderSVGResourceClipper::drawContentIntoMaskImage): (WebCore::RenderSVGResourceClipper::calculateClipContentRepaintRect): (WebCore::RenderSVGResourceClipper::hitTestClipContent):
  • rendering/RenderSVGResourceContainer.cpp: (WebCore::RenderSVGResourceContainer::transformOnNonScalingStroke):
  • rendering/RenderSVGResourceSolidColor.cpp: (WebCore::RenderSVGResourceSolidColor::postApplyResource):
  • rendering/RenderTreeAsText.cpp: (WebCore::write):
  • rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderSupport::layoutChildren):
  • rendering/SVGRenderTreeAsText.cpp: (WebCore::writeStyle): (WebCore::operator<<): (WebCore::write):
  • rendering/SVGRenderTreeAsText.h:
  • rendering/style/SVGRenderStyle.cpp: (WebCore::SVGRenderStyle::diff):
  • rendering/svg/RenderSVGPath.cpp: Copied from WebCore/rendering/RenderPath.cpp. (WebCore::RenderSVGPath::RenderSVGPath): (WebCore::RenderSVGPath::fillContains): (WebCore::RenderSVGPath::strokeContains): (WebCore::RenderSVGPath::layout): (WebCore::RenderSVGPath::fillAndStrokePath): (WebCore::RenderSVGPath::paint): (WebCore::RenderSVGPath::addFocusRingRects): (WebCore::RenderSVGPath::nodeAtFloatPoint): (WebCore::RenderSVGPath::calculateMarkerBoundsIfNeeded): (WebCore::RenderSVGPath::updateCachedBoundaries):
  • rendering/svg/RenderSVGPath.h: Copied from WebCore/rendering/RenderPath.h. (WebCore::RenderSVGPath::isSVGPath): (WebCore::RenderSVGPath::renderName): (WebCore::toRenderSVGPath):
  • svg/SVGCircleElement.cpp: (WebCore::SVGCircleElement::svgAttributeChanged):
  • svg/SVGEllipseElement.cpp: (WebCore::SVGEllipseElement::svgAttributeChanged):
  • svg/SVGGradientElement.cpp:
  • svg/SVGLineElement.cpp: (WebCore::SVGLineElement::svgAttributeChanged):
  • svg/SVGPathElement.cpp: (WebCore::SVGPathElement::svgAttributeChanged):
  • svg/SVGPolyElement.cpp: (WebCore::SVGPolyElement::svgAttributeChanged):
  • svg/SVGRectElement.cpp: (WebCore::SVGRectElement::svgAttributeChanged):
  • svg/SVGStyledLocatableElement.cpp:
  • svg/SVGStyledTransformableElement.cpp: (WebCore::SVGStyledTransformableElement::createRenderer):

Oct 6, 2010:

11:57 PM Changeset in webkit [69278] by alex
  • 2 edits in trunk/LayoutTests

2010-10-06 Alejandro G. Castro <alex@igalia.com>

Unreviewed, update GTK+ expected results.

  • platform/gtk/svg/css/getComputedStyle-basic-expected.txt:
11:57 PM Changeset in webkit [69277] by cevans@google.com
  • 5 edits in trunk/JavaScriptCore

2010-10-06 Chris Evans <cevans@google.com>

Reviewed by David Levin.

https://bugs.webkit.org/show_bug.cgi?id=47248

Use size_t consistently in CString, to prevent theoretical trouble
with > 4GB strings on 64-bit platforms.

  • wtf/text/CString.h:
  • wtf/text/CString.cpp: Use size_t for string lengths.
  • wtf/MD5.cpp: (WTF::expectMD5): use suitable format string + cast for size_t.
  • JavaScriptCore.exp: Update symbol name.
11:42 PM Changeset in webkit [69276] by yurys@chromium.org
  • 4 edits in trunk/WebCore

2010-10-06 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: clear line highlight when switching current view
https://bugs.webkit.org/show_bug.cgi?id=47262

  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype.clearLineHighlight):
  • inspector/front-end/SourceView.js: (WebInspector.SourceView.prototype.hide):
  • inspector/front-end/TextViewer.js: (WebInspector.TextViewer.prototype.highlightLine): (WebInspector.TextViewer.prototype.clearLineHighlight):
10:42 PM Changeset in webkit [69275] by cevans@google.com
  • 2 edits in trunk/WebCore

2010-10-06 Chris Evans <cevans@google.com>

Reviewed by David Levin.

https://bugs.webkit.org/show_bug.cgi?id=47313

Fix integer errors with enormous input strings to newline normalization APIs.

  • platform/text/LineEnding.cpp: (WebCore::normalizeLineEndingsToCRLF): return the empty string upon huge input strings. (Behaves similarly to base64Encode now). (WebCore::normalizeToCROrLF): use the correct type for a string length.
10:31 PM Changeset in webkit [69274] by commit-queue@webkit.org
  • 9 edits in trunk

2010-10-06 Chris Guillory <chris.guillory@google.com>

Reviewed by Chris Fleizach.

Remove unused accessibility functions from webkit.
https://bugs.webkit.org/attachment.cgi?bugid=46707

  • public/WebAccessibilityCache.h:
  • public/WebViewClient.h:
  • src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::focusedNodeChanged):
  • src/WebAccessibilityCacheImpl.cpp:
  • src/WebAccessibilityCacheImpl.h:

2010-10-06 Chris Guillory <chris.guillory@google.com>

Reviewed by Chris Fleizach.

Remove unused accessibility functions from webkit.
https://bugs.webkit.org/attachment.cgi?bugid=46707

  • DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::postAccessibilityNotification):
  • DumpRenderTree/chromium/WebViewHost.h:
10:23 PM Changeset in webkit [69273] by tkent@chromium.org
  • 4 edits in trunk/WebCore

2010-10-06 Kent Tamura <tkent@chromium.org>

Unreviewed, build fix.

Windows build fix for r69272.

  • html/BaseDateAndTimeInputType.cpp: (WebCore::BaseDateAndTimeInputType::stepBase): Use defaultStepBase() instead of defaultStepBase.
  • html/InputType.h: (WebCore::InputType::defaultStepBase): Make defaultStepBase static function.
  • html/NumberInputType.cpp: (WebCore::NumberInputType::stepBase): Use defaultStepBase() instead of defaultStepBase.
9:49 PM Changeset in webkit [69272] by tkent@chromium.org
  • 23 edits in trunk/WebCore

2010-10-06 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

Refactor HTMLInputElement: Move range/step related functions
https://bugs.webkit.org/show_bug.cgi?id=47251

Move the content of the following functions:

  • rangeUnderflow()
  • rangeOverflow()
  • minimum()
  • maximum()
  • stepMismatch()
  • stepBase()

getStepParameters() was split into InputType::defaultStep() and
stepScaleFactor().

  • html/BaseDateAndTimeInputType.cpp: (WebCore::BaseDateAndTimeInputType::rangeUnderflow): (WebCore::BaseDateAndTimeInputType::rangeOverflow): (WebCore::BaseDateAndTimeInputType::stepMismatch): (WebCore::BaseDateAndTimeInputType::stepBase):
  • html/BaseDateAndTimeInputType.h:
  • html/DateInputType.cpp: (WebCore::DateInputType::minimum): (WebCore::DateInputType::maximum): (WebCore::DateInputType::defaultStep): (WebCore::DateInputType::stepScaleFactor): (WebCore::DateInputType::parsedStepValueShouldBeInteger):
  • html/DateInputType.h:
  • html/DateTimeInputType.cpp: (WebCore::DateTimeInputType::minimum): (WebCore::DateTimeInputType::maximum): (WebCore::DateTimeInputType::defaultStep): (WebCore::DateTimeInputType::stepScaleFactor): (WebCore::DateTimeInputType::scaledStepValeuShouldBeInteger):
  • html/DateTimeInputType.h:
  • html/DateTimeLocalInputType.cpp: (WebCore::DateTimeLocalInputType::minimum): (WebCore::DateTimeLocalInputType::maximum): (WebCore::DateTimeLocalInputType::defaultStep): (WebCore::DateTimeLocalInputType::stepScaleFactor): (WebCore::DateTimeLocalInputType::scaledStepValeuShouldBeInteger):
  • html/DateTimeLocalInputType.h:
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::rangeUnderflow): (WebCore::HTMLInputElement::rangeOverflow): (WebCore::HTMLInputElement::minimum): (WebCore::HTMLInputElement::maximum): (WebCore::HTMLInputElement::stepMismatch): (WebCore::HTMLInputElement::getAllowedValueStep): (WebCore::HTMLInputElement::applyStep): (WebCore::HTMLInputElement::handleKeyEventForRange): (WebCore::HTMLInputElement::stepUpFromRenderer):
  • html/HTMLInputElement.h:
  • html/InputType.cpp: (WebCore::InputType::patternMismatch): (WebCore::InputType::rangeUnderflow): (WebCore::InputType::rangeOverflow): (WebCore::InputType::minimum): (WebCore::InputType::maximum): (WebCore::InputType::stepMismatch): (WebCore::InputType::stepBase): (WebCore::InputType::defaultStep): (WebCore::InputType::stepScaleFactor): (WebCore::InputType::parsedStepValueShouldBeInteger): (WebCore::InputType::scaledStepValeuShouldBeInteger):
  • html/InputType.h:
  • html/MonthInputType.cpp: (WebCore::MonthInputType::minimum): (WebCore::MonthInputType::maximum): (WebCore::MonthInputType::defaultStep): (WebCore::MonthInputType::stepScaleFactor): (WebCore::MonthInputType::parsedStepValueShouldBeInteger):
  • html/MonthInputType.h:
  • html/NumberInputType.cpp: (WebCore::NumberInputType::rangeUnderflow): (WebCore::NumberInputType::rangeOverflow): (WebCore::NumberInputType::minimum): (WebCore::NumberInputType::maximum): (WebCore::NumberInputType::stepMismatch): (WebCore::NumberInputType::stepBase): (WebCore::NumberInputType::defaultStep): (WebCore::NumberInputType::stepScaleFactor):
  • html/NumberInputType.h:
  • html/RangeInputType.cpp: (WebCore::RangeInputType::rangeUnderflow): (WebCore::RangeInputType::rangeOverflow): (WebCore::RangeInputType::minimum): (WebCore::RangeInputType::maximum): (WebCore::RangeInputType::stepMismatch): (WebCore::RangeInputType::stepBase): (WebCore::RangeInputType::defaultStep): (WebCore::RangeInputType::stepScaleFactor):
  • html/RangeInputType.h:
  • html/TimeInputType.cpp: (WebCore::TimeInputType::minimum): (WebCore::TimeInputType::maximum): (WebCore::TimeInputType::defaultStep): (WebCore::TimeInputType::stepScaleFactor): (WebCore::TimeInputType::scaledStepValeuShouldBeInteger):
  • html/TimeInputType.h:
  • html/WeekInputType.cpp: (WebCore::WeekInputType::minimum): (WebCore::WeekInputType::maximum): (WebCore::WeekInputType::stepBase): (WebCore::WeekInputType::defaultStep): (WebCore::WeekInputType::stepScaleFactor): (WebCore::WeekInputType::parsedStepValueShouldBeInteger):
  • html/WeekInputType.h:
9:46 PM Changeset in webkit [69271] by tkent@chromium.org
  • 2 edits
    7 adds in trunk/LayoutTests

2010-10-06 Kent Tamura <tkent@chromium.org>

Unreviewed, test expectation update.

Add expectations for r69269 and r69270.

  • platform/chromium-linux/fast/css/first-letter-punctuation-expected.checksum: Added.
  • platform/chromium-linux/fast/css/first-letter-punctuation-expected.png: Added.
  • platform/chromium-mac/fast/css/first-letter-punctuation-expected.checksum: Added.
  • platform/chromium-mac/fast/css/first-letter-punctuation-expected.png: Added.
  • platform/chromium-win/fast/css/first-letter-punctuation-expected.checksum: Added.
  • platform/chromium-win/fast/css/first-letter-punctuation-expected.png: Added.
  • platform/chromium-win/fast/css/first-letter-punctuation-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
7:37 PM Changeset in webkit [69270] by Simon Fraser
  • 3 edits
    4 adds in trunk

2010-10-06 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein, Darin Adler.

:first-letter should apply to "punctuation" after the first letter
https://bugs.webkit.org/show_bug.cgi?id=45986

Follow the CSS 2.1 spec by allow certain kinds of punctuation before and after
the :first-letter character.

The spec does not describe whitespace behavior, and browsers are inconsistent.
This patch allows whitespace (including non-breaking spaces) before and after the
leading punctuation, and before the trailing punctuation.

Test: fast/css/first-letter-punctuation.html

  • rendering/RenderBlock.cpp: (WebCore::isPunctuationForFirstLetter): (WebCore::shouldSkipForFirstLetter): (WebCore::RenderBlock::updateFirstLetter):
7:09 PM Changeset in webkit [69269] by commit-queue@webkit.org
  • 5 edits
    16 adds in trunk/LayoutTests

2010-10-06 Jia Pu <jpu@apple.com>

Reviewed by Adele Peterson.

Add regression tests for autocorrection panel
https://bugs.webkit.org/show_bug.cgi?id=47308
<rdar://problem/8521243>

Added regression tests for recently added autocorrection panel on Mac platform, as implemented in <https://bugs.webkit.org/show_bug.cgi?id=44958>.

  • editing/spelling/autocorrection-delete.html: Added.
  • editing/spelling/autocorrection-removing-underline-after-paste.html: Added.
  • editing/spelling/autocorrection-removing-underline.html: Added.
  • editing/spelling/autocorrection-simple.html: Added.
  • platform/mac-leopard/Skipped:
  • platform/mac-snowleopard/Skipped:
  • platform/mac-tiger/Skipped:
  • platform/mac-wk2/Skipped:
  • platform/mac/editing/spelling/autocorrection-delete-expected.checksum: Added.
  • platform/mac/editing/spelling/autocorrection-delete-expected.png: Added.
  • platform/mac/editing/spelling/autocorrection-delete-expected.txt: Added.
  • platform/mac/editing/spelling/autocorrection-removing-underline-after-paste-expected.checksum: Added.
  • platform/mac/editing/spelling/autocorrection-removing-underline-after-paste-expected.png: Added.
  • platform/mac/editing/spelling/autocorrection-removing-underline-after-paste-expected.txt: Added.
  • platform/mac/editing/spelling/autocorrection-removing-underline-expected.checksum: Added.
  • platform/mac/editing/spelling/autocorrection-removing-underline-expected.png: Added.
  • platform/mac/editing/spelling/autocorrection-removing-underline-expected.txt: Added.
  • platform/mac/editing/spelling/autocorrection-simple-expected.checksum: Added.
  • platform/mac/editing/spelling/autocorrection-simple-expected.png: Added.
  • platform/mac/editing/spelling/autocorrection-simple-expected.txt: Added.
6:42 PM Changeset in webkit [69268] by commit-queue@webkit.org
  • 3 edits in trunk/WebCore

2010-10-06 Sanjeev Radhakrishnan <sanjeevr@chromium.org>

Reviewed by Darin Fisher.

Released the pluginNode in PluginDocument::detach() and prevents a memory leak.
https://bugs.webkit.org/show_bug.cgi?id=47129

  • html/PluginDocument.cpp: (WebCore::PluginDocument::detach):
  • html/PluginDocument.h:
6:30 PM Changeset in webkit [69267] by jamesr@google.com
  • 3 edits in branches/chromium/517/WebCore

Revert code changes of WebKit r67261 on the 517 branch, caused regressions. BUG=56150 TBR=pkasting

6:26 PM Changeset in webkit [69266] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-10-06 Vincent Scheib <scheib@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Thumbnail generation asserts on zero alpha values.
https://bugs.webkit.org/show_bug.cgi?id=47292

Test: Tested manually by running debug mode, and analyzing in PIX.

  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::drawLayers):
6:18 PM Changeset in webkit [69265] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2010-10-06 Adam Barth <abarth@webkit.org>

Reviewed by Simon Fraser.

compositing/geometry/limit-layer-bounds-transformed-overflow.html is flakey
https://bugs.webkit.org/show_bug.cgi?id=46912

This test is the flakiest test of all because sometimes it doesn't show
that it's using tiled layering. It seems likely that the compositor
state just hasn't synced all the time. This patch adds an explicit
display() call to force the compositor state to sync. Hopefully it
will make the test non-flaky.

  • compositing/geometry/limit-layer-bounds-transformed-overflow.html:
6:06 PM Changeset in webkit [69264] by commit-queue@webkit.org
  • 2 edits in trunk/WebKitTools

2010-10-06 Lucas Forschler <Lucas Forschler>

Reviewed by Adam Roben.

Fix the sunspider-compare-results to actually use the passed in value for $root.

  • Scripts/sunspider-compare-results:
5:43 PM Changeset in webkit [69263] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2010-10-06 Adam Barth <abarth@webkit.org>

Update expected results. I think this should have been part of Hyatt's
patch, but I'll confirm with him via bugs.webkit.org.

  • platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
5:39 PM Changeset in webkit [69262] by kinuko@chromium.org
  • 3 edits in trunk/WebCore

2010-10-06 Kinuko Yasuda <kinuko@chromium.org>

Unreviewed, trying to fix chromium Windows build.

Explicitly give the parameter value that has a default parameter value.

  • page/DOMWindow.cpp: (WebCore::DOMWindow::requestFileSystem):
  • workers/WorkerContext.cpp: (WebCore::WorkerContext::requestFileSystem):
5:34 PM Changeset in webkit [69261] by Darin Adler
  • 3 edits in trunk/WebCore

Try to fix Windows build.

  • platform/graphics/cg/ColorCG.cpp:

(WebCore::cachedCGColor): Put in braces to make the Windows compiler
happy with this file.

  • platform/graphics/cg/ImageCG.cpp: Added include of RetainPtr.h.
5:19 PM Changeset in webkit [69260] by ajwong@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed. Build fix.

Cleaning up test_expectations, and marking more failures.

  • platform/chromium/test_expectations.txt:
5:15 PM Changeset in webkit [69259] by Darin Adler
  • 14 edits
    1 add in trunk/WebCore

2010-10-06 Darin Adler <Darin Adler>

Reviewed by Alexey Proskuryakov.

Cache CGColor as we do NSColor
https://bugs.webkit.org/show_bug.cgi?id=47226

This fixes performance problems on certain web pages that use
multiple colors. Once in the past we were using NSColor. Now that
we are using CGColor, we need the same sort of caching that we have
for NSColor.

One example: <http://results.active.com/uploads/html/100759.html>.

  • WebCore.xcodeproj/project.pbxproj: Add GraphicsContextCG.h.
  • platform/graphics/Color.h: Replace createCGColor with cachedCGColor.
  • platform/graphics/cg/ColorCG.cpp: (WebCore::cachedCGColorSpace): Added. (WebCore::leakCGColor): Added. (WebCore::cachedCGColor): Added.
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::setCGFillColor): Use cachedCGColor. (WebCore::setCGStrokeColor): Ditto. (WebCore::GraphicsContext::fillRect): Ditto. (WebCore::GraphicsContext::setPlatformShadow): Ditto.
  • platform/graphics/cg/GraphicsContextCG.h: Added.
  • platform/graphics/cg/GraphicsContextPlatformPrivateCG.h: Moved the color space functions here.
  • platform/graphics/cg/ImageCG.cpp: Tweaked headers and formatting.
  • platform/graphics/mac/ColorMac.mm: Removed the createCGColor function.
  • platform/graphics/mac/GraphicsContextMac.mm: (WebCore::drawFocusRingToContext): Removed innappropriate use of RetainPtr for the arguments to this function. (WebCore::GraphicsContext::drawFocusRing): Use cachedCGColor.
  • platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::setLayerBorderColor): Use cachedCGColor. (WebCore::setLayerBackgroundColor): Ditto.
  • platform/graphics/win/GraphicsContextCGWin.cpp: (WebCore::GraphicsContext::drawFocusRing): Ditto.
  • platform/graphics/win/GraphicsLayerCACF.cpp: (WebCore::setLayerBorderColor): Ditto. (WebCore::setLayerBackgroundColor): Ditto.
  • platform/graphics/win/WKCACFLayerRenderer.cpp: (WebCore::WKCACFLayerRenderer::WKCACFLayerRenderer): Use CGColorCreateGenericRGB for color used only for debugging.
  • platform/graphics/win/WebTiledLayer.cpp: (WebCore::WebTiledLayer::addTile): Ditto.
5:05 PM Changeset in webkit [69258] by jamesr@google.com
  • 2 edits in branches/chromium/517/WebCore

Merge 69257 - 2010-10-06 Peter Kasting <pkasting@google.com>

Reviewed by James Robinson

ScrollViews without scrollbars should not eat scroll events
https://bugs.webkit.org/show_bug.cgi?id=47036

  • platform/ScrollView.cpp: (WebCore::ScrollView::wheelEvent):

TBR=jamesr@google.com
BUG=56063

Review URL: http://codereview.chromium.org/3552012

4:56 PM Changeset in webkit [69257] by jamesr@google.com
  • 2 edits in trunk/WebCore

2010-10-06 Peter Kasting <pkasting@google.com>

Reviewed by James Robinson

ScrollViews without scrollbars should not eat scroll events
https://bugs.webkit.org/show_bug.cgi?id=47036

  • platform/ScrollView.cpp: (WebCore::ScrollView::wheelEvent):
4:52 PM Changeset in webkit [69256] by dbates@webkit.org
  • 3 edits
    2 adds in trunk

2010-10-06 Daniel Bates <dbates@rim.com>

Reviewed by Darin Adler.

ASSERTION FAILURE: Attempt to cast RenderObject to RenderFrameSet
when <frameset> has CSS content property
https://bugs.webkit.org/show_bug.cgi?id=47314

Fixes an issue where sending a mouse event to an HTML Frameset Element that
whose content was replaced via the CSS content property causes an assertion
failure.

By default, HTMLFrameSetElement forwards mouse events to RenderFrameSet so as
to support resizing a frame within the set. When a <frameset> specifies an
image in its CSS content property we create a generic render object (RenderObject)
for the frame set instead of a RenderFrameSet object. The event handler code
in HTMLFrameSetElement calls WebCore::toRenderFrameSet() to cast its renderer
to type RenderFrameSet, which fails. To correct this, HTMLFrameSetElement
must check that its renderer is of type RenderFrameSet before casting to this type.

Test: fast/frames/crash-frameset-CSS-content-property.html

  • html/HTMLFrameSetElement.cpp: (WebCore::HTMLFrameSetElement::defaultEventHandler): Check that our renderer is of type RenderFrameSet before casting it as such.

2010-10-06 Daniel Bates <dbates@rim.com>

Reviewed by Darin Adler.

ASSERTION FAILURE: Attempt to cast RenderObject to RenderFrameSet
when <frameset> has CSS content property
https://bugs.webkit.org/show_bug.cgi?id=47314

Test to ensure that we don't crash when clicking on a <frameset> that specifies the CSS content property.

  • fast/frames/crash-frameset-CSS-content-property-expected.txt: Added.
  • fast/frames/crash-frameset-CSS-content-property.html: Added.
4:51 PM Changeset in webkit [69255] by ajwong@chromium.org
  • 2 edits in trunk/WebCore

r69181 breaks compilation of WebCore/platform/graphics/filters/FETile.cpp if ENABLE(SVG) is false.
https://bugs.webkit.org/show_bug.cgi?id=47315

Reviewed by Andreas Kling.

Compile fix. No tests.

  • platform/graphics/filters/FETile.cpp:

(WebCore::FETile::apply):

4:41 PM Changeset in webkit [69254] by Chris Fleizach
  • 3 edits in trunk/LayoutTests

Unreviewed. Try to make test pass on GTK and QT.

REGRESSION (r53857): AREA tag with tabindex="-1" displays focus ring after multiple mouse clicks.
https://bugs.webkit.org/show_bug.cgi?id=45832

  • fast/events/mouse-focus-imagemap-expected.txt:
  • fast/events/mouse-focus-imagemap.html:
4:28 PM Changeset in webkit [69253] by abecsi@webkit.org
  • 3 edits in trunk/WebKitTools

2010-10-06 Balazs Kelemen <kbalazs@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Runloop implementation for WTR
https://bugs.webkit.org/show_bug.cgi?id=47280

  • WebKitTestRunner/qt/TestControllerQt.cpp: Implemented TestController::runUntil by a timerEvent and a QEventLoop. We step into the event loop from runUntil. While we are waiting in the loop a timerEvent is periodically checking the value of the condition. Once the condition has becoming true the timerEvent wakes us up. (WTR::RunUntilLoop::start): (WTR::RunUntilLoop::RunUntilLoop): (WTR::RunUntilLoop::run): (WTR::RunUntilLoop::timerEvent): (WTR::TestController::platformInitialize): (WTR::TestController::runUntil):
  • WebKitTestRunner/qt/main.cpp: Start the main event loop first and creating the TestController later. (Launcher::Launcher): (Launcher::~Launcher): (Launcher::launch): Creating the TestController. (main): Setting up a timer for calling Launcher::launch from the main event loop.
4:24 PM Changeset in webkit [69252] by kinuko@chromium.org
  • 1 edit in trunk/WebCore/ChangeLog

2010-10-06 Kinuko Yasuda <kinuko@chromium.org>

Unreviewed, fixing screwed up ChangeLogs.

4:22 PM Changeset in webkit [69251] by andreip@google.com
  • 1 edit in trunk/WebCore/storage/IDBDatabase.cpp

[Chromium] Unreviewed build fix.

4:18 PM Changeset in webkit [69250] by dpranke@chromium.org
  • 5 edits in trunk

2010-10-06 Dirk Pranke <dpranke@chromium.org>

Reviewed by Kenneth Russell.

Add a "FIXME" to clarify that all of the tests are currently marked
"PASS FAIL" and hence we won't actually see any failures requiring
new baselines (only crashes or timeouts).

https://bugs.webkit.org/show_bug.cgi?id=47312

  • platform/chromium-gpu/test_expectations.txt:

2010-10-06 Dirk Pranke <dpranke@chromium.org>

Reviewed by Kenneth Russell.

new-run-webkit-tests: fix typo in chromium-gpu that was trying to
enable 'accelerated-composting' instead of 'accelerated-compositing'.

https://bugs.webkit.org/show_bug.cgi?id=47312

  • Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
  • Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
4:08 PM Changeset in webkit [69249] by kinuko@chromium.org
  • 53 edits
    9 adds
    1 delete in trunk

2010-10-06 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by David Levin.

Add FileSystemSync implementation for Worker
https://bugs.webkit.org/show_bug.cgi?id=47044

  • src/LocalFileSystemChromium.cpp: (WebCore::LocalFileSystem::requestFileSystem): Added a new parameter for synchronous mode.
  • src/WebFileSystemCallbacksImpl.cpp: (WebKit::WebFileSystemCallbacksImpl::WebFileSystemCallbacksImpl): Added a parameter for synchronous mode. (WebKit::WebFileSystemCallbacksImpl::didOpenFileSystem): Changed to creates WorkerAsyncFileSystemChromium with synchronous flag.
  • src/WebFileSystemCallbacksImpl.h:
  • src/WebWorkerBase.cpp: (WebKit::WebWorkerBase::openFileSystem): Added a parameter for synchronous mode.
  • src/WebWorkerBase.h:
  • src/WorkerAsyncFileSystemChromium.cpp: (WebCore::WorkerAsyncFileSystemChromium::WorkerAsyncFileSystemChromium): (WebCore::WorkerAsyncFileSystemChromium::waitForOperationToComplete): Added. (WebCore::WorkerAsyncFileSystemChromium::move): (WebCore::WorkerAsyncFileSystemChromium::copy): (WebCore::WorkerAsyncFileSystemChromium::remove): (WebCore::WorkerAsyncFileSystemChromium::readMetadata): (WebCore::WorkerAsyncFileSystemChromium::createFile): (WebCore::WorkerAsyncFileSystemChromium::createDirectory): (WebCore::WorkerAsyncFileSystemChromium::fileExists): (WebCore::WorkerAsyncFileSystemChromium::directoryExists): (WebCore::WorkerAsyncFileSystemChromium::readDirectory): (WebCore::WorkerAsyncFileSystemChromium::createWorkerFileSystemCallbacksBridge): Updated to store the created bridge in a member variable so that we can call bridge->stop() later when the RunLoop is terminating.
  • src/WorkerAsyncFileSystemChromium.h: (WebCore::WorkerAsyncFileSystemChromium::create): Added a new parameter for synchronous mode.

2010-10-06 Andrei Popescu <andreip@google.com>

Reviewed by Jeremy Orlow.

IDBDatabase and IDBObjectStore metadata is not recovered correctly when the setVersion transactions aborts.
https://bugs.webkit.org/show_bug.cgi?id=47245

Recover metadata properly by adding abort tasks that
are run when a transaction aborts.


  • storage/IDBDatabase.cpp: (WebCore::IDBDatabase::createObjectStore): (WebCore::IDBDatabase::removeObjectStore):
  • storage/IDBDatabaseBackendImpl.cpp: (WebCore::IDBDatabaseBackendImpl::createObjectStore): (WebCore::IDBDatabaseBackendImpl::removeObjectStore): (WebCore::IDBDatabaseBackendImpl::setVersion): (WebCore::IDBDatabaseBackendImpl::removeObjectStoreFromMap): (WebCore::IDBDatabaseBackendImpl::addObjectStoreToMap): (WebCore::IDBDatabaseBackendImpl::resetVersion):
  • storage/IDBDatabaseBackendImpl.h:
  • storage/IDBObjectStoreBackendImpl.cpp: (WebCore::IDBObjectStoreBackendImpl::createIndex): (WebCore::IDBObjectStoreBackendImpl::removeIndex): (WebCore::IDBObjectStoreBackendImpl::removeIndexFromMap): (WebCore::IDBObjectStoreBackendImpl::addIndexToMap):
  • storage/IDBObjectStoreBackendImpl.h:
  • storage/IDBTransactionBackendImpl.cpp: (WebCore::IDBTransactionBackendImpl::scheduleTask): (WebCore::IDBTransactionBackendImpl::abort):
  • storage/IDBTransactionBackendImpl.h:
  • storage/IDBTransactionBackendInterface.h:
  • storage/IDBTransactionCoordinator.h:

2010-10-06 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by David Levin.

Add FileSystemSync implementation for Worker
https://bugs.webkit.org/show_bug.cgi?id=47044

  • fast/filesystem/async-operations.html: Added.
  • fast/filesystem/resources/async-operations.js: Added.
  • fast/filesystem/resources/fs-worker-test-pre.js:
  • fast/filesystem/resources/sync-operations.js: Added.
  • fast/filesystem/script-tests/flags-passing.js:
  • fast/filesystem/workers/async-operations-expected.txt: Added.
  • fast/filesystem/workers/async-operations.html: Added.
  • fast/filesystem/workers/simple-persistent-sync-expected.txt:
  • fast/filesystem/workers/simple-temporary-sync-expected.txt:
  • fast/filesystem/workers/sync-operations-expected.txt: Added.
  • fast/filesystem/workers/sync-operations.html: Added.
4:00 PM Changeset in webkit [69248] by abecsi@webkit.org
  • 4 edits in trunk/WebKitTools

2010-10-06 Balazs Kelemen <kbalazs@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] PlatformWebView implementation for WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=47276

The implementation follows the way how
we use the API in MiniBrowser.

  • WebKitTestRunner/PlatformWebView.h:
  • WebKitTestRunner/qt/PlatformWebViewQt.cpp: (WTR::WebView::wkView): (WTR::WebView::~WebView): (WTR::WebView::WebView): (WTR::PlatformWebView::PlatformWebView): (WTR::PlatformWebView::~PlatformWebView): (WTR::PlatformWebView::resizeTo): (WTR::PlatformWebView::page): (WTR::PlatformWebView::focus):
  • WebKitTestRunner/qt/WebKitTestRunner.pro:
3:52 PM Changeset in webkit [69247] by andreip@google.com
  • 21 edits in trunk

2010-10-06 Andrei Popescu <andreip@google.com>

Reviewed by Jeremy Orlow.

IDBDatabase and IDBObjectStore metadata is not recovered correctly when the setVersion transactions aborts.
https://bugs.webkit.org/show_bug.cgi?id=47245

  • storage/indexeddb/database-basics-expected.txt:
  • storage/indexeddb/database-basics.html:
  • storage/indexeddb/objectstore-basics-expected.txt:
  • storage/indexeddb/objectstore-basics.html:
  • storage/indexeddb/resources/shared.js: (unexpectedAbortCallback): (unexpectedCompleteCallback): (deleteAllObjectStores):
  • storage/indexeddb/transaction-basics-expected.txt:
  • storage/indexeddb/transaction-basics.html:

2010-10-06 Andrei Popescu <andreip@google.com>

Reviewed by Jeremy Orlow.

IDBDatabase and IDBObjectStore metadata is not recovered correctly when the setVersion transactions aborts.
https://bugs.webkit.org/show_bug.cgi?id=47245

Recover metadata properly by adding abort tasks that
are run when a transaction aborts.

  • storage/IDBDatabase.cpp: (WebCore::IDBDatabase::createObjectStore): (WebCore::IDBDatabase::removeObjectStore):
  • storage/IDBDatabaseBackendImpl.cpp: (WebCore::IDBDatabaseBackendImpl::createObjectStore): (WebCore::IDBDatabaseBackendImpl::removeObjectStore): (WebCore::IDBDatabaseBackendImpl::setVersion): (WebCore::IDBDatabaseBackendImpl::removeObjectStoreFromMap): (WebCore::IDBDatabaseBackendImpl::addObjectStoreToMap): (WebCore::IDBDatabaseBackendImpl::resetVersion):
  • storage/IDBDatabaseBackendImpl.h:
  • storage/IDBObjectStoreBackendImpl.cpp: (WebCore::IDBObjectStoreBackendImpl::createIndex): (WebCore::IDBObjectStoreBackendImpl::removeIndex): (WebCore::IDBObjectStoreBackendImpl::removeIndexFromMap): (WebCore::IDBObjectStoreBackendImpl::addIndexToMap):
  • storage/IDBObjectStoreBackendImpl.h:
  • storage/IDBTransactionBackendImpl.cpp: (WebCore::IDBTransactionBackendImpl::scheduleTask): (WebCore::IDBTransactionBackendImpl::abort):
  • storage/IDBTransactionBackendImpl.h:
  • storage/IDBTransactionBackendInterface.h:
  • storage/IDBTransactionCoordinator.h:

2010-10-06 Andrei Popescu <andreip@google.com>

Reviewed by Jeremy Orlow.

IDBDatabase and IDBObjectStore metadata is not recovered correctly when the setVersion transactions aborts.
https://bugs.webkit.org/show_bug.cgi?id=47245

  • src/IDBTransactionBackendProxy.cpp: (WebCore::IDBTransactionBackendProxy::scheduleTask):
  • src/IDBTransactionBackendProxy.h:
3:48 PM Changeset in webkit [69246] by ajwong@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed. Build fix. Mark flaky tests.

  • platform/chromium/test_expectations.txt:
3:47 PM Changeset in webkit [69245] by andersca@apple.com
  • 3 edits in trunk/WebKit2

Separate actually calling the member function from decoding/encoding arguments
and remove any ambiguities when calling the function.

Reviewed by Sam Weinig.

  • Platform/CoreIPC/Arguments.h:
  • Platform/CoreIPC/HandleMessage.h:

(CoreIPC::callMemberFunction):
(CoreIPC::handleMessage):

3:43 PM Changeset in webkit [69244] by abecsi@webkit.org
  • 10 edits
    1 move
    6 adds in trunk

2010-10-06 Balazs Kelemen <kbalazs@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Add WebKitTestRunner's build files
https://bugs.webkit.org/show_bug.cgi?id=44155

Add the new subdirs.

  • DerivedSources.pro:
  • WebKit.pro:

2010-10-06 Balazs Kelemen <kbalazs@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Add WebKitTestRunner's build files
https://bugs.webkit.org/show_bug.cgi?id=44155

Parts was taken by Zoltan Horvath's patch.

  • Scripts/generate-forwarding-headers.pl: Moved from WebKit2.
  • Scripts/webkitdirs.pm: Make the generated files needed by WTR.
  • WebKitTestRunner/PlatformWebView.h: Addeed typedefs for PlatformWKView and PlatformWindow (void* for now). Buildfix the case when APPLE is not defined.
  • WebKitTestRunner/qt/DerivedSources.pro: Added.
  • WebKitTestRunner/qt/PlatformWebViewQt.cpp: Added. Empty stub implementation. (WTR::registerWindowClass): (WTR::PlatformWebView::PlatformWebView): (WTR::PlatformWebView::~PlatformWebView): (WTR::PlatformWebView::resizeTo): (WTR::PlatformWebView::page): (WTR::PlatformWebView::focus):
  • WebKitTestRunner/qt/TestControllerQt.cpp: Added. Empty stub implementation. (WTR::registerWindowClass): (WTR::TestController::runUntil): (WTR::TestController::platformInitialize): (WTR::TestController::initializeInjectedBundlePath): (WTR::TestController::initializeTestPluginDirectory): (WTR::TestController::platformInitializeContext):
  • WebKitTestRunner/qt/WebKitTestRunner.pro: Added.
  • WebKitTestRunner/qt/main.cpp: Added. (main):

2010-10-06 Balazs Kelemen <kbalazs@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Add WebKitTestRunner's build files
https://bugs.webkit.org/show_bug.cgi?id=44155

  • DerivedSources.pro: Changes according the new location of generate-forwarding-headers.pl.
  • UIProcess/API/C/WebKit2.h: Do not check the value of the APPLE define if it is not defined.
  • WebKit2.pro: Changes according the new location of generate-forwarding-headers.pl. Added missing files to the build that provides API that is used by WTR.
  • generate-forwarding-headers.pl: Moved to WebKitTools/Scripts since from now this is not only used by WebKit2.
3:33 PM Changeset in webkit [69243] by victorw@chromium.org
  • 4 edits
    2 adds in trunk/WebKit/chromium

2010-10-06 Victor Wang <victorw@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Add webkit unit tests to chromium multi-dll build.

In chromium multi-dll build mode, compile the webkit unit tests
code in webkit.dll and export an api that runs the tests.

https://bugs.webkit.org/show_bug.cgi?id=46907

  • WebKit.gyp:
  • WebKit.gypi:
  • tests/RunAllTests.cpp: (main):
  • tests/WebUnitTests.cpp: Added. (WebKit::RunAllUnitTests):
  • tests/WebUnitTests.h: Added.
3:30 PM Changeset in webkit [69242] by Chris Fleizach
  • 3 edits in trunk/LayoutTests

Unreviewed. Make test work on QT as well as other platforms.

REGRESSION (r53857): AREA tag with tabindex="-1" displays focus ring after multiple mouse clicks.
https://bugs.webkit.org/show_bug.cgi?id=45832

  • fast/events/mouse-focus-imagemap-expected.txt:
  • fast/events/mouse-focus-imagemap.html:
3:28 PM Changeset in webkit [69241] by ajwong@chromium.org
  • 3 edits
    7 adds in trunk

[chromium] Unreviewed. Rebaseline more tests.

Linux having similar SVG failures to windows. Revision r69226 added
http/tests/appcache/main-resource-redirect.html which does not work
on chromium yet.

  • platform/chromium-linux/fast/blockflow/fieldsets-expected.checksum: Added.
  • platform/chromium-linux/fast/blockflow/fieldsets-expected.png: Added.
  • platform/chromium-linux/svg/filters/feDisplacementMap-expected.checksum: Copied from LayoutTests/platform/chromium-win/svg/filters/feDisplacementMap-expected.checksum.
  • platform/chromium-linux/svg/filters/feDisplacementMap-expected.png: Copied from LayoutTests/platform/chromium-win/svg/filters/feDisplacementMap-expected.png.
  • platform/chromium-win/fast/blockflow/fieldsets-expected.checksum: Added.
  • platform/chromium-win/fast/blockflow/fieldsets-expected.png: Added.
  • platform/chromium-win/fast/blockflow/fieldsets-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
3:15 PM Changeset in webkit [69240] by andersca@apple.com
  • 5 edits in trunk/WebKit2

More Arguments.h cleanup.

Reviewed by Sam Weinig.

  • Platform/CoreIPC/Arguments.h:
  • Platform/CoreIPC/HandleMessage.h:

Remove unnecessary typedefs, simplify.

  • Scripts/webkit2/messages.py:
  • UIProcess/WebContext.h:

Fix clang++ build.

3:13 PM Changeset in webkit [69239] by hyatt@apple.com
  • 2 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=47306

Reviewed by Dan Bernstein.

Convert determineStart/EndPosition and matchedEndLine to be writing-mode-aware.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::determineStartPosition):
(WebCore::RenderBlock::determineEndPosition):
(WebCore::RenderBlock::matchedEndLine):

3:12 PM Changeset in webkit [69238] by fsamuel@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests/platform

Mac baseline for simple_paint.html. Updated test_expectations.

3:09 PM Changeset in webkit [69237] by Chris Fleizach
  • 6 edits
    2 adds in trunk

REGRESSION (r53857): AREA tag with tabindex="-1" displays focus ring after multiple mouse clicks.
https://bugs.webkit.org/show_bug.cgi?id=45832

Reviewed by Beth Dakin.

WebCore:

Test: fast/events/mouse-focus-imagemap.html

  • html/HTMLAreaElement.cpp:

(WebCore::HTMLAreaElement::isKeyboardFocusable):
(WebCore::HTMLAreaElement::isMouseFocusable):
(WebCore::HTMLAreaElement::isFocusable):
(WebCore::HTMLAreaElement::updateFocusAppearance):

  • html/HTMLAreaElement.h:

LayoutTests:

  • fast/events/mouse-focus-imagemap-expected.txt: Added.
  • fast/events/mouse-focus-imagemap.html: Added.
  • fast/events/resources/tabindex-focus-blur-all.js:

(testProgrammaticFocus):

  • fast/events/tabindex-focus-blur-all-expected.txt:

Update test to reflect that AREA with tabindex=-1 should not be focusable.

2:48 PM Changeset in webkit [69236] by andersca@apple.com
  • 6 edits in trunk

Start cleaning up Arguments.h
https://bugs.webkit.org/show_bug.cgi?id=47304

Reviewed by Sam Weinig.

JavaScriptCore:

  • wtf/TypeTraits.h:
  • wtf/TypeTraits.cpp:

Add RemoveReference type trait.

WebKit2:

This is a first step towards simplifying all the handleMessage overloads we have.

  • Platform/CoreIPC/Arguments.h:

(CoreIPC::Arguments1):
Make Arguments1 a struct and get rid of the FirstArgumentType typedef. Instead, add a
ValueType typedef which is defined to an Arguments1 type whose type parameter is not
a reference type.

  • Platform/CoreIPC/HandleMessage.h:

(CoreIPC::handleMessage):
Update for the Arguments1 change. Rename "arguments" to "argumentDecoder" and "reply" to
"replyEncoder".

2:44 PM Changeset in webkit [69235] by hyatt@apple.com
  • 5 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=47303

Reviewed by Dan Bernstein.

Convert layoutInlineChildren to be block-flow-aware. None of the functions it calls are patched yet.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlock):

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::forceLayoutInlineChildren):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::layoutInlineChildren):
(WebCore::RenderBlock::beforeSideVisibleOverflowForLine):
(WebCore::RenderBlock::afterSideVisibleOverflowForLine):
(WebCore::RenderBlock::beforeSideLayoutOverflowForLine):
(WebCore::RenderBlock::afterSideLayoutOverflowForLine):

  • rendering/RenderBox.h:

(WebCore::RenderBox::logicalLeftLayoutOverflow):
(WebCore::RenderBox::logicalRightLayoutOverflow):
(WebCore::RenderBox::logicalLeftVisualOverflow):
(WebCore::RenderBox::logicalRightVisualOverflow):

2:27 PM Changeset in webkit [69234] by fsamuel@chromium.org
  • 2 edits in branches/chromium/517/LayoutTests

Merge 69167 - 2010-10-05 Kent Tamura <tkent@chromium.org>

Unreviewed, test expectation update.

  • platform/chromium/test_expectations.txt:

TBR=tkent@chromium.org
Review URL: http://codereview.chromium.org/3626003

2:13 PM Changeset in webkit [69233] by fsamuel@chromium.org
  • 6 edits in branches/chromium/517

Merge 69161 - 2010-10-05 Fady Samuel <fsamuel@chromium.org>

Reviewed by Darin Adler.

REGRESSION (r65539): One pixel white gaps when scrolling Trac changeset pages
https://bugs.webkit.org/show_bug.cgi?id=45131

Added a layout test to check for paint rects that touch the border of an adjacent sell,
when border-collapse: separate is set for the table.

  • fast/table/simple_paint.html:

Don't do rtl as it doesn't exercise some of the new paint code.

  • fast/table/simple_paint_separate_borders-expected.checksum: Added.
  • fast/table/simple_paint_separate_borders-expected.png: Added.
  • fast/table/simple_paint_separate_borders-expected.txt: Added.
  • fast/table/simple_paint_separate_borders.html: Added.

2010-10-05 Fady Samuel <fsamuel@chromium.org>

Reviewed by Darin Adler.

REGRESSION (r65539): One pixel white gaps when scrolling Trac changeset pages
https://bugs.webkit.org/show_bug.cgi?id=45131

When border-collapse: separate property is set on the table, paintObject
may skip repainting cells, if the dirty region only touches one row/col of pixels.

Test: fast/table/simple_paint_separate_borders.html

  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::paintObject):

Don't subtract one from the right and bottom of the dirty paint rect.

TBR=fsamuel@chromium.org
Review URL: http://codereview.chromium.org/3590023

2:08 PM Changeset in webkit [69232] by abecsi@webkit.org
  • 3 edits in trunk/WebKit2

2010-10-06 Andras Becsi <abecsi@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Fix the build after API changes introduced in r69214.

  • UIProcess/API/cpp/qt/WKStringQt.cpp: (WKStringCreateWithQString):
  • UIProcess/API/cpp/qt/WKURLQt.cpp: (WKURLCreateWithQUrl):
2:02 PM Changeset in webkit [69231] by ajwong@chromium.org
  • 173 edits
    3 copies
    16 adds
    5 deletes in trunk/LayoutTests

[chromium] Unreviewed. Rebaseline layout tests.

Rebaselining for changes caused by r69181, r69220, and a few others
in that range.

Bugs filed for the 2 tests that look like real failures.

  • platform/chromium-linux/fast/block/basic/fieldset-stretch-to-legend-expected.checksum:
  • platform/chromium-linux/fast/block/basic/fieldset-stretch-to-legend-expected.png:
  • platform/chromium-linux/fast/css/getComputedStyle/computed-style-expected.txt: Removed.
  • platform/chromium-linux/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Removed.
  • platform/chromium-linux/fast/forms/006-expected.checksum:
  • platform/chromium-linux/fast/forms/006-expected.png:
  • platform/chromium-linux/fast/forms/007-expected.checksum:
  • platform/chromium-linux/fast/forms/007-expected.png:
  • platform/chromium-linux/fast/forms/fieldset-align-expected.checksum:
  • platform/chromium-linux/fast/forms/fieldset-align-expected.png:
  • platform/chromium-linux/fast/forms/float-before-fieldset-expected.checksum:
  • platform/chromium-linux/fast/forms/float-before-fieldset-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-blend-01-b-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-blend-01-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-color-01-b-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-composite-02-b-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-composite-02-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-example-01-b-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-example-01-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-morph-01-f-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
  • platform/chromium-linux/svg/batik/filters/feTile-expected.checksum:
  • platform/chromium-linux/svg/batik/filters/feTile-expected.png:
  • platform/chromium-linux/svg/batik/filters/filterRegions-expected.checksum:
  • platform/chromium-linux/svg/batik/filters/filterRegions-expected.png:
  • platform/chromium-linux/svg/batik/text/textEffect-expected.checksum:
  • platform/chromium-linux/svg/batik/text/textEffect-expected.png:
  • platform/chromium-linux/svg/batik/text/textEffect3-expected.checksum:
  • platform/chromium-linux/svg/batik/text/textEffect3-expected.png:
  • platform/chromium-linux/svg/batik/text/textFeatures-expected.checksum:
  • platform/chromium-linux/svg/batik/text/textFeatures-expected.png:
  • platform/chromium-linux/svg/css/getComputedStyle-basic-expected.txt: Removed.
  • platform/chromium-linux/svg/custom/empty-merge-expected.checksum: Removed.
  • platform/chromium-linux/svg/custom/empty-merge-expected.png: Removed.
  • platform/chromium-linux/svg/custom/feComponentTransfer-Discrete-expected.checksum:
  • platform/chromium-linux/svg/custom/feComponentTransfer-Discrete-expected.png:
  • platform/chromium-linux/svg/custom/feComponentTransfer-Gamma-expected.checksum:
  • platform/chromium-linux/svg/custom/feComponentTransfer-Gamma-expected.png:
  • platform/chromium-linux/svg/custom/feComponentTransfer-Linear-expected.checksum:
  • platform/chromium-linux/svg/custom/feComponentTransfer-Linear-expected.png:
  • platform/chromium-linux/svg/custom/feComponentTransfer-Table-expected.checksum:
  • platform/chromium-linux/svg/custom/feComponentTransfer-Table-expected.png:
  • platform/chromium-linux/svg/custom/image-with-transform-clip-filter-expected.checksum:
  • platform/chromium-linux/svg/custom/image-with-transform-clip-filter-expected.png:
  • platform/chromium-linux/svg/custom/inline-svg-in-xhtml-expected.checksum:
  • platform/chromium-linux/svg/custom/inline-svg-in-xhtml-expected.png:
  • platform/chromium-linux/svg/custom/non-opaque-filters-expected.checksum:
  • platform/chromium-linux/svg/custom/non-opaque-filters-expected.png:
  • platform/chromium-linux/svg/custom/recursive-filter-expected.checksum:
  • platform/chromium-linux/svg/custom/recursive-filter-expected.png:
  • platform/chromium-linux/svg/custom/text-filter-expected.checksum:
  • platform/chromium-linux/svg/custom/text-filter-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-in-attr-expected.checksum:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-in-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-attr-expected.checksum:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-call-expected.checksum:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-call-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEGaussianBlurElement-svgdom-in-prop-expected.checksum:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEGaussianBlurElement-svgdom-in-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEMergeNodeElement-dom-in-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEMergeNodeElement-dom-in-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEMergeNodeElement-svgdom-in-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEMergeNodeElement-svgdom-in-prop-expected.png: Added.
  • platform/chromium-linux/svg/filters/feComposite-expected.checksum:
  • platform/chromium-linux/svg/filters/feComposite-expected.png:
  • platform/chromium-linux/svg/filters/filter-on-filter-for-text-expected.checksum:
  • platform/chromium-linux/svg/filters/filter-on-filter-for-text-expected.png:
  • platform/chromium-linux/svg/filters/filter-on-tspan-expected.checksum:
  • platform/chromium-linux/svg/filters/filter-on-tspan-expected.png:
  • platform/chromium-linux/svg/filters/sourceAlpha-expected.checksum:
  • platform/chromium-linux/svg/filters/subRegion-one-effect-expected.checksum:
  • platform/chromium-linux/svg/filters/subRegion-one-effect-expected.png:
  • platform/chromium-linux/svg/filters/subRegion-two-effects-expected.checksum:
  • platform/chromium-linux/svg/filters/subRegion-two-effects-expected.png:
  • platform/chromium-mac/fast/blockflow/fieldsets-expected.checksum: Added.
  • platform/chromium-mac/fast/blockflow/fieldsets-expected.png: Added.
  • platform/chromium-mac/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-morph-01-f-expected.checksum: Copied from LayoutTests/platform/mac-leopard/svg/W3C-SVG-1.1/filters-morph-01-f-expected.checksum.
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png: Added.
  • platform/chromium-mac/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-win/fast/block/basic/fieldset-stretch-to-legend-expected.checksum:
  • platform/chromium-win/fast/block/basic/fieldset-stretch-to-legend-expected.png:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-win/fast/forms/006-expected.checksum:
  • platform/chromium-win/fast/forms/006-expected.png:
  • platform/chromium-win/fast/forms/007-expected.checksum:
  • platform/chromium-win/fast/forms/007-expected.png:
  • platform/chromium-win/fast/forms/fieldset-align-expected.checksum:
  • platform/chromium-win/fast/forms/fieldset-align-expected.png:
  • platform/chromium-win/fast/forms/float-before-fieldset-expected.checksum:
  • platform/chromium-win/fast/forms/float-before-fieldset-expected.png:
  • platform/chromium-win/inspector/console-uncaught-exception-expected.txt: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-blend-01-b-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-blend-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-color-01-b-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-composite-02-b-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-composite-02-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-example-01-b-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-example-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-morph-01-f-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
  • platform/chromium-win/svg/batik/filters/feTile-expected.checksum:
  • platform/chromium-win/svg/batik/filters/feTile-expected.png:
  • platform/chromium-win/svg/batik/filters/filterRegions-expected.checksum:
  • platform/chromium-win/svg/batik/filters/filterRegions-expected.png:
  • platform/chromium-win/svg/batik/text/textEffect-expected.checksum:
  • platform/chromium-win/svg/batik/text/textEffect-expected.png:
  • platform/chromium-win/svg/batik/text/textEffect3-expected.checksum:
  • platform/chromium-win/svg/batik/text/textEffect3-expected.png:
  • platform/chromium-win/svg/batik/text/textFeatures-expected.checksum:
  • platform/chromium-win/svg/batik/text/textFeatures-expected.png:
  • platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-win/svg/custom/convolution-crash-expected.checksum:
  • platform/chromium-win/svg/custom/convolution-crash-expected.png:
  • platform/chromium-win/svg/custom/empty-merge-expected.checksum:
  • platform/chromium-win/svg/custom/empty-merge-expected.png:
  • platform/chromium-win/svg/custom/feComponentTransfer-Discrete-expected.checksum:
  • platform/chromium-win/svg/custom/feComponentTransfer-Discrete-expected.png:
  • platform/chromium-win/svg/custom/feComponentTransfer-Gamma-expected.checksum:
  • platform/chromium-win/svg/custom/feComponentTransfer-Gamma-expected.png:
  • platform/chromium-win/svg/custom/feComponentTransfer-Linear-expected.checksum:
  • platform/chromium-win/svg/custom/feComponentTransfer-Linear-expected.png:
  • platform/chromium-win/svg/custom/feComponentTransfer-Table-expected.checksum:
  • platform/chromium-win/svg/custom/feComponentTransfer-Table-expected.png:
  • platform/chromium-win/svg/custom/image-with-transform-clip-filter-expected.checksum:
  • platform/chromium-win/svg/custom/image-with-transform-clip-filter-expected.png:
  • platform/chromium-win/svg/custom/inline-svg-in-xhtml-expected.checksum:
  • platform/chromium-win/svg/custom/inline-svg-in-xhtml-expected.png:
  • platform/chromium-win/svg/custom/non-opaque-filters-expected.checksum:
  • platform/chromium-win/svg/custom/non-opaque-filters-expected.png:
  • platform/chromium-win/svg/custom/recursive-filter-expected.checksum:
  • platform/chromium-win/svg/custom/recursive-filter-expected.png:
  • platform/chromium-win/svg/custom/text-filter-expected.checksum:
  • platform/chromium-win/svg/custom/text-filter-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-in-attr-expected.checksum:
  • platform/chromium-win/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-in-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-attr-expected.checksum:
  • platform/chromium-win/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-call-expected.checksum:
  • platform/chromium-win/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-call-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEGaussianBlurElement-svgdom-in-prop-expected.checksum:
  • platform/chromium-win/svg/dynamic-updates/SVGFEGaussianBlurElement-svgdom-in-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEMergeNodeElement-dom-in-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEMergeNodeElement-dom-in-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEMergeNodeElement-svgdom-in-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEMergeNodeElement-svgdom-in-prop-expected.png: Added.
  • platform/chromium-win/svg/filters/big-sized-filter-expected.checksum:
  • platform/chromium-win/svg/filters/big-sized-filter-expected.png:
  • platform/chromium-win/svg/filters/feColorMatrix-values-expected.checksum:
  • platform/chromium-win/svg/filters/feColorMatrix-values-expected.png:
  • platform/chromium-win/svg/filters/feComposite-expected.checksum:
  • platform/chromium-win/svg/filters/feComposite-expected.png:
  • platform/chromium-win/svg/filters/feGaussianBlur-expected.checksum:
  • platform/chromium-win/svg/filters/feGaussianBlur-expected.png:
  • platform/chromium-win/svg/filters/feOffset-expected.checksum:
  • platform/chromium-win/svg/filters/feOffset-expected.png:
  • platform/chromium-win/svg/filters/feTile-expected.checksum:
  • platform/chromium-win/svg/filters/feTile-expected.png:
  • platform/chromium-win/svg/filters/filter-on-filter-for-text-expected.checksum:
  • platform/chromium-win/svg/filters/filter-on-filter-for-text-expected.png:
  • platform/chromium-win/svg/filters/filter-on-tspan-expected.checksum:
  • platform/chromium-win/svg/filters/filter-on-tspan-expected.png:
  • platform/chromium-win/svg/filters/filterRes1-expected.checksum: Added.
  • platform/chromium-win/svg/filters/filterRes1-expected.png: Added.
  • platform/chromium-win/svg/filters/filterRes2-expected.checksum: Added.
  • platform/chromium-win/svg/filters/filterRes2-expected.png: Added.
  • platform/chromium-win/svg/filters/filterRes3-expected.checksum: Added.
  • platform/chromium-win/svg/filters/filterRes3-expected.png: Added.
  • platform/chromium-win/svg/filters/filteredImage-expected.checksum:
  • platform/chromium-win/svg/filters/filteredImage-expected.png:
  • platform/chromium-win/svg/filters/parent-children-with-same-filter-expected.checksum:
  • platform/chromium-win/svg/filters/parent-children-with-same-filter-expected.png:
  • platform/chromium-win/svg/filters/shadow-on-filter-expected.checksum:
  • platform/chromium-win/svg/filters/shadow-on-filter-expected.png:
  • platform/chromium-win/svg/filters/sourceAlpha-expected.checksum:
  • platform/chromium-win/svg/filters/sourceAlpha-expected.png:
  • platform/chromium-win/svg/filters/subRegion-in-userSpace-expected.checksum:
  • platform/chromium-win/svg/filters/subRegion-in-userSpace-expected.png:
  • platform/chromium-win/svg/filters/subRegion-one-effect-expected.checksum:
  • platform/chromium-win/svg/filters/subRegion-one-effect-expected.png:
  • platform/chromium-win/svg/filters/subRegion-two-effects-expected.checksum:
  • platform/chromium-win/svg/filters/subRegion-two-effects-expected.png:
  • platform/chromium/test_expectations.txt:
1:37 PM Changeset in webkit [69230] by Nikolas Zimmermann
  • 481 edits
    477 adds in trunk/LayoutTests

2010-10-06 Nikolas Zimmermann <nzimmermann@rim.com>

Rubber stamped by Dirk Schulze.

Next patch updating the SVG pixel test baseline for Leopard & Snow Leopard.

  • platform/mac-leopard/svg/dynamic-updates: Added.
  • platform/mac-leopard/svg/dynamic-updates/SVGCircleElement-dom-cx-attr-expected.checksum: Added.

...

1:36 PM Changeset in webkit [69229] by commit-queue@webkit.org
  • 27 edits
    1 add
    2 deletes in trunk/WebKit2

2010-10-06 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r69210.
http://trac.webkit.org/changeset/69210
https://bugs.webkit.org/show_bug.cgi?id=47297

This patch broke Windows (Requested by andersca on #webkit).

  • DerivedSources.make:
  • DerivedSources.pro:
  • Platform/CoreIPC/Arguments.h:
  • Platform/CoreIPC/HandleMessage.h: (CoreIPC::handleMessage):
  • Scripts/webkit2/messages.py:
  • Scripts/webkit2/messages_unittest.py:
  • Shared/CoreIPCSupport/WebPageProxyMessageKinds.h: Added.
  • Shared/StringPairVector.h: Removed.
  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm: (WebKit::PageClientImpl::registerEditCommand):
  • UIProcess/API/qt/qwkpage.cpp: (QWKPagePrivate::registerEditCommand):
  • UIProcess/API/qt/qwkpage_p.h:
  • UIProcess/PageClient.h:
  • UIProcess/WebEditCommandProxy.cpp: (WebKit::WebEditCommandProxy::unapply): (WebKit::WebEditCommandProxy::reapply):
  • UIProcess/WebFormClient.cpp: (WebKit::WebFormClient::willSubmitForm):
  • UIProcess/WebFormClient.h:
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didReceiveMessage): (WebKit::WebPageProxy::didReceiveSyncMessage): (WebKit::WebPageProxy::didStartProvisionalLoadForFrame): (WebKit::WebPageProxy::didReceiveServerRedirectForProvisionalLoadForFrame): (WebKit::WebPageProxy::didFailProvisionalLoadForFrame): (WebKit::WebPageProxy::didCommitLoadForFrame): (WebKit::WebPageProxy::didFinishDocumentLoadForFrame): (WebKit::WebPageProxy::didFinishLoadForFrame): (WebKit::WebPageProxy::didFailLoadForFrame): (WebKit::WebPageProxy::didReceiveTitleForFrame): (WebKit::WebPageProxy::didFirstLayoutForFrame): (WebKit::WebPageProxy::didFirstVisuallyNonEmptyLayoutForFrame): (WebKit::WebPageProxy::didRemoveFrameFromHierarchy): (WebKit::WebPageProxy::decidePolicyForNavigationAction): (WebKit::WebPageProxy::decidePolicyForNewWindowAction): (WebKit::WebPageProxy::decidePolicyForMIMEType): (WebKit::WebPageProxy::willSubmitForm): (WebKit::WebPageProxy::createNewPage): (WebKit::WebPageProxy::runJavaScriptAlert): (WebKit::WebPageProxy::runJavaScriptConfirm): (WebKit::WebPageProxy::runJavaScriptPrompt): (WebKit::WebPageProxy::mouseDidMoveOverElement): (WebKit::WebPageProxy::contentsSizeChanged): (WebKit::WebPageProxy::addItemToBackForwardList): (WebKit::WebPageProxy::goToItemInBackForwardList): (WebKit::WebPageProxy::registerEditCommandForUndo): (WebKit::WebPageProxy::registerEditCommandForRedo): (WebKit::WebPageProxy::didReceiveEvent): (WebKit::WebPageProxy::didChangeAcceleratedCompositing):
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in: Removed.
  • UIProcess/win/WebView.cpp: (WebKit::WebView::registerEditCommand):
  • UIProcess/win/WebView.h:
  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::setWindowRect): (WebKit::WebChromeClient::takeFocus): (WebKit::WebChromeClient::createWindow): (WebKit::WebChromeClient::runJavaScriptAlert): (WebKit::WebChromeClient::runJavaScriptConfirm): (WebKit::WebChromeClient::runJavaScriptPrompt): (WebKit::WebChromeClient::setStatusbarText): (WebKit::WebChromeClient::contentsSizeChanged): (WebKit::WebChromeClient::mouseDidMoveOverElement): (WebKit::WebChromeClient::setToolTip): (WebKit::WebChromeClient::setCursor):
  • WebProcess/WebCoreSupport/WebEditorClient.cpp: (WebKit::WebEditorClient::registerCommandForUndo): (WebKit::WebEditorClient::clearUndoRedoOperations):
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::detachedFromParent2): (WebKit::WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad): (WebKit::WebFrameLoaderClient::dispatchDidStartProvisionalLoad): (WebKit::WebFrameLoaderClient::dispatchDidReceiveTitle): (WebKit::WebFrameLoaderClient::dispatchDidCommitLoad): (WebKit::WebFrameLoaderClient::dispatchDidFailProvisionalLoad): (WebKit::WebFrameLoaderClient::dispatchDidFailLoad): (WebKit::WebFrameLoaderClient::dispatchDidFinishDocumentLoad): (WebKit::WebFrameLoaderClient::dispatchDidFinishLoad): (WebKit::WebFrameLoaderClient::dispatchDidFirstLayout): (WebKit::WebFrameLoaderClient::dispatchDidFirstVisuallyNonEmptyLayout): (WebKit::WebFrameLoaderClient::dispatchDecidePolicyForMIMEType): (WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction): (WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): (WebKit::WebFrameLoaderClient::dispatchWillSubmitForm): (WebKit::WebFrameLoaderClient::postProgressStartedNotification): (WebKit::WebFrameLoaderClient::postProgressEstimateChangedNotification): (WebKit::WebFrameLoaderClient::postProgressFinishedNotification): (WebKit::WebFrameLoaderClient::createFrame):
  • WebProcess/WebPage/WebBackForwardListProxy.cpp: (WebKit::WebBackForwardListProxy::addItem): (WebKit::WebBackForwardListProxy::goToItem): (WebKit::WebBackForwardListProxy::backItem): (WebKit::WebBackForwardListProxy::currentItem): (WebKit::WebBackForwardListProxy::forwardItem): (WebKit::WebBackForwardListProxy::itemAtIndex): (WebKit::WebBackForwardListProxy::backListCount): (WebKit::WebBackForwardListProxy::forwardListCount):
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::WebPage): (WebKit::WebPage::changeAcceleratedCompositingMode): (WebKit::WebPage::enterAcceleratedCompositingMode): (WebKit::WebPage::sendClose): (WebKit::WebPage::mouseEvent): (WebKit::WebPage::wheelEvent): (WebKit::WebPage::keyEvent): (WebKit::WebPage::validateMenuItem): (WebKit::WebPage::touchEvent): (WebKit::WebPage::show): (WebKit::WebPage::runJavaScriptInMainFrame): (WebKit::WebPage::getRenderTreeExternalRepresentation): (WebKit::WebPage::getSourceForFrame):
  • win/WebKit2.vcproj:
1:35 PM Changeset in webkit [69228] by hyatt@apple.com
  • 6 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=47298

Reviewed by Dan Bernstein.

Rename blockHeight to blockLogicalHeight.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::markLinesDirtyInBlockRange):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::computeBlockDirectionPositionsForLine):
(WebCore::RenderBlock::layoutInlineChildren):
(WebCore::RenderBlock::determineStartPosition):
(WebCore::RenderBlock::determineEndPosition):
(WebCore::RenderBlock::matchedEndLine):

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::RootInlineBox):
(WebCore::RootInlineBox::adjustPosition):

  • rendering/RootInlineBox.h:

(WebCore::RootInlineBox::blockLogicalHeight):
(WebCore::RootInlineBox::setBlockLogicalHeight):

  • rendering/svg/SVGRootInlineBox.cpp:

(WebCore::SVGRootInlineBox::layoutRootBox):

1:21 PM Changeset in webkit [69227] by jamesr@google.com
  • 2 edits in trunk/WebCore

2010-10-05 James Robinson <jamesr@chromium.org>

Reviewed by Kenneth Russell.

[chromium] DRT assertion w/accel 2D canvas in PlatformContextSkia
https://bugs.webkit.org/show_bug.cgi?id=47242

Call PlatformContextSkia::prepareForSoftwareDraw before doing putImageData
since that call mutates the software backing store.

Test: fast/canvas/canvas-putImageData.html

  • platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::ImageBuffer::putUnmultipliedImageData):
1:14 PM Changeset in webkit [69226] by ap@apple.com
  • 4 edits
    5 adds in trunk

Reviewed by Brady Eidson.

https://bugs.webkit.org/show_bug.cgi?id=47294
<rdar://problem/8425647>Application cache isn't consulted on redirect

Test: http/tests/appcache/main-resource-redirect.html

  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::continueAfterNavigationPolicy): If we have substitute data now (presumably after a redirect is served by appcache), switch to it. (WebCore::MainResourceLoader::willSendRequest): Check appcache for the new URL.
  • loader/MainResourceLoader.h: Made handleDataLoadSoon() take a const ResourceRequest reference - it doesn't ever modify it, and we can call it from continueAfterNavigationPolicy() now.
12:54 PM Changeset in webkit [69225] by jberlin@webkit.org
  • 2 edits in trunk/WebKit2

WKSerializedScriptValue.h needs to be copied over into the WEBKITOUTPUTDIR on Windows.
https://bugs.webkit.org/show_bug.cgi?id=47287

Rubber-stamped by Dan Bernstein.

  • win/WebKit2Generated.make:

Copy WKSerializedScriptValue.h into $(WEBKITOUTPUTDIR)\include\WebKit2.

12:38 PM Changeset in webkit [69224] by Nikolas Zimmermann
  • 46 edits
    81 adds in trunk/LayoutTests

2010-10-06 Nikolas Zimmermann <nzimmermann@rim.com>

Rubber stamped by Dirk Schulze.

Next patch updating the SVG pixel test baseline for Leopard & Snow Leopard.

  • platform/mac-leopard/svg/W3C-SVG-1.1/filters-morph-01-f-expected.checksum:
  • platform/mac-leopard/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:

...

12:37 PM Changeset in webkit [69223] by Martin Robinson
  • 5 edits in trunk/WebCore

2010-10-06 Alejandro G. Castro <alex@igalia.com>

Reviewed by Dirk Schulze.

ContextShadow should not use the blur radius as kernel size of the
box blurs
https://bugs.webkit.org/show_bug.cgi?id=46918

Calculate the size of the kernel in the blur algorithm using the radius instead
of using the blur distance directly. Change the name of the variables to match the
terminology in the spec.

  • platform/graphics/ContextShadow.cpp: (WebCore::ContextShadow::ContextShadow): (WebCore::ContextShadow::clear): (WebCore::ContextShadow::blurLayerImage): (WebCore::ContextShadow::calculateLayerBoundingRect):
  • platform/graphics/ContextShadow.h:
12:26 PM Changeset in webkit [69222] by mihaip@chromium.org
  • 5 edits
    4 copies in branches/chromium/517

Merge 68742

BUG=56591
TBR=darin@chromium.org
TEST=fast/history/same-document-iframes-changing-fragment.html
Review URL: http://codereview.chromium.org/3573012

12:16 PM Changeset in webkit [69221] by abecsi@webkit.org
  • 3 edits in trunk/WebCore

2010-10-06 Andras Becsi <abecsi@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Correct CamelCase of socketSentdata() in SocketStreamHandlePrivate
to fix "QMetaObject::invokeMethod: No such method" warnings in layout tests.
https://bugs.webkit.org/show_bug.cgi?id=47284

No new tests needed.

  • platform/network/qt/SocketStreamHandlePrivate.h:
  • platform/network/qt/SocketStreamHandleQt.cpp: (WebCore::SocketStreamHandlePrivate::socketSentData):
12:02 PM Changeset in webkit [69220] by hyatt@apple.com
  • 44 edits
    5 deletes in trunk

https://bugs.webkit.org/show_bug.cgi?id=47285

Reviewed by Dan Bernstein.

Update to the latest writing-mode draft. The block-flow property is gone and has been replaced with writing-mode.
Change all the code to use writingMode() instead of blockFlow() and rename all functions that referred to block flow
as appropriate.

WebCore:

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator WritingMode):
(WebCore::CSSPrimitiveValue::operator SVGWritingMode):

  • css/CSSProperty.cpp:

(WebCore::resolveToPhysicalProperty):
(WebCore::CSSProperty::resolveDirectionAwareProperty):

  • css/CSSProperty.h:
  • css/CSSPropertyNames.in:
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::styleForDocument):
(WebCore::CSSStyleSelector::adjustRenderStyle):
(WebCore::CSSStyleSelector::applyDeclarations):
(WebCore::CSSStyleSelector::applyProperty):

  • css/CSSValueKeywords.in:
  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::MarginInfo::MarginInfo):
(WebCore::RenderBlock::expandsToEncloseOverhangingFloats):
(WebCore::RenderBlock::setLogicalLeftForChild):
(WebCore::RenderBlock::setLogicalTopForChild):
(WebCore::RenderBlock::layoutBlockChild):
(WebCore::RenderBlock::insertFloatingObject):
(WebCore::RenderBlock::addOverhangingFloats):
(WebCore::RenderBlock::addIntrudingFloats):
(WebCore::RenderBlock::collapsedMarginBeforeForChild):
(WebCore::RenderBlock::collapsedMarginAfterForChild):
(WebCore::RenderBlock::marginBeforeForChild):
(WebCore::RenderBlock::marginAfterForChild):
(WebCore::RenderBlock::marginStartForChild):
(WebCore::RenderBlock::marginEndForChild):
(WebCore::RenderBlock::setMarginStartForChild):
(WebCore::RenderBlock::setMarginEndForChild):
(WebCore::RenderBlock::setMarginBeforeForChild):
(WebCore::RenderBlock::setMarginAfterForChild):
(WebCore::RenderBlock::marginValuesForChild):

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::logicalWidthForChild):
(WebCore::RenderBlock::logicalHeightForChild):
(WebCore::RenderBlock::logicalTopForChild):
(WebCore::RenderBlock::logicalRightOffsetForContent):
(WebCore::RenderBlock::logicalLeftOffsetForContent):
(WebCore::RenderBlock::logicalTopForFloat):
(WebCore::RenderBlock::logicalBottomForFloat):
(WebCore::RenderBlock::logicalLeftForFloat):
(WebCore::RenderBlock::logicalRightForFloat):
(WebCore::RenderBlock::logicalWidthForFloat):
(WebCore::RenderBlock::setLogicalTopForFloat):
(WebCore::RenderBlock::setLogicalLeftForFloat):
(WebCore::RenderBlock::setLogicalHeightForFloat):
(WebCore::RenderBlock::setLogicalWidthForFloat):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::marginBefore):
(WebCore::RenderBox::marginAfter):
(WebCore::RenderBox::marginStart):
(WebCore::RenderBox::marginEnd):
(WebCore::RenderBox::setMarginStart):
(WebCore::RenderBox::setMarginEnd):
(WebCore::RenderBox::setMarginBefore):
(WebCore::RenderBox::setMarginAfter):
(WebCore::RenderBox::styleDidChange):
(WebCore::RenderBox::perpendicularContainingBlockLogicalHeight):
(WebCore::RenderBox::computeLogicalWidth):
(WebCore::RenderBox::computeLogicalHeight):
(WebCore::RenderBox::availableLogicalHeightUsing):
(WebCore::RenderBox::avoidsFloats):

  • rendering/RenderBox.h:

(WebCore::RenderBox::logicalLeft):
(WebCore::RenderBox::logicalTop):
(WebCore::RenderBox::logicalWidth):
(WebCore::RenderBox::logicalHeight):
(WebCore::RenderBox::setLogicalLeft):
(WebCore::RenderBox::setLogicalTop):
(WebCore::RenderBox::setLogicalWidth):
(WebCore::RenderBox::setLogicalHeight):
(WebCore::RenderBox::setLogicalLocation):
(WebCore::RenderBox::contentLogicalWidth):
(WebCore::RenderBox::contentLogicalHeight):
(WebCore::RenderBox::stretchesToViewport):
(WebCore::RenderBox::intrinsicLogicalWidth):
(WebCore::RenderBox::intrinsicLogicalHeight):
(WebCore::RenderBox::availableWidth):
(WebCore::RenderBox::availableHeight):
(WebCore::RenderBox::scrollbarLogicalHeight):
(WebCore::RenderBox::isWritingModeRoot):

  • rendering/RenderFieldset.cpp:

(WebCore::RenderFieldset::paintBoxDecorations):
(WebCore::RenderFieldset::paintMask):

  • rendering/RenderImage.cpp:

(WebCore::RenderImage::computeReplacedLogicalWidth):
(WebCore::RenderImage::computeReplacedLogicalHeight):

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::marginLeft):
(WebCore::RenderInline::marginRight):
(WebCore::RenderInline::marginTop):
(WebCore::RenderInline::marginBottom):

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::paddingTop):
(WebCore::RenderTableCell::paddingBottom):
(WebCore::RenderTableCell::paddingLeft):
(WebCore::RenderTableCell::paddingRight):

  • rendering/RenderView.h:

(WebCore::RenderView::viewLogicalWidth):
(WebCore::RenderView::viewLogicalHeight):

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::RootInlineBox):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::diff):
(WebCore::RenderStyle::logicalWidth):
(WebCore::RenderStyle::logicalHeight):
(WebCore::RenderStyle::logicalMinWidth):
(WebCore::RenderStyle::logicalMaxWidth):
(WebCore::RenderStyle::logicalMinHeight):
(WebCore::RenderStyle::logicalMaxHeight):
(WebCore::RenderStyle::borderBeforeWidth):
(WebCore::RenderStyle::borderAfterWidth):
(WebCore::RenderStyle::borderStartWidth):
(WebCore::RenderStyle::borderEndWidth):
(WebCore::RenderStyle::marginBefore):
(WebCore::RenderStyle::marginAfter):
(WebCore::RenderStyle::marginBeforeUsing):
(WebCore::RenderStyle::marginAfterUsing):
(WebCore::RenderStyle::marginStart):
(WebCore::RenderStyle::marginEnd):
(WebCore::RenderStyle::marginStartUsing):
(WebCore::RenderStyle::marginEndUsing):
(WebCore::RenderStyle::paddingBefore):
(WebCore::RenderStyle::paddingAfter):
(WebCore::RenderStyle::paddingStart):
(WebCore::RenderStyle::paddingEnd):

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::setBitDefaults):
(WebCore::InheritedFlags::writingMode):
(WebCore::InheritedFlags::isHorizontalWritingMode):
(WebCore::InheritedFlags::setWritingMode):
(WebCore::InheritedFlags::initialWritingMode):

  • rendering/style/RenderStyleConstants.h:
  • rendering/style/SVGRenderStyle.h:

(WebCore::SVGRenderStyle::initialWritingMode):
(WebCore::SVGRenderStyle::setWritingMode):
(WebCore::SVGRenderStyle::writingMode):

  • rendering/style/SVGRenderStyleDefs.h:

LayoutTests:

Also hacked all of the getComputedStyle tests to just omit dashboard regions so that the results can be
cross-platform.

  • fast/blockflow/auto-margins-across-boundaries.html:
  • fast/blockflow/block-formatting-context.html:
  • fast/blockflow/block-level-images.html:
  • fast/blockflow/display-mutation.html:
  • fast/blockflow/fieldsets.html:
  • fast/blockflow/floats-in-block-layout.html:
  • fast/blockflow/inline-direction-positioning.html:
  • fast/blockflow/margin-collapse.html:
  • fast/blockflow/percentage-padding.html:
  • fast/blockflow/relative-positioning-percentages.html:
  • fast/blockflow/root-lr-basic.html:
  • fast/blockflow/self-collapsing-block.html:
  • fast/css/getComputedStyle/computed-style-expected.txt:
  • fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • fast/css/getComputedStyle/computed-style-without-renderer.html:
  • fast/css/getComputedStyle/computed-style.html:
  • fast/css/logical-property-resolution.html:
  • platform/mac/fast/css/getComputedStyle/computed-style-expected.txt: Removed.
  • platform/mac/svg/css/getComputedStyle-basic-expected.checksum: Removed.
  • platform/mac/svg/css/getComputedStyle-basic-expected.png: Removed.
  • platform/win/fast/css/getComputedStyle/computed-style-expected.txt: Removed.
  • platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Removed.
  • svg/css/getComputedStyle-basic-expected.txt:
  • svg/css/getComputedStyle-basic.xhtml:
11:59 AM Changeset in webkit [69219] by ajwong@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed. Build fix.

Update test expectations for more svg failures, and some new crashes.

  • platform/chromium/test_expectations.txt:
11:57 AM Changeset in webkit [69218] by commit-queue@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-10-06 Rafael Antognolli <antognolli@profusion.mobi>

Unreviewed build fix.

[EFL] Build fix for glib support.
https://bugs.webkit.org/show_bug.cgi?id=47221

If compiling with GLib support enabled, we also need to link wtf against
glib library.

  • wtf/CMakeListsEfl.txt:
11:53 AM Changeset in webkit [69217] by commit-queue@webkit.org
  • 3 edits in trunk/WebKit/qt

2010-10-06 Ragner Magalhaes <ragner.magalhaes@openbossa.org>

Reviewed by Antonio Gomes.

[Qt] Duplicated code in QWebPagePrivate
https://bugs.webkit.org/show_bug.cgi?id=47195

Remove duplicated code from QWebPagePrivate class for QGraphicsView and QWidget's mouse events.

  • Api/qwebpage.cpp: (QWebPagePrivate::mouseMoveEvent): (QWebPagePrivate::mousePressEvent): (QWebPagePrivate::mouseDoubleClickEvent): (QWebPagePrivate::mouseTripleClickEvent): (QWebPagePrivate::mouseReleaseEvent): (QWebPagePrivate::wheelEvent): (QWebPagePrivate::dragEnterEvent): (QWebPagePrivate::dragLeaveEvent): (QWebPagePrivate::dragMoveEvent): (QWebPagePrivate::dropEvent):
  • Api/qwebpage_p.h:
11:31 AM Changeset in webkit [69216] by commit-queue@webkit.org
  • 7 edits in trunk

2010-10-06 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r69201.
http://trac.webkit.org/changeset/69201
https://bugs.webkit.org/show_bug.cgi?id=47279

This change broke the WebKitGTK+ build for GTK+ 2.0.
(Requested by mrobinson on #webkit).

  • platform/gtk/GtkVersioning.c: (getDefaultGDKPointerDevice):
  • platform/gtk/GtkVersioning.h:
  • platform/gtk/PlatformScreenGtk.cpp: (WebCore::getVisual): (WebCore::screenAvailableRect):

2010-10-06 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r69201.
http://trac.webkit.org/changeset/69201
https://bugs.webkit.org/show_bug.cgi?id=47279

This change broke the WebKitGTK+ build for GTK+ 2.0.
(Requested by mrobinson on #webkit).

  • tests/testcopyandpaste.c: (runPasteTestCallback):
  • webkit/webkitwebview.cpp: (webkit_web_view_button_press_event):
11:22 AM Changeset in webkit [69215] by senorblanco@chromium.org
  • 3 edits in trunk/WebCore

2010-10-06 Stephen White <senorblanco@chromium.org>

Reviewed by James Robinson.
https://bugs.webkit.org/show_bug.cgi?id=47282

Robustify the creation of SharedGraphicsContext3D against shader
compilation failures.

Covered by any canvas 2D layout test, when opened in chrome with
--enable-accelerated-2d-canvas --in-process-webgl.

  • platform/graphics/gpu/SharedGraphicsContext3D.cpp: (WebCore::SharedGraphicsContext3D::create): (WebCore::SharedGraphicsContext3D::SharedGraphicsContext3D):
  • platform/graphics/gpu/SharedGraphicsContext3D.h:
11:16 AM Changeset in webkit [69214] by andersca@apple.com
  • 70 edits in trunk/WebKit2

Rename toRef/toWK to toAPI/toImpl
https://bugs.webkit.org/show_bug.cgi?id=47281

Reviewed by Sam Weinig.

  • Shared/API/c/WKArray.cpp:
  • Shared/API/c/WKCertificateInfo.cpp:
  • Shared/API/c/WKData.cpp:
  • Shared/API/c/WKDictionary.cpp:
  • Shared/API/c/WKError.cpp:
  • Shared/API/c/WKMutableArray.cpp:
  • Shared/API/c/WKMutableDictionary.cpp:
  • Shared/API/c/WKNumber.cpp:
  • Shared/API/c/WKSerializedScriptValue.cpp:
  • Shared/API/c/WKSharedAPICast.h:
  • Shared/API/c/WKString.cpp:
  • Shared/API/c/WKType.cpp:
  • Shared/API/c/WKURL.cpp:
  • Shared/API/c/WKURLRequest.cpp:
  • Shared/API/c/WKURLResponse.cpp:
  • Shared/API/c/cf/WKStringCF.cpp:
  • Shared/API/c/cf/WKURLCF.cpp:
  • Shared/API/c/cf/WKURLRequestCF.cpp:
  • Shared/API/c/cf/WKURLResponseCF.cpp:
  • Shared/API/c/mac/WKCertificateInfoMac.mm:
  • Shared/API/c/mac/WKURLRequestNS.mm:
  • Shared/API/c/mac/WKURLResponseNS.mm:
  • Shared/API/c/win/WKCertificateInfoWin.cpp:
  • UIProcess/API/C/WKAPICast.h:
  • UIProcess/API/C/WKBackForwardList.cpp:
  • UIProcess/API/C/WKBackForwardListItem.cpp:
  • UIProcess/API/C/WKContext.cpp:
  • UIProcess/API/C/WKFormSubmissionListener.cpp:
  • UIProcess/API/C/WKFrame.cpp:
  • UIProcess/API/C/WKFramePolicyListener.cpp:
  • UIProcess/API/C/WKNavigationData.cpp:
  • UIProcess/API/C/WKPage.cpp:
  • UIProcess/API/C/WKPageNamespace.cpp:
  • UIProcess/API/C/WKPreferences.cpp:
  • UIProcess/API/C/WKPreferencesPrivate.cpp:
  • UIProcess/API/C/win/WKContextWin.cpp:
  • UIProcess/API/C/win/WKView.cpp:
  • UIProcess/API/cpp/qt/WKStringQt.cpp:
  • UIProcess/API/cpp/qt/WKURLQt.cpp:
  • UIProcess/API/mac/PageClientImpl.mm:
  • UIProcess/API/mac/WKView.mm:
  • UIProcess/API/qt/ClientImpl.cpp:
  • UIProcess/API/qt/qwkpage.cpp:
  • UIProcess/GenericCallback.h:
  • UIProcess/WebContextInjectedBundleClient.cpp:
  • UIProcess/WebFormClient.cpp:
  • UIProcess/WebHistoryClient.cpp:
  • UIProcess/WebLoaderClient.cpp:
  • UIProcess/WebPolicyClient.cpp:
  • UIProcess/WebUIClient.cpp:
  • UIProcess/mac/ChunkedUpdateDrawingAreaProxyMac.mm:
  • UIProcess/mac/LayerBackedDrawingAreaProxyMac.mm:
  • UIProcess/qt/ChunkedUpdateDrawingAreaProxyQt.cpp:
  • WebProcess/InjectedBundle/API/c/WKBundle.cpp:
  • WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:
  • WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
  • WebProcess/InjectedBundle/API/c/WKBundleHitTestResult.cpp:
  • WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.cpp:
  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
  • WebProcess/InjectedBundle/API/c/WKBundleRangeHandle.cpp:
  • WebProcess/InjectedBundle/API/c/WKBundleScriptWorld.cpp:
  • WebProcess/InjectedBundle/InjectedBundle.cpp:
  • WebProcess/InjectedBundle/InjectedBundlePageEditorClient.cpp:
  • WebProcess/InjectedBundle/InjectedBundlePageFormClient.cpp:
  • WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:
  • WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:
  • WebProcess/InjectedBundle/mac/InjectedBundleMac.cpp:
  • WebProcess/InjectedBundle/qt/InjectedBundleQt.cpp:
  • WebProcess/InjectedBundle/win/InjectedBundleWin.cpp:
11:14 AM Changeset in webkit [69213] by ajwong@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed. Build fix.

Change svg test expectations after r69181

  • platform/chromium/test_expectations.txt:
10:36 AM Changeset in webkit [69212] by Nikolas Zimmermann
  • 1 edit
    1 move
    1 add in trunk/LayoutTests

2010-10-06 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed.

Fixed incorrect baseline for svg/custom/use-invalid-style.svg

  • platform/mac-leopard/svg/custom/use-invalid-style-expected.txt: Copied from svg/custom/use-invalid-style-expected.txt.
  • platform/mac/svg/custom/use-invalid-style-expected.txt: Added.
  • svg/custom/use-invalid-style-expected.txt: Removed.
10:34 AM Changeset in webkit [69211] by commit-queue@webkit.org
  • 8 edits in trunk

2010-10-06 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

Renaming WebCore::ViewportConfiguration to WebCore::ViewportAttributes
https://bugs.webkit.org/show_bug.cgi?id=47268

Renaming WebCore::ViewportConfiguration to WebCore::ViewportAttributes

  • dom/ViewportArguments.cpp: (WebCore::findConfigurationForViewportData):
  • dom/ViewportArguments.h:

2010-10-06 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

Renaming WebCore::ViewportConfiguration to WebCore::ViewportAttributes
https://bugs.webkit.org/show_bug.cgi?id=47268

Renaming WebCore::ViewportConfiguration to WebCore::ViewportAttributes

  • Api/qwebpage.cpp: (QWebPage::viewportConfigurationForSize):
  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::viewportAsText):

2010-10-06 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

Renaming WebCore::ViewportConfiguration to WebCore::ViewportAttributes
https://bugs.webkit.org/show_bug.cgi?id=47268

Renaming WebCore::ViewportConfiguration to WebCore::ViewportAttributes

  • UIProcess/API/qt/qwkpage.cpp: (QWKPage::viewportConfigurationForSize):
10:31 AM Changeset in webkit [69210] by weinig@apple.com
  • 27 edits
    2 adds
    1 delete in trunk/WebKit2

Generate the messages sent to the WebPageProxy
https://bugs.webkit.org/show_bug.cgi?id=47239

Reviewed by Adam Roben.

  • Platform/CoreIPC/Arguments.h:

Add additional typedefs.

  • Platform/CoreIPC/HandleMessage.h:

(CoreIPC::handleMessage):
Add more handleMessage implementations.

  • Scripts/webkit2/messages.py:
  • Scripts/webkit2/messages_unittest.py:

Add headers for reply argument types.

  • Shared/CoreIPCSupport/WebPageProxyMessageKinds.h: Removed.
  • Shared/StringPairVector.h: Added.

This file is a hack to work around a deficiency in the generator
which can't deal with class templates with more than one argument.

  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm:
  • UIProcess/API/qt/qwkpage.cpp:
  • UIProcess/API/qt/qwkpage_p.h:
  • UIProcess/PageClient.h:
  • UIProcess/WebEditCommandProxy.cpp:
  • UIProcess/WebFormClient.cpp:
  • UIProcess/WebFormClient.h:
  • UIProcess/WebPageProxy.cpp:
  • UIProcess/WebPageProxy.h:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:
  • WebProcess/WebCoreSupport/WebEditorClient.cpp:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
  • WebProcess/WebPage/WebBackForwardListProxy.cpp:
  • WebProcess/WebPage/WebPage.cpp:

Migrate to generated calls.

  • UIProcess/WebPageProxy.messages.in: Added.

New messages definitions file.

  • DerivedSources.make:
  • DerivedSources.pro:
  • win/WebKit2.vcproj:
  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:

Add new files.

10:27 AM Changeset in webkit [69209] by Nikolas Zimmermann
  • 144 edits
    407 adds
    2 deletes in trunk/LayoutTests

2010-10-06 Nikolas Zimmermann <nzimmermann@rim.com>

Rubber stamped by Dirk Schulze.

Generate SVG pixel test baseline for Snow Leopard (placed in platform/mac/svg) in svg/custom.

  • platform/mac-leopard/svg/custom/SVGMatrix-interface-expected.checksum: Added.
  • platform/mac-leopard/svg/custom/SVGMatrix-interface-expected.png: Added.

...

10:13 AM Changeset in webkit [69208] by jorlow@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-10-05 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Nate Chapin.

[Chromium] WebIDBKeyRange should handle null left/right pointers
https://bugs.webkit.org/show_bug.cgi?id=47247

  • src/WebIDBKeyRange.cpp: (WebKit::WebIDBKeyRange::assign): (WebKit::WebIDBKeyRange::left): (WebKit::WebIDBKeyRange::right): (WebKit::WebIDBKeyRange::flags):
10:10 AM Changeset in webkit [69207] by tony@chromium.org
  • 7 edits in trunk

2010-10-06 Tony Chang <tony@chromium.org>

Unreviewed, rolling out r69202.
http://trac.webkit.org/changeset/69202
https://bugs.webkit.org/show_bug.cgi?id=46937

Broke compile of test_shell

  • DEPS:
  • public/WebDragData.h:
  • src/WebDragData.cpp: (WebKit::WebDragData::hasFileNames): (WebKit::WebDragData::fileNames): (WebKit::WebDragData::setFileNames): (WebKit::WebDragData::appendToFileNames): (WebKit::WebDragData::fileContentFileName): (WebKit::WebDragData::setFileContentFileName):

2010-10-06 Tony Chang <tony@chromium.org>

Unreviewed, rolling out r69202.
http://trac.webkit.org/changeset/69202
https://bugs.webkit.org/show_bug.cgi?id=46937

Broke compile of test_shell

  • DumpRenderTree/chromium/EventSender.cpp: (EventSender::beginDragWithFiles):
  • DumpRenderTree/chromium/WebViewHost.cpp: (addDRTFakeFileToDataObject):
10:09 AM Changeset in webkit [69206] by commit-queue@webkit.org
  • 4 edits
    10 adds in trunk

2010-10-06 Renata Hodovan <reni@inf.u-szeged.hu>

Reviewed by Nikolas Zimmermann.

SVGFEMergeNodeElement doesn't support dynamic invalidation, when attributes change.
https://bugs.webkit.org/show_bug.cgi?id=47181

Adding layout tests for feMergeNode dynamic changes.

  • platform/mac/svg/dynamic-updates/SVGFEMergeNodeElement-dom-in-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEMergeNodeElement-dom-in-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEMergeNodeElement-svgdom-in-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEMergeNodeElement-svgdom-in-prop-expected.png: Added.
  • svg/dynamic-updates/SVGFEMergeNodeElement-dom-in-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGFEMergeNodeElement-dom-in-attr.html: Added.
  • svg/dynamic-updates/SVGFEMergeNodeElement-svgdom-in-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFEMergeNodeElement-svgdom-in-prop.html: Added.
  • svg/dynamic-updates/script-tests/SVGFEMergeNodeElement-dom-in-attr.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFEMergeNodeElement-svgdom-in-prop.js: Added. (executeTest):

2010-10-06 Renata Hodovan <reni@inf.u-szeged.hu>

Reviewed by Nikolas Zimmermann.

SVGFEMergeNodeElement doesn't support dynamic invalidation, when attributes change.
https://bugs.webkit.org/show_bug.cgi?id=47181

Since feMergeNode doesn't have own renderer, we have to call the invalidation via its parent.

Tests: svg/dynamic-updates/SVGFEMergeNodeElement-dom-in-attr.html

svg/dynamic-updates/SVGFEMergeNodeElement-svgdom-in-prop.html

  • svg/SVGFEMergeNodeElement.cpp: (WebCore::SVGFEMergeNodeElement::svgAttributeChanged):
  • svg/SVGFEMergeNodeElement.h:
10:04 AM Changeset in webkit [69205] by commit-queue@webkit.org
  • 3 edits in trunk/WebCore

2010-10-06 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Remove unused code from gtk2drawing.c
https://bugs.webkit.org/show_bug.cgi?id=47086

gtk2drawing.c was copied from mozilla and contains a lot of code that is not
used by WebKit. Most of that unused code is uncompatible with gtk3, so
removing it will make easier porting to gtk3.

  • platform/gtk/gtk2drawing.c: (moz_gtk_get_widget_border): (moz_gtk_widget_paint): (moz_gtk_destroy_theme_parts_widgets):
  • platform/gtk/gtkdrawing.h:
9:52 AM Changeset in webkit [69204] by commit-queue@webkit.org
  • 4 edits in trunk/WebCore

2010-10-06 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Xan Lopez.

[GTK] Use pixbufs instead of pixmaps when creating platform cursors
https://bugs.webkit.org/show_bug.cgi?id=47087

gdk_cursor_new_from_pixmap() has been removed in gtk3. We can use a
pixbuf instead of a pixman and use gdk_cursor_new_from_pixbuf() instead
for both gtk2 and gtk3.

  • platform/gtk/CursorGtk.cpp: (WebCore::createNamedCursor):
  • platform/gtk/GtkVersioning.c: (gdk_cairo_format_for_content): (gdk_cairo_surface_coerce_to_image): (convert_alpha): (convert_no_alpha): (gdk_pixbuf_get_from_surface):
  • platform/gtk/GtkVersioning.h:
9:48 AM Changeset in webkit [69203] by podivilov@chromium.org
  • 10 edits in trunk/WebCore

2010-10-06 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: add event listener breakpoints sidebar pane
https://bugs.webkit.org/show_bug.cgi?id=46738

  • inspector/front-end/BreakpointManager.js: (WebInspector.BreakpointManager.prototype.createEventListenerBreakpoint): (WebInspector.BreakpointManager.prototype.createXHRBreakpoint.breakpoint.compareTo): (WebInspector.BreakpointManager.prototype.createXHRBreakpoint): (WebInspector.NativeBreakpoint): (WebInspector.NativeBreakpoint.prototype._setOnBackend.didSet): (WebInspector.NativeBreakpoint.prototype._setOnBackend):
  • inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.XHRBreakpointsSidebarPane.prototype._showEditBreakpointDialog): (WebInspector.BreakpointItem): (WebInspector.EventListenerBreakpointsSidebarPane): (WebInspector.EventListenerBreakpointsSidebarPane.prototype._populate): (WebInspector.EventListenerBreakpointsSidebarPane.prototype._createCheckbox): (WebInspector.EventListenerBreakpointsSidebarPane.prototype._categoryCheckboxClicked): (WebInspector.EventListenerBreakpointsSidebarPane.prototype._eventNameCheckboxClicked): (WebInspector.EventListenerBreakpointsSidebarPane.prototype._breakpointEnableChanged): (WebInspector.EventListenerBreakpointsSidebarPane.prototype._updateCategoryCheckbox): (WebInspector.EventListenerBreakpointsSidebarPane.prototype.reset):
  • inspector/front-end/EventListenersSidebarPane.js: ():
  • inspector/front-end/PropertiesSection.js: (WebInspector.PropertiesSection):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype.reset):
  • inspector/front-end/inspector.css: (.section .properties, .event-bar .event-properties): (.section.expanded .properties, .event-bar.expanded .event-properties): (ol.properties-tree): (ol.properties-tree li): (ol.properties-tree li.parent): (ol.properties-tree li.parent::before): (ol.properties-tree li.parent.expanded::before): (ol.properties-tree li .info): (ol.properties-tree ol, .stack-trace ol, ol.stack-trace): (ol.properties-tree ol.expanded, .stack-trace ol, ol.stack-trace): (ol.stack-trace): (.event-listener-breakpoints .event-category): (ol.event-listener-breakpoints.properties-tree .children li): (.event-listener-breakpoints .checkbox-elem):
  • inspector/front-end/inspector.js: (WebInspector.createXHRBreakpointsSidebarPane.breakpointAdded): (WebInspector.createXHRBreakpointsSidebarPane):
9:45 AM Changeset in webkit [69202] by tony@chromium.org
  • 7 edits in trunk

2010-10-06 Daniel Cheng <dcheng@chromium.org>

Reviewed by Tony Chang.

[chromium] Minor naming cleanup in WebDragData, part 2
https://bugs.webkit.org/show_bug.cgi?id=46937

Chromium no longer uses the deprecated methods, so delete them.

  • DEPS:
  • public/WebDragData.h:
  • src/WebDragData.cpp:

2010-10-06 Daniel Cheng <dcheng@chromium.org>

Reviewed by Tony Chang.

[chromium] Minor naming cleanup in WebDragData, part 2
https://bugs.webkit.org/show_bug.cgi?id=46937

Update DRT to use the renamed methods.

  • DumpRenderTree/chromium/EventSender.cpp: (EventSender::beginDragWithFiles):
  • DumpRenderTree/chromium/WebViewHost.cpp: (addDRTFakeFileToDataObject):
9:40 AM Changeset in webkit [69201] by commit-queue@webkit.org
  • 7 edits in trunk

2010-10-06 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Xan Lopez.

[GTK] Port to gtk+3 (2.91.0)
https://bugs.webkit.org/show_bug.cgi?id=47249

Do not use GdkDrawable deprecated API

Some methods of GdkDrawable are deprecated in gtk2 and have been
remmoved in gtk3. Equivalent API has been added to GdkWindow.

  • platform/gtk/GtkVersioning.c: (getDefaultGDKPointerDevice):
  • platform/gtk/GtkVersioning.h:
  • platform/gtk/PlatformScreenGtk.cpp: (WebCore::getVisual): (WebCore::screenAvailableRect):

2010-10-06 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Xan Lopez.

Port to gtk+3 (2.91.0)
https://bugs.webkit.org/show_bug.cgi?id=47249

Do not use GdkDrawable deprecated API

Some methods of GdkDrawable are deprecated in gtk2 and have been
remmoved in gtk3. Equivalent API has been added to GdkWindow.

  • tests/testcopyandpaste.c: (runPasteTestCallback):
  • webkit/webkitwebview.cpp: (webkit_web_view_button_press_event):
9:35 AM Changeset in webkit [69200] by ddkilzer@apple.com
  • 1 edit in trunk/WebKitTools/ChangeLog

Added bug URL to ChangeLog entry.

9:32 AM Changeset in webkit [69199] by ddkilzer@apple.com
  • 3 edits
    1 copy
    1 add in trunk/WebKitTools

Move WebArchive serialization code into its own file

Reviewed by Adam Roben.

This is the first step in making webarchive tests work on
Windows.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added

new files to the project.

  • DumpRenderTree/mac/DumpRenderTree.mm: Removed code that moved

to WebArchiveDumpSupport.mm.

  • DumpRenderTree/mac/WebArchiveDumpSupport.h: Added.
  • DumpRenderTree/mac/WebArchiveDumpSupport.mm: Copied from WebKitTools/DumpRenderTree/mac/DumpRenderTree.mm.

(serializeWebArchiveToXML):

9:28 AM Changeset in webkit [69198] by commit-queue@webkit.org
  • 6 edits
    4 adds in trunk

2010-10-06 Ryuan Choi <ryuan.choi@samsung.com>

Reviewed by Antonio Gomes.

[EFL] Support Progress Tag
https://bugs.webkit.org/show_bug.cgi?id=45951

Implement to render progress tag.

No new tests. Existing tests in fast/dom/HTMLProgressElement.

  • platform/efl/RenderThemeEfl.cpp: (WebCore::RenderThemeEfl::paintThemePart): (WebCore::RenderThemeEfl::edjeGroupFromFormType): (WebCore::RenderThemeEfl::adjustProgressBarStyle): (WebCore::RenderThemeEfl::paintProgressBar):
  • platform/efl/RenderThemeEfl.h:

2010-10-06 Ryuan Choi <ryuan.choi@samsung.com>

Reviewed by Antonio Gomes.

[EFL] Support Progress Tag
https://bugs.webkit.org/show_bug.cgi?id=45951

Implement progressbar.edc to support progress tag

  • CMakeListsEfl.txt:
  • DefaultTheme/default.edc:
  • DefaultTheme/widget/progressbar: Added.
  • DefaultTheme/widget/progressbar/bt_base.png: Added.
  • DefaultTheme/widget/progressbar/progressbar.edc: Added.
  • DefaultTheme/widget/progressbar/shelf_inset.png: Added.
8:58 AM Changeset in webkit [69197] by Patrick Gansterer
  • 7 edits in trunk/WebCore

2010-10-06 Patrick Gansterer <Patrick Gansterer>

Reviewed by Darin Adler.

Add KURL::protocolIsData()
https://bugs.webkit.org/show_bug.cgi?id=47219

  • page/Page.cpp: (WebCore::Page::userStyleSheetLocationChanged):
  • page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::taintsCanvas):
  • page/XSSAuditor.cpp: (WebCore::XSSAuditor::findInRequest):
  • platform/KURL.h: (WebCore::KURL::protocolIsData):
  • platform/network/curl/ResourceHandleManager.cpp: (WebCore::ResourceHandleManager::dispatchSynchronousJob): (WebCore::ResourceHandleManager::startJob):
  • platform/network/win/ResourceHandleWin.cpp: (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::fileLoadTimer):
8:43 AM Changeset in webkit [69196] by apavlov@chromium.org
  • 9 edits in trunk/WebCore

2010-10-06 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

CSSParser: Enable rule selector source range extraction.
API modification followed by clients.
https://bugs.webkit.org/show_bug.cgi?id=46367

Some code removal suggested by Darin Adler.

  • css/CSSGrammar.y:
  • css/CSSParser.cpp: (WebCore::CSSParser::CSSParser): (WebCore::CSSParser::parseSheet): (WebCore::CSSParser::parseDeclaration): (WebCore::CSSParser::createStyleRule): (WebCore::CSSParser::markSelectorListStart): (WebCore::CSSParser::markSelectorListEnd): (WebCore::CSSParser::markRuleBodyStart): (WebCore::CSSParser::markRuleBodyEnd): (WebCore::CSSParser::markPropertyStart): (WebCore::CSSParser::markPropertyEnd):
  • css/CSSParser.h: (WebCore::CSSParser::resetSelectorListMarks): (WebCore::CSSParser::resetRuleBodyMarks): (WebCore::CSSParser::resetPropertyMarks):
  • css/CSSPropertySourceData.cpp:
  • css/CSSPropertySourceData.h: (WebCore::CSSRuleSourceData::create):
  • inspector/InspectorCSSStore.cpp: (WebCore::InspectorCSSStore::getRuleSourceData): (WebCore::InspectorCSSStore::extractRanges): (WebCore::InspectorCSSStore::getStyleAttributeRanges):
  • inspector/InspectorCSSStore.h:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::getStyleSourceData):
8:23 AM Changeset in webkit [69195] by krit@webkit.org
  • 1 edit in trunk/WebCore/ChangeLog

2010-10-06 Dirk Schulze <krit@webkit.org>

Added reviewer to commit r69187.

8:16 AM Changeset in webkit [69194] by krit@webkit.org
  • 2 edits in trunk/WebCore

2010-10-06 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG feMorphology - big radii cause huge ImageBuffer sizes
https://bugs.webkit.org/show_bug.cgi?id=47263

The current code in FEMorphology::determineAbsolutePaintRect calculates the smallest paint rect by inflate the paint rect
of a previous effect with the radius. This was meant as an optimization, but I forgot to clip the calculated image size
by the maximal effect size. This caused huge image sizes for big radii.

This is covered by svg/filters/feMorphology-invalid-radius.svg and fixes the crashes on Windows and Snow Leopard bots.

  • platform/graphics/filters/FEMorphology.cpp: (WebCore::FEMorphology::determineAbsolutePaintRect):
7:57 AM Changeset in webkit [69193] by alex
  • 2 edits in trunk/WebCore

2010-10-06 Alejandro G. Castro <alex@igalia.com>

Reviewed by Dirk Schulze.

Fixed crash in gtk bots (filter-empty-g.svg) after r69181.

  • rendering/RenderSVGResourceFilter.cpp: (WebCore::RenderSVGResourceFilter::postApplyResource):
7:53 AM Changeset in webkit [69192] by tonikitoo@webkit.org
  • 13 edits in trunk/WebCore

Rename HitTestResult::rectFromPoint to rectForPoint
https://bugs.webkit.org/show_bug.cgi?id=47261

Patch by Antonio Gomes <agomes@rim.org> on 2010-10-06
Reviewed by Kenneth Rohde Christiansen.

As per Kenneth Christiansen request inhttps://bugs.webkit.org/show_bug.cgi?id=46336#c20.

  • WebCore.exp.in:
  • dom/Document.cpp:

(WebCore::Document::nodesFromRect):

  • rendering/EllipsisBox.cpp:

(WebCore::EllipsisBox::nodeAtPoint):

  • rendering/HitTestResult.cpp:

(WebCore::HitTestResult::addNodeToRectBasedTestResult):
(WebCore::HitTestResult::rectForPoint):

  • rendering/HitTestResult.h:

(WebCore::HitTestResult::rectForPoint):

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::nodeAtPoint):

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::nodeAtPoint):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::nodeAtPoint):
(WebCore::RenderBlock::hitTestColumns):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::nodeAtPoint):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::hitTestLayer):
(WebCore::RenderLayer::hitTestChildLayerColumns):

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::nodeAtPoint):

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::nodeAtPoint):

7:44 AM Changeset in webkit [69191] by Nikolas Zimmermann
  • 189 edits
    374 adds in trunk/LayoutTests

2010-10-06 Nikolas Zimmermann <nzimmermann@rim.com>

Rubber stamped by Dirk Schulze.

Generate SVG pixel test baseline for Snow Leopard (placed in platform/mac/svg). Where the results differ in Leopard
place new results in platform/mac-leopard/svg. As I finally have a 10.5 and 10.6 machine, we can now maintain two
baselines.

  • platform/mac-leopard/svg/W3C-SVG-1.1/animate-elem-03-t-expected.checksum: Added.
  • platform/mac-leopard/svg/W3C-SVG-1.1/animate-elem-03-t-expected.png: Added.

...

6:42 AM Changeset in webkit [69190] by yurys@chromium.org
  • 1 edit
    3 adds in trunk/LayoutTests

2010-10-06 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: test that uncaught exceptions have stack trace when inspector is open
https://bugs.webkit.org/show_bug.cgi?id=47250

  • http/tests/inspector/console-tests2.js: Added. (initialize_ConsoleTest.InspectorTest.dumpConsoleMessages): (initialize_ConsoleTest.InspectorTest.expandConsoleMessages): (initialize_ConsoleTest):
  • inspector/console-uncaught-exception.html: Added.
  • platform/chromium/inspector/console-uncaught-exception-expected.txt: Added.
6:33 AM Changeset in webkit [69189] by caseq@chromium.org
  • 2 edits
    2 adds in trunk/LayoutTests

2010-10-06 Andrey Kosyakov <caseq@chromium.org>

Unreviewed. Rebased test expectations after r69185.

  • inspector/report-protocol-errors-expected.txt:
  • platform/mac-leopard/inspector/extensions-resources-expected.txt: Added.
6:06 AM Changeset in webkit [69188] by Nikolas Zimmermann
  • 99 edits in trunk/LayoutTests

2010-10-06 Nikolas Zimmermann <nzimmermann@rim.com>

Rubber stamped by Dirk Schulze.

SVGs with filters look grainy when scaled
https://bugs.webkit.org/show_bug.cgi?id=5526

Land new mac pixel test baseline after the filter patch.

  • platform/mac-leopard/svg/W3C-SVG-1.1/filters-composite-02-b-expected.checksum:
  • platform/mac-leopard/svg/W3C-SVG-1.1/filters-composite-02-b-expected.png:
  • platform/mac-leopard/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.checksum:
  • platform/mac-leopard/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.png:
  • platform/mac-leopard/svg/W3C-SVG-1.1/filters-morph-01-f-expected.checksum:
  • platform/mac-leopard/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
  • platform/mac-leopard/svg/batik/filters/feTile-expected.checksum:
  • platform/mac-leopard/svg/batik/filters/feTile-expected.png:
  • platform/mac-leopard/svg/custom/feComponentTransfer-Discrete-expected.checksum:
  • platform/mac-leopard/svg/custom/feComponentTransfer-Discrete-expected.png:
  • platform/mac-leopard/svg/custom/feComponentTransfer-Gamma-expected.checksum:
  • platform/mac-leopard/svg/custom/feComponentTransfer-Gamma-expected.png:
  • platform/mac-leopard/svg/custom/feComponentTransfer-Linear-expected.checksum:
  • platform/mac-leopard/svg/custom/feComponentTransfer-Linear-expected.png:
  • platform/mac-leopard/svg/custom/feComponentTransfer-Table-expected.checksum:
  • platform/mac-leopard/svg/custom/feComponentTransfer-Table-expected.png:
  • platform/mac-leopard/svg/filters/feGaussianBlur-expected.checksum:
  • platform/mac-leopard/svg/filters/feGaussianBlur-expected.png:
  • platform/mac-leopard/svg/filters/shadow-on-filter-expected.checksum:
  • platform/mac-leopard/svg/filters/shadow-on-filter-expected.png:
  • platform/mac-leopard/svg/filters/shadow-on-rect-with-filter-expected.checksum:
  • platform/mac-leopard/svg/filters/shadow-on-rect-with-filter-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-blend-01-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/filters-blend-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-color-01-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-example-01-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/filters-example-01-b-expected.png:
  • platform/mac/svg/batik/filters/filterRegions-expected.checksum:
  • platform/mac/svg/batik/filters/filterRegions-expected.png:
  • platform/mac/svg/batik/text/textEffect-expected.checksum:
  • platform/mac/svg/batik/text/textEffect-expected.png:
  • platform/mac/svg/batik/text/textEffect3-expected.checksum:
  • platform/mac/svg/batik/text/textEffect3-expected.png:
  • platform/mac/svg/batik/text/textFeatures-expected.checksum:
  • platform/mac/svg/batik/text/textFeatures-expected.png:
  • platform/mac/svg/custom/convolution-crash-expected.checksum:
  • platform/mac/svg/custom/convolution-crash-expected.png:
  • platform/mac/svg/custom/empty-merge-expected.checksum:
  • platform/mac/svg/custom/empty-merge-expected.png:
  • platform/mac/svg/custom/image-with-transform-clip-filter-expected.checksum:
  • platform/mac/svg/custom/image-with-transform-clip-filter-expected.png:
  • platform/mac/svg/custom/non-opaque-filters-expected.checksum:
  • platform/mac/svg/custom/non-opaque-filters-expected.png:
  • platform/mac/svg/custom/recursive-filter-expected.checksum:
  • platform/mac/svg/custom/recursive-filter-expected.png:
  • platform/mac/svg/custom/resource-invalidate-on-target-update-expected.checksum:
  • platform/mac/svg/custom/resource-invalidate-on-target-update-expected.png:
  • platform/mac/svg/custom/text-filter-expected.checksum:
  • platform/mac/svg/custom/text-filter-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-in-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-in-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-call-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-call-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEGaussianBlurElement-svgdom-in-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEGaussianBlurElement-svgdom-in-prop-expected.png:
  • platform/mac/svg/filters/big-sized-filter-expected.checksum:
  • platform/mac/svg/filters/big-sized-filter-expected.png:
  • platform/mac/svg/filters/feColorMatrix-values-expected.checksum:
  • platform/mac/svg/filters/feColorMatrix-values-expected.png:
  • platform/mac/svg/filters/feComposite-expected.checksum:
  • platform/mac/svg/filters/feComposite-expected.png:
  • platform/mac/svg/filters/feDisplacementMap-expected.checksum:
  • platform/mac/svg/filters/feDisplacementMap-expected.png:
  • platform/mac/svg/filters/feOffset-expected.checksum:
  • platform/mac/svg/filters/feOffset-expected.png:
  • platform/mac/svg/filters/feTile-expected.checksum:
  • platform/mac/svg/filters/feTile-expected.png:
  • platform/mac/svg/filters/filter-on-filter-for-text-expected.checksum:
  • platform/mac/svg/filters/filter-on-filter-for-text-expected.png:
  • platform/mac/svg/filters/filter-on-tspan-expected.checksum:
  • platform/mac/svg/filters/filter-on-tspan-expected.png:
  • platform/mac/svg/filters/filterRes-expected.checksum:
  • platform/mac/svg/filters/filterRes-expected.png:
  • platform/mac/svg/filters/filterRes1-expected.checksum:
  • platform/mac/svg/filters/filterRes1-expected.png:
  • platform/mac/svg/filters/filterRes3-expected.checksum:
  • platform/mac/svg/filters/filterRes3-expected.png:
  • platform/mac/svg/filters/filteredImage-expected.checksum:
  • platform/mac/svg/filters/filteredImage-expected.png:
  • platform/mac/svg/filters/parent-children-with-same-filter-expected.checksum:
  • platform/mac/svg/filters/parent-children-with-same-filter-expected.png:
  • platform/mac/svg/filters/sourceAlpha-expected.checksum:
  • platform/mac/svg/filters/sourceAlpha-expected.png:
  • platform/mac/svg/filters/subRegion-in-userSpace-expected.checksum:
  • platform/mac/svg/filters/subRegion-in-userSpace-expected.png:
  • platform/mac/svg/filters/subRegion-one-effect-expected.checksum:
  • platform/mac/svg/filters/subRegion-one-effect-expected.png:
  • platform/mac/svg/filters/subRegion-two-effects-expected.checksum:
  • platform/mac/svg/filters/subRegion-two-effects-expected.png:
  • platform/mac/svg/repaint/filter-repaint-expected.checksum:
  • platform/mac/svg/repaint/filter-repaint-expected.png:
  • platform/mac/svg/webarchive/svg-feimage-subresources-expected.checksum:
  • platform/mac/svg/webarchive/svg-feimage-subresources-expected.png:
5:47 AM Changeset in webkit [69187] by krit@webkit.org
  • 5 edits in trunk/WebCore

2010-10-06 Dirk Schulze <krit@webkit.org>

Unreviewed fix of Cairo ports.

SVGs with filters look grainy when scaled
https://bugs.webkit.org/show_bug.cgi?id=5526

Fixed issues on Cairos shadow implementation after the changes to FilterEffects.
Cairo calculates the inflation of the effect rect itself. Respect this for FEGaussianBlur.
This is just a temporary solution, since Cairo and Qt will use ContextShadow soon.

  • platform/graphics/GraphicsContext.h:
  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::drawBorderlessRectShadow): (WebCore::GraphicsContext::applyPlatformShadow): (WebCore::GraphicsContext::createShadowMask): (WebCore::GraphicsContext::drawTiledShadow): (WebCore::GraphicsContext::fillRoundedRect):
  • platform/graphics/filters/ImageBufferFilter.cpp: (WebCore::ImageBufferFilter::ImageBufferFilter): (WebCore::ImageBufferFilter::create):
  • platform/graphics/filters/ImageBufferFilter.h: (WebCore::ImageBufferFilter::filterRegion): (WebCore::ImageBufferFilter::sourceImageRect):
5:29 AM Changeset in webkit [69186] by Nikolas Zimmermann
  • 10 edits in trunk/WebCore

2010-10-06 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Only execute first SVG text layout phase if needed
https://bugs.webkit.org/show_bug.cgi?id=47254

The first SVG text layout phase which computes the per-character metrics and extracts
the x/y/dx/dy/rotate values from the SVG DOM is currently executed upon every RenderSVGText::layout() call.

Optimize this, by only calling it:

  • if x/y/dx/dy/rotate value lists change
  • the style of a RenderSVGInlineText changes (eg. font-size changes influence metrics)
  • the text content of any of the children in the <text> subtree change

No change in layout tests, a pure performance change - covered by existing tests.

  • rendering/RenderSVGResourceGradient.cpp: (WebCore::createMaskAndSwapContextForTextGradient): Adapt to renames, use RenderSVGText::locateRenderSVGTextAncestor(). (WebCore::clipToTextMask): Ditto.
  • rendering/SVGRenderSupport.cpp:
  • rendering/SVGRenderSupport.h: Move findTreeRootObject to RenderSVGText::locateRenderSVGTextAncestor().
  • rendering/svg/RenderSVGInline.cpp: (WebCore::RenderSVGInline::objectBoundingBox): adapt to renames, use RenderSVGText::locateRenderSVGTextAncestor(). (WebCore::RenderSVGInline::strokeBoundingBox): Ditto. (WebCore::RenderSVGInline::repaintRectInLocalCoordinates): Ditto. (WebCore::RenderSVGInline::absoluteQuads): Ditto.
  • rendering/svg/RenderSVGInlineText.cpp: (WebCore::RenderSVGInlineText::styleDidChange): Call setNeedsPositioningValuesUpdate() on the RenderSVGText root object, if diff == StyleDifferenceLayout.
  • rendering/svg/RenderSVGText.cpp: (WebCore::RenderSVGText::RenderSVGText): Initialize m_needsPositioningValuesUpdate. (WebCore::RenderSVGText::locateRenderSVGTextAncestor): New helper function, moved from SVGRenderSupport, to a more sensible place. (WebCore::RenderSVGText::layout): Only execute the first SVG text layout phase, if m_needsPositioningValuesUpdate=true.
  • rendering/svg/RenderSVGText.h: (WebCore::RenderSVGText::setNeedsPositioningValuesUpdate): (WebCore::toRenderSVGText): Add new helper casting methods, like most other renderers have.
  • svg/SVGTextPositioningElement.cpp: (WebCore::updatePositioningValuesInRenderer): (WebCore::SVGTextPositioningElement::svgAttributeChanged): If x/y/dx/dy/rotate changes, call setNeedsPositioningValuesUpdate on the RenderSVGText root object. (WebCore::SVGTextPositioningElement::childrenChanged): If any children changes (addition, removal), do the same.
  • svg/SVGTextPositioningElement.h:
5:27 AM Changeset in webkit [69185] by caseq@chromium.org
  • 14 edits in trunk

2010-10-05 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [Extensions API] Expose access to resource bodies
Added support for encoding resource in WebInspector.getResourceContent()
https://bugs.webkit.org/show_bug.cgi?id=45953

  • inspector/Inspector.idl: Added encoding parameter to getResourceContent()
  • inspector/InspectorController.cpp: (WebCore::InspectorController::getResourceContent):
  • inspector/InspectorController.h:
  • inspector/InspectorResource.cpp: Added sourceBytes() to return encoded representation of resource's binary body. (WebCore::InspectorResource::sourceBytes):
  • inspector/InspectorResource.h:
  • inspector/front-end/ExtensionAPI.js: (WebInspector.injectedExtensionAPI.Resources.prototype.getContent):
  • inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer): (WebInspector.ExtensionServer.prototype._onGetResourceContent): (WebInspector.ExtensionServer.prototype._onGetResourceContent.onContentAvailable): (WebInspector.getEncodedResourceContent):
  • inspector/front-end/NetworkPanel.js: (WebInspector.getResourceContent):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.getResourceContent):

2010-10-05 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [Extensions API] Expose access to resource bodies
https://bugs.webkit.org/show_bug.cgi?id=45953

  • inspector/extensions-api-expected.txt:
  • inspector/extensions-resources-expected.txt:
  • inspector/extensions-resources.html:
5:10 AM Changeset in webkit [69184] by hyatt@apple.com
  • 10 edits
    4 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=47235

Reviewed by Dan Bernstein.

Make "lr" block-flow fieldsets work.

(1) Patched html.css rules for legends and fieldsets to use logical margins and padding.
(2) Converted just enough of computePreferredLogicalWidths to make basic examples work.
(3) Removed the extra border drawing code from fieldsets so that the "clip out the legend" approach
is now just always used. It's silly to keep the old border drawing code in (which has already gotten out
of sync with the base class) just to avoid a save/restore and some clipping.
(4) Modified the layout/painting routines to place the legend properly and to be able to draw it in
both the top and the left borders.

Added fast/blockflow/fieldsets.html

WebCore:

  • css/html.css:

(legend):
(fieldset):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::determineLogicalLeftPositionForChild):
(WebCore::RenderBlock::setLogicalLeftForChild):
(WebCore::RenderBlock::setLogicalTopForChild):
(WebCore::RenderBlock::layoutBlockChild):
(WebCore::RenderBlock::computePreferredLogicalWidths):

  • rendering/RenderBlock.h:
  • rendering/RenderFieldset.cpp:

(WebCore::RenderFieldset::layoutLegend):
(WebCore::RenderFieldset::paintBoxDecorations):
(WebCore::RenderFieldset::paintMask):

  • rendering/RenderFieldset.h:

LayoutTests:

  • fast/blockflow/fieldsets.html: Added.
  • platform/mac/fast/blockflow/fieldsets-expected.checksum: Added.
  • platform/mac/fast/blockflow/fieldsets-expected.png: Added.
  • platform/mac/fast/blockflow/fieldsets-expected.txt: Added.
  • platform/mac/fast/forms/fieldset-align-expected.checksum:
  • platform/mac/fast/forms/fieldset-align-expected.png:
  • platform/mac/fast/forms/fieldset-align-expected.txt:
3:59 AM Changeset in webkit [69183] by Patrick Gansterer
  • 6 edits
    2 adds in trunk/WebCore

2010-10-06 Patrick Gansterer <Patrick Gansterer>

Reviewed by Darin Adler.

Move parseDataUrl() from CURL into own file
https://bugs.webkit.org/show_bug.cgi?id=41462

Move the data URL parsing algorithm into a new file to use it in ResourceHandleWin too.

  • CMakeLists.txt:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • platform/network/DataURL.cpp: Added. (WebCore::handleDataURL):
  • platform/network/DataURL.h: Added.
  • platform/network/curl/ResourceHandleManager.cpp: (WebCore::ResourceHandleManager::dispatchSynchronousJob): (WebCore::ResourceHandleManager::startJob):
  • platform/network/win/ResourceHandleWin.cpp: (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::fileLoadTimer):
3:40 AM Changeset in webkit [69182] by krit@webkit.org
  • 3 edits in trunk/LayoutTests

2010-10-06 Dirk Schulze <krit@webkit.org>

Unreviewed new baseline for Qt.

SVGs with filters look grainy when scaled
https://bugs.webkit.org/show_bug.cgi?id=5526

  • platform/qt/svg/filters/shadow-on-filter-expected.txt:
  • platform/qt/svg/filters/shadow-on-rect-with-filter-expected.txt:
2:45 AM Changeset in webkit [69181] by krit@webkit.org
  • 44 edits
    12 adds in trunk

2010-10-06 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVGs with filters look grainy when scaled
https://bugs.webkit.org/show_bug.cgi?id=5526

SVG filter effects need smarter size calculation
https://bugs.webkit.org/show_bug.cgi?id=31370

SVG elements use Filters before own transformations
https://bugs.webkit.org/show_bug.cgi?id=32486

Calculate all filter results in device space instead of the filtered objects user space. This change is similar to
the patches for SVG Pattern and SVG Masker before. It avoids pixelation and guarantees smooth filter results for
every scale level and is independent of any transformation to the target element or any ancester of the target.
The second part of this patch reduces the size of every effect to the smallest affected region instead of the complete
filter primitive subregion (http://www.w3.org/TR/SVG/filters.html#FilterPrimitiveSubRegion). We just use the subregion
as clipping region, like mentioned in the SVG specification, to make the affected region even smaller now.

This is a huge speed up. The ECMA cloud (http://ejohn.org/files/ecma-cloud.svg) is more than 100 times faster on Gtk and
renders in less than a second.
Some examples on svg-wow.org can be viewed the first time now, since the subregions were much bigger than the affected
region.
There's still more potential to speed up filters, by further reducing the ImageBuffer sizes.
Renamed repaintRectInLocalCoordinates to absolutePaintRect, since all coordinates are in device space instead of the
user space now.
The absolute paint rect is calculated by determineAbsolutePaintRect() and gets called by FilterEffect::effectContext() on
applying the effect.
Partly rewrote filter resolution (http://www.w3.org/TR/SVG/filters.html#FilterElementFilterResAttribute) to work with the
new concept. This also corrects the old behavior to match the SVG specification.

Tests: svg/filters/filterRes1.svg

svg/filters/filterRes2.svg
svg/filters/filterRes3.svg

  • platform/graphics/cairo/GraphicsContextCairo.cpp: Call setAbsolutePaintRect instead of setRepaintRectInLocalCoordinates. (WebCore::GraphicsContext::createShadowMask):
  • platform/graphics/filters/FEBlend.cpp: Renamed repaintRectInLocalCoordinates to absolutePaintRect. (WebCore::FEBlend::apply):
  • platform/graphics/filters/FEColorMatrix.cpp: Ditto. (WebCore::FEColorMatrix::apply):
  • platform/graphics/filters/FEComponentTransfer.cpp: Ditto. (WebCore::FEComponentTransfer::apply):
  • platform/graphics/filters/FEComposite.cpp: Ditto. (WebCore::FEComposite::determineAbsolutePaintRect): (WebCore::FEComposite::apply):
  • platform/graphics/filters/FEComposite.h:
  • platform/graphics/filters/FEConvolveMatrix.cpp: Ditto. (WebCore::FEConvolveMatrix::apply):
  • platform/graphics/filters/FEConvolveMatrix.h: (WebCore::FEConvolveMatrix::determineAbsolutePaintRect):
  • platform/graphics/filters/FEDisplacementMap.cpp: Ditto. (WebCore::FEDisplacementMap::apply):
  • platform/graphics/filters/FEDisplacementMap.h: (WebCore::FEDisplacementMap::determineAbsolutePaintRect):
  • platform/graphics/filters/FEFlood.cpp: Ditto. (WebCore::FEFlood::apply):
  • platform/graphics/filters/FEFlood.h: (WebCore::FEFlood::determineAbsolutePaintRect):
  • platform/graphics/filters/FEGaussianBlur.cpp: Ditto. (WebCore::calculateKernelSize): (WebCore::FEGaussianBlur::determineAbsolutePaintRect): (WebCore::FEGaussianBlur::apply):
  • platform/graphics/filters/FEGaussianBlur.h:
  • platform/graphics/filters/FELighting.cpp: Ditto. (WebCore::FELighting::apply):
  • platform/graphics/filters/FEMerge.cpp: Ditto. (WebCore::FEMerge::apply):
  • platform/graphics/filters/FEMorphology.cpp: Ditto. (WebCore::FEMorphology::determineAbsolutePaintRect): (WebCore::FEMorphology::apply):
  • platform/graphics/filters/FEMorphology.h:
  • platform/graphics/filters/FEOffset.cpp: Ditto. (WebCore::FEOffset::determineAbsolutePaintRect): (WebCore::FEOffset::apply):
  • platform/graphics/filters/FEOffset.h:
  • platform/graphics/filters/FETile.cpp: Ditto. (WebCore::FETile::determineFilterPrimitiveSubregion): (WebCore::FETile::apply):
  • platform/graphics/filters/FETile.h: (WebCore::FETile::determineAbsolutePaintRect):
  • platform/graphics/filters/FETurbulence.cpp: Ditto. (WebCore::FETurbulence::apply):
  • platform/graphics/filters/FETurbulence.h: (WebCore::FETurbulence::determineAbsolutePaintRect):
  • platform/graphics/filters/Filter.h: (WebCore::Filter::applyHorizontalScale): Map horizontal effect values to absolute coordinates. (WebCore::Filter::applyVerticalScale): Map vertical effect values to absolute coordinates. (WebCore::Filter::mapAbsolutePointToLocalPoint): (WebCore::Filter::filterRegionInUserSpace):
  • platform/graphics/filters/FilterEffect.cpp: Ditto. (WebCore::FilterEffect::determineFilterPrimitiveSubregion): (WebCore::FilterEffect::determineAbsolutePaintRect): (WebCore::FilterEffect::requestedRegionOfInputImageData): (WebCore::FilterEffect::drawingRegionOfInputImage): (WebCore::FilterEffect::effectContext):
  • platform/graphics/filters/FilterEffect.h: (WebCore::FilterEffect::absolutePaintRect): (WebCore::FilterEffect::setAbsolutePaintRect): (WebCore::FilterEffect::maxEffectRect): The subregion in absolute coordinates for SVG. (WebCore::FilterEffect::setMaxEffectRect):
  • platform/graphics/filters/SourceAlpha.cpp: Ditto. (WebCore::SourceAlpha::determineAbsolutePaintRect): (WebCore::SourceAlpha::apply):
  • platform/graphics/filters/SourceAlpha.h:
  • platform/graphics/filters/SourceGraphic.cpp: Ditto. (WebCore::SourceGraphic::determineAbsolutePaintRect): (WebCore::SourceGraphic::apply):
  • platform/graphics/filters/SourceGraphic.h:
  • rendering/RenderSVGResourceFilter.cpp: (WebCore::RenderSVGResourceFilter::applyResource): (WebCore::RenderSVGResourceFilter::postApplyResource):
  • rendering/RenderSVGResourceFilter.h: (WebCore::FilterData::FilterData):
  • svg/graphics/filters/SVGFEImage.cpp: Ditto. (WebCore::FEImage::apply):
  • svg/graphics/filters/SVGFEImage.h: (WebCore::FEImage::determineAbsolutePaintRect):
  • svg/graphics/filters/SVGFilter.cpp: (WebCore::SVGFilter::SVGFilter): (WebCore::SVGFilter::determineFilterPrimitiveSubregion): (WebCore::SVGFilter::applyHorizontalScale): (WebCore::SVGFilter::applyVerticalScale): (WebCore::SVGFilter::create):
  • svg/graphics/filters/SVGFilter.h: (WebCore::SVGFilter::effectBoundingBoxMode): (WebCore::SVGFilter::filterRegionInUserSpace): (WebCore::SVGFilter::filterRegion): (WebCore::SVGFilter::mapAbsolutePointToLocalPoint): Map absolute point to local point in userspace. (WebCore::SVGFilter::sourceImageRect): (WebCore::SVGFilter::maxImageSize):

2010-10-06 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVGs with filters look grainy when scaled
https://bugs.webkit.org/show_bug.cgi?id=5526

Added three new tests for SVGs filterRes.
Shadow tests for SVG Filter needed an update. Current tests didn't respect
primitiveUnits "objectBoundingBox" for stdDeviation on feGaussianBlur correctly.

  • platform/mac/svg/filters/filterRes1-expected.checksum: Added.
  • platform/mac/svg/filters/filterRes1-expected.png: Added.
  • platform/mac/svg/filters/filterRes1-expected.txt: Added.
  • platform/mac/svg/filters/filterRes2-expected.checksum: Added.
  • platform/mac/svg/filters/filterRes2-expected.png: Added.
  • platform/mac/svg/filters/filterRes2-expected.txt: Added.
  • platform/mac/svg/filters/filterRes3-expected.checksum: Added.
  • platform/mac/svg/filters/filterRes3-expected.png: Added.
  • platform/mac/svg/filters/filterRes3-expected.txt: Added.
  • platform/mac/svg/filters/shadow-on-filter-expected.txt:
  • platform/mac/svg/filters/shadow-on-rect-with-filter-expected.txt:
  • svg/filters/filterRes1.svg: Added.
  • svg/filters/filterRes2.svg: Added.
  • svg/filters/filterRes3.svg: Added.
  • svg/filters/shadow-on-filter.svg:
  • svg/filters/shadow-on-rect-with-filter.svg:
1:55 AM QtWebKitDocContrib edited by Henry Haverinen
(diff)
1:36 AM QtWebKitDocContrib edited by Henry Haverinen
(diff)
1:17 AM Changeset in webkit [69180] by podivilov@chromium.org
  • 3 edits in trunk/WebCore

2010-10-06 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: add "Set Breakpoint" item to XHR resource context menu.
https://bugs.webkit.org/show_bug.cgi?id=47085

  • English.lproj/localizedStrings.js:
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype._contextMenu):
12:37 AM Changeset in webkit [69179] by tkent@chromium.org
  • 2 edits
    7 adds in trunk/LayoutTests

2010-10-06 Kent Tamura <tkent@chromium.org>

Unreviewed, test expectation update.

Add Chromium results for r69176.

  • platform/chromium-linux/fast/forms/input-placeholder-focus-twice-expected.checksum: Added.
  • platform/chromium-linux/fast/forms/input-placeholder-focus-twice-expected.png: Added.
  • platform/chromium-mac/fast/forms/input-placeholder-focus-twice-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/input-placeholder-focus-twice-expected.png: Added.
  • platform/chromium-win/fast/forms/input-placeholder-focus-twice-expected.checksum: Added.
  • platform/chromium-win/fast/forms/input-placeholder-focus-twice-expected.png: Added.
  • platform/chromium-win/fast/forms/input-placeholder-focus-twice-expected.txt: Added.
  • platform/chromium/test_expectations.txt:

Oct 5, 2010:

10:52 PM Changeset in webkit [69178] by kinuko@chromium.org
  • 23 edits
    48 adds in trunk

2010-10-05 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by David Levin.

Add idl and mock classes for FileSystemSync for FileSystem API
https://bugs.webkit.org/show_bug.cgi?id=46405

Added bunch of *Sync classes, plus refactored some classes:
Added DOMFileSystemBase as a common base class for DOMFileSystem and
DOMFileSystemSync.
Added EntryBase as a common base class for Entry and EntrySync.
Added DirectoryReaderBase as a common base class for DirectoryReader and
DirectoryReaderSync.

Test: fast/filesystem/workers/

  • CMakeLists.txt: Added new files.
  • DerivedSources.cpp: Added new files.
  • DerivedSources.make: Added new files.
  • GNUmakefile.am: Added new files.
  • WebCore.gypi: Added new files.
  • WebCore.pri: Added new files.
  • WebCore.pro: Added new files.
  • WebCore.vcproj/WebCore.vcproj: Added new files. Also removed the duplicated fileapi\FileEntry.cpp entry.
  • WebCore.xcodeproj/project.pbxproj: Added new files.
  • bindings/js/JSDirectoryEntrySyncCustom.cpp: Added.
  • bindings/js/JSEntrySyncCustom.cpp: Added.
  • bindings/v8/custom/V8DirectoryEntrySyncCustom.cpp: Added.
  • bindings/v8/custom/V8EntrySyncCustom.cpp: Added.
  • fileapi/DOMFileSystemBase.cpp: Added.
  • fileapi/DOMFileSystemBase.h: Added.
  • fileapi/DOMFileSystemSync.cpp: Added.
  • fileapi/DOMFileSystemSync.h: Added.
  • fileapi/DOMFileSystemSync.idl: Added.
  • fileapi/DirectoryEntrySync.cpp: Added.
  • fileapi/DirectoryEntrySync.h: Added.
  • fileapi/DirectoryEntrySync.idl: Added.
  • fileapi/DirectoryReaderBase.h: Added.
  • fileapi/DirectoryReaderSync.cpp: Added.
  • fileapi/DirectoryReaderSync.h: Added.
  • fileapi/DirectoryReaderSync.idl: Added.
  • fileapi/EntryArraySync.cpp: Added.
  • fileapi/EntryArraySync.h: Added.
  • fileapi/EntryArraySync.idl: Added.
  • fileapi/EntryBase.h: Added.
  • fileapi/EntrySync.cpp: Added.
  • fileapi/EntrySync.h: Added.
  • fileapi/EntrySync.idl: Added.
  • fileapi/FileEntrySync.cpp: Added.
  • fileapi/FileEntrySync.h: Added.
  • fileapi/FileEntrySync.idl: Added.

2010-10-05 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by David Levin.

Add idl and mock classes for FileSystemSync for FileSystem API
https://bugs.webkit.org/show_bug.cgi?id=46405

Add small subset of tests for workers (and non-workers) that can be
tested with the current minimal implementation.

An entry method (requestFileSystemSync) is not yet exposed to the
WorkerContext in this patch, so workers/simple-*-sync-expected.txt
have reference errors for now.

  • fast/filesystem/resources/fs-worker-common.js: Added.
  • fast/filesystem/resources/fs-worker-test-post.js: Added.
  • fast/filesystem/resources/fs-worker-test-pre.js: Added.
  • fast/filesystem/resources/simple-persistent-sync.js: Added.
  • fast/filesystem/resources/simple-persistent.js: Added.
  • fast/filesystem/resources/simple-temporary-sync.js: Added.
  • fast/filesystem/resources/simple-temporary.js: Added.
  • fast/filesystem/simple-persistent-expected.txt: Added.
  • fast/filesystem/simple-persistent.html: Added.
  • fast/filesystem/simple-temporary-expected.txt: Added.
  • fast/filesystem/simple-temporary.html: Added.
  • fast/filesystem/workers/simple-persistent-expected.txt: Added.
  • fast/filesystem/workers/simple-persistent-sync-expected.txt: Added.
  • fast/filesystem/workers/simple-persistent-sync.html: Added.
  • fast/filesystem/workers/simple-persistent-sync.txt: Added.
  • fast/filesystem/workers/simple-persistent.html: Added.
  • fast/filesystem/workers/simple-temporary-expected.txt: Added.
  • fast/filesystem/workers/simple-temporary-sync-expected.txt: Added.
  • fast/filesystem/workers/simple-temporary-sync.html: Added.
  • fast/filesystem/workers/simple-temporary.html: Added.
  • fast/js/resources/fs-test-post.js: Added.
  • platform/chromium/test_expectations.txt: Added fast/filesystem/workers not to run them in regular test runs.
9:58 PM Changeset in webkit [69177] by dbates@webkit.org
  • 6 edits in trunk/WebKitTools

2010-10-05 Daniel Bates <dbates@rim.com>

Reviewed by David Kilzer.

Add infrastructure to towards detecting change log diffs that aren't at the top of the ChangeLog
https://bugs.webkit.org/show_bug.cgi?id=46058

Make VCSUtils::fixChangeLogPatch() return a reference to a hash
structure so as to support returning additional information
about a change log diff.

Currently, VCSUtils::fixChangeLogPatch() returns a string that
represents the change log diff. Towards supporting the return
of additional information, such as whether the change log diff
inserts an entry at the top of the ChangeLog file, we need to
make VCSUtils::fixChangeLogPatch() return a reference to hash
structure.

  • Scripts/VCSUtils.pm:
    • Modified fixChangeLogPatch() to return a reference to a hash structure.
    • Added documentation to fixChangeLogPatch().
    • Modified call site in mergeChangeLogs() as necessary.
  • Scripts/svn-apply:
    • Modified call site in patch() as necessary.
  • Scripts/svn-create-patch:
    • Modified call site in generateDiff() as necessary.
  • Scripts/svn-unapply:
    • Modified call site in patch() as necessary.
  • Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
    • Modified the unit tests as necessary.
9:36 PM Changeset in webkit [69176] by tkent@chromium.org
  • 5 edits
    4 adds in trunk

REGRESSION (r67166): "Placeholder" text remains in input box after 2nd focus()
https://bugs.webkit.org/show_bug.cgi?id=45940

Reviewed by Dimitri Glazkov.

WebCore:

Test: fast/forms/input-placeholder-focus-twice.html

  • html/HTMLFormControlElement.h: Make supportsPlaceholder() public.
  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::updateFromElement):

We always need to update the renderer value with the DOM value if
the element supports the placeholder feature.
Note: the placeholder feature and "unacceptable renderer value"
are exclusive.

LayoutTests:

  • fast/forms/input-placeholder-focus-twice.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/mac/fast/forms/input-placeholder-focus-twice-expected.checksum: Added.
  • platform/mac/fast/forms/input-placeholder-focus-twice-expected.png: Added.
  • platform/mac/fast/forms/input-placeholder-focus-twice-expected.txt: Added.
8:58 PM Changeset in webkit [69175] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-10-05 Kyusun Kim <maniagoon@company100.net>

Reviewed by Kent Tamura.

[BREWMP] Translate key code in PlatformKeyboardEvent with IKeysMapping
https://bugs.webkit.org/show_bug.cgi?id=47234

Brew MP devices have a variey of key configurations and use modifiers to
input capital letters, symbols and special characters. Use IKeysMapping to translate key code.

  • platform/brew/PlatformKeyboardEventBrew.cpp: (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
8:53 PM Changeset in webkit [69174] by Martin Robinson
  • 2 edits in trunk/LayoutTests

2010-10-05 Martin Robinson <mrobinson@igalia.com>

[GTK] editing/pasteboard/dataTransfer-setData-getData.html fails on GTK+
https://bugs.webkit.org/show_bug.cgi?id=47244

  • platform/gtk/Skipped: Skip this test as it's failing on GTK+ currently.
8:50 PM Changeset in webkit [69173] by jparent@chromium.org
  • 4 edits
    3 adds in trunk/LayoutTests

2010-10-05 Julie Parent <jparent@chromium.org>

Reviewed by Tony Chang.

[Chromium] Rebaseline svg/W3C-SVG-1.1/fonts-glyph-02-t.svg
https://bugs.webkit.org/show_bug.cgi?id=47229

  • platform/chromium-linux/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.png: Old baseline had invalid character.
  • platform/chromium-win/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.txt: Added.
  • platform/chromium/test_expectations.txt:Link to bug about crashing.
8:41 PM Changeset in webkit [69172] by commit-queue@webkit.org
  • 4 edits in trunk/WebCore

2010-10-05 W. James MacLean <wjmaclean@chromium.org>

Reviewed by James Robinson.

[chromium] Add mipmap support for ImageLayerChromium
https://bugs.webkit.org/show_bug.cgi?id=46493

Mipmap behaviour can be tested with existing tests.
Tests in LayoutTests/compositing/images/ will detect if
mipmaps fail.

  • platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::SharedValues::SharedValues): (WebCore::isPowerOfTwo): (WebCore::ContentLayerChromium::updateTextureRect):
  • platform/graphics/chromium/ContentLayerChromium.h: (WebCore::ContentLayerChromium::SharedValues::npotSupported):
  • platform/graphics/chromium/ImageLayerChromium.cpp: (WebCore::ImageLayerChromium::updateContents):
8:38 PM Changeset in webkit [69171] by tony@chromium.org
  • 2 edits in trunk/WebKitTools

2010-10-05 Tony Chang <tony@chromium.org>

Reviewed by Darin Adler.

fix the link to the expected image on windows
https://bugs.webkit.org/show_bug.cgi?id=47228

  • Scripts/webkitpy/layout_tests/test_types/test_type_base.py: On

windows, the file must be opened in binary mode when writing
binary data.

8:04 PM Changeset in webkit [69170] by abarth@webkit.org
  • 4 edits in trunk

2010-10-05 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Issue in treebuilder parsing related to table tags
https://bugs.webkit.org/show_bug.cgi?id=47190

Add test coverage.

  • html5lib/resources/webkit02.dat:

2010-10-05 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Issue in treebuilder parsing related to table tags
https://bugs.webkit.org/show_bug.cgi?id=47190

Update ASSERT to match the spec and our behavior.

  • html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processEndTagForInCell):
7:51 PM Changeset in webkit [69169] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-10-05 Adam Barth <abarth@webkit.org>

Update expected result of unittest to match Tony's change below.

  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
7:42 PM Changeset in webkit [69168] by kbr@google.com
  • 2 edits in trunk/LayoutTests

2010-10-05 Kenneth Russell <kbr@google.com>

Unreviewed, test expectations update.

Added initial skip list for Chromium GPU testing. With this list,
runs are clean with:
new-run-webkit-tests --chromium --platform chromium-gpu --use-drt --debug

  • platform/chromium-gpu/test_expectations.txt:
7:35 PM Changeset in webkit [69167] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

2010-10-05 Kent Tamura <tkent@chromium.org>

Unreviewed, test expectation update.

  • platform/chromium/test_expectations.txt:
6:40 PM Changeset in webkit [69166] by hclam@chromium.org
  • 7 edits in trunk/WebCore

VideoLayerChromium releases old resources if the LayerRenderer changes.
https://bugs.webkit.org/show_bug.cgi?id=47030

Submitted for Victoria Kirst <vrk@google.com>.
Reviewed by James Robinson.

Refactored LayerChromium to have a virtual cleanupResources() method
that will release textures/other context-dependent resources when a
LayerRenderer changes. ContentLayerChromium and VideoLayerChromium now
override this method to perform cleanup.

  • platform/graphics/chromium/ContentLayerChromium.cpp:
  • platform/graphics/chromium/ContentLayerChromium.h:
  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::setLayerRenderer):

  • platform/graphics/chromium/LayerChromium.h:

(WebCore::LayerChromium::cleanupResources):

  • platform/graphics/chromium/VideoLayerChromium.cpp:

(WebCore::VideoLayerChromium::~VideoLayerChromium):
(WebCore::VideoLayerChromium::cleanupResources):

  • platform/graphics/chromium/VideoLayerChromium.h:
6:34 PM Changeset in webkit [69165] by kinuko@chromium.org
  • 3 edits
    3 adds in trunk

2010-10-05 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by Jian Li.

FileEntry::file needs to be implemented
https://bugs.webkit.org/show_bug.cgi?id=47192

Test: fast/filesystem/file-from-file-entry.html

  • fileapi/FileEntry.cpp: (WebCore::FileEntry::file): Implemented.

2010-10-05 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by Jian Li.

FileEntry::file needs to be implemented
https://bugs.webkit.org/show_bug.cgi?id=47192

  • fast/filesystem/file-from-file-entry-expected.txt: Added.
  • fast/filesystem/file-from-file-entry.html: Added.
  • fast/filesystem/script-tests/file-from-file-entry.js: Added.
5:59 PM Changeset in webkit [69164] by jam@chromium.org
  • 1 edit in trunk/WebKit/chromium/src/ChromeClientImpl.cpp

Fix Chrome build.

5:52 PM Changeset in webkit [69163] by hclam@chromium.org
  • 12 edits in trunk

WebCore: Render textures in video frame directly.
https://bugs.webkit.org/show_bug.cgi?id=46765

Reviewed by NOBODY (OOPS!).

Render textures in VideoLayerChromium directly if the video frame type
is GL texture. In the future VideoLayerChromium will not allocate
textures and perform textures upload as those operations will be done
in Chromium to minimize memory copy. This patch will help moving toward
this direction and facilitate hardware video decoding.

  • platform/graphics/chromium/VideoFrameChromium.h:
  • platform/graphics/chromium/VideoFrameProvider.h:

(WebCore::VideoFrameProvider::~VideoFrameProvider):

  • platform/graphics/chromium/VideoLayerChromium.cpp:

(WebCore::VideoLayerChromium::VideoLayerChromium):
(WebCore::VideoLayerChromium::~VideoLayerChromium):
(WebCore::VideoLayerChromium::updateContents):
(WebCore::VideoLayerChromium::draw):
(WebCore::VideoLayerChromium::releaseCurrentFrame):
(WebCore::VideoLayerChromium::resetFrameParameters):
(WebCore::VideoLayerChromium::saveCurrentFrame):

  • platform/graphics/chromium/VideoLayerChromium.h:

(WebCore::VideoLayerChromium::SharedValues::initialized):

WebKit/chromium: Add getter for accessing textures stored in VideoFrameChromium and WebVideoFrame.
Also explicitly instruct VideoLayerChromium to release video frame when the owner
of video frame is going away.

Reviewed by NOBODY (OOPS!).

  • public/WebVideoFrame.h:
  • src/AssertMatchingEnums.cpp:
  • src/VideoFrameChromiumImpl.cpp:

(WebKit::VideoFrameChromiumImpl::texture):

  • src/VideoFrameChromiumImpl.h:
  • src/WebMediaPlayerClientImpl.cpp:

(WebKit::WebMediaPlayerClientImpl::~WebMediaPlayerClientImpl):
(WebKit::WebMediaPlayerClientImpl::load):

  • src/WebMediaPlayerClientImpl.h:
4:55 PM Changeset in webkit [69162] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit/chromium

2010-10-05 Nat Duca <nduca@chromium.org>

Reviewed by James Robinson.

[chromium] Handle composited root layer invalidations in screenspace,
fixing the disappearing scrollbar problem.
https://bugs.webkit.org/show_bug.cgi?id=46864

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::composite): (WebKit::WebViewImpl::scrollRootLayerRect): (WebKit::WebViewImpl::invalidateRootLayerRect): (WebKit::WebViewImpl::doComposite):
4:55 PM Changeset in webkit [69161] by fsamuel@chromium.org
  • 6 edits in trunk

2010-10-05 Fady Samuel <fsamuel@chromium.org>

Reviewed by Darin Adler.

REGRESSION (r65539): One pixel white gaps when scrolling Trac changeset pages
https://bugs.webkit.org/show_bug.cgi?id=45131

Added a layout test to check for paint rects that touch the border of an adjacent sell,
when border-collapse: separate is set for the table.

  • fast/table/simple_paint.html:

Don't do rtl as it doesn't exercise some of the new paint code.

  • fast/table/simple_paint_separate_borders-expected.checksum: Added.
  • fast/table/simple_paint_separate_borders-expected.png: Added.
  • fast/table/simple_paint_separate_borders-expected.txt: Added.
  • fast/table/simple_paint_separate_borders.html: Added.

2010-10-05 Fady Samuel <fsamuel@chromium.org>

Reviewed by Darin Adler.

REGRESSION (r65539): One pixel white gaps when scrolling Trac changeset pages
https://bugs.webkit.org/show_bug.cgi?id=45131

When border-collapse: separate property is set on the table, paintObject
may skip repainting cells, if the dirty region only touches one row/col of pixels.

Test: fast/table/simple_paint_separate_borders.html

  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::paintObject):

Don't subtract one from the right and bottom of the dirty paint rect.

4:39 PM Changeset in webkit [69160] by tony@chromium.org
  • 2 edits in trunk/WebKitTools

2010-10-05 Tony Chang <tony@chromium.org>

Reviewed by Ojan Vafai (over the shoulder).

Paper over errors in image_diff so we don't crash the whole test run.

  • Scripts/webkitpy/layout_tests/port/chromium.py:
4:15 PM Changeset in webkit [69159] by commit-queue@webkit.org
  • 3 edits in trunk/WebCore

2010-10-05 Sanjeev Radhakrishnan <sanjeevr@chromium.org>

Reviewed by Darin Fisher.

PluginDocument now holds on to the created plugin node so that the pluginNode() and pluginWidget() methods can return the correct node.
https://bugs.webkit.org/show_bug.cgi?id=47129

  • html/PluginDocument.cpp: (WebCore::PluginDocumentParser::createDocumentStructure): (WebCore::PluginDocument::pluginWidget): (WebCore::PluginDocument::pluginNode):
  • html/PluginDocument.h: (WebCore::PluginDocument::setPluginNode):
4:01 PM Changeset in webkit [69158] by jianli@chromium.org
  • 4 edits
    1 copy in branches/chromium/517/WebCore

Merge 69148 - [V8] Add FileReader to active DOM map
https://bugs.webkit.org/show_bug.cgi?id=47205

Reviewed by Nate Chapin.

We need to have a custom FileReader V8 constructor in order to add object
into active DOM map to prevent it from GC-ed when it is still in-use.

  • Android.v8bindings.mk:
  • WebCore.gypi:
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/custom/V8FileReaderCustom.cpp: Added.

(WebCore::V8FileReader::constructorCallback):

  • fileapi/FileReader.idl:

TBR=jianli@chromium.org
Review URL: http://codereview.chromium.org/3520018

4:00 PM Changeset in webkit [69157] by kbr@google.com
  • 2 edits in trunk/WebKit/chromium

2010-10-05 Kenneth Russell <kbr@google.com>

Unreviewed, follow up to 47216. Add newline above "protected:".

  • public/WebFrame.h:
3:55 PM Changeset in webkit [69156] by tony@chromium.org
  • 2 edits in trunk/WebKitTools

2010-10-05 Tony Chang <tony@chromium.org>

Unreviewed, make shutil.rmtree more resiliant to errors
since windows was raising WindowsError: The process cannot access the file because it
is being used by another process.

  • Scripts/webkitpy/layout_tests/port/chromium.py:
3:49 PM Changeset in webkit [69155] by andersca@apple.com
  • 5 edits in trunk/WebKit2

Send null events and mouse events
https://bugs.webkit.org/show_bug.cgi?id=47223

Reviewed by Sam Weinig.

  • WebKit2.xcodeproj/project.pbxproj:

Add "-Wno-deprecated-declarations" to the COMPILER_FLAGS for NetscapePluginMac.mm since
we call Button() which is deprecated.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::NetscapePlugin):
Initialize the null event timer.

  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:

(WebKit::NetscapePlugin::platformPostInitialize):
Start the null event timer.

(WebKit::NetscapePlugin::platformDestroy):
Stop the null event timer.

(WebKit::NetscapePlugin::platformHandleMouseEvent):
Initialize the event record and call NPP_HandleEvent.

(WebKit::NetscapePlugin::nullEventTimerFired):
Send a null event with the current mouse position.

3:45 PM Changeset in webkit [69154] by jam@chromium.org
  • 5 edits in trunk/WebKit

2010-10-05 John Abd-El-Malek <jam@chromium.org>

Reviewed by Darin Fisher.

[chromium] Get the link from a plugin when creating a context menu
https://bugs.webkit.org/show_bug.cgi?id=47130

  • chromium/public/WebPlugin.h: (WebKit::WebPlugin::linkAtPosition):
  • chromium/public/WebView.h:
  • chromium/src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::mouseDidMoveOverElement):
  • chromium/src/ContextMenuClientImpl.cpp: (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
3:33 PM Changeset in webkit [69153] by tony@chromium.org
  • 5 edits in trunk/WebKitTools

2010-10-05 Tony Chang <tony@chromium.org>

Reviewed by Ojan Vafai.

[chromium] fix image diffing in NRWT
https://bugs.webkit.org/show_bug.cgi?id=47128

  • Scripts/webkitpy/layout_tests/port/chromium.py: Stop using

NamedTemporaryFile since it doesn't work on Windows.

  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3:21 PM Changeset in webkit [69152] by jhoneycutt@apple.com
  • 2 edits in trunk/WebKit/win

Prevent an assertion failure when trying to create a protection space
for file/data URLs.

Reviewed by Sam Weinig.

  • WebURLProtectionSpace.cpp:

(WebURLProtectionSpace::initWithHost):
Remove the ASSERT_NOT_REACHED().

3:11 PM Changeset in webkit [69151] by kbr@google.com
  • 7 edits in trunk

2010-10-05 Kenneth Russell <kbr@google.com>

Reviewed by Tony Chang.

[chromium] Implement layerTreeAsText in DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=47216

Plumbed Frame::layerTreeAsText through Chromium's WebKit API to
make it callable from DumpRenderTree.

No new tests; verified with existing compositor layout tests.

  • public/WebFrame.h:
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::layerTreeAsText):
  • src/WebFrameImpl.h:

2010-10-05 Kenneth Russell <kbr@google.com>

Reviewed by Tony Chang.

[chromium] Implement layerTreeAsText in DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=47216

Plumbed Frame::layerTreeAsText through Chromium's WebKit API to
make it callable from DumpRenderTree.

No new tests; verified with existing compositor layout tests.

  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::layerTreeAsText):
  • DumpRenderTree/chromium/LayoutTestController.h:
2:46 PM CSS21Results edited by Simon Fraser
(diff)
2:44 PM CSS21Results edited by Simon Fraser
(diff)
2:43 PM CSS21Results edited by Simon Fraser
(diff)
2:43 PM CSS21Results edited by Simon Fraser
(diff)
2:42 PM Changeset in webkit [69150] by andersca@apple.com
  • 4 edits in trunk/WebKit2

Start sending Carbon plug-in events in th Carbon event model
https://bugs.webkit.org/show_bug.cgi?id=47209
<rdar://problem/8515677>

Reviewed by Sam Weinig.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::NetscapePlugin):
Initialize the NP_CGContext struct.

  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:

(WebKit::NetscapePlugin::platformPostInitialize):
Create a fake Carbon window.

(WebKit::NetscapePlugin::platformDestroy):
Destroy the Carbon window.

(WebKit::modifiersForEvent):
Given a WebEvent, return the EventRecord modifiers.

(WebKit::NetscapePlugin::platformPaint):
(WebKit::NetscapePlugin::platformHandleMouseEvent):
(WebKit::NetscapePlugin::platformHandleWheelEvent):
(WebKit::NetscapePlugin::platformHandleMouseEnterEvent):
(WebKit::NetscapePlugin::platformHandleMouseLeaveEvent):
(WebKit::NetscapePlugin::platformSetFocus):
(WebKit::NetscapePlugin::windowFocusChanged):
Create Carbon EventRecords and call NPP_HandleEvent.

2:41 PM Changeset in webkit [69149] by andreas.kling@nokia.com
  • 2 edits in trunk/WebCore

2010-10-05 Andreas Kling <kling@webkit.org>

Reviewed by Tor Arne Vestbø.

[Qt] Re-enable single-NPP_SetWindow quirk for 64-bit
https://bugs.webkit.org/show_bug.cgi?id=45363

This is still causing trouble for people, so let's put the
quirk back until we can figure this out properly.

  • plugins/PluginPackage.cpp: (WebCore::PluginPackage::determineQuirks):
2:41 PM CSS21Results edited by Simon Fraser
(diff)
2:38 PM Changeset in webkit [69148] by jianli@chromium.org
  • 5 edits
    1 copy in trunk/WebCore

[V8] Add FileReader to active DOM map
https://bugs.webkit.org/show_bug.cgi?id=47205

Reviewed by Nate Chapin.

We need to have a custom FileReader V8 constructor in order to add object
into active DOM map to prevent it from GC-ed when it is still in-use.

  • Android.v8bindings.mk:
  • WebCore.gypi:
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/custom/V8FileReaderCustom.cpp: Added.

(WebCore::V8FileReader::constructorCallback):

  • fileapi/FileReader.idl:
2:37 PM Changeset in webkit [69147] by rniwa@webkit.org
  • 3 edits
    2 adds
    18 deletes in trunk/LayoutTests

2010-10-04 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Tony Chang.

dump-as-markup conversion: editing/execCommand/format-block-with-braces.html and format-block.html
https://bugs.webkit.org/show_bug.cgi?id=47098

Converted editing/execCommand/format-block-with-braces.html and format-block.html to dump-as-text tests.

  • editing/execCommand/format-block-expected.txt: Added.
  • editing/execCommand/format-block-with-braces-expected.txt: Added.
  • editing/execCommand/format-block-with-braces.html:
  • editing/execCommand/format-block.html:
  • platform/chromium-linux/editing/execCommand/format-block-expected.checksum: Removed.
  • platform/chromium-linux/editing/execCommand/format-block-expected.png: Removed.
  • platform/chromium-linux/editing/execCommand/format-block-with-braces-expected.checksum: Removed.
  • platform/chromium-linux/editing/execCommand/format-block-with-braces-expected.png: Removed.
  • platform/chromium-win/editing/execCommand/format-block-expected.checksum: Removed.
  • platform/chromium-win/editing/execCommand/format-block-expected.png: Removed.
  • platform/chromium-win/editing/execCommand/format-block-expected.txt: Removed.
  • platform/chromium-win/editing/execCommand/format-block-with-braces-expected.checksum: Removed.
  • platform/chromium-win/editing/execCommand/format-block-with-braces-expected.png: Removed.
  • platform/chromium-win/editing/execCommand/format-block-with-braces-expected.txt: Removed.
  • platform/mac/editing/execCommand/format-block-expected.checksum: Removed.
  • platform/mac/editing/execCommand/format-block-expected.png: Removed.
  • platform/mac/editing/execCommand/format-block-expected.txt: Removed.
  • platform/mac/editing/execCommand/format-block-with-braces-expected.checksum: Removed.
  • platform/mac/editing/execCommand/format-block-with-braces-expected.png: Removed.
  • platform/mac/editing/execCommand/format-block-with-braces-expected.txt: Removed.
  • platform/qt/editing/execCommand/format-block-expected.txt: Removed.
  • platform/qt/editing/execCommand/format-block-with-braces-expected.txt: Removed.
2:36 PM CSS21Results created by Simon Fraser
2:35 PM WikiStart edited by Simon Fraser
(diff)
2:34 PM WikiStart edited by Simon Fraser
(diff)
2:34 PM WikiStart edited by Simon Fraser
(diff)
2:32 PM Changeset in webkit [69146] by bfulgham@webkit.org
  • 2 edits in trunk/WebKitTools

Unreviewed build correction.

  • DumpRenderTree/win/ImageDiff.vcproj: Use WinCairo debug

property sheet so proper libraries are linked.

2:32 PM Changeset in webkit [69145] by bfulgham@webkit.org
  • 2 edits in trunk/WebKit/win

Unreviewed build correction.

  • WebKit.vcproj/WebKit.sln: Turn the QTMovieWin project

off for WinCairo release builds. Somehow this was
incorrectly turned on.

1:59 PM Changeset in webkit [69144] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-10-05 Vincent Scheib <scheib@chromium.org>

Reviewed by Kenneth Russell.

[chromium] 51304 GPU compositor resorts to "slow" text rendering for base page layer
https://bugs.webkit.org/show_bug.cgi?id=47193

Test: Accelerated compositor test infrastructure still coming online. Tested manually.

  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::setRootLayerCanvasSize): (WebCore::LayerRendererChromium::prepareToDrawLayers): (WebCore::LayerRendererChromium::drawLayers):
1:41 PM Changeset in webkit [69143] by atwilson@chromium.org
  • 4 edits in trunk/WebKit

2010-10-05 Andrew Wilson <atwilson@chromium.org>

Reviewed by Andreas Kling.

Notification onclick() events don't act like user gestures
https://bugs.webkit.org/show_bug.cgi?id=47137

  • src/WebNotification.cpp: (WebKit::WebNotification::dispatchClickEvent): Use UserGestureIndicator to make sure click events are treated like user gestures.

2010-10-05 Andrew Wilson <atwilson@chromium.org>

Reviewed by Andreas Kling.

Notification onclick() events don't act like user gestures
https://bugs.webkit.org/show_bug.cgi?id=47137

  • WebCoreSupport/NotificationPresenterClientQt.cpp: (WebCore::NotificationPresenterClientQt::notificationClicked): Use UserGestureIndicator to make sure click events are treated like user gestures.
1:39 PM Changeset in webkit [69142] by thakis@chromium.org
  • 2 edits in trunk/WebCore

2010-10-05 Nico Weber <thakis@chromium.org>

Reviewed by Andreas Kling.

Fix clang build
https://bugs.webkit.org/show_bug.cgi?id=47198

  • page/Chrome.h: Declare ViewportArguments as struct, not as class.
1:32 PM Changeset in webkit [69141] by hyatt@apple.com
  • 3 edits
    4 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=47204

Reviewed by Sam Weinig.

Make isSelfCollapsingBlock use logical height instead of height in all its checks.

Added fast/blockflow/self-collapsing-block.html

WebCore:

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::isSelfCollapsingBlock):

LayoutTests:

  • fast/blockflow/self-collapsing-block.html: Added.
  • platform/mac/fast/blockflow/self-collapsing-block-expected.checksum: Added.
  • platform/mac/fast/blockflow/self-collapsing-block-expected.png: Added.
  • platform/mac/fast/blockflow/self-collapsing-block-expected.txt: Added.
1:28 PM Changeset in webkit [69140] by commit-queue@webkit.org
  • 3 edits in trunk/WebCore

2010-10-05 Eric Uhrhane <ericu@chromium.org>

Reviewed by David Levin.

Relax restrictions on FileWriter::didWrite calls
https://bugs.webkit.org/show_bug.cgi?id=47139

No new tests; they're still waiting on the first implementation.

  • fileapi/FileWriter.cpp: (WebCore::FileWriter::FileWriter): (WebCore::FileWriter::write): (WebCore::FileWriter::didWrite):
  • fileapi/FileWriter.h:
1:17 PM Changeset in webkit [69139] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit/chromium

2010-10-05 Alok Priyadarshi <alokp@chromium.org>

Reviewed by Kenneth Russell.

Supported ANGLE SH_VERSION > 100
https://bugs.webkit.org/show_bug.cgi?id=47024

  • src/WebGraphicsContext3DDefaultImpl.cpp: (WebKit::WebGraphicsContext3DDefaultImpl::angleCreateCompilers): (WebKit::WebGraphicsContext3DDefaultImpl::angleValidateShaderSource):
1:13 PM Changeset in webkit [69138] by commit-queue@webkit.org
  • 7 edits in trunk

2010-10-05 Daniel Cheng <dcheng@chromium.org>

Reviewed by Tony Chang.

[chromium] getData('text/uri-list') should return the same thing that was passed to setData('text/uri-list')
https://bugs.webkit.org/show_bug.cgi?id=46943

Update the layout test to check that getData('text/uri-list') returns
the same thing that was passed to setData('text/uri-list').

  • editing/pasteboard/dataTransfer-setData-getData-expected.txt:
  • editing/pasteboard/script-tests/dataTransfer-setData-getData.js: (doDrop): (test): (runTest):
  • fast/js/resources/js-test-pre.js: (shouldBeEqualToString): Updated to allow '\n' and '\r' in expected argument.

2010-10-05 Daniel Cheng <dcheng@chromium.org>

Reviewed by Tony Chang.

[chromium] getData('text/uri-list') should return the same thing that was passed to setData('text/uri-list')
https://bugs.webkit.org/show_bug.cgi?id=46943

We no longer parse the input of setData('text/uri-list') and only store
the valid URLs that were parsed out.

Test: editing/pasteboard/dataTransfer-setData-getData.html

  • platform/chromium/ChromiumDataObject.cpp: (WebCore::ChromiumDataObject::clearData): (WebCore::ChromiumDataObject::clearAllExceptFiles): (WebCore::ChromiumDataObject::types): (WebCore::ChromiumDataObject::getData): (WebCore::ChromiumDataObject::setData):
  • platform/chromium/ChromiumDataObject.h:
1:09 PM Changeset in webkit [69137] by Martin Robinson
  • 3 edits in trunk/WebCore

2010-10-05 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Support FontPlatformData::isFixedPitch for custom fonts
https://bugs.webkit.org/show_bug.cgi?id=47124

Instead of determining whether or not a font is a fixed-width font
lazily, do it up front. For fonts not backed by Fontconfig patterns,
fetch information about whether or not the font is fixed-width from
the FreeType face.

No new tests as this should not change functionality.

  • platform/graphics/cairo/FontPlatformDataFreeType.cpp: (WebCore::FontPlatformData::FontPlatformData): Initialize the m_fixedWidth member from the Fontconfig pattern or the FreeType face. (WebCore::FontPlatformData::operator=): Copy over the m_fixedWidth member. (WebCore::FontPlatformData::isFixedPitch): Just return the value of the m_fixedWidth member.
  • platform/graphics/cairo/FontPlatformDataFreeType.h: Added an m_fixedWidth member.
1:01 PM Changeset in webkit [69136] by hyatt@apple.com
  • 4 edits
    4 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=47199

Reviewed by Anders Carlsson.

Make float positioning work in block layout with block children.
It doesn't work yet from inside line layout, since line layout is unpatched.

Added fast/blockflow/floats-in-block-layout.html

WebCore:

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::adjustFloatingBlock):
(WebCore::RenderBlock::setLogicalLeftForChild):
(WebCore::RenderBlock::setLogicalTopForChild):
(WebCore::RenderBlock::insertFloatingObject):
(WebCore::RenderBlock::positionNewFloats):
(WebCore::RenderBlock::logicalLeftOffsetForLine):
(WebCore::RenderBlock::logicalRightOffsetForLine):

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::FloatingObject::type):
(WebCore::RenderBlock::FloatingObject::renderer):
(WebCore::RenderBlock::logicalRightForFloat):
(WebCore::RenderBlock::setLogicalTopForFloat):
(WebCore::RenderBlock::setLogicalLeftForFloat):
(WebCore::RenderBlock::setLogicalHeightForFloat):
(WebCore::RenderBlock::setLogicalWidthForFloat):

LayoutTests:

  • fast/blockflow/floats-in-block-layout.html: Added.
  • platform/mac/fast/blockflow/floats-in-block-layout-expected.checksum: Added.
  • platform/mac/fast/blockflow/floats-in-block-layout-expected.png: Added.
  • platform/mac/fast/blockflow/floats-in-block-layout-expected.txt: Added.
12:14 PM Changeset in webkit [69135] by commit-queue@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-10-05 Kwang Yul Seo <skyul@company100.net>

Reviewed by Gavin Barraclough.

[BREWMP] Port ExecutableAllocator::cacheFlush to enable ARM JIT
https://bugs.webkit.org/show_bug.cgi?id=47117

Use IMemCache1 to flush data cache and invalidate instruction cache.

  • jit/ExecutableAllocator.h: (JSC::ExecutableAllocator::cacheFlush):
12:13 PM Changeset in webkit [69134] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-10-05 Kimmo Kinnunen <kimmo.t.kinnunen@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Web process crash when pressing modifiers in input field
https://bugs.webkit.org/show_bug.cgi?id=44935

Revert part of the http://trac.webkit.org/changeset/69105 due to a
test regression. Unix: Add ASSERTs to plugin related code. These
will fail if Qt WebKit2 is used with plugins, unless code is not
fixed before.

  • plugins/qt/PluginViewQt.cpp: (WebCore::setXKeyEventSpecificFields): Use qKeyEvent, Use ASSERT as a reminder.
12:01 PM Changeset in webkit [69133] by robert@webkit.org
  • 6 edits in trunk

2010-10-05 Robert Hogan <robert@webkit.org>

Reviewed by Andreas Kling.

[Qt] Fix url conversion in QWebHistory

Converting from KURL to WFT::String to QUrl does not
permit proper percent encoding later.

Unskp tests that now pass:

http/tests/navigation/postredirect-goback2.html
http/tests/navigation/error404-frames.html
http/tests/navigation/post-basic.html
http/tests/navigation/post-frames.html
http/tests/navigation/post-goback1.html
http/tests/navigation/anchor-frames.html

These produce only rendertree differences with '--platform mac'.
Unskipping so we can get Qt-specific results from bot:

http/tests/navigation/error404-basic.html
http/tests/navigation/error404-goback.html
http/tests/navigation/error404-subframeload.html
http/tests/navigation/javascriptlink-frames.html
http/tests/navigation/postredirect-basic.html
http/tests/navigation/postredirect-frames.html
http/tests/navigation/postredirect-goback1.html

https://bugs.webkit.org/show_bug.cgi?id=47048

  • platform/qt/Skipped:

2010-10-05 Robert Hogan <robert@webkit.org>

Reviewed by Andreas Kling.

[Qt] Fix url conversion in QWebHistory

Converting from KURL to WFT::String to QUrl does not
permit proper percent encoding later.

https://bugs.webkit.org/show_bug.cgi?id=47048

  • Api/qwebhistory.cpp: (QWebHistoryItem::originalUrl): (QWebHistoryItem::url):

2010-10-05 Robert Hogan <robert@webkit.org>

Reviewed by Andreas Kling.

[Qt] Fix url conversion in QWebHistory

Converting from KURL to WFT::String to QUrl does not
permit proper percent encoding later.

https://bugs.webkit.org/show_bug.cgi?id=47048

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::dumpHistoryItem):
11:58 AM Changeset in webkit [69132] by leandro@webkit.org
  • 2 edits
    1 move in trunk/JavaScriptCore

2010-10-05 Leandro Pereira <leandro@profusion.mobi>

Unreviewed. Build fix.

Moved "jsc" directory to "shell", so that the name does not clash with the
JavaScriptCore shell in some build systems.
http://webkit.org/b/47049

  • CMakeLists.txt: Changed reference from "jsc" to "shell".
  • jsc: Removed.
  • jsc/CMakeLists.txt: Removed.
  • jsc/CMakeListsEfl.txt: Removed.
  • shell: Copied from JavaScriptCore/jsc.
11:48 AM Changeset in webkit [69131] by crogers@google.com
  • 1 edit
    2 adds in trunk/WebCore

2010-10-05 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

Add AudioBasicProcessorNode files
https://bugs.webkit.org/show_bug.cgi?id=46495

No new tests since audio API is not yet implemented.

  • webaudio/AudioBasicProcessorNode.cpp: Added. (WebCore::AudioBasicProcessorNode::AudioBasicProcessorNode): (WebCore::AudioBasicProcessorNode::initialize): (WebCore::AudioBasicProcessorNode::uninitialize): (WebCore::AudioBasicProcessorNode::process): (WebCore::AudioBasicProcessorNode::pullInputs): (WebCore::AudioBasicProcessorNode::reset): (WebCore::AudioBasicProcessorNode::checkNumberOfChannelsForInput): (WebCore::AudioBasicProcessorNode::numberOfChannels):
  • webaudio/AudioBasicProcessorNode.h: Added. (WebCore::AudioBasicProcessorNode::processor):
11:39 AM Changeset in webkit [69130] by tony@chromium.org
  • 9 edits in trunk/LayoutTests

2010-10-05 Tony Chang <tony@chromium.org>

Unreviewed, updating chromium linux baselines after landing r69126
which changed how really short scrollbars are painted.

  • platform/chromium-linux/fast/frames/invalid-expected.checksum:
  • platform/chromium-linux/fast/frames/invalid-expected.png:
  • platform/chromium-linux/fast/frames/valid-expected.checksum:
  • platform/chromium-linux/fast/frames/valid-expected.png:
  • platform/chromium-linux/fast/replaced/width100percent-textarea-expected.checksum:
  • platform/chromium-linux/fast/replaced/width100percent-textarea-expected.png:
  • platform/chromium-linux/fast/text/drawBidiText-expected.checksum:
  • platform/chromium-linux/fast/text/drawBidiText-expected.png:
11:36 AM Changeset in webkit [69129] by andersca@apple.com
  • 4 edits in trunk/WebKitTools

REGRESSION (r68966?): All dumpAsText test fail on WebKit2
https://bugs.webkit.org/show_bug.cgi?id=47188
<rdar://problem/8514104>

Reviewed by Sam Weinig.

When constructing the std::string, use the real string length instead of the maximum buffer size.

  • TestWebKitAPI/PlatformUtilities.h:

(TestWebKitAPI::Util::toSTD):

  • WebKitTestRunner/StringFunctions.h:

(WTR::toSTD):

11:35 AM Changeset in webkit [69128] by cmarrin@apple.com
  • 2 edits in trunk/WebCore

2010-10-05 Chris Marrin <cmarrin@apple.com>

Unreviewed.

The platform/graphics/gpu folder was mistakenly inside the filters folder.
I moved it to the right place in the Group Tree.

  • WebCore.xcodeproj/project.pbxproj:
11:20 AM Changeset in webkit [69127] by cmarrin@apple.com
  • 2 edits in trunk/WebCore

2010-10-05 Chris Marrin <cmarrin@apple.com>

Reviewed by Adam Roben.

Fix ownership of GraphicsContext3D in SharedGraphicsContext3D to prevent early deallocation and crash
https://bugs.webkit.org/show_bug.cgi?id=47197

This is work in progress and the crash only happens with ACCELERATED_2D_CANVAS turned on (which is off
by default). Many existing test cases will crash before and after this patch.

  • platform/graphics/gpu/SharedGraphicsContext3D.cpp: (WebCore::SharedGraphicsContext3D::create):
10:58 AM Changeset in webkit [69126] by tony@chromium.org
  • 6 edits in trunk

2010-10-05 Tony Chang <tony@chromium.org>

Reviewed by Kent Tamura.

[chromium] properly paint really small scrollbar arrows on linux
https://bugs.webkit.org/show_bug.cgi?id=47109

  • platform/chromium-linux/fast/frames/onlyCommentInIFrame-expected.checksum:
  • platform/chromium-linux/fast/frames/onlyCommentInIFrame-expected.png:
  • platform/chromium/test_expectations.txt: Remove passing test and remove windows test that has no failures on

the dashboard

2010-10-05 Tony Chang <tony@chromium.org>

Reviewed by Kent Tamura.

[chromium] properly paint really small scrollbar arrows on linux
https://bugs.webkit.org/show_bug.cgi?id=47109

  • platform/chromium/ScrollbarThemeChromiumLinux.cpp: (WebCore::ScrollbarThemeChromiumLinux::buttonSize): Clamp button size based on available size. This matches what

we do on Win.

10:44 AM Changeset in webkit [69125] by Nate Chapin
  • 3 edits in trunk/WebCore

2010-10-05 Nate Chapin <Nate Chapin>

Reviewed by David Levin.

Remove unused CachedResource::Status values (New and NotCached).
https://bugs.webkit.org/show_bug.cgi?id=47132

Refactor only, no new tests.

  • loader/CachedResource.h:
  • loader/CachedResourceLoader.cpp: (WebCore::CachedResourceLoader::checkCacheObjectStatus):
10:34 AM Changeset in webkit [69124] by commit-queue@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-10-05 Kwang Yul Seo <skyul@company100.net>

Reviewed by Kent Tamura.

[BREWMP] Use PlatformRefPtr in randomNumber
https://bugs.webkit.org/show_bug.cgi?id=46989

Use PlatformRefPtr to free memory automatically.

  • wtf/RandomNumber.cpp: (WTF::randomNumber):
10:17 AM Changeset in webkit [69123] by jorlow@chromium.org
  • 17 edits in trunk

2010-10-04 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Nate Chapin.

Rename get* and open*Cursor per the spec on IDBIndex
https://bugs.webkit.org/show_bug.cgi?id=46906

The spec changed so that:
IDBIndex.get -> getKey
IDBIndex.getObject -> get
IDBIndex.openCursor -> openKeyCursor
IDBIndex.openObjectCursor -> openCursor

  • storage/indexeddb/index-basics-expected.txt:
  • storage/indexeddb/index-basics.html:
  • storage/indexeddb/index-cursor.html:

2010-10-04 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Nate Chapin.

Rename get* and open*Cursor per the spec on IDBIndex
https://bugs.webkit.org/show_bug.cgi?id=46906

The spec changed so that:
IDBIndex.get -> getKey
IDBIndex.getObject -> get
IDBIndex.openCursor -> openKeyCursor
IDBIndex.openObjectCursor -> openCursor

Existing tests cover since this is just renaming stuff.

  • storage/IDBIndex.cpp: (WebCore::IDBIndex::openCursor): (WebCore::IDBIndex::openKeyCursor): (WebCore::IDBIndex::get): (WebCore::IDBIndex::getKey):
  • storage/IDBIndex.h:
  • storage/IDBIndex.idl:
  • storage/IDBIndexBackendImpl.cpp: (WebCore::IDBIndexBackendImpl::openCursor): (WebCore::IDBIndexBackendImpl::openKeyCursor): (WebCore::IDBIndexBackendImpl::get): (WebCore::IDBIndexBackendImpl::getKey):
  • storage/IDBIndexBackendImpl.h:
  • storage/IDBIndexBackendInterface.h:

2010-10-04 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Nate Chapin.

Rename get* and open*Cursor per the spec on IDBIndex
https://bugs.webkit.org/show_bug.cgi?id=46906

The spec changed so that:
IDBIndex.get -> getKey
IDBIndex.getObject -> get
IDBIndex.openCursor -> openKeyCursor
IDBIndex.openObjectCursor -> openCursor

  • public/WebIDBIndex.h: (WebKit::WebIDBIndex::openCursor): (WebKit::WebIDBIndex::openKeyCursor): (WebKit::WebIDBIndex::get): (WebKit::WebIDBIndex::getKey):
  • src/IDBIndexBackendProxy.cpp: (WebCore::IDBIndexBackendProxy::openCursor): (WebCore::IDBIndexBackendProxy::openKeyCursor): (WebCore::IDBIndexBackendProxy::get): (WebCore::IDBIndexBackendProxy::getKey):
  • src/IDBIndexBackendProxy.h:
  • src/WebIDBIndexImpl.cpp: (WebKit::WebIDBIndexImpl::openObjectCursor): (WebKit::WebIDBIndexImpl::openKeyCursor): (WebKit::WebIDBIndexImpl::getObject): (WebKit::WebIDBIndexImpl::getKey):
  • src/WebIDBIndexImpl.h:
10:14 AM Changeset in webkit [69122] by Simon Hausmann
  • 3 edits in trunk/WebCore

[Qt] Fix breakage in RVCT 2.2 compile
https://bugs.webkit.org/show_bug.cgi?id=47187

Patch by Keith Kyzivat <keith.kyzivat@nokia.com> on 2010-10-05
Reviewed by Simon Hausmann.

Fix bug in RVCT 2.2 compile for Symbian3 in html/canvas/Int32Array.h and
html/canvas/Uin8Array.h
For RVCT2.2, the using clause is unneeded, and can be omitted.

A Test case cannot be made for this since this is a build-related issue.

  • html/canvas/Int32Array.h:
  • html/canvas/Uint8Array.h:
10:10 AM Changeset in webkit [69121] by andreip@google.com
  • 46 edits in trunk

2010-10-04 Andrei Popescu <andreip@google.com>

Reviewed by Jeremy Orlow.

IDBDatabase::createObjectStore/removeObjectStore and IDBObjectStore::createIndex/removeIndex should be synchronous.
https://bugs.webkit.org/show_bug.cgi?id=46883

  • storage/indexeddb/database-basics-expected.txt:
  • storage/indexeddb/database-basics.html:
  • storage/indexeddb/index-basics-expected.txt:
  • storage/indexeddb/index-basics.html:
  • storage/indexeddb/index-cursor-expected.txt:
  • storage/indexeddb/index-cursor.html:
  • storage/indexeddb/objectstore-basics-expected.txt:
  • storage/indexeddb/objectstore-basics.html:
  • storage/indexeddb/objectstore-cursor-expected.txt:
  • storage/indexeddb/objectstore-cursor.html:
  • storage/indexeddb/objectstore-removeobjectstore-expected.txt:
  • storage/indexeddb/objectstore-removeobjectstore.html:
  • storage/indexeddb/open-cursor-expected.txt:
  • storage/indexeddb/open-cursor.html:
  • storage/indexeddb/resources/shared.js: (deleteAllObjectStores):
  • storage/indexeddb/transaction-basics-expected.txt:
  • storage/indexeddb/transaction-basics.html:

2010-10-04 Andrei Popescu <andreip@google.com>

Reviewed by Jeremy Orlow.

IDBDatabase::createObjectStore/removeObjectStore and IDBObjectStore::createIndex/removeIndex should be synchronous.
https://bugs.webkit.org/show_bug.cgi?id=46883

Makes the schema manipulation methods synchronous. Modifies the transaction
logic to support tasks that may have pending events as well as tasks that
don't have such events.

  • storage/IDBDatabase.cpp: (WebCore::IDBDatabase::createObjectStore): (WebCore::IDBDatabase::removeObjectStore):
  • storage/IDBDatabase.h:
  • storage/IDBDatabase.idl:
  • storage/IDBDatabaseBackendImpl.cpp: (WebCore::IDBDatabaseBackendImpl::createObjectStore): (WebCore::IDBDatabaseBackendImpl::createObjectStoreInternal): (WebCore::IDBDatabaseBackendImpl::removeObjectStore): (WebCore::IDBDatabaseBackendImpl::removeObjectStoreInternal):
  • storage/IDBDatabaseBackendImpl.h:
  • storage/IDBDatabaseBackendInterface.h:
  • storage/IDBIndexBackendImpl.cpp: (WebCore::IDBIndexBackendImpl::IDBIndexBackendImpl):
  • storage/IDBIndexBackendImpl.h: (WebCore::IDBIndexBackendImpl::create): (WebCore::IDBIndexBackendImpl::id): (WebCore::IDBIndexBackendImpl::setId):
  • storage/IDBObjectStore.cpp: (WebCore::IDBObjectStore::createIndex): (WebCore::IDBObjectStore::removeIndex):
  • storage/IDBObjectStore.h:
  • storage/IDBObjectStore.idl:
  • storage/IDBObjectStoreBackendImpl.cpp: (WebCore::IDBObjectStoreBackendImpl::IDBObjectStoreBackendImpl): (WebCore::IDBObjectStoreBackendImpl::createIndex): (WebCore::IDBObjectStoreBackendImpl::createIndexInternal): (WebCore::IDBObjectStoreBackendImpl::removeIndex): (WebCore::IDBObjectStoreBackendImpl::removeIndexInternal):
  • storage/IDBObjectStoreBackendImpl.h: (WebCore::IDBObjectStoreBackendImpl::create): (WebCore::IDBObjectStoreBackendImpl::id): (WebCore::IDBObjectStoreBackendImpl::setId): (WebCore::IDBObjectStoreBackendImpl::autoIncrement):
  • storage/IDBObjectStoreBackendInterface.h:
  • storage/IDBTransactionBackendImpl.cpp: (WebCore::IDBTransactionBackendImpl::IDBTransactionBackendImpl): (WebCore::IDBTransactionBackendImpl::objectStore): (WebCore::IDBTransactionBackendImpl::scheduleTask): (WebCore::IDBTransactionBackendImpl::abort): (WebCore::IDBTransactionBackendImpl::didCompleteTaskEvents): (WebCore::IDBTransactionBackendImpl::run): (WebCore::IDBTransactionBackendImpl::taskTimerFired): (WebCore::IDBTransactionBackendImpl::taskEventTimerFired):
  • storage/IDBTransactionBackendImpl.h:

2010-10-04 Andrei Popescu <andreip@google.com>

Reviewed by Jeremy Orlow.

IDBDatabase::createObjectStore/removeObjectStore and IDBObjectStore::createIndex/removeIndex should be synchronous.
https://bugs.webkit.org/show_bug.cgi?id=46883

  • public/WebIDBDatabase.h: (WebKit::WebIDBDatabase::createObjectStore): (WebKit::WebIDBDatabase::removeObjectStore):
  • public/WebIDBObjectStore.h: (WebKit::WebIDBObjectStore::createIndex): (WebKit::WebIDBObjectStore::removeIndex):
  • src/IDBDatabaseProxy.cpp: (WebCore::IDBDatabaseProxy::createObjectStore): (WebCore::IDBDatabaseProxy::removeObjectStore):
  • src/IDBDatabaseProxy.h:
  • src/IDBObjectStoreProxy.cpp: (WebCore::IDBObjectStoreProxy::createIndex): (WebCore::IDBObjectStoreProxy::removeIndex):
  • src/IDBObjectStoreProxy.h:
  • src/WebIDBDatabaseImpl.cpp: (WebKit::WebIDBDatabaseImpl::createObjectStore): (WebKit::WebIDBDatabaseImpl::removeObjectStore):
  • src/WebIDBDatabaseImpl.h:
  • src/WebIDBObjectStoreImpl.cpp: (WebKit::WebIDBObjectStoreImpl::createIndex): (WebKit::WebIDBObjectStoreImpl::removeIndex):
  • src/WebIDBObjectStoreImpl.h:
10:06 AM Changeset in webkit [69120] by Chris Fleizach
  • 3 edits
    2 adds in trunk

WAI-ARIA 'marquee' role live region uses aria-live="polite", should use aria-live="off"
https://bugs.webkit.org/show_bug.cgi?id=47185

Reviewed by Darin Adler.

WebCore:

Test: platform/mac/accessibility/aria-liveregion-marquee-default.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::ariaLiveRegionStatus):

LayoutTests:

  • platform/mac/accessibility/aria-liveregion-marquee-default-expected.txt: Added.
  • platform/mac/accessibility/aria-liveregion-marquee-default.html: Added.
10:03 AM Changeset in webkit [69119] by Martin Robinson
  • 3 edits in trunk/WebCore

2010-10-05 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Interior scrollbars do not draw their background properly
https://bugs.webkit.org/show_bug.cgi?id=47096

Correct the method that the GTK+ theme drawing code uses to
draw scrolled window backgrounds. Now it uses gtk_paint_shadow,
the same as the actual code from GTK+.

No new tests as this is very hard to write tests for. The bug only
manifests on some GTK+ themes and we have no test harness mechanism
for testing rendering with non-default GTK+ themes.

  • platform/gtk/ScrollbarThemeGtk.cpp: (WebCore::ScrollbarThemeGtk::paintScrollbarBackground): No longer initialize the widget state, as it's unused by the callee. (WebCore::ScrollbarThemeGtk::paint): Remove an inaccurate comment.
  • platform/gtk/gtk2drawing.c: (moz_gtk_scrolled_window_paint): Paint scrolled window backgrounds with gtk_paint_shadow instead of gtk_paint_box.
10:01 AM Changeset in webkit [69118] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-10-05 Kwang Yul Seo <skyul@company100.net>

Reviewed by Kent Tamura.

[BREWMP] Use PlatformRefPtr instead of OwnPtr in FileSystem
https://bugs.webkit.org/show_bug.cgi?id=47025

PlatformRefPtr is a better choice here because all Brew MP instances are
reference counted.

  • platform/brew/FileSystemBrew.cpp: (WebCore::getFileSize): (WebCore::fileExists): (WebCore::deleteFile): (WebCore::deleteEmptyDirectory): (WebCore::canonicalPath): (WebCore::makeAllDirectories): (WebCore::openTemporaryFile):
9:58 AM Changeset in webkit [69117] by Martin Robinson
  • 3 edits
    6 adds in trunk

2010-10-05 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] Complex text rendering does not render custom fonts
https://bugs.webkit.org/show_bug.cgi?id=41091

Added a layout test that verifies that custom fonts are rendered with
the correct font when hitting the complex text code path.

  • platform/gtk/fonts/font-face-with-complex-text-expected.checksum: Added.
  • platform/gtk/fonts/font-face-with-complex-text-expected.png: Added.
  • platform/gtk/fonts/font-face-with-complex-text-expected.txt: Added.
  • platform/gtk/fonts/font-face-with-complex-text.html: Added.
  • platform/gtk/fonts/resources/Ahem.ttf: Copied from LayoutTests/fast/css/resources/Ahem.ttf.

2010-10-05 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] Complex text rendering does not render custom fonts
https://bugs.webkit.org/show_bug.cgi?id=41091

For fonts that do not have a FontConfig pattern (including custom
fonts), fall back to the simple text rendering path. This is a work-
-around for not supporting Pango rendering with non-FontConfig fonts.

Test: platform/gtk/fonts/font-face-with-complex-text.html

  • platform/graphics/gtk/FontGtk.cpp: (WebCore::Font::drawComplexText): Fall back to the simple path for custom fonts. (WebCore::Font::floatWidthForComplexText): Ditto. (WebCore::Font::offsetForPositionForComplexText): Ditto. (WebCore::Font::selectionRectForComplexText): Ditto.
9:47 AM Changeset in webkit [69116] by weinig@apple.com
  • 12 edits
    4 adds
    1 delete in trunk

Add MIMEType accessor to WKFrame
<rdar://problem/8347683>
https://bugs.webkit.org/show_bug.cgi?id=47138

Reviewed by Mark Rowe.

WebKit2:

Tests: WebKit2/FrameMIMETypePNG

WebKit2/FrameMIMETypeHTML

  • UIProcess/API/C/WKFrame.cpp:

(WKFrameCopyMIMEType):

  • UIProcess/API/C/WKFrame.h:
  • UIProcess/WebFrameProxy.h:

(WebKit::WebFrameProxy::setMIMEType):
(WebKit::WebFrameProxy::mimeType):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didReceiveMessage):
(WebKit::WebPageProxy::didCommitLoadForFrame):

  • UIProcess/WebPageProxy.h:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDidCommitLoad):

WebKitTools:

  • TestWebKitAPI/PlatformUtilities.h:

(TestWebKitAPI::Util::toSTD):

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp: Added.

(TestWebKitAPI::didStartProvisionalLoadForFrame):
(TestWebKitAPI::didCommitLoadForFrame):
(TestWebKitAPI::didFinishLoadForFrame):
(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp: Added.

(TestWebKitAPI::didStartProvisionalLoadForFrame):
(TestWebKitAPI::didCommitLoadForFrame):
(TestWebKitAPI::didFinishLoadForFrame):
(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit2/basic-1.html: Removed.
  • TestWebKitAPI/Tests/WebKit2/icon.png: Added.
  • TestWebKitAPI/Tests/WebKit2/simple.html: Added.
  • TestWebKitAPI/mac/PlatformUtilitiesMac.mm:

(TestWebKitAPI::Util::createURLForResource):

9:44 AM Changeset in webkit [69115] by commit-queue@webkit.org
  • 3 edits in trunk/WebKitTools

2010-10-05 Gabor Rapcsanyi <rgabor@inf.u-szeged.hu>

Reviewed by Ojan Vafai.

[NRWT] Rename current_dir to current_group because it's not a directory
https://bugs.webkit.org/show_bug.cgi?id=47169

  • Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
9:42 AM Changeset in webkit [69114] by kseo@webkit.org
  • 2 edits in trunk/WebCore

[BREWMP] Use PlatformRefPtr in getDisplayInfo
https://bugs.webkit.org/show_bug.cgi?id=47023

Reviewed by Kent Tamura.

Use PlatformRefPtr to release IBitmap* automatically.

  • platform/brew/ScreenBrew.cpp:

(WebCore::getDisplayInfo):

9:00 AM Changeset in webkit [69113] by commit-queue@webkit.org
  • 4 edits in trunk/WebKit/efl

2010-10-05 Ryuan Choi <ryuan.choi@samsung.com>

Reviewed by Antonio Gomes.

[EFL] Remove strdup in ewk_setting.cpp using eina_stringshare
https://bugs.webkit.org/show_bug.cgi?id=46613

Add variables shared by eina_stringshare and remove strdup.

  • ewk/ewk_main.cpp: (_ewk_init_body):
  • ewk/ewk_settings.cpp: (ewk_settings_web_database_path_set): (ewk_settings_web_database_path_get): (ewk_settings_icon_database_path_set): (ewk_settings_icon_database_path_get):
  • ewk/ewk_settings.h:
8:53 AM Changeset in webkit [69112] by commit-queue@webkit.org
  • 3 edits in trunk/WebCore

2010-10-05 Kristian Monsen <kristianm@google.com>

Reviewed by Steve Block.

Including JavaScriptCore/config.h from WebCore/config.h
instead of from WebCorePrefix.h.
https://bugs.webkit.org/show_bug.cgi?id=47179

No new tests, just changing where files are included.

  • WebCorePrefix.h:
  • config.h:
8:52 AM Changeset in webkit [69111] by jpetsovits@rim.com
  • 4 edits in trunk

2010-10-05 Jakob Petsovits <jpetsovits@rim.com>

Reviewed by Andreas Kling.

[Qt] Make build work with QT_NO_CURSOR
https://bugs.webkit.org/show_bug.cgi?id=46097

Add a missing semicolon.

  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::setCursor):

2010-10-05 Jakob Petsovits <jpetsovits@rim.com>

Reviewed by Andreas Kling.

[Qt] Make build work with QT_NO_CURSOR
https://bugs.webkit.org/show_bug.cgi?id=46097

Add a missing include.

  • platform/qt/QWebPageClient.h:
8:44 AM Changeset in webkit [69110] by jpetsovits@rim.com
  • 2 edits in trunk/WebCore

2010-10-05 Jakob Petsovits <jpetsovits@rim.com>

Reviewed by Andreas Kling.

[Qt] Make build work with QT_NO_CURSOR
https://bugs.webkit.org/show_bug.cgi?id=46097

createCustomCursor() is a static function and not used
in that file if QT_NO_CURSOR is defined, so rather than
making it return 0, it should not exist altogether.

  • platform/qt/CursorQt.cpp: (WebCore::createCustomCursor):
8:32 AM Changeset in webkit [69109] by commit-queue@webkit.org
  • 4 edits in trunk/WebKit/mac

2010-10-05 Philippe Normand <pnormand@igalia.com>

Reviewed by Martin Robinson.

check for ENABLE(GLIB_SUPPORT) in WebView
https://bugs.webkit.org/show_bug.cgi?id=46788

Use ENABLE(GLIB_SUPPORT) in WebView to guard the glib runloop observer.

  • WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]): (-[WebView _close]):
  • WebView/WebViewData.h:
  • WebView/WebViewInternal.h:
8:02 AM Changeset in webkit [69108] by commit-queue@webkit.org
  • 3 edits in trunk/WebKit2

2010-10-05 Kimmo Kinnunen <kimmo.t.kinnunen@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Implement API call for setting custom user agent
(QWKPage::setCustomUserAgent)

[Qt] Ability to set custom userAgent for WebKit2/WebKit
https://bugs.webkit.org/show_bug.cgi?id=44265

  • UIProcess/API/qt/qwkpage.cpp: (QWKPage::setCustomUserAgent): Added.
  • UIProcess/API/qt/qwkpage.h: Add setCustomUserAgent.
7:30 AM Changeset in webkit [69107] by commit-queue@webkit.org
  • 5 edits in trunk/WebKit2

2010-10-05 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r69103.
http://trac.webkit.org/changeset/69103
https://bugs.webkit.org/show_bug.cgi?id=47177

Breaking Windows and Mac build. (Requested by lca on #webkit).

  • UIProcess/API/C/WKNativeEvent.h:
  • UIProcess/API/qt/qwkpage.cpp:
  • UIProcess/API/qt/qwkpage.h:
  • WebKit2.pri:
6:47 AM Changeset in webkit [69106] by Adam Roben
  • 2 edits in trunk/WebCore

Windows linker warning fix

  • WebCore.vcproj/WebCore.vcproj: Exclude JSDOMTokenList.cpp from the

build, since it is already being compiled via DerivedSources.cpp. Also
let VS reorder some files.

6:46 AM QtWebKitDocContrib edited by Henry Haverinen
(diff)
6:44 AM QtWebKitDocContrib edited by Henry Haverinen
(diff)
6:40 AM QtWebKitDocContrib edited by Henry Haverinen
(diff)
6:37 AM QtWebKitDocContrib edited by Henry Haverinen
(diff)
6:28 AM Changeset in webkit [69105] by commit-queue@webkit.org
  • 5 edits in trunk/WebCore

2010-10-05 Kimmo Kinnunen <kimmo.t.kinnunen@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Web process crash when pressing modifiers in input field
https://bugs.webkit.org/show_bug.cgi?id=44935

Fix null pointer dereference by not using
PlatformKeyboardEvent::m_qtEvent. This member is not set when
event comes from WebKit2. Unix: Add ASSERTs to plugin related
code. These will fail if WebKit2 is used with plugins, unless code
is not fixed before. Symbian: Add ASSERT to code which uses
qtEvent(). It will fail when WebKit2 is enabled for Symbian, if
code is not fixed before.

  • platform/PlatformKeyboardEvent.h:
  • platform/qt/PlatformKeyboardEventQt.cpp: (WebCore::isVirtualKeyCodeRepresentingCharacter): Added. (WebCore::PlatformKeyboardEvent::disambiguateKeyDownEvent): Avoid using m_qtEvent. (WebCore::PlatformKeyboardEvent::nativeModifiers): Added. Use ASSERT as a reminder. (WebCore::PlatformKeyboardEvent::nativeScanCode): Added. Use ASSERT as a reminder.
  • plugins/qt/PluginViewQt.cpp: (WebCore::setXKeyEventSpecificFields):
  • plugins/symbian/PluginViewSymbian.cpp: (WebCore::PluginView::handleKeyboardEvent): Add ASSERT as a reminder.
6:27 AM Changeset in webkit [69104] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Unreviewed build fix.

[Symbian] Fix build issue due to gaps in ordinals in the def file

Restore previously removed symbols and mark them absent instead. We must
not remove symbols from this file, because it breaks binary compatibility
(when re-assigning the ordinals of the following symbols) or it causes build
breakage when instead having a gap in the ordinal sequence. Instead removing
a symbol is done by marking it as absent.

  • symbian/eabi/QtWebKitu.def:
6:18 AM Changeset in webkit [69103] by luiz@webkit.org
  • 5 edits in trunk/WebKit2

2010-10-05 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Antti Koivisto.

[Qt] Webkit2 MacOS build fix
https://bugs.webkit.org/show_bug.cgi?id=47167

Qt WebKit2 MacOS build fix.

  • UIProcess/API/C/WKNativeEvent.h:
  • UIProcess/API/qt/qwkpage.cpp:
  • UIProcess/API/qt/qwkpage.h:
  • WebKit2.pri:
4:22 AM Changeset in webkit [69102] by tkent@chromium.org
  • 2 edits
    32 adds in trunk/LayoutTests

2010-10-05 Kent Tamura <tkent@chromium.org>

Unreviewed, test expectation update.

Add baselines for tests added by r69076 and r69077.

  • platform/chromium-linux/svg/dynamic-updates/SVGFEFloodElement-dom-flood-color-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEFloodElement-dom-flood-color-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEFloodElement-dom-flood-opacity-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEFloodElement-dom-flood-opacity-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-color-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-color-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-opacity-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-opacity-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-in-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-in-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-call-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-call-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEGaussianBlurElement-svgdom-in-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEGaussianBlurElement-svgdom-in-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEFloodElement-dom-flood-color-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEFloodElement-dom-flood-color-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEFloodElement-dom-flood-opacity-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEFloodElement-dom-flood-opacity-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-color-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-color-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-opacity-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-opacity-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-in-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-in-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-call-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-call-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEGaussianBlurElement-svgdom-in-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEGaussianBlurElement-svgdom-in-prop-expected.png: Added.
  • platform/chromium/test_expectations.txt:
4:16 AM Changeset in webkit [69101] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-10-05 Kwang Yul Seo <skyul@company100.net>

Reviewed by Csaba Osztrogonác.

Add ENABLE(ACCELERATED_2D_CANVAS) guard to LoopBlinnLocalTriangulator.cpp
https://bugs.webkit.org/show_bug.cgi?id=47115

LoopBlinnLocalTriangulator.cpp depends on LoopBlinnMathUtils.cpp which is guarded by
ENABLE(ACCELERATED_2D_CANVAS).

  • platform/graphics/gpu/LoopBlinnLocalTriangulator.cpp:
3:44 AM Changeset in webkit [69100] by satish@chromium.org
  • 10 edits in trunk

2010-10-05 Satish Sampath <satish@chromium.org>

Reviewed by Kent Tamura.

Added event onwebkitspeechchange to invoke on new speech input results.
https://bugs.webkit.org/show_bug.cgi?id=47127

Updated to use onwebkitspeechchange instead of onchange.

  • fast/speech/input-text-speechbutton.html:
  • fast/speech/speech-button-ignore-generated-events.html:

2010-10-05 Satish Sampath <satish@chromium.org>

Reviewed by Kent Tamura.

Added event onwebkitspeechchange to invoke on new speech input results.
https://bugs.webkit.org/show_bug.cgi?id=47127

  • dom/EventNames.h: Added webkitspeechchange event name.
  • html/HTMLAttributeNames.in: Added onwebkitspeechchange attribute name.
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::parseMappedAttribute): Handle new attribute set. (WebCore::HTMLInputElement::dispatchWebkitSpeechChangeEvent): Invoke the event handler.
  • html/HTMLInputElement.h:
  • html/HTMLInputElement.idl: Added attribute to IDL.
  • rendering/TextControlInnerElements.cpp: (WebCore::InputFieldSpeechButtonElement::setRecognitionResult): Invoke new event handler instead of onChange
2:03 AM Changeset in webkit [69099] by satish@chromium.org
  • 11 edits in trunk

2010-10-05 Satish Sampath <satish@chromium.org>

Reviewed by Jeremy Orlow.

Rename @webkitspeech to @x-webkit-speech to follow HTML5 convention.
https://bugs.webkit.org/show_bug.cgi?id=46873

Updated layout tests to use the new attribute name.

  • fast/speech/input-appearance-numberandspeech.html:
  • fast/speech/input-appearance-searchandspeech.html:
  • fast/speech/input-appearance-speechbutton.html:
  • fast/speech/input-text-speechbutton.html:
  • fast/speech/speech-button-ignore-generated-events.html:

2010-10-05 Satish Sampath <satish@chromium.org>

Reviewed by Jeremy Orlow.

Rename @webkitspeech to @x-webkit-speech to follow HTML5 convention
https://bugs.webkit.org/show_bug.cgi?id=46873

The @webkitspeech attribute is renamed to @x-webkit-speech per the HTML5 spec for extension
attributes. The DOM attribute in IDL was renamed to 'webkitSpeech' as well. But the generated
code for the attribute did not match the generated code for the IDL, so I modified
dom/make_names.pl to generate the appropriate name for such extension attributes.

  • bindings/generic/RuntimeEnabledFeatures.h: Rename flag accessor to match IDL attribute name. (WebCore::RuntimeEnabledFeatures::webkitSpeechEnabled):
  • dom/make_names.pl: Additions to generate names for x-webkit-xxxx attributes that match the generated code from IDL and remember the original names including the x- prefix when writing out the cpp files.
  • html/HTMLAttributeNames.in: Rename @webkitspeech to @x-webkit-speech
  • html/HTMLInputElement.idl: Rename @webkitspeech to @webkitSpeech
1:59 AM Changeset in webkit [69098] by caseq@chromium.org
  • 4 edits in trunk

2010-10-04 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [Chromium][Extension API] provide tab id of inspected tab in extension API
https://bugs.webkit.org/show_bug.cgi?id=47080

  • inspector/front-end/ExtensionServer.js: Added support for platform-specific extensions API. (WebInspector.ExtensionServer.prototype._buildExtensionAPIInjectedScript):

2010-10-04 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [Chromium][Extension API] provide tab id of inspected tab in extension API
https://bugs.webkit.org/show_bug.cgi?id=47080

  • src/js/DevTools.js: Added a way for extension to get tabId of inspected window. (WebInspector.platformExtensionAPI): (WebInspector.buildPlatformExtensionAPI): (WebInspector.setInspectedTabId):
1:42 AM Changeset in webkit [69097] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-10-05 Sanjeev Radhakrishnan <sanjeevr@chromium.org>

Reviewed by Darin Fisher.

Fixed implementation of pluginWidgetFromDocument to search for the "embed" element rather than just use the first child.
https://bugs.webkit.org/show_bug.cgi?id=47129

  • html/PluginDocument.cpp: (WebCore::PluginDocumentParser::pluginWidgetFromDocument):
1:28 AM Changeset in webkit [69096] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

2010-10-05 Oliver Hunt <oliver@apple.com>

Reviewed by Darin Adler.

REGRESSION(r68338): JavaScript error on PowerPC only (crashes on Interpreter built for x86_64)
https://bugs.webkit.org/show_bug.cgi?id=46690

Use the correct register value when initialising the arguments
object in the interpreter. This is covered by existing tests.

  • interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute):
1:27 AM Changeset in webkit [69095] by crogers@google.com
  • 1 edit
    2 adds in trunk/WebCore

2010-10-05 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

Add BiquadDSPKernel files
https://bugs.webkit.org/show_bug.cgi?id=46528

No new tests since audio API is not yet implemented.

  • webaudio/BiquadDSPKernel.cpp: Added. (WebCore::BiquadDSPKernel::process):
  • webaudio/BiquadDSPKernel.h: Added. (WebCore::BiquadDSPKernel::BiquadDSPKernel): (WebCore::BiquadDSPKernel::reset): (WebCore::BiquadDSPKernel::biquadProcessor):
1:16 AM Changeset in webkit [69094] by crogers@google.com
  • 4 edits in trunk/WebCore

2010-10-05 Chris Rogers <crogers@google.com>

Reviewed by James Robinson.

Fix AudioContext to use new HRTFDatabaseLoader API
https://bugs.webkit.org/show_bug.cgi?id=46858

No new tests since audio API is not yet implemented.

  • webaudio/AudioContext.cpp: (WebCore::AudioContext::AudioContext): (WebCore::AudioContext::isRunnable):
  • webaudio/AudioContext.h:
  • webaudio/AudioContext.idl:
1:13 AM Changeset in webkit [69093] by crogers@google.com
  • 1 edit
    3 adds in trunk/WebCore

2010-10-05 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

Add AudioPannerNode files
https://bugs.webkit.org/show_bug.cgi?id=46505

No new tests since audio API is not yet implemented.

  • webaudio/AudioPannerNode.cpp: Added. (WebCore::fixNANs): (WebCore::AudioPannerNode::AudioPannerNode): (WebCore::AudioPannerNode::~AudioPannerNode): (WebCore::AudioPannerNode::pullInputs): (WebCore::AudioPannerNode::process): (WebCore::AudioPannerNode::reset): (WebCore::AudioPannerNode::initialize): (WebCore::AudioPannerNode::uninitialize): (WebCore::AudioPannerNode::listener): (WebCore::AudioPannerNode::setPanningModel): (WebCore::AudioPannerNode::getAzimuthElevation): (WebCore::AudioPannerNode::dopplerRate): (WebCore::AudioPannerNode::distanceConeGain): (WebCore::AudioPannerNode::notifyAudioSourcesConnectedToNode):
  • webaudio/AudioPannerNode.h: Added. (WebCore::AudioPannerNode::create): (WebCore::AudioPannerNode::panningModel): (WebCore::AudioPannerNode::position): (WebCore::AudioPannerNode::setPosition): (WebCore::AudioPannerNode::orientation): (WebCore::AudioPannerNode::setOrientation): (WebCore::AudioPannerNode::velocity): (WebCore::AudioPannerNode::setVelocity): (WebCore::AudioPannerNode::distanceModel): (WebCore::AudioPannerNode::setDistanceModel): (WebCore::AudioPannerNode::refDistance): (WebCore::AudioPannerNode::setRefDistance): (WebCore::AudioPannerNode::maxDistance): (WebCore::AudioPannerNode::setMaxDistance): (WebCore::AudioPannerNode::rolloffFactor): (WebCore::AudioPannerNode::setRolloffFactor): (WebCore::AudioPannerNode::coneInnerAngle): (WebCore::AudioPannerNode::setConeInnerAngle): (WebCore::AudioPannerNode::coneOuterAngle): (WebCore::AudioPannerNode::setConeOuterAngle): (WebCore::AudioPannerNode::coneOuterGain): (WebCore::AudioPannerNode::setConeOuterGain): (WebCore::AudioPannerNode::distanceGain): (WebCore::AudioPannerNode::coneGain):
  • webaudio/AudioPannerNode.idl: Added.
1:08 AM Changeset in webkit [69092] by alex
  • 3 edits in trunk/WebCore

2010-10-04 Alejandro G. Castro <alex@igalia.com>

Reviewed by Martin Robinson.

[Cairo] Port drawTiledShadow to the new ContextShadow
https://bugs.webkit.org/show_bug.cgi?id=45902

Ported the drawTiledShadow function to the ContextShadow, it
renders shadows for rects faster than the simple blurring using
tiling of a smaller rect. We will remove the old function in a
next patch when starting to use ContextShadows for cairo
rendering.

  • platform/graphics/ContextShadow.h:
  • platform/graphics/cairo/ContextShadowCairo.cpp: (WebCore::ContextShadow::drawRectShadowWithoutTiling): (WebCore::ContextShadow::drawRectShadow):
12:59 AM Changeset in webkit [69091] by crogers@google.com
  • 1 edit
    2 adds in trunk/WebCore

2010-10-05 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

Add BiquadProcessor files
https://bugs.webkit.org/show_bug.cgi?id=46527

No new tests since audio API is not yet implemented.

  • webaudio/BiquadProcessor.cpp: Added. (WebCore::BiquadProcessor::BiquadProcessor): (WebCore::BiquadProcessor::~BiquadProcessor): (WebCore::BiquadProcessor::createKernel): (WebCore::BiquadProcessor::process):
  • webaudio/BiquadProcessor.h: Added. (WebCore::BiquadProcessor::filterCoefficientsDirty): (WebCore::BiquadProcessor::parameter1): (WebCore::BiquadProcessor::parameter2): (WebCore::BiquadProcessor::parameter3): (WebCore::BiquadProcessor::type):
12:49 AM Changeset in webkit [69090] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

2010-10-05 Kent Tamura <tkent@chromium.org>

Unreviewed, test expectation update.

  • platform/chromium/test_expectations.txt: Add expectations for tests added by r69076 and r69077.
12:45 AM Changeset in webkit [69089] by crogers@google.com
  • 1 edit
    2 adds in trunk/WebCore

2010-10-05 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

Add EqualPowerPanner files
https://bugs.webkit.org/show_bug.cgi?id=45077

No new tests since audio API is not yet implemented.

  • platform/audio/EqualPowerPanner.cpp: Added. (WebCore::EqualPowerPanner::EqualPowerPanner): (WebCore::EqualPowerPanner::pan):
  • platform/audio/EqualPowerPanner.h: Added. (WebCore::EqualPowerPanner::reset):
12:33 AM Changeset in webkit [69088] by crogers@google.com
  • 1 edit
    3 adds in trunk/WebCore

2010-10-05 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

Add HighPass2FilterNode files
https://bugs.webkit.org/show_bug.cgi?id=46533

No new tests since audio API is not yet implemented.

  • webaudio/HighPass2FilterNode.cpp: Added. (WebCore::HighPass2FilterNode::HighPass2FilterNode):
  • webaudio/HighPass2FilterNode.h: Added. (WebCore::HighPass2FilterNode::create): (WebCore::HighPass2FilterNode::cutoff): (WebCore::HighPass2FilterNode::resonance): (WebCore::HighPass2FilterNode::biquadProcessor):
  • webaudio/HighPass2FilterNode.idl: Added.
12:23 AM Changeset in webkit [69087] by crogers@google.com
  • 1 edit
    3 adds in trunk/WebCore

2010-10-05 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

Add LowPass2FilterNode files
https://bugs.webkit.org/show_bug.cgi?id=46532

No new tests since audio API is not yet implemented.

  • webaudio/LowPass2FilterNode.cpp: Added. (WebCore::LowPass2FilterNode::LowPass2FilterNode):
  • webaudio/LowPass2FilterNode.h: Added. (WebCore::LowPass2FilterNode::create): (WebCore::LowPass2FilterNode::cutoff): (WebCore::LowPass2FilterNode::resonance): (WebCore::LowPass2FilterNode::biquadProcessor):
  • webaudio/LowPass2FilterNode.idl: Added.

Oct 4, 2010:

11:53 PM Changeset in webkit [69086] by alex
  • 2 edits in trunk/WebCore

2010-10-04 Alejandro G. Castro <alex@igalia.com>

Reviewed by Kent Tamura.

Fixed compilation problem added in commit 69082. The interface of
the function has two parameters with the same name.

  • rendering/RenderBlock.h:
11:39 PM Changeset in webkit [69085] by dpranke@chromium.org
  • 2 edits in trunk/WebKitTools

2010-10-04 Dirk Pranke <dpranke@chromium.org>

Unreviewed, build fix.

r69065 broke test-webkitpy by trying to create a '/tmp-X' directory,
which can't always be done. This test uses tempfile.mkdtemp(), which
should be safe.

  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
11:36 PM Changeset in webkit [69084] by tonyg@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-10-04 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Darin Fisher.

[chromium] Properly clear WebKit cache when chromium cache is cleared
https://bugs.webkit.org/show_bug.cgi?id=47119

Contributed by Ricardo Vargas.

See: http://code.google.com/p/chromium/issues/detail?id=54336

  • src/WebCache.cpp: (WebKit::WebCache::clear):
11:22 PM Changeset in webkit [69083] by crogers@google.com
  • 1 edit
    2 adds in trunk/WebCore

2010-10-04 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

Add AudioUtilities files
https://bugs.webkit.org/show_bug.cgi?id=47011

No new tests since audio API is not yet implemented.

  • platform/audio/AudioUtilities.cpp: Added. (WebCore::AudioUtilities::decibelsToLinear): (WebCore::AudioUtilities::linearToDecibels): (WebCore::AudioUtilities::discreteTimeConstantForSampleRate):
  • platform/audio/AudioUtilities.h: Added.
11:13 PM Changeset in webkit [69082] by hyatt@apple.com
  • 4 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=47112

Reviewed by Dan Bernstein.

Convert addOverhangingFloats and addIntrudingFloats to be block-flow-aware.

Also clean up how floats are placed to use a bit instead of the magic -1 value on top().

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::layoutBlockChild):
(WebCore::RenderBlock::insertFloatingObject):
(WebCore::RenderBlock::removeFloatingObject):
(WebCore::RenderBlock::removeFloatingObjectsBelow):
(WebCore::RenderBlock::positionNewFloats):
(WebCore::RenderBlock::markLinesDirtyInBlockRange):
(WebCore::RenderBlock::clearFloats):
(WebCore::RenderBlock::addOverhangingFloats):
(WebCore::RenderBlock::addIntrudingFloats):

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::FloatingObject::FloatingObject):
(WebCore::RenderBlock::FloatingObject::isPlaced):
(WebCore::RenderBlock::FloatingObject::setIsPlaced):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::determineStartPosition):

11:10 PM Changeset in webkit [69081] by thakis@chromium.org
  • 6 edits in trunk

2010-10-04 Nico Weber <thakis@chromium.org>

Reviewed by Kenneth Russell.

Fix broken C++ in PODInterval and PODIntervalTree
https://bugs.webkit.org/show_bug.cgi?id=47063

See http://clang.llvm.org/compatibility.html#dep_lookup . Since
valueToString needs to work with non-class types, it needs to be
declared before it's used. And since it needs to handle many types, it
needs to be a template function, for which clients will need to
provide specializations for the types they care about. Partial template
specialization is only supported for structs, so wrap the function in
a struct, too.

  • platform/graphics/gpu/PODInterval.h: (WebCore::PODInterval::toString):
  • platform/graphics/gpu/PODIntervalTree.h: (WebCore::PODIntervalTree::checkInvariantsFromNode):
  • platform/graphics/gpu/PODRedBlackTree.h: (WebCore::PODRedBlackTree::dumpFromNode):

2010-10-04 Nico Weber <thakis@chromium.org>

Reviewed by Kenneth Russell.

Fix broken C++ in PODInterval and PODIntervalTree
https://bugs.webkit.org/show_bug.cgi?id=47063

Change functions to be template specializations, like it's now required
by PODIntervalTree and friends.

  • tests/PODIntervalTreeTest.cpp:
10:56 PM Changeset in webkit [69080] by commit-queue@webkit.org
  • 3 edits in trunk/JavaScriptCore

2010-10-04 David Goodwin <david_goodwin@apple.com>

Reviewed by Oliver Hunt.

ARMv7 JIT should take advantage of 2-byte branches to reduce code size
https://bugs.webkit.org/show_bug.cgi?id=47007

  • assembler/ARMv7Assembler.cpp:
  • assembler/ARMv7Assembler.h: (JSC::ARMv7Assembler::computeJumpType): (JSC::ARMv7Assembler::link): (JSC::ARMv7Assembler::canBeJumpT2): (JSC::ARMv7Assembler::canBeJumpT4): (JSC::ARMv7Assembler::linkBX): (JSC::ARMv7Assembler::linkJumpT4): (JSC::ARMv7Assembler::linkJumpT2): (JSC::ARMv7Assembler::linkJumpAbsolute):
10:56 PM Changeset in webkit [69079] by dpranke@chromium.org
  • 2 edits in trunk/WebKitTools

2010-10-04 Dirk Pranke <dpranke@chromium.org>

Unreviewed, build fix.

Add missing "from future import with_statement" that was
breaking test-webkitpy on the Leopard bots (broke in r69040).

  • Scripts/webkitpy/layout_tests/port/google_chrome.py:
10:43 PM Changeset in webkit [69078] by yael.aharon@nokia.com
  • 3 edits
    4 adds in trunk

2010-10-04 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Antonio Gomes.

Spatial Navigation: Add support for <input type="radio">
https://bugs.webkit.org/show_bug.cgi?id=46993

  • fast/events/spatial-navigation/snav-radio-expected.txt: Added.
  • fast/events/spatial-navigation/snav-radio-group-expected.txt: Added.
  • fast/events/spatial-navigation/snav-radio-group.html: Added.
  • fast/events/spatial-navigation/snav-radio.html: Added.

2010-10-04 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Antonio Gomes.

Spatial Navigation: Add support for <input type="radio">
https://bugs.webkit.org/show_bug.cgi?id=46993

When using Spatial Navigation, every radio button should be focusable and
users should be able to navigate from one button to the next without moving the selection.

Tests: fast/events/spatial-navigation/snav-radio-group.html

fast/events/spatial-navigation/snav-radio.html

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::isKeyboardFocusable): Every radio button should be keyboard focusable, if using Spatial Navigation. (WebCore::HTMLInputElement::defaultEventHandler): Disable the algorithm for selecting the next radio button within a group, if using Spatial Navigation.
10:32 PM Changeset in webkit [69077] by commit-queue@webkit.org
  • 4 edits
    20 adds in trunk

2010-10-04 Renata Hodovan <reni@inf.u-szeged.hu>

Reviewed by Andreas Kling.

SVGFEGaussianBlurElement doesn't support dynamic invalidation, when attributes change.
https://bugs.webkit.org/show_bug.cgi?id=47074
Adding layout tests for feGaussianBlur dynamic changes.

  • platform/mac/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-in-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-in-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-call-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-call-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEGaussianBlurElement-svgdom-in-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEGaussianBlurElement-svgdom-in-prop-expected.png: Added.
  • svg/dynamic-updates/SVGFEGaussianBlurElement-dom-in-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGFEGaussianBlurElement-dom-in-attr.html: Added.
  • svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-attr.html: Added.
  • svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-call-expected.txt: Added.
  • svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-call.html: Added.
  • svg/dynamic-updates/SVGFEGaussianBlurElement-svgdom-in-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFEGaussianBlurElement-svgdom-in-prop.html: Added.
  • svg/dynamic-updates/script-tests/SVGFEGaussianBlurElement-dom-in-attr.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFEGaussianBlurElement-dom-stdDeviation-attr.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFEGaussianBlurElement-svgdom-in-prop.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFEGaussianBlurElement-svgdom-stdDeviation-call.js: Added. (executeTest):

2010-10-04 Renata Hodovan <reni@inf.u-szeged.hu>

Reviewed by Andreas Kling.

SVGFEGaussianBlurElement doesn't support dynamic invalidation, when attributes change.
https://bugs.webkit.org/show_bug.cgi?id=47074
The patch also implements the simple setStdDeviation method.

Tests: svg/dynamic-updates/SVGFEGaussianBlurElement-dom-in-attr.html

svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-attr.html
svg/dynamic-updates/SVGFEGaussianBlurElement-dom-stdDeviation-call.html
svg/dynamic-updates/SVGFEGaussianBlurElement-svgdom-in-prop.html

  • svg/SVGFEGaussianBlurElement.cpp: (WebCore::SVGFEGaussianBlurElement::setStdDeviation): (WebCore::SVGFEGaussianBlurElement::svgAttributeChanged):
  • svg/SVGFEGaussianBlurElement.h:
10:31 PM Changeset in webkit [69076] by commit-queue@webkit.org
  • 1 edit
    20 adds in trunk/LayoutTests

2010-10-04 Renata Hodovan <reni@inf.u-szeged.hu>

Reviewed by Dirk Schulze.

SVGFEFloodElement doesn't support dynamic invalidation, when attributes change.
https://bugs.webkit.org/show_bug.cgi?id=47077

Adding layout tests for feFlood dynamic changes. Since the attributes are CSS attributes,
their changes are captured by the CSS support sub-system, and invalidated when needed.
Thus, no need to add a new handler for SVGFEFloodElement.

  • platform/mac/svg/dynamic-updates/SVGFEFloodElement-dom-flood-color-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEFloodElement-dom-flood-color-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEFloodElement-dom-flood-opacity-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEFloodElement-dom-flood-opacity-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-color-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-color-prop-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-opacity-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-opacity-prop-expected.png: Added.
  • svg/dynamic-updates/SVGFEFloodElement-dom-flood-color-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGFEFloodElement-dom-flood-color-attr.html: Added.
  • svg/dynamic-updates/SVGFEFloodElement-dom-flood-opacity-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGFEFloodElement-dom-flood-opacity-attr.html: Added.
  • svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-color-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-color-prop.html: Added.
  • svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-opacity-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-opacity-prop.html: Added.
  • svg/dynamic-updates/script-tests/SVGFEFloodElement-dom-flood-color-attr.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFEFloodElement-dom-flood-opacity-attr.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFEFloodElement-svgdom-flood-color-prop.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFEFloodElement-svgdom-flood-opacity-prop.js: Added. (executeTest):
10:26 PM Changeset in webkit [69075] by tkent@chromium.org
  • 3 edits in trunk/WebKitTools

2010-10-04 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r69066.
http://trac.webkit.org/changeset/69066
https://bugs.webkit.org/show_bug.cgi?id=47163

Made NRWT reliability worse. (Requested by tkent on #webkit).

  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
10:18 PM Changeset in webkit [69074] by commit-queue@webkit.org
  • 2 edits in trunk/WebKitTools

2010-10-04 Gabor Rapcsanyi <rgabor@inf.u-szeged.hu>

Reviewed by Tony Chang.

[NRWT] Reverse the http tests to alphabetical order.
https://bugs.webkit.org/show_bug.cgi?id=47075

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
10:14 PM Changeset in webkit [69073] by robert@webkit.org
  • 4 edits in trunk

2010-10-04 Robert Hogan <robert@webkit.org>

Reviewed by Andreas Kling.

[Qt] Fix timeout on http/tests/navigation/post-goback2.html and postredirect-goback2.html

We need to queue back and forward navigations in the DRT from the
LayoutTestController so that maybeDump() knows about them.

Unskip:

http/tests/navigation/post-goback2.html

  • platform/qt/Skipped:

2010-10-04 Robert Hogan <robert@webkit.org>

Reviewed by Andreas Kling.

[Qt] Fix timeout on http/tests/navigation/post-goback2.html and postredirect-goback2.html

We need to queue back and forward navigations in the DRT from the
LayoutTestController so that maybeDump() knows about them.

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::queueBackNavigation): (LayoutTestController::queueForwardNavigation):
10:06 PM Changeset in webkit [69072] by commit-queue@webkit.org
  • 10 edits in trunk

2010-10-04 Patrick Gansterer <paroga@paroga.com>

Reviewed by Darin Adler.

Add Base64DecodePolicy option at base64Decode()
https://bugs.webkit.org/show_bug.cgi?id=41510

  • fast/dom/Window/atob-btoa-expected.txt:
  • fast/dom/Window/atob-btoa.html:
  • platform/mac/fast/loader/user-stylesheet-fast-path-expected.txt:
  • platform/mac/fast/loader/user-stylesheet-fast-path.html: Added additional data urls tests.

2010-10-04 Patrick Gansterer <paroga@paroga.com>

Reviewed by Darin Adler.

Add Base64DecodePolicy option at base64Decode()
https://bugs.webkit.org/show_bug.cgi?id=41510

Add an option for ignoring characters in base64 data.
This is necessary for decoding data urls.

Also add an overload to decode WebCore::String directly.

  • page/DOMWindow.cpp: (WebCore::DOMWindow::atob):
  • page/Page.cpp: (WebCore::Page::userStyleSheetLocationChanged):
  • platform/text/Base64.cpp: (WebCore::base64Encode): (WebCore::base64Decode): (WebCore::base64DecodeInternal):
  • platform/text/Base64.h: (WebCore::):
9:58 PM Changeset in webkit [69071] by commit-queue@webkit.org
  • 3 edits in trunk/WebCore

2010-10-04 Ryuan Choi <bunhere@gmail.com>

Unreviewed build fix.

[WML] Build fix for r68854
https://bugs.webkit.org/show_bug.cgi?id=47043

Include HTMLParserIdioms.h.

No features added, so no new tests.

  • wml/WMLAElement.cpp:
  • wml/WMLImageLoader.cpp:
9:53 PM Changeset in webkit [69070] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-10-04 Ryuan Choi <ryuan.choi@samsung.com>

Unreviewed build fix.

[CMAKE] Build fix for r68901
https://bugs.webkit.org/show_bug.cgi?id=47042

Move plugins/PluginPackage.cpp

No features added, so no new tests.

  • CMakeLists.txt:
9:41 PM Changeset in webkit [69069] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-10-04 Eric Uhrhane <ericu@chromium.org>

Reviewed by David Levin.

Hook FileEntry::createWriter to DOMFileSystem::createWriter
https://bugs.webkit.org/show_bug.cgi?id=46908

No new tests--still waiting for the first complete implementation.

  • fileapi/FileEntry.cpp: (WebCore::FileEntry::createWriter):
9:28 PM Changeset in webkit [69068] by yael.aharon@nokia.com
  • 3 edits
    4 adds in trunk

2010-10-04 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Antonio Gomes.

Spatial Navigation: select element does not release focus with Spatial Navigation
https://bugs.webkit.org/show_bug.cgi?id=46896

  • fast/events/spatial-navigation/snav-multiple-select-expected.txt: Added.
  • fast/events/spatial-navigation/snav-multiple-select.html: Added.
  • fast/events/spatial-navigation/snav-single-select-expected.txt: Added.
  • fast/events/spatial-navigation/snav-single-select.html: Added.

2010-10-04 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Antonio Gomes.

Spatial Navigation: select element does not release focus with Spatial Navigation
https://bugs.webkit.org/show_bug.cgi?id=46896

When using Spatial Navigation, once a select element is focused, you cannot use arrow keys
to navigate out of the select element. That is because select element currently uses the
arrow keys to change the selected element.
Change the behavior of select element so it does not change selection, if Spatial Navigation
is on.

This patch is addressing the case where Spatial Navigation is used
in a mobile device, and the flag ENABLE_NO_LISTBOX_RENDERING is on.
In the future we can add support for the case where the flag is off, and
the user needs to traverse the select element inline.

Tests: fast/events/spatial-navigation/snav-multiple-select.html

fast/events/spatial-navigation/snav-single-select.html

  • dom/SelectElement.cpp: (WebCore::SelectElement::menuListDefaultEventHandler):
9:21 PM Changeset in webkit [69067] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit/chromium

2010-10-04 Matt Mueller <mattm@chromium.org>

Reviewed by Darin Fisher.

When building under chromium, build libwebkit as the same type (shared
or static) as chromium. Fixes problems with multiple calls to global
initializers/finalizers in shared chromium build.
https://bugs.webkit.org/show_bug.cgi?id=46762

  • WebKit.gyp:
9:21 PM Changeset in webkit [69066] by tkent@chromium.org
  • 3 edits in trunk/WebKitTools

2010-10-04 Tony Chang <tony@chromium.org>

Reviewed by Kent Tamura.

[chromium] fix image diffing in NRWT
https://bugs.webkit.org/show_bug.cgi?id=47128

  • Scripts/webkitpy/layout_tests/port/chromium.py: Flush data to the

temp file and check the image_diff error code more carefully

  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
9:19 PM Changeset in webkit [69065] by dpranke@chromium.org
  • 6 edits in trunk/WebKitTools

2010-10-04 Dirk Pranke <dpranke@chromium.org>

Reviewed by Adam Barth.

aroben's change in r68792 actually broke new-run-webkit-tests when
running the DRT code path. His change was intended to fix the
way we were converting windows paths to URIs when running under
Cygwin (the paths were getting one too many "/" on the front).
However, the change ended up breaking the chromium_win port, which
had slightly different logic.

This patch removes the port-specific code and adds tests to make
sure we're getting the behavior we expect. The Port object no longer
exposes a get_absolute_path() method that can be used outside of
of converting test filenames, because it's unreliable otherwise
(we don't have the right context to know which conversion is intended).

https://bugs.webkit.org/show_bug.cgi?id=47140

  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/base_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
9:16 PM Changeset in webkit [69064] by commit-queue@webkit.org
  • 3 edits in trunk/WebCore

2010-10-04 Sriram Neelakandan <sriram.neelakandan@gmail.com>

Reviewed by Andreas Kling.

[Qt] QNetworkReplyHandler forces buffered output for FormData with files
https://bugs.webkit.org/show_bug.cgi?id=46259

No new tests. Existing form submit tests should cover this change.

  • platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::FormDataIODevice::FormDataIODevice): (WebCore::FormDataIODevice::computeSize): Add computeSize() for computing form device size (WebCore::QNetworkReplyHandler::start): Call computeSize(), fill Content-Length and prevent UploadData buffering
  • platform/network/qt/QNetworkReplyHandler.h: (WebCore::FormDataIODevice::getFormDataSize):
9:03 PM Changeset in webkit [69063] by chang.shu@nokia.com
  • 3 edits
    2 adds in trunk

2010-10-04 Chang Shu <chang.shu@nokia.com>

Reviewed by Antonio Gomes.

Fixed the typo that searches the wrong direction in the no-focus-node case.
As a result, after page is loaded, pressing key "arrowdown" will bring the
focus to the 1st element instead of the last element.
https://bugs.webkit.org/show_bug.cgi?id=46901

  • fast/events/spatial-navigation/snav-1st-stop-expected.txt: Added.
  • fast/events/spatial-navigation/snav-1st-stop.html: Added.

2010-10-04 Chang Shu <chang.shu@nokia.com>

Reviewed by Antonio Gomes.

Fixed the typo that searches the wrong direction in the no-focus-node case.
As a result, after page is loaded, pressing key "arrowdown" will bring the
focus to the 1st element instead of the last element.
https://bugs.webkit.org/show_bug.cgi?id=46901

Test: fast/events/spatial-navigation/snav-1st-stop.html

  • page/FocusController.cpp: (WebCore::FocusController::advanceFocusDirectionally):
8:47 PM Changeset in webkit [69062] by Simon Fraser
  • 3 edits in trunk/WebCore

2010-10-04 Simon Fraser <Simon Fraser>

No review.

Touch cf/SocketStreamHandle.h and add an #ifdef to qt/SocketStreamHandle.h
to fail at compile time if Mac includes that header.

  • platform/network/cf/SocketStreamHandle.h:
  • platform/network/qt/SocketStreamHandle.h:
8:43 PM Changeset in webkit [69061] by commit-queue@webkit.org
  • 5 edits in trunk/WebKit/efl

2010-10-04 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Viewport data change notification by Bug 46755
https://bugs.webkit.org/show_bug.cgi?id=46772

Bug 46755 changes virtual function regarding to viewport metatag. Thus, EFL port
should change the function as well in order to get viewport arguments.

And, setInitLayoutCompleted / getInitLayoutCompleted() are removed because these functions
aren't needed anymore.

  • WebCoreSupport/ChromeClientEfl.cpp: (WebCore::ChromeClientEfl::dispatchViewportDataDidChange):
  • WebCoreSupport/ChromeClientEfl.h:
  • WebCoreSupport/FrameLoaderClientEfl.cpp: (WebCore::FrameLoaderClientEfl::FrameLoaderClientEfl): (WebCore::FrameLoaderClientEfl::dispatchDidCommitLoad): (WebCore::FrameLoaderClientEfl::dispatchDidFirstLayout):
  • WebCoreSupport/FrameLoaderClientEfl.h:
8:37 PM Changeset in webkit [69060] by commit-queue@webkit.org
  • 4 edits in trunk

2010-10-04 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Antonio Gomes.

[EFL] Use fast malloc for WebKit EFL
https://bugs.webkit.org/show_bug.cgi?id=46691

Use fast malloc for WebKit EFL because the fast malloc is to allocate
memory quickly.

  • wtf/CMakeListsEfl.txt:

2010-10-04 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Antonio Gomes.

[EFL] Use fast malloc for WebKit EFL
https://bugs.webkit.org/show_bug.cgi?id=46691

Use fast malloc for WebKit EFL because the fast malloc is to allocate
memory quickly.

  • cmake/OptionsEfl.cmake:
8:03 PM Changeset in webkit [69059] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

2010-10-04 Kent Tamura <tkent@chromium.org>

Unreviewed, test expectation update.

  • platform/chromium/test_expectations.txt: Remove a duplicated entry.
7:41 PM Changeset in webkit [69058] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

2010-10-04 Kent Tamura <tkent@chromium.org>

Unreviewed, test expectation update.

  • platform/chromium/test_expectations.txt: fail-on-update-2.html is TIMEOUT on Windows.
6:23 PM Changeset in webkit [69057] by Simon Fraser
  • 2 edits in trunk/WebCore

2010-10-04 Simon Fraser <Simon Fraser>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=47136
WebSocket tests are crashing

The Mac xcode project was finding qt/SocketStreamHandle.h because of
an inadvertent change in r68951. Thus the header and implementation didn't match,
and memory corruption ensued.

  • WebCore.xcodeproj/project.pbxproj:
6:04 PM Changeset in webkit [69056] by mrowe@apple.com
  • 3 edits in trunk/WebKit2

Fix the build when sandboxing is enabled.

Reviewed by Sam Weinig.

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::ensureWebProcess):

  • UIProcess/WebProcessProxy.cpp:
5:58 PM Changeset in webkit [69055] by hclam@chromium.org
  • 2 edits in trunk/WebKit/chromium

Build fix. Not reviewed.

Remove a function declaration.

  • src/ChromeClientImpl.h:
5:30 PM Changeset in webkit [69054] by hclam@chromium.org
  • 2 edits in trunk/WebKit/chromium

Build fix. Not reviewed.

https://bugs.webkit.org/show_bug.cgi?id=47135
Add a stub method to make the build happy.

  • src/ApplicationCacheHost.cpp:

(WebCore::ApplicationCacheHost::stopLoadingInFrame):

5:09 PM Changeset in webkit [69053] by cmarrin@apple.com
  • 11 edits in trunk

2010-10-04 Chris Marrin <cmarrin@apple.com>

Reviewed by James Robinson.

Move SharedGraphicsContext3D from ChromeClient to Page
https://bugs.webkit.org/show_bug.cgi?id=47113

4:33 PM Changeset in webkit [69052] by jorlow@chromium.org
  • 16 edits
    4 copies in trunk

2010-10-04 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Nate Chapin.

Implement IndexedDB's oncomplete and ontimeout.
https://bugs.webkit.org/show_bug.cgi?id=47106

  • storage/indexeddb/resources/shared.js: (verifyCompleteEvent):
  • storage/indexeddb/transaction-basics.html:

2010-10-04 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Nate Chapin.

Implement IndexedDB's oncomplete and ontimeout.
https://bugs.webkit.org/show_bug.cgi?id=47106

Add ontimeout and oncomplete to IDBTransaction and plumb
them. Test this behavior in the existing IDBTransaction-basics
test.

  • WebCore.gypi:
  • storage/IDBTransaction.cpp: (WebCore::IDBTransaction::IDBTransaction): (WebCore::IDBTransaction::mode): (WebCore::IDBTransaction::objectStore): (WebCore::IDBTransaction::abort): (WebCore::IDBTransaction::onAbort): (WebCore::IDBTransaction::onComplete): (WebCore::IDBTransaction::onTimeout): (WebCore::IDBTransaction::stop): (WebCore::IDBTransaction::onAbortTimerFired): (WebCore::IDBTransaction::onCompleteTimerFired): (WebCore::IDBTransaction::onTimeoutTimerFired):
  • storage/IDBTransaction.h:
  • storage/IDBTransactionBackendImpl.cpp: (WebCore::IDBTransactionBackendImpl::IDBTransactionBackendImpl): (WebCore::IDBTransactionBackendImpl::commit):
  • storage/IDBTransactionCallbacks.h:

2010-10-04 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Nate Chapin.

Implement IndexedDB's oncomplete and ontimeout.
https://bugs.webkit.org/show_bug.cgi?id=47106

  • public/WebIDBTransactionCallbacks.h: (WebKit::WebIDBTransactionCallbacks::id): (WebKit::WebIDBTransactionCallbacks::onAbort): (WebKit::WebIDBTransactionCallbacks::onComplete): (WebKit::WebIDBTransactionCallbacks::onTimeout):
  • src/IDBTransactionCallbacksProxy.cpp: (WebCore::IDBTransactionCallbacksProxy::onComplete): (WebCore::IDBTransactionCallbacksProxy::onTimeout):
  • src/IDBTransactionCallbacksProxy.h:
  • src/WebIDBTransactionCallbacksImpl.cpp: (WebCore::WebIDBTransactionCallbacksImpl::onComplete): (WebCore::WebIDBTransactionCallbacksImpl::onTimeout):
  • src/WebIDBTransactionCallbacksImpl.h:
4:30 PM Changeset in webkit [69051] by enrica@apple.com
  • 3 edits
    3 adds in trunk

Crash at WebCore::nextCandidate + 27
https://bugs.webkit.org/show_bug.cgi?id=47118
<rdar://problem/7282934>

Reviewed by Darin Adler.

WebCore:

When we canonicalize a Position to create a VisiblePosition, the position
is passed by reference. In canonicalPosition we call updateLayoutIgnorePendingStylesheets
that can produce a lot of side effects, including changing the selection.
This becomes a serious problem whne the position passed as reference is one of
the selection endpoints.

Test: editing/selection/focus-crash.html

  • editing/VisiblePosition.cpp:

(WebCore::VisiblePosition::canonicalPosition):

LayoutTests:

  • editing/resources/iframebody.html: Added.
  • editing/selection/focus-crash-expected.txt: Added.
  • editing/selection/focus-crash.html: Added.
4:17 PM Changeset in webkit [69050] by dpranke@chromium.org
  • 2 edits in trunk/WebKitTools

2010-10-04 Dirk Pranke <dpranke@chromium.org>

Unreviewed, build fix.

Handle crash introduced in r69040 if we are not running in a
Chromium checkout.

  • Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
4:12 PM Changeset in webkit [69049] by abecsi@webkit.org
  • 2 edits in trunk/WebKit2

2010-10-04 Andras Becsi <abecsi@webkit.org>

Reviewed Csaba Osztrogonác.

[Qt] Build fix after r69037.
Also remove dummy setUpAcceleratedCompositing() from the source file,
since it has been removed from the header.

  • UIProcess/WebProcessProxy.cpp:
4:12 PM Changeset in webkit [69048] by ap@apple.com
  • 5 edits
    4 adds in trunk

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=37812
Assertion failure when appcache/fail-on-update.html is run twice in a row

Test: http/tests/appcache/fail-on-update-2.html

For some reason, I can't reproduce this assertion failure with ToT, but the fixes I made
previously are still good, and covered by the new test.

  • loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::selectCache): Handle the case when the cache is already obsolete by the time cache selection occurs.
  • loader/appcache/ApplicationCacheHost.cpp: (WebCore::ApplicationCacheHost::failedLoadingMainResource): It's not true that loading from appcache always succeeds - it can be aborted.
  • loader/appcache/ApplicationCacheStorage.cpp: (WebCore::ApplicationCacheStorage::store): Calling ensureOriginRecord(group->origin()) can change lastInsertRowID!
4:07 PM Changeset in webkit [69047] by arv@chromium.org
  • 6 edits in trunk

2010-10-04 Erik Arvidsson <arv@chromium.org>

Reviewed by James Robinson.

https://bugs.webkit.org/show_bug.cgi?id=47122
Crash in classList when class attribute is empty.

  • fast/dom/HTMLElement/class-list-expected.txt:
  • fast/dom/HTMLElement/class-list-quirks-expected.txt:
  • fast/dom/HTMLElement/script-tests/class-list.js:

2010-10-04 Erik Arvidsson <arv@chromium.org>

Reviewed by James Robinson.

https://bugs.webkit.org/show_bug.cgi?id=47122
Crash in classList when class attribute is empty.

Tests: fast/dom/HTMLElement/class-list.html

  • html/DOMTokenList.cpp: (WebCore::DOMTokenList::length): (WebCore::DOMTokenList::containsInternal): (WebCore::DOMTokenList::classNames):
3:57 PM Changeset in webkit [69046] by Csaba Osztrogonác
  • 2 edits in trunk/WebKit2

[Qt] Fix the WebKit2 build after r69029.

Patch by Andras Becsi <abecsi@webkit.org> on 2010-10-04
Rubber-stamped by Csaba Osztrogonác.

  • DerivedSources.pro:
3:43 PM Changeset in webkit [69045] by oliver@apple.com
  • 14 edits in trunk/JavaScriptCore

2010-10-04 Oliver Hunt <oliver@apple.com>

Reviewed by Geoff Garen.

Lazily create activation objects
https://bugs.webkit.org/show_bug.cgi?id=47107

Make it possible to lazily create the activation object
for a function that needs one. This allows us to reduce
the overhead of entering a function that may require
an activation in some cases, but not always.

This does make exception handling a little more complex as
it's now necessary to verify that a callframes activation
has been created, and create it if not, in all of the
paths used in exception handling.

We also need to add logic to check for the existence of
the activation in the scoped_var opcodes, as well as
op_ret, op_ret_object_or_this and op_tearoff_activation
so that we can avoid creating an activation unnecesarily
on function exit.

  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::dump): (JSC::CodeBlock::reparseForExceptionInfoIfNecessary): (JSC::CodeBlock::createActivation):
  • bytecode/CodeBlock.h: (JSC::CodeBlock::setActivationRegister): (JSC::CodeBlock::activationRegister):
  • bytecode/Opcode.h:
  • bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::BytecodeGenerator): (JSC::BytecodeGenerator::emitNewFunctionInternal): (JSC::BytecodeGenerator::emitNewFunctionExpression): (JSC::BytecodeGenerator::createActivationIfNecessary):
  • bytecompiler/BytecodeGenerator.h:
  • interpreter/Interpreter.cpp: (JSC::Interpreter::resolveSkip): (JSC::Interpreter::resolveGlobalDynamic): (JSC::Interpreter::resolveBase): (JSC::Interpreter::unwindCallFrame): (JSC::Interpreter::throwException): (JSC::Interpreter::privateExecute):
  • jit/JIT.cpp: (JSC::JIT::privateCompileMainPass):
  • jit/JIT.h:
  • jit/JITCall32_64.cpp: (JSC::JIT::emit_op_ret): (JSC::JIT::emit_op_ret_object_or_this):
  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_end): (JSC::JIT::emit_op_get_scoped_var): (JSC::JIT::emit_op_put_scoped_var): (JSC::JIT::emit_op_tear_off_activation): (JSC::JIT::emit_op_ret): (JSC::JIT::emit_op_ret_object_or_this): (JSC::JIT::emit_op_create_activation): (JSC::JIT::emit_op_resolve_global_dynamic):
  • jit/JITOpcodes32_64.cpp: (JSC::JIT::emit_op_get_scoped_var): (JSC::JIT::emit_op_put_scoped_var): (JSC::JIT::emit_op_tear_off_activation): (JSC::JIT::emit_op_create_activation):
  • jit/JITStubs.cpp: (JSC::DEFINE_STUB_FUNCTION):
3:41 PM Changeset in webkit [69044] by Darin Adler
  • 7 edits in trunk/WebCore

2010-10-04 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

Use isHTMLSpace in more places, and optimize it
https://bugs.webkit.org/show_bug.cgi?id=47103

  • css/CSSParser.cpp: (WebCore::parseColorInt): Use isHTMLSpace instead of a separate isCSSWhitespace function. (WebCore::parseAlphaValue): Ditto. (WebCore::CSSParser::text): Ditto.
  • dom/SpaceSplitString.h: Removed isClassWhitespace.
  • dom/SpaceSplitString.cpp: (WebCore::SpaceSplitStringData::createVector): Use isHTMLSpace instead of isClassWhitespace.
  • dom/StyledElement.cpp: (WebCore::StyledElement::classAttributeChanged): Ditto.
  • html/DOMTokenList.cpp: (WebCore::validateToken): Ditto. (WebCore::DOMTokenList::removeInternal): Ditto.
  • html/parser/HTMLParserIdioms.h: Added histogram data an changed so that non-spaces take only a single branch and plain old spaces take only two branches.
3:39 PM WebKitGTKFonts edited by Martin Robinson
(diff)
3:25 PM Changeset in webkit [69043] by jschuh@chromium.org
  • 9 edits
    2 adds in trunk

2010-10-04 Justin Schuh <jschuh@chromium.org>

Reviewed by James Robinson.

HTMLMediaElement delayed load should fire asynchronously
https://bugs.webkit.org/show_bug.cgi?id=45765

Test: media/remove-from-document-before-load.html

  • dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::decrementLoadEventDelayCount): (WebCore::Document::loadEventDelayTimerFired):
  • dom/Document.h:
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement): (WebCore::HTMLMediaElement::asyncEventTimerFired): (WebCore::HTMLMediaElement::setShouldDelayLoadEvent):
  • html/HTMLMediaElement.h:

2010-10-04 Justin Schuh <jschuh@chromium.org>

Reviewed by James Robinson.

HTMLMediaElement delayed load should fire asynchronously
https://bugs.webkit.org/show_bug.cgi?id=45765

  • media/remove-from-document-before-load-expected.txt: Added.
  • media/remove-from-document-before-load.html: Added.
  • media/video-click-dblckick-standalone.html:
  • media/video-controls-rendering.html:
  • media/video-transformed.html:
3:19 PM Changeset in webkit [69042] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-10-04 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

ResourceHandle's public/protected/private sections are fragmented
https://bugs.webkit.org/show_bug.cgi?id=47038

Minor cleanup.

  • platform/network/ResourceHandle.h:
3:16 PM WebKitGTKFonts edited by Martin Robinson
Update bug list (diff)
3:14 PM Changeset in webkit [69041] by ap@apple.com
  • 6 edits in trunk/WebCore

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=43506
<rdar://problem/8289284> foreign-iframe-main.html occasionally crashes (during the next test,
idempotent-update.html)

Application cache doesn't use ResourceLoader machinery (for better or worse), so we need to
abort update process explicitly.

Note that in principle, update could piggyback on any other existing frame - or even run
frameless - but currently, it's tied to the first frame that requested update.

  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::stopLoading):
  • loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::stopLoadingInFrame):
  • loader/appcache/ApplicationCacheGroup.h:
  • loader/appcache/ApplicationCacheHost.cpp: (WebCore::ApplicationCacheHost::~ApplicationCacheHost): (WebCore::ApplicationCacheHost::stopLoadingInFrame):
  • loader/appcache/ApplicationCacheHost.h:
3:11 PM Changeset in webkit [69040] by dpranke@chromium.org
  • 3 edits in trunk/WebKitTools

2010-10-04 Dirk Pranke <dpranke@chromium.org>

Reviewed by Tony Chang.

Add a way for us to have test expectations that are specific to the
official builds of Google Chrome (as opposed to Chromium). This change
looks for an additional "test_expectations_chrome.txt" file in
Chromium's repository (webkit/tools/layout_tests), and uses the
concatenation of that file and the regular test_expectations.txt
file for test overrides.

https://bugs.webkit.org/show_bug.cgi?id=46854

  • Scripts/webkitpy/layout_tests/port/google_chrome.py:
  • Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
3:09 PM Changeset in webkit [69039] by abarth@webkit.org
  • 29 edits
    2 moves in trunk

2010-10-04 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Rename RedirectScheduler to NavigationScheduler
https://bugs.webkit.org/show_bug.cgi?id=47037

Update for name change.

  • src/ApplicationCacheHost.cpp: (WebCore::ApplicationCacheHost::selectCacheWithManifest):
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::loadJavaScriptURL):

2010-10-04 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Rename RedirectScheduler to NavigationScheduler
https://bugs.webkit.org/show_bug.cgi?id=47037

Update for name change.

  • Api/qwebpage.cpp: (QWebPage::triggerAction):

2010-10-04 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Rename RedirectScheduler to NavigationScheduler
https://bugs.webkit.org/show_bug.cgi?id=47037

This class schedules more than just redirects. In fact, it schedules
most kinds of navigations.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/generic/BindingDOMWindow.h: (WebCore::::createWindow): (WebCore::::open):
  • bindings/generic/BindingFrame.h: (WebCore::::navigateIfAllowed):
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::setLocation): (WebCore::createWindow): (WebCore::JSDOMWindow::open):
  • bindings/js/JSDocumentCustom.cpp: (WebCore::JSDocument::setLocation):
  • bindings/js/JSLocationCustom.cpp: (WebCore::JSLocation::reload):
  • bindings/v8/custom/V8LocationCustom.cpp: (WebCore::V8Location::reloadCallback):
  • dom/Document.cpp: (WebCore::Document::implicitClose): (WebCore::Document::processHttpEquiv):
  • inspector/InspectorController.cpp: (WebCore::InspectorController::setResourceTrackingEnabled): (WebCore::InspectorController::reloadPage):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::setDefersLoading): (WebCore::FrameLoader::submitForm): (WebCore::FrameLoader::stopLoading): (WebCore::FrameLoader::didOpenURL): (WebCore::FrameLoader::didExplicitOpen): (WebCore::FrameLoader::cancelAndClear): (WebCore::FrameLoader::clear): (WebCore::FrameLoader::receivedFirstData): (WebCore::FrameLoader::checkCompleted): (WebCore::FrameLoader::provisionalLoadStarted): (WebCore::FrameLoader::completed): (WebCore::FrameLoader::prepareForCachedPageRestore):
  • loader/FrameLoader.h:
  • loader/NavigationScheduler.cpp: Added. (WebCore::ScheduledNavigation::ScheduledNavigation): (WebCore::ScheduledNavigation::~ScheduledNavigation): (WebCore::ScheduledNavigation::shouldStartTimer): (WebCore::ScheduledNavigation::didStartTimer): (WebCore::ScheduledNavigation::didStopTimer): (WebCore::ScheduledNavigation::delay): (WebCore::ScheduledNavigation::lockHistory): (WebCore::ScheduledNavigation::lockBackForwardList): (WebCore::ScheduledNavigation::wasDuringLoad): (WebCore::ScheduledNavigation::isLocationChange): (WebCore::ScheduledNavigation::wasUserGesture): (WebCore::ScheduledURLNavigation::ScheduledURLNavigation): (WebCore::ScheduledURLNavigation::fire): (WebCore::ScheduledURLNavigation::didStartTimer): (WebCore::ScheduledURLNavigation::didStopTimer): (WebCore::ScheduledURLNavigation::url): (WebCore::ScheduledURLNavigation::referrer): (WebCore::ScheduledRedirect::ScheduledRedirect): (WebCore::ScheduledRedirect::shouldStartTimer): (WebCore::ScheduledLocationChange::ScheduledLocationChange): (WebCore::ScheduledRefresh::ScheduledRefresh): (WebCore::ScheduledRefresh::fire): (WebCore::ScheduledHistoryNavigation::ScheduledHistoryNavigation): (WebCore::ScheduledHistoryNavigation::fire): (WebCore::ScheduledFormSubmission::ScheduledFormSubmission): (WebCore::ScheduledFormSubmission::fire): (WebCore::ScheduledFormSubmission::didStartTimer): (WebCore::ScheduledFormSubmission::didStopTimer): (WebCore::NavigationScheduler::NavigationScheduler): (WebCore::NavigationScheduler::~NavigationScheduler): (WebCore::NavigationScheduler::redirectScheduledDuringLoad): (WebCore::NavigationScheduler::locationChangePending): (WebCore::NavigationScheduler::clear): (WebCore::NavigationScheduler::scheduleRedirect): (WebCore::NavigationScheduler::mustLockBackForwardList): (WebCore::NavigationScheduler::scheduleLocationChange): (WebCore::NavigationScheduler::scheduleFormSubmission): (WebCore::NavigationScheduler::scheduleRefresh): (WebCore::NavigationScheduler::scheduleHistoryNavigation): (WebCore::NavigationScheduler::timerFired): (WebCore::NavigationScheduler::schedule): (WebCore::NavigationScheduler::startTimer): (WebCore::NavigationScheduler::cancel):
  • loader/NavigationScheduler.h: Added.
  • loader/RedirectScheduler.cpp: Removed.
  • loader/RedirectScheduler.h: Removed.
  • loader/SubframeLoader.cpp: (WebCore::SubframeLoader::loadOrRedirectSubframe):
  • loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::selectCache):
  • page/Frame.cpp: (WebCore::Frame::Frame):
  • page/Frame.h: (WebCore::Frame::navigationScheduler):
  • page/History.cpp: (WebCore::History::back): (WebCore::History::forward): (WebCore::History::go):
  • page/XSSAuditor.cpp: (WebCore::XSSAuditor::findInRequest):
2:56 PM Changeset in webkit [69038] by abarth@webkit.org
  • 7 edits in trunk

2010-10-04 Adam Barth <abarth@webkit.org>

Reviewed by Sam Weinig.

Remove ENABLE_SANDBOX
https://bugs.webkit.org/show_bug.cgi?id=47032

  • Configurations/FeatureDefines.xcconfig:

2010-10-04 Adam Barth <abarth@webkit.org>

Reviewed by Sam Weinig.

Remove ENABLE_SANDBOX
https://bugs.webkit.org/show_bug.cgi?id=47032

I'm not sure there's a reason for this to be behind a compile flag
anymore.

  • Configurations/FeatureDefines.xcconfig:
  • GNUmakefile.am:
  • features.pri:
  • html/HTMLIFrameElement.cpp: (WebCore::parseSandboxAttribute): (WebCore::HTMLIFrameElement::parseMappedAttribute):
2:14 PM Changeset in webkit [69037] by weinig@apple.com
  • 15 edits
    2 adds
    1 delete in trunk/WebKit2

Change WebProcess initialization to be done with an
auxiliary struct.

Reviewed by Anders Carlsson.

  • Platform/CoreIPC/mac/MachPort.h:
  • Shared/WebProcessCreationParameters.cpp: Added.

(WebKit::WebProcessCreationParameters::WebProcessCreationParameters):
(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):

  • Shared/WebProcessCreationParameters.h: Added.
  • UIProcess/WebContext.cpp:

(WebKit::WebContext::ensureWebProcess):

  • UIProcess/WebContext.h:
  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::WebProcessProxy):

  • UIProcess/WebProcessProxy.h:
  • UIProcess/mac/WebContextMac.mm:

(WebKit::WebContext::platformInitializeWebProcess):

  • UIProcess/mac/WebProcessProxyMac.mm: Removed.
  • UIProcess/qt/WebContextQt.cpp:

(WebKit::WebContext::applicationCacheDirectory):
(WebKit::WebContext::platformInitializeWebProcess):

  • UIProcess/win/WebContextWin.cpp:

(WebKit::WebContext::platformInitializeWebProcess):

  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeWebProcess):

  • WebProcess/WebProcess.h:
  • WebProcess/WebProcess.messages.in:
  • win/WebKit2.vcproj:
2:09 PM Changeset in webkit [69036] by Simon Fraser
  • 3 edits in trunk/WebKitTools

2010-10-04 Simon Fraser <Simon Fraser>

Color tests in the list based on existing pass/fail result.

Fix the summary data to account for htmlOnly and nonHTML tests.

  • CSSTestSuiteHarness/harness/harness.css: (#test-list > option.pass): (#test-list > option.fail): (#test-list > option.skipped):
  • CSSTestSuiteHarness/harness/harness.js: (Test): (Test.prototype.statusForFormat): (TestSuite.prototype.fillTestList): (TestSuite.prototype.updateTestList): (TestSuite.prototype.recordResult): (TestSuite.prototype.markTestCompleted): (TestSuite.prototype.countTestsWithFlag): (TestSuite.prototype.queryDatabaseForSummary.this.db.transaction): (TestSuite.prototype.queryDatabaseForSummary):
2:08 PM Changeset in webkit [69035] by hclam@chromium.org
  • 267 edits
    41 copies
    18 adds in trunk/LayoutTests

Build fix. Not reviewed.

Add test expectations for the recently SVG change.

  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-30-t-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-30-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-30-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/masking-intro-01-f-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-align-02-b-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-align-02-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-align-02-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-align-05-b-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-align-05-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-align-05-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-align-06-b-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-align-06-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-align-06-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-text-05-t-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-text-05-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-text-05-t-expected.txt: Added.
  • platform/chromium-linux/svg/text/kerning-expected.txt: Added.
  • platform/chromium-linux/svg/text/multichar-glyph-expected.checksum:
  • platform/chromium-linux/svg/text/multichar-glyph-expected.png:
  • platform/chromium-linux/svg/text/multichar-glyph-expected.txt: Added.
  • platform/chromium-linux/svg/text/select-textLength-spacing-squeeze-1-expected.checksum:
  • platform/chromium-linux/svg/text/select-textLength-spacing-squeeze-1-expected.png:
  • platform/chromium-linux/svg/text/select-textLength-spacing-squeeze-1-expected.txt: Copied from LayoutTests/platform/gtk/svg/text/select-textLength-spacing-squeeze-1-expected.txt.
  • platform/chromium-linux/svg/text/select-textLength-spacing-squeeze-2-expected.checksum:
  • platform/chromium-linux/svg/text/select-textLength-spacing-squeeze-2-expected.png:
  • platform/chromium-linux/svg/text/select-textLength-spacing-squeeze-2-expected.txt: Copied from LayoutTests/platform/gtk/svg/text/select-textLength-spacing-squeeze-2-expected.txt.
  • platform/chromium-linux/svg/text/select-textLength-spacing-squeeze-3-expected.checksum:
  • platform/chromium-linux/svg/text/select-textLength-spacing-squeeze-3-expected.png:
  • platform/chromium-linux/svg/text/select-textLength-spacing-squeeze-3-expected.txt: Copied from LayoutTests/platform/gtk/svg/text/select-textLength-spacing-squeeze-3-expected.txt.
  • platform/chromium-linux/svg/text/select-textLength-spacing-squeeze-4-expected.checksum:
  • platform/chromium-linux/svg/text/select-textLength-spacing-squeeze-4-expected.png:
  • platform/chromium-linux/svg/text/select-textLength-spacing-squeeze-4-expected.txt: Copied from LayoutTests/platform/gtk/svg/text/select-textLength-spacing-squeeze-4-expected.txt.
  • platform/chromium-linux/svg/text/select-textLength-spacing-stretch-1-expected.checksum:
  • platform/chromium-linux/svg/text/select-textLength-spacing-stretch-1-expected.png:
  • platform/chromium-linux/svg/text/select-textLength-spacing-stretch-1-expected.txt:
  • platform/chromium-linux/svg/text/select-textLength-spacing-stretch-2-expected.checksum:
  • platform/chromium-linux/svg/text/select-textLength-spacing-stretch-2-expected.png:
  • platform/chromium-linux/svg/text/select-textLength-spacing-stretch-2-expected.txt:
  • platform/chromium-linux/svg/text/select-textLength-spacing-stretch-3-expected.checksum:
  • platform/chromium-linux/svg/text/select-textLength-spacing-stretch-3-expected.png:
  • platform/chromium-linux/svg/text/select-textLength-spacing-stretch-3-expected.txt:
  • platform/chromium-linux/svg/text/select-textLength-spacing-stretch-4-expected.checksum:
  • platform/chromium-linux/svg/text/select-textLength-spacing-stretch-4-expected.png:
  • platform/chromium-linux/svg/text/select-textLength-spacing-stretch-4-expected.txt:
  • platform/chromium-linux/svg/text/select-textLength-spacingAndGlyphs-squeeze-1-expected.checksum:
  • platform/chromium-linux/svg/text/select-textLength-spacingAndGlyphs-squeeze-1-expected.png:
  • platform/chromium-linux/svg/text/select-textLength-spacingAndGlyphs-squeeze-1-expected.txt: Copied from LayoutTests/platform/gtk/svg/text/select-textLength-spacingAndGlyphs-squeeze-1-expected.txt.
  • platform/chromium-linux/svg/text/select-textLength-spacingAndGlyphs-squeeze-2-expected.checksum:
  • platform/chromium-linux/svg/text/select-textLength-spacingAndGlyphs-squeeze-2-expected.png:
  • platform/chromium-linux/svg/text/select-textLength-spacingAndGlyphs-squeeze-2-expected.txt: Copied from LayoutTests/platform/gtk/svg/text/select-textLength-spacingAndGlyphs-squeeze-2-expected.txt.
  • platform/chromium-linux/svg/text/select-textLength-spacingAndGlyphs-squeeze-3-expected.checksum:
  • platform/chromium-linux/svg/text/select-textLength-spacingAndGlyphs-squeeze-3-expected.png:
  • platform/chromium-linux/svg/text/select-textLength-spacingAndGlyphs-squeeze-3-expected.txt: Copied from LayoutTests/platform/gtk/svg/text/select-textLength-spacingAndGlyphs-squeeze-3-expected.txt.
  • platform/chromium-linux/svg/text/select-textLength-spacingAndGlyphs-squeeze-4-expected.checksum:
  • platform/chromium-linux/svg/text/select-textLength-spacingAndGlyphs-squeeze-4-expected.png:
  • platform/chromium-linux/svg/text/select-textLength-spacingAndGlyphs-squeeze-4-expected.txt: Copied from LayoutTests/platform/gtk/svg/text/select-textLength-spacingAndGlyphs-squeeze-4-expected.txt.
  • platform/chromium-linux/svg/text/select-textLength-spacingAndGlyphs-stretch-1-expected.checksum:
  • platform/chromium-linux/svg/text/select-textLength-spacingAndGlyphs-stretch-1-expected.png:
  • platform/chromium-linux/svg/text/select-textLength-spacingAndGlyphs-stretch-1-expected.txt:
  • platform/chromium-linux/svg/text/select-textLength-spacingAndGlyphs-stretch-2-expected.checksum:
  • platform/chromium-linux/svg/text/select-textLength-spacingAndGlyphs-stretch-2-expected.png:
  • platform/chromium-linux/svg/text/select-textLength-spacingAndGlyphs-stretch-2-expected.txt:
  • platform/chromium-linux/svg/text/select-textLength-spacingAndGlyphs-stretch-3-expected.checksum:
  • platform/chromium-linux/svg/text/select-textLength-spacingAndGlyphs-stretch-3-expected.png:
  • platform/chromium-linux/svg/text/select-textLength-spacingAndGlyphs-stretch-3-expected.txt:
  • platform/chromium-linux/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.checksum:
  • platform/chromium-linux/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.png:
  • platform/chromium-linux/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.txt:
  • platform/chromium-linux/svg/text/select-x-list-1-expected.checksum:
  • platform/chromium-linux/svg/text/select-x-list-1-expected.png:
  • platform/chromium-linux/svg/text/select-x-list-1-expected.txt: Copied from LayoutTests/platform/gtk/svg/text/select-x-list-1-expected.txt.
  • platform/chromium-linux/svg/text/select-x-list-2-expected.checksum:
  • platform/chromium-linux/svg/text/select-x-list-2-expected.png:
  • platform/chromium-linux/svg/text/select-x-list-2-expected.txt: Copied from LayoutTests/platform/gtk/svg/text/select-x-list-2-expected.txt.
  • platform/chromium-linux/svg/text/select-x-list-3-expected.checksum:
  • platform/chromium-linux/svg/text/select-x-list-3-expected.png:
  • platform/chromium-linux/svg/text/select-x-list-3-expected.txt: Copied from LayoutTests/platform/gtk/svg/text/select-x-list-3-expected.txt.
  • platform/chromium-linux/svg/text/select-x-list-4-expected.checksum:
  • platform/chromium-linux/svg/text/select-x-list-4-expected.png:
  • platform/chromium-linux/svg/text/select-x-list-4-expected.txt: Copied from LayoutTests/platform/gtk/svg/text/select-x-list-4-expected.txt.
  • platform/chromium-linux/svg/text/select-x-list-with-tspans-1-expected.checksum:
  • platform/chromium-linux/svg/text/select-x-list-with-tspans-1-expected.png:
  • platform/chromium-linux/svg/text/select-x-list-with-tspans-1-expected.txt: Copied from LayoutTests/platform/gtk/svg/text/select-x-list-with-tspans-1-expected.txt.
  • platform/chromium-linux/svg/text/select-x-list-with-tspans-2-expected.checksum:
  • platform/chromium-linux/svg/text/select-x-list-with-tspans-2-expected.png:
  • platform/chromium-linux/svg/text/select-x-list-with-tspans-2-expected.txt: Copied from LayoutTests/platform/gtk/svg/text/select-x-list-with-tspans-2-expected.txt.
  • platform/chromium-linux/svg/text/select-x-list-with-tspans-3-expected.checksum:
  • platform/chromium-linux/svg/text/select-x-list-with-tspans-3-expected.png:
  • platform/chromium-linux/svg/text/select-x-list-with-tspans-3-expected.txt: Copied from LayoutTests/platform/gtk/svg/text/select-x-list-with-tspans-3-expected.txt.
  • platform/chromium-linux/svg/text/select-x-list-with-tspans-4-expected.checksum:
  • platform/chromium-linux/svg/text/select-x-list-with-tspans-4-expected.png:
  • platform/chromium-linux/svg/text/select-x-list-with-tspans-4-expected.txt: Copied from LayoutTests/platform/gtk/svg/text/select-x-list-with-tspans-4-expected.txt.
  • platform/chromium-linux/svg/text/text-align-01-b-expected.txt: Added.
  • platform/chromium-linux/svg/text/text-align-02-b-expected.checksum:
  • platform/chromium-linux/svg/text/text-align-02-b-expected.png:
  • platform/chromium-linux/svg/text/text-align-02-b-expected.txt: Added.
  • platform/chromium-linux/svg/text/text-align-03-b-expected.txt: Added.
  • platform/chromium-linux/svg/text/text-align-04-b-expected.checksum:
  • platform/chromium-linux/svg/text/text-align-04-b-expected.png:
  • platform/chromium-linux/svg/text/text-align-04-b-expected.txt: Added.
  • platform/chromium-linux/svg/text/text-align-05-b-expected.checksum:
  • platform/chromium-linux/svg/text/text-align-05-b-expected.png:
  • platform/chromium-linux/svg/text/text-align-05-b-expected.txt: Added.
  • platform/chromium-linux/svg/text/text-align-06-b-expected.checksum:
  • platform/chromium-linux/svg/text/text-align-06-b-expected.png:
  • platform/chromium-linux/svg/text/text-align-06-b-expected.txt: Added.
  • platform/chromium-linux/svg/text/text-altglyph-01-b-expected.txt: Added.
  • platform/chromium-linux/svg/text/text-deco-01-b-expected.checksum:
  • platform/chromium-linux/svg/text/text-deco-01-b-expected.png:
  • platform/chromium-linux/svg/text/text-deco-01-b-expected.txt: Added.
  • platform/chromium-linux/svg/text/text-fonts-01-t-expected.txt:
  • platform/chromium-linux/svg/text/text-fonts-02-t-expected.txt:
  • platform/chromium-linux/svg/text/text-gradient-positioning-expected.txt: Added.
  • platform/chromium-linux/svg/text/text-hkern-expected.png: Added.
  • platform/chromium-linux/svg/text/text-intro-05-t-expected.txt:
  • platform/chromium-linux/svg/text/text-path-01-b-expected.checksum:
  • platform/chromium-linux/svg/text/text-path-01-b-expected.png:
  • platform/chromium-linux/svg/text/text-path-01-b-expected.txt: Added.
  • platform/chromium-linux/svg/text/text-repaint-rects-expected.txt: Added.
  • platform/chromium-linux/svg/text/text-spacing-01-b-expected.checksum:
  • platform/chromium-linux/svg/text/text-spacing-01-b-expected.png:
  • platform/chromium-linux/svg/text/text-spacing-01-b-expected.txt:
  • platform/chromium-linux/svg/text/text-text-01-b-expected.checksum:
  • platform/chromium-linux/svg/text/text-text-01-b-expected.png:
  • platform/chromium-linux/svg/text/text-text-01-b-expected.txt:
  • platform/chromium-linux/svg/text/text-text-03-b-expected.txt: Added.
  • platform/chromium-linux/svg/text/text-text-04-t-expected.checksum:
  • platform/chromium-linux/svg/text/text-text-04-t-expected.png:
  • platform/chromium-linux/svg/text/text-text-04-t-expected.txt: Added.
  • platform/chromium-linux/svg/text/text-text-05-t-expected.checksum:
  • platform/chromium-linux/svg/text/text-text-05-t-expected.png:
  • platform/chromium-linux/svg/text/text-text-05-t-expected.txt: Added.
  • platform/chromium-linux/svg/text/text-text-06-t-expected.txt: Added.
  • platform/chromium-linux/svg/text/text-text-07-t-expected.checksum:
  • platform/chromium-linux/svg/text/text-text-07-t-expected.png:
  • platform/chromium-linux/svg/text/text-text-07-t-expected.txt: Added.
  • platform/chromium-linux/svg/text/text-text-08-b-expected.checksum:
  • platform/chromium-linux/svg/text/text-text-08-b-expected.png:
  • platform/chromium-linux/svg/text/text-text-08-b-expected.txt: Added.
  • platform/chromium-linux/svg/text/text-tref-01-b-expected.txt: Added.
  • platform/chromium-linux/svg/text/text-tselect-01-b-expected.txt: Added.
  • platform/chromium-linux/svg/text/text-tselect-02-f-expected.txt: Added.
  • platform/chromium-linux/svg/text/text-tspan-01-b-expected.txt: Added.
  • platform/chromium-linux/svg/text/text-vkern-expected.png: Added.
  • platform/chromium-linux/svg/text/text-ws-01-t-expected.txt: Added.
  • platform/chromium-linux/svg/text/text-ws-02-t-expected.txt: Added.
  • platform/chromium-linux/svg/text/textPathBoundsBug-expected.txt: Added.
  • platform/chromium-mac/svg/text/text-align-02-b-expected.checksum:
  • platform/chromium-mac/svg/text/text-align-02-b-expected.png: Added.
  • platform/chromium-mac/svg/text/text-align-04-b-expected.checksum:
  • platform/chromium-mac/svg/text/text-align-04-b-expected.png:
  • platform/chromium-mac/svg/text/text-align-05-b-expected.checksum:
  • platform/chromium-mac/svg/text/text-align-05-b-expected.png: Added.
  • platform/chromium-mac/svg/text/text-align-06-b-expected.checksum:
  • platform/chromium-mac/svg/text/text-align-06-b-expected.png: Added.
  • platform/chromium-mac/svg/text/text-deco-01-b-expected.checksum:
  • platform/chromium-mac/svg/text/text-deco-01-b-expected.png: Added.
  • platform/chromium-mac/svg/text/text-path-01-b-expected.checksum:
  • platform/chromium-mac/svg/text/text-path-01-b-expected.png:
  • platform/chromium-mac/svg/text/text-spacing-01-b-expected.checksum:
  • platform/chromium-mac/svg/text/text-spacing-01-b-expected.png: Added.
  • platform/chromium-mac/svg/text/text-text-01-b-expected.checksum:
  • platform/chromium-mac/svg/text/text-text-01-b-expected.png: Added.
  • platform/chromium-mac/svg/text/text-text-04-t-expected.checksum:
  • platform/chromium-mac/svg/text/text-text-04-t-expected.png: Added.
  • platform/chromium-mac/svg/text/text-text-07-t-expected.checksum:
  • platform/chromium-mac/svg/text/text-text-07-t-expected.png: Added.
  • platform/chromium-mac/svg/text/text-text-08-b-expected.checksum:
  • platform/chromium-mac/svg/text/text-text-08-b-expected.png:
  • platform/chromium-win-vista/svg/batik/text/verticalText-expected.checksum:
  • platform/chromium-win-vista/svg/batik/text/verticalText-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-30-t-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-30-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-30-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/masking-intro-01-f-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/text-align-02-b-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/text-align-02-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/text-align-02-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/text-align-05-b-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/text-align-05-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/text-align-05-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/text-align-06-b-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/text-align-06-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/text-align-06-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/text-text-05-t-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/text-text-05-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/text-text-05-t-expected.txt:
  • platform/chromium-win/svg/text/kerning-expected.txt:
  • platform/chromium-win/svg/text/multichar-glyph-expected.checksum:
  • platform/chromium-win/svg/text/multichar-glyph-expected.png:
  • platform/chromium-win/svg/text/multichar-glyph-expected.txt:
  • platform/chromium-win/svg/text/select-textLength-spacing-squeeze-1-expected.checksum:
  • platform/chromium-win/svg/text/select-textLength-spacing-squeeze-1-expected.png:
  • platform/chromium-win/svg/text/select-textLength-spacing-squeeze-1-expected.txt:
  • platform/chromium-win/svg/text/select-textLength-spacing-squeeze-2-expected.checksum:
  • platform/chromium-win/svg/text/select-textLength-spacing-squeeze-2-expected.png:
  • platform/chromium-win/svg/text/select-textLength-spacing-squeeze-2-expected.txt:
  • platform/chromium-win/svg/text/select-textLength-spacing-squeeze-3-expected.checksum:
  • platform/chromium-win/svg/text/select-textLength-spacing-squeeze-3-expected.png:
  • platform/chromium-win/svg/text/select-textLength-spacing-squeeze-3-expected.txt:
  • platform/chromium-win/svg/text/select-textLength-spacing-squeeze-4-expected.checksum:
  • platform/chromium-win/svg/text/select-textLength-spacing-squeeze-4-expected.png:
  • platform/chromium-win/svg/text/select-textLength-spacing-squeeze-4-expected.txt:
  • platform/chromium-win/svg/text/select-textLength-spacing-stretch-1-expected.checksum:
  • platform/chromium-win/svg/text/select-textLength-spacing-stretch-1-expected.png:
  • platform/chromium-win/svg/text/select-textLength-spacing-stretch-1-expected.txt:
  • platform/chromium-win/svg/text/select-textLength-spacing-stretch-2-expected.checksum:
  • platform/chromium-win/svg/text/select-textLength-spacing-stretch-2-expected.png:
  • platform/chromium-win/svg/text/select-textLength-spacing-stretch-2-expected.txt:
  • platform/chromium-win/svg/text/select-textLength-spacing-stretch-3-expected.checksum:
  • platform/chromium-win/svg/text/select-textLength-spacing-stretch-3-expected.png:
  • platform/chromium-win/svg/text/select-textLength-spacing-stretch-3-expected.txt:
  • platform/chromium-win/svg/text/select-textLength-spacing-stretch-4-expected.checksum:
  • platform/chromium-win/svg/text/select-textLength-spacing-stretch-4-expected.png:
  • platform/chromium-win/svg/text/select-textLength-spacing-stretch-4-expected.txt:
  • platform/chromium-win/svg/text/select-textLength-spacingAndGlyphs-squeeze-1-expected.checksum:
  • platform/chromium-win/svg/text/select-textLength-spacingAndGlyphs-squeeze-1-expected.png:
  • platform/chromium-win/svg/text/select-textLength-spacingAndGlyphs-squeeze-1-expected.txt:
  • platform/chromium-win/svg/text/select-textLength-spacingAndGlyphs-squeeze-2-expected.checksum:
  • platform/chromium-win/svg/text/select-textLength-spacingAndGlyphs-squeeze-2-expected.png:
  • platform/chromium-win/svg/text/select-textLength-spacingAndGlyphs-squeeze-2-expected.txt:
  • platform/chromium-win/svg/text/select-textLength-spacingAndGlyphs-squeeze-3-expected.checksum:
  • platform/chromium-win/svg/text/select-textLength-spacingAndGlyphs-squeeze-3-expected.png:
  • platform/chromium-win/svg/text/select-textLength-spacingAndGlyphs-squeeze-3-expected.txt:
  • platform/chromium-win/svg/text/select-textLength-spacingAndGlyphs-squeeze-4-expected.checksum:
  • platform/chromium-win/svg/text/select-textLength-spacingAndGlyphs-squeeze-4-expected.png:
  • platform/chromium-win/svg/text/select-textLength-spacingAndGlyphs-squeeze-4-expected.txt:
  • platform/chromium-win/svg/text/select-textLength-spacingAndGlyphs-stretch-1-expected.checksum:
  • platform/chromium-win/svg/text/select-textLength-spacingAndGlyphs-stretch-1-expected.png:
  • platform/chromium-win/svg/text/select-textLength-spacingAndGlyphs-stretch-1-expected.txt:
  • platform/chromium-win/svg/text/select-textLength-spacingAndGlyphs-stretch-2-expected.checksum:
  • platform/chromium-win/svg/text/select-textLength-spacingAndGlyphs-stretch-2-expected.png:
  • platform/chromium-win/svg/text/select-textLength-spacingAndGlyphs-stretch-2-expected.txt:
  • platform/chromium-win/svg/text/select-textLength-spacingAndGlyphs-stretch-3-expected.checksum:
  • platform/chromium-win/svg/text/select-textLength-spacingAndGlyphs-stretch-3-expected.png:
  • platform/chromium-win/svg/text/select-textLength-spacingAndGlyphs-stretch-3-expected.txt:
  • platform/chromium-win/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.checksum:
  • platform/chromium-win/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.png:
  • platform/chromium-win/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.txt:
  • platform/chromium-win/svg/text/select-x-list-1-expected.checksum:
  • platform/chromium-win/svg/text/select-x-list-1-expected.png:
  • platform/chromium-win/svg/text/select-x-list-1-expected.txt:
  • platform/chromium-win/svg/text/select-x-list-2-expected.checksum:
  • platform/chromium-win/svg/text/select-x-list-2-expected.png:
  • platform/chromium-win/svg/text/select-x-list-2-expected.txt:
  • platform/chromium-win/svg/text/select-x-list-3-expected.checksum:
  • platform/chromium-win/svg/text/select-x-list-3-expected.png:
  • platform/chromium-win/svg/text/select-x-list-3-expected.txt:
  • platform/chromium-win/svg/text/select-x-list-4-expected.checksum:
  • platform/chromium-win/svg/text/select-x-list-4-expected.png:
  • platform/chromium-win/svg/text/select-x-list-4-expected.txt:
  • platform/chromium-win/svg/text/select-x-list-with-tspans-1-expected.checksum:
  • platform/chromium-win/svg/text/select-x-list-with-tspans-1-expected.png:
  • platform/chromium-win/svg/text/select-x-list-with-tspans-1-expected.txt:
  • platform/chromium-win/svg/text/select-x-list-with-tspans-2-expected.checksum:
  • platform/chromium-win/svg/text/select-x-list-with-tspans-2-expected.png:
  • platform/chromium-win/svg/text/select-x-list-with-tspans-2-expected.txt:
  • platform/chromium-win/svg/text/select-x-list-with-tspans-3-expected.checksum:
  • platform/chromium-win/svg/text/select-x-list-with-tspans-3-expected.png:
  • platform/chromium-win/svg/text/select-x-list-with-tspans-3-expected.txt:
  • platform/chromium-win/svg/text/select-x-list-with-tspans-4-expected.checksum:
  • platform/chromium-win/svg/text/select-x-list-with-tspans-4-expected.png:
  • platform/chromium-win/svg/text/select-x-list-with-tspans-4-expected.txt:
  • platform/chromium-win/svg/text/text-align-01-b-expected.txt:
  • platform/chromium-win/svg/text/text-align-02-b-expected.checksum:
  • platform/chromium-win/svg/text/text-align-02-b-expected.png:
  • platform/chromium-win/svg/text/text-align-02-b-expected.txt:
  • platform/chromium-win/svg/text/text-align-03-b-expected.txt:
  • platform/chromium-win/svg/text/text-align-04-b-expected.checksum:
  • platform/chromium-win/svg/text/text-align-04-b-expected.png:
  • platform/chromium-win/svg/text/text-align-04-b-expected.txt:
  • platform/chromium-win/svg/text/text-align-05-b-expected.checksum:
  • platform/chromium-win/svg/text/text-align-05-b-expected.png:
  • platform/chromium-win/svg/text/text-align-05-b-expected.txt:
  • platform/chromium-win/svg/text/text-align-06-b-expected.checksum:
  • platform/chromium-win/svg/text/text-align-06-b-expected.png:
  • platform/chromium-win/svg/text/text-align-06-b-expected.txt:
  • platform/chromium-win/svg/text/text-altglyph-01-b-expected.txt:
  • platform/chromium-win/svg/text/text-deco-01-b-expected.checksum:
  • platform/chromium-win/svg/text/text-deco-01-b-expected.png:
  • platform/chromium-win/svg/text/text-deco-01-b-expected.txt:
  • platform/chromium-win/svg/text/text-fonts-01-t-expected.txt:
  • platform/chromium-win/svg/text/text-fonts-02-t-expected.txt:
  • platform/chromium-win/svg/text/text-gradient-positioning-expected.txt:
  • platform/chromium-win/svg/text/text-hkern-expected.checksum:
  • platform/chromium-win/svg/text/text-hkern-expected.png:
  • platform/chromium-win/svg/text/text-intro-05-t-expected.txt: Added.
  • platform/chromium-win/svg/text/text-path-01-b-expected.checksum:
  • platform/chromium-win/svg/text/text-path-01-b-expected.png:
  • platform/chromium-win/svg/text/text-path-01-b-expected.txt:
  • platform/chromium-win/svg/text/text-repaint-rects-expected.txt:
  • platform/chromium-win/svg/text/text-spacing-01-b-expected.checksum:
  • platform/chromium-win/svg/text/text-spacing-01-b-expected.png:
  • platform/chromium-win/svg/text/text-spacing-01-b-expected.txt:
  • platform/chromium-win/svg/text/text-text-01-b-expected.checksum:
  • platform/chromium-win/svg/text/text-text-01-b-expected.png:
  • platform/chromium-win/svg/text/text-text-01-b-expected.txt:
  • platform/chromium-win/svg/text/text-text-03-b-expected.txt:
  • platform/chromium-win/svg/text/text-text-04-t-expected.checksum:
  • platform/chromium-win/svg/text/text-text-04-t-expected.png:
  • platform/chromium-win/svg/text/text-text-04-t-expected.txt:
  • platform/chromium-win/svg/text/text-text-05-t-expected.checksum:
  • platform/chromium-win/svg/text/text-text-05-t-expected.png:
  • platform/chromium-win/svg/text/text-text-05-t-expected.txt:
  • platform/chromium-win/svg/text/text-text-06-t-expected.txt:
  • platform/chromium-win/svg/text/text-text-07-t-expected.checksum:
  • platform/chromium-win/svg/text/text-text-07-t-expected.png:
  • platform/chromium-win/svg/text/text-text-07-t-expected.txt:
  • platform/chromium-win/svg/text/text-text-08-b-expected.checksum:
  • platform/chromium-win/svg/text/text-text-08-b-expected.png:
  • platform/chromium-win/svg/text/text-text-08-b-expected.txt:
  • platform/chromium-win/svg/text/text-tref-01-b-expected.txt:
  • platform/chromium-win/svg/text/text-tselect-01-b-expected.txt:
  • platform/chromium-win/svg/text/text-tselect-02-f-expected.txt:
  • platform/chromium-win/svg/text/text-tspan-01-b-expected.txt:
  • platform/chromium-win/svg/text/text-vkern-expected.checksum:
  • platform/chromium-win/svg/text/text-vkern-expected.png:
  • platform/chromium-win/svg/text/text-ws-01-t-expected.txt:
  • platform/chromium-win/svg/text/text-ws-02-t-expected.txt:
  • platform/chromium-win/svg/text/textPathBoundsBug-expected.txt:
  • platform/chromium/test_expectations.txt:
2:06 PM Changeset in webkit [69034] by steveblock@google.com
  • 2 edits in trunk/WebCore

2010-10-04 Huahui Wu <mediadependent@gmail.com>

Reviewed by Darin Adler.

Fix a compiler error for ANDROID introduced by bug 45221.
https://bugs.webkit.org/show_bug.cgi?id=47095

It's a small fix for a compiler error, so there is no new test.

  • platform/android/PlatformTouchEventAndroid.cpp: (WebCore::PlatformTouchEvent::PlatformTouchEvent):
2:03 PM Changeset in webkit [69033] by Chris Fleizach
  • 7 edits
    2 adds in trunk

AX: doAXRangeForLine does not work
https://bugs.webkit.org/show_bug.cgi?id=47101

Reviewed by Beth Dakin.

WebCore:

Asking for NSAccessibilityRangeForLine was returning a null range for any line number > 0.
The code was using a SelectionController to extend to the next line. Rather than change the implementation
of that core functionality, it is cleaner to use endOfLine to find the end of the line.

Test: platform/mac/accessibility/range-for-line-textarea.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::doAXRangeForLine):

WebKitTools:

DRT support to handle NSAccessibilityRangeForLineParameterizedAttribute.

  • DumpRenderTree/AccessibilityUIElement.cpp:

(rangeForLineCallback):
(AccessibilityUIElement::rangeForLine):
(AccessibilityUIElement::getJSClass):

  • DumpRenderTree/AccessibilityUIElement.h:
  • DumpRenderTree/mac/AccessibilityUIElementMac.mm:

(AccessibilityUIElement::rangeForLine):

LayoutTests:

  • platform/mac/accessibility/range-for-line-textarea-expected.txt: Added.
  • platform/mac/accessibility/range-for-line-textarea.html: Added.
1:44 PM Changeset in webkit [69032] by inferno@chromium.org
  • 4 edits
    2 copies in branches/chromium/517

Merge 68096

BUG=56451
Review URL: http://codereview.chromium.org/3565007

1:44 PM Changeset in webkit [69031] by bfulgham@webkit.org
  • 5 edits
    1 add in trunk

WebCore: Unreviewed, build fix for r68951.

Add stub implementation for ProxyServer logic.

  • WebCore.vcproj/WebCore.vcproj: Add new WinCairo file.
  • WebCore/platform/network/curl/ProxyServerCurl.cpp: Added

WebKit2: Unreviewed build fixes after r68260 and r68686.

  • Platform/CoreIPC/DataReference.h: Add include directive for

<inttypes.h>, needed for WinCairo build.

  • Shared/win/PlatformCertificateInfo.cpp:

(WebKit::PlatformCertificateInfo::PlatformCertificateInfo):
Conditionalize logic specific to WebKitSystemInterface and
add a stub implementation for WinCairo.

1:35 PM Changeset in webkit [69030] by inferno@chromium.org
  • 1 edit
    2 copies in branches/chromium/517

Merge 68860

BUG=56144
Review URL: http://codereview.chromium.org/3621005

1:06 PM Changeset in webkit [69029] by weinig@apple.com
  • 16 edits
    1 add
    1 delete in trunk/WebKit2

Generate messages sent to the WebProcess class.
https://bugs.webkit.org/show_bug.cgi?id=47097

Reviewed by Adam Roben.

  • DerivedSources.make:

Add new file to generate and new directory to search.

  • Scripts/webkit2/messages.py:

(forward_declarations_and_headers): Special case class templates.
(headers_for_type): Special case Vector.

  • Scripts/webkit2/messages_unittest.py:

Make this script work for passing a templated type.

  • Shared/CoreIPCSupport/WebProcessMessageKinds.h: Removed.
  • UIProcess/VisitedLinkProvider.cpp:

(WebKit::VisitedLinkProvider::pendingVisitedLinksTimerFired):

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::initializeHistoryClient):
(WebKit::WebContext::ensureWebProcess):
(WebKit::WebContext::registerURLSchemeAsEmptyDocument):
(WebKit::WebContext::setCacheModel):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::initializeWebPage):
(WebKit::WebPageProxy::reinitializeWebPage):

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::WebProcessProxy): Always pass both
the bundle path and a key, even if the key is null, which it will be for
all non-mac builds for now.

  • UIProcess/mac/WebProcessProxyMac.mm:

(WebKit::WebProcessProxy::setUpAcceleratedCompositing):

  • UIProcess/win/WebContextWin.cpp:

(WebKit::WebContext::setShouldPaintNativeControls):
(WebKit::WebContext::platformSetUpWebProcess):
Use the new syntax for sending the messages.

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::setShouldTrackVisitedLinks):
(WebKit::WebProcess::setCacheModel):
(WebKit::WebProcess::setupAcceleratedCompositingPort):
(WebKit::WebProcess::setShouldPaintNativeControls):
(WebKit::WebProcess::didReceiveMessage):

  • WebProcess/WebProcess.h:

Convert to using generated didReceiveWebProcessMessage.

  • WebProcess/WebProcess.messages.in: Added.
  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:

Update projects.

1:06 PM Changeset in webkit [69028] by inferno@chromium.org
  • 1 edit in branches/chromium/517/WebCore/dom/Text.cpp

Merge 68705

BUG=57347
Review URL: http://codereview.chromium.org/3599013

1:01 PM Changeset in webkit [69027] by inferno@chromium.org
  • 5 edits
    3 copies in branches/chromium/517

Merge 68446 - WebCore: ImageDecoderSkia.cpp needs to check for allocator failure when copying
bitmaps.
https://bugs.webkit.org/show_bug.cgi?id=46437

Reviewed by James Robinson.

  • manual-tests/large-size-image-crash.html: Added.
  • manual-tests/resources/large-size-image-crash.gif: Added.
  • platform/image-decoders/ImageDecoder.cpp:

(WebCore::RGBA32Buffer::copyBitmapData):

  • platform/image-decoders/ImageDecoder.h:
  • platform/image-decoders/gif/GIFImageDecoder.cpp:

(WebCore::GIFImageDecoder::initFrameBuffer):

  • platform/image-decoders/qt/RGBA32BufferQt.cpp:

(WebCore::RGBA32Buffer::copyBitmapData):

  • platform/image-decoders/skia/ImageDecoderSkia.cpp:

(WebCore::RGBA32Buffer::copyBitmapData):

LayoutTests: This resource should have been in r62399; without it the test no-ops.
https://bugs.webkit.org/show_bug.cgi?id=41487

Reviewed by James Robinson.

  • fast/images/resources/large-size-image-crash.jpeg: Added.

BUG=54500

Review URL: http://codereview.chromium.org/3573008

12:48 PM Changeset in webkit [69026] by ap@apple.com
  • 16 edits
    10 adds in trunk

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=47035
Application cache selection algorithm should only be invoked after navigation

Tests: http/tests/appcache/document-write-html-element-2.html

http/tests/appcache/document-write-html-element.html
http/tests/appcache/insert-html-element-with-manifest-2.html
http/tests/appcache/insert-html-element-with-manifest.html

  • dom/DocumentParser.cpp: (WebCore::DocumentParser::DocumentParser):
  • dom/DocumentParser.h: (WebCore::DocumentParser::setDocumentWasLoadedAsPartOfNavigation): (WebCore::DocumentParser::documentWasLoadedAsPartOfNavigation): Track whether the document being parsed is being loaded as part of navigation.
  • html/HTMLHtmlElement.cpp: (WebCore::HTMLHtmlElement::insertedByParser): Only run the cache selection algorithm if the document is being loaded as part of navigation. We don't want to switch associated appcache is someone document.writes <html manifest=...>.
  • html/HTMLHtmlElement.h: We need to differentiate between parsing and DOM manipulation, so this code can't be in HTMLHtmlElement::insertedIntoDocument().
  • dom/XMLDocumentParserLibxml2.cpp: (WebCore::XMLDocumentParser::startElementNs):
  • dom/XMLDocumentParserQt.cpp: (WebCore::XMLDocumentParser::parseStartElement):
  • html/ImageDocument.cpp: (WebCore::ImageDocument::createDocumentStructure):
  • html/MediaDocument.cpp: (WebCore::MediaDocumentParser::createDocumentStructure):
  • html/PluginDocument.cpp: (WebCore::PluginDocumentParser::createDocumentStructure):
  • html/parser/HTMLConstructionSite.cpp: (WebCore::HTMLConstructionSite::insertHTMLHtmlStartTagBeforeHTML): Check for manifest attribute in cases specified by HTML5.
  • html/parser/HTMLConstructionSite.h: Removed unused insertHTMLHtmlElement().
  • loader/DocumentWriter.cpp: (WebCore::DocumentWriter::setDocumentWasLoadedAsPartOfNavigation):
  • loader/DocumentWriter.h: Forward this call to DocumentParser, since DocumentWriter is supposed to encapsulate it.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::receivedFirstData): Receiving data from loader means being loaded as part of navigation. This notion is used in HTML5 without a rigorous definition that I could find - this seems to be a meaningful formalization.
12:05 PM Changeset in webkit [69025] by hyatt@apple.com
  • 3 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=47100

Reviewed by Dan Bernstein.

Convert clearFloats() to be block-flow-aware. Helpers that it calls have not been patched though.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::clearFloats):

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::logicalTopForFloat):
(WebCore::RenderBlock::logicalLeftForFloat):
(WebCore::RenderBlock::logicalWidthForFloat):

12:04 PM Changeset in webkit [69024] by diegohcg@webkit.org
  • 5 edits
    1 copy
    1 add in trunk

[Qt] Hook up DeviceOrientation data for Qt support
https://bugs.webkit.org/show_bug.cgi?id=47052

Reviewed by Kenneth Rohde Christiansen.

Get DeviceOrientation necessary data via Qt mobility library
using a provider class.

WebCore:

  • WebCore.pro:

WebKit/qt:

  • WebCoreSupport/DeviceOrientationClientQt.cpp:

(WebCore::DeviceOrientationClientQt::DeviceOrientationClientQt):
(WebCore::DeviceOrientationClientQt::~DeviceOrientationClientQt):
(WebCore::DeviceOrientationClientQt::startUpdating):
(WebCore::DeviceOrientationClientQt::stopUpdating):
(WebCore::DeviceOrientationClientQt::lastOrientation):
(WebCore::DeviceOrientationClientQt::changeDeviceOrientation):

  • WebCoreSupport/DeviceOrientationClientQt.h:
  • WebCoreSupport/DeviceOrientationProviderQt.cpp: Added.

(WebCore::DeviceOrientationProviderQt::DeviceOrientationProviderQt):
(WebCore::DeviceOrientationProviderQt::~DeviceOrientationProviderQt):
(WebCore::DeviceOrientationProviderQt::start):
(WebCore::DeviceOrientationProviderQt::stop):
(WebCore::DeviceOrientationProviderQt::filter):

  • WebCoreSupport/DeviceOrientationProviderQt.h: Added.

(WebCore::DeviceOrientationProviderQt::isActive):
(WebCore::DeviceOrientationProviderQt::orientation):
(WebCore::DeviceOrientationProviderQt::hasAlpha):

11:45 AM Changeset in webkit [69023] by caseq@chromium.org
  • 2 edits in trunk/WebKitTools

2010-10-04 Andrey Kosyakov <caseq@chromium.org>

Unreviewed. Adding myself to the committers list.

  • Scripts/webkitpy/common/config/committers.py:
10:35 AM Changeset in webkit [69022] by hclam@chromium.org
  • 4 edits in trunk

Fixing crash when audio media player is destructed
https://bugs.webkit.org/show_bug.cgi?id=47020

Reviewed by James Robinson.

WebCore:

Adds assert for LayerRenderer in destructor.

  • platform/graphics/chromium/VideoLayerChromium.cpp:

(WebCore::VideoLayerChromium::~VideoLayerChromium):

WebKit/chromium:

Creates the VideoLayerChromium layer only if the media player contains
a video.

  • src/WebMediaPlayerClientImpl.cpp:

(WebKit::WebMediaPlayerClientImpl::readyStateChanged):
(WebKit::WebMediaPlayerClientImpl::create):

10:30 AM Changeset in webkit [69021] by weinig@apple.com
  • 2 edits in trunk/WebKit2

Fix the Mac build.

  • WebProcess/mac/WebProcessMac.mm:
10:15 AM Changeset in webkit [69020] by weinig@apple.com
  • 14 edits
    4 adds in trunk

Add ability to set the CacheModel in Webkit2
https://bugs.webkit.org/show_bug.cgi?id=47066

Reviewed by Anders Carlsson.

WebKit2:

Add WKContext function to set the cache model for the context.

  • Shared/CacheModel.h: Added.
  • Shared/CoreIPCSupport/WebProcessMessageKinds.h:
  • UIProcess/API/C/WKAPICast.h:

(WebKit::toCacheModel):
(WebKit::toRef):

  • UIProcess/API/C/WKContext.cpp:

(WKContextSetCacheModel):
(WKContextGetCacheModel):

  • UIProcess/API/C/WKContext.h:
  • UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext):
(WebKit::WebContext::ensureWebProcess):
(WebKit::WebContext::setCacheModel):

  • UIProcess/WebContext.h:

(WebKit::WebContext::cacheModel):

  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::WebProcess):
(WebKit::WebProcess::setCacheModel):
(WebKit::WebProcess::didReceiveMessage):

  • WebProcess/WebProcess.h:
  • WebProcess/mac/WebProcessMac.mm: Added.

(WebKit::memorySize):
(WebKit::volumeFreeSize):
(WebKit::WebProcess::platformSetCacheModel):

  • WebProcess/qt/WebProcessQt.cpp: Added.

(WebKit::WebProcess::platformSetCacheModel):

  • WebProcess/win/WebProcessWin.cpp: Added.

(WebKit::WebProcess::platformSetCacheModel):

  • win/WebKit2.vcproj:

WebKitTools:

  • MiniBrowser/mac/AppDelegate.m:

(-[BrowserAppDelegate init]): Opt minibrowser into
a PrimaryWebBrowser cache model.

10:00 AM Changeset in webkit [69019] by podivilov@chromium.org
  • 2 edits in trunk/WebCore

2010-10-04 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: do not show breakpoint in front-end if it was not set in v8
https://bugs.webkit.org/show_bug.cgi?id=46749

  • bindings/v8/DebuggerScript.js: ():
9:25 AM Changeset in webkit [69018] by alex
  • 2 edits in trunk/WebCore

2010-10-04 Alejandro G. Castro <alex@igalia.com>

Reviewed by Martin Robinson.

[cairo] Context shadow modifies the data of the surface without
flushing and marking as dirty
https://bugs.webkit.org/show_bug.cgi?id=47079

Added the cairo_surface_flush and cairo_surface_mark_dirty before
and after modifying the image pixels directly.

  • platform/graphics/cairo/ContextShadowCairo.cpp: (WebCore::ContextShadow::endShadowLayer):
9:00 AM Changeset in webkit [69017] by Adam Roben
  • 2 edits in trunk/LayoutTests

Skip a timing-out test on Windows

  • platform/win/Skipped: Added http/tests/misc/copy-resolves-urls.html,

which times out in Release builds.

8:48 AM Changeset in webkit [69016] by alex
  • 2 edits in trunk/WebCore

2010-10-04 Alejandro G. Castro <alex@igalia.com>

Reviewed by Xan Lopez.

Crashed caused by missing OwnPtrCairo include, for more
information check the issue in the bug 46268.

  • platform/graphics/cairo/CairoUtilities.cpp:
8:23 AM Changeset in webkit [69015] by alex
  • 5 edits in trunk/WebCore

2010-10-04 Alejandro G. Castro <alex@igalia.com>

Reviewed by Martin Robinson.

[cairo] Move some cairo functions to the CairoUtilities
https://bugs.webkit.org/show_bug.cgi?id=47076

Moved some cairo functions to the CairoUtilities so we can use
them outside GraphicsContextCairo.

  • platform/graphics/cairo/CairoUtilities.cpp: (WebCore::appendPathToCairoContext): (WebCore::setPathOnCairoContext): (WebCore::appendWebCorePathToCairoContext): (WebCore::toCairoOperator): (WebCore::drawPatternToCairoContext):
  • platform/graphics/cairo/CairoUtilities.h:
  • platform/graphics/cairo/GraphicsContextCairo.cpp:
  • platform/graphics/cairo/ImageCairo.cpp: (WebCore::Image::drawPattern):
7:52 AM Changeset in webkit [69014] by podivilov@chromium.org
  • 15 edits in trunk/WebCore

2010-10-04 podivilov@chromium.org <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: implement pausing on event listeners (back-end part)
https://bugs.webkit.org/show_bug.cgi?id=46624

  • bindings/js/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::setPauseOnNextStatement):
  • bindings/js/ScriptDebugServer.h:
  • bindings/v8/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::setPauseOnNextStatement):
  • bindings/v8/ScriptDebugServer.h:
  • dom/Node.cpp: (WebCore::Node::dispatchGenericEvent):
  • inspector/InspectorController.cpp: (WebCore::InspectorController::didCommitLoad): (WebCore::InspectorController::setNativeBreakpoint): (WebCore::InspectorController::removeNativeBreakpoint): (WebCore::InspectorController::shouldBreakOnEvent): (WebCore::InspectorController::shouldBreakOnXMLHttpRequest):
  • inspector/InspectorController.h:
  • inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::~InspectorDebuggerAgent): (WebCore::InspectorDebuggerAgent::schedulePauseOnNextStatement): (WebCore::InspectorDebuggerAgent::cancelPauseOnNextStatement): (WebCore::InspectorDebuggerAgent::pause): (WebCore::InspectorDebuggerAgent::didContinue): (WebCore::InspectorDebuggerAgent::breakProgram):
  • inspector/InspectorDebuggerAgent.h:
  • inspector/InspectorInstrumentation.cpp: (WebCore::eventHasListeners): (WebCore::InspectorInstrumentation::instrumentWillDispatchEventImpl): (WebCore::InspectorInstrumentation::instrumentDidDispatchEventImpl): (WebCore::InspectorInstrumentation::instrumentWillSendXMLHttpRequestImpl):
  • inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::instrumentWillDispatchEvent): (WebCore::InspectorInstrumentation::instrumentDidDispatchEvent): (WebCore::InspectorInstrumentation::instrumentWillSendXMLHttpRequest):
  • inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::InspectorTimelineAgent):
  • inspector/InspectorTimelineAgent.h: (WebCore::InspectorTimelineAgent::id):
  • inspector/front-end/CallStackSidebarPane.js:
7:28 AM Changeset in webkit [69013] by Adam Roben
  • 2 edits in trunk/LayoutTests

Skip a flaky SVG test on Windows

  • platform/win/Skipped: Added

svg/dom/SVGScriptElement/script-load-and-error-events.svg

7:25 AM Changeset in webkit [69012] by Adam Roben
  • 2 edits in trunk/LayoutTests

Skip http/tests/xmlhttprequest/xmlhttprequest-sync-vs-async-assertion-failure.html on Windows

It seems to be causing other tests to time out, like
http/tests/xmlhttprequest/xmlhttprequest-test-send-flag.html.

  • platform/win/Skipped:
6:48 AM Changeset in webkit [69011] by Adam Roben
  • 1 edit
    1 add in trunk/LayoutTests

Land XP-specific results for fast/text/international/bidi-mirror-he-ar.html

In r69008 I updated the post-XP results, but forgot to check in the
XP-specific results.

  • platform/win-xp/fast/text/international/bidi-mirror-he-ar-expected.txt: Added.
6:42 AM Changeset in webkit [69010] by pfeldman@chromium.org
  • 8 edits in trunk/WebCore

2010-10-04 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: add total bar to the network panel.
https://bugs.webkit.org/show_bug.cgi?id=47081

  • English.lproj/localizedStrings.js:
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.createDividerElement):
  • inspector/front-end/DataGrid.js: (WebInspector.DataGrid.prototype.removeChild): (WebInspector.DataGrid.prototype.sortNodes): (WebInspector.DataGrid.prototype._clickInHeaderCell): (WebInspector.DataGrid.prototype.markColumnAsSortedBy):
  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel): (WebInspector.NetworkPanel.prototype.resize): (WebInspector.NetworkPanel.prototype._positionSummaryBar): (WebInspector.NetworkPanel.prototype._createTimelineGrid): (WebInspector.NetworkPanel.prototype._createSortingFunctions): (WebInspector.NetworkPanel.prototype._sortItems): (WebInspector.NetworkPanel.prototype._sortByTimeline): (WebInspector.NetworkPanel.prototype._createFilterStatusBarItems): (WebInspector.NetworkPanel.prototype._createSummaryBar): (WebInspector.NetworkPanel.prototype._updateSummaryBar): (WebInspector.NetworkPanel.prototype._updateFilter): (WebInspector.NetworkPanel.prototype.show): (WebInspector.NetworkPanel.prototype.refresh): (WebInspector.NetworkPanel.prototype.reset): (WebInspector.NetworkDataGridNode.SizeComparator): (WebInspector.NetworkDataGridNode.ResourcePropertyComparator): (WebInspector.NetworkTotalGridNode): (WebInspector.NetworkTotalGridNode.prototype.createCells):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.createFilterPanel):
  • inspector/front-end/inspector.css: (.scope-bar-divider):
  • inspector/front-end/networkPanel.css: (.network-timeline-grid): (.network-summary-bar): (.network-summary-bar-bottom): (.data-grid td .network-summary-bar):
6:17 AM Changeset in webkit [69009] by luiz@webkit.org
  • 18 edits in trunk

2010-09-28 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

Viewport data change notifications
https://bugs.webkit.org/show_bug.cgi?id=46755

Regarding viewport meta tags, what matters for browser developers is to know when the viewport data has
changed and its current value. Viewport data belongs to the document, but it is useful to keep the current
viewport data in Page as a reference, to be able to send notifications only when the current viewport
has changed.

  • dom/Document.cpp: (WebCore::Document::processViewport): (WebCore::Document::setInPageCache):
  • dom/ViewportArguments.h: (WebCore::ViewportArguments::operator==):
  • html/HTMLBodyElement.cpp: (WebCore::HTMLBodyElement::HTMLBodyElement):
  • page/Chrome.cpp: (WebCore::Chrome::viewportDataChanged):
  • page/Chrome.h:
  • page/ChromeClient.h: (WebCore::ChromeClient::viewportDataChanged):
  • page/Page.cpp: (WebCore::Page::updateViewportArguments):
  • page/Page.h: (WebCore::Page::viewportArguments):

2010-09-28 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

Viewport data change notifications
https://bugs.webkit.org/show_bug.cgi?id=46755

Regarding viewport meta tags, what matters for browser developers is to know when the viewport data has
changed and its current value. Viewport data belongs to the document, but it is useful to keep the current
viewport data in Page as a reference, to be able to send notifications only when the current viewport
has changed.

  • Api/qwebframe.cpp:
  • Api/qwebframe_p.h:
  • Api/qwebpage.cpp: (QWebPagePrivate::viewportArguments): (QWebPage::viewportConfigurationForSize):
  • Api/qwebpage_p.h:
  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::viewportDataChanged):
  • WebCoreSupport/ChromeClientQt.h:
  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::viewportAsText):
5:39 AM Changeset in webkit [69008] by Adam Roben
  • 2 edits in trunk/LayoutTests

Land correct post-XP results for fast/text/international/bidi-mirror-he-ar.html

Apparently the results I landed earlier weren't quite right.

  • platform/win/fast/text/international/bidi-mirror-he-ar-expected.txt:
4:20 AM Changeset in webkit [69007] by podivilov@chromium.org
  • 2 edits in trunk/LayoutTests

2010-10-04 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, test expectation update.

[Chromium] Mark debugger-breakpoints-not-activated-on-reload.html as slow on win debug

  • platform/chromium/test_expectations.txt:
3:44 AM WebKit Team edited by kim.1.gronholm@nokia.com
(diff)
3:26 AM Changeset in webkit [69006] by tkent@chromium.org
  • 6 edits in trunk/LayoutTests

2010-10-04 Kent Tamura <tkent@chromium.org>

Unreviewed, test expectation update.

Fix incorrect rebaseline of verticalText.svg by r69004.

  • move chromium-win image baseline to chromium-win-xp
  • revert chromium-win image baseline
  • platform/chromium-win-xp/svg/batik/text/verticalText-expected.checksum:
  • platform/chromium-win-xp/svg/batik/text/verticalText-expected.png:
  • platform/chromium-win/svg/batik/text/verticalText-expected.checksum:
  • platform/chromium-win/svg/batik/text/verticalText-expected.png:
  • platform/chromium/test_expectations.txt:
2:34 AM Changeset in webkit [69005] by tkent@chromium.org
  • 48 edits
    25 copies
    5 deletes in trunk/LayoutTests

Unreviewed, test expectation update.

Update SVG baseline for Chromium.

  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-03-t-expected.txt:
  • platform/chromium-linux/svg/W3C-SVG-1.1/masking-opacity-01-b-expected.txt: Added.
  • platform/chromium-linux/svg/batik/text/textLength-expected.txt: Added.
  • platform/chromium-linux/svg/carto.net/button-expected.txt: Added.
  • platform/chromium-linux/svg/carto.net/colourpicker-expected.txt: Added.
  • platform/chromium-linux/svg/carto.net/combobox-expected.txt: Added.
  • platform/chromium-linux/svg/carto.net/selectionlist-expected.checksum:
  • platform/chromium-linux/svg/carto.net/selectionlist-expected.png:
  • platform/chromium-linux/svg/carto.net/selectionlist-expected.txt: Added.
  • platform/chromium-linux/svg/carto.net/textbox-expected.txt: Added.
  • platform/chromium-linux/svg/carto.net/window-expected.txt:
  • platform/chromium-linux/svg/clip-path/clip-path-text-and-shape-expected.txt: Added.
  • platform/chromium-linux/svg/clip-path/clip-path-text-and-stroke-expected.txt: Added.
  • platform/chromium-linux/svg/clip-path/clip-path-text-expected.txt: Added.
  • platform/chromium-linux/svg/clip-path/clip-path-with-text-clipped-expected.txt: Added.
  • platform/chromium-linux/svg/css/composite-shadow-text-expected.txt: Added.
  • platform/chromium-linux/svg/css/shadow-changes-expected.txt: Added.
  • platform/chromium-linux/svg/css/text-shadow-multiple-expected.txt: Added.
  • platform/chromium-linux/svg/custom/use-detach-expected.txt: Added.
  • platform/chromium-linux/svg/filters/filter-on-filter-for-text-expected.txt: Added.
  • platform/chromium-linux/svg/filters/filter-on-tspan-expected.txt: Copied from LayoutTests/platform/gtk/svg/filters/filter-on-tspan-expected.txt.
  • platform/chromium-linux/svg/filters/sourceAlpha-expected.checksum:
  • platform/chromium-linux/svg/filters/sourceAlpha-expected.png: Removed.
  • platform/chromium-linux/svg/filters/sourceAlpha-expected.txt: Added.
  • platform/chromium-linux/svg/hixie/error/017-expected.txt: Added.
  • platform/chromium-linux/svg/hixie/text/002-expected.txt: Added.
  • platform/chromium-linux/svg/hixie/text/003b-expected.txt:
  • platform/chromium-linux/svg/transforms/text-with-pattern-inside-transformed-html-expected.checksum:
  • platform/chromium-linux/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
  • platform/chromium-linux/svg/transforms/text-with-pattern-inside-transformed-html-expected.txt: Added.
  • platform/chromium-linux/svg/transforms/text-with-pattern-with-svg-transform-expected.checksum:
  • platform/chromium-linux/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
  • platform/chromium-linux/svg/transforms/text-with-pattern-with-svg-transform-expected.txt: Added.
  • platform/chromium-linux/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt: Added.
  • platform/chromium-linux/svg/zoom/text/zoom-coords-viewattr-01-b-expected.txt: Added.
  • platform/chromium-linux/transitions/svg-text-shadow-transition-expected.txt: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-03-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/masking-opacity-01-b-expected.txt:
  • platform/chromium-win/svg/batik/text/textLength-expected.txt:
  • platform/chromium-win/svg/carto.net/button-expected.txt:
  • platform/chromium-win/svg/carto.net/colourpicker-expected.txt:
  • platform/chromium-win/svg/carto.net/combobox-expected.txt:
  • platform/chromium-win/svg/carto.net/selectionlist-expected.checksum:
  • platform/chromium-win/svg/carto.net/selectionlist-expected.png:
  • platform/chromium-win/svg/carto.net/selectionlist-expected.txt:
  • platform/chromium-win/svg/carto.net/textbox-expected.txt:
  • platform/chromium-win/svg/carto.net/window-expected.txt:
  • platform/chromium-win/svg/clip-path/clip-path-text-and-shape-expected.txt:
  • platform/chromium-win/svg/clip-path/clip-path-text-and-stroke-expected.txt:
  • platform/chromium-win/svg/clip-path/clip-path-text-expected.txt:
  • platform/chromium-win/svg/clip-path/clip-path-with-text-clipped-expected.txt:
  • platform/chromium-win/svg/css/composite-shadow-text-expected.txt:
  • platform/chromium-win/svg/css/shadow-changes-expected.txt:
  • platform/chromium-win/svg/css/text-shadow-multiple-expected.txt:
  • platform/chromium-win/svg/custom/use-detach-expected.txt:
  • platform/chromium-win/svg/filters/filter-on-filter-for-text-expected.txt:
  • platform/chromium-win/svg/filters/filter-on-tspan-expected.txt:
  • platform/chromium-win/svg/filters/sourceAlpha-expected.checksum:
  • platform/chromium-win/svg/filters/sourceAlpha-expected.png:
  • platform/chromium-win/svg/filters/sourceAlpha-expected.txt:
  • platform/chromium-win/svg/hixie/error/017-expected.txt:
  • platform/chromium-win/svg/hixie/text/002-expected.txt:
  • platform/chromium-win/svg/hixie/text/003b-expected.txt:
  • platform/chromium-win/svg/transforms/text-with-pattern-inside-transformed-html-expected.checksum:
  • platform/chromium-win/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
  • platform/chromium-win/svg/transforms/text-with-pattern-inside-transformed-html-expected.txt:
  • platform/chromium-win/svg/transforms/text-with-pattern-with-svg-transform-expected.checksum:
  • platform/chromium-win/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
  • platform/chromium-win/svg/transforms/text-with-pattern-with-svg-transform-expected.txt:
  • platform/chromium-win/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt:
  • platform/chromium-win/svg/zoom/text/zoom-coords-viewattr-01-b-expected.txt:
  • platform/chromium-win/transitions/svg-text-shadow-transition-expected.txt:
  • platform/chromium/test_expectations.txt:
2:14 AM Changeset in webkit [69004] by tkent@chromium.org
  • 79 edits
    13 copies
    8 adds in trunk/LayoutTests

2010-10-04 Kent Tamura <tkent@chromium.org>

Unreviewed, test expectation update.

Update svg/batik results for Chromium.

  • platform/chromium-linux/svg/batik/text/longTextOnPath-expected.txt: Added.
  • platform/chromium-linux/svg/batik/text/textAnchor-expected.txt: Added.
  • platform/chromium-linux/svg/batik/text/textAnchor2-expected.checksum:
  • platform/chromium-linux/svg/batik/text/textAnchor2-expected.png:
  • platform/chromium-linux/svg/batik/text/textAnchor2-expected.txt: Added.
  • platform/chromium-linux/svg/batik/text/textAnchor3-expected.txt: Added.
  • platform/chromium-linux/svg/batik/text/textDecoration-expected.checksum:
  • platform/chromium-linux/svg/batik/text/textDecoration-expected.png:
  • platform/chromium-linux/svg/batik/text/textDecoration-expected.txt: Added.
  • platform/chromium-linux/svg/batik/text/textDecoration2-expected.checksum:
  • platform/chromium-linux/svg/batik/text/textDecoration2-expected.png:
  • platform/chromium-linux/svg/batik/text/textDecoration2-expected.txt: Added.
  • platform/chromium-linux/svg/batik/text/textEffect-expected.checksum:
  • platform/chromium-linux/svg/batik/text/textEffect-expected.png:
  • platform/chromium-linux/svg/batik/text/textEffect-expected.txt: Added.
  • platform/chromium-linux/svg/batik/text/textEffect2-expected.txt: Added.
  • platform/chromium-linux/svg/batik/text/textEffect3-expected.checksum:
  • platform/chromium-linux/svg/batik/text/textEffect3-expected.png:
  • platform/chromium-linux/svg/batik/text/textEffect3-expected.txt: Added.
  • platform/chromium-linux/svg/batik/text/textFeatures-expected.txt: Added.
  • platform/chromium-linux/svg/batik/text/textGlyphOrientationHorizontal-expected.checksum:
  • platform/chromium-linux/svg/batik/text/textGlyphOrientationHorizontal-expected.png:
  • platform/chromium-linux/svg/batik/text/textGlyphOrientationHorizontal-expected.txt: Added.
  • platform/chromium-linux/svg/batik/text/textLayout-expected.txt: Added.
  • platform/chromium-linux/svg/batik/text/textLayout2-expected.checksum:
  • platform/chromium-linux/svg/batik/text/textLayout2-expected.png:
  • platform/chromium-linux/svg/batik/text/textLayout2-expected.txt: Added.
  • platform/chromium-linux/svg/batik/text/textOnPath-expected.checksum:
  • platform/chromium-linux/svg/batik/text/textOnPath-expected.png:
  • platform/chromium-linux/svg/batik/text/textOnPath-expected.txt:
  • platform/chromium-linux/svg/batik/text/textOnPath2-expected.txt: Added.
  • platform/chromium-linux/svg/batik/text/textOnPath3-expected.txt: Added.
  • platform/chromium-linux/svg/batik/text/textOnPathSpaces-expected.txt: Added.
  • platform/chromium-linux/svg/batik/text/textPCDATA-expected.txt: Added.
  • platform/chromium-linux/svg/batik/text/textPosition-expected.txt:
  • platform/chromium-linux/svg/batik/text/textPosition2-expected.txt:
  • platform/chromium-linux/svg/batik/text/textProperties-expected.checksum:
  • platform/chromium-linux/svg/batik/text/textProperties-expected.png:
  • platform/chromium-linux/svg/batik/text/textProperties-expected.txt: Added.
  • platform/chromium-linux/svg/batik/text/textProperties2-expected.txt: Added.
  • platform/chromium-linux/svg/batik/text/verticalText-expected.checksum:
  • platform/chromium-linux/svg/batik/text/verticalText-expected.png:
  • platform/chromium-linux/svg/batik/text/verticalText-expected.txt: Added.
  • platform/chromium-linux/svg/batik/text/verticalTextOnPath-expected.checksum:
  • platform/chromium-linux/svg/batik/text/verticalTextOnPath-expected.png:
  • platform/chromium-linux/svg/batik/text/verticalTextOnPath-expected.txt:
  • platform/chromium-linux/svg/batik/text/xmlSpace-expected.checksum:
  • platform/chromium-linux/svg/batik/text/xmlSpace-expected.png:
  • platform/chromium-linux/svg/batik/text/xmlSpace-expected.txt: Added.
  • platform/chromium-win/svg/batik/text/longTextOnPath-expected.txt:
  • platform/chromium-win/svg/batik/text/textAnchor-expected.txt:
  • platform/chromium-win/svg/batik/text/textAnchor2-expected.checksum:
  • platform/chromium-win/svg/batik/text/textAnchor2-expected.png:
  • platform/chromium-win/svg/batik/text/textAnchor2-expected.txt:
  • platform/chromium-win/svg/batik/text/textAnchor3-expected.txt:
  • platform/chromium-win/svg/batik/text/textDecoration-expected.checksum:
  • platform/chromium-win/svg/batik/text/textDecoration-expected.png:
  • platform/chromium-win/svg/batik/text/textDecoration-expected.txt:
  • platform/chromium-win/svg/batik/text/textDecoration2-expected.checksum:
  • platform/chromium-win/svg/batik/text/textDecoration2-expected.png:
  • platform/chromium-win/svg/batik/text/textDecoration2-expected.txt:
  • platform/chromium-win/svg/batik/text/textEffect-expected.checksum:
  • platform/chromium-win/svg/batik/text/textEffect-expected.png:
  • platform/chromium-win/svg/batik/text/textEffect-expected.txt:
  • platform/chromium-win/svg/batik/text/textEffect2-expected.txt:
  • platform/chromium-win/svg/batik/text/textEffect3-expected.checksum:
  • platform/chromium-win/svg/batik/text/textEffect3-expected.png:
  • platform/chromium-win/svg/batik/text/textEffect3-expected.txt:
  • platform/chromium-win/svg/batik/text/textFeatures-expected.txt:
  • platform/chromium-win/svg/batik/text/textGlyphOrientationHorizontal-expected.checksum:
  • platform/chromium-win/svg/batik/text/textGlyphOrientationHorizontal-expected.png:
  • platform/chromium-win/svg/batik/text/textGlyphOrientationHorizontal-expected.txt:
  • platform/chromium-win/svg/batik/text/textLayout-expected.txt:
  • platform/chromium-win/svg/batik/text/textLayout2-expected.checksum:
  • platform/chromium-win/svg/batik/text/textLayout2-expected.png:
  • platform/chromium-win/svg/batik/text/textLayout2-expected.txt:
  • platform/chromium-win/svg/batik/text/textOnPath-expected.checksum:
  • platform/chromium-win/svg/batik/text/textOnPath-expected.png:
  • platform/chromium-win/svg/batik/text/textOnPath-expected.txt:
  • platform/chromium-win/svg/batik/text/textOnPath2-expected.txt:
  • platform/chromium-win/svg/batik/text/textOnPath3-expected.txt:
  • platform/chromium-win/svg/batik/text/textOnPathSpaces-expected.txt:
  • platform/chromium-win/svg/batik/text/textPCDATA-expected.txt:
  • platform/chromium-win/svg/batik/text/textPosition-expected.txt:
  • platform/chromium-win/svg/batik/text/textPosition2-expected.txt:
  • platform/chromium-win/svg/batik/text/textProperties-expected.checksum:
  • platform/chromium-win/svg/batik/text/textProperties-expected.png:
  • platform/chromium-win/svg/batik/text/textProperties-expected.txt:
  • platform/chromium-win/svg/batik/text/textProperties2-expected.txt:
  • platform/chromium-win/svg/batik/text/verticalText-expected.checksum:
  • platform/chromium-win/svg/batik/text/verticalText-expected.png:
  • platform/chromium-win/svg/batik/text/verticalText-expected.txt:
  • platform/chromium-win/svg/batik/text/verticalTextOnPath-expected.checksum:
  • platform/chromium-win/svg/batik/text/verticalTextOnPath-expected.png:
  • platform/chromium-win/svg/batik/text/verticalTextOnPath-expected.txt:
  • platform/chromium-win/svg/batik/text/xmlSpace-expected.checksum:
  • platform/chromium-win/svg/batik/text/xmlSpace-expected.png:
  • platform/chromium-win/svg/batik/text/xmlSpace-expected.txt:
  • platform/chromium/test_expectations.txt:
1:09 AM Changeset in webkit [69003] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

[Qt] Fix platform plugin support after r68128

Rubber-stamped by Tor Arne Vestbø.

Replaced the qobject_cast from the QObject derived extension to a
static_cast. qobject_cast works by comparing pointers to meta-object
instances, of which there are two each: one compiled into WebKit and
one compiled into the plugin.

The platform plugin ensures the validity of the interface contract
through its version and the initial safe qobject_cast from QObject
to QWebKitPlatformPlugin. After that it is safe to use static_cast,
and with the recent changes even required.

  • WebCoreSupport/QtPlatformPlugin.cpp:

(WebCore::QtPlatformPlugin::createSelectInputMethod):
(WebCore::QtPlatformPlugin::createNotificationPresenter):
(WebCore::QtPlatformPlugin::createHapticFeedbackPlayer):

12:02 AM Changeset in webkit [69002] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

2010-10-04 Kent Tamura <tkent@chromium.org>

Unreviewed, test expectation update.

  • platform/chromium/test_expectations.txt:

Oct 3, 2010:

11:22 PM Changeset in webkit [69001] by Simon Fraser
  • 2 edits in trunk/WebKitTools

2010-10-03 Simon Fraser <Simon Fraser>

Make sure to enter all tests when creating the database
for the first time.

When migrating to a new version of the suite, be sure to
sync up the database and testinfo.data by removing old
tests, and inserting new ones.

  • CSSTestSuiteHarness/harness/harness.js: (TestSuite.prototype.openDatabase.creation): (TestSuite.prototype.databaseCreated): (TestSuite.prototype.populateDatabaseFromTestInfoData): (TestSuite.prototype.insertTest):
11:22 PM Changeset in webkit [69000] by Simon Fraser
  • 2 edits in trunk/WebKitTools

2010-10-03 Simon Fraser <Simon Fraser>

More work on treating HTML4 and XHTML1 independently; when
changing the format, rebuild the test list, and update the
numbers in the chapter popup.

  • CSSTestSuiteHarness/harness/harness.js: (Test): (Test.prototype.runForFormat): (Test.prototype.completedForFormat): (ChapterSection): (ChapterSection.prototype.countTests): (Chapter): (Chapter.prototype.description): (Chapter.prototype.countTests): (Chapter.prototype.testCount): (Chapter.prototype.untestedCount): (TestSuite.prototype.buildChapters): (TestSuite.prototype.loadCurrentTest): (TestSuite.prototype.updateProgressLabel): (TestSuite.prototype.processFlags): (TestSuite.prototype.formatChanged):
11:21 PM Changeset in webkit [68999] by Simon Fraser
  • 2 edits in trunk/WebKitTools

2010-10-03 Simon Fraser <Simon Fraser>

Update test suite version 20101001.

Handle database migration, and delete tests from the db that are
not present in testinfo.data.

Load about:blank into the test frame before the test url, to make
missing tests more obvious.

  • CSSTestSuiteHarness/harness/harness.js: (TestSuite.prototype.loadTest): (TestSuite.prototype.openDatabase.creation): (TestSuite.prototype.openDatabase.migration1_0To1_1): (TestSuite.prototype.openDatabase.if.return): (TestSuite.prototype.databaseReady): (TestSuite.prototype.populateDatabaseFromTestInfoData): (TestSuite.prototype.syncDatabaseWithTestInfoData.this.db.transaction): (TestSuite.prototype.syncDatabaseWithTestInfoData):
11:20 PM Changeset in webkit [68998] by bfulgham@webkit.org
  • 2 edits in trunk/WebKitLibraries

Unreviewed build fix.

WinCairo also needs access to the <inttypes.h> header requirement
introduced by Bug 46357.

  • win/tools/vsprops/WinCairo.vsprops:
11:14 PM Changeset in webkit [68997] by tkent@chromium.org
  • 5 edits in trunk/WebCore

2010-10-03 Kent Tamura <tkent@chromium.org>

Unreviewed, build fix for r68996.

  • html/BaseDateAndTimeInputType.cpp: Includes <wtf/MathExtras.h> for isfinite().
  • html/MonthInputType.cpp: ditto.
  • html/NumberInputType.cpp: ditto.
  • html/RangeInputType.cpp: ditto.
10:59 PM Changeset in webkit [68996] by tkent@chromium.org
  • 28 edits
    2 copies in trunk/WebCore

2010-10-03 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

Refactor HTMLInputElement: Move parseToDouble() and
parseToDateComponents() to InputType.
https://bugs.webkit.org/show_bug.cgi?id=46965

Introduce BaseDateAndTimeInputType, which is a super class of
date, datetime, datetime-local, month, time, and week types.

No new tests. Just a refactoring.

  • Android.mk: Add BaseDateAndTimeInputType.
  • CMakeLists.txt: ditto.
  • GNUmakefile.am: ditto.
  • WebCore.gypi: ditto.
  • WebCore.pro: ditto.
  • WebCore.vcproj/WebCore.vcproj: ditto.
  • WebCore.xcodeproj/project.pbxproj: ditto.
  • html/BaseDateAndTimeInputType.cpp: Added. (WebCore::BaseDateAndTimeInputType::parseToDouble): (WebCore::BaseDateAndTimeInputType::parseToDateComponents):
  • html/BaseDateAndTimeInputType.h: Added. (WebCore::BaseDateAndTimeInputType::BaseDateAndTimeInputType):
  • html/DateInputType.cpp: (WebCore::DateInputType::parseToDateComponentsInternal):
  • html/DateInputType.h: (WebCore::DateInputType::DateInputType):
  • html/DateTimeInputType.cpp: (WebCore::DateTimeInputType::parseToDateComponentsInternal):
  • html/DateTimeInputType.h: (WebCore::DateTimeInputType::DateTimeInputType):
  • html/DateTimeLocalInputType.cpp: (WebCore::DateTimeLocalInputType::parseToDateComponentsInternal):
  • html/DateTimeLocalInputType.h: (WebCore::DateTimeLocalInputType::DateTimeLocalInputType):
  • html/HTMLInputElement.cpp: Replace parseToD* calls with m_inputType->parseToD*. (WebCore::HTMLInputElement::typeMismatch): (WebCore::HTMLInputElement::rangeUnderflow): (WebCore::HTMLInputElement::rangeOverflow): (WebCore::HTMLInputElement::minimum): (WebCore::HTMLInputElement::maximum): (WebCore::HTMLInputElement::stepBase): (WebCore::HTMLInputElement::stepMismatch): (WebCore::HTMLInputElement::applyStep): (WebCore::HTMLInputElement::valueAsDate): (WebCore::HTMLInputElement::valueAsNumber): (WebCore::HTMLInputElement::handleKeyEventForRange): (WebCore::HTMLInputElement::stepUpFromRenderer):
  • html/HTMLInputElement.h:
  • html/InputType.cpp: (WebCore::InputType::parseToDouble): (WebCore::InputType::parseToDateComponents):
  • html/InputType.h:
  • html/MonthInputType.cpp: (WebCore::MonthInputType::parseToDouble): (WebCore::MonthInputType::parseToDateComponentsInternal):
  • html/MonthInputType.h: (WebCore::MonthInputType::MonthInputType):
  • html/NumberInputType.cpp: (WebCore::NumberInputType::parseToDouble):
  • html/NumberInputType.h:
  • html/RangeInputType.cpp: (WebCore::RangeInputType::parseToDouble):
  • html/RangeInputType.h:
  • html/TimeInputType.cpp: (WebCore::TimeInputType::parseToDateComponentsInternal):
  • html/TimeInputType.h: (WebCore::TimeInputType::TimeInputType):
  • html/WeekInputType.cpp: (WebCore::WeekInputType::parseToDateComponentsInternal):
  • html/WeekInputType.h: (WebCore::WeekInputType::WeekInputType):
10:44 PM Changeset in webkit [68995] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, remove redundant expectations.

  • platform/chromium/test_expectations.txt:
8:53 PM Changeset in webkit [68994] by morrita@google.com
  • 245 edits
    227 adds in trunk/LayoutTests

2010-10-03 MORITA Hajime <morrita@google.com>

Unrevied, added test expectations for because of the massive SVG change in r68976.
This chanage is for svg/W3C-SVG-1.1/*.

  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-08-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-09-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-10-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-11-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-12-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-13-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-14-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-15-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-16-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-17-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-18-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-19-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-20-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-21-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-22-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-23-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-25-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-26-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-27-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-28-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-29-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-31-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-32-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-33-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-34-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-36-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-37-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-39-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-40-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-41-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-44-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-46-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-52-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-60-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-61-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-62-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-63-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-64-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-65-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-66-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-67-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-68-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-69-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-70-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-77-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-78-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-81-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-82-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-83-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-84-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-85-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/color-prof-01-f-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/color-prop-01-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/color-prop-02-f-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/color-prop-03-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/coords-coord-01-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/coords-coord-02-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/coords-trans-01-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/coords-trans-02-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/coords-trans-03-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/coords-trans-04-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/coords-trans-05-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/coords-trans-06-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/coords-units-01-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/coords-units-02-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/coords-units-03-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/coords-viewattr-01-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/coords-viewattr-03-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/extend-namespace-01-f-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-color-01-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-composite-02-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-displace-01-f-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-example-01-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-felem-01-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-image-01-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-light-01-f-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-offset-01-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-specular-01-f-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-tile-01-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-turb-01-f-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/fonts-desc-02-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-01-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-02-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-03-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-07-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/fonts-glyph-03-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/fonts-glyph-04-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/interact-cursor-01-f-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/interact-dom-01-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/interact-events-01-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/interact-order-01-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/interact-order-02-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/interact-order-03-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/interact-zoom-01-t-expected.txt:
  • platform/chromium-linux/svg/W3C-SVG-1.1/linking-a-01-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/linking-a-02-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/linking-a-03-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/linking-a-04-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/linking-a-05-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/linking-a-07-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/linking-uri-01-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/linking-uri-02-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/linking-uri-03-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/masking-path-01-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/masking-path-03-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/masking-path-04-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/metadata-example-01-b-expected.txt:
  • platform/chromium-linux/svg/W3C-SVG-1.1/painting-fill-01-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/painting-fill-02-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/painting-fill-03-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/painting-fill-04-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/painting-fill-05-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/painting-marker-01-f-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/painting-marker-02-f-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/painting-marker-03-f-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/painting-render-01-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/painting-stroke-01-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/painting-stroke-02-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/painting-stroke-03-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/painting-stroke-04-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/painting-stroke-07-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/paths-data-01-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/paths-data-02-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/paths-data-03-f-expected.txt:
  • platform/chromium-linux/svg/W3C-SVG-1.1/paths-data-04-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/paths-data-05-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/paths-data-06-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/paths-data-07-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/paths-data-08-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/paths-data-09-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/paths-data-10-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/paths-data-12-t-expected.txt:
  • platform/chromium-linux/svg/W3C-SVG-1.1/paths-data-13-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/paths-data-14-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/paths-data-15-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-01-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-02-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-03-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-04-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-05-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-07-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-09-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-10-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-11-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-12-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-15-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-16-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-17-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-18-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-19-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-pattern-01-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/render-elems-01-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/render-elems-02-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/render-elems-03-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/render-elems-06-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/render-elems-07-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/render-elems-08-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/render-groups-01-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/render-groups-03-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/script-handle-01-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/script-handle-02-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/script-handle-03-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/script-handle-04-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/shapes-circle-01-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/shapes-circle-02-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/shapes-ellipse-01-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/shapes-ellipse-02-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/shapes-intro-01-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/shapes-line-01-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/shapes-polygon-01-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/shapes-polyline-01-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/shapes-rect-01-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/shapes-rect-02-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/struct-cond-01-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/struct-cond-02-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/struct-cond-03-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/struct-defs-01-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/struct-frag-04-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/struct-frag-05-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/struct-frag-06-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/struct-group-01-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/struct-group-02-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/struct-group-03-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/struct-image-01-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/struct-image-03-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/struct-image-04-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/struct-image-05-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/struct-image-06-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/struct-image-07-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/struct-image-08-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/struct-image-09-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/struct-image-10-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/struct-use-03-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/struct-use-05-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/styling-css-01-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/styling-css-02-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/styling-css-03-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/styling-css-05-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/styling-css-06-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/styling-inherit-01-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/styling-pres-01-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-align-01-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-align-03-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-align-04-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-altglyph-01-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-deco-01-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-fonts-01-t-expected.txt:
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-fonts-02-t-expected.txt:
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-path-01-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-spacing-01-b-expected.txt:
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-text-01-b-expected.txt:
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-text-03-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-text-04-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-text-06-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-text-07-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-text-08-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-tref-01-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-tselect-01-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-tselect-02-f-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-tspan-01-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-ws-01-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-ws-02-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/types-basicDOM-01-b-expected.txt: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-08-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-09-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-10-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-11-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-12-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-13-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-14-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-15-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-16-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-17-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-18-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-19-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-20-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-21-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-22-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-23-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-25-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-26-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-27-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-28-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-29-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-31-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-32-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-33-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-34-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-36-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-37-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-39-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-40-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-41-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-44-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-46-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-52-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-60-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-61-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-62-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-63-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-64-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-65-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-66-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-67-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-68-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-69-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-70-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-77-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-78-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-81-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-82-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-83-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-84-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-85-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/color-prof-01-f-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/color-prop-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/color-prop-02-f-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/color-prop-03-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/coords-coord-01-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/coords-coord-02-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/coords-trans-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/coords-trans-02-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/coords-trans-03-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/coords-trans-04-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/coords-trans-05-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/coords-trans-06-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/coords-units-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/coords-units-02-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/coords-units-03-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/coords-viewattr-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/coords-viewattr-03-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/extend-namespace-01-f-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-color-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-composite-02-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-displace-01-f-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-example-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-felem-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-image-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-light-01-f-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-offset-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-specular-01-f-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-tile-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-turb-01-f-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/fonts-desc-02-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/fonts-elem-01-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/fonts-elem-02-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/fonts-elem-03-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/fonts-elem-07-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/fonts-glyph-03-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/fonts-glyph-04-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/interact-cursor-01-f-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/interact-dom-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/interact-events-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/interact-order-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/interact-order-02-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/interact-order-03-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/interact-zoom-01-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/linking-a-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/linking-a-02-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/linking-a-03-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/linking-a-04-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/linking-a-05-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/linking-a-07-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/linking-uri-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/linking-uri-02-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/linking-uri-03-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/masking-path-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/masking-path-03-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/masking-path-04-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/metadata-example-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/painting-fill-01-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/painting-fill-02-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/painting-fill-03-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/painting-fill-04-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/painting-fill-05-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/painting-marker-01-f-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/painting-marker-02-f-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/painting-marker-03-f-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/painting-render-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/painting-stroke-01-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/painting-stroke-02-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/painting-stroke-03-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/painting-stroke-04-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/painting-stroke-07-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/paths-data-01-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/paths-data-02-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/paths-data-03-f-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/paths-data-04-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/paths-data-05-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/paths-data-06-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/paths-data-07-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/paths-data-08-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/paths-data-09-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/paths-data-10-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/paths-data-12-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/paths-data-13-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/paths-data-14-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/paths-data-15-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-02-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-03-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-04-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-05-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-07-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-09-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-10-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-11-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-12-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-15-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-16-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-17-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-18-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-19-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-pattern-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/render-elems-01-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/render-elems-02-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/render-elems-03-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/render-elems-06-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/render-elems-07-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/render-elems-08-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/render-groups-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/render-groups-03-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/script-handle-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/script-handle-02-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/script-handle-03-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/script-handle-04-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/shapes-circle-01-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/shapes-circle-02-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/shapes-ellipse-01-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/shapes-ellipse-02-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/shapes-intro-01-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/shapes-line-01-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/shapes-polygon-01-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/shapes-polyline-01-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/shapes-rect-01-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/shapes-rect-02-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/struct-cond-01-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/struct-cond-02-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/struct-cond-03-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/struct-defs-01-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/struct-frag-04-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/struct-frag-05-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/struct-frag-06-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/struct-group-01-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/struct-group-02-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/struct-group-03-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/struct-image-01-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/struct-image-03-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/struct-image-04-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/struct-image-05-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/struct-image-06-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/struct-image-07-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/struct-image-08-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/struct-image-09-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/struct-image-10-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/struct-use-03-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/struct-use-05-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/styling-css-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/styling-css-02-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/styling-css-03-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/styling-css-05-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/styling-css-06-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/styling-inherit-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/styling-pres-01-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/text-align-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/text-align-03-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/text-align-04-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/text-altglyph-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/text-deco-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/text-fonts-01-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/text-fonts-02-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/text-path-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/text-spacing-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/text-text-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/text-text-03-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/text-text-04-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/text-text-06-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/text-text-07-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/text-text-08-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/text-tref-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/text-tselect-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/text-tselect-02-f-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/text-tspan-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/text-ws-01-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/text-ws-02-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/types-basicDOM-01-b-expected.txt:
  • platform/chromium/test_expectations.txt:
8:38 PM Changeset in webkit [68993] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

2010-10-03 Kent Tamura <tkent@chromium.org>

Unreviewed, upstreaming test expectations in Chromium tree.

  • platform/chromium/test_expectations.txt:
7:37 PM Changeset in webkit [68992] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

2010-10-03 Kent Tamura <tkent@chromium.org>

Unreviewed, test expectation update for r68976.

  • platform/chromium/test_expectations.txt:
7:29 PM Changeset in webkit [68991] by Dimitri Glazkov
  • 2 edits
    1 delete in trunk/LayoutTests

2010-10-03 Dimitri Glazkov <Dimitri Glazkov>

Move chromium-win-xp-specific result to its proper place.

  • platform/chromium-win-xp/svg/custom/js-late-pattern-and-object-creation-expected.txt:
  • platform/chromium-win/svg/custom/js-late-pattern-and-object-creation-expected.txt: Removed.
6:22 PM Changeset in webkit [68990] by Dimitri Glazkov
  • 64 edits
    27 copies
    19 adds in trunk/LayoutTests

2010-10-03 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Nikolas Zimmermann.

[Chromium] Rebaseline svg/custom tests due to http://trac.webkit.org/changeset/68976.
https://bugs.webkit.org/show_bug.cgi?id=47061

  • platform/chromium-linux/svg/custom/alignment-baseline-modes-expected.checksum:
  • platform/chromium-linux/svg/custom/alignment-baseline-modes-expected.png:
  • platform/chromium-linux/svg/custom/alignment-baseline-modes-expected.txt: Added.
  • platform/chromium-linux/svg/custom/altglyph-expected.checksum:
  • platform/chromium-linux/svg/custom/altglyph-expected.png:
  • platform/chromium-linux/svg/custom/altglyph-expected.txt: Added.
  • platform/chromium-linux/svg/custom/broken-internal-references-expected.txt:
  • platform/chromium-linux/svg/custom/container-opacity-clip-viewBox-expected.txt: Added.
  • platform/chromium-linux/svg/custom/dominant-baseline-modes-expected.checksum:
  • platform/chromium-linux/svg/custom/dominant-baseline-modes-expected.png:
  • platform/chromium-linux/svg/custom/dominant-baseline-modes-expected.txt: Added.
  • platform/chromium-linux/svg/custom/glyph-transformation-with-hkern-expected.checksum:
  • platform/chromium-linux/svg/custom/glyph-transformation-with-hkern-expected.png:
  • platform/chromium-linux/svg/custom/image-small-width-height-expected.checksum:
  • platform/chromium-linux/svg/custom/image-small-width-height-expected.png:
  • platform/chromium-linux/svg/custom/image-small-width-height-expected.txt: Added.
  • platform/chromium-linux/svg/custom/invalid-fill-expected.txt: Added.
  • platform/chromium-linux/svg/custom/invalid-fill-hex-expected.txt: Added.
  • platform/chromium-linux/svg/custom/js-late-clipPath-and-object-creation-expected.txt: Added.
  • platform/chromium-linux/svg/custom/js-late-clipPath-creation-expected.txt: Added.
  • platform/chromium-linux/svg/custom/js-late-gradient-and-object-creation-expected.txt: Added.
  • platform/chromium-linux/svg/custom/js-late-gradient-creation-expected.txt: Added.
  • platform/chromium-linux/svg/custom/js-late-pattern-and-object-creation-expected.txt:
  • platform/chromium-linux/svg/custom/js-late-pattern-creation-expected.txt: Added.
  • platform/chromium-linux/svg/custom/pattern-rotate-expected.txt: Added.
  • platform/chromium-linux/svg/custom/pattern-with-transformation-expected.txt: Added.
  • platform/chromium-linux/svg/custom/pointer-events-text-expected.txt: Added.
  • platform/chromium-linux/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt: Added.
  • platform/chromium-linux/svg/custom/stroke-width-large-expected.txt:
  • platform/chromium-linux/svg/custom/struct-use-09-b-expected.txt:
  • platform/chromium-linux/svg/custom/style-attribute-font-size-expected.txt: Added.
  • platform/chromium-linux/svg/custom/text-clip-expected.txt: Added.
  • platform/chromium-linux/svg/custom/text-dom-01-f-expected.txt: Added.
  • platform/chromium-linux/svg/custom/text-filter-expected.checksum:
  • platform/chromium-linux/svg/custom/text-filter-expected.png:
  • platform/chromium-linux/svg/custom/text-filter-expected.txt: Added.
  • platform/chromium-linux/svg/custom/text-letter-spacing-expected.txt: Added.
  • platform/chromium-linux/svg/custom/text-linking-expected.txt: Added.
  • platform/chromium-linux/svg/custom/text-repaint-including-stroke-expected.txt: Added.
  • platform/chromium-linux/svg/custom/text-rotation-expected.checksum: Added.
  • platform/chromium-linux/svg/custom/text-rotation-expected.png: Added.
  • platform/chromium-linux/svg/custom/text-rotation-expected.txt: Added.
  • platform/chromium-linux/svg/custom/text-whitespace-handling-expected.txt: Added.
  • platform/chromium-linux/svg/custom/text-x-dx-lists-expected.txt: Added.
  • platform/chromium-linux/svg/custom/text-x-dy-lists-expected.checksum: Added.
  • platform/chromium-linux/svg/custom/text-x-dy-lists-expected.png: Added.
  • platform/chromium-linux/svg/custom/text-x-dy-lists-expected.txt: Added.
  • platform/chromium-linux/svg/custom/text-x-override-in-tspan-child-expected.checksum:
  • platform/chromium-linux/svg/custom/text-x-override-in-tspan-child-expected.png:
  • platform/chromium-linux/svg/custom/text-x-override-in-tspan-child-expected.txt: Added.
  • platform/chromium-linux/svg/custom/use-on-text-expected.txt: Added.
  • platform/chromium-linux/svg/custom/use-referencing-nonexisting-symbol-expected.txt: Added.
  • platform/chromium-mac/svg/custom/altglyph-expected.checksum: Added.
  • platform/chromium-mac/svg/custom/altglyph-expected.png: Added.
  • platform/chromium-win/svg/custom/alignment-baseline-modes-expected.checksum:
  • platform/chromium-win/svg/custom/alignment-baseline-modes-expected.png:
  • platform/chromium-win/svg/custom/alignment-baseline-modes-expected.txt:
  • platform/chromium-win/svg/custom/altglyph-expected.checksum:
  • platform/chromium-win/svg/custom/altglyph-expected.png:
  • platform/chromium-win/svg/custom/altglyph-expected.txt:
  • platform/chromium-win/svg/custom/broken-internal-references-expected.txt:
  • platform/chromium-win/svg/custom/container-opacity-clip-viewBox-expected.txt:
  • platform/chromium-win/svg/custom/dominant-baseline-modes-expected.checksum:
  • platform/chromium-win/svg/custom/dominant-baseline-modes-expected.png:
  • platform/chromium-win/svg/custom/dominant-baseline-modes-expected.txt:
  • platform/chromium-win/svg/custom/glyph-transformation-with-hkern-expected.checksum:
  • platform/chromium-win/svg/custom/glyph-transformation-with-hkern-expected.png:
  • platform/chromium-win/svg/custom/image-small-width-height-expected.checksum:
  • platform/chromium-win/svg/custom/image-small-width-height-expected.png:
  • platform/chromium-win/svg/custom/image-small-width-height-expected.txt:
  • platform/chromium-win/svg/custom/invalid-fill-expected.txt:
  • platform/chromium-win/svg/custom/invalid-fill-hex-expected.txt:
  • platform/chromium-win/svg/custom/js-late-clipPath-and-object-creation-expected.txt:
  • platform/chromium-win/svg/custom/js-late-clipPath-creation-expected.txt:
  • platform/chromium-win/svg/custom/js-late-gradient-and-object-creation-expected.txt:
  • platform/chromium-win/svg/custom/js-late-gradient-creation-expected.txt:
  • platform/chromium-win/svg/custom/js-late-pattern-and-object-creation-expected.txt: Added.
  • platform/chromium-win/svg/custom/js-late-pattern-creation-expected.txt:
  • platform/chromium-win/svg/custom/pattern-rotate-expected.txt:
  • platform/chromium-win/svg/custom/pattern-with-transformation-expected.txt:
  • platform/chromium-win/svg/custom/pointer-events-text-expected.txt:
  • platform/chromium-win/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt:
  • platform/chromium-win/svg/custom/stroke-width-large-expected.txt:
  • platform/chromium-win/svg/custom/struct-use-09-b-expected.checksum: Added.
  • platform/chromium-win/svg/custom/struct-use-09-b-expected.png: Added.
  • platform/chromium-win/svg/custom/struct-use-09-b-expected.txt: Added.
  • platform/chromium-win/svg/custom/style-attribute-font-size-expected.txt:
  • platform/chromium-win/svg/custom/text-clip-expected.txt:
  • platform/chromium-win/svg/custom/text-dom-01-f-expected.txt:
  • platform/chromium-win/svg/custom/text-filter-expected.checksum:
  • platform/chromium-win/svg/custom/text-filter-expected.png:
  • platform/chromium-win/svg/custom/text-filter-expected.txt:
  • platform/chromium-win/svg/custom/text-letter-spacing-expected.txt:
  • platform/chromium-win/svg/custom/text-linking-expected.txt:
  • platform/chromium-win/svg/custom/text-repaint-including-stroke-expected.txt:
  • platform/chromium-win/svg/custom/text-rotation-expected.checksum: Added.
  • platform/chromium-win/svg/custom/text-rotation-expected.png: Added.
  • platform/chromium-win/svg/custom/text-rotation-expected.txt: Added.
  • platform/chromium-win/svg/custom/text-whitespace-handling-expected.txt:
  • platform/chromium-win/svg/custom/text-x-dx-lists-expected.txt:
  • platform/chromium-win/svg/custom/text-x-dy-lists-expected.checksum: Added.
  • platform/chromium-win/svg/custom/text-x-dy-lists-expected.png: Added.
  • platform/chromium-win/svg/custom/text-x-dy-lists-expected.txt: Added.
  • platform/chromium-win/svg/custom/text-x-override-in-tspan-child-expected.checksum:
  • platform/chromium-win/svg/custom/text-x-override-in-tspan-child-expected.png:
  • platform/chromium-win/svg/custom/text-x-override-in-tspan-child-expected.txt:
  • platform/chromium-win/svg/custom/use-on-text-expected.txt:
  • platform/chromium-win/svg/custom/use-referencing-nonexisting-symbol-expected.txt:
  • platform/chromium/test_expectations.txt:
2:50 PM Changeset in webkit [68989] by andersca@apple.com
  • 14 edits in trunk/WebKit2

Implement newly added Plugin/PluginController member functions for out of process plug-ins
https://bugs.webkit.org/show_bug.cgi?id=47065
<rdar://problem/8507194>

Reviewed by Sam Weinig.

  • Platform/CoreIPC/Arguments.h:

Add typedefs.

  • Platform/CoreIPC/HandleMessage.h:

(CoreIPC::handleMessage):
Add new handleMessage overload.

  • PluginProcess/PluginControllerProxy.cpp:

(WebKit::PluginControllerProxy::create):
Add an isPrivateBrowsingEnabled boolean.

(WebKit::PluginControllerProxy::PluginControllerProxy):
Add an isPrivateBrowsingEnabled boolean.

(WebKit::PluginControllerProxy::proxiesForURL):
(WebKit::PluginControllerProxy::cookiesForURL):
(WebKit::PluginControllerProxy::setCookiesForURL):
Send messages to the web process.

(WebKit::PluginControllerProxy::isPrivateBrowsingEnabled):
Return whether private browsing is enabled or not.

(WebKit::PluginControllerProxy::handleKeyboardEvent):
Call Plugin::handleKeyboardEvent.

(WebKit::PluginControllerProxy::privateBrowsingStateChanged):
Call Plugin::privateBrowsingStateChanged.

  • PluginProcess/PluginControllerProxy.messages.in:

Add new messages.

  • PluginProcess/WebProcessConnection.cpp:

(WebKit::WebProcessConnection::createPlugin):
Pass the isPrivateBrowsingEnabled flag.

  • PluginProcess/WebProcessConnection.h:
  • PluginProcess/WebProcessConnection.messages.in:

Update CreatePlugin message parameters.

  • WebProcess/Plugins/PluginProcessConnection.cpp:

(WebKit::PluginProcessConnection::didReceiveMessage):
(WebKit::PluginProcessConnection::didReceiveSyncMessage):
It's OK for a plug-in to not get a sync message.

  • WebProcess/Plugins/PluginProcessConnection.h:
  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::handleKeyboardEvent):
(WebKit::PluginProxy::privateBrowsingStateChanged):
Send messages.

(WebKit::PluginProxy::proxiesForURL):
(WebKit::PluginProxy::cookiesForURL):
(WebKit::PluginProxy::setCookiesForURL):
Call the plug-in controller.

  • WebProcess/Plugins/PluginProxy.messages.in:

Add new messages.

2:02 PM Changeset in webkit [68988] by andersca@apple.com
  • 8 edits in trunk/WebKit2

Send keyboard events to plug-ins
https://bugs.webkit.org/show_bug.cgi?id=47064
<rdar://problem/8507148>

Reviewed by Sam Weinig.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::handleKeyboardEvent):
Call platformHandleKeyboardEvent.

  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:

(WebKit::modifierFlags):
Return the modifier flags given a WebKeyboardEvent.

(WebKit::initializeKeyboardEvent):
Initialize an NPCocoaEvent from a WebKeyboardEvent.

(WebKit::NetscapePlugin::platformHandleKeyboardEvent):
Initialize the event and dispatch it using NPP_HandleEvent.

  • WebProcess/Plugins/Netscape/qt/NetscapePluginQt.cpp:

(WebKit::NetscapePlugin::platformHandleKeyboardEvent):
Add stub.

  • WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:

(WebKit::NetscapePlugin::platformHandleKeyboardEvent):
Add stub.

  • WebProcess/Plugins/Plugin.h:

Add handleKeyboardEvent.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::handleEvent):
Call Plugin::handleKeyboardEvent if we see a keydown or keyup event.

8:35 AM Changeset in webkit [68987] by Dimitri Glazkov
  • 2 edits in trunk

2010-10-03 Dimitri Glazkov <Dimitri Glazkov>

Add Chromium depot_tools to files that git should ignore.

  • .gitignore: Added WebKit/chromium/depot_tools.
2:22 AM Changeset in webkit [68986] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-10-03 Adam Barth <abarth@webkit.org>

Reviewed by Holger Freyther.

ASSERT(m_state = Open); is bad news bears
https://bugs.webkit.org/show_bug.cgi?id=47057

Added by ap (review by darin) in http://trac.webkit.org/changeset/50951
Too bad the compiler doesn't catch these errors. I don't believe this
is possible to test.

  • platform/network/cf/SocketStreamHandleCFNet.cpp: (WebCore::SocketStreamHandle::writeStreamCallback):
2:00 AM Changeset in webkit [68985] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-10-03 Adam Barth <abarth@webkit.org>

Reviewed by Holger Freyther.

All the WebSocket tests crash
https://bugs.webkit.org/show_bug.cgi?id=47056

More code that tries to hold onto temporaries with references.

  • websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::didOpen):
1:19 AM Changeset in webkit [68984] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-10-03 Adam Barth <abarth@webkit.org>

Reviewed by Holger Freyther.

All the WebSocket tests crash
https://bugs.webkit.org/show_bug.cgi?id=47055

This code attempts to hold onto temporary objects using references.
That doesn't work in C++. Instead, we need to actually store the
objects somewhere.

  • bindings/js/JSWebSocketCustom.cpp: (WebCore::JSWebSocketConstructor::constructJSWebSocket):
Note: See TracTimeline for information about the timeline view.