Timeline



Oct 15, 2010:

10:09 PM Changeset in webkit [69911] by kinuko@chromium.org
  • 14 edits
    6 copies
    1 delete in branches/chromium/552

Merge 69907 - 2010-10-15 Kinuko Yasuda <​kinuko@google.com>

Reviewed by Jian Li.

Implement FileEntrySync.file() in FileSystem API
​https://bugs.webkit.org/show_bug.cgi?id=47310

Tests: fast/filesystem/workers/file-from-file-entry-sync.html

fast/filesystem/workers/file-from-file-entry.html

TBR=​kinuko@chromium.org

9:10 PM Changeset in webkit [69910] by rniwa@webkit.org
  • 4 edits
    3 adds in trunk

2010-10-15 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Darin Adler.

unlink removes inline style of anchor elements
​https://bugs.webkit.org/show_bug.cgi?id=47424

The bug was caused by our not extracting styles when the anchor element is removed by removeInlineStyle.
Because we removed the element without pushing its inline style down, we lost style information.

Fixed the bug by pushing down styles in removeInlineStyle as done in pushDownInlineStyleAroundNode.
Also fixed a bug in addInlineStyleIfNeeded where StyleChange incorrectly removed styles of the container
node as supposed to that of startNode from the style to apply when startNode is not an element.

Test: editing/execCommand/toggle-unlink.html

  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::removeInlineStyleFromElement): To prevent a similar bug in the future, added an assert that extractedStyle is specified whenever we're removing a styled element. (WebCore::ApplyStyleCommand::removeInlineStyle): (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded):

2010-10-15 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Darin Adler.

unlink removes inline style of anchor elements
​https://bugs.webkit.org/show_bug.cgi?id=47424

Added a test to ensure execCommand('unlink', false, null) preserves the inline style declaration.

  • editing/execCommand/script-tests/toggle-unlink.js: Added. (testSingleToggle): (selectAll): (selectFirstTwoWords): (selectLastTwoWords): (selectLastWord):
  • editing/execCommand/toggle-unlink-expected.txt: Added.
  • editing/execCommand/toggle-unlink.html: Added.
  • editing/style/script-tests/make-text-writing-direction-inline.js: Specifies both direction and unicode-bidi properties instead of just direction property.
8:16 PM Changeset in webkit [69909] by rniwa@webkit.org
  • 4 edits in trunk/WebCore

2010-10-15 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Tony Chang.

serializeNodesWithNamespaces should be in MarkupAccumulator
​https://bugs.webkit.org/show_bug.cgi?id=47749

Moved serializeNodesWithNamespaces to MarkupAccumulator, and renamed it to serializeNodes.
MarkupAccumulator::serializeNode now returns the resultant string instead of having a separate takeResults().
Added several helper functions to MarkupAccumulator.

No new tests are added since this is a cleanup.

  • editing/MarkupAccumulator.cpp: (WebCore::MarkupAccumulator::serializeNodes): Wrapper for serializeNodes and concatenateMarkup. (WebCore::MarkupAccumulator::serializeNodesWithNamespaces): Moved from markup.cpp (WebCore::MarkupAccumulator::appendStartTag): Calls appendString instead of appending into m_succeedingMarkup directly. (WebCore::MarkupAccumulator::appendEndTag): Ditto. (WebCore::MarkupAccumulator::totalLength): Added; extracted from takeResults. (WebCore::MarkupAccumulator::concatenateMarkup): Ditto.
  • editing/MarkupAccumulator.h: (WebCore::MarkupAccumulator::length): Added; calls totalLength.
  • editing/markup.cpp: (WebCore::StyledMarkupAccumulator::appendString): Added; calls MarkupAccumulator's appendString. (WebCore::StyledMarkupAccumulator::wrapWithStyleNode): Calls appendString. (WebCore::StyledMarkupAccumulator::takeResults): Calls length, totalLength, and concatenateMarkup. (WebCore::StyledMarkupAccumulator::serializeNodes): Became a member function. (WebCore::createMarkup): Uses MarkupAccumulator.
7:17 PM Changeset in webkit [69908] by thakis@chromium.org
  • 2 edits in branches/chromium/552/WebCore

Merge 69901 - 2010-10-15 Nico Weber <​thakis@chromium.org>

Reviewed by Eric Carlson.

Make sure to update the current graphics context when calling out to AppKit.
​https://bugs.webkit.org/show_bug.cgi?id=47757

Like r57741, but for the spellchecking highlight

  • platform/graphics/mac/GraphicsContextMac.mm: (WebCore::GraphicsContext::drawLineForTextChecking):

TBR=​thakis@chromium.org

7:05 PM Changeset in webkit [69907] by kinuko@chromium.org
  • 14 edits
    1 move
    5 adds in trunk

2010-10-15 Kinuko Yasuda <​kinuko@google.com>

Reviewed by Jian Li.

Implement FileEntrySync.file() in FileSystem API
​https://bugs.webkit.org/show_bug.cgi?id=47310

Tests: fast/filesystem/workers/file-from-file-entry-sync.html

fast/filesystem/workers/file-from-file-entry.html

  • fileapi/DOMFileSystem.cpp: (WebCore::DOMFileSystem::createFile): Added.
  • fileapi/DOMFileSystem.h:
  • fileapi/DOMFileSystemSync.cpp: (WebCore::DOMFileSystemSync::createFile): Added.
  • fileapi/DOMFileSystemSync.h:
  • fileapi/DirectoryReaderBase.h: Added 'virtual path' comment.
  • fileapi/EntryBase.h: Added 'virtual path' comment.
  • fileapi/FileEntry.cpp: (WebCore::FileEntry::file): Changed to use DOMFileSystem::createFile.
  • fileapi/FileEntrySync.cpp: (WebCore::FileEntrySync::file): Implemented.
  • fileapi/FileEntrySync.h:
  • fileapi/FileEntrySync.idl: Added file().

2010-10-15 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by Jian Li.

Implement FileEntrySync.file() in FileSystem API
​https://bugs.webkit.org/show_bug.cgi?id=47310

  • fast/filesystem/file-from-file-entry-expected.txt:
  • fast/filesystem/file-from-file-entry.html:
  • fast/filesystem/resources/file-from-file-entry-sync.js: Added.
  • fast/filesystem/resources/file-from-file-entry.js: Added.
  • fast/filesystem/script-tests/file-from-file-entry.js: Moved to resources to make it available for workers tests too.
  • fast/filesystem/workers/file-from-file-entry-expected.txt: Added.
  • fast/filesystem/workers/file-from-file-entry-sync-expected.txt: Added.
  • fast/filesystem/workers/file-from-file-entry-sync.html: Added.
  • fast/filesystem/workers/file-from-file-entry.html: Added.
6:50 PM Changeset in webkit [69906] by oliver@apple.com
  • 4 edits
    3 adds in trunk

2010-10-15 Oliver Hunt <​oliver@apple.com>

Reviewed by Sam Weinig.

Automatic Semicolon Insertion incorrectly inserts semicolon after break, continue, and return followed by a newline
​https://bugs.webkit.org/show_bug.cgi?id=47762

The old YACC parser depended on the lexer for some classes of semicolon insertion.
The new parser handles ASI entirely on its own so when the lexer inserts a semicolon
on its own the net result is a spurious semicolon in the input stream. This can result
in incorrect parsing in some cases:

if (0)

break

;else {}

Would result in a parse failure as the output from the lexer is essentially

if (0)

break

;;else

So the second semicolon is interpreted as a empty statement, which terminates the if,
making the else an error.

  • parser/JSParser.cpp: (JSC::JSParser::parseThrowStatement): Parsing of throw statement was wrong, and only worked due to the weird behaviour in the lexer
  • parser/Lexer.cpp: (JSC::Lexer::lex): Remove bogus semicolon insertion from the newline handling

2010-10-15 Oliver Hunt <​oliver@apple.com>

Reviewed by Sam Weinig.

ASI incorrectly inserts semicolon after break, continue, and return followed by a newline
​https://bugs.webkit.org/show_bug.cgi?id=47762

tests for correct ASI following break, continue, and return

  • fast/js/break-ASI-expected.txt: Added.
  • fast/js/break-ASI.html: Added.
  • fast/js/script-tests/break-ASI.js: Added.
6:31 PM Changeset in webkit [69905] by dpranke@chromium.org
  • 7 edits in trunk/WebKitTools

2010-10-15 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Eric Siedel.

mocktool.MockOptions is inheriting from Mock, which has the side
effect of defaulting any attribute to another MockObject. So,
MockOptions().foo would always evaluate to true. This was
covering over bugs in the unit tests, and is probably the wrong
default behavior for anything attempting to mock out the options
argument returned from optparse.parse_args().

This patch changes the default behavior. The new MockOptions()
class takes an optional list of keyword parameters to set; this
patch doesn't use that feature but the fix for bug 47510 will.

Also, this patch just fills in the default values necessary to
get all of the tests to pass; I didn't stare at each test by
hand to determine the "right" values. We can either fix that in
subsequent patches or let me know if we want to do that now (and
give me some guidance on what those values might want to be).

​https://bugs.webkit.org/show_bug.cgi?id=47709

  • Scripts/webkitpy/tool/commands/commandtest.py:
  • Scripts/webkitpy/tool/commands/download_unittest.py:
  • Scripts/webkitpy/tool/commands/upload_unittest.py:
  • Scripts/webkitpy/tool/mocktool.py:
  • Scripts/webkitpy/tool/steps/steps_unittest.py:
  • Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
6:15 PM Changeset in webkit [69904] by crogers@google.com
  • 56 edits
    2 adds in branches/audio/WebCore

audio branch: changes in preparation for landing into trunk

  • massive munge to change to proper license
  • cleanup of delay-related files
  • add AudioResamplerKernel files
  • lots of cleanup for AudioNodeInput and AudioNodeOutput
  • cleanup of AudioResampler
  • lots of cleanup for AudioBufferSourceNode

audio branch: last minute cleanup

6:08 PM Changeset in webkit [69903] by jamesr@google.com
  • 21 edits
    20 copies in trunk/LayoutTests

2010-10-15 Mihai Parparita <​mihaip@chromium.org>

Reviewed by James Robinson.

css2.1/ layout tests need new Mac baselines for Snow Leopard
​https://bugs.webkit.org/show_bug.cgi?id=47760

Rebaseline 10 css2.1/ test for Snow Leopard using the experimental
local rebaselining tool.

  • platform/mac-leopard/css2.1/t010403-shand-border-00-c-expected.checksum: Copied from LayoutTests/platform/mac/css2.1/t010403-shand-border-00-c-expected.checksum.
  • platform/mac-leopard/css2.1/t010403-shand-border-00-c-expected.png: Copied from LayoutTests/platform/mac/css2.1/t010403-shand-border-00-c-expected.png.
  • platform/mac-leopard/css2.1/t010403-shand-font-00-b-expected.checksum: Copied from LayoutTests/platform/mac/css2.1/t010403-shand-font-00-b-expected.checksum.
  • platform/mac-leopard/css2.1/t010403-shand-font-00-b-expected.png: Copied from LayoutTests/platform/mac/css2.1/t010403-shand-font-00-b-expected.png.
  • platform/mac-leopard/css2.1/t010403-shand-font-01-b-expected.checksum: Copied from LayoutTests/platform/mac/css2.1/t010403-shand-font-01-b-expected.checksum.
  • platform/mac-leopard/css2.1/t010403-shand-font-01-b-expected.png: Copied from LayoutTests/platform/mac/css2.1/t010403-shand-font-01-b-expected.png.
  • platform/mac-leopard/css2.1/t010403-shand-font-02-b-expected.checksum: Copied from LayoutTests/platform/mac/css2.1/t010403-shand-font-02-b-expected.checksum.
  • platform/mac-leopard/css2.1/t010403-shand-font-02-b-expected.png: Copied from LayoutTests/platform/mac/css2.1/t010403-shand-font-02-b-expected.png.
  • platform/mac-leopard/css2.1/t010403-shand-font-03-b-expected.checksum: Copied from LayoutTests/platform/mac/css2.1/t010403-shand-font-03-b-expected.checksum.
  • platform/mac-leopard/css2.1/t010403-shand-font-03-b-expected.png: Copied from LayoutTests/platform/mac/css2.1/t010403-shand-font-03-b-expected.png.
  • platform/mac-leopard/css2.1/t040102-keywords-00-b-expected.checksum: Copied from LayoutTests/platform/mac/css2.1/t040102-keywords-00-b-expected.checksum.
  • platform/mac-leopard/css2.1/t040102-keywords-00-b-expected.png: Copied from LayoutTests/platform/mac/css2.1/t040102-keywords-00-b-expected.png.
  • platform/mac-leopard/css2.1/t040102-keywords-01-b-expected.checksum: Copied from LayoutTests/platform/mac/css2.1/t040102-keywords-01-b-expected.checksum.
  • platform/mac-leopard/css2.1/t040102-keywords-01-b-expected.png: Copied from LayoutTests/platform/mac/css2.1/t040102-keywords-01-b-expected.png.
  • platform/mac-leopard/css2.1/t040103-case-00-b-expected.checksum: Copied from LayoutTests/platform/mac/css2.1/t040103-case-00-b-expected.checksum.
  • platform/mac-leopard/css2.1/t040103-case-00-b-expected.png: Copied from LayoutTests/platform/mac/css2.1/t040103-case-00-b-expected.png.
  • platform/mac-leopard/css2.1/t040103-case-01-c-expected.checksum: Copied from LayoutTests/platform/mac/css2.1/t040103-case-01-c-expected.checksum.
  • platform/mac-leopard/css2.1/t040103-case-01-c-expected.png: Copied from LayoutTests/platform/mac/css2.1/t040103-case-01-c-expected.png.
  • platform/mac-leopard/css2.1/t040103-escapes-00-b-expected.checksum: Copied from LayoutTests/platform/mac/css2.1/t040103-escapes-00-b-expected.checksum.
  • platform/mac-leopard/css2.1/t040103-escapes-00-b-expected.png: Copied from LayoutTests/platform/mac/css2.1/t040103-escapes-00-b-expected.png.
  • platform/mac/css2.1/t010403-shand-border-00-c-expected.checksum:
  • platform/mac/css2.1/t010403-shand-border-00-c-expected.png:
  • platform/mac/css2.1/t010403-shand-font-00-b-expected.checksum:
  • platform/mac/css2.1/t010403-shand-font-00-b-expected.png:
  • platform/mac/css2.1/t010403-shand-font-01-b-expected.checksum:
  • platform/mac/css2.1/t010403-shand-font-01-b-expected.png:
  • platform/mac/css2.1/t010403-shand-font-02-b-expected.checksum:
  • platform/mac/css2.1/t010403-shand-font-02-b-expected.png:
  • platform/mac/css2.1/t010403-shand-font-03-b-expected.checksum:
  • platform/mac/css2.1/t010403-shand-font-03-b-expected.png:
  • platform/mac/css2.1/t040102-keywords-00-b-expected.checksum:
  • platform/mac/css2.1/t040102-keywords-00-b-expected.png:
  • platform/mac/css2.1/t040102-keywords-01-b-expected.checksum:
  • platform/mac/css2.1/t040102-keywords-01-b-expected.png:
  • platform/mac/css2.1/t040103-case-00-b-expected.checksum:
  • platform/mac/css2.1/t040103-case-00-b-expected.png:
  • platform/mac/css2.1/t040103-case-01-c-expected.checksum:
  • platform/mac/css2.1/t040103-case-01-c-expected.png:
  • platform/mac/css2.1/t040103-escapes-00-b-expected.checksum:
  • platform/mac/css2.1/t040103-escapes-00-b-expected.png:
6:01 PM Changeset in webkit [69902] by weinig@apple.com
  • 2 edits in trunk/WebKit2

Fix Qt build.

  • UIProcess/API/qt/qwkpage.cpp:

(QWKPagePrivate::createPopupMenuProxy):

5:56 PM Changeset in webkit [69901] by thakis@chromium.org
  • 2 edits in trunk/WebCore

2010-10-15 Nico Weber <​thakis@chromium.org>

Reviewed by Eric Carlson.

Make sure to update the current graphics context when calling out to AppKit.
​https://bugs.webkit.org/show_bug.cgi?id=47757

Like r57741, but for the spellchecking highlight

  • platform/graphics/mac/GraphicsContextMac.mm: (WebCore::GraphicsContext::drawLineForTextChecking):
5:50 PM Changeset in webkit [69900] by bweinstein@apple.com
  • 5 edits
    2 adds in trunk

REGRESSION(r69850) Loading apple.com/startpage in WebKit on Windows gets a bad request.
​https://bugs.webkit.org/show_bug.cgi?id=47753
<rdar://problem/8558242>

Reviewed by Sam Weinig.

WebCore:

r69850 switched over to a different way of concatenating WebCore strings, but ran into an issue
where some Windows calls were returning null terminated strings, and this breaks the new
method of concatenation.

GetLocaleInfo returns a null-terminated string, but WebCore strings are non-null terminated,
so once we create our WebCore string, we want to trim off the null terminating character before
we return the localeInfo.

Test: fast/dom/navigator-userAgent.html

  • platform/win/Language.cpp:

(WebCore::localeInfo):

WebKit/win:

VerQueryValue returns a null terminated string, but we need to strip off the null terminating character
when we turn it into a WebCore string, or else concatenation using this string will break.

  • WebView.cpp:

LayoutTests:

Add a test to make sure that the user agent has some important parts, and is fully formed.
This test tests that the user agent has Mozilla, AppleWebKit, and KHML, like Gecko. If the
user agent has all of these components, the string concatenation worked correctly, and this
bug is fixed.

  • fast/dom/navigator-userAgent-expected.txt: Added.
  • fast/dom/navigator-userAgent.html: Added.
5:47 PM Changeset in webkit [69899] by weinig@apple.com
  • 22 edits
    9 adds in trunk/WebKit2

Popup widget support (<select>)
<rdar://problem/8147746>
​https://bugs.webkit.org/show_bug.cgi?id=47740

Reviewed by Anders Carlsson.

Add initial support for popup menus. Only works on the mac at this time.

  • Shared/WebPopupItem.cpp: Added.

(WebKit::WebPopupItem::WebPopupItem):
(WebKit::WebPopupItem::encode):
(WebKit::WebPopupItem::decode):

  • Shared/WebPopupItem.h: Added.

Serializable representation of a menu item.

  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::createPopupMenuProxy):
Create a WebPopupMenuProxyMac.

  • UIProcess/API/qt/qwkpage.cpp:

(WebView::createPopupMenuProxy):

  • UIProcess/API/qt/qwkpage_p.h:

Create a WebPopupMenuProxyQt (which is just a stub right now).

(WebKit::WebPopupMenuProxyWin::create):

  • UIProcess/win/WebView.cpp:

(WebKit::WebView::createPopupMenuProxy):

  • UIProcess/win/WebView.h:

Create a WebPopupMenuProxyWin (which is just a stub right now).

  • UIProcess/PageClient.h:

Add new client function to get a platform specific WebPopupMenuProxy.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::close):
(WebKit::WebPageProxy::showPopupMenu):
(WebKit::WebPageProxy::hidePopupMenu):
(WebKit::WebPageProxy::processDidExit):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:

Pipe through calls to set up the menu.

  • UIProcess/mac/WebPopupMenuProxyMac.h: Added.

(WebKit::WebPopupMenuProxyMac::create):

  • UIProcess/mac/WebPopupMenuProxyMac.mm: Added.

(WebKit::WebPopupMenuProxyMac::WebPopupMenuProxyMac):
(WebKit::WebPopupMenuProxyMac::~WebPopupMenuProxyMac):
(WebKit::WebPopupMenuProxyMac::populate):
(WebKit::WebPopupMenuProxyMac::showPopupMenu):
(WebKit::WebPopupMenuProxyMac::hidePopupMenu):
Add UI process side implementation. Currently this does not support
custom fonts as the old implementation did.

  • UIProcess/qt/WebPopupMenuProxyQt.cpp: Added.

(WebKit::WebPopupMenuProxyQt::WebPopupMenuProxyQt):
(WebKit::WebPopupMenuProxyQt::~WebPopupMenuProxyQt):
(WebKit::WebPopupMenuProxyQt::showPopupMenu):
(WebKit::WebPopupMenuProxyQt::hidePopupMenu):

  • UIProcess/qt/WebPopupMenuProxyQt.h: Added.

(WebKit::WebPopupMenuProxyQt::create):

  • UIProcess/win/WebPopupMenuProxyWin.cpp: Added.

(WebKit::WebPopupMenuProxyWin::WebPopupMenuProxyWin):
(WebKit::WebPopupMenuProxyWin::~WebPopupMenuProxyWin):
(WebKit::WebPopupMenuProxyWin::showPopupMenu):
(WebKit::WebPopupMenuProxyWin::hidePopupMenu):

  • UIProcess/win/WebPopupMenuProxyWin.h: Added.

Add stubbed out implementations for Qt and windows.

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::createPopupMenu):
(WebKit::WebChromeClient::createSearchPopupMenu):
Pass the page in the create function.

  • WebProcess/WebCoreSupport/WebPopupMenu.cpp:

(WebKit::WebPopupMenu::create):
(WebKit::WebPopupMenu::WebPopupMenu):
(WebKit::WebPopupMenu::didChangeSelectedIndex):
(WebKit::WebPopupMenu::populateItems):
(WebKit::WebPopupMenu::show):
(WebKit::WebPopupMenu::hide):

  • WebProcess/WebCoreSupport/WebPopupMenu.h:

(WebKit::WebPopupMenu::disconnectFromPage):

  • WebProcess/WebCoreSupport/WebSearchPopupMenu.cpp:

(WebKit::WebSearchPopupMenu::create):
(WebKit::WebSearchPopupMenu::WebSearchPopupMenu):
(WebKit::WebSearchPopupMenu::popupMenu):

  • WebProcess/WebCoreSupport/WebSearchPopupMenu.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::close):
(WebKit::WebPage::setActivePopupMenu):
(WebKit::WebPage::didChangeSelectedIndexForActivePopupMenu):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:

Pipe through calls to set up the menu.

  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:

Add new files.

5:40 PM Changeset in webkit [69898] by ap@apple.com
  • 4 edits in trunk/WebCore

Trying to fix crashes on Leopard buildbot.

  • loader/loader.cpp: (WebCore::Loader::Host::didFinishLoading): (WebCore::Loader::Host::didFail): Moved logging higher in the function - it seems that CachedResource can be already destroyed.
  • platform/Logging.cpp: (WebCore::getChannelFromName):
  • platform/mac/LoggingMac.mm: (WebCore::InitializeLoggingChannelsIfNecessary): Initialize the new channel (oops).
5:14 PM Changeset in webkit [69897] by andersca@apple.com
  • 2 edits in trunk/WebKit2

Fix build.

  • UIProcess/API/mac/FindIndicatorWindow.mm:

(-[WebFindIndicatorWindowAnimation setCurrentProgress:]):

4:39 PM Changeset in webkit [69896] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

2010-10-15 Mike Lawther <​mikelawther@chromium.org>

Reviewed by James Robinson.

iframes keep getting scrollbars with scrolling="no"
​https://bugs.webkit.org/show_bug.cgi?id=29240

Prevent scrollbars from appearing in iframes with scrolling=no
when the embedded content has overflow:scroll set on the html
or body tags.

  • fast/frames/iframe-scrolling-attribute-overflowscroll-expected.txt: Added.
  • fast/frames/iframe-scrolling-attribute-overflowscroll.html: Added.

2010-10-15 Mike Lawther <​mikelawther@chromium.org>

Reviewed by James Robinson.

Prevent scrollbars from appearing in iframes with scrolling=no
when the embedded content has overflow:scroll set on the html
or body tags.

iframes keep getting scrollbars with scrolling="no"
​https://bugs.webkit.org/show_bug.cgi?id=29240

Test: fast/frames/iframe-scrolling-attribute-overflowscroll.html

  • page/FrameView.cpp: (WebCore::FrameView::calculateScrollbarModesForLayout) (WebCore::FrameView::updateCanHaveScrollbars): (WebCore::FrameView::layout):
  • page/FrameView.h: (WebCore::FrameView::calculateScrollbarModesForLayout)
4:33 PM Changeset in webkit [69895] by andersca@apple.com
  • 3 edits in trunk/WebKit2

Make the find indicator window fade out when requested
​https://bugs.webkit.org/show_bug.cgi?id=47747

Reviewed by Sam Weinig.

  • UIProcess/API/mac/FindIndicatorWindow.h:
  • UIProcess/API/mac/FindIndicatorWindow.mm:

Add WebFindIndicatorWindowAnimation - an NSAnimation subclass that takes two
C++ member function pointers and invokes them the animation progress changes and
when the animation stops.

(-[WebFindIndicatorWindowAnimation setCurrentProgress:]):
Call the _animationProgressCallback.

(-[WebFindIndicatorWindowAnimation animationDidEnd:]):
Call the _animationDidEndCallback.

(WebKit::FindIndicatorWindow::FindIndicatorWindow):
Initialize the fade out start timer.

(WebKit::FindIndicatorWindow::setFindIndicator):
When asked to fade out, we start the fade out timer.

(WebKit::FindIndicatorWindow::closeWindow):
Stop the fade out timer and the fade out animation.

(WebKit::FindIndicatorWindow::startFadeOutTimerFired):
Create a fade out animation.

(WebKit::FindIndicatorWindow::fadeOutAnimationCallback):
Update the window alpha.

(WebKit::FindIndicatorWindow::fadeOutAnimationDidEnd):
Close the window.

3:52 PM Changeset in webkit [69894] by Simon Fraser
  • 3 edits in trunk/WebKitTools

2010-10-15 Simon Fraser <Simon Fraser>

Fix the build; need to add new slot to PageUIClient callbacks.

  • MiniBrowser/mac/BrowserWindowController.m: (-[BrowserWindowController awakeFromNib]):
  • WebKitTestRunner/TestController.cpp: (WTR::createOtherPage): (WTR::TestController::initialize):
3:43 PM Changeset in webkit [69893] by Simon Fraser
  • 2 edits in trunk/WebKitTools

2010-10-15 Simon Fraser <Simon Fraser>

Add Matt Delaney to committers.py.

  • Scripts/webkitpy/common/config/committers.py:
3:33 PM Changeset in webkit [69892] by Simon Fraser
  • 8 edits in trunk/WebKit2

2010-10-15 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Add 'didDraw' callback for framerate tracking
​https://bugs.webkit.org/show_bug.cgi?id=47478

Hook up the 'didDraw' callback for WebKit2 on Mac.

  • UIProcess/API/C/WKPage.h:
  • UIProcess/API/mac/WKView.mm: (-[WKView drawRect:]):
  • UIProcess/API/qt/qwkpage.cpp: (QWKPage::QWKPage):
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didDraw):
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebUIClient.cpp: (WebKit::WebUIClient::didDraw):
  • UIProcess/WebUIClient.h:
3:28 PM Changeset in webkit [69891] by jianli@chromium.org
  • 6 edits in branches/chromium/552

Merge 69883 - FileReader.readAsDataURL should take Blob object
​https://bugs.webkit.org/show_bug.cgi?id=47679

Reviewed by Dmitry Titov.

BUG=59409
TEST=none

TBR=​jianli@chromium.org

3:27 PM Changeset in webkit [69890] by mitz@apple.com
  • 2 edits in trunk/WebCore

Clean up RenderFlexibleBox::applyLineClamp()
​https://bugs.webkit.org/show_bug.cgi?id=47743

Reviewed by Adele Peterson.

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::applyLineClamp):

3:17 PM Changeset in webkit [69889] by ap@apple.com
  • 2 edits in trunk

Correct ChangeLogs.

3:14 PM Changeset in webkit [69888] by rniwa@webkit.org
  • 3 edits
    2 copies in branches/chromium/552

Merge 69865 - 2010-10-15 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Darin Adler.

Crash in WebCore::ApplyStyleCommand::applyBlockStyle
​https://bugs.webkit.org/show_bug.cgi?id=47699

The crash was caused by applyBlockStyle's invalidly assuming that visibleStart and visibleEnd always exist.
Added an early exit to the function when either visibleStart or visibleEnd is null or orphaned.

Test: editing/style/block-style-progress-crash.html

  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyBlockStyle):

2010-10-15 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Darin Adler.

Crash in WebCore::ApplyStyleCommand::applyBlockStyle
​https://bugs.webkit.org/show_bug.cgi?id=47699

Added a test to ensure WebKit does not crash when the body is content editable
and justifying a progress element and '>' following the element to the right.

  • editing/style/block-style-progress-crash-expected.txt: Added.
  • editing/style/block-style-progress-crash.html: Added.

BUG=58832
TBR=​rniwa@webkit.org

3:12 PM Changeset in webkit [69887] by ap@apple.com
  • 3 edits
    5 adds in trunk

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=47736
<rdar://problem/8429396> WebCore cache gets corrupted if revalidation request starts at a wrong time

Test: http/tests/cache/stopped-revalidation.html

  • loader/loader.cpp: (WebCore::Loader::Host::servePendingRequests): Copied logic for revalidation requests from didFail().
3:05 PM Changeset in webkit [69886] by ap@apple.com
  • 6 edits in trunk/WebCore

2010-10-15 Alexey Proskuryakov <​ap@apple.com>

Reviewed by Darin Adler in <​https://bugs.webkit.org/show_bug.cgi?id=47736>.

Add a logging channel for WebCore cache and resource loading.

Test: http/tests/cache/stopped-revalidation.html

  • platform/Logging.cpp:
  • platform/Logging.h: Added a logging channel for Cache and Loader.
  • loader/Cache.cpp: (WebCore::Cache::requestResource): (WebCore::Cache::revalidateResource): (WebCore::Cache::revalidationFailed): (WebCore::Cache::evict):
  • loader/CachedResource.cpp: (WebCore::CachedResource::setResourceToRevalidate): (WebCore::CachedResource::switchClientsToRevalidatedResource): (WebCore::CachedResource::mustRevalidate): Added logging.
  • loader/loader.cpp: (WebCore::Loader::load): Added logging. (WebCore::Loader::scheduleServePendingRequests): Ditto. (WebCore::Loader::requestTimerFired): Ditto. (WebCore::Loader::servePendingRequests): Ditto. (WebCore::Loader::Host::servePendingRequests): Changed logging to use the new channel. (WebCore::Loader::Host::didFinishLoading): Changed logging to use the new channel. (WebCore::Loader::Host::didFail): Added logging.
2:58 PM Changeset in webkit [69885] by Nate Chapin
  • 41 edits
    24 adds in trunk/LayoutTests

2010-10-15 Nate Chapin <Nate Chapin>

Unreviewed, Chromium expectations update.

Update results for ​http://trac.webkit.org/changeset/69872.

  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.checksum:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.checksum:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.checksum:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.checksum:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.checksum:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.checksum:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.checksum:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.checksum:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.checksum:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.checksum:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.png:
  • platform/chromium-mac/svg/custom/repaint-on-constant-size-change-expected.checksum: Added.
  • platform/chromium-mac/svg/custom/repaint-on-constant-size-change-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.png: Added.
  • platform/chromium-win/svg/custom/repaint-on-constant-size-change-expected.checksum: Added.
  • platform/chromium-win/svg/custom/repaint-on-constant-size-change-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.checksum:
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.checksum:
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.checksum:
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.checksum:
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.checksum:
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.checksum:
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.checksum:
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.checksum:
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.checksum:
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.checksum:
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.png:
2:57 PM Changeset in webkit [69884] by noam.rosenthal@nokia.com
  • 7 edits in trunk/WebCore

2010-10-15 No'am Rosenthal <​noam.rosenthal@nokia.com>

Reviewed by Simon Fraser.

Add public functions to serialize TransformOperations.
​https://bugs.webkit.org/show_bug.cgi?id=47728

Added public accessors to the internal data of the TransformOperations.

No new tests. These functions are enablers for WebKit2.

  • platform/graphics/transforms/Matrix3DTransformOperation.h: (WebCore::Matrix3DTransformOperation::matrix):
  • platform/graphics/transforms/MatrixTransformOperation.h: (WebCore::MatrixTransformOperation::matrix):
  • platform/graphics/transforms/PerspectiveTransformOperation.h: (WebCore::PerspectiveTransformOperation::perspective):
  • platform/graphics/transforms/RotateTransformOperation.h: (WebCore::RotateTransformOperation::x): (WebCore::RotateTransformOperation::y): (WebCore::RotateTransformOperation::z):
  • platform/graphics/transforms/SkewTransformOperation.h: (WebCore::SkewTransformOperation::angleX): (WebCore::SkewTransformOperation::angleY):
  • platform/graphics/transforms/TranslateTransformOperation.h: (WebCore::TranslateTransformOperation::x): (WebCore::TranslateTransformOperation::y): (WebCore::TranslateTransformOperation::z):
2:46 PM Changeset in webkit [69883] by jianli@chromium.org
  • 8 edits in trunk

FileReader.readAsDataURL should take Blob object
​https://bugs.webkit.org/show_bug.cgi?id=47679

Reviewed by Dmitry Titov.

WebCore:

Test cases have been added into read-blob-test-cases.js.

  • fileapi/FileReader.idl: Update per the latest File API spec.

LayoutTests:

  • fast/files/read-blob-async-expected.txt:
  • fast/files/resources/read-blob-test-cases.js:

(testReadingSingleTextBlobAsDataURL):
(testReadingSingleTextBlobAsDataURL2):
(testReadingTripleSlicedHybridBlob):

  • fast/files/resources/read-common.js:

(buildBlob):

  • fast/files/workers/worker-read-blob-async-expected.txt:
  • fast/files/workers/worker-read-blob-sync-expected.txt:
2:38 PM Changeset in webkit [69882] by jianli@chromium.org
  • 1 edit in branches/chromium/552/WebKit/chromium/public/WebBlobRegistry.h

Merge 69615 - Unreview. Build fix for chromium.

  • public/WebBlobRegistry.h:

BUG=59391
TEST=none

TBR=​jianli@chromium.org

2:36 PM Changeset in webkit [69881] by jianli@chromium.org
  • 5 edits
    2 copies
    2 deletes in branches/chromium/552/WebKit/chromium

Merge 69611 - [chromium] Update WebBlobData to adapt to BlobData change in terms of
handling string data item.
​https://bugs.webkit.org/show_bug.cgi?id=47423

Reviewed by Darin Fisher.

Also remove unneeded methods in WebBlobData. WebBlobStorageData.* are
also removed since they're not longer needed.

BUG=59391
TEST=none

TBR=​jianli@chromium.org

2:34 PM Changeset in webkit [69880] by abarth@webkit.org
  • 11 edits
    2 adds in trunk/WebCore

2010-10-15 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Move MarkupAccumulator from markup.cpp to its own file
​https://bugs.webkit.org/show_bug.cgi?id=47734

This patch moves the MarkupAccumulator class into its own file.
There's a lot of clean up left to do, but this patch is a step in the
right direction.

No behavior change.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • editing/markup.cpp: (WebCore::elementCannotHaveEndTag):
  • editing/markup.h:
  • editing/MarkupAccumulator.h: Added.
  • editing/MarkupAccumulator.cpp: Added.
2:34 PM Changeset in webkit [69879] by jianli@chromium.org
  • 9 edits in branches/chromium/552/WebCore

Merge 69610 - Fix passing blob data with string data item between threads.
​https://bugs.webkit.org/show_bug.cgi?id=46543

Reviewed by David Levin.

The fix is to use a thread-safe ref-counted Vector<char> to store the
string data. This also makes us be able to store any binary data in it.

I've also fix BlobBuilder and BlobRegistryImpl to avoid some additional
copies to make blob handling faster.

BUG=59391
TEST=none

TBR=​jianli@chromium.org

2:31 PM Changeset in webkit [69878] by andersca@apple.com
  • 5 edits in trunk/WebKit2

Move find indicator window logic to WKView
​https://bugs.webkit.org/show_bug.cgi?id=47739

Reviewed by Sam Weinig.

  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::setFindIndicator):
Call -[WKView _setFindIndicator:fadeOut:].

  • UIProcess/API/mac/WKView.mm:

(-[WKView renewGState]):
Hide the find indicator.

(-[WKView _setFindIndicator:fadeOut:]):
Move the find indicator logic here.

2:05 PM Changeset in webkit [69877] by andersca@apple.com
  • 7 edits in trunk/WebKit2

Hide the find indicator/overlay when necessary
​https://bugs.webkit.org/show_bug.cgi?id=47737

Reviewed by Sam Weinig.

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::invalidateContentsForSlowScroll):
Hide the find indicator.

(WebKit::WebChromeClient::scroll):
Ditto.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
Hide the find indicator and the find overlay.

  • WebProcess/WebPage/FindController.cpp:

(WebKit::FindController::findString):
Always hide all previous find matches. Only clear the selection if the string
not found wasn't empty.

(WebKit::FindController::hideFindUI):
Uninstall the page overlay and hide the find indicator.

(WebKit::FindController::hideFindIndicator):
Rename resetFindIndicator to hideFindIndicator.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::uninstallPageOverlay):
Invalidate the entire page.

1:53 PM Changeset in webkit [69876] by rniwa@webkit.org
  • 9 edits in trunk

2010-10-15 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Darin Adler.

Match the elements supported by execCommand('formatBlock') and queryCommandValue('formatBlock')
​https://bugs.webkit.org/show_bug.cgi?id=47712

Extended queryCommandValue('formatBlock', false, null) to support article, aside, blockquote, dd, dl,
div, dl, dt, dl, footer, header, hgroup, nav, and section. Because this makes isElementForFormatBlockCommand
in Editor.cpp and FormatBlockCommand::isElementToApplyInFormatBlockCommand identical, they are merged and moved
to FormatBlockCommand.cpp

Tests are added to editing/execCommand/query-format-block.html

  • editing/Editor.cpp: Removed isElementForFormatBlockCommand and Editor::elementForFormatBlockCommand.
  • editing/Editor.h:
  • editing/EditorCommand.cpp: (WebCore::executeFormatBlock): Removed the check of tag name; the check is moved into FormatBlockCommand. (WebCore::valueFormatBlock): Calls FormatBlockCommand::elementForFormatBlockCommand.
  • editing/FormatBlockCommand.cpp: (WebCore::isElementForFormatBlock): (WebCore::FormatBlockCommand::FormatBlockCommand): (WebCore::FormatBlockCommand::formatSelection): Added to check the tag name. Exit early if the specified tag name is not what FormatBlock should apply. Set m_didApply true if m_didApply did apply the element. (WebCore::FormatBlockCommand::formatRange): Moved from Editor.cpp. Takes Range* instead of accessing selection directly. (WebCore::FormatBlockCommand::elementForFormatBlockCommand): Moved from Editor.cpp (WebCore::enclosingBlockToSplitTreeTo): Calls isElementForFormatBlock.
  • editing/FormatBlockCommand.h: (WebCore::FormatBlockCommand::didApply): Added.

2010-10-15 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Darin Adler.

Match the elements supported by execCommand('formatBlock') and queryCommandValue('formatBlock')
​https://bugs.webkit.org/show_bug.cgi?id=47712

Added queryCommandValue('formatBlock') tests for support article, aside, blockquote, dd, dl, div,
dl, dt, dl, footer, header, hgroup, nav, and section.

Also added tests to ensure we don't return tag name for a subset of unsupported elements.

  • editing/execCommand/query-format-block-expected.txt:
  • editing/execCommand/script-tests/query-format-block.js: (queryFormatBlock): (selectFirstPosition): (selectMiddleOfHelloWorld):
1:39 PM Changeset in webkit [69875] by Martin Robinson
  • 3 edits in trunk/LayoutTests

2010-10-15 Martin Robinson <​mrobinson@igalia.com>

Rebaseline two GTK+ tests.

  • platform/gtk/fast/forms/mailto/advanced-get-expected.txt:
  • platform/gtk/fast/forms/mailto/advanced-put-expected.txt:
1:02 PM Changeset in webkit [69874] by krit@webkit.org
  • 5 edits
    4 adds in trunk

2010-10-15 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

carto.net Dock example redraws *way* too often
​https://bugs.webkit.org/show_bug.cgi?id=16090

Setting the attributes x, y, width or height shouldn't cause a repaint if the image boundaries don't change.
Added updateFromElement() to RenderSVGImage that checks if the old boundaries match the new boundaries after
setting one of the attributes of above. Mark renderer for layout (and therefore repaint) if the boundaries
differ, do nothing if not.
Also added caching of the repaint rect to avoid multiple calculations.

Test: svg/custom/repaint-on-constant-size-change.svg

  • rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::RenderSVGImage): (WebCore::RenderSVGImage::layout): Update repaint rect on layout. (WebCore::RenderSVGImage::updateFromElement): Check SVGImageElement for boundaries update.
  • rendering/RenderSVGImage.h: (WebCore::RenderSVGImage::repaintRectInLocalCoordinates): Return the cached repaint rect.
  • svg/SVGImageElement.cpp: (WebCore::SVGImageElement::svgAttributeChanged): Call updateFromElement() on changes to x, y, width or height.

2010-10-15 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

carto.net Dock example redraws *way* too often
​https://bugs.webkit.org/show_bug.cgi?id=16090

Added a repaint example to make sure that setting the attributes x, y, width or height
doens't cause a repaint if the boundaries don't change.

  • platform/mac/svg/custom/repaint-on-constant-size-change-expected.checksum: Added.
  • platform/mac/svg/custom/repaint-on-constant-size-change-expected.png: Added.
  • platform/mac/svg/custom/repaint-on-constant-size-change-expected.txt: Added.
  • svg/custom/repaint-on-constant-size-change.svg: Added.
12:57 PM Changeset in webkit [69873] by Martin Robinson
  • 2 edits in trunk/WebCore

2010-10-15 Martin Robinson <​mrobinson@igalia.com>

Build fix for GTK+.

  • platform/network/soup/cache/webkit/soup-cache.h: Do not use PLATFORM(...) macro in a file that does not include config.h
12:46 PM Changeset in webkit [69872] by krit@webkit.org
  • 21 edits
    20 adds in trunk/LayoutTests

2010-10-15 Dirk Schulze <​krit@webkit.org>

Unreviewed rebaseline of Snow Leopard.

Moved current results for SVGFEConvolveMatrixElement to mac-leopard.

  • platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.checksum: Added.
  • platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.png: Added.
  • platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.checksum: Added.
  • platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.png: Added.
  • platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.checksum: Added.
  • platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.png: Added.
  • platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.checksum: Added.
  • platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.png: Added.
  • platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.checksum: Added.
  • platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.png: Added.
  • platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.checksum: Added.
  • platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.png: Added.
  • platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.checksum: Added.
  • platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.png: Added.
  • platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.checksum: Added.
  • platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.png: Added.
  • platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.checksum: Added.
  • platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png: Added.
  • platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.checksum: Added.
  • platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.png:
12:16 PM Changeset in webkit [69871] by andersca@apple.com
  • 6 edits
    1 copy
    1 add in trunk

Add FindIndicatorWindow class
​https://bugs.webkit.org/show_bug.cgi?id=47731

Reviewed by Sam Weinig.

WebCore:

Export symbols needed by the FindIndicator in WebKit2.

  • WebCore.exp.in:

WebKit2:

  • UIProcess/API/mac/FindIndicatorWindow.h: Added.
  • UIProcess/API/mac/FindIndicatorWindow.mm: Added.

(-[WebFindIndicatorView _initWithFindIndicator:WebKit::]):
Initialize the find indicator view.

(-[WebFindIndicatorView drawRect:]):
Ask the find indicator to draw.

(-[WebFindIndicatorView isFlipped]):
Return YES.

(WebKit::FindIndicatorWindow::~FindIndicatorWindow):
Make sure to close the window.

(WebKit::FindIndicatorWindow::setFindIndicator):
Update the find indicator window.

(WebKit::FindIndicatorWindow::closeWindow):
Close and release the window.

  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::setFindIndicator):
Create a find indicator window.

  • WebKit2.xcodeproj/project.pbxproj:

Add new files.

11:48 AM Changeset in webkit [69870] by tony@chromium.org
  • 5 edits
    3 adds in trunk

2010-10-15 Tony Chang <​tony@chromium.org>

Reviewed by Kent Tamura.

[chromium] compile TestNetscapePlugIn on Chromium mac
​https://bugs.webkit.org/show_bug.cgi?id=47633

  • WebKit.gyp: Add a mac specific target for compiling TestNetscapePlugIn

Fix an include dir so we can compile in a chromium checkout.

2010-10-15 Tony Chang <​tony@chromium.org>

Reviewed by Kent Tamura.

[chromium] compile TestNetscapePlugIn on Chromium mac
​https://bugs.webkit.org/show_bug.cgi?id=47633

  • DumpRenderTree/DumpRenderTree.gypi: files to compile
  • DumpRenderTree/TestNetscapePlugIn/main.cpp: Use ifdef because gcc was complaining (NP_GetEntryPoints): (NPP_New): (NPP_Destroy): (NPP_HandleEvent): (NPP_GetValue):
  • DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: Added.
  • DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Added.
  • DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h: Added.
11:42 AM Changeset in webkit [69869] by leandro@webkit.org
  • 3 edits in trunk/WebCore

2010-10-15 Leandro Pereira <​leandro@profusion.mobi>

[EFL] Unreviewed. Build fix.

Add new files needed by the Soup network backend, and #ifdef a
GTK+-port only include in soup-cache.h.

  • CMakeListsEfl.txt:
  • platform/network/soup/cache/webkit/soup-cache.h:
11:30 AM Changeset in webkit [69868] by Darin Adler
  • 73 edits in trunk/WebCore

2010-10-14 Darin Adler <Darin Adler>

Reviewed by Alexey Proskuryakov.

Use more specific types for node pointers, especially when calling node insertion and removal functions
​https://bugs.webkit.org/show_bug.cgi?id=47702

Refactoring. No new tests.

While developing this patch I temporarily removed the node insertion and
removal member functions from the Node class and fixed almost all call sites
so they call it directly on the ContainerNode class, which will be important
once we make the functions non-virtual.

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkSelector):
  • dom/ContainerNode.cpp: (WebCore::ContainerNode::insertBefore): (WebCore::ContainerNode::replaceChild): (WebCore::ContainerNode::appendChild):
  • dom/Document.cpp: (WebCore::Document::caretRangeFromPoint):
  • dom/DynamicNodeList.cpp: (WebCore::DynamicNodeList::itemWithName):
  • dom/Position.cpp: (WebCore::Position::previous): (WebCore::Position::next):
  • dom/Text.cpp: (WebCore::Text::replaceWholeText):
  • dom/TreeWalker.cpp: (WebCore::TreeWalker::firstChild): (WebCore::TreeWalker::lastChild): (WebCore::TreeWalker::previousNode):
  • dom/XMLDocumentParserLibxml2.cpp: (WebCore::XMLDocumentParser::XMLDocumentParser):
  • editing/BreakBlockquoteCommand.cpp: (WebCore::BreakBlockquoteCommand::doApply):
  • editing/CompositeEditCommand.h:
  • editing/DeleteButtonController.cpp: (WebCore::isDeletableElement):
  • editing/IndentOutdentCommand.cpp: (WebCore::IndentOutdentCommand::outdentParagraph):
  • editing/InsertNodeBeforeCommand.cpp: (WebCore::InsertNodeBeforeCommand::doApply):
  • editing/JoinTextNodesCommand.cpp: (WebCore::JoinTextNodesCommand::doApply): (WebCore::JoinTextNodesCommand::doUnapply):
  • editing/MergeIdenticalElementsCommand.cpp: (WebCore::MergeIdenticalElementsCommand::doUnapply):
  • editing/RemoveNodeCommand.cpp: (WebCore::RemoveNodeCommand::doApply): (WebCore::RemoveNodeCommand::doUnapply):
  • editing/RemoveNodeCommand.h:
  • editing/SplitElementCommand.cpp: (WebCore::SplitElementCommand::executeApply):
  • editing/SplitTextNodeCommand.cpp: (WebCore::SplitTextNodeCommand::doApply): (WebCore::SplitTextNodeCommand::doReapply):
  • editing/TextIterator.cpp: (WebCore::parentCrossingShadowBoundaries):
  • editing/htmlediting.cpp: (WebCore::enclosingList):
  • editing/markup.cpp: (WebCore::serializeNodes): (WebCore::ancestorToRetainStructureAndAppearance): (WebCore::createMarkup):
  • html/HTMLAreaElement.cpp: (WebCore::HTMLAreaElement::updateFocusAppearance):
  • html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::rendererIsNeeded):
  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::rendererIsNeeded):
  • html/HTMLFrameSetElement.cpp: (WebCore::HTMLFrameSetElement::attach):
  • html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::insertedIntoTree):
  • html/HTMLLegendElement.cpp: (WebCore::HTMLLegendElement::associatedControl):
  • html/HTMLOptGroupElement.cpp: (WebCore::HTMLOptGroupElement::recalcSelectOptions): (WebCore::HTMLOptGroupElement::ownerSelectElement):
  • html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::ownerSelectElement):
  • html/HTMLTableCellElement.cpp: (WebCore::HTMLTableCellElement::additionalAttributeStyleDecls):
  • html/HTMLTableColElement.cpp: (WebCore::HTMLTableColElement::additionalAttributeStyleDecls):
  • html/HTMLTableElement.cpp: (WebCore::HTMLTableElement::insertRow):
  • html/HTMLTableRowElement.cpp: (WebCore::HTMLTableRowElement::rowIndex):
  • html/HTMLTableSectionElement.cpp: (WebCore::HTMLTableSectionElement::additionalAttributeStyleDecls):
  • page/DOMSelection.cpp: (WebCore::DOMSelection::getRangeAt): (WebCore::DOMSelection::containsNode):
  • rendering/RenderSVGGradientStop.cpp: (WebCore::RenderSVGGradientStop::gradientElement):
  • svg/SVGElement.cpp: (WebCore::SVGElement::ownerSVGElement): (WebCore::SVGElement::viewportElement):
  • svg/SVGFELightElement.cpp: (WebCore::SVGFELightElement::svgAttributeChanged): (WebCore::SVGFELightElement::childrenChanged):
  • svg/SVGFEMergeNodeElement.cpp: (WebCore::SVGFEMergeNodeElement::svgAttributeChanged):
  • svg/SVGFontFaceFormatElement.cpp: (WebCore::SVGFontFaceFormatElement::childrenChanged):
  • svg/SVGFontFaceUriElement.cpp: (WebCore::SVGFontFaceUriElement::childrenChanged):
  • svg/SVGGlyphElement.cpp: (WebCore::SVGGlyphElement::invalidateGlyphCache):
  • svg/SVGHKernElement.cpp: (WebCore::SVGHKernElement::insertedIntoDocument): (WebCore::SVGHKernElement::removedFromDocument):
  • svg/SVGLocatable.cpp: (WebCore::SVGLocatable::nearestViewportElement): (WebCore::SVGLocatable::farthestViewportElement):
  • svg/SVGUseElement.cpp: (WebCore::SVGUseElement::updateContainerOffsets):
  • svg/SVGVKernElement.cpp: (WebCore::SVGVKernElement::insertedIntoDocument): (WebCore::SVGVKernElement::removedFromDocument):
  • svg/animation/SVGSMILElement.cpp: (WebCore::SVGSMILElement::targetElement):
  • wml/WMLDoElement.cpp: (WebCore::WMLDoElement::insertedIntoDocument): (WebCore::WMLDoElement::removedFromDocument):
  • wml/WMLNoopElement.cpp: (WebCore::WMLNoopElement::insertedIntoDocument):
  • wml/WMLOptionElement.cpp: (WebCore::ownerSelectElement):
  • wml/WMLPostfieldElement.cpp: (WebCore::WMLPostfieldElement::insertedIntoDocument): (WebCore::WMLPostfieldElement::removedFromDocument):
  • wml/WMLSetvarElement.cpp: (WebCore::WMLSetvarElement::insertedIntoDocument): (WebCore::WMLSetvarElement::removedFromDocument):
  • wml/WMLTaskElement.cpp: (WebCore::WMLTaskElement::insertedIntoDocument): (WebCore::WMLTaskElement::removedFromDocument):
  • wml/WMLTimerElement.cpp: (WebCore::WMLTimerElement::insertedIntoDocument): (WebCore::WMLTimerElement::removedFromDocument):
  • xml/XPathStep.cpp: (WebCore::XPath::Step::nodesInAxis): Use ContainerNode* for the result of the parentNode function now that it returns a ContainerNode*. In the past it used to return just Node*.
  • dom/ContainerNode.h: Added toContainerNode.
  • dom/Element.h: Use ContainerNode*. Added toElement.
  • dom/Element.cpp: (WebCore::Element::deprecatedCreateContextualFragment): Explcitly cast to HTMLElement* in the case that handles <html> and <body> elements. (WebCore::Element::baseURI): Use ContainerNode*.
  • dom/Node.cpp: (WebCore::Node::markAncestorsWithChildNeedsStyleRecalc): Use ContainerNode*. (WebCore::Node::isDescendantOf): Ditto. (WebCore::Node::createRendererIfNeeded): Ditto. (WebCore::Node::setTextContent): Use already-typecast pointer in a call to appendChild. (WebCore::Node::ancestorElement): Use ContainerNode*.
  • dom/Range.cpp: (WebCore::Range::compareNode): Use ContainerNode*. (WebCore::Range::intersectsNode): Ditto. (WebCore::Range::processContents): Cast to ContainerNode* in a couple cases where we previously checked that the node in question has a child. Any node that returns a non-zero value for firstChild is a ContainerNode. (WebCore::Range::checkNodeBA): Ditto. (WebCore::Range::selectNode): Ditto. (WebCore::Range::surroundContents): Ditto.
  • dom/XMLDocumentParser.cpp: (WebCore::XMLDocumentParser::insertErrorMessageBlock): Rewrote code to use more specific types, document instead of doc, and paragraph instead of par.
  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::removeStyleFromRunBeforeApplyingStyle): Use ContainerNode*. (WebCore::ApplyStyleCommand::replaceWithSpanOrRemoveIfWithoutAttributes): Use replaceElementWithSpanPreservingChildrenAndAttributes; the old function took a Node argument and had Node in its name.
  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::removeNodeAndPruneAncestors): Use ContainerNode. (WebCore::CompositeEditCommand::replaceElementWithSpanPreservingChildrenAndAttributes): Renamed and changed to take HTMLElement. Also use ContainerNode. (WebCore::CompositeEditCommand::prune): Ditto. (WebCore::CompositeEditCommand::breakOutOfEmptyListItem): Ditto. (WebCore::CompositeEditCommand::breakOutOfEmptyMailBlockquotedParagraph): Ditto.
  • editing/ReplaceNodeWithSpanCommand.cpp: (WebCore::ReplaceNodeWithSpanCommand::ReplaceNodeWithSpanCommand): Take an HTMLElement instead of a Node. Call it m_elementToReplace instead of m_node. (WebCore::swapInNodePreservingAttributesAndChildren): Take HTMLElement. (WebCore::ReplaceNodeWithSpanCommand::doApply): Updated for name changes. (WebCore::ReplaceNodeWithSpanCommand::doUnapply): Ditto.
  • editing/ReplaceNodeWithSpanCommand.h: Ditto.
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplacementFragment::ReplacementFragment): Use StyledElement for result of insertFragmentForTestRendering since that's what it returns. (WebCore::ReplacementFragment::removeNode): Use ContainerNode. (WebCore::ReplacementFragment::insertNodeBefore): Ditto. (WebCore::ReplacementFragment::insertFragmentForTestRendering): Return StyledElement. Use HTMLElement for body. (WebCore::ReplacementFragment::restoreTestRenderingNodesToFragment): Take StyledElement. (WebCore::ReplaceSelectionCommand::handleStyleSpans): Use ContainerNode. (WebCore::ReplaceSelectionCommand::copyStyleToChildren): Use HTMLElement for the cloned span, since the clone will be a sspan too. (WebCore::ReplaceSelectionCommand::insertAsListItems): Use ContainerNode since the list item has a child, and that proves it is a ContainerNode.
  • editing/SelectionController.cpp: (WebCore::SelectionController::selectFrameElementInParentIfFullySelected): Use ContainerNode and also removed an unnneded local variable.
  • html/HTMLElement.cpp: (WebCore::HTMLElement::setOuterText): Use ContainerNode. (WebCore::HTMLElement::insertAdjacent): Use ContainerNode and also use && to make the logic a little simpler. (WebCore::contextElementForInsertion): Use ContainerNode. (WebCore::HTMLElement::findFormAncestor): Ditto.
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::removeNode): Use ContainerNode. (WebCore::InspectorDOMAgent::changeTagName): Ditto. (WebCore::InspectorDOMAgent::setOuterHTML): Ditto. (WebCore::InspectorDOMAgent::innerParentNode): Use isDocumentNode instead of nodeType. We should almost never use nodeType inside the engine. (WebCore::InspectorDOMAgent::didInsertDOMNode): Use ContainerNode. (WebCore::InspectorDOMAgent::didRemoveDOMNode): Ditto.
  • wml/WMLOptGroupElement.cpp: Removed unneeded overrides of insertBefore, replaceChild, removeChild, appendChild, and removeChildren functions. Ths already overrides childrenChanged, that is called by all of the above, and it does the same thing these functions did. (WebCore::ownerSelectElement): Use ContainerNode.
  • wml/WMLOptGroupElement.h: Ditto.
11:18 AM Changeset in webkit [69867] by jam@chromium.org
  • 2 edits in branches/chromium/552/WebKit/chromium

2010-10-14 John Abd-El-Malek <​jam@chromium.org>

Reviewed by Tony Chang.

[chromium] null check the widget before sending it data as calling didReceiveData might delete it
​https://bugs.webkit.org/show_bug.cgi?id=47708

  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::committedLoad):
11:12 AM Changeset in webkit [69866] by andersca@apple.com
  • 3 edits in trunk/WebKit2

[GTK] Fix introspection support
​https://bugs.webkit.org/show_bug.cgi?id=47723

Patch by Sergio Villar Senin <​svillar@igalia.com> on 2010-10-15
Reviewed by Martin Robinson.

Added HTTP cache directory to the WebkitGtk+ GIR sources.

  • GNUmakefile.am:
11:05 AM Changeset in webkit [69865] by rniwa@webkit.org
  • 3 edits
    2 adds in trunk

2010-10-15 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Darin Adler.

Crash in WebCore::ApplyStyleCommand::applyBlockStyle
​https://bugs.webkit.org/show_bug.cgi?id=47699

The crash was caused by applyBlockStyle's invalidly assuming that visibleStart and visibleEnd always exist.
Added an early exit to the function when either visibleStart or visibleEnd is null or orphaned.

Test: editing/style/block-style-progress-crash.html

  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyBlockStyle):

2010-10-15 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Darin Adler.

Crash in WebCore::ApplyStyleCommand::applyBlockStyle
​https://bugs.webkit.org/show_bug.cgi?id=47699

Added a test to ensure WebKit does not crash when the body is content editable
and justifying a progress element and '>' following the element to the right.

  • editing/style/block-style-progress-crash-expected.txt: Added.
  • editing/style/block-style-progress-crash.html: Added.
10:53 AM Changeset in webkit [69864] by alex
  • 2 edits in trunk/LayoutTests

2010-10-15 Alejandro G. Castro <​alex@igalia.com>

Unreviewed, skipped flaky tests, added followup bug:
​https://bugs.webkit.org/show_bug.cgi?id=47727

  • platform/gtk/Skipped:
10:37 AM Changeset in webkit [69863] by commit-queue@webkit.org
  • 2 edits in trunk/WebKitTools

2010-10-15 Leandro Pereira <​leandro@profusion.mobi>

Reviewed by Gustavo Noronha Silva.

build-webkit: Should die when make fails when build a CMake project
​https://bugs.webkit.org/show_bug.cgi?id=47726

  • Scripts/webkitdirs.pm: If make fails, die immediately.
10:27 AM Changeset in webkit [69862] by andersca@apple.com
  • 19 edits
    1 copy
    1 add in trunk

Add a FindIndicator class
​https://bugs.webkit.org/show_bug.cgi?id=47635

Reviewed by Sam Weinig.

WebCore:

Make Gradient.h and Generator.h private headers; they're used by WebKit2.

  • WebCore.xcodeproj/project.pbxproj:

WebKit2:

  • Shared/BackingStore.h:

(WebKit::BackingStore::bounds):
New function that returns the bounds of the backing store.

  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::setFindIndicator):
Add stub.

  • UIProcess/API/qt/qwkpage.cpp:

(QWKPagePrivate::setFindIndicator):
Add stub.

  • UIProcess/FindIndicator.cpp: Added.
  • UIProcess/FindIndicator.h:
  • UIProcess/PageClient.h:

Add setFindIndicator client member function.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::setFindIndicator):
Call PageClient::setFindIndicator.

  • UIProcess/WebPageProxy.messages.in:

Add a fadeOut boolean to the message.

  • UIProcess/win/WebView.cpp:

(WebKit::WebView::setFindIndicator):
Add stub.

  • UIProcess/win/WebView.h:
  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebPage/FindController.cpp:

(WebKit::FindController::findString):
(WebKit::FindController::updateFindIndicator):
(WebKit::FindController::resetFindIndicator):

  • WebProcess/WebPage/FindController.h:
  • win/WebKit2.vcproj:
10:12 AM Changeset in webkit [69861] by commit-queue@webkit.org
  • 3 edits
    4 adds in trunk

2010-10-15 Sergio Villar Senin <​svillar@igalia.com>

Reviewed by Gustavo Noronha Silva.

[Soup] Should not ignore body for redirection responses
​https://bugs.webkit.org/show_bug.cgi?id=29299

Tests that 302 redirections without Location do not ignore the
body for redirection purpouses (the body could have a meta
http-equiv=refresh)

  • http/tests/navigation/redirect302-metaredirect-expected.txt: Added.
  • http/tests/navigation/redirect302-metaredirect.html: Added.
  • http/tests/navigation/resources/redirect302-metaredirect.html: Added.
  • http/tests/navigation/resources/redirect302-metaredirect.pl: Added.

2010-10-15 Sergio Villar Senin <​svillar@igalia.com>

Reviewed by Gustavo Noronha Silva.

[Soup] Should not ignore body for redirection responses
​https://bugs.webkit.org/show_bug.cgi?id=29299

Body is now provided to WebKitGtk+ in some redirections (like 302)
because it could be used by servers to perform clunky redirections
for example using http-equiv=REFRESH

Test: http/tests/navigation/redirect302-metaredirect.html

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::gotHeadersCallback): (WebCore::finishedCallback):
10:06 AM Changeset in webkit [69860] by Nate Chapin
  • 2 edits in trunk/LayoutTests

2010-10-15 Nate Chapin <Nate Chapin>

Unreviewed, Chromium expectations tweak.

Add failing tests from r69824 and r69833.

  • platform/chromium/test_expectations.txt:
9:54 AM Changeset in webkit [69859] by jorlow@chromium.org
  • 57 edits in branches/chromium/552

BUG=58992

IndexedDB should fire some errors synchronously
​https://bugs.webkit.org/show_bug.cgi?id=47530

Reviewed by Nate Chapin.

LayoutTests:

  • storage/indexeddb/objectstore-basics-expected.txt:
  • storage/indexeddb/objectstore-basics.html:
  • storage/indexeddb/objectstore-removeobjectstore-expected.txt:
  • storage/indexeddb/objectstore-removeobjectstore.html:

WebCore:

Add dumb plumbing to pass around exception codes.
Utilize that plumbing in the backend to fire some
errors synchronously.
Verify that create/remove* functions are only called
in setVersionTransactions (and raise when not).
Remove plumbing for obsolete IDBDatabase.objectStore
Remove obsolete mode param.

  • storage/IDBCursor.cpp:

(WebCore::IDBCursor::update):
(WebCore::IDBCursor::continueFunction):
(WebCore::IDBCursor::remove):

  • storage/IDBCursor.h:

(WebCore::IDBCursor::continueFunction):

  • storage/IDBCursor.idl:
  • storage/IDBCursorBackendImpl.cpp:

(WebCore::IDBCursorBackendImpl::update):
(WebCore::IDBCursorBackendImpl::continueFunction):
(WebCore::IDBCursorBackendImpl::remove):

  • storage/IDBCursorBackendImpl.h:
  • storage/IDBCursorBackendInterface.h:
  • storage/IDBDatabase.cpp:

(WebCore::IDBDatabase::IDBDatabase):
(WebCore::IDBDatabase::createObjectStore):
(WebCore::IDBDatabase::removeObjectStore):
(WebCore::IDBDatabase::setVersion):
(WebCore::IDBDatabase::transaction):

  • storage/IDBDatabase.h:

(WebCore::IDBDatabase::createObjectStore):
(WebCore::IDBDatabase::transaction):

  • storage/IDBDatabase.idl:
  • storage/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::createObjectStore):
(WebCore::IDBDatabaseBackendImpl::objectStore):
(WebCore::IDBDatabaseBackendImpl::removeObjectStore):
(WebCore::IDBDatabaseBackendImpl::setVersion):
(WebCore::IDBDatabaseBackendImpl::transaction):

  • storage/IDBDatabaseBackendImpl.h:
  • storage/IDBDatabaseBackendInterface.h:
  • storage/IDBFactory.cpp:

(WebCore::IDBFactory::open):

  • storage/IDBFactory.h:

(WebCore::IDBFactory::open):

  • storage/IDBFactory.idl:
  • storage/IDBIndex.cpp:

(WebCore::IDBIndex::openCursor):
(WebCore::IDBIndex::openKeyCursor):
(WebCore::IDBIndex::get):
(WebCore::IDBIndex::getKey):

  • storage/IDBIndex.h:

(WebCore::IDBIndex::openCursor):
(WebCore::IDBIndex::openKeyCursor):

  • storage/IDBIndex.idl:
  • storage/IDBIndexBackendImpl.cpp:

(WebCore::IDBIndexBackendImpl::openCursor):
(WebCore::IDBIndexBackendImpl::openKeyCursor):
(WebCore::IDBIndexBackendImpl::get):
(WebCore::IDBIndexBackendImpl::getKey):

  • storage/IDBIndexBackendImpl.h:
  • storage/IDBIndexBackendInterface.h:
  • storage/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::get):
(WebCore::IDBObjectStore::add):
(WebCore::IDBObjectStore::put):
(WebCore::IDBObjectStore::remove):
(WebCore::IDBObjectStore::createIndex):
(WebCore::IDBObjectStore::index):
(WebCore::IDBObjectStore::removeIndex):
(WebCore::IDBObjectStore::openCursor):

  • storage/IDBObjectStore.h:

(WebCore::IDBObjectStore::add):
(WebCore::IDBObjectStore::put):
(WebCore::IDBObjectStore::createIndex):
(WebCore::IDBObjectStore::openCursor):

  • storage/IDBObjectStore.idl:
  • storage/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::get):
(WebCore::IDBObjectStoreBackendImpl::put):
(WebCore::IDBObjectStoreBackendImpl::remove):
(WebCore::IDBObjectStoreBackendImpl::createIndex):
(WebCore::IDBObjectStoreBackendImpl::index):
(WebCore::IDBObjectStoreBackendImpl::removeIndex):
(WebCore::IDBObjectStoreBackendImpl::openCursor):

  • storage/IDBObjectStoreBackendImpl.h:

(WebCore::IDBObjectStoreBackendImpl::name):
(WebCore::IDBObjectStoreBackendImpl::keyPath):
(WebCore::IDBObjectStoreBackendImpl::autoIncrement):

  • storage/IDBObjectStoreBackendInterface.h:
  • storage/IDBTransaction.cpp:

(WebCore::IDBTransaction::objectStore):

  • storage/IDBTransaction.h:
  • storage/IDBTransactionBackendImpl.cpp:

(WebCore::IDBTransactionBackendImpl::objectStore):

WebKit/chromium:

  • public/WebIDBCursor.h:
  • public/WebIDBDatabase.h:

(WebKit::WebIDBDatabase::transaction):

  • public/WebIDBFactory.h:

(WebKit::WebIDBFactory::open):

  • public/WebIDBObjectStore.h:
  • public/WebIDBTransactionCallbacks.h:
  • src/IDBCursorBackendProxy.cpp:

(WebCore::IDBCursorBackendProxy::update):
(WebCore::IDBCursorBackendProxy::continueFunction):
(WebCore::IDBCursorBackendProxy::remove):

  • src/IDBCursorBackendProxy.h:
  • src/IDBDatabaseProxy.cpp:

(WebCore::IDBDatabaseProxy::createObjectStore):
(WebCore::IDBDatabaseProxy::removeObjectStore):
(WebCore::IDBDatabaseProxy::setVersion):
(WebCore::IDBDatabaseProxy::transaction):

  • src/IDBDatabaseProxy.h:
  • src/IDBIndexBackendProxy.cpp:

(WebCore::IDBIndexBackendProxy::openCursor):
(WebCore::IDBIndexBackendProxy::openKeyCursor):
(WebCore::IDBIndexBackendProxy::get):
(WebCore::IDBIndexBackendProxy::getKey):

  • src/IDBIndexBackendProxy.h:
  • src/IDBObjectStoreProxy.cpp:

(WebCore::IDBObjectStoreProxy::get):
(WebCore::IDBObjectStoreProxy::put):
(WebCore::IDBObjectStoreProxy::remove):
(WebCore::IDBObjectStoreProxy::createIndex):
(WebCore::IDBObjectStoreProxy::index):
(WebCore::IDBObjectStoreProxy::removeIndex):
(WebCore::IDBObjectStoreProxy::openCursor):

  • src/IDBObjectStoreProxy.h:
  • src/WebIDBCursorImpl.cpp:

(WebKit::WebIDBCursorImpl::update):
(WebKit::WebIDBCursorImpl::continueFunction):
(WebKit::WebIDBCursorImpl::remove):

  • src/WebIDBCursorImpl.h:
  • src/WebIDBDatabaseImpl.cpp:

(WebKit::WebIDBDatabaseImpl::createObjectStore):
(WebKit::WebIDBDatabaseImpl::removeObjectStore):
(WebKit::WebIDBDatabaseImpl::setVersion):
(WebKit::WebIDBDatabaseImpl::transaction):

  • src/WebIDBDatabaseImpl.h:
  • src/WebIDBIndexImpl.cpp:

(WebKit::WebIDBIndexImpl::openObjectCursor):
(WebKit::WebIDBIndexImpl::openKeyCursor):
(WebKit::WebIDBIndexImpl::getObject):
(WebKit::WebIDBIndexImpl::getKey):

  • src/WebIDBIndexImpl.h:
  • src/WebIDBObjectStoreImpl.cpp:

(WebKit::WebIDBObjectStoreImpl::get):
(WebKit::WebIDBObjectStoreImpl::put):
(WebKit::WebIDBObjectStoreImpl::remove):
(WebKit::WebIDBObjectStoreImpl::createIndex):
(WebKit::WebIDBObjectStoreImpl::index):
(WebKit::WebIDBObjectStoreImpl::removeIndex):
(WebKit::WebIDBObjectStoreImpl::openCursor):

  • src/WebIDBObjectStoreImpl.h:

Merge 69721 - 2010-10-13 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Nate Chapin.

IndexedDB should fire some errors synchronously
​https://bugs.webkit.org/show_bug.cgi?id=47530

  • storage/indexeddb/objectstore-basics-expected.txt:
  • storage/indexeddb/objectstore-basics.html:
  • storage/indexeddb/objectstore-removeobjectstore-expected.txt:
  • storage/indexeddb/objectstore-removeobjectstore.html:

2010-10-13 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Nate Chapin.

IndexedDB should fire some errors synchronously
​https://bugs.webkit.org/show_bug.cgi?id=47530

Add dumb plumbing to pass around exception codes.
Utilize that plumbing in the backend to fire some
errors synchronously.
Verify that create/remove* functions are only called
in setVersionTransactions (and raise when not).
Remove plumbing for obsolete IDBDatabase.objectStore
Remove obsolete mode param.

  • storage/IDBCursor.cpp: (WebCore::IDBCursor::update): (WebCore::IDBCursor::continueFunction): (WebCore::IDBCursor::remove):
  • storage/IDBCursor.h: (WebCore::IDBCursor::continueFunction):
  • storage/IDBCursor.idl:
  • storage/IDBCursorBackendImpl.cpp: (WebCore::IDBCursorBackendImpl::update): (WebCore::IDBCursorBackendImpl::continueFunction): (WebCore::IDBCursorBackendImpl::remove):
  • storage/IDBCursorBackendImpl.h:
  • storage/IDBCursorBackendInterface.h:
  • storage/IDBDatabase.cpp: (WebCore::IDBDatabase::IDBDatabase): (WebCore::IDBDatabase::createObjectStore): (WebCore::IDBDatabase::removeObjectStore): (WebCore::IDBDatabase::setVersion): (WebCore::IDBDatabase::transaction):
  • storage/IDBDatabase.h: (WebCore::IDBDatabase::createObjectStore): (WebCore::IDBDatabase::transaction):
  • storage/IDBDatabase.idl:
  • storage/IDBDatabaseBackendImpl.cpp: (WebCore::IDBDatabaseBackendImpl::createObjectStore): (WebCore::IDBDatabaseBackendImpl::objectStore): (WebCore::IDBDatabaseBackendImpl::removeObjectStore): (WebCore::IDBDatabaseBackendImpl::setVersion): (WebCore::IDBDatabaseBackendImpl::transaction):
  • storage/IDBDatabaseBackendImpl.h:
  • storage/IDBDatabaseBackendInterface.h:
  • storage/IDBFactory.cpp: (WebCore::IDBFactory::open):
  • storage/IDBFactory.h: (WebCore::IDBFactory::open):
  • storage/IDBFactory.idl:
  • storage/IDBIndex.cpp: (WebCore::IDBIndex::openCursor): (WebCore::IDBIndex::openKeyCursor): (WebCore::IDBIndex::get): (WebCore::IDBIndex::getKey):
  • storage/IDBIndex.h: (WebCore::IDBIndex::openCursor): (WebCore::IDBIndex::openKeyCursor):
  • storage/IDBIndex.idl:
  • storage/IDBIndexBackendImpl.cpp: (WebCore::IDBIndexBackendImpl::openCursor): (WebCore::IDBIndexBackendImpl::openKeyCursor): (WebCore::IDBIndexBackendImpl::get): (WebCore::IDBIndexBackendImpl::getKey):
  • storage/IDBIndexBackendImpl.h:
  • storage/IDBIndexBackendInterface.h:
  • storage/IDBObjectStore.cpp: (WebCore::IDBObjectStore::get): (WebCore::IDBObjectStore::add): (WebCore::IDBObjectStore::put): (WebCore::IDBObjectStore::remove): (WebCore::IDBObjectStore::createIndex): (WebCore::IDBObjectStore::index): (WebCore::IDBObjectStore::removeIndex): (WebCore::IDBObjectStore::openCursor):
  • storage/IDBObjectStore.h: (WebCore::IDBObjectStore::add): (WebCore::IDBObjectStore::put): (WebCore::IDBObjectStore::createIndex): (WebCore::IDBObjectStore::openCursor):
  • storage/IDBObjectStore.idl:
  • storage/IDBObjectStoreBackendImpl.cpp: (WebCore::IDBObjectStoreBackendImpl::get): (WebCore::IDBObjectStoreBackendImpl::put): (WebCore::IDBObjectStoreBackendImpl::remove): (WebCore::IDBObjectStoreBackendImpl::createIndex): (WebCore::IDBObjectStoreBackendImpl::index): (WebCore::IDBObjectStoreBackendImpl::removeIndex): (WebCore::IDBObjectStoreBackendImpl::openCursor):
  • storage/IDBObjectStoreBackendImpl.h: (WebCore::IDBObjectStoreBackendImpl::name): (WebCore::IDBObjectStoreBackendImpl::keyPath): (WebCore::IDBObjectStoreBackendImpl::autoIncrement):
  • storage/IDBObjectStoreBackendInterface.h:
  • storage/IDBTransaction.cpp: (WebCore::IDBTransaction::objectStore):
  • storage/IDBTransaction.h:
  • storage/IDBTransactionBackendImpl.cpp: (WebCore::IDBTransactionBackendImpl::objectStore):

2010-10-13 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Nate Chapin.

IndexedDB should fire some errors synchronously
​https://bugs.webkit.org/show_bug.cgi?id=47530

  • public/WebIDBCursor.h:
  • public/WebIDBDatabase.h: (WebKit::WebIDBDatabase::transaction):
  • public/WebIDBFactory.h: (WebKit::WebIDBFactory::open):
  • public/WebIDBObjectStore.h:
  • public/WebIDBTransactionCallbacks.h:
  • src/IDBCursorBackendProxy.cpp: (WebCore::IDBCursorBackendProxy::update): (WebCore::IDBCursorBackendProxy::continueFunction): (WebCore::IDBCursorBackendProxy::remove):
  • src/IDBCursorBackendProxy.h:
  • src/IDBDatabaseProxy.cpp: (WebCore::IDBDatabaseProxy::createObjectStore): (WebCore::IDBDatabaseProxy::removeObjectStore): (WebCore::IDBDatabaseProxy::setVersion): (WebCore::IDBDatabaseProxy::transaction):
  • src/IDBDatabaseProxy.h:
  • src/IDBIndexBackendProxy.cpp: (WebCore::IDBIndexBackendProxy::openCursor): (WebCore::IDBIndexBackendProxy::openKeyCursor): (WebCore::IDBIndexBackendProxy::get): (WebCore::IDBIndexBackendProxy::getKey):
  • src/IDBIndexBackendProxy.h:
  • src/IDBObjectStoreProxy.cpp: (WebCore::IDBObjectStoreProxy::get): (WebCore::IDBObjectStoreProxy::put): (WebCore::IDBObjectStoreProxy::remove): (WebCore::IDBObjectStoreProxy::createIndex): (WebCore::IDBObjectStoreProxy::index): (WebCore::IDBObjectStoreProxy::removeIndex): (WebCore::IDBObjectStoreProxy::openCursor):
  • src/IDBObjectStoreProxy.h:
  • src/WebIDBCursorImpl.cpp: (WebKit::WebIDBCursorImpl::update): (WebKit::WebIDBCursorImpl::continueFunction): (WebKit::WebIDBCursorImpl::remove):
  • src/WebIDBCursorImpl.h:
  • src/WebIDBDatabaseImpl.cpp: (WebKit::WebIDBDatabaseImpl::createObjectStore): (WebKit::WebIDBDatabaseImpl::removeObjectStore): (WebKit::WebIDBDatabaseImpl::setVersion): (WebKit::WebIDBDatabaseImpl::transaction):
  • src/WebIDBDatabaseImpl.h:
  • src/WebIDBIndexImpl.cpp: (WebKit::WebIDBIndexImpl::openObjectCursor): (WebKit::WebIDBIndexImpl::openKeyCursor): (WebKit::WebIDBIndexImpl::getObject): (WebKit::WebIDBIndexImpl::getKey):
  • src/WebIDBIndexImpl.h:
  • src/WebIDBObjectStoreImpl.cpp: (WebKit::WebIDBObjectStoreImpl::get): (WebKit::WebIDBObjectStoreImpl::put): (WebKit::WebIDBObjectStoreImpl::remove): (WebKit::WebIDBObjectStoreImpl::createIndex): (WebKit::WebIDBObjectStoreImpl::index): (WebKit::WebIDBObjectStoreImpl::removeIndex): (WebKit::WebIDBObjectStoreImpl::openCursor):
  • src/WebIDBObjectStoreImpl.h:

TBR=​jorlow@chromium.org

9:48 AM Changeset in webkit [69858] by commit-queue@webkit.org
  • 4 edits in trunk

2010-10-15 Sergio Villar Senin <​svillar@igalia.com>

Reviewed by Martin Robinson.

[GTK] Fix introspection support
​https://bugs.webkit.org/show_bug.cgi?id=47723

Added HTTP cache directory to the WebkitGtk+ GIR sources.

  • GNUmakefile.am:

2010-10-15 Sergio Villar Senin <​svillar@igalia.com>

Reviewed by Martin Robinson.

[GTK] Fix introspection support
​https://bugs.webkit.org/show_bug.cgi?id=47723

WebKitSoupCacheType was incorrectly registered twice. Renamed to
WebKitSoupCacheTypeType for the enumerated type.

  • platform/network/soup/cache/webkit/soup-cache.c: (webkit_soup_cache_type_get_type):
9:43 AM WebKitGtkLayoutTests edited by kov@webkit.org
(diff)
9:30 AM Changeset in webkit [69857] by commit-queue@webkit.org
  • 5 edits
    3 deletes in trunk

2010-10-15 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r69809.
​http://trac.webkit.org/changeset/69809
​https://bugs.webkit.org/show_bug.cgi?id=47725

Broke chromium mac compile (Requested by japhet on #webkit).

  • WebKit.gyp:

2010-10-15 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r69809.
​http://trac.webkit.org/changeset/69809
​https://bugs.webkit.org/show_bug.cgi?id=47725

Broke chromium mac compile (Requested by japhet on #webkit).

  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/TestNetscapePlugIn/main.cpp: (NP_GetEntryPoints): (NPP_New): (NPP_Destroy): (NPP_HandleEvent): (NPP_GetValue):
  • DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: Removed.
  • DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Removed.
  • DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h: Removed.
9:27 AM Changeset in webkit [69856] by commit-queue@webkit.org
  • 3 edits in trunk/WebKit/qt

2010-10-15 Qi Zhang <​qi.2.zhang@nokia.com>

Reviewed by Andreas Kling.

[Qt] window.close() doesn't work in qt
​https://bugs.webkit.org/show_bug.cgi?id=46186

Introduce new attribute in QWebSettings to trigger "setAllowScriptsToCloseWindow"

  • Api/qwebsettings.cpp: (QWebSettingsPrivate::apply):
  • Api/qwebsettings.h:
8:56 AM Changeset in webkit [69855] by Martin Robinson
  • 3 edits
    2 copies
    1 add in trunk/LayoutTests

2010-10-15 Martin Robinson <​mrobinson@igalia.com>

Fix my rebaseline sanfu.

  • fast/forms/mailto/advanced-get.html:
  • fast/forms/mailto/advanced-put.html:
  • platform/gtk/fast/forms/mailto/advanced-get-expected.txt: Copied from LayoutTests/fast/forms/mailto/advanced-get-expected.txt.
  • platform/gtk/fast/forms/mailto/advanced-put-expected.txt: Copied from LayoutTests/fast/forms/mailto/advanced-put-expected.txt.
8:34 AM Changeset in webkit [69854] by Martin Robinson
  • 3 edits in trunk/LayoutTests

2010-10-15 Martin Robinson <​mrobinson@igalia.com>

Rebaseline a few other failing tests. They differ because
dumpAsText output depends on whether or not certain content
reaches the edge of the view and wraps.

  • fast/forms/mailto/advanced-get.html:
  • fast/forms/mailto/advanced-put.html:
8:20 AM Changeset in webkit [69853] by loislo@chromium.org
  • 7 edits in trunk/WebCore

2010-10-15 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: extract consoleMessages related stuff from populateScriptObjects into separate function.

This is a part of Inspector protocol sanitization activity.
We want to populate console messages only if it is required by frontend.

​https://bugs.webkit.org/show_bug.cgi?id=46802

  • inspector/Inspector.idl:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::setConsoleMessagesEnabled): (WebCore::InspectorController::addConsoleMessage): (WebCore::InspectorController::disconnectFrontend): (WebCore::InspectorController::populateScriptObjects):
  • inspector/InspectorController.h:
  • inspector/InspectorState.cpp: (WebCore::InspectorState::InspectorState):
  • inspector/InspectorState.h:
  • inspector/front-end/inspector.js: (WebInspector.doLoadedDone):
8:11 AM Changeset in webkit [69852] by jberlin@webkit.org
  • 2 edits in trunk/WebKit/win

Windows build fix. Unreviewed.

  • WebCoreSupport/WebInspectorClient.cpp:

Add a missing include.

6:56 AM Changeset in webkit [69851] by andreas.kling@nokia.com
  • 2 edits in trunk/WebKit/qt

2010-10-15 Andreas Kling <​kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Unbreak scrolling the ContentsLayer with QWebView

r69777 broke scrolling the contents layer in QWebView by not restoring
the painter clip after painting each part of the dirty region.

  • Api/qwebframe.cpp: (QWebFramePrivate::renderRelativeCoords):
5:29 AM Changeset in webkit [69850] by Nikolas Zimmermann
  • 17 edits in trunk

2010-10-15 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Replace some String::format() usages by StringConcatenate in WebKit
​https://bugs.webkit.org/show_bug.cgi?id=47714

  • wtf/text/StringConcatenate.h: Add UChar specific StringTypeAdapter, to accept single UChars in makeString().

2010-10-15 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Replace some String::format() usages by StringConcatenate in WebKit
​https://bugs.webkit.org/show_bug.cgi?id=47714

  • src/BackForwardListClientImpl.cpp: (WebKit::BackForwardListClientImpl::itemAtIndex):
  • src/DebuggerAgentManager.cpp: (WebKit::DebuggerAgentManager::debugDetach):
  • src/LocalizedStrings.cpp: (WebCore::imageTitle):
  • src/WebPageSerializer.cpp: (WebKit::WebPageSerializer::generateMetaCharsetDeclaration): (WebKit::WebPageSerializer::generateBaseTagDeclaration):

2010-10-15 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Replace some String::format() usages by StringConcatenate in WebKit
​https://bugs.webkit.org/show_bug.cgi?id=47714

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchDidFailLoad):
  • webkit/webkitwebsettings.cpp: (webkitOSVersion): (webkitUserAgent):

2010-10-15 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Replace some String::format() usages by StringConcatenate in WebKit
​https://bugs.webkit.org/show_bug.cgi?id=47714

  • WebCoreSupport/WebInspectorClient.cpp: (WebInspectorFrontendClient::updateWindowTitle):
  • WebView.cpp: (WebView::standardUserAgentWithApplicationName): (osVersion):

2010-10-15 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Replace some String::format() usages by StringConcatenate in WebKit
​https://bugs.webkit.org/show_bug.cgi?id=47714

  • WebCoreSupport/PlatformStrategiesWinCE.cpp: (PlatformStrategiesWinCE::imageTitle): (PlatformStrategiesWinCE::multipleFileUploadText):

2010-10-15 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Replace some String::format() usages by StringConcatenate in WebKit
​https://bugs.webkit.org/show_bug.cgi?id=47714

  • WebCoreSupport/FrameLoaderClientEfl.cpp: (WebCore::agentOS):
5:23 AM Changeset in webkit [69849] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-10-15 Ryuan Choi <​ryuan.choi@samsung.com>

Reviewed by Nikolas Zimmermann.

[EFL] REGRESSION(69798) UCHAR can't be converted to String.
​https://bugs.webkit.org/show_bug.cgi?id=47698

Create String value using String(const char*, 1) instead of operator[].

No tests. No functionality changed.

  • platform/efl/PlatformKeyboardEventEfl.cpp: (WebCore::createWindowsKeyMap):
3:39 AM Changeset in webkit [69848] by commit-queue@webkit.org
  • 3 edits in trunk/WebCore

2010-10-15 Sergio Villar Senin <​svillar@igalia.com>

Reviewed by Xan Lopez.

[GTK] Do a stricter check for invalid base64 dataURLs
​https://bugs.webkit.org/show_bug.cgi?id=47717

Restore the strict base64 decoding we added in
​https://bugs.webkit.org/show_bug.cgi?id=44261 and then rolled back
in ​https://bugs.webkit.org/show_bug.cgi?id=47666 due to a failing
test. The actual issue was that we were not finishing the load of
the resource gracefully when an error happened.

Loading invalid base64-encoded data:// URLs are now handled
properly.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::parseDataUrl):
  • platform/network/soup/cache/soup-request-data.c: (webkit_soup_request_data_send):
2:04 AM Changeset in webkit [69847] by loislo@chromium.org
  • 2 edits in trunk/JavaScriptCore

2010-10-15 Ilya Tikhonovsky <​loislo@chromium.org>

Unreviewed build fix for Debug Leopard which is failng to compile after r69842.

  • yarr/RegexInterpreter.cpp: (JSC::Yarr::ByteCompiler::emitDisjunction):
1:47 AM Changeset in webkit [69846] by alex
  • 3 edits in trunk/LayoutTests

2010-10-15 Alejandro G. Castro <​alex@igalia.com>

Rebaseline some failing tests to the former results, apparently
they are flaky, skip if they continue failing.

  • platform/gtk/mathml/presentation/fenced-expected.txt:
  • platform/gtk/mathml/presentation/subsup-expected.txt:
1:33 AM Changeset in webkit [69845] by alex
  • 3 edits in trunk/WebCore

2010-10-15 Alejandro G. Castro <​alex@igalia.com>

Reviewed by Martin Robinson.

compile fail with gtk >= 2.22
​https://bugs.webkit.org/show_bug.cgi?id=47483

  • platform/graphics/gtk/FontGtk.cpp: Removed the shrink operation, it was added long time ago and currently it is not adding any real area to the clip vertically, actually the gtk3 shrink version did not work. (WebCore::Font::drawComplexText):
  • platform/gtk/gtk2drawing.c: Undef the deprecation flags, this file is full of gtk2 stuff, and it does not seem interesting to upgrade because we are already creating a new version of the file for gtk3.
1:31 AM Changeset in webkit [69844] by loislo@chromium.org
  • 15 edits
    2 adds in trunk

2010-10-14 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: inspector settings/properties/states management
should be extracted into separate class.

We have a lot of flags/values in InspectorController.
Some flags are persisting into profile.
Others are part of inspector state for frontend.
All these flags should keep their values after navigation.
It'd be better to extract these flags/values into separate
class which will care about theirs lifetime.

​https://bugs.webkit.org/show_bug.cgi?id=47275

WebCore:

  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.exp.in:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::inspectorStartsAttached): (WebCore::InspectorController::setInspectorStartsAttached): (WebCore::InspectorController::setInspectorAttachedHeight): (WebCore::InspectorController::inspectorAttachedHeight): (WebCore::InspectorController::searchingForNodeInPage): (WebCore::InspectorController::resourceTrackingEnabled): (WebCore::InspectorController::saveApplicationSettings): (WebCore::InspectorController::getInspectorState): (WebCore::InspectorController::restoreInspectorStateFromCookie): (WebCore::InspectorController::getSettings): (WebCore::InspectorController::storeLastActivePanel): (WebCore::InspectorController::mouseDidMoveOverElement): (WebCore::InspectorController::handleMousePress): (WebCore::InspectorController::setSearchingForNode): (WebCore::InspectorController::setMonitoringXHREnabled): (WebCore::InspectorController::showPanel): (WebCore::InspectorController::disconnectFrontend): (WebCore::InspectorController::populateScriptObjects): (WebCore::InspectorController::restoreDebugger): (WebCore::InspectorController::restoreProfiler): (WebCore::InspectorController::getTrackedResource): (WebCore::InspectorController::didLoadResourceFromMemoryCache): (WebCore::InspectorController::identifierForInitialRequest): (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest): (WebCore::InspectorController::scriptImported): (WebCore::InspectorController::setResourceTrackingEnabled): (WebCore::InspectorController::ensureSettingsLoaded): (WebCore::InspectorController::startTimelineProfiler): (WebCore::InspectorController::stopTimelineProfiler): (WebCore::InspectorController::enableProfiler): (WebCore::InspectorController::disableProfiler): (WebCore::InspectorController::enableDebuggerFromFrontend): (WebCore::InspectorController::disableDebugger): (WebCore::InspectorController::loadBreakpoints): (WebCore::InspectorController::saveBreakpoints):
  • inspector/InspectorController.h:
  • inspector/InspectorFrontendClientLocal.cpp: (WebCore::InspectorFrontendClientLocal::changeAttachedWindowHeight): (WebCore::InspectorFrontendClientLocal::restoreAttachedWindowHeight):
  • inspector/InspectorState.cpp: Added. (WebCore::InspectorState::InspectorState): (WebCore::InspectorState::restoreFromInspectorCookie): (WebCore::InspectorState::generateStateObjectForFrontend): (WebCore::InspectorState::loadFromSettings): (WebCore::InspectorState::updateCookie): (WebCore::InspectorState::setValue): (WebCore::InspectorState::getBoolean): (WebCore::InspectorState::getString): (WebCore::InspectorState::getLong): (WebCore::InspectorState::registerBoolean): (WebCore::InspectorState::registerString): (WebCore::InspectorState::registerLong): (WebCore::InspectorState::Property::create):
  • inspector/InspectorState.h: Added. (WebCore::InspectorState::setBoolean): (WebCore::InspectorState::setString): (WebCore::InspectorState::setLong):

WebKit/mac:

  • WebCoreSupport/WebInspectorClient.mm: (-[WebInspectorWindowController showWindow:]): (-[WebInspectorWindowController attach]): (-[WebInspectorWindowController detach]):

WebKit/win:

  • WebCoreSupport/WebInspectorClient.cpp: (WebInspectorFrontendClient::attachWindow): (WebInspectorFrontendClient::detachWindow): (WebInspectorFrontendClient::showWindowWithoutNotifications):
1:20 AM Changeset in webkit [69843] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-10-15 Adam Barth <​abarth@webkit.org>

Reviewed by Adam Barth.

test-webkitpy fails on Linux
​https://bugs.webkit.org/show_bug.cgi?id=47713

The old code failed on Linux because the MacPort tries to read
something out of platform that doesn't make sense on Linux.

  • Scripts/webkitpy/tool/mocktool.py:
12:59 AM Changeset in webkit [69842] by zoltan@webkit.org
  • 2 edits in trunk/JavaScriptCore

The parenthetical assertion checking isn't working in some cases with YARR
Interpreter
​https://bugs.webkit.org/show_bug.cgi?id=46893

Patch by Peter Varga <​pvarga@inf.u-szeged.hu> on 2010-10-15
Reviewed by Gavin Barraclough.

Calculate the countToCheck value of a TypeParentheticalAssertion by
subtracting the number of characters which follows
a TypeParentheticalAssertion term with the number of characters which should
be matched by terms which are contained
in the TypeParentheticalAssertion term (minimumSize).

  • yarr/RegexInterpreter.cpp:

(JSC::Yarr::ByteCompiler::emitDisjunction):

Oct 14, 2010:

11:52 PM Changeset in webkit [69841] by commit-queue@webkit.org
  • 2 edits
    2 adds in trunk/WebCore

2010-10-14 Jia Pu <​jpu@apple.com>

Reviewed by Adele Peterson.

REGRESSION (r69548): Autocorrections are applied even after typing further characters in the word
​https://bugs.webkit.org/show_bug.cgi?id=47689
<rdar://problem/8552250>

The test requires using setTimeout(). So we put it in manual-tests.

  • editing/Editor.cpp: (WebCore::Editor::markMisspellingsAfterTypingToPosition): Relpace release() with clear(). (WebCore::Editor::startCorrectionPanelTimer): Release previously set correction range before start timer for next autocorrection check.
  • manual-tests/autocorrection: Added.
  • manual-tests/autocorrection/autocorrection-cancelled-by-typing-1.html: Added.
11:33 PM Changeset in webkit [69840] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit/chromium

2010-10-14 Wei Jia <​wjia@chromium.org>

Reviewed by Darin Fisher.

Retrieve info of lock keys from stashed currentInputEvent which
is stored by chromium when it passes input event to WebCore.
Retrieving only when stashed event is a keyboard event, which
means synthetic KeyboardEvent inherits lock key state from real
keyboard event.
​https://bugs.webkit.org/show_bug.cgi?id=46518

  • src/WebPluginContainerImpl.cpp: (WebKit::WebPluginContainerImpl::handleKeyboardEvent):
11:31 PM Changeset in webkit [69839] by Csaba Osztrogonác
  • 2 edits in trunk/WebKitTools

2010-10-14 Balazs Kelemen <​kbalazs@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] WTR is sloooow
​https://bugs.webkit.org/show_bug.cgi?id=47695

  • WebKitTestRunner/qt/TestControllerQt.cpp: Change the timer interval of RunUntilConditionLoop from 50 milliseconds to 1 to avoid wasting time after the test had been finished.
11:17 PM Changeset in webkit [69838] by Martin Robinson
  • 6 edits in trunk/LayoutTests

2010-10-14 Martin Robinson <​mrobinson@igalia.com>

Rebaseline some failing tests.

  • platform/gtk/fast/events/keydown-1-expected.txt:
  • platform/gtk/fast/forms/input-placeholder-focus-twice-expected.txt:
  • platform/gtk/fast/forms/textfield-focus-ring-expected.txt:
  • platform/gtk/mathml/presentation/fenced-expected.txt:
  • platform/gtk/mathml/presentation/subsup-expected.txt:
10:14 PM Changeset in webkit [69837] by levin@chromium.org
  • 2 edits in trunk/WebKitSite

Add guideline for constructors doing implicit type conversion to coding style.
​https://bugs.webkit.org/show_bug.cgi?id=47646

Reviewed by Darin Adler.

  • coding/coding-style.html:
9:09 PM Changeset in webkit [69836] by rniwa@webkit.org
  • 15 edits
    4 adds in trunk

2010-10-14 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Tony Chang and Darin Adler.

execCommand FormatBlock creates lots of blockquotes
​https://bugs.webkit.org/show_bug.cgi?id=19795

The bug was caused by WebKit's not reusing the block node added by previous iteration
and its inserting block node at wrong places.

Fixed the bug by rewriting FormatBlockCommand::formatRange. New code resembles that of
IndentOutdentCommand::indentIntoBlockquote. The difference between two is that formatRange
avoids the existing block elements when replacing blocks and it also adds a placeholder
when removing the existing block caused paragraphs to collapse.

Also fixed a bug in moveParagraphWithClones where erroneous br is added to the start of
the block element to which the paragraph is moved if the block element is the start of a paragraph
and not the end of a paragraph.

Tests: editing/execCommand/format-block-multiple-paragraphs.html

editing/execCommand/format-block-table.html

  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::moveParagraphWithClones): No longer adds erroneous br.
  • editing/EditorCommand.cpp: (WebCore::executeFormatBlock):
  • editing/FormatBlockCommand.cpp: (WebCore::FormatBlockCommand::formatRange): Rewritten; see above. (WebCore::FormatBlockCommand::isElementToApplyInFormatBlockCommand): Renamed from validBlockElement and moved from htmlediting.cpp. (WebCore::enclosingBlockToSplitTreeTo): Added.
  • editing/FormatBlockCommand.h:
  • editing/VisiblePosition.cpp: (WebCore::enclosingBlockFlowElement): Changed the return type to Element*
  • editing/VisiblePosition.h:

2010-10-14 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Tony Chang and Darin Adler.

execCommand FormatBlock creates lots of blockquotes
​https://bugs.webkit.org/show_bug.cgi?id=19795

Added tests to ensure WebKit does not add multiple block elements when applying block element to
multiple paragraphs. Also added a test to ensure formatBlock works with tables.

  • fast/html/nav-element-expected.txt: Preserved new lines and removed redundant br.
  • editing/execCommand/format-block-expected.txt: Preserved span and removed erroneous br.
  • editing/execCommand/format-block-from-range-selection-expected.txt: Merged dl's and removed erroneous br.
  • editing/execCommand/format-block-multiple-paragraphs-expected.txt: Added.
  • editing/execCommand/format-block-multiple-paragraphs.html: Added.
  • editing/execCommand/format-block-table-expected.txt: Added.
  • editing/execCommand/format-block-table.html: Added.
  • editing/execCommand/format-block-with-braces-expected.txt: Removed erroneous br.
8:08 PM Changeset in webkit [69835] by kinuko@chromium.org
  • 2 edits in trunk/LayoutTests

2010-10-14 Kinuko Yasuda <​kinuko@chromium.org>

Unreviewed, asssigned a bug number to failing filesystem tests.

  • platform/chromium/drt_expectations.txt:
7:54 PM Changeset in webkit [69834] by jam@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-10-14 John Abd-El-Malek <​jam@chromium.org>

Reviewed by Tony Chang.

[chromium] null check the widget before sending it data as calling didReceiveData might delete it
​https://bugs.webkit.org/show_bug.cgi?id=47708

  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::committedLoad):
7:45 PM Changeset in webkit [69833] by commit-queue@webkit.org
  • 7 edits in trunk

2010-10-14 Nathan Vander Wilt <​nate@andyet.net>

Reviewed by Darin Adler.

Added parser for ECMAScript 5 standard date format, so Date.parse can handle RFC 3339 timestamps: ​https://bugs.webkit.org/show_bug.cgi?id=44632

  • runtime/DateConversion.cpp: (JSC::parseDate):
  • wtf/DateMath.cpp: (WTF::ymdhmsToSeconds): (WTF::parseES5DateFromNullTerminatedCharacters):
  • wtf/DateMath.h:

2010-10-14 Nathan Vander Wilt <​nate@andyet.net>

Reviewed by Darin Adler.

Added tests for ​https://bugs.webkit.org/show_bug.cgi?id=44632

  • fast/js/date-parse-test-expected.txt:
  • fast/js/script-tests/date-parse-test.js: (testDateParseExact):
6:54 PM Changeset in webkit [69832] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-10-14 Eric Seidel <​eric@webkit.org>

Unreviewed, just fixing an exception seen on the commit-queue.

I should have unit tested this function before.

  • Scripts/webkitpy/tool/commands/queues.py:
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
6:50 PM Changeset in webkit [69831] by jschuh@chromium.org
  • 7 edits
    2 adds in trunk

2010-10-14 Justin Schuh <​jschuh@chromium.org>

Reviewed by James Robinson.

Crash in HTMLTextFormControlElement::selection()
​https://bugs.webkit.org/show_bug.cgi?id=47522

Patch by Ryosuke Niwa <​rniwa@webkit.org>

The bug was caused by our triggering layout inside RenderTextControl::selection.
Fixed it by changing the return type of RenderTextControl::selection to PassRefPtr<Range> from VisibleSelection.

Test: fast/forms/render-text-crash.html

  • editing/Editor.cpp: (WebCore::Editor::selectionForCommand): Calls HTMLTextFormControlElement::selection.
  • html/HTMLFormControlElement.cpp: (WebCore::HTMLTextFormControlElement::selection): Calls RenderTextControl::selection.
  • html/HTMLFormControlElement.h:
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::selection): Changed the return type.
  • rendering/RenderTextControl.h:

2010-10-14 Justin Schuh <​jschuh@chromium.org>

Reviewed by James Robinson.

Crash in HTMLTextFormControlElement::selection()
​https://bugs.webkit.org/show_bug.cgi?id=47522

Patch by Ryosuke Niwa <​rniwa@webkit.org>

Added a test to ensure WebKit does not crash when moving selection between input elements.

  • fast/forms/render-text-crash-expected.txt: Added.
  • fast/forms/render-text-crash.html: Added.
6:10 PM Changeset in webkit [69830] by jamesr@google.com
  • 2 edits in branches/chromium/552/WebCore

Merge 69529 - 2010-10-11 James Robinson <​jamesr@chromium.org>

Reviewed by Kenneth Russell.

[chromium] DRT crash in fast/canvas tests w/accel 2D canvas due to NULL DrawingBuffer
​https://bugs.webkit.org/show_bug.cgi?id=47241

Avoid initializing accelerated graphics objects on CanvasRenderingContext2D
if there is no drawingContext associated with the canvas.

Test: fast/canvas/access-zero-sized-canvas.html

fast/canvas/canvas-skia-excessive-size.html
fast/canvas/toDataURL-noData.html

with --accelerated-compositing and --accelerated-2d-canvas

  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::CanvasRenderingContext2D): (WebCore::CanvasRenderingContext2D::reset):

TBR=​jamesr@google.com

5:51 PM Changeset in webkit [69829] by eric@webkit.org
  • 18 edits in trunk/WebKitTools

2010-10-14 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

commit-queue should not fail patches due to flaky tests
​https://bugs.webkit.org/show_bug.cgi?id=47647

This patch makes it so that the *same* flaky test has to fail
twice in a row to have a false negative from a flaky test.

If different flaky tests fail (or if a test fails and then passes
in a second run) then we will warn in the bug that we encountered
a flaky test.

This patch grew to include moving port off of steps onto tool
(which Adam wrote and then I integrated), as well as removing the
use of tool from CommitQueueTask.

  • Scripts/webkitpy/common/config/ports.py:
    • Added a layout_test_results_path method. This covers old-run-webkit-tests but doesn't cover NRWT. This is probably not the long term solution, but putting this knowledge on port makes more sense than in LayoutTestResults.
  • Scripts/webkitpy/common/net/buildbot.py:
    • LayoutTestResults shouldn't know how to fetch from the network, make the Build code do that instead.
  • Scripts/webkitpy/common/net/buildbot_unittest.py:
    • Code style fix.
  • Scripts/webkitpy/common/net/layouttestresults.py:
    • Remove code for reading from the network.
  • Scripts/webkitpy/common/net/layouttestresults_unittest.py:
    • Test the new entrypoint.
  • Scripts/webkitpy/tool/bot/commitqueuetask.py:
    • Make the delegate interface explicit.
    • Remove the _tool member, since using the delegate for everything is cleaner.
    • Teach the testing logic how to deal with flaky tests.
  • Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
    • Update to match the CommitQueueTask changes.
  • Scripts/webkitpy/tool/commands/queues.py:
    • Use the new CommitQueueTaskDelegate interface.
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
    • Fix the SecondThoughtsCommitQueue test which was broken.
    • Add a new test to make sure the flaky test reporting works.
  • Scripts/webkitpy/tool/main.py:
    • Store the port on the tool object.
  • Scripts/webkitpy/tool/mocktool.py:
    • Add a port() accessor to MockTool
  • Scripts/webkitpy/tool/steps/abstractstep.py:
    • Move port() off of Step and onto Tool.
  • Scripts/webkitpy/tool/steps/build.py:
  • Scripts/webkitpy/tool/steps/preparechangelog.py:
  • Scripts/webkitpy/tool/steps/runtests.py:
  • Scripts/webkitpy/tool/steps/steps_unittest.py:
    • Two tests with the same name! only the latter was being run.
  • Scripts/webkitpy/tool/steps/update.py:
5:50 PM Changeset in webkit [69828] by jamesr@google.com
  • 3 edits
    2 copies in branches/chromium/552

Merge 69827 - 2010-10-14 James Robinson <​jamesr@chromium.org>

Reviewed by Simon Fraser.

SelectElement should check if its renderer exists after calling Element::focus()
​https://bugs.webkit.org/show_bug.cgi?id=47696

Tests that clicking on a listbox select with an element has a blur listener that causes
the listbox to become display:none does not crash.

  • fast/forms/select-listbox-focus-displaynone.html: Added.

2010-10-14 James Robinson <​jamesr@chromium.org>

Reviewed by Simon Fraser.

SelectElement should check if its renderer exists after calling Element::focus()
​https://bugs.webkit.org/show_bug.cgi?id=47696

Adds null checks for element->renderer() after calling element->focus(), since focus()
can dispatch an event and run arbitrary javascript that may cause the select element
to lose its renderer.

Test: fast/forms/select-listbox-focus-displaynone.html

  • dom/SelectElement.cpp: (WebCore::SelectElement::menuListDefaultEventHandler): (WebCore::SelectElement::listBoxDefaultEventHandler):

TBR=​jamesr@google.com

5:47 PM Changeset in webkit [69827] by jamesr@google.com
  • 3 edits
    2 adds in trunk

2010-10-14 James Robinson <​jamesr@chromium.org>

Reviewed by Simon Fraser.

SelectElement should check if its renderer exists after calling Element::focus()
​https://bugs.webkit.org/show_bug.cgi?id=47696

Tests that clicking on a listbox select with an element has a blur listener that causes
the listbox to become display:none does not crash.

  • fast/forms/select-listbox-focus-displaynone.html: Added.

2010-10-14 James Robinson <​jamesr@chromium.org>

Reviewed by Simon Fraser.

SelectElement should check if its renderer exists after calling Element::focus()
​https://bugs.webkit.org/show_bug.cgi?id=47696

Adds null checks for element->renderer() after calling element->focus(), since focus()
can dispatch an event and run arbitrary javascript that may cause the select element
to lose its renderer.

Test: fast/forms/select-listbox-focus-displaynone.html

  • dom/SelectElement.cpp: (WebCore::SelectElement::menuListDefaultEventHandler): (WebCore::SelectElement::listBoxDefaultEventHandler):
5:35 PM Changeset in webkit [69826] by Simon Fraser
  • 9 edits in trunk/WebKit2

2010-10-14 Simon Fraser <Simon Fraser>

Reviewed by Sam Weinig.

Plumb accelerated compositing prefs through WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=46860
<rdar://problem/8495312>

Wire up the prefs to enable accelerated compositing, and
show debug borders and repaint counters.

  • Shared/WebPreferencesStore.cpp: (WebKit::WebPreferencesStore::WebPreferencesStore): (WebKit::WebPreferencesStore::encode): (WebKit::WebPreferencesStore::decode):
  • Shared/WebPreferencesStore.h:
  • UIProcess/API/C/WKPreferencesPrivate.cpp: (WKPreferencesSetAcceleratedCompositingEnabled): (WKPreferencesGetAcceleratedCompositingEnabled): (WKPreferencesSetCompositingBordersVisible): (WKPreferencesGetCompositingBordersVisible): (WKPreferencesSetCompositingRepaintCountersVisible): (WKPreferencesGetCompositingRepaintCountersVisible):
  • UIProcess/API/C/WKPreferencesPrivate.h:
  • UIProcess/WebPreferences.cpp: (WebKit::WebPreferences::setAcceleratedCompositingEnabled): (WebKit::WebPreferences::acceleratedCompositingEnabled): (WebKit::WebPreferences::setCompositingBordersVisible): (WebKit::WebPreferences::compositingBordersVisible): (WebKit::WebPreferences::setCompositingRepaintCountersVisible): (WebKit::WebPreferences::compositingRepaintCountersVisible):
  • UIProcess/WebPreferences.h:
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::WebPage): (WebKit::WebPage::preferencesDidChange): (WebKit::WebPage::updatePreferences):
  • WebProcess/WebPage/WebPage.h:
5:27 PM Changeset in webkit [69825] by commit-queue@webkit.org
  • 4 edits in trunk/WebKit/qt

2010-09-27 Dawit Alemayehu <​adawit@kde.org>

Reviewed by Andreas Kling.

[Qt] Added functions for obtaining and checking the supported content types.
​http://webkit.org/b/37880

  • Api/qwebpage.cpp: (extractContentTypeFromHash): (extractContentTypeFromPluginVector): (QWebPage::supportedContentTypes): (QWebPage::supportsContentType):
  • tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::supportedContentType):
5:24 PM Changeset in webkit [69824] by steveblock@google.com
  • 1 edit
    3 adds in trunk/LayoutTests

2010-10-14 Steve Block <​steveblock@google.com>

Reviewed by Adam Barth.

Document behaviour of href when document base URI is changed after href atribute has been set
​https://bugs.webkit.org/show_bug.cgi?id=47665

  • fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-prevents-rebase.js: Added.
  • fast/dom/HTMLAnchorElement/set-href-attribute-prevents-rebase-expected.txt: Added.
  • fast/dom/HTMLAnchorElement/set-href-attribute-prevents-rebase.html: Added.
5:16 PM Changeset in webkit [69823] by hclam@chromium.org
  • 1 edit in branches/chromium/552/WebCore/platform/graphics/chromium/VideoLayerChromium.cpp

Merge 69706 - No longer ASSERT for LayerRenderer in VideoLayerChromium destructor
​https://bugs.webkit.org/show_bug.cgi?id=47432

Patch by Victoria Kirst <​vrk@google.com> on 2010-10-13
Reviewed by James Robinson.

  • platform/graphics/chromium/VideoLayerChromium.cpp:

(WebCore::VideoLayerChromium::cleanupResources):

TBR=​hclam@chromium.org

4:35 PM Changeset in webkit [69822] by Beth Dakin
  • 9 edits in trunk/WebCore

This patch lays the groundwork for
​https://bugs.webkit.org/show_bug.cgi?id=47514 CSS transforms should
affect scrolling
by adding topmostPosition().

Reviewed by Dave Hyatt.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::topmostPosition):

  • rendering/RenderBlock.h:
  • rendering/RenderBox.cpp:

(WebCore::RenderBox::topmostPosition):

  • rendering/RenderBox.h:
  • rendering/RenderMedia.cpp:

(WebCore::RenderMedia::topmostPosition):

  • rendering/RenderMedia.h:
  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::topmostPosition):

  • rendering/RenderTableSection.h:
4:24 PM Changeset in webkit [69821] by commit-queue@webkit.org
  • 5 edits in trunk/WebCore

2010-10-14 Sergio Villar Senin <​svillar@igalia.com>

Reviewed by Martin Robinson.

[GTK] fix compilation warnings in imported libsoup code
​https://bugs.webkit.org/show_bug.cgi?id=47674

Fixed some warnings caused by comparisons between signed and
unsigned integer expressions

  • platform/network/soup/cache/soup-directory-input-stream.c: (webkit_soup_directory_input_stream_read):
  • platform/network/soup/cache/soup-request-data.c: (webkit_soup_request_data_send):
  • platform/network/soup/cache/soup-request-file.c: (webkit_soup_request_file_ensure_file):
  • platform/network/soup/cache/webkit/soup-cache.c: (webkit_soup_cache_entry_is_fresh_enough): (webkit_soup_cache_has_response):
4:22 PM Changeset in webkit [69820] by dpranke@chromium.org
  • 4 edits in trunk/WebKitTools

2010-10-14 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Eric Seidel.

new-run-webkit-tests will now handle missing Ruby installs (or
missing PrettyPatch scripts) more cleanly - previously this
would be detected when we actually tried to create the diff, and
the error message was obscure. Now we'll log a warning up front
and otherwise be silent.

This change also refactors some global variables to be class or
instance variables to be slightly more testable and more
modular. There are no cases where we create lots of port objects
and can't afford to test for configurations repeatedly, so
there's no performance concern here.

​https://bugs.webkit.org/show_bug.cgi?id=47466

  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/base_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
4:20 PM Changeset in webkit [69819] by andreas.kling@nokia.com
  • 2 edits in trunk/WebCore

2010-10-14 Andreas Kling <​kling@webkit.org>

Unreviewed buildfix, RetainPtr is a mac thing..

  • platform/network/soup/ProxyServerSoup.cpp:
4:18 PM Changeset in webkit [69818] by Martin Robinson
  • 26 edits
    24 adds in trunk

2010-10-08 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Form controls do not respect GTK+ font size
​https://bugs.webkit.org/show_bug.cgi?id=47134

Rebaseline tests which depend on form control font size.

  • platform/gtk/editing/pasteboard/drop-text-without-selection-expected.txt:
  • platform/gtk/editing/selection/drag-select-1-expected.txt:
  • platform/gtk/editing/selection/drag-text-delay-expected.txt:
  • platform/gtk/editing/selection/select-box-expected.txt:
  • platform/gtk/fast/css/input-search-padding-expected.txt:
  • platform/gtk/fast/css/text-input-with-webkit-border-radius-expected.txt:
  • platform/gtk/fast/events/keydown-1-expected.txt:
  • platform/gtk/fast/forms/box-shadow-override-expected.txt:
  • platform/gtk/fast/forms/button-style-color-expected.txt:
  • platform/gtk/fast/forms/input-button-sizes-expected.txt:
  • platform/gtk/fast/forms/input-text-drag-down-expected.txt:
  • platform/gtk/fast/forms/placeholder-stripped-expected.txt:
  • platform/gtk/fast/frames/take-focus-from-iframe-expected.txt:
  • platform/gtk/fast/text/backslash-to-yen-sign-euc-expected.txt:
  • platform/gtk/transforms/2d/zoom-menulist-expected.txt:

2010-10-08 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Form controls do not respect GTK+ font size
​https://bugs.webkit.org/show_bug.cgi?id=47134

Have form controls use the font specified in GtkSettings. This font is
the default control font in GTK+ applications and Firefox. We need to
pass the string through Pango to get a valid font name and size.

  • platform/gtk/RenderThemeGtk.cpp: (WebCore::getScreenDPI): A helper function which returns the DPI of the default screen or 96 as a fallback. (WebCore::RenderThemeGtk::systemFont): Calculate the system font by looking at the GtkSettings value and pushing it through Pango to get the font family and font size.

2010-10-08 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Form controls do not respect GTK+ font size
​https://bugs.webkit.org/show_bug.cgi?id=47134

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (initializeGtkFontSettings): Initialize the font control size when running DumpRenderTree to a standard value.
4:12 PM Changeset in webkit [69817] by andreas.kling@nokia.com
  • 2 edits
    1 add in trunk/WebCore

2010-10-14 Andreas Kling <​kling@webkit.org>

Soup buildfix for r69808: add ProxyServer stub.

  • GNUmakefile.am:
  • platform/network/soup/ProxyServerSoup.cpp: Added. (WebCore::proxyServersForURL):
4:05 PM Changeset in webkit [69816] by mrowe@apple.com
  • 5 edits in branches/safari-533.19-branch

Versioning.

4:04 PM Changeset in webkit [69815] by andreas.kling@nokia.com
  • 3 edits in trunk/WebCore

2010-10-14 Andreas Kling <​kling@webkit.org>

Fix GTK+ build after r69808.

  • GNUmakefile.am:
  • platform/network/curl/ProxyServerCurl.cpp: (WebCore::proxyServersForURL):
4:04 PM Changeset in webkit [69814] by mrowe@apple.com
  • 1 copy in tags/Safari-533.19.4

New tag.

4:02 PM Changeset in webkit [69813] by Simon Fraser
  • 2 edits in trunk/WebCore

2010-10-14 Simon Fraser <Simon Fraser>

Another build fix. Export FrameLoader::networkingContext()

  • WebCore.exp.in:
3:58 PM Changeset in webkit [69812] by mrowe@apple.com
  • 3 edits
    5 adds in branches/safari-533.19-branch

Merge r62683.

3:56 PM Changeset in webkit [69811] by Simon Fraser
  • 4 edits in trunk/WebCore

2010-10-14 Simon Fraser <Simon Fraser>

Fix the build after r69808.

  • WebCore.xcodeproj/project.pbxproj:
  • platform/network/cf/ProxyServerCFNet.cpp: (WebCore::proxyServersForURL):
3:46 PM Changeset in webkit [69810] by barraclough@apple.com
  • 2 edits in trunk/WebCore

Windows build fix following r69806.

  • platform/win/ClipboardUtilitiesWin.cpp:

(WebCore::markupToCFHTML):

3:32 PM Changeset in webkit [69809] by tony@chromium.org
  • 5 edits
    6 adds in trunk

2010-10-14 Tony Chang <​tony@chromium.org>

Reviewed by Kent Tamura.

[chromium] compile TestNetscapePlugIn on Chromium mac
​https://bugs.webkit.org/show_bug.cgi?id=47633

  • WebKit.gyp: Add a mac specific target for compiling TestNetscapePlugIn

2010-10-14 Tony Chang <​tony@chromium.org>

Reviewed by Kent Tamura.

[chromium] compile TestNetscapePlugIn on Chromium mac
​https://bugs.webkit.org/show_bug.cgi?id=47633

  • DumpRenderTree/DumpRenderTree.gypi: files to compile
  • DumpRenderTree/TestNetscapePlugIn/main.cpp: Use ifdef because gcc was complaining (NP_GetEntryPoints): (NPP_New): (NPP_Destroy): (NPP_HandleEvent): (NPP_GetValue):
  • DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: Added.
  • DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Added.
  • DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h: Added.
3:16 PM Changeset in webkit [69808] by commit-queue@webkit.org
  • 13 edits in trunk

2010-10-14 Dawit Alemayehu <​adawit@kde.org>

Reviewed by Andreas Kling

Implemented NPN_GetValueForURL and NPN_SetValueForURL and NPN_GetAuthenticationInfo.
​https://bugs.webkit.org/show_bug.cgi?id=34539

These missing NPN functions cause Java applets to crash in ports such
as QtWebkit that rely on webkit for Java applet support.

  • plugins/PluginDebug.cpp: (WebCore::prettyNameForNPNURLVariable):
  • plugins/PluginDebug.h:
  • plugins/PluginPackage.cpp: (WebCore::PluginPackage::initializeBrowserFuncs):
  • plugins/PluginView.cpp: (WebCore::PluginView::getValueForURL): (WebCore::PluginView::setValueForURL): (WebCore::PluginView::getAuthenticationInfo):
  • plugins/PluginView.h:
  • plugins/npapi.cpp: (NPN_GetValueForURL): (NPN_SetValueForURL): (NPN_GetAuthenticationInfo):
  • platform/network/ProxyServer.h:
  • platform/network/cf/ProxyServerCFNet.cpp: (WebCore::proxyServersForURL):
  • platform/network/qt/ProxyServerQt.cpp: (WebCore::proxyServersForURL):
2:56 PM Changeset in webkit [69807] by barraclough@apple.com
  • 2 edits in trunk/WebCore

Windows build fix following r69806.

  • platform/win/ClipboardUtilitiesWin.cpp:

(WebCore::markupToCFHTML):

2:45 PM Changeset in webkit [69806] by victorw@chromium.org
  • 2 edits in trunk/WebKitTools

2010-10-14 Victor Wang <​victorw@chromium.org>

Reviewed by Nate Chapin.

[Chromium] Fix rebaseline_chromium_webkit_tests to use 0 tolerance image diff.

​https://bugs.webkit.org/show_bug.cgi?id=47686

  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2:18 PM Changeset in webkit [69805] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-10-14 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

test-webkitpy spews Delegate terminated queue messages
​https://bugs.webkit.org/show_bug.cgi?id=47678

  • Scripts/webkitpy/tool/bot/queueengine_unittest.py:
2:11 PM Changeset in webkit [69804] by zmo@google.com
  • 4 edits in trunk/WebCore

2010-10-14 Zhenyao Mo <​zmo@google.com>

Reviewed by Kenneth Russell.

Cache link status at linkProgram and use it in useProgram instead of querying GPU
​https://bugs.webkit.org/show_bug.cgi?id=47685

  • html/canvas/WebGLProgram.cpp: Always cache link status at linkStatus and use it upon query. (WebCore::WebGLProgram::WebGLProgram):
  • html/canvas/WebGLProgram.h: Ditto. (WebCore::WebGLProgram::getLinkStatus): (WebCore::WebGLProgram::setLinkStatus):
  • html/canvas/WebGLRenderingContext.cpp: Ditto. (WebCore::WebGLRenderingContext::getProgramParameter): (WebCore::WebGLRenderingContext::linkProgram): (WebCore::WebGLRenderingContext::useProgram):
2:05 PM Changeset in webkit [69803] by commit-queue@webkit.org
  • 4 edits in trunk

2010-10-14 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r69795.
​http://trac.webkit.org/changeset/69795
​https://bugs.webkit.org/show_bug.cgi?id=47687

'See discussion at webkit.org/b/47609' (Requested by mwenge on
#webkit).

  • platform/qt/Skipped:

2010-10-14 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r69795.
​http://trac.webkit.org/changeset/69795
​https://bugs.webkit.org/show_bug.cgi?id=47687

'See discussion at webkit.org/b/47609' (Requested by mwenge on
#webkit).

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::canHandleRequest): (WebCore::FrameLoaderClientQt::dispatchUnableToImplementPolicy):
2:03 PM Changeset in webkit [69802] by adachan@apple.com
  • 5 edits in trunk/WebKit2

Reviewed by Sam Weinig.

WebKit2: Store the certificate chain in PlatformCertificateInfo.
​https://bugs.webkit.org/show_bug.cgi?id=47603

  • Shared/API/c/win/WKCertificateInfoWin.cpp: (WKCertificateInfoGetCertificateChainLength): (WKCertificateInfoGetCertificateContextAtIndex):
  • Shared/API/c/win/WKCertificateInfoWin.h:
  • Shared/win/PlatformCertificateInfo.cpp: (WebKit::PlatformCertificateInfo::PlatformCertificateInfo): Get the chain context from the response and duplicate the certificate contexts in the chain to store in m_certificateChain. (WebKit::PlatformCertificateInfo::~PlatformCertificateInfo): Free all the certificate contexts in the chain. (WebKit::PlatformCertificateInfo::operator=): Duplicate the certificate contexts from the other PlatformCertificateInfo's certificate chain to store in m_certificateChain. (WebKit::PlatformCertificateInfo::encode): (WebKit::PlatformCertificateInfo::decode): (WebKit::PlatformCertificateInfo::clearCertificateChain): Free all the certificate contexts in the chain and clear the vector.
  • Shared/win/PlatformCertificateInfo.h: (WebKit::PlatformCertificateInfo::certificateChain):
1:48 PM Changeset in webkit [69801] by jschuh@chromium.org
  • 2 edits in trunk/WebCore

2010-10-14 Justin Schuh <​jschuh@chromium.org>

Reviewed by James Robinson.

Style fix for r69735
​https://bugs.webkit.org/show_bug.cgi?id=47684

No logic change. Existing tests apply.

  • rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::alignBoxesInBlockDirection):
1:16 PM Changeset in webkit [69800] by tonyg@chromium.org
  • 14 edits
    28 deletes in branches/chromium/517

Revert 66670 - 2010-09-01 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Adam Barth.

Support <script defer> as specified by HTML5
​https://bugs.webkit.org/show_bug.cgi?id=40934

  • fast/dom/HTMLScriptElement/defer-double-defer-write-expected.txt: Added.
  • fast/dom/HTMLScriptElement/defer-double-defer-write.html: Added. Tests that a write of a deferred script from a deferred script will execute when the document is closed. The explicit close is necessary because this is a script created parser.
  • fast/dom/HTMLScriptElement/defer-double-write-expected.txt: Added.
  • fast/dom/HTMLScriptElement/defer-double-write.html: Added. Tests that a script block written from a deferred script will write into the new document.
  • fast/dom/HTMLScriptElement/defer-inline-script-expected.txt: Added.
  • fast/dom/HTMLScriptElement/defer-inline-script.html: Added. Tests that inline scripts are not deferred. This is consistent with HTML5 and inconsistent with IE.
  • fast/dom/HTMLScriptElement/defer-onbeforeload-expected.txt: Added.
  • fast/dom/HTMLScriptElement/defer-onbeforeload.html: Added. Tests that the beforeload event is fired immediately and is cancellable.
  • fast/dom/HTMLScriptElement/defer-script-invalid-url-expected.txt: Added.
  • fast/dom/HTMLScriptElement/defer-script-invalid-url.html: Added. Tests that deferred scripts with invalid URLs are ignored and that subsequent deferred scripts will be run.
  • fast/dom/HTMLScriptElement/defer-write-expected.txt: Added.
  • fast/dom/HTMLScriptElement/defer-write.html: Added. Tests that a basic write from a deferred script blows away the document.
  • fast/dom/HTMLScriptElement/resources/defer.js: Added.
  • fast/dom/HTMLScriptElement/resources/external.js: Added.
  • fast/dom/HTMLScriptElement/resources/shouldnotexecute.js: Added.
  • fast/dom/HTMLScriptElement/shouldnotexecute.js: Added.
  • fast/dom/HTMLScriptElement/two-defer-writes-expected.txt: Added.
  • fast/dom/HTMLScriptElement/two-defer-writes.html: Added. Tests that when a document.write from the first deferred script blows away the document, subsequent deferred scripts are not executed.
  • http/tests/misc/resources/defer-script.js: Added.
  • http/tests/misc/resources/external-script.js: Added.
  • http/tests/misc/resources/script-debug-body-background.js: Added.
  • http/tests/misc/resources/script-write-slow-stylesheet.js: Added.
  • http/tests/misc/resources/slow-defer-script.cgi: Added.
  • http/tests/misc/resources/slow-stylesheet.cgi: Added.
  • http/tests/misc/script-defer-after-slow-stylesheet-expected.txt: Added.
  • http/tests/misc/script-defer-after-slow-stylesheet.html: Added. Tests that deferred scripts respect blocking stylesheets.
  • http/tests/misc/script-defer-expected.txt: Added.
  • http/tests/misc/script-defer.html: Added. Tests basic ordering of deferred scripts.

2010-09-01 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Adam Barth.

Support <script defer> as specified by HTML5
​https://bugs.webkit.org/show_bug.cgi?id=40934

Tests: fast/dom/HTMLScriptElement/defer-double-defer-write.html

fast/dom/HTMLScriptElement/defer-double-write.html
fast/dom/HTMLScriptElement/defer-inline-script.html
fast/dom/HTMLScriptElement/defer-onbeforeload.html
fast/dom/HTMLScriptElement/defer-script-invalid-url.html
fast/dom/HTMLScriptElement/defer-write.html
fast/dom/HTMLScriptElement/two-defer-writes.html
http/tests/misc/script-defer-after-slow-stylesheet.html
http/tests/misc/script-defer.html

  • dom/Document.cpp: (WebCore::Document::open): Allow implicit open for writes() while executing deferred scripts.
  • dom/DocumentParser.cpp: (WebCore::DocumentParser::DocumentParser): (WebCore::DocumentParser::startParsing): (WebCore::DocumentParser::prepareToStopParsing): If called when stopped or detached, it shouldn't reset to stopping. (WebCore::DocumentParser::stopParsing): (WebCore::DocumentParser::detach):
  • dom/DocumentParser.h: (WebCore::DocumentParser::isParsing): (WebCore::DocumentParser::isActive): (WebCore::DocumentParser::isStopping): (WebCore::DocumentParser::isDetached):
  • dom/RawDataDocumentParser.h: (WebCore::RawDataDocumentParser::finish):
  • dom/XMLDocumentParser.cpp: (WebCore::XMLDocumentParser::append): (WebCore::XMLDocumentParser::exitText):
  • dom/XMLDocumentParserLibxml2.cpp: (WebCore::XMLDocumentParser::doWrite): (WebCore::XMLDocumentParser::startElementNs): (WebCore::XMLDocumentParser::endElementNs): (WebCore::XMLDocumentParser::characters): (WebCore::XMLDocumentParser::error): (WebCore::XMLDocumentParser::processingInstruction): (WebCore::XMLDocumentParser::cdataBlock): (WebCore::XMLDocumentParser::comment): (WebCore::XMLDocumentParser::internalSubset): (WebCore::XMLDocumentParser::initializeParserContext): (WebCore::XMLDocumentParser::doEnd):
  • html/parser/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::prepareToStopParsing): (WebCore::HTMLDocumentParser::pumpTokenizerIfPossible): (WebCore::HTMLDocumentParser::pumpTokenizer): (WebCore::HTMLDocumentParser::insert): (WebCore::HTMLDocumentParser::append): (WebCore::HTMLDocumentParser::end): (WebCore::HTMLDocumentParser::attemptToEnd): (WebCore::HTMLDocumentParser::endIfDelayed): (WebCore::HTMLDocumentParser::notifyFinished):
  • html/parser/HTMLDocumentParser.h:
  • html/parser/HTMLScriptRunner.cpp: (WebCore::HTMLScriptRunner::~HTMLScriptRunner): (WebCore::HTMLScriptRunner::executeParsingBlockingScript): (WebCore::HTMLScriptRunner::executePendingScriptAndDispatchEvent): (WebCore::HTMLScriptRunner::executeScriptsWaitingForParsing): (WebCore::HTMLScriptRunner::requestDeferredScript): (WebCore::HTMLScriptRunner::runScript):
  • html/parser/HTMLScriptRunner.h:
  • loader/ImageDocument.cpp: (WebCore::ImageDocumentParser::finish):

TBR=​tonyg@chromium.org
BUG=57196
Review URL: ​http://codereview.chromium.org/3776004

12:52 PM Changeset in webkit [69799] by yurys@chromium.org
  • 8 edits in trunk/WebCore

2010-10-14 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: encapsulate ScriptState into ConsoleMessage instead of passing it as additional parameter
​https://bugs.webkit.org/show_bug.cgi?id=47675

No new tests. This refactoring is covered by existing inspector tests.

  • bindings/js/JSConsoleCustom.cpp:
  • bindings/js/ScriptCallFrame.cpp:
  • bindings/js/ScriptCallFrame.h: (WebCore::ScriptCallFrame::functionName): (WebCore::ScriptCallFrame::sourceURL): (WebCore::ScriptCallFrame::lineNumber): (WebCore::ScriptCallFrame::argumentCount):
  • inspector/ConsoleMessage.cpp: (WebCore::ConsoleMessage::isEqual):
  • inspector/ConsoleMessage.h:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::addMessageToConsole): (WebCore::InspectorController::addConsoleMessage): (WebCore::InspectorController::startGroup): (WebCore::InspectorController::endGroup):
  • inspector/InspectorController.h:
12:48 PM Changeset in webkit [69798] by Nikolas Zimmermann
  • 44 edits
    1 add in trunk

2010-10-14 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Gavin Barraclough.

Replace lots of String::format() usages by StringConcatenate
​https://bugs.webkit.org/show_bug.cgi?id=47664

Add StringTypeAdapter<char> to accept single characters for makeString().

  • wtf/text/StringConcatenate.h: (WTF::makeString):

2010-10-14 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Gavin Barraclough.

Replace lots of String::format() usages by StringConcatenate
​https://bugs.webkit.org/show_bug.cgi?id=47664

  • ForwardingHeaders/wtf/text/StringConcatenate.h: Added.
  • bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::crossDomainAccessErrorMessage):
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::reportUnsafeAccessTo):
  • dom/ExceptionBase.cpp: (WebCore::ExceptionBase::ExceptionBase):
  • dom/XMLDocumentParser.cpp: (WebCore::XMLDocumentParser::handleError):
  • history/PageCache.cpp: (WebCore::logCanCacheFrameDecision):
  • html/FTPDirectoryDocument.cpp: (WebCore::processFileDateString):
  • inspector/CodeGeneratorInspector.pm:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::didReceiveResponse): (WebCore::InspectorController::count):
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::createBreakpointId):
  • inspector/InspectorDebuggerAgent.cpp: (WebCore::formatBreakpointId):
  • inspector/InspectorProfilerAgent.cpp: (WebCore::InspectorProfilerAgent::addProfileFinishedMessageToConsole): (WebCore::InspectorProfilerAgent::addStartProfilingMessageToConsole): (WebCore::InspectorProfilerAgent::getCurrentUserInitiatedProfileName): (WebCore::InspectorProfilerAgent::takeHeapSnapshot):
  • loader/CachedResourceLoader.cpp: (WebCore::CachedResourceLoader::printAccessDeniedMessage):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::checkIfDisplayInsecureContent): (WebCore::FrameLoader::checkIfRunInsecureContent): (WebCore::FrameLoader::shouldAllowNavigation):
  • loader/archive/cf/LegacyWebArchive.cpp: (WebCore::LegacyWebArchive::createFromSelection):
  • page/DOMWindow.cpp: (WebCore::DOMWindow::postMessageTimerFired):
  • page/PrintContext.cpp: (WebCore::PrintContext::pageProperty): (WebCore::PrintContext::pageSizeAndMarginsInPixels):
  • page/XSSAuditor.cpp: (WebCore::XSSAuditor::canLoadObject):
  • platform/efl/PlatformKeyboardEventEfl.cpp: (WebCore::createKeyMap): (WebCore::createWindowsKeyMap):
  • platform/graphics/GraphicsLayer.cpp: (WebCore::GraphicsLayer::animationNameForTransition):
  • platform/graphics/brew/ImageBrew.cpp: (WebCore::Image::loadPlatformResource):
  • platform/graphics/cg/ImageBufferCG.cpp: (WebCore::ImageBuffer::toDataURL):
  • platform/graphics/efl/ImageEfl.cpp: (WebCore::loadResourceSharedBuffer):
  • platform/graphics/gtk/ImageBufferGtk.cpp: (WebCore::ImageBuffer::toDataURL):
  • platform/graphics/haiku/ImageBufferHaiku.cpp: (WebCore::ImageBuffer::toDataURL):
  • platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::animationIdentifier):
  • platform/graphics/qt/ImageBufferQt.cpp: (WebCore::ImageBuffer::toDataURL):
  • platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::ImageBuffer::toDataURL):
  • platform/graphics/win/WebLayer.cpp: (WebCore::WebLayer::drawInContext):
  • platform/network/CredentialStorage.cpp: (WebCore::originStringFromURL):
  • platform/sql/SQLiteDatabase.cpp: (WebCore::SQLiteDatabase::setSynchronous):
  • platform/text/wince/TextCodecWinCE.cpp: (WebCore::LanguageManager::LanguageManager):
  • platform/win/ClipboardUtilitiesWin.cpp: (WebCore::markupToCFHTML):
  • platform/win/Language.cpp: (WebCore::defaultLanguage):
  • plugins/PluginStream.cpp: (WebCore::PluginStream::startStream):
  • svg/SVGUseElement.cpp: (WebCore::dumpInstanceTree):
  • websockets/WebSocket.cpp: (WebCore::WebSocket::connect):
  • websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::appendToBuffer):
  • websockets/WebSocketHandshake.cpp: (WebCore::WebSocketHandshake::readServerHandshake):

2010-10-14 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Gavin Barraclough.

Replace lots of String::format() usages by StringConcatenate
​https://bugs.webkit.org/show_bug.cgi?id=47664

Rebaseline two xssAuditor tests, that have been changed, after switching from String::format() -> makeString().

  • http/tests/security/xssAuditor/embed-tag-null-char-expected.txt:
  • http/tests/security/xssAuditor/object-embed-tag-null-char-expected.txt:
12:47 PM Changeset in webkit [69797] by adachan@apple.com
  • 4 edits in trunk/WebKitLibraries

Rubber-stamped by Adam Roben.

Fix Windows build.

  • win/include/WebKitSystemInterface/WebKitSystemInterface.h:
  • win/lib/WebKitSystemInterface.lib:
  • win/lib/WebKitSystemInterface_debug.lib:
12:40 PM Changeset in webkit [69796] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit/gtk

2010-10-14 Joone Hur <​joone@kldp.org>

Reviewed by Andreas Kling.

[GTK] google.co.kr was missed when checking Google domains
​https://bugs.webkit.org/show_bug.cgi?id=47652

WebKitGtk+ maintains a list of Google domains for working well with Google sites.
Add google.co.kr also to the list to be checked with other Google domains.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::initializeDomainsList): Added google.co.kr.
12:38 PM Changeset in webkit [69795] by robert@webkit.org
  • 4 edits in trunk

2010-10-14 Robert Hogan <​robert@webkit.org>

Reviewed by Antonio Gomes.

[Qt] Fix http/tests/misc/redirect-to-external-url.html

Support the test in FrameLoaderClientQt and unskip.

​https://bugs.webkit.org/show_bug.cgi?id=47609

  • platform/qt/Skipped:

2010-10-14 Robert Hogan <​robert@webkit.org>

Reviewed by Antonio Gomes.

[Qt] Fix http/tests/misc/redirect-to-external-url.html

Support the test in FrameLoaderClientQt and unskip.

​https://bugs.webkit.org/show_bug.cgi?id=47609

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::canHandleRequest): (WebCore::FrameLoaderClientQt::dispatchUnableToImplementPolicy):
12:29 PM Changeset in webkit [69794] by kinuko@chromium.org
  • 2 edits in branches/chromium/552/WebCore

Merge 69634 - 2010-10-12 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by Jian Li.

Pass platform path (rather than virtual path) when creating File from FileEntry
​https://bugs.webkit.org/show_bug.cgi?id=47563

No new tests, the new test for FileWriter will be verifying this.

  • fileapi/FileEntry.cpp: (WebCore::FileEntry::file):

TBR=​kinuko@chromium.org

12:29 PM Changeset in webkit [69793] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-10-14 Xan Lopez <​xlopez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Small cleanup in PluginViewGtk
​https://bugs.webkit.org/show_bug.cgi?id=47588

Remove some dead code and use PlatformRefPtr for cairo surfaces.

No new tests, only refactoring.

  • plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::paint):
12:23 PM Changeset in webkit [69792] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit/efl

2010-10-14 Rafael Antognolli <​antognolli@profusion.mobi>

Reviewed by Eric Seidel.

[EFL] Use data_set after data_get to keep refcount correct.
​https://bugs.webkit.org/show_bug.cgi?id=47110

The call to evas_object_image_data_set was missed in this function,
which caused the refcount of the data being always increased on every
scroll.

  • ewk/ewk_view_single.c: (_ewk_view_single_smart_scrolls_process):
12:22 PM Changeset in webkit [69791] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-10-14 Dawit Alemayehu <​adawit@kde.org>

Reviewed by Andreas Kling.

Fix compile error when bulding webkit's Qt port using the "--v8" option.
​https://bugs.webkit.org/show_bug.cgi?id=47455

  • platform/qt/PlatformBridge.h:
12:22 PM Changeset in webkit [69790] by Adam Roben
  • 4 edits in trunk/WebKit2

Make sure WebKit2 only loads each plugin once

Fixes <​http://webkit.org/b/47677> <rdar://problem/8552178> WebKit2 can
load the same plugin multiple times

Reviewed by Sam Weinig.

  • UIProcess/Plugins/PluginInfoStore.cpp:

(WebKit::addFromVector): Helper function that adds all the elements
from a Vector to a HashSet.
(WebKit::PluginInfoStore::loadPluginsIfNecessary): Put all the plugin
paths into a HashSet, then load the plugins specified in the HashSet.
On Windows, the HashSet is case-insensitive, just like the file
system.

  • UIProcess/Plugins/PluginInfoStore.h: Removed loadPluginsInDirectory,

which is no longer used.

  • UIProcess/Plugins/win/PluginInfoStoreWin.cpp:

(WebKit::addPluginPathsFromRegistry):
(WebKit::PluginInfoStore::individualPluginPaths):
Changed to store the paths in a Vector instead of a HashSet now that
loadPluginsIfNecessary will handle duplicates for us.

12:22 PM Changeset in webkit [69789] by Adam Roben
  • 6 edits in trunk/WebKit2

Load plugins that are specified in the MozillaPlugins registry key

Fixes <​http://webkit.org/b/44271> <rdar://problem/8329750> WebKit2
should load plugins specified in the MozillaPlugins registry key (like
old WebKit does)

I couldn't think of a good way to test this.

Reviewed by Steve Falkenburg.

  • UIProcess/Plugins/PluginInfoStore.cpp:

(WebKit::PluginInfoStore::loadPluginsIfNecessary): Also load plugins
specified by individualPluginPaths.

  • UIProcess/Plugins/PluginInfoStore.h: Added individualPluginPaths and

some comments.

  • UIProcess/Plugins/mac/PluginInfoStoreMac.mm:

(WebKit::PluginInfoStore::individualPluginPaths):

  • UIProcess/Plugins/qt/PluginInfoStoreQt.cpp:

(WebKit::PluginInfoStore::individualPluginPaths):
Stubbed out.

  • UIProcess/Plugins/win/PluginInfoStoreWin.cpp:

(WebKit::addPluginPathsFromRegistry):
(WebKit::PluginInfoStore::individualPluginPaths):
Ported this code from WebCore's PluginDatabaseWin.cpp. I slightly
cleaned it up and changed it to use a case-insensitive hash, since
paths on Windows are case-insensitive.

12:21 PM Changeset in webkit [69788] by Adam Roben
  • 14 edits
    1 copy
    2 adds in trunk

Call ::DefWindowProcW for unhandled key events

::DefWindowProcW does important things for at least some key events
(e.g., it generates a WM_SYSCOMMAND message when the Alt key is
released), so we need to make sure to call it when we don't handle key
events.

Fixes <​http://webkit.org/b/47671> <rdar://problem/8435594> Pressing
the Alt key when MiniBrowser's WKView is focused doesn't send focus to
the menu bar

Reviewed by Steve Falkenburg.

WebKit2:

  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::didNotHandleKeyEvent):

  • UIProcess/API/qt/qwkpage.cpp:

(QWKPagePrivate::didNotHandleKeyEvent):

  • UIProcess/API/qt/qwkpage_p.h:

Stubbed out didNotHandleKeyEvent.

  • UIProcess/PageClient.h: Added didNotHandleKeyEvent.
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didReceiveEvent): Tell the PageClient about the
unhandled event.

  • UIProcess/win/WebView.cpp:

(WebKit::WebView::onKeyEvent): Added a comment.
(WebKit::WebView::didNotHandleKeyEvent): Pass the event to
::DefWindowProcW.

  • UIProcess/win/WebView.h: Added didNotHandleKeyEvent.

WebKitTools:

Test that pressing the Alt key generates a WM_SYSCOMMAND message

  • TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops: Added

TestWebKitAPI/win to the include path so that WindowMessageObserver
can be found.

  • TestWebKitAPI/PlatformWebView.h: Added simulateAltKeyPress and

Windows-specific members.
(TestWebKitAPI::PlatformWebView::setParentWindowMessageObserver):
Added this simple setter.

  • TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp: Added.

(TestWebKitAPI::WMSysCommandObserver::WMSysCommandObserver):
Initialize our lone data member.
(TestWebKitAPI::WMSysCommandObserver::windowDidReceiveWMSysCommand):
Simple getter.
(TestWebKitAPI::WMSysCommandObserver::windowReceivedMessage): Record
when a WM_SYSCOMMAND message is received.
(TestWebKitAPI::didNotHandleKeyEventCallback): Record when a
WM_SYSKEYUP message is not handled.
(TestWebKitAPI::WebKit2_AltKeyGeneratesWMSysCommand): Simulate
pressing the Alt key and check that a WM_SYSCOMMAND message got sent
to the WKView's parent window.

  • TestWebKitAPI/win/PlatformWebViewWin.cpp:

(TestWebKitAPI::PlatformWebView::registerWindowClass): Made this a
member function so it could access PlatformWebView::wndProc. Use
PlatformWebView::wndProc as the WNDPROC.
(TestWebKitAPI::PlatformWebView::PlatformWebView): Initialize our new
data member and pass the this pointer to CreateWindowEx so we can
store it on the HWND.
(TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress): Moved some
constants from here to the top of the file.
(TestWebKitAPI::PlatformWebView::simulateAltKeyPress): Added. Sends
the same messages that Notepad receives when you press the Alt key.
(TestWebKitAPI::PlatformWebView::wndProc): Added.

  • When WM_CREATE is received, we set the PlatformWebView instance pointer as a property on the HWND so we can access it later.
  • For other messages, we try to get the PlatformWebView instance pointer from the HWND property.
  • When WM_NCDESTROY is received (which is the last message we will receive), we remove the PlatformWebView instance property.
  • Pass messages to the parent window's message observer, if there is one.
  • Pass all messages through to ::DefWindowProcW.
  • TestWebKitAPI/win/TestWebKitAPI.vcproj: Added WindowMessageObserver

and AltKeyGeneratesWMSysCommand.

  • TestWebKitAPI/win/WindowMessageObserver.h: Added. This class can be

used to observe messages sent to one or more windows.

12:19 PM Changeset in webkit [69787] by ggaren@apple.com
  • 3 edits in trunk/JavaScriptCore

need way to measure size of JITed ARM code
​https://bugs.webkit.org/show_bug.cgi?id=47121

Patch by David Goodwin <​david_goodwin@apple.com> on 2010-10-14
Reviewed by Darin Adler.

  • assembler/LinkBuffer.h:

(JSC::LinkBuffer::linkCode):
(JSC::LinkBuffer::dumpLinkStats):
(JSC::LinkBuffer::dumpCode):

11:52 AM Changeset in webkit [69786] by Martin Robinson
  • 5 edits
    4 adds in trunk

2010-10-01 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Holger Freyther.

[GTK] REGRESSION: FreeType backend does not respect XSettings font settings after r68558
​https://bugs.webkit.org/show_bug.cgi?id=47033

Added a platform-specific test which verifies that if XSettings
specifies subpixel aliasing, it is the default rendering style.

  • platform/gtk/fonts/xsettings_antialias_settings-expected.checksum: Added.
  • platform/gtk/fonts/xsettings_antialias_settings-expected.png: Added.
  • platform/gtk/fonts/xsettings_antialias_settings-expected.txt: Added.
  • platform/gtk/fonts/xsettings_antialias_settings.html: Added.

2010-10-01 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Holger Freyther.

[GTK] REGRESSION: FreeType backend does not respect XSettings font settings after r68558
​https://bugs.webkit.org/show_bug.cgi?id=47033

Fix logic that merges XSettings defaults and FontConfig settings. If
FontConfig or XSettings specifies a subpixel order, we force subpixel
anti-aliasing on. If anti-aliasing is turned on explicitly, only
override the setting if it was previously off, otherwise we ignore
the user's preference for subpixel or gray antialiasing.

Test: platform/gtk/fonts/xsettings_antialias_settings.html

  • platform/graphics/cairo/FontPlatformDataFreeType.cpp: (WebCore::setCairoFontOptionsFromFontConfigPattern): Fix merging of XSettings and FontConfig anti-aliasing settings. (WebCore::getDefaultFontOptions): Added this helper. (WebCore::FontPlatformData::FontPlatformData): Use the getDefaultFontOptions helper.

2010-10-01 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Holger Freyther.

[GTK] REGRESSION: FreeType backend does not respect XSettings font settings after r68558
​https://bugs.webkit.org/show_bug.cgi?id=47033

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (initializeGtkFontSettings): Added this method which initializes XSettings font settings to consistent values before running a test. For the one test in which we need subpixel aliasing turned on, do that. (initializeFonts): Accepts a testURL parameter now and delegates to initializeGtkFontSettings. (runTest): Pass the testURL to initializeFonts.
11:50 AM Changeset in webkit [69785] by Nate Chapin
  • 1 edit
    40 adds in trunk/LayoutTests

2010-10-14 Nate Chapin <Nate Chapin>

Unreviewed, test tweaks.

Add Chromium win/linux results for ​http://trac.webkit.org/changeset/69774.

  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.png: Added.
11:45 AM Changeset in webkit [69784] by adachan@apple.com
  • 4 edits in trunk/WebKitLibraries

Reviewed by Steve Falkenburg.

Add wkGetSSLCertificateChainContext for fetching the certificate chain.
Needed for ​https://bugs.webkit.org/show_bug.cgi?id=47603.

  • win/include/WebKitSystemInterface/WebKitSystemInterface.h:
  • win/lib/WebKitSystemInterface.lib:
  • win/lib/WebKitSystemInterface_debug.lib:
11:36 AM Changeset in webkit [69783] by commit-queue@webkit.org
  • 3 edits in trunk/WebKit/efl

2010-10-14 Ryuan Choi <​ryuan.choi@samsung.com>

Reviewed by Eric Seidel.

[EFL] Add setting api for enabling encoding detector
​https://bugs.webkit.org/show_bug.cgi?id=45427

Add settings api for enabling encoding detector.

  • ewk/ewk_view.cpp: (_ewk_view_priv_new): (ewk_view_setting_encoding_detector_set): (ewk_view_setting_encoding_detector_get):
  • ewk/ewk_view.h:
11:30 AM Changeset in webkit [69782] by jianli@chromium.org
  • 13 edits in trunk/WebCore

Support typed arrays in workers
​https://bugs.webkit.org/show_bug.cgi?id=47616

Reviewed by David Levin.

To support typed arrays in workers, we need to expose constructors in
WorkerContext and add NoStaticTables attribute.

I also add File API feature guard to the constructors defined in
DOMWindow.

  • bindings/js/JSDOMWindowCustom.cpp: Add File API feature guard to the

constructors defined in DOMWindow.

  • html/canvas/ArrayBuffer.idl: Add NoStaticTables attribute.
  • html/canvas/ArrayBufferView.idl: Add NoStaticTables attribute.
  • html/canvas/Float32Array.idl: Add NoStaticTables attribute.
  • html/canvas/Int16Array.idl: Add NoStaticTables attribute.
  • html/canvas/Int32Array.idl: Add NoStaticTables attribute.
  • html/canvas/Int8Array.idl: Add NoStaticTables attribute.
  • html/canvas/Uint16Array.idl: Add NoStaticTables attribute.
  • html/canvas/Uint32Array.idl: Add NoStaticTables attribute.
  • html/canvas/Uint8Array.idl: Add NoStaticTables attribute.
  • page/DOMWindow.idl: Add File API feature guard to the constructors

defined in DOMWindow.

  • workers/WorkerContext.idl: Expose type array constructors.
11:00 AM Changeset in webkit [69781] by commit-queue@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-10-14 Peter Varga <​pvarga@inf.u-szeged.hu>

Reviewed by Gavin Barraclough.

The backreference checking isn't working in some cases with YARR Interpreter
​https://bugs.webkit.org/show_bug.cgi?id=46904

The Interpreter::matchBackReference() function returns true without matching
when a backreference points to the same parentheses where it is.

  • yarr/RegexInterpreter.cpp: (JSC::Yarr::Interpreter::matchBackReference):
10:47 AM Changeset in webkit [69780] by Martin Robinson
  • 1 edit
    9 adds in trunk/LayoutTests

Add baselines and pixel results for some new tests.

  • platform/gtk/fast/forms/textfield-focus-ring-expected.checksum: Added.
  • platform/gtk/fast/forms/textfield-focus-ring-expected.png: Added.
  • platform/gtk/fast/forms/textfield-focus-ring-expected.txt: Added.
  • platform/gtk/fast/images/imagemap-focus-ring-expected.checksum: Added.
  • platform/gtk/fast/images/imagemap-focus-ring-expected.png: Added.
  • platform/gtk/fast/images/imagemap-focus-ring-expected.txt: Added.
  • platform/gtk/fast/inline/inline-focus-ring-expected.checksum: Added.
  • platform/gtk/fast/inline/inline-focus-ring-expected.png: Added.
  • platform/gtk/fast/inline/inline-focus-ring-expected.txt: Added.
10:45 AM Changeset in webkit [69779] by andreas.kling@nokia.com
  • 2 edits in trunk/WebCore

2010-10-14 Andreas Kling <​kling@webkit.org>

Reviewed by Ariya Hidayat.

[Qt] Avoid creating empty transparency layers in ImageBuffer::clip()

We were creating empty layers for sub-1 height/width clips due to
using IntRect(FloatRect) instead of enclosingIntRect().
This lead to a bunch of QPainter warnings on the console since you
can't draw on an empty QPixmap.

  • platform/graphics/qt/ImageBufferQt.cpp: (WebCore::ImageBuffer::clip):
10:31 AM Changeset in webkit [69778] by Nate Chapin
  • 1 edit
    18 adds in trunk/LayoutTests

2010-10-14 Nate Chapin <Nate Chapin>

Unreviewed, Chromium test fix.

Expected results for tests added in ​http://trac.webkit.org/changeset/69766.

  • platform/chromium-linux/fast/forms/textfield-focus-ring-expected.checksum: Added.
  • platform/chromium-linux/fast/forms/textfield-focus-ring-expected.png: Added.
  • platform/chromium-linux/fast/images/imagemap-focus-ring-expected.checksum: Added.
  • platform/chromium-linux/fast/images/imagemap-focus-ring-expected.png: Added.
  • platform/chromium-linux/fast/inline/inline-focus-ring-expected.checksum: Added.
  • platform/chromium-linux/fast/inline/inline-focus-ring-expected.png: Added.
  • platform/chromium-mac/fast/forms/textfield-focus-ring-expected.checksum: Added.
  • platform/chromium-mac/fast/images/imagemap-focus-ring-expected.checksum: Added.
  • platform/chromium-mac/fast/inline/inline-focus-ring-expected.checksum: Added.
  • platform/chromium-win/fast/forms/textfield-focus-ring-expected.checksum: Added.
  • platform/chromium-win/fast/forms/textfield-focus-ring-expected.png: Added.
  • platform/chromium-win/fast/forms/textfield-focus-ring-expected.txt: Added.
  • platform/chromium-win/fast/images/imagemap-focus-ring-expected.checksum: Added.
  • platform/chromium-win/fast/images/imagemap-focus-ring-expected.png: Added.
  • platform/chromium-win/fast/images/imagemap-focus-ring-expected.txt: Added.
  • platform/chromium-win/fast/inline/inline-focus-ring-expected.checksum: Added.
  • platform/chromium-win/fast/inline/inline-focus-ring-expected.png: Added.
  • platform/chromium-win/fast/inline/inline-focus-ring-expected.txt: Added.
10:31 AM Changeset in webkit [69777] by noam.rosenthal@nokia.com
  • 3 edits in trunk/WebKit/qt

2010-10-14 No'am Rosenthal <​noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Texmap] [Qt] Texture mapper initial implementation
​https://bugs.webkit.org/show_bug.cgi?id=47070

Allow rendering of accelerated-compositing with TextureMapper, inside a QWebFrame. The frame will render the regular content,
either normally or through tiled backingstore, then let the TextureMapper layer render itself to the active context, and
then render the scrollbar and pan icon. This is different from the current implementation, which uses additional QGraphicsItems for AC
and the scrollbar overlay.

  • Api/qgraphicswebview.cpp: (QGraphicsWebView::paint):
  • Api/qwebframe.cpp: (QWebFramePrivate::renderFromTiledBackingStore): (QWebFramePrivate::renderRelativeCoords):
10:23 AM Changeset in webkit [69776] by zecke@webkit.org
  • 2 edits in trunk/WebCore

[cairo] Typo in determining fixed width fonts
​https://bugs.webkit.org/show_bug.cgi?id=47470

It must be a single ampersand otherwise the
&& FT_FACE_FLAG_FIXED_WIDTH will always be true.

  • platform/graphics/cairo/FontPlatformDataFreeType.cpp:

(WebCore::FontPlatformData::FontPlatformData):

10:13 AM Changeset in webkit [69775] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-10-14 Sergio Villar Senin <​svillar@igalia.com>

Reviewed by Xan Lopez.

[GTK] Failing test LayoutTests/editing/undo/orphaned-selection-crash-bug32823-2.html
​https://bugs.webkit.org/show_bug.cgi?id=47666

Do a less strict decoding of base64 data url's as it was done
before. The actual problem is most likely
​https://bugs.webkit.org/show_bug.cgi?id=47661 tough.

  • platform/network/soup/cache/soup-request-data.c: (webkit_soup_request_data_send):
10:12 AM Changeset in webkit [69774] by commit-queue@webkit.org
  • 4 edits
    50 adds in trunk

2010-10-14 Renata Hodovan <​reni@inf.u-szeged.hu>

Reviewed by Andreas Kling.

SVGFEConvolveMatrixElement doesn't support dynamic invalidation, when attributes change.
​https://bugs.webkit.org/show_bug.cgi?id=47660

Adding layout tests for feConvolveMatrix dynamic DOM changes. SVGDOM tests cases will be in the following patch because of patch-size limitation (2M in bugzilla).

  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.png: Added.
  • svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr.html: Added.
  • svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr.html: Added.
  • svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr.html: Added.
  • svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr.html: Added.
  • svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr.html: Added.
  • svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr.html: Added.
  • svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr.html: Added.
  • svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr.html: Added.
  • svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr.html: Added.
  • svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr.html: Added.
  • svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-dom-bias-attr.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-dom-divisor-attr.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-dom-edgeMode-attr.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-dom-in-attr.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-dom-order-attr.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-dom-targetX-attr.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-dom-targetY-attr.js: Added. (executeTest):

2010-10-14 Renata Hodovan <​reni@inf.u-szeged.hu>

Reviewed by Andreas Kling.

SVGFEConvolveMatrixElement doesn't support dynamic invalidation, when attributes change.
​https://bugs.webkit.org/show_bug.cgi?id=47660

The dynamic changes are captured by the svgAttributeChange function, and invalidate the filter primitive if necessary.
The patch also implements the simple setOrder and setKernelUnitLength methods.

Tests: svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr.html

svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr.html
svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr.html
svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr.html
svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr.html
svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr.html
svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr.html
svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr.html
svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr.html
svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr.html

  • svg/SVGFEConvolveMatrixElement.cpp: (WebCore::SVGFEConvolveMatrixElement::setOrder): (WebCore::SVGFEConvolveMatrixElement::setKernelUnitLength): (WebCore::SVGFEConvolveMatrixElement::svgAttributeChanged):
  • svg/SVGFEConvolveMatrixElement.h:
9:57 AM Changeset in webkit [69773] by noam.rosenthal@nokia.com
  • 6 edits in trunk

2010-10-14 No'am Rosenthal <​noam.rosenthal@nokia.com>

Reviewed by Andreas Kling.

[Qt] Text breaking is slow: enable ICU as an opt-in
​https://bugs.webkit.org/show_bug.cgi?id=40332

Added a config flag that enables ICU as an opt-in instead of the Qt specific code.
Because of the inclusion of ICU headers, some explicit casting was necessary in UnicodeQt4.h

  • JavaScriptCore.pri:
  • wtf/unicode/qt4/UnicodeQt4.h: (WTF::Unicode::toLower): (WTF::Unicode::toUpper): (WTF::Unicode::toTitleCase): (WTF::Unicode::foldCase): (WTF::Unicode::isPrintableChar): (WTF::Unicode::isSeparatorSpace): (WTF::Unicode::isPunct): (WTF::Unicode::isLower): (WTF::Unicode::mirroredChar): (WTF::Unicode::combiningClass): (WTF::Unicode::direction): (WTF::Unicode::category):

2010-10-14 No'am Rosenthal <​noam.rosenthal@nokia.com>

Reviewed by Andreas Kling.

[Qt] Text breaking is slow: enable ICU as an opt-in
​https://bugs.webkit.org/show_bug.cgi?id=40332

Added a config flag that enables ICU as an opt-in instead of the Qt specific code.

No new tests, this should be covered by existing tests.

  • WebCore.pro:
  • platform/text/qt/TextBreakIteratorQt.cpp: (WebCore::currentTextBreakLocaleID):
9:52 AM Changeset in webkit [69772] by noam.rosenthal@nokia.com
  • 3 edits in trunk/WebCore

2010-10-14 No'am Rosenthal <​noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Texmap] [Qt] Texture mapper initial implementation
​https://bugs.webkit.org/show_bug.cgi?id=47070

This patch enables compilation of TextureMapper with Media. It has an initial non-working implementation of a video layer, to be integrated
once other parts of TextureMapper are fully working.

No new tests: this is new implementation that's not enabled yet.

  • platform/graphics/qt/MediaPlayerPrivateQt.cpp: (WebCore::TextureMapperVideoLayerQt::TextureMapperVideoLayerQt): (WebCore::TextureMapperVideoLayerQt::setPlatformLayerClient): (WebCore::TextureMapperVideoLayerQt::paint): (WebCore::TextureMapperVideoLayerQt::size): (WebCore::MediaPlayerPrivateQt::acceleratedRenderingStateChanged): (WebCore::MediaPlayerPrivateQt::platformLayer):
  • platform/graphics/qt/MediaPlayerPrivateQt.h: (WebCore::MediaPlayerPrivateQt::supportsAcceleratedRendering): (WebCore::MediaPlayerPrivateQt::acceleratedRenderingStateChanged): (WebCore::MediaPlayerPrivateQt::platformLayer):
9:40 AM Changeset in webkit [69771] by Nate Chapin
  • 2 edits in trunk/LayoutTests

2010-10-14 Nate Chapin <Nate Chapin>

Unreviewed, Chromium expectations update.

  • platform/chromium/test_expectations.txt:
9:40 AM Changeset in webkit [69770] by abarth@webkit.org
  • 3 edits in trunk/WebKitTools

2010-10-14 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

ChromiumXVFBPort.run_webkit_tests_command has infinite recursion
​https://bugs.webkit.org/show_bug.cgi?id=47655

  • Scripts/webkitpy/common/config/ports.py:
  • Scripts/webkitpy/common/config/ports_unittest.py:
9:18 AM Changeset in webkit [69769] by yurys@chromium.org
  • 3 edits in trunk/LayoutTests

2010-10-14 Yury Semikhatsky <​yurys@chromium.org>

Unreviewed. Update expectations for some inspector tests.

  • inspector/debugger-pause-in-eval-script-expected.txt:
  • inspector/extensions-events-expected.txt:
9:13 AM Changeset in webkit [69768] by alex
  • 2 edits in trunk/WebCore

2010-10-14 Alejandro G. Castro <​alex@igalia.com>

Reviewed by Martin Robinson.

Fixed crashes in the GTK 64bits bot, we have to use NULL instead
of 0 when calling these glib APIs, 0 is compiled as a char and in
64bits systems it is not correct.

  • platform/network/soup/cache/soup-requester.c: (webkit_soup_requester_new): (webkit_soup_requester_request_uri):
9:00 AM Changeset in webkit [69767] by dbates@webkit.org
  • 2 edits in trunk/WebCore

2010-10-14 Daniel Bates <​dbates@rim.com>

Attempt to fix the Qt and GTK builds based on the build bot results from <​http://webkit.sed.hu>.

  • rendering/RenderInline.cpp: Include header "RenderTheme.h"
8:40 AM Changeset in webkit [69766] by dbates@webkit.org
  • 6 edits
    12 adds in trunk

2010-10-14 Daniel Bates <​dbates@rim.com>

Reviewed by Darin Adler.

Only draw focus ring in RenderInline and RenderImage if the theme
is not able to draw a focus ring
​https://bugs.webkit.org/show_bug.cgi?id=47632

Fixes an issue where RenderInline::paintOutline() and RenderImage::paintFocusRings()
would draw a focus ring regardless of whether the port-specific theme is able to
draw a focus ring. Instead, these methods should only draw a focus ring if the
theme is unable to draw a focus ring.

Also, extracted common focus ring drawing code from RenderObject::paintOutline()
and RenderInline::paintOutline() into RenderObject::paintFocusRing().

Tests: fast/forms/textfield-focus-ring.html

fast/images/imagemap-focus-ring.html
fast/inline/inline-focus-ring.html

  • rendering/RenderImage.cpp: (WebCore::RenderImage::paintFocusRings): Modified to only draw a focus ring if the the theme does not draw one.
  • rendering/RenderInline.cpp: (WebCore::RenderInline::paintOutline): Modified to call RenderObject::paintFocusRing().
  • rendering/RenderObject.cpp:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::paintFocusRing): Added. (WebCore::RenderObject::paintOutline): Modified to call RenderObject::paintFocusRing().
  • rendering/RenderObject.h:

2010-10-14 Daniel Bates <​dbates@rim.com>

Reviewed by Darin Adler.

Only draw focus ring in RenderInline and RenderImage if the theme
is not able to draw a focus ring
​https://bugs.webkit.org/show_bug.cgi?id=47632

Pixel tests to ensure that we don't regress focus ring drawing for RenderObject
(fast/forms/textfield-focus-ring.html), RenderImage (fast/images/imagemap-focus-ring.html)
and RenderInline (fast/inline/inline-focus-ring.html) on ports that support focus
ring drawing.

  • fast/forms/textfield-focus-ring.html: Added.
  • fast/images/imagemap-focus-ring.html: Added.
  • fast/inline/inline-focus-ring.html: Added.
  • platform/mac/fast/forms/textfield-focus-ring-expected.checksum: Added.
  • platform/mac/fast/forms/textfield-focus-ring-expected.png: Added.
  • platform/mac/fast/forms/textfield-focus-ring-expected.txt: Added.
  • platform/mac/fast/images/imagemap-focus-ring-expected.checksum: Added.
  • platform/mac/fast/images/imagemap-focus-ring-expected.png: Added.
  • platform/mac/fast/images/imagemap-focus-ring-expected.txt: Added.
  • platform/mac/fast/inline/inline-focus-ring-expected.checksum: Added.
  • platform/mac/fast/inline/inline-focus-ring-expected.png: Added.
  • platform/mac/fast/inline/inline-focus-ring-expected.txt: Added.
8:16 AM Changeset in webkit [69765] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

2010-10-14 Stephen White <​senorblanco@chromium.org>

Unreviewed; test expectations update.

[chromium] Update test_expectations following Skia roll in chromium.

  • platform/chromium/test_expectations.txt:
7:14 AM Changeset in webkit [69764] by steveblock@google.com
  • 1 edit
    4 adds in trunk/LayoutTests

2010-10-14 Steve Block <​steveblock@google.com>

Reviewed by Jeremy Orlow.

DeviceOrientation crash when page is in page cache and is navigated while listener is registered
​https://bugs.webkit.org/show_bug.cgi?id=47257

This crash is avoided now that pages using DeviceOrientation are not put in
the page cache. See ​https://bugs.webkit.org/show_bug.cgi?id=47408.

This test serves to document the fact that the underlying problem needs to
be addressed before the page cache is enabled for DeviceOrientation.

  • fast/dom/DeviceOrientation/event-after-navigation-expected.txt: Added.
  • fast/dom/DeviceOrientation/event-after-navigation.html: Added.
  • fast/dom/DeviceOrientation/resources/event-after-navigation-new.html: Added.
  • fast/dom/DeviceOrientation/script-tests/event-after-navigation.js: Added.
6:48 AM Changeset in webkit [69763] by pfeldman@chromium.org
  • 9 edits in trunk/WebCore

2010-10-14 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Move load and dom content event timers into InspectorController.
​https://bugs.webkit.org/show_bug.cgi?id=47668

  • inspector/CodeGeneratorInspector.pm:
  • inspector/Inspector.idl:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::populateScriptObjects): (WebCore::InspectorController::mainResourceFiredDOMContentEvent): (WebCore::InspectorController::mainResourceFiredLoadEvent):
  • inspector/InspectorController.h:
  • inspector/InspectorResource.cpp: (WebCore::InspectorResource::InspectorResource): (WebCore::InspectorResource::updateScriptObject):
  • inspector/InspectorResource.h:
  • inspector/front-end/inspector.js: (WebInspector.updateResource): (WebInspector.domContentEventFired): (WebInspector.loadEventFired):
6:18 AM Changeset in webkit [69762] by abecsi@webkit.org
  • 2 edits in trunk

2010-10-14 Andras Becsi <​abecsi@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt] Fix -Werror after r68637 on x86 platforms.
Qt's build system sets QT_ARCH statically to i386 or x86_64 accordingly,
so check for this instead of only checking for x86.

  • WebKit.pri:
6:03 AM Changeset in webkit [69761] by pfeldman@chromium.org
  • 11 edits
    1 move
    1 add
    1 delete in trunk/WebCore

2010-10-14 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed. Re-landing r69757.

5:56 AM Changeset in webkit [69760] by podivilov@chromium.org
  • 6 edits in trunk/WebCore

2010-10-14 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: implement pausing on window events and timeouts
​https://bugs.webkit.org/show_bug.cgi?id=47542

  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::didInstallTimerImpl): (WebCore::InspectorInstrumentation::didRemoveTimerImpl): (WebCore::InspectorInstrumentation::willDispatchEventImpl): (WebCore::InspectorInstrumentation::didDispatchEventImpl): (WebCore::InspectorInstrumentation::willDispatchEventOnWindowImpl): (WebCore::InspectorInstrumentation::didDispatchEventOnWindowImpl): (WebCore::InspectorInstrumentation::willFireTimerImpl): (WebCore::InspectorInstrumentation::didFireTimerImpl): (WebCore::InspectorInstrumentation::pauseOnNativeEventIfNeeded): (WebCore::InspectorInstrumentation::cancelPauseOnNativeEvent):
  • inspector/InspectorInstrumentation.h:
  • inspector/front-end/BreakpointManager.js: (WebInspector.EventListenerBreakpoint.prototype.populateLabelElement): (WebInspector.EventListenerBreakpoint.prototype.populateStatusMessageElement): (WebInspector.EventListenerBreakpoint.prototype._condition): (WebInspector.EventListenerBreakpoint.prototype._uiEventName):
  • inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.EventListenerBreakpointsSidebarPane.prototype._populate):
5:43 AM Changeset in webkit [69759] by Csaba Osztrogonác
  • 2 edits in trunk/WebCore

2010-10-14 Csaba Osztrogonác <Csaba Osztrogonác>

Reviewed by Andreas Kling.

Canvas: "currentColor" should inherit the canvas element's color
​https://bugs.webkit.org/show_bug.cgi?id=40273

Warning fix after r69755. Missing default cases added.

  • html/canvas/CanvasStyle.cpp: (WebCore::parseColorOrCurrentColor): (WebCore::CanvasStyle::createFromString): (WebCore::CanvasStyle::createFromStringWithOverrideAlpha):
5:01 AM Changeset in webkit [69758] by pfeldman@chromium.org
  • 11 edits
    1 move
    1 add
    1 delete in trunk/WebCore

2010-10-14 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed. Rolling out r69757.

4:38 AM Changeset in webkit [69757] by pfeldman@chromium.org
  • 11 edits
    1 move
    1 add
    1 delete in trunk/WebCore

2010-10-14 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: extract content-related methods into InspectorResourceAgent.
​https://bugs.webkit.org/show_bug.cgi?id=47415

This is needed for resource-tracking-less operation of resources panel.

  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • inspector/InspectorCSSAgent.cpp:
  • inspector/InspectorResource.cpp: (WebCore::InspectorResource::type): (WebCore::InspectorResource::sourceString): (WebCore::InspectorResource::sourceBytes):
  • inspector/InspectorResource.h:
  • inspector/InspectorResourceAgent.cpp: Added. (WebCore::InspectorResourceAgent::resourceContent): (WebCore::InspectorResourceAgent::resourceContentBase64): (WebCore::InspectorResourceAgent::resourceData): (WebCore::InspectorResourceAgent::cachedResourceType): (WebCore::InspectorResourceAgent::cachedResource):
  • inspector/InspectorResourceAgent.h: Added.
  • inspector/InspectorStyleSheet.cpp: (WebCore::InspectorStyleSheet::resourceStyleSheetText):
  • inspector/InspectorUtilities.cpp: Removed.
  • inspector/InspectorUtilities.h: Removed.
4:02 AM Changeset in webkit [69756] by hayato@chromium.org
  • 2 edits in trunk/LayoutTests

2010-10-14 Hayato Ito <​hayato@chromium.org>

Unreviewed, build fix.

Skip a test that does not have an expected result.
<​http://trac.webkit.org/changeset/69751> lacked prefix of 'platform/gtk'.

  • platform/gtk/Skipped:
3:47 AM Changeset in webkit [69755] by andreas.kling@nokia.com
  • 9 edits
    3 adds in trunk

2010-10-14 Andreas Kling <​kling@webkit.org>

Reviewed by Darin Adler.

Canvas: "currentColor" should inherit the canvas element's color
​https://bugs.webkit.org/show_bug.cgi?id=40273

Add support for "currentColor" in CanvasRenderingContext2D APIs.
If the canvas is in-document, "currentColor" is replaced by canvas.style.color,
otherwise we use fully opaque black.

For gradient addColorStop(), "currentColor" always means fully opaque black.

Spec link:
​http://www.whatwg.org/specs/web-apps/current-work/#2dcontext

Test: fast/canvas/canvas-currentColor.html

  • html/canvas/CanvasGradient.cpp: (WebCore::CanvasGradient::addColorStop):
  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::setStrokeStyle): (WebCore::CanvasRenderingContext2D::setFillStyle): (WebCore::CanvasRenderingContext2D::setShadowColor): (WebCore::CanvasRenderingContext2D::setShadow):
  • html/canvas/CanvasStyle.cpp: (WebCore::parseColor): (WebCore::currentColor): (WebCore::parseColorOrCurrentColor): (WebCore::CanvasStyle::CanvasStyle): (WebCore::CanvasStyle::createFromString): (WebCore::CanvasStyle::createFromStringWithOverrideAlpha): (WebCore::CanvasStyle::isEquivalentColor): (WebCore::CanvasStyle::applyStrokeColor): (WebCore::CanvasStyle::applyFillColor):
  • html/canvas/CanvasStyle.h: (WebCore::CanvasStyle::isCurrentColor): (WebCore::CanvasStyle::hasOverrideAlpha): (WebCore::CanvasStyle::overrideAlpha):

2010-10-14 Andreas Kling <​kling@webkit.org>

Reviewed by Darin Adler.

Canvas: "currentColor" should inherit the canvas element's color
​https://bugs.webkit.org/show_bug.cgi?id=40273

Added test to verify support for "currentColor" value in CanvasRenderingContext2D.

Also unskipped 3 tests which now pass:

  • canvas/philip/tests/2d.fillStyle.parse.current.basic.html
  • canvas/philip/tests/2d.fillStyle.parse.current.changed.html
  • canvas/philip/tests/2d.fillStyle.parse.current.removed.html

Spec link:
​http://www.whatwg.org/specs/web-apps/current-work/#2dcontext

  • fast/canvas/canvas-currentColor-expected.txt: Added.
  • fast/canvas/canvas-currentColor.html: Added.
  • fast/canvas/script-tests/canvas-currentColor.js: Added. (attachCanvasToDocument): (tryLinearGradientColor): (tryRadialGradientColor):
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
2:20 AM Changeset in webkit [69754] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed fix after r69749.

  • platform/qt/fast/dom/Window/window-properties-expected.txt: Updated.
2:13 AM Changeset in webkit [69753] by commit-queue@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-10-14 Anton Faern <​anton@bladehawke.com>

Reviewed by Csaba Osztrogonác.

​https://bugs.webkit.org/show_bug.cgi?id=47658
NetBSD was not included in the WTF_PLATFORM_FOO to WTF_OS_FOO
change. This means that OS(NETBSD) is also undefined.

  • wtf/Platform.h: s/_PLATFORM_/_OS_/ for NetBSD
1:42 AM Changeset in webkit [69752] by yurys@chromium.org
  • 4 edits
    2 adds in trunk

2010-10-08 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [REGRESSION] Scripts panel: the bubble shows wrong values
​https://bugs.webkit.org/show_bug.cgi?id=47358

Test: inspector/debugger-eval-on-call-frame.html

  • inspector/front-end/InjectedScript.js: (injectedScriptConstructor.): don't embrace expression evaluated in the local scope of a call frame into with(window) to avoid shadowing local variables by global ones.

2010-10-08 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [REGRESSION] Scripts panel: the bubble shows wrong values
​https://bugs.webkit.org/show_bug.cgi?id=47358

  • inspector/debugger-eval-on-call-frame-expected.txt: Added.
  • inspector/debugger-eval-on-call-frame.html: Added.
1:39 AM Changeset in webkit [69751] by hayato@chromium.org
  • 2 edits in trunk/LayoutTests

2010-10-14 Hayato Ito <​hayato@chromium.org>

Unreviewed, build fix.

Skip a test that does not have an expected result.

  • platform/gtk/Skipped:
1:18 AM Changeset in webkit [69750] by andreas.kling@nokia.com
  • 3 edits in trunk/LayoutTests

2010-10-14 Andreas Kling <​kling@webkit.org>

Reviewed by Dirk Schulze.

svg/custom/use-on-symbol-inside-pattern.svg is failing
​https://bugs.webkit.org/show_bug.cgi?id=17393

Re-enable this test since the debugString() discrepancy issue
disappeared with <​http://trac.webkit.org/changeset/69386>

  • platform/mac-tiger/Skipped:
  • platform/win/Skipped:
1:02 AM Changeset in webkit [69749] by abarth@webkit.org
  • 14 edits
    4 adds in trunk

2010-10-13 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

Implement getParameter from the URL API
​https://bugs.webkit.org/show_bug.cgi?id=46610

Test various interesting cases in parameter parsing.

  • fast/dom/anchor-getParameter-expected.txt: Added.
  • fast/dom/anchor-getParameter.html: Added.
  • http/tests/misc/location-getParameter-expected.txt: Added.
  • http/tests/misc/location-getParameter.html: Added.

2010-10-13 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

Implement getParameter from the URL API
​https://bugs.webkit.org/show_bug.cgi?id=46610

Another API from
​https://docs.google.com/document/edit?id=1r_VTFKApVOaNIkocrg0z-t7lZgzisTuGTXkdzAk4gLU&hl=en#
getParameter lets a web site easily read the value of a URL parameter.
This API is for the simple case of a non-repeated parameter name.
getParameterAll will handle repeated parameter names in a future patch.

Tests: fast/dom/anchor-getParameter.html

http/tests/misc/location-getParameter.html

  • html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::getParameter):
  • html/HTMLAnchorElement.h:
  • html/HTMLAnchorElement.idl:
  • page/Location.cpp: (WebCore::Location::getParameter):
  • page/Location.h:
  • page/Location.idl:
  • platform/KURL.cpp: (WebCore::KURL::copyParsedQueryTo):
  • platform/KURLGoogle.cpp: (WebCore::KURL::copyParsedQueryTo):
  • platform/KURL.h:
12:53 AM Changeset in webkit [69748] by alex
  • 2 edits in trunk/WebCore

2010-10-14 Alejandro G. Castro <​alex@igalia.com>

Unreviewed. GTK build fix.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::sendRequestCallback):
12:18 AM Changeset in webkit [69747] by commit-queue@webkit.org
  • 8 edits
    6 adds in trunk

2010-10-14 Adrienne Walker <​enne@google.com>

Reviewed by James Robinson.

Add a test for very large image layers. Skip this test for mac-wk2
because of the use of layerTreeAsText().
​https://bugs.webkit.org/show_bug.cgi?id=47016

  • compositing/tiling/huge-layer-img.html: Added.
  • platform/chromium-gpu/compositing/tiling/huge-layer-img-expected.txt: Added.
  • platform/mac-wk2/Skipped:
  • platform/mac/compositing/tiling/huge-layer-img-expected.txt: Added.

2010-10-14 Adrienne Walker <​enne@google.com>

Reviewed by James Robinson.

Add a short-term solution for large layers. Layers that are too
large to be contained in a single texture just upload the portion of
the layer that is within the content rect. A longer-term solution
is still tiling with proper memory management. Layers that have full
3D transforms (more than just translations) are still not drawn.
​https://bugs.webkit.org/show_bug.cgi?id=47016

Test: compositing/tiling

  • platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::ContentLayerChromium): (WebCore::ContentLayerChromium::requiresClippedUpdateRect): (WebCore::ContentLayerChromium::calculateClippedUpdateRect): (WebCore::ContentLayerChromium::updateContents): (WebCore::ContentLayerChromium::updateTextureRect): (WebCore::ContentLayerChromium::draw):
  • platform/graphics/chromium/ContentLayerChromium.h:
  • platform/graphics/chromium/ImageLayerChromium.cpp: (WebCore::ImageLayerChromium::updateContents):
  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::drawLayers):
  • platform/graphics/chromium/LayerRendererChromium.h: (WebCore::LayerRendererChromium::rootLayerContentRect):
12:10 AM Changeset in webkit [69746] by crogers@google.com
  • 1 edit
    2 adds in trunk/WebCore

2010-10-14 Chris Rogers <​crogers@google.com>

Reviewed by Chris Fleizach.

Add DelayDSPKernel files
​https://bugs.webkit.org/show_bug.cgi?id=47518

No new tests since audio API is not yet implemented.

  • webaudio/DelayDSPKernel.cpp: Added. (WebCore::DelayDSPKernel::DelayDSPKernel): (WebCore::DelayDSPKernel::process): (WebCore::DelayDSPKernel::reset):
  • webaudio/DelayDSPKernel.h: Added. (WebCore::DelayDSPKernel::maxDelayTime): (WebCore::DelayDSPKernel::setDelayFrames): (WebCore::DelayDSPKernel::delayProcessor):

Oct 13, 2010:

11:58 PM Changeset in webkit [69745] by commit-queue@webkit.org
  • 8 edits in trunk/LayoutTests

2010-10-13 James Simonsen <​simonjam@chromium.org>

Reviewed by Adam Barth.

Sync tests from html5lib.
​https://bugs.webkit.org/show_bug.cgi?id=47627

  • html5lib/resources/adoption02.dat: Copied from html5lib.
  • html5lib/resources/entities01.dat: Ditto.
  • html5lib/resources/pending-spec-changes.dat: Ditto.
  • html5lib/resources/tests21.dat: Ditto.
  • html5lib/runner-expected.txt: 2 tests now pass.
  • platform/chromium/html5lib/runner-expected.txt: Ditto.
  • platform/win/html5lib/runner-expected.txt: Ditto.
11:55 PM Changeset in webkit [69744] by eric@webkit.org
  • 4 edits in trunk/WebKitTools

2010-10-13 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

beat diff_parser with the ugly stick
​https://bugs.webkit.org/show_bug.cgi?id=47626

  • Scripts/webkitpy/common/checkout/diff_parser.py:
  • Scripts/webkitpy/style/patchreader.py:
  • Scripts/webkitpy/style/patchreader_unittest.py:
11:45 PM Changeset in webkit [69743] by commit-queue@webkit.org
  • 5 edits in trunk/JavaScriptCore

2010-10-13 David Goodwin <​david_goodwin@apple.com>

Reviewed by Oliver Hunt.

ARMv7 JIT should generated conditional branches when possible
​https://bugs.webkit.org/show_bug.cgi?id=47384

Use different jump padding sizes for conditional and unconditional
jumps (12 bytes and 10 bytes respectively). This allows the JIT to
include the IT instruction as part of the conditional jump sequence
which in turn allows it to optimize away the IT using an ARMv7
conditional branch instruction. Use 2-byte B(T1) and 4-byte B(T3) for
conditional branches when displacement is in range. Also use IT/B(T4)
for conditional branch when displacement does not fit in B(T3).

For unconditional jump, instruction selection options are:
B(T2), B(T4), MOVW/MOVT/BX. For conditional jump, instruction selection
options are: B(T1), B(T3), IT/B(T4), ITTT/MOVW/MOVT/BX.

  • assembler/ARMv7Assembler.cpp:
  • assembler/ARMv7Assembler.h: (JSC::ARMv7Assembler::JmpSrc::JmpSrc): (JSC::ARMv7Assembler::ifThenElse): (JSC::ARMv7Assembler::jumpSizeDelta): (JSC::ARMv7Assembler::canCompact): (JSC::ARMv7Assembler::computeJumpType): (JSC::ARMv7Assembler::link): (JSC::ARMv7Assembler::canBeJumpT1): (JSC::ARMv7Assembler::canBeJumpT3): (JSC::ARMv7Assembler::canBeJumpT4): (JSC::ARMv7Assembler::linkJumpT1): (JSC::ARMv7Assembler::linkJumpT3): (JSC::ARMv7Assembler::linkJumpT4): (JSC::ARMv7Assembler::linkConditionalJumpT4): (JSC::ARMv7Assembler::linkBX): (JSC::ARMv7Assembler::linkConditionalBX): (JSC::ARMv7Assembler::linkJumpAbsolute):
  • assembler/LinkBuffer.h: (JSC::LinkBuffer::linkCode):
  • assembler/MacroAssemblerARMv7.h: (JSC::MacroAssemblerARMv7::canCompact): (JSC::MacroAssemblerARMv7::computeJumpType): (JSC::MacroAssemblerARMv7::jumpSizeDelta): (JSC::MacroAssemblerARMv7::jump): (JSC::MacroAssemblerARMv7::nearCall): (JSC::MacroAssemblerARMv7::call): (JSC::MacroAssemblerARMv7::ret): (JSC::MacroAssemblerARMv7::tailRecursiveCall): (JSC::MacroAssemblerARMv7::makeJump): (JSC::MacroAssemblerARMv7::makeBranch):
11:32 PM Changeset in webkit [69742] by Martin Robinson
  • 7 edits in trunk

2010-10-13 Sergio Villar Senin <​svillar@igalia.com>

Reviewed by Martin Robinson.

WebKitGtk+ to use the new API from the imported SoupURILoader code

[GTK] Add HTTP caching support
​https://bugs.webkit.org/show_bug.cgi?id=44261

ResourceHandleSoup now does everything via SoupURILoader. This means
that all URLs are handled via the same code path, where WebCore simply
asks libsoup for a WebKitSoupRequest and the request returns an input
stream. Many of ResourceHandleSoup's data members are now PlatformRefPtr
as well, to simplify reference counting

  • platform/network/ResourceHandleInternal.h: (WebCore::ResourceHandleInternal::ResourceHandleInternal):
  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandleInternal::~ResourceHandleInternal): (WebCore::ResourceHandle::~ResourceHandle): (WebCore::restartedCallback): (WebCore::gotChunkCallback): (WebCore::parseDataUrl): (WebCore::cleanupSoupRequestOperation): (WebCore::sendRequestCallback): (WebCore::startHttp): (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::cancel): (WebCore::closeCallback): (WebCore::readCallback): (WebCore::startGio):
  • platform/network/soup/ResourceRequest.h:
  • platform/network/soup/ResourceRequestSoup.cpp: (WebCore::ResourceRequest::updateSoupMessage):

2010-10-13 Sergio Villar Senin <​svillar@igalia.com>

Reviewed by Martin Robinson.

WebKitGtk+ to use the new API from the imported SoupURILoader code

[GTK] Add HTTP caching support
​https://bugs.webkit.org/show_bug.cgi?id=44261

ResourceHandleInternal m_msg is now called m_soupMessage.

  • webkit/webkitdownload.cpp: (webkit_download_new_with_handle): (webkit_download_start):
11:28 PM Changeset in webkit [69741] by Martin Robinson
  • 3 edits in trunk/LayoutTests

2010-10-13 Martin Robinson <​mrobinson@igalia.com>

Rebaseline canvas/philip/tests/2d.gradient.radial.negative.html. It seems
that the result for this test is only differing by two newlines. Also skip
a failing test on GTK+.

  • canvas/philip/tests/2d.gradient.radial.negative-expected.txt: Rebaseline.
  • platform/gtk/Skipped: Skip failing test.
10:54 PM Changeset in webkit [69740] by eric@webkit.org
  • 3 edits
    2 adds in trunk/WebKitTools

2010-10-13 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Break LayoutTestResults out into its own file
​https://bugs.webkit.org/show_bug.cgi?id=47637

  • Scripts/webkitpy/common/net/buildbot.py:
  • Scripts/webkitpy/common/net/buildbot_unittest.py:
  • Scripts/webkitpy/common/net/layouttestresults.py: Added.
  • Scripts/webkitpy/common/net/layouttestresults_unittest.py: Added.
10:49 PM Changeset in webkit [69739] by hamaji@chromium.org
  • 2 edits
    7 adds in trunk/LayoutTests

2010-10-13 Shinichiro Hamaji <​hamaji@chromium.org>

Update chromium's test expectations.

  • platform/chromium-linux/fast/text/backslash-to-yen-sign-euc-expected.checksum: Added.
  • platform/chromium-linux/fast/text/backslash-to-yen-sign-euc-expected.png: Added.
  • platform/chromium-linux/fast/text/backslash-to-yen-sign-euc-expected.txt: Added.
  • platform/chromium-mac/fast/text/backslash-to-yen-sign-euc-expected.checksum: Added.
  • platform/chromium-win/fast/text/backslash-to-yen-sign-euc-expected.checksum: Added.
  • platform/chromium-win/fast/text/backslash-to-yen-sign-euc-expected.png: Added.
  • platform/chromium-win/fast/text/backslash-to-yen-sign-euc-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
10:28 PM Changeset in webkit [69738] by abarth@webkit.org
  • 3 edits in trunk/WebKitTools

2010-10-13 Adam Barth <​abarth@webkit.org>

Unreviewed.

Chromium port can't run JavaScriptCore tests
​https://bugs.webkit.org/show_bug.cgi?id=47654

This lets webkit-patch build-and-test work on Chromium.

  • Scripts/webkitpy/common/config/ports.py:
  • Scripts/webkitpy/tool/steps/runtests.py:
10:04 PM Changeset in webkit [69737] by abarth@webkit.org
  • 9 edits in trunk/WebKitTools

2010-10-13 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Make --port a global option and pass the port information to the commit-queue subprocess
​https://bugs.webkit.org/show_bug.cgi?id=47650

This patch paves the way to run the commit-queue on a non-Mac port.

  • Scripts/webkitpy/tool/commands/queues.py:
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
  • Scripts/webkitpy/tool/commands/queuestest.py:
  • Scripts/webkitpy/tool/main.py:
  • Scripts/webkitpy/tool/steps/options.py:
  • Scripts/webkitpy/tool/steps/preparechangelog.py:
  • Scripts/webkitpy/tool/steps/runtests.py:
  • Scripts/webkitpy/tool/steps/update.py:
10:00 PM Changeset in webkit [69736] by abarth@webkit.org
  • 3 edits in trunk/WebKitTools

2010-10-13 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Introduce the ChromiumXVFBPort for running commit-queue on EC2
​https://bugs.webkit.org/show_bug.cgi?id=47653

I'm not entirely sure this is the best way to do this, but we need to
run the tests under XVFB on EC2 because the EC2 instances don't have a
real monitor hooked up. This patch adds a ChromiumXVFBPort that runs
that way. The idea is that XVFB is like a platform for the Chromium
port, but we don't have a real notion of platform separate from port.

  • Scripts/webkitpy/common/config/ports.py:
9:55 PM Changeset in webkit [69735] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

2010-10-12 Abhishek Arya <​inferno@chromium.org>

Reviewed by Darin Adler.

Prevent block logical height of a root inline box from overflowing by clamping it
at INT_MAX. Otherwise, we will not be able to properly dirty the set of lines during
removal a floating object.
​https://bugs.webkit.org/show_bug.cgi?id=45611

Test: fast/overflow/overflow-block-logical-height-crash.html

  • rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::alignBoxesInBlockDirection):

2010-10-12 Abhishek Arya <​inferno@chromium.org>

Reviewed by Darin Adler.

Tests that overflowing the block logical height of a root inline box does not result in crash.
​https://bugs.webkit.org/show_bug.cgi?id=45611

  • fast/overflow/overflow-block-logical-height-crash-expected.txt: Added.
  • fast/overflow/overflow-block-logical-height-crash.html: Added.
9:11 PM Changeset in webkit [69734] by weinig@apple.com
  • 3 edits in trunk/WebKit2

Memory smasher in WebKit2 InjectedBundleHitTestResult::absoluteLinkURL
​https://bugs.webkit.org/show_bug.cgi?id=47648

Reviewed by Jon Honeycutt.

  • WebProcess/InjectedBundle/InjectedBundleHitTestResult.cpp:

(WebKit::InjectedBundleHitTestResult::absoluteLinkURL):

  • WebProcess/InjectedBundle/InjectedBundleHitTestResult.h: Return a String instead of

a const String&.

9:11 PM Changeset in webkit [69733] by weinig@apple.com
  • 2 edits in trunk/WebKit2

PlatformMouseEvents need to contain modifier flags
​https://bugs.webkit.org/show_bug.cgi?id=47651

Reviewed by Jon Honeycutt.

  • Shared/WebEventConversion.cpp:

(WebKit::WebKit2PlatformMouseEvent::WebKit2PlatformMouseEvent):
Fill in m_modifierFlags.

7:40 PM Changeset in webkit [69732] by mrowe@apple.com
  • 5 edits in branches/safari-533.19-branch

Versioning.

7:36 PM Changeset in webkit [69731] by mrowe@apple.com
  • 1 copy in tags/Safari-533.19.3

New tag.

7:31 PM Changeset in webkit [69730] by mrowe@apple.com
  • 4 edits in branches/safari-533.19-branch/WebCore

Merge r69596.

7:31 PM Changeset in webkit [69729] by mrowe@apple.com
  • 5 edits in branches/safari-533.19-branch

Versioning.

7:16 PM Changeset in webkit [69728] by commit-queue@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-10-13 Fridrich Strba <​fridrich.strba@bluewin.ch>

Reviewed by Darin Adler.

Don't depend on Windows on sched_yield and sched.h
​https://bugs.webkit.org/show_bug.cgi?id=45543

sched.h is part of pthreads and sched_yield is implemented
in pthreads-win32 as Sleep(0). This patch avoids a gratuitous
dependency on pthreads-win32 in this file.

  • wtf/TCSpinLock.h: (TCMalloc_SlowLock):
7:13 PM Changeset in webkit [69727] by jamesr@google.com
  • 7 edits in trunk

2010-09-23 James Robinson <​jamesr@chromium.org>

Reviewed by Darin Adler.

Canvas: radialGradient with negative radius should throw exception
​https://bugs.webkit.org/show_bug.cgi?id=37176

Remove test from skipped lists now that it passes.

  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:

2010-10-13 James Robinson <​jamesr@chromium.org>

Reviewed by Darin Adler.

Throw INDEX_SIZE_ERR exception if createRadialGradient is called with a negative radius
Canvas: radialGradient with negative radius should throw exception
​https://bugs.webkit.org/show_bug.cgi?id=37176

This matches the canvas 2d specification, Opera, IE9 beta and our behavior for arc()
and arcTo(). Also fixes some PassRefPtr/RefPtr errors in this file.

Test: canvas/philip/tests/2d.gradient.radial.negative.html

  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::createLinearGradient): (WebCore::CanvasRenderingContext2D::createRadialGradient): (WebCore::createEmptyImageData): (WebCore::CanvasRenderingContext2D::measureText):
7:03 PM Changeset in webkit [69726] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-10-13 Fridrich Strba <​fridrich.strba@bluewin.ch>

Reviewed by Darin Adler.

Add WebCore/plugins/win directory to CFLAGS
​https://bugs.webkit.org/show_bug.cgi?id=45547

  • GNUmakefile.am:
6:30 PM Changeset in webkit [69725] by Martin Robinson
  • 2 edits in trunk/WebCore

2010-10-13 Martin Robinson <​mrobinson@igalia.com>

Build fix for older versions of libsoup.

  • platform/network/soup/cache/soup-request-file.c: (webkit_soup_request_file_ensure_file): Access the path member of the SoupURI directly.
6:26 PM WebKit Team edited by hayato@chromium.org
(diff)
6:12 PM WebKit Team edited by tkent@chromium.org
Add DRT/Chromium to tkent's area (diff)
6:08 PM Changeset in webkit [69724] by kinuko@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-10-13 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by Jian Li.

[Chromium] Enable FILE_SYSTEM by default for chromium
​https://bugs.webkit.org/show_bug.cgi?id=47639

  • features.gypi: Add FILE_SYSTEM=1. Also remove FILE_READER=1 as it seems to be not used anymore.
6:01 PM Changeset in webkit [69723] by kseo@webkit.org
  • 3 edits
    3 adds in trunk/JavaScriptCore

[BREWMP] Port unicode
​https://bugs.webkit.org/show_bug.cgi?id=45716

Reviewed by Kent Tamura.

Brew MP port uses only the subset of ICU library to reduce the binary size.
Follow the WinCE's implementation.

  • wtf/Platform.h:
  • wtf/unicode/Unicode.h:
  • wtf/unicode/brew/UnicodeBrew.cpp: Added.

(WTF::Unicode::toLower):
(WTF::Unicode::toUpper):
(WTF::Unicode::foldCase):
(WTF::Unicode::isPrintableChar):
(WTF::Unicode::isUpper):
(WTF::Unicode::isLower):
(WTF::Unicode::isDigit):
(WTF::Unicode::isPunct):
(WTF::Unicode::isAlphanumeric):
(WTF::Unicode::toTitleCase):
(WTF::Unicode::direction):
(WTF::Unicode::category):
(WTF::Unicode::decompositionType):
(WTF::Unicode::combiningClass):
(WTF::Unicode::mirroredChar):
(WTF::Unicode::digitValue):
(WTF::Unicode::isSpace):
(WTF::Unicode::isLetter):

  • wtf/unicode/brew/UnicodeBrew.h: Added.

(WTF::Unicode::isArabicChar):
(WTF::Unicode::isSeparatorSpace):
(WTF::Unicode::hasLineBreakingPropertyComplexContext):
(WTF::Unicode::hasLineBreakingPropertyComplexContextOrIdeographic):
(WTF::Unicode::umemcasecmp):

5:59 PM WebKit Team edited by yutak@chromium.org
Add Yuta Kitamura (yutak). (diff)
5:49 PM Changeset in webkit [69722] by kseo@webkit.org
  • 1 edit
    2 adds in trunk/WebCore

[BREWMP] Add TextBoundaries and TextBreakIterator
​https://bugs.webkit.org/show_bug.cgi?id=46105

Reviewed by Kent Tamura.

Copy the implementation of WinCE port.

  • platform/text/brew/TextBoundariesBrew.cpp: Added.

(WebCore::findNextWordFromIndex):
(WebCore::findWordBoundary):

  • platform/text/brew/TextBreakIteratorBrew.cpp: Added.

(WebCore::isCharStop):
(WebCore::isLineStop):
(WebCore::isSentenceStop):
(WebCore::TextBreakIterator::reset):
(WebCore::TextBreakIterator::following):
(WebCore::TextBreakIterator::preceding):
(WebCore::WordBreakIterator::first):
(WebCore::WordBreakIterator::next):
(WebCore::WordBreakIterator::previous):
(WebCore::CharBreakIterator::first):
(WebCore::CharBreakIterator::next):
(WebCore::CharBreakIterator::previous):
(WebCore::LineBreakIterator::first):
(WebCore::LineBreakIterator::next):
(WebCore::LineBreakIterator::previous):
(WebCore::SentenceBreakIterator::first):
(WebCore::SentenceBreakIterator::next):
(WebCore::SentenceBreakIterator::previous):
(WebCore::wordBreakIterator):
(WebCore::characterBreakIterator):
(WebCore::lineBreakIterator):
(WebCore::sentenceBreakIterator):
(WebCore::textBreakFirst):
(WebCore::textBreakNext):
(WebCore::textBreakPreceding):
(WebCore::textBreakFollowing):
(WebCore::textBreakCurrent):
(WebCore::isTextBreak):
(WebCore::cursorMovementIterator):

5:39 PM Changeset in webkit [69721] by jorlow@chromium.org
  • 57 edits in trunk

2010-10-13 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Nate Chapin.

IndexedDB should fire some errors synchronously
​https://bugs.webkit.org/show_bug.cgi?id=47530

  • storage/indexeddb/objectstore-basics-expected.txt:
  • storage/indexeddb/objectstore-basics.html:
  • storage/indexeddb/objectstore-removeobjectstore-expected.txt:
  • storage/indexeddb/objectstore-removeobjectstore.html:

2010-10-13 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Nate Chapin.

IndexedDB should fire some errors synchronously
​https://bugs.webkit.org/show_bug.cgi?id=47530

Add dumb plumbing to pass around exception codes.
Utilize that plumbing in the backend to fire some
errors synchronously.
Verify that create/remove* functions are only called
in setVersionTransactions (and raise when not).
Remove plumbing for obsolete IDBDatabase.objectStore
Remove obsolete mode param.

  • storage/IDBCursor.cpp: (WebCore::IDBCursor::update): (WebCore::IDBCursor::continueFunction): (WebCore::IDBCursor::remove):
  • storage/IDBCursor.h: (WebCore::IDBCursor::continueFunction):
  • storage/IDBCursor.idl:
  • storage/IDBCursorBackendImpl.cpp: (WebCore::IDBCursorBackendImpl::update): (WebCore::IDBCursorBackendImpl::continueFunction): (WebCore::IDBCursorBackendImpl::remove):
  • storage/IDBCursorBackendImpl.h:
  • storage/IDBCursorBackendInterface.h:
  • storage/IDBDatabase.cpp: (WebCore::IDBDatabase::IDBDatabase): (WebCore::IDBDatabase::createObjectStore): (WebCore::IDBDatabase::removeObjectStore): (WebCore::IDBDatabase::setVersion): (WebCore::IDBDatabase::transaction):
  • storage/IDBDatabase.h: (WebCore::IDBDatabase::createObjectStore): (WebCore::IDBDatabase::transaction):
  • storage/IDBDatabase.idl:
  • storage/IDBDatabaseBackendImpl.cpp: (WebCore::IDBDatabaseBackendImpl::createObjectStore): (WebCore::IDBDatabaseBackendImpl::objectStore): (WebCore::IDBDatabaseBackendImpl::removeObjectStore): (WebCore::IDBDatabaseBackendImpl::setVersion): (WebCore::IDBDatabaseBackendImpl::transaction):
  • storage/IDBDatabaseBackendImpl.h:
  • storage/IDBDatabaseBackendInterface.h:
  • storage/IDBFactory.cpp: (WebCore::IDBFactory::open):
  • storage/IDBFactory.h: (WebCore::IDBFactory::open):
  • storage/IDBFactory.idl:
  • storage/IDBIndex.cpp: (WebCore::IDBIndex::openCursor): (WebCore::IDBIndex::openKeyCursor): (WebCore::IDBIndex::get): (WebCore::IDBIndex::getKey):
  • storage/IDBIndex.h: (WebCore::IDBIndex::openCursor): (WebCore::IDBIndex::openKeyCursor):
  • storage/IDBIndex.idl:
  • storage/IDBIndexBackendImpl.cpp: (WebCore::IDBIndexBackendImpl::openCursor): (WebCore::IDBIndexBackendImpl::openKeyCursor): (WebCore::IDBIndexBackendImpl::get): (WebCore::IDBIndexBackendImpl::getKey):
  • storage/IDBIndexBackendImpl.h:
  • storage/IDBIndexBackendInterface.h:
  • storage/IDBObjectStore.cpp: (WebCore::IDBObjectStore::get): (WebCore::IDBObjectStore::add): (WebCore::IDBObjectStore::put): (WebCore::IDBObjectStore::remove): (WebCore::IDBObjectStore::createIndex): (WebCore::IDBObjectStore::index): (WebCore::IDBObjectStore::removeIndex): (WebCore::IDBObjectStore::openCursor):
  • storage/IDBObjectStore.h: (WebCore::IDBObjectStore::add): (WebCore::IDBObjectStore::put): (WebCore::IDBObjectStore::createIndex): (WebCore::IDBObjectStore::openCursor):
  • storage/IDBObjectStore.idl:
  • storage/IDBObjectStoreBackendImpl.cpp: (WebCore::IDBObjectStoreBackendImpl::get): (WebCore::IDBObjectStoreBackendImpl::put): (WebCore::IDBObjectStoreBackendImpl::remove): (WebCore::IDBObjectStoreBackendImpl::createIndex): (WebCore::IDBObjectStoreBackendImpl::index): (WebCore::IDBObjectStoreBackendImpl::removeIndex): (WebCore::IDBObjectStoreBackendImpl::openCursor):
  • storage/IDBObjectStoreBackendImpl.h: (WebCore::IDBObjectStoreBackendImpl::name): (WebCore::IDBObjectStoreBackendImpl::keyPath): (WebCore::IDBObjectStoreBackendImpl::autoIncrement):
  • storage/IDBObjectStoreBackendInterface.h:
  • storage/IDBTransaction.cpp: (WebCore::IDBTransaction::objectStore):
  • storage/IDBTransaction.h:
  • storage/IDBTransactionBackendImpl.cpp: (WebCore::IDBTransactionBackendImpl::objectStore):

2010-10-13 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Nate Chapin.

IndexedDB should fire some errors synchronously
​https://bugs.webkit.org/show_bug.cgi?id=47530

  • public/WebIDBCursor.h:
  • public/WebIDBDatabase.h: (WebKit::WebIDBDatabase::transaction):
  • public/WebIDBFactory.h: (WebKit::WebIDBFactory::open):
  • public/WebIDBObjectStore.h:
  • public/WebIDBTransactionCallbacks.h:
  • src/IDBCursorBackendProxy.cpp: (WebCore::IDBCursorBackendProxy::update): (WebCore::IDBCursorBackendProxy::continueFunction): (WebCore::IDBCursorBackendProxy::remove):
  • src/IDBCursorBackendProxy.h:
  • src/IDBDatabaseProxy.cpp: (WebCore::IDBDatabaseProxy::createObjectStore): (WebCore::IDBDatabaseProxy::removeObjectStore): (WebCore::IDBDatabaseProxy::setVersion): (WebCore::IDBDatabaseProxy::transaction):
  • src/IDBDatabaseProxy.h:
  • src/IDBIndexBackendProxy.cpp: (WebCore::IDBIndexBackendProxy::openCursor): (WebCore::IDBIndexBackendProxy::openKeyCursor): (WebCore::IDBIndexBackendProxy::get): (WebCore::IDBIndexBackendProxy::getKey):
  • src/IDBIndexBackendProxy.h:
  • src/IDBObjectStoreProxy.cpp: (WebCore::IDBObjectStoreProxy::get): (WebCore::IDBObjectStoreProxy::put): (WebCore::IDBObjectStoreProxy::remove): (WebCore::IDBObjectStoreProxy::createIndex): (WebCore::IDBObjectStoreProxy::index): (WebCore::IDBObjectStoreProxy::removeIndex): (WebCore::IDBObjectStoreProxy::openCursor):
  • src/IDBObjectStoreProxy.h:
  • src/WebIDBCursorImpl.cpp: (WebKit::WebIDBCursorImpl::update): (WebKit::WebIDBCursorImpl::continueFunction): (WebKit::WebIDBCursorImpl::remove):
  • src/WebIDBCursorImpl.h:
  • src/WebIDBDatabaseImpl.cpp: (WebKit::WebIDBDatabaseImpl::createObjectStore): (WebKit::WebIDBDatabaseImpl::removeObjectStore): (WebKit::WebIDBDatabaseImpl::setVersion): (WebKit::WebIDBDatabaseImpl::transaction):
  • src/WebIDBDatabaseImpl.h:
  • src/WebIDBIndexImpl.cpp: (WebKit::WebIDBIndexImpl::openObjectCursor): (WebKit::WebIDBIndexImpl::openKeyCursor): (WebKit::WebIDBIndexImpl::getObject): (WebKit::WebIDBIndexImpl::getKey):
  • src/WebIDBIndexImpl.h:
  • src/WebIDBObjectStoreImpl.cpp: (WebKit::WebIDBObjectStoreImpl::get): (WebKit::WebIDBObjectStoreImpl::put): (WebKit::WebIDBObjectStoreImpl::remove): (WebKit::WebIDBObjectStoreImpl::createIndex): (WebKit::WebIDBObjectStoreImpl::index): (WebKit::WebIDBObjectStoreImpl::removeIndex): (WebKit::WebIDBObjectStoreImpl::openCursor):
  • src/WebIDBObjectStoreImpl.h:
5:36 PM Changeset in webkit [69720] by abarth@webkit.org
  • 1 edit
    4 adds in trunk/LayoutTests

2010-10-13 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

Incorrect use of alternate content inside the <object> element
​https://bugs.webkit.org/show_bug.cgi?id=11803

Our current behavior appears to match Firefox and the spec. Opera
seems to do what the bug reporter requests, but our current behavior
seems more sane.

  • fast/forms/fallback-content-submission-expected.txt: Added.
  • fast/forms/fallback-content-submission.html: Added.
  • fast/parser/object-with-textarea-fallback-expected.txt: Added.
  • fast/parser/object-with-textarea-fallback.html: Added.
5:32 PM Changeset in webkit [69719] by brettw@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-10-13 Brett Wilson <​brettw@chromium.org>

Reviewed by Darin Fisher.

Save and restore the GraphicsContext around setting the clip rect for
drawing text.
​https://bugs.webkit.org/show_bug.cgi?id=47634

  • src/WebFontImpl.cpp: (WebKit::WebFontImpl::drawText):
5:32 PM Changeset in webkit [69718] by Martin Robinson
  • 7 edits
    19 adds in trunk

2010-10-13 Sergio Villar Senin <​svillar@igalia.com>

Reviewed by Martin Robinson.

[GTK] Add HTTP caching support
​https://bugs.webkit.org/show_bug.cgi?id=44261

This patch adds HTTP caching support to libsoup networking backend.
This code will eventually be part of libsoup, but has been temporarily
imported into the WebCore tree for testing purposes. All libsoup code
is located in WebCore/platform/network/soup/cache. The webkit prefix
was added to all the symbols to prevent problems when this lands in
libsoup. Some external API was also added under webkit/ directory and
will be used by library clients to enable HTTP caching.

There are two parts to this imported code, the first one is the code
under WebCore/platform/network/soup/cache/ that contains all the
SoupURILoader code that supports the development of the cache. The
second part is the HTTP cache implementation located in
WebCore/platform/network/soup/cache/webkit/.

  • GNUmakefile.am:
  • platform/network/soup/cache/soup-directory-input-stream.c: Added. (webkit_soup_directory_input_stream_parse_info): (webkit_soup_directory_input_stream_read_next_file): (webkit_soup_directory_input_stream_read): (webkit_soup_directory_input_stream_close): (webkit_soup_directory_input_stream_class_init): (webkit_soup_directory_input_stream_init): (webkit_soup_directory_input_stream_new):
  • platform/network/soup/cache/soup-directory-input-stream.h: Added.
  • platform/network/soup/cache/soup-http-input-stream.c: Added. (webkit_soup_http_input_stream_finalize): (webkit_soup_http_input_stream_class_init): (webkit_soup_http_input_stream_seekable_iface_init): (webkit_soup_http_input_stream_init): (webkit_soup_http_input_stream_queue_message): (webkit_soup_http_input_stream_new): (webkit_soup_http_input_stream_got_headers): (webkit_soup_http_input_stream_got_chunk): (webkit_soup_http_input_stream_finished): (webkit_soup_http_input_stream_cancelled): (webkit_soup_http_input_stream_prepare_for_io): (webkit_soup_http_input_stream_done_io): (set_error_if_http_failed): (read_from_leftover): (webkit_soup_http_input_stream_send_internal): (send_sync_finished): (webkit_soup_http_input_stream_send): (webkit_soup_http_input_stream_read): (webkit_soup_http_input_stream_close): (wrapper_callback): (send_async_thread): (webkit_soup_http_input_stream_send_async_in_thread): (send_async_finished): (webkit_soup_http_input_stream_send_async_internal): (webkit_soup_http_input_stream_send_async): (webkit_soup_http_input_stream_send_finish): (read_async_done): (webkit_soup_http_input_stream_read_async): (webkit_soup_http_input_stream_read_finish): (webkit_soup_http_input_stream_close_async): (webkit_soup_http_input_stream_close_finish): (webkit_soup_http_input_stream_tell): (webkit_soup_http_input_stream_can_seek): (webkit_soup_http_input_stream_seek): (webkit_soup_http_input_stream_can_truncate): (webkit_soup_http_input_stream_truncate): (webkit_soup_http_input_stream_get_message):
  • platform/network/soup/cache/soup-http-input-stream.h: Added.
  • platform/network/soup/cache/soup-request-data.c: Added. (webkit_soup_request_data_init): (webkit_soup_request_data_finalize): (webkit_soup_request_data_check_uri): (uri_decoded_copy): (webkit_soup_request_data_send): (webkit_soup_request_data_get_content_length): (webkit_soup_request_data_get_content_type): (webkit_soup_request_data_class_init):
  • platform/network/soup/cache/soup-request-data.h: Added.
  • platform/network/soup/cache/soup-request-file.c: Added. (webkit_soup_request_file_get_file): (webkit_soup_request_file_init): (webkit_soup_request_file_finalize): (webkit_soup_request_file_check_uri): (webkit_soup_request_file_ftp_main_loop_quit): (webkit_soup_request_file_ensure_file_ftp): (webkit_soup_request_file_ensure_file): (webkit_soup_request_file_send): (webkit_soup_request_file_send_async_thread): (webkit_soup_request_file_send_async): (webkit_soup_request_file_send_finish): (webkit_soup_request_file_get_content_length): (webkit_soup_request_file_get_content_type): (webkit_soup_request_file_class_init):
  • platform/network/soup/cache/soup-request-file.h: Added.
  • platform/network/soup/cache/soup-request-http.c: Added. (webkit_soup_request_http_get_message): (webkit_soup_request_http_init): (webkit_soup_request_http_check_uri): (webkit_soup_request_http_finalize): (webkit_soup_request_http_send): (sent_async): (conditional_get_ready_cb): (send_async_cb): (webkit_soup_request_http_send_async): (webkit_soup_request_http_send_finish): (webkit_soup_request_http_get_content_length): (webkit_soup_request_http_get_content_type): (webkit_soup_request_http_class_init):
  • platform/network/soup/cache/soup-request-http.h: Added.
  • platform/network/soup/cache/soup-request.c: Added. (webkit_soup_request_init): (webkit_soup_request_finalize): (webkit_soup_request_set_property): (webkit_soup_request_get_property): (webkit_soup_request_initable_init): (webkit_soup_request_default_check_uri): (webkit_soup_request_default_send_async): (webkit_soup_request_default_send_finish): (webkit_soup_request_send): (webkit_soup_request_send_async): (webkit_soup_request_send_finish): (webkit_soup_request_class_init): (webkit_soup_request_initable_interface_init): (webkit_soup_request_get_uri): (webkit_soup_request_get_session): (webkit_soup_request_get_content_length): (webkit_soup_request_get_content_type):
  • platform/network/soup/cache/soup-request.h: Added.
  • platform/network/soup/cache/soup-requester.c: Added. (webkit_soup_requester_init): (finalize): (webkit_soup_requester_class_init): (init_request_types): (webkit_soup_requester_new): (webkit_soup_requester_request): (webkit_soup_requester_request_uri): (webkit_soup_scheme_is_valid): (webkit_soup_requester_add_protocol): (webkit_soup_requester_remove_protocol): (webkit_soup_error_quark):
  • platform/network/soup/cache/soup-requester.h: Added.
  • platform/network/soup/cache/webkit/soup-cache-private.h: Added.
  • platform/network/soup/cache/webkit/soup-cache.c: Added. (get_cacheability): (webkit_soup_cache_entry_free): (copy_headers): (update_headers): (webkit_soup_cache_entry_get_current_age): (webkit_soup_cache_entry_is_fresh_enough): (webkit_soup_message_get_cache_key): (webkit_soup_cache_entry_set_freshness): (webkit_soup_cache_entry_new): (webkit_soup_cache_writing_fixture_free): (close_ready_cb): (write_ready_cb): (msg_got_chunk_cb): (msg_got_body_cb): (webkit_soup_cache_entry_delete): (lru_compare_func): (cache_accepts_entries_of_size): (make_room_for_new_entry): (webkit_soup_cache_entry_insert_by_key): (msg_restarted_cb): (append_to_ready_cb): (msg_got_headers_cb): (webkit_soup_cache_send_response): (request_started): (attach): (webkit_soup_cache_session_feature_init): (webkit_soup_cache_init): (webkit_soup_cache_finalize): (webkit_soup_cache_set_property): (webkit_soup_cache_get_property): (webkit_soup_cache_constructed): (webkit_soup_cache_type_get_type): (webkit_soup_cache_class_init): (webkit_soup_cache_new): (webkit_soup_cache_has_response): (webkit_soup_cache_get_cacheability): (force_flush_timeout): (webkit_soup_cache_flush): (remove_cache_item): (webkit_soup_cache_clear): (webkit_soup_cache_generate_conditional_request): (pack_entry): (webkit_soup_cache_dump): (webkit_soup_cache_load): (webkit_soup_cache_set_max_size): (webkit_soup_cache_get_max_size):
  • platform/network/soup/cache/webkit/soup-cache.h: Added.

2010-10-13 Sergio Villar Senin <​svillar@igalia.com>

Reviewed by Martin Robinson.

[GTK] Add HTTP caching support
​https://bugs.webkit.org/show_bug.cgi?id=44261

Bump the required version of GLib. The serialization/deserialization
code of libsoup caching code uses GVariant, which was added to GLib in
version 2.24.

  • GNUmakefile.am: Add paths for soup HTTP cache code.
  • autotools/webkit.m4: Increase required glib version.

2010-10-13 Sergio Villar Senin <​svillar@igalia.com>

Reviewed by Martin Robinson.

[GTK] Add HTTP caching support
​https://bugs.webkit.org/show_bug.cgi?id=44261

Add include paths for the new soup HTTP cache code.

  • GNUmakefile.am: Add paths for the new soup HTTP cache code.
5:27 PM Changeset in webkit [69717] by barraclough@apple.com
  • 2 edits in trunk/WebCore

Chromium build fix.

  • bindings/v8/ScriptProfiler.cpp:
5:21 PM Changeset in webkit [69716] by cevans@google.com
  • 4 edits
    2 adds in trunk

2010-10-13 Chris Evans <​cevans@google.com>

Reviewed by Jian Li.

Blob / BlobBuilder can be put into bad state with wild integers and strings, due to integer overflows
​https://bugs.webkit.org/show_bug.cgi?id=47382

Add test for Blob.slice() integer overflow.

  • fast/files/blob-slice-overflow.html: Added.
  • fast/files/blob-slice-overflow-expected.txt: Added.

2010-10-13 Chris Evans <​cevans@google.com>

Reviewed by Jian Li.

Blob / BlobBuilder can be put into bad state with wild integers and strings, due to integer overflows
​https://bugs.webkit.org/show_bug.cgi?id=47382

Fix integer overflow errors in Blob.slice and BlobBuilder.append.

Test: fast/files/blob-slice-overflow.html

  • fileapi/Blob.cpp: (WebCore::Blob::slice): handle integer overflow properly.
  • fileapi/BlobBuilder.cpp: (WebCore::BlobBuilder::append): use correct type for vector length.
5:16 PM Changeset in webkit [69715] by barraclough@apple.com
  • 4 edits in trunk/WebCore

Build fix - remove some redundant references to ScriptString.

  • WebCore.gypi:
  • WebCore.pro:
  • bindings/v8/ScriptProfiler.cpp:
4:58 PM Changeset in webkit [69714] by commit-queue@webkit.org
  • 2 edits in trunk/WebKitTools

2010-10-13 Yi Shen <​yi.4.shen@nokia.com>

Reviewed by Antonio Gomes.

[Qt] QtTestBrowser shows two Url input fields
​https://bugs.webkit.org/show_bug.cgi?id=47613

  • QtTestBrowser/mainwindow.cpp: (MainWindow::MainWindow): (MainWindow::buildUI):
4:42 PM Changeset in webkit [69713] by commit-queue@webkit.org
  • 2 edits in trunk/WebKitTools

2010-10-13 Yi Shen <​yi.4.shen@nokia.com>

Reviewed by Tony Chang.

[gdb] Add pretty-print supports for UString, Identifier and JSString
​https://bugs.webkit.org/show_bug.cgi?id=47601

  • gdb/webkit.py:
4:34 PM Changeset in webkit [69712] by barraclough@apple.com
  • 4 edits
    3 deletes in trunk/WebCore

Bug 47621 - Remove bindings/v8/ScriptString
This is now redundant.

Reviewed by Oliver Hunt.

  • bindings/v8/ScriptCallFrame.h:

(WebCore::ScriptCallFrame::functionName):

  • bindings/v8/ScriptFunctionCall.cpp:
  • bindings/v8/ScriptFunctionCall.h:
  • bindings/v8/ScriptString.h: Removed.
  • bindings/v8/ScriptStringImpl.cpp: Removed.
  • bindings/v8/ScriptStringImpl.h: Removed.
4:12 PM Changeset in webkit [69711] by andersca@apple.com
  • 4 edits in trunk

Draw the find overlay holes
​https://bugs.webkit.org/show_bug.cgi?id=47631

Reviewed by John Sullivan.

WebCore:

Export symbols needed by WebKit2.

  • WebCore.exp.in:

WebKit2:

  • WebProcess/WebPage/FindPageOverlay.cpp:

(WebKit::FindPageOverlay::drawRect):
Draw the white frames and the holes.

4:10 PM Changeset in webkit [69710] by commit-queue@webkit.org
  • 7 edits in trunk

2010-10-13 James Simonsen <​simonjam@chromium.org>

Reviewed by Darin Adler.

Implement onreadystatechange event handler for Documents
​https://bugs.webkit.org/show_bug.cgi?id=26140

  • fast/dom/Document/readystate-expected.txt:
  • fast/dom/Document/readystate.html:

2010-10-13 James Simonsen <​simonjam@chromium.org>

Reviewed by Darin Adler.

Implement onreadystatechange event handler for Documents
​https://bugs.webkit.org/show_bug.cgi?id=26140

Test: fast/dom/Document/readystate.html

  • dom/Document.cpp: (WebCore::Document::setReadyState): Fire readystatechangeevent. (WebCore::Document::open): Clear event listeners.
  • dom/Document.h: Add readystatechange event.
  • dom/Document.idl: Ditto.
4:07 PM Changeset in webkit [69709] by Chris Fleizach
  • 3 edits in trunk/LayoutTests

No review. Fix layout test, now that behavior is correct.

AX: accessibilityIsIgnored not respected on ARIA tables
​https://bugs.webkit.org/show_bug.cgi?id=47564

  • accessibility/aria-hidden-with-elements-expected.txt:
  • accessibility/aria-hidden-with-elements.html:
4:03 PM Changeset in webkit [69708] by commit-queue@webkit.org
  • 2 edits in trunk/WebKitTools/EWSTools

Mark these scripts executable

3:53 PM Changeset in webkit [69707] by Chris Fleizach
  • 3 edits
    1 add in trunk

AX: accessibilityIsIgnored not respected on ARIA tables
​https://bugs.webkit.org/show_bug.cgi?id=47564

Reviewed by Beth Dakin.

WebCore:

For platforms that ignore column headers and header container objects (everything
except Mac) on accessibility tables, that choice needs to be respected in
ARIA tables as well.

GTK is the only open platform doing this, so I'll have to collect the result of this
test. It was copied from table-hierarchy.html, but changed to use ARIA tables.

Test: platform/gtk/accessibility/aria-table-hierarchy.html

  • accessibility/AccessibilityARIAGrid.cpp:

(WebCore::AccessibilityARIAGrid::addChildren):

LayoutTests:

Will gather the results from GTK after this runs.

  • platform/gtk/accessibility/aria-table-hierarchy.html: Added.
3:50 PM Changeset in webkit [69706] by hclam@chromium.org
  • 2 edits in trunk/WebCore

No longer ASSERT for LayerRenderer in VideoLayerChromium destructor
​https://bugs.webkit.org/show_bug.cgi?id=47432

Patch by Victoria Kirst <​vrk@google.com> on 2010-10-13
Reviewed by James Robinson.

  • platform/graphics/chromium/VideoLayerChromium.cpp:

(WebCore::VideoLayerChromium::cleanupResources):

3:48 PM Changeset in webkit [69705] by abarth@webkit.org
  • 1 edit
    1 add in trunk/WebKitTools

2010-10-13 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Add list of Ubuntu packages needed by the EWS bots
​https://bugs.webkit.org/show_bug.cgi?id=47628

I've been copy/pasting this list between bots, but it's better to have
this checked in.

  • EWSTools/ubuntu-ews-packages: Added.
3:46 PM Changeset in webkit [69704] by leandro@webkit.org
  • 5 edits in trunk

2010-10-13 Leandro Pereira <​leandro@profusion.mobi>

[EFL] Unreviewed. Build fix.

  • WebCoreSupport/FrameLoaderClientEfl.h: Use String instead of WebCore::String.

2010-10-13 Leandro Pereira <​leandro@profusion.mobi>

[EFL] Unreviewed. Build fix.

  • CMakeLists.txt: Add ContextShadow.cpp.
  • CMakeListsEfl.txt: Add ContextShadowCairo.cpp.
3:39 PM Changeset in webkit [69703] by commit-queue@webkit.org
  • 3 edits in trunk/WebKitTools

2010-10-13 Leandro Pereira <​leandro@profusion.mobi>

Reviewed by Csaba Osztrogonác.

[EFL] Adds a build slave.
​https://bugs.webkit.org/show_bug.cgi?id=47290

  • BuildSlaveSupport/build.webkit.org-config/config.json: Add an entry for a release build of the EFL port.
  • BuildSlaveSupport/build.webkit.org-config/master.cfg: Add platform flag to build the EFL port.
3:25 PM Changeset in webkit [69702] by zmo@google.com
  • 3 edits in trunk/LayoutTests

2010-10-13 Zhenyao Mo <​zmo@google.com>

Unreviewed, update WebGL test expectations.

  • platform/chromium/drt_expectations.txt:
  • platform/chromium/test_expectations.txt:
3:24 PM Changeset in webkit [69701] by Martin Robinson
  • 2 edits in trunk/WebCore

2010-10-13 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Holger Freyther.

[GTK] r69681 caused some tests to crash
​https://bugs.webkit.org/show_bug.cgi?id=47622

Properly initialize m_layerContext on the ContextShadow so that in situations
where beginShadowLayer bails out early with a null return value, it is set
to null. This may happen when the first call to beginShadowLayer on a particular
ContextShadow uses a region which is entirely outside the clip region or which
is empty.

  • platform/graphics/cairo/ContextShadow.cpp: (WebCore::ContextShadow::ContextShadow): Properly initialize m_layerContext.
2:44 PM Changeset in webkit [69700] by andersca@apple.com
  • 2 edits in trunk/WebCore

Don't set the fill/stroke colorspace before filling/stroking
​https://bugs.webkit.org/show_bug.cgi?id=47619

Reviewed by Beth Dakin.

Setting the colorspace has the side-effect of setting the color to black, which is
not what we want. When fill/stroke is called, a fill/stroke color should already have been set.

Pixel tests show no regressions from this change.

  • platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::strokeRect):

2:29 PM Changeset in webkit [69699] by bfulgham@webkit.org
  • 3 edits in trunk/WebCore

Unreviewed WinCairo build fix.
New ContextShadow class not built for Windows builds.

  • WebCore.vcproj/WebCore.vcproj: Add missing files for

building ContextShadow on WinCairo.

  • platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:

Add missing include for ContextShadow definition.

2:19 PM Changeset in webkit [69698] by tony@chromium.org
  • 5 edits
    1 delete in branches/chromium/552

Merge 69586 - 2010-10-12 Dave Moore <​davemoore@chromium.org>

Reviewed by Tony Chang.

Use new WebThemeEngine api on chromium / linux to draw scrollbars.
​https://bugs.webkit.org/show_bug.cgi?id=47473

  • platform/chromium/ChromiumBridge.h:
  • platform/chromium/ScrollbarThemeChromiumLinux.cpp:

2010-10-12 Dave Moore <​davemoore@chromium.org>

Reviewed by Tony Chang.

Use new WebThemeEngine api on chromium / linux to draw scrollbars.
​https://bugs.webkit.org/show_bug.cgi?id=47473

  • public/WebThemeEngine.h: Removed.
  • chromium/src/ChromiumBridge.cpp:

TBR=​tony@chromium.org

2:19 PM Changeset in webkit [69697] by Nate Chapin
  • 3 edits in trunk/LayoutTests

2010-10-13 Nate Chapin <Nate Chapin>

Unreviewed, Chromium expectations update.

Fix line endings in a couple of inspector test expectations.

  • platform/chromium/inspector/console-trace-in-eval-expected.txt:
  • platform/chromium/inspector/console-uncaught-exception-in-eval-expected.txt:
2:02 PM Changeset in webkit [69696] by tony@chromium.org
  • 2 edits in branches/chromium/552/WebKitTools

Merge 69591 - 2010-10-12 Tony Chang <​tony@chromium.org>

Unreviewed, fixing DRT compile on Windows after r69586.

  • DumpRenderTree/chromium/WebThemeEngineDRT.h:

TBR=​tony@chromium.org

1:51 PM Changeset in webkit [69695] by barraclough@apple.com
  • 2 edits in trunk/WebCore

Chromium build fix pt1.

  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp:

(WebCore::V8XMLHttpRequest::responseTextAccessorGetter):

1:40 PM Changeset in webkit [69694] by andersca@apple.com
  • 4 edits in trunk/WebKit2

Use WKSI to get wheel event deltas
​https://bugs.webkit.org/show_bug.cgi?id=47617

Reviewed by Darin Adler.

  • Shared/mac/WebEventFactory.mm:

(WebKit::WebEventFactory::createWebWheelEvent):
Call WKGetWheelEventDeltas.

  • UIProcess/API/mac/WKView.mm:

(-[WKView initWithFrame:pageNamespaceRef:]):
Call InitWebCoreSystemInterface.

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface):
Use dispatch_once.

1:29 PM Changeset in webkit [69693] by kbr@google.com
  • 2 edits in trunk/WebKit/chromium

2010-10-13 Kenneth Russell <​kbr@google.com>

Reviewed by James Robinson.

Revert changes to WebViewImpl in r69633
​https://bugs.webkit.org/show_bug.cgi?id=47610

Revert change to WebViewImpl.cpp in
​http://trac.webkit.org/changeset/69633 which incorrectly used
PassRefPtr for a local variable instead of RefPtr. This was a fix
for changes in ​http://trac.webkit.org/changeset/69619 and
​http://trac.webkit.org/changeset/69624 .

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
1:28 PM Changeset in webkit [69692] by Adam Roben
  • 2 edits
    2 adds in trunk/WebKit2

Fix the Cairo build

  • Shared/cairo/BackingStoreCairo.cpp: Added.

(WebKit::BackingStore::createGraphicsContext):
(WebKit::BackingStore::paint):
Stubbed out.

  • win/WebKit2.vcproj: Build BackingStoreCG.cpp in CG builds and

BackingStoreCairo.cpp in Cairo builds.

1:24 PM Changeset in webkit [69691] by andersca@apple.com
  • 2 edits in trunk/WebKit2

Build fix.

  • Shared/cg/BackingStoreCG.cpp:
1:20 PM Changeset in webkit [69690] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Windows build fix.

1:18 PM Changeset in webkit [69689] by andersca@apple.com
  • 8 edits in trunk

Send over find indicator information to the UI process
​https://bugs.webkit.org/show_bug.cgi?id=47612

Reviewed by Sam Weinig.

WebCore:

Export symbols needed by WebKit2.

  • WebCore.exp.in:

WebKit2:

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::setFindIndicator):
Add stub.

  • UIProcess/WebPageProxy.messages.in:

Add SetFindIndicator.

  • WebProcess/WebPage/FindController.cpp:

(WebKit::FindController::FindController):
Initialize m_isShowingFindIndicator.

(WebKit::FindController::findString):
Update the find indicator if needed.

(WebKit::FindController::updateFindIndicator):
Compute find indicator information, paint the find indicator text into a
backing store and send it over.

(WebKit::FindController::resetFindIndicator):
Send a SetFindIndicator message with a null backing store.

1:10 PM Changeset in webkit [69688] by barraclough@apple.com
  • 40 edits
    1 delete in trunk

​https://bugs.webkit.org/show_bug.cgi?id=43987
Switch XMLHttpRequest, FileReader, and FileReaderSync to use a Stringbuilder
to construct their internal result string. Remove ScriptString (this is now
redundant).

Reviewed by Oliver Hunt.

WebCore:

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDOMBinding.cpp:

(WebCore::jsOwnedStringOrNull):

  • bindings/js/JSDOMBinding.h:
  • bindings/js/JSXMLHttpRequestCustom.cpp:

(WebCore::JSXMLHttpRequest::responseText):

  • bindings/js/ScriptCallFrame.cpp:

(WebCore::ScriptCallFrame::ScriptCallFrame):

  • bindings/js/ScriptCallFrame.h:

(WebCore::ScriptCallFrame::functionName):

  • bindings/js/ScriptCallStack.h:
  • bindings/js/ScriptFunctionCall.cpp:
  • bindings/js/ScriptFunctionCall.h:
  • bindings/js/ScriptString.h: Removed.
  • dom/ScriptExecutionContext.h:
  • fileapi/FileReader.cpp:

(WebCore::FileReader::FileReader):
(WebCore::FileReader::abort):
(WebCore::FileReader::didReceiveData):
(WebCore::FileReader::result):
(WebCore::FileReader::convertToText):
(WebCore::FileReader::convertToDataURL):

  • fileapi/FileReader.h:
  • fileapi/FileReaderSync.cpp:

(WebCore::FileReaderSyncLoader::FileReaderSyncLoader):
(WebCore::FileReaderSyncLoader::didReceiveData):
(WebCore::FileReaderSync::readAsBinaryString):
(WebCore::FileReaderSync::readAsText):
(WebCore::FileReaderSync::readAsDataURL):
(WebCore::FileReaderSync::read):
(WebCore::FileReaderSync::convertToText):

  • fileapi/FileReaderSync.h:

(WebCore::FileReaderSync::readAsText):
(WebCore::FileReaderSync::FileReaderSync):

  • inspector/InspectorController.cpp:

(WebCore::InspectorController::resourceRetrievedByXMLHttpRequest):
(WebCore::InspectorController::scriptImported):

  • inspector/InspectorController.h:
  • inspector/InspectorResource.cpp:

(WebCore::InspectorResource::setOverrideContent):

  • inspector/InspectorResource.h:
  • loader/FrameLoader.cpp:
  • loader/FrameLoader.h:
  • loader/FrameLoaderClient.h:
  • loader/ResourceLoadNotifier.h:
  • workers/WorkerScriptLoader.h:
  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::XMLHttpRequest):
(WebCore::XMLHttpRequest::responseText):
(WebCore::XMLHttpRequest::responseXML):
(WebCore::XMLHttpRequest::abort):
(WebCore::XMLHttpRequest::clearResponse):
(WebCore::XMLHttpRequest::dropProtection):
(WebCore::XMLHttpRequest::didFinishLoading):
(WebCore::XMLHttpRequest::didReceiveData):

  • xml/XMLHttpRequest.h:

WebKit/efl:

  • WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore::FrameLoaderClientEfl::dispatchDidLoadResourceByXMLHttpRequest):

  • WebCoreSupport/FrameLoaderClientEfl.h:

WebKit/mac:

  • WebCoreSupport/WebFrameLoaderClient.mm:

WebKit/qt:

  • WebCoreSupport/FrameLoaderClientQt.cpp:

WebKit/win:

  • WebCoreSupport/WebFrameLoaderClient.cpp:

WebKit/wx:

  • WebKitSupport/FrameLoaderClientWx.cpp:

WebKit2:

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDidLoadResourceByXMLHttpRequest):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
1:04 PM Changeset in webkit [69687] by andersca@apple.com
  • 3 edits
    1 add in trunk/WebKit2

Add BackingStoreQt.cpp file with stubbed out BackingStore member functions
​https://bugs.webkit.org/show_bug.cgi?id=47614

Reviewed by Sam Weinig.

  • Shared/BackingStore.h:

Remove unused include.

  • Shared/qt/BackingStoreQt.cpp: Added.

(WebKit::BackingStore::createGraphicsContext):
(WebKit::BackingStore::paint):

  • WebKit2.pro:

Add BackingStore.cpp, BackingStore.h and BackingStoreQt.cpp

1:01 PM Changeset in webkit [69686] by abarth@webkit.org
  • 2 edits
    3 adds in trunk/JavaScriptCore

2010-10-13 Adam Barth <​abarth@webkit.org>

Reviewed by Maciej Stachowiak.

[WTFURL] Add URLQueryCanonicalizer
​https://bugs.webkit.org/show_bug.cgi?id=45088

This class canonicalizes the query component of URLs. The main tricky
bit there is the convertCharset function, which I've moved to a
templated dependency. There'll likely be more about that in future
patches.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • wtf/url/src/URLEscape.cpp: Added.
  • wtf/url/src/URLEscape.h: Added. (WTF::appendEscapedCharacter):
  • wtf/url/src/URLQueryCanonicalizer.h: Added. (WTF::URLQueryCanonicalizer::canonicalize): (WTF::URLQueryCanonicalizer::isAllASCII): (WTF::URLQueryCanonicalizer::appendRaw8BitQueryString): (WTF::URLQueryCanonicalizer::convertToQueryEncoding):
12:54 PM Changeset in webkit [69685] by abarth@webkit.org
  • 6 edits in trunk/WebKitTools

2010-10-13 Adam Barth <​abarth@webkit.org>

Reviewed by Csaba Osztrogonác.

webkit-patch build shouldn't need --build to actually build!
​https://bugs.webkit.org/show_bug.cgi?id=47438

Yeah, requiring --build for the build command is really dumb. We did
this originally because the build step is usually optional in other
commands. We don't have a good way of reversing the default for an
option in one command. This approach is slightly hacky since --build
still shows up as an option on the help page, but at least it makes
progress. Passing --build is harmless, so the EWS bots shouldn't
explode because of this change.

  • Scripts/webkitpy/tool/bot/commitqueuetask.py:
  • Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
  • Scripts/webkitpy/tool/commands/download.py:
  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
12:38 PM Changeset in webkit [69684] by robert@webkit.org
  • 2 edits in trunk/LayoutTests

2010-10-13 Robert Hogan <​robert@webkit.org>

Rubber-stamped by Csaba Osztrogonac.

[Qt] editing/execCommand/move-selection-back-line.html fails in DRT

Unskip test that now passes.

​https://bugs.webkit.org/show_bug.cgi?id=35921

  • platform/qt/Skipped:
12:29 PM Changeset in webkit [69683] by barraclough@apple.com
  • 19 edits
    1 add in trunk

JavaScriptCore: Bug 43987 - Downloading using XHR is much slower than before
Change StringBuilder to use overcapacity in a StringImpl, rather than a Vector.
Fundamentally this should be the same (copies current contents to expand capacity,
rather than using a rope), but this approach allows the intermadiate state of the
String to be inspected in the buffer without copying to resolve.

Reviewed by Oliver Hunt.

  • runtime/JSONObject.cpp:

(JSC::Stringifier::appendQuotedString):
(JSC::Stringifier::Holder::appendNextProperty):

Renamed StringBuilder::size() -> length() (to match other String types).

  • runtime/UStringBuilder.h:

(JSC::UStringBuilder::append):
(JSC::UStringBuilder::toUString):

Update for changes in parent class, can just 'using' the append methods.

  • wtf/text/StringBuilder.cpp: Added.

(WTF::StringBuilder::reifyString):
(WTF::StringBuilder::resize):
(WTF::StringBuilder::reserveCapacity):
(WTF::StringBuilder::allocateBuffer):
(WTF::StringBuilder::appendUninitialized):
(WTF::StringBuilder::append):
(WTF::StringBuilder::shrinkToFit):

  • wtf/text/StringBuilder.h:

(WTF::StringBuilder::StringBuilder):
(WTF::StringBuilder::append):
(WTF::StringBuilder::toString):
(WTF::StringBuilder::toStringPreserveCapacity):
(WTF::StringBuilder::length):
(WTF::StringBuilder::isEmpty):
(WTF::StringBuilder::operator[]):
(WTF::StringBuilder::clear):

Class updated to use overcapacity in a StringImpl, rather than a Vector.

WebCore: Bug 43987 - Downloading using XHR is much slower than before

Reviewed by Oliver Hunt.

  • svg/SVGPathStringBuilder.cpp:

(WebCore::SVGPathStringBuilder::result):

StringBuilder::size() -> StringBuilder::length().

WebKit/chromium: Bug 43987 - Downloading using XHR is much slower than before

Reviewed by Oliver Hunt.

  • src/WebPageSerializerImpl.cpp:

(WebKit::WebPageSerializerImpl::encodeAndFlushBuffer):

12:21 PM Changeset in webkit [69682] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-10-13 Yong Li <​yoli@rim.com>

Reviewed by Oliver Hunt.

Fix potential misaligned memory access in CloneDeserializer::readLittleEndian and readString
that can result crash on ARM (<v6).
​https://bugs.webkit.org/show_bug.cgi?id=47594

No new test added, because the crash can be produced by existing tests like:
LayoutTests/fast/events/message-channel-gc-4.html

  • bindings/js/SerializedScriptValue.cpp: (WebCore::CloneDeserializer::readLittleEndian): (WebCore::CloneDeserializer::readString):
12:18 PM Changeset in webkit [69681] by Martin Robinson
  • 63 edits in trunk

2010-09-24 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Dirk Schulze.

[Cairo] Activate ContextShadow in all places where shadows are drawn
​https://bugs.webkit.org/show_bug.cgi?id=46475

Rebaselined tests. All these changes seem reasonable. In some cases, the
new results are much better / closer matches to Chromium.

  • platform/gtk/fast/box-shadow/basic-shadows-expected.checksum:
  • platform/gtk/fast/box-shadow/basic-shadows-expected.png:
  • platform/gtk/fast/box-shadow/inset-expected.checksum:
  • platform/gtk/fast/box-shadow/inset-expected.png:
  • platform/gtk/fast/css/shadow-multiple-expected.checksum:
  • platform/gtk/fast/css/shadow-multiple-expected.png:
  • platform/gtk/fast/text/shadow-no-blur-expected.checksum:
  • platform/gtk/fast/text/shadow-no-blur-expected.png:
  • platform/gtk/fast/text/shadow-translucent-fill-expected.checksum:
  • platform/gtk/fast/text/shadow-translucent-fill-expected.png:
  • platform/gtk/fast/text/stroking-decorations-expected.checksum:
  • platform/gtk/fast/text/stroking-decorations-expected.png:
  • platform/gtk/fast/text/stroking-expected.checksum:
  • platform/gtk/fast/text/stroking-expected.png:
  • platform/gtk/fast/transforms/shadows-expected.checksum:
  • platform/gtk/fast/transforms/shadows-expected.png:
  • platform/gtk/svg/css/arrow-with-shadow-expected.checksum:
  • platform/gtk/svg/css/arrow-with-shadow-expected.png:
  • platform/gtk/svg/css/composite-shadow-text-expected.checksum:
  • platform/gtk/svg/css/composite-shadow-text-expected.png:
  • platform/gtk/svg/css/group-with-shadow-expected.checksum:
  • platform/gtk/svg/css/group-with-shadow-expected.png:
  • platform/gtk/svg/css/path-with-shadow-expected.checksum:
  • platform/gtk/svg/css/path-with-shadow-expected.png:
  • platform/gtk/svg/css/shadow-with-large-radius-expected.checksum:
  • platform/gtk/svg/css/shadow-with-large-radius-expected.png:
  • platform/gtk/svg/css/shadow-with-negative-offset-expected.checksum:
  • platform/gtk/svg/css/shadow-with-negative-offset-expected.png:

2010-10-06 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Dirk Schulze.

[Cairo] Activate ContextShadow in all places where shadows are drawn
​https://bugs.webkit.org/show_bug.cgi?id=46475

Turn on ContextShadow for the Cairo port and remove all old shadow code.
Shadow tiling optimizations will be added in a followup patch to ContextShadowCairo.

  • platform/graphics/GraphicsContext.h: Add a ContextShadow forward declaration for Cairo.
  • platform/graphics/cairo/FontCairo.cpp: Switch to using ContextShadow. (WebCore::prepareContextForGlyphDrawing): Added this helper which sets up the translation on the specified cairo_t to prepare for drawing glyphs. (WebCore::drawGlyphsToContext): Added this helper which draws the glyphs to a cairo_t, while properly handling glyphs with synthetic bold. (WebCore::Font::drawGlyphs): Removed old shadow code and replaced it with ContextShadow usage.
  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::drawPathShadow): Modified this to use ContextShadow and to take an enum argument specifying whether to fill or stroke the solid figure for the shadow. (WebCore::fillCurrentCairoPath): Updated drawPathShadow call. (WebCore::strokeCurrentCairoPath): Ditto. (WebCore::GraphicsContext::savePlatformState): Save the ContextShadow. (WebCore::GraphicsContext::restorePlatformState): Restore the ContextShadow. (WebCore::GraphicsContext::drawPath): Updated drawPathShadow call. (WebCore::GraphicsContext::fillRect): Uses ContextShadow now. (WebCore::GraphicsContext::setPlatformShadow): Uses ContextShadow now. (WebCore::GraphicsContext::contextShadow): Added. (WebCore::GraphicsContext::clearPlatformShadow): Clears the ContextShadow member. (WebCore::GraphicsContext::fillRoundedRect): Updated drawPathShadow call.
  • platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h: (WebCore::GraphicsContextPlatformPrivate::hasShadow): Added.
  • platform/graphics/cairo/ImageCairo.cpp: (WebCore::BitmapImage::draw): Updated to use ContextShadow.
12:15 PM Changeset in webkit [69680] by bfulgham@webkit.org
  • 4 edits in trunk/WebKit2

Unreviewed build fixes after r69538.

  • UIProcess/WebBackForwardList.h: Add missing include directive

for CoreFoundation.

  • UIProcess/cf/WebBackForwardListCF.cpp: Add missing include

directives for RetainPtr.h and CoreFoundation.

  • UIProcess/cf/WebPageProxyCF.cpp: Add missing include directive

for RetainPtr.h.

11:50 AM Changeset in webkit [69679] by Nate Chapin
  • 1 edit
    2 moves in trunk/LayoutTests

2010-10-13 Nate Chapin <Nate Chapin>

Unreviewed, Chromium test fix.

Move a couple of platform-specific results that were added to the wrong directory.

  • platform/chromium/console-trace-in-eval-expected.txt: Removed.
  • platform/chromium/console-uncaught-exception-in-eval-expected.txt: Removed.
  • platform/chromium/inspector/console-trace-in-eval-expected.txt: Copied from LayoutTests/platform/chromium/console-trace-in-eval-expected.txt.
  • platform/chromium/inspector/console-uncaught-exception-in-eval-expected.txt: Copied from LayoutTests/platform/chromium/console-uncaught-exception-in-eval-expected.txt.
11:49 AM Changeset in webkit [69678] by Adam Roben
  • 4 edits in trunk

Start compiling BackingStore on Windows

Rubber-stamped by Anders Carlsson.

JavaScriptCore:

Export tryFastRealloc for WebKit2's benefit

tryFastRealloc. Removed RegExpObject::info, which is now exported via
JS_EXPORTDATA.

WebKit2:

  • win/WebKit2.vcproj: Added BackingStore.
11:49 AM Changeset in webkit [69677] by Adam Roben
  • 2 edits
    1 move
    1 add in trunk/WebKit2

Rename BackingStoreMac.mm to BackingStoreCG.cpp

There's nothing Mac-specific about this file.

Rubber-stamped by Anders Carlsson.

  • Shared/cg/BackingStoreCG.cpp: Renamed from WebKit2/Shared/mac/BackingStoreMac.mm.
  • WebKit2.xcodeproj/project.pbxproj: Updated for rename.
11:31 AM Changeset in webkit [69676] by Martin Robinson
  • 2 edits in trunk/LayoutTests

2010-10-13 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r69667.
​http://trac.webkit.org/changeset/69667
​https://bugs.webkit.org/show_bug.cgi?id=47598

"Most of the tests seem to fail in the bots for some reason"
(Requested by xan_ on #webkit).

  • platform/gtk/Skipped:
11:12 AM Changeset in webkit [69675] by abarth@webkit.org
  • 3 edits in trunk/WebKit/chromium

2010-10-13 Adam Barth <​abarth@webkit.org>

Reviewed by Tony Chang.

[Chromium] Clean up WebPageSerializerImpl::serialize
​https://bugs.webkit.org/show_bug.cgi?id=47577

This patch shouldn't have any behavior change. I'm just trying to
understand what this code does.

  • src/WebPageSerializerImpl.cpp: (WebKit::WebPageSerializerImpl::saveHTMLContentToBuffer): (WebKit::WebPageSerializerImpl::encodeAndFlushBuffer): (WebKit::WebPageSerializerImpl::serialize):
  • src/WebPageSerializerImpl.h:
11:10 AM Changeset in webkit [69674] by commit-queue@webkit.org
  • 7 edits in trunk/WebKitTools

2010-10-13 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r69638.
​http://trac.webkit.org/changeset/69638
​https://bugs.webkit.org/show_bug.cgi?id=47595

"Broke win and chromium-win bots" (Requested by dglazkov on
#webkit).

  • Scripts/webkitpy/common/system/path.py:
  • Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/base_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
11:01 AM Changeset in webkit [69673] by commit-queue@webkit.org
  • 12 edits in trunk

2010-10-13 John Knottenbelt <​jknotten@chromium.org>

Reviewed by Steve Block.

First step towards client-based Geolocation in Chromium. Build
fixes for CLIENT_BASED_GEOLOCATION preprocessor feature define.
​https://bugs.webkit.org/show_bug.cgi?id=47586

  • WebCore.gyp/WebCore.gyp:
  • platform/chromium/ChromiumBridge.h:
  • platform/chromium/GeolocationServiceChromium.cpp:

2010-10-13 John Knottenbelt <​jknotten@chromium.org>

Reviewed by Steve Block.

First step towards client-based Geolocation in Chromium. Build
fixes for CLIENT_BASED_GEOLOCATION preprocessor feature define.
​https://bugs.webkit.org/show_bug.cgi?id=47586

  • WebKit.gyp:
  • src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::requestGeolocationPermissionForFrame): (WebKit::ChromeClientImpl::cancelGeolocationPermissionRequestForFrame):
  • src/ChromiumBridge.cpp:
  • src/WebGeolocationServiceMock.cpp: (WebKit::WebGeolocationServiceMock::createWebGeolocationServiceMock): (WebKit::WebGeolocationServiceMock::setMockGeolocationPermission): (WebKit::WebGeolocationServiceMock::setMockGeolocationPosition): (WebKit::WebGeolocationServiceMock::setMockGeolocationError):

2010-10-13 John Knottenbelt <​jknotten@chromium.org>

Reviewed by Steve Block.

First step towards client-based Geolocation in Chromium. Build
fixes for CLIENT_BASED_GEOLOCATION preprocessor feature define.
​https://bugs.webkit.org/show_bug.cgi?id=47586

  • DumpRenderTree/chromium/WebViewHost.cpp:
  • DumpRenderTree/chromium/WebViewHost.h:
11:01 AM Changeset in webkit [69672] by andersca@apple.com
  • 2 edits in trunk/WebKit2

Allow all signals to be delivered to the web process
​https://bugs.webkit.org/show_bug.cgi?id=47602
<rdar://problem/8546399>

Reviewed by Sam Weinig.

  • UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::ProcessLauncher::launchProcess):

10:40 AM Changeset in webkit [69671] by Adam Roben
  • 12 edits
    2 adds in trunk

Let WebCore handle scrolling when the spacebar is pressed on Windows

WebCore already has code to do this, and WebKit2 was doing it on
keydown instead of keypress, which caused problems with text fields.

WebCore's spacebar-handling code is currently compiled out on Mac and
Qt, so we continue to handle spacebar in WebKit2 on those platforms.

Fixes <​http://webkit.org/b/47544> <rdar://problem/8540645> REGRESSION:
Pressing spacebar in a text field in WebKit2 does not insert a space,
scrolls the page instead

Test: WebKit2/SpacebarScrolling

Reviewed by Sam Weinig.

WebKit2:

  • WebProcess/WebPage/win/WebPageWin.cpp:

(WebKit::WebPage::performDefaultBehaviorForKeyEvent):
Removed handling for spacebar presses. WebCore already does this for
us, and does it better.

WebKitTools:

Test that pressing the spacebar in a text field does not scroll the
document

  • TestWebKitAPI/PlatformUtilities.h: Added isKeyDown.
  • TestWebKitAPI/PlatformWebView.h: Added simulateSpacebarKeyPress.
  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/win/TestWebKitAPI.vcproj:
  • TestWebKitAPI/win/copy-resources.cmd:

Added new files.

  • TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp: Added.

(TestWebKitAPI::JavaScriptCallbackContext::JavaScriptCallbackContext):
We use this to track what the result of calling into JavaScript was.
(TestWebKitAPI::didFinishLoadForFrame): Records when the page
finishes loading.
(TestWebKitAPI::didNotHandleKeyEventCallback): Records when a key down
event is not handled.
(TestWebKitAPI::javaScriptCallback): Records that JavaScript finished
executing and whether the result matched our expectation.
(TestWebKitAPI::wk): Turns a UTF-8 C string into a WKStringRef.
(TestWebKitAPI::runJSTest): Calls into JS, waits for the call to
complete, and returns whether we got back the expected result.
(TestWebKitAPI::WebKit2_SpacebarScrolling): Tests that pressing
spacebar inside a text field does not scroll the document and that
pressing it outside the text field does scroll the document.

  • TestWebKitAPI/Tests/WebKit2/spacebar-scrolling.html: Added.
  • TestWebKitAPI/mac/PlatformUtilitiesMac.mm:

(TestWebKitAPI::Util::isKeyDown): Checks the event's type.

  • TestWebKitAPI/mac/PlatformWebViewMac.mm:

(TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress): Copied
code from DRT's EventSendingController.

  • TestWebKitAPI/win/PlatformUtilitiesWin.cpp:

(TestWebKitAPI::Util::isKeyDown): Checks the message's type.

  • TestWebKitAPI/win/PlatformWebViewWin.cpp:

(TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress): Send the
same messages that get sent when you press spacebar in Notepad.

10:26 AM Changeset in webkit [69670] by andreip@google.com
  • 2 edits in trunk/WebKit/chromium

2010-10-11 Andrei Popescu <​andreip@google.com>

Reviewed by Jeremy Orlow.

[Chromium] Cleanup WebIDBFactory::open once the Chromium plumbing has landed.
​https://bugs.webkit.org/show_bug.cgi?id=47531

Remove the temporary open() method since the appropriate Chromium plumbing was
added in ​http://codereview.chromium.org/3729003/

  • public/WebIDBFactory.h: (WebKit::WebIDBFactory::open):
10:21 AM Changeset in webkit [69669] by abarth@webkit.org
  • 2 edits
    2 adds in trunk/JavaScriptCore

2010-10-13 Adam Barth <​abarth@webkit.org>

Reviewed by Maciej Stachowiak.

[WTFURL] Add a mechanism for classifying types of characters
​https://bugs.webkit.org/show_bug.cgi?id=45085

Various characters have different escaping rules depending on where
they are in URLs. This patch adds a table containing that information.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • wtf/url/src/URLCharacterTypes.cpp: Added.
  • wtf/url/src/URLCharacterTypes.h: Added. (WTF::URLCharacterTypes::isQueryChar): (WTF::URLCharacterTypes::isIPv4Char): (WTF::URLCharacterTypes::isHexChar): (WTF::URLCharacterTypes::isCharOfType):
9:40 AM Changeset in webkit [69668] by abarth@webkit.org
  • 3 edits in trunk/WebKit/chromium

2010-10-13 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Fisher.

[Chromium] Clean up SerializeDomParam
​https://bugs.webkit.org/show_bug.cgi?id=47580

This patch just renames a bunch of the members of this struct to be
more sensible. No behavior change, well, except for one struct member
that wasn't initialized. I didn't trace through this code to see if
the uninitialized value was used anywhere, but initializing all the
values seems like a good idea.

  • src/WebPageSerializerImpl.cpp: (WebKit::WebPageSerializerImpl::SerializeDomParam::SerializeDomParam): (WebKit::WebPageSerializerImpl::preActionBeforeSerializeOpenTag): (WebKit::WebPageSerializerImpl::postActionAfterSerializeOpenTag): (WebKit::WebPageSerializerImpl::postActionAfterSerializeEndTag): (WebKit::WebPageSerializerImpl::encodeAndFlushBuffer): (WebKit::WebPageSerializerImpl::openTagToString): (WebKit::WebPageSerializerImpl::endTagToString): (WebKit::WebPageSerializerImpl::buildContentForNode):
  • src/WebPageSerializerImpl.h:
8:53 AM Changeset in webkit [69667] by xan@webkit.org
  • 2 edits in trunk/LayoutTests

2010-10-13 Xan Lopez <​xlopez@igalia.com>

Reviewed by Martin Robinson.

Unskip some fast/js tests that seem to be working now.

  • platform/gtk/Skipped:
8:44 AM Changeset in webkit [69666] by steveblock@google.com
  • 2 edits in trunk/WebCore

Unreviewed fix

Need to check for the existence of DeviceOrientation and DeviceMotion controllers

These features can be disabled at run time, so an enable guard is not sufficient.
This bug was introduced in ​http://trac.webkit.org/changeset/69646

Tested with existing tests.

  • history/PageCache.cpp:

(WebCore::logCanCachePageDecision):
(WebCore::PageCache::canCache):

8:39 AM Changeset in webkit [69665] by xan@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-10-13 Xan Lopez <​xlopez@igalia.com>

Reviewed by Csaba Osztrogonác.

Missing parameters for bytecode dump of next_pname
​https://bugs.webkit.org/show_bug.cgi?id=47590

  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::dump): add missing parameters to the dump.
8:24 AM Changeset in webkit [69664] by yurys@chromium.org
  • 2 edits in trunk/LayoutTests

2010-10-13 Yury Semikhatsky <​yurys@chromium.org>

Unreviewed. Update test expectation.

  • inspector/console-trace-expected.txt:
7:44 AM Changeset in webkit [69663] by Nikolas Zimmermann
  • 17 edits
    1 move
    1 add in trunk/JavaScriptCore

2010-10-13 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Add wtf/text/StringConcatenate
​https://bugs.webkit.org/show_bug.cgi?id=47584

Move runtime/StringConcatenate.h to wtf/text, make it work for Strings too.
Add a special runtime/UStringConcatenate.h class that inherits from StringConcatenate, and extends it for use with UString.
Exactly the same design that has been followed while refactoring StringBuilder.

The UString variants can all be removed as soon as WTF::String & JSC::UString converge.

  • GNUmakefile.am: Add wtf/text/StringConcatenate.h and runtime/UStringConcatenate.h.
  • JavaScriptCore.gypi: Ditto.
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Ditto.
  • JavaScriptCore.vcproj/WTF/WTF.vcproj: Ditto.
  • JavaScriptCore.xcodeproj/project.pbxproj: Ditto.
  • bytecode/CodeBlock.cpp: s/makeString/makeUString/ (JSC::escapeQuotes): (JSC::valueToSourceString): (JSC::constantName): (JSC::idName): (JSC::CodeBlock::registerName): (JSC::regexpToSourceString): (JSC::regexpName):
  • bytecompiler/NodesCodegen.cpp: Ditto. (JSC::substitute):
  • profiler/Profiler.cpp: Ditto. (JSC::Profiler::createCallIdentifier):
  • runtime/ExceptionHelpers.cpp: Ditto. (JSC::createUndefinedVariableError): (JSC::createErrorMessage): (JSC::createInvalidParamError):
  • runtime/FunctionConstructor.cpp: Ditto. (JSC::constructFunction):
  • runtime/FunctionPrototype.cpp: Ditto. (JSC::insertSemicolonIfNeeded):
  • runtime/JSONObject.cpp: Ditto. (JSC::Stringifier::indent):
  • runtime/JSStringBuilder.h: (JSC::jsMakeNontrivialString):
  • runtime/RegExpConstructor.cpp: Ditto. (JSC::constructRegExp):
  • runtime/RegExpObject.cpp: Ditto. (JSC::RegExpObject::match):
  • runtime/RegExpPrototype.cpp: Ditto. (JSC::regExpProtoFuncCompile):
  • runtime/StringConcatenate.h: Removed.
  • runtime/UStringConcatenate.h: Added. Only contains the StringTypeAdapter<JSC::UString> code and the makeUString variants, the rest lives in wtf/text/StringConcatenate.h (JSC::makeUString):
  • wtf/text/StringConcatenate.h: Copied from runtime/StringConcatenate.h. (WTF::makeString):
7:43 AM Changeset in webkit [69662] by yurys@chromium.org
  • 16 edits
    6 adds in trunk

2010-10-13 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: stack information is inconsistent between console.trace and runtime errors.
​https://bugs.webkit.org/show_bug.cgi?id=47252

  • console.trace() is now formatted the same way as other stack traces
  • If there is @ sourceURL=url line at the end of eval'ed script source the url will be shown in the stack traces for script. That is why ScriptCallFrame::sourceURL type has changed from KURL to String.

Tests: inspector/console-trace-in-eval.html

inspector/console-uncaught-exception-in-eval.html

  • bindings/js/ScriptCallFrame.cpp: (WebCore::ScriptCallFrame::ScriptCallFrame):
  • bindings/js/ScriptCallFrame.h: (WebCore::ScriptCallFrame::sourceURL):
  • bindings/v8/ScriptCallFrame.cpp: (WebCore::ScriptCallFrame::ScriptCallFrame):
  • bindings/v8/ScriptCallFrame.h: (WebCore::ScriptCallFrame::sourceURL):
  • bindings/v8/ScriptCallStack.cpp: (WebCore::getFrameLocation): (WebCore::ScriptCallStack::create):
  • bindings/v8/ScriptCallStack.h:
  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::setCaptureCallStackForUncaughtExceptions):
  • bindings/v8/custom/V8ConsoleCustom.cpp: (WebCore::V8Console::traceCallback):
  • inspector/ConsoleMessage.cpp: (WebCore::ConsoleMessage::CallFrame::buildInspectorObject): (WebCore::ConsoleMessage::ConsoleMessage):
  • inspector/ConsoleMessage.h:
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleMessage.prototype._formatMessage):
  • page/Console.cpp: (WebCore::Console::addMessage): (WebCore::Console::count): (WebCore::Console::timeEnd):

2010-10-13 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: stack information is inconsistent between console.trace and runtime errors.
​https://bugs.webkit.org/show_bug.cgi?id=47252

  • inspector/console-trace-in-eval-expected.txt: Added.
  • inspector/console-trace-in-eval.html: Added.
  • inspector/console-uncaught-exception-in-eval-expected.txt: Added.
  • inspector/console-uncaught-exception-in-eval.html: Added.
  • platform/chromium/console-trace-in-eval-expected.txt: Added.
  • platform/chromium/console-uncaught-exception-in-eval-expected.txt: Added.

2010-10-13 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: stack information is inconsistent between console.trace and runtime errors.
​https://bugs.webkit.org/show_bug.cgi?id=47252

  • DEPS: bump up V8 revision
7:42 AM Changeset in webkit [69661] by jberlin@webkit.org
  • 10 edits in trunk/WebKit2

Add ability for WK2 to set domain relaxation forbidden for a URL scheme.
​https://bugs.webkit.org/show_bug.cgi?id=47562

Reviewed by Jon Honeycutt.

Add the schemes for which domain relaxation is forbidden to the
WebProcessCreationParameters.

  • Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):

  • Shared/WebProcessCreationParameters.h:
  • UIProcess/API/C/WKContext.cpp:

(WKContextSetDomainRelaxationForbiddenForURLScheme):

  • UIProcess/API/C/WKContextPrivate.h:
  • UIProcess/WebContext.cpp:

(WebKit::WebContext::ensureWebProcess):
Copy over the schemes for which domain relaxation is forbidden to
WebProcessCreationParameters.
(WebKit::WebContext::setDomainRelaxationForbiddenForURLScheme):
Only send a message to the WebProcess if it is valid.

  • UIProcess/WebContext.h:
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeWebProcess):
Set domain relaxation forbidden for the schemes in
WebProcesCreationParameters.urlSchemesForWhichDomainRelaxationIsForbidden.
(WebKit::WebProcess::setDomainRelaxationForbiddenForURLScheme):

  • WebProcess/WebProcess.h:
  • WebProcess/WebProcess.messages.in:

Add the SetDomainRelaxationFobiddenForURLScheme message.

7:37 AM Changeset in webkit [69660] by tkent@chromium.org
  • 2 edits in trunk/WebCore

2010-10-13 Kent Tamura <​tkent@chromium.org>

Unreviewed, a trivial change.

Run sort-Xcode-project-file.

  • WebCore.xcodeproj/project.pbxproj:
7:34 AM Changeset in webkit [69659] by Adam Roben
  • 4 edits in trunk/WebKitTools

Fix a couple of issues with the TestWebKitAPI build

  • TestWebKitAPI/Configurations/TestWebKitAPICFLite.vsprops:
  • TestWebKitAPI/Configurations/TestWebKitAPICoreFoundation.vsprops:

Fixed a typo.

  • TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj: Use common.vsprops

to set our output and intermediate directories so that we don't spew
files into the source tree.

7:08 AM Changeset in webkit [69658] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed.

  • platform/qt/Skipped: Reskip fast/events/spatial-navigation/snav-clipped-overflowed-content.html again, because it still fails.
7:07 AM Changeset in webkit [69657] by kbalazs@webkit.org
  • 3 edits in trunk/WebKitTools

2010-10-13 Balazs Kelemen <​kbalazs@webkit.org>

Reviewed by Csaba Osztrogonác.

WTR should accept relative paths
​https://bugs.webkit.org/show_bug.cgi?id=47486

  • WebKitTestRunner/StringFunctions.h:
  • WebKitTestRunner/TestInvocation.cpp: (WTR::createWKURL): Moved from StringFunctions.h since it is used only here. Extend relative paths to absolute.
6:58 AM Changeset in webkit [69656] by Adam Roben
  • 6 edits
    1 copy
    10 adds in trunk

Make TestWebKitAPI work on Windows

Fixes <​http://webkit.org/b/47552> <rdar://problem/8541708>.

Reviewed by Sam Weinig.

WebKit/win:

Build TestWebKitAPI on Windows

  • WebKit.vcproj/WebKit.sln: Added TestWebKitAPI and

TestWebKitAPIGenerated and made them build just after
WebKitTestRunner.

WebKitTools:

  • Scripts/build-api-tests: Build TestWebKitAPI.sln on Windows.
  • Scripts/run-api-tests: Fix the PATH so that TestWebKitAPI can be

run on Windows.
(runTest): Added code to run TestWebKitAPI.exe on Windows and to die
on unsupported platforms.
(populateTests): Added code to run TestWebKitAPI.exe on Windows and to
die on other platforms. Extracted some formerly-Mac-specific code to
be cross-platform and made it handle any style of line-endings.

  • TestWebKitAPI/Configurations/TestWebKitAPICFLite.vsprops: Added.

Links against CFLite.

  • TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops: Added.

Contains most properties for the project.

  • TestWebKitAPI/Configurations/TestWebKitAPICoreFoundation.vsprops:

Added. Links against CoreFoundation.

  • TestWebKitAPI/TestWebKitAPIPrefix.h: Added a Windows-specific

section and moved the cross-platform section after the
platform-specific parts.

  • TestWebKitAPI/win/PlatformUtilitiesWin.cpp: Added.

(TestWebKitAPI::Util::run): Runs a normal message pump until we're
done.
(TestWebKitAPI::Util::cf): Turns a UTF-8 C string into a CFString.
(TestWebKitAPI::Util::createURLForResource): Uses CFBundle to get the
resource path.
(TestWebKitAPI::Util::URLForNonExistentResource): Creates a bogus
WKURL.

  • TestWebKitAPI/win/PlatformWebViewWin.cpp: Added.

(TestWebKitAPI::registerWindowClass):
(TestWebKitAPI::PlatformWebView::PlatformWebView):
(TestWebKitAPI::PlatformWebView::~PlatformWebView):
(TestWebKitAPI::PlatformWebView::page):
This was mostly copied from WebKitTestRunner's PlatformWebView.

  • TestWebKitAPI/win/TestWebKitAPI.sln: Added. Builds both

TestWebKitAPI and TestWebKitAPIGeneratd. This is used by the
build-api-tests script.

  • TestWebKitAPI/win/TestWebKitAPI.vcproj: Added. Builds

TestWebKitAPI.exe.

  • TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj: Added. Just calls

through to copy-resources.cmd.

  • TestWebKitAPI/win/copy-resources.cmd: Added. Copies resources into

or deletes resources from TestWebKitAPI.resources.

  • TestWebKitAPI/win/main.cpp: Added.

(main): Calls through to TestsController.

6:46 AM Changeset in webkit [69655] by xan@webkit.org
  • 10 edits in trunk

2010-10-13 Xan Lopez <​xlopez@igalia.com>

Reviewed by Gustavo Noronha.

[GTK] Remove more warnings from the g-i scanner run
​https://bugs.webkit.org/show_bug.cgi?id=47255

Fixes almost all warnings coming from the g-i scanner.

  • GNUmakefile.am: Add missing files and include dirs to the scanner run.

WebKit/gtk:

2010-10-13 Xan Lopez <​xlopez@igalia.com>

Reviewed by Gustavo Noronha.

[GTK] Remove more warnings from the g-i scanner run
​https://bugs.webkit.org/show_bug.cgi?id=47255

Fixes almost all warnings coming from the g-i scanner.

  • webkit/webkitsecurityorigin.cpp: Rename parameter names in gtk-doc blurb to the actual name of the parameter.
  • webkit/webkitsoupauthdialog.c: ditto. (webkit_soup_auth_dialog_class_init): Write missing doc for the 'current-toplevel' signal.
  • webkit/webkitsoupauthdialog.h: Rename signal parameter to its actual name.
  • webkit/webkitwebdatabase.cpp: Rename parameter names in gtk-doc blurb to the actual name of the parameter.
  • webkit/webkitwebinspector.cpp: ditto. (webkit_web_inspector_class_init): ditto.
  • webkit/webkitwebview.cpp: ditto. (webkit_web_view_class_init): ditto.
  • webkit/webkitwebview.h: Rename the parameter names to be in sync with the ones we use in the function definition.
6:32 AM Changeset in webkit [69654] by tonikitoo@webkit.org
  • 4 edits in trunk/LayoutTests

2010-10-13 Antonio Gomes <​agomes@rim.com>

Unreviewed clean up of Spatial Navigation tests listed in Mac, Gtk and Qt's Skipped files.

  • platform/qt/Skipped: Unskip fast/events/spatial-navigation/snav-clipped-overflowed-content.html
  • platform/gtk/Skipped: Added reference to the respective bug # for the skipped spatial navigation tests.
  • platform/mac/Skipped: Ditto.
6:09 AM Changeset in webkit [69653] by Csaba Osztrogonác
  • 3 edits in trunk/WebKit2

2010-10-13 Csaba Osztrogonác <Csaba Osztrogonác>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Simplify code generation in WebKit2/DerivedSources.pro
​https://bugs.webkit.org/show_bug.cgi?id=47543

  • DerivedSources.pro: General generator rules added instead of copy/paste code to converge Makefile.DerivedSources.
  • WebKit2.pro: PluginProcess' headers and sources added.
6:05 AM QtWebKitFeatures21 edited by Henry Haverinen
(diff)
6:04 AM QtWebKitFeatures21 edited by Henry Haverinen
(diff)
5:49 AM Changeset in webkit [69652] by apavlov@chromium.org
  • 2 edits in trunk/LayoutTests

2010-10-13 Alexander Pavlov <​apavlov@chromium.org>

[Chromium] Unreviewed, build fix.

Bring back the storage/change-version.html CRASH expectation (still crashes on the main waterfall).

  • platform/chromium/test_expectations.txt:
5:27 AM Changeset in webkit [69651] by yael.aharon@nokia.com
  • 3 edits
    2 adds in trunk

2010-10-13 Yael Aharon <​yael.aharon@nokia.com>

Reviewed by Andreas Kling.

Wrong ASSERT when select element has size 0
​https://bugs.webkit.org/show_bug.cgi?id=47567

  • fast/dom/HTMLSelectElement/click-size-zero-no-crash-expected.txt: Added.
  • fast/dom/HTMLSelectElement/click-size-zero-no-crash.html: Added.

2010-10-13 Yael Aharon <​yael.aharon@nokia.com>

Reviewed by Andreas Kling.

Wrong ASSERT when select element has size 0
​https://bugs.webkit.org/show_bug.cgi?id=47567

Keep the ASSERT only if the size of the element list is more than 0
Test: fast/dom/HTMLSelectElement/click-size-zero-no-crash.html

  • dom/SelectElement.cpp: (WebCore::SelectElement::updateListBoxSelection): (WebCore::SelectElement::listBoxDefaultEventHandler):
5:14 AM Changeset in webkit [69650] by commit-queue@webkit.org
  • 8 edits in trunk

2010-10-13 Gyuyoung Kim <​gyuyoung.kim@samsung.com>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Support viewport configuration and add new arguments for WebKit EFL
​https://bugs.webkit.org/show_bug.cgi?id=47084

Opera spec regarding to viewport meta tag was adjusted to WebCore. So, EFL port
needs to be modified according to the changes.

  • WebCoreSupport/ChromeClientEfl.cpp: (WebCore::ChromeClientEfl::dispatchViewportDataDidChange):
  • WebCoreSupport/FrameLoaderClientEfl.cpp: (WebCore::FrameLoaderClientEfl::dispatchDidCommitLoad):
  • ewk/ewk_private.h:
  • ewk/ewk_view.cpp: (_ewk_view_priv_new): (_ewk_view_viewport_attributes_compute): (ewk_view_viewport_attributes_set): (ewk_view_viewport_attributes_get): (ewk_view_device_pixel_ratio_get):
  • ewk/ewk_view.h:

2010-10-13 Gyuyoung Kim <​gyuyoung.kim@samsung.com>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Support viewport configuration and add new arguments for WebKit EFL
​https://bugs.webkit.org/show_bug.cgi?id=47084

Opera spec regarding to viewport meta tag was adjusted to WebCore. So, EFL port
needs to be modified according to the changes.

  • EWebLauncher/main.c: (on_viewport_changed):
5:05 AM Changeset in webkit [69649] by andreas.kling@nokia.com
  • 4 edits in trunk/WebKit2

2010-10-13 Andreas Kling <​kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Use flag instead of magic word to mark memory map free/used

Original patch by Antti Koivisto.

  • Shared/qt/MappedMemory.h: (WebKit::MappedMemory::mapSize): (WebKit::MappedMemory::markUsed): (WebKit::MappedMemory::markFree): (WebKit::MappedMemory::isFree): (WebKit::MappedMemory::data):
  • Shared/qt/MappedMemoryPool.cpp: (WebKit::MappedMemoryPool::cleanUp):
  • Shared/qt/UpdateChunk.cpp: (WebKit::mapMemory): (WebKit::mapFile): (WebKit::UpdateChunk::data): (WebKit::UpdateChunk::decode):
4:56 AM Changeset in webkit [69648] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-10-13 Dinu Jacob <​dinu.jacob@nokia.com>

Reviewed by Andreas Kling.

[Qt] Update .def file for Symbian
​https://bugs.webkit.org/show_bug.cgi?id=47540

Updated symbols for Symbian - added viewportAttributesForSize and
made viewportConfigurationForSize absent based on the API change in
47325

  • symbian/eabi/QtWebKitu.def:
3:17 AM Changeset in webkit [69647] by Nikolas Zimmermann
  • 3 edits
    6 adds in trunk/LayoutTests

2010-10-13 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed.

Rebaseline some windows tests. Add new expectations for two SVG tests.

  • platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/win/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/win/svg/batik: Added.
  • platform/win/svg/batik/masking: Added.
  • platform/win/svg/batik/masking/maskRegions-expected.txt: Added.
  • platform/win/svg/zoom: Added.
  • platform/win/svg/zoom/page: Added.
  • platform/win/svg/zoom/page/zoom-mask-with-percentages-expected.txt: Added.
3:00 AM Changeset in webkit [69646] by steveblock@google.com
  • 6 edits
    12 adds in trunk

2010-10-13 Steve Block <​steveblock@google.com>

Reviewed by Alexey Proskuryakov.

Pages using DeviceOrientation and DeviceMotion should not go into the page cache
​https://bugs.webkit.org/show_bug.cgi?id=47408

  • fast/dom/DeviceMotion/no-page-cache-expected.txt: Added.
  • fast/dom/DeviceMotion/no-page-cache.html: Added.
  • fast/dom/DeviceMotion/resources: Added.
  • fast/dom/DeviceMotion/resources/cached-page-1.html: Added.
  • fast/dom/DeviceMotion/resources/cached-page-2.html: Added.
  • fast/dom/DeviceMotion/script-tests/no-page-cache.js: Added. (reportPageOneOnload):
  • fast/dom/DeviceOrientation/no-page-cache-expected.txt: Added.
  • fast/dom/DeviceOrientation/no-page-cache.html: Added.
  • fast/dom/DeviceOrientation/resources: Added.
  • fast/dom/DeviceOrientation/resources/cached-page-1.html: Added.
  • fast/dom/DeviceOrientation/resources/cached-page-2.html: Added.
  • fast/dom/DeviceOrientation/script-tests/no-page-cache.js: Added. (reportPageOneOnload):

2010-10-13 Steve Block <​steveblock@google.com>

Reviewed by Alexey Proskuryakov.

Pages using DeviceOrientation and DeviceMotion should not go into the page cache
​https://bugs.webkit.org/show_bug.cgi?id=47408

Tests: fast/dom/DeviceMotion/no-page-cache.html

fast/dom/DeviceOrientation/no-page-cache.html

  • dom/DeviceMotionController.h: (WebCore::DeviceMotionController::isActive):
  • dom/DeviceOrientationController.h: (WebCore::DeviceOrientationController::isActive):
  • history/PageCache.cpp: (WebCore::logCanCachePageDecision): (WebCore::PageCache::canCache):
  • page/Page.cpp:
2:54 AM QtWebKitFeatures21 edited by Henry Haverinen
(diff)
2:24 AM Changeset in webkit [69645] by apavlov@chromium.org
  • 2 edits in trunk/LayoutTests

2010-10-13 Alexander Pavlov <​apavlov@chromium.org>

[Chromium] Unreviewed, build fix.

Disable printing/simultaneous-position-float-change.html as LayoutTestController::setPrinting()
is not implemented in Chromium.
​https://bugs.webkit.org/show_bug.cgi?id=47578

  • platform/chromium/test_expectations.txt:
2:18 AM QtWebKitFeatures21 created by Henry Haverinen
2:14 AM Changeset in webkit [69644] by rolandsteiner@chromium.org
  • 1 edit
    9 adds in trunk/LayoutTests

2010-10-13 Roland Steiner <​rolandsteiner@chromium.org>

Unreviewed: Chromium pixel baselines for new ruby test.

Add baselines for the new ruby test introduced in WK r69642.

  • platform/chromium-linux/fast/ruby/ruby-beforeafter-expected.checksum: Added.
  • platform/chromium-linux/fast/ruby/ruby-beforeafter-expected.png: Added.
  • platform/chromium-linux/fast/ruby/ruby-beforeafter-expected.txt: Added.
  • platform/chromium-mac/fast/ruby/ruby-beforeafter-expected.checksum: Added.
  • platform/chromium-mac/fast/ruby/ruby-beforeafter-expected.png: Added.
  • platform/chromium-win/fast/ruby/ruby-beforeafter-expected.checksum: Added.
  • platform/chromium-win/fast/ruby/ruby-beforeafter-expected.png: Added.
  • platform/chromium-win/fast/ruby/ruby-beforeafter-expected.txt: Added.
2:03 AM Changeset in webkit [69643] by commit-queue@webkit.org
  • 4 edits
    4 adds in trunk

2010-10-13 Jenn Braithwaite <​jennb@chromium.org>

Reviewed by Dmitry Titov.

Make resource identifiers unique across pages
​https://bugs.webkit.org/show_bug.cgi?id=47002

  • http/tests/misc/iframe-reparenting-id-collision-expected.txt: Added.
  • http/tests/misc/iframe-reparenting-id-collision.html: Added.
  • http/tests/misc/resources/iframe-reparenting-id-collision-page.html: Added.
  • http/tests/misc/resources/send-async-xhr.html: Added.

2010-10-13 Jenn Braithwaite <​jennb@chromium.org>

Reviewed by Dmitry Titov.

Make resource identifiers unique across pages
​https://bugs.webkit.org/show_bug.cgi?id=47002

Test: http/tests/misc/iframe-reparenting-id-collision.html

  • loader/ProgressTracker.cpp: (WebCore::ProgressTracker::ProgressTracker): (WebCore::ProgressTracker::createUniqueIdentifier):
  • loader/ProgressTracker.h:
12:25 AM Changeset in webkit [69642] by rolandsteiner@chromium.org
  • 8 edits
    1 copy
    5 adds in trunk

2010-10-07 Roland Steiner <​rolandsteiner@chromium.org>

Reviewed by Davit Hyatt.

Bug 41040 - :before/:after content should not become part of a ruby base
​https://bugs.webkit.org/show_bug.cgi?id=41040

Also related to:
​https://bugs.webkit.org/show_bug.cgi?id=40895.
​https://bugs.webkit.org/show_bug.cgi?id=43722.

Layout tests: verify that generated content is outside of the ruby base.
Also, tests shouldn't crash.

  • fast/ruby/after-doesnt-crash-expected.txt:
  • fast/ruby/after-doesnt-crash.html: Added.
  • fast/ruby/before-doesnt-crash.html:
  • fast/ruby/ruby-beforeafter.html: Added.
  • platform/gtk/Skipped:
  • platform/mac/fast/ruby/ruby-beforeafter-expected.checksum: Added.
  • platform/mac/fast/ruby/ruby-beforeafter-expected.png: Added.
  • platform/mac/fast/ruby/ruby-beforeafter-expected.txt: Added.
  • platform/qt/Skipped:

Explicitly handle :before and :after content in the default way.

Test: fast/ruby/ruby-beforeafter.html

fast/ruby/after-doesnt-crash.html

  • rendering/RenderObject.h: (WebCore::RenderObject::isBeforeContent):
  • rendering/RenderRuby.cpp: (WebCore::lastRubyRun): (WebCore::RenderRubyAsInline::addChild): (WebCore::RenderRubyAsInline::removeChild): (WebCore::RenderRubyAsBlock::addChild): (WebCore::RenderRubyAsBlock::removeChild):

Oct 12, 2010:

11:52 PM Changeset in webkit [69641] by jhoneycutt@apple.com
  • 2 edits in trunk/WebKit2

Build fix. Unreviewed.

  • win/WebKit2Generated.make:

Copy over WKBundleHitTestResult.h.

11:34 PM Changeset in webkit [69640] by commit-queue@webkit.org
  • 13 edits
    4 deletes in trunk

2010-10-12 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r69639.
​http://trac.webkit.org/changeset/69639
​https://bugs.webkit.org/show_bug.cgi?id=47575

"regressed nav-element.html" (Requested by rniwa on #webkit).

  • editing/execCommand/format-block-expected.txt:
  • editing/execCommand/format-block-from-range-selection-expected.txt:
  • editing/execCommand/format-block-multiple-paragraphs-expected.txt: Removed.
  • editing/execCommand/format-block-multiple-paragraphs.html: Removed.
  • editing/execCommand/format-block-table-expected.txt: Removed.
  • editing/execCommand/format-block-table.html: Removed.
  • editing/execCommand/format-block-with-braces-expected.txt:

2010-10-12 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r69639.
​http://trac.webkit.org/changeset/69639
​https://bugs.webkit.org/show_bug.cgi?id=47575

"regressed nav-element.html" (Requested by rniwa on #webkit).

  • editing/ApplyBlockElementCommand.cpp: (WebCore::ApplyBlockElementCommand::formatSelection):
  • editing/EditorCommand.cpp: (WebCore::executeFormatBlock):
  • editing/FormatBlockCommand.cpp: (WebCore::FormatBlockCommand::formatRange):
  • editing/FormatBlockCommand.h: (WebCore::FormatBlockCommand::editingAction):
  • editing/VisiblePosition.cpp: (WebCore::enclosingBlockFlowElement):
  • editing/VisiblePosition.h:
  • editing/htmlediting.cpp: (WebCore::validBlockTag):
  • editing/htmlediting.h:
11:01 PM Changeset in webkit [69639] by rniwa@webkit.org
  • 13 edits
    4 adds in trunk

2010-10-12 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Tony Chang.

execCommand FormatBlock creates lots of blockquotes
​https://bugs.webkit.org/show_bug.cgi?id=19795

The bug was caused by WebKit's not reusing the block node added by previous iteration
and its inserting block node at wrong places.

Fixed the bug by rewriting FormatBlockCommand::formatRange. New code resembles that of
IndentOutdentCommand::indentIntoBlockquote. The difference between two is that formatRange
avoids the existing block elements when replacing blocks and it also adds a placeholder
when removing the existing block caused paragraphs to collapse.

Tests: editing/execCommand/format-block-multiple-paragraphs.html

editing/execCommand/format-block-table.html

  • editing/EditorCommand.cpp: (WebCore::executeFormatBlock):
  • editing/FormatBlockCommand.cpp: (WebCore::FormatBlockCommand::formatRange): Rewritten; see above. (WebCore::FormatBlockCommand::isElementToApplyInFormatBlockCommand): Renamed from validBlockElement and moved from htmlediting.cpp. (WebCore::FormatBlockCommand::enclosingBlockToSplitTreeTo): Added.
  • editing/FormatBlockCommand.h:
  • editing/VisiblePosition.cpp: (WebCore::enclosingBlockFlowElement): Changed the return type to Element*
  • editing/VisiblePosition.h:

2010-10-12 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Tony Chang.

execCommand FormatBlock creates lots of blockquotes
​https://bugs.webkit.org/show_bug.cgi?id=19795

Added tests to ensure WebKit does not add multiple block elements when applying block element to
multiple paragraphs. Also added a test to ensure formatBlock works with tables.

  • editing/execCommand/format-block-expected.txt: Preserved span and removed erroneous br.
  • editing/execCommand/format-block-from-range-selection-expected.txt: Merged dl's and removed erroneous br.
  • editing/execCommand/format-block-multiple-paragraphs-expected.txt: Added.
  • editing/execCommand/format-block-multiple-paragraphs.html: Added.
  • editing/execCommand/format-block-table-expected.txt: Added.
  • editing/execCommand/format-block-table.html: Added.
  • editing/execCommand/format-block-with-braces-expected.txt: Removed erroneous br.
9:39 PM Changeset in webkit [69638] by dpranke@chromium.org
  • 7 edits in trunk/WebKitTools

2010-10-12 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Eric Seidel.

This patch enables new-run-webkit-tests (in particular the
chromium-win port) to run under Cygwin as well as Win32. Mostly
this just required some conversions from cygwin paths to Win32
paths when we spawn off Win32 binaries like test_shell.

​https://bugs.webkit.org/show_bug.cgi?id=47220

  • Scripts/webkitpy/common/system/path.py:
  • Expose the cygpath() function for path conversion
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
  • shift filename->uri conversion in the TestInfo objects to the dump_render_tree thread
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • use cygpath()
9:30 PM Changeset in webkit [69637] by yutak@chromium.org
  • 2 edits in trunk/WebKitTools

2010-10-12 Yuta Kitamura <​yutak@chromium.org>

Unreviewed. Add Yuta Kitamura (yutak) to the committers list.

  • Scripts/webkitpy/common/config/committers.py:
9:29 PM Changeset in webkit [69636] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-10-12 David Leong <​david.leong@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Enable Netscape plugin metadata caching on Linux
​https://bugs.webkit.org/show_bug.cgi?id=46287

QWebSettings::enablePersistentStorage will now store the netscape
plugin cache to QDesktopServices::CacheLocation.

  • Api/qwebsettings.cpp: (QWebSettings::enablePersistentStorage):
9:11 PM Changeset in webkit [69635] by Girish Ramakrishnan
  • 4 edits in trunk/WebCore

Make PluginView inherit from PluginViewBase.

Reviewed by Anders Carlsson.

This change is a precursor to adding accelerated compositing support
for NPAPI plugins.

​https://bugs.webkit.org/show_bug.cgi?id=47418

  • page/Page.cpp:

(WebCore::Page::privateBrowsingStateChanged):

  • plugins/PluginView.h:
  • plugins/PluginViewBase.h:

(WebCore::PluginViewBase::PluginViewBase):

8:25 PM WebKit Team edited by dbates@webkit.org
Remove extraneous single quote to fix formatting after revision 192 (diff)
7:26 PM Changeset in webkit [69634] by kinuko@chromium.org
  • 2 edits in trunk/WebCore

2010-10-12 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by Jian Li.

Pass platform path (rather than virtual path) when creating File from FileEntry
​https://bugs.webkit.org/show_bug.cgi?id=47563

No new tests, the new test for FileWriter will be verifying this.

  • fileapi/FileEntry.cpp: (WebCore::FileEntry::file):
7:25 PM Changeset in webkit [69633] by kbr@google.com
  • 3 edits in trunk/WebKit/chromium

2010-10-12 Kenneth Russell <​kbr@google.com>

Unreviewed. Fixes for all WebGL content causing assertion failures
in Chromium after ​http://trac.webkit.org/changeset/69619 and
​http://trac.webkit.org/changeset/69624 .

  • src/GraphicsContext3DChromium.cpp: (WebCore::GraphicsContext3D::create):
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
6:55 PM Changeset in webkit [69632] by Michael Nordman
  • 1 edit in trunk/WebKitTools/Scripts/webkitpy/common/config/committers.py

Unreviewed: Add Michael Nordman (michaeln) to the committers list.

6:47 PM Changeset in webkit [69631] by dumi@chromium.org
  • 1 edit
    6 adds in trunk/LayoutTests

Test that workers can be successfully interrupted in the middle of DB operations.

Reviewed by David Levin.

  • fast/workers/storage/interrupt-database-expected.txt: Added.
  • fast/workers/storage/interrupt-database-sync-expected.txt: Added.
  • fast/workers/storage/interrupt-database-sync.html: Added.
  • fast/workers/storage/interrupt-database.html: Added.
  • fast/workers/storage/resources/interrupt-database-sync.js: Added.
  • fast/workers/storage/resources/interrupt-database.js: Added.

(runTransaction):

6:46 PM Changeset in webkit [69630] by weinig@apple.com
  • 5 edits in trunk/WebKit2

Add API to get the target frame from a HitTestResult.

Reviewed by Gavin "Sometimes" Barraclough.

  • WebProcess/InjectedBundle/API/c/WKBundleHitTestResult.cpp:

(WKBundleHitTestResultGetFrame):
(WKBundleHitTestResultGetTargetFrame):

  • WebProcess/InjectedBundle/API/c/WKBundleHitTestResult.h:
  • WebProcess/InjectedBundle/InjectedBundleHitTestResult.cpp:

(WebKit::InjectedBundleHitTestResult::frame): Rename from webFrame.
(WebKit::InjectedBundleHitTestResult::targetFrame):

  • WebProcess/InjectedBundle/InjectedBundleHitTestResult.h:
6:40 PM Changeset in webkit [69629] by jorlow@chromium.org
  • 6 edits
    1 copy in branches/chromium/552/WebKit/chromium

Merge 69541 - 2010-10-11 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Nate Chapin.

[Chromium] Add plumbing for synchronous indexedDB exceptions
​https://bugs.webkit.org/show_bug.cgi?id=47511

Add a WebExceptionCode file (already run by fishd) and add versions of
each applicable method that take such a parameter. A follow up patch
will be posted with the meat.

  • WebKit.gyp:
  • public/WebExceptionCode.h: Added.
  • public/WebIDBCursor.h: (WebKit::WebIDBCursor::update): (WebKit::WebIDBCursor::continueFunction): (WebKit::WebIDBCursor::remove):
  • public/WebIDBDatabase.h: (WebKit::WebIDBDatabase::objectStore): (WebKit::WebIDBDatabase::createObjectStore): (WebKit::WebIDBDatabase::removeObjectStore): (WebKit::WebIDBDatabase::setVersion): (WebKit::WebIDBDatabase::transaction):
  • public/WebIDBIndex.h: (WebKit::WebIDBIndex::openObjectCursor): (WebKit::WebIDBIndex::openKeyCursor): (WebKit::WebIDBIndex::getObject): (WebKit::WebIDBIndex::getKey):
  • public/WebIDBObjectStore.h: (WebKit::WebIDBObjectStore::get): (WebKit::WebIDBObjectStore::put): (WebKit::WebIDBObjectStore::remove): (WebKit::WebIDBObjectStore::createIndex): (WebKit::WebIDBObjectStore::index): (WebKit::WebIDBObjectStore::removeIndex): (WebKit::WebIDBObjectStore::openCursor):

TBR=​jorlow@chromium.org

6:36 PM Changeset in webkit [69628] by hyatt@apple.com
  • 11 edits
    4 adds in trunk

<rdar://problem/8488444> REGRESSION (r67771)
​https://bugs.webkit.org/show_bug.cgi?id=47434
Crash when printing in RenderBlock::markDescendantBlocksAndLinesForLayout

Reviewed by Dan Bernstein

Added printing/simultaneous-position-float-change.html

Remove the markDescendantBlocksAndLinesForLayout method since it can walk m_floatingObjects lists with deleted
objects in them. Make the mechanism for relayout when the page height changes the same as the one when pageY
changes and just tie a concept of pageHeightChanged to the layout state. If that is set, blocks will just
automatically mark themselves as needing layout.

WebCore:

  • rendering/LayoutState.cpp:

(WebCore::LayoutState::LayoutState):

  • rendering/LayoutState.h:

(WebCore::LayoutState::LayoutState):
(WebCore::LayoutState::pageHeight):
(WebCore::LayoutState::pageHeightChanged):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::layoutBlockChild):
(WebCore::RenderBlock::layoutPositionedObjects):
(WebCore::RenderBlock::markForPaginationRelayoutIfNeeded):
(WebCore::RenderBlock::insertFloatingObject):
(WebCore::RenderBlock::positionNewFloats):

  • rendering/RenderBlock.h:
  • rendering/RenderBox.cpp:
  • rendering/RenderBox.h:

(WebCore::RenderBox::markForPaginationRelayoutIfNeeded):

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutHorizontalBox):
(WebCore::RenderFlexibleBox::layoutVerticalBox):

  • rendering/RenderView.cpp:

(WebCore::RenderView::RenderView):
(WebCore::RenderView::layout):

  • rendering/RenderView.h:

(WebCore::RenderView::setPageHeight):
(WebCore::RenderView::pushLayoutState):
(WebCore::LayoutStateMaintainer::LayoutStateMaintainer):
(WebCore::LayoutStateMaintainer::push):

LayoutTests:

  • platform/mac/printing/simultaneous-position-float-change-expected.checksum: Added.
  • platform/mac/printing/simultaneous-position-float-change-expected.png: Added.
  • platform/mac/printing/simultaneous-position-float-change-expected.txt: Added.
  • printing/simultaneous-position-float-change.html: Added.
6:23 PM Changeset in webkit [69627] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit/chromium

2010-10-12 Alok priyadarshi <​alokp@chromium.org>

Reviewed by Kenneth Russell.

Remove support for ANGLE SH_VERSION <= 100
​https://bugs.webkit.org/show_bug.cgi?id=47307

  • src/WebGraphicsContext3DDefaultImpl.cpp: (WebKit::WebGraphicsContext3DDefaultImpl::angleCreateCompilers): (WebKit::WebGraphicsContext3DDefaultImpl::angleValidateShaderSource):
6:23 PM Changeset in webkit [69626] by dumi@chromium.org
  • 1 edit
    3 adds in trunk/LayoutTests

Adding a test that makes sure the same database can be simultaneously accessed from workers and the page.

Reviewed by David Levin.

  • fast/workers/storage/resources/use-same-database-in-page-and-workers.js: Added.
  • fast/workers/storage/use-same-database-in-page-and-workers-expected.txt: Added.
  • fast/workers/storage/use-same-database-in-page-and-workers.html: Added.
6:05 PM Changeset in webkit [69625] by andersca@apple.com
  • 7 edits in trunk

Paint the find overlay background
​https://bugs.webkit.org/show_bug.cgi?id=47565

Reviewed by Dan Bernstein.

WebCore:

Export symbols required by WebKit2.

  • WebCore.exp.in:

WebKit2:

  • WebProcess/WebPage/FindController.cpp:

(WebKit::FindController::findString):
Don't show the overlay if we have too many matches.

  • WebProcess/WebPage/FindPageOverlay.cpp:

(WebKit::FindPageOverlay::rectsForTextMatches):
Get the rects for all text matches.

(WebKit::FindPageOverlay::drawRect):
Assert that we're only being called if there are any text matches.
Paint the background.

5:57 PM Changeset in webkit [69624] by jamesr@google.com
  • 7 edits in trunk

2010-10-12 James Robinson <​jamesr@chromium.org>

Unreviewed chromium compile fixes for ​http://trac.webkit.org/changeset/69619

  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::create): (WebCore::LayerRendererChromium::LayerRendererChromium):
  • platform/graphics/chromium/LayerRendererChromium.h:

2010-10-12 James Robinson <​jamesr@chromium.org>

Unreviewed chromium compile fixes for ​http://trac.webkit.org/changeset/69619.

  • src/GraphicsContext3DChromium.cpp: (WebCore::GraphicsContext3D::create):
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
  • src/WebViewImpl.h:
5:51 PM Changeset in webkit [69623] by aestes@apple.com
  • 2 edits in trunk/WebKit/mac

Check in some cleanup from the previous commit.

Rubber-stamped by Darin Adler.

  • WebView/WebView.mm:

(leakMailQuirksUserScriptPath): Renamed to indicate that this function
leaks an NSString.
(-[WebView _injectMailQuirksScript]): Moved a static initialization from
a separate class method into the only method that used it and removed
the now-unnecessary class method.

5:25 PM Changeset in webkit [69622] by aestes@apple.com
  • 4 edits
    1 add in trunk/WebKit

2010-10-12 Eric Seidel <​eric@webkit.org>

Reviewed by Darin Adler.

REGRESSION (new parser): Leopard/Tiger Mail <head>/<body> quirk is gone
​https://bugs.webkit.org/show_bug.cgi?id=45693

  • WebKit.xcodeproj/project.pbxproj:
    • Add the MailQuirksUserScript.js to the project.

2010-10-12 Eric Seidel <​eric@webkit.org>

Reviewed by Darin Adler.

REGRESSION (new parser): Leopard/Tiger Mail <head>/<body> quirk is gone
​https://bugs.webkit.org/show_bug.cgi?id=45693

Re-implement this former WebCore parser quirk as a
Mac-only userscript-based quirk. As far as I can tell
from Darin's description this should satisfy Mail's needs.

  • Misc/MailQuirksUserScript.js: Added.
  • WebView/WebView.mm: (+[WebView _mailQuirksUserScript]): (-[WebView _injectMailQuirksScript]): (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
5:25 PM Changeset in webkit [69621] by weinig@apple.com
  • 4 edits in trunk

When a provisional load fails, the provisional URL returned
from WKFrameCopyProvisionalURL should be empty
<rdar://problem/8540878>
​https://bugs.webkit.org/show_bug.cgi?id=47546

Reviewed by Dan Bernstein.

WebKit2:

API Tests: FailedLoad (updated).

  • UIProcess/WebFrameProxy.cpp:

(WebKit::WebFrameProxy::didFailProvisionalLoad): Empty out the provisional URL.

WebKitTools:

Add test.

  • TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:

(TestWebKitAPI::didFailProvisionalLoadWithErrorForFrame):

5:21 PM Changeset in webkit [69620] by Martin Robinson
  • 2 edits in trunk/LayoutTests

2010-10-12 Martin Robinson <​mrobinson@igalia.com>

Unskip a test which is now passing.

  • platform/gtk/Skipped: Unskip passing test.
5:16 PM Changeset in webkit [69619] by cmarrin@apple.com
  • 14 edits in trunk/WebCore

2010-10-12 Chris Marrin <​cmarrin@apple.com>

Reviewed by Darin Adler.

Manage DrawingBuffer lifetime in GraphicsContext3D
​https://bugs.webkit.org/show_bug.cgi?id=47501

GraphicsContext3D and DrawingBuffer are now Refcounted. DrawingBuffer
has a RefPtr to GraphicsContext3D to ensure the proper lifetime.
DrawingBuffer is now created by GraphicsContext3D. Also DrawingBuffer
refers to GraphicsContext3D rather than SharedGraphicsContext3D.

4:28 PM Changeset in webkit [69618] by ajwong@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed. Build fix.

Marking svg/text/text-tselect-02-f.svg as failed on linux.
It is failing consistently.

  • platform/chromium/test_expectations.txt:
4:14 PM Changeset in webkit [69617] by jianli@chromium.org
  • 2 edits in trunk/WebKit/chromium

Unreviewed. Bump up revision in order to pick up fix.

  • DEPS:
4:10 PM Changeset in webkit [69616] by andersca@apple.com
  • 11 edits
    4 copies in trunk

Start fleshing out find page overlays
​https://bugs.webkit.org/show_bug.cgi?id=47559

Reviewed by Sam Weinig.

WebKit2:

  • UIProcess/API/C/WKAPICast.h:

(WebKit::toFindOptions):
Handle the kWKFindOptionsShowFindIndicator flag.

  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:

Add new files.

  • WebProcess/WebPage/FindController.cpp:

(WebKit::FindController::FindController):
Initialize the find page overlay.

(WebKit::FindController::findString):
Hide or show the find page overlay.

(WebKit::FindController::findPageOverlayDestroyed):
Null out the find page overlay.

  • WebProcess/WebPage/FindPageOverlay.cpp: Added.
  • WebProcess/WebPage/FindPageOverlay.h: Added.

Add stubbed out FindPageOverlay class.

  • WebProcess/WebPage/PageOverlay.cpp: Added.

(WebKit::PageOverlay::setPage):
Set the parent web page.

(WebKit::PageOverlay::setNeedsDisplay):
Invalidate the parent web page.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::drawRect):
If there's a page overlay, ask it to draw on top of the page contents.

(WebKit::WebPage::installPageOverlay):
Set the page overlay.

(WebKit::WebPage::uninstallPageOverlay):
Clear the page overlay.

  • win/WebKit2.vcproj:

Add new files.

WebKitTools:

  • MiniBrowser/mac/BrowserWindowController.m:

(-[BrowserWindowController find:]):
Pass kWKFindOptionsShowOverlay to WKPageFindString.

3:47 PM Changeset in webkit [69615] by jianli@chromium.org
  • 2 edits in trunk/WebKit/chromium

Unreview. Build fix for chromium.

  • public/WebBlobRegistry.h:
3:37 PM Changeset in webkit [69614] by jberlin@webkit.org
  • 10 edits in trunk/WebKit2

Add ability for WK2 to register a scheme as secure.
​https://bugs.webkit.org/show_bug.cgi?id=47557

Reviewed by Jon Honeycutt.

Add the schemes that need to be registered as secure to the WebProcessCreationParameters.

  • Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):

  • Shared/WebProcessCreationParameters.h:
  • UIProcess/API/C/WKContext.cpp:

(WKContextRegisterURLSchemeAsSecure):

  • UIProcess/API/C/WKContextPrivate.h:
  • UIProcess/WebContext.cpp:

(WebKit::WebContext::ensureWebProcess):
Copy over the schemes that are to be registered as secure to the
WebProcessCreationParameters.
(WebKit::WebContext::registerURLSchemeAsSecure):
Only send a message to the WebProcess if it is valid.

  • UIProcess/WebContext.h:
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeWebProcess):
Register the schemes that need to be registered as secure from the
WebProcessCreationParameters.
(WebKit::WebProcess::registerURLSchemeAsSecure):

  • WebProcess/WebProcess.h:
  • WebProcess/WebProcess.messages.in:

Add the RegisterURLSchemeAsSecure message.

3:36 PM Changeset in webkit [69613] by commit-queue@webkit.org
  • 3 edits in trunk/WebKit/efl

2010-10-12 Gyuyoung Kim <​gyuyoung.kim@samsung.com>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Add a method to get target's dpi value
​https://bugs.webkit.org/show_bug.cgi?id=47537

Add a method to get target dpi value using Ecore_X.
When we set layout size, we need to use the dpi value.

  • ewk/ewk_private.h:
  • ewk/ewk_view.cpp: (ewk_view_page_rect_get): (ewk_view_dpi_get):
3:30 PM Changeset in webkit [69612] by andreip@google.com
  • 3 edits in trunk/LayoutTests

2010-10-11 Andrei Popescu <​andreip@google.com>

Reviewed by Jeremy Orlow.

storage/indexeddb/database-quota.html expects the wrong database version string
​https://bugs.webkit.org/show_bug.cgi?id=47533

  • storage/indexeddb/database-quota-expected.txt:
  • storage/indexeddb/database-quota.html:
3:16 PM Changeset in webkit [69611] by jianli@chromium.org
  • 5 edits
    1 copy
    1 move
    1 delete in trunk/WebKit/chromium

[chromium] Update WebBlobData to adapt to BlobData change in terms of
handling string data item.
​https://bugs.webkit.org/show_bug.cgi?id=47423

Reviewed by Darin Fisher.

Also remove unneeded methods in WebBlobData. WebBlobStorageData.* are
also removed since they're not longer needed.

  • WebKit.gyp:
  • public/WebBlobData.h:
  • public/WebBlobRegistry.h:
  • public/WebBlobStorageData.h: Removed.
  • public/WebThreadSafeData.h: Added.
  • src/WebBlobData.cpp:
  • src/WebBlobStorageData.cpp: Removed.
  • src/WebThreadSafeData.cpp: Added.
3:15 PM Changeset in webkit [69610] by jianli@chromium.org
  • 10 edits in trunk/WebCore

Fix passing blob data with string data item between threads.
​https://bugs.webkit.org/show_bug.cgi?id=46543

Reviewed by David Levin.

The fix is to use a thread-safe ref-counted Vector<char> to store the
string data. This also makes us be able to store any binary data in it.

I've also fix BlobBuilder and BlobRegistryImpl to avoid some additional
copies to make blob handling faster.

  • fileapi/BlobBuilder.cpp:

(WebCore::BlobBuilder::append):

  • fileapi/ThreadableBlobRegistry.cpp:

(WebCore::BlobRegistryContext::BlobRegistryContext):

  • platform/network/BlobData.cpp:

(WebCore::BlobDataItem::RawData::RawData):
(WebCore::BlobDataItem::RawData::detachFromCurrentThread):
(WebCore::BlobDataItem::detachFromCurrentThread):
(WebCore::BlobData::create):
(WebCore::BlobData::detachFromCurrentThread):
(WebCore::BlobData::appendData):

  • platform/network/BlobData.h:

(WebCore::BlobDataItem::RawData::create):
(WebCore::BlobDataItem::RawData::data):
(WebCore::BlobDataItem::RawData::length):
(WebCore::BlobDataItem::RawData::mutableData):
(WebCore::BlobDataItem::BlobDataItem):

  • platform/network/BlobRegistryImpl.cpp:

(WebCore::BlobRegistryImpl::registerBlobURL):

  • platform/network/BlobResourceHandle.cpp:

(WebCore::BlobResourceHandle::readDataSync):
(WebCore::BlobResourceHandle::readDataAsync):

  • platform/network/mac/FormDataStreamMac.mm:

(WebCore::setHTTPBody):

  • platform/text/LineEnding.cpp:

(OutputBuffer::CStringBuffer::CStringBuffer):
(OutputBuffer::CStringBuffer::~CStringBuffer):
(OutputBuffer::CStringBuffer::allocate):
(OutputBuffer::CStringBuffer::copy):
(OutputBuffer::CStringBuffer::buffer):
(OutputBuffer::VectorCharAppendBuffer::VectorCharAppendBuffer):
(OutputBuffer::VectorCharAppendBuffer::~VectorCharAppendBuffer):
(OutputBuffer::VectorCharAppendBuffer::allocate):
(OutputBuffer::VectorCharAppendBuffer::copy):
(OutputBuffer::internalNormalizeLineEndingsToCRLF):
(WebCore::normalizeToCROrLF):
(WebCore::normalizeLineEndingsToCRLF):
(WebCore::normalizeLineEndingsToCR):
(WebCore::normalizeLineEndingsToLF):
(WebCore::normalizeLineEndingsToNative):

  • platform/text/LineEnding.h:
3:05 PM Changeset in webkit [69609] by commit-queue@webkit.org
  • 3 edits in trunk/WebKit/chromium

2010-10-12 Kavita Kanetkar <​kkanetkar@chromium.org>

Reviewed by Dumitru Daniliuc.

[FileSystem] Add ability to pass a bool to create or not create root path while opening filesystem.
​https://bugs.webkit.org/show_bug.cgi?id=47519

  • public/WebCommonWorkerClient.h: (WebKit::WebCommonWorkerClient::openFileSystem):
  • public/WebFrameClient.h: (WebKit::WebFrameClient::openFileSystem):
3:05 PM Changeset in webkit [69608] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Windows build fix.

  • wtf/text/StringBuilder.h:

(WTF::StringBuilder::length):

2:59 PM Changeset in webkit [69607] by dumi@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, updating Chromium expectations.

  • platform/chromium/test_expectations.txt:
2:44 PM Changeset in webkit [69606] by Martin Robinson
  • 7 edits in trunk

2010-10-12 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r69589.
​http://trac.webkit.org/changeset/69589
​https://bugs.webkit.org/show_bug.cgi?id=47547

Wrong patch landed from a bug with two patches (Requested by
mrobinson on #webkit).

  • platform/network/ResourceHandleInternal.h: (WebCore::ResourceHandleInternal::ResourceHandleInternal):
  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandleInternal::~ResourceHandleInternal): (WebCore::ResourceHandle::~ResourceHandle): (WebCore::restartedCallback): (WebCore::gotChunkCallback): (WebCore::finishedCallback): (WebCore::parseDataUrl): (WebCore::startHttp):
  • platform/network/soup/ResourceRequest.h:
  • platform/network/soup/ResourceRequestSoup.cpp:

2010-10-12 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r69589.
​http://trac.webkit.org/changeset/69589
​https://bugs.webkit.org/show_bug.cgi?id=47547

Wrong patch landed from a bug with two patches (Requested by
mrobinson on #webkit).

  • webkit/webkitdownload.cpp: (webkit_download_new_with_handle): (webkit_download_start):
2:27 PM Changeset in webkit [69605] by jamesr@google.com
  • 2 edits in trunk/WebKit/chromium

2010-10-12 James Robinson <​jamesr@chromium.org>

Reviewed by Nate Chapin (in person).

Fix chromium compile.

  • src/WebPageSerializerImpl.cpp: (WebKit::WebPageSerializerImpl::WebPageSerializerImpl): (WebKit::WebPageSerializerImpl::serialize):
2:24 PM Changeset in webkit [69604] by sullivan@apple.com
  • 2 edits in trunk/WebKit2

​https://bugs.webkit.org/show_bug.cgi?id=47556
WKBundleNodeHandlePrivate.h should be marked private, not project

Reviewed by Anders Carlsson.

  • WebKit2.xcodeproj/project.pbxproj:

Marked WKBundleNodeHandlePrivate.h as private.

2:14 PM Changeset in webkit [69603] by Simon Fraser
  • 1 edit
    1 add in trunk/WebCore

2010-10-12 Simon Fraser <Simon Fraser>

Screen.availLeft should be signed
​https://bugs.webkit.org/show_bug.cgi?id=34397

Add the manual test missed in r69599.

  • manual-tests/screen-availLeft.html: Added.
2:12 PM Changeset in webkit [69602] by Girish Ramakrishnan
  • 4 edits in trunk/WebCore

[Qt] Windowless mode 64-bit Flash/X11 freezes when right-click is sent.

Reviewed by Ariya Hidayat.

Adds a new quirk PluginQuirkIgnoreRightClickInWindowlessMode. This
quirk is enabled only for 64-bit Flash/X11 and should not affect other
plugins. The freeze itself is in Flash code and the backtrace is not
useful.

​https://bugs.webkit.org/show_bug.cgi?id=47545

  • plugins/PluginPackage.cpp:

(WebCore::PluginPackage::determineQuirks):

  • plugins/PluginQuirkSet.h:
  • plugins/qt/PluginViewQt.cpp:

(WebCore::PluginView::handleMouseEvent):

2:09 PM Changeset in webkit [69601] by ajwong@chromium.org
  • 12 edits
    2 adds in trunk/LayoutTests

[chromium] Clean up test expectations from gardening shift.

File bugs for new issues, and rebaseline non-issues.

  • platform/chromium-linux/svg/text/text-tselect-02-f-expected.checksum:
  • platform/chromium-linux/svg/text/text-tselect-02-f-expected.png:
  • platform/chromium-mac/fast/css/transformed-mask-expected.checksum: Added.
  • platform/chromium-mac/fast/css/transformed-mask-expected.png: Added.
  • platform/chromium-win/svg/batik/paints/patternPreserveAspectRatioA-expected.checksum:
  • platform/chromium-win/svg/batik/paints/patternPreserveAspectRatioA-expected.png:
  • platform/chromium-win/svg/carto.net/button-expected.checksum:
  • platform/chromium-win/svg/carto.net/button-expected.png:
  • platform/chromium-win/svg/custom/marker-child-changes-expected.checksum:
  • platform/chromium-win/svg/custom/marker-child-changes-expected.png:
  • platform/chromium-win/svg/custom/marker-viewBox-changes-expected.checksum:
  • platform/chromium-win/svg/custom/marker-viewBox-changes-expected.png:
  • platform/chromium/test_expectations.txt:
2:06 PM Changeset in webkit [69600] by Simon Fraser
  • 3 edits in trunk/WebKit/mac

2010-10-12 Simon Fraser <Simon Fraser>

Reviewed by Sam Weinig.

Add 'didDraw' callback for framerate tracking
​https://bugs.webkit.org/show_bug.cgi?id=47478

Add a callback at the end of -[WebHTMLView drawRect:] so
a delegate can get notified when a draw happens.

  • WebView/WebHTMLView.mm: (-[WebHTMLView drawRect:]):
  • WebView/WebUIDelegatePrivate.h:
2:06 PM Changeset in webkit [69599] by Simon Fraser
  • 4 edits in trunk/WebCore

2010-10-08 Simon Fraser <Simon Fraser>

Reviewed by Alexey Proskuryakov.

Screen.availLeft should be signed
​https://bugs.webkit.org/show_bug.cgi?id=34397

For the screen to the left of the main screen, screen.availLeft
can be negative, so the Screen API needs to use signed numbers
for availLeft and availTop.

  • manual-tests/screen-availLeft.html: Added.
  • page/Screen.cpp: (WebCore::Screen::availLeft): (WebCore::Screen::availTop):
  • page/Screen.h:
  • page/Screen.idl:
2:00 PM Changeset in webkit [69598] by andersca@apple.com
  • 8 edits
    2 adds in trunk

Add FindController class
​https://bugs.webkit.org/show_bug.cgi?id=47555

Reviewed by Sam Weinig.

WebCore:

Export Page::findString.

  • WebCore.exp.in:

WebKit2:

  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:

Add new files.

  • WebProcess/WebPage/FindController.cpp: Added.

(WebKit::FindController::FindController):
(WebKit::FindController::findString):
Ask WebCore to find the given string for us.

(WebKit::FindController::hideFindUI):
Add stub.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):
Initialize the find controller.

(WebKit::WebPage::findString):
(WebKit::WebPage::hideFindUI):
Call the find controller.

  • win/WebKit2.vcproj:

Add new files.

1:46 PM Changeset in webkit [69597] by robert@webkit.org
  • 4 edits in trunk

2010-10-12 Robert Hogan <​robert@webkit.org>

Reviewed by Antonio Gomes.

[Qt] editing/input/emacs-ctrl-o.html

Unskip editing/input/emacs-ctrl-o.html

​https://bugs.webkit.org/show_bug.cgi?id=47548

  • platform/qt/Skipped:

2010-10-12 Robert Hogan <​robert@webkit.org>

Reviewed by Antonio Gomes.

[Qt] editing/input/emacs-ctrl-o.html

ctrl-o is bound to a sequence of commands on Mac, namely:
insertParagraphSeparator then moveLeft. In the DRT, we just interpret
ctrl-o in EventSenderQt as '\n', i.e. insertParagraphSeparator. As a
result we only issue one command, so don't generate the change in caret
position that results in the extra editing delegate messages.

So for the sake of not managing suspicious-looking differences, just
make DRT issue the appropriate edit commands to pass the test.

​https://bugs.webkit.org/show_bug.cgi?id=47548

  • DumpRenderTree/qt/EventSenderQt.cpp: (EventSender::keyDown):
1:28 PM Changeset in webkit [69596] by ap@apple.com
  • 5 edits in trunk/WebCore

Reviewed by Simon Fraser.

​https://bugs.webkit.org/show_bug.cgi?id=47550
<rdar://problem/8353386> For WebKit plug-ins, beforeload can be called recursively
(esp. with AdBlock style extensions)

No test - we don't have a WebKit-style plugin in DRT, and don't care enough to add one.

The fix is to block plug-in scripting while in beforeload event - the plug-in is obviously
not available yet, so scripting could only attempt to load it recursively.

This didn't affect NPAPI plug-ins, because of a completely different code path taken in
updateWidget(), see <​https://bugs.webkit.org/show_bug.cgi?id=44575#c8>.

  • html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::updateWidget):
  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::updateWidget):
  • html/HTMLPlugInElement.cpp: (WebCore::HTMLPlugInElement::HTMLPlugInElement): (WebCore::HTMLPlugInElement::pluginWidget):
  • html/HTMLPlugInElement.h:
1:28 PM Changeset in webkit [69595] by andersca@apple.com
  • 4 edits in trunk/WebKitTools

Add a simple Find UI to MiniBrowser
​https://bugs.webkit.org/show_bug.cgi?id=47553

Reviewed by Sam Weinig.

  • MiniBrowser/mac/BrowserWindow.xib:

Add Find panel.

  • MiniBrowser/mac/BrowserWindowController.h:
  • MiniBrowser/mac/BrowserWindowController.m:

(-[BrowserWindowController performFindPanelAction:]):
Show the find panel.

(-[BrowserWindowController find:]):
Tell the WKPageRef to find the given string.

12:47 PM Changeset in webkit [69594] by Nikolas Zimmermann
  • 49 edits
    1 move
    3 adds
    4 deletes in trunk

2010-10-12 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Gavin Barraclough.

Unify JSC::StringBuilder & WebCore::StringBuilder
​https://bugs.webkit.org/show_bug.cgi?id=47538

Move runtime/StringBuilder.h to wtf/text/StringBuilder.h. Rename build() to toString() and return a WTF::String().
Move the append(const JSC::UString&) method into runtime/UStringBuilder.h.
UStringBuilder inherits from StringBuilder.h and adds append(const JSC::UString&) and UString toUString() functionality.

No new code, just move code around.

  • GNUmakefile.am: Add wtf/text/StringBuilder.h / runtime/UStringBuilder.h. Remove runtime/StringBuilder.h.
  • JavaScriptCore.gypi: Ditto.
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Ditto.
  • JavaScriptCore.vcproj/WTF/WTF.vcproj: Ditto.
  • JavaScriptCore.xcodeproj/project.pbxproj: Ditto.
  • runtime/Executable.cpp: (JSC::FunctionExecutable::paramString): Use UStringBuilder, instead of StringBuilder. Rename build() -> toUString().
  • runtime/FunctionConstructor.cpp: (JSC::constructFunction): Ditto.
  • runtime/JSGlobalObjectFunctions.cpp: (JSC::globalFuncUnescape): Ditto.
  • runtime/JSONObject.cpp: (JSC::Stringifier::stringify): Ditto. (JSC::Stringifier::appendQuotedString): Ditto. (JSC::Stringifier::appendStringifiedValue): Ditto. (JSC::Stringifier::startNewLine): Ditto. (JSC::Stringifier::Holder::appendNextProperty): Ditto.
  • runtime/LiteralParser.cpp: (JSC::LiteralParser::Lexer::lexString): Ditto.
  • runtime/NumberPrototype.cpp: Remove unneeded JSStringBuilder.h / StringBuilder.h include.
  • runtime/StringBuilder.h: Removed.
  • runtime/UStringBuilder.h: Added. Inherits from WTF::StringBuilder, extending it by two methods. (JSC::UStringBuilder::append): append(const JSC::UString&) (JSC::UStringBuilder::toUString):
  • wtf/text/StringBuilder.h: Copied from runtime/StringBuilder.h. Move JSC::UString parts into runtime/UStringBuilder.h (WTF::StringBuilder::append): Renamed m_buffer to buffer everywhere. (WTF::StringBuilder::isEmpty): Ditto (+ constify method). (WTF::StringBuilder::reserveCapacity): Ditto. (WTF::StringBuilder::resize): Ditto. (WTF::StringBuilder::size): Ditto. (WTF::StringBuilder::operator[]): Ditto. (WTF::StringBuilder::toString): Ditto (+ renamed from build()). Returns a String, not an UString. The old build() method is now named toUString() and lives in UStringBuilder.

2010-10-12 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Gavin Barraclough.

Unify JSC::StringBuilder & WebCore::StringBuilder
​https://bugs.webkit.org/show_bug.cgi?id=47538

  • src/LocalizedStrings.cpp: (WebCore::imageTitle): Use WTF::StringBuilder.
  • src/WebEntities.cpp: (WebKit::WebEntities::convertEntitiesInString): Ditto.
  • src/WebPageSerializerImpl.cpp: Remove useless includes. (WebKit::WebPageSerializerImpl::encodeAndFlushBuffer):
  • src/WebPageSerializerImpl.h: Use WTF::StringBuilder.

2010-10-12 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Gavin Barraclough.

Unify JSC::StringBuilder & WebCore::StringBuilder
​https://bugs.webkit.org/show_bug.cgi?id=47538

JSC::StringBuilder operates on a Vector<UChar, 64> and allows to build a string based on a stream of characters in an efficient manner.
WebCore::StringBuilder operates on a Vector<String, 16> and allows to concat an arbitary number of Strings. It's not efficient in handling single
characters, as a String with length=1 has to be constructed for those. An analysis of the callers of WebCore::StringBuilder shows that
most callsites actually combine Strings and single characters, so using a Vector<UChar> would be more efficient. Those who only combine large
strings are only used for debugging purposes, so it's fine to switch them to a Vector<UChar> approach as well.

Replace WebCore::StringBuilder with JSC::StringBuilder, and move it to wtf/text/StringBuilder.h into the WTF namespace.
While I was at it remove platform/text/StringBuffer.h, as it was only including wtf/text/StringBuffer.h.

No change in functionality, thus no new tests.

  • Android.mk: Remove platform/text/StringBuilder.* and platform/text/StringBuffer.h.
  • CMakeLists.txt: Ditto.
  • GNUmakefile.am: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.order: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • ForwardingHeaders/runtime/StringBuilder.h: Removed.
  • ForwardingHeaders/runtime/UStringBuilder.h: Added.
  • ForwardingHeaders/wtf/text/StringBuilder.h: Added.
  • bindings/js/ScriptString.h: Don't include PlatformString.h but wtf/text/WTFString.h. (WebCore::ScriptString::operator+=): Use JSC::UStringBuilder instead of JSC::StringBuilder.
  • bridge/jni/JNIBridge.cpp: Use WTF::StringBuilder (+ use append(const UChar) for single characters).
  • css/MediaQuery.cpp: Ditto.
  • css/MediaQueryExp.cpp: Ditto.
  • dom/Node.cpp: Ditto. (WebCore::Node::appendTextContent): Manually track wheter the StringBuilder content is empty or null, the new StringBuilder doesn't differentiate between null & empty strings.
  • dom/Node.h: Remove appendTextContent definition, it's not needed to be exported, removes the need for a StringBuilder.h include or forward declaration.
  • html/DOMTokenList.cpp: Use WTF::StringBuilder.
  • inspector/InspectorResource.cpp: Remove useless StringBuffer.h include.
  • platform/android/FileSystemAndroid.cpp: Use WTF::StringBuilder.
  • platform/brew/FileSystemBrew.cpp: Ditto.
  • platform/chromium/ClipboardChromium.cpp: Ditto (+ use append(const UChar) for single characters).
  • platform/graphics/gpu/PODInterval.h: Ditto (Only used as debugging helper here, in debug builds).
  • platform/graphics/gpu/PODRedBlackTree.h: Ditto (Only used as debugging helper here, in debug builds).
  • platform/graphics/mac/GraphicsLayerCA.mm: Remove useless StringBuilder.h include.
  • platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp: Use WTF::StringBuilder, and use append(const UChar) for single characters.
  • platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp: Ditto.
  • platform/network/ProxyServer.cpp: (WebCore::appendProxyServerString): Use WTF::StringBuilder.
  • platform/text/StringBuffer.h: Removed.
  • platform/text/StringBuilder.cpp: Removed.
  • platform/text/StringBuilder.h: Removed.
  • plugins/DOMMimeType.cpp: Use WTF::StringBuilder.
  • svg/SVGPathParserFactory.cpp: Ditto.
  • svg/SVGPathStringBuilder.cpp: SVGPathStringBuilder used stringBuilder.toString(ConcatAddingSpacesBetweenIndividualStrings), adapt to the change, that this mode is gone now. (WebCore::SVGPathStringBuilder::result): Just use toString(), append a space to the end of each command, when building the string. Remove the last trailing space before building the result. (WebCore::SVGPathStringBuilder::moveTo): (WebCore::SVGPathStringBuilder::lineTo): (WebCore::SVGPathStringBuilder::lineToHorizontal): (WebCore::SVGPathStringBuilder::lineToVertical): (WebCore::SVGPathStringBuilder::curveToCubic): (WebCore::SVGPathStringBuilder::curveToCubicSmooth): (WebCore::SVGPathStringBuilder::curveToQuadratic): (WebCore::SVGPathStringBuilder::curveToQuadraticSmooth): (WebCore::SVGPathStringBuilder::arcTo): (WebCore::SVGPathStringBuilder::closePath):
  • svg/SVGPathStringBuilder.h: (WebCore::SVGPathStringBuilder::cleanup): StringBuilder::clear() is gone, just cleanup by assigning StringBuilder().
  • websockets/WebSocket.cpp: Use WTF::StringBuilder.
  • websockets/WebSocketHandshake.cpp: Ditto (+ use append(const UChar) for single characters).
12:15 PM Changeset in webkit [69593] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-10-12 Gyuyoung Kim <​gyuyoung.kim@samsung.com>

Reviewed by Antonio Gomes.

[EFL] Add a missing file in CMakeListEfl.txt
​https://bugs.webkit.org/show_bug.cgi?id=47480

IntRectEfl.cpp was missing in CMakeListEfl.txt. So, IntRectEfl.cpp is added.

  • CMakeListsEfl.txt:
12:01 PM Changeset in webkit [69592] by Dimitri Glazkov
  • 1 copy in branches/chromium/552

Create branch for Chromium 552.

11:37 AM Changeset in webkit [69591] by tony@chromium.org
  • 2 edits in trunk/WebKitTools

2010-10-12 Tony Chang <​tony@chromium.org>

Unreviewed, fixing DRT compile on Windows after r69586.

  • DumpRenderTree/chromium/WebThemeEngineDRT.h:
11:34 AM Changeset in webkit [69590] by msaboff@apple.com
  • 2 edits in trunk/JavaScriptCore

2010-10-12 Michael Saboff <​msaboff@apple.com>

Reviewed by Oliver Hunt.

Cleaned up the processing of replacements after regular expression
processing, especially the case where there wasn't a match.
Changed to use empty strings instead of computing a zero length sub
string.
​https://bugs.webkit.org/show_bug.cgi?id=47506

  • runtime/StringPrototype.cpp: (JSC::jsSpliceSubstringsWithSeparators): (JSC::stringProtoFuncReplace):
10:59 AM Changeset in webkit [69589] by commit-queue@webkit.org
  • 6 edits in trunk

2010-10-12 Sergio Villar Senin <​svillar@igalia.com>

Reviewed by Martin Robinson.

[GTK] Add HTTP caching support
​https://bugs.webkit.org/show_bug.cgi?id=44261

ResourceHandle's m_msg renamed to m_soupMsg and it's also now a PlatformRefPtr

  • webkit/webkitdownload.cpp: (webkit_download_new_with_handle): (webkit_download_start):
10:30 AM Changeset in webkit [69588] by senorblanco@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-10-07 Stephen White <​senorblanco@chromium.org>

Reviewed by James Robinson.

[chromium] Zero-out all textures created via WebGraphicsContext3DDefaultImpl::texImage2D().
​https://bugs.webkit.org/show_bug.cgi?id=47178


Covered by fast/canvas/toDataURL-alpha.html, when run with --accelerated-2d-canvas.

  • src/WebGraphicsContext3DDefaultImpl.cpp: (WebKit::bytesPerComponent): (WebKit::componentsPerPixel): (WebKit::imageSizeInBytes): (WebKit::WebGraphicsContext3DDefaultImpl::texImage2D):
10:20 AM Changeset in webkit [69587] by weinig@apple.com
  • 11 edits in trunk

Need WebKit2 API to get the cell above a table cell
<rdar://problem/8537111>
​https://bugs.webkit.org/show_bug.cgi?id=47532

Reviewed by Anders Carlsson.

WebCore:

Re-factor functionality to get the cell above a table cell
into a function on HTMLTableCellElement and export it for use
as SPI.

  • WebCore.exp.in:
  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLTableCellElement.cpp:

(WebCore::HTMLTableCellElement::cellAbove): Move implementation here...

  • html/HTMLTableCellElement.h:
  • page/Frame.cpp:

(WebCore::Frame::searchForLabelsAboveCell): ...from here.

WebKit2:

  • WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.cpp:

(WKBundleNodeHandleCopyHTMLTableCellElementCellAbove):

  • WebProcess/InjectedBundle/API/c/WKBundleNodeHandlePrivate.h:
  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:

(WebKit::InjectedBundleNodeHandle::copyHTMLTableCellElementCellAbove):

  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h:
10:10 AM Changeset in webkit [69586] by tony@chromium.org
  • 5 edits
    1 delete in trunk

2010-10-12 Dave Moore <​davemoore@chromium.org>

Reviewed by Tony Chang.

Use new WebThemeEngine api on chromium / linux to draw scrollbars.
​https://bugs.webkit.org/show_bug.cgi?id=47473

  • platform/chromium/ChromiumBridge.h:
  • platform/chromium/ScrollbarThemeChromiumLinux.cpp:

2010-10-12 Dave Moore <​davemoore@chromium.org>

Reviewed by Tony Chang.

Use new WebThemeEngine api on chromium / linux to draw scrollbars.
​https://bugs.webkit.org/show_bug.cgi?id=47473

  • public/WebThemeEngine.h: Removed.
  • chromium/src/ChromiumBridge.cpp:
9:32 AM Changeset in webkit [69585] by tony@chromium.org
  • 2 edits in trunk/WebKitTools

2010-10-12 Tony Chang <​tony@chromium.org>

Unreviewed, trying to fix NRWT on Windows.

  • Scripts/webkitpy/layout_tests/port/http_lock.py:
9:29 AM Changeset in webkit [69584] by andersca@apple.com
  • 6 edits
    2 adds in trunk/WebKit2

Add BinarySemaphore class to CoreIPC and use it in Connection::waitForSyncReply
​https://bugs.webkit.org/show_bug.cgi?id=47526

Reviewed by Sam Weinig.

  • Platform/CoreIPC/BinarySemaphore.cpp: Added.
  • Platform/CoreIPC/BinarySemaphore.h: Added.

Add BinarySemaphore class.

  • Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::sendSyncMessage):
(CoreIPC::Connection::waitForSyncReply):
(CoreIPC::Connection::processIncomingMessage):
Use the binary semaphore and the newly added m_pendingSyncRepliesMutex.

  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:

Add new files.

8:11 AM Changeset in webkit [69583] by Martin Robinson
  • 3 edits
    1 add in trunk/LayoutTests

2010-10-12 Martin Robinson <​mrobinson@igalia.com>

Rebaselined a failing tests. Unskipped editing tests that are passing and
categorized the remaining failing editing tests.

  • platform/gtk/Skipped: Updated skipped list.
  • platform/gtk/editing/style/apply-through-end-of-document-expected.txt: Added.
  • platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt: Rebaselined.
7:47 AM Changeset in webkit [69582] by yael.aharon@nokia.com
  • 3 edits
    2 adds in trunk

2010-10-12 Yael Aharon <​yael.aharon@nokia.com>

Reviewed by Antonio Gomes.

[Qt] Editing commands should not be executed on non-editable content.
​https://bugs.webkit.org/show_bug.cgi?id=47426

  • fast/events/scroll-after-click-on-tab-index-expected.txt: Added.
  • fast/events/scroll-after-click-on-tab-index.html: Added.

2010-10-12 Yael Aharon <​yael.aharon@nokia.com>

Reviewed by Antonio Gomes.

[Qt] Editing commands should not be executed on non-editable content.
​https://bugs.webkit.org/show_bug.cgi?id=47426

Remove calls to editor()->command() when we are not in editable content.
There is no value in doing that, and in some cases, it prevents scrolling.

  • WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::handleKeyboardEvent):
7:47 AM Changeset in webkit [69581] by kbalazs@webkit.org
  • 2 edits in trunk/WebKitTools

2010-10-12 Balazs Kelemen <​kbalazs@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt][WTR] Checking the path of the injected bundle is bogus
​https://bugs.webkit.org/show_bug.cgi?id=47541

  • WebKitTestRunner/qt/TestControllerQt.cpp: (WTR::isExistingLibrary): Added (static helper). Extend the path with the appropriate suffix(es) on the platform and check that the file exists. (WTR::TestController::initializeInjectedBundlePath): There were two bugs with the path checking:
    • the condition should have been inverted
    • QLibrary::fileName does not give back the filename with the library suffix so we cannot check that existance of the file this way.
7:17 AM Changeset in webkit [69580] by Adam Roben
  • 3 edits in trunk/WebKit2

Bring WebKit2 .vcproj files up-to-date with reality

  • win/WebKit2.vcproj:
  • win/WebKit2Generated.vcproj:

Added missing files, removed non-existent files.

7:05 AM Changeset in webkit [69579] by andreas.kling@nokia.com
  • 2 edits in trunk/WebCore

2010-10-12 Andreas Kling <​kling@webkit.org>

Reviewed by Antonio Gomes.

[Qt] Clipping problem viewing SVG with WebKit
​https://bugs.webkit.org/show_bug.cgi?id=29596

SVG path clipping (via GraphicsContext::clipPath()) was done using the
Qt::ReplaceClip mode (default) instead of Qt::IntersectClip. This led
to misrenderings when nesting multiple clip paths.

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::clipPath):
6:53 AM Changeset in webkit [69578] by Csaba Osztrogonác
  • 4 edits
    2 adds in trunk/WebKitTools

Implement http locking in NRWT.
​https://bugs.webkit.org/show_bug.cgi?id=47072

Patch by Gabor Rapcsanyi <​rgabor@inf.u-szeged.hu> on 2010-10-12
Reviewed by Tony Chang.

  • Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/http_lock.py: Added.
  • Scripts/webkitpy/layout_tests/port/http_lock_unittest.py: Added.
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
6:10 AM Changeset in webkit [69577] by apavlov@chromium.org
  • 2 edits in trunk/LayoutTests

2010-10-12 Alexander Pavlov <​apavlov@chromium.org>

[Chromium] Unreviewed, clean up chromium-win SVG test expectations.

Remove stale expectations for fixed or rebaselined SVG tests on Windows.

  • platform/chromium/test_expectations.txt:
5:32 AM Changeset in webkit [69576] by apavlov@chromium.org
  • 2 edits in trunk/LayoutTests

2010-10-12 Alexander Pavlov <​apavlov@chromium.org>

[Chromium] Unreviewed, clean up chromium-mac SVG test expectations.

Some tests have started to pass after a series of SVG test rebaselines.
Remove stale failure expectations.

  • platform/chromium/test_expectations.txt:
5:29 AM Changeset in webkit [69575] by mrowe@apple.com
  • 4 edits in trunk

Fix the 32-bit WebKit2 build.

WebKit2:

  • UIProcess/cf/WebBackForwardListCF.cpp:

(WebKit::WebBackForwardList::restoreFromCFDictionaryRepresentation): Change currentIndex to be of
type CFIndex and specify kCFNumberCFIndexType when calling CFNumberGetValue. This avoids a warning
when comparing currentIndex with another variable of type CFIndex later in the function.

WebKitTools:

  • MiniBrowser/mac/BrowserWindowController.m:

(getWindowFrame): Use NSRect rather than CGRect since that's what -frame returns.
(setWindowFrame): Use NSMakeRect rather than CGRectMake since that's what -setFrame:display: expects.

5:28 AM Changeset in webkit [69574] by mrowe@apple.com
  • 4 edits in trunk/WebKit2

Fix class vs struct forward declaration issues in WebKit2 observed when using clang.

  • Scripts/webkit2/messages.py: Add WebCore::ViewportArguments to the set of structs.
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.h:
4:55 AM Changeset in webkit [69573] by podivilov@chromium.org
  • 2 edits in trunk/LayoutTests

2010-10-12 Pavel Podivilov <​podivilov@chromium.org>

Unreviewed, build fix.

Build fix for r69567.

  • inspector/dom-breakpoints.html:
4:32 AM Changeset in webkit [69572] by Nikolas Zimmermann
  • 371 edits
    110 adds in trunk/LayoutTests

2010-10-12 Nikolas Zimmermann <​nzimmermann@rim.com>

Rubber-stamped by Dirk Schulze.

Update of Leopard pixel test baseline baseline after r69517.

  • platform/mac-leopard/svg/W3C-SVG-1.1-SE: Added.
  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.checksum: Added.

...

4:20 AM Changeset in webkit [69571] by apavlov@chromium.org
  • 1 edit
    9 adds in trunk/LayoutTests

2010-10-12 Alexander Pavlov <​apavlov@chromium.org>

[Chromium] Unreviewed, build fix.

Rebaseline inspector/console-dir-global.html to follow r69553.
Rebaseline some SVG tests on chromium-mac to follow r69563.

  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.png: Added.
  • platform/chromium-mac/svg/custom/gradient-with-1d-boundingbox-expected.checksum: Added.
  • platform/chromium-mac/svg/custom/gradient-with-1d-boundingbox-expected.png: Added.
  • platform/chromium-win/inspector/console-dir-global-expected.txt: Added.
4:14 AM Changeset in webkit [69570] by commit-queue@webkit.org
  • 3 edits in trunk/WebKit2

2010-10-12 Juha Savolainen <​juha.savolainen@weego.fi>

Reviewed by Antti Koivisto.

[Qt] Adding Qt WebKit2 API for zooming.
​https://bugs.webkit.org/show_bug.cgi?id=47539

Adding zoom methods to QWKPage.

  • UIProcess/API/qt/qwkpage.cpp: (QWKPage::textZoomFactor): Added (QWKPage::setTextZoomFactor): Added (QWKPage::pageZoomFactor): Added (QWKPage::setPageZoomFactor): Added (QWKPage::setPageAndTextZoomFactors): Added
  • UIProcess/API/qt/qwkpage.h:
3:22 AM Changeset in webkit [69569] by apavlov@chromium.org
  • 3 edits in trunk/LayoutTests

2010-10-12 Alexander Pavlov <​apavlov@chromium.org>

[Chromium] Unreviewed, build fix.

Rebaseline http/tests/security/cross-frame-access-get.html for chromium-mac and chromium-win

  • platform/chromium-mac/http/tests/security/cross-frame-access-get-expected.txt:
  • platform/chromium-win/http/tests/security/cross-frame-access-get-expected.txt:
2:35 AM Changeset in webkit [69568] by hamaji@chromium.org
  • 4 edits in trunk/LayoutTests

2010-10-12 Shinichiro Hamaji <​hamaji@chromium.org>

Update test expectations for r69564.

fast/text/backslash-to-yen-sign-euc.html fails on Windows
​https://bugs.webkit.org/show_bug.cgi?id=47018

  • platform/gtk/fast/text/backslash-to-yen-sign-euc-expected.txt:
  • platform/qt/fast/text/backslash-to-yen-sign-euc-expected.txt:
  • platform/win/fast/text/backslash-to-yen-sign-euc-expected.txt:
2:35 AM Changeset in webkit [69567] by podivilov@chromium.org
  • 15 edits in trunk/WebCore

2010-10-07 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: refactoring of native breakpoints.
​https://bugs.webkit.org/show_bug.cgi?id=47360

Make DOM, EventListener and XHR breakpoints subclasses of NativeBreakpoint class.
Move stuff that depends on breakpoint type to corresponding subclass.

  • inspector/Inspector.idl:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::didCommitLoad): (WebCore::InspectorController::setNativeBreakpoint): (WebCore::InspectorController::removeNativeBreakpoint): (WebCore::InspectorController::findEventListenerBreakpoint): (WebCore::InspectorController::findXHRBreakpoint):
  • inspector/InspectorController.h:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::setDOMBreakpoint): (WebCore::InspectorDOMAgent::removeDOMBreakpoint): (WebCore::InspectorDOMAgent::descriptionForDOMEvent): (WebCore::InspectorDOMAgent::didRemoveDOMNode): (WebCore::InspectorDOMAgent::removeBreakpointsForNode): (WebCore::InspectorDOMAgent::createBreakpointId):
  • inspector/InspectorDOMAgent.h:
  • inspector/InspectorDebuggerAgent.h:
  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::willInsertDOMNodeImpl): (WebCore::InspectorInstrumentation::willRemoveDOMNodeImpl): (WebCore::InspectorInstrumentation::willModifyDOMAttrImpl): (WebCore::InspectorInstrumentation::willSendXMLHttpRequestImpl): (WebCore::InspectorInstrumentation::willDispatchEventImpl):
  • inspector/front-end/BreakpointManager.js: (WebInspector.BreakpointManager): (WebInspector.BreakpointManager.prototype.reset): (WebInspector.BreakpointManager.prototype.createDOMBreakpoint): (WebInspector.BreakpointManager.prototype.createEventListenerBreakpoint): (WebInspector.BreakpointManager.prototype.createXHRBreakpoint): (WebInspector.BreakpointManager.prototype._removeNativeBreakpoint): (WebInspector.BreakpointManager.prototype._setNativeBreakpointOnBackend.didSetNativeBreakpoint): (WebInspector.BreakpointManager.prototype._setNativeBreakpointOnBackend): (WebInspector.BreakpointManager.prototype.debuggerPaused): (WebInspector.BreakpointManager.prototype.debuggerResumed): (WebInspector.BreakpointManager.prototype.restoreDOMBreakpoints.restoreBreakpointsForNode): (WebInspector.BreakpointManager.prototype.restoreDOMBreakpoints): (WebInspector.NativeBreakpoint): (WebInspector.NativeBreakpoint.prototype.remove): (WebInspector.NativeBreakpoint.prototype.get _frontendId): (WebInspector.NativeBreakpoint.prototype.get _type): (WebInspector.NativeBreakpoint.prototype._compare): (WebInspector.NativeBreakpoint.prototype._onRemove): (WebInspector.DOMBreakpoint): (WebInspector.DOMBreakpoint.prototype.click): (WebInspector.DOMBreakpoint.prototype.compareTo): (WebInspector.DOMBreakpoint.prototype.populateLabelElement): (WebInspector.DOMBreakpoint.prototype.populateStatusMessageElement.formatters.s): (WebInspector.DOMBreakpoint.prototype.populateStatusMessageElement.append): (WebInspector.DOMBreakpoint.prototype.populateStatusMessageElement): (WebInspector.DOMBreakpoint.prototype._condition): (WebInspector.DOMBreakpoint.prototype._onRemove): (WebInspector.EventListenerBreakpoint): (WebInspector.EventListenerBreakpoint.prototype.compareTo): (WebInspector.EventListenerBreakpoint.prototype.label): (WebInspector.EventListenerBreakpoint.prototype.populateStatusMessageElement): (WebInspector.EventListenerBreakpoint.prototype._condition): (WebInspector.XHRBreakpoint): (WebInspector.XHRBreakpoint.prototype.compareTo): (WebInspector.XHRBreakpoint.prototype.populateLabelElement): (WebInspector.XHRBreakpoint.prototype.populateStatusMessageElement): (WebInspector.XHRBreakpoint.prototype._condition): (WebInspector.domBreakpointTypeLabel): (WebInspector.domBreakpointTypeContextMenuLabel):
  • inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.BreakpointItem): (WebInspector.BreakpointItem.prototype._breakpointClicked): (WebInspector.EventListenerBreakpointsSidebarPane.prototype._populate):
  • inspector/front-end/CallStackSidebarPane.js: (WebInspector.CallStackSidebarPane): (WebInspector.CallStackSidebarPane.prototype.registerShortcuts): (WebInspector.CallStackSidebarPane.prototype._breakpointHit):
  • inspector/front-end/DOMAgent.js: (WebInspector.DOMNode): (WebInspector.DOMAgent.prototype._setDocument): (WebInspector.DOMAgent.prototype._removeBreakpoints): (WebInspector.childNodeRemoved):
  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype._populateTagContextMenu):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.debuggerPaused):
  • inspector/front-end/inspector.js: (WebInspector.createDOMBreakpointsSidebarPane.breakpointAdded): (WebInspector.createDOMBreakpointsSidebarPane): (WebInspector.reset):
1:39 AM Changeset in webkit [69566] by krit@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2010-10-12 Dirk Schulze <​krit@webkit.org>

Update of Leopard baseline after r69517.
Rubber-stamped by Nikolas Zimmermann.

  • platform/mac-leopard/svg/batik/masking/maskRegions-expected.txt: Added.
  • platform/mac-leopard/svg/zoom/page/zoom-mask-with-percentages-expected.txt: Added.
1:12 AM Changeset in webkit [69565] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed. Update Qt specific expected file after r69517.

  • platform/qt/svg/zoom/page/zoom-mask-with-percentages-expected.txt:
1:00 AM Changeset in webkit [69564] by hamaji@chromium.org
  • 5 edits in trunk/LayoutTests

2010-10-11 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by Alexey Proskuryakov.

REGRESSION (r63957): fast/text/backslash-to-yen-sign-euc.html fails on Mac
​https://bugs.webkit.org/show_bug.cgi?id=47017

  • fast/text/backslash-to-yen-sign-euc.html:
  • platform/mac/fast/text/backslash-to-yen-sign-euc-expected.checksum:
  • platform/mac/fast/text/backslash-to-yen-sign-euc-expected.png:
  • platform/mac/fast/text/backslash-to-yen-sign-euc-expected.txt:
12:55 AM Changeset in webkit [69563] by krit@webkit.org
  • 1103 edits in trunk/LayoutTests

2010-10-12 Dirk Schulze <​krit@webkit.org>

Update of Snow Leopard baseline after r69517.
Rubber-stamped by Nikolas Zimmermann.

  • platform/mac/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-02-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-04-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-05-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-06-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-07-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-09-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-10-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-11-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-12-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-13-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-14-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-15-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-16-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-17-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-18-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-19-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-20-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-21-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-22-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-23-t-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-23-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-24-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-25-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-26-t-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-26-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-27-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-28-t-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-28-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-29-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-29-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-30-t-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-30-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-31-t-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-31-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-32-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-33-t-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-33-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-37-t-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-37-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-39-t-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-39-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-44-t-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-44-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-80-t-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-80-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-84-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-85-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/color-prof-01-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/color-prop-01-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/color-prop-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/color-prop-02-f-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/color-prop-02-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/color-prop-03-t-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/color-prop-03-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/coords-coord-01-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/coords-coord-02-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/coords-trans-02-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/coords-trans-03-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/coords-trans-04-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/coords-trans-05-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/coords-trans-06-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/coords-units-01-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/coords-units-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/coords-units-02-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/coords-units-02-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/extend-namespace-01-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-felem-01-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/filters-felem-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-light-04-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-offset-01-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/filters-offset-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/fonts-desc-02-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/fonts-glyph-03-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/fonts-glyph-04-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/interact-cursor-01-f-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/interact-cursor-01-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/interact-dom-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/interact-events-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/interact-order-01-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/interact-order-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/interact-order-02-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/interact-order-02-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/interact-order-03-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/interact-zoom-01-t-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/interact-zoom-01-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/linking-a-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/linking-a-02-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/linking-a-03-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/linking-a-04-t-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/linking-a-04-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/linking-a-05-t-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/linking-a-05-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/linking-uri-01-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/linking-uri-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/linking-uri-02-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/linking-uri-02-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/masking-opacity-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/masking-path-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/masking-path-02-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/masking-path-03-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/masking-path-05-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/metadata-example-01-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/metadata-example-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/painting-fill-01-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/painting-fill-02-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/painting-fill-03-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/painting-fill-04-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/painting-fill-05-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/painting-marker-01-f-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/painting-marker-01-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/painting-marker-02-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/painting-marker-03-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/painting-render-01-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/painting-render-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/painting-stroke-01-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/painting-stroke-02-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/painting-stroke-03-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/painting-stroke-04-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/painting-stroke-07-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/paths-data-01-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/paths-data-04-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/paths-data-05-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/paths-data-06-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/paths-data-07-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/paths-data-08-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/paths-data-09-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/paths-data-10-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/paths-data-12-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/paths-data-13-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/paths-data-14-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-03-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-17-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-17-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/pservers-pattern-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/render-elems-01-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/render-elems-02-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/render-elems-06-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/render-elems-07-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/render-elems-08-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/script-handle-02-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/script-handle-02-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/script-handle-03-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/script-handle-03-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/script-handle-04-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/script-handle-04-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/shapes-circle-01-t-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/shapes-circle-01-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/shapes-circle-02-t-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/shapes-circle-02-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/shapes-ellipse-01-t-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/shapes-ellipse-01-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/shapes-ellipse-02-t-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/shapes-ellipse-02-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/shapes-intro-01-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/shapes-line-01-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/shapes-polygon-01-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/shapes-polyline-01-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/shapes-rect-01-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/shapes-rect-02-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/struct-cond-01-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/struct-cond-02-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/struct-cond-03-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/struct-defs-01-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/struct-dom-02-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/struct-dom-03-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/struct-dom-04-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/struct-dom-05-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/struct-frag-01-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/struct-frag-02-t-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/struct-frag-02-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/struct-frag-03-t-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/struct-frag-03-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/struct-frag-04-t-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/struct-frag-04-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/struct-frag-05-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/struct-group-01-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/struct-group-02-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/struct-image-05-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/struct-image-07-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/struct-use-01-t-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/struct-use-01-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/struct-use-05-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/styling-css-01-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/styling-css-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/styling-css-02-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/styling-css-02-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/styling-css-03-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/styling-css-03-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/styling-css-04-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/styling-css-05-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/styling-css-06-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/styling-inherit-01-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/styling-inherit-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/styling-pres-01-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/text-align-01-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/text-align-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/text-align-02-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/text-align-03-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/text-align-04-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/text-align-05-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/text-align-05-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/text-align-06-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/text-altglyph-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/text-deco-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/text-fonts-01-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/text-fonts-02-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/text-spacing-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/text-text-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/text-text-03-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/text-text-07-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/text-text-08-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/text-tref-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/text-tselect-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/text-tspan-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/text-ws-01-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/text-ws-02-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/types-basicDOM-01-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/types-basicDOM-01-b-expected.png:
  • platform/mac/svg/batik/filters/feTile-expected.png:
  • platform/mac/svg/batik/filters/filterRegions-expected.png:
  • platform/mac/svg/batik/masking/maskRegions-expected.checksum:
  • platform/mac/svg/batik/masking/maskRegions-expected.png:
  • platform/mac/svg/batik/paints/gradientLimit-expected.png:
  • platform/mac/svg/batik/paints/patternPreserveAspectRatioA-expected.checksum:
  • platform/mac/svg/batik/paints/patternPreserveAspectRatioA-expected.png:
  • platform/mac/svg/batik/paints/patternRegionA-expected.png:
  • platform/mac/svg/batik/paints/patternRegions-expected.checksum:
  • platform/mac/svg/batik/paints/patternRegions-expected.png:
  • platform/mac/svg/batik/paints/patternRegions-positioned-objects-expected.checksum:
  • platform/mac/svg/batik/paints/patternRegions-positioned-objects-expected.png:
  • platform/mac/svg/batik/text/longTextOnPath-expected.png:
  • platform/mac/svg/batik/text/textAnchor-expected.png:
  • platform/mac/svg/batik/text/textAnchor2-expected.png:
  • platform/mac/svg/batik/text/textAnchor3-expected.png:
  • platform/mac/svg/batik/text/textDecoration-expected.png:
  • platform/mac/svg/batik/text/textDecoration2-expected.png:
  • platform/mac/svg/batik/text/textEffect-expected.png:
  • platform/mac/svg/batik/text/textEffect2-expected.png:
  • platform/mac/svg/batik/text/textEffect3-expected.png:
  • platform/mac/svg/batik/text/textFeatures-expected.png:
  • platform/mac/svg/batik/text/textGlyphOrientationHorizontal-expected.png:
  • platform/mac/svg/batik/text/textLayout2-expected.png:
  • platform/mac/svg/batik/text/textLength-expected.png:
  • platform/mac/svg/batik/text/textOnPath-expected.png:
  • platform/mac/svg/batik/text/textOnPath2-expected.png:
  • platform/mac/svg/batik/text/textOnPath3-expected.png:
  • platform/mac/svg/batik/text/textOnPathSpaces-expected.png:
  • platform/mac/svg/batik/text/textPCDATA-expected.png:
  • platform/mac/svg/batik/text/textPosition-expected.png:
  • platform/mac/svg/batik/text/textPosition2-expected.png:
  • platform/mac/svg/batik/text/textProperties-expected.png:
  • platform/mac/svg/batik/text/textProperties2-expected.png:
  • platform/mac/svg/batik/text/textStyles-expected.png:
  • platform/mac/svg/batik/text/verticalText-expected.checksum:
  • platform/mac/svg/batik/text/verticalText-expected.png:
  • platform/mac/svg/batik/text/verticalTextOnPath-expected.png:
  • platform/mac/svg/batik/text/xmlSpace-expected.png:
  • platform/mac/svg/carto.net/button-expected.checksum:
  • platform/mac/svg/carto.net/button-expected.png:
  • platform/mac/svg/carto.net/colourpicker-expected.checksum:
  • platform/mac/svg/carto.net/colourpicker-expected.png:
  • platform/mac/svg/carto.net/combobox-expected.png:
  • platform/mac/svg/carto.net/scrollbar-expected.png:
  • platform/mac/svg/carto.net/selectionlist-expected.png:
  • platform/mac/svg/carto.net/slider-expected.png:
  • platform/mac/svg/carto.net/tabgroup-expected.png:
  • platform/mac/svg/carto.net/textbox-expected.png:
  • platform/mac/svg/carto.net/window-expected.png:
  • platform/mac/svg/clip-path/clip-in-mask-expected.checksum:
  • platform/mac/svg/clip-path/clip-in-mask-expected.png:
  • platform/mac/svg/clip-path/clip-in-mask-objectBoundingBox-expected.checksum:
  • platform/mac/svg/clip-path/clip-in-mask-objectBoundingBox-expected.png:
  • platform/mac/svg/clip-path/clip-in-mask-userSpaceOnUse-expected.checksum:
  • platform/mac/svg/clip-path/clip-in-mask-userSpaceOnUse-expected.png:
  • platform/mac/svg/clip-path/clip-path-child-clipped-expected.checksum:
  • platform/mac/svg/clip-path/clip-path-child-clipped-expected.png:
  • platform/mac/svg/clip-path/clip-path-childs-clipped-expected.checksum:
  • platform/mac/svg/clip-path/clip-path-childs-clipped-expected.png:
  • platform/mac/svg/clip-path/clip-path-clipped-evenodd-twice-expected.checksum:
  • platform/mac/svg/clip-path/clip-path-clipped-evenodd-twice-expected.png:
  • platform/mac/svg/clip-path/clip-path-clipped-expected.checksum:
  • platform/mac/svg/clip-path/clip-path-clipped-expected.png:
  • platform/mac/svg/clip-path/clip-path-clipped-no-content-expected.png:
  • platform/mac/svg/clip-path/clip-path-clipped-nonzero-expected.checksum:
  • platform/mac/svg/clip-path/clip-path-clipped-nonzero-expected.png:
  • platform/mac/svg/clip-path/clip-path-evenodd-expected.png:
  • platform/mac/svg/clip-path/clip-path-evenodd-nonzero-expected.checksum:
  • platform/mac/svg/clip-path/clip-path-evenodd-nonzero-expected.png:
  • platform/mac/svg/clip-path/clip-path-nonzero-evenodd-expected.checksum:
  • platform/mac/svg/clip-path/clip-path-nonzero-evenodd-expected.png:
  • platform/mac/svg/clip-path/clip-path-nonzero-expected.checksum:
  • platform/mac/svg/clip-path/clip-path-nonzero-expected.png:
  • platform/mac/svg/clip-path/clip-path-objectBoundingBox-expected.checksum:
  • platform/mac/svg/clip-path/clip-path-objectBoundingBox-expected.png:
  • platform/mac/svg/clip-path/clip-path-on-clipped-use-expected.checksum:
  • platform/mac/svg/clip-path/clip-path-on-clipped-use-expected.png:
  • platform/mac/svg/clip-path/clip-path-on-g-and-child-expected.checksum:
  • platform/mac/svg/clip-path/clip-path-on-g-and-child-expected.png:
  • platform/mac/svg/clip-path/clip-path-on-g-expected.checksum:
  • platform/mac/svg/clip-path/clip-path-on-g-expected.png:
  • platform/mac/svg/clip-path/clip-path-on-svg-and-child-expected.checksum:
  • platform/mac/svg/clip-path/clip-path-on-svg-and-child-expected.png:
  • platform/mac/svg/clip-path/clip-path-on-svg-expected.checksum:
  • platform/mac/svg/clip-path/clip-path-on-svg-expected.png:
  • platform/mac/svg/clip-path/clip-path-pixelation-expected.checksum:
  • platform/mac/svg/clip-path/clip-path-pixelation-expected.png:
  • platform/mac/svg/clip-path/clip-path-recursive-call-by-child-expected.png:
  • platform/mac/svg/clip-path/clip-path-recursive-call-expected.png:
  • platform/mac/svg/clip-path/clip-path-text-and-shape-expected.png:
  • platform/mac/svg/clip-path/clip-path-text-and-stroke-expected.png:
  • platform/mac/svg/clip-path/clip-path-text-expected.png:
  • platform/mac/svg/clip-path/clip-path-use-as-child-expected.checksum:
  • platform/mac/svg/clip-path/clip-path-use-as-child-expected.png:
  • platform/mac/svg/clip-path/clip-path-use-as-child2-expected.checksum:
  • platform/mac/svg/clip-path/clip-path-use-as-child2-expected.png:
  • platform/mac/svg/clip-path/clip-path-use-as-child3-expected.checksum:
  • platform/mac/svg/clip-path/clip-path-use-as-child3-expected.png:
  • platform/mac/svg/clip-path/clip-path-use-as-child4-expected.checksum:
  • platform/mac/svg/clip-path/clip-path-use-as-child4-expected.png:
  • platform/mac/svg/clip-path/clip-path-use-as-child5-expected.png:
  • platform/mac/svg/clip-path/clip-path-userSpaceOnUse-expected.png:
  • platform/mac/svg/clip-path/clip-path-with-container-expected.png:
  • platform/mac/svg/clip-path/clip-path-with-different-unittypes-expected.png:
  • platform/mac/svg/clip-path/clip-path-with-different-unittypes2-expected.png:
  • platform/mac/svg/clip-path/clip-path-with-invisibile-child-expected.png:
  • platform/mac/svg/clip-path/clip-path-with-text-clipped-expected.png:
  • platform/mac/svg/clip-path/deep-nested-clip-in-mask-different-unitTypes-expected.checksum:
  • platform/mac/svg/clip-path/deep-nested-clip-in-mask-different-unitTypes-expected.png:
  • platform/mac/svg/clip-path/deep-nested-clip-in-mask-expected.checksum:
  • platform/mac/svg/clip-path/deep-nested-clip-in-mask-expected.png:
  • platform/mac/svg/clip-path/deep-nested-clip-in-mask-panning-expected.checksum:
  • platform/mac/svg/clip-path/deep-nested-clip-in-mask-panning-expected.png:
  • platform/mac/svg/clip-path/nested-clip-in-mask-image-based-clipping-expected.checksum:
  • platform/mac/svg/clip-path/nested-clip-in-mask-image-based-clipping-expected.png:
  • platform/mac/svg/clip-path/nested-clip-in-mask-path-and-image-based-clipping-expected.checksum:
  • platform/mac/svg/clip-path/nested-clip-in-mask-path-and-image-based-clipping-expected.png:
  • platform/mac/svg/clip-path/nested-clip-in-mask-path-based-clipping-expected.checksum:
  • platform/mac/svg/clip-path/nested-clip-in-mask-path-based-clipping-expected.png:
  • platform/mac/svg/css/arrow-with-shadow-expected.png:
  • platform/mac/svg/css/background-image-svg-expected.png:
  • platform/mac/svg/css/circle-in-mask-with-shadow-expected.checksum:
  • platform/mac/svg/css/circle-in-mask-with-shadow-expected.png:
  • platform/mac/svg/css/clippath-with-shadow-expected.png:
  • platform/mac/svg/css/composite-shadow-example-expected.png:
  • platform/mac/svg/css/composite-shadow-text-expected.png:
  • platform/mac/svg/css/composite-shadow-with-opacity-expected.png:
  • platform/mac/svg/css/group-with-shadow-expected.png:
  • platform/mac/svg/css/mask-with-shadow-expected.checksum:
  • platform/mac/svg/css/mask-with-shadow-expected.png:
  • platform/mac/svg/css/path-with-shadow-expected.png:
  • platform/mac/svg/css/shadow-and-opacity-expected.png:
  • platform/mac/svg/css/shadow-changes-expected.checksum:
  • platform/mac/svg/css/shadow-changes-expected.png:
  • platform/mac/svg/css/shadow-with-large-radius-expected.png:
  • platform/mac/svg/css/shadow-with-negative-offset-expected.png:
  • platform/mac/svg/css/stars-with-shadow-expected.png:
  • platform/mac/svg/css/text-shadow-multiple-expected.png:
  • platform/mac/svg/custom/SVGMatrix-interface-expected.png:
  • platform/mac/svg/custom/SVGNumber-interface-expected.png:
  • platform/mac/svg/custom/SVGPoint-interface-expected.png:
  • platform/mac/svg/custom/SVGPoint-matrixTransform-expected.png:
  • platform/mac/svg/custom/SVGRect-interface-expected.png:
  • platform/mac/svg/custom/absolute-sized-content-with-resources-expected.checksum:
  • platform/mac/svg/custom/absolute-sized-content-with-resources-expected.png:
  • platform/mac/svg/custom/absolute-sized-svg-in-xhtml-expected.png:
  • platform/mac/svg/custom/alignment-baseline-modes-expected.png:
  • platform/mac/svg/custom/altglyph-expected.png:
  • platform/mac/svg/custom/animate-path-discrete-expected.png:
  • platform/mac/svg/custom/animate-path-morphing-expected.png:
  • platform/mac/svg/custom/animation-currentColor-expected.png:
  • platform/mac/svg/custom/attribute-namespace-check-expected.png:
  • platform/mac/svg/custom/broken-internal-references-expected.png:
  • platform/mac/svg/custom/bug45331-expected.png:
  • platform/mac/svg/custom/circle-move-invalidation-expected.checksum:
  • platform/mac/svg/custom/circle-move-invalidation-expected.png:
  • platform/mac/svg/custom/circular-marker-reference-1-expected.png:
  • platform/mac/svg/custom/circular-marker-reference-2-expected.checksum:
  • platform/mac/svg/custom/circular-marker-reference-2-expected.png:
  • platform/mac/svg/custom/circular-marker-reference-3-expected.png:
  • platform/mac/svg/custom/circular-marker-reference-4-expected.png:
  • platform/mac/svg/custom/class-baseValue-expected.png:
  • platform/mac/svg/custom/class-selector-expected.png:
  • platform/mac/svg/custom/clip-path-child-changes-expected.png:
  • platform/mac/svg/custom/clip-path-href-changes-expected.png:
  • platform/mac/svg/custom/clip-path-id-changes-expected.png:
  • platform/mac/svg/custom/clip-path-units-changes-expected.png:
  • platform/mac/svg/custom/clip-path-with-transform-expected.png:
  • platform/mac/svg/custom/clone-element-with-animated-svg-properties-expected.checksum:
  • platform/mac/svg/custom/clone-element-with-animated-svg-properties-expected.png:
  • platform/mac/svg/custom/conditional-processing-outside-switch-expected.png:
  • platform/mac/svg/custom/control-points-for-S-and-T-expected.png:
  • platform/mac/svg/custom/coords-relative-units-transforms-expected.png:
  • platform/mac/svg/custom/create-metadata-element-expected.png:
  • platform/mac/svg/custom/createImageElement-expected.png:
  • platform/mac/svg/custom/createImageElement2-expected.png:
  • platform/mac/svg/custom/createelement-expected.png:
  • platform/mac/svg/custom/css-pixels-dpi-expected.png:
  • platform/mac/svg/custom/dasharrayOrigin-expected.checksum:
  • platform/mac/svg/custom/dasharrayOrigin-expected.png:
  • platform/mac/svg/custom/deep-dynamic-updates-expected.png:
  • platform/mac/svg/custom/display-none-expected.png:
  • platform/mac/svg/custom/dominant-baseline-hanging-expected.checksum:
  • platform/mac/svg/custom/dominant-baseline-hanging-expected.png:
  • platform/mac/svg/custom/dominant-baseline-modes-expected.png:
  • platform/mac/svg/custom/dynamic-empty-path-expected.png:
  • platform/mac/svg/custom/dynamic-svg-document-creation-expected.png:
  • platform/mac/svg/custom/dynamic-viewBox-expected.png:
  • platform/mac/svg/custom/empty-clip-path-expected.png:
  • platform/mac/svg/custom/empty-mask-expected.png:
  • platform/mac/svg/custom/empty-merge-expected.png:
  • platform/mac/svg/custom/evt-onload-expected.png:
  • platform/mac/svg/custom/feComponentTransfer-Discrete-expected.png:
  • platform/mac/svg/custom/feComponentTransfer-Gamma-expected.png:
  • platform/mac/svg/custom/feComponentTransfer-Linear-expected.png:
  • platform/mac/svg/custom/feComponentTransfer-Table-expected.png:
  • platform/mac/svg/custom/feDisplacementMap-01-expected.png:
  • platform/mac/svg/custom/fill-SVGPaint-interface-expected.png:
  • platform/mac/svg/custom/fill-opacity-hsl-expected.png:
  • platform/mac/svg/custom/fill-opacity-rgba-expected.png:
  • platform/mac/svg/custom/fill-update-expected.png:
  • platform/mac/svg/custom/focus-ring-expected.checksum:
  • platform/mac/svg/custom/focus-ring-expected.png:
  • platform/mac/svg/custom/font-face-cascade-order-expected.png:
  • platform/mac/svg/custom/font-face-simple-expected.png:
  • platform/mac/svg/custom/foreign-object-skew-expected.checksum:
  • platform/mac/svg/custom/foreign-object-skew-expected.png:
  • platform/mac/svg/custom/foreignObject-crash-on-hover-expected.png:
  • platform/mac/svg/custom/fractional-rects-expected.png:
  • platform/mac/svg/custom/getTransformToElement-expected.png:
  • platform/mac/svg/custom/getscreenctm-in-mixed-content-expected.png:
  • platform/mac/svg/custom/getscreenctm-in-scrollable-div-area-expected.checksum:
  • platform/mac/svg/custom/getscreenctm-in-scrollable-div-area-expected.png:
  • platform/mac/svg/custom/getscreenctm-in-scrollable-div-area-nested-expected.checksum:
  • platform/mac/svg/custom/getscreenctm-in-scrollable-div-area-nested-expected.png:
  • platform/mac/svg/custom/getscreenctm-in-scrollable-svg-area-expected.checksum:
  • platform/mac/svg/custom/getscreenctm-in-scrollable-svg-area-expected.png:
  • platform/mac/svg/custom/glyph-selection-lang-attribute-expected.png:
  • platform/mac/svg/custom/glyph-transformation-with-hkern-expected.png:
  • platform/mac/svg/custom/gradient-add-stops-expected.png:
  • platform/mac/svg/custom/gradient-attr-update-expected.png:
  • platform/mac/svg/custom/gradient-cycle-detection-expected.png:
  • platform/mac/svg/custom/gradient-deep-referencing-expected.png:
  • platform/mac/svg/custom/gradient-rotated-bbox-expected.png:
  • platform/mac/svg/custom/gradient-stop-corner-cases-expected.png:
  • platform/mac/svg/custom/gradient-stop-style-change-expected.png:
  • platform/mac/svg/custom/gradient-stroke-width-expected.checksum:
  • platform/mac/svg/custom/gradient-stroke-width-expected.png:
  • platform/mac/svg/custom/gradient-userSpaceOnUse-with-percentage-expected.png:
  • platform/mac/svg/custom/gradient-with-1d-boundingbox-expected.checksum:
  • platform/mac/svg/custom/gradient-with-1d-boundingbox-expected.png:
  • platform/mac/svg/custom/grayscale-gradient-mask-expected.png:
  • platform/mac/svg/custom/group-opacity-expected.png:
  • platform/mac/svg/custom/hit-test-path-expected.png:
  • platform/mac/svg/custom/hit-test-path-stroke-expected.png:
  • platform/mac/svg/custom/hit-test-unclosed-subpaths-expected.png:
  • platform/mac/svg/custom/hit-test-with-br-expected.png:
  • platform/mac/svg/custom/hover-default-fill-expected.png:
  • platform/mac/svg/custom/image-small-width-height-expected.png:
  • platform/mac/svg/custom/image-with-aspect-ratio-stretch-expected.png:
  • platform/mac/svg/custom/image-with-prefix-in-webarchive-expected.png:
  • platform/mac/svg/custom/image-with-transform-clip-filter-expected.png:
  • platform/mac/svg/custom/inline-svg-in-xhtml-expected.checksum:
  • platform/mac/svg/custom/inline-svg-in-xhtml-expected.png:
  • platform/mac/svg/custom/inner-percent-expected.png:
  • platform/mac/svg/custom/inner-svg-hit-test-expected.png:
  • platform/mac/svg/custom/invalid-css-expected.checksum:
  • platform/mac/svg/custom/invalid-css-expected.png:
  • platform/mac/svg/custom/invalid-fill-expected.checksum:
  • platform/mac/svg/custom/invalid-fill-expected.png:
  • platform/mac/svg/custom/invalid-fill-hex-expected.checksum:
  • platform/mac/svg/custom/invalid-fill-hex-expected.png:
  • platform/mac/svg/custom/invalid-lengthlist-expected.png:
  • platform/mac/svg/custom/invalid-transforms-expected.png:
  • platform/mac/svg/custom/js-late-clipPath-and-object-creation-expected.png:
  • platform/mac/svg/custom/js-late-clipPath-creation-expected.png:
  • platform/mac/svg/custom/js-late-gradient-and-object-creation-expected.png:
  • platform/mac/svg/custom/js-late-gradient-creation-expected.png:
  • platform/mac/svg/custom/js-late-marker-and-object-creation-expected.checksum:
  • platform/mac/svg/custom/js-late-marker-and-object-creation-expected.png:
  • platform/mac/svg/custom/js-late-marker-creation-expected.checksum:
  • platform/mac/svg/custom/js-late-marker-creation-expected.png:
  • platform/mac/svg/custom/js-late-mask-and-object-creation-expected.png:
  • platform/mac/svg/custom/js-late-mask-creation-expected.png:
  • platform/mac/svg/custom/js-late-pattern-and-object-creation-expected.png:
  • platform/mac/svg/custom/js-late-pattern-creation-expected.png:
  • platform/mac/svg/custom/js-repaint-rect-on-path-with-stroke-expected.png:
  • platform/mac/svg/custom/js-update-bounce-expected.checksum:
  • platform/mac/svg/custom/js-update-bounce-expected.png:
  • platform/mac/svg/custom/js-update-container-expected.png:
  • platform/mac/svg/custom/js-update-container2-expected.png:
  • platform/mac/svg/custom/js-update-gradient-expected.png:
  • platform/mac/svg/custom/js-update-image-and-display-expected.png:
  • platform/mac/svg/custom/js-update-image-and-display2-expected.png:
  • platform/mac/svg/custom/js-update-image-and-display3-expected.png:
  • platform/mac/svg/custom/js-update-image-expected.png:
  • platform/mac/svg/custom/js-update-path-changes-expected.png:
  • platform/mac/svg/custom/js-update-path-removal-expected.png:
  • platform/mac/svg/custom/js-update-pattern-child-expected.png:
  • platform/mac/svg/custom/js-update-pattern-expected.png:
  • platform/mac/svg/custom/js-update-polygon-changes-expected.png:
  • platform/mac/svg/custom/js-update-polygon-removal-expected.png:
  • platform/mac/svg/custom/js-update-stop-expected.png:
  • platform/mac/svg/custom/js-update-stop-linked-gradient-expected.png:
  • platform/mac/svg/custom/js-update-style-expected.png:
  • platform/mac/svg/custom/js-update-transform-addition-expected.png:
  • platform/mac/svg/custom/js-update-transform-changes-expected.png:
  • platform/mac/svg/custom/junk-data-expected.png:
  • platform/mac/svg/custom/large-bounding-box-percents-expected.png:
  • platform/mac/svg/custom/linking-a-03-b-all-expected.checksum:
  • platform/mac/svg/custom/linking-a-03-b-all-expected.png:
  • platform/mac/svg/custom/linking-a-03-b-preserveAspectRatio-expected.checksum:
  • platform/mac/svg/custom/linking-a-03-b-preserveAspectRatio-expected.png:
  • platform/mac/svg/custom/linking-a-03-b-transform-expected.checksum:
  • platform/mac/svg/custom/linking-a-03-b-transform-expected.png:
  • platform/mac/svg/custom/linking-a-03-b-viewBox-expected.checksum:
  • platform/mac/svg/custom/linking-a-03-b-viewBox-expected.png:
  • platform/mac/svg/custom/linking-a-03-b-viewBox-transform-expected.checksum:
  • platform/mac/svg/custom/linking-a-03-b-viewBox-transform-expected.png:
  • platform/mac/svg/custom/linking-a-03-b-viewTarget-expected.checksum:
  • platform/mac/svg/custom/linking-a-03-b-viewTarget-expected.png:
  • platform/mac/svg/custom/linking-a-03-b-zoomAndPan-expected.checksum:
  • platform/mac/svg/custom/linking-a-03-b-zoomAndPan-expected.png:
  • platform/mac/svg/custom/marker-changes-expected.checksum:
  • platform/mac/svg/custom/marker-changes-expected.png:
  • platform/mac/svg/custom/marker-child-changes-css-expected.checksum:
  • platform/mac/svg/custom/marker-child-changes-css-expected.png:
  • platform/mac/svg/custom/marker-child-changes-expected.checksum:
  • platform/mac/svg/custom/marker-child-changes-expected.png:
  • platform/mac/svg/custom/marker-default-width-height-expected.png:
  • platform/mac/svg/custom/marker-empty-path-expected.png:
  • platform/mac/svg/custom/marker-opacity-expected.checksum:
  • platform/mac/svg/custom/marker-opacity-expected.png:
  • platform/mac/svg/custom/marker-overflow-clip-expected.png:
  • platform/mac/svg/custom/marker-referencePoint-expected.png:
  • platform/mac/svg/custom/marker-strokeWidth-changes-expected.checksum:
  • platform/mac/svg/custom/marker-strokeWidth-changes-expected.png:
  • platform/mac/svg/custom/marker-viewBox-changes-expected.checksum:
  • platform/mac/svg/custom/marker-viewBox-changes-expected.png:
  • platform/mac/svg/custom/mask-changes-expected.png:
  • platform/mac/svg/custom/mask-child-changes-expected.png:
  • platform/mac/svg/custom/mask-colorspace-expected.checksum:
  • platform/mac/svg/custom/mask-colorspace-expected.png:
  • platform/mac/svg/custom/mask-excessive-malloc-expected.png:
  • platform/mac/svg/custom/mask-inside-defs-expected.png:
  • platform/mac/svg/custom/mask-on-multiple-objects-expected.checksum:
  • platform/mac/svg/custom/mask-on-multiple-objects-expected.png:
  • platform/mac/svg/custom/mask-with-all-units-expected.png:
  • platform/mac/svg/custom/mask-with-default-value-expected.png:
  • platform/mac/svg/custom/massive-coordinates-expected.png:
  • platform/mac/svg/custom/missing-xlink-expected.png:
  • platform/mac/svg/custom/mouse-move-on-svg-container-expected.checksum:
  • platform/mac/svg/custom/mouse-move-on-svg-container-expected.png:
  • platform/mac/svg/custom/mouse-move-on-svg-container-standalone-expected.checksum:
  • platform/mac/svg/custom/mouse-move-on-svg-container-standalone-expected.png:
  • platform/mac/svg/custom/mouse-move-on-svg-root-expected.checksum:
  • platform/mac/svg/custom/mouse-move-on-svg-root-expected.png:
  • platform/mac/svg/custom/mouse-move-on-svg-root-standalone-expected.checksum:
  • platform/mac/svg/custom/mouse-move-on-svg-root-standalone-expected.png:
  • platform/mac/svg/custom/no-inherited-dashed-stroke-expected.png:
  • platform/mac/svg/custom/non-circular-marker-reference-expected.checksum:
  • platform/mac/svg/custom/non-circular-marker-reference-expected.png:
  • platform/mac/svg/custom/non-opaque-filters-expected.png:
  • platform/mac/svg/custom/non-scaling-stroke-expected.png:
  • platform/mac/svg/custom/non-scaling-stroke-markers-expected.png:
  • platform/mac/svg/custom/outer-svg-unknown-feature-expected.png:
  • platform/mac/svg/custom/path-textPath-simulation-expected.png:
  • platform/mac/svg/custom/path-update-expected.png:
  • platform/mac/svg/custom/path-zero-strokewidth-expected.checksum:
  • platform/mac/svg/custom/path-zero-strokewidth-expected.png:
  • platform/mac/svg/custom/pattern-cycle-detection-expected.png:
  • platform/mac/svg/custom/pattern-excessive-malloc-expected.png:
  • platform/mac/svg/custom/pattern-in-defs-expected.png:
  • platform/mac/svg/custom/pattern-incorrect-tiling-expected.checksum:
  • platform/mac/svg/custom/pattern-incorrect-tiling-expected.png:
  • platform/mac/svg/custom/pattern-no-pixelation-expected.checksum:
  • platform/mac/svg/custom/pattern-no-pixelation-expected.png:
  • platform/mac/svg/custom/pattern-rotate-expected.checksum:
  • platform/mac/svg/custom/pattern-rotate-expected.png:
  • platform/mac/svg/custom/pattern-size-bigger-than-target-size-expected.png:
  • platform/mac/svg/custom/pattern-skew-transformed-expected.png:
  • platform/mac/svg/custom/pattern-with-transformation-expected.png:
  • platform/mac/svg/custom/pattern-y-offset-expected.png:
  • platform/mac/svg/custom/percentage-rect-expected.png:
  • platform/mac/svg/custom/percentage-rect2-expected.png:
  • platform/mac/svg/custom/pointer-events-path-expected.png:
  • platform/mac/svg/custom/poly-identify-expected.png:
  • platform/mac/svg/custom/polyline-hittest-expected.png:
  • platform/mac/svg/custom/polyline-invalid-points-expected.png:
  • platform/mac/svg/custom/polyline-setattribute-points-null-expected.png:
  • platform/mac/svg/custom/prevent-default-expected.png:
  • platform/mac/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.png:
  • platform/mac/svg/custom/recursive-clippath-expected.png:
  • platform/mac/svg/custom/recursive-filter-expected.png:
  • platform/mac/svg/custom/recursive-gradient-expected.png:
  • platform/mac/svg/custom/recursive-mask-expected.png:
  • platform/mac/svg/custom/recursive-pattern-expected.png:
  • platform/mac/svg/custom/relative-sized-content-with-resources-expected.checksum:
  • platform/mac/svg/custom/relative-sized-content-with-resources-expected.png:
  • platform/mac/svg/custom/relative-sized-inner-svg-expected.png:
  • platform/mac/svg/custom/relative-sized-use-on-symbol-expected.png:
  • platform/mac/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.png:
  • platform/mac/svg/custom/repaint-moving-svg-and-div-expected.png:
  • platform/mac/svg/custom/repaint-on-image-bounds-change-expected.png:
  • platform/mac/svg/custom/repaint-stroke-width-changes-expected.png:
  • platform/mac/svg/custom/resource-client-removal-expected.png:
  • platform/mac/svg/custom/resource-invalidate-on-target-update-expected.checksum:
  • platform/mac/svg/custom/resource-invalidate-on-target-update-expected.png:
  • platform/mac/svg/custom/rgbcolor-syntax-expected.png:
  • platform/mac/svg/custom/root-container-opacity-clip-viewBox-expected.png:
  • platform/mac/svg/custom/rootelement-expected.png:
  • platform/mac/svg/custom/rounded-rects-expected.png:
  • platform/mac/svg/custom/scroll-hit-test-expected.png:
  • platform/mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
  • platform/mac/svg/custom/second-inline-text-expected.png:
  • platform/mac/svg/custom/shapes-supporting-markers-expected.checksum:
  • platform/mac/svg/custom/shapes-supporting-markers-expected.png:
  • platform/mac/svg/custom/sheet-title-expected.png:
  • platform/mac/svg/custom/simpleCDF-expected.png:
  • platform/mac/svg/custom/stroke-width-large-expected.png:
  • platform/mac/svg/custom/stroked-pattern-expected.checksum:
  • platform/mac/svg/custom/stroked-pattern-expected.png:
  • platform/mac/svg/custom/struct-use-09-b-expected.png:
  • platform/mac/svg/custom/style-attribute-font-size-expected.png:
  • platform/mac/svg/custom/svg-absolute-children-expected.png:
  • platform/mac/svg/custom/svg-curve-with-relative-cordinates-expected.png:
  • platform/mac/svg/custom/svg-fonts-in-html-expected.png:
  • platform/mac/svg/custom/svg-fonts-with-no-element-reference-expected.png:
  • platform/mac/svg/custom/svg-overflow-types-expected.png:
  • platform/mac/svg/custom/svgpolyparser-extra-space-expected.png:
  • platform/mac/svg/custom/text-clip-expected.png:
  • platform/mac/svg/custom/text-ctm-expected.png:
  • platform/mac/svg/custom/text-decoration-visibility-expected.png:
  • platform/mac/svg/custom/text-dom-01-f-expected.png:
  • platform/mac/svg/custom/text-dom-removal-expected.png:
  • platform/mac/svg/custom/text-filter-expected.png:
  • platform/mac/svg/custom/text-gradient-no-content-expected.png:
  • platform/mac/svg/custom/text-hit-test-expected.png:
  • platform/mac/svg/custom/text-image-opacity-expected.png:
  • platform/mac/svg/custom/text-letter-spacing-expected.png:
  • platform/mac/svg/custom/text-linking-expected.png:
  • platform/mac/svg/custom/text-repaint-including-stroke-expected.png:
  • platform/mac/svg/custom/text-rotated-gradient-expected.png:
  • platform/mac/svg/custom/text-rotation-expected.png:
  • platform/mac/svg/custom/text-whitespace-handling-expected.png:
  • platform/mac/svg/custom/text-x-dx-lists-expected.png:
  • platform/mac/svg/custom/text-x-dy-lists-expected.png:
  • platform/mac/svg/custom/text-x-override-in-tspan-child-expected.png:
  • platform/mac/svg/custom/text-xy-updates-SVGList-expected.png:
  • platform/mac/svg/custom/text-xy-updates-expected.png:
  • platform/mac/svg/custom/transform-ignore-after-invalid-expected.png:
  • platform/mac/svg/custom/transform-invalid-expected.png:
  • platform/mac/svg/custom/transform-removeAttributeNS-expected.png:
  • platform/mac/svg/custom/transform-scale-parse-expected.png:
  • platform/mac/svg/custom/transform-with-ending-space-expected.png:
  • platform/mac/svg/custom/transformedMaskFails-expected.png:
  • platform/mac/svg/custom/tref-update-expected.png:
  • platform/mac/svg/custom/use-clipped-hit-expected.png:
  • platform/mac/svg/custom/use-css-events-expected.checksum:
  • platform/mac/svg/custom/use-css-events-expected.png:
  • platform/mac/svg/custom/use-css-no-effect-on-shadow-tree-expected.png:
  • platform/mac/svg/custom/use-detach-expected.checksum:
  • platform/mac/svg/custom/use-detach-expected.png:
  • platform/mac/svg/custom/use-dynamic-append-expected.png:
  • platform/mac/svg/custom/use-elementInstance-event-target-expected.png:
  • platform/mac/svg/custom/use-elementInstance-methods-expected.png:
  • platform/mac/svg/custom/use-empty-reference-expected.png:
  • platform/mac/svg/custom/use-event-handler-on-referenced-element-expected.png:
  • platform/mac/svg/custom/use-event-handler-on-use-element-expected.png:
  • platform/mac/svg/custom/use-events-crash-expected.png:
  • platform/mac/svg/custom/use-font-face-crash-expected.png:
  • platform/mac/svg/custom/use-forward-refs-expected.png:
  • platform/mac/svg/custom/use-infinite-recursion-expected.png:
  • platform/mac/svg/custom/use-instanceRoot-modifications-expected.checksum:
  • platform/mac/svg/custom/use-instanceRoot-modifications-expected.png:
  • platform/mac/svg/custom/use-modify-container-in-target-expected.checksum:
  • platform/mac/svg/custom/use-modify-container-in-target-expected.png:
  • platform/mac/svg/custom/use-modify-target-container-expected.checksum:
  • platform/mac/svg/custom/use-modify-target-container-expected.png:
  • platform/mac/svg/custom/use-modify-target-symbol-expected.png:
  • platform/mac/svg/custom/use-nested-transform-expected.png:
  • platform/mac/svg/custom/use-on-clip-path-with-transformation-expected.png:
  • platform/mac/svg/custom/use-on-disallowed-foreign-object-1-expected.png:
  • platform/mac/svg/custom/use-on-disallowed-foreign-object-2-expected.png:
  • platform/mac/svg/custom/use-on-disallowed-foreign-object-3-expected.png:
  • platform/mac/svg/custom/use-on-disallowed-foreign-object-4-expected.png:
  • platform/mac/svg/custom/use-on-disallowed-foreign-object-5-expected.png:
  • platform/mac/svg/custom/use-on-disallowed-foreign-object-6-expected.png:
  • platform/mac/svg/custom/use-on-g-containing-foreignObject-and-image-expected.png:
  • platform/mac/svg/custom/use-on-g-containing-symbol-expected.png:
  • platform/mac/svg/custom/use-on-g-containing-use-expected.checksum:
  • platform/mac/svg/custom/use-on-g-containing-use-expected.png:
  • platform/mac/svg/custom/use-on-g-expected.checksum:
  • platform/mac/svg/custom/use-on-g-expected.png:
  • platform/mac/svg/custom/use-on-non-svg-namespaced-element-expected.png:
  • platform/mac/svg/custom/use-on-rect-expected.png:
  • platform/mac/svg/custom/use-on-symbol-expected.png:
  • platform/mac/svg/custom/use-on-symbol-inside-pattern-expected.png:
  • platform/mac/svg/custom/use-on-text-expected.png:
  • platform/mac/svg/custom/use-on-use-expected.checksum:
  • platform/mac/svg/custom/use-on-use-expected.png:
  • platform/mac/svg/custom/use-property-changes-through-dom-expected.png:
  • platform/mac/svg/custom/use-property-changes-through-svg-dom-expected.png:
  • platform/mac/svg/custom/use-property-synchronization-crash-expected.png:
  • platform/mac/svg/custom/use-recalcStyle-crash-expected.png:
  • platform/mac/svg/custom/use-recursion-1-expected.png:
  • platform/mac/svg/custom/use-recursion-2-expected.png:
  • platform/mac/svg/custom/use-recursion-3-expected.png:
  • platform/mac/svg/custom/use-recursion-4-expected.png:
  • platform/mac/svg/custom/use-referencing-nonexisting-symbol-expected.png:
  • platform/mac/svg/custom/use-setAttribute-crash-expected.checksum:
  • platform/mac/svg/custom/use-setAttribute-crash-expected.png:
  • platform/mac/svg/custom/use-symbol-overflow-expected.png:
  • platform/mac/svg/custom/use-transform-expected.checksum:
  • platform/mac/svg/custom/use-transform-expected.png:
  • platform/mac/svg/custom/viewBox-hit-expected.checksum:
  • platform/mac/svg/custom/viewBox-hit-expected.png:
  • platform/mac/svg/custom/viewport-clip-expected.png:
  • platform/mac/svg/custom/viewport-em-expected.png:
  • platform/mac/svg/custom/viewport-no-width-height-expected.png:
  • platform/mac/svg/custom/viewport-update-expected.png:
  • platform/mac/svg/custom/viewport-update2-expected.png:
  • platform/mac/svg/custom/visibility-override-clip-expected.png:
  • platform/mac/svg/custom/visibility-override-expected.png:
  • platform/mac/svg/custom/visibility-override-filter-expected.png:
  • platform/mac/svg/custom/visibility-override-mask-expected.png:
  • platform/mac/svg/custom/width-full-percentage-expected.checksum:
  • platform/mac/svg/custom/width-full-percentage-expected.png:
  • platform/mac/svg/custom/xhtml-no-svg-renderer-expected.png:
  • platform/mac/svg/custom/xml-stylesheet-expected.png:
  • platform/mac/svg/dom/SVGRectElement/rect-modify-rx-expected.png:
  • platform/mac/svg/dynamic-updates/SVGCircleElement-dom-cx-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGCircleElement-dom-cx-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGCircleElement-dom-cy-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGCircleElement-dom-cy-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGCircleElement-dom-r-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGCircleElement-dom-r-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGCircleElement-svgdom-cx-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGCircleElement-svgdom-cx-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGCircleElement-svgdom-cy-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGCircleElement-svgdom-cy-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGCircleElement-svgdom-r-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGCircleElement-svgdom-r-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGEllipseElement-dom-cx-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGEllipseElement-dom-cx-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGEllipseElement-dom-cy-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGEllipseElement-dom-cy-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGEllipseElement-dom-rx-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGEllipseElement-dom-rx-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGEllipseElement-dom-ry-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGEllipseElement-dom-ry-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGEllipseElement-svgdom-cx-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGEllipseElement-svgdom-cx-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGEllipseElement-svgdom-cy-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGEllipseElement-svgdom-cy-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGEllipseElement-svgdom-rx-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGEllipseElement-svgdom-rx-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGEllipseElement-svgdom-ry-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGEllipseElement-svgdom-ry-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-type-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-type-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-values-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-values-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-in-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-in-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-diffuseConstant-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-diffuseConstant-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-in-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-in-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-lighting-color-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-lighting-color-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-surfaceScale-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-surfaceScale-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-lighting-color-css-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-lighting-color-css-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-diffuseConstant-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-diffuseConstant-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-in-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-in-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-surfaceScale-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-surfaceScale-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDistantLightElement-dom-azimuth-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEDistantLightElement-dom-azimuth-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDistantLightElement-dom-elevation-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEDistantLightElement-dom-elevation-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDistantLightElement-svgdom-azimuth-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEDistantLightElement-svgdom-azimuth-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEDistantLightElement-svgdom-elevation-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEDistantLightElement-svgdom-elevation-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEMergeNodeElement-dom-in-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEMergeNodeElement-dom-in-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEMergeNodeElement-svgdom-in-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEMergeNodeElement-svgdom-in-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEOffsetElement-dom-dx-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEOffsetElement-dom-dx-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEOffsetElement-dom-dy-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEOffsetElement-dom-dy-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEOffsetElement-dom-in-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEOffsetElement-dom-in-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEOffsetElement-svgdom-dx-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEOffsetElement-svgdom-dx-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEOffsetElement-svgdom-dy-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEOffsetElement-svgdom-dy-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEOffsetElement-svgdom-in-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEOffsetElement-svgdom-in-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEPointLightElement-dom-x-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEPointLightElement-dom-x-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEPointLightElement-dom-y-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEPointLightElement-dom-y-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEPointLightElement-dom-z-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEPointLightElement-dom-z-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEPointLightElement-svgdom-x-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEPointLightElement-svgdom-x-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEPointLightElement-svgdom-y-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEPointLightElement-svgdom-y-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEPointLightElement-svgdom-z-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEPointLightElement-svgdom-z-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-dom-gradientTransform-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-dom-gradientTransform-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-dom-gradientUnits-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-dom-gradientUnits-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-dom-x1-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-dom-x1-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-dom-x2-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-dom-x2-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-dom-y1-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-dom-y1-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-dom-y2-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-dom-y2-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientTransform-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientTransform-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientUnits-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientUnits-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-svgdom-x1-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-svgdom-x1-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-svgdom-x2-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-svgdom-x2-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-svgdom-y1-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-svgdom-y1-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-svgdom-y2-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGLinearGradientElement-svgdom-y2-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGMaskElement-dom-height-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGMaskElement-dom-height-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGMaskElement-dom-maskContentUnits-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGMaskElement-dom-maskContentUnits-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGMaskElement-dom-maskUnits-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGMaskElement-dom-maskUnits-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGMaskElement-dom-width-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGMaskElement-dom-width-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGMaskElement-dom-x-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGMaskElement-dom-x-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGMaskElement-dom-y-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGMaskElement-dom-y-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGMaskElement-svgdom-height-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGMaskElement-svgdom-height-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGMaskElement-svgdom-maskContentUnits-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGMaskElement-svgdom-maskContentUnits-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGMaskElement-svgdom-maskUnits-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGMaskElement-svgdom-maskUnits-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGMaskElement-svgdom-width-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGMaskElement-svgdom-width-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGMaskElement-svgdom-x-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGMaskElement-svgdom-x-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGMaskElement-svgdom-y-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGMaskElement-svgdom-y-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-dom-cx-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-dom-cx-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-dom-cy-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-dom-cy-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-dom-fx-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-dom-fx-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-dom-fy-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-dom-fy-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-dom-gradientTransform-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-dom-gradientTransform-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-dom-gradientUnits-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-dom-gradientUnits-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-dom-r-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-dom-r-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-cx-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-cx-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-cy-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-cy-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-fx-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-fx-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-fy-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-fy-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientTransform-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientTransform-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientUnits-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientUnits-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-r-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-r-prop-expected.png:
  • platform/mac/svg/filters/big-sized-filter-2-expected.png:
  • platform/mac/svg/filters/feColorMatrix-values-expected.png:
  • platform/mac/svg/filters/feMerge-wrong-input-expected.png:
  • platform/mac/svg/filters/feOffset-expected.png:
  • platform/mac/svg/filters/filter-clip-expected.checksum:
  • platform/mac/svg/filters/filter-clip-expected.png:
  • platform/mac/svg/filters/filter-empty-g-expected.png:
  • platform/mac/svg/filters/filter-on-filter-for-text-expected.png:
  • platform/mac/svg/filters/parent-children-with-same-filter-expected.png:
  • platform/mac/svg/filters/sourceAlpha-expected.png:
  • platform/mac/svg/filters/subRegion-one-effect-expected.png:
  • platform/mac/svg/filters/subRegion-two-effects-expected.png:
  • platform/mac/svg/foreignObject/disallowed-svg-nodes-as-direct-children-expected.png:
  • platform/mac/svg/foreignObject/text-tref-02-b-expected.png:
  • platform/mac/svg/hixie/cascade/001-broken-expected.checksum:
  • platform/mac/svg/hixie/cascade/001-broken-expected.png:
  • platform/mac/svg/hixie/cascade/002-expected.checksum:
  • platform/mac/svg/hixie/cascade/002-expected.png:
  • platform/mac/svg/hixie/data-types/001-expected.png:
  • platform/mac/svg/hixie/dynamic/002-expected.png:
  • platform/mac/svg/hixie/dynamic/003-expected.png:
  • platform/mac/svg/hixie/dynamic/004-expected.png:
  • platform/mac/svg/hixie/dynamic/005-expected.png:
  • platform/mac/svg/hixie/dynamic/006-expected.png:
  • platform/mac/svg/hixie/error/001-expected.png:
  • platform/mac/svg/hixie/error/003-expected.png:
  • platform/mac/svg/hixie/error/006-expected.png:
  • platform/mac/svg/hixie/error/007-expected.png:
  • platform/mac/svg/hixie/error/008-expected.png:
  • platform/mac/svg/hixie/error/009-expected.png:
  • platform/mac/svg/hixie/error/010-expected.png:
  • platform/mac/svg/hixie/error/011-expected.png:
  • platform/mac/svg/hixie/error/014-expected.png:
  • platform/mac/svg/hixie/error/014-test-expected.png:
  • platform/mac/svg/hixie/error/015-expected.png:
  • platform/mac/svg/hixie/error/016-expected.png:
  • platform/mac/svg/hixie/error/017-expected.checksum:
  • platform/mac/svg/hixie/error/017-expected.png:
  • platform/mac/svg/hixie/links/001-expected.checksum:
  • platform/mac/svg/hixie/links/001-expected.png:
  • platform/mac/svg/hixie/links/002-expected.png:
  • platform/mac/svg/hixie/links/003-broken-expected.checksum:
  • platform/mac/svg/hixie/links/003-broken-expected.png:
  • platform/mac/svg/hixie/mixed/003-expected.checksum:
  • platform/mac/svg/hixie/mixed/003-expected.png:
  • platform/mac/svg/hixie/mixed/004-expected.checksum:
  • platform/mac/svg/hixie/mixed/004-expected.png:
  • platform/mac/svg/hixie/mixed/005-expected.checksum:
  • platform/mac/svg/hixie/mixed/005-expected.png:
  • platform/mac/svg/hixie/mixed/006-expected.checksum:
  • platform/mac/svg/hixie/mixed/006-expected.png:
  • platform/mac/svg/hixie/mixed/008-expected.checksum:
  • platform/mac/svg/hixie/mixed/008-expected.png:
  • platform/mac/svg/hixie/mixed/011-expected.checksum:
  • platform/mac/svg/hixie/mixed/011-expected.png:
  • platform/mac/svg/hixie/painting/001-expected.png:
  • platform/mac/svg/hixie/perf/001-expected.checksum:
  • platform/mac/svg/hixie/perf/001-expected.png:
  • platform/mac/svg/hixie/perf/002-expected.checksum:
  • platform/mac/svg/hixie/perf/002-expected.png:
  • platform/mac/svg/hixie/perf/003-expected.png:
  • platform/mac/svg/hixie/perf/004-expected.png:
  • platform/mac/svg/hixie/perf/005-expected.png:
  • platform/mac/svg/hixie/perf/006-expected.png:
  • platform/mac/svg/hixie/perf/007-expected.checksum:
  • platform/mac/svg/hixie/perf/007-expected.png:
  • platform/mac/svg/hixie/processing-model/005-expected.png:
  • platform/mac/svg/hixie/rendering-model/001-expected.checksum:
  • platform/mac/svg/hixie/rendering-model/001-expected.png:
  • platform/mac/svg/hixie/rendering-model/002-expected.checksum:
  • platform/mac/svg/hixie/rendering-model/002-expected.png:
  • platform/mac/svg/hixie/rendering-model/003a-expected.png:
  • platform/mac/svg/hixie/shapes/path/001-expected.checksum:
  • platform/mac/svg/hixie/shapes/path/001-expected.png:
  • platform/mac/svg/hixie/text/001-expected.png:
  • platform/mac/svg/hixie/text/002-expected.png:
  • platform/mac/svg/hixie/text/003a-expected.png:
  • platform/mac/svg/hixie/text/003b-expected.png:
  • platform/mac/svg/hixie/transform/001-expected.checksum:
  • platform/mac/svg/hixie/transform/001-expected.png:
  • platform/mac/svg/hixie/use/001-expected.png:
  • platform/mac/svg/hixie/use/002-expected.png:
  • platform/mac/svg/hixie/use/002-test-expected.png:
  • platform/mac/svg/hixie/viewbox/001-expected.png:
  • platform/mac/svg/hixie/viewbox/002-expected.png:
  • platform/mac/svg/hixie/viewbox/003-expected.png:
  • platform/mac/svg/hixie/viewbox/004-expected.png:
  • platform/mac/svg/hixie/viewbox/preserveAspectRatio/001-expected.png:
  • platform/mac/svg/hixie/viewbox/preserveAspectRatio/002-expected.png:
  • platform/mac/svg/in-html/circle-expected.checksum:
  • platform/mac/svg/in-html/circle-expected.png:
  • platform/mac/svg/overflow/overflow-on-foreignObject-expected.png:
  • platform/mac/svg/overflow/overflow-on-inner-svg-element-defaults-expected.png:
  • platform/mac/svg/overflow/overflow-on-inner-svg-element-expected.png:
  • platform/mac/svg/overflow/overflow-on-outermost-svg-element-defaults-expected.png:
  • platform/mac/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-1-expected.png:
  • platform/mac/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-2-expected.png:
  • platform/mac/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-3-expected.png:
  • platform/mac/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-auto-expected.png:
  • platform/mac/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults-expected.png:
  • platform/mac/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-hidden-expected.png:
  • platform/mac/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-scroll-expected.png:
  • platform/mac/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-visible-expected.png:
  • platform/mac/svg/text/foreignObject-repaint-expected.png:
  • platform/mac/svg/text/select-textLength-spacing-squeeze-1-expected.png:
  • platform/mac/svg/text/select-textLength-spacing-squeeze-2-expected.png:
  • platform/mac/svg/text/select-textLength-spacing-squeeze-3-expected.png:
  • platform/mac/svg/text/select-textLength-spacing-squeeze-4-expected.png:
  • platform/mac/svg/text/select-textLength-spacing-stretch-1-expected.png:
  • platform/mac/svg/text/select-textLength-spacing-stretch-2-expected.png:
  • platform/mac/svg/text/select-textLength-spacing-stretch-3-expected.png:
  • platform/mac/svg/text/select-textLength-spacing-stretch-4-expected.png:
  • platform/mac/svg/text/select-textLength-spacingAndGlyphs-squeeze-1-expected.png:
  • platform/mac/svg/text/select-textLength-spacingAndGlyphs-squeeze-2-expected.png:
  • platform/mac/svg/text/select-textLength-spacingAndGlyphs-squeeze-3-expected.png:
  • platform/mac/svg/text/select-textLength-spacingAndGlyphs-squeeze-4-expected.png:
  • platform/mac/svg/text/select-textLength-spacingAndGlyphs-stretch-1-expected.png:
  • platform/mac/svg/text/select-textLength-spacingAndGlyphs-stretch-2-expected.png:
  • platform/mac/svg/text/select-textLength-spacingAndGlyphs-stretch-3-expected.png:
  • platform/mac/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.png:
  • platform/mac/svg/text/select-x-list-1-expected.png:
  • platform/mac/svg/text/select-x-list-2-expected.png:
  • platform/mac/svg/text/select-x-list-3-expected.png:
  • platform/mac/svg/text/select-x-list-4-expected.png:
  • platform/mac/svg/text/select-x-list-with-tspans-1-expected.png:
  • platform/mac/svg/text/select-x-list-with-tspans-2-expected.png:
  • platform/mac/svg/text/select-x-list-with-tspans-3-expected.png:
  • platform/mac/svg/text/select-x-list-with-tspans-4-expected.png:
  • platform/mac/svg/text/selection-doubleclick-expected.png:
  • platform/mac/svg/text/selection-tripleclick-expected.png:
  • platform/mac/svg/text/text-align-01-b-expected.checksum:
  • platform/mac/svg/text/text-align-01-b-expected.png:
  • platform/mac/svg/text/text-align-05-b-expected.checksum:
  • platform/mac/svg/text/text-align-05-b-expected.png:
  • platform/mac/svg/text/text-gradient-positioning-expected.png:
  • platform/mac/svg/text/text-hkern-expected.png:
  • platform/mac/svg/text/text-hkern-on-vertical-text-expected.png:
  • platform/mac/svg/text/text-spacing-01-b-expected.png:
  • platform/mac/svg/text/text-text-01-b-expected.png:
  • platform/mac/svg/text/text-vkern-expected.png:
  • platform/mac/svg/text/text-vkern-on-horizontal-text-expected.png:
  • platform/mac/svg/text/textPathBoundsBug-expected.png:
  • platform/mac/svg/webarchive/svg-script-subresouces-expected.png:
  • platform/mac/svg/zoom/page/absolute-sized-document-no-scrollbars-expected.png:
  • platform/mac/svg/zoom/page/absolute-sized-document-scrollbars-expected.png:
  • platform/mac/svg/zoom/page/relative-sized-document-scrollbars-expected.png:
  • platform/mac/svg/zoom/page/zoom-hixie-mixed-008-expected.checksum:
  • platform/mac/svg/zoom/page/zoom-hixie-mixed-008-expected.png:
  • platform/mac/svg/zoom/page/zoom-hixie-mixed-009-expected.png:
  • platform/mac/svg/zoom/page/zoom-hixie-rendering-model-004-expected.png:
  • platform/mac/svg/zoom/page/zoom-mask-with-percentages-expected.checksum:
  • platform/mac/svg/zoom/page/zoom-mask-with-percentages-expected.png:
  • platform/mac/svg/zoom/page/zoom-svg-float-border-padding-expected.png:
  • platform/mac/svg/zoom/text/absolute-sized-document-no-scrollbars-expected.png:
  • platform/mac/svg/zoom/text/absolute-sized-document-scrollbars-expected.png:
  • platform/mac/svg/zoom/text/relative-sized-document-scrollbars-expected.png:
  • platform/mac/svg/zoom/text/zoom-foreignObject-expected.png:
  • platform/mac/svg/zoom/text/zoom-hixie-mixed-008-expected.checksum:
  • platform/mac/svg/zoom/text/zoom-hixie-mixed-008-expected.png:
  • platform/mac/svg/zoom/text/zoom-hixie-mixed-009-expected.png:
  • platform/mac/svg/zoom/text/zoom-hixie-rendering-model-004-expected.png:
  • platform/mac/svg/zoom/text/zoom-svg-float-border-padding-expected.png:
  • svg/custom/glyph-setting-d-attribute-expected.png:
  • svg/custom/text-zoom-expected.png:
  • svg/custom/use-clipped-transform-expected.png:
  • svg/in-html/by-reference-expected.png:
12:31 AM Changeset in webkit [69562] by Csaba Osztrogonác
  • 4 edits in trunk/LayoutTests

Unreviewed. Update Qt specific expected files after r69553.

  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt/http/tests/security/cross-frame-access-get-expected.txt:

Oct 11, 2010:

11:17 PM Changeset in webkit [69561] by hamaji@chromium.org
  • 5 edits in trunk/WebKit/win

2010-10-11 Shinichiro Hamaji <​hamaji@chromium.org>

Attempt to fix windows build failure.

Remove WebIconFetcher from WebKit and IconFetcher from WebCore
​https://bugs.webkit.org/show_bug.cgi?id=47523

  • Interfaces/IWebFramePrivate.idl: s/unused1/unused2/
  • Interfaces/WebKit.idl: Touched.
  • WebFrame.cpp: s/unused1/unused2/ (WebFrame::unused2):
  • WebFrame.h: s/unused1/unused2/
9:08 PM Changeset in webkit [69560] by dumi@chromium.org
  • 5 edits
    2 adds in trunk

2010-10-11 Eric Uhrhane <​ericu@chromium.org>

Reviewed by Dumitru Daniliuc.

FileWriter should hold a reference to a Blob during write
​https://bugs.webkit.org/show_bug.cgi?id=47318

Without this reference, the Blob might get garbage-collected from JS
before the write has completed, which would be quite unintuitive to the
user. I just grab a RefPtr to the Blob at write(), then clear it when
we're done.

  • fileapi/FileWriter.cpp: (WebCore::FileWriter::stop): (WebCore::FileWriter::write): (WebCore::FileWriter::didWrite): (WebCore::FileWriter::didFail):
  • fileapi/FileWriter.h:

2010-10-11 Eric Uhrhane <​ericu@chromium.org>

Reviewed by Dumitru Daniliuc.

FileWriter should hold a reference to a Blob during write
​https://bugs.webkit.org/show_bug.cgi?id=47318

Added the first FileWriter test to cover this.
Problem #1: it's not a deterministic problem; the test might or might
not catch the error, but at least it won't ever trigger a false
positive.
Problem #2: no platform fully implements FileWriter yet, so this test
must start out completely supressed. All non-chromium platforms
already skip all filesystem tests, so I'm only adding a suppression in
chromium.

  • fast/filesystem/file-writer-gc-blob-expected.txt: Added.
  • fast/filesystem/file-writer-gc-blob.html: Added.
  • platform/chromium/test_expectations.txt:
7:42 PM Changeset in webkit [69559] by beidson@apple.com
  • 5 edits in trunk/WebKit2

Address some of Darin's review feedback in ​https://bugs.webkit.org/show_bug.cgi?id=47354
that wasn't left till after my original commit.

Reviewed by Darin Adler of the past.

  • UIProcess/API/C/WKPage.cpp:

(WKPageCopySessionState): Nuke the temporary variable.

  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebPageProxy.h: Fix up function declarations.


  • UIProcess/cf/WebPageProxyCF.cpp:

(WebKit::WebPageProxy::sessionStateData): Use sizeof(UInt32) instead of 4.
(WebKit::WebPageProxy::restoreFromSessionStateData): Ditto.

7:41 PM Changeset in webkit [69558] by Martin Robinson
  • 8 edits in trunk/LayoutTests

2010-10-11 Martin Robinson <​mrobinson@igalia.com>

Rebaseline some failing GTK+ tests.

  • platform/gtk/editing/selection/move-past-trailing-space-expected.txt:
  • platform/gtk/fast/css/shadow-multiple-expected.txt:
  • platform/gtk/fast/text/shadow-no-blur-expected.txt:
7:25 PM Changeset in webkit [69557] by kinuko@chromium.org
  • 2 edits in trunk/LayoutTests

2010-10-11 Kinuko Yasuda <​kinuko@chromium.org>

Unreviewed, updating test_expectations.txt for passing tests.

  • platform/chromium/test_expectations.txt:
7:19 PM Changeset in webkit [69556] by beidson@apple.com
  • 2 edits in trunk/WebKit2

Build fix for Windows in ​https://bugs.webkit.org/show_bug.cgi?id=47354

Reviewed by BUILD FIX.

  • UIProcess/cf/WebPageProxyCF.cpp:

(WebKit::WebPageProxy::sessionStateData): Change to use CF APIs that exist on Windows.
(WebKit::WebPageProxy::restoreFromSessionStateData): Ditto.

7:18 PM Changeset in webkit [69555] by ajwong@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed. More expectation changes for green canary.

More expectations resulting from r69517.

  • platform/chromium/test_expectations.txt:
7:17 PM Changeset in webkit [69554] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

2010-10-11 James Kozianski <​koz@chromium.org>

Reviewed by Simon Fraser.

Remove superflous comments from a layout test.
​https://bugs.webkit.org/show_bug.cgi?id=47521

  • fast/css-generated-content/malformed-url.html:
7:12 PM Changeset in webkit [69553] by msaboff@apple.com
  • 18 edits
    2 adds in trunk

2010-10-11 Michael Saboff <​msaboff@apple.com>

Reviewed by Darin Adler.

Added and changed tests to verify that DOMWindow objects are
create with appropriate constructors and that those constructors
are not callable directly.
​https://bugs.webkit.org/show_bug.cgi?id=47422

  • fast/dom/Window/window-constructor-expected.txt: Added.
  • fast/dom/Window/window-constructor.html: Added.
  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/Window/window-property-descriptors-expected.txt:
  • fast/dom/prototype-inheritance-2-expected.txt:
  • fast/dom/script-tests/constructors-cached.js:
  • fast/dom/wrapper-classes-expected.txt:
  • http/tests/security/cross-frame-access-get-expected.txt:
  • http/tests/security/cross-frame-access-get.html:
  • http/tests/security/cross-frame-access-put.html:
  • inspector/console-dir-global-expected.txt:
  • java/lc3/JSObject/ToJSObject-001-expected.txt:
  • java/lc3/JSObject/ToObject-001-expected.txt:

2010-10-11 Michael Saboff <​msaboff@apple.com>

Reviewed by Darin Adler.

Changed DOMWindow to have a constructor. Updated the code generator
to add security checks to the constructors if CheckDomainSecurity is
set. Also changed the constructor generation code to use
globalObject->prototype() for DOMWindow object prototypes instead
of "self".
​https://bugs.webkit.org/show_bug.cgi?id=47422

Test: fast/dom/Window/window-constructor.html

  • bindings/scripts/CodeGeneratorJS.pm:
  • page/DOMWindow.idl:
7:04 PM Changeset in webkit [69552] by tony@chromium.org
  • 2 edits in trunk/WebKitTools

2010-10-11 Tony Chang <​tony@chromium.org>

Reviewed by Adam Barth.

change the order of mrobinson's email addresses so bugs.webkit.org suggests the right one
​https://bugs.webkit.org/show_bug.cgi?id=47513

bugs.webkit.org suggests ​mrobinson@igalia.com as an autocomplete,
which doesn't actually work.

  • Scripts/webkitpy/common/config/committers.py:
6:52 PM Changeset in webkit [69551] by commit-queue@webkit.org
  • 15 edits
    2 copies in trunk

2010-10-11 Daniel Cheng <​dcheng@chromium.org>

Reviewed by Tony Chang.

[chromium] Prepare Clipboard/DragData for transition to new drag-and-drop interface.
​https://bugs.webkit.org/show_bug.cgi?id=44992

In order to allow a graceful transition, ChromiumDataObject has been
reimplemented as a wrapper around the three different types of data
objects that the Chrome port uses:

  1. ChromiumDataObjectLegacy -- this is the original ChromiumDataObject. All the data that ClipboardChromium/DragDataChromium can potentially use is copied over, regardless of whether or not it is needed.
  2. ReadableDataObject -- used for dragging in and pasting into WebKit. For efficiency, it caches an optimistic list of types it believes it can handle. When getData() is called, a browser IPC is called to retrieve the appropriate data.
  3. WritableDataObject -- similar to ChromiumDataObjectLegacy in that it buffers all data when dragging out of WebKit or copying/cutting. Unfortunately, there is a difference between dragging out and copying/cutting--on drag outs, the data is buffered and flushed out when startDrag() is called. For copy/cut, any calls to setData() result in a browser IPC right away, so calls to setData() in one copy/cut event are not atomic.

Copy and paste has been changed to use the new data objects. Dragging
out uses the legacy data object, and dragging in now has two potential
entry points--one using the legacy data object, and one using
ReadableDataObject. Once Chromium transitions to using the new drag-in
interface, the old interface will be removed.

This change is covered by existing tests.

  • WebCore.gypi:
  • editing/chromium/EditorChromium.cpp: (WebCore::Editor::newGeneralClipboard):
  • page/chromium/EventHandlerChromium.cpp: (WebCore::EventHandler::createDraggingClipboard):
  • platform/chromium/ChromiumDataObject.cpp: (WebCore::ChromiumDataObject::ChromiumDataObject): (WebCore::ChromiumDataObject::create): (WebCore::ChromiumDataObject::createReadable): (WebCore::ChromiumDataObject::createWritable): (WebCore::ChromiumDataObject::clearData): (WebCore::ChromiumDataObject::clearAll): (WebCore::ChromiumDataObject::clearAllExceptFiles): (WebCore::ChromiumDataObject::hasData): (WebCore::ChromiumDataObject::types): (WebCore::ChromiumDataObject::getData): (WebCore::ChromiumDataObject::setData): (WebCore::ChromiumDataObject::urlTitle): (WebCore::ChromiumDataObject::setUrlTitle): (WebCore::ChromiumDataObject::htmlBaseUrl): (WebCore::ChromiumDataObject::setHtmlBaseUrl): (WebCore::ChromiumDataObject::containsFilenames): (WebCore::ChromiumDataObject::filenames): (WebCore::ChromiumDataObject::setFilenames): (WebCore::ChromiumDataObject::fileExtension): (WebCore::ChromiumDataObject::setFileExtension): (WebCore::ChromiumDataObject::fileContentFilename): (WebCore::ChromiumDataObject::setFileContentFilename): (WebCore::ChromiumDataObject::fileContent): (WebCore::ChromiumDataObject::setFileContent):
  • platform/chromium/ChromiumDataObject.h:
  • platform/chromium/ChromiumDataObjectLegacy.cpp: Copied from ChromiumDataObject.cpp (WebCore::ChromiumDataObjectLegacy::clearData): (WebCore::ChromiumDataObjectLegacy::clearAll): (WebCore::ChromiumDataObjectLegacy::clearAllExceptFiles): (WebCore::ChromiumDataObjectLegacy::hasData): (WebCore::ChromiumDataObjectLegacy::types): (WebCore::ChromiumDataObjectLegacy::getData): (WebCore::ChromiumDataObjectLegacy::setData): (WebCore::ChromiumDataObjectLegacy::ChromiumDataObjectLegacy):
  • platform/chromium/ChromiumDataObjectLegacy.h: Copied from ChromiumDataObject.h (WebCore::ChromiumDataObjectLegacy::create): (WebCore::ChromiumDataObjectLegacy::copy): (WebCore::ChromiumDataObjectLegacy::urlTitle): (WebCore::ChromiumDataObjectLegacy::setUrlTitle): (WebCore::ChromiumDataObjectLegacy::htmlBaseUrl): (WebCore::ChromiumDataObjectLegacy::setHtmlBaseUrl): (WebCore::ChromiumDataObjectLegacy::containsFilenames): (WebCore::ChromiumDataObjectLegacy::filenames): (WebCore::ChromiumDataObjectLegacy::setFilenames): (WebCore::ChromiumDataObjectLegacy::fileExtension): (WebCore::ChromiumDataObjectLegacy::setFileExtension): (WebCore::ChromiumDataObjectLegacy::fileContentFilename): (WebCore::ChromiumDataObjectLegacy::setFileContentFilename): (WebCore::ChromiumDataObjectLegacy::fileContent): (WebCore::ChromiumDataObjectLegacy::setFileContent):
  • platform/chromium/ClipboardChromium.cpp: (WebCore::ClipboardChromium::create):
  • platform/chromium/ClipboardChromium.h:
  • platform/chromium/ReadableDataObject.cpp: (WebCore::ReadableDataObject::getData):
  • platform/chromium/WritableDataObject.cpp: (WebCore::WritableDataObject::setData):

2010-10-11 Daniel Cheng <​dcheng@chromium.org>

Reviewed by Tony Chang.

[chromium] Prepare Clipboard/DragData for transition to new drag-and-drop interface.
​https://bugs.webkit.org/show_bug.cgi?id=44992

Add a new entry point for drag in to allow a graceful transition
from the legacy drag and drop model, where all data is copied in at the
beginning of a drag, to a model where data is retrieved on demand via
IPCs. The rationale for this is when we begin supporting arbitrary MIME
types in dataTransfer, we don't want to be copying aribtrary amounts of
data over for each start drag IPC.

  • public/WebView.h:
  • src/WebDragData.cpp: (WebKit::WebDragData::initialize): Use the legacy data object. (WebKit::WebDragData::ensureMutable): Change the if to an ASSERT.
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::dragTargetDragEnterNew): New entry point.
  • src/WebViewImpl.h:
6:39 PM Changeset in webkit [69550] by commit-queue@webkit.org
  • 5 edits in trunk

2010-10-11 Prasad Tammana <​prasadt@chromium.org>

Reviewed by Dmitry Titov.

Added support for showModalDialog on chromium port.

Implement showModalDialog for Layout tests for chromium port
​https://bugs.webkit.org/show_bug.cgi?id=46759

  • platform/chromium/drt_expectations.txt: Removed show-modal-dialog tests.

2010-10-11 Prasad Tammana <​prasadt@chromium.org>

Reviewed by Dmitry Titov.

Added support for showModalDialog on chromium port.

Implement showModalDialog for Layout tests for chromium port
​https://bugs.webkit.org/show_bug.cgi?id=46759

  • DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::closeWidgetSoon): Quit current message loop if in a modal loop. (WebViewHost::runModal): Start a nested message loop and remember that. (WebViewHost::WebViewHost): Initialize m_inModalLoop.
  • DumpRenderTree/chromium/WebViewHost.h: Add m_inModalLoop.
6:31 PM Changeset in webkit [69549] by andersca@apple.com
  • 19 edits
    8 deletes in trunk

Remove WebIconFetcher from WebKit and IconFetcher from WebCore
​https://bugs.webkit.org/show_bug.cgi?id=47523

Reviewed by Darin Adler.

WebCore:

Remove all traces of the WebCore IconFetcher class. It's SPI that nobody uses.

  • GNUmakefile.am:
  • WebCore.exp.in:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • loader/icon/IconFetcher.cpp: Removed.
  • loader/icon/IconFetcher.h: Removed.

WebKit:

Remove all traces of the WebKit WebIconFetcher class. It's SPI that nobody uses.

  • WebKit.xcodeproj/project.pbxproj:

WebKit/mac:

Remove all traces of the WebKit WebIconFetcher class. It's SPI that nobody uses.

  • Misc/WebIconFetcher.h: Removed.
  • Misc/WebIconFetcher.mm: Removed.
  • Misc/WebIconFetcherInternal.h: Removed.
  • WebView/WebFrame.mm:
  • WebView/WebFramePrivate.h:

WebKit/win:

Remove all traces of the WebKit WebIconFetcher class. It's SPI that nobody uses.

  • Interfaces/IWebFramePrivate.idl:
  • Interfaces/IWebIconFetcher.idl: Removed.
  • Interfaces/WebKit.idl:
  • WebFrame.cpp:

(WebFrame::unused1):

  • WebFrame.h:
  • WebIconFetcher.cpp: Removed.
  • WebIconFetcher.h: Removed.
  • WebKit.vcproj/Interfaces.vcproj:
  • WebKit.vcproj/WebKit.vcproj:
6:21 PM Changeset in webkit [69548] by commit-queue@webkit.org
  • 3 edits in trunk/WebCore

2010-10-11 Jia Pu <​jpu@apple.com>

Reviewed by Adele Peterson.

Should commit pending autocorrection before next round of text checking.
​https://bugs.webkit.org/show_bug.cgi?id=46986
<rdar://problem/8424535>

  1. Apply pending autocorrection before calling markAllMisspellingsAndBadGrammarInRanges().
  2. Remove unneccessary calls to dismissCorrectionPanel(), since the panel is dismissed when selection changes, which occurs after every typing command.
  • editing/Editor.cpp: (WebCore::Editor::markMisspellingsAfterTypingToPosition): Apply pending autocorrection. (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): Store current correction replacement in m_correctionReplacementString. (WebCore::Editor::startCorrectionPanelTimer): Remove call to dismissCorrectionPanel().
  • editing/Editor.h: Add m_correctionReplacementString to store proposed autocorrection string.
6:05 PM Changeset in webkit [69547] by ajwong@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed. Build fix.

Marking linux expectations as failues missed during the SVG sweep.

  • platform/chromium/test_expectations.txt:
5:58 PM Changeset in webkit [69546] by oliver@apple.com
  • 2 edits in trunk/WebCore

2010-10-11 Oliver Hunt <​oliver@apple.com>

Reviewed by Adam Barth.

Make fast/canvas/webgl/glsl-conformance pass again
​https://bugs.webkit.org/show_bug.cgi?id=47525

Remove incorrect call to glGetShaderiv, so it is only
called in the case where we don't have our own simulated
log.

  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp: (WebCore::GraphicsContext3D::getShaderInfoLog):
5:53 PM Changeset in webkit [69545] by weinig@apple.com
  • 7 edits in trunk

WebCore: Add WebKit2 equivalents for setValueForUser and setAutoFilled
<rdar://problem/8475934>
​https://bugs.webkit.org/show_bug.cgi?id=47524

Reviewed by Anders Carlsson.

  • WebCore.exp.in: Add needed export.

WebKit2: Add WebKit2 equivalents for setValueForUser and setAutofilled
<rdar://problem/8475934>
​https://bugs.webkit.org/show_bug.cgi?id=47524

Reviewed by Anders Carlsson.

  • WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.cpp:

(WKBundleNodeHandleSetHTMLInputElementValueForUser):
(WKBundleNodeHandleSetHTMLInputElementAutofilled):

  • WebProcess/InjectedBundle/API/c/WKBundleNodeHandlePrivate.h:
  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:

(WebKit::InjectedBundleNodeHandle::setHTMLInputElementValueForUser):
(WebKit::InjectedBundleNodeHandle::setHTMLInputElementAutofilled):

  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h:
5:34 PM Changeset in webkit [69544] by bweinstein@apple.com
  • 2 edits in trunk/WebKit2

Windows build fix. Add a needed include.

  • UIProcess/cf/WebPageProxyCF.cpp:
5:33 PM Changeset in webkit [69543] by ajwong@chromium.org
  • 993 edits
    524 adds
    1 delete in trunk/LayoutTests

[chromium] Unreviewed. Build Fix.

Submit 1506 new rebaselines due to changes for all elipse/circle
drawing code caused by r69517. Changelog compressed to list the
number of files changed per directory.

  • LayoutTests/platform/chromium-linux/fast/blockflow/: 2 changed.
  • LayoutTests/platform/chromium-linux/svg/W3C-SVG-1.1/: 96 changed.
  • LayoutTests/platform/chromium-linux/svg/batik/paints/: 4 changed.
  • LayoutTests/platform/chromium-linux/svg/batik/text/: 4 changed.
  • LayoutTests/platform/chromium-linux/svg/clip-path/: 34 changed.
  • LayoutTests/platform/chromium-linux/svg/css/: 6 changed.
  • LayoutTests/platform/chromium-linux/svg/custom/: 104 changed.
  • LayoutTests/platform/chromium-linux/svg/dynamic-updates/: 176 changed.
  • LayoutTests/platform/chromium-linux/svg/hixie/cascade/: 4 changed.
  • LayoutTests/platform/chromium-linux/svg/hixie/error/: 2 changed.
  • LayoutTests/platform/chromium-linux/svg/hixie/links/: 4 changed.
  • LayoutTests/platform/chromium-linux/svg/hixie/mixed/: 12 changed.
  • LayoutTests/platform/chromium-linux/svg/hixie/perf/: 2 changed.
  • LayoutTests/platform/chromium-linux/svg/hixie/rendering-model/: 4 changed.
  • LayoutTests/platform/chromium-linux/svg/hixie/shapes/path/: 2 changed.
  • LayoutTests/platform/chromium-linux/svg/hixie/transform/: 2 changed.
  • LayoutTests/platform/chromium-linux/svg/in-html/: 2 changed.
  • LayoutTests/platform/chromium-linux/svg/text/: 4 changed.
  • LayoutTests/platform/chromium-linux/svg/zoom/page/: 6 changed.
  • LayoutTests/platform/chromium-linux/svg/zoom/text/: 4 changed.
  • LayoutTests/platform/chromium-mac/fast/backgrounds/: 6 changed.
  • LayoutTests/platform/chromium-mac/fast/blockflow/: 2 changed.
  • LayoutTests/platform/chromium-mac/fast/images/: 2 changed.
  • LayoutTests/platform/chromium-mac/svg/W3C-SVG-1.1/: 101 changed.
  • LayoutTests/platform/chromium-mac/svg/batik/masking/: 2 changed.
  • LayoutTests/platform/chromium-mac/svg/batik/paints/: 6 changed.
  • LayoutTests/platform/chromium-mac/svg/batik/text/: 4 changed.
  • LayoutTests/platform/chromium-mac/svg/carto.net/: 2 changed.
  • LayoutTests/platform/chromium-mac/svg/clip-path/: 50 changed.
  • LayoutTests/platform/chromium-mac/svg/css/: 6 changed.
  • LayoutTests/platform/chromium-mac/svg/custom/: 118 changed.
  • LayoutTests/platform/chromium-mac/svg/dynamic-updates/: 184 changed.
  • LayoutTests/platform/chromium-mac/svg/hixie/cascade/: 4 changed.
  • LayoutTests/platform/chromium-mac/svg/hixie/error/: 2 changed.
  • LayoutTests/platform/chromium-mac/svg/hixie/links/: 4 changed.
  • LayoutTests/platform/chromium-mac/svg/hixie/mixed/: 12 changed.
  • LayoutTests/platform/chromium-mac/svg/hixie/perf/: 2 changed.
  • LayoutTests/platform/chromium-mac/svg/hixie/rendering-model/: 4 changed.
  • LayoutTests/platform/chromium-mac/svg/hixie/shapes/path/: 2 changed.
  • LayoutTests/platform/chromium-mac/svg/hixie/transform/: 2 changed.
  • LayoutTests/platform/chromium-mac/svg/in-html/: 2 changed.
  • LayoutTests/platform/chromium-mac/svg/text/: 6 changed.
  • LayoutTests/platform/chromium-mac/svg/zoom/page/: 6 changed.
  • LayoutTests/platform/chromium-mac/svg/zoom/text/: 4 changed.
  • LayoutTests/platform/chromium-win-xp/fast/blockflow/: 1 changed.
  • LayoutTests/platform/chromium-win-xp/svg/batik/text/: 2 changed.
  • LayoutTests/platform/chromium-win-xp/svg/custom/: 1 changed.
  • LayoutTests/platform/chromium-win/fast/blockflow/: 2 changed.
  • LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/: 107 changed.
  • LayoutTests/platform/chromium-win/svg/batik/masking/: 1 changed.
  • LayoutTests/platform/chromium-win/svg/batik/paints/: 4 changed.
  • LayoutTests/platform/chromium-win/svg/batik/text/: 2 changed.
  • LayoutTests/platform/chromium-win/svg/clip-path/: 34 changed.
  • LayoutTests/platform/chromium-win/svg/css/: 6 changed.
  • LayoutTests/platform/chromium-win/svg/custom/: 114 changed.
  • LayoutTests/platform/chromium-win/svg/dynamic-updates/: 176 changed.
  • LayoutTests/platform/chromium-win/svg/hixie/cascade/: 4 changed.
  • LayoutTests/platform/chromium-win/svg/hixie/error/: 2 changed.
  • LayoutTests/platform/chromium-win/svg/hixie/links/: 4 changed.
  • LayoutTests/platform/chromium-win/svg/hixie/mixed/: 12 changed.
  • LayoutTests/platform/chromium-win/svg/hixie/perf/: 2 changed.
  • LayoutTests/platform/chromium-win/svg/hixie/rendering-model/: 4 changed.
  • LayoutTests/platform/chromium-win/svg/hixie/shapes/path/: 2 changed.
  • LayoutTests/platform/chromium-win/svg/hixie/transform/: 2 changed.
  • LayoutTests/platform/chromium-win/svg/in-html/: 2 changed.
  • LayoutTests/platform/chromium-win/svg/text/: 4 changed.
  • LayoutTests/platform/chromium-win/svg/zoom/page/: 7 changed.
  • LayoutTests/platform/chromium-win/svg/zoom/text/: 4 changed.
  • LayoutTests/platform/chromium/: 1 changed.
  • platform/chromium/test_expectations.txt:
5:28 PM Changeset in webkit [69542] by bweinstein@apple.com
  • 3 edits in trunk/WebKit2

Windows build fix. Wrap calls to CFSTR in parentheses.

  • UIProcess/cf/WebBackForwardListCF.cpp:
  • UIProcess/cf/WebPageProxyCF.cpp:
5:19 PM Changeset in webkit [69541] by jorlow@chromium.org
  • 6 edits
    1 add in trunk/WebKit/chromium

2010-10-11 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Nate Chapin.

[Chromium] Add plumbing for synchronous indexedDB exceptions
​https://bugs.webkit.org/show_bug.cgi?id=47511

Add a WebExceptionCode file (already run by fishd) and add versions of
each applicable method that take such a parameter. A follow up patch
will be posted with the meat.

  • WebKit.gyp:
  • public/WebExceptionCode.h: Added.
  • public/WebIDBCursor.h: (WebKit::WebIDBCursor::update): (WebKit::WebIDBCursor::continueFunction): (WebKit::WebIDBCursor::remove):
  • public/WebIDBDatabase.h: (WebKit::WebIDBDatabase::objectStore): (WebKit::WebIDBDatabase::createObjectStore): (WebKit::WebIDBDatabase::removeObjectStore): (WebKit::WebIDBDatabase::setVersion): (WebKit::WebIDBDatabase::transaction):
  • public/WebIDBIndex.h: (WebKit::WebIDBIndex::openObjectCursor): (WebKit::WebIDBIndex::openKeyCursor): (WebKit::WebIDBIndex::getObject): (WebKit::WebIDBIndex::getKey):
  • public/WebIDBObjectStore.h: (WebKit::WebIDBObjectStore::get): (WebKit::WebIDBObjectStore::put): (WebKit::WebIDBObjectStore::remove): (WebKit::WebIDBObjectStore::createIndex): (WebKit::WebIDBObjectStore::index): (WebKit::WebIDBObjectStore::removeIndex): (WebKit::WebIDBObjectStore::openCursor):
5:16 PM Changeset in webkit [69540] by andreip@google.com
  • 32 edits in trunk

2010-10-11 Andrei Popescu <​andreip@google.com>

Reviewed by Jeremy Orlow.

The names of IndexedDB-specific attributes of DOMWindow should be prefixed with 'webkit'.
​https://bugs.webkit.org/show_bug.cgi?id=47508

  • storage/indexeddb/basics-expected.txt:
  • storage/indexeddb/basics.html:
  • storage/indexeddb/constants-expected.txt:
  • storage/indexeddb/constants.html:
  • storage/indexeddb/database-basics-expected.txt:
  • storage/indexeddb/database-basics.html:
  • storage/indexeddb/database-quota-expected.txt:
  • storage/indexeddb/database-quota.html:
  • storage/indexeddb/index-basics-expected.txt:
  • storage/indexeddb/index-basics.html:
  • storage/indexeddb/index-cursor-expected.txt:
  • storage/indexeddb/index-cursor.html:
  • storage/indexeddb/keyrange-expected.txt:
  • storage/indexeddb/keyrange.html:
  • storage/indexeddb/objectstore-basics-expected.txt:
  • storage/indexeddb/objectstore-basics.html:
  • storage/indexeddb/objectstore-cursor-expected.txt:
  • storage/indexeddb/objectstore-cursor.html:
  • storage/indexeddb/objectstore-removeobjectstore-expected.txt:
  • storage/indexeddb/objectstore-removeobjectstore.html:
  • storage/indexeddb/open-cursor-expected.txt:
  • storage/indexeddb/open-cursor.html:
  • storage/indexeddb/transaction-basics-expected.txt:
  • storage/indexeddb/transaction-basics.html:

2010-10-11 Andrei Popescu <​andreip@google.com>

Reviewed by Jeremy Orlow.

The names of IndexedDB-specific attributes of DOMWindow should be prefixed with 'webkit'.
​https://bugs.webkit.org/show_bug.cgi?id=47508

  • bindings/generic/RuntimeEnabledFeatures.h: (WebCore::RuntimeEnabledFeatures::setWebkitIndexedDBEnabled): (WebCore::RuntimeEnabledFeatures::webkitIndexedDBEnabled): (WebCore::RuntimeEnabledFeatures::webkitIDBCursorEnabled): (WebCore::RuntimeEnabledFeatures::webkitIDBDatabaseEnabled): (WebCore::RuntimeEnabledFeatures::webkitIDBDatabaseErrorEnabled): (WebCore::RuntimeEnabledFeatures::webkitIDBDatabaseExceptionEnabled): (WebCore::RuntimeEnabledFeatures::webkitIDBErrorEventEnabled): (WebCore::RuntimeEnabledFeatures::webkitIDBEventEnabled): (WebCore::RuntimeEnabledFeatures::webkitIDBFactoryEnabled): (WebCore::RuntimeEnabledFeatures::webkitIDBIndexEnabled): (WebCore::RuntimeEnabledFeatures::webkitIDBKeyRangeEnabled): (WebCore::RuntimeEnabledFeatures::webkitIDBObjectStoreEnabled): (WebCore::RuntimeEnabledFeatures::webkitIDBRequestEnabled): (WebCore::RuntimeEnabledFeatures::webkitIDBSuccessEventEnabled): (WebCore::RuntimeEnabledFeatures::webkitIDBTransactionEnabled):
  • page/DOMWindow.cpp: (WebCore::DOMWindow::webkitIndexedDB):
  • page/DOMWindow.h:
  • page/DOMWindow.idl:

2010-10-11 Andrei Popescu <​andreip@google.com>

Reviewed by Jeremy Orlow.

The names of IndexedDB-specific attributes of DOMWindow should be prefixed with 'webkit'.
​https://bugs.webkit.org/show_bug.cgi?id=47508

  • src/WebRuntimeFeatures.cpp: (WebKit::WebRuntimeFeatures::enableIndexedDatabase): (WebKit::WebRuntimeFeatures::isIndexedDatabaseEnabled):
5:05 PM Changeset in webkit [69539] by weinig@apple.com
  • 11 edits
    1 add in trunk

Add ability to convert from a JSObjectRef back to a WKBundleNodeHandleRef
​https://bugs.webkit.org/show_bug.cgi?id=47509

Reviewed by Anders Carlsson.

WebCore:

  • WebCore.exp.in: Export toNode.

WebKit2:

Add SPI to convert a JSObjectRef to a WKBundleNodeHandleRef.

  • DerivedSources.pro:
  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.cpp:

(WKBundleNodeHandleCreate):

  • WebProcess/InjectedBundle/API/c/WKBundleNodeHandlePrivate.h: Added.
  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:

(WebKit::InjectedBundleNodeHandle::getOrCreate):

  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h:
  • win/WebKit2.vcproj:
  • win/WebKit2Generated.make:
5:01 PM Changeset in webkit [69538] by beidson@apple.com
  • 9 edits
    3 adds in trunk/WebKit2

<rdar://problem/8262202> and ​https://bugs.webkit.org/show_bug.cgi?id=47354
Need WKPage API for serializing and restoring a page's state

Reviewed by Darin Adler and Sam Weinig.

  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:
  • WebKit2Prefix.h: Add DEFINE_STATIC_GETTER convenience.
  • UIProcess/API/C/WKPage.cpp:

(WKPageGetSessionHistoryURLValueType):
(WKPageCopySessionState): Change to use a filter function to allow the API client to decide what

types of things get serialized as session state. For now it only filters based on URL in
session history entries.

(WKPageRestoreFromSessionState):

  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebBackForwardList.h:

(WebKit::WebBackForwardList::restoredCurrentURL):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::sessionStateData): Leave stubs for non-CF platform builds.
(WebKit::WebPageProxy::restoreFromSessionStateData): Ditto.

  • UIProcess/WebPageProxy.h:
  • UIProcess/cf: Added.
  • UIProcess/cf/WebBackForwardListCF.cpp: Added.

(WebKit::WebBackForwardList::createCFDictionaryRepresentation): Store back/forward list info CF property list style.
(WebKit::WebBackForwardList::restoreFromCFDictionaryRepresentation): Restore from that data - but for now we don't

actually put the back/forward list back into place and instead only remember the current URL.

  • UIProcess/cf/WebPageProxyCF.cpp: Added.

(WebKit::WebPageProxy::sessionStateData): Create the sessions state date CF property list style, plus a version header.
(WebKit::WebPageProxy::restoreFromSessionStateData): Restore from that property list style session state data.

5:01 PM Changeset in webkit [69537] by tony@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-10-11 Tony Chang <​tony@chromium.org>

Unreviewed, roll chromium DEPS to pick up Dave's fix for
scrollbar painting. This will be needed by an upcoming patch.

  • DEPS:
4:45 PM Changeset in webkit [69536] by abarth@webkit.org
  • 14 edits in trunk/LayoutTests

2010-10-11 Adam Barth <​abarth@webkit.org>

Rebaseline SVG expectations.
Rubber-stamped by Mr. kling.

  • platform/mac/svg/W3C-SVG-1.1/animate-elem-21-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-29-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/shapes-circle-01-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/shapes-ellipse-01-t-expected.txt:
  • platform/mac/svg/batik/masking/maskRegions-expected.txt:
  • platform/mac/svg/custom/gradient-stroke-width-expected.txt:
  • platform/mac/svg/custom/linking-a-03-b-preserveAspectRatio-expected.txt:
  • platform/mac/svg/custom/linking-a-03-b-transform-expected.txt:
  • platform/mac/svg/custom/linking-a-03-b-viewTarget-expected.txt:
  • platform/mac/svg/custom/linking-a-03-b-zoomAndPan-expected.txt:
  • platform/mac/svg/custom/stroked-pattern-expected.txt:
  • platform/mac/svg/zoom/page/zoom-mask-with-percentages-expected.txt:
4:30 PM Changeset in webkit [69535] by Patrick Gansterer
  • 2 edits in trunk/JavaScriptCore

2010-10-11 Patrick Gansterer <Patrick Gansterer>

Unreviewed.

Clang build fix after r69472.
​https://bugs.webkit.org/show_bug.cgi?id=46523

  • wtf/text/StringHash.h:
3:42 PM Changeset in webkit [69534] by kinuko@chromium.org
  • 2 edits in trunk/LayoutTests

2010-10-11 Kinuko Yasuda <​kinuko@chromium.org>

Unreviewed, updating test_expectations for a passing test.

  • platform/chromium/test_expectations.txt:
3:16 PM Changeset in webkit [69533] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

Undo last minute change to 32bit build.

3:15 PM Changeset in webkit [69532] by Adam Roben
  • 3 edits in trunk/WebKit2

Implement SharedMemory on Windows

This makes visited links be colored correctly.

Fixes <​http://webkit.org/b/47499> <rdar://problem/8422725>.

Reviewed by Anders Carlsson.

  • Platform/SharedMemory.h: Add Windows-specific members to

SharedMemory and SharedMemory::Handle.

  • Platform/win/SharedMemoryWin.cpp:

(WebKit::SharedMemory::Handle::Handle): Initialize our members.
(WebKit::SharedMemory::Handle::~Handle): Close our HANDLE if we have
one.
(WebKit::SharedMemory::Handle::encode): Encode our size, HANDLE, and
PID. Null out our HANDLE member, as it is now the receiving process's
responsibility to close the HANDLE.
(WebKit::SharedMemory::Handle::decode): Copy the handle from the
sending process into the receiving process and close the HANDLE the
sending process gave us.
(WebKit::SharedMemory::create): Map some memory and store it in a new
SharedMemory object.
(WebKit::accessRights): Helper function to convert a
SharedMemory::Protection to a file-mapping access right.
(WebKit::SharedMemory::create): Map the memory represented by the
Handle, and adopt the HANDLE from it.
(WebKit::SharedMemory::~SharedMemory): Clean up our memory mapping.
(WebKit::SharedMemory::createHandle): Give the Handle a copy of our
HANDLE with the specified protection.

3:14 PM Changeset in webkit [69531] by Adam Roben
  • 2 edits in trunk/WebKit2

Make it possible to restart a RunLoop::Timer on Windows

Fixes <​http://webkit.org/b/47505> RunLoop::Timer only ever fires once
on Windows

Reviewed by Anders Carlsson.

  • Platform/win/RunLoopWin.cpp:

(RunLoop::TimerBase::timerFired): Remove non-repeating timers from the
set of active timers when they fire, just like we do when stopping
them manually.

3:12 PM Changeset in webkit [69530] by Martin Robinson
  • 8 edits in trunk

2010-10-11 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Tony Chang.

[GTK] editing/pasteboard/dataTransfer-setData-getData.html fails on GTK+
​https://bugs.webkit.org/show_bug.cgi?id=47244

Unskip the freshly passing test and add a baseline which has a PASS for all
tests.

  • platform/gtk/Skipped: Unskip passing test.
  • platform/gtk/editing/pasteboard/dataTransfer-setData-getData-expected.txt:

2010-10-11 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Tony Chang.

[GTK] editing/pasteboard/dataTransfer-setData-getData.html fails on GTK+
​https://bugs.webkit.org/show_bug.cgi?id=47244

Store the URI list as a String in DataObjectGtk, so that non-URI elements
are preserved when getData(...) is called. This necessitates some other
changes, including adding a m_filenames member to DataObjectGtk to store
filenames extracted during setURIList(...). The logic in getData(...) has
also changed to set success = true no matter what to match the spec. A
followup patch will remove this parameter completely for all platforms.

  • platform/gtk/ClipboardGtk.cpp: (WebCore::ClipboardGtk::getData): Always succeed to match the HTML5 spec and Firefox. Simply return the uriList string from the DataObject instead of reconstructing it from a vector of KURLs. (WebCore::ClipboardGtk::setData): The DataObject now accepts a string for the uriList parameter. (WebCore::ClipboardGtk::types): Predicate the "Files" member on DataObjectGtk::hasFilenames(). (WebCore::ClipboardGtk::files): Update to reflect the change from DataObjectGtk::files() to DataObjectGtk::filenames().
  • platform/gtk/DataObjectGtk.cpp: (WebCore::DataObjectGtk::setURIList): Expanded this setter to find the first valid URL to use as the m_url member and also extract a list of filenames from the URI list. (WebCore::DataObjectGtk::setURL): Updated to reflect changes to m_uriList. (WebCore::DataObjectGtk::clear): Updated to reflect changes to m_uriList and also leave a comment explaining why we do not clear filenames here.
  • platform/gtk/DataObjectGtk.h: (WebCore::DataObjectGtk::url): This implementation is now a simple getter. (WebCore::DataObjectGtk::uriList): Ditto. (WebCore::DataObjectGtk::filenames): Added. (WebCore::DataObjectGtk::hasURL): Now a simple check. (WebCore::DataObjectGtk::hasFilenames): Added. (WebCore::DataObjectGtk::clearURIList): Simple setter. (WebCore::DataObjectGtk::clearURL): Ditto.
  • platform/gtk/DragDataGtk.cpp: (WebCore::DragData::containsFiles): Updated to access DataObjectGtk::hasFilenames(). (WebCore::DragData::asFilenames): Updated to access DataObjectGtk::filenames().
  • platform/gtk/PasteboardHelper.cpp: (WebCore::PasteboardHelper::getClipboardContents): Use the uriList as a string now. (WebCore::PasteboardHelper::fillSelectionData): Ditto. (WebCore::PasteboardHelper::fillDataObjectFromDropData): Ditto.
3:10 PM Changeset in webkit [69529] by jamesr@google.com
  • 2 edits in trunk/WebCore

2010-10-11 James Robinson <​jamesr@chromium.org>

Reviewed by Kenneth Russell.

[chromium] DRT crash in fast/canvas tests w/accel 2D canvas due to NULL DrawingBuffer
​https://bugs.webkit.org/show_bug.cgi?id=47241

Avoid initializing accelerated graphics objects on CanvasRenderingContext2D
if there is no drawingContext associated with the canvas.

Test: fast/canvas/access-zero-sized-canvas.html

fast/canvas/canvas-skia-excessive-size.html
fast/canvas/toDataURL-noData.html

with --accelerated-compositing and --accelerated-2d-canvas

  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::CanvasRenderingContext2D): (WebCore::CanvasRenderingContext2D::reset):
2:56 PM Changeset in webkit [69528] by Martin Robinson
  • 9 edits
    6 adds in trunk

2010-10-11 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] Cleanup font selection code for the Freetype backend
​https://bugs.webkit.org/show_bug.cgi?id=47503

Unskip some tests that lacked baselines before (they used cursive and fantasy font
families) and regenerate some correct baselines for the synthetic oblique test.

  • platform/gtk/Skipped: Update the skipped list.
  • platform/gtk/fonts/cursive-expected.txt: Added.
  • platform/gtk/fonts/default-expected.txt: Added.
  • platform/gtk/fonts/fantasy-expected.txt: Added.
  • platform/gtk/fonts/fontconfig-synthetic-oblique-expected.checksum:
  • platform/gtk/fonts/fontconfig-synthetic-oblique-expected.png:
  • platform/gtk/fonts/monospace-expected.txt: Added.
  • platform/gtk/fonts/sans-serif-expected.txt: Added.
  • platform/gtk/fonts/serif-expected.txt: Added.

2010-10-11 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] Cleanup font selection code for the Freetype backend
​https://bugs.webkit.org/show_bug.cgi?id=47503

Do some miscellaneous cleanup work in the Freetype font font selection backend.

  • platform/graphics/cairo/FontCacheFreeType.cpp: (WebCore::getFamilyNameStringFromFontDescriptionAndFamily): Modified this method to return a WebCore String. (WebCore::FontCache::createFontPlatformData): Do a bit of cleanup in this method: properly handle cursive and fantasy as fallback-like fonts. Instead of using raw CStrings do string comparisons using WebCore Strings. Remove a large block comment that originated from a Apache-licensed file.

2010-10-11 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] Cleanup font selection code for the Freetype backend
​https://bugs.webkit.org/show_bug.cgi?id=47503

Update DRT to set values for the cursive and fantasy font families, so
that we can generate consistent results for tests that use these families.
Add some missing information to fonts.conf.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues): Always set the fantasy and cursive font family names.
  • DumpRenderTree/gtk/fonts/fonts.conf: Add aliases for cursive and fantasy fonts to our default serif font. Eventually we may want to import or require some "real" fonts, but this should at least ensure consistent rendering during test runs. Also add aliases for some other commonly used fonts in tests (Arial and Lucida Grande). Finally, add a missing oblique specification for DejaVu Serif, which was resulting in some incorrect baselines for the synthetic oblique test.
2:32 PM Changeset in webkit [69527] by ajwong@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed. Temporary patch for SVG changes from r69517.

Update test expectations to fail all SVG tests with different output
after r69517's changes. Rebaselines coming later.

  • platform/chromium/test_expectations.txt:
2:20 PM Changeset in webkit [69526] by Martin Robinson
  • 2 edits in trunk/WebCore

2010-10-11 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] Buttons activated with the keyboard should be painted as clicked
​https://bugs.webkit.org/show_bug.cgi?id=18364

When a button is pressed, force it into the hovered state as far as the
Mozilla theme drawing code is concerned. This bug also seems to be an
issue for Firefox. When we switch away from the Mozilla theme drawing
code this work-around should no longer be necessary.

No new tests. I was not able to generate a pixel test for this issue. It
seems that our DRT does not have the necessary infrastructure to generate a
pixel dump while a button is in the pressed state.

  • platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::paintRenderObject):
2:15 PM Changeset in webkit [69525] by bweinstein@apple.com
  • 2 edits in trunk/JavaScriptCore

Build fix for Windows. Add a necessary export from r69516.

2:08 PM Changeset in webkit [69524] by jberlin@webkit.org
  • 10 edits in trunk

Add Private API for creating a WebKit2 WebSerializedScriptValue from the internal
representation of a WebKit1 WebSerializedJSValue.
​https://bugs.webkit.org/show_bug.cgi?id=47439

Reviewed by Darin Adler.

WebKit/mac:

  • WebView/WebSerializedJSValue.mm:

(-[WebSerializedJSValue internalRepresentation]):

  • WebView/WebSerializedJSValuePrivate.h:

WebKit/win:

  • Interfaces/IWebSerializedJSValuePrivate.idl:

Because it is taking a void parameter, getInternalRepresentation must be declared [local].

  • WebSerializedJSValue.cpp:

(WebSerializedJSValue::getInternalRepresentation):

  • WebSerializedJSValue.h:

WebKit2:

  • Shared/API/c/WKSerializedScriptValue.cpp:

(WKSerializedScriptValueCreateWithInternalRepresentation):
Use the existing WebSerializedScriptValue constructor that takes a pointer to the internal
representation (a WebCore::SerializedScriptValue).

  • Shared/API/c/WKSerializedScriptValuePrivate.h:
1:58 PM Changeset in webkit [69523] by jianli@chromium.org
  • 19 edits in trunk/WebCore

Unreviewed. Build fix.

  • bindings/js/JSArrayBufferCustom.cpp:
  • bindings/js/JSArrayBufferViewCustom.cpp:
  • bindings/js/JSFloat32ArrayCustom.cpp:
  • bindings/js/JSInt16ArrayCustom.cpp:
  • bindings/js/JSInt32ArrayCustom.cpp:
  • bindings/js/JSInt8ArrayCustom.cpp:
  • bindings/js/JSUint16ArrayCustom.cpp:
  • bindings/js/JSUint32ArrayCustom.cpp:
  • bindings/js/JSUint8ArrayCustom.cpp:
  • bindings/v8/custom/V8ArrayBufferCustom.cpp:
  • bindings/v8/custom/V8ArrayBufferViewCustom.cpp:
  • bindings/v8/custom/V8Float32ArrayCustom.cpp:
  • bindings/v8/custom/V8Int16ArrayCustom.cpp:
  • bindings/v8/custom/V8Int32ArrayCustom.cpp:
  • bindings/v8/custom/V8Int8ArrayCustom.cpp:
  • bindings/v8/custom/V8Uint16ArrayCustom.cpp:
  • bindings/v8/custom/V8Uint32ArrayCustom.cpp:
  • bindings/v8/custom/V8Uint8ArrayCustom.cpp:
1:28 PM Changeset in webkit [69522] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

Fix interpreter build -- was broken by incorrect merge.

1:20 PM Changeset in webkit [69521] by bfulgham@webkit.org
  • 3 edits in trunk/WebCore

Unreviewed WinCairo build fixes.

  • platform/network/curl/ResourceResponse.h: Correct forward declaration

for CFURLResponseRef.

  • rendering/RenderMediaControls.h: Add ENABLE(VIDEO) guard to new

header file to avoid build failure on non-VIDEO builds.

1:16 PM Changeset in webkit [69520] by jianli@chromium.org
  • 19 edits in trunk/WebCore

Add File API feature guard to all typed array files
​https://bugs.webkit.org/show_bug.cgi?id=47437

Reviewed by Adam Barth.

Since we're going to add ArrayBuffer support to FileReader and BlobBuilder,
we need to update all type array files to include File API feature guard
in addition to the existing 3D_CANVAS guard. When ArrayBuffer is used in
XMLHttpRequest, we will then remove all the guards. This is per the
discussion on webkit-dev mailing list:
​https://lists.webkit.org/pipermail/webkit-dev/2010-October/014716.html

  • html/canvas/ArrayBuffer.cpp:
  • html/canvas/ArrayBuffer.idl:
  • html/canvas/ArrayBufferView.cpp:
  • html/canvas/ArrayBufferView.idl:
  • html/canvas/Float32Array.cpp:
  • html/canvas/Float32Array.idl:
  • html/canvas/Int16Array.cpp:
  • html/canvas/Int16Array.idl:
  • html/canvas/Int32Array.cpp:
  • html/canvas/Int32Array.idl:
  • html/canvas/Int8Array.cpp:
  • html/canvas/Int8Array.idl:
  • html/canvas/Uint16Array.cpp:
  • html/canvas/Uint16Array.idl:
  • html/canvas/Uint32Array.cpp:
  • html/canvas/Uint32Array.idl:
  • html/canvas/Uint8Array.cpp:
  • html/canvas/Uint8Array.idl:
12:50 PM Changeset in webkit [69519] by andreas.kling@nokia.com
  • 2 edits in trunk/WebCore

2010-10-11 Andreas Kling <​kling@webkit.org>

Build fix (implicit float conversion in Path.cpp)

  • platform/graphics/Path.cpp:
12:45 PM Changeset in webkit [69518] by Girish Ramakrishnan
  • 3 edits in trunk/WebCore

[Qt] Refactor Plugin X Pixmap painting code to a separate function

Reviewed by Kenneth Rohde Christiansen.

The refactored function will be used for rendering by the Accelerated
Composition enabled graphics layer.

​https://bugs.webkit.org/show_bug.cgi?id=35524

  • plugins/PluginView.h:
  • plugins/qt/PluginViewQt.cpp:

(WebCore::PluginView::paintUsingXPixmap):
(WebCore::PluginView::paint):

12:19 PM Changeset in webkit [69517] by andreas.kling@nokia.com
  • 35 edits in trunk/WebCore

2010-10-11 Andreas Kling <​kling@webkit.org>

Reviewed by Dirk Schulze.

SVG: Remove "create" methods and use port-specific "add" counterparts
​https://bugs.webkit.org/show_bug.cgi?id=46052

Circles and ellipses will be significantly faster on platforms that
implement Path::addEllipse() in a sane fashion.

Also, a lot of Path copying has been factored out by changing functions
that would return Paths to take Path& arguments instead (toPathData, toClipPath)

  • mathml/RenderMathMLRoot.cpp: (WebCore::RenderMathMLRoot::paint):
  • mathml/RenderMathMLSquareRoot.cpp: (WebCore::RenderMathMLSquareRoot::paint):
  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::addRoundedRectClip): (WebCore::GraphicsContext::clipOutRoundedRect):
  • platform/graphics/Path.cpp: (WebCore::pathLengthApplierFunction): (WebCore::Path::addRoundedRect):
  • platform/graphics/Path.h:
  • platform/graphics/cairo/ContextShadowCairo.cpp: (WebCore::ContextShadow::drawRectShadowWithoutTiling): (WebCore::ContextShadow::drawRectShadow):
  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::drawFocusRing): (WebCore::GraphicsContext::drawTiledShadow): (WebCore::GraphicsContext::fillRoundedRect):
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::fillRoundedRect):
  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::fillRoundedRect):
  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintBorder): (WebCore::RenderBoxModelObject::paintBoxShadow):
  • rendering/RenderEmbeddedObject.cpp: (WebCore::RenderEmbeddedObject::getReplacementTextGeometry):
  • rendering/RenderSVGResourceClipper.cpp: (WebCore::RenderSVGResourceClipper::pathOnlyClipping):
  • rendering/svg/RenderSVGPath.cpp: (WebCore::RenderSVGPath::layout):
  • rendering/svg/RenderSVGTextPath.cpp: (WebCore::RenderSVGTextPath::layoutPath):
  • rendering/svg/SVGInlineTextBox.cpp: (WebCore::SVGInlineTextBox::paintDecorationWithStyle):
  • svg/SVGAnimateMotionElement.cpp: (WebCore::SVGAnimateMotionElement::animationPath):
  • svg/SVGCircleElement.cpp: (WebCore::SVGCircleElement::toPathData):
  • svg/SVGCircleElement.h:
  • svg/SVGEllipseElement.cpp: (WebCore::SVGEllipseElement::toPathData):
  • svg/SVGEllipseElement.h:
  • svg/SVGLineElement.cpp: (WebCore::SVGLineElement::toPathData):
  • svg/SVGLineElement.h:
  • svg/SVGPathElement.cpp: (WebCore::SVGPathElement::getTotalLength): (WebCore::SVGPathElement::getPointAtLength): (WebCore::SVGPathElement::toPathData):
  • svg/SVGPathElement.h:
  • svg/SVGPolygonElement.cpp: (WebCore::SVGPolygonElement::toPathData):
  • svg/SVGPolygonElement.h:
  • svg/SVGPolylineElement.cpp: (WebCore::SVGPolylineElement::toPathData):
  • svg/SVGPolylineElement.h:
  • svg/SVGRectElement.cpp: (WebCore::SVGRectElement::toPathData):
  • svg/SVGRectElement.h:
  • svg/SVGStyledTransformableElement.cpp: (WebCore::SVGStyledTransformableElement::toClipPath):
  • svg/SVGStyledTransformableElement.h: (WebCore::SVGStyledTransformableElement::toPathData):
  • svg/SVGUseElement.cpp: (WebCore::SVGUseElement::toClipPath):
  • svg/SVGUseElement.h:
12:12 PM Changeset in webkit [69516] by oliver@apple.com
  • 60 edits
    5 adds in trunk

2010-10-01 Oliver Hunt <​oliver@apple.com>

Reviewed by Gavin Barraclough.

[ES5] Implement strict mode
​https://bugs.webkit.org/show_bug.cgi?id=10701

Initial strict mode implementation. This is the simplest
implementation that could possibly work and adds (hopefully)
all of the restrictions required by strict mode. There are
a number of inefficiencies, especially in the handling of
arguments and eval as smart implementations would make this
patch more complicated.

The SyntaxChecker AST builder has become somewhat more complex
as strict mode does require more parse tree information to
validate the syntax.

Summary of major changes to the parser:

  • We track when we enter strict mode (this may come as a surprise)
  • Strict mode actually requires a degree of AST knowledge to validate so the SyntaxChecker now produces values that can be used to distinguish "node" types.
  • We now track variables that are written to. We do this to statically identify writes to global properties that don't exist and abort at that point. This should actually make it possible to optimise some other cases in the future but for now it's purely for validity checking. Currently writes are only tracked in strict mode code.
  • Labels are now tracked as it is now a syntax error to jump to a label that does not exist (or to use break, continue, or return in a context where they would be invalid).

Runtime changes:

  • In order to get correct hanlding of the Arguments object all strict mode functions that reference arguments create and tearoff the arguments object on entry. This is not strictly necessary but was the least work necessary to get the correct behaviour.
  • PutPropertySlot now tracks whether it is being used for a strict mode write, and if so Object::put will throw when a write can't be completed.
  • StrictEvalActivation was added as an "activation" object for strict mode eval (so that strict eval does not introduce new variables into the containing scope).
  • CMakeLists.txt:
  • GNUmakefile.am:
  • JavaScriptCore.exp:
  • JavaScriptCore.pro:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::dump): (JSC::CodeBlock::CodeBlock): (JSC::CodeBlock::reparseForExceptionInfoIfNecessary):
  • bytecode/CodeBlock.h: (JSC::CodeBlock::isStrictMode):
  • bytecode/EvalCodeCache.h: (JSC::EvalCodeCache::get):
  • bytecode/Opcode.h:
  • bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::BytecodeGenerator): (JSC::BytecodeGenerator::createArgumentsIfNecessary): (JSC::BytecodeGenerator::emitReturn):
  • bytecompiler/BytecodeGenerator.h: (JSC::BytecodeGenerator::isStrictMode): (JSC::BytecodeGenerator::makeFunction):
  • debugger/Debugger.cpp: (JSC::evaluateInGlobalCallFrame):
  • debugger/DebuggerCallFrame.cpp: (JSC::DebuggerCallFrame::evaluate):
  • interpreter/Interpreter.cpp: (JSC::Interpreter::callEval): (JSC::Interpreter::unwindCallFrame): (JSC::Interpreter::execute): (JSC::Interpreter::privateExecute):
  • jit/JIT.cpp: (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompileSlowCases):
  • jit/JIT.h:
  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_get_pnames): (JSC::JIT::emit_op_convert_this_strict): (JSC::JIT::emitSlow_op_convert_this_strict):
  • jit/JITOpcodes32_64.cpp: (JSC::JIT::emit_op_get_pnames):
  • jit/JITStubs.cpp: (JSC::DEFINE_STUB_FUNCTION):
  • jit/JITStubs.h:
  • parser/ASTBuilder.h: (JSC::ASTBuilder::createFunctionBody): (JSC::ASTBuilder::isResolve):
  • parser/JSParser.cpp: (JSC::JSParser::next): (JSC::JSParser::startLoop): (JSC::JSParser::endLoop): (JSC::JSParser::startSwitch): (JSC::JSParser::endSwitch): (JSC::JSParser::setStrictMode): (JSC::JSParser::strictMode): (JSC::JSParser::isValidStrictMode): (JSC::JSParser::declareParameter): (JSC::JSParser::breakIsValid): (JSC::JSParser::pushLabel): (JSC::JSParser::popLabel): (JSC::JSParser::hasLabel): (JSC::JSParser::DepthManager::DepthManager): (JSC::JSParser::DepthManager::~DepthManager): (JSC::JSParser::Scope::Scope): (JSC::JSParser::Scope::startSwitch): (JSC::JSParser::Scope::endSwitch): (JSC::JSParser::Scope::startLoop): (JSC::JSParser::Scope::endLoop): (JSC::JSParser::Scope::inLoop): (JSC::JSParser::Scope::breakIsValid): (JSC::JSParser::Scope::pushLabel): (JSC::JSParser::Scope::popLabel): (JSC::JSParser::Scope::hasLabel): (JSC::JSParser::Scope::isFunction): (JSC::JSParser::Scope::declareVariable): (JSC::JSParser::Scope::declareWrite): (JSC::JSParser::Scope::deleteProperty): (JSC::JSParser::Scope::declareParameter): (JSC::JSParser::Scope::setNeedsFullActivation): (JSC::JSParser::Scope::collectFreeVariables): (JSC::JSParser::Scope::getUncapturedWrittenVariables): (JSC::JSParser::Scope::getDeletedVariables): (JSC::JSParser::Scope::setStrictMode): (JSC::JSParser::Scope::strictMode): (JSC::JSParser::Scope::isValidStrictMode): (JSC::JSParser::pushScope): (JSC::JSParser::popScope): (JSC::JSParser::declareVariable): (JSC::JSParser::declareWrite): (JSC::JSParser::deleteProperty): (JSC::jsParse): (JSC::JSParser::JSParser): (JSC::JSParser::parseProgram): (JSC::JSParser::parseSourceElements): (JSC::JSParser::parseDoWhileStatement): (JSC::JSParser::parseWhileStatement): (JSC::JSParser::parseVarDeclarationList): (JSC::JSParser::parseConstDeclarationList): (JSC::JSParser::parseForStatement): (JSC::JSParser::parseBreakStatement): (JSC::JSParser::parseContinueStatement): (JSC::JSParser::parseReturnStatement): (JSC::JSParser::parseWithStatement): (JSC::JSParser::parseSwitchStatement): (JSC::JSParser::parseSwitchClauses): (JSC::JSParser::parseSwitchDefaultClause): (JSC::JSParser::parseTryStatement): (JSC::JSParser::parseBlockStatement): (JSC::JSParser::parseStatement): (JSC::JSParser::parseFormalParameters): (JSC::JSParser::parseFunctionBody): (JSC::JSParser::parseFunctionInfo): (JSC::JSParser::parseFunctionDeclaration): (JSC::JSParser::parseExpressionOrLabelStatement): (JSC::JSParser::parseIfStatement): (JSC::JSParser::parseExpression): (JSC::JSParser::parseAssignmentExpression): (JSC::JSParser::parseConditionalExpression): (JSC::JSParser::parseBinaryExpression): (JSC::JSParser::parseStrictObjectLiteral): (JSC::JSParser::parsePrimaryExpression): (JSC::JSParser::parseMemberExpression): (JSC::JSParser::parseUnaryExpression):
  • parser/JSParser.h:
  • parser/Lexer.cpp: (JSC::Lexer::parseString): (JSC::Lexer::lex):
  • parser/Lexer.h: (JSC::Lexer::isReparsing):
  • parser/Nodes.cpp: (JSC::ScopeNode::ScopeNode): (JSC::FunctionBodyNode::FunctionBodyNode): (JSC::FunctionBodyNode::create):
  • parser/Nodes.h: (JSC::ScopeNode::isStrictMode):
  • parser/Parser.cpp: (JSC::Parser::parse):
  • parser/Parser.h: (JSC::Parser::parse):
  • parser/SyntaxChecker.h: (JSC::SyntaxChecker::SyntaxChecker): (JSC::SyntaxChecker::makeFunctionCallNode): (JSC::SyntaxChecker::appendToComma): (JSC::SyntaxChecker::createCommaExpr): (JSC::SyntaxChecker::makeAssignNode): (JSC::SyntaxChecker::makePrefixNode): (JSC::SyntaxChecker::makePostfixNode): (JSC::SyntaxChecker::makeTypeOfNode): (JSC::SyntaxChecker::makeDeleteNode): (JSC::SyntaxChecker::makeNegateNode): (JSC::SyntaxChecker::makeBitwiseNotNode): (JSC::SyntaxChecker::createLogicalNot): (JSC::SyntaxChecker::createUnaryPlus): (JSC::SyntaxChecker::createVoid): (JSC::SyntaxChecker::thisExpr): (JSC::SyntaxChecker::createResolve): (JSC::SyntaxChecker::createObjectLiteral): (JSC::SyntaxChecker::createArray): (JSC::SyntaxChecker::createNumberExpr): (JSC::SyntaxChecker::createString): (JSC::SyntaxChecker::createBoolean): (JSC::SyntaxChecker::createNull): (JSC::SyntaxChecker::createBracketAccess): (JSC::SyntaxChecker::createDotAccess): (JSC::SyntaxChecker::createRegex): (JSC::SyntaxChecker::createNewExpr): (JSC::SyntaxChecker::createConditionalExpr): (JSC::SyntaxChecker::createAssignResolve): (JSC::SyntaxChecker::createFunctionExpr): (JSC::SyntaxChecker::createFunctionBody): (JSC::SyntaxChecker::appendBinaryExpressionInfo): (JSC::SyntaxChecker::operatorStackPop):
  • runtime/Arguments.cpp: (JSC::Arguments::createStrictModeCallerIfNecessary): (JSC::Arguments::createStrictModeCalleeIfNecessary): (JSC::Arguments::getOwnPropertySlot): (JSC::Arguments::getOwnPropertyDescriptor): (JSC::Arguments::put): (JSC::Arguments::deleteProperty):
  • runtime/Arguments.h: (JSC::Arguments::Arguments):
  • runtime/CommonIdentifiers.cpp: (JSC::CommonIdentifiers::CommonIdentifiers):
  • runtime/CommonIdentifiers.h:
  • runtime/Error.cpp: (JSC::StrictModeTypeErrorFunction::StrictModeTypeErrorFunction): (JSC::StrictModeTypeErrorFunction::constructThrowTypeError): (JSC::StrictModeTypeErrorFunction::getConstructData): (JSC::StrictModeTypeErrorFunction::callThrowTypeError): (JSC::StrictModeTypeErrorFunction::getCallData): (JSC::createTypeErrorFunction):
  • runtime/Error.h:
  • runtime/Executable.cpp: (JSC::EvalExecutable::EvalExecutable): (JSC::ProgramExecutable::ProgramExecutable): (JSC::FunctionExecutable::FunctionExecutable): (JSC::EvalExecutable::compileInternal): (JSC::ProgramExecutable::checkSyntax): (JSC::ProgramExecutable::compileInternal): (JSC::FunctionExecutable::compileForCallInternal): (JSC::FunctionExecutable::compileForConstructInternal): (JSC::FunctionExecutable::reparseExceptionInfo): (JSC::EvalExecutable::reparseExceptionInfo): (JSC::FunctionExecutable::fromGlobalCode): (JSC::ProgramExecutable::reparseExceptionInfo):
  • runtime/Executable.h: (JSC::ScriptExecutable::ScriptExecutable): (JSC::ScriptExecutable::isStrictMode): (JSC::EvalExecutable::create): (JSC::FunctionExecutable::create):
  • runtime/JSActivation.cpp: (JSC::JSActivation::toStrictThisObject):
  • runtime/JSActivation.h:
  • runtime/JSFunction.cpp: (JSC::createDescriptorForThrowingProperty): (JSC::JSFunction::getOwnPropertySlot): (JSC::JSFunction::getOwnPropertyDescriptor): (JSC::JSFunction::put):
  • runtime/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData):
  • runtime/JSGlobalData.h:
  • runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::reset):
  • runtime/JSGlobalObject.h: (JSC::JSGlobalObject::internalFunctionStructure):
  • runtime/JSGlobalObjectFunctions.cpp: (JSC::globalFuncEval):
  • runtime/JSObject.cpp: (JSC::JSObject::put): (JSC::JSObject::toStrictThisObject): (JSC::throwTypeError):
  • runtime/JSObject.h: (JSC::JSObject::isStrictModeFunction): (JSC::JSObject::putDirectInternal): (JSC::JSObject::putDirect): (JSC::JSValue::putDirect): (JSC::JSValue::toStrictThisObject):
  • runtime/JSStaticScopeObject.cpp: (JSC::JSStaticScopeObject::toStrictThisObject):
  • runtime/JSStaticScopeObject.h:
  • runtime/JSValue.h:
  • runtime/JSZombie.h: (JSC::JSZombie::toStrictThisObject):
  • runtime/PutPropertySlot.h: (JSC::PutPropertySlot::PutPropertySlot): (JSC::PutPropertySlot::isStrictMode):
  • runtime/StrictEvalActivation.cpp: Added. (JSC::StrictEvalActivation::StrictEvalActivation): (JSC::StrictEvalActivation::deleteProperty): (JSC::StrictEvalActivation::toThisObject): (JSC::StrictEvalActivation::toStrictThisObject):
  • runtime/StrictEvalActivation.h: Added.

2010-10-01 Oliver Hunt <​oliver@apple.com>

Reviewed by Gavin Barraclough.

[ES5] Implement strict mode
​https://bugs.webkit.org/show_bug.cgi?id=10701

Tests for the many different behaviours we get in strict mode.

  • fast/js/basic-strict-mode-expected.txt: Added.
  • fast/js/basic-strict-mode.html: Added.
  • fast/js/script-tests/basic-strict-mode.js: Added. (testThis): (testGlobalAccess):

2010-10-01 Oliver Hunt <​oliver@apple.com>

Reviewed by Gavin Barraclough.

[ES5] Implement strict mode
​https://bugs.webkit.org/show_bug.cgi?id=10701

Test: fast/js/basic-strict-mode.html

Override toStrictThisObject on the domwindow so that
it correctly provides the shell object when used as this
in a strict mode function.

  • bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::toStrictThisObject):
  • bindings/js/JSDOMWindowBase.h:
12:09 PM Changeset in webkit [69515] by tonikitoo@webkit.org
  • 3 edits
    3 deletes in trunk/LayoutTests

2010-10-10 Antonio Gomes <​agomes@rim.com>

Reviewed by Andreas Kling.

Convert editing/selection/script-tests/click-in-padding-with-multiple-line-boxes.js to use LayoutTestController::setEditingBehavior
​https://bugs.webkit.org/show_bug.cgi?id=47472

Patch converts the editing/selection/click-in-padding-with-multiple-line-boxes.js to make use of the
LayoutTestController::setEditingBehavior machinery. That way, all platform specific editing behavior
code paths can be test in the same execution, and we make it possible to share the same
expected result file through all ports.

  • editing/selection/click-in-padding-with-multiple-line-boxes-expected.txt: Modified with resutls for all editing behaviors, i.e. mac and win.
  • editing/selection/script-tests/click-in-padding-with-multiple-line-boxes.js: ():
  • platform/mac/editing/selection/click-in-padding-with-multiple-line-boxes-expected.txt: Removed.
  • platform/qt/editing/selection/click-in-padding-with-multiple-line-boxes-expected.txt: Removed.
  • platform/win/editing/selection/click-in-padding-with-multiple-line-boxes-expected.txt: Removed.
12:03 PM Changeset in webkit [69514] by Joseph Pecoraro
  • 2 edits in trunk/WebCore

2010-10-11 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Eric Carlson.

CRASH at WebCore::HTMLSourceElement::scheduleErrorEvent
​https://bugs.webkit.org/show_bug.cgi?id=46777

Another case that could lead to an improper set of states between
m_currentNode and m_loadingState. Also added an ASSERT and early
return to prevent crashes if this case can still happen in other ways.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::prepareForLoad):
12:00 PM Changeset in webkit [69513] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2010-10-11 Ryosuke Niwa <​rniwa@webkit.org>

Unreviewed build fix.

Fixed design-mode-spellcheck-off.html so that it passes on platforms that do not support textInputController.

  • editing/spelling/design-mode-spellcheck-off.html:
11:38 AM Changeset in webkit [69512] by crogers@google.com
  • 43 edits
    2 adds in branches/audio/WebCore

audio branch: lots of cleanup for landing into trunk

  • HRTFPanner and EqualPowerPanner last cleanup before landing
  • HighPass2Filter and LowPass2Filter last cleanup before landing
  • AudioBasicProcessorNode, AudioPannerNode, BiquadDSPKernel, BiquadProcess, last cleanup before landing
  • lots of cleanup and thread safety work for AudioNodeInput and AudioNodeOutput
  • add AudioUtilities
  • general cleanup: AudioResampler, AudioBufferSourceNode, AudioGainNode, RealtimeAnalyser, RealtimeAnalyserNode
11:32 AM Changeset in webkit [69511] by mthole@apple.com
  • 9 edits in trunk

Rename WKCertificateInfoGetPeerCertificates() to WKCertificateInfoGetCertificateChain()
​https://bugs.webkit.org/show_bug.cgi?id=47495

Reviewed by Darin Adler.

WebKit2:

  • Shared/API/c/mac/WKCertificateInfoMac.h:

Renamed WKCertificateInfoGetPeerCertificates() to WKCertificateInfoGetCertificateChain()

  • Shared/API/c/mac/WKCertificateInfoMac.mm:

(WKCertificateInfoGetCertificateChain): Updated for name change.

  • Shared/mac/PlatformCertificateInfo.h:

(WebKit::PlatformCertificateInfo::certificateChain): Renamed from peerCertificates()

  • Shared/mac/PlatformCertificateInfo.mm:

(WebKit::PlatformCertificateInfo::PlatformCertificateInfo): Updated for name change.
(WebKit::PlatformCertificateInfo::encode): Ditto.
(WebKit::PlatformCertificateInfo::decode): Ditto.
(WebKit::PlatformCertificateInfo::dump): Ditto.

WebKitLibraries:

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
11:29 AM Changeset in webkit [69510] by kbalazs@webkit.org
  • 2 edits in trunk/WebKit2

2010-10-11 Balazs Kelemen <​kbalazs@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Issue a warning when an InjectedBundle can't be loaded.
​https://bugs.webkit.org/show_bug.cgi?id=47497

The original author of the patch is Jocelyn Turcotte <​jocelyn.turcotte@nokia.com>.

  • WebProcess/InjectedBundle/qt/InjectedBundleQt.cpp: (WebKit::InjectedBundle::load):
11:12 AM Changeset in webkit [69509] by rniwa@webkit.org
  • 20 edits
    2 adds in trunk

2010-10-11 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Darin Adler.

spellcheck="false" not respected in designMode
​https://bugs.webkit.org/show_bug.cgi?id=39978

The bug was caused by WebKit's setting focus to html element rather than body element in design mode.
Because we disable spell-check only if ancestor nodes of the focused element had spellcheck=false,
this caused us to ignore body element's spellcheck attribute.

Fixed the bug by overriding supportsFocus in HTMLBodyElement to make body element focusable
when the parent node of body elements (namely html element) is editable.

Test: editing/spelling/design-mode-spellcheck-off.html

  • html/HTMLBodyElement.cpp: (WebCore::HTMLBodyElement::supportsFocus): Added.
  • html/HTMLBodyElement.h:

2010-10-11 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Darin Adler.

spellcheck="false" not respected in designMode
​https://bugs.webkit.org/show_bug.cgi?id=39978

Added a test to ensure Webkit respects spellcheck=off on body element.
Rebaselined are due to our setting the focus to body element rather than html element in design mode.

  • editing/spelling/design-mode-spellcheck-off-expected.txt: Added.
  • editing/spelling/design-mode-spellcheck-off.html: Added.
  • editing/inserting/space-after-removeformat-expected.txt: Editing delegates change due to focus moving to body.
  • platform/chromium-win/editing/inserting/editable-html-element-expected.txt: Ditto.
  • platform/chromium-win/editing/selection/editable-html-element-expected.txt: Ditto.
  • platform/chromium-win/editing/selection/editable-links-expected.txt: Ditto.
  • platform/chromium-win/editing/selection/focus_editable_html-expected.txt: Ditto.
  • platform/chromium-win/editing/style/designmode-expected.txt: Ditto.
  • platform/mac/editing/inserting/editable-html-element-expected.txt: Ditto.
  • platform/mac/editing/selection/designmode-no-caret-expected.txt: Ditto.
  • platform/mac/editing/selection/editable-html-element-expected.txt: Ditto.
  • platform/mac/editing/selection/editable-links-expected.txt: Ditto.
  • platform/mac/editing/selection/focus_editable_html-expected.txt: Ditto.
  • platform/mac/editing/style/designmode-expected.txt: Ditto.
  • platform/qt/editing/inserting/editable-html-element-expected.txt: Ditto.
  • platform/qt/editing/selection/editable-html-element-expected.txt: Ditto.
  • platform/qt/editing/selection/focus_editable_html-expected.txt: Ditto.
  • platform/qt/editing/style/designmode-expected.txt: Ditto.
11:12 AM Changeset in webkit [69508] by weinig@apple.com
  • 11 edits in trunk/WebKit2

Rename transformToDeviceSpace to convertToDeviceSpace and
transformToUserSpace to convertToUserSpace at Simon's request.

Reviewed by Simon Fraser.

  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::convertToDeviceSpace):
(WebKit::PageClientImpl::convertToUserSpace):

  • UIProcess/API/mac/WKView.mm:

(-[WKView _convertToDeviceSpace:]):
(-[WKView _convertToUserSpace:]):

  • UIProcess/API/mac/WKViewInternal.h:
  • UIProcess/API/qt/qwkpage.cpp:

(QWKPagePrivate::convertToDeviceSpace):
(QWKPagePrivate::convertToUserSpace):

  • UIProcess/API/qt/qwkpage_p.h:
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::setWindowFrame):
(WebKit::WebPageProxy::getWindowFrame):

  • UIProcess/win/WebView.cpp:

(WebKit::WebView::convertToDeviceSpace):
(WebKit::WebView::convertToUserSpace):

  • UIProcess/win/WebView.h:
10:54 AM Changeset in webkit [69507] by oliver@apple.com
  • 2 edits in trunk/WebCore

Build fix -- I thought i had killed the prior commit in time to allow me to add this

10:44 AM Changeset in webkit [69506] by oliver@apple.com
  • 2 edits in trunk/WebCore

2010-10-11 Oliver Hunt <​oliver@apple.com>

Reviewed by Andreas Kling.

Incorrect handling of 0 length logs in GraphicsContext3DOpenGL.cpp
​https://bugs.webkit.org/show_bug.cgi?id=47494

Working on another patch I found that there was some screwy behaviour
when dealing with logs from GL. GL_INFO_LOG_LENGTH is defined as being
zero if there is no log message, but we did not check for that case and
simply perfomed a zero sized alloc and passed the resultant buffer to
glGetShaderInfoLog, etc. glGetShaderInfoLog would then write a null
terminator to the buffer, thus causing an overflow. This is obviously
not a problem in practice as allocations are at least 4 bytes long in
all common allocators, but it is still a bug.

I also removed some unnecessary null checks following calls to fastMalloc.

  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp: (WebCore::GraphicsContext3D::getProgramInfoLog): (WebCore::GraphicsContext3D::getShaderInfoLog):
10:27 AM Changeset in webkit [69505] by Nikolas Zimmermann
  • 13 edits in trunk/WebCore

2010-10-11 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Andreas Kling.

Kill Path::debugString()
​https://bugs.webkit.org/show_bug.cgi?id=47493

Remove the obsolete Path::debugString() method. DRT now dumps paths in a platform independant way.

  • platform/graphics/Path.h:
  • platform/graphics/cairo/PathCairo.cpp:
  • platform/graphics/cg/PathCG.cpp:
  • platform/graphics/haiku/PathHaiku.cpp:
  • platform/graphics/openvg/PathOpenVG.cpp:
  • platform/graphics/qt/PathQt.cpp:
  • platform/graphics/skia/PathSkia.cpp:
  • platform/graphics/wince/PathWinCE.cpp:
  • platform/graphics/wince/PlatformPathWinCE.cpp:
  • platform/graphics/wince/PlatformPathWinCE.h:
  • platform/graphics/wx/PathWx.cpp:
  • svg/SVGGlyphElement.h: (WebCore::SVGGlyphIdentifier::operator==):
10:13 AM Changeset in webkit [69504] by weinig@apple.com
  • 3 edits in trunk/WebKit2

Try to fix the Mac release build.

  • UIProcess/API/mac/WKView.mm:

(-[WKView _transformToDeviceSpace:]):
(-[WKView _transformToUserSpace:]):

  • UIProcess/API/mac/WKViewInternal.h:
10:07 AM Changeset in webkit [69503] by kbalazs@webkit.org
  • 2 edits in trunk/WebKit2

2010-10-11 Balazs Kelemen <​kbalazs@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

WebProcess ASSERTs with a null application cache dir creation parameter
​https://bugs.webkit.org/show_bug.cgi?id=47489

  • WebProcess/WebProcess.cpp: (WebKit::WebProcess::initializeWebProcess):
9:38 AM Changeset in webkit [69502] by kenneth@webkit.org
  • 2 edits in trunk/WebKit2

Unlink the files used for I/O mapped memory as soon as they are
created.

Reviewed by Andreas Kling.

  • Shared/qt/UpdateChunk.cpp:

(WebKit::mapMemory):
(WebKit::mapFile):

9:24 AM Changeset in webkit [69501] by inferno@chromium.org
  • 3 edits
    2 copies in branches/chromium/517

Merge 68819

BUG=56206
Review URL: ​http://codereview.chromium.org/3674004

9:21 AM Changeset in webkit [69500] by inferno@chromium.org
  • 1 edit
    4 copies in branches/chromium/517

Merge 69476

BUG=57200
Review URL: ​http://codereview.chromium.org/3662002

9:19 AM Changeset in webkit [69499] by inferno@chromium.org
  • 7 edits
    2 copies in branches/chromium/517

Merge 69043

BUG=55346
Review URL: ​http://codereview.chromium.org/3691003

9:14 AM Changeset in webkit [69498] by inferno@chromium.org
  • 2 edits
    2 copies in branches/chromium/517

Merge 69345

BUG=58008
Review URL: ​http://codereview.chromium.org/3692003

9:08 AM Changeset in webkit [69497] by kenneth@webkit.org
  • 2 edits in trunk/WebKit2

Build fix when using MeeGo Touch

Rubberstamped by Andreas Kling.

  • WebProcess/qt/WebProcessMainQt.cpp:
8:55 AM Changeset in webkit [69496] by kenneth@webkit.org
  • 2 edits in trunk/WebKit2

Use raster for the QtWebProcess.

Reviewed by Andreas Kling.

  • WebProcess/qt/WebProcessMainQt.cpp:

(WebKit::WebProcessMainQt):

8:24 AM Changeset in webkit [69495] by Martin Robinson
  • 3 edits
    2 adds in trunk

2010-10-11 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Search field icons should be centered vertically in the field
​https://bugs.webkit.org/show_bug.cgi?id=47441

Add a pixel dump result which tests the fix.

  • platform/gtk/fast/css/text-input-with-webkit-border-radius-expected.checksum: Added.
  • platform/gtk/fast/css/text-input-with-webkit-border-radius-expected.png: Added.

2010-10-11 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Search field icons should be centered vertically in the field
​https://bugs.webkit.org/show_bug.cgi?id=47441

Center search field icons vertically in the search field.

  • platform/gtk/RenderThemeGtk.cpp: (WebCore::centerRectVerticallyInParentInputElement): Added this helper. (WebCore::RenderThemeGtk::paintSearchFieldResultsDecoration): Center the search field icon by adjusting its drawing rect relative to the containing search field. (WebCore::RenderThemeGtk::paintSearchFieldCancelButton): Ditto.
8:18 AM Changeset in webkit [69494] by podivilov@chromium.org
  • 2 edits in trunk/WebCore

2010-10-11 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: fix event listener breakpoints sidebar pane style
​https://bugs.webkit.org/show_bug.cgi?id=47487

  • inspector/front-end/inspector.css: (.section .properties, .event-bar .event-properties): (.section.expanded .properties, .event-bar.expanded .event-properties): (.properties-tree): (.properties-tree li): (.properties-tree li.parent): (.properties-tree li.parent::before): (.properties-tree li.parent.expanded::before): (.properties-tree li .info): (.properties-tree ol, .stack-trace ol, ol.stack-trace): (.properties-tree ol.expanded, .stack-trace ol, ol.stack-trace): (ol.stack-trace): (.event-listener-breakpoints .event-category): (.event-listener-breakpoints.properties-tree .children li): (.event-listener-breakpoints .checkbox-elem): (.breakpoint-list .breakpoint-hit):
8:07 AM Changeset in webkit [69493] by andreas.kling@nokia.com
  • 2 edits in trunk/WebCore

2010-10-11 Andreas Kling <​kling@webkit.org>

Reviewed by Tor Arne Vestbø.

[Qt] Avoid QPainterPath::operator=(QPainterPath()) when possible

Same concept as <​http://trac.webkit.org/changeset/69462>, do nothing
when clearing an already empty QPainterPath. Avoids one delete+new.

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContextPlatformPrivate::clearCurrentPath): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::beginPath):
8:02 AM Changeset in webkit [69492] by kov@webkit.org
  • 3 edits in trunk/WebCore

2010-10-11 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Unreviewed. Remove unnecessary GTK+ and Pango includes.

  • platform/gtk/FileChooserGtk.cpp:
  • platform/gtk/Language.cpp:
7:43 AM Changeset in webkit [69491] by kenneth@webkit.org
  • 2 edits in trunk/WebKit2

Unreviewed win build fix.

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:
7:12 AM Changeset in webkit [69490] by kenneth@webkit.org
  • 15 edits in trunk/WebKit2

Adding Qt WebKit2 API for dealing with viewport meta info
​https://bugs.webkit.org/show_bug.cgi?id=47202

Reviewed by Sam Weinig.

Add new API for setting scale and layout viewport given the data
provided by the viewport meta tag.

Any Qt view components who wants to support this, will need to
compute the viewport attributes before first load using
viewportAttributesForSize(..), and then again everytime
the viewport attributes gets invalidates (loading a new page,
navigating page cache) or every time on of the browser
attributes change, such as when the device is rotates (which
changes the actual visible viewport). A signal
viewportChangeRequested() is provided for the former.

  • Shared/WebCoreArgumentCoders.h:
  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::setViewportArguments):

  • UIProcess/API/qt/qwkpage.cpp:

(QWKPagePrivate::setViewportArguments):
(QWKPage::ViewportAttributes::ViewportAttributes):
(QWKPage::ViewportAttributes::~ViewportAttributes):
(QWKPage::ViewportAttributes::operator=):
(QWKPage::viewportAttributesForSize):

  • UIProcess/API/qt/qwkpage.h:
  • UIProcess/API/qt/qwkpage_p.h:

(QtViewportAttributesPrivate::QtViewportAttributesPrivate):

  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didReceiveMessage):
(WebKit::WebPageProxy::didChangeViewportData):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/win/WebView.cpp:

(WebKit::WebView::setViewportArguments):

  • UIProcess/win/WebView.h:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::dispatchViewportDataDidChange):

  • WebProcess/WebCoreSupport/WebChromeClient.h:
6:56 AM WebKit Team edited by tonikitoo@webkit.org
(diff)
6:41 AM Changeset in webkit [69489] by tonikitoo@webkit.org
  • 3 edits
    3 deletes in trunk/LayoutTests

2010-10-10 Antonio Gomes <​agomes@rim.com>

Reviewed by Andreas Kling.

Convert editing/selection/script-tests/click-in-margins-inside-editable-div.js to use LayoutTestController::setEditingBeh avior
​https://bugs.webkit.org/show_bug.cgi?id=47471

Patch converts the editing/selection/click-in-margins-inside-editable-div to make use of the
LayoutTestController::setEditingBehavior machinery. That way, all platform specific editing behavior
code paths can be test in the same execution, and we make it possible to share the same
expected result file through all ports.

  • editing/selection/click-in-margins-inside-editable-div-expected.txt:
  • editing/selection/script-tests/click-in-margins-inside-editable-div.js: ():
  • platform/mac/editing/selection/click-in-margins-inside-editable-div-expected.txt: Removed.
  • platform/qt/editing/selection/click-in-margins-inside-editable-div-expected.txt: Removed.
  • platform/win/editing/selection/click-in-margins-inside-editable-div-expected.txt: Removed.
6:19 AM Changeset in webkit [69488] by Csaba Osztrogonác
  • 2 edits in trunk/WebKit2

2010-10-11 Csaba Osztrogonác <Csaba Osztrogonác>

Reviewed by Andreas Kling.

[Qt] WebKit2 build scripts are buggy
​https://bugs.webkit.org/show_bug.cgi?id=47377

Generated sources must depends on WebKit2/Scripts/webkit2/messages.py too.

  • DerivedSources.pro: Missing dependencies added.
5:36 AM Changeset in webkit [69487] by apavlov@chromium.org
  • 2 edits in trunk/LayoutTests

2010-10-11 Alexander Pavlov <​apavlov@chromium.org>

[Chromium] Unreviewed, build fix.

Disable fast/filesystem/op-remove.html for chromium-win.

  • platform/chromium/test_expectations.txt:
4:59 AM Changeset in webkit [69486] by apavlov@chromium.org
  • 5 edits in trunk/LayoutTests

2010-10-11 Alexander Pavlov <​apavlov@chromium.org>

[Chromium] Unreviewed, build fix.

Rebaseline svg/W3C-SVG-1.1-SE/filters-image-03-f for chromium-linux and chromium-mac.

  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.checksum:
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png:
4:21 AM Changeset in webkit [69485] by kinuko@chromium.org
  • 31 edits in trunk

2010-10-11 Kinuko Yasuda <​kinuko@google.com>

Reviewed by David Levin.

Support DirectoryEntry.removeRecursively for FileSystem API
​https://bugs.webkit.org/show_bug.cgi?id=47400

  • src/AsyncFileSystemChromium.cpp: (WebCore::AsyncFileSystemChromium::removeRecursively): Added.
  • src/AsyncFileSystemChromium.h:
  • src/WorkerAsyncFileSystemChromium.cpp: (WebCore::WorkerAsyncFileSystemChromium::removeRecursively): Added.
  • src/WorkerAsyncFileSystemChromium.h:
  • src/WorkerFileSystemCallbacksBridge.cpp: (WebKit::WorkerFileSystemCallbacksBridge::postRemoveRecursivelyToMainThread): Added. (WebKit::WorkerFileSystemCallbacksBridge::removeRecursivelyOnMainThread): Added.
  • src/WorkerFileSystemCallbacksBridge.h:

2010-10-11 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by David Levin.

Support DirectoryEntry.removeRecursively for FileSystem API
​https://bugs.webkit.org/show_bug.cgi?id=47400

Also disallows remove/removeRecursively on the root directory.

Test: fast/filesystem/op-remove.html

  • fileapi/DOMFileSystemBase.cpp: (WebCore::DOMFileSystemBase::removeRecursively): Added.
  • fileapi/DOMFileSystemBase.h:
  • fileapi/DirectoryEntry.cpp: (WebCore::DirectoryEntry::removeRecursively): Added.
  • fileapi/DirectoryEntry.h:
  • fileapi/DirectoryEntry.idl:
  • fileapi/DirectoryEntrySync.cpp: (WebCore::DirectoryEntrySync::removeRecursively): Added.
  • fileapi/DirectoryEntrySync.h:
  • fileapi/DirectoryEntrySync.idl:
  • platform/AsyncFileSystem.h:

2010-10-11 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by David Levin.

Support DirectoryEntry.removeRecursively for FileSystem API
​https://bugs.webkit.org/show_bug.cgi?id=47400

  • fast/filesystem/resources/async-operations.js:
  • fast/filesystem/resources/fs-test-util.js: (removeAllInDirectory): renamed from removeRecursively and changed the implemntation to use DirectoryEntry.removeRecursively.
  • fast/filesystem/resources/fs-worker-common.js: (removeAllInDirectorySync): ditto.
  • fast/filesystem/resources/op-remove.js: Added removeRecursively test.
  • fast/filesystem/resources/op-tests-helper.js: (runOperationTest.OperationTestHelper.this.removeRecursively): Added.
  • fast/filesystem/resources/sync-operations.js:
  • fast/filesystem/script-tests/file-from-file-entry.js:
  • fast/filesystem/script-tests/read-directory.js:
4:03 AM Changeset in webkit [69484] by apavlov@chromium.org
  • 4 edits in trunk/LayoutTests

2010-10-11 Alexander Pavlov <​apavlov@chromium.org>

[Chromium] Unreviewed, build fix.

Rebaseline svg/W3C-SVG-1.1-SE/filters-image-03-f for chromium-linux.
Fix bad expectation.

  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png:
  • platform/chromium/test_expectations.txt:
3:38 AM Changeset in webkit [69483] by apavlov@chromium.org
  • 2 edits in trunk/LayoutTests

2010-10-11 Alexander Pavlov <​apavlov@chromium.org>

[Chromium] Unreviewed, build fix.

Update more test expectations.

  • platform/chromium/test_expectations.txt:
2:56 AM Changeset in webkit [69482] by krit@webkit.org
  • 6 edits in trunk

2010-10-11 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG feImage take preserveAspectRatio into account for absolute paint rect
​https://bugs.webkit.org/show_bug.cgi?id=47464

Determine the smallest effect region for SVGFEImage by taking preserveAspectRatio into account.

  • svg/graphics/filters/SVGFEImage.cpp: (WebCore::FEImage::determineAbsolutePaintRect): (WebCore::FEImage::apply):
  • svg/graphics/filters/SVGFEImage.h:

2010-10-11 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG feImage take preserveAspectRatio into account for absolute paint rect
​https://bugs.webkit.org/show_bug.cgi?id=47464

Needs a new baseline for svg/W3C-SVG-1.1-SE/filters-image-03-f.

  • platform/mac/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png:
2:19 AM Changeset in webkit [69481] by apavlov@chromium.org
  • 1 edit
    4 adds in trunk/LayoutTests

2010-10-11 Alexander Pavlov <​apavlov@chromium.org>

[Chromium] Unreviewed, build fix.

Rebaseline overhanging-floats-removed for chromium-win and chromium-linux platforms.

  • platform/chromium-linux/fast/flexbox/overhanging-floats-removed-expected.checksum: Added.
  • platform/chromium-linux/fast/flexbox/overhanging-floats-removed-expected.png: Added.
  • platform/chromium-win/fast/flexbox/overhanging-floats-removed-expected.checksum: Added.
  • platform/chromium-win/fast/flexbox/overhanging-floats-removed-expected.png: Added.
1:26 AM QtWebKitContrib edited by jocelyn.turcotte@nokia.com
Remove running the tests from the steps. (diff)
1:22 AM Changeset in webkit [69480] by abarth@webkit.org
  • 3 edits in trunk/WebKitTools

2010-10-11 Adam Barth <​abarth@webkit.org>

Unreviewed.

Fix sheriffbot not to crash when there are failing tests. It turns out
Python sets don't support the + operator. We need to use union
instead. There's a more elegant way to do this in Python 2.6, but we
need this code to work in 2.5.

  • Scripts/webkitpy/common/net/failuremap.py:
  • Scripts/webkitpy/common/net/failuremap_unittest.py:
12:17 AM Changeset in webkit [69479] by inferno@chromium.org
  • 1 edit
    2 adds
    1 delete in trunk/LayoutTests

2010-10-11 Abhishek Arya <​inferno@chromium.org>

Unreviewed.

Commit r69478 put the expected file in wrong platform. Correcting that.

  • platform/gtk/fast/flexbox: Added.
  • platform/gtk/fast/flexbox/overhanging-floats-removed-expected.txt: Added.
  • platform/qt/fast/flexbox/overhanging-floats-removed-expected.txt: Removed.
Note: See TracTimeline for information about the timeline view.