Timeline


and

10/18/10:

23:54 Changeset [70032] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2010-10-18 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed.

Re-enabled editing/execCommand/remove-formatting.html and editing/execCommand/remove-formatting-2.html on Qt platforms.

  • platform/qt/Skipped:
23:34 Changeset [70031] by rniwa@webkit.org
  • 3 edits
    2 adds
    22 deletes in trunk/LayoutTests

2010-10-18 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Kent Tamura.

dump-as-markup conversion: editing/execCommand/remove-formatting.html and remove-formatting-2.html
https://bugs.webkit.org/show_bug.cgi?id=47792

Converted editing/execCommand/remove-formatting.html and remove-formatting-2.html to dump-as-markup tests.

  • editing/execCommand/remove-formatting-2-expected.txt: Added.
  • editing/execCommand/remove-formatting-2.html:
  • editing/execCommand/remove-formatting-expected.txt: Added.
  • editing/execCommand/remove-formatting.html:
  • platform/chromium-linux/editing/execCommand/remove-formatting-2-expected.checksum: Removed.
  • platform/chromium-linux/editing/execCommand/remove-formatting-2-expected.png: Removed.
  • platform/chromium-linux/editing/execCommand/remove-formatting-expected.checksum: Removed.
  • platform/chromium-linux/editing/execCommand/remove-formatting-expected.png: Removed.
  • platform/chromium-win/editing/execCommand/remove-formatting-2-expected.checksum: Removed.
  • platform/chromium-win/editing/execCommand/remove-formatting-2-expected.png: Removed.
  • platform/chromium-win/editing/execCommand/remove-formatting-2-expected.txt: Removed.
  • platform/chromium-win/editing/execCommand/remove-formatting-expected.checksum: Removed.
  • platform/chromium-win/editing/execCommand/remove-formatting-expected.png: Removed.
  • platform/chromium-win/editing/execCommand/remove-formatting-expected.txt: Removed.
  • platform/mac-leopard/editing/execCommand/remove-formatting-2-expected.checksum: Removed.
  • platform/mac-leopard/editing/execCommand/remove-formatting-2-expected.png: Removed.
  • platform/mac-leopard/editing/execCommand/remove-formatting-expected.checksum: Removed.
  • platform/mac-leopard/editing/execCommand/remove-formatting-expected.png: Removed.
  • platform/mac/editing/execCommand/remove-formatting-2-expected.checksum: Removed.
  • platform/mac/editing/execCommand/remove-formatting-2-expected.png: Removed.
  • platform/mac/editing/execCommand/remove-formatting-2-expected.txt: Removed.
  • platform/mac/editing/execCommand/remove-formatting-expected.checksum: Removed.
  • platform/mac/editing/execCommand/remove-formatting-expected.png: Removed.
  • platform/mac/editing/execCommand/remove-formatting-expected.txt: Removed.
  • platform/qt/editing/execCommand/remove-formatting-2-expected.txt: Removed.
  • platform/qt/editing/execCommand/remove-formatting-expected.txt: Removed.
22:37 Changeset [70030] by commit-queue@webkit.org
  • 3 edits in trunk/WebKit/qt

2010-10-18 Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Export QWebPage::ViewportAttributes class.
https://bugs.webkit.org/show_bug.cgi?id=47845

  • Api/qwebpage.h:
  • symbian/eabi/QtWebKitu.def:
22:36 Changeset [70029] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-10-18 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Add Chromium Mac EWS to the list of queues at queues.webkit.org
https://bugs.webkit.org/show_bug.cgi?id=47878

  • QueueStatusServer/model/queues.py:
22:35 Changeset [70028] by eric@webkit.org
  • 6 edits in trunk/WebKitTools

2010-10-18 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

queues.webkit.org/next_patch is always 404
https://bugs.webkit.org/show_bug.cgi?id=47881

With the addition of the Queue class, I changed most of the
code to lookup WorkItems using get_or_insert with a key_name
instead of WorkItems.all().filter(queue_name=).
Because the new get_or_insert code uses an explicit key_name
(which is obviously different from the previously autogenerated
ones), there were new WorkItem records created for each queue.
However, some parts of the code still use WorkItems.all().filter,
thus some parts were getting the new record and some parts the old record.

The same basic bug was occurring with ActiveWorkItems, because I
changed the key_name for that class as well.

To fix this I've moved more of the code over to using Queue.*work_items.
I've also enabled the datastore_admin (new in GAE 1.3.8) so that
we can go delete the old WorkItems records.
I also changed remote_api to use the new builtin: syntax (also added in GAE 1.3.8).

  • QueueStatusServer/app.yaml:
  • QueueStatusServer/handlers/queuestatus.py:
  • QueueStatusServer/handlers/recentstatus.py:
  • QueueStatusServer/handlers/updatestatus.py:
  • QueueStatusServer/handlers/updateworkitems.py:
22:33 Changeset [70027] by tkent@chromium.org
  • 3 edits
    2 adds in trunk

2010-10-18 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

Should not save state of a detached form control.
https://bugs.webkit.org/show_bug.cgi?id=47811

  • fast/forms/state-save-of-detached-control-expected.txt: Added.
  • fast/forms/state-save-of-detached-control.html: Added.

2010-10-18 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

Should not save state of a detached form control.
https://bugs.webkit.org/show_bug.cgi?id=47811

Test: fast/forms/state-save-of-detached-control.html

  • html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElementWithState::shouldSaveAndRestoreFormControlState): If the node is detached, don't save the state.
21:55 Changeset [70026] by xan@webkit.org
  • 9 edits in trunk

2010-10-18 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

Bump version numbers for 1.3.5 release.

  • configure.ac:

WebCore:

2010-10-18 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

  • GNUmakefile.am: add missing files.

WebKit/gtk:

2010-10-18 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

  • NEWS: update for 1.3.5 release.
  • docs/webkitgtk-sections.txt: add new APIs.

JavaScriptCore:

2010-10-18 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

  • GNUmakefile.am: add missing file.
21:48 Changeset [70025] by eric@webkit.org
  • 8 edits
    2 copies in trunk/WebKitTools

2010-10-18 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Correct a bunch of typos in QueueStatusServer
https://bugs.webkit.org/show_bug.cgi?id=47880

These are all due to our complete lack of unit testing in QueueStatusServer.
I added a couple unit tests to cover a few of these fixes, but most of these
are still only caught by actually running the application.

  • QueueStatusServer/handlers/nextpatch.py:
  • QueueStatusServer/handlers/statusbubble.py:
  • QueueStatusServer/handlers/statusbubble_unittest.py: Added.
  • QueueStatusServer/handlers/updateworkitems.py:
  • QueueStatusServer/model/attachment.py:
  • QueueStatusServer/model/queuepropertymixin.py:
  • QueueStatusServer/model/queuepropertymixin_unittest.py:
  • QueueStatusServer/model/workitems.py:
  • QueueStatusServer/model/workitems_unittest.py: Added.
21:25 Changeset [70024] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-10-18 Adam Barth <abarth@webkit.org>

Disable this test because it's failing on the bots and the authors
aren't around to fix it.

  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
21:11 Changeset [70023] by abarth@webkit.org
  • 6 edits in trunk/WebKitTools

2010-10-18 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

CC authors of flaky tests when the commit-queue hits a flaky test
https://bugs.webkit.org/show_bug.cgi?id=47872

  • Scripts/webkitpy/common/checkout/api.py:
  • Scripts/webkitpy/common/net/layouttestresults.py:
  • Scripts/webkitpy/tool/commands/queues.py:
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
  • Scripts/webkitpy/tool/mocktool.py:
21:05 Changeset [70022] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-10-18 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Make it possible to run a chromium-mac-ews builder
https://bugs.webkit.org/show_bug.cgi?id=47876

Since we can't run Mac OS X in a VM, we need to only run committer patches.
There was a multiple inheritance problem which was holding this patch back,
but I decided to just ignore the problem and go with a functional hack for now.

  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:
  • Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
20:22 Changeset [70021] by kbr@google.com
  • 2 edits in trunk/WebKitTools

2010-10-18 Kenneth Russell <kbr@google.com>

Reviewed by Tony Chang.

Regression in run_webkit_tests_unittest from r70017
https://bugs.webkit.org/show_bug.cgi?id=47875

  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
19:44 Changeset [70020] by abarth@webkit.org
  • 6 edits in trunk/WebKitTools

2010-10-18 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Implement webkit-patch suggest-reviewers
https://bugs.webkit.org/show_bug.cgi?id=47866

  • Scripts/webkitpy/common/checkout/api.py:
    • The main logic. We look at the last five changes to each modified (non-ChangeLog) file and collect up the reviewers of those changes as well as the authors of those changes who are reviewers.
  • Scripts/webkitpy/common/checkout/api_unittest.py:
    • Test the logic with some fun mocks.
  • Scripts/webkitpy/common/checkout/scm.py:
    • Fix a bug when you have local git commits.
  • Scripts/webkitpy/common/checkout/scm_unittest.py:
    • Test that the bug is fixed.
  • Scripts/webkitpy/tool/commands/queries.py:
    • Add the query.
19:37 Changeset [70019] by eric@webkit.org
  • 9 edits
    1 copy
    1 add in trunk/WebKitTools

2010-10-18 Kenneth Russell <kbr@google.com>

Reviewed by Eric Seidel.

new-run-webkit-tests produces corrupt PNG baselines on Windows
https://bugs.webkit.org/show_bug.cgi?id=47867

  • Scripts/webkitpy/layout_tests/port/base.py:
19:33 Changeset [70018] by oliver@apple.com
  • 5 edits in trunk

2010-10-18 Oliver Hunt <oliver@apple.com>

Reviewed by Sam Weinig.

REGRESSION: Feedly extension crashes Webkit
https://bugs.webkit.org/show_bug.cgi?id=45811

Make test cover large number of properties/string pairs, at two offsets to get the
new allocation to occur at different locations.

  • fast/dom/Window/window-postmessage-clone-expected.txt:
  • fast/dom/Window/window-postmessage-clone.html:

2010-10-18 Oliver Hunt <oliver@apple.com>

Reviewed by Sam Weinig.

REGRESSION: Feedly extension crashes Webkit
https://bugs.webkit.org/show_bug.cgi?id=45811

The basic problem was the deserializer was holding a pointer into
the constant pool, but if you were sufficiently unlucky then the
constant pool would be moved while still relying on the pointer,
which leads to badness.

I looked at just making all the sites this could happen extract the
right string/jsstring before any possible allocations, but it seemed
too fragile so i've gone for a forwarding object as the solution.

  • bindings/js/SerializedScriptValue.cpp: (WebCore::CloneDeserializer::CachedStringRef::CachedStringRef): (WebCore::CloneDeserializer::CachedStringRef::operator->): (WebCore::CloneDeserializer::readStringData): (WebCore::CloneDeserializer::readFile): (WebCore::CloneDeserializer::readTerminal): (WebCore::CloneDeserializer::deserialize):
19:32 Changeset [70017] by kbr@google.com
  • 2 edits in trunk/WebKitTools

2010-10-18 Kenneth Russell <kbr@google.com>

Reviewed by Eric Seidel.

new-run-webkit-tests produces corrupt PNG baselines on Windows
https://bugs.webkit.org/show_bug.cgi?id=47867

  • Scripts/webkitpy/layout_tests/port/base.py:
19:13 Changeset [70016] by eric@webkit.org
  • 8 edits
    2 copies in trunk/WebKitTools

2010-10-18 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Deploy Queue class in more places throughout QueueStatusServer
https://bugs.webkit.org/show_bug.cgi?id=47855

I also caught two typos from the previous change. Unfortunately
I don't yet know how to unittest request handlers yet.

  • QueueStatusServer/handlers/dashboard.py:
  • QueueStatusServer/handlers/statusbubble.py:
  • QueueStatusServer/handlers/updateworkitems.py:
  • QueueStatusServer/model/activeworkitems.py:
  • QueueStatusServer/model/attachment.py:
  • QueueStatusServer/model/queuepropertymixin.py: Added.
  • QueueStatusServer/model/queuepropertymixin_unittest.py: Added.
  • QueueStatusServer/model/queuestatus.py:
  • QueueStatusServer/model/workitems.py:
18:59 Changeset [70015] by crogers@google.com
  • 1 edit
    2 adds in trunk/WebCore

2010-10-18 Chris Rogers <crogers@google.com>

Reviewed by Chris Fleizach.

Add AudioResampler files
https://bugs.webkit.org/show_bug.cgi?id=47623

No new tests since audio API is not yet implemented.

  • platform/audio/AudioResampler.cpp: Added. (WebCore::AudioResampler::AudioResampler): (WebCore::AudioResampler::configureChannels): (WebCore::AudioResampler::process): (WebCore::AudioResampler::setRate): (WebCore::AudioResampler::reset):
  • platform/audio/AudioResampler.h: Added. (WebCore::AudioResampler::~AudioResampler): (WebCore::AudioResampler::rate):
18:38 Changeset [70014] by abarth@webkit.org
  • 3 edits in trunk/WebKitTools

2010-10-18 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

scm.py should be able tell us what revisions made changes to a given file
https://bugs.webkit.org/show_bug.cgi?id=47863

Look again, your SCM.py can now log files.

  • Scripts/webkitpy/common/checkout/scm.py:
  • Scripts/webkitpy/common/checkout/scm_unittest.py:
18:02 Changeset [70013] by dpranke@chromium.org
  • 16 edits
    1 add in trunk/WebKitTools

2010-10-18 Dirk Pranke <dpranke@chromium.org>

Reviewed by Eric Siedel.

new-run-webkit-tests: clean up the options-parsing code in the port
classes.

This change modifies the Port interface to have a get_option() and
set_option_default() method for accessing the options argument
passed to the constructor. If the constructor is not passed an
options argument, we default to a MockOptions() argument from
mocktool, which has the same semantics we want.

Note that there is a disadvantage to port.get_option('foo') over
port._options.foo, which is that you lose some of the checking
for whether 'foo' is set (typos result in the default value, not
an exception being raised. This is desired in this case, since the
Port class is not allowed to assume that options does have any
particular values set, and so this change ensures that all of
the subclasses are following the same, intended, logic.

Arguably this is the wrong semantics to have, and the Port
classes should be able to assume a default set of
attributes/arguments, but that change will need to wait for a
different CL where we can modify new-run-webkit-tests to pull a
list of arguments from the port factory routines.

Also, add unit tests for webkitpy.tool.mocktool.MockOptions .

https://bugs.webkit.org/show_bug.cgi?id=47510

  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/base_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
  • Scripts/webkitpy/layout_tests/port/dryrun.py:
  • Scripts/webkitpy/layout_tests/port/factory_unittest.py:
  • Scripts/webkitpy/layout_tests/port/mac_unittest.py:
  • Scripts/webkitpy/layout_tests/port/port_testcase.py:
  • Scripts/webkitpy/layout_tests/port/test.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
  • Scripts/webkitpy/tool/mocktool_unittest.py: Added.
17:40 Changeset [70012] by dpranke@chromium.org
  • 9 edits in trunk/WebKitTools

2010-10-18 Dirk Pranke <dpranke@chromium.org>

Reviewed by Eric Seidel.

Re-submit a revised version of r69638 - enabling new-run-webkit-tests
under cygwin. The initial version had a bug in base:uri_to_test_name
that was causing tests to fail. This version corrects that bug, but
also makes the code safer by calling cygpath more reliably, and
leaving a long-running cygpath process open.

This patch also corrects a couple of minor bugs in http_lock_unittest,
chromium_unittest, and dedpulicate_tests_unittest that showed up
while testing this.

https://bugs.webkit.org/show_bug.cgi?id=47220

  • Scripts/webkitpy/common/system/path.py:
  • Scripts/webkitpy/common/system/path_unittest.py:
  • Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
  • Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/base_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  • Scripts/webkitpy/layout_tests/port/http_lock_unittest.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
17:06 Changeset [70011] by jamesr@google.com
  • 2 edits
    1 add in trunk/LayoutTests

2010-10-18 James Robinson <jamesr@chromium.org>

Update chromium test expectations

  • platform/chromium-linux/svg/custom/text-linking-expected.txt: Copied from LayoutTests/platform/chromium-win-xp/svg/custom/text-linking-expected.txt.
  • platform/chromium/test_expectations.txt:
16:53 Changeset [70010] by vangelis@chromium.org
  • 6 edits in trunk/WebCore

2010-10-18 Vangelis Kokkevis <vangelis@chromium.org>

Reviewed by James Robinson.

[chromium] Prevent the creation of very large textures for layers by switching
to "large layer" mode when a texture is larger than some fixed reasonable size
(set to 2000 pixels for now).
https://bugs.webkit.org/show_bug.cgi?id=47751

The code also changes the large layer logic to use the current scissor rect used
by the compositor instead of the visible rect to determine how to clip large layers.
This will provide additional texture savings. In addition, the various layer rects
have been converted to use integers instead of floats to preserve uniformity in the code.


Tests: Existing large layer layout tests including huge-layer and huge-layer-img

  • platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::requiresClippedUpdateRect): (WebCore::ContentLayerChromium::calculateClippedUpdateRect):
  • platform/graphics/chromium/LayerChromium.cpp: (WebCore::LayerChromium::getDrawRect):
  • platform/graphics/chromium/LayerChromium.h:
  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::drawLayers): (WebCore::LayerRendererChromium::drawLayersRecursive): (WebCore::LayerRendererChromium::scissorToRect):
  • platform/graphics/chromium/LayerRendererChromium.h: (WebCore::LayerRendererChromium::currentScissorRect):
16:38 Changeset [70009] by jamesr@google.com
  • 2 edits
    2 moves
    1 delete in trunk/LayoutTests

2010-10-18 James Robinson <jamesr@chromium.org>

Move chromium xp specific baselines to right place.

  • platform/chromium-win-xp/svg/custom/text-linking-expected.checksum:
  • platform/chromium-win-xp/svg/custom/text-linking-expected.png: Renamed from LayoutTests/platform/chromium-win/svg/custom/text-linking-expected.png.
  • platform/chromium-win-xp/svg/custom/text-linking-expected.txt: Renamed from LayoutTests/platform/chromium-win/svg/custom/text-linking-expected.txt.
  • platform/chromium-win/svg/custom/text-linking-expected.checksum: Removed.
16:28 Changeset [70008] by oliver@apple.com
  • 5 edits in trunk

2010-10-18 Oliver Hunt <oliver@apple.com>

Reviewed by Sam Weinig.

Strict mode: Functions created with the function constructor don't implement strict mode semantics
https://bugs.webkit.org/show_bug.cgi?id=47860

When creating the FunctionExecutable for a new function the function constructor
was always passing false for whether or not a function was strict, rather than
using the information from the freshly parsed function itself.

  • runtime/Executable.cpp: (JSC::FunctionExecutable::fromGlobalCode):

2010-10-18 Oliver Hunt <oliver@apple.com>

Reviewed by Sam Weinig.

Strict mode: Functions created with the function constructor don't implement strict mode semantics
https://bugs.webkit.org/show_bug.cgi?id=47860

Test that the function constructor produces correct strict mode functions.

  • fast/js/basic-strict-mode-expected.txt:
  • fast/js/script-tests/basic-strict-mode.js:
16:21 Changeset [70007] by andersca@apple.com
  • 2 edits in trunk/WebKit2

Initialize the API client.

Reviewed by Sam Weinig.

  • Shared/APIClient.h:

(WebKit::APIClient::APIClient):

16:08 Changeset [70006] by eric@webkit.org
  • 11 edits
    1 add in trunk/WebKitTools

2010-10-18 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Add Queue class and add minimal unittesting of QueueStatusServer code
https://bugs.webkit.org/show_bug.cgi?id=47847

  • QueueStatusServer/handlers/dashboard.py:
  • QueueStatusServer/handlers/queuestatus.py:
  • QueueStatusServer/handlers/recentstatus.py:
  • QueueStatusServer/handlers/statusbubble.py:
  • QueueStatusServer/handlers/updateworkitems.py:
  • QueueStatusServer/model/attachment.py:
  • QueueStatusServer/model/queues.py:
  • QueueStatusServer/model/queues_unittest.py: Added.
  • QueueStatusServer/model/svnrevision.py:
  • Scripts/test-webkitpy:
  • Scripts/webkitpy/test/main.py:
15:44 Changeset [70005] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

2010-10-18 James Robinson <jamesr@chromium.org>

Mark flaky SVG tests as flaky in chromium test expectations.

  • platform/chromium/test_expectations.txt:
15:40 Changeset [70004] by andersca@apple.com
  • 5 edits in trunk/WebKit2

WebKit2 should handle dismissing the Find overlay on mouse-down
https://bugs.webkit.org/show_bug.cgi?id=47854

Reviewed by John Sullivan.

  • WebProcess/WebPage/FindPageOverlay.cpp:

(WebKit::FindPageOverlay::mouseEvent):
Dismiss the find UI on MouseDown.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::mouseEvent):
If there's a page overlay, let it have a go at the event.

15:29 Changeset [70003] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-10-18 Jia Pu <jpu@apple.com>

Reviewed by Stephanie Lewis.

Correct the description of manual test: autocorrection-cancelled-by-typing-1.html
https://bugs.webkit.org/show_bug.cgi?id=47722
<rdar://problem/8556206>

  • manual-tests/autocorrection/autocorrection-cancelled-by-typing-1.html: Update description to match the test content.
15:19 Changeset [70002] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2010-10-18 Mihai Parparita <mihaip@chromium.org>

Group Chromium DRT media test failures and add media/video-src.html,
which became flaky around r68970.

  • platform/chromium/drt_expectations.txt:
15:14 Changeset [70001] by andersca@apple.com
  • 5 edits in trunk/WebKit2

Fix clang build.

  • UIProcess/API/mac/FindIndicatorWindow.mm:

(-[WebFindIndicatorWindowAnimation _initWithFindIndicatorWindow:WebKit::animationProgressCallback:WebKit::FindIndicatorWindow::animationDidEndCallback:WebKit::FindIndicatorWindow::]):
(WebKit::FindIndicatorWindow::setFindIndicator):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPopupMenuProxy.h:
  • WebProcess/WebCoreSupport/WebPopupMenu.h:
15:13 Changeset [70000] by beidson@apple.com
  • 1 edit in trunk/ChangeLog

70,000!

15:11 Changeset [69999] by weinig@apple.com
  • 2 edits in trunk/WebKit2

Fix Qt build.

  • WebKit2.pro:
15:10 WebKit2 edited by simon.fraser@apple.com
(diff)
15:02 Changeset [69998] by mrobinson@webkit.org
  • 2 edits in trunk/WebCore

2010-10-18 Martin Robinson <mrobinson@igalia.com>

Build fix for newer versions of GTK+ 2.0. Instead of using GDK_DISPLAY()
use GDK_DRAWABLE_XDISPLAY(gdk_display_get_default()). GDK_DISPLAY() was
recently deprecated and the latter method has been available since GTK+
2.2.

  • plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::updatePluginWidget): (WebCore::PluginView::paint): (WebCore::PluginView::initXEvent): (WebCore::PluginView::platformGetValue): (WebCore::getVisualAndColormap): (WebCore::PluginView::platformStart): (WebCore::PluginView::platformDestroy):
14:55 Changeset [69997] by andersca@apple.com
  • 3 edits in trunk/WebKit2

Don't try to change accelerated compositing mode if the web page is closed
https://bugs.webkit.org/show_bug.cgi?id=47852

Reviewed by Simon Fraser.

changeAcceleratedCompositingMode ends up sending a sync message to the UI process which is unnecessary if
the UI process is being torn down.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):
(WebKit::WebPage::changeAcceleratedCompositingMode):
(WebKit::WebPage::close):

  • WebProcess/WebPage/WebPage.h:
14:53 Changeset [69996] by commit-queue@webkit.org
  • 6 edits in trunk

2010-10-18 Adrienne Walker <enne@google.com>

Reviewed by Kenneth Russell.

Update context attribute conformance test from updated Khronos source.
https://bugs.webkit.org/show_bug.cgi?id=47697

  • fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias-expected.txt:
  • fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias.html:
  • platform/chromium/test_expectations.txt:

2010-10-18 Adrienne Walker <enne@google.com>

Reviewed by Kenneth Russell.

Turn off antialiasing when using Mesa during testing.
https://bugs.webkit.org/show_bug.cgi?id=47697

  • src/WebGraphicsContext3DDefaultImpl.cpp: (WebKit::WebGraphicsContext3DDefaultImpl::validateAttributes):
14:44 Changeset [69995] by brettw@chromium.org
  • 1 edit in branches/chromium/552/WebKit/chromium/src/WebFontImpl.cpp

Merge 69719 - 2010-10-13 Brett Wilson <brettw@chromium.org>

Reviewed by Darin Fisher.

Save and restore the GraphicsContext around setting the clip rect for
drawing text.
https://bugs.webkit.org/show_bug.cgi?id=47634

  • src/WebFontImpl.cpp: (WebKit::WebFontImpl::drawText):

TBR=brettw@chromium.org

14:42 Changeset [69994] by rniwa@webkit.org
  • 5 edits in trunk/WebCore

2010-10-18 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Adam Barth.

elementCannotHaveEndTag should be a member function of MarkupAccumulator
https://bugs.webkit.org/show_bug.cgi?id=47846

Moved elementCannotHaveEndTag into MarkupAccumulator.

No new tests are added since this is a cleanup.

  • editing/MarkupAccumulator.cpp: (WebCore::MarkupAccumulator::elementCannotHaveEndTag): Added.
  • editing/MarkupAccumulator.h: Added MarkupAccumulator::elementCannotHaveEndTag.
  • editing/markup.cpp: Removed elementCannotHaveEndTag.
  • editing/markup.h: Removed elementCannotHaveEndTag.
14:41 Changeset [69993] by jamesr@google.com
  • 2 edits in trunk/WebKit/chromium

2010-10-18 James Robinson <jamesr@chromium.org>

Update the chromium DEPS from 62399 to 62813 to pick up skia fixes

  • DEPS:
14:28 Changeset [69992] by andersca@apple.com
  • 4 edits in trunk/WebKit2

<rdar://problem/8036034>
WebKit2's WebProcess dies immediately on Mac due to DYLD_FRAMEWORK_PATH problem

Reviewed by Sam Weinig.

Pass the path to the WebKit2 framework along to the web process and don't rely on DYLD_FRAMEWORK_PATH being set.

  • Shared/mac/CommandLineMac.cpp:

(WebKit::CommandLine::parse):

  • UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::ProcessLauncher::launchProcess):

  • mac/MainMac.cpp:

(main):

14:24 Changeset [69991] by jberlin@webkit.org
  • 9 edits
    3 adds in trunk/WebKit2

Need a WebKit2 equivalent of the WebKit1 WebUserContentURLPattern.
https://bugs.webkit.org/show_bug.cgi?id=47783

Reviewed by Sam Weinig.

  • Shared/API/c/WKBase.h:
  • Shared/API/c/WKSharedAPICast.h:
  • Shared/API/c/WKUserContentURLPattern.cpp: Added.

(WKUserContentURLPatternGetTypeID):
(WKUserContentURLPatternCreate):
(WKUserContentURLPatternMatchesURL):

  • Shared/API/c/WKUserContentURLPattern.h: Added.
  • Shared/APIObject.h:
  • Shared/UserMessageCoders.h:

Use the original pattern string to encode and decode a UserContentURLPattern.
(WebKit::UserMessageEncoder::baseEncode):
(WebKit::UserMessageDecoder::baseDecode):

  • Shared/WebUserContentURLPattern.h: Added.

(WebKit::WebUserContentURLPattern::create):
(WebKit::WebUserContentURLPattern::matchesURL):
Use WebCore::UserContentURLPattern::matches.
(WebKit::WebUserContentURLPattern::patternString):
Expose the pattern string used to create the UserContentURLPattern for the purpose of
encoding and decoding.
(WebKit::WebUserContentURLPattern::WebUserContentURLPattern):
(WebKit::WebUserContentURLPattern::type):

  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:

Add WKUserContentURLPattern.h/.cpp and WebUserContentURLPattern.h

  • win/WebKit2Generated.make:

Copy over WKUsercontentURLPattern into the output directory.

14:15 Changeset [69990] by inferno@chromium.org
  • 4 edits
    2 adds in trunk

2010-10-18 Johnny Ding <jnd@chromium.org>

Reviewed by Adam Barth.

Set the right referent sourceURL for the script with force user gesture.
https://bugs.webkit.org/show_bug.cgi?id=37138

Because empty sourceURL indicates running script with force user gesture,
make WebKit use document.url() as referent sourceURL (Since it uses blank
URL instead empty if the input URL is empty) if WebKit isn't running the
script from a hyper-link.

Test: fast/events/popup-blocked-from-window-open.html

  • bindings/ScriptControllerBase.cpp: (WebCore::ScriptController::executeScript):
  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::executeScriptInWorld):

2010-10-18 Johnny Ding <jnd@chromium.org>

Reviewed by Adam Barth.

Set the right referent sourceURL for the script with force user gesture.
https://bugs.webkit.org/show_bug.cgi?id=37138

  • fast/events/popup-blocked-from-window-open-expected.txt: Added.
  • fast/events/popup-blocked-from-window-open.html: Added.
14:12 Changeset [69989] by jamesr@google.com
  • 15 edits
    6 adds in trunk/LayoutTests

2010-10-18 James Robinson <jamesr@chromium.org>

Update chromium expectations and baselines.

  • platform/chromium/test_expectations.txt:
12:59 Changeset [69988] by darin@apple.com
  • 2 edits in trunk/WebCore
  • dom/Node.h: Fix ancient typo in just-modified comment.
12:52 Changeset [69987] by darin@apple.com
  • 10 edits in trunk/WebCore

2010-10-18 Darin Adler <darin@apple.com>

Reviewed by Alexey Proskuryakov.

Remove some functions from class Node and make a few others non-virtual
https://bugs.webkit.org/show_bug.cgi?id=47735

Refactoring. No new tests.

  • bindings/js/JSNodeCustom.cpp: (WebCore::JSNode::markChildren): Added a FIXME about the use of the virtual ownerDocument function.
  • dom/ContainerNode.cpp: (WebCore::ContainerNode::removeChildren): Removed the unused return value.
  • dom/ContainerNode.h: Made insertBefore, replaceChild, removeChild, and appendChild non-virtual for clarity and performance. Made removeChildren non-virtual and removed its return value. Moved the inline Node functions that call through to ContainerNode into this file since the old way involved an extra level of inline function but otherwise had no advantages.
  • dom/Element.h: Moved isMathMLElement here because there is no call site that needs to call it on a Node*. We can always move it back if we need to, but it's better to have less in the Node class.
  • dom/Node.cpp: (WebCore::Node::insertBefore): Added an isContainerNode check so this can be non-virtual. There are very few callers who call this function on Node. If we want to optimize them further we can make the isContainerNode check inline in the future. (WebCore::Node::replaceChild): Ditto. (WebCore::Node::removeChild): Ditto. (WebCore::Node::appendChild): Ditto. (WebCore::Node::remove): Removed unneeded ref/unref because ContainerNode::removeChild already does this. (WebCore::Node::createRendererIfNeeded): Removed #if around call to childShouldCreateRenderer since it's needed even without SVG and XHTMLMP.
  • dom/Node.h: Moved definitions of inline functions that depend on ContainerNode to the ContainerNode.h header. They already required inclusion of that header, so there is no functional change. Made insertBefore, replaceChild, removeChild, and appendChild non-virtual. There are very few callers of these functions on this class. Moved isMathMLElement to Element. Added a FIXME about the name of eventAncestors. Fixed comment formatting. Eliminated unused isEditableBlock function. Moved the body of the enclosingInlineElement function to the editing file that was the only call site. Removed the previousEditable and nextEditable functions, incorporating their bodies into the one place they were called. Took the childShouldCreateRenderer function out of #if since it's now used by the implementation of the <noscript> element.
  • dom/Position.cpp: (WebCore::nextRenderedEditable): Rewrote the function to use nextLeafNode instead of nextEditable. (WebCore::previousRenderedEditable): Rewrote the function to use previousLeafNode instead of previousEditable.
  • editing/ReplaceSelectionCommand.cpp: (WebCore::enclosingInline): Moved function here from the Node class. Also fixed an incorrect cast this function did, which assumed the function result was always an element, which the function does not guarantee. (WebCore::ReplaceSelectionCommand::doApply): Call the function above.
  • history/HistoryItem.cpp: Added include of MathExtras.h.
12:48 Changeset [69986] by andersca@apple.com
  • 2 edits in trunk/WebKitTools

Fix build.

  • DumpRenderTree/TestNetscapePlugIn/main.cpp:

(handleEventCarbon):

12:46 Changeset [69985] by andersca@apple.com
  • 2 edits in trunk/WebKit2

Fix build.

  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:

(WebKit::NetscapePlugin::platformHandleMouseEnterEvent):
(WebKit::NetscapePlugin::platformHandleMouseLeaveEvent):
(WebKit::NetscapePlugin::platformSetFocus):

12:33 Changeset [69984] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

2010-10-18 Yongjun Zhang <yongjun_zhang@apple.com>

Reviewed by Darin Adler.

Missing support for document.createEvent("OrientationEvent")
https://bugs.webkit.org/show_bug.cgi?id=32492

Add support for document.createEvent("OrientationEvent") to help unit testing of
onOrientationChange event.

  • fast/dom/DeviceOrientation/create-event-onorientationchange-expected.txt: Added.
  • fast/dom/DeviceOrientation/create-event-onorientationchange.html: Added.
  • fast/dom/DeviceOrientation/script-tests/create-event-onorientationchange.js: Added.

2010-10-18 Yongjun Zhang <yongjun_zhang@apple.com>

Reviewed by Darin Adler.

Missing support for document.createEvent("OrientationEvent")
https://bugs.webkit.org/show_bug.cgi?id=32492

Add support for document.createEvent("OrientationEvent") to help unit testing of
onOrientationChange event.

Test: fast/dom/DeviceOrientation/create-event-onorientationchange.html

  • dom/Document.cpp: (WebCore::Document::createEvent):
12:15 Changeset [69983] by jorlow@chromium.org
  • 9 edits in trunk

2010-10-18 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Adler.

DOMStringList should return null if the index is out of range
https://bugs.webkit.org/show_bug.cgi?id=47829

Add tests for out of range behavior here since IndexedDB is the only user
of DOMStringList.

  • storage/indexeddb/database-basics-expected.txt:
  • storage/indexeddb/database-basics.html:
  • storage/indexeddb/objectstore-basics-expected.txt:
  • storage/indexeddb/objectstore-basics.html:

2010-10-18 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Adler.

DOMStringList should return null if the index is out of range
https://bugs.webkit.org/show_bug.cgi?id=47829

When item() returns a null string, it needs to be passed to JS as
null. The indexed getter will then magically do the right thing.
So all that's left is having DOMStringList::item() return null when
the index is out of bounds.

  • dom/DOMStringList.cpp: (WebCore::DOMStringList::item):
  • dom/DOMStringList.h:
  • dom/DOMStringList.idl:
12:14 Changeset [69982] by rniwa@webkit.org
  • 4 edits
    3 adds
    33 deletes in trunk/LayoutTests

2010-10-18 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Kent Tamura.

dump-as-markup conversion: editing/execCommand/4920742-1.html, 5049671.html, and 5573879.html
https://bugs.webkit.org/show_bug.cgi?id=47784

Converted editing/execCommand/4920742-1.html, 5049671.html, and 5573879.html to dump-as-markup tests.

  • editing/execCommand/4920742-1-expected.txt: Added.
  • editing/execCommand/4920742-1.html:
  • editing/execCommand/5049671-expected.txt: Added.
  • editing/execCommand/5049671.html:
  • editing/execCommand/5573879-expected.txt: Added.
  • editing/execCommand/5573879.html:
  • platform/chromium-linux/editing/execCommand/4920742-1-expected.checksum: Removed.
  • platform/chromium-linux/editing/execCommand/4920742-1-expected.png: Removed.
  • platform/chromium-linux/editing/execCommand/5049671-expected.checksum: Removed.
  • platform/chromium-linux/editing/execCommand/5049671-expected.png: Removed.
  • platform/chromium-linux/editing/execCommand/5573879-expected.checksum: Removed.
  • platform/chromium-linux/editing/execCommand/5573879-expected.png: Removed.
  • platform/chromium-win/editing/execCommand/4920742-1-expected.checksum: Removed.
  • platform/chromium-win/editing/execCommand/4920742-1-expected.png: Removed.
  • platform/chromium-win/editing/execCommand/4920742-1-expected.txt: Removed.
  • platform/chromium-win/editing/execCommand/5049671-expected.checksum: Removed.
  • platform/chromium-win/editing/execCommand/5049671-expected.png: Removed.
  • platform/chromium-win/editing/execCommand/5049671-expected.txt: Removed.
  • platform/chromium-win/editing/execCommand/5573879-expected.checksum: Removed.
  • platform/chromium-win/editing/execCommand/5573879-expected.png: Removed.
  • platform/chromium-win/editing/execCommand/5573879-expected.txt: Removed.
  • platform/gtk/editing/execCommand/4920742-1-expected.txt: Removed.
  • platform/gtk/editing/execCommand/5049671-expected.txt: Removed.
  • platform/gtk/editing/execCommand/5573879-expected.txt: Removed.
  • platform/mac-leopard/editing/execCommand/4920742-1-expected.checksum: Removed.
  • platform/mac-leopard/editing/execCommand/4920742-1-expected.png: Removed.
  • platform/mac-leopard/editing/execCommand/5049671-expected.checksum: Removed.
  • platform/mac-leopard/editing/execCommand/5049671-expected.png: Removed.
  • platform/mac/editing/execCommand/4920742-1-expected.checksum: Removed.
  • platform/mac/editing/execCommand/4920742-1-expected.png: Removed.
  • platform/mac/editing/execCommand/4920742-1-expected.txt: Removed.
  • platform/mac/editing/execCommand/5049671-expected.checksum: Removed.
  • platform/mac/editing/execCommand/5049671-expected.png: Removed.
  • platform/mac/editing/execCommand/5049671-expected.txt: Removed.
  • platform/mac/editing/execCommand/5573879-expected.checksum: Removed.
  • platform/mac/editing/execCommand/5573879-expected.png: Removed.
  • platform/mac/editing/execCommand/5573879-expected.txt: Removed.
  • platform/qt/editing/execCommand/4920742-1-expected.txt: Removed.
  • platform/qt/editing/execCommand/5049671-expected.txt: Removed.
12:13 Changeset [69981] by girish@forwardbias.in
  • 3 edits in trunk/WebCore

[Qt] Implement Accelerated Composition for NPAPI Plugins.

Reviewed by Ariya Hidayat.

https://bugs.webkit.org/show_bug.cgi?id=35524

  • plugins/PluginView.h:

(WebCore::PluginView::platformLayer):

  • plugins/qt/PluginViewQt.cpp:

(WebCore::PluginGraphicsLayerQt::PluginGraphicsLayerQt):
(WebCore::PluginGraphicsLayerQt::~PluginGraphicsLayerQt):
(WebCore::PluginGraphicsLayerQt::paint):
(WebCore::PluginView::updatePluginWidget):
(WebCore::PluginView::paint):
(WebCore::PluginView::invalidateRect):
(WebCore::PluginView::invalidateRegion):
(WebCore::PluginView::platformStart):
(WebCore::PluginView::platformLayer):

11:54 Changeset [69980] by rniwa@webkit.org
  • 4 edits
    3 adds
    34 deletes in trunk/LayoutTests

2010-10-18 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Kent Tamura.

dump-as-markup conversion: editing/execCommand/4786404-1.html, 4786404-2.html, 4920488.html
https://bugs.webkit.org/show_bug.cgi?id=47782

Converted editing/execCommand/4786404-1.html, 4786404-2.html, 4920488.html to dump-as-markup tests.

  • editing/execCommand/4786404-1-expected.txt: Added.
  • editing/execCommand/4786404-1.html:
  • editing/execCommand/4786404-2-expected.txt: Added.
  • editing/execCommand/4786404-2.html:
  • editing/execCommand/4920488-expected.txt: Added.
  • editing/execCommand/4920488.html:
  • platform/chromium-linux/editing/execCommand/4786404-1-expected.checksum: Removed.
  • platform/chromium-linux/editing/execCommand/4786404-1-expected.png: Removed.
  • platform/chromium-linux/editing/execCommand/4786404-2-expected.checksum: Removed.
  • platform/chromium-linux/editing/execCommand/4786404-2-expected.png: Removed.
  • platform/chromium-linux/editing/execCommand/4920488-expected.checksum: Removed.
  • platform/chromium-linux/editing/execCommand/4920488-expected.png: Removed.
  • platform/chromium-win/editing/execCommand/4786404-1-expected.checksum: Removed.
  • platform/chromium-win/editing/execCommand/4786404-1-expected.png: Removed.
  • platform/chromium-win/editing/execCommand/4786404-1-expected.txt: Removed.
  • platform/chromium-win/editing/execCommand/4786404-2-expected.checksum: Removed.
  • platform/chromium-win/editing/execCommand/4786404-2-expected.png: Removed.
  • platform/chromium-win/editing/execCommand/4786404-2-expected.txt: Removed.
  • platform/chromium-win/editing/execCommand/4920488-expected.checksum: Removed.
  • platform/chromium-win/editing/execCommand/4920488-expected.png: Removed.
  • platform/chromium-win/editing/execCommand/4920488-expected.txt: Removed.
  • platform/gtk/editing/execCommand/4786404-1-expected.txt: Removed.
  • platform/gtk/editing/execCommand/4786404-2-expected.txt: Removed.
  • platform/gtk/editing/execCommand/4920488-expected.txt: Removed.
  • platform/mac-leopard/editing/execCommand/4786404-2-expected.checksum: Removed.
  • platform/mac-leopard/editing/execCommand/4786404-2-expected.png: Removed.
  • platform/mac-leopard/editing/execCommand/4920488-expected.checksum: Removed.
  • platform/mac-leopard/editing/execCommand/4920488-expected.png: Removed.
  • platform/mac/editing/execCommand/4786404-1-expected.checksum: Removed.
  • platform/mac/editing/execCommand/4786404-1-expected.png: Removed.
  • platform/mac/editing/execCommand/4786404-1-expected.txt: Removed.
  • platform/mac/editing/execCommand/4786404-2-expected.checksum: Removed.
  • platform/mac/editing/execCommand/4786404-2-expected.png: Removed.
  • platform/mac/editing/execCommand/4786404-2-expected.txt: Removed.
  • platform/mac/editing/execCommand/4920488-expected.checksum: Removed.
  • platform/mac/editing/execCommand/4920488-expected.png: Removed.
  • platform/mac/editing/execCommand/4920488-expected.txt: Removed.
  • platform/qt/editing/execCommand/4786404-1-expected.txt: Removed.
  • platform/qt/editing/execCommand/4786404-2-expected.txt: Removed.
  • platform/qt/editing/execCommand/4920488-expected.txt: Removed.
11:54 Changeset [69979] by commit-queue@webkit.org
  • 7 edits in trunk

2010-10-18 Stuart Morgan <stuartmorgan@chromium.org>

Reviewed by Eric Seidel.

Switch to using the new Carbon NPAPI event declarations, and remove
the old ones.

https://bugs.webkit.org/show_bug.cgi?id=40784

  • bridge/npapi.h:
  • plugins/mac/PluginViewMac.mm: (WebCore::PluginView::setFocus): (WebCore::PluginView::handleMouseEvent):

2010-10-18 Stuart Morgan <stuartmorgan@chromium.org>

Reviewed by Eric Seidel.

Switch to using the new Carbon NPAPI event declarations, and remove
the old ones.

https://bugs.webkit.org/show_bug.cgi?id=40784

  • Plugins/WebNetscapePluginEventHandlerCarbon.mm: (WebNetscapePluginEventHandlerCarbon::mouseEntered): (WebNetscapePluginEventHandlerCarbon::mouseExited): (WebNetscapePluginEventHandlerCarbon::mouseMoved): (WebNetscapePluginEventHandlerCarbon::focusChanged):

2010-10-18 Stuart Morgan <stuartmorgan@chromium.org>

Reviewed by Eric Seidel.

Switch to using the new Carbon NPAPI event declarations, and remove
the old ones.

https://bugs.webkit.org/show_bug.cgi?id=40784

  • DumpRenderTree/TestNetscapePlugIn/main.cpp: (handleEventCarbon):
11:46 Changeset [69978] by andersca@apple.com
  • 13 edits in trunk/WebKit2

Add matchCountDidChange callback
https://bugs.webkit.org/show_bug.cgi?id=47840

Reviewed by Darin Adler.

  • UIProcess/API/C/WKPage.h:

Add matchCountDidChange WKPageFindClient callback.

  • UIProcess/WebFindClient.cpp:

(WebKit::WebFindClient::matchCountDidChange):
Call the WKPageFindClient callback.

  • UIProcess/WebPageProxy.messages.in:

Add MatchCountDidChange message.

  • WebProcess/WebPage/FindController.cpp:

(WebKit::FindController::countStringMatches):
Move code here from WebPage.

(WebKit::FindController::findString):
Send the MatchCountDidChange message.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::countStringMatches):
Move this code over to FindController.

11:32 Changeset [69977] by oliver@apple.com
  • 5 edits in trunk

2010-10-18 Oliver Hunt <oliver@apple.com>

Reviewed by Darin Adler.

Strict mode: |this| should be undefined if it is not explicitly provided
https://bugs.webkit.org/show_bug.cgi?id=47833

To make strict mode behave correctly we want to pass undefined instead of null
as the default this value. This has no impact on behaviour outside of strict
mode as both values are replaced with the global object if necessary.

  • bytecompiler/NodesCodegen.cpp: (JSC::FunctionCallValueNode::emitBytecode): (JSC::FunctionCallResolveNode::emitBytecode): (JSC::CallFunctionCallDotNode::emitBytecode): (JSC::ApplyFunctionCallDotNode::emitBytecode):

2010-10-18 Oliver Hunt <oliver@apple.com>

Reviewed by Darin Adler.

Strict mode: |this| should be undefined if it is not explicitly provided
https://bugs.webkit.org/show_bug.cgi?id=47833

Add tests to ensure that |this| is undefined rather than null when it has
not been explicitly provided.

  • fast/js/basic-strict-mode-expected.txt:
  • fast/js/script-tests/basic-strict-mode.js:
11:17 Changeset [69976] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2010-10-18 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: comment out resource manager instantiation on front-end side.
https://bugs.webkit.org/show_bug.cgi?id=47823

  • inspector/front-end/inspector.js:
11:08 Changeset [69975] by robert@webkit.org
  • 2 edits in trunk/LayoutTests

2010-10-18 Robert Hogan <robert@webkit.org>

Rubber-stamped by Csaba Osztrogonác.

Unskip:

http/tests/navigation/no-referrer-reset.html
http/tests/navigation/no-referrer-target-blank.html

These tests now pass.

  • platform/qt/Skipped:
11:04 Changeset [69974] by andreip@google.com
  • 8 edits in trunk

2010-10-18 Andrei Popescu <andreip@google.com>

Reviewed by Jeremy Orlow.

The description parameter of IDBFactory::open() should be mandatory.
https://bugs.webkit.org/show_bug.cgi?id=47835

  • storage/indexeddb/basics-expected.txt:
  • storage/indexeddb/basics.html:

2010-10-18 Andrei Popescu <andreip@google.com>

Reviewed by Jeremy Orlow.

The description parameter of IDBFactory::open() should be mandatory.
https://bugs.webkit.org/show_bug.cgi?id=47835

Makes the description parameter mandatory, as per the IndexedDatabase specification.
Modified existing tests to cover this change.

  • storage/IDBDatabaseBackendImpl.cpp: (WebCore::extractMetaData): (WebCore::setMetaData): (WebCore::IDBDatabaseBackendImpl::IDBDatabaseBackendImpl):
  • storage/IDBFactory.cpp: (WebCore::IDBFactory::open):
  • storage/IDBFactory.h:
  • storage/IDBFactory.idl:
11:02 Changeset [69973] by andersca@apple.com
  • 4 edits in trunk/WebKit2

Use nullptr instead of 0.

Reviewed by Darin Adler.

  • UIProcess/API/mac/FindIndicatorWindow.mm:

(WebKit::FindIndicatorWindow::closeWindow):

  • UIProcess/API/mac/WKView.mm:

(-[WKView renewGState]):

  • WebProcess/Plugins/PluginProcessConnection.cpp:

(WebKit::PluginProcessConnection::removePluginProxy):

10:41 Changeset [69972] by xji@chromium.org
  • 2 edits in trunk/WebCore

2010-10-18 Xiaomei Ji <xji@chromium.org>

Reviewed by David Levin.

Code cleanup: Move most function members in TextRunWorker from inlined.
https://bugs.webkit.org/show_bug.cgi?id=47732

No functionality change, so no tests added.

  • platform/graphics/chromium/FontLinux.cpp: (WebCore::TextRunWalker::setWordSpacingAdjustment): (WebCore::TextRunWalker::setLetterSpacingAdjustment): (WebCore::TextRunWalker::setXOffsetToZero): (WebCore::TextRunWalker::rtl): (WebCore::TextRunWalker::glyphs): (WebCore::TextRunWalker::length): (WebCore::TextRunWalker::xPositions): (WebCore::TextRunWalker::advances): (WebCore::TextRunWalker::width): (WebCore::TextRunWalker::logClusters): (WebCore::TextRunWalker::numCodePoints): (WebCore::TextRunWalker::fontPlatformDataForScriptRun): (WebCore::TextRunWalker::isCodepointSpace): (WebCore::TextRunWalker::TextRunWalker): (WebCore::TextRunWalker::~TextRunWalker): (WebCore::TextRunWalker::isWordBreak): (WebCore::TextRunWalker::setPadding): (WebCore::TextRunWalker::reset): (WebCore::TextRunWalker::setBackwardsIteration): (WebCore::TextRunWalker::nextScriptRun): (WebCore::TextRunWalker::widthOfFullRun): (WebCore::TextRunWalker::getTextRun): (WebCore::TextRunWalker::getNormalizedTextRun): (WebCore::TextRunWalker::setupFontForScriptRun): (WebCore::TextRunWalker::allocHarfbuzzFont): (WebCore::TextRunWalker::deleteGlyphArrays): (WebCore::TextRunWalker::createGlyphArrays): (WebCore::TextRunWalker::resetGlyphArrays): (WebCore::TextRunWalker::shapeGlyphs): (WebCore::TextRunWalker::setGlyphXPositions): (WebCore::TextRunWalker::mirrorCharacters):
10:27 Changeset [69971] by noam.rosenthal@nokia.com
  • 3 edits in trunk/WebCore

2010-10-18 No'am Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Andreas Kling.

[Qt] AC rendering bugs
There were a few missing connections in Qt AC between GraphicsLayer and plugins, like changing the plugin's geometry to the layer's
contentsRect, and making sure media layers handle ParentChange events and setContentsNeedsDisplay. Now media layers behave correctly.

https://bugs.webkit.org/show_bug.cgi?id=47571

No new tests. This is in preparation for fixing AC+plugins, which already has tests that don't work yet with Qt.

  • platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::GraphicsLayerQtImpl::flushChanges): (WebCore::GraphicsLayerQt::setContentsNeedsDisplay):
  • platform/graphics/qt/GraphicsLayerQt.h:
10:23 Changeset [69970] by darin@apple.com
  • 10 edits
    1 add in trunk/JavaScriptCore

2010-10-18 Darin Adler <darin@apple.com>

Reviewed by Anders Carlsson.

Make a nullptr that works with OwnPtr and RefPtr
https://bugs.webkit.org/show_bug.cgi?id=47756

  • wtf/NullPtr.h: Added.
  • wtf/OwnArrayPtr.h: Add an overload of = taking nullptr.
  • wtf/OwnPtr.h: Ditto.
  • wtf/PassOwnArrayPtr.h: Ditto.
  • wtf/PassOwnPtr.h: Ditto.
  • wtf/PassRefPtr.h: Ditto.
  • wtf/RefPtr.h: Ditto.
  • wtf/RetainPtr.h: Ditto.
10:21 Changeset [69969] by podivilov@chromium.org
  • 4 edits in trunk/WebKit

2010-10-18 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: disable private browsing for inspector
https://bugs.webkit.org/show_bug.cgi?id=47827

  • WebCoreSupport/WebInspectorClient.mm: (-[WebInspectorWindowController init]):

2010-10-18 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: disable private browsing for inspector
https://bugs.webkit.org/show_bug.cgi?id=47827

  • WebCoreSupport/WebInspectorClient.cpp: (WebInspectorClient::openInspectorFrontend):
10:08 Changeset [69968] by pfeldman@chromium.org
  • 15 edits
    1 add in trunk

2010-10-18 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Simon Fraser.

Web Inspector: [crash] when Inspector Open in CSSStyleSelector::loadPendingImages().
https://bugs.webkit.org/show_bug.cgi?id=46224

  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/InspectorClient.cpp: Added. (WebCore::InspectorClient::doDispatchMessageOnFrontendPage):
  • inspector/InspectorClient.h: (WebCore::InspectorClient::InspectorClient):

2010-10-18 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Simon Fraser.

Web Inspector: [crash] when Inspector Open in CSSStyleSelector::loadPendingImages().
https://bugs.webkit.org/show_bug.cgi?id=46224

  • WebCoreSupport/WebInspectorClientCF.cpp: (WebInspectorClient::sendMessageToFrontend):

2010-10-18 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Simon Fraser.

Web Inspector: [crash] when Inspector Open in CSSStyleSelector::loadPendingImages().
https://bugs.webkit.org/show_bug.cgi?id=46224

  • WebCoreSupport/InspectorClientGtk.cpp: (WebKit::InspectorClient::sendMessageToFrontend):

2010-10-18 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Simon Fraser.

Web Inspector: [crash] when Inspector Open in CSSStyleSelector::loadPendingImages().
https://bugs.webkit.org/show_bug.cgi?id=46224

  • WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorClientQt::sendMessageToFrontend):
10:07 Changeset [69967] by alex@webkit.org
  • 2 edits in trunk/LayoutTests

2010-10-18 Alejandro G. Castro <alex@igalia.com>

Unreviewed, skip test failing in the bots, bug opened to check the
problem: https://bugs.webkit.org/show_bug.cgi?id=47832

  • platform/gtk/Skipped:
09:48 Changeset [69966] by noam.rosenthal@nokia.com
  • 3 edits in trunk/WebKit/qt

2010-10-18 No'am Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Andreas Kling.

[Qt] AC rendering bugs

This fixes a regression that was introduced by making scrolling in accelerated compositing automatic,
which made our explicit function to scroll the compositing layers superfluous, making the scrolling behavior
when graphics layers are present incorrect. The fix simply removes those redundant functions.

https://bugs.webkit.org/show_bug.cgi?id=47571

  • WebCoreSupport/PageClientQt.cpp: (WebCore::PageClientQGraphicsWidget::scroll): (WebCore::PageClientQGraphicsWidget::update): (WebCore::PageClientQGraphicsWidget::setRootGraphicsLayer):
  • WebCoreSupport/PageClientQt.h:
09:47 Changeset [69965] by oliver@apple.com
  • 5 edits in trunk

2010-10-18 Oliver Hunt <oliver@apple.com>

Reviewed by Sam Weinig.

Strict mode: JIT doesn't check for |this| being an immediate before dereferencing
https://bugs.webkit.org/show_bug.cgi?id=47826

There's no guarantee that |this| will be a cell in a strict mode function, so
don't claim that it is.

  • bytecode/CodeBlock.h: (JSC::CodeBlock::isKnownNotImmediate):

2010-10-18 Oliver Hunt <oliver@apple.com>

Reviewed by Sam Weinig.

Strict mode: JIT doesn't check for |this| being an immediate before dereferencing
https://bugs.webkit.org/show_bug.cgi?id=47826

Add tests for accessing properties on |this| when |this| is not an object

  • fast/js/basic-strict-mode-expected.txt:
  • fast/js/script-tests/basic-strict-mode.js: (testThisDotAccess): (testThisBracketAccess):
09:35 Changeset [69964] by andreip@google.com
  • 3 edits
    1 delete in trunk/WebCore

2010-10-18 Andrei Popescu <andreip@google.com>

Reviewed by Jeremy Orlow.

IDBKeyTree.h is no longer used.
https://bugs.webkit.org/show_bug.cgi?id=47824

No new tests, just removing unused files.

  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • storage/IDBKeyTree.h: Removed.
09:30 Changeset [69963] by zherczeg@webkit.org
  • 5 edits in trunk

2010-10-18 Zoltan Herczeg <zherczeg@webkit.org>

Reviewed by Oliver Hunt.

if (0) throw "x" ; else { } throws parse error after r69906
https://bugs.webkit.org/show_bug.cgi?id=47807

r69906 introduced a bug: the semicolon is not parsed after a throw
expression anymore. Thus, the semicolon terminates the "if" parsing
in the example above, and the else token results a parse error.

  • parser/JSParser.cpp: (JSC::JSParser::parseThrowStatement):

2010-10-18 Zoltan Herczeg <zherczeg@webkit.org>

Reviewed by Oliver Hunt.

if (0) throw "x" ; else { } throws parse error after r69906
https://bugs.webkit.org/show_bug.cgi?id=47807

Adding a new test case to break-ASI.js

  • fast/js/break-ASI-expected.txt:
  • fast/js/script-tests/break-ASI.js:
09:16 Changeset [69962] by jocelyn.turcotte@nokia.com
  • 2 edits in trunk/WebKit/qt

[Qt] Fix the build with MSVC.

Reviewed by nobody, build fix.

Splitting the condition in two to prevent qmake parentheses issues.

  • Api/DerivedSources.pro:
08:41 Changeset [69961] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-10-18 Yi Shen <yi.4.shen@nokia.com>

Reviewed by Antonio Gomes.

[QT] Unable to load pages on QtTestBrowser after canceling a page load.
https://bugs.webkit.org/show_bug.cgi?id=43827

  • Api/qwebpage.cpp: (QWebPage::triggerAction):
08:39 Changeset [69960] by andreas.kling@nokia.com
  • 2 edits in trunk/WebCore

2010-10-18 Andreas Kling <kling@webkit.org>

Unreviewed buildfix for Qt + V8.
Add missing <wtf/text/CString.h> include.

  • inspector/InspectorInstrumentation.cpp:
08:24 Changeset [69959] by loislo@chromium.org
  • 2 edits in trunk/WebCore

2010-10-18 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: toJSON serialization for Numbers should be fixed.
DecimalNumber is used instead of printf.

https://bugs.webkit.org/show_bug.cgi?id=43832

  • inspector/InspectorValues.cpp: (WebCore::InspectorBasicValue::writeJSON):
06:29 Changeset [69958] by ossy@webkit.org
  • 1 edit
    107 adds in trunk/LayoutTests

[Qt] Add platform specific expected results for new passing tests.
Compared to Mac png files and Mac expected files.

  • platform/qt/editing/input: Added.
  • platform/qt/editing/input/emacs-ctrl-o-expected.checksum: Added.
  • platform/qt/editing/input/emacs-ctrl-o-expected.png: Added.
  • platform/qt/editing/input/emacs-ctrl-o-expected.txt: Added.
  • platform/qt/fast/blockflow: Added.
  • platform/qt/fast/blockflow/block-level-images-expected.checksum: Added.
  • platform/qt/fast/blockflow/block-level-images-expected.png: Added.
  • platform/qt/fast/blockflow/block-level-images-expected.txt: Added.
  • platform/qt/fast/blockflow/fieldsets-expected.checksum: Added.
  • platform/qt/fast/blockflow/fieldsets-expected.png: Added.
  • platform/qt/fast/blockflow/fieldsets-expected.txt: Added.
  • platform/qt/fast/blockflow/floats-in-block-layout-expected.checksum: Added.
  • platform/qt/fast/blockflow/floats-in-block-layout-expected.png: Added.
  • platform/qt/fast/blockflow/floats-in-block-layout-expected.txt: Added.
  • platform/qt/fast/blockflow/inline-direction-positioning-expected.checksum: Added.
  • platform/qt/fast/blockflow/inline-direction-positioning-expected.png: Added.
  • platform/qt/fast/blockflow/inline-direction-positioning-expected.txt: Added.
  • platform/qt/fast/blockflow/margin-collapse-expected.checksum: Added.
  • platform/qt/fast/blockflow/margin-collapse-expected.png: Added.
  • platform/qt/fast/blockflow/margin-collapse-expected.txt: Added.
  • platform/qt/fast/blockflow/root-lr-basic-expected.checksum: Added.
  • platform/qt/fast/blockflow/root-lr-basic-expected.png: Added.
  • platform/qt/fast/blockflow/root-lr-basic-expected.txt: Added.
  • platform/qt/fast/blockflow/self-collapsing-block-expected.checksum: Added.
  • platform/qt/fast/blockflow/self-collapsing-block-expected.png: Added.
  • platform/qt/fast/blockflow/self-collapsing-block-expected.txt: Added.
  • platform/qt/fast/css/first-letter-punctuation-expected.checksum: Added.
  • platform/qt/fast/css/first-letter-punctuation-expected.png: Added.
  • platform/qt/fast/css/first-letter-punctuation-expected.txt: Added.
  • platform/qt/fast/css/preserve-user-specified-zoom-level-on-reload-expected.checksum: Added.
  • platform/qt/fast/css/preserve-user-specified-zoom-level-on-reload-expected.png: Added.
  • platform/qt/fast/css/preserve-user-specified-zoom-level-on-reload-expected.txt: Added.
  • platform/qt/fast/css/rtl-to-viewport-expected.checksum: Added.
  • platform/qt/fast/css/rtl-to-viewport-expected.png: Added.
  • platform/qt/fast/css/rtl-to-viewport-expected.txt: Added.
  • platform/qt/fast/forms/input-button-sizes-expected.checksum: Added.
  • platform/qt/fast/forms/input-button-sizes-expected.png: Added.
  • platform/qt/fast/forms/input-button-sizes-expected.txt: Added.
  • platform/qt/fast/forms/input-placeholder-focus-twice-expected.checksum: Added.
  • platform/qt/fast/forms/input-placeholder-focus-twice-expected.png: Added.
  • platform/qt/fast/forms/input-placeholder-focus-twice-expected.txt: Added.
  • platform/qt/fast/images/gif-large-checkerboard-expected.checksum: Added.
  • platform/qt/fast/images/gif-large-checkerboard-expected.png: Added.
  • platform/qt/fast/images/gif-large-checkerboard-expected.txt: Added.
  • platform/qt/fast/multicol/border-padding-pagination-expected.checksum: Added.
  • platform/qt/fast/multicol/border-padding-pagination-expected.png: Added.
  • platform/qt/fast/multicol/border-padding-pagination-expected.txt: Added.
  • platform/qt/fast/multicol/column-break-with-balancing-expected.checksum: Added.
  • platform/qt/fast/multicol/column-break-with-balancing-expected.png: Added.
  • platform/qt/fast/multicol/column-break-with-balancing-expected.txt: Added.
  • platform/qt/fast/multicol/float-paginate-complex-expected.checksum: Added.
  • platform/qt/fast/multicol/float-paginate-complex-expected.png: Added.
  • platform/qt/fast/multicol/float-paginate-complex-expected.txt: Added.
  • platform/qt/fast/multicol/margin-collapse-expected.checksum: Added.
  • platform/qt/fast/multicol/margin-collapse-expected.png: Added.
  • platform/qt/fast/multicol/margin-collapse-expected.txt: Added.
  • platform/qt/fast/multicol/shadow-breaking-expected.checksum: Added.
  • platform/qt/fast/multicol/shadow-breaking-expected.png: Added.
  • platform/qt/fast/multicol/shadow-breaking-expected.txt: Added.
  • platform/qt/fast/multicol/table-margin-collapse-expected.checksum: Added.
  • platform/qt/fast/multicol/table-margin-collapse-expected.png: Added.
  • platform/qt/fast/multicol/table-margin-collapse-expected.txt: Added.
  • platform/qt/fast/multicol/table-vertical-align-expected.checksum: Added.
  • platform/qt/fast/multicol/table-vertical-align-expected.png: Added.
  • platform/qt/fast/multicol/table-vertical-align-expected.txt: Added.
  • platform/qt/fast/multicol/unsplittable-inline-block-expected.checksum: Added.
  • platform/qt/fast/multicol/unsplittable-inline-block-expected.png: Added.
  • platform/qt/fast/multicol/unsplittable-inline-block-expected.txt: Added.
  • platform/qt/fast/repaint/block-layout-inline-children-replaced-expected.checksum: Added.
  • platform/qt/fast/repaint/block-layout-inline-children-replaced-expected.png: Added.
  • platform/qt/fast/repaint/block-layout-inline-children-replaced-expected.txt: Added.
  • platform/qt/scrollbars: Added.
  • platform/qt/scrollbars/custom-scrollbar-with-incomplete-style-expected.checksum: Added.
  • platform/qt/scrollbars/custom-scrollbar-with-incomplete-style-expected.png: Added.
  • platform/qt/scrollbars/custom-scrollbar-with-incomplete-style-expected.txt: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.checksum: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.checksum: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.png: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.txt: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.checksum: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.png: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.txt: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.checksum: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.png: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt: Added.
  • platform/qt/svg/custom/fill-opacity-hsl-expected.checksum: Added.
  • platform/qt/svg/custom/fill-opacity-hsl-expected.png: Added.
  • platform/qt/svg/custom/fill-opacity-hsl-expected.txt: Added.
  • platform/qt/svg/custom/fill-opacity-rgba-expected.checksum: Added.
  • platform/qt/svg/custom/fill-opacity-rgba-expected.png: Added.
  • platform/qt/svg/custom/fill-opacity-rgba-expected.txt: Added.
  • platform/qt/svg/custom/recursive-filter-expected.checksum: Added.
  • platform/qt/svg/custom/recursive-filter-expected.png: Added.
  • platform/qt/svg/custom/recursive-filter-expected.txt: Added.
  • platform/qt/svg/custom/repaint-on-constant-size-change-expected.checksum: Added.
  • platform/qt/svg/custom/repaint-on-constant-size-change-expected.png: Added.
  • platform/qt/svg/custom/repaint-on-constant-size-change-expected.txt: Added.
  • platform/qt/svg/custom/text-rotation-expected.checksum: Added.
  • platform/qt/svg/custom/text-rotation-expected.png: Added.
  • platform/qt/svg/custom/text-rotation-expected.txt: Added.
  • platform/qt/svg/custom/text-x-dy-lists-expected.checksum: Added.
  • platform/qt/svg/custom/text-x-dy-lists-expected.png: Added.
  • platform/qt/svg/custom/text-x-dy-lists-expected.txt: Added.
  • platform/qt/svg/in-html/by-reference-expected.txt: Added.
06:20 Changeset [69957] by commit-queue@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-10-18 Peter Varga <pvarga@inf.u-szeged.hu>

Reviewed by Andreas Kling.

Remove some unnecessary lines of code from Parser.cpp
https://bugs.webkit.org/show_bug.cgi?id=47816

  • parser/Parser.cpp:
05:46 Changeset [69956] by loislo@chromium.org
  • 2 edits in trunk/WebCore

2010-10-18 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [REGRESSION] Inspector window visible during run-webkit-tests.
The initial state of an inspector setting should stay untouched
if the profile has no value for it.

https://bugs.webkit.org/show_bug.cgi?id=47785

  • inspector/InspectorState.cpp: (WebCore::InspectorState::loadFromSettings):
05:43 Styling Form Controls edited by morrita@google.com
(diff)
05:42 Styling Form Controls edited by morrita@google.com
(diff)
05:41 Styling Form Controls edited by morrita@google.com
(diff)
05:33 custom-progress.png attached to Styling Form Controls by morrita@google.com
A <progress> screenshot
05:33 custom-meter.png attached to Styling Form Controls by morrita@google.com
A <meter> screenshot
05:32 Styling Form Controls created by morrita@google.com
05:29 Changeset [69955] by levin@chromium.org
  • 2 edits in trunk/WebKitTools

2010-10-18 David Levin <levin@chromium.org>

Reviewed by Adam Barth.

check-webkit-style should treat the GObject binding directory like other GTK directories.
https://bugs.webkit.org/show_bug.cgi?id=47796

  • Scripts/webkitpy/style/checker.py: Added the GObject binding directory with the other gtk directories (and fixed typo).
05:24 WikiStart edited by morrita@google.com
(diff)
05:13 Changeset [69954] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2010-10-18 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: tab headers on resource panel are 1px off on Mac.
https://bugs.webkit.org/show_bug.cgi?id=47798

  • inspector/front-end/inspector.css: (.tabbed-pane-header li):
04:57 Changeset [69953] by levin@chromium.org
  • 4 edits in trunk/WebKitTools

2010-10-18 David Levin <levin@chromium.org>

Reviewed by Oliver Hunt.

check-webkit-style needs to ignore underscores in opcode names and vm_throw
https://bugs.webkit.org/show_bug.cgi?id=47789

  • Scripts/webkitpy/style/checker.py: Added the exception for the assembler directory.
  • Scripts/webkitpy/style/checkers/cpp.py: Added special cased names.
  • Scripts/webkitpy/style/checkers/cpp_unittest.py: Added unit tests for the special cases.
04:46 Changeset [69952] by morrita@google.com
  • 20 edits in trunk

2010-10-18 MORITA Hajime <morrita@google.com>

Reviewed by Kent Tamura.

TextInputController.hasSpellingMarkers() should be owned by LayoutTestController
https://bugs.webkit.org/show_bug.cgi?id=47659

Changed the reciever of hasSpellingMarkers from
textInputController to layoutTestController.

  • editing/spelling/design-mode-spellcheck-off.html:
  • editing/spelling/script-tests/spelling-backspace-between-lines.js: (testWithDelete): (testWithForwardDelete):
  • editing/spelling/spelling-backspace-between-lines-expected.txt:
  • editing/spelling/spelling-contenteditable.html:
  • editing/spelling/spelling-textarea.html:

2010-10-18 MORITA Hajime <morrita@google.com>

Reviewed by Kent Tamura.

TextInputController.hasSpellingMarkers() should be owned by LayoutTestController
https://bugs.webkit.org/show_bug.cgi?id=47659

Moved hasSpellingMarkers() from TextInputController to
LayoutTestController. Currently the implementation is available
only for Mac and for Chromium.

  • DumpRenderTree/LayoutTestController.cpp: (hasSpellingMarkerCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::hasSpellingMarker):
  • DumpRenderTree/chromium/LayoutTestController.h:
  • DumpRenderTree/chromium/TextInputController.cpp: (TextInputController::TextInputController): (TextInputController::makeAttributedString):
  • DumpRenderTree/chromium/TextInputController.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::hasSpellingMarker):
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::hasSpellingMarker):
  • DumpRenderTree/mac/TextInputController.m: (+[TextInputController isSelectorExcludedFromWebScript:]): (+[TextInputController webScriptNameForSelector:]):
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::hasSpellingMarker):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::hasSpellingMarker):
  • DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::hasSpellingMarker):
04:42 Changeset [69951] by abarth@webkit.org
  • 3 edits in trunk/WebKitTools

2010-10-18 Adam Barth <abarth@webkit.org>

Reviewed by David Levin.

commit-queue's flaky test notice is very Pythony
https://bugs.webkit.org/show_bug.cgi?id=47790

This patch make the list of tests delimted by \n instead of just
converting the array to a string.

  • Scripts/webkitpy/tool/commands/queues.py:
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
03:42 Changeset [69950] by alex@webkit.org
  • 2 edits in trunk/LayoutTests

2010-10-18 Alejandro G. Castro <alex@igalia.com>

Unreviewed, skip another mathml flaky test, check bug:
https://bugs.webkit.org/show_bug.cgi?id=47727

  • platform/gtk/Skipped:
03:39 Changeset [69949] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2010-10-18 Pavel Feldman <pfeldman@chromium.org>

Not reviewed. Build fix.

  • inspector/InspectorResourceAgent.cpp: (WebCore::cachedResourceTypeString):
03:14 Changeset [69948] by pfeldman@chromium.org
  • 27 edits
    1 add in trunk

2010-10-17 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Introduce InspectorResourceAgent.h/cpp and ResourceManager.js to
fill network panel with data.
https://bugs.webkit.org/show_bug.cgi?id=47779


InspectorResourceAgent instance / JS part are introduced in this patch. Agent's lifetime is equal
to the front-end's. This new resource agent does not have state, instead it covers two functions:

1) forwards loader client messages to the front-end 2) is capable of building a tree of cached resources.

(1) feeds network panel with data, (2) shows the resource tree in the new ResourcesPanel concept.
This bug is for extracting this new InspectorResourceAgent class and its javascript counterpart.
Once resources panel is refactored for the new concept, InspectorResource, InspectorController's
resource-related routines, inspector.js's code dealing with resources, they all will be gone.

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/CodeGeneratorInspector.pm:
  • inspector/Inspector.idl:
  • inspector/InspectorApplicationCacheAgent.cpp: (WebCore::InspectorApplicationCacheAgent::didReceiveManifestResponse):
  • inspector/InspectorController.cpp: (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::releaseFrontendLifetimeAgents): (WebCore::InspectorController::didCommitLoad): (WebCore::InspectorController::frameDetachedFromParent): (WebCore::InspectorController::didLoadResourceFromMemoryCache): (WebCore::InspectorController::identifierForInitialRequest): (WebCore::InspectorController::willSendRequest): (WebCore::InspectorController::markResourceAsCached): (WebCore::InspectorController::didReceiveResponse): (WebCore::InspectorController::didReceiveContentLength): (WebCore::InspectorController::didFinishLoading): (WebCore::InspectorController::didFailLoading): (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest): (WebCore::InspectorController::scriptImported): (WebCore::InspectorController::didCreateWebSocket): (WebCore::InspectorController::willSendWebSocketHandshakeRequest): (WebCore::InspectorController::didReceiveWebSocketHandshakeResponse): (WebCore::InspectorController::didCloseWebSocket):
  • inspector/InspectorController.h:
  • inspector/InspectorResource.cpp: (WebCore::InspectorResource::updateResponse): (WebCore::cachedResourceType): (WebCore::InspectorResource::type): (WebCore::InspectorResource::sourceString): (WebCore::InspectorResource::sourceBytes): (WebCore::InspectorResource::endTiming):
  • inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::resourceContent): (WebCore::InspectorResourceAgent::resourceContentBase64): (WebCore::InspectorResourceAgent::resourceData): (WebCore::InspectorResourceAgent::cachedResource): (WebCore::buildObjectForHeaders): (WebCore::buildObjectForTiming): (WebCore::buildObjectForResourceRequest): (WebCore::buildObjectForResourceResponse): (WebCore::buildObjectForMainResource): (WebCore::cachedResourceTypeString): (WebCore::buildObjectForCachedResource): (WebCore::buildObjectForFrameResources): (WebCore::InspectorResourceAgent::~InspectorResourceAgent): (WebCore::InspectorResourceAgent::identifierForInitialRequest): (WebCore::InspectorResourceAgent::willSendRequest): (WebCore::InspectorResourceAgent::markResourceAsCached): (WebCore::InspectorResourceAgent::didReceiveResponse): (WebCore::InspectorResourceAgent::didReceiveContentLength): (WebCore::InspectorResourceAgent::didFinishLoading): (WebCore::InspectorResourceAgent::didFailLoading): (WebCore::InspectorResourceAgent::didLoadResourceFromMemoryCache): (WebCore::InspectorResourceAgent::setOverrideContent): (WebCore::InspectorResourceAgent::didCommitLoad): (WebCore::InspectorResourceAgent::frameDetachedFromParent): (WebCore::createReadableStringFromBinary): (WebCore::InspectorResourceAgent::didCreateWebSocket): (WebCore::InspectorResourceAgent::willSendWebSocketHandshakeRequest): (WebCore::InspectorResourceAgent::didReceiveWebSocketHandshakeResponse): (WebCore::InspectorResourceAgent::didCloseWebSocket): (WebCore::InspectorResourceAgent::cachedResources): (WebCore::InspectorResourceAgent::InspectorResourceAgent):
  • inspector/InspectorResourceAgent.h: (WebCore::InspectorResourceAgent::create):
  • inspector/InspectorStyleSheet.cpp: (WebCore::InspectorStyleSheet::resourceStyleSheetText):
  • inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer.prototype._onRevealAndSelectResource): (WebInspector.ExtensionServer.prototype._onGetResourceContent):
  • inspector/front-end/Resource.js: (WebInspector.Resource.prototype.get responseReceivedTime): (WebInspector.Resource.prototype.set endTime):
  • inspector/front-end/Settings.js:
  • inspector/front-end/SourceView.js: (WebInspector.SourceView.prototype.setupSourceFrameIfNeeded):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.css: (.tabbed-pane-header li):
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js: (WebInspector.updateResource):
  • loader/ResourceLoadNotifier.cpp: (WebCore::ResourceLoadNotifier::dispatchDidReceiveResponse):
  • loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::didReceiveResponse):

2010-10-17 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Introduce InspectorResourceAgent.h/cpp and ResourceManager.js to
fill network panel with data.
https://bugs.webkit.org/show_bug.cgi?id=47779

  • src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::didReceiveResponse):
02:18 Changeset [69947] by pfeldman@chromium.org
  • 11 edits in trunk

2010-10-16 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: brush up URL parsing on the front-end.
https://bugs.webkit.org/show_bug.cgi?id=47772

  • inspector/InspectorResource.cpp: (WebCore::InspectorResource::updateScriptObject):
  • inspector/front-end/AuditRules.js: (WebInspector.AuditRules.getDomainToResourcesMap): (WebInspector.AuditRules.CombineExternalResourcesRule.prototype.doRun): (WebInspector.AuditRules.MinimizeDnsLookupsRule.prototype.doRun): (WebInspector.AuditRules.ParallelizeDownloadRule.prototype.doRun): (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun): (WebInspector.AuditRules.CookieSizeRule.prototype.processCookies): (WebInspector.AuditRules.StaticCookielessRule.prototype.processCookies):
  • inspector/front-end/CookieItemsView.js: (WebInspector.CookieItemsView.prototype._filterCookiesForDomain):
  • inspector/front-end/DOMAgent.js: (WebInspector.Cookies.cookieMatchesResourceURL):
  • inspector/front-end/Resource.js: (WebInspector.Resource): (WebInspector.Resource.prototype.set url): (WebInspector.Resource.prototype.get displayName):
  • inspector/front-end/ResourceCategory.js: (WebInspector.ResourceCategory.prototype.addResource):
  • inspector/front-end/ResourceView.js: (WebInspector.ResourceView):
  • inspector/front-end/inspector.js: (WebInspector.documentClick.followLink): (WebInspector.documentClick): (WebInspector.updateResource): (WebInspector.linkifyStringAsFragment): (WebInspector.resourceURLForRelatedNode): (WebInspector.completeURL):
  • inspector/front-end/utilities.js: (String.prototype.asParsedURL):
01:15 Changeset [69946] by andreas.kling@nokia.com
  • 3 edits in trunk/WebCore

2010-10-17 Andreas Kling <kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Support custom open() verbs/methods in XMLHttpRequest
https://bugs.webkit.org/show_bug.cgi?id=40476

Fall back to QNetworkAccessManager::CustomOperation for any HTTP verb
that's not specifically supported by QNetworkAccessManager.

This prevents the infinite loop that otherwise occurs after sending
an UnknownOperation request.

This change is covered by existing (skipped) tests that will be
unskipped once the Qt bots are running Qt 4.7.

  • platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::httpMethod): (WebCore::QNetworkReplyHandler::QNetworkReplyHandler): (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
  • platform/network/qt/QNetworkReplyHandler.h:
00:53 Changeset [69945] by abarth@webkit.org
  • 5 edits in trunk/LayoutTests

2010-10-18 Adam Barth <abarth@webkit.org>

Add more Skipped list entries because WebP requires an external decoder
library.

  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
00:39 Changeset [69944] by xan@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-10-18 Xan Lopez <xlopez@igalia.com>

Reviewed by Csaba Osztrogonác.

Build broken with JIT disabled
https://bugs.webkit.org/show_bug.cgi?id=47801

This is a regression caused by r69940.

  • interpreter/Interpreter.cpp: (JSC::Interpreter::resolveBase):
00:25 Changeset [69943] by zoltan@webkit.org
  • 2 edits in trunk/JavaScriptCore

Change FastAllocBase implementation into a macro
https://bugs.webkit.org/show_bug.cgi?id=42998

Reviewed by Darin Adler.

It was investigated in bug #33896 that inheriting classes from FastAllocBase
can result in objects getting larger which leads to memory regressions.
Using a macro instead of inheriting classes from FastAllocBase would solve the issue.

  • wtf/FastAllocBase.h: Add a WTF_MAKE_FAST_ALLOCATED macro

10/17/10:

23:51 Changeset [69942] by commit-queue@webkit.org
  • 11 edits
    6 adds in trunk

2010-10-17 Pascal Massimino <pascal.massimino@gmail.com>

Reviewed by Adam Barth.

Add support for WebP image decoding in ImageDecoder
using library libwebp-decode library available from
http://www.webmproject.org/code/

https://bugs.webkit.org/show_bug.cgi?id=47512

Tests: fast/images/webp-image-decoding.html

  • CMakeLists.txt:

add platform/image-decoders/webp files and directory

  • GNUmakefile.am:

add platform/image-decoders/webp directory

  • WebCore.gyp/WebCore.gyp:

add platform/image-decoders/webp directory

  • WebCore.gypi:

add platform/image-decoders/webp directory

  • features.gypi:

add WTF_USE_WEBP=1

  • platform/image-decoders/ImageDecoder.cpp: (WebCore::ImageDecoder::create):

instantiate webp decoder for file starting with 'RIFF????WEBP'

  • platform/image-decoders/webp: Added.
  • platform/image-decoders/webp/WEBPImageDecoder.cpp: Added. (WebCore::WEBPImageDecoder::WEBPImageDecoder): (WebCore::WEBPImageDecoder::~WEBPImageDecoder): (WebCore::WEBPImageDecoder::isSizeAvailable): (WebCore::WEBPImageDecoder::frameBufferAtIndex): (WebCore::WEBPImageDecoder::decode):

sub-class handling decoding of webp images

  • platform/image-decoders/webp/WEBPImageDecoder.h: Added. (WebCore::WEBPImageDecoder::filenameExtension): (WebCore::WEBPImageDecoder::supportsAlpha):

header for webp-decoder sub-class

2010-10-17 Pascal Massimino <pascal.massimino@gmail.com>

Reviewed by Adam Barth.


Add support for decoding WebP image
https://bugs.webkit.org/show_bug.cgi?id=47512


  • DEPS:
    • Add dependency to libwebp.
22:42 Changeset [69941] by oliver@apple.com
  • 5 edits in trunk

2010-10-17 Oliver Hunt <oliver@apple.com>

Reviewed by Sam Weinig.

Strict mode: arguments is not valid as the base expression for pre- or post-fix expressions
https://bugs.webkit.org/show_bug.cgi?id=47791

Simple fix, check for arguments in addition to eval.

  • parser/JSParser.cpp: (JSC::JSParser::parseUnaryExpression):

2010-10-17 Oliver Hunt <oliver@apple.com>

Reviewed by Sam Weinig.

Strict mode: arguments is not valid as the base expression for pre- or post-fix expressions
https://bugs.webkit.org/show_bug.cgi?id=47791

Add arguments tests, and make pre-/post-fix expression tests cover another case I was
needlessly worried about.

  • fast/js/basic-strict-mode-expected.txt:
  • fast/js/script-tests/basic-strict-mode.js:
21:08 Changeset [69940] by oliver@apple.com
  • 20 edits in trunk

2010-10-17 Oliver Hunt <oliver@apple.com>

Reviewed by Sam Weinig.

Strict mode: Assignment that would create a global should be a late ReferenceError, not a syntax failure
https://bugs.webkit.org/show_bug.cgi?id=47788

Fixing this required a couple of changes:

  • resolve_base now has a flag to indicate whether it is being used for a put in strict mode. this allows us to throw an exception when we're doing a completely generic resolve for assignment, and that assignment would create a new global.
  • There is a new opcode 'op_ensure_property_exists' that is used to determine whether the property being assigned to already exists on the global object. This currently has no caching, but such caching could be added relatively trivially. It is only used in the case where we know that a property will be placed on the global object, and we cannot verify that the property already exists.

In the jit we plant a call to cti_op_resolve_base_strict_put in the effected case rather
than making op_resolve_base have an additional runtime branch.

There's also a new helper function to create the exception for the invalid assignment.

  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::dump):
  • bytecode/Opcode.h:
  • bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::emitResolveBase): (JSC::BytecodeGenerator::emitResolveBaseForPut):
  • bytecompiler/BytecodeGenerator.h:
  • bytecompiler/NodesCodegen.cpp: (JSC::AssignResolveNode::emitBytecode): (JSC::ForInNode::emitBytecode):
  • interpreter/Interpreter.cpp: (JSC::Interpreter::resolveBase): (JSC::Interpreter::privateExecute):
  • jit/JIT.cpp: (JSC::JIT::privateCompileMainPass):
  • jit/JIT.h:
  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_resolve_base): (JSC::JIT::emit_op_ensure_property_exists):
  • jit/JITOpcodes32_64.cpp: (JSC::JIT::emit_op_resolve_base): (JSC::JIT::emit_op_ensure_property_exists):
  • jit/JITStubs.cpp: (JSC::DEFINE_STUB_FUNCTION):
  • jit/JITStubs.h:
  • parser/JSParser.cpp: (JSC::JSParser::parseProgram):
  • runtime/ExceptionHelpers.cpp: (JSC::createErrorForInvalidGlobalAssignment):
  • runtime/ExceptionHelpers.h:
  • runtime/Operations.h: (JSC::resolveBase):

2010-10-17 Oliver Hunt <oliver@apple.com>

Reviewed by Sam Weinig.

Strict mode: Assignment that would create a global should be a late ReferenceError, not a syntax failure
https://bugs.webkit.org/show_bug.cgi?id=47788

Update test to check for the correct behaviour.

  • fast/js/basic-strict-mode-expected.txt:
  • fast/js/script-tests/basic-strict-mode.js:
21:02 Changeset [69939] by tonikitoo@webkit.org
  • 3 edits in trunk/LayoutTests

2010-10-17 Antonio Gomes <agomes@rim.com>

Reviewed by Simon Fraser.

Enrich /fast/dom/nodesFromRect-basic.html test
https://bugs.webkit.org/show_bug.cgi?id=47766

The patch makes fast/dom/nodesFromRect-basic.html test more precise:
instead of calling nodesFromRect always with equal vertical (up and down) and
horizontal (right and left) padding values, it are now tests it by passing
different padding values on the various directions.

It is now possible due to the work on bug 46336: Make Document::nodesFromRect more flexible.

  • fast/dom/nodesFromRect-basic-expected.txt:
  • fast/dom/nodesFromRect-basic.html:
19:59 Changeset [69938] by abarth@webkit.org
  • 9 edits in trunk/WebCore

2010-10-17 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Remove explicit passing of user gesture in NavigationScheduler
https://bugs.webkit.org/show_bug.cgi?id=47786

As requested by Mr. Glazkov, remove more explicit passing of the user
gesture state. We now use a static to pass this information around.

  • bindings/generic/BindingFrame.h: (WebCore::::navigateIfAllowed):
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::setLocation):
  • bindings/js/JSLocationCustom.cpp: (WebCore::JSLocation::reload):
  • bindings/v8/custom/V8LocationCustom.cpp: (WebCore::V8Location::reloadCallback):
  • inspector/InspectorController.cpp: (WebCore::InspectorController::setResourceTrackingEnabled): (WebCore::InspectorController::reloadPage):
  • loader/NavigationScheduler.cpp: (WebCore::ScheduledNavigation::ScheduledNavigation): (WebCore::ScheduledURLNavigation::ScheduledURLNavigation): (WebCore::ScheduledRedirect::ScheduledRedirect): (WebCore::ScheduledLocationChange::ScheduledLocationChange): (WebCore::ScheduledRefresh::ScheduledRefresh): (WebCore::ScheduledHistoryNavigation::ScheduledHistoryNavigation): (WebCore::ScheduledFormSubmission::ScheduledFormSubmission): (WebCore::NavigationScheduler::scheduleRedirect): (WebCore::NavigationScheduler::mustLockBackForwardList): (WebCore::NavigationScheduler::scheduleLocationChange): (WebCore::NavigationScheduler::scheduleFormSubmission): (WebCore::NavigationScheduler::scheduleRefresh): (WebCore::NavigationScheduler::scheduleHistoryNavigation):
  • loader/NavigationScheduler.h:
  • loader/SubframeLoader.cpp: (WebCore::SubframeLoader::loadOrRedirectSubframe):
18:22 Changeset [69937] by jchaffraix@webkit.org
  • 5 edits
    2 adds in trunk

WebCore: 'transparent' should be a valid color
https://bugs.webkit.org/show_bug.cgi?id=45482

Reviewed by Andreas Kling.

Test: svg/animations/svg-animate-color-transparent.svg

Based on previous work by Jan Erik Hanssen <jhanssen@codeaurora.org>

  • platform/ColorData.gperf: Added 'transparent' to the list of colors.

Added the alpha to all the colors as it was needed to support the new color.

  • platform/graphics/Color.cpp:

(WebCore::Color::Color):
(WebCore::Color::setNamedColor): Avoid setting the alpha as now it is not
always 0xFF.

LayoutTests: Test for: 'transparent' should be a valid color
https://bugs.webkit.org/show_bug.cgi?id=45482

Reviewed by Andreas Kling.

Test that animation works with 'transparent' as they check the validity of the
color.

  • svg/animations/svg-animate-color-transparent-expected.txt: Added.
  • svg/animations/svg-animate-color-transparent.svg: Added.
17:47 Changeset [69936] by jschuh@chromium.org
  • 3 edits
    2 adds in trunk

2010-10-17 Justin Schuh <jschuh@chromium.org>

Reviewed by Nikolas Zimmermann.

Duplicate use element children in shadow tree.
https://bugs.webkit.org/show_bug.cgi?id=47561

Test: svg/custom/use-nested-children.svg

  • svg/SVGUseElement.cpp: (WebCore::SVGUseElement::expandUseElementsInShadowTree):

2010-10-17 Justin Schuh <jschuh@chromium.org>

Reviewed by Nikolas Zimmermann.

Duplicate use element children in shadow tree.
https://bugs.webkit.org/show_bug.cgi?id=47561

  • svg/custom/use-nested-children-expected.txt: Added.
  • svg/custom/use-nested-children.svg: Added.
17:04 Changeset [69935] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-10-17 Hyung Song <beergun@company100.net>

Reviewed by David Levin.

Add !SINGLE_THREADED guard.
https://bugs.webkit.org/show_bug.cgi?id=47608

For SINGLE_THREADED ports LockingMutex.tryLock() returns false.
This will prevent interrupt() from falling into infinite loop.

  • platform/sql/SQLiteDatabase.cpp: (WebCore::SQLiteDatabase::interrupt):
15:05 Changeset [69934] by simon.fraser@apple.com
  • 1 edit
    1 delete in trunk/LayoutTests

2010-10-17 Simon Fraser <simon.fraser@apple.com>

Remove Windows-specific result, which is not longer needed after r69928.

  • platform/win/fast/css/large-number-round-trip-expected.txt: Removed.
14:55 Changeset [69933] by jorlow@chromium.org
  • 32 edits in branches/chromium/552

The names of IndexedDB-specific attributes of DOMWindow should be prefixed with 'webkit'.
https://bugs.webkit.org/show_bug.cgi?id=47508

BUG=59508

Patch by Andrei Popescu <andreip@google.com> on 2010-10-11
Reviewed by Jeremy Orlow.

LayoutTests:

  • storage/indexeddb/basics-expected.txt:
  • storage/indexeddb/basics.html:
  • storage/indexeddb/constants-expected.txt:
  • storage/indexeddb/constants.html:
  • storage/indexeddb/database-basics-expected.txt:
  • storage/indexeddb/database-basics.html:
  • storage/indexeddb/database-quota-expected.txt:
  • storage/indexeddb/database-quota.html:
  • storage/indexeddb/index-basics-expected.txt:
  • storage/indexeddb/index-basics.html:
  • storage/indexeddb/index-cursor-expected.txt:
  • storage/indexeddb/index-cursor.html:
  • storage/indexeddb/keyrange-expected.txt:
  • storage/indexeddb/keyrange.html:
  • storage/indexeddb/objectstore-basics-expected.txt:
  • storage/indexeddb/objectstore-basics.html:
  • storage/indexeddb/objectstore-cursor-expected.txt:
  • storage/indexeddb/objectstore-cursor.html:
  • storage/indexeddb/objectstore-removeobjectstore-expected.txt:
  • storage/indexeddb/objectstore-removeobjectstore.html:
  • storage/indexeddb/open-cursor-expected.txt:
  • storage/indexeddb/open-cursor.html:
  • storage/indexeddb/transaction-basics-expected.txt:
  • storage/indexeddb/transaction-basics.html:

WebCore:

  • bindings/generic/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::setWebkitIndexedDBEnabled):
(WebCore::RuntimeEnabledFeatures::webkitIndexedDBEnabled):
(WebCore::RuntimeEnabledFeatures::webkitIDBCursorEnabled):
(WebCore::RuntimeEnabledFeatures::webkitIDBDatabaseEnabled):
(WebCore::RuntimeEnabledFeatures::webkitIDBDatabaseErrorEnabled):
(WebCore::RuntimeEnabledFeatures::webkitIDBDatabaseExceptionEnabled):
(WebCore::RuntimeEnabledFeatures::webkitIDBErrorEventEnabled):
(WebCore::RuntimeEnabledFeatures::webkitIDBEventEnabled):
(WebCore::RuntimeEnabledFeatures::webkitIDBFactoryEnabled):
(WebCore::RuntimeEnabledFeatures::webkitIDBIndexEnabled):
(WebCore::RuntimeEnabledFeatures::webkitIDBKeyRangeEnabled):
(WebCore::RuntimeEnabledFeatures::webkitIDBObjectStoreEnabled):
(WebCore::RuntimeEnabledFeatures::webkitIDBRequestEnabled):
(WebCore::RuntimeEnabledFeatures::webkitIDBSuccessEventEnabled):
(WebCore::RuntimeEnabledFeatures::webkitIDBTransactionEnabled):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::webkitIndexedDB):

  • page/DOMWindow.h:
  • page/DOMWindow.idl:

WebKit/chromium:

  • src/WebRuntimeFeatures.cpp:

(WebKit::WebRuntimeFeatures::enableIndexedDatabase):
(WebKit::WebRuntimeFeatures::isIndexedDatabaseEnabled):
Merge 69540 - 2010-10-11 Andrei Popescu <andreip@google.com>

Reviewed by Jeremy Orlow.

The names of IndexedDB-specific attributes of DOMWindow should be prefixed with 'webkit'.
https://bugs.webkit.org/show_bug.cgi?id=47508

  • storage/indexeddb/basics-expected.txt:
  • storage/indexeddb/basics.html:
  • storage/indexeddb/constants-expected.txt:
  • storage/indexeddb/constants.html:
  • storage/indexeddb/database-basics-expected.txt:
  • storage/indexeddb/database-basics.html:
  • storage/indexeddb/database-quota-expected.txt:
  • storage/indexeddb/database-quota.html:
  • storage/indexeddb/index-basics-expected.txt:
  • storage/indexeddb/index-basics.html:
  • storage/indexeddb/index-cursor-expected.txt:
  • storage/indexeddb/index-cursor.html:
  • storage/indexeddb/keyrange-expected.txt:
  • storage/indexeddb/keyrange.html:
  • storage/indexeddb/objectstore-basics-expected.txt:
  • storage/indexeddb/objectstore-basics.html:
  • storage/indexeddb/objectstore-cursor-expected.txt:
  • storage/indexeddb/objectstore-cursor.html:
  • storage/indexeddb/objectstore-removeobjectstore-expected.txt:
  • storage/indexeddb/objectstore-removeobjectstore.html:
  • storage/indexeddb/open-cursor-expected.txt:
  • storage/indexeddb/open-cursor.html:
  • storage/indexeddb/transaction-basics-expected.txt:
  • storage/indexeddb/transaction-basics.html:

2010-10-11 Andrei Popescu <andreip@google.com>

Reviewed by Jeremy Orlow.

The names of IndexedDB-specific attributes of DOMWindow should be prefixed with 'webkit'.
https://bugs.webkit.org/show_bug.cgi?id=47508

  • bindings/generic/RuntimeEnabledFeatures.h: (WebCore::RuntimeEnabledFeatures::setWebkitIndexedDBEnabled): (WebCore::RuntimeEnabledFeatures::webkitIndexedDBEnabled): (WebCore::RuntimeEnabledFeatures::webkitIDBCursorEnabled): (WebCore::RuntimeEnabledFeatures::webkitIDBDatabaseEnabled): (WebCore::RuntimeEnabledFeatures::webkitIDBDatabaseErrorEnabled): (WebCore::RuntimeEnabledFeatures::webkitIDBDatabaseExceptionEnabled): (WebCore::RuntimeEnabledFeatures::webkitIDBErrorEventEnabled): (WebCore::RuntimeEnabledFeatures::webkitIDBEventEnabled): (WebCore::RuntimeEnabledFeatures::webkitIDBFactoryEnabled): (WebCore::RuntimeEnabledFeatures::webkitIDBIndexEnabled): (WebCore::RuntimeEnabledFeatures::webkitIDBKeyRangeEnabled): (WebCore::RuntimeEnabledFeatures::webkitIDBObjectStoreEnabled): (WebCore::RuntimeEnabledFeatures::webkitIDBRequestEnabled): (WebCore::RuntimeEnabledFeatures::webkitIDBSuccessEventEnabled): (WebCore::RuntimeEnabledFeatures::webkitIDBTransactionEnabled):
  • page/DOMWindow.cpp: (WebCore::DOMWindow::webkitIndexedDB):
  • page/DOMWindow.h:
  • page/DOMWindow.idl:

2010-10-11 Andrei Popescu <andreip@google.com>

Reviewed by Jeremy Orlow.

The names of IndexedDB-specific attributes of DOMWindow should be prefixed with 'webkit'.
https://bugs.webkit.org/show_bug.cgi?id=47508

  • src/WebRuntimeFeatures.cpp: (WebKit::WebRuntimeFeatures::enableIndexedDatabase): (WebKit::WebRuntimeFeatures::isIndexedDatabaseEnabled):

TBR=andreip@google.com

14:48 Changeset [69932] by jorlow@chromium.org
  • 3 edits in branches/chromium/552/LayoutTests

storage/indexeddb/database-quota.html expects the wrong database version string
https://bugs.webkit.org/show_bug.cgi?id=47533

BUG=59506

Patch by Andrei Popescu <andreip@google.com> on 2010-10-11
Reviewed by Jeremy Orlow.

  • storage/indexeddb/database-quota-expected.txt:
  • storage/indexeddb/database-quota.html:

Merge 69612 - 2010-10-11 Andrei Popescu <andreip@google.com>

Reviewed by Jeremy Orlow.

storage/indexeddb/database-quota.html expects the wrong database version string
https://bugs.webkit.org/show_bug.cgi?id=47533

  • storage/indexeddb/database-quota-expected.txt:
  • storage/indexeddb/database-quota.html:

TBR=andreip@google.com

14:46 Changeset [69931] by jorlow@chromium.org
  • 2 edits in branches/chromium/552/WebKit/chromium

[Chromium] Cleanup WebIDBFactory::open once the Chromium plumbing has landed.
https://bugs.webkit.org/show_bug.cgi?id=47531

BUG=59506

Patch by Andrei Popescu <andreip@google.com> on 2010-10-11
Reviewed by Jeremy Orlow.

Remove the temporary open() method since the appropriate Chromium plumbing was
added in http://codereview.chromium.org/3729003/

  • public/WebIDBFactory.h:

(WebKit::WebIDBFactory::open):
Merge 69670 - 2010-10-11 Andrei Popescu <andreip@google.com>

Reviewed by Jeremy Orlow.

[Chromium] Cleanup WebIDBFactory::open once the Chromium plumbing has landed.
https://bugs.webkit.org/show_bug.cgi?id=47531

Remove the temporary open() method since the appropriate Chromium plumbing was
added in http://codereview.chromium.org/3729003/

  • public/WebIDBFactory.h: (WebKit::WebIDBFactory::open):

TBR=andreip@google.com

14:44 Changeset [69930] by mrobinson@webkit.org
  • 11 edits in trunk/LayoutTests

2010-10-17 Martin Robinson <mrobinson@igalia.com>

Rebaseline MathML tests after r69926.

  • platform/gtk/mathml/presentation/attributes-expected.txt:
  • platform/gtk/mathml/presentation/fenced-mi-expected.txt:
  • platform/gtk/mathml/presentation/fractions-expected.txt:
  • platform/gtk/mathml/presentation/fractions-vertical-alignment-expected.txt:
  • platform/gtk/mathml/presentation/mo-expected.txt:
  • platform/gtk/mathml/presentation/row-alignment-expected.txt:
  • platform/gtk/mathml/presentation/row-expected.txt:
  • platform/gtk/mathml/presentation/style-expected.txt:
  • platform/gtk/mathml/presentation/tokenElements-expected.txt:
  • platform/gtk/mathml/presentation/underover-expected.txt:
13:40 Changeset [69929] by simon.fraser@apple.com
  • 2 edits in trunk/JavaScriptCore

2010-10-17 Simon Fraser <simon.fraser@apple.com>

First part of fix for Windows build failure. Will wait for the
next set of link errors to determine the mangled forms for dtoaRoundSF
and dtoaRoundDP.

13:05 Changeset [69928] by simon.fraser@apple.com
  • 12 edits
    2 adds
    1 delete in trunk

2010-10-17 Simon Fraser <simon.fraser@apple.com>

Reviewed by Nikolas Zimmermann.

Very large and small numbers fail to round-trip through CSS
https://bugs.webkit.org/show_bug.cgi?id=20674

Use the new DecimalNumber functionality to convert CSS numberic values to strings
using decimal notation, rather than %g (which can output scientific notation).

Test: fast/css/round-trip-values.html

  • css/CSSPrimitiveValue.cpp: (WebCore::formatNumber): (WebCore::CSSPrimitiveValue::cssText):
12:46 Changeset [69927] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

2010-10-17 Cosmin Truta <ctruta@chromium.org>

Reviewed by Nikolas Zimmermann.

Crash while processing ill-formed SVG with cycles
https://bugs.webkit.org/show_bug.cgi?id=47498

Checked the behavior of the attributes fill, stroke, clip and mask
when used with URLs that point to wrong elements.

  • svg/custom/invalid-paint-shape-mask.svg: Added.
  • svg/custom/invalid-paint-shape-mask-expected.svg: Added.

2010-10-17 Cosmin Truta <ctruta@chromium.org>

Reviewed by Nikolas Zimmermann.

Crash while processing ill-formed SVG with cycles
https://bugs.webkit.org/show_bug.cgi?id=47498

Test: svg/custom/invalid-paint-shape-mask.svg

  • rendering/SVGResources.cpp: (paintingResourceFromSVGPaint): Ensured that the painting resource is either a pattern resource or a gradient resource. (SVGResources::setClipper): (SVGResources::setFilter): (SVGResources::setMarkerStart): (SVGResources::setMarkerMid): (SVGResources::setMarkerEnd): (SVGResources::setMasker): (SVGResources::setFill): (SVGResources::setStroke): Added ASSERT statements for previously-unchecked preconditions.
11:44 Changeset [69926] by commit-queue@webkit.org
  • 26 edits in trunk

2010-10-17 Alex Milowski <alex@milowski.com>

Reviewed by Kenneth Rohde Christiansen.

Since whitespace and baseline alignment have changed for operators,
many tests needed to be re-baselined.

  • platform/mac/mathml/presentation/attributes-expected.checksum:
  • platform/mac/mathml/presentation/attributes-expected.png:
  • platform/mac/mathml/presentation/attributes-expected.txt:
  • platform/mac/mathml/presentation/fenced-expected.checksum:
  • platform/mac/mathml/presentation/fenced-expected.png:
  • platform/mac/mathml/presentation/fenced-expected.txt:
  • platform/mac/mathml/presentation/fractions-vertical-alignment-expected.checksum:
  • platform/mac/mathml/presentation/fractions-vertical-alignment-expected.png:
  • platform/mac/mathml/presentation/fractions-vertical-alignment-expected.txt:
  • platform/mac/mathml/presentation/mo-expected.checksum:
  • platform/mac/mathml/presentation/mo-expected.png:
  • platform/mac/mathml/presentation/mo-expected.txt:
  • platform/mac/mathml/presentation/roots-expected.checksum:
  • platform/mac/mathml/presentation/roots-expected.png:
  • platform/mac/mathml/presentation/roots-expected.txt:
  • platform/mac/mathml/presentation/row-alignment-expected.checksum:
  • platform/mac/mathml/presentation/row-alignment-expected.png:
  • platform/mac/mathml/presentation/row-alignment-expected.txt:
  • platform/mac/mathml/presentation/row-expected.checksum:
  • platform/mac/mathml/presentation/row-expected.png:
  • platform/mac/mathml/presentation/row-expected.txt:

2010-10-17 Alex Milowski <alex@milowski.com>

Reviewed by Kenneth Rohde Christiansen.

Fixed extra whitespace above operators when they aren't stretched
yet the stretch height is large. Also, the baseline alignment
was changed so that rows and operators interact appropriately now
that operators don't have the extra white space.

  • mathml/RenderMathMLOperator.cpp:
  • mathml/RenderMathMLRow.cpp:
11:19 Changeset [69925] by commit-queue@webkit.org
  • 4 edits
    3 adds in trunk

2010-10-17 Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>

Reviewed by Antonio Gomes.

[Qt] Layout tests for fix focusing of control elements on mouse click.
https://bugs.webkit.org/show_bug.cgi?id=40641

  • fast/events/click-focus-control-expected.txt: Added.
  • fast/events/click-focus-control.html: Added.
  • platform/mac/fast/events/click-focus-control-expected.txt: Added.
  • platform/win/Skipped:

2010-10-17 Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>

Reviewed by Antonio Gomes.

[Qt] Fix focusing of control elements on mouse click.
Brings GTK fix to Qt platform.
https://bugs.webkit.org/show_bug.cgi?id=40641

Test: fast/events/click-focus-control.html

  • html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::isMouseFocusable):
09:02 Changeset [69924] by abarth@webkit.org
  • 14 edits in trunk

2010-10-17 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

FrameLoader doesn't need an explicit userGesture parameter
https://bugs.webkit.org/show_bug.cgi?id=47777

We used to pass around the user gesture state explicitly. Now we use
static state. Explicitly passing the user gesture state to FrameLoader
in these methods is pretty out-dated.

  • bindings/ScriptControllerBase.cpp: (WebCore::ScriptController::executeIfJavaScriptURL):
  • bindings/generic/BindingDOMWindow.h: (WebCore::::createWindow): (WebCore::::open):
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::createWindow): (WebCore::JSDOMWindow::open):
  • bindings/js/JSDocumentCustom.cpp: (WebCore::JSDocument::setLocation):
  • bindings/js/ScriptController.h:
  • bindings/v8/ScriptController.h:
  • html/HTMLAnchorElement.cpp: (WebCore::handleLinkClick):
  • inspector/InspectorController.cpp: (WebCore::InspectorController::openInInspectedWindow):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::changeLocation): (WebCore::FrameLoader::urlSelected): (WebCore::FrameLoader::submitForm):
  • loader/FrameLoader.h:
  • loader/NavigationScheduler.cpp: (WebCore::ScheduledURLNavigation::fire): (WebCore::ScheduledRefresh::fire): (WebCore::ScheduledHistoryNavigation::fire): (WebCore::NavigationScheduler::scheduleLocationChange):

2010-10-17 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

FrameLoader doesn't need an explicit userGesture parameter
https://bugs.webkit.org/show_bug.cgi?id=47777

Update for the new API.

  • WebCoreSupport/WebContextMenuClient.cpp: (WebContextMenuClient::searchWithGoogle):
07:31 Changeset [69923] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-10-17 Sergey A. Sukiyazov <sergey.sukiyazov@gmail.com>

Reviewed by Andreas Kling

[Qt] Hovering the mouse over links produce a trail of underlined links (X11 paint engine)
https://bugs.webkit.org/show_bug.cgi?id=42248

The problem will appear because coordinates of points may increase by 0.05f (if line width is odd) inside
method GraphicsContext::adjustLineToPixelBoundaries(...) and become outside of text bounding rect htere,
then the new point coordinates will be passed to Qt graphics engine.

The solution decreases Y cordinates of points inside drawLineForText(...) method only if Qt graphics engine
is X11. The Y coordinates will be increase by 0.5f inside method adjustLineToPixelBoundaries(...), which
called from drawLine(...), and then inside Qt painting engine will be rounded to next greater integer value.

NOTE: This changes will affect only Qt X11 verision and if only X11 Painting Engine will be used.

No new tests.

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::drawLineForText):
03:53 Changeset [69922] by rwlbuis@webkit.org
  • 10 edits in trunk

2010-10-17 Rob Buis <rwlbuis@gmail.com>

Reviewed by Dirk Schulze.

Text under nested link dropped
https://bugs.webkit.org/show_bug.cgi?id=46460

Allow links inside of tspan and textPath elements.

  • svg/SVGTSpanElement.cpp: (WebCore::SVGTSpanElement::childShouldCreateRenderer):
  • svg/SVGTextPathElement.cpp: (WebCore::SVGTextPathElement::childShouldCreateRenderer):

10/16/10:

21:47 Changeset [69921] by tonikitoo@webkit.org
  • 4 edits
    1 add in trunk/LayoutTests/platform/gtk/fast/frames/flattening

2010-10-16 Antonio Gomes <agomes@rim.com>

Complementary to r69919.

Unreviewed expectation update for frame flattening tests from the Gtk+ bots.

Basically 3px difference between the results generated on my machine and the ones
from the Gtk+ bots.

  • platform/gtk/fast/frames/flattening/frameset-flattening-advanced-expected.txt: Added.
  • platform/gtk/fast/frames/flattening/frameset-flattening-grid-expected.txt:
  • platform/gtk/fast/frames/flattening/frameset-flattening-simple-expected.txt:
  • platform/gtk/fast/frames/flattening/frameset-flattening-subframe-resize-expected.txt:
  • platform/gtk/fast/frames/flattening/frameset-flattening-subframesets-expected.txt:
21:43 Changeset [69920] by commit-queue@webkit.org
  • 3 edits in trunk/JavaScriptCore

2010-10-16 Kyusun Kim <maniagoon@company100.net>

Reviewed by Alexey Proskuryakov.

Add using declarations for currentTimeMS() and parseDateFromNullTerminatedCharacters()
https://bugs.webkit.org/show_bug.cgi?id=47758

  • wtf/CurrentTime.h:
  • wtf/DateMath.h:
20:51 Changeset [69919] by tonikitoo@webkit.org
  • 8 edits
    11 adds in trunk

[Gtk]: DRT does not support frame flattening testing
https://bugs.webkit.org/show_bug.cgi?id=38650

Reviewed by Martin Robinson and Xan Lopez.
Patch by Antonio Gomes <agomes@rim.com>

WebKit/gtk:

Implement enable-frame-flattening API for Gtk+.

  • webkit/webkitwebsettings.cpp:

(webkit_web_settings_class_init):
(webkit_web_settings_set_property):
(webkit_web_settings_get_property):
(webkit_web_settings_copy):

  • webkit/webkitwebview.cpp:

(webkit_web_view_update_settings):
(webkit_web_view_settings_notify):

WebKitTools:

Implement DRT's support for toggling on/off frame flattening
support.

  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(resetDefaultsToConsistentValues):

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:

(LayoutTestController::setFrameFlatteningEnabled):

LayoutTests:

Unskipping passing frame flattening tests and adding expected results
for them.

  • platform/gtk/Skipped:
18:54 Changeset [69918] by dbates@webkit.org
  • 10 edits
    25 adds in trunk/LayoutTests

2010-10-16 Alex Milowski <alex@milowski.com>

Reviewed by Daniel Bates.

New MathML Baseline for GTK Port
https://bugs.webkit.org/show_bug.cgi?id=47774

New baseline for MathML tests for GTK port.

  • platform/gtk/mathml/presentation/attributes-expected.checksum: Added.
  • platform/gtk/mathml/presentation/attributes-expected.png: Added.
  • platform/gtk/mathml/presentation/attributes-expected.txt:
  • platform/gtk/mathml/presentation/fenced-mi-expected.checksum: Added.
  • platform/gtk/mathml/presentation/fenced-mi-expected.png: Added.
  • platform/gtk/mathml/presentation/fenced-mi-expected.txt: Added.
  • platform/gtk/mathml/presentation/fractions-expected.checksum: Added.
  • platform/gtk/mathml/presentation/fractions-expected.png: Added.
  • platform/gtk/mathml/presentation/fractions-expected.txt:
  • platform/gtk/mathml/presentation/fractions-vertical-alignment-expected.checksum: Added.
  • platform/gtk/mathml/presentation/fractions-vertical-alignment-expected.png: Added.
  • platform/gtk/mathml/presentation/fractions-vertical-alignment-expected.txt:
  • platform/gtk/mathml/presentation/mo-expected.checksum: Added.
  • platform/gtk/mathml/presentation/mo-expected.png: Added.
  • platform/gtk/mathml/presentation/mo-expected.txt:
  • platform/gtk/mathml/presentation/over-expected.checksum: Added.
  • platform/gtk/mathml/presentation/over-expected.png: Added.
  • platform/gtk/mathml/presentation/row-alignment-expected.checksum: Added.
  • platform/gtk/mathml/presentation/row-alignment-expected.png: Added.
  • platform/gtk/mathml/presentation/row-alignment-expected.txt:
  • platform/gtk/mathml/presentation/row-expected.checksum: Added.
  • platform/gtk/mathml/presentation/row-expected.png: Added.
  • platform/gtk/mathml/presentation/row-expected.txt:
  • platform/gtk/mathml/presentation/style-expected.checksum: Added.
  • platform/gtk/mathml/presentation/style-expected.png: Added.
  • platform/gtk/mathml/presentation/style-expected.txt:
  • platform/gtk/mathml/presentation/tokenElements-expected.checksum: Added.
  • platform/gtk/mathml/presentation/tokenElements-expected.png: Added.
  • platform/gtk/mathml/presentation/tokenElements-expected.txt:
  • platform/gtk/mathml/presentation/under-expected.checksum: Added.
  • platform/gtk/mathml/presentation/under-expected.png: Added.
  • platform/gtk/mathml/presentation/underover-expected.checksum: Added.
  • platform/gtk/mathml/presentation/underover-expected.png: Added.
  • platform/gtk/mathml/presentation/underover-expected.txt:
14:04 Changeset [69917] by kseo@webkit.org
  • 3 edits
    2 adds in trunk/WebCore

[BREWMP] Port TextCodec
https://bugs.webkit.org/show_bug.cgi?id=45797

Reviewed by Kent Tamura.

Implement TextCodec with Brew MP's ICharsetConv.
Only UTF-8 is supported for now.

  • platform/text/TextEncoding.cpp:

(WebCore::TextEncoding::encode):

  • platform/text/TextEncodingRegistry.cpp:

(WebCore::buildBaseTextCodecMaps):

  • platform/text/brew/TextCodecBrew.cpp: Added.

(WebCore::newTextCodecBrew):
(WebCore::TextCodecBrew::registerBaseEncodingNames):
(WebCore::TextCodecBrew::registerBaseCodecs):
(WebCore::TextCodecBrew::registerExtendedEncodingNames):
(WebCore::TextCodecBrew::registerExtendedCodecs):
(WebCore::TextCodecBrew::TextCodecBrew):
(WebCore::TextCodecBrew::~TextCodecBrew):
(WebCore::TextCodecBrew::decode):
(WebCore::TextCodecBrew::encode):

  • platform/text/brew/TextCodecBrew.h: Added.
13:07 Changeset [69916] by paroga@webkit.org
  • 2 edits in trunk/WebCore

2010-10-16 Patrick Gansterer <paroga@webkit.org>

Unreviewed.

Build fix for !ENABLE(INSPECTOR) after r69844.

  • inspector/InspectorState.h: Added ENABLE(INSPECTOR) guard.
13:00 Changeset [69915] by paroga@webkit.org
  • 2 edits in trunk/WebCore

2010-10-16 Patrick Gansterer <paroga@webkit.org>

Unreviewed, build fix.

WinCE build fix for r69798.

  • platform/text/wince/TextCodecWinCE.cpp: Added missing include.
09:48 Changeset [69914] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

2010-10-16 Johnny Ding <jnd@chromium.org>

Reviewed by Adam Barth.

Requires a user gesture when opening file choose dialog.
https://bugs.webkit.org/show_bug.cgi?id=47593

Test: fast/forms/input-file-not-open-without-gesture.html

  • rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::click):

2010-10-16 Johnny Ding <jnd@chromium.org>

Reviewed by Adam Barth.

Requires a user gesture when opening file choose dialog.
https://bugs.webkit.org/show_bug.cgi?id=47593

  • fast/forms/input-file-not-open-without-gesture-expected.txt: Added.
  • fast/forms/input-file-not-open-without-gesture.html: Added.
08:37 Changeset [69913] by commit-queue@webkit.org
  • 40 edits
    4 adds in trunk

2010-10-16 Alex Milowski <alex@milowski.com>

Reviewed by Kenneth Rohde Christiansen.

The tests were re-baselined as operator padding was adjusted.

  • mathml/presentation/fenced-mi.xhtml: Added.

A test for mi vertical alignment in mfenced.

  • platform/mac/mathml/presentation/attributes-expected.checksum:
  • platform/mac/mathml/presentation/attributes-expected.png:
  • platform/mac/mathml/presentation/attributes-expected.txt:
  • platform/mac/mathml/presentation/fenced-expected.checksum:
  • platform/mac/mathml/presentation/fenced-expected.png:
  • platform/mac/mathml/presentation/fenced-expected.txt:
  • platform/mac/mathml/presentation/fenced-mi-expected.checksum: Added.
  • platform/mac/mathml/presentation/fenced-mi-expected.png: Added.
  • platform/mac/mathml/presentation/fenced-mi-expected.txt: Added.
  • platform/mac/mathml/presentation/fractions-expected.checksum:
  • platform/mac/mathml/presentation/fractions-expected.png:
  • platform/mac/mathml/presentation/fractions-expected.txt:
  • platform/mac/mathml/presentation/fractions-vertical-alignment-expected.checksum:
  • platform/mac/mathml/presentation/fractions-vertical-alignment-expected.png:
  • platform/mac/mathml/presentation/fractions-vertical-alignment-expected.txt:
  • platform/mac/mathml/presentation/mo-expected.checksum:
  • platform/mac/mathml/presentation/mo-expected.png:
  • platform/mac/mathml/presentation/mo-expected.txt:
  • platform/mac/mathml/presentation/roots-expected.checksum:
  • platform/mac/mathml/presentation/roots-expected.png:
  • platform/mac/mathml/presentation/roots-expected.txt:
  • platform/mac/mathml/presentation/row-alignment-expected.checksum:
  • platform/mac/mathml/presentation/row-alignment-expected.png:
  • platform/mac/mathml/presentation/row-alignment-expected.txt:
  • platform/mac/mathml/presentation/row-expected.checksum:
  • platform/mac/mathml/presentation/row-expected.png:
  • platform/mac/mathml/presentation/row-expected.txt:
  • platform/mac/mathml/presentation/style-expected.checksum:
  • platform/mac/mathml/presentation/style-expected.png:
  • platform/mac/mathml/presentation/style-expected.txt:
  • platform/mac/mathml/presentation/subsup-expected.checksum:
  • platform/mac/mathml/presentation/subsup-expected.png:
  • platform/mac/mathml/presentation/subsup-expected.txt:
  • platform/mac/mathml/presentation/tokenElements-expected.checksum:
  • platform/mac/mathml/presentation/tokenElements-expected.png:
  • platform/mac/mathml/presentation/tokenElements-expected.txt:
  • platform/mac/mathml/presentation/underover-expected.checksum:
  • platform/mac/mathml/presentation/underover-expected.png:
  • platform/mac/mathml/presentation/underover-expected.txt:

2010-10-16 Alex Milowski <alex@milowski.com>

Reviewed by Kenneth Rohde Christiansen.

Changed the vertical alignment within mfenced to baseline to
match the rest of the containers (e.g. mrow) and adjusted the
operator spacing to 0.1em.

Test: mathml/presentation/fenced-mi.xhtml

  • css/mathml.css:
  • mathml/RenderMathMLFenced.cpp:
03:45 Changeset [69912] by paroga@webkit.org
  • 8 edits
    3 moves in trunk

2010-10-16 Patrick Gansterer <paroga@webkit.org>

Reviewed by Adam Barth.

Rename StringHasherFunctions.h to StringHasher.h
https://bugs.webkit.org/show_bug.cgi?id=47200

Now StringHasherFunctions.h only contains the StringHasher class, so rename it to the correct name.

  • GNUmakefile.am:
  • JavaScriptCore.gypi:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • wtf/StringHashFunctions.h: Removed.
  • wtf/StringHasher.h: Copied from JavaScriptCore/wtf/StringHashFunctions.h.
  • wtf/text/StringHash.h:
  • wtf/text/StringImpl.h:

2010-10-16 Patrick Gansterer <paroga@webkit.org>

Reviewed by Adam Barth.

Rename StringHasherFunctions.h to StringHasher.h
https://bugs.webkit.org/show_bug.cgi?id=47200

  • ForwardingHeaders/wtf/StringHashFunctions.h: Removed.
  • ForwardingHeaders/wtf/StringHasher.h: Copied from JavaScriptGlue/ForwardingHeaders/wtf/StringHashFunctions.h.

2010-10-16 Patrick Gansterer <paroga@webkit.org>

Reviewed by Adam Barth.

Rename StringHasherFunctions.h to StringHasher.h
https://bugs.webkit.org/show_bug.cgi?id=47200

  • ForwardingHeaders/wtf/StringHashFunctions.h: Removed.
  • ForwardingHeaders/wtf/StringHasher.h: Copied from WebCore/ForwardingHeaders/wtf/StringHashFunctions.h.

10/15/10:

22:09 Changeset [69911] by kinuko@chromium.org
  • 14 edits
    6 copies
    1 delete in branches/chromium/552

Merge 69907 - 2010-10-15 Kinuko Yasuda <kinuko@google.com>

Reviewed by Jian Li.

Implement FileEntrySync.file() in FileSystem API
https://bugs.webkit.org/show_bug.cgi?id=47310

Tests: fast/filesystem/workers/file-from-file-entry-sync.html

fast/filesystem/workers/file-from-file-entry.html

TBR=kinuko@chromium.org

21:10 Changeset [69910] by rniwa@webkit.org
  • 4 edits
    3 adds in trunk

2010-10-15 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

unlink removes inline style of anchor elements
https://bugs.webkit.org/show_bug.cgi?id=47424

The bug was caused by our not extracting styles when the anchor element is removed by removeInlineStyle.
Because we removed the element without pushing its inline style down, we lost style information.

Fixed the bug by pushing down styles in removeInlineStyle as done in pushDownInlineStyleAroundNode.
Also fixed a bug in addInlineStyleIfNeeded where StyleChange incorrectly removed styles of the container
node as supposed to that of startNode from the style to apply when startNode is not an element.

Test: editing/execCommand/toggle-unlink.html

  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::removeInlineStyleFromElement): To prevent a similar bug in the future, added an assert that extractedStyle is specified whenever we're removing a styled element. (WebCore::ApplyStyleCommand::removeInlineStyle): (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded):

2010-10-15 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

unlink removes inline style of anchor elements
https://bugs.webkit.org/show_bug.cgi?id=47424

Added a test to ensure execCommand('unlink', false, null) preserves the inline style declaration.

  • editing/execCommand/script-tests/toggle-unlink.js: Added. (testSingleToggle): (selectAll): (selectFirstTwoWords): (selectLastTwoWords): (selectLastWord):
  • editing/execCommand/toggle-unlink-expected.txt: Added.
  • editing/execCommand/toggle-unlink.html: Added.
  • editing/style/script-tests/make-text-writing-direction-inline.js: Specifies both direction and unicode-bidi properties instead of just direction property.
20:16 Changeset [69909] by rniwa@webkit.org
  • 4 edits in trunk/WebCore

2010-10-15 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Tony Chang.

serializeNodesWithNamespaces should be in MarkupAccumulator
https://bugs.webkit.org/show_bug.cgi?id=47749

Moved serializeNodesWithNamespaces to MarkupAccumulator, and renamed it to serializeNodes.
MarkupAccumulator::serializeNode now returns the resultant string instead of having a separate takeResults().
Added several helper functions to MarkupAccumulator.

No new tests are added since this is a cleanup.

  • editing/MarkupAccumulator.cpp: (WebCore::MarkupAccumulator::serializeNodes): Wrapper for serializeNodes and concatenateMarkup. (WebCore::MarkupAccumulator::serializeNodesWithNamespaces): Moved from markup.cpp (WebCore::MarkupAccumulator::appendStartTag): Calls appendString instead of appending into m_succeedingMarkup directly. (WebCore::MarkupAccumulator::appendEndTag): Ditto. (WebCore::MarkupAccumulator::totalLength): Added; extracted from takeResults. (WebCore::MarkupAccumulator::concatenateMarkup): Ditto.
  • editing/MarkupAccumulator.h: (WebCore::MarkupAccumulator::length): Added; calls totalLength.
  • editing/markup.cpp: (WebCore::StyledMarkupAccumulator::appendString): Added; calls MarkupAccumulator's appendString. (WebCore::StyledMarkupAccumulator::wrapWithStyleNode): Calls appendString. (WebCore::StyledMarkupAccumulator::takeResults): Calls length, totalLength, and concatenateMarkup. (WebCore::StyledMarkupAccumulator::serializeNodes): Became a member function. (WebCore::createMarkup): Uses MarkupAccumulator.
19:17 Changeset [69908] by thakis@chromium.org
  • 2 edits in branches/chromium/552/WebCore

Merge 69901 - 2010-10-15 Nico Weber <thakis@chromium.org>

Reviewed by Eric Carlson.

Make sure to update the current graphics context when calling out to AppKit.
https://bugs.webkit.org/show_bug.cgi?id=47757

Like r57741, but for the spellchecking highlight

  • platform/graphics/mac/GraphicsContextMac.mm: (WebCore::GraphicsContext::drawLineForTextChecking):

TBR=thakis@chromium.org

19:05 Changeset [69907] by kinuko@chromium.org
  • 14 edits
    1 move
    5 adds in trunk

2010-10-15 Kinuko Yasuda <kinuko@google.com>

Reviewed by Jian Li.

Implement FileEntrySync.file() in FileSystem API
https://bugs.webkit.org/show_bug.cgi?id=47310

Tests: fast/filesystem/workers/file-from-file-entry-sync.html

fast/filesystem/workers/file-from-file-entry.html

  • fileapi/DOMFileSystem.cpp: (WebCore::DOMFileSystem::createFile): Added.
  • fileapi/DOMFileSystem.h:
  • fileapi/DOMFileSystemSync.cpp: (WebCore::DOMFileSystemSync::createFile): Added.
  • fileapi/DOMFileSystemSync.h:
  • fileapi/DirectoryReaderBase.h: Added 'virtual path' comment.
  • fileapi/EntryBase.h: Added 'virtual path' comment.
  • fileapi/FileEntry.cpp: (WebCore::FileEntry::file): Changed to use DOMFileSystem::createFile.
  • fileapi/FileEntrySync.cpp: (WebCore::FileEntrySync::file): Implemented.
  • fileapi/FileEntrySync.h:
  • fileapi/FileEntrySync.idl: Added file().

2010-10-15 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by Jian Li.

Implement FileEntrySync.file() in FileSystem API
https://bugs.webkit.org/show_bug.cgi?id=47310

  • fast/filesystem/file-from-file-entry-expected.txt:
  • fast/filesystem/file-from-file-entry.html:
  • fast/filesystem/resources/file-from-file-entry-sync.js: Added.
  • fast/filesystem/resources/file-from-file-entry.js: Added.
  • fast/filesystem/script-tests/file-from-file-entry.js: Moved to resources to make it available for workers tests too.
  • fast/filesystem/workers/file-from-file-entry-expected.txt: Added.
  • fast/filesystem/workers/file-from-file-entry-sync-expected.txt: Added.
  • fast/filesystem/workers/file-from-file-entry-sync.html: Added.
  • fast/filesystem/workers/file-from-file-entry.html: Added.
18:50 Changeset [69906] by oliver@apple.com
  • 4 edits
    3 adds in trunk

2010-10-15 Oliver Hunt <oliver@apple.com>

Reviewed by Sam Weinig.

Automatic Semicolon Insertion incorrectly inserts semicolon after break, continue, and return followed by a newline
https://bugs.webkit.org/show_bug.cgi?id=47762

The old YACC parser depended on the lexer for some classes of semicolon insertion.
The new parser handles ASI entirely on its own so when the lexer inserts a semicolon
on its own the net result is a spurious semicolon in the input stream. This can result
in incorrect parsing in some cases:

if (0)

break

;else {}

Would result in a parse failure as the output from the lexer is essentially

if (0)

break

;;else

So the second semicolon is interpreted as a empty statement, which terminates the if,
making the else an error.

  • parser/JSParser.cpp: (JSC::JSParser::parseThrowStatement): Parsing of throw statement was wrong, and only worked due to the weird behaviour in the lexer
  • parser/Lexer.cpp: (JSC::Lexer::lex): Remove bogus semicolon insertion from the newline handling

2010-10-15 Oliver Hunt <oliver@apple.com>

Reviewed by Sam Weinig.

ASI incorrectly inserts semicolon after break, continue, and return followed by a newline
https://bugs.webkit.org/show_bug.cgi?id=47762

tests for correct ASI following break, continue, and return

  • fast/js/break-ASI-expected.txt: Added.
  • fast/js/break-ASI.html: Added.
  • fast/js/script-tests/break-ASI.js: Added.
18:31 Changeset [69905] by dpranke@chromium.org
  • 7 edits in trunk/WebKitTools

2010-10-15 Dirk Pranke <dpranke@chromium.org>

Reviewed by Eric Siedel.

mocktool.MockOptions is inheriting from Mock, which has the side
effect of defaulting any attribute to another MockObject. So,
MockOptions().foo would always evaluate to true. This was
covering over bugs in the unit tests, and is probably the wrong
default behavior for anything attempting to mock out the options
argument returned from optparse.parse_args().

This patch changes the default behavior. The new MockOptions()
class takes an optional list of keyword parameters to set; this
patch doesn't use that feature but the fix for bug 47510 will.

Also, this patch just fills in the default values necessary to
get all of the tests to pass; I didn't stare at each test by
hand to determine the "right" values. We can either fix that in
subsequent patches or let me know if we want to do that now (and
give me some guidance on what those values might want to be).

https://bugs.webkit.org/show_bug.cgi?id=47709

  • Scripts/webkitpy/tool/commands/commandtest.py:
  • Scripts/webkitpy/tool/commands/download_unittest.py:
  • Scripts/webkitpy/tool/commands/upload_unittest.py:
  • Scripts/webkitpy/tool/mocktool.py:
  • Scripts/webkitpy/tool/steps/steps_unittest.py:
  • Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
18:15 Changeset [69904] by crogers@google.com
  • 56 edits
    2 adds in branches/audio/WebCore

audio branch: changes in preparation for landing into trunk

  • massive munge to change to proper license
  • cleanup of delay-related files
  • add AudioResamplerKernel files
  • lots of cleanup for AudioNodeInput and AudioNodeOutput
  • cleanup of AudioResampler
  • lots of cleanup for AudioBufferSourceNode

audio branch: last minute cleanup

18:08 Changeset [69903] by jamesr@google.com
  • 21 edits
    20 copies in trunk/LayoutTests

2010-10-15 Mihai Parparita <mihaip@chromium.org>

Reviewed by James Robinson.

css2.1/ layout tests need new Mac baselines for Snow Leopard
https://bugs.webkit.org/show_bug.cgi?id=47760

Rebaseline 10 css2.1/ test for Snow Leopard using the experimental
local rebaselining tool.

  • platform/mac-leopard/css2.1/t010403-shand-border-00-c-expected.checksum: Copied from LayoutTests/platform/mac/css2.1/t010403-shand-border-00-c-expected.checksum.
  • platform/mac-leopard/css2.1/t010403-shand-border-00-c-expected.png: Copied from LayoutTests/platform/mac/css2.1/t010403-shand-border-00-c-expected.png.
  • platform/mac-leopard/css2.1/t010403-shand-font-00-b-expected.checksum: Copied from LayoutTests/platform/mac/css2.1/t010403-shand-font-00-b-expected.checksum.
  • platform/mac-leopard/css2.1/t010403-shand-font-00-b-expected.png: Copied from LayoutTests/platform/mac/css2.1/t010403-shand-font-00-b-expected.png.
  • platform/mac-leopard/css2.1/t010403-shand-font-01-b-expected.checksum: Copied from LayoutTests/platform/mac/css2.1/t010403-shand-font-01-b-expected.checksum.
  • platform/mac-leopard/css2.1/t010403-shand-font-01-b-expected.png: Copied from LayoutTests/platform/mac/css2.1/t010403-shand-font-01-b-expected.png.
  • platform/mac-leopard/css2.1/t010403-shand-font-02-b-expected.checksum: Copied from LayoutTests/platform/mac/css2.1/t010403-shand-font-02-b-expected.checksum.
  • platform/mac-leopard/css2.1/t010403-shand-font-02-b-expected.png: Copied from LayoutTests/platform/mac/css2.1/t010403-shand-font-02-b-expected.png.
  • platform/mac-leopard/css2.1/t010403-shand-font-03-b-expected.checksum: Copied from LayoutTests/platform/mac/css2.1/t010403-shand-font-03-b-expected.checksum.
  • platform/mac-leopard/css2.1/t010403-shand-font-03-b-expected.png: Copied from LayoutTests/platform/mac/css2.1/t010403-shand-font-03-b-expected.png.
  • platform/mac-leopard/css2.1/t040102-keywords-00-b-expected.checksum: Copied from LayoutTests/platform/mac/css2.1/t040102-keywords-00-b-expected.checksum.
  • platform/mac-leopard/css2.1/t040102-keywords-00-b-expected.png: Copied from LayoutTests/platform/mac/css2.1/t040102-keywords-00-b-expected.png.
  • platform/mac-leopard/css2.1/t040102-keywords-01-b-expected.checksum: Copied from LayoutTests/platform/mac/css2.1/t040102-keywords-01-b-expected.checksum.
  • platform/mac-leopard/css2.1/t040102-keywords-01-b-expected.png: Copied from LayoutTests/platform/mac/css2.1/t040102-keywords-01-b-expected.png.
  • platform/mac-leopard/css2.1/t040103-case-00-b-expected.checksum: Copied from LayoutTests/platform/mac/css2.1/t040103-case-00-b-expected.checksum.
  • platform/mac-leopard/css2.1/t040103-case-00-b-expected.png: Copied from LayoutTests/platform/mac/css2.1/t040103-case-00-b-expected.png.
  • platform/mac-leopard/css2.1/t040103-case-01-c-expected.checksum: Copied from LayoutTests/platform/mac/css2.1/t040103-case-01-c-expected.checksum.
  • platform/mac-leopard/css2.1/t040103-case-01-c-expected.png: Copied from LayoutTests/platform/mac/css2.1/t040103-case-01-c-expected.png.
  • platform/mac-leopard/css2.1/t040103-escapes-00-b-expected.checksum: Copied from LayoutTests/platform/mac/css2.1/t040103-escapes-00-b-expected.checksum.
  • platform/mac-leopard/css2.1/t040103-escapes-00-b-expected.png: Copied from LayoutTests/platform/mac/css2.1/t040103-escapes-00-b-expected.png.
  • platform/mac/css2.1/t010403-shand-border-00-c-expected.checksum:
  • platform/mac/css2.1/t010403-shand-border-00-c-expected.png:
  • platform/mac/css2.1/t010403-shand-font-00-b-expected.checksum:
  • platform/mac/css2.1/t010403-shand-font-00-b-expected.png:
  • platform/mac/css2.1/t010403-shand-font-01-b-expected.checksum:
  • platform/mac/css2.1/t010403-shand-font-01-b-expected.png:
  • platform/mac/css2.1/t010403-shand-font-02-b-expected.checksum:
  • platform/mac/css2.1/t010403-shand-font-02-b-expected.png:
  • platform/mac/css2.1/t010403-shand-font-03-b-expected.checksum:
  • platform/mac/css2.1/t010403-shand-font-03-b-expected.png:
  • platform/mac/css2.1/t040102-keywords-00-b-expected.checksum:
  • platform/mac/css2.1/t040102-keywords-00-b-expected.png:
  • platform/mac/css2.1/t040102-keywords-01-b-expected.checksum:
  • platform/mac/css2.1/t040102-keywords-01-b-expected.png:
  • platform/mac/css2.1/t040103-case-00-b-expected.checksum:
  • platform/mac/css2.1/t040103-case-00-b-expected.png:
  • platform/mac/css2.1/t040103-case-01-c-expected.checksum:
  • platform/mac/css2.1/t040103-case-01-c-expected.png:
  • platform/mac/css2.1/t040103-escapes-00-b-expected.checksum:
  • platform/mac/css2.1/t040103-escapes-00-b-expected.png:
18:01 Changeset [69902] by weinig@apple.com
  • 2 edits in trunk/WebKit2

Fix Qt build.

  • UIProcess/API/qt/qwkpage.cpp:

(QWKPagePrivate::createPopupMenuProxy):

17:56 Changeset [69901] by thakis@chromium.org
  • 2 edits in trunk/WebCore

2010-10-15 Nico Weber <thakis@chromium.org>

Reviewed by Eric Carlson.

Make sure to update the current graphics context when calling out to AppKit.
https://bugs.webkit.org/show_bug.cgi?id=47757

Like r57741, but for the spellchecking highlight

  • platform/graphics/mac/GraphicsContextMac.mm: (WebCore::GraphicsContext::drawLineForTextChecking):
17:50 Changeset [69900] by bweinstein@apple.com
  • 5 edits
    2 adds in trunk

REGRESSION(r69850) Loading apple.com/startpage in WebKit on Windows gets a bad request.
https://bugs.webkit.org/show_bug.cgi?id=47753
<rdar://problem/8558242>

Reviewed by Sam Weinig.

WebCore:

r69850 switched over to a different way of concatenating WebCore strings, but ran into an issue
where some Windows calls were returning null terminated strings, and this breaks the new
method of concatenation.

GetLocaleInfo returns a null-terminated string, but WebCore strings are non-null terminated,
so once we create our WebCore string, we want to trim off the null terminating character before
we return the localeInfo.

Test: fast/dom/navigator-userAgent.html

  • platform/win/Language.cpp:

(WebCore::localeInfo):

WebKit/win:

VerQueryValue returns a null terminated string, but we need to strip off the null terminating character
when we turn it into a WebCore string, or else concatenation using this string will break.

  • WebView.cpp:

LayoutTests:

Add a test to make sure that the user agent has some important parts, and is fully formed.
This test tests that the user agent has Mozilla, AppleWebKit, and KHML, like Gecko. If the
user agent has all of these components, the string concatenation worked correctly, and this
bug is fixed.

  • fast/dom/navigator-userAgent-expected.txt: Added.
  • fast/dom/navigator-userAgent.html: Added.
17:47 Changeset [69899] by weinig@apple.com
  • 22 edits
    9 adds in trunk/WebKit2

Popup widget support (<select>)
<rdar://problem/8147746>
https://bugs.webkit.org/show_bug.cgi?id=47740

Reviewed by Anders Carlsson.

Add initial support for popup menus. Only works on the mac at this time.

  • Shared/WebPopupItem.cpp: Added.

(WebKit::WebPopupItem::WebPopupItem):
(WebKit::WebPopupItem::encode):
(WebKit::WebPopupItem::decode):

  • Shared/WebPopupItem.h: Added.

Serializable representation of a menu item.

  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::createPopupMenuProxy):
Create a WebPopupMenuProxyMac.

  • UIProcess/API/qt/qwkpage.cpp:

(WebView::createPopupMenuProxy):

  • UIProcess/API/qt/qwkpage_p.h:

Create a WebPopupMenuProxyQt (which is just a stub right now).

(WebKit::WebPopupMenuProxyWin::create):

  • UIProcess/win/WebView.cpp:

(WebKit::WebView::createPopupMenuProxy):

  • UIProcess/win/WebView.h:

Create a WebPopupMenuProxyWin (which is just a stub right now).

  • UIProcess/PageClient.h:

Add new client function to get a platform specific WebPopupMenuProxy.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::close):
(WebKit::WebPageProxy::showPopupMenu):
(WebKit::WebPageProxy::hidePopupMenu):
(WebKit::WebPageProxy::processDidExit):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:

Pipe through calls to set up the menu.

  • UIProcess/mac/WebPopupMenuProxyMac.h: Added.

(WebKit::WebPopupMenuProxyMac::create):

  • UIProcess/mac/WebPopupMenuProxyMac.mm: Added.

(WebKit::WebPopupMenuProxyMac::WebPopupMenuProxyMac):
(WebKit::WebPopupMenuProxyMac::~WebPopupMenuProxyMac):
(WebKit::WebPopupMenuProxyMac::populate):
(WebKit::WebPopupMenuProxyMac::showPopupMenu):
(WebKit::WebPopupMenuProxyMac::hidePopupMenu):
Add UI process side implementation. Currently this does not support
custom fonts as the old implementation did.

  • UIProcess/qt/WebPopupMenuProxyQt.cpp: Added.

(WebKit::WebPopupMenuProxyQt::WebPopupMenuProxyQt):
(WebKit::WebPopupMenuProxyQt::~WebPopupMenuProxyQt):
(WebKit::WebPopupMenuProxyQt::showPopupMenu):
(WebKit::WebPopupMenuProxyQt::hidePopupMenu):

  • UIProcess/qt/WebPopupMenuProxyQt.h: Added.

(WebKit::WebPopupMenuProxyQt::create):

  • UIProcess/win/WebPopupMenuProxyWin.cpp: Added.

(WebKit::WebPopupMenuProxyWin::WebPopupMenuProxyWin):
(WebKit::WebPopupMenuProxyWin::~WebPopupMenuProxyWin):
(WebKit::WebPopupMenuProxyWin::showPopupMenu):
(WebKit::WebPopupMenuProxyWin::hidePopupMenu):

  • UIProcess/win/WebPopupMenuProxyWin.h: Added.

Add stubbed out implementations for Qt and windows.

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::createPopupMenu):
(WebKit::WebChromeClient::createSearchPopupMenu):
Pass the page in the create function.

  • WebProcess/WebCoreSupport/WebPopupMenu.cpp:

(WebKit::WebPopupMenu::create):
(WebKit::WebPopupMenu::WebPopupMenu):
(WebKit::WebPopupMenu::didChangeSelectedIndex):
(WebKit::WebPopupMenu::populateItems):
(WebKit::WebPopupMenu::show):
(WebKit::WebPopupMenu::hide):

  • WebProcess/WebCoreSupport/WebPopupMenu.h:

(WebKit::WebPopupMenu::disconnectFromPage):

  • WebProcess/WebCoreSupport/WebSearchPopupMenu.cpp:

(WebKit::WebSearchPopupMenu::create):
(WebKit::WebSearchPopupMenu::WebSearchPopupMenu):
(WebKit::WebSearchPopupMenu::popupMenu):

  • WebProcess/WebCoreSupport/WebSearchPopupMenu.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::close):
(WebKit::WebPage::setActivePopupMenu):
(WebKit::WebPage::didChangeSelectedIndexForActivePopupMenu):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:

Pipe through calls to set up the menu.

  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:

Add new files.

17:40 Changeset [69898] by ap@apple.com
  • 4 edits in trunk/WebCore

Trying to fix crashes on Leopard buildbot.

  • loader/loader.cpp: (WebCore::Loader::Host::didFinishLoading): (WebCore::Loader::Host::didFail): Moved logging higher in the function - it seems that CachedResource can be already destroyed.
  • platform/Logging.cpp: (WebCore::getChannelFromName):
  • platform/mac/LoggingMac.mm: (WebCore::InitializeLoggingChannelsIfNecessary): Initialize the new channel (oops).
17:14 Changeset [69897] by andersca@apple.com
  • 2 edits in trunk/WebKit2

Fix build.

  • UIProcess/API/mac/FindIndicatorWindow.mm:

(-[WebFindIndicatorWindowAnimation setCurrentProgress:]):

16:39 Changeset [69896] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

2010-10-15 Mike Lawther <mikelawther@chromium.org>

Reviewed by James Robinson.

iframes keep getting scrollbars with scrolling="no"
https://bugs.webkit.org/show_bug.cgi?id=29240

Prevent scrollbars from appearing in iframes with scrolling=no
when the embedded content has overflow:scroll set on the html
or body tags.

  • fast/frames/iframe-scrolling-attribute-overflowscroll-expected.txt: Added.
  • fast/frames/iframe-scrolling-attribute-overflowscroll.html: Added.

2010-10-15 Mike Lawther <mikelawther@chromium.org>

Reviewed by James Robinson.

Prevent scrollbars from appearing in iframes with scrolling=no
when the embedded content has overflow:scroll set on the html
or body tags.

iframes keep getting scrollbars with scrolling="no"
https://bugs.webkit.org/show_bug.cgi?id=29240

Test: fast/frames/iframe-scrolling-attribute-overflowscroll.html

  • page/FrameView.cpp: (WebCore::FrameView::calculateScrollbarModesForLayout) (WebCore::FrameView::updateCanHaveScrollbars): (WebCore::FrameView::layout):
  • page/FrameView.h: (WebCore::FrameView::calculateScrollbarModesForLayout)
16:33 Changeset [69895] by andersca@apple.com
  • 3 edits in trunk/WebKit2

Make the find indicator window fade out when requested
https://bugs.webkit.org/show_bug.cgi?id=47747

Reviewed by Sam Weinig.

  • UIProcess/API/mac/FindIndicatorWindow.h:
  • UIProcess/API/mac/FindIndicatorWindow.mm:

Add WebFindIndicatorWindowAnimation - an NSAnimation subclass that takes two
C++ member function pointers and invokes them the animation progress changes and
when the animation stops.

(-[WebFindIndicatorWindowAnimation setCurrentProgress:]):
Call the _animationProgressCallback.

(-[WebFindIndicatorWindowAnimation animationDidEnd:]):
Call the _animationDidEndCallback.

(WebKit::FindIndicatorWindow::FindIndicatorWindow):
Initialize the fade out start timer.

(WebKit::FindIndicatorWindow::setFindIndicator):
When asked to fade out, we start the fade out timer.

(WebKit::FindIndicatorWindow::closeWindow):
Stop the fade out timer and the fade out animation.

(WebKit::FindIndicatorWindow::startFadeOutTimerFired):
Create a fade out animation.

(WebKit::FindIndicatorWindow::fadeOutAnimationCallback):
Update the window alpha.

(WebKit::FindIndicatorWindow::fadeOutAnimationDidEnd):
Close the window.

15:52 Changeset [69894] by simon.fraser@apple.com
  • 3 edits in trunk/WebKitTools

2010-10-15 Simon Fraser <simon.fraser@apple.com>

Fix the build; need to add new slot to PageUIClient callbacks.

  • MiniBrowser/mac/BrowserWindowController.m: (-[BrowserWindowController awakeFromNib]):
  • WebKitTestRunner/TestController.cpp: (WTR::createOtherPage): (WTR::TestController::initialize):
15:43 Changeset [69893] by simon.fraser@apple.com
  • 2 edits in trunk/WebKitTools

2010-10-15 Simon Fraser <simon.fraser@apple.com>

Add Matt Delaney to committers.py.

  • Scripts/webkitpy/common/config/committers.py:
15:33 Changeset [69892] by simon.fraser@apple.com
  • 8 edits in trunk/WebKit2

2010-10-15 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

Add 'didDraw' callback for framerate tracking
https://bugs.webkit.org/show_bug.cgi?id=47478

Hook up the 'didDraw' callback for WebKit2 on Mac.

  • UIProcess/API/C/WKPage.h:
  • UIProcess/API/mac/WKView.mm: (-[WKView drawRect:]):
  • UIProcess/API/qt/qwkpage.cpp: (QWKPage::QWKPage):
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didDraw):
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebUIClient.cpp: (WebKit::WebUIClient::didDraw):
  • UIProcess/WebUIClient.h:
15:28 Changeset [69891] by jianli@chromium.org
  • 6 edits in branches/chromium/552

Merge 69883 - FileReader.readAsDataURL should take Blob object
https://bugs.webkit.org/show_bug.cgi?id=47679

Reviewed by Dmitry Titov.

BUG=59409
TEST=none

TBR=jianli@chromium.org

15:27 Changeset [69890] by mitz@apple.com
  • 2 edits in trunk/WebCore

Clean up RenderFlexibleBox::applyLineClamp()
https://bugs.webkit.org/show_bug.cgi?id=47743

Reviewed by Adele Peterson.

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::applyLineClamp):

15:17 Changeset [69889] by ap@apple.com
  • 2 edits in trunk

Correct ChangeLogs.

15:14 Changeset [69888] by rniwa@webkit.org
  • 3 edits
    2 copies in branches/chromium/552

Merge 69865 - 2010-10-15 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

Crash in WebCore::ApplyStyleCommand::applyBlockStyle
https://bugs.webkit.org/show_bug.cgi?id=47699

The crash was caused by applyBlockStyle's invalidly assuming that visibleStart and visibleEnd always exist.
Added an early exit to the function when either visibleStart or visibleEnd is null or orphaned.

Test: editing/style/block-style-progress-crash.html

  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyBlockStyle):

2010-10-15 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

Crash in WebCore::ApplyStyleCommand::applyBlockStyle
https://bugs.webkit.org/show_bug.cgi?id=47699

Added a test to ensure WebKit does not crash when the body is content editable
and justifying a progress element and '>' following the element to the right.

  • editing/style/block-style-progress-crash-expected.txt: Added.
  • editing/style/block-style-progress-crash.html: Added.

BUG=58832
TBR=rniwa@webkit.org

15:12 Changeset [69887] by ap@apple.com
  • 3 edits
    5 adds in trunk

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=47736
<rdar://problem/8429396> WebCore cache gets corrupted if revalidation request starts at a wrong time

Test: http/tests/cache/stopped-revalidation.html

  • loader/loader.cpp: (WebCore::Loader::Host::servePendingRequests): Copied logic for revalidation requests from didFail().
15:05 Changeset [69886] by ap@apple.com
  • 6 edits in trunk/WebCore

2010-10-15 Alexey Proskuryakov <ap@apple.com>

Reviewed by Darin Adler in <https://bugs.webkit.org/show_bug.cgi?id=47736>.

Add a logging channel for WebCore cache and resource loading.

Test: http/tests/cache/stopped-revalidation.html

  • platform/Logging.cpp:
  • platform/Logging.h: Added a logging channel for Cache and Loader.
  • loader/Cache.cpp: (WebCore::Cache::requestResource): (WebCore::Cache::revalidateResource): (WebCore::Cache::revalidationFailed): (WebCore::Cache::evict):
  • loader/CachedResource.cpp: (WebCore::CachedResource::setResourceToRevalidate): (WebCore::CachedResource::switchClientsToRevalidatedResource): (WebCore::CachedResource::mustRevalidate): Added logging.
  • loader/loader.cpp: (WebCore::Loader::load): Added logging. (WebCore::Loader::scheduleServePendingRequests): Ditto. (WebCore::Loader::requestTimerFired): Ditto. (WebCore::Loader::servePendingRequests): Ditto. (WebCore::Loader::Host::servePendingRequests): Changed logging to use the new channel. (WebCore::Loader::Host::didFinishLoading): Changed logging to use the new channel. (WebCore::Loader::Host::didFail): Added logging.
14:58 Changeset [69885] by japhet@chromium.org
  • 41 edits
    24 adds in trunk/LayoutTests

2010-10-15 Nate Chapin <japhet@chromium.org>

Unreviewed, Chromium expectations update.

Update results for http://trac.webkit.org/changeset/69872.

  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.checksum:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.checksum:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.checksum:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.checksum:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.checksum:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.checksum:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.checksum:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.checksum:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.checksum:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.checksum:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.png:
  • platform/chromium-mac/svg/custom/repaint-on-constant-size-change-expected.checksum: Added.
  • platform/chromium-mac/svg/custom/repaint-on-constant-size-change-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.png: Added.
  • platform/chromium-win/svg/custom/repaint-on-constant-size-change-expected.checksum: Added.
  • platform/chromium-win/svg/custom/repaint-on-constant-size-change-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.checksum:
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.checksum:
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.checksum:
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.checksum:
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.checksum:
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.checksum:
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.checksum:
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.checksum:
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.checksum:
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.checksum:
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.png:
14:57 Changeset [69884] by noam.rosenthal@nokia.com
  • 7 edits in trunk/WebCore

2010-10-15 No'am Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Simon Fraser.

Add public functions to serialize TransformOperations.
https://bugs.webkit.org/show_bug.cgi?id=47728

Added public accessors to the internal data of the TransformOperations.

No new tests. These functions are enablers for WebKit2.

  • platform/graphics/transforms/Matrix3DTransformOperation.h: (WebCore::Matrix3DTransformOperation::matrix):
  • platform/graphics/transforms/MatrixTransformOperation.h: (WebCore::MatrixTransformOperation::matrix):
  • platform/graphics/transforms/PerspectiveTransformOperation.h: (WebCore::PerspectiveTransformOperation::perspective):
  • platform/graphics/transforms/RotateTransformOperation.h: (WebCore::RotateTransformOperation::x): (WebCore::RotateTransformOperation::y): (WebCore::RotateTransformOperation::z):
  • platform/graphics/transforms/SkewTransformOperation.h: (WebCore::SkewTransformOperation::angleX): (WebCore::SkewTransformOperation::angleY):
  • platform/graphics/transforms/TranslateTransformOperation.h: (WebCore::TranslateTransformOperation::x): (WebCore::TranslateTransformOperation::y): (WebCore::TranslateTransformOperation::z):
14:46 Changeset [69883] by jianli@chromium.org
  • 8 edits in trunk

FileReader.readAsDataURL should take Blob object
https://bugs.webkit.org/show_bug.cgi?id=47679

Reviewed by Dmitry Titov.

WebCore:

Test cases have been added into read-blob-test-cases.js.

  • fileapi/FileReader.idl: Update per the latest File API spec.

LayoutTests:

  • fast/files/read-blob-async-expected.txt:
  • fast/files/resources/read-blob-test-cases.js:

(testReadingSingleTextBlobAsDataURL):
(testReadingSingleTextBlobAsDataURL2):
(testReadingTripleSlicedHybridBlob):

  • fast/files/resources/read-common.js:

(buildBlob):

  • fast/files/workers/worker-read-blob-async-expected.txt:
  • fast/files/workers/worker-read-blob-sync-expected.txt:
14:38 Changeset [69882] by jianli@chromium.org
  • 1 edit in branches/chromium/552/WebKit/chromium/public/WebBlobRegistry.h

Merge 69615 - Unreview. Build fix for chromium.

  • public/WebBlobRegistry.h:

BUG=59391
TEST=none

TBR=jianli@chromium.org

14:36 Changeset [69881] by jianli@chromium.org
  • 5 edits
    2 copies
    2 deletes in branches/chromium/552/WebKit/chromium

Merge 69611 - [chromium] Update WebBlobData to adapt to BlobData change in terms of
handling string data item.
https://bugs.webkit.org/show_bug.cgi?id=47423

Reviewed by Darin Fisher.

Also remove unneeded methods in WebBlobData. WebBlobStorageData.* are
also removed since they're not longer needed.

BUG=59391
TEST=none

TBR=jianli@chromium.org

14:34 Changeset [69880] by abarth@webkit.org
  • 11 edits
    2 adds in trunk/WebCore

2010-10-15 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Move MarkupAccumulator from markup.cpp to its own file
https://bugs.webkit.org/show_bug.cgi?id=47734

This patch moves the MarkupAccumulator class into its own file.
There's a lot of clean up left to do, but this patch is a step in the
right direction.

No behavior change.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • editing/markup.cpp: (WebCore::elementCannotHaveEndTag):
  • editing/markup.h:
  • editing/MarkupAccumulator.h: Added.
  • editing/MarkupAccumulator.cpp: Added.
14:34 Changeset [69879] by jianli@chromium.org
  • 9 edits in branches/chromium/552/WebCore

Merge 69610 - Fix passing blob data with string data item between threads.
https://bugs.webkit.org/show_bug.cgi?id=46543

Reviewed by David Levin.

The fix is to use a thread-safe ref-counted Vector<char> to store the
string data. This also makes us be able to store any binary data in it.

I've also fix BlobBuilder and BlobRegistryImpl to avoid some additional
copies to make blob handling faster.

BUG=59391
TEST=none

TBR=jianli@chromium.org

14:31 Changeset [69878] by andersca@apple.com
  • 5 edits in trunk/WebKit2

Move find indicator window logic to WKView
https://bugs.webkit.org/show_bug.cgi?id=47739

Reviewed by Sam Weinig.

  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::setFindIndicator):
Call -[WKView _setFindIndicator:fadeOut:].

  • UIProcess/API/mac/WKView.mm:

(-[WKView renewGState]):
Hide the find indicator.

(-[WKView _setFindIndicator:fadeOut:]):
Move the find indicator logic here.

14:05 Changeset [69877] by andersca@apple.com
  • 7 edits in trunk/WebKit2

Hide the find indicator/overlay when necessary
https://bugs.webkit.org/show_bug.cgi?id=47737

Reviewed by Sam Weinig.

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::invalidateContentsForSlowScroll):
Hide the find indicator.

(WebKit::WebChromeClient::scroll):
Ditto.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
Hide the find indicator and the find overlay.

  • WebProcess/WebPage/FindController.cpp:

(WebKit::FindController::findString):
Always hide all previous find matches. Only clear the selection if the string
not found wasn't empty.

(WebKit::FindController::hideFindUI):
Uninstall the page overlay and hide the find indicator.

(WebKit::FindController::hideFindIndicator):
Rename resetFindIndicator to hideFindIndicator.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::uninstallPageOverlay):
Invalidate the entire page.

13:53 Changeset [69876] by rniwa@webkit.org
  • 9 edits in trunk

2010-10-15 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

Match the elements supported by execCommand('formatBlock') and queryCommandValue('formatBlock')
https://bugs.webkit.org/show_bug.cgi?id=47712

Extended queryCommandValue('formatBlock', false, null) to support article, aside, blockquote, dd, dl,
div, dl, dt, dl, footer, header, hgroup, nav, and section. Because this makes isElementForFormatBlockCommand
in Editor.cpp and FormatBlockCommand::isElementToApplyInFormatBlockCommand identical, they are merged and moved
to FormatBlockCommand.cpp

Tests are added to editing/execCommand/query-format-block.html

  • editing/Editor.cpp: Removed isElementForFormatBlockCommand and Editor::elementForFormatBlockCommand.
  • editing/Editor.h:
  • editing/EditorCommand.cpp: (WebCore::executeFormatBlock): Removed the check of tag name; the check is moved into FormatBlockCommand. (WebCore::valueFormatBlock): Calls FormatBlockCommand::elementForFormatBlockCommand.
  • editing/FormatBlockCommand.cpp: (WebCore::isElementForFormatBlock): (WebCore::FormatBlockCommand::FormatBlockCommand): (WebCore::FormatBlockCommand::formatSelection): Added to check the tag name. Exit early if the specified tag name is not what FormatBlock should apply. Set m_didApply true if m_didApply did apply the element. (WebCore::FormatBlockCommand::formatRange): Moved from Editor.cpp. Takes Range* instead of accessing selection directly. (WebCore::FormatBlockCommand::elementForFormatBlockCommand): Moved from Editor.cpp (WebCore::enclosingBlockToSplitTreeTo): Calls isElementForFormatBlock.
  • editing/FormatBlockCommand.h: (WebCore::FormatBlockCommand::didApply): Added.

2010-10-15 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

Match the elements supported by execCommand('formatBlock') and queryCommandValue('formatBlock')
https://bugs.webkit.org/show_bug.cgi?id=47712

Added queryCommandValue('formatBlock') tests for support article, aside, blockquote, dd, dl, div,
dl, dt, dl, footer, header, hgroup, nav, and section.

Also added tests to ensure we don't return tag name for a subset of unsupported elements.

  • editing/execCommand/query-format-block-expected.txt:
  • editing/execCommand/script-tests/query-format-block.js: (queryFormatBlock): (selectFirstPosition): (selectMiddleOfHelloWorld):
13:39 Changeset [69875] by mrobinson@webkit.org
  • 3 edits in trunk/LayoutTests

2010-10-15 Martin Robinson <mrobinson@igalia.com>

Rebaseline two GTK+ tests.

  • platform/gtk/fast/forms/mailto/advanced-get-expected.txt:
  • platform/gtk/fast/forms/mailto/advanced-put-expected.txt:
13:02 Changeset [69874] by krit@webkit.org
  • 5 edits
    4 adds in trunk

2010-10-15 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

carto.net Dock example redraws *way* too often
https://bugs.webkit.org/show_bug.cgi?id=16090

Setting the attributes x, y, width or height shouldn't cause a repaint if the image boundaries don't change.
Added updateFromElement() to RenderSVGImage that checks if the old boundaries match the new boundaries after
setting one of the attributes of above. Mark renderer for layout (and therefore repaint) if the boundaries
differ, do nothing if not.
Also added caching of the repaint rect to avoid multiple calculations.

Test: svg/custom/repaint-on-constant-size-change.svg

  • rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::RenderSVGImage): (WebCore::RenderSVGImage::layout): Update repaint rect on layout. (WebCore::RenderSVGImage::updateFromElement): Check SVGImageElement for boundaries update.
  • rendering/RenderSVGImage.h: (WebCore::RenderSVGImage::repaintRectInLocalCoordinates): Return the cached repaint rect.
  • svg/SVGImageElement.cpp: (WebCore::SVGImageElement::svgAttributeChanged): Call updateFromElement() on changes to x, y, width or height.

2010-10-15 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

carto.net Dock example redraws *way* too often
https://bugs.webkit.org/show_bug.cgi?id=16090

Added a repaint example to make sure that setting the attributes x, y, width or height
doens't cause a repaint if the boundaries don't change.

  • platform/mac/svg/custom/repaint-on-constant-size-change-expected.checksum: Added.
  • platform/mac/svg/custom/repaint-on-constant-size-change-expected.png: Added.
  • platform/mac/svg/custom/repaint-on-constant-size-change-expected.txt: Added.
  • svg/custom/repaint-on-constant-size-change.svg: Added.
12:57 Changeset [69873] by mrobinson@webkit.org
  • 2 edits in trunk/WebCore

2010-10-15 Martin Robinson <mrobinson@igalia.com>

Build fix for GTK+.

  • platform/network/soup/cache/webkit/soup-cache.h: Do not use PLATFORM(...) macro in a file that does not include config.h
12:46 Changeset [69872] by krit@webkit.org
  • 21 edits
    20 adds in trunk/LayoutTests

2010-10-15 Dirk Schulze <krit@webkit.org>

Unreviewed rebaseline of Snow Leopard.

Moved current results for SVGFEConvolveMatrixElement to mac-leopard.

  • platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.checksum: Added.
  • platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.png: Added.
  • platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.checksum: Added.
  • platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.png: Added.
  • platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.checksum: Added.
  • platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.png: Added.
  • platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.checksum: Added.
  • platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.png: Added.
  • platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.checksum: Added.
  • platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.png: Added.
  • platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.checksum: Added.
  • platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.png: Added.
  • platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.checksum: Added.
  • platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.png: Added.
  • platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.checksum: Added.
  • platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.png: Added.
  • platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.checksum: Added.
  • platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png: Added.
  • platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.checksum: Added.
  • platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.png:
12:16 Changeset [69871] by andersca@apple.com
  • 6 edits
    1 copy
    1 add in trunk

Add FindIndicatorWindow class
https://bugs.webkit.org/show_bug.cgi?id=47731

Reviewed by Sam Weinig.

WebCore:

Export symbols needed by the FindIndicator in WebKit2.

  • WebCore.exp.in:

WebKit2:

  • UIProcess/API/mac/FindIndicatorWindow.h: Added.
  • UIProcess/API/mac/FindIndicatorWindow.mm: Added.

(-[WebFindIndicatorView _initWithFindIndicator:WebKit::]):
Initialize the find indicator view.

(-[WebFindIndicatorView drawRect:]):
Ask the find indicator to draw.

(-[WebFindIndicatorView isFlipped]):
Return YES.

(WebKit::FindIndicatorWindow::~FindIndicatorWindow):
Make sure to close the window.

(WebKit::FindIndicatorWindow::setFindIndicator):
Update the find indicator window.

(WebKit::FindIndicatorWindow::closeWindow):
Close and release the window.

  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::setFindIndicator):
Create a find indicator window.

  • WebKit2.xcodeproj/project.pbxproj:

Add new files.

11:48 Changeset [69870] by tony@chromium.org
  • 5 edits
    3 adds in trunk

2010-10-15 Tony Chang <tony@chromium.org>

Reviewed by Kent Tamura.

[chromium] compile TestNetscapePlugIn on Chromium mac
https://bugs.webkit.org/show_bug.cgi?id=47633

  • WebKit.gyp: Add a mac specific target for compiling TestNetscapePlugIn

Fix an include dir so we can compile in a chromium checkout.

2010-10-15 Tony Chang <tony@chromium.org>

Reviewed by Kent Tamura.

[chromium] compile TestNetscapePlugIn on Chromium mac
https://bugs.webkit.org/show_bug.cgi?id=47633

  • DumpRenderTree/DumpRenderTree.gypi: files to compile
  • DumpRenderTree/TestNetscapePlugIn/main.cpp: Use ifdef because gcc was complaining (NP_GetEntryPoints): (NPP_New): (NPP_Destroy): (NPP_HandleEvent): (NPP_GetValue):
  • DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: Added.
  • DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Added.
  • DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h: Added.
11:42 Changeset [69869] by leandro@webkit.org
  • 3 edits in trunk/WebCore

2010-10-15 Leandro Pereira <leandro@profusion.mobi>

[EFL] Unreviewed. Build fix.

Add new files needed by the Soup network backend, and #ifdef a
GTK+-port only include in soup-cache.h.

  • CMakeListsEfl.txt:
  • platform/network/soup/cache/webkit/soup-cache.h:
11:30 Changeset [69868] by darin@apple.com
  • 73 edits in trunk/WebCore

2010-10-14 Darin Adler <darin@apple.com>

Reviewed by Alexey Proskuryakov.

Use more specific types for node pointers, especially when calling node insertion and removal functions
https://bugs.webkit.org/show_bug.cgi?id=47702

Refactoring. No new tests.

While developing this patch I temporarily removed the node insertion and
removal member functions from the Node class and fixed almost all call sites
so they call it directly on the ContainerNode class, which will be important
once we make the functions non-virtual.

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkSelector):
  • dom/ContainerNode.cpp: (WebCore::ContainerNode::insertBefore): (WebCore::ContainerNode::replaceChild): (WebCore::ContainerNode::appendChild):
  • dom/Document.cpp: (WebCore::Document::caretRangeFromPoint):
  • dom/DynamicNodeList.cpp: (WebCore::DynamicNodeList::itemWithName):
  • dom/Position.cpp: (WebCore::Position::previous): (WebCore::Position::next):
  • dom/Text.cpp: (WebCore::Text::replaceWholeText):
  • dom/TreeWalker.cpp: (WebCore::TreeWalker::firstChild): (WebCore::TreeWalker::lastChild): (WebCore::TreeWalker::previousNode):
  • dom/XMLDocumentParserLibxml2.cpp: (WebCore::XMLDocumentParser::XMLDocumentParser):
  • editing/BreakBlockquoteCommand.cpp: (WebCore::BreakBlockquoteCommand::doApply):
  • editing/CompositeEditCommand.h:
  • editing/DeleteButtonController.cpp: (WebCore::isDeletableElement):
  • editing/IndentOutdentCommand.cpp: (WebCore::IndentOutdentCommand::outdentParagraph):
  • editing/InsertNodeBeforeCommand.cpp: (WebCore::InsertNodeBeforeCommand::doApply):
  • editing/JoinTextNodesCommand.cpp: (WebCore::JoinTextNodesCommand::doApply): (WebCore::JoinTextNodesCommand::doUnapply):
  • editing/MergeIdenticalElementsCommand.cpp: (WebCore::MergeIdenticalElementsCommand::doUnapply):
  • editing/RemoveNodeCommand.cpp: (WebCore::RemoveNodeCommand::doApply): (WebCore::RemoveNodeCommand::doUnapply):
  • editing/RemoveNodeCommand.h:
  • editing/SplitElementCommand.cpp: (WebCore::SplitElementCommand::executeApply):
  • editing/SplitTextNodeCommand.cpp: (WebCore::SplitTextNodeCommand::doApply): (WebCore::SplitTextNodeCommand::doReapply):
  • editing/TextIterator.cpp: (WebCore::parentCrossingShadowBoundaries):
  • editing/htmlediting.cpp: (WebCore::enclosingList):
  • editing/markup.cpp: (WebCore::serializeNodes): (WebCore::ancestorToRetainStructureAndAppearance): (WebCore::createMarkup):
  • html/HTMLAreaElement.cpp: (WebCore::HTMLAreaElement::updateFocusAppearance):
  • html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::rendererIsNeeded):
  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::rendererIsNeeded):
  • html/HTMLFrameSetElement.cpp: (WebCore::HTMLFrameSetElement::attach):
  • html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::insertedIntoTree):
  • html/HTMLLegendElement.cpp: (WebCore::HTMLLegendElement::associatedControl):
  • html/HTMLOptGroupElement.cpp: (WebCore::HTMLOptGroupElement::recalcSelectOptions): (WebCore::HTMLOptGroupElement::ownerSelectElement):
  • html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::ownerSelectElement):
  • html/HTMLTableCellElement.cpp: (WebCore::HTMLTableCellElement::additionalAttributeStyleDecls):
  • html/HTMLTableColElement.cpp: (WebCore::HTMLTableColElement::additionalAttributeStyleDecls):
  • html/HTMLTableElement.cpp: (WebCore::HTMLTableElement::insertRow):
  • html/HTMLTableRowElement.cpp: (WebCore::HTMLTableRowElement::rowIndex):
  • html/HTMLTableSectionElement.cpp: (WebCore::HTMLTableSectionElement::additionalAttributeStyleDecls):
  • page/DOMSelection.cpp: (WebCore::DOMSelection::getRangeAt): (WebCore::DOMSelection::containsNode):
  • rendering/RenderSVGGradientStop.cpp: (WebCore::RenderSVGGradientStop::gradientElement):
  • svg/SVGElement.cpp: (WebCore::SVGElement::ownerSVGElement): (WebCore::SVGElement::viewportElement):
  • svg/SVGFELightElement.cpp: (WebCore::SVGFELightElement::svgAttributeChanged): (WebCore::SVGFELightElement::childrenChanged):
  • svg/SVGFEMergeNodeElement.cpp: (WebCore::SVGFEMergeNodeElement::svgAttributeChanged):
  • svg/SVGFontFaceFormatElement.cpp: (WebCore::SVGFontFaceFormatElement::childrenChanged):
  • svg/SVGFontFaceUriElement.cpp: (WebCore::SVGFontFaceUriElement::childrenChanged):
  • svg/SVGGlyphElement.cpp: (WebCore::SVGGlyphElement::invalidateGlyphCache):
  • svg/SVGHKernElement.cpp: (WebCore::SVGHKernElement::insertedIntoDocument): (WebCore::SVGHKernElement::removedFromDocument):
  • svg/SVGLocatable.cpp: (WebCore::SVGLocatable::nearestViewportElement): (WebCore::SVGLocatable::farthestViewportElement):
  • svg/SVGUseElement.cpp: (WebCore::SVGUseElement::updateContainerOffsets):
  • svg/SVGVKernElement.cpp: (WebCore::SVGVKernElement::insertedIntoDocument): (WebCore::SVGVKernElement::removedFromDocument):
  • svg/animation/SVGSMILElement.cpp: (WebCore::SVGSMILElement::targetElement):
  • wml/WMLDoElement.cpp: (WebCore::WMLDoElement::insertedIntoDocument): (WebCore::WMLDoElement::removedFromDocument):
  • wml/WMLNoopElement.cpp: (WebCore::WMLNoopElement::insertedIntoDocument):
  • wml/WMLOptionElement.cpp: (WebCore::ownerSelectElement):
  • wml/WMLPostfieldElement.cpp: (WebCore::WMLPostfieldElement::insertedIntoDocument): (WebCore::WMLPostfieldElement::removedFromDocument):
  • wml/WMLSetvarElement.cpp: (WebCore::WMLSetvarElement::insertedIntoDocument): (WebCore::WMLSetvarElement::removedFromDocument):
  • wml/WMLTaskElement.cpp: (WebCore::WMLTaskElement::insertedIntoDocument): (WebCore::WMLTaskElement::removedFromDocument):
  • wml/WMLTimerElement.cpp: (WebCore::WMLTimerElement::insertedIntoDocument): (WebCore::WMLTimerElement::removedFromDocument):
  • xml/XPathStep.cpp: (WebCore::XPath::Step::nodesInAxis): Use ContainerNode* for the result of the parentNode function now that it returns a ContainerNode*. In the past it used to return just Node*.
  • dom/ContainerNode.h: Added toContainerNode.
  • dom/Element.h: Use ContainerNode*. Added toElement.
  • dom/Element.cpp: (WebCore::Element::deprecatedCreateContextualFragment): Explcitly cast to HTMLElement* in the case that handles <html> and <body> elements. (WebCore::Element::baseURI): Use ContainerNode*.
  • dom/Node.cpp: (WebCore::Node::markAncestorsWithChildNeedsStyleRecalc): Use ContainerNode*. (WebCore::Node::isDescendantOf): Ditto. (WebCore::Node::createRendererIfNeeded): Ditto. (WebCore::Node::setTextContent): Use already-typecast pointer in a call to appendChild. (WebCore::Node::ancestorElement): Use ContainerNode*.
  • dom/Range.cpp: (WebCore::Range::compareNode): Use ContainerNode*. (WebCore::Range::intersectsNode): Ditto. (WebCore::Range::processContents): Cast to ContainerNode* in a couple cases where we previously checked that the node in question has a child. Any node that returns a non-zero value for firstChild is a ContainerNode. (WebCore::Range::checkNodeBA): Ditto. (WebCore::Range::selectNode): Ditto. (WebCore::Range::surroundContents): Ditto.
  • dom/XMLDocumentParser.cpp: (WebCore::XMLDocumentParser::insertErrorMessageBlock): Rewrote code to use more specific types, document instead of doc, and paragraph instead of par.
  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::removeStyleFromRunBeforeApplyingStyle): Use ContainerNode*. (WebCore::ApplyStyleCommand::replaceWithSpanOrRemoveIfWithoutAttributes): Use replaceElementWithSpanPreservingChildrenAndAttributes; the old function took a Node argument and had Node in its name.
  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::removeNodeAndPruneAncestors): Use ContainerNode. (WebCore::CompositeEditCommand::replaceElementWithSpanPreservingChildrenAndAttributes): Renamed and changed to take HTMLElement. Also use ContainerNode. (WebCore::CompositeEditCommand::prune): Ditto. (WebCore::CompositeEditCommand::breakOutOfEmptyListItem): Ditto. (WebCore::CompositeEditCommand::breakOutOfEmptyMailBlockquotedParagraph): Ditto.
  • editing/ReplaceNodeWithSpanCommand.cpp: (WebCore::ReplaceNodeWithSpanCommand::ReplaceNodeWithSpanCommand): Take an HTMLElement instead of a Node. Call it m_elementToReplace instead of m_node. (WebCore::swapInNodePreservingAttributesAndChildren): Take HTMLElement. (WebCore::ReplaceNodeWithSpanCommand::doApply): Updated for name changes. (WebCore::ReplaceNodeWithSpanCommand::doUnapply): Ditto.
  • editing/ReplaceNodeWithSpanCommand.h: Ditto.
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplacementFragment::ReplacementFragment): Use StyledElement for result of insertFragmentForTestRendering since that's what it returns. (WebCore::ReplacementFragment::removeNode): Use ContainerNode. (WebCore::ReplacementFragment::insertNodeBefore): Ditto. (WebCore::ReplacementFragment::insertFragmentForTestRendering): Return StyledElement. Use HTMLElement for body. (WebCore::ReplacementFragment::restoreTestRenderingNodesToFragment): Take StyledElement. (WebCore::ReplaceSelectionCommand::handleStyleSpans): Use ContainerNode. (WebCore::ReplaceSelectionCommand::copyStyleToChildren): Use HTMLElement for the cloned span, since the clone will be a sspan too. (WebCore::ReplaceSelectionCommand::insertAsListItems): Use ContainerNode since the list item has a child, and that proves it is a ContainerNode.
  • editing/SelectionController.cpp: (WebCore::SelectionController::selectFrameElementInParentIfFullySelected): Use ContainerNode and also removed an unnneded local variable.
  • html/HTMLElement.cpp: (WebCore::HTMLElement::setOuterText): Use ContainerNode. (WebCore::HTMLElement::insertAdjacent): Use ContainerNode and also use && to make the logic a little simpler. (WebCore::contextElementForInsertion): Use ContainerNode. (WebCore::HTMLElement::findFormAncestor): Ditto.
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::removeNode): Use ContainerNode. (WebCore::InspectorDOMAgent::changeTagName): Ditto. (WebCore::InspectorDOMAgent::setOuterHTML): Ditto. (WebCore::InspectorDOMAgent::innerParentNode): Use isDocumentNode instead of nodeType. We should almost never use nodeType inside the engine. (WebCore::InspectorDOMAgent::didInsertDOMNode): Use ContainerNode. (WebCore::InspectorDOMAgent::didRemoveDOMNode): Ditto.
  • wml/WMLOptGroupElement.cpp: Removed unneeded overrides of insertBefore, replaceChild, removeChild, appendChild, and removeChildren functions. Ths already overrides childrenChanged, that is called by all of the above, and it does the same thing these functions did. (WebCore::ownerSelectElement): Use ContainerNode.
  • wml/WMLOptGroupElement.h: Ditto.
11:18 Changeset [69867] by jam@chromium.org
  • 2 edits in branches/chromium/552/WebKit/chromium

2010-10-14 John Abd-El-Malek <jam@chromium.org>

Reviewed by Tony Chang.

[chromium] null check the widget before sending it data as calling didReceiveData might delete it
https://bugs.webkit.org/show_bug.cgi?id=47708

  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::committedLoad):
11:12 Changeset [69866] by andersca@apple.com
  • 3 edits in trunk/WebKit2

[GTK] Fix introspection support
https://bugs.webkit.org/show_bug.cgi?id=47723

Patch by Sergio Villar Senin <svillar@igalia.com> on 2010-10-15
Reviewed by Martin Robinson.

Added HTTP cache directory to the WebkitGtk+ GIR sources.

  • GNUmakefile.am:
11:05 Changeset [69865] by rniwa@webkit.org
  • 3 edits
    2 adds in trunk

2010-10-15 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

Crash in WebCore::ApplyStyleCommand::applyBlockStyle
https://bugs.webkit.org/show_bug.cgi?id=47699

The crash was caused by applyBlockStyle's invalidly assuming that visibleStart and visibleEnd always exist.
Added an early exit to the function when either visibleStart or visibleEnd is null or orphaned.

Test: editing/style/block-style-progress-crash.html

  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyBlockStyle):

2010-10-15 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

Crash in WebCore::ApplyStyleCommand::applyBlockStyle
https://bugs.webkit.org/show_bug.cgi?id=47699

Added a test to ensure WebKit does not crash when the body is content editable
and justifying a progress element and '>' following the element to the right.

  • editing/style/block-style-progress-crash-expected.txt: Added.
  • editing/style/block-style-progress-crash.html: Added.
10:53 Changeset [69864] by alex@webkit.org
  • 2 edits in trunk/LayoutTests

2010-10-15 Alejandro G. Castro <alex@igalia.com>

Unreviewed, skipped flaky tests, added followup bug:
https://bugs.webkit.org/show_bug.cgi?id=47727

  • platform/gtk/Skipped:
10:37 Changeset [69863] by commit-queue@webkit.org
  • 2 edits in trunk/WebKitTools

2010-10-15 Leandro Pereira <leandro@profusion.mobi>

Reviewed by Gustavo Noronha Silva.

build-webkit: Should die when make fails when build a CMake project
https://bugs.webkit.org/show_bug.cgi?id=47726

  • Scripts/webkitdirs.pm: If make fails, die immediately.
10:27 Changeset [69862] by andersca@apple.com
  • 19 edits
    1 copy
    1 add in trunk

Add a FindIndicator class
https://bugs.webkit.org/show_bug.cgi?id=47635

Reviewed by Sam Weinig.

WebCore:

Make Gradient.h and Generator.h private headers; they're used by WebKit2.

  • WebCore.xcodeproj/project.pbxproj:

WebKit2:

  • Shared/BackingStore.h:

(WebKit::BackingStore::bounds):
New function that returns the bounds of the backing store.

  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::setFindIndicator):
Add stub.

  • UIProcess/API/qt/qwkpage.cpp:

(QWKPagePrivate::setFindIndicator):
Add stub.

  • UIProcess/FindIndicator.cpp: Added.
  • UIProcess/FindIndicator.h:
  • UIProcess/PageClient.h:

Add setFindIndicator client member function.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::setFindIndicator):
Call PageClient::setFindIndicator.

  • UIProcess/WebPageProxy.messages.in:

Add a fadeOut boolean to the message.

  • UIProcess/win/WebView.cpp:

(WebKit::WebView::setFindIndicator):
Add stub.

  • UIProcess/win/WebView.h:
  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebPage/FindController.cpp:

(WebKit::FindController::findString):
(WebKit::FindController::updateFindIndicator):
(WebKit::FindController::resetFindIndicator):

  • WebProcess/WebPage/FindController.h:
  • win/WebKit2.vcproj:
10:12 Changeset [69861] by commit-queue@webkit.org
  • 3 edits
    4 adds in trunk

2010-10-15 Sergio Villar Senin <svillar@igalia.com>

Reviewed by Gustavo Noronha Silva.

[Soup] Should not ignore body for redirection responses
https://bugs.webkit.org/show_bug.cgi?id=29299

Tests that 302 redirections without Location do not ignore the
body for redirection purpouses (the body could have a meta
http-equiv=refresh)

  • http/tests/navigation/redirect302-metaredirect-expected.txt: Added.
  • http/tests/navigation/redirect302-metaredirect.html: Added.
  • http/tests/navigation/resources/redirect302-metaredirect.html: Added.
  • http/tests/navigation/resources/redirect302-metaredirect.pl: Added.

2010-10-15 Sergio Villar Senin <svillar@igalia.com>

Reviewed by Gustavo Noronha Silva.

[Soup] Should not ignore body for redirection responses
https://bugs.webkit.org/show_bug.cgi?id=29299

Body is now provided to WebKitGtk+ in some redirections (like 302)
because it could be used by servers to perform clunky redirections
for example using http-equiv=REFRESH

Test: http/tests/navigation/redirect302-metaredirect.html

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::gotHeadersCallback): (WebCore::finishedCallback):
10:06 Changeset [69860] by japhet@chromium.org
  • 2 edits in trunk/LayoutTests

2010-10-15 Nate Chapin <japhet@chromium.org>

Unreviewed, Chromium expectations tweak.

Add failing tests from r69824 and r69833.

  • platform/chromium/test_expectations.txt:
09:54 Changeset [69859] by jorlow@chromium.org
  • 57 edits in branches/chromium/552

BUG=58992

IndexedDB should fire some errors synchronously
https://bugs.webkit.org/show_bug.cgi?id=47530

Reviewed by Nate Chapin.

LayoutTests:

  • storage/indexeddb/objectstore-basics-expected.txt:
  • storage/indexeddb/objectstore-basics.html:
  • storage/indexeddb/objectstore-removeobjectstore-expected.txt:
  • storage/indexeddb/objectstore-removeobjectstore.html:

WebCore:

Add dumb plumbing to pass around exception codes.
Utilize that plumbing in the backend to fire some
errors synchronously.
Verify that create/remove* functions are only called
in setVersionTransactions (and raise when not).
Remove plumbing for obsolete IDBDatabase.objectStore
Remove obsolete mode param.

  • storage/IDBCursor.cpp:

(WebCore::IDBCursor::update):
(WebCore::IDBCursor::continueFunction):
(WebCore::IDBCursor::remove):

  • storage/IDBCursor.h:

(WebCore::IDBCursor::continueFunction):

  • storage/IDBCursor.idl:
  • storage/IDBCursorBackendImpl.cpp:

(WebCore::IDBCursorBackendImpl::update):
(WebCore::IDBCursorBackendImpl::continueFunction):
(WebCore::IDBCursorBackendImpl::remove):

  • storage/IDBCursorBackendImpl.h:
  • storage/IDBCursorBackendInterface.h:
  • storage/IDBDatabase.cpp:

(WebCore::IDBDatabase::IDBDatabase):
(WebCore::IDBDatabase::createObjectStore):
(WebCore::IDBDatabase::removeObjectStore):
(WebCore::IDBDatabase::setVersion):
(WebCore::IDBDatabase::transaction):

  • storage/IDBDatabase.h:

(WebCore::IDBDatabase::createObjectStore):
(WebCore::IDBDatabase::transaction):

  • storage/IDBDatabase.idl:
  • storage/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::createObjectStore):
(WebCore::IDBDatabaseBackendImpl::objectStore):
(WebCore::IDBDatabaseBackendImpl::removeObjectStore):
(WebCore::IDBDatabaseBackendImpl::setVersion):
(WebCore::IDBDatabaseBackendImpl::transaction):

  • storage/IDBDatabaseBackendImpl.h:
  • storage/IDBDatabaseBackendInterface.h:
  • storage/IDBFactory.cpp:

(WebCore::IDBFactory::open):

  • storage/IDBFactory.h:

(WebCore::IDBFactory::open):

  • storage/IDBFactory.idl:
  • storage/IDBIndex.cpp:

(WebCore::IDBIndex::openCursor):
(WebCore::IDBIndex::openKeyCursor):
(WebCore::IDBIndex::get):
(WebCore::IDBIndex::getKey):

  • storage/IDBIndex.h:

(WebCore::IDBIndex::openCursor):
(WebCore::IDBIndex::openKeyCursor):

  • storage/IDBIndex.idl:
  • storage/IDBIndexBackendImpl.cpp:

(WebCore::IDBIndexBackendImpl::openCursor):
(WebCore::IDBIndexBackendImpl::openKeyCursor):
(WebCore::IDBIndexBackendImpl::get):
(WebCore::IDBIndexBackendImpl::getKey):

  • storage/IDBIndexBackendImpl.h:
  • storage/IDBIndexBackendInterface.h:
  • storage/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::get):
(WebCore::IDBObjectStore::add):
(WebCore::IDBObjectStore::put):
(WebCore::IDBObjectStore::remove):
(WebCore::IDBObjectStore::createIndex):
(WebCore::IDBObjectStore::index):
(WebCore::IDBObjectStore::removeIndex):
(WebCore::IDBObjectStore::openCursor):

  • storage/IDBObjectStore.h:

(WebCore::IDBObjectStore::add):
(WebCore::IDBObjectStore::put):
(WebCore::IDBObjectStore::createIndex):
(WebCore::IDBObjectStore::openCursor):

  • storage/IDBObjectStore.idl:
  • storage/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::get):
(WebCore::IDBObjectStoreBackendImpl::put):
(WebCore::IDBObjectStoreBackendImpl::remove):
(WebCore::IDBObjectStoreBackendImpl::createIndex):
(WebCore::IDBObjectStoreBackendImpl::index):
(WebCore::IDBObjectStoreBackendImpl::removeIndex):
(WebCore::IDBObjectStoreBackendImpl::openCursor):

  • storage/IDBObjectStoreBackendImpl.h:

(WebCore::IDBObjectStoreBackendImpl::name):
(WebCore::IDBObjectStoreBackendImpl::keyPath):
(WebCore::IDBObjectStoreBackendImpl::autoIncrement):

  • storage/IDBObjectStoreBackendInterface.h:
  • storage/IDBTransaction.cpp:

(WebCore::IDBTransaction::objectStore):

  • storage/IDBTransaction.h:
  • storage/IDBTransactionBackendImpl.cpp:

(WebCore::IDBTransactionBackendImpl::objectStore):

WebKit/chromium:

  • public/WebIDBCursor.h:
  • public/WebIDBDatabase.h:

(WebKit::WebIDBDatabase::transaction):

  • public/WebIDBFactory.h:

(WebKit::WebIDBFactory::open):

  • public/WebIDBObjectStore.h:
  • public/WebIDBTransactionCallbacks.h:
  • src/IDBCursorBackendProxy.cpp:

(WebCore::IDBCursorBackendProxy::update):
(WebCore::IDBCursorBackendProxy::continueFunction):
(WebCore::IDBCursorBackendProxy::remove):

  • src/IDBCursorBackendProxy.h:
  • src/IDBDatabaseProxy.cpp:

(WebCore::IDBDatabaseProxy::createObjectStore):
(WebCore::IDBDatabaseProxy::removeObjectStore):
(WebCore::IDBDatabaseProxy::setVersion):
(WebCore::IDBDatabaseProxy::transaction):

  • src/IDBDatabaseProxy.h:
  • src/IDBIndexBackendProxy.cpp:

(WebCore::IDBIndexBackendProxy::openCursor):
(WebCore::IDBIndexBackendProxy::openKeyCursor):
(WebCore::IDBIndexBackendProxy::get):
(WebCore::IDBIndexBackendProxy::getKey):

  • src/IDBIndexBackendProxy.h:
  • src/IDBObjectStoreProxy.cpp:

(WebCore::IDBObjectStoreProxy::get):
(WebCore::IDBObjectStoreProxy::put):
(WebCore::IDBObjectStoreProxy::remove):
(WebCore::IDBObjectStoreProxy::createIndex):
(WebCore::IDBObjectStoreProxy::index):
(WebCore::IDBObjectStoreProxy::removeIndex):
(WebCore::IDBObjectStoreProxy::openCursor):

  • src/IDBObjectStoreProxy.h:
  • src/WebIDBCursorImpl.cpp:

(WebKit::WebIDBCursorImpl::update):
(WebKit::WebIDBCursorImpl::continueFunction):
(WebKit::WebIDBCursorImpl::remove):

  • src/WebIDBCursorImpl.h:
  • src/WebIDBDatabaseImpl.cpp:

(WebKit::WebIDBDatabaseImpl::createObjectStore):
(WebKit::WebIDBDatabaseImpl::removeObjectStore):
(WebKit::WebIDBDatabaseImpl::setVersion):
(WebKit::WebIDBDatabaseImpl::transaction):

  • src/WebIDBDatabaseImpl.h:
  • src/WebIDBIndexImpl.cpp:

(WebKit::WebIDBIndexImpl::openObjectCursor):
(WebKit::WebIDBIndexImpl::openKeyCursor):
(WebKit::WebIDBIndexImpl::getObject):
(WebKit::WebIDBIndexImpl::getKey):

  • src/WebIDBIndexImpl.h:
  • src/WebIDBObjectStoreImpl.cpp:

(WebKit::WebIDBObjectStoreImpl::get):
(WebKit::WebIDBObjectStoreImpl::put):
(WebKit::WebIDBObjectStoreImpl::remove):
(WebKit::WebIDBObjectStoreImpl::createIndex):
(WebKit::WebIDBObjectStoreImpl::index):
(WebKit::WebIDBObjectStoreImpl::removeIndex):
(WebKit::WebIDBObjectStoreImpl::openCursor):

  • src/WebIDBObjectStoreImpl.h:

Merge 69721 - 2010-10-13 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Nate Chapin.

IndexedDB should fire some errors synchronously
https://bugs.webkit.org/show_bug.cgi?id=47530

  • storage/indexeddb/objectstore-basics-expected.txt:
  • storage/indexeddb/objectstore-basics.html:
  • storage/indexeddb/objectstore-removeobjectstore-expected.txt:
  • storage/indexeddb/objectstore-removeobjectstore.html:

2010-10-13 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Nate Chapin.

IndexedDB should fire some errors synchronously
https://bugs.webkit.org/show_bug.cgi?id=47530

Add dumb plumbing to pass around exception codes.
Utilize that plumbing in the backend to fire some
errors synchronously.
Verify that create/remove* functions are only called
in setVersionTransactions (and raise when not).
Remove plumbing for obsolete IDBDatabase.objectStore
Remove obsolete mode param.

  • storage/IDBCursor.cpp: (WebCore::IDBCursor::update): (WebCore::IDBCursor::continueFunction): (WebCore::IDBCursor::remove):
  • storage/IDBCursor.h: (WebCore::IDBCursor::continueFunction):
  • storage/IDBCursor.idl:
  • storage/IDBCursorBackendImpl.cpp: (WebCore::IDBCursorBackendImpl::update): (WebCore::IDBCursorBackendImpl::continueFunction): (WebCore::IDBCursorBackendImpl::remove):
  • storage/IDBCursorBackendImpl.h:
  • storage/IDBCursorBackendInterface.h:
  • storage/IDBDatabase.cpp: (WebCore::IDBDatabase::IDBDatabase): (WebCore::IDBDatabase::createObjectStore): (WebCore::IDBDatabase::removeObjectStore): (WebCore::IDBDatabase::setVersion): (WebCore::IDBDatabase::transaction):
  • storage/IDBDatabase.h: (WebCore::IDBDatabase::createObjectStore): (WebCore::IDBDatabase::transaction):
  • storage/IDBDatabase.idl:
  • storage/IDBDatabaseBackendImpl.cpp: (WebCore::IDBDatabaseBackendImpl::createObjectStore): (WebCore::IDBDatabaseBackendImpl::objectStore): (WebCore::IDBDatabaseBackendImpl::removeObjectStore): (WebCore::IDBDatabaseBackendImpl::setVersion): (WebCore::IDBDatabaseBackendImpl::transaction):
  • storage/IDBDatabaseBackendImpl.h:
  • storage/IDBDatabaseBackendInterface.h:
  • storage/IDBFactory.cpp: (WebCore::IDBFactory::open):
  • storage/IDBFactory.h: (WebCore::IDBFactory::open):
  • storage/IDBFactory.idl:
  • storage/IDBIndex.cpp: (WebCore::IDBIndex::openCursor): (WebCore::IDBIndex::openKeyCursor): (WebCore::IDBIndex::get): (WebCore::IDBIndex::getKey):
  • storage/IDBIndex.h: (WebCore::IDBIndex::openCursor): (WebCore::IDBIndex::openKeyCursor):
  • storage/IDBIndex.idl:
  • storage/IDBIndexBackendImpl.cpp: (WebCore::IDBIndexBackendImpl::openCursor): (WebCore::IDBIndexBackendImpl::openKeyCursor): (WebCore::IDBIndexBackendImpl::get): (WebCore::IDBIndexBackendImpl::getKey):
  • storage/IDBIndexBackendImpl.h:
  • storage/IDBIndexBackendInterface.h:
  • storage/IDBObjectStore.cpp: (WebCore::IDBObjectStore::get): (WebCore::IDBObjectStore::add): (WebCore::IDBObjectStore::put): (WebCore::IDBObjectStore::remove): (WebCore::IDBObjectStore::createIndex): (WebCore::IDBObjectStore::index): (WebCore::IDBObjectStore::removeIndex): (WebCore::IDBObjectStore::openCursor):
  • storage/IDBObjectStore.h: (WebCore::IDBObjectStore::add): (WebCore::IDBObjectStore::put): (WebCore::IDBObjectStore::createIndex): (WebCore::IDBObjectStore::openCursor):
  • storage/IDBObjectStore.idl:
  • storage/IDBObjectStoreBackendImpl.cpp: (WebCore::IDBObjectStoreBackendImpl::get): (WebCore::IDBObjectStoreBackendImpl::put): (WebCore::IDBObjectStoreBackendImpl::remove): (WebCore::IDBObjectStoreBackendImpl::createIndex): (WebCore::IDBObjectStoreBackendImpl::index): (WebCore::IDBObjectStoreBackendImpl::removeIndex): (WebCore::IDBObjectStoreBackendImpl::openCursor):
  • storage/IDBObjectStoreBackendImpl.h: (WebCore::IDBObjectStoreBackendImpl::name): (WebCore::IDBObjectStoreBackendImpl::keyPath): (WebCore::IDBObjectStoreBackendImpl::autoIncrement):
  • storage/IDBObjectStoreBackendInterface.h:
  • storage/IDBTransaction.cpp: (WebCore::IDBTransaction::objectStore):
  • storage/IDBTransaction.h:
  • storage/IDBTransactionBackendImpl.cpp: (WebCore::IDBTransactionBackendImpl::objectStore):

2010-10-13 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Nate Chapin.

IndexedDB should fire some errors synchronously
https://bugs.webkit.org/show_bug.cgi?id=47530

  • public/WebIDBCursor.h:
  • public/WebIDBDatabase.h: (WebKit::WebIDBDatabase::transaction):
  • public/WebIDBFactory.h: (WebKit::WebIDBFactory::open):
  • public/WebIDBObjectStore.h:
  • public/WebIDBTransactionCallbacks.h:
  • src/IDBCursorBackendProxy.cpp: (WebCore::IDBCursorBackendProxy::update): (WebCore::IDBCursorBackendProxy::continueFunction): (WebCore::IDBCursorBackendProxy::remove):
  • src/IDBCursorBackendProxy.h:
  • src/IDBDatabaseProxy.cpp: (WebCore::IDBDatabaseProxy::createObjectStore): (WebCore::IDBDatabaseProxy::removeObjectStore): (WebCore::IDBDatabaseProxy::setVersion): (WebCore::IDBDatabaseProxy::transaction):
  • src/IDBDatabaseProxy.h:
  • src/IDBIndexBackendProxy.cpp: (WebCore::IDBIndexBackendProxy::openCursor): (WebCore::IDBIndexBackendProxy::openKeyCursor): (WebCore::IDBIndexBackendProxy::get): (WebCore::IDBIndexBackendProxy::getKey):
  • src/IDBIndexBackendProxy.h:
  • src/IDBObjectStoreProxy.cpp: (WebCore::IDBObjectStoreProxy::get): (WebCore::IDBObjectStoreProxy::put): (WebCore::IDBObjectStoreProxy::remove): (WebCore::IDBObjectStoreProxy::createIndex): (WebCore::IDBObjectStoreProxy::index): (WebCore::IDBObjectStoreProxy::removeIndex): (WebCore::IDBObjectStoreProxy::openCursor):
  • src/IDBObjectStoreProxy.h:
  • src/WebIDBCursorImpl.cpp: (WebKit::WebIDBCursorImpl::update): (WebKit::WebIDBCursorImpl::continueFunction): (WebKit::WebIDBCursorImpl::remove):
  • src/WebIDBCursorImpl.h:
  • src/WebIDBDatabaseImpl.cpp: (WebKit::WebIDBDatabaseImpl::createObjectStore): (WebKit::WebIDBDatabaseImpl::removeObjectStore): (WebKit::WebIDBDatabaseImpl::setVersion): (WebKit::WebIDBDatabaseImpl::transaction):
  • src/WebIDBDatabaseImpl.h:
  • src/WebIDBIndexImpl.cpp: (WebKit::WebIDBIndexImpl::openObjectCursor): (WebKit::WebIDBIndexImpl::openKeyCursor): (WebKit::WebIDBIndexImpl::getObject): (WebKit::WebIDBIndexImpl::getKey):
  • src/WebIDBIndexImpl.h:
  • src/WebIDBObjectStoreImpl.cpp: (WebKit::WebIDBObjectStoreImpl::get): (WebKit::WebIDBObjectStoreImpl::put): (WebKit::WebIDBObjectStoreImpl::remove): (WebKit::WebIDBObjectStoreImpl::createIndex): (WebKit::WebIDBObjectStoreImpl::index): (WebKit::WebIDBObjectStoreImpl::removeIndex): (WebKit::WebIDBObjectStoreImpl::openCursor):
  • src/WebIDBObjectStoreImpl.h:

TBR=jorlow@chromium.org

09:48 Changeset [69858] by commit-queue@webkit.org
  • 4 edits in trunk

2010-10-15 Sergio Villar Senin <svillar@igalia.com>

Reviewed by Martin Robinson.

[GTK] Fix introspection support
https://bugs.webkit.org/show_bug.cgi?id=47723

Added HTTP cache directory to the WebkitGtk+ GIR sources.

  • GNUmakefile.am:

2010-10-15 Sergio Villar Senin <svillar@igalia.com>

Reviewed by Martin Robinson.

[GTK] Fix introspection support
https://bugs.webkit.org/show_bug.cgi?id=47723

WebKitSoupCacheType was incorrectly registered twice. Renamed to
WebKitSoupCacheTypeType for the enumerated type.

  • platform/network/soup/cache/webkit/soup-cache.c: (webkit_soup_cache_type_get_type):
09:43 WebKitGtkLayoutTests edited by kov@webkit.org
(diff)
09:30 Changeset [69857] by commit-queue@webkit.org
  • 5 edits
    3 deletes in trunk

2010-10-15 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r69809.
http://trac.webkit.org/changeset/69809
https://bugs.webkit.org/show_bug.cgi?id=47725

Broke chromium mac compile (Requested by japhet on #webkit).

  • WebKit.gyp:

2010-10-15 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r69809.
http://trac.webkit.org/changeset/69809
https://bugs.webkit.org/show_bug.cgi?id=47725

Broke chromium mac compile (Requested by japhet on #webkit).

  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/TestNetscapePlugIn/main.cpp: (NP_GetEntryPoints): (NPP_New): (NPP_Destroy): (NPP_HandleEvent): (NPP_GetValue):
  • DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: Removed.
  • DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Removed.
  • DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h: Removed.
09:27 Changeset [69856] by commit-queue@webkit.org
  • 3 edits in trunk/WebKit/qt

2010-10-15 Qi Zhang <qi.2.zhang@nokia.com>

Reviewed by Andreas Kling.

[Qt] window.close() doesn't work in qt
https://bugs.webkit.org/show_bug.cgi?id=46186

Introduce new attribute in QWebSettings to trigger "setAllowScriptsToCloseWindow"

  • Api/qwebsettings.cpp: (QWebSettingsPrivate::apply):
  • Api/qwebsettings.h:
08:56 Changeset [69855] by mrobinson@webkit.org
  • 3 edits
    2 copies
    1 add in trunk/LayoutTests

2010-10-15 Martin Robinson <mrobinson@igalia.com>

Fix my rebaseline sanfu.

  • fast/forms/mailto/advanced-get.html:
  • fast/forms/mailto/advanced-put.html:
  • platform/gtk/fast/forms/mailto/advanced-get-expected.txt: Copied from LayoutTests/fast/forms/mailto/advanced-get-expected.txt.
  • platform/gtk/fast/forms/mailto/advanced-put-expected.txt: Copied from LayoutTests/fast/forms/mailto/advanced-put-expected.txt.
08:34 Changeset [69854] by mrobinson@webkit.org
  • 3 edits in trunk/LayoutTests

2010-10-15 Martin Robinson <mrobinson@igalia.com>

Rebaseline a few other failing tests. They differ because
dumpAsText output depends on whether or not certain content
reaches the edge of the view and wraps.

  • fast/forms/mailto/advanced-get.html:
  • fast/forms/mailto/advanced-put.html:
08:20 Changeset [69853] by loislo@chromium.org
  • 7 edits in trunk/WebCore

2010-10-15 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: extract consoleMessages related stuff from populateScriptObjects into separate function.

This is a part of Inspector protocol sanitization activity.
We want to populate console messages only if it is required by frontend.

https://bugs.webkit.org/show_bug.cgi?id=46802

  • inspector/Inspector.idl:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::setConsoleMessagesEnabled): (WebCore::InspectorController::addConsoleMessage): (WebCore::InspectorController::disconnectFrontend): (WebCore::InspectorController::populateScriptObjects):
  • inspector/InspectorController.h:
  • inspector/InspectorState.cpp: (WebCore::InspectorState::InspectorState):
  • inspector/InspectorState.h:
  • inspector/front-end/inspector.js: (WebInspector.doLoadedDone):
08:11 Changeset [69852] by jberlin@webkit.org
  • 2 edits in trunk/WebKit/win

Windows build fix. Unreviewed.

  • WebCoreSupport/WebInspectorClient.cpp:

Add a missing include.

06:56 Changeset [69851] by andreas.kling@nokia.com
  • 2 edits in trunk/WebKit/qt

2010-10-15 Andreas Kling <kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Unbreak scrolling the ContentsLayer with QWebView

r69777 broke scrolling the contents layer in QWebView by not restoring
the painter clip after painting each part of the dirty region.

  • Api/qwebframe.cpp: (QWebFramePrivate::renderRelativeCoords):
05:29 Changeset [69850] by zimmermann@webkit.org
  • 17 edits in trunk

2010-10-15 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Replace some String::format() usages by StringConcatenate in WebKit
https://bugs.webkit.org/show_bug.cgi?id=47714

  • wtf/text/StringConcatenate.h: Add UChar specific StringTypeAdapter, to accept single UChars in makeString().

2010-10-15 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Replace some String::format() usages by StringConcatenate in WebKit
https://bugs.webkit.org/show_bug.cgi?id=47714

  • src/BackForwardListClientImpl.cpp: (WebKit::BackForwardListClientImpl::itemAtIndex):
  • src/DebuggerAgentManager.cpp: (WebKit::DebuggerAgentManager::debugDetach):
  • src/LocalizedStrings.cpp: (WebCore::imageTitle):
  • src/WebPageSerializer.cpp: (WebKit::WebPageSerializer::generateMetaCharsetDeclaration): (WebKit::WebPageSerializer::generateBaseTagDeclaration):

2010-10-15 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Replace some String::format() usages by StringConcatenate in WebKit
https://bugs.webkit.org/show_bug.cgi?id=47714

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchDidFailLoad):
  • webkit/webkitwebsettings.cpp: (webkitOSVersion): (webkitUserAgent):

2010-10-15 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Replace some String::format() usages by StringConcatenate in WebKit
https://bugs.webkit.org/show_bug.cgi?id=47714

  • WebCoreSupport/WebInspectorClient.cpp: (WebInspectorFrontendClient::updateWindowTitle):
  • WebView.cpp: (WebView::standardUserAgentWithApplicationName): (osVersion):

2010-10-15 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Replace some String::format() usages by StringConcatenate in WebKit
https://bugs.webkit.org/show_bug.cgi?id=47714

  • WebCoreSupport/PlatformStrategiesWinCE.cpp: (PlatformStrategiesWinCE::imageTitle): (PlatformStrategiesWinCE::multipleFileUploadText):

2010-10-15 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Replace some String::format() usages by StringConcatenate in WebKit
https://bugs.webkit.org/show_bug.cgi?id=47714

  • WebCoreSupport/FrameLoaderClientEfl.cpp: (WebCore::agentOS):
05:23 Changeset [69849] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-10-15 Ryuan Choi <ryuan.choi@samsung.com>

Reviewed by Nikolas Zimmermann.

[EFL] REGRESSION(69798) UCHAR can't be converted to String.
https://bugs.webkit.org/show_bug.cgi?id=47698

Create String value using String(const char*, 1) instead of operator[].

No tests. No functionality changed.

  • platform/efl/PlatformKeyboardEventEfl.cpp: (WebCore::createWindowsKeyMap):
03:39 Changeset [69848] by commit-queue@webkit.org
  • 3 edits in trunk/WebCore

2010-10-15 Sergio Villar Senin <svillar@igalia.com>

Reviewed by Xan Lopez.

[GTK] Do a stricter check for invalid base64 dataURLs
https://bugs.webkit.org/show_bug.cgi?id=47717

Restore the strict base64 decoding we added in
https://bugs.webkit.org/show_bug.cgi?id=44261 and then rolled back
in https://bugs.webkit.org/show_bug.cgi?id=47666 due to a failing
test. The actual issue was that we were not finishing the load of
the resource gracefully when an error happened.

Loading invalid base64-encoded data:// URLs are now handled
properly.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::parseDataUrl):
  • platform/network/soup/cache/soup-request-data.c: (webkit_soup_request_data_send):
02:04 Changeset [69847] by loislo@chromium.org
  • 2 edits in trunk/JavaScriptCore

2010-10-15 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed build fix for Debug Leopard which is failng to compile after r69842.

  • yarr/RegexInterpreter.cpp: (JSC::Yarr::ByteCompiler::emitDisjunction):
01:47 Changeset [69846] by alex@webkit.org
  • 3 edits in trunk/LayoutTests

2010-10-15 Alejandro G. Castro <alex@igalia.com>

Rebaseline some failing tests to the former results, apparently
they are flaky, skip if they continue failing.

  • platform/gtk/mathml/presentation/fenced-expected.txt:
  • platform/gtk/mathml/presentation/subsup-expected.txt:
01:33 Changeset [69845] by alex@webkit.org
  • 3 edits in trunk/WebCore

2010-10-15 Alejandro G. Castro <alex@igalia.com>

Reviewed by Martin Robinson.

compile fail with gtk >= 2.22
https://bugs.webkit.org/show_bug.cgi?id=47483

  • platform/graphics/gtk/FontGtk.cpp: Removed the shrink operation, it was added long time ago and currently it is not adding any real area to the clip vertically, actually the gtk3 shrink version did not work. (WebCore::Font::drawComplexText):
  • platform/gtk/gtk2drawing.c: Undef the deprecation flags, this file is full of gtk2 stuff, and it does not seem interesting to upgrade because we are already creating a new version of the file for gtk3.
01:31 Changeset [69844] by loislo@chromium.org
  • 15 edits
    2 adds in trunk

2010-10-14 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: inspector settings/properties/states management
should be extracted into separate class.

We have a lot of flags/values in InspectorController.
Some flags are persisting into profile.
Others are part of inspector state for frontend.
All these flags should keep their values after navigation.
It'd be better to extract these flags/values into separate
class which will care about theirs lifetime.

https://bugs.webkit.org/show_bug.cgi?id=47275

WebCore:

  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.exp.in:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::inspectorStartsAttached): (WebCore::InspectorController::setInspectorStartsAttached): (WebCore::InspectorController::setInspectorAttachedHeight): (WebCore::InspectorController::inspectorAttachedHeight): (WebCore::InspectorController::searchingForNodeInPage): (WebCore::InspectorController::resourceTrackingEnabled): (WebCore::InspectorController::saveApplicationSettings): (WebCore::InspectorController::getInspectorState): (WebCore::InspectorController::restoreInspectorStateFromCookie): (WebCore::InspectorController::getSettings): (WebCore::InspectorController::storeLastActivePanel): (WebCore::InspectorController::mouseDidMoveOverElement): (WebCore::InspectorController::handleMousePress): (WebCore::InspectorController::setSearchingForNode): (WebCore::InspectorController::setMonitoringXHREnabled): (WebCore::InspectorController::showPanel): (WebCore::InspectorController::disconnectFrontend): (WebCore::InspectorController::populateScriptObjects): (WebCore::InspectorController::restoreDebugger): (WebCore::InspectorController::restoreProfiler): (WebCore::InspectorController::getTrackedResource): (WebCore::InspectorController::didLoadResourceFromMemoryCache): (WebCore::InspectorController::identifierForInitialRequest): (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest): (WebCore::InspectorController::scriptImported): (WebCore::InspectorController::setResourceTrackingEnabled): (WebCore::InspectorController::ensureSettingsLoaded): (WebCore::InspectorController::startTimelineProfiler): (WebCore::InspectorController::stopTimelineProfiler): (WebCore::InspectorController::enableProfiler): (WebCore::InspectorController::disableProfiler): (WebCore::InspectorController::enableDebuggerFromFrontend): (WebCore::InspectorController::disableDebugger): (WebCore::InspectorController::loadBreakpoints): (WebCore::InspectorController::saveBreakpoints):
  • inspector/InspectorController.h:
  • inspector/InspectorFrontendClientLocal.cpp: (WebCore::InspectorFrontendClientLocal::changeAttachedWindowHeight): (WebCore::InspectorFrontendClientLocal::restoreAttachedWindowHeight):
  • inspector/InspectorState.cpp: Added. (WebCore::InspectorState::InspectorState): (WebCore::InspectorState::restoreFromInspectorCookie): (WebCore::InspectorState::generateStateObjectForFrontend): (WebCore::InspectorState::loadFromSettings): (WebCore::InspectorState::updateCookie): (WebCore::InspectorState::setValue): (WebCore::InspectorState::getBoolean): (WebCore::InspectorState::getString): (WebCore::InspectorState::getLong): (WebCore::InspectorState::registerBoolean): (WebCore::InspectorState::registerString): (WebCore::InspectorState::registerLong): (WebCore::InspectorState::Property::create):
  • inspector/InspectorState.h: Added. (WebCore::InspectorState::setBoolean): (WebCore::InspectorState::setString): (WebCore::InspectorState::setLong):

WebKit/mac:

  • WebCoreSupport/WebInspectorClient.mm: (-[WebInspectorWindowController showWindow:]): (-[WebInspectorWindowController attach]): (-[WebInspectorWindowController detach]):

WebKit/win:

  • WebCoreSupport/WebInspectorClient.cpp: (WebInspectorFrontendClient::attachWindow): (WebInspectorFrontendClient::detachWindow): (WebInspectorFrontendClient::showWindowWithoutNotifications):
01:20 Changeset [69843] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-10-15 Adam Barth <abarth@webkit.org>

Reviewed by Adam Barth.

test-webkitpy fails on Linux
https://bugs.webkit.org/show_bug.cgi?id=47713

The old code failed on Linux because the MacPort tries to read
something out of platform that doesn't make sense on Linux.

  • Scripts/webkitpy/tool/mocktool.py:
00:59 Changeset [69842] by zoltan@webkit.org
  • 2 edits in trunk/JavaScriptCore

The parenthetical assertion checking isn't working in some cases with YARR
Interpreter
https://bugs.webkit.org/show_bug.cgi?id=46893

Patch by Peter Varga <pvarga@inf.u-szeged.hu> on 2010-10-15
Reviewed by Gavin Barraclough.

Calculate the countToCheck value of a TypeParentheticalAssertion by
subtracting the number of characters which follows
a TypeParentheticalAssertion term with the number of characters which should
be matched by terms which are contained
in the TypeParentheticalAssertion term (minimumSize).

  • yarr/RegexInterpreter.cpp:

(JSC::Yarr::ByteCompiler::emitDisjunction):

10/14/10:

23:52 Changeset [69841] by commit-queue@webkit.org
  • 2 edits
    2 adds in trunk/WebCore

2010-10-14 Jia Pu <jpu@apple.com>

Reviewed by Adele Peterson.

REGRESSION (r69548): Autocorrections are applied even after typing further characters in the word
https://bugs.webkit.org/show_bug.cgi?id=47689
<rdar://problem/8552250>

The test requires using setTimeout(). So we put it in manual-tests.

  • editing/Editor.cpp: (WebCore::Editor::markMisspellingsAfterTypingToPosition): Relpace release() with clear(). (WebCore::Editor::startCorrectionPanelTimer): Release previously set correction range before start timer for next autocorrection check.
  • manual-tests/autocorrection: Added.
  • manual-tests/autocorrection/autocorrection-cancelled-by-typing-1.html: Added.
23:33 Changeset [69840] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit/chromium

2010-10-14 Wei Jia <wjia@chromium.org>

Reviewed by Darin Fisher.

Retrieve info of lock keys from stashed currentInputEvent which
is stored by chromium when it passes input event to WebCore.
Retrieving only when stashed event is a keyboard event, which
means synthetic KeyboardEvent inherits lock key state from real
keyboard event.
https://bugs.webkit.org/show_bug.cgi?id=46518

  • src/WebPluginContainerImpl.cpp: (WebKit::WebPluginContainerImpl::handleKeyboardEvent):
23:31 Changeset [69839] by ossy@webkit.org
  • 2 edits in trunk/WebKitTools

2010-10-14 Balazs Kelemen <kbalazs@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] WTR is sloooow
https://bugs.webkit.org/show_bug.cgi?id=47695

  • WebKitTestRunner/qt/TestControllerQt.cpp: Change the timer interval of RunUntilConditionLoop from 50 milliseconds to 1 to avoid wasting time after the test had been finished.
23:17 Changeset [69838] by mrobinson@webkit.org
  • 6 edits in trunk/LayoutTests

2010-10-14 Martin Robinson <mrobinson@igalia.com>

Rebaseline some failing tests.

  • platform/gtk/fast/events/keydown-1-expected.txt:
  • platform/gtk/fast/forms/input-placeholder-focus-twice-expected.txt:
  • platform/gtk/fast/forms/textfield-focus-ring-expected.txt:
  • platform/gtk/mathml/presentation/fenced-expected.txt:
  • platform/gtk/mathml/presentation/subsup-expected.txt:
22:14 Changeset [69837] by levin@chromium.org
  • 2 edits in trunk/WebKitSite

Add guideline for constructors doing implicit type conversion to coding style.
https://bugs.webkit.org/show_bug.cgi?id=47646

Reviewed by Darin Adler.

  • coding/coding-style.html:
21:09 Changeset [69836] by rniwa@webkit.org
  • 15 edits
    4 adds in trunk

2010-10-14 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Tony Chang and Darin Adler.

execCommand FormatBlock creates lots of blockquotes
https://bugs.webkit.org/show_bug.cgi?id=19795

The bug was caused by WebKit's not reusing the block node added by previous iteration
and its inserting block node at wrong places.

Fixed the bug by rewriting FormatBlockCommand::formatRange. New code resembles that of
IndentOutdentCommand::indentIntoBlockquote. The difference between two is that formatRange
avoids the existing block elements when replacing blocks and it also adds a placeholder
when removing the existing block caused paragraphs to collapse.

Also fixed a bug in moveParagraphWithClones where erroneous br is added to the start of
the block element to which the paragraph is moved if the block element is the start of a paragraph
and not the end of a paragraph.

Tests: editing/execCommand/format-block-multiple-paragraphs.html

editing/execCommand/format-block-table.html

  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::moveParagraphWithClones): No longer adds erroneous br.
  • editing/EditorCommand.cpp: (WebCore::executeFormatBlock):
  • editing/FormatBlockCommand.cpp: (WebCore::FormatBlockCommand::formatRange): Rewritten; see above. (WebCore::FormatBlockCommand::isElementToApplyInFormatBlockCommand): Renamed from validBlockElement and moved from htmlediting.cpp. (WebCore::enclosingBlockToSplitTreeTo): Added.
  • editing/FormatBlockCommand.h:
  • editing/VisiblePosition.cpp: (WebCore::enclosingBlockFlowElement): Changed the return type to Element*
  • editing/VisiblePosition.h:

2010-10-14 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Tony Chang and Darin Adler.

execCommand FormatBlock creates lots of blockquotes
https://bugs.webkit.org/show_bug.cgi?id=19795

Added tests to ensure WebKit does not add multiple block elements when applying block element to
multiple paragraphs. Also added a test to ensure formatBlock works with tables.

  • fast/html/nav-element-expected.txt: Preserved new lines and removed redundant br.
  • editing/execCommand/format-block-expected.txt: Preserved span and removed erroneous br.
  • editing/execCommand/format-block-from-range-selection-expected.txt: Merged dl's and removed erroneous br.
  • editing/execCommand/format-block-multiple-paragraphs-expected.txt: Added.
  • editing/execCommand/format-block-multiple-paragraphs.html: Added.
  • editing/execCommand/format-block-table-expected.txt: Added.
  • editing/execCommand/format-block-table.html: Added.
  • editing/execCommand/format-block-with-braces-expected.txt: Removed erroneous br.
20:08 Changeset [69835] by kinuko@chromium.org
  • 2 edits in trunk/LayoutTests

2010-10-14 Kinuko Yasuda <kinuko@chromium.org>

Unreviewed, asssigned a bug number to failing filesystem tests.

  • platform/chromium/drt_expectations.txt:
19:54 Changeset [69834] by jam@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-10-14 John Abd-El-Malek <jam@chromium.org>

Reviewed by Tony Chang.

[chromium] null check the widget before sending it data as calling didReceiveData might delete it
https://bugs.webkit.org/show_bug.cgi?id=47708

  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::committedLoad):
19:45 Changeset [69833] by commit-queue@webkit.org
  • 7 edits in trunk

2010-10-14 Nathan Vander Wilt <nate@andyet.net>

Reviewed by Darin Adler.

Added parser for ECMAScript 5 standard date format, so Date.parse can handle RFC 3339 timestamps: https://bugs.webkit.org/show_bug.cgi?id=44632

  • runtime/DateConversion.cpp: (JSC::parseDate):
  • wtf/DateMath.cpp: (WTF::ymdhmsToSeconds): (WTF::parseES5DateFromNullTerminatedCharacters):
  • wtf/DateMath.h:

2010-10-14 Nathan Vander Wilt <nate@andyet.net>

Reviewed by Darin Adler.

Added tests for https://bugs.webkit.org/show_bug.cgi?id=44632

  • fast/js/date-parse-test-expected.txt:
  • fast/js/script-tests/date-parse-test.js: (testDateParseExact):
18:54 Changeset [69832] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-10-14 Eric Seidel <eric@webkit.org>

Unreviewed, just fixing an exception seen on the commit-queue.

I should have unit tested this function before.

  • Scripts/webkitpy/tool/commands/queues.py:
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
18:50 Changeset [69831] by jschuh@chromium.org
  • 7 edits
    2 adds in trunk

2010-10-14 Justin Schuh <jschuh@chromium.org>

Reviewed by James Robinson.

Crash in HTMLTextFormControlElement::selection()
https://bugs.webkit.org/show_bug.cgi?id=47522

Patch by Ryosuke Niwa <rniwa@webkit.org>

The bug was caused by our triggering layout inside RenderTextControl::selection.
Fixed it by changing the return type of RenderTextControl::selection to PassRefPtr<Range> from VisibleSelection.

Test: fast/forms/render-text-crash.html

  • editing/Editor.cpp: (WebCore::Editor::selectionForCommand): Calls HTMLTextFormControlElement::selection.
  • html/HTMLFormControlElement.cpp: (WebCore::HTMLTextFormControlElement::selection): Calls RenderTextControl::selection.
  • html/HTMLFormControlElement.h:
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::selection): Changed the return type.
  • rendering/RenderTextControl.h:

2010-10-14 Justin Schuh <jschuh@chromium.org>

Reviewed by James Robinson.

Crash in HTMLTextFormControlElement::selection()
https://bugs.webkit.org/show_bug.cgi?id=47522

Patch by Ryosuke Niwa <rniwa@webkit.org>

Added a test to ensure WebKit does not crash when moving selection between input elements.

  • fast/forms/render-text-crash-expected.txt: Added.
  • fast/forms/render-text-crash.html: Added.
18:10 Changeset [69830] by jamesr@google.com
  • 2 edits in branches/chromium/552/WebCore

Merge 69529 - 2010-10-11 James Robinson <jamesr@chromium.org>

Reviewed by Kenneth Russell.

[chromium] DRT crash in fast/canvas tests w/accel 2D canvas due to NULL DrawingBuffer
https://bugs.webkit.org/show_bug.cgi?id=47241

Avoid initializing accelerated graphics objects on CanvasRenderingContext2D
if there is no drawingContext associated with the canvas.

Test: fast/canvas/access-zero-sized-canvas.html

fast/canvas/canvas-skia-excessive-size.html
fast/canvas/toDataURL-noData.html

with --accelerated-compositing and --accelerated-2d-canvas

  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::CanvasRenderingContext2D): (WebCore::CanvasRenderingContext2D::reset):

TBR=jamesr@google.com

17:51 Changeset [69829] by eric@webkit.org
  • 18 edits in trunk/WebKitTools

2010-10-14 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

commit-queue should not fail patches due to flaky tests
https://bugs.webkit.org/show_bug.cgi?id=47647

This patch makes it so that the *same* flaky test has to fail
twice in a row to have a false negative from a flaky test.

If different flaky tests fail (or if a test fails and then passes
in a second run) then we will warn in the bug that we encountered
a flaky test.

This patch grew to include moving port off of steps onto tool
(which Adam wrote and then I integrated), as well as removing the
use of tool from CommitQueueTask.

  • Scripts/webkitpy/common/config/ports.py:
    • Added a layout_test_results_path method. This covers old-run-webkit-tests but doesn't cover NRWT. This is probably not the long term solution, but putting this knowledge on port makes more sense than in LayoutTestResults.
  • Scripts/webkitpy/common/net/buildbot.py:
    • LayoutTestResults shouldn't know how to fetch from the network, make the Build code do that instead.
  • Scripts/webkitpy/common/net/buildbot_unittest.py:
    • Code style fix.
  • Scripts/webkitpy/common/net/layouttestresults.py:
    • Remove code for reading from the network.
  • Scripts/webkitpy/common/net/layouttestresults_unittest.py:
    • Test the new entrypoint.
  • Scripts/webkitpy/tool/bot/commitqueuetask.py:
    • Make the delegate interface explicit.
    • Remove the _tool member, since using the delegate for everything is cleaner.
    • Teach the testing logic how to deal with flaky tests.
  • Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
    • Update to match the CommitQueueTask changes.
  • Scripts/webkitpy/tool/commands/queues.py:
    • Use the new CommitQueueTaskDelegate interface.
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
    • Fix the SecondThoughtsCommitQueue test which was broken.
    • Add a new test to make sure the flaky test reporting works.
  • Scripts/webkitpy/tool/main.py:
    • Store the port on the tool object.
  • Scripts/webkitpy/tool/mocktool.py:
    • Add a port() accessor to MockTool
  • Scripts/webkitpy/tool/steps/abstractstep.py:
    • Move port() off of Step and onto Tool.
  • Scripts/webkitpy/tool/steps/build.py:
  • Scripts/webkitpy/tool/steps/preparechangelog.py:
  • Scripts/webkitpy/tool/steps/runtests.py:
  • Scripts/webkitpy/tool/steps/steps_unittest.py:
    • Two tests with the same name! only the latter was being run.
  • Scripts/webkitpy/tool/steps/update.py:
17:50 Changeset [69828] by jamesr@google.com
  • 3 edits
    2 copies in branches/chromium/552

Merge 69827 - 2010-10-14 James Robinson <jamesr@chromium.org>

Reviewed by Simon Fraser.

SelectElement should check if its renderer exists after calling Element::focus()
https://bugs.webkit.org/show_bug.cgi?id=47696

Tests that clicking on a listbox select with an element has a blur listener that causes
the listbox to become display:none does not crash.

  • fast/forms/select-listbox-focus-displaynone.html: Added.

2010-10-14 James Robinson <jamesr@chromium.org>

Reviewed by Simon Fraser.

SelectElement should check if its renderer exists after calling Element::focus()
https://bugs.webkit.org/show_bug.cgi?id=47696

Adds null checks for element->renderer() after calling element->focus(), since focus()
can dispatch an event and run arbitrary javascript that may cause the select element
to lose its renderer.

Test: fast/forms/select-listbox-focus-displaynone.html

  • dom/SelectElement.cpp: (WebCore::SelectElement::menuListDefaultEventHandler): (WebCore::SelectElement::listBoxDefaultEventHandler):

TBR=jamesr@google.com

17:47 Changeset [69827] by jamesr@google.com
  • 3 edits
    2 adds in trunk

2010-10-14 James Robinson <jamesr@chromium.org>

Reviewed by Simon Fraser.

SelectElement should check if its renderer exists after calling Element::focus()
https://bugs.webkit.org/show_bug.cgi?id=47696

Tests that clicking on a listbox select with an element has a blur listener that causes
the listbox to become display:none does not crash.

  • fast/forms/select-listbox-focus-displaynone.html: Added.

2010-10-14 James Robinson <jamesr@chromium.org>

Reviewed by Simon Fraser.

SelectElement should check if its renderer exists after calling Element::focus()
https://bugs.webkit.org/show_bug.cgi?id=47696

Adds null checks for element->renderer() after calling element->focus(), since focus()
can dispatch an event and run arbitrary javascript that may cause the select element
to lose its renderer.

Test: fast/forms/select-listbox-focus-displaynone.html

  • dom/SelectElement.cpp: (WebCore::SelectElement::menuListDefaultEventHandler): (WebCore::SelectElement::listBoxDefaultEventHandler):
17:35 Changeset [69826] by simon.fraser@apple.com
  • 9 edits in trunk/WebKit2

2010-10-14 Simon Fraser <simon.fraser@apple.com>

Reviewed by Sam Weinig.

Plumb accelerated compositing prefs through WebKit2
https://bugs.webkit.org/show_bug.cgi?id=46860
<rdar://problem/8495312>

Wire up the prefs to enable accelerated compositing, and
show debug borders and repaint counters.

  • Shared/WebPreferencesStore.cpp: (WebKit::WebPreferencesStore::WebPreferencesStore): (WebKit::WebPreferencesStore::encode): (WebKit::WebPreferencesStore::decode):
  • Shared/WebPreferencesStore.h:
  • UIProcess/API/C/WKPreferencesPrivate.cpp: (WKPreferencesSetAcceleratedCompositingEnabled): (WKPreferencesGetAcceleratedCompositingEnabled): (WKPreferencesSetCompositingBordersVisible): (WKPreferencesGetCompositingBordersVisible): (WKPreferencesSetCompositingRepaintCountersVisible): (WKPreferencesGetCompositingRepaintCountersVisible):
  • UIProcess/API/C/WKPreferencesPrivate.h:
  • UIProcess/WebPreferences.cpp: (WebKit::WebPreferences::setAcceleratedCompositingEnabled): (WebKit::WebPreferences::acceleratedCompositingEnabled): (WebKit::WebPreferences::setCompositingBordersVisible): (WebKit::WebPreferences::compositingBordersVisible): (WebKit::WebPreferences::setCompositingRepaintCountersVisible): (WebKit::WebPreferences::compositingRepaintCountersVisible):
  • UIProcess/WebPreferences.h:
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::WebPage): (WebKit::WebPage::preferencesDidChange): (WebKit::WebPage::updatePreferences):
  • WebProcess/WebPage/WebPage.h:
17:27 Changeset [69825] by commit-queue@webkit.org
  • 4 edits in trunk/WebKit/qt

2010-09-27 Dawit Alemayehu <adawit@kde.org>

Reviewed by Andreas Kling.

[Qt] Added functions for obtaining and checking the supported content types.
http://webkit.org/b/37880

  • Api/qwebpage.cpp: (extractContentTypeFromHash): (extractContentTypeFromPluginVector): (QWebPage::supportedContentTypes): (QWebPage::supportsContentType):
  • tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::supportedContentType):
17:24 Changeset [69824] by steveblock@google.com
  • 1 edit
    3 adds in trunk/LayoutTests

2010-10-14 Steve Block <steveblock@google.com>

Reviewed by Adam Barth.

Document behaviour of href when document base URI is changed after href atribute has been set
https://bugs.webkit.org/show_bug.cgi?id=47665

  • fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-prevents-rebase.js: Added.
  • fast/dom/HTMLAnchorElement/set-href-attribute-prevents-rebase-expected.txt: Added.
  • fast/dom/HTMLAnchorElement/set-href-attribute-prevents-rebase.html: Added.
17:16 Changeset [69823] by hclam@chromium.org
  • 1 edit in branches/chromium/552/WebCore/platform/graphics/chromium/VideoLayerChromium.cpp

Merge 69706 - No longer ASSERT for LayerRenderer in VideoLayerChromium destructor
https://bugs.webkit.org/show_bug.cgi?id=47432

Patch by Victoria Kirst <vrk@google.com> on 2010-10-13
Reviewed by James Robinson.

  • platform/graphics/chromium/VideoLayerChromium.cpp:

(WebCore::VideoLayerChromium::cleanupResources):

TBR=hclam@chromium.org

16:35 Changeset [69822] by bdakin@apple.com
  • 9 edits in trunk/WebCore

This patch lays the groundwork for
https://bugs.webkit.org/show_bug.cgi?id=47514 CSS transforms should
affect scrolling
by adding topmostPosition().

Reviewed by Dave Hyatt.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::topmostPosition):

  • rendering/RenderBlock.h:
  • rendering/RenderBox.cpp:

(WebCore::RenderBox::topmostPosition):

  • rendering/RenderBox.h:
  • rendering/RenderMedia.cpp:

(WebCore::RenderMedia::topmostPosition):

  • rendering/RenderMedia.h:
  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::topmostPosition):

  • rendering/RenderTableSection.h:
16:24 Changeset [69821] by commit-queue@webkit.org
  • 5 edits in trunk/WebCore

2010-10-14 Sergio Villar Senin <svillar@igalia.com>

Reviewed by Martin Robinson.

[GTK] fix compilation warnings in imported libsoup code
https://bugs.webkit.org/show_bug.cgi?id=47674

Fixed some warnings caused by comparisons between signed and
unsigned integer expressions

  • platform/network/soup/cache/soup-directory-input-stream.c: (webkit_soup_directory_input_stream_read):
  • platform/network/soup/cache/soup-request-data.c: (webkit_soup_request_data_send):
  • platform/network/soup/cache/soup-request-file.c: (webkit_soup_request_file_ensure_file):
  • platform/network/soup/cache/webkit/soup-cache.c: (webkit_soup_cache_entry_is_fresh_enough): (webkit_soup_cache_has_response):
16:22 Changeset [69820] by dpranke@chromium.org
  • 4 edits in trunk/WebKitTools

2010-10-14 Dirk Pranke <dpranke@chromium.org>

Reviewed by Eric Seidel.

new-run-webkit-tests will now handle missing Ruby installs (or
missing PrettyPatch scripts) more cleanly - previously this
would be detected when we actually tried to create the diff, and
the error message was obscure. Now we'll log a warning up front
and otherwise be silent.

This change also refactors some global variables to be class or
instance variables to be slightly more testable and more
modular. There are no cases where we create lots of port objects
and can't afford to test for configurations repeatedly, so
there's no performance concern here.

https://bugs.webkit.org/show_bug.cgi?id=47466

  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/base_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
16:20 Changeset [69819] by andreas.kling@nokia.com
  • 2 edits in trunk/WebCore

2010-10-14 Andreas Kling <kling@webkit.org>

Unreviewed buildfix, RetainPtr is a mac thing..

  • platform/network/soup/ProxyServerSoup.cpp:
16:18 Changeset [69818] by mrobinson@webkit.org
  • 26 edits
    24 adds in trunk

2010-10-08 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Form controls do not respect GTK+ font size
https://bugs.webkit.org/show_bug.cgi?id=47134

Rebaseline tests which depend on form control font size.

  • platform/gtk/editing/pasteboard/drop-text-without-selection-expected.txt:
  • platform/gtk/editing/selection/drag-select-1-expected.txt:
  • platform/gtk/editing/selection/drag-text-delay-expected.txt:
  • platform/gtk/editing/selection/select-box-expected.txt:
  • platform/gtk/fast/css/input-search-padding-expected.txt:
  • platform/gtk/fast/css/text-input-with-webkit-border-radius-expected.txt:
  • platform/gtk/fast/events/keydown-1-expected.txt:
  • platform/gtk/fast/forms/box-shadow-override-expected.txt:
  • platform/gtk/fast/forms/button-style-color-expected.txt:
  • platform/gtk/fast/forms/input-button-sizes-expected.txt:
  • platform/gtk/fast/forms/input-text-drag-down-expected.txt:
  • platform/gtk/fast/forms/placeholder-stripped-expected.txt:
  • platform/gtk/fast/frames/take-focus-from-iframe-expected.txt:
  • platform/gtk/fast/text/backslash-to-yen-sign-euc-expected.txt:
  • platform/gtk/transforms/2d/zoom-menulist-expected.txt:

2010-10-08 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Form controls do not respect GTK+ font size
https://bugs.webkit.org/show_bug.cgi?id=47134

Have form controls use the font specified in GtkSettings. This font is
the default control font in GTK+ applications and Firefox. We need to
pass the string through Pango to get a valid font name and size.

  • platform/gtk/RenderThemeGtk.cpp: (WebCore::getScreenDPI): A helper function which returns the DPI of the default screen or 96 as a fallback. (WebCore::RenderThemeGtk::systemFont): Calculate the system font by looking at the GtkSettings value and pushing it through Pango to get the font family and font size.

2010-10-08 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Form controls do not respect GTK+ font size
https://bugs.webkit.org/show_bug.cgi?id=47134

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (initializeGtkFontSettings): Initialize the font control size when running DumpRenderTree to a standard value.
16:12 Changeset [69817] by andreas.kling@nokia.com
  • 2 edits
    1 add in trunk/WebCore

2010-10-14 Andreas Kling <kling@webkit.org>

Soup buildfix for r69808: add ProxyServer stub.

  • GNUmakefile.am:
  • platform/network/soup/ProxyServerSoup.cpp: Added. (WebCore::proxyServersForURL):
16:05 Changeset [69816] by mrowe@apple.com
  • 5 edits in branches/safari-533.19-branch

Versioning.

16:04 Changeset [69815] by andreas.kling@nokia.com
  • 3 edits in trunk/WebCore

2010-10-14 Andreas Kling <kling@webkit.org>

Fix GTK+ build after r69808.

  • GNUmakefile.am:
  • platform/network/curl/ProxyServerCurl.cpp: (WebCore::proxyServersForURL):
16:04 Changeset [69814] by mrowe@apple.com
  • 1 copy in tags/Safari-533.19.4

New tag.

16:02 Changeset [69813] by simon.fraser@apple.com
  • 2 edits in trunk/WebCore

2010-10-14 Simon Fraser <simon.fraser@apple.com>

Another build fix. Export FrameLoader::networkingContext()

  • WebCore.exp.in:
15:58 Changeset [69812] by mrowe@apple.com
  • 3 edits
    5 adds in branches/safari-533.19-branch

Merge r62683.

15:56 Changeset [69811] by simon.fraser@apple.com
  • 4 edits in trunk/WebCore

2010-10-14 Simon Fraser <simon.fraser@apple.com>

Fix the build after r69808.

  • WebCore.xcodeproj/project.pbxproj:
  • platform/network/cf/ProxyServerCFNet.cpp: (WebCore::proxyServersForURL):
15:46 Changeset [69810] by barraclough@apple.com
  • 2 edits in trunk/WebCore

Windows build fix following r69806.

  • platform/win/ClipboardUtilitiesWin.cpp:

(WebCore::markupToCFHTML):

15:32 Changeset [69809] by tony@chromium.org
  • 5 edits
    6 adds in trunk

2010-10-14 Tony Chang <tony@chromium.org>

Reviewed by Kent Tamura.

[chromium] compile TestNetscapePlugIn on Chromium mac
https://bugs.webkit.org/show_bug.cgi?id=47633

  • WebKit.gyp: Add a mac specific target for compiling TestNetscapePlugIn

2010-10-14 Tony Chang <tony@chromium.org>

Reviewed by Kent Tamura.

[chromium] compile TestNetscapePlugIn on Chromium mac
https://bugs.webkit.org/show_bug.cgi?id=47633

  • DumpRenderTree/DumpRenderTree.gypi: files to compile
  • DumpRenderTree/TestNetscapePlugIn/main.cpp: Use ifdef because gcc was complaining (NP_GetEntryPoints): (NPP_New): (NPP_Destroy): (NPP_HandleEvent): (NPP_GetValue):
  • DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: Added.
  • DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Added.
  • DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h: Added.
15:16 Changeset [69808] by commit-queue@webkit.org
  • 13 edits in trunk

2010-10-14 Dawit Alemayehu <adawit@kde.org>

Reviewed by Andreas Kling

Implemented NPN_GetValueForURL and NPN_SetValueForURL and NPN_GetAuthenticationInfo.
https://bugs.webkit.org/show_bug.cgi?id=34539

These missing NPN functions cause Java applets to crash in ports such
as QtWebkit that rely on webkit for Java applet support.

  • plugins/PluginDebug.cpp: (WebCore::prettyNameForNPNURLVariable):
  • plugins/PluginDebug.h:
  • plugins/PluginPackage.cpp: (WebCore::PluginPackage::initializeBrowserFuncs):
  • plugins/PluginView.cpp: (WebCore::PluginView::getValueForURL): (WebCore::PluginView::setValueForURL): (WebCore::PluginView::getAuthenticationInfo):
  • plugins/PluginView.h:
  • plugins/npapi.cpp: (NPN_GetValueForURL): (NPN_SetValueForURL): (NPN_GetAuthenticationInfo):
  • platform/network/ProxyServer.h:
  • platform/network/cf/ProxyServerCFNet.cpp: (WebCore::proxyServersForURL):
  • platform/network/qt/ProxyServerQt.cpp: (WebCore::proxyServersForURL):
14:56 Changeset [69807] by barraclough@apple.com
  • 2 edits in trunk/WebCore

Windows build fix following r69806.

  • platform/win/ClipboardUtilitiesWin.cpp:

(WebCore::markupToCFHTML):

14:45 Changeset [69806] by victorw@chromium.org
  • 2 edits in trunk/WebKitTools

2010-10-14 Victor Wang <victorw@chromium.org>

Reviewed by Nate Chapin.

[Chromium] Fix rebaseline_chromium_webkit_tests to use 0 tolerance image diff.

https://bugs.webkit.org/show_bug.cgi?id=47686

  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
14:18 Changeset [69805] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-10-14 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

test-webkitpy spews Delegate terminated queue messages
https://bugs.webkit.org/show_bug.cgi?id=47678

  • Scripts/webkitpy/tool/bot/queueengine_unittest.py:
14:11 Changeset [69804] by zmo@google.com
  • 4 edits in trunk/WebCore

2010-10-14 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Cache link status at linkProgram and use it in useProgram instead of querying GPU
https://bugs.webkit.org/show_bug.cgi?id=47685

  • html/canvas/WebGLProgram.cpp: Always cache link status at linkStatus and use it upon query. (WebCore::WebGLProgram::WebGLProgram):
  • html/canvas/WebGLProgram.h: Ditto. (WebCore::WebGLProgram::getLinkStatus): (WebCore::WebGLProgram::setLinkStatus):
  • html/canvas/WebGLRenderingContext.cpp: Ditto. (WebCore::WebGLRenderingContext::getProgramParameter): (WebCore::WebGLRenderingContext::linkProgram): (WebCore::WebGLRenderingContext::useProgram):
14:05 Changeset [69803] by commit-queue@webkit.org
  • 4 edits in trunk

2010-10-14 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r69795.
http://trac.webkit.org/changeset/69795
https://bugs.webkit.org/show_bug.cgi?id=47687

'See discussion at webkit.org/b/47609' (Requested by mwenge on
#webkit).

  • platform/qt/Skipped:

2010-10-14 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r69795.
http://trac.webkit.org/changeset/69795
https://bugs.webkit.org/show_bug.cgi?id=47687

'See discussion at webkit.org/b/47609' (Requested by mwenge on
#webkit).

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::canHandleRequest): (WebCore::FrameLoaderClientQt::dispatchUnableToImplementPolicy):
14:03 Changeset [69802] by adachan@apple.com
  • 5 edits in trunk/WebKit2

Reviewed by Sam Weinig.

WebKit2: Store the certificate chain in PlatformCertificateInfo.
https://bugs.webkit.org/show_bug.cgi?id=47603

  • Shared/API/c/win/WKCertificateInfoWin.cpp: (WKCertificateInfoGetCertificateChainLength): (WKCertificateInfoGetCertificateContextAtIndex):
  • Shared/API/c/win/WKCertificateInfoWin.h:
  • Shared/win/PlatformCertificateInfo.cpp: (WebKit::PlatformCertificateInfo::PlatformCertificateInfo): Get the chain context from the response and duplicate the certificate contexts in the chain to store in m_certificateChain. (WebKit::PlatformCertificateInfo::~PlatformCertificateInfo): Free all the certificate contexts in the chain. (WebKit::PlatformCertificateInfo::operator=): Duplicate the certificate contexts from the other PlatformCertificateInfo's certificate chain to store in m_certificateChain. (WebKit::PlatformCertificateInfo::encode): (WebKit::PlatformCertificateInfo::decode): (WebKit::PlatformCertificateInfo::clearCertificateChain): Free all the certificate contexts in the chain and clear the vector.
  • Shared/win/PlatformCertificateInfo.h: (WebKit::PlatformCertificateInfo::certificateChain):
13:48 Changeset [69801] by jschuh@chromium.org
  • 2 edits in trunk/WebCore

2010-10-14 Justin Schuh <jschuh@chromium.org>

Reviewed by James Robinson.

Style fix for r69735
https://bugs.webkit.org/show_bug.cgi?id=47684

No logic change. Existing tests apply.

  • rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::alignBoxesInBlockDirection):
13:16 Changeset [69800] by tonyg@chromium.org
  • 14 edits
    28 deletes in branches/chromium/517

Revert 66670 - 2010-09-01 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Adam Barth.

Support <script defer> as specified by HTML5
https://bugs.webkit.org/show_bug.cgi?id=40934

  • fast/dom/HTMLScriptElement/defer-double-defer-write-expected.txt: Added.
  • fast/dom/HTMLScriptElement/defer-double-defer-write.html: Added. Tests that a write of a deferred script from a deferred script will execute when the document is closed. The explicit close is necessary because this is a script created parser.
  • fast/dom/HTMLScriptElement/defer-double-write-expected.txt: Added.
  • fast/dom/HTMLScriptElement/defer-double-write.html: Added. Tests that a script block written from a deferred script will write into the new document.
  • fast/dom/HTMLScriptElement/defer-inline-script-expected.txt: Added.
  • fast/dom/HTMLScriptElement/defer-inline-script.html: Added. Tests that inline scripts are not deferred. This is consistent with HTML5 and inconsistent with IE.
  • fast/dom/HTMLScriptElement/defer-onbeforeload-expected.txt: Added.
  • fast/dom/HTMLScriptElement/defer-onbeforeload.html: Added. Tests that the beforeload event is fired immediately and is cancellable.
  • fast/dom/HTMLScriptElement/defer-script-invalid-url-expected.txt: Added.
  • fast/dom/HTMLScriptElement/defer-script-invalid-url.html: Added. Tests that deferred scripts with invalid URLs are ignored and that subsequent deferred scripts will be run.
  • fast/dom/HTMLScriptElement/defer-write-expected.txt: Added.
  • fast/dom/HTMLScriptElement/defer-write.html: Added. Tests that a basic write from a deferred script blows away the document.
  • fast/dom/HTMLScriptElement/resources/defer.js: Added.
  • fast/dom/HTMLScriptElement/resources/external.js: Added.
  • fast/dom/HTMLScriptElement/resources/shouldnotexecute.js: Added.
  • fast/dom/HTMLScriptElement/shouldnotexecute.js: Added.
  • fast/dom/HTMLScriptElement/two-defer-writes-expected.txt: Added.
  • fast/dom/HTMLScriptElement/two-defer-writes.html: Added. Tests that when a document.write from the first deferred script blows away the document, subsequent deferred scripts are not executed.
  • http/tests/misc/resources/defer-script.js: Added.
  • http/tests/misc/resources/external-script.js: Added.
  • http/tests/misc/resources/script-debug-body-background.js: Added.
  • http/tests/misc/resources/script-write-slow-stylesheet.js: Added.
  • http/tests/misc/resources/slow-defer-script.cgi: Added.
  • http/tests/misc/resources/slow-stylesheet.cgi: Added.
  • http/tests/misc/script-defer-after-slow-stylesheet-expected.txt: Added.
  • http/tests/misc/script-defer-after-slow-stylesheet.html: Added. Tests that deferred scripts respect blocking stylesheets.
  • http/tests/misc/script-defer-expected.txt: Added.
  • http/tests/misc/script-defer.html: Added. Tests basic ordering of deferred scripts.

2010-09-01 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Adam Barth.

Support <script defer> as specified by HTML5
https://bugs.webkit.org/show_bug.cgi?id=40934

Tests: fast/dom/HTMLScriptElement/defer-double-defer-write.html

fast/dom/HTMLScriptElement/defer-double-write.html
fast/dom/HTMLScriptElement/defer-inline-script.html
fast/dom/HTMLScriptElement/defer-onbeforeload.html
fast/dom/HTMLScriptElement/defer-script-invalid-url.html
fast/dom/HTMLScriptElement/defer-write.html
fast/dom/HTMLScriptElement/two-defer-writes.html
http/tests/misc/script-defer-after-slow-stylesheet.html
http/tests/misc/script-defer.html

  • dom/Document.cpp: (WebCore::Document::open): Allow implicit open for writes() while executing deferred scripts.
  • dom/DocumentParser.cpp: (WebCore::DocumentParser::DocumentParser): (WebCore::DocumentParser::startParsing): (WebCore::DocumentParser::prepareToStopParsing): If called when stopped or detached, it shouldn't reset to stopping. (WebCore::DocumentParser::stopParsing): (WebCore::DocumentParser::detach):
  • dom/DocumentParser.h: (WebCore::DocumentParser::isParsing): (WebCore::DocumentParser::isActive): (WebCore::DocumentParser::isStopping): (WebCore::DocumentParser::isDetached):
  • dom/RawDataDocumentParser.h: (WebCore::RawDataDocumentParser::finish):
  • dom/XMLDocumentParser.cpp: (WebCore::XMLDocumentParser::append): (WebCore::XMLDocumentParser::exitText):
  • dom/XMLDocumentParserLibxml2.cpp: (WebCore::XMLDocumentParser::doWrite): (WebCore::XMLDocumentParser::startElementNs): (WebCore::XMLDocumentParser::endElementNs): (WebCore::XMLDocumentParser::characters): (WebCore::XMLDocumentParser::error): (WebCore::XMLDocumentParser::processingInstruction): (WebCore::XMLDocumentParser::cdataBlock): (WebCore::XMLDocumentParser::comment): (WebCore::XMLDocumentParser::internalSubset): (WebCore::XMLDocumentParser::initializeParserContext): (WebCore::XMLDocumentParser::doEnd):
  • html/parser/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::prepareToStopParsing): (WebCore::HTMLDocumentParser::pumpTokenizerIfPossible): (WebCore::HTMLDocumentParser::pumpTokenizer): (WebCore::HTMLDocumentParser::insert): (WebCore::HTMLDocumentParser::append): (WebCore::HTMLDocumentParser::end): (WebCore::HTMLDocumentParser::attemptToEnd): (WebCore::HTMLDocumentParser::endIfDelayed): (WebCore::HTMLDocumentParser::notifyFinished):
  • html/parser/HTMLDocumentParser.h:
  • html/parser/HTMLScriptRunner.cpp: (WebCore::HTMLScriptRunner::~HTMLScriptRunner): (WebCore::HTMLScriptRunner::executeParsingBlockingScript): (WebCore::HTMLScriptRunner::executePendingScriptAndDispatchEvent): (WebCore::HTMLScriptRunner::executeScriptsWaitingForParsing): (WebCore::HTMLScriptRunner::requestDeferredScript): (WebCore::HTMLScriptRunner::runScript):
  • html/parser/HTMLScriptRunner.h:
  • loader/ImageDocument.cpp: (WebCore::ImageDocumentParser::finish):

TBR=tonyg@chromium.org
BUG=57196
Review URL: http://codereview.chromium.org/3776004

12:52 Changeset [69799] by yurys@chromium.org
  • 8 edits in trunk/WebCore

2010-10-14 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: encapsulate ScriptState into ConsoleMessage instead of passing it as additional parameter
https://bugs.webkit.org/show_bug.cgi?id=47675

No new tests. This refactoring is covered by existing inspector tests.

  • bindings/js/JSConsoleCustom.cpp:
  • bindings/js/ScriptCallFrame.cpp:
  • bindings/js/ScriptCallFrame.h: (WebCore::ScriptCallFrame::functionName): (WebCore::ScriptCallFrame::sourceURL): (WebCore::ScriptCallFrame::lineNumber): (WebCore::ScriptCallFrame::argumentCount):
  • inspector/ConsoleMessage.cpp: (WebCore::ConsoleMessage::isEqual):
  • inspector/ConsoleMessage.h:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::addMessageToConsole): (WebCore::InspectorController::addConsoleMessage): (WebCore::InspectorController::startGroup): (WebCore::InspectorController::endGroup):
  • inspector/InspectorController.h:
12:48 Changeset [69798] by zimmermann@webkit.org
  • 44 edits
    1 add in trunk

2010-10-14 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Gavin Barraclough.

Replace lots of String::format() usages by StringConcatenate
https://bugs.webkit.org/show_bug.cgi?id=47664

Add StringTypeAdapter<char> to accept single characters for makeString().

  • wtf/text/StringConcatenate.h: (WTF::makeString):

2010-10-14 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Gavin Barraclough.

Replace lots of String::format() usages by StringConcatenate
https://bugs.webkit.org/show_bug.cgi?id=47664

  • ForwardingHeaders/wtf/text/StringConcatenate.h: Added.
  • bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::crossDomainAccessErrorMessage):
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::reportUnsafeAccessTo):
  • dom/ExceptionBase.cpp: (WebCore::ExceptionBase::ExceptionBase):
  • dom/XMLDocumentParser.cpp: (WebCore::XMLDocumentParser::handleError):
  • history/PageCache.cpp: (WebCore::logCanCacheFrameDecision):
  • html/FTPDirectoryDocument.cpp: (WebCore::processFileDateString):
  • inspector/CodeGeneratorInspector.pm:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::didReceiveResponse): (WebCore::InspectorController::count):
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::createBreakpointId):
  • inspector/InspectorDebuggerAgent.cpp: (WebCore::formatBreakpointId):
  • inspector/InspectorProfilerAgent.cpp: (WebCore::InspectorProfilerAgent::addProfileFinishedMessageToConsole): (WebCore::InspectorProfilerAgent::addStartProfilingMessageToConsole): (WebCore::InspectorProfilerAgent::getCurrentUserInitiatedProfileName): (WebCore::InspectorProfilerAgent::takeHeapSnapshot):
  • loader/CachedResourceLoader.cpp: (WebCore::CachedResourceLoader::printAccessDeniedMessage):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::checkIfDisplayInsecureContent): (WebCore::FrameLoader::checkIfRunInsecureContent): (WebCore::FrameLoader::shouldAllowNavigation):
  • loader/archive/cf/LegacyWebArchive.cpp: (WebCore::LegacyWebArchive::createFromSelection):
  • page/DOMWindow.cpp: (WebCore::DOMWindow::postMessageTimerFired):
  • page/PrintContext.cpp: (WebCore::PrintContext::pageProperty): (WebCore::PrintContext::pageSizeAndMarginsInPixels):
  • page/XSSAuditor.cpp: (WebCore::XSSAuditor::canLoadObject):
  • platform/efl/PlatformKeyboardEventEfl.cpp: (WebCore::createKeyMap): (WebCore::createWindowsKeyMap):
  • platform/graphics/GraphicsLayer.cpp: (WebCore::GraphicsLayer::animationNameForTransition):
  • platform/graphics/brew/ImageBrew.cpp: (WebCore::Image::loadPlatformResource):
  • platform/graphics/cg/ImageBufferCG.cpp: (WebCore::ImageBuffer::toDataURL):
  • platform/graphics/efl/ImageEfl.cpp: (WebCore::loadResourceSharedBuffer):
  • platform/graphics/gtk/ImageBufferGtk.cpp: (WebCore::ImageBuffer::toDataURL):
  • platform/graphics/haiku/ImageBufferHaiku.cpp: (WebCore::ImageBuffer::toDataURL):
  • platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::animationIdentifier):
  • platform/graphics/qt/ImageBufferQt.cpp: (WebCore::ImageBuffer::toDataURL):
  • platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::ImageBuffer::toDataURL):
  • platform/graphics/win/WebLayer.cpp: (WebCore::WebLayer::drawInContext):
  • platform/network/CredentialStorage.cpp: (WebCore::originStringFromURL):
  • platform/sql/SQLiteDatabase.cpp: (WebCore::SQLiteDatabase::setSynchronous):
  • platform/text/wince/TextCodecWinCE.cpp: (WebCore::LanguageManager::LanguageManager):
  • platform/win/ClipboardUtilitiesWin.cpp: (WebCore::markupToCFHTML):
  • platform/win/Language.cpp: (WebCore::defaultLanguage):
  • plugins/PluginStream.cpp: (WebCore::PluginStream::startStream):
  • svg/SVGUseElement.cpp: (WebCore::dumpInstanceTree):
  • websockets/WebSocket.cpp: (WebCore::WebSocket::connect):
  • websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::appendToBuffer):
  • websockets/WebSocketHandshake.cpp: (WebCore::WebSocketHandshake::readServerHandshake):

2010-10-14 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Gavin Barraclough.

Replace lots of String::format() usages by StringConcatenate
https://bugs.webkit.org/show_bug.cgi?id=47664

Rebaseline two xssAuditor tests, that have been changed, after switching from String::format() -> makeString().

  • http/tests/security/xssAuditor/embed-tag-null-char-expected.txt:
  • http/tests/security/xssAuditor/object-embed-tag-null-char-expected.txt:
12:47 Changeset [69797] by adachan@apple.com
  • 4 edits in trunk/WebKitLibraries

Rubber-stamped by Adam Roben.

Fix Windows build.

  • win/include/WebKitSystemInterface/WebKitSystemInterface.h:
  • win/lib/WebKitSystemInterface.lib:
  • win/lib/WebKitSystemInterface_debug.lib:
12:40 Changeset [69796] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit/gtk

2010-10-14 Joone Hur <joone@kldp.org>

Reviewed by Andreas Kling.

[GTK] google.co.kr was missed when checking Google domains
https://bugs.webkit.org/show_bug.cgi?id=47652

WebKitGtk+ maintains a list of Google domains for working well with Google sites.
Add google.co.kr also to the list to be checked with other Google domains.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::initializeDomainsList): Added google.co.kr.
12:38 Changeset [69795] by robert@webkit.org
  • 4 edits in trunk

2010-10-14 Robert Hogan <robert@webkit.org>

Reviewed by Antonio Gomes.

[Qt] Fix http/tests/misc/redirect-to-external-url.html

Support the test in FrameLoaderClientQt and unskip.

https://bugs.webkit.org/show_bug.cgi?id=47609

  • platform/qt/Skipped:

2010-10-14 Robert Hogan <robert@webkit.org>

Reviewed by Antonio Gomes.

[Qt] Fix http/tests/misc/redirect-to-external-url.html

Support the test in FrameLoaderClientQt and unskip.

https://bugs.webkit.org/show_bug.cgi?id=47609

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::canHandleRequest): (WebCore::FrameLoaderClientQt::dispatchUnableToImplementPolicy):
12:29 Changeset [69794] by kinuko@chromium.org
  • 2 edits in branches/chromium/552/WebCore

Merge 69634 - 2010-10-12 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by Jian Li.

Pass platform path (rather than virtual path) when creating File from FileEntry
https://bugs.webkit.org/show_bug.cgi?id=47563

No new tests, the new test for FileWriter will be verifying this.

  • fileapi/FileEntry.cpp: (WebCore::FileEntry::file):

TBR=kinuko@chromium.org

12:29 Changeset [69793] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-10-14 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Small cleanup in PluginViewGtk
https://bugs.webkit.org/show_bug.cgi?id=47588

Remove some dead code and use PlatformRefPtr for cairo surfaces.

No new tests, only refactoring.

  • plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::paint):
12:23 Changeset [69792] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit/efl

2010-10-14 Rafael Antognolli <antognolli@profusion.mobi>

Reviewed by Eric Seidel.

[EFL] Use data_set after data_get to keep refcount correct.
https://bugs.webkit.org/show_bug.cgi?id=47110

The call to evas_object_image_data_set was missed in this function,
which caused the refcount of the data being always increased on every
scroll.

  • ewk/ewk_view_single.c: (_ewk_view_single_smart_scrolls_process):
12:22 Changeset [69791] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-10-14 Dawit Alemayehu <adawit@kde.org>

Reviewed by Andreas Kling.

Fix compile error when bulding webkit's Qt port using the "--v8" option.
https://bugs.webkit.org/show_bug.cgi?id=47455

  • platform/qt/PlatformBridge.h:
12:22 Changeset [69790] by aroben@apple.com
  • 4 edits in trunk/WebKit2

Make sure WebKit2 only loads each plugin once

Fixes <http://webkit.org/b/47677> <rdar://problem/8552178> WebKit2 can
load the same plugin multiple times

Reviewed by Sam Weinig.

  • UIProcess/Plugins/PluginInfoStore.cpp:

(WebKit::addFromVector): Helper function that adds all the elements
from a Vector to a HashSet.
(WebKit::PluginInfoStore::loadPluginsIfNecessary): Put all the plugin
paths into a HashSet, then load the plugins specified in the HashSet.
On Windows, the HashSet is case-insensitive, just like the file
system.

  • UIProcess/Plugins/PluginInfoStore.h: Removed loadPluginsInDirectory,

which is no longer used.

  • UIProcess/Plugins/win/PluginInfoStoreWin.cpp:

(WebKit::addPluginPathsFromRegistry):
(WebKit::PluginInfoStore::individualPluginPaths):
Changed to store the paths in a Vector instead of a HashSet now that
loadPluginsIfNecessary will handle duplicates for us.

12:22 Changeset [69789] by aroben@apple.com
  • 6 edits in trunk/WebKit2

Load plugins that are specified in the MozillaPlugins registry key

Fixes <http://webkit.org/b/44271> <rdar://problem/8329750> WebKit2
should load plugins specified in the MozillaPlugins registry key (like
old WebKit does)

I couldn't think of a good way to test this.

Reviewed by Steve Falkenburg.

  • UIProcess/Plugins/PluginInfoStore.cpp:

(WebKit::PluginInfoStore::loadPluginsIfNecessary): Also load plugins
specified by individualPluginPaths.

  • UIProcess/Plugins/PluginInfoStore.h: Added individualPluginPaths and

some comments.

  • UIProcess/Plugins/mac/PluginInfoStoreMac.mm:

(WebKit::PluginInfoStore::individualPluginPaths):

  • UIProcess/Plugins/qt/PluginInfoStoreQt.cpp:

(WebKit::PluginInfoStore::individualPluginPaths):
Stubbed out.

  • UIProcess/Plugins/win/PluginInfoStoreWin.cpp:

(WebKit::addPluginPathsFromRegistry):
(WebKit::PluginInfoStore::individualPluginPaths):
Ported this code from WebCore's PluginDatabaseWin.cpp. I slightly
cleaned it up and changed it to use a case-insensitive hash, since
paths on Windows are case-insensitive.

12:21 Changeset [69788] by aroben@apple.com
  • 14 edits
    1 copy
    2 adds in trunk

Call ::DefWindowProcW for unhandled key events

::DefWindowProcW does important things for at least some key events
(e.g., it generates a WM_SYSCOMMAND message when the Alt key is
released), so we need to make sure to call it when we don't handle key
events.

Fixes <http://webkit.org/b/47671> <rdar://problem/8435594> Pressing
the Alt key when MiniBrowser's WKView is focused doesn't send focus to
the menu bar

Reviewed by Steve Falkenburg.

WebKit2:

  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::didNotHandleKeyEvent):

  • UIProcess/API/qt/qwkpage.cpp:

(QWKPagePrivate::didNotHandleKeyEvent):

  • UIProcess/API/qt/qwkpage_p.h:

Stubbed out didNotHandleKeyEvent.

  • UIProcess/PageClient.h: Added didNotHandleKeyEvent.
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didReceiveEvent): Tell the PageClient about the
unhandled event.

  • UIProcess/win/WebView.cpp:

(WebKit::WebView::onKeyEvent): Added a comment.
(WebKit::WebView::didNotHandleKeyEvent): Pass the event to
::DefWindowProcW.

  • UIProcess/win/WebView.h: Added didNotHandleKeyEvent.

WebKitTools:

Test that pressing the Alt key generates a WM_SYSCOMMAND message

  • TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops: Added

TestWebKitAPI/win to the include path so that WindowMessageObserver
can be found.

  • TestWebKitAPI/PlatformWebView.h: Added simulateAltKeyPress and

Windows-specific members.
(TestWebKitAPI::PlatformWebView::setParentWindowMessageObserver):
Added this simple setter.

  • TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp: Added.

(TestWebKitAPI::WMSysCommandObserver::WMSysCommandObserver):
Initialize our lone data member.
(TestWebKitAPI::WMSysCommandObserver::windowDidReceiveWMSysCommand):
Simple getter.
(TestWebKitAPI::WMSysCommandObserver::windowReceivedMessage): Record
when a WM_SYSCOMMAND message is received.
(TestWebKitAPI::didNotHandleKeyEventCallback): Record when a
WM_SYSKEYUP message is not handled.
(TestWebKitAPI::WebKit2_AltKeyGeneratesWMSysCommand): Simulate
pressing the Alt key and check that a WM_SYSCOMMAND message got sent
to the WKView's parent window.

  • TestWebKitAPI/win/PlatformWebViewWin.cpp:

(TestWebKitAPI::PlatformWebView::registerWindowClass): Made this a
member function so it could access PlatformWebView::wndProc. Use
PlatformWebView::wndProc as the WNDPROC.
(TestWebKitAPI::PlatformWebView::PlatformWebView): Initialize our new
data member and pass the this pointer to CreateWindowEx so we can
store it on the HWND.
(TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress): Moved some
constants from here to the top of the file.
(TestWebKitAPI::PlatformWebView::simulateAltKeyPress): Added. Sends
the same messages that Notepad receives when you press the Alt key.
(TestWebKitAPI::PlatformWebView::wndProc): Added.

  • When WM_CREATE is received, we set the PlatformWebView instance pointer as a property on the HWND so we can access it later.
  • For other messages, we try to get the PlatformWebView instance pointer from the HWND property.
  • When WM_NCDESTROY is received (which is the last message we will receive), we remove the PlatformWebView instance property.
  • Pass messages to the parent window's message observer, if there is one.
  • Pass all messages through to ::DefWindowProcW.
  • TestWebKitAPI/win/TestWebKitAPI.vcproj: Added WindowMessageObserver

and AltKeyGeneratesWMSysCommand.

  • TestWebKitAPI/win/WindowMessageObserver.h: Added. This class can be

used to observe messages sent to one or more windows.

12:19 Changeset [69787] by ggaren@apple.com
  • 3 edits in trunk/JavaScriptCore

need way to measure size of JITed ARM code
https://bugs.webkit.org/show_bug.cgi?id=47121

Patch by David Goodwin <david_goodwin@apple.com> on 2010-10-14
Reviewed by Darin Adler.

  • assembler/LinkBuffer.h:

(JSC::LinkBuffer::linkCode):
(JSC::LinkBuffer::dumpLinkStats):
(JSC::LinkBuffer::dumpCode):

11:52 Changeset [69786] by mrobinson@webkit.org
  • 5 edits
    4 adds in trunk

2010-10-01 Martin Robinson <mrobinson@igalia.com>

Reviewed by Holger Freyther.

[GTK] REGRESSION: FreeType backend does not respect XSettings font settings after r68558
https://bugs.webkit.org/show_bug.cgi?id=47033

Added a platform-specific test which verifies that if XSettings
specifies subpixel aliasing, it is the default rendering style.

  • platform/gtk/fonts/xsettings_antialias_settings-expected.checksum: Added.
  • platform/gtk/fonts/xsettings_antialias_settings-expected.png: Added.
  • platform/gtk/fonts/xsettings_antialias_settings-expected.txt: Added.
  • platform/gtk/fonts/xsettings_antialias_settings.html: Added.

2010-10-01 Martin Robinson <mrobinson@igalia.com>

Reviewed by Holger Freyther.

[GTK] REGRESSION: FreeType backend does not respect XSettings font settings after r68558
https://bugs.webkit.org/show_bug.cgi?id=47033

Fix logic that merges XSettings defaults and FontConfig settings. If
FontConfig or XSettings specifies a subpixel order, we force subpixel
anti-aliasing on. If anti-aliasing is turned on explicitly, only
override the setting if it was previously off, otherwise we ignore
the user's preference for subpixel or gray antialiasing.

Test: platform/gtk/fonts/xsettings_antialias_settings.html

  • platform/graphics/cairo/FontPlatformDataFreeType.cpp: (WebCore::setCairoFontOptionsFromFontConfigPattern): Fix merging of XSettings and FontConfig anti-aliasing settings. (WebCore::getDefaultFontOptions): Added this helper. (WebCore::FontPlatformData::FontPlatformData): Use the getDefaultFontOptions helper.

2010-10-01 Martin Robinson <mrobinson@igalia.com>

Reviewed by Holger Freyther.

[GTK] REGRESSION: FreeType backend does not respect XSettings font settings after r68558
https://bugs.webkit.org/show_bug.cgi?id=47033

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (initializeGtkFontSettings): Added this method which initializes XSettings font settings to consistent values before running a test. For the one test in which we need subpixel aliasing turned on, do that. (initializeFonts): Accepts a testURL parameter now and delegates to initializeGtkFontSettings. (runTest): Pass the testURL to initializeFonts.
11:50 Changeset [69785] by japhet@chromium.org
  • 1 edit
    40 adds in trunk/LayoutTests

2010-10-14 Nate Chapin <japhet@chromium.org>

Unreviewed, test tweaks.

Add Chromium win/linux results for http://trac.webkit.org/changeset/69774.

  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.png: Added.
11:45 Changeset [69784] by adachan@apple.com
  • 4 edits in trunk/WebKitLibraries

Reviewed by Steve Falkenburg.

Add wkGetSSLCertificateChainContext for fetching the certificate chain.
Needed for https://bugs.webkit.org/show_bug.cgi?id=47603.

  • win/include/WebKitSystemInterface/WebKitSystemInterface.h:
  • win/lib/WebKitSystemInterface.lib:
  • win/lib/WebKitSystemInterface_debug.lib:
11:36 Changeset [69783] by commit-queue@webkit.org
  • 3 edits in trunk/WebKit/efl

2010-10-14 Ryuan Choi <ryuan.choi@samsung.com>

Reviewed by Eric Seidel.

[EFL] Add setting api for enabling encoding detector
https://bugs.webkit.org/show_bug.cgi?id=45427

Add settings api for enabling encoding detector.

  • ewk/ewk_view.cpp: (_ewk_view_priv_new): (ewk_view_setting_encoding_detector_set): (ewk_view_setting_encoding_detector_get):
  • ewk/ewk_view.h:
11:30 Changeset [69782] by jianli@chromium.org
  • 13 edits in trunk/WebCore

Support typed arrays in workers
https://bugs.webkit.org/show_bug.cgi?id=47616

Reviewed by David Levin.

To support typed arrays in workers, we need to expose constructors in
WorkerContext and add NoStaticTables attribute.

I also add File API feature guard to the constructors defined in
DOMWindow.

  • bindings/js/JSDOMWindowCustom.cpp: Add File API feature guard to the

constructors defined in DOMWindow.

  • html/canvas/ArrayBuffer.idl: Add NoStaticTables attribute.
  • html/canvas/ArrayBufferView.idl: Add NoStaticTables attribute.
  • html/canvas/Float32Array.idl: Add NoStaticTables attribute.
  • html/canvas/Int16Array.idl: Add NoStaticTables attribute.
  • html/canvas/Int32Array.idl: Add NoStaticTables attribute.
  • html/canvas/Int8Array.idl: Add NoStaticTables attribute.
  • html/canvas/Uint16Array.idl: Add NoStaticTables attribute.
  • html/canvas/Uint32Array.idl: Add NoStaticTables attribute.
  • html/canvas/Uint8Array.idl: Add NoStaticTables attribute.
  • page/DOMWindow.idl: Add File API feature guard to the constructors

defined in DOMWindow.

  • workers/WorkerContext.idl: Expose type array constructors.
11:00 Changeset [69781] by commit-queue@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-10-14 Peter Varga <pvarga@inf.u-szeged.hu>

Reviewed by Gavin Barraclough.

The backreference checking isn't working in some cases with YARR Interpreter
https://bugs.webkit.org/show_bug.cgi?id=46904

The Interpreter::matchBackReference() function returns true without matching
when a backreference points to the same parentheses where it is.

  • yarr/RegexInterpreter.cpp: (JSC::Yarr::Interpreter::matchBackReference):
10:47 Changeset [69780] by mrobinson@webkit.org
  • 1 edit
    9 adds in trunk/LayoutTests

Add baselines and pixel results for some new tests.

  • platform/gtk/fast/forms/textfield-focus-ring-expected.checksum: Added.
  • platform/gtk/fast/forms/textfield-focus-ring-expected.png: Added.
  • platform/gtk/fast/forms/textfield-focus-ring-expected.txt: Added.
  • platform/gtk/fast/images/imagemap-focus-ring-expected.checksum: Added.
  • platform/gtk/fast/images/imagemap-focus-ring-expected.png: Added.
  • platform/gtk/fast/images/imagemap-focus-ring-expected.txt: Added.
  • platform/gtk/fast/inline/inline-focus-ring-expected.checksum: Added.
  • platform/gtk/fast/inline/inline-focus-ring-expected.png: Added.
  • platform/gtk/fast/inline/inline-focus-ring-expected.txt: Added.
10:45 Changeset [69779] by andreas.kling@nokia.com
  • 2 edits in trunk/WebCore

2010-10-14 Andreas Kling <kling@webkit.org>

Reviewed by Ariya Hidayat.

[Qt] Avoid creating empty transparency layers in ImageBuffer::clip()

We were creating empty layers for sub-1 height/width clips due to
using IntRect(FloatRect) instead of enclosingIntRect().
This lead to a bunch of QPainter warnings on the console since you
can't draw on an empty QPixmap.

  • platform/graphics/qt/ImageBufferQt.cpp: (WebCore::ImageBuffer::clip):
10:31 Changeset [69778] by japhet@chromium.org
  • 1 edit
    18 adds in trunk/LayoutTests

2010-10-14 Nate Chapin <japhet@chromium.org>

Unreviewed, Chromium test fix.

Expected results for tests added in http://trac.webkit.org/changeset/69766.

  • platform/chromium-linux/fast/forms/textfield-focus-ring-expected.checksum: Added.
  • platform/chromium-linux/fast/forms/textfield-focus-ring-expected.png: Added.
  • platform/chromium-linux/fast/images/imagemap-focus-ring-expected.checksum: Added.
  • platform/chromium-linux/fast/images/imagemap-focus-ring-expected.png: Added.
  • platform/chromium-linux/fast/inline/inline-focus-ring-expected.checksum: Added.
  • platform/chromium-linux/fast/inline/inline-focus-ring-expected.png: Added.
  • platform/chromium-mac/fast/forms/textfield-focus-ring-expected.checksum: Added.
  • platform/chromium-mac/fast/images/imagemap-focus-ring-expected.checksum: Added.
  • platform/chromium-mac/fast/inline/inline-focus-ring-expected.checksum: Added.
  • platform/chromium-win/fast/forms/textfield-focus-ring-expected.checksum: Added.
  • platform/chromium-win/fast/forms/textfield-focus-ring-expected.png: Added.
  • platform/chromium-win/fast/forms/textfield-focus-ring-expected.txt: Added.
  • platform/chromium-win/fast/images/imagemap-focus-ring-expected.checksum: Added.
  • platform/chromium-win/fast/images/imagemap-focus-ring-expected.png: Added.
  • platform/chromium-win/fast/images/imagemap-focus-ring-expected.txt: Added.
  • platform/chromium-win/fast/inline/inline-focus-ring-expected.checksum: Added.
  • platform/chromium-win/fast/inline/inline-focus-ring-expected.png: Added.
  • platform/chromium-win/fast/inline/inline-focus-ring-expected.txt: Added.
10:31 Changeset [69777] by noam.rosenthal@nokia.com
  • 3 edits in trunk/WebKit/qt

2010-10-14 No'am Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Texmap] [Qt] Texture mapper initial implementation
https://bugs.webkit.org/show_bug.cgi?id=47070

Allow rendering of accelerated-compositing with TextureMapper, inside a QWebFrame. The frame will render the regular content,
either normally or through tiled backingstore, then let the TextureMapper layer render itself to the active context, and
then render the scrollbar and pan icon. This is different from the current implementation, which uses additional QGraphicsItems for AC
and the scrollbar overlay.

  • Api/qgraphicswebview.cpp: (QGraphicsWebView::paint):
  • Api/qwebframe.cpp: (QWebFramePrivate::renderFromTiledBackingStore): (QWebFramePrivate::renderRelativeCoords):
10:23 Changeset [69776] by zecke@webkit.org
  • 2 edits in trunk/WebCore

[cairo] Typo in determining fixed width fonts
https://bugs.webkit.org/show_bug.cgi?id=47470

It must be a single ampersand otherwise the
&& FT_FACE_FLAG_FIXED_WIDTH will always be true.

  • platform/graphics/cairo/FontPlatformDataFreeType.cpp:

(WebCore::FontPlatformData::FontPlatformData):

10:13 Changeset [69775] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-10-14 Sergio Villar Senin <svillar@igalia.com>

Reviewed by Xan Lopez.

[GTK] Failing test LayoutTests/editing/undo/orphaned-selection-crash-bug32823-2.html
https://bugs.webkit.org/show_bug.cgi?id=47666

Do a less strict decoding of base64 data url's as it was done
before. The actual problem is most likely
https://bugs.webkit.org/show_bug.cgi?id=47661 tough.

  • platform/network/soup/cache/soup-request-data.c: (webkit_soup_request_data_send):
10:12 Changeset [69774] by commit-queue@webkit.org
  • 4 edits
    50 adds in trunk

2010-10-14 Renata Hodovan <reni@inf.u-szeged.hu>

Reviewed by Andreas Kling.

SVGFEConvolveMatrixElement doesn't support dynamic invalidation, when attributes change.
https://bugs.webkit.org/show_bug.cgi?id=47660

Adding layout tests for feConvolveMatrix dynamic DOM changes. SVGDOM tests cases will be in the following patch because of patch-size limitation (2M in bugzilla).

  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.png: Added.
  • svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr.html: Added.
  • svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr.html: Added.
  • svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr.html: Added.
  • svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr.html: Added.
  • svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr.html: Added.
  • svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr.html: Added.
  • svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr.html: Added.
  • svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr.html: Added.
  • svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr.html: Added.
  • svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr.html: Added.
  • svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-dom-bias-attr.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-dom-divisor-attr.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-dom-edgeMode-attr.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-dom-in-attr.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-dom-order-attr.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-dom-targetX-attr.js: Added. (executeTest):
  • svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-dom-targetY-attr.js: Added. (executeTest):

2010-10-14 Renata Hodovan <reni@inf.u-szeged.hu>

Reviewed by Andreas Kling.

SVGFEConvolveMatrixElement doesn't support dynamic invalidation, when attributes change.
https://bugs.webkit.org/show_bug.cgi?id=47660

The dynamic changes are captured by the svgAttributeChange function, and invalidate the filter primitive if necessary.
The patch also implements the simple setOrder and setKernelUnitLength methods.

Tests: svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr.html

svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr.html
svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr.html
svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr.html
svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr.html
svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr.html
svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr.html
svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr.html
svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr.html
svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr.html

  • svg/SVGFEConvolveMatrixElement.cpp: (WebCore::SVGFEConvolveMatrixElement::setOrder): (WebCore::SVGFEConvolveMatrixElement::setKernelUnitLength): (WebCore::SVGFEConvolveMatrixElement::svgAttributeChanged):
  • svg/SVGFEConvolveMatrixElement.h:
09:57 Changeset [69773] by noam.rosenthal@nokia.com
  • 6 edits in trunk

2010-10-14 No'am Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Andreas Kling.

[Qt] Text breaking is slow: enable ICU as an opt-in
https://bugs.webkit.org/show_bug.cgi?id=40332

Added a config flag that enables ICU as an opt-in instead of the Qt specific code.
Because of the inclusion of ICU headers, some explicit casting was necessary in UnicodeQt4.h

  • JavaScriptCore.pri:
  • wtf/unicode/qt4/UnicodeQt4.h: (WTF::Unicode::toLower): (WTF::Unicode::toUpper): (WTF::Unicode::toTitleCase): (WTF::Unicode::foldCase): (WTF::Unicode::isPrintableChar): (WTF::Unicode::isSeparatorSpace): (WTF::Unicode::isPunct): (WTF::Unicode::isLower): (WTF::Unicode::mirroredChar): (WTF::Unicode::combiningClass): (WTF::Unicode::direction): (WTF::Unicode::category):

2010-10-14 No'am Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Andreas Kling.

[Qt] Text breaking is slow: enable ICU as an opt-in
https://bugs.webkit.org/show_bug.cgi?id=40332

Added a config flag that enables ICU as an opt-in instead of the Qt specific code.

No new tests, this should be covered by existing tests.

  • WebCore.pro:
  • platform/text/qt/TextBreakIteratorQt.cpp: (WebCore::currentTextBreakLocaleID):
09:52 Changeset [69772] by noam.rosenthal@nokia.com
  • 3 edits in trunk/WebCore

2010-10-14 No'am Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Texmap] [Qt] Texture mapper initial implementation
https://bugs.webkit.org/show_bug.cgi?id=47070

This patch enables compilation of TextureMapper with Media. It has an initial non-working implementation of a video layer, to be integrated
once other parts of TextureMapper are fully working.

No new tests: this is new implementation that's not enabled yet.

  • platform/graphics/qt/MediaPlayerPrivateQt.cpp: (WebCore::TextureMapperVideoLayerQt::TextureMapperVideoLayerQt): (WebCore::TextureMapperVideoLayerQt::setPlatformLayerClient): (WebCore::TextureMapperVideoLayerQt::paint): (WebCore::TextureMapperVideoLayerQt::size): (WebCore::MediaPlayerPrivateQt::acceleratedRenderingStateChanged): (WebCore::MediaPlayerPrivateQt::platformLayer):
  • platform/graphics/qt/MediaPlayerPrivateQt.h: (WebCore::MediaPlayerPrivateQt::supportsAcceleratedRendering): (WebCore::MediaPlayerPrivateQt::acceleratedRenderingStateChanged): (WebCore::MediaPlayerPrivateQt::platformLayer):
09:40 Changeset [69771] by japhet@chromium.org
  • 2 edits in trunk/LayoutTests

2010-10-14 Nate Chapin <japhet@chromium.org>

Unreviewed, Chromium expectations update.

  • platform/chromium/test_expectations.txt:
09:40 Changeset [69770] by abarth@webkit.org
  • 3 edits in trunk/WebKitTools

2010-10-14 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

ChromiumXVFBPort.run_webkit_tests_command has infinite recursion
https://bugs.webkit.org/show_bug.cgi?id=47655

  • Scripts/webkitpy/common/config/ports.py:
  • Scripts/webkitpy/common/config/ports_unittest.py:
09:18 Changeset [69769] by yurys@chromium.org
  • 3 edits in trunk/LayoutTests

2010-10-14 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Update expectations for some inspector tests.

  • inspector/debugger-pause-in-eval-script-expected.txt:
  • inspector/extensions-events-expected.txt:
09:13 Changeset [69768] by alex@webkit.org
  • 2 edits in trunk/WebCore

2010-10-14 Alejandro G. Castro <alex@igalia.com>

Reviewed by Martin Robinson.

Fixed crashes in the GTK 64bits bot, we have to use NULL instead
of 0 when calling these glib APIs, 0 is compiled as a char and in
64bits systems it is not correct.

  • platform/network/soup/cache/soup-requester.c: (webkit_soup_requester_new): (webkit_soup_requester_request_uri):
09:00 Changeset [69767] by dbates@webkit.org
  • 2 edits in trunk/WebCore

2010-10-14 Daniel Bates <dbates@rim.com>

Attempt to fix the Qt and GTK builds based on the build bot results from <http://webkit.sed.hu>.

  • rendering/RenderInline.cpp: Include header "RenderTheme.h"
08:40 Changeset [69766] by dbates@webkit.org
  • 6 edits
    12 adds in trunk

2010-10-14 Daniel Bates <dbates@rim.com>

Reviewed by Darin Adler.

Only draw focus ring in RenderInline and RenderImage if the theme
is not able to draw a focus ring
https://bugs.webkit.org/show_bug.cgi?id=47632

Fixes an issue where RenderInline::paintOutline() and RenderImage::paintFocusRings()
would draw a focus ring regardless of whether the port-specific theme is able to
draw a focus ring. Instead, these methods should only draw a focus ring if the
theme is unable to draw a focus ring.

Also, extracted common focus ring drawing code from RenderObject::paintOutline()
and RenderInline::paintOutline() into RenderObject::paintFocusRing().

Tests: fast/forms/textfield-focus-ring.html

fast/images/imagemap-focus-ring.html
fast/inline/inline-focus-ring.html

  • rendering/RenderImage.cpp: (WebCore::RenderImage::paintFocusRings): Modified to only draw a focus ring if the the theme does not draw one.
  • rendering/RenderInline.cpp: (WebCore::RenderInline::paintOutline): Modified to call RenderObject::paintFocusRing().
  • rendering/RenderObject.cpp:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::paintFocusRing): Added. (WebCore::RenderObject::paintOutline): Modified to call RenderObject::paintFocusRing().
  • rendering/RenderObject.h:

2010-10-14 Daniel Bates <dbates@rim.com>

Reviewed by Darin Adler.

Only draw focus ring in RenderInline and RenderImage if the theme
is not able to draw a focus ring
https://bugs.webkit.org/show_bug.cgi?id=47632

Pixel tests to ensure that we don't regress focus ring drawing for RenderObject
(fast/forms/textfield-focus-ring.html), RenderImage (fast/images/imagemap-focus-ring.html)
and RenderInline (fast/inline/inline-focus-ring.html) on ports that support focus
ring drawing.

  • fast/forms/textfield-focus-ring.html: Added.
  • fast/images/imagemap-focus-ring.html: Added.
  • fast/inline/inline-focus-ring.html: Added.
  • platform/mac/fast/forms/textfield-focus-ring-expected.checksum: Added.
  • platform/mac/fast/forms/textfield-focus-ring-expected.png: Added.
  • platform/mac/fast/forms/textfield-focus-ring-expected.txt: Added.
  • platform/mac/fast/images/imagemap-focus-ring-expected.checksum: Added.
  • platform/mac/fast/images/imagemap-focus-ring-expected.png: Added.
  • platform/mac/fast/images/imagemap-focus-ring-expected.txt: Added.
  • platform/mac/fast/inline/inline-focus-ring-expected.checksum: Added.
  • platform/mac/fast/inline/inline-focus-ring-expected.png: Added.
  • platform/mac/fast/inline/inline-focus-ring-expected.txt: Added.
08:16 Changeset [69765] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

2010-10-14 Stephen White <senorblanco@chromium.org>

Unreviewed; test expectations update.

[chromium] Update test_expectations following Skia roll in chromium.

  • platform/chromium/test_expectations.txt:
07:14 Changeset [69764] by steveblock@google.com
  • 1 edit
    4 adds in trunk/LayoutTests

2010-10-14 Steve Block <steveblock@google.com>

Reviewed by Jeremy Orlow.

DeviceOrientation crash when page is in page cache and is navigated while listener is registered
https://bugs.webkit.org/show_bug.cgi?id=47257

This crash is avoided now that pages using DeviceOrientation are not put in
the page cache. See https://bugs.webkit.org/show_bug.cgi?id=47408.

This test serves to document the fact that the underlying problem needs to
be addressed before the page cache is enabled for DeviceOrientation.

  • fast/dom/DeviceOrientation/event-after-navigation-expected.txt: Added.
  • fast/dom/DeviceOrientation/event-after-navigation.html: Added.
  • fast/dom/DeviceOrientation/resources/event-after-navigation-new.html: Added.
  • fast/dom/DeviceOrientation/script-tests/event-after-navigation.js: Added.
06:48 Changeset [69763] by pfeldman@chromium.org
  • 9 edits in trunk/WebCore

2010-10-14 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Move load and dom content event timers into InspectorController.
https://bugs.webkit.org/show_bug.cgi?id=47668

  • inspector/CodeGeneratorInspector.pm:
  • inspector/Inspector.idl:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::populateScriptObjects): (WebCore::InspectorController::mainResourceFiredDOMContentEvent): (WebCore::InspectorController::mainResourceFiredLoadEvent):
  • inspector/InspectorController.h:
  • inspector/InspectorResource.cpp: (WebCore::InspectorResource::InspectorResource): (WebCore::InspectorResource::updateScriptObject):
  • inspector/InspectorResource.h:
  • inspector/front-end/inspector.js: (WebInspector.updateResource): (WebInspector.domContentEventFired): (WebInspector.loadEventFired):
06:18 Changeset [69762] by abecsi@webkit.org
  • 2 edits in trunk

2010-10-14 Andras Becsi <abecsi@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt] Fix -Werror after r68637 on x86 platforms.
Qt's build system sets QT_ARCH statically to i386 or x86_64 accordingly,
so check for this instead of only checking for x86.

  • WebKit.pri:
06:03 Changeset [69761] by pfeldman@chromium.org
  • 11 edits
    1 move
    1 add
    1 delete in trunk/WebCore

2010-10-14 Pavel Feldman <pfeldman@chromium.org>

Not reviewed. Re-landing r69757.

05:56 Changeset [69760] by podivilov@chromium.org
  • 6 edits in trunk/WebCore

2010-10-14 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: implement pausing on window events and timeouts
https://bugs.webkit.org/show_bug.cgi?id=47542

  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::didInstallTimerImpl): (WebCore::InspectorInstrumentation::didRemoveTimerImpl): (WebCore::InspectorInstrumentation::willDispatchEventImpl): (WebCore::InspectorInstrumentation::didDispatchEventImpl): (WebCore::InspectorInstrumentation::willDispatchEventOnWindowImpl): (WebCore::InspectorInstrumentation::didDispatchEventOnWindowImpl): (WebCore::InspectorInstrumentation::willFireTimerImpl): (WebCore::InspectorInstrumentation::didFireTimerImpl): (WebCore::InspectorInstrumentation::pauseOnNativeEventIfNeeded): (WebCore::InspectorInstrumentation::cancelPauseOnNativeEvent):
  • inspector/InspectorInstrumentation.h:
  • inspector/front-end/BreakpointManager.js: (WebInspector.EventListenerBreakpoint.prototype.populateLabelElement): (WebInspector.EventListenerBreakpoint.prototype.populateStatusMessageElement): (WebInspector.EventListenerBreakpoint.prototype._condition): (WebInspector.EventListenerBreakpoint.prototype._uiEventName):
  • inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.EventListenerBreakpointsSidebarPane.prototype._populate):
05:43 Changeset [69759] by ossy@webkit.org
  • 2 edits in trunk/WebCore

2010-10-14 Csaba Osztrogonác <ossy@webkit.org>

Reviewed by Andreas Kling.

Canvas: "currentColor" should inherit the canvas element's color
https://bugs.webkit.org/show_bug.cgi?id=40273

Warning fix after r69755. Missing default cases added.

  • html/canvas/CanvasStyle.cpp: (WebCore::parseColorOrCurrentColor): (WebCore::CanvasStyle::createFromString): (WebCore::CanvasStyle::createFromStringWithOverrideAlpha):
05:01 Changeset [69758] by pfeldman@chromium.org
  • 11 edits
    1 move
    1 add
    1 delete in trunk/WebCore

2010-10-14 Pavel Feldman <pfeldman@chromium.org>

Not reviewed. Rolling out r69757.

04:38 Changeset [69757] by pfeldman@chromium.org
  • 11 edits
    1 move
    1 add
    1 delete in trunk/WebCore

2010-10-14 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: extract content-related methods into InspectorResourceAgent.
https://bugs.webkit.org/show_bug.cgi?id=47415

This is needed for resource-tracking-less operation of resources panel.

  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • inspector/InspectorCSSAgent.cpp:
  • inspector/InspectorResource.cpp: (WebCore::InspectorResource::type): (WebCore::InspectorResource::sourceString): (WebCore::InspectorResource::sourceBytes):
  • inspector/InspectorResource.h:
  • inspector/InspectorResourceAgent.cpp: Added. (WebCore::InspectorResourceAgent::resourceContent): (WebCore::InspectorResourceAgent::resourceContentBase64): (WebCore::InspectorResourceAgent::resourceData): (WebCore::InspectorResourceAgent::cachedResourceType): (WebCore::InspectorResourceAgent::cachedResource):
  • inspector/InspectorResourceAgent.h: Added.
  • inspector/InspectorStyleSheet.cpp: (WebCore::InspectorStyleSheet::resourceStyleSheetText):
  • inspector/InspectorUtilities.cpp: Removed.
  • inspector/InspectorUtilities.h: Removed.
04:02 Changeset [69756] by hayato@chromium.org
  • 2 edits in trunk/LayoutTests

2010-10-14 Hayato Ito <hayato@chromium.org>

Unreviewed, build fix.

Skip a test that does not have an expected result.
<http://trac.webkit.org/changeset/69751> lacked prefix of 'platform/gtk'.

  • platform/gtk/Skipped:
03:47 Changeset [69755] by andreas.kling@nokia.com
  • 9 edits
    3 adds in trunk

2010-10-14 Andreas Kling <kling@webkit.org>

Reviewed by Darin Adler.

Canvas: "currentColor" should inherit the canvas element's color
https://bugs.webkit.org/show_bug.cgi?id=40273

Add support for "currentColor" in CanvasRenderingContext2D APIs.
If the canvas is in-document, "currentColor" is replaced by canvas.style.color,
otherwise we use fully opaque black.

For gradient addColorStop(), "currentColor" always means fully opaque black.

Spec link:
http://www.whatwg.org/specs/web-apps/current-work/#2dcontext

Test: fast/canvas/canvas-currentColor.html

  • html/canvas/CanvasGradient.cpp: (WebCore::CanvasGradient::addColorStop):
  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::setStrokeStyle): (WebCore::CanvasRenderingContext2D::setFillStyle): (WebCore::CanvasRenderingContext2D::setShadowColor): (WebCore::CanvasRenderingContext2D::setShadow):
  • html/canvas/CanvasStyle.cpp: (WebCore::parseColor): (WebCore::currentColor): (WebCore::parseColorOrCurrentColor): (WebCore::CanvasStyle::CanvasStyle): (WebCore::CanvasStyle::createFromString): (WebCore::CanvasStyle::createFromStringWithOverrideAlpha): (WebCore::CanvasStyle::isEquivalentColor): (WebCore::CanvasStyle::applyStrokeColor): (WebCore::CanvasStyle::applyFillColor):
  • html/canvas/CanvasStyle.h: (WebCore::CanvasStyle::isCurrentColor): (WebCore::CanvasStyle::hasOverrideAlpha): (WebCore::CanvasStyle::overrideAlpha):

2010-10-14 Andreas Kling <kling@webkit.org>

Reviewed by Darin Adler.

Canvas: "currentColor" should inherit the canvas element's color
https://bugs.webkit.org/show_bug.cgi?id=40273

Added test to verify support for "currentColor" value in CanvasRenderingContext2D.

Also unskipped 3 tests which now pass:

  • canvas/philip/tests/2d.fillStyle.parse.current.basic.html
  • canvas/philip/tests/2d.fillStyle.parse.current.changed.html
  • canvas/philip/tests/2d.fillStyle.parse.current.removed.html

Spec link:
http://www.whatwg.org/specs/web-apps/current-work/#2dcontext

  • fast/canvas/canvas-currentColor-expected.txt: Added.
  • fast/canvas/canvas-currentColor.html: Added.
  • fast/canvas/script-tests/canvas-currentColor.js: Added. (attachCanvasToDocument): (tryLinearGradientColor): (tryRadialGradientColor):
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
02:20 Changeset [69754] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed fix after r69749.

  • platform/qt/fast/dom/Window/window-properties-expected.txt: Updated.
02:13 Changeset [69753] by commit-queue@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-10-14 Anton Faern <anton@bladehawke.com>

Reviewed by Csaba Osztrogonác.

https://bugs.webkit.org/show_bug.cgi?id=47658
NetBSD was not included in the WTF_PLATFORM_FOO to WTF_OS_FOO
change. This means that OS(NETBSD) is also undefined.

  • wtf/Platform.h: s/_PLATFORM_/_OS_/ for NetBSD
01:42 Changeset [69752] by yurys@chromium.org
  • 4 edits
    2 adds in trunk

2010-10-08 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [REGRESSION] Scripts panel: the bubble shows wrong values
https://bugs.webkit.org/show_bug.cgi?id=47358

Test: inspector/debugger-eval-on-call-frame.html

  • inspector/front-end/InjectedScript.js: (injectedScriptConstructor.): don't embrace expression evaluated in the local scope of a call frame into with(window) to avoid shadowing local variables by global ones.

2010-10-08 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [REGRESSION] Scripts panel: the bubble shows wrong values
https://bugs.webkit.org/show_bug.cgi?id=47358

  • inspector/debugger-eval-on-call-frame-expected.txt: Added.
  • inspector/debugger-eval-on-call-frame.html: Added.
01:39 Changeset [69751] by hayato@chromium.org
  • 2 edits in trunk/LayoutTests

2010-10-14 Hayato Ito <hayato@chromium.org>

Unreviewed, build fix.

Skip a test that does not have an expected result.

  • platform/gtk/Skipped:
01:18 Changeset [69750] by andreas.kling@nokia.com
  • 3 edits in trunk/LayoutTests

2010-10-14 Andreas Kling <kling@webkit.org>

Reviewed by Dirk Schulze.

svg/custom/use-on-symbol-inside-pattern.svg is failing
https://bugs.webkit.org/show_bug.cgi?id=17393

Re-enable this test since the debugString() discrepancy issue
disappeared with <http://trac.webkit.org/changeset/69386>

  • platform/mac-tiger/Skipped:
  • platform/win/Skipped:
01:02 Changeset [69749] by abarth@webkit.org
  • 14 edits
    4 adds in trunk

2010-10-13 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Implement getParameter from the URL API
https://bugs.webkit.org/show_bug.cgi?id=46610

Test various interesting cases in parameter parsing.

  • fast/dom/anchor-getParameter-expected.txt: Added.
  • fast/dom/anchor-getParameter.html: Added.
  • http/tests/misc/location-getParameter-expected.txt: Added.
  • http/tests/misc/location-getParameter.html: Added.

2010-10-13 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Implement getParameter from the URL API
https://bugs.webkit.org/show_bug.cgi?id=46610

Another API from
https://docs.google.com/document/edit?id=1r_VTFKApVOaNIkocrg0z-t7lZgzisTuGTXkdzAk4gLU&hl=en#
getParameter lets a web site easily read the value of a URL parameter.
This API is for the simple case of a non-repeated parameter name.
getParameterAll will handle repeated parameter names in a future patch.

Tests: fast/dom/anchor-getParameter.html

http/tests/misc/location-getParameter.html

  • html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::getParameter):
  • html/HTMLAnchorElement.h:
  • html/HTMLAnchorElement.idl:
  • page/Location.cpp: (WebCore::Location::getParameter):
  • page/Location.h:
  • page/Location.idl:
  • platform/KURL.cpp: (WebCore::KURL::copyParsedQueryTo):
  • platform/KURLGoogle.cpp: (WebCore::KURL::copyParsedQueryTo):
  • platform/KURL.h:
00:53 Changeset [69748] by alex@webkit.org
  • 2 edits in trunk/WebCore

2010-10-14 Alejandro G. Castro <alex@igalia.com>

Unreviewed. GTK build fix.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::sendRequestCallback):
00:18 Changeset [69747] by commit-queue@webkit.org
  • 8 edits
    6 adds in trunk

2010-10-14 Adrienne Walker <enne@google.com>

Reviewed by James Robinson.

Add a test for very large image layers. Skip this test for mac-wk2
because of the use of layerTreeAsText().
https://bugs.webkit.org/show_bug.cgi?id=47016

  • compositing/tiling/huge-layer-img.html: Added.
  • platform/chromium-gpu/compositing/tiling/huge-layer-img-expected.txt: Added.
  • platform/mac-wk2/Skipped:
  • platform/mac/compositing/tiling/huge-layer-img-expected.txt: Added.

2010-10-14 Adrienne Walker <enne@google.com>

Reviewed by James Robinson.

Add a short-term solution for large layers. Layers that are too
large to be contained in a single texture just upload the portion of
the layer that is within the content rect. A longer-term solution
is still tiling with proper memory management. Layers that have full
3D transforms (more than just translations) are still not drawn.
https://bugs.webkit.org/show_bug.cgi?id=47016

Test: compositing/tiling

  • platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::ContentLayerChromium): (WebCore::ContentLayerChromium::requiresClippedUpdateRect): (WebCore::ContentLayerChromium::calculateClippedUpdateRect): (WebCore::ContentLayerChromium::updateContents): (WebCore::ContentLayerChromium::updateTextureRect): (WebCore::ContentLayerChromium::draw):
  • platform/graphics/chromium/ContentLayerChromium.h:
  • platform/graphics/chromium/ImageLayerChromium.cpp: (WebCore::ImageLayerChromium::updateContents):
  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::drawLayers):
  • platform/graphics/chromium/LayerRendererChromium.h: (WebCore::LayerRendererChromium::rootLayerContentRect):
00:10 Changeset [69746] by crogers@google.com
  • 1 edit
    2 adds in trunk/WebCore

2010-10-14 Chris Rogers <crogers@google.com>

Reviewed by Chris Fleizach.

Add DelayDSPKernel files
https://bugs.webkit.org/show_bug.cgi?id=47518

No new tests since audio API is not yet implemented.

  • webaudio/DelayDSPKernel.cpp: Added. (WebCore::DelayDSPKernel::DelayDSPKernel): (WebCore::DelayDSPKernel::process): (WebCore::DelayDSPKernel::reset):
  • webaudio/DelayDSPKernel.h: Added. (WebCore::DelayDSPKernel::maxDelayTime): (WebCore::DelayDSPKernel::setDelayFrames): (WebCore::DelayDSPKernel::delayProcessor):
Note: See TracTimeline for information about the timeline view.