Timeline
10/19/10:
- 23:45 Changeset [70130] by
-
Windows build fix
- win/include/WebKitSystemInterface/WebKitSystemInterface.h: Check in
this file that I meant to check in in r70129.
- 23:36 Changeset [70129] by
-
Remove uses of CACFContextRef and CARender* from WebCore
These types are now wrapped in a WKCACFContext type exported by
WebKitSystemInterface.
Fixes <http://webkit.org/b/43244>.
Reviewed by Sam Weinig.
WebCore:
- platform/graphics/win/WKCACFContextFlusher.cpp:
(WebCore::WKCACFContextFlusher::addContext):
(WebCore::WKCACFContextFlusher::removeContext):
(WebCore::WKCACFContextFlusher::flushAllContexts):
- platform/graphics/win/WKCACFContextFlusher.h:
Changed to use WKCACFContext. We don't retain/release the context when
putting it into/taking it out of the set. WKCACFContext is not a
ref-counted type, so we can't retain/release it, but the
retain/release was also unnecessary as WKCACFLayerRenderer calls
removeContext before the context is destroyed.
- platform/graphics/win/WKCACFLayer.cpp:
(WebCore::WKCACFLayer::becomeRootLayerForContext):
- platform/graphics/win/WKCACFLayer.h:
Changed to use WKCACFContext.
- platform/graphics/win/WKCACFLayerRenderer.cpp:
(WebCore::WKCACFLayerRenderer::didFlushContext):
(WebCore::WKCACFLayerRenderer::WKCACFLayerRenderer):
(WebCore::WKCACFLayerRenderer::~WKCACFLayerRenderer):
(WebCore::WKCACFLayerRenderer::layerTreeDidChange):
(WebCore::WKCACFLayerRenderer::createRenderer):
(WebCore::WKCACFLayerRenderer::destroyRenderer):
(WebCore::WKCACFLayerRenderer::render): Also replaced uses of
CGSRegion with WebKitSystemInterface functions/types.
(WebCore::WKCACFLayerRenderer::resetDevice):
- platform/graphics/win/WKCACFLayerRenderer.h:
Replaced our CACFContextRef, CARenderContext, and CARenderOGLContext
with a single WKCACFContext, which wraps all three. We hold a bare
pointer to it and destroy it in our destructor.
WebKitLibraries:
Add WKCACFContext and related functions
- win/lib/WebKitSystemInterface.lib:
- win/lib/WebKitSystemInterface_debug.lib:
- 23:33 Changeset [70128] by
-
Teach update-webkit-support-libs about the new versioning of WebKitSupportLibrary
Fixes <http://webkit.org/b/47915> update-webkit-support-libs should
check version numbers instead of modification times
Reviewed by Sam Weinig.
- Scripts/update-webkit-support-libs: Fetch the expected version
number from developer.apple.com, then compare with the version number
of the extracted library and of the zipped library to see if anything
needs to be done. Removed code that tracked the modified timestamp of
the library, as it is no longer needed.
- 21:59 Changeset [70127] by
-
2010-10-19 Yuzo Fujishima <yuzo@google.com>
Unreviewed Chromium test rebaseline.
- platform/chromium-mac/fast/borders/border-image-scale-transform-expected.checksum: Added.
- platform/chromium-mac/fast/borders/border-image-scale-transform-expected.png: Added.
- 21:43 Changeset [70126] by
-
2010-10-19 Kwang Yul Seo <skyul@company100.net>
Reviewed by David Kilzer.
[BREWMP] Turn off JIT for simulator build
https://bugs.webkit.org/show_bug.cgi?id=47937
We don't need to test x86 JIT.
- wtf/Platform.h:
- 20:34 Changeset [70125] by
-
2010-10-19 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r70124.
http://trac.webkit.org/changeset/70124
https://bugs.webkit.org/show_bug.cgi?id=47965
test expectation conflict (Requested by yuzo on #webkit).
- platform/chromium/test_expectations.txt:
- 20:24 Changeset [70124] by
-
2010-10-19 Yuzo Fujishima <yuzo@google.com>
Unreviewed Chromium test expectation change.
The following tests are failing for WIN and LINUX.
editing/spelling/spelling-contenteditable.html
editing/spelling/spelling-textarea.html
- platform/chromium/test_expectations.txt:
- 20:19 Changeset [70123] by
-
2010-10-19 James Robinson <jamesr@chromium.org>
Update chromium expectations.
- platform/chromium/test_expectations.txt:
- 20:07 Changeset [70122] by
-
2010-10-19 James Robinson <jamesr@chromium.org>
Update chromium expectations and add baselines for new test.
- platform/chromium-linux/fast/images/pixel-crack-image-background-webkit-transform-scale-expected.checksum: Added.
- platform/chromium-linux/fast/images/pixel-crack-image-background-webkit-transform-scale-expected.png: Added.
- platform/chromium-mac/fast/images/pixel-crack-image-background-webkit-transform-scale-expected.checksum: Added.
- platform/chromium-mac/fast/images/pixel-crack-image-background-webkit-transform-scale-expected.png: Added.
- platform/chromium-win/fast/images/pixel-crack-image-background-webkit-transform-scale-expected.checksum: Added.
- platform/chromium-win/fast/images/pixel-crack-image-background-webkit-transform-scale-expected.png: Added.
- platform/chromium-win/fast/images/pixel-crack-image-background-webkit-transform-scale-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- 19:53 Changeset [70121] by
-
2010-10-19 Jenn Braithwaite <jennb@chromium.org>
Reviewed by David Levin.
Add DirectX SDK to Installing Developer Tools web page
https://bugs.webkit.org/show_bug.cgi?id=47911
- building/tools.html:
- 19:18 Changeset [70120] by
-
2010-10-19 Ryuan Choi <ryuan.choi@samsung.com>
Unreviewed, adding missed additionalArguments.
[CMAKE] additional arguments was missed in GENERATE_DOM_NAMES
https://bugs.webkit.org/show_bug.cgi?id=47694
Pass additionalArguments for make_names.pl to choose enabled features.
- cmake/WebKitMacros.cmake:
- 18:55 Changeset [70119] by
-
2010-10-19 Kenneth Russell <kbr@google.com>
Unreviewed, test expectations update.
Added initial test expectations for the chromium-gpu configuration,
generated on Windows. Pixel results have been added under chromium-gpu-win.
The hope is that at least the text results might be shareable between the
Windows and Linux platforms; for the time being, they are being placed
under chromium-gpu, though they may be moved in the near future.
platform/chromium-gpu/test_expectations.txt still has all of the tests
marked "PASS FAIL". Only once we have a certain set of the tests passing on
all three platforms (Windows, Mac, Linux) will we remove the FAIL from that
line. The current effort has focused on the "compositing" directory.
- platform/chromium-gpu-win/compositing: Added.
- platform/chromium-gpu-win/compositing/animation: Added.
- platform/chromium-gpu-win/compositing/animation/state-at-end-event-transform-layer-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/animation/state-at-end-event-transform-layer-expected.png: Added.
- platform/chromium-gpu-win/compositing/compositing-visible-descendant-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/compositing-visible-descendant-expected.png: Added.
- platform/chromium-gpu-win/compositing/direct-image-compositing-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/direct-image-compositing-expected.png: Added.
- platform/chromium-gpu-win/compositing/generated-content-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/generated-content-expected.png: Added.
- platform/chromium-gpu-win/compositing/geometry: Added.
- platform/chromium-gpu-win/compositing/geometry/clipping-foreground-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/geometry/clipping-foreground-expected.png: Added.
- platform/chromium-gpu-win/compositing/geometry/fixed-in-composited-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/geometry/fixed-in-composited-expected.png: Added.
- platform/chromium-gpu-win/compositing/geometry/fixed-position-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/geometry/fixed-position-expected.png: Added.
- platform/chromium-gpu-win/compositing/geometry/horizontal-scroll-composited-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/geometry/horizontal-scroll-composited-expected.png: Added.
- platform/chromium-gpu-win/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.png: Added.
- platform/chromium-gpu-win/compositing/geometry/outline-change-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/geometry/outline-change-expected.png: Added.
- platform/chromium-gpu-win/compositing/geometry/partial-layout-update-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/geometry/partial-layout-update-expected.png: Added.
- platform/chromium-gpu-win/compositing/geometry/root-layer-update-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/geometry/root-layer-update-expected.png: Added.
- platform/chromium-gpu-win/compositing/geometry/transfrom-origin-on-zero-size-layer-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/geometry/transfrom-origin-on-zero-size-layer-expected.png: Added.
- platform/chromium-gpu-win/compositing/geometry/vertical-scroll-composited-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/geometry/vertical-scroll-composited-expected.png: Added.
- platform/chromium-gpu-win/compositing/iframes: Added.
- platform/chromium-gpu-win/compositing/iframes/composited-iframe-alignment-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/iframes/composited-iframe-alignment-expected.png: Added.
- platform/chromium-gpu-win/compositing/iframes/iframe-content-flipping-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/iframes/iframe-content-flipping-expected.png: Added.
- platform/chromium-gpu-win/compositing/iframes/iframe-copy-on-scroll-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/iframes/iframe-copy-on-scroll-expected.png: Added.
- platform/chromium-gpu-win/compositing/iframes/iframe-in-composited-layer-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/iframes/iframe-in-composited-layer-expected.png: Added.
- platform/chromium-gpu-win/compositing/images: Added.
- platform/chromium-gpu-win/compositing/images/direct-image-background-color-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/images/direct-image-background-color-expected.png: Added.
- platform/chromium-gpu-win/compositing/overflow: Added.
- platform/chromium-gpu-win/compositing/overflow/fixed-position-ancestor-clip-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/overflow/fixed-position-ancestor-clip-expected.png: Added.
- platform/chromium-gpu-win/compositing/overflow/overflow-positioning-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/overflow/overflow-positioning-expected.png: Added.
- platform/chromium-gpu-win/compositing/overflow/overflow-scroll-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/overflow/overflow-scroll-expected.png: Added.
- platform/chromium-gpu-win/compositing/overflow/parent-overflow-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/overflow/parent-overflow-expected.png: Added.
- platform/chromium-gpu-win/compositing/overflow/scrollbar-painting-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/overflow/scrollbar-painting-expected.png: Added.
- platform/chromium-gpu-win/compositing/overflow/zero-size-overflow-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/overflow/zero-size-overflow-expected.png: Added.
- platform/chromium-gpu-win/compositing/reflections: Added.
- platform/chromium-gpu-win/compositing/reflections/backface-hidden-reflection-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/reflections/backface-hidden-reflection-expected.png: Added.
- platform/chromium-gpu-win/compositing/reflections/reflection-in-composited-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/reflections/reflection-in-composited-expected.png: Added.
- platform/chromium-gpu-win/compositing/repaint: Added.
- platform/chromium-gpu-win/compositing/repaint/become-overlay-composited-layer-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/repaint/become-overlay-composited-layer-expected.png: Added.
- platform/chromium-gpu-win/compositing/repaint/content-into-overflow-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/repaint/content-into-overflow-expected.png: Added.
- platform/chromium-gpu-win/compositing/repaint/layer-repaint-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/repaint/layer-repaint-expected.png: Added.
- platform/chromium-gpu-win/compositing/repaint/layer-repaint-rects-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/repaint/layer-repaint-rects-expected.png: Added.
- platform/chromium-gpu-win/compositing/repaint/opacity-between-absolute-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/repaint/opacity-between-absolute-expected.png: Added.
- platform/chromium-gpu-win/compositing/repaint/opacity-between-absolute2-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/repaint/opacity-between-absolute2-expected.png: Added.
- platform/chromium-gpu-win/compositing/repaint/overflow-into-content-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/repaint/overflow-into-content-expected.png: Added.
- platform/chromium-gpu-win/compositing/sibling-positioning-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/sibling-positioning-expected.png: Added.
- platform/chromium-gpu-win/compositing/transitions: Added.
- platform/chromium-gpu-win/compositing/transitions/singular-scale-transition-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/transitions/singular-scale-transition-expected.png: Added.
- platform/chromium-gpu/compositing/animation: Added.
- platform/chromium-gpu/compositing/animation/animated-composited-inside-hidden-expected.txt: Added.
- platform/chromium-gpu/compositing/animation/animation-compositing-expected.txt: Added.
- platform/chromium-gpu/compositing/animation/computed-style-during-delay-expected.txt: Added.
- platform/chromium-gpu/compositing/animation/state-at-end-event-transform-layer-expected.txt: Added.
- platform/chromium-gpu/compositing/composited-negative-zindex-child-expected.txt: Added.
- platform/chromium-gpu/compositing/compositing-visible-descendant-expected.txt: Added.
- platform/chromium-gpu/compositing/direct-image-compositing-expected.txt: Added.
- platform/chromium-gpu/compositing/generated-content-expected.txt: Added.
- platform/chromium-gpu/compositing/geometry: Added.
- platform/chromium-gpu/compositing/geometry/clip-expected.txt: Added.
- platform/chromium-gpu/compositing/geometry/clipping-foreground-expected.txt: Added.
- platform/chromium-gpu/compositing/geometry/empty-embed-rects-expected.txt: Added.
- platform/chromium-gpu/compositing/geometry/fixed-in-composited-expected.txt: Added.
- platform/chromium-gpu/compositing/geometry/fixed-position-expected.txt: Added.
- platform/chromium-gpu/compositing/geometry/horizontal-scroll-composited-expected.txt: Added.
- platform/chromium-gpu/compositing/geometry/huge-layer-expected.txt: Added.
- platform/chromium-gpu/compositing/geometry/limit-layer-bounds-fixed-positioned-expected.txt: Added.
- platform/chromium-gpu/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.txt: Added.
- platform/chromium-gpu/compositing/geometry/limit-layer-bounds-positioned-expected.txt: Added.
- platform/chromium-gpu/compositing/geometry/limit-layer-bounds-positioned-transition-expected.txt: Added.
- platform/chromium-gpu/compositing/geometry/limit-layer-bounds-transformed-expected.txt: Added.
- platform/chromium-gpu/compositing/geometry/object-clip-rects-assertion-expected.txt: Added.
- platform/chromium-gpu/compositing/geometry/outline-change-expected.txt: Added.
- platform/chromium-gpu/compositing/geometry/partial-layout-update-expected.txt: Added.
- platform/chromium-gpu/compositing/geometry/preserve-3d-switching-expected.txt: Added.
- platform/chromium-gpu/compositing/geometry/root-layer-update-expected.txt: Added.
- platform/chromium-gpu/compositing/geometry/transfrom-origin-on-zero-size-layer-expected.txt: Added.
- platform/chromium-gpu/compositing/geometry/vertical-scroll-composited-expected.txt: Added.
- platform/chromium-gpu/compositing/iframes: Added.
- platform/chromium-gpu/compositing/iframes/composited-iframe-alignment-expected.txt: Added.
- platform/chromium-gpu/compositing/iframes/composited-parent-iframe-expected.txt: Added.
- platform/chromium-gpu/compositing/iframes/connect-compositing-iframe-delayed-expected.txt: Added.
- platform/chromium-gpu/compositing/iframes/connect-compositing-iframe-expected.txt: Added.
- platform/chromium-gpu/compositing/iframes/connect-compositing-iframe2-expected.txt: Added.
- platform/chromium-gpu/compositing/iframes/connect-compositing-iframe3-expected.txt: Added.
- platform/chromium-gpu/compositing/iframes/enter-compositing-iframe-expected.txt: Added.
- platform/chromium-gpu/compositing/iframes/iframe-content-flipping-expected.txt: Added.
- platform/chromium-gpu/compositing/iframes/iframe-copy-on-scroll-expected.txt: Added.
- platform/chromium-gpu/compositing/iframes/iframe-in-composited-layer-expected.txt: Added.
- platform/chromium-gpu/compositing/iframes/iframe-resize-expected.txt: Added.
- platform/chromium-gpu/compositing/iframes/iframe-size-from-zero-expected.txt: Added.
- platform/chromium-gpu/compositing/iframes/iframe-size-to-zero-expected.txt: Added.
- platform/chromium-gpu/compositing/iframes/iframe-src-change-expected.txt: Added.
- platform/chromium-gpu/compositing/iframes/layout-on-compositing-change-expected.txt: Added.
- platform/chromium-gpu/compositing/iframes/leave-compositing-iframe-expected.txt: Added.
- platform/chromium-gpu/compositing/iframes/overlapped-iframe-expected.txt: Added.
- platform/chromium-gpu/compositing/iframes/remove-iframe-crash-expected.txt: Added.
- platform/chromium-gpu/compositing/iframes/scrolling-iframe-expected.txt: Added.
- platform/chromium-gpu/compositing/images: Added.
- platform/chromium-gpu/compositing/images/clip-on-directly-composited-image-expected.txt: Added.
- platform/chromium-gpu/compositing/images/content-image-expected.txt: Added.
- platform/chromium-gpu/compositing/images/direct-image-background-color-expected.txt: Added.
- platform/chromium-gpu/compositing/layer-creation: Added.
- platform/chromium-gpu/compositing/layer-creation/scroll-partial-update-expected.txt: Added.
- platform/chromium-gpu/compositing/overflow: Added.
- platform/chromium-gpu/compositing/overflow/clip-descendents-expected.txt: Added.
- platform/chromium-gpu/compositing/overflow/fixed-position-ancestor-clip-expected.txt: Added.
- platform/chromium-gpu/compositing/overflow/get-transform-from-non-box-container-expected.txt: Added.
- platform/chromium-gpu/compositing/overflow/overflow-positioning-expected.txt: Added.
- platform/chromium-gpu/compositing/overflow/overflow-scroll-expected.txt: Added.
- platform/chromium-gpu/compositing/overflow/parent-overflow-expected.txt: Added.
- platform/chromium-gpu/compositing/overflow/resize-painting-expected.txt: Added.
- platform/chromium-gpu/compositing/overflow/scrollbar-painting-expected.txt: Added.
- platform/chromium-gpu/compositing/overflow/zero-size-overflow-expected.txt: Added.
- platform/chromium-gpu/compositing/plugins: Added.
- platform/chromium-gpu/compositing/plugins/1x1-composited-plugin-expected.txt: Added.
- platform/chromium-gpu/compositing/plugins/large-to-small-composited-plugin-expected.txt: Added.
- platform/chromium-gpu/compositing/plugins/small-to-large-composited-plugin-expected.txt: Added.
- platform/chromium-gpu/compositing/reflections: Added.
- platform/chromium-gpu/compositing/reflections/backface-hidden-reflection-expected.txt: Added.
- platform/chromium-gpu/compositing/reflections/reflection-in-composited-expected.txt: Added.
- platform/chromium-gpu/compositing/repaint: Added.
- platform/chromium-gpu/compositing/repaint/become-overlay-composited-layer-expected.txt: Added.
- platform/chromium-gpu/compositing/repaint/content-into-overflow-expected.txt: Added.
- platform/chromium-gpu/compositing/repaint/inline-repaint-container-expected.txt: Added.
- platform/chromium-gpu/compositing/repaint/layer-repaint-expected.txt: Added.
- platform/chromium-gpu/compositing/repaint/layer-repaint-rects-expected.txt: Added.
- platform/chromium-gpu/compositing/repaint/opacity-between-absolute-expected.txt: Added.
- platform/chromium-gpu/compositing/repaint/opacity-between-absolute2-expected.txt: Added.
- platform/chromium-gpu/compositing/repaint/overflow-into-content-expected.txt: Added.
- platform/chromium-gpu/compositing/sibling-positioning-expected.txt: Added.
- platform/chromium-gpu/compositing/tiling/crash-reparent-tiled-layer-expected.txt: Added.
- platform/chromium-gpu/compositing/tiling/huge-layer-resize-expected.txt: Added.
- platform/chromium-gpu/compositing/tiling/huge-layer-with-layer-children-resize-expected.txt: Added.
- platform/chromium-gpu/compositing/transitions: Added.
- platform/chromium-gpu/compositing/transitions/opacity-on-inline-expected.txt: Added.
- platform/chromium-gpu/compositing/transitions/singular-scale-transition-expected.txt: Added.
- platform/chromium-gpu/test_expectations.txt:
- 18:44 Changeset [70118] by
-
2010-10-19 Yongjun Zhang <yongjun_zhang@apple.com>
Reviewed by Dan Bernstein.
Pixel cracks when using background image sprite on transformed element at certain scales.
https://bugs.webkit.org/show_bug.cgi?id=47868
- fast/images/pixel-crack-image-background-webkit-transform-scale.html: Added.
- fast/images/resources/pixel-crack-image-background-webkit-transform-scale.png: Added.
- platform/mac/fast/images/pixel-crack-image-background-webkit-transform-scale-expected.checksum: Added.
- platform/mac/fast/images/pixel-crack-image-background-webkit-transform-scale-expected.png: Added.
- platform/mac/fast/images/pixel-crack-image-background-webkit-transform-scale-expected.txt: Added.
2010-10-19 Yongjun Zhang <yongjun_zhang@apple.com>
Reviewed by Dan Bernstein.
Pixel cracks when using background image sprite on transformed element at certain scales.
https://bugs.webkit.org/show_bug.cgi?id=47868
The pixel bleeding happens when the current context has scale and interpolation is kCGInterpolationHigh
or kCGInterpolationDefault. If the source rect size is smaller than the intrinsic image size, some
pixels outside of the clip rect will also be used to interpolate the color value for clip edges, which
results in unwanted thin lines around the painted area. We need to use sub-image patch to get rid of
the artifacts in this case.
Test: fast/images/pixel-crack-image-background-webkit-transform-scale.html
- platform/graphics/cg/ImageCG.cpp: (WebCore::BitmapImage::draw):
- 18:26 Changeset [70117] by
-
2010-10-19 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Teach feeder-queue how to feed the EWS bots
https://bugs.webkit.org/show_bug.cgi?id=47943
queues.webkit.org already knew how to accept EWS submissions
via /submit-to-ews. This teaches the feeder queue how to post
to that page with any new r? patches it sees.
- QueueStatusServer/model/activeworkitems_unitest.py: Added.
- More unit testing is always a good thing.
- Scripts/webkitpy/common/net/bugzilla.py:
- Scripts/webkitpy/common/net/statusserver.py:
- Scripts/webkitpy/tool/bot/feeders.py:
- Scripts/webkitpy/tool/commands/queues.py:
- Scripts/webkitpy/tool/commands/queues_unittest.py:
- Scripts/webkitpy/tool/mocktool.py:
- QueueStatusServer/model/activeworkitems_unitest.py: Added.
- 18:25 Changeset [70116] by
-
2010-10-19 James Robinson <jamesr@chromium.org>
Remove test expectations entries for tests that consistently pass.
- platform/chromium/test_expectations.txt:
- 18:10 Changeset [70115] by
-
2010-10-19 Tony Chang <tony@chromium.org>
Unreviewed, plugins/plugin-javascript-access.html is
passing again on Chromium mac after a chromium side fix to TestShell.
- platform/chromium/test_expectations.txt:
- 18:08 Changeset [70114] by
-
2010-10-19 Evan Martin <evan@chromium.org>
Reviewed by Tony Chang.
sqlite: remove unused member variable
https://bugs.webkit.org/show_bug.cgi?id=47957
There's no need to save the error code into a member variable
because nobody ever looks at it.
- platform/sql/SQLiteDatabase.cpp: (WebCore::SQLiteDatabase::open):
- platform/sql/SQLiteDatabase.h:
- 17:20 Changeset [70113] by
-
2010-10-19 Jia Pu <jpu@apple.com>
Reviewed by James Robinson.
Moving cursor back to autocorrected word in the same line shouldn't remove the underline
https://bugs.webkit.org/show_bug.cgi?id=47629
<rdar://problem/8546758>
Patch <http://trac.webkit.org/changeset/70071> breaks some Chromium Mac hehavior. This patch
fixes that.
- editing/Editor.cpp: (WebCore::Editor::respondToChangedSelection): Add "!PLATFORM(MAC)" to make sure nothing changes on non-Mac platforms.
- 17:06 Changeset [70112] by
-
Merge 70102 - Rename createBlobURL to createObjectURL and revokeBlobURL to
revokeObjectURL per the latest File API spec.
https://bugs.webkit.org/show_bug.cgi?id=47934
Reviewed by Darin Fisher.
BUG=59875
TEST=none
- 16:55 Changeset [70111] by
-
2010-10-19 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
Remove support for JSVALUE32 from JSC
https://bugs.webkit.org/show_bug.cgi?id=47948
Remove all the code for supporting JSVALUE32 from JSC.
- jit/JIT.cpp: (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompileSlowCases):
- jit/JIT.h:
- jit/JITArithmetic.cpp: (JSC::JIT::emit_op_lshift): (JSC::JIT::emitSlow_op_lshift): (JSC::JIT::emit_op_rshift): (JSC::JIT::emitSlow_op_rshift): (JSC::JIT::emit_op_urshift): (JSC::JIT::emitSlow_op_urshift): (JSC::JIT::emit_op_jnless): (JSC::JIT::emitSlow_op_jnless): (JSC::JIT::emit_op_jless): (JSC::JIT::emitSlow_op_jless): (JSC::JIT::emit_op_jlesseq): (JSC::JIT::emitSlow_op_jlesseq): (JSC::JIT::emit_op_bitand): (JSC::JIT::emit_op_post_inc): (JSC::JIT::emit_op_post_dec): (JSC::JIT::emit_op_pre_inc): (JSC::JIT::emit_op_pre_dec): (JSC::JIT::emit_op_mod): (JSC::JIT::emitSlow_op_mod):
- jit/JITCall.cpp:
- jit/JITInlineMethods.h: (JSC::JIT::emitGetFromCallFrameHeaderPtr): (JSC::JIT::emitGetFromCallFrameHeader32):
- jit/JITOpcodes.cpp: (JSC::JIT::emit_op_loop_if_lesseq): (JSC::JIT::emit_op_bitnot): (JSC::JIT::emit_op_next_pname):
- jit/JITPropertyAccess.cpp: (JSC::JIT::emit_op_get_by_val): (JSC::JIT::emit_op_put_by_val):
- jit/JITStubs.h:
- jit/JSInterfaceJIT.h:
- jit/SpecializedThunkJIT.h: (JSC::SpecializedThunkJIT::returnDouble): (JSC::SpecializedThunkJIT::tagReturnAsInt32):
- jit/ThunkGenerators.cpp: (JSC::sqrtThunkGenerator): (JSC::powThunkGenerator):
- runtime/Collector.cpp: (JSC::isPossibleCell): (JSC::typeName):
- runtime/JSCell.h:
- runtime/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData):
- runtime/JSGlobalData.h:
- runtime/JSGlobalObject.h: (JSC::Structure::prototypeForLookup):
- runtime/JSImmediate.h: (JSC::reinterpretIntptrToDouble): (JSC::JSImmediate::isIntegerNumber): (JSC::JSImmediate::isDouble): (JSC::JSImmediate::areBothImmediateIntegerNumbers): (JSC::JSImmediate::makeDouble): (JSC::JSImmediate::doubleValue): (JSC::JSImmediate::toBoolean): (JSC::JSImmediate::fromNumberOutsideIntegerRange): (JSC::JSImmediate::from): (JSC::JSImmediate::toDouble): (JSC::JSFastMath::rightShiftImmediateNumbers):
- runtime/JSNumberCell.cpp:
- runtime/JSNumberCell.h:
- runtime/JSObject.h: (JSC::JSObject::JSObject):
- runtime/JSValue.h:
- runtime/NumberObject.h:
- wtf/Platform.h:
- 16:41 Changeset [70110] by
-
2010-10-19 Tony Chang <tony@chromium.org>
Unreviewed, updating drt expectations for plugin tests on mac.
- platform/chromium/drt_expectations.txt:
- 16:40 Changeset [70109] by
-
Fix MiniBrowser crashes during startup and shutdown
https://bugs.webkit.org/show_bug.cgi?id=47954
Reviewed by Sam Weinig.
- UIProcess/WebContext.cpp:
(WebKit::WebContext::sharedProcessContext):
Initialize the main thread.
(WebKit::WebContext::create):
Ditto.
(WebKit::WebContext::WebContext):
Add the language observer here so we know that it will always be set up.
(WebKit::WebContext::ensureWebProcess):
Remove code.
- UIProcess/WebContext.h:
- 16:27 Changeset [70108] by
-
Versioning.
- 16:25 Changeset [70107] by
-
Merge 69804 - 2010-10-14 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
Cache link status at linkProgram and use it in useProgram instead of querying GPU
https://bugs.webkit.org/show_bug.cgi?id=47685
- html/canvas/WebGLProgram.cpp: Always cache link status at linkStatus and use it upon query. (WebCore::WebGLProgram::WebGLProgram):
- html/canvas/WebGLProgram.h: Ditto. (WebCore::WebGLProgram::getLinkStatus): (WebCore::WebGLProgram::setLinkStatus):
- html/canvas/WebGLRenderingContext.cpp: Ditto. (WebCore::WebGLRenderingContext::getProgramParameter): (WebCore::WebGLRenderingContext::linkProgram): (WebCore::WebGLRenderingContext::useProgram):
TBR=zmo@google.com
- 16:23 Changeset [70106] by
-
New tag.
- 16:17 Changeset [70105] by
-
2010-10-19 James Robinson <jamesr@chromium.org>
Update chromium test expectations
- platform/chromium/test_expectations.txt:
- 16:15 Changeset [70104] by
-
Build fix (EFL, maybe more).
- CMakeLists.txt: Added platform/Language.cpp here, too.
- 16:02 Changeset [70103] by
-
2010-10-19 Eric Seidel <eric@webkit.org>
Unreviewed, just fixing test-webkitpy. I'm really on a roll today.
commit-queue gets stuck when release-patch returns 404
https://bugs.webkit.org/show_bug.cgi?id=47935
Fix test-webkitpy and unittest NetworkTransaction.
- Scripts/webkitpy/common/net/networktransaction.py:
- Scripts/webkitpy/common/net/networktransaction_unittest.py:
- 16:02 Changeset [70102] by
-
Rename createBlobURL to createObjectURL and revokeBlobURL to
revokeObjectURL per the latest File API spec.
https://bugs.webkit.org/show_bug.cgi?id=47934
Reviewed by Darin Fisher.
WebCore:
- inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype._contextMenu):
- inspector/front-end/utilities.js:
- page/DOMWindow.cpp:
(WebCore::DOMWindow::createObjectURL):
(WebCore::DOMWindow::revokeObjectURL):
- page/DOMWindow.h:
- page/DOMWindow.idl:
- workers/WorkerContext.cpp:
(WebCore::WorkerContext::createObjectURL):
(WebCore::WorkerContext::revokeObjectURL):
- workers/WorkerContext.h:
- workers/WorkerContext.idl:
LayoutTests:
Update all the related test and result files to account for the
renaming changes.
- fast/dom/Window/script-tests/window-property-descriptors.js:
- fast/dom/Window/window-properties-expected.txt:
- fast/dom/Window/window-properties.html:
- fast/dom/script-tests/prototype-inheritance.js:
- fast/files/apply-blob-url-to-img.html:
- fast/files/apply-blob-url-to-xhr.html:
- fast/files/create-blob-url-crash-expected.txt:
- fast/files/create-blob-url-crash.html:
- fast/files/revoke-blob-url-expected.txt:
- fast/files/revoke-blob-url.html:
- fast/files/workers/resources/worker-apply-blob-url-to-xhr.js:
- 15:59 Changeset [70101] by
-
Merge 69747 - 2010-10-14 Adrienne Walker <enne@google.com>
Reviewed by James Robinson.
Add a test for very large image layers. Skip this test for mac-wk2
because of the use of layerTreeAsText().
https://bugs.webkit.org/show_bug.cgi?id=47016
- compositing/tiling/huge-layer-img.html: Added.
- platform/chromium-gpu/compositing/tiling/huge-layer-img-expected.txt: Added.
- platform/mac-wk2/Skipped:
- platform/mac/compositing/tiling/huge-layer-img-expected.txt: Added.
2010-10-14 Adrienne Walker <enne@google.com>
Reviewed by James Robinson.
Add a short-term solution for large layers. Layers that are too
large to be contained in a single texture just upload the portion of
the layer that is within the content rect. A longer-term solution
is still tiling with proper memory management. Layers that have full
3D transforms (more than just translations) are still not drawn.
https://bugs.webkit.org/show_bug.cgi?id=47016
Test: compositing/tiling
- platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::ContentLayerChromium): (WebCore::ContentLayerChromium::requiresClippedUpdateRect): (WebCore::ContentLayerChromium::calculateClippedUpdateRect): (WebCore::ContentLayerChromium::updateContents): (WebCore::ContentLayerChromium::updateTextureRect): (WebCore::ContentLayerChromium::draw):
- platform/graphics/chromium/ContentLayerChromium.h:
- platform/graphics/chromium/ImageLayerChromium.cpp: (WebCore::ImageLayerChromium::updateContents):
- platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::drawLayers):
- platform/graphics/chromium/LayerRendererChromium.h: (WebCore::LayerRendererChromium::rootLayerContentRect):
- 15:55 Changeset [70100] by
-
Reverting 70099 as checkin messed up Changelog files..
Revert 70099 - Merge 69747 - 2010-10-14 Adrienne Walker <enne@google.com>
Reviewed by James Robinson.
Add a test for very large image layers. Skip this test for mac-wk2
because of the use of layerTreeAsText().
https://bugs.webkit.org/show_bug.cgi?id=47016
- compositing/tiling/huge-layer-img.html: Added.
- platform/chromium-gpu/compositing/tiling/huge-layer-img-expected.txt: Added.
- platform/mac-wk2/Skipped:
- platform/mac/compositing/tiling/huge-layer-img-expected.txt: Added.
2010-10-14 Adrienne Walker <enne@google.com>
Reviewed by James Robinson.
Add a short-term solution for large layers. Layers that are too
large to be contained in a single texture just upload the portion of
the layer that is within the content rect. A longer-term solution
is still tiling with proper memory management. Layers that have full
3D transforms (more than just translations) are still not drawn.
https://bugs.webkit.org/show_bug.cgi?id=47016
Test: compositing/tiling
- platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::ContentLayerChromium): (WebCore::ContentLayerChromium::requiresClippedUpdateRect): (WebCore::ContentLayerChromium::calculateClippedUpdateRect): (WebCore::ContentLayerChromium::updateContents): (WebCore::ContentLayerChromium::updateTextureRect): (WebCore::ContentLayerChromium::draw):
- platform/graphics/chromium/ContentLayerChromium.h:
- platform/graphics/chromium/ImageLayerChromium.cpp: (WebCore::ImageLayerChromium::updateContents):
- platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::drawLayers):
- platform/graphics/chromium/LayerRendererChromium.h: (WebCore::LayerRendererChromium::rootLayerContentRect):
- 15:49 Changeset [70099] by
-
Merge 69747 - 2010-10-14 Adrienne Walker <enne@google.com>
Reviewed by James Robinson.
Add a test for very large image layers. Skip this test for mac-wk2
because of the use of layerTreeAsText().
https://bugs.webkit.org/show_bug.cgi?id=47016
- compositing/tiling/huge-layer-img.html: Added.
- platform/chromium-gpu/compositing/tiling/huge-layer-img-expected.txt: Added.
- platform/mac-wk2/Skipped:
- platform/mac/compositing/tiling/huge-layer-img-expected.txt: Added.
2010-10-14 Adrienne Walker <enne@google.com>
Reviewed by James Robinson.
Add a short-term solution for large layers. Layers that are too
large to be contained in a single texture just upload the portion of
the layer that is within the content rect. A longer-term solution
is still tiling with proper memory management. Layers that have full
3D transforms (more than just translations) are still not drawn.
https://bugs.webkit.org/show_bug.cgi?id=47016
Test: compositing/tiling
- platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::ContentLayerChromium): (WebCore::ContentLayerChromium::requiresClippedUpdateRect): (WebCore::ContentLayerChromium::calculateClippedUpdateRect): (WebCore::ContentLayerChromium::updateContents): (WebCore::ContentLayerChromium::updateTextureRect): (WebCore::ContentLayerChromium::draw):
- platform/graphics/chromium/ContentLayerChromium.h:
- platform/graphics/chromium/ImageLayerChromium.cpp: (WebCore::ImageLayerChromium::updateContents):
- platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::drawLayers):
- platform/graphics/chromium/LayerRendererChromium.h: (WebCore::LayerRendererChromium::rootLayerContentRect):
- 15:48 Changeset [70098] by
-
Coalesce plug-in drawing
https://bugs.webkit.org/show_bug.cgi?id=47939
Reviewed by Sam Weinig.
Coalesce plug-in drawing in the same manner as we do it in the chunked update drawing area.
- PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::PluginControllerProxy):
Initialize m_waitingForDidUpdate to false.
(WebKit::PluginControllerProxy::startPaintTimer):
Move code from invalidate out to here. Don't start the paint timer if m_waitingForDidUpdate is true.
(WebKit::PluginControllerProxy::invalidate):
Call startPaintTimer.
(WebKit::PluginControllerProxy::didUpdate):
Set m_waitingForDidUpdate to false and start the paint timer.
- PluginProcess/PluginControllerProxy.messages.in:
Add DidUpdate message.
- WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::PluginProxy):
Initialize m_waitingForPaintInResponseToUpdate to false.
(WebKit::PluginProxy::paint):
If m_waitingForPaintInResponseToUpdate is true, send a DidUpdate message.
(WebKit::PluginProxy::update):
Set m_waitingForPaintInResponseToUpdate to true.
- 15:45 Changeset [70097] by
-
Add alternateHTMLString and unreachableURL API to WebKit2
<rdar://problem/8557864>
https://bugs.webkit.org/show_bug.cgi?id=47938
Reviewed by Anders Carlsson.
- UIProcess/API/C/WKFrame.cpp:
(WKFrameCopyUnreachableURL):
- UIProcess/API/C/WKFrame.h:
Add accessor for the unreachableURL if one is set. It will only be
set during a loadAlternateHTMLString and will be unset on the next normal
didStartProvisionalLoadForFrame call.
- UIProcess/API/C/WKPage.cpp:
(WKPageLoadHTMLString): Remove whitespace.
(WKPageLoadAlternateHTMLString):
- UIProcess/API/C/WKPage.h:
Add function to load a string as "alternate", meant for use as error pages.
- UIProcess/WebFrameProxy.h:
(WebKit::WebFrameProxy::setUnreachableURL):
(WebKit::WebFrameProxy::unreachableURL):
Add setter/getter for the unreachableURL.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::loadAlternateHTMLString):
Plumb through the call to loadAlternateHTMLString to the WebProcess
and set the main frame's unreachableURL. This does nothing if no pages
have ever been loaded in this page.
(WebKit::WebPageProxy::didStartProvisionalLoadForFrame):
If this is not a provisional load of substitute data for an unreachableURL
(e.g. someone who called WKPageLoadAlternateHTMLString), reset the
frame's unreachableURL.
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
Update function signatures.
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
Pass whether or not this is a load of SubstituteData for an unreachableURL
to the UIProcess.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::loadData):
(WebKit::WebPage::loadAlternateHTMLString):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
Plumb through the loading of the alternate HTML string.
- 15:29 Changeset [70096] by
-
2010-10-19 Eric Seidel <eric@webkit.org>
Unreviewed.
commit-queue gets stuck when release-patch returns 404
https://bugs.webkit.org/show_bug.cgi?id=47935
Turns out ClientForm gets upset if passed an int() instead of a string type.
Yay for untestable code.
- Scripts/webkitpy/common/net/statusserver.py:
- 15:28 Changeset [70095] by
-
Reviewed by Anders Carlsson.
https://bugs.webkit.org/show_bug.cgi?id=47933
<rdar://problem/8494337> navigator.language doesn't work in WebKit2
- 15:16 Changeset [70094] by
-
2010-10-19 James Simonsen <simonjam@chromium.org>
Reviewed by Adam Barth.
Add "in select" insertion mode to parser.
This was added to the spec in:
http://html5.org/tools/web-apps-tracker?from=5520&to=5522
And as a result of:
http://www.w3.org/Bugs/Public/show_bug.cgi?id=10314
No new tests. Open to ideas.
- html/parser/HTMLElementStack.cpp: Added "in select" mode. (WebCore::HTMLNames::isSelectScopeMarker): Ditto. (WebCore::HTMLElementStack::inSelectScope): Ditto.
- html/parser/HTMLElementStack.h: Ditto.
- html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTag): Use "in select" instead of "in table." (WebCore::HTMLTreeBuilder::processEndTag): Ditto.
- 15:10 Changeset [70093] by
-
2010-10-19 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Nate Chapin.
Fix multiple index support in IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=47919
Modify an existing test to verify behavior and add another test for
something I thought might have been related (but wasn't, but it still
seems like a good test).
- storage/indexeddb/index-basics-expected.txt:
- storage/indexeddb/index-basics.html:
- storage/indexeddb/queued-commands-expected.txt: Added.
- storage/indexeddb/queued-commands.html: Added.
2010-10-19 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Nate Chapin.
Fix multiple index support in IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=47919
Fix 2 bugs that caused the IndexData of all but the last index to be
properly updated:
- The objectStoreDataId is NOT unique if there are multiple indexes. So remove the constraint.
- Do not delete all existing entries with that objectStoreDataId before adding an entry for each index. Only do it once at the beginning.
Test: storage/indexeddb/queued-commands.html
+ index-basics.html modified
- storage/IDBFactoryBackendImpl.cpp: (WebCore::createTables):
- storage/IDBObjectStoreBackendImpl.cpp: (WebCore::deleteIndexData): (WebCore::putIndexData): (WebCore::IDBObjectStoreBackendImpl::putInternal):
- 15:06 Changeset [70092] by
-
2010-10-19 Eric Seidel <eric@webkit.org>
Unreviewed. Will get Adam's commentary after his meeting
for now this gets the commit-cluster back running.
commit-queue gets stuck when release-patch returns 404
https://bugs.webkit.org/show_bug.cgi?id=47935
I taught NetworkTransaction the basics of 404 handling.
We'll want to go back and teach it how to handle urllib2 404's too
and then deploy it to the places that want it.
- QueueStatusServer/handlers/releasepatch.py:
- Scripts/webkitpy/common/net/buildbot.py:
- Scripts/webkitpy/common/net/networktransaction.py:
- Scripts/webkitpy/common/net/statusserver.py:
- 14:58 Changeset [70091] by
-
2010-10-19 Ryuan Choi <ryuan.choi@samsung.com>
Reviewed by Eric Seidel.
[EFL] Add setting api for disabling auto resize window
https://bugs.webkit.org/show_bug.cgi?id=47787
- WebCoreSupport/ChromeClientEfl.cpp: (WebCore::ChromeClientEfl::setWindowRect): Return when auto_resize_window was disabled.
- ewk/ewk_view.cpp: (_ewk_view_priv_new): (ewk_view_setting_enable_auto_resize_window_get): Added. (ewk_view_setting_enable_auto_resize_window_set): Added.
- ewk/ewk_view.h:
- 14:42 Changeset [70090] by
-
2010-10-19 Csaba Osztrogonác <ossy@webkit.org>
Reviewed by Geoffrey Garen.
BytecodeGenerator::m_lastOpcodePosition must be initialized in all constructors
https://bugs.webkit.org/show_bug.cgi?id=47920
- bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::BytecodeGenerator): Add missing member initialization.
- 14:38 Changeset [70089] by
-
2010-10-19 Martin Robinson <mrobinson@igalia.com>
Fix the GTK+ build after r70072. The logic looks incorrect, but
this fix tries to preserves it, even so.
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (baselinePositionForAccessibilityRenderObject): (getAttributeSetForAccessibilityObject):
- 14:19 Changeset [70088] by
-
2010-10-19 Eric Seidel <eric@webkit.org>
Unreviewed. Fixing typos in my previous commit.
Make patch release explicit and not a magic part of "retry" status
https://bugs.webkit.org/show_bug.cgi?id=47909
All of these typos again due to our inability to unit
test much of this code. I added one unit test where
possible. activeworkitems_unittest.py will be in a separate patch.
- QueueStatusServer/handlers/releasepatch.py:
- QueueStatusServer/main.py:
- QueueStatusServer/model/activeworkitems.py:
- QueueStatusServer/model/workitems.py:
- QueueStatusServer/model/workitems_unittest.py:
- QueueStatusServer/templates/releasepatch.html:
- Scripts/webkitpy/common/net/statusserver.py:
- 14:18 Changeset [70087] by
-
2010-10-19 James Robinson <jamesr@chromium.org>
Update chromium expectations.
- platform/chromium/drt_expectations.txt:
- platform/chromium/test_expectations.txt:
- 14:14 Changeset [70086] by
-
2010-10-19 Antonio Gomes <agomes@rim.com>
Unreviewed complementary fix to r70058 (Part III).
Skipping fast/dom/nodesFromRect-links-and-text.html instead of fast/dom/nodesFromRect-links-and-text-expected.html.
- platform/gtk/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- 14:11 Changeset [70085] by
-
Stop waiting for sync replies if the connection is closed
https://bugs.webkit.org/show_bug.cgi?id=47930
Reviewed by Adam Roben.
- Platform/CoreIPC/Connection.cpp:
(CoreIPC::Connection::Connection):
Initialize m_shouldWaitForSyncReplies to true.
(CoreIPC::Connection::sendSyncMessage):
Don't attempt to send a message if m_shouldWaitForSyncReplies is false.
(CoreIPC::Connection::waitForSyncReply):
Return if m_shouldWaitForSyncReplies was set to false.
(CoreIPC::Connection::connectionDidClose):
Set m_shouldWaitForSyncReplies to true and signal the semaphore.
- Platform/CoreIPC/Connection.h:
- 14:11 Changeset [70084] by
-
Windows: Implement 'preload=none'
https://bugs.webkit.org/show_bug.cgi?id=47317
<rdar://problem/7718442>
Reviewed by Eric Carlson.
WebCore:
Implement the 'preload=none' identically to the mac implementation. Add three new
ivars: m_preload, m_delayLoad and m_movieURL; and override the MediaPlayerPrivate
functions: prepareToPlay() and setPreload().
- platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::MediaPlayerPrivateQuickTimeVisualContext):
Initialize new ivars m_delayLoad and m_preload.
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::resumeLoad): Added; new.
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::load): Split contents between
load and loadInternal.
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::loadInternal): Added; new.
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::prepareToPlay): Added; overrides MediaPlayerPrivate.
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::setPreload): Added; overrides MediaPlayerPrivate.
- platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.h:
LayoutTests:
Do not skip the media/video-preload.html test on windows any longer.
- platform/win/Skipped:
- 14:03 Changeset [70083] by
-
Upstream support of KeyCodes for iOS
https://bugs.webkit.org/show_bug.cgi?id=47857
Reviewed by Alexey Proskuryakov.
- platform/cocoa/KeyEventCocoa.mm:
(WebCore::windowsKeyCodeForCharCode): Added special handling of keyCodes for iOS.
- 13:59 Changeset [70082] by
-
2010-10-19 Zhenyao Mo <zmo@google.com>
Unreviewed, remove a passing webgl test from test_expectations.txt.
- platform/chromium/test_expectations.txt:
- 13:54 Changeset [70081] by
-
2010-10-19 Tony Chang <tony@chromium.org>
Reviewed by Kent Tamura.
[chromium] Use webkit's TestNetscapePlugIn in DRT mac
https://bugs.webkit.org/show_bug.cgi?id=47850
- platform/chromium/drt_expectations.txt: Update passing/failing test
list. More new passing tests than new failing tests.
2010-10-19 Tony Chang <tony@chromium.org>
Reviewed by Kent Tamura.
[chromium] Use webkit's TestNetscapePlugIn in DRT mac
https://bugs.webkit.org/show_bug.cgi?id=47850
- WebKit.gyp: Copy WebKitTestPlugIn into plugins and add
GCC_SYMBOLS_PRIVATE_EXTERN: NO to export the symbols.
2010-10-19 Tony Chang <tony@chromium.org>
Reviewed by Kent Tamura.
[chromium] Use webkit's TestNetscapePlugIn in DRT mac
https://bugs.webkit.org/show_bug.cgi?id=47850
- DumpRenderTree/chromium/TestNetscapePlugIn/Info.plist: Added. Forked
because we're going to name our plugin WebKitTestNetscapePlugIn
temporarily until the chromium forked plugin goes away.
- 13:47 Changeset [70080] by
-
2010-10-19 Antonio Gomes <agomes@rim.com>
Unreviewed complementary fix to r70058 (Part II).
Skipping the test on Gtk, Qt and Windows, because they do not implement LayoutTestController::nodesFromRect.
- platform/gtk/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- 13:44 Changeset [70079] by
-
2010-10-19 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
cr-mac bubble has caused status bubbles to wrap
https://bugs.webkit.org/show_bug.cgi?id=47928
We now have too many EWSes to fit in the bugs.webkit.org
status-bubble iframe when more than a couple EWS builds are pending.
To fix this I've reduced the space taken up by queue position,
and also moved cr-mac to the end of the list (since it's going to be
triple-digits for a while).
- QueueStatusServer/model/queues.py:
- QueueStatusServer/templates/statusbubble.html:
- 13:39 Changeset [70078] by
-
2010-10-19 Antonio Gomes <agomes@rim.com>
Unreviewed complementary fix to r70058.
- fast/dom/nodesFromRect-links-and-text-expected.txt: Renamed from LayoutTests/fast/dom/nodesFromRect-links-and-text-expected.html.
- 13:34 Changeset [70077] by
-
2010-10-19 Joseph Pecoraro <joepeck@webkit.org>
Reviewed by David Kilzer.
iOS: ASSERT in Cache::adjustSize running layout tests
https://bugs.webkit.org/show_bug.cgi?id=47873
Inside Cache::pruneDeadResources we loop over the LRU lists and make resources purgeable
with Cache::makeResourcePurgeable(). This wasn't taking into account whether the resource
was already purgeable or not, and the makeResourcePurgeable call was always calling
adjustSize(). Now we make sure makeResourcePurgable only adjusts the size of the Cache's
dead sizes when it first marks the resource purgeable. Likewise, if a resource is marked
as purgeable and then evicted, we should not adjust the size again.
The balancing call is when we have a resource that has been marked as purgeable and we
successfully mark it as no longer purgeable in Cache::resourceForURL.
No test added because this requires testing purgeable memory.
- loader/Cache.cpp: (WebCore::Cache::makeResourcePurgeable): (WebCore::Cache::evict):
- 12:43 Changeset [70076] by
-
2010-10-19 Kwang Yul Seo <skyul@company100.net>
Reviewed by David Kilzer.
RVCT fails to compile DateMath.cpp due to overloaded function pow
https://bugs.webkit.org/show_bug.cgi?id=47844
Choose std::pow(double, double) among multiple overloaded pow functions
to fix build for RVCT.
- wtf/DateMath.cpp: (WTF::parseES5DateFromNullTerminatedCharacters):
- 12:38 Changeset [70075] by
-
2010-10-19 Vangelis Kokkevis <vangelis@chromium.org>
Reviewed by Kenneth Russell.
[chromium] Disable mipmapping for ImageLayer's to prevent memory use and
performance regression.
https://bugs.webkit.org/show_bug.cgi?id=47913
This patch is a straight revert of the patch committed with issue 46493
- platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::SharedValues::SharedValues): (WebCore::ContentLayerChromium::updateTextureRect):
- platform/graphics/chromium/ContentLayerChromium.h: (WebCore::ContentLayerChromium::SharedValues::initialized):
- platform/graphics/chromium/ImageLayerChromium.cpp: (WebCore::ImageLayerChromium::updateContents):
- 12:23 Changeset [70074] by
-
2010-10-19 Patrick Gansterer <paroga@webkit.org>
Reviewed by David Kilzer.
Use UChar instead of wchar_t in UnicodeWinCE
https://bugs.webkit.org/show_bug.cgi?id=47904
Make UnicodeWinCE more portable, so we can use it for other ports too.
- wtf/unicode/wince/UnicodeWinCE.cpp: (WTF::Unicode::toLower): (WTF::Unicode::toUpper): (WTF::Unicode::foldCase): (WTF::Unicode::isPrintableChar): (WTF::Unicode::isSpace): (WTF::Unicode::isLetter): (WTF::Unicode::isUpper): (WTF::Unicode::isLower): (WTF::Unicode::isDigit): (WTF::Unicode::isPunct): (WTF::Unicode::isAlphanumeric): (WTF::Unicode::toTitleCase): (WTF::Unicode::mirroredChar): (WTF::Unicode::digitValue):
- wtf/unicode/wince/UnicodeWinCE.h: (WTF::Unicode::isSeparatorSpace): (WTF::Unicode::isHighSurrogate): (WTF::Unicode::isLowSurrogate): (WTF::Unicode::umemcasecmp): (WTF::Unicode::surrogateToUcs4):
- 12:16 Changeset [70073] by
-
2010-10-18 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
gl-teximage.html fails on chromium webkit mac bot
https://bugs.webkit.org/show_bug.cgi?id=47034
- platform/graphics/GraphicsContext3D.cpp: Deal with endians in 16 bit image data. (WebCore::convertColor16LittleTo8): (WebCore::convertColor16BigTo8): (WebCore::doPacking):
- platform/graphics/GraphicsContext3D.h: Ditto.
- platform/graphics/cg/GraphicsContext3DCG.cpp: Ditto. (WebCore::GraphicsContext3D::getImageData):
- 11:38 Changeset [70072] by
-
https://bugs.webkit.org/show_bug.cgi?id=47841
Reviewed by Dan Bernstein.
Rework baselinePosition and lineHeight to be writing-mode-aware. There's a lot of refactoring here to clean up
the method parameters to be more readable and to simplify the subclassing of the various methods in order to
keep the horizontal/vertical querying to a minimum.
- WebCore.xcodeproj/project.pbxproj:
- mathml/RenderMathMLFraction.cpp:
(WebCore::RenderMathMLFraction::baselinePosition):
- mathml/RenderMathMLFraction.h:
- mathml/RenderMathMLOperator.cpp:
(WebCore::RenderMathMLOperator::baselinePosition):
- mathml/RenderMathMLOperator.h:
- mathml/RenderMathMLRow.cpp:
(WebCore::RenderMathMLRow::baselinePosition):
- mathml/RenderMathMLRow.h:
- mathml/RenderMathMLSubSup.cpp:
(WebCore::RenderMathMLSubSup::baselinePosition):
- mathml/RenderMathMLSubSup.h:
- mathml/RenderMathMLUnderOver.cpp:
(WebCore::RenderMathMLUnderOver::layout):
(WebCore::RenderMathMLUnderOver::baselinePosition):
- mathml/RenderMathMLUnderOver.h:
- rendering/InlineBox.h:
(WebCore::InlineBox::baselinePosition):
(WebCore::InlineBox::lineHeight):
- rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::adjustMaxAscentAndDescent):
(WebCore::InlineFlowBox::computeLogicalBoxHeights):
(WebCore::InlineFlowBox::placeBoxesInBlockDirection):
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::baselinePosition):
(WebCore::InlineTextBox::lineHeight):
- rendering/InlineTextBox.h:
- rendering/RenderBR.cpp:
(WebCore::RenderBR::lineHeight):
- rendering/RenderBR.h:
(WebCore::toRenderBR):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::lineHeight):
(WebCore::RenderBlock::baselinePosition):
(WebCore::RenderBlock::firstLineBoxBaseline):
(WebCore::RenderBlock::lastLineBoxBaseline):
(WebCore::RenderBlock::localCaretRect):
- rendering/RenderBlock.h:
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutInlineChildren):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::lineHeight):
(WebCore::RenderBox::baselinePosition):
- rendering/RenderBox.h:
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::verticalPosition):
- rendering/RenderBoxModelObject.h:
- rendering/RenderFileUploadControl.cpp:
(WebCore::RenderFileUploadControl::paintObject):
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutHorizontalBox):
(WebCore::RenderFlexibleBox::layoutVerticalBox):
- rendering/RenderInline.cpp:
(WebCore::RenderInline::lineHeight):
(WebCore::RenderInline::baselinePosition):
- rendering/RenderInline.h:
- rendering/RenderListBox.cpp:
(WebCore::RenderListBox::baselinePosition):
- rendering/RenderListBox.h:
- rendering/RenderListMarker.cpp:
(WebCore::RenderListMarker::lineHeight):
(WebCore::RenderListMarker::baselinePosition):
- rendering/RenderListMarker.h:
- rendering/RenderObject.cpp:
- rendering/RenderObject.h:
- rendering/RenderReplaced.cpp:
- rendering/RenderReplaced.h:
- rendering/RenderSVGRoot.cpp:
- rendering/RenderSVGRoot.h:
- rendering/RenderSlider.cpp:
(WebCore::RenderSlider::baselinePosition):
- rendering/RenderSlider.h:
- rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::baselinePosition):
- rendering/RenderTableCell.h:
- rendering/RenderTableCol.h:
(WebCore::RenderTableCol::isTableCol):
- rendering/RenderTableRow.h:
- rendering/RenderTableSection.h:
- rendering/RenderText.cpp:
- rendering/RenderText.h:
- rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::computeLogicalHeight):
- rendering/RenderTextControlMultiLine.cpp:
(WebCore::RenderTextControlMultiLine::baselinePosition):
- rendering/RenderTextControlMultiLine.h:
- rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::createInnerTextStyle):
- rendering/RootInlineBox.h:
(WebCore::RootInlineBox::baselinePosition):
(WebCore::RootInlineBox::lineHeight):
- rendering/svg/SVGInlineTextBox.cpp:
(WebCore::SVGInlineTextBox::calculateBoundaries):
- 11:30 Changeset [70071] by
-
2010-10-19 Jia Pu <jpu@apple.com>
Reviewed by Adele Peterson.
Moving cursor back to autocorrected word in the same line shouldn't remove the underline
https://bugs.webkit.org/show_bug.cgi?id=47629
<rdar://problem/8546758>
- platform/mac-leopard/Skipped: New tests don't apply to this Mac OSX version.
- platform/mac-snowleopard/Skipped: Ditto.
- platform/mac-tiger/Skipped: Ditto.
- platform/mac-wk2/Skipped: Ditto.
- platform/mac/editing/spelling/autocorrection-delete-expected.checksum:
- platform/mac/editing/spelling/autocorrection-delete-expected.png:
- platform/mac/editing/spelling/click-autocorrected-word-expected.checksum: Added.
- platform/mac/editing/spelling/click-autocorrected-word-expected.png: Added.
- platform/mac/editing/spelling/click-autocorrected-word-expected.txt: Added.
- platform/mac/editing/spelling/click-autocorrected-word.html: Added.
- platform/mac/editing/spelling/delete-into-autocorrected-word-expected.checksum: Added.
- platform/mac/editing/spelling/delete-into-autocorrected-word-expected.png: Added.
- platform/mac/editing/spelling/delete-into-autocorrected-word-expected.txt: Added.
- platform/mac/editing/spelling/delete-into-autocorrected-word.html: Added.
- platform/mac/editing/spelling/delete-into-misspelled-word-expected.txt: Added.
- platform/mac/editing/spelling/delete-into-misspelled-word.html: Added.
- platform/mac/editing/spelling/forward-delete-into-autocorrected-word-expected.checksum: Added.
- platform/mac/editing/spelling/forward-delete-into-autocorrected-word-expected.png: Added.
- platform/mac/editing/spelling/forward-delete-into-autocorrected-word-expected.txt: Added.
- platform/mac/editing/spelling/forward-delete-into-autocorrected-word.html: Added.
- platform/mac/editing/spelling/move-cursor-around-misspelled-word-expected.txt: Added.
- platform/mac/editing/spelling/move-cursor-around-misspelled-word.html: Added.
- platform/mac/editing/spelling/move-cursor-to-autocorrected-word-expected.checksum: Added.
- platform/mac/editing/spelling/move-cursor-to-autocorrected-word-expected.png: Added.
- platform/mac/editing/spelling/move-cursor-to-autocorrected-word-expected.txt: Added.
- platform/mac/editing/spelling/move-cursor-to-autocorrected-word.html: Added.
- platform/mac/editing/spelling/move-cursor-to-beginning-of-autocorrected-word-expected.checksum: Added.
- platform/mac/editing/spelling/move-cursor-to-beginning-of-autocorrected-word-expected.png: Added.
- platform/mac/editing/spelling/move-cursor-to-beginning-of-autocorrected-word-expected.txt: Added.
- platform/mac/editing/spelling/move-cursor-to-beginning-of-autocorrected-word.html: Added.
2010-10-19 Jia Pu <jpu@apple.com>
Reviewed by Adele Peterson.
Moving cursor back to autocorrected word in the same line shouldn't remove the underline
https://bugs.webkit.org/show_bug.cgi?id=47629
<rdar://problem/8546758>
Tests: platform/mac/editing/spelling/click-autocorrected-word.html
platform/mac/editing/spelling/delete-into-autocorrected-word.html
platform/mac/editing/spelling/delete-into-misspelled-word.html
platform/mac/editing/spelling/forward-delete-into-autocorrected-word.html
platform/mac/editing/spelling/move-cursor-around-misspelled-word.html
platform/mac/editing/spelling/move-cursor-to-autocorrected-word.html
platform/mac/editing/spelling/move-cursor-to-beginning-of-autocorrected-word.html
- editing/Editor.cpp: (WebCore::Editor::respondToChangedSelection): Don't remove misspelling or autocorrection underlines when cursor is moved onto a word.
- 11:02 Changeset [70070] by
-
2010-10-19 Tony Chang <tony@chromium.org>
Unreviewed. Rolling chromium DEPS to 63057 to pick up mac plugin
loading in DRT.
- DEPS: bump chromium DEPS to 63057.
- 10:58 Changeset [70069] by
-
Reviewed by David Kilzer.
https://bugs.webkit.org/show_bug.cgi?id=47864
Convert WebNSUserDefaultsExtras.m to .mm
Also, fixed some issues in the process:
- removed locking, which was only necessary when this code was in Foundation;
- fixed notification center observer to actually work (previously, it picked up changes when application preferences changed, not when system language did);
- removed unused NSString category;
- updated style.
- Misc/WebNSUserDefaultsExtras.m: Removed.
- Misc/WebNSUserDefaultsExtras.mm: Copied from WebKit/mac/Misc/WebNSUserDefaultsExtras.m. (createHTTPStyleLanguageCode): (+[NSUserDefaults _webkit_defaultsDidChange]): (addLanguageChangeObserver): (+[NSUserDefaults _webkit_preferredLanguageCode]):
- 10:56 Changeset [70068] by
-
2010-10-19 Kenneth Russell <kbr@google.com>
Reviewed by David Levin.
chromium_gpu port of new-run-webkit-tests must search chromium-gpu directory for expectations
https://bugs.webkit.org/show_bug.cgi?id=47874
- Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
- Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
- 10:47 Changeset [70067] by
-
Windows build fix
- WebProcess/WebCoreSupport/win/WebErrorsWin.cpp:
(WebKit::interruptForPolicyChangeError): Add a missing comma.
- 10:15 Changeset [70066] by
-
Part 2 of:
Need to include WKErrorRef in the WKPageDidFail... functions
<rdar://problem/8564110>
https://bugs.webkit.org/show_bug.cgi?id=47871
Reviewed by Anders Carlsson.
- Shared/API/c/WKError.cpp:
(WKErrorCopyWKErrorDomain):
- Shared/API/c/WKError.h:
- Shared/WebError.cpp: Added.
(WebKit::WebError::webKitErrorDomain):
- Shared/WebError.h:
- WebKit2.pro:
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/WebCoreSupport/mac/WebErrorsMac.mm:
(+[NSError _webKitErrorWithCode:failingURL:]):
(registerErrors):
(WebKit::blockedError):
(WebKit::cannotShowURLError):
(WebKit::interruptForPolicyChangeError):
(WebKit::cannotShowMIMETypeError):
- WebProcess/WebCoreSupport/win/WebErrorsWin.cpp:
(WebKit::cancelledError):
(WebKit::blockedError):
(WebKit::cannotShowURLError):
(WebKit::interruptForPolicyChangeError):
- win/WebKit2.vcproj:
- 10:10 Changeset [70065] by
-
2010-10-19 Eric Carlson <eric.carlson@apple.com>
Not reviewed. Build fix.
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::selectNextSourceChild): Initialize variable to avoid Windows "potentially uninitialized local variable" warning.
- 09:43 Changeset [70064] by
-
2010-10-19 Tony Chang <tony@chromium.org>
Reviewed by Kent Tamura.
[chromium] DumpRenderTree shouldn't put '.' in include path
https://bugs.webkit.org/show_bug.cgi?id=47877
- WebKit.gyp: Replace '.' with <(chromium_src_dir) and add public
2010-10-19 Tony Chang <tony@chromium.org>
Reviewed by Kent Tamura.
[chromium] DumpRenderTree shouldn't put '.' in include path
https://bugs.webkit.org/show_bug.cgi?id=47877
Fix include paths.
- DumpRenderTree/chromium/AccessibilityController.cpp:
- DumpRenderTree/chromium/AccessibilityUIElement.cpp:
- DumpRenderTree/chromium/AccessibilityUIElement.h:
- DumpRenderTree/chromium/CppBoundClass.cpp:
- DumpRenderTree/chromium/CppVariant.cpp:
- DumpRenderTree/chromium/CppVariant.h:
- DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
- DumpRenderTree/chromium/DRTDevToolsAgent.h:
- DumpRenderTree/chromium/DRTDevToolsCallArgs.h:
- DumpRenderTree/chromium/DRTDevToolsClient.cpp:
- DumpRenderTree/chromium/DRTDevToolsClient.h:
- DumpRenderTree/chromium/EventSender.cpp:
- DumpRenderTree/chromium/EventSender.h:
- DumpRenderTree/chromium/LayoutTestController.cpp:
- DumpRenderTree/chromium/LayoutTestController.h:
- DumpRenderTree/chromium/MockSpellCheck.cpp:
- DumpRenderTree/chromium/NotificationPresenter.cpp:
- DumpRenderTree/chromium/NotificationPresenter.h:
- DumpRenderTree/chromium/PlainTextController.cpp:
- DumpRenderTree/chromium/Task.cpp:
- DumpRenderTree/chromium/TestNavigationController.h:
- DumpRenderTree/chromium/TestShell.cpp:
- DumpRenderTree/chromium/TestWebWorker.h:
- DumpRenderTree/chromium/TextInputController.cpp:
- DumpRenderTree/chromium/WebPreferences.cpp:
- DumpRenderTree/chromium/WebPreferences.h:
- DumpRenderTree/chromium/WebThemeEngineDRT.cpp:
- DumpRenderTree/chromium/WebThemeEngineDRT.h:
- DumpRenderTree/chromium/WebViewHost.cpp:
- DumpRenderTree/chromium/WebViewHost.h:
- 09:43 Changeset [70063] by
-
2010-10-19 Eric Carlson <eric.carlson@apple.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=46763
CRASH in WebCore::ThreadTimers::sharedTimerFiredInternal
Fix crashes caused by moving and deleting <source> element(s) of active media element.
Tests: media/video-source-moved.html
media/video-source-removed.html
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement): Add logging. Initialize selectNextSourceChild. (WebCore::HTMLMediaElement::~HTMLMediaElement): Ditto. (WebCore::HTMLMediaElement::insertedIntoDocument): Ditto. (WebCore::HTMLMediaElement::removedFromDocument): Ditto. (WebCore::HTMLMediaElement::scheduleLoad): Ditto. (WebCore::HTMLMediaElement::setNetworkState): Deal with m_currentSourceNode being null when the media engine signals a failure by skipping the error message and continuing as usual. (WebCore::HTMLMediaElement::setVolume): Fix logging typo. (WebCore::HTMLMediaElement::havePotentialSourceChild): Save and restore m_nextChildNodeToConsider around call to selectNextSourceChild because they are both significant. (WebCore::HTMLMediaElement::selectNextSourceChild): Use m_nextChildNodeToConsider to pick the first node to consider. Bail immediately if it signals that we have already processed every <source> node. Stach the node following the current source element in m_nextChildNodeToConsider so we can resume the search even if m_currentSourceNode is removed while it is being processed. (WebCore::HTMLMediaElement::sourceWasAdded): New, move logic from HTMLSourceElement::insertedIntoTree here and correct it to deal with a <source> node being inserted immediately after the current <source> node and a new <source> node being inserted at the end of the list after all candidates have failed. (WebCore::HTMLMediaElement::sourceWillBeRemoved): New, deal with current source node and next potential node being removed.
- html/HTMLMediaElement.h: (WebCore::HTMLMediaElement::sourceChildEndOfListValue): New, define sentinal value used to indicate that all nodes have been processed.
- html/HTMLSourceElement.cpp: (WebCore::HTMLSourceElement::HTMLSourceElement): Add logging. (WebCore::HTMLSourceElement::insertedIntoTree): Call mediaElement->sourceWasAdded instead of having logic here. (WebCore::HTMLSourceElement::willRemove): New, call mediaElement->sourceWillBeRemoved (WebCore::HTMLSourceElement::scheduleErrorEvent): Add logging. (WebCore::HTMLSourceElement::cancelPendingErrorEvent): Add logging.
- html/HTMLSourceElement.h:
2010-10-19 Eric Carlson <eric.carlson@apple.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=46763
CRASH in WebCore::ThreadTimers::sharedTimerFiredInternal
Test moving and deleting <source> element(s) of active <video>.
- media/media-file.js: (mimeTypeForExtension): New, added to make it possible to set 'type' attribute on <source>.
- media/video-source-moved-expected.txt: Added.
- media/video-source-moved.html: Added.
- media/video-source-removed-expected.txt: Added.
- media/video-source-removed.html: Added.
- 08:56 Changeset [70062] by
-
WebKit2: Need to include WKErrorRef in the WKPageDidFail... functions
<rdar://problem/8564110>
https://bugs.webkit.org/show_bug.cgi?id=47871
Reviewed by Dan Bernstein.
Give WebError a WebCore::ResourceError backing and start passing it over the wire
for failure cases. Also, fill out the WKError API to include domain, errorCode,
failingURL and localizedDescription.
- Shared/API/c/WKError.cpp:
(WKErrorCopyDomain):
(WKErrorGetErrorCode):
(WKErrorCopyFailingURL):
(WKErrorCopyLocalizedDescription):
- Shared/API/c/WKError.h:
- Shared/API/c/WKSharedAPICast.h:
(WebKit::toAPI):
- Shared/WebCoreArgumentCoders.h:
- Shared/WebError.h:
(WebKit::WebError::create):
(WebKit::WebError::domain):
(WebKit::WebError::errorCode):
(WebKit::WebError::failingURL):
(WebKit::WebError::localizedDescription):
(WebKit::WebError::platformError):
(WebKit::WebError::WebError):
- UIProcess/API/C/WKPage.h:
- UIProcess/API/qt/ClientImpl.cpp:
(qt_wk_didFailProvisionalLoadWithErrorForFrame):
(qt_wk_didFailLoadWithErrorForFrame):
- UIProcess/API/qt/ClientImpl.h:
- UIProcess/WebLoaderClient.cpp:
(WebKit::WebLoaderClient::didFailProvisionalLoadWithErrorForFrame):
(WebKit::WebLoaderClient::didFailLoadWithErrorForFrame):
- UIProcess/WebLoaderClient.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didFailProvisionalLoadForFrame):
(WebKit::WebPageProxy::didFailLoadForFrame):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- WebProcess/InjectedBundle/API/c/WKBundlePage.h:
- WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:
(WebKit::InjectedBundlePageLoaderClient::didFailProvisionalLoadWithErrorForFrame):
(WebKit::InjectedBundlePageLoaderClient::didFailLoadWithErrorForFrame):
- WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDidFailProvisionalLoad):
(WebKit::WebFrameLoaderClient::dispatchDidFailLoad):
WebKitTools: Need to include WKErrorRef in the WKPageDidFail... functions
https://bugs.webkit.org/show_bug.cgi?id=47871
Reviewed by Dan Bernstein.
Update tools for new parameter in failure callbacks.
- MiniBrowser/mac/BrowserWindowController.m:
(didFailProvisionalLoadWithErrorForFrame):
(didFailLoadWithErrorForFrame):
(-[BrowserWindowController updateProvisionalURLForFrame:]):
- TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
(TestWebKitAPI::didFailProvisionalLoadWithErrorForFrame):
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
(WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
- 08:31 Changeset [70061] by
-
2010-10-19 Christian Sejersen <christian.webkit@gmail.com>
Reviewed by Kenneth Rohde Christiansen.
Scratchbox has an old version of python as the default one, so
force it to use version 2.6.
https://bugs.webkit.org/show_bug.cgi?id=47895
- DerivedSources.pro:
- 08:28 Changeset [70060] by
-
2010-10-19 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Antti Koivisto.
[Qt] WebKit2 MacOS build fix
https://bugs.webkit.org/show_bug.cgi?id=47897
Qt WebKit2 MacOS build fix.
- bridge/npapi.h:
2010-10-19 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Antti Koivisto.
[Qt] WebKit2 MacOS build fix
https://bugs.webkit.org/show_bug.cgi?id=47897
Qt WebKit2 MacOS build fix.
- UIProcess/WebPageProxy.cpp:
- WebKit2.pri:
- WebKit2.pro:
2010-10-19 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Antti Koivisto.
[Qt] WebKit2 MacOS build fix
https://bugs.webkit.org/show_bug.cgi?id=47897
Qt WebKit2 MacOS build fix.
- WebKitTestRunner/PlatformWebView.h:
- WebKitTestRunner/qt/TestControllerQt.cpp:
- 08:21 Changeset [70059] by
-
2010-10-19 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
webkit-patch stats the filesystem too many times
https://bugs.webkit.org/show_bug.cgi?id=47883
This patch attempts to cache the list of changed files more agressively
and to use that list to compute the diff instead of stating the file
system again.
- Scripts/webkitpy/common/checkout/api.py:
- Scripts/webkitpy/common/checkout/scm.py:
- Scripts/webkitpy/tool/mocktool.py:
- Scripts/webkitpy/tool/steps/abstractstep.py:
- Scripts/webkitpy/tool/steps/editchangelog.py:
- Scripts/webkitpy/tool/steps/preparechangelog.py:
- 08:12 Changeset [70058] by
-
2010-10-18 Antonio Gomes <agomes@rim.com>
Reviewed by Kenneth Rohde Christiansen.
Add a test to nodesFromRect involving links and text nodes
https://bugs.webkit.org/show_bug.cgi?id=47795
Similarly to bug 47766 (Enrich /fast/dom/nodesFromRect-basic.html test,
this patch continues to improve the test coverage for Document::nodesFromRect.
This time tests involving links and text nodes are being added this time. Basically
it performs various rect hit tests involving the positions of the elements.
- fast/dom/nodesFromRect-links-and-text-expected.html: Added.
- fast/dom/nodesFromRect-links-and-text.html: Added.
- 07:51 Changeset [70057] by
-
<http://webkit.org/b/47741> Make sort-Xcode-project-file a little more friendly
Reviewed by Darin Adler.
- Scripts/sort-Xcode-project-file:
- Don't print an error message about missing arguments when
-hhelp is used. - Allow Xcode project files to be specified as Project.xcodeproj instead of Project.xcodeproj/project.pbxproj.
- 07:37 Changeset [70056] by
-
2010-10-19 Philippe Normand <pnormand@igalia.com>
Reviewed by Xan Lopez.
[GTK] Soup cache code still has some warnings
https://bugs.webkit.org/show_bug.cgi?id=47733
Fixed some compilation warnings happening with gcc 4.4.5 on
64-bits architecture.
- platform/network/soup/cache/webkit/soup-cache.c: (webkit_soup_cache_entry_set_freshness): (close_ready_cb):
- 07:21 Changeset [70055] by
-
Merge 70054 - 2010-10-19 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: crash while trying to step over a function using inspector
https://bugs.webkit.org/show_bug.cgi?id=47902
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.reset): reset scripts panel to resumed state on navigation.
TBR=yurys@chromium.org
BUG=59622
- 07:12 Changeset [70054] by
-
2010-10-19 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: crash while trying to step over a function using inspector
https://bugs.webkit.org/show_bug.cgi?id=47902
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.reset): reset scripts panel to resumed state on navigation.
- 06:44 Changeset [70053] by
-
2010-10-19 Andreas Kling <kling@webkit.org>
Unreviewed, skip fast/canvas/canvas-getImageData-negative-source.html on Mac.
https://bugs.webkit.org/show_bug.cgi?id=47901
- platform/mac/Skipped:
- 05:52 Changeset [70052] by
-
Unreviewed, update the Qt test expectations after r70047.
Missing support for document.createTouch and document.createTouchList
https://bugs.webkit.org/show_bug.cgi?id=47676
- platform/qt/fast/dom/Window/window-properties-expected.txt:
Add the new APIs to the expected results.
- 05:47 Changeset [70051] by
-
2010-10-19 Ryuan Choi <ryuan.choi@samsung.com>
Unreviewed attempt to remove warning in EFL build.
Fix #if to #ifdef.
No new features, so no tests added.
- platform/efl/WidgetEfl.cpp: (WebCore::Widget::applyFallbackCursor):
- 05:46 Changeset [70050] by
-
2010-10-19 Andreas Kling <kling@webkit.org>
Reviewed by Tor Arne Vestbø.
[Qt] getImageData returns wrong data for non-0,0 source offset
https://bugs.webkit.org/show_bug.cgi?id=47898
Test: fast/canvas/canvas-getImageData-negative-source.html
- platform/graphics/qt/ImageBufferQt.cpp: (WebCore::getImageData): Add missing *4's to get correct pixel offset.
2010-10-19 Andreas Kling <kling@webkit.org>
Reviewed by Tor Arne Vestbø.
[Qt] getImageData returns wrong data for non-0,0 source offset
https://bugs.webkit.org/show_bug.cgi?id=47898
- fast/canvas/canvas-getImageData-negative-source-expected.txt: Added.
- fast/canvas/canvas-getImageData-negative-source.html: Added.
- fast/canvas/script-tests/canvas-getImageData-negative-source.js: Added.
- 05:44 Changeset [70049] by
-
2010-10-19 Andreas Kling <kling@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Correct initial state of ImageBuffer QPen
https://bugs.webkit.org/show_bug.cgi?id=47804
Have the QPen on ImageBuffers start in Qt::SvgMiterJoin mode.
- platform/graphics/qt/ImageBufferQt.cpp: (WebCore::ImageBufferData::ImageBufferData):
- 05:15 Changeset [70048] by
-
2010-10-19 Philippe Normand <pnormand@igalia.com>
Reviewed by Martin Robinson.
GStreamer PlatformVideoWindow needs an API to prepare the widget before applying the overlay
https://bugs.webkit.org/show_bug.cgi?id=46790
Simple API addition to PlatformVideoWindow to allow
implementations to optionally prepare their own PlatformWidget
before applying the GStreamer XOverlay to it. This will likely be
needed on Mac OSX only.
- platform/graphics/gstreamer/GStreamerGWorld.cpp: (WebCore::GStreamerGWorld::setWindowOverlay):
- platform/graphics/gstreamer/PlatformVideoWindow.h:
- platform/graphics/gstreamer/PlatformVideoWindowGtk.cpp: (PlatformVideoWindow::prepareForOverlay):
- platform/graphics/gstreamer/PlatformVideoWindowEfl.cpp: (PlatformVideoWindow::prepareForOverlay):
- 04:50 Changeset [70047] by
-
2010-10-19 Ben Murdoch <benm@google.com>
Reviewed by Steve Block.
Missing support for document.createTouch and document.createTouchList
https://bugs.webkit.org/show_bug.cgi?id=47676
Add tests to verify the presence of the APIs and that they work correctly.
- fast/events/touch/document-create-touch-expected.txt: Added.
- fast/events/touch/document-create-touch-list-expected.txt: Added.
- fast/events/touch/document-create-touch-list.html: Added.
- fast/events/touch/document-create-touch.html: Added.
- fast/events/touch/script-tests/document-create-touch-list.js: Added.
- fast/events/touch/script-tests/document-create-touch.js: Added.
2010-10-19 Ben Murdoch <benm@google.com>
Reviewed by Steve Block.
Missing support for document.createTouch and document.createTouchList
https://bugs.webkit.org/show_bug.cgi?id=47676
These APIs are used by many sites to detect support for touch events.
Implement the APIs according to the documentation at:
http://developer.apple.com/library/safari/#documentation/UserExperience/Reference/DocumentAdditionsReference/DocumentAdditions/DocumentAdditions.html
Tests: fast/events/touch/document-create-touch-list.html
fast/events/touch/document-create-touch.html
- bindings/js/JSBindingsAllInOne.cpp: Add new files to list.
- bindings/js/JSTouchCustom.cpp: Added. (WebCore::toJSNewlyCreated):
- bindings/js/JSTouchListCustom.cpp: Added. (WebCore::toJSNewlyCreated):
- bindings/scripts/CodeGeneratorJS.pm:
- dom/Document.cpp: (WebCore::Document::createTouch): (WebCore::Document::createTouchList):
- dom/Document.h:
- dom/Document.idl: Add createTouch and createTouchList functions.
- Android.jscbindings.mk: Update makefiles.
- CMakeLists.txt: Ditto.
- GNUmakefile.am: Ditto.
- WebCore.gypi: Ditto.
- WebCore.pro: Ditto.
- 03:38 Changeset [70046] by
-
2010-10-19 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: migrate from legacy Object.properties to Object.keys, remove dead code.
https://bugs.webkit.org/show_bug.cgi?id=47890
- inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype._reportCompletions):
- inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel):
- inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer.prototype._onGetResources):
- inspector/front-end/HAREntry.js: (WebInspector.HARLog.prototype.build):
- inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertyTreeElement.prototype.): (WebInspector.StylePropertyTreeElement.prototype):
- inspector/front-end/utilities.js:
- 03:35 Changeset [70045] by
-
2010-10-19 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: do not access ResourcePanel from resources directly.
https://bugs.webkit.org/show_bug.cgi?id=47892
- inspector/front-end/Resource.js: (WebInspector.Resource.prototype.set documentURL): (WebInspector.Resource.prototype.set startTime): (WebInspector.Resource.prototype.set responseReceivedTime): (WebInspector.Resource.prototype.set endTime): (WebInspector.Resource.prototype.set resourceSize): (WebInspector.Resource.prototype.set expectedContentLength): (WebInspector.Resource.prototype.set category): (WebInspector.Resource.prototype.set cached): (WebInspector.Resource.prototype.set mimeType): (WebInspector.Resource.prototype.get requestHeaders): (WebInspector.Resource.prototype.set requestHeaders): (WebInspector.Resource.prototype.get responseHeaders): (WebInspector.Resource.prototype.set responseHeaders):
- inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.addResource): (WebInspector.ResourcesPanel.prototype.refreshResource): (WebInspector.ResourcesPanel.prototype._recreateViewForResourceIfNeeded): (WebInspector.ResourcesPanel.prototype._resourceViewIsConsistentWithCategory): (WebInspector.ResourceGraph): (WebInspector.ResourceGraph.prototype.refresh):
- inspector/front-end/inspector.js: (WebInspector.updateResource):
- 03:34 Changeset [70044] by
-
[Qt] QtTestBrowser: Prevent calling load() directly from loadFinished() in robot mode.
https://bugs.webkit.org/show_bug.cgi?id=47809
Reviewed by Andreas Kling.
Connecting a call to load from the loadFinished signal can cause
re-entrance crashes in WebCore. This patch uses a timer to do so,
also giving some time to subsequent frames to finish loading.
- QtTestBrowser/urlloader.cpp:
(UrlLoader::UrlLoader):
(UrlLoader::loadNext):
(UrlLoader::checkIfFinished):
(UrlLoader::frameLoadStarted):
(UrlLoader::frameLoadFinished):
- QtTestBrowser/urlloader.h:
- 03:21 Changeset [70043] by
-
2010-10-19 Yuta Kitamura <yutak@chromium.org>
Reviewed by Pavel Feldman.
Make sure WebSocket resource has the url field when it is created.
Web Inspector: Uncaught TypeError when connection to WebSocket server is refused
https://bugs.webkit.org/show_bug.cgi?id=47891
- inspector/InspectorResource.cpp: (WebCore::InspectorResource::createWebSocket):
- 02:38 Changeset [70042] by
-
DOMStringList should return null if the index is out of range
https://bugs.webkit.org/show_bug.cgi?id=47829
BUG=59579
Reviewed by Darin Adler.
LayoutTests:
Add tests for out of range behavior here since IndexedDB is the only user
of DOMStringList.
- storage/indexeddb/database-basics-expected.txt:
- storage/indexeddb/database-basics.html:
- storage/indexeddb/objectstore-basics-expected.txt:
- storage/indexeddb/objectstore-basics.html:
WebCore:
When item() returns a null string, it needs to be passed to JS as
null. The indexed getter will then magically do the right thing.
So all that's left is having DOMStringList::item() return null when
the index is out of bounds.
- dom/DOMStringList.cpp:
(WebCore::DOMStringList::item):
- dom/DOMStringList.h:
- dom/DOMStringList.idl:
Merge 69983 - 2010-10-18 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Darin Adler.
DOMStringList should return null if the index is out of range
https://bugs.webkit.org/show_bug.cgi?id=47829
Add tests for out of range behavior here since IndexedDB is the only user
of DOMStringList.
- storage/indexeddb/database-basics-expected.txt:
- storage/indexeddb/database-basics.html:
- storage/indexeddb/objectstore-basics-expected.txt:
- storage/indexeddb/objectstore-basics.html:
2010-10-18 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Darin Adler.
DOMStringList should return null if the index is out of range
https://bugs.webkit.org/show_bug.cgi?id=47829
When item() returns a null string, it needs to be passed to JS as
null. The indexed getter will then magically do the right thing.
So all that's left is having DOMStringList::item() return null when
the index is out of bounds.
- dom/DOMStringList.cpp: (WebCore::DOMStringList::item):
- dom/DOMStringList.h:
- dom/DOMStringList.idl:
- 02:05 Changeset [70041] by
-
2010-10-19 Patrick Gansterer <paroga@webkit.org>
Reviewed by Andreas Kling.
Fix style of UnicodeWinCE
https://bugs.webkit.org/show_bug.cgi?id=47818
- wtf/unicode/wince/UnicodeWinCE.cpp: (WTF::Unicode::toLower): (WTF::Unicode::toUpper):
- wtf/unicode/wince/UnicodeWinCE.h:
- 01:57 Changeset [70040] by
-
2010-10-19 Hayato Ito <hayato@chromium.org>
Reviewed by Darin Adler.
Make CSS style selector non-recursive.
https://bugs.webkit.org/show_bug.cgi?id=43783
This change is one of the required changes to fix the following master bug:
https://bugs.webkit.org/show_bug.cgi?id=42806
To avoid recursion, we prepare a call stack and maintain a list of
function call state by ourselves and try matching iteratively.
- fast/css/long-css-selector-matches-expected.txt: Added.
- fast/css/long-css-selector-matches.html: Added.
2010-10-19 Hayato Ito <hayato@chromium.org>
Reviewed by Darin Adler.
Make CSS style selector non-recursive.
https://bugs.webkit.org/show_bug.cgi?id=43783
This change is one of the required changes to fix the following master bug:
https://bugs.webkit.org/show_bug.cgi?id=42806
To avoid recursion, we prepare a call stack and maintain a list of
function call state by ourselves and try matching iteratively.
Test: fast/css/long-css-selector-matches.html
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkSelector): (WebCore::CSSStyleSelector::checkSelector):
- css/CSSStyleSelector.h:
- 01:48 Changeset [70039] by
-
2010-10-19 Sergio Villar Senín <svillar@igalia.com>
Reviewed by Xan Lopez.
[GTK] http/history tests are failing
https://bugs.webkit.org/show_bug.cgi?id=36173
Removed skipped tests from http/history
- platform/gtk/Skipped:
2010-10-19 Sergio Villar Senín <svillar@igalia.com>
Reviewed by Xan Lopez.
[GTK] http/history tests are failing
https://bugs.webkit.org/show_bug.cgi?id=36173
Clear the history each time a test is run. Return the actual
history item count when calling
LayoutTestController::webHistoryItemCount
- DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::webHistoryItemCount):
- 01:30 Changeset [70038] by
-
2010-10-19 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r70034.
http://trac.webkit.org/changeset/70034
https://bugs.webkit.org/show_bug.cgi?id=47889
"Gustavo's bot is lame" (Requested by xan_ on #webkit).
- configure.ac:
2010-10-19 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r70034.
http://trac.webkit.org/changeset/70034
https://bugs.webkit.org/show_bug.cgi?id=47889
"Gustavo's bot is lame" (Requested by xan_ on #webkit).
- platform/network/soup/CookieJarSoup.cpp: (WebCore::defaultCookieJar): (WebCore::setCookies):
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandle::prepareForURL): (WebCore::restartedCallback): (WebCore::startHttp):
- platform/network/soup/ResourceRequestSoup.cpp: (WebCore::ResourceRequest::toSoupMessage): (WebCore::ResourceRequest::updateFromSoupMessage):
- 01:23 Changeset [70037] by
-
Merge 69954 - 2010-10-18 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: tab headers on resource panel are 1px off on Mac.
https://bugs.webkit.org/show_bug.cgi?id=47798
- inspector/front-end/inspector.css: (.tabbed-pane-header li):
TBR=pfeldman@chromium.org
BUG=59748
- 01:17 Changeset [70036] by
-
2010-10-19 Joone Hur <joone@kldp.org>
Reviewed by Martin Robinson.
[GTK] Needs fixing mistyped comments in the API documentation
https://bugs.webkit.org/show_bug.cgi?id=47656
Fixed mistyped comments in the API documenentation.
- webkit/webkitwebsettings.cpp: Fixed a mistyped comment in the the section block.
- webkit/webkitwebwindowfeatures.cpp: Fixed a mistyped comment in the section block.
- 00:58 Changeset [70035] by
-
2010-10-19 Prof. MAAD <himself@prof-maad.org>
Reviewed by Xan Lopez.
[GTK] Correct erroneous documentation for webkit_web_navigation_action_get_button()
https://bugs.webkit.org/show_bug.cgi?id=46723
- WebKit/gtk/webkit/webkitwebnavigationaction.cpp:
- 00:50 Changeset [70034] by
-
2010-10-19 Xan Lopez <xlopez@igalia.com>
Reviewed by Martin Robinson.
[GTK] Bump minimum requirement for libsoup to 2.30
https://bugs.webkit.org/show_bug.cgi?id=46176
Bump minimum libsoup to required version to 2.30.0.
- configure.ac:
WebCore:
2010-10-19 Xan Lopez <xlopez@igalia.com>
Reviewed by Martin Robinson.
[GTK] Bump minimum requirement for libsoup to 2.30
https://bugs.webkit.org/show_bug.cgi?id=46176
Bump minimum required libsoup version to 2.30.
- platform/network/soup/CookieJarSoup.cpp: (WebCore::defaultCookieJar): (WebCore::setCookies):
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandle::prepareForURL): (WebCore::restartedCallback): (WebCore::startHttp):
- platform/network/soup/ResourceRequestSoup.cpp: (WebCore::ResourceRequest::toSoupMessage): (WebCore::ResourceRequest::updateFromSoupMessage):
- 00:15 Changeset [70033] by
-
2010-10-19 Xan Lopez <xlopez@igalia.com>
Reviewed by Martin Robinson.
Fix distcheck, take 2.
- GNUmakefile.am: also move the generated CSS hash files to the build dir.
10/18/10:
- 23:54 Changeset [70032] by
-
2010-10-18 Ryosuke Niwa <rniwa@webkit.org>
Unreviewed.
Re-enabled editing/execCommand/remove-formatting.html and editing/execCommand/remove-formatting-2.html on Qt platforms.
- platform/qt/Skipped:
- 23:34 Changeset [70031] by
-
2010-10-18 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Kent Tamura.
dump-as-markup conversion: editing/execCommand/remove-formatting.html and remove-formatting-2.html
https://bugs.webkit.org/show_bug.cgi?id=47792
Converted editing/execCommand/remove-formatting.html and remove-formatting-2.html to dump-as-markup tests.
- editing/execCommand/remove-formatting-2-expected.txt: Added.
- editing/execCommand/remove-formatting-2.html:
- editing/execCommand/remove-formatting-expected.txt: Added.
- editing/execCommand/remove-formatting.html:
- platform/chromium-linux/editing/execCommand/remove-formatting-2-expected.checksum: Removed.
- platform/chromium-linux/editing/execCommand/remove-formatting-2-expected.png: Removed.
- platform/chromium-linux/editing/execCommand/remove-formatting-expected.checksum: Removed.
- platform/chromium-linux/editing/execCommand/remove-formatting-expected.png: Removed.
- platform/chromium-win/editing/execCommand/remove-formatting-2-expected.checksum: Removed.
- platform/chromium-win/editing/execCommand/remove-formatting-2-expected.png: Removed.
- platform/chromium-win/editing/execCommand/remove-formatting-2-expected.txt: Removed.
- platform/chromium-win/editing/execCommand/remove-formatting-expected.checksum: Removed.
- platform/chromium-win/editing/execCommand/remove-formatting-expected.png: Removed.
- platform/chromium-win/editing/execCommand/remove-formatting-expected.txt: Removed.
- platform/mac-leopard/editing/execCommand/remove-formatting-2-expected.checksum: Removed.
- platform/mac-leopard/editing/execCommand/remove-formatting-2-expected.png: Removed.
- platform/mac-leopard/editing/execCommand/remove-formatting-expected.checksum: Removed.
- platform/mac-leopard/editing/execCommand/remove-formatting-expected.png: Removed.
- platform/mac/editing/execCommand/remove-formatting-2-expected.checksum: Removed.
- platform/mac/editing/execCommand/remove-formatting-2-expected.png: Removed.
- platform/mac/editing/execCommand/remove-formatting-2-expected.txt: Removed.
- platform/mac/editing/execCommand/remove-formatting-expected.checksum: Removed.
- platform/mac/editing/execCommand/remove-formatting-expected.png: Removed.
- platform/mac/editing/execCommand/remove-formatting-expected.txt: Removed.
- platform/qt/editing/execCommand/remove-formatting-2-expected.txt: Removed.
- platform/qt/editing/execCommand/remove-formatting-expected.txt: Removed.
- 22:37 Changeset [70030] by
-
2010-10-18 Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] Export QWebPage::ViewportAttributes class.
https://bugs.webkit.org/show_bug.cgi?id=47845
- Api/qwebpage.h:
- symbian/eabi/QtWebKitu.def:
- 22:36 Changeset [70029] by
-
2010-10-18 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Add Chromium Mac EWS to the list of queues at queues.webkit.org
https://bugs.webkit.org/show_bug.cgi?id=47878
- QueueStatusServer/model/queues.py:
- 22:35 Changeset [70028] by
-
2010-10-18 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
queues.webkit.org/next_patch is always 404
https://bugs.webkit.org/show_bug.cgi?id=47881
With the addition of the Queue class, I changed most of the
code to lookup WorkItems using get_or_insert with a key_name
instead of WorkItems.all().filter(queue_name=).
Because the new get_or_insert code uses an explicit key_name
(which is obviously different from the previously autogenerated
ones), there were new WorkItem records created for each queue.
However, some parts of the code still use WorkItems.all().filter,
thus some parts were getting the new record and some parts the old record.
The same basic bug was occurring with ActiveWorkItems, because I
changed the key_name for that class as well.
To fix this I've moved more of the code over to using Queue.*work_items.
I've also enabled the datastore_admin (new in GAE 1.3.8) so that
we can go delete the old WorkItems records.
I also changed remote_api to use the new builtin: syntax (also added in GAE 1.3.8).
- QueueStatusServer/app.yaml:
- QueueStatusServer/handlers/queuestatus.py:
- QueueStatusServer/handlers/recentstatus.py:
- QueueStatusServer/handlers/updatestatus.py:
- QueueStatusServer/handlers/updateworkitems.py:
- 22:33 Changeset [70027] by
-
2010-10-18 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
Should not save state of a detached form control.
https://bugs.webkit.org/show_bug.cgi?id=47811
- fast/forms/state-save-of-detached-control-expected.txt: Added.
- fast/forms/state-save-of-detached-control.html: Added.
2010-10-18 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
Should not save state of a detached form control.
https://bugs.webkit.org/show_bug.cgi?id=47811
Test: fast/forms/state-save-of-detached-control.html
- html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElementWithState::shouldSaveAndRestoreFormControlState): If the node is detached, don't save the state.
- 21:55 Changeset [70026] by
-
2010-10-18 Xan Lopez <xlopez@igalia.com>
Reviewed by Martin Robinson.
Bump version numbers for 1.3.5 release.
- configure.ac:
WebCore:
2010-10-18 Xan Lopez <xlopez@igalia.com>
Reviewed by Martin Robinson.
- GNUmakefile.am: add missing files.
WebKit/gtk:
2010-10-18 Xan Lopez <xlopez@igalia.com>
Reviewed by Martin Robinson.
- NEWS: update for 1.3.5 release.
- docs/webkitgtk-sections.txt: add new APIs.
2010-10-18 Xan Lopez <xlopez@igalia.com>
Reviewed by Martin Robinson.
- GNUmakefile.am: add missing file.
- 21:48 Changeset [70025] by
-
2010-10-18 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Correct a bunch of typos in QueueStatusServer
https://bugs.webkit.org/show_bug.cgi?id=47880
These are all due to our complete lack of unit testing in QueueStatusServer.
I added a couple unit tests to cover a few of these fixes, but most of these
are still only caught by actually running the application.
- QueueStatusServer/handlers/nextpatch.py:
- QueueStatusServer/handlers/statusbubble.py:
- QueueStatusServer/handlers/statusbubble_unittest.py: Added.
- QueueStatusServer/handlers/updateworkitems.py:
- QueueStatusServer/model/attachment.py:
- QueueStatusServer/model/queuepropertymixin.py:
- QueueStatusServer/model/queuepropertymixin_unittest.py:
- QueueStatusServer/model/workitems.py:
- QueueStatusServer/model/workitems_unittest.py: Added.
- 21:25 Changeset [70024] by
-
2010-10-18 Adam Barth <abarth@webkit.org>
Disable this test because it's failing on the bots and the authors
aren't around to fix it.
- Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
- 21:11 Changeset [70023] by
-
2010-10-18 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
CC authors of flaky tests when the commit-queue hits a flaky test
https://bugs.webkit.org/show_bug.cgi?id=47872
- Scripts/webkitpy/common/checkout/api.py:
- Scripts/webkitpy/common/net/layouttestresults.py:
- Scripts/webkitpy/tool/commands/queues.py:
- Scripts/webkitpy/tool/commands/queues_unittest.py:
- Scripts/webkitpy/tool/mocktool.py:
- 21:05 Changeset [70022] by
-
2010-10-18 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Make it possible to run a chromium-mac-ews builder
https://bugs.webkit.org/show_bug.cgi?id=47876
Since we can't run Mac OS X in a VM, we need to only run committer patches.
There was a multiple inheritance problem which was holding this patch back,
but I decided to just ignore the problem and go with a functional hack for now.
- Scripts/webkitpy/tool/commands/earlywarningsystem.py:
- Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
- 20:22 Changeset [70021] by
-
2010-10-18 Kenneth Russell <kbr@google.com>
Reviewed by Tony Chang.
Regression in run_webkit_tests_unittest from r70017
https://bugs.webkit.org/show_bug.cgi?id=47875
- Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
- 19:44 Changeset [70020] by
-
2010-10-18 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Implement webkit-patch suggest-reviewers
https://bugs.webkit.org/show_bug.cgi?id=47866
- Scripts/webkitpy/common/checkout/api.py:
- The main logic. We look at the last five changes to each modified (non-ChangeLog) file and collect up the reviewers of those changes as well as the authors of those changes who are reviewers.
- Scripts/webkitpy/common/checkout/api_unittest.py:
- Test the logic with some fun mocks.
- Scripts/webkitpy/common/checkout/scm.py:
- Fix a bug when you have local git commits.
- Scripts/webkitpy/common/checkout/scm_unittest.py:
- Test that the bug is fixed.
- Scripts/webkitpy/tool/commands/queries.py:
- Add the query.
- Scripts/webkitpy/common/checkout/api.py:
- 19:37 Changeset [70019] by
-
2010-10-18 Kenneth Russell <kbr@google.com>
Reviewed by Eric Seidel.
new-run-webkit-tests produces corrupt PNG baselines on Windows
https://bugs.webkit.org/show_bug.cgi?id=47867
- Scripts/webkitpy/layout_tests/port/base.py:
- 19:33 Changeset [70018] by
-
2010-10-18 Oliver Hunt <oliver@apple.com>
Reviewed by Sam Weinig.
REGRESSION: Feedly extension crashes Webkit
https://bugs.webkit.org/show_bug.cgi?id=45811
Make test cover large number of properties/string pairs, at two offsets to get the
new allocation to occur at different locations.
- fast/dom/Window/window-postmessage-clone-expected.txt:
- fast/dom/Window/window-postmessage-clone.html:
2010-10-18 Oliver Hunt <oliver@apple.com>
Reviewed by Sam Weinig.
REGRESSION: Feedly extension crashes Webkit
https://bugs.webkit.org/show_bug.cgi?id=45811
The basic problem was the deserializer was holding a pointer into
the constant pool, but if you were sufficiently unlucky then the
constant pool would be moved while still relying on the pointer,
which leads to badness.
I looked at just making all the sites this could happen extract the
right string/jsstring before any possible allocations, but it seemed
too fragile so i've gone for a forwarding object as the solution.
- bindings/js/SerializedScriptValue.cpp: (WebCore::CloneDeserializer::CachedStringRef::CachedStringRef): (WebCore::CloneDeserializer::CachedStringRef::operator->): (WebCore::CloneDeserializer::readStringData): (WebCore::CloneDeserializer::readFile): (WebCore::CloneDeserializer::readTerminal): (WebCore::CloneDeserializer::deserialize):
- 19:32 Changeset [70017] by
-
2010-10-18 Kenneth Russell <kbr@google.com>
Reviewed by Eric Seidel.
new-run-webkit-tests produces corrupt PNG baselines on Windows
https://bugs.webkit.org/show_bug.cgi?id=47867
- Scripts/webkitpy/layout_tests/port/base.py:
- 19:13 Changeset [70016] by
-
2010-10-18 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Deploy Queue class in more places throughout QueueStatusServer
https://bugs.webkit.org/show_bug.cgi?id=47855
I also caught two typos from the previous change. Unfortunately
I don't yet know how to unittest request handlers yet.
- QueueStatusServer/handlers/dashboard.py:
- QueueStatusServer/handlers/statusbubble.py:
- QueueStatusServer/handlers/updateworkitems.py:
- QueueStatusServer/model/activeworkitems.py:
- QueueStatusServer/model/attachment.py:
- QueueStatusServer/model/queuepropertymixin.py: Added.
- QueueStatusServer/model/queuepropertymixin_unittest.py: Added.
- QueueStatusServer/model/queuestatus.py:
- QueueStatusServer/model/workitems.py:
- 18:59 Changeset [70015] by
-
2010-10-18 Chris Rogers <crogers@google.com>
Reviewed by Chris Fleizach.
Add AudioResampler files
https://bugs.webkit.org/show_bug.cgi?id=47623
No new tests since audio API is not yet implemented.
- platform/audio/AudioResampler.cpp: Added. (WebCore::AudioResampler::AudioResampler): (WebCore::AudioResampler::configureChannels): (WebCore::AudioResampler::process): (WebCore::AudioResampler::setRate): (WebCore::AudioResampler::reset):
- platform/audio/AudioResampler.h: Added. (WebCore::AudioResampler::~AudioResampler): (WebCore::AudioResampler::rate):
- 18:38 Changeset [70014] by
-
2010-10-18 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
scm.py should be able tell us what revisions made changes to a given file
https://bugs.webkit.org/show_bug.cgi?id=47863
Look again, your SCM.py can now log files.
- Scripts/webkitpy/common/checkout/scm.py:
- Scripts/webkitpy/common/checkout/scm_unittest.py:
- 18:02 Changeset [70013] by
-
2010-10-18 Dirk Pranke <dpranke@chromium.org>
Reviewed by Eric Siedel.
new-run-webkit-tests: clean up the options-parsing code in the port
classes.
This change modifies the Port interface to have a get_option() and
set_option_default() method for accessing the options argument
passed to the constructor. If the constructor is not passed an
options argument, we default to a MockOptions() argument from
mocktool, which has the same semantics we want.
Note that there is a disadvantage to port.get_option('foo') over
port._options.foo, which is that you lose some of the checking
for whether 'foo' is set (typos result in the default value, not
an exception being raised. This is desired in this case, since the
Port class is not allowed to assume that options does have any
particular values set, and so this change ensures that all of
the subclasses are following the same, intended, logic.
Arguably this is the wrong semantics to have, and the Port
classes should be able to assume a default set of
attributes/arguments, but that change will need to wait for a
different CL where we can modify new-run-webkit-tests to pull a
list of arguments from the port factory routines.
Also, add unit tests for webkitpy.tool.mocktool.MockOptions .
- Scripts/webkitpy/layout_tests/port/base.py:
- Scripts/webkitpy/layout_tests/port/base_unittest.py:
- Scripts/webkitpy/layout_tests/port/chromium.py:
- Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
- Scripts/webkitpy/layout_tests/port/chromium_linux.py:
- Scripts/webkitpy/layout_tests/port/chromium_mac.py:
- Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
- Scripts/webkitpy/layout_tests/port/chromium_win.py:
- Scripts/webkitpy/layout_tests/port/dryrun.py:
- Scripts/webkitpy/layout_tests/port/factory_unittest.py:
- Scripts/webkitpy/layout_tests/port/mac_unittest.py:
- Scripts/webkitpy/layout_tests/port/port_testcase.py:
- Scripts/webkitpy/layout_tests/port/test.py:
- Scripts/webkitpy/layout_tests/port/webkit.py:
- Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
- Scripts/webkitpy/tool/mocktool_unittest.py: Added.
- 17:40 Changeset [70012] by
-
2010-10-18 Dirk Pranke <dpranke@chromium.org>
Reviewed by Eric Seidel.
Re-submit a revised version of r69638 - enabling new-run-webkit-tests
under cygwin. The initial version had a bug in base:uri_to_test_name
that was causing tests to fail. This version corrects that bug, but
also makes the code safer by calling cygpath more reliably, and
leaving a long-running cygpath process open.
This patch also corrects a couple of minor bugs in http_lock_unittest,
chromium_unittest, and dedpulicate_tests_unittest that showed up
while testing this.
- Scripts/webkitpy/common/system/path.py:
- Scripts/webkitpy/common/system/path_unittest.py:
- Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
- Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
- Scripts/webkitpy/layout_tests/port/base.py:
- Scripts/webkitpy/layout_tests/port/base_unittest.py:
- Scripts/webkitpy/layout_tests/port/chromium.py:
- Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
- Scripts/webkitpy/layout_tests/port/http_lock_unittest.py:
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- 17:06 Changeset [70011] by
-
2010-10-18 James Robinson <jamesr@chromium.org>
Update chromium test expectations
- platform/chromium-linux/svg/custom/text-linking-expected.txt: Copied from LayoutTests/platform/chromium-win-xp/svg/custom/text-linking-expected.txt.
- platform/chromium/test_expectations.txt:
- 16:53 Changeset [70010] by
-
2010-10-18 Vangelis Kokkevis <vangelis@chromium.org>
Reviewed by James Robinson.
[chromium] Prevent the creation of very large textures for layers by switching
to "large layer" mode when a texture is larger than some fixed reasonable size
(set to 2000 pixels for now).
https://bugs.webkit.org/show_bug.cgi?id=47751
The code also changes the large layer logic to use the current scissor rect used
by the compositor instead of the visible rect to determine how to clip large layers.
This will provide additional texture savings. In addition, the various layer rects
have been converted to use integers instead of floats to preserve uniformity in the code.
Tests: Existing large layer layout tests including huge-layer and huge-layer-img
- platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::requiresClippedUpdateRect): (WebCore::ContentLayerChromium::calculateClippedUpdateRect):
- platform/graphics/chromium/LayerChromium.cpp: (WebCore::LayerChromium::getDrawRect):
- platform/graphics/chromium/LayerChromium.h:
- platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::drawLayers): (WebCore::LayerRendererChromium::drawLayersRecursive): (WebCore::LayerRendererChromium::scissorToRect):
- platform/graphics/chromium/LayerRendererChromium.h: (WebCore::LayerRendererChromium::currentScissorRect):
- 16:38 Changeset [70009] by
-
2010-10-18 James Robinson <jamesr@chromium.org>
Move chromium xp specific baselines to right place.
- platform/chromium-win-xp/svg/custom/text-linking-expected.checksum:
- platform/chromium-win-xp/svg/custom/text-linking-expected.png: Renamed from LayoutTests/platform/chromium-win/svg/custom/text-linking-expected.png.
- platform/chromium-win-xp/svg/custom/text-linking-expected.txt: Renamed from LayoutTests/platform/chromium-win/svg/custom/text-linking-expected.txt.
- platform/chromium-win/svg/custom/text-linking-expected.checksum: Removed.
- 16:28 Changeset [70008] by
-
2010-10-18 Oliver Hunt <oliver@apple.com>
Reviewed by Sam Weinig.
Strict mode: Functions created with the function constructor don't implement strict mode semantics
https://bugs.webkit.org/show_bug.cgi?id=47860
When creating the FunctionExecutable for a new function the function constructor
was always passing false for whether or not a function was strict, rather than
using the information from the freshly parsed function itself.
- runtime/Executable.cpp: (JSC::FunctionExecutable::fromGlobalCode):
2010-10-18 Oliver Hunt <oliver@apple.com>
Reviewed by Sam Weinig.
Strict mode: Functions created with the function constructor don't implement strict mode semantics
https://bugs.webkit.org/show_bug.cgi?id=47860
Test that the function constructor produces correct strict mode functions.
- fast/js/basic-strict-mode-expected.txt:
- fast/js/script-tests/basic-strict-mode.js:
- 16:21 Changeset [70007] by
-
Initialize the API client.
Reviewed by Sam Weinig.
- Shared/APIClient.h:
(WebKit::APIClient::APIClient):
- 16:08 Changeset [70006] by
-
2010-10-18 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Add Queue class and add minimal unittesting of QueueStatusServer code
https://bugs.webkit.org/show_bug.cgi?id=47847
- QueueStatusServer/handlers/dashboard.py:
- QueueStatusServer/handlers/queuestatus.py:
- QueueStatusServer/handlers/recentstatus.py:
- QueueStatusServer/handlers/statusbubble.py:
- QueueStatusServer/handlers/updateworkitems.py:
- QueueStatusServer/model/attachment.py:
- QueueStatusServer/model/queues.py:
- QueueStatusServer/model/queues_unittest.py: Added.
- QueueStatusServer/model/svnrevision.py:
- Scripts/test-webkitpy:
- Scripts/webkitpy/test/main.py:
- 15:44 Changeset [70005] by
-
2010-10-18 James Robinson <jamesr@chromium.org>
Mark flaky SVG tests as flaky in chromium test expectations.
- platform/chromium/test_expectations.txt:
- 15:40 Changeset [70004] by
-
WebKit2 should handle dismissing the Find overlay on mouse-down
https://bugs.webkit.org/show_bug.cgi?id=47854
Reviewed by John Sullivan.
- WebProcess/WebPage/FindPageOverlay.cpp:
(WebKit::FindPageOverlay::mouseEvent):
Dismiss the find UI on MouseDown.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::mouseEvent):
If there's a page overlay, let it have a go at the event.
- 15:29 Changeset [70003] by
-
2010-10-18 Jia Pu <jpu@apple.com>
Reviewed by Stephanie Lewis.
Correct the description of manual test: autocorrection-cancelled-by-typing-1.html
https://bugs.webkit.org/show_bug.cgi?id=47722
<rdar://problem/8556206>
- manual-tests/autocorrection/autocorrection-cancelled-by-typing-1.html: Update description to match the test content.
- 15:19 Changeset [70002] by
-
2010-10-18 Mihai Parparita <mihaip@chromium.org>
Group Chromium DRT media test failures and add media/video-src.html,
which became flaky around r68970.
- platform/chromium/drt_expectations.txt:
- 15:14 Changeset [70001] by
-
Fix clang build.
- UIProcess/API/mac/FindIndicatorWindow.mm:
(-[WebFindIndicatorWindowAnimation _initWithFindIndicatorWindow:WebKit::animationProgressCallback:WebKit::FindIndicatorWindow::animationDidEndCallback:WebKit::FindIndicatorWindow::]):
(WebKit::FindIndicatorWindow::setFindIndicator):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPopupMenuProxy.h:
- WebProcess/WebCoreSupport/WebPopupMenu.h:
- 15:13 Changeset [70000] by
-
70,000!
- 15:11 Changeset [69999] by
-
Fix Qt build.
- WebKit2.pro:
- 15:10 WebKit2 edited by
- (diff)
- 15:02 Changeset [69998] by
-
2010-10-18 Martin Robinson <mrobinson@igalia.com>
Build fix for newer versions of GTK+ 2.0. Instead of using GDK_DISPLAY()
use GDK_DRAWABLE_XDISPLAY(gdk_display_get_default()). GDK_DISPLAY() was
recently deprecated and the latter method has been available since GTK+
2.2.
- plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::updatePluginWidget): (WebCore::PluginView::paint): (WebCore::PluginView::initXEvent): (WebCore::PluginView::platformGetValue): (WebCore::getVisualAndColormap): (WebCore::PluginView::platformStart): (WebCore::PluginView::platformDestroy):
- 14:55 Changeset [69997] by
-
Don't try to change accelerated compositing mode if the web page is closed
https://bugs.webkit.org/show_bug.cgi?id=47852
Reviewed by Simon Fraser.
changeAcceleratedCompositingMode ends up sending a sync message to the UI process which is unnecessary if
the UI process is being torn down.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
(WebKit::WebPage::changeAcceleratedCompositingMode):
(WebKit::WebPage::close):
- WebProcess/WebPage/WebPage.h:
- 14:53 Changeset [69996] by
-
2010-10-18 Adrienne Walker <enne@google.com>
Reviewed by Kenneth Russell.
Update context attribute conformance test from updated Khronos source.
https://bugs.webkit.org/show_bug.cgi?id=47697
- fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias-expected.txt:
- fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias.html:
- platform/chromium/test_expectations.txt:
2010-10-18 Adrienne Walker <enne@google.com>
Reviewed by Kenneth Russell.
Turn off antialiasing when using Mesa during testing.
https://bugs.webkit.org/show_bug.cgi?id=47697
- src/WebGraphicsContext3DDefaultImpl.cpp: (WebKit::WebGraphicsContext3DDefaultImpl::validateAttributes):
- 14:44 Changeset [69995] by
-
Merge 69719 - 2010-10-13 Brett Wilson <brettw@chromium.org>
Reviewed by Darin Fisher.
Save and restore the GraphicsContext around setting the clip rect for
drawing text.
https://bugs.webkit.org/show_bug.cgi?id=47634
- src/WebFontImpl.cpp: (WebKit::WebFontImpl::drawText):
- 14:42 Changeset [69994] by
-
2010-10-18 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Adam Barth.
elementCannotHaveEndTag should be a member function of MarkupAccumulator
https://bugs.webkit.org/show_bug.cgi?id=47846
Moved elementCannotHaveEndTag into MarkupAccumulator.
No new tests are added since this is a cleanup.
- editing/MarkupAccumulator.cpp: (WebCore::MarkupAccumulator::elementCannotHaveEndTag): Added.
- editing/MarkupAccumulator.h: Added MarkupAccumulator::elementCannotHaveEndTag.
- editing/markup.cpp: Removed elementCannotHaveEndTag.
- editing/markup.h: Removed elementCannotHaveEndTag.
- 14:41 Changeset [69993] by
-
2010-10-18 James Robinson <jamesr@chromium.org>
Update the chromium DEPS from 62399 to 62813 to pick up skia fixes
- DEPS:
- 14:28 Changeset [69992] by
-
<rdar://problem/8036034>
WebKit2's WebProcess dies immediately on Mac due to DYLD_FRAMEWORK_PATH problem
Reviewed by Sam Weinig.
Pass the path to the WebKit2 framework along to the web process and don't rely on DYLD_FRAMEWORK_PATH being set.
- Shared/mac/CommandLineMac.cpp:
(WebKit::CommandLine::parse):
- UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::ProcessLauncher::launchProcess):
- mac/MainMac.cpp:
(main):
- 14:24 Changeset [69991] by
-
Need a WebKit2 equivalent of the WebKit1 WebUserContentURLPattern.
https://bugs.webkit.org/show_bug.cgi?id=47783
Reviewed by Sam Weinig.
- Shared/API/c/WKBase.h:
- Shared/API/c/WKSharedAPICast.h:
- Shared/API/c/WKUserContentURLPattern.cpp: Added.
(WKUserContentURLPatternGetTypeID):
(WKUserContentURLPatternCreate):
(WKUserContentURLPatternMatchesURL):
- Shared/API/c/WKUserContentURLPattern.h: Added.
- Shared/APIObject.h:
- Shared/UserMessageCoders.h:
Use the original pattern string to encode and decode a UserContentURLPattern.
(WebKit::UserMessageEncoder::baseEncode):
(WebKit::UserMessageDecoder::baseDecode):
- Shared/WebUserContentURLPattern.h: Added.
(WebKit::WebUserContentURLPattern::create):
(WebKit::WebUserContentURLPattern::matchesURL):
Use WebCore::UserContentURLPattern::matches.
(WebKit::WebUserContentURLPattern::patternString):
Expose the pattern string used to create the UserContentURLPattern for the purpose of
encoding and decoding.
(WebKit::WebUserContentURLPattern::WebUserContentURLPattern):
(WebKit::WebUserContentURLPattern::type):
- WebKit2.pro:
- WebKit2.xcodeproj/project.pbxproj:
- win/WebKit2.vcproj:
Add WKUserContentURLPattern.h/.cpp and WebUserContentURLPattern.h
- win/WebKit2Generated.make:
Copy over WKUsercontentURLPattern into the output directory.
- 14:15 Changeset [69990] by
-
2010-10-18 Johnny Ding <jnd@chromium.org>
Reviewed by Adam Barth.
Set the right referent sourceURL for the script with force user gesture.
https://bugs.webkit.org/show_bug.cgi?id=37138
Because empty sourceURL indicates running script with force user gesture,
make WebKit use document.url() as referent sourceURL (Since it uses blank
URL instead empty if the input URL is empty) if WebKit isn't running the
script from a hyper-link.
Test: fast/events/popup-blocked-from-window-open.html
- bindings/ScriptControllerBase.cpp: (WebCore::ScriptController::executeScript):
- bindings/js/ScriptController.cpp: (WebCore::ScriptController::executeScriptInWorld):
2010-10-18 Johnny Ding <jnd@chromium.org>
Reviewed by Adam Barth.
Set the right referent sourceURL for the script with force user gesture.
https://bugs.webkit.org/show_bug.cgi?id=37138
- fast/events/popup-blocked-from-window-open-expected.txt: Added.
- fast/events/popup-blocked-from-window-open.html: Added.
- 14:12 Changeset [69989] by
-
2010-10-18 James Robinson <jamesr@chromium.org>
Update chromium expectations and baselines.
- platform/chromium/test_expectations.txt:
- 12:59 Changeset [69988] by
-
- dom/Node.h: Fix ancient typo in just-modified comment.
- 12:52 Changeset [69987] by
-
2010-10-18 Darin Adler <darin@apple.com>
Reviewed by Alexey Proskuryakov.
Remove some functions from class Node and make a few others non-virtual
https://bugs.webkit.org/show_bug.cgi?id=47735
Refactoring. No new tests.
- bindings/js/JSNodeCustom.cpp: (WebCore::JSNode::markChildren): Added a FIXME about the use of the virtual ownerDocument function.
- dom/ContainerNode.cpp: (WebCore::ContainerNode::removeChildren): Removed the unused return value.
- dom/ContainerNode.h: Made insertBefore, replaceChild, removeChild, and appendChild non-virtual for clarity and performance. Made removeChildren non-virtual and removed its return value. Moved the inline Node functions that call through to ContainerNode into this file since the old way involved an extra level of inline function but otherwise had no advantages.
- dom/Element.h: Moved isMathMLElement here because there is no call site that needs to call it on a Node*. We can always move it back if we need to, but it's better to have less in the Node class.
- dom/Node.cpp: (WebCore::Node::insertBefore): Added an isContainerNode check so this can be non-virtual. There are very few callers who call this function on Node. If we want to optimize them further we can make the isContainerNode check inline in the future. (WebCore::Node::replaceChild): Ditto. (WebCore::Node::removeChild): Ditto. (WebCore::Node::appendChild): Ditto. (WebCore::Node::remove): Removed unneeded ref/unref because ContainerNode::removeChild already does this. (WebCore::Node::createRendererIfNeeded): Removed #if around call to childShouldCreateRenderer since it's needed even without SVG and XHTMLMP.
- dom/Node.h: Moved definitions of inline functions that depend on ContainerNode to the ContainerNode.h header. They already required inclusion of that header, so there is no functional change. Made insertBefore, replaceChild, removeChild, and appendChild non-virtual. There are very few callers of these functions on this class. Moved isMathMLElement to Element. Added a FIXME about the name of eventAncestors. Fixed comment formatting. Eliminated unused isEditableBlock function. Moved the body of the enclosingInlineElement function to the editing file that was the only call site. Removed the previousEditable and nextEditable functions, incorporating their bodies into the one place they were called. Took the childShouldCreateRenderer function out of #if since it's now used by the implementation of the <noscript> element.
- dom/Position.cpp: (WebCore::nextRenderedEditable): Rewrote the function to use nextLeafNode instead of nextEditable. (WebCore::previousRenderedEditable): Rewrote the function to use previousLeafNode instead of previousEditable.
- editing/ReplaceSelectionCommand.cpp: (WebCore::enclosingInline): Moved function here from the Node class. Also fixed an incorrect cast this function did, which assumed the function result was always an element, which the function does not guarantee. (WebCore::ReplaceSelectionCommand::doApply): Call the function above.
- history/HistoryItem.cpp: Added include of MathExtras.h.
- 12:48 Changeset [69986] by
-
Fix build.
- DumpRenderTree/TestNetscapePlugIn/main.cpp:
(handleEventCarbon):
- 12:46 Changeset [69985] by
-
Fix build.
- WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
(WebKit::NetscapePlugin::platformHandleMouseEnterEvent):
(WebKit::NetscapePlugin::platformHandleMouseLeaveEvent):
(WebKit::NetscapePlugin::platformSetFocus):
- 12:33 Changeset [69984] by
-
2010-10-18 Yongjun Zhang <yongjun_zhang@apple.com>
Reviewed by Darin Adler.
Missing support for document.createEvent("OrientationEvent")
https://bugs.webkit.org/show_bug.cgi?id=32492
Add support for document.createEvent("OrientationEvent") to help unit testing of
onOrientationChange event.
- fast/dom/DeviceOrientation/create-event-onorientationchange-expected.txt: Added.
- fast/dom/DeviceOrientation/create-event-onorientationchange.html: Added.
- fast/dom/DeviceOrientation/script-tests/create-event-onorientationchange.js: Added.
2010-10-18 Yongjun Zhang <yongjun_zhang@apple.com>
Reviewed by Darin Adler.
Missing support for document.createEvent("OrientationEvent")
https://bugs.webkit.org/show_bug.cgi?id=32492
Add support for document.createEvent("OrientationEvent") to help unit testing of
onOrientationChange event.
Test: fast/dom/DeviceOrientation/create-event-onorientationchange.html
- dom/Document.cpp: (WebCore::Document::createEvent):
- 12:15 Changeset [69983] by
-
2010-10-18 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Darin Adler.
DOMStringList should return null if the index is out of range
https://bugs.webkit.org/show_bug.cgi?id=47829
Add tests for out of range behavior here since IndexedDB is the only user
of DOMStringList.
- storage/indexeddb/database-basics-expected.txt:
- storage/indexeddb/database-basics.html:
- storage/indexeddb/objectstore-basics-expected.txt:
- storage/indexeddb/objectstore-basics.html:
2010-10-18 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Darin Adler.
DOMStringList should return null if the index is out of range
https://bugs.webkit.org/show_bug.cgi?id=47829
When item() returns a null string, it needs to be passed to JS as
null. The indexed getter will then magically do the right thing.
So all that's left is having DOMStringList::item() return null when
the index is out of bounds.
- dom/DOMStringList.cpp: (WebCore::DOMStringList::item):
- dom/DOMStringList.h:
- dom/DOMStringList.idl:
- 12:14 Changeset [69982] by
-
2010-10-18 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Kent Tamura.
dump-as-markup conversion: editing/execCommand/4920742-1.html, 5049671.html, and 5573879.html
https://bugs.webkit.org/show_bug.cgi?id=47784
Converted editing/execCommand/4920742-1.html, 5049671.html, and 5573879.html to dump-as-markup tests.
- editing/execCommand/4920742-1-expected.txt: Added.
- editing/execCommand/4920742-1.html:
- editing/execCommand/5049671-expected.txt: Added.
- editing/execCommand/5049671.html:
- editing/execCommand/5573879-expected.txt: Added.
- editing/execCommand/5573879.html:
- platform/chromium-linux/editing/execCommand/4920742-1-expected.checksum: Removed.
- platform/chromium-linux/editing/execCommand/4920742-1-expected.png: Removed.
- platform/chromium-linux/editing/execCommand/5049671-expected.checksum: Removed.
- platform/chromium-linux/editing/execCommand/5049671-expected.png: Removed.
- platform/chromium-linux/editing/execCommand/5573879-expected.checksum: Removed.
- platform/chromium-linux/editing/execCommand/5573879-expected.png: Removed.
- platform/chromium-win/editing/execCommand/4920742-1-expected.checksum: Removed.
- platform/chromium-win/editing/execCommand/4920742-1-expected.png: Removed.
- platform/chromium-win/editing/execCommand/4920742-1-expected.txt: Removed.
- platform/chromium-win/editing/execCommand/5049671-expected.checksum: Removed.
- platform/chromium-win/editing/execCommand/5049671-expected.png: Removed.
- platform/chromium-win/editing/execCommand/5049671-expected.txt: Removed.
- platform/chromium-win/editing/execCommand/5573879-expected.checksum: Removed.
- platform/chromium-win/editing/execCommand/5573879-expected.png: Removed.
- platform/chromium-win/editing/execCommand/5573879-expected.txt: Removed.
- platform/gtk/editing/execCommand/4920742-1-expected.txt: Removed.
- platform/gtk/editing/execCommand/5049671-expected.txt: Removed.
- platform/gtk/editing/execCommand/5573879-expected.txt: Removed.
- platform/mac-leopard/editing/execCommand/4920742-1-expected.checksum: Removed.
- platform/mac-leopard/editing/execCommand/4920742-1-expected.png: Removed.
- platform/mac-leopard/editing/execCommand/5049671-expected.checksum: Removed.
- platform/mac-leopard/editing/execCommand/5049671-expected.png: Removed.
- platform/mac/editing/execCommand/4920742-1-expected.checksum: Removed.
- platform/mac/editing/execCommand/4920742-1-expected.png: Removed.
- platform/mac/editing/execCommand/4920742-1-expected.txt: Removed.
- platform/mac/editing/execCommand/5049671-expected.checksum: Removed.
- platform/mac/editing/execCommand/5049671-expected.png: Removed.
- platform/mac/editing/execCommand/5049671-expected.txt: Removed.
- platform/mac/editing/execCommand/5573879-expected.checksum: Removed.
- platform/mac/editing/execCommand/5573879-expected.png: Removed.
- platform/mac/editing/execCommand/5573879-expected.txt: Removed.
- platform/qt/editing/execCommand/4920742-1-expected.txt: Removed.
- platform/qt/editing/execCommand/5049671-expected.txt: Removed.
- 12:13 Changeset [69981] by
-
[Qt] Implement Accelerated Composition for NPAPI Plugins.
Reviewed by Ariya Hidayat.
https://bugs.webkit.org/show_bug.cgi?id=35524
- plugins/PluginView.h:
(WebCore::PluginView::platformLayer):
- plugins/qt/PluginViewQt.cpp:
(WebCore::PluginGraphicsLayerQt::PluginGraphicsLayerQt):
(WebCore::PluginGraphicsLayerQt::~PluginGraphicsLayerQt):
(WebCore::PluginGraphicsLayerQt::paint):
(WebCore::PluginView::updatePluginWidget):
(WebCore::PluginView::paint):
(WebCore::PluginView::invalidateRect):
(WebCore::PluginView::invalidateRegion):
(WebCore::PluginView::platformStart):
(WebCore::PluginView::platformLayer):
- 11:54 Changeset [69980] by
-
2010-10-18 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Kent Tamura.
dump-as-markup conversion: editing/execCommand/4786404-1.html, 4786404-2.html, 4920488.html
https://bugs.webkit.org/show_bug.cgi?id=47782
Converted editing/execCommand/4786404-1.html, 4786404-2.html, 4920488.html to dump-as-markup tests.
- editing/execCommand/4786404-1-expected.txt: Added.
- editing/execCommand/4786404-1.html:
- editing/execCommand/4786404-2-expected.txt: Added.
- editing/execCommand/4786404-2.html:
- editing/execCommand/4920488-expected.txt: Added.
- editing/execCommand/4920488.html:
- platform/chromium-linux/editing/execCommand/4786404-1-expected.checksum: Removed.
- platform/chromium-linux/editing/execCommand/4786404-1-expected.png: Removed.
- platform/chromium-linux/editing/execCommand/4786404-2-expected.checksum: Removed.
- platform/chromium-linux/editing/execCommand/4786404-2-expected.png: Removed.
- platform/chromium-linux/editing/execCommand/4920488-expected.checksum: Removed.
- platform/chromium-linux/editing/execCommand/4920488-expected.png: Removed.
- platform/chromium-win/editing/execCommand/4786404-1-expected.checksum: Removed.
- platform/chromium-win/editing/execCommand/4786404-1-expected.png: Removed.
- platform/chromium-win/editing/execCommand/4786404-1-expected.txt: Removed.
- platform/chromium-win/editing/execCommand/4786404-2-expected.checksum: Removed.
- platform/chromium-win/editing/execCommand/4786404-2-expected.png: Removed.
- platform/chromium-win/editing/execCommand/4786404-2-expected.txt: Removed.
- platform/chromium-win/editing/execCommand/4920488-expected.checksum: Removed.
- platform/chromium-win/editing/execCommand/4920488-expected.png: Removed.
- platform/chromium-win/editing/execCommand/4920488-expected.txt: Removed.
- platform/gtk/editing/execCommand/4786404-1-expected.txt: Removed.
- platform/gtk/editing/execCommand/4786404-2-expected.txt: Removed.
- platform/gtk/editing/execCommand/4920488-expected.txt: Removed.
- platform/mac-leopard/editing/execCommand/4786404-2-expected.checksum: Removed.
- platform/mac-leopard/editing/execCommand/4786404-2-expected.png: Removed.
- platform/mac-leopard/editing/execCommand/4920488-expected.checksum: Removed.
- platform/mac-leopard/editing/execCommand/4920488-expected.png: Removed.
- platform/mac/editing/execCommand/4786404-1-expected.checksum: Removed.
- platform/mac/editing/execCommand/4786404-1-expected.png: Removed.
- platform/mac/editing/execCommand/4786404-1-expected.txt: Removed.
- platform/mac/editing/execCommand/4786404-2-expected.checksum: Removed.
- platform/mac/editing/execCommand/4786404-2-expected.png: Removed.
- platform/mac/editing/execCommand/4786404-2-expected.txt: Removed.
- platform/mac/editing/execCommand/4920488-expected.checksum: Removed.
- platform/mac/editing/execCommand/4920488-expected.png: Removed.
- platform/mac/editing/execCommand/4920488-expected.txt: Removed.
- platform/qt/editing/execCommand/4786404-1-expected.txt: Removed.
- platform/qt/editing/execCommand/4786404-2-expected.txt: Removed.
- platform/qt/editing/execCommand/4920488-expected.txt: Removed.
- 11:54 Changeset [69979] by
-
2010-10-18 Stuart Morgan <stuartmorgan@chromium.org>
Reviewed by Eric Seidel.
Switch to using the new Carbon NPAPI event declarations, and remove
the old ones.
- bridge/npapi.h:
- plugins/mac/PluginViewMac.mm: (WebCore::PluginView::setFocus): (WebCore::PluginView::handleMouseEvent):
2010-10-18 Stuart Morgan <stuartmorgan@chromium.org>
Reviewed by Eric Seidel.
Switch to using the new Carbon NPAPI event declarations, and remove
the old ones.
- Plugins/WebNetscapePluginEventHandlerCarbon.mm: (WebNetscapePluginEventHandlerCarbon::mouseEntered): (WebNetscapePluginEventHandlerCarbon::mouseExited): (WebNetscapePluginEventHandlerCarbon::mouseMoved): (WebNetscapePluginEventHandlerCarbon::focusChanged):
2010-10-18 Stuart Morgan <stuartmorgan@chromium.org>
Reviewed by Eric Seidel.
Switch to using the new Carbon NPAPI event declarations, and remove
the old ones.
- DumpRenderTree/TestNetscapePlugIn/main.cpp: (handleEventCarbon):
- 11:46 Changeset [69978] by
-
Add matchCountDidChange callback
https://bugs.webkit.org/show_bug.cgi?id=47840
Reviewed by Darin Adler.
- UIProcess/API/C/WKPage.h:
Add matchCountDidChange WKPageFindClient callback.
- UIProcess/WebFindClient.cpp:
(WebKit::WebFindClient::matchCountDidChange):
Call the WKPageFindClient callback.
- UIProcess/WebPageProxy.messages.in:
Add MatchCountDidChange message.
- WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::countStringMatches):
Move code here from WebPage.
(WebKit::FindController::findString):
Send the MatchCountDidChange message.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::countStringMatches):
Move this code over to FindController.
- 11:32 Changeset [69977] by
-
2010-10-18 Oliver Hunt <oliver@apple.com>
Reviewed by Darin Adler.
Strict mode: |this| should be undefined if it is not explicitly provided
https://bugs.webkit.org/show_bug.cgi?id=47833
To make strict mode behave correctly we want to pass undefined instead of null
as the default this value. This has no impact on behaviour outside of strict
mode as both values are replaced with the global object if necessary.
- bytecompiler/NodesCodegen.cpp: (JSC::FunctionCallValueNode::emitBytecode): (JSC::FunctionCallResolveNode::emitBytecode): (JSC::CallFunctionCallDotNode::emitBytecode): (JSC::ApplyFunctionCallDotNode::emitBytecode):
2010-10-18 Oliver Hunt <oliver@apple.com>
Reviewed by Darin Adler.
Strict mode: |this| should be undefined if it is not explicitly provided
https://bugs.webkit.org/show_bug.cgi?id=47833
Add tests to ensure that |this| is undefined rather than null when it has
not been explicitly provided.
- fast/js/basic-strict-mode-expected.txt:
- fast/js/script-tests/basic-strict-mode.js:
- 11:17 Changeset [69976] by
-
2010-10-18 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: comment out resource manager instantiation on front-end side.
https://bugs.webkit.org/show_bug.cgi?id=47823
- inspector/front-end/inspector.js:
- 11:08 Changeset [69975] by
-
2010-10-18 Robert Hogan <robert@webkit.org>
Rubber-stamped by Csaba Osztrogonác.
Unskip:
http/tests/navigation/no-referrer-reset.html
http/tests/navigation/no-referrer-target-blank.html
These tests now pass.
- platform/qt/Skipped:
- 11:04 Changeset [69974] by
-
2010-10-18 Andrei Popescu <andreip@google.com>
Reviewed by Jeremy Orlow.
The description parameter of IDBFactory::open() should be mandatory.
https://bugs.webkit.org/show_bug.cgi?id=47835
- storage/indexeddb/basics-expected.txt:
- storage/indexeddb/basics.html:
2010-10-18 Andrei Popescu <andreip@google.com>
Reviewed by Jeremy Orlow.
The description parameter of IDBFactory::open() should be mandatory.
https://bugs.webkit.org/show_bug.cgi?id=47835
Makes the description parameter mandatory, as per the IndexedDatabase specification.
Modified existing tests to cover this change.
- storage/IDBDatabaseBackendImpl.cpp: (WebCore::extractMetaData): (WebCore::setMetaData): (WebCore::IDBDatabaseBackendImpl::IDBDatabaseBackendImpl):
- storage/IDBFactory.cpp: (WebCore::IDBFactory::open):
- storage/IDBFactory.h:
- storage/IDBFactory.idl:
- 11:02 Changeset [69973] by
-
Use nullptr instead of 0.
Reviewed by Darin Adler.
- UIProcess/API/mac/FindIndicatorWindow.mm:
(WebKit::FindIndicatorWindow::closeWindow):
- UIProcess/API/mac/WKView.mm:
(-[WKView renewGState]):
- WebProcess/Plugins/PluginProcessConnection.cpp:
(WebKit::PluginProcessConnection::removePluginProxy):
- 10:41 Changeset [69972] by
-
2010-10-18 Xiaomei Ji <xji@chromium.org>
Reviewed by David Levin.
Code cleanup: Move most function members in TextRunWorker from inlined.
https://bugs.webkit.org/show_bug.cgi?id=47732
No functionality change, so no tests added.
- platform/graphics/chromium/FontLinux.cpp: (WebCore::TextRunWalker::setWordSpacingAdjustment): (WebCore::TextRunWalker::setLetterSpacingAdjustment): (WebCore::TextRunWalker::setXOffsetToZero): (WebCore::TextRunWalker::rtl): (WebCore::TextRunWalker::glyphs): (WebCore::TextRunWalker::length): (WebCore::TextRunWalker::xPositions): (WebCore::TextRunWalker::advances): (WebCore::TextRunWalker::width): (WebCore::TextRunWalker::logClusters): (WebCore::TextRunWalker::numCodePoints): (WebCore::TextRunWalker::fontPlatformDataForScriptRun): (WebCore::TextRunWalker::isCodepointSpace): (WebCore::TextRunWalker::TextRunWalker): (WebCore::TextRunWalker::~TextRunWalker): (WebCore::TextRunWalker::isWordBreak): (WebCore::TextRunWalker::setPadding): (WebCore::TextRunWalker::reset): (WebCore::TextRunWalker::setBackwardsIteration): (WebCore::TextRunWalker::nextScriptRun): (WebCore::TextRunWalker::widthOfFullRun): (WebCore::TextRunWalker::getTextRun): (WebCore::TextRunWalker::getNormalizedTextRun): (WebCore::TextRunWalker::setupFontForScriptRun): (WebCore::TextRunWalker::allocHarfbuzzFont): (WebCore::TextRunWalker::deleteGlyphArrays): (WebCore::TextRunWalker::createGlyphArrays): (WebCore::TextRunWalker::resetGlyphArrays): (WebCore::TextRunWalker::shapeGlyphs): (WebCore::TextRunWalker::setGlyphXPositions): (WebCore::TextRunWalker::mirrorCharacters):
- 10:27 Changeset [69971] by
-
2010-10-18 No'am Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Andreas Kling.
[Qt] AC rendering bugs
There were a few missing connections in Qt AC between GraphicsLayer and plugins, like changing the plugin's geometry to the layer's
contentsRect, and making sure media layers handle ParentChange events and setContentsNeedsDisplay. Now media layers behave correctly.
No new tests. This is in preparation for fixing AC+plugins, which already has tests that don't work yet with Qt.
- platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::GraphicsLayerQtImpl::flushChanges): (WebCore::GraphicsLayerQt::setContentsNeedsDisplay):
- platform/graphics/qt/GraphicsLayerQt.h:
- 10:23 Changeset [69970] by
-
2010-10-18 Darin Adler <darin@apple.com>
Reviewed by Anders Carlsson.
Make a nullptr that works with OwnPtr and RefPtr
https://bugs.webkit.org/show_bug.cgi?id=47756
- JavaScriptCore.xcodeproj/project.pbxproj: Added NullPtr.h.
- wtf/NullPtr.h: Added.
- wtf/OwnArrayPtr.h: Add an overload of = taking nullptr.
- wtf/OwnPtr.h: Ditto.
- wtf/PassOwnArrayPtr.h: Ditto.
- wtf/PassOwnPtr.h: Ditto.
- wtf/PassRefPtr.h: Ditto.
- wtf/RefPtr.h: Ditto.
- wtf/RetainPtr.h: Ditto.
- 10:21 Changeset [69969] by
-
2010-10-18 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: disable private browsing for inspector
https://bugs.webkit.org/show_bug.cgi?id=47827
- WebCoreSupport/WebInspectorClient.mm: (-[WebInspectorWindowController init]):
2010-10-18 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: disable private browsing for inspector
https://bugs.webkit.org/show_bug.cgi?id=47827
- WebCoreSupport/WebInspectorClient.cpp: (WebInspectorClient::openInspectorFrontend):
- 10:08 Changeset [69968] by
-
2010-10-18 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Simon Fraser.
Web Inspector: [crash] when Inspector Open in CSSStyleSelector::loadPendingImages().
https://bugs.webkit.org/show_bug.cgi?id=46224
- CMakeLists.txt:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- inspector/InspectorClient.cpp: Added. (WebCore::InspectorClient::doDispatchMessageOnFrontendPage):
- inspector/InspectorClient.h: (WebCore::InspectorClient::InspectorClient):
2010-10-18 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Simon Fraser.
Web Inspector: [crash] when Inspector Open in CSSStyleSelector::loadPendingImages().
https://bugs.webkit.org/show_bug.cgi?id=46224
- WebCoreSupport/WebInspectorClientCF.cpp: (WebInspectorClient::sendMessageToFrontend):
2010-10-18 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Simon Fraser.
Web Inspector: [crash] when Inspector Open in CSSStyleSelector::loadPendingImages().
https://bugs.webkit.org/show_bug.cgi?id=46224
- WebCoreSupport/InspectorClientGtk.cpp: (WebKit::InspectorClient::sendMessageToFrontend):
2010-10-18 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Simon Fraser.
Web Inspector: [crash] when Inspector Open in CSSStyleSelector::loadPendingImages().
https://bugs.webkit.org/show_bug.cgi?id=46224
- WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorClientQt::sendMessageToFrontend):
- 10:07 Changeset [69967] by
-
2010-10-18 Alejandro G. Castro <alex@igalia.com>
Unreviewed, skip test failing in the bots, bug opened to check the
problem: https://bugs.webkit.org/show_bug.cgi?id=47832
- platform/gtk/Skipped:
- 09:48 Changeset [69966] by
-
2010-10-18 No'am Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Andreas Kling.
[Qt] AC rendering bugs
This fixes a regression that was introduced by making scrolling in accelerated compositing automatic,
which made our explicit function to scroll the compositing layers superfluous, making the scrolling behavior
when graphics layers are present incorrect. The fix simply removes those redundant functions.
- WebCoreSupport/PageClientQt.cpp: (WebCore::PageClientQGraphicsWidget::scroll): (WebCore::PageClientQGraphicsWidget::update): (WebCore::PageClientQGraphicsWidget::setRootGraphicsLayer):
- WebCoreSupport/PageClientQt.h:
- 09:47 Changeset [69965] by
-
2010-10-18 Oliver Hunt <oliver@apple.com>
Reviewed by Sam Weinig.
Strict mode: JIT doesn't check for |this| being an immediate before dereferencing
https://bugs.webkit.org/show_bug.cgi?id=47826
There's no guarantee that |this| will be a cell in a strict mode function, so
don't claim that it is.
- bytecode/CodeBlock.h: (JSC::CodeBlock::isKnownNotImmediate):
2010-10-18 Oliver Hunt <oliver@apple.com>
Reviewed by Sam Weinig.
Strict mode: JIT doesn't check for |this| being an immediate before dereferencing
https://bugs.webkit.org/show_bug.cgi?id=47826
Add tests for accessing properties on |this| when |this| is not an object
- fast/js/basic-strict-mode-expected.txt:
- fast/js/script-tests/basic-strict-mode.js: (testThisDotAccess): (testThisBracketAccess):
- 09:35 Changeset [69964] by
-
2010-10-18 Andrei Popescu <andreip@google.com>
Reviewed by Jeremy Orlow.
IDBKeyTree.h is no longer used.
https://bugs.webkit.org/show_bug.cgi?id=47824
No new tests, just removing unused files.
- WebCore.gypi:
- WebCore.xcodeproj/project.pbxproj:
- storage/IDBKeyTree.h: Removed.
- 09:30 Changeset [69963] by
-
2010-10-18 Zoltan Herczeg <zherczeg@webkit.org>
Reviewed by Oliver Hunt.
if (0) throw "x" ; else { } throws parse error after r69906
https://bugs.webkit.org/show_bug.cgi?id=47807
r69906 introduced a bug: the semicolon is not parsed after a throw
expression anymore. Thus, the semicolon terminates the "if" parsing
in the example above, and the else token results a parse error.
- parser/JSParser.cpp: (JSC::JSParser::parseThrowStatement):
2010-10-18 Zoltan Herczeg <zherczeg@webkit.org>
Reviewed by Oliver Hunt.
if (0) throw "x" ; else { } throws parse error after r69906
https://bugs.webkit.org/show_bug.cgi?id=47807
Adding a new test case to break-ASI.js
- fast/js/break-ASI-expected.txt:
- fast/js/script-tests/break-ASI.js:
- 09:16 Changeset [69962] by
-
[Qt] Fix the build with MSVC.
Reviewed by nobody, build fix.
Splitting the condition in two to prevent qmake parentheses issues.
- Api/DerivedSources.pro:
- 08:41 Changeset [69961] by
-
2010-10-18 Yi Shen <yi.4.shen@nokia.com>
Reviewed by Antonio Gomes.
[QT] Unable to load pages on QtTestBrowser after canceling a page load.
https://bugs.webkit.org/show_bug.cgi?id=43827
- Api/qwebpage.cpp: (QWebPage::triggerAction):
- 08:39 Changeset [69960] by
-
2010-10-18 Andreas Kling <kling@webkit.org>
Unreviewed buildfix for Qt + V8.
Add missing <wtf/text/CString.h> include.
- inspector/InspectorInstrumentation.cpp:
- 08:24 Changeset [69959] by
-
2010-10-18 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: toJSON serialization for Numbers should be fixed.
DecimalNumber is used instead of printf.
- inspector/InspectorValues.cpp: (WebCore::InspectorBasicValue::writeJSON):
- 06:29 Changeset [69958] by
-
[Qt] Add platform specific expected results for new passing tests.
Compared to Mac png files and Mac expected files.
- platform/qt/editing/input: Added.
- platform/qt/editing/input/emacs-ctrl-o-expected.checksum: Added.
- platform/qt/editing/input/emacs-ctrl-o-expected.png: Added.
- platform/qt/editing/input/emacs-ctrl-o-expected.txt: Added.
- platform/qt/fast/blockflow: Added.
- platform/qt/fast/blockflow/block-level-images-expected.checksum: Added.
- platform/qt/fast/blockflow/block-level-images-expected.png: Added.
- platform/qt/fast/blockflow/block-level-images-expected.txt: Added.
- platform/qt/fast/blockflow/fieldsets-expected.checksum: Added.
- platform/qt/fast/blockflow/fieldsets-expected.png: Added.
- platform/qt/fast/blockflow/fieldsets-expected.txt: Added.
- platform/qt/fast/blockflow/floats-in-block-layout-expected.checksum: Added.
- platform/qt/fast/blockflow/floats-in-block-layout-expected.png: Added.
- platform/qt/fast/blockflow/floats-in-block-layout-expected.txt: Added.
- platform/qt/fast/blockflow/inline-direction-positioning-expected.checksum: Added.
- platform/qt/fast/blockflow/inline-direction-positioning-expected.png: Added.
- platform/qt/fast/blockflow/inline-direction-positioning-expected.txt: Added.
- platform/qt/fast/blockflow/margin-collapse-expected.checksum: Added.
- platform/qt/fast/blockflow/margin-collapse-expected.png: Added.
- platform/qt/fast/blockflow/margin-collapse-expected.txt: Added.
- platform/qt/fast/blockflow/root-lr-basic-expected.checksum: Added.
- platform/qt/fast/blockflow/root-lr-basic-expected.png: Added.
- platform/qt/fast/blockflow/root-lr-basic-expected.txt: Added.
- platform/qt/fast/blockflow/self-collapsing-block-expected.checksum: Added.
- platform/qt/fast/blockflow/self-collapsing-block-expected.png: Added.
- platform/qt/fast/blockflow/self-collapsing-block-expected.txt: Added.
- platform/qt/fast/css/first-letter-punctuation-expected.checksum: Added.
- platform/qt/fast/css/first-letter-punctuation-expected.png: Added.
- platform/qt/fast/css/first-letter-punctuation-expected.txt: Added.
- platform/qt/fast/css/preserve-user-specified-zoom-level-on-reload-expected.checksum: Added.
- platform/qt/fast/css/preserve-user-specified-zoom-level-on-reload-expected.png: Added.
- platform/qt/fast/css/preserve-user-specified-zoom-level-on-reload-expected.txt: Added.
- platform/qt/fast/css/rtl-to-viewport-expected.checksum: Added.
- platform/qt/fast/css/rtl-to-viewport-expected.png: Added.
- platform/qt/fast/css/rtl-to-viewport-expected.txt: Added.
- platform/qt/fast/forms/input-button-sizes-expected.checksum: Added.
- platform/qt/fast/forms/input-button-sizes-expected.png: Added.
- platform/qt/fast/forms/input-button-sizes-expected.txt: Added.
- platform/qt/fast/forms/input-placeholder-focus-twice-expected.checksum: Added.
- platform/qt/fast/forms/input-placeholder-focus-twice-expected.png: Added.
- platform/qt/fast/forms/input-placeholder-focus-twice-expected.txt: Added.
- platform/qt/fast/images/gif-large-checkerboard-expected.checksum: Added.
- platform/qt/fast/images/gif-large-checkerboard-expected.png: Added.
- platform/qt/fast/images/gif-large-checkerboard-expected.txt: Added.
- platform/qt/fast/multicol/border-padding-pagination-expected.checksum: Added.
- platform/qt/fast/multicol/border-padding-pagination-expected.png: Added.
- platform/qt/fast/multicol/border-padding-pagination-expected.txt: Added.
- platform/qt/fast/multicol/column-break-with-balancing-expected.checksum: Added.
- platform/qt/fast/multicol/column-break-with-balancing-expected.png: Added.
- platform/qt/fast/multicol/column-break-with-balancing-expected.txt: Added.
- platform/qt/fast/multicol/float-paginate-complex-expected.checksum: Added.
- platform/qt/fast/multicol/float-paginate-complex-expected.png: Added.
- platform/qt/fast/multicol/float-paginate-complex-expected.txt: Added.
- platform/qt/fast/multicol/margin-collapse-expected.checksum: Added.
- platform/qt/fast/multicol/margin-collapse-expected.png: Added.
- platform/qt/fast/multicol/margin-collapse-expected.txt: Added.
- platform/qt/fast/multicol/shadow-breaking-expected.checksum: Added.
- platform/qt/fast/multicol/shadow-breaking-expected.png: Added.
- platform/qt/fast/multicol/shadow-breaking-expected.txt: Added.
- platform/qt/fast/multicol/table-margin-collapse-expected.checksum: Added.
- platform/qt/fast/multicol/table-margin-collapse-expected.png: Added.
- platform/qt/fast/multicol/table-margin-collapse-expected.txt: Added.
- platform/qt/fast/multicol/table-vertical-align-expected.checksum: Added.
- platform/qt/fast/multicol/table-vertical-align-expected.png: Added.
- platform/qt/fast/multicol/table-vertical-align-expected.txt: Added.
- platform/qt/fast/multicol/unsplittable-inline-block-expected.checksum: Added.
- platform/qt/fast/multicol/unsplittable-inline-block-expected.png: Added.
- platform/qt/fast/multicol/unsplittable-inline-block-expected.txt: Added.
- platform/qt/fast/repaint/block-layout-inline-children-replaced-expected.checksum: Added.
- platform/qt/fast/repaint/block-layout-inline-children-replaced-expected.png: Added.
- platform/qt/fast/repaint/block-layout-inline-children-replaced-expected.txt: Added.
- platform/qt/scrollbars: Added.
- platform/qt/scrollbars/custom-scrollbar-with-incomplete-style-expected.checksum: Added.
- platform/qt/scrollbars/custom-scrollbar-with-incomplete-style-expected.png: Added.
- platform/qt/scrollbars/custom-scrollbar-with-incomplete-style-expected.txt: Added.
- platform/qt/svg/W3C-SVG-1.1-SE: Added.
- platform/qt/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.checksum: Added.
- platform/qt/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png: Added.
- platform/qt/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt: Added.
- platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.checksum: Added.
- platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.png: Added.
- platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.txt: Added.
- platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.checksum: Added.
- platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.png: Added.
- platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.txt: Added.
- platform/qt/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.checksum: Added.
- platform/qt/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.png: Added.
- platform/qt/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt: Added.
- platform/qt/svg/custom/fill-opacity-hsl-expected.checksum: Added.
- platform/qt/svg/custom/fill-opacity-hsl-expected.png: Added.
- platform/qt/svg/custom/fill-opacity-hsl-expected.txt: Added.
- platform/qt/svg/custom/fill-opacity-rgba-expected.checksum: Added.
- platform/qt/svg/custom/fill-opacity-rgba-expected.png: Added.
- platform/qt/svg/custom/fill-opacity-rgba-expected.txt: Added.
- platform/qt/svg/custom/recursive-filter-expected.checksum: Added.
- platform/qt/svg/custom/recursive-filter-expected.png: Added.
- platform/qt/svg/custom/recursive-filter-expected.txt: Added.
- platform/qt/svg/custom/repaint-on-constant-size-change-expected.checksum: Added.
- platform/qt/svg/custom/repaint-on-constant-size-change-expected.png: Added.
- platform/qt/svg/custom/repaint-on-constant-size-change-expected.txt: Added.
- platform/qt/svg/custom/text-rotation-expected.checksum: Added.
- platform/qt/svg/custom/text-rotation-expected.png: Added.
- platform/qt/svg/custom/text-rotation-expected.txt: Added.
- platform/qt/svg/custom/text-x-dy-lists-expected.checksum: Added.
- platform/qt/svg/custom/text-x-dy-lists-expected.png: Added.
- platform/qt/svg/custom/text-x-dy-lists-expected.txt: Added.
- platform/qt/svg/in-html/by-reference-expected.txt: Added.
- 06:20 Changeset [69957] by
-
2010-10-18 Peter Varga <pvarga@inf.u-szeged.hu>
Reviewed by Andreas Kling.
Remove some unnecessary lines of code from Parser.cpp
https://bugs.webkit.org/show_bug.cgi?id=47816
- parser/Parser.cpp:
- 05:46 Changeset [69956] by
-
2010-10-18 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: [REGRESSION] Inspector window visible during run-webkit-tests.
The initial state of an inspector setting should stay untouched
if the profile has no value for it.
- inspector/InspectorState.cpp: (WebCore::InspectorState::loadFromSettings):
- 05:43 Styling Form Controls edited by
- (diff)
- 05:42 Styling Form Controls edited by
- (diff)
- 05:41 Styling Form Controls edited by
- (diff)
- 05:32 Styling Form Controls created by
- 05:29 Changeset [69955] by
-
2010-10-18 David Levin <levin@chromium.org>
Reviewed by Adam Barth.
check-webkit-style should treat the GObject binding directory like other GTK directories.
https://bugs.webkit.org/show_bug.cgi?id=47796
- Scripts/webkitpy/style/checker.py: Added the GObject binding directory with the other gtk directories (and fixed typo).
- 05:24 WikiStart edited by
- (diff)
- 05:13 Changeset [69954] by
-
2010-10-18 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: tab headers on resource panel are 1px off on Mac.
https://bugs.webkit.org/show_bug.cgi?id=47798
- inspector/front-end/inspector.css: (.tabbed-pane-header li):
- 04:57 Changeset [69953] by
-
2010-10-18 David Levin <levin@chromium.org>
Reviewed by Oliver Hunt.
check-webkit-style needs to ignore underscores in opcode names and vm_throw
https://bugs.webkit.org/show_bug.cgi?id=47789
- Scripts/webkitpy/style/checker.py: Added the exception for the assembler directory.
- Scripts/webkitpy/style/checkers/cpp.py: Added special cased names.
- Scripts/webkitpy/style/checkers/cpp_unittest.py: Added unit tests for the special cases.
- 04:46 Changeset [69952] by
-
2010-10-18 MORITA Hajime <morrita@google.com>
Reviewed by Kent Tamura.
TextInputController.hasSpellingMarkers() should be owned by LayoutTestController
https://bugs.webkit.org/show_bug.cgi?id=47659
Changed the reciever of hasSpellingMarkers from
textInputController to layoutTestController.
- editing/spelling/design-mode-spellcheck-off.html:
- editing/spelling/script-tests/spelling-backspace-between-lines.js: (testWithDelete): (testWithForwardDelete):
- editing/spelling/spelling-backspace-between-lines-expected.txt:
- editing/spelling/spelling-contenteditable.html:
- editing/spelling/spelling-textarea.html:
2010-10-18 MORITA Hajime <morrita@google.com>
Reviewed by Kent Tamura.
TextInputController.hasSpellingMarkers() should be owned by LayoutTestController
https://bugs.webkit.org/show_bug.cgi?id=47659
Moved hasSpellingMarkers() from TextInputController to
LayoutTestController. Currently the implementation is available
only for Mac and for Chromium.
- DumpRenderTree/LayoutTestController.cpp: (hasSpellingMarkerCallback): (LayoutTestController::staticFunctions):
- DumpRenderTree/LayoutTestController.h:
- DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::hasSpellingMarker):
- DumpRenderTree/chromium/LayoutTestController.h:
- DumpRenderTree/chromium/TextInputController.cpp: (TextInputController::TextInputController): (TextInputController::makeAttributedString):
- DumpRenderTree/chromium/TextInputController.h:
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::hasSpellingMarker):
- DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::hasSpellingMarker):
- DumpRenderTree/mac/TextInputController.m: (+[TextInputController isSelectorExcludedFromWebScript:]): (+[TextInputController webScriptNameForSelector:]):
- DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::hasSpellingMarker):
- DumpRenderTree/qt/LayoutTestControllerQt.h:
- DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::hasSpellingMarker):
- DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::hasSpellingMarker):
- 04:42 Changeset [69951] by
-
2010-10-18 Adam Barth <abarth@webkit.org>
Reviewed by David Levin.
commit-queue's flaky test notice is very Pythony
https://bugs.webkit.org/show_bug.cgi?id=47790
This patch make the list of tests delimted by \n instead of just
converting the array to a string.
- Scripts/webkitpy/tool/commands/queues.py:
- Scripts/webkitpy/tool/commands/queues_unittest.py:
- 03:42 Changeset [69950] by
-
2010-10-18 Alejandro G. Castro <alex@igalia.com>
Unreviewed, skip another mathml flaky test, check bug:
https://bugs.webkit.org/show_bug.cgi?id=47727
- platform/gtk/Skipped:
- 03:39 Changeset [69949] by
-
2010-10-18 Pavel Feldman <pfeldman@chromium.org>
Not reviewed. Build fix.
- inspector/InspectorResourceAgent.cpp: (WebCore::cachedResourceTypeString):
- 03:14 Changeset [69948] by
-
2010-10-17 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Introduce InspectorResourceAgent.h/cpp and ResourceManager.js to
fill network panel with data.
https://bugs.webkit.org/show_bug.cgi?id=47779
InspectorResourceAgent instance / JS part are introduced in this patch. Agent's lifetime is equal
to the front-end's. This new resource agent does not have state, instead it covers two functions:
1) forwards loader client messages to the front-end 2) is capable of building a tree of cached resources.
(1) feeds network panel with data, (2) shows the resource tree in the new ResourcesPanel concept.
This bug is for extracting this new InspectorResourceAgent class and its javascript counterpart.
Once resources panel is refactored for the new concept, InspectorResource, InspectorController's
resource-related routines, inspector.js's code dealing with resources, they all will be gone.
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/CodeGeneratorInspector.pm:
- inspector/Inspector.idl:
- inspector/InspectorApplicationCacheAgent.cpp: (WebCore::InspectorApplicationCacheAgent::didReceiveManifestResponse):
- inspector/InspectorController.cpp: (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::releaseFrontendLifetimeAgents): (WebCore::InspectorController::didCommitLoad): (WebCore::InspectorController::frameDetachedFromParent): (WebCore::InspectorController::didLoadResourceFromMemoryCache): (WebCore::InspectorController::identifierForInitialRequest): (WebCore::InspectorController::willSendRequest): (WebCore::InspectorController::markResourceAsCached): (WebCore::InspectorController::didReceiveResponse): (WebCore::InspectorController::didReceiveContentLength): (WebCore::InspectorController::didFinishLoading): (WebCore::InspectorController::didFailLoading): (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest): (WebCore::InspectorController::scriptImported): (WebCore::InspectorController::didCreateWebSocket): (WebCore::InspectorController::willSendWebSocketHandshakeRequest): (WebCore::InspectorController::didReceiveWebSocketHandshakeResponse): (WebCore::InspectorController::didCloseWebSocket):
- inspector/InspectorController.h:
- inspector/InspectorResource.cpp: (WebCore::InspectorResource::updateResponse): (WebCore::cachedResourceType): (WebCore::InspectorResource::type): (WebCore::InspectorResource::sourceString): (WebCore::InspectorResource::sourceBytes): (WebCore::InspectorResource::endTiming):
- inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::resourceContent): (WebCore::InspectorResourceAgent::resourceContentBase64): (WebCore::InspectorResourceAgent::resourceData): (WebCore::InspectorResourceAgent::cachedResource): (WebCore::buildObjectForHeaders): (WebCore::buildObjectForTiming): (WebCore::buildObjectForResourceRequest): (WebCore::buildObjectForResourceResponse): (WebCore::buildObjectForMainResource): (WebCore::cachedResourceTypeString): (WebCore::buildObjectForCachedResource): (WebCore::buildObjectForFrameResources): (WebCore::InspectorResourceAgent::~InspectorResourceAgent): (WebCore::InspectorResourceAgent::identifierForInitialRequest): (WebCore::InspectorResourceAgent::willSendRequest): (WebCore::InspectorResourceAgent::markResourceAsCached): (WebCore::InspectorResourceAgent::didReceiveResponse): (WebCore::InspectorResourceAgent::didReceiveContentLength): (WebCore::InspectorResourceAgent::didFinishLoading): (WebCore::InspectorResourceAgent::didFailLoading): (WebCore::InspectorResourceAgent::didLoadResourceFromMemoryCache): (WebCore::InspectorResourceAgent::setOverrideContent): (WebCore::InspectorResourceAgent::didCommitLoad): (WebCore::InspectorResourceAgent::frameDetachedFromParent): (WebCore::createReadableStringFromBinary): (WebCore::InspectorResourceAgent::didCreateWebSocket): (WebCore::InspectorResourceAgent::willSendWebSocketHandshakeRequest): (WebCore::InspectorResourceAgent::didReceiveWebSocketHandshakeResponse): (WebCore::InspectorResourceAgent::didCloseWebSocket): (WebCore::InspectorResourceAgent::cachedResources): (WebCore::InspectorResourceAgent::InspectorResourceAgent):
- inspector/InspectorResourceAgent.h: (WebCore::InspectorResourceAgent::create):
- inspector/InspectorStyleSheet.cpp: (WebCore::InspectorStyleSheet::resourceStyleSheetText):
- inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer.prototype._onRevealAndSelectResource): (WebInspector.ExtensionServer.prototype._onGetResourceContent):
- inspector/front-end/Resource.js: (WebInspector.Resource.prototype.get responseReceivedTime): (WebInspector.Resource.prototype.set endTime):
- inspector/front-end/Settings.js:
- inspector/front-end/SourceView.js: (WebInspector.SourceView.prototype.setupSourceFrameIfNeeded):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.css: (.tabbed-pane-header li):
- inspector/front-end/inspector.html:
- inspector/front-end/inspector.js: (WebInspector.updateResource):
- loader/ResourceLoadNotifier.cpp: (WebCore::ResourceLoadNotifier::dispatchDidReceiveResponse):
- loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::didReceiveResponse):
2010-10-17 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Introduce InspectorResourceAgent.h/cpp and ResourceManager.js to
fill network panel with data.
https://bugs.webkit.org/show_bug.cgi?id=47779
- src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::didReceiveResponse):
- 02:18 Changeset [69947] by
-
2010-10-16 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: brush up URL parsing on the front-end.
https://bugs.webkit.org/show_bug.cgi?id=47772
- inspector/InspectorResource.cpp: (WebCore::InspectorResource::updateScriptObject):
- inspector/front-end/AuditRules.js: (WebInspector.AuditRules.getDomainToResourcesMap): (WebInspector.AuditRules.CombineExternalResourcesRule.prototype.doRun): (WebInspector.AuditRules.MinimizeDnsLookupsRule.prototype.doRun): (WebInspector.AuditRules.ParallelizeDownloadRule.prototype.doRun): (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun): (WebInspector.AuditRules.CookieSizeRule.prototype.processCookies): (WebInspector.AuditRules.StaticCookielessRule.prototype.processCookies):
- inspector/front-end/CookieItemsView.js: (WebInspector.CookieItemsView.prototype._filterCookiesForDomain):
- inspector/front-end/DOMAgent.js: (WebInspector.Cookies.cookieMatchesResourceURL):
- inspector/front-end/Resource.js: (WebInspector.Resource): (WebInspector.Resource.prototype.set url): (WebInspector.Resource.prototype.get displayName):
- inspector/front-end/ResourceCategory.js: (WebInspector.ResourceCategory.prototype.addResource):
- inspector/front-end/ResourceView.js: (WebInspector.ResourceView):
- inspector/front-end/inspector.js: (WebInspector.documentClick.followLink): (WebInspector.documentClick): (WebInspector.updateResource): (WebInspector.linkifyStringAsFragment): (WebInspector.resourceURLForRelatedNode): (WebInspector.completeURL):
- inspector/front-end/utilities.js: (String.prototype.asParsedURL):
- 01:15 Changeset [69946] by
-
2010-10-17 Andreas Kling <kling@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Support custom open() verbs/methods in XMLHttpRequest
https://bugs.webkit.org/show_bug.cgi?id=40476
Fall back to QNetworkAccessManager::CustomOperation for any HTTP verb
that's not specifically supported by QNetworkAccessManager.
This prevents the infinite loop that otherwise occurs after sending
an UnknownOperation request.
This change is covered by existing (skipped) tests that will be
unskipped once the Qt bots are running Qt 4.7.
- platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::httpMethod): (WebCore::QNetworkReplyHandler::QNetworkReplyHandler): (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
- platform/network/qt/QNetworkReplyHandler.h:
- 00:53 Changeset [69945] by
-
2010-10-18 Adam Barth <abarth@webkit.org>
Add more Skipped list entries because WebP requires an external decoder
library.
- platform/gtk/Skipped:
- platform/mac/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- 00:39 Changeset [69944] by
-
2010-10-18 Xan Lopez <xlopez@igalia.com>
Reviewed by Csaba Osztrogonác.
Build broken with JIT disabled
https://bugs.webkit.org/show_bug.cgi?id=47801
This is a regression caused by r69940.
- interpreter/Interpreter.cpp: (JSC::Interpreter::resolveBase):
- 00:25 Changeset [69943] by
-
Change FastAllocBase implementation into a macro
https://bugs.webkit.org/show_bug.cgi?id=42998
Reviewed by Darin Adler.
It was investigated in bug #33896 that inheriting classes from FastAllocBase
can result in objects getting larger which leads to memory regressions.
Using a macro instead of inheriting classes from FastAllocBase would solve the issue.
- wtf/FastAllocBase.h: Add a WTF_MAKE_FAST_ALLOCATED macro
10/17/10:
- 23:51 Changeset [69942] by
-
2010-10-17 Pascal Massimino <pascal.massimino@gmail.com>
Reviewed by Adam Barth.
Add support for WebP image decoding in ImageDecoder
using library libwebp-decode library available from
http://www.webmproject.org/code/
Tests: fast/images/webp-image-decoding.html
- CMakeLists.txt:
add platform/image-decoders/webp files and directory
- GNUmakefile.am:
add platform/image-decoders/webp directory
- WebCore.gyp/WebCore.gyp:
add platform/image-decoders/webp directory
- WebCore.gypi:
add platform/image-decoders/webp directory
- features.gypi:
add WTF_USE_WEBP=1
- platform/image-decoders/ImageDecoder.cpp: (WebCore::ImageDecoder::create):
instantiate webp decoder for file starting with 'RIFF????WEBP'
- platform/image-decoders/webp: Added.
- platform/image-decoders/webp/WEBPImageDecoder.cpp: Added. (WebCore::WEBPImageDecoder::WEBPImageDecoder): (WebCore::WEBPImageDecoder::~WEBPImageDecoder): (WebCore::WEBPImageDecoder::isSizeAvailable): (WebCore::WEBPImageDecoder::frameBufferAtIndex): (WebCore::WEBPImageDecoder::decode):
sub-class handling decoding of webp images
- platform/image-decoders/webp/WEBPImageDecoder.h: Added. (WebCore::WEBPImageDecoder::filenameExtension): (WebCore::WEBPImageDecoder::supportsAlpha):
header for webp-decoder sub-class
2010-10-17 Pascal Massimino <pascal.massimino@gmail.com>
Reviewed by Adam Barth.
Add support for decoding WebP image
https://bugs.webkit.org/show_bug.cgi?id=47512
- DEPS:
- Add dependency to libwebp.
- 22:42 Changeset [69941] by
-
2010-10-17 Oliver Hunt <oliver@apple.com>
Reviewed by Sam Weinig.
Strict mode: arguments is not valid as the base expression for pre- or post-fix expressions
https://bugs.webkit.org/show_bug.cgi?id=47791
Simple fix, check for arguments in addition to eval.
- parser/JSParser.cpp: (JSC::JSParser::parseUnaryExpression):
2010-10-17 Oliver Hunt <oliver@apple.com>
Reviewed by Sam Weinig.
Strict mode: arguments is not valid as the base expression for pre- or post-fix expressions
https://bugs.webkit.org/show_bug.cgi?id=47791
Add arguments tests, and make pre-/post-fix expression tests cover another case I was
needlessly worried about.
- fast/js/basic-strict-mode-expected.txt:
- fast/js/script-tests/basic-strict-mode.js:
- 21:08 Changeset [69940] by
-
2010-10-17 Oliver Hunt <oliver@apple.com>
Reviewed by Sam Weinig.
Strict mode: Assignment that would create a global should be a late ReferenceError, not a syntax failure
https://bugs.webkit.org/show_bug.cgi?id=47788
Fixing this required a couple of changes:
- resolve_base now has a flag to indicate whether it is being used for a put in strict mode. this allows us to throw an exception when we're doing a completely generic resolve for assignment, and that assignment would create a new global.
- There is a new opcode 'op_ensure_property_exists' that is used to determine whether the property being assigned to already exists on the global object. This currently has no caching, but such caching could be added relatively trivially. It is only used in the case where we know that a property will be placed on the global object, and we cannot verify that the property already exists.
In the jit we plant a call to cti_op_resolve_base_strict_put in the effected case rather
than making op_resolve_base have an additional runtime branch.
There's also a new helper function to create the exception for the invalid assignment.
- bytecode/CodeBlock.cpp: (JSC::CodeBlock::dump):
- bytecode/Opcode.h:
- bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::emitResolveBase): (JSC::BytecodeGenerator::emitResolveBaseForPut):
- bytecompiler/BytecodeGenerator.h:
- bytecompiler/NodesCodegen.cpp: (JSC::AssignResolveNode::emitBytecode): (JSC::ForInNode::emitBytecode):
- interpreter/Interpreter.cpp: (JSC::Interpreter::resolveBase): (JSC::Interpreter::privateExecute):
- jit/JIT.cpp: (JSC::JIT::privateCompileMainPass):
- jit/JIT.h:
- jit/JITOpcodes.cpp: (JSC::JIT::emit_op_resolve_base): (JSC::JIT::emit_op_ensure_property_exists):
- jit/JITOpcodes32_64.cpp: (JSC::JIT::emit_op_resolve_base): (JSC::JIT::emit_op_ensure_property_exists):
- jit/JITStubs.cpp: (JSC::DEFINE_STUB_FUNCTION):
- jit/JITStubs.h:
- parser/JSParser.cpp: (JSC::JSParser::parseProgram):
- runtime/ExceptionHelpers.cpp: (JSC::createErrorForInvalidGlobalAssignment):
- runtime/ExceptionHelpers.h:
- runtime/Operations.h: (JSC::resolveBase):
2010-10-17 Oliver Hunt <oliver@apple.com>
Reviewed by Sam Weinig.
Strict mode: Assignment that would create a global should be a late ReferenceError, not a syntax failure
https://bugs.webkit.org/show_bug.cgi?id=47788
Update test to check for the correct behaviour.
- fast/js/basic-strict-mode-expected.txt:
- fast/js/script-tests/basic-strict-mode.js:
- 21:02 Changeset [69939] by
-
2010-10-17 Antonio Gomes <agomes@rim.com>
Reviewed by Simon Fraser.
Enrich /fast/dom/nodesFromRect-basic.html test
https://bugs.webkit.org/show_bug.cgi?id=47766
The patch makes fast/dom/nodesFromRect-basic.html test more precise:
instead of calling nodesFromRect always with equal vertical (up and down) and
horizontal (right and left) padding values, it are now tests it by passing
different padding values on the various directions.
It is now possible due to the work on bug 46336: Make Document::nodesFromRect more flexible.
- fast/dom/nodesFromRect-basic-expected.txt:
- fast/dom/nodesFromRect-basic.html:
- 19:59 Changeset [69938] by
-
2010-10-17 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Remove explicit passing of user gesture in NavigationScheduler
https://bugs.webkit.org/show_bug.cgi?id=47786
As requested by Mr. Glazkov, remove more explicit passing of the user
gesture state. We now use a static to pass this information around.
- bindings/generic/BindingFrame.h: (WebCore::::navigateIfAllowed):
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::setLocation):
- bindings/js/JSLocationCustom.cpp: (WebCore::JSLocation::reload):
- bindings/v8/custom/V8LocationCustom.cpp: (WebCore::V8Location::reloadCallback):
- inspector/InspectorController.cpp: (WebCore::InspectorController::setResourceTrackingEnabled): (WebCore::InspectorController::reloadPage):
- loader/NavigationScheduler.cpp: (WebCore::ScheduledNavigation::ScheduledNavigation): (WebCore::ScheduledURLNavigation::ScheduledURLNavigation): (WebCore::ScheduledRedirect::ScheduledRedirect): (WebCore::ScheduledLocationChange::ScheduledLocationChange): (WebCore::ScheduledRefresh::ScheduledRefresh): (WebCore::ScheduledHistoryNavigation::ScheduledHistoryNavigation): (WebCore::ScheduledFormSubmission::ScheduledFormSubmission): (WebCore::NavigationScheduler::scheduleRedirect): (WebCore::NavigationScheduler::mustLockBackForwardList): (WebCore::NavigationScheduler::scheduleLocationChange): (WebCore::NavigationScheduler::scheduleFormSubmission): (WebCore::NavigationScheduler::scheduleRefresh): (WebCore::NavigationScheduler::scheduleHistoryNavigation):
- loader/NavigationScheduler.h:
- loader/SubframeLoader.cpp: (WebCore::SubframeLoader::loadOrRedirectSubframe):
- 18:22 Changeset [69937] by
-
WebCore: 'transparent' should be a valid color
https://bugs.webkit.org/show_bug.cgi?id=45482
Reviewed by Andreas Kling.
Test: svg/animations/svg-animate-color-transparent.svg
Based on previous work by Jan Erik Hanssen <jhanssen@codeaurora.org>
- platform/ColorData.gperf: Added 'transparent' to the list of colors.
Added the alpha to all the colors as it was needed to support the new color.
- platform/graphics/Color.cpp:
(WebCore::Color::Color):
(WebCore::Color::setNamedColor): Avoid setting the alpha as now it is not
always 0xFF.
LayoutTests: Test for: 'transparent' should be a valid color
https://bugs.webkit.org/show_bug.cgi?id=45482
Reviewed by Andreas Kling.
Test that animation works with 'transparent' as they check the validity of the
color.
- svg/animations/svg-animate-color-transparent-expected.txt: Added.
- svg/animations/svg-animate-color-transparent.svg: Added.
- 17:47 Changeset [69936] by
-
2010-10-17 Justin Schuh <jschuh@chromium.org>
Reviewed by Nikolas Zimmermann.
Duplicate use element children in shadow tree.
https://bugs.webkit.org/show_bug.cgi?id=47561
Test: svg/custom/use-nested-children.svg
- svg/SVGUseElement.cpp: (WebCore::SVGUseElement::expandUseElementsInShadowTree):
2010-10-17 Justin Schuh <jschuh@chromium.org>
Reviewed by Nikolas Zimmermann.
Duplicate use element children in shadow tree.
https://bugs.webkit.org/show_bug.cgi?id=47561
- svg/custom/use-nested-children-expected.txt: Added.
- svg/custom/use-nested-children.svg: Added.
- 17:04 Changeset [69935] by
-
2010-10-17 Hyung Song <beergun@company100.net>
Reviewed by David Levin.
Add !SINGLE_THREADED guard.
https://bugs.webkit.org/show_bug.cgi?id=47608
For SINGLE_THREADED ports LockingMutex.tryLock() returns false.
This will prevent interrupt() from falling into infinite loop.
- platform/sql/SQLiteDatabase.cpp: (WebCore::SQLiteDatabase::interrupt):
- 15:05 Changeset [69934] by
-
2010-10-17 Simon Fraser <simon.fraser@apple.com>
Remove Windows-specific result, which is not longer needed after r69928.
- platform/win/fast/css/large-number-round-trip-expected.txt: Removed.
- 14:55 Changeset [69933] by
-
The names of IndexedDB-specific attributes of DOMWindow should be prefixed with 'webkit'.
https://bugs.webkit.org/show_bug.cgi?id=47508
BUG=59508
Patch by Andrei Popescu <andreip@google.com> on 2010-10-11
Reviewed by Jeremy Orlow.
LayoutTests:
- storage/indexeddb/basics-expected.txt:
- storage/indexeddb/basics.html:
- storage/indexeddb/constants-expected.txt:
- storage/indexeddb/constants.html:
- storage/indexeddb/database-basics-expected.txt:
- storage/indexeddb/database-basics.html:
- storage/indexeddb/database-quota-expected.txt:
- storage/indexeddb/database-quota.html:
- storage/indexeddb/index-basics-expected.txt:
- storage/indexeddb/index-basics.html:
- storage/indexeddb/index-cursor-expected.txt:
- storage/indexeddb/index-cursor.html:
- storage/indexeddb/keyrange-expected.txt:
- storage/indexeddb/keyrange.html:
- storage/indexeddb/objectstore-basics-expected.txt:
- storage/indexeddb/objectstore-basics.html:
- storage/indexeddb/objectstore-cursor-expected.txt:
- storage/indexeddb/objectstore-cursor.html:
- storage/indexeddb/objectstore-removeobjectstore-expected.txt:
- storage/indexeddb/objectstore-removeobjectstore.html:
- storage/indexeddb/open-cursor-expected.txt:
- storage/indexeddb/open-cursor.html:
- storage/indexeddb/transaction-basics-expected.txt:
- storage/indexeddb/transaction-basics.html:
WebCore:
- bindings/generic/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::setWebkitIndexedDBEnabled):
(WebCore::RuntimeEnabledFeatures::webkitIndexedDBEnabled):
(WebCore::RuntimeEnabledFeatures::webkitIDBCursorEnabled):
(WebCore::RuntimeEnabledFeatures::webkitIDBDatabaseEnabled):
(WebCore::RuntimeEnabledFeatures::webkitIDBDatabaseErrorEnabled):
(WebCore::RuntimeEnabledFeatures::webkitIDBDatabaseExceptionEnabled):
(WebCore::RuntimeEnabledFeatures::webkitIDBErrorEventEnabled):
(WebCore::RuntimeEnabledFeatures::webkitIDBEventEnabled):
(WebCore::RuntimeEnabledFeatures::webkitIDBFactoryEnabled):
(WebCore::RuntimeEnabledFeatures::webkitIDBIndexEnabled):
(WebCore::RuntimeEnabledFeatures::webkitIDBKeyRangeEnabled):
(WebCore::RuntimeEnabledFeatures::webkitIDBObjectStoreEnabled):
(WebCore::RuntimeEnabledFeatures::webkitIDBRequestEnabled):
(WebCore::RuntimeEnabledFeatures::webkitIDBSuccessEventEnabled):
(WebCore::RuntimeEnabledFeatures::webkitIDBTransactionEnabled):
- page/DOMWindow.cpp:
(WebCore::DOMWindow::webkitIndexedDB):
- page/DOMWindow.h:
- page/DOMWindow.idl:
WebKit/chromium:
- src/WebRuntimeFeatures.cpp:
(WebKit::WebRuntimeFeatures::enableIndexedDatabase):
(WebKit::WebRuntimeFeatures::isIndexedDatabaseEnabled):
Merge 69540 - 2010-10-11 Andrei Popescu <andreip@google.com>
Reviewed by Jeremy Orlow.
The names of IndexedDB-specific attributes of DOMWindow should be prefixed with 'webkit'.
https://bugs.webkit.org/show_bug.cgi?id=47508
- storage/indexeddb/basics-expected.txt:
- storage/indexeddb/basics.html:
- storage/indexeddb/constants-expected.txt:
- storage/indexeddb/constants.html:
- storage/indexeddb/database-basics-expected.txt:
- storage/indexeddb/database-basics.html:
- storage/indexeddb/database-quota-expected.txt:
- storage/indexeddb/database-quota.html:
- storage/indexeddb/index-basics-expected.txt:
- storage/indexeddb/index-basics.html:
- storage/indexeddb/index-cursor-expected.txt:
- storage/indexeddb/index-cursor.html:
- storage/indexeddb/keyrange-expected.txt:
- storage/indexeddb/keyrange.html:
- storage/indexeddb/objectstore-basics-expected.txt:
- storage/indexeddb/objectstore-basics.html:
- storage/indexeddb/objectstore-cursor-expected.txt:
- storage/indexeddb/objectstore-cursor.html:
- storage/indexeddb/objectstore-removeobjectstore-expected.txt:
- storage/indexeddb/objectstore-removeobjectstore.html:
- storage/indexeddb/open-cursor-expected.txt:
- storage/indexeddb/open-cursor.html:
- storage/indexeddb/transaction-basics-expected.txt:
- storage/indexeddb/transaction-basics.html:
2010-10-11 Andrei Popescu <andreip@google.com>
Reviewed by Jeremy Orlow.
The names of IndexedDB-specific attributes of DOMWindow should be prefixed with 'webkit'.
https://bugs.webkit.org/show_bug.cgi?id=47508
- bindings/generic/RuntimeEnabledFeatures.h: (WebCore::RuntimeEnabledFeatures::setWebkitIndexedDBEnabled): (WebCore::RuntimeEnabledFeatures::webkitIndexedDBEnabled): (WebCore::RuntimeEnabledFeatures::webkitIDBCursorEnabled): (WebCore::RuntimeEnabledFeatures::webkitIDBDatabaseEnabled): (WebCore::RuntimeEnabledFeatures::webkitIDBDatabaseErrorEnabled): (WebCore::RuntimeEnabledFeatures::webkitIDBDatabaseExceptionEnabled): (WebCore::RuntimeEnabledFeatures::webkitIDBErrorEventEnabled): (WebCore::RuntimeEnabledFeatures::webkitIDBEventEnabled): (WebCore::RuntimeEnabledFeatures::webkitIDBFactoryEnabled): (WebCore::RuntimeEnabledFeatures::webkitIDBIndexEnabled): (WebCore::RuntimeEnabledFeatures::webkitIDBKeyRangeEnabled): (WebCore::RuntimeEnabledFeatures::webkitIDBObjectStoreEnabled): (WebCore::RuntimeEnabledFeatures::webkitIDBRequestEnabled): (WebCore::RuntimeEnabledFeatures::webkitIDBSuccessEventEnabled): (WebCore::RuntimeEnabledFeatures::webkitIDBTransactionEnabled):
- page/DOMWindow.cpp: (WebCore::DOMWindow::webkitIndexedDB):
- page/DOMWindow.h:
- page/DOMWindow.idl:
2010-10-11 Andrei Popescu <andreip@google.com>
Reviewed by Jeremy Orlow.
The names of IndexedDB-specific attributes of DOMWindow should be prefixed with 'webkit'.
https://bugs.webkit.org/show_bug.cgi?id=47508
- src/WebRuntimeFeatures.cpp: (WebKit::WebRuntimeFeatures::enableIndexedDatabase): (WebKit::WebRuntimeFeatures::isIndexedDatabaseEnabled):
- 14:48 Changeset [69932] by
-
storage/indexeddb/database-quota.html expects the wrong database version string
https://bugs.webkit.org/show_bug.cgi?id=47533
BUG=59506
Patch by Andrei Popescu <andreip@google.com> on 2010-10-11
Reviewed by Jeremy Orlow.
- storage/indexeddb/database-quota-expected.txt:
- storage/indexeddb/database-quota.html:
Merge 69612 - 2010-10-11 Andrei Popescu <andreip@google.com>
Reviewed by Jeremy Orlow.
storage/indexeddb/database-quota.html expects the wrong database version string
https://bugs.webkit.org/show_bug.cgi?id=47533
- storage/indexeddb/database-quota-expected.txt:
- storage/indexeddb/database-quota.html:
- 14:46 Changeset [69931] by
-
[Chromium] Cleanup WebIDBFactory::open once the Chromium plumbing has landed.
https://bugs.webkit.org/show_bug.cgi?id=47531
BUG=59506
Patch by Andrei Popescu <andreip@google.com> on 2010-10-11
Reviewed by Jeremy Orlow.
Remove the temporary open() method since the appropriate Chromium plumbing was
added in http://codereview.chromium.org/3729003/
- public/WebIDBFactory.h:
(WebKit::WebIDBFactory::open):
Merge 69670 - 2010-10-11 Andrei Popescu <andreip@google.com>
Reviewed by Jeremy Orlow.
[Chromium] Cleanup WebIDBFactory::open once the Chromium plumbing has landed.
https://bugs.webkit.org/show_bug.cgi?id=47531
Remove the temporary open() method since the appropriate Chromium plumbing was
added in http://codereview.chromium.org/3729003/
- public/WebIDBFactory.h: (WebKit::WebIDBFactory::open):
- 14:44 Changeset [69930] by
-
2010-10-17 Martin Robinson <mrobinson@igalia.com>
Rebaseline MathML tests after r69926.
- platform/gtk/mathml/presentation/attributes-expected.txt:
- platform/gtk/mathml/presentation/fenced-mi-expected.txt:
- platform/gtk/mathml/presentation/fractions-expected.txt:
- platform/gtk/mathml/presentation/fractions-vertical-alignment-expected.txt:
- platform/gtk/mathml/presentation/mo-expected.txt:
- platform/gtk/mathml/presentation/row-alignment-expected.txt:
- platform/gtk/mathml/presentation/row-expected.txt:
- platform/gtk/mathml/presentation/style-expected.txt:
- platform/gtk/mathml/presentation/tokenElements-expected.txt:
- platform/gtk/mathml/presentation/underover-expected.txt:
- 13:40 Changeset [69929] by
-
2010-10-17 Simon Fraser <simon.fraser@apple.com>
First part of fix for Windows build failure. Will wait for the
next set of link errors to determine the mangled forms for dtoaRoundSF
and dtoaRoundDP.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- 13:05 Changeset [69928] by
-
2010-10-17 Simon Fraser <simon.fraser@apple.com>
Reviewed by Nikolas Zimmermann.
Very large and small numbers fail to round-trip through CSS
https://bugs.webkit.org/show_bug.cgi?id=20674
Use the new DecimalNumber functionality to convert CSS numberic values to strings
using decimal notation, rather than %g (which can output scientific notation).
Test: fast/css/round-trip-values.html
- css/CSSPrimitiveValue.cpp: (WebCore::formatNumber): (WebCore::CSSPrimitiveValue::cssText):
- 12:46 Changeset [69927] by
-
2010-10-17 Cosmin Truta <ctruta@chromium.org>
Reviewed by Nikolas Zimmermann.
Crash while processing ill-formed SVG with cycles
https://bugs.webkit.org/show_bug.cgi?id=47498
Checked the behavior of the attributes fill, stroke, clip and mask
when used with URLs that point to wrong elements.
- svg/custom/invalid-paint-shape-mask.svg: Added.
- svg/custom/invalid-paint-shape-mask-expected.svg: Added.
2010-10-17 Cosmin Truta <ctruta@chromium.org>
Reviewed by Nikolas Zimmermann.
Crash while processing ill-formed SVG with cycles
https://bugs.webkit.org/show_bug.cgi?id=47498
Test: svg/custom/invalid-paint-shape-mask.svg
- rendering/SVGResources.cpp: (paintingResourceFromSVGPaint): Ensured that the painting resource is either a pattern resource or a gradient resource. (SVGResources::setClipper): (SVGResources::setFilter): (SVGResources::setMarkerStart): (SVGResources::setMarkerMid): (SVGResources::setMarkerEnd): (SVGResources::setMasker): (SVGResources::setFill): (SVGResources::setStroke): Added ASSERT statements for previously-unchecked preconditions.
- 11:44 Changeset [69926] by
-
2010-10-17 Alex Milowski <alex@milowski.com>
Reviewed by Kenneth Rohde Christiansen.
Since whitespace and baseline alignment have changed for operators,
many tests needed to be re-baselined.
- platform/mac/mathml/presentation/attributes-expected.checksum:
- platform/mac/mathml/presentation/attributes-expected.png:
- platform/mac/mathml/presentation/attributes-expected.txt:
- platform/mac/mathml/presentation/fenced-expected.checksum:
- platform/mac/mathml/presentation/fenced-expected.png:
- platform/mac/mathml/presentation/fenced-expected.txt:
- platform/mac/mathml/presentation/fractions-vertical-alignment-expected.checksum:
- platform/mac/mathml/presentation/fractions-vertical-alignment-expected.png:
- platform/mac/mathml/presentation/fractions-vertical-alignment-expected.txt:
- platform/mac/mathml/presentation/mo-expected.checksum:
- platform/mac/mathml/presentation/mo-expected.png:
- platform/mac/mathml/presentation/mo-expected.txt:
- platform/mac/mathml/presentation/roots-expected.checksum:
- platform/mac/mathml/presentation/roots-expected.png:
- platform/mac/mathml/presentation/roots-expected.txt:
- platform/mac/mathml/presentation/row-alignment-expected.checksum:
- platform/mac/mathml/presentation/row-alignment-expected.png:
- platform/mac/mathml/presentation/row-alignment-expected.txt:
- platform/mac/mathml/presentation/row-expected.checksum:
- platform/mac/mathml/presentation/row-expected.png:
- platform/mac/mathml/presentation/row-expected.txt:
2010-10-17 Alex Milowski <alex@milowski.com>
Reviewed by Kenneth Rohde Christiansen.
Fixed extra whitespace above operators when they aren't stretched
yet the stretch height is large. Also, the baseline alignment
was changed so that rows and operators interact appropriately now
that operators don't have the extra white space.
- mathml/RenderMathMLOperator.cpp:
- mathml/RenderMathMLRow.cpp:
- 11:19 Changeset [69925] by
-
2010-10-17 Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>
Reviewed by Antonio Gomes.
[Qt] Layout tests for fix focusing of control elements on mouse click.
https://bugs.webkit.org/show_bug.cgi?id=40641
- fast/events/click-focus-control-expected.txt: Added.
- fast/events/click-focus-control.html: Added.
- platform/mac/fast/events/click-focus-control-expected.txt: Added.
- platform/win/Skipped:
2010-10-17 Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>
Reviewed by Antonio Gomes.
[Qt] Fix focusing of control elements on mouse click.
Brings GTK fix to Qt platform.
https://bugs.webkit.org/show_bug.cgi?id=40641
Test: fast/events/click-focus-control.html
- html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::isMouseFocusable):
- 09:02 Changeset [69924] by
-
2010-10-17 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
FrameLoader doesn't need an explicit userGesture parameter
https://bugs.webkit.org/show_bug.cgi?id=47777
We used to pass around the user gesture state explicitly. Now we use
static state. Explicitly passing the user gesture state to FrameLoader
in these methods is pretty out-dated.
- bindings/ScriptControllerBase.cpp: (WebCore::ScriptController::executeIfJavaScriptURL):
- bindings/generic/BindingDOMWindow.h: (WebCore::::createWindow): (WebCore::::open):
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::createWindow): (WebCore::JSDOMWindow::open):
- bindings/js/JSDocumentCustom.cpp: (WebCore::JSDocument::setLocation):
- bindings/js/ScriptController.h:
- bindings/v8/ScriptController.h:
- html/HTMLAnchorElement.cpp: (WebCore::handleLinkClick):
- inspector/InspectorController.cpp: (WebCore::InspectorController::openInInspectedWindow):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::changeLocation): (WebCore::FrameLoader::urlSelected): (WebCore::FrameLoader::submitForm):
- loader/FrameLoader.h:
- loader/NavigationScheduler.cpp: (WebCore::ScheduledURLNavigation::fire): (WebCore::ScheduledRefresh::fire): (WebCore::ScheduledHistoryNavigation::fire): (WebCore::NavigationScheduler::scheduleLocationChange):
2010-10-17 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
FrameLoader doesn't need an explicit userGesture parameter
https://bugs.webkit.org/show_bug.cgi?id=47777
Update for the new API.
- WebCoreSupport/WebContextMenuClient.cpp: (WebContextMenuClient::searchWithGoogle):
- 07:31 Changeset [69923] by
-
2010-10-17 Sergey A. Sukiyazov <sergey.sukiyazov@gmail.com>
Reviewed by Andreas Kling
[Qt] Hovering the mouse over links produce a trail of underlined links (X11 paint engine)
https://bugs.webkit.org/show_bug.cgi?id=42248
The problem will appear because coordinates of points may increase by 0.05f (if line width is odd) inside
method GraphicsContext::adjustLineToPixelBoundaries(...) and become outside of text bounding rect htere,
then the new point coordinates will be passed to Qt graphics engine.
The solution decreases Y cordinates of points inside drawLineForText(...) method only if Qt graphics engine
is X11. The Y coordinates will be increase by 0.5f inside method adjustLineToPixelBoundaries(...), which
called from drawLine(...), and then inside Qt painting engine will be rounded to next greater integer value.
NOTE: This changes will affect only Qt X11 verision and if only X11 Painting Engine will be used.
No new tests.
- platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::drawLineForText):
- 03:53 Changeset [69922] by
-
2010-10-17 Rob Buis <rwlbuis@gmail.com>
Reviewed by Dirk Schulze.
Text under nested link dropped
https://bugs.webkit.org/show_bug.cgi?id=46460
Allow links inside of tspan and textPath elements.
- svg/SVGTSpanElement.cpp: (WebCore::SVGTSpanElement::childShouldCreateRenderer):
- svg/SVGTextPathElement.cpp: (WebCore::SVGTextPathElement::childShouldCreateRenderer):
10/16/10:
- 21:47 Changeset [69921] by
-
2010-10-16 Antonio Gomes <agomes@rim.com>
Complementary to r69919.
Unreviewed expectation update for frame flattening tests from the Gtk+ bots.
Basically 3px difference between the results generated on my machine and the ones
from the Gtk+ bots.
- platform/gtk/fast/frames/flattening/frameset-flattening-advanced-expected.txt: Added.
- platform/gtk/fast/frames/flattening/frameset-flattening-grid-expected.txt:
- platform/gtk/fast/frames/flattening/frameset-flattening-simple-expected.txt:
- platform/gtk/fast/frames/flattening/frameset-flattening-subframe-resize-expected.txt:
- platform/gtk/fast/frames/flattening/frameset-flattening-subframesets-expected.txt:
- 21:43 Changeset [69920] by
-
2010-10-16 Kyusun Kim <maniagoon@company100.net>
Reviewed by Alexey Proskuryakov.
Add using declarations for currentTimeMS() and parseDateFromNullTerminatedCharacters()
https://bugs.webkit.org/show_bug.cgi?id=47758
- wtf/CurrentTime.h:
- wtf/DateMath.h:
- 20:51 Changeset [69919] by
-
[Gtk]: DRT does not support frame flattening testing
https://bugs.webkit.org/show_bug.cgi?id=38650
Reviewed by Martin Robinson and Xan Lopez.
Patch by Antonio Gomes <agomes@rim.com>
WebKit/gtk:
Implement enable-frame-flattening API for Gtk+.
- webkit/webkitwebsettings.cpp:
(webkit_web_settings_class_init):
(webkit_web_settings_set_property):
(webkit_web_settings_get_property):
(webkit_web_settings_copy):
- webkit/webkitwebview.cpp:
(webkit_web_view_update_settings):
(webkit_web_view_settings_notify):
WebKitTools:
Implement DRT's support for toggling on/off frame flattening
support.
- DumpRenderTree/gtk/DumpRenderTree.cpp:
(resetDefaultsToConsistentValues):
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::setFrameFlatteningEnabled):
LayoutTests:
Unskipping passing frame flattening tests and adding expected results
for them.
- platform/gtk/Skipped:
- 18:54 Changeset [69918] by
-
2010-10-16 Alex Milowski <alex@milowski.com>
Reviewed by Daniel Bates.
New MathML Baseline for GTK Port
https://bugs.webkit.org/show_bug.cgi?id=47774
New baseline for MathML tests for GTK port.
- platform/gtk/mathml/presentation/attributes-expected.checksum: Added.
- platform/gtk/mathml/presentation/attributes-expected.png: Added.
- platform/gtk/mathml/presentation/attributes-expected.txt:
- platform/gtk/mathml/presentation/fenced-mi-expected.checksum: Added.
- platform/gtk/mathml/presentation/fenced-mi-expected.png: Added.
- platform/gtk/mathml/presentation/fenced-mi-expected.txt: Added.
- platform/gtk/mathml/presentation/fractions-expected.checksum: Added.
- platform/gtk/mathml/presentation/fractions-expected.png: Added.
- platform/gtk/mathml/presentation/fractions-expected.txt:
- platform/gtk/mathml/presentation/fractions-vertical-alignment-expected.checksum: Added.
- platform/gtk/mathml/presentation/fractions-vertical-alignment-expected.png: Added.
- platform/gtk/mathml/presentation/fractions-vertical-alignment-expected.txt:
- platform/gtk/mathml/presentation/mo-expected.checksum: Added.
- platform/gtk/mathml/presentation/mo-expected.png: Added.
- platform/gtk/mathml/presentation/mo-expected.txt:
- platform/gtk/mathml/presentation/over-expected.checksum: Added.
- platform/gtk/mathml/presentation/over-expected.png: Added.
- platform/gtk/mathml/presentation/row-alignment-expected.checksum: Added.
- platform/gtk/mathml/presentation/row-alignment-expected.png: Added.
- platform/gtk/mathml/presentation/row-alignment-expected.txt:
- platform/gtk/mathml/presentation/row-expected.checksum: Added.
- platform/gtk/mathml/presentation/row-expected.png: Added.
- platform/gtk/mathml/presentation/row-expected.txt:
- platform/gtk/mathml/presentation/style-expected.checksum: Added.
- platform/gtk/mathml/presentation/style-expected.png: Added.
- platform/gtk/mathml/presentation/style-expected.txt:
- platform/gtk/mathml/presentation/tokenElements-expected.checksum: Added.
- platform/gtk/mathml/presentation/tokenElements-expected.png: Added.
- platform/gtk/mathml/presentation/tokenElements-expected.txt:
- platform/gtk/mathml/presentation/under-expected.checksum: Added.
- platform/gtk/mathml/presentation/under-expected.png: Added.
- platform/gtk/mathml/presentation/underover-expected.checksum: Added.
- platform/gtk/mathml/presentation/underover-expected.png: Added.
- platform/gtk/mathml/presentation/underover-expected.txt:
- 14:04 Changeset [69917] by
-
[BREWMP] Port TextCodec
https://bugs.webkit.org/show_bug.cgi?id=45797
Reviewed by Kent Tamura.
Implement TextCodec with Brew MP's ICharsetConv.
Only UTF-8 is supported for now.
- platform/text/TextEncoding.cpp:
(WebCore::TextEncoding::encode):
- platform/text/TextEncodingRegistry.cpp:
(WebCore::buildBaseTextCodecMaps):
- platform/text/brew/TextCodecBrew.cpp: Added.
(WebCore::newTextCodecBrew):
(WebCore::TextCodecBrew::registerBaseEncodingNames):
(WebCore::TextCodecBrew::registerBaseCodecs):
(WebCore::TextCodecBrew::registerExtendedEncodingNames):
(WebCore::TextCodecBrew::registerExtendedCodecs):
(WebCore::TextCodecBrew::TextCodecBrew):
(WebCore::TextCodecBrew::~TextCodecBrew):
(WebCore::TextCodecBrew::decode):
(WebCore::TextCodecBrew::encode):
- platform/text/brew/TextCodecBrew.h: Added.
- 13:07 Changeset [69916] by
-
2010-10-16 Patrick Gansterer <paroga@webkit.org>
Unreviewed.
Build fix for !ENABLE(INSPECTOR) after r69844.
- inspector/InspectorState.h: Added ENABLE(INSPECTOR) guard.
- 13:00 Changeset [69915] by
-
2010-10-16 Patrick Gansterer <paroga@webkit.org>
Unreviewed, build fix.
WinCE build fix for r69798.
- platform/text/wince/TextCodecWinCE.cpp: Added missing include.
- 09:48 Changeset [69914] by
-
2010-10-16 Johnny Ding <jnd@chromium.org>
Reviewed by Adam Barth.
Requires a user gesture when opening file choose dialog.
https://bugs.webkit.org/show_bug.cgi?id=47593
Test: fast/forms/input-file-not-open-without-gesture.html
- rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::click):
2010-10-16 Johnny Ding <jnd@chromium.org>
Reviewed by Adam Barth.
Requires a user gesture when opening file choose dialog.
https://bugs.webkit.org/show_bug.cgi?id=47593
- fast/forms/input-file-not-open-without-gesture-expected.txt: Added.
- fast/forms/input-file-not-open-without-gesture.html: Added.
- 08:37 Changeset [69913] by
-
2010-10-16 Alex Milowski <alex@milowski.com>
Reviewed by Kenneth Rohde Christiansen.
The tests were re-baselined as operator padding was adjusted.
- mathml/presentation/fenced-mi.xhtml: Added.
A test for mi vertical alignment in mfenced.
- platform/mac/mathml/presentation/attributes-expected.checksum:
- platform/mac/mathml/presentation/attributes-expected.png:
- platform/mac/mathml/presentation/attributes-expected.txt:
- platform/mac/mathml/presentation/fenced-expected.checksum:
- platform/mac/mathml/presentation/fenced-expected.png:
- platform/mac/mathml/presentation/fenced-expected.txt:
- platform/mac/mathml/presentation/fenced-mi-expected.checksum: Added.
- platform/mac/mathml/presentation/fenced-mi-expected.png: Added.
- platform/mac/mathml/presentation/fenced-mi-expected.txt: Added.
- platform/mac/mathml/presentation/fractions-expected.checksum:
- platform/mac/mathml/presentation/fractions-expected.png:
- platform/mac/mathml/presentation/fractions-expected.txt:
- platform/mac/mathml/presentation/fractions-vertical-alignment-expected.checksum:
- platform/mac/mathml/presentation/fractions-vertical-alignment-expected.png:
- platform/mac/mathml/presentation/fractions-vertical-alignment-expected.txt:
- platform/mac/mathml/presentation/mo-expected.checksum:
- platform/mac/mathml/presentation/mo-expected.png:
- platform/mac/mathml/presentation/mo-expected.txt:
- platform/mac/mathml/presentation/roots-expected.checksum:
- platform/mac/mathml/presentation/roots-expected.png:
- platform/mac/mathml/presentation/roots-expected.txt:
- platform/mac/mathml/presentation/row-alignment-expected.checksum:
- platform/mac/mathml/presentation/row-alignment-expected.png:
- platform/mac/mathml/presentation/row-alignment-expected.txt:
- platform/mac/mathml/presentation/row-expected.checksum:
- platform/mac/mathml/presentation/row-expected.png:
- platform/mac/mathml/presentation/row-expected.txt:
- platform/mac/mathml/presentation/style-expected.checksum:
- platform/mac/mathml/presentation/style-expected.png:
- platform/mac/mathml/presentation/style-expected.txt:
- platform/mac/mathml/presentation/subsup-expected.checksum:
- platform/mac/mathml/presentation/subsup-expected.png:
- platform/mac/mathml/presentation/subsup-expected.txt:
- platform/mac/mathml/presentation/tokenElements-expected.checksum:
- platform/mac/mathml/presentation/tokenElements-expected.png:
- platform/mac/mathml/presentation/tokenElements-expected.txt:
- platform/mac/mathml/presentation/underover-expected.checksum:
- platform/mac/mathml/presentation/underover-expected.png:
- platform/mac/mathml/presentation/underover-expected.txt:
2010-10-16 Alex Milowski <alex@milowski.com>
Reviewed by Kenneth Rohde Christiansen.
Changed the vertical alignment within mfenced to baseline to
match the rest of the containers (e.g. mrow) and adjusted the
operator spacing to 0.1em.
Test: mathml/presentation/fenced-mi.xhtml
- css/mathml.css:
- mathml/RenderMathMLFenced.cpp:
- 03:45 Changeset [69912] by
-
2010-10-16 Patrick Gansterer <paroga@webkit.org>
Reviewed by Adam Barth.
Rename StringHasherFunctions.h to StringHasher.h
https://bugs.webkit.org/show_bug.cgi?id=47200
Now StringHasherFunctions.h only contains the StringHasher class, so rename it to the correct name.
- GNUmakefile.am:
- JavaScriptCore.gypi:
- JavaScriptCore.xcodeproj/project.pbxproj:
- wtf/StringHashFunctions.h: Removed.
- wtf/StringHasher.h: Copied from JavaScriptCore/wtf/StringHashFunctions.h.
- wtf/text/StringHash.h:
- wtf/text/StringImpl.h:
2010-10-16 Patrick Gansterer <paroga@webkit.org>
Reviewed by Adam Barth.
Rename StringHasherFunctions.h to StringHasher.h
https://bugs.webkit.org/show_bug.cgi?id=47200
- ForwardingHeaders/wtf/StringHashFunctions.h: Removed.
- ForwardingHeaders/wtf/StringHasher.h: Copied from JavaScriptGlue/ForwardingHeaders/wtf/StringHashFunctions.h.
2010-10-16 Patrick Gansterer <paroga@webkit.org>
Reviewed by Adam Barth.
Rename StringHasherFunctions.h to StringHasher.h
https://bugs.webkit.org/show_bug.cgi?id=47200
- ForwardingHeaders/wtf/StringHashFunctions.h: Removed.
- ForwardingHeaders/wtf/StringHasher.h: Copied from WebCore/ForwardingHeaders/wtf/StringHashFunctions.h.
10/15/10:
- 22:09 Changeset [69911] by
-
Merge 69907 - 2010-10-15 Kinuko Yasuda <kinuko@google.com>
Reviewed by Jian Li.
Implement FileEntrySync.file() in FileSystem API
https://bugs.webkit.org/show_bug.cgi?id=47310
Tests: fast/filesystem/workers/file-from-file-entry-sync.html
fast/filesystem/workers/file-from-file-entry.html
- 21:10 Changeset [69910] by
-
2010-10-15 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
unlink removes inline style of anchor elements
https://bugs.webkit.org/show_bug.cgi?id=47424
The bug was caused by our not extracting styles when the anchor element is removed by removeInlineStyle.
Because we removed the element without pushing its inline style down, we lost style information.
Fixed the bug by pushing down styles in removeInlineStyle as done in pushDownInlineStyleAroundNode.
Also fixed a bug in addInlineStyleIfNeeded where StyleChange incorrectly removed styles of the container
node as supposed to that of startNode from the style to apply when startNode is not an element.
Test: editing/execCommand/toggle-unlink.html
- editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::removeInlineStyleFromElement): To prevent a similar bug in the future, added an assert that extractedStyle is specified whenever we're removing a styled element. (WebCore::ApplyStyleCommand::removeInlineStyle): (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded):
2010-10-15 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
unlink removes inline style of anchor elements
https://bugs.webkit.org/show_bug.cgi?id=47424
Added a test to ensure execCommand('unlink', false, null) preserves the inline style declaration.
- editing/execCommand/script-tests/toggle-unlink.js: Added. (testSingleToggle): (selectAll): (selectFirstTwoWords): (selectLastTwoWords): (selectLastWord):
- editing/execCommand/toggle-unlink-expected.txt: Added.
- editing/execCommand/toggle-unlink.html: Added.
- editing/style/script-tests/make-text-writing-direction-inline.js: Specifies both direction and unicode-bidi properties instead of just direction property.
- 20:16 Changeset [69909] by
-
2010-10-15 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Tony Chang.
serializeNodesWithNamespaces should be in MarkupAccumulator
https://bugs.webkit.org/show_bug.cgi?id=47749
Moved serializeNodesWithNamespaces to MarkupAccumulator, and renamed it to serializeNodes.
MarkupAccumulator::serializeNode now returns the resultant string instead of having a separate takeResults().
Added several helper functions to MarkupAccumulator.
No new tests are added since this is a cleanup.
- editing/MarkupAccumulator.cpp: (WebCore::MarkupAccumulator::serializeNodes): Wrapper for serializeNodes and concatenateMarkup. (WebCore::MarkupAccumulator::serializeNodesWithNamespaces): Moved from markup.cpp (WebCore::MarkupAccumulator::appendStartTag): Calls appendString instead of appending into m_succeedingMarkup directly. (WebCore::MarkupAccumulator::appendEndTag): Ditto. (WebCore::MarkupAccumulator::totalLength): Added; extracted from takeResults. (WebCore::MarkupAccumulator::concatenateMarkup): Ditto.
- editing/MarkupAccumulator.h: (WebCore::MarkupAccumulator::length): Added; calls totalLength.
- editing/markup.cpp: (WebCore::StyledMarkupAccumulator::appendString): Added; calls MarkupAccumulator's appendString. (WebCore::StyledMarkupAccumulator::wrapWithStyleNode): Calls appendString. (WebCore::StyledMarkupAccumulator::takeResults): Calls length, totalLength, and concatenateMarkup. (WebCore::StyledMarkupAccumulator::serializeNodes): Became a member function. (WebCore::createMarkup): Uses MarkupAccumulator.
- 19:17 Changeset [69908] by
-
Merge 69901 - 2010-10-15 Nico Weber <thakis@chromium.org>
Reviewed by Eric Carlson.
Make sure to update the current graphics context when calling out to AppKit.
https://bugs.webkit.org/show_bug.cgi?id=47757
Like r57741, but for the spellchecking highlight
- platform/graphics/mac/GraphicsContextMac.mm: (WebCore::GraphicsContext::drawLineForTextChecking):
- 19:05 Changeset [69907] by
-
2010-10-15 Kinuko Yasuda <kinuko@google.com>
Reviewed by Jian Li.
Implement FileEntrySync.file() in FileSystem API
https://bugs.webkit.org/show_bug.cgi?id=47310
Tests: fast/filesystem/workers/file-from-file-entry-sync.html
fast/filesystem/workers/file-from-file-entry.html
- fileapi/DOMFileSystem.cpp: (WebCore::DOMFileSystem::createFile): Added.
- fileapi/DOMFileSystem.h:
- fileapi/DOMFileSystemSync.cpp: (WebCore::DOMFileSystemSync::createFile): Added.
- fileapi/DOMFileSystemSync.h:
- fileapi/DirectoryReaderBase.h: Added 'virtual path' comment.
- fileapi/EntryBase.h: Added 'virtual path' comment.
- fileapi/FileEntry.cpp: (WebCore::FileEntry::file): Changed to use DOMFileSystem::createFile.
- fileapi/FileEntrySync.cpp: (WebCore::FileEntrySync::file): Implemented.
- fileapi/FileEntrySync.h:
- fileapi/FileEntrySync.idl: Added file().
2010-10-15 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by Jian Li.
Implement FileEntrySync.file() in FileSystem API
https://bugs.webkit.org/show_bug.cgi?id=47310
- fast/filesystem/file-from-file-entry-expected.txt:
- fast/filesystem/file-from-file-entry.html:
- fast/filesystem/resources/file-from-file-entry-sync.js: Added.
- fast/filesystem/resources/file-from-file-entry.js: Added.
- fast/filesystem/script-tests/file-from-file-entry.js: Moved to resources to make it available for workers tests too.
- fast/filesystem/workers/file-from-file-entry-expected.txt: Added.
- fast/filesystem/workers/file-from-file-entry-sync-expected.txt: Added.
- fast/filesystem/workers/file-from-file-entry-sync.html: Added.
- fast/filesystem/workers/file-from-file-entry.html: Added.
- 18:50 Changeset [69906] by
-
2010-10-15 Oliver Hunt <oliver@apple.com>
Reviewed by Sam Weinig.
Automatic Semicolon Insertion incorrectly inserts semicolon after break, continue, and return followed by a newline
https://bugs.webkit.org/show_bug.cgi?id=47762
The old YACC parser depended on the lexer for some classes of semicolon insertion.
The new parser handles ASI entirely on its own so when the lexer inserts a semicolon
on its own the net result is a spurious semicolon in the input stream. This can result
in incorrect parsing in some cases:
if (0)
break
;else {}
Would result in a parse failure as the output from the lexer is essentially
if (0)
break
;;else
So the second semicolon is interpreted as a empty statement, which terminates the if,
making the else an error.
- parser/JSParser.cpp: (JSC::JSParser::parseThrowStatement): Parsing of throw statement was wrong, and only worked due to the weird behaviour in the lexer
- parser/Lexer.cpp: (JSC::Lexer::lex): Remove bogus semicolon insertion from the newline handling
2010-10-15 Oliver Hunt <oliver@apple.com>
Reviewed by Sam Weinig.
ASI incorrectly inserts semicolon after break, continue, and return followed by a newline
https://bugs.webkit.org/show_bug.cgi?id=47762
tests for correct ASI following break, continue, and return
- fast/js/break-ASI-expected.txt: Added.
- fast/js/break-ASI.html: Added.
- fast/js/script-tests/break-ASI.js: Added.
- 18:31 Changeset [69905] by
-
2010-10-15 Dirk Pranke <dpranke@chromium.org>
Reviewed by Eric Siedel.
mocktool.MockOptions is inheriting from Mock, which has the side
effect of defaulting any attribute to another MockObject. So,
MockOptions().foo would always evaluate to true. This was
covering over bugs in the unit tests, and is probably the wrong
default behavior for anything attempting to mock out the options
argument returned from optparse.parse_args().
This patch changes the default behavior. The new MockOptions()
class takes an optional list of keyword parameters to set; this
patch doesn't use that feature but the fix for bug 47510 will.
Also, this patch just fills in the default values necessary to
get all of the tests to pass; I didn't stare at each test by
hand to determine the "right" values. We can either fix that in
subsequent patches or let me know if we want to do that now (and
give me some guidance on what those values might want to be).
- Scripts/webkitpy/tool/commands/commandtest.py:
- Scripts/webkitpy/tool/commands/download_unittest.py:
- Scripts/webkitpy/tool/commands/upload_unittest.py:
- Scripts/webkitpy/tool/mocktool.py:
- Scripts/webkitpy/tool/steps/steps_unittest.py:
- Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
- 18:15 Changeset [69904] by
-
audio branch: changes in preparation for landing into trunk
- massive munge to change to proper license
- cleanup of delay-related files
- add AudioResamplerKernel files
- lots of cleanup for AudioNodeInput and AudioNodeOutput
- cleanup of AudioResampler
- lots of cleanup for AudioBufferSourceNode
audio branch: last minute cleanup
- 18:08 Changeset [69903] by
-
2010-10-15 Mihai Parparita <mihaip@chromium.org>
Reviewed by James Robinson.
css2.1/ layout tests need new Mac baselines for Snow Leopard
https://bugs.webkit.org/show_bug.cgi?id=47760
Rebaseline 10 css2.1/ test for Snow Leopard using the experimental
local rebaselining tool.
- platform/mac-leopard/css2.1/t010403-shand-border-00-c-expected.checksum: Copied from LayoutTests/platform/mac/css2.1/t010403-shand-border-00-c-expected.checksum.
- platform/mac-leopard/css2.1/t010403-shand-border-00-c-expected.png: Copied from LayoutTests/platform/mac/css2.1/t010403-shand-border-00-c-expected.png.
- platform/mac-leopard/css2.1/t010403-shand-font-00-b-expected.checksum: Copied from LayoutTests/platform/mac/css2.1/t010403-shand-font-00-b-expected.checksum.
- platform/mac-leopard/css2.1/t010403-shand-font-00-b-expected.png: Copied from LayoutTests/platform/mac/css2.1/t010403-shand-font-00-b-expected.png.
- platform/mac-leopard/css2.1/t010403-shand-font-01-b-expected.checksum: Copied from LayoutTests/platform/mac/css2.1/t010403-shand-font-01-b-expected.checksum.
- platform/mac-leopard/css2.1/t010403-shand-font-01-b-expected.png: Copied from LayoutTests/platform/mac/css2.1/t010403-shand-font-01-b-expected.png.
- platform/mac-leopard/css2.1/t010403-shand-font-02-b-expected.checksum: Copied from LayoutTests/platform/mac/css2.1/t010403-shand-font-02-b-expected.checksum.
- platform/mac-leopard/css2.1/t010403-shand-font-02-b-expected.png: Copied from LayoutTests/platform/mac/css2.1/t010403-shand-font-02-b-expected.png.
- platform/mac-leopard/css2.1/t010403-shand-font-03-b-expected.checksum: Copied from LayoutTests/platform/mac/css2.1/t010403-shand-font-03-b-expected.checksum.
- platform/mac-leopard/css2.1/t010403-shand-font-03-b-expected.png: Copied from LayoutTests/platform/mac/css2.1/t010403-shand-font-03-b-expected.png.
- platform/mac-leopard/css2.1/t040102-keywords-00-b-expected.checksum: Copied from LayoutTests/platform/mac/css2.1/t040102-keywords-00-b-expected.checksum.
- platform/mac-leopard/css2.1/t040102-keywords-00-b-expected.png: Copied from LayoutTests/platform/mac/css2.1/t040102-keywords-00-b-expected.png.
- platform/mac-leopard/css2.1/t040102-keywords-01-b-expected.checksum: Copied from LayoutTests/platform/mac/css2.1/t040102-keywords-01-b-expected.checksum.
- platform/mac-leopard/css2.1/t040102-keywords-01-b-expected.png: Copied from LayoutTests/platform/mac/css2.1/t040102-keywords-01-b-expected.png.
- platform/mac-leopard/css2.1/t040103-case-00-b-expected.checksum: Copied from LayoutTests/platform/mac/css2.1/t040103-case-00-b-expected.checksum.
- platform/mac-leopard/css2.1/t040103-case-00-b-expected.png: Copied from LayoutTests/platform/mac/css2.1/t040103-case-00-b-expected.png.
- platform/mac-leopard/css2.1/t040103-case-01-c-expected.checksum: Copied from LayoutTests/platform/mac/css2.1/t040103-case-01-c-expected.checksum.
- platform/mac-leopard/css2.1/t040103-case-01-c-expected.png: Copied from LayoutTests/platform/mac/css2.1/t040103-case-01-c-expected.png.
- platform/mac-leopard/css2.1/t040103-escapes-00-b-expected.checksum: Copied from LayoutTests/platform/mac/css2.1/t040103-escapes-00-b-expected.checksum.
- platform/mac-leopard/css2.1/t040103-escapes-00-b-expected.png: Copied from LayoutTests/platform/mac/css2.1/t040103-escapes-00-b-expected.png.
- platform/mac/css2.1/t010403-shand-border-00-c-expected.checksum:
- platform/mac/css2.1/t010403-shand-border-00-c-expected.png:
- platform/mac/css2.1/t010403-shand-font-00-b-expected.checksum:
- platform/mac/css2.1/t010403-shand-font-00-b-expected.png:
- platform/mac/css2.1/t010403-shand-font-01-b-expected.checksum:
- platform/mac/css2.1/t010403-shand-font-01-b-expected.png:
- platform/mac/css2.1/t010403-shand-font-02-b-expected.checksum:
- platform/mac/css2.1/t010403-shand-font-02-b-expected.png:
- platform/mac/css2.1/t010403-shand-font-03-b-expected.checksum:
- platform/mac/css2.1/t010403-shand-font-03-b-expected.png:
- platform/mac/css2.1/t040102-keywords-00-b-expected.checksum:
- platform/mac/css2.1/t040102-keywords-00-b-expected.png:
- platform/mac/css2.1/t040102-keywords-01-b-expected.checksum:
- platform/mac/css2.1/t040102-keywords-01-b-expected.png:
- platform/mac/css2.1/t040103-case-00-b-expected.checksum:
- platform/mac/css2.1/t040103-case-00-b-expected.png:
- platform/mac/css2.1/t040103-case-01-c-expected.checksum:
- platform/mac/css2.1/t040103-case-01-c-expected.png:
- platform/mac/css2.1/t040103-escapes-00-b-expected.checksum:
- platform/mac/css2.1/t040103-escapes-00-b-expected.png:
- 18:01 Changeset [69902] by
-
Fix Qt build.
- UIProcess/API/qt/qwkpage.cpp:
(QWKPagePrivate::createPopupMenuProxy):
- 17:56 Changeset [69901] by
-
2010-10-15 Nico Weber <thakis@chromium.org>
Reviewed by Eric Carlson.
Make sure to update the current graphics context when calling out to AppKit.
https://bugs.webkit.org/show_bug.cgi?id=47757
Like r57741, but for the spellchecking highlight
- platform/graphics/mac/GraphicsContextMac.mm: (WebCore::GraphicsContext::drawLineForTextChecking):
- 17:50 Changeset [69900] by
-
REGRESSION(r69850) Loading apple.com/startpage in WebKit on Windows gets a bad request.
https://bugs.webkit.org/show_bug.cgi?id=47753
<rdar://problem/8558242>
Reviewed by Sam Weinig.
WebCore:
r69850 switched over to a different way of concatenating WebCore strings, but ran into an issue
where some Windows calls were returning null terminated strings, and this breaks the new
method of concatenation.
GetLocaleInfo returns a null-terminated string, but WebCore strings are non-null terminated,
so once we create our WebCore string, we want to trim off the null terminating character before
we return the localeInfo.
Test: fast/dom/navigator-userAgent.html
- platform/win/Language.cpp:
(WebCore::localeInfo):
WebKit/win:
VerQueryValue returns a null terminated string, but we need to strip off the null terminating character
when we turn it into a WebCore string, or else concatenation using this string will break.
- WebView.cpp:
LayoutTests:
Add a test to make sure that the user agent has some important parts, and is fully formed.
This test tests that the user agent has Mozilla, AppleWebKit, and KHML, like Gecko. If the
user agent has all of these components, the string concatenation worked correctly, and this
bug is fixed.
- fast/dom/navigator-userAgent-expected.txt: Added.
- fast/dom/navigator-userAgent.html: Added.
- 17:47 Changeset [69899] by
-
Popup widget support (<select>)
<rdar://problem/8147746>
https://bugs.webkit.org/show_bug.cgi?id=47740
Reviewed by Anders Carlsson.
Add initial support for popup menus. Only works on the mac at this time.
- Shared/WebPopupItem.cpp: Added.
(WebKit::WebPopupItem::WebPopupItem):
(WebKit::WebPopupItem::encode):
(WebKit::WebPopupItem::decode):
- Shared/WebPopupItem.h: Added.
Serializable representation of a menu item.
- UIProcess/API/mac/PageClientImpl.h:
- UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::createPopupMenuProxy):
Create a WebPopupMenuProxyMac.
- UIProcess/API/qt/qwkpage.cpp:
(WebView::createPopupMenuProxy):
- UIProcess/API/qt/qwkpage_p.h:
Create a WebPopupMenuProxyQt (which is just a stub right now).
(WebKit::WebPopupMenuProxyWin::create):
- UIProcess/win/WebView.cpp:
(WebKit::WebView::createPopupMenuProxy):
- UIProcess/win/WebView.h:
Create a WebPopupMenuProxyWin (which is just a stub right now).
- UIProcess/PageClient.h:
Add new client function to get a platform specific WebPopupMenuProxy.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::close):
(WebKit::WebPageProxy::showPopupMenu):
(WebKit::WebPageProxy::hidePopupMenu):
(WebKit::WebPageProxy::processDidExit):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
Pipe through calls to set up the menu.
- UIProcess/mac/WebPopupMenuProxyMac.h: Added.
(WebKit::WebPopupMenuProxyMac::create):
- UIProcess/mac/WebPopupMenuProxyMac.mm: Added.
(WebKit::WebPopupMenuProxyMac::WebPopupMenuProxyMac):
(WebKit::WebPopupMenuProxyMac::~WebPopupMenuProxyMac):
(WebKit::WebPopupMenuProxyMac::populate):
(WebKit::WebPopupMenuProxyMac::showPopupMenu):
(WebKit::WebPopupMenuProxyMac::hidePopupMenu):
Add UI process side implementation. Currently this does not support
custom fonts as the old implementation did.
- UIProcess/qt/WebPopupMenuProxyQt.cpp: Added.
(WebKit::WebPopupMenuProxyQt::WebPopupMenuProxyQt):
(WebKit::WebPopupMenuProxyQt::~WebPopupMenuProxyQt):
(WebKit::WebPopupMenuProxyQt::showPopupMenu):
(WebKit::WebPopupMenuProxyQt::hidePopupMenu):
- UIProcess/qt/WebPopupMenuProxyQt.h: Added.
(WebKit::WebPopupMenuProxyQt::create):
- UIProcess/win/WebPopupMenuProxyWin.cpp: Added.
(WebKit::WebPopupMenuProxyWin::WebPopupMenuProxyWin):
(WebKit::WebPopupMenuProxyWin::~WebPopupMenuProxyWin):
(WebKit::WebPopupMenuProxyWin::showPopupMenu):
(WebKit::WebPopupMenuProxyWin::hidePopupMenu):
- UIProcess/win/WebPopupMenuProxyWin.h: Added.
Add stubbed out implementations for Qt and windows.
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::createPopupMenu):
(WebKit::WebChromeClient::createSearchPopupMenu):
Pass the page in the create function.
- WebProcess/WebCoreSupport/WebPopupMenu.cpp:
(WebKit::WebPopupMenu::create):
(WebKit::WebPopupMenu::WebPopupMenu):
(WebKit::WebPopupMenu::didChangeSelectedIndex):
(WebKit::WebPopupMenu::populateItems):
(WebKit::WebPopupMenu::show):
(WebKit::WebPopupMenu::hide):
- WebProcess/WebCoreSupport/WebPopupMenu.h:
(WebKit::WebPopupMenu::disconnectFromPage):
- WebProcess/WebCoreSupport/WebSearchPopupMenu.cpp:
(WebKit::WebSearchPopupMenu::create):
(WebKit::WebSearchPopupMenu::WebSearchPopupMenu):
(WebKit::WebSearchPopupMenu::popupMenu):
- WebProcess/WebCoreSupport/WebSearchPopupMenu.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::close):
(WebKit::WebPage::setActivePopupMenu):
(WebKit::WebPage::didChangeSelectedIndexForActivePopupMenu):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
Pipe through calls to set up the menu.
- WebKit2.pro:
- WebKit2.xcodeproj/project.pbxproj:
- win/WebKit2.vcproj:
Add new files.
- 17:40 Changeset [69898] by
-
Trying to fix crashes on Leopard buildbot.
- loader/loader.cpp: (WebCore::Loader::Host::didFinishLoading): (WebCore::Loader::Host::didFail): Moved logging higher in the function - it seems that CachedResource can be already destroyed.
- platform/Logging.cpp: (WebCore::getChannelFromName):
- platform/mac/LoggingMac.mm: (WebCore::InitializeLoggingChannelsIfNecessary): Initialize the new channel (oops).
- 17:14 Changeset [69897] by
-
Fix build.
- UIProcess/API/mac/FindIndicatorWindow.mm:
(-[WebFindIndicatorWindowAnimation setCurrentProgress:]):
- 16:39 Changeset [69896] by
-
2010-10-15 Mike Lawther <mikelawther@chromium.org>
Reviewed by James Robinson.
iframes keep getting scrollbars with scrolling="no"
https://bugs.webkit.org/show_bug.cgi?id=29240
Prevent scrollbars from appearing in iframes with scrolling=no
when the embedded content has overflow:scroll set on the html
or body tags.
- fast/frames/iframe-scrolling-attribute-overflowscroll-expected.txt: Added.
- fast/frames/iframe-scrolling-attribute-overflowscroll.html: Added.
2010-10-15 Mike Lawther <mikelawther@chromium.org>
Reviewed by James Robinson.
Prevent scrollbars from appearing in iframes with scrolling=no
when the embedded content has overflow:scroll set on the html
or body tags.
iframes keep getting scrollbars with scrolling="no"
https://bugs.webkit.org/show_bug.cgi?id=29240
Test: fast/frames/iframe-scrolling-attribute-overflowscroll.html
- page/FrameView.cpp: (WebCore::FrameView::calculateScrollbarModesForLayout) (WebCore::FrameView::updateCanHaveScrollbars): (WebCore::FrameView::layout):
- page/FrameView.h: (WebCore::FrameView::calculateScrollbarModesForLayout)
- 16:33 Changeset [69895] by
-
Make the find indicator window fade out when requested
https://bugs.webkit.org/show_bug.cgi?id=47747
Reviewed by Sam Weinig.
- UIProcess/API/mac/FindIndicatorWindow.h:
- UIProcess/API/mac/FindIndicatorWindow.mm:
Add WebFindIndicatorWindowAnimation - an NSAnimation subclass that takes two
C++ member function pointers and invokes them the animation progress changes and
when the animation stops.
(-[WebFindIndicatorWindowAnimation setCurrentProgress:]):
Call the _animationProgressCallback.
(-[WebFindIndicatorWindowAnimation animationDidEnd:]):
Call the _animationDidEndCallback.
(WebKit::FindIndicatorWindow::FindIndicatorWindow):
Initialize the fade out start timer.
(WebKit::FindIndicatorWindow::setFindIndicator):
When asked to fade out, we start the fade out timer.
(WebKit::FindIndicatorWindow::closeWindow):
Stop the fade out timer and the fade out animation.
(WebKit::FindIndicatorWindow::startFadeOutTimerFired):
Create a fade out animation.
(WebKit::FindIndicatorWindow::fadeOutAnimationCallback):
Update the window alpha.
(WebKit::FindIndicatorWindow::fadeOutAnimationDidEnd):
Close the window.
- 15:52 Changeset [69894] by
-
2010-10-15 Simon Fraser <simon.fraser@apple.com>
Fix the build; need to add new slot to PageUIClient callbacks.
- MiniBrowser/mac/BrowserWindowController.m: (-[BrowserWindowController awakeFromNib]):
- WebKitTestRunner/TestController.cpp: (WTR::createOtherPage): (WTR::TestController::initialize):
- 15:43 Changeset [69893] by
-
2010-10-15 Simon Fraser <simon.fraser@apple.com>
Add Matt Delaney to committers.py.
- Scripts/webkitpy/common/config/committers.py:
- 15:33 Changeset [69892] by
-
2010-10-15 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dan Bernstein.
Add 'didDraw' callback for framerate tracking
https://bugs.webkit.org/show_bug.cgi?id=47478
Hook up the 'didDraw' callback for WebKit2 on Mac.
- UIProcess/API/C/WKPage.h:
- UIProcess/API/mac/WKView.mm: (-[WKView drawRect:]):
- UIProcess/API/qt/qwkpage.cpp: (QWKPage::QWKPage):
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didDraw):
- UIProcess/WebPageProxy.h:
- UIProcess/WebUIClient.cpp: (WebKit::WebUIClient::didDraw):
- UIProcess/WebUIClient.h:
- 15:28 Changeset [69891] by
-
Merge 69883 - FileReader.readAsDataURL should take Blob object
https://bugs.webkit.org/show_bug.cgi?id=47679
Reviewed by Dmitry Titov.
BUG=59409
TEST=none
- 15:27 Changeset [69890] by
-
Clean up RenderFlexibleBox::applyLineClamp()
https://bugs.webkit.org/show_bug.cgi?id=47743
Reviewed by Adele Peterson.
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::applyLineClamp):
- 15:17 Changeset [69889] by
-
Correct ChangeLogs.
- 15:14 Changeset [69888] by
-
Merge 69865 - 2010-10-15 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
Crash in WebCore::ApplyStyleCommand::applyBlockStyle
https://bugs.webkit.org/show_bug.cgi?id=47699
The crash was caused by applyBlockStyle's invalidly assuming that visibleStart and visibleEnd always exist.
Added an early exit to the function when either visibleStart or visibleEnd is null or orphaned.
Test: editing/style/block-style-progress-crash.html
- editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyBlockStyle):
2010-10-15 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
Crash in WebCore::ApplyStyleCommand::applyBlockStyle
https://bugs.webkit.org/show_bug.cgi?id=47699
Added a test to ensure WebKit does not crash when the body is content editable
and justifying a progress element and '>' following the element to the right.
- editing/style/block-style-progress-crash-expected.txt: Added.
- editing/style/block-style-progress-crash.html: Added.
BUG=58832
TBR=rniwa@webkit.org
- 15:12 Changeset [69887] by
-
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=47736
<rdar://problem/8429396> WebCore cache gets corrupted if revalidation request starts at a wrong time
Test: http/tests/cache/stopped-revalidation.html
- loader/loader.cpp: (WebCore::Loader::Host::servePendingRequests): Copied logic for revalidation requests from didFail().
- 15:05 Changeset [69886] by
-
2010-10-15 Alexey Proskuryakov <ap@apple.com>
Reviewed by Darin Adler in <https://bugs.webkit.org/show_bug.cgi?id=47736>.
Add a logging channel for WebCore cache and resource loading.
Test: http/tests/cache/stopped-revalidation.html
- platform/Logging.cpp:
- platform/Logging.h: Added a logging channel for Cache and Loader.
- loader/Cache.cpp: (WebCore::Cache::requestResource): (WebCore::Cache::revalidateResource): (WebCore::Cache::revalidationFailed): (WebCore::Cache::evict):
- loader/CachedResource.cpp: (WebCore::CachedResource::setResourceToRevalidate): (WebCore::CachedResource::switchClientsToRevalidatedResource): (WebCore::CachedResource::mustRevalidate): Added logging.
- loader/loader.cpp: (WebCore::Loader::load): Added logging. (WebCore::Loader::scheduleServePendingRequests): Ditto. (WebCore::Loader::requestTimerFired): Ditto. (WebCore::Loader::servePendingRequests): Ditto. (WebCore::Loader::Host::servePendingRequests): Changed logging to use the new channel. (WebCore::Loader::Host::didFinishLoading): Changed logging to use the new channel. (WebCore::Loader::Host::didFail): Added logging.
- 14:58 Changeset [69885] by
-
2010-10-15 Nate Chapin <japhet@chromium.org>
Unreviewed, Chromium expectations update.
Update results for http://trac.webkit.org/changeset/69872.
- platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.checksum:
- platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.checksum:
- platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.checksum:
- platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.checksum:
- platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.checksum:
- platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.checksum:
- platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.checksum:
- platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.checksum:
- platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.checksum:
- platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.checksum:
- platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.png:
- platform/chromium-mac/svg/custom/repaint-on-constant-size-change-expected.checksum: Added.
- platform/chromium-mac/svg/custom/repaint-on-constant-size-change-expected.png: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.checksum: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.png: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.checksum: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.png: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.checksum: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.png: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.checksum: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.png: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.checksum: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.png: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.checksum: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.png: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.checksum: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.png: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.checksum: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.png: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.checksum: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.checksum: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.png: Added.
- platform/chromium-win/svg/custom/repaint-on-constant-size-change-expected.checksum: Added.
- platform/chromium-win/svg/custom/repaint-on-constant-size-change-expected.png: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.checksum:
- platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.checksum:
- platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.checksum:
- platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.checksum:
- platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.checksum:
- platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.checksum:
- platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.checksum:
- platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.checksum:
- platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.checksum:
- platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.checksum:
- platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.png:
- 14:57 Changeset [69884] by
-
2010-10-15 No'am Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Simon Fraser.
Add public functions to serialize TransformOperations.
https://bugs.webkit.org/show_bug.cgi?id=47728
Added public accessors to the internal data of the TransformOperations.
No new tests. These functions are enablers for WebKit2.
- platform/graphics/transforms/Matrix3DTransformOperation.h: (WebCore::Matrix3DTransformOperation::matrix):
- platform/graphics/transforms/MatrixTransformOperation.h: (WebCore::MatrixTransformOperation::matrix):
- platform/graphics/transforms/PerspectiveTransformOperation.h: (WebCore::PerspectiveTransformOperation::perspective):
- platform/graphics/transforms/RotateTransformOperation.h: (WebCore::RotateTransformOperation::x): (WebCore::RotateTransformOperation::y): (WebCore::RotateTransformOperation::z):
- platform/graphics/transforms/SkewTransformOperation.h: (WebCore::SkewTransformOperation::angleX): (WebCore::SkewTransformOperation::angleY):
- platform/graphics/transforms/TranslateTransformOperation.h: (WebCore::TranslateTransformOperation::x): (WebCore::TranslateTransformOperation::y): (WebCore::TranslateTransformOperation::z):
- 14:46 Changeset [69883] by
-
FileReader.readAsDataURL should take Blob object
https://bugs.webkit.org/show_bug.cgi?id=47679
Reviewed by Dmitry Titov.
WebCore:
Test cases have been added into read-blob-test-cases.js.
- fileapi/FileReader.idl: Update per the latest File API spec.
LayoutTests:
- fast/files/read-blob-async-expected.txt:
- fast/files/resources/read-blob-test-cases.js:
(testReadingSingleTextBlobAsDataURL):
(testReadingSingleTextBlobAsDataURL2):
(testReadingTripleSlicedHybridBlob):
- fast/files/resources/read-common.js:
(buildBlob):
- fast/files/workers/worker-read-blob-async-expected.txt:
- fast/files/workers/worker-read-blob-sync-expected.txt:
- 14:38 Changeset [69882] by
-
Merge 69615 - Unreview. Build fix for chromium.
- public/WebBlobRegistry.h:
BUG=59391
TEST=none
- 14:36 Changeset [69881] by
-
Merge 69611 - [chromium] Update WebBlobData to adapt to BlobData change in terms of
handling string data item.
https://bugs.webkit.org/show_bug.cgi?id=47423
Reviewed by Darin Fisher.
Also remove unneeded methods in WebBlobData. WebBlobStorageData.* are
also removed since they're not longer needed.
BUG=59391
TEST=none
- 14:34 Changeset [69880] by
-
2010-10-15 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Move MarkupAccumulator from markup.cpp to its own file
https://bugs.webkit.org/show_bug.cgi?id=47734
This patch moves the MarkupAccumulator class into its own file.
There's a lot of clean up left to do, but this patch is a step in the
right direction.
No behavior change.
- Android.mk:
- CMakeLists.txt:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- editing/markup.cpp: (WebCore::elementCannotHaveEndTag):
- editing/markup.h:
- editing/MarkupAccumulator.h: Added.
- editing/MarkupAccumulator.cpp: Added.
- 14:34 Changeset [69879] by
-
Merge 69610 - Fix passing blob data with string data item between threads.
https://bugs.webkit.org/show_bug.cgi?id=46543
Reviewed by David Levin.
The fix is to use a thread-safe ref-counted Vector<char> to store the
string data. This also makes us be able to store any binary data in it.
I've also fix BlobBuilder and BlobRegistryImpl to avoid some additional
copies to make blob handling faster.
BUG=59391
TEST=none
- 14:31 Changeset [69878] by
-
Move find indicator window logic to WKView
https://bugs.webkit.org/show_bug.cgi?id=47739
Reviewed by Sam Weinig.
- UIProcess/API/mac/PageClientImpl.h:
- UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::setFindIndicator):
Call -[WKView _setFindIndicator:fadeOut:].
- UIProcess/API/mac/WKView.mm:
(-[WKView renewGState]):
Hide the find indicator.
(-[WKView _setFindIndicator:fadeOut:]):
Move the find indicator logic here.
- 14:05 Changeset [69877] by
-
Hide the find indicator/overlay when necessary
https://bugs.webkit.org/show_bug.cgi?id=47737
Reviewed by Sam Weinig.
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::invalidateContentsForSlowScroll):
Hide the find indicator.
(WebKit::WebChromeClient::scroll):
Ditto.
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
Hide the find indicator and the find overlay.
- WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::findString):
Always hide all previous find matches. Only clear the selection if the string
not found wasn't empty.
(WebKit::FindController::hideFindUI):
Uninstall the page overlay and hide the find indicator.
(WebKit::FindController::hideFindIndicator):
Rename resetFindIndicator to hideFindIndicator.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::uninstallPageOverlay):
Invalidate the entire page.
- 13:53 Changeset [69876] by
-
2010-10-15 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
Match the elements supported by execCommand('formatBlock') and queryCommandValue('formatBlock')
https://bugs.webkit.org/show_bug.cgi?id=47712
Extended queryCommandValue('formatBlock', false, null) to support article, aside, blockquote, dd, dl,
div, dl, dt, dl, footer, header, hgroup, nav, and section. Because this makes isElementForFormatBlockCommand
in Editor.cpp and FormatBlockCommand::isElementToApplyInFormatBlockCommand identical, they are merged and moved
to FormatBlockCommand.cpp
Tests are added to editing/execCommand/query-format-block.html
- editing/Editor.cpp: Removed isElementForFormatBlockCommand and Editor::elementForFormatBlockCommand.
- editing/Editor.h:
- editing/EditorCommand.cpp: (WebCore::executeFormatBlock): Removed the check of tag name; the check is moved into FormatBlockCommand. (WebCore::valueFormatBlock): Calls FormatBlockCommand::elementForFormatBlockCommand.
- editing/FormatBlockCommand.cpp: (WebCore::isElementForFormatBlock): (WebCore::FormatBlockCommand::FormatBlockCommand): (WebCore::FormatBlockCommand::formatSelection): Added to check the tag name. Exit early if the specified tag name is not what FormatBlock should apply. Set m_didApply true if m_didApply did apply the element. (WebCore::FormatBlockCommand::formatRange): Moved from Editor.cpp. Takes Range* instead of accessing selection directly. (WebCore::FormatBlockCommand::elementForFormatBlockCommand): Moved from Editor.cpp (WebCore::enclosingBlockToSplitTreeTo): Calls isElementForFormatBlock.
- editing/FormatBlockCommand.h: (WebCore::FormatBlockCommand::didApply): Added.
2010-10-15 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
Match the elements supported by execCommand('formatBlock') and queryCommandValue('formatBlock')
https://bugs.webkit.org/show_bug.cgi?id=47712
Added queryCommandValue('formatBlock') tests for support article, aside, blockquote, dd, dl, div,
dl, dt, dl, footer, header, hgroup, nav, and section.
Also added tests to ensure we don't return tag name for a subset of unsupported elements.
- editing/execCommand/query-format-block-expected.txt:
- editing/execCommand/script-tests/query-format-block.js: (queryFormatBlock): (selectFirstPosition): (selectMiddleOfHelloWorld):
- 13:39 Changeset [69875] by
-
2010-10-15 Martin Robinson <mrobinson@igalia.com>
Rebaseline two GTK+ tests.
- platform/gtk/fast/forms/mailto/advanced-get-expected.txt:
- platform/gtk/fast/forms/mailto/advanced-put-expected.txt:
- 13:02 Changeset [69874] by
-
2010-10-15 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
carto.net Dock example redraws *way* too often
https://bugs.webkit.org/show_bug.cgi?id=16090
Setting the attributes x, y, width or height shouldn't cause a repaint if the image boundaries don't change.
Added updateFromElement() to RenderSVGImage that checks if the old boundaries match the new boundaries after
setting one of the attributes of above. Mark renderer for layout (and therefore repaint) if the boundaries
differ, do nothing if not.
Also added caching of the repaint rect to avoid multiple calculations.
Test: svg/custom/repaint-on-constant-size-change.svg
- rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::RenderSVGImage): (WebCore::RenderSVGImage::layout): Update repaint rect on layout. (WebCore::RenderSVGImage::updateFromElement): Check SVGImageElement for boundaries update.
- rendering/RenderSVGImage.h: (WebCore::RenderSVGImage::repaintRectInLocalCoordinates): Return the cached repaint rect.
- svg/SVGImageElement.cpp: (WebCore::SVGImageElement::svgAttributeChanged): Call updateFromElement() on changes to x, y, width or height.
2010-10-15 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
carto.net Dock example redraws *way* too often
https://bugs.webkit.org/show_bug.cgi?id=16090
Added a repaint example to make sure that setting the attributes x, y, width or height
doens't cause a repaint if the boundaries don't change.
- platform/mac/svg/custom/repaint-on-constant-size-change-expected.checksum: Added.
- platform/mac/svg/custom/repaint-on-constant-size-change-expected.png: Added.
- platform/mac/svg/custom/repaint-on-constant-size-change-expected.txt: Added.
- svg/custom/repaint-on-constant-size-change.svg: Added.
- 12:57 Changeset [69873] by
-
2010-10-15 Martin Robinson <mrobinson@igalia.com>
Build fix for GTK+.
- platform/network/soup/cache/webkit/soup-cache.h: Do not use PLATFORM(...) macro in a file that does not include config.h
- 12:46 Changeset [69872] by
-
2010-10-15 Dirk Schulze <krit@webkit.org>
Unreviewed rebaseline of Snow Leopard.
Moved current results for SVGFEConvolveMatrixElement to mac-leopard.
- platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.checksum: Added.
- platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.png: Added.
- platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.checksum: Added.
- platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.png: Added.
- platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.checksum: Added.
- platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.png: Added.
- platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.checksum: Added.
- platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.png: Added.
- platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.checksum: Added.
- platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.png: Added.
- platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.checksum: Added.
- platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.png: Added.
- platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.checksum: Added.
- platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.png: Added.
- platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.checksum: Added.
- platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.png: Added.
- platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.checksum: Added.
- platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png: Added.
- platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.checksum: Added.
- platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.png:
- platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.png:
- platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.png:
- platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.png:
- platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.png:
- platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.png:
- platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.png:
- platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.png:
- platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png:
- platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.checksum:
- platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.png:
- 12:16 Changeset [69871] by
-
Add FindIndicatorWindow class
https://bugs.webkit.org/show_bug.cgi?id=47731
Reviewed by Sam Weinig.
WebCore:
Export symbols needed by the FindIndicator in WebKit2.
- WebCore.exp.in:
WebKit2:
- UIProcess/API/mac/FindIndicatorWindow.h: Added.
- UIProcess/API/mac/FindIndicatorWindow.mm: Added.
(-[WebFindIndicatorView _initWithFindIndicator:WebKit::]):
Initialize the find indicator view.
(-[WebFindIndicatorView drawRect:]):
Ask the find indicator to draw.
(-[WebFindIndicatorView isFlipped]):
Return YES.
(WebKit::FindIndicatorWindow::~FindIndicatorWindow):
Make sure to close the window.
(WebKit::FindIndicatorWindow::setFindIndicator):
Update the find indicator window.
(WebKit::FindIndicatorWindow::closeWindow):
Close and release the window.
- UIProcess/API/mac/PageClientImpl.h:
- UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::setFindIndicator):
Create a find indicator window.
- WebKit2.xcodeproj/project.pbxproj:
Add new files.
- 11:48 Changeset [69870] by
-
2010-10-15 Tony Chang <tony@chromium.org>
Reviewed by Kent Tamura.
[chromium] compile TestNetscapePlugIn on Chromium mac
https://bugs.webkit.org/show_bug.cgi?id=47633
- WebKit.gyp: Add a mac specific target for compiling TestNetscapePlugIn
Fix an include dir so we can compile in a chromium checkout.
2010-10-15 Tony Chang <tony@chromium.org>
Reviewed by Kent Tamura.
[chromium] compile TestNetscapePlugIn on Chromium mac
https://bugs.webkit.org/show_bug.cgi?id=47633
- DumpRenderTree/DumpRenderTree.gypi: files to compile
- DumpRenderTree/TestNetscapePlugIn/main.cpp: Use ifdef because gcc was complaining (NP_GetEntryPoints): (NPP_New): (NPP_Destroy): (NPP_HandleEvent): (NPP_GetValue):
- DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: Added.
- DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Added.
- DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h: Added.
- 11:42 Changeset [69869] by
-
2010-10-15 Leandro Pereira <leandro@profusion.mobi>
[EFL] Unreviewed. Build fix.
Add new files needed by the Soup network backend, and #ifdef a
GTK+-port only include in soup-cache.h.
- CMakeListsEfl.txt:
- platform/network/soup/cache/webkit/soup-cache.h:
- 11:30 Changeset [69868] by
-
2010-10-14 Darin Adler <darin@apple.com>
Reviewed by Alexey Proskuryakov.
Use more specific types for node pointers, especially when calling node insertion and removal functions
https://bugs.webkit.org/show_bug.cgi?id=47702
Refactoring. No new tests.
While developing this patch I temporarily removed the node insertion and
removal member functions from the Node class and fixed almost all call sites
so they call it directly on the ContainerNode class, which will be important
once we make the functions non-virtual.
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkSelector):
- dom/ContainerNode.cpp: (WebCore::ContainerNode::insertBefore): (WebCore::ContainerNode::replaceChild): (WebCore::ContainerNode::appendChild):
- dom/Document.cpp: (WebCore::Document::caretRangeFromPoint):
- dom/DynamicNodeList.cpp: (WebCore::DynamicNodeList::itemWithName):
- dom/Position.cpp: (WebCore::Position::previous): (WebCore::Position::next):
- dom/Text.cpp: (WebCore::Text::replaceWholeText):
- dom/TreeWalker.cpp: (WebCore::TreeWalker::firstChild): (WebCore::TreeWalker::lastChild): (WebCore::TreeWalker::previousNode):
- dom/XMLDocumentParserLibxml2.cpp: (WebCore::XMLDocumentParser::XMLDocumentParser):
- editing/BreakBlockquoteCommand.cpp: (WebCore::BreakBlockquoteCommand::doApply):
- editing/CompositeEditCommand.h:
- editing/DeleteButtonController.cpp: (WebCore::isDeletableElement):
- editing/IndentOutdentCommand.cpp: (WebCore::IndentOutdentCommand::outdentParagraph):
- editing/InsertNodeBeforeCommand.cpp: (WebCore::InsertNodeBeforeCommand::doApply):
- editing/JoinTextNodesCommand.cpp: (WebCore::JoinTextNodesCommand::doApply): (WebCore::JoinTextNodesCommand::doUnapply):
- editing/MergeIdenticalElementsCommand.cpp: (WebCore::MergeIdenticalElementsCommand::doUnapply):
- editing/RemoveNodeCommand.cpp: (WebCore::RemoveNodeCommand::doApply): (WebCore::RemoveNodeCommand::doUnapply):
- editing/RemoveNodeCommand.h:
- editing/SplitElementCommand.cpp: (WebCore::SplitElementCommand::executeApply):
- editing/SplitTextNodeCommand.cpp: (WebCore::SplitTextNodeCommand::doApply): (WebCore::SplitTextNodeCommand::doReapply):
- editing/TextIterator.cpp: (WebCore::parentCrossingShadowBoundaries):
- editing/htmlediting.cpp: (WebCore::enclosingList):
- editing/markup.cpp: (WebCore::serializeNodes): (WebCore::ancestorToRetainStructureAndAppearance): (WebCore::createMarkup):
- html/HTMLAreaElement.cpp: (WebCore::HTMLAreaElement::updateFocusAppearance):
- html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::rendererIsNeeded):
- html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::rendererIsNeeded):
- html/HTMLFrameSetElement.cpp: (WebCore::HTMLFrameSetElement::attach):
- html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::insertedIntoTree):
- html/HTMLLegendElement.cpp: (WebCore::HTMLLegendElement::associatedControl):
- html/HTMLOptGroupElement.cpp: (WebCore::HTMLOptGroupElement::recalcSelectOptions): (WebCore::HTMLOptGroupElement::ownerSelectElement):
- html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::ownerSelectElement):
- html/HTMLTableCellElement.cpp: (WebCore::HTMLTableCellElement::additionalAttributeStyleDecls):
- html/HTMLTableColElement.cpp: (WebCore::HTMLTableColElement::additionalAttributeStyleDecls):
- html/HTMLTableElement.cpp: (WebCore::HTMLTableElement::insertRow):
- html/HTMLTableRowElement.cpp: (WebCore::HTMLTableRowElement::rowIndex):
- html/HTMLTableSectionElement.cpp: (WebCore::HTMLTableSectionElement::additionalAttributeStyleDecls):
- page/DOMSelection.cpp: (WebCore::DOMSelection::getRangeAt): (WebCore::DOMSelection::containsNode):
- rendering/RenderSVGGradientStop.cpp: (WebCore::RenderSVGGradientStop::gradientElement):
- svg/SVGElement.cpp: (WebCore::SVGElement::ownerSVGElement): (WebCore::SVGElement::viewportElement):
- svg/SVGFELightElement.cpp: (WebCore::SVGFELightElement::svgAttributeChanged): (WebCore::SVGFELightElement::childrenChanged):
- svg/SVGFEMergeNodeElement.cpp: (WebCore::SVGFEMergeNodeElement::svgAttributeChanged):
- svg/SVGFontFaceFormatElement.cpp: (WebCore::SVGFontFaceFormatElement::childrenChanged):
- svg/SVGFontFaceUriElement.cpp: (WebCore::SVGFontFaceUriElement::childrenChanged):
- svg/SVGGlyphElement.cpp: (WebCore::SVGGlyphElement::invalidateGlyphCache):
- svg/SVGHKernElement.cpp: (WebCore::SVGHKernElement::insertedIntoDocument): (WebCore::SVGHKernElement::removedFromDocument):
- svg/SVGLocatable.cpp: (WebCore::SVGLocatable::nearestViewportElement): (WebCore::SVGLocatable::farthestViewportElement):
- svg/SVGUseElement.cpp: (WebCore::SVGUseElement::updateContainerOffsets):
- svg/SVGVKernElement.cpp: (WebCore::SVGVKernElement::insertedIntoDocument): (WebCore::SVGVKernElement::removedFromDocument):
- svg/animation/SVGSMILElement.cpp: (WebCore::SVGSMILElement::targetElement):
- wml/WMLDoElement.cpp: (WebCore::WMLDoElement::insertedIntoDocument): (WebCore::WMLDoElement::removedFromDocument):
- wml/WMLNoopElement.cpp: (WebCore::WMLNoopElement::insertedIntoDocument):
- wml/WMLOptionElement.cpp: (WebCore::ownerSelectElement):
- wml/WMLPostfieldElement.cpp: (WebCore::WMLPostfieldElement::insertedIntoDocument): (WebCore::WMLPostfieldElement::removedFromDocument):
- wml/WMLSetvarElement.cpp: (WebCore::WMLSetvarElement::insertedIntoDocument): (WebCore::WMLSetvarElement::removedFromDocument):
- wml/WMLTaskElement.cpp: (WebCore::WMLTaskElement::insertedIntoDocument): (WebCore::WMLTaskElement::removedFromDocument):
- wml/WMLTimerElement.cpp: (WebCore::WMLTimerElement::insertedIntoDocument): (WebCore::WMLTimerElement::removedFromDocument):
- xml/XPathStep.cpp: (WebCore::XPath::Step::nodesInAxis): Use ContainerNode* for the result of the parentNode function now that it returns a ContainerNode*. In the past it used to return just Node*.
- dom/ContainerNode.h: Added toContainerNode.
- dom/Element.h: Use ContainerNode*. Added toElement.
- dom/Element.cpp: (WebCore::Element::deprecatedCreateContextualFragment): Explcitly cast to HTMLElement* in the case that handles <html> and <body> elements. (WebCore::Element::baseURI): Use ContainerNode*.
- dom/Node.cpp: (WebCore::Node::markAncestorsWithChildNeedsStyleRecalc): Use ContainerNode*. (WebCore::Node::isDescendantOf): Ditto. (WebCore::Node::createRendererIfNeeded): Ditto. (WebCore::Node::setTextContent): Use already-typecast pointer in a call to appendChild. (WebCore::Node::ancestorElement): Use ContainerNode*.
- dom/Range.cpp: (WebCore::Range::compareNode): Use ContainerNode*. (WebCore::Range::intersectsNode): Ditto. (WebCore::Range::processContents): Cast to ContainerNode* in a couple cases where we previously checked that the node in question has a child. Any node that returns a non-zero value for firstChild is a ContainerNode. (WebCore::Range::checkNodeBA): Ditto. (WebCore::Range::selectNode): Ditto. (WebCore::Range::surroundContents): Ditto.
- dom/XMLDocumentParser.cpp: (WebCore::XMLDocumentParser::insertErrorMessageBlock): Rewrote code to use more specific types, document instead of doc, and paragraph instead of par.
- editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::removeStyleFromRunBeforeApplyingStyle): Use ContainerNode*. (WebCore::ApplyStyleCommand::replaceWithSpanOrRemoveIfWithoutAttributes): Use replaceElementWithSpanPreservingChildrenAndAttributes; the old function took a Node argument and had Node in its name.
- editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::removeNodeAndPruneAncestors): Use ContainerNode. (WebCore::CompositeEditCommand::replaceElementWithSpanPreservingChildrenAndAttributes): Renamed and changed to take HTMLElement. Also use ContainerNode. (WebCore::CompositeEditCommand::prune): Ditto. (WebCore::CompositeEditCommand::breakOutOfEmptyListItem): Ditto. (WebCore::CompositeEditCommand::breakOutOfEmptyMailBlockquotedParagraph): Ditto.
- editing/ReplaceNodeWithSpanCommand.cpp: (WebCore::ReplaceNodeWithSpanCommand::ReplaceNodeWithSpanCommand): Take an HTMLElement instead of a Node. Call it m_elementToReplace instead of m_node. (WebCore::swapInNodePreservingAttributesAndChildren): Take HTMLElement. (WebCore::ReplaceNodeWithSpanCommand::doApply): Updated for name changes. (WebCore::ReplaceNodeWithSpanCommand::doUnapply): Ditto.
- editing/ReplaceNodeWithSpanCommand.h: Ditto.
- editing/ReplaceSelectionCommand.cpp: (WebCore::ReplacementFragment::ReplacementFragment): Use StyledElement for result of insertFragmentForTestRendering since that's what it returns. (WebCore::ReplacementFragment::removeNode): Use ContainerNode. (WebCore::ReplacementFragment::insertNodeBefore): Ditto. (WebCore::ReplacementFragment::insertFragmentForTestRendering): Return StyledElement. Use HTMLElement for body. (WebCore::ReplacementFragment::restoreTestRenderingNodesToFragment): Take StyledElement. (WebCore::ReplaceSelectionCommand::handleStyleSpans): Use ContainerNode. (WebCore::ReplaceSelectionCommand::copyStyleToChildren): Use HTMLElement for the cloned span, since the clone will be a sspan too. (WebCore::ReplaceSelectionCommand::insertAsListItems): Use ContainerNode since the list item has a child, and that proves it is a ContainerNode.
- editing/SelectionController.cpp: (WebCore::SelectionController::selectFrameElementInParentIfFullySelected): Use ContainerNode and also removed an unnneded local variable.
- html/HTMLElement.cpp: (WebCore::HTMLElement::setOuterText): Use ContainerNode. (WebCore::HTMLElement::insertAdjacent): Use ContainerNode and also use && to make the logic a little simpler. (WebCore::contextElementForInsertion): Use ContainerNode. (WebCore::HTMLElement::findFormAncestor): Ditto.
- inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::removeNode): Use ContainerNode. (WebCore::InspectorDOMAgent::changeTagName): Ditto. (WebCore::InspectorDOMAgent::setOuterHTML): Ditto. (WebCore::InspectorDOMAgent::innerParentNode): Use isDocumentNode instead of nodeType. We should almost never use nodeType inside the engine. (WebCore::InspectorDOMAgent::didInsertDOMNode): Use ContainerNode. (WebCore::InspectorDOMAgent::didRemoveDOMNode): Ditto.
- wml/WMLOptGroupElement.cpp: Removed unneeded overrides of insertBefore, replaceChild, removeChild, appendChild, and removeChildren functions. Ths already overrides childrenChanged, that is called by all of the above, and it does the same thing these functions did. (WebCore::ownerSelectElement): Use ContainerNode.
- wml/WMLOptGroupElement.h: Ditto.
- 11:18 Changeset [69867] by
-
2010-10-14 John Abd-El-Malek <jam@chromium.org>
Reviewed by Tony Chang.
[chromium] null check the widget before sending it data as calling didReceiveData might delete it
https://bugs.webkit.org/show_bug.cgi?id=47708
- src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::committedLoad):
- 11:12 Changeset [69866] by
-
[GTK] Fix introspection support
https://bugs.webkit.org/show_bug.cgi?id=47723
Patch by Sergio Villar Senin <svillar@igalia.com> on 2010-10-15
Reviewed by Martin Robinson.
Added HTTP cache directory to the WebkitGtk+ GIR sources.
- GNUmakefile.am:
- 11:05 Changeset [69865] by
-
2010-10-15 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
Crash in WebCore::ApplyStyleCommand::applyBlockStyle
https://bugs.webkit.org/show_bug.cgi?id=47699
The crash was caused by applyBlockStyle's invalidly assuming that visibleStart and visibleEnd always exist.
Added an early exit to the function when either visibleStart or visibleEnd is null or orphaned.
Test: editing/style/block-style-progress-crash.html
- editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyBlockStyle):
2010-10-15 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
Crash in WebCore::ApplyStyleCommand::applyBlockStyle
https://bugs.webkit.org/show_bug.cgi?id=47699
Added a test to ensure WebKit does not crash when the body is content editable
and justifying a progress element and '>' following the element to the right.
- editing/style/block-style-progress-crash-expected.txt: Added.
- editing/style/block-style-progress-crash.html: Added.
- 10:53 Changeset [69864] by
-
2010-10-15 Alejandro G. Castro <alex@igalia.com>
Unreviewed, skipped flaky tests, added followup bug:
https://bugs.webkit.org/show_bug.cgi?id=47727
- platform/gtk/Skipped:
- 10:37 Changeset [69863] by
-
2010-10-15 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Gustavo Noronha Silva.
build-webkit: Should die when make fails when build a CMake project
https://bugs.webkit.org/show_bug.cgi?id=47726
- Scripts/webkitdirs.pm: If make fails, die immediately.
- 10:27 Changeset [69862] by
-
Add a FindIndicator class
https://bugs.webkit.org/show_bug.cgi?id=47635
Reviewed by Sam Weinig.
WebCore:
Make Gradient.h and Generator.h private headers; they're used by WebKit2.
- WebCore.xcodeproj/project.pbxproj:
WebKit2:
- Shared/BackingStore.h:
(WebKit::BackingStore::bounds):
New function that returns the bounds of the backing store.
- UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::setFindIndicator):
Add stub.
- UIProcess/API/qt/qwkpage.cpp:
(QWKPagePrivate::setFindIndicator):
Add stub.
- UIProcess/FindIndicator.cpp: Added.
- UIProcess/FindIndicator.h:
- UIProcess/PageClient.h:
Add setFindIndicator client member function.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::setFindIndicator):
Call PageClient::setFindIndicator.
- UIProcess/WebPageProxy.messages.in:
Add a fadeOut boolean to the message.
- UIProcess/win/WebView.cpp:
(WebKit::WebView::setFindIndicator):
Add stub.
- UIProcess/win/WebView.h:
- WebKit2.pro:
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::findString):
(WebKit::FindController::updateFindIndicator):
(WebKit::FindController::resetFindIndicator):
- WebProcess/WebPage/FindController.h:
- win/WebKit2.vcproj:
- 10:12 Changeset [69861] by
-
2010-10-15 Sergio Villar Senin <svillar@igalia.com>
Reviewed by Gustavo Noronha Silva.
[Soup] Should not ignore body for redirection responses
https://bugs.webkit.org/show_bug.cgi?id=29299
Tests that 302 redirections without Location do not ignore the
body for redirection purpouses (the body could have a meta
http-equiv=refresh)
- http/tests/navigation/redirect302-metaredirect-expected.txt: Added.
- http/tests/navigation/redirect302-metaredirect.html: Added.
- http/tests/navigation/resources/redirect302-metaredirect.html: Added.
- http/tests/navigation/resources/redirect302-metaredirect.pl: Added.
2010-10-15 Sergio Villar Senin <svillar@igalia.com>
Reviewed by Gustavo Noronha Silva.
[Soup] Should not ignore body for redirection responses
https://bugs.webkit.org/show_bug.cgi?id=29299
Body is now provided to WebKitGtk+ in some redirections (like 302)
because it could be used by servers to perform clunky redirections
for example using http-equiv=REFRESH
Test: http/tests/navigation/redirect302-metaredirect.html
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::gotHeadersCallback): (WebCore::finishedCallback):
- 10:06 Changeset [69860] by
-
2010-10-15 Nate Chapin <japhet@chromium.org>
Unreviewed, Chromium expectations tweak.
- platform/chromium/test_expectations.txt:
- 09:54 Changeset [69859] by
-
BUG=58992
IndexedDB should fire some errors synchronously
https://bugs.webkit.org/show_bug.cgi?id=47530
Reviewed by Nate Chapin.
LayoutTests:
- storage/indexeddb/objectstore-basics-expected.txt:
- storage/indexeddb/objectstore-basics.html:
- storage/indexeddb/objectstore-removeobjectstore-expected.txt:
- storage/indexeddb/objectstore-removeobjectstore.html:
WebCore:
Add dumb plumbing to pass around exception codes.
Utilize that plumbing in the backend to fire some
errors synchronously.
Verify that create/remove* functions are only called
in setVersionTransactions (and raise when not).
Remove plumbing for obsolete IDBDatabase.objectStore
Remove obsolete mode param.
- storage/IDBCursor.cpp:
(WebCore::IDBCursor::update):
(WebCore::IDBCursor::continueFunction):
(WebCore::IDBCursor::remove):
- storage/IDBCursor.h:
(WebCore::IDBCursor::continueFunction):
- storage/IDBCursor.idl:
- storage/IDBCursorBackendImpl.cpp:
(WebCore::IDBCursorBackendImpl::update):
(WebCore::IDBCursorBackendImpl::continueFunction):
(WebCore::IDBCursorBackendImpl::remove):
- storage/IDBCursorBackendImpl.h:
- storage/IDBCursorBackendInterface.h:
- storage/IDBDatabase.cpp:
(WebCore::IDBDatabase::IDBDatabase):
(WebCore::IDBDatabase::createObjectStore):
(WebCore::IDBDatabase::removeObjectStore):
(WebCore::IDBDatabase::setVersion):
(WebCore::IDBDatabase::transaction):
- storage/IDBDatabase.h:
(WebCore::IDBDatabase::createObjectStore):
(WebCore::IDBDatabase::transaction):
- storage/IDBDatabase.idl:
- storage/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::createObjectStore):
(WebCore::IDBDatabaseBackendImpl::objectStore):
(WebCore::IDBDatabaseBackendImpl::removeObjectStore):
(WebCore::IDBDatabaseBackendImpl::setVersion):
(WebCore::IDBDatabaseBackendImpl::transaction):
- storage/IDBDatabaseBackendImpl.h:
- storage/IDBDatabaseBackendInterface.h:
- storage/IDBFactory.cpp:
(WebCore::IDBFactory::open):
- storage/IDBFactory.h:
(WebCore::IDBFactory::open):
- storage/IDBFactory.idl:
- storage/IDBIndex.cpp:
(WebCore::IDBIndex::openCursor):
(WebCore::IDBIndex::openKeyCursor):
(WebCore::IDBIndex::get):
(WebCore::IDBIndex::getKey):
- storage/IDBIndex.h:
(WebCore::IDBIndex::openCursor):
(WebCore::IDBIndex::openKeyCursor):
- storage/IDBIndex.idl:
- storage/IDBIndexBackendImpl.cpp:
(WebCore::IDBIndexBackendImpl::openCursor):
(WebCore::IDBIndexBackendImpl::openKeyCursor):
(WebCore::IDBIndexBackendImpl::get):
(WebCore::IDBIndexBackendImpl::getKey):
- storage/IDBIndexBackendImpl.h:
- storage/IDBIndexBackendInterface.h:
- storage/IDBObjectStore.cpp:
(WebCore::IDBObjectStore::get):
(WebCore::IDBObjectStore::add):
(WebCore::IDBObjectStore::put):
(WebCore::IDBObjectStore::remove):
(WebCore::IDBObjectStore::createIndex):
(WebCore::IDBObjectStore::index):
(WebCore::IDBObjectStore::removeIndex):
(WebCore::IDBObjectStore::openCursor):
- storage/IDBObjectStore.h:
(WebCore::IDBObjectStore::add):
(WebCore::IDBObjectStore::put):
(WebCore::IDBObjectStore::createIndex):
(WebCore::IDBObjectStore::openCursor):
- storage/IDBObjectStore.idl:
- storage/IDBObjectStoreBackendImpl.cpp:
(WebCore::IDBObjectStoreBackendImpl::get):
(WebCore::IDBObjectStoreBackendImpl::put):
(WebCore::IDBObjectStoreBackendImpl::remove):
(WebCore::IDBObjectStoreBackendImpl::createIndex):
(WebCore::IDBObjectStoreBackendImpl::index):
(WebCore::IDBObjectStoreBackendImpl::removeIndex):
(WebCore::IDBObjectStoreBackendImpl::openCursor):
- storage/IDBObjectStoreBackendImpl.h:
(WebCore::IDBObjectStoreBackendImpl::name):
(WebCore::IDBObjectStoreBackendImpl::keyPath):
(WebCore::IDBObjectStoreBackendImpl::autoIncrement):
- storage/IDBObjectStoreBackendInterface.h:
- storage/IDBTransaction.cpp:
(WebCore::IDBTransaction::objectStore):
- storage/IDBTransaction.h:
- storage/IDBTransactionBackendImpl.cpp:
(WebCore::IDBTransactionBackendImpl::objectStore):
WebKit/chromium:
- public/WebIDBCursor.h:
- public/WebIDBDatabase.h:
(WebKit::WebIDBDatabase::transaction):
- public/WebIDBFactory.h:
(WebKit::WebIDBFactory::open):
- public/WebIDBObjectStore.h:
- public/WebIDBTransactionCallbacks.h:
- src/IDBCursorBackendProxy.cpp:
(WebCore::IDBCursorBackendProxy::update):
(WebCore::IDBCursorBackendProxy::continueFunction):
(WebCore::IDBCursorBackendProxy::remove):
- src/IDBCursorBackendProxy.h:
- src/IDBDatabaseProxy.cpp:
(WebCore::IDBDatabaseProxy::createObjectStore):
(WebCore::IDBDatabaseProxy::removeObjectStore):
(WebCore::IDBDatabaseProxy::setVersion):
(WebCore::IDBDatabaseProxy::transaction):
- src/IDBDatabaseProxy.h:
- src/IDBIndexBackendProxy.cpp:
(WebCore::IDBIndexBackendProxy::openCursor):
(WebCore::IDBIndexBackendProxy::openKeyCursor):
(WebCore::IDBIndexBackendProxy::get):
(WebCore::IDBIndexBackendProxy::getKey):
- src/IDBIndexBackendProxy.h:
- src/IDBObjectStoreProxy.cpp:
(WebCore::IDBObjectStoreProxy::get):
(WebCore::IDBObjectStoreProxy::put):
(WebCore::IDBObjectStoreProxy::remove):
(WebCore::IDBObjectStoreProxy::createIndex):
(WebCore::IDBObjectStoreProxy::index):
(WebCore::IDBObjectStoreProxy::removeIndex):
(WebCore::IDBObjectStoreProxy::openCursor):
- src/IDBObjectStoreProxy.h:
- src/WebIDBCursorImpl.cpp:
(WebKit::WebIDBCursorImpl::update):
(WebKit::WebIDBCursorImpl::continueFunction):
(WebKit::WebIDBCursorImpl::remove):
- src/WebIDBCursorImpl.h:
- src/WebIDBDatabaseImpl.cpp:
(WebKit::WebIDBDatabaseImpl::createObjectStore):
(WebKit::WebIDBDatabaseImpl::removeObjectStore):
(WebKit::WebIDBDatabaseImpl::setVersion):
(WebKit::WebIDBDatabaseImpl::transaction):
- src/WebIDBDatabaseImpl.h:
- src/WebIDBIndexImpl.cpp:
(WebKit::WebIDBIndexImpl::openObjectCursor):
(WebKit::WebIDBIndexImpl::openKeyCursor):
(WebKit::WebIDBIndexImpl::getObject):
(WebKit::WebIDBIndexImpl::getKey):
- src/WebIDBIndexImpl.h:
- src/WebIDBObjectStoreImpl.cpp:
(WebKit::WebIDBObjectStoreImpl::get):
(WebKit::WebIDBObjectStoreImpl::put):
(WebKit::WebIDBObjectStoreImpl::remove):
(WebKit::WebIDBObjectStoreImpl::createIndex):
(WebKit::WebIDBObjectStoreImpl::index):
(WebKit::WebIDBObjectStoreImpl::removeIndex):
(WebKit::WebIDBObjectStoreImpl::openCursor):
- src/WebIDBObjectStoreImpl.h:
Merge 69721 - 2010-10-13 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Nate Chapin.
IndexedDB should fire some errors synchronously
https://bugs.webkit.org/show_bug.cgi?id=47530
- storage/indexeddb/objectstore-basics-expected.txt:
- storage/indexeddb/objectstore-basics.html:
- storage/indexeddb/objectstore-removeobjectstore-expected.txt:
- storage/indexeddb/objectstore-removeobjectstore.html:
2010-10-13 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Nate Chapin.
IndexedDB should fire some errors synchronously
https://bugs.webkit.org/show_bug.cgi?id=47530
Add dumb plumbing to pass around exception codes.
Utilize that plumbing in the backend to fire some
errors synchronously.
Verify that create/remove* functions are only called
in setVersionTransactions (and raise when not).
Remove plumbing for obsolete IDBDatabase.objectStore
Remove obsolete mode param.
- storage/IDBCursor.cpp: (WebCore::IDBCursor::update): (WebCore::IDBCursor::continueFunction): (WebCore::IDBCursor::remove):
- storage/IDBCursor.h: (WebCore::IDBCursor::continueFunction):
- storage/IDBCursor.idl:
- storage/IDBCursorBackendImpl.cpp: (WebCore::IDBCursorBackendImpl::update): (WebCore::IDBCursorBackendImpl::continueFunction): (WebCore::IDBCursorBackendImpl::remove):
- storage/IDBCursorBackendImpl.h:
- storage/IDBCursorBackendInterface.h:
- storage/IDBDatabase.cpp: (WebCore::IDBDatabase::IDBDatabase): (WebCore::IDBDatabase::createObjectStore): (WebCore::IDBDatabase::removeObjectStore): (WebCore::IDBDatabase::setVersion): (WebCore::IDBDatabase::transaction):
- storage/IDBDatabase.h: (WebCore::IDBDatabase::createObjectStore): (WebCore::IDBDatabase::transaction):
- storage/IDBDatabase.idl:
- storage/IDBDatabaseBackendImpl.cpp: (WebCore::IDBDatabaseBackendImpl::createObjectStore): (WebCore::IDBDatabaseBackendImpl::objectStore): (WebCore::IDBDatabaseBackendImpl::removeObjectStore): (WebCore::IDBDatabaseBackendImpl::setVersion): (WebCore::IDBDatabaseBackendImpl::transaction):
- storage/IDBDatabaseBackendImpl.h:
- storage/IDBDatabaseBackendInterface.h:
- storage/IDBFactory.cpp: (WebCore::IDBFactory::open):
- storage/IDBFactory.h: (WebCore::IDBFactory::open):
- storage/IDBFactory.idl:
- storage/IDBIndex.cpp: (WebCore::IDBIndex::openCursor): (WebCore::IDBIndex::openKeyCursor): (WebCore::IDBIndex::get): (WebCore::IDBIndex::getKey):
- storage/IDBIndex.h: (WebCore::IDBIndex::openCursor): (WebCore::IDBIndex::openKeyCursor):
- storage/IDBIndex.idl:
- storage/IDBIndexBackendImpl.cpp: (WebCore::IDBIndexBackendImpl::openCursor): (WebCore::IDBIndexBackendImpl::openKeyCursor): (WebCore::IDBIndexBackendImpl::get): (WebCore::IDBIndexBackendImpl::getKey):
- storage/IDBIndexBackendImpl.h:
- storage/IDBIndexBackendInterface.h:
- storage/IDBObjectStore.cpp: (WebCore::IDBObjectStore::get): (WebCore::IDBObjectStore::add): (WebCore::IDBObjectStore::put): (WebCore::IDBObjectStore::remove): (WebCore::IDBObjectStore::createIndex): (WebCore::IDBObjectStore::index): (WebCore::IDBObjectStore::removeIndex): (WebCore::IDBObjectStore::openCursor):
- storage/IDBObjectStore.h: (WebCore::IDBObjectStore::add): (WebCore::IDBObjectStore::put): (WebCore::IDBObjectStore::createIndex): (WebCore::IDBObjectStore::openCursor):
- storage/IDBObjectStore.idl:
- storage/IDBObjectStoreBackendImpl.cpp: (WebCore::IDBObjectStoreBackendImpl::get): (WebCore::IDBObjectStoreBackendImpl::put): (WebCore::IDBObjectStoreBackendImpl::remove): (WebCore::IDBObjectStoreBackendImpl::createIndex): (WebCore::IDBObjectStoreBackendImpl::index): (WebCore::IDBObjectStoreBackendImpl::removeIndex): (WebCore::IDBObjectStoreBackendImpl::openCursor):
- storage/IDBObjectStoreBackendImpl.h: (WebCore::IDBObjectStoreBackendImpl::name): (WebCore::IDBObjectStoreBackendImpl::keyPath): (WebCore::IDBObjectStoreBackendImpl::autoIncrement):
- storage/IDBObjectStoreBackendInterface.h:
- storage/IDBTransaction.cpp: (WebCore::IDBTransaction::objectStore):
- storage/IDBTransaction.h:
- storage/IDBTransactionBackendImpl.cpp: (WebCore::IDBTransactionBackendImpl::objectStore):
2010-10-13 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Nate Chapin.
IndexedDB should fire some errors synchronously
https://bugs.webkit.org/show_bug.cgi?id=47530
- public/WebIDBCursor.h:
- public/WebIDBDatabase.h: (WebKit::WebIDBDatabase::transaction):
- public/WebIDBFactory.h: (WebKit::WebIDBFactory::open):
- public/WebIDBObjectStore.h:
- public/WebIDBTransactionCallbacks.h:
- src/IDBCursorBackendProxy.cpp: (WebCore::IDBCursorBackendProxy::update): (WebCore::IDBCursorBackendProxy::continueFunction): (WebCore::IDBCursorBackendProxy::remove):
- src/IDBCursorBackendProxy.h:
- src/IDBDatabaseProxy.cpp: (WebCore::IDBDatabaseProxy::createObjectStore): (WebCore::IDBDatabaseProxy::removeObjectStore): (WebCore::IDBDatabaseProxy::setVersion): (WebCore::IDBDatabaseProxy::transaction):
- src/IDBDatabaseProxy.h:
- src/IDBIndexBackendProxy.cpp: (WebCore::IDBIndexBackendProxy::openCursor): (WebCore::IDBIndexBackendProxy::openKeyCursor): (WebCore::IDBIndexBackendProxy::get): (WebCore::IDBIndexBackendProxy::getKey):
- src/IDBIndexBackendProxy.h:
- src/IDBObjectStoreProxy.cpp: (WebCore::IDBObjectStoreProxy::get): (WebCore::IDBObjectStoreProxy::put): (WebCore::IDBObjectStoreProxy::remove): (WebCore::IDBObjectStoreProxy::createIndex): (WebCore::IDBObjectStoreProxy::index): (WebCore::IDBObjectStoreProxy::removeIndex): (WebCore::IDBObjectStoreProxy::openCursor):
- src/IDBObjectStoreProxy.h:
- src/WebIDBCursorImpl.cpp: (WebKit::WebIDBCursorImpl::update): (WebKit::WebIDBCursorImpl::continueFunction): (WebKit::WebIDBCursorImpl::remove):
- src/WebIDBCursorImpl.h:
- src/WebIDBDatabaseImpl.cpp: (WebKit::WebIDBDatabaseImpl::createObjectStore): (WebKit::WebIDBDatabaseImpl::removeObjectStore): (WebKit::WebIDBDatabaseImpl::setVersion): (WebKit::WebIDBDatabaseImpl::transaction):
- src/WebIDBDatabaseImpl.h:
- src/WebIDBIndexImpl.cpp: (WebKit::WebIDBIndexImpl::openObjectCursor): (WebKit::WebIDBIndexImpl::openKeyCursor): (WebKit::WebIDBIndexImpl::getObject): (WebKit::WebIDBIndexImpl::getKey):
- src/WebIDBIndexImpl.h:
- src/WebIDBObjectStoreImpl.cpp: (WebKit::WebIDBObjectStoreImpl::get): (WebKit::WebIDBObjectStoreImpl::put): (WebKit::WebIDBObjectStoreImpl::remove): (WebKit::WebIDBObjectStoreImpl::createIndex): (WebKit::WebIDBObjectStoreImpl::index): (WebKit::WebIDBObjectStoreImpl::removeIndex): (WebKit::WebIDBObjectStoreImpl::openCursor):
- src/WebIDBObjectStoreImpl.h:
- 09:48 Changeset [69858] by
-
2010-10-15 Sergio Villar Senin <svillar@igalia.com>
Reviewed by Martin Robinson.
[GTK] Fix introspection support
https://bugs.webkit.org/show_bug.cgi?id=47723
Added HTTP cache directory to the WebkitGtk+ GIR sources.
- GNUmakefile.am:
2010-10-15 Sergio Villar Senin <svillar@igalia.com>
Reviewed by Martin Robinson.
[GTK] Fix introspection support
https://bugs.webkit.org/show_bug.cgi?id=47723
WebKitSoupCacheType was incorrectly registered twice. Renamed to
WebKitSoupCacheTypeType for the enumerated type.
- platform/network/soup/cache/webkit/soup-cache.c: (webkit_soup_cache_type_get_type):
- 09:43 WebKitGtkLayoutTests edited by
- (diff)
- 09:30 Changeset [69857] by
-
2010-10-15 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r69809.
http://trac.webkit.org/changeset/69809
https://bugs.webkit.org/show_bug.cgi?id=47725
Broke chromium mac compile (Requested by japhet on #webkit).
- WebKit.gyp:
2010-10-15 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r69809.
http://trac.webkit.org/changeset/69809
https://bugs.webkit.org/show_bug.cgi?id=47725
Broke chromium mac compile (Requested by japhet on #webkit).
- DumpRenderTree/DumpRenderTree.gypi:
- DumpRenderTree/TestNetscapePlugIn/main.cpp: (NP_GetEntryPoints): (NPP_New): (NPP_Destroy): (NPP_HandleEvent): (NPP_GetValue):
- DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: Removed.
- DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Removed.
- DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h: Removed.
- 09:27 Changeset [69856] by
-
2010-10-15 Qi Zhang <qi.2.zhang@nokia.com>
Reviewed by Andreas Kling.
[Qt] window.close() doesn't work in qt
https://bugs.webkit.org/show_bug.cgi?id=46186
Introduce new attribute in QWebSettings to trigger "setAllowScriptsToCloseWindow"
- Api/qwebsettings.cpp: (QWebSettingsPrivate::apply):
- Api/qwebsettings.h:
- 08:56 Changeset [69855] by
-
2010-10-15 Martin Robinson <mrobinson@igalia.com>
Fix my rebaseline sanfu.
- fast/forms/mailto/advanced-get.html:
- fast/forms/mailto/advanced-put.html:
- platform/gtk/fast/forms/mailto/advanced-get-expected.txt: Copied from LayoutTests/fast/forms/mailto/advanced-get-expected.txt.
- platform/gtk/fast/forms/mailto/advanced-put-expected.txt: Copied from LayoutTests/fast/forms/mailto/advanced-put-expected.txt.
- 08:34 Changeset [69854] by
-
2010-10-15 Martin Robinson <mrobinson@igalia.com>
Rebaseline a few other failing tests. They differ because
dumpAsText output depends on whether or not certain content
reaches the edge of the view and wraps.
- fast/forms/mailto/advanced-get.html:
- fast/forms/mailto/advanced-put.html:
- 08:20 Changeset [69853] by
-
2010-10-15 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: extract consoleMessages related stuff from populateScriptObjects into separate function.
This is a part of Inspector protocol sanitization activity.
We want to populate console messages only if it is required by frontend.
- inspector/Inspector.idl:
- inspector/InspectorController.cpp: (WebCore::InspectorController::setConsoleMessagesEnabled): (WebCore::InspectorController::addConsoleMessage): (WebCore::InspectorController::disconnectFrontend): (WebCore::InspectorController::populateScriptObjects):
- inspector/InspectorController.h:
- inspector/InspectorState.cpp: (WebCore::InspectorState::InspectorState):
- inspector/InspectorState.h:
- inspector/front-end/inspector.js: (WebInspector.doLoadedDone):
- 08:11 Changeset [69852] by
-
Windows build fix. Unreviewed.
- WebCoreSupport/WebInspectorClient.cpp:
Add a missing include.
- 06:56 Changeset [69851] by
-
2010-10-15 Andreas Kling <kling@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Unbreak scrolling the ContentsLayer with QWebView
r69777 broke scrolling the contents layer in QWebView by not restoring
the painter clip after painting each part of the dirty region.
- Api/qwebframe.cpp: (QWebFramePrivate::renderRelativeCoords):
- 05:29 Changeset [69850] by
-
2010-10-15 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
Replace some String::format() usages by StringConcatenate in WebKit
https://bugs.webkit.org/show_bug.cgi?id=47714
- wtf/text/StringConcatenate.h: Add UChar specific StringTypeAdapter, to accept single UChars in makeString().
2010-10-15 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
Replace some String::format() usages by StringConcatenate in WebKit
https://bugs.webkit.org/show_bug.cgi?id=47714
- src/BackForwardListClientImpl.cpp: (WebKit::BackForwardListClientImpl::itemAtIndex):
- src/DebuggerAgentManager.cpp: (WebKit::DebuggerAgentManager::debugDetach):
- src/LocalizedStrings.cpp: (WebCore::imageTitle):
- src/WebPageSerializer.cpp: (WebKit::WebPageSerializer::generateMetaCharsetDeclaration): (WebKit::WebPageSerializer::generateBaseTagDeclaration):
2010-10-15 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
Replace some String::format() usages by StringConcatenate in WebKit
https://bugs.webkit.org/show_bug.cgi?id=47714
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchDidFailLoad):
- webkit/webkitwebsettings.cpp: (webkitOSVersion): (webkitUserAgent):
2010-10-15 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
Replace some String::format() usages by StringConcatenate in WebKit
https://bugs.webkit.org/show_bug.cgi?id=47714
- WebCoreSupport/WebInspectorClient.cpp: (WebInspectorFrontendClient::updateWindowTitle):
- WebView.cpp: (WebView::standardUserAgentWithApplicationName): (osVersion):
2010-10-15 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
Replace some String::format() usages by StringConcatenate in WebKit
https://bugs.webkit.org/show_bug.cgi?id=47714
- WebCoreSupport/PlatformStrategiesWinCE.cpp: (PlatformStrategiesWinCE::imageTitle): (PlatformStrategiesWinCE::multipleFileUploadText):
2010-10-15 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
Replace some String::format() usages by StringConcatenate in WebKit
https://bugs.webkit.org/show_bug.cgi?id=47714
- WebCoreSupport/FrameLoaderClientEfl.cpp: (WebCore::agentOS):
- 05:23 Changeset [69849] by
-
2010-10-15 Ryuan Choi <ryuan.choi@samsung.com>
Reviewed by Nikolas Zimmermann.
[EFL] REGRESSION(69798) UCHAR can't be converted to String.
https://bugs.webkit.org/show_bug.cgi?id=47698
Create String value using String(const char*, 1) instead of operator[].
No tests. No functionality changed.
- platform/efl/PlatformKeyboardEventEfl.cpp: (WebCore::createWindowsKeyMap):
- 03:39 Changeset [69848] by
-
2010-10-15 Sergio Villar Senin <svillar@igalia.com>
Reviewed by Xan Lopez.
[GTK] Do a stricter check for invalid base64 dataURLs
https://bugs.webkit.org/show_bug.cgi?id=47717
Restore the strict base64 decoding we added in
https://bugs.webkit.org/show_bug.cgi?id=44261 and then rolled back
in https://bugs.webkit.org/show_bug.cgi?id=47666 due to a failing
test. The actual issue was that we were not finishing the load of
the resource gracefully when an error happened.
Loading invalid base64-encoded data:// URLs are now handled
properly.
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::parseDataUrl):
- platform/network/soup/cache/soup-request-data.c: (webkit_soup_request_data_send):
- 02:04 Changeset [69847] by
-
2010-10-15 Ilya Tikhonovsky <loislo@chromium.org>
Unreviewed build fix for Debug Leopard which is failng to compile after r69842.
- yarr/RegexInterpreter.cpp: (JSC::Yarr::ByteCompiler::emitDisjunction):
- 01:47 Changeset [69846] by
-
2010-10-15 Alejandro G. Castro <alex@igalia.com>
Rebaseline some failing tests to the former results, apparently
they are flaky, skip if they continue failing.
- platform/gtk/mathml/presentation/fenced-expected.txt:
- platform/gtk/mathml/presentation/subsup-expected.txt:
- 01:33 Changeset [69845] by
-
2010-10-15 Alejandro G. Castro <alex@igalia.com>
Reviewed by Martin Robinson.
compile fail with gtk >= 2.22
https://bugs.webkit.org/show_bug.cgi?id=47483
- platform/graphics/gtk/FontGtk.cpp: Removed the shrink operation, it was added long time ago and currently it is not adding any real area to the clip vertically, actually the gtk3 shrink version did not work. (WebCore::Font::drawComplexText):
- platform/gtk/gtk2drawing.c: Undef the deprecation flags, this file is full of gtk2 stuff, and it does not seem interesting to upgrade because we are already creating a new version of the file for gtk3.
- 01:31 Changeset [69844] by
-
2010-10-14 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: inspector settings/properties/states management
should be extracted into separate class.
We have a lot of flags/values in InspectorController.
Some flags are persisting into profile.
Others are part of inspector state for frontend.
All these flags should keep their values after navigation.
It'd be better to extract these flags/values into separate
class which will care about theirs lifetime.
WebCore:
- CMakeLists.txt:
- GNUmakefile.am:
- WebCore.exp.in:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::inspectorStartsAttached): (WebCore::InspectorController::setInspectorStartsAttached): (WebCore::InspectorController::setInspectorAttachedHeight): (WebCore::InspectorController::inspectorAttachedHeight): (WebCore::InspectorController::searchingForNodeInPage): (WebCore::InspectorController::resourceTrackingEnabled): (WebCore::InspectorController::saveApplicationSettings): (WebCore::InspectorController::getInspectorState): (WebCore::InspectorController::restoreInspectorStateFromCookie): (WebCore::InspectorController::getSettings): (WebCore::InspectorController::storeLastActivePanel): (WebCore::InspectorController::mouseDidMoveOverElement): (WebCore::InspectorController::handleMousePress): (WebCore::InspectorController::setSearchingForNode): (WebCore::InspectorController::setMonitoringXHREnabled): (WebCore::InspectorController::showPanel): (WebCore::InspectorController::disconnectFrontend): (WebCore::InspectorController::populateScriptObjects): (WebCore::InspectorController::restoreDebugger): (WebCore::InspectorController::restoreProfiler): (WebCore::InspectorController::getTrackedResource): (WebCore::InspectorController::didLoadResourceFromMemoryCache): (WebCore::InspectorController::identifierForInitialRequest): (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest): (WebCore::InspectorController::scriptImported): (WebCore::InspectorController::setResourceTrackingEnabled): (WebCore::InspectorController::ensureSettingsLoaded): (WebCore::InspectorController::startTimelineProfiler): (WebCore::InspectorController::stopTimelineProfiler): (WebCore::InspectorController::enableProfiler): (WebCore::InspectorController::disableProfiler): (WebCore::InspectorController::enableDebuggerFromFrontend): (WebCore::InspectorController::disableDebugger): (WebCore::InspectorController::loadBreakpoints): (WebCore::InspectorController::saveBreakpoints):
- inspector/InspectorController.h:
- inspector/InspectorFrontendClientLocal.cpp: (WebCore::InspectorFrontendClientLocal::changeAttachedWindowHeight): (WebCore::InspectorFrontendClientLocal::restoreAttachedWindowHeight):
- inspector/InspectorState.cpp: Added. (WebCore::InspectorState::InspectorState): (WebCore::InspectorState::restoreFromInspectorCookie): (WebCore::InspectorState::generateStateObjectForFrontend): (WebCore::InspectorState::loadFromSettings): (WebCore::InspectorState::updateCookie): (WebCore::InspectorState::setValue): (WebCore::InspectorState::getBoolean): (WebCore::InspectorState::getString): (WebCore::InspectorState::getLong): (WebCore::InspectorState::registerBoolean): (WebCore::InspectorState::registerString): (WebCore::InspectorState::registerLong): (WebCore::InspectorState::Property::create):
- inspector/InspectorState.h: Added. (WebCore::InspectorState::setBoolean): (WebCore::InspectorState::setString): (WebCore::InspectorState::setLong):
WebKit/mac:
- WebCoreSupport/WebInspectorClient.mm: (-[WebInspectorWindowController showWindow:]): (-[WebInspectorWindowController attach]): (-[WebInspectorWindowController detach]):
WebKit/win:
- WebCoreSupport/WebInspectorClient.cpp: (WebInspectorFrontendClient::attachWindow): (WebInspectorFrontendClient::detachWindow): (WebInspectorFrontendClient::showWindowWithoutNotifications):
- 01:20 Changeset [69843] by
-
2010-10-15 Adam Barth <abarth@webkit.org>
Reviewed by Adam Barth.
test-webkitpy fails on Linux
https://bugs.webkit.org/show_bug.cgi?id=47713
The old code failed on Linux because the MacPort tries to read
something out of platform that doesn't make sense on Linux.
- Scripts/webkitpy/tool/mocktool.py:
- 00:59 Changeset [69842] by
-
The parenthetical assertion checking isn't working in some cases with YARR
Interpreter
https://bugs.webkit.org/show_bug.cgi?id=46893
Patch by Peter Varga <pvarga@inf.u-szeged.hu> on 2010-10-15
Reviewed by Gavin Barraclough.
Calculate the countToCheck value of a TypeParentheticalAssertion by
subtracting the number of characters which follows
a TypeParentheticalAssertion term with the number of characters which should
be matched by terms which are contained
in the TypeParentheticalAssertion term (minimumSize).
- yarr/RegexInterpreter.cpp:
(JSC::Yarr::ByteCompiler::emitDisjunction):
