Timeline


and

11/02/10:

23:59 Changeset [71215] by gyuyoung.kim@samsung.com

2010-11-02 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Unreviewed: Add myself to the list of Committers.

  • Scripts/webkitpy/common/config/committers.py:
22:29 Changeset [71214] by mrobinson@webkit.org

2010-11-02 Amruth Raj <amruthraj@motorola.com> and Ravi Kasibhatla <ravi.kasibhatla@motorola.com>

Reviewed by Martin Robinson.

Changes to enable building WebKit2 for Gtk port.
(https://bugs.webkit.org/show_bug.cgi?id=37369)

  • Platform/gtk: Added.
  • Platform/gtk/SharedMemoryGtk.cpp: Added. Stubbed implementation for GTK port. Yet to implement. (WebKit::SharedMemory::Handle::Handle): (WebKit::SharedMemory::Handle::~Handle): (WebKit::SharedMemory::Handle::encode): (WebKit::SharedMemory::Handle::decode): (WebKit::SharedMemory::create): (WebKit::SharedMemory::~SharedMemory): (WebKit::SharedMemory::createHandle): (WebKit::SharedMemory::systemPageSize):
  • Shared/gtk: Added.
  • Shared/gtk/BackingStoreGtk.cpp: Added. Stubbed implementation for GTK port. Yet to implement. (WebKit::BackingStore::createGraphicsContext): (WebKit::BackingStore::paint):
  • Shared/gtk/PlatformCertificateInfo.h: Added. Added. Stubbed implementation for GTK port. Yet to implement. (WebKit::PlatformCertificateInfo::PlatformCertificateInfo): (WebKit::PlatformCertificateInfo::encode): (WebKit::PlatformCertificateInfo::decode):
  • Shared/gtk/WebCoreArgumentCodersGtk.cpp: Added. Stubbed implementation for GTK port. Yet to implement. (CoreIPC::encodeResourceRequest): (CoreIPC::decodeResourceRequest):
  • UIProcess/Plugins/gtk: Added.
  • UIProcess/Plugins/gtk/PluginInfoStoreGtk.cpp: Added. Stubbed implementation for GTK port. Yet to implement. (WebKit::PluginInfoStore::pluginsDirectories): (WebKit::PluginInfoStore::pluginPathsInDirectory): (WebKit::PluginInfoStore::individualPluginPaths): (WebKit::PluginInfoStore::getPluginInfo): (WebKit::PluginInfoStore::shouldUsePlugin):
  • WebProcess/InjectedBundle/InjectedBundle.h:
  • WebProcess/InjectedBundle/gtk: Added.
  • WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp: Added. Stubbed implementation for GTK port. Yet to implement. (WebKit::InjectedBundle::load): (WebKit::InjectedBundle::activateMacFontAscentHack):
  • WebProcess/Plugins/Netscape/gtk: Added.
  • WebProcess/Plugins/Netscape/gtk/NetscapePluginGtk.cpp: Added. Stubbed implementation for GTK port. Yet to implement. (WebKit::NetscapePlugin::platformPostInitialize): (WebKit::NetscapePlugin::platformDestroy): (WebKit::NetscapePlugin::platformGeometryDidChange): (WebKit::NetscapePlugin::platformPaint): (WebKit::toNP): (WebKit::NetscapePlugin::platformHandleMouseEvent): (WebKit::NetscapePlugin::platformHandleWheelEvent): (WebKit::NetscapePlugin::platformSetFocus): (WebKit::NetscapePlugin::platformHandleMouseEnterEvent): (WebKit::NetscapePlugin::platformHandleMouseLeaveEvent): (WebKit::NetscapePlugin::platformHandleKeyboardEvent):
  • WebProcess/WebCoreSupport/gtk: Added.
  • WebProcess/WebCoreSupport/gtk/WebFrameNetworkingContext.h: Added. Added. Stubbed implementation for GTK port. Yet to implement. (WebFrameNetworkingContext::create): (WebFrameNetworkingContext::WebFrameNetworkingContext):
21:53 WebKitGtkLayoutTests edited by mrobinson@webkit.org
Fixed the color depth argument on Xvfb calls (diff)
21:41 Changeset [71213] by crogers@google.com

2010-11-02 Chris Rogers <crogers@google.com>

Reviewed by James Robinson.

Add AudioProcessingEvent files
https://bugs.webkit.org/show_bug.cgi?id=48884

No new tests since audio API is not yet implemented.

  • webaudio/AudioProcessingEvent.cpp: Added. (WebCore::AudioProcessingEvent::create): (WebCore::AudioProcessingEvent::AudioProcessingEvent): (WebCore::AudioProcessingEvent::~AudioProcessingEvent): (WebCore::AudioProcessingEvent::isAudioProcessingEvent):
  • webaudio/AudioProcessingEvent.h: Added. (WebCore::AudioProcessingEvent::inputBuffer): (WebCore::AudioProcessingEvent::outputBuffer):
  • webaudio/AudioProcessingEvent.idl: Added.

2010-11-02 Noam Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Some refactor for texmap to enable WebKit2: remove globals, and allow TextureMapper to exist without a GraphicsContext.
This will allow rendering the TextureMapperNode tree without an active QPainter, into the current GL context.
Most of the changes simply move the globas in TextureMapperGL into members of that class.

[Texmap] [Qt] Texture mapper initial implementation
https://bugs.webkit.org/show_bug.cgi?id=47070

  • Api/qwebframe.cpp: (QWebFramePrivate::renderFromTiledBackingStore): (QWebFramePrivate::renderCompositedLayers): (QWebFramePrivate::renderRelativeCoords):
  • Api/qwebframe_p.h:
21:36 Changeset [71212] by crogers@google.com

2010-11-02 Chris Rogers <crogers@google.com>

Reviewed by James Robinson.

Add AudioProcessingEvent files
https://bugs.webkit.org/show_bug.cgi?id=48884

No new tests since audio API is not yet implemented.

  • webaudio/AudioProcessingEvent.cpp: Added. (WebCore::AudioProcessingEvent::create): (WebCore::AudioProcessingEvent::AudioProcessingEvent): (WebCore::AudioProcessingEvent::~AudioProcessingEvent): (WebCore::AudioProcessingEvent::isAudioProcessingEvent):
  • webaudio/AudioProcessingEvent.h: Added. (WebCore::AudioProcessingEvent::inputBuffer): (WebCore::AudioProcessingEvent::outputBuffer):
  • webaudio/AudioProcessingEvent.idl: Added.
21:23 Changeset [71211] by commit-queue@webkit.org

2010-11-02 Benjamin Kalman <kalman@chromium.org>

Reviewed by Ojan Vafai.

canvas/philip tests use BUG instead of BUGWK in chromium test_expectations.txt.
https://bugs.webkit.org/show_bug.cgi?id=48879

  • platform/chromium/test_expectations.txt: Update canvas/philip tests to use BUGWK instead of BUG.
21:16 Changeset [71210] by commit-queue@webkit.org

2010-11-02 Al Patrick <apatrick@chromium.org>

Reviewed by Kenneth Russell.

Added PluginLayerChromium, which composites plugin instances that have an associated OpenGL backing texture.

https://bugs.webkit.org/show_bug.cgi?id=48032

  • WebCore.gypi:
  • loader/SubframeLoader.cpp (WebCore::SubframeLoader::loadPlugin):
  • platform/graphics/chromium/LayerChromium.cpp: (WebCore::LayerChromium::setNeedsDisplay):
  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::initializeSharedObjects): (WebCore::LayerRendererChromium::cleanupSharedObjects):
  • platform/graphics/chromium/LayerRendererChromium.h: (WebCore::LayerRendererChromium::pluginLayerSharedValues):
  • platform/graphics/chromium/PluginLayerChromium.cpp: Added. (WebCore::PluginLayerChromium::SharedValues::SharedValues): (WebCore::PluginLayerChromium::SharedValues::~SharedValues): (WebCore::PluginLayerChromium::create): (WebCore::PluginLayerChromium::PluginLayerChromium): (WebCore::PluginLayerChromium::updateContents): (WebCore::PluginLayerChromium::draw):
  • platform/graphics/chromium/PluginLayerChromium.h: Added. (WebCore::PluginLayerChromium::drawsContent): (WebCore::PluginLayerChromium::setTextureId): (WebCore::PluginLayerChromium::SharedValues::shaderProgram): (WebCore::PluginLayerChromium::SharedValues::shaderSamplerLocation): (WebCore::PluginLayerChromium::SharedValues::shaderMatrixLocation): (WebCore::PluginLayerChromium::SharedValues::shaderAlphaLocation): (WebCore::PluginLayerChromium::SharedValues::initialized):

2010-11-02 Al Patrick <apatrick@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Plugin instances can propagate the ID of the OpenGL texture they render to.

https://bugs.webkit.org/show_bug.cgi?id=48032

  • public/WebPlugin.h: (WebKit::WebPlugin::getBackingTextureId):
  • public/WebPluginContainer.h: (WebKit::WebPluginContainer::commitBackingTexture):
  • src/WebPluginContainerImpl.cpp: (WebKit::WebPluginContainerImpl::commitBackingTexture): (WebKit::WebPluginContainerImpl::platformLayer): (WebKit::WebPluginContainerImpl::WebPluginContainerImpl):
  • src/WebPluginContainerImpl.h:
20:56 Changeset [71209] by commit-queue@webkit.org

2010-11-02 James Simonsen <simonjam@chromium.org>

Reviewed by Adam Barth.

mathml in html sometimes incorrectly parsed
https://bugs.webkit.org/show_bug.cgi?id=48105

  • html5lib/resources/webkit01.dat: Test case for bug.

2010-11-02 James Simonsen <simonjam@chromium.org>

Reviewed by Adam Barth.

mathml in html sometimes incorrectly parsed
https://bugs.webkit.org/show_bug.cgi?id=48105

  • html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processEndTag): Fixed to match HTML5 spec.
20:46 Changeset [71208] by rolandsteiner@chromium.org

2010-11-02 Chris Guillory <chris.guillory@google.com>

Reviewed by Dmitry Titov.

Null check obj in AXObjectCache::postPlatformNotification.
https://bugs.webkit.org/show_bug.cgi?id=48896

  • accessibility/chromium/AXObjectCacheChromium.cpp: (WebCore::AXObjectCache::postPlatformNotification):
20:31 Changeset [71207] by dimich@chromium.org

[Chromium] Unreviewed update of test expectations.
Add Chromium baseline for a test expectations added
in http://trac.webkit.org/changeset/71192.

  • platform/chromium-mac/fast/canvas/canvas-zoom-expected.checksum: Added.
19:59 Changeset [71206] by commit-queue@webkit.org

2010-11-02 Kavita Kanetkar <kkanetkar@chromium.org>

Reviewed by Dumitru Daniliuc.

[FileSystem] Support not creating directories when queried by inspector.
https://bugs.webkit.org/show_bug.cgi?id=48169

  • fileapi/LocalFileSystem.cpp: (WebCore::openFileSystem): (WebCore::LocalFileSystem::readFileSystem): (WebCore::LocalFileSystem::requestFileSystem):
  • fileapi/LocalFileSystem.h:
  • platform/AsyncFileSystem.cpp: (WebCore::AsyncFileSystem::openFileSystem):
  • platform/AsyncFileSystem.h:

2010-11-02 Kavita Kanetkar <kkanetkar@chromium.org>

Reviewed by Dumitru Daniliuc.

[FileSystem] Support not creating directories when queried by inspector.
https://bugs.webkit.org/show_bug.cgi?id=48169

  • src/LocalFileSystemChromium.cpp: (WebCore::LocalFileSystem::readFileSystem): (WebCore::LocalFileSystem::requestFileSystem):
19:35 Changeset [71205] by crogers@google.com

2010-11-02 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

Add AudioBufferSourceNode files
https://bugs.webkit.org/show_bug.cgi?id=48012

No new tests since audio API is not yet implemented.

  • webaudio/AudioBufferSourceNode.cpp: Added. (WebCore::AudioBufferSourceNode::create): (WebCore::AudioBufferSourceNode::AudioBufferSourceNode): (WebCore::AudioBufferSourceNode::~AudioBufferSourceNode): (WebCore::AudioBufferSourceNode::process): (WebCore::AudioBufferSourceNode::provideInput): (WebCore::AudioBufferSourceNode::readFromBuffer): (WebCore::AudioBufferSourceNode::readFromBufferWithGrainEnvelope): (WebCore::AudioBufferSourceNode::reset): (WebCore::AudioBufferSourceNode::setBuffer): (WebCore::AudioBufferSourceNode::numberOfChannels): (WebCore::AudioBufferSourceNode::noteOn): (WebCore::AudioBufferSourceNode::noteGrainOn): (WebCore::AudioBufferSourceNode::noteOff): (WebCore::AudioBufferSourceNode::totalPitchRate):
  • webaudio/AudioBufferSourceNode.h: Added. (WebCore::AudioBufferSourceNode::buffer): (WebCore::AudioBufferSourceNode::looping): (WebCore::AudioBufferSourceNode::setLooping): (WebCore::AudioBufferSourceNode::gain): (WebCore::AudioBufferSourceNode::playbackRate): (WebCore::AudioBufferSourceNode::setPannerNode):
  • webaudio/AudioBufferSourceNode.idl: Added.
19:23 Changeset [71204] by mrobinson@webkit.org

2010-11-02 Martin Robinson <mrobinson@igalia.com>

Reviewed by Adam Barth.

[Cairo] Remove PlatformRefPtrCairo
https://bugs.webkit.org/show_bug.cgi?id=48192

Replace PlatformRefPtrCairo with a RefPtr specialization for Cairo and
Fontconfig types. This is the first step toward removing PlatformRefPtr,
whose job is better handled by RefPtr.

  • CMakeListsEfl.txt: Update the sources list to include RefPtrCairo instead of PlatformRefPtrCairo.
  • GNUmakefile.am: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • platform/graphics/GraphicsContext.h: Replace PlatformRefPtrCairo with RefPtrCairo.
  • platform/graphics/cairo/CairoUtilities.cpp: Ditto. (WebCore::drawPatternToCairoContext): Ditto.
  • platform/graphics/cairo/FontCacheFreeType.cpp: Ditto. (WebCore::FontCache::getFontDataForCharacters): Ditto. (WebCore::FontCache::createFontPlatformData): Ditto.
  • platform/graphics/cairo/FontPlatformDataFreeType.cpp: Ditto. (WebCore::FontPlatformData::FontPlatformData): Ditto. (WebCore::FontPlatformData::initializeWithFontFace): Ditto.
  • platform/graphics/cairo/FontPlatformDataFreeType.h: Ditto.
  • platform/graphics/cairo/GraphicsContextCairo.cpp: Ditto.
  • platform/graphics/cairo/ImageCairo.cpp: Ditto.
  • platform/graphics/cairo/RefPtrCairo.cpp: Renamed from WebCore/platform/graphics/cairo/PlatformRefPtrCairo.cpp. (WTF::refIfNotNull): Added. (WTF::derefIfNotNull): Added.
  • platform/graphics/cairo/RefPtrCairo.h: Renamed from WebCore/platform/graphics/cairo/PlatformRefPtrCairo.h.
  • platform/gtk/CursorGtk.cpp: Replace PlatformRefPtrCairo with RefPtrCairo. (WebCore::createNamedCursor): Ditto.
  • platform/gtk/DragImageGtk.cpp: Ditto. (WebCore::scaleDragImage): Ditto. (WebCore::dissolveDragImageToFraction): Ditto.
  • plugins/gtk/PluginViewGtk.cpp: Ditto. (WebCore::PluginView::paint): Ditto.

2010-11-02 Martin Robinson <mrobinson@igalia.com>

Reviewed by Adam Barth.

[Cairo] Remove PlatformRefPtrCairo
https://bugs.webkit.org/show_bug.cgi?id=48192

Replace instances of PlatformRefPtr smart pointers that wrap Cairo
types with RefPtrs.

  • WebCoreSupport/DragClientGtk.cpp: Use RefPtr instead of PlatformRefPtr. (WebKit::dragIconWindowDrawEventCallback):
  • WebCoreSupport/DragClientGtk.h: Ditto.
19:18 Changeset [71203] by commit-queue@webkit.org

2010-11-02 Jing Jin <jjin@apple.com>

Reviewed by Alexey Proskuryakov.

Key down calls are not being sent to the application.
https://bugs.webkit.org/show_bug.cgi?id=48867

  • UIProcess/API/mac/WKView.mm: (-[WKView keyDown:]): Call super when ignoring a key down.
19:05 Changeset [71202] by commit-queue@webkit.org

Revert 71176 - Merge 71170

BUG=59554

TBR=inferno@chromium.org

19:02 Changeset [71201] by dimich@chromium.org

[Chromium] Unreviewed update of test expectations.
Add Chromium baseline for test added http://trac.webkit.org/changeset/71177.

  • platform/chromium-mac/fast/repaint/selection-rl-expected.checksum: Added.
  • platform/chromium-mac/fast/repaint/selection-rl-expected.png: Added.
18:55 Changeset [71200] by crogers@google.com

2010-11-02 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

Simple followup changes to files affected by AudioNodeInput thread safety
https://bugs.webkit.org/show_bug.cgi?id=48661

No new tests since audio API is not yet implemented.

  • webaudio/AudioBasicProcessorNode.cpp: (WebCore::AudioBasicProcessorNode::checkNumberOfChannelsForInput):
  • webaudio/AudioChannelSplitter.cpp: (WebCore::AudioChannelSplitter::process):
  • webaudio/AudioDestinationNode.cpp: (WebCore::AudioDestinationNode::initialize): (WebCore::AudioDestinationNode::uninitialize): (WebCore::AudioDestinationNode::provideInput):
  • webaudio/AudioGainNode.cpp: (WebCore::AudioGainNode::checkNumberOfChannelsForInput):
  • webaudio/AudioPannerNode.cpp: (WebCore::AudioPannerNode::notifyAudioSourcesConnectedToNode):
18:40 Changeset [71199] by commit-queue@webkit.org

2010-11-02 Adrienne Walker <enne@google.com>

Reviewed by Kenneth Russell.

Fix typo in webgl-test-util.js.
https://bugs.webkit.org/show_bug.cgi?id=48861

  • fast/canvas/webgl/resources/webgl-test-utils.js: (WebGLTestUtils):
18:20 Changeset [71198] by commit-queue@webkit.org

2010-11-02 Chris Guillory <chris.guillory@google.com>

Reviewed by Chris Fleizach.

Chromium: Propagate a document value changed notification on scroll.
https://bugs.webkit.org/show_bug.cgi?id=48817

  • platform/chromium/accessibility/post-notification-ValueChanged-expected.txt:
  • platform/chromium/accessibility/post-notification-ValueChanged.html:

2010-11-02 Chris Guillory <chris.guillory@google.com>

Reviewed by Chris Fleizach.

Chromium: Propagate a document value changed notification on scroll.
https://bugs.webkit.org/show_bug.cgi?id=48817

  • accessibility/AccessibilityObject.h: (WebCore::AccessibilityObject::isAccessibilityScrollbar):
  • accessibility/AccessibilityScrollbar.h: (WebCore::AccessibilityScrollbar::scrollbar): (WebCore::AccessibilityScrollbar::isAccessibilityScrollbar):
  • accessibility/chromium/AXObjectCacheChromium.cpp: (WebCore::AXObjectCache::postPlatformNotification):

2010-11-02 Chris Guillory <chris.guillory@google.com>

Reviewed by Chris Fleizach.

Chromium: Propagate a document value changed notification on scroll.
https://bugs.webkit.org/show_bug.cgi?id=48817

  • src/WebAccessibilityObject.cpp: (WebKit::WebAccessibilityObject::boundingBoxRect):
18:18 Changeset [71197] by dimich@chromium.org

[Chromium] Unreviewed update of test expectations.

  • platform/chromium/test_expectations.txt:
18:07 Changeset [71196] by michaeln@google.com

2010-11-02 Michael Nordman <michaeln@google.com>

Reviewed by Alexey Proskuryakov.

[Chromium] Some work on making appcache layout tests less flaky.
https://bugs.webkit.org/show_bug.cgi?id=48002
1) Make network-simulator.php less slow.
In addition to redirecting back to the requested url, the response contains
multiple content-length headers. Chrome's network stacks considers that an
error condition too and picks up on it faster (one round trip instead of multiple).
This avoids timeouts due to using PHP via slow CGI on windows.
2) Removed canLoad() from appcache/fallback.html layout test, the load()
result is sufficient for determining if it could be loaded. So fewer requests are
made to conduct the test, cutting out more time.
3) Removed some unneeded code from offline-access-frame.html. Appcache events are guaranteed
to be deferred until after 'onload' has happened. This test was coded prior to that
guarantee being satisfied.

  • http/tests/appcache/fallback.html:
  • http/tests/resources/network-simulator.php:
  • http/tests/resources/offline-access-frame.html:
18:00 Changeset [71195] by crogers@google.com

2010-11-02 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

Add ConvolverNode files
https://bugs.webkit.org/show_bug.cgi?id=47941

No new tests since audio API is not yet implemented.

  • webaudio/ConvolverNode.cpp: Added. (WebCore::ConvolverNode::ConvolverNode): (WebCore::ConvolverNode::~ConvolverNode): (WebCore::ConvolverNode::process): (WebCore::ConvolverNode::reset): (WebCore::ConvolverNode::initialize): (WebCore::ConvolverNode::uninitialize): (WebCore::ConvolverNode::setBuffer): (WebCore::ConvolverNode::buffer):
  • webaudio/ConvolverNode.h: Added. (WebCore::ConvolverNode::create):
  • webaudio/ConvolverNode.idl: Added.
17:59 Changeset [71194] by simon.fraser@apple.com

2010-11-02 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

Overlapped nested iframes show smearing when scrolled
https://bugs.webkit.org/show_bug.cgi?id=48873

A FrameView goes into slow scrolling mode (not blitting) when told that it is
overlapped. However, a nested iframe could still try to use fast scrolling
when its parent is overlapped, which could result in bad rendering.

Fixed by making useSlowRepaints() and useSlowRepaintsIfNotOverlapped()
walk up their parent chain, asking if their parents also use slow
repaints.

All the places that call setCanBlitOnScroll() now call
updateCanBlitOnScrollRecursively() to ensure that the canBlitOnScroll
flag is updated correctly on subframes.

Repaint tests do not work on nested iframes, so added manual test.

  • manual-tests/frames/nested-iframe-blit-on-scroll.html: Added.
  • manual-tests/frames/resources/blit-on-scroll-subframe.html: Added.
  • manual-tests/frames/resources/blit-on-scroll-subsubframe.html: Added.
  • page/FrameView.cpp: (WebCore::FrameView::layout): (WebCore::FrameView::useSlowRepaints): (WebCore::FrameView::useSlowRepaintsIfNotOverlapped): (WebCore::FrameView::updateCanBlitOnScrollRecursively): (WebCore::FrameView::setUseSlowRepaints): (WebCore::FrameView::addSlowRepaintObject): (WebCore::FrameView::removeSlowRepaintObject): (WebCore::FrameView::addFixedObject): (WebCore::FrameView::removeFixedObject): (WebCore::FrameView::setIsOverlapped): (WebCore::FrameView::setContentIsOpaque):
  • page/FrameView.h:
17:44 Changeset [71193] by crogers@google.com

2010-11-02 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

Add RealtimeAnalyser files
https://bugs.webkit.org/show_bug.cgi?id=48810

No new tests since audio API is not yet implemented.

  • webaudio/RealtimeAnalyser.cpp: Added. (WebCore::RealtimeAnalyser::RealtimeAnalyser): (WebCore::RealtimeAnalyser::~RealtimeAnalyser): (WebCore::RealtimeAnalyser::reset): (WebCore::RealtimeAnalyser::setFftSize): (WebCore::RealtimeAnalyser::writeInput): (WebCore::RealtimeAnalyser::doFFTAnalysis): (WebCore::RealtimeAnalyser::getFloatFrequencyData): (WebCore::RealtimeAnalyser::getByteFrequencyData): (WebCore::RealtimeAnalyser::getByteTimeDomainData):
  • webaudio/RealtimeAnalyser.h: Added. (WebCore::RealtimeAnalyser::fftSize): (WebCore::RealtimeAnalyser::frequencyBinCount): (WebCore::RealtimeAnalyser::setMinDecibels): (WebCore::RealtimeAnalyser::minDecibels): (WebCore::RealtimeAnalyser::setMaxDecibels): (WebCore::RealtimeAnalyser::maxDecibels): (WebCore::RealtimeAnalyser::setSmoothingTimeConstant): (WebCore::RealtimeAnalyser::smoothingTimeConstant): (WebCore::RealtimeAnalyser::magnitudeBuffer):
17:30 Changeset [71192] by mihaip@chromium.org

2010-11-02 Mihai Parparita <mihaip@chromium.org>

Update the pixel expectations for fast/canvas, fast/css-generated-content, fast/inline-block, fast/inline, and fast/overflow for the Mac port.

For the tests that currently fail on Snow Leopard with --pixel-tests
--tolerance 0, this moves the current pixel results to mac-leopard and
adds new Snow Leopard-specific results to platform/mac.

List of files omitted due to length but composed entirely of moves from
platform/mac to platform/mac-leopard and newly added files in
platform/mac.

17:25 Changeset [71191] by commit-queue@webkit.org

2010-11-02 Ilya Sherman <isherman@chromium.org>

Reviewed by Kent Tamura.

Avoid overlapping label text in autofill popup with icon.
Updates the menu width computation to take the icon width into account.
https://bugs.webkit.org/show_bug.cgi?id=48497

  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupListBox::paintRow): (WebCore::PopupListBox::layout):
17:23 Changeset [71190] by zmo@google.com

2010-10-28 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Perform framebuffer attachment checking upon draw call rather than attachment
https://bugs.webkit.org/show_bug.cgi?id=46318

  • html/canvas/WebGLFramebuffer.cpp: (WebCore::getInternalFormat): Helper function to get an attachment's internal format. (WebCore::isUninitialized): Helper function to decide if an attachment is initialized or not. (WebCore::setInitialized): Helper funtion to set an attachment as being initialized. (WebCore::WebGLFramebuffer::setAttachment): No longer perform buffer initialization at this point. (WebCore::WebGLFramebuffer::removeAttachment): Ditto. (WebCore::WebGLFramebuffer::getColorBufferFormat): Make it const. (WebCore::WebGLFramebuffer::isIncomplete): Attachments conflict check. (WebCore::WebGLFramebuffer::onAccess): Check atatchment conflicts and buffer initialization if necessary. (WebCore::WebGLFramebuffer::initializeRenderbuffers): Return a boolean whether the framebuffer is complete or not.
  • html/canvas/WebGLFramebuffer.h: Add new function declaration and remove some outdated functions. (WebCore::WebGLFramebuffer::isColorAttached): (WebCore::WebGLFramebuffer::isDepthAttached): Make this private. (WebCore::WebGLFramebuffer::isStencilAttached): Ditto. (WebCore::WebGLFramebuffer::isDepthStencilAttached): Ditto.
  • html/canvas/WebGLRenderbuffer.h: (WebCore::WebGLRenderbuffer::setInternalFormat): Also set the renderbuffer as uninitialized.
  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::bindFramebuffer): No longer perform framebuffer initialization at this point. (WebCore::WebGLRenderingContext::checkFramebufferStatus): Check WebGL specific attachment conflicts. (WebCore::WebGLRenderingContext::clear): Call WebGLFramebuffer::onAccess. (WebCore::WebGLRenderingContext::copyTexImage2D): Ditto. (WebCore::WebGLRenderingContext::copyTexSubImage2D): Ditto. (WebCore::WebGLRenderingContext::drawArrays): Ditto. (WebCore::WebGLRenderingContext::drawElements): Ditto. (WebCore::WebGLRenderingContext::framebufferRenderbuffer): No longer perform framebuffer initialization at this point. (WebCore::WebGLRenderingContext::readPixels): Call WebGLFramebuffer::onAccess. (WebCore::WebGLRenderingContext::renderbufferStorage): No longer perform framebuffer initialization at this point. (WebCore::WebGLRenderingContext::texImage2DBase): Ditto.

2010-10-28 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Perform framebuffer attachment checking upon draw call rather than attachment
https://bugs.webkit.org/show_bug.cgi?id=46318

  • fast/canvas/webgl/framebuffer-object-attachment-expected.txt:
  • fast/canvas/webgl/framebuffer-object-attachment.html:
17:06 Changeset [71189] by mihaip@chromium.org

2010-11-02 Mihai Parparita <mihaip@chromium.org>

Update the pixel expectations for fast/flexbox, fast/frames, fast/invalid, fast/layers, and fast/lists for the Mac port.

For the tests that currently fail on Snow Leopard with --pixel-tests
--tolerance 0, this moves the current pixel results to mac-leopard and
adds new Snow Leopard-specific results to platform/mac.

List of files omitted due to length but composed entirely of moves from
platform/mac to platform/mac-leopard and newly added files in
platform/mac.

16:50 Changeset [71188] by andersca@apple.com

Add Null and Int32 to NPVariantData
https://bugs.webkit.org/show_bug.cgi?id=48887

Reviewed by John Sullivan.

  • Shared/Plugins/NPRemoteObjectMap.cpp:

(WebKit::NPRemoteObjectMap::npVariantToNPVariantData):
(WebKit::NPRemoteObjectMap::npVariantDataToNPVariant):

  • Shared/Plugins/NPVariantData.cpp:

(WebKit::NPVariantData::NPVariantData):
(WebKit::NPVariantData::makeNull):
(WebKit::NPVariantData::makeInt32):
(WebKit::NPVariantData::encode):
(WebKit::NPVariantData::decode):

  • Shared/Plugins/NPVariantData.h:

(WebKit::NPVariantData::int32Value):

16:40 Changeset [71187] by mihaip@chromium.org

2010-11-02 Mihai Parparita <mihaip@chromium.org>

Update the pixel expectations for fast/forms for the Mac port.

For the tests that currently fail on Snow Leopard with --pixel-tests
--tolerance 0, this moves the current pixel results to mac-leopard and
adds new Snow Leopard-specific results to platform/mac.

List of files omitted due to length but composed entirely of moves from
platform/mac to platform/mac-leopard and newly added files in
platform/mac.

16:36 Changeset [71186] by jam@chromium.org

2010-10-29 John Abd-El-Malek <jam@chromium.org>

Reviewed by Darin Fisher.

[chromium]: Allow plugins to use optimized scrolling
https://bugs.webkit.org/show_bug.cgi?id=48660

  • public/WebPluginContainer.h:
  • src/WebPluginContainerImpl.cpp: (WebKit::WebPluginContainerImpl::scrollRect):
  • src/WebPluginContainerImpl.h:
16:25 Changeset [71185] by zmo@google.com

2010-11-01 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

blendFunc should generate INVALID_OPERATION if constant color and constant alpha are together as source and destination factors
https://bugs.webkit.org/show_bug.cgi?id=48674

Test: fast/canvas/webgl/webgl-specific.html

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::blendFunc): (WebCore::WebGLRenderingContext::blendFuncSeparate):
  • html/canvas/WebGLRenderingContext.h: (WebCore::WebGLRenderingContext::validateBlendFuncFactors): Helper function to do the checking.

2010-11-01 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

blendFunc should generate INVALID_OPERATION if constant color and constant alpha are together as source and destination factors
https://bugs.webkit.org/show_bug.cgi?id=48674

  • fast/canvas/webgl/webgl-specific-expected.txt: Added.
  • fast/canvas/webgl/webgl-specific.html: Added.
16:20 Changeset [71184] by dimich@chromium.org

[Chromium] Unreviewed update of test expectations.
Add Chromium baseline for a test added in http://trac.webkit.org/changeset/71177.

  • platform/chromium-linux/fast/repaint/selection-rl-expected.checksum: Added.
  • platform/chromium-linux/fast/repaint/selection-rl-expected.png: Added.
  • platform/chromium-win/fast/repaint/selection-rl-expected.checksum: Added.
  • platform/chromium-win/fast/repaint/selection-rl-expected.png: Added.
  • platform/chromium-win/fast/repaint/selection-rl-expected.txt: Added.
16:16 Changeset [71183] by andersca@apple.com

Add support for NP_HasMethod and NP_Invoke
https://bugs.webkit.org/show_bug.cgi?id=48882

Reviewed by Adam Roben.

WebKit2:

  • Platform/CoreIPC/HandleMessage.h:

(CoreIPC::callMemberFunction):
Add new overload.

  • Shared/Plugins/NPObjectMessageReceiver.cpp:

(WebKit::NPObjectMessageReceiver::hasMethod):
Call hasMethod and return the result.

(WebKit::NPObjectMessageReceiver::invoke):
Convert the arguments, call invoke and return the result.

(WebKit::NPObjectMessageReceiver::getProperty):
Release the converted variant.

  • Shared/Plugins/NPObjectMessageReceiver.messages.in:

Add HasMethod and Invoke messages.

  • Shared/Plugins/NPObjectProxy.cpp:

(WebKit::NPObjectProxy::hasMethod):
Send the HasMethod message.

(WebKit::NPObjectProxy::invoke):
Send the Invoke message.

(WebKit::NPObjectProxy::NP_HasMethod):
Call hasMethod.

(WebKit::NPObjectProxy::NP_Invoke):
Call invoke.

LayoutTests:

Remove now passing tests.

  • platform/mac-wk2/Skipped:
16:12 Changeset [71182] by simon.fraser@apple.com

2010-11-02 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

Iframes nested inside a compositing layer don't repaint correctly
https://bugs.webkit.org/show_bug.cgi?id=48880
<rdar://problem/8194698>

The isEnclosedInCompositingLayer() is used to modify the behavior of
-[WebClipView visibleRect:] in WebKit, so that scrolling-related repaints
are correct in composited iframes. Previously it only asked whether the
frame's renderer was in a compositing layer, but we actually need to
consult all ancestors.

Test: compositing/iframes/nested-iframe-scrolling.html

  • page/FrameView.cpp: (WebCore::FrameView::isEnclosedInCompositingLayer):
16:02 Changeset [71181] by dimich@chromium.org

[Chromium] Unreviewed update of test expectations.

  • platform/chromium/test_expectations.txt:
15:48 Changeset [71180] by andersca@apple.com

Fix build.

  • TestWebKitAPI/PlatformUtilities.cpp:

(TestWebKitAPI::Util::createContextForInjectedBundleTest):

15:35 Changeset [71179] by commit-queue@webkit.org

2010-11-02 Marc-Antoine Ruel <maruel@chromium.org>

Reviewed by Dimitri Glazkov.

Disable incremental linking for webkit_unit_test and DumpRenderTRee on x86 Windows on chromium build.
https://bugs.webkit.org/show_bug.cgi?id=48836

It fails to link otherwise due to lack of virtual address space.

  • WebKit.gyp:
15:28 Changeset [71178] by andersca@apple.com

Implement NP_HasProperty for NPObjectProxy
https://bugs.webkit.org/show_bug.cgi?id=48876

Reviewed by Sam Weinig.

WebKit2:

  • Shared/Plugins/NPObjectMessageReceiver.cpp:

(WebKit::NPObjectMessageReceiver::hasProperty):
Call The hasProperty callback function.

  • Shared/Plugins/NPObjectMessageReceiver.messages.in:

Add HasProperty message.

  • Shared/Plugins/NPObjectProxy.cpp:

(WebKit::NPObjectProxy::hasProperty):
Send the HasProperty message.

(WebKit::NPObjectProxy::NP_HasProperty):
Call hasProperty.

LayoutTests:

Remove now passing test.

  • platform/mac-wk2/Skipped:
15:21 Changeset [71177] by hyatt@apple.com

https://bugs.webkit.org/show_bug.cgi?id=48672

Reviewed by Dan Bernstein.

Make vertical glyph offset hit testing work with inline boxes. This allows selection to paint
properly for vertical text (although gap-filling is still broken).

Refactored and cleaned up the writing mode flipping functions, and also did some cleanup to
better share code between hit testing and painting.

WebCore:

  • rendering/InlineBox.cpp:

(WebCore::InlineBox::locationIncludingFlipping):
(WebCore::InlineBox::flipForWritingMode):

  • rendering/InlineBox.h:
  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::nodeAtPoint):
(WebCore::InlineFlowBox::paint):
(WebCore::InlineFlowBox::paintBoxDecorations):
(WebCore::InlineFlowBox::paintMask):

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::selectionRect):
(WebCore::InlineTextBox::nodeAtPoint):
(WebCore::InlineTextBox::paint):
(WebCore::InlineTextBox::textPos):
(WebCore::InlineTextBox::offsetForPosition):
(WebCore::InlineTextBox::positionForOffset):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paintChildren):
(WebCore::RenderBlock::paintFloats):
(WebCore::RenderBlock::hitTestFloats):
(WebCore::RenderBlock::hitTestContents):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeRectForRepaint):
(WebCore::RenderBox::flipForWritingMode):
(WebCore::RenderBox::locationOffsetIncludingFlipping):

  • rendering/RenderBox.h:
  • rendering/RenderInline.cpp:

(WebCore::RenderInline::clippedOverflowRectForRepaint):

  • rendering/RenderLineBoxList.cpp:

(WebCore::RenderLineBoxList::rangeIntersectsRect):
(WebCore::RenderLineBoxList::anyLineIntersectsRect):
(WebCore::RenderLineBoxList::lineIntersectsDirtyRect):
(WebCore::RenderLineBoxList::paint):
(WebCore::RenderLineBoxList::hitTest):

  • rendering/RenderLineBoxList.h:
  • rendering/RenderText.cpp:

(WebCore::RenderText::positionForPoint):

LayoutTests:

  • fast/repaint/selection-rl.html: Added.
  • platform/mac/fast/repaint/selection-rl-expected.checksum: Added.
  • platform/mac/fast/repaint/selection-rl-expected.png: Added.
  • platform/mac/fast/repaint/selection-rl-expected.txt: Added.
15:15 Changeset [71176] by inferno@chromium.org

Merge 71170

BUG=59554

15:06 Changeset [71175] by weinig@apple.com

Add a way to send startup messages on the context which can be posted when a process launches
<rdar://problem/8617928>
https://bugs.webkit.org/show_bug.cgi?id=48838

Reviewed by Anders Carlsson.

WebKit2:

Adds WKContextSetInitializationUserDataForInjectedBundle which sets an
APIObject on WebContext to be sent to the InjectedBundle's WKBundleInitialize
function each time a process starts up. This can help in cases where
the WebProcess dies, and will be helpful in the world where there are
multiple WebProcess's per context.

  • Scripts/webkit2/messages.py:
  • UIProcess/API/C/WKContext.cpp:

(WKContextSetInitializationUserDataForInjectedBundle):

  • UIProcess/API/C/WKContext.h:
  • UIProcess/WebContext.cpp:

(WebKit::WebContext::ensureWebProcess):

  • UIProcess/WebContext.h:

(WebKit::WebContext::setInjectedBundleInitializationUserData):
(WebKit::WebContext::injectedBundleInitializationUserData):

  • WebProcess/InjectedBundle/API/c/WKBundleInitialize.h:
  • WebProcess/InjectedBundle/InjectedBundle.h:
  • WebProcess/InjectedBundle/mac/InjectedBundleMac.cpp:

(WebKit::InjectedBundle::load):

  • WebProcess/InjectedBundle/qt/InjectedBundleQt.cpp:

(WebKit::InjectedBundle::load):

  • WebProcess/InjectedBundle/win/InjectedBundleWin.cpp:

(WebKit::InjectedBundle::load):

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeWebProcess):

  • WebProcess/WebProcess.h:
  • WebProcess/WebProcess.messages.in:

WebKitTools:

  • MiniBrowser/mac/WebBundle/WebBundleMain.m:

(WKBundleInitialize):

  • TestWebKitAPI/InjectedBundleController.cpp:

(TestWebKitAPI::InjectedBundleController::initialize):
(TestWebKitAPI::InjectedBundleController::didReceiveMessage):

  • TestWebKitAPI/InjectedBundleController.h:
  • TestWebKitAPI/InjectedBundleMain.cpp:

(WKBundleInitialize):

  • TestWebKitAPI/PlatformUtilities.cpp:

(TestWebKitAPI::Util::createContextForInjectedBundleTest):

  • WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:

(WKBundleInitialize):
Update implementations of WKBundleInitialize to take an initial userData
argument. Change TestWebKitAPI to use the new initial userData to initialize
each test's bundle.

15:01 Changeset [71174] by abarth@webkit.org

2010-11-02 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

JPEG decoders should understand color profiles
https://bugs.webkit.org/show_bug.cgi?id=48819

This patch is currently a no-op because no one defines USE(ICCJPEG).
We'll enable this for Chromium Mac once we have ICCJPEG landed in
Chromium's third_party directory.

  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp: (WebCore::readColorProfile): (WebCore::JPEGImageReader::JPEGImageReader): (WebCore::JPEGImageReader::decode): (WebCore::JPEGImageDecoder::outputScanlines):
  • platform/image-decoders/jpeg/JPEGImageDecoder.h: (WebCore::JPEGImageDecoder::setColorProfile):
14:54 Changeset [71173] by andersca@apple.com

Implement PluginProxy::pluginScriptableNPObject
https://bugs.webkit.org/show_bug.cgi?id=48874

Reviewed by Sam Weinig.

  • PluginProcess/PluginControllerProxy.cpp:

(WebKit::PluginControllerProxy::getPluginScriptableNPObject):
Ask the plug-in for its scriptable NPObject, register it with the map and return its object ID.

  • PluginProcess/PluginControllerProxy.messages.in:

Add GetPluginScriptableNPObject message.

  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::pluginScriptableNPObject):
Send the GetPluginScriptableNPObject message.

14:35 Changeset [71172] by paroga@webkit.org

2010-11-02 Patrick Gansterer <paroga@webkit.org>

Unreviewed, build fix after r71041.

  • WebCoreSupport/ChromeClientWinCE.h: (WebKit::ChromeClientWinCE::showContextMenu):
14:31 WebKit Team edited by leviw@google.com
Updating my company to Google. (diff)
14:26 Changeset [71171] by andersca@apple.com

Add strings to NPVariantData
https://bugs.webkit.org/show_bug.cgi?id=48871

Reviewed by Dan Bernstein.

  • Shared/Plugins/NPRemoteObjectMap.cpp:

(WebKit::NPRemoteObjectMap::npVariantToNPVariantData):
(WebKit::NPRemoteObjectMap::npVariantDataToNPVariant):

  • Shared/Plugins/NPVariantData.cpp:

(WebKit::NPVariantData::makeString):
(WebKit::NPVariantData::encode):
(WebKit::NPVariantData::decode):

  • Shared/Plugins/NPVariantData.h:

(WebKit::NPVariantData::stringValue):

14:23 Changeset [71170] by mihaip@chromium.org

2010-11-02 Mihai Parparita <mihaip@chromium.org>

Reviewed by Adam Barth.

[Chromium] Crash when encountering history.back() call during Page::goToItem execution
https://bugs.webkit.org/show_bug.cgi?id=48477

Add a reduced version of the page that was originally reported at
http://crbug.com/59554.

  • http/tests/history/back-during-onload-triggered-by-back-expected.txt: Added.
  • http/tests/history/back-during-onload-triggered-by-back.html: Added.
  • http/tests/history/resources/back-during-onload-container.html: Added.
  • http/tests/history/resources/back-during-onload-hung-page.php: Added.
  • http/tests/history/resources/back-during-onload-middle.html: Added.

2010-11-02 Mihai Parparita <mihaip@chromium.org>

Reviewed by Adam Barth.

[Chromium] Crash when encountering history.back() call during Page::goToItem execution
https://bugs.webkit.org/show_bug.cgi?id=48477

For the Chromium port, BackForwardList::itemAtIndex synthesizes a
HistoryItem and saves a pointer to it in m_pendingItem. During
Page::goToItem we call FrameLoader::stopAllLoaders, which can trigger
onload handlers (if a subframe was not considered committed by the frame
loader). If one of those handlers calls calls history.back() or another
operation that ends up in NavigationScheduler::scheduleHistoryNavigation,
we would call BackForwardList::itemAtIndex, which means that we would
lose the m_pendingItem RefPtr that pointed to the item being navigated
to, causing its ref count to go to 0*, and thus for the HistoryItem to
be deleted before we were done navigating to it.

This is fixed in two ways:

  • Add a protector RefPtr in Page::goToItem to make sure that the item is still around for when we pass it to HistoryController:goToItem.
  • Change NavigationScheduler::scheduleHistoryNavigation to not use BackForwardList::itemAtIndex and instead look at the forward/backListCount() (since it doesn't actually care about the returned HistoryItem).

Test: http/tests/history/back-during-onload-triggered-by-back.html

  • loader/NavigationScheduler.cpp: (WebCore::NavigationScheduler::scheduleHistoryNavigation):
  • page/Page.cpp: (WebCore::Page::goToItem):
14:18 Changeset [71169] by andersca@apple.com

Add convenience functions for allocating NPAPI memory
https://bugs.webkit.org/show_bug.cgi?id=48870

Reviewed by Dan Bernstein.

Add npnMemAlloc, npnMemFree and createNPString functions and
npnMemNew, npnMemNewArray function templates.

  • WebProcess/Plugins/Netscape/JSNPObject.cpp:

(WebKit::JSNPObject::getOwnPropertyNames):
Use npnMemFree.

  • WebProcess/Plugins/Netscape/NPJSObject.cpp:

(WebKit::NPJSObject::enumerate):
Use npnMemNewArray.

  • WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:

(WebKit::NPRuntimeObjectMap::convertJSValueToNPVariant):
Use createNPString.

  • WebProcess/Plugins/Netscape/NPRuntimeUtilities.cpp:

(WebKit::npnMemAlloc):
Call malloc.

(WebKit::npnMemFree):
Call free.

(WebKit::createNPString):
Allocate the characters for a new NPString.

(WebKit::createNPObject):
Call npnMemNew.

(WebKit::deallocateNPObject):
Call npnMemFree.

(WebKit::releaseNPVariantValue):
Call npnMemFree.

  • WebProcess/Plugins/Netscape/NPRuntimeUtilities.h:

(WebKit::npnMemNew):
(WebKit::npnMemNewArray):
Add new functions.

  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:

(WebKit::NPN_MemAlloc):
Call npnMemAlloc.

(WebKit::NPN_MemFree):
Call npnMemFree.

(WebKit::NPN_UTF8FromIdentifier):
Call npnMemNewArray.

(WebKit::copyCString):
Call npnMemNewArray. Correctly initialize the "len" out parameter.

14:14 Changeset [71168] by jberlin@webkit.org

Windows build fix. Unreviewed.

  • win/WebKit2Generated.make:

Add WKInspector.h so that it is copied over to the WebKitBuild directory.

14:13 Changeset [71167] by dimich@chromium.org

[Chromium] Unreviewed update of test expectations.
Move the expected file higher up so it's used for all chromium flavors.

  • platform/chromium/security/block-test-no-port-expected.txt: Renamed from LayoutTests/platform/chromium-mac/security/block-test-no-port-expected.txt.
14:05 Changeset [71166] by commit-queue@webkit.org

2010-11-02 Jenn Braithwaite <jennb@chromium.org>

Reviewed by Andreas Kling.

fast/frames/iframe-reparenting-new-page.html output is ordered wrong
https://bugs.webkit.org/show_bug.cgi?id=48807

  • fast/frames/iframe-reparenting-new-page-expected.txt:
  • fast/frames/script-tests/iframe-reparenting-new-page.js: (finish):
14:02 Changeset [71165] by beidson@apple.com

<rdar://problem/8346191> and https://bugs.webkit.org/show_bug.cgi?id=48868
Implement IMutableWebRequest::setTimeoutInterval

Reviewed by Anders Carlsson.

  • WebMutableURLRequest.cpp:

(WebMutableURLRequest::setTimeoutInterval):

14:01 Changeset [71164] by zmo@google.com

2010-10-28 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Update getUniform for bvec[234] to return boolean[] rather than Uint8Array
https://bugs.webkit.org/show_bug.cgi?id=47568

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::getUniform):

2010-10-28 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Update getUniform for bvec[234] to return boolean[] rather than Uint8Array
https://bugs.webkit.org/show_bug.cgi?id=47568

  • fast/canvas/webgl/gl-object-get-calls-expected.txt:
  • fast/canvas/webgl/gl-object-get-calls.html:
13:53 Changeset [71163] by crogers@google.com

2010-11-02 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

Add RealtimeAnalyserNode files
https://bugs.webkit.org/show_bug.cgi?id=48798

No new tests since audio API is not yet implemented.

  • webaudio/RealtimeAnalyserNode.cpp: Added. (WebCore::RealtimeAnalyserNode::RealtimeAnalyserNode): (WebCore::RealtimeAnalyserNode::~RealtimeAnalyserNode): (WebCore::RealtimeAnalyserNode::process): (WebCore::RealtimeAnalyserNode::pullInputs): (WebCore::RealtimeAnalyserNode::reset):
  • webaudio/RealtimeAnalyserNode.h: Added. (WebCore::RealtimeAnalyserNode::create): (WebCore::RealtimeAnalyserNode::fftSize): (WebCore::RealtimeAnalyserNode::setFftSize): (WebCore::RealtimeAnalyserNode::frequencyBinCount): (WebCore::RealtimeAnalyserNode::setMinDecibels): (WebCore::RealtimeAnalyserNode::minDecibels): (WebCore::RealtimeAnalyserNode::setMaxDecibels): (WebCore::RealtimeAnalyserNode::maxDecibels): (WebCore::RealtimeAnalyserNode::setSmoothingTimeConstant): (WebCore::RealtimeAnalyserNode::smoothingTimeConstant): (WebCore::RealtimeAnalyserNode::getFloatFrequencyData): (WebCore::RealtimeAnalyserNode::getByteFrequencyData): (WebCore::RealtimeAnalyserNode::getByteTimeDomainData):
  • webaudio/RealtimeAnalyserNode.idl: Added.
13:48 Changeset [71162] by commit-queue@webkit.org

2010-11-02 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r71152.
http://trac.webkit.org/changeset/71152
https://bugs.webkit.org/show_bug.cgi?id=48866

Causes lots and lots of crashes (Requested by jamesr_ on
#webkit).

  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp: (WebCore::JPEGImageReader::JPEGImageReader): (WebCore::JPEGImageReader::decode): (WebCore::JPEGImageDecoder::outputScanlines):
  • platform/image-decoders/jpeg/JPEGImageDecoder.h:
13:47 Changeset [71161] by cmarrin@apple.com

2010-11-02 Chris Marrin <cmarrin@apple.com>

Reviewed by Simon Fraser.

When animations are paused, play-state can cause them to be unpaused.
https://bugs.webkit.org/show_bug.cgi?id=46525

I Changed updatePlayState() to only unpause when both play-state is
"running" and not suspended. Likewise I pause animation when either
play-state is "paused" or suspended.

Test: animations/play-state-suspend.html

  • page/animation/AnimationBase.cpp: (WebCore::AnimationBase::updatePlayState):
13:42 Changeset [71160] by commit-queue@webkit.org

2010-11-02 Benjamin Kalman <kalman@google.com>

Reviewed by Ojan Vafai.

new-run-webkit-tests doesn't strip "LayoutTests/" from prefix, unlike old-run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=48794

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py: Strip the "LayoutTests/" prefix from test argument paths.
13:34 Changeset [71159] by ap@apple.com

Reviewed by Timothy Hatcher.

https://bugs.webkit.org/show_bug.cgi?id=48813
<rdar://problem/8602552> REGRESSION (r63622): DNS prefetching for <link> tags doesn't work
in non-HTTP documents

Cannot test DNS prefetching.

  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::process): We should be looking at preferences, not at whether this document has prefetching enabled.
13:30 Changeset [71158] by commit-queue@webkit.org

2010-11-02 Ilya Sherman <isherman@chromium.org>

Reviewed by Kent Tamura.

Expose the sendChangeEvent parameter in WebInputElement::setValue() API,
primarily so that chromium form autofill can fire the onChange event.
https://bugs.webkit.org/show_bug.cgi?id=48177

  • public/WebInputElement.h:
  • src/WebInputElement.cpp: (WebKit::WebInputElement::setValue):
13:28 Changeset [71157] by dimich@chromium.org

[Chromium] Unreviewed update of test expectations.
Intentional error result to narrow down a regression caused by http://codereview.chromium.org/3976004

  • platform/chromium-mac/security/block-test-no-port-expected.txt:
13:24 Changeset [71156] by andersca@apple.com

Add some support for remote and local NPObjects to NPRemoteObjectMap
https://bugs.webkit.org/show_bug.cgi?id=48864

Reviewed by Adam Roben.

  • Shared/Plugins/NPRemoteObjectMap.cpp:

(WebKit::NPRemoteObjectMap::npVariantToNPVariantData):
If the NPVariant contains an NPObject that isn't an NPObjectProxy, register it
and return its ID.

(WebKit::NPRemoteObjectMap::npVariantDataToNPVariant):
If the NPVariantData contains a remote object, create an NPObjectProxy and return it.

  • Shared/Plugins/NPVariantData.cpp:

(WebKit::NPVariantData::NPVariantData):
Initialize m_localNPObjectIDValue and m_remoteNPObjectIDValue.

(WebKit::NPVariantData::makeLocalNPObjectID):
Create an NPVariantData that contains a local NPObject ID.

(WebKit::NPVariantData::encode):
Handle local and remote NPObject IDs.

(WebKit::NPVariantData::decode):
Decode local and remote NPObject IDs and "swap them" so an encoded remote NPObject ID is
decoded as a local NPObjectID (and vice versa).

  • Shared/Plugins/NPVariantData.h:

(WebKit::NPVariantData::localNPObjectIDValue):
(WebKit::NPVariantData::remoteNPObjectIDValue):

12:52 Changeset [71155] by aroben@apple.com

Windows build fix after r71127

MSVC isn't smart enough to figure out that the definition of the global
nullptr variable isn't needed, so we provide one for it.

Fixes <http://webkit.org/b/48862> Windows build is broken due to
undefined symbol nullptr

Reviewed by Anders Carlsson.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Export nullptr.

resort the files.

  • wtf/NullPtr.cpp: Added.
12:51 Changeset [71154] by pfeldman@chromium.org

2010-11-02 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: Web Inspector: follow up to r71139. Fixed Mac monospace
height style.

  • inspector/front-end/PropertiesSection.js: (WebInspector.PropertiesSection):
  • inspector/front-end/inspector.css:
12:51 Changeset [71153] by abarth@webkit.org

Merge 71147 - 2010-11-02 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

querySelectorAll('body>:last-child') does not work unless HTML file ends with 'new-line'.
https://bugs.webkit.org/show_bug.cgi?id=47166

We need to pop all the open elements when we end the document in the
AfterAfterBody state.

Test: fast/parser/pop-all-after-after-body.html

  • html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processEndOfFile):

2010-11-02 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

querySelectorAll('body>:last-child') does not work unless HTML file ends with 'new-line'.
https://bugs.webkit.org/show_bug.cgi?id=47166

Test that :last-child works when we end the document in the
AfterAfterBody state.

  • fast/parser/pop-all-after-after-body-expected.txt: Added.
  • fast/parser/pop-all-after-after-body.html: Added.

TBR=abarth@webkit.org

12:45 Changeset [71152] by abarth@webkit.org

2010-11-02 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

JPEG decoders should understand color profiles
https://bugs.webkit.org/show_bug.cgi?id=48819

This patch is currently a no-op because no one defines USE(ICCJPEG).
We'll enable this for Chromium Mac once we have ICCJPEG landed in
Chromium's third_party directory.

  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp: (WebCore::readColorProfile): (WebCore::JPEGImageReader::JPEGImageReader): (WebCore::JPEGImageReader::decode): (WebCore::JPEGImageDecoder::outputScanlines):
  • platform/image-decoders/jpeg/JPEGImageDecoder.h: (WebCore::JPEGImageDecoder::setColorProfile):
12:39 Changeset [71151] by jamesr@google.com

2010-11-02 James Robinson <jamesr@chromium.org>

Update pixel baselines for Snow Leopard for tests in fast/text/*

12:37 Changeset [71150] by commit-queue@webkit.org

2010-11-02 Ilya Sherman <isherman@chromium.org>

Reviewed by Simon Fraser.

Marks selectionStart() and selectionEnd() as const.
https://bugs.webkit.org/show_bug.cgi?id=48786

  • html/HTMLFormControlElement.cpp: (WebCore::HTMLTextFormControlElement::selectionStart): (WebCore::HTMLTextFormControlElement::selectionEnd):
  • html/HTMLFormControlElement.h:
12:29 Changeset [71149] by crogers@google.com

2010-11-02 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

Fix license for audio files
https://bugs.webkit.org/show_bug.cgi?id=48859

  • webaudio/AudioChannelSplitter.cpp:
  • webaudio/AudioChannelSplitter.h:
  • webaudio/AudioDestinationNode.cpp:
  • webaudio/AudioDestinationNode.h:
  • webaudio/AudioGainNode.cpp:
  • webaudio/AudioGainNode.h:
  • webaudio/AudioPannerNode.cpp:
  • webaudio/AudioPannerNode.h:
  • webaudio/AudioPannerNode.idl:
12:20 Changeset [71148] by mrobinson@webkit.org

2010-11-02 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

Remove special handling of HashTableDeletedValue in PlatformRefPtr and manually manage memory that cannot be controlled by HashTraits
https://bugs.webkit.org/show_bug.cgi?id=48841

Remove special handling of HashTableDeletedValue in PlatformRefPtr.
This is better handled on a case-by-case basis, when HashTraits
cannot account for it.

  • wtf/PlatformRefPtr.h: (WTF::PlatformRefPtr::~PlatformRefPtr): (WTF::PlatformRefPtr::clear): (WTF::::operator):

2010-11-02 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

Remove special handling of HashTableDeletedValue in PlatformRefPtr and manually manage memory that cannot be controlled by HashTraits
https://bugs.webkit.org/show_bug.cgi?id=48841

Switch to manually managing the memory in FontPlatformDataFreeType. This
is necessary because smart pointers do not know how to deal with a pointer
value of -1 (HashTableDeletedValue) and HashTraits can only manage the type
contained in the HashMap.

No new tests as this should not change functionality.

  • platform/graphics/cairo/FontPlatformDataFreeType.cpp: (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::operator=): (WebCore::FontPlatformData::~FontPlatformData): (WebCore::FontPlatformData::operator==): (WebCore::FontPlatformData::initializeWithFontFace):
  • platform/graphics/cairo/FontPlatformDataFreeType.h: (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::scaledFont): (WebCore::FontPlatformData::hash): (WebCore::FontPlatformData::isHashTableDeletedValue): (WebCore::FontPlatformData::hashTableDeletedFontValue):
  • platform/graphics/cairo/GlyphPageTreeNodeCairo.cpp: (WebCore::GlyphPage::fill):
  • platform/graphics/cairo/SimpleFontDataCairo.cpp: (WebCore::SimpleFontData::platformInit): (WebCore::SimpleFontData::containsCharacters): (WebCore::SimpleFontData::platformWidthForGlyph):
12:15 Changeset [71147] by abarth@webkit.org

2010-11-02 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

querySelectorAll('body>:last-child') does not work unless HTML file ends with 'new-line'.
https://bugs.webkit.org/show_bug.cgi?id=47166

We need to pop all the open elements when we end the document in the
AfterAfterBody state.

Test: fast/parser/pop-all-after-after-body.html

  • html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processEndOfFile):

2010-11-02 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

querySelectorAll('body>:last-child') does not work unless HTML file ends with 'new-line'.
https://bugs.webkit.org/show_bug.cgi?id=47166

Test that :last-child works when we end the document in the
AfterAfterBody state.

  • fast/parser/pop-all-after-after-body-expected.txt: Added.
  • fast/parser/pop-all-after-after-body.html: Added.
12:08 Changeset [71146] by aroben@apple.com

Skip webkitpy.layout_tests.run_webkit_tests_unittest.MainTest on Cygwin Python 2.5.x

It is known to hang on that version of Python. See
<http://webkit.org/b/48614>.

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: Use

skip_if to skip MainTest on Cygwin Python 2.5.x.

  • Scripts/webkitpy/test/skip.py: Added.

(skip_if): If the passed-in condition is false, find all the test_*
methods of the given class and replace them with a function that just
logs that we're skipping these tests. This is loosely based on the
unittest.skip_if decorator added in Python 3.1.
(_skipped_method): Returns a function that just logs that the tests are
being skipped. This is used in place of the actual test_* functions.

  • Scripts/webkitpy/test/skip_unittest.py: Added.

(SkipTest.setUp): Create a logger for ourselves and give it a handler
that logs to a private stream.
(SkipTest.tearDown): Reset the logger.
(SkipTest.create_fixture_class): Returns a class that we use to test
skip_if. It has a single test_* method, test_foo, that just calls
through to a callback.
(SkipTest.foo_callback): Record that test_foo was called.
(SkipTest.test_skip_if_false): Pass skip_if a False condition and test
that test_foo does get called.
(SkipTest.test_skip_if_true): Pass skip_if a True condition and test
that test_foo does not get called and the appropriate message gets
logged.

12:07 Changeset [71145] by paroga@webkit.org

2010-11-02 Patrick Gansterer <paroga@webkit.org>

Reviewed by Adam Roben.

Cleanup createGlobalImageFileDescriptor in ClipboardWin
https://bugs.webkit.org/show_bug.cgi?id=48189

  • platform/win/ClipboardWin.cpp: (WebCore::ClipboardWin::writeURL):
12:00 Changeset [71144] by pfeldman@chromium.org

2010-11-02 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: display frame names in the resources panel.
https://bugs.webkit.org/show_bug.cgi?id=48839

  • inspector/Inspector.idl:
  • inspector/InspectorResourceAgent.cpp: (WebCore::frameId): (WebCore::buildObjectForDocumentLoader): (WebCore::buildObjectForFrame): (WebCore::buildObjectForFrameTree): (WebCore::InspectorResourceAgent::didCommitLoad): (WebCore::InspectorResourceAgent::frameDetachedFromParent): (WebCore::InspectorResourceAgent::frameForId): (WebCore::InspectorResourceAgent::resourceContent):
  • inspector/InspectorResourceAgent.h:
  • inspector/front-end/ResourceManager.js: (WebInspector.ResourceManager.prototype.didCommitLoadForFrame): (WebInspector.ResourceManager.prototype._processCachedResources): (WebInspector.ResourceManager.prototype._addFramesRecursively): (WebInspector.ResourceTreeModel.prototype.addOrUpdateFrame): (WebInspector.ResourceTreeModel.prototype.didCommitLoadForFrame):
  • inspector/front-end/StoragePanel.js: (WebInspector.StoragePanel.prototype.addOrUpdateFrame): (WebInspector.BaseStorageTreeElement.prototype.get titleText): (WebInspector.FrameTreeElement): (WebInspector.FrameTreeElement.prototype.onattach): (WebInspector.FrameTreeElement.prototype.get nameForSorting): (WebInspector.FrameTreeElement.prototype.setTitles): (WebInspector.FrameTreeElement.prototype.set hovered):
  • inspector/front-end/inspector.css: (li.selected .base-storage-tree-element-subtitle): (.base-storage-tree-element-subtitle):
11:50 Changeset [71143] by pfeldman@chromium.org

2010-11-02 Pavel Feldman <pfeldman@chromium.org>

Not reviewed. Follow up to r71139: removing unused images.
https://bugs.webkit.org/show_bug.cgi?id=48827

  • WebCore.gypi:
  • inspector/front-end/Images/grayConnectorPoint.png: Removed.
  • inspector/front-end/Images/whiteConnectorPoint.png: Removed.
  • inspector/front-end/WebKit.qrc:
11:48 Changeset [71142] by abarth@webkit.org

2010-11-02 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

webkit-patch should tell check-webkit-style which files were changed so
check-webkit-style doesn't have to stat the whole working copy again
https://bugs.webkit.org/show_bug.cgi?id=48792

  • Scripts/webkitpy/tool/mocktool.py:
  • Scripts/webkitpy/tool/steps/checkstyle.py:
11:40 Changeset [71141] by andersca@apple.com

Attempt to fix a GCC release only warning.

  • Shared/Plugins/NPVariantData.cpp:

(WebKit::NPVariantData::NPVariantData):

11:39 Changeset [71140] by andersca@apple.com

Invalidate the NPRemoteObjectMap
https://bugs.webkit.org/show_bug.cgi?id=48856

Reviewed by John Sullivan.

  • Shared/Plugins/NPObjectMessageReceiver.cpp:

(WebKit::NPObjectMessageReceiver::~NPObjectMessageReceiver):
Remove FIXME. The NPRemoteObjectMap always outlives the NPObjectMessageReceiver.

  • Shared/Plugins/NPObjectProxy.cpp:

(WebKit::NPObjectProxy::~NPObjectProxy):
Call npObjectProxyDestroyed here.

(WebKit::NPObjectProxy::invalidate):
Null out m_npRemoteObjectMap.

  • Shared/Plugins/NPRemoteObjectMap.cpp:

(WebKit::NPRemoteObjectMap::~NPRemoteObjectMap):
Add assertions.

(WebKit::NPRemoteObjectMap::createNPObjectProxy):
Keep track of the NPObjectProxy by adding it to the m_npObjectProxies set.

(WebKit::NPRemoteObjectMap::npObjectProxyDestroyed):
Remove the NPObjectProxy from the m_npObjectProxies set.

(WebKit::NPRemoteObjectMap::invalidate):
Delete all NPObjectMessageReceivers. Iterate over all NPObjectProxy objects and invalidate them.

11:31 Changeset [71139] by pfeldman@chromium.org

2010-11-02 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: make properties and event listeners look consistent with the styles section.
https://bugs.webkit.org/show_bug.cgi?id=48827

  • inspector/front-end/EventListenersSidebarPane.js:
  • inspector/front-end/PropertiesSection.js: (WebInspector.PropertiesSection):
  • inspector/front-end/PropertiesSidebarPane.js: (WebInspector.PropertiesSidebarPane.prototype.update.callback): (WebInspector.PropertiesSidebarPane.prototype.update):
  • inspector/front-end/inspector.css: (.events-pane .section:not(:nth-of-type(1))): (.event-bar:first-child): (.section .header): (.section .header::before): (.section.expanded .header::before): (.section .header .title, .event-bar .header .title): (.section .header .subtitle, .event-bar .header .subtitle): (.section.expanded .properties, .event-bar.expanded .event-properties): (.properties-tree): (.event-bar): (.event-bars .event-bar .header): (.event-bars .event-bar .header .title): (.event-bars .event-bar .header::before):

2010-11-02 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: make properties and event listeners look consistent with the styles section.
https://bugs.webkit.org/show_bug.cgi?id=48827

  • src/js/devTools.css:
11:20 Changeset [71138] by mitz@apple.com

Remove unused methods and member variables from AutoTableLayout.

Reviewed by Anders Carlsson.

  • rendering/AutoTableLayout.cpp:

(WebCore::AutoTableLayout::AutoTableLayout): Removed initialization of m_percentagesDirty
and m_totalPercent.
(WebCore::AutoTableLayout::fullRecalc): Removed setting of m_percentagesDirty.
(WebCore::AutoTableLayout::calcPercentages): Removed.

  • rendering/AutoTableLayout.h: Removed totalPercent(), m_percentagesDirty, and m_totalPercent.
11:15 Changeset [71137] by commit-queue@webkit.org

2010-11-02 Robert Kroeger <rjkroege@chromium.org>

Reviewed by James Robinson.

[Chromium/DRT] Make EventSendingController honour leapForward for touch events.
https://bugs.webkit.org/show_bug.cgi?id=48777

  • DumpRenderTree/chromium/EventSender.cpp: (EventSender::sendCurrentTouchEvent):
11:12 Changeset [71136] by pfeldman@chromium.org

2010-11-02 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: clear / hide timing information for cached resources.
https://bugs.webkit.org/show_bug.cgi?id=48848

  • inspector/front-end/Resource.js: (WebInspector.Resource.prototype.set cached): (WebInspector.Resource.prototype.get timing): (WebInspector.Resource.prototype.set timing):
  • inspector/front-end/ResourceManager.js: (WebInspector.ResourceManager.prototype.markResourceAsCached):
11:11 Changeset [71135] by mthole@apple.com

WebProcessManager informed about crashes too late (pages may have already tried to load a new URL)
https://bugs.webkit.org/show_bug.cgi?id=48853

Reviewed by Anders Carlsson.

This also fixes: <rdar://problem/8610451> Webkit2: Crash in WebKit!WebKit::WebProcessProxy::sendMessage opening google.com page

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::~WebProcessProxy):
Removed invalid assertion that is hit when the WebProcess dies unexpectedly.
(WebKit::WebProcessProxy::didClose):
Reordered so that the individual pages are informed that the processDidCrash() after the shared
WebProcessManager has been. This allows the pages to properly trigger a new process to be launched.

11:10 Changeset [71134] by pfeldman@chromium.org

2010-11-02 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: improve network's 'preview close' usability.
https://bugs.webkit.org/show_bug.cgi?id=48846

  • inspector/front-end/networkPanel.css: (#network-close-button:hover): (#network-close-button:active):
11:08 Changeset [71133] by pfeldman@chromium.org

2010-11-02 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Image heights are displayed as 0.
https://bugs.webkit.org/show_bug.cgi?id=40817

  • inspector/front-end/ImageView.js: (WebInspector.ImageView.prototype.contentTabSelected): (WebInspector.ImageView.prototype.contentTabSelected.onImageLoad):
11:01 Changeset [71132] by andersca@apple.com

Handle boolean values in NPVariant and NPVariantData
https://bugs.webkit.org/show_bug.cgi?id=48852

Reviewed by John Sullivan.

  • Shared/Plugins/NPRemoteObjectMap.cpp:

(WebKit::NPRemoteObjectMap::npVariantToNPVariantData):
(WebKit::NPRemoteObjectMap::npVariantDataToNPVariant):

  • Shared/Plugins/NPVariantData.cpp:

(WebKit::NPVariantData::makeBool):
(WebKit::NPVariantData::encode):
(WebKit::NPVariantData::decode):

  • Shared/Plugins/NPVariantData.h:

(WebKit::NPVariantData::boolValue):

10:59 Changeset [71131] by adele@apple.com

WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=48814
<rdar://problem/8546143> Attempting to redo typing in apple.com/startpage search field causes infinite recursion in TextControlInnerTextElement::defaultEventHandler

Reviewed by Kent Tamura.

Test: editing/undo/redo-after-detach.html

  • rendering/TextControlInnerElements.cpp: (WebCore::TextControlInnerTextElement::defaultEventHandler):

A TextControlInnerTextElement will almost always have a shadowAncestorNode, the HTMLInputElement. In this case,
after the renderer was destroyed, this shadow node was kept alive by the EditCommand, even though its not hooked up
anymore to the shadow DOM. EditCommands can sometimes operate on stale selections and are expected to fail silently.
So here we prevent the infinite loop during event dispatch, and the rest of the redo operation will fail silently.

LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=48814
<rdar://problem/8546143> Attempting to redo typing in apple.com/startpage search field causes infinite recursion in TextControlInnerTextElement::defaultEventHandler

Reviewed by Kent Tamura.

  • editing/undo/redo-after-detach-expected.txt: Added.
  • editing/undo/redo-after-detach.html: Added.
10:55 Changeset [71130] by enrica@apple.com

WebKit2: Repeated cmd-key presses lead to unusable UI state
https://bugs.webkit.org/show_bug.cgi?id=48811
<rdar://problem/8611924>

Reviewed by Alexey Proskuryakov.

Given the asynchronous nature of every interaction with the WebProcess,
we could re-send a keyDown event to AppKit that maps to an
action that is currently disabled and therefore will not trigger an action
but a call to the keyDown method of the NSView. We need to detect this
situation to avoid an infinite loop.

  • UIProcess/API/mac/WKView.mm:

(-[WKView performKeyEquivalent:]): Delay the release of the last processed event
to the moment we receive another event.
(-[WKView keyDown:]): Added early return in case the event is one we have re-sent.

10:51 Changeset [71129] by andersca@apple.com

Assertion hit in WebProcessProxy::~WebProcessProxy()
https://bugs.webkit.org/show_bug.cgi?id=48849
<rdar://problem/8617676>

Reviewed by John Sullivan.

It is perfectly valid for the page map to contain pages if the web process proxy
goes away, this can happen if the process crashes for example.

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::~WebProcessProxy):
Remove the assertion.

10:35 Changeset [71128] by commit-queue@webkit.org

2010-11-02 Christian Sejersen <christian.webkit@gmail.com>

Reviewed by Andreas Kling.

The previous patch only took into account arm targets. This one
now checks whether the build is done inside Scratchbox.
https://bugs.webkit.org/show_bug.cgi?id=47895

  • DerivedSources.pro:
10:26 Changeset [71127] by andersca@apple.com

More NPRuntime work
https://bugs.webkit.org/show_bug.cgi?id=48847

Reviewed by Adam Roben.

  • PluginProcess/WebProcessConnection.cpp:

(WebKit::WebProcessConnection::~WebProcessConnection):
Add assertions.

(WebKit::WebProcessConnection::removePluginControllerProxy):
If we have no more plug-in controller proxies, invalidate the remote object map.

  • Shared/Plugins/NPIdentifierData.cpp:

(WebKit::NPIdentifierData::createNPIdentifier):
Create an NPIdentifier from the given NPIdentifierData.

  • Shared/Plugins/NPObjectMessageReceiver.cpp:

(WebKit::NPObjectMessageReceiver::create):
(WebKit::NPObjectMessageReceiver::NPObjectMessageReceiver):
This now takes the NPRemoteObjectMap as well as the npObjectID of the object.

(WebKit::NPObjectMessageReceiver::~NPObjectMessageReceiver):
Unregister the object.

(WebKit::NPObjectMessageReceiver::deallocate):
Delete the object.

(WebKit::NPObjectMessageReceiver::getProperty):
Ask the NPObject for the property and convert it back to an NPVariantData.

  • Shared/Plugins/NPObjectProxy.cpp:

(WebKit::NPObjectProxy::~NPObjectProxy):
Send a Deallocate message to the corresponding message receiver on the other side.

(WebKit::NPObjectProxy::getProperty):
Convert the NPVariantData back to an NPVariant and return it.

  • Shared/Plugins/NPRemoteObjectMap.cpp:

(WebKit::NPRemoteObjectMap::registerNPObject):
Pass the NPRemoteObjectMap and the npObjectID to NPObjectMessageReceiver::create.

(WebKit::NPRemoteObjectMap::unregisterNPObject):
Remove the given object from the map of registered objects.

(WebKit::NPRemoteObjectMap::npVariantToNPVariantData):
Given an NPVariant, create an NPVariantData. Only supports void and double types right now.

(WebKit::NPRemoteObjectMap::npVariantDataToNPVariant):
Given an NPVariantData, create an NPVariant. Only supports void and double types right now.

(WebKit::NPRemoteObjectMap::invalidate):
Add stub.

  • Shared/Plugins/NPVariantData.cpp:

(WebKit::NPVariantData::NPVariantData):
Set the type to void by default.

(WebKit::NPVariantData::makeVoid):
Return a void NPVariantData.

(WebKit::NPVariantData::makeDouble):
Return an NPVariantData that contains a double value.

(WebKit::NPVariantData::encode):
Encode the NPVariantData.

(WebKit::NPVariantData::decode):
Decode the NPVariantData.

  • Shared/Plugins/NPVariantData.h:

(WebKit::NPVariantData::type):
Return the type of the NPVariantData.

(WebKit::NPVariantData::doubleValue):
Return the double value of the NPVariantData.

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::didClose):
Use nullptr instead of 0.

  • WebProcess/Plugins/PluginProcessConnection.cpp:

(WebKit::PluginProcessConnection::~PluginProcessConnection):
Assert that the connection and the remote object map are both null.

(WebKit::PluginProcessConnection::removePluginProxy):
If this was the last plug-in proxy, invalidate the remote object map.

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::shutdown):
Use nullptr instead of 0.

10:25 Changeset [71126] by aroben@apple.com

Skip another test that fails in WebKit2

  • platform/mac-wk2/Skipped:
10:19 Changeset [71125] by cmarrin@apple.com

2010-11-02 Chris Marrin <cmarrin@apple.com>

Reviewed by Adam Roben.

Make RenderStyle::playState() return typed value and cleanup naming in Animation code
https://bugs.webkit.org/show_bug.cgi?id=48844

playState() function was returning unsigned value, but there is a EAnimPlayState
enum type which has the legal playState values. This type is now used everywhere.
I also changed the naming of the m_isSuspended to m_suspended to match the style
elsewhere in the code.

  • page/animation/AnimationBase.cpp: (WebCore::AnimationBase::updatePlayState):
  • page/animation/AnimationBase.h:
  • page/animation/AnimationController.cpp: (WebCore::AnimationControllerPrivate::clear): (WebCore::AnimationControllerPrivate::updateAnimationTimer):
  • page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimation::updateKeyframeAnimations): (WebCore::CompositeAnimation::suspendAnimations): (WebCore::CompositeAnimation::resumeAnimations):
  • page/animation/CompositeAnimation.h: (WebCore::CompositeAnimation::suspended): (WebCore::CompositeAnimation::CompositeAnimation):
  • platform/animation/Animation.h: (WebCore::Animation::playState): (WebCore::Animation::setPlayState): (WebCore::Animation::initialAnimationPlayState):
10:08 Changeset [71124] by aroben@apple.com

Update Windows results after r71043

  • platform/win/fast/blockflow/border-vertical-lr-expected.checksum:
  • platform/win/fast/blockflow/border-vertical-lr-expected.png:
  • platform/win/fast/blockflow/border-vertical-lr-expected.txt:
  • platform/win/fast/blockflow/japanese-lr-text-expected.checksum:
  • platform/win/fast/blockflow/japanese-lr-text-expected.png:
  • platform/win/fast/blockflow/japanese-lr-text-expected.txt:
  • platform/win/fast/blockflow/japanese-rl-text-expected.checksum:
  • platform/win/fast/blockflow/japanese-rl-text-expected.png:
  • platform/win/fast/blockflow/japanese-rl-text-expected.txt:
  • platform/win/fast/text/international/vertical-text-glyph-test-expected.checksum:
  • platform/win/fast/text/international/vertical-text-glyph-test-expected.png:
  • platform/win/fast/text/international/vertical-text-glyph-test-expected.txt:
10:00 TriagingTestFailures edited by aroben@apple.com
More wordsmithing (diff)
09:46 TriagingTestFailures edited by aroben@apple.com
Reword the intro a bit (diff)
09:44 Changeset [71123] by zmo@google.com

2010-11-01 Zhenyao Mo <zmo@google.com>

Reviewed by Andreas Kling.

vertexAttribPointer should generate INVALID_VALUE if the stride exceeds 255
https://bugs.webkit.org/show_bug.cgi?id=48677

Test: fast/canvas/webgl/gl-vertexattribpointer.html

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::vertexAttribPointer): Generate INVALID_VALUE if stride > 255.

2010-11-01 Zhenyao Mo <zmo@google.com>

Reviewed by Andreas Kling.

vertexAttribPointer should generate INVALID_VALUE if the stride exceeds 255
https://bugs.webkit.org/show_bug.cgi?id=48677

  • fast/canvas/webgl/gl-vertexattribpointer-expected.txt: Added.
  • fast/canvas/webgl/gl-vertexattribpointer.html: Added.
09:44 TriagingTestFailures edited by aroben@apple.com
Flesh out the intro and add a note about migrating into Radar (diff)
09:39 Changeset [71122] by kbalazs@webkit.org

Unreviewed Qt buildfix.

message recievers.

09:38 TriagingTestFailures edited by aroben@apple.com
Address more of John Sullivan's feedback (diff)
09:35 TriagingTestFailures edited by aroben@apple.com
Address more of John Sullivan's feedback (diff)
09:32 TriagingTestFailures edited by aroben@apple.com
Address some of John Sullivan's feedback (diff)
09:25 TriagingTestFailures edited by aroben@apple.com
Fleshed out a little more (diff)
09:11 TriagingTestFailures edited by aroben@apple.com
Slightly more prose-y (diff)
09:10 TriagingTestFailures created by aroben@apple.com
Initial version
09:06 Changeset [71121] by senorblanco@chromium.org

2010-11-02 Stephen White <senorblanco@chromium.org>

Unreviewed; test expectations fix.

[Chromium] Update chromium-gpu test_expectations to reflect the
test results from the FYI bots.

  • platform/chromium-gpu/test_expectations.txt:
09:04 Changeset [71120] by dbates@webkit.org

2010-11-02 Daniel Bates <dbates@rim.com>

Reviewed by Martin Robinson.

Set frame name before appending it to the frame tree in the Apple Windows,
GTK, and EFL ports
https://bugs.webkit.org/show_bug.cgi?id=48806

Make the frame creation process in the GTK-port consistent with the
Mac, Qt, and Haiku ports. In particular, set the name of the new
frame before it's appended to the frame tree.

At this time we cannot test this change since it is being masked by
HTMLFrameElementBase::setName() <http://trac.webkit.org/browser/trunk/WebCore/html/HTMLFrameElementBase.cpp?rev=70976#L160>.
We'll be able to test this once we fix bug #6751.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::createFrame):

2010-11-02 Daniel Bates <dbates@rim.com>

Reviewed by Martin Robinson.

Set frame name before appending it to the frame tree in the Apple Windows,
GTK, and EFL ports
https://bugs.webkit.org/show_bug.cgi?id=48806

Make the frame creation process in the Apple Windows-port consistent
with the Mac, Qt, and Haiku ports. In particular, set the name of
the new frame before it's appended to the frame tree.

At this time we cannot test this change since it is being masked by
HTMLFrameElementBase::setName() <http://trac.webkit.org/browser/trunk/WebCore/html/HTMLFrameElementBase.cpp?rev=70976#L160>.
We'll be able to test this once we fix bug #6751.

  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::createFrame):

2010-11-02 Daniel Bates <dbates@rim.com>

Reviewed by Martin Robinson.

Set frame name before appending it to the frame tree in the Apple Windows,
GTK, and EFL ports
https://bugs.webkit.org/show_bug.cgi?id=48806

Make the frame creation process in the EFL-port consistent with the
Mac, Qt, and Haiku ports. In particular, set the name of the new
frame before it's appended to the frame tree.

At this time we cannot test this change since it is being masked by
HTMLFrameElementBase::setName() <http://trac.webkit.org/browser/trunk/WebCore/html/HTMLFrameElementBase.cpp?rev=70976#L160>.
We'll be able to test this once we fix bug #6751.

  • ewk/ewk_frame.cpp: (ewk_frame_child_add):
08:52 Changeset [71119] by mrobinson@webkit.org

2010-11-01 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[Soup] Random crashes in http/tests/websocket/tests/workers/worker-handshake-challenge-randomness.html
https://bugs.webkit.org/show_bug.cgi?id=48805

Track active WebSocket handles via a sequential id. This ensures
that when a handle is reallocated into a recently used segment of
memory, it doesn't trigger a false positive in the code which ensures
the original handle is active.

No new tests. This test should stop crashing on the bots, proving the fix.

  • platform/network/soup/SocketStreamHandle.h: (WebCore::SocketStreamHandle::id): Added an m_id member and accessor to SocketStreamHandle.
  • platform/network/soup/SocketStreamHandleSoup.cpp: (WebCore::getHandleFromId): Updated to work with HashMap of handle ids to SocketStreamHandle*. (WebCore::deactivateHandle): Ditto. (WebCore::activateHandle): Ditto. (WebCore::SocketStreamHandle::SocketStreamHandle): Ditto. (WebCore::SocketStreamHandle::connected): Ditto. (WebCore::SocketStreamHandle::readBytes): Ditto. (WebCore::SocketStreamHandle::beginWaitingForSocketWritability): Ditto. (WebCore::connectedCallback): Ditto. (WebCore::readReadyCallback): Ditto. (WebCore::writeReadyCallback): Ditto.
08:47 Changeset [71118] by kbalazs@webkit.org

[Qt][WK2] SharedMemory is broken
https://bugs.webkit.org/show_bug.cgi?id=48520

Reviewed by Andreas Kling.

Implement SharedMemory with QSharedMemory to correctly handle
ownership and to avoid extra allocation for page size requests.

  • Platform/SharedMemory.h:
  • Platform/qt/SharedMemoryQt.cpp:

(WebKit::SharedMemory::Handle::Handle):
(WebKit::SharedMemory::Handle::isNull):
(WebKit::SharedMemory::Handle::encode):
(WebKit::SharedMemory::Handle::decode):
(WebKit::createUniqueKey):
(WebKit::SharedMemory::create):
(WebKit::accessMode):
(WebKit::SharedMemory::~SharedMemory):
(WebKit::SharedMemory::createHandle):

08:41 WikiStart edited by aroben@apple.com
Add a link to a new to-be-written page about triaging test failures (diff)
08:37 Changeset [71117] by ossy@webkit.org

Unreviewed trivial fix.

  • WebCore.pro: Remove inspector/InspectorResource.h after r71035.
08:36 Changeset [71116] by aroben@apple.com

Only track resource identifiers in DRT when dumpResourceLoadCallbacks is on

This reverts Windows to our pre-r71097 behavior. That patch made us
track all resource identifiers, including the main resource, so the
main resource's URL started appearing in test output instead of
"<unknown>". Arguably having the main resource's URL is better, but all
other platforms print "<unknown>" and we want to match.

Fixes <http://webkit.org/b/48837> <rdar://problem/8620351> REGRESSION
(r71097): Many http tests failing on Windows

Reviewed by Anders Carlsson.

  • DumpRenderTree/win/ResourceLoadDelegate.cpp:

(ResourceLoadDelegate::identifierForInitialRequest): Don't add the
identifier to the URL map if we're not supposed to dump resource load
callbacks.
(ResourceLoadDelegate::removeIdentifierForRequest): Always remove the
identifier from the URL map even if we're already "done". There's no
point in keeping out-of-date identifiers around.

08:22 Changeset [71115] by timothy@apple.com

Add WKInspector public APIs.

https://webkit.org/b/48718

Reviewed by Pavel Feldman.

  • DerivedSources.make: Added WebInspector to MESSAGE_RECEIVERS section.
  • UIProcess/API/C/WKInspector.cpp:

(WKInspectorIsVisible): Added.
(WKInspectorShow): Added.
(WKInspectorClose): Added.
(WKInspectorShowConsole): Added.
(WKInspectorIsAttached): Added.
(WKInspectorAttach): Added.
(WKInspectorDetach): Added.
(WKInspectorIsDebuggingJavaScript): Added.
(WKInspectorToggleJavaScriptDebugging): Added.
(WKInspectorIsProfilingJavaScript): Added.
(WKInspectorToggleJavaScriptProfiling): Added.
(WKInspectorIsProfilingPage): Added.
(WKInspectorTogglePageProfiling): Added.

  • UIProcess/API/C/WKInspector.h: Added new functions.
  • UIProcess/WebInspectorProxy.cpp:

(WebKit::WebInspectorProxy::WebInspectorProxy): Initialize new booleans.
(WebKit::WebInspectorProxy::invalidate): Reset new booleans.
(WebKit::WebInspectorProxy::show): Added.
(WebKit::WebInspectorProxy::close): Added.
(WebKit::WebInspectorProxy::showConsole): Added.
(WebKit::WebInspectorProxy::attach): Added.
(WebKit::WebInspectorProxy::detach): Added.
(WebKit::WebInspectorProxy::toggleJavaScriptDebugging): Added.
(WebKit::WebInspectorProxy::toggleJavaScriptProfiling): Added.
(WebKit::WebInspectorProxy::togglePageProfiling): Added.

  • UIProcess/WebInspectorProxy.h:

(WebKit::WebInspectorProxy::isVisible): Added.
(WebKit::WebInspectorProxy::isAttached): Added.
(WebKit::WebInspectorProxy::isDebuggingJavaScript): Added.
(WebKit::WebInspectorProxy::isProfilingJavaScript): Added.
(WebKit::WebInspectorProxy::isProfilingPage): Added.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::close): Invalidate the WebInspectorProxy.
(WebKit::WebPageProxy::inspector): Return 0 if closed or invalid.

  • WebKit2.pro: Added new files.
  • WebKit2.xcodeproj/project.pbxproj: Added new Files.
  • WebProcess/WebPage/WebInspector.cpp:

(WebKit::WebInspector::show): Added.
(WebKit::WebInspector::close): Added.
(WebKit::WebInspector::showConsole): Added.
(WebKit::WebInspector::startJavaScriptDebugging): Added.
(WebKit::WebInspector::stopJavaScriptDebugging): Added.
(WebKit::WebInspector::startJavaScriptProfiling): Added.
(WebKit::WebInspector::stopJavaScriptProfiling): Added.
(WebKit::WebInspector::startPageProfiling): Added.
(WebKit::WebInspector::stopPageProfiling): Added.

  • WebProcess/WebPage/WebInspector.h:

(WebKit::WebInspector::page): Added.

  • WebProcess/WebPage/WebInspector.messages.in: Added.
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::close): Destroy the WebInspector.
(WebKit::WebPage::inspector): Return 0 if closed.
(WebKit::WebPage::didReceiveMessage): Send the message to the WebInspector
if the message class is MessageClassWebInspector.

  • win/WebKit2.vcproj: Added new files.
08:22 Changeset [71114] by timothy@apple.com

Make WebInspectorFrontendClient inherit from InspectorFrontendClientLocal.

We can do this since the Web Inspector WebPage will share the same process
with the inspected WebPage.

https://webkit.org/b/48652

Reviewed by Pavel Feldman.

  • WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp:

(WebKit::WebInspectorFrontendClient::WebInspectorFrontendClient):
Call the InspectorFrontendClientLocal constructor.
(WebKit::WebInspectorFrontendClient::attachWindow): Added.
(WebKit::WebInspectorFrontendClient::detachWindow): Added.
(WebKit::WebInspectorFrontendClient::setAttachedWindowHeight): Added.

  • WebProcess/WebCoreSupport/WebInspectorFrontendClient.h:
07:32 Changeset [71113] by podivilov@chromium.org

2010-11-02 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: make xhr breakpoints editable
https://bugs.webkit.org/show_bug.cgi?id=48830

  • inspector/front-end/BreakpointManager.js: (WebInspector.Breakpoint.prototype.set sourceText): (WebInspector.Breakpoint.prototype.click): (WebInspector.Breakpoint.prototype.populateLabelElement): (WebInspector.XHRBreakpoint.prototype.populateEditElement):
  • inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.BreakpointsSidebarPane.prototype.addBreakpointItem): (WebInspector.BreakpointsSidebarPane.prototype._breakpointItemClicked): (WebInspector.BreakpointsSidebarPane.prototype._contextMenuEventFired): (WebInspector.BreakpointsSidebarPane.prototype._addListElement): (WebInspector.BreakpointsSidebarPane.prototype._removeListElement): (WebInspector.XHRBreakpointsSidebarPane.addButtonClicked): (WebInspector.XHRBreakpointsSidebarPane): (WebInspector.XHRBreakpointsSidebarPane.prototype._startEditingBreakpoint): (WebInspector.XHRBreakpointsSidebarPane.prototype._hideEditBreakpointDialog): (WebInspector.XHRBreakpointsSidebarPane.prototype._breakpointItemClicked): (WebInspector.BreakpointItem): (WebInspector.BreakpointItem.prototype.get element): (WebInspector.BreakpointItem.prototype.click): (WebInspector.BreakpointItem.prototype.populateEditElement): (WebInspector.BreakpointItem.prototype.remove): (WebInspector.BreakpointItem.prototype._hitStateChanged): (WebInspector.BreakpointItem.prototype._labelChanged): (WebInspector.BreakpointItem.prototype._createLabelElement):
  • inspector/front-end/inspector.js: (WebInspector.createJSBreakpointsSidebarPane.breakpointAdded): (WebInspector.createJSBreakpointsSidebarPane): (WebInspector.createDOMBreakpointsSidebarPane.breakpointAdded): (WebInspector.createDOMBreakpointsSidebarPane): (WebInspector.createXHRBreakpointsSidebarPane.breakpointAdded): (WebInspector.createXHRBreakpointsSidebarPane):
06:54 Changeset [71112] by podivilov@chromium.org

2010-11-02 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: fix for breakpoints not restored on live edit bug
https://bugs.webkit.org/show_bug.cgi?id=48833

  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.debuggerPaused):
  • inspector/front-end/inspector.js: (WebInspector.pausedScript):
06:35 Changeset [71111] by apavlov@chromium.org

2010-11-02 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [REGRESSION] Rule addition/selector editing result in unusable rules
https://bugs.webkit.org/show_bug.cgi?id=48826

  • inspector/front-end/CSSStyleModel.js: (WebInspector.CSSStyleModel.prototype.setRuleSelector): (WebInspector.CSSStyleModel.prototype.addRule):
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.BlankStylePropertiesSection.prototype.editingSelectorCommitted.successCallback): (WebInspector.BlankStylePropertiesSection.prototype.editingSelectorCommitted):
05:08 Changeset [71110] by vestbo@webkit.org

[Qt] Don't include Objective-C sources in SOURCES

Reviewed by Andreas Kling.

  • WebCore.pro:
03:43 Changeset [71109] by podivilov@chromium.org

2010-11-02 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: persist native breakpoints in localStorage
https://bugs.webkit.org/show_bug.cgi?id=48711

  • inspector/InspectorController.cpp: (WebCore::InspectorController::disconnectFrontend): (WebCore::InspectorController::didCommitLoad): (WebCore::InspectorController::clearNativeBreakpoints):
  • inspector/InspectorController.h:
  • inspector/front-end/BreakpointManager.js: (WebInspector.BreakpointManager): (WebInspector.DOMBreakpoint): (WebInspector.EventListenerBreakpoint): (WebInspector.EventListenerBreakpoint.eventNameForUI): (WebInspector.EventListenerBreakpoint.prototype._uiEventName): (WebInspector.XHRBreakpoint): (WebInspector.XHRBreakpoint.prototype.populateStatusMessageElement):
  • inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.BreakpointsSidebarPane.prototype.addBreakpoint): (WebInspector.BreakpointsSidebarPane.prototype._breakpointHit): (WebInspector.BreakpointItem.prototype._hitStateChanged): (WebInspector.EventListenerBreakpointsSidebarPane):
  • inspector/front-end/ConsoleView.js:
  • inspector/front-end/EventListenersSidebarPane.js:
  • inspector/front-end/NetworkPanel.js:
  • inspector/front-end/Panel.js:
  • inspector/front-end/ResourceView.js:
  • inspector/front-end/ScriptsPanel.js:
  • inspector/front-end/Settings.js: (WebInspector.Settings): (WebInspector.Settings.prototype.inspectedURLChanged): (WebInspector.Settings.prototype._formatProjectKey):
  • inspector/front-end/StoragePanel.js:
  • inspector/front-end/StylesSidebarPane.js:
  • inspector/front-end/WatchExpressionsSidebarPane.js:
  • inspector/front-end/inspector.css: (.pane .breakpoint-hit):
  • inspector/front-end/inspector.js: (WebInspector.set currentPanel): (WebInspector.doLoadedDone.onPopulateScriptObjects): (WebInspector.doLoadedDone): (WebInspector.reset): (WebInspector.inspectedURLChanged):
03:31 Changeset [71108] by pfeldman@chromium.org

2010-11-01 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Joseph Pecoraro.

Web Inspector: use mimeType from cached resource
in case response data contains none.
https://bugs.webkit.org/show_bug.cgi?id=48773

  • inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::didReceiveResponse):
  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype._createTable):
03:29 Changeset [71107] by caseq@chromium.org

2010-11-01 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Extensions API] expose API to create properties watch sidebar panes
https://bugs.webkit.org/show_bug.cgi?id=48761

  • inspector/front-end/ExtensionAPI.js: (WebInspector.injectedExtensionAPI.PanelImpl.prototype.createSidebarPane): (WebInspector.injectedExtensionAPI.PanelImpl.prototype.createWatchExpressionSidebarPane.callbackWrapper): (WebInspector.injectedExtensionAPI.PanelImpl.prototype.createWatchExpressionSidebarPane): (WebInspector.injectedExtensionAPI): (WebInspector.injectedExtensionAPI.WatchExpressionSidebarPaneImpl): (WebInspector.injectedExtensionAPI.WatchExpressionSidebarPaneImpl.prototype.setExpression): (WebInspector.injectedExtensionAPI.WatchExpressionSidebarPaneImpl.prototype.setObject):
  • inspector/front-end/ExtensionPanel.js: Added ExtensionWatchSidebarPane (WebInspector.ExtensionWatchSidebarPane): (WebInspector.ExtensionWatchSidebarPane.prototype.setObject): (WebInspector.ExtensionWatchSidebarPane.prototype.setExpression): (WebInspector.ExtensionWatchSidebarPane.prototype._onEvaluate): (WebInspector.ExtensionWatchSidebarPane.prototype._setObject):
  • inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer): (WebInspector.ExtensionServer.prototype.notifyExtensionWatchSidebarUpdated): (WebInspector.ExtensionServer.prototype._onCreateSidebar): (WebInspector.ExtensionServer.prototype._onCreateWatchExpressionSidebarPane): (WebInspector.ExtensionServer.prototype._createSidebar): (WebInspector.ExtensionServer.prototype._onSetWatchSidebarContent):
  • inspector/front-end/InjectedScript.js: (injectedScriptConstructor.):
  • inspector/front-end/RemoteObject.js: Added a wrapper for local JSON object to simulate RemoteObject interface. (WebInspector.RemoteObject.fromLocalObject): (WebInspector.LocalJSONObject): (WebInspector.LocalJSONObject.prototype.get description): (WebInspector.LocalJSONObject.prototype.get type): (WebInspector.LocalJSONObject.prototype.get hasChildren): (WebInspector.LocalJSONObject.prototype.getOwnProperties): (WebInspector.LocalJSONObject.prototype.getProperties): (WebInspector.LocalJSONObject.prototype.isError):

2010-11-01 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Extensions API] expose API to create properties watch sidebar panes
https://bugs.webkit.org/show_bug.cgi?id=48761

  • inspector/extensions-api-expected.txt:
  • inspector/extensions-events-expected.txt:
  • inspector/extensions-expected.txt:
  • inspector/extensions-test.js: Added generic way to dispatch messages to front-end and receive callbacks. (initialize_ExtensionsTest.InspectorTest.dispatchOnMessage): (initialize_ExtensionsTest.InspectorTest.dumpSidebarContent):
  • inspector/extensions.html:
  • inspector/resources/extension-main.js: (dispatchOnFrontend.callbackWrapper): (dispatchOnFrontend):
03:20 Changeset [71106] by philn@webkit.org

2010-11-02 Philippe Normand <pnormand@igalia.com>

Unreviewed, unskip passing media test on the GTK+ port.

  • platform/gtk/Skipped: Unskip media/video-canvas-alpha.html.
03:11 Changeset [71105] by commit-queue@webkit.org

2010-11-02 Ryuan Choi <ryuan.choi@samsung.com>

Unreviewed build fix for EFL build with libcurl

[EFL] remove multiple definition with libcurl
https://bugs.webkit.org/show_bug.cgi?id=48499

Add macro to isolate setCookieStoragePrivateBrowsingEnabled from EFL
build because it was duplicated.

  • platform/network/curl/CookieJarCurl.cpp:
02:57 Changeset [71104] by pfeldman@chromium.org

2010-11-02 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Joseph Pecoraro.

Web Inspector: highlight frame on hover in resources panel.
https://bugs.webkit.org/show_bug.cgi?id=48760

  • inspector/Inspector.idl:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::highlightFrame):
  • inspector/InspectorController.h: (WebCore::InspectorController::hideFrameHighlight):
  • inspector/front-end/StoragePanel.js: (WebInspector.StoragePanel): (WebInspector.StoragePanel.prototype.showView): (WebInspector.StoragePanel.prototype._onmousemove): (WebInspector.StoragePanel.prototype._onmouseout): (WebInspector.FrameTreeElement.prototype.onselect): (WebInspector.FrameTreeElement.prototype.ondeselect): (WebInspector.FrameTreeElement.prototype.set displayName): (WebInspector.FrameTreeElement.prototype.set hovered):
  • inspector/front-end/inspector.css: (.storage.panel .sidebar li.selected .selection): (.storage.panel .sidebar :focus li.selected .selection): (body.inactive .storage.panel .sidebar li.selected .selection):
01:35 Changeset [71103] by zimmermann@webkit.org

2010-11-02 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Rob Buis.

Convert SVGPreserveAspectRatio to the new SVGPropertyTearOff concept
https://bugs.webkit.org/show_bug.cgi?id=48822

Convert the next type to use the SVGPropertyTearOffConcept. Just SVGAnimatedTransformList/SVGTransform/SVGStringList are missing.

Tests: svg/dom/SVGAnimatedPreserveAspectRatio.html

svg/dom/SVGPreserveAspectRatio.html

  • GNUmakefile.am: Add SVGAnimatedPreserveAspectRatio.h to build.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • bindings/scripts/CodeGenerator.pm: Recognize SVGAnimatedPreserveAspectRatio as new style animated type.
  • bindings/scripts/CodeGeneratorJS.pm: Remove special SVGPreserveAspectRatio handling.
  • bindings/scripts/CodeGeneratorObjC.pm: Always include the type wrapped by SVGPropertyTearOff<> - this was missing before, and now become visible as missing include.
  • bindings/scripts/CodeGeneratorV8.pm: Remove special SVGPreserveAspectRatio handling.
  • svg/DeprecatedSVGAnimatedPropertyTraits.h: Remove SVGPreserveAspectRatio handling.
  • svg/DeprecatedSVGAnimatedTemplate.h: Ditto.
  • svg/SVGAnimatedPreserveAspectRatio.h: Added.
  • svg/SVGFEImageElement.h: s/DECLARE_ANIMATED_PROPERTY/DECLARE_ANIMATED_PROPERTY_NEW/ where SVGPreserveAspectRatio is used.
  • svg/SVGFitToViewBox.cpp: (WebCore::SVGFitToViewBox::viewBoxToViewTransform): SVGPreserveAspectRatio::getCTM doesn't need x/y parameters, they were not used anywhere, remove them.
  • svg/SVGFitToViewBox.h: Replace includes by class forwards.
  • svg/SVGImageElement.h: s/DECLARE_ANIMATED_PROPERTY/DECLARE_ANIMATED_PROPERTY_NEW/ where SVGPreserveAspectRatio is used.
  • svg/SVGLocatable.cpp: Add SVGNames.h include, to allow Qt to build (thanks ews!).
  • svg/SVGMarkerElement.h: Ditto.
  • svg/SVGPatternElement.h: Ditto.
  • svg/SVGPreserveAspectRatio.cpp: Modernize code, add error handling for align/meetOrSlice covered by the new tests. (WebCore::SVGPreserveAspectRatio::SVGPreserveAspectRatio): (WebCore::SVGPreserveAspectRatio::setAlign): (WebCore::SVGPreserveAspectRatio::setMeetOrSlice): (WebCore::SVGPreserveAspectRatio::parsePreserveAspectRatio): (WebCore::SVGPreserveAspectRatio::transformRect): (WebCore::SVGPreserveAspectRatio::getCTM): (WebCore::SVGPreserveAspectRatio::valueAsString):
  • svg/SVGPreserveAspectRatio.h: Reindented header. (WebCore::SVGPreserveAspectRatio::align): Inlined. (WebCore::SVGPreserveAspectRatio::meetOrSlice): Inlined.
  • svg/SVGPreserveAspectRatio.idl: Enable StrictTypeChecking for the align/meetOrSlice properties.
  • svg/SVGSVGElement.h: s/DECLARE_ANIMATED_PROPERTY/DECLARE_ANIMATED_PROPERTY_NEW/ where SVGPreserveAspectRatio is used.
  • svg/SVGStyledTransformableElement.h: Add SVGAnimatedPropertyMacros.h include, needed by efl to build (thanks ews!).
  • svg/SVGSymbolElement.h: Ditto.
  • svg/SVGViewElement.h: Ditto.
  • svg/SVGViewSpec.h: Ditto.

2010-11-02 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Rob Buis.

Convert SVGPreserveAspectRatio to the new SVGPropertyTearOff concept
https://bugs.webkit.org/show_bug.cgi?id=48822

  • svg/dom/SVGAnimatedPreserveAspectRatio-expected.txt: Added.
  • svg/dom/SVGAnimatedPreserveAspectRatio.html: Added.
  • svg/dom/SVGPreserveAspectRatio-expected.txt: Added.
  • svg/dom/SVGPreserveAspectRatio.html: Added.
  • svg/dom/script-tests/SVGAnimatedPreserveAspectRatio.js: Added.
  • svg/dom/script-tests/SVGPreserveAspectRatio.js: Added.

11/01/10:

23:34 Changeset [71102] by morrita@google.com

2010-11-01 MORITA Hajime <morrita@google.com>

Unreviewed, added skip entries for platforms where spellchecking
is not supported.

  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/qt/Skipped:
22:30 Changeset [71101] by morrita@google.com

2010-11-01 MORITA Hajime <morrita@google.com>

Reviewed by Kent Tamura.

@spellcheck attribute at the child of contentEditable node is ignored.
https://bugs.webkit.org/show_bug.cgi?id=48418

  • editing/spelling/script-tests/spelling-attribute-at-child.js: Added.
  • editing/spelling/spelling-attribute-at-child-expected.txt: Added.
  • editing/spelling/spelling-attribute-at-child.html: Added.

2010-11-01 MORITA Hajime <morrita@google.com>

Reviewed by Kent Tamura.

@spellcheck attribute at the child of contentEditable node is ignored.
https://bugs.webkit.org/show_bug.cgi?id=48418

Changed to check spellcheck availability against a node under the
selection (caret) instead of the focus. For shadow elements, the
check now refers its host node. Note that the original code didn't
care shadows because focus is never set on them.

Test: editing/spelling/spelling-attribute-at-child.html

  • dom/Element.h:
  • editing/Editor.cpp: (WebCore::Editor::markMisspellingsOrBadGrammar): (WebCore::Editor::isSpellCheckingEnabledFor): (WebCore::Editor::isSpellCheckingEnabledInFocusedNode): Now just calling isSpellCheckingEnabledFor() (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
  • editing/Editor.h:
  • platform/ContextMenu.cpp: (WebCore::ContextMenu::populate):
  • rendering/TextControlInnerElements.cpp: (WebCore::TextControlInnerElement::isSpellCheckingEnabled): Added.
  • rendering/TextControlInnerElements.h:
22:09 Changeset [71100] by abarth@webkit.org

2010-11-01 Adam Barth <abarth@webkit.org>

Update expected results for PNG ICC profile.

  • platform/chromium-mac/fast/borders/svg-as-border-image-2-expected.checksum:
  • platform/chromium-mac/fast/borders/svg-as-border-image-2-expected.png: Removed.
  • platform/chromium-mac/fast/borders/svg-as-border-image-expected.checksum:
  • platform/chromium-mac/fast/borders/svg-as-border-image-expected.png: Removed.
  • platform/chromium-mac/fast/css/background-shorthand-invalid-url-expected.checksum:
  • platform/chromium-mac/fast/css/background-shorthand-invalid-url-expected.png: Removed.
  • platform/chromium-mac/fast/media/mq-min-pixel-ratio-expected.checksum: Removed.
  • platform/chromium-mac/fast/media/mq-min-pixel-ratio-expected.png: Removed.
  • platform/chromium-mac/fast/reflections/reflection-masks-expected.checksum: Removed.
  • platform/chromium-mac/fast/reflections/reflection-masks-expected.png: Removed.
  • platform/chromium-mac/fast/reflections/reflection-masks-opacity-expected.checksum: Removed.
  • platform/chromium-mac/http/tests/misc/slow-loading-image-in-pattern-expected.checksum:
  • platform/chromium-mac/http/tests/misc/slow-loading-image-in-pattern-expected.png:
  • platform/chromium-mac/scrollbars/listbox-scrollbar-combinations-expected.checksum:
  • platform/chromium-mac/scrollbars/overflow-scrollbar-combinations-expected.checksum:
  • platform/chromium-mac/scrollbars/overflow-scrollbar-combinations-expected.png: Removed.
  • platform/chromium-mac/svg/custom/createImageElement-expected.checksum:
  • platform/chromium-mac/svg/custom/createImageElement-expected.png:
  • platform/chromium-mac/svg/custom/focus-ring-expected.checksum:
  • platform/chromium-mac/svg/custom/focus-ring-expected.png: Removed.
  • platform/chromium-mac/svg/custom/group-opacity-expected.checksum:
  • platform/chromium-mac/svg/custom/group-opacity-expected.png: Removed.
  • platform/chromium-mac/svg/custom/image-parent-translation-expected.checksum:
  • platform/chromium-mac/svg/custom/image-parent-translation-expected.png:
  • platform/chromium-mac/svg/custom/image-small-width-height-expected.checksum:
  • platform/chromium-mac/svg/custom/image-small-width-height-expected.png:
  • platform/chromium-mac/svg/custom/image-with-transform-clip-filter-expected.checksum:
  • platform/chromium-mac/svg/custom/js-update-image-and-display-expected.checksum:
  • platform/chromium-mac/svg/custom/js-update-image-and-display-expected.png:
  • platform/chromium-mac/svg/custom/js-update-image-and-display2-expected.checksum:
  • platform/chromium-mac/svg/custom/js-update-image-and-display2-expected.png:
  • platform/chromium-mac/svg/custom/js-update-image-and-display3-expected.checksum:
  • platform/chromium-mac/svg/custom/js-update-image-and-display3-expected.png:
  • platform/chromium-mac/svg/custom/js-update-image-expected.checksum:
  • platform/chromium-mac/svg/custom/js-update-image-expected.png:
  • platform/chromium-mac/svg/custom/pointer-events-image-expected.checksum:
  • platform/chromium-mac/svg/custom/pointer-events-image-expected.png:
  • platform/chromium-mac/svg/custom/text-image-opacity-expected.checksum:
  • platform/chromium-mac/svg/custom/text-image-opacity-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-height-attr-expected.checksum:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-height-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.checksum:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-width-attr-expected.checksum:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-width-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-x-attr-expected.checksum:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-x-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-y-attr-expected.checksum:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-y-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.checksum:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.checksum:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.checksum:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-x-prop-expected.checksum:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-x-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-y-prop-expected.checksum:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-y-prop-expected.png:
  • platform/chromium/test_expectations.txt:
21:34 Changeset [71099] by mrobinson@webkit.org

2010-11-01 Martin Robinson <mrobinson@igalia.com>

Reviewed by Daniel Bates.

[GTK] PopupMenuGtk has a very confusing if-else block
https://bugs.webkit.org/show_bug.cgi?id=48816

Small code cleanup for PopupMenuGtk.

  • platform/gtk/PopupMenuGtk.cpp: (WebCore::PopupMenuGtk::show):
21:15 Changeset [71098] by abarth@webkit.org

2010-11-01 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

[Chromium] Add ICC support for PNG on Mac
https://bugs.webkit.org/show_bug.cgi?id=48170

This just pipes the ICC profile from libpng to CoreGraphics. This
patch would have been a lot prettier on Snow Leopard, but we have to
use a somewhat ugly API to get this to work on Leopard.

This is covered by about infinite tests.

  • platform/image-decoders/ImageDecoder.cpp: (WebCore::RGBA32Buffer::setColorProfile):
  • platform/image-decoders/ImageDecoder.h:
  • platform/image-decoders/cg/ImageDecoderCG.cpp: (WebCore::RGBA32Buffer::asNewNativeImage):
  • platform/image-decoders/png/PNGImageDecoder.cpp: (WebCore::PNGImageDecoder::headerAvailable): (WebCore::PNGImageDecoder::rowAvailable):
  • platform/image-decoders/qt/RGBA32BufferQt.cpp: (WebCore::RGBA32Buffer::setColorProfile):
  • platform/image-decoders/skia/ImageDecoderSkia.cpp: (WebCore::RGBA32Buffer::setColorProfile):
19:42 Changeset [71097] by commit-queue@webkit.org

2010-11-01 Jenn Braithwaite <jennb@chromium.org>

Reviewed by Adam Roben.

Windows: Update resource tracking when moving a frame between documents
https://bugs.webkit.org/show_bug.cgi?id=48364

  • Interfaces/IWebResourceLoadDelegatePrivate2.idl:Added Added removeIdentifierForRequest.
  • Interfaces/WebKit.idl: Added IWebResourceLoadDelegatePrivate2.idl.
  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::transferLoadingResourceFromPage):

2010-11-01 Jenn Braithwaite <jennb@chromium.org>

Reviewed by Adam Roben.

Windows: Update resource tracking when moving a frame between documents
https://bugs.webkit.org/show_bug.cgi?id=48364

  • DumpRenderTree/win/DumpRenderTree.cpp: (createWebViewAndOffscreenWindow): (main): Give each WebView its own ResourceLoadDelegate instance in order to make assertions about resource ids on a particular WebView.
  • DumpRenderTree/win/ResourceLoadDelegate.cpp: (ResourceLoadDelegate::identifierForInitialRequest): Always add id to the map. (ResourceLoadDelegate::removeIdentifierForRequest): Added. (ResourceLoadDelegate::willSendRequest): (ResourceLoadDelegate::didReceiveAuthenticationChallenge): (ResourceLoadDelegate::didReceiveResponse): (ResourceLoadDelegate::didFinishLoadingFromDataSource): (ResourceLoadDelegate::didFailLoadingWithError): (ResourceLoadDelegate::descriptionSuitableForTestResult): Replace static descriptionSuitableForTestResult with static member function to access identifier map.
  • DumpRenderTree/win/ResourceLoadDelegate.h: (ResourceLoadDelegate::urlMap): Moved within class so that each WebView has its own id map.
19:20 Changeset [71096] by commit-queue@webkit.org

2010-11-01 Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>

Reviewed by Andreas Kling.

[Qt][Symbian] QtTestBrowser runs out of memory with most of javascript benchmarks.
https://bugs.webkit.org/show_bug.cgi?id=48730

Increase the maximum heap size on Symbian to 256 MB.

  • WebKit.pri:
19:10 Changeset [71095] by dimich@chromium.org

[Chromium] Unreviewed update of test expectations.
Snap chromium checksum for the newly added baseline (added in http://trac.webkit.org/changeset/71088)

  • platform/chromium-mac/fast/css/text-input-with-webkit-border-radius-expected.checksum: Added.
18:56 Changeset [71094] by chang.shu@nokia.com

2010-11-01 Chang Shu <chang.shu@nokia.com>

Reviewed by Antonio Gomes.

Leave SelectElement key handling without setting event default
handled when the selection reaches the boundary so focus can
move to neighbor nodes in spatial navigation.
https://bugs.webkit.org/show_bug.cgi?id=48145

  • fast/events/spatial-navigation/snav-multiple-select-expected.txt:
  • fast/events/spatial-navigation/snav-multiple-select.html:

2010-11-01 Chang Shu <chang.shu@nokia.com>

Reviewed by Antonio Gomes.

Leave SelectElement key handling without setting event default
handled when the selection reaches the boundary so focus can
move to neighbor nodes in spatial navigation.
https://bugs.webkit.org/show_bug.cgi?id=48145

  • dom/SelectElement.cpp: (WebCore::SelectElement::listBoxDefaultEventHandler):
18:54 Changeset [71093] by dimich@chromium.org

[Chromium] Unreviewed update of test expectations.
Did I run --lint-test-files last time? Probably not.

  • platform/chromium/test_expectations.txt:
18:44 Changeset [71092] by dimich@chromium.org

[Chromium] Unreviewed update of test expectations.

  • platform/chromium/test_expectations.txt:
18:40 Changeset [71091] by commit-queue@webkit.org

2010-11-01 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r71080.
http://trac.webkit.org/changeset/71080
https://bugs.webkit.org/show_bug.cgi?id=48815

This change caused many crashes on the debug bot. (Requested
by mrobinson on #webkit).

  • platform/network/soup/SocketStreamHandle.h:
  • platform/network/soup/SocketStreamHandleSoup.cpp: (WebCore::isActiveHandle): (WebCore::deactivateHandle): (WebCore::SocketStreamHandle::SocketStreamHandle): (WebCore::SocketStreamHandle::connected): (WebCore::SocketStreamHandle::readBytes): (WebCore::SocketStreamHandle::beginWaitingForSocketWritability): (WebCore::connectedCallback): (WebCore::readReadyCallback): (WebCore::writeReadyCallback):
18:36 Changeset [71090] by commit-queue@webkit.org

2010-11-01 Jennifer Braithwaite <jennb@google.com>

Reviewed by Martin Robinson.

GTK: Update resource tracking when moving a frame between documents
https://bugs.webkit.org/show_bug.cgi?id=48362

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::transferLoadingResourceFromPage): Assign resource id to current web view and remove from former web view.
  • webkit/webkitprivate.h:
  • webkit/webkitwebview.cpp: (webkit_web_view_remove_resource): Added.
18:15 Changeset [71089] by commit-queue@webkit.org

2010-11-01 Juha Savolainen <juha.savolainen@weego.fi>

Reviewed by Kenneth Rohde Christiansen.

Initial implementation of QWKHistoryItem.
https://bugs.webkit.org/show_bug.cgi?id=48620

The QWkHistoryItem represents one item in the history of QWKPage.

  • UIProcess/API/qt/qwkhistory.cpp: (QWKHistoryItemPrivate::QWKHistoryItemPrivate): (QWKHistoryItem::QWKHistoryItem): (QWKHistoryItem::~QWKHistoryItem): (QWKHistoryItem::title): The page title (QWKHistoryItem::url): The URL of the page. (QWKHistoryItem::originalUrl): The URL used to access the page.
  • UIProcess/API/qt/qwkhistory.h:
  • UIProcess/API/qt/qwkhistory_p.h:
  • WebKit2.pro: Added WKBackForwardListItem.h and WKBackForwardListItem.cpp
17:55 Changeset [71088] by mihaip@chromium.org

2010-11-01 Mihai Parparita <mihaip@chromium.org>

Update the pixel expectations for css/ for the Mac port.

For the tests that currently fail on Snow Leopard with --pixel-tests
--tolerance 0, this moves the current pixel results to mac-leopard and
adds new Snow Leopard-specific results to platform/mac.

List of files omitted due to length but composed entirely of moves from
platform/mac to platform/mac-leopard and newly added files in
platform/mac.

17:47 Changeset [71087] by dimich@chromium.org

[Chromium] Unreviewed update of test expectations.

  • platform/chromium/test_expectations.txt:
17:39 Changeset [71086] by hyatt@apple.com

Fix layout tests.

17:38 Changeset [71085] by hyatt@apple.com

Fix layout tests.

17:31 Changeset [71084] by mihaip@chromium.org

2010-11-01 Mihai Parparita <mihaip@chromium.org>

Update the pixel expectations for editing/ for the Mac port.

For the tests that currently fail on Snow Leopard with --pixel-tests
--tolerance 0, this moves the current pixel results to mac-leopard and
adds new Snow Leopard-specific results to platform/mac.

List of files omitted due to length but composed entirely of moves from
platform/mac to platform/mac-leopard and newly added files in
platform/mac.

Some tests had differences due to spell correction underlining, those
were skipped since it's not clear what the correct dictionary state is.

17:17 Changeset [71083] by ojan@chromium.org

2010-11-01 Ojan Vafai <ojan@chromium.org>

Reviewed by Dimitri Glazkov.

remove debug code from run_webkit_tests.py
https://bugs.webkit.org/show_bug.cgi?id=48800

Remove temporary debug code and make --master-name required
if --test-results-server is set now that all clients set
--master-name.

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
17:17 Changeset [71082] by dimich@chromium.org

[Chromium] Unreviewed update of test expectations.
Temporarily disable new test added by http://trac.webkit.org/changeset/71066
Need to convert it to dumpAsText().

  • platform/chromium/test_expectations.txt:
17:12 Changeset [71081] by andersca@apple.com

Make NPRemoteObjectMap a ref counted object
https://bugs.webkit.org/show_bug.cgi?id=48808

Reviewed by Oliver Hunt.

  • PluginProcess/PluginControllerProxy.cpp:

(WebKit::PluginControllerProxy::windowScriptNPObject):

  • PluginProcess/WebProcessConnection.cpp:

(WebKit::WebProcessConnection::WebProcessConnection):
(WebKit::WebProcessConnection::didReceiveSyncMessage):

  • PluginProcess/WebProcessConnection.h:

(WebKit::WebProcessConnection::npRemoteObjectMap):

  • Shared/Plugins/NPRemoteObjectMap.cpp:

(WebKit::NPRemoteObjectMap::create):
(WebKit::NPRemoteObjectMap::~NPRemoteObjectMap):
(WebKit::NPRemoteObjectMap::createNPObjectProxy):

  • Shared/Plugins/NPRemoteObjectMap.h:
  • WebProcess/Plugins/PluginProcessConnection.cpp:

(WebKit::PluginProcessConnection::PluginProcessConnection):
(WebKit::PluginProcessConnection::didReceiveSyncMessage):

  • WebProcess/Plugins/PluginProcessConnection.h:

(WebKit::PluginProcessConnection::npRemoteObjectMap):

  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::getWindowScriptNPObject):

17:09 Changeset [71080] by mrobinson@webkit.org

2010-11-01 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[Soup] Random crashes in http/tests/websocket/tests/workers/worker-handshake-challenge-randomness.html
https://bugs.webkit.org/show_bug.cgi?id=48805

Track active WebSocket handles via a sequential id. This ensures
that when a handle is reallocated into a recently used segment of
memory, it doesn't trigger a false positive in the code which ensures
the original handle is active.

No new tests. This test should stop crashing on the bots, proving the fix.

  • platform/network/soup/SocketStreamHandle.h: (WebCore::SocketStreamHandle::id): Added an m_id member and accessor to SocketStreamHandle.
  • platform/network/soup/SocketStreamHandleSoup.cpp: (WebCore::getHandleFromId): Updated to work with HashMap of handle ids to SocketStreamHandle*. (WebCore::deactivateHandle): Ditto. (WebCore::activateHandle): Ditto. (WebCore::SocketStreamHandle::SocketStreamHandle): Ditto. (WebCore::SocketStreamHandle::connected): Ditto. (WebCore::SocketStreamHandle::readBytes): Ditto. (WebCore::SocketStreamHandle::beginWaitingForSocketWritability): Ditto. (WebCore::connectedCallback): Ditto. (WebCore::readReadyCallback): Ditto. (WebCore::writeReadyCallback): Ditto.
17:05 Changeset [71079] by tkent@chromium.org

2010-11-01 Kent Tamura <tkent@chromium.org>

Unreviewed. Run sort-Xcode-project-file.

  • WebCore.xcodeproj/project.pbxproj:
17:05 Changeset [71078] by tony@chromium.org

2010-11-01 Tony Chang <tony@chromium.org>

Reviewed by Kent Tamura.

add plugin event logging for linux
https://bugs.webkit.org/show_bug.cgi?id=48779

This is taken from Chromium's fork of the layout test plugin:
http://git.chromium.org/gitweb/?p=chromium.git/.git;a=blob;f=webkit/tools/npapi_layout_test_plugin/main.cpp;h=3ebdada2f049b3624756438cff852364f86a2ede;hb=HEAD#l348

  • DumpRenderTree/TestNetscapePlugIn/main.cpp: (handleEventX11): (NPP_HandleEvent):
17:00 Changeset [71077] by tony@chromium.org

2010-11-01 Tony Chang <tony@chromium.org>

Reviewed by Kent Tamura.

[chromium] Compile TestNetscapePlugin on chromium win
https://bugs.webkit.org/show_bug.cgi?id=48802

It creates npTestNetscapePlugin.dll in the build directory, so
it's not yet loaded by DRT or test_shell.

  • WebKit.gyp:
17:00 Changeset [71076] by andersca@apple.com

Remove duplicate ChangeLog entry.

16:58 Changeset [71075] by andersca@apple.com

Respond to NP_GetProperty by sending a GetProperty message
https://bugs.webkit.org/show_bug.cgi?id=48797

Reviewed by John Sullivan.

  • Platform/CoreIPC/HandleMessage.h:

(CoreIPC::callMemberFunction):
Add new sync message overload.

  • PluginProcess/WebProcessConnection.cpp:

(WebKit::WebProcessConnection::didReceiveSyncMessage):
If the message class is MessageClassNPObjectMessageReceiver, pass it to the NPRemoteObjectMap.

  • Shared/Plugins/NPIdentifierData.cpp:
  • Shared/Plugins/NPIdentifierData.h:

Add NPIdentifierData, a CoreIPC representation of an NPIdentifier.

  • Shared/Plugins/NPObjectMessageReceiver.cpp:

(WebKit::NPObjectMessageReceiver::getProperty):
Add stub.

  • Shared/Plugins/NPObjectMessageReceiver.messages.in:

Add GetProperty.

  • Shared/Plugins/NPObjectProxy.cpp:

(WebKit::NPObjectProxy::create):
(WebKit::NPObjectProxy::NPObjectProxy):
(WebKit::NPObjectProxy::initialize):
NPObjectProxy now takes an NPRemoteObjectMap in its create function.

(WebKit::NPObjectProxy::getProperty):
Send a GetProperty message.

(WebKit::NPObjectProxy::NP_GetProperty):
Call getProperty.

  • Shared/Plugins/NPRemoteObjectMap.cpp:

(WebKit::NPRemoteObjectMap::createNPObjectProxy):
Pass the NPRemoteObjectMap.

(WebKit::NPRemoteObjectMap::didReceiveSyncMessage):
Find the right message receiver and dispatch the message to it.

  • Shared/Plugins/NPVariantData.cpp:
  • Shared/Plugins/NPVariantData.h:

Add NPVariantData, which will be a CoreIPC representation of an NPVariant.

  • WebKit2.xcodeproj/project.pbxproj:

Add new files.

  • WebProcess/Plugins/PluginProcessConnection.cpp:

(WebKit::PluginProcessConnection::didReceiveSyncMessage):
If the message class is MessageClassNPObjectMessageReceiver, pass it to the NPRemoteObjectMap.

16:41 Changeset [71074] by simon.fraser@apple.com

2010-11-01 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

Assertion failure in FrameView::layout when clicking on a YouTube video on youtube.com front page
https://bugs.webkit.org/show_bug.cgi?id=44287

When removing subframes, it's possible for layout() to get called on a FrameView
for a Frame that has been removed from the frame tree. This can happen if the parent
document happens to do a layout() while RenderView still has a reference to the widget
for the removed frame; updateWidgetPosition() will try to force a layout() on the
subframe.

Fix by checking that the FrameView's Frame still has a reference to the page before
calling layout() on the subframe.

Test: fast/frames/layout-after-destruction.html

  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::updateWidgetPosition):
16:36 Changeset [71073] by mihaip@chromium.org

2010-11-01 Mihai Parparita <mihaip@chromium.org>

Update the pixel expectations for fast/dom, fast/dynamic, fast/encoding, fast/events, and fast/gradients for the Mac port.

For the tests that currently fail on Snow Leopard with --pixel-tests
--tolerance 0, this moves the current pixel results to mac-leopard and
adds new Snow Leopard-specific results to platform/mac.

List of files omitted due to length but composed entirely of moves from
platform/mac to platform/mac-leopard and newly added files in
platform/mac.

16:30 Changeset [71072] by mihaip@chromium.org

2010-11-01 Mihai Parparita <mihaip@chromium.org>

Update the pixel expectations for fast/dom, fast/dynamic, fast/encoding, fast/events, and fast/gradients for the Mac port.

For the tests that currently fail on Snow Leopard with --pixel-tests
--tolerance 0, this moves the current pixel results to mac-leopard and
adds new Snow Leopard-specific results to platform/mac.

List of files omitted due to length but composed entirely of moves from
platform/mac to platform/mac-leopard and newly added files in
platform/mac.

16:25 Changeset [71071] by dimich@chromium.org

2010-11-01 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r71065.
http://trac.webkit.org/changeset/71065
https://bugs.webkit.org/show_bug.cgi?id=48801

Seem to breake a lot of tests on Chromium bots (Requested by
dimich on #webkit).

  • platform/image-decoders/ImageDecoder.cpp:
  • platform/image-decoders/ImageDecoder.h:
  • platform/image-decoders/cg/ImageDecoderCG.cpp: (WebCore::RGBA32Buffer::asNewNativeImage):
  • platform/image-decoders/png/PNGImageDecoder.cpp: (WebCore::PNGImageDecoder::headerAvailable): (WebCore::PNGImageDecoder::rowAvailable):
  • platform/image-decoders/qt/RGBA32BufferQt.cpp:
  • platform/image-decoders/skia/ImageDecoderSkia.cpp:
16:23 Changeset [71070] by jamesr@google.com

2010-11-01 James Robinson <jamesr@chromium.org>

Update chromium baselines for a few tests.

  • platform/chromium-linux/fast/repaint/iframe-scroll-repaint-expected.checksum: Added.
  • platform/chromium-linux/fast/repaint/iframe-scroll-repaint-expected.png: Added.
  • platform/chromium-linux/svg/custom/resource-invalidate-on-target-update-expected.checksum: Added.
  • platform/chromium-linux/svg/custom/resource-invalidate-on-target-update-expected.png: Added.
  • platform/chromium-mac/fast/repaint/iframe-scroll-repaint-expected.checksum: Added.
  • platform/chromium-mac/fast/repaint/iframe-scroll-repaint-expected.png: Added.
  • platform/chromium-mac/svg/custom/resource-invalidate-on-target-update-expected.checksum: Removed.
  • platform/chromium-mac/svg/custom/resource-invalidate-on-target-update-expected.png: Removed.
  • platform/chromium-win/fast/repaint/iframe-scroll-repaint-expected.checksum: Added.
  • platform/chromium-win/fast/repaint/iframe-scroll-repaint-expected.png: Added.
  • platform/chromium-win/fast/repaint/iframe-scroll-repaint-expected.txt: Added.
  • platform/chromium-win/svg/custom/resource-invalidate-on-target-update-expected.checksum:
  • platform/chromium-win/svg/custom/resource-invalidate-on-target-update-expected.png:
  • platform/chromium/test_expectations.txt:
16:12 Changeset [71069] by andersca@apple.com

Add ArgumentCoder specialization for WTF::CString
https://bugs.webkit.org/show_bug.cgi?id=48796

Reviewed by Sam Weinig.

  • Platform/CoreIPC/ArgumentCoders.h:
16:01 Changeset [71068] by dpranke@chromium.org

2010-11-01 Dirk Pranke <dpranke@chromium.org>

Reviewed by James Robinson.

new-run-webkit-tests: use DRT, child-processes=1 for GPU tests by default
https://bugs.webkit.org/show_bug.cgi?id=48790

  • Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
  • Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
15:43 Changeset [71067] by hyatt@apple.com

Fix SVG bustage.

15:40 Changeset [71066] by mdelaney@apple.com

2010-11-01 Matthew Delaney <mdelaney@apple.com>

Reviewed by Simon Fraser.

Setting attr repeatDur=0 on SVG element causes hang
https://bugs.webkit.org/show_bug.cgi?id=48785

Test: svg/animations/repeatDur-zero.xhtml

  • svg/animation/SVGSMILElement.cpp: Fixing bound checking for legal repeatDur values.

2010-11-01 Matthew Delaney <mdelaney@apple.com>

Reviewed by Simon Fraser.

Setting attr repeatDur=0 on SVG element causes hang
https://bugs.webkit.org/show_bug.cgi?id=48785

  • svg/animations/repeatDur-zero.xhtml: Added. Tests if setting attr repeatDur=0 causes a hang or not.
15:33 Changeset [71065] by abarth@webkit.org

2010-10-31 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

[Chromium] Add ICC support for PNG on Mac
https://bugs.webkit.org/show_bug.cgi?id=48170

This just pipes the ICC profile from libpng to CoreGraphics. This
patch would have been a lot prettier on Snow Leopard, but we have to
use a somewhat ugly API to get this to work on Leopard.

This is covered by about infinite tests.

  • platform/image-decoders/ImageDecoder.cpp: (WebCore::RGBA32Buffer::setColorProfile):
  • platform/image-decoders/ImageDecoder.h:
  • platform/image-decoders/cg/ImageDecoderCG.cpp: (WebCore::RGBA32Buffer::asNewNativeImage):
  • platform/image-decoders/png/PNGImageDecoder.cpp: (WebCore::PNGImageDecoder::headerAvailable): (WebCore::PNGImageDecoder::rowAvailable):
  • platform/image-decoders/qt/RGBA32BufferQt.cpp: (WebCore::RGBA32Buffer::setColorProfile):
  • platform/image-decoders/skia/ImageDecoderSkia.cpp: (WebCore::RGBA32Buffer::setColorProfile):
15:27 Changeset [71064] by abarth@webkit.org

2010-11-01 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Teach check-webkit-style how to accept a list of files to diff on the
command line
https://bugs.webkit.org/show_bug.cgi?id=48784

In a future patch, webkit-patch will use this option to improve
performance. I'm landing this in two pieces to avoid causing a version
skew problem for the style-bot.

  • Scripts/check-webkit-style:
  • Scripts/webkitpy/style/optparser.py:
  • Scripts/webkitpy/style/optparser_unittest.py:
  • Scripts/webkitpy/style_references.py:
15:20 Changeset [71063] by dimich@chromium.org

[Chromium] Unreviewed test rebaseline.

  • platform/chromium-linux/svg/custom/gradient-userSpaceOnUse-with-percentage-expected.checksum: Removed.
  • platform/chromium-linux/svg/custom/gradient-userSpaceOnUse-with-percentage-expected.png: Removed.
  • platform/chromium-mac/fast/blockflow/border-vertical-lr-expected.checksum:
  • platform/chromium-mac/fast/repaint/inline-horizontal-bt-overflow-expected.checksum: Added.
  • platform/chromium-mac/fast/repaint/inline-horizontal-bt-overflow-expected.png: Added.
  • platform/chromium-mac/fast/repaint/inline-vertical-lr-overflow-expected.checksum: Added.
  • platform/chromium-mac/fast/repaint/inline-vertical-lr-overflow-expected.png: Added.
  • platform/chromium/test_expectations.txt:
15:16 Changeset [71062] by mihaip@chromium.org

2010-11-01 Mihai Parparita <mihaip@chromium.org>

Update the pixel expectations for fast/body-propagation, fast/borders, fast/box-shadow, fast/box-sizing, fast/clip, and fast/compact for the Mac port.

For the tests that currently fail on Snow Leopard with --pixel-tests
--tolerance 0, this moves the current pixel results to mac-leopard and
adds new Snow Leopard-specific results to platform/mac.

List of files omitted due to length but composed entirely of moves from
platform/mac to platform/mac-leopard and newly added files in
platform/mac.

platform/mac/test_expectations.txt was also modified to remove two
now-passing tests.

15:10 Changeset [71061] by senorblanco@chromium.org

2010-11-01 Stephen White <senorblanco@chromium.org>

Unreviewed; test expectations update.

Update chromium-gpu test expectations to reflect test_shell
timeouts on ~35 tests.

  • platform/chromium-gpu/test_expectations.txt:
14:53 Changeset [71060] by andersca@apple.com

Fix build.

  • WebKit2.xcodeproj/project.pbxproj:
14:51 Changeset [71059] by crogers@google.com

audio branch: bracket some JS and V8 wrappper and Event code with #if ENABLE(WEB_AUDIO)

14:30 Changeset [71058] by simon.fraser@apple.com

2010-11-01 Simon Fraser <simon.fraser@apple.com>

Fix test failures on Qt by avoiding references to external image files.

  • fast/backgrounds/multiple-backgrounds-computed-style-expected.txt:
  • fast/backgrounds/script-tests/multiple-backgrounds-computed-style.js:
14:29 Changeset [71057] by andersca@apple.com

Add NPObjectMessageReceiver.messages.in
https://bugs.webkit.org/show_bug.cgi?id=48782

Reviewed by Adam Roben.

  • DerivedSources.make:

Add NPObjectMessageReceiver.

  • Platform/CoreIPC/MessageID.h:

Add MessageClassNPObjectMessageReceiver message class.

  • Shared/Plugins/NPObjectMessageReceiver.cpp:

(WebKit::NPObjectMessageReceiver::deallocate):
Add stubbed out deallocate member function.

  • Shared/Plugins/NPObjectMessageReceiver.messages.in: Added.
  • WebKit2.xcodeproj/project.pbxproj:

Add NPObjectMessageReceiver.messages.in.

14:25 Changeset [71056] by mihaip@chromium.org

2010-11-01 Mihai Parparita <mihaip@chromium.org>

Update the pixel expectations for fast/selectors for the Mac port.

For the tests that currently fail on Snow Leopard with --pixel-tests
--tolerance 0, this moves the current pixel results to mac-leopard and
adds new Snow Leopard-specific results to platform/mac.

List of files omitted due to length but composed entirely of moves from
platform/mac to platform/mac-leopard and newly added files in
platform/mac.

14:13 Changeset [71055] by hyatt@apple.com

https://bugs.webkit.org/show_bug.cgi?id=48776

Reviewed by Dan Bernstein.

Change isVertical() on InlineBox to isHorizontal() instead. This makes the horizontal code path come
first if you branch on isHorizontal() and makes the code read better (since that's the more common code
path).

  • rendering/InlineBox.cpp:

(WebCore::InlineBox::logicalHeight):

  • rendering/InlineBox.h:

(WebCore::InlineBox::InlineBox):
(WebCore::InlineBox::isHorizontal):
(WebCore::InlineBox::setIsHorizontal):
(WebCore::InlineBox::width):
(WebCore::InlineBox::height):
(WebCore::InlineBox::logicalLeft):
(WebCore::InlineBox::setLogicalLeft):
(WebCore::InlineBox::logicalTop):
(WebCore::InlineBox::setLogicalTop):
(WebCore::InlineBox::baselinePosition):
(WebCore::InlineBox::lineHeight):

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::addToLine):
(WebCore::InlineFlowBox::placeBoxesInInlineDirection):
(WebCore::InlineFlowBox::computeBlockDirectionOverflow):
(WebCore::InlineFlowBox::paintFillLayer):
(WebCore::InlineFlowBox::paintBoxDecorations):
(WebCore::InlineFlowBox::paintMask):

  • rendering/InlineFlowBox.h:

(WebCore::InlineFlowBox::marginLogicalLeft):
(WebCore::InlineFlowBox::marginLogicalRight):
(WebCore::InlineFlowBox::borderLogicalLeft):
(WebCore::InlineFlowBox::borderLogicalRight):
(WebCore::InlineFlowBox::paddingLogicalLeft):
(WebCore::InlineFlowBox::paddingLogicalRight):
(WebCore::InlineFlowBox::setInlineDirectionOverflowPositions):
(WebCore::InlineFlowBox::setBlockDirectionOverflowPositions):

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::selectionRect):
(WebCore::InlineTextBox::applyShadowToGraphicsContext):
(WebCore::paintTextWithShadows):
(WebCore::InlineTextBox::paint):
(WebCore::InlineTextBox::paintDecoration):

  • rendering/InlineTextBox.h:
  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::createLineBoxes):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::blockDirectionOverflow):

  • rendering/RenderBox.h:
  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintFillLayerExtended):

  • rendering/RenderLineBoxList.cpp:

(WebCore::RenderLineBoxList::hitTest):

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::RootInlineBox):
(WebCore::RootInlineBox::placeEllipsis):

  • rendering/RootInlineBox.h:

(WebCore::RootInlineBox::baselinePosition):
(WebCore::RootInlineBox::lineHeight):

14:10 Changeset [71054] by andersca@apple.com

Start stubbing out NPClass functions in NPObjectProxy
https://bugs.webkit.org/show_bug.cgi?id=48778

Reviewed by Adam Roben.

  • PluginProcess/PluginControllerProxy.cpp:

(WebKit::PluginControllerProxy::windowScriptNPObject):
getOrCreateNPObjectProxy is now createNPObjectProxy.

  • Shared/Plugins/NPObjectProxy.cpp:

(WebKit::NPObjectProxy::create):
Allocate and initialize an NPObjectProxy object.

(WebKit::NPObjectProxy::NPObjectProxy):
Initialize m_npObjectID to 0.

(WebKit::NPObjectProxy::isNPObjectProxy):
Check the class.

(WebKit::NPObjectProxy::initialize):
Set m_npObjectID.

(WebKit::NPObjectProxy::npClass):
Return the NPClass with all functions filled in.

(WebKit::NPObjectProxy::NP_Allocate):
Create a new NPObjectProxy object.

(WebKit::NPObjectProxy::NP_Deallocate):
Deallocate the NPObjectProxy object.

(WebKit::NPObjectProxy::NP_HasMethod):
(WebKit::NPObjectProxy::NP_Invoke):
(WebKit::NPObjectProxy::NP_InvokeDefault):
(WebKit::NPObjectProxy::NP_HasProperty):
(WebKit::NPObjectProxy::NP_GetProperty):
(WebKit::NPObjectProxy::NP_SetProperty):
(WebKit::NPObjectProxy::NP_RemoveProperty):
(WebKit::NPObjectProxy::NP_Enumerate):
(WebKit::NPObjectProxy::NP_Construct):
Add stubs.

  • Shared/Plugins/NPRemoteObjectMap.cpp:

(WebKit::NPRemoteObjectMap::createNPObjectProxy):

  • Shared/Plugins/NPRemoteObjectMap.h:

Rename getOrCreateNPObjectProxy to createNPObjectProxy.

  • WebProcess/Plugins/Netscape/NPJSObject.cpp:

(WebKit::NPJSObject::NP_Allocate):
Remove unused parameter.

14:01 Changeset [71053] by dimich@chromium.org

[Chromium] Unreviewed update of test expectations.
Add baseline for a new test added in http://trac.webkit.org/changeset/71043

  • platform/chromium-mac/fast/repaint/inline-vertical-rl-overflow-expected.checksum: Added.
  • platform/chromium-mac/fast/repaint/inline-vertical-rl-overflow-expected.png: Added.
  • platform/chromium-mac/fast/repaint/inline-vertical-rl-overflow-expected.txt: Added.
  • platform/chromium-win/fast/repaint/inline-vertical-rl-overflow-expected.txt: Added.
14:00 Changeset [71052] by mario@webkit.org

2010-11-01 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Cleanup needed in testatk.c file
https://bugs.webkit.org/show_bug.cgi?id=48759

Cleanup done in testatk.c, mainly addressing the following issues:

  • Removed any trace of extra main loops in tests, so now we just spin the original main loop in all of them to get the a11y objects.
  • As we no longer use the extra main loops, removed the bail_out function, used along with g_idle_add() to stop those extra loops.
  • As we now spin the loop in every test, created a new function waitForAccessibilityObjects() to write the loop just once.
  • Fixed name in incorrectly named test testWekitAtkTextSelections.
  • Alphabetically sorted the list of includes.
  • Renamed all identifiers to camel Case notation.
  • Declare variables when needed only (instead of declaring all of them at the beginning of the function).
  • Don't declare two variables of the same type in the same line.
  • No more short names like 'obj', 'textObj' or 'alloc'. Use names like 'object', 'textObject' and 'allocation' instead.
  • Fixed indentation.
  • Make sure all comments finish with '.'
  • Replace NULL's with 0's.
  • tests/testatk.c: (waitForAccessibleObjects): New, manually spins the main context to make sure accessible objects are created before continuing. (testGetTextFunction): Fixed this function to be compliant with the WebKit's coding style. (runGetTextTests): Ditto. (testWebkitAtkGetTextAtOffsetForms): Ditto. (testWebkitAtkGetTextAtOffset): Ditto. (testWebkitAtkGetTextAtOffsetNewlines): Ditto. (testWebkitAtkGetTextAtOffsetTextarea): Ditto. (testWebkitAtkGetTextAtOffsetTextInput): Ditto. (testWebkitAtkGetTextInParagraphAndBodySimple): Ditto. (testWebkitAtkGetTextInParagraphAndBodyModerate): Ditto. (testWebkitAtkGetTextInTable): Ditto. (testWebkitAtkGetHeadersInTable): Ditto. (compAtkAttribute): Ditto. (atkAttributeSetAttributeNameHasValue): Ditto. (testWebkitAtkTextAttributes): Ditto. (testWebkitAtkTextSelections): Ditto. (testWebkitAtkGetExtents): Ditto. (testWebkitAtkLayoutAndDataTables): Ditto. (testWebkitAtkLinksWithInlineImages): Ditto. (testWebkitAtkHypertextAndHyperlinks): Ditto. (testWebkitAtkListsOfItems): Ditto. (testWebkitAtkTextChangedNotifications): Ditto. (main): Ditto.
13:53 UpdatingBugzilla edited by ddkilzer@apple.com
(diff)
13:47 Changeset [71051] by andersca@apple.com

Both the WebProcessConnection and PluginProcessConnection should have NPRemoteObjectMaps
https://bugs.webkit.org/show_bug.cgi?id=48775

Reviewed by Adam Roben.

  • PluginProcess/PluginControllerProxy.cpp:

(WebKit::PluginControllerProxy::windowScriptNPObject):
Ask for an NPObjectProxy for the window script NPObject.

  • PluginProcess/WebProcessConnection.cpp:

(WebKit::WebProcessConnection::WebProcessConnection):
Initialize m_npRemoteObjectMap.

  • Shared/Plugins/NPObjectMessageReceiver.cpp:

(WebKit::NPObjectMessageReceiver::create):
Add a create member function that takes an NPObject.

(WebKit::NPObjectMessageReceiver::NPObjectMessageReceiver):
Retain the NPObject.

(WebKit::NPObjectMessageReceiver::~NPObjectMessageReceiver):
Release the NPObject.

  • Shared/Plugins/NPRemoteObjectMap.cpp:

(WebKit::generateNPObjectID):
Generate a unique 64-bit NPObject ID.

(WebKit::NPRemoteObjectMap::getOrCreateNPObjectProxy):
Add stub.

(WebKit::NPRemoteObjectMap::registerNPObject):
Create a NPObjectMessageReceiver and add it to the map.

  • WebKit2.xcodeproj/project.pbxproj:

Set the correct target for NPRuntime related files.

  • WebProcess/Plugins/PluginProcessConnection.cpp:

(WebKit::PluginProcessConnection::PluginProcessConnection):
Initialize m_npRemoteObjectMap

  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::getWindowScriptNPObject):
Ask the real plug-in controller for the window script NPObject and register it.

13:44 Changeset [71050] by dimich@chromium.org

[Chromium] Unreviewed, update test expectations.
Updated render tree dumps after http://trac.webkit.org/changeset/71043.

  • platform/chromium-linux/fast/blockflow/japanese-lr-text-expected.txt:
  • platform/chromium-linux/fast/blockflow/japanese-rl-text-expected.txt:
  • platform/chromium-win/fast/blockflow/basic-vertical-line-expected.txt:
  • platform/chromium-win/fast/blockflow/border-radius-clipping-vertical-lr-expected.txt:
  • platform/chromium-win/fast/blockflow/box-shadow-vertical-lr-expected.txt:
  • platform/chromium-win/fast/blockflow/box-shadow-vertical-rl-expected.txt:
  • platform/chromium-win/fast/blockflow/english-lr-text-expected.txt:
  • platform/chromium-win/fast/blockflow/english-rl-text-expected.txt:
  • platform/chromium-win/fast/blockflow/japanese-lr-text-expected.txt:
  • platform/chromium-win/fast/blockflow/japanese-rl-text-expected.txt:
13:39 Changeset [71049] by simon.fraser@apple.com

2010-11-01 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dave Hyatt.

Multiple background properties are not retrievable via DOM method getComputedStyle
https://bugs.webkit.org/show_bug.cgi?id=23203

Return lists of values from getComputedStyle() for multiple backgrounds,
and multiple masks.

Test: fast/backgrounds/multiple-backgrounds-computed-style.html

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::fillSizeToCSSValue): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
13:37 Changeset [71048] by sullivan@apple.com

https://bugs.webkit.org/show_bug.cgi?id=48774
minimFontSize preference needs to be exposed in WebKit2

Reviewed by Anders Carlsson.

  • UIProcess/WebPreferences.cpp:

(WebKit::WebPreferences::setMinimumFontSize):
New function, parallel to existing functions for other preferences.
(WebKit::WebPreferences::minimumFontSize):
Ditto.

  • UIProcess/WebPreferences.h:

Declared new function.

  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetMinimumFontSize):
New UI process wrapper for new function.
(WKPreferencesGetMinimumFontSize):
Ditto.

  • UIProcess/API/C/WKPreferences.h:

Declared new functions.

13:24 Changeset [71047] by mihaip@chromium.org

2010-11-01 Mihai Parparita <mihaip@chromium.org>

Update the pixel expectations for fast/block/positioning for the Mac port.

For the tests that currently fail on Snow Leopard with --pixel-tests
--tolerance 0, this moves the current pixel results to mac-leopard and
adds new Snow Leopard-specific results to platform/mac.

List of files omitted due to length but composed entirely of moves from
platform/mac to platform/mac-leopard and newly added files in
platform/mac.

13:20 Changeset [71046] by dimich@chromium.org

[Chromium] Unreviewed update of test expectations.
svg-as-background.html now fails on debug mac 10.5 bots.

  • platform/chromium/test_expectations.txt:
12:30 Changeset [71045] by crogers@google.com

audio branch: changes in preparation for landing in trunk

  • change name from Accelerate to VectorMath
  • AudioResamplerKernel cleanup
  • JSDOMWindowCustom.cpp: guard include and audioContext() method with ENABLE_WEB_AUDIO
  • V8Binding.cpp: remove AdjustAmountOfExternalAllocatedMemory() hack
12:16 Changeset [71044] by andersca@apple.com

Tear down the related WebProcessProxy when a WebContext is deallocated
https://bugs.webkit.org/show_bug.cgi?id=48769

Reviewed by John Sullivan.

WebKit2:

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::~WebContext):
Call WebProcessManager::contextWasDestroyed.

(WebKit::WebContext::didNavigateWithNavigationData):
(WebKit::WebContext::didPerformClientRedirect):
(WebKit::WebContext::didPerformServerRedirect):
(WebKit::WebContext::didUpdateHistoryTitle):
It is valid for a frame to have a null page here, if the frame has outlived
its page.

  • UIProcess/WebProcessManager.cpp:

(WebKit::WebProcessManager::contextWasDestroyed):
Remove the context from the map.

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::~WebProcessProxy):
It's OK for the connection to be non-null here if the process goes away because
the context has been deallocated.

WebKitTools:

  • TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:

(TestWebKitAPI::didFailProvisionalLoadWithErrorForFrame):
We don't support empty URLs anymore, update test to expect a null URL instead.

12:07 Changeset [71043] by hyatt@apple.com

https://bugs.webkit.org/show_bug.cgi?id=48663

Reviewed by Dan Bernstein.

Make repaint invalidation work with vertical lines. Rewrite linesBoundingBox for RenderText and
RenderInline to give the correct rectangle back for vertical lines. Also patch linesVisibleOverflowBoundingBox
to give back the correct rectangle for vertical lines.

Fix bugs in the overflow accessors of InlineFlowBox when m_overflow was 0.

Patch hit testing to also account for "rt" and "bt" blocks.

WebCore:

  • rendering/InlineBox.cpp:

(WebCore::InlineBox::adjustForFlippedBlocksWritingMode):

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::nodeAtPoint):

  • rendering/InlineFlowBox.h:

(WebCore::InlineFlowBox::logicalLeftVisibleOverflow):
(WebCore::InlineFlowBox::logicalRightVisibleOverflow):
(WebCore::InlineFlowBox::bottomLayoutOverflow):
(WebCore::InlineFlowBox::rightLayoutOverflow):
(WebCore::InlineFlowBox::bottomVisualOverflow):
(WebCore::InlineFlowBox::rightVisualOverflow):

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::nodeAtPoint):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::hitTestFloats):
(WebCore::RenderBlock::hitTestContents):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeRectForRepaint):
(WebCore::RenderBox::adjustForFlippedBlocksWritingMode):

  • rendering/RenderBox.h:
  • rendering/RenderInline.cpp:

(WebCore::RenderInline::linesBoundingBox):
(WebCore::RenderInline::linesVisibleOverflowBoundingBox):
(WebCore::RenderInline::clippedOverflowRectForRepaint):

  • rendering/RenderText.cpp:

(WebCore::RenderText::linesBoundingBox):

LayoutTests:

  • fast/repaint/inline-horizontal-bt-overflow.html: Added.
  • fast/repaint/inline-vertical-lr-overflow.html: Added.
  • fast/repaint/inline-vertical-rl-overflow.html: Copied from fast/repaint/inline-vertical-rl-overflow.html.
  • platform/mac/fast/blockflow/background-vertical-lr-expected.txt:
  • platform/mac/fast/blockflow/background-vertical-rl-expected.txt:
  • platform/mac/fast/blockflow/basic-vertical-line-expected.txt:
  • platform/mac/fast/blockflow/border-image-vertical-lr-expected.txt:
  • platform/mac/fast/blockflow/border-image-vertical-rl-expected.txt:
  • platform/mac/fast/blockflow/border-radius-clipping-vertical-lr-expected.txt:
  • platform/mac/fast/blockflow/border-vertical-lr-expected.checksum:
  • platform/mac/fast/blockflow/border-vertical-lr-expected.png:
  • platform/mac/fast/blockflow/border-vertical-lr-expected.txt:
  • platform/mac/fast/blockflow/box-shadow-vertical-lr-expected.txt:
  • platform/mac/fast/blockflow/box-shadow-vertical-rl-expected.txt:
  • platform/mac/fast/blockflow/english-lr-text-expected.txt:
  • platform/mac/fast/blockflow/english-rl-text-expected.txt:
  • platform/mac/fast/blockflow/japanese-lr-text-expected.txt:
  • platform/mac/fast/blockflow/japanese-rl-text-expected.txt:
  • platform/mac/fast/repaint/inline-horizontal-bt-overflow-expected.checksum: Added.
  • platform/mac/fast/repaint/inline-horizontal-bt-overflow-expected.png: Added.
  • platform/mac/fast/repaint/inline-horizontal-bt-overflow-expected.txt: Added.
  • platform/mac/fast/repaint/inline-vertical-lr-overflow-expected.checksum: Added.
  • platform/mac/fast/repaint/inline-vertical-lr-overflow-expected.png: Added.
  • platform/mac/fast/repaint/inline-vertical-lr-overflow-expected.txt: Added.
  • platform/mac/fast/repaint/inline-vertical-rl-overflow-expected.checksum: Copied from platform/mac/fast/repaint/inline-vertical-rl-overflow-expected.checksum.
  • platform/mac/fast/repaint/inline-vertical-rl-overflow-expected.png: Copied from platform/mac/fast/repaint/inline-vertical-rl-overflow-expected.png.
11:53 Changeset [71042] by beidson@apple.com

Windows build fix.

  • UIProcess/win/WebView.cpp:
11:34 Changeset [71041] by beidson@apple.com

<rdar://problem/7660547> and https://bugs.webkit.org/show_bug.cgi?id=48699
Context menu support for WebKit 2.

Reviewed by Anders Carlsson.

WebCore:

Add a "showContextMenu" call to Chrome/ChromeClient:

  • loader/EmptyClients.h:

(WebCore::EmptyChromeClient::showContextMenu):

  • page/Chrome.cpp:

(WebCore::Chrome::showContextMenu):

  • page/Chrome.h:
  • page/ChromeClient.h:

Add a "platform description to ContextMenuItem" creator, will be needed by WebKit2

  • platform/ContextMenu.h:
  • platform/mac/ContextMenuMac.mm:

(WebCore::contextMenuItemVector):

  • platform/mac/ContextMenuItemMac.mm:

(WebCore::ContextMenuItem::checked): WebKit2 ports now need this implemented.

Stub these out to keep their WK2 ports building:

  • platform/qt/ContextMenuItemQt.cpp:

(WebCore::ContextMenuItem::checked):

  • platform/qt/ContextMenuQt.cpp:

(WebCore::contextMenuItemVector):

  • platform/win/ContextMenuItemWin.cpp:

(WebCore::ContextMenuItem::checked):

  • platform/win/ContextMenuWin.cpp:

(WebCore::contextMenuItemVector):

WebKit/chromium:

  • src/ChromeClientImpl.h:

(WebKit::ChromeClientImpl::showContextMenu):

WebKit/efl:

  • WebCoreSupport/ChromeClientEfl.h:

(WebCore::ChromeClientEfl::showContextMenu):

WebKit/gtk:

  • WebCoreSupport/ChromeClientGtk.h:

(WebKit::ChromeClient::showContextMenu):

WebKit/haiku:

  • WebCoreSupport/ChromeClientHaiku.h:

(WebCore::ChromeClientHaiku::showContextMenu):

WebKit/mac:

  • WebCoreSupport/WebChromeClient.h:

(WebChromeClient::showContextMenu):

WebKit/qt:

  • WebCoreSupport/ChromeClientQt.h:

(WebCore::ChromeClientQt::showContextMenu):

WebKit/win:

  • WebCoreSupport/WebChromeClient.h:

(WebChromeClient::showContextMenu):

WebKit/wx:

  • WebKitSupport/ChromeClientWx.h:

(WebCore::ChromeClientWx::showContextMenu):

WebKit2:

  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:
  • Shared/WebContextMenuItem.cpp: Added.

(WebKit::WebContextMenuItem::WebContextMenuItem):
(WebKit::WebContextMenuItem::encode):
(WebKit::WebContextMenuItem::decode):
(WebKit::kitItems):

  • Shared/WebContextMenuItem.h: Added.
  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::createContextMenuProxy):

  • UIProcess/API/qt/qwkpage.cpp:

(QWKPagePrivate::createContextMenuProxy): Stub to keep the build working.

  • UIProcess/API/qt/qwkpage_p.h:
  • UIProcess/PageClient.h:
  • UIProcess/WebContextMenuProxy.cpp: Added.

(WebKit::WebContextMenuProxy::~WebContextMenuProxy):
(WebKit::WebContextMenuProxy::WebContextMenuProxy):

  • UIProcess/WebContextMenuProxy.h: Added.
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::showContextMenu): Shows the menu after receiving the message from the WebProcess.
(WebKit::WebPageProxy::contextMenuItemSelected): Sends info about the selected menu item to the WebProcess

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/mac/WebContextMenuProxyMac.h: Added.

(WebKit::WebContextMenuProxyMac::create):

  • UIProcess/mac/WebContextMenuProxyMac.mm: Added.

(+[WebMenuTarget sharedMenuTarget]):
(-[WebMenuTarget WebKit::]):
(-[WebMenuTarget setMenuProxy:WebKit::]):
(-[WebMenuTarget forwardContextMenuAction:]):
(WebKit::WebContextMenuProxyMac::WebContextMenuProxyMac):
(WebKit::WebContextMenuProxyMac::~WebContextMenuProxyMac):
(WebKit::WebContextMenuProxyMac::contextMenuItemSelected):
(WebKit::populateNSMenu):
(WebKit::nsMenuItemVector):
(WebKit::WebContextMenuProxyMac::populate):
(WebKit::WebContextMenuProxyMac::showContextMenu):
(WebKit::WebContextMenuProxyMac::hideContextMenu):

  • UIProcess/win/WebView.cpp:

(WebKit::WebView::createContextMenuProxy): Stub for now.

  • UIProcess/win/WebView.h:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::showContextMenu):

  • WebProcess/WebCoreSupport/WebChromeClient.h:
  • WebProcess/WebCoreSupport/WebContextMenuClient.cpp:

(WebKit::WebContextMenuClient::getCustomMenuFromDefaultItems): Return the WebCore-provided default

menu for now. Embedding app customization will come later (see bug 48720)

  • WebProcess/WebPage/WebContextMenu.cpp: Added.

(WebKit::WebContextMenu::WebContextMenu):
(WebKit::WebContextMenu::~WebContextMenu):
(WebKit::WebContextMenu::show):
(WebKit::WebContextMenu::itemSelected):

  • WebProcess/WebPage/WebContextMenu.h: Added.

(WebKit::WebContextMenu::create):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::contextMenu):
(WebKit::handleMouseEvent): Pass right mouse presses along to WebCore as both a mouse event and context menu event,

the same way WebKit1 does.

(WebKit::WebPage::didSelectItemFromActiveContextMenu):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
11:30 Changeset [71040] by pfeldman@chromium.org

2010-11-01 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: Chromium build fix.

  • src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::WebDevToolsAgentImpl):
11:18 Changeset [71039] by eric.carlson@apple.com

2010-11-01 Eric Carlson <eric.carlson@apple.com>

Reviewed by Adam Roben.

Seeking by very small increment doesn't generate 'seeked' event
https://bugs.webkit.org/show_bug.cgi?id=48530

Test: media/video-seek-by-small-increment.html

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::seek): Ask the media engine for its closest time value so we can avoid asking it to seek to the current time.
  • platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::mediaTimeForTimeValue): New.
  • platform/graphics/MediaPlayer.h:
  • platform/graphics/MediaPlayerPrivate.h: (WebCore::MediaPlayerPrivateInterface::mediaTimeForTimeValue): Ditto.
  • platform/graphics/mac/MediaPlayerPrivateQTKit.h:
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::mediaTimeForTimeValue): Return the closest value in the movie's time scale.
  • platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp: (WebCore::MediaPlayerPrivateQuickTimeVisualContext::mediaTimeForTimeValue): Ditto
  • platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.h:
  • platform/graphics/win/QTMovie.cpp: (QTMovie::timeScale): Return the movie's time scale.
  • platform/graphics/win/QTMovie.h:

2010-11-01 Eric Carlson <eric.carlson@apple.com>

Reviewed by Adam Roben.

Seeking by very small increment doesn't generate 'seeked' event
https://bugs.webkit.org/show_bug.cgi?id=48530

  • media/video-seek-by-small-increment-expected.txt: Added.
  • media/video-seek-by-small-increment.html: Added.
  • platform/qt/Skipped: Skip new test as it fails.
11:14 Changeset [71038] by pfeldman@chromium.org

2010-11-01 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: Chromium build fix. Adding missing transitive dependency.

  • inspector/InspectorResourceAgent.cpp:
11:09 Changeset [71037] by mihaip@chromium.org

2010-11-01 Mihai Parparita <mihaip@chromium.org>

Update the pixel expectations for fast/block/margin-collapse for the Mac port.

For the tests that currently fail on Snow Leopard with --pixel-tests
--tolerance 0, this moves the current pixel results to mac-leopard and
adds new Snow Leopard-specific results to platform/mac.

List of files omitted due to length but composed entirely of moves from
platform/mac to platform/mac-leopard and newly added files in
platform/mac.

11:02 Changeset [71036] by pfeldman@chromium.org

2010-11-01 Pavel Feldman <pfeldman@chromium.org>

Not reviewed. Removing references to removed file from project files.

  • WebCore.gypi:
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.css:
10:56 Changeset [71035] by pfeldman@chromium.org

2010-11-01 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: remove old resources panel.
https://bugs.webkit.org/show_bug.cgi?id=45657

  • CMakeLists.txt:
  • English.lproj/localizedStrings.js:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSInjectedScriptHostCustom.cpp:
  • inspector/InjectedScriptHost.cpp:
  • inspector/Inspector.idl:
  • inspector/InspectorCSSStore.cpp:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::~InspectorController): (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::releaseFrontendLifetimeAgents): (WebCore::InspectorController::populateScriptObjects): (WebCore::InspectorController::unbindAllResources): (WebCore::InspectorController::didCommitLoad): (WebCore::InspectorController::frameDetachedFromParent): (WebCore::InspectorController::didLoadResourceFromMemoryCache): (WebCore::InspectorController::identifierForInitialRequest): (WebCore::InspectorController::willSendRequest): (WebCore::InspectorController::markResourceAsCached): (WebCore::InspectorController::didReceiveResponse): (WebCore::InspectorController::didReceiveContentLength): (WebCore::InspectorController::didFinishLoading): (WebCore::InspectorController::didFailLoading): (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest): (WebCore::InspectorController::scriptImported): (WebCore::InspectorController::didCreateWebSocket): (WebCore::InspectorController::willSendWebSocketHandshakeRequest): (WebCore::InspectorController::didReceiveWebSocketHandshakeResponse): (WebCore::InspectorController::didCloseWebSocket):
  • inspector/InspectorController.h:
  • inspector/InspectorFrontendHost.cpp:
  • inspector/InspectorResource.cpp: Removed.
  • inspector/InspectorResource.h: Removed.
  • inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::setOverrideContent):
  • inspector/InspectorResourceAgent.h:
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.addMessage): (WebInspector.ConsoleView.prototype.clearMessages):
  • inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer.prototype._onRevealAndSelectResource):
  • inspector/front-end/Images/resourcesSilhouette.png: Removed.
  • inspector/front-end/Resource.js:
  • inspector/front-end/ResourceManager.js: (WebInspector.ResourceManager.getContent):
  • inspector/front-end/ResourcesPanel.js: Removed.
  • inspector/front-end/Settings.js:
  • inspector/front-end/StoragePanel.js: (WebInspector.StoragePanel): (WebInspector.StoragePanel.prototype.get toolbarItemLabel):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js: (WebInspector._createPanels): (WebInspector.get networkResources): (WebInspector.forAllResources): (WebInspector.resourceForURL): (WebInspector.doLoadedDone.populateInspectorState): (WebInspector.openResource): (WebInspector.domContentEventFired): (WebInspector.loadEventFired): (WebInspector.reset): (WebInspector._choosePanelToShowSourceLine):

2010-11-01 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: remove old resources panel.
https://bugs.webkit.org/show_bug.cgi?id=45657

  • src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::setApuAgentEnabled):
  • src/WebDevToolsAgentImpl.h:

2010-11-01 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: remove old resources panel.
https://bugs.webkit.org/show_bug.cgi?id=45657

  • http/tests/inspector/inspector-test2.js:
  • http/tests/inspector/resource-har-conversion.html:
  • http/tests/inspector/resource-parameters.html:
  • inspector/audits-panel-functional.html:
  • inspector/extensions-test.js:
  • inspector/report-protocol-errors-expected.txt:
  • inspector/report-protocol-errors.html:
  • inspector/styles-source-offsets.html:
10:35 Changeset [71034] by zmo@google.com

2010-10-28 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Fix enum naming style violation in GraphicsContext3D
https://bugs.webkit.org/show_bug.cgi?id=48441

  • platform/graphics/GraphicsContext3D.cpp: (WebCore::GraphicsContext3D::extractImageData): (WebCore::GraphicsContext3D::extractTextureData): (WebCore::doPacking): (WebCore::GraphicsContext3D::packPixels):
  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/cg/GraphicsContext3DCG.cpp: (WebCore::getSourceDataFormat): (WebCore::GraphicsContext3D::getImageData):
  • platform/graphics/skia/GraphicsContext3DSkia.cpp: (WebCore::GraphicsContext3D::getImageData):
09:51 Changeset [71033] by aroben@apple.com

Cancel main resource loads after we hand them off to the media engine

This is the WebKit2 equivalent of r51104. Clearly this code should be
moved to a cross-platform location someday.

Fixes <http://webkit.org/b/48561> <rdar://problem/8606679> Assertion
failure in DocumentLoader::commitData when loading a media document in
WebKit2

Reviewed by Eric Carlson.

  • WebProcess/WebCoreSupport/WebErrors.h: Added pluginWillHandleLoadError.
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebFrameLoaderClient::committedLoad): Cancel the main resource load
after handing off the load to the media engine. This code originally
came from -[WebHTMLRepresentation receivedData:withDataSource:].
(WebKit::WebFrameLoaderClient::pluginWillHandleLoadError): Call through to WebErrors.
(WebKit::WebFrameLoaderClient::shouldFallBack): Implemented. We fall
back for all errors except when the load was cancelled or we handed it
off to the media engine or a plugin.

  • WebProcess/WebCoreSupport/mac/WebErrorsMac.mm:

(WebKit::pluginWillHandleLoadError): Implemented.

  • WebProcess/WebCoreSupport/qt/WebErrorsQt.cpp:

(WebKit::pluginWillHandleLoadError): Stubbed out.

  • WebProcess/WebCoreSupport/win/WebErrorsWin.cpp:

(WebKit::pluginWillHandleLoadError): Implemented.

09:50 Changeset [71032] by aroben@apple.com

Cancel main resource loads after we hand them off to the media engine

This is the Windows equivalent of r51104. Clearly this code should be
moved to a cross-platform location someday.

Fixes <http://webkit.org/b/48531> <rdar://problem/8606635> Assertion
failure in DocumentLoader::commitData when loading a media document in
WebKit1 on Windows

Reviewed by Dan Bernstein.

  • WebCoreSupport/WebFrameLoaderClient.cpp:

(WebFrameLoaderClient::committedLoad): Cancel the main resource load
after handing off the load to the media engine. This code originally
came from -[WebHTMLRepresentation receivedData:withDataSource:].

  • WebFrame.cpp:

(WebFrame::shouldFallBack): Don't fall back when handing the resource
load off to the media engine or a plugin. Added error domain checking
so that we don't rely on error codes being unique.

09:00 Changeset [71031] by mrobinson@webkit.org

2010-11-01 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Pasting markup into Thunderbird compose window produces no text
https://bugs.webkit.org/show_bug.cgi?id=43737

Include a content-type meta tag prefix on all clipboard markup. Programs like
Thunderbird expect this meta tag and will not paste anything unless it is there.

This is covered by changes to WebKit/gtk/tests/testcopyandpaste.c. This patch was
written in such a way as to not affect layout test results, otherwise there
would be many new GTK+-specific results that say "FAIL").

  • platform/gtk/PasteboardHelper.cpp: (WebCore::removeMarkupPrefix): Added this helper which removes the prefix when found on incoming clipboard and drag-and-drop text. (WebCore::PasteboardHelper::getClipboardContents): Remove the meta tag prefix. (WebCore::PasteboardHelper::fillSelectionData): Add the meta tag prefix. (WebCore::PasteboardHelper::fillDataObjectFromDropData): Remove the meta tag prefix

2010-11-01 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Pasting markup into Thunderbird compose window produces no text
https://bugs.webkit.org/show_bug.cgi?id=43737

Added a test verifying that the meta tag prefix on markup data exists.

  • tests/testcopyandpaste.c: (load_status_cb): Add a check for the meta tag prefix.
08:50 Changeset [71030] by commit-queue@webkit.org

2010-11-01 Søren Gjesse <sgjesse@chromium.org>

Reviewed by Andreas Kling.

Fix warning when compiling the chromium port of DumpRenderShell
with clang.
https://bugs.webkit.org/show_bug.cgi?id=48414

  • DumpRenderTree/chromium/TestShell.h: (TestShell::javaScriptFlagsForLoad):
08:33 Changeset [71029] by andreas.kling@nokia.com

2010-11-01 Andreas Kling <kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt][WK2] Cleanup viewportAttributesForSize API

Change QSize argument to a const QSize&.

  • UIProcess/API/qt/qwkpage.cpp: (QWKPage::viewportAttributesForSize):
  • UIProcess/API/qt/qwkpage.h:
08:27 Changeset [71028] by ossy@webkit.org

Unreviewed.

[Qt] DRT sideeffect revealed by r71004
https://bugs.webkit.org/show_bug.cgi?id=48758

  • platform/qt/Skipped: fast/dom/nodesFromRect-basic.html added until fix.
08:23 Changeset [71027] by jschuh@chromium.org

2010-11-01 Justin Schuh <jschuh@chromium.org>

Reviewed by Dirk Schulze.

Check for NULL node in SVGUseElement::associateInstancesWithShadowTreeElements loop
https://bugs.webkit.org/show_bug.cgi?id=48741

  • svg/custom/use-on-use-with-child-and-empty-target-expected.txt: Added.
  • svg/custom/use-on-use-with-child-and-empty-target.svg: Added.

2010-11-01 Justin Schuh <jschuh@chromium.org>

Reviewed by Dirk Schulze.

Check for NULL node in SVGUseElement::associateInstancesWithShadowTreeElements loop
https://bugs.webkit.org/show_bug.cgi?id=48741

Test: svg/custom/use-on-use-with-child-and-empty-target.svg

  • svg/SVGUseElement.cpp: (WebCore::SVGUseElement::associateInstancesWithShadowTreeElements):
08:11 BuildingOnWindows edited by aroben@apple.com
Added some more DLLs that need to be rebased (diff)
08:08 BuildingOnWindows edited by aroben@apple.com
Update instructions for rebasing libphp4.dll (diff)
08:05 Changeset [71026] by mario@webkit.org

2010-11-01 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Martin Robinson.

[Gtk] AtkHyperlink needs to be implemented
https://bugs.webkit.org/show_bug.cgi?id=33785

Implemented the AtkHyperlink/AtkHypertext stuff in the GTK port.

Even thought these kind of tasks are usually about implementing an
interface, in this case it was needed to implement some more
things due to the fact that AtkHyperlink is neither an interface
nor an AtkObject, but just an abstract class child of GObject that
needs to be redefined in a specific subclass of that one. On top
of that, it was needed to implement the AtkAction interface as
well for that new class, so exposed hyperlinks can work as
expected with Assistive Technologies based on ATK.

Furthermore, as there's no mechanism to get an instance of that
AtkHyperlink other than doing it through an AtkObject implementing
the AtkHypertext interface, it was needed to also add the code to
implement that one, so it makes possible to ask for the
'hyperlinks' under an 'hypertext' accessible object.

Finally, to complete the implementation of all this stuff and make
it all consistent, it was needed as well to implement the
AtkHyperlinkImpl interface (providing just one method only) so
that allows retrieving the AtkHyperlink object associated to an
AtkObject implementing such an interface.

  • GNUmakefile.am: Add the new WebKitAccessibleHyperlink.[h|cpp] files to the sources list for the GTK port.
  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (core): New function to return the core accessibility object related to an AtkObject implementing the AtkHypertext interface. (webkitAccessibleHypertextGetLink): New, part of the implementation of the AtkHypertext interface. (webkitAccessibleHypertextGetNLinks): New, likewise. (webkitAccessibleHypertextGetLinkIndex): New, likewise. (atkHypertextInterfaceInit): New, initialize the AtkHypertext interface. (webkitAccessibleHyperlinkImplGetHyperlink): New, part of the implementation of the AtkHyperlinkImpl interface. (atkHyperlinkImplInterfaceInit): New, initialize the AtkHyperlinkImpl interface. (GetAtkInterfaceTypeFromWAIType): Add ATK_TYPE_HYPERTEXT and ATK_TYPE_HYPERLINK_IMPL to the list of recognized types. (getInterfaceMaskFromObject): Decide when it's needed to add WAI_HYPERTEXT and WAI_HYPERLINK to the interface mask.
  • accessibility/gtk/WebKitAccessibleHyperlink.h: Added.
  • accessibility/gtk/WebKitAccessibleHyperlink.cpp: Added. (returnString): Return (const char*) from String variables. (core): Return the associated AccessibilityObject. (webkitAccessibleHyperlinkActionDoAction): Part of the implementation of the AtkAction interface. (webkitAccessibleHyperlinkActionGetNActions): Likewise. (webkitAccessibleHyperlinkActionGetDescription): Likewise. (webkitAccessibleHyperlinkActionGetKeybinding): Likewise. (webkitAccessibleHyperlinkActionGetName): Likewise. (atkActionInterfaceInit): Initialize the AtkAction interface. (getRangeLengthForObject): Returns the length for a given Range, considering special cases (e.g. List item markers). (webkitAccessibleHyperlinkGetURI): Implementation of one of the methods in the AtkHyperlink abstract class. (webkitAccessibleHyperlinkGetObject): Likewise. (webkitAccessibleHyperlinkGetStartIndex): Likewise. (webkitAccessibleHyperlinkGetEndIndex): Likewise. (webkitAccessibleHyperlinkIsValid): Likewise. (webkitAccessibleHyperlinkGetNAnchors): Likewise. (webkitAccessibleHyperlinkIsSelectedLink): Likewise. (webkitAccessibleHyperlinkGetProperty): Getter method. (webkitAccessibleHyperlinkSetProperty): Setter method. (webkitAccessibleHyperlinkFinalize): Finalize method. (webkitAccessibleHyperlinkClassInit): Initialize the WebKitAccessibleHyperlink class. (webkitAccessibleHyperlinkInit): Initialize the WebKitAccessibleHyperlink instance. (webkitAccessibleHyperlinkGetType): Implementation of the get_type() function for the WebKitAccessibleHyperlink class. (webkitAccessibleHyperlinkNew): Returns an instance of the class associated to a given AtkHyperlinkImpl object. (webkitAccessibleHyperlinkGetAccessibilityObject): Public function returning the AccessibilityObject associated to the instance of the WebKitAccessibleHyperlink class.

2010-11-01 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Martin Robinson.

[Gtk] AtkHyperlink needs to be implemented
https://bugs.webkit.org/show_bug.cgi?id=33785

New test to ensure the AtkHypertext/AtkHyperlink stuff works.

  • tests/testatk.c: (testWebkitAtkHypertextAndHyperlinks): New test, checking both the implementation of the AtkHypertext interface, the subclass of the AtkHyperlink abstract class, and the implementation of the AtkAction interface in that subclass. (main): Added the new unit test.
07:55 Changeset [71025] by aroben@apple.com

Add two more failing tests to the WebKit2 Skipped file

  • platform/mac-wk2/Skipped:
07:38 Changeset [71024] by aroben@apple.com

Add some failing/timing out tests to the Windows Skipped file

  • platform/win/Skipped:
07:32 Changeset [71023] by aroben@apple.com

Fix typo from r71022

  • BuildSlaveSupport/build.webkit.org-config/config.json:
07:29 Changeset [71022] by aroben@apple.com

Trigger the Windows Release WebKit2 tests when a Release build finishes, not when a Debug build finishes

Fixes <http://webkit.org/b/48754> Windows Release WebKit2 tests are
triggered at the wrong time

Reviewed by Sam Weinig.

  • BuildSlaveSupport/build.webkit.org-config/config.json: Fixed

triggerable name and trigger.

07:28 Changeset [71021] by jorlow@chromium.org

2010-11-01 Jeremy Orlow <jorlow@chromium.org>

Remove test previous patch fixed.

  • platform/chromium/test_expectations.txt:
07:26 Changeset [71020] by jorlow@chromium.org

2010-11-01 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Steve Block.

Fix IndexedDB layout test
https://bugs.webkit.org/show_bug.cgi?id=48644

This test needs to be async. Also clean up a few other things like
using a logger div rather than document.write.

  • storage/indexeddb/tutorial-expected.txt:
  • storage/indexeddb/tutorial.html:
05:56 Changeset [71019] by satish@chromium.org

2010-11-01 Leandro Gracia Gil <leandrogracia@google.com>

Reviewed by Jeremy Orlow.

This is the last part of a 4-sided patch for the language attribute
in speech text buttons. This patch removes what now is dead code
and re-enables the layout test introduced by bug 47089.
https://bugs.webkit.org/show_bug.cgi?id=47420

  • platform/chromium/test_expectations.txt:

2010-11-01 Leandro Gracia Gil <leandrogracia@google.com>

Reviewed by Jeremy Orlow.

This is the last part of a 4-sided patch for the language attribute
in speech text buttons. This patch removes what now is dead code
and re-enables the layout test introduced by bug 47089.
https://bugs.webkit.org/show_bug.cgi?id=47420

  • public/WebSpeechInputControllerMock.h:
  • src/WebSpeechInputControllerMockImpl.cpp:
  • src/WebSpeechInputControllerMockImpl.h:
05:21 WinCE edited by paroga@webkit.org
(diff)
04:28 Changeset [71018] by mario@webkit.org

2010-11-01 Mario Sanchez Prada <msanchez@igalia.com>

Unreviewed. Adding my IRC nickname to the list of committers.

  • Scripts/webkitpy/common/config/committers.py:
04:09 Changeset [71017] by pfeldman@chromium.org

2010-11-01 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: simplify inspector styles test to make all bots happy.
(drive-by fix for overriden inspector styles in network panel).

  • inspector/InspectorController.h:
  • inspector/front-end/networkPanel.css:

2010-11-01 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: simplify styles test to make all bots happy.

  • inspector/styles-source-lines-inline-expected.txt:
  • inspector/styles-source-lines-inline.html:
03:25 Changeset [71016] by pfeldman@chromium.org

2010-11-01 Pavel Feldman <pfeldman@chromium.org>

Not reviewed. Updating inspector test expectation as a follow up to r71010.

  • inspector/styles-source-lines-inline-expected.txt:
02:12 Changeset [71015] by zimmermann@webkit.org

2010-11-01 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed.

Enable StrictTypeChecking for all types using SVG(Animated)PropertyTearOff
https://bugs.webkit.org/show_bug.cgi?id=48715

Forgot to land some changes in my previous commit.

  • svg/dynamic-updates/script-tests/SVGCircleElement-svgdom-cx-prop.js:
  • svg/dynamic-updates/script-tests/SVGCircleElement-svgdom-cy-prop.js:
  • svg/dynamic-updates/script-tests/SVGCircleElement-svgdom-r-prop.js:
  • svg/dynamic-updates/script-tests/SVGEllipseElement-svgdom-cx-prop.js:
  • svg/dynamic-updates/script-tests/SVGEllipseElement-svgdom-cy-prop.js:
  • svg/dynamic-updates/script-tests/SVGEllipseElement-svgdom-rx-prop.js:
  • svg/dynamic-updates/script-tests/SVGEllipseElement-svgdom-ry-prop.js:
  • svg/dynamic-updates/script-tests/SVGForeignObjectElement-svgdom-height-prop.js:
  • svg/dynamic-updates/script-tests/SVGForeignObjectElement-svgdom-width-prop.js:
  • svg/dynamic-updates/script-tests/SVGForeignObjectElement-svgdom-x-prop.js:
  • svg/dynamic-updates/script-tests/SVGForeignObjectElement-svgdom-y-prop.js:
01:57 Changeset [71014] by zimmermann@webkit.org

2010-10-31 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Rob Buis.

Enable StrictTypeChecking for all types using SVG(Animated)PropertyTearOff
https://bugs.webkit.org/show_bug.cgi?id=48715

Enable StrictTypeChecking for all readwrite attributes and function calls of all types using the new SVG(Animated)PropertyTearOff concept.
Also enable RequiresAllArguments=Raise for all function calls of these new types. Cover this functionality by tests for each of them.

When testing SVGLength it became obvious that quite a lot of functionality was missing.
Conversion from relative arguments (percentage, ems, exs) to user specified units was missing, added that functionality and tested it.
User units to pt conversion was wrong, fixed that.

Tests: svg/dom/SVGAnimatedAngle.html

svg/dom/SVGAnimatedBoolean.html
svg/dom/SVGAnimatedEnumeration.html
svg/dom/SVGAnimatedInteger.html
svg/dom/SVGAnimatedLength.html
svg/dom/SVGAnimatedLengthList.html
svg/dom/SVGAnimatedRect.html
svg/dom/SVGLength-px-with-context.html
svg/dom/SVGLength-px.html
svg/dom/SVGLength.html

  • bindings/js/JSSVGLengthCustom.cpp: These SVGLength methods now take an ExceptionCode parameter, adapt to that. (WebCore::JSSVGLength::value): (WebCore::JSSVGLength::setValue): (WebCore::JSSVGLength::convertToSpecifiedUnits):
  • bindings/scripts/CodeGeneratorObjC.pm: Remove FIXMEs, pass real context instead off null pointer. DOMSVGLength::value is functional now.
  • bindings/v8/custom/V8SVGLengthCustom.cpp: These SVGLength methods now take an ExceptionCode parameter, adapt to that. (WebCore::V8SVGLength::valueAccessorGetter): (WebCore::V8SVGLength::valueAccessorSetter): (WebCore::V8SVGLength::convertToSpecifiedUnitsCallback):
  • rendering/style/SVGRenderStyle.h: Adapt to SVGLength API changes. (WebCore::SVGRenderStyle::initialBaselineShiftValue): (WebCore::SVGRenderStyle::initialKerning): (WebCore::SVGRenderStyle::initialStrokeDashOffset): (WebCore::SVGRenderStyle::initialStrokeWidth):
  • svg/SVGAngle.idl: Add StrictTypeChecking, RequiresAllArguments=Raise to all methods.
  • svg/SVGAnimatedBoolean.idl: Remove StrictTypeChecking from animVal, it's readonly so this is useless.
  • svg/SVGAnimatedEnumeration.idl: Add StrictTypeChecking to all attributes.
  • svg/SVGAnimatedInteger.idl: Ditto.
  • svg/SVGLength.cpp: Implement all missing features of SVGLength. Conform to our style guide (s/.0f etc) (WebCore::lengthTypeToString): (WebCore::SVGLength::SVGLength): (WebCore::SVGLength::value): Throw NOT_SUPPORTED_ERR when trying to obtain to relative units, when no context is given (SVGLength created by createSVGLength()). (WebCore::SVGLength::setValue): Ditto, for the setter. (WebCore::SVGLength::valueAsPercentage): Use m_valueInSpecifiedUnits instead of valueInSpecifiedUnits(). (WebCore::SVGLength::setValueAsString): Throw SYNTAX_ERR if parsing failed. (WebCore::SVGLength::valueAsString): Use makeString() instead of String and operator+. (WebCore::SVGLength::newValueSpecifiedUnits): Add ExceptionCode parameter, throw NOT_SUPPORTED_ERR, if the given unit type is invalid. (WebCore::SVGLength::convertToSpecifiedUnits): Ditto. (WebCore::SVGLength::determineViewport): Added helper function used by convertValue*Percentage*. (WebCore::SVGLength::convertValueFromUserUnitsToPercentage): Add new helper functions, used by value/setValue. (WebCore::SVGLength::convertValueFromPercentageToUserUnits): Ditto. (WebCore::SVGLength::convertValueFromUserUnitsToEMS): Ditto. (WebCore::SVGLength::convertValueFromEMSToUserUnits): Ditto. (WebCore::SVGLength::convertValueFromUserUnitsToEXS): Ditto. (WebCore::SVGLength::convertValueFromEXSToUserUnits): Ditto. (WebCore::SVGLength::fromCSSPrimitiveValue): Adapt to newValueSpecifiedUnits API change. (WebCore::SVGLength::toCSSPrimitiveValue): Remove default switch case.
  • svg/SVGLength.h: (WebCore::SVGLength::valueInSpecifiedUnits): Inlined. (WebCore::SVGLength::setValueInSpecifiedUnits): Ditto. (WebCore::SVGLength::isRelative):
  • svg/SVGLength.idl: Add StrictTypeChecking for all attributes/functions and RequiresAllArguments=Raise for all functions.
  • svg/SVGLengthList.cpp: Adapt to SVGLength API changes. (WebCore::SVGLengthList::parse):

2010-10-31 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Rob Buis.

Enable StrictTypeChecking for all types using SVG(Animated)PropertyTearOff
https://bugs.webkit.org/show_bug.cgi?id=48715

  • svg/dom/SVGAngle-expected.txt:
  • svg/dom/SVGAnimatedAngle-expected.txt: Added.
  • svg/dom/SVGAnimatedAngle.html: Added.
  • svg/dom/SVGAnimatedBoolean-expected.txt: Copied from LayoutTests/svg/dom/SVGExternalResourcesRequired-expected.txt.
  • svg/dom/SVGAnimatedBoolean.html: Copied from LayoutTests/svg/dom/SVGExternalResourcesRequired.html.
  • svg/dom/SVGAnimatedEnumeration-expected.txt: Added.
  • svg/dom/SVGAnimatedEnumeration.html: Added.
  • svg/dom/SVGAnimatedInteger-expected.txt: Added.
  • svg/dom/SVGAnimatedInteger.html: Added.
  • svg/dom/SVGAnimatedLength-expected.txt: Added.
  • svg/dom/SVGAnimatedLength.html: Added.
  • svg/dom/SVGAnimatedLengthList-expected.txt: Added.
  • svg/dom/SVGAnimatedLengthList.html: Added.
  • svg/dom/SVGAnimatedRect-expected.txt: Added.
  • svg/dom/SVGAnimatedRect.html: Added.
  • svg/dom/SVGExternalResourcesRequired-expected.txt: Removed.
  • svg/dom/SVGExternalResourcesRequired.html: Removed.
  • svg/dom/SVGLength-expected.txt: Added.
  • svg/dom/SVGLength-px-expected.txt: Added.
  • svg/dom/SVGLength-px-with-context-expected.txt: Added.
  • svg/dom/SVGLength-px-with-context.html: Added.
  • svg/dom/SVGLength-px.html: Added.
  • svg/dom/SVGLength.html: Added.
  • svg/dom/script-tests/SVGAngle.js:
  • svg/dom/script-tests/SVGAnimatedAngle.js: Added.
  • svg/dom/script-tests/SVGAnimatedBoolean.js: Copied from LayoutTests/svg/dom/script-tests/SVGExternalResourcesRequired.js.
  • svg/dom/script-tests/SVGAnimatedEnumeration.js: Added.
  • svg/dom/script-tests/SVGAnimatedInteger.js: Added.
  • svg/dom/script-tests/SVGAnimatedLength.js: Added.
  • svg/dom/script-tests/SVGAnimatedLengthList.js: Added.
  • svg/dom/script-tests/SVGAnimatedRect.js: Added.
  • svg/dom/script-tests/SVGExternalResourcesRequired.js: Removed.
  • svg/dom/script-tests/SVGLength-px-with-context.js: Added. Tests various operations on a SVGLength object obtained via rectElement.x.baseVal.
  • svg/dom/script-tests/SVGLength-px.js: Added. Tests various operations on a SVGLength object created via svgElement.createSVGLength().
  • svg/dom/script-tests/SVGLength.js: Added.
  • svg/dom/svg-length-units-expected.txt: Removed.
  • svg/dom/svg-length-units.html: Removed. Test is obsolete now, as SVGLength* covers this in detail.
  • svg/dynamic-updates/script-tests/SVGCircleElement-svgdom-cx-prop.js: (executeTest): Fixed StrictTypeChecking correctness, don't assign strings as SVGLength value.
  • svg/dynamic-updates/script-tests/SVGCircleElement-svgdom-cy-prop.js: (executeTest): Ditto.
  • svg/dynamic-updates/script-tests/SVGCircleElement-svgdom-r-prop.js: (executeTest): Ditto.
  • svg/dynamic-updates/script-tests/SVGEllipseElement-svgdom-cx-prop.js: (executeTest): Ditto.
  • svg/dynamic-updates/script-tests/SVGEllipseElement-svgdom-cy-prop.js: (executeTest): Ditto.
  • svg/dynamic-updates/script-tests/SVGEllipseElement-svgdom-rx-prop.js: (executeTest): Ditto.
  • svg/dynamic-updates/script-tests/SVGEllipseElement-svgdom-ry-prop.js: (executeTest): Ditto.
  • svg/dynamic-updates/script-tests/SVGForeignObjectElement-svgdom-height-prop.js: (executeTest): Ditto.
  • svg/dynamic-updates/script-tests/SVGForeignObjectElement-svgdom-width-prop.js: (executeTest): Ditto.
  • svg/dynamic-updates/script-tests/SVGForeignObjectElement-svgdom-x-prop.js: (executeTest): Ditto.
  • svg/dynamic-updates/script-tests/SVGForeignObjectElement-svgdom-y-prop.js: (executeTest): Ditto.
00:57 Changeset [71013] by rolandsteiner@chromium.org

2010-10-31 Roland Steiner <rolandsteiner@chromium.org>

Unreviewed: add failing SVG tests to Chromium test_expectations.txt.

WebKit roll 70949:71000 caused failures within 4 SVG tests on all platforms.
Bot and server outages make analysis difficult, thus adding to
Chromium test_expectations.txt for the time being.

  • platform/chromium/test_expectations.txt:
00:30 Changeset [71012] by pfeldman@chromium.org

2010-11-01 Pavel Feldman <pfeldman@chromium.org>

Not reviewed. Fixing test expectation for r71010.

  • inspector/console-log-syntax-error-expected.txt:
00:19 Changeset [71011] by commit-queue@webkit.org

2010-11-01 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r71002.
http://trac.webkit.org/changeset/71002
https://bugs.webkit.org/show_bug.cgi?id=48743

Makes Leopard and GTK bots red. (Requested by pfeldman on
#webkit).

  • platform/chromium-gpu/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/mac-leopard/Skipped:
  • platform/qt/Skipped:
00:07 Changeset [71010] by pfeldman@chromium.org

2010-10-31 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: unhide new network and resources panels.
https://bugs.webkit.org/show_bug.cgi?id=48725

  • English.lproj/localizedStrings.js:
  • inspector/InspectorController.h:
  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel):
  • inspector/front-end/Settings.js:
  • inspector/front-end/StoragePanel.js: (WebInspector.StoragePanel): (WebInspector.StoragePanel.prototype.reset): (WebInspector.StoragePanel.prototype.addResourceToFrame): (WebInspector.StoragePanel.prototype.addDocumentURL): (WebInspector.StoragePanel.prototype.showFileSystem): (WebInspector.FileSystemTreeElement): (WebInspector.FileSystemTreeElement.prototype.get itemURL): (WebInspector.FileSystemTreeElement.prototype.onselect):
  • inspector/front-end/inspector.js: (WebInspector.updateResource):
  • inspector/front-end/networkPanel.css: (#network-close-button): (.network.panel.viewing-resource #network-close-button):

2010-10-31 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: unhide new network and resources panels.
https://bugs.webkit.org/show_bug.cgi?id=48725

  • http/tests/inspector/console-xhr-logging-expected.txt:
  • http/tests/inspector/resource-parameters-expected.txt:
  • inspector/console-log-syntax-error-expected.txt:
  • inspector/elements-panel-styles-expected.txt:

2010-10-31 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: unhide new network and resources panels.
https://bugs.webkit.org/show_bug.cgi?id=48725

  • src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::setApuAgentEnabled):

10/31/10:

23:35 Changeset [71009] by morrita@google.com

2010-10-26 MORITA Hajime <morrita@google.com>

Reviewed by Kent Tamura.

Refactoring: Spellchecking related static functions could form a class
https://bugs.webkit.org/show_bug.cgi?id=48287

Extracted spellcheck related static functions to TextCheckingHelper class,
which has EditorClient and Range as its member.

No new tests. Just a refactoring.

  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • editing/EditingAllInOne.cpp
  • editing/Editor.cpp: (WebCore::Editor::advanceToNextMisspelling): (WebCore::Editor::isSelectionUngrammatical): (WebCore::Editor::guessesForUngrammaticalSelection): (WebCore::Editor::guessesForMisspelledOrUngrammaticalSelection): (WebCore::Editor::markMisspellingsAfterTypingToPosition): (WebCore::Editor::markMisspellingsOrBadGrammar): (WebCore::Editor::markMisspellings): (WebCore::Editor::markBadGrammar): (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): (WebCore::Editor::changeBackToReplacedString):
  • editing/Editor.h:
  • editing/TextCheckingHelper.cpp: Added. (WebCore::TextCheckingHelper::TextCheckingHelper): (WebCore::TextCheckingHelper::~TextCheckingHelper): (WebCore::TextCheckingHelper::paragraphAlignedRange): (WebCore::TextCheckingHelper::findFirstMisspelling): (WebCore::TextCheckingHelper::findFirstMisspellingOrBadGrammar): (WebCore::TextCheckingHelper::findFirstGrammarDetail): (WebCore::TextCheckingHelper::findFirstBadGrammar): (WebCore::TextCheckingHelper::isUngrammatical): (WebCore::TextCheckingHelper::guessesForMisspelledOrUngrammaticalRange): (WebCore::TextCheckingHelper::markAllMisspellings): (WebCore::TextCheckingHelper::markAllBadGrammar):
  • editing/TextCheckingHelper.h: Added.
21:21 Changeset [71008] by xan@webkit.org

2010-10-31 Xan Lopez <xlopez@igalia.com>

Try to fix the GTK+ build.

Do not use broken/deprecated functions that won't be available
with G_DISABLE_DEPRECATED (used in debug builds).

  • plugins/gtk/PluginPackageGtk.cpp: (WebCore::PluginPackage::fetchInfo):
19:54 Changeset [71007] by commit-queue@webkit.org

2010-10-31 Kenichi Ishibashi <bashi@google.com>

Reviewed by Adam Barth.

V8 binding for DOMSettableTokenList
https://bugs.webkit.org/show_bug.cgi?id=47812

Tests for this change will be included in the change for supporting
the <output> element.
See https://bugs.webkit.org/show_bug.cgi?id=29363.

  • bindings/v8/custom/V8DOMSettableTokenListCustom.cpp: Implemented. (WebCore::V8DOMSettableTokenList::indexedPropertyGetter): Just calls DOMSettableTokenList::item(index).
19:48 Changeset [71006] by robert@webkit.org

2010-10-31 Robert Hogan <robert@webkit.org>

Reviewed by Antonio Gomes.

[Qt] [Gtk] Plug-ins having upper case in mime type are failing to load

Qt and Gtk are case-sensitive when storing the declared mime-type
of plugins. Since plugin mime-types are lowercased prior to searching
for them in the plugin database, ensure they are loaded with the
mime-type in lower case too.

https://bugs.webkit.org/show_bug.cgi?id=36815

  • plugins/gtk/PluginPackageGtk.cpp: (WebCore::PluginPackage::fetchInfo):
  • plugins/qt/PluginPackageQt.cpp: (WebCore::PluginPackage::setMIMEDescription):

2010-10-31 Robert Hogan <robert@webkit.org>

Reviewed by Antonio Gomes.

[Qt] [Gtk] Plug-ins having upper case in mime type are failing to load

Qt and Gtk are case-sensitive when storing the declared mime-type
of plugins. Since plugin mime-types are lowercased prior to searching
for them in the plugin database, ensure they are loaded with the
mime-type in lower case too.

Change the test netscape plugin to declare its mimetype in sentence
case so that the correct behaviour is enforced.

https://bugs.webkit.org/show_bug.cgi?id=36815

  • DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: (NP_GetMIMEDescription):
19:37 Changeset [71005] by jeremy@chromium.org

2010-10-31 Jeremy Moskovich <jeremy@chromium.org>

Reviewed by Ojan Vafai.

https://bugs.webkit.org/show_bug.cgi?id=24118

Add layout test to make sure we don't regress truncation of an rtl block.

  • fast/block/basic/truncation-rtl.html: Added.
  • platform/mac/fast/block/basic/truncation-rtl-expected.checksum: Added.
  • platform/mac/fast/block/basic/truncation-rtl-expected.png: Added.
  • platform/mac/fast/block/basic/truncation-rtl-expected.txt: Added.
19:30 Changeset [71004] by robert@webkit.org

2010-10-31 Robert Hogan <robert@webkit.org>

Reviewed by Antonio Gomes.

[Qt] Support nodesFromRect in DRT

Unskip fast/dom/nodesFromRect-basic.html

https://bugs.webkit.org/show_bug.cgi?id=48716

  • platform/qt/Skipped:

2010-10-31 Robert Hogan <robert@webkit.org>

Reviewed by Antonio Gomes.

[Qt] Support nodesFromRect in DRT

Pass a Document object as a QWebElement.

https://bugs.webkit.org/show_bug.cgi?id=48716

  • bridge/qt/qt_runtime.cpp: (JSC::Bindings::convertValueToQVariant):

2010-10-31 Robert Hogan <robert@webkit.org>

Reviewed by Antonio Gomes.

[Qt] Support nodesFromRect in DRT

https://bugs.webkit.org/show_bug.cgi?id=48716

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::nodesFromRect):
  • WebCoreSupport/DumpRenderTreeSupportQt.h:

2010-10-31 Robert Hogan <robert@webkit.org>

Reviewed by Antonio Gomes.

[Qt] Support nodesFromRect in DRT

https://bugs.webkit.org/show_bug.cgi?id=48716

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::nodesFromRect):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
19:20 Changeset [71003] by yael.aharon@nokia.com

2010-10-31 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Antonio Gomes.

[GTK] Add bug ID for skipped <meter> tests
https://bugs.webkit.org/show_bug.cgi?id=48714

  • platform/gtk/Skipped:
19:17 Changeset [71002] by commit-queue@webkit.org

2010-10-31 Mike Lawther <mikelawther@chromium.org>

Reviewed by Andreas Kling.

unskip canvas/philip/tests/2d.imageData.get.source.negative on all ports
https://bugs.webkit.org/show_bug.cgi?id=48702

  • platform/chromium-gpu/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/mac-leopard/Skipped:
  • platform/qt/Skipped:
19:04 Changeset [71001] by commit-queue@webkit.org

2010-10-31 Peter Kasting <pkasting@google.com>

Reviewed by Adam Barth.

Treat GIFs with no loop count as "loop once".
https://bugs.webkit.org/show_bug.cgi?id=47302

  • fast/images/gif-loop-count-expected.checksum: Added.
  • fast/images/gif-loop-count-expected.png: Added.
  • fast/images/gif-loop-count-expected.txt: Added.
  • fast/images/gif-loop-count.html: Added.
  • fast/images/resources/gif-loop-count.gif: Added.
  • fast/images/resources/gif-loop-count.png: Added.

2010-10-31 Peter Kasting <pkasting@google.com>

Reviewed by Adam Barth.

Treat GIFs with no loop count as "loop once".
https://bugs.webkit.org/show_bug.cgi?id=47302

Test: fast/images/gif-loop-count.html

  • platform/image-decoders/gif/GIFImageDecoder.cpp: (WebCore::GIFImageDecoder::repetitionCount): (WebCore::GIFImageDecoder::gifComplete):
18:39 Changeset [71000] by noam.rosenthal@nokia.com

2010-10-31 No'am Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Andreas Kling.

[Texmap] [Qt] Texture mapper initial implementation
https://bugs.webkit.org/show_bug.cgi?id=47070

Build fix for X11.

No new tests; build fix.

  • plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::invalidateRect): (WebCore::PluginView::platformStart):
13:42 Changeset [70999] by andreas.kling@nokia.com

2010-10-31 Andreas Kling <kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Short-circuit QWebPage::selectedText() if frame has no selection
https://bugs.webkit.org/show_bug.cgi?id=48736

Do an early return if the selection is empty.

No new tests, this is covered by tst_QWebPage::findText().

  • Api/qwebpage.cpp: (QWebPage::selectedText):
13:33 Changeset [70998] by andreas.kling@nokia.com

2010-10-31 James Simonsen <simonjam@chromium.org>

Reviewed by Andreas Kling.

Rebaseline a fast/dynamic LayoutTest for Chromium Linux

fast/dynamic/positioned-movement-with-positioned-children.html exposes
a change to the defult button style on Linux.

Prior to bug 26030, buttons were always drawn as #dddddd, regardless of
what the style said. The default style had been #c0c0c0. With the fix,
buttons now honor the style sheet, but in order to maintain
consistency, the default style for Linux was changed to #dddddd.

This patch updates the test to reflect the newer Linux button style.

https://bugs.webkit.org/show_bug.cgi?id=48460

  • platform/chromium-linux/fast/dynamic/positioned-movement-with-positioned-children-expected.txt: Added.
  • platform/chromium/test_expectations.txt: Removed rebaselined test.
13:20 Changeset [70997] by darin@apple.com

2010-10-31 Darin Adler <darin@apple.com>

Reviewed by Dan Bernstein.

Visited links not populated correctly in new web processes after the first
https://bugs.webkit.org/show_bug.cgi?id=48735
rdar://problem/8442177

  • UIProcess/VisitedLinkProvider.cpp: (WebKit::VisitedLinkProvider::VisitedLinkProvider): Initialize m_webProcessHasVisitedLinkState. (WebKit::VisitedLinkProvider::processDidFinishLaunching): Renamed from populateVisitedLinksIfNeeded. Set m_webProcessHasVisitedLinkState to false, since this is a new process, and also start the timer so the visited links messages will be sent. (WebKit::VisitedLinkProvider::processDidClose): Renamed from stopVisitedLinksTimer. (WebKit::VisitedLinkProvider::pendingVisitedLinksTimerFired): Added logic so we send SetVisitedLinkTable and AllVisitedLinkStateChanged once to each new process and to set m_webProcessHasVisitedLinkState to true once that is done.
  • UIProcess/VisitedLinkProvider.h: Updated for above changes.
  • UIProcess/WebContext.cpp: (WebKit::WebContext::processDidFinishLaunching): Called VisitedLinkProvider function under its new name. Also used ASSERT_UNUSED rather than ASSERT since the argument is used only for the assertion. (WebKit::WebContext::processDidClose): Ditto.
12:32 Changeset [70996] by andreas.kling@nokia.com

2010-10-31 Andreas Kling <kling@webkit.org>

Reviewed by Dirk Schulze.

Remove the unused GraphicsContext::clipOutEllipseInRect(IntRect)
https://bugs.webkit.org/show_bug.cgi?id=48727

This function was added in <http://trac.webkit.org/changeset/18654> for CSS3 box-shadows.
All use of the function was removed in <http://trac.webkit.org/changeset/21601>

  • platform/graphics/GraphicsContext.h:
  • platform/graphics/cairo/GraphicsContextCairo.cpp:
  • platform/graphics/cg/GraphicsContextCG.cpp:
  • platform/graphics/haiku/GraphicsContextHaiku.cpp: (WebCore::GraphicsContext::clipOut):
  • platform/graphics/openvg/GraphicsContextOpenVG.cpp:
  • platform/graphics/qt/GraphicsContextQt.cpp:
  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::clipOut):
  • platform/graphics/wince/GraphicsContextWinCE.cpp:
  • platform/graphics/wx/GraphicsContextWx.cpp:
12:30 Changeset [70995] by andreas.kling@nokia.com

2010-10-31 Andreas Kling <kling@webkit.org>

Reviewed by Dirk Schulze.

[Qt] Respect the "antialiased" argument in clipConvexPolygon()
https://bugs.webkit.org/show_bug.cgi?id=48734

Set (or unset) the QPainter::Antialiased render hint for antialiased
clipping based on the "antialiased" argument.

No test since Qt doesn't have pixel tests yet.

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::clipConvexPolygon):
12:02 Changeset [70994] by andreas.kling@nokia.com

2010-10-31 Andreas Kling <kling@webkit.org>

Reviewed by Dirk Schulze.

Remove the unused GraphicsContext::strokeRect(FloatRect)
https://bugs.webkit.org/show_bug.cgi?id=48726

This function was only implemented by GraphicsContextOpenVG and not
called from anywhere.

  • platform/graphics/GraphicsContext.h:
  • platform/graphics/openvg/GraphicsContextOpenVG.cpp:
11:59 Changeset [70993] by andreas.kling@nokia.com

2010-10-31 Andreas Kling <kling@webkit.org>

Reviewed by Dirk Schulze.

Remove the unused GraphicsContext::origin()
https://bugs.webkit.org/show_bug.cgi?id=48732

This method was not called from anywhere.

  • platform/graphics/GraphicsContext.h:
  • platform/graphics/cairo/GraphicsContextCairo.cpp:
  • platform/graphics/haiku/GraphicsContextHaiku.cpp:
  • platform/graphics/openvg/GraphicsContextOpenVG.cpp:
  • platform/graphics/qt/GraphicsContextQt.cpp:
  • platform/graphics/wince/GraphicsContextWinCE.cpp:
11:57 Changeset [70992] by andreas.kling@nokia.com

2010-10-31 Andreas Kling <kling@webkit.org>

Reviewed by Dirk Schulze.

[Qt] Remove GraphicsContext::pen()
https://bugs.webkit.org/show_bug.cgi?id=48733

Have PathQt obtain the pen() through the platformContext() instead.

  • platform/graphics/GraphicsContext.h:
  • platform/graphics/qt/GraphicsContextQt.cpp:
  • platform/graphics/qt/PathQt.cpp: (WebCore::Path::strokeContains): (WebCore::Path::strokeBoundingRect):
10:33 Changeset [70991] by ossy@webkit.org

2010-10-31 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r70959.
http://trac.webkit.org/changeset/70959
https://bugs.webkit.org/show_bug.cgi?id=48731

It broke fast/events/spatial-navigation tests (Requested by
Ossy on #webkit).

  • WebCore.xcodeproj/project.pbxproj:
  • rendering/InlineBox.cpp: (WebCore::InlineBox::adjustForFlippedBlocksWritingMode):
  • rendering/InlineFlowBox.h: (WebCore::InlineFlowBox::bottomLayoutOverflow): (WebCore::InlineFlowBox::rightLayoutOverflow): (WebCore::InlineFlowBox::bottomVisualOverflow): (WebCore::InlineFlowBox::rightVisualOverflow):
  • rendering/RenderBox.cpp:
  • rendering/RenderBox.h:
  • rendering/RenderInline.cpp: (WebCore::RenderInline::linesBoundingBox): (WebCore::RenderInline::linesVisibleOverflowBoundingBox): (WebCore::RenderInline::clippedOverflowRectForRepaint):
  • rendering/RenderText.cpp: (WebCore::RenderText::linesBoundingBox):

2010-10-31 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r70959.
http://trac.webkit.org/changeset/70959
https://bugs.webkit.org/show_bug.cgi?id=48731

It broke fast/events/spatial-navigation tests (Requested by
Ossy on #webkit).

  • fast/repaint/inline-vertical-rl-overflow.html: Removed.
  • platform/mac/fast/blockflow/background-vertical-lr-expected.txt:
  • platform/mac/fast/blockflow/background-vertical-rl-expected.txt:
  • platform/mac/fast/blockflow/basic-vertical-line-expected.txt:
  • platform/mac/fast/blockflow/border-image-vertical-lr-expected.txt:
  • platform/mac/fast/blockflow/border-image-vertical-rl-expected.txt:
  • platform/mac/fast/blockflow/border-radius-clipping-vertical-lr-expected.txt:
  • platform/mac/fast/blockflow/border-vertical-lr-expected.checksum:
  • platform/mac/fast/blockflow/border-vertical-lr-expected.png:
  • platform/mac/fast/blockflow/border-vertical-lr-expected.txt:
  • platform/mac/fast/blockflow/box-shadow-vertical-lr-expected.txt:
  • platform/mac/fast/blockflow/box-shadow-vertical-rl-expected.txt:
  • platform/mac/fast/blockflow/english-lr-text-expected.txt:
  • platform/mac/fast/blockflow/english-rl-text-expected.txt:
  • platform/mac/fast/blockflow/japanese-lr-text-expected.txt:
  • platform/mac/fast/blockflow/japanese-rl-text-expected.txt:
  • platform/mac/fast/repaint/inline-vertical-rl-overflow-expected.checksum: Removed.
  • platform/mac/fast/repaint/inline-vertical-rl-overflow-expected.png: Removed.
  • platform/mac/fast/repaint/inline-vertical-rl-overflow-expected.txt: Removed.
  • platform/mac/fast/text/international/vertical-text-glyph-test-expected.txt:
09:04 Changeset [70990] by zimmermann@webkit.org

2010-10-31 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed.

Convert SVGAnimatedNumber/SVGAnimatedNumberList to the new SVGAnimatedPropertyTearOff concept
https://bugs.webkit.org/show_bug.cgi?id=48686

Forgot to land SVGAnimatedNumber.js, fails on all bots. Thanks Darin for noticing.

  • svg/dom/script-tests/SVGAnimatedNumber.js: Added.

10/30/10:

23:43 Changeset [70989] by pfeldman@chromium.org

2010-10-30 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: new resources and network panel usability improvements.
https://bugs.webkit.org/show_bug.cgi?id=48680

By default, navigation clears network log, added 'preserve log' button,
that prevents log from being cleared.

Storing expanded state of all group items, restoring last selected item,
fall back to main frame's main resource by default.
Do not list XHRs and redirects in resources.

  • English.lproj/localizedStrings.js:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::didLoadResourceFromMemoryCache): (WebCore::InspectorController::identifierForInitialRequest):
  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype.get statusBarItems): (WebInspector.NetworkPanel.prototype._positionSummaryBar): (WebInspector.NetworkPanel.prototype._updateFilter): (WebInspector.NetworkPanel.prototype._createStatusbarButtons): (WebInspector.NetworkPanel.prototype._onPreserveLogClicked): (WebInspector.NetworkPanel.prototype.reset): (WebInspector.NetworkPanel.prototype.refreshResource):
  • inspector/front-end/ResourceManager.js: (WebInspector.ResourceManager.prototype.identifierForInitialRequest): (WebInspector.ResourceManager.prototype.willSendRequest): (WebInspector.ResourceManager.prototype.didLoadResourceFromMemoryCache): (WebInspector.ResourceManager.prototype.setOverrideContent): (WebInspector.ResourceManager.prototype.didCreateWebSocket):
  • inspector/front-end/StoragePanel.js: (WebInspector.StoragePanel): (WebInspector.StoragePanel.prototype.show): (WebInspector.StoragePanel.prototype._initDefaultSelection): (WebInspector.StoragePanel.prototype.reset): (WebInspector.StoragePanel.prototype.addResourceToFrame): (WebInspector.StoragePanel.prototype.refreshResource): (WebInspector.StoragePanel.prototype.showDatabase): (WebInspector.BaseStorageTreeElement.prototype.onselect): (WebInspector.StorageCategoryTreeElement): (WebInspector.StorageCategoryTreeElement.prototype.get itemURL): (WebInspector.StorageCategoryTreeElement.prototype.onselect): (WebInspector.StorageCategoryTreeElement.prototype.onattach): (WebInspector.StorageCategoryTreeElement.prototype.onexpand): (WebInspector.StorageCategoryTreeElement.prototype.oncollapse): (WebInspector.FrameTreeElement.prototype.get itemURL): (WebInspector.FrameTreeElement.prototype.onselect): (WebInspector.FrameResourceTreeElement.prototype.get itemURL): (WebInspector.FrameResourceTreeElement.prototype.onselect): (WebInspector.DatabaseTreeElement.prototype.get itemURL): (WebInspector.DatabaseTreeElement.prototype.onselect): (WebInspector.DatabaseTableTreeElement.prototype.get itemURL): (WebInspector.DatabaseTableTreeElement.prototype.onselect): (WebInspector.DOMStorageTreeElement.prototype.get itemURL): (WebInspector.DOMStorageTreeElement.prototype.onselect): (WebInspector.CookieTreeElement.prototype.get itemURL): (WebInspector.CookieTreeElement.prototype.onselect): (WebInspector.ApplicationCacheTreeElement.prototype.get itemURL): (WebInspector.ApplicationCacheTreeElement.prototype.onselect):
16:08 Changeset [70988] by tonikitoo@webkit.org

2010-10-30 Antonio Gomes <agomes@rim.com>

Unreviewed Windows bots build fix (take I).

Touching WebKit.idl to try forcing a clean build.

  • Interfaces/WebKit.idl:
14:00 Changeset [70987] by wsiegrist@apple.com

William Siegrist <wsiegrist@apple.com>

Change trigger name to match builder name change in r70871.

12:31 Changeset [70986] by paroga@webkit.org

2010-10-30 Patrick Gansterer <paroga@webkit.org>

Unreviewed, build fix after r70846.

  • platform/graphics/wince/ImageWinCE.cpp: (WebCore::RGBA32Buffer::asNewNativeImage):

2010-10-30 Patrick Gansterer <paroga@webkit.org>

Unreviewed, build fix after r70574.

  • WebCoreSupport/FrameLoaderClientWinCE.cpp: (WebKit::FrameLoaderClientWinCE::transferLoadingResourceFromPage):
11:48 Changeset [70985] by dglazkov@chromium.org

2010-10-30 Dimitri Glazkov <dglazkov@chromium.org>

Unreviewed, rolling out r70984.
http://trac.webkit.org/changeset/70984
https://bugs.webkit.org/show_bug.cgi?id=46015

Made media/audio-delete-while-slider-thumb-clicked.html crash.

  • fast/events/shadow-boundary-crossing.html:

2010-10-30 Dimitri Glazkov <dglazkov@chromium.org>

Unreviewed, rolling out r70984.
http://trac.webkit.org/changeset/70984
https://bugs.webkit.org/show_bug.cgi?id=46015

Made media/audio-delete-while-slider-thumb-clicked.html crash.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/ContainerNode.cpp: (WebCore::notifyChildInserted):
  • dom/EventContext.cpp: Removed.
  • dom/EventContext.h: Removed.
  • dom/Node.cpp: (WebCore::Node::markAncestorsWithChildNeedsStyleRecalc): (WebCore::Node::createRendererIfNeeded): (WebCore::Node::eventParentNode): (WebCore::Node::enclosingLinkEventParentOrSelf): (WebCore::eventTargetAsSVGElementInstance): (WebCore::eventTargetRespectingSVGTargetRules): (WebCore::Node::eventAncestors): (WebCore::Node::dispatchGenericEvent):
  • dom/Node.h:
  • dom/Text.cpp: (WebCore::Text::createRenderer):
  • dom/WindowEventContext.cpp: Removed.
  • dom/WindowEventContext.h: Removed.
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::getEventListenersForNode):
  • inspector/InspectorInstrumentation.cpp: (WebCore::eventHasListeners): (WebCore::InspectorInstrumentation::willDispatchEventImpl):
  • inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::willDispatchEvent):
  • page/EventHandler.cpp: (WebCore::EventHandler::updateMouseEventTargetNode):
  • svg/SVGElement.cpp: (WebCore::SVGElement::eventParentNode):
  • svg/SVGElement.h:
10:32 Changeset [70984] by dglazkov@chromium.org

2010-10-30 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Darin Adler.

Implement shadow DOM-aware event targeting and introduce EventContext to track the context of each event dispatch.
https://bugs.webkit.org/show_bug.cgi?id=46015

Tuned the test to better reflect its point: the event should indeed fire (it used to be swallowed),
but its target should be a non-shadow node.

  • fast/events/shadow-boundary-crossing.html: Modified the test.

2010-10-30 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Darin Adler.

Implement shadow DOM-aware event targeting and introduce EventContext to track the context of each event dispatch.
https://bugs.webkit.org/show_bug.cgi?id=46015

This patch adds the notion of EventContext (and a very similar-acting WindowEventContext, specifically
for DOMWindow), an abstraction that carries information around dispatching an event for any given Node.

This abstraction is necessary to ensure that events, fired from shadow DOM nodes are properly retargeted to
appear as if they are coming from their host, thus never exposing the shadow DOM nodes to the world outside.

  • Android.mk: Added EventContext, WindowEventContext files.
  • CMakeLists.txt: Ditto.
  • GNUmakefile.am: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • dom/ContainerNode.cpp: (WebCore::notifyChildInserted): Changed to be shadow DOM-aware.
  • dom/EventContext.cpp: Added.
  • dom/EventContext.h: Added.
  • dom/Node.cpp: (WebCore::Node::markAncestorsWithChildNeedsStyleRecalc): Changed to be shadow DOM-aware. (WebCore::Node::createRendererIfNeeded): Ditto. (WebCore::Node::parentOrHostNode): Added new helper method. (WebCore::Node::enclosingLinkEventParentOrSelf): Changed to be shadow DOM-aware. (WebCore::eventTargetRespectingSVGTargetRules): Collapsed two helper methods into one. (WebCore::Node::eventAncestors): Refactored to collect a vector of EventContexts. (WebCore::Node::topEventContext): Added. (WebCore::eventHasListeners): Changed to use EventContexts. (WebCore::Node::dispatchGenericEvent): Ditto.
  • dom/Node.h: Removed eventParentNode that's no longer needed, added parentOrHostNode decl,

and changed signature of eventAncestors to use EventContexts.

  • dom/Text.cpp: (WebCore::Text::createRenderer): Changed to be shadow DOM-aware.
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::getEventListenersForNode): Changed to use EventContexts.
  • page/EventHandler.cpp: (WebCore::EventHandler::updateMouseEventTargetNode): Removed code that's no longer necessary.
  • svg/SVGElement.cpp: Removed eventParentNode that's no longer needed.
  • svg/SVGElement.h: Ditto.
  • dom/WindowEventContext.cpp: Added.
  • dom/WindowEventContext.h: Added.
08:17 Changeset [70983] by xan@webkit.org

2010-10-30 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Use new width for height APIs in GTK+ 3.x
https://bugs.webkit.org/show_bug.cgi?id=48709

Use the new width for height APIs in GTK+ 3.x, since size-request
is deprecated.

For now we just return the same value for preferred and minimum
width/height, which should match the 2.x behavior. Probably we
could do something smarter for the minimum values.

  • webkit/webkitwebview.cpp: (webkit_web_view_get_preferred_width): return our preferred width. (webkit_web_view_get_preferred_height): return our preferred height. (webkit_web_view_class_init): hook the new default handlers.
07:51 Changeset [70982] by andreas.kling@nokia.com

2010-10-30 Andreas Kling <kling@webkit.org>

Reviewed by Antonio Gomes.

[Qt] IM: Don't manipulate selection via RenderTextControl
https://bugs.webkit.org/show_bug.cgi?id=48700

Go directly through the Frame's SelectionController instead.

No new tests, this is covered by tst_QWebPage::inputMethods.

  • Api/qwebpage.cpp: (QWebPagePrivate::inputMethodEvent): (QWebPage::inputMethodQuery):
07:49 Changeset [70981] by andreas.kling@nokia.com

2010-10-30 Andreas Kling <kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt][WK2] Crash in drawUpdateChunkIntoBackingStore
https://bugs.webkit.org/show_bug.cgi?id=48707

UpdateChunk images have to be created using the QImage constructor
that takes a bytesPerLine (stride) value, or the data length won't
match UpdateChunk::size().

  • Shared/qt/UpdateChunk.cpp: (WebKit::UpdateChunk::createImage):
07:48 Changeset [70980] by andreas.kling@nokia.com

2010-10-30 Andreas Kling <kling@webkit.org>

Reviewed by Antonio Gomes.

[Qt] QtTestBrowser: Switching view type moves the embedded inspector
https://bugs.webkit.org/show_bug.cgi?id=48705

Reinsert the embedded inspector into the splitter after changing
between QWebView/QGraphicsWebView.

  • QtTestBrowser/launcherwindow.cpp: (LauncherWindow::init): (LauncherWindow::initializeView):
  • QtTestBrowser/webinspector.h: (WebInspector::WebInspector):
06:23 Changeset [70979] by zimmermann@webkit.org

2010-10-30 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Rob Buis.

Convert SVGAnimatedNumber/SVGAnimatedNumberList to the new SVGAnimatedPropertyTearOff concept
https://bugs.webkit.org/show_bug.cgi?id=48686

Convert the next set of primitives to use the new SVG(Animated)PropertyTearOff concept.

Tests: svg/dom/SVGAnimatedNumber.html

svg/dom/SVGAnimatedNumberList.html
svg/dom/SVGNumber.html

  • GNUmakefile.am: Add SVGAnimatedNumber.h / SVGAnimatedNumberList.h to build.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • bindings/scripts/CodeGenerator.pm: Recognize SVGAnimatedNumber/SVGAnimatedNumberList as new style SVG animated properties. Remove SVGNumber from PODType hash.
  • bindings/scripts/CodeGeneratorJS.pm: Remove special SVGNumber handing, it's obsolete now.
  • bindings/scripts/CodeGeneratorObjC.pm: Add special SVGNumber handling, as it's the first of the converted dynamic SVGAnimatedProperty types that's not in WebCore namespace.
  • bindings/scripts/CodeGeneratorV8.pm: Use AvoidInclusionOfType method from CodeGenerator.pm, remove special SVGNumber handling, that's obsolete now.
  • rendering/svg/SVGTextLayoutAttributesBuilder.cpp: (WebCore::extractFloatValuesFromSVGNumberList): Adapt to SVGNumberList change, which is a plain Vector<float> now.
  • svg/DeprecatedSVGAnimatedPropertyTraits.h: Remove SVGAnimatedNumber/SVGAnimatedNumberList handling.
  • svg/DeprecatedSVGAnimatedTemplate.h: Ditto.
  • svg/SVGAnimatedNumber.h: Added.
  • svg/SVGAnimatedNumber.idl: Enable StrictTypeChecking.
  • svg/SVGAnimatedNumberList.h: Added.
  • svg/SVGAnimatedNumberList.idl: Ditto.
  • svg/SVGComponentTransferFunctionElement.cpp: Switch animated float properties to the new SVGAnimatedNumber(List). (WebCore::SVGComponentTransferFunctionElement::SVGComponentTransferFunctionElement): (WebCore::SVGComponentTransferFunctionElement::parseMappedAttribute): (WebCore::SVGComponentTransferFunctionElement::transferFunction):
  • svg/SVGComponentTransferFunctionElement.h:
  • svg/SVGFEColorMatrixElement.cpp: Ditto. (WebCore::SVGFEColorMatrixElement::SVGFEColorMatrixElement): (WebCore::SVGFEColorMatrixElement::parseMappedAttribute): (WebCore::SVGFEColorMatrixElement::build):
  • svg/SVGFEColorMatrixElement.h:
  • svg/SVGFECompositeElement.h: Ditto.
  • svg/SVGFEConvolveMatrixElement.cpp: Ditto. (WebCore::SVGFEConvolveMatrixElement::SVGFEConvolveMatrixElement): (WebCore::SVGFEConvolveMatrixElement::kernelUnitLengthXIdentifier): Added, replacing char[] hack by a static atomic string. (WebCore::SVGFEConvolveMatrixElement::kernelUnitLengthYIdentifier): Ditto. (WebCore::SVGFEConvolveMatrixElement::parseMappedAttribute): (WebCore::SVGFEConvolveMatrixElement::build):
  • svg/SVGFEConvolveMatrixElement.h: Switch animated float properties to the new SVGAnimatedNumber(List).
  • svg/SVGFEDiffuseLightingElement.cpp: Ditto. (WebCore::SVGFEDiffuseLightingElement::kernelUnitLengthXIdentifier): Remove trailing whitespace. (WebCore::SVGFEDiffuseLightingElement::kernelUnitLengthYIdentifier): Ditto.
  • svg/SVGFEDiffuseLightingElement.h: Switch animated float properties to the new SVGAnimatedNumber(List).
  • svg/SVGFEDisplacementMapElement.h: Ditto.
  • svg/SVGFEGaussianBlurElement.cpp: Ditto. (WebCore::SVGFEGaussianBlurElement::stdDeviationXIdentifier): Remove trailing whitespace. (WebCore::SVGFEGaussianBlurElement::stdDeviationYIdentifier): Ditto.
  • svg/SVGFEGaussianBlurElement.h: Switch animated float properties to the new SVGAnimatedNumber(List).
  • svg/SVGFELightElement.h: Ditto.
  • svg/SVGFEMorphologyElement.cpp: (WebCore::SVGFEMorphologyElement::radiusXIdentifier): Added, replacing char[] hack by a static atomic string. (WebCore::SVGFEMorphologyElement::radiusYIdentifier): Ditto.
  • svg/SVGFEMorphologyElement.h: Switch animated float properties to the new SVGAnimatedNumber(List).
  • svg/SVGFEOffsetElement.h: Ditto.
  • svg/SVGFESpecularLightingElement.cpp: (WebCore::SVGFESpecularLightingElement::kernelUnitLengthXIdentifier): Remove trailing whitespace. (WebCore::SVGFESpecularLightingElement::kernelUnitLengthYIdentifier): Ditto.
  • svg/SVGFESpecularLightingElement.h: Switch animated float properties to the new SVGAnimatedNumber(List).
  • svg/SVGFETurbulenceElement.cpp: (WebCore::SVGFETurbulenceElement::baseFrequencyXIdentifier): Remove trailing whitespace. (WebCore::SVGFETurbulenceElement::baseFrequencyYIdentifier): Ditto.
  • svg/SVGFETurbulenceElement.h: Switch animated float properties to the new SVGAnimatedNumber(List).
  • svg/SVGFilterElement.cpp: (WebCore::SVGFilterElement::filterResXIdentifier): Remove trailing whitespace. (WebCore::SVGFilterElement::filterResYIdentifier): Ditto.
  • svg/SVGLengthList.idl: Remove leftover [SVGListProperty] marker.
  • svg/SVGMarkerElement.cpp: (WebCore::SVGMarkerElement::orientTypeIdentifier): Remove trailing whitespace. (WebCore::SVGMarkerElement::orientAngleIdentifier): Ditto.
  • svg/SVGNumber.idl: Remove [PODType] marker, add StrictTypeChecking.
  • svg/SVGNumberList.cpp: Convert from SVGPODList<RefPtr<SVGPODListItem<float> > > to plain Vector<float>, just like it has been done for SVGLengthList before. (WebCore::SVGNumberList::parse): (WebCore::SVGNumberList::valueAsString):
  • svg/SVGNumberList.h: (WebCore::SVGNumberList::SVGNumberList):
  • svg/SVGPathElement.h: Switch animated float properties to the new SVGAnimatedNumber(List).
  • svg/SVGStopElement.h: Ditto.
  • svg/SVGTextPositioningElement.cpp: Switch animated float properties to the new SVGAnimatedNumber(List). (WebCore::SVGTextPositioningElement::SVGTextPositioningElement): (WebCore::SVGTextPositioningElement::parseMappedAttribute):
  • svg/SVGTextPositioningElement.h: Ditto.
  • svg/properties/SVGPropertyTraits.h: Add SVGNumberList handling.

2010-10-30 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Rob Buis.

Convert SVGAnimatedNumber/SVGAnimatedNumberList to the new SVGAnimatedPropertyTearOff concept
https://bugs.webkit.org/show_bug.cgi?id=48686

Fix invalid tests in svg/dynamic-updates, that relied on a bug in our SVGNumberList implementation. If an item was already
inserted in a list, and we tried to insert it somewhere else, we didn't remove it from the old list. Now that SVGNumberList
has been switched to SVGAnimatedListPropertyTearOff, the bug is fixed, and it behaves exactly like SVGLengthList.

Side effect: svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop.html now works as expected (dynamic update is executed)

  • platform/mac-leopard/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop-expected.checksum:
  • platform/mac-leopard/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop-expected.png:
  • svg/dom/SVGAnimatedNumber-expected.txt: Added.
  • svg/dom/SVGAnimatedNumber.html: Added.
  • svg/dom/SVGAnimatedNumberList-expected.txt: Added.
  • svg/dom/SVGAnimatedNumberList.html: Added.
  • svg/dom/SVGNumber-expected.txt: Added.
  • svg/dom/SVGNumber.html: Added.
  • svg/dom/script-tests/SVGAnimatedNumber.js: Added.
  • svg/dom/script-tests/SVGAnimatedNumberList.js: Added.
  • svg/dom/script-tests/SVGNumber.js: Added.
  • svg/dynamic-updates/script-tests/SVGFEColorMatrixElement-svgdom-type-prop.js: Test now works in Firefox as well. (executeTest): SVGNumber.value only accepts numbers, not strings, now that StrictTypeChecking is enabled.
  • svg/dynamic-updates/script-tests/SVGFEColorMatrixElement-svgdom-values-prop.js: Test now works in Firefox as well. (executeTest): Don't call appendItem several times with the same SVGNumber, it will be removed if it was already inserted in a list.
  • svg/dynamic-updates/script-tests/SVGFETurbulenceElement-svgdom-baseFrequency-prop.js:
01:59 Changeset [70978] by zimmermann@webkit.org

2010-10-30 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed.

Update SVGFEFloodElement mac-leopard baseline, which was forgotten.

  • platform/mac-leopard/svg/dynamic-updates/SVGFEFloodElement-dom-flood-opacity-attr-expected.checksum:
  • platform/mac-leopard/svg/dynamic-updates/SVGFEFloodElement-dom-flood-opacity-attr-expected.png:
  • platform/mac-leopard/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-opacity-prop-expected.checksum:
  • platform/mac-leopard/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-opacity-prop-expected.png:

10/29/10:

23:15 Changeset [70977] by abarth@webkit.org

Merge 70718 - 2010-10-27 Adam Barth <abarth@webkit.org>

Reviewed by Ojan Vafai.

REGRESSION(66511): CORDYS Process Factory doesn't work
https://bugs.webkit.org/show_bug.cgi?id=48453

Test some appendChild cases that didn't have coverage before.

  • fast/dom/allowed-children-expected.txt: Added.
  • fast/dom/allowed-children.html: Added.

2010-10-27 Adam Barth <abarth@webkit.org>

Reviewed by Ojan Vafai.

REGRESSION(66511): CORDYS Process Factory doesn't work
https://bugs.webkit.org/show_bug.cgi?id=48453

When Ojan refactored this function in 66511, he missed an "else",
which causes us to generated HIERARCHY_REQUEST_ERR in some cases where
we're not supposed to. This patch restores the "else" behavior (using
an early return) and adds a test for the cases that caused problems in
the field.

Test: fast/dom/allowed-children.html

  • dom/Node.cpp: (WebCore::isChildTypeAllowed):

TBR=abarth@webkit.org

23:13 Changeset [70976] by dbates@webkit.org

2010-10-29 Daniel Bates <dbates@rim.com>

No review, rolling out 70971.
http://trac.webkit.org/changeset/70971
https://bugs.webkit.org/show_bug.cgi?id=6751

Rolling out changeset 70971 <http://trac.webkit.org/changeset/70971> since
it caused layout tests regressions on all bots. In particular, the
child count in a generated frame name differs after this patch. We need
to look into this further.

  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::name):

2010-10-29 Daniel Bates <dbates@rim.com>

No review, rolling out 70971.
http://trac.webkit.org/changeset/70971
https://bugs.webkit.org/show_bug.cgi?id=6751

Rolling out changeset 70971 <http://trac.webkit.org/changeset/70971> since
it caused layout tests regressions on all bots. In particular, the
child count in a generated frame name differs after this patch. We need
to look into this further.

  • Api/qwebframe.cpp: (QWebFrame::frameName):

2010-10-29 Daniel Bates <dbates@rim.com>

No review, rolling out 70971.
http://trac.webkit.org/changeset/70971
https://bugs.webkit.org/show_bug.cgi?id=6751

Rolling out changeset 70971 <http://trac.webkit.org/changeset/70971> since
it caused layout tests regressions on all bots. In particular, the
child count in a generated frame name differs after this patch. We need
to look into this further.

  • webkit/webkitwebframe.cpp: (webkit_web_frame_get_name):

2010-10-29 Daniel Bates <dbates@rim.com>

No review, rolling out 70971.
http://trac.webkit.org/changeset/70971
https://bugs.webkit.org/show_bug.cgi?id=6751

Rolling out changeset 70971 <http://trac.webkit.org/changeset/70971> since
it caused layout test failures on all bots. In particular, the
child count in a generated frame name differs after this patch. We need
to look into this further.

  • WebFrame.cpp: (WebFrame::name):

2010-10-29 Daniel Bates <dbates@rim.com>

No review, rolling out 70971.
http://trac.webkit.org/changeset/70971
https://bugs.webkit.org/show_bug.cgi?id=6751

Rolling out changeset 70971 <http://trac.webkit.org/changeset/70971> since
it caused layout test failures on all bots. In particular, the
child count in a generated frame name differs after this patch. We need
to look into this further.

  • WebView/WebFrame.mm: (-[WebFrame name]):

2010-10-29 Daniel Bates <dbates@rim.com>

No review, rolling out 70971.
http://trac.webkit.org/changeset/70971
https://bugs.webkit.org/show_bug.cgi?id=6751

Rolling out changeset 70971 <http://trac.webkit.org/changeset/70971> since
it caused layout test failures on all bots. In particular, the
child count in a generated frame name differs after this patch. We need
to look into this further.

  • ewk/ewk_frame.cpp: (ewk_frame_name_get):

2010-10-29 Daniel Bates <dbates@rim.com>

No review, rolling out 70971.
http://trac.webkit.org/changeset/70971
https://bugs.webkit.org/show_bug.cgi?id=6751

Rolling out changeset 70971 <http://trac.webkit.org/changeset/70971> since
it caused layout test failures on all bots. In particular, the
child count in a generated frame name differs after this patch. We need
to look into this further.

Test: fast/frames/iframe-set-inner-html.html

  • html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::openURL): (WebCore::HTMLFrameElementBase::setName):
  • html/HTMLFrameElementBase.h:
  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::mainResource):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::loadURLIntoChildFrame): (WebCore::FrameLoader::commitProvisionalLoad):
  • loader/HistoryController.cpp: (WebCore::HistoryController::saveDocumentState): (WebCore::HistoryController::restoreDocumentState): (WebCore::HistoryController::createItem): (WebCore::HistoryController::currentFramesMatchItem):
  • loader/ProgressTracker.cpp: (WebCore::ProgressTracker::progressStarted): (WebCore::ProgressTracker::progressCompleted):
  • loader/archive/cf/LegacyWebArchive.cpp: (WebCore::LegacyWebArchive::create):
  • page/FrameTree.cpp: (WebCore::FrameTree::setName): (WebCore::FrameTree::clearName): (WebCore::FrameTree::uniqueChildName): (WebCore::FrameTree::child): (WebCore::FrameTree::find):
  • page/FrameTree.h: (WebCore::FrameTree::name):

2010-10-29 Daniel Bates <dbates@rim.com>

No review, rolling out 70971.
http://trac.webkit.org/changeset/70971
https://bugs.webkit.org/show_bug.cgi?id=6751

Rolling out changeset 70971 <http://trac.webkit.org/changeset/70971> since
it caused layout test failures on all bots. In particular, the
child count in a generated frame name differs after this patch. We need
to look into this further.

  • fast/frames/frame-element-name-expected.txt:
  • fast/frames/iframe-set-inner-html-expected.txt: Copied from LayoutTests/fast/frames/iframe-set-inner-html-expected.txt.
  • fast/frames/iframe-set-inner-html.html: Copied from LayoutTests/fast/frames/iframe-set-inner-html.html.
  • fast/frames/resources/frame-element-name-left.html:
  • fast/frames/resources/frame-element-name-right.html:

2010-10-29 Daniel Bates <dbates@rim.com>

No review, rolling out 70971.
http://trac.webkit.org/changeset/70971
https://bugs.webkit.org/show_bug.cgi?id=6751

Rolling out changeset 70971 <http://trac.webkit.org/changeset/70971> since
it caused layout test failures on all bots. In particular, the
child count in a generated frame name differs after this patch. We need
to look into this further.

  • WebProcess/WebPage/WebFrame.cpp: (WebKit::WebFrame::name):
22:38 Changeset [70975] by tonikitoo@webkit.org

Needs a "LinuxEditingBehavior", perhaps with a better name
https://bugs.webkit.org/show_bug.cgi?id=36627

Reviewed by Ojan Vafai.
Patch by Antonio Gomes <agomes@rim.com>

WebCore:

Added EditingUnixBehavior editing type aim to cover the cases when
neither Mac or Windows behaviors are appropriated.

It was decided to name it Unix not Linux.

No new tests. The current editing tests that involve platform specific
bahaviors are coded so that they go through all editing behavior
types possible. There will be a follow up bug where all of them will
be updated to include the new editing behavior ("unix").

  • editing/EditingBehaviorTypes.h:
  • page/Settings.cpp:

(WebCore::editingBehaviorTypeForPlatform):
(WebCore::Settings::Settings):

WebKit/chromium:

Added the corresponding Chromium setting to WebCore's EditingUnixBehavior: EditingBehaviorUnix.

  • public/WebSettings.h:
  • src/AssertMatchingEnums.cpp:

WebKit/gtk:

Added the corresponding GTK+ setting to WebCore's EditingUnixBehavior: WEBKIT_EDITING_BEHAVIOR_UNIX.

  • webkit/webkitwebsettings.cpp:

(webkit_web_settings_class_init):

  • webkit/webkitwebsettings.h:

WebKit/mac:

Added the corresponding GTK+ setting to WebCore's EditingUnixBehavior: WebKitEditingUnixBehavior.

  • WebView/WebFrame.mm:

(core):

  • WebView/WebPreferencesPrivate.h:

WebKit/qt:

Adding support to Qt's DRTSupport class to test the newly introduced Unix editing behavior.

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(DumpRenderTreeSupportQt::setEditingBehavior):

WebKit/win:

Added the corresponding GTK+ setting to WebCore's EditingUnixBehavior: WebKitEditingUnixBehavior.

  • Interfaces/IWebPreferences.idl:

WebKitTools:

Adding support to Mac's, GTK+'s, Windows' and Chromium's LayoutTestController class to test the newly introduced Unix editing behavior.

  • DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::setEditingBehavior):

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:

(LayoutTestController::setEditingBehavior):

  • DumpRenderTree/mac/LayoutTestControllerMac.mm:

(LayoutTestController::setEditingBehavior):

  • DumpRenderTree/win/LayoutTestControllerWin.cpp:

(LayoutTestController::setEditingBehavior):

21:07 Changeset [70974] by mrowe@apple.com

Merge r70970.

21:07 Changeset [70973] by mrowe@apple.com

Versioning.

20:57 Changeset [70972] by mrowe@apple.com

New tag.

20:49 Changeset [70971] by dbates@webkit.org

2010-10-29 Daniel Bates <dbates@rim.com>

Reviewed by Adam Barth.

For unnamed frames, window.name returns a generated name
https://bugs.webkit.org/show_bug.cgi?id=6751

Modified Chromium-port to use FrameTree::uniqueName().

  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::name):

2010-10-29 Daniel Bates <dbates@rim.com>

Reviewed by Adam Barth.

For unnamed frames, window.name returns a generated name
https://bugs.webkit.org/show_bug.cgi?id=6751

Modified Qt-port to use FrameTree::uniqueName().

  • Api/qwebframe.cpp: (QWebFrame::frameName):

2010-10-29 Daniel Bates <dbates@rim.com>

Reviewed by Adam Barth.

For unnamed frames, window.name returns a generated name
https://bugs.webkit.org/show_bug.cgi?id=6751

Modified GTK-port to use FrameTree::uniqueName().

  • webkit/webkitwebframe.cpp: (webkit_web_frame_get_name):

2010-10-29 Daniel Bates <dbates@rim.com>

Reviewed by Adam Barth.

For unnamed frames, window.name returns a generated name
https://bugs.webkit.org/show_bug.cgi?id=6751

Modified Apple Windows-port to use FrameTree::uniqueName().

  • WebFrame.cpp: (WebFrame::name):

2010-10-29 Daniel Bates <dbates@rim.com>

Reviewed by Adam Barth.

For unnamed frames, window.name returns a generated name
https://bugs.webkit.org/show_bug.cgi?id=6751

Modified Mac-port to use FrameTree::uniqueName().

  • WebView/WebFrame.mm: (-[WebFrame name]):

2010-10-29 Daniel Bates <dbates@rim.com>

Reviewed by Adam Barth.

For unnamed frames, window.name returns a generated name
https://bugs.webkit.org/show_bug.cgi?id=6751

Modified EFL-port to use FrameTree::uniqueName().

  • ewk/ewk_frame.cpp: (ewk_frame_name_get):

2010-10-29 Daniel Bates <dbates@rim.com>

Reviewed by Adam Barth.

For unnamed frames, window.name returns a generated name
https://bugs.webkit.org/show_bug.cgi?id=6751

Fixes an issue where the window.name of an unnamed frame returns
a unique generated name that is used internally to identify the
frame. Instead, we should return an empty string as implied by
section 5.1.6 of the HTML5 spec. (http://www.w3.org/TR/html5/browsers.html#browsing-context-names).
This section describes that a browsing context can have no name or be
the empty string.

  • html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::openURL): Removed ASSERT for empty frame name since this is valid as per the HTML5 spec. (WebCore::HTMLFrameElementBase::setName): Removed the call to FrameTree::uniqueChildName() since the loader code no longer depends on the frame name being unique.
  • html/HTMLFrameElementBase.h:
  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::mainResource): Use FrameTree::uniqueName().
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::loadURLIntoChildFrame): Ditto. (WebCore::FrameLoader::commitProvisionalLoad): Ditto.
  • loader/HistoryController.cpp: (WebCore::HistoryController::saveDocumentState): Ditto. (WebCore::HistoryController::restoreDocumentState): Ditto. (WebCore::HistoryController::createItem): (WebCore::HistoryController::currentFramesMatchItem): Ditto.
  • loader/ProgressTracker.cpp: (WebCore::ProgressTracker::progressStarted): Ditto. (WebCore::ProgressTracker::progressCompleted): Ditto.
  • loader/archive/cf/LegacyWebArchive.cpp: (WebCore::LegacyWebArchive::create): Ditto.
  • page/FrameTree.cpp: (WebCore::FrameTree::setName): Modified to store the DOM-specified name of the frame. (WebCore::FrameTree::clearName): (WebCore::FrameTree::uniqueChildName): Use FrameTree::uniqueName(). (WebCore::FrameTree::child): Ditto. (WebCore::FrameTree::find): Ditto.
  • page/FrameTree.h: (WebCore::FrameTree::uniqueName): Added.

2010-10-29 Daniel Bates <dbates@rim.com>

Reviewed by Adam Barth.

For unnamed frames, window.name returns a generated name
https://bugs.webkit.org/show_bug.cgi?id=6751

Updated test case fast/frames/frame-element-name.html to check
the value of window.name.

  • fast/frames/frame-element-name-expected.txt: Updated result.
  • fast/frames/iframe-set-inner-html-expected.txt: Removed; This test ensured that the generated name for an unnamed frames was unique by looking at the value of window.name. However, the generated name should not be exposed to web developers. Instead, window.name should return the empty string for an unnamed frame as implied by section 5.1.6 of the HTML5 spec. We should consider exposing a DRT method for obtaining the internal frame name (which may be generated) and re-implementing this test to use it.
  • fast/frames/iframe-set-inner-html.html: Removed.
  • fast/frames/resources/frame-element-name-left.html: Added test for window.name.
  • fast/frames/resources/frame-element-name-right.html: Ditto.

2010-10-29 Daniel Bates <dbates@rim.com>

Reviewed by Adam Barth.

For unnamed frames, window.name returns a generated name
https://bugs.webkit.org/show_bug.cgi?id=6751

Modified WebKit2 to use FrameTree::uniqueName().

  • WebProcess/WebPage/WebFrame.cpp: (WebKit::WebFrame::name):
20:42 Changeset [70970] by mrowe@apple.com

Roll out r70847 as it causes crashes when typing text in both Safari and Mail: <http://webkit.org/b/48708>.

20:37 Changeset [70969] by mitz@apple.com

Snow Leopard PowerPC build fix.

  • libWebKitSystemInterfaceSnowLeopard.a:
20:34 Changeset [70968] by mitz@apple.com

Leopard PowerPC build fix.

  • libWebKitSystemInterfaceLeopard.a:
18:40 Changeset [70967] by jamesr@google.com

2010-10-29 James Robinson <jamesr@chromium.org>

Update pixel expectations for Snow Leopard for tests in tables/mozilla/bugs.

Moves the leopard-specific mac baselines to platform/mac-leopard/ and adds new Snow Leopard pixel
expectations for tests that need them. List of files omitted due to length.

18:28 Changeset [70966] by weinig@apple.com

Implement WebProcess::platformSetCacheModel for windows
<rdar://problem/8605796>
https://bugs.webkit.org/show_bug.cgi?id=48703

Reviewed by Simon Fraser.

  • WebProcess/win/WebProcessWin.cpp:

(WebKit::memorySize):
(WebKit::volumeFreeSize):
(WebKit::WebProcess::platformSetCacheModel):
Add implemenation based on the version in WebKit/win/WebView.cpp.

18:23 Changeset [70965] by dimich@chromium.org

[Chromium] Unreviewed test expectations update.
Enable a few tests that were fixed in revs 70891:70949.

  • platform/chromium/test_expectations.txt:
18:09 Changeset [70964] by andreas.kling@nokia.com

2010-10-29 Andreas Kling <kling@webkit.org>

Reviewed by Anders Carlsson.

WK2: Unbreak compilation of WebPlatformTouchPoint::decode()

  • Shared/WebPlatformTouchPoint.cpp: (WebKit::WebPlatformTouchPoint::decode):
18:07 Changeset [70963] by darin@apple.com

Try to fix build.

  • page/ContextMenuController.cpp: Added include of BackForwardController.h.
  • page/DOMWindow.cpp: Ditto.
  • page/History.cpp: Ditto.
  • platform/ContextMenu.cpp: Ditto.
17:58 Changeset [70962] by mrowe@apple.com

Versioning.

17:55 Changeset [70961] by mrowe@apple.com

New tag.

17:44 Changeset [70960] by darin@apple.com

More back/forward refactoring

Reviewed by Sam Weinig.

WebCore:

  • WebCore.exp.in: Updated.
  • GNUmakefile.am: Removed BackForwardControllerClient.h.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • history/BackForwardControllerClient.h: Removed.
  • history/BackForwardController.cpp:

(WebCore::BackForwardController::BackForwardController):
Set up just m_client.
(WebCore::BackForwardController::~BackForwardController):
Removed call to backForwardControllerDestroyed.
(WebCore::BackForwardController::canGoBackOrForward): Added.
(WebCore::BackForwardController::goBackOrForward): Added.
(WebCore::BackForwardController::goBack): Added.
(WebCore::BackForwardController::goForward): Added.
(WebCore::BackForwardController::addItem): Added.
(WebCore::BackForwardController::setCurrentItem): Added.
(WebCore::BackForwardController::count): Added.
(WebCore::BackForwardController::backCount): Added.
(WebCore::BackForwardController::forwardCount): Added.
(WebCore::BackForwardController::itemAtIndex): Added.
(WebCore::BackForwardController::isActive): Added.
(WebCore::BackForwardController::close): Added.

  • history/BackForwardController.h: Added functions from Page

and BackForwardList that should be called here instead.
Note that BackForwardList is to be renamed BackForwardClient soon.

  • history/BackForwardList.h: Removed many now-unneeded

virtual functions.

  • history/BackForwardListImpl.h: Moved BackForwardListClient

in here.

  • history/PageCache.cpp:

(WebCore::logCanCachePageDecision): Use backForward().
(WebCore::PageCache::canCache): Ditto.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::transitionToCommitted): Removed unneeded
null check of backFowardList, which is never null.
(WebCore::FrameLoader::checkLoadCompleteForThisFrame): Use backForward.
(WebCore::FrameLoader::didFirstLayout): Ditto.
(WebCore::FrameLoader::continueLoadAfterNavigationPolicy): Ditto.
(WebCore::FrameLoader::checkDidPerformFirstNavigation): Ditto.

  • loader/HistoryController.cpp:

(WebCore::HistoryController::goToItem): Ditto.
(WebCore::HistoryController::updateForStandardLoad): Ditto.
(WebCore::HistoryController::updateForRedirectWithLockedBackForwardList): Ditto.
(WebCore::HistoryController::updateBackForwardListClippedAtTarget): Ditto.
(WebCore::HistoryController::pushState): Ditto.

  • loader/NavigationScheduler.cpp:

(WebCore::ScheduledHistoryNavigation::fire): Ditto.
(WebCore::NavigationScheduler::scheduleHistoryNavigation): Ditto.

  • page/ContextMenuController.cpp:

(WebCore::ContextMenuController::contextMenuItemSelected): Ditto.

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::close): Ditto.

  • page/History.cpp:

(WebCore::History::length): Ditto.

  • page/Page.cpp:

(WebCore::Page::Page): Use more adoptPtr. Use backForwardClient instead of
backForwardControllerClient.
(WebCore::Page::~Page): Use backForward.
(WebCore::Page::backForwardList): Ditto.
(WebCore::Page::goBack): Ditto.
(WebCore::Page::goForward): Ditto.
(WebCore::Page::canGoBackOrForward): Ditto.
(WebCore::Page::goBackOrForward): Ditto.
(WebCore::Page::getHistoryLength): Ditto.
(WebCore::Page::PageClients::PageClients): Made non-inline.
(WebCore::Page::PageClients::~PageClients): Ditto.

  • page/Page.h: Made PageClients constructor and destructor non-inline.

Added backForward function. Marked old functions as deprecated.

  • page/Settings.cpp:

(WebCore::Settings::setUsesPageCache): Use backForward.

  • platform/ContextMenu.cpp:

(WebCore::ContextMenu::populate): Ditto.
(WebCore::ContextMenu::checkOrEnableIfNeeded): Ditto.

  • wml/WMLDoElement.cpp:

(WebCore::WMLDoElement::defaultEventHandler): Ditto.

  • wml/WMLDocument.cpp:

(WebCore::WMLDocument::finishedParsing): Ditto.

  • wml/WMLPageState.cpp:

(WebCore::WMLPageState::reset): Ditto.
(WebCore::tryAccessHistoryURLs): Ditto.

  • wml/WMLPrevElement.cpp:

(WebCore::WMLPrevElement::executeTask): Ditto.

WebKit2:

  • WebKit2.pro: Removed WebBackForwardControllerClient.cpp and .h.
  • WebKit2.xcodeproj/project.pbxproj: Ditto.
  • WebProcess/WebCoreSupport/WebBackForwardControllerClient.cpp: Removed.
  • WebProcess/WebCoreSupport/WebBackForwardControllerClient.h: Removed.
  • WebProcess/InjectedBundle/InjectedBundleBackForwardList.cpp:

(WebKit::InjectedBundleBackForwardList::itemAtIndex): Use backForward.
(WebKit::InjectedBundleBackForwardList::backListCount): Ditto.
(WebKit::InjectedBundleBackForwardList::forwardListCount): Ditto.
(WebKit::InjectedBundleBackForwardList::clear): Ditto.

  • WebProcess/WebPage/WebBackForwardListProxy.h: Added newly-needed include.
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage): Set up backForwardClient.

17:38 Changeset [70959] by hyatt@apple.com

https://bugs.webkit.org/show_bug.cgi?id=48663

Reviewed by Sam Weinig.

Make repaint invalidation work with vertical lines. Rewrite linesBoundingBox for RenderText and
RenderInline to give the correct rectangle back for vertical lines. Also patch linesVisibleOverflowBoundingBox
to give back the correct rectangle for vertical lines.

Fix bugs in the overflow accessors of InlineFlowBox when m_overflow was 0.

Added fast/repaint/inline-vertical-lr-overflow.html

WebCore:

  • rendering/InlineBox.cpp:

(WebCore::InlineBox::adjustForFlippedBlocksWritingMode):

  • rendering/InlineFlowBox.h:

(WebCore::InlineFlowBox::logicalLeftVisibleOverflow):
(WebCore::InlineFlowBox::logicalRightVisibleOverflow):
(WebCore::InlineFlowBox::bottomLayoutOverflow):
(WebCore::InlineFlowBox::rightLayoutOverflow):
(WebCore::InlineFlowBox::bottomVisualOverflow):
(WebCore::InlineFlowBox::rightVisualOverflow):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::adjustForFlippedBlocksWritingMode):

  • rendering/RenderBox.h:
  • rendering/RenderInline.cpp:

(WebCore::RenderInline::linesBoundingBox):
(WebCore::RenderInline::linesVisibleOverflowBoundingBox):
(WebCore::RenderInline::clippedOverflowRectForRepaint):

  • rendering/RenderText.cpp:

(WebCore::RenderText::linesBoundingBox):

LayoutTests:

  • fast/repaint/inline-vertical-rl-overflow.html: Added.
  • platform/mac/fast/blockflow/background-vertical-lr-expected.txt:
  • platform/mac/fast/blockflow/background-vertical-rl-expected.txt:
  • platform/mac/fast/blockflow/basic-vertical-line-expected.txt:
  • platform/mac/fast/blockflow/border-image-vertical-lr-expected.txt:
  • platform/mac/fast/blockflow/border-image-vertical-rl-expected.txt:
  • platform/mac/fast/blockflow/border-radius-clipping-vertical-lr-expected.txt:
  • platform/mac/fast/blockflow/border-vertical-lr-expected.checksum:
  • platform/mac/fast/blockflow/border-vertical-lr-expected.png:
  • platform/mac/fast/blockflow/border-vertical-lr-expected.txt:
  • platform/mac/fast/blockflow/box-shadow-vertical-lr-expected.txt:
  • platform/mac/fast/blockflow/box-shadow-vertical-rl-expected.txt:
  • platform/mac/fast/blockflow/english-lr-text-expected.txt:
  • platform/mac/fast/blockflow/english-rl-text-expected.txt:
  • platform/mac/fast/blockflow/japanese-lr-text-expected.txt:
  • platform/mac/fast/blockflow/japanese-rl-text-expected.txt:
  • platform/mac/fast/repaint/inline-vertical-rl-overflow-expected.checksum: Added.
  • platform/mac/fast/repaint/inline-vertical-rl-overflow-expected.png: Added.
  • platform/mac/fast/repaint/inline-vertical-rl-overflow-expected.txt: Added.
  • platform/mac/fast/text/international/vertical-text-glyph-test-expected.txt:
17:37 Changeset [70958] by jamesr@google.com

2010-10-29 James Robinson <jamesr@chromium.org>

Update pixel expectations for Snow Leopard for tests in tables/mozilla/marvin.

Moves the leopard-specific mac baselines to platform/mac-leopard/ and adds new Snow Leopard pixel
expectations for tests that need them. List of files omitted due to length.

17:13 Changeset [70957] by commit-queue@webkit.org

2010-10-29 Mike Lawther <mikelawther@chromium.org>

Reviewed by James Robinson.

Fix canvas/philip/tests/2d.imageData.get.source.negative
https://bugs.webkit.org/show_bug.cgi?id=48277

Remove canvas/philip/tests/2d.imageData.get.source.negative from chromium skipped.
Also remove spurious trailing newlines from 2d.imageData.get.source.negative-expected.txt

  • canvas/philip/tests/2d.imageData.get.source.negative-expected.txt:
  • platform/chromium/test_expectations.txt:

2010-10-29 Mike Lawther <mikelawther@chromium.org>

Reviewed by James Robinson.

Fix canvas/philip/tests/2d.imageData.get.source.negative
https://bugs.webkit.org/show_bug.cgi?id=48277

Handle negative width/height.
See http://www.whatwg.org/specs/web-apps/current-work/multipage/the-canvas-element.html#pixel-manipulation

  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::getImageData):
16:57 Changeset [70956] by commit-queue@webkit.org

2010-10-29 Kavita Kanetkar <kkanetkar@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: FileSystem integration
https://bugs.webkit.org/show_bug.cgi?id=45982

Adding filesystem support for Inspector under storage tab. This fetches root paths for
temporary and persistent filesystems and allows "reveal folder in OS" option that
launches native file browser. Currently this feature is disabled for non-chromium platforms.

  • CMakeLists.txt:
  • English.lproj/localizedStrings.js:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/CodeGeneratorInspector.pm:
  • inspector/Inspector.idl:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::releaseFrontendLifetimeAgents):
  • inspector/InspectorController.h: (WebCore::InspectorController::fileSystemAgent):
  • inspector/InspectorFileSystemAgent.cpp: Added.
  • inspector/InspectorFileSystemAgent.h: Added.
  • inspector/front-end/FileSystemView.js: Added.
  • inspector/front-end/Settings.js:
  • inspector/front-end/StoragePanel.js: (WebInspector.StoragePanel): (WebInspector.StoragePanel.prototype.reset): (WebInspector.StoragePanel.prototype.addFileSystem): (WebInspector.StoragePanel.prototype.showFileSystem): (WebInspector.StoragePanel.prototype.updateFileSystemPath): (WebInspector.StoragePanel.prototype.updateFileSystemError): (WebInspector.FileSystemTreeElement): (WebInspector.FileSystemTreeElement.prototype.onselect):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.css: (.file-system-storage-tree-item .icon):
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js: (WebInspector.updateResource): (WebInspector._addFileSystemOrigin): (WebInspector.didGetFileSystemPath): (WebInspector.didGetFileSystemError): (WebInspector.reset):
  • platform/AsyncFileSystem.h: (WebCore::AsyncFileSystem::root):
  • platform/FileSystem.h:
  • platform/chromium/ChromiumBridge.h:
  • platform/chromium/FileSystemChromium.cpp: (WebCore::revealFolderInOS):

2010-10-29 Kavita Kanetkar <kkanetkar@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: FileSystem integration
https://bugs.webkit.org/show_bug.cgi?id=45982

  • public/WebFileUtilities.h: (WebKit::WebFileUtilities::revealFolderInOS):
  • src/ChromiumBridge.cpp: (WebCore::ChromiumBridge::revealFolderInOS):
16:53 Changeset [70955] by mrobinson@webkit.org

2010-10-29 Martin Robinson <mrobinson@igalia.com>

Build fix for GTK+ after BackForwardListImpl introduction.

  • webkit/webkitwebbackforwardlist.cpp: (webkit_web_back_forward_list_new_with_web_view):
16:45 Changeset [70954] by aroben@apple.com

Stop using encode/decodeBytes for WebEvent subclasses

The use of encode/decodeBytes was making these classes sensitive to
differences in padding on different architectures (e.g., 32-bit vs.
64-bit). By encoding each data member explicitly we remove this
sensitivity, allowing these classes to be passed between processes
with different padding.

Fixes <http://webkit.org/b/48552> <rdar://problem/8606571> Mouse
events never reach Flash in WebKit2 on Mac (asserts in Debug builds)

Reviewed by Anders Carlsson.

  • Platform/CoreIPC/Arguments.h:

(CoreIPC::Arguments8::Arguments8):
(CoreIPC::Arguments8::encode):
(CoreIPC::Arguments8::decode):
(CoreIPC::In):
(CoreIPC::Out):
Added Arguments8, the biggest Arguments yet.

  • Shared/WebEvent.cpp:

(WebKit::WebEvent::encode):
(WebKit::WebEvent::decode):

  • Shared/WebKeyboardEvent.cpp:

(WebKit::WebKeyboardEvent::encode):
(WebKit::WebKeyboardEvent::decode):

  • Shared/WebMouseEvent.cpp:

(WebKit::WebMouseEvent::encode):
(WebKit::WebMouseEvent::decode):

  • Shared/WebPlatformTouchPoint.cpp:

(WebKit::WebPlatformTouchPoint::encode):
(WebKit::WebPlatformTouchPoint::decode):

  • Shared/WebTouchEvent.cpp:

(WebKit::WebTouchEvent::encode):
(WebKit::WebTouchEvent::decode):

  • Shared/WebWheelEvent.cpp:

(WebKit::WebWheelEvent::encode):
(WebKit::WebWheelEvent::decode):
Changed all encode/decode function to use CoreIPC::In/Out to
encode/decode data members individually.

16:44 Changeset [70953] by aroben@apple.com

Use only CoreIPC-sanctioned types in WebEvent subclasses

Fixes <http://webkit.org//48694> WebEvent subclasses should not use
architecture-dependent types

Reviewed by Anders Carlsson.

  • Shared/WebEvent.h:

(WebKit::WebEvent::type):
(WebKit::WebMouseEvent::button):
(WebKit::WebMouseEvent::clickCount):
(WebKit::WebWheelEvent::granularity):
(WebKit::WebPlatformTouchPoint::id):
(WebKit::WebPlatformTouchPoint::state):
Replaced enums, ints, and unsigneds with uint32_ts, int32_ts, and
uint32_ts, respectively.

16:44 Changeset [70952] by andreas.kling@nokia.com

2010-10-29 Aaron Colwell <acolwell@chromium.org>

Reviewed by David Levin.

Disable media/video-canvas-alpha.html for Qt & GTK
https://bugs.webkit.org/show_bug.cgi?id=48688

  • platform/gtk/Skipped:
  • platform/qt/Skipped:
16:37 Changeset [70951] by andersca@apple.com

Generate a DelayedReply struct for sync messages marked delayed
https://bugs.webkit.org/show_bug.cgi?id=48696

Reviewed by Adam Roben.

  • Scripts/webkit2/messages.py:

If we encounter a sync message marked delayed, generate a DelayedReply struct with a send member funciton
that can be used for sending the reply.

  • Scripts/webkit2/messages_unittest.py:

Update expected results.

16:34 Changeset [70950] by jamesr@google.com

2010-10-29 James Robinson <jamesr@chromium.org>

Update Snow Leopard pixel baselines for tests in tables/mozilla pt 1

This updates the pixel baselines in platform/mac to be valid for Snow Leopard for tests
in tables/mozilla/collapsing_borders, /core, /dom, and /other. Old baselines moved to
platform/mac-leopard.

16:31 Changeset [70949] by dimich@chromium.org

[Chromium] Unreviewed, test expectations update.

  • platform/chromium-win/editing/deleting/5390681-2-expected.checksum:
  • platform/chromium-win/editing/deleting/5390681-2-expected.png:
16:24 Changeset [70948] by andreas.kling@nokia.com

2010-10-29 Andreas Kling <kling@webkit.org>

Reviewed by Ariya Hidayat.

[Qt] QWebPage's InputMethod event handling calls ShortcutOverride handler too
https://bugs.webkit.org/show_bug.cgi?id=48692

  • Api/qwebpage.cpp: (QWebPage::event): Add missing break statement.
16:22 Changeset [70947] by andreas.kling@nokia.com

2010-10-29 Andreas Kling <kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] QtTestBrowser: Add keyboard shortcut to toggle full screen (F11)
https://bugs.webkit.org/show_bug.cgi?id=48695

  • QtTestBrowser/launcherwindow.cpp: (LauncherWindow::createChrome):
16:19 Changeset [70946] by andreas.kling@nokia.com

2010-10-29 Andreas Kling <kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] QtTestBrowser: Fix uninitialized read in FpsTimer
https://bugs.webkit.org/show_bug.cgi?id=48675

FpsTimer::m_timer was never initialized and passed to QObject::killTimer()
on startup with in -graphicsbased mode.

  • QtTestBrowser/fpstimer.cpp: (FpsTimer::FpsTimer): (FpsTimer::numFrames): (FpsTimer::stop): (FpsTimer::timerEvent):
  • QtTestBrowser/fpstimer.h:
16:15 Changeset [70945] by rniwa@webkit.org

2010-10-29 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

Remove RenderTextControl::setSelectionRange
https://bugs.webkit.org/show_bug.cgi?id=47870

Converted RenderTextControll::setSelectionRange to a global function.

  • Api/qwebpage.cpp: (QWebPagePrivate::inputMethodEvent): Calls setSelectionRange.

2010-10-29 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

Remove RenderTextControl::setSelectionRange
https://bugs.webkit.org/show_bug.cgi?id=47870

Made RenderTextControl::setSelectionRange a global function.
Removed setSelectionStart, setSelectionEnd, and select from RenderTextControl.

No new tests are added since there is no behavioral change.

  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::setSelectedTextRange): Calls setSelectedTextRange.
  • dom/InputElement.cpp: (WebCore::InputElement::updateSelectionRange): Ditto.
  • html/HTMLFormControlElement.cpp: (WebCore::HTMLTextFormControlElement::setSelectionStart): Ditto. (WebCore::HTMLTextFormControlElement::setSelectionEnd): Ditto. (WebCore::HTMLTextFormControlElement::select): Ditto. (WebCore::HTMLTextFormControlElement::setSelectionRange): Ditto.
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::hasVisibleTextArea): Added. (WebCore::setSelectionRange): See above.
  • rendering/RenderTextControl.h:
15:48 Changeset [70944] by jamesr@google.com

2010-10-29 James Robinson <jamesr@chromium.org>

Update pixel expectations for Snow Leopard for tests in tables/mozilla_expected_failures.

Moves the leopard-specific mac baselines to platform/mac-leopard/ and adds new Snow Leopard pixel
expectations for 96 tests that need them. List of files omitted due to length.

15:46 Changeset [70943] by dpranke@chromium.org

2010-10-29 Dirk Pranke <dpranke@chromium.org>

Reviewed by Tony Chang.

new-run-webkit-tests: change TestResults to be serializable

In preparation for changing new-run-webkit-tests from
multithreaded to multiprocess, we need to make sure the data
going between the threads is easily serialized over a socket.

This change adds serialization/pickling for the TestResults and
TestFailure objects (using cPickle).

The TestFailure objects included a "has_wdiff" flag for Text
results, but the flag wasn't being used, so I've removed it,
simplifying the state to basically a set of enum objects with
associated methods.

https://bugs.webkit.org/show_bug.cgi?id=48616

  • Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
  • Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_results.py: Added.
  • Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:Added.
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/test_types/text_diff.py:
15:44 Changeset [70942] by dpranke@chromium.org

2010-10-29 Dirk Pranke <dpranke@chromium.org>

Reviewed by Ojan Vafai.

new-run-webkit-tests: need to provide separate dashboard results for GPU tests
https://bugs.webkit.org/show_bug.cgi?id=48687

Modify the steps to upload the JSON files to the dashboards so
that the GPU tests don't conflict with the regular tests on a
port. We do this by modifying the --builder-name parameter to
append " - GPU", which should cause the app to treat the results
as a completely new builder. This is a little non-obvious, but
keeps us from having to restructure the app.

  • Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
  • Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
15:39 Changeset [70941] by dimich@chromium.org

[Chromium] Unreviewed test expectations update.

  • platform/chromium/test_expectations.txt:
15:36 Changeset [70940] by eric.carlson@apple.com

2010-10-29 Eric Carlson <eric.carlson@apple.com>

Reviewed by Adam Roben.

Results for media test controls-drag-timebar.html are needlessly platform specific
https://bugs.webkit.org/show_bug.cgi?id=48662

  • media/controls-drag-timebar-expected.txt:
  • media/controls-drag-timebar.html: Remove some of the logging to avoid timing differences on slower machines.
15:32 Changeset [70939] by michaeln@google.com

Merge 70923 - 2010-10-28 Michael Nordman <michaeln@google.com>

Reviewed by ap.

[Chrome] Fix an appcache regression introduced in r69226
https://bugs.webkit.org/show_bug.cgi?id=48592
Provide a noop method body ApplicationCacheHost::maybeLoadMainResourceForRedirect.

  • src/ApplicationCacheHost.cpp: (WebCore::ApplicationCacheHost::maybeLoadMainResourceForRedirect):

2010-10-28 Michael Nordman <michaeln@google.com>

Reviewed by ap.

[Chrome] Fix an appcache regression introduced in r69226
https://bugs.webkit.org/show_bug.cgi?id=48592
Define a new ApplicationCacheHost method for the specific case of main resource redirect handling.

Tests: the existing layout test applies

  • loader/MainResourceLoader.cpp: use the newly introduced method (WebCore::MainResourceLoader::willSendRequest):
  • loader/appcache/ApplicationCacheHost.cpp: (WebCore::ApplicationCacheHost::maybeLoadMainResourceForRedirect):
  • loader/appcache/ApplicationCacheHost.h:

TBR=michaeln@google.com

15:23 Changeset [70938] by aroben@apple.com

Update test results for the presence of HTMLMeterElement

  • platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/win/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/win/fast/dom/prototype-inheritance-expected.txt:
  • platform/win/fast/js/global-constructors-expected.txt:
15:23 Changeset [70937] by aroben@apple.com

Stop skipping HTMLMeterElement tests on Windows and check in results for them

Fixes <http://webkit.org/b/48681>
fast/dom/HTMLMeterElement/meter-boundary-values.html fails on Windows

  • platform/win/Skipped: Removed HTMLMeterElement tests.
  • platform/win/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.checksum: Added.
  • platform/win/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.png: Added.
  • platform/win/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.txt: Added.
  • platform/win/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.checksum: Added.
  • platform/win/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.png: Added.
  • platform/win/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.txt: Added.
  • platform/win/fast/dom/HTMLMeterElement/meter-boundary-values-expected.checksum: Added.
  • platform/win/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png: Added.
  • platform/win/fast/dom/HTMLMeterElement/meter-boundary-values-expected.txt: Added.
  • platform/win/fast/dom/HTMLMeterElement/meter-element-expected.checksum: Added.
  • platform/win/fast/dom/HTMLMeterElement/meter-element-expected.png: Added.
  • platform/win/fast/dom/HTMLMeterElement/meter-element-expected.txt: Added.
  • platform/win/fast/dom/HTMLMeterElement/meter-optimums-expected.checksum: Added.
  • platform/win/fast/dom/HTMLMeterElement/meter-optimums-expected.png: Added.
  • platform/win/fast/dom/HTMLMeterElement/meter-optimums-expected.txt: Added.
  • platform/win/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.checksum: Added.
  • platform/win/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.png: Added.
  • platform/win/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt: Added.
  • platform/win/fast/dom/HTMLMeterElement/meter-styles-expected.checksum: Added.
  • platform/win/fast/dom/HTMLMeterElement/meter-styles-expected.png: Added.
  • platform/win/fast/dom/HTMLMeterElement/meter-styles-expected.txt: Added.
15:16 Changeset [70936] by andersca@apple.com

Use WebPage::send in a couple of more places.

Reviewed by Adam Roben.

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::setWindowRect):
(WebKit::WebChromeClient::takeFocus):
(WebKit::WebChromeClient::setToolbarsVisible):
(WebKit::WebChromeClient::setStatusbarVisible):
(WebKit::WebChromeClient::setMenubarVisible):
(WebKit::WebChromeClient::setResizable):
(WebKit::WebChromeClient::setStatusbarText):
(WebKit::WebChromeClient::contentsSizeChanged):
(WebKit::WebChromeClient::mouseDidMoveOverElement):
(WebKit::WebChromeClient::setToolTip):
(WebKit::WebChromeClient::setCursor):
(WebKit::WebChromeClient::dispatchViewportDataDidChange):

  • WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::WebEditorClient::registerCommandForUndo):
(WebKit::WebEditorClient::clearUndoRedoOperations):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::detachedFromParent2):
(WebKit::WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad):
(WebKit::WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
(WebKit::WebFrameLoaderClient::dispatchDidReceiveTitle):
(WebKit::WebFrameLoaderClient::dispatchDidCommitLoad):
(WebKit::WebFrameLoaderClient::dispatchDidFailProvisionalLoad):
(WebKit::WebFrameLoaderClient::dispatchDidFailLoad):
(WebKit::WebFrameLoaderClient::dispatchDidFinishDocumentLoad):
(WebKit::WebFrameLoaderClient::dispatchDidFinishLoad):
(WebKit::WebFrameLoaderClient::dispatchDidFirstLayout):
(WebKit::WebFrameLoaderClient::dispatchDidFirstVisuallyNonEmptyLayout):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForMIMEType):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
(WebKit::WebFrameLoaderClient::dispatchWillSubmitForm):
(WebKit::WebFrameLoaderClient::postProgressStartedNotification):
(WebKit::WebFrameLoaderClient::postProgressEstimateChangedNotification):
(WebKit::WebFrameLoaderClient::postProgressFinishedNotification):
(WebKit::WebFrameLoaderClient::didDisplayInsecureContent):
(WebKit::WebFrameLoaderClient::didRunInsecureContent):
(WebKit::WebFrameLoaderClient::dispatchDidBecomeFrameset):

  • WebProcess/WebPage/FindController.cpp:

(WebKit::FindController::findString):
(WebKit::FindController::hideFindIndicator):

  • WebProcess/WebPage/WebBackForwardListProxy.cpp:

(WebKit::WebBackForwardListProxy::addItem):
(WebKit::WebBackForwardListProxy::goToItem):
(WebKit::WebBackForwardListProxy::clear):

  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::createMainFrame):
(WebKit::WebFrame::createSubframe):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::sendClose):
(WebKit::WebPage::pageDidScroll):
(WebKit::WebPage::mouseEvent):
(WebKit::WebPage::wheelEvent):
(WebKit::WebPage::keyEvent):
(WebKit::WebPage::validateMenuItem):
(WebKit::WebPage::touchEvent):
(WebKit::WebPage::show):
(WebKit::WebPage::runJavaScriptInMainFrame):
(WebKit::WebPage::getRenderTreeExternalRepresentation):
(WebKit::WebPage::getSourceForFrame):

15:15 Changeset [70935] by commit-queue@webkit.org

2010-10-29 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Andreas Kling.

[GTK] Crash in TextEncoding.cpp when using glib unicode
https://bugs.webkit.org/show_bug.cgi?id=48521

When the conversion to UTF-8 fails, try to encode the original string
without normalizing. Fixes tests cases:

fast/url/anchor.html
fast/url/query.html
fast/url/standard-url.html

  • platform/text/TextEncoding.cpp: (WebCore::TextEncoding::encode):
15:02 Changeset [70934] by andersca@apple.com

Add a MessageSender class template
https://bugs.webkit.org/show_bug.cgi?id=48683

Reviewed by Adam Roben.

  • Platform/CoreIPC/MessageSender.h: Added.

(CoreIPC::MessageSender::send):
Add send overloads for simple message sending.

  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:

Add MessageSender.h

  • WebProcess/WebPage/FindController.cpp:

(WebKit::FindController::countStringMatches):
(WebKit::FindController::findString):
(WebKit::FindController::updateFindIndicator):
Call send on the web page.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::connection):
Add connection(), used by the MessageSender.

  • WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::destinationID):
Add destinationID(), used by the MessageSender.

  • win/WebKit2.vcproj:

Add MessageSender.h

15:01 Changeset [70933] by benjamin.poulain@nokia.com

2010-10-29 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Antonio Gomes.

TextureMapperGL get the driver info log but do not use it
https://bugs.webkit.org/show_bug.cgi?id=48247

Remove the call to glGetProgramInfoLog().

  • platform/graphics/opengl/TextureMapperGL.cpp: (WebCore::TexmapShaderInfo::createShaderProgram):
14:47 Changeset [70932] by commit-queue@webkit.org

2010-10-29 Benjamin Kalman <kalman@google.com>

Reviewed by Tony Chang.

Deleting contenteditable text to the left of a non-contenteditable span inserts unnecessary placeholder <br/>
https://bugs.webkit.org/show_bug.cgi?id=48658

  • editing/deleting/5390681-expected.txt: Update test for changed behaviour.
  • editing/deleting/5390681.html: Ditto (update comment).
  • editing/deleting/delete-mixed-editable-content-001-expected.txt: Ditto.
  • editing/pasteboard/copy-backslash-with-euc-expected.txt: Ditto.

2010-10-29 Benjamin Kalman <kalman@google.com>

Reviewed by Tony Chang.

Deleting contenteditable text to the left of a non-contenteditable span inserts unnecessary placeholder <br/>
https://bugs.webkit.org/show_bug.cgi?id=48658

  • WebCore.exp.in: Update is{Start,End}OfParagraph symbols.
  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::doApply): Cross editability boundaries when determining whether to insert placeholder.
  • editing/visible_units.cpp: Allow editability boundary to be crossed in {start,end,isStart,isEnd}OfParagraph. (WebCore::startOfParagraph): Also, avoid returning a position where renderer can't accept caret, like in endOfParagraph. (WebCore::endOfParagraph): (WebCore::isStartOfParagraph): (WebCore::isEndOfParagraph):
  • editing/visible_units.h: Ditto.
14:38 Changeset [70931] by darin@apple.com

2010-10-29 Darin Adler <darin@apple.com>

Reviewed by Sam Weinig.

Change BackForwardList clients to use BackForwardListImpl to prepare for further refactoring
https://bugs.webkit.org/show_bug.cgi?id=48574

  • src/BackForwardListClientImpl.h: Use BackForwardListImpl.h.
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::WebViewImpl): Cast to BackForwardList* before calling setClient.

2010-10-29 Darin Adler <darin@apple.com>

Reviewed by Sam Weinig.

Change BackForwardList clients to use BackForwardListImpl to prepare for further refactoring
https://bugs.webkit.org/show_bug.cgi?id=48574

  • Api/qwebhistory.cpp: (QWebHistory::clear):
  • Api/qwebhistory_p.h:
  • Api/qwebpage.cpp: (QWebPagePrivate::QWebPagePrivate): Use BackForwardListImpl.

2010-10-29 Darin Adler <darin@apple.com>

Reviewed by Sam Weinig.

Change BackForwardList clients to use BackForwardListImpl to prepare for further refactoring
https://bugs.webkit.org/show_bug.cgi?id=48574

  • webkit/webkitprivate.h:
  • webkit/webkitwebbackforwardlist.cpp: (webkit_web_back_forward_list_dispose): (webkit_web_back_forward_list_new_with_web_view): (webkit_web_back_forward_list_go_forward): (webkit_web_back_forward_list_go_back): (webkit_web_back_forward_list_contains_item): (webkit_web_back_forward_list_go_to_item): (webkit_web_back_forward_list_get_forward_list_with_limit): (webkit_web_back_forward_list_get_back_list_with_limit): (webkit_web_back_forward_list_get_back_item): (webkit_web_back_forward_list_get_current_item): (webkit_web_back_forward_list_get_forward_item): (webkit_web_back_forward_list_get_nth_item): (webkit_web_back_forward_list_get_back_length): (webkit_web_back_forward_list_get_forward_length): (webkit_web_back_forward_list_get_limit): (webkit_web_back_forward_list_set_limit): (webkit_web_back_forward_list_add_item): (webkit_web_back_forward_list_clear): (WebKit::core):
  • webkit/webkitwebview.cpp: (webkit_web_view_set_maintains_back_forward_list): (webkit_web_view_get_back_forward_list): Use BackForwardListImpl.

2010-10-29 Darin Adler <darin@apple.com>

Reviewed by Sam Weinig.

Change BackForwardList clients to use BackForwardListImpl to prepare for further refactoring
https://bugs.webkit.org/show_bug.cgi?id=48574

  • WebBackForwardList.cpp: (backForwardListWrappers): (WebBackForwardList::WebBackForwardList): (WebBackForwardList::createInstance):
  • WebBackForwardList.h:
  • WebView.cpp: (WebView::backForwardList): Use BackForwardListImpl.

2010-10-29 Darin Adler <darin@apple.com>

Reviewed by Sam Weinig.

Change BackForwardList clients to use BackForwardListImpl to prepare for further refactoring
https://bugs.webkit.org/show_bug.cgi?id=48574

  • WebFrame.cpp: (wxWebFrame::CanGoBack): Use canGoBackOrForward. (wxWebFrame::CanGoForward): Ditto.

2010-10-29 Darin Adler <darin@apple.com>

Reviewed by Sam Weinig.

Change BackForwardList clients to use BackForwardListImpl to prepare for further refactoring
https://bugs.webkit.org/show_bug.cgi?id=48574

  • History/WebBackForwardList.mm: Use BackForwardListImpl.

2010-10-29 Darin Adler <darin@apple.com>

Reviewed by Sam Weinig.

Change BackForwardList clients to use BackForwardListImpl to prepare for further refactoring
https://bugs.webkit.org/show_bug.cgi?id=48574

  • ewk/ewk_history.cpp: (ewk_history_new):
  • ewk/ewk_private.h:
  • ewk/ewk_view.cpp: (_ewk_view_priv_new): (ewk_view_history_enable_get): (ewk_view_history_enable_set): (ewk_view_history_get): Use BackForwardListImpl.
14:31 Changeset [70930] by andersca@apple.com

Add the plug-in proxy to the map before sending the CreatePlugin message
https://bugs.webkit.org/show_bug.cgi?id=48678

Reviewed by Adam Roben.

  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::initialize):

14:28 Changeset [70929] by pfeldman@chromium.org

2010-10-29 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: last active panel is not restored upon opening inspector.
https://bugs.webkit.org/show_bug.cgi?id=48668

  • inspector/Inspector.idl:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::inspect): (WebCore::InspectorController::showPanel): (WebCore::InspectorController::disconnectFrontend): (WebCore::InspectorController::populateScriptObjects):
  • inspector/InspectorController.h:
  • inspector/InspectorState.cpp: (WebCore::InspectorState::InspectorState):
  • inspector/front-end/Settings.js: (WebInspector.Settings):
  • inspector/front-end/inspector.js: (WebInspector.set currentPanel): (WebInspector.doLoadedDone.onPopulateScriptObjects): (WebInspector.doLoadedDone): (WebInspector.documentClick.followLink): (WebInspector.documentClick):
14:26 Changeset [70928] by aroben@apple.com

Remove redundant data members from WebTouchEvent

WebEvent already stores the Type and timestamp.

Fixes <http://webkit.org/b/48671> WebTouchEvent duplicates data from
WebEvent

Reviewed by Anders Carlsson.

  • Shared/WebEvent.h:
  • Shared/WebTouchEvent.cpp:

(WebKit::WebTouchEvent::WebTouchEvent):
Removed m_type and m_timestamp (which was never even getting
initialized!).

14:24 Changeset [70927] by andersca@apple.com

Add GetWindowScriptNPObject message
https://bugs.webkit.org/show_bug.cgi?id=48670

Reviewed by Adam Roben.

  • PluginProcess/PluginControllerProxy.cpp:

(WebKit::PluginControllerProxy::windowScriptNPObject):
Send the GetWindowScriptNPObject message.

  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::getWindowScriptNPObject):
Add stub.

  • WebProcess/Plugins/PluginProxy.messages.in:

Add GetWindowScriptNPObject message.

14:18 Changeset [70926] by eric.carlson@apple.com

2010-10-29 Eric Carlson <eric.carlson@apple.com>

Reviewed by Adam Roben.

Results for media test controls-drag-timebar.html are needlessly platform specific
https://bugs.webkit.org/show_bug.cgi?id=48662

  • media/controls-drag-timebar-expected.txt: Added.
  • media/controls-drag-timebar.html: Remove all platform specific logging.
  • platform/chromium-mac/media/controls-drag-timebar-expected.txt: Removed.
  • platform/chromium-win/media/controls-drag-timebar-expected.txt: Removed.
  • platform/gtk/media/controls-drag-timebar-expected.txt: Removed.
  • platform/mac-leopard/media/controls-drag-timebar-expected.txt: Removed.
  • platform/mac-snowleopard/Skipped: Unskip test.
  • platform/mac-tiger/media/controls-drag-timebar-expected.txt: Removed.
  • platform/mac/media/controls-drag-timebar-expected.txt: Removed.
  • platform/win/media/controls-drag-timebar-expected.txt: Removed.
14:07 Changeset [70925] by dimich@chromium.org

[Chromium] Unreviewed test expectations update.

  • platform/chromium/test_expectations.txt:
14:06 Changeset [70924] by ojan@chromium.org

2010-10-29 Ojan Vafai <ojan@chromium.org>

Reviewed by Tony Chang.

[chromium] add debug logging to help diagnose flakiness dashboard issues
https://bugs.webkit.org/show_bug.cgi?id=48657

The appengine app thinks it's getting empty files uploaded. Add some logging
to see if new-run-webkit-tests agrees.

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
14:06 Changeset [70923] by michaeln@google.com

2010-10-28 Michael Nordman <michaeln@google.com>

Reviewed by ap.

[Chrome] Fix an appcache regression introduced in r69226
https://bugs.webkit.org/show_bug.cgi?id=48592
Provide a noop method body ApplicationCacheHost::maybeLoadMainResourceForRedirect.

  • src/ApplicationCacheHost.cpp: (WebCore::ApplicationCacheHost::maybeLoadMainResourceForRedirect):

2010-10-28 Michael Nordman <michaeln@google.com>

Reviewed by ap.

[Chrome] Fix an appcache regression introduced in r69226
https://bugs.webkit.org/show_bug.cgi?id=48592
Define a new ApplicationCacheHost method for the specific case of main resource redirect handling.

Tests: the existing layout test applies

  • loader/MainResourceLoader.cpp: use the newly introduced method (WebCore::MainResourceLoader::willSendRequest):
  • loader/appcache/ApplicationCacheHost.cpp: (WebCore::ApplicationCacheHost::maybeLoadMainResourceForRedirect):
  • loader/appcache/ApplicationCacheHost.h:
14:00 Changeset [70922] by eric.carlson@apple.com

2010-10-29 Eric Carlson <eric.carlson@apple.com>

Reviewed by Adam Roben.

Navigating to a .wav file creates a plugin document but should create a media document
https://bugs.webkit.org/show_bug.cgi?id=48546
<rdar://problem/8606105>

Test: media/media-can-play-wav-audio.html

  • platform/MIMETypeRegistry.cpp: Add mapping from ".wav" to "audio/x-wav".

2010-10-28 Eric Carlson <eric.carlson@apple.com>

Reviewed by Adam Roben.

Navigating to a .wav file creates a plugin document but should create a media document
https://bugs.webkit.org/show_bug.cgi?id=48546
<rdar://problem/8606105>

  • media/media-can-play-wav-audio-expected.txt: Added.
  • media/media-can-play-wav-audio.html: Added.
13:52 Changeset [70921] by mihaip@chromium.org

2010-10-29 Mihai Parparita <mihaip@chromium.org>

Update the pixel expectations for fast/block/float for the Mac port.

For the tests that currently fail on Snow Leopard with --pixel-tests
--tolerance 0, this moves the current pixel results to mac-leopard and
adds new Snow Leopard-specific results to platform/mac.

List of files omitted due to length but composed entirely of moves from
platform/mac to platform/mac-leopard and newly added files in
platform/mac.

platform/mac/test_expectations.txt was also modified to remove a
now-passing test.

13:51 Changeset [70920] by andersca@apple.com

Change the Connection::sendSync timeout parameter to have the NoTimeout argument as a default
argument and update all the call sites.

Reviewed by Dan Bernstein.

  • Platform/CoreIPC/Connection.h:
  • PluginProcess/PluginControllerProxy.cpp:

(WebKit::PluginControllerProxy::proxiesForURL):
(WebKit::PluginControllerProxy::cookiesForURL):

  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::postSynchronousMessage):

  • WebProcess/Plugins/PluginProcessConnectionManager.cpp:

(WebKit::PluginProcessConnectionManager::getPluginProcessConnection):

  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::initialize):
(WebKit::PluginProxy::destroy):
(WebKit::PluginProxy::paint):
(WebKit::PluginProxy::handleMouseEvent):
(WebKit::PluginProxy::handleWheelEvent):
(WebKit::PluginProxy::handleMouseEnterEvent):
(WebKit::PluginProxy::handleMouseLeaveEvent):
(WebKit::PluginProxy::handleKeyboardEvent):

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::windowRect):
(WebKit::WebChromeClient::createWindow):
(WebKit::WebChromeClient::toolbarsVisible):
(WebKit::WebChromeClient::statusbarVisible):
(WebKit::WebChromeClient::menubarVisible):
(WebKit::WebChromeClient::canRunBeforeUnloadConfirmPanel):
(WebKit::WebChromeClient::runBeforeUnloadConfirmPanel):
(WebKit::WebChromeClient::runJavaScriptAlert):
(WebKit::WebChromeClient::runJavaScriptConfirm):
(WebKit::WebChromeClient::runJavaScriptPrompt):

  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:

(WebKit::WebPlatformStrategies::populatePluginCache):

  • WebProcess/WebPage/WebBackForwardListProxy.cpp:

(WebKit::WebBackForwardListProxy::itemAtIndex):
(WebKit::WebBackForwardListProxy::backListCount):
(WebKit::WebBackForwardListProxy::forwardListCount):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::createPlugin):
(WebKit::WebPage::changeAcceleratedCompositingMode):

  • WebProcess/WebPage/mac/LayerBackedDrawingAreaMac.mm:

(WebKit::LayerBackedDrawingArea::attachCompositingContext):

  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::interceptEditingKeyboardEvent):

13:49 Changeset [70919] by commit-queue@webkit.org

2010-10-29 Aaron Colwell <acolwell@chromium.org>

Reviewed by James Robinson.

Added a layout test for verifying that globalAlpha is properly handled
when copying a video frame to a 2D canvas context.
https://bugs.webkit.org/show_bug.cgi?id=48094

  • media/video-canvas-alpha-expected.txt: Added.
  • media/video-canvas-alpha.html: Added.
  • platform/chromium-mac/media/video-canvas-alpha-expected.checksum: Added.
  • platform/chromium-mac/media/video-canvas-alpha-expected.png: Added.
  • platform/chromium-win/media/video-canvas-alpha-expected.checksum: Added.
  • platform/chromium-win/media/video-canvas-alpha-expected.png: Added.

2010-10-29 Aaron Colwell <acolwell@chromium.org>

Reviewed by James Robinson.

Created helper method WebCore::PlatformContextSkia::getNormalizedAlpha()
to centralize alpha rounding & clipping logic.
https://bugs.webkit.org/show_bug.cgi?id=48094

Test: media/video-canvas-alpha.html

  • platform/graphics/skia/ImageSkia.cpp: (WebCore::paintSkBitmap):
  • platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::getNormalizedAlpha):
  • platform/graphics/skia/PlatformContextSkia.h:

2010-10-29 Aaron Colwell <acolwell@chromium.org>

Reviewed by James Robinson.

Fix globalAlpha support when using drawImage() to copy a video frame
to a 2D canvas context.
https://bugs.webkit.org/show_bug.cgi?id=48094

This fix applies the globalAlpha value to the canvas before passing it
down to the lower layers that don't have access to the graphics
context. This makes sure that any drawing on the canvas will have the
proper global alpha value applied.

  • src/WebMediaPlayerClientImpl.cpp: (WebKit::WebMediaPlayerClientImpl::paint):
13:33 Changeset [70918] by zimmermann@webkit.org

2010-10-29 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

ASSERT when SVGAnimatedProperty instance is assigned to multiple elements.
https://bugs.webkit.org/show_bug.cgi?id=48555

Test: svg/custom/insertItemBefore-from-non-list-origin.svg

  • bindings/scripts/CodeGeneratorJS.pm: Include SVGAnimatedPropertyTearOff.h instead of SVGPropertyTearOff.h
  • bindings/scripts/CodeGeneratorObjC.pm: Ditto.
  • bindings/scripts/CodeGeneratorV8.pm: Ditto.
  • svg/properties/SVGAnimatedListPropertyTearOff.h: (WebCore::SVGAnimatedListPropertyTearOff::isAnimatedListTearOff): Return true. (WebCore::SVGAnimatedListPropertyTearOff::removeItemFromList): Devirtualize function.
  • svg/properties/SVGAnimatedProperty.h: (WebCore::SVGAnimatedProperty::isAnimatedListTearOff): Return false.
  • svg/properties/SVGListPropertyTearOff.h: (WebCore::SVGListPropertyTearOff::removeItemFromListIfNeeded): Only try to remove the passed item from its list, if its actually a list and not just a SVGAnimatedProperty.

2010-10-29 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

ASSERT when SVGAnimatedProperty instance is assigned to multiple elements.
https://bugs.webkit.org/show_bug.cgi?id=48555

  • svg/custom/insertItemBefore-from-non-list-origin-expected.txt: Added.
  • svg/custom/insertItemBefore-from-non-list-origin.svg: Added.
13:25 Changeset [70917] by hyatt@apple.com

https://bugs.webkit.org/show_bug.cgi?id=48444

Reviewed by Adam Roben.

Fix the dirty rect checks in RenderBoxLineList, InlineFlowBox, InlineTextBox. They were still assuming horizontal-tb writing-mode.
This patch makes the checks directionally abstract and also refactors the checks in RenderLineBoxList to share code.

No tests yet, since the invalidation code for inlines still assumes horizontal-tb. That will be fixed in a follow-up bug,
and then repaint tests will be easy to write.

  • rendering/InlineBox.cpp:

(WebCore::InlineBox::adjustForFlippedBlocksWritingMode):

  • rendering/InlineBox.h:
  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::paint):

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paint):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::convertFromFlippedWritingMode):

  • rendering/RenderBox.h:
  • rendering/RenderLineBoxList.cpp:

(WebCore::RenderLineBoxList::rangeIntersectsDirtyRect):
(WebCore::RenderLineBoxList::anyLineIntersectsDirtyRect):
(WebCore::RenderLineBoxList::lineIntersectsDirtyRect):
(WebCore::RenderLineBoxList::paint):
(WebCore::RenderLineBoxList::hitTest):

  • rendering/RenderLineBoxList.h:
13:06 Changeset [70916] by sullivan@apple.com

https://bugs.webkit.org/show_bug.cgi?id=48666
WebKit2 should provide counterpart getter to WKBundleNodeHandleSetHTMLInputElementAutofilled

Reviewed by Anders Carlsson.

  • WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.cpp:

(WKBundleNodeHandleGetHTMLInputElementAutofilled):
New function, calls through to InjectedBundleNodeHandle.

  • WebProcess/InjectedBundle/API/c/WKBundleNodeHandlePrivate.h:

Declared new function.

  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:

(WebKit::InjectedBundleNodeHandle::isHTMLInputElementAutofilled):
New function, calls through to HTMLInputElement.

  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h:

Declared new function.

12:30 Changeset [70915] by jberlin@webkit.org

ASSERTION FAILURE in WebProcessProxy::frameDestroyed when a Page is closed before it can send
the DidCreateMainFrame messsage to the UIProcess.
https://bugs.webkit.org/show_bug.cgi?id=48654

Reviewed by Anders Carlsson.

WebProcessProxy::frameDestroyed was asserting that the frameID it was called with was
registered in WebProcessProxy::frameCreated (which is called when the WebPageProxy is
created). However, in the case where we close the page before it's had the chance to send
the DidCreateMainFrame message back to the UI process, the UI Process will get the
DidDestroyFrame message because it's sent directly to the WebProcessProxy and doesn't go
through WebPageProxy.

Remove the assert because it is invalid in this case.

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::frameDestroyed):

12:13 Changeset [70914] by paroga@webkit.org

2010-10-29 Patrick Gansterer <paroga@webkit.org>

Reviewed by Adam Roben.

Cleanup createGlobalImageFileDescriptor in ClipboardWin
https://bugs.webkit.org/show_bug.cgi?id=48189

  • platform/win/ClipboardWin.cpp: (WebCore::createGlobalURLContent): (WebCore::createGlobalUrlFileDescriptor): (WebCore::ClipboardWin::writeURL):
12:00 Changeset [70913] by mihaip@chromium.org

2010-10-29 Mihai Parparita <mihaip@chromium.org>

Reviewed by Tony Chang.

[Chromium] fast/loader/stateobjects/state-api-on-detached-frame-crash.html does not pass on Chromium
https://bugs.webkit.org/show_bug.cgi?id=48647

Chromium throws an exception if calling push/replaceState on a detached
frame, while the mac port fails silently (presumably a JSC vs. V8
difference). Either behavior is correct (as long as we don't crash),
make the test handle both.

  • fast/loader/stateobjects/state-api-on-detached-frame-crash-expected.txt:
  • fast/loader/stateobjects/state-api-on-detached-frame-crash.html:
  • platform/chromium/test_expectations.txt:
12:00 Changeset [70912] by dimich@chromium.org

[Chromium clang] Unreviewed fix removing compiler warning.
If GIFImageReader is a struct, don't call it a class.

  • platform/image-decoders/gif/GIFImageDecoder.h:
11:56 Changeset [70911] by ap@apple.com

Rubber-stamped by Sam Weinig.

Comment for usesDocumentViews explains it backwards. This flag is true in ToT, and we do
create views for subframes.

  • WebView/WebViewData.h: Double negation is better than a lie.
11:55 Changeset [70910] by oliver@apple.com

2010-10-29 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

REGRESSION: r69429-r69611: Crash in JSC::Interpreter::privateExecute
https://bugs.webkit.org/show_bug.cgi?id=47573

I think the interpreter portion of this was introduced by
an incorrect but silent merge when I updated prior to committing.
The JIT change is basically just a correctness fix, but it is
needed to prevent the testcase from asserting in debug builds.

The basic problem is incorrectly setting the activation object
on an arguments object. The crash was due to us setting a null
activation in the interpreter, in the jit we were setting the
activation of a strict mode arguments object.

  • interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute):
  • jit/JITStubs.cpp: (JSC::DEFINE_STUB_FUNCTION):
  • wtf/Platform.h:

2010-10-29 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

REGRESSION: r69429-r69611: Crash in JSC::Interpreter::privateExecute
https://bugs.webkit.org/show_bug.cgi?id=47573

Add a test to ensure that we don't incorrectly set a null activation
as an argument object's activation.

  • fast/js/interpreter-no-activation-expected.txt: Added.
  • fast/js/interpreter-no-activation.html: Added.
  • fast/js/script-tests/interpreter-no-activation.js: Added.
11:48 Changeset [70909] by jamesr@google.com

Merge 70748 - 2010-10-27 Andy Estes <aestes@apple.com>

Reviewed by Adam Barth.

r66156 broke AtlasCT library, formerly affected http://map.d.co.il/
https://bugs.webkit.org/show_bug.cgi?id=45679

This patch removes WebKit's map of classid values to MIME types. It also
changes the behavior of object elements to render fallback content when
a non-empty classid attribute is specified, which is the behavior HTML5
specifies when a UA encounters a classid it doesn't understand.

Test: fast/replaced/object-with-non-empty-classid-triggers-fallback.html

  • html/HTMLObjectElement.cpp: Remove serviceTypeForClassId(), createClassIdToTypeMap(), and the ClassIdToTypeMap typedef. (WebCore::HTMLObjectElement::updateWidget): Do not call serviceTypeForClassId() when there is no type attribute, and render fallback content if the classid attribute is non-empty.

2010-10-27 Andy Estes <aestes@apple.com>

Reviewed by Adam Barth.

r66156 broke AtlasCT library, formerly affected http://map.d.co.il/
https://bugs.webkit.org/show_bug.cgi?id=45679

  • fast/dom/object-embed-plugin-scripting.html: Changed classid attributes to type attributes.
  • fast/dom/object-plugin-hides-properties.html: Ditto.
  • fast/replaced/object-with-non-empty-classid-triggers-fallback-expected.txt: Added.
  • fast/replaced/object-with-non-empty-classid-triggers-fallback.html: Added.

TBR=cpu@google.com
BUG=57986

Review URL: http://codereview.chromium.org/4214004

11:43 Changeset [70908] by mihaip@chromium.org

2010-10-29 Mihai Parparita <mihaip@chromium.org>

Unreviewed cleanp of platform/chromium/test_expectations.txt

Group http/tests/navigation failures together, and differentiate between
flaky/failing tests and those that need updated baselines (though really
they shouldn't be pixel tests in the first place).

Also enable http/tests/navigation/post-goback-repost-policy.html, it
seems to be passing now (we've enabled sessionStorage for a while).

  • platform/chromium/test_expectations.txt:
11:40 Changeset [70907] by ap@apple.com

Fix the world (d'oh!)

https://bugs.webkit.org/show_bug.cgi?id=48576
Let WebKit2 client know when a frame is a frameset

  • html/HTMLFrameSetElement.cpp: (WebCore::HTMLFrameSetElement::insertedIntoDocument): (WebCore::HTMLFrameSetElement::removedFromDocument): Call base class version.
11:36 Changeset [70906] by jianli@chromium.org

Unreviewed. Fix chromium build break.

  • bindings/v8/custom/V8FileReaderCustom.cpp:

(WebCore::V8FileReader::resultAccessorGetter):

11:28 Changeset [70905] by dglazkov@chromium.org

2010-10-29 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Ojan Vafai.

[Chromium/DRT] Add master-name flag to new-run-webkit-tests.
https://bugs.webkit.org/show_bug.cgi?id=48649

  • BuildSlaveSupport/build.webkit.org-config/master.cfg: Added flag.
11:23 Changeset [70904] by jianli@chromium.org

Support readAsArrayBuffer in FileReader and FileReaderSync
https://bugs.webkit.org/show_bug.cgi?id=47691

Reviewed by David Levin.

WebCore:

Merge the similar code in FileReader and FileReaderSync into
FileReaderLoader.

Test cases have been added to read-file-test-cases.js.

  • Android.jscbindings.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/v8/custom/V8FileReaderCustom.cpp: Added.
  • fileapi/FileReader.cpp:

(WebCore::FileReader::FileReader):
(WebCore::FileReader::readAsArrayBuffer):
(WebCore::FileReader::readAsBinaryString):
(WebCore::FileReader::readAsText):
(WebCore::FileReader::readAsDataURL):
(WebCore::FileReader::readInternal):
(WebCore::FileReader::doAbort):
(WebCore::FileReader::terminate):
(WebCore::FileReader::start):
(WebCore::FileReader::didStartLoading):
(WebCore::FileReader::didReceiveData):
(WebCore::FileReader::didFinishLoading):
(WebCore::FileReader::didFail):
(WebCore::FileReader::fireEvent):
(WebCore::FileReader::arrayBufferResult):
(WebCore::FileReader::stringResult):

  • fileapi/FileReader.h:

(WebCore::FileReader::readType):

  • fileapi/FileReader.idl:
  • fileapi/FileReaderLoader.cpp: Added.
  • fileapi/FileReaderLoader.h: Added.
  • fileapi/FileReaderLoaderClient.h: Added.
  • fileapi/FileReaderSync.cpp:

(WebCore::FileReaderSync::FileReaderSync):
(WebCore::FileReaderSync::readAsArrayBuffer):
(WebCore::FileReaderSync::readAsBinaryString):
(WebCore::FileReaderSync::readAsText):
(WebCore::FileReaderSync::readAsDataURL):
(WebCore::FileReaderSync::startLoading):

  • fileapi/FileReaderSync.h:
  • fileapi/FileReaderSync.idl:
  • html/canvas/ArrayBuffer.cpp:

(WebCore::ArrayBuffer::create):

  • html/canvas/ArrayBuffer.h:
  • loader/ThreadableLoaderClient.h:

LayoutTests:

  • fast/files/read-file-async-expected.txt:
  • fast/files/resources/read-common.js:

(readBlobAsArrayBuffer):
(_readBlobAsArrayBufferAsync):
(_readBlobAsArrayBufferSync):
(_readBlobAsBinaryStringSync):
(_readBlobAsTextSync):
(_readBlobAsDataURLSync):
(logResult):
(loaded):
(_toString):
(_isASCIIString):
(_toHexadecimal):
(_getElementAt):

  • fast/files/resources/read-file-test-cases.js:

(testReadingNonExistentFileAsArrayBuffer):
(testReadingEmptyFileAsArrayBuffer):
(testReadingUTF8EncodedFileAsArrayBuffer):
(testReadingBinaryFileAsArrayBuffer):
(testMultipleReads):

  • fast/files/workers/resources/worker-read-file-sync.js:

(testMultipleReadsSync):

  • fast/files/workers/worker-read-blob-sync-expected.txt:
  • fast/files/workers/worker-read-file-async-expected.txt:
  • fast/files/workers/worker-read-file-sync-expected.txt:
11:00 Changeset [70903] by aroben@apple.com

Build fix when Carbon plugins are disabled

  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:

(WebKit::NetscapePlugin::platformHandleMouseEvent):

10:57 Changeset [70902] by aroben@apple.com

Windows build fix

  • WebKitPrefix.h: Touched to force a rebuild.
10:53 Changeset [70901] by jer.noble@apple.com

2010-10-27 Jer Noble <jer.noble@apple.com>

Reviewed by Darin Adler.

Full screen video in Safari (still) exits full-screen if you switch to another
app on a multi-display system.
https://bugs.webkit.org/show_bug.cgi?id=47364
<rdar://problem/8382299>


The FullScreen window does not technically close when it deactivates, but the
two NSWindows that make up the FullScreen feature should not hide when deactivated.


  • WebView/WebVideoFullscreenController.mm: (createBackgroundFullscreenWindow): Do not set hidesOnDeactivate. (-[WebVideoFullscreenWindow initWithContentRect:styleMask:backing:defer:]): Ditto.
  • WebView/WebVideoFullscreenHUDWindowController.mm: (-[WebVideoFullscreenHUDWindow initWithContentRect:styleMask:backing:defer:]): Ditto.
10:50 Changeset [70900] by jschuh@chromium.org

Merge 70065 - 2010-10-19 Eric Carlson <eric.carlson@apple.com>

Not reviewed. Build fix.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::selectNextSourceChild): Initialize variable to avoid Windows "potentially uninitialized local variable" warning.

BUG=59593
TBR=jschuh@chromium.org

10:47 Changeset [70899] by jschuh@chromium.org

Merge 70063 - 2010-10-19 Eric Carlson <eric.carlson@apple.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=46763
CRASH in WebCore::ThreadTimers::sharedTimerFiredInternal

Fix crashes caused by moving and deleting <source> element(s) of active media element.

Tests: media/video-source-moved.html

media/video-source-removed.html

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement): Add logging. Initialize selectNextSourceChild. (WebCore::HTMLMediaElement::~HTMLMediaElement): Ditto. (WebCore::HTMLMediaElement::insertedIntoDocument): Ditto. (WebCore::HTMLMediaElement::removedFromDocument): Ditto. (WebCore::HTMLMediaElement::scheduleLoad): Ditto. (WebCore::HTMLMediaElement::setNetworkState): Deal with m_currentSourceNode being null when the media engine signals a failure by skipping the error message and continuing as usual. (WebCore::HTMLMediaElement::setVolume): Fix logging typo. (WebCore::HTMLMediaElement::havePotentialSourceChild): Save and restore m_nextChildNodeToConsider around call to selectNextSourceChild because they are both significant. (WebCore::HTMLMediaElement::selectNextSourceChild): Use m_nextChildNodeToConsider to pick the first node to consider. Bail immediately if it signals that we have already processed every <source> node. Stach the node following the current source element in m_nextChildNodeToConsider so we can resume the search even if m_currentSourceNode is removed while it is being processed. (WebCore::HTMLMediaElement::sourceWasAdded): New, move logic from HTMLSourceElement::insertedIntoTree here and correct it to deal with a <source> node being inserted immediately after the current <source> node and a new <source> node being inserted at the end of the list after all candidates have failed. (WebCore::HTMLMediaElement::sourceWillBeRemoved): New, deal with current source node and next potential node being removed.
  • html/HTMLMediaElement.h: (WebCore::HTMLMediaElement::sourceChildEndOfListValue): New, define sentinal value used to indicate that all nodes have been processed.
  • html/HTMLSourceElement.cpp: (WebCore::HTMLSourceElement::HTMLSourceElement): Add logging. (WebCore::HTMLSourceElement::insertedIntoTree): Call mediaElement->sourceWasAdded instead of having logic here. (WebCore::HTMLSourceElement::willRemove): New, call mediaElement->sourceWillBeRemoved (WebCore::HTMLSourceElement::scheduleErrorEvent): Add logging. (WebCore::HTMLSourceElement::cancelPendingErrorEvent): Add logging.
  • html/HTMLSourceElement.h:

2010-10-19 Eric Carlson <eric.carlson@apple.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=46763
CRASH in WebCore::ThreadTimers::sharedTimerFiredInternal

Test moving and deleting <source> element(s) of active <video>.

  • media/media-file.js: (mimeTypeForExtension): New, added to make it possible to set 'type' attribute on <source>.
  • media/video-source-moved-expected.txt: Added.
  • media/video-source-moved.html: Added.
  • media/video-source-removed-expected.txt: Added.
  • media/video-source-removed.html: Added.

BUG=59593
TBR=jschuh@chromium.org

10:45 Changeset [70898] by aroben@apple.com

Move NPRuntime-related files into WebProcess/Plugins/Netscape

Fixes <http://webkit.org/b/48645>.

Reviewed by Anders Carlsson.

  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:

Updated the files' paths.

  • WebProcess/Plugins/Netscape/JSNPMethod.cpp: Renamed from WebKit2/WebProcess/Plugins/JSNPMethod.cpp.
  • WebProcess/Plugins/Netscape/JSNPMethod.h: Renamed from WebKit2/WebProcess/Plugins/JSNPMethod.h.
  • WebProcess/Plugins/Netscape/JSNPObject.cpp: Renamed from WebKit2/WebProcess/Plugins/JSNPObject.cpp.
  • WebProcess/Plugins/Netscape/JSNPObject.h: Renamed from WebKit2/WebProcess/Plugins/JSNPObject.h.
  • WebProcess/Plugins/Netscape/NPJSObject.cpp: Renamed from WebKit2/WebProcess/Plugins/NPJSObject.cpp.
  • WebProcess/Plugins/Netscape/NPJSObject.h: Renamed from WebKit2/WebProcess/Plugins/NPJSObject.h.
  • WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp: Renamed from WebKit2/WebProcess/Plugins/NPRuntimeObjectMap.cpp.
  • WebProcess/Plugins/Netscape/NPRuntimeObjectMap.h: Renamed from WebKit2/WebProcess/Plugins/NPRuntimeObjectMap.h.
  • WebProcess/Plugins/Netscape/NPRuntimeUtilities.cpp: Renamed from WebKit2/WebProcess/Plugins/NPRuntimeUtilities.cpp.
  • WebProcess/Plugins/Netscape/NPRuntimeUtilities.h: Renamed from WebKit2/WebProcess/Plugins/NPRuntimeUtilities.h.
10:44 Changeset [70897] by jschuh@chromium.org

Merge 69514 - 2010-10-11 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by Eric Carlson.

CRASH at WebCore::HTMLSourceElement::scheduleErrorEvent
https://bugs.webkit.org/show_bug.cgi?id=46777

Another case that could lead to an improper set of states between
m_currentNode and m_loadingState. Also added an ASSERT and early
return to prevent crashes if this case can still happen in other ways.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::prepareForLoad):

BUG=59593
TBR=jschuh@chromium.org

10:32 Changeset [70896] by tony@chromium.org

2010-10-29 Tony Chang <tony@chromium.org>

Unreviewed, rolling out r70850.
http://trac.webkit.org/changeset/70850
https://bugs.webkit.org/show_bug.cgi?id=45640

chromium and qt pixel test regressions

  • dom/Document.cpp:
  • dom/Document.h:
  • page/FrameView.cpp: (WebCore::FrameView::invalidateRect): (WebCore::FrameView::repaintContentRectangle): (WebCore::FrameView::doDeferredRepaints):
  • page/FrameView.h:
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintContents):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintLayer):
10:28 Changeset [70895] by zmo@google.com

2010-10-29 Zhenyao Mo <zmo@google.com>

Unreviewed, webgl test expectations update.

  • platform/chromium/test_expectations.txt:
10:23 Changeset [70894] by ap@apple.com

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=48576
Let WebKit2 client know when a frame is a frameset

This can change in two cases, when document changes, and when frame is navigated to another
document.

10:22 Changeset [70893] by andersca@apple.com

Connection::sendSyncMessage needs to dispatch incoming sync messages
https://bugs.webkit.org/show_bug.cgi?id=48606

Reviewed by Adam Roben.

  • Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::sendSyncMessage):
Protect the connection when waiting for a reply. Schedule for any remaining incoming sync messages
to be sent once the bottom-most waitForSyncReply calls returns.

(CoreIPC::Connection::waitForSyncReply):
Make sure to dispatch any incoming sync messages.

(CoreIPC::Connection::processIncomingMessage):
If the incoming message is a sync message and we're waiting for a sync reply, add the message to the
queue of "sync messages received while waiting for sync reply" and wake up the client thread.

  • Platform/CoreIPC/Connection.h:
10:06 Changeset [70892] by aroben@apple.com

Use IntPoint/FloatSize in WebEvent subclasses

This is nicer than passing around pairs of ints/floats.

Fixes <http://webkit.org/b/48611>.

Reviewed by Anders Carlsson.

  • Shared/WebEvent.h:
  • Shared/WebMouseEvent.cpp:
  • Shared/WebPlatformTouchPoint.cpp:
  • Shared/WebWheelEvent.cpp:

Changed all x/y pairs to either use IntPoint or FloatSize, as
appropriate.

  • Shared/WebEventConversion.cpp:
  • Shared/mac/WebEventFactory.mm:
  • Shared/qt/WebEventFactoryQt.cpp:
  • Shared/win/WebEventFactory.cpp:
  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
  • WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:

Updated for WebEvent changes.

10:05 Changeset [70891] by mnaganov@chromium.org

2010-10-29 Mikhail Naganov <mnaganov@chromium.org>

[Chromium] Unreviewed test_expectations update.

Fix a duplicate for Mac, address r70887 tests miss.y

  • platform/chromium/test_expectations.txt:
10:01 Changeset [70890] by aroben@apple.com

Touch WebKit2Prefix.h to fix incremental builds on Windows

  • WebKit2Prefix.h:
09:59 Changeset [70889] by aroben@apple.com

Instruct developers to install the Feburary 2010 DirectX SDK, not just any version

The February 2010 SDK is the last one with support for Visual Studio
2005.

I also removed some unnecessary instructions regarding the DirectX
SDK.

Fixes <http://webkit.org/b/48642> webkit.org should recommend a
specific version of the DirectX SDK

Reviewed by Steve Falkenburg.

  • building/tools.html:
09:57 Changeset [70888] by jocelyn.turcotte@nokia.com

2010-10-29 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>

Reviewed by Andreas Kling.

[Qt] Fix tst_QWebFrame on XVFB.
https://bugs.webkit.org/show_bug.cgi?id=48637

These tests relied on a window manager to activate the window.

Fixes:

  • tst_QWebFrame::popupFocus()
  • tst_QwebFrame::inputFieldFocus()
  • tests/qwebframe/tst_qwebframe.cpp:
09:37 Changeset [70887] by jorlow@chromium.org

2010-10-29 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Steve Block.

Add IndexedDB test/tutorial
https://bugs.webkit.org/show_bug.cgi?id=48067

This document is useful in terms of demonstrating IndexedDB and
documenting what we do and don't support currently, since I'll be
maintaining it for at least some time.

  • storage/indexeddb/tutorial-expected.txt: Added.
  • storage/indexeddb/tutorial.html: Added.
09:31 Changeset [70886] by mrobinson@webkit.org

2010-10-29 Nicolas Dufresne <nicolas.dufresne@collabora.co.uk>

Reviewed by Martin Robinson.

Enable popup window in GtkLauncher
https://bugs.webkit.org/show_bug.cgi?id=48335

The GtkLauncher application does not support opening new window when
a link with "target=_blank" is clicked or similar call to
window.open(). Instead, GtkLauncher does nothing which breaks
navigation of some websites.

  • GtkLauncher/main.c: (activate_uri_entry_cb): (update_title): (link_hover_cb): (notify_title_cb): (notify_load_status_cb): (notify_progress_cb): (destroy_cb): (go_back_cb): (go_forward_cb): (create_web_view_cb): (web_view_ready_cb): (close_web_view_cb): (create_browser): (create_statusbar): (create_toolbar): (create_window): (main):
09:27 Changeset [70885] by aroben@apple.com

Remove unnecessary #includes from WebEvent.h

Fixes <http://webkit.org/b/48609> WebEvent.h #includes things it
doesn't need

Reviewed by Sam Weinig.

  • Scripts/webkit2/messages.py:

(MessageReceiver.iterparameters): Merged iterreplyparameters into this
function. All callers to iterparameters are really interested in the
reply parameters, too. This will cause us to, e.g., add
forward-declarations for types used in sync replies.
(headers_for_type): Added a special case for WebCore::KeypressCommand.

  • Scripts/webkit2/messages_unittest.py: Added a test to cover the

failing case that inspired the above changes.

  • Shared/WebEvent.h: Replaced #includes with forward-declarations.
  • Shared/API/c/WKSharedAPICast.h:
  • Shared/NativeWebKeyboardEvent.h:
  • Shared/WebEvent.cpp:
  • Shared/WebKeyboardEvent.cpp:
  • Shared/WebMouseEvent.cpp:
  • Shared/WebPlatformTouchPoint.cpp:
  • Shared/WebTouchEvent.cpp:
  • Shared/WebWheelEvent.cpp:
  • UIProcess/LayerBackedDrawingAreaProxy.cpp:
  • UIProcess/WebUIClient.cpp:
  • UIProcess/WebUIClient.h:
  • WebProcess/WebPage/FindController.cpp:
  • WebProcess/WebPage/mac/WebPageMac.mm:

Added now-needed #includes and declarations.

08:45 Changeset [70884] by ossy@webkit.org

Unreviewed fix. Touch WebCorePrefix.h to fix incremental build failure after r70878.

  • WebCorePrefix.h:
08:45 Changeset [70883] by aroben@apple.com

Teach check-webkit-style about WebKit2's idiosyncracies

Fixes <http://webkit.org/b/48638> Style bot complains about a number
of WebKit2 conventions

Reviewed by Anders Carlsson.

  • Scripts/webkitpy/style/checker.py: Excluded some rules for various

WebKit2-related files. Also updated the excluded rules for
WebKitAPITest to match the current code.

08:41 Changeset [70882] by mnaganov@chromium.org

2010-10-29 Mikhail Naganov <mnaganov@chromium.org>

[Chromium] Unreviewed test_expectations fix.

Remove duplicate for body-propagation\overflow\004-xhtml.xhtml.

  • platform/chromium/test_expectations.txt:
08:39 Changeset [70881] by commit-queue@webkit.org

2010-10-29 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Handle surrogate pairs in TextBreakIteratorGtk
https://bugs.webkit.org/show_bug.cgi?id=48227

TextBreakIteratorGtk uses UTF-8 because it's what pango expects, but we
need to return indices for the given input string that are in UTF-16.
The number of characters is the same for both UTF-16 and UTF-8 except when
the input string contains surrogate pairs. We need to keep both, the
index for the UTF-8 string to be used internally, and the index for the
UTF-16 string to be used as return value of the iterator interface. It
fixes test fast/forms/textarea-maxlength.html

  • platform/text/gtk/TextBreakIteratorGtk.cpp: (WebCore::CharacterIterator::getText): (WebCore::CharacterIterator::getLength): (WebCore::CharacterIterator::getSize): (WebCore::CharacterIterator::getIndex): (WebCore::CharacterIterator::getUTF16Index): (WebCore::CharacterIterator::getUTF16Length): (WebCore::CharacterIterator::characterSize): (WebCore::CharacterIterator::setText): (WebCore::CharacterIterator::setIndex): (WebCore::CharacterIterator::setUTF16Index): (WebCore::CharacterIterator::first): (WebCore::CharacterIterator::last): (WebCore::CharacterIterator::next): (WebCore::CharacterIterator::previous): (WebCore::setUpIterator): (WebCore::textBreakFirst): (WebCore::textBreakLast): (WebCore::textBreakNext): (WebCore::textBreakPrevious): (WebCore::textBreakPreceding): (WebCore::textBreakFollowing): (WebCore::textBreakCurrent): (WebCore::isTextBreak):
08:34 Changeset [70880] by apavlov@chromium.org

2010-10-29 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [REGRESSION] Addition of a new (blank) style property does not work
https://bugs.webkit.org/show_bug.cgi?id=48631

Test: inspector/styles-add-blank-property.html

WebCore:

  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertiesSection.prototype.addNewBlankProperty): (WebInspector.ComputedStylePropertiesSection.prototype.onpopulate):

LayoutTests:

  • inspector/styles-add-blank-property-expected.txt: Added.
  • inspector/styles-add-blank-property.html: Added.
08:25 Changeset [70879] by pfeldman@chromium.org

2010-10-29 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: add close button to network view, make tests pass for
resource manager on all ports.
https://bugs.webkit.org/show_bug.cgi?id=48628

  • inspector/InspectorController.cpp: (WebCore::InspectorController::didCommitLoad): (WebCore::InspectorController::frameDetachedFromParent): (WebCore::InspectorController::didLoadResourceFromMemoryCache): (WebCore::InspectorController::identifierForInitialRequest): (WebCore::InspectorController::willSendRequest): (WebCore::InspectorController::markResourceAsCached): (WebCore::InspectorController::didReceiveResponse): (WebCore::InspectorController::didReceiveContentLength): (WebCore::InspectorController::didFinishLoading): (WebCore::InspectorController::didFailLoading): (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest): (WebCore::InspectorController::scriptImported): (WebCore::InspectorController::didCreateWebSocket): (WebCore::InspectorController::willSendWebSocketHandshakeRequest): (WebCore::InspectorController::didReceiveWebSocketHandshakeResponse): (WebCore::InspectorController::didCloseWebSocket):
  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel):
  • inspector/front-end/ResourceManager.js: (WebInspector.ResourceTreeModel.prototype.didCommitLoadForFrame):
  • inspector/front-end/StoragePanel.js: (WebInspector.StoragePanel.prototype.addResourceToFrame):
  • inspector/front-end/inspector.js: (WebInspector._createPanels):
  • inspector/front-end/networkPanel.css: (.network-close-button):

2010-10-29 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: add close button to network view, make tests pass
for resource manager on all ports.
https://bugs.webkit.org/show_bug.cgi?id=48628

  • src/js/Tests.js:

2010-10-29 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: add close button to network view, make tests pass
for resource manager on all ports.
https://bugs.webkit.org/show_bug.cgi?id=48628

  • inspector/audits-panel-functional.html:
08:23 Changeset [70878] by ossy@webkit.org

Fix and cleanup of build systems
https://bugs.webkit.org/show_bug.cgi?id=48342

Reviewed by Adam Roben and David Kilzer.

.:

  • cmake/OptionsEfl.cmake: Remove unnecessary ENABLE_SANDBOX.
  • cmakeconfig.h.cmake:
  • configure.ac:

JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig: Add missing ENABLE_FULLSCREEN_API

WebKit/chromium:

  • features.gypi: Remove unnecessary ENABLE_SANDBOX.

WebKit/mac:

  • Configurations/FeatureDefines.xcconfig: Remove unnecessary ENABLE_SANDBOX.

WebKit2:

  • Configurations/FeatureDefines.xcconfig: Remove unnecessary ENABLE_SANDBOX and add missing features.

WebKitLibraries:

Remove unnecessary ENABLE_SANDBOX.
Add missing features to converge to FeatureDefines.xcconfig.

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:

WebKitTools:

  • Scripts/build-webkit:
    • Remove unnecessary ENABLE_SANDBOX option.
    • Add ENABLE_FULLSCREEN_API option.
08:19 Changeset [70877] by mnaganov@chromium.org

2010-10-29 Mikhail Naganov <mnaganov@chromium.org>

[Chromium] Unreviewed test expectations update.

Add 4 more suspicious tests to bug 48634.
https://bugs.webkit.org/show_bug.cgi?id=48634

  • platform/chromium/test_expectations.txt:
07:43 Changeset [70876] by aroben@apple.com

Update Windows test results after r70854

  • platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/win/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/win/fast/dom/prototype-inheritance-expected.txt:
  • platform/win/fast/js/global-constructors-expected.txt:
07:33 Changeset [70875] by mnaganov@chromium.org

2010-10-29 Mikhail Naganov <mnaganov@chromium.org>

[Chromium] Unreviewed, disable tests after r70867.

https://bugs.webkit.org/show_bug.cgi?id=48635

  • platform/chromium/test_expectations.txt:
07:19 Changeset [70874] by mnaganov@chromium.org

2010-10-29 Mikhail Naganov <mnaganov@chromium.org>

[Chromium] Unreviewed, disable tests.

https://bugs.webkit.org/show_bug.cgi?id=48634

  • platform/chromium/test_expectations.txt:
06:52 Changeset [70873] by mnaganov@chromium.org

2010-10-29 Mikhail Naganov <mnaganov@chromium.org>

[Chromium] Unreviewed rebaselines, probably leftover from r70858.

  • platform/chromium-mac/fast/images/icon-decoding-expected.checksum: Added.
  • platform/chromium-mac/fast/images/icon-decoding-expected.txt: Added.
  • platform/chromium-mac/fast/images/pdf-as-background-expected.checksum: Added.
  • platform/chromium-mac/fast/images/pdf-as-background-expected.png: Added.
  • platform/chromium-mac/svg/custom/createImageElement-expected.checksum: Added.
  • platform/chromium-mac/svg/custom/createImageElement-expected.png: Added.
06:50 Changeset [70872] by zimmermann@webkit.org

2010-10-29 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Convert SVGAnimatedEnumeration/Integer to the new SVGAnimatedPropertyTearOff concept
https://bugs.webkit.org/show_bug.cgi?id=48623

Besides converting SVGAnimatedEnumeration/Integer to the new animated property tear off concept, fix support
for multiple wrappers within the new concept, which was broken - covered by existing svg/dynamic-updates/ tests.

Replace all 'extern char[]' usage when using the multiple wrappers macro, by static AtomicStrings.

  • GNUmakefile.am: Add SVGAnimatedEnumeration.h / SVGAnimatedInteger.h to build.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • bindings/scripts/CodeGenerator.pm: Recognize SVGAnimatedEnumeration / SVGAnimatedInteger as animated types using the new concept.
  • bindings/scripts/CodeGeneratorObjC.pm: Touched, to force regenerating ObjC bindings, dependency tracking is obviously broken.
  • svg/DeprecatedSVGAnimatedPropertyTraits.h: Remove SVGAnimatedBoolean/Enumeration/Integer handling.
  • svg/DeprecatedSVGAnimatedTemplate.h: Ditto.
  • svg/SVGAnimatedEnumeration.h: Added.
  • svg/SVGAnimatedEnumeration.idl:
  • svg/SVGAnimatedInteger.h: Added.
  • svg/SVGClipPathElement.h: Adapted all code to create new style animated property tear offs for long & int types.
  • svg/SVGComponentTransferFunctionElement.h:
  • svg/SVGFEBlendElement.h:
  • svg/SVGFEColorMatrixElement.h:
  • svg/SVGFECompositeElement.h:
  • svg/SVGFEConvolveMatrixElement.h:
  • svg/SVGFEDiffuseLightingElement.cpp: (WebCore::SVGFEDiffuseLightingElement::kernelUnitLengthXIdentifier): Replaced extern[] char hack using a static AtomicString. (WebCore::SVGFEDiffuseLightingElement::kernelUnitLengthYIdentifier): Ditto.
  • svg/SVGFEDiffuseLightingElement.h:
  • svg/SVGFEDisplacementMapElement.h:
  • svg/SVGFEGaussianBlurElement.cpp: (WebCore::SVGFEGaussianBlurElement::stdDeviationXIdentifier): Ditto. (WebCore::SVGFEGaussianBlurElement::stdDeviationYIdentifier): Ditto.
  • svg/SVGFEGaussianBlurElement.h:
  • svg/SVGFEMorphologyElement.h:
  • svg/SVGFESpecularLightingElement.cpp: (WebCore::SVGFESpecularLightingElement::kernelUnitLengthXIdentifier): Ditto. (WebCore::SVGFESpecularLightingElement::kernelUnitLengthYIdentifier): Ditto.
  • svg/SVGFESpecularLightingElement.h:
  • svg/SVGFETurbulenceElement.cpp: (WebCore::SVGFETurbulenceElement::baseFrequencyXIdentifier): Ditto. (WebCore::SVGFETurbulenceElement::baseFrequencyYIdentifier): Ditto.
  • svg/SVGFETurbulenceElement.h:
  • svg/SVGFilterElement.cpp: (WebCore::SVGFilterElement::filterResXIdentifier): Ditto. (WebCore::SVGFilterElement::filterResYIdentifier): Ditto.
  • svg/SVGFilterElement.h:
  • svg/SVGGradientElement.h:
  • svg/SVGMarkerElement.cpp: (WebCore::SVGMarkerElement::orientTypeIdentifier): Ditto. (WebCore::SVGMarkerElement::orientAngleIdentifier): Ditto.
  • svg/SVGMarkerElement.h:
  • svg/SVGMaskElement.h:
  • svg/SVGPatternElement.h:
  • svg/SVGTextContentElement.h:
  • svg/SVGTextPathElement.h:
  • svg/properties/SVGAnimatedPropertyMacros.h: Add new macro for multiple wrappers using static properties.
06:45 Changeset [70871] by aroben@apple.com

Switch the Windows WebKit2 bot to the Release configuration

We only have one machine testing WebKit2 on Windows right now, and
Debug is just too slow for it to keep up.

Fixes (hopefully!) <http://webkit.org/b/48615> Windows WebKit2 bot is
always way behind

Reviewed by Jon Honeycutt.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
06:44 Changeset [70870] by andreas.kling@nokia.com

2010-10-29 Andreas Kling <kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Make GraphicsContext cheaper to construct
https://bugs.webkit.org/show_bug.cgi?id=48626

Do less unnecessary things when creating the Qt GraphicsContext:

  • Don't create a black QBrush that's immediately discarded.
  • Don't call setPlatform*(), set the painter brush and pen directly.
  • Call setRenderHints() once instead of multiple setRenderHint().
  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate): (WebCore::GraphicsContext::GraphicsContext):
06:41 Changeset [70869] by satish@chromium.org

Merge 70644 - 2010-10-27 Satish Sampath <satish@chromium.org>

Reviewed by Steve Block.

Add runtime flag check before enabling speech input in code.
https://bugs.webkit.org/show_bug.cgi?id=48426

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::isSpeechEnabled): Added runtime flag check.

TBR=satish@chromium.org
Review URL: http://codereview.chromium.org/4111010

06:39 Changeset [70868] by andreas.kling@nokia.com

2010-10-29 Andreas Kling <kling@webkit.org>

Reviewed by Simon Hausmann.

[Qt] GraphicsLayer: Don't notifySyncRequired() more than necessary
https://bugs.webkit.org/show_bug.cgi?id=48624

Don't queue multiple meta method invocations for notifySyncRequired()

4% speedup on <http://ariya.github.com/clock.htm>

  • platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::GraphicsLayerQtImpl::GraphicsLayerQtImpl): (WebCore::GraphicsLayerQtImpl::notifySyncRequired): (WebCore::GraphicsLayerQtImpl::notifyChange):
06:35 Changeset [70867] by zmo@google.com

2010-10-29 Zhenyao Mo <zmo@google.com>

Reviewed by Chris Marrin.

drawArrays/drawElements with first/offset out of range but size==0 should generate no error
https://bugs.webkit.org/show_bug.cgi?id=48601

  • fast/canvas/webgl/draw-arrays-out-of-bounds-expected.txt:
  • fast/canvas/webgl/draw-arrays-out-of-bounds.html:
  • fast/canvas/webgl/draw-elements-out-of-bounds-expected.txt:
  • fast/canvas/webgl/draw-elements-out-of-bounds.html:

2010-10-29 Zhenyao Mo <zmo@google.com>

Reviewed by Chris Marrin.

drawArrays/drawElements with first/offset out of range but size==0 should generate no error
https://bugs.webkit.org/show_bug.cgi?id=48601

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::drawArrays): (WebCore::WebGLRenderingContext::drawElements):
06:26 Changeset [70866] by mnaganov@chromium.org

2010-10-29 Mikhail Naganov <mnaganov@chromium.org>

[Chromium] Unreviewed tests checksums update. Also, fix duplicates introduced in r70865.

  • platform/chromium-mac/fast/blockflow/background-horizontal-bt-expected.checksum: Added.
  • platform/chromium-mac/fast/blockflow/background-vertical-lr-expected.checksum: Added.
  • platform/chromium-mac/fast/blockflow/background-vertical-rl-expected.checksum: Added.
  • platform/chromium/test_expectations.txt:
06:06 Changeset [70865] by mnaganov@chromium.org

2010-10-29 Mikhail Naganov <mnaganov@chromium.org>

[Chromium] Unreviewed test expectations update.

https://bugs.webkit.org/show_bug.cgi?id=48627

  • platform/chromium/test_expectations.txt:
05:08 Changeset [70864] by mnaganov@chromium.org

2010-10-29 Mikhail Naganov <mnaganov@chromium.org>

[Chromium] Unreviewed tests rebaselines after r70843, r70847, r70856

  • platform/chromium-linux/fast/blockflow/border-radius-clipping-vertical-lr-expected.checksum: Added.
  • platform/chromium-linux/fast/blockflow/border-radius-clipping-vertical-lr-expected.png: Added.
  • platform/chromium-linux/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.checksum:
  • platform/chromium-linux/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.png:
  • platform/chromium-linux/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.checksum:
  • platform/chromium-linux/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.png:
  • platform/chromium-linux/fast/dom/HTMLMeterElement/meter-boundary-values-expected.checksum: Added.
  • platform/chromium-linux/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png: Added.
  • platform/chromium-linux/fast/dom/HTMLMeterElement/meter-optimums-expected.checksum:
  • platform/chromium-linux/fast/dom/HTMLMeterElement/meter-optimums-expected.png:
  • platform/chromium-mac/fast/blockflow/border-radius-clipping-vertical-lr-expected.checksum: Added.
  • platform/chromium-mac/fast/blockflow/box-shadow-vertical-lr-expected.checksum:
  • platform/chromium-mac/fast/blockflow/box-shadow-vertical-rl-expected.checksum:
  • platform/chromium-mac/fast/dom/HTMLMeterElement/meter-boundary-values-expected.checksum: Added.
  • platform/chromium-win/fast/blockflow/border-radius-clipping-vertical-lr-expected.checksum: Added.
  • platform/chromium-win/fast/blockflow/border-radius-clipping-vertical-lr-expected.png: Added.
  • platform/chromium-win/fast/blockflow/border-radius-clipping-vertical-lr-expected.txt: Added.
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.checksum:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.png:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.checksum:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.png:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-boundary-values-expected.checksum: Added.
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png: Added.
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-boundary-values-expected.txt: Added.
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-optimums-expected.checksum:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-optimums-expected.png:
05:00 Changeset [70863] by satish@chromium.org

2010-10-29 Leandro Gracia Gil <leandrogracia@google.com>

Reviewed by Jeremy Orlow.

Added a layout test for the language tag in speech input. Updated
the speech button tests to include the new language parameter in the
mock result.
https://bugs.webkit.org/show_bug.cgi?id=47089

  • fast/speech/input-text-language-tag-expected.txt: Added.
  • fast/speech/input-text-language-tag.html: Added.
  • fast/speech/input-text-speechbutton.html:
  • fast/speech/speech-button-ignore-generated-events.html:
  • platform/chromium/test_expectations.txt:

2010-10-29 Leandro Gracia Gil <leandrogracia@google.com>

Reviewed by Jeremy Orlow.

Patch the current speech input implementation to use the nearest
language tag. The language is now passed to the startRecognition
methods so that language-specific recognition could be used. Also added
a second parameter to setMockSpeechInputResult for the language used in
speech recognition.
https://bugs.webkit.org/show_bug.cgi?id=47089

This is the 2nd of a 4-sided patch in Chromium and WebKit. For more
details see http://codereview.chromium.org/3615005/show,
http://codereview.chromium.org/3595018/show and
https://bugs.webkit.org/show_bug.cgi?id=47420.

Test: fast/speech/input-text-language-tag.html

  • page/SpeechInput.cpp: (WebCore::SpeechInput::startRecognition):
  • page/SpeechInput.h:
  • page/SpeechInputClient.h:
  • platform/mock/SpeechInputClientMock.cpp: (WebCore::SpeechInputClientMock::startRecognition): (WebCore::SpeechInputClientMock::setRecognitionResult): (WebCore::SpeechInputClientMock::timerFired):
  • platform/mock/SpeechInputClientMock.h:
  • rendering/TextControlInnerElements.cpp: (WebCore::TextControlInnerElement::attachInnerElement): (WebCore::SearchFieldCancelButtonElement::detach): (WebCore::SpinButtonElement::defaultEventHandler): (WebCore::InputFieldSpeechButtonElement::defaultEventHandler): (WebCore::InputFieldSpeechButtonElement::detach):

2010-10-29 Leandro Gracia Gil <leandrogracia@google.com>

Reviewed by Jeremy Orlow.

Patch the current speech input implementation to use the nearest
language tag. The language is now passed to the startRecognition
methods so that language-specific recognition could be used. Also added
a second parameter to setMockSpeechInputResult for the language used in
speech recognition.
https://bugs.webkit.org/show_bug.cgi?id=47089

This is the 2nd of a 4-sided patch in Chromium and WebKit. For more
details see http://codereview.chromium.org/3615005/show,
http://codereview.chromium.org/3595018/show and
https://bugs.webkit.org/show_bug.cgi?id=47420.

  • public/WebSpeechInputController.h: (WebKit::WebSpeechInputController::startRecognition):
  • public/WebSpeechInputControllerMock.h:
  • src/SpeechInputClientImpl.cpp: (WebKit::SpeechInputClientImpl::create): (WebKit::SpeechInputClientImpl::startRecognition):
  • src/SpeechInputClientImpl.h:
  • src/WebSpeechInputControllerMockImpl.cpp: (WebKit::WebSpeechInputControllerMockImpl::setMockRecognitionResult): (WebKit::WebSpeechInputControllerMockImpl::startRecognition):
  • src/WebSpeechInputControllerMockImpl.h:
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::WebViewImpl):
  • src/WebViewImpl.h:

2010-10-29 Leandro Gracia Gil <leandrogracia@google.com>

Reviewed by Jeremy Orlow.

Added a second parameter to setMockSpeechInputResult for
the language used in speech input.
https://bugs.webkit.org/show_bug.cgi?id=47089

  • DumpRenderTree/LayoutTestController.cpp: (setMockSpeechInputResultCallback):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::setMockSpeechInputResult):
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setMockSpeechInputResult):
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setMockSpeechInputResult):
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setMockSpeechInputResult):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setMockSpeechInputResult):
  • DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::setMockSpeechInputResult): (LayoutTestController::pageSizeAndMarginsInPixels):
04:50 Changeset [70862] by ager@chromium.org

2010-10-29 Mads Ager <ager@chromium.org>

Reviewed by Pavel Feldman.

[V8] The DateExtension cannot handle overwritten Date
https://bugs.webkit.org/show_bug.cgi?id=48621

Check that the Date property is an object before attempting to get
hidden properties from it.

Test: fast/dom/Window/slow-unload-handler-overwritten-date.html

  • bindings/v8/DateExtension.cpp: (WebCore::DateExtension::setAllowSleep):

2010-10-29 Mads Ager <ager@chromium.org>

Reviewed by Pavel Feldman.

[V8] The DateExtension cannot handle overwritten Date
https://bugs.webkit.org/show_bug.cgi?id=48621

  • fast/dom/Window/resources/slow-unload-handler-overwritten-date1.html: Added.
  • fast/dom/Window/slow-unload-handler-overwritten-date-expected.txt: Added.
  • fast/dom/Window/slow-unload-handler-overwritten-date.html: Added.
04:25 Changeset [70861] by alex@webkit.org

2010-10-29 Alejandro G. Castro <alex@igalia.com>

Reviewed by Martin Robinson.

[GTK] Add the GtkScrollablePolicy property to the webview
https://bugs.webkit.org/show_bug.cgi?id=48357

Added the GtkScrollablePolicy properties to the webview widget, it
is now required for GtkScrollable widgets in GTK+ 3.x.

  • webkit/webkitprivate.h:
  • webkit/webkitwebview.cpp: (setHorizontalScrollPolicy): Added. (setVerticalScrollPolicy): Added. (getHorizontalScrollPolicy): Added. (getVerticalScrollPolicy): Added. (webkit_web_view_get_property): (webkit_web_view_set_property): (webkit_web_view_class_init):
03:32 Changeset [70860] by zimmermann@webkit.org

2010-10-29 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed.

Oh my, remove a left-over alert(), that I accidently landed.

  • svg/dom/SVGScriptElement/resources/script-load4.js:
03:31 Changeset [70859] by tkent@chromium.org

2010-10-29 Kent Tamura <tkent@chromium.org>

Unreviewed, test expectation update.

Update Qt and GTK expectations for r70854.

  • platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/gtk/fast/dom/prototype-inheritance-expected.txt:
  • platform/gtk/fast/js/global-constructors-expected.txt:
  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-expected.txt:
  • platform/qt/fast/js/global-constructors-expected.txt:
03:11 Changeset [70858] by abarth@webkit.org

2010-10-29 Adam Barth <abarth@webkit.org>

Unreviewed.

[chromium] Chromium Mac should use WebKit's image decoders
https://bugs.webkit.org/show_bug.cgi?id=47974

Update chromium-mac expectations for new image decoders. There are a
lot of changed images here, but I think they're correct.

  • platform/chromium-mac/css2.1/t0804-c5510-padn-00-b-ag-expected.checksum:
  • platform/chromium-mac/css2.1/t0804-c5510-padn-00-b-ag-expected.png: Removed.
  • platform/chromium-mac/css2.1/t0905-c414-flt-01-d-g-expected.checksum: Added.
  • platform/chromium-mac/css2.1/t0905-c414-flt-wrap-01-d-g-expected.checksum: Added.
  • platform/chromium-mac/css2.1/t100801-c544-valgn-02-d-agi-expected.checksum: Added.
  • platform/chromium-mac/css2.1/t100801-c544-valgn-03-d-agi-expected.checksum: Added.
  • platform/chromium-mac/css2.1/t100801-c544-valgn-04-d-agi-expected.checksum: Added.
  • platform/chromium-mac/fast/backgrounds/repeat/negative-offset-repeat-expected.checksum: Added.
  • platform/chromium-mac/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.checksum:
  • platform/chromium-mac/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize01-expected.checksum: Added.
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize01-expected.png: Added.
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize05-expected.checksum: Added.
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize05-expected.png: Added.
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize06-expected.checksum: Added.
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize07-expected.checksum: Added.
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize08-expected.checksum: Added.
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize09-expected.checksum: Added.
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize10-expected.checksum: Added.
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize11-expected.checksum: Added.
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize12-expected.checksum: Added.
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize12-expected.png: Added.
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize16-expected.checksum: Added.
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize16-expected.png: Added.
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize17-expected.checksum: Added.
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize17-expected.png: Added.
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize18-expected.checksum: Added.
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize18-expected.png: Added.
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize19-expected.checksum: Added.
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize19-expected.png: Added.
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize20-expected.checksum: Added.
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize20-expected.png: Added.
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize21-expected.checksum: Added.
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize21-expected.png: Added.
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize22-expected.checksum: Added.
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize22-expected.png: Added.
  • platform/chromium-mac/fast/backgrounds/size/zero-expected.checksum: Added.
  • platform/chromium-mac/fast/backgrounds/size/zero-expected.png: Added.
  • platform/chromium-mac/fast/block/float/014-expected.checksum: Added.
  • platform/chromium-mac/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.checksum: Added.
  • platform/chromium-mac/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png: Added.
  • platform/chromium-mac/fast/borders/border-fit-expected.checksum: Added.
  • platform/chromium-mac/fast/borders/border-fit-expected.png: Added.
  • platform/chromium-mac/fast/borders/border-image-omit-right-slice-expected.checksum: Added.
  • platform/chromium-mac/fast/borders/border-image-omit-right-slice-expected.png: Added.
  • platform/chromium-mac/fast/borders/border-image-rotate-transform-expected.checksum:
  • platform/chromium-mac/fast/borders/border-image-rotate-transform-expected.png:
  • platform/chromium-mac/fast/borders/svg-as-border-image-2-expected.checksum: Added.
  • platform/chromium-mac/fast/borders/svg-as-border-image-2-expected.png: Added.
  • platform/chromium-mac/fast/borders/svg-as-border-image-expected.checksum: Added.
  • platform/chromium-mac/fast/borders/svg-as-border-image-expected.png: Added.
  • platform/chromium-mac/fast/canvas/image-pattern-rotate-expected.checksum: Added.
  • platform/chromium-mac/fast/css/background-shorthand-invalid-url-expected.checksum: Added.
  • platform/chromium-mac/fast/css/background-shorthand-invalid-url-expected.png: Added.
  • platform/chromium-mac/fast/css/contentDiv-expected.checksum: Added.
  • platform/chromium-mac/fast/css/contentDiv-expected.png: Added.
  • platform/chromium-mac/fast/css/contentDivWithChildren-expected.checksum: Added.
  • platform/chromium-mac/fast/css/contentDivWithChildren-expected.png: Added.
  • platform/chromium-mac/fast/css/contentImage-expected.checksum: Added.
  • platform/chromium-mac/fast/css/contentImage-expected.png: Added.
  • platform/chromium-mac/fast/css/value-list-out-of-bounds-crash-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/input-align-image-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/input-appearance-bkcolor-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/input-type-change-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/preserveFormDuringResidualStyle-expected.checksum: Added.
  • platform/chromium-mac/fast/images/pixel-crack-image-background-webkit-transform-scale-expected.checksum:
  • platform/chromium-mac/fast/images/pixel-crack-image-background-webkit-transform-scale-expected.png: Removed.
  • platform/chromium-mac/fast/media/mq-min-pixel-ratio-expected.checksum: Added.
  • platform/chromium-mac/fast/media/mq-min-pixel-ratio-expected.png: Added.
  • platform/chromium-mac/fast/reflections/reflection-masks-expected.checksum: Added.
  • platform/chromium-mac/fast/reflections/reflection-masks-expected.png: Added.
  • platform/chromium-mac/fast/reflections/reflection-masks-opacity-expected.checksum: Added.
  • platform/chromium-mac/fast/repaint/block-layout-inline-children-replaced-expected.checksum:
  • platform/chromium-mac/fast/repaint/block-layout-inline-children-replaced-expected.png:
  • platform/chromium-mac/fast/replaced/absolute-image-sizing-expected.checksum: Added.
  • platform/chromium-mac/fast/replaced/image-onload-expected.checksum: Added.
  • platform/chromium-mac/fast/replaced/image-sizing-expected.checksum: Added.
  • platform/chromium-mac/fast/replaced/image-tag-expected.checksum: Added.
  • platform/chromium-mac/fast/speech/input-appearance-numberandspeech-expected.checksum:
  • platform/chromium-mac/fast/speech/input-appearance-numberandspeech-expected.png:
  • platform/chromium-mac/fast/speech/input-appearance-searchandspeech-expected.checksum:
  • platform/chromium-mac/fast/speech/input-appearance-searchandspeech-expected.png:
  • platform/chromium-mac/fast/speech/input-appearance-speechbutton-expected.checksum:
  • platform/chromium-mac/fast/speech/input-appearance-speechbutton-expected.png:
  • platform/chromium-mac/http/tests/misc/slow-loading-image-in-pattern-expected.checksum:
  • platform/chromium-mac/http/tests/misc/slow-loading-image-in-pattern-expected.png:
  • platform/chromium-mac/scrollbars/listbox-scrollbar-combinations-expected.checksum: Added.
  • platform/chromium-mac/scrollbars/overflow-scrollbar-combinations-expected.checksum: Added.
  • platform/chromium-mac/scrollbars/overflow-scrollbar-combinations-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.checksum:
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-30-t-expected.checksum:
  • platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-30-t-expected.png: Removed.
  • platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-36-t-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-36-t-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-39-t-expected.checksum:
  • platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-39-t-expected.png: Removed.
  • platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-40-t-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-40-t-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-blend-01-b-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-blend-01-b-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-conv-01-f-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-displace-01-f-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-displace-01-f-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-image-01-b-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-image-01-b-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/masking-path-04-b-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/masking-path-04-b-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/render-groups-01-b-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/render-groups-01-b-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/render-groups-03-t-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/render-groups-03-t-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/struct-image-01-t-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/struct-image-03-t-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/struct-image-03-t-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/struct-image-04-t-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/struct-image-04-t-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/struct-image-06-t-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/struct-image-06-t-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/struct-image-07-t-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/struct-image-07-t-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/struct-image-08-t-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/struct-image-08-t-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/struct-image-09-t-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/struct-image-09-t-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/struct-image-10-t-expected.checksum: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/struct-image-10-t-expected.png: Added.
  • platform/chromium-mac/svg/carto.net/scrollbar-expected.checksum: Added.
  • platform/chromium-mac/svg/carto.net/scrollbar-expected.png: Added.
  • platform/chromium-mac/svg/carto.net/selectionlist-expected.checksum: Added.
  • platform/chromium-mac/svg/carto.net/selectionlist-expected.png: Added.
  • platform/chromium-mac/svg/custom/convolution-crash-expected.checksum: Added.
  • platform/chromium-mac/svg/custom/focus-ring-expected.checksum:
  • platform/chromium-mac/svg/custom/focus-ring-expected.png:
  • platform/chromium-mac/svg/custom/group-opacity-expected.checksum: Added.
  • platform/chromium-mac/svg/custom/group-opacity-expected.png: Added.
  • platform/chromium-mac/svg/custom/image-parent-translation-expected.checksum: Added.
  • platform/chromium-mac/svg/custom/image-parent-translation-expected.png: Added.
  • platform/chromium-mac/svg/custom/image-small-width-height-expected.checksum: Added.
  • platform/chromium-mac/svg/custom/image-small-width-height-expected.png: Added.
  • platform/chromium-mac/svg/custom/image-with-transform-clip-filter-expected.checksum: Added.
  • platform/chromium-mac/svg/custom/js-update-image-and-display-expected.checksum: Added.
  • platform/chromium-mac/svg/custom/js-update-image-and-display-expected.png: Added.
  • platform/chromium-mac/svg/custom/js-update-image-and-display2-expected.checksum: Added.
  • platform/chromium-mac/svg/custom/js-update-image-and-display2-expected.png: Added.
  • platform/chromium-mac/svg/custom/js-update-image-and-display3-expected.checksum: Added.
  • platform/chromium-mac/svg/custom/js-update-image-and-display3-expected.png: Added.
  • platform/chromium-mac/svg/custom/js-update-image-expected.checksum: Added.
  • platform/chromium-mac/svg/custom/js-update-image-expected.png: Added.
  • platform/chromium-mac/svg/custom/pointer-events-image-expected.checksum: Added.
  • platform/chromium-mac/svg/custom/pointer-events-image-expected.png: Added.
  • platform/chromium-mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.checksum:
  • platform/chromium-mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
  • platform/chromium-mac/svg/custom/text-image-opacity-expected.checksum: Added.
  • platform/chromium-mac/svg/custom/text-image-opacity-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.checksum:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.checksum:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.checksum:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.checksum:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.checksum:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.checksum:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.checksum:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.png: Removed.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.checksum:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.png: Removed.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.checksum:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.png: Removed.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.checksum:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.png: Removed.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.checksum:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.png: Removed.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.checksum:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.png: Removed.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.checksum:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.png: Removed.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.checksum:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.png: Removed.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.checksum:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png: Removed.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.checksum:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.png: Removed.
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-height-attr-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-height-attr-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-width-attr-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-width-attr-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-x-attr-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-x-attr-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-y-attr-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-y-attr-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.checksum:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-x-prop-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-x-prop-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-y-prop-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-y-prop-expected.png: Added.
  • platform/chromium-mac/svg/filters/feDisplacementMap-expected.checksum: Added.
  • platform/chromium-mac/svg/filters/filterRes-expected.checksum: Added.
  • platform/chromium-mac/svg/filters/filteredImage-expected.checksum: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug10565-expected.checksum: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug11026-expected.checksum: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug1188-expected.checksum: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug120107-expected.checksum: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug1271-expected.checksum: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug12908-1-expected.checksum: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug12908-2-expected.checksum: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug12910-2-expected.checksum: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug1296-expected.checksum: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug1296-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug13169-expected.checksum: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug1430-expected.checksum:
  • platform/chromium-mac/tables/mozilla/bugs/bug1430-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug14929-expected.checksum:
  • platform/chromium-mac/tables/mozilla/bugs/bug15544-expected.checksum: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug17138-expected.checksum: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug196870-expected.checksum: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug2981-2-expected.checksum:
  • platform/chromium-mac/tables/mozilla/bugs/bug4093-expected.checksum: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug4284-expected.checksum: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug4427-expected.checksum:
  • platform/chromium-mac/tables/mozilla/bugs/bug4427-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug4523-expected.checksum: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug50695-2-expected.checksum: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug56563-expected.checksum:
  • platform/chromium-mac/tables/mozilla/bugs/bug56563-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug6404-expected.checksum:
  • platform/chromium-mac/tables/mozilla/bugs/bug82946-2-expected.checksum: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug82946-2-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug86708-expected.checksum: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug97383-expected.checksum: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug97383-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/core/col_widths_auto_autoFix-expected.checksum:
  • platform/chromium-mac/tables/mozilla/core/col_widths_auto_autoFix-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/core/misc-expected.checksum: Added.
  • platform/chromium-mac/tables/mozilla/marvin/tbody_valign_baseline-expected.checksum:
  • platform/chromium-mac/tables/mozilla/marvin/tbody_valign_bottom-expected.checksum:
  • platform/chromium-mac/tables/mozilla/marvin/tbody_valign_middle-expected.checksum:
  • platform/chromium-mac/tables/mozilla/marvin/tbody_valign_top-expected.checksum:
  • platform/chromium-mac/tables/mozilla/marvin/td_valign_baseline-expected.checksum:
  • platform/chromium-mac/tables/mozilla/marvin/td_valign_bottom-expected.checksum: Added.
  • platform/chromium-mac/tables/mozilla/marvin/td_valign_middle-expected.checksum: Added.
  • platform/chromium-mac/tables/mozilla/marvin/td_valign_top-expected.checksum: Added.
  • platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_baseline-expected.checksum:
  • platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_bottom-expected.checksum:
  • platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_middle-expected.checksum:
  • platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_top-expected.checksum:
  • platform/chromium-mac/tables/mozilla/marvin/th_valign_baseline-expected.checksum: Added.
  • platform/chromium-mac/tables/mozilla/marvin/th_valign_bottom-expected.checksum: Added.
  • platform/chromium-mac/tables/mozilla/marvin/th_valign_middle-expected.checksum: Added.
  • platform/chromium-mac/tables/mozilla/marvin/th_valign_top-expected.checksum: Added.
  • platform/chromium-mac/tables/mozilla/marvin/thead_valign_baseline-expected.checksum:
  • platform/chromium-mac/tables/mozilla/marvin/thead_valign_bottom-expected.checksum:
  • platform/chromium-mac/tables/mozilla/marvin/thead_valign_middle-expected.checksum:
  • platform/chromium-mac/tables/mozilla/marvin/thead_valign_top-expected.checksum:
  • platform/chromium-mac/tables/mozilla/marvin/tr_valign_baseline-expected.checksum:
  • platform/chromium-mac/tables/mozilla/marvin/tr_valign_bottom-expected.checksum: Added.
  • platform/chromium-mac/tables/mozilla/marvin/tr_valign_middle-expected.checksum: Added.
  • platform/chromium-mac/tables/mozilla/marvin/tr_valign_top-expected.checksum: Added.
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug6933-expected.checksum: Added.
  • platform/chromium/test_expectations.txt:
    • Now that we now fail a handful of tests more consistently across platforms.
02:54 Changeset [70857] by zimmermann@webkit.org

2010-10-27 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Convert SVGAnimatedBoolean to the new SVGAnimatedPropertyTearOff concept
https://bugs.webkit.org/show_bug.cgi?id=48469

Convert the next SVG animated primitive type to use the SVGAnimatedPropertyTearOff concept: SVGAnimatedBoolean.
Added new test verifying that StrictTypeChecking is enabled for SVGAnimatedBooleans. It also tests that this type is "static", see LayoutTests/ChangeLog for details.

Add support for StrictTypeChecking for boolean types.

Test: svg/dom/SVGExternalResourcesRequired.html

  • GNUmakefile.am: Add SVGAnimatedBoolean.h and SVGAnimatedStaticPropertyTearOff.h to build.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • bindings/scripts/CodeGenerator.pm: Add SVGAnimatedBoolean to the new style svg animated bindings list.
  • bindings/scripts/CodeGeneratorJS.pm: Add StrictTypeChecking support for boolean types.
  • bindings/scripts/CodeGeneratorObjC.pm: Ditto. Only generate kit() usage for new style animated types, if the wrapped type needs a tear off.
  • bindings/scripts/CodeGeneratorV8.pm: Ditto.
  • svg/DeprecatedSVGAnimatedTemplate.h: Remove SVGAnimatedBoolean handling.
  • svg/SVGAElement.h: s/DECLARE_ANIMATED_PROPERTY/DECLARE_ANIMATED_STATIC_PROPERTY_NEW/ for boolean types everywhere. Include SVGAnimatedPropertyMacros.h where needed.
  • svg/SVGAnimatedBoolean.h: Added.
  • svg/SVGAnimatedBoolean.idl:
  • svg/SVGAnimationElement.h:
  • svg/SVGCircleElement.h:
  • svg/SVGClipPathElement.h:
  • svg/SVGCursorElement.h:
  • svg/SVGDefsElement.h:
  • svg/SVGEllipseElement.h:
  • svg/SVGExternalResourcesRequired.cpp:
  • svg/SVGExternalResourcesRequired.h: (WebCore::SVGExternalResourcesRequired::~SVGExternalResourcesRequired):
  • svg/SVGFEConvolveMatrixElement.h:
  • svg/SVGFEImageElement.h:
  • svg/SVGFilterElement.h:
  • svg/SVGFontElement.h:
  • svg/SVGForeignObjectElement.h:
  • svg/SVGGElement.h:
  • svg/SVGGradientElement.h:
  • svg/SVGImageElement.h:
  • svg/SVGLineElement.h:
  • svg/SVGMPathElement.h:
  • svg/SVGMarkerElement.h:
  • svg/SVGMaskElement.h:
  • svg/SVGPathElement.h:
  • svg/SVGPatternElement.h:
  • svg/SVGPolyElement.h:
  • svg/SVGRectElement.h:
  • svg/SVGSVGElement.h:
  • svg/SVGScriptElement.h:
  • svg/SVGSwitchElement.h:
  • svg/SVGSymbolElement.h:
  • svg/SVGTextContentElement.h:
  • svg/SVGUseElement.h:
  • svg/SVGViewElement.h:
  • svg/properties/SVGAnimatedListPropertyTearOff.h: Moved RefPtr<SVGProperty> m_baseVal/m_animVal from SVGAnimatedProperty, as SVGAnimatedStaticPropertyTearOff doesn't need them.
  • svg/properties/SVGAnimatedProperty.h: Remove m_baseVal/m_animVal. (WebCore::SVGAnimatedProperty::commitChange): New method to share code between the SVGAnimated*PropertyTearOff classes.
  • svg/properties/SVGAnimatedPropertyMacros.h: Add new DECLARE_ANIMATED_STATIC_PROPERTY_NEW macro which creates SVGAnimatedStaticPropertyTearOff types.
  • svg/properties/SVGAnimatedPropertyTearOff.h: Moved RefPtr<SVGProperty> m_baseVal/m_animVal from SVGAnimatedProperty, as SVGAnimatedStaticPropertyTearOff doesn't need them.
  • svg/properties/SVGAnimatedStaticPropertyTearOff.h: Added. (WebCore::SVGAnimatedStaticPropertyTearOff::baseVal): Directly returns the stored m_property as reference, no tear off is created. (WebCore::SVGAnimatedStaticPropertyTearOff::animVal): Ditto. (WebCore::SVGAnimatedStaticPropertyTearOff::setBaseVal): Directly updates the stored m_property reference, and invalidates the SVG attributes. (WebCore::SVGAnimatedStaticPropertyTearOff::setAnimVal): Not implemented. (WebCore::SVGAnimatedStaticPropertyTearOff::create): (WebCore::SVGAnimatedStaticPropertyTearOff::SVGAnimatedStaticPropertyTearOff):
  • svg/properties/SVGListPropertyTearOff.h: (WebCore::SVGListPropertyTearOff::commitChange): Share code, use SVGAnimatedProperty::commitChange.
  • svg/properties/SVGPropertyTearOff.h: (WebCore::SVGPropertyTearOff::commitChange): Ditto.

2010-10-27 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Convert SVGAnimatedBoolean to the new SVGAnimatedPropertyTearOff concept
https://bugs.webkit.org/show_bug.cgi?id=48469

Add simple test that SVGAnimatedBooleans aren't creating tear off when accessing baseVal/animVal.
For example with SVGLength you can do:
var foo = rect.x.baseVal; SVGRectElement -> SVGAnimatedLength -> SVGLength
foo.value = 50;
affects the SVGRectElement

For SVGExternalResourcesRequired (one of the two SVGAnimatedBoolean types), this is not possible, as baseVal returns a POD type (boolean).
var bar = rect.externalResourcesRequired.baseVal; bar is a boolean
bar = false;
does NOT effect the rect.externalResourcesRequired object

  • svg/dom/SVGExternalResourcesRequired-expected.txt: Added.
  • svg/dom/SVGExternalResourcesRequired.html: Added.
  • svg/dom/script-tests/SVGExternalResourcesRequired.js: Added.
02:47 Changeset [70856] by morrita@google.com

2010-10-28 MORITA Hajime <morrita@google.com>

Reviewed by Kent Tamura.

<meter min=0 max=100 value=100> should be optimum.
https://bugs.webkit.org/show_bug.cgi?id=48613

  • fast/dom/HTMLMeterElement/meter-boundary-values.html: Added.
  • platform/mac/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.checksum:
  • platform/mac/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.png:
  • platform/mac/fast/dom/HTMLMeterElement/meter-boundary-values-expected.checksum: Added.
  • platform/mac/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png: Added.
  • platform/mac/fast/dom/HTMLMeterElement/meter-boundary-values-expected.txt: Added.
  • platform/mac/fast/dom/HTMLMeterElement/meter-optimums-expected.checksum:
  • platform/mac/fast/dom/HTMLMeterElement/meter-optimums-expected.png:

2010-10-28 MORITA Hajime <morrita@google.com>

Reviewed by Kent Tamura.

<meter min=0 max=100 value=100> should be optimum.
https://bugs.webkit.org/show_bug.cgi?id=48613

Changed to make the condition inclusive for better case consistently.

  • Values on the border between optimum and subsequntial go optimum.
  • Values on the border between suboptimal and even-less-than-good go suboptimal.

Test: fast/dom/HTMLMeterElement/meter-boundary-values.html

  • html/HTMLMeterElement.cpp: (WebCore::HTMLMeterElement::gaugeRegion):
02:43 Changeset [70855] by mnaganov@chromium.org

2010-10-29 Mikhail Naganov <mnaganov@chromium.org>

[Chromium] Unreviewed test expectations update after r70843.

  • platform/chromium-linux/fast/blockflow/box-shadow-horizontal-bt-expected.checksum: Added.
  • platform/chromium-linux/fast/blockflow/box-shadow-horizontal-bt-expected.png: Added.
  • platform/chromium-linux/fast/blockflow/box-shadow-vertical-lr-expected.checksum: Added.
  • platform/chromium-linux/fast/blockflow/box-shadow-vertical-lr-expected.png: Added.
  • platform/chromium-linux/fast/blockflow/box-shadow-vertical-rl-expected.checksum: Added.
  • platform/chromium-linux/fast/blockflow/box-shadow-vertical-rl-expected.png: Added.
  • platform/chromium-linux/fast/blockflow/english-lr-text-expected.checksum:
  • platform/chromium-linux/fast/blockflow/english-rl-text-expected.checksum:
  • platform/chromium-linux/fast/blockflow/japanese-lr-text-expected.checksum:
  • platform/chromium-linux/fast/blockflow/japanese-lr-text-expected.png:
  • platform/chromium-linux/fast/blockflow/japanese-rl-text-expected.checksum:
  • platform/chromium-linux/fast/blockflow/japanese-rl-text-expected.png:
  • platform/chromium-mac/fast/blockflow/border-vertical-lr-expected.checksum:
  • platform/chromium-mac/fast/blockflow/box-shadow-vertical-lr-expected.checksum: Added.
  • platform/chromium-mac/fast/blockflow/box-shadow-vertical-rl-expected.checksum: Added.
  • platform/chromium-mac/fast/blockflow/english-lr-text-expected.checksum:
  • platform/chromium-mac/fast/blockflow/japanese-lr-text-expected.checksum:
  • platform/chromium-mac/fast/blockflow/japanese-rl-text-expected.checksum:
  • platform/chromium-win/fast/blockflow/box-shadow-horizontal-bt-expected.checksum: Added.
  • platform/chromium-win/fast/blockflow/box-shadow-horizontal-bt-expected.png: Added.
  • platform/chromium-win/fast/blockflow/box-shadow-horizontal-bt-expected.txt: Added.
  • platform/chromium-win/fast/blockflow/box-shadow-vertical-lr-expected.checksum: Added.
  • platform/chromium-win/fast/blockflow/box-shadow-vertical-lr-expected.png: Added.
  • platform/chromium-win/fast/blockflow/box-shadow-vertical-lr-expected.txt: Added.
  • platform/chromium-win/fast/blockflow/box-shadow-vertical-rl-expected.checksum: Added.
  • platform/chromium-win/fast/blockflow/box-shadow-vertical-rl-expected.png: Added.
  • platform/chromium-win/fast/blockflow/box-shadow-vertical-rl-expected.txt: Added.
  • platform/chromium-win/fast/blockflow/english-lr-text-expected.checksum:
  • platform/chromium-win/fast/blockflow/english-lr-text-expected.png:
  • platform/chromium-win/fast/blockflow/english-rl-text-expected.checksum:
  • platform/chromium-win/fast/blockflow/english-rl-text-expected.png:
  • platform/chromium-win/fast/blockflow/japanese-lr-text-expected.checksum:
  • platform/chromium-win/fast/blockflow/japanese-lr-text-expected.png:
  • platform/chromium-win/fast/blockflow/japanese-rl-text-expected.checksum:
  • platform/chromium-win/fast/blockflow/japanese-rl-text-expected.png:
02:32 Changeset [70854] by commit-queue@webkit.org

2010-10-29 Kenichi Ishibashi <bashi@google.com>

Reviewed by Kent Tamura.

[HTML5] Add DOMSettableTokenList
https://bugs.webkit.org/show_bug.cgi?id=47810

  • fast/dom/Window/window-properties-expected.txt: Updated expectations.
  • fast/dom/Window/window-property-descriptors-expected.txt: Updated expectations.
  • fast/dom/prototype-inheritance-2-expected.txt: Updated expectations.
  • fast/dom/prototype-inheritance-expected.txt: Updated expectations.
  • fast/js/global-constructors-expected.txt: Updated expectations.

2010-10-29 Kenichi Ishibashi <bashi@google.com>

Reviewed by Kent Tamura.

[HTML5] Add DOMSettableTokenList
https://bugs.webkit.org/show_bug.cgi?id=47810

Adds DOMSettableTokenList interface to support <output> element.
The DOMTokenList interface was refactored since its was tightly coupled
with HTMLElement.classList property.

  • Android.derived.jscbindings.mk: Added JSDOMSettableTokenList.h file.
  • Android.derived.v8bindings.mk: Added V8DOMSettableTokenList.h file.
  • Android.jscbindings.mk: Added JSDOMSettableTokenList.cpp file.
  • Android.mk: Added ClassList.cpp file.
  • CMakeLists.txt: Added DOMSettableTokenList.{cpp,idl} and ClassList.cpp files.
  • DerivedSources.cpp: Added JSDOMSettableTokenList.cpp file.
  • DerivedSources.make: Added DOMSettableTokenList entry.
  • GNUmakefile.am: Added JSDOMSettableTokenList.{h,cpp} and ClassList.{h,cpp} files.
  • WebCore.gypi: Added DOMSettableTokenList.{h,cpp,idl}, V8DOMSettableTokenListCustom.cpp and ClassList.{h,cpp} files.
  • WebCore.pri: Added DOMSettableTokenList.idl file.
  • WebCore.pro: Added V8DOMSettableTokenListCustom.cpp, ClassList.{h,cpp} and DOMSettableTokenList.{h,cpp} files.
  • WebCore.vcproj/WebCore.vcproj: Added JSDOMSettableTokenList.{h,cpp}, ClassList.{h,cpp} and DOMSettableTokenList.{h,cpp} files.
  • WebCore.xcodeproj/project.pbxproj: Added ClassList.{h,cpp}, DOMSettabletokenList.{h,cpp} and JSDOMSettableTokenList.{h,cpp}
  • bindings/gobject/GNUmakefile.am: Added WebKitDOMDOMSettableTokenList.{h,cpp} and WebKitDOMDOMSettableTokenListPrivate.cpp files.
  • bindings/scripts/CodeGeneratorJS.pm: Modified IndexGetterReturnsStrings() returns 1 for DOMSettableTokenList.
  • bindings/v8/custom/V8DOMSettableTokenListCustom.cpp: Added. (WebCore::V8DOMSettableTokenList::indexedPropertyGetter):
  • dom/Element.cpp: Replaced DOMTokenList to ClassList. (WebCore::Element::classList):
  • dom/ElementRareData.h: ditto.
  • dom/SpaceSplitString.cpp: Added add() and remove() functions. (WebCore::SpaceSplitStringData::add): (WebCore::SpaceSplitStringData::remove): (WebCore::SpaceSplitString::add): (WebCore::SpaceSplitString::remove):
  • dom/SpaceSplitString.h: Added add() and remove() functions.
  • dom/StyledElement.cpp: Replaced DOMTokenList to ClassList. (WebCore::StyledElement::classAttributeChanged):
  • dom/StyledElement.h: ditto.
  • html/ClassList.cpp: Added, mostly from original DOMTokenList.cpp. (WebCore::ClassList::ClassList): (WebCore::ClassList::ref): (WebCore::ClassList::deref): (WebCore::ClassList::length): (WebCore::ClassList::item): (WebCore::ClassList::contains): (WebCore::ClassList::containsInternal): (WebCore::ClassList::add): (WebCore::ClassList::addInternal): (WebCore::ClassList::remove): (WebCore::ClassList::removeInternal): (WebCore::ClassList::toggle): (WebCore::ClassList::toString): (WebCore::ClassList::reset): (WebCore::ClassList::classNames):
  • html/ClassList.h: Added, mostly from original DOMTokenList.h. (WebCore::ClassList::create): (WebCore::ClassList::element):
  • html/DOMSettableTokenList.cpp: Added. (WebCore::DOMSettableTokenList::DOMSettableTokenList): (WebCore::DOMSettableTokenList::~DOMSettableTokenList): (WebCore::DOMSettableTokenList::item): (WebCore::DOMSettableTokenList::contains): (WebCore::DOMSettableTokenList::add): (WebCore::DOMSettableTokenList::addInternal): (WebCore::DOMSettableTokenList::remove): (WebCore::DOMSettableTokenList::removeInternal): (WebCore::DOMSettableTokenList::toggle): (WebCore::DOMSettableTokenList::setValue):
  • html/DOMSettableTokenList.h: Added. (WebCore::DOMSettableTokenList::create): (WebCore::DOMSettableTokenList::ref): (WebCore::DOMSettableTokenList::deref): (WebCore::DOMSettableTokenList::length): (WebCore::DOMSettableTokenList::toString): (WebCore::DOMSettableTokenList::value):
  • html/DOMSettableTokenList.idl: Added.
  • html/DOMTokenList.cpp: Refactored to be an abstract interface for both of ClassList and DOMSettableTokenList. (WebCore::DOMTokenList::validateToken): Changed to be a static member function of DOMTokenList. (WebCore::DOMTokenList::addToken): Added, mostly from original DOMTokenList::addInternal(). (WebCore::DOMTokenList::removeToken): Added, mostly from original DOMTokenList::removeInternal().
  • html/DOMTokenList.h: Refactored to be an abstract interface for both of ClassList and DOMSettableTokenList. (WebCore::DOMTokenList::~DOMTokenList): (WebCore::DOMTokenList::element):
  • page/DOMWindow.cpp: Added an entry for DOMSettableTokenList.
  • page/DOMWindow.idl: ditto.
02:00 Changeset [70853] by pfeldman@chromium.org

2010-10-29 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: make legacy resource tracking optional in the native code,
make cookeis work against new resource manager.
https://bugs.webkit.org/show_bug.cgi?id=48532

  • inspector/InspectorCSSStore.cpp: (WebCore::InspectorCSSStore::resourceStyleSheetText):
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::~InspectorController): (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::releaseFrontendLifetimeAgents): (WebCore::InspectorController::populateScriptObjects): (WebCore::InspectorController::unbindAllResources): (WebCore::InspectorController::didCommitLoad): (WebCore::InspectorController::frameDetachedFromParent): (WebCore::InspectorController::didLoadResourceFromMemoryCache): (WebCore::InspectorController::identifierForInitialRequest): (WebCore::InspectorController::willSendRequest): (WebCore::InspectorController::markResourceAsCached): (WebCore::InspectorController::didReceiveResponse): (WebCore::InspectorController::didReceiveContentLength): (WebCore::InspectorController::didFinishLoading): (WebCore::InspectorController::didFailLoading): (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest): (WebCore::InspectorController::scriptImported): (WebCore::InspectorController::setResourceTrackingEnabled): (WebCore::InspectorController::getCookies): (WebCore::InspectorController::deleteCookie): (WebCore::InspectorController::didCreateWebSocket): (WebCore::InspectorController::willSendWebSocketHandshakeRequest): (WebCore::InspectorController::didReceiveWebSocketHandshakeResponse): (WebCore::InspectorController::didCloseWebSocket): (WebCore::InspectorController::breakpointsSettingKey): (WebCore::InspectorController::getResourceContent):
  • inspector/InspectorController.h:
  • inspector/InspectorResource.cpp: (WebCore::InspectorResource::updateScriptObject): (WebCore::InspectorResource::markFailed):
  • inspector/InspectorResource.h:
  • inspector/InspectorResourceAgent.cpp: (WebCore::populateObjectWithFrameResources):
  • inspector/front-end/CookieItemsView.js: (WebInspector.CookieItemsView.prototype._updateWithCookies): (WebInspector.CookieItemsView.prototype._filterCookiesForDomain):
  • inspector/front-end/Resource.js: (WebInspector.Resource.prototype._mimeTypeIsConsistentWithType): (WebInspector.Resource.prototype._checkWarning):
  • inspector/front-end/ResourceManager.js: (WebInspector.ResourceManager.prototype._updateResourceWithResponse): (WebInspector.ResourceManager.prototype.didFailLoading):
  • inspector/front-end/inspector.js:
01:23 Changeset [70852] by morrita@google.com

2010-10-29 MORITA Hajime <morrita@google.com>

Unreviewed attempt for fixing build break for http://trac.webkit.org/changeset/70847

  • editing/EditingAllInOne.cpp:
01:08 Changeset [70851] by mihaip@chromium.org

2010-10-29 Mihai Parparita <mihaip@chromium.org>

Reviewed by Adam Barth.

Support RegExp in V8 implementation of SerializedScriptValue
https://bugs.webkit.org/show_bug.cgi?id=44809

fast/loader/stateobjects/pushstate-object-types.html now passes.

  • platform/chromium/test_expectations.txt:

2010-10-29 Mihai Parparita <mihaip@chromium.org>

Reviewed by Adam Barth.

Support RegExp in V8 implementation of SerializedScriptValue
https://bugs.webkit.org/show_bug.cgi?id=44809

Add RegExp serialization/deserialization now that V8 provides API access
to the RegExp type.

  • bindings/v8/SerializedScriptValue.cpp: (WebCore::ZigZag::Writer::writeRegExp): (WebCore::ZigZag::Serializer::writeRegExp): (WebCore::ZigZag::Serializer::doSerialize): (WebCore::ZigZag::Reader::read): (WebCore::ZigZag::Reader::readRegExp):
00:49 Changeset [70850] by morrita@google.com

2010-10-13 MORITA Hajime <morrita@google.com>

Reviewed by David Hyatt.

Navigating dark background websites results in blinding white flashes between pages.
https://bugs.webkit.org/show_bug.cgi?id=45640

This FOUC is caused by an early layout request before the <body> is ready,
and the page's background style given for <body>, instead of <html>.
So many sites have such stylesheets that we should care them.

  • Some DOM operation such as 'element.offsetLeft' causes page layout.
  • The page layout results page repaint
  • The page page repaint makes a white screen. because there is nothing to paint before <body> is available.

This change:

  • extracted existing FOUC check on RenderBlock and RenderLayer to Document::mayCauseFlashOfUnstyledContent(),
  • checked <body> availability on mayCauseFlashOfUnstyledContent(), and
  • added FOUC guards before requesting reapint on FrameView.

No new tests. The data loading speed matters and it cannot be
captured by DRT.

  • dom/Document.cpp: (WebCore::Document::mayCauseFlashOfUnstyledContent): Added.
  • dom/Document.h:
  • page/FrameView.cpp: (WebCore::FrameView::invalidateRect): Added a guard. (WebCore::FrameView::repaintContentRectangle): Added a guard. (WebCore::FrameView::doDeferredRepaints): Added a guard. (WebCore::FrameView::shouldUpdate): Added.
  • page/FrameView.h:
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintContents): Replaced FOUC check to use mayCauseFlashOfUnstyledContent
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintLayer): Replaced FOUC check to use mayCauseFlashOfUnstyledContent
00:16 Changeset [70849] by pfeldman@chromium.org

Merge 70799 - 2010-10-28 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: fix pausing on next JavaScript statement
https://bugs.webkit.org/show_bug.cgi?id=48534

  • inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent): (WebCore::InspectorDebuggerAgent::schedulePauseOnNextStatement): (WebCore::InspectorDebuggerAgent::cancelPauseOnNextStatement): (WebCore::InspectorDebuggerAgent::pause): (WebCore::InspectorDebuggerAgent::didPause):
  • inspector/InspectorDebuggerAgent.h:

TBR=podivilov@chromium.org
BUG=61195

00:07 Changeset [70848] by hyatt@apple.com

https://bugs.webkit.org/show_bug.cgi?id=48618

Reviewed by Dan Bernstein.

WebCore:

Backgrounds should clip to the border radius properly for vertical lines. The code that does this still assumes horizontal lines.
The testcase to cover this used nested spans, which also exposed a bug in the propagation of the vertical bit through the line
box tree.

Added fast/blockflow/border-radius-clipping-vertical-lr.html.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::createLineBoxes):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintFillLayerExtended):

LayoutTests:

Backgrounds should clip to the border radius properly for vertical lines. The code that does this still assumes horizontal lines.
The testcase to cover this used nested spans, which also exposed a bug in the propagation of the vertical bit through the line
box tree.

Added fast/blockflow/border-radius-clipping-vertical-lr.html.

  • fast/blockflow/border-radius-clipping-vertical-lr.html: Added.
  • platform/mac/fast/blockflow/border-radius-clipping-vertical-lr-expected.checksum: Added.
  • platform/mac/fast/blockflow/border-radius-clipping-vertical-lr-expected.png: Added.
  • platform/mac/fast/blockflow/border-radius-clipping-vertical-lr-expected.txt: Added.
  • platform/mac/fast/blockflow/box-shadow-vertical-lr-expected.checksum:
  • platform/mac/fast/blockflow/box-shadow-vertical-lr-expected.png:
  • platform/mac/fast/blockflow/box-shadow-vertical-rl-expected.checksum:
  • platform/mac/fast/blockflow/box-shadow-vertical-rl-expected.png:
Note: See TracTimeline for information about the timeline view.