Timeline


and

11/03/10:

23:58 Changeset [71309] by tkent@chromium.org
  • 11 edits
    2 adds in trunk/WebCore

Framework to show form validation message for invalid controls
https://bugs.webkit.org/show_bug.cgi?id=31718

Reviewed by Dimitri Glazkov.

HTMLFormElement::validateInteractively() shows a validation message for
an invalid control by HTMLFormControlElement::updateVisibleValidationMessage(),
and the message is hidden when the invalid control looses focus, becomes
valid, detached, or the form is submitted again.

Introduce ValidationMessage class to manage visible form validation
message. It has no implementation to show/hide a message yet.

No new tests. New behavior is disabled by default, and is timing-dependent.

  • Android.mk: Add ValidationMessage.
  • CMakeLists.txt: ditto.
  • GNUmakefile.am: ditto.
  • WebCore.gypi: ditto.
  • WebCore.pro: ditto.
  • WebCore.vcproj/WebCore.vcproj: ditto.
  • WebCore.xcodeproj/project.pbxproj: ditto.
  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::detach): Hides a validation message.
(WebCore::HTMLFormControlElement::setNeedsWillValidateCheck):

Hides a validation message if validation is not needed.

(WebCore::HTMLFormControlElement::updateVisibleValidationMessage):
(WebCore::HTMLFormControlElement::hideVisibleValidationMessage):
(WebCore::HTMLFormControlElement::setNeedsValidityCheck):

Hides a validation message or updates the validation message.

(WebCore::HTMLFormControlElement::dispatchBlurEvent):

Hides a validation message.

(WebCore::HTMLFormControlElement::visibleValidationMessage):

  • html/HTMLFormControlElement.h:
  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::validateInteractively):

  • Hide existing validation messages before showing new message.
  • Show new validation message.
  • html/ValidationMessage.cpp: Added.

(WebCore::ValidationMessage::ValidationMessage):
(WebCore::ValidationMessage::~ValidationMessage):
(WebCore::ValidationMessage::create):
(WebCore::ValidationMessage::setMessage):
(WebCore::ValidationMessage::hideMessage):

  • html/ValidationMessage.h: Added.

(WebCore::ValidationMessage::message):

23:54 Changeset [71308] by rolandsteiner@chromium.org
  • 2 edits in trunk/LayoutTests

2010-11-03 Roland Steiner <rolandsteiner@chromium.org>

Unreviewed: add new entry to Chromium test_expectations.txt

  • platform/chromium/test_expectations.txt:
22:36 Changeset [71307] by paroga@webkit.org
  • 2 edits in trunk/WebCore

2010-11-03 Patrick Gansterer <paroga@webkit.org>

Reviewed by Adam Roben.

Port WCDataObject.cpp to WinCE
https://bugs.webkit.org/show_bug.cgi?id=48921

OleDuplicateData is not supported on WinCE.

  • platform/win/WCDataObject.cpp: (WebCore::WCDataObject::CopyMedium):
21:20 Changeset [71306] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

2010-11-03 Stephen White <senorblanco@chromium.org>

Unreviewed; test_expectations fix.

One last attempt to green up the chromium gpu bots.

  • platform/chromium-gpu/test_expectations.txt:
21:14 Changeset [71305] by rolandsteiner@chromium.org
  • 2 edits in trunk/LayoutTests

2010-11-03 Roland Steiner <rolandsteiner@chromium.org>

Unreviewed: add failing test to Chroium's test_expectation.txt

  • platform/chromium/test_expectations.txt:
21:10 Changeset [71304] by paroga@webkit.org
  • 2 edits in trunk/WebCore

2010-11-03 Patrick Gansterer <paroga@webkit.org>

Reviewed by Adam Roben.

Port ClipboardWin.cpp to WinCE
https://bugs.webkit.org/show_bug.cgi?id=48412

  • platform/win/ClipboardWin.cpp: (WebCore::writeFileToDataObject):
20:55 Changeset [71303] by commit-queue@webkit.org
  • 7 edits in trunk/WebKit/qt

2010-11-03 Andre Pedralho <andre.pedralho@gmail.com>

Reviewed by Kenneth Rohde Christiansen.

Using the Platform Plugin to define the default values for the padding of HitTestResult.
https://bugs.webkit.org/show_bug.cgi?id=48450

  • Api/qwebkitplatformplugin.h: (QWebTouchModifier::~QWebTouchModifier):
  • WebCoreSupport/QtPlatformPlugin.cpp: (WebCore::QtPlatformPlugin::createTouchModifier):
  • WebCoreSupport/QtPlatformPlugin.h:
  • examples/platformplugin/WebPlugin.cpp: (WebPlugin::supportsExtension): (WebPlugin::createExtension):
  • examples/platformplugin/WebPlugin.h: (TouchModifier::hitTestPaddingForTouch):
  • examples/platformplugin/qwebkitplatformplugin.h: (QWebTouchModifier::~QWebTouchModifier):
20:40 Changeset [71302] by commit-queue@webkit.org
  • 2 edits in trunk/WebKitTools

2010-11-03 George Guo <George.Guo@Nokia.com>

Reviewed by Andreas Kling.

[Qt] QtTestBrowser : set mmp rule pageddata in Symbian
https://bugs.webkit.org/show_bug.cgi?id=48767

Paging is needd on Symbian devices to support benchmarks tests like
dromaeo.com and Celtic Kane that need a lot of memory to run

  • QtTestBrowser/QtTestBrowser.pro:
20:25 Changeset [71301] by rolandsteiner@chromium.org
  • 1 edit
    3 deletes in trunk/LayoutTests

2010-11-03 Roland Steiner <rolandsteiner@chromium.org>

Reviewed by Nikolas Zimmermann.

Bug 48904 - [Chromium] Remove obsolete expectation files
https://bugs.webkit.org/show_bug.cgi?id=48904

Remove superfluous files:

  • platform/chromium-mac/fast/css/getComputedStyle/computed-style-expected.txt: Removed.
  • platform/chromium-mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Removed.
  • platform/chromium-mac/svg/css/getComputedStyle-basic-expected.txt: Removed.
19:59 Changeset [71300] by paroga@webkit.org
  • 2 edits in trunk/WebCore

2010-11-03 Patrick Gansterer <paroga@webkit.org>

Reviewed by Adam Roben.

Port ClipboardWin.cpp to WinCE
https://bugs.webkit.org/show_bug.cgi?id=48412

  • platform/win/ClipboardWin.cpp: (WebCore::filesystemPathFromUrlOrTitle): (WebCore::createGlobalHDropContent): (WebCore::ClipboardWin::files):
19:42 Changeset [71299] by commit-queue@webkit.org
  • 6 edits in trunk

2010-11-03 Vincent Scheib <scheib@chromium.org>

Reviewed by James Robinson.

[chromium] GraphicsContext3D creation attributes include canRecoverFromContextLoss option
https://bugs.webkit.org/show_bug.cgi?id=48850

Implementations of GraphicsContext3D may respect the creation attribute
canRecoverFromContextLoss being false, and then only succeeding initialization if
the context can satisfy that request of never being lost. DX9 on XP can not satisfy
such a request.

Test by use of accelerated canvas 2d in Chromium with ANGLE on XP machines.

  • platform/graphics/GraphicsContext3D.h: (WebCore::GraphicsContext3D::Attributes::Attributes):
  • platform/graphics/gpu/SharedGraphicsContext3D.cpp: (WebCore::SharedGraphicsContext3D::create):

2010-11-03 Vincent Scheib <scheib@chromium.org>

Reviewed by James Robinson.

[chromium] GraphicsContext3D creation attributes include canRecoverFromContextLoss option
https://bugs.webkit.org/show_bug.cgi?id=48850

Implementations of GraphicsContext3D may respect the creation attribute
canRecoverFromContextLoss being false, and then only succeeding initialization if
the context can satisfy that request of never being lost. DX9 on XP can not satisfy
such a request.

Test by use of accelerated canvas 2d in Chromium with ANGLE on XP machines.

  • public/WebGraphicsContext3D.h: (WebKit::WebGraphicsContext3D::Attributes::Attributes):
  • src/GraphicsContext3DChromium.cpp: (WebCore::GraphicsContext3DInternal::initialize):
19:32 Changeset [71298] by alice.liu@apple.com
  • 4 edits in trunk/WebKit2

Fix clang++ build

  • PluginProcess/PluginProcess.h:
  • UIProcess/Plugins/PluginProcessProxy.h:
  • UIProcess/WebContextMenuProxy.h:

Change class to struct and vise versa where needed.

19:13 Changeset [71297] by commit-queue@webkit.org
  • 6 edits in trunk

2010-11-03 Jenn Braithwaite <jennb@chromium.org>

Reviewed by Dmitry Titov.

Chromium: Update resource tracking when moving a frame between documents
https://bugs.webkit.org/show_bug.cgi?id=48363

  • public/WebFrameClient.h: (WebKit::WebFrameClient::removeIdentifierForRequest): Added
  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::transferLoadingResourceFromPage): Notify current WebFrameClient of the resource and remove from former WebFrameClient.

2010-11-03 Jenn Braithwaite <jennb@chromium.org>

Reviewed by Dmitry Titov.

Chromium: Update resource tracking when moving a frame between documents
https://bugs.webkit.org/show_bug.cgi?id=48363

  • DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::assignIdentifierToRequest): Always put resource id in map so we can make assumptions about its presence. (WebViewHost::removeIdentifierForRequest): Added. (WebViewHost::didFinishResourceLoad): (WebViewHost::didFailResourceLoad): Check existence of resource id before removing from map.
  • DumpRenderTree/chromium/WebViewHost.h:
18:55 Changeset [71296] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-11-03 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Use sentence boundaries instead of start/end sentence
https://bugs.webkit.org/show_bug.cgi?id=48422

Using sentence boundaries all intersentence
whitespace/control/format characters are assigned to a
sentence. This is what ICU does, so we have to do the same in
order to get the same results with glib unicode backend. It fixes
the sentence tests cases in test fast/dom/Range/range-expand.html.

  • platform/text/gtk/TextBreakIteratorGtk.cpp: (WebCore::textBreakNext): (WebCore::textBreakPrevious):
18:43 Changeset [71295] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed.

[Qt] DRT sideeffect revealed by r71268
https://bugs.webkit.org/show_bug.cgi?id=48958

  • platform/qt/Skipped:
    • svg/custom/text-zoom.xhtml added.
    • canvas/philip/tests/2d.pattern.image.null.html unskipped.
    • canvas/philip/tests/2d.pattern.image.undefined.html unskipped.
18:34 Changeset [71294] by kbr@google.com
  • 2 edits in trunk/LayoutTests

2010-11-03 Adrienne Walker <enne@google.com>

Reviewed by Kenneth Russell.

Rebaseline gl-object-get-calls due to a missing blank line.
https://bugs.webkit.org/show_bug.cgi?id=48965

  • fast/canvas/webgl/gl-object-get-calls-expected.txt:
18:25 Changeset [71293] by tkent@chromium.org
  • 2 edits
    7 adds in trunk/LayoutTests

2010-11-03 Kent Tamura <tkent@chromium.org>

Unreviewed, test expectation update.

  • platform/chromium-linux/editing/selection/transformed-selection-rects-expected.checksum: Added.
  • platform/chromium-linux/editing/selection/transformed-selection-rects-expected.png: Added.
  • platform/chromium-mac/editing/selection/transformed-selection-rects-expected.checksum: Added.
  • platform/chromium-mac/editing/selection/transformed-selection-rects-expected.png: Added.
  • platform/chromium-win/editing/selection/transformed-selection-rects-expected.checksum: Added.
  • platform/chromium-win/editing/selection/transformed-selection-rects-expected.png: Added.
  • platform/chromium-win/editing/selection/transformed-selection-rects-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
18:19 Changeset [71292] by mdelaney@apple.com
  • 5 edits
    1 delete in trunk/LayoutTests

2010-11-03 Matthew Delaney <mdelaney@apple.com>

Reviewed by Darin Adler.

Fix LayoutTests/canvas/philip/tests/2d.drawImage.incomplete.html
https://bugs.webkit.org/show_bug.cgi?id=48306

  • canvas/philip/tests/2d.drawImage.incomplete.html: Modified test to correctly create an image object with its complete attr set to false.
  • platform/gtk/Skipped: Unskipping now passing tests. Same for below.
  • platform/mac-leopard/Skipped:
  • platform/qt/Skipped:
  • platform/mac-snowleopard/canvas/philip/tests/2d.drawImage.incomplete-expected.txt: Removed old failing expectations.
18:15 QtWebKitGraphics edited by ryan.roberts@sharedresearch.jp
fix a few formatting and type-o mistakes (diff)
17:49 Changeset [71291] by zmo@google.com
  • 5 edits in trunk

2010-11-03 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

depthRange should generate INVALID_OPERATION if zNear is greater than zFar
https://bugs.webkit.org/show_bug.cgi?id=48676

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::depthRange):

2010-11-03 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

depthRange should generate INVALID_OPERATION if zNear is greater than zFar
https://bugs.webkit.org/show_bug.cgi?id=48676

  • fast/canvas/webgl/webgl-specific-expected.txt:
  • fast/canvas/webgl/webgl-specific.html:
17:36 Changeset [71290] by dumi@chromium.org
  • 2 edits
    1 add in trunk/LayoutTests

Unreviewed, updating Chromium expectations.

  • platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
17:26 Changeset [71289] by kbr@google.com
  • 5 edits in trunk

2010-11-03 Adrienne Walker <enne@google.com>

Reviewed by Kenneth Russell.

Properly return empty strings instead of null when using invalid
objects for some WebGL calls. This fixes issues caused by r71274.
https://bugs.webkit.org/show_bug.cgi?id=48962

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::getProgramInfoLog): (WebCore::WebGLRenderingContext::getShaderInfoLog): (WebCore::WebGLRenderingContext::getShaderSource):

2010-11-03 Adrienne Walker <enne@google.com>

Reviewed by Kenneth Russell.

WebGL spec doesn't specify whether the return from getAttachedShaders
can be undefined or null. Tolerate both.
https://bugs.webkit.org/show_bug.cgi?id=48962

  • fast/canvas/webgl/gl-object-get-calls-expected.txt:
  • fast/canvas/webgl/gl-object-get-calls.html:
17:14 Changeset [71288] by rniwa@webkit.org
  • 5 edits
    2 adds in trunk

2010-11-01 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

Crash in ApplyStyleCommand::removeStyleFromRunBeforeApplyingStyle
https://bugs.webkit.org/show_bug.cgi?id=48581

The crash was caused by RemoveNodePreservingChildrenCommand's calling removeNode
on m_node without checking that m_node has a parent and it's still in the document.
Fixed the crash by adding an early exit in CompositeEditCommand::removeNode and
deploying RefPtr in several places of ApplyStyleCommand.cpp.

Test: editing/style/iframe-onload-crash.html

  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyInlineStyleToNodeRange): (WebCore::ApplyStyleCommand::removeStyleFromRunBeforeApplyingStyle): (WebCore::ApplyStyleCommand::removeInlineStyleFromElement):
  • editing/ApplyStyleCommand.h:
  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::removeNode):

2010-10-29 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

Crash in ApplyStyleCommand::removeStyleFromRunBeforeApplyingStyle
https://bugs.webkit.org/show_bug.cgi?id=48581

Added a test to ensure removeStyleFromRunBeforeApplyingStyle doesn't crash.

  • editing/style/iframe-onload-crash-expected.txt: Added.
  • editing/style/iframe-onload-crash.html: Added.
17:06 Changeset [71287] by mrowe@apple.com
  • 2 edits in tags/Safari-534.11.2/WebCore

Merge r71284.

17:06 Changeset [71286] by mrowe@apple.com
  • 5 edits in tags/Safari-534.11.2

Versioning.

17:03 Changeset [71285] by mrowe@apple.com
  • 1 copy in tags/Safari-534.11.2

New tag.

16:55 Changeset [71284] by adele@apple.com
  • 2 edits in trunk/WebCore

Crashes in WebCore::DocumentMarkerController::removeMarkersFromMarkerMapVectorPair() when deleting multiple lines of text.
https://bugs.webkit.org/show_bug.cgi?id=48918
<rdar://problem/8620602>

Patch by Jia Pu <jpu@apple.com> on 2010-11-03
Reviewed by Darin Adler.

I haven't been able to found a reliable way to reproduce the bug. However, whenever it happens,
the crash is caused by a null node pointer returned by TextIterator. So it seems to be a
safe fix to guard against that.

  • editing/Editor.cpp: (WebCore::Editor::removeSpellAndCorrectionMarkersFromWordsToBeEdited):
16:55 Changeset [71283] by victorw@chromium.org
  • 2 edits in trunk/WebKitTools

2010-11-03 Victor Wang <victorw@chromium.org>

Reviewed by Adam Barth.

[Chromium] update buildbot names in chromium rebaseline tool.

https://bugs.webkit.org/show_bug.cgi?id=48881

  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
16:53 Changeset [71282] by zmo@google.com
  • 6 edits in trunk

2010-11-02 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

A different mask or reference value in stencil operations should generate INVALID_OPERATION
https://bugs.webkit.org/show_bug.cgi?id=48669

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::WebGLRenderingContext): Init stencil func ref/mask and stencil mask to default. (WebCore::WebGLRenderingContext::stencilFunc): Cache ref/mask value. (WebCore::WebGLRenderingContext::stencilFuncSeparate): Generate error if front/back values differ. (WebCore::WebGLRenderingContext::stencilMask): Cache mask value. (WebCore::WebGLRenderingContext::stencilMaskSeparate): Generate error if front/back values differ. (WebCore::WebGLRenderingContext::validateFace): Validate face parameter. (WebCore::WebGLRenderingContext::validateStencilFunc): Validate stencil func parameter.
  • html/canvas/WebGLRenderingContext.h: Add members to track stencil func ref/mask and stencil mask.

2010-11-02 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

A different mask or reference value in stencil operations should generate INVALID_OPERATION
https://bugs.webkit.org/show_bug.cgi?id=48669

  • fast/canvas/webgl/webgl-specific-expected.txt:
  • fast/canvas/webgl/webgl-specific.html: Uncomment the test cases for the bug.
16:44 Changeset [71281] by crogers@google.com
  • 1023 edits
    130 copies
    29 deletes in branches/audio

audio branch: merge from trunk 70545:71224

16:41 Changeset [71280] by oliver@apple.com
  • 8 edits
    3 adds in trunk

2010-11-03 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

Crash in Function.prototype.call.apply
https://bugs.webkit.org/show_bug.cgi?id=48485

The problem here was op_load_varargs failing to ensure that
there was sufficient space for the entire callframe prior to
op_call_varargs. This meant that when we then re-entered the
VM it was possible to stomp over an earlier portion of the
stack, so causing sub-optimal behaviour.

  • bytecode/Opcode.h:
  • bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::emitLoadVarargs):
  • bytecompiler/BytecodeGenerator.h:
  • bytecompiler/NodesCodegen.cpp: (JSC::ApplyFunctionCallDotNode::emitBytecode):
  • jit/JIT.cpp: (JSC::JIT::privateCompile):
  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_load_varargs):

2010-11-03 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

Crash in Function.prototype.call.apply
https://bugs.webkit.org/show_bug.cgi?id=48485

Test for applying arguments to call at the edge of
the allocated region of the registerfile.

  • fast/js/call-apply-crash-expected.txt: Added.
  • fast/js/call-apply-crash.html: Added.
  • fast/js/script-tests/call-apply-crash.js: Added. (testLog):
16:10 Changeset [71279] by abarth@webkit.org
  • 2 edits in trunk/WebKit/chromium

2010-11-03 Adam Barth <abarth@webkit.org>

Roll Chromium DEPs
https://bugs.webkit.org/show_bug.cgi?id=48959

  • DEPS:
16:03 Changeset [71278] by dglazkov@chromium.org
  • 23 edits
    4 deletes in trunk

2010-11-03 Dimitri Glazkov <dglazkov@chromium.org>

Reverting r71244. Broke default event handling inside text fields.
https://bugs.webkit.org/show_bug.cgi?id=46015

  • fast/events/shadow-boundary-crossing.html: Reverted changes.
  • media/audio-delete-while-slider-thumb-clicked.html: Reverted changes.

2010-11-03 Dimitri Glazkov <dglazkov@chromium.org>

Reverting r71244, r71248 and r71250. Broke default event handling inside text fields.
https://bugs.webkit.org/show_bug.cgi?id=46015

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/ContainerNode.cpp: (WebCore::notifyChildInserted):
  • dom/DOMAllInOne.cpp:
  • dom/EventContext.cpp: Removed.
  • dom/EventContext.h: Removed.
  • dom/Node.cpp: (WebCore::Node::markAncestorsWithChildNeedsStyleRecalc): (WebCore::Node::createRendererIfNeeded): (WebCore::Node::eventParentNode): (WebCore::Node::enclosingLinkEventParentOrSelf): (WebCore::eventTargetAsSVGElementInstance): (WebCore::eventTargetRespectingSVGTargetRules): (WebCore::Node::eventAncestors): (WebCore::Node::dispatchGenericEvent):
  • dom/Node.h:
  • dom/Text.cpp: (WebCore::Text::createRenderer):
  • dom/WindowEventContext.cpp: Removed.
  • dom/WindowEventContext.h: Removed.
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::getEventListenersForNode):
  • inspector/InspectorInstrumentation.cpp: (WebCore::eventHasListeners): (WebCore::InspectorInstrumentation::willDispatchEventImpl):
  • inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::willDispatchEvent):
  • page/EventHandler.cpp: (WebCore::EventHandler::updateMouseEventTargetNode):
  • rendering/ShadowElement.h: (WebCore::ShadowElement::shadowParent): (WebCore::ShadowElement::shadowParentNode):
  • svg/SVGElement.cpp: (WebCore::SVGElement::eventParentNode):
  • svg/SVGElement.h:
15:58 Changeset [71277] by abarth@webkit.org
  • 3 edits
    3 adds in trunk

2010-11-03 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

CG use of WebKit image decoders crashes on some animated GIFs
https://bugs.webkit.org/show_bug.cgi?id=48955

It turns out CFDataGetMutableBytePtr isn't safe call on a null pointer.

Test: fast/images/dont-crash-with-null-gif-frames.html

  • platform/image-decoders/cg/ImageDecoderCG.cpp: (WebCore::RGBA32Buffer::copyReferenceToBitmapData): (WebCore::RGBA32Buffer::copyBitmapData):

2010-11-03 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

CG use of WebKit image decoders crashes on some animated GIFs
https://bugs.webkit.org/show_bug.cgi?id=48955

Test image from Wikipedia that was crashing.

  • fast/images/dont-crash-with-null-gif-frames-expected.txt: Added.
  • fast/images/dont-crash-with-null-gif-frames.html: Added.
  • fast/images/resources/quicksort.gif: Added.
15:48 Changeset [71276] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed.

[Qt] DRT sideeffect revealed by r71268
https://bugs.webkit.org/show_bug.cgi?id=48958

  • platform/qt/Skipped: canvas/philip/tests/2d.pattern.image.null.html and 2d.pattern.image.undefined.html added until fix.
15:15 Changeset [71275] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

2010-11-03 Stephen White <senorblanco@chromium.org>

Unreviewed; test expectations update.

[Chromium] This test is flaky on the GPU path after all.

  • platform/chromium-gpu/test_expectations.txt:
15:06 Changeset [71274] by kbr@google.com
  • 10 edits
    3 adds in trunk/WebCore

2010-11-03 Adrienne Walker <enne@google.com>

Reviewed by Kenneth Russell.

Implement lost, restored, and creation failure context events for
WebGLRenderingContext. The lost and restored functions are not hooked
up yet, but the context now acts according to the spec as it should
during a lost context. Tested manually, as there's no programmatic
way to lose a context yet.
https://bugs.webkit.org/show_bug.cgi?id=35626

  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSWebGLRenderingContextCustom.cpp: (WebCore::JSWebGLRenderingContext::getAttachedShaders):
  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp: (WebCore::V8WebGLRenderingContext::getAttachedShadersCallback):
  • dom/EventNames.h:
  • html/canvas/WebGLContextEvent.cpp: Added. (WebCore::WebGLContextEvent::WebGLContextEvent): (WebCore::WebGLContextEvent::~WebGLContextEvent): (WebCore::WebGLContextEvent::initEvent):
  • html/canvas/WebGLContextEvent.h: Added. (WebCore::WebGLContextEvent::create): (WebCore::WebGLContextEvent::statusMessage):
  • html/canvas/WebGLContextEvent.idl: Added.
  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::create): (WebCore::WebGLRenderingContext::WebGLRenderingContext): (WebCore::WebGLRenderingContext::initializeNewContext): (WebCore::WebGLRenderingContext::activeTexture): (WebCore::WebGLRenderingContext::attachShader): (WebCore::WebGLRenderingContext::bindAttribLocation): (WebCore::WebGLRenderingContext::bindBuffer): (WebCore::WebGLRenderingContext::bindFramebuffer): (WebCore::WebGLRenderingContext::bindRenderbuffer): (WebCore::WebGLRenderingContext::bindTexture): (WebCore::WebGLRenderingContext::blendColor): (WebCore::WebGLRenderingContext::blendEquation): (WebCore::WebGLRenderingContext::blendEquationSeparate): (WebCore::WebGLRenderingContext::blendFunc): (WebCore::WebGLRenderingContext::blendFuncSeparate): (WebCore::WebGLRenderingContext::bufferData): (WebCore::WebGLRenderingContext::bufferSubData): (WebCore::WebGLRenderingContext::checkFramebufferStatus): (WebCore::WebGLRenderingContext::clear): (WebCore::WebGLRenderingContext::clearColor): (WebCore::WebGLRenderingContext::clearDepth): (WebCore::WebGLRenderingContext::clearStencil): (WebCore::WebGLRenderingContext::colorMask): (WebCore::WebGLRenderingContext::compileShader): (WebCore::WebGLRenderingContext::copyTexImage2D): (WebCore::WebGLRenderingContext::copyTexSubImage2D): (WebCore::WebGLRenderingContext::createBuffer): (WebCore::WebGLRenderingContext::createFramebuffer): (WebCore::WebGLRenderingContext::createTexture): (WebCore::WebGLRenderingContext::createProgram): (WebCore::WebGLRenderingContext::createRenderbuffer): (WebCore::WebGLRenderingContext::createShader): (WebCore::WebGLRenderingContext::cullFace): (WebCore::WebGLRenderingContext::deleteBuffer): (WebCore::WebGLRenderingContext::deleteFramebuffer): (WebCore::WebGLRenderingContext::deleteProgram): (WebCore::WebGLRenderingContext::deleteRenderbuffer): (WebCore::WebGLRenderingContext::deleteShader): (WebCore::WebGLRenderingContext::deleteTexture): (WebCore::WebGLRenderingContext::depthFunc): (WebCore::WebGLRenderingContext::depthMask): (WebCore::WebGLRenderingContext::depthRange): (WebCore::WebGLRenderingContext::detachShader): (WebCore::WebGLRenderingContext::disable): (WebCore::WebGLRenderingContext::disableVertexAttribArray): (WebCore::WebGLRenderingContext::drawArrays): (WebCore::WebGLRenderingContext::drawElements): (WebCore::WebGLRenderingContext::enable): (WebCore::WebGLRenderingContext::enableVertexAttribArray): (WebCore::WebGLRenderingContext::finish): (WebCore::WebGLRenderingContext::flush): (WebCore::WebGLRenderingContext::framebufferRenderbuffer): (WebCore::WebGLRenderingContext::framebufferTexture2D): (WebCore::WebGLRenderingContext::frontFace): (WebCore::WebGLRenderingContext::generateMipmap): (WebCore::WebGLRenderingContext::getActiveAttrib): (WebCore::WebGLRenderingContext::getActiveUniform): (WebCore::WebGLRenderingContext::getAttachedShaders): (WebCore::WebGLRenderingContext::getAttribLocation): (WebCore::WebGLRenderingContext::getBufferParameter): (WebCore::WebGLRenderingContext::getContextAttributes): (WebCore::WebGLRenderingContext::getFramebufferAttachmentParameter): (WebCore::WebGLRenderingContext::getParameter): (WebCore::WebGLRenderingContext::getProgramParameter): (WebCore::WebGLRenderingContext::getProgramInfoLog): (WebCore::WebGLRenderingContext::getRenderbufferParameter): (WebCore::WebGLRenderingContext::getShaderParameter): (WebCore::WebGLRenderingContext::getShaderInfoLog): (WebCore::WebGLRenderingContext::getShaderSource): (WebCore::WebGLRenderingContext::getTexParameter): (WebCore::WebGLRenderingContext::getUniform): (WebCore::WebGLRenderingContext::getUniformLocation): (WebCore::WebGLRenderingContext::getVertexAttrib): (WebCore::WebGLRenderingContext::getVertexAttribOffset): (WebCore::WebGLRenderingContext::hint): (WebCore::WebGLRenderingContext::isBuffer): (WebCore::WebGLRenderingContext::isContextLost): (WebCore::WebGLRenderingContext::isEnabled): (WebCore::WebGLRenderingContext::isFramebuffer): (WebCore::WebGLRenderingContext::isProgram): (WebCore::WebGLRenderingContext::isRenderbuffer): (WebCore::WebGLRenderingContext::isShader): (WebCore::WebGLRenderingContext::isTexture): (WebCore::WebGLRenderingContext::lineWidth): (WebCore::WebGLRenderingContext::linkProgram): (WebCore::WebGLRenderingContext::pixelStorei): (WebCore::WebGLRenderingContext::polygonOffset): (WebCore::WebGLRenderingContext::readPixels): (WebCore::WebGLRenderingContext::releaseShaderCompiler): (WebCore::WebGLRenderingContext::renderbufferStorage): (WebCore::WebGLRenderingContext::sampleCoverage): (WebCore::WebGLRenderingContext::scissor): (WebCore::WebGLRenderingContext::shaderSource): (WebCore::WebGLRenderingContext::stencilFunc): (WebCore::WebGLRenderingContext::stencilFuncSeparate): (WebCore::WebGLRenderingContext::stencilMask): (WebCore::WebGLRenderingContext::stencilMaskSeparate): (WebCore::WebGLRenderingContext::stencilOp): (WebCore::WebGLRenderingContext::stencilOpSeparate): (WebCore::WebGLRenderingContext::texImage2D): (WebCore::WebGLRenderingContext::texParameter): (WebCore::WebGLRenderingContext::texSubImage2DBase): (WebCore::WebGLRenderingContext::texSubImage2DImpl): (WebCore::WebGLRenderingContext::texSubImage2D): (WebCore::WebGLRenderingContext::uniform1f): (WebCore::WebGLRenderingContext::uniform1fv): (WebCore::WebGLRenderingContext::uniform1i): (WebCore::WebGLRenderingContext::uniform1iv): (WebCore::WebGLRenderingContext::uniform2f): (WebCore::WebGLRenderingContext::uniform2fv): (WebCore::WebGLRenderingContext::uniform2i): (WebCore::WebGLRenderingContext::uniform2iv): (WebCore::WebGLRenderingContext::uniform3f): (WebCore::WebGLRenderingContext::uniform3fv): (WebCore::WebGLRenderingContext::uniform3i): (WebCore::WebGLRenderingContext::uniform3iv): (WebCore::WebGLRenderingContext::uniform4f): (WebCore::WebGLRenderingContext::uniform4fv): (WebCore::WebGLRenderingContext::uniform4i): (WebCore::WebGLRenderingContext::uniform4iv): (WebCore::WebGLRenderingContext::uniformMatrix2fv): (WebCore::WebGLRenderingContext::uniformMatrix3fv): (WebCore::WebGLRenderingContext::uniformMatrix4fv): (WebCore::WebGLRenderingContext::useProgram): (WebCore::WebGLRenderingContext::validateProgram): (WebCore::WebGLRenderingContext::vertexAttribPointer): (WebCore::WebGLRenderingContext::viewport): (WebCore::WebGLRenderingContext::loseContext): (WebCore::WebGLRenderingContext::restoreContext): (WebCore::WebGLRenderingContext::addObject): (WebCore::WebGLRenderingContext::vertexAttribfImpl): (WebCore::WebGLRenderingContext::vertexAttribfvImpl):
  • html/canvas/WebGLRenderingContext.h:
  • html/canvas/WebGLRenderingContext.idl:
  • platform/graphics/GraphicsContext3D.h:
14:54 Changeset [71273] by andersca@apple.com
  • 8 edits in trunk

Implement NP_SetProperty
https://bugs.webkit.org/show_bug.cgi?id=48956

Reviewed by Adam Roben.

WebKit2:

  • Shared/Plugins/NPObjectMessageReceiver.cpp:

(WebKit::NPObjectMessageReceiver::setProperty):
Call the NPClass setProperty function.

  • Shared/Plugins/NPObjectMessageReceiver.messages.in:

Add SetProperty message.

  • Shared/Plugins/NPObjectProxy.cpp:

(WebKit::NPObjectProxy::setProperty):
Send a SetProperty message.

(WebKit::NPObjectProxy::NP_SetProperty):
Call NPObjectProxy::setProperty.

LayoutTests:

Remove now passing test.

  • platform/mac-wk2/Skipped:
14:48 Changeset [71272] by kbr@google.com
  • 25 edits
    7 adds in trunk

2010-11-03 Kenneth Russell <kbr@google.com>

Reviewed by Chris Marrin.

Redesign extension mechanism in GraphicsContext3D
https://bugs.webkit.org/show_bug.cgi?id=46894

  • JavaScriptCore.exp:
    • Exposed String::split(const String&, Vector<String>).

2010-11-03 Kenneth Russell <kbr@google.com>

Reviewed by Chris Marrin.

Redesign extension mechanism in GraphicsContext3D
https://bugs.webkit.org/show_bug.cgi?id=46894

Upon request, factored out extension support from GraphicsContext3D
into a new Extensions3D class. (The plural was chosen because the
class and subclasses hold multiple extensions.)

Unlike GraphicsContext3D, Extensions3D contains only pure virtual
methods. This was done because Extensions3D's inheritance diagram
and usage pattern is very different from that of GraphicsContext3D,
and the concrete subclasses need to decide how to implement the
various entry points. Requiring them to be placed at the
Extensions3D level will cause implementation details to leak into
the base class, which is highly undesirable. Any virtual call
overhead to these entry points will be negligible.

Changed call sites utilizing these extensions to call through the
Extensions3D object or its subclasses.

Tested:

  • Chromium on Linux with accelerated 2D canvas and HTML5 video
  • Chromium on Mac OS X with WebGL and CSS 3D content
  • Safari on Mac OS X with WebGL and CSS 3D content

No new tests. Covered by existing tests.

  • WebKit.gyp:
  • public/WebGraphicsContext3D.h:
  • src/Extensions3DChromium.cpp: Added. (WebCore::Extensions3DChromium::Extensions3DChromium): (WebCore::Extensions3DChromium::~Extensions3DChromium): (WebCore::Extensions3DChromium::supports): (WebCore::Extensions3DChromium::getGraphicsResetStatusARB): (WebCore::Extensions3DChromium::mapBufferSubDataCHROMIUM): (WebCore::Extensions3DChromium::unmapBufferSubDataCHROMIUM): (WebCore::Extensions3DChromium::mapTexSubImage2DCHROMIUM): (WebCore::Extensions3DChromium::unmapTexSubImage2DCHROMIUM): (WebCore::Extensions3DChromium::copyTextureToParentTextureCHROMIUM):
  • src/GraphicsContext3DChromium.cpp: (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal): (WebCore::GraphicsContext3DInternal::getExtensions): (WebCore::GraphicsContext3DInternal::supportsExtension):
  • src/GraphicsContext3DInternal.h:
  • src/WebGraphicsContext3DDefaultImpl.cpp: (WebKit::WebGraphicsContext3DDefaultImpl::copyTextureToParentTextureCHROMIUM): (WebKit::WebGraphicsContext3DDefaultImpl::getString):
  • src/WebGraphicsContext3DDefaultImpl.h:
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::composite):

2010-11-03 Kenneth Russell <kbr@google.com>

Reviewed by Chris Marrin.

Redesign extension mechanism in GraphicsContext3D
https://bugs.webkit.org/show_bug.cgi?id=46894

Upon request, factored out extension support from GraphicsContext3D
into a new Extensions3D class. (The plural was chosen because the
class and subclasses hold multiple extensions.)

Unlike GraphicsContext3D, Extensions3D contains only pure virtual
methods. This was done because Extensions3D's inheritance diagram
and usage pattern is very different from that of GraphicsContext3D,
and the concrete subclasses need to decide how to implement the
various entry points. Requiring them to be placed at the
Extensions3D level will cause implementation details to leak into
the base class, which is highly undesirable. Any virtual call
overhead to these entry points will be negligible.

Changed call sites utilizing these extensions to call through the
Extensions3D object or its subclasses.

Tested:

  • Chromium on Linux with accelerated 2D canvas and HTML5 video
  • Chromium on Mac OS X with WebGL and CSS 3D content
  • Safari on Mac OS X with WebGL and CSS 3D content

No new tests. Covered by existing tests.

  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/Extensions3D.h: Added. (WebCore::Extensions3D::~Extensions3D):
  • platform/graphics/GraphicsContext3D.cpp:
  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/chromium/DrawingBufferChromium.cpp: (WebCore::DrawingBuffer::DrawingBuffer): (WebCore::DrawingBuffer::publishToPlatformLayer):
  • platform/graphics/chromium/Extensions3DChromium.h: Added.
  • platform/graphics/chromium/VideoLayerChromium.cpp: (WebCore::VideoLayerChromium::updateTexture):
  • platform/graphics/gpu/SharedGraphicsContext3D.cpp: (WebCore::SharedGraphicsContext3D::supportsBGRA):
  • platform/graphics/gpu/SharedGraphicsContext3D.h:
  • platform/graphics/gpu/Texture.cpp: (WebCore::convertFormat):
  • platform/graphics/mac/GraphicsContext3DMac.mm:
  • platform/graphics/opengl/Extensions3DOpenGL.cpp: Added. (WebCore::Extensions3DOpenGL::Extensions3DOpenGL): (WebCore::Extensions3DOpenGL::~Extensions3DOpenGL): (WebCore::Extensions3DOpenGL::supports): (WebCore::Extensions3DOpenGL::getGraphicsResetStatusARB):
  • platform/graphics/opengl/Extensions3DOpenGL.h: Added.
  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp: (WebCore::GraphicsContext3D::getExtensions):
  • platform/graphics/qt/Extensions3DQt.cpp: Added. (WebCore::Extensions3DQt::Extensions3DQt): (WebCore::Extensions3DQt::~Extensions3DQt): (WebCore::Extensions3DQt::supports): (WebCore::Extensions3DQt::getGraphicsResetStatusARB):
  • platform/graphics/qt/Extensions3DQt.h: Added.
  • platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3D::getExtensions):
  • platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::readbackHardwareToSoftware):
14:45 Changeset [71271] by mthole@apple.com
  • 2 edits in trunk/WebCore

Tweak coding style (follow-up to r71264).

Reviewed by Darin Adler.

  • platform/mac/Language.mm:

(WebCore::createHTTPStyleLanguageCode): Style tweaks.

14:44 Changeset [71270] by andersca@apple.com
  • 14 edits
    2 adds in trunk/WebKit2

Out of process plug-ins don't support the CA drawing model
https://bugs.webkit.org/show_bug.cgi?id=48950
<rdar://problem/8626019>

Reviewed by Simon Fraser.

  • Platform/CoreIPC/HandleMessage.h:

(CoreIPC::callMemberFunction):
Add new overload.

  • PluginProcess/PluginControllerProxy.cpp:

(WebKit::PluginControllerProxy::initialize):
Call platformInitialize().

(WebKit::PluginControllerProxy::destroy):
Call platformDestroy().

(WebKit::PluginControllerProxy::isAcceleratedCompositingEnabled):
Assume that accelerated compositing is available if we have a render server port.

(WebKit::PluginControllerProxy::geometryDidChange):
Call platformGeometryDidChange().

  • PluginProcess/PluginProcess.h:
  • PluginProcess/WebProcessConnection.cpp:

(WebKit::WebProcessConnection::createPlugin):
Pass back the remote layer client ID.

  • PluginProcess/WebProcessConnection.messages.in:

Add a remoteLayerClientID out parameter to CreatePlugin.

  • PluginProcess/mac/PluginControllerProxyMac.mm: Added.

(WebKit::PluginControllerProxy::platformInitialize):
If the plug-in has a layer, create a remote layer client and associate it with the layer.

(WebKit::PluginControllerProxy::platformDestroy):
Invalidate the remote layer client.

(WebKit::PluginControllerProxy::remoteLayerClientID):
Return the remote layer client ID if one exists.

(WebKit::PluginControllerProxy::platformGeometryDidChange):
Update the layer bounds.

  • WebKit2.xcodeproj/project.pbxproj:

Add new files.

  • WebProcess/Plugins/Netscape/mac/PluginProxyMac.mm: Added.

(WebKit::PluginProxy::pluginLayer):
Create a render layer if needed.

(WebKit::PluginProxy::needsBackingStore):
Return whether the plug-in needs a backing store. (It doesn't need a backing store if it's a CA plug-in).

  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::PluginProxy):
Initialize m_remoteLayerClientID.

(WebKit::PluginProxy::initialize):
Set m_remoteLayerClientID.

(WebKit::PluginProxy::paint):
Bail if the plug-in doesn't need a backing store.

(WebKit::PluginProxy::geometryDidChange):
Don't create a backing store if the plug-in doesn't need one.

  • WebProcess/WebPage/LayerBackedDrawingArea.cpp:

(WebKit::LayerBackedDrawingArea::LayerBackedDrawingArea):
Remove RetainPtr initialization.

  • WebProcess/WebPage/mac/LayerBackedDrawingAreaMac.mm:

(WebKit::LayerBackedDrawingArea::platformClear):
Use nullptr instead of 0.

14:32 Changeset [71269] by darin@apple.com
  • 22 edits in trunk

Updated Xcode projects by opening them with Xcode 3.2.4.
Updated svn:ignore for Xcode projects.

ANGLE:

  • ANGLE.xcodeproj: Added property svn:ignore.
  • ANGLE.xcodeproj/project.pbxproj: Updated with Xcode 3.2.4.
  • src/build_angle.xcodeproj: Added property svn:ignore.
  • src/build_angle.xcodeproj/project.pbxproj: Updated with Xcode 3.2.4.

WebCore:

  • manual-tests/NPN_Invoke/NPN_Invoke.xcodeproj: Added property svn:ignore.
  • manual-tests/NPN_Invoke/NPN_Invoke.xcodeproj/project.pbxproj: Updated with Xcode 3.2.4.

WebKitExamplePlugins:

  • NetscapeCocoaPlugin/NetscapeCocoaPlugin.xcodeproj: Added property svn:ignore.
  • NetscapeCocoaPlugin/NetscapeCocoaPlugin.xcodeproj/project.pbxproj: Updated with Xcode 3.2.4.
  • NetscapeCoreAnimationMoviePlugin/NetscapeCoreAnimationMoviePlugin.xcodeproj: Added property svn:ignore.
  • NetscapeCoreAnimationMoviePlugin/NetscapeCoreAnimationMoviePlugin.xcodeproj/project.pbxproj:
  • NetscapeCoreAnimationPlugin/NetscapeCoreAnimationPlugin.xcodeproj: Added property svn:ignore.
  • NetscapeCoreAnimationPlugin/NetscapeCoreAnimationPlugin.xcodeproj/project.pbxproj:
  • NetscapeInputMethodPlugin/NetscapeInputMethodPlugin.xcodeproj: Added property svn:ignore.
  • NetscapeInputMethodPlugin/NetscapeInputMethodPlugin.xcodeproj/project.pbxproj: Updated with Xcode 3.2.4.

WebKitTools:

  • MiniBrowser/MiniBrowser.xcodeproj: Added property svn:ignore.
  • TestWebKitAPI/TestWebKitAPI.xcodeproj: Added property svn:ignore.
  • WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
  • WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj: Updated with Xcode 3.2.4.
14:19 Changeset [71268] by mdelaney@apple.com
  • 7 edits
    2 deletes in trunk

2010-11-03 Matthew Delaney <mdelaney@apple.com>

Reviewed by Darin Adler.

Fix canvas/philip/tests/2d.pattern.image.undefined.html
https://bugs.webkit.org/show_bug.cgi?id=48894

  • bindings/js/JSCanvasRenderingContext2DCustom.cpp: Changed error thrown to match the spec.

2010-11-03 Matthew Delaney <mdelaney@apple.com>

Reviewed by Darin Adler.

Fix canvas/philip/tests/2d.pattern.image.undefined.html
https://bugs.webkit.org/show_bug.cgi?id=48894

  • canvas/philip/tests/2d.pattern.image.string.html: Updated test to agree with spec.
  • platform/mac-snowleopard/canvas/philip/tests/2d.pattern.image.null-expected.txt: Removed. Now passing.
  • platform/mac-snowleopard/canvas/philip/tests/2d.pattern.image.undefined-expected.txt: Removed. Now passing.
  • platform/mac-leopard/Skipped: Removed now passing tests.
  • platform/gtk/Skipped: Removed now passing tests.
  • platform/qt/Skipped: Removed now passing tests.
14:04 Changeset [71267] by dumi@chromium.org
  • 2 edits
    5 adds in trunk/LayoutTests

Unreviewed, updating Chromium expectations.

  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.png: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.png: Added.
  • platform/chromium/test_expectations.txt:
13:58 Changeset [71266] by simon.fraser@apple.com
  • 3 edits
    2 adds in trunk

2010-11-03 Simon Fraser <simon.fraser@apple.com>

Reviewed by John Sullivan.

Crash when setting context font to bad value
https://bugs.webkit.org/show_bug.cgi?id=48948

Null-check the CSSValue passed to CSSStyleSelector::applyPropertyToStyle(),
since it may be null if the style declaration does not contain a value
for the 'font' property.

Test: fast/canvas/invalid-set-font-crash.html

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyPropertyToStyle):
13:56 Changeset [71265] by aroben@apple.com
  • 2 edits in trunk/LayoutTests

Skip a test that is probably causing the next test to assert

See <http://webkit.org/b/48910>.

  • platform/win/Skipped: Replaced

http/tests/media/reload-after-dialog.html with
http/tests/media/pdf-served-as-pdf.html.

13:55 Changeset [71264] by mthole@apple.com
  • 2 edits in trunk/WebCore

Crash under WebCore::platformDefaultLanguage() when using Arabic language
https://bugs.webkit.org/show_bug.cgi?id=48946

Reviewed by Alexey Proskuryakov.

  • platform/mac/Language.mm:

(WebCore::createHTTPStyleLanguageCode):
Retain the lowercaseLanguageCode string before returning it. This was the code path that
would lead to a crash. Also removed early return to prevent a leak of preferredLanguageCode.

13:51 Changeset [71263] by aroben@apple.com
  • 8 edits in trunk/WebKitTools

Stop waiting for messages from the web process after a timeout elapses

TestController::runUntil now takes a timeout parameter that specifies
how long to wait for the condition to become true. WebKitTestRunner
takes a --timeout flag that specifies how long the timeout should be.
run-webkit-tests passes this flag to WebKitTestRunner so its timeout
will be similar to run-webkit-tests.

Fixes <http://webkit.org/b/43047> <rdar://problem/8365833>
WebKitTestRunner waits forever if the web process crashes

Reviewed by Darin Adler and Anders Carlsson.

  • Scripts/old-run-webkit-tests:

(top level): Moved the GuardMalloc timeout adjustment here from
readFromDumpToolWithTimer.
(openDumpTool): Make WTR use a timeout similar to but slightly shorter
than the one that was specified on the command line.

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::TestController): Initialize our timeout values.
(WTR::TestController::initialize): Parse the --timeout flag and use it
to modify our timeout values.
(WTR::TestController::resetStateToConsistentValues): Changed to use a
short timeout while waiting for the web process to reset and to return
a boolean indicating whether we were able to reset the web process.
Uses a 5-second timeout while waiting for the process to be reset.
(WTR::TestController::runTest): Changed to return a boolean indicating
whether we were able to reset the web process (and thus run the test).
(WTR::TestController::runUntil): Call through to platformRunUntil.

(WTR::TestController::runTestingServerLoop):
(WTR::TestController::run):
Changed to bail if any test can't be run. This will cause the process
to exit. (Unfortunately this will make run-webkit-tests think we
crashed; see <http://webkit.org/b/48943>.)

  • WebKitTestRunner/TestController.h: Added platformRunUntil,

m_longTimeout, and m_shortTimeout.

  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::invoke): Use a short timeout when waiting for the
initial response and a long timeout when waiting for the test to
complete. Check whether runUntil timed out and print an error message
if so.

  • WebKitTestRunner/mac/TestControllerMac.mm:

(WTR::TestController::platformRunUntil): Renamed from runUntil. Pass
[NSDate distantPast] to -[NSRunLoop runMode:beforeDate:] so that we
won't block waiting for the run loop. Only loop until the timeout
elapses.

  • WebKitTestRunner/qt/TestControllerQt.cpp:

(WTR::TestController::platformRunUntil): Renamed from runUntil. Added a
FIXME about honoring the timeout.

  • WebKitTestRunner/win/TestControllerWin.cpp:

(WTR::TestController::platformRunUntil): Renamed from runUntil. Use
::MsgWaitForMultipleObjectsEx to implement the timeout. Changed to use
::PeekMessageW so that we don't block waiting for messages to become
available.

13:44 Changeset [71262] by mitz@apple.com
  • 6 edits in trunk/WebCore

Made table column width allocation algorithms use logical widths.

Reviewed by Dave Hyatt.

Part of: Make tables work with vertical text
https://bugs.webkit.org/show_bug.cgi?id=46417

No new tests since tables don’t support different block flows yet.

  • rendering/AutoTableLayout.cpp:

(WebCore::AutoTableLayout::AutoTableLayout):
(WebCore::AutoTableLayout::recalcColumn):
(WebCore::AutoTableLayout::fullRecalc):
(WebCore::AutoTableLayout::computePreferredLogicalWidths):
(WebCore::AutoTableLayout::calcEffectiveLogicalWidth):
(WebCore::AutoTableLayout::insertSpanCell):
(WebCore::AutoTableLayout::layout):

  • rendering/AutoTableLayout.h:

(WebCore::AutoTableLayout::Layout::Layout):

  • rendering/FixedTableLayout.cpp:

(WebCore::FixedTableLayout::calcWidthArray):
(WebCore::FixedTableLayout::computePreferredLogicalWidths):
(WebCore::FixedTableLayout::layout):

  • rendering/FixedTableLayout.h:
  • rendering/RenderTable.h:

(WebCore::RenderTable::bordersPaddingAndSpacingInRowDirection): Renamed, but not changed yet.

13:34 Changeset [71261] by andersca@apple.com
  • 3 edits in trunk/WebKit2

Crash when layout in response to setSize changes the drawing area
https://bugs.webkit.org/show_bug.cgi?id=48947

Reviewed by Simon Fraser.

This is tested by compositing/plugins/small-to-large-composited-plugin.html.

  • WebProcess/WebPage/ChunkedUpdateDrawingArea.cpp:

(WebKit::ChunkedUpdateDrawingArea::setSize):

  • WebProcess/WebPage/LayerBackedDrawingArea.cpp:

(WebKit::LayerBackedDrawingArea::setSize):

13:15 Changeset [71260] by noam.rosenthal@nokia.com
  • 2 edits in trunk/WebCore

Unreviewed build fix for r71253

#endif for TILED_BACKING_STORE was at the wrong place.

  • platform/graphics/qt/GraphicsLayerQt.cpp:

(WebCore::GraphicsLayerQtImpl::tiledBackingStoreBackgroundColor):

13:11 Changeset [71259] by hyatt@apple.com
  • 3 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=48945

Reviewed by Dan Bernstein.

Patch logicalLeftSelectionOffset and logicalRightSelectionOffset to be directionally abstract.

Also make sure writing mode roots are also selection painting roots.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::isSelectionRoot):
(WebCore::RenderBlock::logicalLeftSelectionOffset):
(WebCore::RenderBlock::logicalRightSelectionOffset):

  • rendering/RenderBlock.h:
12:57 Changeset [71258] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

2010-11-03 Stephen White <senorblanco@chromium.org>

Unreviewed; test expectations update.

[Chromium] Remove mac expectations for chromium-gpu to let them fall
back to SKIP.

Covered fast/canvas/canvas-incremental-repaint.html et al.

  • platform/chromium-gpu/test_expectations.txt:
12:42 Changeset [71257] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2010-11-03 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: main resource is being re-assigned upon iframe's commit load.
https://bugs.webkit.org/show_bug.cgi?id=48940

  • inspector/front-end/ResourceManager.js: (WebInspector.ResourceManager.prototype.identifierForInitialRequest): (WebInspector.ResourceManager.prototype.didCommitLoadForFrame):
12:04 Changeset [71256] by japhet@chromium.org
  • 3 edits
    8 adds in trunk

2010-11-03 Nate Chapin <japhet@chromium.org>

Reviewed by Alexey Proskuryakov.

Wait to stop all loads for a frame being detached until after its
chidlren have been detached. This ensures that any loads started
by a child's unload event handler will be properly cancelled.
https://bugs.webkit.org/show_bug.cgi?id=46579

Tests: fast/loader/ping-error.html

http/tests/navigation/image-load-in-subframe-unload-handler.html

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::detachFromParent):
11:54 Changeset [71255] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

2010-11-03 Tony Chang <tony@chromium.org>

Unreviewed, updated test expectation due to last change.

  • editing/pasteboard/page-zoom.html:
11:38 Changeset [71254] by pfeldman@chromium.org
  • 7 edits in trunk/WebCore

2010-11-03 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Simon Fraser.

Web Inspector: show proper image size for cached resources.
https://bugs.webkit.org/show_bug.cgi?id=48915

  • inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer.prototype._onGetResourceContent):
  • inspector/front-end/ImageView.js: (WebInspector.ImageView.prototype.contentTabSelected.onImageLoad): (WebInspector.ImageView.prototype.contentTabSelected): (WebInspector.ImageView.prototype._base64ToSize):
  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkDataGridNode.prototype._refreshNameCell):
  • inspector/front-end/Resource.js: (WebInspector.Resource.prototype.set finished): (WebInspector.Resource.prototype.get content): (WebInspector.Resource.prototype.requestContent): (WebInspector.Resource.prototype._innerRequestContent):
  • inspector/front-end/ResourceManager.js: (WebInspector.ResourceManager.requestContent):
  • inspector/front-end/SourceView.js: (WebInspector.SourceView.prototype.setupSourceFrameIfNeeded):
11:33 Changeset [71253] by noam.rosenthal@nokia.com
  • 2 edits in trunk/WebCore

[Qt] GraphicsLayer: support tiling
https://bugs.webkit.org/show_bug.cgi?id=39691

Reviewed by Kenneth Rohde Christiansen.

Add support for TiledBackingStore in GraphicsLayerQt, when a layer is too large.

No new tests. Tests in LayoutTests/compositing/tiling now work with OpenGL enabled.

  • platform/graphics/qt/GraphicsLayerQt.cpp:

(WebCore::GraphicsLayerQtImpl::GraphicsLayerQtImpl):
(WebCore::GraphicsLayerQtImpl::~GraphicsLayerQtImpl):
(WebCore::GraphicsLayerQtImpl::recache):
(WebCore::GraphicsLayerQtImpl::paint):
(WebCore::GraphicsLayerQtImpl::tiledBackingStorePaintBegin):
(WebCore::GraphicsLayerQtImpl::tiledBackingStorePaint):
(WebCore::GraphicsLayerQtImpl::tiledBackingStorePaintEnd):
(WebCore::GraphicsLayerQtImpl::tiledBackingStoreContentsRect):
(WebCore::GraphicsLayerQtImpl::tiledBackingStoreBackgroundColor):
(WebCore::GraphicsLayerQtImpl::tiledBackingStoreVisibleRect):

11:29 Changeset [71252] by tony@chromium.org
  • 3 edits
    2 adds in trunk

2010-11-03 Tony Chang <tony@chromium.org>

Reviewed by Ojan Vafai.

Undo r54932 which inappropriately adjusts font sizes on zoomed pages
https://bugs.webkit.org/show_bug.cgi?id=48890

When copying zoomed text, we used to write to the clipboard the zoomed
font size. r54932 worked around this at paste time by scaling the
font size based on the zoom.

In r67568, Erik fixed getComputedStyle to return the original value
rather than the zoomed font size. This makes the work around added
by r54932 unnecessary.

The code in r54932 was busted in the first place since it only worked
when in quirks mode since it didn't add units to the font size.

  • editing/inserting/page-zoom-font-size-expected.txt: Added.
  • editing/inserting/page-zoom-font-size.html: Added.

2010-11-03 Tony Chang <tony@chromium.org>

Reviewed by Ojan Vafai.

Undo r54932 which inappropriately adjusts font sizes on zoomed pages
https://bugs.webkit.org/show_bug.cgi?id=48890

Test: editing/inserting/page-zoom-font-size.html

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::negateStyleRulesThatAffectAppearance):
11:03 Changeset [71251] by mitz@apple.com
  • 9 edits in trunk/WebCore

Make collapsed borders in tables work with different block flows
https://bugs.webkit.org/show_bug.cgi?id=46191

Reviewed by Dave Hyatt.

No new tests since tables don’t support different block flows yet.

This change still doesn’t support cells whose block flow differs from the table’s.

  • rendering/AutoTableLayout.cpp:

(WebCore::AutoTableLayout::recalcColumn): Updated for the renaming of styleOrColWidth().
(WebCore::AutoTableLayout::calcEffectiveWidth): Ditto.

  • rendering/FixedTableLayout.cpp:

(WebCore::FixedTableLayout::calcWidthArray): Ditto.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::computePreferredLogicalWidths): Ditto.

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::styleOrColLogicalWidth): Renamed styleOrColWidth() to this and
changed to use logical widths.
(WebCore::RenderTableCell::computePreferredLogicalWidths): Updated for the above rename.
(WebCore::RenderTableCell::updateLogicalWidth): Renamed updateWidth() to this and changed
to set the logical width.
(WebCore::RenderTableCell::collapsedStartBorder): Changed collapsedLeftBorder() into this.
Note that “start” here will refer to the table’s block flow, not the cell’s, once we allow
the two to differ.
(WebCore::RenderTableCell::collapsedEndBorder): Similar.
(WebCore::RenderTableCell::collapsedBeforeBorder): Similar.
(WebCore::RenderTableCell::collapsedAfterBorder): Similar.
(WebCore::RenderTableCell::collapsedLeftBorder): Resolves “left” to a logical side using
the table’s block flow.
(WebCore::RenderTableCell::collapsedRightBorder): Similar.
(WebCore::RenderTableCell::collapsedTopBorder): Similar.
(WebCore::RenderTableCell::collapsedBottomBorder): Similar.
(WebCore::RenderTableCell::borderStart): Use borderHalfStart().
(WebCore::RenderTableCell::borderEnd): Similar.
(WebCore::RenderTableCell::borderBefore): Similar.
(WebCore::RenderTableCell::borderAfter): Similar.
(WebCore::RenderTableCell::borderHalfLeft): Resolves “left” to a logical side using the
table’s block flow.
(WebCore::RenderTableCell::borderHalfRight): Similar.
(WebCore::RenderTableCell::borderHalfTop): Similar.
(WebCore::RenderTableCell::borderHalfBottom): Similar.
(WebCore::RenderTableCell::borderHalfStart): Added. Uses collapsedStartBorder(). Splits odd
widths based on physical side.
(WebCore::RenderTableCell::borderHalfEnd): Similar.
(WebCore::RenderTableCell::borderHalfBefore): Similar.
(WebCore::RenderTableCell::borderHalfAfter): Similar.
(WebCore::RenderTableCell::collectBorderStyles): Use logical methods.
(WebCore::RenderTableCell::paintCollapsedBorder): Updated.

  • rendering/RenderTableCell.h:
  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::setCellWidths): Updated for the renaming of updateWidth().

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::borderBefore): Added.
(WebCore::RenderStyle::borderAfter): Added.
(WebCore::RenderStyle::borderStart): Added.
(WebCore::RenderStyle::borderEnd): Adeed.

  • rendering/style/RenderStyle.h:
10:46 Changeset [71250] by dglazkov@chromium.org
  • 3 edits in trunk/WebCore

2010-11-03 Dimitri Glazkov <dglazkov@chromium.org>

Fix Win build correctly after r71244 and r71248

  • WebCore.vcproj/WebCore.vcproj: Added XML gobbledygook back.
  • dom/DOMAllInOne.cpp: Added files to build into a combined file.
10:32 Changeset [71249] by aroben@apple.com
  • 11 edits
    3 adds
    2 deletes in trunk

Add a plugin test that evaluates JS after removing the plugin element from the document

This test replaces platform/win/plugins/plugin-delayed-destroy.html.
That test was made to prevent a crash very similar to this one, but
unfortunately tested only the mechanism that prevented the crash and
not whether the crash itself was prevented. Since WebKit2 uses a
different mechanism to prevent the crash, the test was failing even
though WebKit2 was not vulnerable to the crash. This new test crashes
if there is no mechanism in place to prevent it and passes in both
WebKit1 and WebKit2.

Fixes <http://webkit.org/b/46711> <rdar://problem/8485903>
platform/win/plugins/plugin-delayed-destroy.html fails in WebKit2

Reviewed by Anders Carlsson.

WebKitTools:

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
  • DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
  • GNUmakefile.am:

Added new file.

  • DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:

(pluginDeallocate): Make sure we delete the PluginTest object. This
prevents a leak and also allows us to test the crash.

  • DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:

(PluginTest::executeScript): Made this into a non-static member
function.

(PluginTest::waitUntilDone):
(PluginTest::notifyDone):
Updated for changes to executeScript.

  • DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Added executeScript.
  • DumpRenderTree/TestNetscapePlugIn/Tests/EvaluateJSAfterRemovingPluginElement.cpp: Added.

(EvaluateJSAfterRemovingPluginElement::EvaluateJSAfterRemovingPluginElement):
Initialize ourselves and tell the test harness to wait.
(EvaluateJSAfterRemovingPluginElement::NPP_DestroyStream): Remove our
plugin element from the document, then execute some JavaScript. If
WebKit does not have appropriate mechanisms in place, we'll be
destroyed inside the first call to executeScript and crash on the
second call.

LayoutTests:

  • platform/mac/Skipped: Added the new test, which fails in WebKit1 on SnowLeopard.
  • platform/win-wk2/Skipped: Removed platform/win/plugins/plugin-delayed-destroy.html.
  • platform/win/plugins/plugin-delayed-destroy-expected.txt: Removed.
  • platform/win/plugins/plugin-delayed-destroy.html: Removed.
  • plugins/evaluate-js-after-removing-plugin-element-expected.txt: Added.
  • plugins/evaluate-js-after-removing-plugin-element.html: Added.
10:30 Changeset [71248] by dglazkov@chromium.org
  • 3 edits in trunk/WebCore

Fix Qt, Win builds after r71244.

  • WebCore.vcproj/WebCore.vcproj: Removed XML gobbledygook that prevents files from building.
  • dom/Text.cpp:

(WebCore::Text::createRenderer): Moved parentOrHost inside ENABLE(SVG) guard.

10:21 UpdatingBugzilla edited by ddkilzer@webkit.org
(diff)
10:17 Changeset [71247] by andersca@apple.com
  • 8 edits
    3 adds in trunk/WebKit2

Pass the accelerated compositing render server port to the plug-in process at startup
https://bugs.webkit.org/show_bug.cgi?id=48925

Reviewed by Adam Roben.

  • PluginProcess/PluginProcess.cpp:

(WebKit::PluginProcess::PluginProcess):
Initialize m_compositingRenderServerPort to MACH_PORT_NULL.

(WebKit::PluginProcess::initialize):
Get the plug-in path and render server port from the creation parameters.

  • PluginProcess/PluginProcess.messages.in:

Change the Initialize message to take a PluginProcessCreationParameters struct.

  • Shared/Plugins/PluginProcessCreationParameters.cpp: Added.
  • Shared/Plugins/PluginProcessCreationParameters.h: Added.

Add new PluginProcessCreationParameters struct.

  • UIProcess/Plugins/PluginProcessProxy.cpp:

(WebKit::PluginProcessProxy::didFinishLaunching):
Initialize now takes a PluginProcessCreationParameters struct.

  • UIProcess/Plugins/mac/PluginProcessProxyMac.mm: Added.

(WebKit::PluginProcessProxy::platformInitializePluginProcess):
Initialize the render server port.

  • WebKit2.xcodeproj/project.pbxproj:

Add new files.

10:16 Changeset [71246] by hyatt@apple.com
  • 4 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=48928

Reviewed by Dan Bernstein.

Rename all the selection gap functions to not be directionally specific. Left and Right turn into LogicalLeft and
LogicalRight. Horizontal becomes Line. Vertical becomes Block.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::selectionGapRectsForRepaint):
(WebCore::RenderBlock::paintSelection):
(WebCore::RenderBlock::fillSelectionGaps):
(WebCore::RenderBlock::fillInlineSelectionGaps):
(WebCore::RenderBlock::fillBlockSelectionGaps):
(WebCore::RenderBlock::fillLineSelectionGap):
(WebCore::RenderBlock::fillBlockSelectionGap):
(WebCore::RenderBlock::fillLogicalLeftSelectionGap):
(WebCore::RenderBlock::fillLogicalRightSelectionGap):
(WebCore::RenderBlock::getSelectionGapInfo):
(WebCore::RenderBlock::logicalLeftSelectionOffset):
(WebCore::RenderBlock::logicalRightSelectionOffset):

  • rendering/RenderBlock.h:
  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::fillLineSelectionGap):

10:13 Changeset [71245] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

2010-11-03 Stephen White <senorblanco@chromium.org>

Unreviewed; test expectations update.

[Chromium] Update chromium-gpu test expectations. Most of this
consists of updates to the shared canvas section. The rest adds
a failing test on windows, and some timeouts on mac. The canvas2D
tests are skipped again on the Mac, since accelerated canvas 2D
has not been implemented yet, so there's no point in rebaselining.

  • platform/chromium-gpu/test_expectations.txt:
10:02 Changeset [71244] by dglazkov@chromium.org
  • 22 edits
    4 adds in trunk

2010-11-03 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Darin Adler.

Implement shadow DOM-aware event targeting and introduce EventContext to track the context of each event dispatch.
https://bugs.webkit.org/show_bug.cgi?id=46015

Tuned shadow-boundary-crossing.html to better reflect its point: the event should indeed fire (it used to be swallowed),
but its target should be a non-shadow node.

Tweaked audio-delete-while-slider-thumb-clicked.html to actually click on
the scrubber thumb (it was off by 2 pixels).

  • fast/events/shadow-boundary-crossing.html: Modified the test.
  • media/audio-delete-while-slider-thumb-clicked.html : Ditto.

2010-11-03 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Darin Adler.

Implement shadow DOM-aware event targeting and introduce EventContext to track the context of each event dispatch.
https://bugs.webkit.org/show_bug.cgi?id=46015

This patch adds the notion of EventContext (and a very similar-acting WindowEventContext, specifically
for DOMWindow), an abstraction that carries information around dispatching an event for any given Node.

This abstraction is necessary to ensure that events, fired from shadow DOM nodes are properly retargeted to
appear as if they are coming from their host, thus never exposing the shadow DOM nodes to the world outside.

  • Android.mk: Added EventContext, WindowEventContext files.
  • CMakeLists.txt: Ditto.
  • GNUmakefile.am: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • dom/ContainerNode.cpp: (WebCore::notifyChildInserted): Changed to be shadow DOM-aware.
  • dom/EventContext.cpp: Added.
  • dom/EventContext.h: Added.
  • dom/Node.cpp: (WebCore::Node::markAncestorsWithChildNeedsStyleRecalc): Changed to be shadow DOM-aware. (WebCore::Node::createRendererIfNeeded): Ditto. (WebCore::Node::parentOrHostNode): Added new helper method. (WebCore::Node::enclosingLinkEventParentOrSelf): Changed to be shadow DOM-aware. (WebCore::eventTargetRespectingSVGTargetRules): Collapsed two helper methods into one. (WebCore::Node::eventAncestors): Refactored to collect a vector of EventContexts. (WebCore::Node::topEventContext): Added. (WebCore::eventHasListeners): Changed to use EventContexts. (WebCore::Node::dispatchGenericEvent): Ditto.
  • dom/Node.h: Removed eventParentNode that's no longer needed, added parentOrHostNode decl,

and changed signature of eventAncestors to use EventContexts.

  • dom/Text.cpp: (WebCore::Text::createRenderer): Changed to be shadow DOM-aware.
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::getEventListenersForNode): Changed to use EventContexts.
  • page/EventHandler.cpp: (WebCore::EventHandler::updateMouseEventTargetNode): Removed code that's no longer necessary.
  • rendering/ShadowElement.h: Made m_shadowParent a RefPtr to avoid stale references when parent is deleted.
  • svg/SVGElement.cpp: Removed eventParentNode that's no longer needed.
  • svg/SVGElement.h: Ditto.
  • dom/WindowEventContext.cpp: Added.
  • dom/WindowEventContext.h: Added.
08:58 Changeset [71243] by vestbo@webkit.org
  • 2 edits in trunk/WebKit2

[Qt] Add the webkit2 library to LIBS instead of QMAKE_LFLAGS

Reviewed by Kenneth Rohde Christiansen.

Otherwise the library order will get messed up and cause
missing symbols on Mac OS X.

  • WebKit2.pri:
  • WebKit2.pro:
08:47 Changeset [71242] by mnaganov@chromium.org
  • 3 edits in trunk/WebCore

2010-11-02 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Fix console messages about starting and finishing profiling.

https://bugs.webkit.org/show_bug.cgi?id=48825

  • inspector/InspectorProfilerAgent.cpp: (WebCore::InspectorProfilerAgent::addStartProfilingMessageToConsole):
  • inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype.displayTitleForProfileLink):
08:46 Changeset [71241] by andreas.kling@nokia.com
  • 2 edits in trunk/WebKit/qt

2010-11-03 Andreas Kling <kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] QGWV: Keep the scrolling delegation intact when switching pages

  • Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::updateResizesToContentsForPage): Turn on/off scrolling delegation depending on the resizeToContents mode. (QGraphicsWebViewPrivate::detachCurrentPage): Turn off scrolling delegation. (QGraphicsWebView::setResizesToContents):
08:44 Changeset [71240] by zimmermann@webkit.org
  • 4 edits
    2 adds in trunk

2010-11-03 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Andreas Kling.

chrome.dll!WebCore::SVGLength::SVGLength ...
https://bugs.webkit.org/show_bug.cgi?id=48831

Test: svg/dom/baseVal-animVal-crash.html

  • svg/properties/SVGListPropertyTearOff.h: (WebCore::SVGListPropertyTearOff::initialize): Renamed removeItemFromListIfNeeded to processIncomingListItem, to reflect its new job. (WebCore::SVGListPropertyTearOff::insertItemBefore): Ditto. (WebCore::SVGListPropertyTearOff::replaceItem): Ditto. (WebCore::SVGListPropertyTearOff::appendItem): Ditto. (WebCore::SVGListPropertyTearOff::processIncomingListItem): Copy incoming item, if necessary, see inline comments.
  • svg/properties/SVGPropertyTearOff.h: (WebCore::SVGPropertyTearOff::detachWrapper): Remove association with SVGAnimatedProperty, when wrapper is detached.

2010-11-03 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Andreas Kling.

chrome.dll!WebCore::SVGLength::SVGLength ...
https://bugs.webkit.org/show_bug.cgi?id=48831

  • svg/dom/baseVal-animVal-crash-expected.txt: Added.
  • svg/dom/baseVal-animVal-crash.html: Added.
08:00 Changeset [71239] by andreas.kling@nokia.com
  • 9 edits in trunk

2010-11-03 Kenneth Rohde Christiansen <kenneth@webkit.org>

Reviewed by Andreas Kling.

Make it possible to delegate scrolling to the UI
https://bugs.webkit.org/show_bug.cgi?id=48907

Enable scrolling delegation when setResizesToContents is active.

  • Api/qgraphicswebview.cpp: (QGraphicsWebView::setResizesToContents):

2010-11-03 Kenneth Rohde Christiansen <kenneth@webkit.org>

Reviewed by Andreas Kling.

Make it possible to delegate scrolling to the UI
https://bugs.webkit.org/show_bug.cgi?id=48907

Add a WebCore setting for delegating scrolling to the actual
WebKit view, which means that setScrollPosition will call
scrollContents directly without going though the scrollbar
code.

  • page/FrameView.cpp: (WebCore::FrameView::delegatesScrolling):
  • page/FrameView.h:
  • page/Settings.cpp: (WebCore::Settings::Settings): (WebCore::Settings::setShouldDelegateScrolling):
  • page/Settings.h: (WebCore::Settings::shouldDelegateScrolling):
  • platform/ScrollView.cpp: (WebCore::ScrollView::setScrollPosition):
  • platform/ScrollView.h: (WebCore::ScrollView::delegatesScrolling):
07:50 Changeset [71238] by senorblanco@chromium.org
  • 2 edits in trunk/WebKitTools

2010-11-02 Stephen White <senorblanco@chromium.org>

Reviewed by Tony Chang.

[chromium] Fix LayoutTestController UMRs.
https://bugs.webkit.org/show_bug.cgi?id=48872

  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController):
07:38 Changeset [71237] by paroga@webkit.org
  • 2 edits
    2 adds in trunk/WebCore

2010-11-03 Patrick Gansterer <paroga@webkit.org>

Reviewed by Adam Roben.

[WINCE] Add SharedBitmap
https://bugs.webkit.org/show_bug.cgi?id=28272

SharedBitmap is a helper class used as NativeImagePtr for WinCE.
It's wide used by WinCE graphics files as a replacement of HBITMAP.

Originally written by Yong Li <yong.li@torchmobile.com>.

  • platform/graphics/wince/GraphicsContextWinCE.cpp: (WebCore::TransparentLayerDC::TransparentLayerDC): (WebCore::TransparentLayerDC::~TransparentLayerDC): (WebCore::ScopeDCProvider::ScopeDCProvider): (WebCore::ScopeDCProvider::~ScopeDCProvider): (WebCore::GraphicsContext::drawText):
  • platform/graphics/wince/SharedBitmap.cpp: Added. (WebCore::SharedBitmap::create): (WebCore::SharedBitmap::SharedBitmap): (WebCore::SharedBitmap::~SharedBitmap): (WebCore::SharedBitmap::resetPixels): (WebCore::convert32To16): (WebCore::SharedBitmap::to16bit): (WebCore::SharedBitmap::freeMemory): (WebCore::SharedBitmap::createHandle): (WebCore::SharedBitmap::ensureHandle): (WebCore::SharedBitmap::draw): (WebCore::SharedBitmap::clipBitmap): (WebCore::drawPatternSimple): (WebCore::normalizePhase): (WebCore::SharedBitmap::drawPattern): (WebCore::SharedBitmap::DCProvider::getDC): (WebCore::SharedBitmap::DCProvider::releaseDC): (WebCore::SharedBitmap::clearPixels):
  • platform/graphics/wince/SharedBitmap.h: Added. (WebCore::DCProvider::getDC): (WebCore::DCProvider::releaseDC): (WebCore::DCProvider::DCHolder::DCHolder): (WebCore::DCProvider::DCHolder::~DCHolder): (WebCore::DCProvider::DCHolder::set): (WebCore::DCProvider::DCHolder::get): (WebCore::DCProvider::DCHolder::clearInternal): (WebCore::DCProvider::DCHolder::setInternal):
07:12 Changeset [71236] by zimmermann@webkit.org
  • 4 edits
    2 adds in trunk

2010-11-03 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

chrome.dll!WebCore::SVGListPropertyTearOff<...>::getItem ReadAV@NULL (578c0f7f21ca517ba29a4eafb7099c1b)
https://bugs.webkit.org/show_bug.cgi?id=48829

Share SVGPropertyTearOff wrapper cache between SVGAnimatedListPropertyTearOff::baseVal/animVal.
When modifying the list through baseVal, and then grabbing the animVal list an assertion was fired,
as the wrapper cache was out of sync with the underlying SVG*List vector.

Test: svg/dom/baseVal-animVal-list-crash.html

  • svg/properties/SVGAnimatedListPropertyTearOff.h: (WebCore::SVGAnimatedListPropertyTearOff::baseVal): (WebCore::SVGAnimatedListPropertyTearOff::animVal): (WebCore::SVGAnimatedListPropertyTearOff::removeItemFromList): (WebCore::SVGAnimatedListPropertyTearOff::detachListWrappers): (WebCore::SVGAnimatedListPropertyTearOff::values): (WebCore::SVGAnimatedListPropertyTearOff::wrappers): (WebCore::SVGAnimatedListPropertyTearOff::create): (WebCore::SVGAnimatedListPropertyTearOff::SVGAnimatedListPropertyTearOff):
  • svg/properties/SVGListPropertyTearOff.h: (WebCore::SVGListPropertyTearOff::create): (WebCore::SVGListPropertyTearOff::removeItemFromList): (WebCore::SVGListPropertyTearOff::clear): (WebCore::SVGListPropertyTearOff::numberOfItems): (WebCore::SVGListPropertyTearOff::initialize): (WebCore::SVGListPropertyTearOff::getItem): (WebCore::SVGListPropertyTearOff::insertItemBefore): (WebCore::SVGListPropertyTearOff::replaceItem): (WebCore::SVGListPropertyTearOff::removeItem): (WebCore::SVGListPropertyTearOff::appendItem): (WebCore::SVGListPropertyTearOff::SVGListPropertyTearOff): (WebCore::SVGListPropertyTearOff::commitChange):

2010-11-03 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

chrome.dll!WebCore::SVGListPropertyTearOff<...>::getItem ReadAV@NULL (578c0f7f21ca517ba29a4eafb7099c1b)
https://bugs.webkit.org/show_bug.cgi?id=48829

  • svg/dom/baseVal-animVal-list-crash-expected.txt: Added.
  • svg/dom/baseVal-animVal-list-crash.html: Added.
07:10 Changeset [71235] by loislo@chromium.org
  • 3 edits in trunk/WebCore

2010-11-02 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Remove obsolete code.
It is not required to push onload and DOMContentLoaded events times to the fresh instance of Inspector.
Network Panel is showing the markers only after reloading the inspected page.
https://bugs.webkit.org/show_bug.cgi?id=48854

  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::populateScriptObjects): (WebCore::InspectorController::mainResourceFiredDOMContentEvent): (WebCore::InspectorController::mainResourceFiredLoadEvent):
  • inspector/InspectorController.h:
06:49 Changeset [71234] by pfeldman@chromium.org
  • 5 edits in trunk/WebCore

2010-11-03 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Jeremy Orlow.

Web Inspector: brush up breakpoints UI and UX.
https://bugs.webkit.org/show_bug.cgi?id=48901

  • inspector/front-end/BreakpointManager.js: (WebInspector.DOMBreakpoint.prototype.populateLabelElement): (WebInspector.XHRBreakpoint.prototype.populateLabelElement):
  • inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.BreakpointsSidebarPane.prototype.addBreakpointItem): (WebInspector.XHRBreakpointsSidebarPane.prototype.addBreakpointItem): (WebInspector.XHRBreakpointsSidebarPane.prototype._hideEditBreakpointDialog): (WebInspector.BreakpointItem):
  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype._populateTagContextMenu.handlerFunction): (WebInspector.ElementsTreeElement.prototype._populateTagContextMenu):
  • inspector/front-end/PropertiesSection.js: (WebInspector.PropertiesSection):
  • inspector/front-end/inspector.css: (.monospace): (body.platform-mac.platform-mac-snowleopard .source-code): (body.platform-windows .monospace, body.platform-windows .source-code): (body.platform-linux .monospace, body.platform-linux .source-code): (.source-code): (.section .header): (.section .header::before): (.section .header .title, .event-bar .header .title): (.section .header .subtitle, .event-bar .header .subtitle): (.section.expanded .properties, .event-bar.expanded .event-properties): (.event-listener-breakpoints .event-category): (.event-listener-breakpoints.properties-tree .children li): (.event-listener-breakpoints .checkbox-elem): (.event-bar): (.event-bars .event-bar .header .title): (.event-bars .event-bar .header::before): (.pane > .body .info): (.pane > .body .placard + .info): (ol.breakpoint-list): (.breakpoint-list li): (.pane .breakpoint-hit): (.cursor-pointer): (.cursor-auto):
06:32 Changeset [71233] by aroben@apple.com
  • 2 edits in trunk/LayoutTests

Add some more failing tests to the Windows Skipped file

  • platform/win/Skipped:
06:30 TriagingTestFailures edited by aroben@apple.com
Note that the bug should be updated once you add the test to the Skipped … (diff)
06:27 TriagingTestFailures edited by aroben@apple.com
Added notes about whom to CC on bugs (diff)
05:15 Changeset [71232] by zimmermann@webkit.org
  • 2 edits in trunk/WebCore

2010-11-03 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed.

Convert SVGAnimatedString/SVGStringList to the new SVG*PropertyTearOff concept
https://bugs.webkit.org/show_bug.cgi?id=48898

Fix Chromium/V8 build for real, verified using a local ToT Chromium build.

  • bindings/scripts/CodeGeneratorV8.pm:
04:37 Changeset [71231] by aroben@apple.com
  • 2 edits in trunk/JavaScriptCore

Bring WTF.vcproj up to date

unicode directories, added new files, removed old files.

04:33 Changeset [71230] by zimmermann@webkit.org
  • 2 edits in trunk/WebCore

2010-11-03 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed.

Convert SVGAnimatedString/SVGStringList to the new SVG*PropertyTearOff concept
https://bugs.webkit.org/show_bug.cgi?id=48898

Next attempt to fix the Chromium/V8 builds - a class forward in the headers was still missing.

  • bindings/scripts/CodeGeneratorV8.pm: Add SVGStringListPropertyTearOff in the V8SVGStringList header.
04:23 Changeset [71229] by zimmermann@webkit.org
  • 2 edits in trunk/WebCore

2010-11-03 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed.

Convert SVGAnimatedString/SVGStringList to the new SVG*PropertyTearOff concept
https://bugs.webkit.org/show_bug.cgi?id=48898

Attempt to fix the Chromium/V8 builds.

  • bindings/scripts/CodeGeneratorV8.pm: Add missing "SVGStringListPropertyTearOff.h" include, also replaces some commas by semicolons (no idea why it worked before, Perl is not strict...)
04:20 Changeset [71228] by tkent@chromium.org
  • 3 edits in trunk/WebKitTools

2010-11-03 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

REGRESSION: rebaseline-chromium-webkit-tests uses non-zero tolerance for
image dup detection
https://bugs.webkit.org/show_bug.cgi?id=48744

  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
    • Make a function for option parsing for ease of test
    • Set 0 to options.tolerance
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
    • Add a test for this change
04:13 Changeset [71227] by zimmermann@webkit.org
  • 54 edits
    9 adds in trunk

2010-11-03 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Convert SVGAnimatedString/SVGStringList to the new SVG*PropertyTearOff concept
https://bugs.webkit.org/show_bug.cgi?id=48898

Convert SVGAnimatedString/SVGStringList to the new svg animated type concept.
SVGStringList is special compared to all other SVG*Lists, as it returns non-live elements.
That means myStringList.getItem(0) = 'foobar' doesn't take effect.

When appending an item to a SVGStringList, that has been taken from another list, it's not removed from the list origin.
That demanded a new SVGStringListPropertyTearOff which does just that.

Tests: svg/W3C-SVG-1.1-SE/types-dom-06-f.svg

svg/dom/SVGStringList.html

  • GNUmakefile.am: Add SVGAnimatedString.h / SVGStringListPropertyTearOff.h to build.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • bindings/scripts/CodeGenerator.pm: Recognize SVGAnimatedString as new style svg animated type. Map SVGStringList to SVGStringListPropertyTearOff.
  • bindings/scripts/CodeGeneratorJS.pm: Handle SVGStringListPropertyTearOff in GetSVGPropertyTypes.
  • bindings/scripts/CodeGeneratorObjC.pm: Ditto.
  • bindings/scripts/CodeGeneratorV8.pm: Ditto.
  • svg/DeprecatedSVGAnimatedPropertyTraits.h: Remove SVGAnimatedString handling.
  • svg/DeprecatedSVGAnimatedTemplate.h: Ditto.
  • svg/SVGAElement.cpp: Renamed target to svgTarget() to avoid clashes with Element::target(), adjust the bindings to call svgTarget() instead of target(), when processing SVGAElement. (WebCore::SVGAElement::parseMappedAttribute): (WebCore::SVGAElement::synchronizeProperty):
  • svg/SVGAElement.h:
  • svg/SVGAltGlyphElement.h: s/DECLARE_ANIMATED_PROPERTY/DECLARED_ANIMATED_STATIC_PROPERTY_NEW/
  • svg/SVGAnimatedString.h: Added.
  • svg/SVGCursorElement.h: Ditto.
  • svg/SVGFEBlendElement.h: Ditto.
  • svg/SVGFEColorMatrixElement.h: Ditto.
  • svg/SVGFEComponentTransferElement.h: Ditto.
  • svg/SVGFECompositeElement.h: Ditto.
  • svg/SVGFEConvolveMatrixElement.h: Ditto.
  • svg/SVGFEDiffuseLightingElement.h: Ditto.
  • svg/SVGFEDisplacementMapElement.h: Ditto.
  • svg/SVGFEGaussianBlurElement.h: Ditto.
  • svg/SVGFEImageElement.h: Ditto.
  • svg/SVGFEMergeNodeElement.h: Ditto.
  • svg/SVGFEMorphologyElement.h: Ditto.
  • svg/SVGFEOffsetElement.h: Ditto.
  • svg/SVGFESpecularLightingElement.h: Ditto.
  • svg/SVGFETileElement.h: Ditto.
  • svg/SVGFilterElement.h: Ditto.
  • svg/SVGFilterPrimitiveStandardAttributes.h: Ditto.
  • svg/SVGForeignObjectElement.h: Ditto.
  • svg/SVGGradientElement.h: Ditto.
  • svg/SVGImageElement.h: Ditto.
  • svg/SVGLengthList.idl: Remove leftover SVGListProperty marker.
  • svg/SVGMPathElement.h: s/DECLARE_ANIMATED_PROPERTY/DECLARED_ANIMATED_STATIC_PROPERTY_NEW/
  • svg/SVGPatternElement.h: Ditto.
  • svg/SVGScriptElement.h: Ditto.
  • svg/SVGStringList.cpp: Make SVGStringList a plain Vector<String>. (WebCore::SVGStringList::commitChange): React to SVGStringList changes. (WebCore::SVGStringList::reset): (WebCore::SVGStringList::parse):
  • svg/SVGStringList.h: (WebCore::SVGStringList::SVGStringList):
  • svg/SVGStyledElement.h: s/DECLARE_ANIMATED_PROPERTY/DECLARED_ANIMATED_STATIC_PROPERTY_NEW/
  • svg/SVGTRefElement.h: Ditto.
  • svg/SVGTests.cpp: Adapt to SVGStringList API changes. (WebCore::SVGTests::SVGTests): (WebCore::SVGTests::hasExtension): (WebCore::SVGTests::isValid): (WebCore::SVGTests::parseMappedAttribute): (WebCore::SVGTests::isKnownAttribute):
  • svg/SVGTests.h: Ditto. (WebCore::SVGTests::requiredFeatures): (WebCore::SVGTests::requiredExtensions): (WebCore::SVGTests::systemLanguage):
  • svg/SVGTextPathElement.h: s/DECLARE_ANIMATED_PROPERTY/DECLARED_ANIMATED_STATIC_PROPERTY_NEW/
  • svg/SVGURIReference.h: Adapt to SVGStringList API changes. (WebCore::SVGURIReference::~SVGURIReference):
  • svg/SVGUseElement.h: s/DECLARE_ANIMATED_PROPERTY/DECLARED_ANIMATED_STATIC_PROPERTY_NEW/
  • svg/SVGViewElement.cpp: Adapt to SVGStringList API changes. (WebCore::SVGViewElement::SVGViewElement): (WebCore::SVGViewElement::parseMappedAttribute):
  • svg/SVGViewElement.h: Ditto. (WebCore::SVGViewElement::viewTarget):
  • svg/properties/SVGAnimatedPropertyMacros.h: Moved GetOwnerElementForType heleprs from SVGAnimatedPropertySynchronizer into this file.
  • svg/properties/SVGAnimatedPropertySynchronizer.h:
  • svg/properties/SVGPropertyTraits.h: Handle SVGStringList.
  • svg/properties/SVGStringListPropertyTearOff.h: Added. This is a simplified version of SVGListPropertyTearOff, tied to SVGStringList and its special demands. (WebCore::SVGStringListPropertyTearOff::create): (WebCore::SVGStringListPropertyTearOff::clear): (WebCore::SVGStringListPropertyTearOff::numberOfItems): (WebCore::SVGStringListPropertyTearOff::initialize): (WebCore::SVGStringListPropertyTearOff::getItem): (WebCore::SVGStringListPropertyTearOff::insertItemBefore): (WebCore::SVGStringListPropertyTearOff::replaceItem): (WebCore::SVGStringListPropertyTearOff::removeItem): (WebCore::SVGStringListPropertyTearOff::appendItem): (WebCore::SVGStringListPropertyTearOff::SVGStringListPropertyTearOff):

2010-11-03 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Convert SVGAnimatedString/SVGStringList to the new SVG*PropertyTearOff concept
https://bugs.webkit.org/show_bug.cgi?id=48898

Add a new SVGStringList test ensuring that the items returned by getItem etc. are not live (it's a plain DOMString).
Add a new test from SVG 1.1 2nd edition regarding SVGStringList. The list operations all pass, but because of a bug
in SVGTests requiredFeatures handling (see bug 40887) there's still one red rectangle in the middle.

  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.checksum: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.png: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt: Added.
  • svg/W3C-SVG-1.1-SE/types-dom-06-f.svg: Added.
  • svg/dom/SVGStringList-expected.txt: Added.
  • svg/dom/SVGStringList.html: Added.
  • svg/dom/script-tests/SVGStringList.js: Added.
03:14 Changeset [71226] by loki@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-11-03 Gabor Loki <loki@webkit.org>

Reviewed by Andreas Kling.

Remove unused initializeWeakRandomNumberGenerator
https://bugs.webkit.org/show_bug.cgi?id=48899

WeakRandom class is used instead of weakRandomNumber and its initializer.

  • wtf/RandomNumberSeed.h:
02:48 Changeset [71225] by dbates@webkit.org
  • 1 edit
    1 delete in trunk/LayoutTests

2010-11-03 Daniel Bates <dbates@rim.com>

Rubber-stamped by Nikolas Zimmermann.

Remove the platform-specific GTK results following changeset 71218
<http://trac.webkit.org/changeset/71218> since it is sufficient to
use the platform-independent results, LayoutTests/svg/css/getComputedStyle-basic-expected.txt.

  • platform/gtk/svg/css/getComputedStyle-basic-expected.txt: Removed.
02:25 Changeset [71224] by rolandsteiner@chromium.org
  • 4 edits in trunk/LayoutTests

2010-11-03 Roland Steiner <rolandsteiner@chromium.org>

Unreviewed: additionally update Windows Chromium expectations after WebKit r71218

  • platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
01:55 Changeset [71223] by rolandsteiner@chromium.org
  • 4 edits in trunk/LayoutTests

2010-11-03 Roland Steiner <rolandsteiner@chromium.org>

Unreviewed: update Chromium expectations after WebKit r71218

  • platform/chromium-mac/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-mac/svg/css/getComputedStyle-basic-expected.txt:
01:36 Changeset [71222] by zherczeg@webkit.org
  • 7 edits in trunk/WebCore

SVG FELighting performance issues
https://bugs.webkit.org/show_bug.cgi?id=48212

Reviewed by Dirk Schulze.

This patch speeds-up FELighting filter painting by 40%
It reduces the number of floating point operations and
empolys faster pixel manipulation (both for read and
write). Furthermore the length() member of FloatPoint3D
is made inline to speed up vector length calculations.

The lighting filter pixels tests are cover this patch.

  • platform/graphics/FloatPoint3D.cpp:
  • platform/graphics/FloatPoint3D.h:

(WebCore::FloatPoint3D::length):

  • platform/graphics/filters/FELighting.cpp:

(WebCore::FELighting::LightingData::topLeft):
(WebCore::FELighting::LightingData::topRow):
(WebCore::FELighting::LightingData::topRight):
(WebCore::FELighting::LightingData::leftColumn):
(WebCore::FELighting::LightingData::interior):
(WebCore::FELighting::LightingData::rightColumn):
(WebCore::FELighting::LightingData::bottomLeft):
(WebCore::FELighting::LightingData::bottomRow):
(WebCore::FELighting::LightingData::bottomRight):
(WebCore::FELighting::inlineSetPixel):
(WebCore::FELighting::setPixel):
(WebCore::FELighting::drawLighting):
(WebCore::FELighting::apply):

  • platform/graphics/filters/FELighting.h:
  • platform/graphics/filters/LightSource.cpp:

(WebCore::PointLightSource::updatePaintingData):
(WebCore::SpotLightSource::updatePaintingData):
(WebCore::DistantLightSource::initPaintingData):

  • platform/graphics/filters/LightSource.h:
01:33 Changeset [71221] by philn@webkit.org
  • 2 edits in trunk/LayoutTests

2010-11-03 Philippe Normand <pnormand@igalia.com>

Unreviewed, unskipping passing media test.

[GTK] Need results for media/video-poster-scale.html
https://bugs.webkit.org/show_bug.cgi?id=33541

  • platform/gtk/Skipped: Unskip media/video-poster-scale.html.
01:21 Changeset [71220] by loki@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-11-03 Gabor Loki <loki@webkit.org>

Reviewed by Geoffrey Garen.

Unused class: JSFastMath with JSValue64
https://bugs.webkit.org/show_bug.cgi?id=48835

Remove unused JSFastMath class.

  • runtime/JSImmediate.h:
00:48 Changeset [71219] by dbates@webkit.org
  • 12 edits in trunk

2010-11-03 Daniel Bates <dbates@rim.com>

Reviewed by Adam Barth.

For unnamed frames, window.name returns a generated name
https://bugs.webkit.org/show_bug.cgi?id=6751

Part 2 of 2.

Fixes an issue where the window.name of an unnamed frame returns
a unique generated name that is used internally to identify the
frame. Instead, we should return an empty string as implied by
section 5.1.6 of the HTML5 spec. (http://www.w3.org/TR/html5/browsers.html#browsing-context-names).
This section describes that a browsing context can have no name or be
the empty string.

  • html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::openURL): Removed ASSERT for empty frame name since this is valid as per the HTML5 spec. (WebCore::HTMLFrameElementBase::setName): Removed the call to FrameTree::uniqueChildName() since the loader code no longer depends on the frame name being unique.
  • page/DOMWindow.cpp: (WebCore::DOMWindow::name): Modified to call FrameTree::name().
  • page/FrameTree.cpp: (WebCore::FrameTree::setName): (WebCore::FrameTree::clearName):
  • page/FrameTree.h: (WebCore::FrameTree::name): Re-added; returns the DOM-specified name of the frame. Previously, this method returned the internal frame name.

2010-11-03 Daniel Bates <dbates@rim.com>

Reviewed by Adam Barth.

For unnamed frames, window.name returns a generated name
https://bugs.webkit.org/show_bug.cgi?id=6751

Part 2 of 2.

Updated resources of test case fast/frames/frame-element-name.html to
check the value of window.name. Also modified test case fast/frames/iframe-set-inner-html.html
to use layoutTestController.dumpChildFramesAsText() and rebased the
results of http/tests/security/cross-frame-access-put-expected.txt.

  • fast/frames/frame-element-name-expected.txt: Updated results.
  • fast/frames/iframe-set-inner-html-expected.txt: Updated results.
  • fast/frames/iframe-set-inner-html.html: Modified test to use layoutTestController.dumpChildFramesAsText() instead of window.name. since window.name no longer exposes the WebKit internal frame name.
  • fast/frames/resources/frame-element-name-left.html: Added test for window.name.
  • fast/frames/resources/frame-element-name-right.html: Ditto.
  • http/tests/security/cross-frame-access-put-expected.txt: Updated results.
00:45 Changeset [71218] by commit-queue@webkit.org
  • 17 edits
    2 adds in trunk

2010-11-03 takano takumi <takano1@asia.apple.com>

Reviewed by Dan Bernstein.

Add text-combine property to our property list. Reflect the setting to a RenderStyle object.
https://bugs.webkit.org/show_bug.cgi?id=48608

  • fast/css/getComputedStyle/computed-style-expected.txt: Updated.
  • fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Updated.
  • fast/text/international/text-combine-parser-test-expected.txt: Added.
  • fast/text/international/text-combine-parser-test.html: Added.
  • platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Updated.
  • svg/css/getComputedStyle-basic-expected.txt: Updated.

2010-11-03 takano takumi <takano1@asia.apple.com>

Reviewed by Dan Bernstein.

Add text-combine property to our property list. Reflect the setting to a RenderStyle object.
https://bugs.webkit.org/show_bug.cgi?id=48608

Test: fast/text/international/text-combine-parser-test.html

  • css/CSSComputedStyleDeclaration.cpp: Added text-combine property support. (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  • css/CSSParser.cpp: Added text-combine property support. (WebCore::CSSParser::parseValue):
  • css/CSSPrimitiveValueMappings.h: Added a primitive value mapper for text-combine (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): (WebCore::CSSPrimitiveValue::operator TextCombine):
  • css/CSSPropertyNames.in: Added "text-combine".
  • css/CSSStyleSelector.cpp: Added text-combine property support. (WebCore::CSSStyleSelector::applyProperty):
  • css/CSSValueKeywords.in: Added values for text-combine.
  • rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::diff): Added check of text-combine value.
  • rendering/style/RenderStyle.h: Added accessors for text-combine. (WebCore::InheritedFlags::textCombine): (WebCore::InheritedFlags::setTextCombine): (WebCore::InheritedFlags::initialTextCombine):
  • rendering/style/RenderStyleConstants.h:
  • rendering/style/StyleRareNonInheritedData.cpp: Added text-combine property support. (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): (WebCore::StyleRareNonInheritedData::operator==):
  • rendering/style/StyleRareNonInheritedData.h: Added text-combine entry for RenderStyle object here.
00:19 Changeset [71217] by dbates@webkit.org
  • 8 edits in trunk/WebKit

2010-11-03 Daniel Bates <dbates@rim.com>

For unnamed frames, window.name returns a generated name
https://bugs.webkit.org/show_bug.cgi?id=6751

Part 1 of 2.

Substitute FrameTree::uniqueName() for FrameTree::name() in the Chromium port.

  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::name):

2010-11-03 Daniel Bates <dbates@rim.com>

For unnamed frames, window.name returns a generated name
https://bugs.webkit.org/show_bug.cgi?id=6751

Part 1 of 2.

Substitute FrameTree::uniqueName() for FrameTree::name() in the EFL port.

  • ewk/ewk_frame.cpp: (ewk_frame_name_get):

2010-11-03 Daniel Bates <dbates@rim.com>

For unnamed frames, window.name returns a generated name
https://bugs.webkit.org/show_bug.cgi?id=6751

Part 1 of 2.

Substitute FrameTree::uniqueName() for FrameTree::name() in the GTK port.

  • webkit/webkitwebframe.cpp: (webkit_web_frame_get_name):

2010-11-03 Daniel Bates <dbates@rim.com>

For unnamed frames, window.name returns a generated name
https://bugs.webkit.org/show_bug.cgi?id=6751

Part 1 of 2.

Substitute FrameTree::uniqueName() for FrameTree::name() in the Qt port.

  • Api/qwebframe.cpp: (QWebFrame::frameName):
00:00 Changeset [71216] by dbates@webkit.org
  • 15 edits in trunk

2010-11-02 Daniel Bates <dbates@rim.com>

Reviewed by Adam Barth.

For unnamed frames, window.name returns a generated name
https://bugs.webkit.org/show_bug.cgi?id=6751

Part 1 of 2.

Towards fixing bug #6751, rename FrameTree::name() to FrameTree::uniqueName(),
which is more descriptive of its purpose. A follow up patch will re-add
FrameTree::name() which will return the DOM-specified name of the frame.

We will also take this opportunity to verify that we have found all the
call sites of FrameTree::name().

  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::mainResource): Use FrameTree::uniqueName().
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::loadURLIntoChildFrame): Ditto. (WebCore::FrameLoader::commitProvisionalLoad): Ditto.
  • loader/HistoryController.cpp: (WebCore::HistoryController::saveDocumentState): Ditto. (WebCore::HistoryController::restoreDocumentState): Ditto. (WebCore::HistoryController::createItem): Ditto. (WebCore::HistoryController::currentFramesMatchItem): Ditto.
  • loader/ProgressTracker.cpp: (WebCore::ProgressTracker::progressStarted): Ditto. (WebCore::ProgressTracker::progressCompleted): Ditto.
  • loader/archive/cf/LegacyWebArchive.cpp: (WebCore::LegacyWebArchive::create): Ditto.
  • page/DOMWindow.cpp: (WebCore::DOMWindow::name): Ditto.
  • page/FrameTree.cpp: (WebCore::FrameTree::setName): Ditto. (WebCore::FrameTree::clearName): Ditto. (WebCore::FrameTree::uniqueChildName): Ditto. (WebCore::FrameTree::child): Ditto. (WebCore::FrameTree::find): Ditto.
  • page/FrameTree.h: (WebCore::FrameTree::uniqueName): Renamed (formerly FrameTree::name()).

2010-11-02 Daniel Bates <dbates@rim.com>

Reviewed by Adam Barth.

For unnamed frames, window.name returns a generated name
https://bugs.webkit.org/show_bug.cgi?id=6751

Part 1 of 2.

Substitute FrameTree::uniqueName() for FrameTree::name() in WebKit2.

  • WebProcess/WebPage/WebFrame.cpp: (WebKit::WebFrame::name):

2010-11-02 Daniel Bates <dbates@rim.com>

Reviewed by Adam Barth.

For unnamed frames, window.name returns a generated name
https://bugs.webkit.org/show_bug.cgi?id=6751

Part 1 of 2.

Substitute FrameTree::uniqueName() for FrameTree::name() in the Mac port.

  • WebView/WebFrame.mm: (-[WebFrame name]):

2010-11-02 Daniel Bates <dbates@rim.com>

Reviewed by Adam Barth.

For unnamed frames, window.name returns a generated name
https://bugs.webkit.org/show_bug.cgi?id=6751

Part 1 of 2.

Substitute FrameTree::uniqueName() for FrameTree::name() in the Apple Windows port.

  • WebFrame.cpp: (WebFrame::name):

11/02/10:

23:59 Changeset [71215] by gyuyoung.kim@samsung.com
  • 7 edits in trunk

2010-11-02 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Unreviewed: Add myself to the list of Committers.

  • Scripts/webkitpy/common/config/committers.py:
22:29 Changeset [71214] by mrobinson@webkit.org
  • 2 edits
    14 adds in trunk/WebKit2

2010-11-02 Amruth Raj <amruthraj@motorola.com> and Ravi Kasibhatla <ravi.kasibhatla@motorola.com>

Reviewed by Martin Robinson.

Changes to enable building WebKit2 for Gtk port.
(https://bugs.webkit.org/show_bug.cgi?id=37369)

  • Platform/gtk: Added.
  • Platform/gtk/SharedMemoryGtk.cpp: Added. Stubbed implementation for GTK port. Yet to implement. (WebKit::SharedMemory::Handle::Handle): (WebKit::SharedMemory::Handle::~Handle): (WebKit::SharedMemory::Handle::encode): (WebKit::SharedMemory::Handle::decode): (WebKit::SharedMemory::create): (WebKit::SharedMemory::~SharedMemory): (WebKit::SharedMemory::createHandle): (WebKit::SharedMemory::systemPageSize):
  • Shared/gtk: Added.
  • Shared/gtk/BackingStoreGtk.cpp: Added. Stubbed implementation for GTK port. Yet to implement. (WebKit::BackingStore::createGraphicsContext): (WebKit::BackingStore::paint):
  • Shared/gtk/PlatformCertificateInfo.h: Added. Added. Stubbed implementation for GTK port. Yet to implement. (WebKit::PlatformCertificateInfo::PlatformCertificateInfo): (WebKit::PlatformCertificateInfo::encode): (WebKit::PlatformCertificateInfo::decode):
  • Shared/gtk/WebCoreArgumentCodersGtk.cpp: Added. Stubbed implementation for GTK port. Yet to implement. (CoreIPC::encodeResourceRequest): (CoreIPC::decodeResourceRequest):
  • UIProcess/Plugins/gtk: Added.
  • UIProcess/Plugins/gtk/PluginInfoStoreGtk.cpp: Added. Stubbed implementation for GTK port. Yet to implement. (WebKit::PluginInfoStore::pluginsDirectories): (WebKit::PluginInfoStore::pluginPathsInDirectory): (WebKit::PluginInfoStore::individualPluginPaths): (WebKit::PluginInfoStore::getPluginInfo): (WebKit::PluginInfoStore::shouldUsePlugin):
  • WebProcess/InjectedBundle/InjectedBundle.h:
  • WebProcess/InjectedBundle/gtk: Added.
  • WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp: Added. Stubbed implementation for GTK port. Yet to implement. (WebKit::InjectedBundle::load): (WebKit::InjectedBundle::activateMacFontAscentHack):
  • WebProcess/Plugins/Netscape/gtk: Added.
  • WebProcess/Plugins/Netscape/gtk/NetscapePluginGtk.cpp: Added. Stubbed implementation for GTK port. Yet to implement. (WebKit::NetscapePlugin::platformPostInitialize): (WebKit::NetscapePlugin::platformDestroy): (WebKit::NetscapePlugin::platformGeometryDidChange): (WebKit::NetscapePlugin::platformPaint): (WebKit::toNP): (WebKit::NetscapePlugin::platformHandleMouseEvent): (WebKit::NetscapePlugin::platformHandleWheelEvent): (WebKit::NetscapePlugin::platformSetFocus): (WebKit::NetscapePlugin::platformHandleMouseEnterEvent): (WebKit::NetscapePlugin::platformHandleMouseLeaveEvent): (WebKit::NetscapePlugin::platformHandleKeyboardEvent):
  • WebProcess/WebCoreSupport/gtk: Added.
  • WebProcess/WebCoreSupport/gtk/WebFrameNetworkingContext.h: Added. Added. Stubbed implementation for GTK port. Yet to implement. (WebFrameNetworkingContext::create): (WebFrameNetworkingContext::WebFrameNetworkingContext):
21:53 WebKitGtkLayoutTests edited by mrobinson@webkit.org
Fixed the color depth argument on Xvfb calls (diff)
21:41 Changeset [71213] by crogers@google.com
  • 10 edits in trunk

2010-11-02 Chris Rogers <crogers@google.com>

Reviewed by James Robinson.

Add AudioProcessingEvent files
https://bugs.webkit.org/show_bug.cgi?id=48884

No new tests since audio API is not yet implemented.

  • webaudio/AudioProcessingEvent.cpp: Added. (WebCore::AudioProcessingEvent::create): (WebCore::AudioProcessingEvent::AudioProcessingEvent): (WebCore::AudioProcessingEvent::~AudioProcessingEvent): (WebCore::AudioProcessingEvent::isAudioProcessingEvent):
  • webaudio/AudioProcessingEvent.h: Added. (WebCore::AudioProcessingEvent::inputBuffer): (WebCore::AudioProcessingEvent::outputBuffer):
  • webaudio/AudioProcessingEvent.idl: Added.

2010-11-02 Noam Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Some refactor for texmap to enable WebKit2: remove globals, and allow TextureMapper to exist without a GraphicsContext.
This will allow rendering the TextureMapperNode tree without an active QPainter, into the current GL context.
Most of the changes simply move the globas in TextureMapperGL into members of that class.

[Texmap] [Qt] Texture mapper initial implementation
https://bugs.webkit.org/show_bug.cgi?id=47070

  • Api/qwebframe.cpp: (QWebFramePrivate::renderFromTiledBackingStore): (QWebFramePrivate::renderCompositedLayers): (QWebFramePrivate::renderRelativeCoords):
  • Api/qwebframe_p.h:
21:36 Changeset [71212] by crogers@google.com
  • 1 edit
    3 adds in trunk/WebCore

2010-11-02 Chris Rogers <crogers@google.com>

Reviewed by James Robinson.

Add AudioProcessingEvent files
https://bugs.webkit.org/show_bug.cgi?id=48884

No new tests since audio API is not yet implemented.

  • webaudio/AudioProcessingEvent.cpp: Added. (WebCore::AudioProcessingEvent::create): (WebCore::AudioProcessingEvent::AudioProcessingEvent): (WebCore::AudioProcessingEvent::~AudioProcessingEvent): (WebCore::AudioProcessingEvent::isAudioProcessingEvent):
  • webaudio/AudioProcessingEvent.h: Added. (WebCore::AudioProcessingEvent::inputBuffer): (WebCore::AudioProcessingEvent::outputBuffer):
  • webaudio/AudioProcessingEvent.idl: Added.
21:23 Changeset [71211] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

2010-11-02 Benjamin Kalman <kalman@chromium.org>

Reviewed by Ojan Vafai.

canvas/philip tests use BUG instead of BUGWK in chromium test_expectations.txt.
https://bugs.webkit.org/show_bug.cgi?id=48879

  • platform/chromium/test_expectations.txt: Update canvas/philip tests to use BUGWK instead of BUG.
21:16 Changeset [71210] by commit-queue@webkit.org
  • 11 edits
    2 adds in trunk

2010-11-02 Al Patrick <apatrick@chromium.org>

Reviewed by Kenneth Russell.

Added PluginLayerChromium, which composites plugin instances that have an associated OpenGL backing texture.

https://bugs.webkit.org/show_bug.cgi?id=48032

  • WebCore.gypi:
  • loader/SubframeLoader.cpp (WebCore::SubframeLoader::loadPlugin):
  • platform/graphics/chromium/LayerChromium.cpp: (WebCore::LayerChromium::setNeedsDisplay):
  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::initializeSharedObjects): (WebCore::LayerRendererChromium::cleanupSharedObjects):
  • platform/graphics/chromium/LayerRendererChromium.h: (WebCore::LayerRendererChromium::pluginLayerSharedValues):
  • platform/graphics/chromium/PluginLayerChromium.cpp: Added. (WebCore::PluginLayerChromium::SharedValues::SharedValues): (WebCore::PluginLayerChromium::SharedValues::~SharedValues): (WebCore::PluginLayerChromium::create): (WebCore::PluginLayerChromium::PluginLayerChromium): (WebCore::PluginLayerChromium::updateContents): (WebCore::PluginLayerChromium::draw):
  • platform/graphics/chromium/PluginLayerChromium.h: Added. (WebCore::PluginLayerChromium::drawsContent): (WebCore::PluginLayerChromium::setTextureId): (WebCore::PluginLayerChromium::SharedValues::shaderProgram): (WebCore::PluginLayerChromium::SharedValues::shaderSamplerLocation): (WebCore::PluginLayerChromium::SharedValues::shaderMatrixLocation): (WebCore::PluginLayerChromium::SharedValues::shaderAlphaLocation): (WebCore::PluginLayerChromium::SharedValues::initialized):

2010-11-02 Al Patrick <apatrick@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Plugin instances can propagate the ID of the OpenGL texture they render to.

https://bugs.webkit.org/show_bug.cgi?id=48032

  • public/WebPlugin.h: (WebKit::WebPlugin::getBackingTextureId):
  • public/WebPluginContainer.h: (WebKit::WebPluginContainer::commitBackingTexture):
  • src/WebPluginContainerImpl.cpp: (WebKit::WebPluginContainerImpl::commitBackingTexture): (WebKit::WebPluginContainerImpl::platformLayer): (WebKit::WebPluginContainerImpl::WebPluginContainerImpl):
  • src/WebPluginContainerImpl.h:
20:56 Changeset [71209] by commit-queue@webkit.org
  • 4 edits in trunk

2010-11-02 James Simonsen <simonjam@chromium.org>

Reviewed by Adam Barth.

mathml in html sometimes incorrectly parsed
https://bugs.webkit.org/show_bug.cgi?id=48105

  • html5lib/resources/webkit01.dat: Test case for bug.

2010-11-02 James Simonsen <simonjam@chromium.org>

Reviewed by Adam Barth.

mathml in html sometimes incorrectly parsed
https://bugs.webkit.org/show_bug.cgi?id=48105

  • html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processEndTag): Fixed to match HTML5 spec.
20:46 Changeset [71208] by rolandsteiner@chromium.org
  • 2 edits in trunk/WebCore

2010-11-02 Chris Guillory <chris.guillory@google.com>

Reviewed by Dmitry Titov.

Null check obj in AXObjectCache::postPlatformNotification.
https://bugs.webkit.org/show_bug.cgi?id=48896

  • accessibility/chromium/AXObjectCacheChromium.cpp: (WebCore::AXObjectCache::postPlatformNotification):
20:31 Changeset [71207] by dimich@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

[Chromium] Unreviewed update of test expectations.
Add Chromium baseline for a test expectations added
in http://trac.webkit.org/changeset/71192.

  • platform/chromium-mac/fast/canvas/canvas-zoom-expected.checksum: Added.
19:59 Changeset [71206] by commit-queue@webkit.org
  • 7 edits in trunk

2010-11-02 Kavita Kanetkar <kkanetkar@chromium.org>

Reviewed by Dumitru Daniliuc.

[FileSystem] Support not creating directories when queried by inspector.
https://bugs.webkit.org/show_bug.cgi?id=48169

  • fileapi/LocalFileSystem.cpp: (WebCore::openFileSystem): (WebCore::LocalFileSystem::readFileSystem): (WebCore::LocalFileSystem::requestFileSystem):
  • fileapi/LocalFileSystem.h:
  • platform/AsyncFileSystem.cpp: (WebCore::AsyncFileSystem::openFileSystem):
  • platform/AsyncFileSystem.h:

2010-11-02 Kavita Kanetkar <kkanetkar@chromium.org>

Reviewed by Dumitru Daniliuc.

[FileSystem] Support not creating directories when queried by inspector.
https://bugs.webkit.org/show_bug.cgi?id=48169

  • src/LocalFileSystemChromium.cpp: (WebCore::LocalFileSystem::readFileSystem): (WebCore::LocalFileSystem::requestFileSystem):
19:35 Changeset [71205] by crogers@google.com
  • 1 edit
    3 adds in trunk/WebCore

2010-11-02 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

Add AudioBufferSourceNode files
https://bugs.webkit.org/show_bug.cgi?id=48012

No new tests since audio API is not yet implemented.

  • webaudio/AudioBufferSourceNode.cpp: Added. (WebCore::AudioBufferSourceNode::create): (WebCore::AudioBufferSourceNode::AudioBufferSourceNode): (WebCore::AudioBufferSourceNode::~AudioBufferSourceNode): (WebCore::AudioBufferSourceNode::process): (WebCore::AudioBufferSourceNode::provideInput): (WebCore::AudioBufferSourceNode::readFromBuffer): (WebCore::AudioBufferSourceNode::readFromBufferWithGrainEnvelope): (WebCore::AudioBufferSourceNode::reset): (WebCore::AudioBufferSourceNode::setBuffer): (WebCore::AudioBufferSourceNode::numberOfChannels): (WebCore::AudioBufferSourceNode::noteOn): (WebCore::AudioBufferSourceNode::noteGrainOn): (WebCore::AudioBufferSourceNode::noteOff): (WebCore::AudioBufferSourceNode::totalPitchRate):
  • webaudio/AudioBufferSourceNode.h: Added. (WebCore::AudioBufferSourceNode::buffer): (WebCore::AudioBufferSourceNode::looping): (WebCore::AudioBufferSourceNode::setLooping): (WebCore::AudioBufferSourceNode::gain): (WebCore::AudioBufferSourceNode::playbackRate): (WebCore::AudioBufferSourceNode::setPannerNode):
  • webaudio/AudioBufferSourceNode.idl: Added.
19:23 Changeset [71204] by mrobinson@webkit.org
  • 17 edits
    2 moves in trunk

2010-11-02 Martin Robinson <mrobinson@igalia.com>

Reviewed by Adam Barth.

[Cairo] Remove PlatformRefPtrCairo
https://bugs.webkit.org/show_bug.cgi?id=48192

Replace PlatformRefPtrCairo with a RefPtr specialization for Cairo and
Fontconfig types. This is the first step toward removing PlatformRefPtr,
whose job is better handled by RefPtr.

  • CMakeListsEfl.txt: Update the sources list to include RefPtrCairo instead of PlatformRefPtrCairo.
  • GNUmakefile.am: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • platform/graphics/GraphicsContext.h: Replace PlatformRefPtrCairo with RefPtrCairo.
  • platform/graphics/cairo/CairoUtilities.cpp: Ditto. (WebCore::drawPatternToCairoContext): Ditto.
  • platform/graphics/cairo/FontCacheFreeType.cpp: Ditto. (WebCore::FontCache::getFontDataForCharacters): Ditto. (WebCore::FontCache::createFontPlatformData): Ditto.
  • platform/graphics/cairo/FontPlatformDataFreeType.cpp: Ditto. (WebCore::FontPlatformData::FontPlatformData): Ditto. (WebCore::FontPlatformData::initializeWithFontFace): Ditto.
  • platform/graphics/cairo/FontPlatformDataFreeType.h: Ditto.
  • platform/graphics/cairo/GraphicsContextCairo.cpp: Ditto.
  • platform/graphics/cairo/ImageCairo.cpp: Ditto.
  • platform/graphics/cairo/RefPtrCairo.cpp: Renamed from WebCore/platform/graphics/cairo/PlatformRefPtrCairo.cpp. (WTF::refIfNotNull): Added. (WTF::derefIfNotNull): Added.
  • platform/graphics/cairo/RefPtrCairo.h: Renamed from WebCore/platform/graphics/cairo/PlatformRefPtrCairo.h.
  • platform/gtk/CursorGtk.cpp: Replace PlatformRefPtrCairo with RefPtrCairo. (WebCore::createNamedCursor): Ditto.
  • platform/gtk/DragImageGtk.cpp: Ditto. (WebCore::scaleDragImage): Ditto. (WebCore::dissolveDragImageToFraction): Ditto.
  • plugins/gtk/PluginViewGtk.cpp: Ditto. (WebCore::PluginView::paint): Ditto.

2010-11-02 Martin Robinson <mrobinson@igalia.com>

Reviewed by Adam Barth.

[Cairo] Remove PlatformRefPtrCairo
https://bugs.webkit.org/show_bug.cgi?id=48192

Replace instances of PlatformRefPtr smart pointers that wrap Cairo
types with RefPtrs.

  • WebCoreSupport/DragClientGtk.cpp: Use RefPtr instead of PlatformRefPtr. (WebKit::dragIconWindowDrawEventCallback):
  • WebCoreSupport/DragClientGtk.h: Ditto.
19:18 Changeset [71203] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit2

2010-11-02 Jing Jin <jjin@apple.com>

Reviewed by Alexey Proskuryakov.

Key down calls are not being sent to the application.
https://bugs.webkit.org/show_bug.cgi?id=48867

  • UIProcess/API/mac/WKView.mm: (-[WKView keyDown:]): Call super when ignoring a key down.
19:05 Changeset [71202] by commit-queue@webkit.org
  • 2 edits
    5 deletes in branches/chromium/552

Revert 71176 - Merge 71170

BUG=59554

TBR=inferno@chromium.org

19:02 Changeset [71201] by dimich@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

[Chromium] Unreviewed update of test expectations.
Add Chromium baseline for test added http://trac.webkit.org/changeset/71177.

  • platform/chromium-mac/fast/repaint/selection-rl-expected.checksum: Added.
  • platform/chromium-mac/fast/repaint/selection-rl-expected.png: Added.
18:55 Changeset [71200] by crogers@google.com
  • 6 edits in trunk/WebCore

2010-11-02 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

Simple followup changes to files affected by AudioNodeInput thread safety
https://bugs.webkit.org/show_bug.cgi?id=48661

No new tests since audio API is not yet implemented.

  • webaudio/AudioBasicProcessorNode.cpp: (WebCore::AudioBasicProcessorNode::checkNumberOfChannelsForInput):
  • webaudio/AudioChannelSplitter.cpp: (WebCore::AudioChannelSplitter::process):
  • webaudio/AudioDestinationNode.cpp: (WebCore::AudioDestinationNode::initialize): (WebCore::AudioDestinationNode::uninitialize): (WebCore::AudioDestinationNode::provideInput):
  • webaudio/AudioGainNode.cpp: (WebCore::AudioGainNode::checkNumberOfChannelsForInput):
  • webaudio/AudioPannerNode.cpp: (WebCore::AudioPannerNode::notifyAudioSourcesConnectedToNode):
18:40 Changeset [71199] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

2010-11-02 Adrienne Walker <enne@google.com>

Reviewed by Kenneth Russell.

Fix typo in webgl-test-util.js.
https://bugs.webkit.org/show_bug.cgi?id=48861

  • fast/canvas/webgl/resources/webgl-test-utils.js: (WebGLTestUtils):
18:20 Changeset [71198] by commit-queue@webkit.org
  • 9 edits in trunk

2010-11-02 Chris Guillory <chris.guillory@google.com>

Reviewed by Chris Fleizach.

Chromium: Propagate a document value changed notification on scroll.
https://bugs.webkit.org/show_bug.cgi?id=48817

  • platform/chromium/accessibility/post-notification-ValueChanged-expected.txt:
  • platform/chromium/accessibility/post-notification-ValueChanged.html:

2010-11-02 Chris Guillory <chris.guillory@google.com>

Reviewed by Chris Fleizach.

Chromium: Propagate a document value changed notification on scroll.
https://bugs.webkit.org/show_bug.cgi?id=48817

  • accessibility/AccessibilityObject.h: (WebCore::AccessibilityObject::isAccessibilityScrollbar):
  • accessibility/AccessibilityScrollbar.h: (WebCore::AccessibilityScrollbar::scrollbar): (WebCore::AccessibilityScrollbar::isAccessibilityScrollbar):
  • accessibility/chromium/AXObjectCacheChromium.cpp: (WebCore::AXObjectCache::postPlatformNotification):

2010-11-02 Chris Guillory <chris.guillory@google.com>

Reviewed by Chris Fleizach.

Chromium: Propagate a document value changed notification on scroll.
https://bugs.webkit.org/show_bug.cgi?id=48817

  • src/WebAccessibilityObject.cpp: (WebKit::WebAccessibilityObject::boundingBoxRect):
18:18 Changeset [71197] by dimich@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed update of test expectations.

  • platform/chromium/test_expectations.txt:
18:07 Changeset [71196] by michaeln@google.com
  • 4 edits in trunk/LayoutTests

2010-11-02 Michael Nordman <michaeln@google.com>

Reviewed by Alexey Proskuryakov.

[Chromium] Some work on making appcache layout tests less flaky.
https://bugs.webkit.org/show_bug.cgi?id=48002
1) Make network-simulator.php less slow.
In addition to redirecting back to the requested url, the response contains
multiple content-length headers. Chrome's network stacks considers that an
error condition too and picks up on it faster (one round trip instead of multiple).
This avoids timeouts due to using PHP via slow CGI on windows.
2) Removed canLoad() from appcache/fallback.html layout test, the load()
result is sufficient for determining if it could be loaded. So fewer requests are
made to conduct the test, cutting out more time.
3) Removed some unneeded code from offline-access-frame.html. Appcache events are guaranteed
to be deferred until after 'onload' has happened. This test was coded prior to that
guarantee being satisfied.

  • http/tests/appcache/fallback.html:
  • http/tests/resources/network-simulator.php:
  • http/tests/resources/offline-access-frame.html:
18:00 Changeset [71195] by crogers@google.com
  • 1 edit
    3 adds in trunk/WebCore

2010-11-02 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

Add ConvolverNode files
https://bugs.webkit.org/show_bug.cgi?id=47941

No new tests since audio API is not yet implemented.

  • webaudio/ConvolverNode.cpp: Added. (WebCore::ConvolverNode::ConvolverNode): (WebCore::ConvolverNode::~ConvolverNode): (WebCore::ConvolverNode::process): (WebCore::ConvolverNode::reset): (WebCore::ConvolverNode::initialize): (WebCore::ConvolverNode::uninitialize): (WebCore::ConvolverNode::setBuffer): (WebCore::ConvolverNode::buffer):
  • webaudio/ConvolverNode.h: Added. (WebCore::ConvolverNode::create):
  • webaudio/ConvolverNode.idl: Added.
17:59 Changeset [71194] by simon.fraser@apple.com
  • 3 edits
    5 adds in trunk/WebCore

2010-11-02 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

Overlapped nested iframes show smearing when scrolled
https://bugs.webkit.org/show_bug.cgi?id=48873

A FrameView goes into slow scrolling mode (not blitting) when told that it is
overlapped. However, a nested iframe could still try to use fast scrolling
when its parent is overlapped, which could result in bad rendering.

Fixed by making useSlowRepaints() and useSlowRepaintsIfNotOverlapped()
walk up their parent chain, asking if their parents also use slow
repaints.

All the places that call setCanBlitOnScroll() now call
updateCanBlitOnScrollRecursively() to ensure that the canBlitOnScroll
flag is updated correctly on subframes.

Repaint tests do not work on nested iframes, so added manual test.

  • manual-tests/frames/nested-iframe-blit-on-scroll.html: Added.
  • manual-tests/frames/resources/blit-on-scroll-subframe.html: Added.
  • manual-tests/frames/resources/blit-on-scroll-subsubframe.html: Added.
  • page/FrameView.cpp: (WebCore::FrameView::layout): (WebCore::FrameView::useSlowRepaints): (WebCore::FrameView::useSlowRepaintsIfNotOverlapped): (WebCore::FrameView::updateCanBlitOnScrollRecursively): (WebCore::FrameView::setUseSlowRepaints): (WebCore::FrameView::addSlowRepaintObject): (WebCore::FrameView::removeSlowRepaintObject): (WebCore::FrameView::addFixedObject): (WebCore::FrameView::removeFixedObject): (WebCore::FrameView::setIsOverlapped): (WebCore::FrameView::setContentIsOpaque):
  • page/FrameView.h:
17:44 Changeset [71193] by crogers@google.com
  • 1 edit
    2 adds in trunk/WebCore

2010-11-02 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

Add RealtimeAnalyser files
https://bugs.webkit.org/show_bug.cgi?id=48810

No new tests since audio API is not yet implemented.

  • webaudio/RealtimeAnalyser.cpp: Added. (WebCore::RealtimeAnalyser::RealtimeAnalyser): (WebCore::RealtimeAnalyser::~RealtimeAnalyser): (WebCore::RealtimeAnalyser::reset): (WebCore::RealtimeAnalyser::setFftSize): (WebCore::RealtimeAnalyser::writeInput): (WebCore::RealtimeAnalyser::doFFTAnalysis): (WebCore::RealtimeAnalyser::getFloatFrequencyData): (WebCore::RealtimeAnalyser::getByteFrequencyData): (WebCore::RealtimeAnalyser::getByteTimeDomainData):
  • webaudio/RealtimeAnalyser.h: Added. (WebCore::RealtimeAnalyser::fftSize): (WebCore::RealtimeAnalyser::frequencyBinCount): (WebCore::RealtimeAnalyser::setMinDecibels): (WebCore::RealtimeAnalyser::minDecibels): (WebCore::RealtimeAnalyser::setMaxDecibels): (WebCore::RealtimeAnalyser::maxDecibels): (WebCore::RealtimeAnalyser::setSmoothingTimeConstant): (WebCore::RealtimeAnalyser::smoothingTimeConstant): (WebCore::RealtimeAnalyser::magnitudeBuffer):
17:30 Changeset [71192] by mihaip@chromium.org
  • 225 edits
    224 copies
    6 adds in trunk/LayoutTests

2010-11-02 Mihai Parparita <mihaip@chromium.org>

Update the pixel expectations for fast/canvas, fast/css-generated-content, fast/inline-block, fast/inline, and fast/overflow for the Mac port.

For the tests that currently fail on Snow Leopard with --pixel-tests
--tolerance 0, this moves the current pixel results to mac-leopard and
adds new Snow Leopard-specific results to platform/mac.

List of files omitted due to length but composed entirely of moves from
platform/mac to platform/mac-leopard and newly added files in
platform/mac.

17:25 Changeset [71191] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-11-02 Ilya Sherman <isherman@chromium.org>

Reviewed by Kent Tamura.

Avoid overlapping label text in autofill popup with icon.
Updates the menu width computation to take the icon width into account.
https://bugs.webkit.org/show_bug.cgi?id=48497

  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupListBox::paintRow): (WebCore::PopupListBox::layout):
17:23 Changeset [71190] by zmo@google.com
  • 8 edits in trunk

2010-10-28 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Perform framebuffer attachment checking upon draw call rather than attachment
https://bugs.webkit.org/show_bug.cgi?id=46318

  • html/canvas/WebGLFramebuffer.cpp: (WebCore::getInternalFormat): Helper function to get an attachment's internal format. (WebCore::isUninitialized): Helper function to decide if an attachment is initialized or not. (WebCore::setInitialized): Helper funtion to set an attachment as being initialized. (WebCore::WebGLFramebuffer::setAttachment): No longer perform buffer initialization at this point. (WebCore::WebGLFramebuffer::removeAttachment): Ditto. (WebCore::WebGLFramebuffer::getColorBufferFormat): Make it const. (WebCore::WebGLFramebuffer::isIncomplete): Attachments conflict check. (WebCore::WebGLFramebuffer::onAccess): Check atatchment conflicts and buffer initialization if necessary. (WebCore::WebGLFramebuffer::initializeRenderbuffers): Return a boolean whether the framebuffer is complete or not.
  • html/canvas/WebGLFramebuffer.h: Add new function declaration and remove some outdated functions. (WebCore::WebGLFramebuffer::isColorAttached): (WebCore::WebGLFramebuffer::isDepthAttached): Make this private. (WebCore::WebGLFramebuffer::isStencilAttached): Ditto. (WebCore::WebGLFramebuffer::isDepthStencilAttached): Ditto.
  • html/canvas/WebGLRenderbuffer.h: (WebCore::WebGLRenderbuffer::setInternalFormat): Also set the renderbuffer as uninitialized.
  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::bindFramebuffer): No longer perform framebuffer initialization at this point. (WebCore::WebGLRenderingContext::checkFramebufferStatus): Check WebGL specific attachment conflicts. (WebCore::WebGLRenderingContext::clear): Call WebGLFramebuffer::onAccess. (WebCore::WebGLRenderingContext::copyTexImage2D): Ditto. (WebCore::WebGLRenderingContext::copyTexSubImage2D): Ditto. (WebCore::WebGLRenderingContext::drawArrays): Ditto. (WebCore::WebGLRenderingContext::drawElements): Ditto. (WebCore::WebGLRenderingContext::framebufferRenderbuffer): No longer perform framebuffer initialization at this point. (WebCore::WebGLRenderingContext::readPixels): Call WebGLFramebuffer::onAccess. (WebCore::WebGLRenderingContext::renderbufferStorage): No longer perform framebuffer initialization at this point. (WebCore::WebGLRenderingContext::texImage2DBase): Ditto.

2010-10-28 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Perform framebuffer attachment checking upon draw call rather than attachment
https://bugs.webkit.org/show_bug.cgi?id=46318

  • fast/canvas/webgl/framebuffer-object-attachment-expected.txt:
  • fast/canvas/webgl/framebuffer-object-attachment.html:
17:06 Changeset [71189] by mihaip@chromium.org
  • 231 edits
    230 copies
    2 adds in trunk/LayoutTests

2010-11-02 Mihai Parparita <mihaip@chromium.org>

Update the pixel expectations for fast/flexbox, fast/frames, fast/invalid, fast/layers, and fast/lists for the Mac port.

For the tests that currently fail on Snow Leopard with --pixel-tests
--tolerance 0, this moves the current pixel results to mac-leopard and
adds new Snow Leopard-specific results to platform/mac.

List of files omitted due to length but composed entirely of moves from
platform/mac to platform/mac-leopard and newly added files in
platform/mac.

16:50 Changeset [71188] by andersca@apple.com
  • 4 edits in trunk/WebKit2

Add Null and Int32 to NPVariantData
https://bugs.webkit.org/show_bug.cgi?id=48887

Reviewed by John Sullivan.

  • Shared/Plugins/NPRemoteObjectMap.cpp:

(WebKit::NPRemoteObjectMap::npVariantToNPVariantData):
(WebKit::NPRemoteObjectMap::npVariantDataToNPVariant):

  • Shared/Plugins/NPVariantData.cpp:

(WebKit::NPVariantData::NPVariantData):
(WebKit::NPVariantData::makeNull):
(WebKit::NPVariantData::makeInt32):
(WebKit::NPVariantData::encode):
(WebKit::NPVariantData::decode):

  • Shared/Plugins/NPVariantData.h:

(WebKit::NPVariantData::int32Value):

16:40 Changeset [71187] by mihaip@chromium.org
  • 323 edits
    322 copies in trunk/LayoutTests

2010-11-02 Mihai Parparita <mihaip@chromium.org>

Update the pixel expectations for fast/forms for the Mac port.

For the tests that currently fail on Snow Leopard with --pixel-tests
--tolerance 0, this moves the current pixel results to mac-leopard and
adds new Snow Leopard-specific results to platform/mac.

List of files omitted due to length but composed entirely of moves from
platform/mac to platform/mac-leopard and newly added files in
platform/mac.

16:36 Changeset [71186] by jam@chromium.org
  • 4 edits in trunk/WebKit/chromium

2010-10-29 John Abd-El-Malek <jam@chromium.org>

Reviewed by Darin Fisher.

[chromium]: Allow plugins to use optimized scrolling
https://bugs.webkit.org/show_bug.cgi?id=48660

  • public/WebPluginContainer.h:
  • src/WebPluginContainerImpl.cpp: (WebKit::WebPluginContainerImpl::scrollRect):
  • src/WebPluginContainerImpl.h:
16:25 Changeset [71185] by zmo@google.com
  • 4 edits
    2 adds in trunk

2010-11-01 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

blendFunc should generate INVALID_OPERATION if constant color and constant alpha are together as source and destination factors
https://bugs.webkit.org/show_bug.cgi?id=48674

Test: fast/canvas/webgl/webgl-specific.html

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::blendFunc): (WebCore::WebGLRenderingContext::blendFuncSeparate):
  • html/canvas/WebGLRenderingContext.h: (WebCore::WebGLRenderingContext::validateBlendFuncFactors): Helper function to do the checking.

2010-11-01 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

blendFunc should generate INVALID_OPERATION if constant color and constant alpha are together as source and destination factors
https://bugs.webkit.org/show_bug.cgi?id=48674

  • fast/canvas/webgl/webgl-specific-expected.txt: Added.
  • fast/canvas/webgl/webgl-specific.html: Added.
16:20 Changeset [71184] by dimich@chromium.org
  • 1 edit
    5 adds in trunk/LayoutTests

[Chromium] Unreviewed update of test expectations.
Add Chromium baseline for a test added in http://trac.webkit.org/changeset/71177.

  • platform/chromium-linux/fast/repaint/selection-rl-expected.checksum: Added.
  • platform/chromium-linux/fast/repaint/selection-rl-expected.png: Added.
  • platform/chromium-win/fast/repaint/selection-rl-expected.checksum: Added.
  • platform/chromium-win/fast/repaint/selection-rl-expected.png: Added.
  • platform/chromium-win/fast/repaint/selection-rl-expected.txt: Added.
16:16 Changeset [71183] by andersca@apple.com
  • 9 edits in trunk

Add support for NP_HasMethod and NP_Invoke
https://bugs.webkit.org/show_bug.cgi?id=48882

Reviewed by Adam Roben.

WebKit2:

  • Platform/CoreIPC/HandleMessage.h:

(CoreIPC::callMemberFunction):
Add new overload.

  • Shared/Plugins/NPObjectMessageReceiver.cpp:

(WebKit::NPObjectMessageReceiver::hasMethod):
Call hasMethod and return the result.

(WebKit::NPObjectMessageReceiver::invoke):
Convert the arguments, call invoke and return the result.

(WebKit::NPObjectMessageReceiver::getProperty):
Release the converted variant.

  • Shared/Plugins/NPObjectMessageReceiver.messages.in:

Add HasMethod and Invoke messages.

  • Shared/Plugins/NPObjectProxy.cpp:

(WebKit::NPObjectProxy::hasMethod):
Send the HasMethod message.

(WebKit::NPObjectProxy::invoke):
Send the Invoke message.

(WebKit::NPObjectProxy::NP_HasMethod):
Call hasMethod.

(WebKit::NPObjectProxy::NP_Invoke):
Call invoke.

LayoutTests:

Remove now passing tests.

  • platform/mac-wk2/Skipped:
16:12 Changeset [71182] by simon.fraser@apple.com
  • 3 edits
    6 adds in trunk

2010-11-02 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

Iframes nested inside a compositing layer don't repaint correctly
https://bugs.webkit.org/show_bug.cgi?id=48880
<rdar://problem/8194698>

The isEnclosedInCompositingLayer() is used to modify the behavior of
-[WebClipView visibleRect:] in WebKit, so that scrolling-related repaints
are correct in composited iframes. Previously it only asked whether the
frame's renderer was in a compositing layer, but we actually need to
consult all ancestors.

Test: compositing/iframes/nested-iframe-scrolling.html

  • page/FrameView.cpp: (WebCore::FrameView::isEnclosedInCompositingLayer):
16:02 Changeset [71181] by dimich@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed update of test expectations.

  • platform/chromium/test_expectations.txt:
15:48 Changeset [71180] by andersca@apple.com
  • 2 edits in trunk/WebKitTools

Fix build.

  • TestWebKitAPI/PlatformUtilities.cpp:

(TestWebKitAPI::Util::createContextForInjectedBundleTest):

15:35 Changeset [71179] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit/chromium

2010-11-02 Marc-Antoine Ruel <maruel@chromium.org>

Reviewed by Dimitri Glazkov.

Disable incremental linking for webkit_unit_test and DumpRenderTRee on x86 Windows on chromium build.
https://bugs.webkit.org/show_bug.cgi?id=48836

It fails to link otherwise due to lack of virtual address space.

  • WebKit.gyp:
15:28 Changeset [71178] by andersca@apple.com
  • 8 edits in trunk

Implement NP_HasProperty for NPObjectProxy
https://bugs.webkit.org/show_bug.cgi?id=48876

Reviewed by Sam Weinig.

WebKit2:

  • Shared/Plugins/NPObjectMessageReceiver.cpp:

(WebKit::NPObjectMessageReceiver::hasProperty):
Call The hasProperty callback function.

  • Shared/Plugins/NPObjectMessageReceiver.messages.in:

Add HasProperty message.

  • Shared/Plugins/NPObjectProxy.cpp:

(WebKit::NPObjectProxy::hasProperty):
Send the HasProperty message.

(WebKit::NPObjectProxy::NP_HasProperty):
Call hasProperty.

LayoutTests:

Remove now passing test.

  • platform/mac-wk2/Skipped:
15:21 Changeset [71177] by hyatt@apple.com
  • 13 edits
    4 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=48672

Reviewed by Dan Bernstein.

Make vertical glyph offset hit testing work with inline boxes. This allows selection to paint
properly for vertical text (although gap-filling is still broken).

Refactored and cleaned up the writing mode flipping functions, and also did some cleanup to
better share code between hit testing and painting.

WebCore:

  • rendering/InlineBox.cpp:

(WebCore::InlineBox::locationIncludingFlipping):
(WebCore::InlineBox::flipForWritingMode):

  • rendering/InlineBox.h:
  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::nodeAtPoint):
(WebCore::InlineFlowBox::paint):
(WebCore::InlineFlowBox::paintBoxDecorations):
(WebCore::InlineFlowBox::paintMask):

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::selectionRect):
(WebCore::InlineTextBox::nodeAtPoint):
(WebCore::InlineTextBox::paint):
(WebCore::InlineTextBox::textPos):
(WebCore::InlineTextBox::offsetForPosition):
(WebCore::InlineTextBox::positionForOffset):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paintChildren):
(WebCore::RenderBlock::paintFloats):
(WebCore::RenderBlock::hitTestFloats):
(WebCore::RenderBlock::hitTestContents):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeRectForRepaint):
(WebCore::RenderBox::flipForWritingMode):
(WebCore::RenderBox::locationOffsetIncludingFlipping):

  • rendering/RenderBox.h:
  • rendering/RenderInline.cpp:

(WebCore::RenderInline::clippedOverflowRectForRepaint):

  • rendering/RenderLineBoxList.cpp:

(WebCore::RenderLineBoxList::rangeIntersectsRect):
(WebCore::RenderLineBoxList::anyLineIntersectsRect):
(WebCore::RenderLineBoxList::lineIntersectsDirtyRect):
(WebCore::RenderLineBoxList::paint):
(WebCore::RenderLineBoxList::hitTest):

  • rendering/RenderLineBoxList.h:
  • rendering/RenderText.cpp:

(WebCore::RenderText::positionForPoint):

LayoutTests:

  • fast/repaint/selection-rl.html: Added.
  • platform/mac/fast/repaint/selection-rl-expected.checksum: Added.
  • platform/mac/fast/repaint/selection-rl-expected.png: Added.
  • platform/mac/fast/repaint/selection-rl-expected.txt: Added.
15:15 Changeset [71176] by inferno@chromium.org
  • 2 edits
    5 copies in branches/chromium/552

Merge 71170

BUG=59554

15:06 Changeset [71175] by weinig@apple.com
  • 21 edits in trunk

Add a way to send startup messages on the context which can be posted when a process launches
<rdar://problem/8617928>
https://bugs.webkit.org/show_bug.cgi?id=48838

Reviewed by Anders Carlsson.

WebKit2:

Adds WKContextSetInitializationUserDataForInjectedBundle which sets an
APIObject on WebContext to be sent to the InjectedBundle's WKBundleInitialize
function each time a process starts up. This can help in cases where
the WebProcess dies, and will be helpful in the world where there are
multiple WebProcess's per context.

  • Scripts/webkit2/messages.py:
  • UIProcess/API/C/WKContext.cpp:

(WKContextSetInitializationUserDataForInjectedBundle):

  • UIProcess/API/C/WKContext.h:
  • UIProcess/WebContext.cpp:

(WebKit::WebContext::ensureWebProcess):

  • UIProcess/WebContext.h:

(WebKit::WebContext::setInjectedBundleInitializationUserData):
(WebKit::WebContext::injectedBundleInitializationUserData):

  • WebProcess/InjectedBundle/API/c/WKBundleInitialize.h:
  • WebProcess/InjectedBundle/InjectedBundle.h:
  • WebProcess/InjectedBundle/mac/InjectedBundleMac.cpp:

(WebKit::InjectedBundle::load):

  • WebProcess/InjectedBundle/qt/InjectedBundleQt.cpp:

(WebKit::InjectedBundle::load):

  • WebProcess/InjectedBundle/win/InjectedBundleWin.cpp:

(WebKit::InjectedBundle::load):

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeWebProcess):

  • WebProcess/WebProcess.h:
  • WebProcess/WebProcess.messages.in:

WebKitTools:

  • MiniBrowser/mac/WebBundle/WebBundleMain.m:

(WKBundleInitialize):

  • TestWebKitAPI/InjectedBundleController.cpp:

(TestWebKitAPI::InjectedBundleController::initialize):
(TestWebKitAPI::InjectedBundleController::didReceiveMessage):

  • TestWebKitAPI/InjectedBundleController.h:
  • TestWebKitAPI/InjectedBundleMain.cpp:

(WKBundleInitialize):

  • TestWebKitAPI/PlatformUtilities.cpp:

(TestWebKitAPI::Util::createContextForInjectedBundleTest):

  • WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:

(WKBundleInitialize):
Update implementations of WKBundleInitialize to take an initial userData
argument. Change TestWebKitAPI to use the new initial userData to initialize
each test's bundle.

15:01 Changeset [71174] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2010-11-02 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

JPEG decoders should understand color profiles
https://bugs.webkit.org/show_bug.cgi?id=48819

This patch is currently a no-op because no one defines USE(ICCJPEG).
We'll enable this for Chromium Mac once we have ICCJPEG landed in
Chromium's third_party directory.

  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp: (WebCore::readColorProfile): (WebCore::JPEGImageReader::JPEGImageReader): (WebCore::JPEGImageReader::decode): (WebCore::JPEGImageDecoder::outputScanlines):
  • platform/image-decoders/jpeg/JPEGImageDecoder.h: (WebCore::JPEGImageDecoder::setColorProfile):
14:54 Changeset [71173] by andersca@apple.com
  • 5 edits in trunk/WebKit2

Implement PluginProxy::pluginScriptableNPObject
https://bugs.webkit.org/show_bug.cgi?id=48874

Reviewed by Sam Weinig.

  • PluginProcess/PluginControllerProxy.cpp:

(WebKit::PluginControllerProxy::getPluginScriptableNPObject):
Ask the plug-in for its scriptable NPObject, register it with the map and return its object ID.

  • PluginProcess/PluginControllerProxy.messages.in:

Add GetPluginScriptableNPObject message.

  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::pluginScriptableNPObject):
Send the GetPluginScriptableNPObject message.

14:35 Changeset [71172] by paroga@webkit.org
  • 2 edits in trunk/WebKit/wince

2010-11-02 Patrick Gansterer <paroga@webkit.org>

Unreviewed, build fix after r71041.

  • WebCoreSupport/ChromeClientWinCE.h: (WebKit::ChromeClientWinCE::showContextMenu):
14:31 WebKit Team edited by leviw@google.com
Updating my company to Google. (diff)
14:26 Changeset [71171] by andersca@apple.com
  • 4 edits in trunk/WebKit2

Add strings to NPVariantData
https://bugs.webkit.org/show_bug.cgi?id=48871

Reviewed by Dan Bernstein.

  • Shared/Plugins/NPRemoteObjectMap.cpp:

(WebKit::NPRemoteObjectMap::npVariantToNPVariantData):
(WebKit::NPRemoteObjectMap::npVariantDataToNPVariant):

  • Shared/Plugins/NPVariantData.cpp:

(WebKit::NPVariantData::makeString):
(WebKit::NPVariantData::encode):
(WebKit::NPVariantData::decode):

  • Shared/Plugins/NPVariantData.h:

(WebKit::NPVariantData::stringValue):

14:23 Changeset [71170] by mihaip@chromium.org
  • 4 edits
    5 adds in trunk

2010-11-02 Mihai Parparita <mihaip@chromium.org>

Reviewed by Adam Barth.

[Chromium] Crash when encountering history.back() call during Page::goToItem execution
https://bugs.webkit.org/show_bug.cgi?id=48477

Add a reduced version of the page that was originally reported at
http://crbug.com/59554.

  • http/tests/history/back-during-onload-triggered-by-back-expected.txt: Added.
  • http/tests/history/back-during-onload-triggered-by-back.html: Added.
  • http/tests/history/resources/back-during-onload-container.html: Added.
  • http/tests/history/resources/back-during-onload-hung-page.php: Added.
  • http/tests/history/resources/back-during-onload-middle.html: Added.

2010-11-02 Mihai Parparita <mihaip@chromium.org>

Reviewed by Adam Barth.

[Chromium] Crash when encountering history.back() call during Page::goToItem execution
https://bugs.webkit.org/show_bug.cgi?id=48477

For the Chromium port, BackForwardList::itemAtIndex synthesizes a
HistoryItem and saves a pointer to it in m_pendingItem. During
Page::goToItem we call FrameLoader::stopAllLoaders, which can trigger
onload handlers (if a subframe was not considered committed by the frame
loader). If one of those handlers calls calls history.back() or another
operation that ends up in NavigationScheduler::scheduleHistoryNavigation,
we would call BackForwardList::itemAtIndex, which means that we would
lose the m_pendingItem RefPtr that pointed to the item being navigated
to, causing its ref count to go to 0*, and thus for the HistoryItem to
be deleted before we were done navigating to it.

This is fixed in two ways:

  • Add a protector RefPtr in Page::goToItem to make sure that the item is still around for when we pass it to HistoryController:goToItem.
  • Change NavigationScheduler::scheduleHistoryNavigation to not use BackForwardList::itemAtIndex and instead look at the forward/backListCount() (since it doesn't actually care about the returned HistoryItem).

Test: http/tests/history/back-during-onload-triggered-by-back.html

  • loader/NavigationScheduler.cpp: (WebCore::NavigationScheduler::scheduleHistoryNavigation):
  • page/Page.cpp: (WebCore::Page::goToItem):
14:18 Changeset [71169] by andersca@apple.com
  • 7 edits in trunk/WebKit2

Add convenience functions for allocating NPAPI memory
https://bugs.webkit.org/show_bug.cgi?id=48870

Reviewed by Dan Bernstein.

Add npnMemAlloc, npnMemFree and createNPString functions and
npnMemNew, npnMemNewArray function templates.

  • WebProcess/Plugins/Netscape/JSNPObject.cpp:

(WebKit::JSNPObject::getOwnPropertyNames):
Use npnMemFree.

  • WebProcess/Plugins/Netscape/NPJSObject.cpp:

(WebKit::NPJSObject::enumerate):
Use npnMemNewArray.

  • WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:

(WebKit::NPRuntimeObjectMap::convertJSValueToNPVariant):
Use createNPString.

  • WebProcess/Plugins/Netscape/NPRuntimeUtilities.cpp:

(WebKit::npnMemAlloc):
Call malloc.

(WebKit::npnMemFree):
Call free.

(WebKit::createNPString):
Allocate the characters for a new NPString.

(WebKit::createNPObject):
Call npnMemNew.

(WebKit::deallocateNPObject):
Call npnMemFree.

(WebKit::releaseNPVariantValue):
Call npnMemFree.

  • WebProcess/Plugins/Netscape/NPRuntimeUtilities.h:

(WebKit::npnMemNew):
(WebKit::npnMemNewArray):
Add new functions.

  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:

(WebKit::NPN_MemAlloc):
Call npnMemAlloc.

(WebKit::NPN_MemFree):
Call npnMemFree.

(WebKit::NPN_UTF8FromIdentifier):
Call npnMemNewArray.

(WebKit::copyCString):
Call npnMemNewArray. Correctly initialize the "len" out parameter.

14:14 Changeset [71168] by jberlin@webkit.org
  • 2 edits in trunk/WebKit2

Windows build fix. Unreviewed.

  • win/WebKit2Generated.make:

Add WKInspector.h so that it is copied over to the WebKitBuild directory.

14:13 Changeset [71167] by dimich@chromium.org
  • 1 edit
    1 move
    1 add in trunk/LayoutTests

[Chromium] Unreviewed update of test expectations.
Move the expected file higher up so it's used for all chromium flavors.

  • platform/chromium/security/block-test-no-port-expected.txt: Renamed from LayoutTests/platform/chromium-mac/security/block-test-no-port-expected.txt.
14:05 Changeset [71166] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

2010-11-02 Jenn Braithwaite <jennb@chromium.org>

Reviewed by Andreas Kling.

fast/frames/iframe-reparenting-new-page.html output is ordered wrong
https://bugs.webkit.org/show_bug.cgi?id=48807

  • fast/frames/iframe-reparenting-new-page-expected.txt:
  • fast/frames/script-tests/iframe-reparenting-new-page.js: (finish):
14:02 Changeset [71165] by beidson@apple.com
  • 2 edits in trunk/WebKit/win

<rdar://problem/8346191> and https://bugs.webkit.org/show_bug.cgi?id=48868
Implement IMutableWebRequest::setTimeoutInterval

Reviewed by Anders Carlsson.

  • WebMutableURLRequest.cpp:

(WebMutableURLRequest::setTimeoutInterval):

14:01 Changeset [71164] by zmo@google.com
  • 5 edits in trunk

2010-10-28 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Update getUniform for bvec[234] to return boolean[] rather than Uint8Array
https://bugs.webkit.org/show_bug.cgi?id=47568

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::getUniform):

2010-10-28 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Update getUniform for bvec[234] to return boolean[] rather than Uint8Array
https://bugs.webkit.org/show_bug.cgi?id=47568

  • fast/canvas/webgl/gl-object-get-calls-expected.txt:
  • fast/canvas/webgl/gl-object-get-calls.html:
13:53 Changeset [71163] by crogers@google.com
  • 1 edit
    3 adds in trunk/WebCore

2010-11-02 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

Add RealtimeAnalyserNode files
https://bugs.webkit.org/show_bug.cgi?id=48798

No new tests since audio API is not yet implemented.

  • webaudio/RealtimeAnalyserNode.cpp: Added. (WebCore::RealtimeAnalyserNode::RealtimeAnalyserNode): (WebCore::RealtimeAnalyserNode::~RealtimeAnalyserNode): (WebCore::RealtimeAnalyserNode::process): (WebCore::RealtimeAnalyserNode::pullInputs): (WebCore::RealtimeAnalyserNode::reset):
  • webaudio/RealtimeAnalyserNode.h: Added. (WebCore::RealtimeAnalyserNode::create): (WebCore::RealtimeAnalyserNode::fftSize): (WebCore::RealtimeAnalyserNode::setFftSize): (WebCore::RealtimeAnalyserNode::frequencyBinCount): (WebCore::RealtimeAnalyserNode::setMinDecibels): (WebCore::RealtimeAnalyserNode::minDecibels): (WebCore::RealtimeAnalyserNode::setMaxDecibels): (WebCore::RealtimeAnalyserNode::maxDecibels): (WebCore::RealtimeAnalyserNode::setSmoothingTimeConstant): (WebCore::RealtimeAnalyserNode::smoothingTimeConstant): (WebCore::RealtimeAnalyserNode::getFloatFrequencyData): (WebCore::RealtimeAnalyserNode::getByteFrequencyData): (WebCore::RealtimeAnalyserNode::getByteTimeDomainData):
  • webaudio/RealtimeAnalyserNode.idl: Added.
13:48 Changeset [71162] by commit-queue@webkit.org
  • 3 edits in trunk/WebCore

2010-11-02 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r71152.
http://trac.webkit.org/changeset/71152
https://bugs.webkit.org/show_bug.cgi?id=48866

Causes lots and lots of crashes (Requested by jamesr_ on
#webkit).

  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp: (WebCore::JPEGImageReader::JPEGImageReader): (WebCore::JPEGImageReader::decode): (WebCore::JPEGImageDecoder::outputScanlines):
  • platform/image-decoders/jpeg/JPEGImageDecoder.h:
13:47 Changeset [71161] by cmarrin@apple.com
  • 3 edits
    2 adds in trunk

2010-11-02 Chris Marrin <cmarrin@apple.com>

Reviewed by Simon Fraser.

When animations are paused, play-state can cause them to be unpaused.
https://bugs.webkit.org/show_bug.cgi?id=46525

I Changed updatePlayState() to only unpause when both play-state is
"running" and not suspended. Likewise I pause animation when either
play-state is "paused" or suspended.

Test: animations/play-state-suspend.html

  • page/animation/AnimationBase.cpp: (WebCore::AnimationBase::updatePlayState):
13:42 Changeset [71160] by commit-queue@webkit.org
  • 2 edits in trunk/WebKitTools

2010-11-02 Benjamin Kalman <kalman@google.com>

Reviewed by Ojan Vafai.

new-run-webkit-tests doesn't strip "LayoutTests/" from prefix, unlike old-run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=48794

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py: Strip the "LayoutTests/" prefix from test argument paths.
13:34 Changeset [71159] by ap@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Timothy Hatcher.

https://bugs.webkit.org/show_bug.cgi?id=48813
<rdar://problem/8602552> REGRESSION (r63622): DNS prefetching for <link> tags doesn't work
in non-HTTP documents

Cannot test DNS prefetching.

  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::process): We should be looking at preferences, not at whether this document has prefetching enabled.
13:30 Changeset [71158] by commit-queue@webkit.org
  • 3 edits in trunk/WebKit/chromium

2010-11-02 Ilya Sherman <isherman@chromium.org>

Reviewed by Kent Tamura.

Expose the sendChangeEvent parameter in WebInputElement::setValue() API,
primarily so that chromium form autofill can fire the onChange event.
https://bugs.webkit.org/show_bug.cgi?id=48177

  • public/WebInputElement.h:
  • src/WebInputElement.cpp: (WebKit::WebInputElement::setValue):
13:28 Changeset [71157] by dimich@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed update of test expectations.
Intentional error result to narrow down a regression caused by http://codereview.chromium.org/3976004

  • platform/chromium-mac/security/block-test-no-port-expected.txt:
13:24 Changeset [71156] by andersca@apple.com
  • 4 edits in trunk/WebKit2

Add some support for remote and local NPObjects to NPRemoteObjectMap
https://bugs.webkit.org/show_bug.cgi?id=48864

Reviewed by Adam Roben.

  • Shared/Plugins/NPRemoteObjectMap.cpp:

(WebKit::NPRemoteObjectMap::npVariantToNPVariantData):
If the NPVariant contains an NPObject that isn't an NPObjectProxy, register it
and return its ID.

(WebKit::NPRemoteObjectMap::npVariantDataToNPVariant):
If the NPVariantData contains a remote object, create an NPObjectProxy and return it.

  • Shared/Plugins/NPVariantData.cpp:

(WebKit::NPVariantData::NPVariantData):
Initialize m_localNPObjectIDValue and m_remoteNPObjectIDValue.

(WebKit::NPVariantData::makeLocalNPObjectID):
Create an NPVariantData that contains a local NPObject ID.

(WebKit::NPVariantData::encode):
Handle local and remote NPObject IDs.

(WebKit::NPVariantData::decode):
Decode local and remote NPObject IDs and "swap them" so an encoded remote NPObject ID is
decoded as a local NPObjectID (and vice versa).

  • Shared/Plugins/NPVariantData.h:

(WebKit::NPVariantData::localNPObjectIDValue):
(WebKit::NPVariantData::remoteNPObjectIDValue):

12:52 Changeset [71155] by aroben@apple.com
  • 3 edits
    1 add in trunk/JavaScriptCore

Windows build fix after r71127

MSVC isn't smart enough to figure out that the definition of the global
nullptr variable isn't needed, so we provide one for it.

Fixes <http://webkit.org/b/48862> Windows build is broken due to
undefined symbol nullptr

Reviewed by Anders Carlsson.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Export nullptr.

resort the files.

  • wtf/NullPtr.cpp: Added.
12:51 Changeset [71154] by pfeldman@chromium.org
  • 3 edits in trunk/WebCore

2010-11-02 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: Web Inspector: follow up to r71139. Fixed Mac monospace
height style.

  • inspector/front-end/PropertiesSection.js: (WebInspector.PropertiesSection):
  • inspector/front-end/inspector.css:
12:51 Changeset [71153] by abarth@webkit.org
  • 1 edit
    2 copies in branches/chromium/552

Merge 71147 - 2010-11-02 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

querySelectorAll('body>:last-child') does not work unless HTML file ends with 'new-line'.
https://bugs.webkit.org/show_bug.cgi?id=47166

We need to pop all the open elements when we end the document in the
AfterAfterBody state.

Test: fast/parser/pop-all-after-after-body.html

  • html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processEndOfFile):

2010-11-02 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

querySelectorAll('body>:last-child') does not work unless HTML file ends with 'new-line'.
https://bugs.webkit.org/show_bug.cgi?id=47166

Test that :last-child works when we end the document in the
AfterAfterBody state.

  • fast/parser/pop-all-after-after-body-expected.txt: Added.
  • fast/parser/pop-all-after-after-body.html: Added.

TBR=abarth@webkit.org

12:45 Changeset [71152] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2010-11-02 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

JPEG decoders should understand color profiles
https://bugs.webkit.org/show_bug.cgi?id=48819

This patch is currently a no-op because no one defines USE(ICCJPEG).
We'll enable this for Chromium Mac once we have ICCJPEG landed in
Chromium's third_party directory.

  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp: (WebCore::readColorProfile): (WebCore::JPEGImageReader::JPEGImageReader): (WebCore::JPEGImageReader::decode): (WebCore::JPEGImageDecoder::outputScanlines):
  • platform/image-decoders/jpeg/JPEGImageDecoder.h: (WebCore::JPEGImageDecoder::setColorProfile):
12:39 Changeset [71151] by jamesr@google.com
  • 153 edits
    152 copies
    3 adds in trunk/LayoutTests

2010-11-02 James Robinson <jamesr@chromium.org>

Update pixel baselines for Snow Leopard for tests in fast/text/*

12:37 Changeset [71150] by commit-queue@webkit.org
  • 3 edits in trunk/WebCore

2010-11-02 Ilya Sherman <isherman@chromium.org>

Reviewed by Simon Fraser.

Marks selectionStart() and selectionEnd() as const.
https://bugs.webkit.org/show_bug.cgi?id=48786

  • html/HTMLFormControlElement.cpp: (WebCore::HTMLTextFormControlElement::selectionStart): (WebCore::HTMLTextFormControlElement::selectionEnd):
  • html/HTMLFormControlElement.h:
12:29 Changeset [71149] by crogers@google.com
  • 13 edits in trunk/WebCore

2010-11-02 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

Fix license for audio files
https://bugs.webkit.org/show_bug.cgi?id=48859

  • webaudio/AudioChannelSplitter.cpp:
  • webaudio/AudioChannelSplitter.h:
  • webaudio/AudioDestinationNode.cpp:
  • webaudio/AudioDestinationNode.h:
  • webaudio/AudioGainNode.cpp:
  • webaudio/AudioGainNode.h:
  • webaudio/AudioPannerNode.cpp:
  • webaudio/AudioPannerNode.h:
  • webaudio/AudioPannerNode.idl:
12:20 Changeset [71148] by mrobinson@webkit.org
  • 7 edits in trunk

2010-11-02 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

Remove special handling of HashTableDeletedValue in PlatformRefPtr and manually manage memory that cannot be controlled by HashTraits
https://bugs.webkit.org/show_bug.cgi?id=48841

Remove special handling of HashTableDeletedValue in PlatformRefPtr.
This is better handled on a case-by-case basis, when HashTraits
cannot account for it.

  • wtf/PlatformRefPtr.h: (WTF::PlatformRefPtr::~PlatformRefPtr): (WTF::PlatformRefPtr::clear): (WTF::::operator):

2010-11-02 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

Remove special handling of HashTableDeletedValue in PlatformRefPtr and manually manage memory that cannot be controlled by HashTraits
https://bugs.webkit.org/show_bug.cgi?id=48841

Switch to manually managing the memory in FontPlatformDataFreeType. This
is necessary because smart pointers do not know how to deal with a pointer
value of -1 (HashTableDeletedValue) and HashTraits can only manage the type
contained in the HashMap.

No new tests as this should not change functionality.

  • platform/graphics/cairo/FontPlatformDataFreeType.cpp: (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::operator=): (WebCore::FontPlatformData::~FontPlatformData): (WebCore::FontPlatformData::operator==): (WebCore::FontPlatformData::initializeWithFontFace):
  • platform/graphics/cairo/FontPlatformDataFreeType.h: (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::scaledFont): (WebCore::FontPlatformData::hash): (WebCore::FontPlatformData::isHashTableDeletedValue): (WebCore::FontPlatformData::hashTableDeletedFontValue):
  • platform/graphics/cairo/GlyphPageTreeNodeCairo.cpp: (WebCore::GlyphPage::fill):
  • platform/graphics/cairo/SimpleFontDataCairo.cpp: (WebCore::SimpleFontData::platformInit): (WebCore::SimpleFontData::containsCharacters): (WebCore::SimpleFontData::platformWidthForGlyph):
12:15 Changeset [71147] by abarth@webkit.org
  • 3 edits
    2 adds in trunk

2010-11-02 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

querySelectorAll('body>:last-child') does not work unless HTML file ends with 'new-line'.
https://bugs.webkit.org/show_bug.cgi?id=47166

We need to pop all the open elements when we end the document in the
AfterAfterBody state.

Test: fast/parser/pop-all-after-after-body.html

  • html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processEndOfFile):

2010-11-02 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

querySelectorAll('body>:last-child') does not work unless HTML file ends with 'new-line'.
https://bugs.webkit.org/show_bug.cgi?id=47166

Test that :last-child works when we end the document in the
AfterAfterBody state.

  • fast/parser/pop-all-after-after-body-expected.txt: Added.
  • fast/parser/pop-all-after-after-body.html: Added.
12:08 Changeset [71146] by aroben@apple.com
  • 2 edits
    2 adds in trunk/WebKitTools

Skip webkitpy.layout_tests.run_webkit_tests_unittest.MainTest on Cygwin Python 2.5.x

It is known to hang on that version of Python. See
<http://webkit.org/b/48614>.

Reviewed by Adam Barth.

  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: Use

skip_if to skip MainTest on Cygwin Python 2.5.x.

  • Scripts/webkitpy/test/skip.py: Added.

(skip_if): If the passed-in condition is false, find all the test_*
methods of the given class and replace them with a function that just
logs that we're skipping these tests. This is loosely based on the
unittest.skip_if decorator added in Python 3.1.
(_skipped_method): Returns a function that just logs that the tests are
being skipped. This is used in place of the actual test_* functions.

  • Scripts/webkitpy/test/skip_unittest.py: Added.

(SkipTest.setUp): Create a logger for ourselves and give it a handler
that logs to a private stream.
(SkipTest.tearDown): Reset the logger.
(SkipTest.create_fixture_class): Returns a class that we use to test
skip_if. It has a single test_* method, test_foo, that just calls
through to a callback.
(SkipTest.foo_callback): Record that test_foo was called.
(SkipTest.test_skip_if_false): Pass skip_if a False condition and test
that test_foo does get called.
(SkipTest.test_skip_if_true): Pass skip_if a True condition and test
that test_foo does not get called and the appropriate message gets
logged.

12:07 Changeset [71145] by paroga@webkit.org
  • 2 edits in trunk/WebCore

2010-11-02 Patrick Gansterer <paroga@webkit.org>

Reviewed by Adam Roben.

Cleanup createGlobalImageFileDescriptor in ClipboardWin
https://bugs.webkit.org/show_bug.cgi?id=48189

  • platform/win/ClipboardWin.cpp: (WebCore::ClipboardWin::writeURL):
12:00 Changeset [71144] by pfeldman@chromium.org
  • 7 edits in trunk/WebCore

2010-11-02 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: display frame names in the resources panel.
https://bugs.webkit.org/show_bug.cgi?id=48839

  • inspector/Inspector.idl:
  • inspector/InspectorResourceAgent.cpp: (WebCore::frameId): (WebCore::buildObjectForDocumentLoader): (WebCore::buildObjectForFrame): (WebCore::buildObjectForFrameTree): (WebCore::InspectorResourceAgent::didCommitLoad): (WebCore::InspectorResourceAgent::frameDetachedFromParent): (WebCore::InspectorResourceAgent::frameForId): (WebCore::InspectorResourceAgent::resourceContent):
  • inspector/InspectorResourceAgent.h:
  • inspector/front-end/ResourceManager.js: (WebInspector.ResourceManager.prototype.didCommitLoadForFrame): (WebInspector.ResourceManager.prototype._processCachedResources): (WebInspector.ResourceManager.prototype._addFramesRecursively): (WebInspector.ResourceTreeModel.prototype.addOrUpdateFrame): (WebInspector.ResourceTreeModel.prototype.didCommitLoadForFrame):
  • inspector/front-end/StoragePanel.js: (WebInspector.StoragePanel.prototype.addOrUpdateFrame): (WebInspector.BaseStorageTreeElement.prototype.get titleText): (WebInspector.FrameTreeElement): (WebInspector.FrameTreeElement.prototype.onattach): (WebInspector.FrameTreeElement.prototype.get nameForSorting): (WebInspector.FrameTreeElement.prototype.setTitles): (WebInspector.FrameTreeElement.prototype.set hovered):
  • inspector/front-end/inspector.css: (li.selected .base-storage-tree-element-subtitle): (.base-storage-tree-element-subtitle):
11:50 Changeset [71143] by pfeldman@chromium.org
  • 3 edits
    2 deletes in trunk/WebCore

2010-11-02 Pavel Feldman <pfeldman@chromium.org>

Not reviewed. Follow up to r71139: removing unused images.
https://bugs.webkit.org/show_bug.cgi?id=48827

  • WebCore.gypi:
  • inspector/front-end/Images/grayConnectorPoint.png: Removed.
  • inspector/front-end/Images/whiteConnectorPoint.png: Removed.
  • inspector/front-end/WebKit.qrc:
11:48 Changeset [71142] by abarth@webkit.org
  • 3 edits in trunk/WebKitTools

2010-11-02 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

webkit-patch should tell check-webkit-style which files were changed so
check-webkit-style doesn't have to stat the whole working copy again
https://bugs.webkit.org/show_bug.cgi?id=48792

  • Scripts/webkitpy/tool/mocktool.py:
  • Scripts/webkitpy/tool/steps/checkstyle.py:
11:40 Changeset [71141] by andersca@apple.com
  • 2 edits in trunk/WebKit2

Attempt to fix a GCC release only warning.

  • Shared/Plugins/NPVariantData.cpp:

(WebKit::NPVariantData::NPVariantData):

11:39 Changeset [71140] by andersca@apple.com
  • 6 edits in trunk/WebKit2

Invalidate the NPRemoteObjectMap
https://bugs.webkit.org/show_bug.cgi?id=48856

Reviewed by John Sullivan.

  • Shared/Plugins/NPObjectMessageReceiver.cpp:

(WebKit::NPObjectMessageReceiver::~NPObjectMessageReceiver):
Remove FIXME. The NPRemoteObjectMap always outlives the NPObjectMessageReceiver.

  • Shared/Plugins/NPObjectProxy.cpp:

(WebKit::NPObjectProxy::~NPObjectProxy):
Call npObjectProxyDestroyed here.

(WebKit::NPObjectProxy::invalidate):
Null out m_npRemoteObjectMap.

  • Shared/Plugins/NPRemoteObjectMap.cpp:

(WebKit::NPRemoteObjectMap::~NPRemoteObjectMap):
Add assertions.

(WebKit::NPRemoteObjectMap::createNPObjectProxy):
Keep track of the NPObjectProxy by adding it to the m_npObjectProxies set.

(WebKit::NPRemoteObjectMap::npObjectProxyDestroyed):
Remove the NPObjectProxy from the m_npObjectProxies set.

(WebKit::NPRemoteObjectMap::invalidate):
Delete all NPObjectMessageReceivers. Iterate over all NPObjectProxy objects and invalidate them.

11:31 Changeset [71139] by pfeldman@chromium.org
  • 6 edits in trunk

2010-11-02 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: make properties and event listeners look consistent with the styles section.
https://bugs.webkit.org/show_bug.cgi?id=48827

  • inspector/front-end/EventListenersSidebarPane.js:
  • inspector/front-end/PropertiesSection.js: (WebInspector.PropertiesSection):
  • inspector/front-end/PropertiesSidebarPane.js: (WebInspector.PropertiesSidebarPane.prototype.update.callback): (WebInspector.PropertiesSidebarPane.prototype.update):
  • inspector/front-end/inspector.css: (.events-pane .section:not(:nth-of-type(1))): (.event-bar:first-child): (.section .header): (.section .header::before): (.section.expanded .header::before): (.section .header .title, .event-bar .header .title): (.section .header .subtitle, .event-bar .header .subtitle): (.section.expanded .properties, .event-bar.expanded .event-properties): (.properties-tree): (.event-bar): (.event-bars .event-bar .header): (.event-bars .event-bar .header .title): (.event-bars .event-bar .header::before):

2010-11-02 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: make properties and event listeners look consistent with the styles section.
https://bugs.webkit.org/show_bug.cgi?id=48827

  • src/js/devTools.css:
11:20 Changeset [71138] by mitz@apple.com
  • 3 edits in trunk/WebCore

Remove unused methods and member variables from AutoTableLayout.

Reviewed by Anders Carlsson.

  • rendering/AutoTableLayout.cpp:

(WebCore::AutoTableLayout::AutoTableLayout): Removed initialization of m_percentagesDirty
and m_totalPercent.
(WebCore::AutoTableLayout::fullRecalc): Removed setting of m_percentagesDirty.
(WebCore::AutoTableLayout::calcPercentages): Removed.

  • rendering/AutoTableLayout.h: Removed totalPercent(), m_percentagesDirty, and m_totalPercent.
11:15 Changeset [71137] by commit-queue@webkit.org
  • 2 edits in trunk/WebKitTools

2010-11-02 Robert Kroeger <rjkroege@chromium.org>

Reviewed by James Robinson.

[Chromium/DRT] Make EventSendingController honour leapForward for touch events.
https://bugs.webkit.org/show_bug.cgi?id=48777

  • DumpRenderTree/chromium/EventSender.cpp: (EventSender::sendCurrentTouchEvent):
11:12 Changeset [71136] by pfeldman@chromium.org
  • 3 edits in trunk/WebCore

2010-11-02 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: clear / hide timing information for cached resources.
https://bugs.webkit.org/show_bug.cgi?id=48848

  • inspector/front-end/Resource.js: (WebInspector.Resource.prototype.set cached): (WebInspector.Resource.prototype.get timing): (WebInspector.Resource.prototype.set timing):
  • inspector/front-end/ResourceManager.js: (WebInspector.ResourceManager.prototype.markResourceAsCached):
11:11 Changeset [71135] by mthole@apple.com
  • 2 edits in trunk/WebKit2

WebProcessManager informed about crashes too late (pages may have already tried to load a new URL)
https://bugs.webkit.org/show_bug.cgi?id=48853

Reviewed by Anders Carlsson.

This also fixes: <rdar://problem/8610451> Webkit2: Crash in WebKit!WebKit::WebProcessProxy::sendMessage opening google.com page

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::~WebProcessProxy):
Removed invalid assertion that is hit when the WebProcess dies unexpectedly.
(WebKit::WebProcessProxy::didClose):
Reordered so that the individual pages are informed that the processDidCrash() after the shared
WebProcessManager has been. This allows the pages to properly trigger a new process to be launched.

11:10 Changeset [71134] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2010-11-02 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: improve network's 'preview close' usability.
https://bugs.webkit.org/show_bug.cgi?id=48846

  • inspector/front-end/networkPanel.css: (#network-close-button:hover): (#network-close-button:active):
11:08 Changeset [71133] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2010-11-02 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Image heights are displayed as 0.
https://bugs.webkit.org/show_bug.cgi?id=40817

  • inspector/front-end/ImageView.js: (WebInspector.ImageView.prototype.contentTabSelected): (WebInspector.ImageView.prototype.contentTabSelected.onImageLoad):
11:01 Changeset [71132] by andersca@apple.com
  • 4 edits in trunk/WebKit2

Handle boolean values in NPVariant and NPVariantData
https://bugs.webkit.org/show_bug.cgi?id=48852

Reviewed by John Sullivan.

  • Shared/Plugins/NPRemoteObjectMap.cpp:

(WebKit::NPRemoteObjectMap::npVariantToNPVariantData):
(WebKit::NPRemoteObjectMap::npVariantDataToNPVariant):

  • Shared/Plugins/NPVariantData.cpp:

(WebKit::NPVariantData::makeBool):
(WebKit::NPVariantData::encode):
(WebKit::NPVariantData::decode):

  • Shared/Plugins/NPVariantData.h:

(WebKit::NPVariantData::boolValue):

10:59 Changeset [71131] by adele@apple.com
  • 3 edits
    2 adds in trunk

WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=48814
<rdar://problem/8546143> Attempting to redo typing in apple.com/startpage search field causes infinite recursion in TextControlInnerTextElement::defaultEventHandler

Reviewed by Kent Tamura.

Test: editing/undo/redo-after-detach.html

  • rendering/TextControlInnerElements.cpp: (WebCore::TextControlInnerTextElement::defaultEventHandler):

A TextControlInnerTextElement will almost always have a shadowAncestorNode, the HTMLInputElement. In this case,
after the renderer was destroyed, this shadow node was kept alive by the EditCommand, even though its not hooked up
anymore to the shadow DOM. EditCommands can sometimes operate on stale selections and are expected to fail silently.
So here we prevent the infinite loop during event dispatch, and the rest of the redo operation will fail silently.

LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=48814
<rdar://problem/8546143> Attempting to redo typing in apple.com/startpage search field causes infinite recursion in TextControlInnerTextElement::defaultEventHandler

Reviewed by Kent Tamura.

  • editing/undo/redo-after-detach-expected.txt: Added.
  • editing/undo/redo-after-detach.html: Added.
10:55 Changeset [71130] by enrica@apple.com
  • 2 edits in trunk/WebKit2

WebKit2: Repeated cmd-key presses lead to unusable UI state
https://bugs.webkit.org/show_bug.cgi?id=48811
<rdar://problem/8611924>

Reviewed by Alexey Proskuryakov.

Given the asynchronous nature of every interaction with the WebProcess,
we could re-send a keyDown event to AppKit that maps to an
action that is currently disabled and therefore will not trigger an action
but a call to the keyDown method of the NSView. We need to detect this
situation to avoid an infinite loop.

  • UIProcess/API/mac/WKView.mm:

(-[WKView performKeyEquivalent:]): Delay the release of the last processed event
to the moment we receive another event.
(-[WKView keyDown:]): Added early return in case the event is one we have re-sent.

10:51 Changeset [71129] by andersca@apple.com
  • 2 edits in trunk/WebKit2

Assertion hit in WebProcessProxy::~WebProcessProxy()
https://bugs.webkit.org/show_bug.cgi?id=48849
<rdar://problem/8617676>

Reviewed by John Sullivan.

It is perfectly valid for the page map to contain pages if the web process proxy
goes away, this can happen if the process crashes for example.

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::~WebProcessProxy):
Remove the assertion.

10:35 Changeset [71128] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit2

2010-11-02 Christian Sejersen <christian.webkit@gmail.com>

Reviewed by Andreas Kling.

The previous patch only took into account arm targets. This one
now checks whether the build is done inside Scratchbox.
https://bugs.webkit.org/show_bug.cgi?id=47895

  • DerivedSources.pro:
10:26 Changeset [71127] by andersca@apple.com
  • 15 edits in trunk/WebKit2

More NPRuntime work
https://bugs.webkit.org/show_bug.cgi?id=48847

Reviewed by Adam Roben.

  • PluginProcess/WebProcessConnection.cpp:

(WebKit::WebProcessConnection::~WebProcessConnection):
Add assertions.

(WebKit::WebProcessConnection::removePluginControllerProxy):
If we have no more plug-in controller proxies, invalidate the remote object map.

  • Shared/Plugins/NPIdentifierData.cpp:

(WebKit::NPIdentifierData::createNPIdentifier):
Create an NPIdentifier from the given NPIdentifierData.

  • Shared/Plugins/NPObjectMessageReceiver.cpp:

(WebKit::NPObjectMessageReceiver::create):
(WebKit::NPObjectMessageReceiver::NPObjectMessageReceiver):
This now takes the NPRemoteObjectMap as well as the npObjectID of the object.

(WebKit::NPObjectMessageReceiver::~NPObjectMessageReceiver):
Unregister the object.

(WebKit::NPObjectMessageReceiver::deallocate):
Delete the object.

(WebKit::NPObjectMessageReceiver::getProperty):
Ask the NPObject for the property and convert it back to an NPVariantData.

  • Shared/Plugins/NPObjectProxy.cpp:

(WebKit::NPObjectProxy::~NPObjectProxy):
Send a Deallocate message to the corresponding message receiver on the other side.

(WebKit::NPObjectProxy::getProperty):
Convert the NPVariantData back to an NPVariant and return it.

  • Shared/Plugins/NPRemoteObjectMap.cpp:

(WebKit::NPRemoteObjectMap::registerNPObject):
Pass the NPRemoteObjectMap and the npObjectID to NPObjectMessageReceiver::create.

(WebKit::NPRemoteObjectMap::unregisterNPObject):
Remove the given object from the map of registered objects.

(WebKit::NPRemoteObjectMap::npVariantToNPVariantData):
Given an NPVariant, create an NPVariantData. Only supports void and double types right now.

(WebKit::NPRemoteObjectMap::npVariantDataToNPVariant):
Given an NPVariantData, create an NPVariant. Only supports void and double types right now.

(WebKit::NPRemoteObjectMap::invalidate):
Add stub.

  • Shared/Plugins/NPVariantData.cpp:

(WebKit::NPVariantData::NPVariantData):
Set the type to void by default.

(WebKit::NPVariantData::makeVoid):
Return a void NPVariantData.

(WebKit::NPVariantData::makeDouble):
Return an NPVariantData that contains a double value.

(WebKit::NPVariantData::encode):
Encode the NPVariantData.

(WebKit::NPVariantData::decode):
Decode the NPVariantData.

  • Shared/Plugins/NPVariantData.h:

(WebKit::NPVariantData::type):
Return the type of the NPVariantData.

(WebKit::NPVariantData::doubleValue):
Return the double value of the NPVariantData.

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::didClose):
Use nullptr instead of 0.

  • WebProcess/Plugins/PluginProcessConnection.cpp:

(WebKit::PluginProcessConnection::~PluginProcessConnection):
Assert that the connection and the remote object map are both null.

(WebKit::PluginProcessConnection::removePluginProxy):
If this was the last plug-in proxy, invalidate the remote object map.

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::shutdown):
Use nullptr instead of 0.

10:25 Changeset [71126] by aroben@apple.com
  • 2 edits in trunk/LayoutTests

Skip another test that fails in WebKit2

  • platform/mac-wk2/Skipped:
10:19 Changeset [71125] by cmarrin@apple.com
  • 7 edits in trunk/WebCore

2010-11-02 Chris Marrin <cmarrin@apple.com>

Reviewed by Adam Roben.

Make RenderStyle::playState() return typed value and cleanup naming in Animation code
https://bugs.webkit.org/show_bug.cgi?id=48844

playState() function was returning unsigned value, but there is a EAnimPlayState
enum type which has the legal playState values. This type is now used everywhere.
I also changed the naming of the m_isSuspended to m_suspended to match the style
elsewhere in the code.

  • page/animation/AnimationBase.cpp: (WebCore::AnimationBase::updatePlayState):
  • page/animation/AnimationBase.h:
  • page/animation/AnimationController.cpp: (WebCore::AnimationControllerPrivate::clear): (WebCore::AnimationControllerPrivate::updateAnimationTimer):
  • page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimation::updateKeyframeAnimations): (WebCore::CompositeAnimation::suspendAnimations): (WebCore::CompositeAnimation::resumeAnimations):
  • page/animation/CompositeAnimation.h: (WebCore::CompositeAnimation::suspended): (WebCore::CompositeAnimation::CompositeAnimation):
  • platform/animation/Animation.h: (WebCore::Animation::playState): (WebCore::Animation::setPlayState): (WebCore::Animation::initialAnimationPlayState):
10:08 Changeset [71124] by aroben@apple.com
  • 13 edits in trunk/LayoutTests

Update Windows results after r71043

  • platform/win/fast/blockflow/border-vertical-lr-expected.checksum:
  • platform/win/fast/blockflow/border-vertical-lr-expected.png:
  • platform/win/fast/blockflow/border-vertical-lr-expected.txt:
  • platform/win/fast/blockflow/japanese-lr-text-expected.checksum:
  • platform/win/fast/blockflow/japanese-lr-text-expected.png:
  • platform/win/fast/blockflow/japanese-lr-text-expected.txt:
  • platform/win/fast/blockflow/japanese-rl-text-expected.checksum:
  • platform/win/fast/blockflow/japanese-rl-text-expected.png:
  • platform/win/fast/blockflow/japanese-rl-text-expected.txt:
  • platform/win/fast/text/international/vertical-text-glyph-test-expected.checksum:
  • platform/win/fast/text/international/vertical-text-glyph-test-expected.png:
  • platform/win/fast/text/international/vertical-text-glyph-test-expected.txt:
10:00 TriagingTestFailures edited by aroben@apple.com
More wordsmithing (diff)
09:46 TriagingTestFailures edited by aroben@apple.com
Reword the intro a bit (diff)
09:44 Changeset [71123] by zmo@google.com
  • 3 edits
    2 adds in trunk

2010-11-01 Zhenyao Mo <zmo@google.com>

Reviewed by Andreas Kling.

vertexAttribPointer should generate INVALID_VALUE if the stride exceeds 255
https://bugs.webkit.org/show_bug.cgi?id=48677

Test: fast/canvas/webgl/gl-vertexattribpointer.html

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::vertexAttribPointer): Generate INVALID_VALUE if stride > 255.

2010-11-01 Zhenyao Mo <zmo@google.com>

Reviewed by Andreas Kling.

vertexAttribPointer should generate INVALID_VALUE if the stride exceeds 255
https://bugs.webkit.org/show_bug.cgi?id=48677

  • fast/canvas/webgl/gl-vertexattribpointer-expected.txt: Added.
  • fast/canvas/webgl/gl-vertexattribpointer.html: Added.
09:44 TriagingTestFailures edited by aroben@apple.com
Flesh out the intro and add a note about migrating into Radar (diff)
09:39 Changeset [71122] by kbalazs@webkit.org
  • 2 edits in trunk/WebKit2

Unreviewed Qt buildfix.

message recievers.

09:38 TriagingTestFailures edited by aroben@apple.com
Address more of John Sullivan's feedback (diff)
09:35 TriagingTestFailures edited by aroben@apple.com
Address more of John Sullivan's feedback (diff)
09:32 TriagingTestFailures edited by aroben@apple.com
Address some of John Sullivan's feedback (diff)
09:25 TriagingTestFailures edited by aroben@apple.com
Fleshed out a little more (diff)
09:11 TriagingTestFailures edited by aroben@apple.com
Slightly more prose-y (diff)
09:10 TriagingTestFailures created by aroben@apple.com
Initial version
09:06 Changeset [71121] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

2010-11-02 Stephen White <senorblanco@chromium.org>

Unreviewed; test expectations fix.

[Chromium] Update chromium-gpu test_expectations to reflect the
test results from the FYI bots.

  • platform/chromium-gpu/test_expectations.txt:
09:04 Changeset [71120] by dbates@webkit.org
  • 6 edits in trunk/WebKit

2010-11-02 Daniel Bates <dbates@rim.com>

Reviewed by Martin Robinson.

Set frame name before appending it to the frame tree in the Apple Windows,
GTK, and EFL ports
https://bugs.webkit.org/show_bug.cgi?id=48806

Make the frame creation process in the GTK-port consistent with the
Mac, Qt, and Haiku ports. In particular, set the name of the new
frame before it's appended to the frame tree.

At this time we cannot test this change since it is being masked by
HTMLFrameElementBase::setName() <http://trac.webkit.org/browser/trunk/WebCore/html/HTMLFrameElementBase.cpp?rev=70976#L160>.
We'll be able to test this once we fix bug #6751.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::createFrame):

2010-11-02 Daniel Bates <dbates@rim.com>

Reviewed by Martin Robinson.

Set frame name before appending it to the frame tree in the Apple Windows,
GTK, and EFL ports
https://bugs.webkit.org/show_bug.cgi?id=48806

Make the frame creation process in the Apple Windows-port consistent
with the Mac, Qt, and Haiku ports. In particular, set the name of
the new frame before it's appended to the frame tree.

At this time we cannot test this change since it is being masked by
HTMLFrameElementBase::setName() <http://trac.webkit.org/browser/trunk/WebCore/html/HTMLFrameElementBase.cpp?rev=70976#L160>.
We'll be able to test this once we fix bug #6751.

  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::createFrame):

2010-11-02 Daniel Bates <dbates@rim.com>

Reviewed by Martin Robinson.

Set frame name before appending it to the frame tree in the Apple Windows,
GTK, and EFL ports
https://bugs.webkit.org/show_bug.cgi?id=48806

Make the frame creation process in the EFL-port consistent with the
Mac, Qt, and Haiku ports. In particular, set the name of the new
frame before it's appended to the frame tree.

At this time we cannot test this change since it is being masked by
HTMLFrameElementBase::setName() <http://trac.webkit.org/browser/trunk/WebCore/html/HTMLFrameElementBase.cpp?rev=70976#L160>.
We'll be able to test this once we fix bug #6751.

  • ewk/ewk_frame.cpp: (ewk_frame_child_add):
08:52 Changeset [71119] by mrobinson@webkit.org
  • 3 edits in trunk/WebCore

2010-11-01 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[Soup] Random crashes in http/tests/websocket/tests/workers/worker-handshake-challenge-randomness.html
https://bugs.webkit.org/show_bug.cgi?id=48805

Track active WebSocket handles via a sequential id. This ensures
that when a handle is reallocated into a recently used segment of
memory, it doesn't trigger a false positive in the code which ensures
the original handle is active.

No new tests. This test should stop crashing on the bots, proving the fix.

  • platform/network/soup/SocketStreamHandle.h: (WebCore::SocketStreamHandle::id): Added an m_id member and accessor to SocketStreamHandle.
  • platform/network/soup/SocketStreamHandleSoup.cpp: (WebCore::getHandleFromId): Updated to work with HashMap of handle ids to SocketStreamHandle*. (WebCore::deactivateHandle): Ditto. (WebCore::activateHandle): Ditto. (WebCore::SocketStreamHandle::SocketStreamHandle): Ditto. (WebCore::SocketStreamHandle::connected): Ditto. (WebCore::SocketStreamHandle::readBytes): Ditto. (WebCore::SocketStreamHandle::beginWaitingForSocketWritability): Ditto. (WebCore::connectedCallback): Ditto. (WebCore::readReadyCallback): Ditto. (WebCore::writeReadyCallback): Ditto.
08:47 Changeset [71118] by kbalazs@webkit.org
  • 3 edits in trunk/WebKit2

[Qt][WK2] SharedMemory is broken
https://bugs.webkit.org/show_bug.cgi?id=48520

Reviewed by Andreas Kling.

Implement SharedMemory with QSharedMemory to correctly handle
ownership and to avoid extra allocation for page size requests.

  • Platform/SharedMemory.h:
  • Platform/qt/SharedMemoryQt.cpp:

(WebKit::SharedMemory::Handle::Handle):
(WebKit::SharedMemory::Handle::isNull):
(WebKit::SharedMemory::Handle::encode):
(WebKit::SharedMemory::Handle::decode):
(WebKit::createUniqueKey):
(WebKit::SharedMemory::create):
(WebKit::accessMode):
(WebKit::SharedMemory::~SharedMemory):
(WebKit::SharedMemory::createHandle):

08:41 WikiStart edited by aroben@apple.com
Add a link to a new to-be-written page about triaging test failures (diff)
08:37 Changeset [71117] by ossy@webkit.org
  • 2 edits in trunk/WebCore

Unreviewed trivial fix.

  • WebCore.pro: Remove inspector/InspectorResource.h after r71035.
08:36 Changeset [71116] by aroben@apple.com
  • 2 edits in trunk/WebKitTools

Only track resource identifiers in DRT when dumpResourceLoadCallbacks is on

This reverts Windows to our pre-r71097 behavior. That patch made us
track all resource identifiers, including the main resource, so the
main resource's URL started appearing in test output instead of
"<unknown>". Arguably having the main resource's URL is better, but all
other platforms print "<unknown>" and we want to match.

Fixes <http://webkit.org/b/48837> <rdar://problem/8620351> REGRESSION
(r71097): Many http tests failing on Windows

Reviewed by Anders Carlsson.

  • DumpRenderTree/win/ResourceLoadDelegate.cpp:

(ResourceLoadDelegate::identifierForInitialRequest): Don't add the
identifier to the URL map if we're not supposed to dump resource load
callbacks.
(ResourceLoadDelegate::removeIdentifierForRequest): Always remove the
identifier from the URL map even if we're already "done". There's no
point in keeping out-of-date identifiers around.

08:22 Changeset [71115] by timothy@apple.com
  • 13 edits
    1 add in trunk/WebKit2

Add WKInspector public APIs.

https://webkit.org/b/48718

Reviewed by Pavel Feldman.

  • DerivedSources.make: Added WebInspector to MESSAGE_RECEIVERS section.
  • UIProcess/API/C/WKInspector.cpp:

(WKInspectorIsVisible): Added.
(WKInspectorShow): Added.
(WKInspectorClose): Added.
(WKInspectorShowConsole): Added.
(WKInspectorIsAttached): Added.
(WKInspectorAttach): Added.
(WKInspectorDetach): Added.
(WKInspectorIsDebuggingJavaScript): Added.
(WKInspectorToggleJavaScriptDebugging): Added.
(WKInspectorIsProfilingJavaScript): Added.
(WKInspectorToggleJavaScriptProfiling): Added.
(WKInspectorIsProfilingPage): Added.
(WKInspectorTogglePageProfiling): Added.

  • UIProcess/API/C/WKInspector.h: Added new functions.
  • UIProcess/WebInspectorProxy.cpp:

(WebKit::WebInspectorProxy::WebInspectorProxy): Initialize new booleans.
(WebKit::WebInspectorProxy::invalidate): Reset new booleans.
(WebKit::WebInspectorProxy::show): Added.
(WebKit::WebInspectorProxy::close): Added.
(WebKit::WebInspectorProxy::showConsole): Added.
(WebKit::WebInspectorProxy::attach): Added.
(WebKit::WebInspectorProxy::detach): Added.
(WebKit::WebInspectorProxy::toggleJavaScriptDebugging): Added.
(WebKit::WebInspectorProxy::toggleJavaScriptProfiling): Added.
(WebKit::WebInspectorProxy::togglePageProfiling): Added.

  • UIProcess/WebInspectorProxy.h:

(WebKit::WebInspectorProxy::isVisible): Added.
(WebKit::WebInspectorProxy::isAttached): Added.
(WebKit::WebInspectorProxy::isDebuggingJavaScript): Added.
(WebKit::WebInspectorProxy::isProfilingJavaScript): Added.
(WebKit::WebInspectorProxy::isProfilingPage): Added.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::close): Invalidate the WebInspectorProxy.
(WebKit::WebPageProxy::inspector): Return 0 if closed or invalid.

  • WebKit2.pro: Added new files.
  • WebKit2.xcodeproj/project.pbxproj: Added new Files.
  • WebProcess/WebPage/WebInspector.cpp:

(WebKit::WebInspector::show): Added.
(WebKit::WebInspector::close): Added.
(WebKit::WebInspector::showConsole): Added.
(WebKit::WebInspector::startJavaScriptDebugging): Added.
(WebKit::WebInspector::stopJavaScriptDebugging): Added.
(WebKit::WebInspector::startJavaScriptProfiling): Added.
(WebKit::WebInspector::stopJavaScriptProfiling): Added.
(WebKit::WebInspector::startPageProfiling): Added.
(WebKit::WebInspector::stopPageProfiling): Added.

  • WebProcess/WebPage/WebInspector.h:

(WebKit::WebInspector::page): Added.

  • WebProcess/WebPage/WebInspector.messages.in: Added.
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::close): Destroy the WebInspector.
(WebKit::WebPage::inspector): Return 0 if closed.
(WebKit::WebPage::didReceiveMessage): Send the message to the WebInspector
if the message class is MessageClassWebInspector.

  • win/WebKit2.vcproj: Added new files.
08:22 Changeset [71114] by timothy@apple.com
  • 3 edits in trunk/WebKit2

Make WebInspectorFrontendClient inherit from InspectorFrontendClientLocal.

We can do this since the Web Inspector WebPage will share the same process
with the inspected WebPage.

https://webkit.org/b/48652

Reviewed by Pavel Feldman.

  • WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp:

(WebKit::WebInspectorFrontendClient::WebInspectorFrontendClient):
Call the InspectorFrontendClientLocal constructor.
(WebKit::WebInspectorFrontendClient::attachWindow): Added.
(WebKit::WebInspectorFrontendClient::detachWindow): Added.
(WebKit::WebInspectorFrontendClient::setAttachedWindowHeight): Added.

  • WebProcess/WebCoreSupport/WebInspectorFrontendClient.h:
07:32 Changeset [71113] by podivilov@chromium.org
  • 4 edits in trunk/WebCore

2010-11-02 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: make xhr breakpoints editable
https://bugs.webkit.org/show_bug.cgi?id=48830

  • inspector/front-end/BreakpointManager.js: (WebInspector.Breakpoint.prototype.set sourceText): (WebInspector.Breakpoint.prototype.click): (WebInspector.Breakpoint.prototype.populateLabelElement): (WebInspector.XHRBreakpoint.prototype.populateEditElement):
  • inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.BreakpointsSidebarPane.prototype.addBreakpointItem): (WebInspector.BreakpointsSidebarPane.prototype._breakpointItemClicked): (WebInspector.BreakpointsSidebarPane.prototype._contextMenuEventFired): (WebInspector.BreakpointsSidebarPane.prototype._addListElement): (WebInspector.BreakpointsSidebarPane.prototype._removeListElement): (WebInspector.XHRBreakpointsSidebarPane.addButtonClicked): (WebInspector.XHRBreakpointsSidebarPane): (WebInspector.XHRBreakpointsSidebarPane.prototype._startEditingBreakpoint): (WebInspector.XHRBreakpointsSidebarPane.prototype._hideEditBreakpointDialog): (WebInspector.XHRBreakpointsSidebarPane.prototype._breakpointItemClicked): (WebInspector.BreakpointItem): (WebInspector.BreakpointItem.prototype.get element): (WebInspector.BreakpointItem.prototype.click): (WebInspector.BreakpointItem.prototype.populateEditElement): (WebInspector.BreakpointItem.prototype.remove): (WebInspector.BreakpointItem.prototype._hitStateChanged): (WebInspector.BreakpointItem.prototype._labelChanged): (WebInspector.BreakpointItem.prototype._createLabelElement):
  • inspector/front-end/inspector.js: (WebInspector.createJSBreakpointsSidebarPane.breakpointAdded): (WebInspector.createJSBreakpointsSidebarPane): (WebInspector.createDOMBreakpointsSidebarPane.breakpointAdded): (WebInspector.createDOMBreakpointsSidebarPane): (WebInspector.createXHRBreakpointsSidebarPane.breakpointAdded): (WebInspector.createXHRBreakpointsSidebarPane):
06:54 Changeset [71112] by podivilov@chromium.org
  • 3 edits in trunk/WebCore

2010-11-02 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: fix for breakpoints not restored on live edit bug
https://bugs.webkit.org/show_bug.cgi?id=48833

  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.debuggerPaused):
  • inspector/front-end/inspector.js: (WebInspector.pausedScript):
06:35 Changeset [71111] by apavlov@chromium.org
  • 3 edits in trunk/WebCore

2010-11-02 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [REGRESSION] Rule addition/selector editing result in unusable rules
https://bugs.webkit.org/show_bug.cgi?id=48826

  • inspector/front-end/CSSStyleModel.js: (WebInspector.CSSStyleModel.prototype.setRuleSelector): (WebInspector.CSSStyleModel.prototype.addRule):
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.BlankStylePropertiesSection.prototype.editingSelectorCommitted.successCallback): (WebInspector.BlankStylePropertiesSection.prototype.editingSelectorCommitted):
05:08 Changeset [71110] by vestbo@webkit.org
  • 2 edits in trunk/WebCore

[Qt] Don't include Objective-C sources in SOURCES

Reviewed by Andreas Kling.

  • WebCore.pro:
03:43 Changeset [71109] by podivilov@chromium.org
  • 17 edits in trunk/WebCore

2010-11-02 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: persist native breakpoints in localStorage
https://bugs.webkit.org/show_bug.cgi?id=48711

  • inspector/InspectorController.cpp: (WebCore::InspectorController::disconnectFrontend): (WebCore::InspectorController::didCommitLoad): (WebCore::InspectorController::clearNativeBreakpoints):
  • inspector/InspectorController.h:
  • inspector/front-end/BreakpointManager.js: (WebInspector.BreakpointManager): (WebInspector.DOMBreakpoint): (WebInspector.EventListenerBreakpoint): (WebInspector.EventListenerBreakpoint.eventNameForUI): (WebInspector.EventListenerBreakpoint.prototype._uiEventName): (WebInspector.XHRBreakpoint): (WebInspector.XHRBreakpoint.prototype.populateStatusMessageElement):
  • inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.BreakpointsSidebarPane.prototype.addBreakpoint): (WebInspector.BreakpointsSidebarPane.prototype._breakpointHit): (WebInspector.BreakpointItem.prototype._hitStateChanged): (WebInspector.EventListenerBreakpointsSidebarPane):
  • inspector/front-end/ConsoleView.js:
  • inspector/front-end/EventListenersSidebarPane.js:
  • inspector/front-end/NetworkPanel.js:
  • inspector/front-end/Panel.js:
  • inspector/front-end/ResourceView.js:
  • inspector/front-end/ScriptsPanel.js:
  • inspector/front-end/Settings.js: (WebInspector.Settings): (WebInspector.Settings.prototype.inspectedURLChanged): (WebInspector.Settings.prototype._formatProjectKey):
  • inspector/front-end/StoragePanel.js:
  • inspector/front-end/StylesSidebarPane.js:
  • inspector/front-end/WatchExpressionsSidebarPane.js:
  • inspector/front-end/inspector.css: (.pane .breakpoint-hit):
  • inspector/front-end/inspector.js: (WebInspector.set currentPanel): (WebInspector.doLoadedDone.onPopulateScriptObjects): (WebInspector.doLoadedDone): (WebInspector.reset): (WebInspector.inspectedURLChanged):
03:31 Changeset [71108] by pfeldman@chromium.org
  • 3 edits in trunk/WebCore

2010-11-01 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Joseph Pecoraro.

Web Inspector: use mimeType from cached resource
in case response data contains none.
https://bugs.webkit.org/show_bug.cgi?id=48773

  • inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::didReceiveResponse):
  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype._createTable):
03:29 Changeset [71107] by caseq@chromium.org
  • 13 edits in trunk

2010-11-01 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Extensions API] expose API to create properties watch sidebar panes
https://bugs.webkit.org/show_bug.cgi?id=48761

  • inspector/front-end/ExtensionAPI.js: (WebInspector.injectedExtensionAPI.PanelImpl.prototype.createSidebarPane): (WebInspector.injectedExtensionAPI.PanelImpl.prototype.createWatchExpressionSidebarPane.callbackWrapper): (WebInspector.injectedExtensionAPI.PanelImpl.prototype.createWatchExpressionSidebarPane): (WebInspector.injectedExtensionAPI): (WebInspector.injectedExtensionAPI.WatchExpressionSidebarPaneImpl): (WebInspector.injectedExtensionAPI.WatchExpressionSidebarPaneImpl.prototype.setExpression): (WebInspector.injectedExtensionAPI.WatchExpressionSidebarPaneImpl.prototype.setObject):
  • inspector/front-end/ExtensionPanel.js: Added ExtensionWatchSidebarPane (WebInspector.ExtensionWatchSidebarPane): (WebInspector.ExtensionWatchSidebarPane.prototype.setObject): (WebInspector.ExtensionWatchSidebarPane.prototype.setExpression): (WebInspector.ExtensionWatchSidebarPane.prototype._onEvaluate): (WebInspector.ExtensionWatchSidebarPane.prototype._setObject):
  • inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer): (WebInspector.ExtensionServer.prototype.notifyExtensionWatchSidebarUpdated): (WebInspector.ExtensionServer.prototype._onCreateSidebar): (WebInspector.ExtensionServer.prototype._onCreateWatchExpressionSidebarPane): (WebInspector.ExtensionServer.prototype._createSidebar): (WebInspector.ExtensionServer.prototype._onSetWatchSidebarContent):
  • inspector/front-end/InjectedScript.js: (injectedScriptConstructor.):
  • inspector/front-end/RemoteObject.js: Added a wrapper for local JSON object to simulate RemoteObject interface. (WebInspector.RemoteObject.fromLocalObject): (WebInspector.LocalJSONObject): (WebInspector.LocalJSONObject.prototype.get description): (WebInspector.LocalJSONObject.prototype.get type): (WebInspector.LocalJSONObject.prototype.get hasChildren): (WebInspector.LocalJSONObject.prototype.getOwnProperties): (WebInspector.LocalJSONObject.prototype.getProperties): (WebInspector.LocalJSONObject.prototype.isError):

2010-11-01 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Extensions API] expose API to create properties watch sidebar panes
https://bugs.webkit.org/show_bug.cgi?id=48761

  • inspector/extensions-api-expected.txt:
  • inspector/extensions-events-expected.txt:
  • inspector/extensions-expected.txt:
  • inspector/extensions-test.js: Added generic way to dispatch messages to front-end and receive callbacks. (initialize_ExtensionsTest.InspectorTest.dispatchOnMessage): (initialize_ExtensionsTest.InspectorTest.dumpSidebarContent):
  • inspector/extensions.html:
  • inspector/resources/extension-main.js: (dispatchOnFrontend.callbackWrapper): (dispatchOnFrontend):
03:20 Changeset [71106] by philn@webkit.org
  • 2 edits in trunk/LayoutTests

2010-11-02 Philippe Normand <pnormand@igalia.com>

Unreviewed, unskip passing media test on the GTK+ port.

  • platform/gtk/Skipped: Unskip media/video-canvas-alpha.html.
03:11 Changeset [71105] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-11-02 Ryuan Choi <ryuan.choi@samsung.com>

Unreviewed build fix for EFL build with libcurl

[EFL] remove multiple definition with libcurl
https://bugs.webkit.org/show_bug.cgi?id=48499

Add macro to isolate setCookieStoragePrivateBrowsingEnabled from EFL
build because it was duplicated.

  • platform/network/curl/CookieJarCurl.cpp:
02:57 Changeset [71104] by pfeldman@chromium.org
  • 6 edits in trunk/WebCore

2010-11-02 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Joseph Pecoraro.

Web Inspector: highlight frame on hover in resources panel.
https://bugs.webkit.org/show_bug.cgi?id=48760

  • inspector/Inspector.idl:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::highlightFrame):
  • inspector/InspectorController.h: (WebCore::InspectorController::hideFrameHighlight):
  • inspector/front-end/StoragePanel.js: (WebInspector.StoragePanel): (WebInspector.StoragePanel.prototype.showView): (WebInspector.StoragePanel.prototype._onmousemove): (WebInspector.StoragePanel.prototype._onmouseout): (WebInspector.FrameTreeElement.prototype.onselect): (WebInspector.FrameTreeElement.prototype.ondeselect): (WebInspector.FrameTreeElement.prototype.set displayName): (WebInspector.FrameTreeElement.prototype.set hovered):
  • inspector/front-end/inspector.css: (.storage.panel .sidebar li.selected .selection): (.storage.panel .sidebar :focus li.selected .selection): (body.inactive .storage.panel .sidebar li.selected .selection):
01:35 Changeset [71103] by zimmermann@webkit.org
  • 28 edits
    7 adds in trunk

2010-11-02 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Rob Buis.

Convert SVGPreserveAspectRatio to the new SVGPropertyTearOff concept
https://bugs.webkit.org/show_bug.cgi?id=48822

Convert the next type to use the SVGPropertyTearOffConcept. Just SVGAnimatedTransformList/SVGTransform/SVGStringList are missing.

Tests: svg/dom/SVGAnimatedPreserveAspectRatio.html

svg/dom/SVGPreserveAspectRatio.html

  • GNUmakefile.am: Add SVGAnimatedPreserveAspectRatio.h to build.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • bindings/scripts/CodeGenerator.pm: Recognize SVGAnimatedPreserveAspectRatio as new style animated type.
  • bindings/scripts/CodeGeneratorJS.pm: Remove special SVGPreserveAspectRatio handling.
  • bindings/scripts/CodeGeneratorObjC.pm: Always include the type wrapped by SVGPropertyTearOff<> - this was missing before, and now become visible as missing include.
  • bindings/scripts/CodeGeneratorV8.pm: Remove special SVGPreserveAspectRatio handling.
  • svg/DeprecatedSVGAnimatedPropertyTraits.h: Remove SVGPreserveAspectRatio handling.
  • svg/DeprecatedSVGAnimatedTemplate.h: Ditto.
  • svg/SVGAnimatedPreserveAspectRatio.h: Added.
  • svg/SVGFEImageElement.h: s/DECLARE_ANIMATED_PROPERTY/DECLARE_ANIMATED_PROPERTY_NEW/ where SVGPreserveAspectRatio is used.
  • svg/SVGFitToViewBox.cpp: (WebCore::SVGFitToViewBox::viewBoxToViewTransform): SVGPreserveAspectRatio::getCTM doesn't need x/y parameters, they were not used anywhere, remove them.
  • svg/SVGFitToViewBox.h: Replace includes by class forwards.
  • svg/SVGImageElement.h: s/DECLARE_ANIMATED_PROPERTY/DECLARE_ANIMATED_PROPERTY_NEW/ where SVGPreserveAspectRatio is used.
  • svg/SVGLocatable.cpp: Add SVGNames.h include, to allow Qt to build (thanks ews!).
  • svg/SVGMarkerElement.h: Ditto.
  • svg/SVGPatternElement.h: Ditto.
  • svg/SVGPreserveAspectRatio.cpp: Modernize code, add error handling for align/meetOrSlice covered by the new tests. (WebCore::SVGPreserveAspectRatio::SVGPreserveAspectRatio): (WebCore::SVGPreserveAspectRatio::setAlign): (WebCore::SVGPreserveAspectRatio::setMeetOrSlice): (WebCore::SVGPreserveAspectRatio::parsePreserveAspectRatio): (WebCore::SVGPreserveAspectRatio::transformRect): (WebCore::SVGPreserveAspectRatio::getCTM): (WebCore::SVGPreserveAspectRatio::valueAsString):
  • svg/SVGPreserveAspectRatio.h: Reindented header. (WebCore::SVGPreserveAspectRatio::align): Inlined. (WebCore::SVGPreserveAspectRatio::meetOrSlice): Inlined.
  • svg/SVGPreserveAspectRatio.idl: Enable StrictTypeChecking for the align/meetOrSlice properties.
  • svg/SVGSVGElement.h: s/DECLARE_ANIMATED_PROPERTY/DECLARE_ANIMATED_PROPERTY_NEW/ where SVGPreserveAspectRatio is used.
  • svg/SVGStyledTransformableElement.h: Add SVGAnimatedPropertyMacros.h include, needed by efl to build (thanks ews!).
  • svg/SVGSymbolElement.h: Ditto.
  • svg/SVGViewElement.h: Ditto.
  • svg/SVGViewSpec.h: Ditto.

2010-11-02 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Rob Buis.

Convert SVGPreserveAspectRatio to the new SVGPropertyTearOff concept
https://bugs.webkit.org/show_bug.cgi?id=48822

  • svg/dom/SVGAnimatedPreserveAspectRatio-expected.txt: Added.
  • svg/dom/SVGAnimatedPreserveAspectRatio.html: Added.
  • svg/dom/SVGPreserveAspectRatio-expected.txt: Added.
  • svg/dom/SVGPreserveAspectRatio.html: Added.
  • svg/dom/script-tests/SVGAnimatedPreserveAspectRatio.js: Added.
  • svg/dom/script-tests/SVGPreserveAspectRatio.js: Added.

11/01/10:

23:34 Changeset [71102] by morrita@google.com
  • 4 edits in trunk/LayoutTests

2010-11-01 MORITA Hajime <morrita@google.com>

Unreviewed, added skip entries for platforms where spellchecking
is not supported.

  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/qt/Skipped:
22:30 Changeset [71101] by morrita@google.com
  • 8 edits
    3 adds in trunk

2010-11-01 MORITA Hajime <morrita@google.com>

Reviewed by Kent Tamura.

@spellcheck attribute at the child of contentEditable node is ignored.
https://bugs.webkit.org/show_bug.cgi?id=48418

  • editing/spelling/script-tests/spelling-attribute-at-child.js: Added.
  • editing/spelling/spelling-attribute-at-child-expected.txt: Added.
  • editing/spelling/spelling-attribute-at-child.html: Added.

2010-11-01 MORITA Hajime <morrita@google.com>

Reviewed by Kent Tamura.

@spellcheck attribute at the child of contentEditable node is ignored.
https://bugs.webkit.org/show_bug.cgi?id=48418

Changed to check spellcheck availability against a node under the
selection (caret) instead of the focus. For shadow elements, the
check now refers its host node. Note that the original code didn't
care shadows because focus is never set on them.

Test: editing/spelling/spelling-attribute-at-child.html

  • dom/Element.h:
  • editing/Editor.cpp: (WebCore::Editor::markMisspellingsOrBadGrammar): (WebCore::Editor::isSpellCheckingEnabledFor): (WebCore::Editor::isSpellCheckingEnabledInFocusedNode): Now just calling isSpellCheckingEnabledFor() (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
  • editing/Editor.h:
  • platform/ContextMenu.cpp: (WebCore::ContextMenu::populate):
  • rendering/TextControlInnerElements.cpp: (WebCore::TextControlInnerElement::isSpellCheckingEnabled): Added.
  • rendering/TextControlInnerElements.h:
22:09 Changeset [71100] by abarth@webkit.org
  • 50 edits
    11 deletes in trunk/LayoutTests

2010-11-01 Adam Barth <abarth@webkit.org>

Update expected results for PNG ICC profile.

  • platform/chromium-mac/fast/borders/svg-as-border-image-2-expected.checksum:
  • platform/chromium-mac/fast/borders/svg-as-border-image-2-expected.png: Removed.
  • platform/chromium-mac/fast/borders/svg-as-border-image-expected.checksum:
  • platform/chromium-mac/fast/borders/svg-as-border-image-expected.png: Removed.
  • platform/chromium-mac/fast/css/background-shorthand-invalid-url-expected.checksum:
  • platform/chromium-mac/fast/css/background-shorthand-invalid-url-expected.png: Removed.
  • platform/chromium-mac/fast/media/mq-min-pixel-ratio-expected.checksum: Removed.
  • platform/chromium-mac/fast/media/mq-min-pixel-ratio-expected.png: Removed.
  • platform/chromium-mac/fast/reflections/reflection-masks-expected.checksum: Removed.
  • platform/chromium-mac/fast/reflections/reflection-masks-expected.png: Removed.
  • platform/chromium-mac/fast/reflections/reflection-masks-opacity-expected.checksum: Removed.
  • platform/chromium-mac/http/tests/misc/slow-loading-image-in-pattern-expected.checksum:
  • platform/chromium-mac/http/tests/misc/slow-loading-image-in-pattern-expected.png:
  • platform/chromium-mac/scrollbars/listbox-scrollbar-combinations-expected.checksum:
  • platform/chromium-mac/scrollbars/overflow-scrollbar-combinations-expected.checksum:
  • platform/chromium-mac/scrollbars/overflow-scrollbar-combinations-expected.png: Removed.
  • platform/chromium-mac/svg/custom/createImageElement-expected.checksum:
  • platform/chromium-mac/svg/custom/createImageElement-expected.png:
  • platform/chromium-mac/svg/custom/focus-ring-expected.checksum:
  • platform/chromium-mac/svg/custom/focus-ring-expected.png: Removed.
  • platform/chromium-mac/svg/custom/group-opacity-expected.checksum:
  • platform/chromium-mac/svg/custom/group-opacity-expected.png: Removed.
  • platform/chromium-mac/svg/custom/image-parent-translation-expected.checksum:
  • platform/chromium-mac/svg/custom/image-parent-translation-expected.png:
  • platform/chromium-mac/svg/custom/image-small-width-height-expected.checksum:
  • platform/chromium-mac/svg/custom/image-small-width-height-expected.png:
  • platform/chromium-mac/svg/custom/image-with-transform-clip-filter-expected.checksum:
  • platform/chromium-mac/svg/custom/js-update-image-and-display-expected.checksum:
  • platform/chromium-mac/svg/custom/js-update-image-and-display-expected.png:
  • platform/chromium-mac/svg/custom/js-update-image-and-display2-expected.checksum:
  • platform/chromium-mac/svg/custom/js-update-image-and-display2-expected.png:
  • platform/chromium-mac/svg/custom/js-update-image-and-display3-expected.checksum:
  • platform/chromium-mac/svg/custom/js-update-image-and-display3-expected.png:
  • platform/chromium-mac/svg/custom/js-update-image-expected.checksum:
  • platform/chromium-mac/svg/custom/js-update-image-expected.png:
  • platform/chromium-mac/svg/custom/pointer-events-image-expected.checksum:
  • platform/chromium-mac/svg/custom/pointer-events-image-expected.png:
  • platform/chromium-mac/svg/custom/text-image-opacity-expected.checksum:
  • platform/chromium-mac/svg/custom/text-image-opacity-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-height-attr-expected.checksum:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-height-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.checksum:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-width-attr-expected.checksum:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-width-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-x-attr-expected.checksum:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-x-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-y-attr-expected.checksum:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-dom-y-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.checksum:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.checksum:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.checksum:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-x-prop-expected.checksum:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-x-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-y-prop-expected.checksum:
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-y-prop-expected.png:
  • platform/chromium/test_expectations.txt:
21:34 Changeset [71099] by mrobinson@webkit.org
  • 2 edits in trunk/WebCore

2010-11-01 Martin Robinson <mrobinson@igalia.com>

Reviewed by Daniel Bates.

[GTK] PopupMenuGtk has a very confusing if-else block
https://bugs.webkit.org/show_bug.cgi?id=48816

Small code cleanup for PopupMenuGtk.

  • platform/gtk/PopupMenuGtk.cpp: (WebCore::PopupMenuGtk::show):
21:15 Changeset [71098] by abarth@webkit.org
  • 7 edits in trunk/WebCore

2010-11-01 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

[Chromium] Add ICC support for PNG on Mac
https://bugs.webkit.org/show_bug.cgi?id=48170

This just pipes the ICC profile from libpng to CoreGraphics. This
patch would have been a lot prettier on Snow Leopard, but we have to
use a somewhat ugly API to get this to work on Leopard.

This is covered by about infinite tests.

  • platform/image-decoders/ImageDecoder.cpp: (WebCore::RGBA32Buffer::setColorProfile):
  • platform/image-decoders/ImageDecoder.h:
  • platform/image-decoders/cg/ImageDecoderCG.cpp: (WebCore::RGBA32Buffer::asNewNativeImage):
  • platform/image-decoders/png/PNGImageDecoder.cpp: (WebCore::PNGImageDecoder::headerAvailable): (WebCore::PNGImageDecoder::rowAvailable):
  • platform/image-decoders/qt/RGBA32BufferQt.cpp: (WebCore::RGBA32Buffer::setColorProfile):
  • platform/image-decoders/skia/ImageDecoderSkia.cpp: (WebCore::RGBA32Buffer::setColorProfile):
19:42 Changeset [71097] by commit-queue@webkit.org
  • 7 edits
    1 add in trunk

2010-11-01 Jenn Braithwaite <jennb@chromium.org>

Reviewed by Adam Roben.

Windows: Update resource tracking when moving a frame between documents
https://bugs.webkit.org/show_bug.cgi?id=48364

  • Interfaces/IWebResourceLoadDelegatePrivate2.idl:Added Added removeIdentifierForRequest.
  • Interfaces/WebKit.idl: Added IWebResourceLoadDelegatePrivate2.idl.
  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::transferLoadingResourceFromPage):

2010-11-01 Jenn Braithwaite <jennb@chromium.org>

Reviewed by Adam Roben.

Windows: Update resource tracking when moving a frame between documents
https://bugs.webkit.org/show_bug.cgi?id=48364

  • DumpRenderTree/win/DumpRenderTree.cpp: (createWebViewAndOffscreenWindow): (main): Give each WebView its own ResourceLoadDelegate instance in order to make assertions about resource ids on a particular WebView.
  • DumpRenderTree/win/ResourceLoadDelegate.cpp: (ResourceLoadDelegate::identifierForInitialRequest): Always add id to the map. (ResourceLoadDelegate::removeIdentifierForRequest): Added. (ResourceLoadDelegate::willSendRequest): (ResourceLoadDelegate::didReceiveAuthenticationChallenge): (ResourceLoadDelegate::didReceiveResponse): (ResourceLoadDelegate::didFinishLoadingFromDataSource): (ResourceLoadDelegate::didFailLoadingWithError): (ResourceLoadDelegate::descriptionSuitableForTestResult): Replace static descriptionSuitableForTestResult with static member function to access identifier map.
  • DumpRenderTree/win/ResourceLoadDelegate.h: (ResourceLoadDelegate::urlMap): Moved within class so that each WebView has its own id map.
19:20 Changeset [71096] by commit-queue@webkit.org
  • 2 edits in trunk

2010-11-01 Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>

Reviewed by Andreas Kling.

[Qt][Symbian] QtTestBrowser runs out of memory with most of javascript benchmarks.
https://bugs.webkit.org/show_bug.cgi?id=48730

Increase the maximum heap size on Symbian to 256 MB.

  • WebKit.pri:
19:10 Changeset [71095] by dimich@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

[Chromium] Unreviewed update of test expectations.
Snap chromium checksum for the newly added baseline (added in http://trac.webkit.org/changeset/71088)

  • platform/chromium-mac/fast/css/text-input-with-webkit-border-radius-expected.checksum: Added.
18:56 Changeset [71094] by chang.shu@nokia.com
  • 5 edits in trunk

2010-11-01 Chang Shu <chang.shu@nokia.com>

Reviewed by Antonio Gomes.

Leave SelectElement key handling without setting event default
handled when the selection reaches the boundary so focus can
move to neighbor nodes in spatial navigation.
https://bugs.webkit.org/show_bug.cgi?id=48145

  • fast/events/spatial-navigation/snav-multiple-select-expected.txt:
  • fast/events/spatial-navigation/snav-multiple-select.html:

2010-11-01 Chang Shu <chang.shu@nokia.com>

Reviewed by Antonio Gomes.

Leave SelectElement key handling without setting event default
handled when the selection reaches the boundary so focus can
move to neighbor nodes in spatial navigation.
https://bugs.webkit.org/show_bug.cgi?id=48145

  • dom/SelectElement.cpp: (WebCore::SelectElement::listBoxDefaultEventHandler):
18:54 Changeset [71093] by dimich@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed update of test expectations.
Did I run --lint-test-files last time? Probably not.

  • platform/chromium/test_expectations.txt:
18:44 Changeset [71092] by dimich@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed update of test expectations.

  • platform/chromium/test_expectations.txt:
18:40 Changeset [71091] by commit-queue@webkit.org
  • 3 edits in trunk/WebCore

2010-11-01 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r71080.
http://trac.webkit.org/changeset/71080
https://bugs.webkit.org/show_bug.cgi?id=48815

This change caused many crashes on the debug bot. (Requested
by mrobinson on #webkit).

  • platform/network/soup/SocketStreamHandle.h:
  • platform/network/soup/SocketStreamHandleSoup.cpp: (WebCore::isActiveHandle): (WebCore::deactivateHandle): (WebCore::SocketStreamHandle::SocketStreamHandle): (WebCore::SocketStreamHandle::connected): (WebCore::SocketStreamHandle::readBytes): (WebCore::SocketStreamHandle::beginWaitingForSocketWritability): (WebCore::connectedCallback): (WebCore::readReadyCallback): (WebCore::writeReadyCallback):
18:36 Changeset [71090] by commit-queue@webkit.org
  • 4 edits in trunk/WebKit/gtk

2010-11-01 Jennifer Braithwaite <jennb@google.com>

Reviewed by Martin Robinson.

GTK: Update resource tracking when moving a frame between documents
https://bugs.webkit.org/show_bug.cgi?id=48362

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::transferLoadingResourceFromPage): Assign resource id to current web view and remove from former web view.
  • webkit/webkitprivate.h:
  • webkit/webkitwebview.cpp: (webkit_web_view_remove_resource): Added.
18:15 Changeset [71089] by commit-queue@webkit.org
  • 5 edits in trunk/WebKit2

2010-11-01 Juha Savolainen <juha.savolainen@weego.fi>

Reviewed by Kenneth Rohde Christiansen.

Initial implementation of QWKHistoryItem.
https://bugs.webkit.org/show_bug.cgi?id=48620

The QWkHistoryItem represents one item in the history of QWKPage.

  • UIProcess/API/qt/qwkhistory.cpp: (QWKHistoryItemPrivate::QWKHistoryItemPrivate): (QWKHistoryItem::QWKHistoryItem): (QWKHistoryItem::~QWKHistoryItem): (QWKHistoryItem::title): The page title (QWKHistoryItem::url): The URL of the page. (QWKHistoryItem::originalUrl): The URL used to access the page.
  • UIProcess/API/qt/qwkhistory.h:
  • UIProcess/API/qt/qwkhistory_p.h:
  • WebKit2.pro: Added WKBackForwardListItem.h and WKBackForwardListItem.cpp
17:55 Changeset [71088] by mihaip@chromium.org
  • 311 edits
    310 copies
    3 adds in trunk/LayoutTests

2010-11-01 Mihai Parparita <mihaip@chromium.org>

Update the pixel expectations for css/ for the Mac port.

For the tests that currently fail on Snow Leopard with --pixel-tests
--tolerance 0, this moves the current pixel results to mac-leopard and
adds new Snow Leopard-specific results to platform/mac.

List of files omitted due to length but composed entirely of moves from
platform/mac to platform/mac-leopard and newly added files in
platform/mac.

17:47 Changeset [71087] by dimich@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed update of test expectations.

  • platform/chromium/test_expectations.txt:
17:39 Changeset [71086] by hyatt@apple.com
  • 1 add in trunk/LayoutTests/platform/mac/fast/repaint/inline-vertical-rl-overflow-expected.txt

Fix layout tests.

17:38 Changeset [71085] by hyatt@apple.com
  • 1 edit in trunk/LayoutTests/platform/mac/fast/text/international/vertical-text-glyph-test-expected.txt

Fix layout tests.

17:31 Changeset [71084] by mihaip@chromium.org
  • 263 edits
    262 copies
    2 adds in trunk/LayoutTests

2010-11-01 Mihai Parparita <mihaip@chromium.org>

Update the pixel expectations for editing/ for the Mac port.

For the tests that currently fail on Snow Leopard with --pixel-tests
--tolerance 0, this moves the current pixel results to mac-leopard and
adds new Snow Leopard-specific results to platform/mac.

List of files omitted due to length but composed entirely of moves from
platform/mac to platform/mac-leopard and newly added files in
platform/mac.

Some tests had differences due to spell correction underlining, those
were skipped since it's not clear what the correct dictionary state is.

17:17 Changeset [71083] by ojan@chromium.org
  • 2 edits in trunk/WebKitTools

2010-11-01 Ojan Vafai <ojan@chromium.org>

Reviewed by Dimitri Glazkov.

remove debug code from run_webkit_tests.py
https://bugs.webkit.org/show_bug.cgi?id=48800

Remove temporary debug code and make --master-name required
if --test-results-server is set now that all clients set
--master-name.

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
17:17 Changeset [71082] by dimich@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed update of test expectations.
Temporarily disable new test added by http://trac.webkit.org/changeset/71066
Need to convert it to dumpAsText().

  • platform/chromium/test_expectations.txt:
17:12 Changeset [71081] by andersca@apple.com
  • 9 edits in trunk/WebKit2

Make NPRemoteObjectMap a ref counted object
https://bugs.webkit.org/show_bug.cgi?id=48808

Reviewed by Oliver Hunt.

  • PluginProcess/PluginControllerProxy.cpp:

(WebKit::PluginControllerProxy::windowScriptNPObject):

  • PluginProcess/WebProcessConnection.cpp:

(WebKit::WebProcessConnection::WebProcessConnection):
(WebKit::WebProcessConnection::didReceiveSyncMessage):

  • PluginProcess/WebProcessConnection.h:

(WebKit::WebProcessConnection::npRemoteObjectMap):

  • Shared/Plugins/NPRemoteObjectMap.cpp:

(WebKit::NPRemoteObjectMap::create):
(WebKit::NPRemoteObjectMap::~NPRemoteObjectMap):
(WebKit::NPRemoteObjectMap::createNPObjectProxy):

  • Shared/Plugins/NPRemoteObjectMap.h:
  • WebProcess/Plugins/PluginProcessConnection.cpp:

(WebKit::PluginProcessConnection::PluginProcessConnection):
(WebKit::PluginProcessConnection::didReceiveSyncMessage):

  • WebProcess/Plugins/PluginProcessConnection.h:

(WebKit::PluginProcessConnection::npRemoteObjectMap):

  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::getWindowScriptNPObject):

17:09 Changeset [71080] by mrobinson@webkit.org
  • 3 edits in trunk/WebCore

2010-11-01 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[Soup] Random crashes in http/tests/websocket/tests/workers/worker-handshake-challenge-randomness.html
https://bugs.webkit.org/show_bug.cgi?id=48805

Track active WebSocket handles via a sequential id. This ensures
that when a handle is reallocated into a recently used segment of
memory, it doesn't trigger a false positive in the code which ensures
the original handle is active.

No new tests. This test should stop crashing on the bots, proving the fix.

  • platform/network/soup/SocketStreamHandle.h: (WebCore::SocketStreamHandle::id): Added an m_id member and accessor to SocketStreamHandle.
  • platform/network/soup/SocketStreamHandleSoup.cpp: (WebCore::getHandleFromId): Updated to work with HashMap of handle ids to SocketStreamHandle*. (WebCore::deactivateHandle): Ditto. (WebCore::activateHandle): Ditto. (WebCore::SocketStreamHandle::SocketStreamHandle): Ditto. (WebCore::SocketStreamHandle::connected): Ditto. (WebCore::SocketStreamHandle::readBytes): Ditto. (WebCore::SocketStreamHandle::beginWaitingForSocketWritability): Ditto. (WebCore::connectedCallback): Ditto. (WebCore::readReadyCallback): Ditto. (WebCore::writeReadyCallback): Ditto.
17:05 Changeset [71079] by tkent@chromium.org
  • 2 edits in trunk/WebCore

2010-11-01 Kent Tamura <tkent@chromium.org>

Unreviewed. Run sort-Xcode-project-file.

  • WebCore.xcodeproj/project.pbxproj:
17:05 Changeset [71078] by tony@chromium.org
  • 2 edits in trunk/WebKitTools

2010-11-01 Tony Chang <tony@chromium.org>

Reviewed by Kent Tamura.

add plugin event logging for linux
https://bugs.webkit.org/show_bug.cgi?id=48779

This is taken from Chromium's fork of the layout test plugin:
http://git.chromium.org/gitweb/?p=chromium.git/.git;a=blob;f=webkit/tools/npapi_layout_test_plugin/main.cpp;h=3ebdada2f049b3624756438cff852364f86a2ede;hb=HEAD#l348

  • DumpRenderTree/TestNetscapePlugIn/main.cpp: (handleEventX11): (NPP_HandleEvent):
17:00 Changeset [71077] by tony@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-11-01 Tony Chang <tony@chromium.org>

Reviewed by Kent Tamura.

[chromium] Compile TestNetscapePlugin on chromium win
https://bugs.webkit.org/show_bug.cgi?id=48802

It creates npTestNetscapePlugin.dll in the build directory, so
it's not yet loaded by DRT or test_shell.

  • WebKit.gyp:
17:00 Changeset [71076] by andersca@apple.com
  • 1 edit in trunk/WebKit2/ChangeLog

Remove duplicate ChangeLog entry.

16:58 Changeset [71075] by andersca@apple.com
  • 12 edits
    4 copies in trunk/WebKit2

Respond to NP_GetProperty by sending a GetProperty message
https://bugs.webkit.org/show_bug.cgi?id=48797

Reviewed by John Sullivan.

  • Platform/CoreIPC/HandleMessage.h:

(CoreIPC::callMemberFunction):
Add new sync message overload.

  • PluginProcess/WebProcessConnection.cpp:

(WebKit::WebProcessConnection::didReceiveSyncMessage):
If the message class is MessageClassNPObjectMessageReceiver, pass it to the NPRemoteObjectMap.

  • Shared/Plugins/NPIdentifierData.cpp:
  • Shared/Plugins/NPIdentifierData.h:

Add NPIdentifierData, a CoreIPC representation of an NPIdentifier.

  • Shared/Plugins/NPObjectMessageReceiver.cpp:

(WebKit::NPObjectMessageReceiver::getProperty):
Add stub.

  • Shared/Plugins/NPObjectMessageReceiver.messages.in:

Add GetProperty.

  • Shared/Plugins/NPObjectProxy.cpp:

(WebKit::NPObjectProxy::create):
(WebKit::NPObjectProxy::NPObjectProxy):
(WebKit::NPObjectProxy::initialize):
NPObjectProxy now takes an NPRemoteObjectMap in its create function.

(WebKit::NPObjectProxy::getProperty):
Send a GetProperty message.

(WebKit::NPObjectProxy::NP_GetProperty):
Call getProperty.

  • Shared/Plugins/NPRemoteObjectMap.cpp:

(WebKit::NPRemoteObjectMap::createNPObjectProxy):
Pass the NPRemoteObjectMap.

(WebKit::NPRemoteObjectMap::didReceiveSyncMessage):
Find the right message receiver and dispatch the message to it.

  • Shared/Plugins/NPVariantData.cpp:
  • Shared/Plugins/NPVariantData.h:

Add NPVariantData, which will be a CoreIPC representation of an NPVariant.

  • WebKit2.xcodeproj/project.pbxproj:

Add new files.

  • WebProcess/Plugins/PluginProcessConnection.cpp:

(WebKit::PluginProcessConnection::didReceiveSyncMessage):
If the message class is MessageClassNPObjectMessageReceiver, pass it to the NPRemoteObjectMap.

16:41 Changeset [71074] by simon.fraser@apple.com
  • 3 edits
    3 adds in trunk

2010-11-01 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

Assertion failure in FrameView::layout when clicking on a YouTube video on youtube.com front page
https://bugs.webkit.org/show_bug.cgi?id=44287

When removing subframes, it's possible for layout() to get called on a FrameView
for a Frame that has been removed from the frame tree. This can happen if the parent
document happens to do a layout() while RenderView still has a reference to the widget
for the removed frame; updateWidgetPosition() will try to force a layout() on the
subframe.

Fix by checking that the FrameView's Frame still has a reference to the page before
calling layout() on the subframe.

Test: fast/frames/layout-after-destruction.html

  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::updateWidgetPosition):
16:36 Changeset [71073] by mihaip@chromium.org
  • 201 edits
    200 copies
    18 adds in trunk/LayoutTests

2010-11-01 Mihai Parparita <mihaip@chromium.org>

Update the pixel expectations for fast/dom, fast/dynamic, fast/encoding, fast/events, and fast/gradients for the Mac port.

For the tests that currently fail on Snow Leopard with --pixel-tests
--tolerance 0, this moves the current pixel results to mac-leopard and
adds new Snow Leopard-specific results to platform/mac.

List of files omitted due to length but composed entirely of moves from
platform/mac to platform/mac-leopard and newly added files in
platform/mac.

16:30 Changeset [71072] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2010-11-01 Mihai Parparita <mihaip@chromium.org>

Update the pixel expectations for fast/dom, fast/dynamic, fast/encoding, fast/events, and fast/gradients for the Mac port.

For the tests that currently fail on Snow Leopard with --pixel-tests
--tolerance 0, this moves the current pixel results to mac-leopard and
adds new Snow Leopard-specific results to platform/mac.

List of files omitted due to length but composed entirely of moves from
platform/mac to platform/mac-leopard and newly added files in
platform/mac.

16:25 Changeset [71071] by dimich@chromium.org
  • 7 edits in trunk/WebCore

2010-11-01 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r71065.
http://trac.webkit.org/changeset/71065
https://bugs.webkit.org/show_bug.cgi?id=48801

Seem to breake a lot of tests on Chromium bots (Requested by
dimich on #webkit).

  • platform/image-decoders/ImageDecoder.cpp:
  • platform/image-decoders/ImageDecoder.h:
  • platform/image-decoders/cg/ImageDecoderCG.cpp: (WebCore::RGBA32Buffer::asNewNativeImage):
  • platform/image-decoders/png/PNGImageDecoder.cpp: (WebCore::PNGImageDecoder::headerAvailable): (WebCore::PNGImageDecoder::rowAvailable):
  • platform/image-decoders/qt/RGBA32BufferQt.cpp:
  • platform/image-decoders/skia/ImageDecoderSkia.cpp:
16:23 Changeset [71070] by jamesr@google.com
  • 4 edits
    9 adds
    2 deletes in trunk/LayoutTests

2010-11-01 James Robinson <jamesr@chromium.org>

Update chromium baselines for a few tests.

  • platform/chromium-linux/fast/repaint/iframe-scroll-repaint-expected.checksum: Added.
  • platform/chromium-linux/fast/repaint/iframe-scroll-repaint-expected.png: Added.
  • platform/chromium-linux/svg/custom/resource-invalidate-on-target-update-expected.checksum: Added.
  • platform/chromium-linux/svg/custom/resource-invalidate-on-target-update-expected.png: Added.
  • platform/chromium-mac/fast/repaint/iframe-scroll-repaint-expected.checksum: Added.
  • platform/chromium-mac/fast/repaint/iframe-scroll-repaint-expected.png: Added.
  • platform/chromium-mac/svg/custom/resource-invalidate-on-target-update-expected.checksum: Removed.
  • platform/chromium-mac/svg/custom/resource-invalidate-on-target-update-expected.png: Removed.
  • platform/chromium-win/fast/repaint/iframe-scroll-repaint-expected.checksum: Added.
  • platform/chromium-win/fast/repaint/iframe-scroll-repaint-expected.png: Added.
  • platform/chromium-win/fast/repaint/iframe-scroll-repaint-expected.txt: Added.
  • platform/chromium-win/svg/custom/resource-invalidate-on-target-update-expected.checksum:
  • platform/chromium-win/svg/custom/resource-invalidate-on-target-update-expected.png:
  • platform/chromium/test_expectations.txt:
16:12 Changeset [71069] by andersca@apple.com
  • 2 edits in trunk/WebKit2

Add ArgumentCoder specialization for WTF::CString
https://bugs.webkit.org/show_bug.cgi?id=48796

Reviewed by Sam Weinig.

  • Platform/CoreIPC/ArgumentCoders.h:
16:01 Changeset [71068] by dpranke@chromium.org
  • 3 edits in trunk/WebKitTools

2010-11-01 Dirk Pranke <dpranke@chromium.org>

Reviewed by James Robinson.

new-run-webkit-tests: use DRT, child-processes=1 for GPU tests by default
https://bugs.webkit.org/show_bug.cgi?id=48790

  • Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
  • Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
15:43 Changeset [71067] by hyatt@apple.com
  • 1 edit in trunk/WebCore/rendering/svg/SVGInlineTextBox.cpp

Fix SVG bustage.

15:40 Changeset [71066] by mdelaney@apple.com
  • 3 edits
    3 adds in trunk

2010-11-01 Matthew Delaney <mdelaney@apple.com>

Reviewed by Simon Fraser.

Setting attr repeatDur=0 on SVG element causes hang
https://bugs.webkit.org/show_bug.cgi?id=48785

Test: svg/animations/repeatDur-zero.xhtml

  • svg/animation/SVGSMILElement.cpp: Fixing bound checking for legal repeatDur values.

2010-11-01 Matthew Delaney <mdelaney@apple.com>

Reviewed by Simon Fraser.

Setting attr repeatDur=0 on SVG element causes hang
https://bugs.webkit.org/show_bug.cgi?id=48785

  • svg/animations/repeatDur-zero.xhtml: Added. Tests if setting attr repeatDur=0 causes a hang or not.
15:33 Changeset [71065] by abarth@webkit.org
  • 7 edits in trunk/WebCore

2010-10-31 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

[Chromium] Add ICC support for PNG on Mac
https://bugs.webkit.org/show_bug.cgi?id=48170

This just pipes the ICC profile from libpng to CoreGraphics. This
patch would have been a lot prettier on Snow Leopard, but we have to
use a somewhat ugly API to get this to work on Leopard.

This is covered by about infinite tests.

  • platform/image-decoders/ImageDecoder.cpp: (WebCore::RGBA32Buffer::setColorProfile):
  • platform/image-decoders/ImageDecoder.h:
  • platform/image-decoders/cg/ImageDecoderCG.cpp: (WebCore::RGBA32Buffer::asNewNativeImage):
  • platform/image-decoders/png/PNGImageDecoder.cpp: (WebCore::PNGImageDecoder::headerAvailable): (WebCore::PNGImageDecoder::rowAvailable):
  • platform/image-decoders/qt/RGBA32BufferQt.cpp: (WebCore::RGBA32Buffer::setColorProfile):
  • platform/image-decoders/skia/ImageDecoderSkia.cpp: (WebCore::RGBA32Buffer::setColorProfile):
15:27 Changeset [71064] by abarth@webkit.org
  • 5 edits in trunk/WebKitTools

2010-11-01 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Teach check-webkit-style how to accept a list of files to diff on the
command line
https://bugs.webkit.org/show_bug.cgi?id=48784

In a future patch, webkit-patch will use this option to improve
performance. I'm landing this in two pieces to avoid causing a version
skew problem for the style-bot.

  • Scripts/check-webkit-style:
  • Scripts/webkitpy/style/optparser.py:
  • Scripts/webkitpy/style/optparser_unittest.py:
  • Scripts/webkitpy/style_references.py:
15:20 Changeset [71063] by dimich@chromium.org
  • 3 edits
    4 adds
    2 deletes in trunk/LayoutTests

[Chromium] Unreviewed test rebaseline.

  • platform/chromium-linux/svg/custom/gradient-userSpaceOnUse-with-percentage-expected.checksum: Removed.
  • platform/chromium-linux/svg/custom/gradient-userSpaceOnUse-with-percentage-expected.png: Removed.
  • platform/chromium-mac/fast/blockflow/border-vertical-lr-expected.checksum:
  • platform/chromium-mac/fast/repaint/inline-horizontal-bt-overflow-expected.checksum: Added.
  • platform/chromium-mac/fast/repaint/inline-horizontal-bt-overflow-expected.png: Added.
  • platform/chromium-mac/fast/repaint/inline-vertical-lr-overflow-expected.checksum: Added.
  • platform/chromium-mac/fast/repaint/inline-vertical-lr-overflow-expected.png: Added.
  • platform/chromium/test_expectations.txt:
15:16 Changeset [71062] by mihaip@chromium.org
  • 204 edits
    202 copies
    8 adds in trunk/LayoutTests

2010-11-01 Mihai Parparita <mihaip@chromium.org>

Update the pixel expectations for fast/body-propagation, fast/borders, fast/box-shadow, fast/box-sizing, fast/clip, and fast/compact for the Mac port.

For the tests that currently fail on Snow Leopard with --pixel-tests
--tolerance 0, this moves the current pixel results to mac-leopard and
adds new Snow Leopard-specific results to platform/mac.

List of files omitted due to length but composed entirely of moves from
platform/mac to platform/mac-leopard and newly added files in
platform/mac.

platform/mac/test_expectations.txt was also modified to remove two
now-passing tests.

15:10 Changeset [71061] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

2010-11-01 Stephen White <senorblanco@chromium.org>

Unreviewed; test expectations update.

Update chromium-gpu test expectations to reflect test_shell
timeouts on ~35 tests.

  • platform/chromium-gpu/test_expectations.txt:
14:53 Changeset [71060] by andersca@apple.com
  • 2 edits in trunk/WebKit2

Fix build.

  • WebKit2.xcodeproj/project.pbxproj:
14:51 Changeset [71059] by crogers@google.com
  • 11 edits in branches/audio/WebCore

audio branch: bracket some JS and V8 wrappper and Event code with #if ENABLE(WEB_AUDIO)

14:30 Changeset [71058] by simon.fraser@apple.com
  • 3 edits in trunk/LayoutTests

2010-11-01 Simon Fraser <simon.fraser@apple.com>

Fix test failures on Qt by avoiding references to external image files.

  • fast/backgrounds/multiple-backgrounds-computed-style-expected.txt:
  • fast/backgrounds/script-tests/multiple-backgrounds-computed-style.js:
14:29 Changeset [71057] by andersca@apple.com
  • 6 edits
    1 add in trunk/WebKit2

Add NPObjectMessageReceiver.messages.in
https://bugs.webkit.org/show_bug.cgi?id=48782

Reviewed by Adam Roben.

  • DerivedSources.make:

Add NPObjectMessageReceiver.

  • Platform/CoreIPC/MessageID.h:

Add MessageClassNPObjectMessageReceiver message class.

  • Shared/Plugins/NPObjectMessageReceiver.cpp:

(WebKit::NPObjectMessageReceiver::deallocate):
Add stubbed out deallocate member function.

  • Shared/Plugins/NPObjectMessageReceiver.messages.in: Added.
  • WebKit2.xcodeproj/project.pbxproj:

Add NPObjectMessageReceiver.messages.in.

14:25 Changeset [71056] by mihaip@chromium.org
  • 203 edits
    202 copies
    1 add in trunk/LayoutTests

2010-11-01 Mihai Parparita <mihaip@chromium.org>

Update the pixel expectations for fast/selectors for the Mac port.

For the tests that currently fail on Snow Leopard with --pixel-tests
--tolerance 0, this moves the current pixel results to mac-leopard and
adds new Snow Leopard-specific results to platform/mac.

List of files omitted due to length but composed entirely of moves from
platform/mac to platform/mac-leopard and newly added files in
platform/mac.

14:13 Changeset [71055] by hyatt@apple.com
  • 14 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=48776

Reviewed by Dan Bernstein.

Change isVertical() on InlineBox to isHorizontal() instead. This makes the horizontal code path come
first if you branch on isHorizontal() and makes the code read better (since that's the more common code
path).

  • rendering/InlineBox.cpp:

(WebCore::InlineBox::logicalHeight):

  • rendering/InlineBox.h:

(WebCore::InlineBox::InlineBox):
(WebCore::InlineBox::isHorizontal):
(WebCore::InlineBox::setIsHorizontal):
(WebCore::InlineBox::width):
(WebCore::InlineBox::height):
(WebCore::InlineBox::logicalLeft):
(WebCore::InlineBox::setLogicalLeft):
(WebCore::InlineBox::logicalTop):
(WebCore::InlineBox::setLogicalTop):
(WebCore::InlineBox::baselinePosition):
(WebCore::InlineBox::lineHeight):

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::addToLine):
(WebCore::InlineFlowBox::placeBoxesInInlineDirection):
(WebCore::InlineFlowBox::computeBlockDirectionOverflow):
(WebCore::InlineFlowBox::paintFillLayer):
(WebCore::InlineFlowBox::paintBoxDecorations):
(WebCore::InlineFlowBox::paintMask):

  • rendering/InlineFlowBox.h:

(WebCore::InlineFlowBox::marginLogicalLeft):
(WebCore::InlineFlowBox::marginLogicalRight):
(WebCore::InlineFlowBox::borderLogicalLeft):
(WebCore::InlineFlowBox::borderLogicalRight):
(WebCore::InlineFlowBox::paddingLogicalLeft):
(WebCore::InlineFlowBox::paddingLogicalRight):
(WebCore::InlineFlowBox::setInlineDirectionOverflowPositions):
(WebCore::InlineFlowBox::setBlockDirectionOverflowPositions):

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::selectionRect):
(WebCore::InlineTextBox::applyShadowToGraphicsContext):
(WebCore::paintTextWithShadows):
(WebCore::InlineTextBox::paint):
(WebCore::InlineTextBox::paintDecoration):

  • rendering/InlineTextBox.h:
  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::createLineBoxes):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::blockDirectionOverflow):

  • rendering/RenderBox.h:
  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintFillLayerExtended):

  • rendering/RenderLineBoxList.cpp:

(WebCore::RenderLineBoxList::hitTest):

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::RootInlineBox):
(WebCore::RootInlineBox::placeEllipsis):

  • rendering/RootInlineBox.h:

(WebCore::RootInlineBox::baselinePosition):
(WebCore::RootInlineBox::lineHeight):

14:10 Changeset [71054] by andersca@apple.com
  • 7 edits in trunk/WebKit2

Start stubbing out NPClass functions in NPObjectProxy
https://bugs.webkit.org/show_bug.cgi?id=48778

Reviewed by Adam Roben.

  • PluginProcess/PluginControllerProxy.cpp:

(WebKit::PluginControllerProxy::windowScriptNPObject):
getOrCreateNPObjectProxy is now createNPObjectProxy.

  • Shared/Plugins/NPObjectProxy.cpp:

(WebKit::NPObjectProxy::create):
Allocate and initialize an NPObjectProxy object.

(WebKit::NPObjectProxy::NPObjectProxy):
Initialize m_npObjectID to 0.

(WebKit::NPObjectProxy::isNPObjectProxy):
Check the class.

(WebKit::NPObjectProxy::initialize):
Set m_npObjectID.

(WebKit::NPObjectProxy::npClass):
Return the NPClass with all functions filled in.

(WebKit::NPObjectProxy::NP_Allocate):
Create a new NPObjectProxy object.

(WebKit::NPObjectProxy::NP_Deallocate):
Deallocate the NPObjectProxy object.

(WebKit::NPObjectProxy::NP_HasMethod):
(WebKit::NPObjectProxy::NP_Invoke):
(WebKit::NPObjectProxy::NP_InvokeDefault):
(WebKit::NPObjectProxy::NP_HasProperty):
(WebKit::NPObjectProxy::NP_GetProperty):
(WebKit::NPObjectProxy::NP_SetProperty):
(WebKit::NPObjectProxy::NP_RemoveProperty):
(WebKit::NPObjectProxy::NP_Enumerate):
(WebKit::NPObjectProxy::NP_Construct):
Add stubs.

  • Shared/Plugins/NPRemoteObjectMap.cpp:

(WebKit::NPRemoteObjectMap::createNPObjectProxy):

  • Shared/Plugins/NPRemoteObjectMap.h:

Rename getOrCreateNPObjectProxy to createNPObjectProxy.

  • WebProcess/Plugins/Netscape/NPJSObject.cpp:

(WebKit::NPJSObject::NP_Allocate):
Remove unused parameter.

14:01 Changeset [71053] by dimich@chromium.org
  • 1 edit
    4 adds in trunk/LayoutTests

[Chromium] Unreviewed update of test expectations.
Add baseline for a new test added in http://trac.webkit.org/changeset/71043

  • platform/chromium-mac/fast/repaint/inline-vertical-rl-overflow-expected.checksum: Added.
  • platform/chromium-mac/fast/repaint/inline-vertical-rl-overflow-expected.png: Added.
  • platform/chromium-mac/fast/repaint/inline-vertical-rl-overflow-expected.txt: Added.
  • platform/chromium-win/fast/repaint/inline-vertical-rl-overflow-expected.txt: Added.
14:00 Changeset [71052] by mario@webkit.org
  • 2 edits in trunk/WebKit/gtk

2010-11-01 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Cleanup needed in testatk.c file
https://bugs.webkit.org/show_bug.cgi?id=48759

Cleanup done in testatk.c, mainly addressing the following issues:

  • Removed any trace of extra main loops in tests, so now we just spin the original main loop in all of them to get the a11y objects.
  • As we no longer use the extra main loops, removed the bail_out function, used along with g_idle_add() to stop those extra loops.
  • As we now spin the loop in every test, created a new function waitForAccessibilityObjects() to write the loop just once.
  • Fixed name in incorrectly named test testWekitAtkTextSelections.
  • Alphabetically sorted the list of includes.
  • Renamed all identifiers to camel Case notation.
  • Declare variables when needed only (instead of declaring all of them at the beginning of the function).
  • Don't declare two variables of the same type in the same line.
  • No more short names like 'obj', 'textObj' or 'alloc'. Use names like 'object', 'textObject' and 'allocation' instead.
  • Fixed indentation.
  • Make sure all comments finish with '.'
  • Replace NULL's with 0's.
  • tests/testatk.c: (waitForAccessibleObjects): New, manually spins the main context to make sure accessible objects are created before continuing. (testGetTextFunction): Fixed this function to be compliant with the WebKit's coding style. (runGetTextTests): Ditto. (testWebkitAtkGetTextAtOffsetForms): Ditto. (testWebkitAtkGetTextAtOffset): Ditto. (testWebkitAtkGetTextAtOffsetNewlines): Ditto. (testWebkitAtkGetTextAtOffsetTextarea): Ditto. (testWebkitAtkGetTextAtOffsetTextInput): Ditto. (testWebkitAtkGetTextInParagraphAndBodySimple): Ditto. (testWebkitAtkGetTextInParagraphAndBodyModerate): Ditto. (testWebkitAtkGetTextInTable): Ditto. (testWebkitAtkGetHeadersInTable): Ditto. (compAtkAttribute): Ditto. (atkAttributeSetAttributeNameHasValue): Ditto. (testWebkitAtkTextAttributes): Ditto. (testWebkitAtkTextSelections): Ditto. (testWebkitAtkGetExtents): Ditto. (testWebkitAtkLayoutAndDataTables): Ditto. (testWebkitAtkLinksWithInlineImages): Ditto. (testWebkitAtkHypertextAndHyperlinks): Ditto. (testWebkitAtkListsOfItems): Ditto. (testWebkitAtkTextChangedNotifications): Ditto. (main): Ditto.
13:53 UpdatingBugzilla edited by ddkilzer@apple.com
(diff)
13:47 Changeset [71051] by andersca@apple.com
  • 12 edits in trunk/WebKit2

Both the WebProcessConnection and PluginProcessConnection should have NPRemoteObjectMaps
https://bugs.webkit.org/show_bug.cgi?id=48775

Reviewed by Adam Roben.

  • PluginProcess/PluginControllerProxy.cpp:

(WebKit::PluginControllerProxy::windowScriptNPObject):
Ask for an NPObjectProxy for the window script NPObject.

  • PluginProcess/WebProcessConnection.cpp:

(WebKit::WebProcessConnection::WebProcessConnection):
Initialize m_npRemoteObjectMap.

  • Shared/Plugins/NPObjectMessageReceiver.cpp:

(WebKit::NPObjectMessageReceiver::create):
Add a create member function that takes an NPObject.

(WebKit::NPObjectMessageReceiver::NPObjectMessageReceiver):
Retain the NPObject.

(WebKit::NPObjectMessageReceiver::~NPObjectMessageReceiver):
Release the NPObject.

  • Shared/Plugins/NPRemoteObjectMap.cpp:

(WebKit::generateNPObjectID):
Generate a unique 64-bit NPObject ID.

(WebKit::NPRemoteObjectMap::getOrCreateNPObjectProxy):
Add stub.

(WebKit::NPRemoteObjectMap::registerNPObject):
Create a NPObjectMessageReceiver and add it to the map.

  • WebKit2.xcodeproj/project.pbxproj:

Set the correct target for NPRuntime related files.

  • WebProcess/Plugins/PluginProcessConnection.cpp:

(WebKit::PluginProcessConnection::PluginProcessConnection):
Initialize m_npRemoteObjectMap

  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::getWindowScriptNPObject):
Ask the real plug-in controller for the window script NPObject and register it.

13:44 Changeset [71050] by dimich@chromium.org
  • 11 edits in trunk/LayoutTests

[Chromium] Unreviewed, update test expectations.
Updated render tree dumps after http://trac.webkit.org/changeset/71043.

  • platform/chromium-linux/fast/blockflow/japanese-lr-text-expected.txt:
  • platform/chromium-linux/fast/blockflow/japanese-rl-text-expected.txt:
  • platform/chromium-win/fast/blockflow/basic-vertical-line-expected.txt:
  • platform/chromium-win/fast/blockflow/border-radius-clipping-vertical-lr-expected.txt:
  • platform/chromium-win/fast/blockflow/box-shadow-vertical-lr-expected.txt:
  • platform/chromium-win/fast/blockflow/box-shadow-vertical-rl-expected.txt:
  • platform/chromium-win/fast/blockflow/english-lr-text-expected.txt:
  • platform/chromium-win/fast/blockflow/english-rl-text-expected.txt:
  • platform/chromium-win/fast/blockflow/japanese-lr-text-expected.txt:
  • platform/chromium-win/fast/blockflow/japanese-rl-text-expected.txt:
13:39 Changeset [71049] by simon.fraser@apple.com
  • 3 edits
    5 adds in trunk

2010-11-01 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dave Hyatt.

Multiple background properties are not retrievable via DOM method getComputedStyle
https://bugs.webkit.org/show_bug.cgi?id=23203

Return lists of values from getComputedStyle() for multiple backgrounds,
and multiple masks.

Test: fast/backgrounds/multiple-backgrounds-computed-style.html

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::fillSizeToCSSValue): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
13:37 Changeset [71048] by sullivan@apple.com
  • 5 edits in trunk/WebKit2

https://bugs.webkit.org/show_bug.cgi?id=48774
minimFontSize preference needs to be exposed in WebKit2

Reviewed by Anders Carlsson.

  • UIProcess/WebPreferences.cpp:

(WebKit::WebPreferences::setMinimumFontSize):
New function, parallel to existing functions for other preferences.
(WebKit::WebPreferences::minimumFontSize):
Ditto.

  • UIProcess/WebPreferences.h:

Declared new function.

  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetMinimumFontSize):
New UI process wrapper for new function.
(WKPreferencesGetMinimumFontSize):
Ditto.

  • UIProcess/API/C/WKPreferences.h:

Declared new functions.

13:24 Changeset [71047] by mihaip@chromium.org
  • 101 edits
    100 copies
    2 adds in trunk/LayoutTests

2010-11-01 Mihai Parparita <mihaip@chromium.org>

Update the pixel expectations for fast/block/positioning for the Mac port.

For the tests that currently fail on Snow Leopard with --pixel-tests
--tolerance 0, this moves the current pixel results to mac-leopard and
adds new Snow Leopard-specific results to platform/mac.

List of files omitted due to length but composed entirely of moves from
platform/mac to platform/mac-leopard and newly added files in
platform/mac.

13:20 Changeset [71046] by dimich@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed update of test expectations.
svg-as-background.html now fails on debug mac 10.5 bots.

  • platform/chromium/test_expectations.txt:
12:30 Changeset [71045] by crogers@google.com
  • 13 edits
    1 move
    1 add
    1 delete in branches/audio/WebCore

audio branch: changes in preparation for landing in trunk

  • change name from Accelerate to VectorMath
  • AudioResamplerKernel cleanup
  • JSDOMWindowCustom.cpp: guard include and audioContext() method with ENABLE_WEB_AUDIO
  • V8Binding.cpp: remove AdjustAmountOfExternalAllocatedMemory() hack
12:16 Changeset [71044] by andersca@apple.com
  • 7 edits in trunk

Tear down the related WebProcessProxy when a WebContext is deallocated
https://bugs.webkit.org/show_bug.cgi?id=48769

Reviewed by John Sullivan.

WebKit2:

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::~WebContext):
Call WebProcessManager::contextWasDestroyed.

(WebKit::WebContext::didNavigateWithNavigationData):
(WebKit::WebContext::didPerformClientRedirect):
(WebKit::WebContext::didPerformServerRedirect):
(WebKit::WebContext::didUpdateHistoryTitle):
It is valid for a frame to have a null page here, if the frame has outlived
its page.

  • UIProcess/WebProcessManager.cpp:

(WebKit::WebProcessManager::contextWasDestroyed):
Remove the context from the map.

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::~WebProcessProxy):
It's OK for the connection to be non-null here if the process goes away because
the context has been deallocated.

WebKitTools:

  • TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:

(TestWebKitAPI::didFailProvisionalLoadWithErrorForFrame):
We don't support empty URLs anymore, update test to expect a null URL instead.

12:07 Changeset [71043] by hyatt@apple.com
  • 26 edits
    3 copies
    8 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=48663

Reviewed by Dan Bernstein.

Make repaint invalidation work with vertical lines. Rewrite linesBoundingBox for RenderText and
RenderInline to give the correct rectangle back for vertical lines. Also patch linesVisibleOverflowBoundingBox
to give back the correct rectangle for vertical lines.

Fix bugs in the overflow accessors of InlineFlowBox when m_overflow was 0.

Patch hit testing to also account for "rt" and "bt" blocks.

WebCore:

  • rendering/InlineBox.cpp:

(WebCore::InlineBox::adjustForFlippedBlocksWritingMode):

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::nodeAtPoint):

  • rendering/InlineFlowBox.h:

(WebCore::InlineFlowBox::logicalLeftVisibleOverflow):
(WebCore::InlineFlowBox::logicalRightVisibleOverflow):
(WebCore::InlineFlowBox::bottomLayoutOverflow):
(WebCore::InlineFlowBox::rightLayoutOverflow):
(WebCore::InlineFlowBox::bottomVisualOverflow):
(WebCore::InlineFlowBox::rightVisualOverflow):

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::nodeAtPoint):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::hitTestFloats):
(WebCore::RenderBlock::hitTestContents):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeRectForRepaint):
(WebCore::RenderBox::adjustForFlippedBlocksWritingMode):

  • rendering/RenderBox.h:
  • rendering/RenderInline.cpp:

(WebCore::RenderInline::linesBoundingBox):
(WebCore::RenderInline::linesVisibleOverflowBoundingBox):
(WebCore::RenderInline::clippedOverflowRectForRepaint):

  • rendering/RenderText.cpp:

(WebCore::RenderText::linesBoundingBox):

LayoutTests:

  • fast/repaint/inline-horizontal-bt-overflow.html: Added.
  • fast/repaint/inline-vertical-lr-overflow.html: Added.
  • fast/repaint/inline-vertical-rl-overflow.html: Copied from fast/repaint/inline-vertical-rl-overflow.html.
  • platform/mac/fast/blockflow/background-vertical-lr-expected.txt:
  • platform/mac/fast/blockflow/background-vertical-rl-expected.txt:
  • platform/mac/fast/blockflow/basic-vertical-line-expected.txt:
  • platform/mac/fast/blockflow/border-image-vertical-lr-expected.txt:
  • platform/mac/fast/blockflow/border-image-vertical-rl-expected.txt:
  • platform/mac/fast/blockflow/border-radius-clipping-vertical-lr-expected.txt:
  • platform/mac/fast/blockflow/border-vertical-lr-expected.checksum:
  • platform/mac/fast/blockflow/border-vertical-lr-expected.png:
  • platform/mac/fast/blockflow/border-vertical-lr-expected.txt:
  • platform/mac/fast/blockflow/box-shadow-vertical-lr-expected.txt:
  • platform/mac/fast/blockflow/box-shadow-vertical-rl-expected.txt:
  • platform/mac/fast/blockflow/english-lr-text-expected.txt:
  • platform/mac/fast/blockflow/english-rl-text-expected.txt:
  • platform/mac/fast/blockflow/japanese-lr-text-expected.txt:
  • platform/mac/fast/blockflow/japanese-rl-text-expected.txt:
  • platform/mac/fast/repaint/inline-horizontal-bt-overflow-expected.checksum: Added.
  • platform/mac/fast/repaint/inline-horizontal-bt-overflow-expected.png: Added.
  • platform/mac/fast/repaint/inline-horizontal-bt-overflow-expected.txt: Added.
  • platform/mac/fast/repaint/inline-vertical-lr-overflow-expected.checksum: Added.
  • platform/mac/fast/repaint/inline-vertical-lr-overflow-expected.png: Added.
  • platform/mac/fast/repaint/inline-vertical-lr-overflow-expected.txt: Added.
  • platform/mac/fast/repaint/inline-vertical-rl-overflow-expected.checksum: Copied from platform/mac/fast/repaint/inline-vertical-rl-overflow-expected.checksum.
  • platform/mac/fast/repaint/inline-vertical-rl-overflow-expected.png: Copied from platform/mac/fast/repaint/inline-vertical-rl-overflow-expected.png.
11:53 Changeset [71042] by beidson@apple.com
  • 2 edits in trunk/WebKit2

Windows build fix.

  • UIProcess/win/WebView.cpp:
11:34 Changeset [71041] by beidson@apple.com
  • 50 edits
    8 adds in trunk

<rdar://problem/7660547> and https://bugs.webkit.org/show_bug.cgi?id=48699
Context menu support for WebKit 2.

Reviewed by Anders Carlsson.

WebCore:

Add a "showContextMenu" call to Chrome/ChromeClient:

  • loader/EmptyClients.h:

(WebCore::EmptyChromeClient::showContextMenu):

  • page/Chrome.cpp:

(WebCore::Chrome::showContextMenu):

  • page/Chrome.h:
  • page/ChromeClient.h:

Add a "platform description to ContextMenuItem" creator, will be needed by WebKit2

  • platform/ContextMenu.h:
  • platform/mac/ContextMenuMac.mm:

(WebCore::contextMenuItemVector):

  • platform/mac/ContextMenuItemMac.mm:

(WebCore::ContextMenuItem::checked): WebKit2 ports now need this implemented.

Stub these out to keep their WK2 ports building:

  • platform/qt/ContextMenuItemQt.cpp:

(WebCore::ContextMenuItem::checked):

  • platform/qt/ContextMenuQt.cpp:

(WebCore::contextMenuItemVector):

  • platform/win/ContextMenuItemWin.cpp:

(WebCore::ContextMenuItem::checked):

  • platform/win/ContextMenuWin.cpp:

(WebCore::contextMenuItemVector):

WebKit/chromium:

  • src/ChromeClientImpl.h:

(WebKit::ChromeClientImpl::showContextMenu):

WebKit/efl:

  • WebCoreSupport/ChromeClientEfl.h:

(WebCore::ChromeClientEfl::showContextMenu):

WebKit/gtk:

  • WebCoreSupport/ChromeClientGtk.h:

(WebKit::ChromeClient::showContextMenu):

WebKit/haiku:

  • WebCoreSupport/ChromeClientHaiku.h:

(WebCore::ChromeClientHaiku::showContextMenu):

WebKit/mac:

  • WebCoreSupport/WebChromeClient.h:

(WebChromeClient::showContextMenu):

WebKit/qt:

  • WebCoreSupport/ChromeClientQt.h:

(WebCore::ChromeClientQt::showContextMenu):

WebKit/win:

  • WebCoreSupport/WebChromeClient.h:

(WebChromeClient::showContextMenu):

WebKit/wx:

  • WebKitSupport/ChromeClientWx.h:

(WebCore::ChromeClientWx::showContextMenu):

WebKit2:

  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:
  • Shared/WebContextMenuItem.cpp: Added.

(WebKit::WebContextMenuItem::WebContextMenuItem):
(WebKit::WebContextMenuItem::encode):
(WebKit::WebContextMenuItem::decode):
(WebKit::kitItems):

  • Shared/WebContextMenuItem.h: Added.
  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::createContextMenuProxy):

  • UIProcess/API/qt/qwkpage.cpp:

(QWKPagePrivate::createContextMenuProxy): Stub to keep the build working.

  • UIProcess/API/qt/qwkpage_p.h:
  • UIProcess/PageClient.h:
  • UIProcess/WebContextMenuProxy.cpp: Added.

(WebKit::WebContextMenuProxy::~WebContextMenuProxy):
(WebKit::WebContextMenuProxy::WebContextMenuProxy):

  • UIProcess/WebContextMenuProxy.h: Added.
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::showContextMenu): Shows the menu after receiving the message from the WebProcess.
(WebKit::WebPageProxy::contextMenuItemSelected): Sends info about the selected menu item to the WebProcess

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/mac/WebContextMenuProxyMac.h: Added.

(WebKit::WebContextMenuProxyMac::create):

  • UIProcess/mac/WebContextMenuProxyMac.mm: Added.

(+[WebMenuTarget sharedMenuTarget]):
(-[WebMenuTarget WebKit::]):
(-[WebMenuTarget setMenuProxy:WebKit::]):
(-[WebMenuTarget forwardContextMenuAction:]):
(WebKit::WebContextMenuProxyMac::WebContextMenuProxyMac):
(WebKit::WebContextMenuProxyMac::~WebContextMenuProxyMac):
(WebKit::WebContextMenuProxyMac::contextMenuItemSelected):
(WebKit::populateNSMenu):
(WebKit::nsMenuItemVector):
(WebKit::WebContextMenuProxyMac::populate):
(WebKit::WebContextMenuProxyMac::showContextMenu):
(WebKit::WebContextMenuProxyMac::hideContextMenu):

  • UIProcess/win/WebView.cpp:

(WebKit::WebView::createContextMenuProxy): Stub for now.

  • UIProcess/win/WebView.h:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::showContextMenu):

  • WebProcess/WebCoreSupport/WebChromeClient.h:
  • WebProcess/WebCoreSupport/WebContextMenuClient.cpp:

(WebKit::WebContextMenuClient::getCustomMenuFromDefaultItems): Return the WebCore-provided default

menu for now. Embedding app customization will come later (see bug 48720)

  • WebProcess/WebPage/WebContextMenu.cpp: Added.

(WebKit::WebContextMenu::WebContextMenu):
(WebKit::WebContextMenu::~WebContextMenu):
(WebKit::WebContextMenu::show):
(WebKit::WebContextMenu::itemSelected):

  • WebProcess/WebPage/WebContextMenu.h: Added.

(WebKit::WebContextMenu::create):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::contextMenu):
(WebKit::handleMouseEvent): Pass right mouse presses along to WebCore as both a mouse event and context menu event,

the same way WebKit1 does.

(WebKit::WebPage::didSelectItemFromActiveContextMenu):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
11:30 Changeset [71040] by pfeldman@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-11-01 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: Chromium build fix.

  • src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::WebDevToolsAgentImpl):
11:18 Changeset [71039] by eric.carlson@apple.com
  • 13 edits
    2 adds in trunk

2010-11-01 Eric Carlson <eric.carlson@apple.com>

Reviewed by Adam Roben.

Seeking by very small increment doesn't generate 'seeked' event
https://bugs.webkit.org/show_bug.cgi?id=48530

Test: media/video-seek-by-small-increment.html

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::seek): Ask the media engine for its closest time value so we can avoid asking it to seek to the current time.
  • platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::mediaTimeForTimeValue): New.
  • platform/graphics/MediaPlayer.h:
  • platform/graphics/MediaPlayerPrivate.h: (WebCore::MediaPlayerPrivateInterface::mediaTimeForTimeValue): Ditto.
  • platform/graphics/mac/MediaPlayerPrivateQTKit.h:
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::mediaTimeForTimeValue): Return the closest value in the movie's time scale.
  • platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp: (WebCore::MediaPlayerPrivateQuickTimeVisualContext::mediaTimeForTimeValue): Ditto
  • platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.h:
  • platform/graphics/win/QTMovie.cpp: (QTMovie::timeScale): Return the movie's time scale.
  • platform/graphics/win/QTMovie.h:

2010-11-01 Eric Carlson <eric.carlson@apple.com>

Reviewed by Adam Roben.

Seeking by very small increment doesn't generate 'seeked' event
https://bugs.webkit.org/show_bug.cgi?id=48530

  • media/video-seek-by-small-increment-expected.txt: Added.
  • media/video-seek-by-small-increment.html: Added.
  • platform/qt/Skipped: Skip new test as it fails.
11:14 Changeset [71038] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2010-11-01 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: Chromium build fix. Adding missing transitive dependency.

  • inspector/InspectorResourceAgent.cpp:
11:09 Changeset [71037] by mihaip@chromium.org
  • 139 edits
    138 copies
    2 adds in trunk/LayoutTests

2010-11-01 Mihai Parparita <mihaip@chromium.org>

Update the pixel expectations for fast/block/margin-collapse for the Mac port.

For the tests that currently fail on Snow Leopard with --pixel-tests
--tolerance 0, this moves the current pixel results to mac-leopard and
adds new Snow Leopard-specific results to platform/mac.

List of files omitted due to length but composed entirely of moves from
platform/mac to platform/mac-leopard and newly added files in
platform/mac.

11:02 Changeset [71036] by pfeldman@chromium.org
  • 4 edits in trunk/WebCore

2010-11-01 Pavel Feldman <pfeldman@chromium.org>

Not reviewed. Removing references to removed file from project files.

  • WebCore.gypi:
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.css:
10:56 Changeset [71035] by pfeldman@chromium.org
  • 38 edits
    4 deletes in trunk

2010-11-01 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: remove old resources panel.
https://bugs.webkit.org/show_bug.cgi?id=45657

  • CMakeLists.txt:
  • English.lproj/localizedStrings.js:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSInjectedScriptHostCustom.cpp:
  • inspector/InjectedScriptHost.cpp:
  • inspector/Inspector.idl:
  • inspector/InspectorCSSStore.cpp:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::~InspectorController): (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::releaseFrontendLifetimeAgents): (WebCore::InspectorController::populateScriptObjects): (WebCore::InspectorController::unbindAllResources): (WebCore::InspectorController::didCommitLoad): (WebCore::InspectorController::frameDetachedFromParent): (WebCore::InspectorController::didLoadResourceFromMemoryCache): (WebCore::InspectorController::identifierForInitialRequest): (WebCore::InspectorController::willSendRequest): (WebCore::InspectorController::markResourceAsCached): (WebCore::InspectorController::didReceiveResponse): (WebCore::InspectorController::didReceiveContentLength): (WebCore::InspectorController::didFinishLoading): (WebCore::InspectorController::didFailLoading): (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest): (WebCore::InspectorController::scriptImported): (WebCore::InspectorController::didCreateWebSocket): (WebCore::InspectorController::willSendWebSocketHandshakeRequest): (WebCore::InspectorController::didReceiveWebSocketHandshakeResponse): (WebCore::InspectorController::didCloseWebSocket):
  • inspector/InspectorController.h:
  • inspector/InspectorFrontendHost.cpp:
  • inspector/InspectorResource.cpp: Removed.
  • inspector/InspectorResource.h: Removed.
  • inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::setOverrideContent):
  • inspector/InspectorResourceAgent.h:
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.addMessage): (WebInspector.ConsoleView.prototype.clearMessages):
  • inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer.prototype._onRevealAndSelectResource):
  • inspector/front-end/Images/resourcesSilhouette.png: Removed.
  • inspector/front-end/Resource.js:
  • inspector/front-end/ResourceManager.js: (WebInspector.ResourceManager.getContent):
  • inspector/front-end/ResourcesPanel.js: Removed.
  • inspector/front-end/Settings.js:
  • inspector/front-end/StoragePanel.js: (WebInspector.StoragePanel): (WebInspector.StoragePanel.prototype.get toolbarItemLabel):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js: (WebInspector._createPanels): (WebInspector.get networkResources): (WebInspector.forAllResources): (WebInspector.resourceForURL): (WebInspector.doLoadedDone.populateInspectorState): (WebInspector.openResource): (WebInspector.domContentEventFired): (WebInspector.loadEventFired): (WebInspector.reset): (WebInspector._choosePanelToShowSourceLine):

2010-11-01 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: remove old resources panel.
https://bugs.webkit.org/show_bug.cgi?id=45657

  • src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::setApuAgentEnabled):
  • src/WebDevToolsAgentImpl.h:

2010-11-01 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: remove old resources panel.
https://bugs.webkit.org/show_bug.cgi?id=45657

  • http/tests/inspector/inspector-test2.js:
  • http/tests/inspector/resource-har-conversion.html:
  • http/tests/inspector/resource-parameters.html:
  • inspector/audits-panel-functional.html:
  • inspector/extensions-test.js:
  • inspector/report-protocol-errors-expected.txt:
  • inspector/report-protocol-errors.html:
  • inspector/styles-source-offsets.html:
10:35 Changeset [71034] by zmo@google.com
  • 5 edits in trunk/WebCore

2010-10-28 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Fix enum naming style violation in GraphicsContext3D
https://bugs.webkit.org/show_bug.cgi?id=48441

  • platform/graphics/GraphicsContext3D.cpp: (WebCore::GraphicsContext3D::extractImageData): (WebCore::GraphicsContext3D::extractTextureData): (WebCore::doPacking): (WebCore::GraphicsContext3D::packPixels):
  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/cg/GraphicsContext3DCG.cpp: (WebCore::getSourceDataFormat): (WebCore::GraphicsContext3D::getImageData):
  • platform/graphics/skia/GraphicsContext3DSkia.cpp: (WebCore::GraphicsContext3D::getImageData):
09:51 Changeset [71033] by aroben@apple.com
  • 6 edits in trunk/WebKit2

Cancel main resource loads after we hand them off to the media engine

This is the WebKit2 equivalent of r51104. Clearly this code should be
moved to a cross-platform location someday.

Fixes <http://webkit.org/b/48561> <rdar://problem/8606679> Assertion
failure in DocumentLoader::commitData when loading a media document in
WebKit2

Reviewed by Eric Carlson.

  • WebProcess/WebCoreSupport/WebErrors.h: Added pluginWillHandleLoadError.
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebFrameLoaderClient::committedLoad): Cancel the main resource load
after handing off the load to the media engine. This code originally
came from -[WebHTMLRepresentation receivedData:withDataSource:].
(WebKit::WebFrameLoaderClient::pluginWillHandleLoadError): Call through to WebErrors.
(WebKit::WebFrameLoaderClient::shouldFallBack): Implemented. We fall
back for all errors except when the load was cancelled or we handed it
off to the media engine or a plugin.

  • WebProcess/WebCoreSupport/mac/WebErrorsMac.mm:

(WebKit::pluginWillHandleLoadError): Implemented.

  • WebProcess/WebCoreSupport/qt/WebErrorsQt.cpp:

(WebKit::pluginWillHandleLoadError): Stubbed out.

  • WebProcess/WebCoreSupport/win/WebErrorsWin.cpp:

(WebKit::pluginWillHandleLoadError): Implemented.

09:50 Changeset [71032] by aroben@apple.com
  • 3 edits in trunk/WebKit/win

Cancel main resource loads after we hand them off to the media engine

This is the Windows equivalent of r51104. Clearly this code should be
moved to a cross-platform location someday.

Fixes <http://webkit.org/b/48531> <rdar://problem/8606635> Assertion
failure in DocumentLoader::commitData when loading a media document in
WebKit1 on Windows

Reviewed by Dan Bernstein.

  • WebCoreSupport/WebFrameLoaderClient.cpp:

(WebFrameLoaderClient::committedLoad): Cancel the main resource load
after handing off the load to the media engine. This code originally
came from -[WebHTMLRepresentation receivedData:withDataSource:].

  • WebFrame.cpp:

(WebFrame::shouldFallBack): Don't fall back when handing the resource
load off to the media engine or a plugin. Added error domain checking
so that we don't rely on error codes being unique.

09:00 Changeset [71031] by mrobinson@webkit.org
  • 4 edits in trunk

2010-11-01 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Pasting markup into Thunderbird compose window produces no text
https://bugs.webkit.org/show_bug.cgi?id=43737

Include a content-type meta tag prefix on all clipboard markup. Programs like
Thunderbird expect this meta tag and will not paste anything unless it is there.

This is covered by changes to WebKit/gtk/tests/testcopyandpaste.c. This patch was
written in such a way as to not affect layout test results, otherwise there
would be many new GTK+-specific results that say "FAIL").

  • platform/gtk/PasteboardHelper.cpp: (WebCore::removeMarkupPrefix): Added this helper which removes the prefix when found on incoming clipboard and drag-and-drop text. (WebCore::PasteboardHelper::getClipboardContents): Remove the meta tag prefix. (WebCore::PasteboardHelper::fillSelectionData): Add the meta tag prefix. (WebCore::PasteboardHelper::fillDataObjectFromDropData): Remove the meta tag prefix

2010-11-01 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Pasting markup into Thunderbird compose window produces no text
https://bugs.webkit.org/show_bug.cgi?id=43737

Added a test verifying that the meta tag prefix on markup data exists.

  • tests/testcopyandpaste.c: (load_status_cb): Add a check for the meta tag prefix.
08:50 Changeset [71030] by commit-queue@webkit.org
  • 2 edits in trunk/WebKitTools

2010-11-01 Søren Gjesse <sgjesse@chromium.org>

Reviewed by Andreas Kling.

Fix warning when compiling the chromium port of DumpRenderShell
with clang.
https://bugs.webkit.org/show_bug.cgi?id=48414

  • DumpRenderTree/chromium/TestShell.h: (TestShell::javaScriptFlagsForLoad):
08:33 Changeset [71029] by andreas.kling@nokia.com
  • 3 edits in trunk/WebKit2

2010-11-01 Andreas Kling <kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt][WK2] Cleanup viewportAttributesForSize API

Change QSize argument to a const QSize&.

  • UIProcess/API/qt/qwkpage.cpp: (QWKPage::viewportAttributesForSize):
  • UIProcess/API/qt/qwkpage.h:
08:27 Changeset [71028] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed.

[Qt] DRT sideeffect revealed by r71004
https://bugs.webkit.org/show_bug.cgi?id=48758

  • platform/qt/Skipped: fast/dom/nodesFromRect-basic.html added until fix.
08:23 Changeset [71027] by jschuh@chromium.org
  • 3 edits
    2 adds in trunk

2010-11-01 Justin Schuh <jschuh@chromium.org>

Reviewed by Dirk Schulze.

Check for NULL node in SVGUseElement::associateInstancesWithShadowTreeElements loop
https://bugs.webkit.org/show_bug.cgi?id=48741

  • svg/custom/use-on-use-with-child-and-empty-target-expected.txt: Added.
  • svg/custom/use-on-use-with-child-and-empty-target.svg: Added.

2010-11-01 Justin Schuh <jschuh@chromium.org>

Reviewed by Dirk Schulze.

Check for NULL node in SVGUseElement::associateInstancesWithShadowTreeElements loop
https://bugs.webkit.org/show_bug.cgi?id=48741

Test: svg/custom/use-on-use-with-child-and-empty-target.svg

  • svg/SVGUseElement.cpp: (WebCore::SVGUseElement::associateInstancesWithShadowTreeElements):
08:11 BuildingOnWindows edited by aroben@apple.com
Added some more DLLs that need to be rebased (diff)
08:08 BuildingOnWindows edited by aroben@apple.com
Update instructions for rebasing libphp4.dll (diff)
08:05 Changeset [71026] by mario@webkit.org
  • 5 edits
    2 adds in trunk

2010-11-01 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Martin Robinson.

[Gtk] AtkHyperlink needs to be implemented
https://bugs.webkit.org/show_bug.cgi?id=33785

Implemented the AtkHyperlink/AtkHypertext stuff in the GTK port.

Even thought these kind of tasks are usually about implementing an
interface, in this case it was needed to implement some more
things due to the fact that AtkHyperlink is neither an interface
nor an AtkObject, but just an abstract class child of GObject that
needs to be redefined in a specific subclass of that one. On top
of that, it was needed to implement the AtkAction interface as
well for that new class, so exposed hyperlinks can work as
expected with Assistive Technologies based on ATK.

Furthermore, as there's no mechanism to get an instance of that
AtkHyperlink other than doing it through an AtkObject implementing
the AtkHypertext interface, it was needed to also add the code to
implement that one, so it makes possible to ask for the
'hyperlinks' under an 'hypertext' accessible object.

Finally, to complete the implementation of all this stuff and make
it all consistent, it was needed as well to implement the
AtkHyperlinkImpl interface (providing just one method only) so
that allows retrieving the AtkHyperlink object associated to an
AtkObject implementing such an interface.

  • GNUmakefile.am: Add the new WebKitAccessibleHyperlink.[h|cpp] files to the sources list for the GTK port.
  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (core): New function to return the core accessibility object related to an AtkObject implementing the AtkHypertext interface. (webkitAccessibleHypertextGetLink): New, part of the implementation of the AtkHypertext interface. (webkitAccessibleHypertextGetNLinks): New, likewise. (webkitAccessibleHypertextGetLinkIndex): New, likewise. (atkHypertextInterfaceInit): New, initialize the AtkHypertext interface. (webkitAccessibleHyperlinkImplGetHyperlink): New, part of the implementation of the AtkHyperlinkImpl interface. (atkHyperlinkImplInterfaceInit): New, initialize the AtkHyperlinkImpl interface. (GetAtkInterfaceTypeFromWAIType): Add ATK_TYPE_HYPERTEXT and ATK_TYPE_HYPERLINK_IMPL to the list of recognized types. (getInterfaceMaskFromObject): Decide when it's needed to add WAI_HYPERTEXT and WAI_HYPERLINK to the interface mask.
  • accessibility/gtk/WebKitAccessibleHyperlink.h: Added.
  • accessibility/gtk/WebKitAccessibleHyperlink.cpp: Added. (returnString): Return (const char*) from String variables. (core): Return the associated AccessibilityObject. (webkitAccessibleHyperlinkActionDoAction): Part of the implementation of the AtkAction interface. (webkitAccessibleHyperlinkActionGetNActions): Likewise. (webkitAccessibleHyperlinkActionGetDescription): Likewise. (webkitAccessibleHyperlinkActionGetKeybinding): Likewise. (webkitAccessibleHyperlinkActionGetName): Likewise. (atkActionInterfaceInit): Initialize the AtkAction interface. (getRangeLengthForObject): Returns the length for a given Range, considering special cases (e.g. List item markers). (webkitAccessibleHyperlinkGetURI): Implementation of one of the methods in the AtkHyperlink abstract class. (webkitAccessibleHyperlinkGetObject): Likewise. (webkitAccessibleHyperlinkGetStartIndex): Likewise. (webkitAccessibleHyperlinkGetEndIndex): Likewise. (webkitAccessibleHyperlinkIsValid): Likewise. (webkitAccessibleHyperlinkGetNAnchors): Likewise. (webkitAccessibleHyperlinkIsSelectedLink): Likewise. (webkitAccessibleHyperlinkGetProperty): Getter method. (webkitAccessibleHyperlinkSetProperty): Setter method. (webkitAccessibleHyperlinkFinalize): Finalize method. (webkitAccessibleHyperlinkClassInit): Initialize the WebKitAccessibleHyperlink class. (webkitAccessibleHyperlinkInit): Initialize the WebKitAccessibleHyperlink instance. (webkitAccessibleHyperlinkGetType): Implementation of the get_type() function for the WebKitAccessibleHyperlink class. (webkitAccessibleHyperlinkNew): Returns an instance of the class associated to a given AtkHyperlinkImpl object. (webkitAccessibleHyperlinkGetAccessibilityObject): Public function returning the AccessibilityObject associated to the instance of the WebKitAccessibleHyperlink class.

2010-11-01 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Martin Robinson.

[Gtk] AtkHyperlink needs to be implemented
https://bugs.webkit.org/show_bug.cgi?id=33785

New test to ensure the AtkHypertext/AtkHyperlink stuff works.

  • tests/testatk.c: (testWebkitAtkHypertextAndHyperlinks): New test, checking both the implementation of the AtkHypertext interface, the subclass of the AtkHyperlink abstract class, and the implementation of the AtkAction interface in that subclass. (main): Added the new unit test.
07:55 Changeset [71025] by aroben@apple.com
  • 2 edits in trunk/LayoutTests

Add two more failing tests to the WebKit2 Skipped file

  • platform/mac-wk2/Skipped:
07:38 Changeset [71024] by aroben@apple.com
  • 2 edits in trunk/LayoutTests

Add some failing/timing out tests to the Windows Skipped file

  • platform/win/Skipped:
07:32 Changeset [71023] by aroben@apple.com
  • 2 edits in trunk/WebKitTools

Fix typo from r71022

  • BuildSlaveSupport/build.webkit.org-config/config.json:
07:29 Changeset [71022] by aroben@apple.com
  • 2 edits in trunk/WebKitTools

Trigger the Windows Release WebKit2 tests when a Release build finishes, not when a Debug build finishes

Fixes <http://webkit.org/b/48754> Windows Release WebKit2 tests are
triggered at the wrong time

Reviewed by Sam Weinig.

  • BuildSlaveSupport/build.webkit.org-config/config.json: Fixed

triggerable name and trigger.

07:28 Changeset [71021] by jorlow@chromium.org
  • 2 edits in trunk/LayoutTests

2010-11-01 Jeremy Orlow <jorlow@chromium.org>

Remove test previous patch fixed.

  • platform/chromium/test_expectations.txt:
07:26 Changeset [71020] by jorlow@chromium.org
  • 3 edits in trunk/LayoutTests

2010-11-01 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Steve Block.

Fix IndexedDB layout test
https://bugs.webkit.org/show_bug.cgi?id=48644

This test needs to be async. Also clean up a few other things like
using a logger div rather than document.write.

  • storage/indexeddb/tutorial-expected.txt:
  • storage/indexeddb/tutorial.html:
05:56 Changeset [71019] by satish@chromium.org
  • 6 edits in trunk

2010-11-01 Leandro Gracia Gil <leandrogracia@google.com>

Reviewed by Jeremy Orlow.

This is the last part of a 4-sided patch for the language attribute
in speech text buttons. This patch removes what now is dead code
and re-enables the layout test introduced by bug 47089.
https://bugs.webkit.org/show_bug.cgi?id=47420

  • platform/chromium/test_expectations.txt:

2010-11-01 Leandro Gracia Gil <leandrogracia@google.com>

Reviewed by Jeremy Orlow.

This is the last part of a 4-sided patch for the language attribute
in speech text buttons. This patch removes what now is dead code
and re-enables the layout test introduced by bug 47089.
https://bugs.webkit.org/show_bug.cgi?id=47420

  • public/WebSpeechInputControllerMock.h:
  • src/WebSpeechInputControllerMockImpl.cpp:
  • src/WebSpeechInputControllerMockImpl.h:
05:21 WinCE edited by paroga@webkit.org
(diff)
04:28 Changeset [71018] by mario@webkit.org
  • 2 edits in trunk/WebKitTools

2010-11-01 Mario Sanchez Prada <msanchez@igalia.com>

Unreviewed. Adding my IRC nickname to the list of committers.

  • Scripts/webkitpy/common/config/committers.py:
04:09 Changeset [71017] by pfeldman@chromium.org
  • 6 edits in trunk

2010-11-01 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: simplify inspector styles test to make all bots happy.
(drive-by fix for overriden inspector styles in network panel).

  • inspector/InspectorController.h:
  • inspector/front-end/networkPanel.css:

2010-11-01 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: simplify styles test to make all bots happy.

  • inspector/styles-source-lines-inline-expected.txt:
  • inspector/styles-source-lines-inline.html:
03:25 Changeset [71016] by pfeldman@chromium.org
  • 3 edits in trunk

2010-11-01 Pavel Feldman <pfeldman@chromium.org>

Not reviewed. Updating inspector test expectation as a follow up to r71010.

  • inspector/styles-source-lines-inline-expected.txt:
02:12 Changeset [71015] by zimmermann@webkit.org
  • 12 edits in trunk/LayoutTests

2010-11-01 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed.

Enable StrictTypeChecking for all types using SVG(Animated)PropertyTearOff
https://bugs.webkit.org/show_bug.cgi?id=48715

Forgot to land some changes in my previous commit.

  • svg/dynamic-updates/script-tests/SVGCircleElement-svgdom-cx-prop.js:
  • svg/dynamic-updates/script-tests/SVGCircleElement-svgdom-cy-prop.js:
  • svg/dynamic-updates/script-tests/SVGCircleElement-svgdom-r-prop.js:
  • svg/dynamic-updates/script-tests/SVGEllipseElement-svgdom-cx-prop.js:
  • svg/dynamic-updates/script-tests/SVGEllipseElement-svgdom-cy-prop.js:
  • svg/dynamic-updates/script-tests/SVGEllipseElement-svgdom-rx-prop.js:
  • svg/dynamic-updates/script-tests/SVGEllipseElement-svgdom-ry-prop.js:
  • svg/dynamic-updates/script-tests/SVGForeignObjectElement-svgdom-height-prop.js:
  • svg/dynamic-updates/script-tests/SVGForeignObjectElement-svgdom-width-prop.js:
  • svg/dynamic-updates/script-tests/SVGForeignObjectElement-svgdom-x-prop.js:
  • svg/dynamic-updates/script-tests/SVGForeignObjectElement-svgdom-y-prop.js:
01:57 Changeset [71014] by zimmermann@webkit.org
  • 18 edits
    3 moves
    27 adds
    2 deletes in trunk

2010-10-31 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Rob Buis.

Enable StrictTypeChecking for all types using SVG(Animated)PropertyTearOff
https://bugs.webkit.org/show_bug.cgi?id=48715

Enable StrictTypeChecking for all readwrite attributes and function calls of all types using the new SVG(Animated)PropertyTearOff concept.
Also enable RequiresAllArguments=Raise for all function calls of these new types. Cover this functionality by tests for each of them.

When testing SVGLength it became obvious that quite a lot of functionality was missing.
Conversion from relative arguments (percentage, ems, exs) to user specified units was missing, added that functionality and tested it.
User units to pt conversion was wrong, fixed that.

Tests: svg/dom/SVGAnimatedAngle.html

svg/dom/SVGAnimatedBoolean.html
svg/dom/SVGAnimatedEnumeration.html
svg/dom/SVGAnimatedInteger.html
svg/dom/SVGAnimatedLength.html
svg/dom/SVGAnimatedLengthList.html
svg/dom/SVGAnimatedRect.html
svg/dom/SVGLength-px-with-context.html
svg/dom/SVGLength-px.html
svg/dom/SVGLength.html

  • bindings/js/JSSVGLengthCustom.cpp: These SVGLength methods now take an ExceptionCode parameter, adapt to that. (WebCore::JSSVGLength::value): (WebCore::JSSVGLength::setValue): (WebCore::JSSVGLength::convertToSpecifiedUnits):
  • bindings/scripts/CodeGeneratorObjC.pm: Remove FIXMEs, pass real context instead off null pointer. DOMSVGLength::value is functional now.
  • bindings/v8/custom/V8SVGLengthCustom.cpp: These SVGLength methods now take an ExceptionCode parameter, adapt to that. (WebCore::V8SVGLength::valueAccessorGetter): (WebCore::V8SVGLength::valueAccessorSetter): (WebCore::V8SVGLength::convertToSpecifiedUnitsCallback):
  • rendering/style/SVGRenderStyle.h: Adapt to SVGLength API changes. (WebCore::SVGRenderStyle::initialBaselineShiftValue): (WebCore::SVGRenderStyle::initialKerning): (WebCore::SVGRenderStyle::initialStrokeDashOffset): (WebCore::SVGRenderStyle::initialStrokeWidth):
  • svg/SVGAngle.idl: Add StrictTypeChecking, RequiresAllArguments=Raise to all methods.
  • svg/SVGAnimatedBoolean.idl: Remove StrictTypeChecking from animVal, it's readonly so this is useless.
  • svg/SVGAnimatedEnumeration.idl: Add StrictTypeChecking to all attributes.
  • svg/SVGAnimatedInteger.idl: Ditto.
  • svg/SVGLength.cpp: Implement all missing features of SVGLength. Conform to our style guide (s/.0f etc) (WebCore::lengthTypeToString): (WebCore::SVGLength::SVGLength): (WebCore::SVGLength::value): Throw NOT_SUPPORTED_ERR when trying to obtain to relative units, when no context is given (SVGLength created by createSVGLength()). (WebCore::SVGLength::setValue): Ditto, for the setter. (WebCore::SVGLength::valueAsPercentage): Use m_valueInSpecifiedUnits instead of valueInSpecifiedUnits(). (WebCore::SVGLength::setValueAsString): Throw SYNTAX_ERR if parsing failed. (WebCore::SVGLength::valueAsString): Use makeString() instead of String and operator+. (WebCore::SVGLength::newValueSpecifiedUnits): Add ExceptionCode parameter, throw NOT_SUPPORTED_ERR, if the given unit type is invalid. (WebCore::SVGLength::convertToSpecifiedUnits): Ditto. (WebCore::SVGLength::determineViewport): Added helper function used by convertValue*Percentage*. (WebCore::SVGLength::convertValueFromUserUnitsToPercentage): Add new helper functions, used by value/setValue. (WebCore::SVGLength::convertValueFromPercentageToUserUnits): Ditto. (WebCore::SVGLength::convertValueFromUserUnitsToEMS): Ditto. (WebCore::SVGLength::convertValueFromEMSToUserUnits): Ditto. (WebCore::SVGLength::convertValueFromUserUnitsToEXS): Ditto. (WebCore::SVGLength::convertValueFromEXSToUserUnits): Ditto. (WebCore::SVGLength::fromCSSPrimitiveValue): Adapt to newValueSpecifiedUnits API change. (WebCore::SVGLength::toCSSPrimitiveValue): Remove default switch case.
  • svg/SVGLength.h: (WebCore::SVGLength::valueInSpecifiedUnits): Inlined. (WebCore::SVGLength::setValueInSpecifiedUnits): Ditto. (WebCore::SVGLength::isRelative):
  • svg/SVGLength.idl: Add StrictTypeChecking for all attributes/functions and RequiresAllArguments=Raise for all functions.
  • svg/SVGLengthList.cpp: Adapt to SVGLength API changes. (WebCore::SVGLengthList::parse):

2010-10-31 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Rob Buis.

Enable StrictTypeChecking for all types using SVG(Animated)PropertyTearOff
https://bugs.webkit.org/show_bug.cgi?id=48715

  • svg/dom/SVGAngle-expected.txt:
  • svg/dom/SVGAnimatedAngle-expected.txt: Added.
  • svg/dom/SVGAnimatedAngle.html: Added.
  • svg/dom/SVGAnimatedBoolean-expected.txt: Copied from LayoutTests/svg/dom/SVGExternalResourcesRequired-expected.txt.
  • svg/dom/SVGAnimatedBoolean.html: Copied from LayoutTests/svg/dom/SVGExternalResourcesRequired.html.
  • svg/dom/SVGAnimatedEnumeration-expected.txt: Added.
  • svg/dom/SVGAnimatedEnumeration.html: Added.
  • svg/dom/SVGAnimatedInteger-expected.txt: Added.
  • svg/dom/SVGAnimatedInteger.html: Added.
  • svg/dom/SVGAnimatedLength-expected.txt: Added.
  • svg/dom/SVGAnimatedLength.html: Added.
  • svg/dom/SVGAnimatedLengthList-expected.txt: Added.
  • svg/dom/SVGAnimatedLengthList.html: Added.
  • svg/dom/SVGAnimatedRect-expected.txt: Added.
  • svg/dom/SVGAnimatedRect.html: Added.
  • svg/dom/SVGExternalResourcesRequired-expected.txt: Removed.
  • svg/dom/SVGExternalResourcesRequired.html: Removed.
  • svg/dom/SVGLength-expected.txt: Added.
  • svg/dom/SVGLength-px-expected.txt: Added.
  • svg/dom/SVGLength-px-with-context-expected.txt: Added.
  • svg/dom/SVGLength-px-with-context.html: Added.
  • svg/dom/SVGLength-px.html: Added.
  • svg/dom/SVGLength.html: Added.
  • svg/dom/script-tests/SVGAngle.js:
  • svg/dom/script-tests/SVGAnimatedAngle.js: Added.
  • svg/dom/script-tests/SVGAnimatedBoolean.js: Copied from LayoutTests/svg/dom/script-tests/SVGExternalResourcesRequired.js.
  • svg/dom/script-tests/SVGAnimatedEnumeration.js: Added.
  • svg/dom/script-tests/SVGAnimatedInteger.js: Added.
  • svg/dom/script-tests/SVGAnimatedLength.js: Added.
  • svg/dom/script-tests/SVGAnimatedLengthList.js: Added.
  • svg/dom/script-tests/SVGAnimatedRect.js: Added.
  • svg/dom/script-tests/SVGExternalResourcesRequired.js: Removed.
  • svg/dom/script-tests/SVGLength-px-with-context.js: Added. Tests various operations on a SVGLength object obtained via rectElement.x.baseVal.
  • svg/dom/script-tests/SVGLength-px.js: Added. Tests various operations on a SVGLength object created via svgElement.createSVGLength().
  • svg/dom/script-tests/SVGLength.js: Added.
  • svg/dom/svg-length-units-expected.txt: Removed.
  • svg/dom/svg-length-units.html: Removed. Test is obsolete now, as SVGLength* covers this in detail.
  • svg/dynamic-updates/script-tests/SVGCircleElement-svgdom-cx-prop.js: (executeTest): Fixed StrictTypeChecking correctness, don't assign strings as SVGLength value.
  • svg/dynamic-updates/script-tests/SVGCircleElement-svgdom-cy-prop.js: (executeTest): Ditto.
  • svg/dynamic-updates/script-tests/SVGCircleElement-svgdom-r-prop.js: (executeTest): Ditto.
  • svg/dynamic-updates/script-tests/SVGEllipseElement-svgdom-cx-prop.js: (executeTest): Ditto.
  • svg/dynamic-updates/script-tests/SVGEllipseElement-svgdom-cy-prop.js: (executeTest): Ditto.
  • svg/dynamic-updates/script-tests/SVGEllipseElement-svgdom-rx-prop.js: (executeTest): Ditto.
  • svg/dynamic-updates/script-tests/SVGEllipseElement-svgdom-ry-prop.js: (executeTest): Ditto.
  • svg/dynamic-updates/script-tests/SVGForeignObjectElement-svgdom-height-prop.js: (executeTest): Ditto.
  • svg/dynamic-updates/script-tests/SVGForeignObjectElement-svgdom-width-prop.js: (executeTest): Ditto.
  • svg/dynamic-updates/script-tests/SVGForeignObjectElement-svgdom-x-prop.js: (executeTest): Ditto.
  • svg/dynamic-updates/script-tests/SVGForeignObjectElement-svgdom-y-prop.js: (executeTest): Ditto.
00:57 Changeset [71013] by rolandsteiner@chromium.org
  • 2 edits in trunk/LayoutTests

2010-10-31 Roland Steiner <rolandsteiner@chromium.org>

Unreviewed: add failing SVG tests to Chromium test_expectations.txt.

WebKit roll 70949:71000 caused failures within 4 SVG tests on all platforms.
Bot and server outages make analysis difficult, thus adding to
Chromium test_expectations.txt for the time being.

  • platform/chromium/test_expectations.txt:
00:30 Changeset [71012] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

2010-11-01 Pavel Feldman <pfeldman@chromium.org>

Not reviewed. Fixing test expectation for r71010.

  • inspector/console-log-syntax-error-expected.txt:
00:19 Changeset [71011] by commit-queue@webkit.org
  • 5 edits in trunk/LayoutTests

2010-11-01 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r71002.
http://trac.webkit.org/changeset/71002
https://bugs.webkit.org/show_bug.cgi?id=48743

Makes Leopard and GTK bots red. (Requested by pfeldman on
#webkit).

  • platform/chromium-gpu/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/mac-leopard/Skipped:
  • platform/qt/Skipped:
00:07 Changeset [71010] by pfeldman@chromium.org
  • 16 edits in trunk

2010-10-31 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: unhide new network and resources panels.
https://bugs.webkit.org/show_bug.cgi?id=48725

  • English.lproj/localizedStrings.js:
  • inspector/InspectorController.h:
  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel):
  • inspector/front-end/Settings.js:
  • inspector/front-end/StoragePanel.js: (WebInspector.StoragePanel): (WebInspector.StoragePanel.prototype.reset): (WebInspector.StoragePanel.prototype.addResourceToFrame): (WebInspector.StoragePanel.prototype.addDocumentURL): (WebInspector.StoragePanel.prototype.showFileSystem): (WebInspector.FileSystemTreeElement): (WebInspector.FileSystemTreeElement.prototype.get itemURL): (WebInspector.FileSystemTreeElement.prototype.onselect):
  • inspector/front-end/inspector.js: (WebInspector.updateResource):
  • inspector/front-end/networkPanel.css: (#network-close-button): (.network.panel.viewing-resource #network-close-button):

2010-10-31 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: unhide new network and resources panels.
https://bugs.webkit.org/show_bug.cgi?id=48725

  • http/tests/inspector/console-xhr-logging-expected.txt:
  • http/tests/inspector/resource-parameters-expected.txt:
  • inspector/console-log-syntax-error-expected.txt:
  • inspector/elements-panel-styles-expected.txt:

2010-10-31 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: unhide new network and resources panels.
https://bugs.webkit.org/show_bug.cgi?id=48725

  • src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::setApuAgentEnabled):

10/31/10:

23:35 Changeset [71009] by morrita@google.com
  • 10 edits
    2 adds in trunk/WebCore

2010-10-26 MORITA Hajime <morrita@google.com>

Reviewed by Kent Tamura.

Refactoring: Spellchecking related static functions could form a class
https://bugs.webkit.org/show_bug.cgi?id=48287

Extracted spellcheck related static functions to TextCheckingHelper class,
which has EditorClient and Range as its member.

No new tests. Just a refactoring.

  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • editing/EditingAllInOne.cpp
  • editing/Editor.cpp: (WebCore::Editor::advanceToNextMisspelling): (WebCore::Editor::isSelectionUngrammatical): (WebCore::Editor::guessesForUngrammaticalSelection): (WebCore::Editor::guessesForMisspelledOrUngrammaticalSelection): (WebCore::Editor::markMisspellingsAfterTypingToPosition): (WebCore::Editor::markMisspellingsOrBadGrammar): (WebCore::Editor::markMisspellings): (WebCore::Editor::markBadGrammar): (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): (WebCore::Editor::changeBackToReplacedString):
  • editing/Editor.h:
  • editing/TextCheckingHelper.cpp: Added. (WebCore::TextCheckingHelper::TextCheckingHelper): (WebCore::TextCheckingHelper::~TextCheckingHelper): (WebCore::TextCheckingHelper::paragraphAlignedRange): (WebCore::TextCheckingHelper::findFirstMisspelling): (WebCore::TextCheckingHelper::findFirstMisspellingOrBadGrammar): (WebCore::TextCheckingHelper::findFirstGrammarDetail): (WebCore::TextCheckingHelper::findFirstBadGrammar): (WebCore::TextCheckingHelper::isUngrammatical): (WebCore::TextCheckingHelper::guessesForMisspelledOrUngrammaticalRange): (WebCore::TextCheckingHelper::markAllMisspellings): (WebCore::TextCheckingHelper::markAllBadGrammar):
  • editing/TextCheckingHelper.h: Added.
21:21 Changeset [71008] by xan@webkit.org
  • 2 edits in trunk/WebCore

2010-10-31 Xan Lopez <xlopez@igalia.com>

Try to fix the GTK+ build.

Do not use broken/deprecated functions that won't be available
with G_DISABLE_DEPRECATED (used in debug builds).

  • plugins/gtk/PluginPackageGtk.cpp: (WebCore::PluginPackage::fetchInfo):
19:54 Changeset [71007] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-10-31 Kenichi Ishibashi <bashi@google.com>

Reviewed by Adam Barth.

V8 binding for DOMSettableTokenList
https://bugs.webkit.org/show_bug.cgi?id=47812

Tests for this change will be included in the change for supporting
the <output> element.
See https://bugs.webkit.org/show_bug.cgi?id=29363.

  • bindings/v8/custom/V8DOMSettableTokenListCustom.cpp: Implemented. (WebCore::V8DOMSettableTokenList::indexedPropertyGetter): Just calls DOMSettableTokenList::item(index).
19:48 Changeset [71006] by robert@webkit.org
  • 5 edits in trunk

2010-10-31 Robert Hogan <robert@webkit.org>

Reviewed by Antonio Gomes.

[Qt] [Gtk] Plug-ins having upper case in mime type are failing to load

Qt and Gtk are case-sensitive when storing the declared mime-type
of plugins. Since plugin mime-types are lowercased prior to searching
for them in the plugin database, ensure they are loaded with the
mime-type in lower case too.

https://bugs.webkit.org/show_bug.cgi?id=36815

  • plugins/gtk/PluginPackageGtk.cpp: (WebCore::PluginPackage::fetchInfo):
  • plugins/qt/PluginPackageQt.cpp: (WebCore::PluginPackage::setMIMEDescription):

2010-10-31 Robert Hogan <robert@webkit.org>

Reviewed by Antonio Gomes.

[Qt] [Gtk] Plug-ins having upper case in mime type are failing to load

Qt and Gtk are case-sensitive when storing the declared mime-type
of plugins. Since plugin mime-types are lowercased prior to searching
for them in the plugin database, ensure they are loaded with the
mime-type in lower case too.

Change the test netscape plugin to declare its mimetype in sentence
case so that the correct behaviour is enforced.

https://bugs.webkit.org/show_bug.cgi?id=36815

  • DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: (NP_GetMIMEDescription):
19:37 Changeset [71005] by jeremy@chromium.org
  • 1 edit
    4 adds in trunk/LayoutTests

2010-10-31 Jeremy Moskovich <jeremy@chromium.org>

Reviewed by Ojan Vafai.

https://bugs.webkit.org/show_bug.cgi?id=24118

Add layout test to make sure we don't regress truncation of an rtl block.

  • fast/block/basic/truncation-rtl.html: Added.
  • platform/mac/fast/block/basic/truncation-rtl-expected.checksum: Added.
  • platform/mac/fast/block/basic/truncation-rtl-expected.png: Added.
  • platform/mac/fast/block/basic/truncation-rtl-expected.txt: Added.
19:30 Changeset [71004] by robert@webkit.org
  • 10 edits in trunk

2010-10-31 Robert Hogan <robert@webkit.org>

Reviewed by Antonio Gomes.

[Qt] Support nodesFromRect in DRT

Unskip fast/dom/nodesFromRect-basic.html

https://bugs.webkit.org/show_bug.cgi?id=48716

  • platform/qt/Skipped:

2010-10-31 Robert Hogan <robert@webkit.org>

Reviewed by Antonio Gomes.

[Qt] Support nodesFromRect in DRT

Pass a Document object as a QWebElement.

https://bugs.webkit.org/show_bug.cgi?id=48716

  • bridge/qt/qt_runtime.cpp: (JSC::Bindings::convertValueToQVariant):

2010-10-31 Robert Hogan <robert@webkit.org>

Reviewed by Antonio Gomes.

[Qt] Support nodesFromRect in DRT

https://bugs.webkit.org/show_bug.cgi?id=48716

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::nodesFromRect):
  • WebCoreSupport/DumpRenderTreeSupportQt.h:

2010-10-31 Robert Hogan <robert@webkit.org>

Reviewed by Antonio Gomes.

[Qt] Support nodesFromRect in DRT

https://bugs.webkit.org/show_bug.cgi?id=48716

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::nodesFromRect):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
19:20 Changeset [71003] by yael.aharon@nokia.com
  • 2 edits in trunk/LayoutTests

2010-10-31 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Antonio Gomes.

[GTK] Add bug ID for skipped <meter> tests
https://bugs.webkit.org/show_bug.cgi?id=48714

  • platform/gtk/Skipped:
19:17 Changeset [71002] by commit-queue@webkit.org
  • 5 edits in trunk/LayoutTests

2010-10-31 Mike Lawther <mikelawther@chromium.org>

Reviewed by Andreas Kling.

unskip canvas/philip/tests/2d.imageData.get.source.negative on all ports
https://bugs.webkit.org/show_bug.cgi?id=48702

  • platform/chromium-gpu/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/mac-leopard/Skipped:
  • platform/qt/Skipped:
19:04 Changeset [71001] by commit-queue@webkit.org
  • 3 edits
    6 adds in trunk

2010-10-31 Peter Kasting <pkasting@google.com>

Reviewed by Adam Barth.

Treat GIFs with no loop count as "loop once".
https://bugs.webkit.org/show_bug.cgi?id=47302

  • fast/images/gif-loop-count-expected.checksum: Added.
  • fast/images/gif-loop-count-expected.png: Added.
  • fast/images/gif-loop-count-expected.txt: Added.
  • fast/images/gif-loop-count.html: Added.
  • fast/images/resources/gif-loop-count.gif: Added.
  • fast/images/resources/gif-loop-count.png: Added.

2010-10-31 Peter Kasting <pkasting@google.com>

Reviewed by Adam Barth.

Treat GIFs with no loop count as "loop once".
https://bugs.webkit.org/show_bug.cgi?id=47302

Test: fast/images/gif-loop-count.html

  • platform/image-decoders/gif/GIFImageDecoder.cpp: (WebCore::GIFImageDecoder::repetitionCount): (WebCore::GIFImageDecoder::gifComplete):
18:39 Changeset [71000] by noam.rosenthal@nokia.com
  • 2 edits in trunk/WebCore

2010-10-31 No'am Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Andreas Kling.

[Texmap] [Qt] Texture mapper initial implementation
https://bugs.webkit.org/show_bug.cgi?id=47070

Build fix for X11.

No new tests; build fix.

  • plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::invalidateRect): (WebCore::PluginView::platformStart):
13:42 Changeset [70999] by andreas.kling@nokia.com
  • 2 edits in trunk/WebKit/qt

2010-10-31 Andreas Kling <kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Short-circuit QWebPage::selectedText() if frame has no selection
https://bugs.webkit.org/show_bug.cgi?id=48736

Do an early return if the selection is empty.

No new tests, this is covered by tst_QWebPage::findText().

  • Api/qwebpage.cpp: (QWebPage::selectedText):
13:33 Changeset [70998] by andreas.kling@nokia.com
  • 2 edits
    1 add in trunk/LayoutTests

2010-10-31 James Simonsen <simonjam@chromium.org>

Reviewed by Andreas Kling.

Rebaseline a fast/dynamic LayoutTest for Chromium Linux

fast/dynamic/positioned-movement-with-positioned-children.html exposes
a change to the defult button style on Linux.

Prior to bug 26030, buttons were always drawn as #dddddd, regardless of
what the style said. The default style had been #c0c0c0. With the fix,
buttons now honor the style sheet, but in order to maintain
consistency, the default style for Linux was changed to #dddddd.

This patch updates the test to reflect the newer Linux button style.

https://bugs.webkit.org/show_bug.cgi?id=48460

  • platform/chromium-linux/fast/dynamic/positioned-movement-with-positioned-children-expected.txt: Added.
  • platform/chromium/test_expectations.txt: Removed rebaselined test.
13:20 Changeset [70997] by darin@apple.com
  • 4 edits in trunk/WebKit2

2010-10-31 Darin Adler <darin@apple.com>

Reviewed by Dan Bernstein.

Visited links not populated correctly in new web processes after the first
https://bugs.webkit.org/show_bug.cgi?id=48735
rdar://problem/8442177

  • UIProcess/VisitedLinkProvider.cpp: (WebKit::VisitedLinkProvider::VisitedLinkProvider): Initialize m_webProcessHasVisitedLinkState. (WebKit::VisitedLinkProvider::processDidFinishLaunching): Renamed from populateVisitedLinksIfNeeded. Set m_webProcessHasVisitedLinkState to false, since this is a new process, and also start the timer so the visited links messages will be sent. (WebKit::VisitedLinkProvider::processDidClose): Renamed from stopVisitedLinksTimer. (WebKit::VisitedLinkProvider::pendingVisitedLinksTimerFired): Added logic so we send SetVisitedLinkTable and AllVisitedLinkStateChanged once to each new process and to set m_webProcessHasVisitedLinkState to true once that is done.
  • UIProcess/VisitedLinkProvider.h: Updated for above changes.
  • UIProcess/WebContext.cpp: (WebKit::WebContext::processDidFinishLaunching): Called VisitedLinkProvider function under its new name. Also used ASSERT_UNUSED rather than ASSERT since the argument is used only for the assertion. (WebKit::WebContext::processDidClose): Ditto.
12:32 Changeset [70996] by andreas.kling@nokia.com
  • 10 edits in trunk/WebCore

2010-10-31 Andreas Kling <kling@webkit.org>

Reviewed by Dirk Schulze.

Remove the unused GraphicsContext::clipOutEllipseInRect(IntRect)
https://bugs.webkit.org/show_bug.cgi?id=48727

This function was added in <http://trac.webkit.org/changeset/18654> for CSS3 box-shadows.
All use of the function was removed in <http://trac.webkit.org/changeset/21601>

  • platform/graphics/GraphicsContext.h:
  • platform/graphics/cairo/GraphicsContextCairo.cpp:
  • platform/graphics/cg/GraphicsContextCG.cpp:
  • platform/graphics/haiku/GraphicsContextHaiku.cpp: (WebCore::GraphicsContext::clipOut):
  • platform/graphics/openvg/GraphicsContextOpenVG.cpp:
  • platform/graphics/qt/GraphicsContextQt.cpp:
  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::clipOut):
  • platform/graphics/wince/GraphicsContextWinCE.cpp:
  • platform/graphics/wx/GraphicsContextWx.cpp:
12:30 Changeset [70995] by andreas.kling@nokia.com
  • 2 edits in trunk/WebCore

2010-10-31 Andreas Kling <kling@webkit.org>

Reviewed by Dirk Schulze.

[Qt] Respect the "antialiased" argument in clipConvexPolygon()
https://bugs.webkit.org/show_bug.cgi?id=48734

Set (or unset) the QPainter::Antialiased render hint for antialiased
clipping based on the "antialiased" argument.

No test since Qt doesn't have pixel tests yet.

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::clipConvexPolygon):
12:02 Changeset [70994] by andreas.kling@nokia.com
  • 3 edits in trunk/WebCore

2010-10-31 Andreas Kling <kling@webkit.org>

Reviewed by Dirk Schulze.

Remove the unused GraphicsContext::strokeRect(FloatRect)
https://bugs.webkit.org/show_bug.cgi?id=48726

This function was only implemented by GraphicsContextOpenVG and not
called from anywhere.

  • platform/graphics/GraphicsContext.h:
  • platform/graphics/openvg/GraphicsContextOpenVG.cpp:
11:59 Changeset [70993] by andreas.kling@nokia.com
  • 7 edits in trunk/WebCore

2010-10-31 Andreas Kling <kling@webkit.org>

Reviewed by Dirk Schulze.

Remove the unused GraphicsContext::origin()
https://bugs.webkit.org/show_bug.cgi?id=48732

This method was not called from anywhere.

  • platform/graphics/GraphicsContext.h:
  • platform/graphics/cairo/GraphicsContextCairo.cpp:
  • platform/graphics/haiku/GraphicsContextHaiku.cpp:
  • platform/graphics/openvg/GraphicsContextOpenVG.cpp:
  • platform/graphics/qt/GraphicsContextQt.cpp:
  • platform/graphics/wince/GraphicsContextWinCE.cpp:
11:57 Changeset [70992] by andreas.kling@nokia.com
  • 4 edits in trunk/WebCore

2010-10-31 Andreas Kling <kling@webkit.org>

Reviewed by Dirk Schulze.

[Qt] Remove GraphicsContext::pen()
https://bugs.webkit.org/show_bug.cgi?id=48733

Have PathQt obtain the pen() through the platformContext() instead.

  • platform/graphics/GraphicsContext.h:
  • platform/graphics/qt/GraphicsContextQt.cpp:
  • platform/graphics/qt/PathQt.cpp: (WebCore::Path::strokeContains): (WebCore::Path::strokeBoundingRect):
10:33 Changeset [70991] by ossy@webkit.org
  • 25 edits
    4 deletes in trunk

2010-10-31 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r70959.
http://trac.webkit.org/changeset/70959
https://bugs.webkit.org/show_bug.cgi?id=48731

It broke fast/events/spatial-navigation tests (Requested by
Ossy on #webkit).

  • WebCore.xcodeproj/project.pbxproj:
  • rendering/InlineBox.cpp: (WebCore::InlineBox::adjustForFlippedBlocksWritingMode):
  • rendering/InlineFlowBox.h: (WebCore::InlineFlowBox::bottomLayoutOverflow): (WebCore::InlineFlowBox::rightLayoutOverflow): (WebCore::InlineFlowBox::bottomVisualOverflow): (WebCore::InlineFlowBox::rightVisualOverflow):
  • rendering/RenderBox.cpp:
  • rendering/RenderBox.h:
  • rendering/RenderInline.cpp: (WebCore::RenderInline::linesBoundingBox): (WebCore::RenderInline::linesVisibleOverflowBoundingBox): (WebCore::RenderInline::clippedOverflowRectForRepaint):
  • rendering/RenderText.cpp: (WebCore::RenderText::linesBoundingBox):

2010-10-31 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r70959.
http://trac.webkit.org/changeset/70959
https://bugs.webkit.org/show_bug.cgi?id=48731

It broke fast/events/spatial-navigation tests (Requested by
Ossy on #webkit).

  • fast/repaint/inline-vertical-rl-overflow.html: Removed.
  • platform/mac/fast/blockflow/background-vertical-lr-expected.txt:
  • platform/mac/fast/blockflow/background-vertical-rl-expected.txt:
  • platform/mac/fast/blockflow/basic-vertical-line-expected.txt:
  • platform/mac/fast/blockflow/border-image-vertical-lr-expected.txt:
  • platform/mac/fast/blockflow/border-image-vertical-rl-expected.txt:
  • platform/mac/fast/blockflow/border-radius-clipping-vertical-lr-expected.txt:
  • platform/mac/fast/blockflow/border-vertical-lr-expected.checksum:
  • platform/mac/fast/blockflow/border-vertical-lr-expected.png:
  • platform/mac/fast/blockflow/border-vertical-lr-expected.txt:
  • platform/mac/fast/blockflow/box-shadow-vertical-lr-expected.txt:
  • platform/mac/fast/blockflow/box-shadow-vertical-rl-expected.txt:
  • platform/mac/fast/blockflow/english-lr-text-expected.txt:
  • platform/mac/fast/blockflow/english-rl-text-expected.txt:
  • platform/mac/fast/blockflow/japanese-lr-text-expected.txt:
  • platform/mac/fast/blockflow/japanese-rl-text-expected.txt:
  • platform/mac/fast/repaint/inline-vertical-rl-overflow-expected.checksum: Removed.
  • platform/mac/fast/repaint/inline-vertical-rl-overflow-expected.png: Removed.
  • platform/mac/fast/repaint/inline-vertical-rl-overflow-expected.txt: Removed.
  • platform/mac/fast/text/international/vertical-text-glyph-test-expected.txt:
09:04 Changeset [70990] by zimmermann@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

2010-10-31 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed.

Convert SVGAnimatedNumber/SVGAnimatedNumberList to the new SVGAnimatedPropertyTearOff concept
https://bugs.webkit.org/show_bug.cgi?id=48686

Forgot to land SVGAnimatedNumber.js, fails on all bots. Thanks Darin for noticing.

  • svg/dom/script-tests/SVGAnimatedNumber.js: Added.

10/30/10:

23:43 Changeset [70989] by pfeldman@chromium.org
  • 6 edits in trunk/WebCore

2010-10-30 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: new resources and network panel usability improvements.
https://bugs.webkit.org/show_bug.cgi?id=48680

By default, navigation clears network log, added 'preserve log' button,
that prevents log from being cleared.

Storing expanded state of all group items, restoring last selected item,
fall back to main frame's main resource by default.
Do not list XHRs and redirects in resources.

  • English.lproj/localizedStrings.js:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::didLoadResourceFromMemoryCache): (WebCore::InspectorController::identifierForInitialRequest):
  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype.get statusBarItems): (WebInspector.NetworkPanel.prototype._positionSummaryBar): (WebInspector.NetworkPanel.prototype._updateFilter): (WebInspector.NetworkPanel.prototype._createStatusbarButtons): (WebInspector.NetworkPanel.prototype._onPreserveLogClicked): (WebInspector.NetworkPanel.prototype.reset): (WebInspector.NetworkPanel.prototype.refreshResource):
  • inspector/front-end/ResourceManager.js: (WebInspector.ResourceManager.prototype.identifierForInitialRequest): (WebInspector.ResourceManager.prototype.willSendRequest): (WebInspector.ResourceManager.prototype.didLoadResourceFromMemoryCache): (WebInspector.ResourceManager.prototype.setOverrideContent): (WebInspector.ResourceManager.prototype.didCreateWebSocket):
  • inspector/front-end/StoragePanel.js: (WebInspector.StoragePanel): (WebInspector.StoragePanel.prototype.show): (WebInspector.StoragePanel.prototype._initDefaultSelection): (WebInspector.StoragePanel.prototype.reset): (WebInspector.StoragePanel.prototype.addResourceToFrame): (WebInspector.StoragePanel.prototype.refreshResource): (WebInspector.StoragePanel.prototype.showDatabase): (WebInspector.BaseStorageTreeElement.prototype.onselect): (WebInspector.StorageCategoryTreeElement): (WebInspector.StorageCategoryTreeElement.prototype.get itemURL): (WebInspector.StorageCategoryTreeElement.prototype.onselect): (WebInspector.StorageCategoryTreeElement.prototype.onattach): (WebInspector.StorageCategoryTreeElement.prototype.onexpand): (WebInspector.StorageCategoryTreeElement.prototype.oncollapse): (WebInspector.FrameTreeElement.prototype.get itemURL): (WebInspector.FrameTreeElement.prototype.onselect): (WebInspector.FrameResourceTreeElement.prototype.get itemURL): (WebInspector.FrameResourceTreeElement.prototype.onselect): (WebInspector.DatabaseTreeElement.prototype.get itemURL): (WebInspector.DatabaseTreeElement.prototype.onselect): (WebInspector.DatabaseTableTreeElement.prototype.get itemURL): (WebInspector.DatabaseTableTreeElement.prototype.onselect): (WebInspector.DOMStorageTreeElement.prototype.get itemURL): (WebInspector.DOMStorageTreeElement.prototype.onselect): (WebInspector.CookieTreeElement.prototype.get itemURL): (WebInspector.CookieTreeElement.prototype.onselect): (WebInspector.ApplicationCacheTreeElement.prototype.get itemURL): (WebInspector.ApplicationCacheTreeElement.prototype.onselect):
16:08 Changeset [70988] by tonikitoo@webkit.org
  • 1 edit in trunk/WebKit/win/Interfaces/WebKit.idl

2010-10-30 Antonio Gomes <agomes@rim.com>

Unreviewed Windows bots build fix (take I).

Touching WebKit.idl to try forcing a clean build.

  • Interfaces/WebKit.idl:
14:00 Changeset [70987] by wsiegrist@apple.com
  • 1 edit in trunk/WebKitTools/BuildSlaveSupport/build.webkit.org-config/config.json

William Siegrist <wsiegrist@apple.com>

Change trigger name to match builder name change in r70871.

12:31 Changeset [70986] by paroga@webkit.org
  • 4 edits in trunk

2010-10-30 Patrick Gansterer <paroga@webkit.org>

Unreviewed, build fix after r70846.

  • platform/graphics/wince/ImageWinCE.cpp: (WebCore::RGBA32Buffer::asNewNativeImage):

2010-10-30 Patrick Gansterer <paroga@webkit.org>

Unreviewed, build fix after r70574.

  • WebCoreSupport/FrameLoaderClientWinCE.cpp: (WebKit::FrameLoaderClientWinCE::transferLoadingResourceFromPage):
11:48 Changeset [70985] by dglazkov@chromium.org
  • 19 edits
    4 deletes in trunk

2010-10-30 Dimitri Glazkov <dglazkov@chromium.org>

Unreviewed, rolling out r70984.
http://trac.webkit.org/changeset/70984
https://bugs.webkit.org/show_bug.cgi?id=46015

Made media/audio-delete-while-slider-thumb-clicked.html crash.

  • fast/events/shadow-boundary-crossing.html:

2010-10-30 Dimitri Glazkov <dglazkov@chromium.org>

Unreviewed, rolling out r70984.
http://trac.webkit.org/changeset/70984
https://bugs.webkit.org/show_bug.cgi?id=46015

Made media/audio-delete-while-slider-thumb-clicked.html crash.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/ContainerNode.cpp: (WebCore::notifyChildInserted):
  • dom/EventContext.cpp: Removed.
  • dom/EventContext.h: Removed.
  • dom/Node.cpp: (WebCore::Node::markAncestorsWithChildNeedsStyleRecalc): (WebCore::Node::createRendererIfNeeded): (WebCore::Node::eventParentNode): (WebCore::Node::enclosingLinkEventParentOrSelf): (WebCore::eventTargetAsSVGElementInstance): (WebCore::eventTargetRespectingSVGTargetRules): (WebCore::Node::eventAncestors): (WebCore::Node::dispatchGenericEvent):
  • dom/Node.h:
  • dom/Text.cpp: (WebCore::Text::createRenderer):
  • dom/WindowEventContext.cpp: Removed.
  • dom/WindowEventContext.h: Removed.
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::getEventListenersForNode):
  • inspector/InspectorInstrumentation.cpp: (WebCore::eventHasListeners): (WebCore::InspectorInstrumentation::willDispatchEventImpl):
  • inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::willDispatchEvent):
  • page/EventHandler.cpp: (WebCore::EventHandler::updateMouseEventTargetNode):
  • svg/SVGElement.cpp: (WebCore::SVGElement::eventParentNode):
  • svg/SVGElement.h:
10:32 Changeset [70984] by dglazkov@chromium.org
  • 19 edits
    4 adds in trunk

2010-10-30 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Darin Adler.

Implement shadow DOM-aware event targeting and introduce EventContext to track the context of each event dispatch.
https://bugs.webkit.org/show_bug.cgi?id=46015

Tuned the test to better reflect its point: the event should indeed fire (it used to be swallowed),
but its target should be a non-shadow node.

  • fast/events/shadow-boundary-crossing.html: Modified the test.

2010-10-30 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Darin Adler.

Implement shadow DOM-aware event targeting and introduce EventContext to track the context of each event dispatch.
https://bugs.webkit.org/show_bug.cgi?id=46015

This patch adds the notion of EventContext (and a very similar-acting WindowEventContext, specifically
for DOMWindow), an abstraction that carries information around dispatching an event for any given Node.

This abstraction is necessary to ensure that events, fired from shadow DOM nodes are properly retargeted to
appear as if they are coming from their host, thus never exposing the shadow DOM nodes to the world outside.

  • Android.mk: Added EventContext, WindowEventContext files.
  • CMakeLists.txt: Ditto.
  • GNUmakefile.am: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • dom/ContainerNode.cpp: (WebCore::notifyChildInserted): Changed to be shadow DOM-aware.
  • dom/EventContext.cpp: Added.
  • dom/EventContext.h: Added.
  • dom/Node.cpp: (WebCore::Node::markAncestorsWithChildNeedsStyleRecalc): Changed to be shadow DOM-aware. (WebCore::Node::createRendererIfNeeded): Ditto. (WebCore::Node::parentOrHostNode): Added new helper method. (WebCore::Node::enclosingLinkEventParentOrSelf): Changed to be shadow DOM-aware. (WebCore::eventTargetRespectingSVGTargetRules): Collapsed two helper methods into one. (WebCore::Node::eventAncestors): Refactored to collect a vector of EventContexts. (WebCore::Node::topEventContext): Added. (WebCore::eventHasListeners): Changed to use EventContexts. (WebCore::Node::dispatchGenericEvent): Ditto.
  • dom/Node.h: Removed eventParentNode that's no longer needed, added parentOrHostNode decl,

and changed signature of eventAncestors to use EventContexts.

  • dom/Text.cpp: (WebCore::Text::createRenderer): Changed to be shadow DOM-aware.
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::getEventListenersForNode): Changed to use EventContexts.
  • page/EventHandler.cpp: (WebCore::EventHandler::updateMouseEventTargetNode): Removed code that's no longer necessary.
  • svg/SVGElement.cpp: Removed eventParentNode that's no longer needed.
  • svg/SVGElement.h: Ditto.
  • dom/WindowEventContext.cpp: Added.
  • dom/WindowEventContext.h: Added.
08:17 Changeset [70983] by xan@webkit.org
  • 2 edits in trunk/WebKit/gtk

2010-10-30 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Use new width for height APIs in GTK+ 3.x
https://bugs.webkit.org/show_bug.cgi?id=48709

Use the new width for height APIs in GTK+ 3.x, since size-request
is deprecated.

For now we just return the same value for preferred and minimum
width/height, which should match the 2.x behavior. Probably we
could do something smarter for the minimum values.

  • webkit/webkitwebview.cpp: (webkit_web_view_get_preferred_width): return our preferred width. (webkit_web_view_get_preferred_height): return our preferred height. (webkit_web_view_class_init): hook the new default handlers.
07:51 Changeset [70982] by andreas.kling@nokia.com
  • 2 edits in trunk/WebKit/qt

2010-10-30 Andreas Kling <kling@webkit.org>

Reviewed by Antonio Gomes.

[Qt] IM: Don't manipulate selection via RenderTextControl
https://bugs.webkit.org/show_bug.cgi?id=48700

Go directly through the Frame's SelectionController instead.

No new tests, this is covered by tst_QWebPage::inputMethods.

  • Api/qwebpage.cpp: (QWebPagePrivate::inputMethodEvent): (QWebPage::inputMethodQuery):
07:49 Changeset [70981] by andreas.kling@nokia.com
  • 2 edits in trunk/WebKit2

2010-10-30 Andreas Kling <kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt][WK2] Crash in drawUpdateChunkIntoBackingStore
https://bugs.webkit.org/show_bug.cgi?id=48707

UpdateChunk images have to be created using the QImage constructor
that takes a bytesPerLine (stride) value, or the data length won't
match UpdateChunk::size().

  • Shared/qt/UpdateChunk.cpp: (WebKit::UpdateChunk::createImage):
07:48 Changeset [70980] by andreas.kling@nokia.com
  • 3 edits in trunk/WebKitTools

2010-10-30 Andreas Kling <kling@webkit.org>

Reviewed by Antonio Gomes.

[Qt] QtTestBrowser: Switching view type moves the embedded inspector
https://bugs.webkit.org/show_bug.cgi?id=48705

Reinsert the embedded inspector into the splitter after changing
between QWebView/QGraphicsWebView.

  • QtTestBrowser/launcherwindow.cpp: (LauncherWindow::init): (LauncherWindow::initializeView):
  • QtTestBrowser/webinspector.h: (WebInspector::WebInspector):
06:23 Changeset [70979] by zimmermann@webkit.org
  • 50 edits
    10 adds in trunk

2010-10-30 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Rob Buis.

Convert SVGAnimatedNumber/SVGAnimatedNumberList to the new SVGAnimatedPropertyTearOff concept
https://bugs.webkit.org/show_bug.cgi?id=48686

Convert the next set of primitives to use the new SVG(Animated)PropertyTearOff concept.

Tests: svg/dom/SVGAnimatedNumber.html

svg/dom/SVGAnimatedNumberList.html
svg/dom/SVGNumber.html

  • GNUmakefile.am: Add SVGAnimatedNumber.h / SVGAnimatedNumberList.h to build.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • bindings/scripts/CodeGenerator.pm: Recognize SVGAnimatedNumber/SVGAnimatedNumberList as new style SVG animated properties. Remove SVGNumber from PODType hash.
  • bindings/scripts/CodeGeneratorJS.pm: Remove special SVGNumber handing, it's obsolete now.
  • bindings/scripts/CodeGeneratorObjC.pm: Add special SVGNumber handling, as it's the first of the converted dynamic SVGAnimatedProperty types that's not in WebCore namespace.
  • bindings/scripts/CodeGeneratorV8.pm: Use AvoidInclusionOfType method from CodeGenerator.pm, remove special SVGNumber handling, that's obsolete now.
  • rendering/svg/SVGTextLayoutAttributesBuilder.cpp: (WebCore::extractFloatValuesFromSVGNumberList): Adapt to SVGNumberList change, which is a plain Vector<float> now.
  • svg/DeprecatedSVGAnimatedPropertyTraits.h: Remove SVGAnimatedNumber/SVGAnimatedNumberList handling.
  • svg/DeprecatedSVGAnimatedTemplate.h: Ditto.
  • svg/SVGAnimatedNumber.h: Added.
  • svg/SVGAnimatedNumber.idl: Enable StrictTypeChecking.
  • svg/SVGAnimatedNumberList.h: Added.
  • svg/SVGAnimatedNumberList.idl: Ditto.
  • svg/SVGComponentTransferFunctionElement.cpp: Switch animated float properties to the new SVGAnimatedNumber(List). (WebCore::SVGComponentTransferFunctionElement::SVGComponentTransferFunctionElement): (WebCore::SVGComponentTransferFunctionElement::parseMappedAttribute): (WebCore::SVGComponentTransferFunctionElement::transferFunction):
  • svg/SVGComponentTransferFunctionElement.h:
  • svg/SVGFEColorMatrixElement.cpp: Ditto. (WebCore::SVGFEColorMatrixElement::SVGFEColorMatrixElement): (WebCore::SVGFEColorMatrixElement::parseMappedAttribute): (WebCore::SVGFEColorMatrixElement::build):
  • svg/SVGFEColorMatrixElement.h:
  • svg/SVGFECompositeElement.h: Ditto.
  • svg/SVGFEConvolveMatrixElement.cpp: Ditto. (WebCore::SVGFEConvolveMatrixElement::SVGFEConvolveMatrixElement): (WebCore::SVGFEConvolveMatrixElement::kernelUnitLengthXIdentifier): Added, replacing char[] hack by a static atomic string. (WebCore::SVGFEConvolveMatrixElement::kernelUnitLengthYIdentifier): Ditto. (WebCore::SVGFEConvolveMatrixElement::parseMappedAttribute): (WebCore::SVGFEConvolveMatrixElement::build):
  • svg/SVGFEConvolveMatrixElement.h: Switch animated float properties to the new SVGAnimatedNumber(List).
  • svg/SVGFEDiffuseLightingElement.cpp: Ditto. (WebCore::SVGFEDiffuseLightingElement::kernelUnitLengthXIdentifier): Remove trailing whitespace. (WebCore::SVGFEDiffuseLightingElement::kernelUnitLengthYIdentifier): Ditto.
  • svg/SVGFEDiffuseLightingElement.h: Switch animated float properties to the new SVGAnimatedNumber(List).
  • svg/SVGFEDisplacementMapElement.h: Ditto.
  • svg/SVGFEGaussianBlurElement.cpp: Ditto. (WebCore::SVGFEGaussianBlurElement::stdDeviationXIdentifier): Remove trailing whitespace. (WebCore::SVGFEGaussianBlurElement::stdDeviationYIdentifier): Ditto.
  • svg/SVGFEGaussianBlurElement.h: Switch animated float properties to the new SVGAnimatedNumber(List).
  • svg/SVGFELightElement.h: Ditto.
  • svg/SVGFEMorphologyElement.cpp: (WebCore::SVGFEMorphologyElement::radiusXIdentifier): Added, replacing char[] hack by a static atomic string. (WebCore::SVGFEMorphologyElement::radiusYIdentifier): Ditto.
  • svg/SVGFEMorphologyElement.h: Switch animated float properties to the new SVGAnimatedNumber(List).
  • svg/SVGFEOffsetElement.h: Ditto.
  • svg/SVGFESpecularLightingElement.cpp: (WebCore::SVGFESpecularLightingElement::kernelUnitLengthXIdentifier): Remove trailing whitespace. (WebCore::SVGFESpecularLightingElement::kernelUnitLengthYIdentifier): Ditto.
  • svg/SVGFESpecularLightingElement.h: Switch animated float properties to the new SVGAnimatedNumber(List).
  • svg/SVGFETurbulenceElement.cpp: (WebCore::SVGFETurbulenceElement::baseFrequencyXIdentifier): Remove trailing whitespace. (WebCore::SVGFETurbulenceElement::baseFrequencyYIdentifier): Ditto.
  • svg/SVGFETurbulenceElement.h: Switch animated float properties to the new SVGAnimatedNumber(List).
  • svg/SVGFilterElement.cpp: (WebCore::SVGFilterElement::filterResXIdentifier): Remove trailing whitespace. (WebCore::SVGFilterElement::filterResYIdentifier): Ditto.
  • svg/SVGLengthList.idl: Remove leftover [SVGListProperty] marker.
  • svg/SVGMarkerElement.cpp: (WebCore::SVGMarkerElement::orientTypeIdentifier): Remove trailing whitespace. (WebCore::SVGMarkerElement::orientAngleIdentifier): Ditto.
  • svg/SVGNumber.idl: Remove [PODType] marker, add StrictTypeChecking.
  • svg/SVGNumberList.cpp: Convert from SVGPODList<RefPtr<SVGPODListItem<float> > > to plain Vector<float>, just like it has been done for SVGLengthList before. (WebCore::SVGNumberList::parse): (WebCore::SVGNumberList::valueAsString):
  • svg/SVGNumberList.h: (WebCore::SVGNumberList::SVGNumberList):
  • svg/SVGPathElement.h: Switch animated float properties to the new SVGAnimatedNumber(List).
  • svg/SVGStopElement.h: Ditto.
  • svg/SVGTextPositioningElement.cpp: Switch animated float properties to the new SVGAnimatedNumber(List). (WebCore::SVGTextPositioningElement::SVGTextPositioningElement): (WebCore::SVGTextPositioningElement::parseMappedAttribute):
  • svg/SVGTextPositioningElement.h: Ditto.
  • svg/properties/SVGPropertyTraits.h: Add SVGNumberList handling.

2010-10-30 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Rob Buis.

Convert SVGAnimatedNumber/SVGAnimatedNumberList to the new SVGAnimatedPropertyTearOff concept
https://bugs.webkit.org/show_bug.cgi?id=48686

Fix invalid tests in svg/dynamic-updates, that relied on a bug in our SVGNumberList implementation. If an item was already
inserted in a list, and we tried to insert it somewhere else, we didn't remove it from the old list. Now that SVGNumberList
has been switched to SVGAnimatedListPropertyTearOff, the bug is fixed, and it behaves exactly like SVGLengthList.

Side effect: svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop.html now works as expected (dynamic update is executed)

  • platform/mac-leopard/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop-expected.checksum:
  • platform/mac-leopard/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop-expected.png:
  • svg/dom/SVGAnimatedNumber-expected.txt: Added.
  • svg/dom/SVGAnimatedNumber.html: Added.
  • svg/dom/SVGAnimatedNumberList-expected.txt: Added.
  • svg/dom/SVGAnimatedNumberList.html: Added.
  • svg/dom/SVGNumber-expected.txt: Added.
  • svg/dom/SVGNumber.html: Added.
  • svg/dom/script-tests/SVGAnimatedNumber.js: Added.
  • svg/dom/script-tests/SVGAnimatedNumberList.js: Added.
  • svg/dom/script-tests/SVGNumber.js: Added.
  • svg/dynamic-updates/script-tests/SVGFEColorMatrixElement-svgdom-type-prop.js: Test now works in Firefox as well. (executeTest): SVGNumber.value only accepts numbers, not strings, now that StrictTypeChecking is enabled.
  • svg/dynamic-updates/script-tests/SVGFEColorMatrixElement-svgdom-values-prop.js: Test now works in Firefox as well. (executeTest): Don't call appendItem several times with the same SVGNumber, it will be removed if it was already inserted in a list.
  • svg/dynamic-updates/script-tests/SVGFETurbulenceElement-svgdom-baseFrequency-prop.js:
01:59 Changeset [70978] by zimmermann@webkit.org
  • 5 edits in trunk/LayoutTests

2010-10-30 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed.

Update SVGFEFloodElement mac-leopard baseline, which was forgotten.

  • platform/mac-leopard/svg/dynamic-updates/SVGFEFloodElement-dom-flood-opacity-attr-expected.checksum:
  • platform/mac-leopard/svg/dynamic-updates/SVGFEFloodElement-dom-flood-opacity-attr-expected.png:
  • platform/mac-leopard/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-opacity-prop-expected.checksum:
  • platform/mac-leopard/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-opacity-prop-expected.png:
Note: See TracTimeline for information about the timeline view.