Timeline


and

11/07/10:

23:59 Changeset [71501] by abarth@webkit.org

2010-11-07 Adam Barth <abarth@webkit.org>

Unreviewed. Remove some unneeded includes.

  • loader/FrameLoader.cpp:
  • loader/PlaceholderDocument.cpp:
22:54 Changeset [71500] by ukai@chromium.org

Unreviewed, updating Chromium expectations.

  • platform/chromium/test_expectations.txt:
22:46 Changeset [71499] by abarth@webkit.org

2010-11-07 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Rename Cache to MemoryCache
https://bugs.webkit.org/show_bug.cgi?id=49159

  • public/WebCache.h:
  • src/WebCache.cpp: (WebKit::ToResourceTypeStat): (WebKit::WebCache::setCapacities): (WebKit::WebCache::clear): (WebKit::WebCache::getUsageStats): (WebKit::WebCache::getResourceTypeStats):

2010-11-07 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Rename Cache to MemoryCache
https://bugs.webkit.org/show_bug.cgi?id=49159

  • Api/qwebpage.cpp:
  • Api/qwebsettings.cpp:

2010-11-07 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Rename Cache to MemoryCache
https://bugs.webkit.org/show_bug.cgi?id=49159

  • webkit/webkitwebview.cpp:

2010-11-07 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Rename Cache to MemoryCache
https://bugs.webkit.org/show_bug.cgi?id=49159

  • WebCache.cpp: (WebCache::statistics):
  • WebFrame.cpp:
  • WebView.cpp:

2010-11-07 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Rename Cache to MemoryCache
https://bugs.webkit.org/show_bug.cgi?id=49159

  • WebView.cpp: (wxWebView::SetCachePolicy):
  • WebView.h:

2010-11-07 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Rename Cache to MemoryCache
https://bugs.webkit.org/show_bug.cgi?id=49159

  • Misc/WebCache.mm: (+[WebCache statistics]):
  • WebCoreSupport/WebDeviceOrientationClient.mm: (WebDeviceOrientationClient::setController):
  • WebView/WebView.mm:

2010-11-07 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Rename Cache to MemoryCache
https://bugs.webkit.org/show_bug.cgi?id=49159

So sayeth the diagram.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSImageValue.cpp:
  • dom/ContainerNode.cpp:
  • history/PageCache.cpp:
  • inspector/InspectorCSSStore.h:
  • inspector/InspectorResourceAgent.cpp:
  • loader/FrameLoader.cpp:
  • loader/archive/cf/LegacyWebArchive.cpp:
  • loader/cache/Cache.cpp: Removed.
  • loader/cache/Cache.h: Removed.
  • loader/cache/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::allClientsRemoved):
  • loader/cache/CachedFont.cpp:
  • loader/cache/CachedFont.h:
  • loader/cache/CachedImage.cpp: (WebCore::CachedImage::destroyDecodedData):
  • loader/cache/CachedImage.h:
  • loader/cache/CachedResource.cpp:
  • loader/cache/CachedResource.h:
  • loader/cache/CachedResourceLoader.cpp:
  • loader/cache/CachedResourceLoader.h:
  • loader/cache/CachedScript.cpp: (WebCore::CachedScript::destroyDecodedData):
  • loader/cache/MemoryCache.cpp: Copied from WebCore/loader/cache/Cache.cpp. (WebCore::cache): (WebCore::MemoryCache::MemoryCache): (WebCore::MemoryCache::requestResource): (WebCore::MemoryCache::requestUserCSSStyleSheet): (WebCore::MemoryCache::revalidateResource): (WebCore::MemoryCache::revalidationSucceeded): (WebCore::MemoryCache::revalidationFailed): (WebCore::MemoryCache::resourceForURL): (WebCore::MemoryCache::deadCapacity): (WebCore::MemoryCache::liveCapacity): (WebCore::MemoryCache::pruneLiveResources): (WebCore::MemoryCache::pruneDeadResources): (WebCore::MemoryCache::setCapacities): (WebCore::MemoryCache::makeResourcePurgeable): (WebCore::MemoryCache::evict): (WebCore::MemoryCache::addCachedResourceLoader): (WebCore::MemoryCache::removeCachedResourceLoader): (WebCore::MemoryCache::lruListFor): (WebCore::MemoryCache::removeFromLRUList): (WebCore::MemoryCache::insertInLRUList): (WebCore::MemoryCache::resourceAccessed): (WebCore::MemoryCache::removeFromLiveDecodedResourcesList): (WebCore::MemoryCache::insertInLiveDecodedResourcesList): (WebCore::MemoryCache::addToLiveResourcesSize): (WebCore::MemoryCache::removeFromLiveResourcesSize): (WebCore::MemoryCache::adjustSize): (WebCore::MemoryCache::TypeStatistic::addResource): (WebCore::MemoryCache::getStatistics): (WebCore::MemoryCache::setDisabled): (WebCore::MemoryCache::dumpStats): (WebCore::MemoryCache::dumpLRULists):
  • loader/cache/MemoryCache.h: Copied from WebCore/loader/cache/Cache.h. (WebCore::MemoryCache::shouldMakeResourcePurgeableOnEviction):
  • loader/loader.cpp:
  • page/EventSource.cpp:
  • page/Settings.h:
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::createRequest):

2010-11-07 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Rename Cache to MemoryCache
https://bugs.webkit.org/show_bug.cgi?id=49159

  • WebProcess/WebProcess.cpp:
  • WebProcess/mac/WebProcessMac.mm:
  • WebProcess/win/WebProcessWin.cpp:
21:57 Changeset [71498] by ukai@chromium.org

Unreviewed, updating Chromium expectations.

Add failures for crbug 62298, 62299, 62301

  • platform/chromium/test_expectations.txt:
21:47 Changeset [71497] by eric@webkit.org

2010-11-07 Eric Seidel <eric@webkit.org>

Unreviewed. Attempt to fix the windows build.

Move the rest of the cache-related files into loader/cache
https://bugs.webkit.org/show_bug.cgi?id=49156

  • WebCore.vcproj/WebCoreCommon.vsprops:
  • WebCore.vcproj/copyForwardingHeaders.cmd:
21:30 Changeset [71496] by eric@webkit.org

2010-11-07 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Move the rest of the cache-related files into loader/cache
https://bugs.webkit.org/show_bug.cgi?id=49156

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • loader/CachePolicy.h: Removed.
  • loader/CachedCSSStyleSheet.cpp: Removed.
  • loader/CachedCSSStyleSheet.h: Removed.
  • loader/CachedFont.cpp: Removed.
  • loader/CachedFont.h: Removed.
  • loader/CachedImage.cpp: Removed.
  • loader/CachedImage.h: Removed.
  • loader/CachedResource.cpp: Removed.
  • loader/CachedResource.h: Removed.
  • loader/CachedResourceClient.h: Removed.
  • loader/CachedResourceClientWalker.cpp: Removed.
  • loader/CachedResourceClientWalker.h: Removed.
  • loader/CachedResourceHandle.cpp: Removed.
  • loader/CachedResourceHandle.h: Removed.
  • loader/CachedResourceLoader.cpp: Removed.
  • loader/CachedResourceLoader.h: Removed.
  • loader/CachedScript.cpp: Removed.
  • loader/CachedScript.h: Removed.
  • loader/CachedXSLStyleSheet.cpp: Removed.
  • loader/CachedXSLStyleSheet.h: Removed.
  • loader/cache/CachePolicy.h: Copied from WebCore/loader/CachePolicy.h.
  • loader/cache/CachedCSSStyleSheet.cpp: Copied from WebCore/loader/CachedCSSStyleSheet.cpp.
  • loader/cache/CachedCSSStyleSheet.h: Copied from WebCore/loader/CachedCSSStyleSheet.h.
  • loader/cache/CachedFont.cpp: Copied from WebCore/loader/CachedFont.cpp.
  • loader/cache/CachedFont.h: Copied from WebCore/loader/CachedFont.h.
  • loader/cache/CachedImage.cpp: Copied from WebCore/loader/CachedImage.cpp.
  • loader/cache/CachedImage.h: Copied from WebCore/loader/CachedImage.h.
  • loader/cache/CachedResource.cpp: Copied from WebCore/loader/CachedResource.cpp.
  • loader/cache/CachedResource.h: Copied from WebCore/loader/CachedResource.h.
  • loader/cache/CachedResourceClient.h: Copied from WebCore/loader/CachedResourceClient.h.
  • loader/cache/CachedResourceClientWalker.cpp: Copied from WebCore/loader/CachedResourceClientWalker.cpp.
  • loader/cache/CachedResourceClientWalker.h: Copied from WebCore/loader/CachedResourceClientWalker.h.
  • loader/cache/CachedResourceHandle.cpp: Copied from WebCore/loader/CachedResourceHandle.cpp.
  • loader/cache/CachedResourceHandle.h: Copied from WebCore/loader/CachedResourceHandle.h.
  • loader/cache/CachedResourceLoader.cpp: Copied from WebCore/loader/CachedResourceLoader.cpp.
  • loader/cache/CachedResourceLoader.h: Copied from WebCore/loader/CachedResourceLoader.h.
  • loader/cache/CachedScript.cpp: Copied from WebCore/loader/CachedScript.cpp.
  • loader/cache/CachedScript.h: Copied from WebCore/loader/CachedScript.h.
  • loader/cache/CachedXSLStyleSheet.cpp: Copied from WebCore/loader/CachedXSLStyleSheet.cpp.
  • loader/cache/CachedXSLStyleSheet.h: Copied from WebCore/loader/CachedXSLStyleSheet.h.
21:03 Changeset [71495] by morrita@google.com

2010-11-07 MORITA Hajime <morrita@google.com>

Unreviewed test expectation rebaseline.

  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-element-expected.txt: Removed. (It's now same as platform/win)
  • platform/chromium/test_expectations.txt:
20:44 Changeset [71494] by abarth@webkit.org

2010-11-07 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Rename X-Purpose to Purpose
https://bugs.webkit.org/show_bug.cgi?id=47802

As requested by IETF HTTP WG. This patch is part of a larger movement
in the HTTP community to move away from X- headers. Various senior
folks at the IETF believe they're a failed experiment:

http://tools.ietf.org/html/draft-saintandre-xdash-considered-harmful

  • loader/loader.cpp: (WebCore::Loader::Host::servePendingRequests):

2010-11-07 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Rename X-Purpose to Purpose
https://bugs.webkit.org/show_bug.cgi?id=47802

Update expected results.

  • http/tests/misc/prefetch-purpose-expected.txt:
  • http/tests/misc/resources/prefetch-purpose.php:
20:32 Changeset [71493] by dbates@webkit.org

2010-11-07 Daniel Bates <dbates@rim.com>

Reviewed by Adam Barth.

Assert that a non-null PassRefPtr<Document> has a non-null frame in Frame::setDocument()
https://bugs.webkit.org/show_bug.cgi?id=49152

Add an ASSERT to ensure that a non-null Document has a non-null Frame
in Frame::setDocument().

Currently, whenever Frame::setDocument() is called with a non-null
Document the Document has a non-null Frame. We should assert this
invariant.

  • page/Frame.cpp: (WebCore::Frame::setDocument):
20:09 Changeset [71492] by eric@webkit.org

2010-11-07 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Move Cache.* into loader/cache in as a start to cleaning up loader/
https://bugs.webkit.org/show_bug.cgi?id=49153

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • loader/cache/Cache.cpp: Renamed from WebCore/loader/Cache.cpp. (WebCore::cache): (WebCore::Cache::Cache): (WebCore::createResource): (WebCore::Cache::requestResource): (WebCore::Cache::requestUserCSSStyleSheet): (WebCore::Cache::revalidateResource): (WebCore::Cache::revalidationSucceeded): (WebCore::Cache::revalidationFailed): (WebCore::Cache::resourceForURL): (WebCore::Cache::deadCapacity): (WebCore::Cache::liveCapacity): (WebCore::Cache::pruneLiveResources): (WebCore::Cache::pruneDeadResources): (WebCore::Cache::setCapacities): (WebCore::Cache::makeResourcePurgeable): (WebCore::Cache::evict): (WebCore::Cache::addCachedResourceLoader): (WebCore::Cache::removeCachedResourceLoader): (WebCore::fastLog2): (WebCore::Cache::lruListFor): (WebCore::Cache::removeFromLRUList): (WebCore::Cache::insertInLRUList): (WebCore::Cache::resourceAccessed): (WebCore::Cache::removeFromLiveDecodedResourcesList): (WebCore::Cache::insertInLiveDecodedResourcesList): (WebCore::Cache::addToLiveResourcesSize): (WebCore::Cache::removeFromLiveResourcesSize): (WebCore::Cache::adjustSize): (WebCore::Cache::TypeStatistic::addResource): (WebCore::Cache::getStatistics): (WebCore::Cache::setDisabled): (WebCore::Cache::dumpStats): (WebCore::Cache::dumpLRULists):
  • loader/cache/Cache.h: Renamed from WebCore/loader/Cache.h. (WebCore::Cache::LRUList::LRUList): (WebCore::Cache::TypeStatistic::TypeStatistic): (WebCore::Cache::loader): (WebCore::Cache::disabled): (WebCore::Cache::setPruneEnabled): (WebCore::Cache::prune): (WebCore::Cache::setDeadDecodedDataDeletionInterval): (WebCore::Cache::deadDecodedDataDeletionInterval): (WebCore::Cache::remove): (WebCore::Cache::shouldMakeResourcePurgeableOnEviction):
19:54 Changeset [71491] by ukai@chromium.org

2010-11-07 Fumitoshi Ukai <ukai@chromium.org>

Unreviewed, rolling out r71474.
http://trac.webkit.org/changeset/71474
https://bugs.webkit.org/show_bug.cgi?id=48280

breaks chromium webkit tests
https://bugs.webkit.org/show_bug.cgi?id=49151

  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/base_unittest.py:
  • Scripts/webkitpy/layout_tests/port/config.py:
  • Scripts/webkitpy/layout_tests/port/config_unittest.py:
  • Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
  • Scripts/webkitpy/tool/mocktool.py:
19:52 Changeset [71490] by ukai@chromium.org

2010-11-07 Fumitoshi Ukai <ukai@chromium.org>

Unreviewed, rolling out r71475.
http://trac.webkit.org/changeset/71475

breaks chromium webkit tests
https://bugs.webkit.org/show_bug.cgi?id=49151

  • Scripts/webkitpy/common/newstringio.py: Removed.
  • Scripts/webkitpy/common/newstringio_unittest.py: Removed.
  • Scripts/webkitpy/common/system/executive_mock.py: Removed.
  • Scripts/webkitpy/common/system/filesystem_mock.py: Removed.
  • Scripts/webkitpy/layout_tests/port/config_mock.py: Removed.
19:08 Changeset [71489] by andreas.kling@nokia.com

2010-11-07 Sam Magnuson <smagnuson@netflix.com>

Reviewed by Andreas Kling.

[Qt] make install does not cause JavaScriptCore to be built
https://bugs.webkit.org/show_bug.cgi?id=49114

18:54 Changeset [71488] by andreas.kling@nokia.com

2010-11-05 Helder Correia <helder@sencha.com>

Reviewed by Andreas Kling.

[Qt] box-shadow does not blur (is solid) when using border-radius
https://bugs.webkit.org/show_bug.cgi?id=46327

Implement blurred box-shadow when styling with border-radius.
This change is related to https://bugs.webkit.org/show_bug.cgi?id=44488

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::fillRoundedRect):

2010-11-05 Helder Correia <helder@sencha.com>

Reviewed by Andreas Kling.

[Qt] box-shadow does not blur (is solid) when using border-radius
https://bugs.webkit.org/show_bug.cgi?id=46327

Implement blurred box-shadow when styling with border-radius.
This change is related to https://bugs.webkit.org/show_bug.cgi?id=44488

  • platform/qt/fast/box-shadow/basic-shadows-expected.checksum:
  • platform/qt/fast/box-shadow/basic-shadows-expected.png:
18:31 Changeset [71487] by mdelaney@apple.com

2010-11-07 Matthew Delaney <mdelaney@apple.com>

Reviewed by Andreas Kling.

Unskipping recently merged new philip canvas tests from SnowLeopard
https://bugs.webkit.org/show_bug.cgi?id=49147

  • platform/mac-leopard/Skipped: Moving skipped test list down to leopard.
  • platform/mac-snowleopard/canvas/philip/tests/*: All new tests' expectations.
  • platform/mac/Skipped: Unskipping tests from overall mac.
17:49 Changeset [71486] by andreas.kling@nokia.com

2010-11-07 Helder Correia <helder@sencha.com>

Reviewed by Ariya Hidayat.

[Qt] Update the baseline for blur shadow test
https://bugs.webkit.org/show_bug.cgi?id=48223

Update basic-shadows test expected result with correct line segments.

  • platform/qt/fast/box-shadow/basic-shadows-expected.checksum:
  • platform/qt/fast/box-shadow/basic-shadows-expected.png:
17:14 Changeset [71485] by andreas.kling@nokia.com

2010-11-07 Andreas Kling <kling@webkit.org>

Unreviewed, skipping new canvas tests that are failing on Gtk+ and Qt.

Skip the following tests:

  • canvas/philip/tests/security.pattern.canvas.timing.html
  • canvas/philip/tests/security.pattern.create.html
  • canvas/philip/tests/security.pattern.cross.html
  • canvas/philip/tests/security.pattern.image.fillStyle.html
  • canvas/philip/tests/security.pattern.image.strokeStyle.html
  • platform/gtk/Skipped:
  • platform/qt/Skipped:
15:38 Changeset [71484] by commit-queue@webkit.org

2010-11-07 John Reck <jreck@google.com>

Reviewed by Steve Block.

Implements navigator.language for Android
https://bugs.webkit.org/show_bug.cgi?id=49099

Android was previously hardcoding the value for WebCore::platformDefaultLanguage().
This patch removes the hardcoding and calls into the PlatformBridge to get the
correct language based off of the user's settings.

No new tests needed, this is already covered

  • Android.mk:
  • platform/android/LanguageAndroid.cpp: Added. (WebCore::platformDefaultLanguage):
  • platform/android/PlatformBridge.h:
  • platform/android/TemporaryLinkStubs.cpp:
07:25 Changeset [71483] by robert@webkit.org

2010-11-07 Robert Hogan <robert@webkit.org>

Reviewed by Andreas Kling.

[qt] screenDepthPerComponent returns the wrong value

Return best estimate of the number of bits per color
rather than screen depth.

Add a layout test to sanity check screenDepthPerComponent.

https://bugs.webkit.org/show_bug.cgi?id=20289

  • fast/css/media-rule-screenDepthPerComponent-expected.txt: Added.
  • fast/css/media-rule-screenDepthPerComponent.html: Added.

2010-11-07 Robert Hogan <robert@webkit.org>

Reviewed by Andreas Kling.

[qt] screenDepthPerComponent returns the wrong value

Return best estimate of the number of bits per color
rather than screen depth.

Add a layout test to sanity check screenDepthPerComponent.

https://bugs.webkit.org/show_bug.cgi?id=20289

Test: fast/css/media-rule-screenDepthPerComponent.html

  • platform/qt/PlatformScreenQt.cpp: (WebCore::screenDepthPerComponent):
07:02 Changeset [71482] by andreas.kling@nokia.com

2010-11-07 Andreas Kling <kling@webkit.org>

Unreviewed, rebaselining failures on Leopard and Snow Leopard after r71481.

  • canvas/philip/tests/2d.imageData.get.source.negative-expected.txt:
  • canvas/philip/tests/security.pattern.canvas.timing-expected.txt:
  • canvas/philip/tests/security.pattern.create-expected.txt:
  • canvas/philip/tests/security.pattern.cross-expected.txt:
  • canvas/philip/tests/security.pattern.image.fillStyle-expected.txt:
  • canvas/philip/tests/security.pattern.image.strokeStyle-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.drawImage.broken-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.drawImage.null-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.fillStyle.parse.system-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.gradient.radial.cone.front-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.gradient.radial.cone.top-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.gradient.radial.inside2-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.gradient.radial.inside3-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.gradient.radial.outside1-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.imageData.create1.type-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.imageData.create2.type-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.imageData.get.type-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.line.cap.closed-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.line.join.parallel-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.line.miter.lineedge-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.missingargs-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.path.rect.winding-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.pattern.image.broken-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.pattern.image.incomplete-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.shadow.enable.blur-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.shadow.enable.x-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.shadow.enable.y-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.shadow.gradient.alpha-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.shadow.gradient.basic-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.shadow.gradient.transparent.2-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.strokeRect.zero.4-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.text.draw.baseline.bottom-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.text.draw.baseline.hanging-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.text.draw.baseline.ideographic-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.text.draw.baseline.middle-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.text.draw.baseline.top-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.text.draw.fill.maxWidth.fontface-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.text.draw.space.collapse.end-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.text.draw.space.collapse.nonspace-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.text.draw.space.collapse.other-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.text.draw.space.collapse.space-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.text.draw.space.collapse.start-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.text.font.parse.basic-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.text.font.parse.complex-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.text.font.parse.invalid-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.text.font.parse.size.percentage-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.text.font.parse.size.percentage.default-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.text.font.parse.system-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.text.measure.width.space-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/toDataURL.jpeg.alpha-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/type.prototype-expected.txt:
05:49 Changeset [71481] by andreas.kling@nokia.com

2010-10-18 Andreas Kling <kling@webkit.org>

Reviewed by James Robinson.

Update our clone of Philip Taylor's canvas test suite
https://bugs.webkit.org/show_bug.cgi?id=47707

Source: http://dvcs.w3.org/hg/html/file/df23d00a3395/tests/submission/PhilipTaylor

  • canvas/philip/README: Added, contains link to upstream revision.
  • canvas/philip/: Synced with upstream.
  • platform/gtk/Skipped: Skipped new failing tests.
  • platform/mac/Skipped: Ditto.
  • platform/qt/Skipped: Ditto.
01:42 Changeset [71480] by jcivelli@chromium.org

2010-11-07 Jay Civelli <jcivelli@chromium.org>

Reviewed by Kent Tamura.

Fixing a crasher with the select popup on Mac that happens when a
page removes the select node when the select changes.
https://bugs.webkit.org/show_bug.cgi?id=49108

  • src/ExternalPopupMenu.cpp: (WebKit::ExternalPopupMenu::didAcceptIndex): (WebKit::ExternalPopupMenu::didCancel):
01:24 Changeset [71479] by chang.shu@nokia.com

2010-11-07 Chang Shu <chang.shu@nokia.com>

Reviewed by Antonio Gomes.

Add a helper function to avoid duplicated code.
https://bugs.webkit.org/show_bug.cgi?id=49085

  • dom/SelectElement.cpp:
  • editing/SelectionController.cpp: (WebCore::SelectionController::modify):
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::isKeyboardFocusable):
  • page/EventHandler.cpp: (WebCore::EventHandler::defaultArrowEventHandler):
  • page/SpatialNavigation.cpp: (WebCore::isSpatialNavigationEnabled):
  • page/SpatialNavigation.h:

2010-11-07 Chang Shu <chang.shu@nokia.com>

Reviewed by Antonio Gomes.

Add a helper function to avoid duplicated code.
https://bugs.webkit.org/show_bug.cgi?id=49085

  • WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::handleKeyboardEvent):

11/06/10:

23:43 Changeset [71478] by pfeldman@chromium.org

2010-11-06 Pavel Feldman <pfeldman@chromium.org>

Not reviewed. Chromium DevTools: disable filesystem inspection
until polished.
https://bugs.webkit.org/show_bug.cgi?id=48963

  • src/js/DevTools.js:
23:26 Changeset [71477] by pfeldman@chromium.org

2010-11-06 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Simon Fraser.

Web Inspector: Some image resources don't display the image when selected in the Resources panel.
https://bugs.webkit.org/show_bug.cgi?id=48935

Marked resources loaded from memory cache as finished.

  • inspector/front-end/ResourceManager.js: (WebInspector.ResourceManager.prototype.didLoadResourceFromMemoryCache):
23:23 Changeset [71476] by pfeldman@chromium.org

2010-11-06 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: XHR logging is not checked in context menu after browser restart.
https://bugs.webkit.org/show_bug.cgi?id=49133

  • inspector/InspectorState.cpp: (WebCore::InspectorState::InspectorState):
21:21 Changeset [71475] by dpranke@chromium.org

2010-11-06 Dirk Pranke <dpranke@chromium.org>

Unreviewed, build fix.

Add files inexplicably not committed in r71474 as part of the
fix for bug 48280.

  • Scripts/webkitpy/common/newstringio.py: Added.
  • Scripts/webkitpy/common/newstringio_unittest.py: Added.
  • Scripts/webkitpy/common/system/executive_mock.py: Added.
  • Scripts/webkitpy/common/system/filesystem_mock.py: Added.
  • Scripts/webkitpy/layout_tests/port/config_mock.py: Added.
20:38 Changeset [71474] by dpranke@chromium.org

2010-11-06 Dirk Pranke <dpranke@chromium.org>

Reviewed by Eric Siedel.

new-run-webkit-tests: update port/base and port/webkit to use the
new FileSystem and Config abstractions, pulling more logic out of
the base Port classes into separate, mockable objects.

Also create a MockFileSystem object, a MockConfig object, move
MockExecutive into common/system to be next to executive, and
update the config object to use a FileSystem.

https://bugs.webkit.org/show_bug.cgi?id=48280

  • Scripts/webkitpy/common/newstringio.py: Added.
  • Scripts/webkitpy/common/newstringio_unittest.py: Added.
  • Scripts/webkitpy/common/system/executive_mock.py: Added.
  • Scripts/webkitpy/common/system/filesystem_mock.py: Added.
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/base_unittest.py:
  • Scripts/webkitpy/layout_tests/port/config.py:
  • Scripts/webkitpy/layout_tests/port/config_mock.py:
  • Scripts/webkitpy/layout_tests/port/config_unittest.py:
  • Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
  • Scripts/webkitpy/tool/mocktool.py:
19:44 Changeset [71473] by dpranke@chromium.org

2010-11-06 Dirk Pranke <dpranke@chromium.org>

Unreviewed, build breakage.

Apparently I uploaded the wrong version of the file to fix 49122
and neither Eric or I noticed - it was missing a dirname() call.
Fixing ...

https://bugs.webkit.org/show_bug.cgi?id=49122

  • Scripts/webkitpy/common/checkout/scm.py:
19:31 Changeset [71472] by dpranke@chromium.org

2010-11-06 Dirk Pranke <dpranke@chromium.org>

Reviewed by Eric Seidel.

webkitpy/tool/* unittests change cwd and don't clean up properly

https://bugs.webkit.org/show_bug.cgi?id=49122

  • Scripts/webkitpy/common/checkout/scm.py:
18:23 Changeset [71471] by kbalazs@webkit.org

2010-11-06 Balazs Kelemen <kbalazs@webkit.org>

Reviewed by Andreas Kling.

[Qt][WK2] WebKitTestRunner is dead
https://bugs.webkit.org/show_bug.cgi?id=49129

  • Platform/qt/SharedMemoryQt.cpp: (WebKit::SharedMemory::~SharedMemory): Avoid double deletion when deleteLater has already been called.
15:56 Changeset [71470] by rniwa@webkit.org

2010-11-06 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed Windows build fix.

  • editing/EditingAllInOne.cpp: Added EditingStyle.cpp
14:19 Changeset [71469] by rniwa@webkit.org

2010-11-04 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

Bug 46335 - Add EditingStyle
https://bugs.webkit.org/show_bug.cgi?id=46335

Added EditingStyle to WebCore/editing. This class is intended to encapsulate getPropertiesNotIn, removeNonEditingProperties,
editingStyleAtPosition, and prepareEditingStyleToApplyAt in ApplyStyleCommand.cpp once deployed everywhere.
Deployed it in typing styles.

No new tests are added since this is a refactoring in progress.

  • CMakeLists.txt: Added EditingStyle.cpp
  • GNUmakefile.am: Added EditingStyle.cpp and EditingStyle.h
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::moveParagraphs): Calls editingStyleIncludingTypingStyle. (WebCore::CompositeEditCommand::breakOutOfEmptyListItem): Uses EditingStyle.
  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::saveTypingStyleState): Ditto. (WebCore::DeleteSelectionCommand::calculateTypingStyleAfterDelete): Ditto.
  • editing/DeleteSelectionCommand.h:
  • editing/EditingStyle.cpp: Added. (WebCore::editingStyleFromComputedStyle): Added. (WebCore::EditingStyle::EditingStyle): Added. (WebCore::EditingStyle::init): Added; a clone of ApplyStyleCommand::editingStyleAtPosition. (WebCore::EditingStyle::removeTextFillAndStrokeColorsIfNeeded): Extracted from init. (WebCore::EditingStyle::replaceFontSizeByKeywordIfPossible): Extracted from init. (WebCore::EditingStyle::isEmpty): Added. (WebCore::EditingStyle::setStyle): Added. (WebCore::EditingStyle::clear): Added. (WebCore::EditingStyle::removeBlockProperties): Added. (WebCore::EditingStyle::prepareToApplyAt): Added. (WebCore::editingStyleIncludingTypingStyle): Added.
  • editing/EditingStyle.h: Added. (WebCore::EditingStyle::create): Added. (WebCore::EditingStyle::style): Added.
  • editing/RemoveFormatCommand.cpp: (WebCore::RemoveFormatCommand::doApply): Uses EditingStyle.
  • editing/SelectionController.h: (WebCore::SelectionController::typingStyle): Uses EditingStyle. (WebCore::SelectionController::clearTypingStyle): Uses EditingStyle. (WebCore::SelectionController::setTypingStyle): Uses EditingStyle.
  • rendering/style/RenderStyle.h: Added EditingStyle as a friend.
01:33 Changeset [71468] by ossy@webkit.org

Unreviewed. Update Qt specific expected files after r71467.

  • platform/qt/fast/blockflow/background-horizontal-bt-expected.checksum:
  • platform/qt/fast/blockflow/background-horizontal-bt-expected.png:
  • platform/qt/fast/blockflow/background-horizontal-bt-expected.txt:
  • platform/qt/fast/blockflow/background-vertical-lr-expected.checksum:
  • platform/qt/fast/blockflow/background-vertical-lr-expected.png:
  • platform/qt/fast/blockflow/background-vertical-lr-expected.txt:

11/05/10:

23:13 Changeset [71467] by ap@apple.com

2010-11-05 Alexey Proskuryakov <ap@apple.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=49100
ASSERT([self window]) fails in -[WebBaseNetscapePluginView restartTimers]

  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView restartTimers]): Removed the assertion. Multiple callers provide no guarantee that the plug-in is still alive (see bug comments), and there seems to be no harm in executing this function in that case.
22:52 Changeset [71466] by commit-queue@webkit.org

2010-11-05 Nicolas Dufresne <nicolas.dufresne@collabora.co.uk>

Reviewed by Martin Robinson.

[GTK] Link with target name set does not work correctly
https://bugs.webkit.org/show_bug.cgi?id=48865

When a new page is created with a name (target=myFrame), the new
mainFrame could not be found because they where not stored in the
same PageGroup. As PageGroup are not exposed externally so the
simpliest solution is to use a global page group name. This also fixes
issue with visited link coloration across pages. After this change the
private function webkit_web_view_set_group_name() was no longer used
so it was removed completly.

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::closeWindowSoon):
  • webkit/webkitprivate.h:
  • webkit/webkitwebview.cpp: (webkit_web_view_init):
22:49 Changeset [71465] by hyatt@apple.com

https://bugs.webkit.org/show_bug.cgi?id=47237

Reviewed by Dan Bernstein and Simon Fraser.

Make selection work with vertical text. This patch fixes a bug in the computation of lineTop. For lines
with positive leading, lineTop was incorrectly including the top leading. Since the flipping of lines
for "lr" and "bt" writing modes involved flipping using lineTop and lineBottom, an incorrect lineTop meant
that those modes were mis-rendering. This is why the Japanese "lr" text examples have the first line smushed
too far against the border.

Fixing lineTop to no longer incorrectly include top leading has implications for editing. I ended up
rewriting positionForPoint to exactly match selection, since that seemed to be the most intuitive
behavior. I got rid of the verticalClickFudgeFactor and now just use selectionTop and selectionBottom
instead of lineTop and lineBottom. I am pretty sure the code used selectionTop in a previous incarnation
anyway and that I moved away from it when I implemented lineTop and lineBottom. The code then grew
more complicated from people trying to work with lineTop and lineBottom, but going back to selectionTop
and selectionBottom is the right behavior I think. One editing test has been updated after this change
(editing/selection/after-line-break.html), and one DOM test has been changed to not hit test past the
bottom of a line (fast/dom/Document/CaretRangeFromPoint/basic.html).

I patched selection painting of InlineTextBoxes so that the leading going up to the next line box is used
for "lr" and "bt" modes instead of the previous box. This makes sense for English text, but we may want
a different policy for Japanese text eventually (possibly just splitting the difference instead). Leaving it
this way for now, and we can collect feedback on the design.

I rewrote all of the selection gap painting code to be writing-mode aware. During the course of rewriting this
code I noticed a bug in the logicalLeftSelectionOffset and logicalRightSelectionOffset functions where there
was a coordinate space mismatch on a comparison. Fixing this improves the repaint/selection-clear.html test.

Added new tests in fast/blockflow/.

WebCore:

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::placeBoxesInBlockDirection):

  • rendering/InlineFlowBox.h:
  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::selectionBottom):
(WebCore::InlineTextBox::paintSelection):
(WebCore::InlineTextBox::paintCompositionBackground):
(WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
(WebCore::InlineTextBox::paintTextMatchMarker):

  • rendering/InlineTextBox.h:
  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::selectionGapRectsForRepaint):
(WebCore::RenderBlock::paintSelection):
(WebCore::clipOutPositionedObjects):
(WebCore::blockDirectionOffset):
(WebCore::inlineDirectionOffset):
(WebCore::RenderBlock::logicalRectToPhysicalRect):
(WebCore::RenderBlock::selectionGaps):
(WebCore::RenderBlock::inlineSelectionGaps):
(WebCore::RenderBlock::blockSelectionGaps):
(WebCore::RenderBlock::blockSelectionGap):
(WebCore::RenderBlock::logicalLeftSelectionGap):
(WebCore::RenderBlock::logicalRightSelectionGap):
(WebCore::RenderBlock::logicalLeftSelectionOffset):
(WebCore::RenderBlock::logicalRightSelectionOffset):

  • rendering/RenderBlock.h:
  • rendering/RenderBox.cpp:

(WebCore::RenderBox::flipForWritingMode):

  • rendering/RenderBox.h:

(WebCore::RenderBox::logicalBottom):

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::alignBoxesInBlockDirection):
(WebCore::RootInlineBox::lineSelectionGap):
(WebCore::RootInlineBox::selectionTop):
(WebCore::RootInlineBox::selectionBottom):

  • rendering/RootInlineBox.h:

LayoutTests:

  • editing/selection/after-line-break-expected.txt:
  • fast/blockflow/japanese-lr-selection.html: Added.
  • fast/blockflow/japanese-rl-selection.html: Added.
  • fast/dom/Document/CaretRangeFromPoint/basic.html:
  • platform/mac/fast/blockflow/background-horizontal-bt-expected.checksum:
  • platform/mac/fast/blockflow/background-horizontal-bt-expected.png:
  • platform/mac/fast/blockflow/background-horizontal-bt-expected.txt:
  • platform/mac/fast/blockflow/background-vertical-lr-expected.checksum:
  • platform/mac/fast/blockflow/background-vertical-lr-expected.png:
  • platform/mac/fast/blockflow/background-vertical-lr-expected.txt:
  • platform/mac/fast/blockflow/border-image-horizontal-bt-expected.checksum:
  • platform/mac/fast/blockflow/border-image-horizontal-bt-expected.png:
  • platform/mac/fast/blockflow/border-image-horizontal-bt-expected.txt:
  • platform/mac/fast/blockflow/border-image-vertical-lr-expected.checksum:
  • platform/mac/fast/blockflow/border-image-vertical-lr-expected.png:
  • platform/mac/fast/blockflow/border-image-vertical-lr-expected.txt:
  • platform/mac/fast/blockflow/border-radius-clipping-vertical-lr-expected.checksum:
  • platform/mac/fast/blockflow/border-radius-clipping-vertical-lr-expected.png:
  • platform/mac/fast/blockflow/border-radius-clipping-vertical-lr-expected.txt:
  • platform/mac/fast/blockflow/border-vertical-lr-expected.checksum:
  • platform/mac/fast/blockflow/border-vertical-lr-expected.png:
  • platform/mac/fast/blockflow/border-vertical-lr-expected.txt:
  • platform/mac/fast/blockflow/box-shadow-horizontal-bt-expected.checksum:
  • platform/mac/fast/blockflow/box-shadow-horizontal-bt-expected.png:
  • platform/mac/fast/blockflow/box-shadow-horizontal-bt-expected.txt:
  • platform/mac/fast/blockflow/box-shadow-vertical-lr-expected.checksum:
  • platform/mac/fast/blockflow/box-shadow-vertical-lr-expected.png:
  • platform/mac/fast/blockflow/box-shadow-vertical-lr-expected.txt:
  • platform/mac/fast/blockflow/japanese-lr-selection-expected.checksum: Added.
  • platform/mac/fast/blockflow/japanese-lr-selection-expected.png: Added.
  • platform/mac/fast/blockflow/japanese-lr-selection-expected.txt: Added.
  • platform/mac/fast/blockflow/japanese-lr-text-expected.checksum:
  • platform/mac/fast/blockflow/japanese-lr-text-expected.png:
  • platform/mac/fast/blockflow/japanese-lr-text-expected.txt:
  • platform/mac/fast/blockflow/japanese-rl-selection-expected.checksum: Added.
  • platform/mac/fast/blockflow/japanese-rl-selection-expected.png: Added.
  • platform/mac/fast/blockflow/japanese-rl-selection-expected.txt: Added.
  • platform/mac/fast/repaint/selection-clear-expected.checksum:
  • platform/mac/fast/repaint/selection-clear-expected.png:
22:34 Changeset [71464] by simon.fraser@apple.com

2010-11-05 Simon Fraser <simon.fraser@apple.com>

Just put things back the way they were. Too many mysterious linker errors.

22:23 Changeset [71463] by simon.fraser@apple.com

2010-11-05 Simon Fraser <simon.fraser@apple.com>

Undo most of the previous commit since the compiler seems to have trouble
with an inlined operator++ in debug builds.

  • platform/DeprecatedPtrListImpl.cpp: (WebCore::DeprecatedPtrListImplIterator::operator++):
  • platform/DeprecatedPtrListImpl.h:
21:55 Changeset [71462] by simon.fraser@apple.com

2010-11-05 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dave Hyatt.

Inline some DeprecatedPtrListImplIterator methods for performance
https://bugs.webkit.org/show_bug.cgi?id=49124

This is a ~4% performance improvement on some Peacekeepr "Community" tests.

  • platform/DeprecatedPtrListImpl.cpp:
  • platform/DeprecatedPtrListImpl.h: (WebCore::DeprecatedListNode::DeprecatedListNode): (WebCore::DeprecatedPtrListImplIterator::current): (WebCore::DeprecatedPtrListImplIterator::operator++):
18:01 Changeset [71461] by abarth@webkit.org

2010-11-05 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Gray-scale PNGs with color profiles don't decode properly on Chromium Mac
https://bugs.webkit.org/show_bug.cgi?id=49110

Test that we decode gray-scale PNGs correctly. Sadly, this is a pixel
test. For ports that run pixel tests, we'll have to grab the pixels
off the bot.

  • fast/images/gray-scale-png-with-color-profile.html: Added.
  • fast/images/resources/mu.png: Added.
  • platform/mac/fast/images/gray-scale-png-with-color-profile-expected.txt: Added.

2010-11-05 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Gray-scale PNGs with color profiles don't decode properly on Chromium Mac
https://bugs.webkit.org/show_bug.cgi?id=49110

Applying the color profile from this PNG was causing the image to
triple in width. This seems to be because both the PNG decoder and
CoreGraphics were trying to expand the gray-scale image to RGB. To fix
this issue, I've disabled color profile support for gray-scale PNGs.

Test: fast/images/gray-scale-png-with-color-profile.html

  • platform/image-decoders/png/PNGImageDecoder.cpp: (WebCore::PNGImageDecoder::headerAvailable):
17:42 Changeset [71460] by jianli@chromium.org

2010-11-05 Jian Li <jianli@chromium.org>

Reviewed by Dmitry Titov.

Need to check if page is detached in Frame::transferChildFrameToNewDocument to avoid occasional crash
https://bugs.webkit.org/show_bug.cgi?id=49116

The fix is to add the check.

  • page/Frame.cpp: (WebCore::Frame::transferChildFrameToNewDocument):
17:14 Changeset [71459] by enrica@apple.com

Pasting large amounts of plain text in a text area is very slow
https://bugs.webkit.org/show_bug.cgi?id=49040
<rdar://problem/7640912>

Reviewed by Adele Peterson.

The optimization consists in skipping the ApplyStyle command when
pasting into a text area or into an element that has -webkit-user-modify: read-write-plaintext-only.
The biggest performance hit comes from iterating through
a large number of paragraph when no style change is needed.
A further step will be to improve the paragraph iteration when it
can't be avoided.

  • editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::doApply): Check if the selection
is in a text form control or in an element that has -webkit-user-modify: read-write-plaintext-only
and force no style matching.

17:12 Changeset [71458] by cmarrin@apple.com

2010-11-05 Chris Marrin <cmarrin@apple.com>

Reviewed by Simon Fraser.

suspendAnimations/resumeAnimations not present in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=49109

Got 4 tests out of the Skipped list that now pass

  • platform/mac-wk2/Skipped:

2010-11-05 Chris Marrin <cmarrin@apple.com>

Reviewed by Simon Fraser.

suspendAnimations/resumeAnimations not present in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=49109

  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::suspendAnimations): (WTR::LayoutTestController::resumeAnimations):
  • WebKitTestRunner/InjectedBundle/LayoutTestController.h:

2010-11-05 Chris Marrin <cmarrin@apple.com>

Reviewed by Simon Fraser.

suspendAnimations/resumeAnimations not present in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=49109

  • WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp: (WKBundleFrameSuspendAnimations): (WKBundleFrameResumeAnimations):
  • WebProcess/InjectedBundle/API/c/WKBundleFramePrivate.h:
  • WebProcess/WebPage/WebFrame.cpp: (WebKit::WebFrame::suspendAnimations): (WebKit::WebFrame::resumeAnimations):
  • WebProcess/WebPage/WebFrame.h:
16:01 Changeset [71457] by dumi@chromium.org

Unreviewed, updating Chromium expectations.

  • platform/chromium-linux/fast/dom/HTMLProgressElement/progress-element-with-child-crash-expected.txt: Added.
  • platform/chromium-win/fast/dom/HTMLProgressElement/progress-element-with-child-crash-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
15:55 Changeset [71456] by andersca@apple.com

WebProcess won't kill itself if UIProcess goes away while WebProcess is spinning
https://bugs.webkit.org/show_bug.cgi?id=49090
<rdar://problem/7834575>

Reviewed by Darin Adler.

  • Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::connectionDidClose):
Call Client::didCloseOnConnectionWorkQueue.

  • Platform/CoreIPC/Connection.h:

(CoreIPC::Connection::Client::didCloseOnConnectionWorkQueue):
Add new client function. Will be called on the connection work queue when the connection is closed.

  • Platform/WorkItem.h:

(FunctionWorkItem0::FunctionWorkItem0):
(FunctionWorkItem0::execute):
(WorkItem::create):
Add a new WorkItem subclass that will invoke a C function.

  • Platform/WorkQueue.h:
  • Platform/mac/WorkQueueMac.cpp:

(WorkQueue::scheduleWorkAfterDelay):
New function which will schedule the given work item to be executed in at least 'delay' seconds.

  • Platform/qt/WorkQueueQt.cpp:

(WorkQueue::scheduleWorkAfterDelay):
Add empty stub.

  • Platform/win/WorkQueueWin.cpp:

(WorkQueue::scheduleWorkAfterDelay):
Ditto.

  • PluginProcess/PluginProcess.h:

Derive from ChildProcess.

  • Shared/ChildProcess.cpp: Added.

(WebKit::ChildProcess::ChildProcess):
(WebKit::ChildProcess::~ChildProcess):
(WebKit::watchdogCallback):
Call _exit.

(WebKit::ChildProcess::didCloseOnConnectionWorkQueue):
When the connection is closed, schedule a work item to be run in 10 seconds. If the process hasn't
exited normally by then, we'll exit.

  • Shared/ChildProcess.h:

Add new ChildProcess class which is a common base class of WebProcess and PluginProcess and which contains
the watchdog timer logic.

  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:

Add new files.

  • WebProcess/WebProcess.h:

Derive from ChildProcess.

  • win/WebKit2.vcproj:

Add new files.

15:47 Changeset [71455] by rniwa@webkit.org

2010-11-05 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by David Levin.

JSCallbackData::invokeCallback triggers layout from a worker thread
https://bugs.webkit.org/show_bug.cgi?id=49096

Fixed the bug by only calling updateStyleForAllDocuments when the context is document in
JSCallbackData::invokeCallback.

No new tests are added since many of existing workers tests hit the added assertion in debug builds.

  • bindings/js/JSCallbackData.cpp: (WebCore::JSCallbackData::invokeCallback): No longer calls updateStyleForAllDocuments unconditionally.
  • dom/Document.cpp: (WebCore::Document::updateStyleIfNeeded): Added ASSERT(isMainThread()). (WebCore::Document::updateStyleForAllDocuments): Ditto. (WebCore::Document::updateLayout): Ditto.
15:47 Changeset [71454] by cmarrin@apple.com

Increased tolerance on test due to variability of timing on the bots

15:34 Changeset [71453] by ossy@webkit.org

Unreviewed.

[Qt] animations tests fails which uses suspend/resume
https://bugs.webkit.org/show_bug.cgi?id=43905

  • platform/qt/Skipped:
    • animations/suspend-resume-animation-events.html added until fix.
    • animations/stop-animation-on-suspend.html added until fix.
15:00 Changeset [71452] by commit-queue@webkit.org

2010-11-05 Ilya Sherman <isherman@chromium.org>

Reviewed by Simon Fraser.

Querying selection start and end should be const
https://bugs.webkit.org/show_bug.cgi?id=48786

  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::selectionStart): (WebCore::RenderTextControl::selectionEnd): (WebCore::RenderTextControl::visiblePositionForIndex): (WebCore::RenderTextControl::indexForVisiblePosition):
  • rendering/RenderTextControl.h:

2010-11-05 Ilya Sherman <isherman@chromium.org>

Reviewed by Simon Fraser.

Querying selection start and end should be const
https://bugs.webkit.org/show_bug.cgi?id=48786

  • public/WebInputElement.h:
  • src/WebInputElement.cpp: (WebKit::WebInputElement::selectionStart): (WebKit::WebInputElement::selectionEnd):
14:45 Changeset [71451] by cmarrin@apple.com

2010-11-05 Chris Marrin <cmarrin@apple.com>

Reviewed by Simon Fraser.

Move resumeAnimations/suspendAnimations from Frame to AnimationController.
https://bugs.webkit.org/show_bug.cgi?id=49073

  • src/WebAnimationControllerImpl.cpp: (WebKit::WebAnimationControllerImpl::suspendAnimations): (WebKit::WebAnimationControllerImpl::resumeAnimations):

2010-11-05 Chris Marrin <cmarrin@apple.com>

Reviewed by Simon Fraser.

Move resumeAnimations/suspendAnimations from Frame to AnimationController.
https://bugs.webkit.org/show_bug.cgi?id=49073

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::suspendAnimations): (DumpRenderTreeSupportQt::resumeAnimations):

2010-11-05 Chris Marrin <cmarrin@apple.com>

Reviewed by Simon Fraser.

Move resumeAnimations/suspendAnimations from Frame to AnimationController.
https://bugs.webkit.org/show_bug.cgi?id=49073

  • webkit/webkitwebframe.cpp: (webkit_web_frame_suspend_animations): (webkit_web_frame_resume_animations):

2010-11-05 Chris Marrin <cmarrin@apple.com>

Reviewed by Simon Fraser.

Move resumeAnimations/suspendAnimations from Frame to AnimationController.
https://bugs.webkit.org/show_bug.cgi?id=49073

  • WebFrame.cpp: (WebFrame::suspendAnimations): (WebFrame::resumeAnimations):

2010-11-05 Chris Marrin <cmarrin@apple.com>

Reviewed by Simon Fraser.

Move resumeAnimations/suspendAnimations from Frame to AnimationController.
https://bugs.webkit.org/show_bug.cgi?id=49073

  • WebView/WebFrame.mm: (-[WebFrame _suspendAnimations]): (-[WebFrame _resumeAnimations]):

2010-11-05 Chris Marrin <cmarrin@apple.com>

Reviewed by Simon Fraser.

Move resumeAnimations/suspendAnimations from Frame to AnimationController.
https://bugs.webkit.org/show_bug.cgi?id=49073

Changed the name of suspendAnimations/resumeAnimations to
suspendAnimationsInDocument/resumeAnimationsInDocument. These are no
longer exported, but have the same functionality as before. I then
added new suspendAnimations/resumeAnimations function which take
no params and suspend/resume on the frame owning the animation
controller and all its child frames. These are the functions that
are now exported. I then changed all the platform specific WebKit
code to use these functions.

  • WebCore.exp.in:
  • page/Frame.cpp:
  • page/Frame.h:
  • page/animation/AnimationController.cpp: (WebCore::AnimationControllerPrivate::suspendAnimations): (WebCore::AnimationControllerPrivate::resumeAnimations):
14:41 Changeset [71450] by mihaip@chromium.org

2010-11-05 Mihai Parparita <mihaip@chromium.org>

Reviewed by Ojan Vafai.

[Chromium] fast/events/stopPropagation-submit.html fails
https://bugs.webkit.org/show_bug.cgi?id=49078

The test was failing because of a difference between KURL and GURL in
how forms that have a data: URL action are handled*. Since the actual
test was testing something else (that stopPropagation does not prevent
form submissions), using a real page as the target makes the test
pass everywhere.

  • FWIW, it looks like GURL is right, per step 15 of section 4.10.22.3 (Form submission algorithm) of the HTML 5 spec, data URLs used with GET should not be mutated; filed bug 49091 about this.
  • fast/events/resources/stopPropagation-submit-target.html: Added.
  • fast/events/stopPropagation-submit.html:
  • platform/chromium/test_expectations.txt:
13:28 Changeset [71449] by zmo@google.com

2010-11-04 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Need to simulate DEPTH_STENCIL in framebufferRenderbuffer / getFramebufferAttachmentParameter
https://bugs.webkit.org/show_bug.cgi?id=49020

  • src/WebGraphicsContext3DDefaultImpl.cpp: Remove DEPTH_STENCIL_ATTACHMENT emulation at this level.

2010-11-04 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Need to simulate DEPTH_STENCIL in framebufferRenderbuffer / getFramebufferAttachmentParameter
https://bugs.webkit.org/show_bug.cgi?id=49020

  • html/canvas/WebGLFramebuffer.cpp: (WebCore::WebGLFramebuffer::getAttachment): Return the attached renderbuffer/texture. (WebCore::WebGLFramebuffer::isIncomplete): Add an extra parameter deciding whether we should check internal format matching the attachment point or not. (WebCore::WebGLFramebuffer::onAccess): Pass extra parameter in isIncomplete.
  • html/canvas/WebGLFramebuffer.h:
  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::checkFramebufferStatus): Pass extra parameter in isIncomplete. (WebCore::WebGLRenderingContext::framebufferRenderbuffer): Emulate DEPTH_STENCIL_ATTACHMENT; re-attach previously conflicted buffers upon detachment. (WebCore::WebGLRenderingContext::getFramebufferAttachmentParameter): Throw an error when conflicted attachments exist. (WebCore::WebGLRenderingContext::renderbufferStorage): Map DEPTH_STENCIL to DEPTH24_STENCIL8.
  • platform/graphics/Extensions3D.h: Add DEPTH24_STENCIL8 enum and update the documentation.
  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp: (WebCore::GraphicsContext3D::framebufferRenderbuffer): Remove emulation code at this level.
13:27 Changeset [71448] by mihaip@chromium.org

2010-11-05 Mihai Parparita <mihaip@chromium.org>

Unreviewed; test_expectations fix.

Remove three tests that are no longer flaky. Update a comment about a
test that fails due to V8 differences.

  • platform/chromium/test_expectations.txt:
13:26 Changeset [71447] by darin@chromium.org

2010-11-05 Darin Fisher <darin@chromium.org>

Pull chromium@65229 to fix the build.

  • DEPS:
13:08 Changeset [71446] by mihaip@chromium.org

2010-11-05 Mihai Parparita <mihaip@chromium.org>

Unreviewed expectation update for fast/events/context-no-deselect.html.

Add missing chromium-linux expectations.

  • platform/chromium-linux/fast/events/context-no-deselect-expected.checksum: Added.
  • platform/chromium-linux/fast/events/context-no-deselect-expected.png: Added.
  • platform/chromium/test_expectations.txt:
12:55 Changeset [71445] by commit-queue@webkit.org

2010-11-05 Chris Guillory <chris.guillory@google.com>

Reviewed by Chris Fleizach.

Keep a reference to the scrollbar in accessibility scrollbar.
https://bugs.webkit.org/show_bug.cgi?id=48896

  • accessibility/AccessibilityScrollbar.h: (WebCore::AccessibilityScrollbar::scrollbar):
12:42 Changeset [71444] by oliver@apple.com

2010-11-05 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

Website consistently crashing TOT in JIT::execute() on news.com.au
https://bugs.webkit.org/show_bug.cgi?id=48954

The problem here was the strict pass of this conversion was loading the
this structure into one register but doing the flags check off a different
register. This is clearly wrong. I have been unable to trigger the crash
with a reduction, but I've added an assertion to the this conversion to
attempt to make it more readily catchable in future.

  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_convert_this_strict):
  • jit/JITOpcodes32_64.cpp: (JSC::JIT::emit_op_convert_this_strict):
  • jit/JITStubs.cpp: (JSC::DEFINE_STUB_FUNCTION):
12:37 Changeset [71443] by tony@chromium.org

2010-11-05 Tony Chang <tony@chromium.org>

Reviewed by David Levin.

cleanup style in TestNetscapePlugIn/PluginObject.cpp
https://bugs.webkit.org/show_bug.cgi?id=49044

  • DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp: (getPluginClass): (pluginGetProperty): (pluginSetProperty): (variantToIdentifier): (testCallback): (getURL): (getURLNotify): (testInvokeDefault): (testGetProperty): (testDocumentOpen): (testWindowOpen): (pluginInvoke): (handleCallback): (notifyStream):
  • DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
12:22 Changeset [71442] by chang.shu@nokia.com

2010-11-05 Chang Shu <chang.shu@nokia.com>

Reviewed by Antonio Gomes.

Add support for <select> element in single selection mode. We use space to
trigger arrow key handling for selection change or spatial navigation.
https://bugs.webkit.org/show_bug.cgi?id=48937

  • fast/events/spatial-navigation/resources/spatial-navigation-utils.js: (doMove):
  • fast/events/spatial-navigation/snav-single-select-expected.txt:
  • fast/events/spatial-navigation/snav-single-select.html:

2010-11-05 Chang Shu <chang.shu@nokia.com>

Reviewed by Antonio Gomes.

Add support for <select> element in single selection mode. We use space to
trigger arrow key handling for selection change or spatial navigation.
https://bugs.webkit.org/show_bug.cgi?id=48937

  • dom/SelectElement.cpp: (WebCore::isSpatialNavigationEnabled): (WebCore::SelectElement::menuListDefaultEventHandler): (WebCore::SelectElement::listBoxDefaultEventHandler):
12:02 Changeset [71441] by eric@webkit.org

2010-11-05 Eric Seidel <eric@webkit.org>

Reviewed by David Levin.

Add QueueStatusServer/init.py so others can run the QueueStatusServer tests
https://bugs.webkit.org/show_bug.cgi?id=49032

I wrote this file as part of bug 47847, but I forgot to commit it.
No one else noticed it missing because test-webkitpy knows how
to recover in the case where it can't import QueueStatusServer
(which generally occurs due to not having installed the AppEngine SDK).

  • QueueStatusServer/init.py: Added.
  • QueueStatusServer/model/workitems_unittest.py:
    • Remove a test which fails. This was probably landed (by me) from my other machine, which since this init.py was missing I never noticed the failure and landed this invalid test. Sadly we can't really test remove_work_item as it depends on .key() working. .key() will throw unless the object has already been saved it seems. This may be a mis-design in our remove_work_item implementation, but for now, just removing the test.
11:44 Changeset [71440] by darin@chromium.org

2010-11-05 Darin Fisher <darin@chromium.org>

Reviewed by Nate Chapin.

Replace deprecated TargetIsSub{Frame,Resource} with TargetIsSub{frame,resource}.
https://bugs.webkit.org/show_bug.cgi?id=49074

  • public/WebURLRequest.h:
  • src/FrameLoaderClientImpl.cpp:
11:32 Changeset [71439] by mihaip@chromium.org

2010-11-05 Mihai Parparita <mihaip@chromium.org>

Unreviewed expectations update for fast/events/click-count.html; it's no longer slow since r46779 sped it up.

  • platform/chromium/test_expectations.txt:
11:25 Changeset [71438] by mihaip@chromium.org

2010-11-05 Mihai Parparita <mihaip@chromium.org>

Unreviewed expectations update for fast/events/option-tab.html; it no longer crashes.

  • platform/chromium/test_expectations.txt:
11:24 Changeset [71437] by commit-queue@webkit.org

2010-11-05 Charlie Reis <creis@chromium.org>

Reviewed by Darin Fisher.

Need to expose HistoryController::previousItem() for Chromium WebKit API.
https://bugs.webkit.org/show_bug.cgi?id=48809

  • loader/HistoryController.h:

2010-11-05 Charlie Reis <creis@chromium.org>

Reviewed by Darin Fisher.

WebFrame::previousHistoryItem() should return last committed item.
https://bugs.webkit.org/show_bug.cgi?id=48809

  • src/WebFrameImpl.cpp:
11:15 Changeset [71436] by aroben@apple.com

Implement PluginInfoStore::shouldUsePlugin on Windows

Fixes <http://webkit.org/b/43509> <rdar://problem/8273822> WebKit2
should refuse to load the same plugins that old-WebKit refuses to load

Reviewed by Anders Carlsson.

  • UIProcess/Plugins/win/PluginInfoStoreWin.cpp:

(WebKit::fileVersion): Helper function to construct a 64-bit file
version from two 32-bit numbers.
(WebKit::PluginInfoStore::getPluginInfo): Ported code from
WebCore::PluginPackage::fetchInfo to get the plugin's version. We now
store it in Plugin::fileVersion.

(WebKit::isOldWindowsMediaPlayerPlugin):
(WebKit::isNewWindowsMediaPlayerPlugin):
Added these helpers. The code came from
WebCore::PluginDatabase::getPluginPathsInDirectories.

(WebKit::PluginInfoStore::shouldUsePlugin): Implemented. The code was
ported from WebCore::PluginDatabase::getPluginPathsInDirectories and
WebCore::PluginPackage::isPluginBlacklisted.

11:14 Changeset [71435] by aroben@apple.com

Operate on m_plugins directly in PluginInfoStore::shouldUsePlugin

We'll need to operate on m_plugins if we ever want to unload an
already-loaded plugin before loading the new one.

Fixes <http://webkit.org/b/49076> loadedPlugins parameter to
PluginInfoStore::shouldUsePlugin is redundant

Reviewed by Anders Carlsson.

  • UIProcess/Plugins/PluginInfoStore.cpp:

(WebKit::PluginInfoStore::loadPlugin):

  • UIProcess/Plugins/PluginInfoStore.h:
  • UIProcess/Plugins/gtk/PluginInfoStoreGtk.cpp:

(WebKit::PluginInfoStore::shouldUsePlugin):

  • UIProcess/Plugins/mac/PluginInfoStoreMac.mm:

(WebKit::PluginInfoStore::shouldUsePlugin):

  • UIProcess/Plugins/qt/PluginInfoStoreQt.cpp:

(WebKit::PluginInfoStore::shouldUsePlugin):

  • UIProcess/Plugins/win/PluginInfoStoreWin.cpp:

(WebKit::PluginInfoStore::shouldUsePlugin):
Removed the loadedPlugins parameter from shouldUsePlugin. The single
implementation (Mac) now uses m_plugins directly.

11:08 Changeset [71434] by bweinstein@apple.com

Assertion failure in PluginStream::~PluginStream when running userscripts/user-script-plugin-document.html
https://bugs.webkit.org/show_bug.cgi?id=48751
<rdar://problem/8615536>

Reviewed by Anders Carlsson.

WebKit/win:

Always call committedLoad in WebFrameLoaderClient::finishedLoading, even if we have a manual loader. We were
running into a case where we were trying to load an empty plugin document, which uses a manual loader, and
PluginStream::didFinishLoading was never being called. The stream was never being stopped, making us fire
an assert in the PluginStream destructor.

  • WebCoreSupport/WebFrameLoaderClient.cpp:

(WebFrameLoaderClient::finishedLoading):

LayoutTests:

Unskip userscripts/user-script-plugin-document.html because it is passing now.

  • platform/win/Skipped:
11:01 Changeset [71433] by bweinstein@apple.com

userscripts/user-script-*-document.html tests are flaky on Windows
https://bugs.webkit.org/show_bug.cgi?id=45980

Reviewed by Eric Carlson.

We can't use counting.mp4 as our video file to create a video document, because on Windows counting.mp4
is opened in Windows Explorer or Quicktime instead of Safari. This bug is being tracked by
<https://bugs.webkit.org/show_bug.cgi?id=25220>.

This patch switches user-script-video-document.html to use silence-loop.mov instead of counting.mp4,
which creates a video document on both Mac and Windows.

  • userscripts/resources/counting.mp4: Removed.
  • userscripts/resources/silence-loop.mov: Added.
  • userscripts/user-script-video-document-expected.txt:
  • userscripts/user-script-video-document.html:
10:58 Changeset [71432] by andersca@apple.com

Implement pluginElementNPObject
https://bugs.webkit.org/show_bug.cgi?id=49077

Reviewed by Adam Roben.

WebKit2:

  • PluginProcess/PluginControllerProxy.cpp:

(WebKit::PluginControllerProxy::pluginElementNPObject):
Send the GetPluginElementNPObject message.

  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::getPluginElementNPObject):
Get the plug-in element NPObject and expose it to the other side of the connection.

  • WebProcess/Plugins/PluginProxy.messages.in:

Add GetPluginElementNPObject.

LayoutTests:

Remove now passing test.

  • platform/mac-snowleopard/Skipped:
10:43 Changeset [71431] by rniwa@webkit.org

2010-11-05 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

Crash in ApplyStyleCommand::surroundNodeRangeWithElement
https://bugs.webkit.org/show_bug.cgi?id=48581

The crash was caused by a false assertion that we can always recover selection in
ApplyStyleCommand::removeInlineStyle. Fixed the crash by removing the assertion
and adding an early exit to the call site. Also converted raw pointers to RefPtr
in surroundNodeRangeWithElement and addInlineStyleIfNeeded.

Test (non-Mac platforms): editing/style/iframe-onload-crash.html

  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyInlineStyle): (WebCore::ApplyStyleCommand::removeInlineStyle): (WebCore::ApplyStyleCommand::surroundNodeRangeWithElement): (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded):
  • editing/ApplyStyleCommand.h:

2010-11-04 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

Re-enabled editing/style/iframe-onload-crash.html on Chromium, Qt, and Windows platforms.

  • platform/chromium/test_expectations.txt:
  • platform/qt/Skipped:
  • platform/win/Skipped:
10:38 Changeset [71430] by andersca@apple.com

Implement NP_RemoveProperty and NP_Enumerate
https://bugs.webkit.org/show_bug.cgi?id=49046

Reviewed by Oliver Hunt.

WebKit2:

  • Shared/Plugins/NPObjectMessageReceiver.cpp:

(WebKit::NPObjectMessageReceiver::removeProperty):
Call the removeProperty NPClass function.

(WebKit::NPObjectMessageReceiver::enumerate):
Call the enumerate NPClass function.

  • Shared/Plugins/NPObjectMessageReceiver.messages.in:

Add RemoveProperty and Enumerate messages.

  • Shared/Plugins/NPObjectProxy.cpp:

(WebKit::NPObjectProxy::removeProperty):
Send the RemoveProperty message.

(WebKit::NPObjectProxy::enumerate):
Send the Enumerate message.

(WebKit::NPObjectProxy::NP_RemoveProperty):
Call removeProperty.

(WebKit::NPObjectProxy::NP_Enumerate):
Call enumerate.

LayoutTests:

Remove now passing tests.

  • platform/mac-wk2/Skipped:
10:35 Changeset [71429] by zmo@google.com

2010-11-05 Zhenyao Mo <zmo@google.com>

Unreviewed, update webgl test expectations.

  • platform/chromium/test_expectations.txt:
10:25 Changeset [71428] by zmo@google.com

2010-11-05 Zhenyao Mo <zmo@google.com>

Unreviewed, update webgl test expectations.

  • platform/chromium/test_expectations.txt:
10:05 Changeset [71427] by cmarrin@apple.com

Fix for GTK build broken by http://trac.webkit.org/changeset/71424

10:02 Changeset [71426] by ap@apple.com

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=49008
<rdar://problem/7906226> Frequent crashes on mail.yahoo.co.jp

WebCore:

Instance::m_runtimeObject used to be zeroed out by RuntimeObject destructor. But the
destructor may not be called immediately - GC first marks an object as dead, and only
destroys it when its cell is overwritten. So, m_runtimeObject would keep pointing to a dead
object.

Functions in JSPluginElementFunctions.cpp put the RuntimeObject on stack for later use,
but if it's already dead, it can be overwritten before use.

The solution is of course to use WeakGCPtr, which returns 0 for dead objects.

  • bridge/jsc/BridgeJSC.cpp: (JSC::Bindings::Instance::Instance): (JSC::Bindings::Instance::~Instance): (JSC::Bindings::Instance::createRuntimeObject): (JSC::Bindings::Instance::willDestroyRuntimeObject): (JSC::Bindings::Instance::willInvalidateRuntimeObject):
  • bridge/jsc/BridgeJSC.h:
  • bridge/runtime_object.cpp: (JSC::Bindings::RuntimeObject::~RuntimeObject): (JSC::Bindings::RuntimeObject::invalidate):

WebKit:

Callers of NetscapePluginInstanceProxy::waitForReply() are not prepared to be deleted during
the call, unless it returns 0. There are two reasons for NetscapePluginInstanceProxy to be
deleted during wait:

  • plugin crashed;
  • plugin was stopped (e.g. due to a DOM modification performed by another reply that came in while waiting).

We didn't recognize the latter.

  • Plugins/Hosted/NetscapePluginHostProxy.mm: (WebKit::PluginDestroyDeferrer::~PluginDestroyDeferrer):
  • Plugins/Hosted/NetscapePluginInstanceProxy.h: (WebKit::NetscapePluginInstanceProxy::waitForReply):
  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::didCallPluginFunction):
09:55 Changeset [71425] by weinig@apple.com

Fix failing python tests.

  • Scripts/webkit2/messages.py:
  • Scripts/webkit2/messages_unittest.py:
09:38 Changeset [71424] by cmarrin@apple.com

2010-11-05 Chris Marrin <cmarrin@apple.com>

Reviewed by Simon Fraser.

Make suspendAnimations/resumeAnimations and setCSSAnimations traverse through subframes and remember state
https://bugs.webkit.org/show_bug.cgi?id=46945

Add new funtions to suspend and resume animations. The go through all subframes and suspend or resume them
recursively.

Test: animations/stop-animation-on-suspend.html

  • WebCore.exp.in:
  • page/Frame.cpp: (WebCore::Frame::suspendAnimations): (WebCore::Frame::resumeAnimations):
  • page/Frame.h:
09:18 Changeset [71423] by weinig@apple.com

Generate the messages sent to the WebProcessProxy
https://bugs.webkit.org/show_bug.cgi?id=49062

Reviewed by Adam Roben..

  • Platform/CoreIPC/MessageID.h:

Temporarily add MessageClassWebProcessProxyLegacy while we still can't
support GetPluginProcessConnection (and deferred sync replies) in the
general mechanism.

  • Scripts/webkit2/messages.py:

Add support for WebCore::PluginData and WebKit::WebNavigationDataStore.

  • Shared/CoreIPCSupport/WebProcessProxyMessageKinds.h:

Remove now unused kinds. Rename to MessageClassWebProcessProxyLegacy.

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::getPluginPath):
(WebKit::WebProcessProxy::addBackForwardItem):
(WebKit::WebProcessProxy::didNavigateWithNavigationData):
(WebKit::WebProcessProxy::didPerformClientRedirect):
(WebKit::WebProcessProxy::didPerformServerRedirect):
(WebKit::WebProcessProxy::didUpdateHistoryTitle):
(WebKit::WebProcessProxy::didReceiveMessage):
(WebKit::WebProcessProxy::didReceiveSyncMessage):
(WebKit::WebProcessProxy::didDestroyFrame):

  • UIProcess/WebProcessProxy.h:
  • UIProcess/WebProcessProxy.messages.in: Added.

Move implementations to their own functions.

  • WebProcess/Plugins/PluginProcessConnectionManager.cpp:

(WebKit::PluginProcessConnectionManager::getPluginProcessConnection):
Change to use WebProcessProxyLegacyMessage.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::updateGlobalHistory):
(WebKit::WebFrameLoaderClient::updateGlobalHistoryRedirectLinks):
(WebKit::WebFrameLoaderClient::setTitle):

  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:

(WebKit::WebPlatformStrategies::populatePluginCache):

  • WebProcess/WebPage/WebBackForwardListProxy.cpp:

(WebKit::updateBackForwardItem):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::createPlugin):

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::addVisitedLink):
(WebKit::WebProcess::removeWebFrame):
Use generated messages.

  • DerivedSources.make:
  • DerivedSources.pro:
  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:

Add new files.

08:45 Changeset [71422] by senorblanco@chromium.org

2010-11-05 Stephen White <senorblanco@chromium.org>

Unreviewed; test_expectations fix.

Cleaning up the chromium-gpu test expectations after the switch to DRT.

  • platform/chromium-gpu/test_expectations.txt:
08:40 Changeset [71421] by aroben@apple.com

Update expected results for two tests on Windows

  • platform/win/fast/dom/HTMLMeterElement/meter-element-expected.png:
  • platform/win/fast/dom/HTMLMeterElement/meter-element-expected.txt:
  • platform/win/fast/dom/HTMLProgressElement/progress-element-with-child-crash-expected.txt: Added.
07:59 Changeset [71420] by ossy@webkit.org

Unreviewed.

[Qt] Add platform specific expected results for new passing tests introduced in r71382.
Compared to Mac png files and Mac expected files.

  • platform/qt/fast/table/027-vertical-expected.checksum: Added.
  • platform/qt/fast/table/027-vertical-expected.png: Added.
  • platform/qt/fast/table/027-vertical-expected.txt: Added.
  • platform/qt/fast/table/028-vertical-expected.checksum: Added.
  • platform/qt/fast/table/028-vertical-expected.png: Added.
  • platform/qt/fast/table/028-vertical-expected.txt: Added.
  • platform/qt/fast/table/035-vertical-expected.checksum: Added.
  • platform/qt/fast/table/035-vertical-expected.png: Added.
  • platform/qt/fast/table/035-vertical-expected.txt: Added.
  • platform/qt/fast/table/038-vertical-expected.checksum: Added.
  • platform/qt/fast/table/038-vertical-expected.png: Added.
  • platform/qt/fast/table/038-vertical-expected.txt: Added.
  • platform/qt/fast/table/040-vertical-expected.checksum: Added.
  • platform/qt/fast/table/040-vertical-expected.png: Added.
  • platform/qt/fast/table/040-vertical-expected.txt: Added.
  • platform/qt/fast/table/auto-with-percent-height-vertical-expected.checksum: Added.
  • platform/qt/fast/table/auto-with-percent-height-vertical-expected.png: Added.
  • platform/qt/fast/table/auto-with-percent-height-vertical-expected.txt: Added.
  • platform/qt/fast/table/border-collapsing/001-vertical-expected.checksum: Added.
  • platform/qt/fast/table/border-collapsing/001-vertical-expected.png: Added.
  • platform/qt/fast/table/border-collapsing/001-vertical-expected.txt: Added.
  • platform/qt/fast/table/border-collapsing/002-vertical-expected.checksum: Added.
  • platform/qt/fast/table/border-collapsing/002-vertical-expected.png: Added.
  • platform/qt/fast/table/border-collapsing/002-vertical-expected.txt: Added.
  • platform/qt/fast/table/border-collapsing/003-vertical-expected.checksum: Added.
  • platform/qt/fast/table/border-collapsing/003-vertical-expected.png: Added.
  • platform/qt/fast/table/border-collapsing/003-vertical-expected.txt: Added.
  • platform/qt/fast/table/border-collapsing/004-vertical-expected.checksum: Added.
  • platform/qt/fast/table/border-collapsing/004-vertical-expected.png: Added.
  • platform/qt/fast/table/border-collapsing/004-vertical-expected.txt: Added.
  • platform/qt/fast/table/border-collapsing/border-collapsing-head-foot-vertical-expected.checksum: Added.
  • platform/qt/fast/table/border-collapsing/border-collapsing-head-foot-vertical-expected.png: Added.
  • platform/qt/fast/table/border-collapsing/border-collapsing-head-foot-vertical-expected.txt: Added.
  • platform/qt/fast/table/border-collapsing/equal-precedence-resolution-vertical-expected.checksum: Added.
  • platform/qt/fast/table/border-collapsing/equal-precedence-resolution-vertical-expected.png: Added.
  • platform/qt/fast/table/border-collapsing/equal-precedence-resolution-vertical-expected.txt: Added.
  • platform/qt/fast/table/border-collapsing/rtl-border-collapsing-vertical-expected.checksum: Added.
  • platform/qt/fast/table/border-collapsing/rtl-border-collapsing-vertical-expected.png: Added.
  • platform/qt/fast/table/border-collapsing/rtl-border-collapsing-vertical-expected.txt: Added.
  • platform/qt/fast/table/fixed-with-auto-with-colspan-vertical-expected.checksum: Added.
  • platform/qt/fast/table/fixed-with-auto-with-colspan-vertical-expected.png: Added.
  • platform/qt/fast/table/fixed-with-auto-with-colspan-vertical-expected.txt: Added.
  • platform/qt/fast/table/growCellForImageQuirk-vertical-expected.checksum: Added.
  • platform/qt/fast/table/growCellForImageQuirk-vertical-expected.png: Added.
  • platform/qt/fast/table/growCellForImageQuirk-vertical-expected.txt: Added.
  • platform/qt/fast/table/height-percent-test-vertical-expected.checksum: Added.
  • platform/qt/fast/table/height-percent-test-vertical-expected.png: Added.
  • platform/qt/fast/table/height-percent-test-vertical-expected.txt: Added.
  • platform/qt/fast/table/percent-widths-stretch-vertical-expected.checksum: Added.
  • platform/qt/fast/table/percent-widths-stretch-vertical-expected.png: Added.
  • platform/qt/fast/table/percent-widths-stretch-vertical-expected.txt: Added.
  • platform/qt/fast/table/rowspan-paint-order-vertical-expected.checksum: Added.
  • platform/qt/fast/table/rowspan-paint-order-vertical-expected.png: Added.
  • platform/qt/fast/table/rowspan-paint-order-vertical-expected.txt: Added.
  • platform/qt/fast/table/table-display-types-vertical-expected.checksum: Added.
  • platform/qt/fast/table/table-display-types-vertical-expected.png: Added.
  • platform/qt/fast/table/table-display-types-vertical-expected.txt: Added.
07:48 Changeset [71419] by aroben@apple.com

Teach check-webkit-style about TestNetscapePlugIn

Fixes <http://webkit.org/b/49030> check-webkit-style is ignorant of
TestNetscapePlugIn's coding conventions

Reviewed by John Sullivan.

  • Scripts/webkitpy/style/checker.py: Lump TestNetscapePlugIn in with

WebKitAPITest and TestWebKitAPI in having different include order and
naming conventions than WebCore. Added some comments about why the
exceptions exist.

07:47 Changeset [71418] by aroben@apple.com

Add a test that shows that windowed plugins are able to paint

Somehow we never had a test for this before.

Fixes <http://webkit.org/b/49029> Should add a test that shows
windowed plugins can paint

Reviewed by Jon Honeycutt.

WebKitTools:

  • DumpRenderTree/TestNetscapePlugIn/Tests/win/DrawsGradient.cpp: Added.

(DrawsGradient::DrawsGradient):
(DrawsGradient::wndProc): We handle the WM_PAINT and WM_PRINTCLIENT messages.

(DrawsGradient::onPaint):
(DrawsGradient::onPrintClient):
These both just call through to paint.

(DrawsGradient::paint): Fills our client area with some gradients.

  • DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Link

against Msimg32.lib for ::GradientFill and added DrawsGradient.

  • DumpRenderTree/win/PixelDumpSupportWin.cpp:

(createBitmapContextFromWebView): Use WM_PRINT instead of
WM_PRINTCLIENT so that ::DefWindowProc will send
WM_PRINT/WM_PRINTCLIENT messages to the WebView's child windows.
Replaced kCGImageAlphaPremultipledFirst with kCGImageAlphaNoneSkipFirst
because GDI doesn't support alpha and kCGImageBitmapOrder32Little with
kCGImageBitmapOrder32Host because, who knows, maybe someday Windows
will run on a big-endian platform.

LayoutTests:

  • platform/win/platform/win/plugins/draws-gradient-expected.checksum: Added.
  • platform/win/platform/win/plugins/draws-gradient-expected.png: Added.
  • platform/win/platform/win/plugins/draws-gradient-expected.txt: Added.
  • platform/win/plugins/draws-gradient.html: Added.
07:46 Changeset [71417] by aroben@apple.com

Extract much of NPNInvalidateRectInvalidatesWindow's code into a WindowedPluginTest base class

The base class takes care of subclassing the plugin's window so that a
custom WNDPROC is called. This will make it easier to write tests that
need to handle window messages.

Fixes <http://webkit.org/b/49028> It's hard to write a PluginTest with
a custom WNDPROC

Reviewed by Jon Honeycutt.

  • DumpRenderTree/TestNetscapePlugIn/Tests/win/NPNInvalidateRectInvalidatesWindow.cpp:

(NPNInvalidateRectInvalidatesWindow::NPNInvalidateRectInvalidatesWindow):
(NPNInvalidateRectInvalidatesWindow::NPP_SetWindow):
(NPNInvalidateRectInvalidatesWindow::wndProc):
(NPNInvalidateRectInvalidatesWindow::testInvalidateRect):
Moved code from here to WindowedPluginTest. Changed to use window()
instead of m_window.

  • DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:

Added WindowedPluginTest and added TestNetscapePlugIn/win to the
include path. Also reordered the include path to make a little more
sense and simplified the entry that added TestNetscapePlugIn itself to
the include path.

  • DumpRenderTree/TestNetscapePlugIn/win/WindowedPluginTest.cpp: Added.

(WindowedPluginTest::WindowedPluginTest):
(WindowedPluginTest::NPP_SetWindow):
(WindowedPluginTest::staticWndProc):

  • DumpRenderTree/TestNetscapePlugIn/win/WindowedPluginTest.h: Added.

(WindowedPluginTest::window):
Code came from NPNInvalidateRectInvalidatesWindow.

07:46 Changeset [71416] by aroben@apple.com

Use a window region to clip windowed plugins

Fixes <http://webkit.org/b/49024> <rdar://problem/8487847> Windowed
plugins aren't clipped in WebKit2 on Windows

Reviewed by Jon Honeycutt.

WebKit2:

  • WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:

(WebKit::registerPluginView): Removed the CS_PARENTDC style. This style
makes Windows ignore the window region and always clip to the parent
window. Also pass WebKit.dll's HINSTANCE as part of the WNDCLASSW
struct so that the window class will be specific to WebKit.dll rather
than to WebKit2WebProcess.exe. This is useful for testing, but also
more pedantically correct.
(WebKit::setWindowRegion): Helper function to set a window region and
deal with ownership of the HRGN correctly.
(WebKit::NetscapePlugin::platformGeometryDidChange): Make an HRGN that
corresponds to m_clipRect and set it on the plugin's window.

WebKitTools:

Add a plugin test to show that windowed plugins are clipped correctly

  • DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowRegionIsSetToClipRect.cpp: Added.

(WindowRegionIsSetToClipRect::WindowRegionIsSetToClipRect): Initialize members.
(WindowRegionIsSetToClipRect::NPP_SetWindow): Check that our window
region matches the clip rect we know we should have based on
window-region-is-set-to-clip-rect.html, and check that our window class
doesn't have the CS_PARENTDC style.

  • DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:

Added WindowRegionIsSetToClipRect.

LayoutTests:

Add a test to show that windowed plugins are clipped correctly

  • platform/win/plugins/window-region-is-set-to-clip-rect-expected.txt: Added.
  • platform/win/plugins/window-region-is-set-to-clip-rect.html: Added.
07:29 Changeset [71415] by pfeldman@chromium.org

2010-11-05 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Crash in InspectorDOMAgent::innerParentNode.
https://bugs.webkit.org/show_bug.cgi?id=49054

  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::setOuterHTML):
07:25 Changeset [71414] by ossy@webkit.org

Unreviewed.

[Qt] Add platform specific expected results for new passing tests.
Compared to Mac png files and Mac expected files.

  • platform/qt/fast/block/basic/truncation-rtl-expected.checksum: Added.
  • platform/qt/fast/block/basic/truncation-rtl-expected.png: Added.
  • platform/qt/fast/block/basic/truncation-rtl-expected.txt: Added.
  • platform/qt/fast/blockflow/background-horizontal-bt-expected.checksum: Added.
  • platform/qt/fast/blockflow/background-horizontal-bt-expected.png: Added.
  • platform/qt/fast/blockflow/background-horizontal-bt-expected.txt: Added.
  • platform/qt/fast/blockflow/background-vertical-lr-expected.checksum: Added.
  • platform/qt/fast/blockflow/background-vertical-lr-expected.png: Added.
  • platform/qt/fast/blockflow/background-vertical-lr-expected.txt: Added.
  • platform/qt/fast/blockflow/background-vertical-rl-expected.checksum: Added.
  • platform/qt/fast/blockflow/background-vertical-rl-expected.png: Added.
  • platform/qt/fast/blockflow/background-vertical-rl-expected.txt: Added.
  • platform/qt/fast/blockflow/basic-vertical-line-expected.checksum: Added.
  • platform/qt/fast/blockflow/basic-vertical-line-expected.png: Added.
  • platform/qt/fast/blockflow/basic-vertical-line-expected.txt: Added.
  • platform/qt/fast/blockflow/body-direction-propagation-blocked-expected.checksum: Added.
  • platform/qt/fast/blockflow/body-direction-propagation-blocked-expected.png: Added.
  • platform/qt/fast/blockflow/body-direction-propagation-blocked-expected.txt: Added.
  • platform/qt/fast/blockflow/body-direction-propagation-expected.checksum: Added.
  • platform/qt/fast/blockflow/body-direction-propagation-expected.png: Added.
  • platform/qt/fast/blockflow/body-direction-propagation-expected.txt: Added.
  • platform/qt/fast/blockflow/body-writing-mode-propagation-blocked-expected.checksum: Added.
  • platform/qt/fast/blockflow/body-writing-mode-propagation-blocked-expected.png: Added.
  • platform/qt/fast/blockflow/body-writing-mode-propagation-blocked-expected.txt: Added.
  • platform/qt/fast/blockflow/body-writing-mode-propagation-expected.checksum: Added.
  • platform/qt/fast/blockflow/body-writing-mode-propagation-expected.png: Added.
  • platform/qt/fast/blockflow/body-writing-mode-propagation-expected.txt: Added.
  • platform/qt/fast/blockflow/border-radius-clipping-vertical-lr-expected.checksum: Added.
  • platform/qt/fast/blockflow/border-radius-clipping-vertical-lr-expected.png: Added.
  • platform/qt/fast/blockflow/border-radius-clipping-vertical-lr-expected.txt: Added.
  • platform/qt/fast/blockflow/box-shadow-horizontal-bt-expected.checksum: Added.
  • platform/qt/fast/blockflow/box-shadow-horizontal-bt-expected.png: Added.
  • platform/qt/fast/blockflow/box-shadow-horizontal-bt-expected.txt: Added.
  • platform/qt/fast/blockflow/box-shadow-vertical-lr-expected.checksum: Added.
  • platform/qt/fast/blockflow/box-shadow-vertical-lr-expected.png: Added.
  • platform/qt/fast/blockflow/box-shadow-vertical-lr-expected.txt: Added.
  • platform/qt/fast/blockflow/box-shadow-vertical-rl-expected.checksum: Added.
  • platform/qt/fast/blockflow/box-shadow-vertical-rl-expected.png: Added.
  • platform/qt/fast/blockflow/box-shadow-vertical-rl-expected.txt: Added.
  • platform/qt/fast/blockflow/english-bt-text-expected.checksum: Added.
  • platform/qt/fast/blockflow/english-bt-text-expected.png: Added.
  • platform/qt/fast/blockflow/english-bt-text-expected.txt: Added.
  • platform/qt/fast/blockflow/english-lr-text-expected.checksum: Added.
  • platform/qt/fast/blockflow/english-lr-text-expected.png: Added.
  • platform/qt/fast/blockflow/english-lr-text-expected.txt: Added.
  • platform/qt/fast/blockflow/english-rl-text-expected.checksum: Added.
  • platform/qt/fast/blockflow/english-rl-text-expected.png: Added.
  • platform/qt/fast/blockflow/english-rl-text-expected.txt: Added.
  • platform/qt/fast/borders/border-radius-inline-flow-expected.checksum: Added.
  • platform/qt/fast/borders/border-radius-inline-flow-expected.png: Added.
  • platform/qt/fast/borders/border-radius-inline-flow-expected.txt: Added.
  • platform/qt/fast/dom/HTMLMeterElement/meter-boundary-values-expected.checksum: Added.
  • platform/qt/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png: Added.
  • platform/qt/fast/dom/HTMLMeterElement/meter-boundary-values-expected.txt: Added.
  • platform/qt/fast/dom/gc-10-expected.checksum: Added.
  • platform/qt/fast/dom/gc-10-expected.png: Added.
  • platform/qt/fast/dom/gc-10-expected.txt: Added.
  • platform/qt/fast/transforms/rotated-transform-affects-scrolling-1-expected.checksum: Added.
  • platform/qt/fast/transforms/rotated-transform-affects-scrolling-1-expected.png: Added.
  • platform/qt/fast/transforms/rotated-transform-affects-scrolling-1-expected.txt: Added.
  • platform/qt/fast/transforms/rotated-transform-affects-scrolling-2-expected.checksum: Added.
  • platform/qt/fast/transforms/rotated-transform-affects-scrolling-2-expected.png: Added.
  • platform/qt/fast/transforms/rotated-transform-affects-scrolling-2-expected.txt: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.checksum: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.png: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt: Added.
  • platform/qt/svg/animations: Added.
  • platform/qt/svg/animations/repeatDur-zero-expected.checksum: Added.
  • platform/qt/svg/animations/repeatDur-zero-expected.png: Added.
  • platform/qt/svg/animations/repeatDur-zero-expected.txt: Added.
  • platform/qt/svg/custom/use-invalid-pattern-expected.checksum: Added.
  • platform/qt/svg/custom/use-invalid-pattern-expected.png: Added.
07:25 Changeset [71413] by pfeldman@chromium.org

2010-11-05 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: XHR logging in console should give complete view of resource.
https://bugs.webkit.org/show_bug.cgi?id=48998

Drive-by fixes: linkify line number to scripts panel, fall back to resources;
enable multiline console entry on shift modifier as well.


07:01 Changeset [71412] by jorlow@chromium.org

2010-10-27 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Steve Block.

Clean up IDBTransactionBackend/Coordinator
https://bugs.webkit.org/show_bug.cgi?id=48425

Get rid of obsolete id and thus we don't need the factory method
on IDBTransactionCoordinator that creates IDBTransactionBackends.

Add an assert to IDBTransactionBackend to make sure we're not in
the coordinator and then remove the coordinators ref counting link
to the transaction.

Have the transaction backend zero out refs to the database when its
done using it.

Existing tests provide coverage for this refactoring.

  • storage/IDBDatabaseBackendImpl.cpp: (WebCore::IDBDatabaseBackendImpl::setVersion): (WebCore::IDBDatabaseBackendImpl::transaction):
  • storage/IDBTransactionBackendImpl.cpp: (WebCore::IDBTransactionBackendImpl::create): (WebCore::IDBTransactionBackendImpl::IDBTransactionBackendImpl): (WebCore::IDBTransactionBackendImpl::~IDBTransactionBackendImpl): (WebCore::IDBTransactionBackendImpl::abort): (WebCore::IDBTransactionBackendImpl::commit):
  • storage/IDBTransactionBackendImpl.h:
  • storage/IDBTransactionBackendInterface.h:
  • storage/IDBTransactionCoordinator.cpp: (WebCore::IDBTransactionCoordinator::didStartTransaction): (WebCore::IDBTransactionCoordinator::didFinishTransaction): (WebCore::IDBTransactionCoordinator::isActive): (WebCore::IDBTransactionCoordinator::processStartedTransactions):
  • storage/IDBTransactionCoordinator.h:

2010-10-27 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Steve Block.

Clean up IDBTransactionBackend/Coordinator
https://bugs.webkit.org/show_bug.cgi?id=48425

Remove obsolete ::id() method.

  • public/WebIDBTransaction.h:
  • src/IDBTransactionBackendProxy.cpp:
  • src/IDBTransactionBackendProxy.h:
  • src/WebIDBTransactionImpl.cpp:
  • src/WebIDBTransactionImpl.h:
06:57 Changeset [71411] by jorlow@chromium.org

2010-10-27 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Steve Block.

IDBFactoryBackend's reference to IDBDatabaseBackend should be weak
https://bugs.webkit.org/show_bug.cgi?id=48416

The factory's lifetime is that of the application, so without making
this weak, IDBDatabaseBackend's will never be closed until the app
terminates.

  • storage/IDBDatabaseBackendImpl.cpp: (WebCore::IDBDatabaseBackendImpl::IDBDatabaseBackendImpl): (WebCore::IDBDatabaseBackendImpl::~IDBDatabaseBackendImpl):
  • storage/IDBDatabaseBackendImpl.h: (WebCore::IDBDatabaseBackendImpl::create):
  • storage/IDBFactoryBackendImpl.cpp: (WebCore::IDBFactoryBackendImpl::removeIDBDatabaseBackend): (WebCore::IDBFactoryBackendImpl::removeSQLiteDatabase): (WebCore::IDBFactoryBackendImpl::open):
  • storage/IDBFactoryBackendImpl.h:
05:25 Changeset [71410] by alex@webkit.org

2010-11-05 Alejandro G. Castro <alex@igalia.com>

Unreviewed, apparently some forms tests need different results in
the bots after the removing the font hinting.

  • platform/gtk/fast/dynamic/window-resize-scrollbars-test-expected.txt:
  • platform/gtk/fast/forms/001-expected.txt:
  • platform/gtk/fast/forms/003-expected.txt:
  • platform/gtk/fast/forms/004-expected.txt:
  • platform/gtk/fast/forms/HTMLOptionElement_label01-expected.txt:
  • platform/gtk/fast/forms/HTMLOptionElement_label02-expected.txt:
  • platform/gtk/fast/forms/HTMLOptionElement_label03-expected.txt:
  • platform/gtk/fast/forms/HTMLOptionElement_label04-expected.txt:
  • platform/gtk/fast/forms/HTMLOptionElement_label06-expected.txt:
  • platform/gtk/fast/forms/HTMLOptionElement_label07-expected.txt:
  • platform/gtk/fast/forms/control-restrict-line-height-expected.txt:
  • platform/gtk/fast/forms/disabled-select-change-index-expected.txt:
  • platform/gtk/fast/forms/form-element-geometry-expected.txt:
  • platform/gtk/fast/forms/menulist-deselect-update-expected.txt:
  • platform/gtk/fast/forms/menulist-narrow-width-expected.txt:
  • platform/gtk/fast/forms/menulist-no-overflow-expected.txt:
  • platform/gtk/fast/forms/menulist-restrict-line-height-expected.txt:
  • platform/gtk/fast/forms/menulist-separator-painting-expected.txt:
  • platform/gtk/fast/forms/menulist-style-color-expected.txt:
  • platform/gtk/fast/forms/menulist-width-change-expected.txt:
  • platform/gtk/fast/forms/option-script-expected.txt:
  • platform/gtk/fast/forms/option-strip-whitespace-expected.txt:
  • platform/gtk/fast/forms/select-baseline-expected.txt:
  • platform/gtk/fast/forms/select-change-listbox-to-popup-expected.txt:
  • platform/gtk/fast/forms/select-dirty-parent-pref-widths-expected.txt:
  • platform/gtk/fast/forms/select-disabled-appearance-expected.txt:
  • platform/gtk/fast/forms/select-initial-position-expected.txt:
  • platform/gtk/fast/forms/select-size-expected.txt:
  • platform/gtk/fast/forms/select-style-expected.txt:
  • platform/gtk/fast/forms/select-visual-hebrew-expected.txt:
  • platform/gtk/fast/forms/select-writing-direction-natural-expected.txt:
  • platform/gtk/fast/forms/stuff-on-my-optgroup-expected.txt:
  • platform/gtk/scrollbars/custom-scrollbar-with-incomplete-style-expected.txt:
  • platform/gtk/svg/custom/use-font-face-crash-expected.txt:
  • platform/gtk/svg/in-html/circle-expected.txt:
05:03 Changeset [71409] by kbalazs@webkit.org

[Qt][WK2] Left over files and shared memory segments
https://bugs.webkit.org/show_bug.cgi?id=48985

Reviewed by Andreas Kling.

  • Platform/qt/SharedMemoryQt.cpp:

(WebKit::SharedMemory::create): Force deletion of the QSharedMemory
object on terminate by connecting QCoreApplication::aboutToQuit with
deleteLater. Add the object to the CrashHandler as well to release the
shared memory segment even on crash.
(WebKit::SharedMemory::~SharedMemory):

  • Shared/qt/CrashHandler.cpp: Added.

CrashHandler has a container for QObjects that we want to
destroy on crash. When we got a signal that we interpret as
a crash then it destroys those objects.
(WebKit::CrashHandler::CrashHandler):
(WebKit::CrashHandler::signalHandler):
(WebKit::CrashHandler::deleteObjects):

  • Shared/qt/CrashHandler.h: Added.

(WebKit::CrashHandler::instance):
(WebKit::CrashHandler::didDelete):
(WebKit::CrashHandler::markForDeletionOnCrash):

  • UIProcess/Launcher/qt/ProcessLauncherQt.cpp:

(WebKit::ProcessLauncherHelper::ProcessLauncherHelper):
Add the object itself to the CrashHandler to close the QLocalServer
even on crash. Without that the QLocalServer leaves over socket files on the disk.
(WebKit::ProcessLauncherHelper::~ProcessLauncherHelper):

  • WebKit2.pro:
04:53 Changeset [71408] by jorlow@chromium.org

2010-10-27 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Steve Block.

IDBObjectStoreBackend and IDBIndexBackend should not depend on IDBDatabaseBackend
https://bugs.webkit.org/show_bug.cgi?id=48410

Break dependency cyles between IDBDatabaseBackend and the other classes listed.
This was causing memory leaks.

  • storage/IDBCursorBackendImpl.cpp: (WebCore::IDBCursorBackendImpl::IDBCursorBackendImpl): (WebCore::IDBCursorBackendImpl::updateInternal): (WebCore::IDBCursorBackendImpl::removeInternal): (WebCore::IDBCursorBackendImpl::database):
  • storage/IDBCursorBackendImpl.h: (WebCore::IDBCursorBackendImpl::create):
  • storage/IDBDatabaseBackendImpl.cpp: (WebCore::IDBDatabaseBackendImpl::createObjectStore): (WebCore::IDBDatabaseBackendImpl::loadObjectStores):
  • storage/IDBIndexBackendImpl.cpp: (WebCore::IDBIndexBackendImpl::IDBIndexBackendImpl): (WebCore::IDBIndexBackendImpl::openCursorInternal): (WebCore::IDBIndexBackendImpl::sqliteDatabase):
  • storage/IDBIndexBackendImpl.h: (WebCore::IDBIndexBackendImpl::create): (WebCore::IDBIndexBackendImpl::storeName):
  • storage/IDBObjectStoreBackendImpl.cpp: (WebCore::IDBObjectStoreBackendImpl::IDBObjectStoreBackendImpl): (WebCore::IDBObjectStoreBackendImpl::createIndex): (WebCore::IDBObjectStoreBackendImpl::openCursorInternal): (WebCore::IDBObjectStoreBackendImpl::loadIndexes): (WebCore::IDBObjectStoreBackendImpl::sqliteDatabase):
  • storage/IDBObjectStoreBackendImpl.h: (WebCore::IDBObjectStoreBackendImpl::create):
04:44 Changeset [71407] by philn@webkit.org

2010-11-05 Philippe Normand <pnormand@igalia.com>

Unreviewed, skipping crashing svg test.

[GTK] svg/animations/animate-path-nested-transforms.html crashes
https://bugs.webkit.org/show_bug.cgi?id=49065

  • platform/gtk/Skipped:
04:36 Changeset [71406] by alex@webkit.org

2010-11-05 Alejandro G. Castro <alex@igalia.com>

Reviewed by Martin Robinson.

[GTK] Avoid font hinting in the DRT
https://bugs.webkit.org/show_bug.cgi?id=48548

Rebaseline the test results after removing the font hinting.

  • platform/gtk/http/tests/misc/slow-loading-mask-expected.txt:
  • platform/gtk/fast/multicol/float-multicol-expected.txt:
  • platform/gtk/fast/multicol/float-paginate-complex-expected.txt:
  • platform/gtk/fast/multicol/float-paginate-expected.txt:
  • platform/gtk/fast/multicol/layers-in-multicol-expected.txt:
  • platform/gtk/fast/multicol/layers-split-across-columns-expected.txt:
  • platform/gtk/fast/multicol/margin-collapse-expected.txt:
  • platform/gtk/fast/multicol/max-height-columns-block-expected.txt:
  • platform/gtk/fast/multicol/nested-columns-expected.txt:
  • platform/gtk/fast/multicol/paginate-block-replaced-expected.txt:
  • platform/gtk/fast/multicol/positioned-split-expected.txt:
  • platform/gtk/fast/multicol/positioned-with-constrained-height-expected.txt:
  • platform/gtk/fast/multicol/shadow-breaking-expected.txt:
  • platform/gtk/fast/multicol/single-line-expected.txt:
  • platform/gtk/fast/multicol/span/anonymous-style-inheritance-expected.txt:
  • platform/gtk/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.txt:
  • platform/gtk/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt:
  • platform/gtk/fast/multicol/span/span-as-immediate-child-property-removal-expected.txt:
  • platform/gtk/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.txt:
  • platform/gtk/fast/multicol/span/span-as-immediate-columns-child-expected.txt:
  • platform/gtk/fast/multicol/span/span-as-immediate-columns-child-removal-expected.txt:
  • platform/gtk/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.txt:
  • platform/gtk/fast/multicol/span/span-as-nested-columns-child-expected.txt:
  • platform/gtk/fast/multicol/span/span-margin-collapsing-expected.txt:
  • platform/gtk/fast/multicol/table-margin-collapse-expected.txt:
  • platform/gtk/fast/multicol/table-vertical-align-expected.txt:
  • platform/gtk/fast/multicol/unsplittable-inline-block-expected.txt:
  • platform/gtk/fast/overflow/line-clamp-expected.txt:
  • platform/gtk/fast/repaint/block-layout-inline-children-float-positioned-expected.txt:
  • platform/gtk/fast/repaint/block-layout-inline-children-replaced-expected.txt:
  • platform/gtk/fast/repaint/block-no-inflow-children-expected.txt:
  • platform/gtk/fast/repaint/fixed-child-move-after-scroll-expected.txt:
  • platform/gtk/fast/repaint/fixed-child-of-fixed-move-after-scroll-expected.txt:
  • platform/gtk/fast/repaint/fixed-child-of-transformed-move-after-scroll-expected.txt:
  • platform/gtk/fast/repaint/fixed-move-after-keyboard-scroll-expected.txt:
  • platform/gtk/fast/repaint/fixed-move-after-scroll-expected.txt:
  • platform/gtk/fast/repaint/layout-state-scrolloffset-expected.txt:
  • platform/gtk/fast/repaint/layout-state-scrolloffset2-expected.txt:
  • platform/gtk/fast/repaint/layout-state-scrolloffset3-expected.txt:
  • platform/gtk/fast/repaint/selection-gap-overflow-scroll-2-expected.txt:
  • platform/gtk/fast/repaint/stacked-diacritics-expected.txt:
  • platform/gtk/fast/table/early-table-layout-expected.txt:
  • platform/gtk/fast/table/fixed-table-with-percent-inside-percent-table-expected.txt:
  • platform/gtk/fast/table/fixed-table-with-percent-width-inside-auto-table-expected.txt:
  • platform/gtk/fast/table/fixed-table-with-percent-width-inside-div-expected.txt:
  • platform/gtk/fast/table/fixed-table-with-percent-width-inside-extra-large-div-expected.txt:
  • platform/gtk/fast/table/fixed-table-with-percent-width-inside-fixed-width-table-expected.txt:
  • platform/gtk/fast/table/fixed-table-with-small-percent-width-expected.txt:
  • platform/gtk/fast/text/backslash-to-yen-sign-dynamic-expected.txt:
  • platform/gtk/fast/text/backslash-to-yen-sign-euc-expected.txt:
  • platform/gtk/fast/text/backslash-to-yen-sign-expected.txt:
  • platform/gtk/fast/text/format-control-expected.txt:
  • platform/gtk/fast/text/international/bidi-mirror-he-ar-expected.txt:
  • platform/gtk/fast/text/international/bold-bengali-expected.txt:
  • platform/gtk/fast/text/international/plane2-expected.txt:
  • platform/gtk/fast/text/shadow-no-blur-expected.txt:
  • platform/gtk/fast/text/shadow-translucent-fill-expected.txt:
  • platform/gtk/fast/text/stroking-expected.txt:
  • platform/gtk/fonts/cursive-expected.txt:
  • platform/gtk/fonts/custom-font-missing-glyphs-expected.txt:
  • platform/gtk/fonts/default-expected.txt:
  • platform/gtk/fonts/fantasy-expected.txt:
  • platform/gtk/fonts/font-face-with-complex-text-expected.txt:
  • platform/gtk/fonts/fontconfig-aliasing-settings-expected.txt:
  • platform/gtk/fonts/fontconfig-synthetic-bold-expected.txt:
  • platform/gtk/fonts/fontconfig-synthetic-oblique-expected.txt:
  • platform/gtk/fonts/monospace-expected.txt:
  • platform/gtk/fonts/sans-serif-expected.txt:
  • platform/gtk/fonts/serif-expected.txt:
  • platform/gtk/fonts/xsettings_antialias_settings-expected.txt:
  • platform/gtk/http/tests/misc/slow-loading-image-in-pattern-expected.txt:
  • platform/gtk/media/audio-controls-rendering-expected.txt:
  • platform/gtk/media/audio-no-installed-engines-expected.txt:
  • platform/gtk/media/controls-after-reload-expected.txt:
  • platform/gtk/media/controls-strict-expected.txt:
  • platform/gtk/media/video-display-toggle-expected.txt:
  • platform/gtk/media/video-empty-source-expected.txt:
  • platform/gtk/media/video-no-audio-expected.txt:
  • platform/gtk/media/video-replaces-poster-expected.txt:
  • platform/gtk/media/video-zoom-expected.txt:
  • platform/gtk/scrollbars/basic-scrollbar-expected.txt:
  • platform/gtk/scrollbars/custom-scrollbar-with-incomplete-style-expected.txt:
  • platform/gtk/scrollbars/disabled-scrollbar-expected.txt:
  • platform/gtk/scrollbars/overflow-scrollbar-combinations-expected.txt:
  • platform/gtk/scrollbars/scrollbar-buttons-expected.txt:
  • platform/gtk/scrollbars/scrollbar-orientation-expected.txt:
  • platform/gtk/svg/batik/paints/patternRegions-positioned-objects-expected.txt:
  • platform/gtk/svg/batik/text/textDecoration-expected.txt:
  • platform/gtk/svg/css/composite-shadow-text-expected.txt:
  • platform/gtk/svg/css/group-with-shadow-expected.txt:
  • platform/gtk/svg/css/text-shadow-multiple-expected.txt:
  • platform/gtk/svg/custom/broken-internal-references-expected.txt:
  • platform/gtk/svg/custom/bug45331-expected.txt:
  • platform/gtk/svg/custom/clone-element-with-animated-svg-properties-expected.txt:
  • platform/gtk/svg/custom/getscreenctm-in-scrollable-div-area-expected.txt:
  • platform/gtk/svg/custom/getscreenctm-in-scrollable-div-area-nested-expected.txt:
  • platform/gtk/svg/custom/getscreenctm-in-scrollable-svg-area-expected.txt:
  • platform/gtk/svg/custom/js-update-stop-linked-gradient-expected.txt:
  • platform/gtk/svg/custom/mask-invalidation-expected.txt:
  • platform/gtk/svg/custom/mouse-move-on-svg-container-expected.txt:
  • platform/gtk/svg/custom/mouse-move-on-svg-container-standalone-expected.txt:
  • platform/gtk/svg/custom/mouse-move-on-svg-root-expected.txt:
  • platform/gtk/svg/custom/mouse-move-on-svg-root-standalone-expected.txt:
  • platform/gtk/svg/custom/pattern-incorrect-tiling-expected.txt:
  • platform/gtk/svg/custom/recursive-gradient-expected.txt:
  • platform/gtk/svg/custom/recursive-pattern-expected.txt:
  • platform/gtk/svg/custom/relative-sized-content-expected.txt:
  • platform/gtk/svg/custom/relative-sized-content-with-resources-expected.txt:
  • platform/gtk/svg/custom/relative-sized-deep-shadow-tree-content-expected.txt:
  • platform/gtk/svg/custom/relative-sized-shadow-tree-content-expected.txt:
  • platform/gtk/svg/custom/svg-curve-with-relative-cordinates-expected.txt:
  • platform/gtk/svg/custom/svg-fonts-without-missing-glyph-expected.txt:
  • platform/gtk/svg/custom/text-rotated-gradient-expected.txt:
  • platform/gtk/svg/custom/text-rotation-expected.txt:
  • platform/gtk/svg/custom/text-x-dy-lists-expected.txt:
  • platform/gtk/svg/custom/text-xy-updates-SVGList-expected.txt:
  • platform/gtk/svg/custom/use-font-face-crash-expected.txt:
  • platform/gtk/svg/filters/filter-on-filter-for-text-expected.txt:
  • platform/gtk/svg/filters/filter-on-tspan-expected.txt:
  • platform/gtk/svg/filters/filter-width-update-expected.txt:
  • platform/gtk/svg/foreignObject/no-crash-with-svg-content-in-html-document-expected.txt:
  • platform/gtk/svg/foreignObject/svg-document-as-direct-child-expected.txt:
  • platform/gtk/svg/foreignObject/svg-document-in-html-document-expected.txt:
  • platform/gtk/svg/foreignObject/text-tref-02-b-expected.txt:
  • platform/gtk/svg/in-html/circle-expected.txt:
  • platform/gtk/svg/repaint/filter-repaint-expected.txt:
  • platform/gtk/svg/text/foreignObject-text-clipping-bug-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacing-squeeze-1-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacing-squeeze-2-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacing-squeeze-3-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacing-squeeze-4-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacing-stretch-1-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacing-stretch-2-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacing-stretch-3-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacing-stretch-4-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-squeeze-1-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-squeeze-2-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-squeeze-3-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-squeeze-4-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-stretch-1-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-stretch-2-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-stretch-3-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.txt:
  • platform/gtk/svg/text/select-x-list-1-expected.txt:
  • platform/gtk/svg/text/select-x-list-2-expected.txt:
  • platform/gtk/svg/text/select-x-list-3-expected.txt:
  • platform/gtk/svg/text/select-x-list-4-expected.txt:
  • platform/gtk/svg/text/select-x-list-with-tspans-1-expected.txt:
  • platform/gtk/svg/text/select-x-list-with-tspans-2-expected.txt:
  • platform/gtk/svg/text/select-x-list-with-tspans-3-expected.txt:
  • platform/gtk/svg/text/select-x-list-with-tspans-4-expected.txt:
  • platform/gtk/svg/text/selection-background-color-expected.txt:
  • platform/gtk/svg/text/selection-doubleclick-expected.txt:
  • platform/gtk/svg/text/selection-styles-expected.txt:
  • platform/gtk/svg/text/selection-tripleclick-expected.txt:
  • platform/gtk/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt:
  • platform/gtk/svg/zoom/page/zoom-foreignObject-expected.txt:
  • platform/gtk/svg/zoom/page/zoom-hixie-mixed-008-expected.txt:
  • platform/gtk/svg/zoom/page/zoom-hixie-mixed-009-expected.txt:
  • platform/gtk/svg/zoom/page/zoom-hixie-rendering-model-004-expected.txt:
  • platform/gtk/svg/zoom/page/zoom-svg-float-border-padding-expected.txt:
  • platform/gtk/svg/zoom/text/zoom-coords-viewattr-01-b-expected.txt:
  • platform/gtk/svg/zoom/text/zoom-foreignObject-expected.txt:
  • platform/gtk/svg/zoom/text/zoom-hixie-mixed-008-expected.txt:
  • platform/gtk/svg/zoom/text/zoom-hixie-rendering-model-004-expected.txt:
  • platform/gtk/svg/zoom/text/zoom-svg-float-border-padding-expected.txt:
  • platform/gtk/tables/layering/paint-test-layering-1-expected.txt:
  • platform/gtk/tables/layering/paint-test-layering-2-expected.txt:
  • platform/gtk/transforms/2d/compound-transforms-vs-containers-expected.txt:
  • platform/gtk/transforms/2d/hindi-rotated-expected.txt:
  • platform/gtk/transforms/2d/transform-borderbox-expected.txt:
  • platform/gtk/transforms/2d/transform-fixed-container-expected.txt:
  • platform/gtk/transforms/2d/transform-origin-borderbox-expected.txt:
  • platform/gtk/transforms/2d/zoom-menulist-expected.txt:
  • platform/gtk/transforms/no_transform_hit_testing-expected.txt:
  • platform/gtk/transforms/svg-vs-css-expected.txt:
  • platform/gtk/transitions/move-after-transition-expected.txt:
  • platform/gtk/transitions/svg-text-shadow-transition-expected.txt:
  • platform/gtk/transitions/transition-drt-api-expected.txt:
04:29 Changeset [71405] by alex@webkit.org

2010-11-05 Alejandro G. Castro <alex@igalia.com>

Reviewed by Martin Robinson.

[GTK] Avoid font hinting in the DRT
https://bugs.webkit.org/show_bug.cgi?id=48548

Rebaseline the test results after removing the font hinting.

  • platform/gtk/editing/pasteboard/paste-text-008-expected.txt:
  • platform/gtk/editing/pasteboard/paste-text-009-expected.txt:
  • platform/gtk/editing/pasteboard/paste-text-010-expected.txt:
  • platform/gtk/editing/pasteboard/paste-xml-expected.txt:
  • platform/gtk/editing/pasteboard/subframe-dragndrop-1-expected.txt:
  • platform/gtk/editing/selection/13804-expected.txt:
  • platform/gtk/editing/selection/4818145-expected.txt:
  • platform/gtk/editing/selection/4866671-expected.txt:
  • platform/gtk/editing/selection/4889598-expected.txt:
  • platform/gtk/editing/selection/4895428-2-expected.txt:
  • platform/gtk/editing/selection/4960116-expected.txt:
  • platform/gtk/editing/selection/4960137-expected.txt:
  • platform/gtk/editing/selection/4983858-expected.txt:
  • platform/gtk/editing/selection/5007143-2-expected.txt:
  • platform/gtk/editing/selection/5007143-expected.txt:
  • platform/gtk/editing/selection/5057506-2-expected.txt:
  • platform/gtk/editing/selection/5057506-expected.txt:
  • platform/gtk/editing/selection/5076323-1-expected.txt:
  • platform/gtk/editing/selection/5076323-2-expected.txt:
  • platform/gtk/editing/selection/5076323-3-expected.txt:
  • platform/gtk/editing/selection/5081257-1-expected.txt:
  • platform/gtk/editing/selection/5081257-2-expected.txt:
  • platform/gtk/editing/selection/5099303-expected.txt:
  • platform/gtk/editing/selection/5109817-expected.txt:
  • platform/gtk/editing/selection/5131716-1-expected.txt:
  • platform/gtk/editing/selection/5131716-2-expected.txt:
  • platform/gtk/editing/selection/5131716-3-expected.txt:
  • platform/gtk/editing/selection/5131716-4-expected.txt:
  • platform/gtk/editing/selection/5232159-expected.txt:
  • platform/gtk/editing/selection/5234383-1-expected.txt:
  • platform/gtk/editing/selection/5234383-2-expected.txt:
  • platform/gtk/editing/selection/addRange-expected.txt:
  • platform/gtk/editing/selection/drag-in-iframe-expected.txt:
  • platform/gtk/editing/selection/drag-select-1-expected.txt:
  • platform/gtk/editing/selection/drag-text-delay-expected.txt:
  • platform/gtk/editing/selection/drag-to-contenteditable-iframe-expected.txt:
  • platform/gtk/editing/selection/extend-by-character-002-expected.txt:
  • platform/gtk/editing/selection/extend-by-character-003-expected.txt:
  • platform/gtk/editing/selection/extend-by-character-004-expected.txt:
  • platform/gtk/editing/selection/extend-by-character-005-expected.txt:
  • platform/gtk/editing/selection/extend-selection-expected.txt:
  • platform/gtk/editing/selection/fake-drag-expected.txt:
  • platform/gtk/editing/selection/iframe-expected.txt:
  • platform/gtk/editing/selection/inline-table-expected.txt:
  • platform/gtk/editing/selection/mixed-editability-6-expected.txt:
  • platform/gtk/editing/selection/mixed-editability-7-expected.txt:
  • platform/gtk/editing/selection/move-backwords-by-word-001-expected.txt:
  • platform/gtk/editing/selection/move-between-blocks-no-001-expected.txt:
  • platform/gtk/editing/selection/move-between-blocks-yes-001-expected.txt:
  • platform/gtk/editing/selection/move-by-character-001-expected.txt:
  • platform/gtk/editing/selection/move-by-character-002-expected.txt:
  • platform/gtk/editing/selection/move-by-character-003-expected.txt:
  • platform/gtk/editing/selection/move-by-character-004-expected.txt:
  • platform/gtk/editing/selection/move-by-character-005-expected.txt:
  • platform/gtk/editing/selection/move-by-sentence-001-expected.txt:
  • platform/gtk/editing/selection/move-by-sentence-linebreak-expected.txt:
  • platform/gtk/editing/selection/move-past-trailing-space-expected.txt:
  • platform/gtk/editing/selection/range-between-block-and-inline-expected.txt:
  • platform/gtk/editing/selection/select-box-expected.txt:
  • platform/gtk/editing/selection/select-text-overflow-ellipsis-expected.txt:
  • platform/gtk/editing/selection/selectNode-expected.txt:
  • platform/gtk/editing/selection/selectNodeContents-expected.txt:
  • platform/gtk/editing/selection/selection-actions-expected.txt:
  • platform/gtk/editing/selection/wrapped-line-caret-1-expected.txt:
  • platform/gtk/editing/selection/wrapped-line-caret-2-expected.txt:
  • platform/gtk/editing/spelling/spelling-expected.txt:
  • platform/gtk/editing/style/4916887-expected.txt:
  • platform/gtk/editing/style/5017613-1-expected.txt:
  • platform/gtk/editing/style/5017613-2-expected.txt:
  • platform/gtk/editing/style/5046875-1-expected.txt:
  • platform/gtk/editing/style/5046875-2-expected.txt:
  • platform/gtk/editing/style/5084241-expected.txt:
  • platform/gtk/editing/style/5228141-expected.txt:
  • platform/gtk/editing/style/5279521-expected.txt:
  • platform/gtk/editing/style/apply-through-end-of-document-expected.txt:
  • platform/gtk/editing/style/block-style-003-expected.txt:
  • platform/gtk/editing/style/highlight-expected.txt:
  • platform/gtk/editing/style/relative-font-size-change-001-expected.txt:
  • platform/gtk/editing/style/style-3681552-fix-001-expected.txt:
  • platform/gtk/editing/style/style-3681552-fix-002-expected.txt:
  • platform/gtk/editing/style/typing-style-001-expected.txt:
  • platform/gtk/editing/style/typing-style-002-expected.txt:
  • platform/gtk/editing/undo/4063751-expected.txt:
  • platform/gtk/editing/undo/undo-combined-delete-boundary-expected.txt:
  • platform/gtk/editing/undo/undo-combined-delete-expected.txt:
  • platform/gtk/editing/undo/undo-delete-boundary-expected.txt:
  • platform/gtk/editing/undo/undo-delete-expected.txt:
  • platform/gtk/editing/undo/undo-forward-delete-boundary-expected.txt:
  • platform/gtk/editing/undo/undo-forward-delete-expected.txt:
  • platform/gtk/fast/backgrounds/001-expected.txt:
  • platform/gtk/fast/backgrounds/animated-gif-as-background-expected.txt:
  • platform/gtk/fast/backgrounds/background-inherit-color-bug-expected.txt:
  • platform/gtk/fast/backgrounds/background-origin-root-element-expected.txt:
  • platform/gtk/fast/backgrounds/background-position-1-expected.txt:
  • platform/gtk/fast/backgrounds/background-position-rounding-expected.txt:
  • platform/gtk/fast/backgrounds/body-generated-image-propagated-to-root-expected.txt:
  • platform/gtk/fast/backgrounds/mask-composite-expected.txt:
  • platform/gtk/fast/backgrounds/opacity-on-document-element-expected.txt:
  • platform/gtk/fast/backgrounds/quirks-mode-line-box-backgrounds-expected.txt:
  • platform/gtk/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.txt:
  • platform/gtk/fast/backgrounds/repeat/negative-offset-repeat-expected.txt:
  • platform/gtk/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.txt:
  • platform/gtk/fast/backgrounds/size/backgroundSize16-expected.txt:
  • platform/gtk/fast/backgrounds/size/zero-expected.txt:
  • platform/gtk/fast/backgrounds/solid-color-context-restore-expected.txt:
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/001-expected.txt:
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/002-expected.txt:
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/003-expected.txt:
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/004-expected.txt:
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/005-expected.txt:
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/006-expected.txt:
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/010-expected.txt:
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/011-expected.txt:
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/012-expected.txt:
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/015-expected.txt:
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/016-expected.txt:
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/017-expected.txt:
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/018-expected.txt:
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/019-expected.txt:
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/020-expected.txt:
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/021-expected.txt:
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/022-expected.txt:
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/025-expected.txt:
  • platform/gtk/fast/block/positioning/absolute-positioning-no-scrollbar-expected.txt:
  • platform/gtk/fast/blockflow/fieldsets-expected.txt:
  • platform/gtk/fast/borders/block-mask-overlay-image-expected.txt:
  • platform/gtk/fast/borders/border-color-inherit-expected.txt:
  • platform/gtk/fast/borders/border-fit-expected.txt:
  • platform/gtk/fast/borders/border-image-border-radius-expected.txt:
  • platform/gtk/fast/borders/border-radius-constraints-expected.txt:
  • platform/gtk/fast/borders/border-radius-huge-assert-expected.txt:
  • platform/gtk/fast/borders/border-radius-split-inline-expected.txt:
  • platform/gtk/fast/borders/borderRadiusAllStylesAllCorners-expected.txt:
  • platform/gtk/fast/borders/borderRadiusInvalidColor-expected.txt:
  • platform/gtk/fast/borders/different-color-borders-expected.txt:
  • platform/gtk/fast/borders/inline-mask-overlay-image-expected.txt:
  • platform/gtk/fast/borders/svg-as-border-image-2-expected.txt:
  • platform/gtk/fast/borders/svg-as-border-image-expected.txt:
  • platform/gtk/fast/box-shadow/basic-shadows-expected.txt:
  • platform/gtk/fast/box-shadow/border-radius-big-expected.txt:
  • platform/gtk/fast/box-shadow/inset-expected.txt:
  • platform/gtk/fast/box-shadow/transform-fringing-expected.txt:
  • platform/gtk/fast/canvas/setWidthResetAfterForcedRender-expected.txt:
  • platform/gtk/fast/canvas/shadow-offset-1-expected.txt:
  • platform/gtk/fast/canvas/shadow-offset-2-expected.txt:
  • platform/gtk/fast/canvas/shadow-offset-3-expected.txt:
  • platform/gtk/fast/canvas/shadow-offset-4-expected.txt:
  • platform/gtk/fast/canvas/shadow-offset-5-expected.txt:
  • platform/gtk/fast/canvas/shadow-offset-6-expected.txt:
  • platform/gtk/fast/canvas/shadow-offset-7-expected.txt:
  • platform/gtk/fast/canvas/toDataURL-alpha-expected.txt:
  • platform/gtk/fast/css-generated-content/after-duplicated-after-split-expected.txt:
  • platform/gtk/fast/css/compare-content-style-expected.txt:
  • platform/gtk/fast/css/css3-space-in-nth-and-lang-expected.txt:
  • platform/gtk/fast/css/first-letter-first-line-hover-expected.txt:
  • platform/gtk/fast/css/first-letter-punctuation-expected.txt:
  • platform/gtk/fast/css/font-face-opentype-expected.txt:
  • platform/gtk/fast/css/inline-element-line-break-expected.txt:
  • platform/gtk/fast/css/input-search-padding-expected.txt:
  • platform/gtk/fast/css/non-standard-checkbox-size-expected.txt:
  • platform/gtk/fast/css/percent-top-relative-container-height-unspecified-expected.txt:
  • platform/gtk/fast/css/preserve-user-specified-zoom-level-on-reload-expected.txt:
  • platform/gtk/fast/css/pseudo-element-line-break-expected.txt:
  • platform/gtk/fast/css/rtl-to-viewport-expected.txt:
  • platform/gtk/fast/css/shadow-multiple-expected.txt:
  • platform/gtk/fast/css/text-input-with-webkit-border-radius-expected.txt:
  • platform/gtk/fast/css/transformed-mask-expected.txt:
  • platform/gtk/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.txt:
  • platform/gtk/fast/dynamic/window-resize-scrollbars-test-expected.txt:
  • platform/gtk/fast/dynamic/window-scrollbars-test-expected.txt:
  • platform/gtk/fast/events/event-sender-mouse-moved-expected.txt:
  • platform/gtk/fast/events/keydown-1-expected.txt:
  • platform/gtk/fast/events/mouseout-dead-node-expected.txt:
  • platform/gtk/fast/events/standalone-image-drag-to-editable-expected.txt:
  • platform/gtk/fast/forms/001-expected.txt:
  • platform/gtk/fast/forms/003-expected.txt:
  • platform/gtk/fast/forms/004-expected.txt:
  • platform/gtk/fast/forms/006-expected.txt:
  • platform/gtk/fast/forms/007-expected.txt:
  • platform/gtk/fast/forms/HTMLOptionElement_label01-expected.txt:
  • platform/gtk/fast/forms/HTMLOptionElement_label02-expected.txt:
  • platform/gtk/fast/forms/HTMLOptionElement_label03-expected.txt:
  • platform/gtk/fast/forms/HTMLOptionElement_label04-expected.txt:
  • platform/gtk/fast/forms/HTMLOptionElement_label05-expected.txt:
  • platform/gtk/fast/forms/HTMLOptionElement_label06-expected.txt:
  • platform/gtk/fast/forms/HTMLOptionElement_label07-expected.txt:
  • platform/gtk/fast/forms/basic-buttons-expected.txt:
  • platform/gtk/fast/forms/basic-inputs-expected.txt:
  • platform/gtk/fast/forms/basic-textareas-expected.txt:
  • platform/gtk/fast/forms/blankbuttons-expected.txt:
  • platform/gtk/fast/forms/box-shadow-override-expected.txt:
  • platform/gtk/fast/forms/button-align-expected.txt:
  • platform/gtk/fast/forms/button-cannot-be-nested-expected.txt:
  • platform/gtk/fast/forms/button-default-title-expected.txt:
  • platform/gtk/fast/forms/button-generated-content-expected.txt:
  • platform/gtk/fast/forms/button-inner-block-reuse-expected.txt:
  • platform/gtk/fast/forms/button-positioned-expected.txt:
  • platform/gtk/fast/forms/button-sizes-expected.txt:
  • platform/gtk/fast/forms/button-style-color-expected.txt:
  • platform/gtk/fast/forms/button-submit-expected.txt:
  • platform/gtk/fast/forms/button-table-styles-expected.txt:
  • platform/gtk/fast/forms/button-text-transform-expected.txt:
  • platform/gtk/fast/forms/button-white-space-expected.txt:
  • platform/gtk/fast/forms/caret-rtl-expected.txt:
  • platform/gtk/fast/forms/checkbox-radio-onchange-expected.txt:
  • platform/gtk/fast/forms/control-clip-expected.txt:
  • platform/gtk/fast/forms/control-clip-overflow-expected.txt:
  • platform/gtk/fast/forms/control-restrict-line-height-expected.txt:
  • platform/gtk/fast/forms/disabled-select-change-index-expected.txt:
  • platform/gtk/fast/forms/encoding-test-expected.txt:
  • platform/gtk/fast/forms/fieldset-align-expected.txt:
  • platform/gtk/fast/forms/fieldset-with-float-expected.txt:
  • platform/gtk/fast/forms/file-input-direction-expected.txt:
  • platform/gtk/fast/forms/file-input-disabled-expected.txt:
  • platform/gtk/fast/forms/float-before-fieldset-expected.txt:
  • platform/gtk/fast/forms/floating-textfield-relayout-expected.txt:
  • platform/gtk/fast/forms/form-added-to-table-expected.txt:
  • platform/gtk/fast/forms/form-element-geometry-expected.txt:
  • platform/gtk/fast/forms/form-hides-table-expected.txt:
  • platform/gtk/fast/forms/form-in-malformed-markup-expected.txt:
  • platform/gtk/fast/forms/formmove-expected.txt:
  • platform/gtk/fast/forms/formmove2-expected.txt:
  • platform/gtk/fast/forms/formmove3-expected.txt:
  • platform/gtk/fast/forms/hidden-input-file-expected.txt:
  • platform/gtk/fast/forms/hidden-listbox-expected.txt:
  • platform/gtk/fast/forms/image-border-expected.txt:
  • platform/gtk/fast/forms/indeterminate-expected.txt:
  • platform/gtk/fast/forms/input-align-expected.txt:
  • platform/gtk/fast/forms/input-align-image-expected.txt:
  • platform/gtk/fast/forms/input-appearance-bkcolor-expected.txt:
  • platform/gtk/fast/forms/input-appearance-default-bkcolor-expected.txt:
  • platform/gtk/fast/forms/input-appearance-disabled-expected.txt:
  • platform/gtk/fast/forms/input-appearance-focus-expected.txt:
  • platform/gtk/fast/forms/input-appearance-height-expected.txt:
  • platform/gtk/fast/forms/input-appearance-preventDefault-expected.txt:
  • platform/gtk/fast/forms/input-appearance-readonly-expected.txt:
  • platform/gtk/fast/forms/input-appearance-selection-expected.txt:
  • platform/gtk/fast/forms/input-appearance-visibility-expected.txt:
  • platform/gtk/fast/forms/input-appearance-width-expected.txt:
  • platform/gtk/fast/forms/input-baseline-expected.txt:
  • platform/gtk/fast/forms/input-button-sizes-expected.txt:
  • platform/gtk/fast/forms/input-disabled-color-expected.txt:
  • platform/gtk/fast/forms/input-double-click-selection-gap-bug-expected.txt:
  • platform/gtk/fast/forms/input-field-text-truncated-expected.txt:
  • platform/gtk/fast/forms/input-first-letter-expected.txt:
  • platform/gtk/fast/forms/input-no-renderer-expected.txt:
  • platform/gtk/fast/forms/input-paste-undo-expected.txt:
  • platform/gtk/fast/forms/input-placeholder-focus-twice-expected.txt:
  • platform/gtk/fast/forms/input-readonly-autoscroll-expected.txt:
  • platform/gtk/fast/forms/input-readonly-dimmed-expected.txt:
  • platform/gtk/fast/forms/input-readonly-empty-expected.txt:
  • platform/gtk/fast/forms/input-spaces-expected.txt:
  • platform/gtk/fast/forms/input-table-expected.txt:
  • platform/gtk/fast/forms/input-text-click-inside-expected.txt:
  • platform/gtk/fast/forms/input-text-click-outside-expected.txt:
  • platform/gtk/fast/forms/input-text-double-click-expected.txt:
  • platform/gtk/fast/forms/input-text-drag-down-expected.txt:
  • platform/gtk/fast/forms/input-text-option-delete-expected.txt:
  • platform/gtk/fast/forms/input-text-scroll-left-on-blur-expected.txt:
  • platform/gtk/fast/forms/input-text-self-emptying-click-expected.txt:
  • platform/gtk/fast/forms/input-text-word-wrap-expected.txt:
  • platform/gtk/fast/forms/input-type-change-expected.txt:
  • platform/gtk/fast/forms/input-type-change2-expected.txt:
  • platform/gtk/fast/forms/input-type-text-min-width-expected.txt:
  • platform/gtk/fast/forms/input-value-expected.txt:
  • platform/gtk/fast/forms/isindex-placeholder-expected.txt:
  • platform/gtk/fast/forms/linebox-overflow-in-textarea-padding-expected.txt:
  • platform/gtk/fast/forms/listbox-scrollbar-incremental-load-expected.txt:
  • platform/gtk/fast/forms/listbox-width-change-expected.txt:
  • platform/gtk/fast/forms/menulist-clip-expected.txt:
  • platform/gtk/fast/forms/menulist-deselect-update-expected.txt:
  • platform/gtk/fast/forms/menulist-narrow-width-expected.txt:
  • platform/gtk/fast/forms/menulist-no-overflow-expected.txt:
  • platform/gtk/fast/forms/menulist-option-wrap-expected.txt:
  • platform/gtk/fast/forms/menulist-restrict-line-height-expected.txt:
  • platform/gtk/fast/forms/menulist-separator-painting-expected.txt:
  • platform/gtk/fast/forms/menulist-style-color-expected.txt:
  • platform/gtk/fast/forms/menulist-width-change-expected.txt:
  • platform/gtk/fast/forms/minWidthPercent-expected.txt:
  • platform/gtk/fast/forms/negativeLineHeight-expected.txt:
  • platform/gtk/fast/forms/option-index-expected.txt:
  • platform/gtk/fast/forms/option-script-expected.txt:
  • platform/gtk/fast/forms/option-strip-whitespace-expected.txt:
  • platform/gtk/fast/forms/option-text-clip-expected.txt:
  • platform/gtk/fast/forms/password-placeholder-text-security-expected.txt:
  • platform/gtk/fast/forms/placeholder-pseudo-style-expected.txt:
  • platform/gtk/fast/forms/placeholder-set-attribute-expected.txt:
  • platform/gtk/fast/forms/placeholder-set-value-expected.txt:
  • platform/gtk/fast/forms/placeholder-stripped-expected.txt:
  • platform/gtk/fast/forms/plaintext-mode-2-expected.txt:
  • platform/gtk/fast/forms/preserveFormDuringResidualStyle-expected.txt:
  • platform/gtk/fast/forms/radio-attr-order-expected.txt:
  • platform/gtk/fast/forms/radio-nested-labels-expected.txt:
  • platform/gtk/fast/forms/radio_checked-expected.txt:
  • platform/gtk/fast/forms/radio_checked_dynamic-expected.txt:
  • platform/gtk/fast/forms/range-thumb-height-percentage-expected.txt:
  • platform/gtk/fast/forms/search-cancel-button-style-sharing-expected.txt:
  • platform/gtk/fast/forms/search-display-none-cancel-button-expected.txt:
  • platform/gtk/fast/forms/search-placeholder-value-changed-expected.txt:
  • platform/gtk/fast/forms/search-rtl-expected.txt:
  • platform/gtk/fast/forms/search-transformed-expected.txt:
  • platform/gtk/fast/forms/search-vertical-alignment-expected.txt:
  • platform/gtk/fast/forms/search-zoomed-expected.txt:
  • platform/gtk/fast/forms/searchfield-heights-expected.txt:
  • platform/gtk/fast/forms/select-align-expected.txt:
  • platform/gtk/fast/forms/select-baseline-expected.txt:
  • platform/gtk/fast/forms/select-block-background-expected.txt:
  • platform/gtk/fast/forms/select-change-listbox-size-expected.txt:
  • platform/gtk/fast/forms/select-change-listbox-to-popup-expected.txt:
  • platform/gtk/fast/forms/select-change-popup-to-listbox-expected.txt:
  • platform/gtk/fast/forms/select-dirty-parent-pref-widths-expected.txt:
  • platform/gtk/fast/forms/select-disabled-appearance-expected.txt:
  • platform/gtk/fast/forms/select-display-none-style-resolve-expected.txt:
  • platform/gtk/fast/forms/select-empty-option-height-expected.txt:
  • platform/gtk/fast/forms/select-initial-position-expected.txt:
  • platform/gtk/fast/forms/select-item-background-clip-expected.txt:
  • platform/gtk/fast/forms/select-list-box-with-height-expected.txt:
  • platform/gtk/fast/forms/select-selected-expected.txt:
  • platform/gtk/fast/forms/select-size-expected.txt:
  • platform/gtk/fast/forms/select-style-expected.txt:
  • platform/gtk/fast/forms/select-visual-hebrew-expected.txt:
  • platform/gtk/fast/forms/select-writing-direction-natural-expected.txt:
  • platform/gtk/fast/forms/slider-padding-expected.txt:
  • platform/gtk/fast/forms/slider-thumb-shared-style-expected.txt:
  • platform/gtk/fast/forms/slider-thumb-stylability-expected.txt:
  • platform/gtk/fast/forms/stuff-on-my-optgroup-expected.txt:
  • platform/gtk/fast/forms/tabbing-input-iframe-expected.txt:
  • platform/gtk/fast/forms/targeted-frame-submission-expected.txt:
  • platform/gtk/fast/forms/text-style-color-expected.txt:
  • platform/gtk/fast/forms/textAreaLineHeight-expected.txt:
  • platform/gtk/fast/forms/textarea-align-expected.txt:
  • platform/gtk/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
  • platform/gtk/fast/forms/textarea-placeholder-set-attribute-expected.txt:
  • platform/gtk/fast/forms/textarea-placeholder-set-value-expected.txt:
  • platform/gtk/fast/forms/textarea-scroll-height-expected.txt:
  • platform/gtk/fast/forms/textarea-scrollbar-expected.txt:
  • platform/gtk/fast/forms/textarea-scrolled-type-expected.txt:
  • platform/gtk/fast/forms/textarea-setinnerhtml-expected.txt:
  • platform/gtk/fast/forms/textarea-width-expected.txt:
  • platform/gtk/fast/forms/textfield-focus-ring-expected.txt:
  • platform/gtk/fast/forms/textfield-outline-expected.txt:
  • platform/gtk/fast/forms/thumbslider-crash-expected.txt:
  • platform/gtk/fast/forms/thumbslider-no-parent-slider-expected.txt:
  • platform/gtk/fast/forms/visual-hebrew-text-field-expected.txt:
  • platform/gtk/fast/frames/001-expected.txt:
  • platform/gtk/fast/frames/contentWindow_Frame-expected.txt:
  • platform/gtk/fast/frames/contentWindow_iFrame-expected.txt:
  • platform/gtk/fast/frames/flattening/frameset-flattening-advanced-expected.txt:
  • platform/gtk/fast/frames/flattening/frameset-flattening-grid-expected.txt:
  • platform/gtk/fast/frames/flattening/frameset-flattening-simple-expected.txt:
  • platform/gtk/fast/frames/flattening/frameset-flattening-subframe-resize-expected.txt:
  • platform/gtk/fast/frames/flattening/frameset-flattening-subframesets-expected.txt:
  • platform/gtk/fast/frames/flattening/iframe-flattening-fixed-height-expected.txt:
  • platform/gtk/fast/frames/flattening/iframe-flattening-fixed-width-and-height-expected.txt:
  • platform/gtk/fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling-expected.txt:
  • platform/gtk/fast/frames/flattening/iframe-flattening-fixed-width-expected.txt:
  • platform/gtk/fast/frames/flattening/iframe-flattening-offscreen-expected.txt:
  • platform/gtk/fast/frames/flattening/iframe-flattening-simple-expected.txt:
  • platform/gtk/fast/frames/frame-navigation-expected.txt:
  • platform/gtk/fast/frames/frame-scrolling-attribute-expected.txt:
  • platform/gtk/fast/frames/frameElement-frame-expected.txt:
  • platform/gtk/fast/frames/frameElement-iframe-expected.txt:
  • platform/gtk/fast/frames/frameset-style-recalc-expected.txt:
  • platform/gtk/fast/frames/iframe-option-crash-expected.txt:
  • platform/gtk/fast/frames/iframe-scrolling-attribute-expected.txt:
  • platform/gtk/fast/frames/iframe-with-frameborder-expected.txt:
  • platform/gtk/fast/frames/inline-object-inside-frameset-expected.txt:
  • platform/gtk/fast/frames/onlyCommentInIFrame-expected.txt:
  • platform/gtk/fast/frames/take-focus-from-iframe-expected.txt:
  • platform/gtk/fast/frames/viewsource-attribute-expected.txt:
  • platform/gtk/fast/frames/viewsource-on-image-file-expected.txt:
  • platform/gtk/fast/gradients/radial-centered-expected.txt:
  • platform/gtk/fast/images/imagemap-focus-ring-expected.txt:
  • platform/gtk/fast/images/svg-background-partial-redraw-expected.txt:
  • platform/gtk/fast/inline/continuation-outlines-with-layers-2-expected.txt:
  • platform/gtk/fast/inline/inline-focus-ring-expected.txt:
  • platform/gtk/fast/layers/remove-only-this-layer-update-expected.txt:
  • platform/gtk/fast/lists/drag-into-marker-expected.txt:
  • platform/gtk/fast/multicol/border-padding-pagination-expected.txt:
  • platform/gtk/fast/multicol/client-rects-expected.txt:
  • platform/gtk/fast/multicol/column-break-with-balancing-expected.txt:
  • platform/gtk/fast/multicol/column-count-with-rules-expected.txt:
  • platform/gtk/fast/multicol/column-rules-expected.txt:
  • platform/gtk/fast/multicol/column-rules-stacking-expected.txt:
  • platform/gtk/fast/multicol/columns-shorthand-parsing-expected.txt:
  • platform/gtk/fast/multicol/float-avoidance-expected.txt:
04:18 Changeset [71404] by alex@webkit.org

2010-11-05 Alejandro G. Castro <alex@igalia.com>

Reviewed by Martin Robinson.

[GTK] Avoid font hinting in the DRT
https://bugs.webkit.org/show_bug.cgi?id=48548

Rebaseline the test results after removing the font hinting.

  • platform/gtk/animations/animation-drt-api-expected.txt:
  • platform/gtk/animations/animation-drt-api-multiple-keyframes-expected.txt:
  • platform/gtk/animations/missing-values-first-keyframe-expected.txt:
  • platform/gtk/animations/missing-values-last-keyframe-expected.txt:
  • platform/gtk/animations/state-at-end-event-expected.txt:
  • platform/gtk/css1/basic/class_as_selector-expected.txt:
  • platform/gtk/css1/basic/comments-expected.txt:
  • platform/gtk/css1/basic/containment-expected.txt:
  • platform/gtk/css1/basic/contextual_selectors-expected.txt:
  • platform/gtk/css1/basic/grouping-expected.txt:
  • platform/gtk/css1/basic/id_as_selector-expected.txt:
  • platform/gtk/css1/basic/inheritance-expected.txt:
  • platform/gtk/css1/box_properties/border-expected.txt:
  • platform/gtk/css1/box_properties/border_bottom-expected.txt:
  • platform/gtk/css1/box_properties/border_bottom_inline-expected.txt:
  • platform/gtk/css1/box_properties/border_bottom_width-expected.txt:
  • platform/gtk/css1/box_properties/border_bottom_width_inline-expected.txt:
  • platform/gtk/css1/box_properties/border_color-expected.txt:
  • platform/gtk/css1/box_properties/border_color_inline-expected.txt:
  • platform/gtk/css1/box_properties/border_inline-expected.txt:
  • platform/gtk/css1/box_properties/border_left-expected.txt:
  • platform/gtk/css1/box_properties/border_left_inline-expected.txt:
  • platform/gtk/css1/box_properties/border_left_width-expected.txt:
  • platform/gtk/css1/box_properties/border_left_width_inline-expected.txt:
  • platform/gtk/css1/box_properties/border_right-expected.txt:
  • platform/gtk/css1/box_properties/border_right_inline-expected.txt:
  • platform/gtk/css1/box_properties/border_right_width-expected.txt:
  • platform/gtk/css1/box_properties/border_right_width_inline-expected.txt:
  • platform/gtk/css1/box_properties/border_style-expected.txt:
  • platform/gtk/css1/box_properties/border_style_inline-expected.txt:
  • platform/gtk/css1/box_properties/border_top-expected.txt:
  • platform/gtk/css1/box_properties/border_top_inline-expected.txt:
  • platform/gtk/css1/box_properties/border_top_width-expected.txt:
  • platform/gtk/css1/box_properties/border_top_width_inline-expected.txt:
  • platform/gtk/css1/box_properties/border_width-expected.txt:
  • platform/gtk/css1/box_properties/border_width_inline-expected.txt:
  • platform/gtk/css1/box_properties/clear-expected.txt:
  • platform/gtk/css1/box_properties/clear_float-expected.txt:
  • platform/gtk/css1/box_properties/float-expected.txt:
  • platform/gtk/css1/box_properties/float_elements_in_series-expected.txt:
  • platform/gtk/css1/box_properties/float_margin-expected.txt:
  • platform/gtk/css1/box_properties/float_on_text_elements-expected.txt:
  • platform/gtk/css1/box_properties/height-expected.txt:
  • platform/gtk/css1/box_properties/margin-expected.txt:
  • platform/gtk/css1/box_properties/margin_bottom-expected.txt:
  • platform/gtk/css1/box_properties/margin_bottom_inline-expected.txt:
  • platform/gtk/css1/box_properties/margin_inline-expected.txt:
  • platform/gtk/css1/box_properties/margin_left-expected.txt:
  • platform/gtk/css1/box_properties/margin_left_inline-expected.txt:
  • platform/gtk/css1/box_properties/margin_right-expected.txt:
  • platform/gtk/css1/box_properties/margin_right_inline-expected.txt:
  • platform/gtk/css1/box_properties/margin_top-expected.txt:
  • platform/gtk/css1/box_properties/margin_top_inline-expected.txt:
  • platform/gtk/css1/box_properties/padding-expected.txt:
  • platform/gtk/css1/box_properties/padding_bottom-expected.txt:
  • platform/gtk/css1/box_properties/padding_bottom_inline-expected.txt:
  • platform/gtk/css1/box_properties/padding_inline-expected.txt:
  • platform/gtk/css1/box_properties/padding_left-expected.txt:
  • platform/gtk/css1/box_properties/padding_left_inline-expected.txt:
  • platform/gtk/css1/box_properties/padding_right-expected.txt:
  • platform/gtk/css1/box_properties/padding_right_inline-expected.txt:
  • platform/gtk/css1/box_properties/padding_top-expected.txt:
  • platform/gtk/css1/box_properties/padding_top_inline-expected.txt:
  • platform/gtk/css1/box_properties/width-expected.txt:
  • platform/gtk/css1/cascade/cascade_order-expected.txt:
  • platform/gtk/css1/cascade/important-expected.txt:
  • platform/gtk/css1/classification/display-expected.txt:
  • platform/gtk/css1/classification/list_style-expected.txt:
  • platform/gtk/css1/classification/list_style_image-expected.txt:
  • platform/gtk/css1/classification/list_style_position-expected.txt:
  • platform/gtk/css1/classification/list_style_type-expected.txt:
  • platform/gtk/css1/classification/white_space-expected.txt:
  • platform/gtk/css1/color_and_background/background-expected.txt:
  • platform/gtk/css1/color_and_background/background_attachment-expected.txt:
  • platform/gtk/css1/color_and_background/background_color-expected.txt:
  • platform/gtk/css1/color_and_background/background_image-expected.txt:
  • platform/gtk/css1/color_and_background/background_position-expected.txt:
  • platform/gtk/css1/color_and_background/background_repeat-expected.txt:
  • platform/gtk/css1/color_and_background/color-expected.txt:
  • platform/gtk/css1/conformance/forward_compatible_parsing-expected.txt:
  • platform/gtk/css1/font_properties/font-expected.txt:
  • platform/gtk/css1/font_properties/font_family-expected.txt:
  • platform/gtk/css1/font_properties/font_size-expected.txt:
  • platform/gtk/css1/font_properties/font_style-expected.txt:
  • platform/gtk/css1/font_properties/font_variant-expected.txt:
  • platform/gtk/css1/font_properties/font_weight-expected.txt:
  • platform/gtk/css1/formatting_model/canvas-expected.txt:
  • platform/gtk/css1/formatting_model/floating_elements-expected.txt:
  • platform/gtk/css1/formatting_model/height_of_lines-expected.txt:
  • platform/gtk/css1/formatting_model/horizontal_formatting-expected.txt:
  • platform/gtk/css1/formatting_model/inline_elements-expected.txt:
  • platform/gtk/css1/formatting_model/replaced_elements-expected.txt:
  • platform/gtk/css1/formatting_model/vertical_formatting-expected.txt:
  • platform/gtk/css1/pseudo/anchor-expected.txt:
  • platform/gtk/css1/pseudo/firstletter-expected.txt:
  • platform/gtk/css1/pseudo/firstline-expected.txt:
  • platform/gtk/css1/pseudo/multiple_pseudo_elements-expected.txt:
  • platform/gtk/css1/pseudo/pseudo_elements_in_selectors-expected.txt:
  • platform/gtk/css1/text_properties/letter_spacing-expected.txt:
  • platform/gtk/css1/text_properties/line_height-expected.txt:
  • platform/gtk/css1/text_properties/text_align-expected.txt:
  • platform/gtk/css1/text_properties/text_decoration-expected.txt:
  • platform/gtk/css1/text_properties/text_indent-expected.txt:
  • platform/gtk/css1/text_properties/text_transform-expected.txt:
  • platform/gtk/css1/text_properties/vertical_align-expected.txt:
  • platform/gtk/css1/text_properties/word_spacing-expected.txt:
  • platform/gtk/css1/units/color_units-expected.txt:
  • platform/gtk/css1/units/length_units-expected.txt:
  • platform/gtk/css1/units/percentage_units-expected.txt:
  • platform/gtk/css1/units/urls-expected.txt:
  • platform/gtk/css3/css3-modsel-33-expected.txt:
  • platform/gtk/css3/css3-modsel-35-expected.txt:
  • platform/gtk/css3/css3-modsel-36-expected.txt:
  • platform/gtk/css3/css3-modsel-37-expected.txt:
  • platform/gtk/editing/deleting/4922367-expected.txt:
  • platform/gtk/editing/deleting/5026848-1-expected.txt:
  • platform/gtk/editing/deleting/5026848-2-expected.txt:
  • platform/gtk/editing/deleting/5026848-3-expected.txt:
  • platform/gtk/editing/deleting/5032066-expected.txt:
  • platform/gtk/editing/deleting/5091898-expected.txt:
  • platform/gtk/editing/deleting/5099303-expected.txt:
  • platform/gtk/editing/deleting/5115601-expected.txt:
  • platform/gtk/editing/deleting/5126166-expected.txt:
  • platform/gtk/editing/deleting/5156801-2-expected.txt:
  • platform/gtk/editing/deleting/5206311-1-expected.txt:
  • platform/gtk/editing/deleting/5206311-2-expected.txt:
  • platform/gtk/editing/deleting/5272440-expected.txt:
  • platform/gtk/editing/deleting/5300379-expected.txt:
  • platform/gtk/editing/deleting/5369009-expected.txt:
  • platform/gtk/editing/deleting/5390681-2-expected.txt:
  • platform/gtk/editing/deleting/5433862-2-expected.txt:
  • platform/gtk/editing/deleting/5483370-expected.txt:
  • platform/gtk/editing/deleting/delete-3608430-fix-expected.txt:
  • platform/gtk/editing/deleting/delete-3608462-fix-expected.txt:
  • platform/gtk/editing/deleting/delete-3959464-fix-expected.txt:
  • platform/gtk/editing/deleting/delete-and-undo-expected.txt:
  • platform/gtk/editing/deleting/delete-block-contents-003-expected.txt:
  • platform/gtk/editing/deleting/delete-block-merge-contents-010-expected.txt:
  • platform/gtk/editing/deleting/delete-block-merge-contents-012-expected.txt:
  • platform/gtk/editing/deleting/delete-block-merge-contents-013-expected.txt:
  • platform/gtk/editing/deleting/delete-block-merge-contents-014-expected.txt:
  • platform/gtk/editing/deleting/delete-block-merge-contents-015-expected.txt:
  • platform/gtk/editing/deleting/delete-block-merge-contents-016-expected.txt:
  • platform/gtk/editing/deleting/delete-block-merge-contents-017-expected.txt:
  • platform/gtk/editing/deleting/delete-br-001-expected.txt:
  • platform/gtk/editing/deleting/delete-br-002-expected.txt:
  • platform/gtk/editing/deleting/delete-br-003-expected.txt:
  • platform/gtk/editing/deleting/delete-br-004-expected.txt:
  • platform/gtk/editing/deleting/delete-br-005-expected.txt:
  • platform/gtk/editing/deleting/delete-br-006-expected.txt:
  • platform/gtk/editing/deleting/delete-br-007-expected.txt:
  • platform/gtk/editing/deleting/delete-br-010-expected.txt:
  • platform/gtk/editing/deleting/delete-br-013-expected.txt:
  • platform/gtk/editing/deleting/delete-by-word-001-expected.txt:
  • platform/gtk/editing/deleting/delete-contiguous-ws-001-expected.txt:
  • platform/gtk/editing/deleting/delete-line-001-expected.txt:
  • platform/gtk/editing/deleting/delete-line-002-expected.txt:
  • platform/gtk/editing/deleting/delete-line-005-expected.txt:
  • platform/gtk/editing/deleting/delete-line-006-expected.txt:
  • platform/gtk/editing/deleting/delete-line-007-expected.txt:
  • platform/gtk/editing/deleting/delete-line-008-expected.txt:
  • platform/gtk/editing/deleting/delete-line-009-expected.txt:
  • platform/gtk/editing/deleting/delete-line-010-expected.txt:
  • platform/gtk/editing/deleting/delete-line-011-expected.txt:
  • platform/gtk/editing/deleting/delete-line-012-expected.txt:
  • platform/gtk/editing/deleting/delete-line-013-expected.txt:
  • platform/gtk/editing/deleting/delete-line-014-expected.txt:
  • platform/gtk/editing/deleting/delete-line-end-ws-001-expected.txt:
  • platform/gtk/editing/deleting/delete-line-end-ws-002-expected.txt:
  • platform/gtk/editing/deleting/delete-listitem-001-expected.txt:
  • platform/gtk/editing/deleting/delete-listitem-002-expected.txt:
  • platform/gtk/editing/deleting/delete-to-end-of-paragraph-expected.txt:
  • platform/gtk/editing/deleting/delete-to-select-table-expected.txt:
  • platform/gtk/editing/deleting/delete-trailing-ws-002-expected.txt:
  • platform/gtk/editing/deleting/delete-ws-fixup-001-expected.txt:
  • platform/gtk/editing/deleting/delete-ws-fixup-002-expected.txt:
  • platform/gtk/editing/deleting/forward-delete-expected.txt:
  • platform/gtk/editing/deleting/merge-whitespace-pre-expected.txt:
  • platform/gtk/editing/deleting/move-nodes-001-expected.txt:
  • platform/gtk/editing/deleting/smart-delete-003-expected.txt:
  • platform/gtk/editing/deleting/smart-delete-004-expected.txt:
  • platform/gtk/editing/deleting/type-delete-after-quote-expected.txt:
  • platform/gtk/editing/execCommand/4580583-1-expected.txt:
  • platform/gtk/editing/execCommand/4580583-2-expected.txt:
  • platform/gtk/editing/execCommand/4747450-expected.txt:
  • platform/gtk/editing/execCommand/4916402-expected.txt:
  • platform/gtk/editing/execCommand/4916541-expected.txt:
  • platform/gtk/editing/execCommand/4924441-expected.txt:
  • platform/gtk/editing/execCommand/5080333-1-expected.txt:
  • platform/gtk/editing/execCommand/5080333-2-expected.txt:
  • platform/gtk/editing/execCommand/5136770-expected.txt:
  • platform/gtk/editing/execCommand/5138441-expected.txt:
  • platform/gtk/editing/execCommand/5142012-1-expected.txt:
  • platform/gtk/editing/execCommand/5142012-2-expected.txt:
  • platform/gtk/editing/execCommand/5190926-expected.txt:
  • platform/gtk/editing/execCommand/5481523-expected.txt:
  • platform/gtk/editing/execCommand/5482023-expected.txt:
  • platform/gtk/editing/execCommand/5569741-expected.txt:
  • platform/gtk/editing/inserting/12882-expected.txt:
  • platform/gtk/editing/inserting/4840662-expected.txt:
  • platform/gtk/editing/inserting/4875189-1-expected.txt:
  • platform/gtk/editing/inserting/4875189-2-expected.txt:
  • platform/gtk/editing/inserting/4959067-expected.txt:
  • platform/gtk/editing/inserting/4960120-2-expected.txt:
  • platform/gtk/editing/inserting/5002441-expected.txt:
  • platform/gtk/editing/inserting/5058163-1-expected.txt:
  • platform/gtk/editing/inserting/5058163-2-expected.txt:
  • platform/gtk/editing/inserting/5156401-2-expected.txt:
  • platform/gtk/editing/inserting/5418891-expected.txt:
  • platform/gtk/editing/inserting/5510537-expected.txt:
  • platform/gtk/editing/inserting/5549929-2-expected.txt:
  • platform/gtk/editing/inserting/5549929-3-expected.txt:
  • platform/gtk/editing/inserting/6703873-expected.txt:
  • platform/gtk/editing/inserting/editable-inline-element-expected.txt:
  • platform/gtk/editing/inserting/edited-whitespace-1-expected.txt:
  • platform/gtk/editing/inserting/insert-3800346-fix-expected.txt:
  • platform/gtk/editing/inserting/insert-3851164-fix-expected.txt:
  • platform/gtk/editing/inserting/insert-3907422-fix-expected.txt:
  • platform/gtk/editing/inserting/insert-div-009-expected.txt:
  • platform/gtk/editing/inserting/insert-div-024-expected.txt:
  • platform/gtk/editing/inserting/insert-text-with-newlines-expected.txt:
  • platform/gtk/editing/inserting/redo-expected.txt:
  • platform/gtk/editing/inserting/typing-002-expected.txt:
  • platform/gtk/editing/pasteboard/4076267-2-expected.txt:
  • platform/gtk/editing/pasteboard/4076267-3-expected.txt:
  • platform/gtk/editing/pasteboard/4076267-expected.txt:
  • platform/gtk/editing/pasteboard/5032095-expected.txt:
  • platform/gtk/editing/pasteboard/5071074-2-expected.txt:
  • platform/gtk/editing/pasteboard/5075944-3-expected.txt:
  • platform/gtk/editing/pasteboard/5089327-expected.txt:
  • platform/gtk/editing/pasteboard/5134759-expected.txt:
  • platform/gtk/editing/pasteboard/5156401-1-expected.txt:
  • platform/gtk/editing/pasteboard/5387578-expected.txt:
  • platform/gtk/editing/pasteboard/5483567-expected.txt:
  • platform/gtk/editing/pasteboard/7955-expected.txt:
  • platform/gtk/editing/pasteboard/cut-text-001-expected.txt:
  • platform/gtk/editing/pasteboard/drag-drop-dead-frame-expected.txt:
  • platform/gtk/editing/pasteboard/drag-drop-modifies-page-expected.txt:
  • platform/gtk/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.txt:
  • platform/gtk/editing/pasteboard/drag-selected-image-to-contenteditable-expected.txt:
  • platform/gtk/editing/pasteboard/drop-text-without-selection-expected.txt:
  • platform/gtk/editing/pasteboard/innerText-inline-table-expected.txt:
  • platform/gtk/editing/pasteboard/paste-blockquote-1-expected.txt:
  • platform/gtk/editing/pasteboard/paste-blockquote-2-expected.txt:
  • platform/gtk/editing/pasteboard/paste-blockquote-3-expected.txt:
  • platform/gtk/editing/pasteboard/paste-blockquote-after-blockquote-expected.txt:
  • platform/gtk/editing/pasteboard/paste-blockquote-into-blockquote-2-expected.txt:
  • platform/gtk/editing/pasteboard/paste-blockquote-into-blockquote-3-expected.txt:
  • platform/gtk/editing/pasteboard/paste-blockquote-into-blockquote-4-expected.txt:
  • platform/gtk/editing/pasteboard/paste-blockquote-into-blockquote-expected.txt:
  • platform/gtk/editing/pasteboard/paste-text-001-expected.txt:
  • platform/gtk/editing/pasteboard/paste-text-002-expected.txt:
  • platform/gtk/editing/pasteboard/paste-text-003-expected.txt:
  • platform/gtk/editing/pasteboard/paste-text-004-expected.txt:
  • platform/gtk/editing/pasteboard/paste-text-005-expected.txt:
  • platform/gtk/editing/pasteboard/paste-text-006-expected.txt:
  • platform/gtk/editing/pasteboard/paste-text-007-expected.txt:
04:10 Changeset [71403] by alex@webkit.org

2010-11-05 Alejandro G. Castro <alex@igalia.com>

Reviewed by Martin Robinson.

[GTK] Avoid font hinting in the DRT
https://bugs.webkit.org/show_bug.cgi?id=48548

Change the settings to avoid font hinting, it was causing
different results depending on the distribution.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (initializeGtkFontSettings):
  • DumpRenderTree/gtk/fonts/fonts.conf:
03:30 Changeset [71402] by pfeldman@chromium.org

2010-11-05 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: inspector lags on large resources with numerous <script> tags.
https://bugs.webkit.org/show_bug.cgi?id=49060

  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._addScriptToFilesMenu):
03:15 Changeset [71401] by paroga@webkit.org

2010-11-05 Patrick Gansterer <paroga@webkit.org>

Reviewed by David Kilzer.

Replace ARRAYSIZE with WTF_ARRAY_LENGTH
https://bugs.webkit.org/show_bug.cgi?id=48903

  • platform/UUID.cpp: (WebCore::createCanonicalUUIDString):
  • platform/graphics/chromium/FontCacheChromiumWin.cpp: (WebCore::FontCache::getFontDataForCharacters):
  • platform/graphics/win/FontCacheWin.cpp: (WebCore::FontCache::getLastResortFallbackFont):
  • platform/graphics/win/IconWin.cpp: (WebCore::Icon::createIconForFiles):
  • platform/win/ClipboardUtilitiesWin.cpp: (WebCore::getWebLocData):
  • platform/win/ClipboardWin.cpp: (WebCore::createGlobalHDropContent): (WebCore::createGlobalImageFileDescriptor): (WebCore::ClipboardWin::files): (WebCore::ClipboardWin::writeURL):
  • platform/win/DragDataWin.cpp: (WebCore::DragData::asFilenames):
  • platform/win/FileSystemWin.cpp: (WebCore::safeCreateFile):

2010-11-05 Patrick Gansterer <paroga@webkit.org>

Reviewed by David Kilzer.

Replace ARRAYSIZE with WTF_ARRAY_LENGTH
https://bugs.webkit.org/show_bug.cgi?id=48903

  • WebCoreSupport/EditorClientEfl.cpp: (WebCore::EditorClientEfl::interpretKeyEvent):

2010-11-05 Patrick Gansterer <paroga@webkit.org>

Reviewed by David Kilzer.

Replace ARRAYSIZE with WTF_ARRAY_LENGTH
https://bugs.webkit.org/show_bug.cgi?id=48903

  • WebCoreSupport/WebChromeClient.cpp: (WebChromeClient::exceededDatabaseQuota):
  • WebKitDLL.cpp: (DllGetClassObject):
  • WebView.cpp: (WebView::mouseWheel):
02:47 Changeset [71400] by ukai@chromium.org

Unreviewed.

Fix wrong test_expectation format.

  • platform/chromium/test_expectations.txt:
02:42 Changeset [71399] by rolandsteiner@chromium.org

2010-11-05 Roland Steiner <rolandsteiner@chromium.org>

Reviewed by Dirk Schulze.

Bug 48979 - [Chromium] SVGListPropertyTearOff.h: function commitChange ASSERTs on Win & Mac
https://bugs.webkit.org/show_bug.cgi?id=48979

Remove Chromium expectation entry.

  • platform/chromium/test_expectations.txt:

2010-11-05 Roland Steiner <rolandsteiner@chromium.org>

Reviewed by Dirk Schulze.

Bug 48979 - [Chromium] SVGListPropertyTearOff.h: function commitChange ASSERTs on Win & Mac
https://bugs.webkit.org/show_bug.cgi?id=48979

Function removeItemValuesAndWrappers(): Move code out of 'if' statement so that
'wrappers' and 'values' stay synced.

test: svg/dom/baseVal-animVal-crash.html doesn't ASSERT

  • svg/properties/SVGListProperty.h: (WebCore::SVGListProperty::removeItemValuesAndWrappers):
02:14 Changeset [71398] by eric@webkit.org

2010-11-05 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

build-webkit spams system.log by repeatedly checking for PBXProductDirectory in com.apple.Xcode
https://bugs.webkit.org/show_bug.cgi?id=49051

This is a speculative fix. The unit tests cover these methods, however
I don't know if this will fully stop the system.log spam.

  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
02:08 Changeset [71397] by ukai@chromium.org

Unreviewed, updating Chromium expectations.

Add failure for crbug 62025 and 62026

  • platform/chromium/test_expectations.txt:
01:29 Changeset [71396] by commit-queue@webkit.org

2010-11-05 John Reck <jreck@google.com>

Reviewed by Nikolas Zimmermann.

The change to SVGPropertyTearOff by CodeGeneratorV8.pm caused two build failures
for Android. One was a missing SVGPropertyTearOff.h include, the other was a
missing forward declaration of FloatRect. Seems to be the result of:
https://bugs.webkit.org/show_bug.cgi?id=48204

Bug: https://bugs.webkit.org/show_bug.cgi?id=49025

No tests needed, fixes build issue.

  • bindings/scripts/CodeGeneratorV8.pm:
01:04 Changeset [71395] by rwlbuis@webkit.org

2010-11-05 Rob Buis <rwlbuis@gmail.com>

Reviewed by David Hyatt.

CSSRule#parentRule always null
https://bugs.webkit.org/show_bug.cgi?id=46228

Ensure MediaList child rules have the MediaList set as parent
in order to correct their parentRule correctness.

Test: fast/dom/css-mediarule-parentRule.html

  • css/CSSMediaRule.cpp: (WebCore::CSSMediaRule::CSSMediaRule):
00:58 Changeset [71394] by eric@webkit.org

2010-11-05 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Add basic support for showing bot id on /queue-status/ pages
https://bugs.webkit.org/show_bug.cgi?id=49037

This support is really simple. Eventually we'll want to
show the bot id in the lock table too, but we don't have
that information stored in the server yet.

  • QueueStatusServer/handlers/queuestatus.py:
  • QueueStatusServer/handlers/queuestatus_unittest.py: Added.
  • QueueStatusServer/templates/includes/singlequeuestatus.html:

11/04/10:

22:08 Changeset [71393] by tonikitoo@webkit.org

2010-11-03 Antonio Gomes <tonikitoo@webkit.org>, Andre Pedralho <andre.pedralho@gmail.com>

Reviewed by Kenneth Rohde Christiansen and Antti Koivisto.

[Qt] Making effective use of nodesFromRect.
https://bugs.webkit.org/show_bug.cgi?id=44089

Patch adds a helper class (named TouchAdjuster) to improve tap actions
on mobile touch devices. TouchAdjuster makes use of the newly added rect
based hit test extension through the Document::nodesFromRect method.
Given a rectangle as input, nodesFromRect returns a z-index ordered list
of nodes whose boundaries intersect the rectangle.

Basically the TouchAdjuster class intercepts the QGraphicsSceneMouseEvent
passed to both QWebPagePrivate::mouse{Press,Release}Event methods before
they are passed down to WebCore. The goal is to infer the target click position.
For that, a rectangle is built up using the event position as a center point and
expanding it based on the values and directions set in the Platform Plugin
QWebTouchModifier::hitTestPadding.

TouchAdjuster iterates over the list of nodes returned by nodesFromRect and
picks the clickable one that has the largest intersection area with the hit
test rectangle. The target position is then the center point of this intersection
area.

In case of no clickable node intersects the hit test area, the click position
is not altered.

TouchAdjuster is *only* working for QGraphicsWebView based views.

  • Api/qwebpage.cpp: (QWebPagePrivate::mousePressEvent): (QWebPagePrivate::mouseReleaseEvent): (QWebPagePrivate::adjustPointForClicking): (QWebPagePrivate::TouchAdjuster::TouchAdjuster): (QWebPagePrivate::TouchAdjuster::findCandidatePointForTouch): (isClickableElement): (hasMouseListener): (isValidFrameOwner): (nodeToElement):
  • Api/qwebpage_p.h:
21:58 Changeset [71392] by morrita@google.com

2010-11-04 MORITA Hajime <morrita@google.com>

Reviewed by Kent Tamura.

Expectation of /editing/spelling/spelling-textarea.html is confusing
https://bugs.webkit.org/show_bug.cgi?id=48818

  • Turned spelling-contenteditable.html and spelling-textarea.html into single script-test named spelling-hasspellingmarker.html, which uses shouldBe() family for the assertion. The original tests misused testPassed() for printing.
  • Added a test for <input>, which possibly goes different path from editing <textarea> and @contentEditable.
  • Added a "false" case test to catch the error that results true for anything.
  • editing/spelling/script-tests/spelling-hasspellingmarker.js: Added.
  • editing/spelling/spelling-contenteditable-expected.txt: Removed.
  • editing/spelling/spelling-contenteditable.html: Removed.
  • editing/spelling/spelling-hasspellingmarker-expected.txt: Added.
  • editing/spelling/spelling-hasspellingmarker.html: Added.
  • editing/spelling/spelling-textarea-expected.txt: Removed.
  • editing/spelling/spelling-textarea.html: Removed.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/qt/Skipped:
21:47 Changeset [71391] by commit-queue@webkit.org

2010-11-04 usaini <usaini08@gmail.com>

Reviewed by Antonio Gomes.

WebWindowFeatures has a faulty constructor for WebCore::WindowFeatures
https://bugs.webkit.org/show_bug.cgi?id=48035

  • public/WebWindowFeatures.h: (WebKit::WebWindowFeatures::WebWindowFeatures): updated the constructor that takes in a WebCore::WindowFeature and had it copy all the variables over properly so that after calling the constructor WebWindowFeatures is always in a valid state. Before, the x,y,width,height booleans may be true, but the corresponding int values would not be updated.
21:41 Changeset [71390] by tonikitoo@webkit.org

2010-11-04 Antonio Gomes <agomes@rim.com>

Rubber-stamped by Martin Robinson.

[Gtk] fast/events/spatial-navigation/snav-iframe-flattening-simple.html fails
https://bugs.webkit.org/show_bug.cgi?id=47587

Frame flattening support was added to GTK+ by r69919 in bug 38650. Tests passes now.

  • platform/gtk/Skipped:
21:33 Changeset [71389] by xan@webkit.org

2010-11-04 Xan Lopez <xlopez@igalia.com>

Fix the GTK+ build.

  • GNUmakefile.am:
21:31 Changeset [71388] by tonikitoo@webkit.org

2010-10-20 Chang Shu <chang.shu@nokia.com>, Antonio Gomes <tonikitoo@webkit.org>

Reviewed by Simon Fraser.

Spatial Navigation: add support to <input type=text> and <textarea>
https://bugs.webkit.org/show_bug.cgi?id=37153

Before this patch, the focus cannot move away from input box once it is in. This patch allows focus
move to neighbor nodes when the caret reaches the edge of the texts. This patch does not support yet
cases where the focused <input> has a JS handler for the arrow keys.

WebCore:

Tests: fast/events/spatial-navigation/snav-input.html
fast/events/spatial-navigation/snav-textarea.html

  • editing/EditorCommand.cpp: (WebCore::executeMoveDown): (WebCore::executeMoveLeft): (WebCore::executeMoveRight): (WebCore::executeMoveUp):
  • editing/SelectionController.cpp: (WebCore::SelectionController::modify):

WebKit/qt:

  • WebCoreSupport/EditorClientQt.cpp: WebCore::EditorClientQt::handleKeyboardEvent):

LayoutTests:

  • fast/events/spatial-navigation/snav-input-expected.txt: Added.
  • fast/events/spatial-navigation/snav-input.html: Added.
  • fast/events/spatial-navigation/snav-textarea-expected.txt: Added.
  • fast/events/spatial-navigation/snav-textarea.html: Added.
21:07 Changeset [71387] by mrobinson@webkit.org

2010-11-04 Martin Robinson <mrobinson@igalia.com>

Skip two new tests. One of which is only failing on the
bots and the other which uses the meter element, which is
currently unsupported on GTK+.

  • platform/gtk/Skipped: Skip two more tests.
20:58 Changeset [71386] by mitz@apple.com

Build fix.

  • editing/Editor.cpp:

(WebCore::Editor::dismissCorrectionPanel):

20:48 Changeset [71385] by mitz@apple.com

reversion bubble in WebViews
https://bugs.webkit.org/show_bug.cgi?id=47630
<rdar://problem/8530960>

Patch by Jia Pu <jpu@apple.com> on 2010-11-04
Reviewed by Dan Bernstein.

WebCore:

Added manual test:
manual-tests/autocorrection/continue-typing-to-dismiss-reversion.html
manual-tests/autocorrection/delete-to-dismiss-reversion.html
manual-tests/autocorrection/delete-to-end-of-word-to-show-reversion.html
manual-tests/autocorrection/move-to-end-of-word-to-show-reversion.html
manual-tests/autocorrection/type-whitespace-to-dismiss-reversion.html

We can only manully test this feature for two reasons:

  1. On Mac OS X, the result of spell checking is partly determined by past user usage. We can't realiably generating test cases until we can disable user custom data during spell checking.
  2. To exerciese this feature, we need a minimum of 0.3 second delay using WebCore timer.

This patch is to add reversion to correction panel. It consists of following major code changes:

  1. Collected all autocorrection related member variables in Editor into a CorrectionPanelInfo class to improve readability.
  2. Changed signature of Editor::startCorrectionPanelTimer() to allow caller to specify the type of correction panel--regular correction or reversion.
  3. Made necessary changes to adopt reversion API in AppKit.
  4. Use SUPPORT_CORRECTION_PANEL macro to improve readability.
  • GNUmakefile.am: Added CorrectionPanelInfo.h.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj:
  • editing/CorrectionPanelInfo.h: Added.
  • editing/Editor.cpp:

(WebCore::Editor::respondToChangedSelection): Start correction panel timer for reversion when

the new selection is a caret selection at end of a previously corrected word.

(WebCore::Editor::appliedEditing): Stop timer at the beginning of the method instead of at the end.
(WebCore::Editor::~Editor): Adopted new method dismissCorrectionPanel().
(WebCore::Editor::markMisspellingsAfterTypingToPosition): Adopted new method applyCorrectionPanelInfo().
(WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): Code change for new m_correctionPanelInfo

member variable.

(WebCore::Editor::correctionPanelTimerFired): Change to handle reversion panel type.
(WebCore::Editor::handleRejectedCorrection): Ditto.
(WebCore::Editor::startCorrectionPanelTimer): Changed signature to allow passing in panel type.
(WebCore::Editor::stopCorrectionPanelTimer): Adopted macro SUPPORT_CORRECTION_PANEL.
(WebCore::Editor::handleCancelOperation): Ditto.
(WebCore::Editor::isShowingCorrectionPanel): Ditto.
(WebCore::Editor::dismissCorrectionPanel): Update m_correctionPanelInfo when correction panel

is dismissed.

(WebCore::Editor::applyCorrectionPanelInfo): Factored out code that applies autocorrection.
(WebCore::Editor::changeSelectionAfterCommand): Adopt macro SUPPORT_CORRECTION_PANEL.

  • editing/Editor.h: Adopted CorrectionPanelInfo and add new member methods.
  • editing/EditorCommand.cpp: Adopted macro SUPPORT_CORRECTION_PANEL

(WebCore::createCommandMap):

  • editing/TypingCommand.cpp: Adopted macro SUPPORT_CORRECTION_PANEL and new signature of startCorrectionPanelTimer().

(WebCore::TypingCommand::markMisspellingsAfterTyping):

  • loader/EmptyClients.h:

(WebCore::EmptyEditorClient::showCorrectionPanel): Adopted new signature of base class method.
(WebCore::EmptyEditorClient::dismissCorrectionPanel): Ditto.

  • manual-tests/autocorrection/continue-typing-to-dismiss-reversion.html: Added.
  • manual-tests/autocorrection/delete-to-dismiss-reversion.html: Added.
  • manual-tests/autocorrection/delete-to-end-of-word-to-show-reversion.html: Added.
  • manual-tests/autocorrection/move-to-end-of-word-to-show-reversion.html: Added.
  • manual-tests/autocorrection/type-whitespace-to-dismiss-reversion.html: Added.
  • page/EditorClient.h: Changed signature of showCorrectionPanel() and dismissCorrectionPanel().
  • platform/graphics/mac/GraphicsContextMac.mm: Added comment to improve readability.

(WebCore::GraphicsContext::drawLineForTextChecking):

WebKit/mac:

This patch is to add reversion to correction panel. Please see WebCore/ChangeLog for detail.

  • WebCoreSupport/WebEditorClient.h: Adopted new signature of base class method.
  • WebCoreSupport/WebEditorClient.mm: Adopted new signature of base class method. And code change to use new reversion API in AppKit.

(WebEditorClient::WebEditorClient):
(WebEditorClient::~WebEditorClient):
(WebEditorClient::respondToChangedSelection):
(WebEditorClient::showCorrectionPanel):
(WebEditorClient::dismissCorrectionPanel):
(WebEditorClient::isShowingCorrectionPanel):

WebKit2:

This patch is to add reversion to correction panel. Please see WebCore/ChangeLog for detail.

  • WebProcess/WebCoreSupport/WebEditorClient.h: Adopted new signature of base class method.
  • WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm: Ditto.

(WebKit::WebEditorClient::showCorrectionPanel):
(WebKit::WebEditorClient::dismissCorrectionPanel):

20:39 Changeset [71384] by mitz@apple.com

Updated test result from previous commit, as I removed tabs from the test before committing
but forgot to update the result.

  • platform/mac/fast/table/border-collapsing/004-vertical-expected.txt:
19:51 Changeset [71383] by dpranke@chromium.org

2010-11-04 Dirk Pranke <dpranke@chromium.org>

Reviewed by Adam Barth.

Create a filesystem wrapper that we can use to enforce
particular conventions and use for mocking and dependency
injection down the line.

https://bugs.webkit.org/show_bug.cgi?id=48144

  • Scripts/webkitpy/common/system/filesystem.py: Added.
  • Scripts/webkitpy/common/system/filesystem_unittest.py: Added.
19:43 Changeset [71382] by mitz@apple.com

WebCore: Made table layout and painting work with all writing modes. Hit-testing, repainting, tables
where some elements have their own layers, and cells whose writing mode differs from the
table’s are not supported yet.

Reviewed by Dave Hyatt.

Make tables work with vertical text
https://bugs.webkit.org/show_bug.cgi?id=46417

Tests: fast/table/027-vertical.html

fast/table/028-vertical.html
fast/table/035-vertical.html
fast/table/038-vertical.html
fast/table/040-vertical.html
fast/table/auto-with-percent-height-vertical.html
fast/table/border-collapsing/001-vertical.html
fast/table/border-collapsing/002-vertical.html
fast/table/border-collapsing/003-vertical.html
fast/table/border-collapsing/004-vertical.html
fast/table/border-collapsing/border-collapsing-head-foot-vertical.html
fast/table/border-collapsing/equal-precedence-resolution-vertical.html
fast/table/border-collapsing/rtl-border-collapsing-vertical.html
fast/table/colspanMinWidth-vertical.html
fast/table/fixed-with-auto-with-colspan-vertical.html
fast/table/growCellForImageQuirk-vertical.html
fast/table/height-percent-test-vertical.html
fast/table/percent-widths-stretch-vertical.html
fast/table/rowspan-paint-order-vertical.html
fast/table/table-display-types-vertical.html

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::adjustRenderStyle): Changed to allow all writing modes for tables,
make row groups, rows, column groups and columns inherit the table’s writing mode. For now,
make cells do this too.

  • html/HTMLTableElement.cpp:

(WebCore::HTMLTableElement::parseMappedAttribute): Map align=center using logical properties.

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::RenderTable): Initialize m_borderStart and m_borderEnd.
(WebCore::RenderTable::styleDidChange): Changed the rule for when to use auto layout to look
at the logical width instead of the width.
(WebCore::RenderTable::computeLogicalWidth): Uses logical widths and works with perpendicular
containing blocks.
(WebCore::RenderTable::layout): Use logical lengths.
(WebCore::RenderTable::setCellLogicalWidths): Renamed setCellWidths() to this and updated for
the renaming of RenderTableSection::setCellWidths().
(WebCore::RenderTable::paintObject): Account for flipped modes.
(WebCore::RenderTable::subtractCaptionRect): Added this helper method the considers writing modes.
(WebCore::RenderTable::paintBoxDecorations): Adopted subtractCaptionRect().
(WebCore::RenderTable::paintMask): Ditto.
(WebCore::RenderTable::computePreferredLogicalWidths): Updated for the renaming of
recalcHorizontalBorders().
(WebCore::RenderTable::calcBorderStart): Renamed calcBorderLeft() to this and changed it to use
borderStart(). Splits odd number of pixels based on the physical side.
(WebCore::RenderTable::calcBorderEnd): Similar.
(WebCore::RenderTable::recalcBordersInRowDirection): Renamed recalcHorizontalBorders() to this
and updated for other renames.
(WebCore::RenderTable::borderBefore): Replaced borderTop() with this.
(WebCore::RenderTable::borderAfter): Similar.
(WebCore::RenderTable::outerBorderBefore): Similar.
(WebCore::RenderTable::outerBorderAfter): Similar.
(WebCore::RenderTable::outerBorderStart): Similar.
(WebCore::RenderTable::outerBorderEnd): Similar.
(WebCore::RenderTable::firstLineBoxBaseline): Changed to use logical heights.
(WebCore::RenderTable::overflowClipRect): Account for writing modes.

  • rendering/RenderTable.h:

(WebCore::RenderTable::borderStart):
(WebCore::RenderTable::borderEnd):
(WebCore::RenderTable::borderLeft):
(WebCore::RenderTable::borderRight):
(WebCore::RenderTable::borderTop):
(WebCore::RenderTable::borderBottom):
(WebCore::RenderTable::outerBorderLeft):
(WebCore::RenderTable::outerBorderRight):
(WebCore::RenderTable::outerBorderTop):
(WebCore::RenderTable::outerBorderBottom):
(WebCore::RenderTable::bordersPaddingAndSpacingInRowDirection): Changed to match its name.

  • rendering/RenderTableRow.cpp:

(WebCore::RenderTableRow::styleWillChange): Changed to detect changes to logical height.

  • rendering/RenderTableSection.cpp:

(WebCore::setRowLogicalHeightToRowStyleLogicalHeightIfNotRelative): Renamed and changed to use
logical heights.
(WebCore::RenderTableSection::RenderTableSection): Updated initializers for new member variables.
(WebCore::RenderTableSection::addChild): Updated for rename.
(WebCore::RenderTableSection::ensureRows): Ditto.
(WebCore::RenderTableSection::addCell): Ditto. Also use logical heights.
(WebCore::RenderTableSection::setCellLogicalWidths): Renamed setCellWidths() to this, changed
to use logical widths.
(WebCore::RenderTableSection::calcRowLogicalHeight): Added “logical” to the name. Updated with
logical heights.
(WebCore::RenderTableSection::layoutRows):
(WebCore::RenderTableSection::calcOuterBorderBefore):
(WebCore::RenderTableSection::calcOuterBorderAfter):
(WebCore::RenderTableSection::calcOuterBorderStart):
(WebCore::RenderTableSection::calcOuterBorderEnd):
(WebCore::RenderTableSection::recalcOuterBorder):
(WebCore::RenderTableSection::firstLineBoxBaseline):
(WebCore::RenderTableSection::paintCell):
(WebCore::RenderTableSection::recalcCells):

  • rendering/RenderTableSection.h:

(WebCore::RenderTableSection::outerBorderBefore):
(WebCore::RenderTableSection::outerBorderAfter):
(WebCore::RenderTableSection::outerBorderStart):
(WebCore::RenderTableSection::outerBorderEnd):

LayoutTests: Make tables work with vertical text
https://bugs.webkit.org/show_bug.cgi?id=46417

Reviewed by Dave Hyatt.

  • fast/table/027-vertical.html: Copied from LayoutTests/fast/table/027.html.
  • fast/table/028-vertical.html: Copied from LayoutTests/fast/table/028.html.
  • fast/table/035-vertical.html: Copied from LayoutTests/fast/table/035.html.
  • fast/table/038-vertical.html: Copied from LayoutTests/fast/table/038.html.
  • fast/table/040-vertical.html: Copied from LayoutTests/fast/table/040.html.
  • fast/table/auto-with-percent-height-vertical.html: Copied from LayoutTests/fast/table/auto-with-percent-height.html.
  • fast/table/border-collapsing/001-vertical.html: Copied from LayoutTests/fast/table/border-collapsing/001.html.
  • fast/table/border-collapsing/002-vertical.html: Copied from LayoutTests/fast/table/border-collapsing/002.html.
  • fast/table/border-collapsing/003-vertical.html: Copied from LayoutTests/fast/table/border-collapsing/003.html.
  • fast/table/border-collapsing/004-vertical.html: Copied from LayoutTests/fast/table/border-collapsing/004.html.
  • fast/table/border-collapsing/border-collapsing-head-foot-vertical.html: Copied from LayoutTests/fast/table/border-collapsing/border-collapsing-head-foot.html.
  • fast/table/border-collapsing/equal-precedence-resolution-vertical.html: Copied from LayoutTests/fast/table/border-collapsing/equal-precedence-resolution.html.
  • fast/table/border-collapsing/rtl-border-collapsing-vertical.html: Copied from LayoutTests/fast/table/border-collapsing/rtl-border-collapsing.html.
  • fast/table/colspanMinWidth-vertical.html: Copied from LayoutTests/fast/table/colspanMinWidth.html.
  • fast/table/fixed-with-auto-with-colspan-vertical.html: Copied from LayoutTests/fast/table/fixed-with-auto-with-colspan.html.
  • fast/table/growCellForImageQuirk-vertical.html: Copied from LayoutTests/fast/table/growCellForImageQuirk.html.
  • fast/table/height-percent-test-vertical.html: Copied from LayoutTests/fast/table/height-percent-test.html.
  • fast/table/percent-widths-stretch-vertical.html: Copied from LayoutTests/fast/table/percent-widths-stretch.html.
  • fast/table/rowspan-paint-order-vertical.html: Copied from LayoutTests/fast/table/rowspan-paint-order.html.
  • fast/table/table-display-types-vertical.html: Copied from LayoutTests/fast/table/table-display-types.html.
  • platform/mac/fast/table/027-vertical-expected.checksum: Added.
  • platform/mac/fast/table/027-vertical-expected.png: Added.
  • platform/mac/fast/table/027-vertical-expected.txt: Added.
  • platform/mac/fast/table/028-vertical-expected.checksum: Added.
  • platform/mac/fast/table/028-vertical-expected.png: Added.
  • platform/mac/fast/table/028-vertical-expected.txt: Added.
  • platform/mac/fast/table/035-vertical-expected.checksum: Added.
  • platform/mac/fast/table/035-vertical-expected.png: Added.
  • platform/mac/fast/table/035-vertical-expected.txt: Added.
  • platform/mac/fast/table/038-vertical-expected.checksum: Added.
  • platform/mac/fast/table/038-vertical-expected.png: Added.
  • platform/mac/fast/table/038-vertical-expected.txt: Added.
  • platform/mac/fast/table/040-vertical-expected.checksum: Added.
  • platform/mac/fast/table/040-vertical-expected.png: Added.
  • platform/mac/fast/table/040-vertical-expected.txt: Added.
  • platform/mac/fast/table/auto-with-percent-height-vertical-expected.checksum: Added.
  • platform/mac/fast/table/auto-with-percent-height-vertical-expected.png: Added.
  • platform/mac/fast/table/auto-with-percent-height-vertical-expected.txt: Added.
  • platform/mac/fast/table/border-collapsing/001-vertical-expected.checksum: Added.
  • platform/mac/fast/table/border-collapsing/001-vertical-expected.png: Added.
  • platform/mac/fast/table/border-collapsing/001-vertical-expected.txt: Added.
  • platform/mac/fast/table/border-collapsing/002-vertical-expected.checksum: Added.
  • platform/mac/fast/table/border-collapsing/002-vertical-expected.png: Added.
  • platform/mac/fast/table/border-collapsing/002-vertical-expected.txt: Added.
  • platform/mac/fast/table/border-collapsing/003-vertical-expected.checksum: Added.
  • platform/mac/fast/table/border-collapsing/003-vertical-expected.png: Added.
  • platform/mac/fast/table/border-collapsing/003-vertical-expected.txt: Added.
  • platform/mac/fast/table/border-collapsing/004-vertical-expected.checksum: Added.
  • platform/mac/fast/table/border-collapsing/004-vertical-expected.png: Added.
  • platform/mac/fast/table/border-collapsing/004-vertical-expected.txt: Added.
  • platform/mac/fast/table/border-collapsing/border-collapsing-head-foot-vertical-expected.checksum: Added.
  • platform/mac/fast/table/border-collapsing/border-collapsing-head-foot-vertical-expected.png: Added.
  • platform/mac/fast/table/border-collapsing/border-collapsing-head-foot-vertical-expected.txt: Added.
  • platform/mac/fast/table/border-collapsing/equal-precedence-resolution-vertical-expected.checksum: Added.
  • platform/mac/fast/table/border-collapsing/equal-precedence-resolution-vertical-expected.png: Added.
  • platform/mac/fast/table/border-collapsing/equal-precedence-resolution-vertical-expected.txt: Added.
  • platform/mac/fast/table/border-collapsing/rtl-border-collapsing-vertical-expected.checksum: Added.
  • platform/mac/fast/table/border-collapsing/rtl-border-collapsing-vertical-expected.png: Added.
  • platform/mac/fast/table/border-collapsing/rtl-border-collapsing-vertical-expected.txt: Added.
  • platform/mac/fast/table/colspanMinWidth-vertical-expected.checksum: Added.
  • platform/mac/fast/table/colspanMinWidth-vertical-expected.png: Added.
  • platform/mac/fast/table/colspanMinWidth-vertical-expected.txt: Added.
  • platform/mac/fast/table/fixed-with-auto-with-colspan-vertical-expected.checksum: Added.
  • platform/mac/fast/table/fixed-with-auto-with-colspan-vertical-expected.png: Added.
  • platform/mac/fast/table/fixed-with-auto-with-colspan-vertical-expected.txt: Added.
  • platform/mac/fast/table/growCellForImageQuirk-vertical-expected.checksum: Added.
  • platform/mac/fast/table/growCellForImageQuirk-vertical-expected.png: Added.
  • platform/mac/fast/table/growCellForImageQuirk-vertical-expected.txt: Added.
  • platform/mac/fast/table/height-percent-test-vertical-expected.checksum: Added.
  • platform/mac/fast/table/height-percent-test-vertical-expected.png: Added.
  • platform/mac/fast/table/height-percent-test-vertical-expected.txt: Added.
  • platform/mac/fast/table/percent-widths-stretch-vertical-expected.checksum: Added.
  • platform/mac/fast/table/percent-widths-stretch-vertical-expected.png: Added.
  • platform/mac/fast/table/percent-widths-stretch-vertical-expected.txt: Added.
  • platform/mac/fast/table/rowspan-paint-order-vertical-expected.checksum: Added.
  • platform/mac/fast/table/rowspan-paint-order-vertical-expected.png: Added.
  • platform/mac/fast/table/rowspan-paint-order-vertical-expected.txt: Added.
  • platform/mac/fast/table/table-display-types-vertical-expected.checksum: Added.
  • platform/mac/fast/table/table-display-types-vertical-expected.png: Added.
  • platform/mac/fast/table/table-display-types-vertical-expected.txt: Added.
19:29 Changeset [71381] by inferno@chromium.org

Merge 71377

BUG=60013

19:10 Changeset [71380] by mihaip@chromium.org

2010-11-04 Mihai Parparita <mihaip@chromium.org>

Reviewed by Tony Chang.

run_webkit_tests_unittest fails under Python 2.5
https://bugs.webkit.org/show_bug.cgi?id=49043

Switch from itertools.chain.from_iterable (which was added in 2.6)
to using itertools.chain directly.

  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
18:57 Changeset [71379] by tkent@chromium.org

2010-11-04 Kent Tamura <tkent@chromium.org>

Unreviewed, trivial test fix.

Fix GTK build for http://trac.webkit.org/changeset/71373 .

  • GNUmakefile.am: Add HTMLOutputElement.{cpp,h}
18:26 Changeset [71378] by mihaip@chromium.org

2010-11-04 Mihai Parparita <mihaip@chromium.org>

Unreviewed fix to webkit-patch rebaseline-server so that it runs under
Python 2.5 (it needs an import to use the with statement).

  • Scripts/webkitpy/tool/commands/rebaselineserver.py:
18:23 Changeset [71377] by morrita@google.com

2010-11-04 MORITA Hajime <morrita@google.com>

Reviewed by Kent Tamura.

Stale reference to RenderObject held as FrameView layoutRoot
https://bugs.webkit.org/show_bug.cgi?id=48019

  • fast/dom/HTMLMeterElement/meter-element-with-child-crash-expected.txt: Added.
  • fast/dom/HTMLMeterElement/meter-element-with-child-crash.html: Added.
  • fast/dom/HTMLProgressElement/progress-element-with-child-crash-expected.txt: Added.
  • fast/dom/HTMLProgressElement/progress-element-with-child-crash.html: Added.
  • platform/mac/fast/dom/HTMLMeterElement/meter-element-expected.txt:

2010-11-04 MORITA Hajime <morrita@google.com>

Reviewed by Kent Tamura.

Stale reference to RenderObject held as FrameView layoutRoot
https://bugs.webkit.org/show_bug.cgi?id=48019

<progress> and <meter> shouldn't have children of its RenderObject,
which caused unexpected result.
This change suppresses child creation to prevent it.

Tests: fast/dom/HTMLMeterElement/meter-element-with-child-crash.html

fast/dom/HTMLProgressElement/progress-element-with-child-crash.html

  • rendering/RenderIndicator.h: (WebCore::RenderIndicator::canHaveChildren):
18:18 Changeset [71376] by mrobinson@webkit.org

2010-11-04 Martin Robinson <mrobinson@igalia.com>

Unskip some passing tests and update some baselines.

  • platform/gtk/Skipped: Update skipped list.
  • platform/gtk/http/tests/misc/slow-loading-mask-expected.txt: Added.
  • platform/gtk/transforms/2d/transform-borderbox-expected.txt:
  • platform/gtk/transforms/2d/transform-origin-borderbox-expected.txt:
18:16 Changeset [71375] by xan@webkit.org

2010-11-04 Xan Lopez <xlopez@igalia.com>

Reviewed by Adam Barth.

Use leakRef instead of releaseRef
https://bugs.webkit.org/show_bug.cgi?id=48974

Use leakRef instead of the deprecated releaseRef. This was renamed
some time ago because 'releaseRef' is too close to 'release',
which does something completely different.

18:05 Changeset [71374] by dpranke@chromium.org

2010-11-04 Dirk Pranke <dpranke@chromium.org>

Reviewed by Adam Barth.

new-run-webkit-tests: split out webkit-specific configuration stuff into a new module

The current NRWT code has webkit-specific configuration code (like
_script_path, default configuration, etc.) mixed in with
layout-test-specific stuff in port/base. The configuration code
should be split out into a separate module for easier mocking,
testing, and isolation.

https://bugs.webkit.org/show_bug.cgi?id=48264

  • Scripts/webkitpy/layout_tests/port/config.py: Added.
  • Scripts/webkitpy/layout_tests/port/config_unittest.py: Added.
17:57 Changeset [71373] by commit-queue@webkit.org

2010-11-04 Kenichi Ishibashi <bashi@google.com>

Reviewed by Kent Tamura.

[HTML5][Forms] Support for <output> element
https://bugs.webkit.org/show_bug.cgi?id=29363

Adds tests for the DOMSettableTokenList and the output element.

  • fast/dom/HTMLOutputElement/dom-settable-token-list-expected.txt: Added.
  • fast/dom/HTMLOutputElement/dom-settable-token-list.html: Added.
  • fast/dom/HTMLOutputElement/htmloutputelement-expected.txt: Added.
  • fast/dom/HTMLOutputElement/htmloutputelement-reset-event-expected.txt: Added.
  • fast/dom/HTMLOutputElement/htmloutputelement-reset-event.html: Added.
  • fast/dom/HTMLOutputElement/htmloutputelement-validity-expected.txt: Added.
  • fast/dom/HTMLOutputElement/htmloutputelement-validity.html: Added.
  • fast/dom/HTMLOutputElement/htmloutputelement-value-expected.txt: Added.
  • fast/dom/HTMLOutputElement/htmloutputelement-value.html: Added.
  • fast/dom/HTMLOutputElement/htmloutputelement.html: Added.
  • fast/dom/HTMLOutputElement/script-tests/dom-settable-token-list.js: Added. (createElement):
  • fast/dom/HTMLOutputElement/script-tests/htmloutputelement-reset-event.js: Added.
  • fast/dom/HTMLOutputElement/script-tests/htmloutputelement-validity.js: Added.
  • fast/dom/HTMLOutputElement/script-tests/htmloutputelement-value.js: Added.
  • fast/dom/Window/window-properties-expected.txt: Updated expectation.
  • fast/dom/Window/window-property-descriptors-expected.txt: Updated expectation.
  • fast/dom/prototype-inheritance-2-expected.txt: Updated expectation.
  • fast/dom/prototype-inheritance-expected.txt: Updated expectation.
  • fast/js/global-constructors-expected.txt: Updated expectation.
  • platform/chromium/fast/dom/prototype-inheritance-expected.txt: Updated expectation.
  • platform/gtk/fast/dom/Window/window-properties-expected.txt: Updated expectation.
  • platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt: Updated expectation.
  • platform/gtk/fast/dom/prototype-inheritance-expected.txt: Updated expectation.
  • platform/gtk/fast/js/global-constructors-expected.txt: Updated expectation.
  • platform/qt/fast/dom/Window/window-properties-expected.txt: Updated expectation.
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt: Updated expectation.
  • platform/qt/fast/dom/prototype-inheritance-expected.txt: Updated expectation.
  • platform/qt/fast/js/global-constructors-expected.txt: Updated expectation.
  • platform/win/fast/dom/Window/window-property-descriptors-expected.txt: Updated expectation.
  • platform/win/fast/dom/prototype-inheritance-2-expected.txt: Updated expectation.
  • platform/win/fast/dom/prototype-inheritance-expected.txt: Updated expectation.
  • platform/win/fast/js/global-constructors-expected.txt: Updated expectation.

2010-11-04 Kenichi Ishibashi <bashi@google.com>

Reviewed by Kent Tamura.

[HTML5][Forms] Support for <output> element
https://bugs.webkit.org/show_bug.cgi?id=29363

Support for <output> element.

Tests: fast/dom/HTMLOutputElement/dom-settable-token-list.html

fast/dom/HTMLOutputElement/htmloutputelement-reset-event.html
fast/dom/HTMLOutputElement/htmloutputelement-validity.html
fast/dom/HTMLOutputElement/htmloutputelement-value.html
fast/dom/HTMLOutputElement/htmloutputelement.html

  • Android.derived.jscbindings.mk: Added JSHTMLOutputElement.h.
  • Android.derived.v8bindings.mk: Added V8HTMLOutputElement.h.
  • Android.jscbindings.mk: Added JSHTMLOutputElementCustom.cpp.
  • Android.mk: Added HTMLOutputElement.cpp.
  • Android.v8bindings.mk: Added V8HTMLOutputElementCustom.cpp.
  • CMakeLists.txt: Added HTMLOutputElement.{idl,cpp} and JSHTMLOutputElementCustom.cpp.
  • DerivedSources.cpp: Added JSHTMLOutputElement.cpp.
  • DerivedSources.make: Added HTMLOutputElement entry.
  • GNUmakefile.am: Added JSHTMLOutputElement.{cpp,h}
  • WebCore.gypi: Added HTMLOutputElement.{idl,cpp,h}, JSHTMLOutputElementCustom.cpp and V8HTMLOutputElementCustom.cpp
  • WebCore.pri: Added HTMLOutputElement.idl.
  • WebCore.pro: Added V8HTMLOutputElementCustom.cpp, JSHTMLOutputElementCustom.cpp and HTMLOutputElement.cpp.
  • WebCore.vcproj/WebCore.vcproj: Added entries for JSHTMLOutputElement.{cpp,h} and JSHTMLOutputElementCustom.cpp.
  • WebCore.xcodeproj/project.pbxproj: Added entries for JSHTMLOutputElementCustom.cpp, HTMLOutputElement.{cpp,h,idl}, JSHTMLOutputElement.{cpp,h}
  • bindings/js/JSBindingsAllInOne.cpp: Added JSHTMLOutputElementCustom.cpp.
  • bindings/js/JSHTMLOutputElementCustom.cpp: Added. (WebCore::JSHTMLOutputElement::htmlFor): (WebCore::JSHTMLOutputElement::setHtmlFor):
  • bindings/v8/custom/V8DOMSettableTokenListCustom.cpp: Modified. (WebCore::V8DOMSettableTokenList::indexedPropertyGetter): Returns null if the index is out of range.
  • bindings/v8/custom/V8HTMLOutputElementCustom.cpp: Added. (WebCore::V8HTMLOutputElement::htmlForAccessorGetter): (WebCore::V8HTMLOutputElement::htmlForAccessorSetter):
  • css/html.css: Added a default style of output element. (output):
  • html/DOMSettableTokenList.cpp: Fix bugs. (WebCore::DOMSettableTokenList::item): Returns null string if the index is out of range. (WebCore::DOMSettableTokenList::addInternal): Added check m_tokens.isNull(). (WebCore::DOMSettableTokenList::setValue): Set the value case sensitive.
  • html/HTMLOutputElement.cpp: Added. (WebCore::HTMLOutputElement::HTMLOutputElement): (WebCore::HTMLOutputElement::create): (WebCore::HTMLOutputElement::formControlType): (WebCore::HTMLOutputElement::parseMappedAttribute): (WebCore::HTMLOutputElement::htmlFor): (WebCore::HTMLOutputElement::setFor): (WebCore::HTMLOutputElement::setForm): (WebCore::HTMLOutputElement::childrenChanged): (WebCore::HTMLOutputElement::reset): (WebCore::HTMLOutputElement::value): (WebCore::HTMLOutputElement::setValue): (WebCore::HTMLOutputElement::defaultValue): (WebCore::HTMLOutputElement::setDefaultValue): (WebCore::HTMLOutputElement::setTextContentInternal):
  • html/HTMLOutputElement.h: Added. (WebCore::HTMLOutputElement::isEnumeratable): (WebCore::HTMLOutputElement::willValidate):
  • html/HTMLOutputElement.idl: Added.
  • html/HTMLTagNames.in: Added "output".
  • page/DOMWindow.idl: Added an attribute for HTMLOutputElement.
17:55 Changeset [71372] by zmo@google.com

2010-11-04 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Remove IMPLEMENTATION_COLOR_READ_FORMAT and TYPE
https://bugs.webkit.org/show_bug.cgi?id=48938

  • src/WebGraphicsContext3DDefaultImpl.cpp: (WebKit::WebGraphicsContext3DDefaultImpl::getIntegerv):

2010-11-04 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Remove IMPLEMENTATION_COLOR_READ_FORMAT and TYPE
https://bugs.webkit.org/show_bug.cgi?id=48938

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::initializeNewContext): (WebCore::WebGLRenderingContext::getParameter): (WebCore::WebGLRenderingContext::readPixels):
  • html/canvas/WebGLRenderingContext.h:
  • html/canvas/WebGLRenderingContext.idl:
  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp: (WebCore::GraphicsContext3D::getIntegerv):

2010-11-04 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Remove IMPLEMENTATION_COLOR_READ_FORMAT and TYPE
https://bugs.webkit.org/show_bug.cgi?id=48938

  • fast/canvas/webgl/read-pixels-pack-alignment-expected.txt:
  • fast/canvas/webgl/read-pixels-pack-alignment.html:
  • fast/canvas/webgl/webgl-specific-expected.txt:
  • fast/canvas/webgl/webgl-specific.html: Test two enums are undefined in WebGL.
17:52 Changeset [71371] by zmo@google.com

2010-11-04 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

TypedArray should throw exception if length not a multiple of element size
https://bugs.webkit.org/show_bug.cgi?id=45487

  • bindings/js/JSArrayBufferViewHelper.h: (WebCore::constructArrayBufferView):
  • bindings/v8/custom/V8ArrayBufferViewCustom.h: (WebCore::constructWebGLArray):

2010-11-04 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

TypedArray should throw exception if length not a multiple of element size
https://bugs.webkit.org/show_bug.cgi?id=45487

  • fast/canvas/webgl/array-unit-tests-expected.txt:
  • fast/canvas/webgl/array-unit-tests.html: Test against the non-multiplication exception behavior.
  • fast/canvas/webgl/gl-enum-tests-expected.txt:
  • fast/canvas/webgl/gl-enum-tests.html: Fix the ArrayBuffer size so it won't throw an error with this patch.
17:33 Changeset [71370] by kbr@google.com

2010-11-04 Kenneth Russell <kbr@google.com>

Reviewed by Adam Barth.

[chromium] Mac: WebGL: all textured content is blue
https://bugs.webkit.org/show_bug.cgi?id=49021

Added support for 8-bit, little-endian CGImages. The previous
image decode path used the default byte order, which is apparently
big-endian.

Tested with various WebGL content and layout tests in Chromium.
Ran layout tests in WebKit and tested various WebGL content in
Safari. Was not able to run layout tests with Chromium port of
DumpRenderTree due to build failures currently in the tree.

  • platform/graphics/GraphicsContext3D.cpp: (WebCore::doPacking):
  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/cg/GraphicsContext3DCG.cpp: (WebCore::getSourceDataFormat): (WebCore::GraphicsContext3D::getImageData):

2010-11-04 Kenneth Russell <kbr@google.com>

Reviewed by Adam Barth.

[chromium] Mac: WebGL: all textured content is blue
https://bugs.webkit.org/show_bug.cgi?id=49021

Updated expectations for WebGL layout tests which were affected by
the image decoder change
https://bugs.webkit.org/show_bug.cgi?id=47974 .

  • platform/chromium/test_expectations.txt:
17:28 Changeset [71369] by mihaip@chromium.org

2010-11-02 Mihai Parparita <mihaip@chromium.org>

Reviewed by Tony Chang.

Rebaseline server: initial framework
https://bugs.webkit.org/show_bug.cgi?id=48892

Adds the basic framework for the rebaseline server (details at
http://webkit.org/b/47761). Includes the rebaseline-server webkit-patch
command, which starts an HTTP server that can serve static files or
invoke handler methods on a class.

  • Scripts/webkitpy/tool/commands/init.py:
  • Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html: Added.
  • Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css: Added.
  • Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js: Added.
  • Scripts/webkitpy/tool/commands/rebaselineserver.py: Added.
17:08 Changeset [71368] by mihaip@chromium.org

Merge 71170 - 2010-11-02 Mihai Parparita <mihaip@chromium.org>

Reviewed by Adam Barth.

[Chromium] Crash when encountering history.back() call during Page::goToItem execution
https://bugs.webkit.org/show_bug.cgi?id=48477

Add a reduced version of the page that was originally reported at
http://crbug.com/59554.

  • http/tests/history/back-during-onload-triggered-by-back-expected.txt: Added.
  • http/tests/history/back-during-onload-triggered-by-back.html: Added.
  • http/tests/history/resources/back-during-onload-container.html: Added.
  • http/tests/history/resources/back-during-onload-hung-page.php: Added.
  • http/tests/history/resources/back-during-onload-middle.html: Added.

2010-11-02 Mihai Parparita <mihaip@chromium.org>

Reviewed by Adam Barth.

[Chromium] Crash when encountering history.back() call during Page::goToItem execution
https://bugs.webkit.org/show_bug.cgi?id=48477

For the Chromium port, BackForwardList::itemAtIndex synthesizes a
HistoryItem and saves a pointer to it in m_pendingItem. During
Page::goToItem we call FrameLoader::stopAllLoaders, which can trigger
onload handlers (if a subframe was not considered committed by the frame
loader). If one of those handlers calls calls history.back() or another
operation that ends up in NavigationScheduler::scheduleHistoryNavigation,
we would call BackForwardList::itemAtIndex, which means that we would
lose the m_pendingItem RefPtr that pointed to the item being navigated
to, causing its ref count to go to 0*, and thus for the HistoryItem to
be deleted before we were done navigating to it.

This is fixed in two ways:

  • Add a protector RefPtr in Page::goToItem to make sure that the item is still around for when we pass it to HistoryController:goToItem.
  • Change NavigationScheduler::scheduleHistoryNavigation to not use BackForwardList::itemAtIndex and instead look at the forward/backListCount() (since it doesn't actually care about the returned HistoryItem).

Test: http/tests/history/back-during-onload-triggered-by-back.html

  • loader/NavigationScheduler.cpp: (WebCore::NavigationScheduler::scheduleHistoryNavigation):
  • page/Page.cpp: (WebCore::Page::goToItem):

TBR=mihaip@chromium.org

16:57 Changeset [71367] by zmo@google.com

2010-11-03 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

renderbufferStorage(DEPTH_STENCIL) shouldn't generate an error
https://bugs.webkit.org/show_bug.cgi?id=48891

  • html/canvas/WebGLFramebuffer.cpp: (WebCore::WebGLFramebuffer::isIncomplete): Considering the case where DEPTH_STENCIL is not supported.
  • html/canvas/WebGLRenderbuffer.cpp: (WebCore::WebGLRenderbuffer::WebGLRenderbuffer): Init added members.
  • html/canvas/WebGLRenderbuffer.h: Add members and accessor functions. (WebCore::WebGLRenderbuffer::setInternalFormat): (WebCore::WebGLRenderbuffer::setSize): (WebCore::WebGLRenderbuffer::getWidth): (WebCore::WebGLRenderbuffer::getHeight): (WebCore::WebGLRenderbuffer::setIsValid): (WebCore::WebGLRenderbuffer::isValid):
  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::initializeNewContext): Check if packed_depth_stencil extension exists. (WebCore::WebGLRenderingContext::getRenderbufferParameter): Simulate the case for DEPTH_STENCIL where packed_depth_stencil is not supported. (WebCore::WebGLRenderingContext::renderbufferStorage): Bypass the call if packed_depth_stencil is not supported.
  • html/canvas/WebGLRenderingContext.h:

2010-11-03 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

renderbufferStorage(DEPTH_STENCIL) shouldn't generate an error
https://bugs.webkit.org/show_bug.cgi?id=48891

  • fast/canvas/webgl/framebuffer-object-attachment-expected.txt:
  • fast/canvas/webgl/framebuffer-object-attachment.html: Add the test cases for DEPTH_STENCIL renderbuffer.
16:34 Changeset [71366] by commit-queue@webkit.org

2010-11-04 Kavita Kanetkar <kkanetkar@chromium.org>

Reviewed by Adam Barth.

Web Inspector: Enable files ystem UI for chromium
https://bugs.webkit.org/show_bug.cgi?id=48963

  • inspector/Inspector.idl:
  • inspector/InspectorFileSystemAgent.cpp: (WebCore::InspectorFileSystemAgent::getFileSystemPathAsync):
  • inspector/InspectorFileSystemAgent.h:
  • inspector/front-end/FileSystemView.js: (WebInspector.FileSystemView): (WebInspector.FileSystemView.prototype.setFileSystemDisabled): (WebInspector.FileSystemView.prototype._createTextAndButton): (WebInspector.FileSystemView.prototype.refreshFileSystem):
  • inspector/front-end/StoragePanel.js: (WebInspector.StoragePanel.prototype.setFileSystemDisabled):
  • inspector/front-end/inspector.js: (WebInspector.didGetFileSystemDisabled): (WebInspector.reset):

2010-11-04 Kavita Kanetkar <kkanetkar@chromium.org>

Reviewed by Adam Barth.

Web Inspector: Enable files ystem UI for chromium
https://bugs.webkit.org/show_bug.cgi?id=48963

  • src/js/DevTools.js:
16:32 Changeset [71365] by dpranke@chromium.org

2010-11-04 Dirk Pranke <dpranke@chromium.org>

Reviewed by James Robinson.

new-run-webkit-tests wasn't using DRT by default for
--platform chromium-gpu

The default value was set to False instead of None, which meant
that the platform specific logic wasn't firing to change the
value to True (b/c we were afraid we'd be overriding the user
preference).

https://bugs.webkit.org/show_bug.cgi?id=49038

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
16:31 Changeset [71364] by bweinstein@apple.com

Part of https://bugs.webkit.org/show_bug.cgi?id=45980
userscripts/user-script-*-document.html tests are flaky on Windows

Rubber-stamped by Jon Honeycutt.

Unskip userscripts/user-script-audio-document.html on Windows, because it appears to be passing
and not flaky.

  • platform/win/Skipped:
16:24 Changeset [71363] by tony@chromium.org

2010-11-04 Tony Chang <tony@chromium.org>

Reviewed by Adam Barth.

make platform/chromium/plugins/multiple-plugins.html pass on all platforms
https://bugs.webkit.org/show_bug.cgi?id=49026

Move the test from the chromium directory to the top level LayoutTests/plugins directory.

  • plugins/multiple-plugins-expected.txt: Renamed from LayoutTests/platform/chromium/plugins/multiple-plugins-expected.txt.
  • plugins/multiple-plugins.html: Renamed from LayoutTests/platform/chromium/plugins/multiple-plugins.html.

2010-11-04 Tony Chang <tony@chromium.org>

Reviewed by Adam Barth.

make platform/chromium/plugins/multiple-plugins.html pass on all platforms
https://bugs.webkit.org/show_bug.cgi?id=49026

Have the testObject.bar property return the string "bar". This lets
us run and pass platform/chromium/plugins/multiple-plugins.html on all
platforms.

  • DumpRenderTree/TestNetscapePlugIn/TestObject.cpp: (testGetProperty):
15:45 Changeset [71362] by dumi@chromium.org

Unreviewed, updating Chromium expectations.

  • platform/chromium/test_expectations.txt:
15:40 Changeset [71361] by gyuyoung.kim@samsung.com

2010-11-04 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Adam Barth.

[EFL] Enable HTML5 Video
https://bugs.webkit.org/show_bug.cgi?id=48972

Enable HTML 5 Video option for WebKit EFL.

  • cmake/OptionsEfl.cmake:
15:38 Changeset [71360] by commit-queue@webkit.org

2010-11-04 Ryuan Choi <ryuan.choi@samsung.com>

Reviewed by Adam Barth.

[EFL] Reflect latest EFL changes related to stride.
https://bugs.webkit.org/show_bug.cgi?id=48971

Remove adjustment code to compare stride of cairo_image_surfece and evas_object_image, as following changes of latest EFL.

  • ewk/ewk_util.cpp: (ewk_util_image_from_cairo_surface_add):
15:21 Changeset [71359] by mihaip@chromium.org

2010-11-04 Mihai Parparita <mihaip@chromium.org>

Reviewed by Tony Chang.

NRWT doesn't have good test coverage for --run-chunk, --batch-size, --run-part, etc.
https://bugs.webkit.org/show_bug.cgi?id=48878

Add get_tests_run so that it's easy to see which tests get run (and with
what batching) for a given flag combination. Flesh out the various
test cases that have FIXMEs.

Also fixes an off-by-one error (batch sizes were one larger than
expected) and makes --run-part also have wraparound behavior, like
--run-chunk.

  • Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
14:51 Changeset [71358] by dumi@chromium.org

Unreviewed, updating Chromium expectations.

  • platform/chromium-linux/transforms/2d/transform-borderbox-expected.checksum:
  • platform/chromium-linux/transforms/2d/transform-borderbox-expected.png:
  • platform/chromium-linux/transforms/2d/transform-borderbox-expected.txt: Added.
  • platform/chromium-linux/transforms/2d/transform-origin-borderbox-expected.checksum:
  • platform/chromium-linux/transforms/2d/transform-origin-borderbox-expected.png:
  • platform/chromium-linux/transforms/2d/transform-origin-borderbox-expected.txt: Added.
  • platform/chromium-mac/transforms/2d/transform-borderbox-expected.checksum: Added.
  • platform/chromium-mac/transforms/2d/transform-borderbox-expected.png: Added.
  • platform/chromium-mac/transforms/2d/transform-origin-borderbox-expected.checksum: Added.
  • platform/chromium-mac/transforms/2d/transform-origin-borderbox-expected.png: Added.
  • platform/chromium-win/transforms/2d/transform-borderbox-expected.checksum:
  • platform/chromium-win/transforms/2d/transform-borderbox-expected.png:
  • platform/chromium-win/transforms/2d/transform-borderbox-expected.txt:
  • platform/chromium-win/transforms/2d/transform-origin-borderbox-expected.checksum:
  • platform/chromium-win/transforms/2d/transform-origin-borderbox-expected.png:
  • platform/chromium-win/transforms/2d/transform-origin-borderbox-expected.txt:
14:35 Changeset [71357] by tony@chromium.org

2010-11-04 Tony Chang <tony@chromium.org>

Reviewed by Adam Barth.

handle plugins without mimetypes in fast/js/navigator-mimeTypes-length.html
https://bugs.webkit.org/show_bug.cgi?id=49015

This test was added in r15573 to verify that navigator.mimeTypes.length
returns the number of mimeTypes provided by plugins. However, it assumes
that there are more mimeTypes handled than plugins installed. It's
possible for a plugin to handle no mime types, so this invariant isn't
true. This often works on Win/Mac because they have a plugin that handles
multimedia files (like QuickTime), but on Linux, often there are no plugins
installed other than the test plugin (which handles 1 mime type).

Instead, add up the mime types from each plugin and verify that it
matches navigator.mimeTypes.length.

  • fast/js/navigator-mimeTypes-length-expected.txt:
  • fast/js/script-tests/navigator-mimeTypes-length.js:
  • platform/google-chrome-linux32/fast/js/navigator-mimeTypes-length-expected.txt: Removed.
14:19 Changeset [71356] by commit-queue@webkit.org

2010-11-04 Orlando Leite <orlleite@gmail.com>

Reviewed by Adam Barth.

Add Java for Mac OS X Developer Package to Installing Developer Tools web page

  • building/tools.html:
14:01 Changeset [71355] by tony@chromium.org

2010-11-04 Tony Chang <tony@chromium.org>

Reviewed by Adam Barth.

make plugins/update-widgets-crash.html resilient to multiple calls to NPP_SetWindow
https://bugs.webkit.org/show_bug.cgi?id=49013

When using the upstream TestNetscapePlugIn, on Chromium Linux, this
test passes, but setWindowCalled() is called twice before the test
is finished. This causes an exception to be thrown that 'victim'
doesn't have a parent node (since we already removed it during the
earlier call).

On different platforms, NPP_SetWindow is called a different number
of times.

  • plugins/update-widgets-crash.html:
13:41 Changeset [71354] by robert@webkit.org

2010-11-04 Robert Hogan <robert@webkit.org>

Reviewed by Darin Adler.

Stale reference to JSDOMWindow in ScriptController::m_cacheableBindingObject

Unskip fast/dom/nodesFromRect-basic.html on Qt.

https://bugs.webkit.org/show_bug.cgi?id=48758

  • platform/qt/Skipped:

2010-11-04 Robert Hogan <robert@webkit.org>

Reviewed by Darin Adler.

Stale reference to JSDOMWindow in ScriptController::m_cacheableBindingObject

After bug 37725 we need to update the globalObject() (i.e. JSDOMWindow)
associated with the m_cacheablebindingRootObject every time we clear the
frame and load a new page. This allows the runtime objects
(e.g. LayoutTestController etc.) to persist between navigations as
before but also ensures that when qt_runtime, or any other bridge,
looks at the root->globalObject() of a cacheable binding object
it gets the DOMWindow of the current page rather than the DOMWindow
that was in place when m_cacheableBindingRootObject was created.

Fixes fast/dom/nodesFromRect-basic.html on Qt.

https://bugs.webkit.org/show_bug.cgi?id=48758

  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::clearWindowShell):
  • bridge/runtime_root.cpp: (JSC::Bindings::RootObject::updateGlobalObject):
  • bridge/runtime_root.h:
13:04 Changeset [71353] by mthole@apple.com

Title for images should use localized numerals
https://bugs.webkit.org/show_bug.cgi?id=49017

Reviewed by Dan Bernstein.

WebKit:

  • English.lproj/Localizable.strings: Updated.

WebKit/mac:

  • WebCoreSupport/WebPlatformStrategies.mm:

(WebPlatformStrategies::imageTitle): Use localized numerals on Snow Leopard or newer.

12:41 Changeset [71352] by andreas.kling@nokia.com

2010-11-04 Kenneth Rohde Christiansen <kenneth@webkit.org>

Reviewed by David Hyatt.

Delegate scrolling via a separate method
https://bugs.webkit.org/show_bug.cgi?id=48988

Implement delegatedScrollRequested and make it emit the
scrollRequested signal for Qt.

  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::delegatedScrollRequested):
  • WebCoreSupport/ChromeClientQt.h:

2010-11-04 Kenneth Rohde Christiansen <kenneth@webkit.org>

Reviewed by David Hyatt.

Delegate scrolling via a separate method
https://bugs.webkit.org/show_bug.cgi?id=48988

Add a delegatedScrollRequested method to HostWindow for delegating
scrolling to the view. This is only used in conjunction with tiling,
and is ifdef'ed.

  • page/Chrome.cpp: (WebCore::Chrome::delegatedScrollRequested):
  • page/Chrome.h:
  • page/ChromeClient.h:
  • platform/HostWindow.h:
  • platform/ScrollView.cpp: (WebCore::ScrollView::setScrollPosition):

2010-11-04 Kenneth Rohde Christiansen <kenneth@webkit.org>

Reviewed by David Hyatt.

Delegate scrolling via a separate method
https://bugs.webkit.org/show_bug.cgi?id=48988

Add delegatedScrollRequested method to WebChromeClient,
which is only used in conjunging with tiling, and thus ifdef'ed.

  • WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::delegatedScrollRequested):
  • WebProcess/WebCoreSupport/WebChromeClient.h:
12:09 Changeset [71351] by pfeldman@chromium.org

2010-11-04 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Need better way of switching back to the Timeline view of the Network tab.
https://bugs.webkit.org/show_bug.cgi?id=48995

  • Moved close button to the left, preceding tab headers;
  • Auto-adjusting summary bar width when switching to the preview mode
  • Auto-scrolling network log if it was scrolled to bottom.
  • inspector/front-end/DataGrid.js: (WebInspector.DataGrid): (WebInspector.DataGrid.prototype.isScrolledToLastRow): (WebInspector.DataGrid.prototype.scrollToLastRow):
  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel): (WebInspector.NetworkPanel.prototype.updateSidebarWidth): (WebInspector.NetworkPanel.prototype._positionSummaryBar): (WebInspector.NetworkPanel.prototype.refresh): (WebInspector.NetworkPanel.prototype._reset): (WebInspector.NetworkPanel.prototype._toggleGridMode):
  • inspector/front-end/inspector.css: (.tabbed-pane-header li):
  • inspector/front-end/networkPanel.css: (.network-summary-bar): (#network-close-button): (#network-views.small #network-close-button): (#network-views .resource-view .tabbed-pane-header): (#network-views.small .resource-view .tabbed-pane-header):
12:00 Changeset [71350] by aroben@apple.com

Add a timing-out test to the Windows Skipped file

  • platform/win/Skipped:
11:46 Changeset [71349] by hclam@chromium.org

Not reviewed. Build fix.

https://bugs.webkit.org/show_bug.cgi?id=48795

Skipping 4 media tests that trigger a hang in DRT.

  • platform/chromium/test_expectations.txt:
11:35 Changeset [71348] by arv@chromium.org

2010-11-04 Erik Arvidsson <arv@chromium.org>

Reviewed by Dimitri Glazkov.

Support box-sizing without the vendor prefix
https://bugs.webkit.org/show_bug.cgi?id=36713

Based on patch by Peter Beverloo <peter@lvp-media.com>

Update the tests to use box-sizing instead of -webkit-box-sizing.

  • fast/borders/borderRadiusDashed05.html:
  • fast/css/box-sizing-backwards-compat-prefix-expected.txt: Added.
  • fast/css/box-sizing-backwards-compat-prefix.html: Added. This tests that both box-sizing and -webkit-box-sizing works.
  • fast/css/getComputedStyle/computed-style-expected.txt:
  • fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-mac/fast/css/computed-style-expected.txt:
  • platform/chromium-mac/fast/css/computed-style-without-renderer-expected.txt:
  • platform/chromium-win/fast/css/computed-style-expected.txt:
  • platform/chromium-win/fast/css/computed-style-without-renderer-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-win/transforms/2d/transform-borderbox-expected.txt:
  • platform/chromium-win/transforms/2d/transform-origin-borderbox-expected.txt:
  • platform/gtk/transforms/2d/transform-borderbox-expected.txt:
  • platform/gtk/transforms/2d/transform-origin-borderbox-expected.txt:
  • platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/mac/transforms/2d/transform-borderbox-expected.checksum:
  • platform/mac/transforms/2d/transform-borderbox-expected.txt:
  • platform/mac/transforms/2d/transform-origin-borderbox-expected.checksum:
  • platform/mac/transforms/2d/transform-origin-borderbox-expected.txt:
  • platform/qt/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • svg/css/getComputedStyle-basic-expected.txt:
  • transforms/2d/transform-borderbox.html:
  • transforms/2d/transform-origin-borderbox.html:

2010-11-04 Erik Arvidsson <arv@chromium.org>

Reviewed by Dimitri Glazkov.

Support box-sizing without the vendor prefix
https://bugs.webkit.org/show_bug.cgi?id=36713

Based on patch by Peter Beverloo <peter@lvp-media.com>

Test: fast/css/box-sizing-backwards-compat-prefix.html

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  • css/CSSParser.cpp: (WebCore::CSSParser::parseValue): (WebCore::cssPropertyID): This handles -webkit-box-sizing and maps it to box-sizing.
  • css/CSSPropertyNames.in:
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
  • css/quirks.css: Change -webkit-box-sizing to box-sizing. (input:not([type=image]), textarea):
  • css/view-source.css: Ditto. (.webkit-line-gutter-backdrop, .webkit-line-number):
  • css/wml.css: Ditto. (do): (select):

2010-11-04 Erik Arvidsson <arv@chromium.org>

Reviewed by Dimitri Glazkov.

Support box-sizing without the vendor prefix
https://bugs.webkit.org/show_bug.cgi?id=36713

Based on patch by Peter Beverloo <peter@lvp-media.com>

  • iExploder/htdocs/cssproperties.in: Change -webkit-box-sizing to box-sizing.
11:29 Changeset [71347] by enrica@apple.com

Need a way to test in WebKit2 whether a form field contains marked text
<rdar://problem/8555293>
https://bugs.webkit.org/show_bug.cgi?id=48969

Reviewed by Alexey Proskuryakov.

Added a selection changed notification from the Web process to the UI process.
The message being sent contains information about the current selection.
Event though for this specific bug the only information required is the marked text,
I've added other selection information that will be needed to support IME.
All the stubbed methods are required methods by the NSTextInput protocol.

  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::selectionChanged): Added.

  • UIProcess/API/mac/WKView.h:
  • UIProcess/API/mac/WKView.mm:

(-[WKView initWithFrame:pageNamespaceRef:]): Added initialization of new members.
(-[WKView _selectionChanged:isEditable:isPassword:hasMarkedText:]): Stores the values from
the selection changed message.
(-[WKView selectedRange]): Added stub.
(-[WKView hasMarkedText]): Implemented.
(-[WKView unmarkText]): Added stub.
(-[WKView validAttributesForMarkedText]): Added stub.
(-[WKView setMarkedText:selectedRange:]): Added stub.
(-[WKView markedRange]): Added stub.
(-[WKView attributedSubstringFromRange:]): Added stub.
(-[WKView conversationIdentifier]): Added stub.
(-[WKView characterIndexForPoint:]): Added stub.
(-[WKView firstRectForCharacterRange:]): Added stub.

  • UIProcess/API/mac/WKViewInternal.h:
  • UIProcess/API/qt/qwkpage.cpp:

(QWKPagePrivate::selectionChanged): Added.

  • UIProcess/API/qt/qwkpage_p.h:
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didSelectionChange): New message handler.

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/win/WebView.cpp:

(WebKit::WebView::selectionChanged): Added.

  • UIProcess/win/WebView.h:
  • WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::WebEditorClient::respondToChangedSelection): Added implementation.

11:02 Changeset [71346] by commit-queue@webkit.org

2010-11-04 John Reck <jreck@google.com>

Reviewed by Steve Block.

Fix a linker failure when building for Android
https://bugs.webkit.org/show_bug.cgi?id=48964

The Android stub for setCookieStoragePrivateBrowsingEnabled(bool) wasn't in the WebCore namespace, which caused
a linker failure when building for Android. Moved the stub to the WebCore namespace. This was caused by
http://trac.webkit.org/changeset/70400

No new tests, build fix only

  • platform/android/TemporaryLinkStubs.cpp:
11:01 WebKitGtkLayoutTests edited by philn@webkit.org
(diff)
10:31 Changeset [71345] by eric@webkit.org

2010-11-04 Eric Seidel <eric@webkit.org>

Reviewed by Gavin Barraclough.

REGRESSION(49798): Crash in HTMLObjectElement::parseMappedAttribute
https://bugs.webkit.org/show_bug.cgi?id=48789

The contract for all String/AtomicString methods seems to be that it's
safe to call them, even when the String is null (impl() returns 0).
This contract was broken by r49798 (unintentionally) when optimizing
for dromeo.
This patch adds a null check to AtomicString::lower() fixing this
crash and preventing future confusion.

  • wtf/text/AtomicString.cpp: (WTF::AtomicString::lower):

2010-11-04 Eric Seidel <eric@webkit.org>

Reviewed by Gavin Barraclough.

REGRESSION(49798): Crash in HTMLObjectElement::parseMappedAttribute
https://bugs.webkit.org/show_bug.cgi?id=48789

  • fast/dom/HTMLObjectElement/set-type-to-null-crash-expected.txt: Added.
  • fast/dom/HTMLObjectElement/set-type-to-null-crash.html: Added.
10:25 Changeset [71344] by andreas.kling@nokia.com

2010-11-04 Balazs Kelemen <kbalazs@webkit.org>

Reviewed by Andreas Kling.

[Qt][WK2] Cleanup UpdateChunk and MappedMemoryPool
https://bugs.webkit.org/show_bug.cgi?id=48994

  • Platform/qt/MappedMemoryPool.cpp: (WebKit::MappedMemoryPool::mapMemory): Removed argument with default value that was always used with the default value. (WebKit::MappedMemoryPool::mapFile): Ditto and add some asserts.
  • Platform/qt/MappedMemoryPool.h: Encapsulating MappedMemory and remove the unused MappedMemoryPool::searchForMappedMemory method. (WebKit::MappedMemory::mappedFile): (WebKit::MappedMemory::markFree): (WebKit::MappedMemory::data): (WebKit::MappedMemory::MappedMemory): (WebKit::MappedMemory::markUsed): (WebKit::MappedMemory::mapSize): (WebKit::MappedMemory::isFree): (WebKit::MappedMemoryPool::instance):
  • Shared/qt/UpdateChunk.cpp: Removed the unused data method besides other cleanups. (WebKit::UpdateChunk::UpdateChunk): (WebKit::UpdateChunk::encode): (WebKit::UpdateChunk::decode): (WebKit::UpdateChunk::createImage):
  • Shared/qt/UpdateChunk.h:
10:17 Changeset [71343] by andreas.kling@nokia.com

2010-11-04 Andreas Kling <kling@webkit.org>

Reviewed by Tor Arne Vestbø.

[Qt] Add a stub WebContextMenuProxy

This is the Qt equivalent of r71333.

  • UIProcess/API/qt/qwkpage.cpp: (QWKPagePrivate::createContextMenuProxy):
  • UIProcess/qt/WebContextMenuProxyQt.cpp: Added. (WebKit::WebContextMenuProxyQt::WebContextMenuProxyQt): (WebKit::WebContextMenuProxyQt::create): (WebKit::WebContextMenuProxyQt::showContextMenu): (WebKit::WebContextMenuProxyQt::hideContextMenu):
  • UIProcess/qt/WebContextMenuProxyQt.h: Added.
  • WebKit2.pro:
10:16 Changeset [71342] by ossy@webkit.org

Unreviewed rollout r71340, because it broke Chromium Windows bot.

  • Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
09:51 WebKit Team edited by reni@webkit.org
(diff)
09:44 Changeset [71341] by joepeck@webkit.org

2010-11-04 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by Andreas Kling.

Request.h getters can be made const
https://bugs.webkit.org/show_bug.cgi?id=49003

Added the const qualifier to some getters that don't mutate the object.

  • loader/Request.h: (WebCore::Request::cachedResource): (WebCore::Request::cachedResourceLoader): (WebCore::Request::isIncremental): (WebCore::Request::isMultipart):
09:44 Changeset [71340] by ossy@webkit.org

Make http locking default in NRWT.
https://bugs.webkit.org/show_bug.cgi?id=48053

Patch by Gabor Rapcsanyi <rgabor@inf.u-szeged.hu> on 2010-11-04
Reviewed by Ojan Vafai.

  • Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
09:38 Changeset [71339] by bweinstein@apple.com

User scripts shouldn't be injected in a frame's empty initial document.
https://bugs.webkit.org/show_bug.cgi?id=48970
<rdar://problem/8618164>
<rdar://problem/8082122>

Reviewed by Brady Eidson.

WebCore:

When a frame loads, it first creates an empty initial document, then navigates to the correct URL. Our
current policy with user scripts is to inject them into both the initial empty document, and then inject
them again.

This causes developers to think their scripts have been injected twice into all iframes, and there is a timing
issue between WebKit1 and WebKit2 that causes start scripts to be injected into the initial empty document
of the main frame when a new tab or window is created.

The fix for this is to not inject user scripts when the frame is creating its initial empty document before loading
the correct source.

  • page/Frame.cpp:

(WebCore::Frame::injectUserScripts):

LayoutTests:

Update userscripts tests to reflect the fact that start scripts are not injected
in the initial load of about:blank in an iframe anymore.

This patch also makes the tests more verbose, and the results clearer to understand
by printing out the URLs of the documents that ran the content scripts.

  • userscripts/script-not-run-for-fragments-expected.txt:
  • userscripts/script-not-run-for-fragments.html:
  • userscripts/script-run-at-start-expected.txt:
  • userscripts/user-script-audio-document-expected.txt:
  • userscripts/user-script-audio-document.html:
  • userscripts/user-script-image-document-expected.txt:
  • userscripts/user-script-image-document.html:
  • userscripts/user-script-plugin-document-expected.txt:
  • userscripts/user-script-plugin-document.html:
  • userscripts/user-script-video-document-expected.txt:
  • userscripts/user-script-video-document.html:
09:08 Changeset [71338] by ossy@webkit.org

[NRWT] Clear invalid http locks on Windows platform as well
https://bugs.webkit.org/show_bug.cgi?id=48515

Patch by Gabor Rapcsanyi <rgabor@inf.u-szeged.hu> on 2010-11-04
Reviewed by Eric Seidel.

  • Scripts/webkitpy/common/system/executive.py:
  • Scripts/webkitpy/common/system/executive_unittest.py:
  • Scripts/webkitpy/layout_tests/port/http_lock.py:
08:47 Changeset [71337] by andreas.kling@nokia.com

2010-11-04 Andreas Kling <kling@webkit.org>

Reviewed by Nikolas Zimmermann.

GraphicsContext: Don't do full save/restore when painting with low quality scaling
https://bugs.webkit.org/show_bug.cgi?id=48738

Stash the imageInterpolationQuality() in a local and reset it after painting.

  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::drawImage): (WebCore::GraphicsContext::drawTiledImage): (WebCore::GraphicsContext::drawImageBuffer):
  • platform/graphics/haiku/GraphicsContextHaiku.cpp: (WebCore::GraphicsContext::imageInterpolationQuality):
  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::imageInterpolationQuality):
  • platform/graphics/wince/GraphicsContextWinCE.cpp: (WebCore::GraphicsContext::imageInterpolationQuality):
08:24 Changeset [71336] by aroben@apple.com

Reduce our dependence on coreutils when running Python tests

This patch introduces versions of the standard echo and cat utilities
implemented in Python. They are probably missing features of their
coreutils equivalents, but they can do what's necessary for our Python
tests. This is useful on Windows, where these utilities typically
aren't available.

Fixes <http://webkit.org/b/48883> executive_unittest relies on echo
and cat utilities from coreutils, which are not present on Windows

Reviewed by Eric Seidel.

  • Scripts/webkitpy/common/system/executive_unittest.py: Changed to use

our Python-based echo and cat.

  • Scripts/webkitpy/common/system/fileutils.py: Added.

(make_stdout_binary): On Windows, puts sys.stdout into binary mode so
that \n won't be translated into \r\n. I couldn't think of a good way
to test this directly without touching the filesystem, but it is tested
indirectly by echo_unittest.

  • Scripts/webkitpy/test/cat.py: Added.

(command_arguments): Returns a list for invoking cat with the given arguments.
(main): Acts like a simplified version of the coreutils cat utility.

  • Scripts/webkitpy/test/cat_unittest.py: Added.

(CatTest.assert_cat): Runs cat with the given input and ensures the
output matches the input.
(CatTest.test_basic): Performs a simple test of cat.
(CatTest.test_no_newline): Tests what happens when the input string
doesn't have a trailing newline.
(CatTest.test_unicode): Tests passing a unicode string to cat.
(CatTest.test_as_command): Tests running cat as a separate command.

  • Scripts/webkitpy/test/echo.py: Added.

(command_arguments): Returns a list for invoking echo with the given arguments.
(main): Acts like a simplified version of the coreutils echo utility.

  • Scripts/webkitpy/test/echo_unittest.py: Added.

(EchoTest.test_basic): Performs a simple test of echo.
(EchoTest.test_no_newline): Tests passing -n to echo to suppress the
trailing newline.
(EchoTest.test_unicode): Tests passing unicode and non-unicode strings
to echo.
(EchoTest.test_argument_order): Tests what happens when -n is not the
first argument.
(EchoTest.test_empty_arguments): Tests what happens when you pass [] to
echo.main.
(EchoTest.test_no_arguments): Tests what happens when you call
echo.main with no arguments.
(EchoTest.test_as_command): Tests running echo as a separate command.

08:04 WebKit Team edited by reni@webkit.org
(diff)
08:00 Changeset [71335] by reni@webkit.org

Unreviewed: Add myself to the list of Committers.

  • Scripts/webkitpy/common/config/committers.py:
07:51 Changeset [71334] by aroben@apple.com

Add more failing tests to the Windows Skipped file

  • platform/win/Skipped:
07:31 Changeset [71333] by aroben@apple.com

Add a do-nothing WebContextMenuProxy implementation on Windows

Fixes <http://webkit.org/b/48992> REGRESSION (r71041): Crash in
WebPageProxy::showContextMenu when right-clicking in WebKit2 on
Windows

Reviewed by Dan Bernstein.

  • UIProcess/win/WebContextMenuProxyWin.cpp: Added.

(WebKit::WebContextMenuProxyWin::WebContextMenuProxyWin):
(WebKit::WebContextMenuProxyWin::create):
(WebKit::WebContextMenuProxyWin::showContextMenu):
(WebKit::WebContextMenuProxyWin::hideContextMenu):

  • UIProcess/win/WebContextMenuProxyWin.h: Added.

Just stubbed-out this class.

  • UIProcess/win/WebView.cpp:

(WebKit::WebView::createContextMenuProxy): Create a new
WebContextMenuProxyWin and return it. Returning 0 results in a crash.

  • win/WebKit2.vcproj: Added WebContextMenuProxyWin.
06:45 Changeset [71332] by andreas.kling@nokia.com

2010-11-04 Andreas Kling <kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Hook into QWebPage::scrollRequested for resizes-to-contents mode

In RTC mode the QGraphicsWebView item is the size of the contents,
scrolling works a bit differently (we need to react to scrollRequested.)

Normally QGraphicsView will replay the last mouse event when scrolling,
so to prevent WebKit from getting confused by this we temporarily make
the QGraphicsView non-interactive.

  • QtTestBrowser/webview.cpp: (WebViewGraphicsBased::setPage): (WebViewGraphicsBased::scrollRequested):
  • QtTestBrowser/webview.h:
06:34 Changeset [71331] by vestbo@webkit.org

Use OS(MAC_OS_X) rather than PLATFORM(MAC) in TestControllerQt

Reviewed by Andreas Kling.

PLATFORM(MAC) is not defined for the Qt port, as it refers to
the Mac-port, not the Mac OS X operating system.

  • WebKitTestRunner/qt/TestControllerQt.cpp:

(WTR::isExistingLibrary):

06:24 Changeset [71330] by vestbo@webkit.org

[Qt] Build Webkit2 both in debug and release on Mac

Reviewed by Andreas Kling..

On Mac OS X we build QtWebKit in both debug and release, so
we need to also build the webkit2 library in both configs.

  • WebKit2.pro:
06:06 Changeset [71329] by zimmermann@webkit.org

2010-11-04 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Andreas Kling.

Refactor SVGStringListPropertyTearOff/SVGListPropertyTearOff to use a common base class
https://bugs.webkit.org/show_bug.cgi?id=48990

Introduce SVGListProperty as common base class between static lists (SVGStringListPropertyTearOff) and dynamic lists (SVGListPropertyTearOff).
This is a preparation for the addition of the next static list type: SVGPointList.

  • GNUmakefile.am: Add new files to build.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • bindings/scripts/CodeGenerator.pm: s/SVGStringListPropertyTearOff/SVGStaticListPropertyTearOff/.
  • bindings/scripts/CodeGeneratorJS.pm: Ditto.
  • bindings/scripts/CodeGeneratorObjC.pm: Ditto.
  • bindings/scripts/CodeGeneratorV8.pm: Ditto.
  • svg/properties/SVGAnimatedListPropertyTearOff.h: Include SVGStaticListPropertyTearOff.h here, to avoid special dependencies in CodeGenerator*.pm
  • svg/properties/SVGListProperty.h: Added.
  • svg/properties/SVGListPropertyTearOff.h: Use SVGList API implementation from SVGListProperty base class.
  • svg/properties/SVGStaticListPropertyTearOff.h: Added. Use SVGList API implementation from SVGListProperty base class.
  • svg/properties/SVGStringListPropertyTearOff.h: Removed.
05:42 Changeset [71328] by rniwa@webkit.org

2010-11-04 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed. Fixed WebCore.xcodeproject

  • WebCore.xcodeproj/project.pbxproj:
05:39 Changeset [71327] by aroben@apple.com

Remove lame puts()s from WebPageProxy

Rubber-stamped by Anders Carlsson.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::loadURL):
(WebKit::WebPageProxy::loadURLRequest):

05:34 Changeset [71326] by jeremy@chromium.org

2010-11-04 Jeremy Moskovich <jeremy@chromium.org>

No review - new baselines.

New Linux & Windows baselines for LayoutTests/fast/block/basic/truncation-rtl.html

https://bugs.webkit.org/show_bug.cgi?id=48917

  • platform/chromium-linux/fast/block/basic/truncation-rtl-expected.checksum: Added.
  • platform/chromium-linux/fast/block/basic/truncation-rtl-expected.png: Added.
  • platform/chromium-win/fast/block/basic/truncation-rtl-expected.checksum: Added.
  • platform/chromium-win/fast/block/basic/truncation-rtl-expected.png: Added.
  • platform/chromium-win/fast/block/basic/truncation-rtl-expected.txt: Added.
05:29 Changeset [71325] by commit-queue@webkit.org

2010-11-04 Leonid Ebril <leonid.ebril@nokia.com>

Reviewed by Andreas Kling.

[Qt] Adding iphone user agent string the user agent list for QtTestBrowser
https://bugs.webkit.org/show_bug.cgi?id=48869

  • QtTestBrowser/useragentlist.txt:
05:26 Changeset [71324] by aroben@apple.com

Skip fast/dom/webtiming-document-open.html on Windows

Web Timing isn't implemented yet on Windows. We could check in
platform-specific results for this test, but all other Web Timing tests
are skipped.

  • platform/win/Skipped:
04:38 Changeset [71323] by aroben@apple.com

Skip editing/style/iframe-onload-crash.html on Windows

It crashes there, too.

  • platform/win/Skipped:
04:34 Changeset [71322] by alex@webkit.org

2010-11-04 Alejandro G. Castro <alex@igalia.com>

Unreviewed. Added fast/dom/webtiming-document-open.html to the
Skipped file, it was added in r71313, timing is disabled also in gtk.

  • platform/gtk/Skipped:
04:33 Changeset [71321] by aroben@apple.com

Always use uppercase drive names in strings returned by abspath_to_uri

Some versions of cygpath use lowercase drive letters while others use
uppercase, which makes it hard to test the output of code that uses
cygpath.

Fixes <http://webkit.org/b/48914> webkitpy.common.system.path_unittest
fails with Cygwin 1.5

Reviewed by Eric Seidel.

  • Scripts/webkitpy/common/system/path.py:

(cygpath): Updated the docstring to indicate that only absolute paths
should be passed for now (though relative paths will work fine).
(_Cygpath.convert): Upper-case the first letter of the converted Windows path.

04:17 Changeset [71320] by ossy@webkit.org

Unreviewed.

[Qt] svg/animations/animate-path-nested-transforms.html fails
https://bugs.webkit.org/show_bug.cgi?id=48987

  • platform/qt/Skipped: svg/animations/animate-path-nested-transforms.html skipped until fix.
03:13 Changeset [71319] by ossy@webkit.org

Unreviewed.

[Qt] REGRESSION (r71288): editing/style/iframe-onload-crash.html crashes
https://bugs.webkit.org/show_bug.cgi?id=48967

  • platform/qt/Skipped:
    • fast/dom/webtiming-document-open.html added, because web timing is disabled. (test introduced in r71313)
    • editing/style/iframe-onload-crash.html added until fix.
03:10 Changeset [71318] by commit-queue@webkit.org

2010-11-04 Pratik Solanki <psolanki@apple.com>

Reviewed by Darin Adler.

Should make use of purge priorities for different resource types
https://bugs.webkit.org/show_bug.cgi?id=48684

Assign purge priorities to CachedResource objects. JavaScript and CSS stylesheets are more
important than images so hint to the kernel to purge them last. We do this by repurposing
the previously unused function, PurgeableBuffer::setPurgePriority(). It now just sets the
priority field and does not have side-effects like calling makePurgeable(true).

Also, remove unusued PurgeableBuffer::create(const Vector<char>&) function and move the
purgeable memory size threshold from CachedResource to PurgeableBuffer.

  • WebCore.xcodeproj/project.pbxproj: Add new PurgePriority.h header and mark it as private header.
  • loader/CachedCSSStyleSheet.h: (WebCore::CachedCSSStyleSheet::purgePriority):
  • loader/CachedImage.h: (WebCore::CachedImage::purgePriority):
  • loader/CachedResource.cpp: (WebCore::CachedResource::makePurgeable): Set the purge priority on the PurgeableBffer. Also, move the check for purgeable size threshold to PurgeableBuffer.
  • loader/CachedResource.h: (WebCore::CachedResource::purgePriority): Added. New virtual method that lets the class specify its purge priority.
  • loader/CachedScript.h: (WebCore::CachedScript::purgePriority):
  • platform/PurgePriority.h: Added. Move the PurgePriority enum from PurgeableBuffer class to its own header file. (WebCore::):
  • platform/PurgeableBuffer.h: (WebCore::PurgeableBuffer::setPurgePriority): Update this previously unused function to just set the priority and not call makePurgeable(true).
  • platform/mac/PurgeableBufferMac.cpp: Update size threshold to 16KB which is what CachedResource was using.
02:59 Changeset [71317] by commit-queue@webkit.org

2010-11-04 Chris Guillory <chris.guillory@google.com>

Reviewed by Chris Fleizach.

Ignore static text children of text field controls in the accessibility tree.
https://bugs.webkit.org/show_bug.cgi?id=48944

  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
02:24 Changeset [71316] by arv@chromium.org

2010-11-04 Erik Arvidsson <arv@chromium.org>

Reviewed by Tony Chang.

Computed style is not correct for negative values in the presence of zooming
https://bugs.webkit.org/show_bug.cgi?id=48855

Updated the test to include some negative values. I also added tests for zoom less than one which in turn
forced me to increase the values because we lose a lot of precision when zooming out.

  • fast/css/getComputedStyle/computed-style-with-zoom-expected.txt: Updated the expectations
  • fast/css/getComputedStyle/script-tests/computed-style-with-zoom.js: Updated tests.

2010-11-04 Erik Arvidsson <arv@chromium.org>

Reviewed by Tony Chang.

Computed style is not correct for negative values in the presence of zooming
https://bugs.webkit.org/show_bug.cgi?id=48855

  • rendering/style/RenderStyle.h: (WebCore::adjustForAbsoluteZoom): When the value is less than zero we need to decrement instead of increment.
02:22 Changeset [71315] by robert@webkit.org

2010-11-04 Robert Hogan <robert@webkit.org>

Reviewed by Andreas Kling.

[Qt] Clarify expected return values of innerXml(), outerXml()

If you put HTML in (e.g. using setHTML()) you will get HTML out,
even if you marked it up as XML.

https://bugs.webkit.org/show_bug.cgi?id=44876

  • Api/qwebelement.cpp:
01:49 Changeset [71314] by commit-queue@webkit.org

2010-11-04 Shane Stephens <shanestephens@google.com>

Reviewed by Tony Chang.

SVGStyledTransformableElement supplemental transforms pre-multiplied
but should be post-multiplied.
https://bugs.webkit.org/show_bug.cgi?id=48026

  • svg/animations/animate-path-nested-transforms-expected.txt: Added.
  • svg/animations/animate-path-nested-transforms.svg: Added.

2010-11-04 Shane Stephens <shanestephens@google.com>

Reviewed by Tony Chang.

SVGStyledTransformableElement supplemental transforms pre-multiplied
but should be post-multiplied.
https://bugs.webkit.org/show_bug.cgi?id=48026

Test: svg/animations/animate-path-nested-transforms.svg

  • svg/SVGStyledTransformableElement.cpp: (WebCore::SVGStyledTransformableElement::animatedLocalTransform):

Switched order of multiplication. Note that due to a bug in
AffineTransform's operator* implementation the order of arguments is
reversed (see http://bugs.webkit.org/show_bug.cgi?id=48031).

01:36 Changeset [71313] by commit-queue@webkit.org

2010-11-04 James Simonsen <simonjam@chromium.org>

Reviewed by Darin Fisher.

[Web Timing] Implement dom* timing marks
https://bugs.webkit.org/show_bug.cgi?id=46301

  • fast/dom/Window/window-properties-performance-expected.txt:
  • fast/dom/script-tests/webtiming-async.js: Added.
  • fast/dom/script-tests/webtiming-defer.js: Added.
  • fast/dom/script-tests/webtiming-document-open.js: Added. (testTimingWithDocumentOpen):
  • fast/dom/script-tests/webtiming-navigate-within-document.js: (checkTimingNotChanged): Added dom timing.
  • fast/dom/script-tests/webtiming.js: (checkTimingBeforeLoad): Added dom timing. (checkTimingWhileDeferred): Added. (checkWebTimingWhileAsync): Added. (checkWebTimingOnLoad): Added dom timing. (checkWebTimingAfterLoad): Added dom timing.
  • fast/dom/webtiming-document-open-expected.txt: Added.
  • fast/dom/webtiming-document-open.html: Added.
  • fast/dom/webtiming-expected.txt:
  • fast/dom/webtiming-navigate-within-document-expected.txt:
  • fast/dom/webtiming.html: Added async and defer tests.
  • platform/mac/Skipped: Skip new webtiming test.

2010-11-04 James Simonsen <simonjam@chromium.org>

Reviewed by Darin Fisher.

[Web Timing] Implement dom* timing marks
https://bugs.webkit.org/show_bug.cgi?id=46301

Test: fast/dom/webtiming-document-open.html

  • GNUmakefile.am: Added DocumentTiming.h
  • WebCore.gypi: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • dom/Document.cpp: (WebCore::Document::setReadyState): Set DOM WebTiming marks. (WebCore::Document::finishedParsing): Set DOM WebTiming marks.
  • dom/Document.h: (WebCore::Document::timing): Added.
  • dom/DocumentTiming.h: Added. (WebCore::DocumentTiming::DocumentTiming):
  • page/Timing.cpp: Added DOM timing. (WebCore::Timing::domLoading): Ditto. (WebCore::Timing::domInteractive): Ditto. (WebCore::Timing::domContentLoaded): Ditto. (WebCore::Timing::domComplete): Ditto. (WebCore::Timing::documentTiming): Ditto.
  • page/Timing.h: Ditto.
  • page/Timing.idl: Ditto.
01:23 Changeset [71312] by commit-queue@webkit.org

2010-11-04 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Implement unencodable characters handling in TextCodecGtk::encode()
https://bugs.webkit.org/show_bug.cgi?id=48902

Fixes a crash in test fast/encoding/char-encoding.html.

  • platform/text/gtk/TextCodecGtk.cpp: (WebCore::TextCodecGtk::encode):
00:12 Changeset [71311] by abarth@webkit.org

2010-11-04 Adam Barth <abarth@webkit.org>

Enabled ICCJPEG on Chromium Mac
https://bugs.webkit.org/show_bug.cgi?id=48977

  • wtf/Platform.h:

2010-11-04 Adam Barth <abarth@webkit.org>

Enabled ICCJPEG on Chromium Mac
https://bugs.webkit.org/show_bug.cgi?id=48977

Add iccjpeg as a dependency.

  • WebCore.gyp/WebCore.gyp:
00:00 Changeset [71310] by abarth@webkit.org

2010-11-03 Adam Barth <abarth@webkit.org>

Roll Chromium DEPS
https://bugs.webkit.org/show_bug.cgi?id=48978

  • DEPS:

11/03/10:

23:58 Changeset [71309] by tkent@chromium.org

Framework to show form validation message for invalid controls
https://bugs.webkit.org/show_bug.cgi?id=31718

Reviewed by Dimitri Glazkov.

HTMLFormElement::validateInteractively() shows a validation message for
an invalid control by HTMLFormControlElement::updateVisibleValidationMessage(),
and the message is hidden when the invalid control looses focus, becomes
valid, detached, or the form is submitted again.

Introduce ValidationMessage class to manage visible form validation
message. It has no implementation to show/hide a message yet.

No new tests. New behavior is disabled by default, and is timing-dependent.

  • Android.mk: Add ValidationMessage.
  • CMakeLists.txt: ditto.
  • GNUmakefile.am: ditto.
  • WebCore.gypi: ditto.
  • WebCore.pro: ditto.
  • WebCore.vcproj/WebCore.vcproj: ditto.
  • WebCore.xcodeproj/project.pbxproj: ditto.
  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::detach): Hides a validation message.
(WebCore::HTMLFormControlElement::setNeedsWillValidateCheck):

Hides a validation message if validation is not needed.

(WebCore::HTMLFormControlElement::updateVisibleValidationMessage):
(WebCore::HTMLFormControlElement::hideVisibleValidationMessage):
(WebCore::HTMLFormControlElement::setNeedsValidityCheck):

Hides a validation message or updates the validation message.

(WebCore::HTMLFormControlElement::dispatchBlurEvent):

Hides a validation message.

(WebCore::HTMLFormControlElement::visibleValidationMessage):

  • html/HTMLFormControlElement.h:
  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::validateInteractively):

  • Hide existing validation messages before showing new message.
  • Show new validation message.
  • html/ValidationMessage.cpp: Added.

(WebCore::ValidationMessage::ValidationMessage):
(WebCore::ValidationMessage::~ValidationMessage):
(WebCore::ValidationMessage::create):
(WebCore::ValidationMessage::setMessage):
(WebCore::ValidationMessage::hideMessage):

  • html/ValidationMessage.h: Added.

(WebCore::ValidationMessage::message):

23:54 Changeset [71308] by rolandsteiner@chromium.org

2010-11-03 Roland Steiner <rolandsteiner@chromium.org>

Unreviewed: add new entry to Chromium test_expectations.txt

  • platform/chromium/test_expectations.txt:
22:36 Changeset [71307] by paroga@webkit.org

2010-11-03 Patrick Gansterer <paroga@webkit.org>

Reviewed by Adam Roben.

Port WCDataObject.cpp to WinCE
https://bugs.webkit.org/show_bug.cgi?id=48921

OleDuplicateData is not supported on WinCE.

  • platform/win/WCDataObject.cpp: (WebCore::WCDataObject::CopyMedium):
21:20 Changeset [71306] by senorblanco@chromium.org

2010-11-03 Stephen White <senorblanco@chromium.org>

Unreviewed; test_expectations fix.

One last attempt to green up the chromium gpu bots.

  • platform/chromium-gpu/test_expectations.txt:
21:14 Changeset [71305] by rolandsteiner@chromium.org

2010-11-03 Roland Steiner <rolandsteiner@chromium.org>

Unreviewed: add failing test to Chroium's test_expectation.txt

  • platform/chromium/test_expectations.txt:
21:10 Changeset [71304] by paroga@webkit.org

2010-11-03 Patrick Gansterer <paroga@webkit.org>

Reviewed by Adam Roben.

Port ClipboardWin.cpp to WinCE
https://bugs.webkit.org/show_bug.cgi?id=48412

  • platform/win/ClipboardWin.cpp: (WebCore::writeFileToDataObject):
20:55 Changeset [71303] by commit-queue@webkit.org

2010-11-03 Andre Pedralho <andre.pedralho@gmail.com>

Reviewed by Kenneth Rohde Christiansen.

Using the Platform Plugin to define the default values for the padding of HitTestResult.
https://bugs.webkit.org/show_bug.cgi?id=48450

  • Api/qwebkitplatformplugin.h: (QWebTouchModifier::~QWebTouchModifier):
  • WebCoreSupport/QtPlatformPlugin.cpp: (WebCore::QtPlatformPlugin::createTouchModifier):
  • WebCoreSupport/QtPlatformPlugin.h:
  • examples/platformplugin/WebPlugin.cpp: (WebPlugin::supportsExtension): (WebPlugin::createExtension):
  • examples/platformplugin/WebPlugin.h: (TouchModifier::hitTestPaddingForTouch):
  • examples/platformplugin/qwebkitplatformplugin.h: (QWebTouchModifier::~QWebTouchModifier):
20:40 Changeset [71302] by commit-queue@webkit.org

2010-11-03 George Guo <George.Guo@Nokia.com>

Reviewed by Andreas Kling.

[Qt] QtTestBrowser : set mmp rule pageddata in Symbian
https://bugs.webkit.org/show_bug.cgi?id=48767

Paging is needd on Symbian devices to support benchmarks tests like
dromaeo.com and Celtic Kane that need a lot of memory to run

  • QtTestBrowser/QtTestBrowser.pro:
20:25 Changeset [71301] by rolandsteiner@chromium.org

2010-11-03 Roland Steiner <rolandsteiner@chromium.org>

Reviewed by Nikolas Zimmermann.

Bug 48904 - [Chromium] Remove obsolete expectation files
https://bugs.webkit.org/show_bug.cgi?id=48904

Remove superfluous files:

  • platform/chromium-mac/fast/css/getComputedStyle/computed-style-expected.txt: Removed.
  • platform/chromium-mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Removed.
  • platform/chromium-mac/svg/css/getComputedStyle-basic-expected.txt: Removed.
19:59 Changeset [71300] by paroga@webkit.org

2010-11-03 Patrick Gansterer <paroga@webkit.org>

Reviewed by Adam Roben.

Port ClipboardWin.cpp to WinCE
https://bugs.webkit.org/show_bug.cgi?id=48412

  • platform/win/ClipboardWin.cpp: (WebCore::filesystemPathFromUrlOrTitle): (WebCore::createGlobalHDropContent): (WebCore::ClipboardWin::files):
19:42 Changeset [71299] by commit-queue@webkit.org

2010-11-03 Vincent Scheib <scheib@chromium.org>

Reviewed by James Robinson.

[chromium] GraphicsContext3D creation attributes include canRecoverFromContextLoss option
https://bugs.webkit.org/show_bug.cgi?id=48850

Implementations of GraphicsContext3D may respect the creation attribute
canRecoverFromContextLoss being false, and then only succeeding initialization if
the context can satisfy that request of never being lost. DX9 on XP can not satisfy
such a request.

Test by use of accelerated canvas 2d in Chromium with ANGLE on XP machines.

  • platform/graphics/GraphicsContext3D.h: (WebCore::GraphicsContext3D::Attributes::Attributes):
  • platform/graphics/gpu/SharedGraphicsContext3D.cpp: (WebCore::SharedGraphicsContext3D::create):

2010-11-03 Vincent Scheib <scheib@chromium.org>

Reviewed by James Robinson.

[chromium] GraphicsContext3D creation attributes include canRecoverFromContextLoss option
https://bugs.webkit.org/show_bug.cgi?id=48850

Implementations of GraphicsContext3D may respect the creation attribute
canRecoverFromContextLoss being false, and then only succeeding initialization if
the context can satisfy that request of never being lost. DX9 on XP can not satisfy
such a request.

Test by use of accelerated canvas 2d in Chromium with ANGLE on XP machines.

  • public/WebGraphicsContext3D.h: (WebKit::WebGraphicsContext3D::Attributes::Attributes):
  • src/GraphicsContext3DChromium.cpp: (WebCore::GraphicsContext3DInternal::initialize):
19:32 Changeset [71298] by alice.liu@apple.com

Fix clang++ build

  • PluginProcess/PluginProcess.h:
  • UIProcess/Plugins/PluginProcessProxy.h:
  • UIProcess/WebContextMenuProxy.h:

Change class to struct and vise versa where needed.

19:13 Changeset [71297] by commit-queue@webkit.org

2010-11-03 Jenn Braithwaite <jennb@chromium.org>

Reviewed by Dmitry Titov.

Chromium: Update resource tracking when moving a frame between documents
https://bugs.webkit.org/show_bug.cgi?id=48363

  • public/WebFrameClient.h: (WebKit::WebFrameClient::removeIdentifierForRequest): Added
  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::transferLoadingResourceFromPage): Notify current WebFrameClient of the resource and remove from former WebFrameClient.

2010-11-03 Jenn Braithwaite <jennb@chromium.org>

Reviewed by Dmitry Titov.

Chromium: Update resource tracking when moving a frame between documents
https://bugs.webkit.org/show_bug.cgi?id=48363

  • DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::assignIdentifierToRequest): Always put resource id in map so we can make assumptions about its presence. (WebViewHost::removeIdentifierForRequest): Added. (WebViewHost::didFinishResourceLoad): (WebViewHost::didFailResourceLoad): Check existence of resource id before removing from map.
  • DumpRenderTree/chromium/WebViewHost.h:
18:55 Changeset [71296] by commit-queue@webkit.org

2010-11-03 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Use sentence boundaries instead of start/end sentence
https://bugs.webkit.org/show_bug.cgi?id=48422

Using sentence boundaries all intersentence
whitespace/control/format characters are assigned to a
sentence. This is what ICU does, so we have to do the same in
order to get the same results with glib unicode backend. It fixes
the sentence tests cases in test fast/dom/Range/range-expand.html.

  • platform/text/gtk/TextBreakIteratorGtk.cpp: (WebCore::textBreakNext): (WebCore::textBreakPrevious):
18:43 Changeset [71295] by ossy@webkit.org

Unreviewed.

[Qt] DRT sideeffect revealed by r71268
https://bugs.webkit.org/show_bug.cgi?id=48958

  • platform/qt/Skipped:
    • svg/custom/text-zoom.xhtml added.
    • canvas/philip/tests/2d.pattern.image.null.html unskipped.
    • canvas/philip/tests/2d.pattern.image.undefined.html unskipped.
18:34 Changeset [71294] by kbr@google.com

2010-11-03 Adrienne Walker <enne@google.com>

Reviewed by Kenneth Russell.

Rebaseline gl-object-get-calls due to a missing blank line.
https://bugs.webkit.org/show_bug.cgi?id=48965

  • fast/canvas/webgl/gl-object-get-calls-expected.txt:
18:25 Changeset [71293] by tkent@chromium.org

2010-11-03 Kent Tamura <tkent@chromium.org>

Unreviewed, test expectation update.

  • platform/chromium-linux/editing/selection/transformed-selection-rects-expected.checksum: Added.
  • platform/chromium-linux/editing/selection/transformed-selection-rects-expected.png: Added.
  • platform/chromium-mac/editing/selection/transformed-selection-rects-expected.checksum: Added.
  • platform/chromium-mac/editing/selection/transformed-selection-rects-expected.png: Added.
  • platform/chromium-win/editing/selection/transformed-selection-rects-expected.checksum: Added.
  • platform/chromium-win/editing/selection/transformed-selection-rects-expected.png: Added.
  • platform/chromium-win/editing/selection/transformed-selection-rects-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
18:19 Changeset [71292] by mdelaney@apple.com

2010-11-03 Matthew Delaney <mdelaney@apple.com>

Reviewed by Darin Adler.

Fix LayoutTests/canvas/philip/tests/2d.drawImage.incomplete.html
https://bugs.webkit.org/show_bug.cgi?id=48306

  • canvas/philip/tests/2d.drawImage.incomplete.html: Modified test to correctly create an image object with its complete attr set to false.
  • platform/gtk/Skipped: Unskipping now passing tests. Same for below.
  • platform/mac-leopard/Skipped:
  • platform/qt/Skipped:
  • platform/mac-snowleopard/canvas/philip/tests/2d.drawImage.incomplete-expected.txt: Removed old failing expectations.
18:15 QtWebKitGraphics edited by ryan.roberts@sharedresearch.jp
fix a few formatting and type-o mistakes (diff)
17:49 Changeset [71291] by zmo@google.com

2010-11-03 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

depthRange should generate INVALID_OPERATION if zNear is greater than zFar
https://bugs.webkit.org/show_bug.cgi?id=48676

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::depthRange):

2010-11-03 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

depthRange should generate INVALID_OPERATION if zNear is greater than zFar
https://bugs.webkit.org/show_bug.cgi?id=48676

  • fast/canvas/webgl/webgl-specific-expected.txt:
  • fast/canvas/webgl/webgl-specific.html:
17:36 Changeset [71290] by dumi@chromium.org

Unreviewed, updating Chromium expectations.

  • platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
17:26 Changeset [71289] by kbr@google.com

2010-11-03 Adrienne Walker <enne@google.com>

Reviewed by Kenneth Russell.

Properly return empty strings instead of null when using invalid
objects for some WebGL calls. This fixes issues caused by r71274.
https://bugs.webkit.org/show_bug.cgi?id=48962

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::getProgramInfoLog): (WebCore::WebGLRenderingContext::getShaderInfoLog): (WebCore::WebGLRenderingContext::getShaderSource):

2010-11-03 Adrienne Walker <enne@google.com>

Reviewed by Kenneth Russell.

WebGL spec doesn't specify whether the return from getAttachedShaders
can be undefined or null. Tolerate both.
https://bugs.webkit.org/show_bug.cgi?id=48962

  • fast/canvas/webgl/gl-object-get-calls-expected.txt:
  • fast/canvas/webgl/gl-object-get-calls.html:
17:14 Changeset [71288] by rniwa@webkit.org

2010-11-01 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

Crash in ApplyStyleCommand::removeStyleFromRunBeforeApplyingStyle
https://bugs.webkit.org/show_bug.cgi?id=48581

The crash was caused by RemoveNodePreservingChildrenCommand's calling removeNode
on m_node without checking that m_node has a parent and it's still in the document.
Fixed the crash by adding an early exit in CompositeEditCommand::removeNode and
deploying RefPtr in several places of ApplyStyleCommand.cpp.

Test: editing/style/iframe-onload-crash.html

  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyInlineStyleToNodeRange): (WebCore::ApplyStyleCommand::removeStyleFromRunBeforeApplyingStyle): (WebCore::ApplyStyleCommand::removeInlineStyleFromElement):
  • editing/ApplyStyleCommand.h:
  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::removeNode):

2010-10-29 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

Crash in ApplyStyleCommand::removeStyleFromRunBeforeApplyingStyle
https://bugs.webkit.org/show_bug.cgi?id=48581

Added a test to ensure removeStyleFromRunBeforeApplyingStyle doesn't crash.

  • editing/style/iframe-onload-crash-expected.txt: Added.
  • editing/style/iframe-onload-crash.html: Added.
17:06 Changeset [71287] by mrowe@apple.com

Merge r71284.

17:06 Changeset [71286] by mrowe@apple.com

Versioning.

17:03 Changeset [71285] by mrowe@apple.com

New tag.

16:55 Changeset [71284] by adele@apple.com

Crashes in WebCore::DocumentMarkerController::removeMarkersFromMarkerMapVectorPair() when deleting multiple lines of text.
https://bugs.webkit.org/show_bug.cgi?id=48918
<rdar://problem/8620602>

Patch by Jia Pu <jpu@apple.com> on 2010-11-03
Reviewed by Darin Adler.

I haven't been able to found a reliable way to reproduce the bug. However, whenever it happens,
the crash is caused by a null node pointer returned by TextIterator. So it seems to be a
safe fix to guard against that.

  • editing/Editor.cpp: (WebCore::Editor::removeSpellAndCorrectionMarkersFromWordsToBeEdited):
16:55 Changeset [71283] by victorw@chromium.org

2010-11-03 Victor Wang <victorw@chromium.org>

Reviewed by Adam Barth.

[Chromium] update buildbot names in chromium rebaseline tool.

https://bugs.webkit.org/show_bug.cgi?id=48881

  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
16:53 Changeset [71282] by zmo@google.com

2010-11-02 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

A different mask or reference value in stencil operations should generate INVALID_OPERATION
https://bugs.webkit.org/show_bug.cgi?id=48669

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::WebGLRenderingContext): Init stencil func ref/mask and stencil mask to default. (WebCore::WebGLRenderingContext::stencilFunc): Cache ref/mask value. (WebCore::WebGLRenderingContext::stencilFuncSeparate): Generate error if front/back values differ. (WebCore::WebGLRenderingContext::stencilMask): Cache mask value. (WebCore::WebGLRenderingContext::stencilMaskSeparate): Generate error if front/back values differ. (WebCore::WebGLRenderingContext::validateFace): Validate face parameter. (WebCore::WebGLRenderingContext::validateStencilFunc): Validate stencil func parameter.
  • html/canvas/WebGLRenderingContext.h: Add members to track stencil func ref/mask and stencil mask.

2010-11-02 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

A different mask or reference value in stencil operations should generate INVALID_OPERATION
https://bugs.webkit.org/show_bug.cgi?id=48669

  • fast/canvas/webgl/webgl-specific-expected.txt:
  • fast/canvas/webgl/webgl-specific.html: Uncomment the test cases for the bug.
16:44 Changeset [71281] by crogers@google.com

audio branch: merge from trunk 70545:71224

16:41 Changeset [71280] by oliver@apple.com

2010-11-03 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

Crash in Function.prototype.call.apply
https://bugs.webkit.org/show_bug.cgi?id=48485

The problem here was op_load_varargs failing to ensure that
there was sufficient space for the entire callframe prior to
op_call_varargs. This meant that when we then re-entered the
VM it was possible to stomp over an earlier portion of the
stack, so causing sub-optimal behaviour.

  • bytecode/Opcode.h:
  • bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::emitLoadVarargs):
  • bytecompiler/BytecodeGenerator.h:
  • bytecompiler/NodesCodegen.cpp: (JSC::ApplyFunctionCallDotNode::emitBytecode):
  • jit/JIT.cpp: (JSC::JIT::privateCompile):
  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_load_varargs):

2010-11-03 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

Crash in Function.prototype.call.apply
https://bugs.webkit.org/show_bug.cgi?id=48485

Test for applying arguments to call at the edge of
the allocated region of the registerfile.

  • fast/js/call-apply-crash-expected.txt: Added.
  • fast/js/call-apply-crash.html: Added.
  • fast/js/script-tests/call-apply-crash.js: Added. (testLog):
16:10 Changeset [71279] by abarth@webkit.org

2010-11-03 Adam Barth <abarth@webkit.org>

Roll Chromium DEPs
https://bugs.webkit.org/show_bug.cgi?id=48959

  • DEPS:
16:03 Changeset [71278] by dglazkov@chromium.org

2010-11-03 Dimitri Glazkov <dglazkov@chromium.org>

Reverting r71244. Broke default event handling inside text fields.
https://bugs.webkit.org/show_bug.cgi?id=46015

  • fast/events/shadow-boundary-crossing.html: Reverted changes.
  • media/audio-delete-while-slider-thumb-clicked.html: Reverted changes.

2010-11-03 Dimitri Glazkov <dglazkov@chromium.org>

Reverting r71244, r71248 and r71250. Broke default event handling inside text fields.
https://bugs.webkit.org/show_bug.cgi?id=46015

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/ContainerNode.cpp: (WebCore::notifyChildInserted):
  • dom/DOMAllInOne.cpp:
  • dom/EventContext.cpp: Removed.
  • dom/EventContext.h: Removed.
  • dom/Node.cpp: (WebCore::Node::markAncestorsWithChildNeedsStyleRecalc): (WebCore::Node::createRendererIfNeeded): (WebCore::Node::eventParentNode): (WebCore::Node::enclosingLinkEventParentOrSelf): (WebCore::eventTargetAsSVGElementInstance): (WebCore::eventTargetRespectingSVGTargetRules): (WebCore::Node::eventAncestors): (WebCore::Node::dispatchGenericEvent):
  • dom/Node.h:
  • dom/Text.cpp: (WebCore::Text::createRenderer):
  • dom/WindowEventContext.cpp: Removed.
  • dom/WindowEventContext.h: Removed.
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::getEventListenersForNode):
  • inspector/InspectorInstrumentation.cpp: (WebCore::eventHasListeners): (WebCore::InspectorInstrumentation::willDispatchEventImpl):
  • inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::willDispatchEvent):
  • page/EventHandler.cpp: (WebCore::EventHandler::updateMouseEventTargetNode):
  • rendering/ShadowElement.h: (WebCore::ShadowElement::shadowParent): (WebCore::ShadowElement::shadowParentNode):
  • svg/SVGElement.cpp: (WebCore::SVGElement::eventParentNode):
  • svg/SVGElement.h:
15:58 Changeset [71277] by abarth@webkit.org

2010-11-03 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

CG use of WebKit image decoders crashes on some animated GIFs
https://bugs.webkit.org/show_bug.cgi?id=48955

It turns out CFDataGetMutableBytePtr isn't safe call on a null pointer.

Test: fast/images/dont-crash-with-null-gif-frames.html

  • platform/image-decoders/cg/ImageDecoderCG.cpp: (WebCore::RGBA32Buffer::copyReferenceToBitmapData): (WebCore::RGBA32Buffer::copyBitmapData):

2010-11-03 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

CG use of WebKit image decoders crashes on some animated GIFs
https://bugs.webkit.org/show_bug.cgi?id=48955

Test image from Wikipedia that was crashing.

  • fast/images/dont-crash-with-null-gif-frames-expected.txt: Added.
  • fast/images/dont-crash-with-null-gif-frames.html: Added.
  • fast/images/resources/quicksort.gif: Added.
15:48 Changeset [71276] by ossy@webkit.org

Unreviewed.

[Qt] DRT sideeffect revealed by r71268
https://bugs.webkit.org/show_bug.cgi?id=48958

  • platform/qt/Skipped: canvas/philip/tests/2d.pattern.image.null.html and 2d.pattern.image.undefined.html added until fix.
15:15 Changeset [71275] by senorblanco@chromium.org

2010-11-03 Stephen White <senorblanco@chromium.org>

Unreviewed; test expectations update.

[Chromium] This test is flaky on the GPU path after all.

  • platform/chromium-gpu/test_expectations.txt:
15:06 Changeset [71274] by kbr@google.com

2010-11-03 Adrienne Walker <enne@google.com>

Reviewed by Kenneth Russell.

Implement lost, restored, and creation failure context events for
WebGLRenderingContext. The lost and restored functions are not hooked
up yet, but the context now acts according to the spec as it should
during a lost context. Tested manually, as there's no programmatic
way to lose a context yet.
https://bugs.webkit.org/show_bug.cgi?id=35626

  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSWebGLRenderingContextCustom.cpp: (WebCore::JSWebGLRenderingContext::getAttachedShaders):
  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp: (WebCore::V8WebGLRenderingContext::getAttachedShadersCallback):
  • dom/EventNames.h:
  • html/canvas/WebGLContextEvent.cpp: Added. (WebCore::WebGLContextEvent::WebGLContextEvent): (WebCore::WebGLContextEvent::~WebGLContextEvent): (WebCore::WebGLContextEvent::initEvent):
  • html/canvas/WebGLContextEvent.h: Added. (WebCore::WebGLContextEvent::create): (WebCore::WebGLContextEvent::statusMessage):
  • html/canvas/WebGLContextEvent.idl: Added.
  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::create): (WebCore::WebGLRenderingContext::WebGLRenderingContext): (WebCore::WebGLRenderingContext::initializeNewContext): (WebCore::WebGLRenderingContext::activeTexture): (WebCore::WebGLRenderingContext::attachShader): (WebCore::WebGLRenderingContext::bindAttribLocation): (WebCore::WebGLRenderingContext::bindBuffer): (WebCore::WebGLRenderingContext::bindFramebuffer): (WebCore::WebGLRenderingContext::bindRenderbuffer): (WebCore::WebGLRenderingContext::bindTexture): (WebCore::WebGLRenderingContext::blendColor): (WebCore::WebGLRenderingContext::blendEquation): (WebCore::WebGLRenderingContext::blendEquationSeparate): (WebCore::WebGLRenderingContext::blendFunc): (WebCore::WebGLRenderingContext::blendFuncSeparate): (WebCore::WebGLRenderingContext::bufferData): (WebCore::WebGLRenderingContext::bufferSubData): (WebCore::WebGLRenderingContext::checkFramebufferStatus): (WebCore::WebGLRenderingContext::clear): (WebCore::WebGLRenderingContext::clearColor): (WebCore::WebGLRenderingContext::clearDepth): (WebCore::WebGLRenderingContext::clearStencil): (WebCore::WebGLRenderingContext::colorMask): (WebCore::WebGLRenderingContext::compileShader): (WebCore::WebGLRenderingContext::copyTexImage2D): (WebCore::WebGLRenderingContext::copyTexSubImage2D): (WebCore::WebGLRenderingContext::createBuffer): (WebCore::WebGLRenderingContext::createFramebuffer): (WebCore::WebGLRenderingContext::createTexture): (WebCore::WebGLRenderingContext::createProgram): (WebCore::WebGLRenderingContext::createRenderbuffer): (WebCore::WebGLRenderingContext::createShader): (WebCore::WebGLRenderingContext::cullFace): (WebCore::WebGLRenderingContext::deleteBuffer): (WebCore::WebGLRenderingContext::deleteFramebuffer): (WebCore::WebGLRenderingContext::deleteProgram): (WebCore::WebGLRenderingContext::deleteRenderbuffer): (WebCore::WebGLRenderingContext::deleteShader): (WebCore::WebGLRenderingContext::deleteTexture): (WebCore::WebGLRenderingContext::depthFunc): (WebCore::WebGLRenderingContext::depthMask): (WebCore::WebGLRenderingContext::depthRange): (WebCore::WebGLRenderingContext::detachShader): (WebCore::WebGLRenderingContext::disable): (WebCore::WebGLRenderingContext::disableVertexAttribArray): (WebCore::WebGLRenderingContext::drawArrays): (WebCore::WebGLRenderingContext::drawElements): (WebCore::WebGLRenderingContext::enable): (WebCore::WebGLRenderingContext::enableVertexAttribArray): (WebCore::WebGLRenderingContext::finish): (WebCore::WebGLRenderingContext::flush): (WebCore::WebGLRenderingContext::framebufferRenderbuffer): (WebCore::WebGLRenderingContext::framebufferTexture2D): (WebCore::WebGLRenderingContext::frontFace): (WebCore::WebGLRenderingContext::generateMipmap): (WebCore::WebGLRenderingContext::getActiveAttrib): (WebCore::WebGLRenderingContext::getActiveUniform): (WebCore::WebGLRenderingContext::getAttachedShaders): (WebCore::WebGLRenderingContext::getAttribLocation): (WebCore::WebGLRenderingContext::getBufferParameter): (WebCore::WebGLRenderingContext::getContextAttributes): (WebCore::WebGLRenderingContext::getFramebufferAttachmentParameter): (WebCore::WebGLRenderingContext::getParameter): (WebCore::WebGLRenderingContext::getProgramParameter): (WebCore::WebGLRenderingContext::getProgramInfoLog): (WebCore::WebGLRenderingContext::getRenderbufferParameter): (WebCore::WebGLRenderingContext::getShaderParameter): (WebCore::WebGLRenderingContext::getShaderInfoLog): (WebCore::WebGLRenderingContext::getShaderSource): (WebCore::WebGLRenderingContext::getTexParameter): (WebCore::WebGLRenderingContext::getUniform): (WebCore::WebGLRenderingContext::getUniformLocation): (WebCore::WebGLRenderingContext::getVertexAttrib): (WebCore::WebGLRenderingContext::getVertexAttribOffset): (WebCore::WebGLRenderingContext::hint): (WebCore::WebGLRenderingContext::isBuffer): (WebCore::WebGLRenderingContext::isContextLost): (WebCore::WebGLRenderingContext::isEnabled): (WebCore::WebGLRenderingContext::isFramebuffer): (WebCore::WebGLRenderingContext::isProgram): (WebCore::WebGLRenderingContext::isRenderbuffer): (WebCore::WebGLRenderingContext::isShader): (WebCore::WebGLRenderingContext::isTexture): (WebCore::WebGLRenderingContext::lineWidth): (WebCore::WebGLRenderingContext::linkProgram): (WebCore::WebGLRenderingContext::pixelStorei): (WebCore::WebGLRenderingContext::polygonOffset): (WebCore::WebGLRenderingContext::readPixels): (WebCore::WebGLRenderingContext::releaseShaderCompiler): (WebCore::WebGLRenderingContext::renderbufferStorage): (WebCore::WebGLRenderingContext::sampleCoverage): (WebCore::WebGLRenderingContext::scissor): (WebCore::WebGLRenderingContext::shaderSource): (WebCore::WebGLRenderingContext::stencilFunc): (WebCore::WebGLRenderingContext::stencilFuncSeparate): (WebCore::WebGLRenderingContext::stencilMask): (WebCore::WebGLRenderingContext::stencilMaskSeparate): (WebCore::WebGLRenderingContext::stencilOp): (WebCore::WebGLRenderingContext::stencilOpSeparate): (WebCore::WebGLRenderingContext::texImage2D): (WebCore::WebGLRenderingContext::texParameter): (WebCore::WebGLRenderingContext::texSubImage2DBase): (WebCore::WebGLRenderingContext::texSubImage2DImpl): (WebCore::WebGLRenderingContext::texSubImage2D): (WebCore::WebGLRenderingContext::uniform1f): (WebCore::WebGLRenderingContext::uniform1fv): (WebCore::WebGLRenderingContext::uniform1i): (WebCore::WebGLRenderingContext::uniform1iv): (WebCore::WebGLRenderingContext::uniform2f): (WebCore::WebGLRenderingContext::uniform2fv): (WebCore::WebGLRenderingContext::uniform2i): (WebCore::WebGLRenderingContext::uniform2iv): (WebCore::WebGLRenderingContext::uniform3f): (WebCore::WebGLRenderingContext::uniform3fv): (WebCore::WebGLRenderingContext::uniform3i): (WebCore::WebGLRenderingContext::uniform3iv): (WebCore::WebGLRenderingContext::uniform4f): (WebCore::WebGLRenderingContext::uniform4fv): (WebCore::WebGLRenderingContext::uniform4i): (WebCore::WebGLRenderingContext::uniform4iv): (WebCore::WebGLRenderingContext::uniformMatrix2fv): (WebCore::WebGLRenderingContext::uniformMatrix3fv): (WebCore::WebGLRenderingContext::uniformMatrix4fv): (WebCore::WebGLRenderingContext::useProgram): (WebCore::WebGLRenderingContext::validateProgram): (WebCore::WebGLRenderingContext::vertexAttribPointer): (WebCore::WebGLRenderingContext::viewport): (WebCore::WebGLRenderingContext::loseContext): (WebCore::WebGLRenderingContext::restoreContext): (WebCore::WebGLRenderingContext::addObject): (WebCore::WebGLRenderingContext::vertexAttribfImpl): (WebCore::WebGLRenderingContext::vertexAttribfvImpl):
  • html/canvas/WebGLRenderingContext.h:
  • html/canvas/WebGLRenderingContext.idl:
  • platform/graphics/GraphicsContext3D.h:
14:54 Changeset [71273] by andersca@apple.com

Implement NP_SetProperty
https://bugs.webkit.org/show_bug.cgi?id=48956

Reviewed by Adam Roben.

WebKit2:

  • Shared/Plugins/NPObjectMessageReceiver.cpp:

(WebKit::NPObjectMessageReceiver::setProperty):
Call the NPClass setProperty function.

  • Shared/Plugins/NPObjectMessageReceiver.messages.in:

Add SetProperty message.

  • Shared/Plugins/NPObjectProxy.cpp:

(WebKit::NPObjectProxy::setProperty):
Send a SetProperty message.

(WebKit::NPObjectProxy::NP_SetProperty):
Call NPObjectProxy::setProperty.

LayoutTests:

Remove now passing test.

  • platform/mac-wk2/Skipped:
14:48 Changeset [71272] by kbr@google.com

2010-11-03 Kenneth Russell <kbr@google.com>

Reviewed by Chris Marrin.

Redesign extension mechanism in GraphicsContext3D
https://bugs.webkit.org/show_bug.cgi?id=46894

  • JavaScriptCore.exp:
    • Exposed String::split(const String&, Vector<String>).

2010-11-03 Kenneth Russell <kbr@google.com>

Reviewed by Chris Marrin.

Redesign extension mechanism in GraphicsContext3D
https://bugs.webkit.org/show_bug.cgi?id=46894

Upon request, factored out extension support from GraphicsContext3D
into a new Extensions3D class. (The plural was chosen because the
class and subclasses hold multiple extensions.)

Unlike GraphicsContext3D, Extensions3D contains only pure virtual
methods. This was done because Extensions3D's inheritance diagram
and usage pattern is very different from that of GraphicsContext3D,
and the concrete subclasses need to decide how to implement the
various entry points. Requiring them to be placed at the
Extensions3D level will cause implementation details to leak into
the base class, which is highly undesirable. Any virtual call
overhead to these entry points will be negligible.

Changed call sites utilizing these extensions to call through the
Extensions3D object or its subclasses.

Tested:

  • Chromium on Linux with accelerated 2D canvas and HTML5 video
  • Chromium on Mac OS X with WebGL and CSS 3D content
  • Safari on Mac OS X with WebGL and CSS 3D content

No new tests. Covered by existing tests.

  • WebKit.gyp:
  • public/WebGraphicsContext3D.h:
  • src/Extensions3DChromium.cpp: Added. (WebCore::Extensions3DChromium::Extensions3DChromium): (WebCore::Extensions3DChromium::~Extensions3DChromium): (WebCore::Extensions3DChromium::supports): (WebCore::Extensions3DChromium::getGraphicsResetStatusARB): (WebCore::Extensions3DChromium::mapBufferSubDataCHROMIUM): (WebCore::Extensions3DChromium::unmapBufferSubDataCHROMIUM): (WebCore::Extensions3DChromium::mapTexSubImage2DCHROMIUM): (WebCore::Extensions3DChromium::unmapTexSubImage2DCHROMIUM): (WebCore::Extensions3DChromium::copyTextureToParentTextureCHROMIUM):
  • src/GraphicsContext3DChromium.cpp: (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal): (WebCore::GraphicsContext3DInternal::getExtensions): (WebCore::GraphicsContext3DInternal::supportsExtension):
  • src/GraphicsContext3DInternal.h:
  • src/WebGraphicsContext3DDefaultImpl.cpp: (WebKit::WebGraphicsContext3DDefaultImpl::copyTextureToParentTextureCHROMIUM): (WebKit::WebGraphicsContext3DDefaultImpl::getString):
  • src/WebGraphicsContext3DDefaultImpl.h:
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::composite):

2010-11-03 Kenneth Russell <kbr@google.com>

Reviewed by Chris Marrin.

Redesign extension mechanism in GraphicsContext3D
https://bugs.webkit.org/show_bug.cgi?id=46894

Upon request, factored out extension support from GraphicsContext3D
into a new Extensions3D class. (The plural was chosen because the
class and subclasses hold multiple extensions.)

Unlike GraphicsContext3D, Extensions3D contains only pure virtual
methods. This was done because Extensions3D's inheritance diagram
and usage pattern is very different from that of GraphicsContext3D,
and the concrete subclasses need to decide how to implement the
various entry points. Requiring them to be placed at the
Extensions3D level will cause implementation details to leak into
the base class, which is highly undesirable. Any virtual call
overhead to these entry points will be negligible.

Changed call sites utilizing these extensions to call through the
Extensions3D object or its subclasses.

Tested:

  • Chromium on Linux with accelerated 2D canvas and HTML5 video
  • Chromium on Mac OS X with WebGL and CSS 3D content
  • Safari on Mac OS X with WebGL and CSS 3D content

No new tests. Covered by existing tests.

  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/Extensions3D.h: Added. (WebCore::Extensions3D::~Extensions3D):
  • platform/graphics/GraphicsContext3D.cpp:
  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/chromium/DrawingBufferChromium.cpp: (WebCore::DrawingBuffer::DrawingBuffer): (WebCore::DrawingBuffer::publishToPlatformLayer):
  • platform/graphics/chromium/Extensions3DChromium.h: Added.
  • platform/graphics/chromium/VideoLayerChromium.cpp: (WebCore::VideoLayerChromium::updateTexture):
  • platform/graphics/gpu/SharedGraphicsContext3D.cpp: (WebCore::SharedGraphicsContext3D::supportsBGRA):
  • platform/graphics/gpu/SharedGraphicsContext3D.h:
  • platform/graphics/gpu/Texture.cpp: (WebCore::convertFormat):
  • platform/graphics/mac/GraphicsContext3DMac.mm:
  • platform/graphics/opengl/Extensions3DOpenGL.cpp: Added. (WebCore::Extensions3DOpenGL::Extensions3DOpenGL): (WebCore::Extensions3DOpenGL::~Extensions3DOpenGL): (WebCore::Extensions3DOpenGL::supports): (WebCore::Extensions3DOpenGL::getGraphicsResetStatusARB):
  • platform/graphics/opengl/Extensions3DOpenGL.h: Added.
  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp: (WebCore::GraphicsContext3D::getExtensions):
  • platform/graphics/qt/Extensions3DQt.cpp: Added. (WebCore::Extensions3DQt::Extensions3DQt): (WebCore::Extensions3DQt::~Extensions3DQt): (WebCore::Extensions3DQt::supports): (WebCore::Extensions3DQt::getGraphicsResetStatusARB):
  • platform/graphics/qt/Extensions3DQt.h: Added.
  • platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3D::getExtensions):
  • platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::readbackHardwareToSoftware):
14:45 Changeset [71271] by mthole@apple.com

Tweak coding style (follow-up to r71264).

Reviewed by Darin Adler.

  • platform/mac/Language.mm:

(WebCore::createHTTPStyleLanguageCode): Style tweaks.

14:44 Changeset [71270] by andersca@apple.com

Out of process plug-ins don't support the CA drawing model
https://bugs.webkit.org/show_bug.cgi?id=48950
<rdar://problem/8626019>

Reviewed by Simon Fraser.

  • Platform/CoreIPC/HandleMessage.h:

(CoreIPC::callMemberFunction):
Add new overload.

  • PluginProcess/PluginControllerProxy.cpp:

(WebKit::PluginControllerProxy::initialize):
Call platformInitialize().

(WebKit::PluginControllerProxy::destroy):
Call platformDestroy().

(WebKit::PluginControllerProxy::isAcceleratedCompositingEnabled):
Assume that accelerated compositing is available if we have a render server port.

(WebKit::PluginControllerProxy::geometryDidChange):
Call platformGeometryDidChange().

  • PluginProcess/PluginProcess.h:
  • PluginProcess/WebProcessConnection.cpp:

(WebKit::WebProcessConnection::createPlugin):
Pass back the remote layer client ID.

  • PluginProcess/WebProcessConnection.messages.in:

Add a remoteLayerClientID out parameter to CreatePlugin.

  • PluginProcess/mac/PluginControllerProxyMac.mm: Added.

(WebKit::PluginControllerProxy::platformInitialize):
If the plug-in has a layer, create a remote layer client and associate it with the layer.

(WebKit::PluginControllerProxy::platformDestroy):
Invalidate the remote layer client.

(WebKit::PluginControllerProxy::remoteLayerClientID):
Return the remote layer client ID if one exists.

(WebKit::PluginControllerProxy::platformGeometryDidChange):
Update the layer bounds.

  • WebKit2.xcodeproj/project.pbxproj:

Add new files.

  • WebProcess/Plugins/Netscape/mac/PluginProxyMac.mm: Added.

(WebKit::PluginProxy::pluginLayer):
Create a render layer if needed.

(WebKit::PluginProxy::needsBackingStore):
Return whether the plug-in needs a backing store. (It doesn't need a backing store if it's a CA plug-in).

  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::PluginProxy):
Initialize m_remoteLayerClientID.

(WebKit::PluginProxy::initialize):
Set m_remoteLayerClientID.

(WebKit::PluginProxy::paint):
Bail if the plug-in doesn't need a backing store.

(WebKit::PluginProxy::geometryDidChange):
Don't create a backing store if the plug-in doesn't need one.

  • WebProcess/WebPage/LayerBackedDrawingArea.cpp:

(WebKit::LayerBackedDrawingArea::LayerBackedDrawingArea):
Remove RetainPtr initialization.

  • WebProcess/WebPage/mac/LayerBackedDrawingAreaMac.mm:

(WebKit::LayerBackedDrawingArea::platformClear):
Use nullptr instead of 0.

14:32 Changeset [71269] by darin@apple.com

Updated Xcode projects by opening them with Xcode 3.2.4.
Updated svn:ignore for Xcode projects.

ANGLE:

  • ANGLE.xcodeproj: Added property svn:ignore.
  • ANGLE.xcodeproj/project.pbxproj: Updated with Xcode 3.2.4.
  • src/build_angle.xcodeproj: Added property svn:ignore.
  • src/build_angle.xcodeproj/project.pbxproj: Updated with Xcode 3.2.4.

WebCore:

  • manual-tests/NPN_Invoke/NPN_Invoke.xcodeproj: Added property svn:ignore.
  • manual-tests/NPN_Invoke/NPN_Invoke.xcodeproj/project.pbxproj: Updated with Xcode 3.2.4.

WebKitExamplePlugins:

  • NetscapeCocoaPlugin/NetscapeCocoaPlugin.xcodeproj: Added property svn:ignore.
  • NetscapeCocoaPlugin/NetscapeCocoaPlugin.xcodeproj/project.pbxproj: Updated with Xcode 3.2.4.
  • NetscapeCoreAnimationMoviePlugin/NetscapeCoreAnimationMoviePlugin.xcodeproj: Added property svn:ignore.
  • NetscapeCoreAnimationMoviePlugin/NetscapeCoreAnimationMoviePlugin.xcodeproj/project.pbxproj:
  • NetscapeCoreAnimationPlugin/NetscapeCoreAnimationPlugin.xcodeproj: Added property svn:ignore.
  • NetscapeCoreAnimationPlugin/NetscapeCoreAnimationPlugin.xcodeproj/project.pbxproj:
  • NetscapeInputMethodPlugin/NetscapeInputMethodPlugin.xcodeproj: Added property svn:ignore.
  • NetscapeInputMethodPlugin/NetscapeInputMethodPlugin.xcodeproj/project.pbxproj: Updated with Xcode 3.2.4.

WebKitTools:

  • MiniBrowser/MiniBrowser.xcodeproj: Added property svn:ignore.
  • TestWebKitAPI/TestWebKitAPI.xcodeproj: Added property svn:ignore.
  • WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
  • WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj: Updated with Xcode 3.2.4.
14:19 Changeset [71268] by mdelaney@apple.com

2010-11-03 Matthew Delaney <mdelaney@apple.com>

Reviewed by Darin Adler.

Fix canvas/philip/tests/2d.pattern.image.undefined.html
https://bugs.webkit.org/show_bug.cgi?id=48894

  • bindings/js/JSCanvasRenderingContext2DCustom.cpp: Changed error thrown to match the spec.

2010-11-03 Matthew Delaney <mdelaney@apple.com>

Reviewed by Darin Adler.

Fix canvas/philip/tests/2d.pattern.image.undefined.html
https://bugs.webkit.org/show_bug.cgi?id=48894

  • canvas/philip/tests/2d.pattern.image.string.html: Updated test to agree with spec.
  • platform/mac-snowleopard/canvas/philip/tests/2d.pattern.image.null-expected.txt: Removed. Now passing.
  • platform/mac-snowleopard/canvas/philip/tests/2d.pattern.image.undefined-expected.txt: Removed. Now passing.
  • platform/mac-leopard/Skipped: Removed now passing tests.
  • platform/gtk/Skipped: Removed now passing tests.
  • platform/qt/Skipped: Removed now passing tests.
14:04 Changeset [71267] by dumi@chromium.org

Unreviewed, updating Chromium expectations.

  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.png: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.png: Added.
  • platform/chromium/test_expectations.txt:
13:58 Changeset [71266] by simon.fraser@apple.com

2010-11-03 Simon Fraser <simon.fraser@apple.com>

Reviewed by John Sullivan.

Crash when setting context font to bad value
https://bugs.webkit.org/show_bug.cgi?id=48948

Null-check the CSSValue passed to CSSStyleSelector::applyPropertyToStyle(),
since it may be null if the style declaration does not contain a value
for the 'font' property.

Test: fast/canvas/invalid-set-font-crash.html

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyPropertyToStyle):
13:56 Changeset [71265] by aroben@apple.com

Skip a test that is probably causing the next test to assert

See <http://webkit.org/b/48910>.

  • platform/win/Skipped: Replaced

http/tests/media/reload-after-dialog.html with
http/tests/media/pdf-served-as-pdf.html.

13:55 Changeset [71264] by mthole@apple.com

Crash under WebCore::platformDefaultLanguage() when using Arabic language
https://bugs.webkit.org/show_bug.cgi?id=48946

Reviewed by Alexey Proskuryakov.

  • platform/mac/Language.mm:

(WebCore::createHTTPStyleLanguageCode):
Retain the lowercaseLanguageCode string before returning it. This was the code path that
would lead to a crash. Also removed early return to prevent a leak of preferredLanguageCode.

13:51 Changeset [71263] by aroben@apple.com

Stop waiting for messages from the web process after a timeout elapses

TestController::runUntil now takes a timeout parameter that specifies
how long to wait for the condition to become true. WebKitTestRunner
takes a --timeout flag that specifies how long the timeout should be.
run-webkit-tests passes this flag to WebKitTestRunner so its timeout
will be similar to run-webkit-tests.

Fixes <http://webkit.org/b/43047> <rdar://problem/8365833>
WebKitTestRunner waits forever if the web process crashes

Reviewed by Darin Adler and Anders Carlsson.

  • Scripts/old-run-webkit-tests:

(top level): Moved the GuardMalloc timeout adjustment here from
readFromDumpToolWithTimer.
(openDumpTool): Make WTR use a timeout similar to but slightly shorter
than the one that was specified on the command line.

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::TestController): Initialize our timeout values.
(WTR::TestController::initialize): Parse the --timeout flag and use it
to modify our timeout values.
(WTR::TestController::resetStateToConsistentValues): Changed to use a
short timeout while waiting for the web process to reset and to return
a boolean indicating whether we were able to reset the web process.
Uses a 5-second timeout while waiting for the process to be reset.
(WTR::TestController::runTest): Changed to return a boolean indicating
whether we were able to reset the web process (and thus run the test).
(WTR::TestController::runUntil): Call through to platformRunUntil.

(WTR::TestController::runTestingServerLoop):
(WTR::TestController::run):
Changed to bail if any test can't be run. This will cause the process
to exit. (Unfortunately this will make run-webkit-tests think we
crashed; see <http://webkit.org/b/48943>.)

  • WebKitTestRunner/TestController.h: Added platformRunUntil,

m_longTimeout, and m_shortTimeout.

  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::invoke): Use a short timeout when waiting for the
initial response and a long timeout when waiting for the test to
complete. Check whether runUntil timed out and print an error message
if so.

  • WebKitTestRunner/mac/TestControllerMac.mm:

(WTR::TestController::platformRunUntil): Renamed from runUntil. Pass
[NSDate distantPast] to -[NSRunLoop runMode:beforeDate:] so that we
won't block waiting for the run loop. Only loop until the timeout
elapses.

  • WebKitTestRunner/qt/TestControllerQt.cpp:

(WTR::TestController::platformRunUntil): Renamed from runUntil. Added a
FIXME about honoring the timeout.

  • WebKitTestRunner/win/TestControllerWin.cpp:

(WTR::TestController::platformRunUntil): Renamed from runUntil. Use
::MsgWaitForMultipleObjectsEx to implement the timeout. Changed to use
::PeekMessageW so that we don't block waiting for messages to become
available.

13:44 Changeset [71262] by mitz@apple.com

Made table column width allocation algorithms use logical widths.

Reviewed by Dave Hyatt.

Part of: Make tables work with vertical text
https://bugs.webkit.org/show_bug.cgi?id=46417

No new tests since tables don’t support different block flows yet.

  • rendering/AutoTableLayout.cpp:

(WebCore::AutoTableLayout::AutoTableLayout):
(WebCore::AutoTableLayout::recalcColumn):
(WebCore::AutoTableLayout::fullRecalc):
(WebCore::AutoTableLayout::computePreferredLogicalWidths):
(WebCore::AutoTableLayout::calcEffectiveLogicalWidth):
(WebCore::AutoTableLayout::insertSpanCell):
(WebCore::AutoTableLayout::layout):

  • rendering/AutoTableLayout.h:

(WebCore::AutoTableLayout::Layout::Layout):

  • rendering/FixedTableLayout.cpp:

(WebCore::FixedTableLayout::calcWidthArray):
(WebCore::FixedTableLayout::computePreferredLogicalWidths):
(WebCore::FixedTableLayout::layout):

  • rendering/FixedTableLayout.h:
  • rendering/RenderTable.h:

(WebCore::RenderTable::bordersPaddingAndSpacingInRowDirection): Renamed, but not changed yet.

13:34 Changeset [71261] by andersca@apple.com

Crash when layout in response to setSize changes the drawing area
https://bugs.webkit.org/show_bug.cgi?id=48947

Reviewed by Simon Fraser.

This is tested by compositing/plugins/small-to-large-composited-plugin.html.

  • WebProcess/WebPage/ChunkedUpdateDrawingArea.cpp:

(WebKit::ChunkedUpdateDrawingArea::setSize):

  • WebProcess/WebPage/LayerBackedDrawingArea.cpp:

(WebKit::LayerBackedDrawingArea::setSize):

13:15 Changeset [71260] by noam.rosenthal@nokia.com

Unreviewed build fix for r71253

#endif for TILED_BACKING_STORE was at the wrong place.

  • platform/graphics/qt/GraphicsLayerQt.cpp:

(WebCore::GraphicsLayerQtImpl::tiledBackingStoreBackgroundColor):

13:11 Changeset [71259] by hyatt@apple.com

https://bugs.webkit.org/show_bug.cgi?id=48945

Reviewed by Dan Bernstein.

Patch logicalLeftSelectionOffset and logicalRightSelectionOffset to be directionally abstract.

Also make sure writing mode roots are also selection painting roots.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::isSelectionRoot):
(WebCore::RenderBlock::logicalLeftSelectionOffset):
(WebCore::RenderBlock::logicalRightSelectionOffset):

  • rendering/RenderBlock.h:
12:57 Changeset [71258] by senorblanco@chromium.org

2010-11-03 Stephen White <senorblanco@chromium.org>

Unreviewed; test expectations update.

[Chromium] Remove mac expectations for chromium-gpu to let them fall
back to SKIP.

Covered fast/canvas/canvas-incremental-repaint.html et al.

  • platform/chromium-gpu/test_expectations.txt:
12:42 Changeset [71257] by pfeldman@chromium.org

2010-11-03 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: main resource is being re-assigned upon iframe's commit load.
https://bugs.webkit.org/show_bug.cgi?id=48940

  • inspector/front-end/ResourceManager.js: (WebInspector.ResourceManager.prototype.identifierForInitialRequest): (WebInspector.ResourceManager.prototype.didCommitLoadForFrame):
12:04 Changeset [71256] by japhet@chromium.org

2010-11-03 Nate Chapin <japhet@chromium.org>

Reviewed by Alexey Proskuryakov.

Wait to stop all loads for a frame being detached until after its
chidlren have been detached. This ensures that any loads started
by a child's unload event handler will be properly cancelled.
https://bugs.webkit.org/show_bug.cgi?id=46579

Tests: fast/loader/ping-error.html

http/tests/navigation/image-load-in-subframe-unload-handler.html

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::detachFromParent):
11:54 Changeset [71255] by tony@chromium.org

2010-11-03 Tony Chang <tony@chromium.org>

Unreviewed, updated test expectation due to last change.

  • editing/pasteboard/page-zoom.html:
11:38 Changeset [71254] by pfeldman@chromium.org

2010-11-03 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Simon Fraser.

Web Inspector: show proper image size for cached resources.
https://bugs.webkit.org/show_bug.cgi?id=48915

  • inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer.prototype._onGetResourceContent):
  • inspector/front-end/ImageView.js: (WebInspector.ImageView.prototype.contentTabSelected.onImageLoad): (WebInspector.ImageView.prototype.contentTabSelected): (WebInspector.ImageView.prototype._base64ToSize):
  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkDataGridNode.prototype._refreshNameCell):
  • inspector/front-end/Resource.js: (WebInspector.Resource.prototype.set finished): (WebInspector.Resource.prototype.get content): (WebInspector.Resource.prototype.requestContent): (WebInspector.Resource.prototype._innerRequestContent):
  • inspector/front-end/ResourceManager.js: (WebInspector.ResourceManager.requestContent):
  • inspector/front-end/SourceView.js: (WebInspector.SourceView.prototype.setupSourceFrameIfNeeded):
11:33 Changeset [71253] by noam.rosenthal@nokia.com

[Qt] GraphicsLayer: support tiling
https://bugs.webkit.org/show_bug.cgi?id=39691

Reviewed by Kenneth Rohde Christiansen.

Add support for TiledBackingStore in GraphicsLayerQt, when a layer is too large.

No new tests. Tests in LayoutTests/compositing/tiling now work with OpenGL enabled.

  • platform/graphics/qt/GraphicsLayerQt.cpp:

(WebCore::GraphicsLayerQtImpl::GraphicsLayerQtImpl):
(WebCore::GraphicsLayerQtImpl::~GraphicsLayerQtImpl):
(WebCore::GraphicsLayerQtImpl::recache):
(WebCore::GraphicsLayerQtImpl::paint):
(WebCore::GraphicsLayerQtImpl::tiledBackingStorePaintBegin):
(WebCore::GraphicsLayerQtImpl::tiledBackingStorePaint):
(WebCore::GraphicsLayerQtImpl::tiledBackingStorePaintEnd):
(WebCore::GraphicsLayerQtImpl::tiledBackingStoreContentsRect):
(WebCore::GraphicsLayerQtImpl::tiledBackingStoreBackgroundColor):
(WebCore::GraphicsLayerQtImpl::tiledBackingStoreVisibleRect):

11:29 Changeset [71252] by tony@chromium.org

2010-11-03 Tony Chang <tony@chromium.org>

Reviewed by Ojan Vafai.

Undo r54932 which inappropriately adjusts font sizes on zoomed pages
https://bugs.webkit.org/show_bug.cgi?id=48890

When copying zoomed text, we used to write to the clipboard the zoomed
font size. r54932 worked around this at paste time by scaling the
font size based on the zoom.

In r67568, Erik fixed getComputedStyle to return the original value
rather than the zoomed font size. This makes the work around added
by r54932 unnecessary.

The code in r54932 was busted in the first place since it only worked
when in quirks mode since it didn't add units to the font size.

  • editing/inserting/page-zoom-font-size-expected.txt: Added.
  • editing/inserting/page-zoom-font-size.html: Added.

2010-11-03 Tony Chang <tony@chromium.org>

Reviewed by Ojan Vafai.

Undo r54932 which inappropriately adjusts font sizes on zoomed pages
https://bugs.webkit.org/show_bug.cgi?id=48890

Test: editing/inserting/page-zoom-font-size.html

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::negateStyleRulesThatAffectAppearance):
11:03 Changeset [71251] by mitz@apple.com

Make collapsed borders in tables work with different block flows
https://bugs.webkit.org/show_bug.cgi?id=46191

Reviewed by Dave Hyatt.

No new tests since tables don’t support different block flows yet.

This change still doesn’t support cells whose block flow differs from the table’s.

  • rendering/AutoTableLayout.cpp:

(WebCore::AutoTableLayout::recalcColumn): Updated for the renaming of styleOrColWidth().
(WebCore::AutoTableLayout::calcEffectiveWidth): Ditto.

  • rendering/FixedTableLayout.cpp:

(WebCore::FixedTableLayout::calcWidthArray): Ditto.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::computePreferredLogicalWidths): Ditto.

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::styleOrColLogicalWidth): Renamed styleOrColWidth() to this and
changed to use logical widths.
(WebCore::RenderTableCell::computePreferredLogicalWidths): Updated for the above rename.
(WebCore::RenderTableCell::updateLogicalWidth): Renamed updateWidth() to this and changed
to set the logical width.
(WebCore::RenderTableCell::collapsedStartBorder): Changed collapsedLeftBorder() into this.
Note that “start” here will refer to the table’s block flow, not the cell’s, once we allow
the two to differ.
(WebCore::RenderTableCell::collapsedEndBorder): Similar.
(WebCore::RenderTableCell::collapsedBeforeBorder): Similar.
(WebCore::RenderTableCell::collapsedAfterBorder): Similar.
(WebCore::RenderTableCell::collapsedLeftBorder): Resolves “left” to a logical side using
the table’s block flow.
(WebCore::RenderTableCell::collapsedRightBorder): Similar.
(WebCore::RenderTableCell::collapsedTopBorder): Similar.
(WebCore::RenderTableCell::collapsedBottomBorder): Similar.
(WebCore::RenderTableCell::borderStart): Use borderHalfStart().
(WebCore::RenderTableCell::borderEnd): Similar.
(WebCore::RenderTableCell::borderBefore): Similar.
(WebCore::RenderTableCell::borderAfter): Similar.
(WebCore::RenderTableCell::borderHalfLeft): Resolves “left” to a logical side using the
table’s block flow.
(WebCore::RenderTableCell::borderHalfRight): Similar.
(WebCore::RenderTableCell::borderHalfTop): Similar.
(WebCore::RenderTableCell::borderHalfBottom): Similar.
(WebCore::RenderTableCell::borderHalfStart): Added. Uses collapsedStartBorder(). Splits odd
widths based on physical side.
(WebCore::RenderTableCell::borderHalfEnd): Similar.
(WebCore::RenderTableCell::borderHalfBefore): Similar.
(WebCore::RenderTableCell::borderHalfAfter): Similar.
(WebCore::RenderTableCell::collectBorderStyles): Use logical methods.
(WebCore::RenderTableCell::paintCollapsedBorder): Updated.

  • rendering/RenderTableCell.h:
  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::setCellWidths): Updated for the renaming of updateWidth().

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::borderBefore): Added.
(WebCore::RenderStyle::borderAfter): Added.
(WebCore::RenderStyle::borderStart): Added.
(WebCore::RenderStyle::borderEnd): Adeed.

  • rendering/style/RenderStyle.h:
10:46 Changeset [71250] by dglazkov@chromium.org

2010-11-03 Dimitri Glazkov <dglazkov@chromium.org>

Fix Win build correctly after r71244 and r71248

  • WebCore.vcproj/WebCore.vcproj: Added XML gobbledygook back.
  • dom/DOMAllInOne.cpp: Added files to build into a combined file.
10:32 Changeset [71249] by aroben@apple.com

Add a plugin test that evaluates JS after removing the plugin element from the document

This test replaces platform/win/plugins/plugin-delayed-destroy.html.
That test was made to prevent a crash very similar to this one, but
unfortunately tested only the mechanism that prevented the crash and
not whether the crash itself was prevented. Since WebKit2 uses a
different mechanism to prevent the crash, the test was failing even
though WebKit2 was not vulnerable to the crash. This new test crashes
if there is no mechanism in place to prevent it and passes in both
WebKit1 and WebKit2.

Fixes <http://webkit.org/b/46711> <rdar://problem/8485903>
platform/win/plugins/plugin-delayed-destroy.html fails in WebKit2

Reviewed by Anders Carlsson.

WebKitTools:

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
  • DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
  • GNUmakefile.am:

Added new file.

  • DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:

(pluginDeallocate): Make sure we delete the PluginTest object. This
prevents a leak and also allows us to test the crash.

  • DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:

(PluginTest::executeScript): Made this into a non-static member
function.

(PluginTest::waitUntilDone):
(PluginTest::notifyDone):
Updated for changes to executeScript.

  • DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Added executeScript.
  • DumpRenderTree/TestNetscapePlugIn/Tests/EvaluateJSAfterRemovingPluginElement.cpp: Added.

(EvaluateJSAfterRemovingPluginElement::EvaluateJSAfterRemovingPluginElement):
Initialize ourselves and tell the test harness to wait.
(EvaluateJSAfterRemovingPluginElement::NPP_DestroyStream): Remove our
plugin element from the document, then execute some JavaScript. If
WebKit does not have appropriate mechanisms in place, we'll be
destroyed inside the first call to executeScript and crash on the
second call.

LayoutTests:

  • platform/mac/Skipped: Added the new test, which fails in WebKit1 on SnowLeopard.
  • platform/win-wk2/Skipped: Removed platform/win/plugins/plugin-delayed-destroy.html.
  • platform/win/plugins/plugin-delayed-destroy-expected.txt: Removed.
  • platform/win/plugins/plugin-delayed-destroy.html: Removed.
  • plugins/evaluate-js-after-removing-plugin-element-expected.txt: Added.
  • plugins/evaluate-js-after-removing-plugin-element.html: Added.
10:30 Changeset [71248] by dglazkov@chromium.org

Fix Qt, Win builds after r71244.

  • WebCore.vcproj/WebCore.vcproj: Removed XML gobbledygook that prevents files from building.
  • dom/Text.cpp:

(WebCore::Text::createRenderer): Moved parentOrHost inside ENABLE(SVG) guard.

10:21 UpdatingBugzilla edited by ddkilzer@webkit.org
(diff)
10:17 Changeset [71247] by andersca@apple.com

Pass the accelerated compositing render server port to the plug-in process at startup
https://bugs.webkit.org/show_bug.cgi?id=48925

Reviewed by Adam Roben.

  • PluginProcess/PluginProcess.cpp:

(WebKit::PluginProcess::PluginProcess):
Initialize m_compositingRenderServerPort to MACH_PORT_NULL.

(WebKit::PluginProcess::initialize):
Get the plug-in path and render server port from the creation parameters.

  • PluginProcess/PluginProcess.messages.in:

Change the Initialize message to take a PluginProcessCreationParameters struct.

  • Shared/Plugins/PluginProcessCreationParameters.cpp: Added.
  • Shared/Plugins/PluginProcessCreationParameters.h: Added.

Add new PluginProcessCreationParameters struct.

  • UIProcess/Plugins/PluginProcessProxy.cpp:

(WebKit::PluginProcessProxy::didFinishLaunching):
Initialize now takes a PluginProcessCreationParameters struct.

  • UIProcess/Plugins/mac/PluginProcessProxyMac.mm: Added.

(WebKit::PluginProcessProxy::platformInitializePluginProcess):
Initialize the render server port.

  • WebKit2.xcodeproj/project.pbxproj:

Add new files.

10:16 Changeset [71246] by hyatt@apple.com

https://bugs.webkit.org/show_bug.cgi?id=48928

Reviewed by Dan Bernstein.

Rename all the selection gap functions to not be directionally specific. Left and Right turn into LogicalLeft and
LogicalRight. Horizontal becomes Line. Vertical becomes Block.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::selectionGapRectsForRepaint):
(WebCore::RenderBlock::paintSelection):
(WebCore::RenderBlock::fillSelectionGaps):
(WebCore::RenderBlock::fillInlineSelectionGaps):
(WebCore::RenderBlock::fillBlockSelectionGaps):
(WebCore::RenderBlock::fillLineSelectionGap):
(WebCore::RenderBlock::fillBlockSelectionGap):
(WebCore::RenderBlock::fillLogicalLeftSelectionGap):
(WebCore::RenderBlock::fillLogicalRightSelectionGap):
(WebCore::RenderBlock::getSelectionGapInfo):
(WebCore::RenderBlock::logicalLeftSelectionOffset):
(WebCore::RenderBlock::logicalRightSelectionOffset):

  • rendering/RenderBlock.h:
  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::fillLineSelectionGap):

10:13 Changeset [71245] by senorblanco@chromium.org

2010-11-03 Stephen White <senorblanco@chromium.org>

Unreviewed; test expectations update.

[Chromium] Update chromium-gpu test expectations. Most of this
consists of updates to the shared canvas section. The rest adds
a failing test on windows, and some timeouts on mac. The canvas2D
tests are skipped again on the Mac, since accelerated canvas 2D
has not been implemented yet, so there's no point in rebaselining.

  • platform/chromium-gpu/test_expectations.txt:
10:02 Changeset [71244] by dglazkov@chromium.org

2010-11-03 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Darin Adler.

Implement shadow DOM-aware event targeting and introduce EventContext to track the context of each event dispatch.
https://bugs.webkit.org/show_bug.cgi?id=46015

Tuned shadow-boundary-crossing.html to better reflect its point: the event should indeed fire (it used to be swallowed),
but its target should be a non-shadow node.

Tweaked audio-delete-while-slider-thumb-clicked.html to actually click on
the scrubber thumb (it was off by 2 pixels).

  • fast/events/shadow-boundary-crossing.html: Modified the test.
  • media/audio-delete-while-slider-thumb-clicked.html : Ditto.

2010-11-03 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Darin Adler.

Implement shadow DOM-aware event targeting and introduce EventContext to track the context of each event dispatch.
https://bugs.webkit.org/show_bug.cgi?id=46015

This patch adds the notion of EventContext (and a very similar-acting WindowEventContext, specifically
for DOMWindow), an abstraction that carries information around dispatching an event for any given Node.

This abstraction is necessary to ensure that events, fired from shadow DOM nodes are properly retargeted to
appear as if they are coming from their host, thus never exposing the shadow DOM nodes to the world outside.

  • Android.mk: Added EventContext, WindowEventContext files.
  • CMakeLists.txt: Ditto.
  • GNUmakefile.am: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • dom/ContainerNode.cpp: (WebCore::notifyChildInserted): Changed to be shadow DOM-aware.
  • dom/EventContext.cpp: Added.
  • dom/EventContext.h: Added.
  • dom/Node.cpp: (WebCore::Node::markAncestorsWithChildNeedsStyleRecalc): Changed to be shadow DOM-aware. (WebCore::Node::createRendererIfNeeded): Ditto. (WebCore::Node::parentOrHostNode): Added new helper method. (WebCore::Node::enclosingLinkEventParentOrSelf): Changed to be shadow DOM-aware. (WebCore::eventTargetRespectingSVGTargetRules): Collapsed two helper methods into one. (WebCore::Node::eventAncestors): Refactored to collect a vector of EventContexts. (WebCore::Node::topEventContext): Added. (WebCore::eventHasListeners): Changed to use EventContexts. (WebCore::Node::dispatchGenericEvent): Ditto.
  • dom/Node.h: Removed eventParentNode that's no longer needed, added parentOrHostNode decl,

and changed signature of eventAncestors to use EventContexts.

  • dom/Text.cpp: (WebCore::Text::createRenderer): Changed to be shadow DOM-aware.
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::getEventListenersForNode): Changed to use EventContexts.
  • page/EventHandler.cpp: (WebCore::EventHandler::updateMouseEventTargetNode): Removed code that's no longer necessary.
  • rendering/ShadowElement.h: Made m_shadowParent a RefPtr to avoid stale references when parent is deleted.
  • svg/SVGElement.cpp: Removed eventParentNode that's no longer needed.
  • svg/SVGElement.h: Ditto.
  • dom/WindowEventContext.cpp: Added.
  • dom/WindowEventContext.h: Added.
08:58 Changeset [71243] by vestbo@webkit.org

[Qt] Add the webkit2 library to LIBS instead of QMAKE_LFLAGS

Reviewed by Kenneth Rohde Christiansen.

Otherwise the library order will get messed up and cause
missing symbols on Mac OS X.

  • WebKit2.pri:
  • WebKit2.pro:
08:47 Changeset [71242] by mnaganov@chromium.org

2010-11-02 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Fix console messages about starting and finishing profiling.

https://bugs.webkit.org/show_bug.cgi?id=48825

  • inspector/InspectorProfilerAgent.cpp: (WebCore::InspectorProfilerAgent::addStartProfilingMessageToConsole):
  • inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype.displayTitleForProfileLink):
08:46 Changeset [71241] by andreas.kling@nokia.com

2010-11-03 Andreas Kling <kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] QGWV: Keep the scrolling delegation intact when switching pages

  • Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::updateResizesToContentsForPage): Turn on/off scrolling delegation depending on the resizeToContents mode. (QGraphicsWebViewPrivate::detachCurrentPage): Turn off scrolling delegation. (QGraphicsWebView::setResizesToContents):
08:44 Changeset [71240] by zimmermann@webkit.org

2010-11-03 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Andreas Kling.

chrome.dll!WebCore::SVGLength::SVGLength ...
https://bugs.webkit.org/show_bug.cgi?id=48831

Test: svg/dom/baseVal-animVal-crash.html

  • svg/properties/SVGListPropertyTearOff.h: (WebCore::SVGListPropertyTearOff::initialize): Renamed removeItemFromListIfNeeded to processIncomingListItem, to reflect its new job. (WebCore::SVGListPropertyTearOff::insertItemBefore): Ditto. (WebCore::SVGListPropertyTearOff::replaceItem): Ditto. (WebCore::SVGListPropertyTearOff::appendItem): Ditto. (WebCore::SVGListPropertyTearOff::processIncomingListItem): Copy incoming item, if necessary, see inline comments.
  • svg/properties/SVGPropertyTearOff.h: (WebCore::SVGPropertyTearOff::detachWrapper): Remove association with SVGAnimatedProperty, when wrapper is detached.

2010-11-03 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Andreas Kling.

chrome.dll!WebCore::SVGLength::SVGLength ...
https://bugs.webkit.org/show_bug.cgi?id=48831

  • svg/dom/baseVal-animVal-crash-expected.txt: Added.
  • svg/dom/baseVal-animVal-crash.html: Added.
08:00 Changeset [71239] by andreas.kling@nokia.com

2010-11-03 Kenneth Rohde Christiansen <kenneth@webkit.org>

Reviewed by Andreas Kling.

Make it possible to delegate scrolling to the UI
https://bugs.webkit.org/show_bug.cgi?id=48907

Enable scrolling delegation when setResizesToContents is active.

  • Api/qgraphicswebview.cpp: (QGraphicsWebView::setResizesToContents):

2010-11-03 Kenneth Rohde Christiansen <kenneth@webkit.org>

Reviewed by Andreas Kling.

Make it possible to delegate scrolling to the UI
https://bugs.webkit.org/show_bug.cgi?id=48907

Add a WebCore setting for delegating scrolling to the actual
WebKit view, which means that setScrollPosition will call
scrollContents directly without going though the scrollbar
code.

  • page/FrameView.cpp: (WebCore::FrameView::delegatesScrolling):
  • page/FrameView.h:
  • page/Settings.cpp: (WebCore::Settings::Settings): (WebCore::Settings::setShouldDelegateScrolling):
  • page/Settings.h: (WebCore::Settings::shouldDelegateScrolling):
  • platform/ScrollView.cpp: (WebCore::ScrollView::setScrollPosition):
  • platform/ScrollView.h: (WebCore::ScrollView::delegatesScrolling):
07:50 Changeset [71238] by senorblanco@chromium.org

2010-11-02 Stephen White <senorblanco@chromium.org>

Reviewed by Tony Chang.

[chromium] Fix LayoutTestController UMRs.
https://bugs.webkit.org/show_bug.cgi?id=48872

  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController):
07:38 Changeset [71237] by paroga@webkit.org

2010-11-03 Patrick Gansterer <paroga@webkit.org>

Reviewed by Adam Roben.

[WINCE] Add SharedBitmap
https://bugs.webkit.org/show_bug.cgi?id=28272

SharedBitmap is a helper class used as NativeImagePtr for WinCE.
It's wide used by WinCE graphics files as a replacement of HBITMAP.

Originally written by Yong Li <yong.li@torchmobile.com>.

  • platform/graphics/wince/GraphicsContextWinCE.cpp: (WebCore::TransparentLayerDC::TransparentLayerDC): (WebCore::TransparentLayerDC::~TransparentLayerDC): (WebCore::ScopeDCProvider::ScopeDCProvider): (WebCore::ScopeDCProvider::~ScopeDCProvider): (WebCore::GraphicsContext::drawText):
  • platform/graphics/wince/SharedBitmap.cpp: Added. (WebCore::SharedBitmap::create): (WebCore::SharedBitmap::SharedBitmap): (WebCore::SharedBitmap::~SharedBitmap): (WebCore::SharedBitmap::resetPixels): (WebCore::convert32To16): (WebCore::SharedBitmap::to16bit): (WebCore::SharedBitmap::freeMemory): (WebCore::SharedBitmap::createHandle): (WebCore::SharedBitmap::ensureHandle): (WebCore::SharedBitmap::draw): (WebCore::SharedBitmap::clipBitmap): (WebCore::drawPatternSimple): (WebCore::normalizePhase): (WebCore::SharedBitmap::drawPattern): (WebCore::SharedBitmap::DCProvider::getDC): (WebCore::SharedBitmap::DCProvider::releaseDC): (WebCore::SharedBitmap::clearPixels):
  • platform/graphics/wince/SharedBitmap.h: Added. (WebCore::DCProvider::getDC): (WebCore::DCProvider::releaseDC): (WebCore::DCProvider::DCHolder::DCHolder): (WebCore::DCProvider::DCHolder::~DCHolder): (WebCore::DCProvider::DCHolder::set): (WebCore::DCProvider::DCHolder::get): (WebCore::DCProvider::DCHolder::clearInternal): (WebCore::DCProvider::DCHolder::setInternal):
07:12 Changeset [71236] by zimmermann@webkit.org

2010-11-03 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

chrome.dll!WebCore::SVGListPropertyTearOff<...>::getItem ReadAV@NULL (578c0f7f21ca517ba29a4eafb7099c1b)
https://bugs.webkit.org/show_bug.cgi?id=48829

Share SVGPropertyTearOff wrapper cache between SVGAnimatedListPropertyTearOff::baseVal/animVal.
When modifying the list through baseVal, and then grabbing the animVal list an assertion was fired,
as the wrapper cache was out of sync with the underlying SVG*List vector.

Test: svg/dom/baseVal-animVal-list-crash.html

  • svg/properties/SVGAnimatedListPropertyTearOff.h: (WebCore::SVGAnimatedListPropertyTearOff::baseVal): (WebCore::SVGAnimatedListPropertyTearOff::animVal): (WebCore::SVGAnimatedListPropertyTearOff::removeItemFromList): (WebCore::SVGAnimatedListPropertyTearOff::detachListWrappers): (WebCore::SVGAnimatedListPropertyTearOff::values): (WebCore::SVGAnimatedListPropertyTearOff::wrappers): (WebCore::SVGAnimatedListPropertyTearOff::create): (WebCore::SVGAnimatedListPropertyTearOff::SVGAnimatedListPropertyTearOff):
  • svg/properties/SVGListPropertyTearOff.h: (WebCore::SVGListPropertyTearOff::create): (WebCore::SVGListPropertyTearOff::removeItemFromList): (WebCore::SVGListPropertyTearOff::clear): (WebCore::SVGListPropertyTearOff::numberOfItems): (WebCore::SVGListPropertyTearOff::initialize): (WebCore::SVGListPropertyTearOff::getItem): (WebCore::SVGListPropertyTearOff::insertItemBefore): (WebCore::SVGListPropertyTearOff::replaceItem): (WebCore::SVGListPropertyTearOff::removeItem): (WebCore::SVGListPropertyTearOff::appendItem): (WebCore::SVGListPropertyTearOff::SVGListPropertyTearOff): (WebCore::SVGListPropertyTearOff::commitChange):

2010-11-03 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

chrome.dll!WebCore::SVGListPropertyTearOff<...>::getItem ReadAV@NULL (578c0f7f21ca517ba29a4eafb7099c1b)
https://bugs.webkit.org/show_bug.cgi?id=48829

  • svg/dom/baseVal-animVal-list-crash-expected.txt: Added.
  • svg/dom/baseVal-animVal-list-crash.html: Added.
07:10 Changeset [71235] by loislo@chromium.org

2010-11-02 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Remove obsolete code.
It is not required to push onload and DOMContentLoaded events times to the fresh instance of Inspector.
Network Panel is showing the markers only after reloading the inspected page.
https://bugs.webkit.org/show_bug.cgi?id=48854

  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::populateScriptObjects): (WebCore::InspectorController::mainResourceFiredDOMContentEvent): (WebCore::InspectorController::mainResourceFiredLoadEvent):
  • inspector/InspectorController.h:
06:49 Changeset [71234] by pfeldman@chromium.org

2010-11-03 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Jeremy Orlow.

Web Inspector: brush up breakpoints UI and UX.
https://bugs.webkit.org/show_bug.cgi?id=48901

  • inspector/front-end/BreakpointManager.js: (WebInspector.DOMBreakpoint.prototype.populateLabelElement): (WebInspector.XHRBreakpoint.prototype.populateLabelElement):
  • inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.BreakpointsSidebarPane.prototype.addBreakpointItem): (WebInspector.XHRBreakpointsSidebarPane.prototype.addBreakpointItem): (WebInspector.XHRBreakpointsSidebarPane.prototype._hideEditBreakpointDialog): (WebInspector.BreakpointItem):
  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype._populateTagContextMenu.handlerFunction): (WebInspector.ElementsTreeElement.prototype._populateTagContextMenu):
  • inspector/front-end/PropertiesSection.js: (WebInspector.PropertiesSection):
  • inspector/front-end/inspector.css: (.monospace): (body.platform-mac.platform-mac-snowleopard .source-code): (body.platform-windows .monospace, body.platform-windows .source-code): (body.platform-linux .monospace, body.platform-linux .source-code): (.source-code): (.section .header): (.section .header::before): (.section .header .title, .event-bar .header .title): (.section .header .subtitle, .event-bar .header .subtitle): (.section.expanded .properties, .event-bar.expanded .event-properties): (.event-listener-breakpoints .event-category): (.event-listener-breakpoints.properties-tree .children li): (.event-listener-breakpoints .checkbox-elem): (.event-bar): (.event-bars .event-bar .header .title): (.event-bars .event-bar .header::before): (.pane > .body .info): (.pane > .body .placard + .info): (ol.breakpoint-list): (.breakpoint-list li): (.pane .breakpoint-hit): (.cursor-pointer): (.cursor-auto):
06:32 Changeset [71233] by aroben@apple.com

Add some more failing tests to the Windows Skipped file

  • platform/win/Skipped:
06:30 TriagingTestFailures edited by aroben@apple.com
Note that the bug should be updated once you add the test to the Skipped … (diff)
06:27 TriagingTestFailures edited by aroben@apple.com
Added notes about whom to CC on bugs (diff)
05:15 Changeset [71232] by zimmermann@webkit.org

2010-11-03 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed.

Convert SVGAnimatedString/SVGStringList to the new SVG*PropertyTearOff concept
https://bugs.webkit.org/show_bug.cgi?id=48898

Fix Chromium/V8 build for real, verified using a local ToT Chromium build.

  • bindings/scripts/CodeGeneratorV8.pm:
04:37 Changeset [71231] by aroben@apple.com

Bring WTF.vcproj up to date

unicode directories, added new files, removed old files.

04:33 Changeset [71230] by zimmermann@webkit.org

2010-11-03 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed.

Convert SVGAnimatedString/SVGStringList to the new SVG*PropertyTearOff concept
https://bugs.webkit.org/show_bug.cgi?id=48898

Next attempt to fix the Chromium/V8 builds - a class forward in the headers was still missing.

  • bindings/scripts/CodeGeneratorV8.pm: Add SVGStringListPropertyTearOff in the V8SVGStringList header.
04:23 Changeset [71229] by zimmermann@webkit.org

2010-11-03 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed.

Convert SVGAnimatedString/SVGStringList to the new SVG*PropertyTearOff concept
https://bugs.webkit.org/show_bug.cgi?id=48898

Attempt to fix the Chromium/V8 builds.

  • bindings/scripts/CodeGeneratorV8.pm: Add missing "SVGStringListPropertyTearOff.h" include, also replaces some commas by semicolons (no idea why it worked before, Perl is not strict...)
04:20 Changeset [71228] by tkent@chromium.org

2010-11-03 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

REGRESSION: rebaseline-chromium-webkit-tests uses non-zero tolerance for
image dup detection
https://bugs.webkit.org/show_bug.cgi?id=48744

  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
    • Make a function for option parsing for ease of test
    • Set 0 to options.tolerance
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
    • Add a test for this change
04:13 Changeset [71227] by zimmermann@webkit.org

2010-11-03 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Convert SVGAnimatedString/SVGStringList to the new SVG*PropertyTearOff concept
https://bugs.webkit.org/show_bug.cgi?id=48898

Convert SVGAnimatedString/SVGStringList to the new svg animated type concept.
SVGStringList is special compared to all other SVG*Lists, as it returns non-live elements.
That means myStringList.getItem(0) = 'foobar' doesn't take effect.

When appending an item to a SVGStringList, that has been taken from another list, it's not removed from the list origin.
That demanded a new SVGStringListPropertyTearOff which does just that.

Tests: svg/W3C-SVG-1.1-SE/types-dom-06-f.svg

svg/dom/SVGStringList.html

  • GNUmakefile.am: Add SVGAnimatedString.h / SVGStringListPropertyTearOff.h to build.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • bindings/scripts/CodeGenerator.pm: Recognize SVGAnimatedString as new style svg animated type. Map SVGStringList to SVGStringListPropertyTearOff.
  • bindings/scripts/CodeGeneratorJS.pm: Handle SVGStringListPropertyTearOff in GetSVGPropertyTypes.
  • bindings/scripts/CodeGeneratorObjC.pm: Ditto.
  • bindings/scripts/CodeGeneratorV8.pm: Ditto.
  • svg/DeprecatedSVGAnimatedPropertyTraits.h: Remove SVGAnimatedString handling.
  • svg/DeprecatedSVGAnimatedTemplate.h: Ditto.
  • svg/SVGAElement.cpp: Renamed target to svgTarget() to avoid clashes with Element::target(), adjust the bindings to call svgTarget() instead of target(), when processing SVGAElement. (WebCore::SVGAElement::parseMappedAttribute): (WebCore::SVGAElement::synchronizeProperty):
  • svg/SVGAElement.h:
  • svg/SVGAltGlyphElement.h: s/DECLARE_ANIMATED_PROPERTY/DECLARED_ANIMATED_STATIC_PROPERTY_NEW/
  • svg/SVGAnimatedString.h: Added.
  • svg/SVGCursorElement.h: Ditto.
  • svg/SVGFEBlendElement.h: Ditto.
  • svg/SVGFEColorMatrixElement.h: Ditto.
  • svg/SVGFEComponentTransferElement.h: Ditto.
  • svg/SVGFECompositeElement.h: Ditto.
  • svg/SVGFEConvolveMatrixElement.h: Ditto.
  • svg/SVGFEDiffuseLightingElement.h: Ditto.
  • svg/SVGFEDisplacementMapElement.h: Ditto.
  • svg/SVGFEGaussianBlurElement.h: Ditto.
  • svg/SVGFEImageElement.h: Ditto.
  • svg/SVGFEMergeNodeElement.h: Ditto.
  • svg/SVGFEMorphologyElement.h: Ditto.
  • svg/SVGFEOffsetElement.h: Ditto.
  • svg/SVGFESpecularLightingElement.h: Ditto.
  • svg/SVGFETileElement.h: Ditto.
  • svg/SVGFilterElement.h: Ditto.
  • svg/SVGFilterPrimitiveStandardAttributes.h: Ditto.
  • svg/SVGForeignObjectElement.h: Ditto.
  • svg/SVGGradientElement.h: Ditto.
  • svg/SVGImageElement.h: Ditto.
  • svg/SVGLengthList.idl: Remove leftover SVGListProperty marker.
  • svg/SVGMPathElement.h: s/DECLARE_ANIMATED_PROPERTY/DECLARED_ANIMATED_STATIC_PROPERTY_NEW/
  • svg/SVGPatternElement.h: Ditto.
  • svg/SVGScriptElement.h: Ditto.
  • svg/SVGStringList.cpp: Make SVGStringList a plain Vector<String>. (WebCore::SVGStringList::commitChange): React to SVGStringList changes. (WebCore::SVGStringList::reset): (WebCore::SVGStringList::parse):
  • svg/SVGStringList.h: (WebCore::SVGStringList::SVGStringList):
  • svg/SVGStyledElement.h: s/DECLARE_ANIMATED_PROPERTY/DECLARED_ANIMATED_STATIC_PROPERTY_NEW/
  • svg/SVGTRefElement.h: Ditto.
  • svg/SVGTests.cpp: Adapt to SVGStringList API changes. (WebCore::SVGTests::SVGTests): (WebCore::SVGTests::hasExtension): (WebCore::SVGTests::isValid): (WebCore::SVGTests::parseMappedAttribute): (WebCore::SVGTests::isKnownAttribute):
  • svg/SVGTests.h: Ditto. (WebCore::SVGTests::requiredFeatures): (WebCore::SVGTests::requiredExtensions): (WebCore::SVGTests::systemLanguage):
  • svg/SVGTextPathElement.h: s/DECLARE_ANIMATED_PROPERTY/DECLARED_ANIMATED_STATIC_PROPERTY_NEW/
  • svg/SVGURIReference.h: Adapt to SVGStringList API changes. (WebCore::SVGURIReference::~SVGURIReference):
  • svg/SVGUseElement.h: s/DECLARE_ANIMATED_PROPERTY/DECLARED_ANIMATED_STATIC_PROPERTY_NEW/
  • svg/SVGViewElement.cpp: Adapt to SVGStringList API changes. (WebCore::SVGViewElement::SVGViewElement): (WebCore::SVGViewElement::parseMappedAttribute):
  • svg/SVGViewElement.h: Ditto. (WebCore::SVGViewElement::viewTarget):
  • svg/properties/SVGAnimatedPropertyMacros.h: Moved GetOwnerElementForType heleprs from SVGAnimatedPropertySynchronizer into this file.
  • svg/properties/SVGAnimatedPropertySynchronizer.h:
  • svg/properties/SVGPropertyTraits.h: Handle SVGStringList.
  • svg/properties/SVGStringListPropertyTearOff.h: Added. This is a simplified version of SVGListPropertyTearOff, tied to SVGStringList and its special demands. (WebCore::SVGStringListPropertyTearOff::create): (WebCore::SVGStringListPropertyTearOff::clear): (WebCore::SVGStringListPropertyTearOff::numberOfItems): (WebCore::SVGStringListPropertyTearOff::initialize): (WebCore::SVGStringListPropertyTearOff::getItem): (WebCore::SVGStringListPropertyTearOff::insertItemBefore): (WebCore::SVGStringListPropertyTearOff::replaceItem): (WebCore::SVGStringListPropertyTearOff::removeItem): (WebCore::SVGStringListPropertyTearOff::appendItem): (WebCore::SVGStringListPropertyTearOff::SVGStringListPropertyTearOff):

2010-11-03 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Convert SVGAnimatedString/SVGStringList to the new SVG*PropertyTearOff concept
https://bugs.webkit.org/show_bug.cgi?id=48898

Add a new SVGStringList test ensuring that the items returned by getItem etc. are not live (it's a plain DOMString).
Add a new test from SVG 1.1 2nd edition regarding SVGStringList. The list operations all pass, but because of a bug
in SVGTests requiredFeatures handling (see bug 40887) there's still one red rectangle in the middle.

  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.checksum: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.png: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt: Added.
  • svg/W3C-SVG-1.1-SE/types-dom-06-f.svg: Added.
  • svg/dom/SVGStringList-expected.txt: Added.
  • svg/dom/SVGStringList.html: Added.
  • svg/dom/script-tests/SVGStringList.js: Added.
03:14 Changeset [71226] by loki@webkit.org

2010-11-03 Gabor Loki <loki@webkit.org>

Reviewed by Andreas Kling.

Remove unused initializeWeakRandomNumberGenerator
https://bugs.webkit.org/show_bug.cgi?id=48899

WeakRandom class is used instead of weakRandomNumber and its initializer.

  • wtf/RandomNumberSeed.h:
02:48 Changeset [71225] by dbates@webkit.org

2010-11-03 Daniel Bates <dbates@rim.com>

Rubber-stamped by Nikolas Zimmermann.

Remove the platform-specific GTK results following changeset 71218
<http://trac.webkit.org/changeset/71218> since it is sufficient to
use the platform-independent results, LayoutTests/svg/css/getComputedStyle-basic-expected.txt.

  • platform/gtk/svg/css/getComputedStyle-basic-expected.txt: Removed.
02:25 Changeset [71224] by rolandsteiner@chromium.org

2010-11-03 Roland Steiner <rolandsteiner@chromium.org>

Unreviewed: additionally update Windows Chromium expectations after WebKit r71218

  • platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
01:55 Changeset [71223] by rolandsteiner@chromium.org

2010-11-03 Roland Steiner <rolandsteiner@chromium.org>

Unreviewed: update Chromium expectations after WebKit r71218

  • platform/chromium-mac/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-mac/svg/css/getComputedStyle-basic-expected.txt:
01:36 Changeset [71222] by zherczeg@webkit.org

SVG FELighting performance issues
https://bugs.webkit.org/show_bug.cgi?id=48212

Reviewed by Dirk Schulze.

This patch speeds-up FELighting filter painting by 40%
It reduces the number of floating point operations and
empolys faster pixel manipulation (both for read and
write). Furthermore the length() member of FloatPoint3D
is made inline to speed up vector length calculations.

The lighting filter pixels tests are cover this patch.

  • platform/graphics/FloatPoint3D.cpp:
  • platform/graphics/FloatPoint3D.h:

(WebCore::FloatPoint3D::length):

  • platform/graphics/filters/FELighting.cpp:

(WebCore::FELighting::LightingData::topLeft):
(WebCore::FELighting::LightingData::topRow):
(WebCore::FELighting::LightingData::topRight):
(WebCore::FELighting::LightingData::leftColumn):
(WebCore::FELighting::LightingData::interior):
(WebCore::FELighting::LightingData::rightColumn):
(WebCore::FELighting::LightingData::bottomLeft):
(WebCore::FELighting::LightingData::bottomRow):
(WebCore::FELighting::LightingData::bottomRight):
(WebCore::FELighting::inlineSetPixel):
(WebCore::FELighting::setPixel):
(WebCore::FELighting::drawLighting):
(WebCore::FELighting::apply):

  • platform/graphics/filters/FELighting.h:
  • platform/graphics/filters/LightSource.cpp:

(WebCore::PointLightSource::updatePaintingData):
(WebCore::SpotLightSource::updatePaintingData):
(WebCore::DistantLightSource::initPaintingData):

  • platform/graphics/filters/LightSource.h:
01:33 Changeset [71221] by philn@webkit.org

2010-11-03 Philippe Normand <pnormand@igalia.com>

Unreviewed, unskipping passing media test.

[GTK] Need results for media/video-poster-scale.html
https://bugs.webkit.org/show_bug.cgi?id=33541

  • platform/gtk/Skipped: Unskip media/video-poster-scale.html.
01:21 Changeset [71220] by loki@webkit.org

2010-11-03 Gabor Loki <loki@webkit.org>

Reviewed by Geoffrey Garen.

Unused class: JSFastMath with JSValue64
https://bugs.webkit.org/show_bug.cgi?id=48835

Remove unused JSFastMath class.

  • runtime/JSImmediate.h:
Note: See TracTimeline for information about the timeline view.