Timeline
Nov 10, 2010:
- 11:37 PM Changeset in webkit [71797] by
-
- 5 edits3 adds in trunk
2010-11-10 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Adam Barth.
[HTML5] 10.2.8.4 Scripts that modify the page as it is being parsed
https://bugs.webkit.org/show_bug.cgi?id=49364
Fixed HTMLScriptRunner's executeScript to use the ScriptController of the frame to which script element belongs
as supposed to that of the frame associated with the HTMLScriptRunner.
Test: fast/parser/script-modify-page-outer.html
- html/parser/HTMLScriptRunner.cpp: (WebCore::HTMLScriptRunner::executePendingScriptAndDispatchEvent): Calls executeScript. (WebCore::HTMLScriptRunner::executeScript): Uses the correct ScriptController instance. (WebCore::HTMLScriptRunner::runScript): Call executeScript.
- html/parser/HTMLScriptRunner.h:
2010-11-10 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Adam Barth.
[HTML5] 10.2.8.4 Scripts that modify the page as it is being parsed
https://bugs.webkit.org/show_bug.cgi?id=49364
Added a test to ensure moving the script element to the parent document as it is being parsed
changes the script's global object to the parent document's window object.
- fast/parser/move-during-parsing-expected.txt:
- fast/parser/resources/script-modify-page-inner.html: Added.
- fast/parser/script-modify-page-outer-expected.txt: Added.
- fast/parser/script-modify-page-outer.html: Added.
- 9:20 PM Changeset in webkit [71796] by
-
- 2 edits in trunk/WebCore
Style fix I said I’d make then forgot to make.
- platform/graphics/mac/ComplexTextControllerCoreText.cpp:
(WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun):
- 9:18 PM Changeset in webkit [71795] by
-
- 3 edits in trunk/WebCore
Allow for the possibility of CoreText generating multiple runs for a single text run.
https://bugs.webkit.org/show_bug.cgi?id=49353
Patch by Ned Holbrook <nholbrook@apple.com> on 2010-11-10
Reviewed by Dan Bernstein.
- platform/graphics/mac/ComplexTextController.h:
(WebCore::ComplexTextController::ComplexTextRun::create):
- platform/graphics/mac/ComplexTextControllerCoreText.cpp:
(WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun):
(WebCore::ComplexTextController::collectComplexTextRunsForCharactersCoreText):
- 8:58 PM Changeset in webkit [71794] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, updating Chromium expectations.
- platform/chromium/test_expectations.txt:
- 7:09 PM Changeset in webkit [71793] by
-
- 2 edits in trunk/WebKit/chromium
2010-11-10 Kenneth Russell <kbr@google.com>
Reviewed by James Robinson.
[chromium] Clean up gfx::GetGLImplementation calls in WebGraphicsContext3DDefaultImpl
https://bugs.webkit.org/show_bug.cgi?id=49336
- src/WebGraphicsContext3DDefaultImpl.cpp: (WebKit::WebGraphicsContext3DDefaultImpl::initialize): (WebKit::WebGraphicsContext3DDefaultImpl::reshape): (WebKit::WebGraphicsContext3DDefaultImpl::readBackFramebuffer): (WebKit::WebGraphicsContext3DDefaultImpl::getIntegerv):
- 6:37 PM Changeset in webkit [71792] by
-
- 6 edits in trunk
2010-11-10 Chris Guillory <chris.guillory@google.com>
Reviewed by Chris Fleizach.
Use IAccessibleComparable to compare accessibility objects.
https://bugs.webkit.org/show_bug.cgi?id=49118
- platform/win/Skipped:
2010-11-10 Chris Guillory <chris.guillory@google.com>
Reviewed by Chris Fleizach.
Use IAccessibleComparable to compare accessibility objects.
https://bugs.webkit.org/show_bug.cgi?id=49118
- DumpRenderTree/AccessibilityUIElement.cpp: (AccessibilityUIElement::isEqual):
- DumpRenderTree/AccessibilityUIElement.h:
- DumpRenderTree/win/AccessibilityUIElementWin.cpp: (comparableObject): (AccessibilityUIElement::isEqual):
- 6:28 PM Changeset in webkit [71791] by
-
- 9 edits4 adds in trunk
2010-10-18 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] Widgets do not support CSS transformations
https://bugs.webkit.org/show_bug.cgi?id=40139
Added a platform-specific baseline for the slider transformation
test. This baseline says "FAIL" because the test has platform-specific
offsets hard-coded. The result is only one tick off from expected though,
so it's likely correct for us.
- platform/gtk/Skipped: Unskip.
- platform/gtk/fast/forms/slider-transformed-expected.txt: Added.
2010-10-15 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] Widgets do not support CSS transformations
https://bugs.webkit.org/show_bug.cgi?id=40139
Instead of rendering directly onto the target drawable when rendering
form controls on GTK+ 2.0, render onto an intermediate surface and use
cairo to blit the result back to the target surface. This has two
benefits. The first is that it always honors the current Cairo
transformation. The second is that since the intermediate drawable is
always a 32-bit GdkPixmap, we do not have to have a set of widgets
per-colormap any longer.
This change also begins the abstraction of widget rendering so that GTK+
2 and GTK+ 3 can use the same code path. The WidgetRenderingContext will
eventually hide all version differences from RenderThemeGtk, which can
just focus on interpreting the GtkStyle properties.
- GNUmakefile.am: Add WidgetRenderinContext source files to the sources list.
- platform/graphics/cairo/PlatformRefPtrCairo.cpp: (WTF::refPlatformPtr): Add a specialization for Cairo patterns. (WTF::derefPlatformPtr): Ditto.
- platform/graphics/cairo/PlatformRefPtrCairo.h: Ditto.
- platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::RenderThemeGtk): No longer keep a set of widgets per-colormap for GTK+, instead just determine if we can use RGBA colormaps and go from there. (WebCore::RenderThemeGtk::~RenderThemeGtk): Ditto. (WebCore::RenderThemeGtk::getIndicatorMetrics): Put the logic for getting toggle button indicator metrics into this helper. (WebCore::RenderThemeGtk::paintRenderObject): Now uses WidgetRenderingContext to do widget rendering. (WebCore::setToggleSize): Use the new getIndicatorMetrics helper.
- platform/gtk/RenderThemeGtk.h: Added a member to track whether or not the widgets are using a RGBA colormap. Also remove a defunct Page* member.
- platform/gtk/ScrollbarThemeGtk.cpp: Switch all widget drawing operations to use WidgetRenderingContext. (WebCore::ScrollbarThemeGtk::paintTrackBackground): Ditto. (WebCore::ScrollbarThemeGtk::paintScrollbarBackground): Ditto. (WebCore::ScrollbarThemeGtk::paintThumb): Ditto. (WebCore::ScrollbarThemeGtk::paint): Ditto. (WebCore::ScrollbarThemeGtk::paintButton): Ditto.
- platform/gtk/WidgetRenderingContext.h: Added.
- platform/gtk/WidgetRenderingContextGtk2.cpp: Added. (WebCore::purgeScratchBuffer): Added, this is similar to the scratch buffer implementation from ContextShadow. (WebCore::PurgeScratchBufferTimer::fired): Ditto. (WebCore::scheduleScratchBufferPurge): Ditto. (WebCore::getExtraSpaceForWidget): (WebCore::WidgetRenderingContext::WidgetRenderingContext): Added. (WebCore::WidgetRenderingContext::~WidgetRenderingContext): Added. (WebCore::WidgetRenderingContext::paintMozillaWidget): Added.
- platform/gtk/WidgetRenderingContextGtk3.cpp: Added. (WebCore::WidgetRenderingContext::WidgetRenderingContext): Added. (WebCore::~WidgetRenderingContext::WidgetRenderingContext): Added. (WebCore::WidgetRenderingContext::paintMozillaWidget): Added.
- 6:00 PM Changeset in webkit [71790] by
-
- 16 edits in trunk
Fix for https://bugs.webkit.org/show_bug.cgi?id=49356
-[WebView _scaleWebView:] should take and origin and scroll the
document
-and corresponding-
<rdar://problem/8643921>
Reviewed by Simon Fraser.
WebCore:
Apply the scale to the origin, and set a new scroll position.
- page/Frame.cpp:
(WebCore::Frame::scalePage):
- page/Frame.h:
- WebCore.exp.in:
WebKit/mac:
- WebView/WebView.mm:
(-[WebView _scaleWebView:atOrigin:]):
- WebView/WebViewPrivate.h:
WebKit2:
- Shared/API/c/WKSharedAPICast.h:
(WebKit::toImpl):
- UIProcess/API/C/WKPage.cpp:
(WKPageScaleWebView):
- UIProcess/API/C/WKPage.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::scaleWebView):
- UIProcess/WebPageProxy.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::scaleWebView):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
- 5:19 PM Changeset in webkit [71789] by
-
- 2 edits4 adds in trunk/LayoutTests
2010-11-10 Mihai Parparita <mihaip@chromium.org>
Unreviewed Chromium rebaselines.
Rebaseline fast/lists/001-vertical.html and fast/lists/008-vertical.html
with the chromium-mac scrollbars.
Rest of fast/lists/00*-vertical.html tests fail due to bug 48634,
add them to that grouping.
- platform/chromium-mac/fast/lists/001-vertical-expected.checksum: Added.
- platform/chromium-mac/fast/lists/001-vertical-expected.png: Added.
- platform/chromium-mac/fast/lists/008-vertical-expected.checksum: Added.
- platform/chromium-mac/fast/lists/008-vertical-expected.png: Added.
- platform/chromium/test_expectations.txt:
- 5:16 PM Changeset in webkit [71788] by
-
- 2 edits in trunk/WebKit2
Fix Windows build.
- win/WebKit2Generated.make:
- 5:11 PM Changeset in webkit [71787] by
-
- 5 edits in trunk
REGRESSION (r71566): r71566 breaks bidi-control-chars-treated-as-ZWS.html
https://bugs.webkit.org/show_bug.cgi?id=49295
Reviewed by Darin Adler.
WebCore:
- platform/graphics/mac/ComplexTextControllerATSUI.cpp: Reverted to r71565. Eliding bidi
control characters from ATSUI is no longer necessary since ComplexTextController removes
any glyphs corresponding to them.
(WebCore::ComplexTextController::ComplexTextRun::overrideLayoutOperation):
(WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun):
LayoutTests:
- platform/mac-leopard/fast/text/international/bidi-neutral-run-expected.txt:
- 5:02 PM Changeset in webkit [71786] by
-
- 1 edit1 delete in trunk/LayoutTests
2010-11-10 Mihai Parparita <mihaip@chromium.org>
Unreviewed removal of unncessary Qt baseline (atfer r71781 Qt should
use the base one).
- platform/qt/svg/animations/repeatDur-zero-expected.txt: Removed.
- 5:01 PM Changeset in webkit [71785] by
-
- 3 edits in branches/chromium/552/WebKit/chromium
Merge 71774 - 2010-11-10 Evan Stade <estade@chromium.org>
Reviewed by Tony Chang.
[chromium] menu key doesn't work when capslock or numslock is on
https://bugs.webkit.org/show_bug.cgi?id=49289
Add a special bitmask for the "input" modifier keys (shift, alt, crtl, meta). The Modifier
enum has grown to something that might be better termed State, but changing the nomenclature
now is difficult. The bitmask gets its name from the related function getWebInputModifiers.
- public/WebInputEvent.h: add InputModifiers mask for true modifier keys
- src/WebViewImpl.cpp: disregard non-modifier keys (WebKit::WebViewImpl::keyEvent):
- 4:48 PM Changeset in webkit [71784] by
-
- 3 edits4 adds in trunk
2010-11-10 Pascal Massimino <pascal.massimino@gmail.com>
Reviewed by Adam Barth.
add test case for png where each row has or hasn't alpha values.
This is to exercise code logic within PNGImageDecoder.cpp
- fast/images/png_per_row_alpha_decoding-expected.png: Added.
- fast/images/png_per_row_alpha_decoding-expected.txt: Added.
- fast/images/png_per_row_alpha_decoding.html: Added.
- fast/images/resources/png_per_row_alpha.png: Added.
2010-11-10 Pascal Massimino <pascal.massimino@gmail.com>
Reviewed by Adam Barth.
Simplify the alpha-detection code in png's decoding loop.
https://bugs.webkit.org/show_bug.cgi?id=49333
Added a special test for this case: png_per_row_alpha_decoding.html
- platform/image-decoders/png/PNGImageDecoder.cpp: (WebCore::PNGImageDecoder::rowAvailable): modified loop.
- 4:40 PM Changeset in webkit [71783] by
-
- 3 edits2 adds in trunk
<rdar://problem/8647848> REGRESSION (r68551): Spaces shown at soft hyphens with complex justification
https://bugs.webkit.org/show_bug.cgi?id=49352
Reviewed by Simon Fraser.
WebCore:
Test: fast/text/justification-padding-mid-word.html
- platform/graphics/mac/ComplexTextController.cpp:
(WebCore::ComplexTextController::adjustGlyphsAndAdvances): Changed to add justification padding
and word spacing only at characters that are treated as space, instead of all characters that
use the space glyph (which includes characters treated as zero-width space as well).
LayoutTests:
- fast/text/justification-padding-mid-word-expected.txt: Added.
- fast/text/justification-padding-mid-word.html: Added.
- 4:31 PM Changeset in webkit [71782] by
-
- 3 edits in trunk/WebKit2
2010-11-10 Simon Fraser <Simon Fraser>
Reviewed by Anders Carlsson.
Misc drawing area cleanup
https://bugs.webkit.org/show_bug.cgi?id=49349
- UIProcess/LayerBackedDrawingAreaProxy.cpp: (WebKit::LayerBackedDrawingAreaProxy::setSize): (WebKit::LayerBackedDrawingAreaProxy::setPageIsVisible): (WebKit::LayerBackedDrawingAreaProxy::update): Call process()->send() instead of process()->connection()->send() in case the web process has not been launched yet.
- WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::WebPage): Delay creation of the drawing area until after other WebPage state has been initialized, in case the DrawingArea creation needs to call back to the WebPage.
- 4:29 PM Changeset in webkit [71781] by
-
- 3 edits1 add1 delete in trunk/LayoutTests
2010-11-10 Mihai Parparita <mihaip@chromium.org>
Reviewed by Simon Fraser.
svg/animations/repeatDur-zero.xhtml should use dumpAsText
https://bugs.webkit.org/show_bug.cgi?id=49348
Per r71066 (which added the test), all that we're testing for is whether
or not we hang, therefore using dumpAsText is better (since then we
don't need per-platform baselines).
- platform/chromium/test_expectations.txt:
- platform/mac/svg/animations/repeatDur-zero-expected.txt: Removed.
- svg/animations/repeatDur-zero-expected.txt: Added.
- svg/animations/repeatDur-zero.xhtml:
- 4:22 PM Changeset in webkit [71780] by
-
- 10 edits in trunk/WebKit2
2010-11-10 Simon Fraser <Simon Fraser>
Reviewed by Adam Roben.
Push m_viewSize down to DrawingAreaProxy base class
https://bugs.webkit.org/show_bug.cgi?id=49347
Some refactoring so that the various drawing area classes
can share m_size.
- UIProcess/ChunkedUpdateDrawingAreaProxy.cpp: (WebKit::ChunkedUpdateDrawingAreaProxy::setSize):
- UIProcess/ChunkedUpdateDrawingAreaProxy.h:
- UIProcess/DrawingAreaProxy.h: (WebKit::DrawingAreaProxy::setSize): (WebKit::DrawingAreaProxy::size):
- UIProcess/LayerBackedDrawingAreaProxy.cpp: (WebKit::LayerBackedDrawingAreaProxy::setSize):
- UIProcess/LayerBackedDrawingAreaProxy.h:
- UIProcess/mac/ChunkedUpdateDrawingAreaProxyMac.mm: (WebKit::ChunkedUpdateDrawingAreaProxy::ensureBackingStore): (WebKit::ChunkedUpdateDrawingAreaProxy::drawUpdateChunkIntoBackingStore):
- UIProcess/mac/LayerBackedDrawingAreaProxyMac.mm: (WebKit::LayerBackedDrawingAreaProxy::platformSetSize): (WebKit::LayerBackedDrawingAreaProxy::attachCompositingContext):
- UIProcess/win/ChunkedUpdateDrawingAreaProxyWin.cpp: (WebKit::ChunkedUpdateDrawingAreaProxy::ensureBackingStore):
- UIProcess/qt/ChunkedUpdateDrawingAreaProxyQt.cpp: (WebKit::ChunkedUpdateDrawingAreaProxy::ensureBackingStore):
- 4:22 PM Changeset in webkit [71779] by
-
- 4 edits11 adds in trunk/LayoutTests
2010-11-10 Mihai Parparita <mihaip@chromium.org>
Unreviewed Chromium rebaselines.
Add missing Mac, Windows and Linux baselines (no actual Linux baselines
are included, the Windows ones are also used for it).
- platform/chromium-mac/fast/blockflow/background-horizontal-bt-expected.checksum:
- platform/chromium-mac/fast/blockflow/background-horizontal-bt-expected.png: Added.
- platform/chromium-mac/fast/blockflow/background-vertical-lr-expected.checksum:
- platform/chromium-mac/fast/blockflow/background-vertical-lr-expected.png: Added.
- platform/chromium-win/fast/blockflow/background-horizontal-bt-expected.checksum: Added.
- platform/chromium-win/fast/blockflow/background-horizontal-bt-expected.png: Added.
- platform/chromium-win/fast/blockflow/background-horizontal-bt-expected.txt: Added.
- platform/chromium-win/fast/blockflow/background-vertical-lr-expected.checksum: Added.
- platform/chromium-win/fast/blockflow/background-vertical-lr-expected.png: Added.
- platform/chromium-win/fast/blockflow/background-vertical-lr-expected.txt: Added.
- platform/chromium-win/fast/blockflow/background-vertical-rl-expected.checksum: Added.
- platform/chromium-win/fast/blockflow/background-vertical-rl-expected.png: Added.
- platform/chromium-win/fast/blockflow/background-vertical-rl-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- 4:00 PM Changeset in webkit [71778] by
-
- 1 edit1 add in trunk/LayoutTests
2010-11-10 Mihai Parparita <mihaip@chromium.org>
Unreviewed Chromium rebaseline.
Add back text expectation mistakenly removed by r71773.
- platform/chromium-mac/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.txt: Added.
- 3:34 PM Changeset in webkit [71777] by
-
- 2 edits in trunk/LayoutTests
2010-11-10 Mihai Parparita <mihaip@chromium.org>
Unreviewed Leopard rebaseline.
Rebaseline fast/text/international/bidi-neutral-run.html after r71763.
- platform/mac-leopard/fast/text/international/bidi-neutral-run-expected.txt:
- 3:08 PM Changeset in webkit [71776] by
-
- 3 edits in trunk/LayoutTests
2010-11-10 Tony Chang <tony@chromium.org>
Reviewed by Darin Adler.
plugins/npruntime/enumerate.html shouldn't depend on object enumeration order
https://bugs.webkit.org/show_bug.cgi?id=49338
The ES spec doesn't specify the order, so the test shouldn't depend on it.
Unfortunately, the test still fails in Chromium.
- platform/chromium/test_expectations.txt:
- plugins/npruntime/enumerate.html:
- 2:49 PM Changeset in webkit [71775] by
-
- 3 edits1 add in trunk/LayoutTests
2010-11-10 Stephen White <senorblanco@chromium.org>
Unreviewed; test expectations and baselines.
[chromium] Clean up test_expectations from my lazy gardening. One
new baseline. Remove expectations for many-layers.html (which itself
was removed in r71577).
- platform/chromium-gpu/test_expectations.txt:
- platform/chromium-linux/fast/text/midword-break-after-breakable-char-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- 2:47 PM Changeset in webkit [71774] by
-
- 3 edits in trunk/WebKit/chromium
2010-11-10 Evan Stade <estade@chromium.org>
Reviewed by Tony Chang.
[chromium] menu key doesn't work when capslock or numslock is on
https://bugs.webkit.org/show_bug.cgi?id=49289
Add a special bitmask for the "input" modifier keys (shift, alt, crtl, meta). The Modifier
enum has grown to something that might be better termed State, but changing the nomenclature
now is difficult. The bitmask gets its name from the related function getWebInputModifiers.
- public/WebInputEvent.h: add InputModifiers mask for true modifier keys
- src/WebViewImpl.cpp: disregard non-modifier keys (WebKit::WebViewImpl::keyEvent):
- 2:44 PM Changeset in webkit [71773] by
-
- 4 edits1 delete in trunk/LayoutTests
2010-11-10 Mihai Parparita <mihaip@chromium.org>
Unreviewed Chromium rebaseline.
Update chromium-mac baselines after r71763.
- platform/chromium-mac/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.checksum:
- platform/chromium-mac/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.png:
- platform/chromium-mac/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.txt: Removed.
- platform/chromium-mac/fast/text/international/bidi-neutral-run-expected.txt:
- 2:44 PM Changeset in webkit [71772] by
-
- 3 edits1 add in trunk/WebCore
2010-11-10 Matthew Delaney <mdelaney@apple.com>
Reviewed by Darin Adler.
Crash in documentWillBecomeInactive() when closing window with Reader showing content with SVG
https://bugs.webkit.org/show_bug.cgi?id=49084
Manual test added.
- manual-tests/svg-deep-clone-to-new-doc.html: Added manual test for reproducing bug since an automated version proved to be a bit tough to craft up.
- svg/SVGSVGElement.cpp: Added in necessary document ownership transfer calls.
- svg/SVGSVGElement.h:
- 2:32 PM Changeset in webkit [71771] by
-
- 2 edits in trunk/WebCore
2010-11-10 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Red error bubbles don't fit content.
https://bugs.webkit.org/show_bug.cgi?id=49305
- inspector/front-end/textViewer.css: (.webkit-html-message-bubble):
- 2:07 PM Changeset in webkit [71770] by
-
- 1 edit2 adds in trunk/LayoutTests
https://bugs.webkit.org/show_bug.cgi?id=45205
<rdar://problem/8391455> Detached elements shouldn't have style sheets.
Land test files I missed in original check-in.
- fast/dom/StyleSheet/resources: Added.
- fast/dom/StyleSheet/resources/detached-style.css: Added.
- 1:38 PM Changeset in webkit [71769] by
-
- 2 edits in trunk/WebCore
Release build fix.
- css/StyleSheet.cpp: isAcceptableStyleSheetParent() is a debug-only function.
- 1:16 PM Changeset in webkit [71768] by
-
- 37 edits in trunk/LayoutTests
2010-11-10 Stephen White <senorblanco@chromium.org>
Unreviewed; updated test baselines.
Updated chromium-win tests affected slightly by
http://trac.webkit.org/changeset/71760.
- platform/chromium-win/svg/W3C-SVG-1.1/filters-color-01-b-expected.checksum:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-specular-01-f-expected.checksum:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-specular-01-f-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-turb-01-f-expected.checksum:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-turb-01-f-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-turb-02-f-expected.checksum:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-turb-02-f-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.checksum:
- platform/chromium-win/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.checksum:
- platform/chromium-win/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.checksum:
- platform/chromium-win/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.checksum:
- platform/chromium-win/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-dom-baseFrequency-attr-expected.checksum:
- platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-dom-baseFrequency-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-dom-numOctaves-attr-expected.checksum:
- platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-dom-numOctaves-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-dom-seed-attr-expected.checksum:
- platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-dom-seed-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-dom-stitchTiles-attr-expected.checksum:
- platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-dom-stitchTiles-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-dom-type-attr-expected.checksum:
- platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-dom-type-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-numOctaves-prop-expected.checksum:
- platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-numOctaves-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-seed-prop-expected.checksum:
- platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-seed-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-stitchTiles-prop-expected.checksum:
- platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-stitchTiles-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-type-prop-expected.checksum:
- platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-type-prop-expected.png:
- platform/chromium-win/svg/filters/feLighting-crash-expected.checksum:
- platform/chromium-win/svg/filters/feLighting-crash-expected.png:
- 1:12 PM Changeset in webkit [71767] by
-
- 17 edits8 adds4 deletes in trunk
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=45205
<rdar://problem/8391455> Detached elements shouldn't have style sheets.
Tests: fast/dom/StyleSheet/detached-style-2.html
fast/dom/StyleSheet/detached-style-pi.xhtml
fast/dom/StyleSheet/detached-style.html
fast/dom/StyleSheet/detached-style-pi-2.xhtml
- bindings/js/JSStyleSheetCustom.cpp: (WebCore::JSStyleSheet::markChildren): There is no longer a need to mark owner nodes - StyleSheet->ownerNode() is only non-null when the node is in document.
- css/StyleSheet.cpp: (WebCore::StyleSheet::StyleSheet): Added an assertion checking that all nodes that can be StyleSheet parents have been verified.
- css/StyleSheet.h: (WebCore::StyleSheet::clearOwnerNode): Added.
- dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::~ProcessingInstruction): Clear stylesheet's owner node. This shouldn't have observable effect, since a processing instruction that is in document can only be destroyed with document, and a reachable stylsheet keeps document alive. (WebCore::ProcessingInstruction::removedFromDocument): Clear the relationship between node and style sheet when removed. (WebCore::ProcessingInstruction::setCSSStyleSheet): If the element was removed during load, we still don't want to create a style sheet.
- dom/StyleElement.cpp: (WebCore::StyleElement::sheet): There is no reason for lazy creation. It was a wrong fix for bug 14462, whose regression test still passes. (WebCore::StyleElement::removedFromDocument): Clear the relationship between node and style sheet when removed. (WebCore::StyleElement::finishParsingChildren): Don't call sheet(), it doens't have side effects any more. (WebCore::StyleElement::createSheet): Assert that the element is in document. We never want to create a style sheet for an element that isn't.
- dom/StyleElement.h: (WebCore::StyleElement::sheet): Made implementation inline, now that it's a simple getter.
- html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::~HTMLLinkElement): Clear stylesheet's owner node. (WebCore::HTMLLinkElement::process): Assert that there is no style sheet lingering for any reason. (WebCore::HTMLLinkElement::removedFromDocument): Clear the relationship between node and style sheet when removed. (WebCore::HTMLLinkElement::setCSSStyleSheet): If the element was removed during load, we still don't want to create a style sheet.
- html/HTMLStyleElement.cpp: (WebCore::HTMLStyleElement::~HTMLStyleElement):
- html/HTMLStyleElement.h:
- svg/SVGStyleElement.cpp: (WebCore::SVGStyleElement::~SVGStyleElement):
- svg/SVGStyleElement.h: Clear stylesheet's owner node. As above, this shouldn't have observable effect.
- xml/XSLTProcessor.h:
- xml/XSLTProcessor.cpp: (WebCore::XSLTProcessor::~XSLTProcessor):
- dom/Document.cpp: (WebCore::Document::~Document):
- css/CSSParser.cpp: (WebCore::CSSParser::parseSelector): Assert that stylesheet won't outlive its owner node. We don't really use refcounting here.
- 1:11 PM Changeset in webkit [71766] by
-
- 38 edits2 copies in branches/audio
audio branch: changes made for landing in trunk
- update Webcore.gyp with latest audio files
- remove PassThroughPanner from WebCore.xcodeproj
- FFMPEG file reading cleanup
- remove obsolete pass-through panning model
- deal with ppc and i386 vs. other architectures in calls to Accelerate.framework
- various custom bindings cleanup
- add ChromiumBridge loadPlatformAudioResource() and decodeAudioFileData() methods
- add WebAudioBus thin wrapper class for use by WebKitClient::decodeAudioFileData()
- enable WEB_AUDIO on audio branch for chrome
- cleanup AudioBusMac, RealtimeAnalyser, RealtimeAnalyerNode, JavaScriptAudioNode, AudioProcessingEvent, ConvolverNode, AudioBufferSourceNode, AudioChannelSplitter, AudioDestinationNode, AudioGainNode
- use Conditional=WEB_AUDIO for DOMWindow AudioContext constructor
- include <CoreServices/CoreServices.h> in AudioFileReaderMac.cpp
- no longer need to include "HTMLNames.h" in AudioContext.cpp
- 1:04 PM Changeset in webkit [71765] by
-
- 1 edit in trunk/LayoutTests/ChangeLog
Fixed messed-up ChangeLog.
- 12:55 PM Changeset in webkit [71764] by
-
- 37 edits in trunk/LayoutTests
2010-11-10 Dan Bernstein <mitz@apple.com>
REGRESSION (r71566): r71566 breaks bidi-control-chars-treated-as-ZWS.html
https://bugs.webkit.org/show_bug.cgi?id=49295
- platform/mac-leopard/Skipped: Re-enable the previously failing test.
- 12:53 PM Changeset in webkit [71763] by
-
- 5 edits in trunk
REGRESSION (r71566): r71566 breaks bidi-control-chars-treated-as-ZWS.html
https://bugs.webkit.org/show_bug.cgi?id=49295
WebCore:
Reviewed by Dave Hyatt.
- platform/graphics/mac/ComplexTextController.h: Added m_indexOffset.
- platform/graphics/mac/ComplexTextControllerATSUI.cpp:
(WebCore::ComplexTextController::ComplexTextRun::overrideLayoutOperation): Use m_indexOffset
instead of computing the offset based on m_directionalOverride.
(WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun): Set m_indexOffset to
the offset between indices in m_characters and indices in the text passed to ATSUI.
LayoutTests:
- platform/mac-leopard/Skipped: Re-enable the previously failing test.
- 12:44 PM Changeset in webkit [71762] by
-
- 2 edits in trunk/WebCore
2010-11-10 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Gear menu floats to right edge and expands
to bottom of "Styles" section.
https://bugs.webkit.org/show_bug.cgi?id=49303
This fixes computed style's option wrapping to the next line.
- inspector/front-end/inspector.css: (.sidebar-pane-subtitle):
- 12:30 PM Changeset in webkit [71761] by
-
- 2 edits in trunk/WebKit2
Closing tabs sometimes crashes the WebProcess in invalidateContentsAndWindow
https://bugs.webkit.org/show_bug.cgi?id=49335
<rdar://problem/8646621>
Reviewed by Dan Bernstein.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::changeAcceleratedCompositingMode):
If we fail to send the DidChangeAcceleratedCompositing message, don't null out the
drawing area. This will happen during page teardown.
- 12:16 PM Changeset in webkit [71760] by
-
- 4 edits in trunk
2010-11-10 Stephen White <senorblanco@chromium.org>
Reviewed by James Robinson.
Fix canvas.putImageData(canvas.getImageData(...)) to be lossless.
https://bugs.webkit.org/show_bug.cgi?id=49330
These cycles should be lossless for valid colours. A similar fix went
into the CG port at r32878.
Covered by canvas/philip/tests/2d.imageData.put.unchanged.html.
- platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::mulDiv255Ceil): A helper function to do (a + b + 254) / 255 without a divide. (WebCore::putImageData): Use the above helper to round up when premultiplying alpha.
2010-11-10 Stephen White <senorblanco@chromium.org>
Reviewed by James Robinson.
Mark 2d.imageData.put.unchanged.html as passing on Win/Linux.
https://bugs.webkit.org/show_bug.cgi?id=49330
- platform/chromium/test_expectations.txt:
- 11:29 AM Changeset in webkit [71759] by
-
- 2 edits19 adds in trunk/LayoutTests
2010-11-10 Mihai Parparita <mihaip@chromium.org>
Unreviewed Chromium Mac rebaselines.
Add Chromium Mac baselines for tests added by r71382 (since they have
scrollbars they can't use the upstream Mac baselines).
- platform/chromium-mac/fast/table/027-vertical-expected.checksum: Added.
- platform/chromium-mac/fast/table/027-vertical-expected.png: Added.
- platform/chromium-mac/fast/table/028-vertical-expected.checksum: Added.
- platform/chromium-mac/fast/table/028-vertical-expected.png: Added.
- platform/chromium-mac/fast/table/038-vertical-expected.checksum: Added.
- platform/chromium-mac/fast/table/038-vertical-expected.png: Added.
- platform/chromium-mac/fast/table/040-vertical-expected.checksum: Added.
- platform/chromium-mac/fast/table/040-vertical-expected.png: Added.
- platform/chromium-mac/fast/table/border-collapsing/002-vertical-expected.checksum: Added.
- platform/chromium-mac/fast/table/border-collapsing/002-vertical-expected.png: Added.
- platform/chromium-mac/fast/table/border-collapsing/004-vertical-expected.checksum: Added.
- platform/chromium-mac/fast/table/border-collapsing/004-vertical-expected.png: Added.
- platform/chromium-mac/fast/table/border-collapsing/equal-precedence-resolution-vertical-expected.checksum: Added.
- platform/chromium-mac/fast/table/border-collapsing/equal-precedence-resolution-vertical-expected.png: Added.
- platform/chromium-mac/fast/table/height-percent-test-vertical-expected.checksum: Added.
- platform/chromium-mac/fast/table/height-percent-test-vertical-expected.png: Added.
- platform/chromium-mac/fast/table/table-display-types-vertical-expected.checksum: Added.
- platform/chromium-mac/fast/table/table-display-types-vertical-expected.png: Added.
- platform/chromium/test_expectations.txt:
- 11:18 AM Changeset in webkit [71758] by
-
- 2 edits in trunk/LayoutTests
2010-11-10 Tony Chang <tony@chromium.org>
Unreviewed, update DRT Chromium Mac plugin test results.
This matches the past 2 runs on the bot.
- platform/chromium/drt_expectations.txt:
- 11:11 AM Changeset in webkit [71757] by
-
- 2 edits96 adds in trunk/LayoutTests
2010-11-10 Mihai Parparita <mihaip@chromium.org>
Unreviewed Chromium Mac rebaselines.
Rebaseline css1/ and css2.1/ (because of scrollbar display diferences).
- platform/chromium-mac/css1/cascade/cascade_order-expected.checksum: Added.
- platform/chromium-mac/css1/cascade/cascade_order-expected.png: Added.
- platform/chromium-mac/css1/classification/display-expected.checksum: Added.
- platform/chromium-mac/css1/classification/display-expected.png: Added.
- platform/chromium-mac/css1/classification/list_style_type-expected.checksum: Added.
- platform/chromium-mac/css1/classification/list_style_type-expected.png: Added.
- platform/chromium-mac/css1/classification/white_space-expected.checksum: Added.
- platform/chromium-mac/css1/classification/white_space-expected.png: Added.
- platform/chromium-mac/css1/color_and_background/background-expected.checksum: Added.
- platform/chromium-mac/css1/color_and_background/background-expected.png: Added.
- platform/chromium-mac/css1/color_and_background/background_attachment-expected.checksum: Added.
- platform/chromium-mac/css1/color_and_background/background_attachment-expected.png: Added.
- platform/chromium-mac/css1/color_and_background/background_position-expected.checksum: Added.
- platform/chromium-mac/css1/color_and_background/background_position-expected.png: Added.
- platform/chromium-mac/css1/color_and_background/background_repeat-expected.checksum: Added.
- platform/chromium-mac/css1/color_and_background/background_repeat-expected.png: Added.
- platform/chromium-mac/css1/conformance/forward_compatible_parsing-expected.checksum: Added.
- platform/chromium-mac/css1/conformance/forward_compatible_parsing-expected.png: Added.
- platform/chromium-mac/css1/font_properties/font-expected.checksum: Added.
- platform/chromium-mac/css1/font_properties/font-expected.png: Added.
- platform/chromium-mac/css1/font_properties/font_size-expected.checksum: Added.
- platform/chromium-mac/css1/font_properties/font_size-expected.png: Added.
- platform/chromium-mac/css1/font_properties/font_weight-expected.checksum: Added.
- platform/chromium-mac/css1/font_properties/font_weight-expected.png: Added.
- platform/chromium-mac/css1/formatting_model/floating_elements-expected.checksum: Added.
- platform/chromium-mac/css1/formatting_model/floating_elements-expected.png: Added.
- platform/chromium-mac/css1/formatting_model/height_of_lines-expected.checksum: Added.
- platform/chromium-mac/css1/formatting_model/height_of_lines-expected.png: Added.
- platform/chromium-mac/css1/formatting_model/horizontal_formatting-expected.checksum: Added.
- platform/chromium-mac/css1/formatting_model/horizontal_formatting-expected.png: Added.
- platform/chromium-mac/css1/formatting_model/inline_elements-expected.checksum: Added.
- platform/chromium-mac/css1/formatting_model/inline_elements-expected.png: Added.
- platform/chromium-mac/css1/formatting_model/replaced_elements-expected.checksum: Added.
- platform/chromium-mac/css1/formatting_model/replaced_elements-expected.png: Added.
- platform/chromium-mac/css1/formatting_model/vertical_formatting-expected.checksum: Added.
- platform/chromium-mac/css1/formatting_model/vertical_formatting-expected.png: Added.
- platform/chromium-mac/css1/pseudo/anchor-expected.checksum: Added.
- platform/chromium-mac/css1/pseudo/anchor-expected.png: Added.
- platform/chromium-mac/css1/pseudo/firstletter-expected.checksum: Added.
- platform/chromium-mac/css1/pseudo/firstletter-expected.png: Added.
- platform/chromium-mac/css1/pseudo/firstline-expected.checksum: Added.
- platform/chromium-mac/css1/pseudo/firstline-expected.png: Added.
- platform/chromium-mac/css1/pseudo/multiple_pseudo_elements-expected.checksum: Added.
- platform/chromium-mac/css1/pseudo/multiple_pseudo_elements-expected.png: Added.
- platform/chromium-mac/css1/text_properties/letter_spacing-expected.checksum: Added.
- platform/chromium-mac/css1/text_properties/letter_spacing-expected.png: Added.
- platform/chromium-mac/css1/text_properties/line_height-expected.checksum: Added.
- platform/chromium-mac/css1/text_properties/line_height-expected.png: Added.
- platform/chromium-mac/css1/text_properties/text_decoration-expected.checksum: Added.
- platform/chromium-mac/css1/text_properties/text_decoration-expected.png: Added.
- platform/chromium-mac/css1/text_properties/text_indent-expected.checksum: Added.
- platform/chromium-mac/css1/text_properties/text_indent-expected.png: Added.
- platform/chromium-mac/css1/text_properties/text_transform-expected.checksum: Added.
- platform/chromium-mac/css1/text_properties/text_transform-expected.png: Added.
- platform/chromium-mac/css1/text_properties/vertical_align-expected.checksum: Added.
- platform/chromium-mac/css1/text_properties/vertical_align-expected.png: Added.
- platform/chromium-mac/css1/text_properties/word_spacing-expected.checksum: Added.
- platform/chromium-mac/css1/text_properties/word_spacing-expected.png: Added.
- platform/chromium-mac/css1/units/color_units-expected.checksum: Added.
- platform/chromium-mac/css1/units/color_units-expected.png: Added.
- platform/chromium-mac/css1/units/length_units-expected.checksum: Added.
- platform/chromium-mac/css1/units/length_units-expected.png: Added.
- platform/chromium-mac/css2.1/t0803-c5502-mrgn-r-02-c-expected.checksum: Added.
- platform/chromium-mac/css2.1/t0803-c5502-mrgn-r-02-c-expected.png: Added.
- platform/chromium-mac/css2.1/t0803-c5505-mrgn-02-c-expected.checksum: Added.
- platform/chromium-mac/css2.1/t0803-c5505-mrgn-02-c-expected.png: Added.
- platform/chromium-mac/css2.1/t080301-c411-vt-mrgn-00-b-expected.checksum: Added.
- platform/chromium-mac/css2.1/t080301-c411-vt-mrgn-00-b-expected.png: Added.
- platform/chromium-mac/css2.1/t0905-c5525-fltclr-00-c-ag-expected.checksum: Added.
- platform/chromium-mac/css2.1/t0905-c5525-fltclr-00-c-ag-expected.png: Added.
- platform/chromium-mac/css2.1/t0905-c5525-fltmrgn-00-c-ag-expected.checksum: Added.
- platform/chromium-mac/css2.1/t0905-c5525-fltmrgn-00-c-ag-expected.png: Added.
- platform/chromium-mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.checksum: Added.
- platform/chromium-mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png: Added.
- platform/chromium-mac/css2.1/t0905-c5526-fltclr-00-c-ag-expected.checksum: Added.
- platform/chromium-mac/css2.1/t0905-c5526-fltclr-00-c-ag-expected.png: Added.
- platform/chromium-mac/css2.1/t1002-c5523-width-02-b-g-expected.checksum: Added.
- platform/chromium-mac/css2.1/t1002-c5523-width-02-b-g-expected.png: Added.
- platform/chromium-mac/css2.1/t1202-counters-08-b-expected.checksum: Added.
- platform/chromium-mac/css2.1/t1202-counters-08-b-expected.png: Added.
- platform/chromium-mac/css2.1/t1202-counters-09-b-expected.checksum: Added.
- platform/chromium-mac/css2.1/t1202-counters-09-b-expected.png: Added.
- platform/chromium-mac/css2.1/t140201-c535-bg-fixd-00-b-g-expected.checksum: Added.
- platform/chromium-mac/css2.1/t140201-c535-bg-fixd-00-b-g-expected.png: Added.
- platform/chromium-mac/css2.1/t140201-c537-bgfxps-00-c-ag-expected.checksum: Added.
- platform/chromium-mac/css2.1/t140201-c537-bgfxps-00-c-ag-expected.png: Added.
- platform/chromium-mac/css2.1/t1508-c527-font-07-b-expected.checksum: Added.
- platform/chromium-mac/css2.1/t1508-c527-font-07-b-expected.png: Added.
- platform/chromium/test_expectations.txt:
- 11:02 AM Changeset in webkit [71756] by
-
- 2 edits in trunk/LayoutTests
2010-11-10 Martin Robinson <mrobinson@igalia.com>
Rebaseline a new test. The patch was posted before font
hinting was disabled in the GTK+ DRT.
- platform/gtk/fonts/complex-text-shadows-expected.txt:
- 10:51 AM Changeset in webkit [71755] by
-
- 3 edits in trunk/LayoutTests
2010-11-10 Mihai Parparita <mihaip@chromium.org>
Unreviewed Chromium DRT expectations update.
- fast/images/gif-loop-count.html fails on Linux and Mac when under the DRT.
- Add more flaky media tests
- Tweak video-referrer.html error output to be more useful
- http/tests/media/video-referer.html:
- platform/chromium/drt_expectations.txt:
- 10:43 AM Changeset in webkit [71754] by
-
- 39 edits in trunk
2010-11-10 Csaba Osztrogonác <Csaba Osztrogonác>
Reviewed by David Hyatt.
HTML5 Ruby support should be mandatory feature
https://bugs.webkit.org/show_bug.cgi?id=49272
Remove Ruby as optional feature.
- Configurations/FeatureDefines.xcconfig:
- JavaScriptCorePrefix.h:: Touch it to avoid incremental build failure on Windows.
2010-11-10 Csaba Osztrogonác <Csaba Osztrogonác>
Reviewed by David Hyatt.
HTML5 Ruby support should be mandatory feature
https://bugs.webkit.org/show_bug.cgi?id=49272
Remove Ruby as optional feature.
- features.gypi:
2010-11-10 Csaba Osztrogonác <Csaba Osztrogonác>
Reviewed by David Hyatt.
HTML5 Ruby support should be mandatory feature
https://bugs.webkit.org/show_bug.cgi?id=49272
- WebKitPrefix.h: Touch it to avoid incremental build failure on Windows.
2010-11-10 Csaba Osztrogonác <Csaba Osztrogonác>
Reviewed by David Hyatt.
HTML5 Ruby support should be mandatory feature
https://bugs.webkit.org/show_bug.cgi?id=49272
Remove Ruby as optional feature.
- Configurations/FeatureDefines.xcconfig:
2010-11-10 Csaba Osztrogonác <Csaba Osztrogonác>
Reviewed by David Hyatt.
HTML5 Ruby support should be mandatory feature
https://bugs.webkit.org/show_bug.cgi?id=49272
Remove Ruby as optional feature.
- win/tools/vsprops/FeatureDefines.vsprops:
- win/tools/vsprops/FeatureDefinesCairo.vsprops:
2010-11-10 Csaba Osztrogonác <Csaba Osztrogonác>
Reviewed by David Hyatt.
HTML5 Ruby support should be mandatory feature
https://bugs.webkit.org/show_bug.cgi?id=49272
Remove Ruby as optional feature.
- Configurations/FeatureDefines.xcconfig:
- DerivedSources.make:
- GNUmakefile.am:
- WebCorePrefix.h: Touch WebCorePrefix.h to avoid incremental build failure on Windows.
- config.h: Touch config.h to avoid incremental build failure on Windows.
- features.pri:
- html/HTMLTagNames.in:
- rendering/RenderBlock.cpp: Remove ENABLE_RUBY guard. (WebCore::canMergeContiguousAnonymousBlocks):
- rendering/RenderObject.cpp: Remove ENABLE_RUBY guard. (WebCore::RenderObject::createObject):
- rendering/RenderRuby.cpp: Remove ENABLE_RUBY guard.
- rendering/RenderRuby.h: Remove ENABLE_RUBY guard.
- rendering/RenderRubyBase.cpp: Remove ENABLE_RUBY guard.
- rendering/RenderRubyBase.h: Remove ENABLE_RUBY guard.
- rendering/RenderRubyRun.cpp: Remove ENABLE_RUBY guard.
- rendering/RenderRubyRun.h: Remove ENABLE_RUBY guard.
- rendering/RenderRubyText.cpp: Remove ENABLE_RUBY guard.
- rendering/RenderRubyText.h: Remove ENABLE_RUBY guard.
2010-11-10 Csaba Osztrogonác <Csaba Osztrogonác>
Reviewed by David Hyatt.
HTML5 Ruby support should be mandatory feature
https://bugs.webkit.org/show_bug.cgi?id=49272
Remove Ruby as optional feature.
- cmake/OptionsEfl.cmake:
- cmakeconfig.h.cmake:
- configure.ac:
2010-11-10 Csaba Osztrogonác <Csaba Osztrogonác>
Reviewed by David Hyatt.
HTML5 Ruby support should be mandatory feature
https://bugs.webkit.org/show_bug.cgi?id=49272
Remove Ruby as optional feature.
- Scripts/build-webkit:
2010-11-10 Csaba Osztrogonác <Csaba Osztrogonác>
Reviewed by David Hyatt.
HTML5 Ruby support should be mandatory feature
https://bugs.webkit.org/show_bug.cgi?id=49272
Remove Ruby as optional feature.
- Configurations/FeatureDefines.xcconfig:
- WebKit2Prefix.h: Touch it to avoid incremental build failure on Windows.
- 10:37 AM Changeset in webkit [71753] by
-
- 3 edits2 adds in trunk/LayoutTests
2010-11-10 Adrienne Walker <enne@google.com>
Reviewed by Kenneth Russell.
Add a test for "is" tests on WebGL objects that have not been bound or
have been deleted. This currently does not work in the Chromium
command buffer or in Mesa, so is skipped there.
https://bugs.webkit.org/show_bug.cgi?id=48877
- fast/canvas/webgl/is-object-expected.txt: Added.
- fast/canvas/webgl/is-object.html: Added.
- platform/chromium-gpu/test_expectations.txt:
- platform/chromium/test_expectations.txt:
- 10:34 AM Changeset in webkit [71752] by
-
- 2 edits in trunk/WebKitTools
Print VC++ Express build logs in the same order that the projects are built
Fixes <http://webkit.org/b/49326> print-vse-failure-logs prints logs
in an unhelpful order
Reviewed by Eric Seidel.
- Scripts/print-vse-failure-logs:
(PrintVisualStudioExpressLogs._build_order): Added. Uses
print-msvc-project-dependencies to figure out the order in which
projects are built.
(PrintVisualStudioExpressLogs._sort_buildlogs): Added. Sorts the logs
based on their build order and project name.
(PrintVisualStudioExpressLogs._obj_directory): Moved code to find the
scripts directory from here...
(PrintVisualStudioExpressLogs._scripts_directory): ...to here.
(PrintVisualStudioExpressLogs.main): Sort the logs before printing
them.
- 10:34 AM Changeset in webkit [71751] by
-
- 2 edits in trunk/WebKitTools
Only print the interesting text from VC++ Express build logs
Fixes <http://webkit.org/b/49325> It's hard to find the interesting
output from print-vse-failure-logs
Reviewed by Eric Seidel.
- Scripts/print-vse-failure-logs: Removed unnecessary os.path import,
added newly-required imports. Removed a comment that was essentially a
FIXME, and is now fixed.
(PrintVisualStudioExpressLogs._relevant_text): Added. Uses
BeautifulSoup to extract the relevant text from the build log.
(PrintVisualStudioExpressLogs.main): Only print the relevant text.
- 9:59 AM Changeset in webkit [71750] by
-
- 3 edits4 adds in trunk
2010-11-10 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] Complex text does not have full CSS text-shadow support
https://bugs.webkit.org/show_bug.cgi?id=45597
Add a test which verifies text-shadow on complex text for the GTK+
port. This can easily be made into a cross-platform test with baselines
for other ports.
- platform/gtk/fonts/complex-text-shadows-expected.checksum: Added.
- platform/gtk/fonts/complex-text-shadows-expected.png: Added.
- platform/gtk/fonts/complex-text-shadows-expected.txt: Added.
- platform/gtk/fonts/complex-text-shadows.html: Added.
2010-11-10 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] Complex text does not have full CSS text-shadow support
https://bugs.webkit.org/show_bug.cgi?id=45597
Add ContextShadow support to FontGtk, which enables non-solid shadows
for complex text rendering.
Test: platform/gtk/fonts/complex-text-shadows.html
- platform/graphics/gtk/FontGtk.cpp: (WebCore::destroyPangoRegion): Added this helper, which helps reduce the number of #ifdefs when dealing with GTK+ region type differences. (WebCore::getPangoRegionExtents): Ditto. (WebCore::drawGlyphsShadow): Added this helper which either renders a solid shadow manually or uses ContextShadow to render a blurry shadow. (WebCore::Font::drawComplexText): Use the new helpers.
- 9:45 AM Changeset in webkit [71749] by
-
- 2 edits in trunk/WebKit/chromium
2010-11-10 Tony Chang <tony@chromium.org>
Unreviewed, add libvpx as a chromium dependency.
This should fix the chromium linux build.
- DEPS:
- 9:34 AM Changeset in webkit [71748] by
-
- 3 edits in trunk/WebCore
2010-11-10 Alejandro G. Castro <alex@igalia.com>
Reviewed by Martin Robinson.
[gtk] The revision r71528 causes crashes in GObjectEventListener
https://bugs.webkit.org/show_bug.cgi?id=49314
Moved the addition of the event listener to the node after calling
the constructor of the event listener. This is required beacuse
the addEventListener API receives the EventListener inside a
PassRefPtr.
- bindings/gobject/GObjectEventListener.cpp: (WebCore::GObjectEventListener::GObjectEventListener):
- bindings/gobject/GObjectEventListener.h: (WebCore::GObjectEventListener::addEventListener):
- 9:21 AM Changeset in webkit [71747] by
-
- 2 edits in trunk/WebKit2
Add license to DerivedSources.make.
Reviewed by Anders Carlsson.
- DerivedSources.make:
- 9:14 AM Changeset in webkit [71746] by
-
- 20 edits in trunk/WebKit2
Convert client classes to use APIClient base class.
https://bugs.webkit.org/show_bug.cgi?id=49322
Reviewed by Adam Roben.
- UIProcess/WebFormClient.cpp:
(WebKit::WebFormClient::willSubmitForm):
- UIProcess/WebFormClient.h:
- UIProcess/WebLoaderClient.cpp:
- UIProcess/WebLoaderClient.h:
- UIProcess/WebPolicyClient.cpp:
- UIProcess/WebPolicyClient.h:
- UIProcess/WebUIClient.cpp:
- UIProcess/WebUIClient.h:
- WebProcess/InjectedBundle/InjectedBundlePageContextMenuClient.cpp:
- WebProcess/InjectedBundle/InjectedBundlePageContextMenuClient.h:
- WebProcess/InjectedBundle/InjectedBundlePageEditorClient.cpp:
- WebProcess/InjectedBundle/InjectedBundlePageEditorClient.h:
- WebProcess/InjectedBundle/InjectedBundlePageFormClient.cpp:
- WebProcess/InjectedBundle/InjectedBundlePageFormClient.h:
- WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:
- WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
- WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:
- WebProcess/InjectedBundle/InjectedBundlePageUIClient.h:
- 9:12 AM Changeset in webkit [71745] by
-
- 14 edits in trunk
2010-11-02 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Enable InspectorCSSAgent (not used by frontend for CSS editing yet)
https://bugs.webkit.org/show_bug.cgi?id=48834
Drive-by fix: use a single API method to retrieve all node-related styles instead of a bunch of separate calls.
Test: inspector/styles-new-API.html
WebCore:
- inspector/CodeGeneratorInspector.pm:
- inspector/Inspector.idl:
- inspector/InspectorCSSAgent.cpp: (WebCore::InspectorCSSAgent::InspectorCSSAgent): (WebCore::InspectorCSSAgent::setDOMAgent): (WebCore::InspectorCSSAgent::reset): (WebCore::InspectorCSSAgent::getStylesForNode2): (WebCore::InspectorCSSAgent::getComputedStyleForNode2): (WebCore::InspectorCSSAgent::addRule2): (WebCore::InspectorCSSAgent::querySelectorAll):
- inspector/InspectorCSSAgent.h:
- inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::releaseFrontendLifetimeAgents): (WebCore::InspectorController::didCommitLoad):
- inspector/InspectorController.h: (WebCore::InspectorController::cssAgent):
- inspector/InspectorDOMAgent.cpp:
- inspector/InspectorDOMAgent.h:
- inspector/InspectorStyleSheet.cpp: (WebCore::InspectorStyle::setPropertyText): (WebCore::InspectorStyle::styleText): (WebCore::InspectorStyle::disableProperty): (WebCore::InspectorStyle::populateAllProperties): (WebCore::InspectorStyle::populateObjectWithStyleProperties): (WebCore::InspectorStyleSheet::buildObjectForRule): (WebCore::InspectorStyleSheet::fixUnparsedPropertyRanges): (WebCore::InspectorStyleSheet::ensureSourceData): (WebCore::InspectorStyleSheetForInlineStyle::text):
- inspector/InspectorStyleSheet.h: (WebCore::InspectorStyleProperty::setRawTextFromStyleDeclaration): (WebCore::InspectorStyleProperty::hasRawText):
LayoutTests:
- inspector/resources/styles-new-API.css: Added. (html): (body): (/* comment before selector */body.main1/* comment after selector */): (body.main2): (body::after): (h1):
- inspector/styles-new-API-expected.txt: Added.
- inspector/styles-new-API.html: Added.
- inspector/styles-source-offsets-expected.txt:
- inspector/styles-source-offsets.html:
- 8:57 AM Changeset in webkit [71744] by
-
- 3 edits2 copies in branches/chromium/552
Merge 71723
BUG=62354
- 8:52 AM Changeset in webkit [71743] by
-
- 3 edits2 copies in branches/chromium/552
Merge 71724
BUG=62281
- 8:28 AM Changeset in webkit [71742] by
-
- 2 edits in trunk/LayoutTests
2010-11-10 Mihai Parparita <mihaip@chromium.org>
Unreviwed, updating Chromium GPU test expectations.
canvas/philip/tests/2d.pattern.image.incomplete.html was fixed by
r71718.
- platform/chromium-gpu/test_expectations.txt:
- 8:27 AM Changeset in webkit [71741] by
-
- 2 edits in trunk/LayoutTests
2010-11-10 Andras Becsi <abecsi@webkit.org>
Rubber-stamped by Csaba Osztrogonác.
[Qt] Deduplicate the Skipped list entries.
- platform/qt/Skipped:
- 8:13 AM Changeset in webkit [71740] by
-
- 3 edits in trunk/WebCore
2010-11-10 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Move CSSStyleDeclaration from DOMAgent.js into CSSStyleModel.js
https://bugs.webkit.org/show_bug.cgi?id=49312
No new tests, as it's just code motion.
- inspector/front-end/CSSStyleModel.js: (WebInspector.CSSStyleDeclaration): (WebInspector.CSSStyleDeclaration.parsePayload): (WebInspector.CSSStyleDeclaration.prototype.get allProperties): (WebInspector.CSSStyleDeclaration.prototype.getLiveProperty): (WebInspector.CSSStyleDeclaration.prototype.getPropertyValue): (WebInspector.CSSStyleDeclaration.prototype.getPropertyPriority): (WebInspector.CSSStyleDeclaration.prototype.getPropertyShorthand): (WebInspector.CSSStyleDeclaration.prototype.isPropertyImplicit): (WebInspector.CSSStyleDeclaration.prototype.styleTextWithShorthands): (WebInspector.CSSStyleDeclaration.prototype.getLonghandProperties): (WebInspector.CSSStyleDeclaration.prototype.getShorthandValue): (WebInspector.CSSStyleDeclaration.prototype.getShorthandPriority): (WebInspector.CSSStyleDeclaration.prototype.appendProperty): (WebInspector.CSSStyleDeclaration.prototype.propertyAt): (WebInspector.CSSRule): (WebInspector.CSSRule.parsePayload): (WebInspector.CSSRule.prototype.get isUserAgent): (WebInspector.CSSRule.prototype.get isUser): (WebInspector.CSSRule.prototype.get isViaInspector): (WebInspector.CSSRule.prototype.get isRegular): (WebInspector.CSSProperty): (WebInspector.CSSProperty.parsePayload): (WebInspector.CSSProperty.prototype.get propertyText): (WebInspector.CSSProperty.prototype.get isLive): (WebInspector.CSSProperty.prototype.get active): (WebInspector.CSSProperty.prototype.get styleBased): (WebInspector.CSSProperty.prototype.get inactive): (WebInspector.CSSProperty.prototype.get disabled): (WebInspector.CSSProperty.prototype.setText): (WebInspector.CSSProperty.prototype.setValue): (WebInspector.CSSProperty.prototype.setDisabled.callback): (WebInspector.CSSProperty.prototype.setDisabled):
- inspector/front-end/DOMAgent.js:
- 8:10 AM Changeset in webkit [71739] by
-
- 2 edits in trunk/LayoutTests
2010-11-10 Andras Becsi <abecsi@webkit.org>
Unreviewed.
[Qt][WK2] http/tests/history/popstate-fires-with-pending-requests.html breaks ~400 subsequent tests
https://bugs.webkit.org/show_bug.cgi?id=49321
- platform/qt-wk2/Skipped: Skip the tests until fix.
- 7:43 AM Changeset in webkit [71738] by
-
- 3 edits in trunk/LayoutTests
2010-11-10 Mihai Parparita <mihaip@chromium.org>
Unreviewed, updating Chromium baselines.
Update Chromium inspector/console-log-syntax-error.html baselines
(after r71010 the path displayed is the same as the upstream baseline).
- platform/chromium/inspector/console-log-syntax-error-expected.txt:
- platform/chromium/test_expectations.txt:
- 7:34 AM Changeset in webkit [71737] by
-
- 4 edits4 adds in trunk/LayoutTests
2010-11-10 Mihai Parparita <mihaip@chromium.org>
Unreviewed, updating Chromium Mac baselines.
- editing/selection/extend-by-word-002.html had selection display changed (for the better) by r71700
- fast/block/basic/truncation-rtl.html was likely checked in with Snow Leopard baselines, but chromium-mac is still on Leopard
- tables/mozilla/bugs/bug82946-2.html needed rebaseline after r71311 switched on ICCJPEG
- platform/chromium-mac/editing/selection/extend-by-word-002-expected.checksum: Added.
- platform/chromium-mac/editing/selection/extend-by-word-002-expected.png: Added.
- platform/chromium-mac/fast/block/basic/truncation-rtl-expected.checksum: Added.
- platform/chromium-mac/fast/block/basic/truncation-rtl-expected.png: Added.
- platform/chromium-mac/tables/mozilla/bugs/bug82946-2-expected.checksum:
- platform/chromium-mac/tables/mozilla/bugs/bug82946-2-expected.png:
- platform/chromium/test_expectations.txt:
- 7:13 AM Changeset in webkit [71736] by
-
- 5 edits in trunk
2010-11-10 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r71733.
http://trac.webkit.org/changeset/71733
https://bugs.webkit.org/show_bug.cgi?id=49319
made qt bot crashy and sad (Requested by kling on #webkit).
- Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::updateResizesToContentsForPage):
- WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::transitionToCommittedForNewPage):
2010-11-10 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r71733.
http://trac.webkit.org/changeset/71733
https://bugs.webkit.org/show_bug.cgi?id=49319
made qt bot crashy and sad (Requested by kling on #webkit).
- page/FrameView.cpp: (WebCore::FrameView::windowClipRect):
- 6:43 AM Changeset in webkit [71735] by
-
- 32 edits3 adds in trunk
2010-11-10 Peter Rybin <peter.rybin@gmail.com>
Reviewed by Adam Barth.
HTML parser should provide script column position within HTML document to JavaScript engine
https://bugs.webkit.org/show_bug.cgi?id=45271
Adds TextPosition* classes -- a structure that stores line/column/generation
level coordinates inside text document. Adds *BasedNumber classes -- typesafe int
wrappers that emphasize whether int number is used as zero-based or
one-based.
- GNUmakefile.am:
- JavaScriptCore.gypi:
- JavaScriptCore.xcodeproj/project.pbxproj:
- wtf/text/TextPosition.h: Added. (WTF::TextPosition::TextPosition): (WTF::TextPosition::minimumPosition): (WTF::TextPosition::belowRangePosition): (WTF::ZeroBasedNumber::fromZeroBasedInt): (WTF::ZeroBasedNumber::ZeroBasedNumber): (WTF::ZeroBasedNumber::zeroBasedInt): (WTF::ZeroBasedNumber::base): (WTF::ZeroBasedNumber::belowBase): (WTF::OneBasedNumber::fromOneBasedInt): (WTF::OneBasedNumber::OneBasedNumber): (WTF::OneBasedNumber::oneBasedInt): (WTF::OneBasedNumber::convertAsZeroBasedInt): (WTF::OneBasedNumber::convertToZeroBased): (WTF::OneBasedNumber::base): (WTF::OneBasedNumber::belowBase): (WTF::toZeroBasedTextPosition): (WTF::toOneBasedTextPosition): (WTF::ZeroBasedNumber::convertToOneBased):
2010-11-10 Peter Rybin <peter.rybin@gmail.com>
Reviewed by Adam Barth.
HTML parser should provide script column position within HTML document to JavaScript engine
https://bugs.webkit.org/show_bug.cgi?id=45271
Replaces line number with TextPosition struct so that script engine
gets script starting line/column.
- ForwardingHeaders/wtf/text/TextPosition.h: Added.
- bindings/js/ScriptSourceCode.h: (WebCore::ScriptSourceCode::ScriptSourceCode):
- bindings/v8/ScheduledAction.cpp: (WebCore::ScheduledAction::ScheduledAction):
- bindings/v8/ScriptController.cpp: (WebCore::ScriptController::eventHandlerPosition):
- bindings/v8/ScriptController.h:
- bindings/v8/ScriptEventListener.cpp: (WebCore::createAttributeEventListener):
- bindings/v8/ScriptSourceCode.h: (WebCore::ScriptSourceCode::ScriptSourceCode): (WebCore::ScriptSourceCode::startLine): (WebCore::ScriptSourceCode::startPosition):
- bindings/v8/V8LazyEventListener.cpp: (WebCore::V8LazyEventListener::V8LazyEventListener): (WebCore::V8LazyEventListener::prepareListenerObject):
- bindings/v8/V8LazyEventListener.h: (WebCore::V8LazyEventListener::create):
- bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::compileScript): (WebCore::V8Proxy::evaluate): (WebCore::V8Proxy::runScript):
- bindings/v8/V8Proxy.h:
- bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::evaluate): (WebCore::WorkerContextExecutionProxy::runScript):
- bindings/v8/WorkerContextExecutionProxy.h:
- bindings/v8/WorkerScriptController.cpp: (WebCore::WorkerScriptController::evaluate):
- dom/PendingScript.cpp: (WebCore::PendingScript::releaseElementAndClear):
- dom/PendingScript.h: (WebCore::PendingScript::PendingScript): (WebCore::PendingScript::operator=): (WebCore::PendingScript::startingPosition):
- dom/ScriptableDocumentParser.h:
- dom/XMLDocumentParser.h:
- dom/XMLDocumentParserLibxml2.cpp: (WebCore::XMLDocumentParser::XMLDocumentParser): (WebCore::XMLDocumentParser::startElementNs): (WebCore::XMLDocumentParser::endElementNs): (WebCore::XMLDocumentParser::lineNumber): (WebCore::XMLDocumentParser::columnNumber): (WebCore::XMLDocumentParser::textPosition): (WebCore::XMLDocumentParser::textPositionOneBased):
- dom/XMLDocumentParserQt.cpp: (WebCore::XMLDocumentParser::XMLDocumentParser): (WebCore::XMLDocumentParser::textPosition): (WebCore::XMLDocumentParser::parseStartElement): (WebCore::XMLDocumentParser::parseEndElement):
- html/parser/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::runScriptsForPausedTreeBuilder): (WebCore::HTMLDocumentParser::textPosition):
- html/parser/HTMLDocumentParser.h:
- html/parser/HTMLScriptRunner.cpp: (WebCore::HTMLScriptRunner::sourceFromPendingScript): (WebCore::HTMLScriptRunner::execute): (WebCore::HTMLScriptRunner::runScript):
- html/parser/HTMLScriptRunner.h:
- html/parser/HTMLTreeBuilder.cpp: (WebCore::uninitializedPositionValue1): (WebCore::HTMLTreeBuilder::HTMLTreeBuilder): (WebCore::HTMLTreeBuilder::takeScriptToProcess): (WebCore::HTMLTreeBuilder::processEndTag): (WebCore::HTMLTreeBuilder::processScriptStartTag):
- html/parser/HTMLTreeBuilder.h:
2010-11-10 Peter Rybin <peter.rybin@gmail.com>
Reviewed by Adam Barth.
HTML parser should provide script column position within HTML document to JavaScript engine
https://bugs.webkit.org/show_bug.cgi?id=45271
Replaces script line number with TextPosition structure.
- src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::executeScript): (WebKit::WebFrameImpl::executeScriptInIsolatedWorld): (WebKit::WebFrameImpl::executeScriptAndReturnValue):
- 5:54 AM Changeset in webkit [71734] by
-
- 2 edits in trunk/WebCore
2010-11-10 Ilya Sherman <isherman@chromium.org>
Reviewed by Shinichiro Hamaji.
Fix autofill popup height computation -- take icon heights into account.
https://bugs.webkit.org/show_bug.cgi?id=49306
- platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupListBox::layout):
- 5:48 AM Changeset in webkit [71733] by
-
- 5 edits in trunk
2010-11-10 Kenneth Rohde Christiansen <kenneth@webkit.org>
Reviewed by Andreas Kling.
Use paintEntireContents in combination with tiling, allowing to
actually set visibleContentRect to something different from
the actual contents size.
- Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::updateResizesToContentsForPage):
- WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::transitionToCommittedForNewPage):
2010-11-10 Kenneth Rohde Christiansen <kenneth@webkit.org>
Reviewed by Andreas Kling.
In paintEntireContents mode (used in combination with tiling) we
cannot clip to the actual visibleContentRect as the clipped regions
will not be updated again on scroll. If paintsEntireContents is
enabled, return the actual content rect.
- page/FrameView.cpp: (WebCore::FrameView::windowClipRect):
- 4:03 AM Changeset in webkit [71732] by
-
- 1 edit33 adds in trunk/LayoutTests
Unreviewed.
[Qt] Add platform specific expected results for new passing tests introduced in r71563 and r71700.
Compared to Mac png files and Mac expected files.
- platform/qt/fast/blockflow/horizontal-bt-replaced-selection-expected.checksum: Added.
- platform/qt/fast/blockflow/horizontal-bt-replaced-selection-expected.png: Added.
- platform/qt/fast/blockflow/horizontal-bt-replaced-selection-expected.txt: Added.
- platform/qt/fast/blockflow/vertical-lr-replaced-selection-expected.checksum: Added.
- platform/qt/fast/blockflow/vertical-lr-replaced-selection-expected.png: Added.
- platform/qt/fast/blockflow/vertical-lr-replaced-selection-expected.txt: Added.
- platform/qt/fast/blockflow/vertical-rl-replaced-selection-expected.checksum: Added.
- platform/qt/fast/blockflow/vertical-rl-replaced-selection-expected.png: Added.
- platform/qt/fast/blockflow/vertical-rl-replaced-selection-expected.txt: Added.
- platform/qt/fast/lists/001-vertical-expected.checksum: Added.
- platform/qt/fast/lists/001-vertical-expected.png: Added.
- platform/qt/fast/lists/001-vertical-expected.txt: Added.
- platform/qt/fast/lists/002-vertical-expected.checksum: Added.
- platform/qt/fast/lists/002-vertical-expected.png: Added.
- platform/qt/fast/lists/002-vertical-expected.txt: Added.
- platform/qt/fast/lists/003-vertical-expected.checksum: Added.
- platform/qt/fast/lists/003-vertical-expected.png: Added.
- platform/qt/fast/lists/003-vertical-expected.txt: Added.
- platform/qt/fast/lists/005-vertical-expected.checksum: Added.
- platform/qt/fast/lists/005-vertical-expected.png: Added.
- platform/qt/fast/lists/005-vertical-expected.txt: Added.
- platform/qt/fast/lists/006-vertical-expected.checksum: Added.
- platform/qt/fast/lists/006-vertical-expected.png: Added.
- platform/qt/fast/lists/006-vertical-expected.txt: Added.
- platform/qt/fast/lists/007-vertical-expected.checksum: Added.
- platform/qt/fast/lists/007-vertical-expected.png: Added.
- platform/qt/fast/lists/007-vertical-expected.txt: Added.
- platform/qt/fast/lists/008-vertical-expected.checksum: Added.
- platform/qt/fast/lists/008-vertical-expected.png: Added.
- platform/qt/fast/lists/008-vertical-expected.txt: Added.
- platform/qt/fast/lists/009-vertical-expected.checksum: Added.
- platform/qt/fast/lists/009-vertical-expected.png: Added.
- platform/qt/fast/lists/009-vertical-expected.txt: Added.
- 3:03 AM Changeset in webkit [71731] by
-
- 2 edits in trunk/LayoutTests
Unreviewed.
[Qt] svg/animations/animate-path-nested-transforms.html fails
https://bugs.webkit.org/show_bug.cgi?id=48987
svg/animations/animate-text-nested-transforms.html introduced in r71726
and has same failure as svg/animations/animate-path-nested-transforms.html
- platform/qt/Skipped: svg/animations/animate-text-nested-transforms.html added.
- 2:55 AM Changeset in webkit [71730] by
-
- 2 edits in trunk/LayoutTests
Unreviwed, updating Chromium test expectations.
- platform/chromium/test_expectations.txt:
- 2:46 AM Changeset in webkit [71729] by
-
- 5 edits in trunk/WebKit2
2010-11-10 Andreas Kling <kling@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt][WK2] Fix re-use of memory-mapped files
https://bugs.webkit.org/show_bug.cgi?id=49310
QTemporaryFile::fileName() returns an empty string after close()
so we have to keep separate track of the filename.
Also, we can't reopen the file if it's been QFile::remove()d,
so we defer unlinking until the MappedMemoryPool is destroyed or
the CrashHandler kicks in.
This makes re-use of memory-mapped files work (after we kill an
assertion that the file size == the new mmap size - it's fine if
the file is larger, too.)
- Platform/qt/MappedMemoryPool.cpp: (WebKit::MappedMemoryPool::~MappedMemoryPool): (WebKit::MappedMemoryPool::clear): (WebKit::MappedMemoryPool::mapMemory): (WebKit::MappedMemoryPool::mapFile):
- Platform/qt/MappedMemoryPool.h: (WebKit::MappedMemory::mappedFileName):
- Shared/qt/CrashHandler.cpp: (WebKit::CrashHandler::deleteObjects):
- Shared/qt/UpdateChunk.cpp: (WebKit::UpdateChunk::encode):
- 2:23 AM Changeset in webkit [71728] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, updating Chromium expectations.
removed the followings, since these always passes recently.
BUG51161 LINUX DEBUG : svg/W3C-SVG-1.1/masking-mask-01-b.svg = CRASH
BUG51161 LINUX DEBUG : svg/clip-path/clip-path-text.svg = CRASH
BUG8729 LINUX DEBUG : http/tests/multipart/invalid-image-data.html = IMAGE PASS
BUGWK45991 : canvas/philip/tests/2d.pattern.image.incomplete.html
BUGDPRANKE LINUX DEBUG : fast/forms/restore-selection-after-layout.html = TEXT
- platform/chromium/test_expectations.txt:
- 1:12 AM Changeset in webkit [71727] by
-
- 1 edit1 add in trunk/WebCore
2010-11-10 Shinichiro Hamaji <hamaji@chromium.org>
Adding a manual test which I forgot to add in r71618.
[Chromium] display:none has no effect on <option> element
https://bugs.webkit.org/show_bug.cgi?id=49169
- manual-tests/display-none-option.html: Added.
- 1:04 AM Changeset in webkit [71726] by
-
- 3 edits3 adds in trunk
2010-11-10 Shane Stephens <shanestephens@google.com>
Reviewed by Dirk Schulze.
SVGTextElement supplemental transforms pre-multiplied but should be
post-multiplied in animatedLocalTransform
https://bugs.webkit.org/show_bug.cgi?id=48215
- svg/animations/animate-text-nested-transforms-expected.txt: Added.
- svg/animations/animate-text-nested-transforms.svg: Added.
2010-11-10 Shane Stephens <shanestephens@google.com>
Reviewed by Dirk Schulze.
SVGTextElement supplemental transforms pre-multiplied but should be
post-multiplied in animatedLocalTransform
https://bugs.webkit.org/show_bug.cgi?id=48215
Test: svg/animations/animate-text-nested-transforms.svg
- svg/SVGTextElement.cpp: (WebCore::SVGTextElement::animatedLocalTransform):
Switched order of multiplication. Note that due to a bug in
AffineTransform's operator* implementation the order of arguments is
reversed (see http://bugs.webkit.org/show_bug.cgi?id=48031).
- 12:48 AM Changeset in webkit [71725] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, updating Chromium expectations
from chrome/src/webkit/tools/layout_tests/test_expectations.txt
- platform/chromium/test_expectations.txt:
- 12:24 AM Changeset in webkit [71724] by
-
- 5 edits2 adds in trunk
2010-11-09 Abhishek Arya <inferno@chromium.org>
Reviewed by Dan Bernstein.
Fieldsets avoid floats. Legend elements are expected to have their parent
as fieldset. When this not the case, floats get added incorrectly added to the
legend blocks. This patch tries to prevent those floats addition.
https://bugs.webkit.org/show_bug.cgi?id=49214
Test: fast/blockflow/overhanging-float-legend-crash.html
- rendering/RenderBox.cpp: (WebCore::RenderBox::avoidsFloats):
- rendering/RenderObject.cpp: (WebCore::RenderObject::isLegend):
- rendering/RenderObject.h:
2010-11-09 Abhishek Arya <inferno@chromium.org>
Reviewed by Dan Bernstein.
Tests that we do not crash and avoid floats to be added in legend element
when it is not enclosed in a fieldset.
https://bugs.webkit.org/show_bug.cgi?id=49214
- fast/blockflow/overhanging-float-legend-crash-expected.txt: Added.
- fast/blockflow/overhanging-float-legend-crash.html: Added.
- 12:20 AM Changeset in webkit [71723] by
-
- 5 edits2 adds in trunk
2010-11-10 Cris Neckar <cdn@chromium.org>
Reviewed by Nikolas Zimmermann.
Added check to ensure that svg viewport containers are not treated in the same way as generic svg containers.
https://bugs.webkit.org/show_bug.cgi?id=49188
Test: svg/dom/viewport-container-crash.svg
- rendering/SVGImageBufferTools.cpp: (WebCore::SVGImageBufferTools::renderSubtreeToImageBuffer):
2010-11-10 Cris Neckar <cdn@chromium.org>
Reviewed by Nikolas Zimmermann.
Test for crash when svg viewport containers are treated as generic svg containers.
https://bugs.webkit.org/show_bug.cgi?id=49188
- svg/dom/viewport-container-crash-expected.txt: Added.
- svg/dom/viewport-container-crash.svg: Added.
Nov 9, 2010:
- 11:36 PM Changeset in webkit [71722] by
-
- 3 edits in trunk/JavaScriptCore
2010-11-09 Gabor Loki <loki@webkit.org>
Reviewed by Gavin Barraclough.
ARM JIT asserts when loading http://reader.google.com in debug mode
https://bugs.webkit.org/show_bug.cgi?id=48912
There are several cases when the uninterrupted sequence is larger than
maximum required offset for pathing the same sequence. Eg.: if in a
uninterrupted sequence the last macroassembler's instruction is a stub
call, it emits store instruction(s) which should not be included in the
calculation of length of uninterrupted sequence. So, the insnSpace and
constSpace should be upper limit instead of hard limit.
- jit/JIT.h:
- jit/JITInlineMethods.h: (JSC::JIT::endUninterruptedSequence):
- 9:59 PM Changeset in webkit [71721] by
-
- 6 edits in trunk/WebCore
2010-11-09 Gyuyoung Kim <gyuyoung.kim@samsung.com>
Reviewed by Eric Seidel.
[WML] Fix build breaks when WML is enabled.
https://bugs.webkit.org/show_bug.cgi?id=49168
The backForward() of Page class returns BackForwarddController class type.
So, WML classes need to include the BackForwardController.h file. And, select()
of RenderTextControl.h was removed. Thus, the select() should be replaced by
setSelectionRange().
- wml/WMLDoElement.cpp: Includes BackForwardController.h.
- wml/WMLDocument.cpp: ditto.
- wml/WMLInputElement.cpp: (WebCore::WMLInputElement::select): Replaced by setSelectionRange().
- wml/WMLPageState.cpp: Includes BackForwardController.h.
- wml/WMLPrevElement.cpp: ditto.
- 9:56 PM Changeset in webkit [71720] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, updating Chromium expectations
- platform/chromium/test_expectations.txt:
- 9:55 PM Changeset in webkit [71719] by
-
- 1 edit3 adds in trunk/WebCore
2010-11-09 Chris Rogers <crogers@google.com>
Reviewed by Kenneth Russell.
Add JavaScriptAudioNode files
https://bugs.webkit.org/show_bug.cgi?id=48875
No new tests since audio API is not yet implemented.
- webaudio/JavaScriptAudioNode.cpp: Added. (WebCore::JavaScriptAudioNode::create): (WebCore::JavaScriptAudioNode::JavaScriptAudioNode): (WebCore::JavaScriptAudioNode::~JavaScriptAudioNode): (WebCore::JavaScriptAudioNode::initialize): (WebCore::JavaScriptAudioNode::uninitialize): (WebCore::JavaScriptAudioNode::toJavaScriptAudioNode): (WebCore::JavaScriptAudioNode::process): (WebCore::JavaScriptAudioNode::fireProcessEventDispatch): (WebCore::JavaScriptAudioNode::fireProcessEvent): (WebCore::JavaScriptAudioNode::reset): (WebCore::JavaScriptAudioNode::scriptExecutionContext):
- webaudio/JavaScriptAudioNode.h: Added. (WebCore::JavaScriptAudioNode::eventTargetData): (WebCore::JavaScriptAudioNode::ensureEventTargetData): (WebCore::JavaScriptAudioNode::bufferSize): (WebCore::JavaScriptAudioNode::doubleBufferIndex): (WebCore::JavaScriptAudioNode::swapBuffers): (WebCore::JavaScriptAudioNode::refEventTarget): (WebCore::JavaScriptAudioNode::derefEventTarget):
- webaudio/JavaScriptAudioNode.idl: Added.
- 9:41 PM Changeset in webkit [71718] by
-
- 5 edits1 delete in trunk/LayoutTests
2010-11-09 Helder Correia <helder@sencha.com>
Reviewed by Darin Adler.
Philip Canvas test 2d.pattern.image.incomplete fails
https://bugs.webkit.org/show_bug.cgi?id=49230
Modidy test to correctly follow the spec and create an image object
with its complete attribute set to false. See also:
https://bugs.webkit.org/show_bug.cgi?id=48306
- canvas/philip/tests/2d.pattern.image.incomplete.html:
- platform/gtk/Skipped:
- platform/mac-leopard/Skipped:
- platform/mac-snowleopard/canvas/philip/tests/2d.pattern.image.incomplete-expected.txt: Removed.
- platform/qt/Skipped:
- 9:24 PM Changeset in webkit [71717] by
-
- 4 edits in trunk/WebCore
2010-11-09 Nico Weber <thakis@chromium.org>
Reviewed by Kenneth Russell.
[Chromium] Text jitter during 2D CSS transform
https://bugs.webkit.org/show_bug.cgi?id=49224
Text subpixel rendering only works in AlphaPremultipliedFirst |
kCGBitmapByteOrder32Host contexts:
http://www.cocoabuilder.com/archive/cocoa/228931-sub-pixel-font-smoothing-with-cgbitmapcontext.html
Changing this has the added benefit that the data layout now matches
skia.
- platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::SharedValues::SharedValues): (WebCore::ContentLayerChromium::updateContents):
- platform/graphics/chromium/ImageLayerChromium.cpp: (WebCore::ImageLayerChromium::updateContents):
- platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::setRootLayerCanvasSize):
- 9:06 PM Changeset in webkit [71716] by
-
- 6 edits in trunk
2010-11-09 Helder Correia <helder@sencha.com>
Reviewed by Darin Adler.
Philip Canvas test 2d.path.rect.winding fails
https://bugs.webkit.org/show_bug.cgi?id=49225
Remove test from skipped list.
- platform/gtk/Skipped:
- platform/mac-leopard/Skipped:
- platform/qt/Skipped:
2010-11-09 Helder Correia <helder@sencha.com>
Reviewed by Darin Adler.
Philip Canvas test 2d.path.rect.winding fails
https://bugs.webkit.org/show_bug.cgi?id=49225
Rect path direction is important for nonzero winding rule.
The rect(x, y, w, h) method must create a new subpath containing just the four points
(x, y), (x+w, y), (x+w, y+h), (x, y+h), with those four points connected by straight
lines, and must then mark the subpath as closed.
- html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::rect):
- 8:59 PM Changeset in webkit [71715] by
-
- 2 edits in trunk/WebCore
Unreviewed build fix on Chromium/Win at r71711
RefCound.h reported an error that it cannot access private member
declared in class 'WebCore::FileWriterSync' at
WebCore::FileWriterSync::~FileWriterSync.
- fileapi/FileWriterSync.h: make destructor public
- 8:48 PM Changeset in webkit [71714] by
-
- 2 edits in trunk/WebCore
2010-11-09 Chris Rogers <crogers@google.com>
Reviewed by James Robinson.
AudioFileReaderMac.cpp must include <CoreServices/CoreServices.h>
https://bugs.webkit.org/show_bug.cgi?id=49270
- platform/audio/mac/AudioFileReaderMac.cpp:
- 8:23 PM Changeset in webkit [71713] by
-
- 1 edit2 deletes in trunk/LayoutTests
2010-11-09 Adrienne Walker <enne@google.com>
Reviewed by Kenneth Russell.
Removing context-attributes.html webgl test as it is now redundant.
https://bugs.webkit.org/show_bug.cgi?id=47111
- fast/canvas/webgl/context-attributes-expected.txt: Removed.
- fast/canvas/webgl/context-attributes.html: Removed.
- 8:20 PM Changeset in webkit [71712] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, updating Chromium expectations
- platform/chromium/test_expectations.txt:
- 8:02 PM Changeset in webkit [71711] by
-
- 10 edits3 adds in trunk/WebCore
2010-11-09 Eric Uhrhane <ericu@chromium.org>
Reviewed by David Levin.
Add idl and mock classes for FileWriterSync.
https://bugs.webkit.org/show_bug.cgi?id=48693
No new tests, as there's no functionality.
Build file additions.
- CMakeLists.txt:
- DerivedSources.cpp:
- DerivedSources.make:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/scripts/CodeGeneratorV8.pm:
- fileapi/FileWriterSync.cpp: Added.
- fileapi/FileWriterSync.h: Added.
- fileapi/FileWriterSync.idl: Added.
- 7:44 PM Changeset in webkit [71710] by
-
- 2 edits in trunk/WebCore
2010-11-09 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Chris Fleizach.
[GTK] Improve accessibility of focusable lists
https://bugs.webkit.org/show_bug.cgi?id=25679
Emit the 'selected' and 'focused' events as needed.
This is the last bit of a series of patches to fix bug 25679,
which just ensures that the right signals are emmited whenever a
selection inside a listbox object changes, that is, the signals
'state-changed::selected', 'state-changed::focused' and
'focus-event', along with the right detail for each of them to
report if the focus/selection has been activated or not.
- accessibility/gtk/AXObjectCacheAtk.cpp: (WebCore::notifyChildrenSelectionChange): New, takes care of emitting all the needed signals when children selection has changed, both from the point of view of the container and the selected/unselected items inside of it. It currently supports listboxes (html 'select' controls) only. (WebCore::AXObjectCache::postPlatformNotification): Replaced some old code with a simple call to notifyChildrenSelectionChange().
- 7:10 PM Changeset in webkit [71709] by
-
- 6 edits8 adds in trunk/LayoutTests
2010-11-09 Ryosuke Niwa <rniwa@webkit.org>
Yet another unreviewed Chromium rebaselines for r71465.
- platform/chromium-mac/fast/blockflow/border-radius-clipping-vertical-lr-expected.checksum:
- platform/chromium-mac/fast/blockflow/border-radius-clipping-vertical-lr-expected.png: Added.
- platform/chromium-mac/fast/blockflow/border-vertical-lr-expected.checksum:
- platform/chromium-mac/fast/blockflow/border-vertical-lr-expected.png: Added.
- platform/chromium-mac/fast/blockflow/box-shadow-vertical-lr-expected.checksum:
- platform/chromium-mac/fast/blockflow/box-shadow-vertical-lr-expected.png: Added.
- platform/chromium-mac/fast/blockflow/japanese-lr-selection-expected.checksum: Added.
- platform/chromium-mac/fast/blockflow/japanese-lr-selection-expected.png: Added.
- platform/chromium-mac/fast/blockflow/japanese-lr-text-expected.checksum:
- platform/chromium-mac/fast/blockflow/japanese-lr-text-expected.png: Added.
- platform/chromium-mac/fast/blockflow/japanese-rl-selection-expected.checksum: Added.
- platform/chromium-mac/fast/blockflow/japanese-rl-selection-expected.png: Added.
- platform/chromium/test_expectations.txt:
- 6:51 PM Changeset in webkit [71708] by
-
- 9 edits48 adds in trunk/LayoutTests
2010-11-09 Mihai Parparita <mihaip@chromium.org>
Unreviewed Chromium rebaseline.
Add missing Linux and Windows baselines for the tests added by r71700.
Also update baselines for editing/selection/extend-by-word-002.html
and fast/lists/markers-in-selection-expected.html.
- platform/chromium-linux/editing/selection/extend-by-word-002-expected.checksum:
- platform/chromium-linux/editing/selection/extend-by-word-002-expected.png:
- platform/chromium-linux/fast/lists/001-vertical-expected.checksum: Added.
- platform/chromium-linux/fast/lists/001-vertical-expected.png: Added.
- platform/chromium-linux/fast/lists/001-vertical-expected.txt: Added.
- platform/chromium-linux/fast/lists/002-vertical-expected.checksum: Added.
- platform/chromium-linux/fast/lists/002-vertical-expected.png: Added.
- platform/chromium-linux/fast/lists/002-vertical-expected.txt: Added.
- platform/chromium-linux/fast/lists/003-vertical-expected.checksum: Added.
- platform/chromium-linux/fast/lists/003-vertical-expected.png: Added.
- platform/chromium-linux/fast/lists/003-vertical-expected.txt: Added.
- platform/chromium-linux/fast/lists/005-vertical-expected.checksum: Added.
- platform/chromium-linux/fast/lists/005-vertical-expected.png: Added.
- platform/chromium-linux/fast/lists/005-vertical-expected.txt: Added.
- platform/chromium-linux/fast/lists/006-vertical-expected.checksum: Added.
- platform/chromium-linux/fast/lists/006-vertical-expected.png: Added.
- platform/chromium-linux/fast/lists/006-vertical-expected.txt: Added.
- platform/chromium-linux/fast/lists/007-vertical-expected.checksum: Added.
- platform/chromium-linux/fast/lists/007-vertical-expected.png: Added.
- platform/chromium-linux/fast/lists/007-vertical-expected.txt: Added.
- platform/chromium-linux/fast/lists/008-vertical-expected.checksum: Added.
- platform/chromium-linux/fast/lists/008-vertical-expected.png: Added.
- platform/chromium-linux/fast/lists/008-vertical-expected.txt: Added.
- platform/chromium-linux/fast/lists/009-vertical-expected.checksum: Added.
- platform/chromium-linux/fast/lists/009-vertical-expected.png: Added.
- platform/chromium-linux/fast/lists/009-vertical-expected.txt: Added.
- platform/chromium-linux/fast/lists/markers-in-selection-expected.checksum:
- platform/chromium-linux/fast/lists/markers-in-selection-expected.png:
- platform/chromium-win/editing/selection/extend-by-word-002-expected.checksum:
- platform/chromium-win/editing/selection/extend-by-word-002-expected.png:
- platform/chromium-win/fast/lists/001-vertical-expected.checksum: Added.
- platform/chromium-win/fast/lists/001-vertical-expected.png: Added.
- platform/chromium-win/fast/lists/001-vertical-expected.txt: Added.
- platform/chromium-win/fast/lists/002-vertical-expected.checksum: Added.
- platform/chromium-win/fast/lists/002-vertical-expected.png: Added.
- platform/chromium-win/fast/lists/002-vertical-expected.txt: Added.
- platform/chromium-win/fast/lists/003-vertical-expected.checksum: Added.
- platform/chromium-win/fast/lists/003-vertical-expected.png: Added.
- platform/chromium-win/fast/lists/003-vertical-expected.txt: Added.
- platform/chromium-win/fast/lists/005-vertical-expected.checksum: Added.
- platform/chromium-win/fast/lists/005-vertical-expected.png: Added.
- platform/chromium-win/fast/lists/005-vertical-expected.txt: Added.
- platform/chromium-win/fast/lists/006-vertical-expected.checksum: Added.
- platform/chromium-win/fast/lists/006-vertical-expected.png: Added.
- platform/chromium-win/fast/lists/006-vertical-expected.txt: Added.
- platform/chromium-win/fast/lists/007-vertical-expected.checksum: Added.
- platform/chromium-win/fast/lists/007-vertical-expected.png: Added.
- platform/chromium-win/fast/lists/007-vertical-expected.txt: Added.
- platform/chromium-win/fast/lists/008-vertical-expected.checksum: Added.
- platform/chromium-win/fast/lists/008-vertical-expected.png: Added.
- platform/chromium-win/fast/lists/008-vertical-expected.txt: Added.
- platform/chromium-win/fast/lists/009-vertical-expected.checksum: Added.
- platform/chromium-win/fast/lists/009-vertical-expected.png: Added.
- platform/chromium-win/fast/lists/009-vertical-expected.txt: Added.
- platform/chromium-win/fast/lists/markers-in-selection-expected.checksum:
- platform/chromium-win/fast/lists/markers-in-selection-expected.png:
- 6:35 PM Changeset in webkit [71707] by
-
- 2 edits in trunk/LayoutTests
2010-11-09 Xiaomei Ji <xji@chromium.org>
Reviewed by NOBODY.
Skip bidi-control-chars-treated-as-ZWS.html in leopard while investigating
bug 49295 -- Regression in ATSUI handling.
- platform/mac-leopard/Skipped:
- 6:33 PM Changeset in webkit [71706] by
-
- 2 edits in trunk/LayoutTests
2010-11-09 Xiaomei Ji <xji@chromium.org>
Reviewed by NOBODY.
Rebaseline for leopard after r71566.
- platform/mac-leopard/fast/text/international/bidi-neutral-run-expected.txt:
- 6:26 PM Changeset in webkit [71705] by
-
- 3 edits in trunk/WebKit/chromium
2010-11-09 Kenneth Russell <kbr@google.com>
Reviewed by James Robinson.
WebGraphicsContext3DDefaultImpl does not run on top of OpenGL ES 2.0 implementations
https://bugs.webkit.org/show_bug.cgi?id=48282
Fixed assumptions in WebGraphicsContext3DDefaultImpl that it was
running on top of desktop GL.
Tested various WebGL demos on Windows with ANGLE and
--in-process-webgl --disable-accelerated-compositing; all are now
working. Verified that --use-gl=desktop continues to work in the
same configuration.
- src/WebGraphicsContext3DDefaultImpl.cpp: (WebKit::WebGraphicsContext3DDefaultImpl::WebGraphicsContext3DDefaultImpl): (WebKit::WebGraphicsContext3DDefaultImpl::initialize): (WebKit::WebGraphicsContext3DDefaultImpl::validateAttributes): (WebKit::WebGraphicsContext3DDefaultImpl::resolveMultisampledFramebuffer): (WebKit::WebGraphicsContext3DDefaultImpl::isGLES2Compliant): (WebKit::WebGraphicsContext3DDefaultImpl::reshape): (WebKit::WebGraphicsContext3DDefaultImpl::readBackFramebuffer): (WebKit::WebGraphicsContext3DDefaultImpl::getIntegerv): (WebKit::WebGraphicsContext3DDefaultImpl::angleValidateShaderSource):
- src/WebGraphicsContext3DDefaultImpl.h:
- 6:24 PM Changeset in webkit [71704] by
-
- 2 edits83 adds in trunk/LayoutTests
2010-11-09 Mihai Parparita <mihaip@chromium.org>
Unreviewed Chromium rebaseline.
Add missing Linux and Windows baselines for the tests added by r71382.
- platform/chromium-linux/fast/table/027-vertical-expected.checksum: Added.
- platform/chromium-linux/fast/table/027-vertical-expected.png: Added.
- platform/chromium-linux/fast/table/028-vertical-expected.checksum: Added.
- platform/chromium-linux/fast/table/028-vertical-expected.png: Added.
- platform/chromium-linux/fast/table/035-vertical-expected.checksum: Added.
- platform/chromium-linux/fast/table/035-vertical-expected.png: Added.
- platform/chromium-linux/fast/table/038-vertical-expected.checksum: Added.
- platform/chromium-linux/fast/table/038-vertical-expected.png: Added.
- platform/chromium-linux/fast/table/040-vertical-expected.checksum: Added.
- platform/chromium-linux/fast/table/040-vertical-expected.png: Added.
- platform/chromium-linux/fast/table/auto-with-percent-height-vertical-expected.checksum: Added.
- platform/chromium-linux/fast/table/auto-with-percent-height-vertical-expected.png: Added.
- platform/chromium-linux/fast/table/border-collapsing/001-vertical-expected.checksum: Added.
- platform/chromium-linux/fast/table/border-collapsing/001-vertical-expected.png: Added.
- platform/chromium-linux/fast/table/border-collapsing/002-vertical-expected.checksum: Added.
- platform/chromium-linux/fast/table/border-collapsing/002-vertical-expected.png: Added.
- platform/chromium-linux/fast/table/border-collapsing/003-vertical-expected.checksum: Added.
- platform/chromium-linux/fast/table/border-collapsing/003-vertical-expected.png: Added.
- platform/chromium-linux/fast/table/border-collapsing/004-vertical-expected.checksum: Added.
- platform/chromium-linux/fast/table/border-collapsing/004-vertical-expected.png: Added.
- platform/chromium-linux/fast/table/border-collapsing/border-collapsing-head-foot-vertical-expected.checksum: Added.
- platform/chromium-linux/fast/table/border-collapsing/border-collapsing-head-foot-vertical-expected.png: Added.
- platform/chromium-linux/fast/table/border-collapsing/equal-precedence-resolution-vertical-expected.checksum: Added.
- platform/chromium-linux/fast/table/border-collapsing/equal-precedence-resolution-vertical-expected.png: Added.
- platform/chromium-linux/fast/table/border-collapsing/rtl-border-collapsing-vertical-expected.checksum: Added.
- platform/chromium-linux/fast/table/border-collapsing/rtl-border-collapsing-vertical-expected.png: Added.
- platform/chromium-linux/fast/table/colspanMinWidth-vertical-expected.checksum: Added.
- platform/chromium-linux/fast/table/colspanMinWidth-vertical-expected.png: Added.
- platform/chromium-linux/fast/table/height-percent-test-vertical-expected.checksum: Added.
- platform/chromium-linux/fast/table/height-percent-test-vertical-expected.png: Added.
- platform/chromium-linux/fast/table/rowspan-paint-order-vertical-expected.checksum: Added.
- platform/chromium-linux/fast/table/rowspan-paint-order-vertical-expected.png: Added.
- platform/chromium-linux/fast/table/table-display-types-vertical-expected.checksum: Added.
- platform/chromium-linux/fast/table/table-display-types-vertical-expected.png: Added.
- platform/chromium-win/fast/table/027-vertical-expected.checksum: Added.
- platform/chromium-win/fast/table/027-vertical-expected.png: Added.
- platform/chromium-win/fast/table/027-vertical-expected.txt: Added.
- platform/chromium-win/fast/table/028-vertical-expected.checksum: Added.
- platform/chromium-win/fast/table/028-vertical-expected.png: Added.
- platform/chromium-win/fast/table/028-vertical-expected.txt: Added.
- platform/chromium-win/fast/table/035-vertical-expected.checksum: Added.
- platform/chromium-win/fast/table/035-vertical-expected.png: Added.
- platform/chromium-win/fast/table/035-vertical-expected.txt: Added.
- platform/chromium-win/fast/table/038-vertical-expected.checksum: Added.
- platform/chromium-win/fast/table/038-vertical-expected.png: Added.
- platform/chromium-win/fast/table/038-vertical-expected.txt: Added.
- platform/chromium-win/fast/table/040-vertical-expected.checksum: Added.
- platform/chromium-win/fast/table/040-vertical-expected.png: Added.
- platform/chromium-win/fast/table/040-vertical-expected.txt: Added.
- platform/chromium-win/fast/table/auto-with-percent-height-vertical-expected.checksum: Added.
- platform/chromium-win/fast/table/auto-with-percent-height-vertical-expected.png: Added.
- platform/chromium-win/fast/table/auto-with-percent-height-vertical-expected.txt: Added.
- platform/chromium-win/fast/table/border-collapsing/001-vertical-expected.checksum: Added.
- platform/chromium-win/fast/table/border-collapsing/001-vertical-expected.png: Added.
- platform/chromium-win/fast/table/border-collapsing/001-vertical-expected.txt: Added.
- platform/chromium-win/fast/table/border-collapsing/002-vertical-expected.checksum: Added.
- platform/chromium-win/fast/table/border-collapsing/002-vertical-expected.png: Added.
- platform/chromium-win/fast/table/border-collapsing/002-vertical-expected.txt: Added.
- platform/chromium-win/fast/table/border-collapsing/003-vertical-expected.checksum: Added.
- platform/chromium-win/fast/table/border-collapsing/003-vertical-expected.png: Added.
- platform/chromium-win/fast/table/border-collapsing/003-vertical-expected.txt: Added.
- platform/chromium-win/fast/table/border-collapsing/004-vertical-expected.checksum: Added.
- platform/chromium-win/fast/table/border-collapsing/004-vertical-expected.png: Added.
- platform/chromium-win/fast/table/border-collapsing/004-vertical-expected.txt: Added.
- platform/chromium-win/fast/table/border-collapsing/border-collapsing-head-foot-vertical-expected.checksum: Added.
- platform/chromium-win/fast/table/border-collapsing/border-collapsing-head-foot-vertical-expected.png: Added.
- platform/chromium-win/fast/table/border-collapsing/border-collapsing-head-foot-vertical-expected.txt: Added.
- platform/chromium-win/fast/table/border-collapsing/equal-precedence-resolution-vertical-expected.checksum: Added.
- platform/chromium-win/fast/table/border-collapsing/equal-precedence-resolution-vertical-expected.png: Added.
- platform/chromium-win/fast/table/border-collapsing/rtl-border-collapsing-vertical-expected.checksum: Added.
- platform/chromium-win/fast/table/border-collapsing/rtl-border-collapsing-vertical-expected.png: Added.
- platform/chromium-win/fast/table/border-collapsing/rtl-border-collapsing-vertical-expected.txt: Added.
- platform/chromium-win/fast/table/colspanMinWidth-vertical-expected.checksum: Added.
- platform/chromium-win/fast/table/colspanMinWidth-vertical-expected.png: Added.
- platform/chromium-win/fast/table/colspanMinWidth-vertical-expected.txt: Added.
- platform/chromium-win/fast/table/height-percent-test-vertical-expected.checksum: Added.
- platform/chromium-win/fast/table/height-percent-test-vertical-expected.png: Added.
- platform/chromium-win/fast/table/rowspan-paint-order-vertical-expected.checksum: Added.
- platform/chromium-win/fast/table/rowspan-paint-order-vertical-expected.png: Added.
- platform/chromium-win/fast/table/rowspan-paint-order-vertical-expected.txt: Added.
- platform/chromium-win/fast/table/table-display-types-vertical-expected.checksum: Added.
- platform/chromium-win/fast/table/table-display-types-vertical-expected.png: Added.
- platform/chromium-win/fast/table/table-display-types-vertical-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- 6:22 PM Changeset in webkit [71703] by
-
- 2 edits32 adds in trunk/LayoutTests
2010-11-09 Ryosuke Niwa <rniwa@webkit.org>
Unreviewed Chromium rebaselines.
- platform/chromium-mac/editing/deleting/delete-after-span-ws-001-expected.checksum: Added.
- platform/chromium-mac/editing/deleting/delete-after-span-ws-001-expected.png: Added.
- platform/chromium-mac/editing/deleting/delete-after-span-ws-002-expected.checksum: Added.
- platform/chromium-mac/editing/deleting/delete-after-span-ws-002-expected.png: Added.
- platform/chromium-mac/editing/deleting/delete-after-span-ws-003-expected.checksum: Added.
- platform/chromium-mac/editing/deleting/delete-after-span-ws-003-expected.png: Added.
- platform/chromium-mac/editing/deleting/delete-line-end-ws-001-expected.checksum: Added.
- platform/chromium-mac/editing/deleting/delete-line-end-ws-001-expected.png: Added.
- platform/chromium-mac/editing/deleting/delete-line-end-ws-002-expected.checksum: Added.
- platform/chromium-mac/editing/deleting/delete-line-end-ws-002-expected.png: Added.
- platform/chromium-mac/editing/inserting/insert-div-023-expected.checksum: Added.
- platform/chromium-mac/editing/inserting/insert-div-023-expected.png: Added.
- platform/chromium-mac/editing/selection/focus_editable_html-expected.checksum: Added.
- platform/chromium-mac/editing/selection/focus_editable_html-expected.png: Added.
- platform/chromium-mac/editing/selection/iframe-expected.checksum: Added.
- platform/chromium-mac/editing/selection/iframe-expected.png: Added.
- platform/chromium-mac/editing/selection/select-all-001-expected.checksum: Added.
- platform/chromium-mac/editing/selection/select-all-001-expected.png: Added.
- platform/chromium-mac/editing/selection/select-all-002-expected.checksum: Added.
- platform/chromium-mac/editing/selection/select-all-002-expected.png: Added.
- platform/chromium-mac/editing/selection/select-all-003-expected.checksum: Added.
- platform/chromium-mac/editing/selection/select-all-003-expected.png: Added.
- platform/chromium-mac/editing/selection/select-all-004-expected.checksum: Added.
- platform/chromium-mac/editing/selection/select-all-004-expected.png: Added.
- platform/chromium-mac/editing/selection/unrendered-001-expected.checksum: Added.
- platform/chromium-mac/editing/selection/unrendered-001-expected.png: Added.
- platform/chromium-mac/editing/selection/unrendered-003-expected.checksum: Added.
- platform/chromium-mac/editing/selection/unrendered-003-expected.png: Added.
- platform/chromium-mac/editing/selection/unrendered-004-expected.checksum: Added.
- platform/chromium-mac/editing/selection/unrendered-004-expected.png: Added.
- platform/chromium-mac/editing/selection/unrendered-005-expected.checksum: Added.
- platform/chromium-mac/editing/selection/unrendered-005-expected.png: Added.
- platform/chromium/test_expectations.txt:
- 6:09 PM Changeset in webkit [71702] by
-
- 2 edits in trunk/LayoutTests
2010-11-09 Ryosuke Niwa <rniwa@webkit.org>
Unreviewed Chromium test expectations update.
Skip platform/mac/editing/deleting/backward-delete.html.
- platform/chromium/test_expectations.txt:
- 6:07 PM Changeset in webkit [71701] by
-
- 2 edits in trunk/LayoutTests
2010-11-09 Mihai Parparita <mihaip@chromium.org>
Unreviewed Chromium test_expectations.txt update.
svg/animations/animate-path-nested-transforms.html is flaky on all
platforms.
- platform/chromium/test_expectations.txt:
- 5:46 PM Changeset in webkit [71700] by
-
- 16 edits32 adds in trunk
https://bugs.webkit.org/show_bug.cgi?id=49202
Reviewed by Dan Bernstein.
WebCore:
Make lists work with vertical text.
(1) Patch all the CSS rules in html.css so that the margins are directionally abstract.
(2) Add a transposedRect and transposedSize method to IntRect and IntSize for swapping x/y and width/height.
(3) Add adjustLineDirectionPosition as a helper for moving a line box only in the line direction.
(4) Fix a bug in addIntrudingFLoats uncovered by list test cases where the top margin of an element was being
incorrectly added to a float's physical left side instead of its top side.
(5) Make positioning and painting and selection of list markers account for all writing modes.
(6) Add helpers for setting the start and end margins directly in a RenderStyle, since lists do this to hack
marker margins before they have been calculated and set on the box.
Cloned a bunch of fast/lists tests into fast/lists/*-vertical.html versions.
- css/html.css:
- platform/graphics/IntRect.h:
(WebCore::IntRect::transposedRect):
- platform/graphics/IntSize.h:
(WebCore::IntSize::transposedSize):
- rendering/InlineBox.h:
(WebCore::InlineBox::adjustLineDirectionPosition):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::addIntrudingFloats):
- rendering/RenderListItem.cpp:
(WebCore::getParentOfFirstLineBox):
(WebCore::RenderListItem::positionListMarker):
(WebCore::RenderListItem::paint):
- rendering/RenderListMarker.cpp:
(WebCore::RenderListMarker::localSelectionRect):
(WebCore::RenderListMarker::paint):
(WebCore::RenderListMarker::layout):
(WebCore::RenderListMarker::computePreferredLogicalWidths):
(WebCore::RenderListMarker::updateMargins):
(WebCore::RenderListMarker::getRelativeMarkerRect):
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::setMarginStart):
(WebCore::RenderStyle::setMarginEnd):
- rendering/style/RenderStyle.h:
LayoutTests:
Make lists work with vertical text.
(1) Patch all the CSS rules in html.css so that the margins are directionally abstract.
(2) Add a transposedRect and transposedSize method to IntRect and IntSize for swapping x/y and width/height.
(3) Add adjustLineDirectionPosition as a helper for moving a line box only in the line direction.
(4) Fix a bug in addIntrudingFLoats uncovered by list test cases where the top margin of an element was being
incorrectly added to a float's physical left side instead of its top side.
(5) Make positioning and painting and selection of list markers account for all writing modes.
(6) Add helpers for setting the start and end margins directly in a RenderStyle, since lists do this to hack
marker margins before they have been calculated and set on the box.
Cloned a bunch of fast/lists tests into fast/lists/*-vertical.html versions.
- fast/lists/001-vertical.html: Added.
- fast/lists/002-vertical.html: Added.
- fast/lists/003-vertical.html: Added.
- fast/lists/005-vertical.html: Added.
- fast/lists/006-vertical.html: Added.
- fast/lists/007-vertical.html: Added.
- fast/lists/008-vertical.html: Added.
- fast/lists/009-vertical.html: Added.
- platform/mac/fast/lists/001-vertical-expected.checksum: Added.
- platform/mac/fast/lists/001-vertical-expected.png: Added.
- platform/mac/fast/lists/001-vertical-expected.txt: Added.
- platform/mac/fast/lists/002-vertical-expected.checksum: Added.
- platform/mac/fast/lists/002-vertical-expected.png: Added.
- platform/mac/fast/lists/002-vertical-expected.txt: Added.
- platform/mac/fast/lists/003-vertical-expected.checksum: Added.
- platform/mac/fast/lists/003-vertical-expected.png: Added.
- platform/mac/fast/lists/003-vertical-expected.txt: Added.
- platform/mac/fast/lists/005-vertical-expected.checksum: Added.
- platform/mac/fast/lists/005-vertical-expected.png: Added.
- platform/mac/fast/lists/005-vertical-expected.txt: Added.
- platform/mac/fast/lists/006-vertical-expected.checksum: Added.
- platform/mac/fast/lists/006-vertical-expected.png: Added.
- platform/mac/fast/lists/006-vertical-expected.txt: Added.
- platform/mac/fast/lists/007-vertical-expected.checksum: Added.
- platform/mac/fast/lists/007-vertical-expected.png: Added.
- platform/mac/fast/lists/007-vertical-expected.txt: Added.
- platform/mac/fast/lists/008-vertical-expected.checksum: Added.
- platform/mac/fast/lists/008-vertical-expected.png: Added.
- platform/mac/fast/lists/008-vertical-expected.txt: Added.
- platform/mac/fast/lists/009-vertical-expected.checksum: Added.
- platform/mac/fast/lists/009-vertical-expected.png: Added.
- platform/mac/fast/lists/009-vertical-expected.txt: Added.
- platform/mac/fast/lists/inlineBoxWrapperNullCheck-expected.png:
- platform/mac/fast/lists/markers-in-selection-expected.checksum:
- platform/mac/fast/lists/markers-in-selection-expected.png:
- platform/mac/fast/lists/ol-start-parsing-expected.checksum:
- platform/mac/fast/lists/ol-start-parsing-expected.png:
- 4:46 PM Changeset in webkit [71699] by
-
- 2 edits in trunk/WebKitTools
2010-11-09 Mihai Parparita <mihaip@chromium.org>
Reviewed by Tony Chang.
[Chromium] http/tests/security/XFrameOptions fail with Chromium DRT
https://bugs.webkit.org/show_bug.cgi?id=49286
The tests in http/tests/security/XFrameOptions started to fail after
r71297, since it changed the WebViewHost::assignIdentifierToRequest
logic to always assign identifiers to requests, even if we're not going
to be dumping resource load callbacks at that point. These tests
only call LayoutTestController.dumpResourceLoadCallbacks after the
request is started, thus their expectations have "<unknown>" as the
identifier. Change WebViewHost to the previous behavior, which also
match the other ports'.
- DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::assignIdentifierToRequest): (WebViewHost::removeIdentifierForRequest):
- 4:40 PM Changeset in webkit [71698] by
-
- 2 edits in trunk/LayoutTests
2010-11-09 Mihai Parparita <mihaip@chromium.org>
Unreviewed Chromium test_expectations.txt update.
- fast/images/gif-loop-count.html fails on other platforms too (not just on Windows)
- svg/animations/animate-path-nested-transforms.html also has text diffs
- 4:23 PM Changeset in webkit [71697] by
-
- 2 edits in trunk/WebKit2
Windows build bot was complaining about this.
Reviewed by the ever-picky Windows build-bot.
- Shared/WebContextMenuItemData.cpp:
(WebKit::WebContextMenuItemData::core):
- 4:22 PM Changeset in webkit [71696] by
-
- 2 edits in trunk/LayoutTests
2010-11-09 Tony Chang <tony@chromium.org>
Unreviewed. I updated and moved this test so the Skipped
entry is no longer needed.
- platform/gtk/Skipped: remove fast/js/navigator-mimeTypes-length.html
- 4:19 PM Changeset in webkit [71695] by
-
- 2 edits in trunk/WebKit2
WKDownload.h should be a public header.
Reviewed by John Sullivan.
- WebKit2.xcodeproj/project.pbxproj:
- 4:17 PM Changeset in webkit [71694] by
-
- 1 edit2 copies in branches/chromium/552
Merge 71686
BUG=62401
- 4:12 PM Changeset in webkit [71693] by
-
- 1 edit in branches/chromium/552/WebCore/editing/ApplyStyleCommand.h
Fix Compile for Merge 71288
BUG=61158
- 3:56 PM Changeset in webkit [71692] by
-
- 4 edits in branches/chromium/552
Merge 71431 - 2010-11-05 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
Crash in ApplyStyleCommand::surroundNodeRangeWithElement
https://bugs.webkit.org/show_bug.cgi?id=48581
The crash was caused by a false assertion that we can always recover selection in
ApplyStyleCommand::removeInlineStyle. Fixed the crash by removing the assertion
and adding an early exit to the call site. Also converted raw pointers to RefPtr
in surroundNodeRangeWithElement and addInlineStyleIfNeeded.
Test (non-Mac platforms): editing/style/iframe-onload-crash.html
- editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyInlineStyle): (WebCore::ApplyStyleCommand::removeInlineStyle): (WebCore::ApplyStyleCommand::surroundNodeRangeWithElement): (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded):
- editing/ApplyStyleCommand.h:
2010-11-04 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
Re-enabled editing/style/iframe-onload-crash.html on Chromium, Qt, and Windows platforms.
- platform/chromium/test_expectations.txt:
- platform/qt/Skipped:
- platform/win/Skipped:
- 3:36 PM Changeset in webkit [71691] by
-
- 5 edits in trunk/JavaScriptCore
<http://webkit.org/b/49279> Fix include statements for local headers
Reviewed by Gavin Barraclough.
Use "Foo.h" instead of <Foo.h> for local headers.
- assembler/AbstractMacroAssembler.h: Also fixed sort order.
- assembler/CodeLocation.h:
- yarr/RegexJIT.h:
- yarr/RegexParser.h:
- 3:34 PM Changeset in webkit [71690] by
-
- 3 edits in trunk/LayoutTests
2010-11-09 Mihai Parparita <mihaip@chromium.org>
Unreviewed Chromium test expectations update.
More correct expectations for editing/selection/extend-selection.html:
it's just slow, especially for debug builds.
- platform/chromium/drt_expectations.txt:
- platform/chromium/test_expectations.txt:
- 3:33 PM Changeset in webkit [71689] by
-
- 5 edits2 copies in branches/chromium/552
Merge 71288 - 2010-11-01 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
Crash in ApplyStyleCommand::removeStyleFromRunBeforeApplyingStyle
https://bugs.webkit.org/show_bug.cgi?id=48581
The crash was caused by RemoveNodePreservingChildrenCommand's calling removeNode
on m_node without checking that m_node has a parent and it's still in the document.
Fixed the crash by adding an early exit in CompositeEditCommand::removeNode and
deploying RefPtr in several places of ApplyStyleCommand.cpp.
Test: editing/style/iframe-onload-crash.html
- editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyInlineStyleToNodeRange): (WebCore::ApplyStyleCommand::removeStyleFromRunBeforeApplyingStyle): (WebCore::ApplyStyleCommand::removeInlineStyleFromElement):
- editing/ApplyStyleCommand.h:
- editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::removeNode):
2010-10-29 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
Crash in ApplyStyleCommand::removeStyleFromRunBeforeApplyingStyle
https://bugs.webkit.org/show_bug.cgi?id=48581
Added a test to ensure removeStyleFromRunBeforeApplyingStyle doesn't crash.
- editing/style/iframe-onload-crash-expected.txt: Added.
- editing/style/iframe-onload-crash.html: Added.
- 3:29 PM Changeset in webkit [71688] by
-
- 4 edits in trunk/WebKit/chromium
2010-11-09 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
[Chromium] Add form validation message support to WebLocalizedString.h
https://bugs.webkit.org/show_bug.cgi?id=49239
- DEPS: Roll Chromium revision to r65502 to have crrev.com/65502
- public/WebLocalizedString.h: Add new symbols
- src/LocalizedStrings.cpp: Call query() with the new symbols in the following functions. (WebCore::validationMessageValueMissingText): (WebCore::validationMessageTypeMismatchText): (WebCore::validationMessagePatternMismatchText): (WebCore::validationMessageTooLongText): (WebCore::validationMessageRangeUnderflowText): (WebCore::validationMessageRangeOverflowText): (WebCore::validationMessageStepMismatchText):
- 3:23 PM Changeset in webkit [71687] by
-
- 2 edits in trunk/LayoutTests
2010-11-09 Tony Chang <tony@chromium.org>
Unreviewed, update drt_expectations after recent plugin test moves
and fixes.
- platform/chromium/drt_expectations.txt:
- 3:21 PM Changeset in webkit [71686] by
-
- 3 edits2 adds in trunk
2010-11-09 Abhishek Arya <inferno@chromium.org>
Reviewed by Antti Koivisto.
Call to SVGSMILElement::applyResultsToTarget can blow away the SVGSMILElement.
Refptr the SVGSMILElement in the ResultElementMap to protect it.
https://bugs.webkit.org/show_bug.cgi?id=49274
Test: svg/animations/animate-update-crash.xhtml
- svg/animation/SMILTimeContainer.cpp: (WebCore::SMILTimeContainer::updateAnimations):
2010-11-09 Abhishek Arya <inferno@chromium.org>
Reviewed by Antti Koivisto.
Tests that updating svg animations does not result in crash.
https://bugs.webkit.org/show_bug.cgi?id=49274
- svg/animations/animate-update-crash-expected.txt: Added.
- svg/animations/animate-update-crash.xhtml: Added.
- 3:19 PM Changeset in webkit [71685] by
-
- 12 edits2 adds in trunk/WebKit2
Add injected bundle API for creating page overlays
https://bugs.webkit.org/show_bug.cgi?id=49282
Reviewed by Sam Weinig.
- Shared/API/c/WKBase.h:
Add WKBundlePageOverlayRef.
- Shared/APIObject.h:
Add TypeBundlePageOverlay.
- WebKit2.pro:
- WebKit2.xcodeproj/project.pbxproj:
Add new files.
- WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:
Add WKBundlePageOverlayRef mapping.
- WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageInstallPageOverlay):
Install the passed in page overlay.
(WKBundlePageUninstallPageOverlay):
Uninstall the passed in page overlay.
- WebProcess/InjectedBundle/API/c/WKBundlePageOverlay.cpp: Added.
(PageOverlayClientImpl::create):
(PageOverlayClientImpl::PageOverlayClientImpl):
(PageOverlayClientImpl::pageOverlayDestroyed):
(PageOverlayClientImpl::willMoveToWebPage):
(PageOverlayClientImpl::didMoveToWebPage):
(PageOverlayClientImpl::drawRect):
(PageOverlayClientImpl::mouseEvent):
Add a PageOverlay::Client subclass that forwards everything to its client.
(WKBundlePageOverlayGetTypeID):
(WKBundlePageOverlayCreate):
Create a page overlay.
- WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::pageOverlayDestroyed):
- WebProcess/WebPage/FindController.h:
Add stub.
- WebProcess/WebPage/PageOverlay.h:
Inherit from APIObject.
(WebKit::PageOverlay::type):
return TypeBundlePageOverlay.
- win/WebKit2.vcproj:
Add new files.
- 3:09 PM Changeset in webkit [71684] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=49281
Remove broken code for embedded CSS xml-stylesheet
- dom/Document.cpp: (WebCore::Document::recalcStyleSelector): This made no sense, was untested, and didn't match Firefox.
- 3:07 PM Changeset in webkit [71683] by
-
- 3 edits in trunk/LayoutTests
2010-11-09 Mihai Parparita <mihaip@chromium.org>
Unreviewed Chromium test expectations update.
editing/selection/extend-selection.html is flaky under test_shell, but
not under DRT.
- platform/chromium/drt_expectations.txt:
- platform/chromium/test_expectations.txt:
- 2:56 PM Changeset in webkit [71682] by
-
- 26 edits4 adds in trunk
WebCore: <rdar://problem/8613727> and https://bugs.webkit.org/show_bug.cgi?id=48720
Customizable context menu support in WebKit2.
Reviewed by Darin Adler.
Various WebCore support to allow WebKit2 to create new ContextMenuItems with
the information it has.
- WebCore.exp.in:
- platform/ContextMenu.h:
- platform/ContextMenuItem.h:
- platform/mac/ContextMenuItemMac.mm:
(WebCore::ContextMenuItem::ContextMenuItem):
(WebCore::ContextMenuItem::setSubMenu):
- platform/mac/ContextMenuMac.mm:
(WebCore::platformMenuDescription):
- platform/qt/ContextMenuItemQt.cpp:
(WebCore::ContextMenuItem::ContextMenuItem):
(WebCore::ContextMenuItem::setSubMenu):
- platform/qt/ContextMenuQt.cpp:
(WebCore::platformMenuDescription):
- platform/win/ContextMenuItemWin.cpp:
(WebCore::ContextMenuItem::ContextMenuItem):
(WebCore::ContextMenuItem::setSubMenu):
- platform/win/ContextMenuWin.cpp:
(WebCore::platformMenuDescription):
WebKit2: Part of <rdar://problem/8613727> and https://bugs.webkit.org/show_bug.cgi?id=48720
Customizable context menu support in WebKit2.
Reviewed by Darin Adler.
This adds a BundlePageContextMenu client and lets WebKit2 consult it with the proposed
list of WebContextMenuItems.
There is no realistic API for the embedding app to actually inspect or create new
WebContextMenuItems (will be "WKContextMenuItem") and that ability will come later.
- WebKit2.pro:
- WebKit2.xcodeproj/project.pbxproj:
- win/WebKit2.vcproj:
- Platform/Logging.cpp:
(initializeLogChannelsIfNecessary):
- Platform/Logging.h:
- Shared/APIObject.h:
- Shared/MutableArray.cpp:
(WebKit::MutableArray::reserveCapacity):
- Shared/MutableArray.h:
- Shared/WebContextMenuItem.cpp: Added.
(WebKit::WebContextMenuItem::WebContextMenuItem):
(WebKit::WebContextMenuItem::data):
- Shared/WebContextMenuItem.h: Added.
(WebKit::WebContextMenuItem::create):
(WebKit::WebContextMenuItem::type):
- Shared/WebContextMenuItemData.cpp:
(WebKit::WebContextMenuItemData::core):
(WebKit::kitItems):
(WebKit::coreItems):
- Shared/WebContextMenuItemData.h:
- WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageSetContextMenuClient):
- WebProcess/InjectedBundle/API/c/WKBundlePage.h:
- WebProcess/InjectedBundle/InjectedBundlePageContextMenuClient.cpp: Added.
(WebKit::InjectedBundlePageContextMenuClient::InjectedBundlePageContextMenuClient):
(WebKit::InjectedBundlePageContextMenuClient::initialize):
(WebKit::InjectedBundlePageContextMenuClient::getCustomMenuFromDefaultItems):
- WebProcess/InjectedBundle/InjectedBundlePageContextMenuClient.h: Added.
- WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
(WebKit::WebContextMenuClient::getCustomMenuFromDefaultItems): Call through to the injected bundle client
with the default items and convert the returned items back for WebCore to use.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::initializeInjectedBundleContextMenuClient):
- WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::injectedBundleContextMenuClient):
- 2:48 PM Changeset in webkit [71681] by
-
- 3 edits2 moves in trunk
2010-11-09 Tony Chang <tony@chromium.org>
Reviewed by Adam Barth.
run platform/chromium/plugins/return-npobject.html on all platforms
https://bugs.webkit.org/show_bug.cgi?id=49103
- plugins/return-npobject-expected.txt: Renamed from LayoutTests/platform/chromium/plugins/return-npobject-expected.txt.
- plugins/return-npobject.html: Renamed from LayoutTests/platform/chromium/plugins/return-npobject.html.
2010-11-08 Tony Chang <tony@chromium.org>
Reviewed by Adam Barth.
run platform/chromium/plugins/return-npobject.html on all platforms
https://bugs.webkit.org/show_bug.cgi?id=49103
This tests that we can get an NPObject returned through a method on
an NPAPI Object.
- DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp: (testCallbackReturn): (pluginInvoke):
- 2:33 PM Changeset in webkit [71680] by
-
- 4 edits in trunk/WebKit2
Add some stylistic flourish to the last patch as suggested by Lord Darin Adler.
- UIProcess/API/C/WKPage.cpp:
(WKPageGetSourceForFrame):
(WKPageGetContentsAsString):
- UIProcess/WebPageProxy.cpp:
(WebKit::invalidateCallbackMap):
- WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::contentsAsString):
- 2:29 PM Changeset in webkit [71679] by
-
- 2 edits2 deletes in trunk/WebKitTools
2010-11-09 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r71672.
http://trac.webkit.org/changeset/71672
https://bugs.webkit.org/show_bug.cgi?id=49276
It doesn't work on Chromium Windows bot (Requested by Ossy on
#webkit).
- Scripts/webkitpy/common/system/file_lock.py: Removed.
- Scripts/webkitpy/common/system/file_lock_unittest.py: Removed.
- Scripts/webkitpy/layout_tests/port/http_lock.py:
- 2:22 PM Changeset in webkit [71678] by
-
- 13 edits in trunk
Need WebKit2 mechanism for getting the visible page text
<rdar://problem/8646928>
https://bugs.webkit.org/show_bug.cgi?id=49275
Reviewed by Anders Carlsson.
WebCore:
- WebCore.exp.in: Add necessary exports.
WebKit2:
- UIProcess/API/C/WKPage.cpp:
(WKPageGetContentsAsString):
(callContentsAsStringBlockBlockAndDispose):
(WKPageGetContentsAsString_b):
- UIProcess/API/C/WKPage.h:
Add GetContentsAsString callback function declaration and forwarding.
- UIProcess/WebPageProxy.cpp:
(WebKit::invalidateCallbackMap):
(WebKit::WebPageProxy::close):
(WebKit::WebPageProxy::getContentsAsString):
(WebKit::WebPageProxy::didGetContentsAsString):
(WebKit::WebPageProxy::processDidCrash):
- UIProcess/WebPageProxy.h:
Add GetContentsAsString callback and generalize invalidating the callback
maps into a standalone function.
- UIProcess/WebPageProxy.messages.in:
Add DidGetContentsAsString return message.
- WebProcess/WebPage/WebFrame.h:
- WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::contentsAsString):
Gets the string content of all the subframes.
(WebKit::WebFrame::isFrameSet):
Call through to the document.
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::getContentsAsString):
Forward to the the main frames contentsAsString function.
- WebProcess/WebPage/WebPage.messages.in:
Add GetContentsAsString and collect all callback messages together.
- 2:20 PM Changeset in webkit [71677] by
-
- 2 edits in trunk/WebKit2
Fix mac build.
- WebProcess/mac/WebProcessMac.mm:
(WebKit::WebProcess::platformSetCacheModel):
- 2:05 PM Changeset in webkit [71676] by
-
- 2 edits in trunk/WebKit2
2010-11-09 Simon Fraser <Simon Fraser>
Reviewed by Darin Adler, Dan Bernstein.
<rdar://problem/8360145> Pages using accelerated compositing missing content on Windows
Disable accelerated compositing on Windows until we have cross-process
rendering implemented.
- WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::updatePreferences):
- 2:04 PM Changeset in webkit [71675] by
-
- 2 edits2 adds in trunk/LayoutTests
2010-11-09 Ryosuke Niwa <rniwa@webkit.org>
Unreviewed rebaselines for Chromium.
Also re-enabled editing/inserting/caret-position.html since it has been passing.
- platform/chromium-mac/editing/selection/unrendered-002-expected.checksum: Added.
- platform/chromium-mac/editing/selection/unrendered-002-expected.png: Added.
- platform/chromium/test_expectations.txt:
- 1:59 PM Changeset in webkit [71674] by
-
- 5 edits in trunk/WebCore
2010-11-09 Simon Fraser <Simon Fraser>
Reviewed by James Robinson.
Make showLayerTree() more useful for debugging
https://bugs.webkit.org/show_bug.cgi?id=49273
Three things to make showLayerTree() more useful when called from gdb:
- Add showLayerTree(RenderObject*)
- Make it not update layout, so you can call it when debugging layout code.
- Add output of the 'needs layout' flags for each renderer.
- rendering/RenderLayer.cpp: (showLayerTree):
- rendering/RenderLayer.h:
- rendering/RenderTreeAsText.cpp: (WebCore::RenderTreeAsText::writeRenderObject): (WebCore::externalRepresentation):
- rendering/RenderTreeAsText.h:
- 1:20 PM Changeset in webkit [71673] by
-
- 2 edits in trunk/LayoutTests
2010-11-09 Mihai Parparita <mihaip@chromium.org>
Unreviewed Chromium drt_expectations.txt update.
Remove DRT PASS expectations that we added a bit over-eagerly (they're
still flaky with the DRT).
- platform/chromium/drt_expectations.txt:
- 1:13 PM Changeset in webkit [71672] by
-
- 2 edits2 adds in trunk/WebKitTools
[NRWT] Make http locking similar to perl implementation
https://bugs.webkit.org/show_bug.cgi?id=49187
Patch by Gabor Rapcsanyi <rgabor@inf.u-szeged.hu> on 2010-11-09
Reviewed by Tony Chang.
- Scripts/webkitpy/common/system/file_lock.py: Added.
- Scripts/webkitpy/common/system/file_lock_unittest.py: Added.
- Scripts/webkitpy/layout_tests/port/http_lock.py:
- 1:05 PM Changeset in webkit [71671] by
-
- 3 edits in trunk/LayoutTests
2010-11-09 Mihai Parparita <mihaip@chromium.org>
Unreviewed Chromium test_expectations.txt update.
Remove tests that consistently pass:
- fast/js/kde/evil-n.html: passes with the v8 roll to 5780 (version 2.5.5) which fixed http://code.google.com/p/v8/issues/detail?id=924.
- http/tests/appcache/main-resource-redirect.html now only occasionally times out, and only under DRT for chromium-linux.
- fast/blockflow/english-rl-text.html (rebaselined with r71050)
- platform/chromium/drt_expectations.txt:
- platform/chromium/test_expectations.txt:
- 1:02 PM Changeset in webkit [71670] by
-
- 2 edits in trunk/WebCore
2010-11-09 Chris Rogers <crogers@google.com>
Reviewed by James Robinson.
AudioChannel.h is including AudioFloatArray.h instead of AudioArray.h
https://bugs.webkit.org/show_bug.cgi?id=49269
- platform/audio/AudioChannel.h:
- 1:01 PM Changeset in webkit [71669] by
-
- 10 edits2 deletes in trunk/WebKit2
Get rid of FindPageOverlay
https://bugs.webkit.org/show_bug.cgi?id=49268
Reviewed by Sam Weinig.
- WebKit2.pro:
- WebKit2.xcodeproj/project.pbxproj:
Remove files.
- WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::findString):
Create a PageOverlay with the FindController as its client.
(WebKit::FindController::willMoveToWebPage):
Null out the find page overlay if the web page is null.
(WebKit::FindController::didMoveToWebPage):
Add stub.
- WebProcess/WebPage/FindController.h:
FindController is now a PageOverlay::Client.
- WebProcess/WebPage/FindPageOverlay.cpp: Removed.
- WebProcess/WebPage/FindPageOverlay.h: Removed.
- WebProcess/WebPage/PageOverlay.cpp:
(WebKit::PageOverlay::setPage):
Call the willMoveToWebPage and didMoveToWebPage client functions.
(WebKit::PageOverlay::setNeedsDisplay):
Pass the page overlay bounds instead of the web page size.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::installPageOverlay):
Clear the page of the previous page overlay.
(WebKit::WebPage::uninstallPageOverlay):
Clear the page of the previous page overlay.
- WebProcess/WebPage/WebPage.h:
The page overlay is now refcounted.
- win/WebKit2.vcproj:
Remove files.
- 12:46 PM Changeset in webkit [71668] by
-
- 5 edits2 adds in trunk
WebCore: Made tables hit-test correctly in all writing modes.
Reviewed by Dave Hyatt.
Part of: Make tables work with vertical text
https://bugs.webkit.org/show_bug.cgi?id=46417
Test: fast/blockflow/table-hit-test.html
- rendering/RenderTable.cpp:
(WebCore::RenderTable::nodeAtPoint):
- rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::nodeAtPoint):
- rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::nodeAtPoint):
LayoutTests: Make tables work with vertical text
https://bugs.webkit.org/show_bug.cgi?id=46417
Reviewed by Dave Hyatt.
- fast/blockflow/table-hit-test-expected.txt: Added.
- fast/blockflow/table-hit-test.html: Added.
- 12:24 PM Changeset in webkit [71667] by
-
- 5 edits in trunk/WebKitTools
2010-11-09 James Kozianski <koz@chromium.org>
Reviewed by Eric Seidel.
Clean up imports for webkit-patch.
https://bugs.webkit.org/show_bug.cgi?id=49083
Move some imports from commands into main.py where they are used.
Move command imports into the init of the commands module.
- Scripts/webkitpy/tool/commands/init.py:
- Scripts/webkitpy/tool/commands/download.py:
- Scripts/webkitpy/tool/commands/queues.py:
- Scripts/webkitpy/tool/main.py:
- 12:13 PM Changeset in webkit [71666] by
-
- 2 edits2 adds in trunk/WebCore
2010-11-09 Simon Fraser <Simon Fraser>
Reviewed by Darin Adler.
Caret fails to render with some combination of iframes and compositing
https://bugs.webkit.org/show_bug.cgi?id=49079
Because it's possible for the caret to jump between different
compositing layers and the view, caret repainting currently dirties
both the view and all compositing layers that intersect the caret rect,
via repaintRectangleInViewAndCompositedLayers().
When an iframe contained compositing layers, we erroneously skipped
invalidating the compositing layer inside the iframe, which caused
the caret to fail to blink.
- manual-tests/compositing/caret-in-compositing-frame.html: Added.
- manual-tests/compositing/resources/editable-compositing-subframe.html: Added.
- rendering/RenderView.cpp: (WebCore::RenderView::repaintRectangleInViewAndCompositedLayers):
- 12:03 PM Changeset in webkit [71665] by
-
- 7 edits in trunk/WebKit2
Move the find page overlay code to FindController
https://bugs.webkit.org/show_bug.cgi?id=49266
Reviewed by John Sullivan.
- WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::~FindController):
(WebKit::FindController::rectsForTextMatches):
(WebKit::overlayBackgroundColor):
(WebKit::FindController::drawRect):
(WebKit::FindController::mouseEvent):
- WebProcess/WebPage/FindController.h:
- WebProcess/WebPage/FindPageOverlay.cpp:
(WebKit::FindPageOverlay::drawRect):
(WebKit::FindPageOverlay::mouseEvent):
- WebProcess/WebPage/FindPageOverlay.h:
- WebProcess/WebPage/PageOverlay.cpp:
(WebKit::PageOverlay::bounds):
(WebKit::PageOverlay::drawRect):
(WebKit::PageOverlay::mouseEvent):
- WebProcess/WebPage/PageOverlay.h:
- 11:45 AM Changeset in webkit [71664] by
-
- 10 edits in branches/chromium/552/WebCore
Merge 71641
BUG=62293
- 11:42 AM Changeset in webkit [71663] by
-
- 2 edits in trunk/WebKit/chromium
2010-11-09 Tony Chang <tony@chromium.org>
Unreviewed, rolling chromium DEPS.
- DEPS: Roll to r65462.
- 11:41 AM Changeset in webkit [71662] by
-
- 2 edits in trunk/WebKit2
Fix windows build.
- WebProcess/win/WebProcessWin.cpp:
(WebKit::WebProcess::platformSetCacheModel):
- 11:38 AM Changeset in webkit [71661] by
-
- 2 edits in branches/chromium/552/WebKit/chromium/src
Merge 71533
BUG=62168
- 11:38 AM Changeset in webkit [71660] by
-
- 15 edits in trunk/LayoutTests
2010-11-09 Ryosuke Niwa <rniwa@webkit.org>
Yet another unreviewed Chromium rebaselines for r71465.
- platform/chromium-linux/editing/deleting/delete-line-end-ws-001-expected.checksum:
- platform/chromium-linux/editing/deleting/delete-line-end-ws-001-expected.png:
- platform/chromium-linux/editing/deleting/delete-line-end-ws-002-expected.checksum:
- platform/chromium-linux/editing/deleting/delete-line-end-ws-002-expected.png:
- platform/chromium-linux/editing/selection/5232159-expected.checksum:
- platform/chromium-linux/editing/selection/5232159-expected.png:
- platform/chromium-win/editing/deleting/delete-line-end-ws-001-expected.checksum:
- platform/chromium-win/editing/deleting/delete-line-end-ws-001-expected.png:
- platform/chromium-win/editing/deleting/delete-line-end-ws-002-expected.checksum:
- platform/chromium-win/editing/deleting/delete-line-end-ws-002-expected.png:
- platform/chromium-win/editing/selection/5232159-expected.checksum:
- platform/chromium-win/editing/selection/5232159-expected.png:
- platform/chromium-win/editing/selection/5232159-expected.txt:
- platform/chromium/test_expectations.txt:
- 11:33 AM Changeset in webkit [71659] by
-
- 1 edit2 copies in branches/chromium/552
Merge 71642
BUG=62296
- 11:28 AM Changeset in webkit [71658] by
-
- 5 edits in trunk/WebKit2
Factor calculation of cache sizes based on cache model into shared function
https://bugs.webkit.org/show_bug.cgi?id=48706
Reviewed by Adam Roben.
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::calculateCacheSizes):
- WebProcess/WebProcess.h:
- WebProcess/mac/WebProcessMac.mm:
(WebKit::volumeFreeSize):
(WebKit::WebProcess::platformSetCacheModel):
- WebProcess/win/WebProcessWin.cpp:
(WebKit::memorySize):
(WebKit::volumeFreeSize):
(WebKit::WebProcess::platformSetCacheModel):
- 11:23 AM Changeset in webkit [71657] by
-
- 2 edits in trunk/LayoutTests
2010-11-09 Mihai Parparita <mihaip@chromium.org>
Unreviewed Chromium test_expectations.txt update.
Mark svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-edgeMode-prop.html
as flaky on chromium-linux.
- platform/chromium/test_expectations.txt:
- 11:20 AM Changeset in webkit [71656] by
-
- 2 edits in trunk/WebKit2
Context menus show up in the wrong place when the page is scrolled
https://bugs.webkit.org/show_bug.cgi?id=49264
Reviewed by Anders Carlsson.
Convert the hitTestResult point into 'window' coordinates before sending over
to the UIProcess to show the menu.
- WebProcess/WebPage/WebContextMenu.cpp:
(WebKit::WebContextMenu::show):
Convert to use message sender interface.
(WebKit::WebContextMenu::itemSelected):
Remove unnecessary WebCore::'s.
- 11:18 AM Changeset in webkit [71655] by
-
- 18 edits1 add in trunk/WebKit2
Send messages directly to the WebContext
https://bugs.webkit.org/show_bug.cgi?id=49262
Reviewed by Anders Carlsson.
- Platform/CoreIPC/MessageID.h:
Temporarily add MessageClassWebContextLegacy.
- Shared/CoreIPCSupport/WebContextMessageKinds.h:
Rename adding Legacy prefix.
- UIProcess/WebContext.cpp:
(WebKit::WebContext::didNavigateWithNavigationData):
(WebKit::WebContext::didPerformClientRedirect):
(WebKit::WebContext::didPerformServerRedirect):
(WebKit::WebContext::didUpdateHistoryTitle):
(WebKit::WebContext::setCacheModel):
(WebKit::WebContext::addVisitedLink):
(WebKit::WebContext::addVisitedLinkHash):
(WebKit::WebContext::getPlugins):
(WebKit::WebContext::getPluginPath):
(WebKit::WebContext::didReceiveMessage):
(WebKit::WebContext::didReceiveSyncMessage):
- UIProcess/WebContext.h:
- UIProcess/WebContext.messages.in: Added.
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::getPluginProcessConnection):
(WebKit::WebProcessProxy::didReceiveMessage):
(WebKit::WebProcessProxy::didReceiveSyncMessage):
- UIProcess/WebProcessProxy.h:
- UIProcess/WebProcessProxy.messages.in:
- WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::postMessage):
(WebKit::InjectedBundle::postSynchronousMessage):
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::updateGlobalHistory):
(WebKit::WebFrameLoaderClient::updateGlobalHistoryRedirectLinks):
(WebKit::WebFrameLoaderClient::setTitle):
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit::WebPlatformStrategies::populatePluginCache):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::createPlugin):
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::addVisitedLink):
Move context related messages to be sent directly to the context.
- DerivedSources.make:
- DerivedSources.pro:
- WebKit2.pro:
- WebKit2.xcodeproj/project.pbxproj:
- win/WebKit2.vcproj:
Add new files.
- 11:16 AM Changeset in webkit [71654] by
-
- 2 edits in trunk/WebCore
2010-11-09 Peter Rybin <peter.rybin@gmail.com>
Reviewed by Adam Barth.
XMLDocumentParser gets deleted and then used in LayoutTest/fast/frames/set-parent-src-synchronously.xhtml on QT/Linux
https://bugs.webkit.org/show_bug.cgi?id=48643
- dom/XMLDocumentParserQt.cpp: (WebCore::XMLDocumentParser::doWrite):
- 11:12 AM Changeset in webkit [71653] by
-
- 2 edits in trunk/LayoutTests
[Qt][WK2] Populate the WTR Skipped list with failing tests, which fail due to missing features.
Rubber-stamped by Csaba Osztrogonác.
- platform/qt-wk2/Skipped:
- 11:06 AM Changeset in webkit [71652] by
-
- 5 edits in trunk/WebKit2
Add a PageOverlay::Client object in preparation of not allowing subclassing of PageOverlay
https://bugs.webkit.org/show_bug.cgi?id=49263
Reviewed by John Sullivan.
- WebProcess/WebPage/FindPageOverlay.cpp:
(WebKit::FindPageOverlay::FindPageOverlay):
Call the PageOverlay constructor.
(WebKit::FindPageOverlay::drawRect):
(WebKit::FindPageOverlay::mouseEvent):
These now take a PageOverlay callback.
- WebProcess/WebPage/FindPageOverlay.h:
FindPageOverlay now inherits from PageOverlay::Client.
- WebProcess/WebPage/PageOverlay.cpp:
(WebKit::PageOverlay::create):
Add create function.
(WebKit::PageOverlay::PageOverlay):
The constructor now takes a client.
(WebKit::PageOverlay::drawRect):
(WebKit::PageOverlay::mouseEvent):
Call the client methods.
- WebProcess/WebPage/PageOverlay.h:
Add Client class.
- 11:04 AM Changeset in webkit [71651] by
-
- 1 edit3 moves in trunk/LayoutTests
2010-11-09 Tony Chang <tony@chromium.org>
Reviewed by Alexey Proskuryakov.
move fast/js/navigator-mimeTypes-length.html to plugin/
https://bugs.webkit.org/show_bug.cgi?id=49226
- plugins/navigator-mimeTypes-length-expected.txt: Renamed from LayoutTests/fast/js/navigator-mimeTypes-length-expected.txt.
- plugins/navigator-mimeTypes-length.html: Renamed from LayoutTests/fast/js/navigator-mimeTypes-length.html.
- plugins/script-tests/navigator-mimeTypes-length.js: Renamed from LayoutTests/fast/js/script-tests/navigator-mimeTypes-length.js.
- 10:55 AM Changeset in webkit [71650] by
-
- 5 edits in trunk/LayoutTests
2010-11-09 Mihai Parparita <mihaip@chromium.org>
Unreviewed Chromium rebaseline.
Rebaseline fast/repaint/inline-outline-repaint.html after r71589
(the caret is now slightly visible, but that's not what the test is
testing for)
- platform/chromium-linux/fast/repaint/inline-outline-repaint-expected.checksum:
- platform/chromium-linux/fast/repaint/inline-outline-repaint-expected.png:
- platform/chromium-win/fast/repaint/inline-outline-repaint-expected.checksum:
- platform/chromium-win/fast/repaint/inline-outline-repaint-expected.png:
- 10:55 AM Changeset in webkit [71649] by
-
- 2 edits in trunk/WebKitTools
2010-11-09 Yi Shen <yi.4.shen@nokia.com>
Reviewed by Andreas Kling.
[Qt][QtTestBrowser] Don't erase incorrect url in the Url Bar
https://bugs.webkit.org/show_bug.cgi?id=49047
- QtTestBrowser/mainwindow.cpp: (MainWindow::setAddressUrl):
- 10:19 AM Changeset in webkit [71648] by
-
- 2 edits in trunk/WebKit2
<rdar://problem/8646456> WebProcess crashes reproducibly on complex text
Rubber-stamped by Darin Adler.
- WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface): Initialize wkCreateCTTypesetterWithUniCharProviderAndOptions
and wkCreateCTLineWithUniCharProvider.
- 10:16 AM Changeset in webkit [71647] by
-
- 2 edits in trunk/LayoutTests
2010-11-09 Mihai Parparita <mihaip@chromium.org>
Unreviewed Chromium test_expectations.txt update.
Remove tests that now pass (r71589 fixed the regression in caret
rendering).
- platform/chromium/test_expectations.txt:
- 10:07 AM Changeset in webkit [71646] by
-
- 2 edits in trunk/WebKit2
Fix Windows build.
- win/WebKit2.vcproj:
- 9:58 AM Changeset in webkit [71645] by
-
- 2 edits in trunk/WebKit2
Fix Qt build.
- WebKit2.pro:
- 9:54 AM Changeset in webkit [71644] by
-
- 1 edit8 adds in trunk/LayoutTests
2010-11-09 Mihai Parparita <mihaip@chromium.org>
Unreviewed Chromium rebaseline.
Add missing Chromium Windows and Linux baselines for SVG tests added by
r71630.
- platform/chromium-linux/svg/dynamic-updates/SVGFETileElement-dom-in-attr-expected.checksum: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFETileElement-dom-in-attr-expected.png: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFETileElement-svgdom-in-prop-expected.checksum: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFETileElement-svgdom-in-prop-expected.png: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFETileElement-dom-in-attr-expected.checksum: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFETileElement-dom-in-attr-expected.png: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFETileElement-svgdom-in-prop-expected.checksum: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFETileElement-svgdom-in-prop-expected.png: Added.
- 9:51 AM Changeset in webkit [71643] by
-
- 3 edits in trunk/LayoutTests
Not reviewed, Chromium test expectation update.
Add a bug number for some failing tests, and move an expectation from
the Chromium-side overrides to the WebKit-side expectations.
- platform/chromium/drt_expectations.txt:
- platform/chromium/test_expectations.txt:
- 9:45 AM Changeset in webkit [71642] by
-
- 3 edits2 adds in trunk
2010-11-09 Simon Fraser <Simon Fraser>
Reviewed by Dave Hyatt.
https://bugs.webkit.org/show_bug.cgi?id=49197
<rdar://problem/8642746>
When starting an accelerated transform animation on a renderer, check
that it's a RenderBox before allow transform animations (and before
calling borderBoxRect()), because transforms are currently disallowed
on inline elements.
Test: animations/animation-on-inline-crash.html
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::startAnimation):
- 9:45 AM Changeset in webkit [71641] by
-
- 11 edits in trunk/WebCore
2010-11-09 Simon Fraser <Simon Fraser>
Reviewed by Dave Hyatt.
https://bugs.webkit.org/show_bug.cgi?id=49204
<rdar://problem/8643412>
Add checks to the CSSStyleSelector code to ensure that the
casts to the various CSSValue types are safe, and do more
rigorous checking of the lengths of CSSValueLists, and
non-null members of Pair in some cases.
- css/CSSBorderImageValue.h: (WebCore::CSSBorderImageValue::isBorderImageValue):
- css/CSSCursorImageValue.h: (WebCore::CSSCursorImageValue::isCursorImageValue):
- css/CSSImageValue.h: (WebCore::CSSImageValue::isImageValue):
- css/CSSReflectValue.h: (WebCore::CSSReflectValue::isReflectValue):
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::resolveVariablesForDeclaration): (WebCore::CSSRuleSet::addRulesFromSheet): (WebCore::CSSRuleSet::addStyleRule): (WebCore::applyCounterList): (WebCore::CSSStyleSelector::applyProperty): (WebCore::CSSStyleSelector::mapFillSize): (WebCore::CSSStyleSelector::mapAnimationDelay): (WebCore::CSSStyleSelector::mapAnimationDirection): (WebCore::CSSStyleSelector::mapAnimationFillMode): (WebCore::CSSStyleSelector::mapAnimationName): (WebCore::CSSStyleSelector::mapAnimationPlayState): (WebCore::CSSStyleSelector::mapNinePieceImage): (WebCore::CSSStyleSelector::createTransformOperations):
- css/CSSValue.h: (WebCore::CSSValue::isBorderImageValue): (WebCore::CSSValue::isCursorImageValue): (WebCore::CSSValue::isFontFamilyValue): (WebCore::CSSValue::isReflectValue): (WebCore::CSSValue::isShadowValue):
- css/FontFamilyValue.h: (WebCore::FontFamilyValue::isFontFamilyValue):
- css/SVGCSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applySVGProperty):
- css/ShadowValue.h: (WebCore::ShadowValue::isShadowValue):
- platform/graphics/transforms/TransformOperations.h: (WebCore::TransformOperations::clear):
- 9:44 AM Changeset in webkit [71640] by
-
- 24 edits5 adds in trunk/WebKit2
Windows Popup widget support (<select>)
<rdar://problem/8559439>
https://bugs.webkit.org/show_bug.cgi?id=48701
Reviewed by Anders Carlsson.
Port WebCore's PopupMenuWin's implementation to work within the confines of WebKit2.
Since we currently can't draw text using WebCore in the UIProcess, this approach uses
the WebProcess to create two bitmaps representing the full popup menu (both unselected and
selected) and sends them to the UIProcess to be drawn in an HWND.
- Shared/BackingStore.h:
- Shared/cg/BackingStoreCG.cpp:
- Shared/qt/BackingStoreQt.cpp:
Add new function to create a flipped graphics context from the backing store,
and add additional parameters to paint, to allow more control of how the backing
store is painted into the destination context.
- Shared/PlatformPopupMenuData.cpp: Added.
(WebKit::PlatformPopupMenuData::PlatformPopupMenuData):
(WebKit::PlatformPopupMenuData::encode):
(WebKit::PlatformPopupMenuData::decode):
- Shared/PlatformPopupMenuData.h: Added.
Add struct so platforms can send platform specific data to their popup menu implementations.
- Shared/WebPopupItem.cpp:
(WebKit::WebPopupItem::WebPopupItem):
(WebKit::WebPopupItem::encode):
(WebKit::WebPopupItem::decode):
- Shared/WebPopupItem.h:
Add isLabel for each menu item.
- UIProcess/FindIndicator.cpp:
(WebKit::FindIndicator::draw):
Update for new BackingStore::paint signature.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::showPopupMenu):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- UIProcess/WebPopupMenuProxy.h:
- UIProcess/mac/WebPopupMenuProxyMac.h:
- UIProcess/mac/WebPopupMenuProxyMac.mm:
(WebKit::WebPopupMenuProxyMac::showPopupMenu):
- UIProcess/qt/WebPopupMenuProxyQt.cpp:
(WebKit::WebPopupMenuProxyQt::showPopupMenu):
- UIProcess/qt/WebPopupMenuProxyQt.h:
Pass through the new PlatformPopupMenuData.
- UIProcess/win/WebPopupMenuProxyWin.cpp:
- UIProcess/win/WebPopupMenuProxyWin.h:
Port implementation from WebCore.
- UIProcess/win/WebView.cpp:
(WebKit::WebView::createPopupMenuProxy):
Pass the WebView to the WebPopupMenuProxyWin.
- WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::paint):
(WebKit::PluginProxy::update):
Update for new BackingStore::paint signature.
- WebProcess/WebCoreSupport/WebPopupMenu.cpp:
(WebKit::WebPopupMenu::populateItems): Add isLabel for each item.
(WebKit::WebPopupMenu::show): Give each platform a chance to add platform specific data.
- WebProcess/WebCoreSupport/WebPopupMenu.h:
- WebProcess/WebCoreSupport/mac/WebPopupMenuMac.mm: Added.
(WebKit::WebPopupMenu::setUpPlatformData):
- WebProcess/WebCoreSupport/qt/WebPopupMenuQt.cpp: Added.
(WebKit::WebPopupMenu::setUpPlatformData):
Add stubbed out setUpPlatformData.
- WebProcess/WebCoreSupport/win/WebPopupMenuWin.cpp: Added.
(WebKit::WebPopupMenu::setUpPlatformData):
Compute data needed in the UIProcess including generating the bitmaps.
- WebKit2.pro:
- WebKit2.xcodeproj/project.pbxproj:
- win/WebKit2.vcproj:
Add new files.
- 9:34 AM Changeset in webkit [71639] by
-
- 3 edits in trunk/WebCore
2010-11-09 Ben Murdoch <benm@google.com>
Reviewed by Steve Block.
Android is missing implementation of V8GCController::checkMemoryUsage
https://bugs.webkit.org/show_bug.cgi?id=49255
This patch adds the necessary code to WebCore to implement the
functionality. The implementation of the PlatformBridge on Android
does not live upstream yet, so not patching that here.
No new test as this is a platform specific change on Android.
- bindings/v8/V8GCController.cpp: (WebCore::V8GCController::checkMemoryUsage): Implement on Android.
- platform/android/PlatformBridge.h: Add necessary methods to read
device specific memory usage and constraints.
- 8:50 AM Changeset in webkit [71638] by
-
- 2 edits in trunk/WebKit2
2010-11-09 Balazs Kelemen <kbalazs@webkit.org>
Reviewed by Csaba Osztrogonác.
[Qt][WK2] ASSERT fail in fast/frames/lots-of-objects.html
https://bugs.webkit.org/show_bug.cgi?id=49253
- Platform/qt/SharedMemoryQt.cpp: (WebKit::SharedMemory::create): Do not assert when the attach was unsuccessful but return with 0.
- 8:47 AM Changeset in webkit [71637] by
-
- 2 edits in trunk/LayoutTests
2010-11-09 Mihai Parparita <mihaip@chromium.org>
Unreviewed Chromium drt_expectations.txt update.
Remove tests that are no longer present:
- platform/chromium/plugins/multiple-plugins.html was moved to run on all platforms by r71363
- platform/chromium/plugins/nested-plugin-objects.html was moved to run on all platforms by r71537
- platform/win/plugins/plugin-delayed-destroy.html was replaced by plugins/evaluate-js-after-removing-plugin-element.html in r71249
- platform/chromium/drt_expectations.txt:
- 8:38 AM Changeset in webkit [71636] by
-
- 2 edits in trunk/LayoutTests
2010-11-09 Mihai Parparita <mihaip@chromium.org>
Unreviewed Chromium test_expectations.txt update.
Expect failures for printing/page-format-data-display-none.html due to
test_shell and DRT not having LayoutTestController.
pageSizeAndMarginsInPixels.
- platform/chromium/test_expectations.txt:
- 8:09 AM Changeset in webkit [71635] by
-
- 2 edits in trunk/WebCore
2010-11-09 Andreas Kling <kling@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
ScrollView::updateScrollbars() shouldn't do anything when scrolling is delegated.
- platform/ScrollView.cpp: (WebCore::ScrollView::updateScrollbars):
- 8:06 AM Changeset in webkit [71634] by
-
- 4 edits in trunk/LayoutTests
2010-11-09 Mihai Parparita <mihaip@chromium.org>
Unreviewed Chromium rebaselines.
More fixes after r71612 (removed requestEnd) and r71608 (split
domContentLoaded into domContentLoadedStart and domContentLoadedEnd).
- fast/dom/script-tests/webtiming.js: (checkWebTimingOnDOMContentLoaded):
- fast/dom/webtiming-expected.txt:
- fast/dom/webtiming-navigate-within-document-expected.txt:
- 7:55 AM Changeset in webkit [71633] by
-
- 2 edits in trunk/LayoutTests
2010-11-09 Mihai Parparita <mihaip@chromium.org>
Unreviewed Chromium rebaseline.
r71612 removed requestEnd, r71608 split domContentLoaded into
domContentLoadedStart and domContentLoadedEnd.
- fast/dom/Window/window-properties-performance-expected.txt:
- 7:46 AM Changeset in webkit [71632] by
-
- 3 edits in trunk/WebCore
2010-11-09 Steve Block <steveblock@google.com>
Reviewed by Andreas Kling.
Unused parameter warning causes JSC build failure with deviceorientation
https://bugs.webkit.org/show_bug.cgi?id=49251
No new tests, build fix only.
- bindings/js/JSDeviceMotionEventCustom.cpp: (WebCore::JSDeviceMotionEvent::interval):
- bindings/js/JSDeviceOrientationEventCustom.cpp: (WebCore::JSDeviceOrientationEvent::alpha): (WebCore::JSDeviceOrientationEvent::beta): (WebCore::JSDeviceOrientationEvent::gamma):
- 7:33 AM Changeset in webkit [71631] by
-
- 2 edits in trunk/WebKit/chromium
2010-11-09 Mihai Parparita <mihaip@chromium.org>
Unreviewed Chromium Windows build fix.
Add isDisplayNone to the PopupMenuStyle constructor call in
PopupMenuTest (necessary after r71618).
- tests/PopupMenuTest.cpp: (WebKit::TestPopupMenuClient::itemStyle):
- 7:31 AM Changeset in webkit [71630] by
-
- 4 edits10 adds in trunk
SVGFETileElement doesn't support dynamic invalidation, when attributes change.
https://bugs.webkit.org/show_bug.cgi?id=49247
Patch by Renata Hodovan <reni@webkit.org> on 2010-11-09
Reviewed by Nikolas Zimmermann.
WebCore:
The dynamic changes are captured by the svgAttributeChanged function. Invalidate the filter primitive if necessary.
Tests: svg/dynamic-updates/SVGFETileElement-dom-in-attr.html
svg/dynamic-updates/SVGFETileElement-svgdom-in-prop.html
- svg/SVGFETileElement.cpp:
(WebCore::SVGFETileElement::svgAttributeChanged):
- svg/SVGFETileElement.h:
LayoutTests:
Adding layout tests for feTile dynamic changes.
- platform/mac/svg/dynamic-updates/SVGFETileElement-dom-in-attr-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFETileElement-dom-in-attr-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFETileElement-svgdom-in-prop-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFETileElement-svgdom-in-prop-expected.png: Added.
- svg/dynamic-updates/SVGFETileElement-dom-in-attr-expected.txt: Added.
- svg/dynamic-updates/SVGFETileElement-dom-in-attr.html: Added.
- svg/dynamic-updates/SVGFETileElement-svgdom-in-prop-expected.txt: Added.
- svg/dynamic-updates/SVGFETileElement-svgdom-in-prop.html: Added.
- svg/dynamic-updates/script-tests/SVGFETileElement-dom-in-attr.js: Added.
(executeTest):
- svg/dynamic-updates/script-tests/SVGFETileElement-svgdom-in-prop.js: Added.
(executeTest):
- 7:28 AM Changeset in webkit [71629] by
-
- 2 edits in trunk/WebKitTools
2010-11-09 Andras Becsi <abecsi@webkit.org>
Reviewed by Csaba Osztrogonác.
Improve old-run-webkit-tests --verbose to show DumpTool opening/closing
https://bugs.webkit.org/show_bug.cgi?id=49252
- Scripts/old-run-webkit-tests:
- 7:20 AM Changeset in webkit [71628] by
-
- 2 edits in trunk/LayoutTests
2010-11-09 Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>
Rubber-stamped by Antonio Gomes.
Remove fast/events/click-focus-control.html from windows Skipped list.
This way it will fall back to Mac version of test results and windows
matches Mac in this case.
https://bugs.webkit.org/show_bug.cgi?id=40641
- platform/win/Skipped:
- 7:16 AM Changeset in webkit [71627] by
-
- 2 edits in trunk/WebKitTools
2010-11-09 Csaba Osztrogonác <Csaba Osztrogonác>
Reviewed by Tor Arne Vestbø.
Output of old-run-webkit-tests is buggy in verbose mode
https://bugs.webkit.org/show_bug.cgi?id=49249
- Scripts/old-run-webkit-tests: Redundant outputs removed.
- 6:27 AM Changeset in webkit [71626] by
-
- 8 edits9 adds in trunk/LayoutTests
Update Windows results after r71566 and r71572
- platform/win/editing/selection/extend-selection-expected.txt:
- platform/win/fast/blockflow/japanese-lr-selection-expected.checksum:
- platform/win/fast/blockflow/japanese-lr-selection-expected.png:
- platform/win/fast/blockflow/japanese-lr-selection-expected.txt:
- platform/win/fast/blockflow/japanese-rl-selection-expected.checksum:
- platform/win/fast/blockflow/japanese-rl-selection-expected.png:
- platform/win/fast/blockflow/japanese-rl-selection-expected.txt:
- platform/win/fast/blockflow/japanese-ruby-horizontal-bt-expected.checksum: Added.
- platform/win/fast/blockflow/japanese-ruby-horizontal-bt-expected.png: Added.
- platform/win/fast/blockflow/japanese-ruby-horizontal-bt-expected.txt: Added.
- platform/win/fast/blockflow/japanese-ruby-vertical-lr-expected.checksum: Added.
- platform/win/fast/blockflow/japanese-ruby-vertical-lr-expected.png: Added.
- platform/win/fast/blockflow/japanese-ruby-vertical-lr-expected.txt: Added.
- platform/win/fast/blockflow/japanese-ruby-vertical-rl-expected.checksum: Added.
- platform/win/fast/blockflow/japanese-ruby-vertical-rl-expected.png: Added.
- platform/win/fast/blockflow/japanese-ruby-vertical-rl-expected.txt: Added.
- 5:01 AM Changeset in webkit [71625] by
-
- 7 edits in trunk/WebCore
2010-11-09 Jenn Braithwaite <jennb@chromium.org>
Reviewed by Dmitry Titov.
Update ProgressTracker when moving a frame between documents
https://bugs.webkit.org/show_bug.cgi?id=48368
No new tests. andersca informs me it's not possible to test
ProgressTracker changes via layouttests. Review extra carefully...
- loader/DocumentLoader.cpp: (WebCore::DocumentLoader::transferLoadingResourcesFromPage): Changed to use FrameLoader to deliver the notification to the client via the notifier.
- loader/FrameLoader.cpp: (WebCore::FrameLoader:;transferLoadingResourcesFromPage): Update old and new progress tracker about frame progress. (WebCore::FrameLoader::dispatchTransferLoadingResourceFromPage): Added to route notification via the notifier.
- loader/FrameLoader.h:
- loader/ProgressTracker.cpp: (WebCore::ProgressTracker::completeProgress): Comment change only.
- loader/ResourceLoadNotifier.cpp: (WebCore::ResourceLoadNotifier::dispatchTransferLoadingResourceFromPage): Added to provide one place to notify client and progress tracker - and probably inspector controller (separate patch).
- loader/ResourceLoadNotifier.h:
- 4:53 AM Changeset in webkit [71624] by
-
- 2 edits in trunk/WebKit2
2010-11-09 Balazs Kelemen <kbalazs@webkit.org>
Reviewed by Andreas Kling.
[Qt][WK2] WebKitTestRunner is dead
https://bugs.webkit.org/show_bug.cgi?id=49129
- Platform/qt/SharedMemoryQt.cpp: (WebKit::SharedMemory::~SharedMemory): Follow up fix: do not access the QSharedMemory object in an assert if it has been deleted.
- 4:38 AM Changeset in webkit [71623] by
-
- 3 edits1 move in trunk/LayoutTests
2010-11-09 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: debugger-autocontinue-on-syntax-error.html should restore debugger state to disabled
https://bugs.webkit.org/show_bug.cgi?id=49244
- inspector/debugger-autocontinue-on-syntax-error-expected.txt:
- inspector/debugger-autocontinue-on-syntax-error.html:
- platform/chromium/inspector/debugger-autocontinue-on-syntax-error-expected.txt: Renamed from LayoutTests/platform/chromium-win/inspector/debugger-autocontinue-on-syntax-error-expected.txt.
- 4:26 AM Changeset in webkit [71622] by
-
- 12 edits in trunk
2010-11-09 Dai Mikurube <dmikurube@google.com>
Reviewed by Kent Tamura.
Too precise serialization from floating point number to string for "number" input elements
https://bugs.webkit.org/show_bug.cgi?id=48308
- fast/forms/input-stepup-stepdown-expected.txt:
- fast/forms/script-tests/input-stepup-stepdown.js:
2010-11-09 Dai Mikurube <dmikurube@google.com>
Reviewed by Kent Tamura.
Too precise serialization from floating point number to string for "number" input elements
https://bugs.webkit.org/show_bug.cgi?id=48308
Modified to consider decimal places when handling step and base in applyStep().
- html/HTMLInputElement.cpp: Considering decimal places of the given "step" attribtue. (WebCore::HTMLInputElement::getAllowedValueStep): (WebCore::HTMLInputElement::getAllowedValueStepWithDecimalPlaces): (WebCore::HTMLInputElement::applyStep):
- html/HTMLInputElement.h:
- html/InputType.cpp: Added virtual functions for decimal places and an acceptable error. (WebCore::InputType::stepBaseWithDecimalPlaces): (WebCore::InputType::acceptableError): (WebCore::InputType::parseToDoubleWithDecimalPlaces):
- html/InputType.h:
- html/NumberInputType.cpp: (WebCore::NumberInputType::stepMismatch): Using the virtual function acceptableError(). (WebCore::NumberInputType::stepBaseWithDecimalPlaces): Considering decimal places of the given "base" attribute. (WebCore::NumberInputType::parseToDoubleWithDecimalPlaces): (WebCore::NumberInputType::acceptableError): Concrete acceptableError() for the number type.
- html/NumberInputType.h:
- html/parser/HTMLParserIdioms.cpp: (WebCore::parseToDoubleForNumberTypeWithDecimalPlaces): Parsing numbers with decimal places.
- html/parser/HTMLParserIdioms.h:
- 4:21 AM Changeset in webkit [71621] by
-
- 3 edits2 adds in trunk
2010-11-09 Yuzo Fujishima <yuzo@google.com>
Reviewed by Shinichiro Hamaji.
Fix for Bug 48984 - [Chromium] @media print crash due to paged media support
https://bugs.webkit.org/show_bug.cgi?id=48984
- printing/page-format-data-display-none-expected.txt: Added.
- printing/page-format-data-display-none.html: Added.
2010-11-09 Yuzo Fujishima <yuzo@google.com>
Reviewed by Shinichiro Hamaji.
Fix for Bug 48984 - [Chromium] @media print crash due to paged media support
Page context has been inheriting from document element style that becomes null if display property is none.
It should inherit from document style instead to properly handle direction property (and to avoid the null reference).
https://bugs.webkit.org/show_bug.cgi?id=48984
Test: printing/page-format-data-display-none.html
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::styleForPage): Page context inherits from document style.
- 4:05 AM Changeset in webkit [71620] by
-
- 2 edits in trunk
2010-11-09 Gavin Peters <gavinp@chromium.org>
Reviewed by Xan Lopez.
gtk platform doesn't support link prefetch
https://bugs.webkit.org/show_bug.cgi?id=49234
- configure.ac:
- 3:48 AM Changeset in webkit [71619] by
-
- 1 edit2 adds in trunk/WebCore
2010-11-09 Chris Rogers <crogers@google.com>
Reviewed by Kenneth Russell.
Add custom bindings for AudioContext
https://bugs.webkit.org/show_bug.cgi?id=49115
No new tests since audio API is not yet implemented.
- bindings/js/JSAudioContextCustom.cpp: Added. (WebCore::JSAudioContextConstructor::constructJSAudioContext):
- bindings/v8/custom/V8AudioContextCustom.cpp: Added. (WebCore::V8AudioContext::constructorCallback):
- 2:39 AM Changeset in webkit [71618] by
-
- 7 edits in trunk
2010-11-09 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Dimitri Glazkov.
[Chromium] display:none has no effect on <option> element
https://bugs.webkit.org/show_bug.cgi?id=49169
Added a manual test because it's hard to test the content of
<option> element.
- manual-tests/display-none-option.html: Added.
- platform/PopupMenuStyle.h: (WebCore::PopupMenuStyle::PopupMenuStyle): (WebCore::PopupMenuStyle::isDisplayNone):
- platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupListBox::getRowHeight): (WebCore::PopupListBox::layout):
- rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::itemStyle): (WebCore::RenderMenuList::menuStyle):
- rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::menuStyle):
2010-11-09 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Dimitri Glazkov.
[Chromium] display:none has no effect on <option> element
https://bugs.webkit.org/show_bug.cgi?id=49169
- src/AutoFillPopupMenuClient.cpp: (WebKit::AutoFillPopupMenuClient::initialize):
- 2:39 AM Changeset in webkit [71617] by
-
- 2 edits in trunk/LayoutTests
Unreviewed.
[Qt] REGRESSION (r71582): Two editing tests fail
https://bugs.webkit.org/show_bug.cgi?id=49243
- platform/qt/Skipped:
- editing/deleting/delete-line-011.html added until fix.
- editing/pasteboard/paste-4039777-fix.html added until fix.
- 1:57 AM Changeset in webkit [71616] by
-
- 1 edit12 adds in trunk/LayoutTests
2010-11-09 Ryosuke Niwa <rniwa@webkit.org>
More unreviewed Chromium rebaselines for r71465.
- platform/chromium-mac/editing/pasteboard/4806874-expected.checksum: Added.
- platform/chromium-mac/editing/pasteboard/4806874-expected.png: Added.
- platform/chromium-mac/editing/pasteboard/4944770-1-expected.checksum: Added.
- platform/chromium-mac/editing/pasteboard/4944770-1-expected.png: Added.
- platform/chromium-mac/editing/pasteboard/input-field-1-expected.checksum: Added.
- platform/chromium-mac/editing/pasteboard/input-field-1-expected.png: Added.
- platform/chromium-mac/editing/selection/4397952-expected.checksum: Added.
- platform/chromium-mac/editing/selection/4397952-expected.png: Added.
- platform/chromium-mac/editing/selection/caret-before-select-expected.checksum: Added.
- platform/chromium-mac/editing/selection/caret-before-select-expected.png: Added.
- platform/chromium-mac/editing/selection/select-element-paragraph-boundary-expected.checksum: Added.
- platform/chromium-mac/editing/selection/select-element-paragraph-boundary-expected.png: Added.
- 12:58 AM Changeset in webkit [71615] by
-
- 3 edits in trunk/LayoutTests
2010-11-09 Adrienne Walker <enne@google.com>
Reviewed by Andreas Kling.
getAttachedShaders should only return NULL in the case of error.
https://bugs.webkit.org/show_bug.cgi?id=49231
- fast/canvas/webgl/gl-object-get-calls-expected.txt:
- fast/canvas/webgl/gl-object-get-calls.html:
- 12:56 AM Changeset in webkit [71614] by
-
- 3 edits in trunk/LayoutTests
2010-11-09 Ryosuke Niwa <rniwa@webkit.org>
Unreviewed Chromium rebaselines for r71566.
- platform/chromium-win/fast/forms/focus-selection-textarea-expected.txt:
- platform/chromium/test_expectations.txt:
- 12:40 AM Changeset in webkit [71613] by
-
- 3 edits1 add in trunk/WebCore
2010-11-09 Chris Rogers <crogers@google.com>
Reviewed by Kenneth Russell.
audio engine: add audio resources abstraction
https://bugs.webkit.org/show_bug.cgi?id=34660
No new tests since audio API is not yet implemented.
- platform/audio/AudioBus.h:
- platform/audio/HRTFElevation.cpp: (WebCore::HRTFElevation::calculateKernelsForAzimuthElevation): (WebCore::HRTFElevation::createByInterpolatingSlices):
- platform/audio/mac/AudioBusMac.mm: Added. (WebCore::AudioBus::loadPlatformResource):
- 12:22 AM Changeset in webkit [71612] by
-
- 11 edits in trunk
2010-11-09 James Simonsen <simonjam@chromium.org>
Reviewed by Dimitri Glazkov.
[Web Timing] Remove requestEnd
https://bugs.webkit.org/show_bug.cgi?id=48924
- fast/dom/script-tests/webtiming.js: (checkTimingBeforeLoad): (checkTimingWhileDeferred): (checkWebTimingWhileAsync): (checkWebTimingOnLoad): (checkWebTimingAfterLoad):
- fast/dom/webtiming-document-open-expected.txt:
- fast/dom/webtiming-expected.txt:
2010-11-09 James Simonsen <simonjam@chromium.org>
Reviewed by Dimitri Glazkov.
[Web Timing] Remove requestEnd
https://bugs.webkit.org/show_bug.cgi?id=48924
- page/Timing.cpp:
- page/Timing.h:
- page/Timing.idl:
2010-11-09 James Simonsen <simonjam@chromium.org>
Reviewed by Dimitri Glazkov.
[Web Timing] Remove requestEnd
https://bugs.webkit.org/show_bug.cgi?id=48924
- public/WebPerformance.h:
- src/WebPerformance.cpp:
- 12:04 AM Changeset in webkit [71611] by
-
- 2 edits in trunk/WebCore
2010-11-09 Sam Magnuson <smagnuson@netflix.com>
Reviewed by Andreas Kling.
[Qt] image borders do not render correctly
https://bugs.webkit.org/show_bug.cgi?id=49191
Test: fast/borders/border-image-01.html
- platform/graphics/qt/ImageQt.cpp: (WebCore::Image::drawPattern):
Nov 8, 2010:
- 11:48 PM Changeset in webkit [71610] by
-
- 3 edits in trunk/WebKit/chromium
2010-11-08 John Knottenbelt <jknotten@chromium.org>
Reviewed by Steve Block.
Convert to and from DOMTimeStamp with converter functions
https://bugs.webkit.org/show_bug.cgi?id=49066
- src/WebDataSourceImpl.cpp: (WebKit::WebDataSourceImpl::triggeringEventTime):
- 11:07 PM Changeset in webkit [71609] by
-
- 67 edits1 add in trunk/LayoutTests
2010-11-08 Ryosuke Niwa <rniwa@webkit.org>
Unreviewed Chromium rebaselines for r71465.
- platform/chromium-linux/editing/pasteboard/4806874-expected.checksum:
- platform/chromium-linux/editing/pasteboard/4806874-expected.png:
- platform/chromium-linux/editing/pasteboard/4944770-1-expected.checksum:
- platform/chromium-linux/editing/pasteboard/4944770-1-expected.png:
- platform/chromium-linux/editing/pasteboard/input-field-1-expected.checksum:
- platform/chromium-linux/editing/pasteboard/input-field-1-expected.png:
- platform/chromium-linux/editing/selection/4397952-expected.checksum:
- platform/chromium-linux/editing/selection/4397952-expected.png:
- platform/chromium-linux/editing/selection/caret-before-select-expected.checksum:
- platform/chromium-linux/editing/selection/caret-before-select-expected.png:
- platform/chromium-linux/editing/selection/click-start-of-line-expected.checksum:
- platform/chromium-linux/editing/selection/click-start-of-line-expected.png:
- platform/chromium-linux/editing/selection/extend-by-word-002-expected.checksum:
- platform/chromium-linux/editing/selection/extend-by-word-002-expected.png:
- platform/chromium-linux/editing/selection/select-element-paragraph-boundary-expected.checksum:
- platform/chromium-linux/editing/selection/select-element-paragraph-boundary-expected.png:
- platform/chromium-linux/fast/blockflow/border-radius-clipping-vertical-lr-expected.checksum:
- platform/chromium-linux/fast/blockflow/border-radius-clipping-vertical-lr-expected.png:
- platform/chromium-linux/fast/blockflow/box-shadow-horizontal-bt-expected.checksum:
- platform/chromium-linux/fast/blockflow/box-shadow-horizontal-bt-expected.png:
- platform/chromium-linux/fast/blockflow/box-shadow-vertical-lr-expected.checksum:
- platform/chromium-linux/fast/blockflow/box-shadow-vertical-lr-expected.png:
- platform/chromium-linux/fast/text/delete-hard-break-character-expected.checksum:
- platform/chromium-linux/fast/text/delete-hard-break-character-expected.png:
- platform/chromium-win/editing/pasteboard/4806874-expected.checksum:
- platform/chromium-win/editing/pasteboard/4806874-expected.png:
- platform/chromium-win/editing/pasteboard/4944770-1-expected.checksum:
- platform/chromium-win/editing/pasteboard/4944770-1-expected.png:
- platform/chromium-win/editing/pasteboard/input-field-1-expected.checksum:
- platform/chromium-win/editing/pasteboard/input-field-1-expected.png:
- platform/chromium-win/editing/selection/4397952-expected.checksum:
- platform/chromium-win/editing/selection/4397952-expected.png:
- platform/chromium-win/editing/selection/after-line-break-expected.txt: Added.
- platform/chromium-win/editing/selection/caret-before-select-expected.checksum:
- platform/chromium-win/editing/selection/caret-before-select-expected.png:
- platform/chromium-win/editing/selection/click-start-of-line-expected.checksum:
- platform/chromium-win/editing/selection/click-start-of-line-expected.png:
- platform/chromium-win/editing/selection/extend-by-word-002-expected.checksum:
- platform/chromium-win/editing/selection/extend-by-word-002-expected.png:
- platform/chromium-win/editing/selection/select-element-paragraph-boundary-expected.checksum:
- platform/chromium-win/editing/selection/select-element-paragraph-boundary-expected.png:
- platform/chromium-win/fast/blockflow/border-radius-clipping-vertical-lr-expected.checksum:
- platform/chromium-win/fast/blockflow/border-radius-clipping-vertical-lr-expected.png:
- platform/chromium-win/fast/blockflow/border-radius-clipping-vertical-lr-expected.txt:
- platform/chromium-win/fast/blockflow/box-shadow-horizontal-bt-expected.checksum:
- platform/chromium-win/fast/blockflow/box-shadow-horizontal-bt-expected.png:
- platform/chromium-win/fast/blockflow/box-shadow-horizontal-bt-expected.txt:
- platform/chromium-win/fast/blockflow/box-shadow-vertical-lr-expected.checksum:
- platform/chromium-win/fast/blockflow/box-shadow-vertical-lr-expected.png:
- platform/chromium-win/fast/blockflow/box-shadow-vertical-lr-expected.txt:
- platform/chromium-win/fast/text/delete-hard-break-character-expected.checksum:
- platform/chromium-win/fast/text/delete-hard-break-character-expected.png:
- platform/chromium/test_expectations.txt:
- platform/mac/editing/pasteboard/4806874-expected.checksum:
- platform/mac/editing/pasteboard/4806874-expected.png:
- platform/mac/editing/pasteboard/4944770-1-expected.checksum:
- platform/mac/editing/pasteboard/4944770-1-expected.png:
- platform/mac/editing/pasteboard/input-field-1-expected.checksum:
- platform/mac/editing/pasteboard/input-field-1-expected.png:
- platform/mac/editing/selection/4397952-expected.checksum:
- platform/mac/editing/selection/4397952-expected.png:
- platform/mac/editing/selection/caret-before-select-expected.checksum:
- platform/mac/editing/selection/caret-before-select-expected.png:
- platform/mac/editing/selection/extend-by-word-002-expected.checksum:
- platform/mac/editing/selection/extend-by-word-002-expected.png:
- platform/mac/editing/selection/select-element-paragraph-boundary-expected.checksum:
- platform/mac/editing/selection/select-element-paragraph-boundary-expected.png:
- 11:02 PM Changeset in webkit [71608] by
-
- 10 edits in trunk
2010-11-08 James Simonsen <simonjam@chromium.org>
Reviewed by Dimitri Glazkov.
[Web Timing] Split domContentLoaded into start/end
https://bugs.webkit.org/show_bug.cgi?id=48920
- fast/dom/script-tests/webtiming.js: (checkTimingBeforeLoad): (checkTimingWhileDeferred): (checkWebTimingOnDOMContentLoaded): Added. (checkWebTimingWhileAsync): (checkWebTimingOnLoad): (checkWebTimingAfterLoad):
- fast/dom/webtiming-document-open-expected.txt:
- fast/dom/webtiming-expected.txt:
2010-11-08 James Simonsen <simonjam@chromium.org>
Reviewed by Dimitri Glazkov.
[Web Timing] Split domContentLoaded into start/end
https://bugs.webkit.org/show_bug.cgi?id=48920
- dom/Document.cpp: (WebCore::Document::finishedParsing):
- dom/DocumentTiming.h: (WebCore::DocumentTiming::DocumentTiming):
- page/Timing.cpp: (WebCore::Timing::domContentLoadedStart): (WebCore::Timing::domContentLoadedEnd):
- page/Timing.h:
- page/Timing.idl:
- 10:19 PM Changeset in webkit [71607] by
-
- 2 edits in trunk/BugsSite
2010-11-08 Adam Barth <abarth@webkit.org>
Update help text to match behavior change.
- code-review.js:
- 10:15 PM Changeset in webkit [71606] by
-
- 2 edits in trunk/WebCore
2010-11-08 Nate Chapin <Nate Chapin>
Reviewed by Adam Barth.
Call ApplicationCacheHost::maybeLoadResource() in
ResourceLoader::start() instead of ResourceLoader::load().
maybeLoadResource() might mutate the ResourceRequest, and
in its current location any modifications are lost.
Fixes a couple of http/tests/appcache tests
failing on chromium.
- loader/ResourceLoader.cpp: (WebCore::ResourceLoader::load): (WebCore::ResourceLoader::start):
- 9:23 PM Changeset in webkit [71605] by
-
- 4 edits in trunk
2010-11-08 Chang Shu <chang.shu@nokia.com>
Reviewed by Antonio Gomes.
Unskip test that is passing now.
https://bugs.webkit.org/show_bug.cgi?id=49150
- platform/gtk/Skipped:
2010-11-08 Chang Shu <chang.shu@nokia.com>
Reviewed by Antonio Gomes.
[GTK] Use Space to toggle arrow key handling for selection change or
spatial navigation. Put the logic in common code to pass both Qt and
GTK. Mac won't work because arrow keys trigger the popup.
https://bugs.webkit.org/show_bug.cgi?id=49150
Existing test: fast/events/spatial-navigation/snav-single-select.html
- dom/SelectElement.cpp: (WebCore::SelectElement::menuListDefaultEventHandler):
- 9:05 PM Changeset in webkit [71604] by
-
- 7 edits in trunk
2010-11-08 Nicolas Dufresne <nicolas.dufresne@collabora.co.uk>
Reviewed by Martin Robinson.
[GTK] Link with target name set does not work
https://bugs.webkit.org/show_bug.cgi?id=48865
When a new page is created with a name (target=myFrame), the new
mainFrame could not be found because they where not stored in the
same PageGroup. As PageGroup are not exposed externally so the
simpliest solution is to use a global page group name. This also fixes
issue with visited link coloration across pages. After this change the
private function webkit_web_view_set_group_name() was no longer used
so it was removed completly.
- WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::closeWindowSoon):
- WebCoreSupport/InspectorClientGtk.cpp: (WebKit::InspectorClient::openInspectorFrontend):
- webkit/webkitprivate.h:
- webkit/webkitwebview.cpp: (webkit_web_view_init):
2010-11-08 Nicolas Dufresne <nicolas.dufresne@collabora.co.uk>
Reviewed by Martin Robinson.
[GTK] Link with target name set does not work
https://bugs.webkit.org/show_bug.cgi?id=48865
When a new page is created with a name (target=myFrame), the new
mainFrame could not be found because they where not stored in the
same PageGroup. As PageGroup are not exposed externally so the
simpliest solution is to use a global page group name. This also fixes
issue with visited link coloration across pages. After this change the
private function webkit_web_view_set_group_name() was no longer used
so it was removed completly.
- DumpRenderTree/gtk/DumpRenderTree.cpp: (createWebView):
- 8:47 PM Changeset in webkit [71603] by
-
- 2 edits in trunk/WebCore
2010-11-08 Jenn Braithwaite <jennb@chromium.org>
Reviewed by Pavel Feldman.
_bindResourceURL in ResourceManager.js may not add resource to map
https://bugs.webkit.org/show_bug.cgi?id=49088
No new tests. pfeldman working on better test harness and tests.
- inspector/front-end/ResourceManager.js: (WebInspector.ResourceManager.prototype._bindResourceURL):
- 8:14 PM Changeset in webkit [71602] by
-
- 12 edits1 add in trunk
2010-11-08 John Knottenbelt <jknotten@chromium.org>
Reviewed by Steve Block.
Convert to and from DOMTimeStamp with converter functions.
This is a refactoring only, covered by existing layout tests.
https://bugs.webkit.org/show_bug.cgi?id=49066
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- dom/DOMTimeStamp.h: Added. (WebCore::convertSecondsToDOMTimeStamp): (WebCore::convertDOMTimeStampToSeconds):
- dom/Event.cpp: (WebCore::Event::Event):
- dom/Event.h:
- page/Geolocation.cpp: (WebCore::Geolocation::haveSuitableCachedPosition):
- platform/android/GeolocationServiceAndroid.cpp: (WebCore::GeolocationServiceAndroid::isPositionMoreTimely):
2010-11-08 John Knottenbelt <jknotten@chromium.org>
Reviewed by Steve Block.
Convert to and from DOMTimeStamp with converter functions
https://bugs.webkit.org/show_bug.cgi?id=49066
- src/WebDataSourceImpl.cpp: (WebKit::WebDataSourceImpl::triggeringEventTime):
- 8:14 PM Changeset in webkit [71601] by
-
- 238 edits in trunk/LayoutTests
2010-11-08 Ryosuke Niwa <rniwa@webkit.org>
Unreviewed. Rebaselines for r71589.
- platform/chromium-linux/editing/deleting/5156801-2-expected.checksum:
- platform/chromium-linux/editing/deleting/5156801-2-expected.png:
- platform/chromium-linux/editing/deleting/delete-3608445-fix-expected.checksum:
- platform/chromium-linux/editing/deleting/delete-3608445-fix-expected.png:
- platform/chromium-linux/editing/deleting/delete-br-002-expected.checksum:
- platform/chromium-linux/editing/deleting/delete-br-002-expected.png:
- platform/chromium-linux/editing/deleting/delete-br-004-expected.checksum:
- platform/chromium-linux/editing/deleting/delete-br-004-expected.png:
- platform/chromium-linux/editing/deleting/delete-br-005-expected.checksum:
- platform/chromium-linux/editing/deleting/delete-br-005-expected.png:
- platform/chromium-linux/editing/deleting/delete-line-003-expected.checksum:
- platform/chromium-linux/editing/deleting/delete-line-003-expected.png:
- platform/chromium-linux/editing/deleting/delete-tab-004-expected.checksum:
- platform/chromium-linux/editing/deleting/delete-tab-004-expected.png:
- platform/chromium-linux/editing/deleting/delete-trailing-ws-002-expected.checksum:
- platform/chromium-linux/editing/deleting/delete-trailing-ws-002-expected.png:
- platform/chromium-linux/editing/execCommand/5482023-expected.checksum:
- platform/chromium-linux/editing/execCommand/5482023-expected.png:
- platform/chromium-linux/editing/inserting/4960120-2-expected.checksum:
- platform/chromium-linux/editing/inserting/4960120-2-expected.png:
- platform/chromium-linux/editing/inserting/5549929-2-expected.checksum:
- platform/chromium-linux/editing/inserting/5549929-2-expected.png:
- platform/chromium-linux/editing/inserting/5549929-3-expected.checksum:
- platform/chromium-linux/editing/inserting/5549929-3-expected.png:
- platform/chromium-linux/editing/inserting/editable-inline-element-expected.checksum:
- platform/chromium-linux/editing/inserting/editable-inline-element-expected.png:
- platform/chromium-linux/editing/inserting/insert-3654864-fix-expected.checksum:
- platform/chromium-linux/editing/inserting/insert-3654864-fix-expected.png:
- platform/chromium-linux/editing/inserting/insert-3775316-fix-expected.checksum:
- platform/chromium-linux/editing/inserting/insert-3775316-fix-expected.png:
- platform/chromium-linux/editing/inserting/insert-3786362-fix-expected.checksum:
- platform/chromium-linux/editing/inserting/insert-3786362-fix-expected.png:
- platform/chromium-linux/editing/inserting/insert-3800346-fix-expected.checksum:
- platform/chromium-linux/editing/inserting/insert-3800346-fix-expected.png:
- platform/chromium-linux/editing/inserting/insert-br-001-expected.checksum:
- platform/chromium-linux/editing/inserting/insert-br-001-expected.png:
- platform/chromium-linux/editing/inserting/insert-br-002-expected.checksum:
- platform/chromium-linux/editing/inserting/insert-br-002-expected.png:
- platform/chromium-linux/editing/inserting/insert-br-003-expected.checksum:
- platform/chromium-linux/editing/inserting/insert-br-003-expected.png:
- platform/chromium-linux/editing/inserting/insert-br-004-expected.checksum:
- platform/chromium-linux/editing/inserting/insert-br-004-expected.png:
- platform/chromium-linux/editing/inserting/insert-br-005-expected.checksum:
- platform/chromium-linux/editing/inserting/insert-br-005-expected.png:
- platform/chromium-linux/editing/inserting/insert-br-006-expected.checksum:
- platform/chromium-linux/editing/inserting/insert-br-006-expected.png:
- platform/chromium-linux/editing/inserting/insert-br-007-expected.checksum:
- platform/chromium-linux/editing/inserting/insert-br-007-expected.png:
- platform/chromium-linux/editing/inserting/insert-br-008-expected.checksum:
- platform/chromium-linux/editing/inserting/insert-br-008-expected.png:
- platform/chromium-linux/editing/inserting/insert-br-009-expected.checksum:
- platform/chromium-linux/editing/inserting/insert-br-009-expected.png:
- platform/chromium-linux/editing/inserting/insert-br-at-tabspan-001-expected.checksum:
- platform/chromium-linux/editing/inserting/insert-br-at-tabspan-001-expected.png:
- platform/chromium-linux/editing/inserting/insert-br-at-tabspan-002-expected.checksum:
- platform/chromium-linux/editing/inserting/insert-br-at-tabspan-002-expected.png:
- platform/chromium-linux/editing/inserting/insert-br-at-tabspan-003-expected.checksum:
- platform/chromium-linux/editing/inserting/insert-br-at-tabspan-003-expected.png:
- platform/chromium-linux/editing/inserting/insert-tab-004-expected.checksum:
- platform/chromium-linux/editing/inserting/insert-tab-004-expected.png:
- platform/chromium-linux/editing/inserting/insert-text-with-newlines-expected.checksum:
- platform/chromium-linux/editing/inserting/insert-text-with-newlines-expected.png:
- platform/chromium-linux/editing/inserting/line-break-expected.checksum:
- platform/chromium-linux/editing/inserting/line-break-expected.png:
- platform/chromium-linux/editing/inserting/paragraph-separator-in-table-1-expected.checksum:
- platform/chromium-linux/editing/inserting/paragraph-separator-in-table-1-expected.png:
- platform/chromium-linux/editing/inserting/paragraph-separator-in-table-2-expected.checksum:
- platform/chromium-linux/editing/inserting/paragraph-separator-in-table-2-expected.png:
- platform/chromium-linux/editing/inserting/typing-003-expected.checksum:
- platform/chromium-linux/editing/inserting/typing-003-expected.png:
- platform/chromium-linux/editing/inserting/typing-around-br-001-expected.checksum:
- platform/chromium-linux/editing/inserting/typing-around-br-001-expected.png:
- platform/chromium-linux/editing/pasteboard/4989774-expected.checksum:
- platform/chromium-linux/editing/pasteboard/4989774-expected.png:
- platform/chromium-linux/editing/pasteboard/5028447-expected.checksum:
- platform/chromium-linux/editing/pasteboard/5028447-expected.png:
- platform/chromium-linux/editing/pasteboard/5601583-1-expected.checksum:
- platform/chromium-linux/editing/pasteboard/5601583-1-expected.png:
- platform/chromium-linux/editing/pasteboard/merge-end-1-expected.checksum:
- platform/chromium-linux/editing/pasteboard/merge-end-1-expected.png:
- platform/chromium-linux/editing/pasteboard/merge-end-2-expected.checksum:
- platform/chromium-linux/editing/pasteboard/merge-end-2-expected.png:
- platform/chromium-linux/editing/pasteboard/paste-4035648-fix-expected.checksum:
- platform/chromium-linux/editing/pasteboard/paste-4035648-fix-expected.png:
- platform/chromium-linux/editing/pasteboard/paste-blockquote-into-blockquote-3-expected.checksum:
- platform/chromium-linux/editing/pasteboard/paste-blockquote-into-blockquote-3-expected.png:
- platform/chromium-linux/editing/pasteboard/paste-line-endings-001-expected.checksum:
- platform/chromium-linux/editing/pasteboard/paste-line-endings-001-expected.png:
- platform/chromium-linux/editing/pasteboard/paste-line-endings-006-expected.checksum:
- platform/chromium-linux/editing/pasteboard/paste-line-endings-006-expected.png:
- platform/chromium-linux/editing/pasteboard/paste-table-003-expected.checksum:
- platform/chromium-linux/editing/pasteboard/paste-table-003-expected.png:
- platform/chromium-linux/editing/pasteboard/paste-text-010-expected.checksum:
- platform/chromium-linux/editing/pasteboard/paste-text-010-expected.png:
- platform/chromium-linux/editing/selection/5007143-2-expected.checksum:
- platform/chromium-linux/editing/selection/5007143-2-expected.png:
- platform/chromium-linux/editing/selection/5007143-expected.checksum:
- platform/chromium-linux/editing/selection/5007143-expected.png:
- platform/chromium-linux/editing/selection/5234383-2-expected.checksum:
- platform/chromium-linux/editing/selection/5234383-2-expected.png:
- platform/chromium-linux/editing/selection/editable-html-element-expected.checksum:
- platform/chromium-linux/editing/selection/editable-html-element-expected.png:
- platform/chromium-linux/editing/selection/move-3875618-fix-expected.checksum:
- platform/chromium-linux/editing/selection/move-3875618-fix-expected.png:
- platform/chromium-linux/editing/selection/move-backwords-by-word-001-expected.checksum:
- platform/chromium-linux/editing/selection/move-backwords-by-word-001-expected.png:
- platform/chromium-linux/editing/selection/move-by-character-002-expected.checksum:
- platform/chromium-linux/editing/selection/move-by-character-002-expected.png:
- platform/chromium-linux/editing/selection/move-by-character-003-expected.checksum:
- platform/chromium-linux/editing/selection/move-by-character-003-expected.png:
- platform/chromium-linux/editing/selection/move-past-trailing-space-expected.checksum:
- platform/chromium-linux/editing/selection/move-past-trailing-space-expected.png:
- platform/chromium-linux/editing/selection/selection-3748164-fix-expected.checksum:
- platform/chromium-linux/editing/selection/selection-3748164-fix-expected.png:
- platform/chromium-linux/editing/unsupported-content/table-delete-001-expected.checksum:
- platform/chromium-linux/editing/unsupported-content/table-delete-001-expected.png:
- platform/chromium-linux/editing/unsupported-content/table-delete-003-expected.checksum:
- platform/chromium-linux/editing/unsupported-content/table-delete-003-expected.png:
- platform/chromium-win/editing/deleting/5156801-2-expected.checksum:
- platform/chromium-win/editing/deleting/5156801-2-expected.png:
- platform/chromium-win/editing/deleting/delete-3608445-fix-expected.checksum:
- platform/chromium-win/editing/deleting/delete-3608445-fix-expected.png:
- platform/chromium-win/editing/deleting/delete-br-002-expected.checksum:
- platform/chromium-win/editing/deleting/delete-br-002-expected.png:
- platform/chromium-win/editing/deleting/delete-br-004-expected.checksum:
- platform/chromium-win/editing/deleting/delete-br-004-expected.png:
- platform/chromium-win/editing/deleting/delete-br-005-expected.checksum:
- platform/chromium-win/editing/deleting/delete-br-005-expected.png:
- platform/chromium-win/editing/deleting/delete-line-003-expected.checksum:
- platform/chromium-win/editing/deleting/delete-line-003-expected.png:
- platform/chromium-win/editing/deleting/delete-tab-004-expected.checksum:
- platform/chromium-win/editing/deleting/delete-tab-004-expected.png:
- platform/chromium-win/editing/deleting/delete-trailing-ws-002-expected.checksum:
- platform/chromium-win/editing/deleting/delete-trailing-ws-002-expected.png:
- platform/chromium-win/editing/execCommand/5482023-expected.checksum:
- platform/chromium-win/editing/execCommand/5482023-expected.png:
- platform/chromium-win/editing/inserting/4960120-2-expected.checksum:
- platform/chromium-win/editing/inserting/4960120-2-expected.png:
- platform/chromium-win/editing/inserting/5549929-2-expected.checksum:
- platform/chromium-win/editing/inserting/5549929-2-expected.png:
- platform/chromium-win/editing/inserting/5549929-3-expected.checksum:
- platform/chromium-win/editing/inserting/5549929-3-expected.png:
- platform/chromium-win/editing/inserting/editable-inline-element-expected.checksum:
- platform/chromium-win/editing/inserting/editable-inline-element-expected.png:
- platform/chromium-win/editing/inserting/insert-3654864-fix-expected.checksum:
- platform/chromium-win/editing/inserting/insert-3654864-fix-expected.png:
- platform/chromium-win/editing/inserting/insert-3775316-fix-expected.checksum:
- platform/chromium-win/editing/inserting/insert-3775316-fix-expected.png:
- platform/chromium-win/editing/inserting/insert-3786362-fix-expected.checksum:
- platform/chromium-win/editing/inserting/insert-3786362-fix-expected.png:
- platform/chromium-win/editing/inserting/insert-3800346-fix-expected.checksum:
- platform/chromium-win/editing/inserting/insert-3800346-fix-expected.png:
- platform/chromium-win/editing/inserting/insert-br-001-expected.checksum:
- platform/chromium-win/editing/inserting/insert-br-001-expected.png:
- platform/chromium-win/editing/inserting/insert-br-002-expected.checksum:
- platform/chromium-win/editing/inserting/insert-br-002-expected.png:
- platform/chromium-win/editing/inserting/insert-br-003-expected.checksum:
- platform/chromium-win/editing/inserting/insert-br-003-expected.png:
- platform/chromium-win/editing/inserting/insert-br-004-expected.checksum:
- platform/chromium-win/editing/inserting/insert-br-004-expected.png:
- platform/chromium-win/editing/inserting/insert-br-005-expected.checksum:
- platform/chromium-win/editing/inserting/insert-br-005-expected.png:
- platform/chromium-win/editing/inserting/insert-br-006-expected.checksum:
- platform/chromium-win/editing/inserting/insert-br-006-expected.png:
- platform/chromium-win/editing/inserting/insert-br-007-expected.checksum:
- platform/chromium-win/editing/inserting/insert-br-007-expected.png:
- platform/chromium-win/editing/inserting/insert-br-008-expected.checksum:
- platform/chromium-win/editing/inserting/insert-br-008-expected.png:
- platform/chromium-win/editing/inserting/insert-br-009-expected.checksum:
- platform/chromium-win/editing/inserting/insert-br-009-expected.png:
- platform/chromium-win/editing/inserting/insert-br-at-tabspan-001-expected.checksum:
- platform/chromium-win/editing/inserting/insert-br-at-tabspan-001-expected.png:
- platform/chromium-win/editing/inserting/insert-br-at-tabspan-002-expected.checksum:
- platform/chromium-win/editing/inserting/insert-br-at-tabspan-002-expected.png:
- platform/chromium-win/editing/inserting/insert-br-at-tabspan-003-expected.checksum:
- platform/chromium-win/editing/inserting/insert-br-at-tabspan-003-expected.png:
- platform/chromium-win/editing/inserting/insert-tab-004-expected.checksum:
- platform/chromium-win/editing/inserting/insert-tab-004-expected.png:
- platform/chromium-win/editing/inserting/insert-text-with-newlines-expected.checksum:
- platform/chromium-win/editing/inserting/insert-text-with-newlines-expected.png:
- platform/chromium-win/editing/inserting/line-break-expected.checksum:
- platform/chromium-win/editing/inserting/line-break-expected.png:
- platform/chromium-win/editing/inserting/paragraph-separator-in-table-1-expected.checksum:
- platform/chromium-win/editing/inserting/paragraph-separator-in-table-1-expected.png:
- platform/chromium-win/editing/inserting/paragraph-separator-in-table-2-expected.checksum:
- platform/chromium-win/editing/inserting/paragraph-separator-in-table-2-expected.png:
- platform/chromium-win/editing/inserting/typing-003-expected.checksum:
- platform/chromium-win/editing/inserting/typing-003-expected.png:
- platform/chromium-win/editing/inserting/typing-around-br-001-expected.checksum:
- platform/chromium-win/editing/inserting/typing-around-br-001-expected.png:
- platform/chromium-win/editing/pasteboard/4989774-expected.checksum:
- platform/chromium-win/editing/pasteboard/4989774-expected.png:
- platform/chromium-win/editing/pasteboard/5028447-expected.checksum:
- platform/chromium-win/editing/pasteboard/5028447-expected.png:
- platform/chromium-win/editing/pasteboard/5601583-1-expected.checksum:
- platform/chromium-win/editing/pasteboard/5601583-1-expected.png:
- platform/chromium-win/editing/pasteboard/merge-end-1-expected.checksum:
- platform/chromium-win/editing/pasteboard/merge-end-1-expected.png:
- platform/chromium-win/editing/pasteboard/merge-end-2-expected.checksum:
- platform/chromium-win/editing/pasteboard/merge-end-2-expected.png:
- platform/chromium-win/editing/pasteboard/paste-4035648-fix-expected.checksum:
- platform/chromium-win/editing/pasteboard/paste-4035648-fix-expected.png:
- platform/chromium-win/editing/pasteboard/paste-blockquote-into-blockquote-3-expected.checksum:
- platform/chromium-win/editing/pasteboard/paste-blockquote-into-blockquote-3-expected.png:
- platform/chromium-win/editing/pasteboard/paste-line-endings-001-expected.checksum:
- platform/chromium-win/editing/pasteboard/paste-line-endings-001-expected.png:
- platform/chromium-win/editing/pasteboard/paste-line-endings-006-expected.checksum:
- platform/chromium-win/editing/pasteboard/paste-line-endings-006-expected.png:
- platform/chromium-win/editing/pasteboard/paste-table-003-expected.checksum:
- platform/chromium-win/editing/pasteboard/paste-table-003-expected.png:
- platform/chromium-win/editing/pasteboard/paste-text-010-expected.checksum:
- platform/chromium-win/editing/pasteboard/paste-text-010-expected.png:
- platform/chromium-win/editing/selection/5007143-2-expected.checksum:
- platform/chromium-win/editing/selection/5007143-2-expected.png:
- platform/chromium-win/editing/selection/5007143-expected.checksum:
- platform/chromium-win/editing/selection/5007143-expected.png:
- platform/chromium-win/editing/selection/5234383-2-expected.checksum:
- platform/chromium-win/editing/selection/5234383-2-expected.png:
- platform/chromium-win/editing/selection/editable-html-element-expected.checksum:
- platform/chromium-win/editing/selection/editable-html-element-expected.png:
- platform/chromium-win/editing/selection/extend-selection-expected.txt:
- platform/chromium-win/editing/selection/move-3875618-fix-expected.checksum:
- platform/chromium-win/editing/selection/move-3875618-fix-expected.png:
- platform/chromium-win/editing/selection/move-backwords-by-word-001-expected.checksum:
- platform/chromium-win/editing/selection/move-backwords-by-word-001-expected.png:
- platform/chromium-win/editing/selection/move-by-character-002-expected.checksum:
- platform/chromium-win/editing/selection/move-by-character-002-expected.png:
- platform/chromium-win/editing/selection/move-by-character-003-expected.checksum:
- platform/chromium-win/editing/selection/move-by-character-003-expected.png:
- platform/chromium-win/editing/selection/move-past-trailing-space-expected.checksum:
- platform/chromium-win/editing/selection/move-past-trailing-space-expected.png:
- platform/chromium-win/editing/selection/selection-3748164-fix-expected.checksum:
- platform/chromium-win/editing/selection/selection-3748164-fix-expected.png:
- platform/chromium-win/editing/unsupported-content/table-delete-001-expected.checksum:
- platform/chromium-win/editing/unsupported-content/table-delete-001-expected.png:
- platform/chromium-win/editing/unsupported-content/table-delete-003-expected.checksum:
- platform/chromium-win/editing/unsupported-content/table-delete-003-expected.png:
- 7:41 PM Changeset in webkit [71600] by
-
- 11 edits in trunk/WebKit2
2010-11-08 Kenneth Rohde Christiansen <kenneth@webkit.org>
Reviewed by Andreas Kling.
Send page scroll requests to the PageClient when scroll delegation is turned on
https://bugs.webkit.org/show_bug.cgi?id=49171
Implement the IPC and API required for making scroll delegation work
with WebKit2. This is only used when you have tiling enabled.
- UIProcess/API/qt/qwkpage.cpp: (QWKPagePrivate::pageDidRequestScroll):
- UIProcess/API/qt/qwkpage.h:
- UIProcess/API/qt/qwkpage_p.h:
- UIProcess/PageClient.h:
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::pageDidRequestScroll):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::delegatedScrollRequested):
- WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::pageDidRequestScroll):
- WebProcess/WebPage/WebPage.h:
- 7:24 PM Changeset in webkit [71599] by
-
- 2 edits in trunk/WebKit2
<rdar://problem/8531943> Enable partial symbolication for sandbox violations in WebProcess.
Patch by Ivan Krstić <ike@apple.com> on 2010-11-08
Reviewed by Mark Rowe.
- WebProcess/com.apple.WebProcess.sb:
- 7:19 PM Changeset in webkit [71598] by
-
- 2 edits in trunk/WebCore
2010-11-08 Ryosuke Niwa <rniwa@webkit.org>
Unreviewed build fix for Chromium Mac for r71590.
- platform/graphics/mac/ComplexTextControllerCoreText.cpp: (WebCore::provideStringAndAttributes):
- 7:04 PM Changeset in webkit [71597] by
-
- 2 edits in trunk/WebKitTools
2010-11-08 John Knottenbelt <jknotten@chromium.org>
Reviewed by Kent Tamura.
WebViewHost::reset() uses placement new.
https://bugs.webkit.org/show_bug.cgi?id=49069
WebViewHost is using placement destruction / new to simulate a fresh
WebViewHost object at the same address. This is because the WebView remains
open across tests and maintains a pointer to the WebViewHost.
This change resets member variables explictly instead of the placement new dance.
- DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::WebViewHost): (WebViewHost::reset):
- 6:48 PM Changeset in webkit [71596] by
-
- 4 edits in trunk/WebKit2
2010-11-08 Juha Savolainen <juha.savolainen@weego.fi>
Reviewed by Andreas Kling.
[Qt] Added new methods to QWKHistory and made QWKHistoryItemPrivate to shared object.
https://bugs.webkit.org/show_bug.cgi?id=49063
Added more functionality to the QWKHistory and changed QWKHistoryItemPrivate to shared object.
This is needed because we cannot delete the QWKHistoryItemPrivate pointer in destructor of QWKHistoryItem,
there may have other history instances which share same private implementation.
- UIProcess/API/qt/qwkhistory.cpp: (QWKHistoryItemPrivate::~QWKHistoryItemPrivate): (QWKHistoryItem::QWKHistoryItem): (QWKHistoryItem::QWKHistoryItem::operator=): (QWKHistory::currentItem): Added (QWKHistory::backItem): Added (QWKHistory::forwardItem): Added (QWKHistory::itemAt): Added (QWKHistory::backItems): Added (QWKHistory::forwardItems): Added
- UIProcess/API/qt/qwkhistory.h:
- UIProcess/API/qt/qwkhistory_p.h:
- 6:45 PM Changeset in webkit [71595] by
-
- 6 edits2 adds21 deletes in trunk/LayoutTests
2010-11-08 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Kent Tamura.
dump-as-markup conversion: editing/inserting/5607069-2.html and 5607069-3.html
https://bugs.webkit.org/show_bug.cgi?id=49223
Converted editing/inserting/5607069-2.html and editing/inserting/5607069-3.html
to dump-as-markup tests. Re-enabled them on Qt, Gtk, and Chromium platforms.
- editing/inserting/5607069-2-expected.txt: Added.
- editing/inserting/5607069-2.html:
- editing/inserting/5607069-3-expected.txt: Added.
- editing/inserting/5607069-3.html:
- platform/chromium-linux/editing/inserting/5607069-2-expected.checksum: Removed.
- platform/chromium-linux/editing/inserting/5607069-2-expected.png: Removed.
- platform/chromium-linux/editing/inserting/5607069-2-expected.txt: Removed.
- platform/chromium-linux/editing/inserting/5607069-3-expected.checksum: Removed.
- platform/chromium-linux/editing/inserting/5607069-3-expected.png: Removed.
- platform/chromium-win/editing/inserting/5607069-2-expected.checksum: Removed.
- platform/chromium-win/editing/inserting/5607069-2-expected.png: Removed.
- platform/chromium-win/editing/inserting/5607069-2-expected.txt: Removed.
- platform/chromium-win/editing/inserting/5607069-3-expected.checksum: Removed.
- platform/chromium-win/editing/inserting/5607069-3-expected.png: Removed.
- platform/chromium-win/editing/inserting/5607069-3-expected.txt: Removed.
- platform/chromium/test_expectations.txt:
- platform/gtk/Skipped:
- platform/mac-leopard/editing/inserting/5607069-2-expected.checksum: Removed.
- platform/mac-leopard/editing/inserting/5607069-2-expected.png: Removed.
- platform/mac-leopard/editing/inserting/5607069-3-expected.checksum: Removed.
- platform/mac-leopard/editing/inserting/5607069-3-expected.png: Removed.
- platform/mac/editing/inserting/5607069-2-expected.checksum: Removed.
- platform/mac/editing/inserting/5607069-2-expected.png: Removed.
- platform/mac/editing/inserting/5607069-2-expected.txt: Removed.
- platform/mac/editing/inserting/5607069-3-expected.checksum: Removed.
- platform/mac/editing/inserting/5607069-3-expected.png: Removed.
- platform/mac/editing/inserting/5607069-3-expected.txt: Removed.
- platform/qt/Skipped:
- 6:32 PM Changeset in webkit [71594] by
-
- 6 edits in trunk
2010-11-08 Anton Muhin <antonm@chromium.org>
Reviewed by Nate Chapin.
[v8] Get rid of automatically generated named property getter for classes with namedItem method
https://bugs.webkit.org/show_bug.cgi?id=48770
- platform/chromium-mac/fast/dom/HTMLSelectElement/named-options-expected.txt:
- platform/chromium-win/fast/dom/HTMLSelectElement/named-options-expected.txt:
2010-11-08 Anton Muhin <antonm@chromium.org>
Reviewed by Nate Chapin.
[v8] Get rid of automatically generated named property getter for classes with namedItem method
https://bugs.webkit.org/show_bug.cgi?id=48770
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/v8/custom/V8HTMLSelectElementCustom.cpp:
- 6:15 PM Changeset in webkit [71593] by
-
- 2 edits in trunk/WebKit/qt
2010-11-08 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Andreas Kling.
[Qt] build error in WebKit/qt/Api/qwebpage.cpp in Qt 4.7.0
https://bugs.webkit.org/show_bug.cgi?id=47427
Add a missing guard in order to be able to compile when
ENABLE(TOUCH_EVENTS) is not defined.
- Api/qwebpage.cpp: (QWebPagePrivate::touchEvent):
- 6:08 PM Changeset in webkit [71592] by
-
- 10 edits46 adds in trunk/LayoutTests
Unreviewed, updating Chromium expectations.
- platform/chromium-linux/editing/selection/home-end-expected.txt: Added.
- platform/chromium-linux/fast/blockflow/horizontal-bt-replaced-selection-expected.checksum: Added.
- platform/chromium-linux/fast/blockflow/horizontal-bt-replaced-selection-expected.png: Added.
- platform/chromium-linux/fast/blockflow/japanese-ruby-horizontal-bt-expected.checksum: Added.
- platform/chromium-linux/fast/blockflow/japanese-ruby-horizontal-bt-expected.png: Added.
- platform/chromium-linux/fast/blockflow/japanese-ruby-horizontal-bt-expected.txt: Added.
- platform/chromium-linux/fast/blockflow/japanese-ruby-vertical-lr-expected.checksum: Added.
- platform/chromium-linux/fast/blockflow/japanese-ruby-vertical-lr-expected.png: Added.
- platform/chromium-linux/fast/blockflow/japanese-ruby-vertical-lr-expected.txt: Added.
- platform/chromium-linux/fast/blockflow/japanese-ruby-vertical-rl-expected.checksum: Added.
- platform/chromium-linux/fast/blockflow/japanese-ruby-vertical-rl-expected.png: Added.
- platform/chromium-linux/fast/blockflow/japanese-ruby-vertical-rl-expected.txt: Added.
- platform/chromium-linux/fast/blockflow/vertical-lr-replaced-selection-expected.checksum: Added.
- platform/chromium-linux/fast/blockflow/vertical-lr-replaced-selection-expected.png: Added.
- platform/chromium-linux/fast/blockflow/vertical-rl-replaced-selection-expected.checksum: Added.
- platform/chromium-linux/fast/blockflow/vertical-rl-replaced-selection-expected.png: Added.
- platform/chromium-mac/fast/blockflow/japanese-ruby-vertical-lr-expected.checksum: Added.
- platform/chromium-mac/fast/blockflow/japanese-ruby-vertical-lr-expected.png: Added.
- platform/chromium-mac/fast/blockflow/japanese-ruby-vertical-rl-expected.checksum: Added.
- platform/chromium-mac/fast/blockflow/japanese-ruby-vertical-rl-expected.png: Added.
- platform/chromium-mac/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.checksum: Added.
- platform/chromium-mac/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.png: Added.
- platform/chromium-mac/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.txt: Added.
- platform/chromium-mac/fast/text/international/bidi-neutral-run-expected.checksum: Added.
- platform/chromium-mac/fast/text/international/bidi-neutral-run-expected.png: Added.
- platform/chromium-mac/fast/text/international/bidi-neutral-run-expected.txt: Added.
- platform/chromium-win-xp/fast/blockflow/japanese-ruby-vertical-lr-expected.png: Added.
- platform/chromium-win-xp/fast/blockflow/japanese-ruby-vertical-rl-expected.png: Added.
- platform/chromium-win/editing/selection/home-end-expected.txt:
- platform/chromium-win/fast/blockflow/horizontal-bt-replaced-selection-expected.checksum: Added.
- platform/chromium-win/fast/blockflow/horizontal-bt-replaced-selection-expected.png: Added.
- platform/chromium-win/fast/blockflow/horizontal-bt-replaced-selection-expected.txt: Added.
- platform/chromium-win/fast/blockflow/japanese-ruby-horizontal-bt-expected.checksum: Added.
- platform/chromium-win/fast/blockflow/japanese-ruby-horizontal-bt-expected.png: Added.
- platform/chromium-win/fast/blockflow/japanese-ruby-horizontal-bt-expected.txt: Added.
- platform/chromium-win/fast/blockflow/japanese-ruby-vertical-lr-expected.checksum: Added.
- platform/chromium-win/fast/blockflow/japanese-ruby-vertical-lr-expected.png: Added.
- platform/chromium-win/fast/blockflow/japanese-ruby-vertical-lr-expected.txt: Added.
- platform/chromium-win/fast/blockflow/japanese-ruby-vertical-rl-expected.checksum: Added.
- platform/chromium-win/fast/blockflow/japanese-ruby-vertical-rl-expected.png: Added.
- platform/chromium-win/fast/blockflow/japanese-ruby-vertical-rl-expected.txt: Added.
- platform/chromium-win/fast/blockflow/vertical-lr-replaced-selection-expected.checksum: Added.
- platform/chromium-win/fast/blockflow/vertical-lr-replaced-selection-expected.png: Added.
- platform/chromium-win/fast/blockflow/vertical-lr-replaced-selection-expected.txt: Added.
- platform/chromium-win/fast/blockflow/vertical-rl-replaced-selection-expected.checksum: Added.
- platform/chromium-win/fast/blockflow/vertical-rl-replaced-selection-expected.png: Added.
- platform/chromium-win/fast/blockflow/vertical-rl-replaced-selection-expected.txt: Added.
- platform/chromium-win/fast/css/text-overflow-ellipsis-bidi-expected.txt:
- platform/chromium-win/fast/text/international/bidi-LDB-2-formatting-characters-expected.txt:
- platform/chromium-win/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.txt:
- platform/chromium-win/fast/text/international/bidi-explicit-embedding-expected.txt:
- platform/chromium-win/fast/text/international/bidi-ignored-for-first-child-inline-expected.txt:
- platform/chromium-win/fast/text/international/bidi-neutral-run-expected.txt:
- platform/chromium-win/fast/text/international/bidi-override-expected.txt:
- platform/chromium/test_expectations.txt:
- 5:54 PM Changeset in webkit [71591] by
-
- 16 edits3 copies1 add in trunk/WebKit2
Add WKDownloadClient API
https://bugs.webkit.org/show_bug.cgi?id=49227
Reviewed by Dan Bernstein.
- Shared/API/c/WKBase.h:
Add WKDownloadRef.
- UIProcess/API/C/WKAPICast.h:
Add WKDownloadRef <-> DownloadProxy mapping.
- UIProcess/API/C/WKContext.cpp:
(WKContextSetDownloadClient):
Initialize the download client.
- UIProcess/API/C/WKContext.h:
Add new WKContextDownloadClient API.
- UIProcess/API/C/WKDownload.cpp: Added.
- UIProcess/API/C/WKDownload.h:
Add WKDownload files.
- UIProcess/Downloads/DownloadProxy.cpp:
(WebKit::DownloadProxy::didStart):
(WebKit::DownloadProxy::didCreateDestination):
(WebKit::DownloadProxy::didFinish):
Call down to the the WebDownloadClient.
- UIProcess/Downloads/DownloadProxy.messages.in:
Rename DidBegin to DidStart.
- UIProcess/WebContext.cpp:
(WebKit::WebContext::initializeDownloadClient):
Initialize the download client.
- UIProcess/WebContext.h:
(WebKit::WebContext::downloadClient):
Add getter.
- UIProcess/WebDownloadClient.cpp:
(WebKit::WebDownloadClient::didStart):
(WebKit::WebDownloadClient::didCreateDestination):
(WebKit::WebDownloadClient::didFinish):
Call the relevant WKContextDownloadClient functions.
- WebKit2.pro:
- WebKit2.xcodeproj/project.pbxproj:
Add new files.
- WebProcess/Downloads/Download.cpp:
(WebKit::Download::didStart):
- WebProcess/Downloads/Download.h:
- WebProcess/Downloads/mac/DownloadMac.mm:
(-[WKDownloadAsDelegate downloadDidBegin:]):
Rename Download::didBegin to Download::didStart.
- win/WebKit2.vcproj:
Add new files.
- 5:53 PM Changeset in webkit [71590] by
-
- 7 edits in trunk
2010-11-08 Ned Holbrook <nholbrook@apple.com>
Reviewed by Adam Barth.
Avoid CFAttributedString creation in ComplexTextController by adopting UniChar provider SPI.
https://bugs.webkit.org/show_bug.cgi?id=48886
- WebCore.exp.in:
- platform/graphics/mac/ComplexTextControllerCoreText.cpp: (WebCore::provideStringAndAttributes): (WebCore::ComplexTextController::collectComplexTextRunsForCharactersCoreText):
- platform/mac/WebCoreSystemInterface.h:
- platform/mac/WebCoreSystemInterface.mm:
2010-11-08 Ned Holbrook <nholbrook@apple.com>
Reviewed by Adam Barth.
Avoid CFAttributedString creation in ComplexTextController by adopting UniChar provider SPI.
https://bugs.webkit.org/show_bug.cgi?id=48886
- WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface):
- 5:41 PM Changeset in webkit [71589] by
-
- 2 edits in trunk/WebCore
https://bugs.webkit.org/show_bug.cgi?id=49228
Reviewed by Simon Fraser.
REGRESSION: caret too short when a positive line height is specified. Now that lineTop no longer
accidentally incorporates the top leading, we need to use selectionTop/Bottom for the caret rect.
- rendering/RenderText.cpp:
(WebCore::RenderText::localCaretRect):
- 5:13 PM Changeset in webkit [71588] by
-
- 2 edits in trunk/LayoutTests
2010-11-08 Xiaomei Ji <xji@chromium.org>
Reviewed by Dan Bernstein.
Rebaesline for GTK after r71566
https://bugs.webkit.org/show_bug.cgi?id=25321
- platform/gtk/editing/selection/extend-selection-expected.txt:
- 5:05 PM Changeset in webkit [71587] by
-
- 6 edits in trunk
2010-11-08 Pierre-Antoine LaFayette <pierre.lafayette@gmail.com>
Reviewed by Darin Fisher.
[chromium] Adding hasUserGesture flag to the ResourceRequest
https://bugs.webkit.org/show_bug.cgi?id=37057
This flag is to be used on the browser side to indicate when a
download has been user initiated.
No new tests. This change will be tested through a browser UI test.
- platform/network/chromium/ResourceRequest.h: (WebCore::ResourceRequest::ResourceRequest): (WebCore::ResourceRequest::hasUserGesture): (WebCore::ResourceRequest::setHasUserGesture):
2010-11-08 Pierre-Antoine LaFayette <pierre.lafayette@gmail.com>
Reviewed by Darin Fisher.
[chromium] Adding hasUserGesture flag to the ResourceRequest
https://bugs.webkit.org/show_bug.cgi?id=37057
This flag is to be used on the browser side to indicate when a
download has been user initiated.
- public/WebURLRequest.h:
- src/WebURLRequest.cpp: (WebKit::WebURLRequest::hasUserGesture): (WebKit::WebURLRequest::setHasUserGesture):
- 4:48 PM Changeset in webkit [71586] by
-
- 5 edits in trunk/WebCore
2010-11-08 Chris Rogers <crogers@google.com>
Reviewed by Kenneth Russell.
Remove obsolete PASSTHROUGH and MATRIXMIX panner mode
https://bugs.webkit.org/show_bug.cgi?id=49087
No new tests since audio API is not yet implemented.
- platform/audio/Panner.cpp: (WebCore::Panner::create):
- platform/audio/Panner.h:
- webaudio/AudioPannerNode.h:
- webaudio/AudioPannerNode.idl:
- 4:42 PM Changeset in webkit [71585] by
-
- 19 edits2 moves in trunk/WebKit2
Part of https://bugs.webkit.org/show_bug.cgi?id=49222
Rename "WebContextMenuItem" to "WebContextMenuItemData"
Reviewed by Anders Carlsson.
- WebKit2.pro:
- WebKit2.xcodeproj/project.pbxproj:
- win/WebKit2.vcproj:
- Shared/WebContextMenuItem.cpp: Removed.
- Shared/WebContextMenuItem.h: Removed.
- Shared/WebContextMenuItemData.cpp: Copied from Shared/WebContextMenuItem.cpp.
(WebKit::WebContextMenuItemData::WebContextMenuItemData):
(WebKit::WebContextMenuItemData::encode):
(WebKit::WebContextMenuItemData::decode):
(WebKit::kitItems):
- Shared/WebContextMenuItemData.h: Copied from Shared/WebContextMenuItem.h.
(WebKit::WebContextMenuItemData::submenu):
- UIProcess/WebContextMenuProxy.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::showContextMenu):
(WebKit::WebPageProxy::contextMenuItemSelected):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- UIProcess/mac/WebContextMenuProxyMac.h:
- UIProcess/mac/WebContextMenuProxyMac.mm:
(-[WebMenuTarget forwardContextMenuAction:]):
(WebKit::WebContextMenuProxyMac::contextMenuItemSelected):
(WebKit::nsMenuItemVector):
(WebKit::WebContextMenuProxyMac::populate):
(WebKit::WebContextMenuProxyMac::showContextMenu):
- UIProcess/qt/WebContextMenuProxyQt.cpp:
(WebKit::WebContextMenuProxyQt::showContextMenu):
- UIProcess/qt/WebContextMenuProxyQt.h:
- UIProcess/win/WebContextMenuProxyWin.cpp:
(WebKit::WebContextMenuProxyWin::showContextMenu):
- UIProcess/win/WebContextMenuProxyWin.h:
- WebProcess/WebPage/WebContextMenu.cpp:
(WebKit::WebContextMenu::itemSelected):
- WebProcess/WebPage/WebContextMenu.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::didSelectItemFromActiveContextMenu):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
- 4:23 PM Changeset in webkit [71584] by
-
- 2 edits1 delete in trunk/WebCore
2010-11-08 Patrick Gansterer <Patrick Gansterer>
Reviewed by Adam Roben.
Merge EditorWinCE.cpp into EditorWin.cpp
https://bugs.webkit.org/show_bug.cgi?id=49095
- platform/win/EditorWin.cpp: (WebCore::Editor::newGeneralClipboard):
- platform/wince/EditorWinCE.cpp: Removed.
- 4:08 PM Changeset in webkit [71583] by
-
- 3 edits in trunk/WebKit2
Find in Page: scrolling the page with the scrollbar while overlay is up dismisses the overlay
https://bugs.webkit.org/show_bug.cgi?id=49219
<rdar://problem/8569550>
Reviewed by John Sullivan and Dan Bernstein.
- WebProcess/WebPage/FindPageOverlay.cpp:
(WebKit::FindPageOverlay::bounds):
Return the bounds of the find page overlay, excluding any scrollbars.
(WebKit::FindPageOverlay::drawRect):
Call bounds.
(WebKit::FindPageOverlay::mouseEvent):
Only dismiss the find UI if the mouse down event happens inside the overlay bounds.
- 3:59 PM Changeset in webkit [71582] by
-
- 6 edits in trunk
https://bugs.webkit.org/show_bug.cgi?id=49217
Reviewed by Simon Fraser.
Fix coordinate space mismatch in RenderReplaced and make sure RenderText retains its old behavior of
preferring later lines when there is overlap.
WebCore:
- rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::positionForPoint):
- rendering/RenderText.cpp:
(WebCore::RenderText::positionForPoint):
LayoutTests:
- fast/dom/Document/CaretRangeFromPoint/replace-element-expected.txt:
- fast/dom/Document/CaretRangeFromPoint/replace-element.html:
- 3:52 PM Changeset in webkit [71581] by
-
- 16 edits1 add in trunk/WebKit2
Add the ability to send messages to DownloadProxy objects
https://bugs.webkit.org/show_bug.cgi?id=49213
Reviewed by Adam Roben.
- DerivedSources.make:
- DerivedSources.pro:
Add Download.messages.in.
- Platform/CoreIPC/MessageID.h:
Add MessageClassDownloadProxy message class.
- Platform/CoreIPC/MessageSender.h:
Include Connection.h directly since it's required.
- UIProcess/Downloads/DownloadProxy.cpp:
(WebKit::DownloadProxy::didBegin):
(WebKit::DownloadProxy::didCreateDestination):
(WebKit::DownloadProxy::didFinish):
Add stubs.
- UIProcess/Downloads/DownloadProxy.messages.in: Added.
- UIProcess/WebContext.cpp:
(WebKit::WebContext::didReceiveMessage):
Handle DownloadProxy messages.
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::didReceiveMessage):
Hand DownloadProxy messages off to the context.
- WebKit2.pro:
- WebKit2.xcodeproj/project.pbxproj:
Add new files.
- WebProcess/Downloads/Download.cpp:
(WebKit::Download::didBegin):
(WebKit::Download::didReceiveData):
(WebKit::Download::didCreateDestination):
(WebKit::Download::didFinish):
Send messages.
- WebProcess/Downloads/mac/DownloadMac.mm:
(-[WKDownloadAsDelegate download:didCreateDestination:]):
Call Download::didCreateDestination.
- win/WebKit2.vcproj:
Add new files.
- 3:36 PM Changeset in webkit [71580] by
-
- 9 edits5 adds in trunk/WebKitTools
2010-11-08 Dirk Pranke <dpranke@chromium.org>
Reviewed by Eric Seidel.
Fix the webkit_base_dir logic in webkitpy/layout_tests/port/config.py.
It turns out that NRWT can't use the code in scm.find_checkout_root()
because the Chromium bots don't do full checkouts of the WebKit
tree; they only check out subdirectories like WebKitTools/Scripts.
Until we can figure out a better approach for this, I've
restored the base_dir-detecting code from NRWT, which works in
any directory tree, scm or no.
- WebKitTools/Scripts/webkitpy/layout_tests/port/config.py
- WebKitTools/Scripts/webkitpy/layout_tests/port/config_unittest.py
- 3:07 PM Changeset in webkit [71579] by
-
- 1 edit in trunk/WebCore/rendering/RenderObject.h
Fix build bustage.
- 2:52 PM Changeset in webkit [71578] by
-
- 4 edits in trunk/WebCore
2010-11-08 Steve Block <steveblock@google.com>
Reviewed by David Levin.
Building for Android generates several compiler warnings
https://bugs.webkit.org/show_bug.cgi?id=49175
Fixes these warnings, most of which are trivial.
- PREFIX_FOR_WEBCORE was previously required for STL's algorithm, but is no longer. See http://android.git.kernel.org/?p=platform/external/webkit.git;a=commit;h=a47ab5294213cca2741f453b450b02666e08cac8
- The definition of EXPORT is required only for the JNI entry point in WebKit/android, so does not need to be in WebCorePrefix.h
No new tests, fixes compile warnings only.
- WebCorePrefix.h:
- bridge/jni/jsc/JNIUtilityPrivate.cpp: (JSC::Bindings::convertValueToJValue):
- platform/android/FileSystemAndroid.cpp: (WebCore::listDirectory):
- 2:52 PM Changeset in webkit [71577] by
-
- 1 edit1 delete in trunk/LayoutTests
Unreviewed bot fix.
Removed a test that was added without results. Will add again later.
- compositing/layer-creation/many-layers.html: Removed.
- 2:48 PM Changeset in webkit [71576] by
-
- 3 edits2 adds in trunk
<rdar://problem/8119781> Crash zooming into Word document at office.live.com
https://bugs.webkit.org/show_bug.cgi?id=49203
Reviewed by Darin Adler.
WebCore:
Test: fast/css/zoom-change-triggering-layout.html
RenderBox::styleDidChange() was calling scrollLeft() and scrollTop(), whose RenderTextControlSingleLine
overrides can trigger layout.
- rendering/RenderBox.cpp:
(WebCore::RenderBox::styleDidChange): Use the layer directly for updating the scroll offsets when
the zoom factor changes.
LayoutTests:
- fast/css/zoom-change-triggering-layout-expected.txt: Added.
- fast/css/zoom-change-triggering-layout.html: Added.
- 2:43 PM Changeset in webkit [71575] by
-
- 1 edit2 moves in trunk/LayoutTests
Unreviewed rolling out r71567.
r71567 was incorrect, because fast/js/navigator-mimeTypes-length.html contains relative paths to js files.
- fast/js/navigator-mimeTypes-length-expected.txt: Copied from LayoutTests/plugins/navigator-mimeTypes-length-expected.txt.
- fast/js/navigator-mimeTypes-length.html: Copied from LayoutTests/plugins/navigator-mimeTypes-length.html.
- plugins/navigator-mimeTypes-length-expected.txt: Removed.
- plugins/navigator-mimeTypes-length.html: Removed.
- 2:39 PM Changeset in webkit [71574] by
-
- 9 edits2 copies1 add in trunk/WebKit2
Add DownloadProxy object
https://bugs.webkit.org/show_bug.cgi?id=49211
Reviewed by Adam Roben.
DownloadProxy will be the implementation of the forthcoming WKDownloadRef object.
- Shared/APIObject.h:
Add TypeDownload.
- UIProcess/Downloads/DownloadProxy.cpp:
(WebKit::generateDownloadID):
Generate a unique download ID.
(WebKit::DownloadProxy::invalidate):
Null out the web context.
- UIProcess/Downloads/DownloadProxy.h:
(WebKit::WebContext::processDidClose):
Invalidate all downloads.
(WebKit::WebContext::createDownloadProxy):
Create a WebDownload object.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::receivedPolicyDecision):
Call createDownloadProxy instead.
- WebKit2.pro:
- WebKit2.xcodeproj/project.pbxproj:
- win/WebKit2.vcproj:
Add new files.
- win/WebKit2Common.vsprops:
Add new include path.
- 2:28 PM Changeset in webkit [71573] by
-
- 2 edits in trunk/LayoutTests
2010-11-08 Stephen White <senorblanco@chromium.org>
Unreviewed; test expectations update.
Add a test missing results to chromium-gpu test expectations.
- platform/chromium-gpu/test_expectations.txt:
- 2:21 PM Changeset in webkit [71572] by
-
- 4 edits12 adds in trunk
https://bugs.webkit.org/show_bug.cgi?id=48587
Reviewed by Simon Fraser.
Make Ruby work with vertical text. Ruby already nearly does work. The only big issue I found was with
flipped lines writing modes. Make sure to mutate the writing-mode of the RenderRubyRun to ensure that
the ruby text is on the correct side of the ruby base.
Added fast/blockflow tests of the various writing modes.
WebCore:
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::baselinePosition):
(WebCore::RenderBlock::firstLineBoxBaseline):
(WebCore::RenderBlock::lastLineBoxBaseline):
- rendering/RenderRubyRun.cpp:
(WebCore::RenderRubyRun::staticCreateRubyRun):
LayoutTests:
- fast/blockflow/japanese-ruby-horizontal-bt.html: Added.
- fast/blockflow/japanese-ruby-vertical-lr.html: Added.
- fast/blockflow/japanese-ruby-vertical-rl.html: Added.
- platform/mac/fast/blockflow/japanese-ruby-horizontal-bt-expected.checksum: Added.
- platform/mac/fast/blockflow/japanese-ruby-horizontal-bt-expected.png: Added.
- platform/mac/fast/blockflow/japanese-ruby-horizontal-bt-expected.txt: Added.
- platform/mac/fast/blockflow/japanese-ruby-vertical-lr-expected.checksum: Added.
- platform/mac/fast/blockflow/japanese-ruby-vertical-lr-expected.png: Added.
- platform/mac/fast/blockflow/japanese-ruby-vertical-lr-expected.txt: Added.
- platform/mac/fast/blockflow/japanese-ruby-vertical-rl-expected.checksum: Added.
- platform/mac/fast/blockflow/japanese-ruby-vertical-rl-expected.png: Added.
- platform/mac/fast/blockflow/japanese-ruby-vertical-rl-expected.txt: Added.
- 2:19 PM Changeset in webkit [71571] by
-
- 5 edits in trunk/WebKitTools
2010-11-08 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
webkit-patch failure-reason explodes if a build is missing
https://bugs.webkit.org/show_bug.cgi?id=49195
This is likely a recent regression. Adding a unit test for this case.
- Scripts/webkitpy/common/net/buildbot.py:
- Scripts/webkitpy/common/net/buildbot_unittest.py:
- 2:18 PM Changeset in webkit [71570] by
-
- 3 edits in trunk/BugsSite
2010-11-08 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Restore normal meaning of double-click on patch review page?
https://bugs.webkit.org/show_bug.cgi?id=47641
After this patch, you need to click on the line numbers to add a
comment.
- PrettyPatch/PrettyPatch.rb:
- code-review.js:
- 2:10 PM Changeset in webkit [71569] by
-
- 3 edits in trunk/WebCore
Unreviewed build correction after @70369/@70846.
Please use PLATFORM(CG) to define CG-specific code, not
PLATFORM(CF).
- platform/image-decoders/ImageDecoder.cpp:
- platform/image-decoders/ImageDecoder.h:
- 1:52 PM Changeset in webkit [71568] by
-
- 3 edits2 adds in trunk
2010-11-08 James Robinson <jamesr@chromium.org>
Reviewed by Dimitri Glazkov.
Input element with inner spin button set to display:none causes crash
https://bugs.webkit.org/show_bug.cgi?id=49121
Adds a test for dispatching mouse events at an <input type="number"> with
the inner spin button set to display:none does not crash.
- fast/forms/input-number-spinbutton-crash-expected.txt: Added.
- fast/forms/input-number-spinbutton-crash.html: Added.
2010-11-08 James Robinson <jamesr@chromium.org>
Reviewed by Dimitri Glazkov.
Input element with inner spin button set to display:none causes crash
https://bugs.webkit.org/show_bug.cgi?id=49121
Null check the inner spin button's renderer before dereferencing it.
Test: fast/forms/input-number-spinbutton-crash.html
- rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::forwardEvent):
- 1:41 PM Changeset in webkit [71567] by
-
- 1 edit2 moves in trunk/LayoutTests
2010-11-08 Tony Chang <tony@chromium.org>
Unreviewed. Moving a plugin test into the plugins directory.
- plugins/navigator-mimeTypes-length-expected.txt: Renamed from LayoutTests/fast/js/navigator-mimeTypes-length-expected.txt.
- plugins/navigator-mimeTypes-length.html: Renamed from LayoutTests/fast/js/navigator-mimeTypes-length.html.
- 1:35 PM Changeset in webkit [71566] by
-
- 13 edits4 adds in trunk
2010-11-08 Xiaomei Ji <xji@chromium.org>
Reviewed by Dan Bernstein.
Fix Unicode explicit bidi control characters are removed in editing operations,
such as insert/copy/cut/paste.
https://bugs.webkit.org/show_bug.cgi?id=25321
Unicode explicit bidi control characters were excluded in BidiRun and
consequently from InlineTextBoxes due to their effect on rendering complex
text with ATSUI.
The fix is including those characters in BidiRun and remove them from
ComplexTextRun with ATSUI.
Test: editing/inserting/insert-paste-bidi-control.html
fast/text/atsui-bidi-control.html
- platform/graphics/mac/ComplexTextControllerATSUI.cpp: (WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun):
- platform/text/BidiResolver.h: (WebCore::::checkDirectionInLowerRaiseEmbeddingLevel): (WebCore::::lowerExplicitEmbeddingLevel): (WebCore::::raiseExplicitEmbeddingLevel): (WebCore::::createBidiRunsForLine):
2010-11-08 Xiaomei Ji <xji@chromium.org>
Reviewed by Dan Bernstein.
Fix Unicode explicit bidi control characters are removed in editing operations,
such as insert/copy/cut/paste.
https://bugs.webkit.org/show_bug.cgi?id=25321
Unicode explicit bidi control characters were excluded in BidiRun and
consequently from InlineTextBoxes due to their effect on rendering complex
text with ATSUI.
The fix is including those characters in BidiRun and remove them from
ComplexTextRun with ATSUI.
- editing/inserting/insert-paste-bidi-control-expected.txt: Added.
- editing/inserting/insert-paste-bidi-control.html: Added.
- editing/selection/extend-selection-expected.txt:
- editing/selection/home-end-expected.txt:
- fast/text/atsui-bidi-control-expected.txt: Added.
- fast/text/atsui-bidi-control.html: Added.
- platform/mac/fast/css/text-overflow-ellipsis-bidi-expected.txt:
- platform/mac/fast/text/international/bidi-LDB-2-formatting-characters-expected.txt:
- platform/mac/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.txt:
- platform/mac/fast/text/international/bidi-explicit-embedding-expected.txt:
- platform/mac/fast/text/international/bidi-ignored-for-first-child-inline-expected.txt:
- platform/mac/fast/text/international/bidi-neutral-run-expected.txt:
- platform/mac/fast/text/international/bidi-override-expected.txt:
- 1:21 PM Changeset in webkit [71565] by
-
- 3 edits in trunk/WebKit2
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=49201
Crash when closing a page
Handle null frame by passing a 0 frame id (normal ones start from 1).
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::focusedFrameChanged):
- WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::focusedFrameChanged):
- 1:20 PM Changeset in webkit [71564] by
-
- 2 edits in trunk/WebKit/mac
2010-11-08 Nate Chapin <Nate Chapin>
Unreviewed, build fix.
Clumsy typo in r71562.
- Plugins/Hosted/HostedNetscapePluginStream.mm: (WebKit::HostedNetscapePluginStream::start):
- 1:12 PM Changeset in webkit [71563] by
-
- 11 edits12 adds in trunk
https://bugs.webkit.org/show_bug.cgi?id=49126
Reviewed by Dan Bernstein.
RenderBlock::positionForPoint is not writing-mode aware. Patch the function to examine lines in the correct
writing-mode direction. Patched and renamed a number of helpers used by positionForPoint.
Fixed a bug with RenderReplaced's positionForPoint. There was a coordinate space mismatch between what the
function expected (local coordinates) and what was passed in (containing block coords), which meant the function didn't even work.
Fixed a bug with the propagation of selection state on RenderReplaced to its containing block. The bit double propagated
because both the base class function and the derived class function did the propagation, and the setter function did not
do the right thing if this happened.
Patched the localSelectionRect method on RenderReplaced so that selection draws in the right place in all writing modes.
Added new tests of positionForPoint and replaced elements in fast/blockflow.
WebCore:
- editing/visible_units.cpp:
(WebCore::previousLinePosition):
(WebCore::nextLinePosition):
- platform/graphics/IntPoint.h:
(WebCore::IntPoint::transpose):
- rendering/InlineBox.cpp:
(WebCore::InlineBox::paint):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::nodeAtPoint):
(WebCore::RenderBlock::hitTestFloats):
(WebCore::positionForPointRespectingEditingBoundaries):
(WebCore::RenderBlock::positionForPointWithInlineChildren):
(WebCore::RenderBlock::positionForPoint):
- rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::positionForPoint):
(WebCore::RenderReplaced::localSelectionRect):
(WebCore::RenderReplaced::setSelectionState):
- rendering/RenderReplaced.h:
- rendering/RenderText.cpp:
(WebCore::RenderText::positionForPoint):
- rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::closestLeafChildForLogicalLeftPosition):
- rendering/RootInlineBox.h:
LayoutTests:
- fast/blockflow/horizontal-bt-replaced-selection.html: Added.
- fast/blockflow/vertical-lr-replaced-selection.html: Added.
- fast/blockflow/vertical-rl-replaced-selection.html: Added.
- platform/mac/fast/blockflow/horizontal-bt-replaced-selection-expected.checksum: Added.
- platform/mac/fast/blockflow/horizontal-bt-replaced-selection-expected.png: Added.
- platform/mac/fast/blockflow/horizontal-bt-replaced-selection-expected.txt: Added.
- platform/mac/fast/blockflow/vertical-lr-replaced-selection-expected.checksum: Added.
- platform/mac/fast/blockflow/vertical-lr-replaced-selection-expected.png: Added.
- platform/mac/fast/blockflow/vertical-lr-replaced-selection-expected.txt: Added.
- platform/mac/fast/blockflow/vertical-rl-replaced-selection-expected.checksum: Added.
- platform/mac/fast/blockflow/vertical-rl-replaced-selection-expected.png: Added.
- platform/mac/fast/blockflow/vertical-rl-replaced-selection-expected.txt: Added.
- 1:01 PM Changeset in webkit [71562] by
-
- 28 edits2 adds in trunk
2010-11-08 Nate Chapin <Nate Chapin>
Reviewed by Alexey Proskuryakov.
Move connection-per-host counting and request prioritization out
of Loader and down to the ResourceLoader level.
Refactor only, so no new tests.
- CMakeLists.txt:
- GNUmakefile.am:
- WebCore.exp.in:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- dom/ContainerNode.cpp: (WebCore::ContainerNode::suspendPostAttachCallbacks): (WebCore::ContainerNode::resumePostAttachCallbacks):
- loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::loadRequest):
- loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::loadNow):
- loader/NetscapePlugInStreamLoader.cpp: (WebCore::NetscapePlugInStreamLoader::create):
- loader/NetscapePlugInStreamLoader.h:
- loader/ResourceLoadScheduler.cpp: Added. (WebCore::ResourceLoadScheduler::hostForURL): (WebCore::resourceLoadScheduler): Returns the single ResourceLoadScheduler instance (WebCore::ResourceLoadScheduler::ResourceLoadScheduler): (WebCore::ResourceLoadScheduler::scheduleSubresourceLoad): (WebCore::ResourceLoadScheduler::schedulePluginStreamLoad): (WebCore::ResourceLoadScheduler::addMainResourceLoad): (WebCore::ResourceLoadScheduler::scheduleLoad): (WebCore::ResourceLoadScheduler::remove): (WebCore::ResourceLoadScheduler::crossOriginRedirectReceived): (WebCore::ResourceLoadScheduler::servePendingRequests): (WebCore::ResourceLoadScheduler::suspendPendingRequests): (WebCore::ResourceLoadScheduler::resumePendingRequests): (WebCore::ResourceLoadScheduler::scheduleServePendingRequests): (WebCore::ResourceLoadScheduler::requestTimerFired): (WebCore::ResourceLoadScheduler::assertLoaderBeingCounted): (WebCore::ResourceLoadScheduler::HostInformation::assertLoaderBeingCounted): (WebCore::ResourceLoadScheduler::HostInformation::HostInformation): (WebCore::ResourceLoadScheduler::HostInformation::~HostInformation): (WebCore::ResourceLoadScheduler::HostInformation::schedule): (WebCore::ResourceLoadScheduler::HostInformation::addLoadInProgress): (WebCore::ResourceLoadScheduler::HostInformation::remove): (WebCore::ResourceLoadScheduler::HostInformation::hasRequests):
- loader/ResourceLoadScheduler.h: Added. (WebCore::ResourceLoadScheduler::HostInformation::name): (WebCore::ResourceLoadScheduler::HostInformation::limitRequests): (WebCore::ResourceLoadScheduler::HostInformation::requestsPending):
- loader/ResourceLoader.cpp: (WebCore::ResourceLoader::releaseResources): Remove this from ResourceLoadScheduler's counting. (WebCore::ResourceLoader::load): (WebCore::ResourceLoader::start): Create the ResourceHandle, called by ResourceLoadScheduler. (WebCore::ResourceLoader::willSendRequest): Ensure ResourceLoadScheduler counts redirects
correctly.
- loader/ResourceLoader.h: (WebCore::ResourceLoader::url):
- loader/icon/IconLoader.cpp: (WebCore::IconLoader::startLoading):
- loader/loader.cpp: Move scheduling to ResourceLoadScheduler, remove Host subclass
and make Loader the SubresourceLoaderClient instead.
(WebCore::determinePriority):
(WebCore::Loader::load): Schedule the creation of the ResourceHandle, rather than
doing it immediately.
(WebCore::Loader::cancelRequests):
(WebCore::Loader::didFinishLoading):
(WebCore::Loader::didFail):
(WebCore::Loader::didReceiveResponse):
(WebCore::Loader::didReceiveData):
(WebCore::Loader::didReceiveCachedMetadata):
- loader/loader.h:
- page/EventSource.cpp: (WebCore::EventSource::connect): (WebCore::EventSource::endRequest):
- plugins/PluginStream.cpp: (WebCore::PluginStream::start):
- xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::XMLHttpRequest): (WebCore::XMLHttpRequest::~XMLHttpRequest): (WebCore::XMLHttpRequest::createRequest): (WebCore::XMLHttpRequest::didFail): (WebCore::XMLHttpRequest::didFinishLoading):
- xml/XMLHttpRequest.h:
- 1:00 PM Changeset in webkit [71561] by
-
- 2 edits in trunk/WebKit/efl
2010-11-08 Rafael Antognolli <antognolli@profusion.mobi>
Reviewed by Antonio Gomes.
[EFL] Change the usage of eina_iterator_next due to latest EFL changes.
https://bugs.webkit.org/show_bug.cgi?id=49082
A change on how the iterator for a tiler is used in EFL needs to be
reflected in WebKit-EFL. The iterator now receives a pointer to an
Eina_Rectangle and makes it point to its internal structure. The old
usage was to receive a reference to a pre-allocated Eina_Rectangle.
- ewk/ewk_view_single.c: (_ewk_view_single_smart_repaints_process):
- 12:41 PM Changeset in webkit [71560] by
-
- 2 edits in trunk/WebKitTools
Ignore the system scrollbar setting.
Reviewed by Darin Adler.
- DumpRenderTree/mac/DumpRenderTree.mm:
(resetDefaultsToConsistentValues): Set the scrollbar default.
- 12:32 PM Changeset in webkit [71559] by
-
- 9 edits in trunk
NPClass::construct and NPClass::invokeDefault never called with out-of-process plug-ins in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=49198
Reviewed by Adam Roben.
WebKit2:
- Shared/Plugins/NPObjectMessageReceiver.cpp:
(WebKit::NPObjectMessageReceiver::invokeDefault):
Call NPClass::invokeDefault.
(WebKit::NPObjectMessageReceiver::construct):
Call NPClass::construct
- Shared/Plugins/NPObjectMessageReceiver.messages.in:
Add InvokeDefault and Construct messages.
- Shared/Plugins/NPObjectProxy.cpp:
(WebKit::NPObjectProxy::invokeDefault):
Send the InvokeDefault message.
(WebKit::NPObjectProxy::construct):
Send the Construct message.
(WebKit::NPObjectProxy::NP_InvokeDefault):
Call NPObjectProxy::invokeDefault.
(WebKit::NPObjectProxy::NP_Construct):
Call NPObjectProxy::construct.
LayoutTests:
Remove now passing tests.
- platform/mac-snowleopard/Skipped:
- platform/mac-wk2/Skipped:
- 12:29 PM Changeset in webkit [71558] by
-
- 4 edits1 copy1 move2 deletes in trunk/LayoutTests
2010-11-08 Tony Chang <tony@chromium.org>
Unreviewed, updating plugin expectations.
- platform/chromium-mac/plugins/netscape-destroy-plugin-script-objects-expected.txt: Removed.
- platform/chromium-win/plugins/netscape-destroy-plugin-script-objects-expected.txt: Removed.
- platform/mac-snowleopard/Skipped: Only failing on SL.
- platform/mac/Skipped:
- platform/qt/plugins/nested-plugin-objects-expected.txt: Removed.
- plugins/nested-plugin-objects-expected.txt: Made the main version
have a console error line of 0 since it seems to be a chromium
specific difference.
- 12:28 PM Changeset in webkit [71557] by
-
- 2 edits in trunk/WebKitSite
We should add a build step to comment out or remove the lines unsetting TEMP and TMP in the
.bashrc file.
https://bugs.webkit.org/show_bug.cgi?id=49189
Reviewed by Adam Roben.
- building/tools.html:
Add a line recommending bash shell users to comment out or remove those lines, with an
explanation as to why.
- 12:15 PM Changeset in webkit [71556] by
-
- 13 edits in trunk/WebCore
2010-11-08 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
Remove the remaining editing-style functions from ApplyStyleCommand
https://bugs.webkit.org/show_bug.cgi?id=49155
Replaced removeNonEditingProperties, editingStyleAtPosition, prepareEditingStyleToApplyAt,
and removeStylesAddedByNode in ApplyStyleCommand.cpp by removeNonEditingProperties, EditingStyle::create,
prepareToApplyAt, and removeStyleAddedByNode in EditingStyle.cpp.
Also removed unnecessary header includes from various cpp files.
No tests are added since this is a cleanup.
- editing/ApplyStyleCommand.cpp: Removed removeNonEditingProperties, editingStyleAtPosition, prepareEditingStyleToApplyAt, and removeStylesAddedByNode.
- editing/ApplyStyleCommand.h: Ditto.
- editing/DeleteSelectionCommand.cpp: Removed removeEnclosingAnchorStyle. (WebCore::DeleteSelectionCommand::saveTypingStyleState): Calls removeStylesAddedByNode instead.
- editing/EditingStyle.cpp: (WebCore::copyEditingProperties): Moved and renamed ApplyStyleCommand::removeNonEditingProperties. (WebCore::editingStyleFromComputedStyle): Calls copyEditingProperties. Changed the argument to PassRefPtr as supposed to a raw pointer for convenience. (WebCore::EditingStyle::init): Calls editingStyleFromComputedStyle. (WebCore::EditingStyle::removeStyleAddedByNode): Added. (WebCore::EditingStyle::removeStyleConflictingWithStyleOfNode): Added. (WebCore::EditingStyle::removeNonEditingProperties): Added. (WebCore::editingStyleIncludingTypingStyle): Calls copyEditingProperties.
- editing/EditingStyle.h: Added prototypes.
- editing/Editor.cpp: (WebCore::Editor::selectionComputedStyle): Uses EditingStyle.
- editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::calculateStyleBeforeInsertion): Ditto. (WebCore::InsertParagraphSeparatorCommand::applyStyleAfterInsertion): Ditto.
- editing/InsertParagraphSeparatorCommand.h:
- editing/RemoveFormatCommand.cpp: (WebCore::RemoveFormatCommand::doApply): Ditto.
- editing/ReplaceSelectionCommand.cpp: (WebCore::handleStyleSpansBeforeInsertion): Ditto. (WebCore::ReplaceSelectionCommand::handleStyleSpans): Ditto. (WebCore::ReplaceSelectionCommand::doApply): Ditto. (WebCore::ReplaceSelectionCommand::completeHTMLReplacement): Ditto.
- editing/ReplaceSelectionCommand.h:
- editing/markup.cpp: Removed removeEnclosingMailBlockquoteStyle and removeDefaultStyles. (WebCore::createMarkup): Uses EditingStyle.
- 12:02 PM Changeset in webkit [71555] by
-
- 1 edit60 adds2 deletes in trunk/LayoutTests
Unreviewed, updating Chromium expectations.
- platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop-expected.checksum: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop-expected.png: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop-expected.checksum: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop-expected.png: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-edgeMode-prop-expected.checksum: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-edgeMode-prop-expected.png: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop-expected.checksum: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop-expected.png: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop-expected.checksum: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop-expected.png: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop-expected.checksum: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop-expected.png: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop-expected.checksum: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop-expected.png: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop-expected.checksum: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop-expected.png: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.checksum: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.png: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetY-prop-expected.checksum: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetY-prop-expected.png: Added.
- platform/chromium-mac/svg/custom/polyline-points-crash-expected.txt: Removed.
- platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop-expected.checksum: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop-expected.png: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop-expected.checksum: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop-expected.png: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-edgeMode-prop-expected.checksum: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-edgeMode-prop-expected.png: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop-expected.checksum: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop-expected.png: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop-expected.checksum: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop-expected.png: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop-expected.checksum: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop-expected.png: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop-expected.checksum: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop-expected.png: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop-expected.checksum: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop-expected.png: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.checksum: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.png: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetY-prop-expected.checksum: Added.
- platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetY-prop-expected.png: Added.
- platform/chromium-win/svg/custom/polyline-points-crash-expected.txt: Removed.
- platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop-expected.checksum: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop-expected.png: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop-expected.checksum: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop-expected.png: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-edgeMode-prop-expected.checksum: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-edgeMode-prop-expected.png: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop-expected.checksum: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop-expected.png: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop-expected.checksum: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop-expected.png: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop-expected.checksum: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop-expected.png: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop-expected.checksum: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop-expected.png: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop-expected.checksum: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop-expected.png: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.checksum: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.png: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetY-prop-expected.checksum: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetY-prop-expected.png: Added.
- 11:58 AM Changeset in webkit [71554] by
-
- 4 edits in trunk
Plug-in views should not assume that plugins are RenderEmbeddedObjects
https://bugs.webkit.org/show_bug.cgi?id=49196
<rdar://problem/8638467>
Reviewed by Dan Bernstein.
WebKit/mac:
- Plugins/Hosted/WebHostedNetscapePluginView.mm:
(-[WebHostedNetscapePluginView pluginHostDied]):
WebKit2:
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::pluginProcessCrashed):
- 11:47 AM Changeset in webkit [71553] by
-
- 9 edits5 adds in trunk
2010-11-08 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
Media objects in nested iframes showing above everything else in TinyMCE
https://bugs.webkit.org/show_bug.cgi?id=44877
Tests: compositing/iframes/become-composited-nested-iframes.html
compositing/iframes/overlapped-nested-iframes.html
The overlap testing logic that connects compositing across iframe boundaries
needed to be educated about nestd iframes, for platforms (i.e. Mac) where iframes
are allowed to be independently composited.
Also fix a bug that could cause iframes (and possibly other elements) that share
style to fail to become composited.
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::canShareStyleWithElement): Disable style sharing for elements that force synethetic style updates in order to gain RenderLayers, so they can become composited. This is tested by become-composited-nested-iframes.html, though it is very timing-dependent.
- page/FrameView.h:
- page/FrameView.cpp: (WebCore::FrameView::hasCompositedContentIncludingDescendants): New method that is a "deep" version of hasCompositedContent() on platforms where that is necessary to ask.
(WebCore::FrameView::hasCompositingAncestor): New method.
(WebCore::FrameView::setIsOverlapped): If we can have independently composited iframes,
we need to force all descendant iframes to update so that compositing gets hooked up across
nested iframes.
(WebCore::FrameView::isOverlappedIncludingAncestors): New method, only called on platforms
where allowsIndependentlyCompositedIFrames() is true.
- rendering/RenderLayerCompositor.h:
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::allowsIndependentlyCompositedIFrames): Utility method that returns true if an iframe can be a compositing root.
(WebCore::RenderLayerCompositor::shouldPropagateCompositingToEnclosingIFrame): Make use of
allowsIndependentlyCompositedIFrames().
(WebCore::RenderLayerCompositor::notifyIFramesOfCompositingChange): We need to notify all
descendant frames, not just children.
- rendering/RenderObject.cpp: (WebCore::RenderObject::setStyle): Add assert to ensure that we don't do style sharing for elements that play tricks with synthetic style changes.
- rendering/RenderWidget.cpp: (WebCore::RenderWidget::paint): Run overlap testing if a frame has any composited descendants.
- 11:29 AM Changeset in webkit [71552] by
-
- 2 edits1 add in trunk/LayoutTests
2010-11-08 Tony Chang <tony@chromium.org>
Unreviewed, adding qt results for new test (only console line number
is different). Test failing for unknown reasons on mac-- will fix
offline.
- platform/mac/Skipped:
- platform/qt/plugins/nested-plugin-objects-expected.txt: Added.
- 11:26 AM Changeset in webkit [71551] by
-
- 7 edits in trunk
NPN_Evaluate doesn't work with out-of-process plugins in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=49193
Reviewed by Adam Roben.
WebKit2:
- PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::evaluate):
Send an Evaluate message.
- WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::evaluate):
Call Evaluate on the plug-in proxy.
- WebProcess/Plugins/PluginProxy.h:
- WebProcess/Plugins/PluginProxy.messages.in:
Add Evaluate message.
LayoutTests:
Remove now passing tests.
- platform/mac-wk2/Skipped:
- 11:22 AM Changeset in webkit [71550] by
-
- 6 edits in trunk/WebCore
Unreviewed. Rolling back r71506 & r71507, broke inspector/debugger-pause-on-* tests.
- 11:18 AM Changeset in webkit [71549] by
-
- 2 edits in trunk/WebKit
2010-11-08 Leandro Pereira <leandro@profusion.mobi>
[EFL] Unreviewed. Build fix after r71496.
- CMakeLists.txt: Add WebCore/loader/cache directory to WebKit's include directories list.
- 11:15 AM Changeset in webkit [71548] by
-
- 2 edits in trunk/WebKit/win
Windows build fix.
- WebCoreSupport/WebChromeClient.h: Added namespace prefix.
- 11:12 AM Changeset in webkit [71547] by
-
- 3 edits in trunk/WebKitTools
Make webkitpy.common.system.executive_unittest pass when running under Win32 Python
Fixes <http://webkit.org/b/49033>.
Reviewed by Dave Levin and Eric Seidel.
- Scripts/webkitpy/common/system/executive.py:
(Executive._run_command_with_teed_output): Pass the arguments through
encode_argument_if_needed rather than using Cygwin-specific code here.
(Executive.run_and_throw_if_fail): Use child_process_encoding to decode
the output.
(Executive.run_command): Use encode_argument_if_needed to encode the
arguments and child_process_encoding to decode the output.
(Executive._child_process_encoding): Returns the encoding that should be
used when communicating with child processes. On Windows we use mbcs,
which maps to the current code page. On all other platforms we use
UTF-8.
(Executive._should_encode_child_process_arguments): Returns True if
arguments to child processes need to be encoded. This is currently
only needed on Cygwin and Win32 Python 2.x.
(Executive._encode_argument_if_needed): Encode the argument using
child_process_encoding if we need to encode arguments to child
processes on this platform.
- Scripts/webkitpy/common/system/executive_unittest.py:
(never_ending_command): Added. Returns arguments to run a command that
will not quit until we kill it. On Windows we use wmic, on other
platforms we use yes.
(ExecutiveTest.test_run_command_with_unicode): Changed to expect the
mbcs encoding to be used and for output from the child processes to
have been roundtripped through encode/decode on Win32 Python. When
UTF-8 is the encoding the roundtripping is undetectable, but with mbcs
it's possible that some characters will not be able to be converted
and will be replaced by question marks; the round-tripping allows us
to expect this result.
(ExecutiveTest.test_kill_process):
(ExecutiveTest.test_kill_all):
Use never_ending_command instead of invoking "yes" directly. Expect an
exit code of 1 when using Win32 Python, as that's what seems to happen.
- 11:05 AM Changeset in webkit [71546] by
-
- 8 edits in trunk
Correctly convert NPObjectProxy to NPVariantData
https://bugs.webkit.org/show_bug.cgi?id=49190
Reviewed by John Sullivan.
WebKit2:
- Shared/Plugins/NPObjectMessageReceiver.h:
(WebKit::NPObjectMessageReceiver::npObject):
Add NPObject getter.
- Shared/Plugins/NPObjectProxy.h:
(WebKit::NPObjectProxy::npObjectID):
Add NPObjectID getter.
- Shared/Plugins/NPRemoteObjectMap.cpp:
(WebKit::NPRemoteObjectMap::npVariantToNPVariantData):
Handle the case where the NPObject is an NPObjectProxy.
(WebKit::NPRemoteObjectMap::npVariantDataToNPVariant):
Handle NPVariantData::LocalNPObjectID.
- Shared/Plugins/NPVariantData.cpp:
(WebKit::NPVariantData::makeRemoteNPObjectID):
- Shared/Plugins/NPVariantData.h:
New function for creating an NPVariantData that contains a remote NPObject ID.
LayoutTests:
Remove now passing test.
- platform/mac-wk2/Skipped:
- 11:04 AM Changeset in webkit [71545] by
-
- 5 edits2 deletes in trunk
Roll out r71532
It broke the build for Cygwin 1.7 installs. Cygwin 1.7's default
.bashrc unsets %TEMP%, which broke copy-tools.cmd.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.vcproj:
- JavaScriptCore.vcproj/JavaScriptCore/copy-tools.cmd: Removed.
- JavaScriptCore.vcproj/JavaScriptCore/show-alert.js: Removed.
WebKitTools:
- Scripts/webkitdirs.pm:
- 11:00 AM Changeset in webkit [71544] by
-
- 3 edits in trunk
- fast/images/image-map-multiple-xhtml.xhtml: Fixed this test to check that
map name lookup is case sensitive.
Rubber stamped by Alexey Proskuryakov.
- 10:50 AM Changeset in webkit [71543] by
-
- 5 edits4 adds in trunk
2010-11-08 Darin Adler <Darin Adler>
Reviewed by Alexey Proskuryakov.
Incorrect image map used when multiple maps have the same name
https://bugs.webkit.org/show_bug.cgi?id=49086
Test: fast/images/image-map-multiple.html
Factored out the code used to look up elements by id and reused it
to look up maps by name. It handles multiple elements efficiently.
- dom/Document.cpp: (WebCore::Document::DocumentOrderedMap::clear): Added. (WebCore::Document::DocumentOrderedMap::add): Added. Has code that was formerly in addElementById. (WebCore::Document::DocumentOrderedMap::remove): Added. Has code that was formerly in removeElementById. (WebCore::Document::DocumentOrderedMap::get): Added. Has code that was formerly in getElementById. (WebCore::keyMatchesId): Added. (WebCore::Document::getElementById): Use DocumentOrderedMap::get. (WebCore::Document::addElementById): Use DocumentOrderedMap::add. (WebCore::Document::removeElementById): Use DocumentOrderedMap::remove. (WebCore::Document::addImageMap): Use DocumentOrderedMap::add. (WebCore::Document::removeImageMap): Use DocumentOrderedMap::remove. (WebCore::keyMatchesMapName): Added. (WebCore::keyMatchesLowercasedMapName): Added. (WebCore::Document::getImageMap): Use DocumentOrderedMap::get.
- dom/Document.h: Added DocumentOrderedMap class, used inside the Document class. Changed m_imageMapsByName to be a DocumentOrderedMap. Changed m_elementsById to be a DocumentOrderedMap. Eliminated m_duplicateIds, since DocumentOrderedMap now has that internally.
2010-11-08 Darin Adler <Darin Adler>
Reviewed by Alexey Proskuryakov.
Incorrect image map used when multiple maps have the same name
https://bugs.webkit.org/show_bug.cgi?id=49086
- fast/images/image-map-multiple-expected.txt: Added.
- fast/images/image-map-multiple-xhtml-expected.txt: Added.
- fast/images/image-map-multiple-xhtml.xhtml: Added.
- fast/images/image-map-multiple.html: Added.
- fast/images/zoomed-img-size-expected.txt: Removed property svn:executable.
- 10:36 AM Changeset in webkit [71542] by
-
- 3 edits in trunk/LayoutTests
2010-11-08 Alexander Pavlov <apavlov@chromium.org>
Unreviewed, build fix from commit r71530.
- fast/css/background-norepeat-crash-expected.txt:
- fast/css/background-norepeat-crash.html:
- 10:23 AM Changeset in webkit [71541] by
-
- 42 edits in trunk
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=48685
Notify UI process about focused frame
- 10:19 AM Changeset in webkit [71540] by
-
- 2 edits in trunk/WebKit/mac
Build fix.
- MigrateHeaders.make:
- 10:16 AM Changeset in webkit [71539] by
-
- 4 edits in trunk
Remove use of HIGetScaleFactor
https://bugs.webkit.org/show_bug.cgi?id=49186
<rdar://problem/8618410>
Reviewed by Adam Roben.
Scale factors can vary on a display-by-display basis and it doesn't make sense
to compute scale factor event coordinates like this.
WebCore:
- plugins/mac/PluginViewMac.mm:
(WebCore::PluginView::globalMousePosForPlugin):
WebKit/mac:
- Plugins/WebNetscapePluginEventHandlerCarbon.mm:
(getCarbonEvent):
- 10:04 AM Changeset in webkit [71538] by
-
- 14 edits4 adds in trunk
[Texmap] [Qt] Texture mapper initial implementation
https://bugs.webkit.org/show_bug.cgi?id=47070
Reviewed by Kenneth Rohde Christiansen.
WebCore:
Make the necessary changes in TextureMapperNode in preparation of making it possible to paint it
from a different thread.
The main problematic part was the cache, which made it so that textures can become invalid and have to
be rerendered from content during paint. This is solved here by creating a pack/unpack function for
textures, which lets a texture archive its data away from video memory, or do whatever the platform
thinks is right for freeing memory without needing to re-render again from content (which cannot be
made thread safe).
After this change, TextureMapperNode moved to its own file, and has 2 entry points: paint and syncCompositingState.
The idea is that syncCompositingState has to be called in the UI thread, paint can be called from a different
thread, and they should block each other.
The new test tests the cache code-path, to show that the pack/unpack technique works for cases where it
kicks in.
Test: compositing/layer-creation/many-layers.html
- WebCore.pro:
- platform/graphics/opengl/TextureMapperGL.cpp:
(WebCore::BitmapTextureGL::~BitmapTextureGL):
(WebCore::BitmapTextureGL::BitmapTextureGL):
(WebCore::TextureMapperGL::TextureMapperGL):
(WebCore::TextureMapperGL::drawTexture):
- platform/graphics/opengl/TextureMapperGL.h:
(WebCore::TextureMapperGL::create):
- platform/graphics/qt/TextureMapperQt.cpp:
(WebCore::BitmapTextureQt::pack):
(WebCore::BitmapTextureQt::unpack):
(WebCore::TextureMapper::create):
(WebCore::BitmapTextureQt::BitmapTextureQt):
- platform/graphics/qt/TextureMapperQt.h: Added.
WebKit/qt:
Reorganized the textureMapper to be a member of QWebFramePrivate, to help with making
TextureMapper thread-safe.
- Api/qwebframe.cpp:
(QWebFramePrivate::renderCompositedLayers):
- Api/qwebframe_p.h:
- WebCoreSupport/PageClientQt.cpp:
(WebCore::PlatformLayerProxyQt::setTextureMapper):
(WebCore::PlatformLayerProxyQt::textureMapper):
(WebCore::PlatformLayerProxyQWidget::PlatformLayerProxyQWidget):
(WebCore::PlatformLayerProxyQGraphicsObject::PlatformLayerProxyQGraphicsObject):
LayoutTests:
Added a test that includes several composited layers, containing pixel data that's larger
than 24MB, which is the default value for TextureMapper's cache. This tests the video memory
ceiling functionality of TextureMapper, as purging that cache would kick in whe running this test.
- compositing/layer-creation/many-layers.html: Added.
- 9:56 AM Changeset in webkit [71537] by
-
- 4 edits2 moves in trunk
2010-11-08 Tony Chang <tony@chromium.org>
Reviewed by Adam Barth.
run platform/chromium/plugins/nested-plugin-objects.html on all platforms
https://bugs.webkit.org/show_bug.cgi?id=49094
- plugins/nested-plugin-objects-expected.txt: Renamed from LayoutTests/platform/chromium/plugins/nested-plugin-objects-expected.txt.
- plugins/nested-plugin-objects.html: Renamed from LayoutTests/platform/chromium/plugins/nested-plugin-objects.html.
2010-11-08 Tony Chang <tony@chromium.org>
Reviewed by Adam Barth.
run platform/chromium/plugins/nested-plugin-objects.html on all platforms
https://bugs.webkit.org/show_bug.cgi?id=49094
This tests that objects created by plugins are proplery cleaned up.
- DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp: (testPassTestObject): (pluginInvoke):
- DumpRenderTree/TestNetscapePlugIn/TestObject.cpp: (testAllocate): (testDeallocate): (testGetProperty): (testConstruct):
- 9:48 AM Changeset in webkit [71536] by
-
- 8 edits in trunk
2010-11-08 Simon Fraser <Simon Fraser>
Reviewed by Sam Weinig.
Allow applets to participate in accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=49117
<rdar://problem/8625819>
Add RenderApplet to the list of renderers that can optionally get RenderLayers,
and be composited for some reason.
Not currently testable.
- rendering/RenderApplet.h: Outdented the class declaration.
- rendering/RenderApplet.cpp: (WebCore::RenderApplet::requiresLayer): Return true if the underlying widget has a platform layer. (WebCore::RenderApplet::allowsAcceleratedCompositing): Check the widget to see if it has a platform layer.
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::shouldBeNormalFlowOnly): Reformat, and add isApplet(). (WebCore::RenderLayer::isSelfPaintingLayer): Reformat, and add isApplet().
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration): Use 'renderer' local variable for efficiency. Now check for embedded objects and applets.
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::requiresCompositingForPlugin): Check for embedded objects and applets.
- 9:30 AM Changeset in webkit [71535] by
-
- 2 edits in trunk/JavaScriptCore
2010-11-08 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
=webkitgtk-1.2.5: parallel build fails with libtool: link: cannot find the library
libwebkit-1.0.la' or unhandled argumentlibwebkit-1.0.la'
r59042 introduced a C++-style comment in Platform.h, which is often
included in C source files. Change it to a C-style comment.
- wtf/Platform.h: Fix the C++-style comment.
- 9:24 AM Changeset in webkit [71534] by
-
- 2 edits in trunk/WebCore
2010-11-08 Xan Lopez <xlopez@igalia.com>
Reviewed by Martin Robinson.
- GNUmakefile.am: add missing files to fix distcheck.
- 9:17 AM Changeset in webkit [71533] by
-
- 3 edits in trunk/WebKit/chromium
2010-11-08 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Yury Semikhatsky.
Only call WebInspector_syncDispatch if it's actually a function.
https://bugs.webkit.org/show_bug.cgi?id=49180
- src/WebDevToolsFrontendImpl.cpp: (WebKit::WebDevToolsFrontendImpl::WebDevToolsFrontendImpl): (WebKit::WebDevToolsFrontendImpl::dispatchOnInspectorFrontend):
- src/WebDevToolsFrontendImpl.h:
- 9:14 AM Changeset in webkit [71532] by
-
- 5 edits2 adds in trunk
Show a message and cause the build to immediately fail when any .vsprops files are copied
When $WebKitLibrariesDir is set to a non-standard location, the
.vsprops files have to be copied from WebKitLibraries/win to
$WebKitLibrariesDir. When this happens, Visual Studio doesn't pick up
changes to the .vsprops files until the next time it opens the solution
file. Before this patch, the build would soldier on with the old
.vsprops files, leading to strange build failures. Now we detect that
the .vsprops files have been updated, display a message to the user
telling them what to do, and make the build fail immediately.
Fixes <http://webkit.org/b/49181> Windows build fail mysteriously when
.vsprops files are updated
Reviewed by Steve Falkenburg.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make:
Moved code to copy the tools directory to the new copy-tools.cmd
script. Moved that after the command that writes the buildfailed file
so the build will be considered a failure if copy-tools.cmd fails.
Changed to write the project name into buildfailed like all our other
projects do, so those other projects will know that the failure was due
to this project.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.vcproj:
Added new scripts.
- JavaScriptCore.vcproj/JavaScriptCore/copy-tools.cmd: Added. Copies
the tools directory to $WebKitLibrariesDir. If any files were copied,
we display a message to the user and exit with error code 1 to cause
the build to fail. In non-interactive builds, we just print the message
to the build log. In interactive builds, we show the message in an
alert.
- JavaScriptCore.vcproj/JavaScriptCore/show-alert.js: Added. Uses
Windows Scripting Host to display a message in an alert.
WebKitTools:
Mark Windows builds triggered from Perl as being non-interactive
This affects whether some of our scripts will show alerts vs. printing
to the build log.
- Scripts/webkitdirs.pm:
(buildVisualStudioProject): Set WEBKIT_NONINTERACTIVE_BUILD to 1.
- 9:02 AM Changeset in webkit [71531] by
-
- 2 edits in trunk/LayoutTests
Add a sometimes-failing test to the Windows Skipped file
- platform/win/Skipped: Added
animations/stop-animation-on-suspend.html.
- 8:54 AM Changeset in webkit [71530] by
-
- 3 edits2 adds in trunk
2010-11-08 Alexander Pavlov <apavlov@chromium.org>
Reviewed by David Hyatt.
getPropertyValue("background") causes crash
https://bugs.webkit.org/show_bug.cgi?id=49055
- fast/css/background-norepeat-crash-expected.txt: Added.
- fast/css/background-norepeat-crash.html: Added.
2010-11-08 Alexander Pavlov <apavlov@chromium.org>
Reviewed by David Hyatt.
getPropertyValue("background") causes crash
https://bugs.webkit.org/show_bug.cgi?id=49055
Test: fast/css/background-norepeat-crash.html
- css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::getLayeredShorthandValue):
- 8:48 AM Changeset in webkit [71529] by
-
- 2 edits in trunk/WebKit/gtk
2010-11-08 Martin Robinson <mrobinson@igalia.com>
Reviewed by Andreas Kling.
[GTK] Error page templates are not filled properly
https://bugs.webkit.org/show_bug.cgi?id=49148
Replace a call to makeString with String::format. This was mistakenly
changed to makeString in an earlier commit.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchDidFailLoad):
- 8:42 AM Changeset in webkit [71528] by
-
- 4 edits in trunk/WebCore
2010-11-08 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] Wrapped DOM bindings GObjects do not disconnect event listeners when they die
https://bugs.webkit.org/show_bug.cgi?id=49136
When GObjects are finalized and freed, disconnect their event listeners, so that
WebCore does not try to fire signals on dead GObjects. We do this by holding a weak
reference to the GObject in the signal listener. When the weak reference notification
callback is executed, we disconnect the event listener.
No new tests; this fix is proved by prevention of crashes in soon to be
landed editing delegate signals, which are covered by the layout tests.
- bindings/gobject/GObjectEventListener.cpp: (WebCore::GObjectEventListener::GObjectEventListener): Updated the constructor. (WebCore::GObjectEventListener::~GObjectEventListener): Disconnect the weak reference if the GObject is still alive. (WebCore::GObjectEventListener::gobjectDestroyed): When the GObject is destroyed, disconnect the appropriate event listener. (WebCore::GObjectEventListener::handleEvent): Changes to reflect use of CString instead of WebCore string.
- bindings/gobject/GObjectEventListener.h: (WebCore::GObjectEventListener::addEventListener): Changed create to addEventListener, so that the connection and disconnection is an internal contract to the class. (WebCore::GObjectEventListener::gobjectDestroyedCallback): Added.
- bindings/scripts/CodeGeneratorGObject.pm: Modified the code generate to use GObjectEventListener::addEventListener and no longer call addEventListener on its own.
- 8:27 AM Changeset in webkit [71527] by
-
- 3 edits in trunk/WebKitTools
Make http locking default in NRWT.
https://bugs.webkit.org/show_bug.cgi?id=48053
Patch by Gabor Rapcsanyi <rgabor@inf.u-szeged.hu> on 2010-11-08
Reviewed by Ojan Vafai.
- Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- 8:26 AM Changeset in webkit [71526] by
-
- 3 edits in trunk/LayoutTests
2010-11-08 Martin Robinson <mrobinson@igalia.com>
Skip failing tests and rebaseline another test after r71512.
- platform/gtk/Skipped: Update the skipped list.
- platform/gtk/svg/custom/use-property-synchronization-crash-expected.txt:
- 8:25 AM Changeset in webkit [71525] by
-
- 2 edits in trunk/WebKitTools
2010-11-08 Gabor Rapcsanyi <rgabor@inf.u-szeged.hu>
Reviewed by Csaba Osztrogonác.
[NRWT] If the http lock fails we shouldn't do any locking
https://bugs.webkit.org/show_bug.cgi?id=49164
If something goes wrong with the locking, the test should keep going.
- Scripts/webkitpy/layout_tests/port/http_lock.py:
- 7:50 AM Changeset in webkit [71524] by
-
- 4 edits in trunk
2010-11-08 Xan Lopez <xlopez@igalia.com>
Reviewed by Martin Robinson.
Update version numbers for release.
- configure.ac:
WebKit/gtk:
2010-11-08 Xan Lopez <xlopez@igalia.com>
Reviewed by Martin Robinson.
- NEWS: update for release.
- 7:40 AM Changeset in webkit [71523] by
-
- 2 edits in trunk/LayoutTests
Skip plugins tests on Qt WebKit2 since we do
not have plugin support yet.
Rubber-stamped by Csaba Osztrogonac.
- platform/qt-wk2/Skipped:
- 7:30 AM Changeset in webkit [71522] by
-
- 2 edits in trunk/LayoutTests
2010-11-08 Stephen White <senorblanco@chromium.org>
Unreviewed; test expectations update.
Update chromium-gpu test_expectations after canvas/philip update, and
other fixes.
- platform/chromium-gpu/test_expectations.txt:
- 7:19 AM Changeset in webkit [71521] by
-
- 2 edits in trunk/WebCore
Windows Release build fix after r71514
The build was failing due to an alignment error. Strangely, depending
on the order of SVGStaticPropertyTearOff's members, the build will
either fail in Release (as it does before this change), or Debug (as it
did before r71514), but not both.
- svg/properties/SVGStaticPropertyTearOff.h:
(WebCore::SVGStaticPropertyTearOff::SVGStaticPropertyTearOff): Copied
the #pragma pack trick from JSSVGPODTypeWrapper.h, which has similar
issues.
- 7:09 AM Changeset in webkit [71520] by
-
- 8 edits in trunk/LayoutTests
Unreviewed. Update expectations.
[Qt] DRT sideeffect revealed by r71518
https://bugs.webkit.org/show_bug.cgi?id=49174
The previous expected results were wrong, because they were modified by this sideeffect.
New results were generated by: WebKitTools/Scripts/run-webkit-tests --reset-results --singly TEST_NAME
- platform/qt/http/tests/navigation/error404-basic-expected.txt:
- platform/qt/http/tests/navigation/error404-goback-expected.txt:
- platform/qt/http/tests/navigation/error404-subframeload-expected.txt:
- platform/qt/http/tests/navigation/javascriptlink-frames-expected.txt:
- platform/qt/http/tests/navigation/postredirect-basic-expected.txt:
- platform/qt/http/tests/navigation/postredirect-frames-expected.txt:
- platform/qt/http/tests/navigation/postredirect-goback1-expected.txt:
- 6:48 AM Changeset in webkit [71519] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Update Qt specific expected file after r71512.
- platform/qt/svg/custom/use-property-synchronization-crash-expected.txt: updated.
- 6:31 AM Changeset in webkit [71518] by
-
- 120 edits1 copy264 adds in trunk/LayoutTests
[Qt] Unreviewed. Update/add expectations for passing editing/deleting/* tests.
Compared to Mac png files and Mac expected files.
- platform/qt/Skipped:
- platform/qt/editing/deleting/4845371-expected.checksum: Added.
- platform/qt/editing/deleting/4845371-expected.png: Added.
- platform/qt/editing/deleting/4845371-expected.txt:
- platform/qt/editing/deleting/4922367-expected.checksum: Added.
- platform/qt/editing/deleting/4922367-expected.png: Added.
- platform/qt/editing/deleting/4922367-expected.txt:
- platform/qt/editing/deleting/5026848-1-expected.checksum: Added.
- platform/qt/editing/deleting/5026848-1-expected.png: Added.
- platform/qt/editing/deleting/5026848-1-expected.txt:
- platform/qt/editing/deleting/5026848-2-expected.checksum: Added.
- platform/qt/editing/deleting/5026848-2-expected.png: Added.
- platform/qt/editing/deleting/5026848-2-expected.txt:
- platform/qt/editing/deleting/5026848-3-expected.checksum: Added.
- platform/qt/editing/deleting/5026848-3-expected.png: Added.
- platform/qt/editing/deleting/5026848-3-expected.txt:
- platform/qt/editing/deleting/5032066-expected.checksum: Added.
- platform/qt/editing/deleting/5032066-expected.png: Added.
- platform/qt/editing/deleting/5032066-expected.txt:
- platform/qt/editing/deleting/5091898-expected.checksum: Added.
- platform/qt/editing/deleting/5091898-expected.png: Added.
- platform/qt/editing/deleting/5091898-expected.txt:
- platform/qt/editing/deleting/5099303-expected.checksum: Added.
- platform/qt/editing/deleting/5099303-expected.png: Added.
- platform/qt/editing/deleting/5099303-expected.txt:
- platform/qt/editing/deleting/5115601-expected.checksum: Added.
- platform/qt/editing/deleting/5115601-expected.png: Added.
- platform/qt/editing/deleting/5115601-expected.txt:
- platform/qt/editing/deleting/5126166-expected.checksum: Added.
- platform/qt/editing/deleting/5126166-expected.png: Added.
- platform/qt/editing/deleting/5126166-expected.txt:
- platform/qt/editing/deleting/5144139-2-expected.checksum: Added.
- platform/qt/editing/deleting/5144139-2-expected.png: Added.
- platform/qt/editing/deleting/5144139-2-expected.txt:
- platform/qt/editing/deleting/5156801-2-expected.checksum: Added.
- platform/qt/editing/deleting/5156801-2-expected.png: Added.
- platform/qt/editing/deleting/5156801-2-expected.txt:
- platform/qt/editing/deleting/5168598-expected.checksum: Added.
- platform/qt/editing/deleting/5168598-expected.png: Added.
- platform/qt/editing/deleting/5168598-expected.txt:
- platform/qt/editing/deleting/5206311-1-expected.checksum: Added.
- platform/qt/editing/deleting/5206311-1-expected.png: Added.
- platform/qt/editing/deleting/5206311-1-expected.txt:
- platform/qt/editing/deleting/5206311-2-expected.checksum: Added.
- platform/qt/editing/deleting/5206311-2-expected.png: Added.
- platform/qt/editing/deleting/5206311-2-expected.txt:
- platform/qt/editing/deleting/5272440-expected.checksum: Added.
- platform/qt/editing/deleting/5272440-expected.png: Added.
- platform/qt/editing/deleting/5272440-expected.txt:
- platform/qt/editing/deleting/5369009-expected.checksum: Added.
- platform/qt/editing/deleting/5369009-expected.png: Added.
- platform/qt/editing/deleting/5369009-expected.txt:
- platform/qt/editing/deleting/5390681-2-expected.checksum: Added.
- platform/qt/editing/deleting/5390681-2-expected.png: Added.
- platform/qt/editing/deleting/5390681-2-expected.txt:
- platform/qt/editing/deleting/5390681-expected.checksum: Added.
- platform/qt/editing/deleting/5390681-expected.png: Added.
- platform/qt/editing/deleting/5433862-2-expected.checksum: Added.
- platform/qt/editing/deleting/5433862-2-expected.png: Added.
- platform/qt/editing/deleting/5433862-2-expected.txt: Added.
- platform/qt/editing/deleting/5483370-expected.checksum: Added.
- platform/qt/editing/deleting/5483370-expected.png: Added.
- platform/qt/editing/deleting/5483370-expected.txt: Added.
- platform/qt/editing/deleting/delete-3608445-fix-expected.checksum: Added.
- platform/qt/editing/deleting/delete-3608445-fix-expected.png: Added.
- platform/qt/editing/deleting/delete-3608445-fix-expected.txt:
- platform/qt/editing/deleting/delete-3775172-fix-expected.checksum: Added.
- platform/qt/editing/deleting/delete-3775172-fix-expected.png: Added.
- platform/qt/editing/deleting/delete-3775172-fix-expected.txt:
- platform/qt/editing/deleting/delete-3857753-fix-expected.checksum: Added.
- platform/qt/editing/deleting/delete-3857753-fix-expected.png: Added.
- platform/qt/editing/deleting/delete-3857753-fix-expected.txt:
- platform/qt/editing/deleting/delete-3865854-fix-expected.checksum: Added.
- platform/qt/editing/deleting/delete-3865854-fix-expected.png: Added.
- platform/qt/editing/deleting/delete-3865854-fix-expected.txt:
- platform/qt/editing/deleting/delete-3928305-fix-expected.checksum: Added.
- platform/qt/editing/deleting/delete-3928305-fix-expected.png: Added.
- platform/qt/editing/deleting/delete-3928305-fix-expected.txt:
- platform/qt/editing/deleting/delete-3959464-fix-expected.checksum: Added.
- platform/qt/editing/deleting/delete-3959464-fix-expected.png: Added.
- platform/qt/editing/deleting/delete-3959464-fix-expected.txt:
- platform/qt/editing/deleting/delete-4038408-fix-expected.checksum: Added.
- platform/qt/editing/deleting/delete-4038408-fix-expected.png: Added.
- platform/qt/editing/deleting/delete-after-span-ws-001-expected.checksum: Added.
- platform/qt/editing/deleting/delete-after-span-ws-001-expected.png: Added.
- platform/qt/editing/deleting/delete-after-span-ws-001-expected.txt:
- platform/qt/editing/deleting/delete-after-span-ws-002-expected.checksum: Added.
- platform/qt/editing/deleting/delete-after-span-ws-002-expected.png: Added.
- platform/qt/editing/deleting/delete-after-span-ws-002-expected.txt:
- platform/qt/editing/deleting/delete-after-span-ws-003-expected.checksum: Added.
- platform/qt/editing/deleting/delete-after-span-ws-003-expected.png: Added.
- platform/qt/editing/deleting/delete-after-span-ws-003-expected.txt:
- platform/qt/editing/deleting/delete-at-paragraph-boundaries-001-expected.checksum: Added.
- platform/qt/editing/deleting/delete-at-paragraph-boundaries-001-expected.png: Added.
- platform/qt/editing/deleting/delete-at-paragraph-boundaries-001-expected.txt:
- platform/qt/editing/deleting/delete-at-paragraph-boundaries-002-expected.checksum: Added.
- platform/qt/editing/deleting/delete-at-paragraph-boundaries-002-expected.png: Added.
- platform/qt/editing/deleting/delete-at-paragraph-boundaries-002-expected.txt:
- platform/qt/editing/deleting/delete-at-paragraph-boundaries-003-expected.checksum: Added.
- platform/qt/editing/deleting/delete-at-paragraph-boundaries-003-expected.png: Added.
- platform/qt/editing/deleting/delete-at-paragraph-boundaries-003-expected.txt:
- platform/qt/editing/deleting/delete-at-paragraph-boundaries-004-expected.checksum: Added.
- platform/qt/editing/deleting/delete-at-paragraph-boundaries-004-expected.png: Added.
- platform/qt/editing/deleting/delete-at-paragraph-boundaries-004-expected.txt:
- platform/qt/editing/deleting/delete-at-paragraph-boundaries-005-expected.checksum: Added.
- platform/qt/editing/deleting/delete-at-paragraph-boundaries-005-expected.png: Added.
- platform/qt/editing/deleting/delete-at-paragraph-boundaries-005-expected.txt:
- platform/qt/editing/deleting/delete-at-paragraph-boundaries-006-expected.checksum: Added.
- platform/qt/editing/deleting/delete-at-paragraph-boundaries-006-expected.png: Added.
- platform/qt/editing/deleting/delete-at-paragraph-boundaries-006-expected.txt:
- platform/qt/editing/deleting/delete-at-paragraph-boundaries-007-expected.checksum: Added.
- platform/qt/editing/deleting/delete-at-paragraph-boundaries-007-expected.png: Added.
- platform/qt/editing/deleting/delete-at-paragraph-boundaries-007-expected.txt:
- platform/qt/editing/deleting/delete-at-paragraph-boundaries-009-expected.checksum: Added.
- platform/qt/editing/deleting/delete-at-paragraph-boundaries-009-expected.png: Added.
- platform/qt/editing/deleting/delete-at-paragraph-boundaries-009-expected.txt:
- platform/qt/editing/deleting/delete-at-paragraph-boundaries-010-expected.checksum: Added.
- platform/qt/editing/deleting/delete-at-paragraph-boundaries-010-expected.png: Added.
- platform/qt/editing/deleting/delete-at-paragraph-boundaries-010-expected.txt:
- platform/qt/editing/deleting/delete-at-paragraph-boundaries-011-expected.checksum: Added.
- platform/qt/editing/deleting/delete-at-paragraph-boundaries-011-expected.png: Added.
- platform/qt/editing/deleting/delete-at-paragraph-boundaries-011-expected.txt:
- platform/qt/editing/deleting/delete-at-start-or-end-expected.checksum: Added.
- platform/qt/editing/deleting/delete-at-start-or-end-expected.png: Added.
- platform/qt/editing/deleting/delete-at-start-or-end-expected.txt:
- platform/qt/editing/deleting/delete-block-contents-001-expected.checksum: Added.
- platform/qt/editing/deleting/delete-block-contents-001-expected.png: Added.
- platform/qt/editing/deleting/delete-block-contents-001-expected.txt:
- platform/qt/editing/deleting/delete-block-contents-002-expected.checksum: Added.
- platform/qt/editing/deleting/delete-block-contents-002-expected.png: Added.
- platform/qt/editing/deleting/delete-block-contents-002-expected.txt:
- platform/qt/editing/deleting/delete-block-contents-003-expected.checksum: Added.
- platform/qt/editing/deleting/delete-block-contents-003-expected.png: Added.
- platform/qt/editing/deleting/delete-block-contents-003-expected.txt:
- platform/qt/editing/deleting/delete-block-merge-contents-001-expected.checksum: Added.
- platform/qt/editing/deleting/delete-block-merge-contents-001-expected.png: Added.
- platform/qt/editing/deleting/delete-block-merge-contents-001-expected.txt:
- platform/qt/editing/deleting/delete-block-merge-contents-002-expected.checksum: Added.
- platform/qt/editing/deleting/delete-block-merge-contents-002-expected.png: Added.
- platform/qt/editing/deleting/delete-block-merge-contents-002-expected.txt:
- platform/qt/editing/deleting/delete-block-merge-contents-003-expected.checksum: Added.
- platform/qt/editing/deleting/delete-block-merge-contents-003-expected.png: Added.
- platform/qt/editing/deleting/delete-block-merge-contents-003-expected.txt:
- platform/qt/editing/deleting/delete-block-merge-contents-004-expected.checksum: Added.
- platform/qt/editing/deleting/delete-block-merge-contents-004-expected.png: Added.
- platform/qt/editing/deleting/delete-block-merge-contents-004-expected.txt:
- platform/qt/editing/deleting/delete-block-merge-contents-005-expected.checksum: Added.
- platform/qt/editing/deleting/delete-block-merge-contents-005-expected.png: Added.
- platform/qt/editing/deleting/delete-block-merge-contents-005-expected.txt:
- platform/qt/editing/deleting/delete-block-merge-contents-006-expected.checksum: Added.
- platform/qt/editing/deleting/delete-block-merge-contents-006-expected.png: Added.
- platform/qt/editing/deleting/delete-block-merge-contents-006-expected.txt:
- platform/qt/editing/deleting/delete-block-merge-contents-007-expected.checksum: Added.
- platform/qt/editing/deleting/delete-block-merge-contents-007-expected.png: Added.
- platform/qt/editing/deleting/delete-block-merge-contents-007-expected.txt:
- platform/qt/editing/deleting/delete-block-merge-contents-008-expected.checksum: Added.
- platform/qt/editing/deleting/delete-block-merge-contents-008-expected.png: Added.
- platform/qt/editing/deleting/delete-block-merge-contents-008-expected.txt:
- platform/qt/editing/deleting/delete-block-merge-contents-009-expected.checksum: Added.
- platform/qt/editing/deleting/delete-block-merge-contents-009-expected.png: Added.
- platform/qt/editing/deleting/delete-block-merge-contents-009-expected.txt:
- platform/qt/editing/deleting/delete-block-merge-contents-010-expected.checksum: Added.
- platform/qt/editing/deleting/delete-block-merge-contents-010-expected.png: Added.
- platform/qt/editing/deleting/delete-block-merge-contents-010-expected.txt:
- platform/qt/editing/deleting/delete-block-merge-contents-011-expected.checksum: Added.
- platform/qt/editing/deleting/delete-block-merge-contents-011-expected.png: Added.
- platform/qt/editing/deleting/delete-block-merge-contents-011-expected.txt:
- platform/qt/editing/deleting/delete-block-merge-contents-012-expected.checksum: Added.
- platform/qt/editing/deleting/delete-block-merge-contents-012-expected.png: Added.
- platform/qt/editing/deleting/delete-block-merge-contents-012-expected.txt:
- platform/qt/editing/deleting/delete-block-merge-contents-013-expected.checksum: Added.
- platform/qt/editing/deleting/delete-block-merge-contents-013-expected.png: Added.
- platform/qt/editing/deleting/delete-block-merge-contents-013-expected.txt:
- platform/qt/editing/deleting/delete-block-merge-contents-014-expected.checksum: Added.
- platform/qt/editing/deleting/delete-block-merge-contents-014-expected.png: Added.
- platform/qt/editing/deleting/delete-block-merge-contents-014-expected.txt:
- platform/qt/editing/deleting/delete-block-merge-contents-015-expected.checksum: Added.
- platform/qt/editing/deleting/delete-block-merge-contents-015-expected.png: Added.
- platform/qt/editing/deleting/delete-block-merge-contents-015-expected.txt:
- platform/qt/editing/deleting/delete-block-merge-contents-016-expected.checksum: Added.
- platform/qt/editing/deleting/delete-block-merge-contents-016-expected.png: Added.
- platform/qt/editing/deleting/delete-block-merge-contents-016-expected.txt:
- platform/qt/editing/deleting/delete-block-merge-contents-017-expected.checksum: Added.
- platform/qt/editing/deleting/delete-block-merge-contents-017-expected.png: Added.
- platform/qt/editing/deleting/delete-block-merge-contents-017-expected.txt:
- platform/qt/editing/deleting/delete-block-merge-contents-019-expected.checksum: Added.
- platform/qt/editing/deleting/delete-block-merge-contents-019-expected.png: Added.
- platform/qt/editing/deleting/delete-block-merge-contents-019-expected.txt:
- platform/qt/editing/deleting/delete-block-merge-contents-020-expected.checksum: Added.
- platform/qt/editing/deleting/delete-block-merge-contents-020-expected.png: Added.
- platform/qt/editing/deleting/delete-block-merge-contents-020-expected.txt:
- platform/qt/editing/deleting/delete-block-merge-contents-023-expected.checksum: Added.
- platform/qt/editing/deleting/delete-block-merge-contents-023-expected.png: Added.
- platform/qt/editing/deleting/delete-block-merge-contents-023-expected.txt:
- platform/qt/editing/deleting/delete-block-merge-contents-024-expected.checksum: Added.
- platform/qt/editing/deleting/delete-block-merge-contents-024-expected.png: Added.
- platform/qt/editing/deleting/delete-block-merge-contents-024-expected.txt:
- platform/qt/editing/deleting/delete-br-001-expected.checksum: Added.
- platform/qt/editing/deleting/delete-br-001-expected.png: Added.
- platform/qt/editing/deleting/delete-br-001-expected.txt:
- platform/qt/editing/deleting/delete-br-002-expected.checksum: Added.
- platform/qt/editing/deleting/delete-br-002-expected.png: Added.
- platform/qt/editing/deleting/delete-br-002-expected.txt:
- platform/qt/editing/deleting/delete-br-003-expected.checksum: Added.
- platform/qt/editing/deleting/delete-br-003-expected.png: Added.
- platform/qt/editing/deleting/delete-br-003-expected.txt:
- platform/qt/editing/deleting/delete-br-004-expected.checksum: Added.
- platform/qt/editing/deleting/delete-br-004-expected.png: Added.
- platform/qt/editing/deleting/delete-br-004-expected.txt:
- platform/qt/editing/deleting/delete-br-005-expected.checksum: Added.
- platform/qt/editing/deleting/delete-br-005-expected.png: Added.
- platform/qt/editing/deleting/delete-br-005-expected.txt:
- platform/qt/editing/deleting/delete-br-006-expected.checksum: Added.
- platform/qt/editing/deleting/delete-br-006-expected.png: Added.
- platform/qt/editing/deleting/delete-br-006-expected.txt:
- platform/qt/editing/deleting/delete-br-008-expected.checksum: Added.
- platform/qt/editing/deleting/delete-br-008-expected.png: Added.
- platform/qt/editing/deleting/delete-br-008-expected.txt:
- platform/qt/editing/deleting/delete-br-009-expected.checksum: Added.
- platform/qt/editing/deleting/delete-br-009-expected.png: Added.
- platform/qt/editing/deleting/delete-br-009-expected.txt:
- platform/qt/editing/deleting/delete-br-010-expected.checksum: Added.
- platform/qt/editing/deleting/delete-br-010-expected.png: Added.
- platform/qt/editing/deleting/delete-br-010-expected.txt:
- platform/qt/editing/deleting/delete-br-011-expected.checksum: Added.
- platform/qt/editing/deleting/delete-br-011-expected.png: Added.
- platform/qt/editing/deleting/delete-br-012-expected.checksum: Added.
- platform/qt/editing/deleting/delete-br-012-expected.png: Added.
- platform/qt/editing/deleting/delete-br-013-expected.checksum: Added.
- platform/qt/editing/deleting/delete-br-013-expected.png: Added.
- platform/qt/editing/deleting/delete-br-013-expected.txt: Added.
- platform/qt/editing/deleting/delete-br-in-last-table-cell-expected.checksum: Added.
- platform/qt/editing/deleting/delete-br-in-last-table-cell-expected.png: Added.
- platform/qt/editing/deleting/delete-by-word-001-expected.checksum: Added.
- platform/qt/editing/deleting/delete-by-word-001-expected.png: Added.
- platform/qt/editing/deleting/delete-by-word-001-expected.txt:
- platform/qt/editing/deleting/delete-by-word-002-expected.checksum: Added.
- platform/qt/editing/deleting/delete-by-word-002-expected.png: Added.
- platform/qt/editing/deleting/delete-by-word-002-expected.txt:
- platform/qt/editing/deleting/delete-character-001-expected.checksum: Added.
- platform/qt/editing/deleting/delete-character-001-expected.png: Added.
- platform/qt/editing/deleting/delete-character-001-expected.txt:
- platform/qt/editing/deleting/delete-first-list-item-expected.checksum: Added.
- platform/qt/editing/deleting/delete-first-list-item-expected.png: Added.
- platform/qt/editing/deleting/delete-first-list-item-expected.txt:
- platform/qt/editing/deleting/delete-hr-expected.checksum: Added.
- platform/qt/editing/deleting/delete-hr-expected.png: Added.
- platform/qt/editing/deleting/delete-hr-expected.txt:
- platform/qt/editing/deleting/delete-image-001-expected.checksum: Added.
- platform/qt/editing/deleting/delete-image-001-expected.png: Added.
- platform/qt/editing/deleting/delete-image-001-expected.txt:
- platform/qt/editing/deleting/delete-image-002-expected.checksum: Added.
- platform/qt/editing/deleting/delete-image-002-expected.png: Added.
- platform/qt/editing/deleting/delete-image-002-expected.txt:
- platform/qt/editing/deleting/delete-image-003-expected.checksum: Added.
- platform/qt/editing/deleting/delete-image-003-expected.png: Added.
- platform/qt/editing/deleting/delete-image-003-expected.txt:
- platform/qt/editing/deleting/delete-image-004-expected.checksum: Added.
- platform/qt/editing/deleting/delete-image-004-expected.png: Added.
- platform/qt/editing/deleting/delete-image-004-expected.txt:
- platform/qt/editing/deleting/delete-line-001-expected.checksum: Added.
- platform/qt/editing/deleting/delete-line-001-expected.png: Added.
- platform/qt/editing/deleting/delete-line-001-expected.txt:
- platform/qt/editing/deleting/delete-line-002-expected.checksum: Added.
- platform/qt/editing/deleting/delete-line-002-expected.png: Added.
- platform/qt/editing/deleting/delete-line-002-expected.txt:
- platform/qt/editing/deleting/delete-line-003-expected.checksum: Added.
- platform/qt/editing/deleting/delete-line-003-expected.png: Added.
- platform/qt/editing/deleting/delete-line-003-expected.txt:
- platform/qt/editing/deleting/delete-line-004-expected.checksum: Added.
- platform/qt/editing/deleting/delete-line-004-expected.png: Added.
- platform/qt/editing/deleting/delete-line-004-expected.txt:
- platform/qt/editing/deleting/delete-line-005-expected.checksum: Added.
- platform/qt/editing/deleting/delete-line-005-expected.png: Added.
- platform/qt/editing/deleting/delete-line-005-expected.txt:
- platform/qt/editing/deleting/delete-line-006-expected.checksum: Added.
- platform/qt/editing/deleting/delete-line-006-expected.png: Added.
- platform/qt/editing/deleting/delete-line-006-expected.txt:
- platform/qt/editing/deleting/delete-line-007-expected.checksum: Added.
- platform/qt/editing/deleting/delete-line-007-expected.png: Added.
- platform/qt/editing/deleting/delete-line-007-expected.txt:
- platform/qt/editing/deleting/delete-line-008-expected.checksum: Added.
- platform/qt/editing/deleting/delete-line-008-expected.png: Added.
- platform/qt/editing/deleting/delete-line-008-expected.txt:
- platform/qt/editing/deleting/delete-line-009-expected.checksum: Added.
- platform/qt/editing/deleting/delete-line-009-expected.png: Added.
- platform/qt/editing/deleting/delete-line-009-expected.txt:
- platform/qt/editing/deleting/delete-line-010-expected.checksum: Added.
- platform/qt/editing/deleting/delete-line-010-expected.png: Added.
- platform/qt/editing/deleting/delete-line-010-expected.txt:
- platform/qt/editing/deleting/delete-line-011-expected.checksum: Added.
- platform/qt/editing/deleting/delete-line-011-expected.png: Added.
- platform/qt/editing/deleting/delete-line-011-expected.txt:
- platform/qt/editing/deleting/delete-line-012-expected.checksum: Added.
- platform/qt/editing/deleting/delete-line-012-expected.png: Added.
- platform/qt/editing/deleting/delete-line-012-expected.txt:
- platform/qt/editing/deleting/delete-line-013-expected.checksum: Added.
- platform/qt/editing/deleting/delete-line-013-expected.png: Added.
- platform/qt/editing/deleting/delete-line-013-expected.txt:
- platform/qt/editing/deleting/delete-line-014-expected.checksum: Added.
- platform/qt/editing/deleting/delete-line-014-expected.png: Added.
- platform/qt/editing/deleting/delete-line-014-expected.txt:
- platform/qt/editing/deleting/delete-line-015-expected.checksum: Added.
- platform/qt/editing/deleting/delete-line-015-expected.png: Added.
- platform/qt/editing/deleting/delete-line-015-expected.txt:
- platform/qt/editing/deleting/delete-line-016-expected.checksum: Added.
- platform/qt/editing/deleting/delete-line-016-expected.png: Added.
- platform/qt/editing/deleting/delete-line-016-expected.txt:
- platform/qt/editing/deleting/delete-line-017-expected.checksum: Added.
- platform/qt/editing/deleting/delete-line-017-expected.png: Added.
- platform/qt/editing/deleting/delete-line-017-expected.txt:
- platform/qt/editing/deleting/delete-line-end-ws-001-expected.checksum: Added.
- platform/qt/editing/deleting/delete-line-end-ws-001-expected.png: Added.
- platform/qt/editing/deleting/delete-line-end-ws-001-expected.txt:
- platform/qt/editing/deleting/delete-mixed-editable-content-001-expected.checksum: Added.
- platform/qt/editing/deleting/delete-mixed-editable-content-001-expected.png: Added.
- platform/qt/editing/deleting/delete-select-all-001-expected.checksum: Added.
- platform/qt/editing/deleting/delete-select-all-001-expected.png: Added.
- platform/qt/editing/deleting/delete-select-all-002-expected.checksum: Added.
- platform/qt/editing/deleting/delete-select-all-002-expected.png: Added.
- platform/qt/editing/deleting/delete-select-all-002-expected.txt:
- platform/qt/editing/deleting/delete-select-all-003-expected.checksum: Added.
- platform/qt/editing/deleting/delete-select-all-003-expected.png: Added.
- platform/qt/editing/deleting/delete-select-all-003-expected.txt:
- platform/qt/editing/deleting/delete-selection-001-expected.checksum: Added.
- platform/qt/editing/deleting/delete-selection-001-expected.png: Added.
- platform/qt/editing/deleting/delete-selection-001-expected.txt:
- platform/qt/editing/deleting/delete-to-end-of-paragraph-expected.checksum: Added.
- platform/qt/editing/deleting/delete-to-end-of-paragraph-expected.png: Added.
- platform/qt/editing/deleting/delete-to-end-of-paragraph-expected.txt: Copied from LayoutTests/platform/qt/editing/deleting/delete-line-009-expected.txt.
- platform/qt/editing/deleting/delete-to-select-table-expected.checksum: Added.
- platform/qt/editing/deleting/delete-to-select-table-expected.png: Added.
- platform/qt/editing/deleting/delete-to-select-table-expected.txt:
- platform/qt/editing/deleting/delete-trailing-ws-001-expected.checksum: Added.
- platform/qt/editing/deleting/delete-trailing-ws-001-expected.png: Added.
- platform/qt/editing/deleting/delete-trailing-ws-001-expected.txt:
- platform/qt/editing/deleting/delete-trailing-ws-002-expected.checksum: Added.
- platform/qt/editing/deleting/delete-trailing-ws-002-expected.png: Added.
- platform/qt/editing/deleting/delete-trailing-ws-002-expected.txt:
- platform/qt/editing/deleting/list-item-1-expected.checksum: Added.
- platform/qt/editing/deleting/list-item-1-expected.png: Added.
- platform/qt/editing/deleting/list-item-1-expected.txt:
- platform/qt/editing/deleting/merge-different-styles-expected.checksum: Added.
- platform/qt/editing/deleting/merge-different-styles-expected.png: Added.
- platform/qt/editing/deleting/merge-different-styles-expected.txt:
- platform/qt/editing/deleting/merge-endOfParagraph-expected.checksum: Added.
- platform/qt/editing/deleting/merge-endOfParagraph-expected.png: Added.
- platform/qt/editing/deleting/merge-endOfParagraph-expected.txt:
- platform/qt/editing/deleting/merge-into-empty-block-1-expected.checksum: Added.
- platform/qt/editing/deleting/merge-into-empty-block-1-expected.png: Added.
- platform/qt/editing/deleting/merge-into-empty-block-1-expected.txt:
- platform/qt/editing/deleting/merge-into-empty-block-2-expected.checksum: Added.
- platform/qt/editing/deleting/merge-into-empty-block-2-expected.png: Added.
- platform/qt/editing/deleting/merge-into-empty-block-2-expected.txt:
- platform/qt/editing/deleting/merge-no-br-expected.checksum: Added.
- platform/qt/editing/deleting/merge-no-br-expected.png: Added.
- platform/qt/editing/deleting/merge-no-br-expected.txt:
- platform/qt/editing/deleting/merge-unrendered-space-expected.checksum: Added.
- platform/qt/editing/deleting/merge-unrendered-space-expected.png: Added.
- platform/qt/editing/deleting/merge-unrendered-space-expected.txt:
- platform/qt/editing/deleting/merge-whitespace-pre-expected.checksum: Added.
- platform/qt/editing/deleting/merge-whitespace-pre-expected.png: Added.
- platform/qt/editing/deleting/merge-whitespace-pre-expected.txt:
- platform/qt/editing/deleting/move-nodes-001-expected.checksum: Added.
- platform/qt/editing/deleting/move-nodes-001-expected.png: Added.
- platform/qt/editing/deleting/move-nodes-001-expected.txt:
- platform/qt/editing/deleting/paragraph-in-preserveNewline-expected.checksum: Added.
- platform/qt/editing/deleting/paragraph-in-preserveNewline-expected.png: Added.
- platform/qt/editing/deleting/paragraph-in-preserveNewline-expected.txt:
- platform/qt/editing/deleting/pruning-after-merge-2-expected.checksum: Added.
- platform/qt/editing/deleting/pruning-after-merge-2-expected.png: Added.
- platform/qt/editing/deleting/pruning-after-merge-2-expected.txt:
- platform/qt/editing/deleting/smart-delete-001-expected.checksum: Added.
- platform/qt/editing/deleting/smart-delete-001-expected.png: Added.
- platform/qt/editing/deleting/smart-delete-001-expected.txt:
- platform/qt/editing/deleting/table-cells-expected.checksum: Added.
- platform/qt/editing/deleting/table-cells-expected.png: Added.
- platform/qt/editing/deleting/table-cells-expected.txt:
- platform/qt/editing/deleting/type-delete-after-quote-expected.checksum: Added.
- platform/qt/editing/deleting/type-delete-after-quote-expected.png: Added.
- platform/qt/editing/deleting/type-delete-after-quote-expected.txt: Added.
- platform/qt/editing/deleting/whitespace-pre-1-expected.checksum: Added.
- platform/qt/editing/deleting/whitespace-pre-1-expected.png: Added.
- platform/qt/editing/deleting/whitespace-pre-1-expected.txt:
- 6:20 AM Changeset in webkit [71517] by
-
- 4 edits6 adds in trunk/LayoutTests
Update Windows results after r71465
- platform/win/fast/blockflow/border-vertical-lr-expected.checksum:
- platform/win/fast/blockflow/border-vertical-lr-expected.png:
- platform/win/fast/blockflow/border-vertical-lr-expected.txt:
- platform/win/fast/blockflow/japanese-lr-selection-expected.checksum: Added.
- platform/win/fast/blockflow/japanese-lr-selection-expected.png: Added.
- platform/win/fast/blockflow/japanese-lr-selection-expected.txt: Added.
- platform/win/fast/blockflow/japanese-rl-selection-expected.checksum: Added.
- platform/win/fast/blockflow/japanese-rl-selection-expected.png: Added.
- platform/win/fast/blockflow/japanese-rl-selection-expected.txt: Added.
- 6:18 AM Changeset in webkit [71516] by
-
- 2 edits in trunk/WebKitTools
Switch back to using kCGImageAlphaPremultipliedFirst when generating pixel dumps on Windows
I changed this behavior in r71418 thinking that it was required for
getting plugins to show up in pixel dumps. But it doesn't seem to be
necessary, and was making it impossible to compare new Windows pixel
dumps with existing Windows or Mac pixel dumps (because ImageDiff won't
compare an image with alpha to an image without alpha).
Fixes <http://webkit.org/b/49172> REGRESION (r71418): Can't compare
new Windows pixel results to existing Windows or Mac results
Reviewed by Antti Koivisto.
- DumpRenderTree/win/PixelDumpSupportWin.cpp:
(createBitmapContextFromWebView): Replaced kCGImageAlphaNoneSkipFirst
with kCGImageAlphaPremultipliedFirst.
- 6:05 AM Changeset in webkit [71515] by
-
- 30 edits4 copies6 moves2 deletes in trunk/WebCore
2010-11-08 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: decouple ScriptArguments from ScriptCallStack
https://bugs.webkit.org/show_bug.cgi?id=48058
ScriptCallFrame and ScriptCallStack are now the same for both JSC and V8.
The factory functions that allow to create ScriptCallStack from VM-specific
objects are defined in ScriptCallStackFactory.cpp.
ScriptArguments class is used for passing arguments from JS code to the native
part.
No new tests. This refactoring is covered with existing Console tests.
- Android.jscbindings.mk:
- Android.v8bindings.mk:
- CMakeLists.txt:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSBindingsAllInOne.cpp:
- bindings/js/JSConsoleCustom.cpp: (WebCore::JSConsole::profile): (WebCore::JSConsole::profileEnd):
- bindings/js/ScriptCallStackFactory.cpp: Renamed from WebCore/bindings/js/ScriptCallStack.cpp. (WebCore::createScriptCallStack): (WebCore::createScriptArguments): (WebCore::ScriptCallStack::stackTrace):
- bindings/js/ScriptCallStackFactory.h: Copied from WebCore/bindings/js/ScriptCallFrame.cpp.
- bindings/js/ScriptState.cpp: (WebCore::ScriptStateProtectedPtr::~ScriptStateProtectedPtr): (WebCore::ScriptStateProtectedPtr::ScriptStateProtectedPtr): (WebCore::ScriptStateProtectedPtr::get):
- bindings/js/ScriptState.h:
- bindings/scripts/CodeGeneratorJS.pm:
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/scripts/test/JS/JSTestObj.cpp: (WebCore::jsTestObjPrototypeFunctionCustomArgsAndException):
- bindings/scripts/test/V8/V8TestObj.cpp: (WebCore::TestObjInternal::customArgsAndExceptionCallback):
- bindings/v8/ScriptCallFrame.h: Removed.
- bindings/v8/ScriptCallStack.h: Removed.
- bindings/v8/ScriptCallStackFactory.cpp: Renamed from WebCore/bindings/v8/ScriptCallStack.cpp. (WebCore::toScriptCallFrame): (WebCore::toScriptCallFramesVector): (WebCore::createScriptCallStack): (WebCore::createScriptArguments): (WebCore::ScriptCallStack::stackTrace):
- bindings/v8/ScriptCallStackFactory.h: Copied from WebCore/bindings/js/ScriptCallFrame.cpp.
- bindings/v8/ScriptController.cpp: (WebCore::ScriptController::setCaptureCallStackForUncaughtExceptions):
- bindings/v8/ScriptState.h: (WebCore::ScriptStateProtectedPtr::get):
- bindings/v8/V8ConsoleMessage.cpp: (WebCore::V8ConsoleMessage::handler): (WebCore::V8ConsoleMessage::dispatchNow):
- bindings/v8/V8ConsoleMessage.h:
- bindings/v8/custom/V8ConsoleCustom.cpp: (WebCore::V8Console::traceCallback): (WebCore::V8Console::assertCallback): (WebCore::V8Console::profileCallback): (WebCore::V8Console::profileEndCallback):
- dom/NodeFilter.h:
- inspector/ConsoleMessage.cpp: (WebCore::ConsoleMessage::ConsoleMessage): (WebCore::ConsoleMessage::addToFrontend): (WebCore::ConsoleMessage::updateRepeatCountInConsole): (WebCore::ConsoleMessage::isEqual):
- inspector/ConsoleMessage.h:
- inspector/InspectorController.cpp: (WebCore::InspectorController::addMessageToConsole): (WebCore::InspectorController::startGroup):
- inspector/InspectorController.h:
- inspector/ScriptArguments.cpp: Copied from WebCore/bindings/v8/ScriptCallFrame.cpp. (WebCore::ScriptArguments::ScriptArguments): (WebCore::ScriptArguments::~ScriptArguments): (WebCore::ScriptArguments::argumentAt): (WebCore::ScriptArguments::globalState): (WebCore::ScriptArguments::getFirstArgumentAsString): (WebCore::ScriptArguments::isEqual):
- inspector/ScriptArguments.h: Copied from WebCore/bindings/js/ScriptCallFrame.h. (WebCore::ScriptArguments::argumentCount):
- inspector/ScriptCallFrame.cpp: Renamed from WebCore/bindings/v8/ScriptCallFrame.cpp. (WebCore::ScriptCallFrame::ScriptCallFrame): (WebCore::ScriptCallFrame::~ScriptCallFrame): (WebCore::ScriptCallFrame::isEqual): (WebCore::ScriptCallFrame::buildInspectorObject):
- inspector/ScriptCallFrame.h: Renamed from WebCore/bindings/js/ScriptCallFrame.h. (WebCore::ScriptCallFrame::functionName): (WebCore::ScriptCallFrame::sourceURL): (WebCore::ScriptCallFrame::lineNumber):
- inspector/ScriptCallStack.cpp: Renamed from WebCore/bindings/js/ScriptCallFrame.cpp. (WebCore::ScriptCallStack::ScriptCallStack): (WebCore::ScriptCallStack::~ScriptCallStack): (WebCore::ScriptCallStack::at): (WebCore::ScriptCallStack::size): (WebCore::ScriptCallStack::isEqual): (WebCore::ScriptCallStack::buildInspectorObject):
- inspector/ScriptCallStack.h: Renamed from WebCore/bindings/js/ScriptCallStack.h.
- page/Console.cpp: (WebCore::Console::addMessage): (WebCore::Console::debug): (WebCore::Console::error): (WebCore::Console::info): (WebCore::Console::log): (WebCore::Console::dir): (WebCore::Console::dirxml): (WebCore::Console::trace): (WebCore::Console::assertCondition): (WebCore::Console::count): (WebCore::Console::markTimeline): (WebCore::Console::profile): (WebCore::Console::profileEnd): (WebCore::Console::timeEnd): (WebCore::Console::group): (WebCore::Console::groupCollapsed): (WebCore::Console::shouldCaptureFullStackTrace): (WebCore::Console::warn):
- page/Console.h: (WebCore::Console::profiles):
- page/Console.idl:
- 6:00 AM Changeset in webkit [71514] by
-
- 2 edits in trunk/WebCore
2010-11-08 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Build fix.
Attempt to fix windows builds after r71512. Swap order of members to avoid warning C4121.
- svg/properties/SVGStaticPropertyTearOff.h: (WebCore::SVGStaticPropertyTearOff::SVGStaticPropertyTearOff):
- 5:49 AM Changeset in webkit [71513] by
-
- 2 edits in trunk/WebCore
2010-11-08 Mikhail Naganov <mnaganov@chromium.org>
Unreviewed. Fix Qt build after r71511.
- inspector/InspectorController.cpp: (WebCore::InspectorController::restoreInspectorStateFromCookie):
- 5:43 AM Changeset in webkit [71512] by
-
- 40 edits4 adds3 deletes in trunk
2010-11-08 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
Convert SVGPoint/SVGPointList to the new SVGPropertyTearOff concept
https://bugs.webkit.org/show_bug.cgi?id=49067
Remove SVGAnimatedPoints interface, not reachable through bindings anyway, it was just another MI interface, that
now has been integrated into SVGPolylineElement/SVGPolygonElement, simplfying the generation and avoiding virtual
calls in SVGPolylineElement/SVGPolygonElement.
Remove the need to use manual XML <-> SVG DOM synchronization. The points/animatedPoints methods now create
SVGListPropertyTearOffs, thus using the same synchronization/expose-to-bindings concept like all other
animated properties.
Convert SVGPoint/SVGPointList to use the new SVGPropertyTearOff concept, adapted all code, as SVGPointList
is now a plain Vector<FloatPoint>. Enable StrictTypeChecking for SVGPoint.
Test: svg/dom/SVGPoint.html
- Android.derived.v8bindings.mk: Remove SVGAnimatedPoints (and IDL generation).
- Android.mk: Ditto.
- CMakeLists.txt: Ditto.
- DerivedSources.make: Ditto.
- GNUmakefile.am: Ditto. Add SVGStaticPropertyTearOff.h to build.
- WebCore.gypi: Ditto.
- WebCore.order: Remove SVGAnimatedPoints symbols.
- WebCore.pro: Remove SVGAnimatedPoints (and IDL generation). Add SVGStaticPropertyTearOff.h to build.
- WebCore.vcproj/WebCore.vcproj: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- bindings/objc/DOMSVG.h: Remove DOMSVGAnimatedPoints include.
- bindings/scripts/CodeGenerator.pm: Adapt code converting SVGPoint/SVGPointList to use the new SVGPropertyTearOff concepts.
- bindings/scripts/CodeGeneratorJS.pm: Ditto.
- bindings/scripts/CodeGeneratorObjC.pm: Ditto.
- bindings/scripts/CodeGeneratorV8.pm: Ditto.
- rendering/SVGRenderTreeAsText.cpp: Adapt for SVGPolyElement API change, use pointList() instead of points() (which is only used for bindings now). (WebCore::operator<<):
- svg/SVGAllInOne.cpp: Remove SVGAnimatedPoints.cpp.
- svg/SVGAnimateElement.cpp: Adapt for SVGPointList API change, it's not refcounted anymore. (WebCore::SVGAnimateElement::calculateAnimatedValue): (WebCore::SVGAnimateElement::calculateFromAndToValues): (WebCore::SVGAnimateElement::applyResultsToTarget):
- svg/SVGAnimateElement.h: Ditto.
- svg/SVGAnimatedPoints.cpp: Removed.
- svg/SVGAnimatedPoints.h: Removed.
- svg/SVGAnimatedPoints.idl: Removed.
- svg/SVGParserUtilities.cpp: Adapt for SVGPointList API change, it's not refcounted anymore. (WebCore::pointsListFromSVGData):
- svg/SVGParserUtilities.h: Ditto.
- svg/SVGPoint.idl: Remove PODType marker, and add StrictTypeChecking for x/y attributes.
- svg/SVGPointList.cpp: SVGPointList is now a plain Vector<FloatPoint>, rewrite. (WebCore::SVGPointList::valueAsString): (WebCore::SVGPointList::createAnimated):
- svg/SVGPointList.h: Ditto. (WebCore::SVGPointList::SVGPointList):
- svg/SVGPolyElement.cpp: Remove manual SVG <-> XML DOM synchronization. Now handles through the SVGAnimatedPropertyTearOff concept. (WebCore::SVGPolyElement::parseMappedAttribute): (WebCore::SVGPolyElement::svgAttributeChanged): (WebCore::SVGPolyElement::synchronizeProperty): (WebCore::SVGPolyElement::synchronizePoints): (WebCore::SVGPolyElement::points): (WebCore::SVGPolyElement::animatedPoints):
- svg/SVGPolyElement.h: Reindented. (WebCore::SVGPolyElement::pointList): (WebCore::SVGPolyElement::isValid): (WebCore::SVGPolyElement::supportsMarkers):
- svg/SVGPolygonElement.cpp: Adapt for SVGPointList API change. (WebCore::SVGPolygonElement::toPathData):
- svg/SVGPolygonElement.idl: Remove SVGAnimatedPoints inheritance.
- svg/SVGPolylineElement.cpp: Adapt for SVGPointList API change. (WebCore::SVGPolylineElement::toPathData):
- svg/SVGPolylineElement.idl: Remove SVGAnimatedPoints inheritance.
- svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::setCurrentTranslate): Use updateCurrentTranslate(). (WebCore::SVGSVGElement::updateCurrentTranslate): Added, only used by the bindings, after changing a value of SVGStaticPropertyTearOff object.
- svg/SVGSVGElement.h: (WebCore::SVGSVGElement::currentTranslate): Return reference to m_translation.
- svg/properties/SVGPropertyTearOff.h: Made constructors protected, as SVGStaticPropertyTearOff inherits from it. (WebCore::SVGPropertyTearOff::commitChange):
- svg/properties/SVGPropertyTraits.h: Add SVGPointList handing.
- svg/properties/SVGStaticPropertyTearOff.h: Added. Used for SVGProperty types returned by attributes, that are not associated with a SVGAnimatedProperty. (SVGSVGElement::currentTranslate). (WebCore::SVGStaticPropertyTearOff::create): (WebCore::SVGStaticPropertyTearOff::commitChange): (WebCore::SVGStaticPropertyTearOff::SVGStaticPropertyTearOff):
2010-11-08 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
Convert SVGPoint/SVGPointList to the new SVGPropertyTearOff concept
https://bugs.webkit.org/show_bug.cgi?id=49067
- platform/mac/svg/custom/use-property-synchronization-crash-expected.txt: Cloned <polyline> now reports parsing problems as well.
- svg/custom/polyline-points-crash-expected.txt: Update expectation.
- svg/custom/polyline-points-crash.html: appendItem(null) now throws, catch exception.
- svg/dom/points-parser.html: Fix failure reporting, use correct variable name.
- 5:38 AM Changeset in webkit [71511] by
-
- 10 edits in trunk/WebCore
2010-11-08 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Adam Barth.
Web Inspector [Chromium]: Make CPU profiling to survive navigation.
- inspector/Inspector.idl:
- inspector/InspectorController.cpp: (WebCore::InspectorController::restoreInspectorStateFromCookie): (WebCore::InspectorController::reuseFrontend): (WebCore::InspectorController::disconnectFrontend): (WebCore::InspectorController::populateScriptObjects): (WebCore::InspectorController::restoreProfiler): (WebCore::InspectorController::didCommitLoad): (WebCore::InspectorController::startUserInitiatedProfiling): (WebCore::InspectorController::stopUserInitiatedProfiling):
- inspector/InspectorController.h: (WebCore::InspectorController::startProfiling): (WebCore::InspectorController::stopProfiling):
- inspector/InspectorProfilerAgent.cpp: (WebCore::InspectorProfilerAgent::startUserInitiatedProfiling): (WebCore::InspectorProfilerAgent::stopUserInitiatedProfiling):
- inspector/InspectorProfilerAgent.h:
- inspector/InspectorState.cpp: (WebCore::InspectorState::InspectorState):
- inspector/InspectorState.h:
- inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype.hasTemporaryProfile): (WebInspector.ProfilesPanel.prototype.hasProfile):
- inspector/front-end/inspector.js: (WebInspector.setRecordingProfile):
- 3:58 AM Changeset in webkit [71510] by
-
- 6 edits in trunk
2010-11-08 Csaba Osztrogonac <Csaba Osztrogonác>
Unreviewed, rolling out r71466.
http://trac.webkit.org/changeset/71466
https://bugs.webkit.org/show_bug.cgi?id=48865
It broke layout tests on GTK bots.
- WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::closeWindowSoon):
- webkit/webkitprivate.h:
- webkit/webkitwebview.cpp: (webkit_web_view_init): (webkit_web_view_set_group_name):
2010-11-08 Csaba Osztrogonac <Csaba Osztrogonác>
Unreviewed, rolling out r71466.
http://trac.webkit.org/changeset/71466
https://bugs.webkit.org/show_bug.cgi?id=48865
It broke layout tests on GTK bots.
- DumpRenderTree/gtk/DumpRenderTree.cpp: (createWebView):
- 2:50 AM Changeset in webkit [71509] by
-
- 2 edits in trunk/WebKitTools
Enable running of Qt API tests on BuildBot
https://bugs.webkit.org/show_bug.cgi?id=49004
Patch by Gabor Rapcsanyi <rgabor@inf.u-szeged.hu> on 2010-11-08
Reviewed by Csaba Osztrogonác.
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
- 2:43 AM Changeset in webkit [71508] by
-
- 6 edits50 adds in trunk
WebCore: SVGFEConvolveMatrixElement doesn't support dynamic invalidation
https://bugs.webkit.org/show_bug.cgi?id=47660
Patch by Renata Hodovan <reni@webkit.org> on 2010-11-08
Reviewed by Nikolas Zimmermann.
Wrap orderX and orderY into the common order property according to the w3 standard and remove them from svnattrs.in.
The patch implements the orderXIdentifier and orderYIdentifier getter functions to reach
properly the orderX and orderY components of order property from SVG DOM.
Tests: svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop.html
svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop.html
svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-edgeMode-prop.html
svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop.html
svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop.html
svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop.html
svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop.html
svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop.html
svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop.html
svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetY-prop.html
- svg/SVGFEConvolveMatrixElement.cpp:
(WebCore::SVGFEConvolveMatrixElement::orderXIdentifier):
(WebCore::SVGFEConvolveMatrixElement::orderYIdentifier):
- svg/SVGFEConvolveMatrixElement.h:
- svg/svgattrs.in:
LayoutTests: SVGFEConvolveMatrixElement doesn't support dynamic invalidation, when attributes change.
https://bugs.webkit.org/show_bug.cgi?id=47660
Patch by Renata Hodovan <reni@webkit.org> on 2010-11-08
Reviewed by Nikolas Zimmermann.
This patch contains the SVG DOM dynamic update tests of feConvolveMatrix and it
fixes the DOM test of order attribute because the product of order components should be equal the
size of the kernelMatrix.
- platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-edgeMode-prop-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-edgeMode-prop-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetY-prop-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetY-prop-expected.png: Added.
- svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop-expected.txt: Added.
- svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop.html: Added.
- svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop-expected.txt: Added.
- svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop.html: Added.
- svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-edgeMode-prop-expected.txt: Added.
- svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-edgeMode-prop.html: Added.
- svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop-expected.txt: Added.
- svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop.html: Added.
- svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop-expected.txt: Added.
- svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop.html: Added.
- svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop-expected.txt: Added.
- svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop.html: Added.
- svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop-expected.txt: Added.
- svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop.html: Added.
- svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop-expected.txt: Added.
- svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop.html: Added.
- svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.txt: Added.
- svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop.html: Added.
- svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetY-prop-expected.txt: Added.
- svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetY-prop.html: Added.
- svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-dom-order-attr.js:
(executeTest):
- svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-svgdom-bias-prop.js: Added.
(executeTest):
- svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-svgdom-divisor-prop.js: Added.
(executeTest):
- svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-svgdom-edgeMode-prop.js: Added.
(executeTest):
- svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-svgdom-in-prop.js: Added.
(executeTest):
- svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop.js: Added.
(SVGNumberListToString):
(executeTest):
- svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop.js: Added.
(executeTest):
- svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-svgdom-order-prop.js: Added.
(executeTest):
- svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop.js: Added.
(executeTest):
- svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-svgdom-targetX-prop.js: Added.
(executeTest):
- svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-svgdom-targetY-prop.js: Added.
(executeTest):
- 2:28 AM Changeset in webkit [71507] by
-
- 3 edits in trunk/WebCore
2010-11-08 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: follow up to inspector commit.
https://bugs.webkit.org/show_bug.cgi?id=49130
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.reset):
- inspector/front-end/inspector.css: (.event-bar):
- 2:12 AM Changeset in webkit [71506] by
-
- 6 edits in trunk/WebCore
2010-11-06 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: add more event listener breakpoint types, add support for regular breakpoint hit state, beautify hit rendering.
https://bugs.webkit.org/show_bug.cgi?id=49130
- English.lproj/localizedStrings.js:
- inspector/front-end/BreakpointManager.js: (WebInspector.BreakpointManager.prototype.debuggerPaused): (WebInspector.Breakpoint.jsBreakpointId): (WebInspector.Breakpoint.prototype.get id):
- inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.EventListenerBreakpointsSidebarPane): (WebInspector.EventListenerBreakpointsSidebarPane.prototype._createCategory):
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel):
- inspector/front-end/inspector.css: (#elements-sidebar): (.pane > .body): (#scripts-sidebar): (li.breakpoint-hit .breakpoint-hit-marker):
- 1:36 AM Changeset in webkit [71505] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, updating Chromium expectations.
Since r71493:r71496, http/tests/misc/prefetch-purpose.html start failing on Mac
- platform/chromium/test_expectations.txt:
- 1:12 AM Changeset in webkit [71504] by
-
- 2 edits in trunk/LayoutTests
[Qt] REGRESSION (r71465): editing/selection/after-line-break.html fails
https://bugs.webkit.org/show_bug.cgi?id=49127
- platform/qt/Skipped: editing/selection/after-line-break.html skipped until fix.
- 12:59 AM Changeset in webkit [71503] by
-
- 8 edits in trunk/WebCore
2010-11-08 Adam Barth <abarth@webkit.org>
Reviewed by Antti Koivisto.
Rename CachedResourceLoader::m_doc to CachedResourceLoader::m_document
https://bugs.webkit.org/show_bug.cgi?id=49163
The usual convention is to use "document", not "doc" to refer to the
document.
- css/CSSCursorImageValue.cpp: (WebCore::CSSCursorImageValue::cachedImage):
- dom/XMLDocumentParserLibxml2.cpp: (WebCore::shouldAllowExternalLoad):
- loader/cache/CachedResourceLoader.cpp: (WebCore::CachedResourceLoader::CachedResourceLoader): (WebCore::CachedResourceLoader::frame): (WebCore::CachedResourceLoader::requestImage): (WebCore::CachedResourceLoader::canRequest): (WebCore::CachedResourceLoader::requestResource): (WebCore::CachedResourceLoader::printAccessDeniedMessage): (WebCore::CachedResourceLoader::preload): (WebCore::CachedResourceLoader::checkForPendingPreloads): (WebCore::CachedResourceLoader::requestPreload):
- loader/cache/CachedResourceLoader.h: (WebCore::CachedResourceLoader::document):
- loader/cache/MemoryCache.cpp: (WebCore::MemoryCache::requestResource):
- loader/loader.cpp: (WebCore::Loader::load): (WebCore::Loader::Host::servePendingRequests): (WebCore::Loader::Host::didFinishLoading): (WebCore::Loader::Host::didFail):
- xml/XSLTProcessorLibxslt.cpp: (WebCore::docLoaderFunc):
- 12:42 AM Changeset in webkit [71502] by
-
- 3 edits in trunk/WebKitTools
2010-11-08 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Add clean-review-queue command to remove closed bugs from the webkit.org/pending-review
https://bugs.webkit.org/show_bug.cgi?id=49160
Bugzilla doesn't automatically remove r? when a bug gets closed.
This script takes care of that for webkit.org.
- Scripts/webkitpy/common/net/bugzilla.py:
- Scripts/webkitpy/tool/commands/upload.py:
Nov 7, 2010:
- 11:59 PM Changeset in webkit [71501] by
-
- 3 edits in trunk/WebCore
2010-11-07 Adam Barth <abarth@webkit.org>
Unreviewed. Remove some unneeded includes.
- loader/FrameLoader.cpp:
- loader/PlaceholderDocument.cpp:
- 10:54 PM Changeset in webkit [71500] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, updating Chromium expectations.
- platform/chromium/test_expectations.txt:
- 10:46 PM Changeset in webkit [71499] by
-
- 53 edits2 moves in trunk
2010-11-07 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Rename Cache to MemoryCache
https://bugs.webkit.org/show_bug.cgi?id=49159
- public/WebCache.h:
- src/WebCache.cpp: (WebKit::ToResourceTypeStat): (WebKit::WebCache::setCapacities): (WebKit::WebCache::clear): (WebKit::WebCache::getUsageStats): (WebKit::WebCache::getResourceTypeStats):
2010-11-07 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Rename Cache to MemoryCache
https://bugs.webkit.org/show_bug.cgi?id=49159
- Api/qwebpage.cpp:
- Api/qwebsettings.cpp:
2010-11-07 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Rename Cache to MemoryCache
https://bugs.webkit.org/show_bug.cgi?id=49159
- webkit/webkitwebview.cpp:
2010-11-07 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Rename Cache to MemoryCache
https://bugs.webkit.org/show_bug.cgi?id=49159
- WebCache.cpp: (WebCache::statistics):
- WebFrame.cpp:
- WebView.cpp:
2010-11-07 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Rename Cache to MemoryCache
https://bugs.webkit.org/show_bug.cgi?id=49159
- WebView.cpp: (wxWebView::SetCachePolicy):
- WebView.h:
2010-11-07 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Rename Cache to MemoryCache
https://bugs.webkit.org/show_bug.cgi?id=49159
- Misc/WebCache.mm: (+[WebCache statistics]):
- WebCoreSupport/WebDeviceOrientationClient.mm: (WebDeviceOrientationClient::setController):
- WebView/WebView.mm:
2010-11-07 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Rename Cache to MemoryCache
https://bugs.webkit.org/show_bug.cgi?id=49159
So sayeth the diagram.
- Android.mk:
- CMakeLists.txt:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- css/CSSImageValue.cpp:
- dom/ContainerNode.cpp:
- history/PageCache.cpp:
- inspector/InspectorCSSStore.h:
- inspector/InspectorResourceAgent.cpp:
- loader/FrameLoader.cpp:
- loader/archive/cf/LegacyWebArchive.cpp:
- loader/cache/Cache.cpp: Removed.
- loader/cache/Cache.h: Removed.
- loader/cache/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::allClientsRemoved):
- loader/cache/CachedFont.cpp:
- loader/cache/CachedFont.h:
- loader/cache/CachedImage.cpp: (WebCore::CachedImage::destroyDecodedData):
- loader/cache/CachedImage.h:
- loader/cache/CachedResource.cpp:
- loader/cache/CachedResource.h:
- loader/cache/CachedResourceLoader.cpp:
- loader/cache/CachedResourceLoader.h:
- loader/cache/CachedScript.cpp: (WebCore::CachedScript::destroyDecodedData):
- loader/cache/MemoryCache.cpp: Copied from WebCore/loader/cache/Cache.cpp. (WebCore::cache): (WebCore::MemoryCache::MemoryCache): (WebCore::MemoryCache::requestResource): (WebCore::MemoryCache::requestUserCSSStyleSheet): (WebCore::MemoryCache::revalidateResource): (WebCore::MemoryCache::revalidationSucceeded): (WebCore::MemoryCache::revalidationFailed): (WebCore::MemoryCache::resourceForURL): (WebCore::MemoryCache::deadCapacity): (WebCore::MemoryCache::liveCapacity): (WebCore::MemoryCache::pruneLiveResources): (WebCore::MemoryCache::pruneDeadResources): (WebCore::MemoryCache::setCapacities): (WebCore::MemoryCache::makeResourcePurgeable): (WebCore::MemoryCache::evict): (WebCore::MemoryCache::addCachedResourceLoader): (WebCore::MemoryCache::removeCachedResourceLoader): (WebCore::MemoryCache::lruListFor): (WebCore::MemoryCache::removeFromLRUList): (WebCore::MemoryCache::insertInLRUList): (WebCore::MemoryCache::resourceAccessed): (WebCore::MemoryCache::removeFromLiveDecodedResourcesList): (WebCore::MemoryCache::insertInLiveDecodedResourcesList): (WebCore::MemoryCache::addToLiveResourcesSize): (WebCore::MemoryCache::removeFromLiveResourcesSize): (WebCore::MemoryCache::adjustSize): (WebCore::MemoryCache::TypeStatistic::addResource): (WebCore::MemoryCache::getStatistics): (WebCore::MemoryCache::setDisabled): (WebCore::MemoryCache::dumpStats): (WebCore::MemoryCache::dumpLRULists):
- loader/cache/MemoryCache.h: Copied from WebCore/loader/cache/Cache.h. (WebCore::MemoryCache::shouldMakeResourcePurgeableOnEviction):
- loader/loader.cpp:
- page/EventSource.cpp:
- page/Settings.h:
- xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::createRequest):
2010-11-07 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Rename Cache to MemoryCache
https://bugs.webkit.org/show_bug.cgi?id=49159
- WebProcess/WebProcess.cpp:
- WebProcess/mac/WebProcessMac.mm:
- WebProcess/win/WebProcessWin.cpp:
- 9:57 PM Changeset in webkit [71498] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, updating Chromium expectations.
Add failures for crbug 62298, 62299, 62301
- platform/chromium/test_expectations.txt:
- 9:47 PM Changeset in webkit [71497] by
-
- 3 edits in trunk/WebCore
2010-11-07 Eric Seidel <eric@webkit.org>
Unreviewed. Attempt to fix the windows build.
Move the rest of the cache-related files into loader/cache
https://bugs.webkit.org/show_bug.cgi?id=49156
- WebCore.vcproj/WebCoreCommon.vsprops:
- WebCore.vcproj/copyForwardingHeaders.cmd:
- 9:30 PM Changeset in webkit [71496] by
-
- 9 edits20 moves in trunk
2010-11-07 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Move the rest of the cache-related files into loader/cache
https://bugs.webkit.org/show_bug.cgi?id=49156
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- loader/CachePolicy.h: Removed.
- loader/CachedCSSStyleSheet.cpp: Removed.
- loader/CachedCSSStyleSheet.h: Removed.
- loader/CachedFont.cpp: Removed.
- loader/CachedFont.h: Removed.
- loader/CachedImage.cpp: Removed.
- loader/CachedImage.h: Removed.
- loader/CachedResource.cpp: Removed.
- loader/CachedResource.h: Removed.
- loader/CachedResourceClient.h: Removed.
- loader/CachedResourceClientWalker.cpp: Removed.
- loader/CachedResourceClientWalker.h: Removed.
- loader/CachedResourceHandle.cpp: Removed.
- loader/CachedResourceHandle.h: Removed.
- loader/CachedResourceLoader.cpp: Removed.
- loader/CachedResourceLoader.h: Removed.
- loader/CachedScript.cpp: Removed.
- loader/CachedScript.h: Removed.
- loader/CachedXSLStyleSheet.cpp: Removed.
- loader/CachedXSLStyleSheet.h: Removed.
- loader/cache/CachePolicy.h: Copied from WebCore/loader/CachePolicy.h.
- loader/cache/CachedCSSStyleSheet.cpp: Copied from WebCore/loader/CachedCSSStyleSheet.cpp.
- loader/cache/CachedCSSStyleSheet.h: Copied from WebCore/loader/CachedCSSStyleSheet.h.
- loader/cache/CachedFont.cpp: Copied from WebCore/loader/CachedFont.cpp.
- loader/cache/CachedFont.h: Copied from WebCore/loader/CachedFont.h.
- loader/cache/CachedImage.cpp: Copied from WebCore/loader/CachedImage.cpp.
- loader/cache/CachedImage.h: Copied from WebCore/loader/CachedImage.h.
- loader/cache/CachedResource.cpp: Copied from WebCore/loader/CachedResource.cpp.
- loader/cache/CachedResource.h: Copied from WebCore/loader/CachedResource.h.
- loader/cache/CachedResourceClient.h: Copied from WebCore/loader/CachedResourceClient.h.
- loader/cache/CachedResourceClientWalker.cpp: Copied from WebCore/loader/CachedResourceClientWalker.cpp.
- loader/cache/CachedResourceClientWalker.h: Copied from WebCore/loader/CachedResourceClientWalker.h.
- loader/cache/CachedResourceHandle.cpp: Copied from WebCore/loader/CachedResourceHandle.cpp.
- loader/cache/CachedResourceHandle.h: Copied from WebCore/loader/CachedResourceHandle.h.
- loader/cache/CachedResourceLoader.cpp: Copied from WebCore/loader/CachedResourceLoader.cpp.
- loader/cache/CachedResourceLoader.h: Copied from WebCore/loader/CachedResourceLoader.h.
- loader/cache/CachedScript.cpp: Copied from WebCore/loader/CachedScript.cpp.
- loader/cache/CachedScript.h: Copied from WebCore/loader/CachedScript.h.
- loader/cache/CachedXSLStyleSheet.cpp: Copied from WebCore/loader/CachedXSLStyleSheet.cpp.
- loader/cache/CachedXSLStyleSheet.h: Copied from WebCore/loader/CachedXSLStyleSheet.h.
- 9:03 PM Changeset in webkit [71495] by
-
- 2 edits1 delete in trunk/LayoutTests
2010-11-07 MORITA Hajime <morrita@google.com>
Unreviewed test expectation rebaseline.
- platform/chromium-win/fast/dom/HTMLMeterElement/meter-element-expected.txt: Removed. (It's now same as platform/win)
- platform/chromium/test_expectations.txt:
- 8:44 PM Changeset in webkit [71494] by
-
- 5 edits in trunk
2010-11-07 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Rename X-Purpose to Purpose
https://bugs.webkit.org/show_bug.cgi?id=47802
As requested by IETF HTTP WG. This patch is part of a larger movement
in the HTTP community to move away from X- headers. Various senior
folks at the IETF believe they're a failed experiment:
http://tools.ietf.org/html/draft-saintandre-xdash-considered-harmful
- loader/loader.cpp: (WebCore::Loader::Host::servePendingRequests):
2010-11-07 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Rename X-Purpose to Purpose
https://bugs.webkit.org/show_bug.cgi?id=47802
Update expected results.
- http/tests/misc/prefetch-purpose-expected.txt:
- http/tests/misc/resources/prefetch-purpose.php:
- 8:32 PM Changeset in webkit [71493] by
-
- 2 edits in trunk/WebCore
2010-11-07 Daniel Bates <dbates@rim.com>
Reviewed by Adam Barth.
Assert that a non-null PassRefPtr<Document> has a non-null frame in Frame::setDocument()
https://bugs.webkit.org/show_bug.cgi?id=49152
Add an ASSERT to ensure that a non-null Document has a non-null Frame
in Frame::setDocument().
Currently, whenever Frame::setDocument() is called with a non-null
Document the Document has a non-null Frame. We should assert this
invariant.
- page/Frame.cpp: (WebCore::Frame::setDocument):
- 8:09 PM Changeset in webkit [71492] by
-
- 9 edits2 moves1 add in trunk/WebCore
2010-11-07 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Move Cache.* into loader/cache in as a start to cleaning up loader/
https://bugs.webkit.org/show_bug.cgi?id=49153
- Android.mk:
- CMakeLists.txt:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- loader/cache/Cache.cpp: Renamed from WebCore/loader/Cache.cpp. (WebCore::cache): (WebCore::Cache::Cache): (WebCore::createResource): (WebCore::Cache::requestResource): (WebCore::Cache::requestUserCSSStyleSheet): (WebCore::Cache::revalidateResource): (WebCore::Cache::revalidationSucceeded): (WebCore::Cache::revalidationFailed): (WebCore::Cache::resourceForURL): (WebCore::Cache::deadCapacity): (WebCore::Cache::liveCapacity): (WebCore::Cache::pruneLiveResources): (WebCore::Cache::pruneDeadResources): (WebCore::Cache::setCapacities): (WebCore::Cache::makeResourcePurgeable): (WebCore::Cache::evict): (WebCore::Cache::addCachedResourceLoader): (WebCore::Cache::removeCachedResourceLoader): (WebCore::fastLog2): (WebCore::Cache::lruListFor): (WebCore::Cache::removeFromLRUList): (WebCore::Cache::insertInLRUList): (WebCore::Cache::resourceAccessed): (WebCore::Cache::removeFromLiveDecodedResourcesList): (WebCore::Cache::insertInLiveDecodedResourcesList): (WebCore::Cache::addToLiveResourcesSize): (WebCore::Cache::removeFromLiveResourcesSize): (WebCore::Cache::adjustSize): (WebCore::Cache::TypeStatistic::addResource): (WebCore::Cache::getStatistics): (WebCore::Cache::setDisabled): (WebCore::Cache::dumpStats): (WebCore::Cache::dumpLRULists):
- loader/cache/Cache.h: Renamed from WebCore/loader/Cache.h. (WebCore::Cache::LRUList::LRUList): (WebCore::Cache::TypeStatistic::TypeStatistic): (WebCore::Cache::loader): (WebCore::Cache::disabled): (WebCore::Cache::setPruneEnabled): (WebCore::Cache::prune): (WebCore::Cache::setDeadDecodedDataDeletionInterval): (WebCore::Cache::deadDecodedDataDeletionInterval): (WebCore::Cache::remove): (WebCore::Cache::shouldMakeResourcePurgeableOnEviction):
- 7:54 PM Changeset in webkit [71491] by
-
- 9 edits in trunk/WebKitTools
2010-11-07 Fumitoshi Ukai <ukai@chromium.org>
Unreviewed, rolling out r71474.
http://trac.webkit.org/changeset/71474
https://bugs.webkit.org/show_bug.cgi?id=48280
breaks chromium webkit tests
https://bugs.webkit.org/show_bug.cgi?id=49151
- Scripts/webkitpy/layout_tests/port/base.py:
- Scripts/webkitpy/layout_tests/port/base_unittest.py:
- Scripts/webkitpy/layout_tests/port/config.py:
- Scripts/webkitpy/layout_tests/port/config_unittest.py:
- Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
- Scripts/webkitpy/layout_tests/port/webkit.py:
- Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
- Scripts/webkitpy/tool/mocktool.py:
- 7:52 PM Changeset in webkit [71490] by
-
- 1 edit5 deletes in trunk/WebKitTools
2010-11-07 Fumitoshi Ukai <ukai@chromium.org>
Unreviewed, rolling out r71475.
http://trac.webkit.org/changeset/71475
breaks chromium webkit tests
https://bugs.webkit.org/show_bug.cgi?id=49151
- Scripts/webkitpy/common/newstringio.py: Removed.
- Scripts/webkitpy/common/newstringio_unittest.py: Removed.
- Scripts/webkitpy/common/system/executive_mock.py: Removed.
- Scripts/webkitpy/common/system/filesystem_mock.py: Removed.
- Scripts/webkitpy/layout_tests/port/config_mock.py: Removed.
- 7:08 PM Changeset in webkit [71489] by
-
- 2 edits in trunk/JavaScriptCore
2010-11-07 Sam Magnuson <smagnuson@netflix.com>
Reviewed by Andreas Kling.
[Qt] make install does not cause JavaScriptCore to be built
https://bugs.webkit.org/show_bug.cgi?id=49114
- JavaScriptCore.pro:
- 6:54 PM Changeset in webkit [71488] by
-
- 5 edits in trunk
2010-11-05 Helder Correia <helder@sencha.com>
Reviewed by Andreas Kling.
[Qt] box-shadow does not blur (is solid) when using border-radius
https://bugs.webkit.org/show_bug.cgi?id=46327
Implement blurred box-shadow when styling with border-radius.
This change is related to https://bugs.webkit.org/show_bug.cgi?id=44488
- platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::fillRoundedRect):
2010-11-05 Helder Correia <helder@sencha.com>
Reviewed by Andreas Kling.
[Qt] box-shadow does not blur (is solid) when using border-radius
https://bugs.webkit.org/show_bug.cgi?id=46327
Implement blurred box-shadow when styling with border-radius.
This change is related to https://bugs.webkit.org/show_bug.cgi?id=44488
- platform/qt/fast/box-shadow/basic-shadows-expected.checksum:
- platform/qt/fast/box-shadow/basic-shadows-expected.png:
- 6:31 PM Changeset in webkit [71487] by
-
- 3 edits12 adds in trunk/LayoutTests
2010-11-07 Matthew Delaney <mdelaney@apple.com>
Reviewed by Andreas Kling.
Unskipping recently merged new philip canvas tests from SnowLeopard
https://bugs.webkit.org/show_bug.cgi?id=49147
- platform/mac-leopard/Skipped: Moving skipped test list down to leopard.
- platform/mac-snowleopard/canvas/philip/tests/*: All new tests' expectations.
- platform/mac/Skipped: Unskipping tests from overall mac.
- 5:49 PM Changeset in webkit [71486] by
-
- 3 edits in trunk/LayoutTests
2010-11-07 Helder Correia <helder@sencha.com>
Reviewed by Ariya Hidayat.
[Qt] Update the baseline for blur shadow test
https://bugs.webkit.org/show_bug.cgi?id=48223
Update basic-shadows test expected result with correct line segments.
- platform/qt/fast/box-shadow/basic-shadows-expected.checksum:
- platform/qt/fast/box-shadow/basic-shadows-expected.png:
- 5:14 PM Changeset in webkit [71485] by
-
- 3 edits in trunk/LayoutTests
2010-11-07 Andreas Kling <kling@webkit.org>
Unreviewed, skipping new canvas tests that are failing on Gtk+ and Qt.
Skip the following tests:
- canvas/philip/tests/security.pattern.canvas.timing.html
- canvas/philip/tests/security.pattern.create.html
- canvas/philip/tests/security.pattern.cross.html
- canvas/philip/tests/security.pattern.image.fillStyle.html
- canvas/philip/tests/security.pattern.image.strokeStyle.html
- platform/gtk/Skipped:
- platform/qt/Skipped:
- 3:38 PM Changeset in webkit [71484] by
-
- 4 edits1 add in trunk/WebCore
2010-11-07 John Reck <jreck@google.com>
Reviewed by Steve Block.
Implements navigator.language for Android
https://bugs.webkit.org/show_bug.cgi?id=49099
Android was previously hardcoding the value for WebCore::platformDefaultLanguage().
This patch removes the hardcoding and calls into the PlatformBridge to get the
correct language based off of the user's settings.
No new tests needed, this is already covered
- Android.mk:
- platform/android/LanguageAndroid.cpp: Added. (WebCore::platformDefaultLanguage):
- platform/android/PlatformBridge.h:
- platform/android/TemporaryLinkStubs.cpp:
- 7:25 AM Changeset in webkit [71483] by
-
- 3 edits2 adds in trunk
2010-11-07 Robert Hogan <robert@webkit.org>
Reviewed by Andreas Kling.
[qt] screenDepthPerComponent returns the wrong value
Return best estimate of the number of bits per color
rather than screen depth.
Add a layout test to sanity check screenDepthPerComponent.
- fast/css/media-rule-screenDepthPerComponent-expected.txt: Added.
- fast/css/media-rule-screenDepthPerComponent.html: Added.
2010-11-07 Robert Hogan <robert@webkit.org>
Reviewed by Andreas Kling.
[qt] screenDepthPerComponent returns the wrong value
Return best estimate of the number of bits per color
rather than screen depth.
Add a layout test to sanity check screenDepthPerComponent.
Test: fast/css/media-rule-screenDepthPerComponent.html
- platform/qt/PlatformScreenQt.cpp: (WebCore::screenDepthPerComponent):
- 7:02 AM Changeset in webkit [71482] by
-
- 52 edits in trunk/LayoutTests
2010-11-07 Andreas Kling <kling@webkit.org>
Unreviewed, rebaselining failures on Leopard and Snow Leopard after r71481.
- canvas/philip/tests/2d.imageData.get.source.negative-expected.txt:
- canvas/philip/tests/security.pattern.canvas.timing-expected.txt:
- canvas/philip/tests/security.pattern.create-expected.txt:
- canvas/philip/tests/security.pattern.cross-expected.txt:
- canvas/philip/tests/security.pattern.image.fillStyle-expected.txt:
- canvas/philip/tests/security.pattern.image.strokeStyle-expected.txt:
- platform/mac-snowleopard/canvas/philip/tests/2d.drawImage.broken-expected.txt:
- platform/mac-snowleopard/canvas/philip/tests/2d.drawImage.null-expected.txt:
- platform/mac-snowleopard/canvas/philip/tests/2d.fillStyle.parse.system-expected.txt:
- platform/mac-snowleopard/canvas/philip/tests/2d.gradient.radial.cone.front-expected.txt:
- platform/mac-snowleopard/canvas/philip/tests/2d.gradient.radial.cone.top-expected.txt:
- platform/mac-snowleopard/canvas/philip/tests/2d.gradient.radial.inside2-expected.txt:
- platform/mac-snowleopard/canvas/philip/tests/2d.gradient.radial.inside3-expected.txt:
- platform/mac-snowleopard/canvas/philip/tests/2d.gradient.radial.outside1-expected.txt:
- platform/mac-snowleopard/canvas/philip/tests/2d.imageData.create1.type-expected.txt:
- platform/mac-snowleopard/canvas/philip/tests/2d.imageData.create2.type-expected.txt:
- platform/mac-snowleopard/canvas/philip/tests/2d.imageData.get.type-expected.txt:
- platform/mac-snowleopard/canvas/philip/tests/2d.line.cap.closed-expected.txt:
- platform/mac-snowleopard/canvas/philip/tests/2d.line.join.parallel-expected.txt:
- platform/mac-snowleopard/canvas/philip/tests/2d.line.miter.lineedge-expected.txt:
- platform/mac-snowleopard/canvas/philip/tests/2d.missingargs-expected.txt:
- platform/mac-snowleopard/canvas/philip/tests/2d.path.rect.winding-expected.txt:
- platform/mac-snowleopard/canvas/philip/tests/2d.pattern.image.broken-expected.txt:
- platform/mac-snowleopard/canvas/philip/tests/2d.pattern.image.incomplete-expected.txt:
- platform/mac-snowleopard/canvas/philip/tests/2d.shadow.enable.blur-expected.txt:
- platform/mac-snowleopard/canvas/philip/tests/2d.shadow.enable.x-expected.txt:
- platform/mac-snowleopard/canvas/philip/tests/2d.shadow.enable.y-expected.txt:
- platform/mac-snowleopard/canvas/philip/tests/2d.shadow.gradient.alpha-expected.txt:
- platform/mac-snowleopard/canvas/philip/tests/2d.shadow.gradient.basic-expected.txt:
- platform/mac-snowleopard/canvas/philip/tests/2d.shadow.gradient.transparent.2-expected.txt:
- platform/mac-snowleopard/canvas/philip/tests/2d.strokeRect.zero.4-expected.txt:
- platform/mac-snowleopard/canvas/philip/tests/2d.text.draw.baseline.bottom-expected.txt:
- platform/mac-snowleopard/canvas/philip/tests/2d.text.draw.baseline.hanging-expected.txt:
- platform/mac-snowleopard/canvas/philip/tests/2d.text.draw.baseline.ideographic-expected.txt:
- platform/mac-snowleopard/canvas/philip/tests/2d.text.draw.baseline.middle-expected.txt:
- platform/mac-snowleopard/canvas/philip/tests/2d.text.draw.baseline.top-expected.txt:
- platform/mac-snowleopard/canvas/philip/tests/2d.text.draw.fill.maxWidth.fontface-expected.txt:
- platform/mac-snowleopard/canvas/philip/tests/2d.text.draw.space.collapse.end-expected.txt:
- platform/mac-snowleopard/canvas/philip/tests/2d.text.draw.space.collapse.nonspace-expected.txt:
- platform/mac-snowleopard/canvas/philip/tests/2d.text.draw.space.collapse.other-expected.txt:
- platform/mac-snowleopard/canvas/philip/tests/2d.text.draw.space.collapse.space-expected.txt:
- platform/mac-snowleopard/canvas/philip/tests/2d.text.draw.space.collapse.start-expected.txt:
- platform/mac-snowleopard/canvas/philip/tests/2d.text.font.parse.basic-expected.txt:
- platform/mac-snowleopard/canvas/philip/tests/2d.text.font.parse.complex-expected.txt:
- platform/mac-snowleopard/canvas/philip/tests/2d.text.font.parse.invalid-expected.txt:
- platform/mac-snowleopard/canvas/philip/tests/2d.text.font.parse.size.percentage-expected.txt:
- platform/mac-snowleopard/canvas/philip/tests/2d.text.font.parse.size.percentage.default-expected.txt:
- platform/mac-snowleopard/canvas/philip/tests/2d.text.font.parse.system-expected.txt:
- platform/mac-snowleopard/canvas/philip/tests/2d.text.measure.width.space-expected.txt:
- platform/mac-snowleopard/canvas/philip/tests/toDataURL.jpeg.alpha-expected.txt:
- platform/mac-snowleopard/canvas/philip/tests/type.prototype-expected.txt:
- 5:49 AM Changeset in webkit [71481] by
-
- 1568 edits53 adds in trunk/LayoutTests
2010-10-18 Andreas Kling <kling@webkit.org>
Reviewed by James Robinson.
Update our clone of Philip Taylor's canvas test suite
https://bugs.webkit.org/show_bug.cgi?id=47707
Source: http://dvcs.w3.org/hg/html/file/df23d00a3395/tests/submission/PhilipTaylor
- canvas/philip/README: Added, contains link to upstream revision.
- canvas/philip/: Synced with upstream.
- platform/gtk/Skipped: Skipped new failing tests.
- platform/mac/Skipped: Ditto.
- platform/qt/Skipped: Ditto.
- 1:42 AM Changeset in webkit [71480] by
-
- 2 edits in trunk/WebKit/chromium
2010-11-07 Jay Civelli <jcivelli@chromium.org>
Reviewed by Kent Tamura.
Fixing a crasher with the select popup on Mac that happens when a
page removes the select node when the select changes.
https://bugs.webkit.org/show_bug.cgi?id=49108
- src/ExternalPopupMenu.cpp: (WebKit::ExternalPopupMenu::didAcceptIndex): (WebKit::ExternalPopupMenu::didCancel):
- 1:24 AM Changeset in webkit [71479] by
-
- 9 edits in trunk
2010-11-07 Chang Shu <chang.shu@nokia.com>
Reviewed by Antonio Gomes.
Add a helper function to avoid duplicated code.
https://bugs.webkit.org/show_bug.cgi?id=49085
- dom/SelectElement.cpp:
- editing/SelectionController.cpp: (WebCore::SelectionController::modify):
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::isKeyboardFocusable):
- page/EventHandler.cpp: (WebCore::EventHandler::defaultArrowEventHandler):
- page/SpatialNavigation.cpp: (WebCore::isSpatialNavigationEnabled):
- page/SpatialNavigation.h:
2010-11-07 Chang Shu <chang.shu@nokia.com>
Reviewed by Antonio Gomes.
Add a helper function to avoid duplicated code.
https://bugs.webkit.org/show_bug.cgi?id=49085
- WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::handleKeyboardEvent):
Nov 6, 2010:
- 11:43 PM Changeset in webkit [71478] by
-
- 2 edits in trunk/WebKit/chromium
2010-11-06 Pavel Feldman <pfeldman@chromium.org>
Not reviewed. Chromium DevTools: disable filesystem inspection
until polished.
https://bugs.webkit.org/show_bug.cgi?id=48963
- src/js/DevTools.js:
- 11:26 PM Changeset in webkit [71477] by
-
- 2 edits in trunk/WebCore
2010-11-06 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Simon Fraser.
Web Inspector: Some image resources don't display the image when selected in the Resources panel.
https://bugs.webkit.org/show_bug.cgi?id=48935
Marked resources loaded from memory cache as finished.
- inspector/front-end/ResourceManager.js: (WebInspector.ResourceManager.prototype.didLoadResourceFromMemoryCache):
- 11:23 PM Changeset in webkit [71476] by
-
- 2 edits in trunk/WebCore
2010-11-06 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: XHR logging is not checked in context menu after browser restart.
https://bugs.webkit.org/show_bug.cgi?id=49133
- inspector/InspectorState.cpp: (WebCore::InspectorState::InspectorState):
- 9:21 PM Changeset in webkit [71475] by
-
- 1 edit5 adds in trunk/WebKitTools
2010-11-06 Dirk Pranke <dpranke@chromium.org>
Unreviewed, build fix.
Add files inexplicably not committed in r71474 as part of the
fix for bug 48280.
- Scripts/webkitpy/common/newstringio.py: Added.
- Scripts/webkitpy/common/newstringio_unittest.py: Added.
- Scripts/webkitpy/common/system/executive_mock.py: Added.
- Scripts/webkitpy/common/system/filesystem_mock.py: Added.
- Scripts/webkitpy/layout_tests/port/config_mock.py: Added.
- 8:38 PM Changeset in webkit [71474] by
-
- 9 edits in trunk/WebKitTools
2010-11-06 Dirk Pranke <dpranke@chromium.org>
Reviewed by Eric Siedel.
new-run-webkit-tests: update port/base and port/webkit to use the
new FileSystem and Config abstractions, pulling more logic out of
the base Port classes into separate, mockable objects.
Also create a MockFileSystem object, a MockConfig object, move
MockExecutive into common/system to be next to executive, and
update the config object to use a FileSystem.
- Scripts/webkitpy/common/newstringio.py: Added.
- Scripts/webkitpy/common/newstringio_unittest.py: Added.
- Scripts/webkitpy/common/system/executive_mock.py: Added.
- Scripts/webkitpy/common/system/filesystem_mock.py: Added.
- Scripts/webkitpy/layout_tests/port/base.py:
- Scripts/webkitpy/layout_tests/port/base_unittest.py:
- Scripts/webkitpy/layout_tests/port/config.py:
- Scripts/webkitpy/layout_tests/port/config_mock.py:
- Scripts/webkitpy/layout_tests/port/config_unittest.py:
- Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
- Scripts/webkitpy/layout_tests/port/webkit.py:
- Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
- Scripts/webkitpy/tool/mocktool.py:
- 7:44 PM Changeset in webkit [71473] by
-
- 2 edits in trunk/WebKitTools
2010-11-06 Dirk Pranke <dpranke@chromium.org>
Unreviewed, build breakage.
Apparently I uploaded the wrong version of the file to fix 49122
and neither Eric or I noticed - it was missing a dirname() call.
Fixing ...
- Scripts/webkitpy/common/checkout/scm.py:
- 7:31 PM Changeset in webkit [71472] by
-
- 2 edits in trunk/WebKitTools
2010-11-06 Dirk Pranke <dpranke@chromium.org>
Reviewed by Eric Seidel.
webkitpy/tool/* unittests change cwd and don't clean up properly
- Scripts/webkitpy/common/checkout/scm.py:
- 6:23 PM Changeset in webkit [71471] by
-
- 2 edits in trunk/WebKit2
2010-11-06 Balazs Kelemen <kbalazs@webkit.org>
Reviewed by Andreas Kling.
[Qt][WK2] WebKitTestRunner is dead
https://bugs.webkit.org/show_bug.cgi?id=49129
- Platform/qt/SharedMemoryQt.cpp: (WebKit::SharedMemory::~SharedMemory): Avoid double deletion when deleteLater has already been called.
- 3:56 PM Changeset in webkit [71470] by
-
- 2 edits in trunk/WebCore
2010-11-06 Ryosuke Niwa <rniwa@webkit.org>
Unreviewed Windows build fix.
- editing/EditingAllInOne.cpp: Added EditingStyle.cpp
- 2:19 PM Changeset in webkit [71469] by
-
- 17 edits2 adds in trunk/WebCore
2010-11-04 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
Bug 46335 - Add EditingStyle
https://bugs.webkit.org/show_bug.cgi?id=46335
Added EditingStyle to WebCore/editing. This class is intended to encapsulate getPropertiesNotIn, removeNonEditingProperties,
editingStyleAtPosition, and prepareEditingStyleToApplyAt in ApplyStyleCommand.cpp once deployed everywhere.
Deployed it in typing styles.
No new tests are added since this is a refactoring in progress.
- CMakeLists.txt: Added EditingStyle.cpp
- GNUmakefile.am: Added EditingStyle.cpp and EditingStyle.h
- WebCore.gypi: Ditto.
- WebCore.pro: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::moveParagraphs): Calls editingStyleIncludingTypingStyle. (WebCore::CompositeEditCommand::breakOutOfEmptyListItem): Uses EditingStyle.
- editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::saveTypingStyleState): Ditto. (WebCore::DeleteSelectionCommand::calculateTypingStyleAfterDelete): Ditto.
- editing/DeleteSelectionCommand.h:
- editing/EditingStyle.cpp: Added. (WebCore::editingStyleFromComputedStyle): Added. (WebCore::EditingStyle::EditingStyle): Added. (WebCore::EditingStyle::init): Added; a clone of ApplyStyleCommand::editingStyleAtPosition. (WebCore::EditingStyle::removeTextFillAndStrokeColorsIfNeeded): Extracted from init. (WebCore::EditingStyle::replaceFontSizeByKeywordIfPossible): Extracted from init. (WebCore::EditingStyle::isEmpty): Added. (WebCore::EditingStyle::setStyle): Added. (WebCore::EditingStyle::clear): Added. (WebCore::EditingStyle::removeBlockProperties): Added. (WebCore::EditingStyle::prepareToApplyAt): Added. (WebCore::editingStyleIncludingTypingStyle): Added.
- editing/EditingStyle.h: Added. (WebCore::EditingStyle::create): Added. (WebCore::EditingStyle::style): Added.
- editing/RemoveFormatCommand.cpp: (WebCore::RemoveFormatCommand::doApply): Uses EditingStyle.
- editing/SelectionController.h: (WebCore::SelectionController::typingStyle): Uses EditingStyle. (WebCore::SelectionController::clearTypingStyle): Uses EditingStyle. (WebCore::SelectionController::setTypingStyle): Uses EditingStyle.
- rendering/style/RenderStyle.h: Added EditingStyle as a friend.
- 1:33 AM Changeset in webkit [71468] by
-
- 7 edits in trunk/LayoutTests
Unreviewed. Update Qt specific expected files after r71467.
- platform/qt/fast/blockflow/background-horizontal-bt-expected.checksum:
- platform/qt/fast/blockflow/background-horizontal-bt-expected.png:
- platform/qt/fast/blockflow/background-horizontal-bt-expected.txt:
- platform/qt/fast/blockflow/background-vertical-lr-expected.checksum:
- platform/qt/fast/blockflow/background-vertical-lr-expected.png:
- platform/qt/fast/blockflow/background-vertical-lr-expected.txt:
