Timeline


and

11/14/10:

23:46 Changeset [71999] by tkent@chromium.org

2010-11-14 Kent Tamura <tkent@chromium.org>

Unreviewed, test expectation update.

  • platform/gtk/Skipped: Skip fast/forms/form-attribute.html, which needs <meter> support.
22:38 Changeset [71998] by mihaip@chromium.org

2010-11-14 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium expectations update.

Add tests that fail under the DRT.

  • platform/chromium/drt_expectations.txt:
22:03 Changeset [71997] by hyatt@apple.com

Back out the italics portion of the previous patch until I can figure out why it
doesn't work.

  • css/CSSFontSelector.cpp:

(WebCore::compareFontFaces):

21:40 Changeset [71996] by tkent@chromium.org

2010-11-14 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

Improve API for form validation message strings
https://bugs.webkit.org/show_bug.cgi?id=34945

This change introduces three new functions;
validationMessageTypeMismatchFor*Text(). The implementation for each
platform is just a call to validationMessageTypeMismatchText().

Some validationMessage*() functions have new parameters. The parameters
are ignored in all platforms for now.

This change doesn't change any behavior. However a platform can add
additional information to validation messages. e.g. Changing "type
mismatch" to "Please specify an e-mail address" for <input type=email>.

  • html/EmailInputType.cpp: (WebCore::EmailInputType::typeMismatchText): Call validationMessageTypeMismatchForEmailText() or validationMessageTypeMismatchForMultipleEmailText().
  • html/EmailInputType.h:
  • html/HTMLFormControlElement.h: Add maxLength() and value() to access them from ValidityState.
  • html/HTMLInputElement.cpp: Add the following functions to pass extra information to validation message string functions. (WebCore::HTMLInputElement::minimumString): (WebCore::HTMLInputElement::maximumString): (WebCore::HTMLInputElement::stepBaseString): (WebCore::HTMLInputElement::stepString): (WebCore::HTMLInputElement::typeMismatchText):
  • html/HTMLInputElement.h:
  • html/HTMLTextAreaElement.h:
  • html/InputType.cpp: (WebCore::InputType::typeMismatchText): Call validationMessageTypeMismatchText().
  • html/InputType.h:
  • html/URLInputType.cpp: (WebCore::URLInputType::typeMismatchText): Call validationMessageTypeMismatchForURLText().
  • html/URLInputType.h:
  • html/ValidityState.cpp: (WebCore::ValidityState::validationMessage):
  • platform/LocalizedStrings.cpp: (WebCore::validationMessageTypeMismatchForEmailText): (WebCore::validationMessageTypeMismatchForMultipleEmailText): (WebCore::validationMessageTypeMismatchForURLText): (WebCore::validationMessageTooLongText): (WebCore::validationMessageRangeUnderflowText): (WebCore::validationMessageRangeOverflowText): (WebCore::validationMessageStepMismatchText):
  • platform/LocalizedStrings.h:
    • Add validationMessageTypeMismatchForEmailText(), validationMessageTypeMismatchForMultipleEmailText() and validationMessageTypeMismatchForURLText()
    • Add length parameters to validationMessageTooLongText().
    • Add the minimum value parameter to validationMessageRangeUnderflowText()
    • Add the maximum value parameter to validationMessageRangeOverflowText()
    • Add parameters of the base value and the step value to validationMessageStepMismatchText()
  • platform/android/LocalizedStringsAndroid.cpp: (WebCore::validationMessageTypeMismatchForEmailText): (WebCore::validationMessageTypeMismatchForMultipleEmailText): (WebCore::validationMessageTypeMismatchForURLText): (WebCore::validationMessageTooLongText): (WebCore::validationMessageRangeUnderflowText): (WebCore::validationMessageRangeOverflowText): (WebCore::validationMessageStepMismatchText):
  • platform/brew/LocalizedStringsBrew.cpp: (WebCore::validationMessageTypeMismatchForEmailText): (WebCore::validationMessageTypeMismatchForMultipleEmailText): (WebCore::validationMessageTypeMismatchForURLText): (WebCore::validationMessageTooLongText): (WebCore::validationMessageRangeUnderflowText): (WebCore::validationMessageRangeOverflowText): (WebCore::validationMessageStepMismatchText):
  • platform/efl/LocalizedStringsEfl.cpp: (WebCore::validationMessageRangeOverflowText): (WebCore::validationMessageRangeUnderflowText): (WebCore::validationMessageStepMismatchText): (WebCore::validationMessageTooLongText): (WebCore::validationMessageTypeMismatchForEmailText): (WebCore::validationMessageTypeMismatchForMultipleEmailText): (WebCore::validationMessageTypeMismatchForURLText):
  • platform/gtk/LocalizedStringsGtk.cpp: (WebCore::validationMessageTypeMismatchForEmailText): (WebCore::validationMessageTypeMismatchForMultipleEmailText): (WebCore::validationMessageTypeMismatchForURLText): (WebCore::validationMessageTooLongText): (WebCore::validationMessageRangeUnderflowText): (WebCore::validationMessageRangeOverflowText): (WebCore::validationMessageStepMismatchText):
  • platform/haiku/LocalizedStringsHaiku.cpp: (WebCore::validationMessageTypeMismatchForEmailText): (WebCore::validationMessageTypeMismatchForMultipleEmailText): (WebCore::validationMessageTypeMismatchForURLText): (WebCore::validationMessageTooLongText): (WebCore::validationMessageRangeUnderflowText): (WebCore::validationMessageRangeOverflowText): (WebCore::validationMessageStepMismatchText):
  • platform/wx/LocalizedStringsWx.cpp: (WebCore::validationMessageTypeMismatchForEmailText): (WebCore::validationMessageTypeMismatchForMultipleEmailText): (WebCore::validationMessageTypeMismatchForURLText): (WebCore::validationMessageTooLongText): (WebCore::validationMessageRangeUnderflowText): (WebCore::validationMessageRangeOverflowText): (WebCore::validationMessageStepMismatchText):

2010-11-14 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

Improve API for form validation message strings
https://bugs.webkit.org/show_bug.cgi?id=34945

  • public/WebLocalizedString.h:
  • src/LocalizedStrings.cpp: (WebCore::validationMessageTypeMismatchForEmailText): (WebCore::validationMessageTypeMismatchForMultipleEmailText): (WebCore::validationMessageTypeMismatchForURLText): (WebCore::validationMessageTooLongText): (WebCore::validationMessageRangeUnderflowText): (WebCore::validationMessageRangeOverflowText): (WebCore::validationMessageStepMismatchText):
21:19 Changeset [71995] by tkent@chromium.org

KeyboardEvent::keyIdentifier() should return "const String&"
https://bugs.webkit.org/show_bug.cgi?id=49426

Reviewed by Andreas Kling.

WebCore:

No new tests. This shouldn't change the current behavior.

  • dom/KeyboardEvent.h:

(WebCore::KeyboardEvent::keyIdentifier): Change the return type; String -> const String&

  • dom/SelectElement.cpp:

(WebCore::SelectElement::menuListDefaultEventHandler):

Change the type of a variable to have keyIdentifier(); String -> const String&

(WebCore::SelectElement::listBoxDefaultEventHandler): ditto.

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::defaultEventHandler): ditto.
(WebCore::HTMLInputElement::handleKeyEventForRange): ditto.

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleKeyboardSelectionMovement): ditto.

WebKit/mac:

  • WebCoreSupport/WebEditorClient.mm:

(selectorForKeyEvent):

Change the type of a variable to have keyIdentifier(); String -> const String&

20:57 Changeset [71994] by commit-queue@webkit.org

2010-11-14 Kenichi Ishibashi <bashi@google.com>

Reviewed by Kent Tamura.

[HTML5] "form" attribute support for form control elements
https://bugs.webkit.org/show_bug.cgi?id=47813

Adds a test file for "form" attribute of form-associated elements.
The test might need to be revised because <label> and <object> don't
support "form" attribute for now, in spite of the HTML5 spec says that
they should support.

  • fast/forms/form-attribute-elements-expected.txt: Added.
  • fast/forms/form-attribute-elements-order-expected.txt: Added.
  • fast/forms/form-attribute-elements-order.html: Added.
  • fast/forms/form-attribute-elements-order2-expected.txt: Added.
  • fast/forms/form-attribute-elements-order2.html: Added.
  • fast/forms/form-attribute-elements.html: Added.
  • fast/forms/form-attribute-expected.txt: Added.
  • fast/forms/form-attribute.html: Added.
  • fast/forms/script-tests/form-attribute-elements-order.js: Added.
  • fast/forms/script-tests/form-attribute-elements-order2.js: Added.
  • fast/forms/script-tests/form-attribute-elements.js: Added.
  • fast/forms/script-tests/form-attribute.js: Added.

2010-11-14 Kenichi Ishibashi <bashi@google.com>

Reviewed by Kent Tamura.

[HTML5] "form" attribute support for form control elements
https://bugs.webkit.org/show_bug.cgi?id=47813

Adds a list of form-associated elements with form attribute into
the Document class to support form attribute.
Adds a function to determine the right place to locate
form-associated elements with form attribute into
m_associatedElements of HTMLFormElement class.

Tests: fast/forms/form-attribute-elements-order.html

fast/forms/form-attribute-elements-order2.html
fast/forms/form-attribute-elements.html
fast/forms/form-attribute.html

  • dom/Document.cpp: (WebCore::Document::registerFormElementWithFormAttribute): Added. (WebCore::Document::unregisterFormElementWithFormAttribute): Added. (WebCore::Document::resetFormElementsOwner): Added.
  • dom/Document.h: Added the list for elements with form attribute.
  • html/HTMLAttributeNames.in: Added form attribute.
  • html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::insertedIntoTree): Modified to handle form attribute. (WebCore::HTMLFormControlElement::removedFromTree): Ditto. (WebCore::HTMLFormControlElement::resetFormOwner): Added. (WebCore::HTMLFormControlElement::attributeChanged): Added.
  • html/HTMLFormControlElement.h:
  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::HTMLFormElement): Modified to initialize newly-added variables. (WebCore::HTMLFormElement::insertedIntoDocument): Modified to reset form owner of form-associated elements. (WebCore::HTMLFormElement::removedFromDocument): Ditto. (WebCore::HTMLFormElement::formElementIndexWithFormAttribute): Added. (WebCore::HTMLFormElement::formElementIndex): Modified to treat form-associated elements with form attribute separately. (WebCore::HTMLFormElement::removeFormElement): Modified to handle form-associated elements with form attribute.
  • html/HTMLFormElement.h: Added three variables to handle form attribute.
  • html/HTMLOutputElement.cpp: Removed "FIXME" comment. (WebCore::HTMLOutputElement::parseMappedAttribute):
  • html/HTMLOutputElement.h: Removed setForm().
20:53 Changeset [71993] by hyatt@apple.com

https://bugs.webkit.org/show_bug.cgi?id=49521

Reviewed by Dan Bernstein.

REGRESSION svg/W3C-SVG-1.1/fonts-desc-02-t.svg broken by r71979.

Refine the font selection function for @font-face to be smarter about what fonts it prefers. If
a font is labeled as only supporting small-caps, then prefer it to one that claims to support both
normal and small-caps. The specialized font is more likely to be true small-caps and to not rely
on synthesis.

Added the same logic for italic as well. Prefer the font that is specifically restricted to
italic to one that claims it can support anything.

  • css/CSSFontSelector.cpp:

(WebCore::compareFontFaces):

19:38 Changeset [71992] by mihaip@chromium.org

2010-11-14 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium expectations update.

Remove two tests that consistently pass on chromium-mac.

  • platform/chromium/test_expectations.txt:
18:14 Changeset [71991] by mihaip@chromium.org

2010-11-14 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium rebaseline and expectations update.

  • platform/chromium-mac/fast/blockflow/vertical-font-fallback-expected.checksum: Added.
  • platform/chromium-mac/fast/blockflow/vertical-font-fallback-expected.png: Added.
  • platform/chromium/test_expectations.txt:
17:56 Changeset [71990] by mihaip@chromium.org

2010-11-14 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium expectations update.

Correct some expectations added by r71988.

  • platform/chromium/test_expectations.txt:
17:17 Changeset [71989] by levin@chromium.org

2010-11-14 David Levin <levin@chromium.org>

Reviewed by Daniel Bates.

check-webkit-style should detect PassRefPtr usage in functions.
https://bugs.webkit.org/show_bug.cgi?id=49513

  • Scripts/webkitpy/style/checkers/cpp.py: (check_for_function_lengths): Revert a comment change that I accidentally made in r71986. (check_pass_ptr_usage): Added the code to do the check. (process_line): Added the call to check_pass_ptr_usage. (CppChecker): Added the new error category.
  • Scripts/webkitpy/style/checkers/cpp_unittest.py: (CppStyleTestBase::perform_pass_ptr_check): Runs the new check for testing purposes. (PassPtrTest::*): The class/functions to unit test the new functionality.
17:15 Changeset [71988] by mihaip@chromium.org

2010-11-14 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium baseline and expectations update.

  • r71969 added a bunch of SVG tests without pixel baselines
  • r71969 also caused svg/W3C-SVG-1.1-SE/types-dom-06-f.svg to need a rebaseline for Linux and Windows (which now match the mac baseline, modulo font rendering)
  • r71970 added two tests that depend on vertical text support (which (doesn't work on Linux or Windows yet)
  • Similarly, r71979 added a test that depends on vertical text support
  • r71979 also caused a regression that should be fixed upstream
  • Add Chromium baselines for fast/repaint/ repaint-across-writing-mode-boundary.html (added by r71980).

Also rebaseline fast/table/colspanMinWidth-vertical.html for Linux and
Windows, to mirror the mac rebaseline done in r71876.

  • platform/chromium-linux/fast/repaint/repaint-across-writing-mode-boundary-expected.checksum: Added.
  • platform/chromium-linux/fast/repaint/repaint-across-writing-mode-boundary-expected.png: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt: Removed.
  • platform/chromium-mac/fast/repaint/repaint-across-writing-mode-boundary-expected.checksum: Added.
  • platform/chromium-mac/fast/repaint/repaint-across-writing-mode-boundary-expected.png: Added.
  • platform/chromium-win/fast/repaint/repaint-across-writing-mode-boundary-expected.checksum: Added.
  • platform/chromium-win/fast/repaint/repaint-across-writing-mode-boundary-expected.png: Added.
  • platform/chromium-win/fast/repaint/repaint-across-writing-mode-boundary-expected.txt: Added.
  • platform/chromium-win/fast/table/colspanMinWidth-vertical-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt:
  • platform/chromium/test_expectations.txt:
13:14 EFLWebKit edited by barbieri@profusion.mobi
document cmake flags we should use for production/development builds (diff)
12:14 Changeset [71987] by commit-queue@webkit.org

2010-11-14 Ryuan Choi <ryuan.choi@samsung.com>

Reviewed by Martin Robinson.

[EFL] add pango support
https://bugs.webkit.org/show_bug.cgi?id=46029

Add FONT_BACKEND option to switch between pango and freetype.

  • cmake/OptionsEfl.cmake:

2010-11-14 Ryuan Choi <ryuan.choi@samsung.com>

Reviewed by Martin Robinson.

[EFL] add pango support
https://bugs.webkit.org/show_bug.cgi?id=46029

Include pango related files.
No new tests; functionality is unchanged.

  • CMakeListsEfl.txt:

2010-11-14 Ryuan Choi <ryuan.choi@samsung.com>

Reviewed by Martin Robinson.

[EFL] add pango support
https://bugs.webkit.org/show_bug.cgi?id=46029

Add pango in include and libs.

  • CMakeListsEfl.txt:
11:59 Changeset [71986] by levin@chromium.org

2010-11-14 David Levin <levin@chromium.org>

Reviewed by Shinichiro Hamaji.

check-webkit-style function detection and the line count style checks should be separate.
https://bugs.webkit.org/show_bug.cgi?id=49512

  • Scripts/webkitpy/style/checkers/cpp.py: Do the separation.
  • Scripts/webkitpy/style/checkers/cpp_unittest.py: Adjust the test to call the detection function and fix line counts in two places now that the code really only counts the lines in the body of the function.
11:39 Changeset [71985] by andreas.kling@nokia.com

2010-11-14 Andreas Kling <kling@webkit.org>

Reviewed by Antonio Gomes.

http/tests/plugins tests print "Unhandled variable" to stderr under Qt
https://bugs.webkit.org/show_bug.cgi?id=33438

Stifle "Unhandled variable" warning to match what the other
TestNetscapePlugin does (NPP_GetValue in TestNetscapePlugIn/main.cpp
simply returns NPERR_GENERIC_ERROR for unhandled variables.)

  • DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: (webkit_test_plugin_get_value):
11:11 Changeset [71984] by andreas.kling@nokia.com

2010-11-12 Tenghui Zhu <ztenghui@google.com>

Reviewed by Andreas Kling.

[V8] Code generation script error in generating the SVGStaticListPropertyTearOff
https://bugs.webkit.org/show_bug.cgi?id=49463

  • bindings/scripts/CodeGeneratorV8.pm: The svgNativeType is the one containing the SVGStaticListPropertyTearOff string, not the svgListPropertyType.
10:43 Changeset [71983] by andreas.kling@nokia.com

2010-11-14 Andreas Kling <kling@webkit.org>

Reviewed by Antonio Gomes.

REGRESSION(r71895): API test javaScriptWindowObjectCleared fails
https://bugs.webkit.org/show_bug.cgi?id=49466

As of r71895 empty inline scripts are no longer executed and so
the javaScriptWindowObjectCleared() signal is no longer triggered
by <script></script>.

  • tests/qwebframe/tst_qwebframe.cpp:
09:18 Changeset [71982] by paroga@webkit.org

2010-11-14 Patrick Gansterer <paroga@webkit.org>

Reviewed by Andreas Kling.

Sort CMakeLists.txt
https://bugs.webkit.org/show_bug.cgi?id=49507

  • CMakeLists.txt:

11/13/10:

23:56 Changeset [71981] by paroga@webkit.org

2010-11-13 Patrick Gansterer <paroga@webkit.org>

Reviewed by Yury Semikhatsky.

Buildfix for !ENABLE(INSPECTOR)
https://bugs.webkit.org/show_bug.cgi?id=49500

Also unify the position of the condition in the cpp files.

  • inspector/ConsoleMessage.cpp:
  • inspector/InspectorResourceAgent.cpp:
  • inspector/InspectorState.cpp:
  • inspector/ScriptCallFrame.cpp:
  • inspector/ScriptCallStack.cpp:
22:14 Changeset [71980] by hyatt@apple.com

https://bugs.webkit.org/show_bug.cgi?id=49506

Reviewed by Anders Carlsson.

Repaint is broken across writing mode boundaries. It's not enough to add in flipped offsets. You have
to flip the rect itself.

WebCore:

Added fast/repaint/repaint-across-writing-mode-boundary.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeRectForRepaint):

LayoutTests:

Added fast/repaint/repaint-across-writing-mode-boundary.html

  • fast/repaint/repaint-across-writing-mode-boundary.html: Added.
  • platform/mac/fast/repaint/repaint-across-writing-mode-boundary-expected.checksum: Added.
  • platform/mac/fast/repaint/repaint-across-writing-mode-boundary-expected.png: Added.
  • platform/mac/fast/repaint/repaint-across-writing-mode-boundary-expected.txt: Added.
21:31 Changeset [71979] by hyatt@apple.com

https://bugs.webkit.org/show_bug.cgi?id=49505

Reviewed by Dan Bernstein.

REGRESSION: @font-face doesn't work with the small-caps variant. This was broken by the addition of SVG fonts
support long ago. This patch fixes the SVG code so that it doesn't break non-SVG fonts.

Added fast/blockflow/broken-ideograph-small-caps.html

WebCore:

  • css/CSSFontFace.cpp:

(WebCore::CSSFontFace::hasSVGFontFaceSource):

  • css/CSSFontFace.h:
  • css/CSSFontFaceSource.cpp:

(WebCore::CSSFontFaceSource::getFontData):

  • css/CSSFontFaceSource.h:
  • css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::addFontFaceRule):
(WebCore::CSSFontSelector::getFontData):

LayoutTests:

  • fast/blockflow/broken-ideograph-small-caps.html: Added.
  • platform/mac/fast/blockflow/broken-ideograph-small-caps-expected.checksum: Added.
  • platform/mac/fast/blockflow/broken-ideograph-small-caps-expected.png: Added.
  • platform/mac/fast/blockflow/broken-ideograph-small-caps-expected.txt: Added.
20:55 Changeset [71978] by levin@chromium.org

2010-11-13 David Levin <levin@chromium.org>

Reviewed by Eric Seidel.

check-webkit-style function detection crashes on functions in templates.
https://bugs.webkit.org/show_bug.cgi?id=49504

For example "template <bool shouldClose(const Element*)>".

  • Scripts/webkitpy/style/checkers/cpp.py: If not function is detected, bail out.
  • Scripts/webkitpy/style/checkers/cpp_unittest.py: Modified the complex function detection test to expose this issue.
20:35 Changeset [71977] by mitz@apple.com

fast/text/hyphen* tests have different results on Leopard
https://bugs.webkit.org/show_bug.cgi?id=43296

Reviewed by Dave Hyatt.

  • platform/text/mac/TextBreakIteratorInternalICUMac.mm:

(WebCore::topLanguagePreference): Changed to look up the value of the AppleLanguages default
through the normal NSUserDefaults search order rather than skipping the application domain.
This makes this function respect DumpRenderTree’s setting of the default in the application
domain.

20:11 Changeset [71976] by levin@chromium.org

check-webkit-style function detection doesn't detect indented functions declaractions.
https://bugs.webkit.org/show_bug.cgi?id=49446

Reviewed by Shinichiro Hamaji.

Indented function declarations occur inside class definitions, so
they are a pretty common (and worth detecting).

  • Scripts/webkitpy/style/checkers/cpp.py: Changed regex to allow indentation. Changed the function start detection to only happen when not in a function. Changed function end detection to work based on matching braces instead of finding a close brace at the beginning of the line. Fixed close_expression to do what it says when it doesn't find the close.
  • Scripts/webkitpy/style/checkers/cpp_unittest.py: Indented function test.
20:04 Changeset [71975] by hyatt@apple.com

https://bugs.webkit.org/show_bug.cgi?id=49499

Reviewed by Dan Bernstein.

broken-ideographic-font.html causes layout test flakiness in release builds. The reason for this is
that the custom font data for m_brokenIdeographFontData was never getting pruned out of the tree.
The same problem exists for custom small caps fonts, so I made sure that the small caps fonts get
pruned as well. In addition, custom small caps fonts were never getting deleted either.

I also made allowsLigatures in FontPlatformData orientation-independent, and the callers check it
instead.

Unskip fast/blockflow/broken-ideographic-font.html

  • platform/graphics/SimpleFontData.cpp:

(WebCore::SimpleFontData::~SimpleFontData):

  • platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:

(WebCore::SimpleFontData::platformDestroy):
(WebCore::SimpleFontData::smallCapsFontData):

  • platform/graphics/chromium/SimpleFontDataLinux.cpp:

(WebCore::SimpleFontData::platformDestroy):
(WebCore::SimpleFontData::smallCapsFontData):

  • platform/graphics/cocoa/FontPlatformDataCocoa.mm:

(WebCore::FontPlatformData::allowsLigatures):

  • platform/graphics/freetype/SimpleFontDataFreeType.cpp:

(WebCore::SimpleFontData::platformDestroy):
(WebCore::SimpleFontData::smallCapsFontData):

  • platform/graphics/haiku/SimpleFontDataHaiku.cpp:

(WebCore::SimpleFontData::platformDestroy):
(WebCore::SimpleFontData::smallCapsFontData):

  • platform/graphics/mac/ComplexTextControllerATSUI.cpp:

(WebCore::disableLigatures):

  • platform/graphics/mac/SimpleFontDataCoreText.cpp:

(WebCore::SimpleFontData::getCFStringAttributes):

  • platform/graphics/mac/SimpleFontDataMac.mm:

(WebCore::SimpleFontData::platformDestroy):

  • platform/graphics/win/SimpleFontDataWin.cpp:

(WebCore::SimpleFontData::platformDestroy):
(WebCore::SimpleFontData::smallCapsFontData):

  • platform/graphics/wx/SimpleFontDataWx.cpp:

(WebCore::SimpleFontData::platformDestroy):
(WebCore::SimpleFontData::smallCapsFontData):

14:48 Changeset [71974] by hyatt@apple.com

Skip the broken ideograph test until I can figure out why it corrupts release builds.

12:46 Changeset [71973] by hyatt@apple.com

Another attempt to fix layout tests.

12:00 Changeset [71972] by hyatt@apple.com

https://bugs.webkit.org/show_bug.cgi?id=49496

Fix broken-ideographic-font.html. I had the font installed locally on my machine, and this covered up
the fact that CoreText was implicitly using it as fallback in the vertical case only. The bots don't have
the font installed locally, and so they showed the bug.

Make sure the GlyphPage is filled with horizontal glyphs for a broken ideograph font, so that CoreText is
willing to fill.

  • platform/graphics/mac/SimpleFontDataCoreText.cpp:

(WebCore::SimpleFontData::getCFStringAttributes):

11:29 Changeset [71971] by rwlbuis@webkit.org

2010-11-13 Rob Buis <rwlbuis@gmail.com>

Unreviewed test expectation rebaseline.

  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt:
10:45 Changeset [71970] by hyatt@apple.com

https://bugs.webkit.org/show_bug.cgi?id=49464

Reviewed by Dan Bernstein.

Fix bugs with the orientation of fonts when the font is brought in via fallback, when the font contains no
vertical tables, or when the font is loaded via font-face in both horizontal and vertical forms.

(1) Include orientation as part of the @font-face hashtables so that the fonts are treated as
distinct when used in horizontal and vertical forms.

(2) Let the orientation member of FontPlatformData represent the desired orientation rather than
the supported one. Add an orientation member to SimpleFontData that represents the actual
supported orientation of the font.

(3) For fonts with no vertical tables, add a brokenIdeographicsFont accessor that is invoked when
CJK ideographs are encountered. This is essentially identical to the small caps fallback mechanism
but invoked only for ideographs. The special ideograph font locks the orientation to vertical and
renders the glyphs upright even when the font has no vertical tables. Punctuation and such will
still look funny, and really this is a bug in the font, but at least this way it will be apparent
that the font is to blame.

Added fast/blockflow/broken-ideographic-font.html and fast/blockflow/vertical-font-fallback.html.

WebCore:

  • css/CSSFontFaceSource.cpp:

(WebCore::CSSFontFaceSource::getFontData):

  • css/CSSSegmentedFontFace.cpp:

(WebCore::CSSSegmentedFontFace::getFontData):

  • platform/graphics/Font.cpp:

(WebCore::Font::isCJKIdeograph):

  • platform/graphics/Font.h:
  • platform/graphics/FontFastPath.cpp:

(WebCore::Font::glyphDataForCharacter):

  • platform/graphics/SimpleFontData.cpp:

(WebCore::SimpleFontData::SimpleFontData):
(WebCore::SimpleFontData::~SimpleFontData):
(WebCore::SimpleFontData::brokenIdeographFontData):

  • platform/graphics/SimpleFontData.h:

(WebCore::SimpleFontData::orientation):

  • platform/graphics/cocoa/FontPlatformDataCocoa.mm:

(WebCore::FontPlatformData::FontPlatformData):

  • platform/graphics/mac/FontMac.mm:

(WebCore::showGlyphsWithAdvances):

  • platform/graphics/mac/SimpleFontDataMac.mm:

(WebCore::SimpleFontData::platformInit):
(WebCore::SimpleFontData::platformBoundsForGlyph):
(WebCore::SimpleFontData::platformWidthForGlyph):

LayoutTests:

  • fast/blockflow/broken-ideographic-font.html: Added.
  • fast/blockflow/resources/MakibaFont13.ttf: Added.
  • fast/blockflow/vertical-font-fallback.html: Added.
  • platform/mac/fast/blockflow/broken-ideographic-font-expected.checksum: Added.
  • platform/mac/fast/blockflow/broken-ideographic-font-expected.png: Added.
  • platform/mac/fast/blockflow/broken-ideographic-font-expected.txt: Added.
  • platform/mac/fast/blockflow/vertical-font-fallback-expected.checksum: Added.
  • platform/mac/fast/blockflow/vertical-font-fallback-expected.png: Added.
  • platform/mac/fast/blockflow/vertical-font-fallback-expected.txt: Added.
09:16 Changeset [71969] by rwlbuis@webkit.org

2010-11-13 Rob Buis <rwlbuis@gmail.com>

Reviewed by Dirk Schulze.

requiredFeatures does not adapt to SVGStringList changes
https://bugs.webkit.org/show_bug.cgi?id=40887

Centralize logic of handling of SVGElement validity changes.
The logic is to detach the SVGElement when changing from valid
to invalid, and to attach when changing from invalid to valid.

Tests: svg/dynamic-updates/SVGCircleElement-dom-requiredFeatures.html

svg/dynamic-updates/SVGCircleElement-svgdom-requiredFeatures.html
svg/dynamic-updates/SVGEllipseElement-dom-requiredFeatures.html
svg/dynamic-updates/SVGEllipseElement-svgdom-requiredFeatures.html
svg/dynamic-updates/SVGForeignObjectElement-dom-requiredFeatures.html
svg/dynamic-updates/SVGForeignObjectElement-svgdom-requiredFeatures.html
svg/dynamic-updates/SVGGElement-dom-requiredFeatures.html
svg/dynamic-updates/SVGGElement-svgdom-requiredFeatures.html
svg/dynamic-updates/SVGImageElement-dom-requiredFeatures.html
svg/dynamic-updates/SVGImageElement-svgdom-requiredFeatures.html
svg/dynamic-updates/SVGLineElement-dom-requiredFeatures.html
svg/dynamic-updates/SVGLineElement-svgdom-requiredFeatures.html
svg/dynamic-updates/SVGPathElement-dom-requiredFeatures.html
svg/dynamic-updates/SVGPathElement-svgdom-requiredFeatures.html
svg/dynamic-updates/SVGPolygonElement-dom-requiredFeatures.html
svg/dynamic-updates/SVGPolygonElement-svgdom-requiredFeatures.html
svg/dynamic-updates/SVGPolylineElement-dom-requiredFeatures.html
svg/dynamic-updates/SVGPolylineElement-svgdom-requiredFeatures.html
svg/dynamic-updates/SVGRectElement-dom-requiredFeatures.html
svg/dynamic-updates/SVGRectElement-svgdom-requiredFeatures.html
svg/dynamic-updates/SVGSVGElement-dom-requiredFeatures.html
svg/dynamic-updates/SVGSVGElement-svgdom-requiredFeatures.html
svg/dynamic-updates/SVGTextElement-dom-requiredFeatures.html
svg/dynamic-updates/SVGTextElement-svgdom-requiredFeatures.html
svg/dynamic-updates/SVGUseElement-dom-requiredFeatures.html
svg/dynamic-updates/SVGUseElement-svgdom-requiredFeatures.html

08:39 Changeset [71968] by paroga@webkit.org

2010-11-13 Patrick Gansterer <paroga@webkit.org>

Unreviewed, build fix after r71541.

  • WebCoreSupport/ChromeClientWinCE.h:
08:32 Changeset [71967] by caseq@chromium.org

2010-11-13 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [refactoring] support Views in TabbedPane and streamline tab selection in resource view
https://bugs.webkit.org/show_bug.cgi?id=49493

  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype._showResource):
  • inspector/front-end/ResourceView.js: (WebInspector.ResourceView): (WebInspector.ResourceView.prototype.selectContentTab): (WebInspector.ResourceView.prototype._selectTab): (WebInspector.ResourceView.prototype._refreshCookies): (WebInspector.ResourceCookiesTab.prototype.show):
  • inspector/front-end/StoragePanel.js: (WebInspector.StoragePanel.prototype.showResource):
  • inspector/front-end/TabbedPane.js: (WebInspector.TabbedPane.prototype.appendTab): (WebInspector.TabbedPane.prototype.hasTab): (WebInspector.TabbedPane.prototype.selectTabById): (WebInspector.TabbedPane.prototype._hideTab): (WebInspector.TabbedPane.prototype._showTab):
  • inspector/front-end/inspector.css: (.resource-view-cookies): (.resource-view-cookies.visible):
06:50 Changeset [71966] by yurys@chromium.org

2010-11-13 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

REGRESSION(71515): Web Inspector: Safari crash calling console.log when Log JavaScript Exceptions to Console is checked
https://bugs.webkit.org/show_bug.cgi?id=49362

  • page/Console.cpp: (WebCore::Console::addMessage): avoid accessing ScriptArguments and ScriptCallStack after their ownership has been passed to the inspector.
03:04 Changeset [71965] by yurys@chromium.org

2010-11-13 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: DOM event listener name is cropped in Elements panel
https://bugs.webkit.org/show_bug.cgi?id=49387

  • inspector/front-end/inspector.css: (.event-bar): use margin-left instead of left to fit child node into its parent
03:02 Changeset [71964] by hamaji@chromium.org

2010-11-13 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Kent Tamura.

[Chromium] print doesn't work on http://nodejs.org/api.html
https://bugs.webkit.org/show_bug.cgi?id=49304

  • platform/chromium/test_expectations.txt:

2010-11-13 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Kent Tamura.

[Chromium] print doesn't work on http://nodejs.org/api.html
https://bugs.webkit.org/show_bug.cgi?id=49304

  • src/WebFrameImpl.cpp: (WebKit::ChromePrintContext::begin): (WebKit::WebFrameImpl::printBegin):
01:47 Changeset [71963] by commit-queue@webkit.org

2010-11-13 Ilya Sherman <isherman@chromium.org>

Reviewed by Shinichiro Hamaji.

Fixes regression from previous patch -- computes y offsets for elements
that are scrolled out of the window.
https://bugs.webkit.org/show_bug.cgi?id=49306

  • manual-tests/select-scroll.html: Added.
  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupListBox::layout):

11/12/10:

22:46 Changeset [71962] by dbates@webkit.org

2010-11-12 Daniel Bates <dbates@rim.com>

Reviewed by Adam Barth.

Transferred <iframe>s may not have a unique internal name
https://bugs.webkit.org/show_bug.cgi?id=48768

Fixes an issue where an <iframe> that is transferred from
document A to document B, where A != B, may not have a
unique internal name in B.

Test: fast/frames/iframe-reparenting-unique-name.html

  • html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::setNameAndOpenURL): Inlined code from HTMLFrameElementBase::setName() so that we can remove setName(), which was only called being called by HTMLFrameElementBase::setNameAndOpenURL().
  • html/HTMLFrameElementBase.h: Removed HTMLFrameElementBase::setName().
  • html/HTMLFrameOwnerElement.h: Removed HTMLFrameOwnerElement::setName().
  • page/Frame.cpp: (WebCore::Frame::transferChildFrameToNewDocument): Modified to call FrameTree::transferChild().
  • page/FrameTree.cpp: (WebCore::FrameTree::transferChild): Added. (WebCore::FrameTree::appendChild): Moved the majority of the code into FrameTree::actuallyAppendChild(). (WebCore::FrameTree::actuallyAppendChild): Added.
  • page/FrameTree.h:

2010-11-12 Daniel Bates <dbates@rim.com>

Reviewed by Adam Barth.

Transferred <iframe>s may not have a unique internal name
https://bugs.webkit.org/show_bug.cgi?id=48768

Tests that an <iframe> which is transferred from document A to
document B, where A != B, has a unique name in B.

  • fast/frames/iframe-reparenting-unique-name-expected.txt: Added.
  • fast/frames/iframe-reparenting-unique-name.html: Added.
22:28 Changeset [71961] by dbates@webkit.org

2010-11-12 Daniel Bates <dbates@rim.com>

Rubber-stamped by Nikolas Zimmermann.

Make do-file-rename rename files in the directory WebKit2.

This also makes the list of searched directories in do-file-rename
consistent with the list of searched directories in the script do-webcore-rename.

  • Scripts/do-file-rename:
18:00 Changeset [71960] by dpranke@chromium.org

2010-11-12 Dirk Pranke <dpranke@chromium.org>

Reviewed by James Robinson.

Attempt yet again to land the fix for bug 49360 (respecting
set-webkit-configuration). We need to handle the cases where
trying to run webkit-build-directory to find out where the
default configuration might be fails (that shows up on some
Chromium bots that apparently don't have perl installed).

https://bugs.webkit.org/show_bug.cgi?id=49360

  • Scripts/webkitpy/layout_tests/port/config.py:
  • Scripts/webkitpy/layout_tests/port/config_standalone.py: Added.
  • Scripts/webkitpy/layout_tests/port/config_unittest.py:
17:39 Changeset [71959] by joepeck@webkit.org

2010-11-12 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by Alexey Proskuryakov.

Some FrameLoader.h Cleanup
https://bugs.webkit.org/show_bug.cgi?id=49484

Removed function signatures without any implementation. The functions
used to exist, and were nicely refactored into PageCache in r60688 and
the signatures were left behind.

Removed function signature setLoadType. Added in r17238 back when the
file was named WebFrameLoader, and the implementation was lost during
the transition from its mm implementation.

Removed function signature updateHistoryAfterClientRedirect. Implementation
and call points were removed in r18541 but the signature was left behind,
and jumped files!

Removed unused debug variable m_didDispatchDidCommitLoad. It was added
and used in Assertions in r28399. It was removed soon after, in r28464
because they were, "firing like crazy. Not sure why yet." It was
never used again.

Added const qualifier and moved interruptionForPolicyChangeError to
be more like its buddies.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::FrameLoader): (WebCore::FrameLoader::checkLoadCompleteForThisFrame): (WebCore::FrameLoader::interruptionForPolicyChangeError): (WebCore::FrameLoader::dispatchDidCommitLoad):
  • loader/FrameLoader.h:
17:17 Changeset [71958] by mihaip@chromium.org

2010-11-12 Mihai Parparita <mihaip@chromium.org>

Reviewed by Adam Barth.

webkit-patch land logs commit message twice
https://bugs.webkit.org/show_bug.cgi?id=49482

Don't log the comment that's used by bugzilla.close_bug_as_fixed, since
that's just the commit message, which we now output following the
actual commit.

  • Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
16:57 Changeset [71957] by tony@chromium.org

2010-11-12 Tony Chang <tony@chromium.org>

Unreviewed, revert changes to script-object-invoke that crash
single process chromium.

  • plugins/script-object-invoke.html:
16:47 Changeset [71956] by yael.aharon@nokia.com

2010-11-12 Yael Aharon <yael.aharon@nokia.com>

Reviewed by David Hyatt.

Spatial Navigation: Cannot focus on some ContainerNode
https://bugs.webkit.org/show_bug.cgi?id=48393

  • fast/events/spatial-navigation/snav-container-only-white-space-expected.txt: Added.
  • fast/events/spatial-navigation/snav-container-only-white-space.html: Added.
  • fast/events/spatial-navigation/snav-container-white-space-expected.txt: Added.
  • fast/events/spatial-navigation/snav-container-white-space.html: Added.

2010-11-12 Yael Aharon <yael.aharon@nokia.com>

Reviewed by David Hyatt.

Spatial Navigation: Cannot focus on some ContainerNode
https://bugs.webkit.org/show_bug.cgi?id=48393

ContainerNode::getLowerRightCorner() assumes that the lowest right corner of its last child
is its own lowest right corner. If that child is an empty text node after an image, it does
not have size and position information, so we should go to the previous child.

Tests: fast/events/spatial-navigation/snav-container-only-white-space.html

fast/events/spatial-navigation/snav-container-white-space.html

  • dom/ContainerNode.cpp: (WebCore::ContainerNode::getLowerRightCorner):
16:34 Changeset [71955] by tony@chromium.org

2010-11-12 Tony Chang <tony@chromium.org>

Reviewed by Adam Barth.

run platform/chromium/plugins/script-object-invoke.html on all platforms
https://bugs.webkit.org/show_bug.cgi?id=49280

  • platform/chromium/drt_expectations.txt:
  • plugins/script-object-invoke-expected.txt: Renamed from LayoutTests/platform/chromium/plugins/script-object-invoke-expected.txt.
  • plugins/script-object-invoke.html: Renamed from LayoutTests/platform/chromium/plugins/script-object-invoke.html.

2010-11-12 Tony Chang <tony@chromium.org>

Reviewed by Adam Barth.

run platform/chromium/plugins/script-object-invoke.html on all platforms
https://bugs.webkit.org/show_bug.cgi?id=49280

  • DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp: (testScriptObjectInvoke): (pluginInvoke):
15:54 Changeset [71954] by mihaip@chromium.org

2010-11-12 Mihai Parparita <mihaip@chromium.org>

Reviewed by Adam Barth.

webkit-patch land-cowboy (and other commands) should display the committed SVN revision after landing a patch
https://bugs.webkit.org/show_bug.cgi?id=49471

Right now there's no indication of a successful commit.

  • Scripts/webkitpy/tool/commands/download_unittest.py:
  • Scripts/webkitpy/tool/steps/commit.py:
15:43 Changeset [71953] by mihaip@chromium.org

2010-11-12 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium expectations update.

fast/canvas/canvas-arc-360-winding.html needs to be skipped for the
GPU suite too.

  • platform/chromium-gpu/test_expectations.txt:
15:14 Changeset [71952] by kinuko@chromium.org

2010-11-12 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by Ojan Vafai.

Include detailed test modifiers in results.json and enable incremental uploading for non-layout tests
https://bugs.webkit.org/show_bug.cgi?id=49354

Also moved/integrated the upload method from run_webkit_tests.py to json_results_generator.py.

  • Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
14:51 Changeset [71951] by commit-queue@webkit.org

2010-11-12 James Simonsen <simonjam@chromium.org>

Reviewed by Darin Fisher.

[Web Timing] Rename interfaces:

  • fast/dom/Window/window-properties-performance-expected.txt: Class names changed.

2010-11-12 James Simonsen <simonjam@chromium.org>

Reviewed by Darin Fisher.

[Web Timing] Rename interfaces:

  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • page/Performance.cpp: (WebCore::Performance::navigation): (WebCore::Performance::timing):
  • page/Performance.h:
  • page/Performance.idl:
  • page/PerformanceNavigation.cpp: Renamed from WebCore/page/Navigation.cpp. (WebCore::PerformanceNavigation::PerformanceNavigation): (WebCore::PerformanceNavigation::frame): (WebCore::PerformanceNavigation::disconnectFrame): (WebCore::PerformanceNavigation::type): (WebCore::PerformanceNavigation::redirectCount):
  • page/PerformanceNavigation.h: Renamed from WebCore/page/Navigation.h. (WebCore::PerformanceNavigation::create):
  • page/PerformanceNavigation.idl: Renamed from WebCore/page/Navigation.idl.
  • page/PerformanceTiming.cpp: Renamed from WebCore/page/Timing.cpp. (WebCore::toIntegerMilliseconds): (WebCore::getPossiblySkewedTimeInKnownRange): (WebCore::PerformanceTiming::PerformanceTiming): (WebCore::PerformanceTiming::frame): (WebCore::PerformanceTiming::disconnectFrame): (WebCore::PerformanceTiming::navigationStart): (WebCore::PerformanceTiming::unloadEventEnd): (WebCore::PerformanceTiming::redirectStart): (WebCore::PerformanceTiming::redirectEnd): (WebCore::PerformanceTiming::fetchStart): (WebCore::PerformanceTiming::domainLookupStart): (WebCore::PerformanceTiming::domainLookupEnd): (WebCore::PerformanceTiming::connectStart): (WebCore::PerformanceTiming::connectEnd): (WebCore::PerformanceTiming::requestStart): (WebCore::PerformanceTiming::requestEnd): (WebCore::PerformanceTiming::responseStart): (WebCore::PerformanceTiming::responseEnd): (WebCore::PerformanceTiming::domLoading): (WebCore::PerformanceTiming::domInteractive): (WebCore::PerformanceTiming::domContentLoaded): (WebCore::PerformanceTiming::domComplete): (WebCore::PerformanceTiming::loadEventStart): (WebCore::PerformanceTiming::loadEventEnd): (WebCore::PerformanceTiming::documentLoader): (WebCore::PerformanceTiming::documentTiming): (WebCore::PerformanceTiming::documentLoadTiming): (WebCore::PerformanceTiming::resourceLoadTiming): (WebCore::PerformanceTiming::resourceLoadTimeRelativeToAbsolute):
  • page/PerformanceTiming.h: Renamed from WebCore/page/Timing.h. (WebCore::PerformanceTiming::create):
  • page/PerformanceTiming.idl: Renamed from WebCore/page/Timing.idl.

2010-11-12 James Simonsen <simonjam@chromium.org>

Reviewed by Darin Fisher.

[Web Timing] Rename interfaces:

  • src/WebPerformance.cpp: (WebKit::WebPerformance::navigationType):
14:40 Changeset [71950] by eric.carlson@apple.com

2010-11-12 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser.

Remove unused code from HTMLMediaElement
https://bugs.webkit.org/show_bug.cgi?id=49451

Just removing code, so no new tests.

  • html/HTMLMediaElement.cpp: Removed unused functions.
  • html/HTMLMediaElement.h:
14:00 Changeset [71949] by rniwa@webkit.org

2010-11-12 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed XCode project fix.

  • WebCore.xcodeproj/project.pbxproj:
13:59 Changeset [71948] by mihaip@chromium.org

2010-11-12 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium expectations update.

Mark fast/canvas/canvas-arc-360-winding.html as failing on Linux and
Windows.

  • platform/chromium/test_expectations.txt:
13:56 Changeset [71947] by ap@apple.com

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=49473

No change in behavior, so no tests.

  • css/WebKitCSSMatrix.cpp: (WebCore::WebKitCSSMatrix::WebKitCSSMatrix): We don't inherit from StyleBase any more, so no need to initialize always-null parent. (WebCore::WebKitCSSMatrix::setMatrixValue): Since there was never a parent, useStrictParsing() just returned true.
  • css/WebKitCSSMatrix.h: Just inherit from RefCounted<WebKitCSSMatrix>. Removed unused default constructor and copy constructor.
  • html/canvas/WebGLRenderingContext.h: Removed an unnneded forward declaration.
13:56 Changeset [71946] by jschuh@chromium.org

Merge 71918 - 2010-11-12 Justin Schuh <jschuh@chromium.org>

Reviewed by Adam Barth.

Use a RefPtr inside ContainerNode::willRemove loop
https://bugs.webkit.org/show_bug.cgi?id=49237

Test: fast/innerHTML/innerHTML-iframe.html

  • dom/ContainerNode.cpp: (WebCore::ContainerNode::willRemove):

2010-11-12 Justin Schuh <jschuh@chromium.org>

Reviewed by Adam Barth.

Use a RefPtr inside ContainerNode::willRemove loop
https://bugs.webkit.org/show_bug.cgi?id=49237

  • fast/innerHTML/innerHTML-iframe-expected.txt: Added.
  • fast/innerHTML/innerHTML-iframe.html: Added.

TBR=jschuh@chromium.org
BUG=62261

13:53 Changeset [71945] by jamesr@google.com

Merge 71345 - 2010-11-04 Eric Seidel <eric@webkit.org>

Reviewed by Gavin Barraclough.

REGRESSION(49798): Crash in HTMLObjectElement::parseMappedAttribute
https://bugs.webkit.org/show_bug.cgi?id=48789

The contract for all String/AtomicString methods seems to be that it's
safe to call them, even when the String is null (impl() returns 0).
This contract was broken by r49798 (unintentionally) when optimizing
for dromeo.
This patch adds a null check to AtomicString::lower() fixing this
crash and preventing future confusion.

  • wtf/text/AtomicString.cpp: (WTF::AtomicString::lower):

2010-11-04 Eric Seidel <eric@webkit.org>

Reviewed by Gavin Barraclough.

REGRESSION(49798): Crash in HTMLObjectElement::parseMappedAttribute
https://bugs.webkit.org/show_bug.cgi?id=48789

  • fast/dom/HTMLObjectElement/set-type-to-null-crash-expected.txt: Added.
  • fast/dom/HTMLObjectElement/set-type-to-null-crash.html: Added.

TBR=eric@webkit.org
BUG=55345

13:51 Changeset [71944] by commit-queue@webkit.org

2010-11-12 Jacob Dinu <dinu.jacob@nokia.com>

Reviewed by Andreas Kling.

[Qt] Update .def file for Symbian
https://bugs.webkit.org/show_bug.cgi?id=49456

Added missing symbols from revisions r69825, r70470, r71806

  • symbian/eabi/QtWebKitu.def:
13:47 Changeset [71943] by dglazkov@chromium.org

2010-11-12 Dimitri Glazkov <dglazkov@chromium.org>

Because of r71945, events from shadow DOM elements now bubble correctly
unless handled, which trips over the old issue in GTK.
https://bugs.webkit.org/show_bug.cgi?id=40601

  • platform/gtk/Skipped: Added media/controls-right-click-on-timebar.html.
13:34 Changeset [71942] by zmo@google.com

2010-11-12 Zhenyao Mo <zmo@google.com>

Reviewed by James Robinson.

WebGraphicsContext3DDefaultImpl does not run on top of OpenGL ES 2.0 implementations
https://bugs.webkit.org/show_bug.cgi?id=48282

Simple fix for a regression introduced in r71793.

  • src/WebGraphicsContext3DDefaultImpl.cpp: (WebKit::WebGraphicsContext3DDefaultImpl::initialize):
13:26 Changeset [71941] by jamesr@google.com

Merge 70840 - 2010-10-28 James Robinson <jamesr@chromium.org>

Reviewed by Simon Fraser.

iframes forced into slow scrolling mode by containing RenderLayer sometimes
https://bugs.webkit.org/show_bug.cgi?id=48570

Adds a test that verifies that the repaint region for a scrolled iframe is not
larger than necessary.

  • fast/repaint/iframe-scroll-repaint.html: Added.
  • fast/repaint/resources/iframe-scroll-repaint-iframe.html: Added.
  • platform/mac/fast/repaint/iframe-scroll-repaint-expected.checksum: Added.
  • platform/mac/fast/repaint/iframe-scroll-repaint-expected.png: Added.
  • platform/mac/fast/repaint/iframe-scroll-repaint-expected.txt: Added.

2010-10-28 James Robinson <jamesr@chromium.org>

Reviewed by Simon Fraser.

iframes forced into slow scrolling mode by containing RenderLayer sometimes
https://bugs.webkit.org/show_bug.cgi?id=48570

Only performs the overlap test for RenderLayers that paint themselves. This
prevents marking RenderWidgets as being overlapped unnecessarily.

Test: fast/repaint/iframe-scroll-repaint.html

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintLayer):

TBR=commit-queue@webkit.org

13:25 Changeset [71940] by mihaip@chromium.org

2010-11-12 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium expectations update.

Fix typo.

  • platform/chromium/test_expectations.txt:
13:07 Changeset [71939] by mihaip@chromium.org

2010-11-12 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium expectations update.

Mark some more tests as flaky.

  • platform/chromium/test_expectations.txt:
13:07 Changeset [71938] by benjamin.poulain@nokia.com

[Qt] Need to implement WebKit::pluginWillHandleLoadError for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=48764

WebKit/qt:

Reviewed by Andreas Kling.

Add the missing error.

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::pluginWillHandleLoadError):

WebKit2:

Reviewed by NOBODY (OOPS!).

Add the missing error to Qt support.

  • WebProcess/WebCoreSupport/qt/WebErrorsQt.cpp:

(WebKit::pluginWillHandleLoadError):

12:28 Changeset [71937] by sullivan@apple.com

Fixed Target for WKBundlePageOverlay.cpp.

Reviewed by Anders Carlsson.

  • WebKit2.xcodeproj/project.pbxproj:

Changed Target for WKBundlePageOverlay.cpp from WebProcess to WebKit2.

12:23 Changeset [71936] by commit-queue@webkit.org

2010-11-12 Helder Correia <helder@sencha.com>

Reviewed by Andreas Kling.

[Qt] Path::addArc() does not set right angle direction on full arcs
https://bugs.webkit.org/show_bug.cgi?id=49138

New test for nonzero winding rule correctness for full arc paths.

  • fast/canvas/canvas-arc-360-winding-expected.txt: Added.
  • fast/canvas/canvas-arc-360-winding.html: Added.
  • fast/canvas/script-tests/canvas-arc-360-winding.js: Added.

2010-11-12 Helder Correia <helder@sencha.com>

Reviewed by Andreas Kling.

[Qt] Path::addArc() does not set right angle direction on full arcs
https://bugs.webkit.org/show_bug.cgi?id=49138

Ensure correctness of nonzero winding rule for full arc paths.
Invert the sign of the span if the direction is counterclockwise.

Test: fast/canvas/canvas-arc-360-winding.html

  • platform/graphics/qt/PathQt.cpp: (WebCore::Path::addArc):
12:14 Changeset [71935] by andersca@apple.com

Need a way that WKBundlePageOverlayRef clients can make sure they only uninstall the overlay they installed
https://bugs.webkit.org/show_bug.cgi?id=49461
<rdar://problem/8662760>

Reviewed by John Sullivan.

  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageUninstallPageOverlay):

  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/WebPage/FindController.cpp:

(WebKit::FindController::findString):
(WebKit::FindController::hideFindUI):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::uninstallPageOverlay):

  • WebProcess/WebPage/WebPage.h:
11:49 Changeset [71934] by dglazkov@chromium.org

2010-11-05 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Darin Adler.

Implement shadow DOM-aware event targeting and introduce EventContext to track the context of each event dispatch.
https://bugs.webkit.org/show_bug.cgi?id=46015

Added more test coverage around events crossing shadow DOM boundaries and tweaked existing tests.

  • fast/events/shadow-boundary-crossing-2-expected.txt: Added.
  • fast/events/shadow-boundary-crossing-2.html: Added.
  • fast/events/shadow-boundary-crossing.html: Tuned to better reflect its point:

the event should indeed fire (it used to be swallowed), but its target
should be a non-shadow node.

  • media/audio-delete-while-slider-thumb-clicked.html : Tweaked to actually click on

the scrubber thumb (it was off by 2 pixels).

2010-11-05 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Darin Adler.

Implement shadow DOM-aware event targeting and introduce EventContext to track the context of each event dispatch.
https://bugs.webkit.org/show_bug.cgi?id=46015

Test: fast/events/shadow-boundary-crossing-2.html

This patch adds the notion of EventContext (and a very similar-acting WindowEventContext, specifically
for DOMWindow), an abstraction that carries information around dispatching an event for any given Node.

This abstraction is necessary to ensure that events, fired from shadow DOM nodes are properly retargeted to
appear as if they are coming from their host, thus never exposing the shadow DOM nodes to the world outside.

  • Android.mk: Added EventContext, WindowEventContext files.
  • CMakeLists.txt: Ditto.
  • GNUmakefile.am: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • dom/ContainerNode.cpp: (WebCore::notifyChildInserted): Changed to be shadow DOM-aware.
  • dom/EventContext.cpp: Added.
  • dom/EventContext.h: Added.
  • dom/Node.cpp: (WebCore::Node::markAncestorsWithChildNeedsStyleRecalc): Changed to be shadow DOM-aware. (WebCore::Node::createRendererIfNeeded): Ditto. (WebCore::Node::parentOrHostNode): Added new helper method. (WebCore::Node::enclosingLinkEventParentOrSelf): Changed to be shadow DOM-aware. (WebCore::eventTargetRespectingSVGTargetRules): Collapsed two helper methods into one. (WebCore::Node::getEventAncestors): Renamed and refactored to collect a vector of EventContexts. (WebCore::Node::topEventContext): Added. (WebCore::eventHasListeners): Changed to use EventContexts. (WebCore::Node::dispatchGenericEvent): Ditto.
  • dom/Node.h: Removed eventParentNode that's no longer needed, added parentOrHostNode decl,

and changed signature of eventAncestors to use EventContexts.

  • dom/Text.cpp: (WebCore::Text::createRenderer): Changed to be shadow DOM-aware.
  • dom/WindowEventContext.cpp: Added.
  • dom/WindowEventContext.h: Added.
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::getEventListenersForNode): Changed to use EventContexts.
  • page/EventHandler.cpp: (WebCore::EventHandler::updateMouseEventTargetNode): Removed code that's no longer necessary.
  • rendering/RenderTextControlMultiLine.cpp: (WebCore::RenderTextControlMultiLine::subtreeHasChanged): Removed event invocation that's

no longer necessary.

  • rendering/ShadowElement.h: Made m_shadowParent a RefPtr to avoid stale references when parent is deleted.
  • rendering/TextControlInnerElements.cpp: (WebCore::TextControlInnerTextElement::defaultEventHandler): Flipped the condition back

from where it was prior to r60418.

  • svg/SVGElement.cpp: Removed eventParentNode that's no longer needed.
  • svg/SVGElement.h: Ditto.
11:37 Changeset [71933] by commit-queue@webkit.org

2010-11-12 Ryuan Choi <ryuan.choi@samsung.com>

Reviewed by Martin Robinson.

[GTK] Remove unnecessary header for FontPlatformDataPango.cpp
https://bugs.webkit.org/show_bug.cgi?id=46029

Remove unnecessary header includes.
No new tests, as there's no functionality.

  • platform/graphics/pango/FontPlatformDataPango.cpp:
11:10 Changeset [71932] by andersca@apple.com

Allow MessageSender to override sendMessage
https://bugs.webkit.org/show_bug.cgi?id=49457

Reviewed by Sam Weinig.

Change MessageSender::send to encode the message and then call sendMessage.
This allows for clients to override sendMessage, something which WebProcessProxy
will be able to take advantage of.

  • Platform/CoreIPC/MessageSender.h:

(CoreIPC::MessageSender::send):
(CoreIPC::MessageSender::sendMessage):

10:52 Changeset [71931] by andersca@apple.com

CoreIPC cleanup
https://bugs.webkit.org/show_bug.cgi?id=49455

Reviewed by Sam Weinig.

Add a static create function to ArgumentEncoder.
Factor sync message argument encoder creation out into a new function,
createSyncMessageArgumentEncoder.

  • Platform/CoreIPC/ArgumentEncoder.cpp:

(CoreIPC::ArgumentEncoder::create):

  • Platform/CoreIPC/ArgumentEncoder.h:
  • Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::createSyncMessageArgumentEncoder):
(CoreIPC::Connection::dispatchSyncMessage):

  • Platform/CoreIPC/Connection.h:

(CoreIPC::Connection::send):
(CoreIPC::Connection::sendSync):

  • UIProcess/WebProcessProxy.h:

(WebKit::WebProcessProxy::send):

10:39 Changeset [71930] by weinig@apple.com

ASSERTION when converting some WKStringRefs returned from willSubmitForm to CFStringRef
<rdar://problem/8662180>
https://bugs.webkit.org/show_bug.cgi?id=49454

Reviewed by Anders Carlsson.

Enforce the invariant that a WebString never contains a null WTF::String at a
lower level, in the WebString constructor, instead of relying on the callers of
WebString::create to do it.

  • Shared/API/c/WKSharedAPICast.h:

(WebKit::toAPI):
(WebKit::toCopiedAPI): Remove null string check...

  • Shared/WebString.h:

(WebKit::WebString::WebString): ... and move it to the constructor.

  • Shared/API/c/WKURL.cpp:

(WKURLCopyString): Use toCopiedAPI() instead of calling WebString directly
to match other similar uses.

10:30 Changeset [71929] by mihaip@chromium.org

2010-11-12 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium expectations update.

Mark http/tests/media/video-cookie.html as flaky.

  • platform/chromium/test_expectations.txt:
10:25 Changeset [71928] by tony@chromium.org

2010-11-12 Tony Chang <tony@chromium.org>

Reviewed by Kent Tamura.

[chromium] Load a blank page when closing DRT WebViewHosts
https://bugs.webkit.org/show_bug.cgi?id=49417

  • platform/chromium/drt_expectations.txt: Fix 2 tests in DRT.

2010-11-12 Tony Chang <tony@chromium.org>

Reviewed by Kent Tamura.

[chromium] Load a blank page when closing DRT WebViewHosts
https://bugs.webkit.org/show_bug.cgi?id=49417

In test_shell, when we close a window, we first load about:blank
and run GC to fire the destruction logic of the page. In test_shell,
this happens in ~TestShell. In DRT, we manage virtual windows as
WebViewHosts, so we need to replicate this logic in ~WebViewHost.

Managing focus is a bit trickier, since normally you would get window
events to reset the focus to the right window. We do it manually
instead.

This fixes 2 plugin tests on DRT.

  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::~TestShell): Move window close logic to ~WebViewHost. (TestShell::closeWindow): Move widget close() to WVH destructor and

manage focus manually.

(TestShell::closeRemainingWindows): Comment typo.

  • DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::closeWidget): (invokeCloseWidget): (WebViewHost::closeWidgetSoon): Close the window asynchronously (matches

test_shell).

(WebViewHost::~WebViewHost):

  • DumpRenderTree/chromium/WebViewHost.h:
10:22 Changeset [71927] by mihaip@chromium.org

2010-11-12 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium rebaseline.

Accumulated rebaselines that were missed due to lots of tests having
expected failures because of bug 48634.

  • platform/chromium-linux/fast/css/input-search-padding-expected.checksum: Added.
  • platform/chromium-linux/fast/css/input-search-padding-expected.png: Added.
  • platform/chromium-linux/fast/css/input-search-padding-expected.txt: Added.
  • platform/chromium-mac/fast/css/input-search-padding-expected.checksum: Added.
  • platform/chromium-mac/fast/css/input-search-padding-expected.png: Added.
  • platform/chromium-mac/fast/lists/markers-in-selection-expected.checksum: Added.
  • platform/chromium-mac/fast/lists/markers-in-selection-expected.png:
  • platform/chromium-mac/fast/repaint/block-layout-inline-children-replaced-expected.checksum:
  • platform/chromium-mac/fast/repaint/block-layout-inline-children-replaced-expected.png:
  • platform/chromium-win/fast/css/input-search-padding-expected.checksum: Added.
  • platform/chromium-win/fast/css/input-search-padding-expected.png: Added.
  • platform/chromium-win/fast/css/input-search-padding-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
10:18 Changeset [71926] by levin@chromium.org

cpp.py needs some tidying.
https://bugs.webkit.org/show_bug.cgi?id=49443

Reviewed by Adam Barth.

  • Scripts/webkitpy/style/checkers/cpp.py: Fix parameter ordering for iteratively_replace_matches_with_char to mirror other similar functions (and improved comments, etc.) Also, use a python-ism (for/else) to get rid of a variable that was there to determine if something had been found in the loop.
10:18 Changeset [71925] by inferno@chromium.org

2010-11-11 Abhishek Arya <inferno@chromium.org>

Reviewed by Adam Barth.

Not allow drag and drop across different origins.
https://bugs.webkit.org/show_bug.cgi?id=49098

Test: http/tests/security/drag-drop-different-origin.html

  • page/DragController.cpp: (WebCore::DragController::tryDocumentDrag):
  • page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::canDropOnTarget):
  • page/SecurityOrigin.h:

2010-11-10 Abhishek Arya <inferno@chromium.org>

Reviewed by Adam Barth.

Check that drag and drop is not allowed across different origins.
https://bugs.webkit.org/show_bug.cgi?id=49098


  • http/tests/security/drag-drop-different-origin-expected.txt: Added.
  • http/tests/security/drag-drop-different-origin.html: Added.
  • http/tests/security/resources/drag-drop.html: Added.
10:09 Changeset [71924] by mihaip@chromium.org

2010-11-12 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium expectations update.

Now that we know better what is causing bug bug 48634, we can just
skip fast/images/size-failure.html instead of the 100+ tests that follow
it.

  • platform/chromium/test_expectations.txt:
09:59 Changeset [71923] by andersca@apple.com

CString(const char*) crashes when passed a null pointer
https://bugs.webkit.org/show_bug.cgi?id=49450

Reviewed by Adam Roben.

  • wtf/text/CString.cpp:

(WTF::CString::CString):
Return early if str is null.

09:55 Changeset [71922] by apavlov@chromium.org

2010-11-11 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Inspect element tooltip obscures element metrics
https://bugs.webkit.org/show_bug.cgi?id=47822

  • inspector/InspectorController.cpp: (WebCore::InspectorController::drawNodeHighlight): (WebCore::InspectorController::drawElementTitle):
09:43 Changeset [71921] by commit-queue@webkit.org

2010-11-12 Robert Kroeger <rjkroege@chromium.org>

Reviewed by James Robinson.

[Chromium/DRT] Make EventSendingController send complete touch events.
https://bugs.webkit.org/show_bug.cgi?id=49285

  • DumpRenderTree/chromium/EventSender.cpp: (EventSender::addTouchPoint): (EventSender::updateTouchPoint): (EventSender::sendCurrentTouchEvent):
09:30 Changeset [71920] by commit-queue@webkit.org

2010-11-12 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Button's background style from default Qt Mobile Theme is overriding facebook's button style
https://bugs.webkit.org/show_bug.cgi?id=48198

Instead of creating gradients that goes from white to grey and cover the whole element the gradients
are created by varying the alpha channel of a dark color. This way the effect will not override the
background color of the elements.

  • css/themeQtMobile.css:
09:23 Changeset [71919] by andreas.kling@nokia.com

2010-11-12 Andreas Kling <kling@webkit.org>

Reviewed by Antonio Gomes.

[Qt][WK2] Fix leaking of mapped files

MappedMemory::fileName was never set on the receiving side, which led
the MappedMemoryPool to call QFile::map() again when reusing an existing file.

  • Platform/qt/MappedMemoryPool.cpp: (WebKit::MappedMemoryPool::mapFile):
08:55 Changeset [71918] by jschuh@chromium.org

2010-11-12 Justin Schuh <jschuh@chromium.org>

Reviewed by Adam Barth.

Use a RefPtr inside ContainerNode::willRemove loop
https://bugs.webkit.org/show_bug.cgi?id=49237

Test: fast/innerHTML/innerHTML-iframe.html

  • dom/ContainerNode.cpp: (WebCore::ContainerNode::willRemove):

2010-11-12 Justin Schuh <jschuh@chromium.org>

Reviewed by Adam Barth.

Use a RefPtr inside ContainerNode::willRemove loop
https://bugs.webkit.org/show_bug.cgi?id=49237

  • fast/innerHTML/innerHTML-iframe-expected.txt: Added.
  • fast/innerHTML/innerHTML-iframe.html: Added.
08:41 Changeset [71917] by yurys@chromium.org

2010-11-12 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: add more event listener breakpoint types, add support for regular breakpoint hit state, beautify hit rendering.
https://bugs.webkit.org/show_bug.cgi?id=49130

  • English.lproj/localizedStrings.js:
  • inspector/front-end/BreakpointManager.js: (WebInspector.BreakpointManager.prototype.debuggerPaused): (WebInspector.Breakpoint.jsBreakpointId): (WebInspector.Breakpoint.prototype.get id):
  • inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.EventListenerBreakpointsSidebarPane): (WebInspector.EventListenerBreakpointsSidebarPane.prototype._createCategory):
  • inspector/front-end/CallStackSidebarPane.js: (WebInspector.CallStackSidebarPane.prototype._breakpointHit): don't call populateStatusMessage for JS breakpoints since there is no specific message in that case.
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype.reset):
  • inspector/front-end/inspector.css: (#elements-sidebar): (.pane > .body): (#scripts-sidebar): (li.breakpoint-hit .breakpoint-hit-marker):
08:37 Changeset [71916] by mihaip@chromium.org

2010-11-12 Mihai Parparita <mihaip@chromium.org>

Unreviewed rollout of r71858.

Rollout out r71858 since it breaks new-run-webkit-httpd as used by the
NaCl tests.

  • Scripts/webkitpy/layout_tests/port/config.py:
  • Scripts/webkitpy/layout_tests/port/config_standalone.py: Removed.
  • Scripts/webkitpy/layout_tests/port/config_unittest.py:
08:36 Changeset [71915] by yael.aharon@nokia.com

2010-11-12 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Antonio Gomes.

Spatial Navigation: Need better way to control size of content in tests.
https://bugs.webkit.org/show_bug.cgi?id=49398

Add an image and use it in a layout test to define fixed size for all ports.
This also fixes https://bugs.webkit.org/show_bug.cgi?id=43030

  • fast/events/spatial-navigation/resources/green.png: Added.
  • fast/events/spatial-navigation/snav-clipped-overflowed-content-expected.txt:
  • fast/events/spatial-navigation/snav-clipped-overflowed-content.html:
  • platform/qt/Skipped:
08:30 Changeset [71914] by aroben@apple.com

Skip a timing-out test on Windows XP

  • platform/win-xp/Skipped: Added. Skip

fast/workers/storage/change-version-handle-reuse-worker.html.

08:30 Changeset [71913] by aroben@apple.com

Land new Windows results for tests added in r71851

  • platform/win/fast/repaint/japanese-rl-selection-clear-expected.checksum: Added.
  • platform/win/fast/repaint/japanese-rl-selection-clear-expected.png: Added.
  • platform/win/fast/repaint/japanese-rl-selection-clear-expected.txt: Added.
  • platform/win/fast/repaint/japanese-rl-selection-repaint-expected.checksum: Added.
  • platform/win/fast/repaint/japanese-rl-selection-repaint-expected.png: Added.
  • platform/win/fast/repaint/japanese-rl-selection-repaint-expected.txt: Added.
08:25 Changeset [71912] by bulach@chromium.org

2010-11-12 Marcus Bulach <bulach@chromium.org>

Not reviewed, Chromium test expectation update.

Update chromium baselines for svg following r71908 (missed mac in r71910).
https://bugs.webkit.org/show_bug.cgi?id=49447

  • platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in-attr-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in-attr-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in2-attr-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in2-attr-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-scale-attr-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-scale-attr-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-xChannelSelector-attr-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-xChannelSelector-attr-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-yChannelSelector-attr-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-yChannelSelector-attr-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in-prop-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in-prop-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in2-prop-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in2-prop-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-scale-prop-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-scale-prop-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-xChannelSelector-prop-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-xChannelSelector-prop-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-yChannelSelector-prop-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-yChannelSelector-prop-expected.png: Added.
07:43 Changeset [71911] by caseq@chromium.org

2010-11-12 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [Extensions API] [refactoring] generate public API interfaces automatically
Adjusting the order of properties in API interfaces dumps in the expectations.
https://bugs.webkit.org/show_bug.cgi?id=49441

  • inspector/extensions-api-expected.txt:
  • inspector/extensions-audits-api-expected.txt:
  • inspector/extensions-expected.txt:

2010-11-12 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [Extensions API] [refactoring] generate public API interfaces automatically
https://bugs.webkit.org/show_bug.cgi?id=49441

07:39 Changeset [71910] by bulach@chromium.org

2010-11-12 Marcus Bulach <bulach@chromium.org>

Not reviewed, Chromium test expectation update.

Update chromium baselines for svg following r71908
https://bugs.webkit.org/show_bug.cgi?id=49440

  • platform/chromium-linux/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in2-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in2-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-scale-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-scale-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-xChannelSelector-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-xChannelSelector-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-yChannelSelector-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-yChannelSelector-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in2-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in2-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-scale-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-scale-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-xChannelSelector-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-xChannelSelector-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-yChannelSelector-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-yChannelSelector-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in2-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in2-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-scale-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-scale-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-xChannelSelector-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-xChannelSelector-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-yChannelSelector-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-yChannelSelector-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in2-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in2-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-scale-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-scale-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-xChannelSelector-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-xChannelSelector-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-yChannelSelector-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-yChannelSelector-prop-expected.png: Added.
07:25 Changeset [71909] by aroben@apple.com

Windows build fix

  • win/WebKit2Generated.make: Copy WKBundlePageOverlay.h.
05:52 Changeset [71908] by reni@webkit.org

WebCore: SVGFEDisplacementMapElement doesn't support dynamic invalidation
https://bugs.webkit.org/show_bug.cgi?id=49430

Patch by Renata Hodovan <reni@webkit.org> on 2010-11-12
Reviewed by Nikolas Zimmermann.

The dynamic changes are captured by the svgAttributeChanged function. Invalidate the filter primitive if necessary.

Tests: svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in-attr.html

svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in2-attr.html
svg/dynamic-updates/SVGFEDisplacementMapElement-dom-scale-attr.html
svg/dynamic-updates/SVGFEDisplacementMapElement-dom-xChannelSelector-attr.html
svg/dynamic-updates/SVGFEDisplacementMapElement-dom-yChannelSelector-attr.html
svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in-prop.html
svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in2-prop.html
svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-scale-prop.html
svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-xChannelSelector-prop.html
svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-yChannelSelector-prop.html

  • svg/SVGFEDisplacementMapElement.cpp:

(WebCore::SVGFEDisplacementMapElement::svgAttributeChanged):

  • svg/SVGFEDisplacementMapElement.h:

LayoutTests: SVGFEDisplacementMapElement doesn't support dynamic invalidation, when attributes change.
https://bugs.webkit.org/show_bug.cgi?id=49430

Patch by Renata Hodovan <reni@webkit.org> on 2010-11-12
Reviewed by Nikolas Zimmermann.

Adding layout tests for feDisplacementMap dynamic changes.

  • platform/mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in2-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in2-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-scale-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-scale-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-xChannelSelector-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-xChannelSelector-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-yChannelSelector-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-yChannelSelector-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in-prop-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in2-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in2-prop-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-scale-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-scale-prop-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-xChannelSelector-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-xChannelSelector-prop-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-yChannelSelector-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-yChannelSelector-prop-expected.png: Added.
  • svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in-attr.html: Added.
  • svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in2-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in2-attr.html: Added.
  • svg/dynamic-updates/SVGFEDisplacementMapElement-dom-scale-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGFEDisplacementMapElement-dom-scale-attr.html: Added.
  • svg/dynamic-updates/SVGFEDisplacementMapElement-dom-xChannelSelector-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGFEDisplacementMapElement-dom-xChannelSelector-attr.html: Added.
  • svg/dynamic-updates/SVGFEDisplacementMapElement-dom-yChannelSelector-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGFEDisplacementMapElement-dom-yChannelSelector-attr.html: Added.
  • svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in-prop.html: Added.
  • svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in2-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in2-prop.html: Added.
  • svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-scale-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-scale-prop.html: Added.
  • svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-xChannelSelector-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-xChannelSelector-prop.html: Added.
  • svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-yChannelSelector-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-yChannelSelector-prop.html: Added.
  • svg/dynamic-updates/script-tests/SVGFEDisplacementMapElement-dom-in-attr.js: Added.

(executeTest):

  • svg/dynamic-updates/script-tests/SVGFEDisplacementMapElement-dom-in2-attr.js: Added.

(executeTest):

  • svg/dynamic-updates/script-tests/SVGFEDisplacementMapElement-dom-scale-attr.js: Added.

(executeTest):

  • svg/dynamic-updates/script-tests/SVGFEDisplacementMapElement-dom-xChannelSelector-attr.js: Added.

(executeTest):

  • svg/dynamic-updates/script-tests/SVGFEDisplacementMapElement-dom-yChannelSelector-attr.js: Added.

(executeTest):

  • svg/dynamic-updates/script-tests/SVGFEDisplacementMapElement-svgdom-in-prop.js: Added.

(executeTest):

  • svg/dynamic-updates/script-tests/SVGFEDisplacementMapElement-svgdom-in2-prop.js: Added.

(executeTest):

  • svg/dynamic-updates/script-tests/SVGFEDisplacementMapElement-svgdom-scale-prop.js: Added.

(executeTest):

  • svg/dynamic-updates/script-tests/SVGFEDisplacementMapElement-svgdom-xChannelSelector-prop.js: Added.

(executeTest):

  • svg/dynamic-updates/script-tests/SVGFEDisplacementMapElement-svgdom-yChannelSelector-prop.js: Added.

(executeTest):

05:45 Changeset [71907] by benjamin.poulain@nokia.com

2010-11-12 Benjamin Poulain <benjamin.poulain@nokia.com>

Unreviewed fix after r71857.

  • UIProcess/qt/WebInspectorProxyQt.cpp:
  • WebProcess/WebPage/qt/WebInspectorQt.cpp:
05:34 Changeset [71906] by caseq@chromium.org

2010-11-12 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [refactoring] do not use absolute positioning for tabbed panes
https://bugs.webkit.org/show_bug.cgi?id=49439

  • inspector/front-end/TabbedPane.js: (WebInspector.TabbedPane): (WebInspector.TabbedPane.prototype.appendTab):
  • inspector/front-end/inspector.css: (.resource-view.visible): (.resource-view .tabbed-pane-header): (.resource-view-cookies): (.tabbed-pane): (.tabbed-pane-content):
  • inspector/front-end/networkPanel.css:
04:49 Changeset [71905] by inferno@chromium.org

Merge 71895

BUG=61313

04:42 Changeset [71904] by inferno@chromium.org

Merge 71797

BUG=61313

04:04 Changeset [71903] by commit-queue@webkit.org

2010-11-12 John Knottenbelt <jknotten@chromium.org>

Reviewed by Steve Block.

Rename GeolocationControllerClient to GeolocationClient.
https://bugs.webkit.org/show_bug.cgi?id=49259

No new tests, renaming only.

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.order:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • page/GeolocationClient.h: Renamed from WebCore/page/GeolocationControllerClient.h. (WebCore::GeolocationClient::~GeolocationClient):
  • page/GeolocationController.cpp: (WebCore::GeolocationController::GeolocationController):
  • page/GeolocationController.h:
  • page/Page.h:

2010-11-12 John Knottenbelt <jknotten@chromium.org>

Reviewed by Steve Block.

Rename GeolocationControllerClient to GeolocationClient.
https://bugs.webkit.org/show_bug.cgi?id=49259

  • WebKit.xcodeproj/project.pbxproj:

2010-11-12 John Knottenbelt <jknotten@chromium.org>

Reviewed by Steve Block.

Rename GeolocationControllerClient to GeolocationClient.
https://bugs.webkit.org/show_bug.cgi?id=49259

  • WebCoreSupport/WebGeolocationClient.h: Renamed from WebKit/mac/WebCoreSupport/WebGeolocationControllerClient.h. (WebGeolocationClient::webView): (WebGeolocationClient::setEnableHighAccuracy):
  • WebCoreSupport/WebGeolocationClient.mm: Renamed from WebKit/mac/WebCoreSupport/WebGeolocationControllerClient.mm. (WebGeolocationClient::WebGeolocationClient): (WebGeolocationClient::geolocationDestroyed): (WebGeolocationClient::startUpdating): (WebGeolocationClient::stopUpdating): (WebGeolocationClient::lastPosition):
  • WebKit.order:
  • WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):

2010-11-12 John Knottenbelt <jknotten@chromium.org>

Reviewed by Steve Block.

Rename GeolocationControllerClient to GeolocationClient.
https://bugs.webkit.org/show_bug.cgi?id=49259

  • WebCoreSupport/WebGeolocationClient.cpp: Renamed from WebKit/win/WebCoreSupport/WebGeolocationControllerClient.cpp. (WebGeolocationClient::WebGeolocationClient): (WebGeolocationClient::geolocationDestroyed): (WebGeolocationClient::startUpdating): (WebGeolocationClient::stopUpdating): (WebGeolocationClient::lastPosition):
  • WebCoreSupport/WebGeolocationClient.h: Renamed from WebKit/win/WebCoreSupport/WebGeolocationControllerClient.h. (WebGeolocationClient::setEnableHighAccuracy):
  • WebKit.vcproj/WebKit.vcproj:
  • WebView.cpp: (WebView::initWithFrame):
03:30 Changeset [71902] by benjamin.poulain@nokia.com

2010-11-12 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] TestController::runUntil doesn't honor the timeout parameter
https://bugs.webkit.org/show_bug.cgi?id=48941

Implement the missing timeout of WebKitTestRunner for Qt.

A QElapsedTimer has been added to RunUntilConditionLoop in order
to measure how long the loop has been running. When the timer
is bigger or equal than the timeout, the loop ends even if the
condition is not met.

  • WebKitTestRunner/qt/TestControllerQt.cpp: (WTR::RunUntilConditionLoop::start): (WTR::RunUntilConditionLoop::run): (WTR::RunUntilConditionLoop::timerEvent): (WTR::TestController::platformRunUntil):
03:04 Changeset [71901] by bulach@chromium.org

2010-11-12 Marcus Bulach <bulach@chromium.org>

Not reviewed, Chromium test expectation update.

Updates test expectations for chromium following r71886
https://bugs.webkit.org/show_bug.cgi?id=49436

Temporarily disables editing/selection/context-menu-on-text.html until we fix test_shell.

  • platform/chromium/test_expectations.txt:
02:39 Changeset [71900] by commit-queue@webkit.org

2010-11-12 Ilya Sherman <isherman@chromium.org>

Reviewed by Eric Seidel.

Remove some trailing whitespace
https://bugs.webkit.org/show_bug.cgi?id=49433

  • platform/PopupMenuClient.h:
  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupContainer::show): (WebCore::PopupListBox::paintRow): (WebCore::PopupListBox::scrollToRevealRow):
  • platform/chromium/PopupMenuChromium.h:
  • platform/chromium/SearchPopupMenuChromium.cpp:
  • rendering/RenderMenuList.h: (WebCore::RenderMenuList::toRenderMenuList):
  • rendering/RenderTextControlSingleLine.h: (WebCore::toRenderTextControlSingleLine):

2010-11-12 Ilya Sherman <isherman@chromium.org>

Reviewed by Eric Seidel.

Remove some trailing whitespace
https://bugs.webkit.org/show_bug.cgi?id=49433

  • src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::createPopupMenu):
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::scrollRootLayerRect): (WebKit::WebViewImpl::invalidateRootLayerRect):
01:26 Changeset [71899] by rniwa@webkit.org

2010-11-12 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Csaba Osztrogonác.

[qt] script-clone tests added in r71895 fails on qt platform
https://bugs.webkit.org/show_bug.cgi?id=49429

Enabled fast/dom/script-clone-rerun-self.html and fast/dom/script-clone-rerun.html

  • platform/qt/Skipped:

2010-11-12 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Csaba Osztrogonác.

[qt] script-clone tests added in r71895 fails on qt platform
https://bugs.webkit.org/show_bug.cgi?id=49429

Fixed parseEndElement to call ScriptElement's executeScript as supposed to that of ScriptController.

  • dom/XMLDocumentParserQt.cpp: (WebCore::XMLDocumentParser::parseEndElement):
01:24 Changeset [71898] by morrita@google.com

2010-11-05 MORITA Hajime <morrita@google.com>

Reviewed by Kent Tamura.

Refactoring: Return values of TextCheckingHelper::paragraphAlignedRange should form a class.
https://bugs.webkit.org/show_bug.cgi?id=49053

Replaced paragraphAlignedRange() function call into
TextCheckingParagraph class. The class encapsulates a range of a
paragraph, and its relation within associated checking range.
Instance variables of the class are computed lazily. So we can save unnecessary
memory allocation and DOM tree traversal.

No new tests, no behavior change.

  • editing/Editor.cpp: (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): Replaced paragraphAlignedRange() call. (WebCore::Editor::changeBackToReplacedString): Replaced paragraphAlignedRange() call.
  • editing/TextCheckingHelper.cpp: (WebCore::expandToParagraphBoundary): (WebCore::TextCheckingParagraph::TextCheckingParagraph): (WebCore::TextCheckingParagraph::~TextCheckingParagraph): (WebCore::TextCheckingParagraph::expandRangeToNextEnd): (WebCore::TextCheckingParagraph::invalidateParagraphRangeValues): (WebCore::TextCheckingParagraph::rangeLength): (WebCore::TextCheckingParagraph::paragraphRange): (WebCore::TextCheckingParagraph::subrange): (WebCore::TextCheckingParagraph::offsetTo): (WebCore::TextCheckingParagraph::isEmpty): (WebCore::TextCheckingParagraph::offsetAsRange): (WebCore::TextCheckingParagraph::text): (WebCore::TextCheckingParagraph::checkingStart): (WebCore::TextCheckingParagraph::checkingEnd): (WebCore::TextCheckingParagraph::checkingLength): (WebCore::TextCheckingHelper::findFirstBadGrammar): Replaced paragraphAlignedRange() call. (WebCore::TextCheckingHelper::guessesForMisspelledOrUngrammaticalRange): Replaced paragraphAlignedRange() call.
  • editing/TextCheckingHelper.h: (WebCore::TextCheckingParagraph::textLength): (WebCore::TextCheckingParagraph::textSubstring): (WebCore::TextCheckingParagraph::textCharacters): (WebCore::TextCheckingParagraph::textCharAt): (WebCore::TextCheckingParagraph::checkingSubstring): (WebCore::TextCheckingParagraph::checkingRangeMatches): (WebCore::TextCheckingParagraph::isCheckingRangeCoveredBy): (WebCore::TextCheckingParagraph::checkingRangeCovers): (WebCore::TextCheckingParagraph::checkingRange): (WebCore::TextCheckingParagraph::isTextEmpty): (WebCore::TextCheckingParagraph::isRangeEmpty):

11/11/10:

23:58 Changeset [71897] by rniwa@webkit.org

2010-11-11 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed. Disable SVG tests added by r71895 because Qt has its own XML parser,
and it needs to be fixed separately.

  • platform/qt/Skipped:
23:39 Changeset [71896] by levin@chromium.org

check-webkit-style function detection doesn't handle templates with spaces.
https://bugs.webkit.org/show_bug.cgi?id=49427

Reviewed by Shinichiro Hamaji.

  • Scripts/webkitpy/style/checkers/cpp.py: Stripped out templates when finding the function name.
  • Scripts/webkitpy/style/checkers/cpp_unittest.py: Made the test have a template with a space.
23:21 Changeset [71895] by rniwa@webkit.org

2010-11-11 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

Script runs more than once after a clone
https://bugs.webkit.org/show_bug.cgi?id=48966

The bug was caused by cloneElementWithoutChildren's not propagating isEvaluated flag,
which indicates whether or not the script has already started, and the fact
neither HTMLScriptRunner nor XMLDocumentParser was setting isEvaluated flag to true.

Fixed the bug by making cloneElementWithoutChildren call a virtual cloneElementWithoutAttributesAndChildren,
and override it in HTMLScriptElement and SVGScriptElement to propagate isEvaluated flag,
and replacing direct access to ScriptController by a call to new ScriptElementData::executeScript,
which updates the isEvaluated flag properly.

See also: http://www.whatwg.org/specs/web-apps/current-work/#already-started

Tests: fast/dom/script-clone-rerun-self.html

fast/dom/script-clone-rerun.html
svg/dom/SVGScriptElement/script-clone-rerun-self.svg
svg/dom/SVGScriptElement/script-clone-rerun.svg

  • dom/Element.cpp: (WebCore::Element::cloneElementWithoutChildren): Calls cloneElementWithoutChildren. (WebCore::Element::cloneElementWithoutAttributesAndChildren): Extracted from cloneElementWithoutChildren.
  • dom/Element.h:
  • dom/ScriptElement.cpp: (WebCore::ScriptElementData::ScriptElementData): Added isEvaluated flag to the argument list. (WebCore::ScriptElementData::evaluateScript): Extracted from HTMLScriptRunner::executeScript. (WebCore::ScriptElementData::executeScript): Renamed evaluated to isEvaluated. (WebCore::ScriptElementData::ignoresLoadRequest): Renamed evaluated to isEvaluated.
  • dom/ScriptElement.h: Renamed evaluated to isEvaluated. (WebCore::ScriptElementData::isEvaluated): Added.
  • dom/XMLDocumentParserLibxml2.cpp: (WebCore::XMLDocumentParser::endElementNs): Calls ScriptElement::executeScript.
  • html/HTMLScriptElement.cpp: (WebCore::HTMLScriptElement::HTMLScriptElement): Added isEvaluated flag to the argument list. (WebCore::HTMLScriptElement::create): Calls the constructor with the isEvaluated flag set to false. (WebCore::HTMLScriptElement::cloneElementWithoutAttributesAndChildren): Propagates isEvaluated. (WebCore::HTMLScriptElement::executeScript): Added; calls ScriptElementData::executeScript.
  • html/HTMLScriptElement.h:
  • html/parser/HTMLScriptRunner.cpp: (WebCore::HTMLScriptRunner::executePendingScriptAndDispatchEvent): Added an assertion that was lost in extracting ScriptElementData::executeScript. (WebCore::HTMLScriptRunner::runScript): Calls ScriptElementData::executeScript.
  • html/parser/HTMLScriptRunner.h:
  • svg/SVGScriptElement.cpp: (WebCore::SVGScriptElement::SVGScriptElement): Added isEvaluated flag to the argument list. (WebCore::SVGScriptElement::create): Calls the constructor with the isEvaluated flag set to false. (WebCore::SVGScriptElement::cloneElementWithoutAttributesAndChildren): Propagates isEvaluated. (WebCore::SVGScriptElement::executeScript): Added; calls ScriptElementData::executeScript.
  • svg/SVGScriptElement.h:

2010-11-11 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

Script runs more than once after a clone
https://bugs.webkit.org/show_bug.cgi?id=48966

Added tests to ensure WebKit does not evaluate the script of a clone of
a script element that has already been evaluated (has already started).

See also: http://www.whatwg.org/specs/web-apps/current-work/#already-started

  • fast/dom/script-clone-rerun-expected.txt: Added.
  • fast/dom/script-clone-rerun-self-expected.txt: Added.
  • fast/dom/script-clone-rerun-self.html: Added.
  • fast/dom/script-clone-rerun.html: Added.
  • svg/dom/SVGScriptElement/script-clone-rerun-expected.txt: Added.
  • svg/dom/SVGScriptElement/script-clone-rerun-self-expected.txt: Added.
  • svg/dom/SVGScriptElement/script-clone-rerun-self.svg: Added.
  • svg/dom/SVGScriptElement/script-clone-rerun.svg: Added.
23:21 Changeset [71894] by commit-queue@webkit.org

2010-11-11 Ademar de Souza Reis Jr <ademar.reis@openbossa.org>

Reviewed by Shinichiro Hamaji.

Enable check-webkit-style on Qt files
https://bugs.webkit.org/show_bug.cgi?id=48322

Adding exception for _q_... private slots and
..._data() methods in tests

  • Scripts/webkitpy/style/checker.py: enable Qt dirs, add exceptions
  • Scripts/webkitpy/style/checker_unittest.py: improve unittests
23:06 Changeset [71893] by morrita@google.com

2010-11-11 MORITA Hajime <morrita@google.com>

Unreviewed another attempt to fx windows build.

  • src/WebBindings.cpp: (WebKit::makeStringArrayImpl):
22:51 Changeset [71892] by hamaji@chromium.org

2010-11-11 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Darin Adler.

REGRESSION: window.print in onload doesn't fire if there's an img
https://bugs.webkit.org/show_bug.cgi?id=48195

This issue was introduced in
https://bugs.webkit.org/show_bug.cgi?id=43658
This happens because FrameLoader::isLoading() is false while an
image is still loading. Now, window.print() happens after all
resources are loaded.

Also changed the name of a member variable as Darin suggested in Bug 43658.

Added a manual test as DRT doesn't support window.print() yet.

  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::DocumentLoader): (WebCore::DocumentLoader::updateLoading):
  • loader/DocumentLoader.h:
  • page/DOMWindow.cpp: (WebCore::DOMWindow::DOMWindow): (WebCore::DOMWindow::print): (WebCore::DOMWindow::finishedLoading):
  • page/DOMWindow.h:
22:46 Changeset [71891] by morrita@google.com

2010-11-11 MORITA Hajime <morrita@google.com>

Unreviewed attempt to fx windows build.

  • src/WebBindings.cpp: (WebKit::makeStringArrayImpl):
22:37 Changeset [71890] by levin@chromium.org

2010-11-11 David Levin <levin@chromium.org>

Reviewed by Shinichiro Hamaji.

check-webkit-style function detection doesn't work for templates and destructors.
https://bugs.webkit.org/show_bug.cgi?id=49425

  • Scripts/webkitpy/style/checkers/cpp.py: Changed regex for templates and destructors.
  • Scripts/webkitpy/style/checkers/cpp_unittest.py: Made the test hit this issue.
22:27 Changeset [71889] by mihaip@chromium.org

2010-11-11 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium rebaseline.

Rebaseline css2.1/t1204-order-01-d.html after r71882 (new Chromium
baselines match the updated mac one)

  • platform/chromium-linux/css2.1/t1204-order-01-d-expected.checksum:
  • platform/chromium-linux/css2.1/t1204-order-01-d-expected.png:
  • platform/chromium-mac/css2.1/t1204-order-01-d-expected.checksum: Added.
  • platform/chromium-mac/css2.1/t1204-order-01-d-expected.png: Added.
  • platform/chromium-win/css2.1/t1204-order-01-d-expected.checksum:
  • platform/chromium-win/css2.1/t1204-order-01-d-expected.png:
  • platform/chromium-win/css2.1/t1204-order-01-d-expected.txt:
22:20 Changeset [71888] by commit-queue@webkit.org

2010-11-11 Joone Hur <joone@kldp.org>

Reviewed by Antonio Gomes.

[GTK][DRT] Implement LayoutTestController::nodesFromRect
https://bugs.webkit.org/show_bug.cgi?id=46598

Unskip fast/dom/nodesFromRect-basic.html on Gtk+.

  • platform/gtk/Skipped:

2010-11-11 Joone Hur <joone@kldp.org>

Reviewed by Antonio Gomes.

[GTK][DRT] Implement LayoutTestController::nodesFromRect
https://bugs.webkit.org/show_bug.cgi?id=46598

Support nodesFromRect in DRT

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp: (DumpRenderTreeSupportGtk::nodesFromRect): Added.
  • WebCoreSupport/DumpRenderTreeSupportGtk.h:

2010-11-11 Joone Hur <joone@kldp.org>

Reviewed by Antonio Gomes.

[GTK][DRT] Implement LayoutTestController::nodesFromRect
https://bugs.webkit.org/show_bug.cgi?id=46598

Support nodesFromRect in DRT

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::nodesFromRect):
22:04 Changeset [71887] by commit-queue@webkit.org

2010-11-11 James Simonsen <simonjam@chromium.org>

Reviewed by Tony Chang.

[chromium] Support letter spacing and fix whitespace wrapping on linux

When lines wrapped on RTL text, the whitespace was inserted before
the first character on the new line instead of at the end of the
previous line. This has been fixed.

The missing cluster information needed for letter spacing was hidden in
harfbuzz's attributes struct.

https://bugs.webkit.org/show_bug.cgi?id=49405

  • platform/chromium-linux/fast/text/atsui-spacing-features-expected.checksum: Rebaselined.
  • platform/chromium-linux/fast/text/atsui-spacing-features-expected.png: Ditto.
  • platform/chromium-linux/fast/text/atsui-spacing-features-expected.txt: Ditto.

2010-11-11 James Simonsen <simonjam@chromium.org>

Reviewed by Tony Chang.

[chromium] Support letter spacing and fix whitespace wrapping on linux

When lines wrapped on RTL text, the whitespace was inserted before
the first character on the new line instead of at the end of the
previous line. This has been fixed.

The missing cluster information needed for letter spacing was hidden in
harfbuzz's attributes struct.

https://bugs.webkit.org/show_bug.cgi?id=49405

  • platform/graphics/chromium/FontLinux.cpp: (WebCore::TextRunWalker::letterSpacing): Added. (WebCore::TextRunWalker::isWordBreak): No need for isRTL. (WebCore::TextRunWalker::setPadding): Ditto. (WebCore::TextRunWalker::setGlyphXPositions): Support letter spacing. No whitespace before RTL text on new line. (WebCore::glyphIndexForXPositionInScriptRun): Support letter spacing.
22:02 Changeset [71886] by morrita@google.com

2010-11-11 MORITA Hajime <morrita@google.com>

Reviewed by Kent Tamura.

editing/selection/context-menu-on-text.html fails on chromium
https://bugs.webkit.org/show_bug.cgi?id=45898

  • platform/chromium/test_expectations.txt: Unskipped context-menu-on-text.html

2010-11-11 MORITA Hajime <morrita@google.com>

Reviewed by Kent Tamura.

editing/selection/context-menu-on-text.html fails on chromium
https://bugs.webkit.org/show_bug.cgi?id=45898

Added makeStringArray(), that is used by DumpRenderTree.

  • public/WebBindings.h:
  • src/WebBindings.cpp: (WebKit::makeStringArrayImpl): Added. (WebKit::WebBindings::makeStringArray): Added.

2010-11-11 MORITA Hajime <morrita@google.com>

Reviewed by Kent Tamura.

editing/selection/context-menu-on-text.html fails on chromium
https://bugs.webkit.org/show_bug.cgi?id=45898

Enhance Chromium's EventSender::contextClick() to return
array of menu strings. The implementation incomplete because
Although actual context menu is implemented by the browser,
it reflects editability of underlying context thus makes
context-menu-on-text.html passed.

  • DumpRenderTree/chromium/EventSender.cpp: (makeMenuItemStringsFor): Added. (EventSender::contextClick): Now returns array of menu strings.
  • DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::showContextMenu): Now storing given WebContextMenuData object. (WebViewHost::clearContextMenuData): Added. (WebViewHost::lastContextMenuData): Added.
  • DumpRenderTree/chromium/WebViewHost.h:
21:38 Changeset [71885] by commit-queue@webkit.org

2010-11-11 Kavita Kanetkar <kkanetkar@chromium.org>

Reviewed by Dumitru Daniliuc.

FileSystem: Fix a link error for non-chromium WebKit build
https://bugs.webkit.org/show_bug.cgi?id=49296

  • WebCore.xcodeproj/project.pbxproj:
  • inspector/InspectorFileSystemAgent.cpp: (WebCore::InspectorFileSystemAgentCallbacks::didOpenFileSystem): (WebCore::InspectorFileSystemAgentCallbacks::didReadDirectoryEntry): (WebCore::InspectorFileSystemAgentCallbacks::didReadDirectoryEntries): (WebCore::InspectorFileSystemAgentCallbacks::didCreateFileWriter): (WebCore::InspectorFileSystemAgentCallbacks::didFail): (WebCore::InspectorFileSystemAgent::revealFolderInOS):
21:17 Changeset [71884] by japhet@chromium.org

2010-11-11 Nate Chapin <japhet@chromium.org>

Reviewed by Antti Koivisto.

Test update for https://bugs.webkit.org/show_bug.cgi?id=49351,
the timing of willSendRequest() calls will be slightly different.

  • platform/mac/security/block-test-expected.txt:

2010-11-11 Nate Chapin <japhet@chromium.org>

Reviewed by Antti Koivisto.

Cleanup after http://trac.webkit.org/changeset/71562, namely:
Make deferred request handle simpler.
Don't perform callbacks associated with network load starting
(e.g., willSendRequest) until the load is in fact sent to the network.
Make ResourceLoadScheduler a friend of ResourceLoader and make
ResourceLoader::start() protected to try to ensure loads actually
go through the scheduler.
https://bugs.webkit.org/show_bug.cgi?id=49351

Behavior should be covered by existing tests.

  • loader/NetscapePlugInStreamLoader.cpp: (WebCore::NetscapePlugInStreamLoader::create):
  • loader/ResourceLoadScheduler.cpp: (WebCore::ResourceLoadScheduler::servePendingRequests):
  • loader/ResourceLoadScheduler.h: (WebCore::ResourceLoadScheduler::HostInformation::limitRequests):
  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::init): (WebCore::ResourceLoader::start): (WebCore::ResourceLoader::setDefersLoading): (WebCore::ResourceLoader::didCancel):
  • loader/ResourceLoader.h: (WebCore::ResourceLoader::reachedTerminalState): (WebCore::ResourceLoader::request):
  • loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::create):
  • loader/loader.cpp: (WebCore::Loader::load): (WebCore::Loader::willSendRequest):
  • loader/loader.h:
20:55 Changeset [71883] by tonyg@chromium.org

2010-11-11 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Nate Chapin.

[chromium] Convert WebPerformance doubles to seconds
https://bugs.webkit.org/show_bug.cgi?id=49232

This makes them suitable for passing to Time::FromDoubleT().

  • src/WebPerformance.cpp: (WebKit::millisecondsToSeconds): (WebKit::WebPerformance::navigationStart): (WebKit::WebPerformance::unloadEventEnd): (WebKit::WebPerformance::redirectStart): (WebKit::WebPerformance::redirectEnd): (WebKit::WebPerformance::fetchStart): (WebKit::WebPerformance::domainLookupStart): (WebKit::WebPerformance::domainLookupEnd): (WebKit::WebPerformance::connectStart): (WebKit::WebPerformance::connectEnd): (WebKit::WebPerformance::requestStart): (WebKit::WebPerformance::requestEnd): (WebKit::WebPerformance::responseStart): (WebKit::WebPerformance::responseEnd): (WebKit::WebPerformance::loadEventStart): (WebKit::WebPerformance::loadEventEnd):
20:35 Changeset [71882] by carol.szabo@nokia.com

2010-11-11 Carol Szabo <carol.szabo@nokia.com>

Reviewed by Kent Tamura.

css2:order of counters in out-of flow content
https://bugs.webkit.org/show_bug.cgi?id=32412

  • fast/css/content: Added.
  • fast/css/content/content-none-expected.txt: Added.
  • fast/css/content/content-none.html: Added.
  • fast/css/content/content-normal-expected.txt: Added.
  • fast/css/content/content-normal.html: Added. Added to provide portable tests for the "content" CSS property.
  • platform/mac/css2.1/t1204-order-01-d-expected.checksum:
  • platform/mac/css2.1/t1204-order-01-d-expected.png:
  • platform/mac/css2.1/t1204-order-01-d-expected.txt: Changed because the existing content was bad, but matching the existing bug that this patch fixes.

2010-11-11 Carol Szabo <carol.szabo@nokia.com>

Reviewed by Kent Tamura.

css2:order of counters in out-of flow content
https://bugs.webkit.org/show_bug.cgi?id=32412

Tests: fast/css/content/content-none.html

fast/css/content/content-normal.html

  • css/CSSParser.cpp: (WebCore::CSSParser::parseContent): Added support for none, normal, open-quote, no-open-quote, etc. identifiers in terms of parsing only, as this has effect on the evaluation of counters. No further implementation needed for none and normal, the others are parsed but do not work as expected.
20:16 Changeset [71881] by chang.shu@nokia.com

2010-11-11 Chang Shu <chang.shu@nokia.com>

Reviewed by Antonio Gomes.

[GTK] Unskip tests that are passing now.
fast/events/spatial-navigation/snav-input.html
fast/events/spatial-navigation/snav-textarea.html
https://bugs.webkit.org/show_bug.cgi?id=49056

  • platform/gtk/Skipped:

2010-11-11 Chang Shu <chang.shu@nokia.com>

Reviewed by Antonio Gomes.

[GTK] Replace "MoveForward"/"MoveBackward" with "MoveRight"/"MoveLeft"
to make spatial navigation work on input/textarea.
https://bugs.webkit.org/show_bug.cgi?id=49056

  • WebCoreSupport/EditorClientGtk.cpp: (WebKit::moveCursorCallback):
19:56 Changeset [71880] by commit-queue@webkit.org

2010-11-11 Julie-Jeongeun-Kim <jiyuluna@gmail.com>

Reviewed by Kent Tamura.

SelectionStart, selectionEnd properties return wrong values when the selection is in a read-only input or textarea element
https://bugs.webkit.org/show_bug.cgi?id=25444

  • fast/forms/selection-start-end-readonly-expected.txt: Added.
  • fast/forms/selection-start-end-readonly.html: Added.

2010-11-11 Julie-Jeongeun-Kim <jiyuluna@gmail.com>

Reviewed by Kent Tamura.

SelectionStart, selectionEnd properties return wrong values when the selection is in a read-only input or textarea element
https://bugs.webkit.org/show_bug.cgi?id=25444

'rootEditableElement()' is checked on RenderTextControl::indexForVisiblePosition.
It means that just editable elements can get selection information.
ReadOnly element is not editable element. So, it just returns and can't get correct selection information.
INPUT and TEXTAREA elements can be read-only but 'indexForVisiblePosition' doesn't accept them.
So, Selectable elements, INPUT and TEXTAREA, checking is added for that case.
Even if they are read-only, they are selectable.

new tests:fast/forms/selection-start-end-readonly.html

  • html/HTMLInputElement.idl:
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::isSelectableElement): (WebCore::RenderTextControl::indexForVisiblePosition):
  • rendering/RenderTextControl.h:
19:07 Changeset [71879] by abarth@webkit.org

2010-11-11 Adam Barth <abarth@webkit.org>

Reviewed by David Levin.

Add some RefPtrs to be on the safe side
https://bugs.webkit.org/show_bug.cgi?id=49301

Hopefully no behavior change.

  • html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processIsindexStartTagForInBody):
19:06 Changeset [71878] by barraclough@apple.com

Bug 49420 - Clean up syntax/reference error throw.

Reviewed by Oliver Hunt.

Some errors detected at compile time are thrown at runtime. We currently do so using a op_new_error/op_throw bytecode pair.
This is not ideal. op_throw is used for explicit user throw statements, and has different requirements in terms or meta data
attached to the exception (controlled by the explicitThrow parameter passed to Interpreter::throwException). To work around
this, op_new_error has to add the meta data at an early stage, which is unlike other VM exceptions being raised.

We can simplify this and bring into line with other exception behaviour by changing new_error from just allocating an
Exception instance to also throwing it – but as a regular VM throw, correctly passing explicitThrow as false.

(JSC::CodeBlock::dump):
(JSC::CodeBlock::expressionRangeForBytecodeOffset):

  • bytecode/Opcode.h:
  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitThrowReferenceError):
(JSC::BytecodeGenerator::emitThrowSyntaxError):
(JSC::BytecodeGenerator::emitThrowExpressionTooDeepException):

  • bytecompiler/BytecodeGenerator.h:

(JSC::BytecodeGenerator::emitNodeInConditionContext):

  • bytecompiler/NodesCodegen.cpp:

(JSC::ThrowableExpressionData::emitThrowReferenceError):
(JSC::ThrowableExpressionData::emitThrowSyntaxError):
(JSC::RegExpNode::emitBytecode):
(JSC::PostfixErrorNode::emitBytecode):
(JSC::PrefixErrorNode::emitBytecode):
(JSC::AssignErrorNode::emitBytecode):
(JSC::ForInNode::emitBytecode):
(JSC::ContinueNode::emitBytecode):
(JSC::BreakNode::emitBytecode):
(JSC::ReturnNode::emitBytecode):
(JSC::LabelNode::emitBytecode):

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

  • jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):

  • jit/JIT.h:
  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_throw_reference_error):
(JSC::JIT::emit_op_throw_syntax_error):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_throw_reference_error):
(JSC::JIT::emit_op_throw_syntax_error):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • jit/JITStubs.h:
  • parser/Nodes.h:
18:49 Changeset [71877] by crogers@google.com

2010-11-11 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

Fix Accelerate.framework issues in VectorMath 32-bit ppc & i386 vs. other architectures (64-bit, ARM, etc.).
On the Mac we use the highly optimized versions in Accelerate.framework
In 32-bit mode (ppc or i386) <Accelerate/Accelerate.h> includes <vecLib/vDSP_translate.h> which defines macros
of the same name as our namespaced function names, so we must handle this case differently.
Other architectures (64bit, ARM, etc.) do not include this header file.

https://bugs.webkit.org/show_bug.cgi?id=49112

No new tests since audio API is not yet implemented.

  • platform/audio/VectorMath.cpp: (WebCore::VectorMath::vsmul): (WebCore::VectorMath::vadd):
18:30 Changeset [71876] by hyatt@apple.com

Fix layout test since it progressed.

18:28 Changeset [71875] by mihaip@chromium.org

2010-11-11 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium rebaseline.

Missed a chromium-mac baseline in r71869 (for r71851).

  • platform/chromium-mac/fast/repaint/box-shadow-h-expected.checksum: Added.
  • platform/chromium-mac/fast/repaint/box-shadow-h-expected.png: Added.
18:20 Changeset [71874] by mihaip@chromium.org

2010-11-11 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium rebaseline.

Restore baseline that r71870 deleted, Chromium Windows and Linux still
have the old behavior.

  • platform/chromium-win/fast/text/justification-padding-mid-word-expected.txt: Added.
17:48 Changeset [71873] by dpranke@chromium.org

2010-11-11 Dirk Pranke <dpranke@chromium.org>

Unreviewed, build fix.

fix build breakage caused by fix for bug 49380 (r71858).

config_standalone needs to ensure that the packages it needs are
in sys.path.

https://bugs.webkit.org/show_bug.cgi?id=49419

  • Scripts/webkitpy/layout_tests/port/config_standalone.py:
17:33 Changeset [71872] by andersca@apple.com

Add didReceiveResponse and didReceiveData to the download client
https://bugs.webkit.org/show_bug.cgi?id=49418

Reviewed by Darin Adler.

  • UIProcess/API/C/WKContext.h:

Add didReceiveResponse and didReceiveData to WKContextDownloadClient.

  • UIProcess/Downloads/DownloadProxy.cpp:

(WebKit::DownloadProxy::didReceiveResponse):
(WebKit::DownloadProxy::didReceiveData):
Call WebDownloadClient member functions.

  • UIProcess/Downloads/DownloadProxy.messages.in:

Add DidReceiveResponse and DidReceiveData messages.

  • UIProcess/WebDownloadClient.cpp:

(WebKit::WebDownloadClient::didReceiveResponse):
(WebKit::WebDownloadClient::didReceiveData):
Call client functions.

  • WebKit2.xcodeproj/project.pbxproj:

Let Xcode update the file.

  • WebProcess/Downloads/Download.cpp:

(WebKit::Download::didReceiveResponse):
(WebKit::Download::didReceiveData):
Send messages.

  • WebProcess/Downloads/mac/DownloadMac.mm:

(WebKit::Download::start):
Set deletesFileUponFailure to NO.

(-[WKDownloadAsDelegate download:didReceiveResponse:]):
Call didReceiveResponse.

17:25 Changeset [71871] by mihaip@chromium.org

2010-11-11 Mihai Parparita <mihaip@chromium.org>

Unreviewed, fix bug number.

  • platform/chromium/test_expectations.txt:
17:21 Changeset [71870] by mitz@apple.com

<rdar://problem/8657116> fast/text/justification-padding-mid-word.html fails on Windows
https://bugs.webkit.org/show_bug.cgi?id=49378

Reviewed by Darin Adler.

WebCore:

  • platform/graphics/win/UniscribeController.cpp:

(WebCore::UniscribeController::shapeAndPlaceItem): For all characters that need to be treated
as zero-width spaces, substitute the space glyph with zero advance. Apply justification padding
and word spacing only at characters treated as (non-zero-width) spaces.

LayoutTests:

  • platform/win/fast/text/justification-padding-mid-word-expected.txt: Removed Windows-specific

expected failure.

17:20 Changeset [71869] by mihaip@chromium.org

2010-11-11 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium rebaseline.

Update fast/repaint baselines after r71851. Add expected failure
for fast/table/colspanMinWidth-vertical.html, which needs rebaselining
upstream for the mac port too.

  • platform/chromium-linux/fast/repaint/japanese-rl-selection-clear-expected.checksum: Added.
  • platform/chromium-linux/fast/repaint/japanese-rl-selection-clear-expected.png: Added.
  • platform/chromium-linux/fast/repaint/japanese-rl-selection-clear-expected.txt: Added.
  • platform/chromium-linux/fast/repaint/japanese-rl-selection-repaint-expected.checksum: Added.
  • platform/chromium-linux/fast/repaint/japanese-rl-selection-repaint-expected.png: Added.
  • platform/chromium-linux/fast/repaint/japanese-rl-selection-repaint-expected.txt: Added.
  • platform/chromium-linux/fast/repaint/selection-rl-expected.checksum:
  • platform/chromium-linux/fast/repaint/selection-rl-expected.png:
  • platform/chromium-mac/fast/repaint/box-shadow-v-expected.checksum: Added.
  • platform/chromium-mac/fast/repaint/box-shadow-v-expected.png: Added.
  • platform/chromium-mac/fast/repaint/flexible-box-overflow-expected.checksum: Added.
  • platform/chromium-mac/fast/repaint/flexible-box-overflow-expected.png: Added.
  • platform/chromium-mac/fast/repaint/flexible-box-overflow-horizontal-expected.checksum: Added.
  • platform/chromium-mac/fast/repaint/flexible-box-overflow-horizontal-expected.png: Added.
  • platform/chromium-mac/fast/repaint/focus-layers-expected.checksum: Added.
  • platform/chromium-mac/fast/repaint/focus-layers-expected.png: Added.
  • platform/chromium-mac/fast/repaint/inline-block-overflow-expected.checksum: Added.
  • platform/chromium-mac/fast/repaint/inline-block-overflow-expected.png: Added.
  • platform/chromium-mac/fast/repaint/japanese-rl-selection-clear-expected.checksum: Added.
  • platform/chromium-mac/fast/repaint/japanese-rl-selection-clear-expected.png: Added.
  • platform/chromium-mac/fast/repaint/japanese-rl-selection-repaint-expected.checksum: Added.
  • platform/chromium-mac/fast/repaint/japanese-rl-selection-repaint-expected.png: Added.
  • platform/chromium-mac/fast/repaint/layer-child-outline-expected.checksum: Added.
  • platform/chromium-mac/fast/repaint/layer-child-outline-expected.png: Added.
  • platform/chromium-mac/fast/repaint/layer-outline-expected.checksum: Added.
  • platform/chromium-mac/fast/repaint/layer-outline-expected.png: Added.
  • platform/chromium-mac/fast/repaint/layer-outline-horizontal-expected.checksum: Added.
  • platform/chromium-mac/fast/repaint/layer-outline-horizontal-expected.png: Added.
  • platform/chromium-mac/fast/repaint/list-marker-expected.checksum: Added.
  • platform/chromium-mac/fast/repaint/list-marker-expected.png: Added.
  • platform/chromium-mac/fast/repaint/selection-rl-expected.checksum:
  • platform/chromium-mac/fast/repaint/selection-rl-expected.png:
  • platform/chromium-mac/fast/repaint/text-shadow-expected.checksum: Added.
  • platform/chromium-mac/fast/repaint/text-shadow-expected.png: Added.
  • platform/chromium-mac/fast/repaint/text-shadow-horizontal-expected.checksum: Added.
  • platform/chromium-mac/fast/repaint/text-shadow-horizontal-expected.png: Added.
  • platform/chromium-win/fast/repaint/japanese-rl-selection-clear-expected.checksum: Added.
  • platform/chromium-win/fast/repaint/japanese-rl-selection-clear-expected.png: Added.
  • platform/chromium-win/fast/repaint/japanese-rl-selection-clear-expected.txt: Added.
  • platform/chromium-win/fast/repaint/japanese-rl-selection-repaint-expected.checksum: Added.
  • platform/chromium-win/fast/repaint/japanese-rl-selection-repaint-expected.png: Added.
  • platform/chromium-win/fast/repaint/japanese-rl-selection-repaint-expected.txt: Added.
  • platform/chromium-win/fast/repaint/selection-rl-expected.checksum:
  • platform/chromium-win/fast/repaint/selection-rl-expected.png:
  • platform/chromium/test_expectations.txt:
17:03 Changeset [71868] by andersca@apple.com

Add an argument coder for ResourceResponse.
https://bugs.webkit.org/show_bug.cgi?id=49415

Reviewed by Sam Weinig.

  • Shared/WebCoreArgumentCoders.h:
  • Shared/gtk/WebCoreArgumentCodersGtk.cpp:

(CoreIPC::encodeResourceResponse):
(CoreIPC::decodeResourceResponse):

  • Shared/mac/WebCoreArgumentCodersMac.mm:

(CoreIPC::encodeResourceResponse):
(CoreIPC::decodeResourceResponse):

  • Shared/qt/WebCoreArgumentCodersQt.cpp:

(CoreIPC::encodeResourceResponse):
(CoreIPC::decodeResourceResponse):

  • Shared/win/WebCoreArgumentCodersWin.cpp:

(CoreIPC::encodeResourceResponse):
(CoreIPC::decodeResourceResponse):

17:01 Changeset [71867] by darin@apple.com

2010-11-11 Darin Adler <darin@apple.com>

Reviewed by Sam Weinig.

Harden some string functions against large lengths
https://bugs.webkit.org/show_bug.cgi?id=49293

  • wtf/text/StringImpl.cpp: (WTF::StringImpl::create): Fix incorrect use of PassRefPtr. Check for strlen results that are too large for StringImpl. (WTF::StringImpl::lower): Check for lengths that are too large for int32_t. (WTF::StringImpl::upper): Fix incorrect use of PassRefPtr. Check for lengths that are too large for int32_t. (WTF::StringImpl::secure): Fix incorect use of PassRefPtr. Use unsigned rather than int and int32_t so we can handle any length. (WTF::StringImpl::foldCase): Fix incorrect use of PassRefPtr. Check for lengths that are too large for int32_t. (WTF::StringImpl::find): Check for strlen results that are too large for StringImpl. (WTF::StringImpl::findIgnoringCase): Ditto. (WTF::StringImpl::replace): Fix incorrect use of PassRefPtr. (WTF::StringImpl::createWithTerminatingNullCharacter): Check before incrementing length.

2010-11-11 Darin Adler <darin@apple.com>

Reviewed by Sam Weinig.

Harden some string functions against large lengths
https://bugs.webkit.org/show_bug.cgi?id=49293

  • rendering/RenderText.cpp: (WebCore::makeCapitalized): Check before incrementing length.
16:50 Changeset [71866] by rniwa@webkit.org

2010-11-11 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed build fix for r71587.

  • WebKit2.xcodeproj/project.pbxproj: No longer uses absolute path.
16:33 Changeset [71865] by ossy@webkit.org

[Qt] Unreviewed WebKit2 buildfix after r71587.

  • UIProcess/qt/WebInspectorProxyQt.cpp:
  • WebKit2.pro:
16:28 Changeset [71864] by bweinstein@apple.com

More Windows build fixing. Change another #import to a #include, and remove an unneeded
namespace.

  • UIProcess/win/WebInspectorProxyWin.cpp:
  • WebProcess/WebPage/win/WebInspectorWin.cpp:
16:19 Changeset [71863] by bfulgham@webkit.org

Windows [Cairo] build fix. Unreviewed.

Provide stubs for two BackingStore methods.

  • Shared/cairo/BackingStoreCairo.cpp:

(WebKit::BackingStore::createFlippedGraphicsContext):
(WebKit::BackingStore::paint):

16:17 Changeset [71862] by bweinstein@apple.com

Windows Build Fix. Change #imports to #includes.

  • UIProcess/win/WebInspectorProxyWin.cpp:
16:02 Changeset [71861] by zmo@google.com

2010-11-10 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

bufferData/bufferSubData should not crash with null data input
https://bugs.webkit.org/show_bug.cgi?id=49350

  • html/canvas/WebGLRenderingContext.cpp: return early if input data is null. (WebCore::WebGLRenderingContext::bufferData): (WebCore::WebGLRenderingContext::bufferSubData):

2010-11-10 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

bufferData/bufferSubData should not crash with null data input
https://bugs.webkit.org/show_bug.cgi?id=49350

  • fast/canvas/webgl/buffer-data-array-buffer-expected.txt:
  • fast/canvas/webgl/buffer-data-array-buffer.html: test the null data input cases.
15:55 Changeset [71860] by zmo@google.com

2010-11-11 Zhenyao Mo <zmo@google.com>

Unreviewed, build fix, update test results.

  • fast/canvas/webgl/texture-transparent-pixels-initialized-expected.txt:
15:52 Changeset [71859] by jhoneycutt@apple.com

Add a flaky test to the Windows skipped list.

  • platform/win/Skipped:
15:51 Changeset [71858] by dpranke@chromium.org

2010-11-11 Dirk Pranke <dpranke@chromium.org>

Reviewed by Adam Roben.

Fix NRWT to respect set-webkit-configuration again :(

This change fixes a typo in config.py that was causing the wrong
value to be read initially and us never actually looking into
the filesystem to get the default configuration.

  • Scripts/webkitpy/layout_tests/port/config.py:
  • Scripts/webkitpy/layout_tests/port/config_standalone.py:
  • Scripts/webkitpy/layout_tests/port/config_unittest.py:
15:43 Changeset [71857] by timothy@apple.com

Create and load the Web Inspector page.

https://webkit.org/b/49207

Reviewed by Anders Carlsson.

  • UIProcess/WebInspectorProxy.cpp:

(WebKit::WebInspectorProxy::createInspectorPage): Added. Call platformCreateInspectorPage and then
call WebPageProxy::loadURL with inspectorPageURL.
(WebKit::WebInspectorProxy::didLoadInspectorPage): Added stub.

  • UIProcess/WebInspectorProxy.h:
  • UIProcess/WebInspectorProxy.messages.in: Added.
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didReceiveMessage): Call WebInspectorProxy::didReceiveWebInspectorProxyMessage.
(WebKit::WebPageProxy::didReceiveSyncMessage): Call WebInspectorProxy::didReceiveSyncWebInspectorProxyMessage.

  • UIProcess/WebPageProxy.h: Made creationParameters public so WebInspectorProxy can use it.
  • UIProcess/mac/WebInspectorProxyMac.mm:

(WebKit::WebInspectorProxy::platformCreateInspectorPage): Make a WkView and return the WebPageProxy.
(WebKit::WebInspectorProxy::inspectorPageURL): Return the file URL for the inspector.html file.

  • UIProcess/qt/WebInspectorProxyQt.cpp:

(WebKit::WebInspectorProxy::platformCreateInspectorPage): Added stub.
(WebKit::WebInspectorProxy::inspectorPageURL): Ditto.

  • UIProcess/win/WebInspectorProxyWin.cpp:

(WebKit::WebInspectorProxy::platformCreateInspectorPage): Added stub.
(WebKit::WebInspectorProxy::inspectorPageURL): Ditto.

  • WebProcess/WebCoreSupport/WebInspectorClient.cpp:

(WebKit::WebInspectorClient::openInspectorFrontend): Call WebInspector::createInspectorPage and set up the WebInspectorFrontendClient.
(WebKit::WebInspectorClient::sendMessageToFrontend): Call doDispatchMessageOnFrontendPage in the base class.

  • WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp:

(WebKit::WebInspectorFrontendClient::frontendLoaded): Call WebInspector::didLoadInspectorPage.
(WebKit::WebInspectorFrontendClient::localizedStringsURL): Call WebInspector::localizedStringsURL.

  • WebProcess/WebCoreSupport/WebInspectorFrontendClient.h:
  • WebProcess/WebPage/WebInspector.cpp:

(WebKit::WebInspector::WebInspector):
(WebKit::WebInspector::createInspectorPage): Send a sync WebInspectorProxy::CreateInspectorPage message and set up
the WebPage using the result page ID.
(WebKit::WebInspector::didLoadInspectorPage): Send a WebInspectorProxy::DidLoadInspectorPage message.

  • WebProcess/WebPage/WebInspector.h:

(WebKit::WebInspector::inspectorPage): Added.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::didReceiveMessage): Call WebInspector::didReceiveWebInspectorMessage.

  • WebProcess/WebPage/mac/WebInspectorMac.mm:

(WebKit::WebInspector::localizedStringsURL): Return the file URL for the localizedStrings.js file.

  • WebProcess/WebPage/qt/WebInspectorQt.cpp:

(WebKit::WebInspector::localizedStringsURL): Added stub.

  • WebProcess/WebPage/win/WebInspectorWin.cpp:

(WebKit::WebInspector::localizedStringsURL): Added stub.

  • DerivedSources.make: Added WebInspectorProxy.messages.in.
  • DerivedSources.pro: Ditto.
  • WebKit2.pro: Added new files.
  • WebKit2.xcodeproj/project.pbxproj: Ditto.
  • win/WebKit2.vcproj: Ditto.
15:26 Changeset [71856] by eric@webkit.org

2010-11-11 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Split out Bug, Attachment and CommitterValidator from bugzilla.py
https://bugs.webkit.org/show_bug.cgi?id=49403

CommitterValidator really had nothing to do with bugzilla.py.
I've put it next to committers.py for now since its rather tied to that file.

  • Scripts/webkitpy/common/config/committervalidator.py: Added.
  • Scripts/webkitpy/common/config/committervalidator_unittest.py: Added.
  • Scripts/webkitpy/common/net/bugzilla/init.py:
  • Scripts/webkitpy/common/net/bugzilla/attachment.py: Added.
  • Scripts/webkitpy/common/net/bugzilla/bug.py: Added.
  • Scripts/webkitpy/common/net/bugzilla/bug_unittest.py: Added.
  • Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
  • Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
  • Scripts/webkitpy/tool/bot/feeders.py:
  • Scripts/webkitpy/tool/commands/queues.py:
15:04 Changeset [71855] by zmo@google.com

2010-11-10 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Implement UNPACK_COLORSPACE_CONVERSION_WEBGL
https://bugs.webkit.org/show_bug.cgi?id=47196

This is the first patch for this bug. We add constants and methods, but haven't hooked it up with texture uploading yet. Also, in order to check in constants.html, we need to remove out-dated constants, and update affected tests correspondingly.

Test: fast/canvas/webgl/constants.html

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::WebGLRenderingContext): Move init code to initializeNewContext. (WebCore::WebGLRenderingContext::initializeNewContext): Ditto. (WebCore::WebGLRenderingContext::getParameter): Implement UNPACK_COLORSPACE_CONVERSION_WEBGL. (WebCore::WebGLRenderingContext::pixelStorei): Ditto.
  • html/canvas/WebGLRenderingContext.h: Add a member to track UNPACK_COLORSPACE_CONVERSION_WEBGL setting.
  • html/canvas/WebGLRenderingContext.idl: Update constants.
  • platform/graphics/GraphicsContext3D.h: Update constants.

2010-11-10 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Implement UNPACK_COLORSPACE_CONVERSION_WEBGL
https://bugs.webkit.org/show_bug.cgi?id=47196

This is the first patch for this bug. We add constants and methods, but haven't hooked it up with texture uploading yet. Also, in order to check in constants.html, we need to remove out-dated constants, and update affected tests correspondingly.

  • fast/canvas/webgl/constants-expected.txt: Added.
  • fast/canvas/webgl/constants.html: Added.
  • fast/canvas/webgl/copy-tex-image-and-sub-image-2d-expected.txt:
  • fast/canvas/webgl/copy-tex-image-and-sub-image-2d.html: Update due to removal of TRUE/FALSE.
  • fast/canvas/webgl/texture-transparent-pixels-initialized-expected.txt:
  • fast/canvas/webgl/texture-transparent-pixels-initialized.html: Ditto.
  • fast/canvas/webgl/webgl-specific-expected.txt:
  • fast/canvas/webgl/webgl-specific.html: Add test cases for UNPACK_COLORSPACE_CONVERSION_WEBGL.
14:52 Changeset [71854] by dpranke@chromium.org

2010-11-11 Dirk Pranke <dpranke@chromium.org>

Reviewed by Eric Seidel.

fix missing 'pid' argument for http lockfile checking on win32
https://bugs.webkit.org/show_bug.cgi?id=49363

  • Scripts/webkitpy/common/system/executive.py:
14:43 Changeset [71853] by cmarrin@apple.com

2010-11-11 Chris Marrin <cmarrin@apple.com>

Reviewed by James Robinson.

Add multisampling support to DrawingBuffer.
https://bugs.webkit.org/show_bug.cgi?id=49206

Added support for the GL_ANGLE_framebuffer_blit and GL_ANGLE_framebuffer_multisample
extensions to Extensions3D. Then I use these to add multisample support to DrawingBuffer.

This re-lands changes rolled out by http://trac.webkit.org/changeset/71839. It includes
the change from http://trac.webkit.org/changeset/71831 and additional changes to
DrawingBufferChromium.cpp which cause the broken canvas tests to pass.

  • platform/graphics/Extensions3D.h:
  • platform/graphics/chromium/DrawingBufferChromium.cpp: (WebCore::DrawingBuffer::DrawingBuffer): (WebCore::DrawingBuffer::~DrawingBuffer): (WebCore::DrawingBuffer::publishToPlatformLayer): (WebCore::DrawingBuffer::didReset): (WebCore::DrawingBuffer::platformColorBuffer):
  • platform/graphics/chromium/Extensions3DChromium.h: (WebCore::Extensions3DChromium::blitFramebuffer): (WebCore::Extensions3DChromium::renderbufferStorageMultisample):
  • platform/graphics/gpu/DrawingBuffer.cpp: (WebCore::DrawingBuffer::create): (WebCore::DrawingBuffer::clear): (WebCore::DrawingBuffer::reset): (WebCore::DrawingBuffer::commit): (WebCore::DrawingBuffer::bind):
  • platform/graphics/gpu/DrawingBuffer.h: (WebCore::DrawingBuffer::multisample):
  • platform/graphics/gpu/mac/DrawingBufferMac.mm: (WebCore::DrawingBuffer::DrawingBuffer): (WebCore::DrawingBuffer::didReset): (WebCore::DrawingBuffer::platformColorBuffer):
  • platform/graphics/opengl/Extensions3DOpenGL.cpp: (WebCore::Extensions3DOpenGL::supports): (WebCore::Extensions3DOpenGL::blitFramebuffer): (WebCore::Extensions3DOpenGL::renderbufferStorageMultisample):
  • platform/graphics/opengl/Extensions3DOpenGL.h:
  • platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::ImageBuffer::draw):
14:32 Changeset [71852] by mihaip@chromium.org

2010-11-11 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium expectation update:

  • fast/selectors/001.html is flaky under release too
  • svg/animations/animate-text-nested-transforms.html is flaky

DRT:

  • Add more crashy/flaky media tests
  • Add flaky SVG tests
  • fast/selectors/001.html is flaky for all platforms
  • platform/chromium/drt_expectations.txt:
  • platform/chromium/test_expectations.txt:
14:17 Changeset [71851] by hyatt@apple.com

https://bugs.webkit.org/show_bug.cgi?id=48664

Reviewed by Simon Fraser.

Make repaint invalidation work with flipped blocks ("rl" and "bt" writing modes).

This patch disables the layout state for flipped blocks, since the paint offset isn't right.

Bugs in the overflow sides for lines have been fixed. before/AfterSideVisible/LayoutOverflowForLine
now respect flipping (and don't incorrectly change sides). This is a very confusing aspect of
the overflow stuff (and at some point we should consider renaming top/left/right/bottom since they
aren't physical).

offsetFromContainer and mapLocalToContainer remain physical and refer to the top left offset.
This means at every step up you convert to the correct physical coordinate. It also means these
functions will be unreliable during layout for flipped blocks. At first glance, this seems to be
more or less ok.

computeRectForRepaint now delays flipping conversions until you cross a writing-mode boundary. This
allows for documents to be fully flipped and repaint during layout can still be reliable. This is
critical for incremental line layout repainting.

Added new tests in fast/repaint and also rebaselined the tests in that directory because I'm tired
of all the stale results and failures.

WebCore:

  • editing/SelectionController.cpp:

(WebCore::SelectionController::absoluteBoundsForLocalRect):
(WebCore::SelectionController::paintCaret):

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::selectionRect):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::layoutOnlyPositionedObjects):
(WebCore::RenderBlock::paintSelection):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::beforeSideVisibleOverflowForLine):
(WebCore::RenderBlock::afterSideVisibleOverflowForLine):
(WebCore::RenderBlock::beforeSideLayoutOverflowForLine):
(WebCore::RenderBlock::afterSideLayoutOverflowForLine):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::layout):
(WebCore::RenderBox::mapLocalToContainer):
(WebCore::RenderBox::offsetFromContainer):
(WebCore::RenderBox::clippedOverflowRectForRepaint):
(WebCore::RenderBox::computeRectForRepaint):
(WebCore::RenderBox::flipForWritingMode):
(WebCore::RenderBox::locationOffsetIncludingFlipping):

  • rendering/RenderBox.h:
  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutBlock):

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::clippedOverflowRectForRepaint):

  • rendering/RenderSlider.cpp:

(WebCore::RenderSlider::layout):

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::layout):

  • rendering/RenderTableRow.cpp:

(WebCore::RenderTableRow::layout):

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::layout):
(WebCore::RenderTableSection::layoutRows):

  • rendering/RenderView.cpp:

(WebCore::RenderView::computeRectForRepaint):

  • rendering/ShadowElement.cpp:

(WebCore::ShadowBlockElement::layoutAsPart):

LayoutTests:

  • fast/repaint/japanese-rl-selection-clear.html: Added.
  • fast/repaint/japanese-rl-selection-repaint.html: Added.
  • fast/repaint/repaint-svg-after-style-change-expected.png:
  • platform/mac/fast/repaint/4774354-expected.checksum:
  • platform/mac/fast/repaint/4774354-expected.png:
  • platform/mac/fast/repaint/4776765-expected.checksum:
  • platform/mac/fast/repaint/4776765-expected.png:
  • platform/mac/fast/repaint/background-generated-expected.checksum:
  • platform/mac/fast/repaint/background-generated-expected.png:
  • platform/mac/fast/repaint/background-misaligned-expected.png:
  • platform/mac/fast/repaint/backgroundSizeRepaint-expected.checksum:
  • platform/mac/fast/repaint/backgroundSizeRepaint-expected.png:
  • platform/mac/fast/repaint/block-layout-inline-children-replaced-expected.checksum:
  • platform/mac/fast/repaint/block-layout-inline-children-replaced-expected.png:
  • platform/mac/fast/repaint/block-no-inflow-children-expected.checksum:
  • platform/mac/fast/repaint/block-no-inflow-children-expected.png:
  • platform/mac/fast/repaint/block-selection-gap-in-composited-layer-expected.checksum:
  • platform/mac/fast/repaint/block-selection-gap-in-composited-layer-expected.png:
  • platform/mac/fast/repaint/block-selection-gap-stale-cache-2-expected.png:
  • platform/mac/fast/repaint/border-fit-lines-expected.checksum:
  • platform/mac/fast/repaint/border-fit-lines-expected.png:
  • platform/mac/fast/repaint/border-radius-repaint-expected.checksum:
  • platform/mac/fast/repaint/border-radius-repaint-expected.png:
  • platform/mac/fast/repaint/border-repaint-glitch-expected.checksum:
  • platform/mac/fast/repaint/border-repaint-glitch-expected.png:
  • platform/mac/fast/repaint/box-shadow-dynamic-expected.checksum:
  • platform/mac/fast/repaint/box-shadow-dynamic-expected.png:
  • platform/mac/fast/repaint/box-shadow-h-expected.checksum:
  • platform/mac/fast/repaint/box-shadow-h-expected.png:
  • platform/mac/fast/repaint/box-shadow-v-expected.checksum:
  • platform/mac/fast/repaint/box-shadow-v-expected.png:
  • platform/mac/fast/repaint/bugzilla-3509-expected.checksum:
  • platform/mac/fast/repaint/bugzilla-3509-expected.png:
  • platform/mac/fast/repaint/bugzilla-5699-expected.checksum:
  • platform/mac/fast/repaint/bugzilla-5699-expected.png:
  • platform/mac/fast/repaint/bugzilla-6278-expected.checksum:
  • platform/mac/fast/repaint/bugzilla-6278-expected.png:
  • platform/mac/fast/repaint/bugzilla-6388-expected.checksum:
  • platform/mac/fast/repaint/bugzilla-6388-expected.png:
  • platform/mac/fast/repaint/bugzilla-6473-expected.checksum:
  • platform/mac/fast/repaint/bugzilla-6473-expected.png:
  • platform/mac/fast/repaint/bugzilla-7235-expected.checksum:
  • platform/mac/fast/repaint/bugzilla-7235-expected.png:
  • platform/mac/fast/repaint/button-spurious-layout-hint-expected.png:
  • platform/mac/fast/repaint/caret-outside-block-expected.checksum:
  • platform/mac/fast/repaint/caret-outside-block-expected.png:
  • platform/mac/fast/repaint/change-transform-expected.checksum:
  • platform/mac/fast/repaint/change-transform-expected.png:
  • platform/mac/fast/repaint/clip-with-layout-delta-expected.png:
  • platform/mac/fast/repaint/clipped-relative-expected.checksum:
  • platform/mac/fast/repaint/clipped-relative-expected.png:
  • platform/mac/fast/repaint/containing-block-position-change-expected.checksum:
  • platform/mac/fast/repaint/containing-block-position-change-expected.png:
  • platform/mac/fast/repaint/content-into-overflow-expected.png:
  • platform/mac/fast/repaint/continuation-after-outline-expected.checksum:
  • platform/mac/fast/repaint/continuation-after-outline-expected.png:
  • platform/mac/fast/repaint/control-clip-expected.checksum:
  • platform/mac/fast/repaint/control-clip-expected.png:
  • platform/mac/fast/repaint/create-layer-repaint-expected.checksum:
  • platform/mac/fast/repaint/create-layer-repaint-expected.png:
  • platform/mac/fast/repaint/delete-into-nested-block-expected.checksum:
  • platform/mac/fast/repaint/delete-into-nested-block-expected.png:
  • platform/mac/fast/repaint/dynamic-table-vertical-alignment-change-expected.checksum:
  • platform/mac/fast/repaint/dynamic-table-vertical-alignment-change-expected.png:
  • platform/mac/fast/repaint/erase-overflow-expected.png:
  • platform/mac/fast/repaint/fixed-expected.checksum:
  • platform/mac/fast/repaint/fixed-expected.png:
  • platform/mac/fast/repaint/flexible-box-overflow-expected.checksum:
  • platform/mac/fast/repaint/flexible-box-overflow-expected.png:
  • platform/mac/fast/repaint/flexible-box-overflow-horizontal-expected.checksum:
  • platform/mac/fast/repaint/flexible-box-overflow-horizontal-expected.png:
  • platform/mac/fast/repaint/float-in-new-block-with-layout-delta-expected.png:
  • platform/mac/fast/repaint/float-move-during-layout-expected.checksum:
  • platform/mac/fast/repaint/float-move-during-layout-expected.png:
  • platform/mac/fast/repaint/float-new-in-block-expected.png:
  • platform/mac/fast/repaint/float-overflow-expected.png:
  • platform/mac/fast/repaint/float-overflow-right-expected.png:
  • platform/mac/fast/repaint/focus-layers-expected.checksum:
  • platform/mac/fast/repaint/focus-layers-expected.png:
  • platform/mac/fast/repaint/focus-ring-expected.png:
  • platform/mac/fast/repaint/inline-block-overflow-expected.checksum:
  • platform/mac/fast/repaint/inline-block-overflow-expected.png:
  • platform/mac/fast/repaint/inline-block-resize-expected.png:
  • platform/mac/fast/repaint/inline-color-change-expected.checksum:
  • platform/mac/fast/repaint/inline-color-change-expected.png:
  • platform/mac/fast/repaint/inline-outline-repaint-expected.checksum:
  • platform/mac/fast/repaint/inline-outline-repaint-expected.png:
  • platform/mac/fast/repaint/intermediate-layout-position-clip-expected.png:
  • platform/mac/fast/repaint/intermediate-layout-position-expected.png:
  • platform/mac/fast/repaint/invisible-objects-expected.png:
  • platform/mac/fast/repaint/japanese-rl-selection-clear-expected.checksum: Added.
  • platform/mac/fast/repaint/japanese-rl-selection-clear-expected.png: Added.
  • platform/mac/fast/repaint/japanese-rl-selection-clear-expected.txt: Added.
  • platform/mac/fast/repaint/japanese-rl-selection-repaint-expected.checksum: Added.
  • platform/mac/fast/repaint/japanese-rl-selection-repaint-expected.png: Added.
  • platform/mac/fast/repaint/japanese-rl-selection-repaint-expected.txt: Added.
  • platform/mac/fast/repaint/layer-child-outline-expected.checksum:
  • platform/mac/fast/repaint/layer-child-outline-expected.png:
  • platform/mac/fast/repaint/layer-full-repaint-expected.png:
  • platform/mac/fast/repaint/layer-hide-when-needs-layout-expected.png:
  • platform/mac/fast/repaint/layer-outline-expected.checksum:
  • platform/mac/fast/repaint/layer-outline-expected.png:
  • platform/mac/fast/repaint/layer-outline-horizontal-expected.checksum:
  • platform/mac/fast/repaint/layer-outline-horizontal-expected.png:
  • platform/mac/fast/repaint/layer-visibility-expected.png:
  • platform/mac/fast/repaint/layout-state-only-positioned-expected.png:
  • platform/mac/fast/repaint/layout-state-relative-expected.checksum:
  • platform/mac/fast/repaint/layout-state-relative-expected.png:
  • platform/mac/fast/repaint/layout-state-scrolloffset-expected.checksum:
  • platform/mac/fast/repaint/layout-state-scrolloffset-expected.png:
  • platform/mac/fast/repaint/layout-state-scrolloffset2-expected.checksum:
  • platform/mac/fast/repaint/layout-state-scrolloffset2-expected.png:
  • platform/mac/fast/repaint/layout-state-scrolloffset3-expected.checksum:
  • platform/mac/fast/repaint/layout-state-scrolloffset3-expected.png:
  • platform/mac/fast/repaint/line-overflow-expected.checksum:
  • platform/mac/fast/repaint/line-overflow-expected.png:
  • platform/mac/fast/repaint/lines-with-layout-delta-expected.checksum:
  • platform/mac/fast/repaint/lines-with-layout-delta-expected.png:
  • platform/mac/fast/repaint/list-marker-2-expected.checksum:
  • platform/mac/fast/repaint/list-marker-2-expected.png:
  • platform/mac/fast/repaint/list-marker-expected.checksum:
  • platform/mac/fast/repaint/list-marker-expected.png:
  • platform/mac/fast/repaint/make-children-non-inline-expected.checksum:
  • platform/mac/fast/repaint/make-children-non-inline-expected.png:
  • platform/mac/fast/repaint/moving-shadow-on-container-expected.checksum:
  • platform/mac/fast/repaint/moving-shadow-on-container-expected.png:
  • platform/mac/fast/repaint/moving-shadow-on-path-expected.checksum:
  • platform/mac/fast/repaint/moving-shadow-on-path-expected.png:
  • platform/mac/fast/repaint/multicol-repaint-expected.checksum:
  • platform/mac/fast/repaint/multicol-repaint-expected.png:
  • platform/mac/fast/repaint/opacity-change-on-overflow-float-expected.checksum:
  • platform/mac/fast/repaint/opacity-change-on-overflow-float-expected.png:
  • platform/mac/fast/repaint/outline-child-repaint-expected.checksum:
  • platform/mac/fast/repaint/outline-child-repaint-expected.png:
  • platform/mac/fast/repaint/outline-inset-expected.png:
  • platform/mac/fast/repaint/outline-repaint-glitch-expected.checksum:
  • platform/mac/fast/repaint/outline-repaint-glitch-expected.png:
  • platform/mac/fast/repaint/outline-shrinking-expected.checksum:
  • platform/mac/fast/repaint/outline-shrinking-expected.png:
  • platform/mac/fast/repaint/overflow-clip-subtree-layout-expected.png:
  • platform/mac/fast/repaint/overflow-delete-line-expected.checksum:
  • platform/mac/fast/repaint/overflow-delete-line-expected.png:
  • platform/mac/fast/repaint/overflow-into-content-expected.png:
  • platform/mac/fast/repaint/overflow-outline-repaint-expected.checksum:
  • platform/mac/fast/repaint/overflow-outline-repaint-expected.png:
  • platform/mac/fast/repaint/overflow-scroll-body-appear-expected.checksum:
  • platform/mac/fast/repaint/overflow-scroll-body-appear-expected.png:
  • platform/mac/fast/repaint/overflow-scroll-delete-expected.checksum:
  • platform/mac/fast/repaint/overflow-scroll-delete-expected.png:
  • platform/mac/fast/repaint/reflection-redraw-expected.checksum:
  • platform/mac/fast/repaint/reflection-redraw-expected.png:
  • platform/mac/fast/repaint/reflection-repaint-test-expected.png:
  • platform/mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png:
  • platform/mac/fast/repaint/repaint-resized-overflow-expected.checksum:
  • platform/mac/fast/repaint/repaint-resized-overflow-expected.png:
  • platform/mac/fast/repaint/search-field-cancel-expected.checksum:
  • platform/mac/fast/repaint/search-field-cancel-expected.png:
  • platform/mac/fast/repaint/selected-replaced-expected.checksum:
  • platform/mac/fast/repaint/selected-replaced-expected.png:
  • platform/mac/fast/repaint/selection-after-delete-expected.checksum:
  • platform/mac/fast/repaint/selection-after-delete-expected.png:
  • platform/mac/fast/repaint/selection-after-remove-expected.checksum:
  • platform/mac/fast/repaint/selection-after-remove-expected.png:
  • platform/mac/fast/repaint/selection-clear-expected.checksum:
  • platform/mac/fast/repaint/selection-clear-expected.png:
  • platform/mac/fast/repaint/selection-gap-overflow-scroll-expected.checksum:
  • platform/mac/fast/repaint/selection-gap-overflow-scroll-expected.png:
  • platform/mac/fast/repaint/selection-rl-expected.checksum:
  • platform/mac/fast/repaint/selection-rl-expected.png:
  • platform/mac/fast/repaint/shadow-multiple-horizontal-expected.png:
  • platform/mac/fast/repaint/shadow-multiple-strict-horizontal-expected.checksum:
  • platform/mac/fast/repaint/shadow-multiple-strict-horizontal-expected.png:
  • platform/mac/fast/repaint/shadow-multiple-strict-vertical-expected.checksum:
  • platform/mac/fast/repaint/shadow-multiple-strict-vertical-expected.png:
  • platform/mac/fast/repaint/shadow-multiple-vertical-expected.png:
  • platform/mac/fast/repaint/stacked-diacritics-expected.checksum:
  • platform/mac/fast/repaint/stacked-diacritics-expected.png:
  • platform/mac/fast/repaint/static-to-positioned-expected.checksum:
  • platform/mac/fast/repaint/static-to-positioned-expected.png:
  • platform/mac/fast/repaint/subtree-root-clip-2-expected.png:
  • platform/mac/fast/repaint/subtree-root-clip-3-expected.png:
  • platform/mac/fast/repaint/subtree-root-clip-expected.png:
  • platform/mac/fast/repaint/subtree-root-skipped-expected.checksum:
  • platform/mac/fast/repaint/subtree-root-skipped-expected.png:
  • platform/mac/fast/repaint/table-cell-collapsed-border-expected.checksum:
  • platform/mac/fast/repaint/table-cell-collapsed-border-expected.png:
  • platform/mac/fast/repaint/table-cell-move-expected.checksum:
  • platform/mac/fast/repaint/table-cell-move-expected.png:
  • platform/mac/fast/repaint/table-cell-vertical-overflow-expected.png:
  • platform/mac/fast/repaint/table-col-background-expected.png:
  • platform/mac/fast/repaint/table-collapsed-border-expected.checksum:
  • platform/mac/fast/repaint/table-collapsed-border-expected.png:
  • platform/mac/fast/repaint/table-extra-bottom-grow-expected.checksum:
  • platform/mac/fast/repaint/table-extra-bottom-grow-expected.png:
  • platform/mac/fast/repaint/table-outer-border-expected.png:
  • platform/mac/fast/repaint/table-row-expected.png:
  • platform/mac/fast/repaint/table-section-overflow-expected.png:
  • platform/mac/fast/repaint/table-section-repaint-expected.png:
  • platform/mac/fast/repaint/table-two-pass-layout-overpaint-expected.png:
  • platform/mac/fast/repaint/text-append-dirty-lines-expected.checksum:
  • platform/mac/fast/repaint/text-append-dirty-lines-expected.png:
  • platform/mac/fast/repaint/text-selection-rect-in-overflow-2-expected.checksum:
  • platform/mac/fast/repaint/text-selection-rect-in-overflow-2-expected.png:
  • platform/mac/fast/repaint/text-selection-rect-in-overflow-expected.checksum:
  • platform/mac/fast/repaint/text-selection-rect-in-overflow-expected.png:
  • platform/mac/fast/repaint/text-shadow-expected.checksum:
  • platform/mac/fast/repaint/text-shadow-expected.png:
  • platform/mac/fast/repaint/text-shadow-horizontal-expected.checksum:
  • platform/mac/fast/repaint/text-shadow-horizontal-expected.png:
  • platform/mac/fast/repaint/transform-absolute-child-expected.png:
  • platform/mac/fast/repaint/transform-absolute-in-positioned-container-expected.checksum:
  • platform/mac/fast/repaint/transform-absolute-in-positioned-container-expected.png:
  • platform/mac/fast/repaint/transform-disable-layoutstate-expected.png:
  • platform/mac/fast/repaint/transform-layout-repaint-expected.png:
  • platform/mac/fast/repaint/transform-relative-position-expected.checksum:
  • platform/mac/fast/repaint/transform-relative-position-expected.png:
  • platform/mac/fast/repaint/transform-repaint-descendants-expected.checksum:
  • platform/mac/fast/repaint/transform-repaint-descendants-expected.png:
  • platform/mac/fast/repaint/transform-replaced-shadows-expected.png:
  • platform/mac/fast/repaint/transform-translate-expected.png:
14:07 Changeset [71850] by weinig@apple.com

Move the remaining API client classes to use the APIClient base class.
https://bugs.webkit.org/show_bug.cgi?id=49404

Reviewed by Anders Carlsson.

Also moves InjectedBundleClient into its own class to match other API clients.

  • UIProcess/WebContextInjectedBundleClient.cpp:
  • UIProcess/WebContextInjectedBundleClient.h:
  • UIProcess/WebHistoryClient.cpp:

(WebKit::WebHistoryClient::didNavigateWithNavigationData):
(WebKit::WebHistoryClient::didPerformClientRedirect):
(WebKit::WebHistoryClient::didPerformServerRedirect):
(WebKit::WebHistoryClient::didUpdateHistoryTitle):
(WebKit::WebHistoryClient::populateVisitedLinks):

  • UIProcess/WebHistoryClient.h:

(WebKit::WebHistoryClient::shouldTrackVisitedLinks):

  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::initializeClient):
(WebKit::InjectedBundle::reportException):
(WebKit::InjectedBundle::didCreatePage):
(WebKit::InjectedBundle::willDestroyPage):
(WebKit::InjectedBundle::didReceiveMessage):

  • WebProcess/InjectedBundle/InjectedBundle.h:
  • WebProcess/InjectedBundle/InjectedBundleClient.cpp: Added.

(WebKit::InjectedBundleClient::didCreatePage):
(WebKit::InjectedBundleClient::willDestroyPage):
(WebKit::InjectedBundleClient::didReceiveMessage):

  • WebProcess/InjectedBundle/InjectedBundleClient.h: Added.
  • win/WebKit2.vcproj:
13:12 Changeset [71849] by eric@webkit.org

2010-11-11 Eric Seidel <eric@webkit.org>

Rubber-stamped by Adam Barth.

Move bugzilla.py into its own module in preparation for splitting one-file-per-class
https://bugs.webkit.org/show_bug.cgi?id=49402

  • Scripts/webkitpy/common/net/bugzilla/init.py: Added.
  • Scripts/webkitpy/common/net/bugzilla/bugzilla.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/bugzilla.py.
  • Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/bugzilla_unittest.py.
13:10 Changeset [71848] by cmarrin@apple.com

2010-11-11 Chris Marrin <cmarrin@apple.com>

Reviewed by Simon Fraser.

Share code between Mac (CA) and Windows (CACF) GraphicsLayer implementations
https://bugs.webkit.org/show_bug.cgi?id=49388

Renamed GraphicsLayerCA.* to GraphicsLayerMac.*

  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/mac/GraphicsLayerCA.h: Removed.
  • platform/graphics/mac/GraphicsLayerCA.mm: Removed.
  • platform/graphics/mac/GraphicsLayerMac.h: Copied from WebCore/platform/graphics/mac/GraphicsLayerCA.h.
  • platform/graphics/mac/GraphicsLayerMac.mm: Copied from WebCore/platform/graphics/mac/GraphicsLayerCA.mm.
13:05 Changeset [71847] by kbr@google.com

2010-11-11 Kenneth Russell <kbr@google.com>

Reviewed by James Robinson.

[chromium] Missing adoptPtr in GraphicsContext3DSkia.cpp
https://bugs.webkit.org/show_bug.cgi?id=49359

  • platform/graphics/skia/GraphicsContext3DSkia.cpp: (WebCore::GraphicsContext3D::getImageData):
13:02 Changeset [71846] by mihaip@chromium.org

2010-11-11 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium expectations update and rebaseline.

  • fast/text/justification-padding-mid-word.html started to pass on Linux and Windows after r71809 updated baselines for it.
  • fast/text/international/bidi-control-chars-treated-as-ZWS.html should pass with the regular Mac baselines, don't need chromium-mac ones anymore
  • Rebaseline fast/text/international/bidi-neutral-run.html
  • platform/chromium-mac/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.txt: Removed.
  • platform/chromium-mac/fast/text/international/bidi-neutral-run-expected.txt:
  • platform/chromium/test_expectations.txt:
12:59 Changeset [71845] by andersca@apple.com

Remove an unneeded CFAllocatorRef parameter.

Reviewed by Adam Roben.

  • Shared/API/c/mac/WKURLResponseNS.h:
  • Shared/API/c/mac/WKURLResponseNS.mm:

(WKURLResponseCopyNSURLResponse):

12:57 Changeset [71844] by commit-queue@webkit.org

2010-11-11 Dan Horák <dan@danny.cz>

Reviewed by Andreas Kling.

Add support for the s390/s390x architectures, it's big-endian
with s390 being 32-bit and s390x being 64-bit.

https://bugs.webkit.org/show_bug.cgi?id=34786

  • wtf/Platform.h:
12:57 Changeset [71843] by mitz@apple.com

<rdar://problem/8113511> Enable auto-hyphenation

Reviewed by Adam Roben.

  • WebCore.vcproj/WebCore.vcproj: Included HyphenationCF.cpp instead of Hyphenation.cpp.
  • platform/text/cf/HyphenationCF.cpp: Added functions and definitions for Windows to look up CFStringGetHyphenationLocationBeforeIndex

and CFStringIsHyphenationAvailableForLocale at runtime.
(wkCFStringGetHyphenationLocationBeforeIndex):
(wkCFStringIsHyphenationAvailableForLocale):
(WebCore::lastHyphenLocation): Added a cast.

12:31 Changeset [71842] by eric.carlson@apple.com

2010-11-11 Eric Carlson <eric.carlson@apple.com>

Reviewed by Eric Seidel.

video-pause-immediately.html sometimes fails
https://bugs.webkit.org/show_bug.cgi?id=49397

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::playInternal): Don't bother calling invalidateCachedTime, it will be called from updatePlayState. (WebCore::HTMLMediaElement::pauseInternal): Don't bother calling refreshCachedTime, it will be called from updatePlayState. (WebCore::HTMLMediaElement::updatePlayState): Call refreshCachedTime after telling the media engine to pause so we cache the post-paused time.
12:24 Changeset [71841] by eric@webkit.org

2010-11-11 Eric Seidel <eric@webkit.org>

Rubber-stamped by Adam Roben.

  • .: Modified property svn:ignore.
    • Add WebKitSupportLibrary.zip and WebKitBuild to the root ignore list.
12:18 Changeset [71840] by andersca@apple.com

Add and implement WKDownloadCopyRequest
https://bugs.webkit.org/show_bug.cgi?id=49393

Reviewed by Adam Roben.

  • Shared/API/c/mac/WKURLRequestNS.h:
  • Shared/API/c/mac/WKURLRequestNS.mm:

(WKURLRequestCopyNSURLRequest):
Remove unneeded CFAllocator parameter.

  • Shared/WebURLRequest.cpp:

(WebKit::WebURLRequest::WebURLRequest):

  • Shared/WebURLRequest.h:

(WebKit::WebURLRequest::create):
Change create to take a ResourceRequest instead.

  • UIProcess/API/C/WKDownload.cpp:

(WKDownloadCopyRequest):
Return a copied WKURLRequest.

  • UIProcess/API/C/WKDownload.h:
  • UIProcess/Downloads/DownloadProxy.cpp:

(WebKit::DownloadProxy::didStart):
Set the request.

  • UIProcess/Downloads/DownloadProxy.h:

(WebKit::DownloadProxy::request):
Return the request.

  • UIProcess/Downloads/DownloadProxy.messages.in:
  • WebProcess/Downloads/Download.cpp:

(WebKit::Download::didStart):
Pass the request along when sending the DidStart message.

11:39 Changeset [71839] by mihaip@chromium.org

2010-11-11 Mihai Parparita <mihaip@chromium.org>

Unreviewed rollout.

Roll out r71827 and r71831, which caused many GPU canvas test failures.

  • platform/graphics/Extensions3D.h:
  • platform/graphics/chromium/DrawingBufferChromium.cpp: (WebCore::DrawingBuffer::reset): (WebCore::DrawingBuffer::getRenderingResultsAsTexture):
  • platform/graphics/chromium/Extensions3DChromium.h:
  • platform/graphics/gpu/DrawingBuffer.cpp: (WebCore::DrawingBuffer::create): (WebCore::DrawingBuffer::clear): (WebCore::DrawingBuffer::bind):
  • platform/graphics/gpu/DrawingBuffer.h:
  • platform/graphics/gpu/SharedGraphicsContext3D.cpp: (WebCore::SharedGraphicsContext3D::create):
  • platform/graphics/gpu/mac/DrawingBufferMac.mm: (WebCore::DrawingBuffer::DrawingBuffer): (WebCore::DrawingBuffer::reset):
  • platform/graphics/opengl/Extensions3DOpenGL.cpp: (WebCore::Extensions3DOpenGL::supports):
  • platform/graphics/opengl/Extensions3DOpenGL.h:
  • platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::ImageBuffer::draw):
11:07 Changeset [71838] by xji@chromium.org

2010-11-11 Xiaomei Ji <xji@chromium.org>

Reviewed by Adam Roben.

Rebaseline bidi-control-chars-treated-as-ZWS after r71566.
Move the result from win/ (since Windows 7 result matches Mac's) to win-xp/
https://bugs.webkit.org/show_bug.cgi?id=49391

  • platform/win-xp/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.checksum: Copied from LayoutTests/platform/win/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.checksum.
  • platform/win-xp/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.png: Copied from LayoutTests/platform/win/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.png.
  • platform/win-xp/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.txt: Copied from LayoutTests/platform/win/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.txt.
  • platform/win/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.checksum: Removed.
  • platform/win/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.png: Removed.
  • platform/win/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.txt: Removed.
10:52 Changeset [71837] by eric.carlson@apple.com

2010-11-11 Eric Carlson <eric.carlson@apple.com>

Unreviewed.

video-played-* tests results are sensitive to timing
https://bugs.webkit.org/show_bug.cgi?id=49390


Skip tests that fail on Leopard Release builds.

  • platform/mac-leopard/Skipped:
10:44 Changeset [71836] by mihaip@chromium.org

2010-11-11 Mihai Parparita <mihaip@chromium.org>

Unreviewed; add missing baseline checksums.

r71784 did not include .checksum files, add them (Chromium needs a
different one, persumably because it computes checksums for images
with alpha channels differently).

  • fast/images/png_per_row_alpha_decoding-expected.checksum: Added.
  • platform/chromium/fast/images/png_per_row_alpha_decoding-expected.checksum: Added.
  • platform/chromium/test_expectations.txt:
10:40 Changeset [71835] by sullivan@apple.com
  • WebKit2.xcodeproj/project.pbxproj:

Added WKBundlePageOverlay.h to the WebKit2 Target and made it public.

Rubber-stamped by Anders Carlsson.

10:18 Changeset [71834] by andersca@apple.com

Move GraphicsContext setup code to PageOverlay::drawRect
https://bugs.webkit.org/show_bug.cgi?id=49389

Reviewed by John Sullivan.

  • WebProcess/InjectedBundle/API/c/WKBundlePageOverlay.h:
  • WebProcess/WebPage/FindController.cpp:

(WebKit::FindController::drawRect):

  • WebProcess/WebPage/PageOverlay.cpp:

(WebKit::PageOverlay::drawRect):

10:13 Changeset [71833] by eric.carlson@apple.com

2010-11-11 Eric Carlson <eric.carlson@apple.com>

Restore the portion of the ChangeLog removed in my last commit.

09:47 Changeset [71832] by eric.carlson@apple.com

2010-11-11 Eric Carlson <eric.carlson@apple.com>

Unreviewed Leoaprd build fix.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::invalidateCachedTime): Make the const a double.
09:45 Changeset [71831] by cmarrin@apple.com

SL bug fix in ExtensionsOpenGL.cpp

09:41 Changeset [71830] by krit@webkit.org

2010-11-11 Dirk Schulze <krit@webkit.org>

Unreviewed Qt build fix.

SVGAnimation calcMode 'spline' should be useable for from-to and from-by animations
https://bugs.webkit.org/show_bug.cgi?id=49284

  • svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::calculatePercentFromKeyPoints): (WebCore::SVGAnimationElement::startedActiveInterval):
09:35 Changeset [71829] by hans@chromium.org

2010-11-11 Hans Wennborg <hans@chromium.org>

Reviewed by Jeremy Orlow.

IndexedDB: signal IDBFactoryBackendInterface destruction to embedder
https://bugs.webkit.org/show_bug.cgi?id=49313

Implement ChromiumBridge::idbShutdown(), passing through to the
WebKitClient.

  • public/WebKitClient.h: (WebKit::WebKitClient::idbShutdown):
  • src/ChromiumBridge.cpp: (WebCore::ChromiumBridge::idbShutdown):

2010-11-11 Hans Wennborg <hans@chromium.org>

Reviewed by Jeremy Orlow.

IndexedDB: signal IDBFactoryBackendInterface destruction to embedder
https://bugs.webkit.org/show_bug.cgi?id=49313

Define IDBFactoryBackendInterface destructor out-of-line to allow
for embedder-specific implementation. For Chromium, have the
destructor call ChromiumBridge::idbShutdown().

  • platform/chromium/ChromiumBridge.h:
  • storage/IDBFactoryBackendInterface.cpp: (WebCore::IDBFactoryBackendInterface::~IDBFactoryBackendInterface):
  • storage/IDBFactoryBackendInterface.h:
  • storage/chromium/IDBFactoryBackendInterface.cpp: (WebCore::IDBFactoryBackendInterface::~IDBFactoryBackendInterface):
09:26 Changeset [71828] by krit@webkit.org

2010-11-11 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVGAnimation calcMode 'spline' should be useable for from-to and from-by animations
https://bugs.webkit.org/show_bug.cgi?id=49284

Add support for from-to and from-by animations in combination with calcMode 'spline' for SVGAnimations.

Tests: svg/animations/animate-calcMode-spline-by.html

svg/animations/animate-calcMode-spline-from-by.html
svg/animations/animate-calcMode-spline-from-to.html
svg/animations/animate-calcMode-spline-to.html
svg/animations/animate-calcMode-spline-values.html

  • svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::calculateKeyTimesIndex): Added to share more code. (WebCore::SVGAnimationElement::calculatePercentFromKeyPoints): (WebCore::SVGAnimationElement::currentValuesForValuesAnimation): (WebCore::SVGAnimationElement::startedActiveInterval): (WebCore::SVGAnimationElement::updateAnimation):
  • svg/SVGAnimationElement.h:

2010-11-11 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVGAnimation calcMode="spline" should use 'to' 'by' animation if no values were specified
https://bugs.webkit.org/show_bug.cgi?id=49284

Added new SVG animation tests to test calcMode 'spline'.

  • svg/animations/animate-calcMode-spline-by-expected.txt: Added.
  • svg/animations/animate-calcMode-spline-by.html: Added.
  • svg/animations/animate-calcMode-spline-from-by-expected.txt: Added.
  • svg/animations/animate-calcMode-spline-from-by.html: Added.
  • svg/animations/animate-calcMode-spline-from-to-expected.txt: Added.
  • svg/animations/animate-calcMode-spline-from-to.html: Added.
  • svg/animations/animate-calcMode-spline-to-expected.txt: Added.
  • svg/animations/animate-calcMode-spline-to.html: Added.
  • svg/animations/animate-calcMode-spline-values-expected.txt: Added.
  • svg/animations/animate-calcMode-spline-values.html: Added.
  • svg/animations/script-tests/animate-calcMode-spline-by.js: Added. (sample1): (sample2): (sample3): (executeTest):
  • svg/animations/script-tests/animate-calcMode-spline-from-by.js: Added. (sample1): (sample2): (sample3): (executeTest):
  • svg/animations/script-tests/animate-calcMode-spline-from-to.js: Added. (sample1): (sample2): (sample3): (executeTest):
  • svg/animations/script-tests/animate-calcMode-spline-to.js: Added. (sample1): (sample2): (sample3): (executeTest):
  • svg/animations/script-tests/animate-calcMode-spline-values.js: Added. (sample1): (sample2): (sample3): (executeTest):
09:11 Changeset [71827] by cmarrin@apple.com

2010-11-10 Chris Marrin <cmarrin@apple.com>

Reviewed by James Robinson.

Add multisampling support to DrawingBuffer.
https://bugs.webkit.org/show_bug.cgi?id=49206

Added support for the GL_ANGLE_framebuffer_blit and GL_ANGLE_framebuffer_multisample
extensions to Extensions3D. Then I use these to add multisample support to DrawingBuffer.

  • platform/graphics/Extensions3D.h:
  • platform/graphics/chromium/DrawingBufferChromium.cpp: (WebCore::DrawingBuffer::platformColorBuffer):
  • platform/graphics/chromium/Extensions3DChromium.h: (WebCore::Extensions3DChromium::blitFramebuffer): (WebCore::Extensions3DChromium::renderbufferStorageMultisample):
  • platform/graphics/gpu/DrawingBuffer.cpp: (WebCore::DrawingBuffer::create): (WebCore::DrawingBuffer::clear): (WebCore::DrawingBuffer::reset): (WebCore::DrawingBuffer::commit): (WebCore::DrawingBuffer::bind):
  • platform/graphics/gpu/DrawingBuffer.h: (WebCore::DrawingBuffer::multisample):
  • platform/graphics/gpu/mac/DrawingBufferMac.mm: (WebCore::DrawingBuffer::DrawingBuffer): (WebCore::DrawingBuffer::platformLayer): (WebCore::DrawingBuffer::platformColorBuffer):
  • platform/graphics/opengl/Extensions3DOpenGL.cpp: (WebCore::Extensions3DOpenGL::supports): (WebCore::Extensions3DOpenGL::blitFramebuffer): (WebCore::Extensions3DOpenGL::renderbufferStorageMultisample):
  • platform/graphics/opengl/Extensions3DOpenGL.h:
  • platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::ImageBuffer::draw):
08:42 Changeset [71826] by eric.carlson@apple.com

2010-11-11 Eric Carlson <eric.carlson@apple.com>

Build fix after r71824.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::invalidateCachedTime): Use an explicit cast from double to float. (WebCore::HTMLMediaElement::currentTime): Ditto.
08:22 Changeset [71825] by aroben@apple.com

Build fix after r71816

  • WebProcess/WebPage/WebPage.messages.in: Compile out

SetActualVisibleContentRect when ENABLE(TILED_BACKING_STORE) is
turned off.

08:08 Changeset [71824] by eric.carlson@apple.com

2010-11-11 Eric Carlson <eric.carlson@apple.com>

Reviewed by Antti Koivisto.

Lots of time spent in MediaPlayerPrivate::currentTime() when playing multiple videos.
https://bugs.webkit.org/show_bug.cgi?id=49009

Make it possible for HTMLMediaElement to cache the movie time and report 'currentTime'
as [cached time + elapsed wall time]. The media engine returns the maximum duration it
is safe to calculate time before resampling the actual movie time with the new
maximumDurationToCacheMovieTime method. Because this may be different for different media
engines the default return value is 0, making it an opt-in feature.

No new tests were added because the existing tests already check currentTime, and because
it is only possible to look for drift between the calculated and actual media time by
calculating the time AND getting the actual media time - which the defeats the purpose of
the change. Building with LOG_CACHED_TIME_WARNINGS defined enables code that does both
and logs warnings when the delta between calculated and observed is greater than 0.01.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement): Initialize new member variables. (WebCore::HTMLMediaElement::prepareForLoad): Force a time resync before setting m_paused. (WebCore::HTMLMediaElement::seek): Force a time resync before getting the current time before seeking so there is no drift. (WebCore::HTMLMediaElement::refreshCachedTime): New, update the cached movie time and the wall clock time it was recorded. (WebCore::HTMLMediaElement::invalidateCachedTime): New, flag the cached time as invalid. (WebCore::HTMLMediaElement::currentTime): Use a cached movie time for as long as the media engine says it is safe. Lots of optional logging can be enabled to help ports fine tune the maximum cache interval. (WebCore::HTMLMediaElement::ended): Force a time resync before setting m_paused. (WebCore::HTMLMediaElement::endScrubbing): Fix a typo in the logging. (WebCore::HTMLMediaElement::scheduleTimeupdateEvent): Call currentTime() instead of calling MediaPlayer so we use the cached time as much as it possible. (WebCore::HTMLMediaElement::mediaPlayerTimeChanged): Invalidate cached time because the engine seeked. (WebCore::HTMLMediaElement::mediaPlayerRateChanged): Ditto. (WebCore::HTMLMediaElement::updatePlayState): Invalidate cached time before changing m_paused.
  • html/HTMLMediaElement.h:
  • platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::maximumDurationToCacheMovieTime): New.
  • platform/graphics/MediaPlayer.h:
  • platform/graphics/MediaPlayerPrivate.h: (WebCore::MediaPlayerPrivateInterface::maximumDurationToCacheMovieTime): New.
  • platform/graphics/mac/MediaPlayerPrivateQTKit.h: (WebCore::MediaPlayerPrivate::maximumDurationToCacheMovieTime): New, say it is safe to cache time for five seconds (based on lots of experimenting with LOG_CACHED_TIME_WARNINGS enabled).
08:02 Changeset [71823] by aroben@apple.com

Windows build fix after r71816

r71816 renamed
WebCore/platform/graphics/cairo/FontPlatformDataCairoWin.h to
WebCore/platform/graphics/win/FontPlatformData.h. This made Apple's
Windows port pick up this header in preference to
WebCore/platform/cg/FontPlatformData.h, thus breaking the build. I
moved the file to
WebCore/platform/graphics/win/cairo/FontPlatformData.h so it won't be
picked up by Apple's Windows build.

  • WebCore.vcproj/WebCore.vcproj: Updated for file move and let VS

re-sort the files.

  • WebCore.vcproj/WebCoreCairo.vsprops: Added

platform/graphics/win/cairo to the include path.

  • WebCore.vcproj/copyForwardingHeaders.cmd: Copy files from

platform/graphics/win/cairo to $WebKitOutputDir.

  • platform/graphics/cg/FontPlatformData.h: Touched to force this file

to be recopied for Apple's build.

  • platform/graphics/win/cairo/FontPlatformData.h: Renamed from

WebCore/platform/graphics/win/FontPlatformData.h.

07:51 Changeset [71822] by chang.shu@nokia.com

2010-11-11 Chang Shu <chang.shu@nokia.com>

Reviewed by Csaba Osztrogonác <ossy@webkit.org>.

Clean up LayoutTests/canvas/philip/tests/security* tests
https://bugs.webkit.org/show_bug.cgi?id=49317

The security tests require httpd and should be in http/tests/canvas/philip/tests.

  • canvas/philip/tests/security.drawImage.canvas-expected.txt: Removed.
  • canvas/philip/tests/security.drawImage.canvas.html: Removed.
  • canvas/philip/tests/security.drawImage.image-expected.txt: Removed.
  • canvas/philip/tests/security.drawImage.image.html: Removed.
  • canvas/philip/tests/security.pattern.canvas.fillStyle-expected.txt: Removed.
  • canvas/philip/tests/security.pattern.canvas.fillStyle.html: Removed.
  • canvas/philip/tests/security.pattern.canvas.strokeStyle-expected.txt: Removed.
  • canvas/philip/tests/security.pattern.canvas.strokeStyle.html: Removed.
  • canvas/philip/tests/security.pattern.canvas.timing-expected.txt: Removed.
  • canvas/philip/tests/security.pattern.canvas.timing.html: Removed.
  • canvas/philip/tests/security.pattern.create-expected.txt: Removed.
  • canvas/philip/tests/security.pattern.create.html: Removed.
  • canvas/philip/tests/security.pattern.cross-expected.txt: Removed.
  • canvas/philip/tests/security.pattern.cross.html: Removed.
  • canvas/philip/tests/security.pattern.image.fillStyle-expected.txt: Removed.
  • canvas/philip/tests/security.pattern.image.fillStyle.html: Removed.
  • canvas/philip/tests/security.pattern.image.strokeStyle-expected.txt: Removed.
  • canvas/philip/tests/security.pattern.image.strokeStyle.html: Removed.
  • canvas/philip/tests/security.reset-expected.txt: Removed.
  • canvas/philip/tests/security.reset.html: Removed.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/mac-leopard/Skipped:
  • platform/qt/Skipped:
07:50 TriagingTestFailures edited by aroben@apple.com
Wordsmithing (diff)
07:47 Changeset [71821] by kbalazs@webkit.org

2010-11-11 Balazs Kelemen <kbalazs@webkit.org>

Reviewed by Andreas Kling.

[Qt][WK2] Implement BackingStore
https://bugs.webkit.org/show_bug.cgi?id=49377
No change in functionality so no tests.

Add a way to hand off ownership of the QPainter and the underlying
QPaintDevice to the GraphicsContext.

  • platform/graphics/GraphicsContext.h:
  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContextPlatformPrivate::takeOwnershipOfPlatformContext): (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate): (WebCore::GraphicsContextPlatformPrivate::~GraphicsContextPlatformPrivate): (WebCore::GraphicsContext::takeOwnershipOfPlatformContext):

2010-11-11 Balazs Kelemen <kbalazs@webkit.org>

Reviewed by Andreas Kling.

[Qt][WK2] Implement BackingStore
https://bugs.webkit.org/show_bug.cgi?id=49377

  • Shared/qt/BackingStoreQt.cpp: (WebKit::createQImage): Added static helper. Creates a QImage from the shared memory buffer. (WebKit::BackingStore::createGraphicsContext): (WebKit::BackingStore::createFlippedGraphicsContext): Leave unimplemented with an ASSERT_NOT_REACHED since this is only needed for the CoreGraphics backend. (WebKit::BackingStore::paint):
07:45 TriagingTestFailures edited by aroben@apple.com
Mention that you should verify your changes worked (diff)
07:40 Changeset [71820] by bulach@chromium.org

2010-11-11 Marcus Bulach <bulach@chromium.org>

Update chromium baselines for svg following r71802

Not reviewed, Chromium test expectation update..

https://bugs.webkit.org/show_bug.cgi?id=49380

  • platform/chromium-win/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.txt: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.txt: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.txt: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.txt: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt: Added.
07:27 Changeset [71819] by ossy@webkit.org

Unreviewed.

[Qt] Add platform specific expected results for new passing tests introduced in r71802.
Compared to Mac png files and Mac expected files.

  • platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.checksum: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.png: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.txt: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.checksum: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.png: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.txt: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.checksum: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.png: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.txt: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.checksum: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.png: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.txt: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.checksum: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.png: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.checksum: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.png: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.txt: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.checksum: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.png: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.txt: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.checksum: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.png: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.checksum: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.png: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt: Added.
06:50 Changeset [71818] by commit-queue@webkit.org

2010-11-11 Yi Shen <yi.4.shen@nokia.com>

Reviewed by Andreas Kling.

[Qt] QWebScriptWorld::world() may crash
https://bugs.webkit.org/show_bug.cgi?id=49342

  • Api/qwebscriptworld.cpp: (QWebScriptWorld::world):
06:47 Changeset [71817] by andreas.kling@nokia.com

2010-11-11 Kenneth Rohde Christiansen <kenneth@webkit.org>

Reviewed by Andreas Kling.

[Qt] Add a Qt WebKit2 API for overriding the actual visible content rect
https://bugs.webkit.org/show_bug.cgi?id=49381

Add an Qt WebKit2 API for overriding the actual visible content rect in
WebCore. This is supposed to be used in combination with tiling.

  • UIProcess/API/qt/qwkpage.cpp: (QWKPage::setActualVisibleContentsRect):
  • UIProcess/API/qt/qwkpage.h:
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::setActualVisibleContentRect):
  • UIProcess/WebPageProxy.h:
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::setActualVisibleContentRect):
  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
06:33 Changeset [71816] by commit-queue@webkit.org

2010-11-11 Ryuan Choi <ryuan.choi@samsung.com>

Reviewed by Adam Barth.

[GTK] Move font related files.
https://bugs.webkit.org/show_bug.cgi?id=48116

Move pango and freetype related files to share non-GTK+ platforms.

No new tests because this is pure refactoring.

  • CMakeListsEfl.txt:
  • GNUmakefile.am:
  • WebCore.vcproj/WebCore.vcproj:
  • platform/graphics/cairo/FontCacheFreeType.cpp: Removed.
  • platform/graphics/cairo/FontCustomPlatformData.cpp: Removed.
  • platform/graphics/cairo/FontPlatformData.h: Removed.
  • platform/graphics/cairo/FontPlatformDataFreeType.cpp: Removed.
  • platform/graphics/cairo/FontPlatformDataFreeType.h: Removed.
  • platform/graphics/cairo/GlyphPageTreeNodeCairo.cpp: Removed.
  • platform/graphics/cairo/SimpleFontDataCairo.cpp: Removed.
  • platform/graphics/freetype: Added.
  • platform/graphics/freetype/FontCacheFreeType.cpp: Copied from WebCore/platform/graphics/cairo/FontCacheFreeType.cpp.
  • platform/graphics/freetype/FontCustomPlatformDataFreeType.cpp: Copied from WebCore/platform/graphics/cairo/FontCustomPlatformData.cpp.
  • platform/graphics/freetype/FontPlatformData.h: Copied from WebCore/platform/graphics/cairo/FontPlatformDataFreeType.h.
  • platform/graphics/freetype/FontPlatformDataFreeType.cpp: Copied from WebCore/platform/graphics/cairo/FontPlatformDataFreeType.cpp.
  • platform/graphics/freetype/GlyphPageTreeNodeFreeType.cpp: Copied from WebCore/platform/graphics/cairo/GlyphPageTreeNodeCairo.cpp.
  • platform/graphics/freetype/SimpleFontDataFreeType.cpp: Copied from WebCore/platform/graphics/cairo/SimpleFontDataCairo.cpp.
  • platform/graphics/gtk/FontCachePango.cpp: Removed.
  • platform/graphics/gtk/FontCustomPlatformDataPango.cpp: Removed.
  • platform/graphics/gtk/FontPlatformDataPango.cpp: Removed.
  • platform/graphics/gtk/FontPlatformDataPango.h: Removed.
  • platform/graphics/gtk/GlyphPageTreeNodePango.cpp: Removed.
  • platform/graphics/gtk/SimpleFontDataPango.cpp: Removed.
  • platform/graphics/pango: Added.
  • platform/graphics/pango/FontCachePango.cpp: Copied from WebCore/platform/graphics/gtk/FontCachePango.cpp.
  • platform/graphics/pango/FontCustomPlatformDataPango.cpp: Copied from WebCore/platform/graphics/gtk/FontCustomPlatformDataPango.cpp.
  • platform/graphics/pango/FontPlatformData.h: Copied from WebCore/platform/graphics/gtk/FontPlatformDataPango.h.
  • platform/graphics/pango/FontPlatformDataPango.cpp: Copied from WebCore/platform/graphics/gtk/FontPlatformDataPango.cpp.
  • platform/graphics/pango/GlyphPageTreeNodePango.cpp: Copied from WebCore/platform/graphics/gtk/GlyphPageTreeNodePango.cpp.
  • platform/graphics/pango/SimpleFontDataPango.cpp: Copied from WebCore/platform/graphics/gtk/SimpleFontDataPango.cpp.
  • platform/graphics/win/FontPlatformData.h: Copied from WebCore/platform/graphics/win/FontPlatformDataCairoWin.h.
  • platform/graphics/win/FontPlatformDataCairoWin.h: Removed.

2010-11-11 Ryuan Choi <ryuan.choi@samsung.com>

Reviewed by Adam Barth.

[GTK] Move font related files.
https://bugs.webkit.org/show_bug.cgi?id=48116

Add freetype/ to include path.

  • CMakeListsEfl.txt:
06:08 Changeset [71815] by zimmermann@webkit.org

2010-11-11 Nikolas Zimmermann <nzimmermann@rim.com>

Rubber-stamped by Dirk Schulze.

Update Snow Leopard baseline, move leopard generated files into platform/mac-leopard.

  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.checksum: Copied from platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.checksum.
  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.png: Copied from platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.png.
  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.checksum: Copied from platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.checksum.
  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.png: Copied from platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.png.
  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.checksum: Copied from platform/mac/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.checksum.
  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.png: Copied from platform/mac/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.png.
  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.checksum: Copied from platform/mac/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.checksum.
  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.png: Copied from platform/mac/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.png.
  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.checksum: Copied from platform/mac/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.checksum.
  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.png: Copied from platform/mac/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.png.
  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.checksum: Copied from platform/mac/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.checksum.
  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.png: Copied from platform/mac/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.png.
  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.checksum: Copied from platform/mac/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.checksum.
  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.png: Copied from platform/mac/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.png.
  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.checksum: Copied from platform/mac/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.checksum.
  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.png: Copied from platform/mac/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.png.
  • platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop-expected.checksum: Copied from platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop-expected.checksum.
  • platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop-expected.png: Copied from platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop-expected.png.
  • platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop-expected.checksum: Copied from platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop-expected.checksum.
  • platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop-expected.png: Copied from platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop-expected.png.
  • platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-edgeMode-prop-expected.checksum: Copied from platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-edgeMode-prop-expected.checksum.
  • platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-edgeMode-prop-expected.png: Copied from platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-edgeMode-prop-expected.png.
  • platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop-expected.checksum: Copied from platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop-expected.checksum.
  • platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop-expected.png: Copied from platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop-expected.png.
  • platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop-expected.checksum: Copied from platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop-expected.checksum.
  • platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop-expected.png: Copied from platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop-expected.png.
  • platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop-expected.checksum: Copied from platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop-expected.checksum.
  • platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop-expected.png: Copied from platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop-expected.png.
  • platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop-expected.checksum: Copied from platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop-expected.checksum.
  • platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop-expected.png: Copied from platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop-expected.png.
  • platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop-expected.checksum: Copied from platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop-expected.checksum.
  • platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop-expected.png: Copied from platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop-expected.png.
  • platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.checksum: Copied from platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.checksum.
  • platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.png: Copied from platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.png.
  • platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetY-prop-expected.checksum: Copied from platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetY-prop-expected.checksum.
  • platform/mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetY-prop-expected.png: Copied from platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetY-prop-expected.png.
  • platform/mac-leopard/svg/dynamic-updates/SVGFETileElement-dom-in-attr-expected.checksum: Copied from platform/mac/svg/dynamic-updates/SVGFETileElement-dom-in-attr-expected.checksum.
  • platform/mac-leopard/svg/dynamic-updates/SVGFETileElement-dom-in-attr-expected.png: Copied from platform/mac/svg/dynamic-updates/SVGFETileElement-dom-in-attr-expected.png.
  • platform/mac-leopard/svg/dynamic-updates/SVGFETileElement-svgdom-in-prop-expected.checksum: Copied from platform/mac/svg/dynamic-updates/SVGFETileElement-svgdom-in-prop-expected.checksum.
  • platform/mac-leopard/svg/dynamic-updates/SVGFETileElement-svgdom-in-prop-expected.png: Copied from platform/mac/svg/dynamic-updates/SVGFETileElement-svgdom-in-prop-expected.png.
  • platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-edgeMode-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-edgeMode-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetY-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetY-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFETileElement-dom-in-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFETileElement-dom-in-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFETileElement-svgdom-in-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFETileElement-svgdom-in-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop-expected.png:
06:06 Changeset [71814] by pfeldman@chromium.org

2010-11-11 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: size of resources in summary is 0
when there are redirects.
https://bugs.webkit.org/show_bug.cgi?id=49242

  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype._updateSummaryBar):
05:49 Changeset [71813] by benm@google.com

2010-11-11 Ben Murdoch <benm@google.com>

Reviewed by Darin Fisher.

document.createTouch and document.createTouchList should specify EnabledAtRuntime
https://bugs.webkit.org/show_bug.cgi?id=49324

The createTouch and createTouchList APIs added to Document.idl in
http://trac.webkit.org/changeset/70047 should have EnabledAtRuntime
specified as touch related features are controlled by a
RuntimeEnabledFeature flag in addition to a compile time guard.

No new tests. This should have been part of r70047 and
that revision provided adequate tests of the new feature.

  • bindings/generic/RuntimeEnabledFeatures.h: (WebCore::RuntimeEnabledFeatures::createTouchEnabled): (WebCore::RuntimeEnabledFeatures::createTouchListEnabled):
  • dom/Document.idl: Add EnabledAtRuntime specifier to the

idl methods.

05:46 Changeset [71812] by pfeldman@chromium.org

2010-11-09 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Provide context menu item 'Reveal in Elements Panel'
on elements in inspector UI.
https://bugs.webkit.org/show_bug.cgi?id=49161

  • English.lproj/localizedStrings.js:
  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeOutline.prototype._contextMenuEventFired.focusElement): (WebInspector.ElementsTreeOutline.prototype._contextMenuEventFired):
  • inspector/front-end/ObjectPropertiesSection.js: (WebInspector.ObjectPropertyTreeElement.prototype.update): (WebInspector.ObjectPropertyTreeElement.prototype._contextMenuEventFired): (WebInspector.ObjectPropertyTreeElement.prototype._contextMenuEventFired.revealElement):
05:27 Changeset [71811] by aroben@apple.com

Skip a newly-crashing test on Windows

  • platform/win/Skipped: Added accessibility/iframe-bastardization.html.
05:27 Changeset [71810] by pfeldman@chromium.org

2010-11-11 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Audit panel toolbar icon shifts left when clicked.
https://bugs.webkit.org/show_bug.cgi?id=48766

  • inspector/front-end/Images/auditsIcon.png:
05:24 TriagingTestFailures edited by aroben@apple.com
CC the author and reviewer of the guilty change, too (diff)
05:23 Changeset [71809] by aroben@apple.com

Update Windows results after r71566 and r71783

<http://webkit.org/b/49378> covers the
justification-padding-mid-word.html failure. The other test seems to be
passing (the two lines are the same width), but the text is slightly
lower than on Mac.

  • platform/win/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.checksum: Added.
  • platform/win/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.png: Added.
  • platform/win/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.txt: Added.
  • platform/win/fast/text/justification-padding-mid-word-expected.txt: Added.
05:21 TriagingTestFailures edited by aroben@apple.com
Mention linking to crash logs (diff)
05:11 Changeset [71808] by andreas.kling@nokia.com

2010-11-11 Andreas Kling <kling@webkit.org>

Unreviewed, remove SL-specific failure result for canvas test 2d.drawImage.null since it now passes.

  • platform/mac-snowleopard/canvas/philip/tests/2d.drawImage.null-expected.txt: Removed.
05:01 Changeset [71807] by ossy@webkit.org

[Qt] clean canvas layout tests skipped file
Removed the following test cases from skipped list:
canvas/philip/tests/2d.imageData.get.source.negative.html
canvas/philip/tests/toDataURL.jpeg.quality.basic.html

Patch by Qi Zhang <qi.2.zhang@nokia.com> on 2010-11-11
Reviewed by Csaba Osztrogonác.

  • platform/qt/Skipped:
04:46 Changeset [71806] by andreas.kling@nokia.com

2010-11-11 Kenneth Rohde Christiansen <kenneth@webkit.org>

Reviewed by Andreas Kling.

[Qt] Add an API for overriding the actual visible content rect in WebCore
https://bugs.webkit.org/show_bug.cgi?id=49373

  • Api/qwebpage.cpp: (QWebPage::setActualVisibleContentRect):
  • Api/qwebpage.h:
04:46 Changeset [71805] by zimmermann@webkit.org

2010-11-11 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

chrome.dll!WebCore::SVGLengthInternal::valueInSpecifiedUnitsAttrGetter ReadAV@NULL (4cf97a4f3ebe8006a2f5ffcc5bc10aeb)
https://bugs.webkit.org/show_bug.cgi?id=49331

Test: svg/dom/SVGPolygonElement-baseVal-list-removal-crash.html

  • svg/properties/SVGListProperty.h: (WebCore::SVGListProperty::replaceItemValuesAndWrappers): Avoid premature deletion of 'oldItem'. (WebCore::SVGListProperty::removeItemValuesAndWrappers): Ditto.

2010-11-11 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

chrome.dll!WebCore::SVGLengthInternal::valueInSpecifiedUnitsAttrGetter ReadAV@NULL (4cf97a4f3ebe8006a2f5ffcc5bc10aeb)
https://bugs.webkit.org/show_bug.cgi?id=49331

  • svg/dom/SVGPolygonElement-baseVal-list-removal-crash-expected.txt: Added.
  • svg/dom/SVGPolygonElement-baseVal-list-removal-crash.html: Added.
04:38 Changeset [71804] by andreas.kling@nokia.com

2010-11-11 Kenneth Rohde Christiansen <kenneth@webkit.org>

Reviewed by Andreas Kling.

Make it possible to override the visibleContentRect in the case the
client is handling the scrolling. This is similar to what the iPhone does.

  • platform/ScrollView.cpp: (WebCore::ScrollView::visibleContentRect):
  • platform/ScrollView.h: (WebCore::ScrollView::setActualVisibleContentRect):
04:32 Changeset [71803] by andreas.kling@nokia.com

2010-11-11 Andreas Kling <kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

FrameView: Don't clip to visibleContentRect in paintEntireContents mode
https://bugs.webkit.org/show_bug.cgi?id=49375

Use paintEntireContents in combination with tiling, allowing to
actually set visibleContentRect to something different from
the actual contents size.

  • Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::updateResizesToContentsForPage):
  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::transitionToCommittedForNewPage):

2010-11-11 Andreas Kling <kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

FrameView: Don't clip to visibleContentRect in paintEntireContents mode
https://bugs.webkit.org/show_bug.cgi?id=49375

In paintEntireContents mode (used in combination with tiling) we
cannot clip to the actual visibleContentRect as the clipped regions
will not be updated again on scroll. If paintsEntireContents is
enabled, return the actual content rect.

  • page/FrameView.cpp: (WebCore::FrameView::windowClipRect):
03:20 Changeset [71802] by zimmermann@webkit.org

2010-11-10 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Convert SVGMatrix/SVGTransform/SVGTransformList to the new SVGPropertyTearOff concept
https://bugs.webkit.org/show_bug.cgi?id=49311

Move the last list type, SVGTransformList, and the last POD types, SVGMatrix & SVGTransform, over to the new SVGPropertyTearOff concept.
Removes the need for a custom JSSVGMatrix/V8SVGMatrix implementation, it's all integrated within the bindings now.

Tests: svg/W3C-SVG-1.1-SE/coords-dom-01-f.svg

svg/W3C-SVG-1.1-SE/coords-dom-02-f.svg
svg/W3C-SVG-1.1-SE/coords-dom-03-f.svg
svg/W3C-SVG-1.1-SE/coords-dom-04-f.svg
svg/W3C-SVG-1.1-SE/types-dom-01-b.svg
svg/W3C-SVG-1.1-SE/types-dom-02-f.svg
svg/W3C-SVG-1.1-SE/types-dom-03-b.svg
svg/W3C-SVG-1.1-SE/types-dom-04-b.svg
svg/W3C-SVG-1.1-SE/types-dom-05-b.svg
svg/dom/SVGMatrix.html
svg/dom/SVGTransform.html
svg/dom/SVGTransformList.html

  • Android.jscbindings.mk: Removed JSSVGMatrixCustom.cpp.
  • Android.v8bindings.mk: Removed V8SVGMatrixCustom.cpp.
  • CMakeLists.txt: Remove JSSVGMatrixCustom.cpp.
  • GNUmakefile.am: Ditto. Add SVGAnimatedTransformListPropertyTearOff.h/SVGStaticPropertyWithParentTearOff.h/SVGTransformListPropertyTearOff.h/SVGAnimatedTransformList.h/SVGMatrix.h to build.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • bindings/js/JSBindingsAllInOne.cpp: Remove JSSVGMatrixCustom.cpp
  • bindings/js/JSSVGMatrixCustom.cpp: Removed.
  • bindings/scripts/CodeGenerator.pm: Convert SVGMatrix/SVGTransform/SVGTransformList to the new concept.
  • bindings/scripts/CodeGeneratorJS.pm: Ditto.
  • bindings/scripts/CodeGeneratorObjC.pm: Ditto.
  • bindings/scripts/CodeGeneratorV8.pm: Ditto.
  • bindings/v8/custom/V8SVGMatrixCustom.cpp: Removed.
  • svg/DeprecatedSVGAnimatedPropertyTraits.h: Remove SVGTransformList handling.
  • svg/DeprecatedSVGAnimatedTemplate.h: Ditto.
  • svg/SVGAnimateTransformElement.cpp: Adapt to SVGTransformList API changes. (WebCore::transformListFor): (WebCore::SVGAnimateTransformElement::resetToBaseValue): (WebCore::SVGAnimateTransformElement::calculateAnimatedValue): (WebCore::SVGAnimateTransformElement::applyResultsToTarget):
  • svg/SVGAnimatedTransformList.h: Added.
  • svg/SVGGradientElement.cpp: Ditto. (WebCore::SVGGradientElement::SVGGradientElement): (WebCore::SVGGradientElement::parseMappedAttribute):
  • svg/SVGGradientElement.h: Ditto.
  • svg/SVGLinearGradientElement.cpp: Ditto. (WebCore::SVGLinearGradientElement::collectGradientAttributes):
  • svg/SVGMatrix.h: Added. SVGMatrix inherits from AffineTransform, and is only used in the bindings. It implements SVGs special requirements. (WebCore::SVGMatrix::translate): Returns a copy of the matrix, not affecting the original matrix. (WebCore::SVGMatrix::scale): Ditto. (WebCore::SVGMatrix::scaleNonUniform): Ditto. (WebCore::SVGMatrix::rotate): Ditto. (WebCore::SVGMatrix::flipX): Ditto. (WebCore::SVGMatrix::flipY): Ditto. (WebCore::SVGMatrix::skewX): Ditto. (WebCore::SVGMatrix::skewY): Ditto. (WebCore::SVGMatrix::multiply): Ditto. (WebCore::SVGMatrix::inverse): Ditto. (WebCore::SVGMatrix::rotateFromVector): Dittto.
  • svg/SVGMatrix.idl: Enable StrictTypeChecking/RequiresAllArguments=Raise on all attributes/functions.
  • svg/SVGPatternElement.cpp: Adapt to SVGTransformList API changes. (WebCore::SVGPatternElement::SVGPatternElement): (WebCore::SVGPatternElement::parseMappedAttribute): (WebCore::SVGPatternElement::collectPatternAttributes):
  • svg/SVGPatternElement.h: Ditto.
  • svg/SVGPoint.idl: Enable StrictTypeChecking/RequiresAllArguments=Raise for 'matrixTransform', now that SVGMatrix has been converted to the new scheme.
  • svg/SVGRadialGradientElement.cpp: Adapt to SVGTransformList API changes. (WebCore::SVGRadialGradientElement::collectGradientAttributes):
  • svg/SVGSVGElement.cpp: Ditto. (WebCore::SVGSVGElement::createSVGTransformFromMatrix): (WebCore::SVGSVGElement::viewBoxToViewTransform):
  • svg/SVGSVGElement.h: Ditto.
  • svg/SVGStyledTransformableElement.cpp: Ditto. (WebCore::SVGStyledTransformableElement::SVGStyledTransformableElement): (WebCore::SVGStyledTransformableElement::animatedLocalTransform): (WebCore::SVGStyledTransformableElement::parseMappedAttribute):
  • svg/SVGStyledTransformableElement.h: Ditto.
  • svg/SVGTextElement.cpp: Ditto. (WebCore::SVGTextElement::SVGTextElement): (WebCore::SVGTextElement::parseMappedAttribute): (WebCore::SVGTextElement::animatedLocalTransform):
  • svg/SVGTextElement.h: Ditto.
  • svg/SVGTransform.cpp: Modernize code, inlined some getters. (WebCore::SVGTransform::SVGTransform): (WebCore::SVGTransform::setMatrix):
  • svg/SVGTransform.h: Reindent header. (WebCore::SVGTransform::type): (WebCore::SVGTransform::svgMatrix): (WebCore::SVGTransform::matrix): (WebCore::SVGTransform::angle): (WebCore::SVGTransform::rotationCenter): (WebCore::SVGTransform::isValid): (WebCore::operator==): Avoid function calls, make operator== a friend of SVGTransform, and compare members directly. (WebCore::operator!=):
  • svg/SVGTransform.idl:
  • svg/SVGTransformList.cpp: Rewritten as plain Vector<SVGTransform>. (WebCore::SVGTransformList::createSVGTransformFromMatrix): (WebCore::SVGTransformList::consolidate): (WebCore::SVGTransformList::concatenate): (WebCore::SVGTransformList::valueAsString):
  • svg/SVGTransformList.h: (WebCore::SVGTransformList::SVGTransformList):
  • svg/SVGTransformList.idl: Enable StrictTypeChecking/RequiresAllArguments=Raise on all attributes/functions.
  • svg/SVGTransformable.cpp: Adapt to SVGTransformList API changes. (WebCore::SVGTransformable::parseTransformAttribute):
  • svg/SVGTransformable.h: Ditto.
  • svg/SVGViewSpec.cpp: Ditto. (WebCore::SVGViewSpec::SVGViewSpec): (WebCore::SVGViewSpec::setTransform): (WebCore::SVGViewSpec::parseViewSpec):
  • svg/SVGViewSpec.h: Ditto. (WebCore::SVGViewSpec::transform):
  • svg/properties/SVGAnimatedListPropertyTearOff.h: Made constructor and members protected.
  • svg/properties/SVGAnimatedPropertyMacros.h: Add new helper macro DECLARE_ANIMATED_TRANSFORM_LIST_PROPERTY. This is needed until we expand all macros.
  • svg/properties/SVGAnimatedTransformListPropertyTearOff.h: Added. Extends SVGAnimatedListPropertyTearOff, returning SVGTransformListPropertyTearOff objects. (WebCore::SVGAnimatedTransformListPropertyTearOff::baseVal): (WebCore::SVGAnimatedTransformListPropertyTearOff::animVal): (WebCore::SVGAnimatedTransformListPropertyTearOff::create): (WebCore::SVGAnimatedTransformListPropertyTearOff::SVGAnimatedTransformListPropertyTearOff):
  • svg/properties/SVGListPropertyTearOff.h: Made construct and members protected.
  • svg/properties/SVGProperty.h: Declare commitChange() as pure virtual method.
  • svg/properties/SVGPropertyTraits.h: Handle SVGTransformList.
  • svg/properties/SVGStaticPropertyWithParentTearOff.h: Added. Same concept as JSSVGStaticPODTypeWrapperWithParent, used to expose SVGPropertyTearOffs for types

that are using this concept themselves. (SVGMatrix attribute of SVGTransform, both are POD types, using SVGPropertyTearOff).

(WebCore::SVGStaticPropertyWithParentTearOff::create):
(WebCore::SVGStaticPropertyWithParentTearOff::commitChange):
(WebCore::SVGStaticPropertyWithParentTearOff::SVGStaticPropertyWithParentTearOff):

  • svg/properties/SVGTransformListPropertyTearOff.h: Added. Extends SVGListPropertyTearOff by two special SVGTransformList methods: consolidate and createSVGTransformFromMatrix. (WebCore::SVGTransformListPropertyTearOff::create): (WebCore::SVGTransformListPropertyTearOff::createSVGTransformFromMatrix): (WebCore::SVGTransformListPropertyTearOff::consolidate): (WebCore::SVGTransformListPropertyTearOff::SVGTransformListPropertyTearOff):

2010-11-10 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Convert SVGMatrix/SVGTransform/SVGTransformList to the new SVGPropertyTearOff concept
https://bugs.webkit.org/show_bug.cgi?id=49311

Add tests covering StrictTypeChecking and RequiresAllArguments=Raise for SVGMatrix/SVGPoint.
Imported several new tests from SVG 1.1 2nd Edition, regarding SVG DOM primitives.

  • platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.checksum: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.png: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.txt: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.checksum: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.png: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.txt: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.checksum: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.png: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.txt: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.checksum: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.png: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.txt: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.checksum: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.png: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.checksum: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.png: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.txt: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.checksum: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.png: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.txt: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.checksum: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.png: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.checksum: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.png: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt: Added.
  • svg/W3C-SVG-1.1-SE/coords-dom-01-f.svg: Added.
  • svg/W3C-SVG-1.1-SE/coords-dom-02-f.svg: Added.
  • svg/W3C-SVG-1.1-SE/coords-dom-03-f.svg: Added.
  • svg/W3C-SVG-1.1-SE/coords-dom-04-f.svg: Added.
  • svg/W3C-SVG-1.1-SE/types-dom-01-b.svg: Added.
  • svg/W3C-SVG-1.1-SE/types-dom-02-f.svg: Added.
  • svg/W3C-SVG-1.1-SE/types-dom-03-b.svg: Added.
  • svg/W3C-SVG-1.1-SE/types-dom-04-b.svg: Added.
  • svg/W3C-SVG-1.1-SE/types-dom-05-b.svg: Added.
  • svg/dom/SVGMatrix-expected.txt: Added.
  • svg/dom/SVGMatrix.html: Added.
  • svg/dom/SVGPoint-expected.txt:
  • svg/dom/SVGTransform-expected.txt: Added.
  • svg/dom/SVGTransform.html: Added.
  • svg/dom/SVGTransformList-expected.txt: Added.
  • svg/dom/SVGTransformList.html: Added.
  • svg/dom/script-tests/SVGMatrix.js: Added.
  • svg/dom/script-tests/SVGPoint.js:
  • svg/dom/script-tests/SVGTransform.js: Added.
  • svg/dom/script-tests/SVGTransformList.js: Added.
01:44 Changeset [71801] by alex@webkit.org

2010-11-11 Alejandro G. Castro <alex@igalia.com>

Reviewed by Nikolas Zimmermann.

Fixed WebKitGTK gtk3 compilation.

  • platform/gtk/WidgetRenderingContextGtk3.cpp: (WebCore::WidgetRenderingContext::WidgetRenderingContext):
00:56 Changeset [71800] by mitz@apple.com

Reverted r71975:71976. That change was wrong, and the tests caught it.

  • platform/graphics/mac/ComplexTextController.h:

(WebCore::ComplexTextController::ComplexTextRun::create):

  • platform/graphics/mac/ComplexTextControllerCoreText.cpp:

(WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun):
(WebCore::ComplexTextController::collectComplexTextRunsForCharactersCoreText):

00:25 Changeset [71799] by tkent@chromium.org

Add a test for form submission by <input type=image>
https://bugs.webkit.org/show_bug.cgi?id=49302

Reviewed by Shinichiro Hamaji.

  • fast/forms/input-image-submit-expected.txt: Added.
  • fast/forms/input-image-submit.html: Added.
00:07 Changeset [71798] by mdelaney@apple.com

2010-11-11 Matthew Delaney <mdelaney@apple.com>

Reviewed by Dan Bernstein.

Fix LayoutTests/canvas/philip/tests/2d.drawImage.null.html
https://bugs.webkit.org/show_bug.cgi?id=48307

There are no new tests because this is a fix for a pre-existing failing test.)

  • bindings/js/JSCanvasRenderingContext2DCustom.cpp: Corrected expection throwing cases to match up with spec.

11/10/10:

23:37 Changeset [71797] by rniwa@webkit.org

2010-11-10 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Adam Barth.

[HTML5] 10.2.8.4 Scripts that modify the page as it is being parsed
https://bugs.webkit.org/show_bug.cgi?id=49364

Fixed HTMLScriptRunner's executeScript to use the ScriptController of the frame to which script element belongs
as supposed to that of the frame associated with the HTMLScriptRunner.

See also: http://www.whatwg.org/specs/web-apps/current-work/#scripts-that-modify-the-page-as-it-is-being-parsed

Test: fast/parser/script-modify-page-outer.html

  • html/parser/HTMLScriptRunner.cpp: (WebCore::HTMLScriptRunner::executePendingScriptAndDispatchEvent): Calls executeScript. (WebCore::HTMLScriptRunner::executeScript): Uses the correct ScriptController instance. (WebCore::HTMLScriptRunner::runScript): Call executeScript.
  • html/parser/HTMLScriptRunner.h:

2010-11-10 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Adam Barth.

[HTML5] 10.2.8.4 Scripts that modify the page as it is being parsed
https://bugs.webkit.org/show_bug.cgi?id=49364

Added a test to ensure moving the script element to the parent document as it is being parsed
changes the script's global object to the parent document's window object.

See also: http://www.whatwg.org/specs/web-apps/current-work/#scripts-that-modify-the-page-as-it-is-being-parsed

  • fast/parser/move-during-parsing-expected.txt:
  • fast/parser/resources/script-modify-page-inner.html: Added.
  • fast/parser/script-modify-page-outer-expected.txt: Added.
  • fast/parser/script-modify-page-outer.html: Added.
21:20 Changeset [71796] by mitz@apple.com

Style fix I said I’d make then forgot to make.

  • platform/graphics/mac/ComplexTextControllerCoreText.cpp:

(WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun):

21:18 Changeset [71795] by mitz@apple.com

Allow for the possibility of CoreText generating multiple runs for a single text run.
https://bugs.webkit.org/show_bug.cgi?id=49353

Patch by Ned Holbrook <nholbrook@apple.com> on 2010-11-10
Reviewed by Dan Bernstein.

  • platform/graphics/mac/ComplexTextController.h:

(WebCore::ComplexTextController::ComplexTextRun::create):

  • platform/graphics/mac/ComplexTextControllerCoreText.cpp:

(WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun):
(WebCore::ComplexTextController::collectComplexTextRunsForCharactersCoreText):

20:58 Changeset [71794] by ukai@chromium.org

Unreviewed, updating Chromium expectations.

  • platform/chromium/test_expectations.txt:
19:09 Changeset [71793] by kbr@google.com

2010-11-10 Kenneth Russell <kbr@google.com>

Reviewed by James Robinson.

[chromium] Clean up gfx::GetGLImplementation calls in WebGraphicsContext3DDefaultImpl
https://bugs.webkit.org/show_bug.cgi?id=49336

  • src/WebGraphicsContext3DDefaultImpl.cpp: (WebKit::WebGraphicsContext3DDefaultImpl::initialize): (WebKit::WebGraphicsContext3DDefaultImpl::reshape): (WebKit::WebGraphicsContext3DDefaultImpl::readBackFramebuffer): (WebKit::WebGraphicsContext3DDefaultImpl::getIntegerv):
18:37 Changeset [71792] by commit-queue@webkit.org

2010-11-10 Chris Guillory <chris.guillory@google.com>

Reviewed by Chris Fleizach.

Use IAccessibleComparable to compare accessibility objects.
https://bugs.webkit.org/show_bug.cgi?id=49118

  • platform/win/Skipped:

2010-11-10 Chris Guillory <chris.guillory@google.com>

Reviewed by Chris Fleizach.

Use IAccessibleComparable to compare accessibility objects.
https://bugs.webkit.org/show_bug.cgi?id=49118

  • DumpRenderTree/AccessibilityUIElement.cpp: (AccessibilityUIElement::isEqual):
  • DumpRenderTree/AccessibilityUIElement.h:
  • DumpRenderTree/win/AccessibilityUIElementWin.cpp: (comparableObject): (AccessibilityUIElement::isEqual):
18:28 Changeset [71791] by mrobinson@webkit.org

2010-10-18 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Widgets do not support CSS transformations
https://bugs.webkit.org/show_bug.cgi?id=40139

Added a platform-specific baseline for the slider transformation
test. This baseline says "FAIL" because the test has platform-specific
offsets hard-coded. The result is only one tick off from expected though,
so it's likely correct for us.

  • platform/gtk/Skipped: Unskip.
  • platform/gtk/fast/forms/slider-transformed-expected.txt: Added.

2010-10-15 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Widgets do not support CSS transformations
https://bugs.webkit.org/show_bug.cgi?id=40139

Instead of rendering directly onto the target drawable when rendering
form controls on GTK+ 2.0, render onto an intermediate surface and use
cairo to blit the result back to the target surface. This has two
benefits. The first is that it always honors the current Cairo
transformation. The second is that since the intermediate drawable is
always a 32-bit GdkPixmap, we do not have to have a set of widgets
per-colormap any longer.

This change also begins the abstraction of widget rendering so that GTK+
2 and GTK+ 3 can use the same code path. The WidgetRenderingContext will
eventually hide all version differences from RenderThemeGtk, which can
just focus on interpreting the GtkStyle properties.

  • GNUmakefile.am: Add WidgetRenderinContext source files to the sources list.
  • platform/graphics/cairo/PlatformRefPtrCairo.cpp: (WTF::refPlatformPtr): Add a specialization for Cairo patterns. (WTF::derefPlatformPtr): Ditto.
  • platform/graphics/cairo/PlatformRefPtrCairo.h: Ditto.
  • platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::RenderThemeGtk): No longer keep a set of widgets per-colormap for GTK+, instead just determine if we can use RGBA colormaps and go from there. (WebCore::RenderThemeGtk::~RenderThemeGtk): Ditto. (WebCore::RenderThemeGtk::getIndicatorMetrics): Put the logic for getting toggle button indicator metrics into this helper. (WebCore::RenderThemeGtk::paintRenderObject): Now uses WidgetRenderingContext to do widget rendering. (WebCore::setToggleSize): Use the new getIndicatorMetrics helper.
  • platform/gtk/RenderThemeGtk.h: Added a member to track whether or not the widgets are using a RGBA colormap. Also remove a defunct Page* member.
  • platform/gtk/ScrollbarThemeGtk.cpp: Switch all widget drawing operations to use WidgetRenderingContext. (WebCore::ScrollbarThemeGtk::paintTrackBackground): Ditto. (WebCore::ScrollbarThemeGtk::paintScrollbarBackground): Ditto. (WebCore::ScrollbarThemeGtk::paintThumb): Ditto. (WebCore::ScrollbarThemeGtk::paint): Ditto. (WebCore::ScrollbarThemeGtk::paintButton): Ditto.
  • platform/gtk/WidgetRenderingContext.h: Added.
  • platform/gtk/WidgetRenderingContextGtk2.cpp: Added. (WebCore::purgeScratchBuffer): Added, this is similar to the scratch buffer implementation from ContextShadow. (WebCore::PurgeScratchBufferTimer::fired): Ditto. (WebCore::scheduleScratchBufferPurge): Ditto. (WebCore::getExtraSpaceForWidget): (WebCore::WidgetRenderingContext::WidgetRenderingContext): Added. (WebCore::WidgetRenderingContext::~WidgetRenderingContext): Added. (WebCore::WidgetRenderingContext::paintMozillaWidget): Added.
  • platform/gtk/WidgetRenderingContextGtk3.cpp: Added. (WebCore::WidgetRenderingContext::WidgetRenderingContext): Added. (WebCore::~WidgetRenderingContext::WidgetRenderingContext): Added. (WebCore::WidgetRenderingContext::paintMozillaWidget): Added.
18:00 Changeset [71790] by bdakin@apple.com

Fix for https://bugs.webkit.org/show_bug.cgi?id=49356
-[WebView _scaleWebView:] should take and origin and scroll the
document
-and corresponding-
<rdar://problem/8643921>

Reviewed by Simon Fraser.

WebCore:

Apply the scale to the origin, and set a new scroll position.

  • page/Frame.cpp:

(WebCore::Frame::scalePage):

  • page/Frame.h:
  • WebCore.exp.in:

WebKit/mac:

  • WebView/WebView.mm:

(-[WebView _scaleWebView:atOrigin:]):

  • WebView/WebViewPrivate.h:

WebKit2:

  • Shared/API/c/WKSharedAPICast.h:

(WebKit::toImpl):

  • UIProcess/API/C/WKPage.cpp:

(WKPageScaleWebView):

  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::scaleWebView):

  • UIProcess/WebPageProxy.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::scaleWebView):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
17:19 Changeset [71789] by mihaip@chromium.org

2010-11-10 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium rebaselines.

Rebaseline fast/lists/001-vertical.html and fast/lists/008-vertical.html
with the chromium-mac scrollbars.

Rest of fast/lists/00*-vertical.html tests fail due to bug 48634,
add them to that grouping.

  • platform/chromium-mac/fast/lists/001-vertical-expected.checksum: Added.
  • platform/chromium-mac/fast/lists/001-vertical-expected.png: Added.
  • platform/chromium-mac/fast/lists/008-vertical-expected.checksum: Added.
  • platform/chromium-mac/fast/lists/008-vertical-expected.png: Added.
  • platform/chromium/test_expectations.txt:
17:16 Changeset [71788] by adachan@apple.com

Fix Windows build.

  • win/WebKit2Generated.make:
17:11 Changeset [71787] by mitz@apple.com

REGRESSION (r71566): r71566 breaks bidi-control-chars-treated-as-ZWS.html
https://bugs.webkit.org/show_bug.cgi?id=49295

Reviewed by Darin Adler.

WebCore:

  • platform/graphics/mac/ComplexTextControllerATSUI.cpp: Reverted to r71565. Eliding bidi

control characters from ATSUI is no longer necessary since ComplexTextController removes
any glyphs corresponding to them.
(WebCore::ComplexTextController::ComplexTextRun::overrideLayoutOperation):
(WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun):

LayoutTests:

  • platform/mac-leopard/fast/text/international/bidi-neutral-run-expected.txt:
17:02 Changeset [71786] by mihaip@chromium.org

2010-11-10 Mihai Parparita <mihaip@chromium.org>

Unreviewed removal of unncessary Qt baseline (atfer r71781 Qt should
use the base one).

  • platform/qt/svg/animations/repeatDur-zero-expected.txt: Removed.
17:01 Changeset [71785] by estade@chromium.org

Merge 71774 - 2010-11-10 Evan Stade <estade@chromium.org>

Reviewed by Tony Chang.

[chromium] menu key doesn't work when capslock or numslock is on
https://bugs.webkit.org/show_bug.cgi?id=49289

Add a special bitmask for the "input" modifier keys (shift, alt, crtl, meta). The Modifier
enum has grown to something that might be better termed State, but changing the nomenclature
now is difficult. The bitmask gets its name from the related function getWebInputModifiers.

  • public/WebInputEvent.h: add InputModifiers mask for true modifier keys
  • src/WebViewImpl.cpp: disregard non-modifier keys (WebKit::WebViewImpl::keyEvent):

TBR=estade@chromium.org

16:48 Changeset [71784] by commit-queue@webkit.org

2010-11-10 Pascal Massimino <pascal.massimino@gmail.com>

Reviewed by Adam Barth.

add test case for png where each row has or hasn't alpha values.
This is to exercise code logic within PNGImageDecoder.cpp

https://bugs.webkit.org/show_bug.cgi?id=49333

  • fast/images/png_per_row_alpha_decoding-expected.png: Added.
  • fast/images/png_per_row_alpha_decoding-expected.txt: Added.
  • fast/images/png_per_row_alpha_decoding.html: Added.
  • fast/images/resources/png_per_row_alpha.png: Added.

2010-11-10 Pascal Massimino <pascal.massimino@gmail.com>

Reviewed by Adam Barth.

Simplify the alpha-detection code in png's decoding loop.
https://bugs.webkit.org/show_bug.cgi?id=49333

Added a special test for this case: png_per_row_alpha_decoding.html

  • platform/image-decoders/png/PNGImageDecoder.cpp: (WebCore::PNGImageDecoder::rowAvailable): modified loop.
16:40 Changeset [71783] by mitz@apple.com

<rdar://problem/8647848> REGRESSION (r68551): Spaces shown at soft hyphens with complex justification
https://bugs.webkit.org/show_bug.cgi?id=49352

Reviewed by Simon Fraser.

WebCore:

Test: fast/text/justification-padding-mid-word.html

  • platform/graphics/mac/ComplexTextController.cpp:

(WebCore::ComplexTextController::adjustGlyphsAndAdvances): Changed to add justification padding
and word spacing only at characters that are treated as space, instead of all characters that
use the space glyph (which includes characters treated as zero-width space as well).

LayoutTests:

  • fast/text/justification-padding-mid-word-expected.txt: Added.
  • fast/text/justification-padding-mid-word.html: Added.
16:31 Changeset [71782] by simon.fraser@apple.com

2010-11-10 Simon Fraser <simon.fraser@apple.com>

Reviewed by Anders Carlsson.

Misc drawing area cleanup
https://bugs.webkit.org/show_bug.cgi?id=49349

  • UIProcess/LayerBackedDrawingAreaProxy.cpp: (WebKit::LayerBackedDrawingAreaProxy::setSize): (WebKit::LayerBackedDrawingAreaProxy::setPageIsVisible): (WebKit::LayerBackedDrawingAreaProxy::update): Call process()->send() instead of process()->connection()->send() in case the web process has not been launched yet.
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::WebPage): Delay creation of the drawing area until after other WebPage state has been initialized, in case the DrawingArea creation needs to call back to the WebPage.
16:29 Changeset [71781] by mihaip@chromium.org

2010-11-10 Mihai Parparita <mihaip@chromium.org>

Reviewed by Simon Fraser.

svg/animations/repeatDur-zero.xhtml should use dumpAsText
https://bugs.webkit.org/show_bug.cgi?id=49348

Per r71066 (which added the test), all that we're testing for is whether
or not we hang, therefore using dumpAsText is better (since then we
don't need per-platform baselines).

  • platform/chromium/test_expectations.txt:
  • platform/mac/svg/animations/repeatDur-zero-expected.txt: Removed.
  • svg/animations/repeatDur-zero-expected.txt: Added.
  • svg/animations/repeatDur-zero.xhtml:
16:22 Changeset [71780] by simon.fraser@apple.com

2010-11-10 Simon Fraser <simon.fraser@apple.com>

Reviewed by Adam Roben.

Push m_viewSize down to DrawingAreaProxy base class
https://bugs.webkit.org/show_bug.cgi?id=49347

Some refactoring so that the various drawing area classes
can share m_size.

  • UIProcess/ChunkedUpdateDrawingAreaProxy.cpp: (WebKit::ChunkedUpdateDrawingAreaProxy::setSize):
  • UIProcess/ChunkedUpdateDrawingAreaProxy.h:
  • UIProcess/DrawingAreaProxy.h: (WebKit::DrawingAreaProxy::setSize): (WebKit::DrawingAreaProxy::size):
  • UIProcess/LayerBackedDrawingAreaProxy.cpp: (WebKit::LayerBackedDrawingAreaProxy::setSize):
  • UIProcess/LayerBackedDrawingAreaProxy.h:
  • UIProcess/mac/ChunkedUpdateDrawingAreaProxyMac.mm: (WebKit::ChunkedUpdateDrawingAreaProxy::ensureBackingStore): (WebKit::ChunkedUpdateDrawingAreaProxy::drawUpdateChunkIntoBackingStore):
  • UIProcess/mac/LayerBackedDrawingAreaProxyMac.mm: (WebKit::LayerBackedDrawingAreaProxy::platformSetSize): (WebKit::LayerBackedDrawingAreaProxy::attachCompositingContext):
  • UIProcess/win/ChunkedUpdateDrawingAreaProxyWin.cpp: (WebKit::ChunkedUpdateDrawingAreaProxy::ensureBackingStore):
  • UIProcess/qt/ChunkedUpdateDrawingAreaProxyQt.cpp: (WebKit::ChunkedUpdateDrawingAreaProxy::ensureBackingStore):
16:22 Changeset [71779] by mihaip@chromium.org

2010-11-10 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium rebaselines.

Add missing Mac, Windows and Linux baselines (no actual Linux baselines
are included, the Windows ones are also used for it).

  • platform/chromium-mac/fast/blockflow/background-horizontal-bt-expected.checksum:
  • platform/chromium-mac/fast/blockflow/background-horizontal-bt-expected.png: Added.
  • platform/chromium-mac/fast/blockflow/background-vertical-lr-expected.checksum:
  • platform/chromium-mac/fast/blockflow/background-vertical-lr-expected.png: Added.
  • platform/chromium-win/fast/blockflow/background-horizontal-bt-expected.checksum: Added.
  • platform/chromium-win/fast/blockflow/background-horizontal-bt-expected.png: Added.
  • platform/chromium-win/fast/blockflow/background-horizontal-bt-expected.txt: Added.
  • platform/chromium-win/fast/blockflow/background-vertical-lr-expected.checksum: Added.
  • platform/chromium-win/fast/blockflow/background-vertical-lr-expected.png: Added.
  • platform/chromium-win/fast/blockflow/background-vertical-lr-expected.txt: Added.
  • platform/chromium-win/fast/blockflow/background-vertical-rl-expected.checksum: Added.
  • platform/chromium-win/fast/blockflow/background-vertical-rl-expected.png: Added.
  • platform/chromium-win/fast/blockflow/background-vertical-rl-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
16:00 Changeset [71778] by mihaip@chromium.org

2010-11-10 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium rebaseline.

Add back text expectation mistakenly removed by r71773.

  • platform/chromium-mac/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.txt: Added.
15:34 Changeset [71777] by mihaip@chromium.org

2010-11-10 Mihai Parparita <mihaip@chromium.org>

Unreviewed Leopard rebaseline.

Rebaseline fast/text/international/bidi-neutral-run.html after r71763.

  • platform/mac-leopard/fast/text/international/bidi-neutral-run-expected.txt:
15:08 Changeset [71776] by tony@chromium.org

2010-11-10 Tony Chang <tony@chromium.org>

Reviewed by Darin Adler.

plugins/npruntime/enumerate.html shouldn't depend on object enumeration order
https://bugs.webkit.org/show_bug.cgi?id=49338

The ES spec doesn't specify the order, so the test shouldn't depend on it.
Unfortunately, the test still fails in Chromium.

  • platform/chromium/test_expectations.txt:
  • plugins/npruntime/enumerate.html:
14:49 Changeset [71775] by senorblanco@chromium.org

2010-11-10 Stephen White <senorblanco@chromium.org>

Unreviewed; test expectations and baselines.

[chromium] Clean up test_expectations from my lazy gardening. One
new baseline. Remove expectations for many-layers.html (which itself
was removed in r71577).

  • platform/chromium-gpu/test_expectations.txt:
  • platform/chromium-linux/fast/text/midword-break-after-breakable-char-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
14:47 Changeset [71774] by estade@chromium.org

2010-11-10 Evan Stade <estade@chromium.org>

Reviewed by Tony Chang.

[chromium] menu key doesn't work when capslock or numslock is on
https://bugs.webkit.org/show_bug.cgi?id=49289

Add a special bitmask for the "input" modifier keys (shift, alt, crtl, meta). The Modifier
enum has grown to something that might be better termed State, but changing the nomenclature
now is difficult. The bitmask gets its name from the related function getWebInputModifiers.

  • public/WebInputEvent.h: add InputModifiers mask for true modifier keys
  • src/WebViewImpl.cpp: disregard non-modifier keys (WebKit::WebViewImpl::keyEvent):
14:44 Changeset [71773] by mihaip@chromium.org

2010-11-10 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium rebaseline.

Update chromium-mac baselines after r71763.

  • platform/chromium-mac/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.checksum:
  • platform/chromium-mac/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.png:
  • platform/chromium-mac/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.txt: Removed.
  • platform/chromium-mac/fast/text/international/bidi-neutral-run-expected.txt:
14:44 Changeset [71772] by mdelaney@apple.com

2010-11-10 Matthew Delaney <mdelaney@apple.com>

Reviewed by Darin Adler.

Crash in documentWillBecomeInactive() when closing window with Reader showing content with SVG
https://bugs.webkit.org/show_bug.cgi?id=49084

Manual test added.

  • manual-tests/svg-deep-clone-to-new-doc.html: Added manual test for reproducing bug since an automated version proved to be a bit tough to craft up.
  • svg/SVGSVGElement.cpp: Added in necessary document ownership transfer calls.
  • svg/SVGSVGElement.h:
14:32 Changeset [71771] by pfeldman@chromium.org

2010-11-10 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Red error bubbles don't fit content.
https://bugs.webkit.org/show_bug.cgi?id=49305

  • inspector/front-end/textViewer.css: (.webkit-html-message-bubble):
14:07 Changeset [71770] by ap@apple.com

https://bugs.webkit.org/show_bug.cgi?id=45205
<rdar://problem/8391455> Detached elements shouldn't have style sheets.

Land test files I missed in original check-in.

  • fast/dom/StyleSheet/resources: Added.
  • fast/dom/StyleSheet/resources/detached-style.css: Added.
13:38 Changeset [71769] by ap@apple.com

Release build fix.

  • css/StyleSheet.cpp: isAcceptableStyleSheetParent() is a debug-only function.
13:16 Changeset [71768] by senorblanco@chromium.org

2010-11-10 Stephen White <senorblanco@chromium.org>

Unreviewed; updated test baselines.

Updated chromium-win tests affected slightly by
http://trac.webkit.org/changeset/71760.

  • platform/chromium-win/svg/W3C-SVG-1.1/filters-color-01-b-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-specular-01-f-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-specular-01-f-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-turb-01-f-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-turb-01-f-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-turb-02-f-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-turb-02-f-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.checksum:
  • platform/chromium-win/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.checksum:
  • platform/chromium-win/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.checksum:
  • platform/chromium-win/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.checksum:
  • platform/chromium-win/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-dom-baseFrequency-attr-expected.checksum:
  • platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-dom-baseFrequency-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-dom-numOctaves-attr-expected.checksum:
  • platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-dom-numOctaves-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-dom-seed-attr-expected.checksum:
  • platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-dom-seed-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-dom-stitchTiles-attr-expected.checksum:
  • platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-dom-stitchTiles-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-dom-type-attr-expected.checksum:
  • platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-dom-type-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-numOctaves-prop-expected.checksum:
  • platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-numOctaves-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-seed-prop-expected.checksum:
  • platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-seed-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-stitchTiles-prop-expected.checksum:
  • platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-stitchTiles-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-type-prop-expected.checksum:
  • platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-type-prop-expected.png:
  • platform/chromium-win/svg/filters/feLighting-crash-expected.checksum:
  • platform/chromium-win/svg/filters/feLighting-crash-expected.png:
13:12 Changeset [71767] by ap@apple.com

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=45205
<rdar://problem/8391455> Detached elements shouldn't have style sheets.

Tests: fast/dom/StyleSheet/detached-style-2.html

fast/dom/StyleSheet/detached-style-pi.xhtml
fast/dom/StyleSheet/detached-style.html
fast/dom/StyleSheet/detached-style-pi-2.xhtml

  • bindings/js/JSStyleSheetCustom.cpp: (WebCore::JSStyleSheet::markChildren): There is no longer a need to mark owner nodes - StyleSheet->ownerNode() is only non-null when the node is in document.
  • css/StyleSheet.cpp: (WebCore::StyleSheet::StyleSheet): Added an assertion checking that all nodes that can be StyleSheet parents have been verified.
  • css/StyleSheet.h: (WebCore::StyleSheet::clearOwnerNode): Added.
  • dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::~ProcessingInstruction): Clear stylesheet's owner node. This shouldn't have observable effect, since a processing instruction that is in document can only be destroyed with document, and a reachable stylsheet keeps document alive. (WebCore::ProcessingInstruction::removedFromDocument): Clear the relationship between node and style sheet when removed. (WebCore::ProcessingInstruction::setCSSStyleSheet): If the element was removed during load, we still don't want to create a style sheet.
  • dom/StyleElement.cpp: (WebCore::StyleElement::sheet): There is no reason for lazy creation. It was a wrong fix for bug 14462, whose regression test still passes. (WebCore::StyleElement::removedFromDocument): Clear the relationship between node and style sheet when removed. (WebCore::StyleElement::finishParsingChildren): Don't call sheet(), it doens't have side effects any more. (WebCore::StyleElement::createSheet): Assert that the element is in document. We never want to create a style sheet for an element that isn't.
  • dom/StyleElement.h: (WebCore::StyleElement::sheet): Made implementation inline, now that it's a simple getter.
  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::~HTMLLinkElement): Clear stylesheet's owner node. (WebCore::HTMLLinkElement::process): Assert that there is no style sheet lingering for any reason. (WebCore::HTMLLinkElement::removedFromDocument): Clear the relationship between node and style sheet when removed. (WebCore::HTMLLinkElement::setCSSStyleSheet): If the element was removed during load, we still don't want to create a style sheet.
  • html/HTMLStyleElement.cpp: (WebCore::HTMLStyleElement::~HTMLStyleElement):
  • html/HTMLStyleElement.h:
  • svg/SVGStyleElement.cpp: (WebCore::SVGStyleElement::~SVGStyleElement):
  • svg/SVGStyleElement.h: Clear stylesheet's owner node. As above, this shouldn't have observable effect.
  • xml/XSLTProcessor.h:
  • xml/XSLTProcessor.cpp: (WebCore::XSLTProcessor::~XSLTProcessor):
  • dom/Document.cpp: (WebCore::Document::~Document):
  • css/CSSParser.cpp: (WebCore::CSSParser::parseSelector): Assert that stylesheet won't outlive its owner node. We don't really use refcounting here.
13:11 Changeset [71766] by crogers@google.com

audio branch: changes made for landing in trunk

  • update Webcore.gyp with latest audio files
  • remove PassThroughPanner from WebCore.xcodeproj
  • FFMPEG file reading cleanup
  • remove obsolete pass-through panning model
  • deal with ppc and i386 vs. other architectures in calls to Accelerate.framework
  • various custom bindings cleanup
  • add ChromiumBridge loadPlatformAudioResource() and decodeAudioFileData() methods
  • add WebAudioBus thin wrapper class for use by WebKitClient::decodeAudioFileData()
  • enable WEB_AUDIO on audio branch for chrome
  • cleanup AudioBusMac, RealtimeAnalyser, RealtimeAnalyerNode, JavaScriptAudioNode, AudioProcessingEvent, ConvolverNode, AudioBufferSourceNode, AudioChannelSplitter, AudioDestinationNode, AudioGainNode
  • use Conditional=WEB_AUDIO for DOMWindow AudioContext constructor
  • include <CoreServices/CoreServices.h> in AudioFileReaderMac.cpp
  • no longer need to include "HTMLNames.h" in AudioContext.cpp
13:04 Changeset [71765] by senorblanco@chromium.org

Fixed messed-up ChangeLog.

12:55 Changeset [71764] by senorblanco@chromium.org

2010-11-10 Dan Bernstein <mitz@apple.com>

REGRESSION (r71566): r71566 breaks bidi-control-chars-treated-as-ZWS.html
https://bugs.webkit.org/show_bug.cgi?id=49295

  • platform/mac-leopard/Skipped: Re-enable the previously failing test.
12:53 Changeset [71763] by mitz@apple.com

REGRESSION (r71566): r71566 breaks bidi-control-chars-treated-as-ZWS.html
https://bugs.webkit.org/show_bug.cgi?id=49295

WebCore:

Reviewed by Dave Hyatt.

  • platform/graphics/mac/ComplexTextController.h: Added m_indexOffset.
  • platform/graphics/mac/ComplexTextControllerATSUI.cpp:

(WebCore::ComplexTextController::ComplexTextRun::overrideLayoutOperation): Use m_indexOffset
instead of computing the offset based on m_directionalOverride.
(WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun): Set m_indexOffset to
the offset between indices in m_characters and indices in the text passed to ATSUI.

LayoutTests:

  • platform/mac-leopard/Skipped: Re-enable the previously failing test.
12:44 Changeset [71762] by pfeldman@chromium.org

2010-11-10 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Gear menu floats to right edge and expands
to bottom of "Styles" section.
https://bugs.webkit.org/show_bug.cgi?id=49303

This fixes computed style's option wrapping to the next line.

  • inspector/front-end/inspector.css: (.sidebar-pane-subtitle):
12:30 Changeset [71761] by andersca@apple.com

Closing tabs sometimes crashes the WebProcess in invalidateContentsAndWindow
https://bugs.webkit.org/show_bug.cgi?id=49335
<rdar://problem/8646621>

Reviewed by Dan Bernstein.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::changeAcceleratedCompositingMode):
If we fail to send the DidChangeAcceleratedCompositing message, don't null out the
drawing area. This will happen during page teardown.

12:16 Changeset [71760] by senorblanco@chromium.org

2010-11-10 Stephen White <senorblanco@chromium.org>

Reviewed by James Robinson.

Fix canvas.putImageData(canvas.getImageData(...)) to be lossless.
https://bugs.webkit.org/show_bug.cgi?id=49330

These cycles should be lossless for valid colours. A similar fix went
into the CG port at r32878.

Covered by canvas/philip/tests/2d.imageData.put.unchanged.html.

  • platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::mulDiv255Ceil): A helper function to do (a + b + 254) / 255 without a divide. (WebCore::putImageData): Use the above helper to round up when premultiplying alpha.

2010-11-10 Stephen White <senorblanco@chromium.org>

Reviewed by James Robinson.

Mark 2d.imageData.put.unchanged.html as passing on Win/Linux.
https://bugs.webkit.org/show_bug.cgi?id=49330

  • platform/chromium/test_expectations.txt:
11:29 Changeset [71759] by mihaip@chromium.org

2010-11-10 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium Mac rebaselines.

Add Chromium Mac baselines for tests added by r71382 (since they have
scrollbars they can't use the upstream Mac baselines).

  • platform/chromium-mac/fast/table/027-vertical-expected.checksum: Added.
  • platform/chromium-mac/fast/table/027-vertical-expected.png: Added.
  • platform/chromium-mac/fast/table/028-vertical-expected.checksum: Added.
  • platform/chromium-mac/fast/table/028-vertical-expected.png: Added.
  • platform/chromium-mac/fast/table/038-vertical-expected.checksum: Added.
  • platform/chromium-mac/fast/table/038-vertical-expected.png: Added.
  • platform/chromium-mac/fast/table/040-vertical-expected.checksum: Added.
  • platform/chromium-mac/fast/table/040-vertical-expected.png: Added.
  • platform/chromium-mac/fast/table/border-collapsing/002-vertical-expected.checksum: Added.
  • platform/chromium-mac/fast/table/border-collapsing/002-vertical-expected.png: Added.
  • platform/chromium-mac/fast/table/border-collapsing/004-vertical-expected.checksum: Added.
  • platform/chromium-mac/fast/table/border-collapsing/004-vertical-expected.png: Added.
  • platform/chromium-mac/fast/table/border-collapsing/equal-precedence-resolution-vertical-expected.checksum: Added.
  • platform/chromium-mac/fast/table/border-collapsing/equal-precedence-resolution-vertical-expected.png: Added.
  • platform/chromium-mac/fast/table/height-percent-test-vertical-expected.checksum: Added.
  • platform/chromium-mac/fast/table/height-percent-test-vertical-expected.png: Added.
  • platform/chromium-mac/fast/table/table-display-types-vertical-expected.checksum: Added.
  • platform/chromium-mac/fast/table/table-display-types-vertical-expected.png: Added.
  • platform/chromium/test_expectations.txt:
11:18 Changeset [71758] by tony@chromium.org

2010-11-10 Tony Chang <tony@chromium.org>

Unreviewed, update DRT Chromium Mac plugin test results.
This matches the past 2 runs on the bot.

  • platform/chromium/drt_expectations.txt:
11:11 Changeset [71757] by mihaip@chromium.org

2010-11-10 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium Mac rebaselines.

Rebaseline css1/ and css2.1/ (because of scrollbar display diferences).

  • platform/chromium-mac/css1/cascade/cascade_order-expected.checksum: Added.
  • platform/chromium-mac/css1/cascade/cascade_order-expected.png: Added.
  • platform/chromium-mac/css1/classification/display-expected.checksum: Added.
  • platform/chromium-mac/css1/classification/display-expected.png: Added.
  • platform/chromium-mac/css1/classification/list_style_type-expected.checksum: Added.
  • platform/chromium-mac/css1/classification/list_style_type-expected.png: Added.
  • platform/chromium-mac/css1/classification/white_space-expected.checksum: Added.
  • platform/chromium-mac/css1/classification/white_space-expected.png: Added.
  • platform/chromium-mac/css1/color_and_background/background-expected.checksum: Added.
  • platform/chromium-mac/css1/color_and_background/background-expected.png: Added.
  • platform/chromium-mac/css1/color_and_background/background_attachment-expected.checksum: Added.
  • platform/chromium-mac/css1/color_and_background/background_attachment-expected.png: Added.
  • platform/chromium-mac/css1/color_and_background/background_position-expected.checksum: Added.
  • platform/chromium-mac/css1/color_and_background/background_position-expected.png: Added.
  • platform/chromium-mac/css1/color_and_background/background_repeat-expected.checksum: Added.
  • platform/chromium-mac/css1/color_and_background/background_repeat-expected.png: Added.
  • platform/chromium-mac/css1/conformance/forward_compatible_parsing-expected.checksum: Added.
  • platform/chromium-mac/css1/conformance/forward_compatible_parsing-expected.png: Added.
  • platform/chromium-mac/css1/font_properties/font-expected.checksum: Added.
  • platform/chromium-mac/css1/font_properties/font-expected.png: Added.
  • platform/chromium-mac/css1/font_properties/font_size-expected.checksum: Added.
  • platform/chromium-mac/css1/font_properties/font_size-expected.png: Added.
  • platform/chromium-mac/css1/font_properties/font_weight-expected.checksum: Added.
  • platform/chromium-mac/css1/font_properties/font_weight-expected.png: Added.
  • platform/chromium-mac/css1/formatting_model/floating_elements-expected.checksum: Added.
  • platform/chromium-mac/css1/formatting_model/floating_elements-expected.png: Added.
  • platform/chromium-mac/css1/formatting_model/height_of_lines-expected.checksum: Added.
  • platform/chromium-mac/css1/formatting_model/height_of_lines-expected.png: Added.
  • platform/chromium-mac/css1/formatting_model/horizontal_formatting-expected.checksum: Added.
  • platform/chromium-mac/css1/formatting_model/horizontal_formatting-expected.png: Added.
  • platform/chromium-mac/css1/formatting_model/inline_elements-expected.checksum: Added.
  • platform/chromium-mac/css1/formatting_model/inline_elements-expected.png: Added.
  • platform/chromium-mac/css1/formatting_model/replaced_elements-expected.checksum: Added.
  • platform/chromium-mac/css1/formatting_model/replaced_elements-expected.png: Added.
  • platform/chromium-mac/css1/formatting_model/vertical_formatting-expected.checksum: Added.
  • platform/chromium-mac/css1/formatting_model/vertical_formatting-expected.png: Added.
  • platform/chromium-mac/css1/pseudo/anchor-expected.checksum: Added.
  • platform/chromium-mac/css1/pseudo/anchor-expected.png: Added.
  • platform/chromium-mac/css1/pseudo/firstletter-expected.checksum: Added.
  • platform/chromium-mac/css1/pseudo/firstletter-expected.png: Added.
  • platform/chromium-mac/css1/pseudo/firstline-expected.checksum: Added.
  • platform/chromium-mac/css1/pseudo/firstline-expected.png: Added.
  • platform/chromium-mac/css1/pseudo/multiple_pseudo_elements-expected.checksum: Added.
  • platform/chromium-mac/css1/pseudo/multiple_pseudo_elements-expected.png: Added.
  • platform/chromium-mac/css1/text_properties/letter_spacing-expected.checksum: Added.
  • platform/chromium-mac/css1/text_properties/letter_spacing-expected.png: Added.
  • platform/chromium-mac/css1/text_properties/line_height-expected.checksum: Added.
  • platform/chromium-mac/css1/text_properties/line_height-expected.png: Added.
  • platform/chromium-mac/css1/text_properties/text_decoration-expected.checksum: Added.
  • platform/chromium-mac/css1/text_properties/text_decoration-expected.png: Added.
  • platform/chromium-mac/css1/text_properties/text_indent-expected.checksum: Added.
  • platform/chromium-mac/css1/text_properties/text_indent-expected.png: Added.
  • platform/chromium-mac/css1/text_properties/text_transform-expected.checksum: Added.
  • platform/chromium-mac/css1/text_properties/text_transform-expected.png: Added.
  • platform/chromium-mac/css1/text_properties/vertical_align-expected.checksum: Added.
  • platform/chromium-mac/css1/text_properties/vertical_align-expected.png: Added.
  • platform/chromium-mac/css1/text_properties/word_spacing-expected.checksum: Added.
  • platform/chromium-mac/css1/text_properties/word_spacing-expected.png: Added.
  • platform/chromium-mac/css1/units/color_units-expected.checksum: Added.
  • platform/chromium-mac/css1/units/color_units-expected.png: Added.
  • platform/chromium-mac/css1/units/length_units-expected.checksum: Added.
  • platform/chromium-mac/css1/units/length_units-expected.png: Added.
  • platform/chromium-mac/css2.1/t0803-c5502-mrgn-r-02-c-expected.checksum: Added.
  • platform/chromium-mac/css2.1/t0803-c5502-mrgn-r-02-c-expected.png: Added.
  • platform/chromium-mac/css2.1/t0803-c5505-mrgn-02-c-expected.checksum: Added.
  • platform/chromium-mac/css2.1/t0803-c5505-mrgn-02-c-expected.png: Added.
  • platform/chromium-mac/css2.1/t080301-c411-vt-mrgn-00-b-expected.checksum: Added.
  • platform/chromium-mac/css2.1/t080301-c411-vt-mrgn-00-b-expected.png: Added.
  • platform/chromium-mac/css2.1/t0905-c5525-fltclr-00-c-ag-expected.checksum: Added.
  • platform/chromium-mac/css2.1/t0905-c5525-fltclr-00-c-ag-expected.png: Added.
  • platform/chromium-mac/css2.1/t0905-c5525-fltmrgn-00-c-ag-expected.checksum: Added.
  • platform/chromium-mac/css2.1/t0905-c5525-fltmrgn-00-c-ag-expected.png: Added.
  • platform/chromium-mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.checksum: Added.
  • platform/chromium-mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png: Added.
  • platform/chromium-mac/css2.1/t0905-c5526-fltclr-00-c-ag-expected.checksum: Added.
  • platform/chromium-mac/css2.1/t0905-c5526-fltclr-00-c-ag-expected.png: Added.
  • platform/chromium-mac/css2.1/t1002-c5523-width-02-b-g-expected.checksum: Added.
  • platform/chromium-mac/css2.1/t1002-c5523-width-02-b-g-expected.png: Added.
  • platform/chromium-mac/css2.1/t1202-counters-08-b-expected.checksum: Added.
  • platform/chromium-mac/css2.1/t1202-counters-08-b-expected.png: Added.
  • platform/chromium-mac/css2.1/t1202-counters-09-b-expected.checksum: Added.
  • platform/chromium-mac/css2.1/t1202-counters-09-b-expected.png: Added.
  • platform/chromium-mac/css2.1/t140201-c535-bg-fixd-00-b-g-expected.checksum: Added.
  • platform/chromium-mac/css2.1/t140201-c535-bg-fixd-00-b-g-expected.png: Added.
  • platform/chromium-mac/css2.1/t140201-c537-bgfxps-00-c-ag-expected.checksum: Added.
  • platform/chromium-mac/css2.1/t140201-c537-bgfxps-00-c-ag-expected.png: Added.
  • platform/chromium-mac/css2.1/t1508-c527-font-07-b-expected.checksum: Added.
  • platform/chromium-mac/css2.1/t1508-c527-font-07-b-expected.png: Added.
  • platform/chromium/test_expectations.txt:
11:02 Changeset [71756] by mrobinson@webkit.org

2010-11-10 Martin Robinson <mrobinson@igalia.com>

Rebaseline a new test. The patch was posted before font
hinting was disabled in the GTK+ DRT.

  • platform/gtk/fonts/complex-text-shadows-expected.txt:
10:51 Changeset [71755] by mihaip@chromium.org

2010-11-10 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium DRT expectations update.

  • fast/images/gif-loop-count.html fails on Linux and Mac when under the DRT.
  • Add more flaky media tests
  • Tweak video-referrer.html error output to be more useful
  • http/tests/media/video-referer.html:
  • platform/chromium/drt_expectations.txt:
10:43 Changeset [71754] by ossy@webkit.org

2010-11-10 Csaba Osztrogonác <ossy@webkit.org>

Reviewed by David Hyatt.

HTML5 Ruby support should be mandatory feature
https://bugs.webkit.org/show_bug.cgi?id=49272

Remove Ruby as optional feature.

  • Configurations/FeatureDefines.xcconfig:
  • JavaScriptCorePrefix.h:: Touch it to avoid incremental build failure on Windows.

2010-11-10 Csaba Osztrogonác <ossy@webkit.org>

Reviewed by David Hyatt.

HTML5 Ruby support should be mandatory feature
https://bugs.webkit.org/show_bug.cgi?id=49272

Remove Ruby as optional feature.

  • features.gypi:

2010-11-10 Csaba Osztrogonác <ossy@webkit.org>

Reviewed by David Hyatt.

HTML5 Ruby support should be mandatory feature
https://bugs.webkit.org/show_bug.cgi?id=49272

  • WebKitPrefix.h: Touch it to avoid incremental build failure on Windows.

2010-11-10 Csaba Osztrogonác <ossy@webkit.org>

Reviewed by David Hyatt.

HTML5 Ruby support should be mandatory feature
https://bugs.webkit.org/show_bug.cgi?id=49272

Remove Ruby as optional feature.

  • Configurations/FeatureDefines.xcconfig:

2010-11-10 Csaba Osztrogonác <ossy@webkit.org>

Reviewed by David Hyatt.

HTML5 Ruby support should be mandatory feature
https://bugs.webkit.org/show_bug.cgi?id=49272

Remove Ruby as optional feature.

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:

2010-11-10 Csaba Osztrogonác <ossy@webkit.org>

Reviewed by David Hyatt.

HTML5 Ruby support should be mandatory feature
https://bugs.webkit.org/show_bug.cgi?id=49272

Remove Ruby as optional feature.

  • Configurations/FeatureDefines.xcconfig:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCorePrefix.h: Touch WebCorePrefix.h to avoid incremental build failure on Windows.
  • config.h: Touch config.h to avoid incremental build failure on Windows.
  • features.pri:
  • html/HTMLTagNames.in:
  • rendering/RenderBlock.cpp: Remove ENABLE_RUBY guard. (WebCore::canMergeContiguousAnonymousBlocks):
  • rendering/RenderObject.cpp: Remove ENABLE_RUBY guard. (WebCore::RenderObject::createObject):
  • rendering/RenderRuby.cpp: Remove ENABLE_RUBY guard.
  • rendering/RenderRuby.h: Remove ENABLE_RUBY guard.
  • rendering/RenderRubyBase.cpp: Remove ENABLE_RUBY guard.
  • rendering/RenderRubyBase.h: Remove ENABLE_RUBY guard.
  • rendering/RenderRubyRun.cpp: Remove ENABLE_RUBY guard.
  • rendering/RenderRubyRun.h: Remove ENABLE_RUBY guard.
  • rendering/RenderRubyText.cpp: Remove ENABLE_RUBY guard.
  • rendering/RenderRubyText.h: Remove ENABLE_RUBY guard.

2010-11-10 Csaba Osztrogonác <ossy@webkit.org>

Reviewed by David Hyatt.

HTML5 Ruby support should be mandatory feature
https://bugs.webkit.org/show_bug.cgi?id=49272

Remove Ruby as optional feature.

  • cmake/OptionsEfl.cmake:
  • cmakeconfig.h.cmake:
  • configure.ac:

2010-11-10 Csaba Osztrogonác <ossy@webkit.org>

Reviewed by David Hyatt.

HTML5 Ruby support should be mandatory feature
https://bugs.webkit.org/show_bug.cgi?id=49272

Remove Ruby as optional feature.

  • Scripts/build-webkit:

2010-11-10 Csaba Osztrogonác <ossy@webkit.org>

Reviewed by David Hyatt.

HTML5 Ruby support should be mandatory feature
https://bugs.webkit.org/show_bug.cgi?id=49272

Remove Ruby as optional feature.

  • Configurations/FeatureDefines.xcconfig:
  • WebKit2Prefix.h: Touch it to avoid incremental build failure on Windows.
10:37 Changeset [71753] by commit-queue@webkit.org

2010-11-10 Adrienne Walker <enne@google.com>

Reviewed by Kenneth Russell.

Add a test for "is" tests on WebGL objects that have not been bound or
have been deleted. This currently does not work in the Chromium
command buffer or in Mesa, so is skipped there.
https://bugs.webkit.org/show_bug.cgi?id=48877

  • fast/canvas/webgl/is-object-expected.txt: Added.
  • fast/canvas/webgl/is-object.html: Added.
  • platform/chromium-gpu/test_expectations.txt:
  • platform/chromium/test_expectations.txt:
10:34 Changeset [71752] by aroben@apple.com

Print VC++ Express build logs in the same order that the projects are built

Fixes <http://webkit.org/b/49326> print-vse-failure-logs prints logs
in an unhelpful order

Reviewed by Eric Seidel.

  • Scripts/print-vse-failure-logs:

(PrintVisualStudioExpressLogs._build_order): Added. Uses
print-msvc-project-dependencies to figure out the order in which
projects are built.
(PrintVisualStudioExpressLogs._sort_buildlogs): Added. Sorts the logs
based on their build order and project name.
(PrintVisualStudioExpressLogs._obj_directory): Moved code to find the
scripts directory from here...
(PrintVisualStudioExpressLogs._scripts_directory): ...to here.
(PrintVisualStudioExpressLogs.main): Sort the logs before printing
them.

10:34 Changeset [71751] by aroben@apple.com

Only print the interesting text from VC++ Express build logs

Fixes <http://webkit.org/b/49325> It's hard to find the interesting
output from print-vse-failure-logs

Reviewed by Eric Seidel.

  • Scripts/print-vse-failure-logs: Removed unnecessary os.path import,

added newly-required imports. Removed a comment that was essentially a
FIXME, and is now fixed.
(PrintVisualStudioExpressLogs._relevant_text): Added. Uses
BeautifulSoup to extract the relevant text from the build log.
(PrintVisualStudioExpressLogs.main): Only print the relevant text.

09:59 Changeset [71750] by mrobinson@webkit.org

2010-11-10 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Complex text does not have full CSS text-shadow support
https://bugs.webkit.org/show_bug.cgi?id=45597

Add a test which verifies text-shadow on complex text for the GTK+
port. This can easily be made into a cross-platform test with baselines
for other ports.

  • platform/gtk/fonts/complex-text-shadows-expected.checksum: Added.
  • platform/gtk/fonts/complex-text-shadows-expected.png: Added.
  • platform/gtk/fonts/complex-text-shadows-expected.txt: Added.
  • platform/gtk/fonts/complex-text-shadows.html: Added.

2010-11-10 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Complex text does not have full CSS text-shadow support
https://bugs.webkit.org/show_bug.cgi?id=45597

Add ContextShadow support to FontGtk, which enables non-solid shadows
for complex text rendering.

Test: platform/gtk/fonts/complex-text-shadows.html

  • platform/graphics/gtk/FontGtk.cpp: (WebCore::destroyPangoRegion): Added this helper, which helps reduce the number of #ifdefs when dealing with GTK+ region type differences. (WebCore::getPangoRegionExtents): Ditto. (WebCore::drawGlyphsShadow): Added this helper which either renders a solid shadow manually or uses ContextShadow to render a blurry shadow. (WebCore::Font::drawComplexText): Use the new helpers.
09:45 Changeset [71749] by tony@chromium.org

2010-11-10 Tony Chang <tony@chromium.org>

Unreviewed, add libvpx as a chromium dependency.

This should fix the chromium linux build.

  • DEPS:
09:34 Changeset [71748] by alex@webkit.org

2010-11-10 Alejandro G. Castro <alex@igalia.com>

Reviewed by Martin Robinson.

[gtk] The revision r71528 causes crashes in GObjectEventListener
https://bugs.webkit.org/show_bug.cgi?id=49314

Moved the addition of the event listener to the node after calling
the constructor of the event listener. This is required beacuse
the addEventListener API receives the EventListener inside a
PassRefPtr.

  • bindings/gobject/GObjectEventListener.cpp: (WebCore::GObjectEventListener::GObjectEventListener):
  • bindings/gobject/GObjectEventListener.h: (WebCore::GObjectEventListener::addEventListener):
09:21 Changeset [71747] by weinig@apple.com

Add license to DerivedSources.make.

Reviewed by Anders Carlsson.

  • DerivedSources.make:
09:14 Changeset [71746] by weinig@apple.com

Convert client classes to use APIClient base class.
https://bugs.webkit.org/show_bug.cgi?id=49322

Reviewed by Adam Roben.

  • UIProcess/WebFormClient.cpp:

(WebKit::WebFormClient::willSubmitForm):

  • UIProcess/WebFormClient.h:
  • UIProcess/WebLoaderClient.cpp:
  • UIProcess/WebLoaderClient.h:
  • UIProcess/WebPolicyClient.cpp:
  • UIProcess/WebPolicyClient.h:
  • UIProcess/WebUIClient.cpp:
  • UIProcess/WebUIClient.h:
  • WebProcess/InjectedBundle/InjectedBundlePageContextMenuClient.cpp:
  • WebProcess/InjectedBundle/InjectedBundlePageContextMenuClient.h:
  • WebProcess/InjectedBundle/InjectedBundlePageEditorClient.cpp:
  • WebProcess/InjectedBundle/InjectedBundlePageEditorClient.h:
  • WebProcess/InjectedBundle/InjectedBundlePageFormClient.cpp:
  • WebProcess/InjectedBundle/InjectedBundlePageFormClient.h:
  • WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:
  • WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
  • WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:
  • WebProcess/InjectedBundle/InjectedBundlePageUIClient.h:
09:12 Changeset [71745] by apavlov@chromium.org

2010-11-02 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Enable InspectorCSSAgent (not used by frontend for CSS editing yet)
https://bugs.webkit.org/show_bug.cgi?id=48834

Drive-by fix: use a single API method to retrieve all node-related styles instead of a bunch of separate calls.

Test: inspector/styles-new-API.html

WebCore:

  • inspector/CodeGeneratorInspector.pm:
  • inspector/Inspector.idl:
  • inspector/InspectorCSSAgent.cpp: (WebCore::InspectorCSSAgent::InspectorCSSAgent): (WebCore::InspectorCSSAgent::setDOMAgent): (WebCore::InspectorCSSAgent::reset): (WebCore::InspectorCSSAgent::getStylesForNode2): (WebCore::InspectorCSSAgent::getComputedStyleForNode2): (WebCore::InspectorCSSAgent::addRule2): (WebCore::InspectorCSSAgent::querySelectorAll):
  • inspector/InspectorCSSAgent.h:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::releaseFrontendLifetimeAgents): (WebCore::InspectorController::didCommitLoad):
  • inspector/InspectorController.h: (WebCore::InspectorController::cssAgent):
  • inspector/InspectorDOMAgent.cpp:
  • inspector/InspectorDOMAgent.h:
  • inspector/InspectorStyleSheet.cpp: (WebCore::InspectorStyle::setPropertyText): (WebCore::InspectorStyle::styleText): (WebCore::InspectorStyle::disableProperty): (WebCore::InspectorStyle::populateAllProperties): (WebCore::InspectorStyle::populateObjectWithStyleProperties): (WebCore::InspectorStyleSheet::buildObjectForRule): (WebCore::InspectorStyleSheet::fixUnparsedPropertyRanges): (WebCore::InspectorStyleSheet::ensureSourceData): (WebCore::InspectorStyleSheetForInlineStyle::text):
  • inspector/InspectorStyleSheet.h: (WebCore::InspectorStyleProperty::setRawTextFromStyleDeclaration): (WebCore::InspectorStyleProperty::hasRawText):

LayoutTests:

  • inspector/resources/styles-new-API.css: Added. (html): (body): (/* comment before selector */body.main1/* comment after selector */): (body.main2): (body::after): (h1):
  • inspector/styles-new-API-expected.txt: Added.
  • inspector/styles-new-API.html: Added.
  • inspector/styles-source-offsets-expected.txt:
  • inspector/styles-source-offsets.html:
08:57 Changeset [71744] by inferno@chromium.org

Merge 71723

BUG=62354

08:52 Changeset [71743] by inferno@chromium.org

Merge 71724

BUG=62281

08:28 Changeset [71742] by mihaip@chromium.org

2010-11-10 Mihai Parparita <mihaip@chromium.org>

Unreviwed, updating Chromium GPU test expectations.

canvas/philip/tests/2d.pattern.image.incomplete.html was fixed by
r71718.

  • platform/chromium-gpu/test_expectations.txt:
08:27 Changeset [71741] by abecsi@webkit.org

2010-11-10 Andras Becsi <abecsi@webkit.org>

Rubber-stamped by Csaba Osztrogonác.

[Qt] Deduplicate the Skipped list entries.

  • platform/qt/Skipped:
08:13 Changeset [71740] by apavlov@chromium.org

2010-11-10 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Move CSSStyleDeclaration from DOMAgent.js into CSSStyleModel.js
https://bugs.webkit.org/show_bug.cgi?id=49312

No new tests, as it's just code motion.

08:10 Changeset [71739] by abecsi@webkit.org

2010-11-10 Andras Becsi <abecsi@webkit.org>

Unreviewed.

[Qt][WK2] http/tests/history/popstate-fires-with-pending-requests.html breaks ~400 subsequent tests
https://bugs.webkit.org/show_bug.cgi?id=49321

  • platform/qt-wk2/Skipped: Skip the tests until fix.
07:43 Changeset [71738] by mihaip@chromium.org

2010-11-10 Mihai Parparita <mihaip@chromium.org>

Unreviewed, updating Chromium baselines.

Update Chromium inspector/console-log-syntax-error.html baselines
(after r71010 the path displayed is the same as the upstream baseline).

  • platform/chromium/inspector/console-log-syntax-error-expected.txt:
  • platform/chromium/test_expectations.txt:
07:34 Changeset [71737] by mihaip@chromium.org

2010-11-10 Mihai Parparita <mihaip@chromium.org>

Unreviewed, updating Chromium Mac baselines.

  • editing/selection/extend-by-word-002.html had selection display changed (for the better) by r71700
  • fast/block/basic/truncation-rtl.html was likely checked in with Snow Leopard baselines, but chromium-mac is still on Leopard
  • tables/mozilla/bugs/bug82946-2.html needed rebaseline after r71311 switched on ICCJPEG
  • platform/chromium-mac/editing/selection/extend-by-word-002-expected.checksum: Added.
  • platform/chromium-mac/editing/selection/extend-by-word-002-expected.png: Added.
  • platform/chromium-mac/fast/block/basic/truncation-rtl-expected.checksum: Added.
  • platform/chromium-mac/fast/block/basic/truncation-rtl-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug82946-2-expected.checksum:
  • platform/chromium-mac/tables/mozilla/bugs/bug82946-2-expected.png:
  • platform/chromium/test_expectations.txt:
07:13 Changeset [71736] by andreas.kling@nokia.com

2010-11-10 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r71733.
http://trac.webkit.org/changeset/71733
https://bugs.webkit.org/show_bug.cgi?id=49319

made qt bot crashy and sad (Requested by kling on #webkit).

  • Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::updateResizesToContentsForPage):
  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::transitionToCommittedForNewPage):

2010-11-10 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r71733.
http://trac.webkit.org/changeset/71733
https://bugs.webkit.org/show_bug.cgi?id=49319

made qt bot crashy and sad (Requested by kling on #webkit).

  • page/FrameView.cpp: (WebCore::FrameView::windowClipRect):
06:43 Changeset [71735] by caseq@chromium.org

2010-11-10 Peter Rybin <peter.rybin@gmail.com>

Reviewed by Adam Barth.

HTML parser should provide script column position within HTML document to JavaScript engine
https://bugs.webkit.org/show_bug.cgi?id=45271

Adds TextPosition* classes -- a structure that stores line/column/generation
level coordinates inside text document. Adds *BasedNumber classes -- typesafe int
wrappers that emphasize whether int number is used as zero-based or
one-based.

  • GNUmakefile.am:
  • JavaScriptCore.gypi:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • wtf/text/TextPosition.h: Added. (WTF::TextPosition::TextPosition): (WTF::TextPosition::minimumPosition): (WTF::TextPosition::belowRangePosition): (WTF::ZeroBasedNumber::fromZeroBasedInt): (WTF::ZeroBasedNumber::ZeroBasedNumber): (WTF::ZeroBasedNumber::zeroBasedInt): (WTF::ZeroBasedNumber::base): (WTF::ZeroBasedNumber::belowBase): (WTF::OneBasedNumber::fromOneBasedInt): (WTF::OneBasedNumber::OneBasedNumber): (WTF::OneBasedNumber::oneBasedInt): (WTF::OneBasedNumber::convertAsZeroBasedInt): (WTF::OneBasedNumber::convertToZeroBased): (WTF::OneBasedNumber::base): (WTF::OneBasedNumber::belowBase): (WTF::toZeroBasedTextPosition): (WTF::toOneBasedTextPosition): (WTF::ZeroBasedNumber::convertToOneBased):

2010-11-10 Peter Rybin <peter.rybin@gmail.com>

Reviewed by Adam Barth.

HTML parser should provide script column position within HTML document to JavaScript engine
https://bugs.webkit.org/show_bug.cgi?id=45271

Replaces line number with TextPosition struct so that script engine
gets script starting line/column.

  • ForwardingHeaders/wtf/text/TextPosition.h: Added.
  • bindings/js/ScriptSourceCode.h: (WebCore::ScriptSourceCode::ScriptSourceCode):
  • bindings/v8/ScheduledAction.cpp: (WebCore::ScheduledAction::ScheduledAction):
  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::eventHandlerPosition):
  • bindings/v8/ScriptController.h:
  • bindings/v8/ScriptEventListener.cpp: (WebCore::createAttributeEventListener):
  • bindings/v8/ScriptSourceCode.h: (WebCore::ScriptSourceCode::ScriptSourceCode): (WebCore::ScriptSourceCode::startLine): (WebCore::ScriptSourceCode::startPosition):
  • bindings/v8/V8LazyEventListener.cpp: (WebCore::V8LazyEventListener::V8LazyEventListener): (WebCore::V8LazyEventListener::prepareListenerObject):
  • bindings/v8/V8LazyEventListener.h: (WebCore::V8LazyEventListener::create):
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::compileScript): (WebCore::V8Proxy::evaluate): (WebCore::V8Proxy::runScript):
  • bindings/v8/V8Proxy.h:
  • bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::evaluate): (WebCore::WorkerContextExecutionProxy::runScript):
  • bindings/v8/WorkerContextExecutionProxy.h:
  • bindings/v8/WorkerScriptController.cpp: (WebCore::WorkerScriptController::evaluate):
  • dom/PendingScript.cpp: (WebCore::PendingScript::releaseElementAndClear):
  • dom/PendingScript.h: (WebCore::PendingScript::PendingScript): (WebCore::PendingScript::operator=): (WebCore::PendingScript::startingPosition):
  • dom/ScriptableDocumentParser.h:
  • dom/XMLDocumentParser.h:
  • dom/XMLDocumentParserLibxml2.cpp: (WebCore::XMLDocumentParser::XMLDocumentParser): (WebCore::XMLDocumentParser::startElementNs): (WebCore::XMLDocumentParser::endElementNs): (WebCore::XMLDocumentParser::lineNumber): (WebCore::XMLDocumentParser::columnNumber): (WebCore::XMLDocumentParser::textPosition): (WebCore::XMLDocumentParser::textPositionOneBased):
  • dom/XMLDocumentParserQt.cpp: (WebCore::XMLDocumentParser::XMLDocumentParser): (WebCore::XMLDocumentParser::textPosition): (WebCore::XMLDocumentParser::parseStartElement): (WebCore::XMLDocumentParser::parseEndElement):
  • html/parser/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::runScriptsForPausedTreeBuilder): (WebCore::HTMLDocumentParser::textPosition):
  • html/parser/HTMLDocumentParser.h:
  • html/parser/HTMLScriptRunner.cpp: (WebCore::HTMLScriptRunner::sourceFromPendingScript): (WebCore::HTMLScriptRunner::execute): (WebCore::HTMLScriptRunner::runScript):
  • html/parser/HTMLScriptRunner.h:
  • html/parser/HTMLTreeBuilder.cpp: (WebCore::uninitializedPositionValue1): (WebCore::HTMLTreeBuilder::HTMLTreeBuilder): (WebCore::HTMLTreeBuilder::takeScriptToProcess): (WebCore::HTMLTreeBuilder::processEndTag): (WebCore::HTMLTreeBuilder::processScriptStartTag):
  • html/parser/HTMLTreeBuilder.h:

2010-11-10 Peter Rybin <peter.rybin@gmail.com>

Reviewed by Adam Barth.

HTML parser should provide script column position within HTML document to JavaScript engine
https://bugs.webkit.org/show_bug.cgi?id=45271

Replaces script line number with TextPosition structure.

  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::executeScript): (WebKit::WebFrameImpl::executeScriptInIsolatedWorld): (WebKit::WebFrameImpl::executeScriptAndReturnValue):
05:54 Changeset [71734] by commit-queue@webkit.org

2010-11-10 Ilya Sherman <isherman@chromium.org>

Reviewed by Shinichiro Hamaji.

Fix autofill popup height computation -- take icon heights into account.
https://bugs.webkit.org/show_bug.cgi?id=49306

  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupListBox::layout):
05:48 Changeset [71733] by andreas.kling@nokia.com

2010-11-10 Kenneth Rohde Christiansen <kenneth@webkit.org>

Reviewed by Andreas Kling.

Use paintEntireContents in combination with tiling, allowing to
actually set visibleContentRect to something different from
the actual contents size.

  • Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::updateResizesToContentsForPage):
  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::transitionToCommittedForNewPage):

2010-11-10 Kenneth Rohde Christiansen <kenneth@webkit.org>

Reviewed by Andreas Kling.

In paintEntireContents mode (used in combination with tiling) we
cannot clip to the actual visibleContentRect as the clipped regions
will not be updated again on scroll. If paintsEntireContents is
enabled, return the actual content rect.

  • page/FrameView.cpp: (WebCore::FrameView::windowClipRect):
04:03 Changeset [71732] by ossy@webkit.org

Unreviewed.

[Qt] Add platform specific expected results for new passing tests introduced in r71563 and r71700.
Compared to Mac png files and Mac expected files.

  • platform/qt/fast/blockflow/horizontal-bt-replaced-selection-expected.checksum: Added.
  • platform/qt/fast/blockflow/horizontal-bt-replaced-selection-expected.png: Added.
  • platform/qt/fast/blockflow/horizontal-bt-replaced-selection-expected.txt: Added.
  • platform/qt/fast/blockflow/vertical-lr-replaced-selection-expected.checksum: Added.
  • platform/qt/fast/blockflow/vertical-lr-replaced-selection-expected.png: Added.
  • platform/qt/fast/blockflow/vertical-lr-replaced-selection-expected.txt: Added.
  • platform/qt/fast/blockflow/vertical-rl-replaced-selection-expected.checksum: Added.
  • platform/qt/fast/blockflow/vertical-rl-replaced-selection-expected.png: Added.
  • platform/qt/fast/blockflow/vertical-rl-replaced-selection-expected.txt: Added.
  • platform/qt/fast/lists/001-vertical-expected.checksum: Added.
  • platform/qt/fast/lists/001-vertical-expected.png: Added.
  • platform/qt/fast/lists/001-vertical-expected.txt: Added.
  • platform/qt/fast/lists/002-vertical-expected.checksum: Added.
  • platform/qt/fast/lists/002-vertical-expected.png: Added.
  • platform/qt/fast/lists/002-vertical-expected.txt: Added.
  • platform/qt/fast/lists/003-vertical-expected.checksum: Added.
  • platform/qt/fast/lists/003-vertical-expected.png: Added.
  • platform/qt/fast/lists/003-vertical-expected.txt: Added.
  • platform/qt/fast/lists/005-vertical-expected.checksum: Added.
  • platform/qt/fast/lists/005-vertical-expected.png: Added.
  • platform/qt/fast/lists/005-vertical-expected.txt: Added.
  • platform/qt/fast/lists/006-vertical-expected.checksum: Added.
  • platform/qt/fast/lists/006-vertical-expected.png: Added.
  • platform/qt/fast/lists/006-vertical-expected.txt: Added.
  • platform/qt/fast/lists/007-vertical-expected.checksum: Added.
  • platform/qt/fast/lists/007-vertical-expected.png: Added.
  • platform/qt/fast/lists/007-vertical-expected.txt: Added.
  • platform/qt/fast/lists/008-vertical-expected.checksum: Added.
  • platform/qt/fast/lists/008-vertical-expected.png: Added.
  • platform/qt/fast/lists/008-vertical-expected.txt: Added.
  • platform/qt/fast/lists/009-vertical-expected.checksum: Added.
  • platform/qt/fast/lists/009-vertical-expected.png: Added.
  • platform/qt/fast/lists/009-vertical-expected.txt: Added.
03:03 Changeset [71731] by ossy@webkit.org

Unreviewed.

[Qt] svg/animations/animate-path-nested-transforms.html fails
https://bugs.webkit.org/show_bug.cgi?id=48987

svg/animations/animate-text-nested-transforms.html introduced in r71726
and has same failure as svg/animations/animate-path-nested-transforms.html

  • platform/qt/Skipped: svg/animations/animate-text-nested-transforms.html added.
02:55 Changeset [71730] by ukai@chromium.org

Unreviwed, updating Chromium test expectations.

  • platform/chromium/test_expectations.txt:
02:46 Changeset [71729] by andreas.kling@nokia.com

2010-11-10 Andreas Kling <kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt][WK2] Fix re-use of memory-mapped files
https://bugs.webkit.org/show_bug.cgi?id=49310

QTemporaryFile::fileName() returns an empty string after close()
so we have to keep separate track of the filename.

Also, we can't reopen the file if it's been QFile::remove()d,
so we defer unlinking until the MappedMemoryPool is destroyed or
the CrashHandler kicks in.

This makes re-use of memory-mapped files work (after we kill an
assertion that the file size == the new mmap size - it's fine if
the file is larger, too.)

  • Platform/qt/MappedMemoryPool.cpp: (WebKit::MappedMemoryPool::~MappedMemoryPool): (WebKit::MappedMemoryPool::clear): (WebKit::MappedMemoryPool::mapMemory): (WebKit::MappedMemoryPool::mapFile):
  • Platform/qt/MappedMemoryPool.h: (WebKit::MappedMemory::mappedFileName):
  • Shared/qt/CrashHandler.cpp: (WebKit::CrashHandler::deleteObjects):
  • Shared/qt/UpdateChunk.cpp: (WebKit::UpdateChunk::encode):
02:23 Changeset [71728] by ukai@chromium.org

Unreviewed, updating Chromium expectations.

removed the followings, since these always passes recently.
BUG51161 LINUX DEBUG : svg/W3C-SVG-1.1/masking-mask-01-b.svg = CRASH
BUG51161 LINUX DEBUG : svg/clip-path/clip-path-text.svg = CRASH
BUG8729 LINUX DEBUG : http/tests/multipart/invalid-image-data.html = IMAGE PASS
BUGWK45991 : canvas/philip/tests/2d.pattern.image.incomplete.html
BUGDPRANKE LINUX DEBUG : fast/forms/restore-selection-after-layout.html = TEXT

  • platform/chromium/test_expectations.txt:
01:12 Changeset [71727] by hamaji@chromium.org

2010-11-10 Shinichiro Hamaji <hamaji@chromium.org>

Adding a manual test which I forgot to add in r71618.

[Chromium] display:none has no effect on <option> element
https://bugs.webkit.org/show_bug.cgi?id=49169

  • manual-tests/display-none-option.html: Added.
01:04 Changeset [71726] by commit-queue@webkit.org

2010-11-10 Shane Stephens <shanestephens@google.com>

Reviewed by Dirk Schulze.

SVGTextElement supplemental transforms pre-multiplied but should be
post-multiplied in animatedLocalTransform
https://bugs.webkit.org/show_bug.cgi?id=48215

  • svg/animations/animate-text-nested-transforms-expected.txt: Added.
  • svg/animations/animate-text-nested-transforms.svg: Added.

2010-11-10 Shane Stephens <shanestephens@google.com>

Reviewed by Dirk Schulze.

SVGTextElement supplemental transforms pre-multiplied but should be
post-multiplied in animatedLocalTransform
https://bugs.webkit.org/show_bug.cgi?id=48215

Test: svg/animations/animate-text-nested-transforms.svg

  • svg/SVGTextElement.cpp: (WebCore::SVGTextElement::animatedLocalTransform):

Switched order of multiplication. Note that due to a bug in
AffineTransform's operator* implementation the order of arguments is
reversed (see http://bugs.webkit.org/show_bug.cgi?id=48031).

00:48 Changeset [71725] by ukai@chromium.org

Unreviewed, updating Chromium expectations
from chrome/src/webkit/tools/layout_tests/test_expectations.txt

  • platform/chromium/test_expectations.txt:
00:24 Changeset [71724] by inferno@chromium.org

2010-11-09 Abhishek Arya <inferno@chromium.org>

Reviewed by Dan Bernstein.

Fieldsets avoid floats. Legend elements are expected to have their parent
as fieldset. When this not the case, floats get added incorrectly added to the
legend blocks. This patch tries to prevent those floats addition.
https://bugs.webkit.org/show_bug.cgi?id=49214

Test: fast/blockflow/overhanging-float-legend-crash.html

  • rendering/RenderBox.cpp: (WebCore::RenderBox::avoidsFloats):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::isLegend):
  • rendering/RenderObject.h:

2010-11-09 Abhishek Arya <inferno@chromium.org>

Reviewed by Dan Bernstein.

Tests that we do not crash and avoid floats to be added in legend element
when it is not enclosed in a fieldset.
https://bugs.webkit.org/show_bug.cgi?id=49214

  • fast/blockflow/overhanging-float-legend-crash-expected.txt: Added.
  • fast/blockflow/overhanging-float-legend-crash.html: Added.
00:20 Changeset [71723] by inferno@chromium.org

2010-11-10 Cris Neckar <cdn@chromium.org>

Reviewed by Nikolas Zimmermann.

Added check to ensure that svg viewport containers are not treated in the same way as generic svg containers.
https://bugs.webkit.org/show_bug.cgi?id=49188

Test: svg/dom/viewport-container-crash.svg

  • rendering/SVGImageBufferTools.cpp: (WebCore::SVGImageBufferTools::renderSubtreeToImageBuffer):

2010-11-10 Cris Neckar <cdn@chromium.org>

Reviewed by Nikolas Zimmermann.

Test for crash when svg viewport containers are treated as generic svg containers.
https://bugs.webkit.org/show_bug.cgi?id=49188

  • svg/dom/viewport-container-crash-expected.txt: Added.
  • svg/dom/viewport-container-crash.svg: Added.
Note: See TracTimeline for information about the timeline view.