Timeline


and

11/16/10:

23:43 Changeset [72175] by aroben@apple.com

Ignore files from libdispatch/zlib

Rubber-stamped by Eric Seidel.

  • win/include: Modified property svn:ignore.
  • win/lib: Modified property svn:ignore.
23:24 Changeset [72174] by aroben@apple.com

Move QTMovieWin's settings into a vsprops file

Fixes <http://webkit.org/b/49644> QTMovieWin should use a vsprops file

Reviewed by Steve Falkenburg.

  • WebCore.vcproj/QTMovieWin.vcproj:
  • WebCore.vcproj/QTMovieWinCommon.vsprops: Added.
22:45 Changeset [72173] by aestes@apple.com

WebKit mishandles line boxes where the content height exceeds the
specified line-height.
https://bugs.webkit.org/show_bug.cgi?id=49410

Reviewed by Dave Hyatt.

WebCore:

If a line height is explicitly specified on a text box and fallback
fonts are in use, only the primary font should be considered when
computing the box's ascent and descent. This prevents the inline box
from being sized larger than the specified line height.

This patch also fixes a math error when computing a used font's descent
in the case where line height isn't explicitly set. This change results
in a number of layout tests needing re-baselining.

Test: fast/css/line-height-determined-by-primary-font.html

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::computeLogicalBoxHeights):

LayoutTests:

  • fast/css/line-height-determined-by-primary-font.html: Added.
  • platform/mac/fast/css/line-height-determined-by-primary-font-expected.checksum: Added.
  • platform/mac/fast/css/line-height-determined-by-primary-font-expected.png: Added.
  • platform/mac/fast/css/line-height-determined-by-primary-font-expected.txt: Added.

The following test results were re-baselined:

  • platform/mac/css2.1/t0805-c5518-brdr-t-01-e-expected.checksum:
  • platform/mac/css2.1/t0805-c5518-brdr-t-01-e-expected.png:
  • platform/mac/css2.1/t0805-c5518-brdr-t-01-e-expected.txt:
  • platform/mac/css2.1/t0805-c5519-brdr-r-00-a-expected.checksum:
  • platform/mac/css2.1/t0805-c5519-brdr-r-00-a-expected.png:
  • platform/mac/css2.1/t0805-c5519-brdr-r-00-a-expected.txt:
  • platform/mac/css2.1/t0805-c5520-brdr-b-01-e-expected.checksum:
  • platform/mac/css2.1/t0805-c5520-brdr-b-01-e-expected.png:
  • platform/mac/css2.1/t0805-c5520-brdr-b-01-e-expected.txt:
  • platform/mac/css2.1/t0805-c5521-brdr-l-00-a-expected.checksum:
  • platform/mac/css2.1/t0805-c5521-brdr-l-00-a-expected.png:
  • platform/mac/css2.1/t0805-c5521-brdr-l-00-a-expected.txt:
  • platform/mac/css2.1/t0805-c5521-brdr-l-01-e-expected.checksum:
  • platform/mac/css2.1/t0805-c5521-brdr-l-01-e-expected.png:
  • platform/mac/css2.1/t0805-c5521-brdr-l-01-e-expected.txt:
  • platform/mac/css2.1/t0805-c5521-ibrdr-l-00-a-expected.checksum:
  • platform/mac/css2.1/t0805-c5521-ibrdr-l-00-a-expected.png:
  • platform/mac/css2.1/t0805-c5521-ibrdr-l-00-a-expected.txt:
  • platform/mac/css2.1/t0905-c414-flt-02-c-expected.checksum:
  • platform/mac/css2.1/t0905-c414-flt-02-c-expected.png:
  • platform/mac/css2.1/t0905-c414-flt-02-c-expected.txt:
  • platform/mac/css2.1/t0905-c414-flt-03-c-expected.checksum:
  • platform/mac/css2.1/t0905-c414-flt-03-c-expected.png:
  • platform/mac/css2.1/t0905-c414-flt-03-c-expected.txt:
  • platform/mac/css2.1/t0905-c414-flt-04-c-expected.checksum:
  • platform/mac/css2.1/t0905-c414-flt-04-c-expected.png:
  • platform/mac/css2.1/t0905-c414-flt-04-c-expected.txt:
  • platform/mac/css2.1/t0905-c414-flt-fit-01-d-g-expected.checksum:
  • platform/mac/css2.1/t0905-c414-flt-fit-01-d-g-expected.png:
  • platform/mac/css2.1/t0905-c414-flt-fit-01-d-g-expected.txt:
  • platform/mac/css2.1/t0905-c5525-fltblck-01-d-expected.checksum:
  • platform/mac/css2.1/t0905-c5525-fltblck-01-d-expected.png:
  • platform/mac/css2.1/t0905-c5525-fltblck-01-d-expected.txt:
  • platform/mac/css2.1/t0905-c5525-fltcont-00-d-g-expected.checksum:
  • platform/mac/css2.1/t0905-c5525-fltcont-00-d-g-expected.png:
  • platform/mac/css2.1/t0905-c5525-fltcont-00-d-g-expected.txt:
  • platform/mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.checksum:
  • platform/mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png:
  • platform/mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.txt:
  • platform/mac/css2.1/t0905-c5525-fltwidth-02-c-g-expected.checksum:
  • platform/mac/css2.1/t0905-c5525-fltwidth-02-c-g-expected.png:
  • platform/mac/css2.1/t0905-c5525-fltwidth-02-c-g-expected.txt:
  • platform/mac/css2.1/t0905-c5525-fltwidth-03-c-g-expected.checksum:
  • platform/mac/css2.1/t0905-c5525-fltwidth-03-c-g-expected.png:
  • platform/mac/css2.1/t0905-c5525-fltwidth-03-c-g-expected.txt:
  • platform/mac/css2.1/t0905-c5525-fltwrap-00-b-expected.checksum:
  • platform/mac/css2.1/t0905-c5525-fltwrap-00-b-expected.png:
  • platform/mac/css2.1/t0905-c5525-fltwrap-00-b-expected.txt:
  • platform/mac/css2.1/t090501-c414-flt-01-b-expected.checksum:
  • platform/mac/css2.1/t090501-c414-flt-01-b-expected.png:
  • platform/mac/css2.1/t090501-c414-flt-01-b-expected.txt:
  • platform/mac/css2.1/t090501-c414-flt-03-b-g-expected.checksum:
  • platform/mac/css2.1/t090501-c414-flt-03-b-g-expected.png:
  • platform/mac/css2.1/t090501-c414-flt-03-b-g-expected.txt:
  • platform/mac/css2.1/t090501-c5525-flt-l-00-b-g-expected.checksum:
  • platform/mac/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
  • platform/mac/css2.1/t090501-c5525-flt-l-00-b-g-expected.txt:
  • platform/mac/css2.1/t090501-c5525-flt-r-00-b-g-expected.checksum:
  • platform/mac/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
  • platform/mac/css2.1/t090501-c5525-flt-r-00-b-g-expected.txt:
  • platform/mac/css2.1/t100304-c43-rpl-bbx-01-d-g-expected.checksum:
  • platform/mac/css2.1/t100304-c43-rpl-bbx-01-d-g-expected.png:
  • platform/mac/css2.1/t100304-c43-rpl-bbx-01-d-g-expected.txt:
  • platform/mac/css2.1/t1202-counter-03-b-expected.checksum:
  • platform/mac/css2.1/t1202-counter-03-b-expected.png:
  • platform/mac/css2.1/t1202-counter-03-b-expected.txt:
  • platform/mac/css2.1/t1202-counter-04-b-expected.checksum:
  • platform/mac/css2.1/t1202-counter-04-b-expected.png:
  • platform/mac/css2.1/t1202-counter-04-b-expected.txt:
  • platform/mac/css2.1/t1202-counter-09-b-expected.checksum:
  • platform/mac/css2.1/t1202-counter-09-b-expected.png:
  • platform/mac/css2.1/t1202-counter-09-b-expected.txt:
  • platform/mac/css2.1/t1202-counters-03-b-expected.checksum:
  • platform/mac/css2.1/t1202-counters-03-b-expected.png:
  • platform/mac/css2.1/t1202-counters-03-b-expected.txt:
  • platform/mac/css2.1/t1202-counters-04-b-expected.checksum:
  • platform/mac/css2.1/t1202-counters-04-b-expected.png:
  • platform/mac/css2.1/t1202-counters-04-b-expected.txt:
  • platform/mac/css2.1/t1202-counters-09-b-expected.checksum:
  • platform/mac/css2.1/t1202-counters-09-b-expected.png:
  • platform/mac/css2.1/t1202-counters-09-b-expected.txt:
  • platform/mac/fast/blockflow/vertical-font-fallback-expected.checksum:
  • platform/mac/fast/blockflow/vertical-font-fallback-expected.png:
  • platform/mac/fast/blockflow/vertical-font-fallback-expected.txt:
  • platform/mac/fast/css/beforeSelectorOnCodeElement-expected.checksum:
  • platform/mac/fast/css/beforeSelectorOnCodeElement-expected.png:
  • platform/mac/fast/css/beforeSelectorOnCodeElement-expected.txt:
  • platform/mac/fast/css/font-face-opentype-expected.checksum:
  • platform/mac/fast/css/font-face-opentype-expected.png:
  • platform/mac/fast/css/font-face-opentype-expected.txt:
  • platform/mac/fast/css/rtl-ordering-expected.checksum:
  • platform/mac/fast/css/rtl-ordering-expected.png:
  • platform/mac/fast/css/rtl-ordering-expected.txt:
  • platform/mac/fast/css/text-overflow-ellipsis-bidi-expected.checksum:
  • platform/mac/fast/css/text-overflow-ellipsis-bidi-expected.png:
  • platform/mac/fast/css/text-overflow-ellipsis-bidi-expected.txt:
  • platform/mac/fast/css/text-overflow-ellipsis-expected.checksum:
  • platform/mac/fast/css/text-overflow-ellipsis-expected.png:
  • platform/mac/fast/css/text-overflow-ellipsis-expected.txt:
  • platform/mac/fast/css/text-overflow-ellipsis-strict-expected.checksum:
  • platform/mac/fast/css/text-overflow-ellipsis-strict-expected.png:
  • platform/mac/fast/css/text-overflow-ellipsis-strict-expected.txt:
  • platform/mac/fast/css/text-security-expected.checksum:
  • platform/mac/fast/css/text-security-expected.png:
  • platform/mac/fast/css/text-security-expected.txt:
  • platform/mac/fast/encoding/denormalised-voiced-japanese-chars-expected.checksum:
  • platform/mac/fast/encoding/denormalised-voiced-japanese-chars-expected.png:
  • platform/mac/fast/encoding/denormalised-voiced-japanese-chars-expected.txt:
  • platform/mac/fast/encoding/invalid-UTF-8-expected.checksum:
  • platform/mac/fast/encoding/invalid-UTF-8-expected.png:
  • platform/mac/fast/encoding/invalid-UTF-8-expected.txt:
  • platform/mac/fast/events/updateLayoutForHitTest-expected.checksum:
  • platform/mac/fast/events/updateLayoutForHitTest-expected.png:
  • platform/mac/fast/events/updateLayoutForHitTest-expected.txt:
  • platform/mac/fast/forms/select-visual-hebrew-expected.checksum:
  • platform/mac/fast/forms/select-visual-hebrew-expected.png:
  • platform/mac/fast/forms/select-visual-hebrew-expected.txt:
  • platform/mac/fast/forms/select-writing-direction-natural-expected.checksum:
  • platform/mac/fast/forms/select-writing-direction-natural-expected.png:
  • platform/mac/fast/forms/select-writing-direction-natural-expected.txt:
  • platform/mac/fast/forms/visual-hebrew-text-field-expected.checksum:
  • platform/mac/fast/forms/visual-hebrew-text-field-expected.png:
  • platform/mac/fast/forms/visual-hebrew-text-field-expected.txt:
  • platform/mac/fast/repaint/repaint-across-writing-mode-boundary-expected.checksum:
  • platform/mac/fast/repaint/repaint-across-writing-mode-boundary-expected.png:
  • platform/mac/fast/repaint/repaint-across-writing-mode-boundary-expected.txt:
  • platform/mac/fast/text/atsui-multiple-renderers-expected.checksum:
  • platform/mac/fast/text/atsui-multiple-renderers-expected.png:
  • platform/mac/fast/text/atsui-multiple-renderers-expected.txt:
  • platform/mac/fast/text/bidi-embedding-pop-and-push-same-expected.checksum:
  • platform/mac/fast/text/bidi-embedding-pop-and-push-same-expected.png:
  • platform/mac/fast/text/bidi-embedding-pop-and-push-same-expected.txt:
  • platform/mac/fast/text/capitalize-boundaries-expected.checksum:
  • platform/mac/fast/text/capitalize-boundaries-expected.png:
  • platform/mac/fast/text/capitalize-boundaries-expected.txt:
  • platform/mac/fast/text/cg-fallback-bolding-expected.checksum:
  • platform/mac/fast/text/cg-fallback-bolding-expected.png:
  • platform/mac/fast/text/cg-fallback-bolding-expected.txt:
  • platform/mac/fast/text/complex-text-opacity-expected.checksum:
  • platform/mac/fast/text/complex-text-opacity-expected.png:
  • platform/mac/fast/text/complex-text-opacity-expected.txt:
  • platform/mac/fast/text/in-rendered-text-rtl-expected.checksum:
  • platform/mac/fast/text/in-rendered-text-rtl-expected.png:
  • platform/mac/fast/text/in-rendered-text-rtl-expected.txt:
  • platform/mac/fast/text/international/001-expected.checksum:
  • platform/mac/fast/text/international/001-expected.png:
  • platform/mac/fast/text/international/001-expected.txt:
  • platform/mac/fast/text/international/002-expected.checksum:
  • platform/mac/fast/text/international/002-expected.png:
  • platform/mac/fast/text/international/002-expected.txt:
  • platform/mac/fast/text/international/003-expected.checksum:
  • platform/mac/fast/text/international/003-expected.png:
  • platform/mac/fast/text/international/003-expected.txt:
  • platform/mac/fast/text/international/bidi-AN-after-L-expected.checksum:
  • platform/mac/fast/text/international/bidi-AN-after-L-expected.png:
  • platform/mac/fast/text/international/bidi-AN-after-L-expected.txt:
  • platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.checksum:
  • platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.png:
  • platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.txt:
  • platform/mac/fast/text/international/bidi-CS-after-AN-expected.checksum:
  • platform/mac/fast/text/international/bidi-CS-after-AN-expected.png:
  • platform/mac/fast/text/international/bidi-CS-after-AN-expected.txt:
  • platform/mac/fast/text/international/bidi-L2-run-reordering-expected.checksum:
  • platform/mac/fast/text/international/bidi-L2-run-reordering-expected.png:
  • platform/mac/fast/text/international/bidi-L2-run-reordering-expected.txt:
  • platform/mac/fast/text/international/bidi-LDB-2-CSS-expected.checksum:
  • platform/mac/fast/text/international/bidi-LDB-2-CSS-expected.png:
  • platform/mac/fast/text/international/bidi-LDB-2-CSS-expected.txt:
  • platform/mac/fast/text/international/bidi-LDB-2-HTML-expected.checksum:
  • platform/mac/fast/text/international/bidi-LDB-2-HTML-expected.png:
  • platform/mac/fast/text/international/bidi-LDB-2-HTML-expected.txt:
  • platform/mac/fast/text/international/bidi-LDB-2-formatting-characters-expected.checksum:
  • platform/mac/fast/text/international/bidi-LDB-2-formatting-characters-expected.png:
  • platform/mac/fast/text/international/bidi-LDB-2-formatting-characters-expected.txt:
  • platform/mac/fast/text/international/bidi-european-terminators-expected.checksum:
  • platform/mac/fast/text/international/bidi-european-terminators-expected.png:
  • platform/mac/fast/text/international/bidi-european-terminators-expected.txt:
  • platform/mac/fast/text/international/bidi-fallback-font-weight-expected.checksum:
  • platform/mac/fast/text/international/bidi-fallback-font-weight-expected.png:
  • platform/mac/fast/text/international/bidi-fallback-font-weight-expected.txt:
  • platform/mac/fast/text/international/bidi-ignored-for-first-child-inline-expected.checksum:
  • platform/mac/fast/text/international/bidi-ignored-for-first-child-inline-expected.png:
  • platform/mac/fast/text/international/bidi-ignored-for-first-child-inline-expected.txt:
  • platform/mac/fast/text/international/bidi-innertext-expected.checksum:
  • platform/mac/fast/text/international/bidi-innertext-expected.png:
  • platform/mac/fast/text/international/bidi-innertext-expected.txt:
  • platform/mac/fast/text/international/bidi-linebreak-001-expected.checksum:
  • platform/mac/fast/text/international/bidi-linebreak-001-expected.png:
  • platform/mac/fast/text/international/bidi-linebreak-001-expected.txt:
  • platform/mac/fast/text/international/bidi-linebreak-002-expected.checksum:
  • platform/mac/fast/text/international/bidi-linebreak-002-expected.png:
  • platform/mac/fast/text/international/bidi-linebreak-002-expected.txt:
  • platform/mac/fast/text/international/bidi-linebreak-003-expected.checksum:
  • platform/mac/fast/text/international/bidi-linebreak-003-expected.png:
  • platform/mac/fast/text/international/bidi-linebreak-003-expected.txt:
  • platform/mac/fast/text/international/bidi-listbox-atsui-expected.checksum:
  • platform/mac/fast/text/international/bidi-listbox-atsui-expected.png:
  • platform/mac/fast/text/international/bidi-listbox-atsui-expected.txt:
  • platform/mac/fast/text/international/bidi-listbox-expected.checksum:
  • platform/mac/fast/text/international/bidi-listbox-expected.png:
  • platform/mac/fast/text/international/bidi-listbox-expected.txt:
  • platform/mac/fast/text/international/bidi-menulist-expected.checksum:
  • platform/mac/fast/text/international/bidi-menulist-expected.png:
  • platform/mac/fast/text/international/bidi-menulist-expected.txt:
  • platform/mac/fast/text/international/bidi-mirror-he-ar-expected.checksum:
  • platform/mac/fast/text/international/bidi-mirror-he-ar-expected.png:
  • platform/mac/fast/text/international/bidi-mirror-he-ar-expected.txt:
  • platform/mac/fast/text/international/bidi-neutral-run-expected.checksum:
  • platform/mac/fast/text/international/bidi-neutral-run-expected.png:
  • platform/mac/fast/text/international/bidi-neutral-run-expected.txt:
  • platform/mac/fast/text/international/bidi-override-expected.checksum:
  • platform/mac/fast/text/international/bidi-override-expected.png:
  • platform/mac/fast/text/international/bidi-override-expected.txt:
  • platform/mac/fast/text/international/danda-space-expected.checksum:
  • platform/mac/fast/text/international/danda-space-expected.png:
  • platform/mac/fast/text/international/danda-space-expected.txt:
  • platform/mac/fast/text/international/hebrew-vowels-expected.checksum:
  • platform/mac/fast/text/international/hebrew-vowels-expected.png:
  • platform/mac/fast/text/international/hebrew-vowels-expected.txt:
  • platform/mac/fast/text/international/hindi-spacing-expected.checksum:
  • platform/mac/fast/text/international/hindi-spacing-expected.png:
  • platform/mac/fast/text/international/hindi-spacing-expected.txt:
  • platform/mac/fast/text/international/hindi-whitespace-expected.checksum:
  • platform/mac/fast/text/international/hindi-whitespace-expected.png:
  • platform/mac/fast/text/international/hindi-whitespace-expected.txt:
  • platform/mac/fast/text/international/plane2-expected.checksum:
  • platform/mac/fast/text/international/plane2-expected.png:
  • platform/mac/fast/text/international/plane2-expected.txt:
  • platform/mac/fast/text/international/rtl-caret-expected.checksum:
  • platform/mac/fast/text/international/rtl-caret-expected.png:
  • platform/mac/fast/text/international/rtl-caret-expected.txt:
  • platform/mac/fast/text/international/thai-baht-space-expected.checksum:
  • platform/mac/fast/text/international/thai-baht-space-expected.png:
  • platform/mac/fast/text/international/thai-baht-space-expected.txt:
  • platform/mac/fast/text/international/thai-line-breaks-expected.checksum:
  • platform/mac/fast/text/international/thai-line-breaks-expected.png:
  • platform/mac/fast/text/international/thai-line-breaks-expected.txt:
  • platform/mac/fast/text/international/wrap-CJK-001-expected.checksum:
  • platform/mac/fast/text/international/wrap-CJK-001-expected.png:
  • platform/mac/fast/text/international/wrap-CJK-001-expected.txt:
  • platform/mac/mathml/presentation/attributes-expected.checksum:
  • platform/mac/mathml/presentation/attributes-expected.png:
  • platform/mac/mathml/presentation/attributes-expected.txt:
  • platform/mac/mathml/presentation/fractions-expected.checksum:
  • platform/mac/mathml/presentation/fractions-expected.png:
  • platform/mac/mathml/presentation/fractions-expected.txt:
  • platform/mac/mathml/presentation/fractions-vertical-alignment-expected.checksum:
  • platform/mac/mathml/presentation/fractions-vertical-alignment-expected.png:
  • platform/mac/mathml/presentation/fractions-vertical-alignment-expected.txt:
  • platform/mac/mathml/presentation/mo-expected.checksum:
  • platform/mac/mathml/presentation/mo-expected.png:
  • platform/mac/mathml/presentation/mo-expected.txt:
  • platform/mac/mathml/presentation/over-expected.checksum:
  • platform/mac/mathml/presentation/over-expected.png:
  • platform/mac/mathml/presentation/over-expected.txt:
  • platform/mac/mathml/presentation/roots-expected.checksum:
  • platform/mac/mathml/presentation/roots-expected.png:
  • platform/mac/mathml/presentation/roots-expected.txt:
  • platform/mac/mathml/presentation/row-alignment-expected.checksum:
  • platform/mac/mathml/presentation/row-alignment-expected.png:
  • platform/mac/mathml/presentation/row-alignment-expected.txt:
  • platform/mac/mathml/presentation/row-expected.txt:
  • platform/mac/mathml/presentation/style-expected.txt:
  • platform/mac/mathml/presentation/sub-expected.txt:
  • platform/mac/mathml/presentation/subsup-expected.txt:
  • platform/mac/mathml/presentation/sup-expected.checksum:
  • platform/mac/mathml/presentation/sup-expected.png:
  • platform/mac/mathml/presentation/sup-expected.txt:
  • platform/mac/mathml/presentation/tables-expected.checksum:
  • platform/mac/mathml/presentation/tables-expected.png:
  • platform/mac/mathml/presentation/tables-expected.txt:
  • platform/mac/mathml/presentation/tokenElements-expected.txt:
  • platform/mac/mathml/presentation/under-expected.checksum:
  • platform/mac/mathml/presentation/under-expected.png:
  • platform/mac/mathml/presentation/under-expected.txt:
  • platform/mac/mathml/presentation/underover-expected.checksum:
  • platform/mac/mathml/presentation/underover-expected.png:
  • platform/mac/mathml/presentation/underover-expected.txt:
  • platform/mac/mathml/xHeight-expected.txt:
21:56 Changeset [72172] by rniwa@webkit.org

2010-11-15 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

ScriptElementData should be a private member of ScriptElement
https://bugs.webkit.org/show_bug.cgi?id=49578

Privatized m_data of ScriptElement. Added haveFiredLoadEvent, setHaveFiredLoadEvent, createdByParser,
and isEvaluated to ScriptElement to proxy calls from HTMLScriptElement and SVGScriptElement to ScriptElementData.

No tests are added since this is a cleanup.

  • dom/ScriptElement.h: (WebCore::ScriptElement::haveFiredLoadEvent): Added. (WebCore::ScriptElement::setHaveFiredLoadEvent): Added. (WebCore::ScriptElement::createdByParser): Added. (WebCore::ScriptElement::isEvaluated): Added.
  • html/HTMLScriptElement.cpp: (WebCore::HTMLScriptElement::dispatchLoadEvent): Calls haveFiredLoadEvent and setHaveFiredLoadEvent. (WebCore::HTMLScriptElement::cloneElementWithoutAttributesAndChildren): Calls isEvaluated.
  • html/HTMLScriptElement.h: (WebCore::HTMLScriptElement::text): Calls scriptContent. (WebCore::HTMLScriptElement::haveFiredLoadEvent): Calls haveFiredLoadEvent.
  • svg/SVGScriptElement.cpp: (WebCore::SVGScriptElement::svgAttributeChanged): Calls haveFiredLoadEvent and createdByParser. (WebCore::SVGScriptElement::insertedIntoDocument): Calls createdByParser. (WebCore::SVGScriptElement::finishParsingChildren): Calls setHaveFiredLoadEvent. (WebCore::SVGScriptElement::haveLoadedRequiredResources): Ditto. (WebCore::SVGScriptElement::dispatchLoadEvent): Calls haveFiredLoadEvent. (WebCore::SVGScriptElement::cloneElementWithoutAttributesAndChildren): Calls createdByParser, haveFiredLoadEvent, and setHaveFiredLoadEvent.
20:52 Changeset [72171] by antti@apple.com

https://bugs.webkit.org/show_bug.cgi?id=49320
Minor ResourceLoadScheduler cleanups

Reviewed by Darin Adler.

  • loader/ResourceLoadScheduler.cpp:

(WebCore::ResourceLoadScheduler::scheduleLoad):
(WebCore::ResourceLoadScheduler::servePendingRequests):
(WebCore::ResourceLoadScheduler::HostInformation::~HostInformation):
(WebCore::ResourceLoadScheduler::HostInformation::remove):
(WebCore::ResourceLoadScheduler::HostInformation::hasRequests):

  • loader/ResourceLoadScheduler.h:
20:27 Changeset [72170] by inferno@chromium.org

Merge 72166

BUG=63389

20:24 Changeset [72169] by inferno@chromium.org

Merge 72163

BUG=63389

20:13 Changeset [72168] by hyatt@apple.com

Add a baselineType member to RootInlineBox that caches whether the default baseline behavior for that
line should be ideographic or alphabetic. Add a requiresIdeographicsBaseline recursive function to
InlineFlowBox that scans for the use of any vertical fonts.

Reviewed by Sam Weinig.

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::requiresIdeographicBaseline):

  • rendering/InlineFlowBox.h:
  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::RootInlineBox):
(WebCore::RootInlineBox::alignBoxesInBlockDirection):

  • rendering/RootInlineBox.h:

(WebCore::RootInlineBox::baselineType):

19:35 Changeset [72167] by weinig@apple.com

Update WebKit2 skipped list.

Rubber-stamped by Jon Honeycutt.

  • platform/mac-wk2/Skipped:
19:24 Changeset [72166] by antti@apple.com

https://bugs.webkit.org/show_bug.cgi?id=31223
Make primitive values immutable.

Patch by Antti Koivisto <koivisto@iki.fi> on 2010-11-16
Reviewed by Adam Barth.

Update test cases for behavior change and test computed style too. Note that there are some
failures in the results demonstrating unrelated bugs in CSSPrimitiveValues.

  • fast/dom/script-tests/setPrimitiveValue-exceptions.js:

(checkThrows):

  • fast/dom/setPrimitiveValue.html:
  • fast/dom/setPrimitiveValue-exceptions-expected.txt
  • fast/dom/setPrimitiveValue-expected.txt
19:24 Changeset [72165] by hyatt@apple.com

Add FontBaseline.h and make ascent and descent take a baseline parameter so that both an
alphabetic and ideographic baseline can be requested.

Reviewed by Sam Weinig.

  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/Font.h:

(WebCore::Font::ascent):
(WebCore::Font::descent):

  • platform/graphics/FontBaseline.h: Added.
  • platform/graphics/SimpleFontData.h:

(WebCore::SimpleFontData::ascent):
(WebCore::SimpleFontData::descent):
(WebCore::SimpleFontData::height):

19:20 Changeset [72164] by hyatt@apple.com

Make sure the pref for minimum font size is just explicitly set to 0 every time,
since the bots have 1 stuck in their plist otherwise.

Reviewed by Sam Weinig.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(resetDefaultsToConsistentValues):

19:15 Changeset [72163] by antti@apple.com

https://bugs.webkit.org/show_bug.cgi?id=31223
Make primitive values immutable.

Patch by Antti Koivisto <koivisto@iki.fi> on 2010-11-16
Reviewed by Adam Barth.

Make CSSPrimitiveValue setFloatValue and setStringValue always throw NO_MODIFICATION_ALLOWED exception.

Reasoning:

  • these setters never worked correctly, style was not invalidated so changing values would have no effect on rendering
  • computed style is immutable in all cases, and it wasn't
  • no other engine seems to support mutable primitives, as a result there is no content using these APIs
  • mutable primitive values are pointless, the usual way to change the value of a propertly is to replace it with a new value
  • allowing mutation of primitive values makes optimizations harder
  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::setFloatValue):
(WebCore::CSSPrimitiveValue::setStringValue):

19:13 Changeset [72162] by weinig@apple.com

WebKit2: Support enabling site-specific quirks
<rdar://problem/8451371>
https://bugs.webkit.org/show_bug.cgi?id=46076

Reviewed by Adam Roben.

  • Shared/WebPreferencesStore.cpp:

(WebKit::WebPreferencesStore::WebPreferencesStore):
(WebKit::WebPreferencesStore::encode):
(WebKit::WebPreferencesStore::decode):

  • Shared/WebPreferencesStore.h:

Add needsSiteSpecificQuirks;

  • UIProcess/API/C/WKAPICast.h:

(WebKit::toFontSmoothingLevel):
(WebKit::toAPI):
Move FontSmoothing conversion functions here.

  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetFontSmoothingLevel):
(WKPreferencesGetFontSmoothingLevel):
(WKPreferencesSetAcceleratedCompositingEnabled):
(WKPreferencesGetAcceleratedCompositingEnabled):
(WKPreferencesSetCompositingBordersVisible):
(WKPreferencesGetCompositingBordersVisible):
(WKPreferencesSetCompositingRepaintCountersVisible):
(WKPreferencesGetCompositingRepaintCountersVisible):
(WKPreferencesSetNeedsSiteSpecificQuirks):
(WKPreferencesGetNeedsSiteSpecificQuirks):
Add WKPreferencesSetNeedsSiteSpecificQuirks/WKPreferencesGetNeedsSiteSpecificQuirks
and move implementations from WKPreferencesPrivate.cpp here.

  • UIProcess/API/C/WKPreferencesPrivate.cpp: Removed.
  • UIProcess/API/C/WKPreferencesPrivate.h:

Add Add WKPreferencesSetNeedsSiteSpecificQuirks/WKPreferencesGetNeedsSiteSpecificQuirks.

  • UIProcess/WebPreferences.cpp:

(WebKit::WebPreferences::setNeedsSiteSpecificQuirks):
(WebKit::WebPreferences::needsSiteSpecificQuirks):

  • UIProcess/WebPreferences.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):
Pipe through needsSiteSpecificQuirks.

  • WebKit2.xcodeproj/project.pbxproj:
  • WebKit2.pro:
  • win/WebKit2.vcproj:

Update for removed files.

19:11 Changeset [72161] by hyatt@apple.com

Update SVG layout test.

19:03 Changeset [72160] by barraclough@apple.com

Bug 49635 - Profiler implementation is fragile

Reviewed by Sam Weinig.

The profile presently requires the exception handling mechanism to explicitly
remove all stack frames that are exited during the exception unwind mechanism.
This is fragile in a number of ways:

  • We have to change bytecode register allocation when compiling code to run when profiling, to preserve the callee function (this is also required to call did_call after the call has returned).
  • In the JIT we have to maintain additional data structures (CodeBlock::RareData::m_functionRegisterInfos) to map back to the register containing the callee.
  • In the interpreter we use 'magic values' to offset into the instruction stream to rediscover the register containing the function.

Instead, move profiling into the head and tail of functions.

  • This correctly accounts the cost of the call itself to the caller.
  • This allows us to access the callee function object from the callframe.
  • This means that at the point a call is made we can track the stack depth on the ProfileNode.
  • When unwinding we can simply report the depth at which the exception is being handled - all call frames above this level are freed.

(JSC::CodeBlock::dump):
(JSC::CodeBlock::shrinkToFit):

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::bytecodeOffset):
(JSC::CodeBlock::methodCallLinkInfo):

  • bytecode/Opcode.h:
  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::emitCall):
(JSC::BytecodeGenerator::emitCallVarargs):
(JSC::BytecodeGenerator::emitReturn):
(JSC::BytecodeGenerator::emitConstruct):

  • bytecompiler/BytecodeGenerator.h:

(JSC::CallArguments::count):

  • bytecompiler/NodesCodegen.cpp:

(JSC::CallArguments::CallArguments):

  • interpreter/Interpreter.cpp:

(JSC::ProfileHostCall::ProfileHostCall):
(JSC::ProfileHostCall::~ProfileHostCall):
(JSC::Interpreter::unwindCallFrame):
(JSC::Interpreter::throwException):
(JSC::Interpreter::execute):
(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):
(JSC::Interpreter::privateExecute):

  • jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):

  • jit/JIT.h:
  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_profile_has_called):
(JSC::JIT::emit_op_profile_will_return):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_profile_has_called):
(JSC::JIT::emit_op_profile_will_return):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • jit/JITStubs.h:
  • profiler/Profile.cpp:

(JSC::Profile::Profile):

  • profiler/ProfileGenerator.cpp:

(JSC::ProfileGenerator::addParentForConsoleStart):
(JSC::ProfileGenerator::willExecute):
(JSC::ProfileGenerator::didExecute):
(JSC::ProfileGenerator::exceptionUnwind):
(JSC::ProfileGenerator::stopProfiling):

  • profiler/ProfileGenerator.h:
  • profiler/ProfileNode.cpp:

(JSC::ProfileNode::ProfileNode):
(JSC::ProfileNode::willExecute):

  • profiler/ProfileNode.h:

(JSC::ProfileNode::create):
(JSC::ProfileNode::operator==):
(JSC::ProfileNode::exec):

  • profiler/Profiler.cpp:

(JSC::dispatchFunctionToProfiles):
(JSC::Profiler::hasCalled):
(JSC::Profiler::willEvaluate):
(JSC::Profiler::willReturn):
(JSC::Profiler::didEvaluate):
(JSC::Profiler::exceptionUnwind):

  • profiler/Profiler.h:
18:58 Changeset [72159] by bweinstein@apple.com

Touch Platform.h to force a rebuild for Windows.

Reviewed by Adam Roben and Steve Falkenburg.

  • wtf/Platform.h:
18:39 Changeset [72158] by sfalken@apple.com

Force a clean build for Windows projects using precompiled headers. Unreviewed.

18:37 Changeset [72157] by mihaip@chromium.org

2010-11-16 Mihai Parparita <mihaip@chromium.org>

Reviewed by Tony Chang.

Rebaseline server: display test results
https://bugs.webkit.org/show_bug.cgi?id=49626

Adds basic result display to the rebaseline server. On the Python side
this involves:

  • Parsing the unexpected_results.json into a dictionary.
  • Serving it as JSON under /results.json. (the JSON -> dict -> JSON transform isn't strictly necessary right now, but I'll need to have access to the parsed results on the Python side for follow-up changes).

On the web UI side this adds:

  • Markup for display image and text results (expected, actual, diff), and JS for populating it.
  • Markup for breaking down test results by failure type and directory, and JS for populating it.
  • Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
  • Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
  • Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
  • Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js: Added.
  • Scripts/webkitpy/tool/commands/rebaselineserver.py:
18:24 Changeset [72156] by dpranke@chromium.org

2010-11-16 Dirk Pranke <dpranke@chromium.org>

Reviewed by Ojan Vafai.

See Chromium issue http://codereview.chromium.org/5133001/ - we
are modifying the build bots to pass in the builder name with
the "GPU" string appended instead of appending it in the code.

https://bugs.webkit.org/show_bug.cgi?id=49636

  • Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
18:21 Changeset [72155] by aroben@apple.com

Fix horizontal scrolling via the mousewheel/trackpad on Windows

Reviewed by Mark Rowe.

  • Shared/win/WebEventFactory.cpp: Fixed typo in the

WM_VISTA_MOUSEHWHEEL constant.

18:20 Changeset [72154] by mihaip@chromium.org

2010-11-16 Mihai Parparita <mihaip@chromium.org>

Update the pixel expectations for fast/reflections, fast/replaced, fast/ruby, fast/runin, and fast/text for the Mac port.

For the tests that currently fail on Snow Leopard with --pixel-tests
--tolerance 0, this moves the current pixel results to mac-leopard and
adds new Snow Leopard-specific results to platform/mac.

List of files omitted due to length but composed entirely of moves from
platform/mac to platform/mac-leopard and newly added files in
platform/mac.

17:49 Changeset [72153] by mihaip@chromium.org

2010-11-16 Mihai Parparita <mihaip@chromium.org>

Update the pixel expectations for fast/html, fast/images, fast/innerHTML, fast/inspector-support, fast/loader, fast/media, fast/multicol, and fast/parser for the Mac port.

For the tests that currently fail on Snow Leopard with --pixel-tests
--tolerance 0, this moves the current pixel results to mac-leopard and
adds new Snow Leopard-specific results to platform/mac.

List of files omitted due to length but composed entirely of moves from
platform/mac to platform/mac-leopard and newly added files in
platform/mac.

Also includes updated baselines for fast/forms after r72052 changed how
placeholders are rendered.

17:03 Changeset [72152] by sfalken@apple.com

2010-11-16 Steve Falkenburg <sfalken@apple.com>

Reviewed by Adam Roben.

Disable LTCG for Windows Release builds. Add new Release_LTCG configuration.
https://bugs.webkit.org/show_bug.cgi?id=49632

2010-11-16 Steve Falkenburg <sfalken@apple.com>

Reviewed by Adam Roben.

Disable LTCG for Windows Release builds. Add new Release_LTCG configuration.
https://bugs.webkit.org/show_bug.cgi?id=49632

  • WebKit.vcproj/Interfaces.vcproj:
  • WebKit.vcproj/WebKit.make:
  • WebKit.vcproj/WebKit.sln:
  • WebKit.vcproj/WebKit.submit.sln:
  • WebKit.vcproj/WebKit.vcproj:
  • WebKit.vcproj/WebKitGUID.vcproj:

2010-11-16 Steve Falkenburg <sfalken@apple.com>

Reviewed by Adam Roben.

Disable LTCG for Windows Release builds. Add new Release_LTCG configuration.
https://bugs.webkit.org/show_bug.cgi?id=49632

  • WebCore.vcproj/QTMovieWin.vcproj:
  • WebCore.vcproj/WebCore.make:
  • WebCore.vcproj/WebCore.sln:
  • WebCore.vcproj/WebCore.vcproj:

2010-11-16 Steve Falkenburg <sfalken@apple.com>

Reviewed by Adam Roben.

Disable LTCG for Windows Release builds. Add new Release_LTCG configuration.
https://bugs.webkit.org/show_bug.cgi?id=49632

  • DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
  • DumpRenderTree/win/DumpRenderTree.vcproj:
  • DumpRenderTree/win/ImageDiff.vcproj:
  • MiniBrowser/MiniBrowser.vcproj:
  • TestWebKitAPI/win/TestWebKitAPI.vcproj:
  • WebKitLauncherWin/WebKitLauncherWin.vcproj:
  • WebKitTestRunner/win/InjectedBundle.vcproj:
  • WebKitTestRunner/win/WebKitTestRunner.vcproj:
  • WinLauncher/WinLauncher.vcproj:
  • record-memory-win/record-memory-win.vcproj:

2010-11-16 Steve Falkenburg <sfalken@apple.com>

Reviewed by Adam Roben.

Disable LTCG for Windows Release builds. Add new Release_LTCG configuration.
https://bugs.webkit.org/show_bug.cgi?id=49632

  • win/WebKit2.make:
  • win/WebKit2.submit.sln:
  • win/WebKit2.vcproj:
  • win/WebKit2WebProcess.vcproj:
17:02 Changeset [72151] by mrowe@apple.com

Versioning.

16:49 Changeset [72150] by mrowe@apple.com

New tag.

16:36 Changeset [72149] by dpranke@chromium.org

2010-11-16 Dirk Pranke <dpranke@chromium.org>

Reviewed by Ojan Vafai.

new-run-webkit-tests: rename TestInfo to TestInput, move image hash to work thread

Rename the TestInfo class to TestInput to be clearer about its
function, and move the checksum-reading code into dump_render_tree_thread
to avoid cross-thread access.

https://bugs.webkit.org/show_bug.cgi?id=49573

  • Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
16:19 Changeset [72148] by andersca@apple.com

Handle converting a ResourceHandle to a download
https://bugs.webkit.org/show_bug.cgi?id=49631

Reviewed by Sam Weinig.

  • WebProcess/Downloads/Download.h:

Add startWithHandle.

  • WebProcess/Downloads/DownloadManager.h:
  • WebProcess/Downloads/DownloadManager.cpp:

(WebKit::DownloadManager::convertHandleToDownload):
Create a new Download object and call startWithHandle on it.

  • WebProcess/Downloads/cf/DownloadCFNet.cpp:

(WebKit::Download::startWithHandle):
Add stub.

  • WebProcess/Downloads/mac/DownloadMac.mm:

(WebKit::Download::startWithHandle):
Create an NSURLDownload object from passed in ResourceHandle.

  • WebProcess/Downloads/qt/DownloadQt.cpp:

(WebKit::Download::startWithHandle):
Add stub.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::download):
Call WebFrame::convertHandleToDownload.

  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::convertHandleToDownload):
Call DownloadManager::convertHandleToDownload.

16:18 Changeset [72147] by hyatt@apple.com

Fix bustage. Remove the minimum font size pref setting in DumpRenderTree.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(resetDefaultsToConsistentValues):

15:54 Changeset [72146] by slewis@apple.com

<rdar://problem/8624267> Leak creating offscreen webview running fast/dom tests

Reviewed by Geoff Garen.

WebKit/mac:

Make a static provider for WebDeviceOrientationProviderMock. The old code allocated a new WebDeviceOrientationProviderMock for
every WebView, and the WebKit API doesn't support that ownership model.

  • WebView/WebDeviceOrientationProviderMock.h:
  • WebView/WebDeviceOrientationProviderMock.mm:

(+[WebDeviceOrientationProviderMock shared]):

WebKitTools:

Use shared DeviceOrientationProviderMock. The old allocation method created a new WebDeviceOrientationProviderMock
for every WebView, and the WebKit API doesn't support that ownership model.

I also fixed a leak in setMockDeviceOrientation by adding a missing release.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(createWebViewAndOffscreenWindow):

  • DumpRenderTree/mac/LayoutTestControllerMac.mm:

(LayoutTestController::setMockDeviceOrientation):

15:52 Changeset [72145] by andersca@apple.com

Set the original URL for downloads
https://bugs.webkit.org/show_bug.cgi?id=49628

Reviewed by John Sullivan.

WebCore:

Export symbols needed by WebKit2.

  • WebCore.exp.in:

WebKit2:

  • WebProcess/Downloads/DownloadManager.cpp:

(WebKit::DownloadManager::startDownload):

  • WebProcess/Downloads/DownloadManager.h:

startDownload now takes the originating web page.

  • WebProcess/Downloads/cf/DownloadCFNet.cpp:

(WebKit::Download::start):
start now takes the originating web page.

  • WebProcess/Downloads/mac/DownloadMac.mm:

(WebKit::originatingURL):
(WebKit::setOriginalURLForDownload):
Port code over from WebKit1 that sets the download URL.

(WebKit::Download::start):
Call setOriginalURLForDownload.

  • WebProcess/Downloads/qt/DownloadQt.cpp:

(WebKit::Download::start):
start now takes the originating web page.

  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::startDownload):
Pass the web page to DownloadManager::startDownload.

15:44 Changeset [72144] by hamaji@chromium.org

Merge 71892 - 2010-11-11 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Darin Adler.

REGRESSION: window.print in onload doesn't fire if there's an img
https://bugs.webkit.org/show_bug.cgi?id=48195

This issue was introduced in
https://bugs.webkit.org/show_bug.cgi?id=43658
This happens because FrameLoader::isLoading() is false while an
image is still loading. Now, window.print() happens after all
resources are loaded.

Also changed the name of a member variable as Darin suggested in Bug 43658.

Added a manual test as DRT doesn't support window.print() yet.

  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::DocumentLoader): (WebCore::DocumentLoader::updateLoading):
  • loader/DocumentLoader.h:
  • page/DOMWindow.cpp: (WebCore::DOMWindow::DOMWindow): (WebCore::DOMWindow::print): (WebCore::DOMWindow::finishedLoading):
  • page/DOMWindow.h:

TBR=hamaji@chromium.org

15:32 Changeset [72143] by dpranke@chromium.org

2010-11-16 Dirk Pranke <dpranke@chromium.org>

Reviewed by Ojan Vafai.

new-run-webkit-tests: log the process id in --verbose mode

As part of the switch to multi-process mode, we should log the
process id when running w/ --verbose.

https://bugs.webkit.org/show_bug.cgi?id=49571

  • Scripts/webkitpy/layout_tests/layout_package/printing.py:
15:29 Changeset [72142] by inferno@chromium.org

Merge 72046

BUG=63268

15:28 Changeset [72141] by hyatt@apple.com

https://bugs.webkit.org/show_bug.cgi?id=11004

Reviewed by Dan Bernstein.

font-size:0 is ignored. Remove the minimum font size of 1 in CSSStyleSelector.
Change the pref value for minimum font size from 1 to 0. Make sure to never use the NSFont's size,
since it doesn't honor a size of 0. Instead pass the size in to the FontPlatformData(NSFont*) version
of the constructor rather than using [NSFont pointSize].

https://bugs.webkit.org/show_bug.cgi?id=49582

Negative leading is not handled correctly. There are two bugs here. The first is that
maxAscent and maxDescent can be negative, so we need a notion of whether or not we have
set them before so that we can allow them to be < 0.

The second issue is that we should understand where fonts will end up relative to
our baseline (excluding line height), and only allow those boxes to impact ascent and
descent if the actual font box (without factoring in line height) is above or below the
root line box baseline.

Added fast/css/negative-leading.html

These two bug fixes have to land together to keep the Acid 3 test rendering correctly.

WebCore:

  • WebCore.exp.in:
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::getComputedSizeFromSpecifiedSize):

  • platform/graphics/cocoa/FontPlatformData.h:
  • platform/graphics/cocoa/FontPlatformDataCocoa.mm:

(WebCore::FontPlatformData::FontPlatformData):

  • platform/graphics/mac/FontCacheMac.mm:

(WebCore::FontCache::getFontDataForCharacters):
(WebCore::FontCache::createFontPlatformData):

  • platform/graphics/mac/SimpleFontDataMac.mm:

(WebCore::SimpleFontData::smallCapsFontData):

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::computeLogicalBoxHeights):

  • rendering/InlineFlowBox.h:
  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::alignBoxesInBlockDirection):

WebKit/mac:

  • Misc/WebKitNSStringExtras.mm:

(-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]):
(-[NSString _web_widthWithFont:]):

  • Misc/WebStringTruncator.mm:

(fontFromNSFont):

  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]):

WebKit/win:

  • WebPreferences.cpp:

(WebPreferences::initializeDefaultSettings):

WebKit2:

  • Shared/WebPreferencesStore.cpp:

(WebKit::WebPreferencesStore::WebPreferencesStore):

LayoutTests:

  • fast/css/negative-leading.html: Added.
  • platform/mac/fast/compact/001-expected.checksum:
  • platform/mac/fast/compact/001-expected.png:
  • platform/mac/fast/compact/001-expected.txt:
  • platform/mac/fast/css/negative-leading-expected.checksum: Added.
  • platform/mac/fast/css/negative-leading-expected.png: Added.
  • platform/mac/fast/css/negative-leading-expected.txt: Added.
  • platform/mac/fast/forms/linebox-overflow-in-textarea-padding-expected.checksum:
  • platform/mac/fast/forms/linebox-overflow-in-textarea-padding-expected.png:
  • platform/mac/fast/forms/linebox-overflow-in-textarea-padding-expected.txt:
  • platform/mac/fast/parser/style-script-head-test-expected.png:
15:27 Changeset [72140] by commit-queue@webkit.org

2010-11-16 Peter Varga <pvarga@inf.u-szeged.hu>

Reviewed by Gavin Barraclough.

The number of recursive match calls isn't limited in YARR Interpreter
https://bugs.webkit.org/show_bug.cgi?id=47906

Check the number of the matchDisjunction recursive calls to avoid unbounded
recursion.
Now the matchDisjunction function returns JSRegExpResult instead of bool.
The JSRegExpResult enum contains the result of matching or the error code
of the failure (like HitLimit) which terminates the matching.
The error codes are based on pcre's jsRegExpExecute error codes.

  • yarr/RegexInterpreter.cpp: (JSC::Yarr::Interpreter::parenthesesDoBacktrack): (JSC::Yarr::Interpreter::matchParentheses): (JSC::Yarr::Interpreter::backtrackParentheses): (JSC::Yarr::Interpreter::matchDisjunction): (JSC::Yarr::Interpreter::matchNonZeroDisjunction): (JSC::Yarr::Interpreter::interpret): (JSC::Yarr::Interpreter::Interpreter):
  • yarr/RegexInterpreter.h:
15:23 Changeset [72139] by inferno@chromium.org

Merge 72135

BUG=63031

14:55 Changeset [72138] by levin@chromium.org

Removed lines for tests that are now passing after r72137.

  • platform/chromium/test_expectations.txt:
14:51 Changeset [72137] by darin@apple.com

https://bugs.webkit.org/show_bug.cgi?id=49611
REGRESSION (r72115): 5 layout tests are broken

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadFrameRequest): Roll change from
https://bugs.webkit.org/show_bug.cgi?id=48603 out. I'll roll
it back in after fixing the failing tests.

14:43 Changeset [72136] by sfalken@apple.com

2010-11-16 Steve Falkenburg <sfalken@apple.com>

Reviewed by Adam Roben.

Use vsprops files for common settings in Windows WebKit
https://bugs.webkit.org/show_bug.cgi?id=49622

  • WebKit.vcproj/WebKit.vcproj:
  • WebKit.vcproj/WebKitCommon.vsprops: Added.
14:08 Changeset [72135] by mitz@apple.com

<rdar://problem/8672000> REGRESSION (r72040): Error image with alt text can cause style to be frozen in a subtree
https://bugs.webkit.org/show_bug.cgi?id=49579

Reviewed by Simon Fraser.

WebCore:

r72040 introduced a call to setNeedsStyleRecalc() from RenderImage::imageChanged(). When imageChanged()
got called beneath recalcStyle() on some ancestor element, the result was that the ancestor’s
childNeedsStyleRecalc flag got cleared, but its descendants all the way down to the image did not.
Thereafter, setNeedsStyleRecalc() would fail to propagate from that subtree up to the root. The fix
is to avoid the newly-added setNeedsStyleRecalc() in most cases, including during reclacStyle(), and
just keep it for when it is needed.

Tests: fast/block/float/015.html

fast/images/style-access-during-imageChanged-style-freeze.html

  • dom/Document.cpp:

(WebCore::Document::isPendingStyleRecalc): Added.

  • dom/Document.h:
  • rendering/RenderImage.cpp:

(WebCore::RenderImage::imageChanged): Only defer intrinsic size compoutation if a style recalc
is coming (indicating that current style() is stale).

LayoutTests:

  • fast/block/float/015.html: Copied from LayoutTests/fast/block/float/015.html-disabled.
  • fast/block/float/015.html-disabled: Removed.
  • fast/images/style-access-during-imageChanged-style-freeze-expected.txt: Added.
  • fast/images/style-access-during-imageChanged-style-freeze.html: Added.
13:56 Changeset [72134] by bweinstein@apple.com

Rest of the Windows build fix.

13:52 WinCE edited by paroga@webkit.org
(diff)
13:44 Changeset [72133] by levin@chromium.org

Unreviewed Chromium expectations update.

  • platform/chromium/test_expectations.txt: Added the failure expectations for 5 tests which are failing due to r72115 (and filed bug 49620 about the issue).
13:41 Changeset [72132] by barraclough@apple.com

Windows build fix pt 1.

13:30 Changeset [72131] by andersca@apple.com

Fix clang++ build.

  • Scripts/webkit2/messages.py:
  • WebProcess/WebPage/WebInspector.h:
13:23 Changeset [72130] by zmo@google.com

2010-11-11 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Implement UNPACK_COLORSPACE_CONVERSION_WEBGL
https://bugs.webkit.org/show_bug.cgi?id=47196

  • src/WebImageDecoder.cpp: (WebKit::WebImageDecoder::init): Add ignoreGammaAndColorProfile parameter.

2010-11-11 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Implement UNPACK_COLORSPACE_CONVERSION_WEBGL
https://bugs.webkit.org/show_bug.cgi?id=47196

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::texImage2DImpl): Apply UNPACK_COLORSPACE_CONVERSION settings to image uploading. (WebCore::WebGLRenderingContext::texSubImage2DImpl): Ditto.
  • platform/graphics/GraphicsContext3D.cpp: (WebCore::GraphicsContext3D::extractImageData): Ditto.
  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/ImageSource.cpp: (WebCore::ImageSource::ImageSource): Add ignoreGammaColorProfile parameter. (WebCore::ImageSource::setData): Ditto.
  • platform/graphics/ImageSource.h:
  • platform/graphics/cg/GraphicsContext3DCG.cpp: (WebCore::GraphicsContext3D::getImageData): Ditto.
  • platform/graphics/cg/ImageSourceCG.cpp: (WebCore::ImageSource::ImageSource): Ditto.
  • platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3D::getImageData): Ditto.
  • platform/graphics/qt/ImageDecoderQt.cpp: (WebCore::ImageDecoder::create): Ditto. (WebCore::ImageDecoderQt::ImageDecoderQt): Ditto.
  • platform/graphics/qt/ImageDecoderQt.h:
  • platform/graphics/skia/GraphicsContext3DSkia.cpp: (WebCore::GraphicsContext3D::getImageData): Ditto.
  • platform/image-decoders/ImageDecoder.cpp: (WebCore::ImageDecoder::create): Ditto.
  • platform/image-decoders/ImageDecoder.h: (WebCore::ImageDecoder::ImageDecoder): Ditto.
  • platform/image-decoders/bmp/BMPImageDecoder.cpp: (WebCore::BMPImageDecoder::BMPImageDecoder):
  • platform/image-decoders/bmp/BMPImageDecoder.h:
  • platform/image-decoders/gif/GIFImageDecoder.cpp: (WebCore::GIFImageDecoder::GIFImageDecoder): Ditto.
  • platform/image-decoders/gif/GIFImageDecoder.h:
  • platform/image-decoders/ico/ICOImageDecoder.cpp: (WebCore::ICOImageDecoder::ICOImageDecoder): Ditto. (WebCore::ICOImageDecoder::decodeAtIndex): Ditto.
  • platform/image-decoders/ico/ICOImageDecoder.h:
  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp: (WebCore::JPEGImageDecoder::JPEGImageDecoder): Ditto.
  • platform/image-decoders/jpeg/JPEGImageDecoder.h:
  • platform/image-decoders/png/PNGImageDecoder.cpp: (WebCore::PNGImageDecoder::PNGImageDecoder): Ditto. (WebCore::PNGImageDecoder::headerAvailable): Ignore gamma settings if ignoreGammaAndColorProfile is true.
  • platform/image-decoders/png/PNGImageDecoder.h:
  • platform/image-decoders/webp/WEBPImageDecoder.cpp: (WebCore::WEBPImageDecoder::WEBPImageDecoder): Add ignoreGammaAndColorProfile parameter.
  • platform/image-decoders/webp/WEBPImageDecoder.h:

2010-11-11 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Implement UNPACK_COLORSPACE_CONVERSION_WEBGL
https://bugs.webkit.org/show_bug.cgi?id=47196

  • fast/canvas/webgl/gl-teximage-expected.txt:
  • fast/canvas/webgl/gl-teximage.html: Testing that if UNPACK_COLORSPACE_CONVERSION is NONE, gamma settings are not applied to images.
13:15 Changeset [72129] by andersca@apple.com

Fix clang++ build.

  • WebCoreSupport/WebFrameLoaderClient.mm:
13:12 Changeset [72128] by eric.carlson@apple.com

2010-11-16 Eric Carlson <eric.carlson@apple.com>

Unreviewed attempt to fix GTK build after http://trac.webkit.org/changeset/72117

  • platform/graphics/MediaPlayer.cpp: (WebCore::installedMediaEngines):
13:11 Changeset [72127] by barraclough@apple.com

JavaScriptCore: https://bugs.webkit.org/show_bug.cgi?id=49606

Reviewed by Oliver Hunt.

The bug here is that we read the prototype from the RHS argument using a regular
op_get_by_id before op_instanceof has checked that this is an object implementing
HasInstance. This incorrect behaviour gives rise to further unnecessary complexity
in the code base, since we have additional logic (implemented using the
GetByIdExceptionInfo data structures on CodeBlock) to convert not an object errors
from the get_by_id into invalid parameter errors. Having fixed this bug this code
is all redundant, since in these cases the get_by_id will never have been reached.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dump):
(JSC::CodeBlock::shrinkToFit):

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::addExpressionInfo):

  • bytecode/Opcode.h:
  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::emitCheckHasInstance):

  • bytecompiler/BytecodeGenerator.h:
  • bytecompiler/NodesCodegen.cpp:

(JSC::InstanceOfNode::emitBytecode):

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::throwException):
(JSC::Interpreter::privateExecute):

  • jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):

  • jit/JIT.h:
  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_check_has_instance):
(JSC::JIT::emit_op_instanceof):
(JSC::JIT::emitSlow_op_check_has_instance):
(JSC::JIT::emitSlow_op_instanceof):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_check_has_instance):
(JSC::JIT::emit_op_instanceof):
(JSC::JIT::emitSlow_op_check_has_instance):
(JSC::JIT::emitSlow_op_instanceof):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • jit/JITStubs.h:
  • runtime/ExceptionHelpers.cpp:

(JSC::createInterruptedExecutionException):
(JSC::createTerminatedExecutionException):
(JSC::createUndefinedVariableError):
(JSC::createNotAFunctionError):
(JSC::createNotAnObjectError):

  • runtime/ExceptionHelpers.h:
  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):

  • runtime/JSGlobalData.h:
  • runtime/JSNotAnObject.cpp:

(JSC::JSNotAnObject::toPrimitive):
(JSC::JSNotAnObject::getPrimitiveNumber):
(JSC::JSNotAnObject::toBoolean):
(JSC::JSNotAnObject::toNumber):
(JSC::JSNotAnObject::toString):
(JSC::JSNotAnObject::toObject):
(JSC::JSNotAnObject::getOwnPropertySlot):
(JSC::JSNotAnObject::getOwnPropertyDescriptor):
(JSC::JSNotAnObject::put):
(JSC::JSNotAnObject::deleteProperty):
(JSC::JSNotAnObject::getOwnPropertyNames):

  • runtime/JSNotAnObject.h:

(JSC::JSNotAnObject::JSNotAnObject):

  • runtime/JSObject.h:

(JSC::JSObject::isActivationObject):

  • runtime/JSValue.cpp:

(JSC::JSValue::toObjectSlowCase):
(JSC::JSValue::synthesizeObject):
(JSC::JSValue::synthesizePrototype):

LayoutTests: Bug 49606 - instanceof should only get the prototype property if the RHS operand implements HasInstance

Reviewed by Oliver Hunt.

  • fast/js/instanceof-XMLHttpRequest-expected.txt: Copied from LayoutTests/fast/js/instanceof-operator-expected.txt.
  • fast/js/instanceof-XMLHttpRequest.html: Copied from LayoutTests/fast/js/instanceof-operator.html.
  • fast/js/script-tests/instanceof-XMLHttpRequest.js: Copied from LayoutTests/fast/js/script-tests/instanceof-operator.js.
    • renamed existing testcase; these really test XMLHttpRequest objects, rather than the instanceof operator.
  • fast/js/instanceof-operator-expected.txt:
  • fast/js/script-tests/instanceof-operator.js:
    • added test case for: javascript: ({} instanceof { get prototype(){ alert("Error!"); } })
12:49 Changeset [72126] by andersca@apple.com

Add WKPageCanShowMIMEType
https://bugs.webkit.org/show_bug.cgi?id=49612

Reviewed by Sam Weinig.

  • UIProcess/API/C/WKPage.cpp:

(WKPageCanShowMIMEType):

  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::canShowMIMEType):

  • UIProcess/WebPageProxy.h:
11:39 Changeset [72125] by ossy@webkit.org

Unreviewed. Update Qt specific expected results after r72116.

Remove CSS Variable support
https://bugs.webkit.org/show_bug.cgi?id=49483

  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-expected.txt:
  • platform/qt/fast/js/global-constructors-expected.txt:
11:30 Changeset [72124] by zmo@google.com

2010-11-12 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Refactor GL backend flags
https://bugs.webkit.org/show_bug.cgi?id=49460

  • public/WebGraphicsContext3D.h: Remove GL flag queries at this level.
  • src/GraphicsContext3DChromium.cpp: Ditto.
  • src/GraphicsContext3DInternal.h: Ditto.
  • src/WebGraphicsContext3DDefaultImpl.cpp: Ditto.
  • src/WebGraphicsContext3DDefaultImpl.h: Ditto.

2010-11-12 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Refactor GL backend flags
https://bugs.webkit.org/show_bug.cgi?id=49460

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::WebGLRenderingContext): Call setupFlags(). (WebCore::WebGLRenderingContext::initializeNewContext): Remove flag initialization to setupFlags(). (WebCore::WebGLRenderingContext::setupFlags): Initialize GL flags. (WebCore::WebGLRenderingContext::getRenderbufferParameter): Use accessor function instead of member. (WebCore::WebGLRenderingContext::renderbufferStorage): Ditto.
  • html/canvas/WebGLRenderingContext.h: Use flags set in setupFlags instead of querying underlying GL implementation. (WebCore::WebGLRenderingContext::isGLES2Compliant): (WebCore::WebGLRenderingContext::isGLES2NPOTStrict): (WebCore::WebGLRenderingContext::isErrorGeneratedOnOutOfBoundsAccesses): (WebCore::WebGLRenderingContext::isResourceSafe): (WebCore::WebGLRenderingContext::isDepthStencilSupported):
  • platform/graphics/Extensions3D.h: Add NPOT extension.
  • platform/graphics/GraphicsContext3D.h: Remove GL flag queries at this level.
  • platform/graphics/chromium/Extensions3DChromium.h: Add resource_safe and strict_attribs extensions.
  • platform/graphics/mac/GraphicsContext3DMac.mm: Remove GL flag queries at this level.
11:19 Changeset [72123] by kbr@google.com

2010-11-16 Kenneth Russell <kbr@google.com>

Reviewed by Dimitri Glazkov.

WebIDL conversions from string to number and array to number should not generate TypeError
https://bugs.webkit.org/show_bug.cgi?id=49218

Recent SVG-related changes to the StrictTypeChecking extended attribute in
CodeGeneratorJS.pm and CodeGeneratorV8.pm were not correct according to the Web IDL and
ECMA-262 specifications. In particular, when an attribute or function argument is specified
as a number type (floating-point or integer), passing in a String or object is not supposed
to raise an exception.

The original intent of the StrictTypeChecking extended attribute was to properly raise
TypeError when an interface type is required, but the supplied object does not implement the
interface type (http://dev.w3.org/2006/webapi/WebIDL/#es-interface). Historically WebKit has
silently passed null to the C++ bindings in this case. The handling of strings in the
original StrictTypeChecking implementation was also incorrect, raising exceptions when it
should not.

The semantics of StrictTypeChecking have been changed to enforce only the restrictions on
interface types. The V8 custom bindings for WebGL have been updated to match the behavior of
the autogenerated code.

Test: fast/canvas/webgl/type-conversion-test.html

  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp: (WebCore::getObjectParameter): (WebCore::V8WebGLRenderingContext::getFramebufferAttachmentParameterCallback): (WebCore::V8WebGLRenderingContext::getParameterCallback): (WebCore::V8WebGLRenderingContext::getProgramParameterCallback): (WebCore::V8WebGLRenderingContext::getShaderParameterCallback): (WebCore::vertexAttribAndUniformHelperf):

2010-11-16 Kenneth Russell <kbr@google.com>

Reviewed by Dimitri Glazkov.

WebIDL conversions from string to number and array to number should not generate TypeError
https://bugs.webkit.org/show_bug.cgi?id=49218

Updated SVG tests which were incorrectly expecting exceptions to be raised when the Web IDL
and ECMA-262 specifications state that none should be. Incorporated WebGL test from Khronos
repository verifying the passing objects of various types to APIs.

Ran all layout tests in Safari on Mac OS X.

  • fast/canvas/webgl/type-conversion-test-expected.txt: Added.
  • fast/canvas/webgl/type-conversion-test.html: Added.
  • svg/dom/SVGAngle-expected.txt:
  • svg/dom/SVGAnimatedBoolean-expected.txt:
  • svg/dom/SVGAnimatedEnumeration-expected.txt:
  • svg/dom/SVGAnimatedInteger-expected.txt:
  • svg/dom/SVGAnimatedNumber-expected.txt:
  • svg/dom/SVGLength-expected.txt:
  • svg/dom/SVGMatrix-expected.txt:
  • svg/dom/SVGNumber-expected.txt:
  • svg/dom/SVGPoint-expected.txt:
  • svg/dom/SVGPreserveAspectRatio-expected.txt:
  • svg/dom/SVGRect-expected.txt:
  • svg/dom/SVGTransform-expected.txt:
  • svg/dom/script-tests/SVGAngle.js:
  • svg/dom/script-tests/SVGAnimatedBoolean.js:
  • svg/dom/script-tests/SVGAnimatedEnumeration.js:
  • svg/dom/script-tests/SVGAnimatedInteger.js:
  • svg/dom/script-tests/SVGAnimatedNumber.js:
  • svg/dom/script-tests/SVGLength.js:
  • svg/dom/script-tests/SVGMatrix.js:
  • svg/dom/script-tests/SVGNumber.js:
  • svg/dom/script-tests/SVGPoint.js:
  • svg/dom/script-tests/SVGPreserveAspectRatio.js:
  • svg/dom/script-tests/SVGRect.js:
  • svg/dom/script-tests/SVGTransform.js:
11:00 Changeset [72122] by andersca@apple.com

Make WebPageProxy::decidePolicyForMIMEType a tad synchronous
https://bugs.webkit.org/show_bug.cgi?id=49605

Reviewed by Sam Weinig.

Change the DecidePolicyForMIMEType message to be synchronous, and if the policy listener is
invoked from within the decidePolicyForMIMEType callback return the policy information as out
parameters. This is needed in order to convert a loading connection to a download.

  • Platform/CoreIPC/HandleMessage.h:

(CoreIPC::callMemberFunction):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::receivedPolicyDecision):
(WebKit::WebPageProxy::decidePolicyForMIMEType):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForMIMEType):

10:58 Changeset [72121] by ap@apple.com

Windows build fix.

  • DerivedSources.cpp: Removing CSS Variables generated files.
10:50 Changeset [72120] by sfalken@apple.com

Remove unnecessary def file, remove outdated def files from vcproj.

Rubber stamped by Adam Roben.

  • WebKit.vcproj/WebKit.vcproj:
  • WebKit.vcproj/WebKit_debug.def: Removed.
10:44 Changeset [72119] by eric.carlson@apple.com

2010-11-16 Eric Carlson <eric.carlson@apple.com>

Reviewed by John Sullivan.

getMIMEType(s)ForExtension should consult system mapping
https://bugs.webkit.org/show_bug.cgi?id=49497

No new tests possible.

  • platform/MIMETypeRegistry.cpp: (WebCore::MIMETypeRegistry::getMediaMIMETypeForExtension): Add the type returned by getMIMETypeForExtension. Put the result of mediaMIMETypeMap().get() in a local variable and test instead of calling constains() and then get(). (WebCore::MIMETypeRegistry::getMediaMIMETypesForExtension): Ditto.
10:35 Changeset [72118] by sfalken@apple.com

Unreviewed baseline update for Windows.
Update test expectations following r72052.

  • platform/win/fast/blockflow/vertical-font-fallback-expected.txt: Added.
  • platform/win/fast/forms/search-placeholder-value-changed-expected.txt:
  • platform/win/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
  • platform/win/fast/forms/textarea-placeholder-set-attribute-expected.txt:
10:28 Changeset [72117] by eric.carlson@apple.com

2010-11-16 Eric Carlson <eric.carlson@apple.com>

Reviewed by Darin Adler.

Rename QTKit based media engine class name
https://bugs.webkit.org/show_bug.cgi?id=36663

No new tests as this just renames a class and restructures existing code.

  • platform/graphics/MediaPlayer.cpp: (WebCore::installedMediaEngines): Use a macro with the platform media player class name to reduce the number of #ifs in the code.
  • platform/graphics/mac/MediaPlayerPrivateQTKit.h: Rename MediaPlayerPrivate to MediaPlayerPrivateQTKit.
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivateQTKit::create): (WebCore::MediaPlayerPrivateQTKit::registerMediaEngine): (WebCore::MediaPlayerPrivateQTKit::MediaPlayerPrivateQTKit): (WebCore::MediaPlayerPrivateQTKit::~MediaPlayerPrivateQTKit): (WebCore::MediaPlayerPrivateQTKit::createQTMovie): (WebCore::MediaPlayerPrivateQTKit::createQTMovieView): (WebCore::MediaPlayerPrivateQTKit::detachQTMovieView): (WebCore::MediaPlayerPrivateQTKit::createQTVideoRenderer): (WebCore::MediaPlayerPrivateQTKit::destroyQTVideoRenderer): (WebCore::MediaPlayerPrivateQTKit::createQTMovieLayer): (WebCore::MediaPlayerPrivateQTKit::destroyQTMovieLayer): (WebCore::MediaPlayerPrivateQTKit::currentRenderingMode): (WebCore::MediaPlayerPrivateQTKit::preferredRenderingMode): (WebCore::MediaPlayerPrivateQTKit::setUpVideoRendering): (WebCore::MediaPlayerPrivateQTKit::tearDownVideoRendering): (WebCore::MediaPlayerPrivateQTKit::hasSetUpVideoRendering): (WebCore::MediaPlayerPrivateQTKit::createQTTime): (WebCore::MediaPlayerPrivateQTKit::resumeLoad): (WebCore::MediaPlayerPrivateQTKit::load): (WebCore::MediaPlayerPrivateQTKit::loadInternal): (WebCore::MediaPlayerPrivateQTKit::prepareToPlay): (WebCore::MediaPlayerPrivateQTKit::platformMedia): (WebCore::MediaPlayerPrivateQTKit::platformLayer): (WebCore::MediaPlayerPrivateQTKit::play): (WebCore::MediaPlayerPrivateQTKit::pause): (WebCore::MediaPlayerPrivateQTKit::duration): (WebCore::MediaPlayerPrivateQTKit::currentTime): (WebCore::MediaPlayerPrivateQTKit::seek): (WebCore::MediaPlayerPrivateQTKit::doSeek): (WebCore::MediaPlayerPrivateQTKit::cancelSeek): (WebCore::MediaPlayerPrivateQTKit::seekTimerFired): (WebCore::MediaPlayerPrivateQTKit::paused): (WebCore::MediaPlayerPrivateQTKit::seeking): (WebCore::MediaPlayerPrivateQTKit::naturalSize): (WebCore::MediaPlayerPrivateQTKit::hasVideo): (WebCore::MediaPlayerPrivateQTKit::hasAudio): (WebCore::MediaPlayerPrivateQTKit::supportsFullscreen): (WebCore::MediaPlayerPrivateQTKit::setVolume): (WebCore::MediaPlayerPrivateQTKit::hasClosedCaptions): (WebCore::MediaPlayerPrivateQTKit::setClosedCaptionsVisible): (WebCore::MediaPlayerPrivateQTKit::setRate): (WebCore::MediaPlayerPrivateQTKit::setPreservesPitch): (WebCore::MediaPlayerPrivateQTKit::buffered): (WebCore::MediaPlayerPrivateQTKit::maxTimeSeekable): (WebCore::MediaPlayerPrivateQTKit::maxTimeLoaded): (WebCore::MediaPlayerPrivateQTKit::bytesLoaded): (WebCore::MediaPlayerPrivateQTKit::totalBytes): (WebCore::MediaPlayerPrivateQTKit::cancelLoad): (WebCore::MediaPlayerPrivateQTKit::cacheMovieScale): (WebCore::MediaPlayerPrivateQTKit::isReadyForVideoSetup): (WebCore::MediaPlayerPrivateQTKit::prepareForRendering): (WebCore::MediaPlayerPrivateQTKit::updateStates): (WebCore::MediaPlayerPrivateQTKit::loadStateChanged): (WebCore::MediaPlayerPrivateQTKit::rateChanged): (WebCore::MediaPlayerPrivateQTKit::sizeChanged): (WebCore::MediaPlayerPrivateQTKit::timeChanged): (WebCore::MediaPlayerPrivateQTKit::didEnd): (WebCore::MediaPlayerPrivateQTKit::setSize): (WebCore::MediaPlayerPrivateQTKit::setVisible): (WebCore::MediaPlayerPrivateQTKit::hasAvailableVideoFrame): (WebCore::MediaPlayerPrivateQTKit::repaint): (WebCore::MediaPlayerPrivateQTKit::paintCurrentFrameInContext): (WebCore::MediaPlayerPrivateQTKit::paint): (WebCore::MediaPlayerPrivateQTKit::getSupportedTypes): (WebCore::MediaPlayerPrivateQTKit::supportsType): (WebCore::MediaPlayerPrivateQTKit::isAvailable): (WebCore::MediaPlayerPrivateQTKit::disableUnsupportedTracks): (WebCore::MediaPlayerPrivateQTKit::sawUnsupportedTracks): (WebCore::MediaPlayerPrivateQTKit::supportsAcceleratedRendering): (WebCore::MediaPlayerPrivateQTKit::acceleratedRenderingStateChanged): (WebCore::MediaPlayerPrivateQTKit::hasSingleSecurityOrigin): (WebCore::MediaPlayerPrivateQTKit::movieLoadType): (WebCore::MediaPlayerPrivateQTKit::setPreload): (WebCore::MediaPlayerPrivateQTKit::mediaTimeForTimeValue): (-[WebCoreMovieObserver initWithCallback:]):
10:25 Changeset [72116] by ap@apple.com

Reviewed by Dave Hyatt.

https://bugs.webkit.org/show_bug.cgi?id=49483
Remove CSS Variable support

10:15 Changeset [72115] by darin@apple.com

2010-11-16 Darin Adler <darin@apple.com>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=48603
Boolean logic mistake in local file check

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::loadFrameRequest): Fix logic so that both checks have to pass before accepting a local file load.
10:04 Changeset [72114] by darin@apple.com

2010-11-15 Darin Adler <darin@apple.com>

Reviewed by Sam Weinig.

Harden additional string functions against large lengths
https://bugs.webkit.org/show_bug.cgi?id=49574

  • wtf/text/CString.cpp: (WTF::CString::init): Check for length that is too large for CString. (WTF::CString::newUninitialized): Ditto. (WTF::CString::copyBufferIfNeeded): Fix types so the length stays in a size_t.
  • wtf/text/WTFString.cpp: (WTF::String::append): Check for length that is too large.

2010-11-15 Darin Adler <darin@apple.com>

Reviewed by Sam Weinig.

Harden additional string functions against large lengths
https://bugs.webkit.org/show_bug.cgi?id=49574

  • platform/text/TextCodecUTF16.cpp: (WebCore::TextCodecUTF16::encode): Check for length that is too large for size_t.
  • platform/text/TextStream.cpp: (WebCore::TextStream::operator<<): Check for length that is too large for size_t.
09:56 Changeset [72113] by mrobinson@webkit.org

2010-11-16 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Some key-press events can't be handled by WebView
https://bugs.webkit.org/show_bug.cgi?id=48986

The problem is that "popup-menu" and "show-help" signals are
handled by GtkTextView, as they are added to the key bindings set
of every widget in gtk_widget_class_init(). For all other bindings
handled by GtkTextView we are stopping the signal emission in
their callbacks, so we only need to do the same for "popup-menu"
and "show-help" signals.

  • WebCoreSupport/EditorClientGtk.cpp: (WebKit::toggleOverwriteCallback): (WebKit::popupMenuCallback): (WebKit::showHelpCallback): (WebKit::EditorClient::EditorClient):
09:50 Changeset [72112] by pfeldman@chromium.org

2010-11-16 Pavel Feldman <pfeldman@chromium.org>

Not reviewed. Chromium build fix.

  • WebKit.gyp:
  • scripts/concatenate_css_files.py: Renamed from WebKit/chromium/Build/concatenate_css_files.py.
  • scripts/concatenate_js_files.py: Renamed from WebKit/chromium/Build/concatenate_js_files.py.
  • scripts/generate_devtools_html.py: Renamed from WebKit/chromium/Build/generate_devtools_html.py.
09:41 Changeset [72111] by aroben@apple.com

Only trigger Windows builds when files that we actually use on Windows are changed

A new Scheduler subclass, PlatformSpecificScheduler, has been added.
It uses the new webkitpy.common.config.build module to determine
whether a particular change should trigger a build on a particular
platform. The Windows builders have been switched to use a
PlatformSpecificScheduler.

The logic to determine whether or not a particular change should
trigger a build on a given platform has only been implemented/tested
for Windows. I tried to make it easy to add more platforms in the
future, but I don't have enough familiarity with all platforms to be
able to implement it for them.

Fixes <http://webkit.org/b/49407> Windows builders kick off builds for
lots irrelevant changes (e.g., rebaselining Chromium test results)

Reviewed by Eric Seidel.

  • BuildSlaveSupport/build.webkit.org-config/config.json: Use a

PlatformSpecificScheduler for the Windows builders.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(PlatformSpecificScheduler.init): Added. Stores our platform, sets
up a ChangeFilter that filters to our branch and will call through to
our filter method, and calls up to our base class.
(PlatformSpecificScheduler.filter): Calls through to
build.should_build to find out whether we should trigger a build for
this change.

  • Scripts/webkitpy/common/net/build.py: Added.

(_should_file_trigger_build): Uses a set of directories and regexp
patterns to determine whether the given file should trigger a build on
the given platform. As mentioned earlier, this has only been
implemented for Windows, though I did try to make some guesses about
other platforms.
(should_build): Returns true if any of the files should trigger a
build on the given platform.

  • Scripts/webkitpy/common/net/build_unittest.py: Added.

(ShouldBuildTest.test_should_build): Does some basic testing to make
sure we're triggering builds for the right files. It only tests
Windows for now, though I tried to make some guesses about other
platforms.

09:32 Changeset [72110] by pfeldman@chromium.org

2010-11-16 Pavel Feldman <pfeldman@chromium.org>

Not reviewed. Touching inspector controller to make gtk / qt happier.

  • inspector/InspectorController.cpp:
09:31 Changeset [72109] by commit-queue@webkit.org

2010-11-16 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Show default context menu for the currently focused element when activated with keyboard
https://bugs.webkit.org/show_bug.cgi?id=49376

  • webkit/webkitwebview.cpp: (webkit_web_view_popup_menu_handler):
09:19 Changeset [72108] by mihaip@chromium.org

2010-11-16 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium expectations update.

A couple of SVG tests don't time out on the Mac.

  • platform/chromium/test_expectations.txt:
09:16 Changeset [72107] by mihaip@chromium.org

2010-11-16 Mihai Parparita <mihaip@chromium.org>

Unreviewed baseline update.

Add pixel baselines for fast/images/gray-scale-png-with-color-profile.html,
originally added by r71461.

  • platform/chromium-mac/fast/images/gray-scale-png-with-color-profile-expected.checksum: Added.
  • platform/chromium-mac/fast/images/gray-scale-png-with-color-profile-expected.png: Added.
  • platform/chromium-win/fast/images/gray-scale-png-with-color-profile-expected.checksum: Added.
  • platform/chromium-win/fast/images/gray-scale-png-with-color-profile-expected.png: Added.
  • platform/chromium/test_expectations.txt:
  • platform/mac/fast/images/gray-scale-png-with-color-profile-expected.checksum: Added.
  • platform/mac/fast/images/gray-scale-png-with-color-profile-expected.png: Added.
09:14 Changeset [72106] by commit-queue@webkit.org

2010-11-16 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Use gdk_pixbuf_get_from_surface() when available
https://bugs.webkit.org/show_bug.cgi?id=49532

  • platform/graphics/gtk/GdkCairoUtilities.cpp: (cairoImageSurfaceToGdkPixbuf):
09:13 Changeset [72105] by bulach@chromium.org

2010-11-16 Marcus Bulach <bulach@chromium.org>

Not reviewed, chromium test expectation and baselines update.

Re-adds a couple of tests_expectations wrongly excluded by r72099
https://bugs.webkit.org/show_bug.cgi?id=49599

  • platform/chromium/test_expectations.txt:
09:06 Changeset [72104] by mihaip@chromium.org

2010-11-16 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium expectations update.

Remove expectations for tests that now pass:

  • r71993 made svg/W3C-SVG-1.1/fonts-desc-02-t.svg passes again (with the current baselines)
  • fast/forms/search-styled.html and fast/forms/search-placeholder-value-changed.html were rebaselined by r72073
  • platform/chromium/test_expectations.txt:
08:44 Changeset [72103] by pfeldman@chromium.org

2010-11-16 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Chrome DevTools: concatenate CSS files, do not link
missing JS files in release mode.
https://bugs.webkit.org/show_bug.cgi?id=49586

  • Build/concatenate_css_files.py: Added.
  • Build/concatenate_js_files.py: Added.
  • Build/generate_devtools_html.py: Added.
  • WebKit.gyp:
08:42 Changeset [72102] by pfeldman@chromium.org

2010-11-16 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: init front-end UI upon DOMContentLoaded, not load event.
https://bugs.webkit.org/show_bug.cgi?id=49596

  • inspector/front-end/inspector.js: (windowLoaded):
08:28 Changeset [72101] by hausmann@webkit.org

[Qt] Remove synchronous QWebPage::checkPermissions signal
https://bugs.webkit.org/show_bug.cgi?id=46810

Reviewed by Andreas Kling.

WebKit/qt:

As decided in the API review, we remove this signal and replace its only use currently
with cached credentials.

  • Api/qwebpage.cpp:

(QWebPage::setUserPermission): Pass the WebCore frame instead of the QWebFrame.

  • Api/qwebpage.h:
  • WebCoreSupport/NotificationPresenterClientQt.cpp:

(WebCore::NotificationPresenterClientQt::checkPermission): Replaced explicit
signal emission with hash lookup of previously granted permission (or not).
(WebCore::NotificationPresenterClientQt::cancelRequestsForPermission): Remove
any previously cached/granted permission for the given script execution context.
(WebCore::NotificationPresenterClientQt::allowNotificationForFrame): Do not
only serve pending permission requests but before calling the JS callbacks, remember
the permission for subsequent synchronous checkPermission() calls.

  • WebCoreSupport/NotificationPresenterClientQt.h: Add cache for permissions.

WebKitTools:

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebCore::WebPage::WebPage):

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:

(LayoutTestController::grantDesktopNotificationPermission): When granting
permission, grant it directly on the QWebPage/Frame, that will remember it.

  • QtTestBrowser/webpage.cpp:

(WebPage::WebPage):

  • QtTestBrowser/webpage.h:
08:14 Changeset [72100] by andreas.kling@nokia.com

2010-11-16 Kenneth Rohde Christiansen <kenneth@webkit.org>, Zalan Bujtas <zbujtas@gmail.com>

Reviewed by Andreas Kling.

[WK2][Qt] Add API for finding a zoomable area for a given point

This is useful for implementing e.g "double tap zoom"

Only enabled for Qt.

  • UIProcess/API/qt/qwkpage.cpp: (QWKPage::findZoomableAreaForPoint): (QWKPagePrivate::didFindZoomableArea):
  • UIProcess/API/qt/qwkpage.h:
  • UIProcess/API/qt/qwkpage_p.h:
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didFindZoomableArea): (WebKit::WebPageProxy::findZoomableAreaForPoint):
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::findZoomableAreaForPoint):
  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
08:03 Changeset [72099] by bulach@chromium.org

2010-11-16 Marcus Bulach <bulach@chromium.org>

Not reviewed, chromium test expectation and baselines update.

Update chromium baselines following r72092
https://bugs.webkit.org/show_bug.cgi?id=49595

  • platform/chromium-linux/svg/dynamic-updates/SVGCircleElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGCircleElement-dom-requiredFeatures-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGCircleElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGCircleElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGEllipseElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGEllipseElement-dom-requiredFeatures-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGEllipseElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGEllipseElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGForeignObjectElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGForeignObjectElement-dom-requiredFeatures-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGForeignObjectElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGForeignObjectElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGGElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGGElement-dom-requiredFeatures-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGGElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGGElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGImageElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGImageElement-dom-requiredFeatures-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGImageElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGImageElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLineElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLineElement-dom-requiredFeatures-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLineElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGLineElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPathElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPathElement-dom-requiredFeatures-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPathElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPathElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPolygonElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPolygonElement-dom-requiredFeatures-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPolygonElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPolygonElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPolylineElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPolylineElement-dom-requiredFeatures-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPolylineElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGPolylineElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRectElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRectElement-dom-requiredFeatures-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRectElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGRectElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGSVGElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGSVGElement-dom-requiredFeatures-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGSVGElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGSVGElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGTextElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGTextElement-dom-requiredFeatures-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGTextElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGTextElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGUseElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGUseElement-dom-requiredFeatures-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGUseElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGUseElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGLineElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGLineElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGUseElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGUseElement-dom-requiredFeatures-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGCircleElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGCircleElement-dom-requiredFeatures-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGCircleElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGCircleElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGEllipseElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGEllipseElement-dom-requiredFeatures-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGEllipseElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGEllipseElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGForeignObjectElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGForeignObjectElement-dom-requiredFeatures-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGForeignObjectElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGForeignObjectElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGGElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGGElement-dom-requiredFeatures-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGGElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGGElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGImageElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGImageElement-dom-requiredFeatures-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGImageElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGImageElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLineElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLineElement-dom-requiredFeatures-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLineElement-dom-requiredFeatures-expected.txt: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLineElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLineElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGLineElement-svgdom-requiredFeatures-expected.txt: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPathElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPathElement-dom-requiredFeatures-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPathElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPathElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPolygonElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPolygonElement-dom-requiredFeatures-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPolygonElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPolygonElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPolylineElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPolylineElement-dom-requiredFeatures-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPolylineElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGPolylineElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRectElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRectElement-dom-requiredFeatures-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRectElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGRectElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGSVGElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGSVGElement-dom-requiredFeatures-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGSVGElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGSVGElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGTextElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGTextElement-dom-requiredFeatures-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGTextElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGTextElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGUseElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGUseElement-dom-requiredFeatures-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGUseElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGUseElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/chromium/test_expectations.txt:
07:52 Changeset [72098] by abecsi@webkit.org

2010-11-16 Andras Becsi <abecsi@inf.u-szeged.hu>

Reviewed by Csaba Osztrogonác.

[Qt] Add isPrinting and setPrinting methods to DRT's LayoutTestController.
Add previously removed expected file, png and checksum.

  • platform/qt/Skipped:
  • platform/qt/printing/page-rule-in-media-query-expected.checksum: Added.
  • platform/qt/printing/page-rule-in-media-query-expected.png: Added.
  • platform/qt/printing/page-rule-in-media-query-expected.txt: Added.

2010-11-16 Andras Becsi <abecsi@inf.u-szeged.hu>

Reviewed by Csaba Osztrogonác.

[Qt] Add isPrinting and setPrinting methods to DRT's LayoutTestController.

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::reset):
  • DumpRenderTree/qt/LayoutTestControllerQt.h: (LayoutTestController::isPrinting): (LayoutTestController::setPrinting):
07:45 Changeset [72097] by leandro@webkit.org

2010-11-16 Leandro Pereira <leandro@profusion.mobi>

[EFL] Unreviewed. Build fix.

  • WebCoreSupport/FrameLoaderClientEfl.h: Also include ResourceError.h.
07:25 Changeset [72096] by apavlov@chromium.org

2010-11-15 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Migrate frontend to the new CSS editing/retrieval API
https://bugs.webkit.org/show_bug.cgi?id=49492

Test: inspector/styles-new-API.html

WebCore:

  • inspector/front-end/AuditRules.js: (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback.selectorsCallback): (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback.routine): (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback): (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.styleSheetCallback): (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.allStylesCallback): (WebInspector.AuditRules.UnusedCssRule.prototype.doRun): (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun): (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.receivedImages):
  • inspector/front-end/CSSStyleModel.js: (WebInspector.CSSStyleModel.prototype.getStylesAsync): (WebInspector.CSSStyleModel.prototype.getComputedStyleAsync): (WebInspector.CSSStyleModel.prototype.getInlineStyleAsync): (WebInspector.CSSStyleModel.prototype.setRuleSelector): (WebInspector.CSSStyleModel.prototype.setRuleSelector.callback): (WebInspector.CSSStyleModel.prototype.addRule): (WebInspector.CSSStyleModel.prototype.addRule.callback): (WebInspector.CSSStyleDeclaration): (WebInspector.CSSStyleDeclaration.prototype.propertyAt): (WebInspector.CSSStyleDeclaration.prototype.pastLastSourcePropertyIndex): (WebInspector.CSSStyleDeclaration.prototype.newBlankProperty): (WebInspector.CSSStyleDeclaration.prototype.insertPropertyAt): (WebInspector.CSSStyleDeclaration.prototype.appendProperty): (WebInspector.CSSRule): (WebInspector.CSSProperty.prototype.get propertyText): (WebInspector.CSSProperty.prototype.setText): (WebInspector.CSSProperty.prototype.setDisabled): (WebInspector.CSSStyleSheet): (WebInspector.CSSStyleSheet.createForId): (WebInspector.CSSStyleSheet.prototype.getText): (WebInspector.CSSStyleSheet.prototype.setText):
  • inspector/front-end/Settings.js:
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertiesSection.prototype.onpopulate): (WebInspector.StylePropertiesSection.prototype.addNewBlankProperty): (WebInspector.StylePropertiesSection.prototype._debugShowStyle.removeStyleBox): (WebInspector.StylePropertiesSection.prototype._debugShowStyle): (WebInspector.StylePropertiesSection.prototype.editingSelectorCommitted): (WebInspector.StylePropertyTreeElement.prototype): (WebInspector.StylePropertyTreeElement.prototype.):
  • inspector/front-end/inspector.css: (.styles-section .properties li.not-parsed-ok): (.styles-section .properties li.not-parsed-ok::before): (.styles-section .properties .inactive):

LayoutTests:

  • inspector/audits-panel-functional-expected.txt:
  • inspector/elements-panel-styles-expected.txt:
  • inspector/resources/styles-new-API.css: Added. (html): (body): (/* comment before selector */body.main1/* comment after selector */): (body.main2): (body::after): (h1):
  • inspector/styles-new-API-expected.txt: Added.
  • inspector/styles-new-API.html: Added.
06:40 Changeset [72095] by apavlov@chromium.org

2010-11-16 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r72082.
http://trac.webkit.org/changeset/72082
https://bugs.webkit.org/show_bug.cgi?id=49594

"broken SnowLeopard build" (Requested by apavlov on #webkit).

  • fast/css/CSSPrimitiveValue-exceptions-expected.txt:
  • fast/css/getFloatValueForUnit-expected.txt: Removed.
  • fast/css/getFloatValueForUnit.html:
  • fast/css/resources/CSSPrimitiveValue-exceptions.js:
  • platform/chromium-linux/fast/css/getFloatValueForUnit-expected.checksum: Added.
  • platform/chromium-linux/fast/css/getFloatValueForUnit-expected.png: Added.
  • platform/chromium-win/fast/css/getFloatValueForUnit-expected.checksum: Added.
  • platform/chromium-win/fast/css/getFloatValueForUnit-expected.png: Added.
  • platform/chromium-win/fast/css/getFloatValueForUnit-expected.txt: Added.
  • platform/mac-leopard/fast/css/getFloatValueForUnit-expected.checksum: Added.
  • platform/mac-leopard/fast/css/getFloatValueForUnit-expected.png: Added.
  • platform/mac/fast/css/getFloatValueForUnit-expected.checksum: Added.
  • platform/mac/fast/css/getFloatValueForUnit-expected.png: Added.
  • platform/mac/fast/css/getFloatValueForUnit-expected.txt: Added.
  • platform/qt/fast/css/getFloatValueForUnit-expected.txt: Added.

2010-11-16 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r72082.
http://trac.webkit.org/changeset/72082
https://bugs.webkit.org/show_bug.cgi?id=49594

"broken SnowLeopard build" (Requested by apavlov on #webkit).

  • css/CSSPrimitiveValue.cpp: (WebCore::scaleFactorForConversion): (WebCore::CSSPrimitiveValue::getDoubleValue): (WebCore::CSSPrimitiveValue::getIdent):
  • css/CSSPrimitiveValue.h: (WebCore::CSSPrimitiveValue::getFloatValue): (WebCore::CSSPrimitiveValue::getIntValue):
06:23 Changeset [72094] by apavlov@chromium.org

2010-11-16 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r72087.
http://trac.webkit.org/changeset/72087
https://bugs.webkit.org/show_bug.cgi?id=49593

"broken build" (Requested by apavlov on #webkit).

  • css/CSSPrimitiveValue.cpp: (WebCore::unitCategory):
06:23 Changeset [72093] by andreas.kling@nokia.com

2010-11-16 Andreas Kling <kling@webkit.org>

Rubber-stamped by Simon Hausmann.

Revert !ENABLE(INSPECTOR) fix- we don't need it right now,
and it was less maintainable than I had though.

  • Shared/API/c/WKSharedAPICast.h: (WebKit::toAPI): (WebKit::toImpl):
  • WebProcess/WebCoreSupport/WebInspectorClient.cpp:
  • WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp:
  • WebProcess/WebPage/WebInspector.cpp:
06:14 Changeset [72092] by zimmermann@webkit.org

2010-11-16 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed.


Add missing pixel test results that Rob forgot to add.

  • platform/mac/svg/dynamic-updates/SVGCircleElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGCircleElement-dom-requiredFeatures-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGCircleElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGCircleElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGEllipseElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGEllipseElement-dom-requiredFeatures-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGEllipseElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGEllipseElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGForeignObjectElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGForeignObjectElement-dom-requiredFeatures-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGForeignObjectElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGForeignObjectElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGGElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGGElement-dom-requiredFeatures-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGGElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGGElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGImageElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGImageElement-dom-requiredFeatures-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGImageElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGImageElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGLineElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGLineElement-dom-requiredFeatures-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGLineElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGLineElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGPathElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGPathElement-dom-requiredFeatures-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGPathElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGPathElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGPolygonElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGPolygonElement-dom-requiredFeatures-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGPolygonElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGPolygonElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGPolylineElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGPolylineElement-dom-requiredFeatures-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGPolylineElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGPolylineElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGRectElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGRectElement-dom-requiredFeatures-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGRectElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGRectElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGSVGElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGSVGElement-dom-requiredFeatures-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGSVGElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGSVGElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGTextElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGTextElement-dom-requiredFeatures-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGTextElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGTextElement-svgdom-requiredFeatures-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGUseElement-dom-requiredFeatures-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGUseElement-dom-requiredFeatures-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGUseElement-svgdom-requiredFeatures-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGUseElement-svgdom-requiredFeatures-expected.png: Added.
05:44 Changeset [72091] by andreas.kling@nokia.com

2010-11-16 Andreas Kling <kling@webkit.org>

Reviewed by Simon Hausmann.

Fix compilation with !ENABLE(INSPECTOR)

  • Shared/API/c/WKSharedAPICast.h: (WebKit::toAPI): (WebKit::toImpl):
  • WebProcess/WebCoreSupport/WebInspectorClient.cpp:
  • WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp:
  • WebProcess/WebPage/WebInspector.cpp:
05:42 Changeset [72090] by pfeldman@chromium.org

2010-11-15 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: rename StoragePanel to ResourcesPanel.
https://bugs.webkit.org/show_bug.cgi?id=49534

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/DatabaseQueryView.js: (WebInspector.DatabaseQueryView.prototype._queryFinished):
  • inspector/front-end/DatabaseTableView.js: (WebInspector.DatabaseTableView.prototype._queryFinished):
  • inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer.prototype._onRevealAndSelectResource):
  • inspector/front-end/Images/storageIcon.png: Removed.
  • inspector/front-end/ResourceManager.js: (WebInspector.ResourceManager.prototype.setOverrideContent): (WebInspector.ResourceTreeModel.prototype.addOrUpdateFrame): (WebInspector.ResourceTreeModel.prototype.didCommitLoadForFrame): (WebInspector.ResourceTreeModel.prototype.frameDetachedFromParent): (WebInspector.ResourceTreeModel.prototype._clearChildFramesAndResources): (WebInspector.ResourceTreeModel.prototype.addResourceToFrame):
  • inspector/front-end/StoragePanel.js: Removed.
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.css: (.resources.panel .sidebar): (.resources.panel .sidebar li): (.resources.panel .sidebar li.parent): (.resources.panel .sidebar li.selected): (.resources.panel .sidebar li.selected .selection): (.resources.panel .sidebar :focus li.selected .selection): (body.inactive .resources.panel .sidebar li.selected .selection): (.resources.panel .sidebar .icon): (.resources.panel .base-storage-tree-element-title): (.resources.panel .status): (.resources.panel li .status .bubble):
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js: (WebInspector._createPanels): (WebInspector.openResource): (WebInspector.showPanel): (WebInspector.selectDatabase): (WebInspector.selectDOMStorage): (WebInspector.addDatabase): (WebInspector.addDOMStorage): (WebInspector.updateDOMStorage): (WebInspector.updateApplicationCacheStatus): (WebInspector.didGetFileSystemPath): (WebInspector.didGetFileSystemError): (WebInspector.didGetFileSystemDisabled): (WebInspector.updateNetworkState): (WebInspector._choosePanelToShowSourceLine):
05:23 Changeset [72089] by kbalazs@webkit.org

2010-11-16 Balazs Kelemen <kbalazs@webkit.org>

Reviewed by Andreas Kling.

[Qt][WK2] Add a way to turn on tiled backing store in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=49587

  • MiniBrowser/qt/BrowserView.cpp: (BrowserView::BrowserView): Added BackingStoreType argument to ctor. Propagating it to the QGraphicsWKView.
  • MiniBrowser/qt/BrowserView.h:
  • MiniBrowser/qt/BrowserWindow.cpp: (BrowserWindow::BrowserWindow): (BrowserWindow::newWindow): Create the new BrowserWindow with the same BackingStoreType that this instance has.
  • MiniBrowser/qt/BrowserWindow.h: Added BackingStoreType member.
  • MiniBrowser/qt/main.cpp: (main): Use tiled backing store if got -tiled command line argument. Avoid redundant copy of command line args.
05:10 Changeset [72088] by abecsi@webkit.org

2010-11-16 Andras Becsi <abecsi@webkit.org>

Reviewed by Andreas Kling.

[Qt] Use SIGINT instead of SIGKILL to let the web process clean up after itself.

  • UIProcess/Launcher/qt/ProcessLauncherQt.cpp: (WebKit::QtWebProcess::setupChildProcess):
05:06 Changeset [72087] by apavlov@chromium.org

2010-11-16 Alexander Pavlov <apavlov@chromium.org>

Unreviewed SnowLeopard build fix.

  • css/CSSPrimitiveValue.cpp: (WebCore::unitCategory):
04:55 Changeset [72086] by andreas.kling@nokia.com

2010-11-16 Kenneth Rohde Christiansen <kenneth@webkit.org>

Reviewed by Andreas Kling.

[WK2][Qt] Expose resizes-to-contents mode in WebKit2

Only available with ENABLE(TILED_BACKING_STORE)

Based on a patch by Antti Koivisto.

  • UIProcess/API/qt/qwkpage.cpp: (QWKPage::setResizesToContentsUsingLayoutSize):
  • UIProcess/API/qt/qwkpage.h:
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::setResizesToContentsUsingLayoutSize):
  • UIProcess/WebPageProxy.h:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::contentsSizeChanged):
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage):
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::setSize): (WebKit::WebPage::setResizesToContentsUsingLayoutSize): (WebKit::WebPage::resizeToContentsIfNeeded):
  • WebProcess/WebPage/WebPage.h: (WebKit::WebPage::resizesToContentsEnabled): (WebKit::WebPage::resizesToContentsLayoutSize):
  • WebProcess/WebPage/WebPage.messages.in:
04:46 Changeset [72085] by andreas.kling@nokia.com

2010-11-16 Andreas Kling <kling@webkit.org>

Unreviewed typo fix for previous commit.

  • common.pri:
04:26 Changeset [72084] by andreas.kling@nokia.com

2010-11-16 Kenneth Rohde Christiansen <kenneth@webkit.org>

Reviewed by Andreas Kling.

Viewport meta tag: Fix geometry computation

Available width and height should also be divided by the device pixel ratio.

  • dom/ViewportArguments.cpp: (WebCore::computeViewportAttributes):
  • platform/network/qt/DnsPrefetchHelper.cpp:
04:22 Changeset [72083] by ossy@webkit.org

Unreviewed.

[Qt] Add printing/page-rule-in-media-query.html to the skipped
list because of missing layoutTestController.setPrinting().

And remove incorrect Qt specific expected result.

  • platform/qt/Skipped: printing/page-rule-in-media-query.html added until fix.
  • platform/qt/printing: Removed.
  • platform/qt/printing/page-rule-in-media-query-expected.checksum: Removed.
  • platform/qt/printing/page-rule-in-media-query-expected.png: Removed.
  • platform/qt/printing/page-rule-in-media-query-expected.txt: Removed.
04:12 Changeset [72082] by apavlov@chromium.org

2010-11-12 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Simon Fraser.

CSSPrimitiveValue.getFloatValue does not convert sizes

Extended getFloatValueForUnit and CSSPrimitiveValue tests. The former has been made text-only,
which allowed to get rid of a number of unnecessary baselines.
https://bugs.webkit.org/show_bug.cgi?id=35770

  • fast/css/CSSPrimitiveValue-exceptions-expected.txt:
  • fast/css/getFloatValueForUnit-expected.txt: Added.
  • fast/css/getFloatValueForUnit.html:
  • fast/css/resources/CSSPrimitiveValue-exceptions.js:
  • platform/chromium-linux/fast/css/getFloatValueForUnit-expected.checksum: Removed.
  • platform/chromium-linux/fast/css/getFloatValueForUnit-expected.png: Removed.
  • platform/chromium-win/fast/css/getFloatValueForUnit-expected.checksum: Removed.
  • platform/chromium-win/fast/css/getFloatValueForUnit-expected.png: Removed.
  • platform/chromium-win/fast/css/getFloatValueForUnit-expected.txt: Removed.
  • platform/mac-leopard/fast/css/getFloatValueForUnit-expected.checksum: Removed.
  • platform/mac-leopard/fast/css/getFloatValueForUnit-expected.png: Removed.
  • platform/mac/fast/css/getFloatValueForUnit-expected.checksum: Removed.
  • platform/mac/fast/css/getFloatValueForUnit-expected.png: Removed.
  • platform/mac/fast/css/getFloatValueForUnit-expected.txt: Removed.
  • platform/qt/fast/css/getFloatValueForUnit-expected.txt: Removed.

2010-11-12 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Simon Fraser.

CSSPrimitiveValue.getFloatValue does not convert sizes
https://bugs.webkit.org/show_bug.cgi?id=35770

Implemented all same-category unit conversions (length, angle, time, frequency) and retained
absolute-relative (cm, mm, in, pt, pc) length conversions intact.
Illegal unit conversion attempts will throw an INVALID_ACCESS_ERR DOMException.

  • css/CSSPrimitiveValue.cpp: (WebCore::unitCategory): (WebCore::scaleFactorForConversion): (WebCore::CSSPrimitiveValue::getDoubleValue): (WebCore::CSSPrimitiveValue::canonicalUnitTypeForCategory): (WebCore::CSSPrimitiveValue::getDoubleValueInternal):
  • css/CSSPrimitiveValue.h:
04:11 Changeset [72081] by andreas.kling@nokia.com

2010-11-16 Andreas Kling <kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt][Scratchbox] Use gold linker explicitly when available

gold is faster at linking QtWebKit than binutils ld, but it cannot be
enabled by default on a system that compiles other Qt projects.
This is due to gold not supporting the --add-needed flag.

Original patch by Kimmo Kinnunen.

  • common.pri:
04:06 Changeset [72080] by andreas.kling@nokia.com

2010-11-16 Andreas Kling <kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt][WK2] Get proxy settings from environment (http[s]_proxy)

If http_proxy and/or https_proxy are set in the environment,
pass those in to QNetworkAccessManager.

  • WebProcess/qt/WebProcessMainQt.cpp: (WebKit::EnvHttpProxyFactory::EnvHttpProxyFactory): (WebKit::EnvHttpProxyFactory::initializeFromEnvironment): (WebKit::EnvHttpProxyFactory::queryProxy): (WebKit::initializeProxy): (WebKit::WebProcessMainQt):
03:56 Changeset [72079] by andreas.kling@nokia.com

2010-11-16 Andreas Kling <kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Add 'valgrind' build mode

Passing CONFIG+=valgrind to qmake will now build WebKit in a way
suitable for debugging with Valgrind.

Original patch by Christian Sejersen.

  • WebKit.pri:
03:53 Changeset [72078] by andreas.kling@nokia.com

2010-11-16 Andreas Kling <kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt][WK2] Emit windowCloseRequested signal on window.close()

Original patch by Zalan Bujtas.

  • UIProcess/API/qt/ClientImpl.cpp: (qt_wk_close):
  • UIProcess/API/qt/qwkpage.h:
03:50 Changeset [72077] by andreas.kling@nokia.com

2010-11-15 Andreas Kling <kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Kill the web process if the UI process dies

Connect UI (parent) process death signal to SIGKILL of the web
process (child). This ensures that there's no stale web processes
after the UI process has crashed.

Original patch by Kimmo Kinnunen.

  • UIProcess/Launcher/qt/ProcessLauncherQt.cpp: (WebKit::QtWebProcess::QtWebProcess): (WebKit::QtWebProcess::setupChildProcess): (WebKit::ProcessLauncherHelper::launch):
03:45 Changeset [72076] by bulach@chromium.org

2010-11-16 Marcus Bulach <bulach@chromium.org>

Not reviewed, chromium test expectation update.

Update chromium baselines following r72063
https://bugs.webkit.org/show_bug.cgi?id=49591

  • platform/chromium-mac/fast/js/function-prototype-descriptor-expected.txt: Added.
  • platform/chromium-win/fast/js/function-prototype-descriptor-expected.txt: Added.
03:34 Changeset [72075] by bulach@chromium.org

2010-11-16 Marcus Bulach <bulach@chromium.org>

Not reviewed, chromium test expectation update.

Update chromium baselines following r72050
https://bugs.webkit.org/show_bug.cgi?id=49590

  • platform/chromium-mac/fast/css/font-face-descriptor-multiple-values-parsing-expected.txt:
  • platform/chromium-mac/fast/js/exception-thrown-from-new-expected.txt:
  • platform/chromium-win/fast/css/font-face-descriptor-multiple-values-parsing-expected.txt:
  • platform/chromium-win/fast/js/exception-thrown-from-new-expected.txt:
03:31 Changeset [72074] by hausmann@webkit.org

[Qt] Trivial build fix for building WebKit2 inside Qt Creator

Rubber-stamped by Andreas Kling.

Similar to WebCore.pro, define a fallback for OUTPUT_DIR.

  • WebKit2.pro:
03:10 Changeset [72073] by bulach@chromium.org

2010-11-16 Marcus Bulach <bulach@chromium.org>

Not reviewed, chromium test expectation update.

Update chromium baselines following r72052
https://bugs.webkit.org/show_bug.cgi?id=49588

  • platform/chromium-linux/fast/forms/placeholder-pseudo-style-expected.checksum:
  • platform/chromium-linux/fast/forms/placeholder-pseudo-style-expected.png:
  • platform/chromium-linux/fast/forms/placeholder-stripped-expected.checksum:
  • platform/chromium-linux/fast/forms/placeholder-stripped-expected.png:
  • platform/chromium-linux/fast/forms/search-placeholder-value-changed-expected.checksum:
  • platform/chromium-linux/fast/forms/search-placeholder-value-changed-expected.png:
  • platform/chromium-linux/fast/forms/search-styled-expected.checksum: Added.
  • platform/chromium-linux/fast/forms/search-styled-expected.png: Added.
  • platform/chromium-linux/fast/forms/search-styled-expected.txt: Added.
  • platform/chromium-linux/fast/forms/textarea-placeholder-pseudo-style-expected.checksum:
  • platform/chromium-linux/fast/forms/textarea-placeholder-pseudo-style-expected.png:
  • platform/chromium-mac/fast/css/pseudo-cache-stale-expected.checksum: Added.
  • platform/chromium-mac/fast/css/pseudo-cache-stale-expected.png: Added.
  • platform/chromium-mac/fast/forms/isindex-placeholder-expected.checksum:
  • platform/chromium-mac/fast/forms/isindex-placeholder-expected.png:
  • platform/chromium-mac/fast/forms/password-placeholder-text-security-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/password-placeholder-text-security-expected.png: Added.
  • platform/chromium-mac/fast/forms/placeholder-pseudo-style-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/placeholder-pseudo-style-expected.png: Added.
  • platform/chromium-mac/fast/forms/placeholder-stripped-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/placeholder-stripped-expected.png: Added.
  • platform/chromium-mac/fast/forms/search-placeholder-value-changed-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/search-placeholder-value-changed-expected.png: Added.
  • platform/chromium-mac/fast/forms/search-styled-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/search-styled-expected.png: Added.
  • platform/chromium-mac/fast/forms/textarea-placeholder-pseudo-style-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/textarea-placeholder-pseudo-style-expected.png: Added.
  • platform/chromium-win-xp/fast/forms/search-styled-expected.checksum: Removed.
  • platform/chromium-win-xp/fast/forms/search-styled-expected.png: Removed.
  • platform/chromium-win-xp/fast/forms/search-styled-expected.txt:
  • platform/chromium-win/fast/css/pseudo-cache-stale-expected.txt:
  • platform/chromium-win/fast/forms/isindex-placeholder-expected.txt:
  • platform/chromium-win/fast/forms/password-placeholder-expected.txt:
  • platform/chromium-win/fast/forms/password-placeholder-text-security-expected.txt:
  • platform/chromium-win/fast/forms/placeholder-pseudo-style-expected.checksum:
  • platform/chromium-win/fast/forms/placeholder-pseudo-style-expected.png:
  • platform/chromium-win/fast/forms/placeholder-pseudo-style-expected.txt:
  • platform/chromium-win/fast/forms/placeholder-set-attribute-expected.txt:
  • platform/chromium-win/fast/forms/placeholder-stripped-expected.checksum:
  • platform/chromium-win/fast/forms/placeholder-stripped-expected.png:
  • platform/chromium-win/fast/forms/placeholder-stripped-expected.txt:
  • platform/chromium-win/fast/forms/search-placeholder-value-changed-expected.txt:
  • platform/chromium-win/fast/forms/search-styled-expected.checksum:
  • platform/chromium-win/fast/forms/search-styled-expected.png:
  • platform/chromium-win/fast/forms/search-styled-expected.txt: Copied from LayoutTests/platform/chromium-win-xp/fast/forms/search-styled-expected.txt.
  • platform/chromium-win/fast/forms/textarea-placeholder-pseudo-style-expected.checksum:
  • platform/chromium-win/fast/forms/textarea-placeholder-pseudo-style-expected.png:
  • platform/chromium-win/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
  • platform/chromium-win/fast/forms/textarea-placeholder-set-attribute-expected.txt:
02:59 Changeset [72072] by pfeldman@chromium.org

2010-11-15 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: extract HTML title setter in treeoutline.js.
https://bugs.webkit.org/show_bug.cgi?id=49540

  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype.adjustCollapsedRange): (WebInspector.ElementsTreeElement.prototype.updateTitle):
  • inspector/front-end/treeoutline.js: (TreeElement.prototype.get titleHTML): (TreeElement.prototype.set titleHTML): (TreeElement.prototype._setListItemNodeContent):
02:54 Changeset [72071] by commit-queue@webkit.org

2010-11-16 John Knottenbelt <jknotten@chromium.org>

Reviewed by Jeremy Orlow.

Assert that DeviceOrientationClientMock is used by only one controller.
https://bugs.webkit.org/show_bug.cgi?id=48506

This is a design constraint of the DeviceOrientationClientMock because the
m_controller field can only store a pointer to a single instance of the
corresponding DeviceOrientationController.

  • platform/mock/DeviceOrientationClientMock.cpp: (WebCore::DeviceOrientationClientMock::setController):

2010-11-16 John Knottenbelt <jknotten@chromium.org>

Reviewed by Jeremy Orlow.

Move DeviceOrientationClientMock from LayoutTestController to WebViewHost.
https://bugs.webkit.org/show_bug.cgi?id=48506

This ensures that there is one mock per page WebView / WebViewHost. This is a
design constraint of the DeviceOrientationClientMock because the m_controller
field can only store a pointer to a single instance of the corresponding
DeviceOrientationController.

Test: fast/dom/DeviceOrientation/no-page-cache.html

  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::setMockDeviceOrientation): (LayoutTestController::deviceOrientationClientMock):
  • DumpRenderTree/chromium/LayoutTestController.h:
  • DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::deviceOrientationClientMock): (WebViewHost::deviceOrientationClient): (WebViewHost::reset):
  • DumpRenderTree/chromium/WebViewHost.h:
02:51 Changeset [72070] by ossy@webkit.org

Unreviewed. Update Qt specific expected results after r72052.

  • platform/qt/fast/css/pseudo-cache-stale-expected.txt:
  • platform/qt/fast/forms/isindex-placeholder-expected.txt:
  • platform/qt/fast/forms/placeholder-stripped-expected.txt:
  • platform/qt/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
  • platform/qt/fast/forms/textarea-placeholder-set-attribute-expected.txt:
02:29 Changeset [72069] by ossy@webkit.org

.

01:21 Changeset [72068] by alex@webkit.org

2010-11-16 Alejandro G. Castro <alex@igalia.com>

Unreviewed, updated test expectations for GTK and skip tests using
computedStyleIncludingVisitedInfo which is not currently supported
in GTK.

  • platform/gtk/Skipped:
  • platform/gtk/fast/forms/isindex-placeholder-expected.txt:
  • platform/gtk/fast/forms/password-placeholder-expected.txt:
  • platform/gtk/fast/forms/password-placeholder-text-security-expected.txt:
  • platform/gtk/fast/forms/placeholder-pseudo-style-expected.txt:
  • platform/gtk/fast/forms/placeholder-set-attribute-expected.txt:
  • platform/gtk/fast/forms/placeholder-stripped-expected.txt:
  • platform/gtk/fast/forms/search-placeholder-value-changed-expected.txt:
  • platform/gtk/fast/forms/search-styled-expected.txt:
  • platform/gtk/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
  • platform/gtk/fast/forms/textarea-placeholder-set-attribute-expected.txt:
01:01 Changeset [72067] by paroga@webkit.org

2010-11-16 Patrick Gansterer <paroga@webkit.org>

Reviewed by Andreas Kling.

[CMake] Remove platform dependent include directories
https://bugs.webkit.org/show_bug.cgi?id=49553

  • CMakeLists.txt:

2010-11-16 Patrick Gansterer <paroga@webkit.org>

Reviewed by Andreas Kling.

[CMake] Add platform dependent include directories
https://bugs.webkit.org/show_bug.cgi?id=49553

  • CMakeListsEfl.txt:
00:44 Changeset [72066] by mihaip@chromium.org

2010-11-16 Mihai Parparita <mihaip@chromium.org>

Reviewed by Adam Barth.

fast/images/size-failure.html results in malloc of 2 Gb after switching to WebKit image decoders
https://bugs.webkit.org/show_bug.cgi?id=48634

Re-enable fast/images/size-failure.html now that it passes and doesn't
affect subsequent tests.

  • platform/chromium/test_expectations.txt:

2010-11-16 Mihai Parparita <mihaip@chromium.org>

Reviewed by Adam Barth.

fast/images/size-failure.html results in malloc of 2 Gb after switching to WebKit image decoders
https://bugs.webkit.org/show_bug.cgi?id=48634

Specify the capacity when calling CFDataCreateMutable, which can signal
malloc failures (by returning NULL), unlike CFDataSetLength.

  • platform/image-decoders/cg/ImageDecoderCG.cpp: (WebCore::RGBA32Buffer::setSize):
00:10 Changeset [72065] by rwlbuis@webkit.org

2010-11-15 Rob Buis <rwlbuis@gmail.com>

Reviewed by Dirk Schulze and Darin Adler.

requiredFeatures does not adapt to SVGStringList changes
https://bugs.webkit.org/show_bug.cgi?id=40887

Centralize the const_cast handling and only do it if needed.
Remove the const_cast in all svgAttributeChanged functions and move
it to SVGTest::handleAttributeChange. Add an early return to
handleAttributeChange to avoid unnecessary const_casts.

No tests necessary as functionality has not changed.

  • svg/SVGCircleElement.cpp: (WebCore::SVGCircleElement::svgAttributeChanged):
  • svg/SVGEllipseElement.cpp: (WebCore::SVGEllipseElement::svgAttributeChanged):
  • svg/SVGForeignObjectElement.cpp: (WebCore::SVGForeignObjectElement::svgAttributeChanged):
  • svg/SVGGElement.cpp: (WebCore::SVGGElement::svgAttributeChanged):
  • svg/SVGImageElement.cpp: (WebCore::SVGImageElement::svgAttributeChanged):
  • svg/SVGLineElement.cpp: (WebCore::SVGLineElement::svgAttributeChanged):
  • svg/SVGPathElement.cpp: (WebCore::SVGPathElement::svgAttributeChanged):
  • svg/SVGPolyElement.cpp: (WebCore::SVGPolyElement::svgAttributeChanged):
  • svg/SVGRectElement.cpp: (WebCore::SVGRectElement::svgAttributeChanged):
  • svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::svgAttributeChanged):
  • svg/SVGTests.cpp: (WebCore::SVGTests::handleAttributeChange):
  • svg/SVGTests.h:
  • svg/SVGTextContentElement.cpp: (WebCore::SVGTextContentElement::svgAttributeChanged):
  • svg/SVGUseElement.cpp: (WebCore::SVGUseElement::svgAttributeChanged):

11/15/10:

23:16 Changeset [72064] by mitz@apple.com

Disabled a test that was failing intermittently due to https://bugs.webkit.org/show_bug.cgi?id=49579

Rubber-stamped by Mark Rowe.

  • fast/block/float/015.html: Removed.
  • fast/block/float/015.html-disabled: Copied from LayoutTests/fast/block/float/015.html.
22:05 Changeset [72063] by barraclough@apple.com

Bug 49577 - Function.prototype should be non-configurable

Reviewed by Sam Weinig.

JavaScriptCore:

JSC lazily allocates the prototype property of Function objects.

We check the prototype exists on 'get', but not on 'put'.
If you 'put' without having first done a 'get' you can end up with a configurable
prototype (prototype should only ever be non-configurable).

This is visible in a couple of ways:

  • 'delete' on the property may succeed. (the next access will result in a new, reset prototype object).
  • the prototype may be set to a getter.
  • runtime/JSFunction.cpp:

(JSC::JSFunction::getOwnPropertyNames):

Reify the prototype property before allowing an enumerate including don't enum properties.

(JSC::JSFunction::put):

Reify the prototype property before any put to it.

LayoutTests:

  • fast/js/script-tests/Object-getOwnPropertyNames.js:
  • fast/js/Object-getOwnPropertyNames-expected.txt:

Object.getOwnPropertyNames should enumerate the 'prototype' property on Functions.

  • fast/js/function-prototype-descriptor.html: Added.
  • fast/js/function-prototype-descriptor-expected.txt: Added.
  • fast/js/script-tests/function-prototype-descriptor.js: Added.

Test the attributes of Functions' prototype properties.

21:35 Changeset [72062] by dglazkov@chromium.org

2010-11-15 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Darin Adler.

REGRESSION(r71934): Removing an element with a shadow DOM from under a cursor causes a crash.
https://bugs.webkit.org/show_bug.cgi?id=49569

  • fast/events/remove-shadow-host-crash-expected.txt: Added.
  • fast/events/remove-shadow-host-crash.html: Added.

2010-11-15 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Darin Adler.

REGRESSION(r71934): Removing an element with a shadow DOM from under a cursor causes a crash.
https://bugs.webkit.org/show_bug.cgi?id=49569

Test: fast/events/remove-shadow-host-crash.html

  • rendering/TextControlInnerElements.h: (WebCore::TextControlInnerElement::isShadowNode): (WebCore::TextControlInnerElement::shadowParentNode):
21:26 Changeset [72061] by barraclough@apple.com

Fix test broken by earlier patch.

Reviewed by NOBODY build fix.

  • tests/qwebframe/tst_qwebframe.cpp:
21:23 Changeset [72060] by rniwa@webkit.org

2010-11-12 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

ScriptElement rather than HTMLScriptElement and SVGScriptElement should have ScriptElementData
https://bugs.webkit.org/show_bug.cgi?id=49469

Moved m_data, scriptCharset, scriptContent, shouldExecuteAsJavaScript, and executeScript from
HTMLScriptElement and SVGScriptElement to ScriptElementData.

Also made insertedIntoDocument, removedFromDocument, childrenChanged, finishParsingChildren,
and handleSourceAttribute of ScriptElement non-static.

No new tests are added since this is a cleanup.

  • dom/ScriptElement.cpp: (WebCore::ScriptElement::scriptCharset): Added. (WebCore::ScriptElement::scriptContent): Added. (WebCore::ScriptElement::shouldExecuteAsJavaScript): Added. (WebCore::ScriptElement::executeScript): Added. (WebCore::ScriptElement::insertedIntoDocument): Made non-static. Accesses m_data. (WebCore::ScriptElement::removedFromDocument): Ditto. (WebCore::ScriptElement::childrenChanged): Ditto. (WebCore::ScriptElement::finishParsingChildren): Ditto. (WebCore::ScriptElement::handleSourceAttribute): Ditto.
  • dom/ScriptElement.h: Moved the declaration of ScriptElement after that of ScriptElementData because ScriptElement has to instantiate ScriptElementData. (WebCore::ScriptElement::ScriptElement): Initializes m_data.
  • html/HTMLScriptElement.cpp: Removed scriptCharset, scriptContent, shouldExecuteAsJavaScript, and executeScript. (WebCore::HTMLScriptElement::HTMLScriptElement): Initializes ScriptElement instead of ScriptElementData. (WebCore::HTMLScriptElement::childrenChanged): Calls ScriptElement::childrenChanged. (WebCore::HTMLScriptElement::parseMappedAttribute): Calls ScriptElement::handleSourceAttribute. (WebCore::HTMLScriptElement::finishParsingChildren): Calls ScriptElement::finishParsingChildren. (WebCore::HTMLScriptElement::insertedIntoDocument): Calls ScriptElement::insertedIntoDocument. (WebCore::HTMLScriptElement::removedFromDocument): Calls ScriptElement::removedFromDocument.
  • html/HTMLScriptElement.h:
  • svg/SVGScriptElement.cpp: Removed scriptCharset, scriptContent, shouldExecuteAsJavaScript, and executeScript. (WebCore::SVGScriptElement::SVGScriptElement): Initializes ScriptElement instead of ScriptElementData. (WebCore::SVGScriptElement::svgAttributeChanged): Calls ScriptElement::handleSourceAttribute. (WebCore::SVGScriptElement::insertedIntoDocument): Calls ScriptElement::insertedIntoDocument. (WebCore::SVGScriptElement::removedFromDocument): Calls ScriptElement::removedFromDocument. (WebCore::SVGScriptElement::childrenChanged): Calls ScriptElement::childrenChanged. (WebCore::SVGScriptElement::finishParsingChildren): Calls ScriptElement::finishParsingChildren.
  • svg/SVGScriptElement.h:
21:13 Changeset [72059] by tkent@chromium.org

Refactor HTMLInputElement: Move a part of HTMLInputElement::
defaultEventHandler() to InputTypes.
https://bugs.webkit.org/show_bug.cgi?id=48317

Reviewed by Darin Adler.

Move out the followings to InputTypes:

  • click event processing,
  • the first keydown event processing, and
  • DOMActivate event processing.

Move m_xPos and m_yPos from HTMLInputElement to ImageInputType as
m_clickLocation. It's ok to move them because they should be valid only
when HTMLInputElement::m_activeSubmit is true. For type=image,
m_activeSubmit is true only in DOMActivate event handling. So we reset
m_clickLocation in handleDOMActivateEvent() with Event::underlyingEvent().

No new tests because this is just a refactoring.

  • html/BaseDateAndTimeInputType.cpp:

(WebCore::BaseDateAndTimeInputType::handleKeydownEvent):

  • html/BaseDateAndTimeInputType.h:
  • html/FileInputType.cpp:

(WebCore::FileInputType::handleDOMActivateEvent):

  • html/FileInputType.h:
  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::HTMLInputElement):
(WebCore::HTMLInputElement::defaultEventHandler):

  • html/HTMLInputElement.h:
  • html/ImageInputType.cpp:

(WebCore::ImageInputType::appendFormData):
(WebCore::ImageInputType::handleDOMActivateEvent):

  • html/ImageInputType.h:
  • html/InputType.cpp:

(WebCore::InputType::handleClickEvent):
(WebCore::InputType::handleDOMActivateEvent):
(WebCore::InputType::handleKeydownEvent):

  • html/InputType.h:
  • html/NumberInputType.cpp:

(WebCore::NumberInputType::handleKeydownEvent):

  • html/NumberInputType.h:
  • html/RadioInputType.cpp:

(WebCore::RadioInputType::handleClickEvent):

  • html/RadioInputType.h:
  • html/RangeInputType.cpp:

(WebCore::RangeInputType::handleKeydownEvent):

  • html/RangeInputType.h:
  • html/ResetInputType.cpp:

(WebCore::ResetInputType::handleDOMActivateEvent):

  • html/ResetInputType.h:
  • html/SubmitInputType.cpp:

(WebCore::SubmitInputType::handleDOMActivateEvent):

  • html/SubmitInputType.h:
  • html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::handleKeydownEvent):
(WebCore::TextFieldInputType::handleKeydownEventForSpinButton):

  • html/TextFieldInputType.h:
21:12 Changeset [72058] by commit-queue@webkit.org

2010-11-15 Nat Duca <nduca@chromium.org>

Reviewed by Darin Fisher.

[chromium] Make WebWidget actively notify client when compositing enables.
https://bugs.webkit.org/show_bug.cgi?id=49396

  • public/WebWidgetClient.h: (WebKit::WebWidgetClient::didAcceleratedCompositingEnable):
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::resize): (WebKit::WebViewImpl::paint): (WebKit::WebViewImpl::setRootLayerNeedsDisplay): (WebKit::WebViewImpl::scrollRootLayerRect): (WebKit::WebViewImpl::invalidateRootLayerRect): (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
20:53 Changeset [72057] by crogers@google.com

2010-11-15 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

Add AudioNode custom bindings
https://bugs.webkit.org/show_bug.cgi?id=49119

No new tests since audio API is not yet implemented.

  • bindings/js/JSAudioNodeCustom.cpp: Added. (WebCore::JSAudioNode::connect): (WebCore::JSAudioNode::disconnect):
  • bindings/v8/custom/V8AudioNodeCustom.cpp: Added. (WebCore::V8AudioNode::connectCallback): (WebCore::V8AudioNode::disconnectCallback):
  • webaudio/AudioNode.idl:
20:45 Changeset [72056] by hyatt@apple.com

https://bugs.webkit.org/show_bug.cgi?id=49570

Reviewed by Dan Bernstein.

Put italics specialization check back in CSSFontSelector. I had to back it out, since it broke
a layout test, and the issue was that local font fallback fonts should not be considered by the
specialization check (since you never want to pick a fallback over an actual @font-face rule if
the @font-face rule can handle it).

  • css/CSSFontFace.h:

(WebCore::CSSFontFace::create):
(WebCore::CSSFontFace::isLocalFallback):
(WebCore::CSSFontFace::CSSFontFace):

  • css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::addFontFaceRule):
(WebCore::compareFontFaces):

20:13 Changeset [72055] by commit-queue@webkit.org

2010-11-15 Yi Shen <yi.4.shen@nokia.com>

Reviewed by Andreas Kling.

[Qt] ZoomTextOnly doesn't work
https://bugs.webkit.org/show_bug.cgi?id=49568

Check QWebSettings::ZoomTextOnly attribute before applying zoom

  • Api/qwebframe.cpp: (QWebFrame::textSizeMultiplier): (QWebFrame::setZoomFactor): (QWebFrame::zoomFactor):
  • Api/qwebframe_p.h: (QWebFramePrivate::QWebFramePrivate):
19:37 Changeset [72054] by paroga@webkit.org

2010-11-15 Patrick Gansterer <paroga@webkit.org>

Reviewed by Andreas Kling.

[CMake] Add additional flags to cmakeconfig.h
https://bugs.webkit.org/show_bug.cgi?id=49556

  • cmake/OptionsEfl.cmake:
  • cmakeconfig.h.cmake:
18:13 Changeset [72053] by tkent@chromium.org

2010-11-15 Kent Tamura <tkent@chromium.org>

Unreviewed, test expectation update.

  • platform/chromium/drt_expectations.txt: Fix duplicated entries added in r72045.
18:09 Changeset [72052] by adele@apple.com

WebCore: Fix for: https://bugs.webkit.org/show_bug.cgi?id=49452
Placeholder should not be swapped in and out of the text control's inner text element

Reviewed by Darin Adler.

There's no need to swap the placeholder text in and out of the inner text element. Instead, just paint the text.
This reduces complexity and makes it easier to make independent decisions about the placeholder text and the text control value.

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setValueFromRenderer):

Since updatePlaceholderVisibility checks the value, set the value before calling updatePlaceholderVisibility.

  • rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::updatePlaceholderVisibility): Remove code that set the inner text value with the placeholder text.
(WebCore::RenderTextControl::paintObject): Paint the placeholder text during the background phase.

  • rendering/RenderTextControl.h:
  • rendering/RenderTextControlMultiLine.cpp:

(WebCore::RenderTextControlMultiLine::nodeAtPoint): Remove custom hit testing that tried to avoid hitting the placeholder text at the wrong time.
(WebCore::RenderTextControlMultiLine::updateFromElement): Remove code that set the inner text value with the placeholder text.
(WebCore::RenderTextControlMultiLine::createInnerTextStyle): Remove code that created the inner text style based on the placeholder pseudoelement.
(WebCore::RenderTextControlMultiLine::textBoxInsetLeft): Added.
(WebCore::RenderTextControlMultiLine::textBoxInsetRight): Added.

  • rendering/RenderTextControlMultiLine.h:
  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::updateFromElement): Remove code that set the inner text value with the placeholder text.
(WebCore::RenderTextControlSingleLine::createInnerTextStyle): Remove code that created the inner text style based on the placeholder pseudoelement.
(WebCore::RenderTextControlSingleLine::textBoxInsetLeft): Added.
(WebCore::RenderTextControlSingleLine::textBoxInsetRight): Added.

  • rendering/RenderTextControlSingleLine.h:
  • rendering/TextControlInnerElements.cpp: Removed custom hit testing that tried to avoid hitting the placeholder text at the wrong time.

LayoutTests: Test for: https://bugs.webkit.org/show_bug.cgi?id=49452
Placeholder should not be swapped in and out of the text control's inner text element

Reviewed by Darin Adler.

The only visual change that occurred is in pseudo-cache-stale.html. The placeholder text did not
use to paint over the spot where the cancel button will display. Since the cancel button is not
present when the placeholder is drawn, now the placeholder text can draw to the edge of the field.

  • platform/mac/fast/css/pseudo-cache-stale-expected.checksum:
  • platform/mac/fast/css/pseudo-cache-stale-expected.png:
  • platform/mac/fast/css/pseudo-cache-stale-expected.txt:
  • platform/mac/fast/forms/isindex-placeholder-expected.txt:
  • platform/mac/fast/forms/password-placeholder-expected.txt:
  • platform/mac/fast/forms/password-placeholder-text-security-expected.txt:
  • platform/mac/fast/forms/placeholder-pseudo-style-expected.txt:
  • platform/mac/fast/forms/placeholder-set-attribute-expected.txt:
  • platform/mac/fast/forms/placeholder-stripped-expected.txt:
  • platform/mac/fast/forms/search-placeholder-value-changed-expected.txt:
  • platform/mac/fast/forms/search-styled-expected.txt:
  • platform/mac/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
  • platform/mac/fast/forms/textarea-placeholder-set-attribute-expected.txt:
18:00 Changeset [72051] by hamaji@chromium.org

Merge 71964 - 2010-11-13 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Kent Tamura.

[Chromium] print doesn't work on http://nodejs.org/api.html
https://bugs.webkit.org/show_bug.cgi?id=49304

  • platform/chromium/test_expectations.txt:

2010-11-13 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Kent Tamura.

[Chromium] print doesn't work on http://nodejs.org/api.html
https://bugs.webkit.org/show_bug.cgi?id=49304

  • src/WebFrameImpl.cpp: (WebKit::ChromePrintContext::begin): (WebKit::WebFrameImpl::printBegin):

TBR=hamaji@chromium.org

17:30 Changeset [72050] by barraclough@apple.com

Bug 49488 - Only add source specific information to exceptions in Interpreter::throwException

Reviewed by Geoff Garen.

JavaScriptCore:

Three types of source location information are added to errors.

(1) Divot information.

This was added with the intention of using it to provide better source highlighting in the inspector.
We may still want to do so, but we probably should not be exposing these values in a manner visible to
user scripts – only through an internal C++ interface. The code adding divot properties to objects has
been removed.

(2) Line number information.

Line number information is presently sometimes added at the point the exception is created, and sometimes
added at the point the exception passes through throwException. Change this so that throwException has
the sole responsibility for adding line number and source file information.

(3) Source snippets in the message of certain type errors (e.g. 'doc' in Result of expression 'doc' [undefined] is not an object.).

These messages are currently created at the point the exceptions is raised. Instead reformat the message
such that the source snippet is located at the end (Result of expression 'b1' [undefined] is not an object.
becomes 'undefined' is not an object (evaluating 'b1.property')), and append these to the message at
the in throw Exception. This presents a number of advantages:

  • we no longer need to have source location information to create these TypeErrors.
  • we can chose to append source location information in other error messages, including those where passing source location to the point of construction would be inconvenient.
  • we can chose in future to omit to append source location information when running in a non-debug mode.

This also cleans up some error output, e.g. removing double brackets ('[[]]') around objects in output,
removing double periods (..) at end of lines, and adding slightly more context to some errors.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::expressionRangeForBytecodeOffset):

  • Separated called to access line and range information.
  • bytecode/CodeBlock.h:
    • Separated called to access line and range information.
  • interpreter/Interpreter.cpp:

(JSC::Interpreter::resolve):
(JSC::Interpreter::resolveSkip):
(JSC::Interpreter::resolveGlobal):
(JSC::Interpreter::resolveGlobalDynamic):
(JSC::Interpreter::resolveBaseAndProperty):
(JSC::isInvalidParamForIn):
(JSC::isInvalidParamForInstanceOf):

  • Update parameters passed to error constructors.

(JSC::appendSourceToError):

  • Update message property to add location information (previously added in createErrorMessage, in ExceptionHelpers)

(JSC::Interpreter::throwException):

  • Updated to call appendSourceToError.

(JSC::Interpreter::privateExecute):

  • Update parameters passed to error constructors.
  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • Update parameters passed to error constructors.
  • runtime/Error.cpp:

(JSC::addErrorInfo):
(JSC::hasErrorInfo):

  • Removed divot properties.
  • runtime/Error.h:
    • Removed divot properties.
  • runtime/ErrorInstance.cpp:

(JSC::ErrorInstance::ErrorInstance):

  • Initialize new property.
  • runtime/ErrorInstance.h:

(JSC::ErrorInstance::appendSourceToMessage):
(JSC::ErrorInstance::setAppendSourceToMessage):
(JSC::ErrorInstance::clearAppendSourceToMessage):

  • Added flag to check for errors needing location information appending.

(JSC::ErrorInstance::isErrorInstance):

  • Added virtual method to check for ErrorInstances.
  • runtime/ExceptionHelpers.cpp:

(JSC::createUndefinedVariableError):
(JSC::createInvalidParamError):
(JSC::createNotAConstructorError):
(JSC::createNotAFunctionError):
(JSC::createNotAnObjectError):

  • Update parameters passed to error constructors, stopped adding line number information early, changed TypeError messages.
  • runtime/ExceptionHelpers.h:
    • Updated function signatures.
  • runtime/JSFunction.cpp:

(JSC::callHostFunctionAsConstructor):

  • Update parameters passed to error constructors.
  • runtime/JSObject.h:

(JSC::JSObject::isErrorInstance):

  • Added virtual method to check for ErrorInstances.

LayoutTests:

Updated results to account for changes in TypeError messages.
(e.g. Result of expression 'b1' [undefined] is not an object. -> 'undefined' is not an object (evaluating 'b1.property')).

  • fast/css/font-face-descriptor-multiple-values-parsing-expected.txt:
  • fast/css/resources/font-face-descriptor-multiple-values-parsing.js:
  • fast/css/variables/color-hex-test-expected.txt:
  • fast/dom/HTMLSelectElement/named-options-expected.txt:
  • fast/dom/Range/getClientRects-expected.txt:
  • fast/dom/SelectorAPI/dumpNodeList-almost-strict-expected.txt:
  • fast/dom/SelectorAPI/dumpNodeList-expected.txt:
  • fast/forms/select-namedItem-expected.txt:
  • fast/js/basic-strict-mode-expected.txt:
  • fast/js/date-toisostring-expected.txt:
  • fast/js/delete-getters-setters-expected.txt:
  • fast/js/exception-expression-offset-expected.txt:
  • fast/js/exception-for-nonobject-expected.txt:
  • fast/js/exception-thrown-from-new-expected.txt:
  • fast/js/exception-thrown-from-new.html:
  • fast/js/instance-of-immediates-expected.txt:
  • fast/js/script-tests/exception-expression-offset.js:

(testException):

  • fast/js/sputnik/Conformance/08_Types/8.6_The_Object_Type/8.6.2_Internal_Properties_and_Methods/S8.6.2_A7-expected.txt:
  • fast/js/sputnik/Conformance/13_Function_Definition/S13_A17_T2-expected.txt:
  • fast/js/sputnik/Conformance/15_Native_Objects/15.1_The_Global_Object/S15.1_A1_T1-expected.txt:
  • fast/js/sputnik/Conformance/15_Native_Objects/15.1_The_Global_Object/S15.1_A1_T2-expected.txt:
  • fast/js/sputnik/Conformance/15_Native_Objects/15.1_The_Global_Object/S15.1_A2_T1-expected.txt:
  • fast/js/sputnik/Conformance/15_Native_Objects/15.2_Object/15.2.4/15.2.4.2_Object.prototype.toString/S15.2.4.2_A7-expected.txt:
  • fast/js/sputnik/Conformance/15_Native_Objects/15.2_Object/15.2.4/15.2.4.3_Object.prototype.toLocaleString/S15.2.4.3_A7-expected.txt:
  • fast/js/sputnik/Conformance/15_Native_Objects/15.2_Object/15.2.4/15.2.4.4_Object.prototype.valueOf/S15.2.4.4_A7-expected.txt:
  • fast/js/sputnik/Conformance/15_Native_Objects/15.2_Object/15.2.4/15.2.4.5_Object.prototype.hasOwnProperty/S15.2.4.5_A7-expected.txt:
  • fast/js/sputnik/Conformance/15_Native_Objects/15.2_Object/15.2.4/15.2.4.6_Object.prototype.isPrototypeOf/S15.2.4.6_A7-expected.txt:
  • fast/js/sputnik/Conformance/15_Native_Objects/15.2_Object/15.2.4/15.2.4.7_Object.prototype.propertyIsEnumerable/S15.2.4.7_A7-expected.txt:
  • fast/js/sputnik/Conformance/15_Native_Objects/15.2_Object/15.2.4/S15.2.4_A3-expected.txt:
  • fast/js/sputnik/Conformance/15_Native_Objects/15.2_Object/15.2.4/S15.2.4_A4-expected.txt:
  • fast/js/sputnik/Conformance/15_Native_Objects/15.3_Function/15.3.4/15.3.4.2_Function.prototype.toString/S15.3.4.2_A7-expected.txt:
  • fast/js/sputnik/Conformance/15_Native_Objects/15.3_Function/15.3.4/S15.3.4_A5-expected.txt:
  • fast/js/sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.10_String.prototype.match/S15.5.4.10_A1_T4-expected.txt:
  • fast/js/sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.12_String.prototype.search/S15.5.4.12_A7-expected.txt:
  • fast/js/sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.13_String.prototype.slice/S15.5.4.13_A7-expected.txt:
  • fast/js/sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.15_String.prototype.substring/S15.5.4.15_A7-expected.txt:
  • fast/js/sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.17_String.prototype.toLocaleLowerCase/S15.5.4.17_A7-expected.txt:
  • fast/js/sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.7_String.prototype.indexOf/S15.5.4.7_A7-expected.txt:
  • fast/js/sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.8_String.prototype.lastIndexOf/S15.5.4.8_A7-expected.txt:
  • fast/xsl/transform-xhr-doc-expected.txt:
  • http/tests/security/aboutBlank/xss-DENIED-navigate-opener-document-write-expected.txt:
  • http/tests/security/aboutBlank/xss-DENIED-navigate-opener-javascript-url-expected.txt:
  • http/tests/security/aboutBlank/xss-DENIED-set-opener-expected.txt:
  • java/lc3/ArrayMethods/byte-001-expected.txt:
  • java/lc3/CallStatic/object-001-expected.txt:
  • java/lc3/ConvertBoolean/boolean-007-n-expected.txt:
  • java/lc3/ConvertBoolean/boolean-008-n-expected.txt:
  • java/lc3/ConvertBoolean/boolean-009-n-expected.txt:
  • java/lc3/ConvertBoolean/boolean-010-n-expected.txt:
  • java/lc3/ConvertBoolean/boolean-011-n-expected.txt:
  • java/lc3/ConvertBoolean/boolean-012-n-expected.txt:
  • java/lc3/ConvertBoolean/boolean-013-n-expected.txt:
  • java/lc3/ConvertBoolean/boolean-014-expected.txt:
  • java/lc3/ConvertNull/null-001-expected.txt:
  • java/lc3/ConvertNumber/number-011-expected.txt:
  • java/lc3/ConvertString/string-006-expected.txt:
  • java/lc3/ConvertString/string-007-n-expected.txt:
  • java/lc3/ConvertUndefined/undefined-002-expected.txt:
  • java/lc3/ConvertUndefined/undefined-003-expected.txt:
  • java/lc3/JSBoolean/boolean-005-n-expected.txt:
  • java/lc3/JSNumber/ToDouble-002-expected.txt:
  • java/lc3/JSObject/ToJSObject-001-expected.txt:
  • java/lc3/JSObject/ToObject-001-expected.txt:
  • java/lc3/JavaObject/JavaObjectFieldOrMethod-001-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.imageData.create1.type-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.imageData.create2.type-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.imageData.get.type-expected.txt:
  • platform/mac/compositing/reflections/reflection-opacity-expected.txt:
  • platform/mac/fast/css/variables/remove-variable-test-expected.txt:
  • platform/mac/fast/css/variables/set-variable-test-expected.txt:
  • platform/mac/fast/css/variables/variable-iteration-test-expected.txt:
  • platform/mac/fast/events/updateLayoutForHitTest-expected.txt:
  • platform/mac/svg/custom/createelement-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug53690-1-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug92868_1-expected.txt:
  • plugins/npruntime/object-from-destroyed-plugin-expected.txt:
  • plugins/npruntime/plugin-scriptable-object-invoke-default-expected.txt:
  • svg/custom/use-nested-missing-target-removed-expected.txt:
  • svg/dom/svgpath-out-of-bounds-getPathSeg-expected.txt:
17:23 Changeset [72049] by andreas.kling@nokia.com

2010-11-15 Andreas Kling <kling@webkit.org>

Unreviewed buildfix (Qt WebKit2 minimal)

  • platform/qt/CookieJarQt.cpp: Add missing <QStringList> include.
17:22 Changeset [72048] by crogers@google.com

2010-11-15 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

Add Event and EventListener hooks for JavaScriptAudioNode and AudioProcessingEvent
https://bugs.webkit.org/show_bug.cgi?id=49357

No new tests since audio API is not yet implemented.

  • bindings/js/JSEventCustom.cpp: (WebCore::toJS):
  • bindings/js/JSEventTarget.cpp: (WebCore::toJS):
  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::convertEventTargetToV8Object):
  • bindings/v8/custom/V8EventCustom.cpp: (WebCore::toV8):
  • dom/Event.cpp: (WebCore::Event::isAudioProcessingEvent):
  • dom/Event.h:
  • dom/EventNames.h:
  • dom/EventTarget.cpp: (WebCore::EventTarget::toJavaScriptAudioNode):
  • dom/EventTarget.h:
17:05 Changeset [72047] by ap@apple.com

Reviewed by Darin Adler.

A minor style fix in StyledElement.cpp.

  • dom/StyledElement.cpp: (WebCore::StyledElement::addCSSProperty): (WebCore::StyledElement::addCSSImageProperty):
17:03 Changeset [72046] by ap@apple.com

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=49565
Remove Attr.style accessor

  • dom/Attr.idl: Only keep the accessor for Objective C API. Inspector doesn't seem to need it any more.
16:40 Changeset [72045] by tkent@chromium.org

2010-11-15 Kent Tamura <tkent@chromium.org>

Unreviewed, test expectation update.

  • platform/chromium/drt_expectations.txt: Update for the recent status of Chromium-Linux DRT.
15:30 Changeset [72044] by aestes@apple.com

Unskip fast/forms/submit-form-attributes.html.

  • platform/mac-leopard/Skipped:
15:04 Changeset [72043] by inferno@chromium.org

Merge 72040

BUG=63031

14:59 Changeset [72042] by bdakin@apple.com

Fix for https://bugs.webkit.org/show_bug.cgi?id=49555
Frame::scalePage() should treat the origin as an absolute
coordinate
-and corresponding-
<rdar://problem/8667138>

Reviewed by Darin Adler.

  • page/Frame.cpp:

(WebCore::Frame::scalePage):

14:30 Changeset [72041] by mitz@apple.com

Fixed a weird typo

14:27 Changeset [72040] by mitz@apple.com

<rdar://problem/8662770> Error image has incorrect size when a custom font is used

Reviewed by Darin Adler.

WebCore:

Test: fast/images/style-access-during-imageChanged-crash.html

  • rendering/RenderImage.cpp:

(WebCore::RenderImage::RenderImage): Added initialization of m_needsToSetSizeForAltText.
(WebCore::RenderImage::imageSizeForError): Factored the non-alt-text dependent size computation
out of setImageSizeForAltText() into this function.
(WebCore::RenderImage::setImageSizeForAltText): Changed to use imageSizeForError().
(WebCore::RenderImage::styleDidChange): Added. If m_needsToSetSizeForAltText is true, sets the
intrinsic size and calls imageDimensionsChanged() as needed to cause layout or invalidation.
(WebCore::RenderImage::imageChanged): Moved som comed from here...
(WebCore::RenderImage::imageDimensionsChanged): ...to here.

  • rendering/RenderImage.h:

LayoutTests:

  • fast/images/style-access-during-imageChanged-crash-expected.txt: Added.
  • fast/images/style-access-during-imageChanged-crash.html: Added.
14:16 Changeset [72039] by andreas.kling@nokia.com

2010-11-15 Andreas Kling <kling@webkit.org>

Reviewed by Tor Arne Vestbø.

[Qt] Make sure qwkpage.h and qwkpreferences.h are copied into includes/WebKit2

  • UIProcess/API/qt/WKView.h:
14:08 Changeset [72038] by andersca@apple.com

ASSERTION (r72003): Assertion failure when running layout tests
https://bugs.webkit.org/show_bug.cgi?id=49561

Reviewed by Dimitri Glazkov.

r72003 added the 'formaction' URL attribute to HTMLButtonElement and HTMLInputElement,
but did not add the attribute to the isURLAttribute which lead to assertion failures
when running the layout tests with a debug build.

  • html/HTMLButtonElement.cpp:

(WebCore::HTMLButtonElement::isURLAttribute):

  • html/HTMLButtonElement.h:
  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::isURLAttribute):

14:07 Changeset [72037] by andreas.kling@nokia.com

2010-11-15 Andreas Kling <kling@webkit.org>

Reviewed by Tor Arne Vestbø.

[Qt] Use $${PYTHON} rather than "python" to execute Python scripts

Fixes building with the old Python that currently ships with Scratchbox.

  • DerivedSources.pro:
13:52 Changeset [72036] by ap@apple.com

2010-11-15 Alexey Proskuryakov <ap@apple.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=49559
DOMWindow.getComputedStyle pseudo element argument lacks ConvertUndefinedOrNullToNullString

No observable change in behavior, so no tests.

  • page/DOMWindow.idl: Added ConvertUndefinedOrNullToNullString.
13:50 Changeset [72035] by aestes@apple.com

r72003 caused fast/forms/submit-form-attributes.html to crash
DumpRenderTree on the Leopard Intel Debug (Tests) bot. Skip this test
until the failure is resolved.
https://bugs.webkit.org/show_bug.cgi?id=49562

  • platform/mac-leopard/Skipped:
13:46 Changeset [72034] by andreas.kling@nokia.com

2010-11-15 Andreas Kling <kling@webkit.org>

Reviewed by Tor Arne Vestbø.

[Qt] Make WTF_USE_MEEGOTOUCH available for WebKit2 as well

Move this into WebCore/features.pri which is used by both WebCore and WebKit2.

  • WebCore.pro:
  • features.pri:
13:42 Changeset [72033] by mrobinson@webkit.org

2010-11-15 Martin Robinson <mrobinson@igalia.com>

Build fix for GTK+.

  • GNUmakefile.am: Add some missing generated files to the source list.
13:38 Changeset [72032] by zmo@google.com

2010-11-15 Zhenyao Mo <zmo@google.com>

Ubreviewed, remove an empty line that causes the test to fail.

  • fast/canvas/webgl/tex-image-and-sub-image-2d-with-array-buffer-view-expected.txt:
13:33 Changeset [72031] by abecsi@webkit.org

2010-11-15 Andras Becsi <abecsi@webkit.org>

Reviewed by Andreas Kling.

[Qt][WK2] Avoid polling in WebKitTestRunner.
https://bugs.webkit.org/show_bug.cgi?id=49542

Make the WK2 testing session about 10-15% faster and decrease random flakiness
resulting from timing skew by removing the millisecond polling from TestControllerQt.

  • WebKitTestRunner/TestController.cpp: (WTR::TestController::didFinishLoadForFrame):
  • WebKitTestRunner/TestController.h:
  • WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
  • WebKitTestRunner/mac/TestControllerMac.mm: (WTR::TestController::notifyDone): Add method stub.
  • WebKitTestRunner/qt/TestControllerQt.cpp: (WTR::TestControllerRunLoop::instance): (WTR::TestControllerRunLoop::start): (WTR::TestControllerRunLoop::stop): (WTR::TestControllerRunLoop::TestControllerRunLoop): (WTR::TestControllerRunLoop::timerEvent): (WTR::TestController::notifyDone): (WTR::TestController::platformRunUntil):
  • WebKitTestRunner/win/TestControllerWin.cpp: (WTR::TestController::notifyDone): Add method stub.
13:29 Changeset [72030] by zmo@google.com

2010-11-15 Zhenyao Mo <zmo@google.com>

Unreviewed, update gpu test expectations.

  • platform/chromium-gpu/test_expectations.txt:
13:27 Changeset [72029] by beidson@apple.com
  • win/WebKit2Generated.make:

Reviewed by a better attempt at a Windows build fix.

13:20 Changeset [72028] by darin@apple.com
  • Scripts/webkitpy/common/net/bugzilla: Added property svn:ignore.
13:17 Changeset [72027] by beidson@apple.com
  • win/WebKit2Generated.make: Add new API headers here.

Reviewed by my attempt to fix the Windows build

13:17 Changeset [72026] by kbr@google.com

2010-11-15 Kenneth Russell <kbr@google.com>

Reviewed by James Robinson.

[chromium] Avoid copying of SkBitmap in LayerRendererChromium
https://bugs.webkit.org/show_bug.cgi?id=49560

Ran CSS 3D content to test. No other new tests.

  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::updateRootLayerTextureRect):
13:04 Changeset [72025] by kbr@google.com

2010-11-15 Kenneth Russell <kbr@google.com>

Reviewed by James Robinson.

[chromium] Remove assumption that GL functions are function pointers
https://bugs.webkit.org/show_bug.cgi?id=49486

Added appropriate extension queries and no longer assume that GL
function names are function pointers which can be tested.

  • src/WebGraphicsContext3DDefaultImpl.cpp: (WebKit::WebGraphicsContext3DDefaultImpl::WebGraphicsContext3DDefaultImpl): (WebKit::WebGraphicsContext3DDefaultImpl::initialize): (WebKit::WebGraphicsContext3DDefaultImpl::validateAttributes): (WebKit::WebGraphicsContext3DDefaultImpl::resolveMultisampledFramebuffer): (WebKit::WebGraphicsContext3DDefaultImpl::reshape): (WebKit::WebGraphicsContext3DDefaultImpl::generateMipmap): (WebKit::WebGraphicsContext3DDefaultImpl::getString):
  • src/WebGraphicsContext3DDefaultImpl.h:
12:47 Changeset [72024] by beidson@apple.com

Finish off <rdar://problem/8613727> and https://bugs.webkit.org/show_bug.cgi?id=48720
Customizable context menu support in WebKit2.

Reviewed by Sam Weinig.

  • Adds an API-level WKContextMenuItem.
  • Round trips through both the InjectedBundle client and the new PageContextMenuClient before actually displaying the menu.
  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:
  • Shared/API/c/WKBase.h:
  • Shared/API/c/WKContextMenuItem.cpp: Added.

(WKContextMenuItemGetTypeID):
(WKContextMenuItemCreateAsAction):
(WKContextMenuItemCreateAsCheckableAction):
(WKContextMenuItemCreateAsSubmenu):
(WKContextMenuItemSeparatorItem):
(WKContextMenuItemGetTag):
(WKContextMenuItemGetType):
(WKContextMenuItemCopyTitle):
(WKContextMenuItemGetEnabled):
(WKContextMenuItemGetChecked):
(WKContextMenuCopySubmenuItems):

  • Shared/API/c/WKContextMenuItem.h: Added.
  • Shared/API/c/WKContextMenuItemTypes.h: Added.
  • Shared/API/c/WKSharedAPICast.h:

(WebKit::toAPI):
(WebKit::toImpl):

  • Shared/WebContextMenuItem.cpp:

(WebKit::WebContextMenuItem::create):
(WebKit::WebContextMenuItem::separatorItem):
(WebKit::WebContextMenuItem::submenuItemsAsImmutableArray):

  • Shared/WebContextMenuItem.h:
  • UIProcess/API/C/WKPage.cpp:

(WKPageSetPageContextMenuClient):
(WKPageSetPageFindClient):
(WKPageSetPageLoaderClient):
(WKPageSetPagePolicyClient):
(WKPageSetPageUIClient):

  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebPageContextMenuClient.cpp: Added.

(WebKit::WebPageContextMenuClient::getContextMenuFromProposedMenu):

  • UIProcess/WebPageContextMenuClient.h: Added.
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::initializeContextMenuClient):
(WebKit::WebPageProxy::showContextMenu):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/InjectedBundle/InjectedBundlePageContextMenuClient.cpp:

(WebKit::InjectedBundlePageContextMenuClient::getCustomMenuFromDefaultItems):

  • WebProcess/InjectedBundle/InjectedBundlePageContextMenuClient.h:
  • WebProcess/WebCoreSupport/WebContextMenuClient.cpp:

(WebKit::WebContextMenuClient::getCustomMenuFromDefaultItems):

  • WebProcess/WebPage/WebContextMenu.cpp:

(WebKit::WebContextMenu::show):

12:46 Changeset [72023] by andersca@apple.com

Add shouldDecodeSourceDataOfMIMEType WKContextDownloadClient callback
https://bugs.webkit.org/show_bug.cgi?id=49558

Reviewed by Sam Weinig.

  • UIProcess/API/C/WKContext.h:

Add shouldDecodeSourceDataOfMIMEType callback.

  • UIProcess/Downloads/DownloadProxy.cpp:

(WebKit::DownloadProxy::shouldDecodeSourceDataOfMIMEType):
Call WebDownloadClient::shouldDecodeSourceDataOfMIMEType.

(WebKit::DownloadProxy::decideDestinationWithSuggestedFilename):
Add allowOverwrite out parameter.

  • UIProcess/Downloads/DownloadProxy.h:
  • UIProcess/Downloads/DownloadProxy.messages.in:

Add ShouldDecodeSourceDataOfMIMEType message.

  • UIProcess/WebDownloadClient.cpp:

(WebKit::WebDownloadClient::shouldDecodeSourceDataOfMIMEType):
Call the WKContextDownloadClient.

(WebKit::WebDownloadClient::decideDestinationWithSuggestedFilename):
Add allowOverwrite out parameter.

  • UIProcess/WebDownloadClient.h:
  • WebProcess/Downloads/Download.cpp:

(WebKit::Download::shouldDecodeSourceDataOfMIMEType):
Send the ShouldDecodeSourceDataOfMIMEType message.

(WebKit::Download::decideDestinationWithSuggestedFilename):
Add allowOverwrite reply parameter.

  • WebProcess/Downloads/mac/DownloadMac.mm:

(-[WKDownloadAsDelegate download:shouldDecodeSourceDataOfMIMEType:]):
Call Download::shouldDecodeSourceDataOfMIMEType.

(-[WKDownloadAsDelegate download:decideDestinationWithSuggestedFilename:]):
Add allowOverwrite parameter.

12:31 Changeset [72022] by inferno@chromium.org

Merge 72013

BUG=63051

12:25 Changeset [72021] by vangelis@chromium.org

2010-11-15 Vangelis Kokkevis <vangelis@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Fixes layer opacity implementation of composited layers
https://bugs.webkit.org/show_bug.cgi?id=49233

This introduces a fairly drastic change in how LayerRendererChromium draws
composited layers. Layers that have non-zero opacity as well as layers that
clip their descendants (and have non-trivial transforms) are now first
rendered onto off-screen surfaces (RenderSurfaceChromium's). The compositing
operation now consists of two distinct phases: First a hierarchical traversal
of the layer tree to compute the layer transforms, determine what the necessary
RenderSurfaces are and sort layer that preserve-3d based on their z-value. A second
pass goes through all the RenderSurfaces discovered by the first pass and updates
their contents.
Additional significant side-effects of this change are:

  1. Depth buffer and depth testing is no longer used. Drawing relies on a painter's algorithm to render layers with the preserves-3d property from back to front using the Z coordinate of their center. This will further be improved in the future with the intoduction of a BSP tree to properly deal with intersecting layers.
  2. Compositor no longer uses the stencil buffer to do clipping. Clipping is now performed by rendering layer subtrees into an offscreen buffer and setting the appropriate scissor and viewport transformation.

Tests: abs-position-inside-opacity.html (for the opacity implementation)

and the rest of the compositing layout tests to verify that
everything still works.

  • WebCore.gypi:
  • platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::cleanupResources): (WebCore::ContentLayerChromium::requiresClippedUpdateRect): (WebCore::ContentLayerChromium::calculateClippedUpdateRect): (WebCore::ContentLayerChromium::updateContents):
  • platform/graphics/chromium/LayerChromium.cpp: (WebCore::LayerChromium::LayerChromium): (WebCore::LayerChromium::cleanupResources): (WebCore::LayerChromium::createRenderSurface): (WebCore::LayerChromium::descendantsDrawContent): (WebCore::LayerChromium::descendantsDrawContentRecursive):
  • platform/graphics/chromium/LayerChromium.h: (WebCore::LayerChromium::drawTransform): (WebCore::LayerChromium::layerRenderer):
  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::orthoMatrix): (WebCore::isScaleOrTranslation): (WebCore::LayerRendererChromium::compareLayerZ): (WebCore::LayerRendererChromium::LayerRendererChromium): (WebCore::LayerRendererChromium::prepareToDrawLayers): (WebCore::LayerRendererChromium::drawLayers): (WebCore::LayerRendererChromium::updateLayersRecursive): (WebCore::LayerRendererChromium::useRenderSurface): (WebCore::LayerRendererChromium::drawLayer): (WebCore::LayerRendererChromium::setScissorToRect): (WebCore::LayerRendererChromium::setDrawViewportRect): (WebCore::LayerRendererChromium::initializeSharedObjects): (WebCore::LayerRendererChromium::cleanupSharedObjects):
  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/RenderSurfaceChromium.cpp: Added. (WebCore::RenderSurfaceChromium::RenderSurfaceChromium): (WebCore::RenderSurfaceChromium::~RenderSurfaceChromium): (WebCore::RenderSurfaceChromium::cleanupResources): (WebCore::RenderSurfaceChromium::layerRenderer): (WebCore::RenderSurfaceChromium::prepareContentsTexture):
  • platform/graphics/chromium/RenderSurfaceChromium.h: Added. (WebCore::RenderSurfaceChromium::contentRectCenter): (WebCore::RenderSurfaceChromium::contentRect):
  • platform/graphics/chromium/VideoLayerChromium.cpp: (WebCore::VideoLayerChromium::cleanupResources):
12:16 Changeset [72020] by mrobinson@webkit.org

2010-11-15 Martin Robinson <mrobinson@igalia.com>

Reviewed by Andreas Kling.

[GTK] gdk_pixbuf_get_from_surface from GtkVersioning.h is broken on GTK+ 2 builds
https://bugs.webkit.org/show_bug.cgi?id=49549

No new tests. This can be verified by loading any existing vertical text test
in GtkLauncher and noticing the lack of CRITICAL GLib exceptions. There's currently
no automatic way of verifying custom cursors.

  • platform/gtk/GtkVersioning.c: (gdk_pixbuf_get_from_surface): Reverse a sanity check in this method to be correct.
11:59 Changeset [72019] by zmo@google.com

2010-11-15 Zhenyao Mo <zmo@google.com>

Unreviewed, skip failing WebGL test.

  • platform/mac-snowleopard/Skipped:
11:48 Changeset [72018] by andersca@apple.com

Add decideDestinationWithSuggestedFilename WKContextDownloadClient callback
https://bugs.webkit.org/show_bug.cgi?id=49554

Reviewed by Sam Weinig.

  • Platform/CoreIPC/MessageSender.h:

(CoreIPC::MessageSender::sendSync):
Add sendSync capabilities to Messagesender.

  • UIProcess/API/C/WKContext.h:

AdddecideDestinationWithSuggestedFilename callback.

  • UIProcess/Downloads/DownloadProxy.cpp:

(WebKit::DownloadProxy::decideDestinationWithSuggestedFilename):
Call WebDownloadClient::decideDestinationWithSuggestedFilename.

  • UIProcess/Downloads/DownloadProxy.messages.in:

Add DecideDestinationWithSuggestedFilename.

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::didReceiveSyncMessage):
Process MessageClassDownloadProxy messages.

  • UIProcess/WebDownloadClient.cpp:

(WebKit::WebDownloadClient::decideDestinationWithSuggestedFilename):
Ask the WKContextDownloadClient for the destination.

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::didReceiveSyncMessage):
MessageClassDownloadProxy messages should go to the WebContext.

  • WebProcess/Downloads/Download.cpp:

(WebKit::Download::decideDestinationWithSuggestedFilename):
Send the DecideDestinationWithSuggestedFilename message.

  • WebProcess/Downloads/Download.h:
  • WebProcess/Downloads/mac/DownloadMac.mm:

(-[WKDownloadAsDelegate download:decideDestinationWithSuggestedFilename:]):
call Download::decideDestinationWithSuggestedFilename and set the destination.

11:39 Changeset [72017] by jer.noble@apple.com

2010-11-12 Jer Noble <jer.noble@apple.com>

Reviewed by Brady Eidson.

Can't view HTML5 video when running Safari with an authenticated proxy server
<rdar://problem/8351926>


  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::createQTMovie):
11:08 Changeset [72016] by andreas.kling@nokia.com

2010-11-15 Andreas Kling <kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[WK2][Qt] Add "page snapshot" functionality to tiled backing store

Original patch by Antti Koivisto.

Add a way to take a snapshot of a specific part of the page, at a specific scale.
Only implemented for the tiled drawing area.

  • Shared/CoreIPCSupport/DrawingAreaMessageKinds.h: New message: TakeSnapshot.
  • Shared/CoreIPCSupport/DrawingAreaProxyMessageKinds.h: New message: SnapshotTaken.
  • UIProcess/API/qt/qgraphicswkview.h:
  • UIProcess/API/qt/qgraphicswkview.cpp: (QGraphicsWKView::takeSnapshot): Expose the snapshot functionality.
  • UIProcess/TiledDrawingAreaProxy.cpp: (WebKit::TiledDrawingAreaProxy::didReceiveMessage): (WebKit::TiledDrawingAreaProxy::takeSnapshot):
  • UIProcess/TiledDrawingAreaProxy.h:
  • UIProcess/qt/TiledDrawingAreaProxyQt.cpp: (WebKit::TiledDrawingAreaProxy::snapshotTaken):
  • WebProcess/WebPage/TiledDrawingArea.cpp: (WebKit::TiledDrawingArea::didReceiveMessage):
10:58 Changeset [72015] by mrobinson@webkit.org

2010-11-15 Martin Robinson <mrobinson@igalia.com>

[GTK] Navigation policy decision API needs to include the DOM node that the decision originated from
https://bugs.webkit.org/show_bug.cgi?id=49551

Add GTK+-specific results for these tests which do policy delegate dumps,
until GTK+ can produce the "originating from" information.

  • platform/gtk/fast/forms/mailto/formenctype-attribute-button-html-expected.txt: Added.
  • platform/gtk/fast/forms/mailto/formenctype-attribute-input-html-expected.txt: Added.
10:45 Changeset [72014] by zmo@google.com

2010-11-15 Zhenyao Mo <zmo@google.com>

Unreviewed, test expectation update.

  • platform/chromium/test_expectations.txt:
10:37 Changeset [72013] by inferno@chromium.org

2010-11-14 Abhishek Arya <inferno@chromium.org>

Reviewed by Dimitri Glazkov.

Event dispatch call can blow away the node's renderer initialized
before the call in updateSelectionForMouseDrag function. We need
to initialize it after the call.
https://bugs.webkit.org/show_bug.cgi?id=49524

  • page/EventHandler.cpp: (WebCore::EventHandler::updateSelectionForMouseDrag):
09:42 Changeset [72012] by zmo@google.com

2010-11-12 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

[Chromium] fast/canvas/webgl/tex-image-and-sub-image-2d-with-array-buffer-view.html is a flaky crash
https://bugs.webkit.org/show_bug.cgi?id=48142

  • fast/canvas/webgl/tex-image-and-sub-image-2d-with-array-buffer-view.html: Cleanup the test, hoping to stop flaky crashes on chromium bots.
09:35 Changeset [72011] by mrobinson@webkit.org

2010-11-15 Martin Robinson <mrobinson@igalia.com>

Add some baselines for new tests and skip a HTML5 meter test until
GTK+ supports rendering the meter element.

  • platform/gtk/Skipped: Skip meter test.
  • platform/gtk/fast/block/basic/truncation-rtl-expected.txt: Added.
  • platform/gtk/fast/blockflow/background-horizontal-bt-expected.txt: Added.
  • platform/gtk/fast/blockflow/background-vertical-lr-expected.txt: Added.
  • platform/gtk/fast/blockflow/background-vertical-rl-expected.txt: Added.
  • platform/gtk/fast/blockflow/basic-vertical-line-expected.txt: Added.
  • platform/gtk/fast/blockflow/body-direction-propagation-blocked-expected.txt: Added.
  • platform/gtk/fast/blockflow/body-direction-propagation-expected.txt: Added.
  • platform/gtk/fast/blockflow/body-writing-mode-propagation-blocked-expected.txt: Added.
  • platform/gtk/fast/blockflow/body-writing-mode-propagation-expected.txt: Added.
  • platform/gtk/fast/blockflow/border-image-horizontal-bt-expected.txt: Added.
  • platform/gtk/fast/blockflow/border-image-vertical-lr-expected.txt: Added.
  • platform/gtk/fast/blockflow/border-image-vertical-rl-expected.txt: Added.
  • platform/gtk/fast/blockflow/border-radius-clipping-vertical-lr-expected.txt: Added.
  • platform/gtk/fast/blockflow/border-vertical-lr-expected.txt: Added.
  • platform/gtk/fast/blockflow/box-shadow-horizontal-bt-expected.txt: Added.
  • platform/gtk/fast/blockflow/box-shadow-vertical-lr-expected.txt: Added.
  • platform/gtk/fast/blockflow/box-shadow-vertical-rl-expected.txt: Added.
  • platform/gtk/fast/blockflow/broken-ideograph-small-caps-expected.txt: Added.
  • platform/gtk/fast/blockflow/broken-ideographic-font-expected.txt: Added.
  • platform/gtk/fast/blockflow/english-bt-text-expected.txt: Added.
  • platform/gtk/fast/blockflow/english-lr-text-expected.txt: Added.
  • platform/gtk/fast/blockflow/english-rl-text-expected.txt: Added.
  • platform/gtk/fast/blockflow/horizontal-bt-replaced-selection-expected.txt: Added.
  • platform/gtk/fast/blockflow/japanese-lr-selection-expected.txt: Added.
  • platform/gtk/fast/blockflow/japanese-lr-text-expected.txt: Added.
  • platform/gtk/fast/blockflow/japanese-rl-selection-expected.txt: Added.
  • platform/gtk/fast/blockflow/japanese-rl-text-expected.txt: Added.
  • platform/gtk/fast/blockflow/japanese-ruby-horizontal-bt-expected.txt: Added.
  • platform/gtk/fast/blockflow/japanese-ruby-vertical-lr-expected.txt: Added.
  • platform/gtk/fast/blockflow/japanese-ruby-vertical-rl-expected.txt: Added.
  • platform/gtk/fast/blockflow/vertical-font-fallback-expected.txt: Added.
  • platform/gtk/fast/blockflow/vertical-lr-replaced-selection-expected.txt: Added.
  • platform/gtk/fast/blockflow/vertical-rl-replaced-selection-expected.txt: Added.
  • platform/gtk/fast/borders/border-radius-inline-flow-expected.txt: Added.
  • platform/gtk/fast/images/gray-scale-png-with-color-profile-expected.txt: Added.
  • platform/gtk/fast/images/pixel-crack-image-background-webkit-transform-scale-expected.txt: Added.
  • platform/gtk/fast/lists/001-vertical-expected.txt: Added.
  • platform/gtk/fast/lists/002-vertical-expected.txt: Added.
  • platform/gtk/fast/lists/003-vertical-expected.txt: Added.
  • platform/gtk/fast/lists/005-vertical-expected.txt: Added.
  • platform/gtk/fast/lists/006-vertical-expected.txt: Added.
  • platform/gtk/fast/lists/007-vertical-expected.txt: Added.
  • platform/gtk/fast/lists/008-vertical-expected.txt: Added.
  • platform/gtk/fast/lists/009-vertical-expected.txt: Added.
  • platform/gtk/fast/repaint/iframe-scroll-repaint-expected.txt: Added.
  • platform/gtk/fast/repaint/inline-horizontal-bt-overflow-expected.txt: Added.
  • platform/gtk/fast/repaint/inline-vertical-lr-overflow-expected.txt: Added.
  • platform/gtk/fast/repaint/inline-vertical-rl-overflow-expected.txt: Added.
  • platform/gtk/fast/repaint/japanese-rl-selection-clear-expected.txt: Added.
  • platform/gtk/fast/repaint/japanese-rl-selection-repaint-expected.txt: Added.
  • platform/gtk/fast/repaint/repaint-across-writing-mode-boundary-expected.txt: Added.
  • platform/gtk/fast/repaint/selection-rl-expected.txt: Added.
  • platform/gtk/fast/table/027-vertical-expected.txt: Added.
  • platform/gtk/fast/table/028-vertical-expected.txt: Added.
  • platform/gtk/fast/table/035-vertical-expected.txt: Added.
  • platform/gtk/fast/table/038-vertical-expected.txt: Added.
  • platform/gtk/fast/table/040-vertical-expected.txt: Added.
  • platform/gtk/fast/table/auto-with-percent-height-vertical-expected.txt: Added.
  • platform/gtk/fast/table/border-collapsing/001-vertical-expected.txt: Added.
  • platform/gtk/fast/table/border-collapsing/002-vertical-expected.txt: Added.
  • platform/gtk/fast/table/border-collapsing/003-vertical-expected.txt: Added.
  • platform/gtk/fast/table/border-collapsing/004-vertical-expected.txt: Added.
  • platform/gtk/fast/table/border-collapsing/border-collapsing-head-foot-vertical-expected.txt: Added.
  • platform/gtk/fast/table/border-collapsing/equal-precedence-resolution-vertical-expected.txt: Added.
  • platform/gtk/fast/table/border-collapsing/rtl-border-collapsing-vertical-expected.txt: Added.
  • platform/gtk/fast/table/colspanMinWidth-vertical-expected.txt: Added.
  • platform/gtk/fast/table/fixed-with-auto-with-colspan-vertical-expected.txt: Added.
  • platform/gtk/fast/table/growCellForImageQuirk-vertical-expected.txt: Added.
  • platform/gtk/fast/table/height-percent-test-vertical-expected.txt: Added.
  • platform/gtk/fast/table/percent-widths-stretch-vertical-expected.txt: Added.
  • platform/gtk/fast/table/rowspan-paint-order-vertical-expected.txt: Added.
  • platform/gtk/fast/table/table-display-types-vertical-expected.txt: Added.
  • platform/gtk/fast/text/international/vertical-text-glyph-test-expected.txt: Added.
  • platform/gtk/fast/text/international/vertical-text-metrics-test-expected.txt: Added.
  • platform/gtk/fast/transforms/rotated-transform-affects-scrolling-1-expected.txt: Added.
  • platform/gtk/fast/transforms/rotated-transform-affects-scrolling-2-expected.txt: Added.
  • platform/gtk/mathml/xHeight-expected.txt: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.txt: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.txt: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.txt: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.txt: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.txt: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.txt: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.txt: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.txt: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt: Added.
  • platform/gtk/svg/custom/repaint-on-constant-size-change-expected.txt: Added.
09:34 Changeset [72010] by andreas.kling@nokia.com

2010-11-15 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[WK2][Qt] WebKit2 implementation of tiled backing store
https://bugs.webkit.org/show_bug.cgi?id=49526

Basic opt-in tiling implementation for WebKit2/Qt.

Original patch by Antti Koivisto.

  • Shared/CoreIPCSupport/DrawingAreaMessageKinds.h: New messages: RequestTileUpdate and CancelTileUpdate.
  • Shared/CoreIPCSupport/DrawingAreaProxyMessageKinds.h: New messages: Invalidate, TileUpdated, AllTileUpdatesProcessed.
  • Shared/DrawingAreaBase.h: New area type: TiledDrawingAreaType.
  • UIProcess/API/qt/qgraphicswkview.h:
  • UIProcess/API/qt/qgraphicswkview.cpp: (QGraphicsWKView::QGraphicsWKView): (QGraphicsWKView::setGeometry): (QGraphicsWKViewPrivate::QGraphicsWKViewPrivate): (QGraphicsWKView::prepareScaleChange): (QGraphicsWKView::commitScaleChange): (QGraphicsWKViewPrivate::onScaleChanged): (QGraphicsWKViewPrivate::commitScale): Support for tiled backing store.
  • UIProcess/TiledDrawingAreaProxy.cpp: Added. (WebKit::TiledDrawingAreaProxy::create): (WebKit::TiledDrawingAreaProxy::TiledDrawingAreaProxy): (WebKit::TiledDrawingAreaProxy::~TiledDrawingAreaProxy): (WebKit::TiledDrawingAreaProxy::setSize): (WebKit::TiledDrawingAreaProxy::setPageIsVisible): (WebKit::TiledDrawingAreaProxy::didSetSize): (WebKit::TiledDrawingAreaProxy::didReceiveMessage): (WebKit::TiledDrawingAreaProxy::didReceiveSyncMessage): (WebKit::TiledDrawingAreaProxy::requestTileUpdate): (WebKit::TiledDrawingAreaProxy::waitUntilUpdatesComplete): (WebKit::TiledDrawingAreaProxy::createTile): (WebKit::TiledDrawingAreaProxy::setTileSize): (WebKit::TiledDrawingAreaProxy::setTileCreationDelay): (WebKit::TiledDrawingAreaProxy::setKeepAndCoverAreaMultipliers): (WebKit::TiledDrawingAreaProxy::invalidate): (WebKit::TiledDrawingAreaProxy::updateTileBuffers): (WebKit::TiledDrawingAreaProxy::tileBufferUpdateComplete): (WebKit::TiledDrawingAreaProxy::paint): (WebKit::TiledDrawingAreaProxy::adjustVisibleRect): (WebKit::TiledDrawingAreaProxy::setContentsScale): (WebKit::TiledDrawingAreaProxy::removeAllTiles): (WebKit::TiledDrawingAreaProxy::tileDistance): (WebKit::TiledDrawingAreaProxy::calculateKeepRect): (WebKit::TiledDrawingAreaProxy::calculateCoverRect): (WebKit::TiledDrawingAreaProxy::createTiles): (WebKit::TiledDrawingAreaProxy::resizeEdgeTiles): (WebKit::TiledDrawingAreaProxy::dropTilesOutsideRect): (WebKit::TiledDrawingAreaProxy::tileAt): (WebKit::TiledDrawingAreaProxy::setTile): (WebKit::TiledDrawingAreaProxy::removeTile): (WebKit::TiledDrawingAreaProxy::mapToContents): (WebKit::TiledDrawingAreaProxy::mapFromContents): (WebKit::TiledDrawingAreaProxy::contentsRect): (WebKit::TiledDrawingAreaProxy::tileRectForCoordinate): (WebKit::TiledDrawingAreaProxy::tileCoordinateForPoint): (WebKit::TiledDrawingAreaProxy::startTileBufferUpdateTimer): (WebKit::TiledDrawingAreaProxy::tileBufferUpdateTimerFired): (WebKit::TiledDrawingAreaProxy::startTileCreationTimer): (WebKit::TiledDrawingAreaProxy::tileCreationTimerFired): (WebKit::TiledDrawingAreaProxy::hasPendingUpdates):
  • UIProcess/TiledDrawingAreaProxy.h: Added. (WebKit::TiledDrawingAreaProxy::contentsScale): (WebKit::TiledDrawingAreaProxy::attachCompositingContext): (WebKit::TiledDrawingAreaProxy::detachCompositingContext): (WebKit::TiledDrawingAreaProxy::tileSize): (WebKit::TiledDrawingAreaProxy::tileCreationDelay): (WebKit::TiledDrawingAreaProxy::getKeepAndCoverAreaMultipliers):
  • UIProcess/TiledDrawingAreaTile.h: Added. (WebKit::TiledDrawingAreaTile::create): (WebKit::TiledDrawingAreaTile::hasBackBufferUpdatePending): (WebKit::TiledDrawingAreaTile::coordinate): (WebKit::TiledDrawingAreaTile::rect): (WebKit::TiledDrawingAreaTile::ID):
  • WebProcess/WebPage/DrawingArea.cpp: (WebKit::DrawingArea::create):
  • WebProcess/WebPage/TiledDrawingArea.cpp: Added. (WebKit::TiledDrawingArea::TiledDrawingArea): (WebKit::TiledDrawingArea::~TiledDrawingArea): (WebKit::TiledDrawingArea::invalidateWindow): (WebKit::TiledDrawingArea::invalidateContentsAndWindow): (WebKit::TiledDrawingArea::invalidateContentsForSlowScroll): (WebKit::TiledDrawingArea::scroll): (WebKit::TiledDrawingArea::setNeedsDisplay): (WebKit::TiledDrawingArea::display): (WebKit::TiledDrawingArea::scheduleDisplay): (WebKit::TiledDrawingArea::setSize): (WebKit::TiledDrawingArea::suspendPainting): (WebKit::TiledDrawingArea::resumePainting): (WebKit::TiledDrawingArea::didUpdate): (WebKit::TiledDrawingArea::updateTile): (WebKit::TiledDrawingArea::tileUpdateTimerFired): (WebKit::TiledDrawingArea::didReceiveMessage):
  • WebProcess/WebPage/TiledDrawingArea.h: Added. (WebKit::TiledDrawingArea::attachCompositingContext): (WebKit::TiledDrawingArea::detachCompositingContext): (WebKit::TiledDrawingArea::setRootCompositingLayer): (WebKit::TiledDrawingArea::scheduleCompositingLayerSync): (WebKit::TiledDrawingArea::syncCompositingLayers):
  • WebProcess/WebPage/qt/TiledDrawingAreaQt.cpp: Added. (WebKit::TiledDrawingArea::paintIntoUpdateChunk):
  • WebKit2.pro:
  • UIProcess/qt/TiledDrawingAreaTileQt.cpp: Added. (WebKit::checkeredPixmap): (WebKit::TiledDrawingAreaTile::TiledDrawingAreaTile): (WebKit::TiledDrawingAreaTile::~TiledDrawingAreaTile): (WebKit::TiledDrawingAreaTile::isDirty): (WebKit::TiledDrawingAreaTile::isReadyToPaint): (WebKit::TiledDrawingAreaTile::hasReadyBackBuffer): (WebKit::TiledDrawingAreaTile::invalidate): (WebKit::TiledDrawingAreaTile::resize): (WebKit::TiledDrawingAreaTile::swapBackBufferToFront): (WebKit::TiledDrawingAreaTile::paint): (WebKit::TiledDrawingAreaTile::paintCheckerPattern): (WebKit::TiledDrawingAreaTile::updateFromChunk): (WebKit::TiledDrawingAreaTile::updateBackBuffer):
  • UIProcess/qt/TiledDrawingAreaProxyQt.cpp: Added. (WebKit::TiledDrawingAreaProxy::updateWebView): (WebKit::TiledDrawingAreaProxy::webViewVisibleRect): (WebKit::TiledDrawingAreaProxy::page):
09:29 Changeset [72009] by bulach@chromium.org

2010-11-15 Marcus Bulach <bulach@chromium.org>

Not reviewed, Chromium test expectation update.

Update chromium baselines for svg following r72006
https://bugs.webkit.org/show_bug.cgi?id=49547

  • platform/chromium-linux/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png: Added.
08:56 Changeset [72008] by benjamin.poulain@nokia.com

2010-11-15 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Andreas Kling.

[Qt] [WK2] Add Ctrl+L shortcut to Qt Minibrowser
https://bugs.webkit.org/show_bug.cgi?id=49544

Add the shortcut to BrowserWindow.

  • MiniBrowser/qt/BrowserWindow.cpp: (BrowserWindow::BrowserWindow): (BrowserWindow::openLocation):
  • MiniBrowser/qt/BrowserWindow.h:
08:24 Changeset [72007] by paroga@webkit.org

2010-11-15 Patrick Gansterer <paroga@webkit.org>

Reviewed by Martin Robinson.

Make ContextShadow compile on all platforms
https://bugs.webkit.org/show_bug.cgi?id=49535

Add a void* typedef for PlatformImage and PlatformContext for unsupported platforms
and move them into the WebCore namespace like all other Platform* typedefs.

  • platform/graphics/ContextShadow.h:
08:10 Changeset [72006] by reni@webkit.org

WebCore: SVGFEImageElement doesn't support dynamic invalidation
https://bugs.webkit.org/show_bug.cgi?id=49536

Patch by Renata Hodovan <reni@webkit.org> on 2010-11-15
Reviewed by Andreas Kling.

The dynamic changes are captured by the svgAttributeChanged function. Invalidate the filter primitive if necessary.

Tests: svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr.html

svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop.html

  • svg/SVGFEImageElement.cpp:

(WebCore::SVGFEImageElement::svgAttributeChanged):

  • svg/SVGFEImageElement.h:

LayoutTests: SVGFEImageElement doesn't support dynamic invalidation, when attributes change.
https://bugs.webkit.org/show_bug.cgi?id=49536

Patch by Renata Hodovan <reni@webkit.org> on 2010-11-15
Reviewed by Andreas Kling.

Adding layout tests for feImage dynamic changes.

  • platform/mac/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png: Added.
  • svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr.html: Added.
  • svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop.html: Added.
  • svg/dynamic-updates/script-tests/SVGFEImageElement-dom-preserveAspectRatio-attr.js: Added.

(executeTest):

  • svg/dynamic-updates/script-tests/SVGFEImageElement-svgdom-preserveAspectRatio-prop.js: Added.

(executeTest):

06:49 Changeset [72005] by ossy@webkit.org

Unreviewed. Add Qt specific expected results after r72003.

[Qt] Possible DRT bug revealed by r72003
https://bugs.webkit.org/show_bug.cgi?id=49538

  • platform/qt/fast/forms/formaction-attribute-expected.txt: Copied from LayoutTests/fast/forms/formaction-attribute-expected.txt.
  • platform/qt/fast/forms/formmethod-attribute-button-html-expected.txt: Copied from LayoutTests/fast/forms/formmethod-attribute-button-html-expected.txt.
  • platform/qt/fast/forms/formtarget-attribute-button-html-expected.txt: Copied from LayoutTests/fast/forms/formtarget-attribute-button-html-expected.txt.
  • platform/qt/fast/forms/mailto: Added.
  • platform/qt/fast/forms/mailto/formenctype-attribute-button-html-expected.txt: Copied from LayoutTests/fast/forms/mailto/formenctype-attribute-button-html-expected.txt.
  • platform/qt/fast/forms/mailto/formenctype-attribute-input-html-expected.txt: Copied from LayoutTests/fast/forms/mailto/formenctype-attribute-input-html-expected.txt.
05:32 Changeset [72004] by yael.aharon@nokia.com

2010-11-15 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Antonio Gomes.

[Qt] Focus ring does not show on focused links.
https://bugs.webkit.org/show_bug.cgi?id=49515

  • platform/qt/fast/inline/inline-focus-ring-expected.checksum: Added.
  • platform/qt/fast/inline/inline-focus-ring-expected.png: Added.
  • platform/qt/fast/inline/inline-focus-ring-expected.txt: Added.

2010-11-15 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Antonio Gomes.

[Qt] Focus ring does not show on focused links.
https://bugs.webkit.org/show_bug.cgi?id=49515

After http://trac.webkit.org/changeset/69766 the focus ring on links is no longer
visible in Qt.
The reason is that Qt always returned true in RenderTheme::supportsFocusRing(),
but until r69766, we did not check that for links. Qt draws its own focus ring
for controls that it draws, but not for links.
Change the return value to false if the style's appearance is not something that Qt
draws by itself or does not support.
Added a Qt specific test result for the new test added in r69766.

  • platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::supportsFocusRing):
04:43 Changeset [72003] by commit-queue@webkit.org

2010-11-15 Dai Mikurube <dmikurube@google.com>

Reviewed by Kent Tamura.

Implement formaction, formenctype, formmethod and formtarget attributes for input and button tags
https://bugs.webkit.org/show_bug.cgi?id=49240

  • fast/forms/formaction-attribute-expected.txt: Added.
  • fast/forms/formaction-attribute.html: Added.
  • fast/forms/formmethod-attribute-button-html-expected.txt: Added.
  • fast/forms/formmethod-attribute-button-html.html: Added.
  • fast/forms/formmethod-attribute-input-html-expected.txt: Added.
  • fast/forms/formmethod-attribute-input-html.html: Added.
  • fast/forms/formtarget-attribute-button-html-expected.txt: Added.
  • fast/forms/formtarget-attribute-button-html.html: Added.
  • fast/forms/formtarget-attribute-input-html-expected.txt: Added.
  • fast/forms/formtarget-attribute-input-html.html: Added.
  • fast/forms/mailto/formenctype-attribute-button-html-expected.txt: Added.
  • fast/forms/mailto/formenctype-attribute-button-html.html: Added.
  • fast/forms/mailto/formenctype-attribute-input-html-expected.txt: Added.
  • fast/forms/mailto/formenctype-attribute-input-html.html: Added.
  • fast/forms/script-tests/submit-form-attributes.js: Added.
  • fast/forms/submit-form-attributes-expected.txt: Added.
  • fast/forms/submit-form-attributes.html: Added.

2010-11-15 Dai Mikurube <dmikurube@google.com>

Reviewed by Kent Tamura.

Implement formaction, formenctype, formmethod and formtarget attributes for input and button tags
https://bugs.webkit.org/show_bug.cgi?id=49240

Tests: fast/forms/formaction-attribute.html

fast/forms/formmethod-attribute-button-html.html
fast/forms/formmethod-attribute-input-html.html
fast/forms/formtarget-attribute-button-html.html
fast/forms/formtarget-attribute-input-html.html
fast/forms/mailto/formenctype-attribute-button-html.html
fast/forms/mailto/formenctype-attribute-input-html.html
fast/forms/submit-form-attributes.html

  • html/HTMLAttributeNames.in: Added formaction, formmethod, formtarget and formenctype attributes
  • html/HTMLButtonElement.idl:
  • html/HTMLInputElement.idl:
  • loader/FormSubmission.cpp: Modified to check the pressed button and its attributes (WebCore::FormSubmission::Attributes::copyFrom): (WebCore::FormSubmission::create):
  • loader/FormSubmission.h:
04:09 Changeset [72002] by pfeldman@chromium.org

2010-11-15 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Do not hide default Ctrl+A behavior on non-Mac.
https://bugs.webkit.org/show_bug.cgi?id=49527

  • inspector/front-end/TextPrompt.js: (WebInspector.TextPrompt.prototype._onKeyDown):
03:37 Changeset [72001] by commit-queue@webkit.org

2010-11-15 Ilya Sherman <isherman@chromium.org>

Reviewed by Kent Tamura.

Add capability for displaying warnings to autofill popup
Warnings are displayed in dark gray italic.
https://bugs.webkit.org/show_bug.cgi?id=49291
http://code.google.com/p/chromium/issues/detail?id=58509

  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupListBox::getRowFont): Use item-specific font, not just the generic menu font. (WebCore::PopupListBox::selectIndex): Updated to clear the selection when hovering over a non-selectable item.
  • platform/chromium/PopupMenuChromium.h: Minor cleanup

2010-11-15 Ilya Sherman <isherman@chromium.org>

Reviewed by Kent Tamura.

Add capability for displaying warnings to autofill popup
Warnings are displayed in dark gray italic.
https://bugs.webkit.org/show_bug.cgi?id=49291
http://code.google.com/p/chromium/issues/detail?id=58509

  • src/AutoFillPopupMenuClient.cpp: (WebKit::AutoFillPopupMenuClient::canRemoveSuggestionAtIndex): Updated logic -- can only remove Autocomplete suggestions, which have unique ID 0. (WebKit::AutoFillPopupMenuClient::itemIsEnabled): False for warnings. (WebKit::AutoFillPopupMenuClient::itemStyle): Dark gray italic for warnings. (WebKit::AutoFillPopupMenuClient::menuStyle): Variable name changed. (WebKit::AutoFillPopupMenuClient::itemIsWarning): True for unique ID < 0. (WebKit::AutoFillPopupMenuClient::initialize): Updated cached styles (see above).
  • src/AutoFillPopupMenuClient.h: Added itemIsEnabled(), variable to cache warning style.
  • src/WebViewImpl.cpp: Minor cleanup. (WebKit::WebViewImpl::applyAutoFillSuggestions):
02:39 Changeset [72000] by alex@webkit.org

2010-11-15 Alejandro G. Castro <alex@igalia.com>

Unreviewed.

Skipping SVG failing tests for GTK+ until we find the issue,
opened a bug:
[gtk] SVGLineElement-dom-requiredFeatures.html and
SVGLineElement-svgdom-requiredFeatures.html failing in the bots
https://bugs.webkit.org/show_bug.cgi?id=49529

  • platform/gtk/Skipped:

11/14/10:

23:46 Changeset [71999] by tkent@chromium.org

2010-11-14 Kent Tamura <tkent@chromium.org>

Unreviewed, test expectation update.

  • platform/gtk/Skipped: Skip fast/forms/form-attribute.html, which needs <meter> support.
22:38 Changeset [71998] by mihaip@chromium.org

2010-11-14 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium expectations update.

Add tests that fail under the DRT.

  • platform/chromium/drt_expectations.txt:
22:03 Changeset [71997] by hyatt@apple.com

Back out the italics portion of the previous patch until I can figure out why it
doesn't work.

  • css/CSSFontSelector.cpp:

(WebCore::compareFontFaces):

21:40 Changeset [71996] by tkent@chromium.org

2010-11-14 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

Improve API for form validation message strings
https://bugs.webkit.org/show_bug.cgi?id=34945

This change introduces three new functions;
validationMessageTypeMismatchFor*Text(). The implementation for each
platform is just a call to validationMessageTypeMismatchText().

Some validationMessage*() functions have new parameters. The parameters
are ignored in all platforms for now.

This change doesn't change any behavior. However a platform can add
additional information to validation messages. e.g. Changing "type
mismatch" to "Please specify an e-mail address" for <input type=email>.

  • html/EmailInputType.cpp: (WebCore::EmailInputType::typeMismatchText): Call validationMessageTypeMismatchForEmailText() or validationMessageTypeMismatchForMultipleEmailText().
  • html/EmailInputType.h:
  • html/HTMLFormControlElement.h: Add maxLength() and value() to access them from ValidityState.
  • html/HTMLInputElement.cpp: Add the following functions to pass extra information to validation message string functions. (WebCore::HTMLInputElement::minimumString): (WebCore::HTMLInputElement::maximumString): (WebCore::HTMLInputElement::stepBaseString): (WebCore::HTMLInputElement::stepString): (WebCore::HTMLInputElement::typeMismatchText):
  • html/HTMLInputElement.h:
  • html/HTMLTextAreaElement.h:
  • html/InputType.cpp: (WebCore::InputType::typeMismatchText): Call validationMessageTypeMismatchText().
  • html/InputType.h:
  • html/URLInputType.cpp: (WebCore::URLInputType::typeMismatchText): Call validationMessageTypeMismatchForURLText().
  • html/URLInputType.h:
  • html/ValidityState.cpp: (WebCore::ValidityState::validationMessage):
  • platform/LocalizedStrings.cpp: (WebCore::validationMessageTypeMismatchForEmailText): (WebCore::validationMessageTypeMismatchForMultipleEmailText): (WebCore::validationMessageTypeMismatchForURLText): (WebCore::validationMessageTooLongText): (WebCore::validationMessageRangeUnderflowText): (WebCore::validationMessageRangeOverflowText): (WebCore::validationMessageStepMismatchText):
  • platform/LocalizedStrings.h:
    • Add validationMessageTypeMismatchForEmailText(), validationMessageTypeMismatchForMultipleEmailText() and validationMessageTypeMismatchForURLText()
    • Add length parameters to validationMessageTooLongText().
    • Add the minimum value parameter to validationMessageRangeUnderflowText()
    • Add the maximum value parameter to validationMessageRangeOverflowText()
    • Add parameters of the base value and the step value to validationMessageStepMismatchText()
  • platform/android/LocalizedStringsAndroid.cpp: (WebCore::validationMessageTypeMismatchForEmailText): (WebCore::validationMessageTypeMismatchForMultipleEmailText): (WebCore::validationMessageTypeMismatchForURLText): (WebCore::validationMessageTooLongText): (WebCore::validationMessageRangeUnderflowText): (WebCore::validationMessageRangeOverflowText): (WebCore::validationMessageStepMismatchText):
  • platform/brew/LocalizedStringsBrew.cpp: (WebCore::validationMessageTypeMismatchForEmailText): (WebCore::validationMessageTypeMismatchForMultipleEmailText): (WebCore::validationMessageTypeMismatchForURLText): (WebCore::validationMessageTooLongText): (WebCore::validationMessageRangeUnderflowText): (WebCore::validationMessageRangeOverflowText): (WebCore::validationMessageStepMismatchText):
  • platform/efl/LocalizedStringsEfl.cpp: (WebCore::validationMessageRangeOverflowText): (WebCore::validationMessageRangeUnderflowText): (WebCore::validationMessageStepMismatchText): (WebCore::validationMessageTooLongText): (WebCore::validationMessageTypeMismatchForEmailText): (WebCore::validationMessageTypeMismatchForMultipleEmailText): (WebCore::validationMessageTypeMismatchForURLText):
  • platform/gtk/LocalizedStringsGtk.cpp: (WebCore::validationMessageTypeMismatchForEmailText): (WebCore::validationMessageTypeMismatchForMultipleEmailText): (WebCore::validationMessageTypeMismatchForURLText): (WebCore::validationMessageTooLongText): (WebCore::validationMessageRangeUnderflowText): (WebCore::validationMessageRangeOverflowText): (WebCore::validationMessageStepMismatchText):
  • platform/haiku/LocalizedStringsHaiku.cpp: (WebCore::validationMessageTypeMismatchForEmailText): (WebCore::validationMessageTypeMismatchForMultipleEmailText): (WebCore::validationMessageTypeMismatchForURLText): (WebCore::validationMessageTooLongText): (WebCore::validationMessageRangeUnderflowText): (WebCore::validationMessageRangeOverflowText): (WebCore::validationMessageStepMismatchText):
  • platform/wx/LocalizedStringsWx.cpp: (WebCore::validationMessageTypeMismatchForEmailText): (WebCore::validationMessageTypeMismatchForMultipleEmailText): (WebCore::validationMessageTypeMismatchForURLText): (WebCore::validationMessageTooLongText): (WebCore::validationMessageRangeUnderflowText): (WebCore::validationMessageRangeOverflowText): (WebCore::validationMessageStepMismatchText):

2010-11-14 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

Improve API for form validation message strings
https://bugs.webkit.org/show_bug.cgi?id=34945

  • public/WebLocalizedString.h:
  • src/LocalizedStrings.cpp: (WebCore::validationMessageTypeMismatchForEmailText): (WebCore::validationMessageTypeMismatchForMultipleEmailText): (WebCore::validationMessageTypeMismatchForURLText): (WebCore::validationMessageTooLongText): (WebCore::validationMessageRangeUnderflowText): (WebCore::validationMessageRangeOverflowText): (WebCore::validationMessageStepMismatchText):
21:19 Changeset [71995] by tkent@chromium.org

KeyboardEvent::keyIdentifier() should return "const String&"
https://bugs.webkit.org/show_bug.cgi?id=49426

Reviewed by Andreas Kling.

WebCore:

No new tests. This shouldn't change the current behavior.

  • dom/KeyboardEvent.h:

(WebCore::KeyboardEvent::keyIdentifier): Change the return type; String -> const String&

  • dom/SelectElement.cpp:

(WebCore::SelectElement::menuListDefaultEventHandler):

Change the type of a variable to have keyIdentifier(); String -> const String&

(WebCore::SelectElement::listBoxDefaultEventHandler): ditto.

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::defaultEventHandler): ditto.
(WebCore::HTMLInputElement::handleKeyEventForRange): ditto.

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleKeyboardSelectionMovement): ditto.

WebKit/mac:

  • WebCoreSupport/WebEditorClient.mm:

(selectorForKeyEvent):

Change the type of a variable to have keyIdentifier(); String -> const String&

20:57 Changeset [71994] by commit-queue@webkit.org

2010-11-14 Kenichi Ishibashi <bashi@google.com>

Reviewed by Kent Tamura.

[HTML5] "form" attribute support for form control elements
https://bugs.webkit.org/show_bug.cgi?id=47813

Adds a test file for "form" attribute of form-associated elements.
The test might need to be revised because <label> and <object> don't
support "form" attribute for now, in spite of the HTML5 spec says that
they should support.

  • fast/forms/form-attribute-elements-expected.txt: Added.
  • fast/forms/form-attribute-elements-order-expected.txt: Added.
  • fast/forms/form-attribute-elements-order.html: Added.
  • fast/forms/form-attribute-elements-order2-expected.txt: Added.
  • fast/forms/form-attribute-elements-order2.html: Added.
  • fast/forms/form-attribute-elements.html: Added.
  • fast/forms/form-attribute-expected.txt: Added.
  • fast/forms/form-attribute.html: Added.
  • fast/forms/script-tests/form-attribute-elements-order.js: Added.
  • fast/forms/script-tests/form-attribute-elements-order2.js: Added.
  • fast/forms/script-tests/form-attribute-elements.js: Added.
  • fast/forms/script-tests/form-attribute.js: Added.

2010-11-14 Kenichi Ishibashi <bashi@google.com>

Reviewed by Kent Tamura.

[HTML5] "form" attribute support for form control elements
https://bugs.webkit.org/show_bug.cgi?id=47813

Adds a list of form-associated elements with form attribute into
the Document class to support form attribute.
Adds a function to determine the right place to locate
form-associated elements with form attribute into
m_associatedElements of HTMLFormElement class.

Tests: fast/forms/form-attribute-elements-order.html

fast/forms/form-attribute-elements-order2.html
fast/forms/form-attribute-elements.html
fast/forms/form-attribute.html

  • dom/Document.cpp: (WebCore::Document::registerFormElementWithFormAttribute): Added. (WebCore::Document::unregisterFormElementWithFormAttribute): Added. (WebCore::Document::resetFormElementsOwner): Added.
  • dom/Document.h: Added the list for elements with form attribute.
  • html/HTMLAttributeNames.in: Added form attribute.
  • html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::insertedIntoTree): Modified to handle form attribute. (WebCore::HTMLFormControlElement::removedFromTree): Ditto. (WebCore::HTMLFormControlElement::resetFormOwner): Added. (WebCore::HTMLFormControlElement::attributeChanged): Added.
  • html/HTMLFormControlElement.h:
  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::HTMLFormElement): Modified to initialize newly-added variables. (WebCore::HTMLFormElement::insertedIntoDocument): Modified to reset form owner of form-associated elements. (WebCore::HTMLFormElement::removedFromDocument): Ditto. (WebCore::HTMLFormElement::formElementIndexWithFormAttribute): Added. (WebCore::HTMLFormElement::formElementIndex): Modified to treat form-associated elements with form attribute separately. (WebCore::HTMLFormElement::removeFormElement): Modified to handle form-associated elements with form attribute.
  • html/HTMLFormElement.h: Added three variables to handle form attribute.
  • html/HTMLOutputElement.cpp: Removed "FIXME" comment. (WebCore::HTMLOutputElement::parseMappedAttribute):
  • html/HTMLOutputElement.h: Removed setForm().
20:53 Changeset [71993] by hyatt@apple.com

https://bugs.webkit.org/show_bug.cgi?id=49521

Reviewed by Dan Bernstein.

REGRESSION svg/W3C-SVG-1.1/fonts-desc-02-t.svg broken by r71979.

Refine the font selection function for @font-face to be smarter about what fonts it prefers. If
a font is labeled as only supporting small-caps, then prefer it to one that claims to support both
normal and small-caps. The specialized font is more likely to be true small-caps and to not rely
on synthesis.

Added the same logic for italic as well. Prefer the font that is specifically restricted to
italic to one that claims it can support anything.

  • css/CSSFontSelector.cpp:

(WebCore::compareFontFaces):

19:38 Changeset [71992] by mihaip@chromium.org

2010-11-14 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium expectations update.

Remove two tests that consistently pass on chromium-mac.

  • platform/chromium/test_expectations.txt:
18:14 Changeset [71991] by mihaip@chromium.org

2010-11-14 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium rebaseline and expectations update.

  • platform/chromium-mac/fast/blockflow/vertical-font-fallback-expected.checksum: Added.
  • platform/chromium-mac/fast/blockflow/vertical-font-fallback-expected.png: Added.
  • platform/chromium/test_expectations.txt:
17:56 Changeset [71990] by mihaip@chromium.org

2010-11-14 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium expectations update.

Correct some expectations added by r71988.

  • platform/chromium/test_expectations.txt:
17:17 Changeset [71989] by levin@chromium.org

2010-11-14 David Levin <levin@chromium.org>

Reviewed by Daniel Bates.

check-webkit-style should detect PassRefPtr usage in functions.
https://bugs.webkit.org/show_bug.cgi?id=49513

  • Scripts/webkitpy/style/checkers/cpp.py: (check_for_function_lengths): Revert a comment change that I accidentally made in r71986. (check_pass_ptr_usage): Added the code to do the check. (process_line): Added the call to check_pass_ptr_usage. (CppChecker): Added the new error category.
  • Scripts/webkitpy/style/checkers/cpp_unittest.py: (CppStyleTestBase::perform_pass_ptr_check): Runs the new check for testing purposes. (PassPtrTest::*): The class/functions to unit test the new functionality.
17:15 Changeset [71988] by mihaip@chromium.org

2010-11-14 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium baseline and expectations update.

  • r71969 added a bunch of SVG tests without pixel baselines
  • r71969 also caused svg/W3C-SVG-1.1-SE/types-dom-06-f.svg to need a rebaseline for Linux and Windows (which now match the mac baseline, modulo font rendering)
  • r71970 added two tests that depend on vertical text support (which (doesn't work on Linux or Windows yet)
  • Similarly, r71979 added a test that depends on vertical text support
  • r71979 also caused a regression that should be fixed upstream
  • Add Chromium baselines for fast/repaint/ repaint-across-writing-mode-boundary.html (added by r71980).

Also rebaseline fast/table/colspanMinWidth-vertical.html for Linux and
Windows, to mirror the mac rebaseline done in r71876.

  • platform/chromium-linux/fast/repaint/repaint-across-writing-mode-boundary-expected.checksum: Added.
  • platform/chromium-linux/fast/repaint/repaint-across-writing-mode-boundary-expected.png: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt: Removed.
  • platform/chromium-mac/fast/repaint/repaint-across-writing-mode-boundary-expected.checksum: Added.
  • platform/chromium-mac/fast/repaint/repaint-across-writing-mode-boundary-expected.png: Added.
  • platform/chromium-win/fast/repaint/repaint-across-writing-mode-boundary-expected.checksum: Added.
  • platform/chromium-win/fast/repaint/repaint-across-writing-mode-boundary-expected.png: Added.
  • platform/chromium-win/fast/repaint/repaint-across-writing-mode-boundary-expected.txt: Added.
  • platform/chromium-win/fast/table/colspanMinWidth-vertical-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt:
  • platform/chromium/test_expectations.txt:
13:14 EFLWebKit edited by barbieri@profusion.mobi
document cmake flags we should use for production/development builds (diff)
12:14 Changeset [71987] by commit-queue@webkit.org

2010-11-14 Ryuan Choi <ryuan.choi@samsung.com>

Reviewed by Martin Robinson.

[EFL] add pango support
https://bugs.webkit.org/show_bug.cgi?id=46029

Add FONT_BACKEND option to switch between pango and freetype.

  • cmake/OptionsEfl.cmake:

2010-11-14 Ryuan Choi <ryuan.choi@samsung.com>

Reviewed by Martin Robinson.

[EFL] add pango support
https://bugs.webkit.org/show_bug.cgi?id=46029

Include pango related files.
No new tests; functionality is unchanged.

  • CMakeListsEfl.txt:

2010-11-14 Ryuan Choi <ryuan.choi@samsung.com>

Reviewed by Martin Robinson.

[EFL] add pango support
https://bugs.webkit.org/show_bug.cgi?id=46029

Add pango in include and libs.

  • CMakeListsEfl.txt:
11:59 Changeset [71986] by levin@chromium.org

2010-11-14 David Levin <levin@chromium.org>

Reviewed by Shinichiro Hamaji.

check-webkit-style function detection and the line count style checks should be separate.
https://bugs.webkit.org/show_bug.cgi?id=49512

  • Scripts/webkitpy/style/checkers/cpp.py: Do the separation.
  • Scripts/webkitpy/style/checkers/cpp_unittest.py: Adjust the test to call the detection function and fix line counts in two places now that the code really only counts the lines in the body of the function.
11:39 Changeset [71985] by andreas.kling@nokia.com

2010-11-14 Andreas Kling <kling@webkit.org>

Reviewed by Antonio Gomes.

http/tests/plugins tests print "Unhandled variable" to stderr under Qt
https://bugs.webkit.org/show_bug.cgi?id=33438

Stifle "Unhandled variable" warning to match what the other
TestNetscapePlugin does (NPP_GetValue in TestNetscapePlugIn/main.cpp
simply returns NPERR_GENERIC_ERROR for unhandled variables.)

  • DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: (webkit_test_plugin_get_value):
11:11 Changeset [71984] by andreas.kling@nokia.com

2010-11-12 Tenghui Zhu <ztenghui@google.com>

Reviewed by Andreas Kling.

[V8] Code generation script error in generating the SVGStaticListPropertyTearOff
https://bugs.webkit.org/show_bug.cgi?id=49463

  • bindings/scripts/CodeGeneratorV8.pm: The svgNativeType is the one containing the SVGStaticListPropertyTearOff string, not the svgListPropertyType.
10:43 Changeset [71983] by andreas.kling@nokia.com

2010-11-14 Andreas Kling <kling@webkit.org>

Reviewed by Antonio Gomes.

REGRESSION(r71895): API test javaScriptWindowObjectCleared fails
https://bugs.webkit.org/show_bug.cgi?id=49466

As of r71895 empty inline scripts are no longer executed and so
the javaScriptWindowObjectCleared() signal is no longer triggered
by <script></script>.

  • tests/qwebframe/tst_qwebframe.cpp:
09:18 Changeset [71982] by paroga@webkit.org

2010-11-14 Patrick Gansterer <paroga@webkit.org>

Reviewed by Andreas Kling.

Sort CMakeLists.txt
https://bugs.webkit.org/show_bug.cgi?id=49507

  • CMakeLists.txt:

11/13/10:

23:56 Changeset [71981] by paroga@webkit.org

2010-11-13 Patrick Gansterer <paroga@webkit.org>

Reviewed by Yury Semikhatsky.

Buildfix for !ENABLE(INSPECTOR)
https://bugs.webkit.org/show_bug.cgi?id=49500

Also unify the position of the condition in the cpp files.

  • inspector/ConsoleMessage.cpp:
  • inspector/InspectorResourceAgent.cpp:
  • inspector/InspectorState.cpp:
  • inspector/ScriptCallFrame.cpp:
  • inspector/ScriptCallStack.cpp:
22:14 Changeset [71980] by hyatt@apple.com

https://bugs.webkit.org/show_bug.cgi?id=49506

Reviewed by Anders Carlsson.

Repaint is broken across writing mode boundaries. It's not enough to add in flipped offsets. You have
to flip the rect itself.

WebCore:

Added fast/repaint/repaint-across-writing-mode-boundary.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeRectForRepaint):

LayoutTests:

Added fast/repaint/repaint-across-writing-mode-boundary.html

  • fast/repaint/repaint-across-writing-mode-boundary.html: Added.
  • platform/mac/fast/repaint/repaint-across-writing-mode-boundary-expected.checksum: Added.
  • platform/mac/fast/repaint/repaint-across-writing-mode-boundary-expected.png: Added.
  • platform/mac/fast/repaint/repaint-across-writing-mode-boundary-expected.txt: Added.
21:31 Changeset [71979] by hyatt@apple.com

https://bugs.webkit.org/show_bug.cgi?id=49505

Reviewed by Dan Bernstein.

REGRESSION: @font-face doesn't work with the small-caps variant. This was broken by the addition of SVG fonts
support long ago. This patch fixes the SVG code so that it doesn't break non-SVG fonts.

Added fast/blockflow/broken-ideograph-small-caps.html

WebCore:

  • css/CSSFontFace.cpp:

(WebCore::CSSFontFace::hasSVGFontFaceSource):

  • css/CSSFontFace.h:
  • css/CSSFontFaceSource.cpp:

(WebCore::CSSFontFaceSource::getFontData):

  • css/CSSFontFaceSource.h:
  • css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::addFontFaceRule):
(WebCore::CSSFontSelector::getFontData):

LayoutTests:

  • fast/blockflow/broken-ideograph-small-caps.html: Added.
  • platform/mac/fast/blockflow/broken-ideograph-small-caps-expected.checksum: Added.
  • platform/mac/fast/blockflow/broken-ideograph-small-caps-expected.png: Added.
  • platform/mac/fast/blockflow/broken-ideograph-small-caps-expected.txt: Added.
20:55 Changeset [71978] by levin@chromium.org

2010-11-13 David Levin <levin@chromium.org>

Reviewed by Eric Seidel.

check-webkit-style function detection crashes on functions in templates.
https://bugs.webkit.org/show_bug.cgi?id=49504

For example "template <bool shouldClose(const Element*)>".

  • Scripts/webkitpy/style/checkers/cpp.py: If not function is detected, bail out.
  • Scripts/webkitpy/style/checkers/cpp_unittest.py: Modified the complex function detection test to expose this issue.
20:35 Changeset [71977] by mitz@apple.com

fast/text/hyphen* tests have different results on Leopard
https://bugs.webkit.org/show_bug.cgi?id=43296

Reviewed by Dave Hyatt.

  • platform/text/mac/TextBreakIteratorInternalICUMac.mm:

(WebCore::topLanguagePreference): Changed to look up the value of the AppleLanguages default
through the normal NSUserDefaults search order rather than skipping the application domain.
This makes this function respect DumpRenderTree’s setting of the default in the application
domain.

20:11 Changeset [71976] by levin@chromium.org

check-webkit-style function detection doesn't detect indented functions declaractions.
https://bugs.webkit.org/show_bug.cgi?id=49446

Reviewed by Shinichiro Hamaji.

Indented function declarations occur inside class definitions, so
they are a pretty common (and worth detecting).

  • Scripts/webkitpy/style/checkers/cpp.py: Changed regex to allow indentation. Changed the function start detection to only happen when not in a function. Changed function end detection to work based on matching braces instead of finding a close brace at the beginning of the line. Fixed close_expression to do what it says when it doesn't find the close.
  • Scripts/webkitpy/style/checkers/cpp_unittest.py: Indented function test.
20:04 Changeset [71975] by hyatt@apple.com

https://bugs.webkit.org/show_bug.cgi?id=49499

Reviewed by Dan Bernstein.

broken-ideographic-font.html causes layout test flakiness in release builds. The reason for this is
that the custom font data for m_brokenIdeographFontData was never getting pruned out of the tree.
The same problem exists for custom small caps fonts, so I made sure that the small caps fonts get
pruned as well. In addition, custom small caps fonts were never getting deleted either.

I also made allowsLigatures in FontPlatformData orientation-independent, and the callers check it
instead.

Unskip fast/blockflow/broken-ideographic-font.html

  • platform/graphics/SimpleFontData.cpp:

(WebCore::SimpleFontData::~SimpleFontData):

  • platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:

(WebCore::SimpleFontData::platformDestroy):
(WebCore::SimpleFontData::smallCapsFontData):

  • platform/graphics/chromium/SimpleFontDataLinux.cpp:

(WebCore::SimpleFontData::platformDestroy):
(WebCore::SimpleFontData::smallCapsFontData):

  • platform/graphics/cocoa/FontPlatformDataCocoa.mm:

(WebCore::FontPlatformData::allowsLigatures):

  • platform/graphics/freetype/SimpleFontDataFreeType.cpp:

(WebCore::SimpleFontData::platformDestroy):
(WebCore::SimpleFontData::smallCapsFontData):

  • platform/graphics/haiku/SimpleFontDataHaiku.cpp:

(WebCore::SimpleFontData::platformDestroy):
(WebCore::SimpleFontData::smallCapsFontData):

  • platform/graphics/mac/ComplexTextControllerATSUI.cpp:

(WebCore::disableLigatures):

  • platform/graphics/mac/SimpleFontDataCoreText.cpp:

(WebCore::SimpleFontData::getCFStringAttributes):

  • platform/graphics/mac/SimpleFontDataMac.mm:

(WebCore::SimpleFontData::platformDestroy):

  • platform/graphics/win/SimpleFontDataWin.cpp:

(WebCore::SimpleFontData::platformDestroy):
(WebCore::SimpleFontData::smallCapsFontData):

  • platform/graphics/wx/SimpleFontDataWx.cpp:

(WebCore::SimpleFontData::platformDestroy):
(WebCore::SimpleFontData::smallCapsFontData):

14:48 Changeset [71974] by hyatt@apple.com

Skip the broken ideograph test until I can figure out why it corrupts release builds.

12:46 Changeset [71973] by hyatt@apple.com

Another attempt to fix layout tests.

12:00 Changeset [71972] by hyatt@apple.com

https://bugs.webkit.org/show_bug.cgi?id=49496

Fix broken-ideographic-font.html. I had the font installed locally on my machine, and this covered up
the fact that CoreText was implicitly using it as fallback in the vertical case only. The bots don't have
the font installed locally, and so they showed the bug.

Make sure the GlyphPage is filled with horizontal glyphs for a broken ideograph font, so that CoreText is
willing to fill.

  • platform/graphics/mac/SimpleFontDataCoreText.cpp:

(WebCore::SimpleFontData::getCFStringAttributes):

11:29 Changeset [71971] by rwlbuis@webkit.org

2010-11-13 Rob Buis <rwlbuis@gmail.com>

Unreviewed test expectation rebaseline.

  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt:
10:45 Changeset [71970] by hyatt@apple.com

https://bugs.webkit.org/show_bug.cgi?id=49464

Reviewed by Dan Bernstein.

Fix bugs with the orientation of fonts when the font is brought in via fallback, when the font contains no
vertical tables, or when the font is loaded via font-face in both horizontal and vertical forms.

(1) Include orientation as part of the @font-face hashtables so that the fonts are treated as
distinct when used in horizontal and vertical forms.

(2) Let the orientation member of FontPlatformData represent the desired orientation rather than
the supported one. Add an orientation member to SimpleFontData that represents the actual
supported orientation of the font.

(3) For fonts with no vertical tables, add a brokenIdeographicsFont accessor that is invoked when
CJK ideographs are encountered. This is essentially identical to the small caps fallback mechanism
but invoked only for ideographs. The special ideograph font locks the orientation to vertical and
renders the glyphs upright even when the font has no vertical tables. Punctuation and such will
still look funny, and really this is a bug in the font, but at least this way it will be apparent
that the font is to blame.

Added fast/blockflow/broken-ideographic-font.html and fast/blockflow/vertical-font-fallback.html.

WebCore:

  • css/CSSFontFaceSource.cpp:

(WebCore::CSSFontFaceSource::getFontData):

  • css/CSSSegmentedFontFace.cpp:

(WebCore::CSSSegmentedFontFace::getFontData):

  • platform/graphics/Font.cpp:

(WebCore::Font::isCJKIdeograph):

  • platform/graphics/Font.h:
  • platform/graphics/FontFastPath.cpp:

(WebCore::Font::glyphDataForCharacter):

  • platform/graphics/SimpleFontData.cpp:

(WebCore::SimpleFontData::SimpleFontData):
(WebCore::SimpleFontData::~SimpleFontData):
(WebCore::SimpleFontData::brokenIdeographFontData):

  • platform/graphics/SimpleFontData.h:

(WebCore::SimpleFontData::orientation):

  • platform/graphics/cocoa/FontPlatformDataCocoa.mm:

(WebCore::FontPlatformData::FontPlatformData):

  • platform/graphics/mac/FontMac.mm:

(WebCore::showGlyphsWithAdvances):

  • platform/graphics/mac/SimpleFontDataMac.mm:

(WebCore::SimpleFontData::platformInit):
(WebCore::SimpleFontData::platformBoundsForGlyph):
(WebCore::SimpleFontData::platformWidthForGlyph):

LayoutTests:

  • fast/blockflow/broken-ideographic-font.html: Added.
  • fast/blockflow/resources/MakibaFont13.ttf: Added.
  • fast/blockflow/vertical-font-fallback.html: Added.
  • platform/mac/fast/blockflow/broken-ideographic-font-expected.checksum: Added.
  • platform/mac/fast/blockflow/broken-ideographic-font-expected.png: Added.
  • platform/mac/fast/blockflow/broken-ideographic-font-expected.txt: Added.
  • platform/mac/fast/blockflow/vertical-font-fallback-expected.checksum: Added.
  • platform/mac/fast/blockflow/vertical-font-fallback-expected.png: Added.
  • platform/mac/fast/blockflow/vertical-font-fallback-expected.txt: Added.
09:16 Changeset [71969] by rwlbuis@webkit.org

2010-11-13 Rob Buis <rwlbuis@gmail.com>

Reviewed by Dirk Schulze.

requiredFeatures does not adapt to SVGStringList changes
https://bugs.webkit.org/show_bug.cgi?id=40887

Centralize logic of handling of SVGElement validity changes.
The logic is to detach the SVGElement when changing from valid
to invalid, and to attach when changing from invalid to valid.

Tests: svg/dynamic-updates/SVGCircleElement-dom-requiredFeatures.html

svg/dynamic-updates/SVGCircleElement-svgdom-requiredFeatures.html
svg/dynamic-updates/SVGEllipseElement-dom-requiredFeatures.html
svg/dynamic-updates/SVGEllipseElement-svgdom-requiredFeatures.html
svg/dynamic-updates/SVGForeignObjectElement-dom-requiredFeatures.html
svg/dynamic-updates/SVGForeignObjectElement-svgdom-requiredFeatures.html
svg/dynamic-updates/SVGGElement-dom-requiredFeatures.html
svg/dynamic-updates/SVGGElement-svgdom-requiredFeatures.html
svg/dynamic-updates/SVGImageElement-dom-requiredFeatures.html
svg/dynamic-updates/SVGImageElement-svgdom-requiredFeatures.html
svg/dynamic-updates/SVGLineElement-dom-requiredFeatures.html
svg/dynamic-updates/SVGLineElement-svgdom-requiredFeatures.html
svg/dynamic-updates/SVGPathElement-dom-requiredFeatures.html
svg/dynamic-updates/SVGPathElement-svgdom-requiredFeatures.html
svg/dynamic-updates/SVGPolygonElement-dom-requiredFeatures.html
svg/dynamic-updates/SVGPolygonElement-svgdom-requiredFeatures.html
svg/dynamic-updates/SVGPolylineElement-dom-requiredFeatures.html
svg/dynamic-updates/SVGPolylineElement-svgdom-requiredFeatures.html
svg/dynamic-updates/SVGRectElement-dom-requiredFeatures.html
svg/dynamic-updates/SVGRectElement-svgdom-requiredFeatures.html
svg/dynamic-updates/SVGSVGElement-dom-requiredFeatures.html
svg/dynamic-updates/SVGSVGElement-svgdom-requiredFeatures.html
svg/dynamic-updates/SVGTextElement-dom-requiredFeatures.html
svg/dynamic-updates/SVGTextElement-svgdom-requiredFeatures.html
svg/dynamic-updates/SVGUseElement-dom-requiredFeatures.html
svg/dynamic-updates/SVGUseElement-svgdom-requiredFeatures.html

08:39 Changeset [71968] by paroga@webkit.org

2010-11-13 Patrick Gansterer <paroga@webkit.org>

Unreviewed, build fix after r71541.

  • WebCoreSupport/ChromeClientWinCE.h:
08:32 Changeset [71967] by caseq@chromium.org

2010-11-13 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [refactoring] support Views in TabbedPane and streamline tab selection in resource view
https://bugs.webkit.org/show_bug.cgi?id=49493

  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype._showResource):
  • inspector/front-end/ResourceView.js: (WebInspector.ResourceView): (WebInspector.ResourceView.prototype.selectContentTab): (WebInspector.ResourceView.prototype._selectTab): (WebInspector.ResourceView.prototype._refreshCookies): (WebInspector.ResourceCookiesTab.prototype.show):
  • inspector/front-end/StoragePanel.js: (WebInspector.StoragePanel.prototype.showResource):
  • inspector/front-end/TabbedPane.js: (WebInspector.TabbedPane.prototype.appendTab): (WebInspector.TabbedPane.prototype.hasTab): (WebInspector.TabbedPane.prototype.selectTabById): (WebInspector.TabbedPane.prototype._hideTab): (WebInspector.TabbedPane.prototype._showTab):
  • inspector/front-end/inspector.css: (.resource-view-cookies): (.resource-view-cookies.visible):
06:50 Changeset [71966] by yurys@chromium.org

2010-11-13 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

REGRESSION(71515): Web Inspector: Safari crash calling console.log when Log JavaScript Exceptions to Console is checked
https://bugs.webkit.org/show_bug.cgi?id=49362

  • page/Console.cpp: (WebCore::Console::addMessage): avoid accessing ScriptArguments and ScriptCallStack after their ownership has been passed to the inspector.
03:04 Changeset [71965] by yurys@chromium.org

2010-11-13 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: DOM event listener name is cropped in Elements panel
https://bugs.webkit.org/show_bug.cgi?id=49387

  • inspector/front-end/inspector.css: (.event-bar): use margin-left instead of left to fit child node into its parent
03:02 Changeset [71964] by hamaji@chromium.org

2010-11-13 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Kent Tamura.

[Chromium] print doesn't work on http://nodejs.org/api.html
https://bugs.webkit.org/show_bug.cgi?id=49304

  • platform/chromium/test_expectations.txt:

2010-11-13 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Kent Tamura.

[Chromium] print doesn't work on http://nodejs.org/api.html
https://bugs.webkit.org/show_bug.cgi?id=49304

  • src/WebFrameImpl.cpp: (WebKit::ChromePrintContext::begin): (WebKit::WebFrameImpl::printBegin):
01:47 Changeset [71963] by commit-queue@webkit.org

2010-11-13 Ilya Sherman <isherman@chromium.org>

Reviewed by Shinichiro Hamaji.

Fixes regression from previous patch -- computes y offsets for elements
that are scrolled out of the window.
https://bugs.webkit.org/show_bug.cgi?id=49306

  • manual-tests/select-scroll.html: Added.
  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupListBox::layout):

11/12/10:

22:46 Changeset [71962] by dbates@webkit.org

2010-11-12 Daniel Bates <dbates@rim.com>

Reviewed by Adam Barth.

Transferred <iframe>s may not have a unique internal name
https://bugs.webkit.org/show_bug.cgi?id=48768

Fixes an issue where an <iframe> that is transferred from
document A to document B, where A != B, may not have a
unique internal name in B.

Test: fast/frames/iframe-reparenting-unique-name.html

  • html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::setNameAndOpenURL): Inlined code from HTMLFrameElementBase::setName() so that we can remove setName(), which was only called being called by HTMLFrameElementBase::setNameAndOpenURL().
  • html/HTMLFrameElementBase.h: Removed HTMLFrameElementBase::setName().
  • html/HTMLFrameOwnerElement.h: Removed HTMLFrameOwnerElement::setName().
  • page/Frame.cpp: (WebCore::Frame::transferChildFrameToNewDocument): Modified to call FrameTree::transferChild().
  • page/FrameTree.cpp: (WebCore::FrameTree::transferChild): Added. (WebCore::FrameTree::appendChild): Moved the majority of the code into FrameTree::actuallyAppendChild(). (WebCore::FrameTree::actuallyAppendChild): Added.
  • page/FrameTree.h:

2010-11-12 Daniel Bates <dbates@rim.com>

Reviewed by Adam Barth.

Transferred <iframe>s may not have a unique internal name
https://bugs.webkit.org/show_bug.cgi?id=48768

Tests that an <iframe> which is transferred from document A to
document B, where A != B, has a unique name in B.

  • fast/frames/iframe-reparenting-unique-name-expected.txt: Added.
  • fast/frames/iframe-reparenting-unique-name.html: Added.
22:28 Changeset [71961] by dbates@webkit.org

2010-11-12 Daniel Bates <dbates@rim.com>

Rubber-stamped by Nikolas Zimmermann.

Make do-file-rename rename files in the directory WebKit2.

This also makes the list of searched directories in do-file-rename
consistent with the list of searched directories in the script do-webcore-rename.

  • Scripts/do-file-rename:
18:00 Changeset [71960] by dpranke@chromium.org

2010-11-12 Dirk Pranke <dpranke@chromium.org>

Reviewed by James Robinson.

Attempt yet again to land the fix for bug 49360 (respecting
set-webkit-configuration). We need to handle the cases where
trying to run webkit-build-directory to find out where the
default configuration might be fails (that shows up on some
Chromium bots that apparently don't have perl installed).

https://bugs.webkit.org/show_bug.cgi?id=49360

  • Scripts/webkitpy/layout_tests/port/config.py:
  • Scripts/webkitpy/layout_tests/port/config_standalone.py: Added.
  • Scripts/webkitpy/layout_tests/port/config_unittest.py:
17:39 Changeset [71959] by joepeck@webkit.org

2010-11-12 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by Alexey Proskuryakov.

Some FrameLoader.h Cleanup
https://bugs.webkit.org/show_bug.cgi?id=49484

Removed function signatures without any implementation. The functions
used to exist, and were nicely refactored into PageCache in r60688 and
the signatures were left behind.

Removed function signature setLoadType. Added in r17238 back when the
file was named WebFrameLoader, and the implementation was lost during
the transition from its mm implementation.

Removed function signature updateHistoryAfterClientRedirect. Implementation
and call points were removed in r18541 but the signature was left behind,
and jumped files!

Removed unused debug variable m_didDispatchDidCommitLoad. It was added
and used in Assertions in r28399. It was removed soon after, in r28464
because they were, "firing like crazy. Not sure why yet." It was
never used again.

Added const qualifier and moved interruptionForPolicyChangeError to
be more like its buddies.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::FrameLoader): (WebCore::FrameLoader::checkLoadCompleteForThisFrame): (WebCore::FrameLoader::interruptionForPolicyChangeError): (WebCore::FrameLoader::dispatchDidCommitLoad):
  • loader/FrameLoader.h:
17:17 Changeset [71958] by mihaip@chromium.org

2010-11-12 Mihai Parparita <mihaip@chromium.org>

Reviewed by Adam Barth.

webkit-patch land logs commit message twice
https://bugs.webkit.org/show_bug.cgi?id=49482

Don't log the comment that's used by bugzilla.close_bug_as_fixed, since
that's just the commit message, which we now output following the
actual commit.

  • Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
16:57 Changeset [71957] by tony@chromium.org

2010-11-12 Tony Chang <tony@chromium.org>

Unreviewed, revert changes to script-object-invoke that crash
single process chromium.

  • plugins/script-object-invoke.html:
16:47 Changeset [71956] by yael.aharon@nokia.com

2010-11-12 Yael Aharon <yael.aharon@nokia.com>

Reviewed by David Hyatt.

Spatial Navigation: Cannot focus on some ContainerNode
https://bugs.webkit.org/show_bug.cgi?id=48393

  • fast/events/spatial-navigation/snav-container-only-white-space-expected.txt: Added.
  • fast/events/spatial-navigation/snav-container-only-white-space.html: Added.
  • fast/events/spatial-navigation/snav-container-white-space-expected.txt: Added.
  • fast/events/spatial-navigation/snav-container-white-space.html: Added.

2010-11-12 Yael Aharon <yael.aharon@nokia.com>

Reviewed by David Hyatt.

Spatial Navigation: Cannot focus on some ContainerNode
https://bugs.webkit.org/show_bug.cgi?id=48393

ContainerNode::getLowerRightCorner() assumes that the lowest right corner of its last child
is its own lowest right corner. If that child is an empty text node after an image, it does
not have size and position information, so we should go to the previous child.

Tests: fast/events/spatial-navigation/snav-container-only-white-space.html

fast/events/spatial-navigation/snav-container-white-space.html

  • dom/ContainerNode.cpp: (WebCore::ContainerNode::getLowerRightCorner):
16:34 Changeset [71955] by tony@chromium.org

2010-11-12 Tony Chang <tony@chromium.org>

Reviewed by Adam Barth.

run platform/chromium/plugins/script-object-invoke.html on all platforms
https://bugs.webkit.org/show_bug.cgi?id=49280

  • platform/chromium/drt_expectations.txt:
  • plugins/script-object-invoke-expected.txt: Renamed from LayoutTests/platform/chromium/plugins/script-object-invoke-expected.txt.
  • plugins/script-object-invoke.html: Renamed from LayoutTests/platform/chromium/plugins/script-object-invoke.html.

2010-11-12 Tony Chang <tony@chromium.org>

Reviewed by Adam Barth.

run platform/chromium/plugins/script-object-invoke.html on all platforms
https://bugs.webkit.org/show_bug.cgi?id=49280

  • DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp: (testScriptObjectInvoke): (pluginInvoke):
15:54 Changeset [71954] by mihaip@chromium.org

2010-11-12 Mihai Parparita <mihaip@chromium.org>

Reviewed by Adam Barth.

webkit-patch land-cowboy (and other commands) should display the committed SVN revision after landing a patch
https://bugs.webkit.org/show_bug.cgi?id=49471

Right now there's no indication of a successful commit.

  • Scripts/webkitpy/tool/commands/download_unittest.py:
  • Scripts/webkitpy/tool/steps/commit.py:
15:43 Changeset [71953] by mihaip@chromium.org

2010-11-12 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium expectations update.

fast/canvas/canvas-arc-360-winding.html needs to be skipped for the
GPU suite too.

  • platform/chromium-gpu/test_expectations.txt:
15:14 Changeset [71952] by kinuko@chromium.org

2010-11-12 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by Ojan Vafai.

Include detailed test modifiers in results.json and enable incremental uploading for non-layout tests
https://bugs.webkit.org/show_bug.cgi?id=49354

Also moved/integrated the upload method from run_webkit_tests.py to json_results_generator.py.

  • Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
14:51 Changeset [71951] by commit-queue@webkit.org

2010-11-12 James Simonsen <simonjam@chromium.org>

Reviewed by Darin Fisher.

[Web Timing] Rename interfaces:

  • fast/dom/Window/window-properties-performance-expected.txt: Class names changed.

2010-11-12 James Simonsen <simonjam@chromium.org>

Reviewed by Darin Fisher.

[Web Timing] Rename interfaces:

  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • page/Performance.cpp: (WebCore::Performance::navigation): (WebCore::Performance::timing):
  • page/Performance.h:
  • page/Performance.idl:
  • page/PerformanceNavigation.cpp: Renamed from WebCore/page/Navigation.cpp. (WebCore::PerformanceNavigation::PerformanceNavigation): (WebCore::PerformanceNavigation::frame): (WebCore::PerformanceNavigation::disconnectFrame): (WebCore::PerformanceNavigation::type): (WebCore::PerformanceNavigation::redirectCount):
  • page/PerformanceNavigation.h: Renamed from WebCore/page/Navigation.h. (WebCore::PerformanceNavigation::create):
  • page/PerformanceNavigation.idl: Renamed from WebCore/page/Navigation.idl.
  • page/PerformanceTiming.cpp: Renamed from WebCore/page/Timing.cpp. (WebCore::toIntegerMilliseconds): (WebCore::getPossiblySkewedTimeInKnownRange): (WebCore::PerformanceTiming::PerformanceTiming): (WebCore::PerformanceTiming::frame): (WebCore::PerformanceTiming::disconnectFrame): (WebCore::PerformanceTiming::navigationStart): (WebCore::PerformanceTiming::unloadEventEnd): (WebCore::PerformanceTiming::redirectStart): (WebCore::PerformanceTiming::redirectEnd): (WebCore::PerformanceTiming::fetchStart): (WebCore::PerformanceTiming::domainLookupStart): (WebCore::PerformanceTiming::domainLookupEnd): (WebCore::PerformanceTiming::connectStart): (WebCore::PerformanceTiming::connectEnd): (WebCore::PerformanceTiming::requestStart): (WebCore::PerformanceTiming::requestEnd): (WebCore::PerformanceTiming::responseStart): (WebCore::PerformanceTiming::responseEnd): (WebCore::PerformanceTiming::domLoading): (WebCore::PerformanceTiming::domInteractive): (WebCore::PerformanceTiming::domContentLoaded): (WebCore::PerformanceTiming::domComplete): (WebCore::PerformanceTiming::loadEventStart): (WebCore::PerformanceTiming::loadEventEnd): (WebCore::PerformanceTiming::documentLoader): (WebCore::PerformanceTiming::documentTiming): (WebCore::PerformanceTiming::documentLoadTiming): (WebCore::PerformanceTiming::resourceLoadTiming): (WebCore::PerformanceTiming::resourceLoadTimeRelativeToAbsolute):
  • page/PerformanceTiming.h: Renamed from WebCore/page/Timing.h. (WebCore::PerformanceTiming::create):
  • page/PerformanceTiming.idl: Renamed from WebCore/page/Timing.idl.

2010-11-12 James Simonsen <simonjam@chromium.org>

Reviewed by Darin Fisher.

[Web Timing] Rename interfaces:

  • src/WebPerformance.cpp: (WebKit::WebPerformance::navigationType):
14:40 Changeset [71950] by eric.carlson@apple.com

2010-11-12 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser.

Remove unused code from HTMLMediaElement
https://bugs.webkit.org/show_bug.cgi?id=49451

Just removing code, so no new tests.

  • html/HTMLMediaElement.cpp: Removed unused functions.
  • html/HTMLMediaElement.h:
14:00 Changeset [71949] by rniwa@webkit.org

2010-11-12 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed XCode project fix.

  • WebCore.xcodeproj/project.pbxproj:
13:59 Changeset [71948] by mihaip@chromium.org

2010-11-12 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium expectations update.

Mark fast/canvas/canvas-arc-360-winding.html as failing on Linux and
Windows.

  • platform/chromium/test_expectations.txt:
13:56 Changeset [71947] by ap@apple.com

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=49473

No change in behavior, so no tests.

  • css/WebKitCSSMatrix.cpp: (WebCore::WebKitCSSMatrix::WebKitCSSMatrix): We don't inherit from StyleBase any more, so no need to initialize always-null parent. (WebCore::WebKitCSSMatrix::setMatrixValue): Since there was never a parent, useStrictParsing() just returned true.
  • css/WebKitCSSMatrix.h: Just inherit from RefCounted<WebKitCSSMatrix>. Removed unused default constructor and copy constructor.
  • html/canvas/WebGLRenderingContext.h: Removed an unnneded forward declaration.
13:56 Changeset [71946] by jschuh@chromium.org

Merge 71918 - 2010-11-12 Justin Schuh <jschuh@chromium.org>

Reviewed by Adam Barth.

Use a RefPtr inside ContainerNode::willRemove loop
https://bugs.webkit.org/show_bug.cgi?id=49237

Test: fast/innerHTML/innerHTML-iframe.html

  • dom/ContainerNode.cpp: (WebCore::ContainerNode::willRemove):

2010-11-12 Justin Schuh <jschuh@chromium.org>

Reviewed by Adam Barth.

Use a RefPtr inside ContainerNode::willRemove loop
https://bugs.webkit.org/show_bug.cgi?id=49237

  • fast/innerHTML/innerHTML-iframe-expected.txt: Added.
  • fast/innerHTML/innerHTML-iframe.html: Added.

TBR=jschuh@chromium.org
BUG=62261

13:53 Changeset [71945] by jamesr@google.com

Merge 71345 - 2010-11-04 Eric Seidel <eric@webkit.org>

Reviewed by Gavin Barraclough.

REGRESSION(49798): Crash in HTMLObjectElement::parseMappedAttribute
https://bugs.webkit.org/show_bug.cgi?id=48789

The contract for all String/AtomicString methods seems to be that it's
safe to call them, even when the String is null (impl() returns 0).
This contract was broken by r49798 (unintentionally) when optimizing
for dromeo.
This patch adds a null check to AtomicString::lower() fixing this
crash and preventing future confusion.

  • wtf/text/AtomicString.cpp: (WTF::AtomicString::lower):

2010-11-04 Eric Seidel <eric@webkit.org>

Reviewed by Gavin Barraclough.

REGRESSION(49798): Crash in HTMLObjectElement::parseMappedAttribute
https://bugs.webkit.org/show_bug.cgi?id=48789

  • fast/dom/HTMLObjectElement/set-type-to-null-crash-expected.txt: Added.
  • fast/dom/HTMLObjectElement/set-type-to-null-crash.html: Added.

TBR=eric@webkit.org
BUG=55345

13:51 Changeset [71944] by commit-queue@webkit.org

2010-11-12 Jacob Dinu <dinu.jacob@nokia.com>

Reviewed by Andreas Kling.

[Qt] Update .def file for Symbian
https://bugs.webkit.org/show_bug.cgi?id=49456

Added missing symbols from revisions r69825, r70470, r71806

  • symbian/eabi/QtWebKitu.def:
13:47 Changeset [71943] by dglazkov@chromium.org

2010-11-12 Dimitri Glazkov <dglazkov@chromium.org>

Because of r71945, events from shadow DOM elements now bubble correctly
unless handled, which trips over the old issue in GTK.
https://bugs.webkit.org/show_bug.cgi?id=40601

  • platform/gtk/Skipped: Added media/controls-right-click-on-timebar.html.
13:34 Changeset [71942] by zmo@google.com

2010-11-12 Zhenyao Mo <zmo@google.com>

Reviewed by James Robinson.

WebGraphicsContext3DDefaultImpl does not run on top of OpenGL ES 2.0 implementations
https://bugs.webkit.org/show_bug.cgi?id=48282

Simple fix for a regression introduced in r71793.

  • src/WebGraphicsContext3DDefaultImpl.cpp: (WebKit::WebGraphicsContext3DDefaultImpl::initialize):
13:26 Changeset [71941] by jamesr@google.com

Merge 70840 - 2010-10-28 James Robinson <jamesr@chromium.org>

Reviewed by Simon Fraser.

iframes forced into slow scrolling mode by containing RenderLayer sometimes
https://bugs.webkit.org/show_bug.cgi?id=48570

Adds a test that verifies that the repaint region for a scrolled iframe is not
larger than necessary.

  • fast/repaint/iframe-scroll-repaint.html: Added.
  • fast/repaint/resources/iframe-scroll-repaint-iframe.html: Added.
  • platform/mac/fast/repaint/iframe-scroll-repaint-expected.checksum: Added.
  • platform/mac/fast/repaint/iframe-scroll-repaint-expected.png: Added.
  • platform/mac/fast/repaint/iframe-scroll-repaint-expected.txt: Added.

2010-10-28 James Robinson <jamesr@chromium.org>

Reviewed by Simon Fraser.

iframes forced into slow scrolling mode by containing RenderLayer sometimes
https://bugs.webkit.org/show_bug.cgi?id=48570

Only performs the overlap test for RenderLayers that paint themselves. This
prevents marking RenderWidgets as being overlapped unnecessarily.

Test: fast/repaint/iframe-scroll-repaint.html

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintLayer):

TBR=commit-queue@webkit.org

13:25 Changeset [71940] by mihaip@chromium.org

2010-11-12 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium expectations update.

Fix typo.

  • platform/chromium/test_expectations.txt:
13:07 Changeset [71939] by mihaip@chromium.org

2010-11-12 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium expectations update.

Mark some more tests as flaky.

  • platform/chromium/test_expectations.txt:
13:07 Changeset [71938] by benjamin.poulain@nokia.com

[Qt] Need to implement WebKit::pluginWillHandleLoadError for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=48764

WebKit/qt:

Reviewed by Andreas Kling.

Add the missing error.

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::pluginWillHandleLoadError):

WebKit2:

Reviewed by NOBODY (OOPS!).

Add the missing error to Qt support.

  • WebProcess/WebCoreSupport/qt/WebErrorsQt.cpp:

(WebKit::pluginWillHandleLoadError):

12:28 Changeset [71937] by sullivan@apple.com

Fixed Target for WKBundlePageOverlay.cpp.

Reviewed by Anders Carlsson.

  • WebKit2.xcodeproj/project.pbxproj:

Changed Target for WKBundlePageOverlay.cpp from WebProcess to WebKit2.

12:23 Changeset [71936] by commit-queue@webkit.org

2010-11-12 Helder Correia <helder@sencha.com>

Reviewed by Andreas Kling.

[Qt] Path::addArc() does not set right angle direction on full arcs
https://bugs.webkit.org/show_bug.cgi?id=49138

New test for nonzero winding rule correctness for full arc paths.

  • fast/canvas/canvas-arc-360-winding-expected.txt: Added.
  • fast/canvas/canvas-arc-360-winding.html: Added.
  • fast/canvas/script-tests/canvas-arc-360-winding.js: Added.

2010-11-12 Helder Correia <helder@sencha.com>

Reviewed by Andreas Kling.

[Qt] Path::addArc() does not set right angle direction on full arcs
https://bugs.webkit.org/show_bug.cgi?id=49138

Ensure correctness of nonzero winding rule for full arc paths.
Invert the sign of the span if the direction is counterclockwise.

Test: fast/canvas/canvas-arc-360-winding.html

  • platform/graphics/qt/PathQt.cpp: (WebCore::Path::addArc):
12:14 Changeset [71935] by andersca@apple.com

Need a way that WKBundlePageOverlayRef clients can make sure they only uninstall the overlay they installed
https://bugs.webkit.org/show_bug.cgi?id=49461
<rdar://problem/8662760>

Reviewed by John Sullivan.

  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageUninstallPageOverlay):

  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/WebPage/FindController.cpp:

(WebKit::FindController::findString):
(WebKit::FindController::hideFindUI):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::uninstallPageOverlay):

  • WebProcess/WebPage/WebPage.h:
11:49 Changeset [71934] by dglazkov@chromium.org

2010-11-05 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Darin Adler.

Implement shadow DOM-aware event targeting and introduce EventContext to track the context of each event dispatch.
https://bugs.webkit.org/show_bug.cgi?id=46015

Added more test coverage around events crossing shadow DOM boundaries and tweaked existing tests.

  • fast/events/shadow-boundary-crossing-2-expected.txt: Added.
  • fast/events/shadow-boundary-crossing-2.html: Added.
  • fast/events/shadow-boundary-crossing.html: Tuned to better reflect its point:

the event should indeed fire (it used to be swallowed), but its target
should be a non-shadow node.

  • media/audio-delete-while-slider-thumb-clicked.html : Tweaked to actually click on

the scrubber thumb (it was off by 2 pixels).

2010-11-05 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Darin Adler.

Implement shadow DOM-aware event targeting and introduce EventContext to track the context of each event dispatch.
https://bugs.webkit.org/show_bug.cgi?id=46015

Test: fast/events/shadow-boundary-crossing-2.html

This patch adds the notion of EventContext (and a very similar-acting WindowEventContext, specifically
for DOMWindow), an abstraction that carries information around dispatching an event for any given Node.

This abstraction is necessary to ensure that events, fired from shadow DOM nodes are properly retargeted to
appear as if they are coming from their host, thus never exposing the shadow DOM nodes to the world outside.

  • Android.mk: Added EventContext, WindowEventContext files.
  • CMakeLists.txt: Ditto.
  • GNUmakefile.am: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • dom/ContainerNode.cpp: (WebCore::notifyChildInserted): Changed to be shadow DOM-aware.
  • dom/EventContext.cpp: Added.
  • dom/EventContext.h: Added.
  • dom/Node.cpp: (WebCore::Node::markAncestorsWithChildNeedsStyleRecalc): Changed to be shadow DOM-aware. (WebCore::Node::createRendererIfNeeded): Ditto. (WebCore::Node::parentOrHostNode): Added new helper method. (WebCore::Node::enclosingLinkEventParentOrSelf): Changed to be shadow DOM-aware. (WebCore::eventTargetRespectingSVGTargetRules): Collapsed two helper methods into one. (WebCore::Node::getEventAncestors): Renamed and refactored to collect a vector of EventContexts. (WebCore::Node::topEventContext): Added. (WebCore::eventHasListeners): Changed to use EventContexts. (WebCore::Node::dispatchGenericEvent): Ditto.
  • dom/Node.h: Removed eventParentNode that's no longer needed, added parentOrHostNode decl,

and changed signature of eventAncestors to use EventContexts.

  • dom/Text.cpp: (WebCore::Text::createRenderer): Changed to be shadow DOM-aware.
  • dom/WindowEventContext.cpp: Added.
  • dom/WindowEventContext.h: Added.
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::getEventListenersForNode): Changed to use EventContexts.
  • page/EventHandler.cpp: (WebCore::EventHandler::updateMouseEventTargetNode): Removed code that's no longer necessary.
  • rendering/RenderTextControlMultiLine.cpp: (WebCore::RenderTextControlMultiLine::subtreeHasChanged): Removed event invocation that's

no longer necessary.

  • rendering/ShadowElement.h: Made m_shadowParent a RefPtr to avoid stale references when parent is deleted.
  • rendering/TextControlInnerElements.cpp: (WebCore::TextControlInnerTextElement::defaultEventHandler): Flipped the condition back

from where it was prior to r60418.

  • svg/SVGElement.cpp: Removed eventParentNode that's no longer needed.
  • svg/SVGElement.h: Ditto.
11:37 Changeset [71933] by commit-queue@webkit.org

2010-11-12 Ryuan Choi <ryuan.choi@samsung.com>

Reviewed by Martin Robinson.

[GTK] Remove unnecessary header for FontPlatformDataPango.cpp
https://bugs.webkit.org/show_bug.cgi?id=46029

Remove unnecessary header includes.
No new tests, as there's no functionality.

  • platform/graphics/pango/FontPlatformDataPango.cpp:
11:10 Changeset [71932] by andersca@apple.com

Allow MessageSender to override sendMessage
https://bugs.webkit.org/show_bug.cgi?id=49457

Reviewed by Sam Weinig.

Change MessageSender::send to encode the message and then call sendMessage.
This allows for clients to override sendMessage, something which WebProcessProxy
will be able to take advantage of.

  • Platform/CoreIPC/MessageSender.h:

(CoreIPC::MessageSender::send):
(CoreIPC::MessageSender::sendMessage):

10:52 Changeset [71931] by andersca@apple.com

CoreIPC cleanup
https://bugs.webkit.org/show_bug.cgi?id=49455

Reviewed by Sam Weinig.

Add a static create function to ArgumentEncoder.
Factor sync message argument encoder creation out into a new function,
createSyncMessageArgumentEncoder.

  • Platform/CoreIPC/ArgumentEncoder.cpp:

(CoreIPC::ArgumentEncoder::create):

  • Platform/CoreIPC/ArgumentEncoder.h:
  • Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::createSyncMessageArgumentEncoder):
(CoreIPC::Connection::dispatchSyncMessage):

  • Platform/CoreIPC/Connection.h:

(CoreIPC::Connection::send):
(CoreIPC::Connection::sendSync):

  • UIProcess/WebProcessProxy.h:

(WebKit::WebProcessProxy::send):

10:39 Changeset [71930] by weinig@apple.com

ASSERTION when converting some WKStringRefs returned from willSubmitForm to CFStringRef
<rdar://problem/8662180>
https://bugs.webkit.org/show_bug.cgi?id=49454

Reviewed by Anders Carlsson.

Enforce the invariant that a WebString never contains a null WTF::String at a
lower level, in the WebString constructor, instead of relying on the callers of
WebString::create to do it.

  • Shared/API/c/WKSharedAPICast.h:

(WebKit::toAPI):
(WebKit::toCopiedAPI): Remove null string check...

  • Shared/WebString.h:

(WebKit::WebString::WebString): ... and move it to the constructor.

  • Shared/API/c/WKURL.cpp:

(WKURLCopyString): Use toCopiedAPI() instead of calling WebString directly
to match other similar uses.

10:30 Changeset [71929] by mihaip@chromium.org

2010-11-12 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium expectations update.

Mark http/tests/media/video-cookie.html as flaky.

  • platform/chromium/test_expectations.txt:
10:25 Changeset [71928] by tony@chromium.org

2010-11-12 Tony Chang <tony@chromium.org>

Reviewed by Kent Tamura.

[chromium] Load a blank page when closing DRT WebViewHosts
https://bugs.webkit.org/show_bug.cgi?id=49417

  • platform/chromium/drt_expectations.txt: Fix 2 tests in DRT.

2010-11-12 Tony Chang <tony@chromium.org>

Reviewed by Kent Tamura.

[chromium] Load a blank page when closing DRT WebViewHosts
https://bugs.webkit.org/show_bug.cgi?id=49417

In test_shell, when we close a window, we first load about:blank
and run GC to fire the destruction logic of the page. In test_shell,
this happens in ~TestShell. In DRT, we manage virtual windows as
WebViewHosts, so we need to replicate this logic in ~WebViewHost.

Managing focus is a bit trickier, since normally you would get window
events to reset the focus to the right window. We do it manually
instead.

This fixes 2 plugin tests on DRT.

  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::~TestShell): Move window close logic to ~WebViewHost. (TestShell::closeWindow): Move widget close() to WVH destructor and

manage focus manually.

(TestShell::closeRemainingWindows): Comment typo.

  • DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::closeWidget): (invokeCloseWidget): (WebViewHost::closeWidgetSoon): Close the window asynchronously (matches

test_shell).

(WebViewHost::~WebViewHost):

  • DumpRenderTree/chromium/WebViewHost.h:
10:22 Changeset [71927] by mihaip@chromium.org

2010-11-12 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium rebaseline.

Accumulated rebaselines that were missed due to lots of tests having
expected failures because of bug 48634.

  • platform/chromium-linux/fast/css/input-search-padding-expected.checksum: Added.
  • platform/chromium-linux/fast/css/input-search-padding-expected.png: Added.
  • platform/chromium-linux/fast/css/input-search-padding-expected.txt: Added.
  • platform/chromium-mac/fast/css/input-search-padding-expected.checksum: Added.
  • platform/chromium-mac/fast/css/input-search-padding-expected.png: Added.
  • platform/chromium-mac/fast/lists/markers-in-selection-expected.checksum: Added.
  • platform/chromium-mac/fast/lists/markers-in-selection-expected.png:
  • platform/chromium-mac/fast/repaint/block-layout-inline-children-replaced-expected.checksum:
  • platform/chromium-mac/fast/repaint/block-layout-inline-children-replaced-expected.png:
  • platform/chromium-win/fast/css/input-search-padding-expected.checksum: Added.
  • platform/chromium-win/fast/css/input-search-padding-expected.png: Added.
  • platform/chromium-win/fast/css/input-search-padding-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
10:18 Changeset [71926] by levin@chromium.org

cpp.py needs some tidying.
https://bugs.webkit.org/show_bug.cgi?id=49443

Reviewed by Adam Barth.

  • Scripts/webkitpy/style/checkers/cpp.py: Fix parameter ordering for iteratively_replace_matches_with_char to mirror other similar functions (and improved comments, etc.) Also, use a python-ism (for/else) to get rid of a variable that was there to determine if something had been found in the loop.
10:18 Changeset [71925] by inferno@chromium.org

2010-11-11 Abhishek Arya <inferno@chromium.org>

Reviewed by Adam Barth.

Not allow drag and drop across different origins.
https://bugs.webkit.org/show_bug.cgi?id=49098

Test: http/tests/security/drag-drop-different-origin.html

  • page/DragController.cpp: (WebCore::DragController::tryDocumentDrag):
  • page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::canDropOnTarget):
  • page/SecurityOrigin.h:

2010-11-10 Abhishek Arya <inferno@chromium.org>

Reviewed by Adam Barth.

Check that drag and drop is not allowed across different origins.
https://bugs.webkit.org/show_bug.cgi?id=49098


  • http/tests/security/drag-drop-different-origin-expected.txt: Added.
  • http/tests/security/drag-drop-different-origin.html: Added.
  • http/tests/security/resources/drag-drop.html: Added.
10:09 Changeset [71924] by mihaip@chromium.org

2010-11-12 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium expectations update.

Now that we know better what is causing bug bug 48634, we can just
skip fast/images/size-failure.html instead of the 100+ tests that follow
it.

  • platform/chromium/test_expectations.txt:
09:59 Changeset [71923] by andersca@apple.com

CString(const char*) crashes when passed a null pointer
https://bugs.webkit.org/show_bug.cgi?id=49450

Reviewed by Adam Roben.

  • wtf/text/CString.cpp:

(WTF::CString::CString):
Return early if str is null.

09:55 Changeset [71922] by apavlov@chromium.org

2010-11-11 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Inspect element tooltip obscures element metrics
https://bugs.webkit.org/show_bug.cgi?id=47822

  • inspector/InspectorController.cpp: (WebCore::InspectorController::drawNodeHighlight): (WebCore::InspectorController::drawElementTitle):
09:43 Changeset [71921] by commit-queue@webkit.org

2010-11-12 Robert Kroeger <rjkroege@chromium.org>

Reviewed by James Robinson.

[Chromium/DRT] Make EventSendingController send complete touch events.
https://bugs.webkit.org/show_bug.cgi?id=49285

  • DumpRenderTree/chromium/EventSender.cpp: (EventSender::addTouchPoint): (EventSender::updateTouchPoint): (EventSender::sendCurrentTouchEvent):
09:30 Changeset [71920] by commit-queue@webkit.org

2010-11-12 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Button's background style from default Qt Mobile Theme is overriding facebook's button style
https://bugs.webkit.org/show_bug.cgi?id=48198

Instead of creating gradients that goes from white to grey and cover the whole element the gradients
are created by varying the alpha channel of a dark color. This way the effect will not override the
background color of the elements.

  • css/themeQtMobile.css:
09:23 Changeset [71919] by andreas.kling@nokia.com

2010-11-12 Andreas Kling <kling@webkit.org>

Reviewed by Antonio Gomes.

[Qt][WK2] Fix leaking of mapped files

MappedMemory::fileName was never set on the receiving side, which led
the MappedMemoryPool to call QFile::map() again when reusing an existing file.

  • Platform/qt/MappedMemoryPool.cpp: (WebKit::MappedMemoryPool::mapFile):
08:55 Changeset [71918] by jschuh@chromium.org

2010-11-12 Justin Schuh <jschuh@chromium.org>

Reviewed by Adam Barth.

Use a RefPtr inside ContainerNode::willRemove loop
https://bugs.webkit.org/show_bug.cgi?id=49237

Test: fast/innerHTML/innerHTML-iframe.html

  • dom/ContainerNode.cpp: (WebCore::ContainerNode::willRemove):

2010-11-12 Justin Schuh <jschuh@chromium.org>

Reviewed by Adam Barth.

Use a RefPtr inside ContainerNode::willRemove loop
https://bugs.webkit.org/show_bug.cgi?id=49237

  • fast/innerHTML/innerHTML-iframe-expected.txt: Added.
  • fast/innerHTML/innerHTML-iframe.html: Added.
08:41 Changeset [71917] by yurys@chromium.org

2010-11-12 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: add more event listener breakpoint types, add support for regular breakpoint hit state, beautify hit rendering.
https://bugs.webkit.org/show_bug.cgi?id=49130

  • English.lproj/localizedStrings.js:
  • inspector/front-end/BreakpointManager.js: (WebInspector.BreakpointManager.prototype.debuggerPaused): (WebInspector.Breakpoint.jsBreakpointId): (WebInspector.Breakpoint.prototype.get id):
  • inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.EventListenerBreakpointsSidebarPane): (WebInspector.EventListenerBreakpointsSidebarPane.prototype._createCategory):
  • inspector/front-end/CallStackSidebarPane.js: (WebInspector.CallStackSidebarPane.prototype._breakpointHit): don't call populateStatusMessage for JS breakpoints since there is no specific message in that case.
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype.reset):
  • inspector/front-end/inspector.css: (#elements-sidebar): (.pane > .body): (#scripts-sidebar): (li.breakpoint-hit .breakpoint-hit-marker):
08:37 Changeset [71916] by mihaip@chromium.org

2010-11-12 Mihai Parparita <mihaip@chromium.org>

Unreviewed rollout of r71858.

Rollout out r71858 since it breaks new-run-webkit-httpd as used by the
NaCl tests.

  • Scripts/webkitpy/layout_tests/port/config.py:
  • Scripts/webkitpy/layout_tests/port/config_standalone.py: Removed.
  • Scripts/webkitpy/layout_tests/port/config_unittest.py:
08:36 Changeset [71915] by yael.aharon@nokia.com

2010-11-12 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Antonio Gomes.

Spatial Navigation: Need better way to control size of content in tests.
https://bugs.webkit.org/show_bug.cgi?id=49398

Add an image and use it in a layout test to define fixed size for all ports.
This also fixes https://bugs.webkit.org/show_bug.cgi?id=43030

  • fast/events/spatial-navigation/resources/green.png: Added.
  • fast/events/spatial-navigation/snav-clipped-overflowed-content-expected.txt:
  • fast/events/spatial-navigation/snav-clipped-overflowed-content.html:
  • platform/qt/Skipped:
08:30 Changeset [71914] by aroben@apple.com

Skip a timing-out test on Windows XP

  • platform/win-xp/Skipped: Added. Skip

fast/workers/storage/change-version-handle-reuse-worker.html.

08:30 Changeset [71913] by aroben@apple.com

Land new Windows results for tests added in r71851

  • platform/win/fast/repaint/japanese-rl-selection-clear-expected.checksum: Added.
  • platform/win/fast/repaint/japanese-rl-selection-clear-expected.png: Added.
  • platform/win/fast/repaint/japanese-rl-selection-clear-expected.txt: Added.
  • platform/win/fast/repaint/japanese-rl-selection-repaint-expected.checksum: Added.
  • platform/win/fast/repaint/japanese-rl-selection-repaint-expected.png: Added.
  • platform/win/fast/repaint/japanese-rl-selection-repaint-expected.txt: Added.
08:25 Changeset [71912] by bulach@chromium.org

2010-11-12 Marcus Bulach <bulach@chromium.org>

Not reviewed, Chromium test expectation update.

Update chromium baselines for svg following r71908 (missed mac in r71910).
https://bugs.webkit.org/show_bug.cgi?id=49447

  • platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in-attr-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in-attr-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in2-attr-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in2-attr-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-scale-attr-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-scale-attr-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-xChannelSelector-attr-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-xChannelSelector-attr-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-yChannelSelector-attr-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-yChannelSelector-attr-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in-prop-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in-prop-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in2-prop-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in2-prop-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-scale-prop-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-scale-prop-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-xChannelSelector-prop-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-xChannelSelector-prop-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-yChannelSelector-prop-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-yChannelSelector-prop-expected.png: Added.
07:43 Changeset [71911] by caseq@chromium.org

2010-11-12 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [Extensions API] [refactoring] generate public API interfaces automatically
Adjusting the order of properties in API interfaces dumps in the expectations.
https://bugs.webkit.org/show_bug.cgi?id=49441

  • inspector/extensions-api-expected.txt:
  • inspector/extensions-audits-api-expected.txt:
  • inspector/extensions-expected.txt:

2010-11-12 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [Extensions API] [refactoring] generate public API interfaces automatically
https://bugs.webkit.org/show_bug.cgi?id=49441

07:39 Changeset [71910] by bulach@chromium.org

2010-11-12 Marcus Bulach <bulach@chromium.org>

Not reviewed, Chromium test expectation update.

Update chromium baselines for svg following r71908
https://bugs.webkit.org/show_bug.cgi?id=49440

  • platform/chromium-linux/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in2-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in2-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-scale-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-scale-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-xChannelSelector-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-xChannelSelector-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-yChannelSelector-attr-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-yChannelSelector-attr-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in2-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in2-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-scale-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-scale-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-xChannelSelector-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-xChannelSelector-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-yChannelSelector-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-yChannelSelector-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in2-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in2-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-scale-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-scale-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-xChannelSelector-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-xChannelSelector-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-yChannelSelector-attr-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-yChannelSelector-attr-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in2-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in2-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-scale-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-scale-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-xChannelSelector-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-xChannelSelector-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-yChannelSelector-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-yChannelSelector-prop-expected.png: Added.
07:25 Changeset [71909] by aroben@apple.com

Windows build fix

  • win/WebKit2Generated.make: Copy WKBundlePageOverlay.h.
05:52 Changeset [71908] by reni@webkit.org

WebCore: SVGFEDisplacementMapElement doesn't support dynamic invalidation
https://bugs.webkit.org/show_bug.cgi?id=49430

Patch by Renata Hodovan <reni@webkit.org> on 2010-11-12
Reviewed by Nikolas Zimmermann.

The dynamic changes are captured by the svgAttributeChanged function. Invalidate the filter primitive if necessary.

Tests: svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in-attr.html

svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in2-attr.html
svg/dynamic-updates/SVGFEDisplacementMapElement-dom-scale-attr.html
svg/dynamic-updates/SVGFEDisplacementMapElement-dom-xChannelSelector-attr.html
svg/dynamic-updates/SVGFEDisplacementMapElement-dom-yChannelSelector-attr.html
svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in-prop.html
svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in2-prop.html
svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-scale-prop.html
svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-xChannelSelector-prop.html
svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-yChannelSelector-prop.html

  • svg/SVGFEDisplacementMapElement.cpp:

(WebCore::SVGFEDisplacementMapElement::svgAttributeChanged):

  • svg/SVGFEDisplacementMapElement.h:

LayoutTests: SVGFEDisplacementMapElement doesn't support dynamic invalidation, when attributes change.
https://bugs.webkit.org/show_bug.cgi?id=49430

Patch by Renata Hodovan <reni@webkit.org> on 2010-11-12
Reviewed by Nikolas Zimmermann.

Adding layout tests for feDisplacementMap dynamic changes.

  • platform/mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in2-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in2-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-scale-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-scale-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-xChannelSelector-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-xChannelSelector-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-yChannelSelector-attr-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-yChannelSelector-attr-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in-prop-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in2-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in2-prop-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-scale-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-scale-prop-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-xChannelSelector-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-xChannelSelector-prop-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-yChannelSelector-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-yChannelSelector-prop-expected.png: Added.
  • svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in-attr.html: Added.
  • svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in2-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in2-attr.html: Added.
  • svg/dynamic-updates/SVGFEDisplacementMapElement-dom-scale-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGFEDisplacementMapElement-dom-scale-attr.html: Added.
  • svg/dynamic-updates/SVGFEDisplacementMapElement-dom-xChannelSelector-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGFEDisplacementMapElement-dom-xChannelSelector-attr.html: Added.
  • svg/dynamic-updates/SVGFEDisplacementMapElement-dom-yChannelSelector-attr-expected.txt: Added.
  • svg/dynamic-updates/SVGFEDisplacementMapElement-dom-yChannelSelector-attr.html: Added.
  • svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in-prop.html: Added.
  • svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in2-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in2-prop.html: Added.
  • svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-scale-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-scale-prop.html: Added.
  • svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-xChannelSelector-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-xChannelSelector-prop.html: Added.
  • svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-yChannelSelector-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-yChannelSelector-prop.html: Added.
  • svg/dynamic-updates/script-tests/SVGFEDisplacementMapElement-dom-in-attr.js: Added.

(executeTest):

  • svg/dynamic-updates/script-tests/SVGFEDisplacementMapElement-dom-in2-attr.js: Added.

(executeTest):

  • svg/dynamic-updates/script-tests/SVGFEDisplacementMapElement-dom-scale-attr.js: Added.

(executeTest):

  • svg/dynamic-updates/script-tests/SVGFEDisplacementMapElement-dom-xChannelSelector-attr.js: Added.

(executeTest):

  • svg/dynamic-updates/script-tests/SVGFEDisplacementMapElement-dom-yChannelSelector-attr.js: Added.

(executeTest):

  • svg/dynamic-updates/script-tests/SVGFEDisplacementMapElement-svgdom-in-prop.js: Added.

(executeTest):

  • svg/dynamic-updates/script-tests/SVGFEDisplacementMapElement-svgdom-in2-prop.js: Added.

(executeTest):

  • svg/dynamic-updates/script-tests/SVGFEDisplacementMapElement-svgdom-scale-prop.js: Added.

(executeTest):

  • svg/dynamic-updates/script-tests/SVGFEDisplacementMapElement-svgdom-xChannelSelector-prop.js: Added.

(executeTest):

  • svg/dynamic-updates/script-tests/SVGFEDisplacementMapElement-svgdom-yChannelSelector-prop.js: Added.

(executeTest):

05:45 Changeset [71907] by benjamin.poulain@nokia.com

2010-11-12 Benjamin Poulain <benjamin.poulain@nokia.com>

Unreviewed fix after r71857.

  • UIProcess/qt/WebInspectorProxyQt.cpp:
  • WebProcess/WebPage/qt/WebInspectorQt.cpp:
05:34 Changeset [71906] by caseq@chromium.org

2010-11-12 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [refactoring] do not use absolute positioning for tabbed panes
https://bugs.webkit.org/show_bug.cgi?id=49439

  • inspector/front-end/TabbedPane.js: (WebInspector.TabbedPane): (WebInspector.TabbedPane.prototype.appendTab):
  • inspector/front-end/inspector.css: (.resource-view.visible): (.resource-view .tabbed-pane-header): (.resource-view-cookies): (.tabbed-pane): (.tabbed-pane-content):
  • inspector/front-end/networkPanel.css:
04:49 Changeset [71905] by inferno@chromium.org

Merge 71895

BUG=61313

04:42 Changeset [71904] by inferno@chromium.org

Merge 71797

BUG=61313

04:04 Changeset [71903] by commit-queue@webkit.org

2010-11-12 John Knottenbelt <jknotten@chromium.org>

Reviewed by Steve Block.

Rename GeolocationControllerClient to GeolocationClient.
https://bugs.webkit.org/show_bug.cgi?id=49259

No new tests, renaming only.

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.order:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • page/GeolocationClient.h: Renamed from WebCore/page/GeolocationControllerClient.h. (WebCore::GeolocationClient::~GeolocationClient):
  • page/GeolocationController.cpp: (WebCore::GeolocationController::GeolocationController):
  • page/GeolocationController.h:
  • page/Page.h:

2010-11-12 John Knottenbelt <jknotten@chromium.org>

Reviewed by Steve Block.

Rename GeolocationControllerClient to GeolocationClient.
https://bugs.webkit.org/show_bug.cgi?id=49259

  • WebKit.xcodeproj/project.pbxproj:

2010-11-12 John Knottenbelt <jknotten@chromium.org>

Reviewed by Steve Block.

Rename GeolocationControllerClient to GeolocationClient.
https://bugs.webkit.org/show_bug.cgi?id=49259

  • WebCoreSupport/WebGeolocationClient.h: Renamed from WebKit/mac/WebCoreSupport/WebGeolocationControllerClient.h. (WebGeolocationClient::webView): (WebGeolocationClient::setEnableHighAccuracy):
  • WebCoreSupport/WebGeolocationClient.mm: Renamed from WebKit/mac/WebCoreSupport/WebGeolocationControllerClient.mm. (WebGeolocationClient::WebGeolocationClient): (WebGeolocationClient::geolocationDestroyed): (WebGeolocationClient::startUpdating): (WebGeolocationClient::stopUpdating): (WebGeolocationClient::lastPosition):
  • WebKit.order:
  • WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):

2010-11-12 John Knottenbelt <jknotten@chromium.org>

Reviewed by Steve Block.

Rename GeolocationControllerClient to GeolocationClient.
https://bugs.webkit.org/show_bug.cgi?id=49259

  • WebCoreSupport/WebGeolocationClient.cpp: Renamed from WebKit/win/WebCoreSupport/WebGeolocationControllerClient.cpp. (WebGeolocationClient::WebGeolocationClient): (WebGeolocationClient::geolocationDestroyed): (WebGeolocationClient::startUpdating): (WebGeolocationClient::stopUpdating): (WebGeolocationClient::lastPosition):
  • WebCoreSupport/WebGeolocationClient.h: Renamed from WebKit/win/WebCoreSupport/WebGeolocationControllerClient.h. (WebGeolocationClient::setEnableHighAccuracy):
  • WebKit.vcproj/WebKit.vcproj:
  • WebView.cpp: (WebView::initWithFrame):
03:30 Changeset [71902] by benjamin.poulain@nokia.com

2010-11-12 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] TestController::runUntil doesn't honor the timeout parameter
https://bugs.webkit.org/show_bug.cgi?id=48941

Implement the missing timeout of WebKitTestRunner for Qt.

A QElapsedTimer has been added to RunUntilConditionLoop in order
to measure how long the loop has been running. When the timer
is bigger or equal than the timeout, the loop ends even if the
condition is not met.

  • WebKitTestRunner/qt/TestControllerQt.cpp: (WTR::RunUntilConditionLoop::start): (WTR::RunUntilConditionLoop::run): (WTR::RunUntilConditionLoop::timerEvent): (WTR::TestController::platformRunUntil):
03:04 Changeset [71901] by bulach@chromium.org

2010-11-12 Marcus Bulach <bulach@chromium.org>

Not reviewed, Chromium test expectation update.

Updates test expectations for chromium following r71886
https://bugs.webkit.org/show_bug.cgi?id=49436

Temporarily disables editing/selection/context-menu-on-text.html until we fix test_shell.

  • platform/chromium/test_expectations.txt:
02:39 Changeset [71900] by commit-queue@webkit.org

2010-11-12 Ilya Sherman <isherman@chromium.org>

Reviewed by Eric Seidel.

Remove some trailing whitespace
https://bugs.webkit.org/show_bug.cgi?id=49433

  • platform/PopupMenuClient.h:
  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupContainer::show): (WebCore::PopupListBox::paintRow): (WebCore::PopupListBox::scrollToRevealRow):
  • platform/chromium/PopupMenuChromium.h:
  • platform/chromium/SearchPopupMenuChromium.cpp:
  • rendering/RenderMenuList.h: (WebCore::RenderMenuList::toRenderMenuList):
  • rendering/RenderTextControlSingleLine.h: (WebCore::toRenderTextControlSingleLine):

2010-11-12 Ilya Sherman <isherman@chromium.org>

Reviewed by Eric Seidel.

Remove some trailing whitespace
https://bugs.webkit.org/show_bug.cgi?id=49433

  • src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::createPopupMenu):
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::scrollRootLayerRect): (WebKit::WebViewImpl::invalidateRootLayerRect):
01:26 Changeset [71899] by rniwa@webkit.org

2010-11-12 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Csaba Osztrogonác.

[qt] script-clone tests added in r71895 fails on qt platform
https://bugs.webkit.org/show_bug.cgi?id=49429

Enabled fast/dom/script-clone-rerun-self.html and fast/dom/script-clone-rerun.html

  • platform/qt/Skipped:

2010-11-12 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Csaba Osztrogonác.

[qt] script-clone tests added in r71895 fails on qt platform
https://bugs.webkit.org/show_bug.cgi?id=49429

Fixed parseEndElement to call ScriptElement's executeScript as supposed to that of ScriptController.

  • dom/XMLDocumentParserQt.cpp: (WebCore::XMLDocumentParser::parseEndElement):
01:24 Changeset [71898] by morrita@google.com

2010-11-05 MORITA Hajime <morrita@google.com>

Reviewed by Kent Tamura.

Refactoring: Return values of TextCheckingHelper::paragraphAlignedRange should form a class.
https://bugs.webkit.org/show_bug.cgi?id=49053

Replaced paragraphAlignedRange() function call into
TextCheckingParagraph class. The class encapsulates a range of a
paragraph, and its relation within associated checking range.
Instance variables of the class are computed lazily. So we can save unnecessary
memory allocation and DOM tree traversal.

No new tests, no behavior change.

  • editing/Editor.cpp: (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): Replaced paragraphAlignedRange() call. (WebCore::Editor::changeBackToReplacedString): Replaced paragraphAlignedRange() call.
  • editing/TextCheckingHelper.cpp: (WebCore::expandToParagraphBoundary): (WebCore::TextCheckingParagraph::TextCheckingParagraph): (WebCore::TextCheckingParagraph::~TextCheckingParagraph): (WebCore::TextCheckingParagraph::expandRangeToNextEnd): (WebCore::TextCheckingParagraph::invalidateParagraphRangeValues): (WebCore::TextCheckingParagraph::rangeLength): (WebCore::TextCheckingParagraph::paragraphRange): (WebCore::TextCheckingParagraph::subrange): (WebCore::TextCheckingParagraph::offsetTo): (WebCore::TextCheckingParagraph::isEmpty): (WebCore::TextCheckingParagraph::offsetAsRange): (WebCore::TextCheckingParagraph::text): (WebCore::TextCheckingParagraph::checkingStart): (WebCore::TextCheckingParagraph::checkingEnd): (WebCore::TextCheckingParagraph::checkingLength): (WebCore::TextCheckingHelper::findFirstBadGrammar): Replaced paragraphAlignedRange() call. (WebCore::TextCheckingHelper::guessesForMisspelledOrUngrammaticalRange): Replaced paragraphAlignedRange() call.
  • editing/TextCheckingHelper.h: (WebCore::TextCheckingParagraph::textLength): (WebCore::TextCheckingParagraph::textSubstring): (WebCore::TextCheckingParagraph::textCharacters): (WebCore::TextCheckingParagraph::textCharAt): (WebCore::TextCheckingParagraph::checkingSubstring): (WebCore::TextCheckingParagraph::checkingRangeMatches): (WebCore::TextCheckingParagraph::isCheckingRangeCoveredBy): (WebCore::TextCheckingParagraph::checkingRangeCovers): (WebCore::TextCheckingParagraph::checkingRange): (WebCore::TextCheckingParagraph::isTextEmpty): (WebCore::TextCheckingParagraph::isRangeEmpty):
Note: See TracTimeline for information about the timeline view.