Context Navigation

← Previous Period
Next Period →

Timeline

11/22/10:

23:44 Changeset [72587] by commit-queue@webkit.org

2010-11-22 Alexey Marinichev <amarinichev@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Implement Extensions3DChromium::getGraphicsResetStatusARB
https://bugs.webkit.org/show_bug.cgi?id=49946

public/WebGraphicsContext3D.h: added isContextLost()
src/Extensions3DChromium.cpp: (WebCore::Extensions3DChromium::getGraphicsResetStatusARB):
src/GraphicsContext3DChromium.cpp: (WebCore::GraphicsContext3DInternal::isContextLost):
src/GraphicsContext3DInternal.h:
src/WebGraphicsContext3DDefaultImpl.cpp: (WebKit::WebGraphicsContext3DDefaultImpl::isContextLost):
src/WebGraphicsContext3DDefaultImpl.h:
src/WebViewImpl.cpp: (WebKit::WebViewImpl::reallocateRenderer): ensure root layer repaining

22:46 Changeset [72586] by jcivelli@chromium.org

2010-11-22 Jay Civelli <jcivelli@chromium.org>

Reviewed by David Levin.

Don't create an external popup menu when there are no items to show.
https://bugs.webkit.org/show_bug.cgi?id=49937

src/ExternalPopupMenu.cpp: (WebKit::ExternalPopupMenu::show):

22:26 Changeset [72585] by paroga@webkit.org

2010-11-22 Patrick Gansterer <paroga@webkit.org>

Reviewed by Adam Roben.

Port ContextMenuWin.cpp to WinCE
https://bugs.webkit.org/show_bug.cgi?id=48408

platform/ContextMenu.h:
platform/win/ContextMenuWin.cpp: (WebCore::ContextMenu::ContextMenu): (WebCore::ContextMenu::itemCount): (WebCore::insertMenuItem): (WebCore::ContextMenu::insertItem): (WebCore::contextMenuItemByIdOrPosition): (WebCore::ContextMenu::setPlatformDescription): (WebCore::contextMenuItemVector): (WebCore::platformMenuDescription):

22:05 Changeset [72584] by commit-queue@webkit.org

2010-11-22 Nat Duca <nduca@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Send didActivateAcceleratedCompositing when compositor
initializes but does not create the shared context3d.
https://bugs.webkit.org/show_bug.cgi?id=49930

src/WebViewImpl.cpp: (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

21:44 Changeset [72583] by hyatt@apple.com

Back out rebaselines from r72527.

platform/mac/css2.1/t0805-c5520-brdr-b-01-e-expected.txt:
platform/mac/fast/lists/marker-before-empty-inline-expected.txt:

21:41 Changeset [72582] by hyatt@apple.com

Back out r72527 since it caused multiple rendering regressions. Details in bug.

WebCore:

rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::placeBoxesInInlineDirection):

rendering/RenderListItem.cpp:

(WebCore::RenderListItem::positionListMarker):

LayoutTests:

fast/lists/outSideListMarkers-expected.txt: Removed.
fast/lists/outSideListMarkers.html: Removed.
platform/mac-leopard/css1/box_properties/margin_right-expected.checksum:
platform/mac-leopard/css1/box_properties/margin_right-expected.png:
platform/mac-leopard/css1/box_properties/padding_right-expected.checksum:
platform/mac-leopard/css1/box_properties/padding_right-expected.png:
platform/mac-leopard/editing/pasteboard/merge-end-list-expected.checksum:
platform/mac-leopard/editing/pasteboard/merge-end-list-expected.png:
platform/mac-leopard/fast/css/background-shorthand-invalid-url-expected.checksum:
platform/mac-leopard/fast/css/background-shorthand-invalid-url-expected.png:
platform/mac-leopard/fast/css/empty-pseudo-class-expected.checksum:
platform/mac-leopard/fast/css/empty-pseudo-class-expected.png:
platform/mac-leopard/fast/css/first-child-pseudo-class-expected.checksum:
platform/mac-leopard/fast/css/first-child-pseudo-class-expected.png:
platform/mac-leopard/fast/css/first-of-type-pseudo-class-expected.checksum:
platform/mac-leopard/fast/css/first-of-type-pseudo-class-expected.png:
platform/mac-leopard/fast/css/last-child-pseudo-class-expected.checksum:
platform/mac-leopard/fast/css/last-child-pseudo-class-expected.png:
platform/mac-leopard/fast/css/last-of-type-pseudo-class-expected.checksum:
platform/mac-leopard/fast/css/last-of-type-pseudo-class-expected.png:
platform/mac-leopard/fast/css/only-child-pseudo-class-expected.checksum:
platform/mac-leopard/fast/css/only-child-pseudo-class-expected.png:
platform/mac-leopard/fast/css/only-of-type-pseudo-class-expected.checksum:
platform/mac-leopard/fast/css/only-of-type-pseudo-class-expected.png:
platform/mac-leopard/fast/doctypes/002-expected.checksum:
platform/mac-leopard/fast/doctypes/002-expected.png:
platform/mac-leopard/fast/lists/001-expected.checksum:
platform/mac-leopard/fast/lists/001-expected.png:
platform/mac-leopard/fast/lists/002-expected.checksum:
platform/mac-leopard/fast/lists/002-expected.png:
platform/mac-leopard/fast/lists/003-expected.checksum:
platform/mac-leopard/fast/lists/003-expected.png:
platform/mac/css1/box_properties/margin_right-expected.txt:
platform/mac/css1/box_properties/padding_right-expected.txt:
platform/mac/editing/pasteboard/merge-end-list-expected.txt:
platform/mac/editing/selection/extend-by-word-002-expected.checksum:
platform/mac/editing/selection/extend-by-word-002-expected.png:
platform/mac/editing/selection/extend-by-word-002-expected.txt:
platform/mac/fast/css/background-shorthand-invalid-url-expected.txt:
platform/mac/fast/css/empty-pseudo-class-expected.txt:
platform/mac/fast/css/first-child-pseudo-class-expected.txt:
platform/mac/fast/css/first-of-type-pseudo-class-expected.txt:
platform/mac/fast/css/last-child-pseudo-class-expected.txt:
platform/mac/fast/css/last-of-type-pseudo-class-expected.txt:
platform/mac/fast/css/only-child-pseudo-class-expected.txt:
platform/mac/fast/css/only-of-type-pseudo-class-expected.txt:
platform/mac/fast/doctypes/002-expected.txt:
platform/mac/fast/lists/001-expected.txt:
platform/mac/fast/lists/001-vertical-expected.checksum:
platform/mac/fast/lists/001-vertical-expected.png:
platform/mac/fast/lists/001-vertical-expected.txt:
platform/mac/fast/lists/002-expected.txt:
platform/mac/fast/lists/002-vertical-expected.checksum:
platform/mac/fast/lists/002-vertical-expected.png:
platform/mac/fast/lists/002-vertical-expected.txt:
platform/mac/fast/lists/003-expected.txt:
platform/mac/fast/lists/003-vertical-expected.checksum:
platform/mac/fast/lists/003-vertical-expected.png:
platform/mac/fast/lists/003-vertical-expected.txt:
platform/mac/fast/lists/007-vertical-expected.checksum:
platform/mac/fast/lists/007-vertical-expected.png:
platform/mac/fast/lists/007-vertical-expected.txt:
platform/mac/fast/lists/008-vertical-expected.checksum:
platform/mac/fast/lists/008-vertical-expected.png:
platform/mac/fast/lists/008-vertical-expected.txt:
platform/mac/fast/lists/outSideListMarkers-expected.checksum: Removed.
platform/mac/fast/lists/outSideListMarkers-expected.png: Removed.

20:43 Changeset [72581] by commit-queue@webkit.org

2010-11-22 John Knottenbelt <jknotten@chromium.org>

Reviewed by Steve Block.

Implement mocks for client-based Geolocation.
https://bugs.webkit.org/show_bug.cgi?id=49258

Android.mk:
CMakeLists.txt:
GNUmakefile.am:
WebCore.gypi:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
platform/mock/GeolocationClientMock.cpp: Added. (WebCore::GeolocationClientMock::GeolocationClientMock): (WebCore::GeolocationClientMock::~GeolocationClientMock): (WebCore::GeolocationClientMock::setController): (WebCore::GeolocationClientMock::setPosition): (WebCore::GeolocationClientMock::setError): (WebCore::GeolocationClientMock::geolocationDestroyed): (WebCore::GeolocationClientMock::startUpdating): (WebCore::GeolocationClientMock::stopUpdating): (WebCore::GeolocationClientMock::setEnableHighAccuracy): (WebCore::GeolocationClientMock::lastPosition): (WebCore::GeolocationClientMock::timerFired): (WebCore::GeolocationClientMock::makeGeolocationCallback):
platform/mock/GeolocationClientMock.h: Added.

20:10 Changeset [72580] by commit-queue@webkit.org

2010-11-22 Leandro Pereira <leandro@profusion.mobi>

Reviewed by Andreas Kling.

Add Leandro Pereira's blog to Planet WebKit
https://bugs.webkit.org/show_bug.cgi?id=49910

config.ini:

18:35 Changeset [72579] by commit-queue@webkit.org

2010-11-22 Alex Grilo <abgrilo@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Tiled Backing Store for Webkit-Efl
https://bugs.webkit.org/show_bug.cgi?id=45397

This tile based backing store is a grid of tiles where each tile is
an Evas_Object showing a piece of the page content. The
new ewk_view_tiled.c is an implementation of some of the functions of
the original ewk_view, that makes calls to the Tiled Backing Store
specific functions.

The rendering occurs in the pixels stored in each tile (Evas_Object),
in the same way as the previous single backing store. Tiles not being
shown in the viewport are stored in a cache, and can be reused later
to avoid having to be rendered again.

Scrolling occurs as just moving the tiles, using Evas move operations,
and when more than one tile size is scrolled, a shift of rows or
columns needs to be done.

CMakeListsEfl.txt:
ewk/ewk_tiled_backing_store.c: Added. (_ewk_tiled_backing_store_updates_process): (_ewk_tiled_backing_store_flush): (_ewk_tiled_backing_store_tile_new): (_ewk_tiled_backing_store_item_move): (_ewk_tiled_backing_store_item_resize): (_ewk_tiled_backing_store_tile_associate): (_ewk_tiled_backing_store_tile_dissociate): (_ewk_tiled_backing_store_tile_dissociate_all): (_ewk_tiled_backing_store_pre_render_request_add): (_ewk_tiled_backing_store_pre_render_request_del): (_ewk_tiled_backing_store_pre_render_request_first): (_ewk_tiled_backing_store_pre_render_request_flush): (_ewk_tiled_backing_store_pre_render_request_remove_unassociated): (_ewk_tiled_backing_store_pre_render_request_remove_associated): (_ewk_tiled_backing_store_pre_render_request_process_single): (_ewk_tiled_backing_store_item_process_idler_cb): (_ewk_tiled_backing_store_item_process_idler_stop): (_ewk_tiled_backing_store_item_process_idler_start): (_ewk_tiled_backing_store_item_request_del): (_ewk_tiled_backing_store_item_request_add): (_ewk_tiled_backing_store_disable_render): (_ewk_tiled_backing_store_enable_render): (_ewk_tiled_backing_store_visible_tiles_rect): (_ewk_tiled_backing_store_tile_is_inside_viewport): (_ewk_tiled_backing_store_tile_is_adjacent_to_viewport): (_ewk_tiled_backing_store_item_fill): (_ewk_tiled_backing_store_item_add): (_ewk_tiled_backing_store_item_del): (_ewk_tiled_backing_store_item_smooth_scale_set): (_ewk_tiled_backing_store_changed): (_ewk_tiled_backing_store_view_cols_end_del): (_ewk_tiled_backing_store_view_cols_end_add): (_ewk_tiled_backing_store_view_row_del): (_ewk_tiled_backing_store_view_rows_range_del): (_ewk_tiled_backing_store_view_rows_all_del): (_ewk_tiled_backing_store_render): (_ewk_tiled_backing_store_model_matrix_create): (_ewk_tiled_backing_store_smart_member_del): (_ewk_tiled_backing_store_smart_member_add): (_ewk_tiled_backing_store_mem_dbg): (_ewk_tiled_backing_store_sig_usr): (_ewk_tiled_backing_store_smart_add): (_ewk_tiled_backing_store_smart_del): (_ewk_tiled_backing_store_smart_move): (_ewk_tiled_backing_store_smart_resize): (_ewk_tiled_backing_store_recalc_renderers): (_ewk_tiled_backing_store_smart_calculate_size): (_ewk_tiled_backing_store_view_dbg): (_ewk_tiled_backing_store_view_wrap_up): (_ewk_tiled_backing_store_view_wrap_down): (_ewk_tiled_backing_store_view_wrap_left): (_ewk_tiled_backing_store_view_wrap_right): (_ewk_tiled_backing_store_view_refill): (_ewk_tiled_backing_store_view_pos_apply): (_ewk_tiled_backing_store_smart_calculate_offset_force): (_ewk_tiled_backing_store_smart_calculate_offset): (_ewk_tiled_backing_store_smart_calculate_pos): (_ewk_tiled_backing_store_fill_renderers): (_ewk_tiled_backing_store_smart_calculate): (ewk_tiled_backing_store_add): (ewk_tiled_backing_store_render_cb_set): (ewk_tiled_backing_store_tile_unused_cache_get): (ewk_tiled_backing_store_tile_unused_cache_set): (_ewk_tiled_backing_store_scroll_full_offset_set_internal): (ewk_tiled_backing_store_scroll_full_offset_set): (ewk_tiled_backing_store_scroll_full_offset_add): (_ewk_tiled_backing_store_zoom_set_internal): (ewk_tiled_backing_store_zoom_set): (ewk_tiled_backing_store_zoom_weak_set): (ewk_tiled_backing_store_fix_offsets): (ewk_tiled_backing_store_zoom_weak_smooth_scale_set): (ewk_tiled_backing_store_update): (ewk_tiled_backing_store_updates_process_pre_set): (ewk_tiled_backing_store_updates_process_post_set): (ewk_tiled_backing_store_updates_process): (ewk_tiled_backing_store_updates_clear): (ewk_tiled_backing_store_contents_resize): (ewk_tiled_backing_store_disabled_update_set): (ewk_tiled_backing_store_flush): (ewk_tiled_backing_store_pre_render_region): (ewk_tiled_backing_store_pre_render_relative_radius): (ewk_tiled_backing_store_pre_render_cancel): (ewk_tiled_backing_store_disable_render): (ewk_tiled_backing_store_enable_render): (ewk_tiled_backing_store_process_entire_queue_set):
ewk/ewk_tiled_backing_store.h: Added.
ewk/ewk_tiled_matrix.c: Added. (_ewk_tile_matrix_cell_free): (_ewk_tile_matrix_tile_free): (ewk_tile_matrix_new): (ewk_tile_matrix_free): (ewk_tile_matrix_resize): (ewk_tile_matrix_unused_cache_get): (ewk_tile_matrix_tile_exact_get): (ewk_tile_matrix_tile_exact_exists): (ewk_tile_matrix_tile_nearest_get): (ewk_tile_matrix_tile_new): (ewk_tile_matrix_tile_put): (ewk_tile_matrix_tile_update): (ewk_tile_matrix_tile_update_full): (ewk_tile_matrix_tile_updates_clear): (_ewk_tile_matrix_slicer_setup): (ewk_tile_matrix_update): (ewk_tile_matrix_updates_process): (ewk_tile_matrix_updates_clear): (ewk_tile_matrix_dbg): (ewk_tile_matrix_freeze): (ewk_tile_matrix_thaw):
ewk/ewk_tiled_matrix.h: Added.
ewk/ewk_tiled_model.c: Added. (_ewk_tile_account_get): (_ewk_tile_account_allocated): (_ewk_tile_account_freed): (ewk_tile_accounting_dbg): (_ewk_tile_paint_rgb888): (_ewk_tile_paint_rgb565): (_ewk_tile_paint): (ewk_tile_new): (ewk_tile_free): (ewk_tile_show): (ewk_tile_hide): (ewk_tile_visible_get): (ewk_tile_update_full): (ewk_tile_update_area): (ewk_tile_updates_process): (ewk_tile_updates_clear): (ewk_tile_unused_cache_new): (ewk_tile_unused_cache_lock_area): (ewk_tile_unused_cache_unlock_area): (ewk_tile_unused_cache_free): (ewk_tile_unused_cache_clear): (ewk_tile_unused_cache_ref): (ewk_tile_unused_cache_unref): (ewk_tile_unused_cache_max_set): (ewk_tile_unused_cache_max_get): (ewk_tile_unused_cache_used_get): (ewk_tile_unused_cache_flush): (ewk_tile_unused_cache_auto_flush): (ewk_tile_unused_cache_dirty): (ewk_tile_unused_cache_freeze): (ewk_tile_unused_cache_thaw): (ewk_tile_unused_cache_tile_get): (ewk_tile_unused_cache_tile_put): (ewk_tile_unused_cache_dbg):
ewk/ewk_tiled_model.h: Added.
ewk/ewk_tiled_private.h: Added.
ewk/ewk_view.cpp: (_ewk_view_smart_add): (_ewk_view_smart_calculate): (_ewk_view_smart_show): (_ewk_view_smart_hide): (_ewk_view_smart_pre_render_relative_radius): (_ewk_view_zoom_animator_cb): (_ewk_view_smart_disable_render): (_ewk_view_smart_enable_render): (ewk_view_base_smart_set): (ewk_view_pre_render_region): (ewk_view_pre_render_relative_radius): (ewk_view_enable_render): (ewk_view_disable_render): (ewk_view_scroll): (ewk_view_did_first_visually_nonempty_layout): (ewk_view_dispatch_did_finish_loading): (ewk_view_transition_to_commited_for_newpage):
ewk/ewk_view.h:
ewk/ewk_view_tiled.c: Added. (_ewk_view_tiled_render_cb): (_ewk_view_tiled_updates_process_pre): (_ewk_view_tiled_smart_backing_store_add): (_ewk_view_tiled_contents_size_changed_cb): (_ewk_view_tiled_smart_add): (_ewk_view_tiled_smart_scrolls_process): (_ewk_view_tiled_smart_repaints_process): (_ewk_view_tiled_smart_contents_resize): (_ewk_view_tiled_smart_zoom_set): (_ewk_view_tiled_smart_zoom_weak_set): (_ewk_view_tiled_smart_zoom_weak_smooth_scale_set): (_ewk_view_tiled_smart_flush): (_ewk_view_tiled_smart_pre_render_region): (_ewk_view_tiled_smart_pre_render_relative_radius): (_ewk_view_tiled_smart_pre_render_cancel): (_ewk_view_tiled_smart_disable_render): (_ewk_view_tiled_smart_enable_render): (ewk_view_tiled_smart_set): (_ewk_view_tiled_smart_class_new): (ewk_view_tiled_add): (ewk_view_tiled_unused_cache_get): (ewk_view_tiled_unused_cache_set): (ewk_view_tiled_process_entire_queue_set):

17:50 Changeset [72578] by tonyg@chromium.org

2010-11-22 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Adam Barth.

Fix bogus include guard.

loader/NavigationScheduler.h:

17:47 Changeset [72577] by andreas.kling@nokia.com

2010-11-22 Andreas Kling <kling@webkit.org>

Reviewed by Ariya Hidayat.

[Qt] Canvas: strokeText() and fillText() produce same shadow
https://bugs.webkit.org/show_bug.cgi?id=48845

Test: fast/canvas/canvas-strokeText-strokes-shadow.html

platform/graphics/qt/FontQt.cpp: (WebCore::drawTextCommon): Stroke the shadow rather than filling it in the cTextStroke case.

2010-11-22 Andreas Kling <kling@webkit.org>

Reviewed by Ariya Hidayat.

[Qt] Canvas: strokeText() and fillText() produce same shadow
https://bugs.webkit.org/show_bug.cgi?id=48845

Add test to verify that strokeText() doesn't produce a fillText() shadow.

fast/canvas/canvas-strokeText-strokes-shadow.html: Added.
fast/canvas/canvas-strokeText-strokes-shadow-expected.txt: Added.
fast/canvas/script-tests/canvas-strokeText-strokes-shadow.js: Added.

16:56 Changeset [72576] by dpranke@chromium.org

2010-11-22 Dirk Pranke <dpranke@chromium.org>

Reviewed by Tony Chang.

Fix some spacing issues with log messages with
new-run-webkit-tests --verbose.

https://bugs.webkit.org/show_bug.cgi?id=49936

Scripts/webkitpy/layout_tests/layout_package/printing.py:

16:56 Changeset [72575] by ojan@chromium.org

2010-11-22 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

update scm to work with different remote branches
https://bugs.webkit.org/show_bug.cgi?id=49949

This works if there are multiple svn tracking branches
and/or if the tracking branch is refs/remots/origin/master
instead of refs/remotes/trunk which is the direction we're trying
to head since that makes fetches faster.

Scripts/webkitpy/common/checkout/scm.py:
Scripts/webkitpy/common/checkout/scm_unittest.py:

16:55 Changeset [72574] by paroga@webkit.org

2010-11-22 Patrick Gansterer <paroga@webkit.org>

Reviewed by Sam Weinig.

Add WTF::FixedArray::size()
https://bugs.webkit.org/show_bug.cgi?id=49891

Add a method to get the size of a FixedArray.

wtf/FixedArray.h: (WTF::FixedArray::size):

2010-11-22 Patrick Gansterer <paroga@webkit.org>

Reviewed by Sam Weinig.

Use WTF::FixedArray::size()
https://bugs.webkit.org/show_bug.cgi?id=49891

dom/Document.cpp: (WebCore::Document::~Document):

16:25 Changeset [72573] by rniwa@webkit.org

2010-11-22 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Tony Chang.

SelectionController::typingStyle() should return EditingStyle*
https://bugs.webkit.org/show_bug.cgi?id=49813

Changed the return value of SelectionController::typingStyle() to EditingStyle*.
Also added SelectionController::copyTypingStyle() to copy the typing style
as an instance of CSSMutableStyleDeclaration.

No tests are added since this is no behavioral change.

WebView/WebFrame.mm: (-[WebFrame _typingStyle]): Calls SelectionController::copyTypingStyle()

2010-11-22 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Tony Chang.

SelectionController::typingStyle() should return EditingStyle*
https://bugs.webkit.org/show_bug.cgi?id=49813

Changed the return type of SelectionController::typingStyle to EditingStyle*.

Extracted textDirection from Editor::textDirectionForSelection to hide the underlying
CSSMutableStyleDeclaration.

Also extracted the code to preserve unicode-bidi and direction CSS properties in
InsertTextCommand::input, and moved into EditingStyle::prepareToApplyAt. ShouldPreserveWritingDirection,
which is added to the argument list of EditingStyle::prepareToApplyAt, decides whether or not
these two properties are preserved.

Also added SelectionController::copyTypingStyle() to copy the typing style as an instance of
CSSMutableStyleDeclaration.

No new tests are added since this is a refactoring.

editing/EditingStyle.cpp: (WebCore::EditingStyle::textDirection): Extracted from Editor::textDirectionForSelection. (WebCore::EditingStyle::removeStyleConflictingWithStyleOfNode): Added a missing null check. (WebCore::EditingStyle::prepareToApplyAt): See above. (WebCore::editingStyleIncludingTypingStyle): Calls SelectionController::typingStyle.
editing/EditingStyle.h: Moved WritingDirection from Editor.h
editing/Editor.cpp: (WebCore::Editor::textDirectionForSelection): Calls EditingStyle::textDirection. (WebCore::Editor::computeAndSetTypingStyle): Calls SelectionController::typingStyle. (WebCore::Editor::selectionComputedStyle): Ditto. (WebCore::Editor::styleForSelectionStart): Ditto.
editing/Editor.h:
editing/InsertLineBreakCommand.cpp: (WebCore::InsertLineBreakCommand::doApply): Ditto.
editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::input): Calls EditingStyle::prepareToApplyAt with PreserveWritingDirection.
editing/SelectionController.h: (WebCore::SelectionController::typingStyle): Returns EditingStyle* rather than CSSMutableStyleDeclaration*. (WebCore::SelectionController::copyTypingStyle): Added.

16:18 Changeset [72572] by paroga@webkit.org

2010-11-22 Patrick Gansterer <paroga@webkit.org>

Reviewed by Adam Roben.

[WINCE] Set correct preprocessor definitions
https://bugs.webkit.org/show_bug.cgi?id=49887

wtf/Platform.h:

2010-11-22 Patrick Gansterer <paroga@webkit.org>

Reviewed by Adam Roben.

[WINCE] Set correct preprocessor definitions
https://bugs.webkit.org/show_bug.cgi?id=49887

config.h:

15:57 Changeset [72571] by aroben@apple.com

Update Windows 7 results for two tests

Windows 7 uses different fonts from Windows XP on these tests (and even
has a font that can render the inverted nun in bidi-mirror-he-ar.html).

platform/win/fast/text/international/bidi-mirror-he-ar-expected.checksum:
platform/win/fast/text/international/bidi-mirror-he-ar-expected.png:
platform/win/fast/text/international/bidi-mirror-he-ar-expected.txt:
platform/win/fast/text/international/bold-bengali-expected.checksum: Added.
platform/win/fast/text/international/bold-bengali-expected.png: Added.
platform/win/fast/text/international/bold-bengali-expected.txt:

15:38 Changeset [72570] by aroben@apple.com

Update Windows 7 results for fast/text/international/complex-character-based-fallback.html

platform/win/fast/text/international/complex-character-based-fallback-expected.checksum: Added.
platform/win/fast/text/international/complex-character-based-fallback-expected.png: Added.
platform/win/fast/text/international/complex-character-based-fallback-expected.txt:

15:27 Changeset [72569] by aroben@apple.com

Update Windows XP results for fast/text/international/complex-character-based-fallback.html after r72173

The existing pixel results were XP-specific so I moved them into
LayoutTests/platform/win-xp.

platform/win-xp/fast/text/international/complex-character-based-fallback-expected.checksum: Added.
platform/win-xp/fast/text/international/complex-character-based-fallback-expected.png: Added.
platform/win-xp/fast/text/international/complex-character-based-fallback-expected.txt:
platform/win/fast/text/international/complex-character-based-fallback-expected.checksum: Removed.
platform/win/fast/text/international/complex-character-based-fallback-expected.png: Removed.

15:21 Changeset [72568] by aroben@apple.com

Update Windows results after r72552

platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
platform/win/fast/dom/prototype-inheritance-expected.txt:

15:04 Changeset [72567] by jamesr@google.com

2010-11-22 James Robinson <jamesr@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] font-size:0 text runs should have zero width
https://bugs.webkit.org/show_bug.cgi?id=49871

Expands test to check width in addition to height.

fast/text/font-size-zero-expected.txt:
fast/text/font-size-zero.html:
fast/text/script-tests/font-size-zero.js:

2010-11-22 James Robinson <jamesr@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] font-size:0 text runs should have zero width
https://bugs.webkit.org/show_bug.cgi?id=49871

Returns 0 from platformWidthForGlyph if the specified font size is 0.

Test: fast/text/font-size-zero.html

platform/graphics/chromium/SimpleFontDataChromiumWin.cpp: (WebCore::SimpleFontData::platformWidthForGlyph):
platform/graphics/chromium/SimpleFontDataLinux.cpp: (WebCore::SimpleFontData::platformWidthForGlyph):

15:01 Changeset [72566] by commit-queue@webkit.org

2010-11-22 Charlie Reis <creis@chromium.org>

Reviewed by Darin Fisher.

Update correct content state during back/forward navigations
https://bugs.webkit.org/show_bug.cgi?id=48809

Test that we update content state when leaving a form in a subframe.

fast/history/saves-state-after-frame-nav.html:
fast/history/saves-state-after-frame-nav-expected.txt:
fast/history/resources/subframe-with-form.html:

2010-11-22 Charlie Reis <creis@chromium.org>

Reviewed by Darin Fisher.

Update correct content state during back/forward navigations
https://bugs.webkit.org/show_bug.cgi?id=48809

Ensures that history's previousItem is non-null when clients try to
update content state (e.g., Chromium's UpdateSessionHistory). We now
track load completions with a boolean field rather than by clearing
previousItem.

Test: fast/history/saves-state-after-frame-nav.html

loader/HistoryController.cpp:
loader/HistoryController.h:

14:59 Changeset [72565] by jparent@chromium.org

Unreviewed. Add flaky crash expectation for fast/files/revoke-blob-url.html on mac debug.

platform/chromium/test_expectations.txt:

14:52 Changeset [72564] by hayato@chromium.org

2010-11-22 Hayato Ito <hayato@chromium.org>

Reviewed by Shinichiro Hamaji.

Ignore reference files which will be used by reftests when collecting
test cases.
https://bugs.webkit.org/show_bug.cgi?id=49835

Scripts/webkitpy/layout_tests/port/test_files.py:
Scripts/webkitpy/layout_tests/port/test_files_unittest.py:

14:45 Changeset [72563] by aroben@apple.com

Update Windows results for transforms/2d/hindi-rotated.html after r72173

The existing pixel results were XP-specific so I moved them to
LayoutTests/platform/win-xp.

platform/win-xp/transforms/2d/hindi-rotated-expected.checksum: Added.
platform/win-xp/transforms/2d/hindi-rotated-expected.png: Added.
platform/win-xp/transforms/2d/hindi-rotated-expected.txt:
platform/win/transforms/2d/hindi-rotated-expected.checksum:
platform/win/transforms/2d/hindi-rotated-expected.png:
platform/win/transforms/2d/hindi-rotated-expected.txt:

14:40 Changeset [72562] by rniwa@webkit.org

2010-11-22 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed rebaseline for Chromium.

Removed the erroneous expected result for editing/deleting/5168598.html on chromium linux.

platform/chromium-linux/editing/deleting/5168598-expected.txt: Removed.
platform/chromium/test_expectations.txt: Removed editing/deleting/5168598.html.

14:33 QtWebKitFeatures21 edited by ademar.reis@openbossa.org

adding (partial) list of fixes (diff)

14:24 Changeset [72561] by ossy@webkit.org

Unreviewed. Update GTK and Mac specific expected results after r72552.

fast/dom/Window/window-properties-expected.txt:
fast/dom/prototype-inheritance-expected.txt:
platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
platform/gtk/fast/dom/prototype-inheritance-expected.txt:

14:15 Changeset [72560] by tony@chromium.org

2010-11-22 Tony Chang <tony@chromium.org>

Unreviewed, roll Chromium DEPS to r67004.

DEPS:

14:05 Changeset [72559] by weinig@apple.com

Update WebKit2 skipped list.

platform/mac-wk2/Skipped:

14:01 Changeset [72558] by jamesr@google.com

Revert code changes of WebKit r67261 on the 552 branch BUG=56150 TBR=pkasting

14:01 Changeset [72557] by luiz@webkit.org

2010-11-22 Luiz Agostini <luiz.agostini@openbossa.org>

Unreviewed, Windows build fix.

Adding JSMediaQueryList to DerivedSources.cpp.

DerivedSources.cpp:

13:53 Changeset [72556] by ossy@webkit.org

Unreviewed. Update Qt specific expected results after r72552.

platform/qt/fast/dom/Window/window-properties-expected.txt:
platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
platform/qt/fast/dom/prototype-inheritance-expected.txt:

13:38 QtWebKitContrib edited by ademar.reis@openbossa.org

(diff)

13:21 Changeset [72555] by aroben@apple.com

Use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops files

Apple's Windows build allows placing header files and import libraries for WebKit's
dependencies (CoreGraphics, CFNetwork, SQLite, etc.) outside the source tree via the
$WebKitLibrariesDir environment variable. This is both required for production builds and
convenient for Apple-internal developer builds. Apple's production builds also require that
WebKit's shared .vsprops files be accessed relative to $WebKitLibrariesDir. In production
builds, the files are copied into that directory tree by the
WebKitLibraries/win/tools/WinTools.make file. In Apple-internal developer builds, the
copying is done by
JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make.

This .vsprops copying is problematic in one very important case: when a developer updates
their source tree and then tries to build. Visual Studio only reads .vsprops files when a
project is first loaded. So, when Visual Studio is first opened after the .vsprops files are
updated, it reads in the old files that were already residing in $WebKitLibrariesDir. When a
build is started, JavaScriptCoreGenerated.make copies the new .vsprops files into
$WebKitLibrariesDir, but Visual Studio will not pick up the changes. The rest of the build
will proceed with out-of-date .vsprops files, which will likely result in a build failure.

To fix this, we now use normal relative paths to access the .vsprops files in the source
tree rather than in $WebKitLibrariesDir, but prefix those paths with a new environment
variable, $WebKitVSPropsRedirectionDir. In developer builds, this environment variable is
unset, so the normal relative paths are used to read the .vsprops files out of the source
tree directly. In production builds, this environment variable is set to a fake directory
that will cause the .vsprops files in $WebKitLibrariesDir to be found when the relative path
is resolved.

For example, JavaScriptCore.vcproj uses this path for FeatureDefines.vsprops:

$(WebKitVSPropsRedirectionDir)..\..\..\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops

In developer builds, where $WebKitVSPropsRedirectionDir is unset, this will point to the
files in WebKitLibraries\win\tools\vsprops in the source tree. In production builds,
JavaScriptCore.make sets $WebKitVSPropsRedirectionDir to
"$(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\1\2\3\", so the full path for
FeatureDefines.vsprops becomes:

$(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\1\2\3\..\..\..\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops

which resolves to:

$(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops

(We rely on the fact that Windows doesn't care whether the directories "1", "2", and "3"
actually exist since they are matched by an equal number of ".." path components.)

Note that Visual Studio still won't pick up changes made to .vsprops files while Visual
Studio is open, but that problem hasn't seemed to cause developers many headaches so far.

Fixes <http://webkit.org/b/49181> Windows build fails mysteriously when .vsprops files are
updated

Reviewed by Dave Hyatt.

JavaScriptCore:

JavaScriptCore.vcproj/JavaScriptCore.make: Set $WebKitVSPropsRedirectionDir so that

production builds can find the .vsprops files.

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make: Stopy copying the

.vsprops files. It isn't needed anymore.

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
JavaScriptCore.vcproj/WTF/WTF.vcproj:
JavaScriptCore.vcproj/jsc/jsc.vcproj:
JavaScriptCore.vcproj/testapi/testapi.vcproj: