Timeline


and

11/23/10:

22:35 Changeset [72646] by paroga@webkit.org

2010-11-23 Patrick Gansterer <paroga@webkit.org>

Reviewed by David Levin.

Add WebKit2 VisualStudio files to .gitattributes
https://bugs.webkit.org/show_bug.cgi?id=49969

  • .gitattributes:
20:44 Changeset [72645] by inferno@chromium.org

2010-11-23 Abhishek Arya <inferno@chromium.org>

Unreviewed.

Drag and drop not working properly. Skipping just like other similar drag
and drop tests. E.g. similar test drag-image-in-about-blank-frame.html.

  • platform/qt/Skipped:
20:14 Changeset [72644] by inferno@chromium.org

2010-11-22 Abhishek Arya <inferno@chromium.org>

Reviewed by Adam Barth.

r71925 broke the chrome new tab page. r71925 blocked drag and drop
of same security origin objects onto themselves if their origin is
marked unique. We need to allow drag and drop in that scenario.
https://bugs.webkit.org/show_bug.cgi?id=49098

Test: http/tests/security/drag-drop-same-unique-origin.html

  • page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::canReceiveDragData):

2010-11-23 Abhishek Arya <inferno@chromium.org>

Reviewed by Adam Barth.

Tests that drag and drop is allowed across the same security origin object,
even if they are marked unique.

  • http/tests/security/drag-drop-same-unique-origin-expected.txt: Added.
  • http/tests/security/drag-drop-same-unique-origin.html: Added.
  • http/tests/security/resources/drag-drop-allowed.html: Added.
16:22 Changeset [72643] by rniwa@webkit.org

2010-11-23 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed update of GTK's skipped list.

Disabled editing/deleting/delete-by-word-001.html and editing/deleting/delete-by-word-002.html
because they require editing delegates dump which haven't been implemented in GTK.

  • platform/gtk/Skipped:
16:19 Changeset [72642] by tony@chromium.org

2010-11-23 Tony Chang <tony@chromium.org>

Unreviewed, [chromium] merge the plugin failures in test_expectations
https://bugs.webkit.org/show_bug.cgi?id=49993

  • platform/chromium/drt_expectations.txt: Remove plugin failures
  • platform/chromium/test_expectations.txt: Move them into this file

with expectations that are valid for either plugin.

16:15 Changeset [72641] by dpranke@chromium.org

2010-11-23 Dirk Pranke <dpranke@chromium.org>

Reviewed by Tony Chang.

This patch cleans up the logic used to shard tests into groups a
bit and adds the --worker-model flag to NRWT. The flag is only
used at the moment to control whether to run single-threaded or
not, but eventually will also allow toggling between threads and
processes.

Also add a minor cleanup with _test_is_slow(), which just
eliminates some repetition and gives slightly better encapsulation.

https://bugs.webkit.org/show_bug.cgi?id=49773

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
16:12 Changeset [72640] by mihaip@chromium.org

2010-11-23 Mihai Parparita <mihaip@chromium.org>

Reviewed by Tony Chang.

Rebaseline server: list current baselines and platforms
https://bugs.webkit.org/show_bug.cgi?id=49991

List existing baselines (with Trac links) for tests.

Add dropdowns for choosing with platform baselines to target (and what
to do with existing ones).

Also fix MockFileSystem.join to behave more like os.path.join (unit
test was ending up with two consecutive slashes in a layout test
path).

  • Scripts/webkitpy/common/system/filesystem_mock.py:
  • Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
  • Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
  • Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
  • Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
  • Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js:
  • Scripts/webkitpy/tool/commands/rebaselineserver.py:
  • Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py: Added.
16:12 Changeset [72639] by inferno@chromium.org

2010-11-23 Cris Neckar <cdn@chromium.org>

Reviewed by Dimitri Glazkov.

Removed unneeded conversions to RenderBlock.
https://bugs.webkit.org/show_bug.cgi?id=49896

Test: fast/css/input-search-table-column-crash.html

  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::adjustControlHeightBasedOnLineHeight):

2010-11-23 Cris Neckar <cdn@chromium.org>

Reviewed by Dimitri Glazkov.

Test for crash with input type search and table column style.
https://bugs.webkit.org/show_bug.cgi?id=49896

  • fast/css/input-search-table-column-crash-expected.txt: Added.
  • fast/css/input-search-table-column-crash.html: Added.
15:59 Changeset [72638] by rniwa@webkit.org

2010-11-23 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Adam Barth.

XMLDocumentParser::notifyFinished calls ScriptController's executeScript without updating isEvaluated flag
https://bugs.webkit.org/show_bug.cgi?id=49701

Fixed the bug by calling ScriptElement's executeScript, which sets isEvaluated flag to true.

Test: fast/dom/script-clone-rerun-src.xhtml

  • dom/XMLDocumentParser.cpp: (WebCore::XMLDocumentParser::notifyFinished):

2010-11-23 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Adam Barth.

XMLDocumentParser::notifyFinished calls ScriptController's executeScript without updating isEvaluated flag
https://bugs.webkit.org/show_bug.cgi?id=49701

Added a test to ensure WebKit doesn't run the script twice when a script element with an external script file
is cloned in a XML document.

  • fast/dom/resources/script-clone-rerun-src.js: Added.
  • fast/dom/script-clone-rerun-src.xhtml: Added.
15:39 Changeset [72637] by rniwa@webkit.org

2010-11-23 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Tony Chang.

dumpAsText conversion: editing/deleting/delete-by-word-001.html and delete-by-word-002.html
https://bugs.webkit.org/show_bug.cgi?id=48130

Converted editing/deleting/delete-by-word-001.html and delete-by-word-002.html to dumpAsText tests
by replacing calls to runEditingTest by runDumpAsTextEditingTest.

  • editing/deleting/delete-by-word-001-expected.txt: Added.
  • editing/deleting/delete-by-word-001.html:
  • editing/deleting/delete-by-word-002-expected.txt: Added.
  • editing/deleting/delete-by-word-002.html:
  • platform/chromium-linux/editing/deleting/delete-by-word-001-expected.checksum: Removed.
  • platform/chromium-linux/editing/deleting/delete-by-word-001-expected.png: Removed.
  • platform/chromium-linux/editing/deleting/delete-by-word-002-expected.checksum: Removed.
  • platform/chromium-linux/editing/deleting/delete-by-word-002-expected.png: Removed.
  • platform/chromium-win/editing/deleting/delete-by-word-001-expected.checksum: Removed.
  • platform/chromium-win/editing/deleting/delete-by-word-001-expected.png: Removed.
  • platform/chromium-win/editing/deleting/delete-by-word-001-expected.txt: Removed.
  • platform/chromium-win/editing/deleting/delete-by-word-002-expected.checksum: Removed.
  • platform/chromium-win/editing/deleting/delete-by-word-002-expected.png: Removed.
  • platform/chromium-win/editing/deleting/delete-by-word-002-expected.txt: Removed.
  • platform/gtk/editing/deleting/delete-by-word-001-expected.txt: Removed.
  • platform/mac/editing/deleting/delete-by-word-001-expected.checksum: Removed.
  • platform/mac/editing/deleting/delete-by-word-001-expected.png: Removed.
  • platform/mac/editing/deleting/delete-by-word-001-expected.txt: Removed.
  • platform/mac/editing/deleting/delete-by-word-002-expected.checksum: Removed.
  • platform/mac/editing/deleting/delete-by-word-002-expected.png: Removed.
  • platform/mac/editing/deleting/delete-by-word-002-expected.txt: Removed.
  • platform/qt/editing/deleting/delete-by-word-001-expected.checksum: Removed.
  • platform/qt/editing/deleting/delete-by-word-001-expected.png: Removed.
  • platform/qt/editing/deleting/delete-by-word-001-expected.txt: Removed.
  • platform/qt/editing/deleting/delete-by-word-002-expected.checksum: Removed.
  • platform/qt/editing/deleting/delete-by-word-002-expected.png: Removed.
  • platform/qt/editing/deleting/delete-by-word-002-expected.txt: Removed.
15:39 Changeset [72636] by ojan@chromium.org

2010-11-23 Ojan Vafai <ojan@chromium.org>

Reviewed by Tony Chang.

remove timeout argument to urlopen
https://bugs.webkit.org/show_bug.cgi?id=49995

Apparently the version of python we have on the bots doesn't accept a timeout argument.

  • Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
15:36 Changeset [72635] by commit-queue@webkit.org

2010-11-23 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r72628.
http://trac.webkit.org/changeset/72628
https://bugs.webkit.org/show_bug.cgi?id=49994

This patch is causing layout-test failtures on GTK Linux
64-bit Debug (Requested by ctguil on #webkit).

  • accessibility/iframe-has-document-expected.txt: Removed.
  • accessibility/iframe-has-document.html: Removed.
  • platform/win/Skipped:

2010-11-23 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r72628.
http://trac.webkit.org/changeset/72628
https://bugs.webkit.org/show_bug.cgi?id=49994

This patch is causing layout-test failtures on GTK Linux
64-bit Debug (Requested by ctguil on #webkit).

  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::renderParentObject): (WebCore::AccessibilityRenderObject::addChildren):
  • accessibility/AccessibilityRenderObject.h:
  • accessibility/chromium/AccessibilityObjectChromium.cpp: (WebCore::AccessibilityObject::accessibilityIgnoreAttachment):

2010-11-23 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r72628.
http://trac.webkit.org/changeset/72628
https://bugs.webkit.org/show_bug.cgi?id=49994

This patch is causing layout-test failtures on GTK Linux
64-bit Debug (Requested by ctguil on #webkit).

  • public/WebAccessibilityObject.h:
  • src/WebAccessibilityObject.cpp: (WebKit::WebAccessibilityObject::parentObject):

2010-11-23 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r72628.
http://trac.webkit.org/changeset/72628
https://bugs.webkit.org/show_bug.cgi?id=49994

This patch is causing layout-test failtures on GTK Linux
64-bit Debug (Requested by ctguil on #webkit).

  • DumpRenderTree/chromium/AccessibilityUIElement.cpp: (AccessibilityUIElement::AccessibilityUIElement): (AccessibilityUIElement::parentElementCallback):
  • DumpRenderTree/chromium/AccessibilityUIElement.h:
  • DumpRenderTree/chromium/CppBoundClass.cpp:
  • DumpRenderTree/chromium/CppBoundClass.h:
15:15 Changeset [72634] by xan@webkit.org

WebCore:

2010-11-23 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Fix IFrame DOM bindings API
https://bugs.webkit.org/show_bug.cgi?id=49980

Fix IFrame API naming. It needs special casing because of the two
consecutive capital letters.

  • bindings/scripts/CodeGeneratorGObject.pm:

WebKit/gtk:

2010-11-23 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Fix IFrame DOM bindings API
https://bugs.webkit.org/show_bug.cgi?id=49980

  • tests/testdomdocument.c: (test_dom_document_garbage_collection): change to use the fixed IFrame APIs.
14:59 Changeset [72633] by ojan@chromium.org

2010-11-22 Ojan Vafai <ojan@chromium.org>

Reviewed by Tony Chang.

speculative fix for upload errors: stop using mechanize to upload to test-results.appspot.com
https://bugs.webkit.org/show_bug.cgi?id=49944

  • Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
14:55 Changeset [72632] by jparent@chromium.org

Unreviewed, fixing chromium gpu_test expectations.

Remove entries for tests that no longer exist, removed in r71822.
Remove duplicates introduced in r72613.

  • platform/chromium-gpu/test_expectations.txt:
14:54 Changeset [72631] by commit-queue@webkit.org

2010-11-23 Shimeng (Simon) Wang <swang@google.com>

Reviewed by Steve Block.

Use platform bridge to set scroll position.
https://bugs.webkit.org/show_bug.cgi?id=49550

Refactoring only. Existing tests shall suffice.

  • platform/android/PlatformBridge.h:
  • platform/android/ScrollViewAndroid.cpp: (WebCore::ScrollView::platformSetScrollPosition):
14:51 Changeset [72630] by commit-queue@webkit.org

2010-11-23 Andreas Kling <kling@webkit.org>

Reviewed by Tor Arne Vestbø.

[Qt] Selecting shadowed text causes rendering artifacts
https://bugs.webkit.org/show_bug.cgi?id=49990

When selecting text starting from the end of a word, we need to use
the X coordinate of the start of the substring when calculating the
bounding rect for a ContextShadow.

  • platform/graphics/qt/FontQt.cpp: (WebCore::drawTextCommon):
14:43 Changeset [72629] by crogers@google.com

2010-11-23 Chris Rogers <crogers@google.com>

Unreviewed.

Disable new XMLHttpRequest layout tests for Qt and gtk since they require ArrayBuffer support
https://bugs.webkit.org/show_bug.cgi?id=49992

  • platform/gtk/Skipped:
  • platform/qt/Skipped:
14:33 Changeset [72628] by commit-queue@webkit.org

2010-11-23 Chris Guillory <chris.guillory@google.com>

Reviewed by Dimitri Glazkov.

Include the FrameView widget of a RenderWidget in the accessibility tree.
https://bugs.webkit.org/show_bug.cgi?id=49106

  • accessibility/iframe-has-document-expected.txt: Added.
  • accessibility/iframe-has-document.html: Added.
  • platform/win/Skipped:

2010-11-23 Chris Guillory <chris.guillory@google.com>

Reviewed by Dimitri Glazkov.

Include the FrameView widget of a RenderWidget in the accessibility tree.
https://bugs.webkit.org/show_bug.cgi?id=49106

Include render widget children in the accessibility tree for not mac webkit ports.

Test: accessibility/iframe-has-document.html

  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::renderParentObject): (WebCore::AccessibilityRenderObject::addChildren): (WebCore::AccessibilityRenderObject::addRenderWidgetChildren):
  • accessibility/AccessibilityRenderObject.h:
  • accessibility/chromium/AccessibilityObjectChromium.cpp: (WebCore::AccessibilityObject::accessibilityIgnoreAttachment):

2010-11-23 Chris Guillory <chris.guillory@google.com>

Reviewed by Dimitri Glazkov.

Include the FrameView widget of a RenderWidget in the accessibility tree.
https://bugs.webkit.org/show_bug.cgi?id=49106

  • public/WebAccessibilityObject.h:
  • src/WebAccessibilityObject.cpp: (WebKit::WebAccessibilityObject::equals): (WebKit::WebAccessibilityObject::parentObject):

2010-11-23 Chris Guillory <chris.guillory@google.com>

Reviewed by Dimitri Glazkov.

Include the FrameView widget of a RenderWidget in the accessibility tree.
https://bugs.webkit.org/show_bug.cgi?id=49106

  • DumpRenderTree/chromium/AccessibilityUIElement.cpp: (AccessibilityUIElement::AccessibilityUIElement): (AccessibilityUIElement::parentElementCallback): (AccessibilityUIElement::isEqualCallback):
  • DumpRenderTree/chromium/AccessibilityUIElement.h:
  • DumpRenderTree/chromium/CppBoundClass.cpp: (CppBoundClass::getFromCppVariant):
  • DumpRenderTree/chromium/CppBoundClass.h:
14:00 Changeset [72627] by tony@chromium.org

2010-11-23 Tony Chang <tony@chromium.org>

Reviewed by Ojan Vafai.

[chromium] update plugin expectations
https://bugs.webkit.org/show_bug.cgi?id=49988

  • platform/chromium/drt_expectations.txt: These tests are passing on the bot
  • platform/chromium/test_expectations.txt: Group and sort alphabetically
13:51 Changeset [72626] by crogers@google.com

2010-11-23 Chris Rogers <crogers@google.com>

Reviewed by Alexey Proskuryakov.

Add .responseType and .response to XMLHttpRequest
https://bugs.webkit.org/show_bug.cgi?id=49633

Tests: fast/xmlhttprequest/xmlhttprequest-responsetype-abort.html

fast/xmlhttprequest/xmlhttprequest-responsetype-arraybuffer.html
fast/xmlhttprequest/xmlhttprequest-responsetype-document.html
fast/xmlhttprequest/xmlhttprequest-responsetype-text.html

  • bindings/js/JSXMLHttpRequestCustom.cpp: (WebCore::JSXMLHttpRequest::markChildren): (WebCore::JSXMLHttpRequest::open): (WebCore::JSXMLHttpRequest::response):
  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp: (WebCore::V8XMLHttpRequest::responseAccessorGetter):
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::XMLHttpRequest): (WebCore::XMLHttpRequest::responseText): (WebCore::XMLHttpRequest::responseXML): (WebCore::XMLHttpRequest::responseBlob): (WebCore::XMLHttpRequest::responseArrayBuffer): (WebCore::XMLHttpRequest::setResponseType): (WebCore::XMLHttpRequest::responseType): (WebCore::XMLHttpRequest::setAsBlob): (WebCore::XMLHttpRequest::open): (WebCore::XMLHttpRequest::clearResponse): (WebCore::XMLHttpRequest::didFinishLoading): (WebCore::XMLHttpRequest::didReceiveData):
  • xml/XMLHttpRequest.h: (WebCore::XMLHttpRequest::asBlob): (WebCore::XMLHttpRequest::optionalResponseXML): (WebCore::XMLHttpRequest::optionalResponseBlob): (WebCore::XMLHttpRequest::responseTypeCode): (WebCore::XMLHttpRequest::optionalResponseArrayBuffer):
  • xml/XMLHttpRequest.idl:

2010-11-23 Chris Rogers <crogers@google.com>

Reviewed by Alexey Proskuryakov.

Add .responseType and .response to XMLHttpRequest
https://bugs.webkit.org/show_bug.cgi?id=49633

  • fast/xmlhttprequest/xmlhttprequest-responsetype-abort-expected.txt: Added.
  • fast/xmlhttprequest/xmlhttprequest-responsetype-abort.html: Added.
  • fast/xmlhttprequest/xmlhttprequest-responsetype-arraybuffer-expected.txt: Added.
  • fast/xmlhttprequest/xmlhttprequest-responsetype-arraybuffer.html: Added.
  • fast/xmlhttprequest/xmlhttprequest-responsetype-document-expected.txt: Added.
  • fast/xmlhttprequest/xmlhttprequest-responsetype-document.html: Added.
  • fast/xmlhttprequest/xmlhttprequest-responsetype-text-expected.txt: Added.
  • fast/xmlhttprequest/xmlhttprequest-responsetype-text.html: Added.
  • http/tests/resources/balls-of-the-orient.aif: Added.
13:34 Changeset [72625] by inferno@chromium.org

2010-11-23 Abhishek Arya <inferno@chromium.org>

Reviewed by Adam Barth.

dispatchEvent call in EventSource endRequest can lead to calling endRequest
again which frees up the pending activity. Make sure we have request in flight
to prevent that from happening.
https://bugs.webkit.org/show_bug.cgi?id=49448

Test: http/tests/eventsource/eventsource-status-error-iframe-crash.html

  • page/EventSource.cpp: (WebCore::EventSource::endRequest): (WebCore::EventSource::close):

2010-11-23 Abhishek Arya <inferno@chromium.org>

Reviewed by Adam Barth.

Tests that we do not crash on EventSource status errors inside an iframe.
https://bugs.webkit.org/show_bug.cgi?id=49448

  • http/tests/eventsource/eventsource-status-error-iframe-crash-expected.txt: Added.
  • http/tests/eventsource/eventsource-status-error-iframe-crash.html: Added.
  • http/tests/eventsource/resources/request-status-error.htm: Added.
13:30 Changeset [72624] by commit-queue@webkit.org

2010-11-23 John Knottenbelt <jknotten@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Introduce wrapper types for WebCore::GeolocationError, WebCore::GeolocationPosition.
https://bugs.webkit.org/show_bug.cgi?id=49735

Introduce WebKit API types so that the browser implementation can feed
position and error updates to the WebCore::GeolocationController.

  • WebKit.gyp:
  • public/WebGeolocationError.h: Added. (WebKit::WebGeolocationError::WebGeolocationError): (WebKit::WebGeolocationError::~WebGeolocationError):
  • public/WebGeolocationPosition.h: Added. (WebKit::WebGeolocationPosition::WebGeolocationPosition): (WebKit::WebGeolocationPosition::~WebGeolocationPosition):
  • src/WebGeolocationError.cpp: Added. (WebKit::WebGeolocationError::assign): (WebKit::WebGeolocationError::reset): (WebKit::WebGeolocationError::WebGeolocationError): (WebKit::WebGeolocationError::operator=): (WebKit::WebGeolocationError::operator WTF::PassRefPtr<WebCore::GeolocationError>):
  • src/WebGeolocationPosition.cpp: Added. (WebKit::WebGeolocationPosition::assign): (WebKit::WebGeolocationPosition::reset): (WebKit::WebGeolocationPosition::operator=): (WebKit::WebGeolocationPosition::operator PassRefPtr<WebCore::GeolocationPosition>):
13:07 Changeset [72623] by commit-queue@webkit.org

2010-11-23 Jonathan Backer <backer@chromium.org>

Reviewed by Kenneth Russell.

Renderer is resizing IOSurfaces when accelerated compositing is disabled.
https://bugs.webkit.org/show_bug.cgi?id=49827

  • IOSurfaces are only presented when accelerated compositing is enabled.
  • Slight performance increase (and clean-up for using this path for Linux and Windows).
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::resize):
12:50 Changeset [72622] by jparent@chromium.org

2010-11-23 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r72618.
http://trac.webkit.org/changeset/72618
https://bugs.webkit.org/show_bug.cgi?id=49987

"Newly added test is failing on Chromium-linux, patch author
said to rollout" (Requested by jparent on #webkit).

  • editing/EditingBehavior.h:
  • page/EventHandler.cpp: (WebCore::EventHandler::sendContextMenuEvent):

2010-11-23 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r72618.
http://trac.webkit.org/changeset/72618
https://bugs.webkit.org/show_bug.cgi?id=49987

"Newly added test is failing on Chromium-linux, patch author
said to rollout" (Requested by jparent on #webkit).

  • editing/selection/context-menu-text-selection-expected.txt: Removed.
  • editing/selection/context-menu-text-selection.html: Removed.
12:40 Changeset [72621] by mrobinson@webkit.org

2010-11-23 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

focus issue with links that have tooltips
https://bugs.webkit.org/show_bug.cgi?id=49498

Set the area of the widget where the tooltip should be shown when
a new tooltip is set. Since the widget is the same (the view), if
the tooltip area is not set and a new tooltip is triggered while
the previous one is still visible, the text of the tooltip is
updated but its position doesn't change.

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::mouseDidMoveOverElement):
  • webkit/webkitprivate.h:
  • webkit/webkitwebview.cpp: (webkit_web_view_query_tooltip):
12:33 Changeset [72620] by commit-queue@webkit.org

2010-11-23 Grace Kloba <klobag@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Accumulated scroll damage rect should be in the content space
https://bugs.webkit.org/show_bug.cgi?id=49842

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::scrollRootLayerRect): Adjust the previous scroll damage with the scroll delta before union it with the new damage rect.
12:14 Changeset [72619] by jparent@chromium.org

Unreviewed, fixing chromium baselines.
Adding back baselines that were removed in r72542 due to r72527, because
r72527 was rolled ou in r72582.

  • platform/chromium-mac/fast/lists/001-vertical-expected.checksum:
  • platform/chromium-mac/fast/lists/001-vertical-expected.png:
11:33 Changeset [72618] by commit-queue@webkit.org

2010-11-23 Avi Drissman <avi@google.com>

Reviewed by Antonio Gomes.

Add preference to not select when right-clicked
https://bugs.webkit.org/show_bug.cgi?id=23351

  • editing/selection/context-menu-text-selection-expected.txt: Added.
  • editing/selection/context-menu-text-selection.html: Added.

2010-11-23 Avi Drissman <avi@google.com>

Reviewed by Antonio Gomes.

Add preference to not select when right-clicked
https://bugs.webkit.org/show_bug.cgi?id=23351

Test: editing/selection/context-menu-text-selection.html

  • editing/EditingBehavior.h: (WebCore::EditingBehavior::shouldSelectOnContextualMenuClick):
  • page/EventHandler.cpp: (WebCore::EventHandler::sendContextMenuEvent):
11:02 Changeset [72617] by commit-queue@webkit.org

2010-11-23 Alex Grilo <abgrilo@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Add tiled backing store to EWebLauncher
https://bugs.webkit.org/show_bug.cgi?id=45777

Allow EWebLauncher to choose between single and tiled backing store

  • EWebLauncher/main.c: (on_key_down): (browserCreate): (main):
10:35 Changeset [72616] by darin@chromium.org

2010-11-18 Darin Fisher <darin@chromium.org>

Reviewed by Dimitri Glazkov.

Add a mechanism for creating a WebURLLoader that is associated with a
particular WebFrame.
https://bugs.webkit.org/show_bug.cgi?id=49764

This will be used by code that calls webKitClient()->createURLLoader()
from within the Chromium source tree.

An associated WebURLLoader should be treated like a subresource of the
WebFrame's document.

  • WebKit.gyp:
  • public/WebFrame.h:
  • src/AssociatedURLLoader.cpp: Added. (WebKit::AssociatedURLLoader::AssociatedURLLoader): (WebKit::AssociatedURLLoader::~AssociatedURLLoader): (WebKit::AssociatedURLLoader::loadSynchronously): (WebKit::AssociatedURLLoader::loadAsynchronously): (WebKit::AssociatedURLLoader::cancel): (WebKit::AssociatedURLLoader::setDefersLoading): (WebKit::AssociatedURLLoader::PrepareRequest):
  • src/AssociatedURLLoader.h: Added.
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::createAssociatedURLLoader):
  • src/WebFrameImpl.h:
10:31 Changeset [72615] by apavlov@chromium.org

2010-11-23 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [STYLES] invalid color values are not marked as such.
https://bugs.webkit.org/show_bug.cgi?id=49960

Properties having a valid structure but invalid values will also
be marked as non-parsedOk in the Styles pane.

WebCore:

  • css/CSSGrammar.y:
  • inspector/InspectorStyleSheet.cpp: (WebCore::InspectorStyle::populateObjectWithStyleProperties):

LayoutTests:

  • inspector/resources/styles-new-API.css: (body):
  • inspector/styles-new-API-expected.txt:
  • inspector/styles-source-offsets-expected.txt:
10:09 WebDevelopers edited by dkeith@apple.com
updated instructions on how to turn on Safari's Develop menu (diff)
09:29 Changeset [72614] by commit-queue@webkit.org

2010-11-23 Adam Bergkvist <adam.bergkvist@ericsson.com>

Reviewed by Martin Robinson.

[GTK] Building with Blob support fails
https://bugs.webkit.org/show_bug.cgi?id=49724

Build fix.

  • GNUmakefile.am:
  • platform/gtk/FileSystemGtk.cpp: (WebCore::seekFile): Not implemented.
09:18 Changeset [72613] by loislo@chromium.org

2010-11-23 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed. Updated chromium expectations.

Plugin tests were disabled.

MAC : compositing/plugins/1x1-composited-plugin.html = CRASH
MAC : compositing/plugins/composited-plugin.html = CRASH
MAC : compositing/plugins/large-to-small-composited-plugin.html = CRASH
MAC : compositing/plugins/small-to-large-composited-plugin.html = CRASH

  • platform/chromium-gpu/test_expectations.txt:
08:58 Changeset [72612] by andreas.kling@nokia.com

2010-11-23 Kenneth Rohde Christiansen <kenneth@webkit.org>

Reviewed by Andreas Kling.

Adapt to setShouldDelegateScrolling not being a real setting anymore.
We now similarily to setUseFixedLayout and setPaintEntireContents
set it on the FrameView wen transitioning to a new page.

  • Api/qgraphicswebview.cpp: (QGraphicsWebViewPrivate::updateResizesToContentsForPage):
  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::transitionToCommittedForNewPage):

2010-11-23 Kenneth Rohde Christiansen <kenneth@webkit.org>

Reviewed by Andreas Kling.

Make setShouldDelegateScrolling not a real setting, so that it works
similar to the related setUseFixedLayout and setPaintEntireContents
options which are all in ScrollView.

  • page/FrameView.cpp:
  • page/FrameView.h:
  • page/Settings.cpp: (WebCore::Settings::Settings):
  • page/Settings.h:
  • platform/ScrollView.cpp: (WebCore::ScrollView::ScrollView): (WebCore::ScrollView::setDelegatesScrolling):
  • platform/ScrollView.h: (WebCore::ScrollView::delegatesScrolling):

2010-11-23 Kenneth Rohde Christiansen <kenneth@webkit.org>

Reviewed by Andreas Kling.

Adapt to setShouldDelegateScrolling not being a real setting anymore.
We now similarily to setUseFixedLayout and setPaintEntireContents
set it on the FrameView wen transitioning to a new page, etc.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage):
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::setResizesToContentsUsingLayoutSize):
08:54 Changeset [72611] by aroben@apple.com

Don't rely on DocumentLoader outliving the load/unload events

DocumentLoader::m_documentLoadTiming is used to record how long firing
the load event took. But the DocumentLoader was being destroyed while
the event was being dispatched (due to a call to document.open), which
meant that when we tried to record the time when the load event
finished, we were writing into freed memory. We now protect the
DocumentLoader using a RefPtr. (I initially made a change where we
would only access the DocumentLoader after the event has finished
firing, but it seemed possible that a different DocumentLoader could
have come into existence by then, which would cause us to record the
times on the wrong DocumentLoadTiming struct.)

I only saw a crash when firing the load event, but the code for timing
the unload event seemed like it was vulnerable to the same issue, so I
made the same fix for it.

Fixes <http://webkit.org/b/49972> REGRESSION (r72415?): Crash in
DOMWindow::dispatchTimedEvent when running fast/dom/onload-open.html

Reviewed by Darin Fisher.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::stopLoading):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::dispatchLoadEvent):
Protect the DocumentLoader (and thus its DocumentLoadTiming) with a
RefPtr.

08:51 Changeset [72610] by zmo@google.com

2010-11-17 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

readPixels should generate INVALID_ENUM if only one of type/format mismatch UNSIGNED_BYTE/RGBA
https://bugs.webkit.org/show_bug.cgi?id=49673

Test: fast/canvas/webgl/read-pixels-test.html

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::readPixels):

2010-11-17 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

readPixels should generate INVALID_ENUM if only one of type/format mismatch UNSIGNED_BYTE/RGBA
https://bugs.webkit.org/show_bug.cgi?id=49673

  • fast/canvas/webgl/read-pixels-test-expected.txt: Added.
  • fast/canvas/webgl/read-pixels-test.html: Added.
08:19 Changeset [72609] by loislo@chromium.org

2010-11-23 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed. Expectations for chromium were fixed.

  • platform/chromium-gpu/test_expectations.txt:
  • platform/chromium/test_expectations.txt:
07:47 Changeset [72608] by loislo@chromium.org

2010-11-23 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed. Just fixing tipo in test_expectations.txt

  • platform/chromium/test_expectations.txt:
07:34 Changeset [72607] by loislo@chromium.org

2010-11-23 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed. Updating test expectations for chromium.

  • platform/chromium/test_expectations.txt:
07:33 Changeset [72606] by laszlo.1.gombos@nokia.com

2010-11-23 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Fix compilation with !ENABLE(INSPECTOR)
https://bugs.webkit.org/show_bug.cgi?id=49942

Add ENABLE(INSPECTOR) to the Qt specific files following r71981.

  • WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorClientQt::inspectorDestroyed): (WebCore::InspectorClientQt::openInspectorFrontend): (WebCore::InspectorClientQt::sendMessageToFrontend):
  • WebCoreSupport/InspectorServerQt.cpp: (WebCore::InspectorServerRequestHandlerQt::webSocketReadyRead):
07:02 BuildingQtOnLinux edited by benjamin.poulain@nokia.com
SQLite takes only one 'L' (diff)
07:01 Changeset [72605] by loislo@chromium.org

2010-11-23 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed. Adjusting expectations for chromium.

  • platform/chromium/test_expectations.txt:
06:52 Changeset [72604] by hausmann@webkit.org

[Qt] Restore binary compatibility with the QtWebKit 2.1 branch

Reviewed by Andreas Kling.

Re-order the enums by adding new enum entries to the end.

  • Api/qwebsettings.h:
06:24 Changeset [72603] by hausmann@webkit.org

[Qt] Review the setUserPermission & friends API
https://bugs.webkit.org/show_bug.cgi?id=46810

Reviewed by Tor Arne Vestbø.

Renamed requestPermissionFromUser to featurePermissionRequested
and cancelRequestsForPermission to featurePermissionRequestCanceled.

WebKit/qt:

  • Api/qwebpage.h:
  • WebCoreSupport/GeolocationPermissionClientQt.cpp:

(WebCore::GeolocationPermissionClientQt::requestGeolocationPermissionForFrame):
(WebCore::GeolocationPermissionClientQt::cancelGeolocationPermissionRequestForFrame):

  • WebCoreSupport/NotificationPresenterClientQt.cpp:

(WebCore::NotificationPresenterClientQt::requestPermission):
(WebCore::NotificationPresenterClientQt::cancelRequestsForPermission):

WebKitTools:

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebCore::WebPage::WebPage):

  • QtTestBrowser/webpage.cpp:

(WebPage::WebPage):
(WebPage::featurePermissionRequestCanceled):

  • QtTestBrowser/webpage.h:
06:23 Changeset [72602] by hausmann@webkit.org

[Qt] Review the setUserPermission & friends API
https://bugs.webkit.org/show_bug.cgi?id=46810

Reviewed by Tor Arne Vestbø.

Rename setUserPermission to setFeaturePermission

WebKit/qt:

  • Api/qwebpage.cpp:

(QWebPage::setFeaturePermission):

  • Api/qwebpage.h:
  • tests/qwebpage/tst_qwebpage.cpp:

(JSTestPage::requestPermission):

WebKitTools:

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebCore::WebPage::requestPermission):
(WebCore::WebPage::permissionSet):

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:

(LayoutTestController::grantDesktopNotificationPermission):

  • QtTestBrowser/webpage.cpp:

(WebPage::requestPermission):

06:23 Changeset [72601] by hausmann@webkit.org

[Qt] Review the setUserPermission & friends API
https://bugs.webkit.org/show_bug.cgi?id=46810

Reviewed by Tor Arne Vestbø.

Rename PermissionDomain to Feature, NotificationsPermissionDomain to Notifications
and GeolocationPermissionDomain to Geolocation.

WebKit/qt:

  • Api/qwebpage.cpp:

(QWebPage::setUserPermission):

  • Api/qwebpage.h:
  • WebCoreSupport/GeolocationPermissionClientQt.cpp:

(WebCore::GeolocationPermissionClientQt::requestGeolocationPermissionForFrame):
(WebCore::GeolocationPermissionClientQt::cancelGeolocationPermissionRequestForFrame):

  • WebCoreSupport/NotificationPresenterClientQt.cpp:

(WebCore::NotificationPresenterClientQt::requestPermission):
(WebCore::NotificationPresenterClientQt::cancelRequestsForPermission):

  • tests/qwebpage/tst_qwebpage.cpp:

(JSTestPage::requestPermission):
(tst_QWebPage::geolocationRequestJS):

WebKitTools:

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebCore::WebPage::WebPage):
(WebCore::WebPage::requestPermission):
(WebCore::WebPage::cancelPermission):
(WebCore::WebPage::permissionSet):
(WebCore::DumpRenderTree::geolocationPermissionSet):

  • DumpRenderTree/qt/DumpRenderTreeQt.h:
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:

(LayoutTestController::grantDesktopNotificationPermission):

  • QtTestBrowser/webpage.cpp:

(WebPage::WebPage):
(WebPage::requestPermission):
(WebPage::cancelRequestsForPermission):

  • QtTestBrowser/webpage.h:
06:22 Changeset [72600] by hausmann@webkit.org

[Qt] Review the setUserPermission & friends API
https://bugs.webkit.org/show_bug.cgi?id=46810

Reviewed by Tor Arne Vestbø.

Add a ByUser suffix to PermissionGranted/Denied. In the future
we can add PermissionGrantedByDefault.

WebKit/qt:

  • Api/qwebpage.cpp:

(QWebPage::setUserPermission):

  • Api/qwebpage.h:
  • WebCoreSupport/GeolocationPermissionClientQt.cpp:

(WebCore::GeolocationPermissionClientQt::setPermission):

  • tests/qwebpage/tst_qwebpage.cpp:

(JSTestPage::requestPermission):

WebKitTools:

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebCore::WebPage::requestPermission):
(WebCore::WebPage::permissionSet):

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:

(LayoutTestController::grantDesktopNotificationPermission):

  • QtTestBrowser/webpage.cpp:

(WebPage::requestPermission):

05:25 Changeset [72599] by loislo@chromium.org

2010-11-23 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed rollout r72534 and r72533 because r72544, r72530 and r72527 were reverted.

  • platform/chromium-linux/css1/box_properties/margin_right-expected.checksum:
  • platform/chromium-linux/css1/box_properties/padding_right-expected.checksum:
  • platform/chromium-linux/css2.1/t0805-c5520-brdr-b-01-e-expected.checksum:
  • platform/chromium-linux/css2.1/t0805-c5520-brdr-b-01-e-expected.txt:
  • platform/chromium-linux/editing/pasteboard/merge-end-list-expected.checksum:
  • platform/chromium-linux/editing/selection/extend-by-word-002-expected.checksum:
  • platform/chromium-linux/fast/css/background-shorthand-invalid-url-expected.checksum:
  • platform/chromium-linux/fast/doctypes/002-expected.checksum:
  • platform/chromium-linux/fast/lists/001-vertical-expected.checksum:
  • platform/chromium-linux/fast/lists/001-vertical-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/lists/001-vertical-expected.txt.
  • platform/chromium-linux/fast/lists/002-expected.checksum:
  • platform/chromium-linux/fast/lists/002-vertical-expected.checksum:
  • platform/chromium-linux/fast/lists/002-vertical-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/lists/002-vertical-expected.txt.
  • platform/chromium-linux/fast/lists/003-expected.checksum:
  • platform/chromium-linux/fast/lists/003-vertical-expected.checksum:
  • platform/chromium-linux/fast/lists/003-vertical-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/lists/003-vertical-expected.txt.
  • platform/chromium-linux/fast/lists/007-vertical-expected.checksum:
  • platform/chromium-linux/fast/lists/007-vertical-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/lists/007-vertical-expected.txt.
  • platform/chromium-linux/fast/lists/008-vertical-expected.checksum:
  • platform/chromium-linux/fast/lists/008-vertical-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/lists/008-vertical-expected.txt.
  • platform/chromium-linux/fast/lists/marker-before-empty-inline-expected.checksum:
  • platform/chromium-linux/fast/lists/outSideListMarkers-expected.checksum: Removed.
  • platform/chromium-mac/css1/box_properties/margin_right-expected.checksum:
  • platform/chromium-mac/css1/box_properties/padding_right-expected.checksum:
  • platform/chromium-mac/css2.1/t0805-c5520-brdr-b-01-e-expected.checksum:
  • platform/chromium-mac/editing/pasteboard/merge-end-list-expected.checksum: Added.
  • platform/chromium-mac/editing/selection/extend-by-word-002-expected.checksum: Added.
  • platform/chromium-mac/fast/css/background-shorthand-invalid-url-expected.checksum: Added.
  • platform/chromium-mac/fast/lists/008-vertical-expected.checksum:
  • platform/chromium-mac/fast/lists/marker-before-empty-inline-expected.checksum: Removed.
  • platform/chromium-win/css1/box_properties/margin_right-expected.checksum:
  • platform/chromium-win/css1/box_properties/margin_right-expected.txt:
  • platform/chromium-win/css1/box_properties/padding_right-expected.checksum:
  • platform/chromium-win/css1/box_properties/padding_right-expected.txt:
  • platform/chromium-win/css2.1/t0805-c5520-brdr-b-01-e-expected.checksum:
  • platform/chromium-win/css2.1/t0805-c5520-brdr-b-01-e-expected.txt:
  • platform/chromium-win/editing/pasteboard/merge-end-list-expected.checksum:
  • platform/chromium-win/editing/pasteboard/merge-end-list-expected.txt:
  • platform/chromium-win/editing/selection/extend-by-word-002-expected.checksum:
  • platform/chromium-win/editing/selection/extend-by-word-002-expected.txt:
  • platform/chromium-win/fast/css/background-shorthand-invalid-url-expected.checksum:
  • platform/chromium-win/fast/css/background-shorthand-invalid-url-expected.txt:
  • platform/chromium-win/fast/doctypes/002-expected.checksum:
  • platform/chromium-win/fast/doctypes/002-expected.txt:
  • platform/chromium-win/fast/lists/001-vertical-expected.checksum:
  • platform/chromium-win/fast/lists/001-vertical-expected.txt:
  • platform/chromium-win/fast/lists/002-expected.checksum:
  • platform/chromium-win/fast/lists/002-expected.txt:
  • platform/chromium-win/fast/lists/002-vertical-expected.checksum:
  • platform/chromium-win/fast/lists/002-vertical-expected.txt:
  • platform/chromium-win/fast/lists/003-expected.checksum:
  • platform/chromium-win/fast/lists/003-expected.txt:
  • platform/chromium-win/fast/lists/003-vertical-expected.checksum:
  • platform/chromium-win/fast/lists/003-vertical-expected.txt:
  • platform/chromium-win/fast/lists/007-vertical-expected.checksum:
  • platform/chromium-win/fast/lists/007-vertical-expected.txt:
  • platform/chromium-win/fast/lists/008-vertical-expected.checksum:
  • platform/chromium-win/fast/lists/008-vertical-expected.txt:
  • platform/chromium-win/fast/lists/marker-before-empty-inline-expected.checksum:
  • platform/chromium-win/fast/lists/marker-before-empty-inline-expected.txt:
  • platform/chromium-win/fast/lists/outSideListMarkers-expected.checksum: Removed.
  • platform/chromium-win/fast/lists/outSideListMarkers-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
05:19 Changeset [72598] by apavlov@chromium.org

2010-11-23 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [STYLES] Use strike through as an 'overridden' marker.
https://bugs.webkit.org/show_bug.cgi?id=49961

"line-through" is used for inactive properties overridden within the same style.

  • inspector/front-end/inspector.css: (.styles-section .properties .overloaded, .styles-section .properties .inactive, .styles-section .properties .disabled):
05:04 Changeset [72597] by satish@chromium.org

2010-11-23 Satish Sampath <satish@chromium.org>

Unreviewed, chromium build fix.

  • public/WebSpeechInputControllerMock.h: (WebKit::WebSpeechInputControllerMock::setMockRecognitionResult):
04:57 Changeset [72596] by yael.aharon@nokia.com

2010-11-23 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Antonio Gomes.

Spatial Navigation: Code cleanup
https://bugs.webkit.org/show_bug.cgi?id=49442

Remove code that is not used anymore after http://trac.webkit.org/changeset/72522.
Added const to canBeScrolledIntoView.
No new tests because this is only code cleanup.

  • page/FocusController.cpp:
  • page/FocusController.h:
  • page/SpatialNavigation.cpp: (WebCore::canBeScrolledIntoView):
  • page/SpatialNavigation.h:
04:48 Changeset [72595] by loislo@chromium.org

2010-11-23 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed.

fast/text/font-size-zero.html was disabled.
It is failing on Mac platform.

https://bugs.webkit.org/show_bug.cgi?id=49967

  • platform/chromium/test_expectations.txt:
03:54 Changeset [72594] by alex@webkit.org

2010-11-23 Alejandro G. Castro <alex@igalia.com>

Unreviewed. Rebaselined
svg-curve-with-relative-cordinates-expected.txt test.

Skipped fast/profiler/throw-exception-from-eval.html, checked in
bug https://bugs.webkit.org/show_bug.cgi?id=49801

Skipped fast/canvas/canvas-fillPath-shadow.html and
fast/canvas/canvas-strokePath-shadow.html until we check if there
is an issue in the gtk shadows or DRT.

  • platform/gtk/Skipped:
  • platform/gtk/svg/custom/svg-curve-with-relative-cordinates-expected.txt:
03:14 Changeset [72593] by jorlow@chromium.org

2010-11-23 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Steve Block.

Remove unimplemented (and untested) methods from IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=49911

  • storage/IDBCursor.idl:
  • storage/IDBDatabase.idl:
02:07 Changeset [72592] by paroga@webkit.org

2010-11-23 Patrick Gansterer <paroga@webkit.org>

Reviewed by Sam Weinig.

Use WTF::StringHasher directly in JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=49893

  • profiler/CallIdentifier.h: (JSC::CallIdentifier::Hash::hash):
  • runtime/Identifier.cpp: (JSC::IdentifierCStringTranslator::hash): (JSC::IdentifierUCharBufferTranslator::hash):
02:01 Changeset [72591] by satish@chromium.org

2010-11-18 Satish Sampath <satish@chromium.org>

Reviewed by Jeremy Orlow.

For speech input event, send an event object containing all the recognition results and metadata.
https://bugs.webkit.org/show_bug.cgi?id=49736

  • fast/speech/input-onspeechchange-event-expected.txt: Added.
  • fast/speech/input-onspeechchange-event.html: New test to check multiple results.
  • fast/speech/input-text-language-tag.html: Updated with new method signature.
  • fast/speech/input-text-speechbutton.html: Ditto.
  • fast/speech/speech-button-ignore-generated-events.html: Ditto.

2010-11-18 Satish Sampath <satish@chromium.org>

Reviewed by Jeremy Orlow.

For speech input event, send an event object containing all the recognition results and metadata.
https://bugs.webkit.org/show_bug.cgi?id=49736

Currently the speech input event 'onwebkitspeechchange' receives no parameters. WebCore already
has the full list of recognition results and populates only the top result into the input field
automatically. In this patch we pass a SpeechInputEvent object to the event handler, and the JS
code can access the full list of results via "event.results.length", "results[i].utterance" and
"results[i].confidence". Also updated mock object with appropriate methods to test multiple results.

Test: fast/speech/input-onspeechchange-event.html

  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSEventCustom.cpp: (WebCore::toJS): Added new event
  • bindings/v8/custom/V8EventCustom.cpp: (WebCore::toV8): Added new event
  • dom/Event.cpp: (WebCore::Event::isSpeechInputEvent):
  • dom/Event.h:
  • html/HTMLInputElement.cpp:
  • html/HTMLInputElement.h:
  • page/SpeechInputEvent.h: New file implementing SpeechInputEvent.idl (WebCore::SpeechInputEvent::~SpeechInputEvent): (WebCore::SpeechInputEvent::create): (WebCore::SpeechInputEvent::isSpeechInputEvent): (WebCore::SpeechInputEvent::results): (WebCore::SpeechInputEvent::SpeechInputEvent):
  • page/SpeechInputEvent.idl: New file defining SpeechInputEvent object
  • page/SpeechInputListener.h:
  • page/SpeechInputResult.cpp: (WebCore::SpeechInputResult::create):
  • page/SpeechInputResult.h:
  • page/SpeechInputResult.idl: New file defining a single SpeechInputResult object
  • page/SpeechInputResultList.h: New file implementing SpeechInputResultList.idl (WebCore::SpeechInputResultList::create): (WebCore::SpeechInputResultList::length): (WebCore::SpeechInputResultList::item): (WebCore::SpeechInputResultList::SpeechInputResultList):
  • page/SpeechInputResultList.idl: New file defining a list of SpeechInputResult objects
  • platform/mock/SpeechInputClientMock.cpp: (WebCore::SpeechInputClientMock::addRecognitionResult): Renamed method and added one parameter. (WebCore::SpeechInputClientMock::clearResults): (WebCore::SpeechInputClientMock::timerFired):
  • platform/mock/SpeechInputClientMock.h:
  • rendering/TextControlInnerElements.cpp: (WebCore::InputFieldSpeechButtonElement::setRecognitionResult): Pass new event object to handler.

2010-11-18 Satish Sampath <satish@chromium.org>

Reviewed by Jeremy Orlow.

For speech input event, send an event object containing all the recognition results and metadata.
https://bugs.webkit.org/show_bug.cgi?id=49736

Updated mock object's method to new signature.

  • public/WebSpeechInputControllerMock.h:
  • src/WebSpeechInputControllerMockImpl.cpp: (WebKit::WebSpeechInputControllerMockImpl::addMockRecognitionResult):
  • src/WebSpeechInputControllerMockImpl.h:

2010-11-18 Satish Sampath <satish@chromium.org>

Reviewed by Jeremy Orlow.

For speech input event, send an event object containing all the recognition results and metadata.
https://bugs.webkit.org/show_bug.cgi?id=49736

Updated DRT by renaming the mock result method on all platforms to the new signature.

  • DumpRenderTree/LayoutTestController.cpp: (addMockSpeechInputResultCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::addMockSpeechInputResult):
  • DumpRenderTree/chromium/LayoutTestController.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::addMockSpeechInputResult):
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::addMockSpeechInputResult):
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::addMockSpeechInputResult):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::addMockSpeechInputResult):
  • DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::addMockSpeechInputResult):
00:55 Changeset [72590] by ap@apple.com

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=49860
CSS style rules don't GC protect objects reachable as their properties

Test: fast/dom/StyleSheet/gc-rule-children-wrappers.html

  • Android.jscbindings.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSBindingsAllInOne.cpp: Added new files, sorted appropriate sections for easier adding.
  • bindings/js/JSCSSFontFaceRuleCustom.cpp: Added. (WebCore::JSCSSFontFaceRule::markChildren):
  • bindings/js/JSCSSImportRuleCustom.cpp: Added. (WebCore::JSCSSImportRule::markChildren):
  • bindings/js/JSCSSMediaRuleCustom.cpp: Added. (WebCore::JSCSSMediaRule::markChildren):
  • bindings/js/JSCSSPageRuleCustom.cpp: Added. (WebCore::JSCSSPageRule::markChildren):
  • bindings/js/JSCSSStyleRuleCustom.cpp: Added. (WebCore::JSCSSStyleRule::markChildren):
  • bindings/js/JSWebKitCSSKeyframeRuleCustom.cpp: Added. (WebCore::JSWebKitCSSKeyframeRule::markChildren):
  • bindings/js/JSWebKitCSSKeyframesRuleCustom.cpp: Added. (WebCore::JSWebKitCSSKeyframesRule::markChildren): Mark objects reachable through these ones.
  • css/CSSFontFaceRule.idl:
  • css/CSSImportRule.idl:
  • css/CSSMediaRule.idl:
  • css/CSSPageRule.idl:
  • css/CSSStyleRule.idl:
  • css/WebKitCSSKeyframeRule.idl:
  • css/WebKitCSSKeyframesRule.idl: Added CustomMarkFunction IDL attribute.
00:43 Changeset [72589] by ossy@webkit.org

Unreviewed revert r72544 and r72530, because r72527 was reverted.

Outside list bullets ignore text-align style.
https://bugs.webkit.org/show_bug.cgi?id=15713

  • platform/gtk/css1/box_properties/margin_right-expected.txt:
  • platform/gtk/css1/box_properties/padding_right-expected.txt:
  • platform/gtk/fast/lists/001-vertical-expected.txt:
  • platform/gtk/fast/lists/002-vertical-expected.txt:
  • platform/gtk/fast/lists/003-vertical-expected.txt:
  • platform/gtk/fast/lists/007-vertical-expected.txt:
  • platform/gtk/fast/lists/008-vertical-expected.txt:
  • platform/gtk/fast/lists/outSideListMarkers-expected.txt: Removed.
  • platform/qt/css1/box_properties/margin_right-expected.checksum: Removed.
  • platform/qt/css1/box_properties/margin_right-expected.png: Removed.
  • platform/qt/css1/box_properties/margin_right-expected.txt:
  • platform/qt/css1/box_properties/padding_right-expected.checksum: Removed.
  • platform/qt/css1/box_properties/padding_right-expected.png: Removed.
  • platform/qt/css1/box_properties/padding_right-expected.txt:
  • platform/qt/editing/pasteboard/merge-end-list-expected.checksum: Removed.
  • platform/qt/editing/pasteboard/merge-end-list-expected.png: Removed.
  • platform/qt/editing/pasteboard/merge-end-list-expected.txt:
  • platform/qt/fast/doctypes/002-expected.checksum: Removed.
  • platform/qt/fast/doctypes/002-expected.png: Removed.
  • platform/qt/fast/doctypes/002-expected.txt:
  • platform/qt/fast/lists/001-vertical-expected.checksum:
  • platform/qt/fast/lists/001-vertical-expected.png:
  • platform/qt/fast/lists/001-vertical-expected.txt:
  • platform/qt/fast/lists/002-vertical-expected.checksum:
  • platform/qt/fast/lists/002-vertical-expected.png:
  • platform/qt/fast/lists/002-vertical-expected.txt:
  • platform/qt/fast/lists/003-vertical-expected.checksum:
  • platform/qt/fast/lists/003-vertical-expected.png:
  • platform/qt/fast/lists/003-vertical-expected.txt:
  • platform/qt/fast/lists/007-vertical-expected.checksum:
  • platform/qt/fast/lists/007-vertical-expected.png:
  • platform/qt/fast/lists/007-vertical-expected.txt:
  • platform/qt/fast/lists/008-vertical-expected.checksum:
  • platform/qt/fast/lists/008-vertical-expected.png:
  • platform/qt/fast/lists/008-vertical-expected.txt:
  • platform/qt/fast/lists/outSideListMarkers-expected.checksum: Removed.
  • platform/qt/fast/lists/outSideListMarkers-expected.png: Removed.
  • platform/qt/fast/lists/outSideListMarkers-expected.txt: Removed.
00:00 Changeset [72588] by commit-queue@webkit.org

2010-11-23 Helder Correia <helder@sencha.com>

Reviewed by Ariya Hidayat.

[Qt] Drawing an image on canvas with shadowBlur draws a solid shadow
https://bugs.webkit.org/show_bug.cgi?id=49878

New test checking solid and blurry shadow on images drawn on canvas.

  • fast/canvas/canvas-drawImage-shadow-expected.txt: Added.
  • fast/canvas/canvas-drawImage-shadow.html: Added.
  • fast/canvas/script-tests/canvas-drawImage-shadow.js: Added.

2010-11-23 Helder Correia <helder@sencha.com>

Reviewed by Ariya Hidayat.

[Qt] Drawing an image on canvas with shadowBlur draws a solid shadow
https://bugs.webkit.org/show_bug.cgi?id=49878

Add support for blurry shadows when drawing images on canvas.

Test: fast/canvas/canvas-drawImage-shadow.html

  • platform/graphics/qt/ContextShadowQt.cpp: (WebCore::ContextShadow::endShadowLayer): Make composition work for solid shadow too.
  • platform/graphics/qt/ImageQt.cpp: (WebCore::BitmapImage::draw): Remove old shadow code and introduce ContextShadow.

11/22/10:

23:44 Changeset [72587] by commit-queue@webkit.org

2010-11-22 Alexey Marinichev <amarinichev@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Implement Extensions3DChromium::getGraphicsResetStatusARB
https://bugs.webkit.org/show_bug.cgi?id=49946

  • public/WebGraphicsContext3D.h: added isContextLost()
  • src/Extensions3DChromium.cpp: (WebCore::Extensions3DChromium::getGraphicsResetStatusARB):
  • src/GraphicsContext3DChromium.cpp: (WebCore::GraphicsContext3DInternal::isContextLost):
  • src/GraphicsContext3DInternal.h:
  • src/WebGraphicsContext3DDefaultImpl.cpp: (WebKit::WebGraphicsContext3DDefaultImpl::isContextLost):
  • src/WebGraphicsContext3DDefaultImpl.h:
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::reallocateRenderer): ensure root layer repaining
22:46 Changeset [72586] by jcivelli@chromium.org

2010-11-22 Jay Civelli <jcivelli@chromium.org>

Reviewed by David Levin.

Don't create an external popup menu when there are no items to show.
https://bugs.webkit.org/show_bug.cgi?id=49937

  • src/ExternalPopupMenu.cpp: (WebKit::ExternalPopupMenu::show):
22:26 Changeset [72585] by paroga@webkit.org

2010-11-22 Patrick Gansterer <paroga@webkit.org>

Reviewed by Adam Roben.

Port ContextMenuWin.cpp to WinCE
https://bugs.webkit.org/show_bug.cgi?id=48408

  • platform/ContextMenu.h:
  • platform/win/ContextMenuWin.cpp: (WebCore::ContextMenu::ContextMenu): (WebCore::ContextMenu::itemCount): (WebCore::insertMenuItem): (WebCore::ContextMenu::insertItem): (WebCore::contextMenuItemByIdOrPosition): (WebCore::ContextMenu::setPlatformDescription): (WebCore::contextMenuItemVector): (WebCore::platformMenuDescription):
22:05 Changeset [72584] by commit-queue@webkit.org

2010-11-22 Nat Duca <nduca@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Send didActivateAcceleratedCompositing when compositor
initializes but does not create the shared context3d.
https://bugs.webkit.org/show_bug.cgi?id=49930

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
21:44 Changeset [72583] by hyatt@apple.com

Back out rebaselines from r72527.

  • platform/mac/css2.1/t0805-c5520-brdr-b-01-e-expected.txt:
  • platform/mac/fast/lists/marker-before-empty-inline-expected.txt:
21:41 Changeset [72582] by hyatt@apple.com

Back out r72527 since it caused multiple rendering regressions. Details in bug.

WebCore:

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::placeBoxesInInlineDirection):

  • rendering/RenderListItem.cpp:

(WebCore::RenderListItem::positionListMarker):

LayoutTests:

  • fast/lists/outSideListMarkers-expected.txt: Removed.
  • fast/lists/outSideListMarkers.html: Removed.
  • platform/mac-leopard/css1/box_properties/margin_right-expected.checksum:
  • platform/mac-leopard/css1/box_properties/margin_right-expected.png:
  • platform/mac-leopard/css1/box_properties/padding_right-expected.checksum:
  • platform/mac-leopard/css1/box_properties/padding_right-expected.png:
  • platform/mac-leopard/editing/pasteboard/merge-end-list-expected.checksum:
  • platform/mac-leopard/editing/pasteboard/merge-end-list-expected.png:
  • platform/mac-leopard/fast/css/background-shorthand-invalid-url-expected.checksum:
  • platform/mac-leopard/fast/css/background-shorthand-invalid-url-expected.png:
  • platform/mac-leopard/fast/css/empty-pseudo-class-expected.checksum:
  • platform/mac-leopard/fast/css/empty-pseudo-class-expected.png:
  • platform/mac-leopard/fast/css/first-child-pseudo-class-expected.checksum:
  • platform/mac-leopard/fast/css/first-child-pseudo-class-expected.png:
  • platform/mac-leopard/fast/css/first-of-type-pseudo-class-expected.checksum:
  • platform/mac-leopard/fast/css/first-of-type-pseudo-class-expected.png:
  • platform/mac-leopard/fast/css/last-child-pseudo-class-expected.checksum:
  • platform/mac-leopard/fast/css/last-child-pseudo-class-expected.png:
  • platform/mac-leopard/fast/css/last-of-type-pseudo-class-expected.checksum:
  • platform/mac-leopard/fast/css/last-of-type-pseudo-class-expected.png:
  • platform/mac-leopard/fast/css/only-child-pseudo-class-expected.checksum:
  • platform/mac-leopard/fast/css/only-child-pseudo-class-expected.png:
  • platform/mac-leopard/fast/css/only-of-type-pseudo-class-expected.checksum:
  • platform/mac-leopard/fast/css/only-of-type-pseudo-class-expected.png:
  • platform/mac-leopard/fast/doctypes/002-expected.checksum:
  • platform/mac-leopard/fast/doctypes/002-expected.png:
  • platform/mac-leopard/fast/lists/001-expected.checksum:
  • platform/mac-leopard/fast/lists/001-expected.png:
  • platform/mac-leopard/fast/lists/002-expected.checksum:
  • platform/mac-leopard/fast/lists/002-expected.png:
  • platform/mac-leopard/fast/lists/003-expected.checksum:
  • platform/mac-leopard/fast/lists/003-expected.png:
  • platform/mac/css1/box_properties/margin_right-expected.txt:
  • platform/mac/css1/box_properties/padding_right-expected.txt:
  • platform/mac/editing/pasteboard/merge-end-list-expected.txt:
  • platform/mac/editing/selection/extend-by-word-002-expected.checksum:
  • platform/mac/editing/selection/extend-by-word-002-expected.png:
  • platform/mac/editing/selection/extend-by-word-002-expected.txt:
  • platform/mac/fast/css/background-shorthand-invalid-url-expected.txt:
  • platform/mac/fast/css/empty-pseudo-class-expected.txt:
  • platform/mac/fast/css/first-child-pseudo-class-expected.txt:
  • platform/mac/fast/css/first-of-type-pseudo-class-expected.txt:
  • platform/mac/fast/css/last-child-pseudo-class-expected.txt:
  • platform/mac/fast/css/last-of-type-pseudo-class-expected.txt:
  • platform/mac/fast/css/only-child-pseudo-class-expected.txt:
  • platform/mac/fast/css/only-of-type-pseudo-class-expected.txt:
  • platform/mac/fast/doctypes/002-expected.txt:
  • platform/mac/fast/lists/001-expected.txt:
  • platform/mac/fast/lists/001-vertical-expected.checksum:
  • platform/mac/fast/lists/001-vertical-expected.png:
  • platform/mac/fast/lists/001-vertical-expected.txt:
  • platform/mac/fast/lists/002-expected.txt:
  • platform/mac/fast/lists/002-vertical-expected.checksum:
  • platform/mac/fast/lists/002-vertical-expected.png:
  • platform/mac/fast/lists/002-vertical-expected.txt:
  • platform/mac/fast/lists/003-expected.txt:
  • platform/mac/fast/lists/003-vertical-expected.checksum:
  • platform/mac/fast/lists/003-vertical-expected.png:
  • platform/mac/fast/lists/003-vertical-expected.txt:
  • platform/mac/fast/lists/007-vertical-expected.checksum:
  • platform/mac/fast/lists/007-vertical-expected.png:
  • platform/mac/fast/lists/007-vertical-expected.txt:
  • platform/mac/fast/lists/008-vertical-expected.checksum:
  • platform/mac/fast/lists/008-vertical-expected.png:
  • platform/mac/fast/lists/008-vertical-expected.txt:
  • platform/mac/fast/lists/outSideListMarkers-expected.checksum: Removed.
  • platform/mac/fast/lists/outSideListMarkers-expected.png: Removed.
20:43 Changeset [72581] by commit-queue@webkit.org

2010-11-22 John Knottenbelt <jknotten@chromium.org>

Reviewed by Steve Block.

Implement mocks for client-based Geolocation.
https://bugs.webkit.org/show_bug.cgi?id=49258

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/mock/GeolocationClientMock.cpp: Added. (WebCore::GeolocationClientMock::GeolocationClientMock): (WebCore::GeolocationClientMock::~GeolocationClientMock): (WebCore::GeolocationClientMock::setController): (WebCore::GeolocationClientMock::setPosition): (WebCore::GeolocationClientMock::setError): (WebCore::GeolocationClientMock::geolocationDestroyed): (WebCore::GeolocationClientMock::startUpdating): (WebCore::GeolocationClientMock::stopUpdating): (WebCore::GeolocationClientMock::setEnableHighAccuracy): (WebCore::GeolocationClientMock::lastPosition): (WebCore::GeolocationClientMock::timerFired): (WebCore::GeolocationClientMock::makeGeolocationCallback):
  • platform/mock/GeolocationClientMock.h: Added.
20:10 Changeset [72580] by commit-queue@webkit.org

2010-11-22 Leandro Pereira <leandro@profusion.mobi>

Reviewed by Andreas Kling.

Add Leandro Pereira's blog to Planet WebKit
https://bugs.webkit.org/show_bug.cgi?id=49910

  • config.ini:
18:35 Changeset [72579] by commit-queue@webkit.org

2010-11-22 Alex Grilo <abgrilo@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Tiled Backing Store for Webkit-Efl
https://bugs.webkit.org/show_bug.cgi?id=45397

This tile based backing store is a grid of tiles where each tile is
an Evas_Object showing a piece of the page content. The
new ewk_view_tiled.c is an implementation of some of the functions of
the original ewk_view, that makes calls to the Tiled Backing Store
specific functions.

The rendering occurs in the pixels stored in each tile (Evas_Object),
in the same way as the previous single backing store. Tiles not being
shown in the viewport are stored in a cache, and can be reused later
to avoid having to be rendered again.

Scrolling occurs as just moving the tiles, using Evas move operations,
and when more than one tile size is scrolled, a shift of rows or
columns needs to be done.

  • CMakeListsEfl.txt:
  • ewk/ewk_tiled_backing_store.c: Added. (_ewk_tiled_backing_store_updates_process): (_ewk_tiled_backing_store_flush): (_ewk_tiled_backing_store_tile_new): (_ewk_tiled_backing_store_item_move): (_ewk_tiled_backing_store_item_resize): (_ewk_tiled_backing_store_tile_associate): (_ewk_tiled_backing_store_tile_dissociate): (_ewk_tiled_backing_store_tile_dissociate_all): (_ewk_tiled_backing_store_pre_render_request_add): (_ewk_tiled_backing_store_pre_render_request_del): (_ewk_tiled_backing_store_pre_render_request_first): (_ewk_tiled_backing_store_pre_render_request_flush): (_ewk_tiled_backing_store_pre_render_request_remove_unassociated): (_ewk_tiled_backing_store_pre_render_request_remove_associated): (_ewk_tiled_backing_store_pre_render_request_process_single): (_ewk_tiled_backing_store_item_process_idler_cb): (_ewk_tiled_backing_store_item_process_idler_stop): (_ewk_tiled_backing_store_item_process_idler_start): (_ewk_tiled_backing_store_item_request_del): (_ewk_tiled_backing_store_item_request_add): (_ewk_tiled_backing_store_disable_render): (_ewk_tiled_backing_store_enable_render): (_ewk_tiled_backing_store_visible_tiles_rect): (_ewk_tiled_backing_store_tile_is_inside_viewport): (_ewk_tiled_backing_store_tile_is_adjacent_to_viewport): (_ewk_tiled_backing_store_item_fill): (_ewk_tiled_backing_store_item_add): (_ewk_tiled_backing_store_item_del): (_ewk_tiled_backing_store_item_smooth_scale_set): (_ewk_tiled_backing_store_changed): (_ewk_tiled_backing_store_view_cols_end_del): (_ewk_tiled_backing_store_view_cols_end_add): (_ewk_tiled_backing_store_view_row_del): (_ewk_tiled_backing_store_view_rows_range_del): (_ewk_tiled_backing_store_view_rows_all_del): (_ewk_tiled_backing_store_render): (_ewk_tiled_backing_store_model_matrix_create): (_ewk_tiled_backing_store_smart_member_del): (_ewk_tiled_backing_store_smart_member_add): (_ewk_tiled_backing_store_mem_dbg): (_ewk_tiled_backing_store_sig_usr): (_ewk_tiled_backing_store_smart_add): (_ewk_tiled_backing_store_smart_del): (_ewk_tiled_backing_store_smart_move): (_ewk_tiled_backing_store_smart_resize): (_ewk_tiled_backing_store_recalc_renderers): (_ewk_tiled_backing_store_smart_calculate_size): (_ewk_tiled_backing_store_view_dbg): (_ewk_tiled_backing_store_view_wrap_up): (_ewk_tiled_backing_store_view_wrap_down): (_ewk_tiled_backing_store_view_wrap_left): (_ewk_tiled_backing_store_view_wrap_right): (_ewk_tiled_backing_store_view_refill): (_ewk_tiled_backing_store_view_pos_apply): (_ewk_tiled_backing_store_smart_calculate_offset_force): (_ewk_tiled_backing_store_smart_calculate_offset): (_ewk_tiled_backing_store_smart_calculate_pos): (_ewk_tiled_backing_store_fill_renderers): (_ewk_tiled_backing_store_smart_calculate): (ewk_tiled_backing_store_add): (ewk_tiled_backing_store_render_cb_set): (ewk_tiled_backing_store_tile_unused_cache_get): (ewk_tiled_backing_store_tile_unused_cache_set): (_ewk_tiled_backing_store_scroll_full_offset_set_internal): (ewk_tiled_backing_store_scroll_full_offset_set): (ewk_tiled_backing_store_scroll_full_offset_add): (_ewk_tiled_backing_store_zoom_set_internal): (ewk_tiled_backing_store_zoom_set): (ewk_tiled_backing_store_zoom_weak_set): (ewk_tiled_backing_store_fix_offsets): (ewk_tiled_backing_store_zoom_weak_smooth_scale_set): (ewk_tiled_backing_store_update): (ewk_tiled_backing_store_updates_process_pre_set): (ewk_tiled_backing_store_updates_process_post_set): (ewk_tiled_backing_store_updates_process): (ewk_tiled_backing_store_updates_clear): (ewk_tiled_backing_store_contents_resize): (ewk_tiled_backing_store_disabled_update_set): (ewk_tiled_backing_store_flush): (ewk_tiled_backing_store_pre_render_region): (ewk_tiled_backing_store_pre_render_relative_radius): (ewk_tiled_backing_store_pre_render_cancel): (ewk_tiled_backing_store_disable_render): (ewk_tiled_backing_store_enable_render): (ewk_tiled_backing_store_process_entire_queue_set):
  • ewk/ewk_tiled_backing_store.h: Added.
  • ewk/ewk_tiled_matrix.c: Added. (_ewk_tile_matrix_cell_free): (_ewk_tile_matrix_tile_free): (ewk_tile_matrix_new): (ewk_tile_matrix_free): (ewk_tile_matrix_resize): (ewk_tile_matrix_unused_cache_get): (ewk_tile_matrix_tile_exact_get): (ewk_tile_matrix_tile_exact_exists): (ewk_tile_matrix_tile_nearest_get): (ewk_tile_matrix_tile_new): (ewk_tile_matrix_tile_put): (ewk_tile_matrix_tile_update): (ewk_tile_matrix_tile_update_full): (ewk_tile_matrix_tile_updates_clear): (_ewk_tile_matrix_slicer_setup): (ewk_tile_matrix_update): (ewk_tile_matrix_updates_process): (ewk_tile_matrix_updates_clear): (ewk_tile_matrix_dbg): (ewk_tile_matrix_freeze): (ewk_tile_matrix_thaw):
  • ewk/ewk_tiled_matrix.h: Added.
  • ewk/ewk_tiled_model.c: Added. (_ewk_tile_account_get): (_ewk_tile_account_allocated): (_ewk_tile_account_freed): (ewk_tile_accounting_dbg): (_ewk_tile_paint_rgb888): (_ewk_tile_paint_rgb565): (_ewk_tile_paint): (ewk_tile_new): (ewk_tile_free): (ewk_tile_show): (ewk_tile_hide): (ewk_tile_visible_get): (ewk_tile_update_full): (ewk_tile_update_area): (ewk_tile_updates_process): (ewk_tile_updates_clear): (ewk_tile_unused_cache_new): (ewk_tile_unused_cache_lock_area): (ewk_tile_unused_cache_unlock_area): (ewk_tile_unused_cache_free): (ewk_tile_unused_cache_clear): (ewk_tile_unused_cache_ref): (ewk_tile_unused_cache_unref): (ewk_tile_unused_cache_max_set): (ewk_tile_unused_cache_max_get): (ewk_tile_unused_cache_used_get): (ewk_tile_unused_cache_flush): (ewk_tile_unused_cache_auto_flush): (ewk_tile_unused_cache_dirty): (ewk_tile_unused_cache_freeze): (ewk_tile_unused_cache_thaw): (ewk_tile_unused_cache_tile_get): (ewk_tile_unused_cache_tile_put): (ewk_tile_unused_cache_dbg):
  • ewk/ewk_tiled_model.h: Added.
  • ewk/ewk_tiled_private.h: Added.
  • ewk/ewk_view.cpp: (_ewk_view_smart_add): (_ewk_view_smart_calculate): (_ewk_view_smart_show): (_ewk_view_smart_hide): (_ewk_view_smart_pre_render_relative_radius): (_ewk_view_zoom_animator_cb): (_ewk_view_smart_disable_render): (_ewk_view_smart_enable_render): (ewk_view_base_smart_set): (ewk_view_pre_render_region): (ewk_view_pre_render_relative_radius): (ewk_view_enable_render): (ewk_view_disable_render): (ewk_view_scroll): (ewk_view_did_first_visually_nonempty_layout): (ewk_view_dispatch_did_finish_loading): (ewk_view_transition_to_commited_for_newpage):
  • ewk/ewk_view.h:
  • ewk/ewk_view_tiled.c: Added. (_ewk_view_tiled_render_cb): (_ewk_view_tiled_updates_process_pre): (_ewk_view_tiled_smart_backing_store_add): (_ewk_view_tiled_contents_size_changed_cb): (_ewk_view_tiled_smart_add): (_ewk_view_tiled_smart_scrolls_process): (_ewk_view_tiled_smart_repaints_process): (_ewk_view_tiled_smart_contents_resize): (_ewk_view_tiled_smart_zoom_set): (_ewk_view_tiled_smart_zoom_weak_set): (_ewk_view_tiled_smart_zoom_weak_smooth_scale_set): (_ewk_view_tiled_smart_flush): (_ewk_view_tiled_smart_pre_render_region): (_ewk_view_tiled_smart_pre_render_relative_radius): (_ewk_view_tiled_smart_pre_render_cancel): (_ewk_view_tiled_smart_disable_render): (_ewk_view_tiled_smart_enable_render): (ewk_view_tiled_smart_set): (_ewk_view_tiled_smart_class_new): (ewk_view_tiled_add): (ewk_view_tiled_unused_cache_get): (ewk_view_tiled_unused_cache_set): (ewk_view_tiled_process_entire_queue_set):
17:50 Changeset [72578] by tonyg@chromium.org

2010-11-22 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Adam Barth.

Fix bogus include guard.

  • loader/NavigationScheduler.h:
17:47 Changeset [72577] by andreas.kling@nokia.com

2010-11-22 Andreas Kling <kling@webkit.org>

Reviewed by Ariya Hidayat.

[Qt] Canvas: strokeText() and fillText() produce same shadow
https://bugs.webkit.org/show_bug.cgi?id=48845

Test: fast/canvas/canvas-strokeText-strokes-shadow.html

  • platform/graphics/qt/FontQt.cpp: (WebCore::drawTextCommon): Stroke the shadow rather than filling it in the cTextStroke case.

2010-11-22 Andreas Kling <kling@webkit.org>

Reviewed by Ariya Hidayat.

[Qt] Canvas: strokeText() and fillText() produce same shadow
https://bugs.webkit.org/show_bug.cgi?id=48845

Add test to verify that strokeText() doesn't produce a fillText() shadow.

  • fast/canvas/canvas-strokeText-strokes-shadow.html: Added.
  • fast/canvas/canvas-strokeText-strokes-shadow-expected.txt: Added.
  • fast/canvas/script-tests/canvas-strokeText-strokes-shadow.js: Added.
16:56 Changeset [72576] by dpranke@chromium.org

2010-11-22 Dirk Pranke <dpranke@chromium.org>

Reviewed by Tony Chang.

Fix some spacing issues with log messages with
new-run-webkit-tests --verbose.

https://bugs.webkit.org/show_bug.cgi?id=49936

  • Scripts/webkitpy/layout_tests/layout_package/printing.py:
16:56 Changeset [72575] by ojan@chromium.org

2010-11-22 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

update scm to work with different remote branches
https://bugs.webkit.org/show_bug.cgi?id=49949

This works if there are multiple svn tracking branches
and/or if the tracking branch is refs/remots/origin/master
instead of refs/remotes/trunk which is the direction we're trying
to head since that makes fetches faster.

  • Scripts/webkitpy/common/checkout/scm.py:
  • Scripts/webkitpy/common/checkout/scm_unittest.py:
16:55 Changeset [72574] by paroga@webkit.org

2010-11-22 Patrick Gansterer <paroga@webkit.org>

Reviewed by Sam Weinig.

Add WTF::FixedArray::size()
https://bugs.webkit.org/show_bug.cgi?id=49891

Add a method to get the size of a FixedArray.

  • wtf/FixedArray.h: (WTF::FixedArray::size):

2010-11-22 Patrick Gansterer <paroga@webkit.org>

Reviewed by Sam Weinig.

Use WTF::FixedArray::size()
https://bugs.webkit.org/show_bug.cgi?id=49891

  • dom/Document.cpp: (WebCore::Document::~Document):
16:25 Changeset [72573] by rniwa@webkit.org

2010-11-22 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Tony Chang.

SelectionController::typingStyle() should return EditingStyle*
https://bugs.webkit.org/show_bug.cgi?id=49813

Changed the return value of SelectionController::typingStyle() to EditingStyle*.
Also added SelectionController::copyTypingStyle() to copy the typing style
as an instance of CSSMutableStyleDeclaration.

No tests are added since this is no behavioral change.

  • WebView/WebFrame.mm: (-[WebFrame _typingStyle]): Calls SelectionController::copyTypingStyle()

2010-11-22 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Tony Chang.

SelectionController::typingStyle() should return EditingStyle*
https://bugs.webkit.org/show_bug.cgi?id=49813

Changed the return type of SelectionController::typingStyle to EditingStyle*.

Extracted textDirection from Editor::textDirectionForSelection to hide the underlying
CSSMutableStyleDeclaration.

Also extracted the code to preserve unicode-bidi and direction CSS properties in
InsertTextCommand::input, and moved into EditingStyle::prepareToApplyAt. ShouldPreserveWritingDirection,
which is added to the argument list of EditingStyle::prepareToApplyAt, decides whether or not
these two properties are preserved.

Also added SelectionController::copyTypingStyle() to copy the typing style as an instance of
CSSMutableStyleDeclaration.

No new tests are added since this is a refactoring.

  • editing/EditingStyle.cpp: (WebCore::EditingStyle::textDirection): Extracted from Editor::textDirectionForSelection. (WebCore::EditingStyle::removeStyleConflictingWithStyleOfNode): Added a missing null check. (WebCore::EditingStyle::prepareToApplyAt): See above. (WebCore::editingStyleIncludingTypingStyle): Calls SelectionController::typingStyle.
  • editing/EditingStyle.h: Moved WritingDirection from Editor.h
  • editing/Editor.cpp: (WebCore::Editor::textDirectionForSelection): Calls EditingStyle::textDirection. (WebCore::Editor::computeAndSetTypingStyle): Calls SelectionController::typingStyle. (WebCore::Editor::selectionComputedStyle): Ditto. (WebCore::Editor::styleForSelectionStart): Ditto.
  • editing/Editor.h:
  • editing/InsertLineBreakCommand.cpp: (WebCore::InsertLineBreakCommand::doApply): Ditto.
  • editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::input): Calls EditingStyle::prepareToApplyAt with PreserveWritingDirection.
  • editing/SelectionController.h: (WebCore::SelectionController::typingStyle): Returns EditingStyle* rather than CSSMutableStyleDeclaration*. (WebCore::SelectionController::copyTypingStyle): Added.
16:18 Changeset [72572] by paroga@webkit.org

2010-11-22 Patrick Gansterer <paroga@webkit.org>

Reviewed by Adam Roben.

[WINCE] Set correct preprocessor definitions
https://bugs.webkit.org/show_bug.cgi?id=49887

  • wtf/Platform.h:

2010-11-22 Patrick Gansterer <paroga@webkit.org>

Reviewed by Adam Roben.

[WINCE] Set correct preprocessor definitions
https://bugs.webkit.org/show_bug.cgi?id=49887

  • config.h:
15:57 Changeset [72571] by aroben@apple.com

Update Windows 7 results for two tests

Windows 7 uses different fonts from Windows XP on these tests (and even
has a font that can render the inverted nun in bidi-mirror-he-ar.html).

  • platform/win/fast/text/international/bidi-mirror-he-ar-expected.checksum:
  • platform/win/fast/text/international/bidi-mirror-he-ar-expected.png:
  • platform/win/fast/text/international/bidi-mirror-he-ar-expected.txt:
  • platform/win/fast/text/international/bold-bengali-expected.checksum: Added.
  • platform/win/fast/text/international/bold-bengali-expected.png: Added.
  • platform/win/fast/text/international/bold-bengali-expected.txt:
15:38 Changeset [72570] by aroben@apple.com

Update Windows 7 results for fast/text/international/complex-character-based-fallback.html

  • platform/win/fast/text/international/complex-character-based-fallback-expected.checksum: Added.
  • platform/win/fast/text/international/complex-character-based-fallback-expected.png: Added.
  • platform/win/fast/text/international/complex-character-based-fallback-expected.txt:
15:27 Changeset [72569] by aroben@apple.com

Update Windows XP results for fast/text/international/complex-character-based-fallback.html after r72173

The existing pixel results were XP-specific so I moved them into
LayoutTests/platform/win-xp.

  • platform/win-xp/fast/text/international/complex-character-based-fallback-expected.checksum: Added.
  • platform/win-xp/fast/text/international/complex-character-based-fallback-expected.png: Added.
  • platform/win-xp/fast/text/international/complex-character-based-fallback-expected.txt:
  • platform/win/fast/text/international/complex-character-based-fallback-expected.checksum: Removed.
  • platform/win/fast/text/international/complex-character-based-fallback-expected.png: Removed.
15:21 Changeset [72568] by aroben@apple.com

Update Windows results after r72552

  • platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/win/fast/dom/prototype-inheritance-expected.txt:
15:04 Changeset [72567] by jamesr@google.com

2010-11-22 James Robinson <jamesr@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] font-size:0 text runs should have zero width
https://bugs.webkit.org/show_bug.cgi?id=49871

Expands test to check width in addition to height.

  • fast/text/font-size-zero-expected.txt:
  • fast/text/font-size-zero.html:
  • fast/text/script-tests/font-size-zero.js:

2010-11-22 James Robinson <jamesr@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] font-size:0 text runs should have zero width
https://bugs.webkit.org/show_bug.cgi?id=49871

Returns 0 from platformWidthForGlyph if the specified font size is 0.

Test: fast/text/font-size-zero.html

  • platform/graphics/chromium/SimpleFontDataChromiumWin.cpp: (WebCore::SimpleFontData::platformWidthForGlyph):
  • platform/graphics/chromium/SimpleFontDataLinux.cpp: (WebCore::SimpleFontData::platformWidthForGlyph):
15:01 Changeset [72566] by commit-queue@webkit.org

2010-11-22 Charlie Reis <creis@chromium.org>

Reviewed by Darin Fisher.

Update correct content state during back/forward navigations
https://bugs.webkit.org/show_bug.cgi?id=48809

Test that we update content state when leaving a form in a subframe.

  • fast/history/saves-state-after-frame-nav.html:
  • fast/history/saves-state-after-frame-nav-expected.txt:
  • fast/history/resources/subframe-with-form.html:

2010-11-22 Charlie Reis <creis@chromium.org>

Reviewed by Darin Fisher.

Update correct content state during back/forward navigations
https://bugs.webkit.org/show_bug.cgi?id=48809

Ensures that history's previousItem is non-null when clients try to
update content state (e.g., Chromium's UpdateSessionHistory). We now
track load completions with a boolean field rather than by clearing
previousItem.

Test: fast/history/saves-state-after-frame-nav.html

  • loader/HistoryController.cpp:
  • loader/HistoryController.h:
14:59 Changeset [72565] by jparent@chromium.org

Unreviewed. Add flaky crash expectation for fast/files/revoke-blob-url.html on mac debug.

  • platform/chromium/test_expectations.txt:
14:52 Changeset [72564] by hayato@chromium.org

2010-11-22 Hayato Ito <hayato@chromium.org>

Reviewed by Shinichiro Hamaji.

Ignore reference files which will be used by reftests when collecting
test cases.
https://bugs.webkit.org/show_bug.cgi?id=49835

  • Scripts/webkitpy/layout_tests/port/test_files.py:
  • Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
14:45 Changeset [72563] by aroben@apple.com

Update Windows results for transforms/2d/hindi-rotated.html after r72173

The existing pixel results were XP-specific so I moved them to
LayoutTests/platform/win-xp.

  • platform/win-xp/transforms/2d/hindi-rotated-expected.checksum: Added.
  • platform/win-xp/transforms/2d/hindi-rotated-expected.png: Added.
  • platform/win-xp/transforms/2d/hindi-rotated-expected.txt:
  • platform/win/transforms/2d/hindi-rotated-expected.checksum:
  • platform/win/transforms/2d/hindi-rotated-expected.png:
  • platform/win/transforms/2d/hindi-rotated-expected.txt:
14:40 Changeset [72562] by rniwa@webkit.org

2010-11-22 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed rebaseline for Chromium.

Removed the erroneous expected result for editing/deleting/5168598.html on chromium linux.

  • platform/chromium-linux/editing/deleting/5168598-expected.txt: Removed.
  • platform/chromium/test_expectations.txt: Removed editing/deleting/5168598.html.
14:33 QtWebKitFeatures21 edited by ademar.reis@openbossa.org
adding (partial) list of fixes (diff)
14:24 Changeset [72561] by ossy@webkit.org

Unreviewed. Update GTK and Mac specific expected results after r72552.

  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/prototype-inheritance-expected.txt:
  • platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/gtk/fast/dom/prototype-inheritance-expected.txt:
14:15 Changeset [72560] by tony@chromium.org

2010-11-22 Tony Chang <tony@chromium.org>

Unreviewed, roll Chromium DEPS to r67004.

  • DEPS:
14:05 Changeset [72559] by weinig@apple.com

Update WebKit2 skipped list.

  • platform/mac-wk2/Skipped:
14:01 Changeset [72558] by jamesr@google.com

Revert code changes of WebKit r67261 on the 552 branch BUG=56150 TBR=pkasting

14:01 Changeset [72557] by luiz@webkit.org

2010-11-22 Luiz Agostini <luiz.agostini@openbossa.org>

Unreviewed, Windows build fix.

Adding JSMediaQueryList to DerivedSources.cpp.

  • DerivedSources.cpp:
13:53 Changeset [72556] by ossy@webkit.org

Unreviewed. Update Qt specific expected results after r72552.

  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-expected.txt:
13:38 QtWebKitContrib edited by ademar.reis@openbossa.org
(diff)
13:21 Changeset [72555] by aroben@apple.com

Use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops files

Apple's Windows build allows placing header files and import libraries for WebKit's
dependencies (CoreGraphics, CFNetwork, SQLite, etc.) outside the source tree via the
$WebKitLibrariesDir environment variable. This is both required for production builds and
convenient for Apple-internal developer builds. Apple's production builds also require that
WebKit's shared .vsprops files be accessed relative to $WebKitLibrariesDir. In production
builds, the files are copied into that directory tree by the
WebKitLibraries/win/tools/WinTools.make file. In Apple-internal developer builds, the
copying is done by
JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make.

This .vsprops copying is problematic in one very important case: when a developer updates
their source tree and then tries to build. Visual Studio only reads .vsprops files when a
project is first loaded. So, when Visual Studio is first opened after the .vsprops files are
updated, it reads in the old files that were already residing in $WebKitLibrariesDir. When a
build is started, JavaScriptCoreGenerated.make copies the new .vsprops files into
$WebKitLibrariesDir, but Visual Studio will not pick up the changes. The rest of the build
will proceed with out-of-date .vsprops files, which will likely result in a build failure.

To fix this, we now use normal relative paths to access the .vsprops files in the source
tree rather than in $WebKitLibrariesDir, but prefix those paths with a new environment
variable, $WebKitVSPropsRedirectionDir. In developer builds, this environment variable is
unset, so the normal relative paths are used to read the .vsprops files out of the source
tree directly. In production builds, this environment variable is set to a fake directory
that will cause the .vsprops files in $WebKitLibrariesDir to be found when the relative path
is resolved.

For example, JavaScriptCore.vcproj uses this path for FeatureDefines.vsprops:

$(WebKitVSPropsRedirectionDir)..\..\..\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops

In developer builds, where $WebKitVSPropsRedirectionDir is unset, this will point to the
files in WebKitLibraries\win\tools\vsprops in the source tree. In production builds,
JavaScriptCore.make sets $WebKitVSPropsRedirectionDir to
"$(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\1\2\3\", so the full path for
FeatureDefines.vsprops becomes:

$(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\1\2\3\..\..\..\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops

which resolves to:

$(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops

(We rely on the fact that Windows doesn't care whether the directories "1", "2", and "3"
actually exist since they are matched by an equal number of ".." path components.)

Note that Visual Studio still won't pick up changes made to .vsprops files while Visual
Studio is open, but that problem hasn't seemed to cause developers many headaches so far.

Fixes <http://webkit.org/b/49181> Windows build fails mysteriously when .vsprops files are
updated

Reviewed by Dave Hyatt.

JavaScriptCore:

  • JavaScriptCore.vcproj/JavaScriptCore.make: Set $WebKitVSPropsRedirectionDir so that

production builds can find the .vsprops files.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make: Stopy copying the

.vsprops files. It isn't needed anymore.

Changed to use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops
files.

WebCore:

  • WebCore.vcproj/WebCore.make: Set $WebKitVSPropsRedirectionDir so that

production builds can find the .vsprops files.

  • WebCore.vcproj/QTMovieWin.vcproj:
  • WebCore.vcproj/WebCore.vcproj:

Changed to use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops
files.

WebKit/win:

  • WebKit.vcproj/WebKit.make: Set $WebKitVSPropsRedirectionDir so that production builds can

find the .vsprops files.

  • WebKit.vcproj/WebKit.vcproj:
  • WebKit.vcproj/Interfaces.vcproj:
  • WebKit.vcproj/WebKitGUID.vcproj:

Changed to use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops
files.

WebKit2:

  • win/WebKit2.make: Set $WebKitVSPropsRedirectionDir so that production builds can

find the .vsprops files.

  • win/WebKit2.vcproj:
  • win/WebKit2WebProcess.vcproj:

Changed to use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops
files.

WebKitLibraries:

  • win/tools/WinTools.make: Copy the shared .vsprops files into a directory tree beneath

AppleInternal\tools\vsprops that matches the source directory tree. This allows production
builds to redirect the relative paths used to find the shared .vsprops files into
AppleInternal by setting $WebKitVSPropsRedirectionDir to the appropriate value.

WebKitTools:

  • DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
  • DumpRenderTree/win/DumpRenderTree.vcproj:
  • DumpRenderTree/win/ImageDiff.vcproj:
  • FindSafari/FindSafari.vcproj:
  • MiniBrowser/MiniBrowser.vcproj:
  • TestWebKitAPI/win/TestWebKitAPI.vcproj:
  • TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
  • WebKitAPITest/WebKitAPITest.vcproj:
  • WebKitLauncherWin/WebKitLauncherWin.vcproj:
  • WebKitTestRunner/win/InjectedBundle.vcproj:
  • WebKitTestRunner/win/WebKitTestRunner.vcproj:
  • WinLauncher/WinLauncher.vcproj:
  • record-memory-win/record-memory-win.vcproj:

Changed to use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops
files.

13:17 Changeset [72554] by aroben@apple.com

Make it possible to run tests on Windows without Visual Studio or VC++ Express installed

webkitdir.pm::setupCygwinEnv dies when Visual Studio and VC++ Express
are not installed. But this function doesn't need to be called when we
already have a build available and are just trying to run the tests.

Fixes <http://webkit.org/b/49932> New Windows 7 bot can't run tests
because Visual Studio/VC++ Express aren't installed

Reviewed by Dave Hyatt.

  • Scripts/webkitdirs.pm:

(determineConfigurationForVisualStudio): Don't call setupCygwinEnv, as
it is not needed by this function. Also added a FIXME.

(usingVisualStudioExpress): Call setupCygwinEnv directly rather than
relying on determineConfigurationForVisualStudio doing it.

13:16 Changeset [72553] by rniwa@webkit.org

2010-11-22 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed update of Windows's skipped list and Chromium's test expectation.

fast/text/international/thai-cursor-position.html erroneously had an expected result
on Windows even though textInputController hasn't been implemented on Windows (the bug 32021).

Removed the expected result and added the tests to Windows platform's skipped list.

  • platform/chromium/test_expectations.txt: Removed fast/text/international/thai-cursor-position.html.
  • platform/win/Skipped: Added fast/text/international/thai-cursor-position.html.
  • platform/win/fast/text/international/thai-cursor-position-expected.txt: Removed.
13:02 Changeset [72552] by luiz@webkit.org

2010-10-21 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Darin Adler.

Implement CSSOM View matchMedia interface
https://bugs.webkit.org/show_bug.cgi?id=37205

New property matchMedia was added to window.

  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/Window/window-property-descriptors-expected.txt:

window.matchMedia and MediaQueryList tests.

  • fast/media/media-query-list-01-expected.txt: Added.
  • fast/media/media-query-list-01.html: Added.

The following tests depend on LayoutTestController::setViewModeMediaFeature() to work.
As it is only implemented by Qt and Gtk the tests needed to be skipped in all other platforms.

  • fast/media/media-query-list-02-expected.txt: Added.
  • fast/media/media-query-list-02.html: Added.
  • fast/media/media-query-list-03-expected.txt: Added.
  • fast/media/media-query-list-03.html: Added.
  • fast/media/media-query-list-04-expected.txt: Added.
  • fast/media/media-query-list-04.html: Added.
  • fast/media/media-query-list-05-expected.txt: Added.
  • fast/media/media-query-list-05.html: Added.
  • fast/media/media-query-list-06-expected.txt: Added.
  • fast/media/media-query-list-06.html: Added.
  • fast/media/media-query-list-07-expected.txt: Added.
  • fast/media/media-query-list-07.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/mac/Skipped:
  • platform/win/Skipped:

2010-10-21 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Darin Adler.

Implement CSSOM View matchMedia interface
https://bugs.webkit.org/show_bug.cgi?id=37205

New interfaces may be used to evaluate media queries and to associate listeners
to media queries. Those listeners are called whenever the associated query changes.
Specification may be found at http://dev.w3.org/csswg/cssom-view/#the-mediaquerylist-interface

operator== added to JS version of ScriptValue.
Method isFunction added to JS and V8 versions of ScriptValue.

  • bindings/js/ScriptValue.cpp: (WebCore::ScriptValue::isFunction):
  • bindings/js/ScriptValue.h: (WebCore::ScriptValue::operator==):
  • bindings/v8/ScriptValue.h: (WebCore::ScriptValue::isFunction):

Some changes were needed to the code generators to handle type MediaQueryListListener.

  • bindings/scripts/CodeGeneratorGObject.pm:
  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/CodeGeneratorV8.pm:

Some changes to the bindings test results that were previously added.

  • bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListener.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListener.h:
  • bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp: (WebCore::jsTestMediaQueryListListenerPrototypeFunctionMethod):
  • bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp: (WebCore::TestMediaQueryListListenerInternal::methodCallback): (WebCore::ConfigureV8TestMediaQueryListListenerTemplate):

New interfaces:

  • css/MediaQueryList.cpp: Added.
  • css/MediaQueryList.h: Added.
  • css/MediaQueryList.idl: Added.
  • css/MediaQueryListListener.cpp: Added.
  • css/MediaQueryListListener.h: Added.
  • css/MediaQueryListListener.idl: Added.

To avoid adding code to classes DOMWindow and Document a new class MediaQueryMatcher was created.

  • css/MediaQueryMatcher.cpp: Added.
  • css/MediaQueryMatcher.h: Added.

Document and DOMWindow have changed to support new features. DOMWindow is the class that
publishes methods matchMedia but for page cache to work properly the reference to the
MediaQueryMatcher must be in Document.

  • dom/Document.cpp: (WebCore::Document::~Document): (WebCore::Document::mediaQueryMatcher): (WebCore::Document::styleSelectorChanged):
  • dom/Document.h:
  • page/DOMWindow.cpp: (WebCore::DOMWindow::matchMedia):
  • page/DOMWindow.h:
  • page/DOMWindow.idl:

Build systems

  • CMakeLists.txt:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/gobject/GNUmakefile.am:

Tests: fast/media/media-query-list-01.html

fast/media/media-query-list-02.html
fast/media/media-query-list-03.html
fast/media/media-query-list-04.html
fast/media/media-query-list-05.html
fast/media/media-query-list-06.html
fast/media/media-query-list-07.html

13:00 Changeset [72551] by hayato@chromium.org

2010-11-19 Hayato Ito <hayato@chromium.org>

Reviewed by Shinichiro Hamaji.

Simplify Driver.run_test() so that it takes only one parameter, TestInput.

https://bugs.webkit.org/show_bug.cgi?id=49812

  • Scripts/webkitpy/layout_tests/driver_test.py:
  • Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/base_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/dryrun.py:
  • Scripts/webkitpy/layout_tests/port/test.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
12:13 Changeset [72550] by rniwa@webkit.org

2010-11-22 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed update of Windows Skipped list.

editing/selection/5825350-1.html and 5825350-2.html erroneously
had expectations with console error message even though textInputController
hasn't been implemented on Windows (the bug 32021),

Removed these expectations and added the tests to the skipped list.

  • platform/win/Skipped:
  • platform/win/editing/selection/5825350-1-expected.txt: Removed.
  • platform/win/editing/selection/5825350-2-expected.txt: Removed.
12:08 Changeset [72549] by aroben@apple.com

Add Windows-specific results for fast/ruby/nested-ruby.html

  • platform/win/fast/ruby/nested-ruby-expected.checksum: Added.
  • platform/win/fast/ruby/nested-ruby-expected.png: Added.
  • platform/win/fast/ruby/nested-ruby-expected.txt: Added.
12:07 Changeset [72548] by aroben@apple.com

Update Windows XP results for fast/text/international/bidi-control-chars-treated-as-ZWS.html

The render tree dump on XP now matches Mac. I updated the pixel results
to match the current rendering (the two test lines have moved down
slightly).

  • platform/win-xp/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.checksum:
  • platform/win-xp/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.png:
  • platform/win-xp/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.txt: Removed.
11:58 Changeset [72547] by hayato@chromium.org

2010-11-22 Hayato Ito <hayato@chromium.org>

Reviewed by Tony Chang.

[NRWT] Retry a few times in reading a png image to avoid a race condition.

https://bugs.webkit.org/show_bug.cgi?id=49924

  • Scripts/webkitpy/layout_tests/port/chromium.py:
11:09 Changeset [72546] by aroben@apple.com

Remove obsolete Windows-specific results for svg/dom/path-parser.html

r72381 made these unnecessary.

  • platform/win/svg/dom/path-parser-expected.txt: Removed.
11:08 Changeset [72545] by aroben@apple.com

Update Windows results for fast/dom/prototype-inheritance-2.html

This is the Windows equivalent of r72353.

  • platform/win/fast/dom/prototype-inheritance-2-expected.txt:
10:55 Changeset [72544] by andreas.kling@nokia.com

2010-11-22 Andreas Kling <kling@webkit.org>

Unreviewed, rebaseline GTK+ after r72527.

  • platform/gtk/css1/box_properties/margin_right-expected.txt:
  • platform/gtk/css1/box_properties/padding_right-expected.txt:
  • platform/gtk/fast/lists/001-vertical-expected.txt:
  • platform/gtk/fast/lists/002-vertical-expected.txt:
  • platform/gtk/fast/lists/003-vertical-expected.txt:
  • platform/gtk/fast/lists/007-vertical-expected.txt:
  • platform/gtk/fast/lists/008-vertical-expected.txt:
  • platform/gtk/fast/lists/outSideListMarkers-expected.txt: Added.
10:50 Changeset [72543] by aroben@apple.com

Add Windows-specific results for editing/selection/extend-selection-home-end.html

These results are identical to the cross-platform results, but are
needed to override the Mac-specific results in platform/mac.

Fixes <http://webkit.org/b/49874>.

  • platform/win/editing/selection/extend-selection-home-end-expected.txt: Added.
10:44 Changeset [72542] by antonm@chromium.org

Not reviewed. Test expectations arrangements and rebaselinings.

  • platform/chromium-mac/fast/lists/001-vertical-expected.checksum: Removed.
  • platform/chromium-mac/fast/lists/001-vertical-expected.png: Removed.
  • platform/chromium/test_expectations.txt:
10:30 Changeset [72541] by antonm@chromium.org

Not reviewed. Fallback font rebaselines.

  • platform/chromium-linux/fast/css/line-height-determined-by-primary-font-expected.checksum: Added.
  • platform/chromium-linux/fast/css/line-height-determined-by-primary-font-expected.png: Added.
  • platform/chromium-linux/fast/css/line-height-determined-by-primary-font-expected.txt: Added.
  • platform/chromium-linux/fast/text/international/hebrew-vowels-expected.checksum: Added.
  • platform/chromium-linux/fast/text/international/hebrew-vowels-expected.png: Added.
  • platform/chromium-mac/css2.1/t1202-counters-04-b-expected.checksum: Added.
  • platform/chromium-mac/css2.1/t1202-counters-04-b-expected.png: Added.
  • platform/chromium-mac/editing/selection/caret-rtl-2-expected.checksum:
  • platform/chromium-mac/editing/selection/caret-rtl-2-expected.png:
  • platform/chromium-mac/fast/css/line-height-determined-by-primary-font-expected.checksum: Added.
  • platform/chromium-mac/fast/css/line-height-determined-by-primary-font-expected.png: Added.
  • platform/chromium-mac/fast/forms/select-visual-hebrew-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/select-visual-hebrew-expected.png: Added.
  • platform/chromium-mac/fast/forms/visual-hebrew-text-field-expected.checksum: Added.
  • platform/chromium-mac/fast/forms/visual-hebrew-text-field-expected.png: Added.
  • platform/chromium-mac/fast/text/international/001-expected.checksum: Added.
  • platform/chromium-mac/fast/text/international/001-expected.png: Added.
  • platform/chromium-mac/fast/text/international/hebrew-vowels-expected.checksum: Added.
  • platform/chromium-mac/fast/text/international/hebrew-vowels-expected.png: Added.
  • platform/chromium-win/fast/css/line-height-determined-by-primary-font-expected.checksum: Added.
  • platform/chromium-win/fast/css/line-height-determined-by-primary-font-expected.png: Added.
  • platform/chromium-win/fast/css/line-height-determined-by-primary-font-expected.txt: Added.
  • platform/chromium-win/fast/text/international/hebrew-vowels-expected.checksum: Added.
  • platform/chromium-win/fast/text/international/hebrew-vowels-expected.png: Added.
  • platform/chromium-win/fast/text/international/hebrew-vowels-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
10:26 Changeset [72540] by apavlov@chromium.org

2010-11-22 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [REGRESSION] Contents of rules inside @media not displayed/editable
https://bugs.webkit.org/show_bug.cgi?id=49804

WebCore:

  • css/CSSImportRule.cpp: (WebCore::CSSImportRule::insertedIntoParent):
  • inspector/InspectorCSSAgent.cpp: (WebCore::InspectorCSSAgent::setStyleSheetText2):
  • inspector/InspectorStyleSheet.cpp: (WebCore::asCSSRuleList): (WebCore::InspectorStyleSheet::reparseStyleSheet): (WebCore::InspectorStyleSheet::setText): (WebCore::InspectorStyleSheet::addRule): (WebCore::InspectorStyleSheet::ruleForId): (WebCore::InspectorStyleSheet::ruleIndexByStyle): (WebCore::InspectorStyleSheet::ensureText): (WebCore::InspectorStyleSheet::ensureSourceData): (WebCore::InspectorStyleSheet::ensureFlatRules): (WebCore::InspectorStyleSheet::revalidateStyle): (WebCore::InspectorStyleSheet::buildArrayForRuleList): (WebCore::InspectorStyleSheet::fixUnparsedPropertyRanges): (WebCore::InspectorStyleSheet::collectFlatRules):
  • inspector/InspectorStyleSheet.h:


LayoutTests:

  • inspector/resources/styles-new-API-1.css: Added. (@page): (@page :first): (#absent-id): (body):
  • inspector/resources/styles-new-API.css:
  • inspector/styles-new-API-expected.txt:
09:53 Changeset [72539] by antonm@chromium.org

Not reviewed. Amending expectations for Chromium.

  • platform/chromium/test_expectations.txt:
09:50 Changeset [72538] by antonm@chromium.org

Not reviewed. Another portion of Chromium rebaselines for SVG.

  • platform/chromium-linux/svg/dom/SVGPathSegList-appendItem-expected.checksum: Added.
  • platform/chromium-linux/svg/dom/SVGPathSegList-appendItem-expected.png: Added.
  • platform/chromium-linux/svg/dom/SVGPathSegList-clear-and-initialize-expected.checksum: Added.
  • platform/chromium-linux/svg/dom/SVGPathSegList-clear-and-initialize-expected.png: Added.
  • platform/chromium-linux/svg/dom/SVGPathSegList-insertItemBefore-expected.checksum: Added.
  • platform/chromium-linux/svg/dom/SVGPathSegList-insertItemBefore-expected.png: Added.
  • platform/chromium-linux/svg/dom/SVGPathSegList-removeItem-expected.checksum: Added.
  • platform/chromium-linux/svg/dom/SVGPathSegList-removeItem-expected.png: Added.
  • platform/chromium-linux/svg/dom/SVGPathSegList-replaceItem-expected.checksum: Added.
  • platform/chromium-linux/svg/dom/SVGPathSegList-replaceItem-expected.png: Added.
  • platform/chromium-mac/svg/dom/SVGPathSegList-appendItem-expected.checksum: Added.
  • platform/chromium-mac/svg/dom/SVGPathSegList-appendItem-expected.png: Added.
  • platform/chromium-mac/svg/dom/SVGPathSegList-clear-and-initialize-expected.checksum: Added.
  • platform/chromium-mac/svg/dom/SVGPathSegList-clear-and-initialize-expected.png: Added.
  • platform/chromium-mac/svg/dom/SVGPathSegList-insertItemBefore-expected.checksum: Added.
  • platform/chromium-mac/svg/dom/SVGPathSegList-insertItemBefore-expected.png: Added.
  • platform/chromium-mac/svg/dom/SVGPathSegList-removeItem-expected.checksum: Added.
  • platform/chromium-mac/svg/dom/SVGPathSegList-removeItem-expected.png: Added.
  • platform/chromium-mac/svg/dom/SVGPathSegList-replaceItem-expected.checksum: Added.
  • platform/chromium-mac/svg/dom/SVGPathSegList-replaceItem-expected.png: Added.
  • platform/chromium-mac/svg/dom/svgpath-out-of-bounds-getPathSeg-expected.txt:
  • platform/chromium-win/svg/dom/SVGPathSegList-appendItem-expected.checksum: Added.
  • platform/chromium-win/svg/dom/SVGPathSegList-appendItem-expected.png: Added.
  • platform/chromium-win/svg/dom/SVGPathSegList-clear-and-initialize-expected.checksum: Added.
  • platform/chromium-win/svg/dom/SVGPathSegList-clear-and-initialize-expected.png: Added.
  • platform/chromium-win/svg/dom/SVGPathSegList-insertItemBefore-expected.checksum: Added.
  • platform/chromium-win/svg/dom/SVGPathSegList-insertItemBefore-expected.png: Added.
  • platform/chromium-win/svg/dom/SVGPathSegList-removeItem-expected.checksum: Added.
  • platform/chromium-win/svg/dom/SVGPathSegList-removeItem-expected.png: Added.
  • platform/chromium-win/svg/dom/SVGPathSegList-replaceItem-expected.checksum: Added.
  • platform/chromium-win/svg/dom/SVGPathSegList-replaceItem-expected.png: Added.
  • platform/chromium-win/svg/dom/svgpath-out-of-bounds-getPathSeg-expected.txt:
  • platform/chromium/test_expectations.txt:
09:39 Changeset [72537] by antonm@chromium.org

Not reviewed. Another portion of Chromium rebaselines.

  • platform/chromium-linux/fast/text/international/hindi-whitespace-expected.checksum:
  • platform/chromium-linux/fast/text/international/hindi-whitespace-expected.png:
  • platform/chromium-linux/fast/text/international/hindi-whitespace-expected.txt:
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-30-t-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-30-t-expected.png:
  • platform/chromium-linux/svg/carto.net/selectionlist-expected.checksum:
  • platform/chromium-linux/svg/carto.net/selectionlist-expected.png:
  • platform/chromium-linux/svg/custom/image-small-width-height-expected.checksum:
  • platform/chromium-linux/svg/custom/image-small-width-height-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-30-t-expected.checksum:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-30-t-expected.png:
  • platform/chromium-win/svg/carto.net/selectionlist-expected.checksum:
  • platform/chromium-win/svg/carto.net/selectionlist-expected.png:
  • platform/chromium-win/svg/custom/image-small-width-height-expected.checksum:
  • platform/chromium-win/svg/custom/image-small-width-height-expected.png:
  • platform/chromium/test_expectations.txt:
09:36 Changeset [72536] by tony@chromium.org

2010-11-22 Tony Chang <tony@chromium.org>

Unreviewed, update Chromium Win plugin test expectations.

  • platform/chromium/drt_expectations.txt:
09:33 Changeset [72535] by antonm@chromium.org

Not reviewed. Chromium rebaselines after http://trac.webkit.org/changeset/72518

  • platform/chromium-linux/svg/dom/SVGLengthList-basics-expected.checksum:
  • platform/chromium-linux/svg/dom/SVGLengthList-basics-expected.png:
  • platform/chromium-linux/svg/dom/SVGNumberList-basics-expected.checksum: Added.
  • platform/chromium-linux/svg/dom/SVGNumberList-basics-expected.png: Added.
  • platform/chromium-linux/svg/dom/SVGPointList-basics-expected.checksum: Added.
  • platform/chromium-linux/svg/dom/SVGPointList-basics-expected.png: Added.
  • platform/chromium-linux/svg/dom/SVGStringList-basics-expected.checksum: Added.
  • platform/chromium-linux/svg/dom/SVGStringList-basics-expected.png: Added.
  • platform/chromium-linux/svg/dom/SVGTransformList-basics-expected.checksum: Added.
  • platform/chromium-linux/svg/dom/SVGTransformList-basics-expected.png: Added.
  • platform/chromium-mac/svg/dom/SVGLengthList-basics-expected.checksum: Added.
  • platform/chromium-mac/svg/dom/SVGLengthList-basics-expected.png: Added.
  • platform/chromium-mac/svg/dom/SVGNumberList-basics-expected.checksum: Added.
  • platform/chromium-mac/svg/dom/SVGNumberList-basics-expected.png: Added.
  • platform/chromium-mac/svg/dom/SVGPointList-basics-expected.checksum: Added.
  • platform/chromium-mac/svg/dom/SVGPointList-basics-expected.png: Added.
  • platform/chromium-mac/svg/dom/SVGStringList-basics-expected.checksum: Added.
  • platform/chromium-mac/svg/dom/SVGStringList-basics-expected.png: Added.
  • platform/chromium-mac/svg/dom/SVGTransformList-basics-expected.checksum: Added.
  • platform/chromium-mac/svg/dom/SVGTransformList-basics-expected.png: Added.
  • platform/chromium-win/svg/dom/SVGLengthList-basics-expected.checksum:
  • platform/chromium-win/svg/dom/SVGLengthList-basics-expected.png:
  • platform/chromium-win/svg/dom/SVGNumberList-basics-expected.checksum: Added.
  • platform/chromium-win/svg/dom/SVGNumberList-basics-expected.png: Added.
  • platform/chromium-win/svg/dom/SVGPointList-basics-expected.checksum: Added.
  • platform/chromium-win/svg/dom/SVGPointList-basics-expected.png: Added.
  • platform/chromium-win/svg/dom/SVGStringList-basics-expected.checksum: Added.
  • platform/chromium-win/svg/dom/SVGStringList-basics-expected.png: Added.
  • platform/chromium-win/svg/dom/SVGTransformList-basics-expected.checksum: Added.
  • platform/chromium-win/svg/dom/SVGTransformList-basics-expected.png: Added.
  • platform/chromium/test_expectations.txt:
09:23 Changeset [72534] by antonm@chromium.org

Not reviewed. Reorganizing suppressions.

  • platform/chromium/test_expectations.txt:
09:16 Changeset [72533] by antonm@chromium.org

Unreviewed. Tons of Chromium rebaselines after http://trac.webkit.org/changeset/72527

  • platform/chromium-linux/css1/box_properties/margin_right-expected.checksum:
  • platform/chromium-linux/css1/box_properties/margin_right-expected.png:
  • platform/chromium-linux/css1/box_properties/padding_right-expected.checksum:
  • platform/chromium-linux/css1/box_properties/padding_right-expected.png:
  • platform/chromium-linux/css2.1/t0805-c5520-brdr-b-01-e-expected.checksum:
  • platform/chromium-linux/css2.1/t0805-c5520-brdr-b-01-e-expected.png:
  • platform/chromium-linux/css2.1/t0805-c5520-brdr-b-01-e-expected.txt:
  • platform/chromium-linux/editing/pasteboard/merge-end-list-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/merge-end-list-expected.png:
  • platform/chromium-linux/editing/selection/extend-by-word-002-expected.checksum:
  • platform/chromium-linux/editing/selection/extend-by-word-002-expected.png:
  • platform/chromium-linux/fast/css/background-shorthand-invalid-url-expected.checksum:
  • platform/chromium-linux/fast/css/background-shorthand-invalid-url-expected.png:
  • platform/chromium-linux/fast/doctypes/002-expected.checksum:
  • platform/chromium-linux/fast/doctypes/002-expected.png:
  • platform/chromium-linux/fast/lists/001-vertical-expected.checksum:
  • platform/chromium-linux/fast/lists/001-vertical-expected.png:
  • platform/chromium-linux/fast/lists/001-vertical-expected.txt: Removed.
  • platform/chromium-linux/fast/lists/002-expected.checksum:
  • platform/chromium-linux/fast/lists/002-expected.png:
  • platform/chromium-linux/fast/lists/002-vertical-expected.checksum:
  • platform/chromium-linux/fast/lists/002-vertical-expected.png:
  • platform/chromium-linux/fast/lists/002-vertical-expected.txt: Removed.
  • platform/chromium-linux/fast/lists/003-expected.checksum:
  • platform/chromium-linux/fast/lists/003-expected.png:
  • platform/chromium-linux/fast/lists/003-vertical-expected.checksum:
  • platform/chromium-linux/fast/lists/003-vertical-expected.png:
  • platform/chromium-linux/fast/lists/003-vertical-expected.txt: Removed.
  • platform/chromium-linux/fast/lists/007-vertical-expected.checksum:
  • platform/chromium-linux/fast/lists/007-vertical-expected.png:
  • platform/chromium-linux/fast/lists/007-vertical-expected.txt: Removed.
  • platform/chromium-linux/fast/lists/008-vertical-expected.checksum:
  • platform/chromium-linux/fast/lists/008-vertical-expected.png:
  • platform/chromium-linux/fast/lists/008-vertical-expected.txt: Removed.
  • platform/chromium-linux/fast/lists/marker-before-empty-inline-expected.checksum:
  • platform/chromium-linux/fast/lists/marker-before-empty-inline-expected.png:
  • platform/chromium-linux/fast/lists/outSideListMarkers-expected.checksum: Added.
  • platform/chromium-linux/fast/lists/outSideListMarkers-expected.png: Added.
  • platform/chromium-mac/css1/box_properties/margin_right-expected.checksum:
  • platform/chromium-mac/css1/box_properties/margin_right-expected.png:
  • platform/chromium-mac/css1/box_properties/padding_right-expected.checksum:
  • platform/chromium-mac/css1/box_properties/padding_right-expected.png:
  • platform/chromium-mac/css2.1/t0805-c5520-brdr-b-01-e-expected.checksum:
  • platform/chromium-mac/css2.1/t0805-c5520-brdr-b-01-e-expected.png:
  • platform/chromium-mac/editing/pasteboard/merge-end-list-expected.checksum: Removed.
  • platform/chromium-mac/editing/pasteboard/merge-end-list-expected.png: Removed.
  • platform/chromium-mac/editing/selection/extend-by-word-002-expected.checksum: Removed.
  • platform/chromium-mac/editing/selection/extend-by-word-002-expected.png: Removed.
  • platform/chromium-mac/fast/css/background-shorthand-invalid-url-expected.checksum: Removed.
  • platform/chromium-mac/fast/lists/008-vertical-expected.checksum:
  • platform/chromium-mac/fast/lists/008-vertical-expected.png:
  • platform/chromium-mac/fast/lists/marker-before-empty-inline-expected.checksum: Added.
  • platform/chromium-mac/fast/lists/marker-before-empty-inline-expected.png: Added.
  • platform/chromium-win/css1/box_properties/margin_right-expected.checksum:
  • platform/chromium-win/css1/box_properties/margin_right-expected.png:
  • platform/chromium-win/css1/box_properties/margin_right-expected.txt:
  • platform/chromium-win/css1/box_properties/padding_right-expected.checksum:
  • platform/chromium-win/css1/box_properties/padding_right-expected.png:
  • platform/chromium-win/css1/box_properties/padding_right-expected.txt:
  • platform/chromium-win/css2.1/t0805-c5520-brdr-b-01-e-expected.checksum:
  • platform/chromium-win/css2.1/t0805-c5520-brdr-b-01-e-expected.png:
  • platform/chromium-win/css2.1/t0805-c5520-brdr-b-01-e-expected.txt:
  • platform/chromium-win/editing/pasteboard/merge-end-list-expected.checksum:
  • platform/chromium-win/editing/pasteboard/merge-end-list-expected.png:
  • platform/chromium-win/editing/pasteboard/merge-end-list-expected.txt:
  • platform/chromium-win/editing/selection/extend-by-word-002-expected.checksum:
  • platform/chromium-win/editing/selection/extend-by-word-002-expected.png:
  • platform/chromium-win/editing/selection/extend-by-word-002-expected.txt:
  • platform/chromium-win/fast/css/background-shorthand-invalid-url-expected.checksum:
  • platform/chromium-win/fast/css/background-shorthand-invalid-url-expected.png:
  • platform/chromium-win/fast/css/background-shorthand-invalid-url-expected.txt:
  • platform/chromium-win/fast/doctypes/002-expected.checksum:
  • platform/chromium-win/fast/doctypes/002-expected.png:
  • platform/chromium-win/fast/doctypes/002-expected.txt:
  • platform/chromium-win/fast/lists/001-vertical-expected.checksum:
  • platform/chromium-win/fast/lists/001-vertical-expected.png:
  • platform/chromium-win/fast/lists/001-vertical-expected.txt:
  • platform/chromium-win/fast/lists/002-expected.checksum:
  • platform/chromium-win/fast/lists/002-expected.png:
  • platform/chromium-win/fast/lists/002-expected.txt:
  • platform/chromium-win/fast/lists/002-vertical-expected.checksum:
  • platform/chromium-win/fast/lists/002-vertical-expected.png:
  • platform/chromium-win/fast/lists/002-vertical-expected.txt:
  • platform/chromium-win/fast/lists/003-expected.checksum:
  • platform/chromium-win/fast/lists/003-expected.png:
  • platform/chromium-win/fast/lists/003-expected.txt:
  • platform/chromium-win/fast/lists/003-vertical-expected.checksum:
  • platform/chromium-win/fast/lists/003-vertical-expected.png:
  • platform/chromium-win/fast/lists/003-vertical-expected.txt:
  • platform/chromium-win/fast/lists/007-vertical-expected.checksum:
  • platform/chromium-win/fast/lists/007-vertical-expected.png:
  • platform/chromium-win/fast/lists/007-vertical-expected.txt:
  • platform/chromium-win/fast/lists/008-vertical-expected.checksum:
  • platform/chromium-win/fast/lists/008-vertical-expected.png:
  • platform/chromium-win/fast/lists/008-vertical-expected.txt:
  • platform/chromium-win/fast/lists/marker-before-empty-inline-expected.checksum:
  • platform/chromium-win/fast/lists/marker-before-empty-inline-expected.png:
  • platform/chromium-win/fast/lists/marker-before-empty-inline-expected.txt:
  • platform/chromium-win/fast/lists/outSideListMarkers-expected.checksum: Added.
  • platform/chromium-win/fast/lists/outSideListMarkers-expected.png: Added.
  • platform/chromium-win/fast/lists/outSideListMarkers-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
08:57 Changeset [72532] by ossy@webkit.org

Make WebKit2 compile with ENABLE_JAVASCRIPT_DEBUGGER=0

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2010-11-22
Reviewed by Andreas Kling.

  • WebProcess/WebPage/WebInspector.cpp: Add missing ENABLE(JAVASCRIPT_DEBUGGER) guards.

(WebKit::WebInspector::startJavaScriptDebugging):
(WebKit::WebInspector::stopJavaScriptDebugging):
(WebKit::WebInspector::startJavaScriptProfiling):
(WebKit::WebInspector::stopJavaScriptProfiling):

08:46 Changeset [72531] by loislo@chromium.org

2010-11-22 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: dump inspector protocol messages into console.
Sometimes I need to dump inspector messages into console.
It'd be much simple to have this code in repository and
enable protocol dumping just by a flag.

https://bugs.webkit.org/show_bug.cgi?id=49905

  • inspector/CodeGeneratorInspector.pm:
  • inspector/front-end/WorkersSidebarPane.js: (WebInspector.WorkersSidebarPane.prototype.reset):
  • inspector/front-end/inspector.js: (WebInspector_syncDispatch):
08:43 Changeset [72530] by ossy@webkit.org

Unreviewed. Update Qt specific expected results after r72527.

  • platform/qt/css1/box_properties/margin_right-expected.checksum: Added.
  • platform/qt/css1/box_properties/margin_right-expected.png: Added.
  • platform/qt/css1/box_properties/margin_right-expected.txt:
  • platform/qt/css1/box_properties/padding_right-expected.checksum: Added.
  • platform/qt/css1/box_properties/padding_right-expected.png: Added.
  • platform/qt/css1/box_properties/padding_right-expected.txt:
  • platform/qt/editing/pasteboard/merge-end-list-expected.checksum: Added.
  • platform/qt/editing/pasteboard/merge-end-list-expected.png: Added.
  • platform/qt/editing/pasteboard/merge-end-list-expected.txt:
  • platform/qt/fast/doctypes/002-expected.checksum: Added.
  • platform/qt/fast/doctypes/002-expected.png: Added.
  • platform/qt/fast/doctypes/002-expected.txt:
  • platform/qt/fast/lists/001-vertical-expected.checksum:
  • platform/qt/fast/lists/001-vertical-expected.png:
  • platform/qt/fast/lists/001-vertical-expected.txt:
  • platform/qt/fast/lists/002-vertical-expected.checksum:
  • platform/qt/fast/lists/002-vertical-expected.png:
  • platform/qt/fast/lists/002-vertical-expected.txt:
  • platform/qt/fast/lists/003-vertical-expected.checksum:
  • platform/qt/fast/lists/003-vertical-expected.png:
  • platform/qt/fast/lists/003-vertical-expected.txt:
  • platform/qt/fast/lists/007-vertical-expected.checksum:
  • platform/qt/fast/lists/007-vertical-expected.png:
  • platform/qt/fast/lists/007-vertical-expected.txt:
  • platform/qt/fast/lists/008-vertical-expected.checksum:
  • platform/qt/fast/lists/008-vertical-expected.png:
  • platform/qt/fast/lists/008-vertical-expected.txt:
  • platform/qt/fast/lists/outSideListMarkers-expected.checksum: Added.
  • platform/qt/fast/lists/outSideListMarkers-expected.png: Added.
  • platform/qt/fast/lists/outSideListMarkers-expected.txt: Added.
08:18 Changeset [72529] by andreas.kling@nokia.com

2010-11-22 Andreas Kling <kling@webkit.org>

Unreviewed, 2 missing rebaselines after r72527.

  • platform/mac/css2.1/t0805-c5520-brdr-b-01-e-expected.txt:
  • platform/mac/fast/lists/marker-before-empty-inline-expected.txt:
07:52 Changeset [72528] by andreas.kling@nokia.com

2010-11-22 Andreas Kling <kling@webkit.org>

Reviewed by Nikolas Zimmermann.

GraphicsContext: Make drawFocusRing() take a Path instead of a Vector<Path>
https://bugs.webkit.org/show_bug.cgi?id=49840

This avoid copying a Path object when drawing focus rings.

  • platform/graphics/GraphicsContext.h:
  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::drawFocusRing):
  • platform/graphics/haiku/GraphicsContextHaiku.cpp: (WebCore::GraphicsContext::drawFocusRing):
  • platform/graphics/mac/GraphicsContextMac.mm: (WebCore::GraphicsContext::drawFocusRing):
  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::drawFocusRing):
  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::drawFocusRing):
  • platform/graphics/win/GraphicsContextCGWin.cpp: (WebCore::GraphicsContext::drawFocusRing):
  • platform/graphics/wince/GraphicsContextWinCE.cpp: (WebCore::GraphicsContext::drawFocusRing):
  • platform/graphics/wx/GraphicsContextWx.cpp: (WebCore::GraphicsContext::drawFocusRing):
  • rendering/RenderImage.h:
  • rendering/RenderImage.cpp: (WebCore::RenderImage::paint): (WebCore::RenderImage::paintFocusRing): Renamed from paintFocusRings since it only paints one ring.
07:13 Changeset [72527] by reni@webkit.org

Outside list bullets ignore text-align style.
https://bugs.webkit.org/show-bug.cgi?id=15713

Patch by Renata Hodovan <reni@webkit.org> on 2010-11-22
Reviewed by Andreas Kling.

WebCore:

Fix the position of outside markers by setting its logicalLeft member. Embedded markers need special treatment.
First, the total width of markers should be calculated. Subtracting it from logicalLeft we get the outermost bullet's
position. As for the others, this sum should be decremented with the previous marker's width.
In case of vertical markers the padding is unneeded.

Test: fast/lists/outSideListMarkers.html

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::placeBoxesInInlineDirection):

  • rendering/RenderListItem.cpp:

(WebCore::RenderListItem::positionListMarker):

LayoutTests:

Add new test for checking outside marker's position and update the related expecteds of tests.

  • fast/lists/outSideListMarkers-expected.txt: Added.
  • fast/lists/outSideListMarkers.html: Added.
  • platform/mac-leopard/css1/box_properties/margin_right-expected.checksum:
  • platform/mac-leopard/css1/box_properties/margin_right-expected.png:
  • platform/mac-leopard/css1/box_properties/padding_right-expected.checksum:
  • platform/mac-leopard/css1/box_properties/padding_right-expected.png:
  • platform/mac-leopard/editing/pasteboard/merge-end-list-expected.checksum:
  • platform/mac-leopard/editing/pasteboard/merge-end-list-expected.png:
  • platform/mac-leopard/fast/css/background-shorthand-invalid-url-expected.checksum:
  • platform/mac-leopard/fast/css/background-shorthand-invalid-url-expected.png:
  • platform/mac-leopard/fast/css/empty-pseudo-class-expected.checksum:
  • platform/mac-leopard/fast/css/empty-pseudo-class-expected.png:
  • platform/mac-leopard/fast/css/first-child-pseudo-class-expected.checksum:
  • platform/mac-leopard/fast/css/first-child-pseudo-class-expected.png:
  • platform/mac-leopard/fast/css/first-of-type-pseudo-class-expected.checksum:
  • platform/mac-leopard/fast/css/first-of-type-pseudo-class-expected.png:
  • platform/mac-leopard/fast/css/last-child-pseudo-class-expected.checksum:
  • platform/mac-leopard/fast/css/last-child-pseudo-class-expected.png:
  • platform/mac-leopard/fast/css/last-of-type-pseudo-class-expected.checksum:
  • platform/mac-leopard/fast/css/last-of-type-pseudo-class-expected.png:
  • platform/mac-leopard/fast/css/only-child-pseudo-class-expected.checksum:
  • platform/mac-leopard/fast/css/only-child-pseudo-class-expected.png:
  • platform/mac-leopard/fast/css/only-of-type-pseudo-class-expected.checksum:
  • platform/mac-leopard/fast/css/only-of-type-pseudo-class-expected.png:
  • platform/mac-leopard/fast/doctypes/002-expected.checksum:
  • platform/mac-leopard/fast/doctypes/002-expected.png:
  • platform/mac-leopard/fast/lists/001-expected.checksum:
  • platform/mac-leopard/fast/lists/001-expected.png:
  • platform/mac-leopard/fast/lists/002-expected.checksum:
  • platform/mac-leopard/fast/lists/002-expected.png:
  • platform/mac-leopard/fast/lists/003-expected.checksum:
  • platform/mac-leopard/fast/lists/003-expected.png:
  • platform/mac/css1/box_properties/margin_right-expected.txt:
  • platform/mac/css1/box_properties/padding_right-expected.txt:
  • platform/mac/editing/pasteboard/merge-end-list-expected.txt:
  • platform/mac/editing/selection/extend-by-word-002-expected.checksum:
  • platform/mac/editing/selection/extend-by-word-002-expected.png:
  • platform/mac/editing/selection/extend-by-word-002-expected.txt:
  • platform/mac/fast/css/background-shorthand-invalid-url-expected.txt:
  • platform/mac/fast/css/empty-pseudo-class-expected.txt:
  • platform/mac/fast/css/first-child-pseudo-class-expected.txt:
  • platform/mac/fast/css/first-of-type-pseudo-class-expected.txt:
  • platform/mac/fast/css/last-child-pseudo-class-expected.txt:
  • platform/mac/fast/css/last-of-type-pseudo-class-expected.txt:
  • platform/mac/fast/css/only-child-pseudo-class-expected.txt:
  • platform/mac/fast/css/only-of-type-pseudo-class-expected.txt:
  • platform/mac/fast/doctypes/002-expected.txt:
  • platform/mac/fast/lists/001-expected.txt:
  • platform/mac/fast/lists/001-vertical-expected.checksum:
  • platform/mac/fast/lists/001-vertical-expected.png:
  • platform/mac/fast/lists/001-vertical-expected.txt:
  • platform/mac/fast/lists/002-expected.txt:
  • platform/mac/fast/lists/002-vertical-expected.checksum:
  • platform/mac/fast/lists/002-vertical-expected.png:
  • platform/mac/fast/lists/002-vertical-expected.txt:
  • platform/mac/fast/lists/003-expected.txt:
  • platform/mac/fast/lists/003-vertical-expected.checksum:
  • platform/mac/fast/lists/003-vertical-expected.png:
  • platform/mac/fast/lists/003-vertical-expected.txt:
  • platform/mac/fast/lists/007-vertical-expected.checksum:
  • platform/mac/fast/lists/007-vertical-expected.png:
  • platform/mac/fast/lists/007-vertical-expected.txt:
  • platform/mac/fast/lists/008-vertical-expected.checksum:
  • platform/mac/fast/lists/008-vertical-expected.png:
  • platform/mac/fast/lists/008-vertical-expected.txt:
  • platform/mac/fast/lists/outSideListMarkers-expected.checksum: Added.
  • platform/mac/fast/lists/outSideListMarkers-expected.png: Added.
06:57 Changeset [72526] by yael.aharon@nokia.com

2010-11-22 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Antonio Gomes.

Spatial Navigation: Additional tests.
https://bugs.webkit.org/show_bug.cgi?id=49604

  • fast/events/spatial-navigation/snav-div-overflow-scrol-hidden-expected.txt: Added.
  • fast/events/spatial-navigation/snav-div-overflow-scrol-hidden.html: Added.
  • fast/events/spatial-navigation/snav-z-index-expected.txt: Added.
  • fast/events/spatial-navigation/snav-z-index.html: Added.
06:40 Changeset [72525] by antonm@chromium.org

Not reviewed. Rebaselining various Win/Linux only deviations.

  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.png: Added.
  • platform/chromium-linux/svg/custom/baseval-animval-equality-expected.checksum:
  • platform/chromium-linux/svg/custom/baseval-animval-equality-expected.png:
  • platform/chromium-linux/svg/dom/SVGPathSegList-segment-modification-expected.checksum: Added.
  • platform/chromium-linux/svg/dom/SVGPathSegList-segment-modification-expected.png: Added.
  • platform/chromium-linux/svg/dom/SVGPathSegList-xml-dom-synchronization-expected.checksum: Added.
  • platform/chromium-linux/svg/dom/SVGPathSegList-xml-dom-synchronization-expected.png: Added.
  • platform/chromium-linux/svg/dom/SVGPathSegList-xml-dom-synchronization2-expected.checksum: Added.
  • platform/chromium-linux/svg/dom/SVGPathSegList-xml-dom-synchronization2-expected.png: Added.
  • platform/chromium-linux/svg/dom/path-parser-expected.txt: Removed.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.txt: Added.
  • platform/chromium-win/svg/custom/baseval-animval-equality-expected.checksum:
  • platform/chromium-win/svg/custom/baseval-animval-equality-expected.png:
  • platform/chromium-win/svg/custom/baseval-animval-equality-expected.txt:
  • platform/chromium-win/svg/dom/SVGPathSegList-segment-modification-expected.checksum: Added.
  • platform/chromium-win/svg/dom/SVGPathSegList-segment-modification-expected.png: Added.
  • platform/chromium-win/svg/dom/SVGPathSegList-segment-modification-expected.txt: Added.
  • platform/chromium-win/svg/dom/SVGPathSegList-xml-dom-synchronization-expected.checksum: Added.
  • platform/chromium-win/svg/dom/SVGPathSegList-xml-dom-synchronization-expected.png: Added.
  • platform/chromium-win/svg/dom/SVGPathSegList-xml-dom-synchronization2-expected.checksum: Added.
  • platform/chromium-win/svg/dom/SVGPathSegList-xml-dom-synchronization2-expected.png: Added.
  • platform/chromium-win/svg/dom/SVGPathSegList-xml-dom-synchronization2-expected.txt: Added.
  • platform/chromium-win/svg/dom/path-parser-expected.txt: Added.
  • platform/chromium-win/svg/filters/filter-rounding-issues-expected.checksum: Added.
  • platform/chromium-win/svg/filters/filter-rounding-issues-expected.png: Added.
  • platform/chromium/test_expectations.txt:
06:37 Changeset [72524] by ossy@webkit.org

Unreviewed.

[Qt] fast/workers/storage/interrupt-database-sync.html fails intermittently
https://bugs.webkit.org/show_bug.cgi?id=49906

  • platform/qt/Skipped: fast/workers/storage/interrupt-database-sync.html added until fix.
06:12 Changeset [72523] by ossy@webkit.org

Unreviewed.

[Qt] Add platform specific expected results for new passing tests.
Compared to Mac png files and Mac expected files.

  • platform/qt/fast/css/negative-leading-expected.checksum: Added.
  • platform/qt/fast/css/negative-leading-expected.png: Added.
  • platform/qt/fast/css/negative-leading-expected.txt: Added. (introduced in r72141)
  • platform/qt/fast/images/imagemap-focus-ring-zoom-expected.checksum: Added.
  • platform/qt/fast/images/imagemap-focus-ring-zoom-expected.png: Added.
  • platform/qt/fast/images/imagemap-focus-ring-zoom-expected.txt: Added. (introduced in r72402)
  • platform/qt/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.checksum: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.png: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt: Added. (introduced in r72381)
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.checksum: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.png: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.txt: Added. (introduced in r72518)
  • platform/qt/svg/custom/image-rescale-expected.checksum: Added.
  • platform/qt/svg/custom/image-rescale-expected.png: Added.
  • platform/qt/svg/custom/image-rescale-expected.txt: Added. (introduced in r72470)
  • platform/qt/svg/custom/image-rescale-scroll-expected.checksum: Added.
  • platform/qt/svg/custom/image-rescale-scroll-expected.png: Added.
  • platform/qt/svg/custom/image-rescale-scroll-expected.txt: Added. (introduced in r72470)
  • platform/qt/svg/dom/SVGPathSegList-cloning-expected.checksum: Added.
  • platform/qt/svg/dom/SVGPathSegList-cloning-expected.png: Added.
  • platform/qt/svg/dom/SVGPathSegList-cloning-expected.txt: Added. (introduced in r72381)
  • platform/qt/svg/dom/SVGPathSegList-segment-modification-expected.checksum: Added.
  • platform/qt/svg/dom/SVGPathSegList-segment-modification-expected.png: Added.
  • platform/qt/svg/dom/SVGPathSegList-segment-modification-expected.txt: Added. (introduced in r72381)
  • platform/qt/svg/dom/SVGPathSegList-xml-dom-synchronization2-expected.checksum: Added.
  • platform/qt/svg/dom/SVGPathSegList-xml-dom-synchronization2-expected.png: Added.
  • platform/qt/svg/dom/SVGPathSegList-xml-dom-synchronization2-expected.txt: Added. (introduced in r72381)
05:49 Changeset [72522] by yael.aharon@nokia.com

Spatial Navigation: issues with the node selection algorithm.
https://bugs.webkit.org/show_bug.cgi?id=49382

Patch by Yael Aharon <yael.aharon@nokia.com>, Chang Shu <chang.shu@nokia.com> on 2010-11-22
Reviewed by Antonio Gomes.

WebCore:

Modify the Spatial Navigation algorithm, to better handle initial focus and
navigation between frames.
The new algorithm takes the rect of the focused node as the startingRect,
instead of the node itself. That allows us to construct a virtual rect if
there is no focused node, or if it is off the screen.
The virtual rect is the edge of the container in the direction of the navigation.

With this patch, scrollable containers and frames will scroll regardless of weather
they have focusable content. Users will be able to use arrow keys to view all the
content of such a container. The only exception is if the container has style overflow:hidden.
We will not scroll in that case.

With this patch, we handle z-index and positioning so that if there are 2 overlapping focusable nodes,
we do a hit test and only the node on top can get focus.

hasOffScreenRect() was modified so that it can check if a node will be off-screen even after we scrolled
its parent container. We do not add the scrolling conditions for containers that have overflow:hidden
and cannot scroll.

calculateScrollbarModesForLayout is used to decide if a frame can scroll or not. We cannot rely on
the exsistance of the scrollbar, because it could be removed via the API, while the frame is still
allowed to scroll.

  • page/FocusController.cpp:

(WebCore::updateFocusCandidateIfNeeded):
(WebCore::FocusController::findFocusCandidateInContainer):
(WebCore::FocusController::advanceFocusDirectionallyInContainer):
(WebCore::FocusController::advanceFocusDirectionally):

  • page/FocusController.h:
  • page/FrameView.h:
  • page/SpatialNavigation.cpp:

(WebCore::FocusCandidate::FocusCandidate):
(WebCore::distanceDataForNode):
(WebCore::alignmentForRects):
(WebCore::areRectsMoreThanFullScreenApart):
(WebCore::isRectInDirection):
(WebCore::hasOffscreenRect):
(WebCore::scrollInDirection):
(WebCore::isScrollableContainerNode):
(WebCore::scrollableEnclosingBoxOrParentFrameForNodeInDirection):
(WebCore::canScrollInDirection):
(WebCore::rectToAbsoluteCoordinates):
(WebCore::nodeRectInAbsoluteCoordinates):
(WebCore::frameRectInAbsoluteCoordinates):
(WebCore::entryAndExitPointsForDirection):
(WebCore::canBeScrolledIntoView):
(WebCore::virtualRectForDirection):

  • page/SpatialNavigation.h:

LayoutTests:

Replaced text in tests with images with fixed size to make them more cross platform and modified
test results to reflect that we can scroll container that do not include focusable content.

  • fast/events/spatial-navigation/snav-clipped-overflowed-content-expected.txt:
  • fast/events/spatial-navigation/snav-clipped-overflowed-content.html:
  • fast/events/spatial-navigation/snav-div-scrollable-but-without-focusable-content-expected.txt:
  • fast/events/spatial-navigation/snav-div-scrollable-but-without-focusable-content.html:
  • fast/events/spatial-navigation/snav-iframe-no-focusable-content-expected.txt:
  • fast/events/spatial-navigation/snav-iframe-no-focusable-content.html:
  • fast/events/spatial-navigation/snav-iframe-no-scrollable-content-expected.txt:
  • fast/events/spatial-navigation/snav-iframe-no-scrollable-content.html:
  • fast/events/spatial-navigation/snav-iframe-with-offscreen-focusable-element-expected.txt:
  • fast/events/spatial-navigation/snav-iframe-with-offscreen-focusable-element.html:
05:29 Changeset [72521] by antonm@chromium.org

Amending suppressions from previous commit.

  • platform/chromium/test_expectations.txt:
05:25 Changeset [72520] by antonm@chromium.org

Not reviewed. Adding new suppressions after http://trac.webkit.org/changeset/72518

  • platform/chromium/test_expectations.txt:
04:53 Changeset [72519] by antonm@chromium.org

Not reviewed. Next batch of SVG rebaselines.

  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.png: Added.
  • platform/chromium-linux/svg/dom/SVGPathSegList-cloning-expected.checksum: Added.
  • platform/chromium-linux/svg/dom/SVGPathSegList-cloning-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.checksum: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt: Added.
  • platform/chromium-win/svg/custom/svg-curve-with-relative-cordinates-expected.txt:
  • platform/chromium-win/svg/dom/SVGPathSegList-cloning-expected.checksum: Added.
  • platform/chromium-win/svg/dom/SVGPathSegList-cloning-expected.png: Added.
  • platform/chromium-win/svg/dom/SVGPathSegList-cloning-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
04:32 Changeset [72518] by commit-queue@webkit.org

2010-11-22 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Fix various problems with the SVG*List code
https://bugs.webkit.org/show_bug.cgi?id=49880

Add tests for all SVG*List types, that were missing.
Add SVG 1.1 2nd edition testcase, types-dom-07-f.svg, testing that all animVal values are readonly.

  • platform/mac-leopard/svg/custom/baseval-animval-equality-expected.checksum:
  • platform/mac-leopard/svg/custom/baseval-animval-equality-expected.png:
  • platform/mac-leopard/svg/dom/SVGLengthList-basics-expected.checksum:
  • platform/mac-leopard/svg/dom/SVGLengthList-basics-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.checksum: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.png: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.txt: Added.
  • platform/mac/svg/custom/baseval-animval-equality-expected.txt:
  • platform/mac/svg/dom/SVGNumberList-basics-expected.checksum: Added.
  • platform/mac/svg/dom/SVGNumberList-basics-expected.png: Added.
  • platform/mac/svg/dom/SVGPointList-basics-expected.checksum: Added.
  • platform/mac/svg/dom/SVGPointList-basics-expected.png: Added.
  • platform/mac/svg/dom/SVGStringList-basics-expected.checksum: Added.
  • platform/mac/svg/dom/SVGStringList-basics-expected.png: Added.
  • platform/mac/svg/dom/SVGTransformList-basics-expected.checksum: Added.
  • platform/mac/svg/dom/SVGTransformList-basics-expected.png: Added.
  • svg/W3C-SVG-1.1-SE/types-dom-07-f.svg: Added.
  • svg/custom/baseval-animval-equality.svg: Fix wrong test.
  • svg/custom/polyline-points-crash-expected.txt:
  • svg/dom/SVGLengthList-basics-expected.txt:
  • svg/dom/SVGLengthList-basics.xhtml: Extended test, synchronized with the other SVG*List tests.
  • svg/dom/SVGNumberList-basics-expected.txt: Added.
  • svg/dom/SVGNumberList-basics.xhtml: Added.
  • svg/dom/SVGPointList-basics-expected.txt: Added.
  • svg/dom/SVGPointList-basics.xhtml: Added.
  • svg/dom/SVGStringList-basics-expected.txt: Added.
  • svg/dom/SVGStringList-basics.xhtml: Added.
  • svg/dom/SVGTransformList-basics-expected.txt: Added.
  • svg/dom/SVGTransformList-basics.xhtml: Added.
  • svg/dom/svglist-exception-on-out-bounds-error-expected.txt:

2010-11-22 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Fix various problems with the SVG*List code
https://bugs.webkit.org/show_bug.cgi?id=49880

Write tests for SVGNumberList/SVGPointList/SVGStringList/SVGTransformList and extend SVGLengthList tests.
SVG DOM <-> XML DOM synchronization is now tested for all these types, and works great. Unify the string format produced
by the various valueAsString() functions for maximum compatibility with Firefox / Opera.

  • Build a real transform string for SVGTransformList, instead of dumping the elements of the concatted matrix.
  • Add SVGStringList XML dom synchronization, only affects SVGTests requiredFeatures/requiredExtensions/systemLanguage.
  • Make all animVal properties readonly, tested by types-dom-07-f.svg (from SVG 1.1 2nd edition).
  • Enable StrictTypeChecking/RequiresAllArguments=Raise for all SVGList types.

Tests: svg/W3C-SVG-1.1-SE/types-dom-07-f.svg

svg/dom/SVGNumberList-basics.xhtml
svg/dom/SVGPointList-basics.xhtml
svg/dom/SVGStringList-basics.xhtml
svg/dom/SVGTransformList-basics.xhtml

  • bindings/js/JSSVGLengthCustom.cpp: (WebCore::JSSVGLength::setValue): Throw NO_MODIFICATION_ALLOWED_ERR when the SVGPropertyTearOffs role is AnimValRole. (WebCore::JSSVGLength::convertToSpecifiedUnits): Ditto.
  • bindings/scripts/CodeGeneratorJS.pm: Ditto.
  • bindings/scripts/CodeGeneratorObjC.pm: Ditto.
  • bindings/scripts/CodeGeneratorV8.pm: Ditto.
  • bindings/v8/custom/V8SVGLengthCustom.cpp: (WebCore::V8SVGLength::valueAccessorSetter): Ditto. (WebCore::V8SVGLength::convertToSpecifiedUnitsCallback): Ditto.
  • svg/SVGAElement.cpp: (WebCore::SVGAElement::synchronizeProperty): Also synchronize the SVGTests SVGStringLists.
  • svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::synchronizeProperty): Ditto.
  • svg/SVGCircleElement.cpp: (WebCore::SVGCircleElement::synchronizeProperty): Ditto.
  • svg/SVGClipPathElement.cpp: (WebCore::SVGClipPathElement::synchronizeProperty): Ditto.
  • svg/SVGCursorElement.cpp: (WebCore::SVGCursorElement::synchronizeProperty): Ditto.
  • svg/SVGDefsElement.cpp: (WebCore::SVGDefsElement::synchronizeProperty): Ditto.
  • svg/SVGEllipseElement.cpp: (WebCore::SVGEllipseElement::synchronizeProperty): Ditto.
  • svg/SVGForeignObjectElement.cpp: (WebCore::SVGForeignObjectElement::synchronizeProperty): Ditto.
  • svg/SVGGElement.cpp: (WebCore::SVGGElement::synchronizeProperty): Ditto.
  • svg/SVGImageElement.cpp: (WebCore::SVGImageElement::synchronizeProperty): Ditto.
  • svg/SVGLengthList.cpp: (WebCore::SVGLengthList::valueAsString): Use ' ' instead of ',' as seperator.
  • svg/SVGLengthList.idl: Enable StrictTypeChecking, RequiresAllArguments=Raise.
  • svg/SVGLineElement.cpp: (WebCore::SVGLineElement::synchronizeProperty): Also synchronize the SVGTests SVGStringLists.
  • svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::synchronizeProperty): Ditto.
  • svg/SVGNumberList.cpp: (WebCore::SVGNumberList::valueAsString): Use ' ' instead of ',' as seperator.
  • svg/SVGNumberList.idl: Enable StrictTypeChecking, RequiresAllArguments=Raise.
  • svg/SVGPathElement.cpp: (WebCore::SVGPathElement::synchronizeProperty): Also synchronize the SVGTests SVGStringLists.
  • svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::synchronizeProperty): Ditto.
  • svg/SVGPointList.idl: Enable StrictTypeChecking, RequiresAllArguments=Raise.
  • svg/SVGPolyElement.cpp: (WebCore::SVGPolyElement::synchronizeProperty): Also synchronize the SVGTests SVGStringLists.
  • svg/SVGRectElement.cpp: (WebCore::SVGRectElement::synchronizeProperty): Ditto.
  • svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::synchronizeProperty): Ditto.
  • svg/SVGStringList.cpp: (WebCore::SVGStringList::valueAsString): Add valueAsString() implementation, necessary for SVG DOM <-> XML DOM synchronization.
  • svg/SVGStringList.h:
  • svg/SVGStringList.idl: Enable StrictTypeChecking, RequiresAllArguments=Raise.
  • svg/SVGSwitchElement.cpp: (WebCore::SVGSwitchElement::synchronizeProperty): Also synchronize the SVGTests SVGStringLists.
  • svg/SVGTests.cpp: Rewrite, similar to SVGPolyElement, to synchronize the requiredFeatures/requiredExtension/systemLanguage SVGStringLists with their XML DOM attributes. (WebCore::SVGTests::SVGTests): (WebCore::SVGTests::isValid): (WebCore::SVGTests::parseMappedAttribute): (WebCore::SVGTests::isKnownAttribute): (WebCore::SVGTests::handleAttributeChange): (WebCore::SVGTests::synchronizeProperties): To be called by all classes inheriting from SVGTests, in their synchronizeProperty() methods. (WebCore::SVGTests::synchronizeRequiredFeatures): (WebCore::SVGTests::synchronizeRequiredExtensions): (WebCore::SVGTests::synchronizeSystemLanguage): (WebCore::SVGTests::requiredFeatures): (WebCore::SVGTests::requiredExtensions): (WebCore::SVGTests::systemLanguage):
  • svg/SVGTests.h:
  • svg/SVGTextContentElement.cpp: (WebCore::SVGTextContentElement::synchronizeProperty): Also synchronize the SVGTests SVGStringLists.
  • svg/SVGTransform.cpp: (WebCore::SVGTransform::valueAsString): Added a proper way to serialize a SVGTransform into a String.
  • svg/SVGTransform.h:
  • svg/SVGTransformList.cpp: (WebCore::SVGTransformList::valueAsString): Rewrite, to build a real transform list string, instead of dumping the concatted matrix.
  • svg/SVGUseElement.cpp: (WebCore::SVGUseElement::synchronizeProperty): Also synchronize the SVGTests SVGStringLists.
  • svg/properties/SVGListProperty.h: s/TYPE_MISMATCH_ERR/SVGException::SVG_WRONG_TYPE_ERR/ for compatibility with Firefox. (WebCore::SVGListProperty::initializeValuesAndWrappers): (WebCore::SVGListProperty::insertItemBeforeValuesAndWrappers): (WebCore::SVGListProperty::replaceItemValues): (WebCore::SVGListProperty::replaceItemValuesAndWrappers): (WebCore::SVGListProperty::removeItemValuesAndWrappers): Handle corner case, the item passed to removeItem() was the only on in the list, list is empty now, nothing to replace. (WebCore::SVGListProperty::appendItemValuesAndWrappers): (WebCore::SVGListProperty::role): Expose the role of this list property.
  • svg/properties/SVGPathSegListPropertyTearOff.h: s/TYPE_MISMATCH_ERR/SVGException::SVG_WRONG_TYPE_ERR/ for compatibility with Firefox. (WebCore::SVGPathSegListPropertyTearOff::initialize): (WebCore::SVGPathSegListPropertyTearOff::insertItemBefore): (WebCore::SVGPathSegListPropertyTearOff::replaceItem): (WebCore::SVGPathSegListPropertyTearOff::appendItem):
  • svg/properties/SVGProperty.h: Add new virtual SVGPropertyRole role() accessor.
  • svg/properties/SVGPropertyTearOff.h: (WebCore::SVGPropertyTearOff::create): Store the passed in SVGProperyRole, instead of ignoring it. (WebCore::SVGPropertyTearOff::role): (WebCore::SVGPropertyTearOff::SVGPropertyTearOff):
  • svg/properties/SVGStaticPropertyTearOff.h: (WebCore::SVGStaticPropertyTearOff::SVGStaticPropertyTearOff): Pass UndefinedRole as default role to SVGPropertyTearOff.
  • svg/properties/SVGStaticPropertyWithParentTearOff.h: Ditto. (WebCore::SVGStaticPropertyWithParentTearOff::SVGStaticPropertyWithParentTearOff):
04:11 Changeset [72517] by antonm@chromium.org

Not reviewed. Rebaselining fast/images/imagemap-focus-ring-zoom.html for Chromium on Win and Linux.

  • platform/chromium-linux/fast/images/imagemap-focus-ring-zoom-expected.checksum: Added.
  • platform/chromium-linux/fast/images/imagemap-focus-ring-zoom-expected.png: Added.
  • platform/chromium-win/fast/images/imagemap-focus-ring-zoom-expected.checksum: Added.
  • platform/chromium-win/fast/images/imagemap-focus-ring-zoom-expected.png: Added.
  • platform/chromium-win/fast/images/imagemap-focus-ring-zoom-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
04:02 Changeset [72516] by antonm@chromium.org

Not reviewed. Rebaselining svg/custom/image-rescale.svg for Chromium on Mac.

  • platform/chromium-mac/svg/custom/image-rescale-expected.checksum: Added.
  • platform/chromium-mac/svg/custom/image-rescale-expected.png: Added.
  • platform/chromium/test_expectations.txt:
03:57 Changeset [72515] by antonm@chromium.org

Not reviewed, removing suppression for now passing editing/selection/5354455-1.html (on Win)

  • platform/chromium/test_expectations.txt:
02:53 Changeset [72514] by antonm@chromium.org

Not reviewed, proper platform for international test.

  • platform/chromium/test_expectations.txt:
02:51 Changeset [72513] by antonm@chromium.org

Not reviewed, Chromium suppressions for a bunch of SVG tests and one international.

  • platform/chromium/test_expectations.txt:
02:26 Changeset [72512] by antonm@chromium.org

Not reviewed, temporary suppressing fast/css/font-face-data-uri.html for Chromium.

  • platform/chromium/test_expectations.txt:
02:22 Changeset [72511] by pfeldman@chromium.org

2010-11-22 Pavel Feldman <pfeldman@chromium.org>

Not reviewed. Partially roll out r72282.
It should not have modified devtools files.

  • src/js/devTools.css:
01:59 Changeset [72510] by commit-queue@webkit.org

2010-11-22 Jan Erik Hanssen <jhanssen@sencha.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] QWebElement::appendInside() doesn't work on head elements
https://bugs.webkit.org/show_bug.cgi?id=49166

Make QWebElement::appendInside() call
Element::deprecatedCreateContextualFragment(), bypassing the check for
the HEAD tag in the HTMLElement implementation of this function.

  • Api/qwebelement.cpp: (QWebElement::appendInside):
  • tests/qwebelement/tst_qwebelement.cpp: (tst_QWebElement::addElementToHead):
01:58 Changeset [72509] by antonm@chromium.org

Not reviewed. Suppressing fast/canvas/canvas-fillPath-shadow.html for Chromium-gpu.

  • platform/chromium-gpu/test_expectations.txt:
01:53 Changeset [72508] by antonm@chromium.org

Not reviewed, remove duplicate suppression.

  • platform/chromium/test_expectations.txt:
01:30 Changeset [72507] by antonm@chromium.org

Not reviewed. Suppressing fast/canvas/canvas-fillPath-shadow.html for Chromium.

  • platform/chromium/test_expectations.txt:
01:27 Changeset [72506] by commit-queue@webkit.org

2010-11-22 João Paulo Rechi Vita <jprvita@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

Fix EWebLauncher zoom discretization
https://bugs.webkit.org/show_bug.cgi?id=49810

  • EWebLauncher/main.c: (nearest_zoom_level_get): (zoom_level_set): (on_load_finished): (on_key_down):
01:26 Changeset [72505] by antonm@chromium.org

Not reviewed. Rebaselining fast/js/regexp-overflow.html expectations
for Chromium after http://trac.webkit.org/changeset/72489

  • platform/chromium-mac/fast/js/regexp-overflow-expected.txt: Added.
  • platform/chromium-win/fast/js/regexp-overflow-expected.txt: Added.
00:41 Changeset [72504] by yuzo@google.com

2010-11-22 Yuzo Fujishima <yuzo@google.com>

Reviewed by Dan Bernstein.

Fix for Bug 49374 - Web Font specified with base64 data URI ending with EOT is not rendered.
https://bugs.webkit.org/show_bug.cgi?id=49374

  • fast/css/font-face-data-uri-expected.txt: Added.
  • fast/css/font-face-data-uri.html: Added.

2010-11-22 Yuzo Fujishima <yuzo@google.com>

Reviewed by Dan Bernstein.

Fix for Bug 49374 - Web Font specified with base64 data URI ending with EOT is not rendered.
https://bugs.webkit.org/show_bug.cgi?id=49374

Test: fast/css/font-face-data-uri.html

  • css/CSSFontFaceSrcValue.cpp: (WebCore::CSSFontFaceSrcValue::isSupportedFormat): Do not check "file extension" for data URI. For other URI, check against ".eot" rather than "eot".

11/21/10:

19:03 Changeset [72503] by weinig@apple.com

Update WebKit2 skipped list.

  • platform/mac-wk2/Skipped:
18:16 Changeset [72502] by weinig@apple.com

Fix ~300 WebKit2 tests by enabling developer extras preference.

Rubber-stamped by Dan Bernstein.

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetStateToConsistentValues):

18:08 Changeset [72501] by weinig@apple.com

Textareas should be resizable by default
https://bugs.webkit.org/show_bug.cgi?id=49892

Reviewed by Dan Bernstein.

WebKit2:

Test: WebKit2/WKPreferences

  • Shared/WebPreferencesStore.cpp:

(WebKit::WebPreferencesStore::WebPreferencesStore):
(WebKit::WebPreferencesStore::encode):
(WebKit::WebPreferencesStore::decode):

  • Shared/WebPreferencesStore.h:

Add textAreasAreResizable bit.

  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetJavaEnabled):
(WKPreferencesGetJavaEnabled):
Fix typo, WKPRe... -> WKPre...

(WKPreferencesSetMinimumFontSize):
(WKPreferencesGetMinimumFontSize):
Fix comment to correctly reflect that the default minimumFontSize is 0, not 1.

(WKPreferencesSetTextAreasAreResizable):
(WKPreferencesGetTextAreasAreResizable):

  • UIProcess/API/C/WKPreferences.h:

Add API.

  • UIProcess/API/C/WKPreferencesPrivate.h:

Don't use PLATFORM in API headers.

  • UIProcess/WebPreferences.cpp:

(WebKit::WebPreferences::setTextAreasAreResizable):
(WebKit::WebPreferences::textAreasAreResizable):

  • UIProcess/WebPreferences.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):
Pipe bit through to the WebProcess and onto WebCore::Settings.

WebKitTools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp: Added.
  • TestWebKitAPI/win/TestWebKitAPI.vcproj:

Add preferences test.

16:10 Changeset [72500] by paroga@webkit.org

2010-11-21 Patrick Gansterer <paroga@webkit.org>

Reviewed by Csaba Osztrogonác.

Use WTF_ARRAY_LENGTH in WebCore directory
https://bugs.webkit.org/show_bug.cgi?id=49882

  • accessibility/AccessibilityObject.cpp: (WebCore::createARIARoleMap):
  • bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::JSDOMWindowBase):
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/scripts/test/V8/V8TestObj.cpp: (WebCore::ConfigureV8TestObjTemplate):
  • css/CSSComputedStyleDeclaration.cpp:
  • css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::getPropertyValue):
  • css/CSSParser.cpp: (WebCore::CSSParser::parseAnimationShorthand): (WebCore::CSSParser::parseTransitionShorthand):
  • css/CSSPropertyLonghand.cpp: (WebCore::initShorthandMap):
  • dom/ExceptionCode.cpp: (WebCore::getExceptionCodeDescription):
  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::removeImplicitlyStyledElement):
  • editing/EditingStyle.cpp:
  • editing/Editor.cpp: (WebCore::triStateOfStyle):
  • editing/EditorCommand.cpp: (WebCore::createCommandMap):
  • editing/MarkupAccumulator.cpp: (WebCore::appendCharactersReplacingEntities):
  • html/canvas/WebGLBuffer.cpp: (WebCore::WebGLBuffer::getCachedMaxIndex): (WebCore::WebGLBuffer::setCachedMaxIndex):
  • loader/FTPDirectoryParser.cpp: (WebCore::parseOneFTPLine):
  • mathml/RenderMathMLOperator.cpp: (WebCore::RenderMathMLOperator::updateFromElement):
  • page/animation/AnimationBase.cpp: (WebCore::addShorthandProperties):
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::hasValidAvgCharWidth):
  • rendering/break_lines.cpp:
  • svg/SVGTransformable.cpp: (WebCore::parseAndSkipType):
  • svg/SVGViewSpec.cpp: (WebCore::SVGViewSpec::parseViewSpec):
  • svg/SVGZoomAndPan.cpp: (WebCore::SVGZoomAndPan::parseZoomAndPan):
  • xml/XPathFunctions.cpp: (WebCore::XPath::createFunctionMap):
15:03 Changeset [72499] by mario@webkit.org

2010-11-21 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Chris Fleizach.

[GTK] Implement ROLE_COMBO_BOX
https://bugs.webkit.org/show_bug.cgi?id=25678

Implement the remaining bits for combo boxes.

This patch finishes the implementation, from the point of view of
the Atk library, of those objects exposed to ATK as combo boxes,
and their related elements (menus and menu items). It therefore
implements the proper interfaces for each type of object related
to combo boxes (AtkSelection for the combo box, AtkText for every
menu item and AtkAction for the combo box, the menu and the menu
items), takes care of emitting the proper signals when focus or a
given a selection changes and adds a new unit test to check all
this new stuff.

Make possible to ask an AccessibleMenuListOption for a sensible
string representation, so far only available through the private
and MSAA related method nameForMSAA. Just moved the implementation
of that method to an overriden version of stringValue(), which is
platform independent, and called that from nameForMSAA().

  • accessibility/AccessibilityMenuListOption.h:
  • accessibility/AccessibilityMenuListOption.cpp: (WebCore::AccessibilityMenuListOption::nameForMSAA): Just call to stringValue(), which holds from now on that used to be here. (WebCore::AccessibilityMenuListOption::stringValue): New, override of AccessibilityObject::stringValue() to return a proper string.

Emit the missing signals when a selection is made.

  • accessibility/gtk/AXObjectCacheAtk.cpp: (WebCore::AXObjectCache::postPlatformNotification): Emit the usual 'focus' signals when a selection is made over the combo box.
  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (setAtkStateSetFromCoreObject): Ensure the EXPANDABLE and EXPANDED Atk states are added to the state set when needed. (listObjectForSelection): New, returns the proper list object (the one holding the list of available options as its children) for an specific AtkObject implementing AtkSelection. This is needed because sometimes the selectable options are not directly children of the AtkSelection object (i.e. a combo box has a 'menu' object as its only child of it, holding the list of options as children). (optionFromList): Use listObjectForSelection() to get the actual object holding the list of children as the available options. (optionFromSelection): Add support for combo boxes. (webkit_accessible_selection_add_selection): Ditto. (webkit_accessible_selection_clear_selection): Ditto. (webkit_accessible_selection_get_selection_count): Ditto. (webkit_accessible_selection_is_child_selected): Ditto. (webkit_accessible_selection_remove_selection): Ditto. (webkit_accessible_text_get_text): Makes sure stringValue() is considered to get the result substring when it was already considered when checking the maximum text length for the object. (getInterfaceMaskFromObject): Make sure the AtkSelection interface is implemented for the combo boxes, that the AtkText is implemented for the menu items and that the AtkAction interface is now implemented for every object (WebCore will decide what to do).

Avoid a segfault crash when using this from unit tests.

  • platform/gtk/PopupMenuGtk.cpp: (WebCore::PopupMenuGtk::show): Make sure we got a valid GdkWindow before calling gdk_window_get_origin() over it.

2010-11-21 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Chris Fleizach.

[GTK] Implement ROLE_COMBO_BOX
https://bugs.webkit.org/show_bug.cgi?id=25678

New test to check the implementation of the combo boxes.

  • tests/testatk.c: (testWebkitAtkComboBox): New test, checking that the roles and the implemented interfaces for a combo box and its descendants work. (main): Added the new unit test.
09:09 Changeset [72498] by paroga@webkit.org

2010-11-21 Patrick Gansterer <paroga@webkit.org>

Reviewed by Csaba Osztrogonác.

Use WTF_ARRAY_LENGTH in WebCore/platform directory
https://bugs.webkit.org/show_bug.cgi?id=49881

  • platform/KURL.cpp: (WebCore::portAllowed):
  • platform/KURLGoogle.cpp: (WebCore::portAllowed):
  • platform/MIMETypeRegistry.cpp: (WebCore::initializeSupportedImageMIMETypes): (WebCore::initializeSupportedJavaScriptMIMETypes): (WebCore::initializeSupportedNonImageMimeTypes):
  • platform/UUID.cpp: (WebCore::createCanonicalUUIDString):
  • platform/efl/RenderThemeEfl.cpp: (WebCore::RenderThemeEfl::applyEdjeStateFromForm):
  • platform/graphics/GraphicsTypes.cpp:
  • platform/graphics/chromium/FontCacheChromiumWin.cpp: (WebCore::FontCodepage::if):
  • platform/graphics/chromium/FontUtilsChromiumWin.cpp:
  • platform/graphics/mac/ComplexTextControllerCoreText.cpp: (WebCore::ComplexTextController::collectComplexTextRunsForCharactersCoreText):
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::disableComponentsOnce):
  • platform/graphics/mac/SimpleFontDataATSUI.mm: (WebCore::SimpleFontData::checkShapesArabic):
  • platform/graphics/mac/SimpleFontDataCoreText.cpp: (WebCore::SimpleFontData::getCFStringAttributes):
  • platform/graphics/win/GraphicsContextCGWin.cpp: (WebCore::GraphicsContext::drawLineForTextChecking):
  • platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp: (WebCore::disableComponentsOnce):
  • platform/graphics/win/QTMovie.cpp: (QTMovie::load):
  • platform/network/cf/SocketStreamHandleCFNet.cpp: (WebCore::SocketStreamHandle::createStreams):
  • platform/text/TextEncodingRegistry.cpp: (WebCore::pruneBlacklistedCodecs):
  • platform/text/transcoder/FontTranscoder.cpp: (WebCore::FontTranscoder::FontTranscoder):
05:11 Changeset [72497] by paroga@webkit.org

2010-11-21 Patrick Gansterer <paroga@webkit.org>

Reviewed by Darin Adler.

Add test for unicode plane 1 characters
https://bugs.webkit.org/show_bug.cgi?id=49581

  • fast/encoding/xml-utf-8-default-expected.txt:
  • fast/encoding/xml-utf-8-default.xml:

11/20/10:

23:20 Changeset [72496] by andreas.kling@nokia.com

2010-11-20 Andreas Kling <kling@webkit.org>

Rubber-stamped by Antonio Gomes.

[Qt] Fix spelling error (isEmtpyValue -> isEmptyValue)

  • platform/graphics/qt/FontPlatformDataQt.cpp: (WebCore::isEmptyValue): (WebCore::FontPlatformData::FontPlatformData):
22:44 Changeset [72495] by andreas.kling@nokia.com

2010-11-20 Andreas Kling <kling@webkit.org>

Reviewed by Antonio Gomes.

[Qt] Limit the size of image preview "cursor" when dragging
https://bugs.webkit.org/show_bug.cgi?id=49872

Respect DragController::maxDragImageSize() (currently 400x400.)

  • platform/qt/DragImageQt.cpp: (WebCore::dragImageSize): (WebCore::scaleDragImage):
22:36 Changeset [72494] by andreas.kling@nokia.com

2010-11-20 Andreas Kling <kling@webkit.org>

Reviewed by Antonio Gomes.

[Qt] Dragging a selection should use a rendering of the selection as "cursor" for the drag
https://bugs.webkit.org/show_bug.cgi?id=49870

  • WebCoreSupport/DragClientQt.cpp: (WebCore::DragClientQt::startDrag): Pass the DragImage to QDrag::setPixmap()

2010-11-20 Andreas Kling <kling@webkit.org>

Reviewed by Antonio Gomes.

[Qt] Dragging a selection should use a rendering of the selection as "cursor" for the drag
https://bugs.webkit.org/show_bug.cgi?id=49870

Implement Frame::dragImageForSelection() and the necessary DragImage helpers for Qt.

  • page/qt/FrameQt.cpp: (WebCore::Frame::dragImageForSelection):
  • platform/qt/DragImageQt.cpp: (WebCore::deleteDragImage): (WebCore::createDragImageFromImage):
22:22 Changeset [72493] by xan@webkit.org

2010-11-20 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

Remove leftover code in unit test.

  • GNUmakefile.am: remove unneeded utils file in dependency list.
  • tests/testdomdocument.c: (main): do not change to the directory of a non existing resource list.
22:11 Changeset [72492] by xan@webkit.org

WebCore:

2010-11-20 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Memory managament for DOM GObject wrappers
https://bugs.webkit.org/show_bug.cgi?id=40302

Initial attempt to have a kind of poor man's garbage collection
for GObject DOM objects. We tie the object's lifecycle to their
parent Frame and/or its document; that is, all objects will be
collected when their parent frame is destroyed or when that frame
transitions to a new document. Manual management (calling
g_object_unref on them) is also allowed, and is required for
objects that are not in the DOM tree (eg NodeLists).

  • GNUmakefile.am:
  • bindings/gobject/DOMObjectCache.cpp: Added.
  • bindings/gobject/DOMObjectCache.h: Copied from WebCore/bindings/gobject/WebKitDOMBinding.h.
  • bindings/gobject/WebKitDOMBinding.cpp: Remove the old cache code.
  • bindings/gobject/WebKitDOMBinding.h: ditto.
  • bindings/scripts/CodeGeneratorGObject.pm: include the new DOMObjectCache header.

WebKit/gtk:

2010-11-20 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Memory managament for DOM GObject wrappers
https://bugs.webkit.org/show_bug.cgi?id=40302

Initial attempt to have a kind of poor man's garbage collection
for GObject DOM objects. We tie the object's lifecycle to their
parent Frame and/or its document; that is, all objects will be
collected when their parent frame is destroyed or when that frame
transitions to a new document. Manual management (calling
g_object_unref on them) is also allowed, and is required for
objects that are not in the DOM tree (eg NodeLists).

  • GNUmakefile.am: add testutils file to testdomdocument.c
  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::setMainFrameDocumentReady): collect DOM objects on document transition.
  • tests/testdomdocument.c: (dom_document_fixture_teardown): only destroy the view if it's not already destroyed, since the new test detroys it on its own. (test_dom_document_get_elements_by_tag_name): manually unref node list. (test_dom_document_get_elements_by_class_name): ditto. (test_dom_document_get_links): ditto. (test_dom_document_garbage_collection): test all possible scenarios for DOM object "garbage collection". (main): add new test.
  • tests/testdomnode.c: (test_dom_node_hierarchy_navigation): manually unref node list. (test_dom_node_insertion): ditto.
  • webkit/webkithittestresult.cpp: (webkit_hit_test_result_dispose): unref the inner node on dispose now that the memory management model is clarified. (webkit_hit_test_result_class_init): hook dispose.
  • webkit/webkitwebframe.cpp: (webkit_web_frame_core_frame_gone): clear DOM objects attached to this frame. (webkit_web_frame_finalize): ditto.
22:03 Changeset [72491] by commit-queue@webkit.org

2010-11-20 Sam Magnuson <smagnuso@gmail.com>

Reviewed by Andreas Kling.

[Qt] crash when attempting to add a JS object
https://bugs.webkit.org/show_bug.cgi?id=49287

  • Api/qwebframe.cpp: (QWebFrame::addToJavaScriptWindowObject):

Test: LayoutTests/fast/frames/sandboxed-iframe-plugins.html

20:19 Changeset [72490] by commit-queue@webkit.org

2010-11-20 Helder Correia <helder@sencha.com>

Reviewed by Andreas Kling.

[Qt] Path stroke lacks blur shadow support
https://bugs.webkit.org/show_bug.cgi?id=49490

Add new test for checking path stroke blur shadow.

  • fast/canvas/canvas-strokePath-shadow-expected.txt: Added.
  • fast/canvas/canvas-strokePath-shadow.html: Added.
  • fast/canvas/script-tests/canvas-strokePath-shadow.js: Added.

2010-11-20 Helder Correia <helder@sencha.com>

Reviewed by Andreas Kling.

[Qt] Path stroke lacks blur shadow support
https://bugs.webkit.org/show_bug.cgi?id=49490

Add blur shadow support to strokePath().

Test: fast/canvas/canvas-strokePath-shadow.html

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::strokePath):
18:48 Changeset [72489] by barraclough@apple.com

YARR JIT should fallback to YARR Interpreter instead of PCRE.
https://bugs.webkit.org/show_bug.cgi?id=46719

Patch by Peter Varga <pvarga@inf.u-szeged.hu> on 2010-11-19
Reviewed by Gavin Barraclough.

Remove the ENABLE_YARR macro and the option of matching regular
expressions with PCRE from JavaScriptCore.

JavaScriptCore:

  • runtime/JSGlobalData.h:
  • runtime/RegExp.cpp:

(JSC::RegExp::compile):
(JSC::RegExp::match):

  • tests/mozilla/expected.html:
  • wtf/Platform.h:
  • yarr/RegexCompiler.cpp:
  • yarr/RegexCompiler.h:
  • yarr/RegexInterpreter.cpp:

(JSC::Yarr::byteCompileRegex):

  • yarr/RegexInterpreter.h:
  • yarr/RegexJIT.cpp:

(JSC::Yarr::jitCompileRegex):

  • yarr/RegexJIT.h:

(JSC::Yarr::RegexCodeBlock::RegexCodeBlock):
(JSC::Yarr::RegexCodeBlock::~RegexCodeBlock):
(JSC::Yarr::RegexCodeBlock::getFallback):
(JSC::Yarr::RegexCodeBlock::isFallback):
(JSC::Yarr::RegexCodeBlock::setFallback):
(JSC::Yarr::executeRegex):

  • yarr/RegexParser.h:
  • yarr/RegexPattern.h:

LayoutTests:

  • fast/js/regexp-look-ahead-empty-expected.txt:
  • fast/js/regexp-overflow-expected.txt:
  • fast/js/script-tests/regexp-overflow.js:
  • fast/js/sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.2/15.10.2.5_Term/S15.10.2.5_A1_T4-expected.txt:
  • fast/js/sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.2/15.10.2.8_Atom/S15.10.2.8_A2_T1-expected.txt:
  • fast/js/sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.6/15.10.6.2_RegExp.prototype.exec/S15.10.6.2_A1_T6-expected.txt:
17:05 Changeset [72488] by rniwa@webkit.org

2010-11-20 Ryosuke Niwa <rniwa@webkit.org>

Another unreviewed rebaseline for r72482.

  • editing/selection/extend-selection-home-end-expected.txt:
  • platform/chromium-win/editing/selection/extend-selection-home-end-expected.txt: Added.
16:27 Changeset [72487] by commit-queue@webkit.org

2010-11-20 Kwang Yul Seo <skyul@company100.net>

Reviewed by David Kilzer.

[BREWMP] Replace HTONL, HTONS, NTOHL and NTOHS with byte order conversion functions from AEEstd.h
https://bugs.webkit.org/show_bug.cgi?id=49518

HTONL, HTONS, NTOHL and NTOHS macros are prohibited in Mod1. Use byte order conversion functions provided by AEEstd.h.

  • platform/graphics/WOFFFileFormat.cpp:
16:16 Changeset [72486] by rniwa@webkit.org

2010-11-20 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed rebaselines for r72482.

Since Home/End behavior is different on Mac and GTK, move the expected result added by r72482
to platform/mac and platform/gtk, and add new expected result for other platforms.

See also: http://trac.webkit.org/changeset/54980 and https://webkit.org/b/35066.

  • editing/selection/extend-selection-home-end-expected.txt:
  • platform/chromium-win/editing/selection/extend-selection-expected.txt: Removed.
  • platform/chromium/test_expectations.txt: Removed extend-selection.html.
  • platform/gtk/Skipped: Ditto.
  • platform/gtk/editing/selection/extend-selection-expected.txt: Removed.
  • platform/gtk/editing/selection/extend-selection-home-end-expected.txt: Added.
  • platform/mac/editing/selection/extend-selection-home-end-expected.txt: Added.
  • platform/qt/Skipped: Removed extend-selection.html.
  • platform/win/editing/selection/extend-selection-expected.txt: Removed.
15:34 Changeset [72485] by commit-queue@webkit.org

2010-11-20 Kwang Yul Seo <skyul@company100.net>

Reviewed by David Kilzer.

[BREWMP] Use std_wstrlen instead of WSTRLEN
https://bugs.webkit.org/show_bug.cgi?id=49516

WSTRLEN is prohibited in Mod1. Use std_wstrlen from AEEstd.h instead.

  • platform/text/brew/StringBrew.cpp: (WTF::String::String):
15:32 Changeset [72484] by commit-queue@webkit.org

2010-11-20 Kwang Yul Seo <skyul@company100.net>

Reviewed by David Kilzer.

[BREWMP] Replace DBGPRINTF and DBGPRINTF_FATAL with dbg_Message
https://bugs.webkit.org/show_bug.cgi?id=49520

DBGPRINTF and DBGPRINTF_FATAL macros are prohibited in Mod1. Use dbg_Message instead.

  • wtf/Assertions.cpp:
  • wtf/Assertions.h:
15:18 Changeset [72483] by paroga@webkit.org

2010-11-20 Patrick Gansterer <paroga@webkit.org>

Reviewed by David Kilzer.

[WINCE] Implement textBreakLast and textBreakPrevious
https://bugs.webkit.org/show_bug.cgi?id=49552

This allows us to use TextBoundaries.cpp and remove TextBoundariesWinCE.cpp.
Also unify the different TextBreakIterator::first() implementations.

  • platform/text/wince/TextBoundariesWinCE.cpp: Removed.
  • platform/text/wince/TextBreakIteratorWinCE.cpp: (WebCore::TextBreakIterator::first): (WebCore::TextBreakIterator::last): (WebCore::textBreakLast): (WebCore::textBreakPrevious):
14:51 Changeset [72482] by rniwa@webkit.org

2010-11-19 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Antonio Gomes.

/editing/selection/extend-selection.html should be split into smaller tests
https://bugs.webkit.org/show_bug.cgi?id=49849

Divided the test into 4 pieces.

  • editing/selection/extend-selection-character-expected.txt: Added.
  • editing/selection/extend-selection-character.html: Added.
  • editing/selection/extend-selection-enclosing-block-expected.txt: Added.
  • editing/selection/extend-selection-enclosing-block.html: Added.
  • editing/selection/extend-selection-expected.txt: Removed.
  • editing/selection/extend-selection-home-end-expected.txt: Added.
  • editing/selection/extend-selection-home-end.html: Added.
  • editing/selection/extend-selection-word-expected.txt: Added.
  • editing/selection/extend-selection-word.html: Added.
  • editing/selection/extend-selection.html: Removed.
  • editing/selection/resources/extend-selection.css: Added. (div.test): (div.test:before): (div.test span): (div.test img): (div.test img + img): (div.test div):
  • editing/selection/resources/extend-selection.js: Added. (log): (positionsExtendingInDirectionForEnclosingBlock): (positionsExtendingInDirection): (fold): (logPositions): (checkReverseOrder): (checkSameOrder): (extendingSelection): (testExtendingSelection): (createTestNodes.window.onload): (createTestNodes):
14:02 Changeset [72481] by loki@webkit.org

2010-11-20 Gabor Loki <loki@webkit.org>

Reviewed by Gavin Barraclough.

Support JIT_OPTIMIZE_MOD on Thumb-2
https://bugs.webkit.org/show_bug.cgi?id=49432

Rewrite the soft modulo operation into macroassembler form, and move it
to JSValue32_64 section.
Add support for soft modulo on Thumb-2 JIT also.

  • assembler/ARMv7Assembler.h: (JSC::ARMv7Assembler::clz):
  • assembler/MacroAssemblerARM.h: (JSC::MacroAssemblerARM::countLeadingZeros32): (JSC::MacroAssemblerARM::relativeTableJump):
  • assembler/MacroAssemblerARMv7.h: (JSC::MacroAssemblerARMv7::countLeadingZeros32): (JSC::MacroAssemblerARMv7::relativeTableJump):
  • jit/JITArithmetic.cpp: (JSC::JIT::emit_op_mod):
  • jit/JITOpcodes.cpp: (JSC::JIT::privateCompileCTIMachineTrampolines):
  • jit/JITOpcodes32_64.cpp: (JSC::JIT::softModulo):
  • jit/JITStubs.cpp: (JSC::JITThunks::JITThunks):
  • wtf/Platform.h:
13:25 Changeset [72480] by jparent@chromium.org

Unreviewed. Adding failing expectation for Win + Linux for new
fast/canvas/canvas-fillPath-shadow test.

  • platform/chromium/test_expectations.txt:
12:54 Changeset [72479] by andreas.kling@nokia.com

2010-11-20 Andreas Kling <kling@webkit.org>

Reviewed by David Kilzer.

Path: Remove unused method swap()
https://bugs.webkit.org/show_bug.cgi?id=49853

  • platform/graphics/Path.h:
12:12 Changeset [72478] by ddkilzer@apple.com

<http://webkit.org/b/49867> MediaPlayerPrivateQTKit::setPreservesPitch(bool) leaks an NSDictionary

Reviewed by Dan Bernstein.

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm:

(WebCore::MediaPlayerPrivateQTKit::setPreservesPitch): Use
RetainPtr<NSDictionary> for movieAttributes.

10:54 Changeset [72477] by ddkilzer@apple.com

<http://webkit.org/b/49848> Make it possible to display the last character of a secure text field unobscured

Reviewed by Darin Adler.

(WTF::StringImpl::secure): Added argument that controls whether
the last character is obscured or not. Implemented behavior.

  • wtf/text/StringImpl.h:

(WTF::StringImpl::LastCharacterBehavior): Added enum.
(WTF::StringImpl::secure): Updated method signature.

09:40 Changeset [72476] by paroga@webkit.org

2010-11-20 Patrick Gansterer <paroga@webkit.org>

Reviewed by Andreas Kling.

Use String::fromUTF8 instead of UTF8Encoding().decode
in the libxml XMLDocumentParser
https://bugs.webkit.org/show_bug.cgi?id=45488

  • dom/XMLDocumentParser.cpp: (WebCore::toString):
09:33 Changeset [72475] by commit-queue@webkit.org

2010-11-20 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r72471.
http://trac.webkit.org/changeset/72471
https://bugs.webkit.org/show_bug.cgi?id=49865

broke two IME tests on Qt (Requested by kling on #webkit).

  • Api/qwebpage.cpp: (QWebPagePrivate::inputMethodEvent):
  • tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::inputMethods):
06:21 Changeset [72474] by reni@webkit.org

FilterPrimitives should have a pointer to its Filter object.
https://bugs.webkit.org/show_bug.cgi?id=49863

Reviewed by Dirk Schulze.

FilterPrimitives should have a renderer, and they need a member pointer to their Filter objects for Layout() calls.
This patch adds this member to FilterEffect.

No new test is needed because these modifications are covered by all of SVG Filter tests.

  • platform/graphics/filters/FEBlend.cpp:

(WebCore::FEBlend::FEBlend):
(WebCore::FEBlend::create):
(WebCore::FEBlend::apply):

  • platform/graphics/filters/FEBlend.h:
  • platform/graphics/filters/FEColorMatrix.cpp:

(WebCore::FEColorMatrix::FEColorMatrix):
(WebCore::FEColorMatrix::create):
(WebCore::FEColorMatrix::apply):

  • platform/graphics/filters/FEColorMatrix.h:
  • platform/graphics/filters/FEComponentTransfer.cpp:

(WebCore::FEComponentTransfer::FEComponentTransfer):
(WebCore::FEComponentTransfer::create):
(WebCore::FEComponentTransfer::apply):

  • platform/graphics/filters/FEComponentTransfer.h:
  • platform/graphics/filters/FEComposite.cpp:

(WebCore::FEComposite::FEComposite):
(WebCore::FEComposite::create):
(WebCore::FEComposite::determineAbsolutePaintRect):
(WebCore::FEComposite::apply):

  • platform/graphics/filters/FEComposite.h:
  • platform/graphics/filters/FEConvolveMatrix.cpp:

(WebCore::FEConvolveMatrix::FEConvolveMatrix):
(WebCore::FEConvolveMatrix::create):
(WebCore::FEConvolveMatrix::apply):

  • platform/graphics/filters/FEConvolveMatrix.h:

(WebCore::FEConvolveMatrix::determineAbsolutePaintRect):

  • platform/graphics/filters/FEDiffuseLighting.cpp:

(WebCore::FEDiffuseLighting::FEDiffuseLighting):
(WebCore::FEDiffuseLighting::create):

  • platform/graphics/filters/FEDiffuseLighting.h:
  • platform/graphics/filters/FEDisplacementMap.cpp:

(WebCore::FEDisplacementMap::FEDisplacementMap):
(WebCore::FEDisplacementMap::create):
(WebCore::FEDisplacementMap::apply):

  • platform/graphics/filters/FEDisplacementMap.h:

(WebCore::FEDisplacementMap::determineAbsolutePaintRect):

  • platform/graphics/filters/FEFlood.cpp:

(WebCore::FEFlood::FEFlood):
(WebCore::FEFlood::create):
(WebCore::FEFlood::apply):

  • platform/graphics/filters/FEFlood.h:

(WebCore::FEFlood::determineAbsolutePaintRect):

  • platform/graphics/filters/FEGaussianBlur.cpp:

(WebCore::FEGaussianBlur::FEGaussianBlur):
(WebCore::FEGaussianBlur::create):
(WebCore::FEGaussianBlur::determineAbsolutePaintRect):
(WebCore::FEGaussianBlur::apply):

  • platform/graphics/filters/FEGaussianBlur.h:
  • platform/graphics/filters/FELighting.cpp:

(WebCore::FELighting::FELighting):
(WebCore::FELighting::apply):

  • platform/graphics/filters/FELighting.h:

(WebCore::FELighting::determineAbsolutePaintRect):

  • platform/graphics/filters/FEMerge.cpp:

(WebCore::FEMerge::FEMerge):
(WebCore::FEMerge::create):
(WebCore::FEMerge::apply):

  • platform/graphics/filters/FEMerge.h:
  • platform/graphics/filters/FEMorphology.cpp:

(WebCore::FEMorphology::FEMorphology):
(WebCore::FEMorphology::create):
(WebCore::FEMorphology::determineAbsolutePaintRect):
(WebCore::FEMorphology::apply):

  • platform/graphics/filters/FEMorphology.h:
  • platform/graphics/filters/FEOffset.cpp:

(WebCore::FEOffset::FEOffset):
(WebCore::FEOffset::create):
(WebCore::FEOffset::determineAbsolutePaintRect):
(WebCore::FEOffset::apply):

  • platform/graphics/filters/FEOffset.h:
  • platform/graphics/filters/FESpecularLighting.cpp:

(WebCore::FESpecularLighting::FESpecularLighting):
(WebCore::FESpecularLighting::create):

  • platform/graphics/filters/FESpecularLighting.h:
  • platform/graphics/filters/FETile.cpp:

(WebCore::FETile::FETile):
(WebCore::FETile::create):
(WebCore::FETile::apply):

  • platform/graphics/filters/FETile.h:

(WebCore::FETile::determineAbsolutePaintRect):

  • platform/graphics/filters/FETurbulence.cpp:

(WebCore::FETurbulence::FETurbulence):
(WebCore::FETurbulence::create):
(WebCore::FETurbulence::apply):

  • platform/graphics/filters/FETurbulence.h:

(WebCore::FETurbulence::determineAbsolutePaintRect):

  • platform/graphics/filters/FilterEffect.cpp:

(WebCore::FilterEffect::FilterEffect):
(WebCore::FilterEffect::determineAbsolutePaintRect):
(WebCore::FilterEffect::effectContext):

  • platform/graphics/filters/FilterEffect.h:

(WebCore::FilterEffect::filter):

  • platform/graphics/filters/SourceAlpha.cpp:

(WebCore::SourceAlpha::create):
(WebCore::SourceAlpha::determineAbsolutePaintRect):
(WebCore::SourceAlpha::apply):

  • platform/graphics/filters/SourceAlpha.h:

(WebCore::SourceAlpha::SourceAlpha):

  • platform/graphics/filters/SourceGraphic.cpp:

(WebCore::SourceGraphic::create):
(WebCore::SourceGraphic::determineAbsolutePaintRect):
(WebCore::SourceGraphic::apply):

  • platform/graphics/filters/SourceGraphic.h:

(WebCore::SourceGraphic::SourceGraphic):

  • rendering/RenderSVGResourceFilter.cpp:

(WebCore::RenderSVGResourceFilter::buildPrimitives):
(WebCore::RenderSVGResourceFilter::applyResource):
(WebCore::RenderSVGResourceFilter::postApplyResource):

  • rendering/RenderSVGResourceFilter.h:
  • rendering/SVGRenderTreeAsText.cpp:

(WebCore::writeSVGResourceContainer):

  • svg/SVGFEBlendElement.cpp:

(WebCore::SVGFEBlendElement::build):

  • svg/SVGFEBlendElement.h:
  • svg/SVGFEColorMatrixElement.cpp:

(WebCore::SVGFEColorMatrixElement::build):

  • svg/SVGFEColorMatrixElement.h:
  • svg/SVGFEComponentTransferElement.cpp:

(WebCore::SVGFEComponentTransferElement::build):

  • svg/SVGFEComponentTransferElement.h:
  • svg/SVGFECompositeElement.cpp:

(WebCore::SVGFECompositeElement::build):

  • svg/SVGFECompositeElement.h:
  • svg/SVGFEConvolveMatrixElement.cpp:

(WebCore::SVGFEConvolveMatrixElement::build):

  • svg/SVGFEConvolveMatrixElement.h:
  • svg/SVGFEDiffuseLightingElement.cpp:

(WebCore::SVGFEDiffuseLightingElement::build):

  • svg/SVGFEDiffuseLightingElement.h:
  • svg/SVGFEDisplacementMapElement.cpp:

(WebCore::SVGFEDisplacementMapElement::build):

  • svg/SVGFEDisplacementMapElement.h:
  • svg/SVGFEFloodElement.cpp:

(WebCore::SVGFEFloodElement::build):

  • svg/SVGFEFloodElement.h:
  • svg/SVGFEGaussianBlurElement.cpp:

(WebCore::SVGFEGaussianBlurElement::build):

  • svg/SVGFEGaussianBlurElement.h:
  • svg/SVGFEImageElement.cpp:

(WebCore::SVGFEImageElement::build):

  • svg/SVGFEImageElement.h:
  • svg/SVGFEMergeElement.cpp:

(WebCore::SVGFEMergeElement::build):

  • svg/SVGFEMergeElement.h:
  • svg/SVGFEMorphologyElement.cpp:

(WebCore::SVGFEMorphologyElement::build):

  • svg/SVGFEMorphologyElement.h:
  • svg/SVGFEOffsetElement.cpp:

(WebCore::SVGFEOffsetElement::build):

  • svg/SVGFEOffsetElement.h:
  • svg/SVGFESpecularLightingElement.cpp:

(WebCore::SVGFESpecularLightingElement::build):

  • svg/SVGFESpecularLightingElement.h:
  • svg/SVGFETileElement.cpp:

(WebCore::SVGFETileElement::build):

  • svg/SVGFETileElement.h:
  • svg/SVGFETurbulenceElement.cpp:

(WebCore::SVGFETurbulenceElement::build):

  • svg/SVGFETurbulenceElement.h:
  • svg/SVGFilterPrimitiveStandardAttributes.h:
  • svg/graphics/filters/SVGFEImage.cpp:

(WebCore::FEImage::FEImage):
(WebCore::FEImage::create):
(WebCore::FEImage::determineAbsolutePaintRect):
(WebCore::FEImage::apply):

  • svg/graphics/filters/SVGFEImage.h:
  • svg/graphics/filters/SVGFilterBuilder.cpp:

(WebCore::SVGFilterBuilder::SVGFilterBuilder):

  • svg/graphics/filters/SVGFilterBuilder.h:

(WebCore::SVGFilterBuilder::create):

02:25 Changeset [72473] by commit-queue@webkit.org

2010-11-20 Helder Correia <helder@sencha.com>

Reviewed by Andreas Kling.

[Qt] GraphicsContext::strokeArc() is not necessary any more
https://bugs.webkit.org/show_bug.cgi?id=49859

Remove strokeArc() from the Qt port.

No test is needed.

  • platform/graphics/qt/GraphicsContextQt.cpp:
02:09 Changeset [72472] by commit-queue@webkit.org

2010-11-20 Helder Correia <helder@sencha.com>

Reviewed by Andreas Kling.

[Qt] Path fill lacks blur shadow support
https://bugs.webkit.org/show_bug.cgi?id=49491

Add new test for checking path fill blur shadow.

  • fast/canvas/canvas-fillPath-shadow-expected.txt: Added.
  • fast/canvas/canvas-fillPath-shadow.html: Added.
  • fast/canvas/script-tests/canvas-fillPath-shadow.js: Added.

2010-11-20 Helder Correia <helder@sencha.com>

Reviewed by Andreas Kling.

[Qt] Path fill lacks blur shadow support
https://bugs.webkit.org/show_bug.cgi?id=49491

Add blur shadow support to fillPath().

Test: fast/canvas/canvas-fillPath-shadow.html

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::fillPath):
00:15 Changeset [72471] by andreas.kling@nokia.com

2010-11-19 Kristian Amlie <kristian.amlie@nokia.com>

Reviewed by Andreas Kling.

Fixed handling of QInputMethodEvents with nonzero replacementLength.

These types of events replace text that is already in the widget, but
WebKit did not check for replacementLength at all.

Also made sure that the preeditString is always respected, even if
there is committed text. This is how QLineEdit does it.

https://bugs.webkit.org/show_bug.cgi?id=49787

  • Api/qwebpage.cpp: (QWebPagePrivate::inputMethodEvent):
  • tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::inputMethods):

11/19/10:

23:56 Changeset [72470] by commit-queue@webkit.org

2010-11-19 W. James MacLean <wjmaclean@chromium.org>

Reviewed by James Robinson.

Scaled Resized images are blurred when sent to Skia
https://bugs.webkit.org/show_bug.cgi?id=42370

  • platform/chromium-linux/svg/custom/image-rescale-expected.checksum: Added.
  • platform/chromium-linux/svg/custom/image-rescale-expected.png: Added.
  • platform/chromium-linux/svg/custom/image-rescale-expected.txt: Added.
  • platform/chromium-linux/svg/custom/image-rescale-scroll-expected.checksum: Added.
  • platform/chromium-linux/svg/custom/image-rescale-scroll-expected.png: Added.
  • platform/chromium-linux/svg/custom/image-rescale-scroll-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
  • platform/mac/svg/custom/image-rescale-expected.checksum: Added.
  • platform/mac/svg/custom/image-rescale-expected.png: Added.
  • platform/mac/svg/custom/image-rescale-expected.txt: Added.
  • platform/mac/svg/custom/image-rescale-scroll-expected.checksum: Added.
  • platform/mac/svg/custom/image-rescale-scroll-expected.png: Added.
  • platform/mac/svg/custom/image-rescale-scroll-expected.txt: Added.
  • platform/mac/test_expectations.txt:
  • svg/custom/image-rescale-scroll.html: Added.
  • svg/custom/image-rescale.svg: Added.
  • svg/custom/resources/image-rescale.jpg: Added.

2010-11-19 W. James MacLean <wjmaclean@chromium.org>

Reviewed by James Robinson.

Scaled Resized images are blurred when sent to Skia
https://bugs.webkit.org/show_bug.cgi?id=42370

This patch modifies ImageSkia.cpp to fix the calculation of resampled
bitmap sizes so as to include the transform matrix of the canvas.
Includes a new test to catch a regression that occured the first time
this patch was applied.

Tests: svg/custom/image-rescale-scroll.html

svg/custom/image-rescale.svg

  • platform/graphics/skia/ImageSkia.cpp: (WebCore::computeResamplingMode): (WebCore::drawResampledBitmap):
23:25 Changeset [72469] by commit-queue@webkit.org

2010-11-19 Jia Pu <jpu@apple.com>

Reviewed by Dan Bernstein.

Regression: contraction is considered misspelling.
https://bugs.webkit.org/show_bug.cgi?id=49423
<rdar://problem/8654206>

  • platform/mac-leopard/Skipped:
  • platform/mac-snowleopard/Skipped:
  • platform/mac-tiger/Skipped:
  • platform/mac-wk2/Skipped:
  • platform/mac/editing/spelling/autocorrection-contraction-expected.checksum: Added.
  • platform/mac/editing/spelling/autocorrection-contraction-expected.png: Added.
  • platform/mac/editing/spelling/autocorrection-contraction-expected.txt: Added.
  • platform/mac/editing/spelling/autocorrection-contraction.html: Added.

2010-11-19 Jia Pu <jpu@apple.com>

Reviewed by Dan Bernstein.

Regression: contraction is considered misspelling.
https://bugs.webkit.org/show_bug.cgi?id=49423
<rdar://problem/8654206>

Test: platform/mac/editing/spelling/autocorrection-contraction.html

manual-tests/autocorrection/autocorrection-contraction.html

  • editing/Editor.cpp: (WebCore::isAmbiguousBoundaryCharacter): Moved function to the top of the file so that it can be used by all other functions in the file. (WebCore::Editor::markMisspellingsAfterTypingToWord): Renamed markMisspellingsAfterTypingToPosition() to improve readability, and to pass in additional argument. Before we apply pending autocorrection, we check to see if currently typed character makes current word a partial contraction, for instance "wouldn'". If that's the case, we would not apply the pending correction. (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): Make sure currently typed word is not a partial contraction, such as "wouldn'", before mark it as misspelled. Also update the location of ambiguous boundary if other replacements have changed the length of the paragraph.
  • editing/Editor.h:
  • editing/TypingCommand.cpp: (WebCore::TypingCommand::markMisspellingsAfterTyping): Adopt renamed function.
  • manual-tests/autocorrection/autocorrection-contraction.html: Added.
22:27 Changeset [72468] by commit-queue@webkit.org

2010-11-19 Zalan Bujtas <zbujtas@gmail.com>

Reviewed by Andreas Kling.

WebUIClient::createNewPage() expects a retained WKPageRef.
https://bugs.webkit.org/show_bug.cgi?id=48549

  • UIProcess/API/qt/ClientImpl.cpp: (qt_wk_createNewPage):
21:48 Changeset [72467] by benjamin.poulain@nokia.com

2010-11-19 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Transition and animation do not work with QWebView anymore
https://bugs.webkit.org/show_bug.cgi?id=49797

Accelerated compositing should not be enabled on QWebView without
texture mapper.

  • WebCoreSupport/PageClientQt.h: (WebCore::PageClientQWidget::allowsAcceleratedCompositing):
21:20 Changeset [72466] by commit-queue@webkit.org

2010-11-19 Yi Shen <yi.4.shen@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Memory leak in QWebInspector
https://bugs.webkit.org/show_bug.cgi?id=49765

Delete QWebInspectorPrivate in ~QWebInspector()

  • Api/qwebinspector.cpp: (QWebInspector::~QWebInspector):
20:51 Changeset [72465] by andreas.kling@nokia.com

2010-11-19 Andreas Kling <kling@webkit.org>

Reviewed by Antonio Gomes.

ScrollView: Make delegatesScrolling() and avoidScrollbarCreation() const.
https://bugs.webkit.org/show_bug.cgi?id=49854

  • page/FrameView.cpp: (WebCore::FrameView::delegatesScrolling): (WebCore::FrameView::avoidScrollbarCreation):
  • page/FrameView.h:
  • platform/ScrollView.h: (WebCore::ScrollView::delegatesScrolling): (WebCore::ScrollView::avoidScrollbarCreation):
20:40 Changeset [72464] by commit-queue@webkit.org

2010-11-19 William Chan <willchan@chromium.org>

Reviewed by David Levin.

Add USE(CHROMIUM_NET)

Indicates the use of Chromium's network stack. Chromium's network
stack performs better when it has full view of all resource requests,
so USE(CHROMIUM_NET) can be used to bypass throttles.

https://bugs.webkit.org/show_bug.cgi?id=49778

  • wtf/Platform.h:
19:24 Changeset [72463] by sfalken@apple.com

Touch file to force build.

19:09 Changeset [72462] by podivilov@chromium.org

2010-11-19 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: scripts panel should be shown before execution line is scrolled into view.
https://bugs.webkit.org/show_bug.cgi?id=49792

  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.debuggerPaused):
18:20 Changeset [72461] by andersca@apple.com

Add a didFail WKContextDownloadClient callback
https://bugs.webkit.org/show_bug.cgi?id=49847

Reviewed by Sam Weinig.

  • UIProcess/API/C/WKContext.h:

Add didFail callback.

  • UIProcess/Downloads/DownloadProxy.cpp:

(WebKit::DownloadProxy::didFail):
Call WebDownloadClient::didFail.

  • UIProcess/WebDownloadClient.cpp:

(WebKit::WebDownloadClient::didFail):
Call the didFail client function.

18:12 Changeset [72460] by mihaip@chromium.org

2010-11-19 Mihai Parparita <mihaip@chromium.org>

Reviewed by Tony Chang.

Rebaseline server: checksum-only differences and prefetching
https://bugs.webkit.org/show_bug.cgi?id=49841

Add support for image test results where the only difference is in the
checksum.

Add prefetching of the image results from the next test.

  • Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
  • Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
  • Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
17:52 Changeset [72459] by commit-queue@webkit.org

2010-11-19 James Simonsen <simonjam@chromium.org>

Reviewed by Tony Chang.

[chromium] Fix whitespace character handling in complex text on linux
https://bugs.webkit.org/show_bug.cgi?id=49771

  • platform/chromium-linux/fast/text/international/bidi-linebreak-001-expected.checksum: Remove null glyph from expected output.
  • platform/chromium-linux/fast/text/international/bidi-linebreak-001-expected.png: Ditto.
  • platform/chromium-linux/fast/text/international/bidi-linebreak-001-expected.txt: Ditto.
  • platform/chromium-linux/fast/text/international/bidi-linebreak-002-expected.checksum: Ditto.
  • platform/chromium-linux/fast/text/international/bidi-linebreak-002-expected.png: Ditto.
  • platform/chromium-linux/fast/text/international/bidi-linebreak-002-expected.txt: Ditto.
  • platform/chromium-linux/fast/text/international/bidi-linebreak-003-expected.checksum: Ditto.
  • platform/chromium-linux/fast/text/international/bidi-linebreak-003-expected.png: Ditto.
  • platform/chromium-linux/fast/text/international/bidi-linebreak-003-expected.txt: Ditto.
  • platform/chromium-linux/fast/text/wide-zero-width-space-expected.checksum: Added. Now passes on Linux.
  • platform/chromium-linux/fast/text/wide-zero-width-space-expected.png: Added.
  • platform/chromium-linux/fast/text/wide-zero-width-space-expected.txt: Added.
  • platform/chromium/test_expectations.txt: Removed LINUX from wide-zero-width-space.

2010-11-19 James Simonsen <simonjam@chromium.org>

Reviewed by Tony Chang.

[chromium] Fix whitespace character handling in complex text on linux
https://bugs.webkit.org/show_bug.cgi?id=49771

  • platform/graphics/SimpleFontData.h: (WebCore::SimpleFontData::isZeroWidthSpaceGlyph): Added. (WebCore::SimpleFontData::boundsForGlyph): Use isZeroWidthSpaceGlyph(). (WebCore::SimpleFontData::widthForGlyph): Use isZeroWidthSpaceGlyph().
  • platform/graphics/chromium/FontLinux.cpp: (WebCore::TextRunWalker::nextScriptRun): Cache currently used font data. (WebCore::TextRunWalker::setGlyphXPositions): Skip zero width spaces. (WebCore::TextRunWalker::normalizeSpacesAndMirrorChars): Normalize zero width spaces. (WebCore::TextRunWalker::getNormalizedTextRun):
17:49 Changeset [72458] by dpranke@chromium.org

2010-11-19 Dirk Pranke <dpranke@chromium.org>

Reviewed by Tony Chang.

nrwt multiprocessing - add 'worker number' concept, move stuff to worker thread

Add the 'worker number' and 'worker name' concepts to the
TestShellThread objects, and move test_types and test_args from
the TestRunner to the TestShellThread.

https://bugs.webkit.org/show_bug.cgi?id=49768

  • Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
17:48 Changeset [72457] by dpranke@chromium.org

2010-11-19 Dirk Pranke <dpranke@chromium.org>

Reviewed by Ojan Vafai.

Do some minor cleanup and bug fixing.

https://bugs.webkit.org/show_bug.cgi?id=49777

  • Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
17:43 Changeset [72456] by andersca@apple.com

Extend sandbox when downloading files
https://bugs.webkit.org/show_bug.cgi?id=49844

Reviewed by Sam Weinig.

  • Platform/CoreIPC/HandleMessage.h:

(CoreIPC::callMemberFunction):
Add new overload.

  • UIProcess/Downloads/DownloadProxy.cpp:

(WebKit::DownloadProxy::decideDestinationWithSuggestedFilename):
Create a sandbox extension handle if necessary.

  • UIProcess/Downloads/DownloadProxy.messages.in:

Add a sandbox extension handle out parameter to the DecideDestinationWithSuggestedFilename message.

  • WebProcess/Downloads/Download.cpp:

(WebKit::Download::decideDestinationWithSuggestedFilename):
Create and consume the returned sandbox extension handle.

(WebKit::Download::didFinish):
(WebKit::Download::didFail):
Invalidate the sandbox extension handles.

  • WebProcess/Downloads/mac/DownloadMac.mm:

(-[WKDownloadAsDelegate download:shouldDecodeSourceDataOfMIMEType:]):
Whoops, fix inverted logic.

17:39 Changeset [72455] by dpranke@chromium.org

2010-11-19 Dirk Pranke <dpranke@chromium.org>

Reviewed by Ojan Vafai.

nrwt - config.build_directory() is busted

Fixes a typo that was causing us to usually return the top level
directory WebKitBuild instead of WebKitBuild/{Debug,Release}. The
bug was hidden by test stubs that were too simplistic :(.

https://bugs.webkit.org/show_bug.cgi?id=49815

  • Scripts/webkitpy/common/system/executive_mock.py:
  • Scripts/webkitpy/layout_tests/port/config.py:
  • Scripts/webkitpy/layout_tests/port/config_unittest.py:
17:15 Changeset [72454] by sfalken@apple.com

2010-11-19 Steve Falkenburg <sfalken@apple.com>

Reviewed by Adam Roben.

Add Debug_Cairo_CFLite and Release_Cairo_CFLite configurations for all vcproj files
https://bugs.webkit.org/show_bug.cgi?id=49819

2010-11-19 Steve Falkenburg <sfalken@apple.com>

Reviewed by Adam Roben.

Add Debug_Cairo_CFLite and Release_Cairo_CFLite configurations for all vcproj files
https://bugs.webkit.org/show_bug.cgi?id=49819

  • WebKit.vcproj/Interfaces.vcproj:
  • WebKit.vcproj/WebKit.sln:
  • WebKit.vcproj/WebKit.vcproj:
  • WebKit.vcproj/WebKitGUID.vcproj:

2010-11-19 Steve Falkenburg <sfalken@apple.com>

Reviewed by Adam Roben.

Add Debug_Cairo_CFLite and Release_Cairo_CFLite configurations for all vcproj files
https://bugs.webkit.org/show_bug.cgi?id=49819

  • WebCore.vcproj/QTMovieWin.vcproj:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcproj/WebCoreGenerated.vcproj:

2010-11-19 Steve Falkenburg <sfalken@apple.com>

Reviewed by Adam Roben.

Add Debug_Cairo_CFLite and Release_Cairo_CFLite configurations for all vcproj files
https://bugs.webkit.org/show_bug.cgi?id=49819

  • DumpRenderTree/DumpRenderTree.sln:
  • DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
  • DumpRenderTree/win/DumpRenderTree.vcproj:
  • DumpRenderTree/win/ImageDiff.vcproj:
  • FindSafari/FindSafari.vcproj:
  • MiniBrowser/MiniBrowser.vcproj:
  • TestWebKitAPI/win/TestWebKitAPI.sln:
  • TestWebKitAPI/win/TestWebKitAPI.vcproj:
  • TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
  • WebKitAPITest/WebKitAPITest.vcproj:
  • WebKitLauncherWin/WebKitLauncherWin.vcproj:
  • WebKitTestRunner/win/InjectedBundle.vcproj:
  • WebKitTestRunner/win/InjectedBundleGenerated.vcproj:
  • WebKitTestRunner/win/WebKitTestRunner.vcproj:
  • WinLauncher/WinLauncher.vcproj:
  • record-memory-win/record-memory-win.vcproj:

2010-11-19 Steve Falkenburg <sfalken@apple.com>

Reviewed by Adam Roben.

Add Debug_Cairo_CFLite and Release_Cairo_CFLite configurations for all vcproj files
https://bugs.webkit.org/show_bug.cgi?id=49819

  • win/WebKit2.vcproj:
  • win/WebKit2Generated.vcproj:
  • win/WebKit2WebProcess.vcproj:
  • win/WebKit2WebProcessCommon.vsprops:
16:40 Changeset [72453] by aroben@apple.com

Add Lucas De Marchi's blog to Planet WebKit

Reviewed by Jon Honeycutt.

  • config.ini:
16:33 Changeset [72452] by aroben@apple.com

Add some more Windows slaves

This is probably more than we will be using in the immediate future,
but having some extra slave names makes experimenting with different
configurations easier.

Reviewed by Jon Honeycutt.

  • BuildSlaveSupport/build.webkit.org-config/config.json: Added 5 more

Windows slaves and distributed them among the three different Test
builders.

16:32 Changeset [72451] by beidson@apple.com

More of <rdar://problem/8613727> and https://bugs.webkit.org/show_bug.cgi?id=49836
Add WebKit2 API relevant to customization of context menus

Reviewed by Darin Adler.

  • WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:

(WKBundleFrameAllowsFollowingLink):

  • WebProcess/InjectedBundle/API/c/WKBundleFrame.h:
  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::allowsFollowingLink):

  • WebProcess/WebPage/WebFrame.h:
16:24 Changeset [72450] by mihaip@chromium.org

2010-11-19 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium/Mac rebaseline.

Rebaseline tests in fast/events that have different scrollbar rendering.

  • platform/chromium-mac/fast/events/autoscroll-expected.checksum: Added.
  • platform/chromium-mac/fast/events/autoscroll-expected.png: Added.
  • platform/chromium-mac/fast/events/pointer-events-2-expected.checksum: Added.
  • platform/chromium-mac/fast/events/pointer-events-2-expected.png: Added.
  • platform/chromium-mac/fast/events/reveal-link-when-focused-expected.checksum: Added.
  • platform/chromium-mac/fast/events/reveal-link-when-focused-expected.png: Added.
  • platform/chromium/test_expectations.txt:
16:21 Changeset [72449] by mihaip@chromium.org

2010-11-19 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium/Mac rebaseline.

Rebaseline tests in fast/frames that have different scrollbar rendering.

  • platform/chromium-mac/fast/frames/frame-scrolling-attribute-expected.checksum: Added.
  • platform/chromium-mac/fast/frames/frame-scrolling-attribute-expected.png: Added.
  • platform/chromium-mac/fast/frames/iframe-scrolling-attribute-expected.checksum: Added.
  • platform/chromium-mac/fast/frames/iframe-scrolling-attribute-expected.png: Added.
  • platform/chromium-mac/fast/frames/invalid-expected.checksum: Added.
  • platform/chromium-mac/fast/frames/invalid-expected.png: Added.
  • platform/chromium-mac/fast/frames/valid-expected.checksum: Added.
  • platform/chromium-mac/fast/frames/valid-expected.png: Added.
  • platform/chromium/test_expectations.txt:
16:13 Changeset [72448] by mihaip@chromium.org

2010-11-19 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium/Mac rebaseline of transforms/2d/zoom-menulist.html.

  • platform/chromium-mac/transforms/2d/zoom-menulist-expected.checksum: Added.
  • platform/chromium-mac/transforms/2d/zoom-menulist-expected.png: Added.
  • platform/chromium/test_expectations.txt:
16:05 Changeset [72447] by mihaip@chromium.org

2010-11-19 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium expectations update.

http/tests/loading/bad-server-subframe.html had chromium-win baselines
that made it fail consistently on Windows and Linux. It should pass with
the regular upstream baselines.

  • platform/chromium-win/http/tests/loading/bad-server-subframe-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
15:41 Changeset [72446] by beidson@apple.com

<rdar://problem/8613727> and https://bugs.webkit.org/show_bug.cgi?id=49836
Add WebKit2 API relevant to customization of context menus

Reviewed by Darin Adler.

WebCore:

  • WebCore.exp.in:

WebKit2:

Most of this is just exposing already-existing concepts in API.

  • Shared/API/c/WKURLRequest.cpp:

(WKURLRequestCreateWithWKURL):

  • Shared/API/c/WKURLRequest.h:
  • Shared/WebURLRequest.cpp:

(WebKit::WebURLRequest::create):

  • Shared/WebURLRequest.h:
  • WebProcess/InjectedBundle/API/c/WKBundleHitTestResult.cpp:

(WKBundleHitTestResultCopyAbsoluteImageURL):
(WKBundleHitTestResultCopyAbsoluteMediaURL):
(WKBundleHitTestResultGetImageRect):
(WKBundleHitTestResultGetIsSelected):

  • WebProcess/InjectedBundle/API/c/WKBundleHitTestResult.h:
  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageHasLocalDataForURL):
(WKBundlePageCanHandleRequest):

  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/InjectedBundle/InjectedBundleHitTestResult.cpp:

(WebKit::InjectedBundleHitTestResult::absoluteImageURL):
(WebKit::InjectedBundleHitTestResult::absoluteMediaURL):
(WebKit::InjectedBundleHitTestResult::imageRect):
(WebKit::InjectedBundleHitTestResult::isSelected):

  • WebProcess/InjectedBundle/InjectedBundleHitTestResult.h:
  • WebProcess/WebPage/WebContextMenu.cpp:

(WebKit::WebContextMenu::show):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::hasLocalDataForURL):
(WebKit::WebPage::canHandleRequest):

  • WebProcess/WebPage/qt/WebPageQt.cpp:

(WebKit::WebPage::hasLocalDataForURL): Stubbed for now.
(WebKit::WebPage::canHandleRequest): Ditto.

  • WebProcess/WebPage/win/WebPageWin.cpp:

(WebKit::WebPage::hasLocalDataForURL): Ditto.
(WebKit::WebPage::canHandleRequest): Ditto.

15:08 Changeset [72445] by kinuko@chromium.org

2010-11-19 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by Ojan Vafai.

[Chromium] REGRESSION: Record actual test results in the JSON result summary for non-layout tests
https://bugs.webkit.org/show_bug.cgi?id=49702

Re-landing r72357 with a test fix.

  • Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
14:59 Changeset [72444] by jparent@chromium.org

Not reviewed, adding TIMEOUT for inspector/styles-disable-then-delete.html.

  • platform/chromium/test_expectations.txt:
14:59 Changeset [72443] by msaboff@apple.com

2010-11-19 Michael Saboff <msaboff@apple.com>

Reviewed by Sam Weinig

Remove DOMSVGAnimatedPathData.h from all: target to fix build.

  • MigrateHeaders.make:

2010-11-19 Michael Saboff <msaboff@apple.com>

Reviewed by Sam Weinig

Remove DOMSVGAnimatedPathData.h from all: target to fix build.

  • MigrateHeaders.make:
14:40 Changeset [72442] by oliver@apple.com

2010-11-19 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

Don't check for constant registers when we can guarantee that the register won't be in the constant pool
https://bugs.webkit.org/show_bug.cgi?id=49814

Add uncheckedR(int) to CallFrame, and replace all the uses of r() with uncheckedR()
when we can guarantee that the register is not referring to a constant.
This makes the interpreter about 0.5% faster, and makes the CallFrame initialisation
logic correct when we're using a faked callframe (as in the case of the globalExec).

  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::createActivation):
  • debugger/DebuggerCallFrame.cpp: (JSC::DebuggerCallFrame::thisObject):
  • interpreter/CallFrame.h: (JSC::ExecState::uncheckedR):
  • interpreter/Interpreter.cpp: (JSC::Interpreter::resolve): (JSC::Interpreter::resolveSkip): (JSC::Interpreter::resolveGlobal): (JSC::Interpreter::resolveGlobalDynamic): (JSC::Interpreter::resolveBase): (JSC::Interpreter::resolveBaseAndProperty): (JSC::Interpreter::callEval): (JSC::Interpreter::unwindCallFrame): (JSC::Interpreter::throwException): (JSC::Interpreter::execute): (JSC::Interpreter::executeCall): (JSC::Interpreter::executeConstruct): (JSC::Interpreter::prepareForRepeatCall): (JSC::Interpreter::createExceptionScope): (JSC::Interpreter::privateExecute):
  • jit/JITStubs.cpp: (JSC::DEFINE_STUB_FUNCTION):
  • runtime/JSActivation.cpp: (JSC::JSActivation::argumentsGetter):
14:37 Changeset [72441] by commit-queue@webkit.org

2010-11-19 Avi Drissman <avi@google.com>

Reviewed by Antonio Gomes.

Complete support for Unix editing mode
https://bugs.webkit.org/show_bug.cgi?id=49757

  • page/Settings.cpp: (WebCore::Settings::Settings):
  • page/Settings.h:

2010-11-19 Avi Drissman <avi@google.com>

Reviewed by Antonio Gomes.

Complete support for Unix editing mode
https://bugs.webkit.org/show_bug.cgi?id=49757

  • DumpRenderTree/LayoutTestController.cpp: (setEditingBehaviorCallback):
  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::setEditingBehavior):
14:32 WebKit Team edited by rniwa@webkit.org
Added HTML DOM to my area (diff)
14:23 Changeset [72440] by darin@apple.com

2010-11-19 Darin Adler <darin@apple.com>

Reviewed by Sam Weinig.

Need a way to clear disk cache from WebContext
https://bugs.webkit.org/show_bug.cgi?id=49820

  • UIProcess/API/C/WKContext.cpp: (WKContextClearResourceCaches): Added. (WKContextClearApplicationCache): Added.
  • UIProcess/API/C/WKContext.h:
  • UIProcess/WebContext.cpp: (WebKit::WebContext::clearResourceCaches): Added. (WebKit::WebContext::clearApplicationCache): Added.
  • UIProcess/WebContext.h:
  • WebProcess/WebProcess.cpp: (WebKit::WebProcess::clearResourceCaches): Added. (WebKit::WebProcess::clearApplicationCache): Added.
  • WebProcess/WebProcess.h:
  • WebProcess/WebProcess.messages.in: Added messages.
  • WebProcess/mac/WebProcessMac.mm: (WebKit::WebProcess::platformClearResourceCaches): Added.
  • WebProcess/qt/WebProcessQt.cpp: (WebKit::WebProcess::platformClearResourceCaches): Added.
  • WebProcess/win/WebProcessWin.cpp: (WebKit::WebProcess::platformClearResourceCaches): Added.
14:22 Changeset [72439] by zmo@google.com

2010-11-19 Zhenyao Mo <zmo@google.com>

Unreviewed, update webgl test expectations.

  • platform/chromium-gpu/test_expectations.txt:
  • platform/chromium/test_expectations.txt:
  • platform/mac-snowleopard/Skipped:
14:15 Changeset [72438] by andersca@apple.com

Implement support for loading local files
https://bugs.webkit.org/show_bug.cgi?id=49828
<rdar://problem/8447121>

Reviewed by Sam Weinig.

  • UIProcess/WebPageProxy.cpp:

(WebKit::initializeSandboxExtensionHandle):
Given an URL, create a sandbox extension if it's a local file URL.

(WebKit::WebPageProxy::loadURL):
(WebKit::WebPageProxy::loadURLRequest):
Pass along sandbox extension handles to the LoadURL and LoadURLRequest messages.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
Call SandboxExtensionTracker::didStartProvisionalLoad.

(WebKit::WebFrameLoaderClient::dispatchDidCommitLoad):
Call SandboxExtensionTracker::didCommitProvisionalLoad.

(WebKit::WebFrameLoaderClient::dispatchDidFailProvisionalLoad):
Call SandboxExtensionTracker::didFailProvisionalLoad.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::~WebPage):
Invalidate the sandbox extension tracker.

(WebKit::WebPage::close):
Invalidate the sandbox extension tracker.

(WebKit::WebPage::loadURL):
(WebKit::WebPage::loadURLRequest):
Pass the sandbox extension handle to the sandbox extension tracker.

(WebKit::WebPage::SandboxExtensionTracker::~SandboxExtensionTracker):
Invalidate the sandbox extension tracker.

(WebKit::WebPage::SandboxExtensionTracker::invalidate):
invalidate ell the sandbox extensions.

(WebKit::WebPage::SandboxExtensionTracker::beginLoad):
Create a sandbox extension and store it as the "pending provisional extension".

(WebKit::WebPage::SandboxExtensionTracker::didStartProvisionalLoad):
Consume the pending provisional extension and make it the provisional extension.

(WebKit::WebPage::SandboxExtensionTracker::didCommitProvisionalLoad):
Invalidate the committed extension and make the provisional extension the committed extension.

(WebKit::WebPage::SandboxExtensionTracker::didFailProvisionalLoad):
Invalidate the provisional extension.

  • WebProcess/WebPage/WebPage.messages.in:

Add SandboxExtension::Handle parameters to LoadURL and LoadURLRequest.

14:14 Changeset [72437] by zmo@google.com

2010-11-19 Zhenyao Mo <zmo@google.com>

Unreviewed, update webgl test expectations.

  • platform/chromium-gpu/test_expectations.txt:
  • platform/chromium/test_expectations.txt:
14:13 Changeset [72436] by commit-queue@webkit.org

2010-11-19 Ilya Sherman <isherman@chromium.org>

Reviewed by Darin Fisher.

Expose default value of maxLength in Chromium API
https://bugs.webkit.org/show_bug.cgi?id=49723

  • public/WebInputElement.h: Added constant defaultMaximumLength
  • src/WebInputElement.cpp:
13:52 Changeset [72435] by japhet@chromium.org

2010-11-19 Nate Chapin <japhet@chromium.org>

Reviewed by Alexey Proskuryakov.

Test for https://bugs.webkit.org/show_bug.cgi?id=49693

  • fast/loader/subresource-willSendRequest-null-expected.txt: Added.
  • fast/loader/subresource-willSendRequest-null.html: Added.

2010-11-19 Nate Chapin <japhet@chromium.org>

Reviewed by Alexey Proskuryakov.

Remove requests from ResourceLoadScheduler's queue before
actually starting them. We're holding a RefPtr anyway, and
the load might be terminated and removed from the queue synchronously.
https://bugs.webkit.org/show_bug.cgi?id=49693

Test: fast/loader/subresource-willSendRequest-null.html

  • loader/ResourceLoadScheduler.cpp: (WebCore::ResourceLoadScheduler::servePendingRequests):
13:50 Changeset [72434] by andersca@apple.com

Make it possible to encode null SandboxExtension handles
https://bugs.webkit.org/show_bug.cgi?id=49825

Reviewed by Darin Adler.

  • Shared/mac/SandboxExtensionMac.mm:

(WebKit::SandboxExtension::Handle::encode):
If there's no underlying sandbox extension, just encode an empty byte array.

(WebKit::SandboxExtension::Handle::decode):
If the decoded byte array is empty, don't try to create a sandbox extension.

(WebKit::SandboxExtension::create):
If the handle is null, return null.

(WebKit::SandboxExtension::consume):
Consuming shuld not null out the underlying sandbox extension object.

13:48 Changeset [72433] by zmo@google.com

2010-11-18 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Make sure is* return false if the name is never bound
https://bugs.webkit.org/show_bug.cgi?id=49767

  • html/canvas/WebGLBuffer.h: Add function to check whether the buffer has been bound before. (WebCore::WebGLBuffer::hasEverBeenBound):
  • html/canvas/WebGLFramebuffer.cpp: Ditto. (WebCore::WebGLFramebuffer::WebGLFramebuffer):
  • html/canvas/WebGLFramebuffer.h: Ditto. (WebCore::WebGLFramebuffer::hasEverBeenBound): (WebCore::WebGLFramebuffer::setBound):
  • html/canvas/WebGLRenderbuffer.cpp: Ditto. (WebCore::WebGLRenderbuffer::WebGLRenderbuffer):
  • html/canvas/WebGLRenderbuffer.h: Ditto. (WebCore::WebGLRenderbuffer::hasEverBeenBound): (WebCore::WebGLRenderbuffer::setBound):
  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::bindFramebuffer): Set bound status to true. (WebCore::WebGLRenderingContext::bindRenderbuffer): Ditto. (WebCore::WebGLRenderingContext::isBuffer): Return false if it's never bound. (WebCore::WebGLRenderingContext::isFramebuffer): Ditto. (WebCore::WebGLRenderingContext::isRenderbuffer): Ditto. (WebCore::WebGLRenderingContext::isTexture): Ditto.
  • html/canvas/WebGLTexture.h: Add function to check whether the texture has been bound before. (WebCore::WebGLTexture::hasEverBeenBound):
13:15 Changeset [72432] by benjamin.poulain@nokia.com

2010-11-19 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] mask-box-image renders wrong in certain conditions
https://bugs.webkit.org/show_bug.cgi?id=43476

Qt does not follow the same convention as the other port
when rendering a pixmap with null width of height. When one
of those dimension is null, we should ignore the painting call
to behave like the other ports.

  • platform/graphics/qt/ImageQt.cpp: (WebCore::Image::drawPattern):
13:03 Changeset [72431] by zmo@google.com

2010-11-18 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

GraphicsContext3D::reshape is clearing using current clear color instead of transparent
https://bugs.webkit.org/show_bug.cgi?id=44064

  • src/WebGraphicsContext3DDefaultImpl.cpp: (WebKit::WebGraphicsContext3DDefaultImpl::reshape): Use 0 as clear values.

2010-11-18 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

GraphicsContext3D::reshape is clearing using current clear color instead of transparent
https://bugs.webkit.org/show_bug.cgi?id=44064

  • platform/graphics/gpu/DrawingBuffer.cpp: (WebCore::DrawingBuffer::reset): Use 0 as clear values.
  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp: (WebCore::GraphicsContext3D::reshape): Ditto.

2010-11-18 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

GraphicsContext3D::reshape is clearing using current clear color instead of transparent
https://bugs.webkit.org/show_bug.cgi?id=44064

  • fast/canvas/webgl/renderbuffer-initialization-expected.txt:
  • fast/canvas/webgl/renderbuffer-initialization.html: Test that o is used as the clear values instead of the current gl clear values.
12:59 Changeset [72430] by bweinstein@apple.com

Rebaseline fast/blockflow results for Windows after r72347.

  • platform/win/fast/blockflow/japanese-ruby-horizontal-bt-expected.txt:
  • platform/win/fast/blockflow/japanese-ruby-vertical-lr-expected.txt:
  • platform/win/fast/blockflow/japanese-ruby-vertical-rl-expected.txt:
12:48 Changeset [72429] by bweinstein@apple.com

Fix failing Windows ruby tests by removing the Windows-specific results. These were the same as the Mac
results before r72347, and that change rebaselined the results in LayoutTests/platform/mac, making these
not match anymore, and causing the Windows tests to fail.

  • platform/win/fast/ruby/ruby-empty-rt-expected.checksum: Removed.
  • platform/win/fast/ruby/ruby-empty-rt-expected.png: Removed.
  • platform/win/fast/ruby/ruby-empty-rt-expected.txt: Removed.
  • platform/win/fast/ruby/ruby-length-expected.checksum: Removed.
  • platform/win/fast/ruby/ruby-length-expected.png: Removed.
  • platform/win/fast/ruby/ruby-length-expected.txt: Removed.
  • platform/win/fast/ruby/ruby-run-break-expected.checksum: Removed.
  • platform/win/fast/ruby/ruby-run-break-expected.png: Removed.
  • platform/win/fast/ruby/ruby-run-break-expected.txt: Removed.
  • platform/win/fast/ruby/ruby-runs-expected.checksum: Removed.
  • platform/win/fast/ruby/ruby-runs-expected.png: Removed.
  • platform/win/fast/ruby/ruby-runs-expected.txt: Removed.
  • platform/win/fast/ruby/ruby-runs-spans-expected.checksum: Removed.
  • platform/win/fast/ruby/ruby-runs-spans-expected.png: Removed.
  • platform/win/fast/ruby/ruby-runs-spans-expected.txt: Removed.
  • platform/win/fast/ruby/ruby-simple-expected.checksum: Removed.
  • platform/win/fast/ruby/ruby-simple-expected.png: Removed.
  • platform/win/fast/ruby/ruby-simple-expected.txt: Removed.
  • platform/win/fast/ruby/ruby-simple-rp-expected.checksum: Removed.
  • platform/win/fast/ruby/ruby-simple-rp-expected.png: Removed.
  • platform/win/fast/ruby/ruby-simple-rp-expected.txt: Removed.
  • platform/win/fast/ruby/ruby-trailing-expected.checksum: Removed.
  • platform/win/fast/ruby/ruby-trailing-expected.png: Removed.
  • platform/win/fast/ruby/ruby-trailing-expected.txt: Removed.
  • platform/win/fast/ruby/rubyDOM-insert-rt-expected.checksum: Removed.
  • platform/win/fast/ruby/rubyDOM-insert-rt-expected.png: Removed.
  • platform/win/fast/ruby/rubyDOM-insert-rt-expected.txt: Removed.
  • platform/win/fast/ruby/rubyDOM-insert-text1-expected.checksum: Removed.
  • platform/win/fast/ruby/rubyDOM-insert-text1-expected.png: Removed.
  • platform/win/fast/ruby/rubyDOM-insert-text1-expected.txt: Removed.
  • platform/win/fast/ruby/rubyDOM-insert-text2-expected.checksum: Removed.
  • platform/win/fast/ruby/rubyDOM-insert-text2-expected.png: Removed.
  • platform/win/fast/ruby/rubyDOM-insert-text2-expected.txt: Removed.
  • platform/win/fast/ruby/rubyDOM-insert-text3-expected.checksum: Removed.
  • platform/win/fast/ruby/rubyDOM-insert-text3-expected.png: Removed.
  • platform/win/fast/ruby/rubyDOM-insert-text3-expected.txt: Removed.
  • platform/win/fast/ruby/rubyDOM-remove-rt1-expected.checksum: Removed.
  • platform/win/fast/ruby/rubyDOM-remove-rt1-expected.png: Removed.
  • platform/win/fast/ruby/rubyDOM-remove-rt1-expected.txt: Removed.
  • platform/win/fast/ruby/rubyDOM-remove-rt2-expected.checksum: Removed.
  • platform/win/fast/ruby/rubyDOM-remove-rt2-expected.png: Removed.
  • platform/win/fast/ruby/rubyDOM-remove-rt2-expected.txt: Removed.
  • platform/win/fast/ruby/rubyDOM-remove-text1-expected.checksum: Removed.
  • platform/win/fast/ruby/rubyDOM-remove-text1-expected.png: Removed.
  • platform/win/fast/ruby/rubyDOM-remove-text1-expected.txt: Removed.
  • platform/win/fast/ruby/rubyDOM-remove-text2-expected.checksum: Removed.
  • platform/win/fast/ruby/rubyDOM-remove-text2-expected.png: Removed.
  • platform/win/fast/ruby/rubyDOM-remove-text2-expected.txt: Removed.
12:47 Changeset [72428] by aroben@apple.com

Fix run-javascriptcore-tests when there's a space in the path to testapi

Reviewed by Sam Weinig.

  • Scripts/run-javascriptcore-tests: Use an indirect object when calling

system() to force it to interpret spaces in the path correctly.

12:46 Changeset [72427] by aroben@apple.com

Update scripts for .exe name changes after r72327

As of r72327, the "_debug" suffix is only used in Debug_All builds.

Reviewed by Sam Weinig.

  • Scripts/run-javascriptcore-tests:

(testapiPath):

  • Scripts/sunspider-compare-results:

(pathToBuiltJSC):

  • Scripts/webkitdirs.pm:

(jscPath):
(safariPath):

12:27 Changeset [72426] by crogers@google.com

2010-11-19 Chris Rogers <crogers@google.com>

Reviewed by Darin Adler.

AudioContext should not include "HTMLNames.h"
https://bugs.webkit.org/show_bug.cgi?id=49680

No new tests since audio API is not yet implemented.

  • webaudio/AudioContext.cpp:
12:22 Changeset [72425] by sfalken@apple.com

2010-11-19 Steve Falkenburg <sfalken@apple.com>

Reviewed by Darin Adler.

Normalize Cairo/CFLite project/solution configuration names
https://bugs.webkit.org/show_bug.cgi?id=49818

2010-11-19 Steve Falkenburg <sfalken@apple.com>

Reviewed by Darin Adler.

Normalize Cairo/CFLite project/solution configuration names
https://bugs.webkit.org/show_bug.cgi?id=49818

  • WebKit.vcproj/WebKit.sln:
  • WebKit.vcproj/WebKit.vcproj:

2010-11-19 Steve Falkenburg <sfalken@apple.com>

Reviewed by Darin Adler.

Normalize Cairo/CFLite project/solution configuration names
https://bugs.webkit.org/show_bug.cgi?id=49818

  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcproj/WebCoreGenerated.vcproj:

2010-11-19 Steve Falkenburg <sfalken@apple.com>

Reviewed by Darin Adler.

Normalize Cairo/CFLite project/solution configuration names
https://bugs.webkit.org/show_bug.cgi?id=49818

  • DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
  • DumpRenderTree/win/DumpRenderTree.vcproj:
  • DumpRenderTree/win/ImageDiff.vcproj:
  • MiniBrowser/MiniBrowser.vcproj:
  • TestWebKitAPI/win/TestWebKitAPI.sln:
  • TestWebKitAPI/win/TestWebKitAPI.vcproj:
  • WebKitAPITest/WebKitAPITest.vcproj:
  • WebKitTestRunner/win/InjectedBundle.vcproj:
  • WebKitTestRunner/win/WebKitTestRunner.vcproj:
  • WinLauncher/WinLauncher.vcproj:
  • Scripts/webkitdirs.pm: Updated cairo build configs.

2010-11-19 Steve Falkenburg <sfalken@apple.com>

Reviewed by Darin Adler.

Normalize Cairo/CFLite project/solution configuration names
https://bugs.webkit.org/show_bug.cgi?id=49818

  • win/WebKit2.vcproj:
  • win/WebKit2WebProcess.vcproj:
12:20 Changeset [72424] by jparent@chromium.org

Not reviewed, remove suppression for svg/dom/fuzz-path-parser.html

  • platform/chromium/test_expectations.txt:
12:08 Changeset [72423] by dbates@webkit.org

2010-11-19 Daniel Bates <dbates@rim.com>

Reviewed by Antonio Gomes.

Replace null checks of newParent in Frame::transferChildFrameToNewDocument() with ASSERT
https://bugs.webkit.org/show_bug.cgi?id=49489

Substitute ASSERT(newParent) for null-checks for newParent in
Frame::transferChildFrameToNewDocument() since newParent is
never null.

When Frame::transferChildFrameToNewDocument() is called the child
frame's owner element has already been transferred to the new
document D and D is attached (i.e. has a frame).

  • page/Frame.cpp: (WebCore::Frame::transferChildFrameToNewDocument):
12:01 Changeset [72422] by andersca@apple.com

Add SandboxExtension abstraction and use it for the injected bundle extension
https://bugs.webkit.org/show_bug.cgi?id=49817

Reviewed by Sam Weinig.

WebCore:

Export fileSystemRepresentation symbol needed by WebKit2.

  • WebCore.exp.in:

WebKit2:

  • Shared/SandboxExtension.h:

Add SandboxExtension abstraction.

  • Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):

  • Shared/WebProcessCreationParameters.h:

Instead of encoding/decoding a token, encode/decode the sandbox extension handle.

  • Shared/mac/SandboxExtensionMac.mm: Added.

Add Mac implementation of SandboxExtension.

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::ensureWebProcess):
Create a SandboxExtension::Handle object.

  • WebKit2.xcodeproj/project.pbxproj:

Add new files.

  • WebProcess/InjectedBundle/InjectedBundle.h:

(WebKit::InjectedBundle::setSandboxExtension):
Set the sandbox extension.

  • WebProcess/InjectedBundle/mac/InjectedBundleMac.cpp:

(WebKit::InjectedBundle::load):
Consume the sandbox extension.

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeWebProcess):
Create a sandbox extension and set it on the injected bundle.

11:21 Changeset [72421] by tony@chromium.org

2010-11-19 Tony Chang <tony@chromium.org>

Unreviewed, updating Chromium DEPS to try and fix the chromium win build.

11:06 Changeset [72420] by sfalken@apple.com

Windows build fix. Remove leftover Debug_Internal use.

  • WebCore.vcproj/WebCore.vcproj:
10:52 Changeset [72419] by antonm@chromium.org

Not reviewed, remove suppression for fast/repaint/inline-block-overflow.html.

  • platform/chromium/test_expectations.txt:
10:37 Changeset [72418] by sfalken@apple.com

2010-11-18 Steve Falkenburg <sfalken@apple.com>

Reviewed by Adam Roben.

Windows vcproj configuration names should be normalized across projects
https://bugs.webkit.org/show_bug.cgi?id=49776

2010-11-18 Steve Falkenburg <sfalken@apple.com>

Reviewed by Adam Roben.

Windows vcproj configuration names should be normalized across projects
https://bugs.webkit.org/show_bug.cgi?id=49776

  • WebKit.vcproj/Interfaces.vcproj:
  • WebKit.vcproj/WebKit.sln:

2010-11-18 Steve Falkenburg <sfalken@apple.com>

Reviewed by Adam Roben.

Windows vcproj configuration names should be normalized across projects
https://bugs.webkit.org/show_bug.cgi?id=49776

  • WebCore.vcproj/WebCore.sln:
  • WebCore.vcproj/WebCore.submit.sln:
  • WebCore.vcproj/WebCoreGenerated.vcproj:
  • WebCore.vcproj/WebCoreGeneratedCairo.vsprops: Added.
  • WebCore.vcproj/WebCoreGeneratedCommon.vsprops: Added.

2010-11-18 Steve Falkenburg <sfalken@apple.com>

Reviewed by Adam Roben.

Windows vcproj configuration names should be normalized across projects
https://bugs.webkit.org/show_bug.cgi?id=49776

  • DumpRenderTree/DumpRenderTree.sln:
  • FindSafari/FindSafari.vcproj:
  • TestWebKitAPI/win/TestWebKitAPI.sln:
  • TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
  • TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops: Added.
  • WebKitAPITest/WebKitAPITest.vcproj:
  • WebKitAPITest/WebKitAPITestCommon.vsprops:
  • WebKitLauncherWin/WebKitLauncherWin.vcproj:
  • WebKitTestRunner/WebKitTestRunner.sln:
  • WebKitTestRunner/win/InjectedBundleGenerated.vcproj:
  • WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops: Added.
  • record-memory-win/record-memory-win.vcproj:

2010-11-18 Steve Falkenburg <sfalken@apple.com>

Reviewed by Adam Roben.

Windows vcproj configuration names should be normalized across projects
https://bugs.webkit.org/show_bug.cgi?id=49776

  • win/WebKit2.submit.sln:
  • win/WebKit2Generated.vcproj:
  • win/WebKit2GeneratedCommon.vsprops: Added.
10:29 Changeset [72417] by tony@chromium.org

2010-11-19 Tony Chang <tony@chromium.org>

Reviewed by Kent Tamura.

[chromium] Enable webkit's TestNetscapePlugIn for DRT on win and linux
https://bugs.webkit.org/show_bug.cgi?id=49706

  • platform/chromium/drt_expectations.txt:

2010-11-19 Tony Chang <tony@chromium.org>

Reviewed by Kent Tamura.

[chromium] Enable webkit's TestNetscapePlugIn for DRT on win and linux
https://bugs.webkit.org/show_bug.cgi?id=49706

It is enabled simply by copying the plugin into
{Debug,Release}/plugins. This change also rolls in a version of
Chromium that disables the old plugin.

  • WebKit.gyp:
10:23 Changeset [72416] by mihaip@chromium.org

2010-11-19 Mihai Parparita <mihaip@chromium.org>

Add recent upstream Chromium dependencies to .gitignore.

  • .gitignore:
10:19 Changeset [72415] by commit-queue@webkit.org

2010-11-19 James Simonsen <simonjam@chromium.org>

Reviewed by Darin Fisher.

[Web Timing] Add unloadEventStart
https://bugs.webkit.org/show_bug.cgi?id=49101

  • fast/dom/Window/window-properties-performance-expected.txt:
  • fast/dom/script-tests/webtiming.js: (checkTimingBeforeLoad): (checkTimingWhileDeferred): (checkWebTimingWhileAsync): (checkWebTimingOnLoad): (checkWebTimingAfterLoad):
  • fast/dom/webtiming-document-open-expected.txt:
  • fast/dom/webtiming-expected.txt:
  • fast/dom/webtiming-navigate-within-document-expected.txt:

2010-11-19 James Simonsen <simonjam@chromium.org>

Reviewed by Darin Fisher.

[Web Timing] Add unloadEventStart
https://bugs.webkit.org/show_bug.cgi?id=49101

  • loader/DocumentLoadTiming.h: (WebCore::DocumentLoadTiming::DocumentLoadTiming):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::stopLoading): Use dispatchTimedEvent().
  • page/DOMWindow.cpp: (WebCore::DOMWindow::dispatchLoadEvent): Use dispatchTimedEvent(). (WebCore::DOMWindow::dispatchTimedEvent): Added.
  • page/DOMWindow.h:
  • page/Timing.cpp: (WebCore::Timing::unloadEventStart):
  • page/Timing.h:
  • page/Timing.idl:
10:08 Changeset [72414] by antonm@chromium.org

Not reviewed, remove a suppression for svg/dom/svglist-exception-on-out-bounds-error.html

  • platform/chromium/test_expectations.txt:
10:02 Changeset [72413] by mrobinson@webkit.org

2010-11-19 Martin Robinson <mrobinson@igalia.com>

Reviewed by Daniel Bates.

[GTK] fast/text/international tests are flaky on the bots
https://bugs.webkit.org/show_bug.cgi?id=49781

Beef up the == operator overload for Freetype FontPlatformData. Before
if two FontPlatformDatas had hash values which fell into the same bucket
and were similar enough, they would be evaluated as being equal, leading
to failures.

No new tests for this change. It's very hard to test, because it depends
on the memory address of new allocations. Hopefully flakiness on the bots
will go away after patch.

  • platform/graphics/freetype/FontPlatformDataFreeType.cpp: (WebCore::FontPlatformData::operator==): Beef up the == operator overload.
09:34 Changeset [72412] by benjamin.poulain@nokia.com

2010-11-19 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] mask-box-image renders wrong in certain conditions
https://bugs.webkit.org/show_bug.cgi?id=43476

When rendering a pixmap with a dest rect having a null dimension,
Qt uses the dimension of the Pixmap. The other ports do not render
anything by convention.

This patch change BitmapImage to follow the convention of other ports and do not
paint anything.

  • platform/graphics/qt/ImageQt.cpp: (WebCore::BitmapImage::draw):
09:16 Changeset [72411] by paroga@webkit.org

2010-11-19 Patrick Gansterer <paroga@webkit.org>

Unreviewed, build fix after r72360.

  • bytecode/CodeBlock.h: (JSC::CodeBlock::bytecodeOffset):
09:01 Changeset [72410] by antonm@chromium.org

Temporary suppression for fast/repaint/inline-block-overflow.html
See r72405.
It needs Chromium's images.

  • platform/chromium/test_expectations.txt:
08:51 Changeset [72409] by commit-queue@webkit.org

2010-11-19 Sam Magnuson <smagnuso@gmail.com>

Reviewed by Andreas Kling.

[Qt] Compile with QT_NO_UNDOCOMMAND
https://bugs.webkit.org/show_bug.cgi?id=49752

  • WebCoreSupport/EditCommandQt.cpp: (EditCommandQt::EditCommandQt):
  • WebCoreSupport/EditCommandQt.h:
08:51 Changeset [72408] by aestes@apple.com

svg/batik/text/smallFonts.svg needs Leopard-specific results after
r72141.

  • platform/mac-leopard/svg/batik/text/smallFonts-expected.txt: Added.
08:45 Changeset [72407] by antonm@chromium.org

Temporary suppression for fast/images/imagemap-focus-ring-zoom.html.
See r72402.
It needs Chromium's images.

  • platform/chromium/test_expectations.txt:
08:41 Changeset [72406] by aestes@apple.com

Skip failing tests on the Leopard bots.

  • platform/mac-leopard/Skipped:
08:27 Changeset [72405] by zimmermann@webkit.org

2010-11-19 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Don't call invalidateSVGAttributes() from the setFooBaseValue() methods
https://bugs.webkit.org/show_bug.cgi?id=49807

Covered by existing tests.

  • svg/SVGComponentTransferFunctionElement.cpp: (WebCore::SVGComponentTransferFunctionElement::parseMappedAttribute): Use setFooBaseValue(newList) instead of fooBaseValue() = newList;
  • svg/SVGFEColorMatrixElement.cpp: (WebCore::SVGFEColorMatrixElement::parseMappedAttribute): Ditto.
  • svg/SVGFEConvolveMatrixElement.cpp: (WebCore::SVGFEConvolveMatrixElement::parseMappedAttribute): Ditto.
  • svg/SVGGradientElement.cpp: (WebCore::SVGGradientElement::parseMappedAttribute): Ditto.
  • svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::parseMappedAttribute): Ditto.
  • svg/SVGStyledTransformableElement.cpp: (WebCore::SVGStyledTransformableElement::parseMappedAttribute): Ditto.
  • svg/SVGTextElement.cpp: (WebCore::SVGTextElement::parseMappedAttribute): Ditto.
  • svg/SVGTextPositioningElement.cpp: (WebCore::SVGTextPositioningElement::parseMappedAttribute): Ditto.
  • svg/properties/SVGAnimatedPropertyMacros.h: Don't call invalidateSVGAttributes() in setFooBaseValue().
08:21 Changeset [72404] by antonm@chromium.org

Not reviewed, nuking now unnecessary suppression.

  • platform/chromium/test_expectations.txt:
08:16 Changeset [72403] by commit-queue@webkit.org

2010-11-19 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r72399.
http://trac.webkit.org/changeset/72399
https://bugs.webkit.org/show_bug.cgi?id=49805

Broke Chromium build (Requested by antonm_ on #webkit).

  • page/chromium/ChromeClientChromium.h:
  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupContainer::showPopup): (WebCore::PopupContainer::showExternal): (WebCore::PopupListBox::layout): (WebCore::PopupMenuChromium::show):
  • platform/chromium/PopupMenuChromium.h:

2010-11-19 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r72399.
http://trac.webkit.org/changeset/72399
https://bugs.webkit.org/show_bug.cgi?id=49805

Broke Chromium build (Requested by antonm_ on #webkit).

  • src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::popupOpened):
  • src/ChromeClientImpl.h:
08:05 Changeset [72402] by yael.aharon@nokia.com

2010-11-19 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Antonio Gomes.

Focus ring in image maps does not take zooming into account
https://bugs.webkit.org/show_bug.cgi?id=49625

  • fast/images/imagemap-focus-ring-zoom.html: Added.
  • platform/mac/fast/images/imagemap-focus-ring-zoom-expected.checksum: Added.
  • platform/mac/fast/images/imagemap-focus-ring-zoom-expected.png: Added.
  • platform/mac/fast/images/imagemap-focus-ring-zoom-expected.txt: Added.

2010-11-19 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Antonio Gomes.

Focus ring in image maps does not take zooming into account
https://bugs.webkit.org/show_bug.cgi?id=49625

Take pageZoomFactor into account when calculating the path of the focus ring.

Test: fast/images/imagemap-focus-ring-zoom.html

  • html/HTMLAreaElement.cpp: (WebCore::HTMLAreaElement::getPath):
07:47 Changeset [72401] by andersca@apple.com

Crash in WebKit::PluginView::manualLoadDidReceiveResponse when navigating to a .wav file in WebKit2 on Mac
https://bugs.webkit.org/show_bug.cgi?id=48559
<rdar://problem/8606622>

Reviewed by Adam Roben.

Add null checks for m_plugin.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::manualLoadDidReceiveResponse):
(WebKit::PluginView::manualLoadDidReceiveData):
(WebKit::PluginView::manualLoadDidFinishLoading):
(WebKit::PluginView::manualLoadDidFail):

07:44 Changeset [72400] by zimmermann@webkit.org

2010-11-19 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

SVGTransformList::consolidate() fails on empty lists
https://bugs.webkit.org/show_bug.cgi?id=49619

Return null in consolidate() when the list is empty, according to SVG 1.1.

Test: svg/dom/SVGTransformList-empty-list-consolidation.html

  • svg/properties/SVGTransformListPropertyTearOff.h: (WebCore::SVGTransformListPropertyTearOff::consolidate):

2010-11-19 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

SVGTransformList::consolidate() fails on empty lists
https://bugs.webkit.org/show_bug.cgi?id=49619

  • svg/dom/SVGTransformList-empty-list-consolidation-expected.txt: Added.
  • svg/dom/SVGTransformList-empty-list-consolidation.html: Added.
07:38 Changeset [72399] by jcivelli@chromium.org

2010-11-19 Jay Civelli <jcivelli@chromium.org>

Reviewed by David Levin.

[chromium] Removing the now unused code to show popup externally on Mac.
https://bugs.webkit.org/show_bug.cgi?id=49747

  • page/chromium/ChromeClientChromium.h:
  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupContainer::showPopup): (WebCore::PopupListBox::layout): (WebCore::PopupMenuChromium::show):
  • platform/chromium/PopupMenuChromium.h:

2010-11-19 Jay Civelli <jcivelli@chromium.org>

Reviewed by David Levin.

Removing unused code to show popup externally on Mac.
https://bugs.webkit.org/show_bug.cgi?id=49747

  • src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::popupOpened):
  • src/ChromeClientImpl.h:
07:34 Changeset [72398] by loislo@chromium.org

2010-11-18 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: reduce the footprint of InspectorBackendDispatcher.
InspectorBackendDispatcher is a generated file.
Its content is not optimal and loc may be reduced by a quarter.
In each generated function we have a code for getting 'in' values from
the arguments properties object. I've extracted this code into separate getters.
The side effect is better readability of the generated code.

https://bugs.webkit.org/show_bug.cgi?id=49729

  • inspector/CodeGeneratorInspector.pm:
07:14 Changeset [72397] by ossy@webkit.org

Unreviewed.

[Qt] REGRESSION (r72351): fast/profiler/throw-exception-from-eval.html fails
https://bugs.webkit.org/show_bug.cgi?id=49801

[Qt] REGRESSION (r72360): http/tests/security/aboutBlank/xss-DENIED-* tests fail
https://bugs.webkit.org/show_bug.cgi?id=49802

  • platform/qt/Skipped: Add failing tests to the Skipped list until fix.
    • fast/profiler/throw-exception-from-eval.html
    • http/tests/security/aboutBlank/xss-DENIED-navigate-opener-document-write.html
    • http/tests/security/aboutBlank/xss-DENIED-navigate-opener-javascript-url.html
    • http/tests/security/aboutBlank/xss-DENIED-set-opener.html
07:06 Changeset [72396] by commit-queue@webkit.org

2010-11-19 John Knottenbelt <jknotten@chromium.org>

Reviewed by Jeremy Orlow.

Reentrant Geolocation tests crash with an assertion.
https://bugs.webkit.org/show_bug.cgi?id=39908

PositionErrors should not be sent to Geolocation watches or one
shots that are due to receive a valid cached position. Re-enable
fast/dom/Geolocation/maximum-age.html on Mac WebKit.

  • platform/mac/Skipped:

2010-11-19 John Knottenbelt <jknotten@chromium.org>

Reviewed by Jeremy Orlow.

Reentrant Geolocation tests crash with an assertion.
https://bugs.webkit.org/show_bug.cgi?id=39908

PositionErrors should not be sent to Geolocation watches or one shots
that are due to receive a valid cached position.

Test: fast/dom/Geolocation/maximum-age.html

  • page/Geolocation.cpp: (WebCore::Geolocation::sendError): (WebCore::Geolocation::copyCachedNotifiers): (WebCore::Geolocation::handleError):
  • page/Geolocation.h:
06:57 Changeset [72395] by antonm@chromium.org

Not reviewed, next batch of Chromium suppressions for layout test failures after
http://trac.webkit.org/changeset/72381.

  • platform/chromium/test_expectations.txt:
06:42 Changeset [72394] by commit-queue@webkit.org

2010-11-19 Sam Magnuson <smagnuso@gmail.com>

Reviewed by Laszlo Gombos.

[Qt] Compile with QT_NO_CLIPBOARD
https://bugs.webkit.org/show_bug.cgi?id=49742

  • platform/qt/PasteboardQt.cpp: (WebCore::Pasteboard::canSmartReplace):
06:38 Changeset [72393] by antonm@chromium.org

Not reviewed, removing duplicate expectation.

  • platform/chromium/test_expectations.txt:
06:26 Changeset [72392] by pfeldman@chromium.org

2010-11-19 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: flip chromium version to mitigate two-sided patch impact.

  • DEPS:
06:21 Changeset [72391] by antonm@chromium.org

Upstreaming Chromium suppressions.

  • platform/chromium/test_expectations.txt:
06:15 Changeset [72390] by zimmermann@webkit.org

2010-11-19 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Andreas Kling.

Remove more unused V8/SVG code
https://bugs.webkit.org/show_bug.cgi?id=49800

Remove DOMSVGObjectWithContextMap and all usages.

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/DOMDataStore.cpp: (WebCore::DOMDataStore::DOMDataStore): (WebCore::DOMDataStore::getDOMWrapperMap):
  • bindings/v8/DOMDataStore.h: (WebCore::DOMDataStore::domSvgElementInstanceMap):
  • bindings/v8/ScopedDOMDataStore.cpp: (WebCore::ScopedDOMDataStore::ScopedDOMDataStore): (WebCore::ScopedDOMDataStore::~ScopedDOMDataStore):
  • bindings/v8/StaticDOMDataStore.cpp: (WebCore::StaticDOMDataStore::StaticDOMDataStore):
  • bindings/v8/StaticDOMDataStore.h:
  • bindings/v8/V8DOMMap.cpp: (WebCore::removeAllDOMObjectsInCurrentThread):
  • bindings/v8/V8DOMMap.h:
06:13 Changeset [72389] by zherczeg@webkit.org

createImageBuffer fail should be handled in the same way as other fails
https://bugs.webkit.org/show_bug.cgi?id=49799

Reviewed by Nikolas Zimmermann.

WebCore:

When createImageBuffer fails (i.e the image width or height is less than
0.5, which is rounded to 0) it just returs with false. Since the m_filter
hash map is not updated in this case, the filter image is not drawn.

Test: svg/filters/filter-rounding-issues.svg

  • rendering/RenderSVGResourceFilter.cpp:

(WebCore::RenderSVGResourceFilter::applyResource):

LayoutTests:

  • platform/mac/svg/filters/filter-rounding-issues-expected.checksum: Added.
  • platform/mac/svg/filters/filter-rounding-issues-expected.png: Added.
  • svg/filters/filter-rounding-issues-expected.txt: Added.
  • svg/filters/filter-rounding-issues.svg: Added.
06:08 Changeset [72388] by antonm@chromium.org

Not reviewed, next batch of Chromium suppressions for layout test failures after
http://trac.webkit.org/changeset/72381.

  • platform/chromium/test_expectations.txt:
05:58 Changeset [72387] by zimmermann@webkit.org

2010-11-19 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Andreas Kling.

Remove old style SVG DOM JS bindings and DeprecatedSVGAnimated* files
https://bugs.webkit.org/show_bug.cgi?id=49796

Just remove the old style SVG DOM JS bindings, now that everything has been converted to the new concept.

  • GNUmakefile.am: Remove SVGList/SVGListTraits/JSSVGPODListCustom/JSSVGPODTypeWrapper/JSSVGContextCache and V8SVGPODTypeWrapper files.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • bindings/js/JSSVGContextCache.h: Removed.
  • bindings/js/JSSVGPODListCustom.h: Removed.
  • bindings/js/JSSVGPODTypeWrapper.h: Removed.
  • bindings/v8/V8Proxy.cpp: Remove SVG specific context cache code, which is no longer needed.
  • bindings/v8/V8Proxy.h: Ditto.
  • bindings/v8/V8SVGPODTypeWrapper.h: Removed.
  • svg/DeprecatedSVGAnimatedProperty.h: Removed.
  • svg/DeprecatedSVGAnimatedPropertyTraits.h: Removed.
  • svg/DeprecatedSVGAnimatedTemplate.h: Removed.
  • svg/SVGElement.h: Remove DeprecatedSVGAnimated* include, which pulled in SVGNames.h for every file.
  • svg/SVGList.h: Removed.
  • svg/SVGListTraits.h: Removed.
05:33 Changeset [72386] by apavlov@chromium.org

2010-11-19 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [REGRESSION] Crash on opening WebInspector for a page with CSS containing @media with nested rules
https://bugs.webkit.org/show_bug.cgi?id=49731

Temporarily disable building of styles for nested rules.

  • inspector/InspectorStyleSheet.cpp: (WebCore::InspectorStyleSheet::buildObjectForRule): (WebCore::InspectorStyleSheet::buildObjectForStyle): (WebCore::InspectorStyleSheet::ensureParsedDataReady): (WebCore::InspectorStyleSheet::ensureSourceData):
  • inspector/InspectorStyleSheet.h:
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype._rebuildUpdate): (WebInspector.StylesSidebarPane.prototype._refreshStyleRules): (WebInspector.StylesSidebarPane.prototype._rebuildStyleRules):
05:30 Changeset [72385] by antonm@chromium.org

Not reviewed, suppressing Chromium layout test failures after
http://trac.webkit.org/changeset/72381.

  • platform/chromium/test_expectations.txt:
05:20 Changeset [72384] by zimmermann@webkit.org

2010-11-19 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Fix Qt build.

  • WebCore.pro: Move SVGPathSegListPropertyTearOff.cpp from HEADERS to SOURCES list. This got lost, when reapplying the patch from the bug - I only fixed it locally before landing the first time.
05:19 Changeset [72383] by antonm@chromium.org

Not reviewed, rebaselining vertical text tests for Chromium.

  • platform/chromium-linux/fast/blockflow/vertical-align-table-baseline-expected.checksum: Added.
  • platform/chromium-linux/fast/blockflow/vertical-align-table-baseline-expected.png: Added.
  • platform/chromium-linux/fast/blockflow/vertical-baseline-alignment-expected.checksum: Added.
  • platform/chromium-linux/fast/blockflow/vertical-baseline-alignment-expected.png: Added.
  • platform/chromium-mac/fast/blockflow/vertical-align-table-baseline-expected.checksum: Added.
  • platform/chromium-mac/fast/blockflow/vertical-align-table-baseline-expected.png: Added.
  • platform/chromium-mac/fast/blockflow/vertical-baseline-alignment-expected.checksum: Added.
  • platform/chromium-mac/fast/blockflow/vertical-baseline-alignment-expected.png: Added.
  • platform/chromium-win/fast/blockflow/vertical-align-table-baseline-expected.checksum: Added.
  • platform/chromium-win/fast/blockflow/vertical-align-table-baseline-expected.png: Added.
  • platform/chromium-win/fast/blockflow/vertical-align-table-baseline-expected.txt: Added.
  • platform/chromium-win/fast/blockflow/vertical-baseline-alignment-expected.checksum: Added.
  • platform/chromium-win/fast/blockflow/vertical-baseline-alignment-expected.png: Added.
  • platform/chromium-win/fast/blockflow/vertical-baseline-alignment-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
05:00 Changeset [72382] by alex@webkit.org

2010-11-19 Alejandro G. Castro <alex@igalia.com>

Unreviewed, added the font-size-zero.html test to skipped and
uploaded the bug: https://bugs.webkit.org/show_bug.cgi?id=49793

It was added with r72327.

  • platform/gtk/Skipped:
04:54 Changeset [72381] by zimmermann@webkit.org

2010-11-19 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Convert SVGPathSeg/SVGPathSegList to the new SVGPropertyTearOff concept
https://bugs.webkit.org/show_bug.cgi?id=49580

SVGPathElement.cloneNode loses generated pathSegList
https://bugs.webkit.org/show_bug.cgi?id=43388

SVG Path elements are not correctly updated through pathSegList manipulation on relative values
https://bugs.webkit.org/show_bug.cgi?id=30219

Changing an SVGPathSeg does not update a following Smooth Cubic Curveto
https://bugs.webkit.org/show_bug.cgi?id=19741

SVGPathElement should only build SVGPathSeg* list on demand
https://bugs.webkit.org/show_bug.cgi?id=10827

Tests: svg/W3C-SVG-1.1-SE/paths-dom-02-f.svg

svg/dom/SVGPathSegList-appendItem.xhtml
svg/dom/SVGPathSegList-clear-and-initialize.xhtml
svg/dom/SVGPathSegList-cloning.html
svg/dom/SVGPathSegList-insertItemBefore.xhtml
svg/dom/SVGPathSegList-removeItem.xhtml
svg/dom/SVGPathSegList-replaceItem.xhtml
svg/dom/SVGPathSegList-xml-dom-synchronization.xhtml
svg/dom/SVGPathSegList-xml-dom-synchronization2.xhtml
svg/dom/SVGPathSegList-segment-modification.svg

Convert SVGPathSeg*/SVGPathSegList to the new SVG(Animated)PropertyTearOff concept.
Unlike all other SVG* types that use the SVGPropertyTearOff concept, SVGPathSegs are already refcounted,
and don't need to be wrapped in SVGPropertyTearOff objects. The consequence is that SVGPathSegs need to track
themselves to which list and path element they belong. Introduce new SVGAnimatedPathSegListPropertyTearOff
and SVGPathSegListPropertyTearOff classes, that encapsulate the special needed for SVGPathSegList.

Each SVGPathSeg now needs to store a RefPtr<SVGPathElement> - this makes it impossible to use SVGPathSegList
to represent the 'd' attribute internally in SVGPathElement. SVGPathSegList is now only used in the SVG DOM bindings
if someone explicitely requests 'pathElement.pathSegList' (eg. via JS). Switch to use SVGPathByteStream to store
the 'd' attribute data in SVGPathElement, which is much more compact, and less memory intensive.
Dirk already prepared SVGPathParserFactory some months ago, which allows easy conversion between
String/Path/SVGPathSegList/SVGPathByteStream in all directions, including normalizing the lists, when requested.

As consequence SVGPathSegList is now only built on demand, when explicitely requested. Using the SVGAnimatedProperty
concept gives us 'd' attribute <-> SVGPathSegList synchronization for free, fixing several bugs, listed above.

  • Android.mk: Remove obsolete SVGPathSeg*.cpp files and SVGAnimatedPathData.cpp from build.
  • CMakeLists.txt: Ditto.
  • DerivedSources.make: Remove SVGAnimatedPathData IDL generation.
  • GNUmakefile.am: Remove obsolete SVGPathSeg*.cpp files and SVGAnimatedPathData.cpp from build.
  • WebCore.gyp/WebCore.gyp: Remove SVGAnimatedPathData IDL generation.
  • WebCore.gypi: Remove obsolete SVGPathSeg*.cpp files and SVGAnimatedPathData.cpp from build.
  • WebCore.order: Remove no-longer existant SVGAnimatedPathData symbols.
  • WebCore.pro: Remove obsolete SVGPathSeg*.cpp files and SVGAnimatedPathData.cpp / JSSVGPathSegCustom.* from build.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • bindings/js/JSBindingsAllInOne.cpp: Remove JSSVGPathSegCustom.cpp from build.
  • bindings/js/JSDOMBinding.cpp: Adapt to toJS() changes, remove context parameter. (WebCore::setDOMException):
  • bindings/js/JSDOMBinding.h: Remove obsolete CREATE_SVG_OBJECT_WRAPPER macro, the context parameter is not existant anymore.
  • bindings/js/JSSVGPathSegCustom.cpp: Replace CREATE_SVG_OBJECT_WRAPPER by CREATE_DOM_OBJECT_WRAPPER. Remove context parameter/handling. (WebCore::toJS):
  • bindings/js/JSSVGPathSegListCustom.cpp: Removed.
  • bindings/scripts/CodeGenerator.pm: Map 'SVGPathSegList' IDL type to SVG 'SVGPathSegListPropertyTearOff' native type.
  • bindings/scripts/CodeGeneratorJS.pm: Remove IsSVGTypeNeedingContextParameter() methods and usages. Handle SVGPathSegListPropertyTearOff.
  • bindings/scripts/CodeGeneratorObjC.pm: Handle SVGPathSegListPropertyTearOff.
  • bindings/scripts/CodeGeneratorV8.pm: Remove IsSVGTypeNeedingContextParameter() methods and usages.
  • rendering/SVGRenderTreeAsText.cpp: Build path string from byte stream, not path segment list. (WebCore::operator<<):
  • svg/SVGAllInOne.cpp: Remove obsolete cpp files.
  • svg/SVGAnimatedPathData.cpp: Removed.
  • svg/SVGAnimatedPathData.h: Removed.
  • svg/SVGAnimatedPathData.idl: Removed.
  • svg/SVGPathElement.cpp: Build SVGPathList on demand. Use SVGPathByteStream to parse/store the 'd' attribute content. (WebCore::SVGPathElement::SVGPathElement): (WebCore::SVGPathElement::getPathSegAtLength): Use SVGPathByteStream, not SVGPathSegList to determine the getPathSegAtLength() information. (WebCore::SVGPathElement::createSVGPathSegClosePath): Pass SVGPathElement to SVGPathSeg and a SVGPathSegRole parameter and store it to track the list origin. (WebCore::SVGPathElement::createSVGPathSegMovetoAbs): Ditto. (WebCore::SVGPathElement::createSVGPathSegMovetoRel): Ditto. (WebCore::SVGPathElement::createSVGPathSegLinetoAbs): Ditto. (WebCore::SVGPathElement::createSVGPathSegLinetoRel): Ditto. (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicAbs): Ditto. (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicRel): Ditto. (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticAbs): Ditto. (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticRel): Ditto. (WebCore::SVGPathElement::createSVGPathSegArcAbs): Ditto. (WebCore::SVGPathElement::createSVGPathSegArcRel): Ditto. (WebCore::SVGPathElement::createSVGPathSegLinetoHorizontalAbs): Ditto. (WebCore::SVGPathElement::createSVGPathSegLinetoHorizontalRel): Ditto. (WebCore::SVGPathElement::createSVGPathSegLinetoVerticalAbs): Ditto. (WebCore::SVGPathElement::createSVGPathSegLinetoVerticalRel): Ditto. (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicSmoothAbs): Ditto. (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicSmoothRel): Ditto. (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticSmoothAbs): Ditto. (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticSmoothRel): Ditto. (WebCore::SVGPathElement::parseMappedAttribute): Build SVGPathByteStream from 'd' attribute, not a SVGPathSegList. (WebCore::SVGPathElement::svgAttributeChanged): If a SVGPathSegList object has been built, synchronize it with the 'd' attribute. (WebCore::SVGPathElement::synchronizeProperty): Synchronize 'd' attribute with the SVGPathSegList, if needed. (WebCore::SVGPathElement::synchronizeD): Added. (WebCore::SVGPathElement::pathSegList): Use same trick as in SVGPolyElement to expose the 'pathSegList' / 'animatedPathSegList' object to the SVG DOM bindings. (WebCore::SVGPathElement::normalizedPathSegList): Ditto. (WebCore::SVGPathElement::animatedPathSegList): Ditto. (WebCore::SVGPathElement::animatedNormalizedPathSegList): Ditto. (WebCore::SVGPathElement::toPathData): Build 'Path' object from SVGPathByteStream, not from SVGPathSegList. (WebCore::SVGPathElement::pathSegListChanged): Used to synchronize the SVGPathSegLists and the d attribute, as well as any changes from any SVGPathSeg associated with this SVGPathElement.
  • svg/SVGPathElement.h: Add new accessors... (WebCore::SVGPathElement::pathByteStream): ... needed by SVGRenderTreeAsText. (WebCore::SVGPathElement::animatablePathSegList): ... needed by SVGPathSegListPropertyTearOff.
  • svg/SVGPathElement.idl: Merge SVGAnimatedPathData interface into SVGPathElement.
  • svg/SVGPathParserFactory.cpp: Cleanup SVGPathParserFactory, remove obsolete methods, now that SVGPathElement switched to using SVGPathByteStream internally. (WebCore::globalSVGPathSegListBuilder): (WebCore::SVGPathParserFactory::buildSVGPathByteStreamFromSVGPathSegList): (WebCore::SVGPathParserFactory::buildPathFromByteStream): (WebCore::SVGPathParserFactory::buildSVGPathSegListFromByteStream): (WebCore::SVGPathParserFactory::buildStringFromSVGPathSegList): (WebCore::SVGPathParserFactory::buildSVGPathByteStreamFromString): (WebCore::SVGPathParserFactory::buildAnimatedSVGPathByteStream): (WebCore::SVGPathParserFactory::getSVGPathSegAtLengthFromSVGPathByteStream):
  • svg/SVGPathParserFactory.h:
  • svg/SVGPathSeg.cpp: Removed.
  • svg/SVGPathSeg.h: Add new SVGPathSegRole enum, identifying to which list a path segment belongs. (WebCore::SVGPathSeg::SVGPathSeg):
  • svg/SVGPathSeg.idl: Reindented.
  • svg/SVGPathSegArc.cpp: Removed.
  • svg/SVGPathSegArc.h: All setters now call the commitChange() method.
  • svg/SVGPathSegArcAbs.idl: Enable StrictTypeChecking.
  • svg/SVGPathSegArcRel.idl: Ditto.
  • svg/SVGPathSegClosePath.cpp: Removed.
  • svg/SVGPathSegClosePath.h:
  • svg/SVGPathSegCurvetoCubic.cpp: Removed.
  • svg/SVGPathSegCurvetoCubic.h: All setters now call the commitChange() method.
  • svg/SVGPathSegCurvetoCubicAbs.idl: Enable StrictTypeChecking.
  • svg/SVGPathSegCurvetoCubicRel.idl: Ditto.
  • svg/SVGPathSegCurvetoCubicSmooth.cpp: Removed.
  • svg/SVGPathSegCurvetoCubicSmooth.h: All setters now call the commitChange() method.
  • svg/SVGPathSegCurvetoCubicSmoothAbs.idl: Enable StrictTypeChecking.
  • svg/SVGPathSegCurvetoCubicSmoothRel.idl: Ditto.
  • svg/SVGPathSegCurvetoQuadratic.cpp: Removed.
  • svg/SVGPathSegCurvetoQuadratic.h: All setters now call the commitChange() method.
  • svg/SVGPathSegCurvetoQuadraticAbs.idl: Enable StrictTypeChecking.
  • svg/SVGPathSegCurvetoQuadraticRel.idl: Ditto.
  • svg/SVGPathSegCurvetoQuadraticSmooth.cpp: Removed.
  • svg/SVGPathSegCurvetoQuadraticSmooth.h: All setters now call the commitChange() method.
  • svg/SVGPathSegCurvetoQuadraticSmoothAbs.idl: Enable StrictTypeChecking.
  • svg/SVGPathSegCurvetoQuadraticSmoothRel.idl: Ditto.
  • svg/SVGPathSegLineto.cpp: Removed.
  • svg/SVGPathSegLineto.h: All setters now call the commitChange() method.
  • svg/SVGPathSegLinetoAbs.idl: Enable StrictTypeChecking.
  • svg/SVGPathSegLinetoHorizontal.cpp: Removed.
  • svg/SVGPathSegLinetoHorizontal.h: All setters now call the commitChange() method.
  • svg/SVGPathSegLinetoHorizontalAbs.idl: Enable StrictTypeChecking.
  • svg/SVGPathSegLinetoHorizontalRel.idl: Ditto.
  • svg/SVGPathSegLinetoRel.idl: Enable StrictTypeChecking.
  • svg/SVGPathSegLinetoVertical.cpp: Removed.
  • svg/SVGPathSegLinetoVertical.h: All setters now call the commitChange() method.
  • svg/SVGPathSegLinetoVerticalAbs.idl: Enable StrictTypeChecking.
  • svg/SVGPathSegLinetoVerticalRel.idl: Ditto.
  • svg/SVGPathSegList.cpp: Switch from SVGList<RefPtr<SVGPathSeg> > to a plain Vector<RefPtr<SVGPathSeg> >. (WebCore::SVGPathSegList::valueAsString): Utilize SVGPathParserFactory to build a String from a SVGPathSegList. (WebCore::SVGPathSegList::commitChange): Call SVGPathElement::pathSegListChanged().
  • svg/SVGPathSegList.h: (WebCore::SVGPathSegList::SVGPathSegList):
  • svg/SVGPathSegList.idl: Remove [JSCCustom] flags, no longer needed.
  • svg/SVGPathSegListBuilder.cpp: Adapt to SVGPathSegList API changes. (WebCore::SVGPathSegListBuilder::SVGPathSegListBuilder): (WebCore::SVGPathSegListBuilder::moveTo): (WebCore::SVGPathSegListBuilder::lineTo): (WebCore::SVGPathSegListBuilder::lineToHorizontal): (WebCore::SVGPathSegListBuilder::lineToVertical): (WebCore::SVGPathSegListBuilder::curveToCubic): (WebCore::SVGPathSegListBuilder::curveToCubicSmooth): (WebCore::SVGPathSegListBuilder::curveToQuadratic): (WebCore::SVGPathSegListBuilder::curveToQuadraticSmooth): (WebCore::SVGPathSegListBuilder::arcTo): (WebCore::SVGPathSegListBuilder::closePath):
  • svg/SVGPathSegListBuilder.h: Ditto. (WebCore::SVGPathSegListBuilder::setCurrentSVGPathElement): (WebCore::SVGPathSegListBuilder::setCurrentSVGPathSegList): (WebCore::SVGPathSegListBuilder::setCurrentSVGPathSegRole): (WebCore::SVGPathSegListBuilder::cleanup):
  • svg/SVGPathSegListSource.cpp: Ditto. (WebCore::SVGPathSegListSource::SVGPathSegListSource): (WebCore::SVGPathSegListSource::parseSVGSegmentType): (WebCore::SVGPathSegListSource::nextCommand): (WebCore::SVGPathSegListSource::parseMoveToSegment): (WebCore::SVGPathSegListSource::parseLineToSegment): (WebCore::SVGPathSegListSource::parseCurveToQuadraticSmoothSegment):
  • svg/SVGPathSegListSource.h: Ditto. (WebCore::SVGPathSegListSource::create):
  • svg/SVGPathSegMoveto.cpp: Removed.
  • svg/SVGPathSegMoveto.h: All setters now call the commitChange() method.
  • svg/SVGPathSegMovetoAbs.idl: Enable StrictTypeChecking.
  • svg/SVGPathSegMovetoRel.idl: Ditto.
  • svg/SVGPathSegWithContext.h: Added. This is the new base class for all SVGPathSeg derived types, that's associated with a SVGPathElement and a 'role' (normalized/unaltered segment list). (WebCore::SVGPathSegWithContext::SVGPathSegWithContext): (WebCore::SVGPathSegWithContext::animatedProperty): (WebCore::SVGPathSegWithContext::setContextAndRole): (WebCore::SVGPathSegWithContext::commitChange): (WebCore::SVGPathSegSingleCoordinate::x): (WebCore::SVGPathSegSingleCoordinate::setX): (WebCore::SVGPathSegSingleCoordinate::y): (WebCore::SVGPathSegSingleCoordinate::setY): (WebCore::SVGPathSegSingleCoordinate::SVGPathSegSingleCoordinate):
  • svg/properties/SVGAnimatedPathSegListPropertyTearOff.h: Added. (WebCore::SVGAnimatedPathSegListPropertyTearOff::baseVal): (WebCore::SVGAnimatedPathSegListPropertyTearOff::animVal): (WebCore::SVGAnimatedPathSegListPropertyTearOff::removeItemFromList): (WebCore::SVGAnimatedPathSegListPropertyTearOff::create): (WebCore::SVGAnimatedPathSegListPropertyTearOff::SVGAnimatedPathSegListPropertyTearOff):
  • svg/properties/SVGPathSegListPropertyTearOff.cpp: Added. (WebCore::SVGPathSegListPropertyTearOff::clear): Added in the cpp file, not in the header, as it needs access to SVGPathSegWithContext, which we can't include from the header. (WebCore::SVGPathSegListPropertyTearOff::getItem): Ditto. (WebCore::SVGPathSegListPropertyTearOff::removeItem): Ditto. (WebCore::SVGPathSegListPropertyTearOff::contextElement): Needs access to SVGPathElement, that's why it lives in the cpp file. (WebCore::SVGPathSegListPropertyTearOff::processIncomingListItemValue): Needs access to SVGPathSegWithContext.
  • svg/properties/SVGPathSegListPropertyTearOff.h: Added. (WebCore::SVGPathSegListPropertyTearOff::create): (WebCore::SVGPathSegListPropertyTearOff::removeItemFromList): (WebCore::SVGPathSegListPropertyTearOff::numberOfItems): (WebCore::SVGPathSegListPropertyTearOff::initialize): (WebCore::SVGPathSegListPropertyTearOff::insertItemBefore): (WebCore::SVGPathSegListPropertyTearOff::replaceItem): (WebCore::SVGPathSegListPropertyTearOff::appendItem): (WebCore::SVGPathSegListPropertyTearOff::SVGPathSegListPropertyTearOff): (WebCore::SVGPathSegListPropertyTearOff::commitChange): (WebCore::SVGPathSegListPropertyTearOff::processIncomingListItemWrapper):

2010-11-19 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Convert SVGPathSeg/SVGPathSegList to the new SVGPropertyTearOff concept
https://bugs.webkit.org/show_bug.cgi?id=49580

Add several new tests covering SVGPathSegList usage.

  • platform/mac/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.checksum: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.png: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt: Added.
  • platform/mac/svg/custom/svg-curve-with-relative-cordinates-expected.txt:
  • platform/mac/svg/dom/SVGPathSegList-appendItem-expected.checksum: Added.
  • platform/mac/svg/dom/SVGPathSegList-appendItem-expected.png: Added.
  • platform/mac/svg/dom/SVGPathSegList-clear-and-initialize-expected.checksum: Added.
  • platform/mac/svg/dom/SVGPathSegList-clear-and-initialize-expected.png: Added.
  • platform/mac/svg/dom/SVGPathSegList-cloning-expected.checksum: Added.
  • platform/mac/svg/dom/SVGPathSegList-cloning-expected.png: Added.
  • platform/mac/svg/dom/SVGPathSegList-cloning-expected.txt: Added.
  • platform/mac/svg/dom/SVGPathSegList-insertItemBefore-expected.checksum: Added.
  • platform/mac/svg/dom/SVGPathSegList-insertItemBefore-expected.png: Added.
  • platform/mac/svg/dom/SVGPathSegList-removeItem-expected.checksum: Added.
  • platform/mac/svg/dom/SVGPathSegList-removeItem-expected.png: Added.
  • platform/mac/svg/dom/SVGPathSegList-replaceItem-expected.checksum: Added.
  • platform/mac/svg/dom/SVGPathSegList-replaceItem-expected.png: Added.
  • platform/mac/svg/dom/SVGPathSegList-segment-modification-expected.checksum: Added.
  • platform/mac/svg/dom/SVGPathSegList-segment-modification-expected.png: Added.
  • platform/mac/svg/dom/SVGPathSegList-segment-modification-expected.txt: Added.
  • platform/mac/svg/dom/SVGPathSegList-xml-dom-synchronization-expected.checksum: Added.
  • platform/mac/svg/dom/SVGPathSegList-xml-dom-synchronization-expected.png: Added.
  • platform/mac/svg/dom/SVGPathSegList-xml-dom-synchronization2-expected.checksum: Added.
  • platform/mac/svg/dom/SVGPathSegList-xml-dom-synchronization2-expected.png: Added.
  • platform/mac/svg/dom/SVGPathSegList-xml-dom-synchronization2-expected.txt: Added.
  • svg/W3C-SVG-1.1-SE/paths-dom-02-f.svg: Added.
  • svg/dom/SVGPathSegList-appendItem-expected.txt: Added.
  • svg/dom/SVGPathSegList-appendItem.xhtml: Added.
  • svg/dom/SVGPathSegList-clear-and-initialize-expected.txt: Added.
  • svg/dom/SVGPathSegList-clear-and-initialize.xhtml: Added.
  • svg/dom/SVGPathSegList-cloning.html: Added.
  • svg/dom/SVGPathSegList-insertItemBefore-expected.txt: Added.
  • svg/dom/SVGPathSegList-insertItemBefore.xhtml: Added.
  • svg/dom/SVGPathSegList-removeItem-expected.txt: Added.
  • svg/dom/SVGPathSegList-removeItem.xhtml: Added.
  • svg/dom/SVGPathSegList-replaceItem-expected.txt: Added.
  • svg/dom/SVGPathSegList-replaceItem.xhtml: Added.
  • svg/dom/SVGPathSegList-segment-modification.svg: Added.
  • svg/dom/SVGPathSegList-xml-dom-synchronization-expected.txt: Added.
  • svg/dom/SVGPathSegList-xml-dom-synchronization.xhtml: Added.
  • svg/dom/SVGPathSegList-xml-dom-synchronization2.xhtml: Added.
  • svg/dom/fuzz-path-parser-expected.txt:
  • svg/dom/path-parser-expected.txt:
  • svg/dom/script-tests/path-parser.js: ():
  • svg/dom/svglist-exception-on-out-bounds-error-expected.txt:
  • svg/dom/svglist-exception-on-out-bounds-error.html:
  • svg/dom/svgpath-out-of-bounds-getPathSeg-expected.txt:
04:42 Changeset [72380] by alex@webkit.org

2010-11-19 Alejandro G. Castro <alex@igalia.com>

Unreviewed, GTK expectations update after r72347

  • platform/gtk/fast/blockflow/japanese-ruby-horizontal-bt-expected.txt:
  • platform/gtk/fast/blockflow/japanese-ruby-vertical-lr-expected.txt:
  • platform/gtk/fast/blockflow/japanese-ruby-vertical-rl-expected.txt:
04:41 Changeset [72379] by pfeldman@chromium.org

2010-11-19 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: one line follow up to r72376.

  • inspector/InspectorResourceAgent.cpp: (WebCore::buildObjectForResourceResponse):
04:32 Changeset [72378] by commit-queue@webkit.org

2010-11-19 Sergio Villar Senin <svillar@igalia.com>

Reviewed by Xan Lopez.

[Gtk] "CRITICAL : msg_got_headers_cb: assertion `entry' failed" when using HTTP cache
https://bugs.webkit.org/show_bug.cgi?id=49666

WebKit resource load cache does validate its own resources by
issuing conditional requests to the server. The HTTP cache was
making the assumption that any possible conditional request was
always generated by itself.

  • platform/network/soup/cache/webkit/soup-cache.c: (webkit_soup_cache_entry_remove): added an assertion (msg_got_headers_cb):
04:13 Changeset [72377] by commit-queue@webkit.org

2010-11-19 Dai Mikurube <dmikurube@google.com>

Reviewed by Kent Tamura.

stepUp/stepDown for values in step-mismatching state for input elements
https://bugs.webkit.org/show_bug.cgi?id=48976

  • fast/forms/input-stepup-stepdown-expected.txt:
  • fast/forms/script-tests/input-stepup-stepdown.js:

2010-11-19 Dai Mikurube <dmikurube@google.com>

Reviewed by Kent Tamura.

stepUp/stepDown for values in step-mismatching state for input elements
https://bugs.webkit.org/show_bug.cgi?id=48976

Fixed stepUp/stepDown behaviors for step-mismatching values to follow the specification of
HTML5 4.10.7.3 Common input element APIs. In details, disabled any stepwise adjustment for
step-mismatching values.

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::applyStep):
03:20 Changeset [72376] by pfeldman@chromium.org

2010-11-19 Pavel Feldman <pfeldman@chromium.org>

Not reviewed. Rolled out build failures introduced in r72373.

  • inspector/CodeGeneratorInspector.pm:
03:14 Changeset [72375] by pfeldman@chromium.org

2010-11-18 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: provide response code and status text as
a part of raw headers data.
https://bugs.webkit.org/show_bug.cgi?id=49668

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/InspectorResourceAgent.cpp: (WebCore::buildObjectForResourceResponse):
  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkDataGridNode.prototype._refreshStatusCell):
  • inspector/front-end/ResourceManager.js: (WebInspector.ResourceManager.prototype._updateResourceWithResponse):
  • platform/network/ResourceLoadInfo.h: Renamed from WebCore/platform/network/ResourceRawHeaders.h. (WebCore::ResourceLoadInfo::ResourceLoadInfo):
  • platform/network/ResourceResponseBase.cpp: (WebCore::ResourceResponseBase::resourceLoadInfo): (WebCore::ResourceResponseBase::setResourceLoadInfo):
  • platform/network/ResourceResponseBase.h:

2010-11-18 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: provide response code and status text as a part
of raw headers data.
https://bugs.webkit.org/show_bug.cgi?id=49668

  • WebKit.gyp:
  • public/WebHTTPLoadInfo.h: Renamed from WebKit/chromium/public/WebResourceRawHeaders.h. (WebKit::WebHTTPLoadInfo::WebHTTPLoadInfo): (WebKit::WebHTTPLoadInfo::~WebHTTPLoadInfo): (WebKit::WebHTTPLoadInfo::operator =):
  • public/WebURLResponse.h:
  • src/WebHTTPLoadInfo.cpp: Renamed from WebKit/chromium/src/WebResourceRawHeaders.cpp. (WebKit::WebHTTPLoadInfo::initialize): (WebKit::WebHTTPLoadInfo::reset): (WebKit::WebHTTPLoadInfo::assign): (WebKit::WebHTTPLoadInfo::WebHTTPLoadInfo): (WebKit::WebHTTPLoadInfo::operator WTF::PassRefPtr<WebCore::ResourceRawHeaders>): (WebKit::WebHTTPLoadInfo::responseCode): (WebKit::WebHTTPLoadInfo::setResponseCode): (WebKit::WebHTTPLoadInfo::statusText): (WebKit::WebHTTPLoadInfo::setStatusText): (WebKit::addHeader): (WebKit::WebHTTPLoadInfo::addRequestHeader): (WebKit::WebHTTPLoadInfo::addResponseHeader):
  • src/WebURLResponse.cpp: (WebKit::WebURLResponse::httpLoadInfo): (WebKit::WebURLResponse::setHTTPLoadInfo):
03:09 Changeset [72374] by commit-queue@webkit.org

2010-11-19 Mike Lawther <mikelawther@chromium.org>

Reviewed by James Robinson.

[skia] assert when attempting to get (but not use) pointer to outside the canvas
https://bugs.webkit.org/show_bug.cgi?id=49698

Removed expectation of failure on Win dbg

  • platform/chromium/test_expectations.txt:

2010-11-19 Mike Lawther <mikelawther@chromium.org>

Reviewed by James Robinson.

[skia] assert when attempting to get (but not use) pointer to outside the canvas
https://bugs.webkit.org/show_bug.cgi?id=49698

Early return to avoid getting a pointer to outside the canvas, and
hence triggering a Skia assert.

  • platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::getImageData):
02:57 Changeset [72373] by loislo@chromium.org

2010-11-18 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: reduce the footprint of InspectorBackendDispatcher.
InspectorBackendDispatcher is a generated file.
Its content is not optimal and loc may be reduced by a quarter.
In each generated function we have a code for getting 'in' values from
the arguments properties object. I've extracted this code into separate getters.
The side effect is better readability of the generated code.

https://bugs.webkit.org/show_bug.cgi?id=49729

  • inspector/CodeGeneratorInspector.pm:
02:54 Changeset [72372] by jparent@chromium.org

2010-11-19 Julie Parent <jparent@chromium.org>

Reviewed by Ojan Vafai.

[Chromium]Several fast/transforms tests need linux specific baselines
https://bugs.webkit.org/show_bug.cgi?id=48788

  • platform/chromium-linux/fast/transforms/transform-on-inline-expected.checksum: Added.
  • platform/chromium-linux/fast/transforms/transform-on-inline-expected.png: Added.
  • platform/chromium-linux/fast/transforms/transform-table-row-expected.checksum: Added.
  • platform/chromium-linux/fast/transforms/transform-table-row-expected.png: Added.
  • platform/chromium-linux/fast/transforms/transformed-document-element-expected.checksum: Added.
  • platform/chromium-linux/fast/transforms/transformed-document-element-expected.png: Added.
  • platform/chromium/test_expectations.txt:
02:31 Changeset [72371] by yael.aharon@nokia.com

2010-11-19 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Antonio Gomes.

[Qt] Focus ring does not show for image maps
https://bugs.webkit.org/show_bug.cgi?id=49615

  • platform/qt/fast/images/imagemap-focus-ring-expected.checksum: Added.
  • platform/qt/fast/images/imagemap-focus-ring-expected.png: Added.
  • platform/qt/fast/images/imagemap-focus-ring-expected.txt: Added.

2010-11-19 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Antonio Gomes.

[Qt] Focus ring does not show for image maps
https://bugs.webkit.org/show_bug.cgi?id=49615

Draw a focus ring for the paths surrounding the focus ring of image map area.
Provide Qt specific results for the test fast/images/imagemap-focus-ring.html.

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::drawFocusRing):
01:35 Changeset [72370] by commit-queue@webkit.org

2010-11-19 Yi Shen <yi.4.shen@nokia.com>

Reviewed by Andreas Kling.

https://bugs.webkit.org/show_bug.cgi?id=49200
[Qt] bugs in Composition mode for QWebPage::inputMethodEvent & inputMethodQuery()

Make QWebPage work as following when editor is in composition mode:

  1. anchor position and cursor position are the same and always >= 0
  2. current selection is always null
  • Api/qwebpage.cpp: (QWebPagePrivate::inputMethodEvent): (QWebPage::inputMethodQuery):
  • tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::inputMethods):
Note: See TracTimeline for information about the timeline view.