Timeline


and

11/29/10:

23:56 Changeset [72894] by sfalken@apple.com
  • 2 edits in trunk/WebKitLibraries

Windows build fix (part 2).
Define Visual Studio internal variables used in pre-build/pre-link/post-build commands in environment for separated cmd files.

  • win/tools/vsprops/common.vsprops:
23:55 Changeset [72893] by sfalken@apple.com
  • 11 edits in trunk/JavaScriptCore

Windows build fix (part 1). Use correct environment variable syntax in cmd files.

23:39 Changeset [72892] by mitz@apple.com
  • 2 edits in trunk/WebKitTools

GTK DumpRenderTree build fix after r72887.

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:

(LayoutTestController::findString):

23:32 Changeset [72891] by mitz@apple.com
  • 2 edits in trunk/WebCore

Build fix for non-ICU platforms after r72887.

  • editing/TextIterator.cpp:

(WebCore::SearchBuffer::prependContext):

23:30 Changeset [72890] by mitz@apple.com
  • 2 edits in trunk/WebKitTools

Windows DumpRenderTree build fix after r72887.

  • DumpRenderTree/win/LayoutTestControllerWin.cpp:

(LayoutTestController::findString): Added empty implementation.

23:25 Changeset [72889] by mitz@apple.com
  • 4 edits in trunk/LayoutTests

Skip editing/text-iterator/findString.html on platforms that do not have an implementation of
layoutTestController.findString()

  • platform/gtk/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
23:08 Changeset [72888] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2010-11-29 MORITA Hajime <morrita@google.com>

Unreviewed, updated expectations (unskip some passing tests).

  • platform/chromium/test_expectations.txt:
22:39 Changeset [72887] by mitz@apple.com
  • 44 edits
    1 move
    3 adds in trunk

JavaScriptCore: WTF support for <rdar://problem/8650085> adding word-prefix search options to the text search API.
https://bugs.webkit.org/show_bug.cgi?id=50038

Reviewed by Darin Adler.

  • wtf/unicode/UnicodeMacrosFromICU.h: Copied additional macros from icu/unicode/utf16.h.

WebCore: WebCore part of <rdar://problem/8650085> adding word-prefix search options to the text search API.
https://bugs.webkit.org/show_bug.cgi?id=50038

Reviewed by Darin Adler.

Test: editing/text-iterator/findString.html

  • GNUmakefile.am: Added FindOptions.h.
  • WebCore.exp.in: Export the new methods that take FindOptions.
  • WebCore.gypi: Added FindOptions.h.
  • WebCore.pro: Added FindOptions.h and TextBoundaries.{cpp,h}.
  • WebCore.vcproj/WebCore.vcproj: Added FindOptions.h.
  • WebCore.xcodeproj/project.pbxproj: Added FindOptions.h and TextBoundaries.cpp.
  • editing/Editor.cpp:

(WebCore::Editor::firstVisibleRange): Changed to use FindOptions.
(WebCore::Editor::lastVisibleRange): Ditto.
(WebCore::Editor::nextVisibleRange): Ditto.
(WebCore::Editor::findString): Ditto.
(WebCore::Editor::countMatchesForText): Ditto.

  • editing/Editor.h: Added a version of findString() that takes FindOptions. Changed

countMatchesForText() to take FindOptions. Made nextVisibleRange() private and changed it
and firstVisibleRange() and lastVisibleRange() to take FindOptions.

  • editing/FindOptions.h: Added.
  • editing/TextIterator.cpp:

Augmented SearchBuffer with an optional prefix, which is not searched, but provides context
for determining word boundaries.
(WebCore::isSeparator): Added. Identifies a class of characters used to determine where
“words” are embedded in a word.
(WebCore::SearchBuffer::SearchBuffer): Changed to take FindOptions. Added initialization of
m_options, m_prefixLength and m_needsMoreContext.
(WebCore::SearchBuffer::append): Adjust m_prefixLength as part of the prefix gets pushed out
of the buffer.
(WebCore::SearchBuffer::needsMoreContext): Added.
(WebCore::SearchBuffer::prependContext): Added.
(WebCore::SearchBuffer::isWordStartMatch): Added.
(WebCore::SearchBuffer::search): Changed to account for the context prefix. When searching
only for word prefix matches, maintains enough context before a tentative match when moving
it to the beginning of the buffer. Reject matches that are not at word starts if requested.
Adjust m_prefixLength when pushing characters out of the buffer.
(WebCore::findPlainText): Changed to work with FindOptions. Feed the search buffer with context
if and as long as it requires more of it.

  • editing/TextIterator.h: Added a version of findPlainText() that takes FindOptions.
  • editing/visible_units.cpp: Moved {end,start}Of{First,Last}WordBoundary to TextBoundaries.cpp.
  • page/Page.cpp:

(WebCore::Page::findString): Changed to work with FindOptions.
(WebCore::Page::markAllMatchesForText): Ditto.

  • page/Page.h: Added FindOptions-based findString() and markAllMatchesForText().
  • platform/text/TextBoundaries.cpp:

(WebCore::endOfFirstWordBoundaryContext): Moved here from visible_units.cpp.
(WebCore::startOfLastWordBoundaryContext): Ditto.

  • platform/text/TextBoundaries.h:

WebKit/mac: WebKit Mac part of <rdar://problem/8650085> adding word-prefix search options to the text search API.
https://bugs.webkit.org/show_bug.cgi?id=50038
Based on a patch from Darin Adler.

Reviewed by Darin Adler.

  • WebView/WebDocumentInternal.h: Removed -markAllMatchesForText:caseSensitive:limit: and

replaced -countMatchesForText:caseSensitive:limit:markMatches: with a WebFindOptions-based
method. Declared a WebDocumentOptionsSearching protocol with a new -findString:options:
method. Made WebHTMLView conform to the new protocol.

  • WebView/WebHTMLView.mm:

(coreOptions): Added. Converts WebFindOptions to WebCore FindOptions.
(-[WebHTMLView searchFor:direction:caseSensitive:wrap:startInSelection:]): Changed to use
-findString:options:.
(-[WebHTMLView countMatchesForText:options:limit:markMatches:]): Changed to use WebFindOptions.
(-[WebHTMLView findString:options:]): Added. Calls through to WebCore::Editor::findString().

  • WebView/WebPDFView.mm:

(-[WebPDFView countMatchesForText:options:limit:markMatches:]): Changed to use WebFindOptions.

  • WebView/WebView.mm:

(-[WebView markAllMatchesForText:caseSensitive:highlight:limit:]): Now calls through to
-countMatchesForText:options:highlight:limit:markMatches.
(-[WebView countMatchesForText:caseSensitive:highlight:limit:markMatches:]): Ditto.
(-[WebView searchFor:direction:caseSensitive:wrap:startInSelection:]): Now calls through to
-findString:options:.
(incrementFrame): Changed to use WebFindOptions.
(findString): Added this helper method that performs the search using the best supported
method for the document view.
(-[WebView findString:options:]): Changed -searchFor::::: into this.
(-[WebView canMarkAllTextMatches]):
(-[WebView countMatchesForText:options:highlight:limit:markMatches:]): Updated to use
WebFindOptions.
(-[WebView unmarkAllTextMatches]): Updated for change to incrementFrame.
(-[WebView rectsForTextMatches]): Ditto.

  • WebView/WebViewPrivate.h: Added WebFindOptions, -findString:options:, and WebFindOptions version

of countMatchesForText:.

WebKit2: WebKit2 part of <rdar://problem/8650085> adding word-prefix search options to the text search API.
https://bugs.webkit.org/show_bug.cgi?id=50038
Based on a patch from Darin Adler.

Reviewed by Darin Adler.

  • Shared/WebFindOptions.h: Renamed FindOptions.h to this to account for WebCore’s new private

FindOptions.h. Added and reordered FindOptions and rolled FindDirection into FindOptions.

  • UIProcess/API/C/WKAPICast.h: Removed toFindDirection().

(WebKit::toFindOptions): Updated for new values.

  • UIProcess/API/C/WKPage.cpp:

(WKPageFindString): Removed separate WKFindDirection.
(WKPageCountStringMatches): Replaces caseInsensitive boolean with WKFindOptions.

  • UIProcess/API/C/WKPage.h: Removed WKFindDirection and updated WKFindOptions.
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::findString): Removed separate FindDirection.
(WebKit::WebPageProxy::countStringMatches): Replaced caseInsensitive boolean with FindOptions.

  • UIProcess/WebPageProxy.h:
  • WebKit2.xcodeproj/project.pbxproj: Updated for the header rename.
  • WebProcess/WebPage/FindController.cpp:

(WebKit::core): Added. Converts WebKit2 FindOptions to WebCore FindOptions.
(WebKit::FindController::countStringMatches): Changed to use FindOptions.
(WebKit::FindController::findString): Ditto.

  • WebProcess/WebPage/FindController.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::findString): Ditto.
(WebKit::WebPage::countStringMatches): Ditto.

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in: Ditto.

WebKitTools: DumpRenderTree changes for testing the text search API.
https://bugs.webkit.org/show_bug.cgi?id=50038

Reviewed by Darin Adler.

  • DumpRenderTree/LayoutTestController.cpp:

(findStringCallback):
(LayoutTestController::staticFunctions):

  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/mac/LayoutTestControllerMac.mm:

(LayoutTestController::findString):

  • MiniBrowser/mac/BrowserWindowController.m:

(-[BrowserWindowController find:]):

LayoutTests: Added text search tests, in particular testing word-prefix search.
https://bugs.webkit.org/show_bug.cgi?id=50038

Reviewed by Darin Adler.

  • editing/text-iterator/findString-expected.txt: Added.
  • editing/text-iterator/findString.html: Added.
22:28 Changeset [72886] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

2010-11-29 Ojan Vafai <ojan@chromium.org>

[chromium] Fix expectations for fast/block/basic/truncation-rtl.html

  • platform/chromium/test_expectations.txt:
22:14 Changeset [72885] by sfalken@apple.com
  • 6 edits
    9 adds in trunk/JavaScriptCore

2010-11-29 Steve Falkenburg <sfalken@apple.com>

Reviewed by Darin Adler.

JavaScriptCore projects on Windows should use cmd files for build events
https://bugs.webkit.org/show_bug.cgi?id=50193

22:11 Changeset [72884] by commit-queue@webkit.org
  • 21 edits
    4 adds in trunk

2010-11-29 Dai Mikurube <dmikurube@google.com>

Reviewed by Kent Tamura.

when empty, clicking "down" on outer-spin-button returns "max value"
https://bugs.webkit.org/show_bug.cgi?id=45491

It is required to calculate UTC/DST offsets to retrieve the current local milliseconds for
date/time type inputs. WTF::currentTimeMS() returns a UTC time, and WTF::getLocalTime()
returns a struct tm, not milliseconds.

Calculating milliseconds from a struct tm is not simple since timegm() cannot be used in all
environments. This calculation is already done in calculateUTCOffset(), and complicated.
Duplicating this complicated calculation is unreasonable because of maintainability.
To achieve this without duplication, we must call calculate{UTC|DST}Offset in some way.

  • JavaScriptCore.exp:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • wtf/DateMath.cpp: Changed calculateUTCOffset() and calculateDSTOffset() to external functions. (WTF::calculateUTCOffset): (WTF::calculateDSTOffset):
  • wtf/DateMath.h:

2010-11-29 Dai Mikurube <dmikurube@google.com>

Reviewed by Kent Tamura.

when empty, clicking "down" on outer-spin-button returns "max value"
https://bugs.webkit.org/show_bug.cgi?id=45491

  • fast/forms/input-stepup-stepdown-from-renderer-expected.txt: Added.
  • fast/forms/input-stepup-stepdown-from-renderer.html: Added.
  • fast/forms/script-tests/input-stepup-stepdown-from-renderer.js: Added. (): (setInputAttributes): (stepUp): (stepDown): (stepUpExplicitBounds): (stepDownExplicitBounds):

2010-11-29 Dai Mikurube <dmikurube@google.com>

Reviewed by Kent Tamura.

when empty, clicking "down" on outer-spin-button returns "max value"
https://bugs.webkit.org/show_bug.cgi?id=45491

Modified stepping-up/down from renderer

  • to clamp steps,
  • to handle empty values (described below), and
  • to apply them for range type inputs.

Stepping-up/down for empty values are handled "the empty as 0."
For example :

  • If 0 is in-range, and matches to step value "down" -> -step "up" -> +step If -step or +step is out of range, new value should be 0.
  • If 0 is smaller than the minimum value "down" -> the minimum value "up" -> the minimum value
  • If 0 is larger than the maximum value "down" -> the maximum value "up" -> the maximum value
  • If 0 is in-range, but not matched to step value "down" -> smaler matched value nearest to 0.

e.g. <input type=number min=-100 step=3> -> -1

"up" -> larger matched value nearest to 0.

e.g. <input type=number min=-100 step=3> -> 2

As for date/datetime-local/month/time/week types, the empty is assumed as "current local date/time".
As for datetime type, the empty is assumed as "current date/time in UTC".

As for range input types, changed stepping from renderer to use stepUpFromRenderer().
It was calculated with stepUp() from RangeInputType::handleKeydownEvent().

Test: fast/forms/input-stepup-stepdown-from-renderer.html

  • html/BaseDateAndTimeInputType.cpp: (WebCore::BaseDateAndTimeInputType::defaultValueForStepUp): Added defaultValueForStepUp() which returns the current local time
  • html/BaseDateAndTimeInputType.h:
  • html/DateTimeInputType.cpp: (WebCore::DateTimeInputType::defaultValueForStepUp): Added defaultValueForStepUp() which returns the current UTC time
  • html/DateTimeInputType.h:
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::stepUpFromRenderer): Modified it to clamp steps, support empty values and support range type inputs
  • html/HTMLInputElement.h: (WebCore::HTMLInputElement::isRangeControl):
  • html/InputType.cpp: (WebCore::InputType::defaultValueForStepUp): Added defaultValueForStepUp() which returns 0
  • html/InputType.h:
  • html/MonthInputType.cpp: (WebCore::MonthInputType::defaultValueForStepUp): Added defaultValueForStepUp() which returns the current local month
  • html/MonthInputType.h:
  • html/RangeInputType.cpp: (WebCore::RangeInputType::handleKeydownEvent): Added comments and modified it to use stepUpFromRenderer()
  • html/TimeInputType.cpp: (WebCore::TimeInputType::defaultValueForStepUp): Added defaultValueForStepUp() which returns the current local time
  • html/TimeInputType.h:
  • manual-tests/input-type-datetime-default-value.html: Added manual tests for default values of date/time inputs since they are "the current local/UTC time", which cannot be tested automatically.
21:40 Changeset [72883] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

2010-11-29 Ojan Vafai <ojan@chromium.org>

Update listing for spatial nav tests after they were moved
in http://trac.webkit.org/changeset/72880/.

  • platform/chromium/test_expectations.txt:
21:21 Changeset [72882] by kinuko@chromium.org
  • 5 edits
    1 delete in trunk/LayoutTests

2010-11-24 Kinuko Yasuda <kinuko@chromium.org>

Unreviewed; updating test expectations.

  • fast/filesystem/async-operations-expected.txt:
  • fast/filesystem/read-directory-expected.txt:
  • fast/filesystem/simple-persistent-expected.txt:
  • fast/filesystem/simple-temporary-expected.txt:
  • platform/chromium-linux/fast/filesystem/async-operations-expected.txt: Removed.
21:14 Changeset [72881] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

2010-11-29 Ojan Vafai <ojan@chromium.org>

[chromium] Hopefully final modification to text_expectations to green chromium bots.

  • platform/chromium/test_expectations.txt:
21:09 Changeset [72880] by tonikitoo@webkit.org
  • 4 edits
    59 moves
    2 adds in trunk/LayoutTests

2010-11-28 Antonio Gomes <agomes@rim.com>

Reviewed by Kenneth Rohde Christiansen.

Spatial navigation: move tests to its own feature directory
https://bugs.webkit.org/show_bug.cgi?id=50133

Patch basically moves all spatial navigation tests out of the fast/events folder,
putting them all under /fast/spatial-navigation.

Some needed changes in some tests and Skipped files were also made, but there is not
any content changes in the tests.

  • fast/events/spatial-navigation: Moved to fast/spatial-navigation
  • platform/mac-wk2/Skipped:
  • platform/qt-wk2/Skipped:
  • platform/win/Skipped:
21:06 Changeset [72879] by ojan@chromium.org
  • 1 edit
    20 adds in trunk/LayoutTests

2010-11-29 Ojan Vafai <ojan@chromium.org>

[chromium] Rebaseline results after http://trac.webkit.org/changeset/72802/.
The only differences are in the scrollbars.
The original patch included the chromium-linux results in addition to the
platform/mac results.

  • platform/chromium-mac/svg/custom/svg-parse-overflow-1-expected.checksum: Added.
  • platform/chromium-mac/svg/custom/svg-parse-overflow-1-expected.png: Added.
  • platform/chromium-mac/svg/custom/svg-parse-overflow-2-expected.checksum: Added.
  • platform/chromium-mac/svg/custom/svg-parse-overflow-2-expected.png: Added.
  • platform/chromium-mac/svg/custom/svg-parse-overflow-3-expected.checksum: Added.
  • platform/chromium-mac/svg/custom/svg-parse-overflow-3-expected.png: Added.
  • platform/chromium-mac/svg/custom/svg-parse-overflow-4-expected.checksum: Added.
  • platform/chromium-mac/svg/custom/svg-parse-overflow-4-expected.png: Added.
  • platform/chromium-mac/svg/custom/svg-parse-overflow-5-expected.checksum: Added.
  • platform/chromium-mac/svg/custom/svg-parse-overflow-5-expected.png: Added.
  • platform/chromium-win/svg/custom/svg-parse-overflow-1-expected.checksum: Added.
  • platform/chromium-win/svg/custom/svg-parse-overflow-1-expected.png: Added.
  • platform/chromium-win/svg/custom/svg-parse-overflow-2-expected.checksum: Added.
  • platform/chromium-win/svg/custom/svg-parse-overflow-2-expected.png: Added.
  • platform/chromium-win/svg/custom/svg-parse-overflow-3-expected.checksum: Added.
  • platform/chromium-win/svg/custom/svg-parse-overflow-3-expected.png: Added.
  • platform/chromium-win/svg/custom/svg-parse-overflow-4-expected.checksum: Added.
  • platform/chromium-win/svg/custom/svg-parse-overflow-4-expected.png: Added.
  • platform/chromium-win/svg/custom/svg-parse-overflow-5-expected.checksum: Added.
  • platform/chromium-win/svg/custom/svg-parse-overflow-5-expected.png: Added.
21:01 Changeset [72878] by rniwa@webkit.org
  • 1 edit
    1 delete in trunk/LayoutTests

2010-11-29 Ryosuke Niwa <rniwa@webkit.org>

More unreviewed rebaseline for r72861.

  • platform/chromium-linux/editing/selection/home-end-expected.txt: Removed.
20:53 Changeset [72877] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

2010-11-29 Ojan Vafai <ojan@chromium.org>

[chromium] Some more expectations updates to green chromium bots.

  • platform/chromium/test_expectations.txt:
20:48 Changeset [72876] by abarth@webkit.org
  • 8 edits in trunk

2010-11-29 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Introduce the notion of a "display-isolated" URL scheme for use by Chrome-internal URLs
https://bugs.webkit.org/show_bug.cgi?id=50182

A display-isolated URL can only be displayed (e.g., put in an iframe,
hyperlinked to) by documents from that scheme. In a sense, this is a
generalization of some of the protections we give file URLs, but
instead of lumping them all together into one "local" bucket, this
patch creates a separate bucket for each scheme.

For a while, I tried using a separate bucket for each origin. That
would have played nicely with what Blob URLs are trying to do, but some
"chrome" URL pages rely on being able to display other chrome URL
pages, even in different origins. For example, the New Tab Page shows
thumbnails from the "thumbnail" host.

This patch also removes a bunch of unused code. I've also propagated
the "deprecated" status of deprecatedCanDisplay to
deprecatedShouldTreatURLAsLocal because that method has no other
callers and is really asking for uppercase/lowercase bugs. I dream of
someday removing these functions.

  • page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::canDisplay): (WebCore::SecurityOrigin::deprecatedCanDisplay):
  • platform/SchemeRegistry.cpp: (WebCore::displayIsolatedURLSchemes): (WebCore::SchemeRegistry::registerURLSchemeAsLocal): (WebCore::SchemeRegistry::deprecatedShouldTreatURLAsLocal): (WebCore::SchemeRegistry::shouldTreatURLSchemeAsLocal): (WebCore::SchemeRegistry::registerURLSchemeAsDisplayIsolated): (WebCore::SchemeRegistry::shouldTreatURLSchemeAsDisplayIsolated):
  • platform/SchemeRegistry.h:

2010-11-29 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Introduce the notion of a "display-isolated" URL scheme for use by Chrome-internal URLs
https://bugs.webkit.org/show_bug.cgi?id=50182

This patch adds a Chromium API for registering schemes as
display-isolated. In a subsequent patch, I'll change the "chrome"
scheme in Chrome to be display isolated instead of local. That will
prevent file URLs from linking to chrome URLs.

  • public/WebSecurityPolicy.h:
  • src/WebSecurityPolicy.cpp: (WebKit::WebSecurityPolicy::registerURLSchemeAsDisplayIsolated):
20:37 Changeset [72875] by xji@chromium.org
  • 6 edits in trunk/LayoutTests

2010-11-29 Xiaomei Ji <xji@chromium.org>

Unreviewed rebaseline for Chromium after r72852.

  • platform/chromium-linux/fast/block/basic/truncation-rtl-expected.checksum:
  • platform/chromium-linux/fast/block/basic/truncation-rtl-expected.png:
  • platform/chromium-win/fast/block/basic/truncation-rtl-expected.checksum:
  • platform/chromium-win/fast/block/basic/truncation-rtl-expected.png:
  • platform/chromium-win/fast/block/basic/truncation-rtl-expected.txt:
20:31 Changeset [72874] by rniwa@webkit.org
  • 9 edits in trunk/LayoutTests

2010-11-29 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed rebaseline for r72861. Also disabled editing/selection/click-left-of-rtl-wrapping-text.html and
editing/selection/modify-up-on-rtl-wrapping-text.html on Gtk, Qt, Windows, Chromium Windows and Chromium Linux.

  • editing/selection/extend-selection-home-end-expected.txt:
  • platform/chromium-win/editing/selection/extend-selection-home-end-expected.txt:
  • platform/chromium-win/editing/selection/home-end-expected.txt:
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • platform/win/editing/selection/extend-selection-home-end-expected.txt:
20:29 Changeset [72873] by chang.shu@nokia.com
  • 1 edit
    3 moves in trunk/LayoutTests

2010-11-29 Chang Shu <chang.shu@nokia.com>

Reviewed by Laszlo Gombos.

Fix the typo in the test case to make it work when ORIENTATION_EVENTS is enabled.
https://bugs.webkit.org/show_bug.cgi?id=50171

  • fast/dom/DeviceOrientation/create-event-onorientationchange-expected.txt: Removed.
  • fast/dom/DeviceOrientation/create-event-onorientationchange.html: Removed.
  • fast/dom/DeviceOrientation/create-event-orientationchange-expected.txt: Copied from LayoutTests/fast/dom/DeviceOrientation/create-event-onorientationchange-expected.txt.
  • fast/dom/DeviceOrientation/create-event-orientationchange.html: Copied from LayoutTests/fast/dom/DeviceOrientation/create-event-onorientationchange.html.
  • fast/dom/DeviceOrientation/script-tests/create-event-onorientationchange.js: Removed.
  • fast/dom/DeviceOrientation/script-tests/create-event-orientationchange.js: Copied from LayoutTests/fast/dom/DeviceOrientation/script-tests/create-event-onorientationchange.js.
20:26 Changeset [72872] by xji@chromium.org
  • 2 edits in trunk/LayoutTests

2010-11-29 Xiaomei Ji <xji@chromium.org>

Unreviewed fix typo.

  • platform/chromium/test_expectations.txt:
20:19 Changeset [72871] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

2010-11-29 Ojan Vafai <ojan@chromium.org>

[Chromium] Reflection tests are now fixed. Remove from test_expectations.

  • platform/chromium/test_expectations.txt:
20:12 Changeset [72870] by commit-queue@webkit.org
  • 3 edits in trunk/WebCore

2010-11-29 Sergio Villar Senin <svillar@igalia.com>

Reviewed by Martin Robinson.

[GTK] Leaks in SoupCache code
https://bugs.webkit.org/show_bug.cgi?id=50161

Fixes some memory leaks in SoupCache code.

  • platform/network/soup/cache/soup-http-input-stream.c: (send_async_finished): Added a missing g_object_unref.
  • platform/network/soup/cache/webkit/soup-cache.c: (get_cacheability): Added soup_header_free_param_list. (webkit_soup_cache_entry_set_freshness): Ditto. (webkit_soup_cache_send_response): Ditto. (webkit_soup_cache_has_response): Ditto.
20:11 Changeset [72869] by xji@chromium.org
  • 3 edits in trunk/LayoutTests

2010-11-29 Xiaomei Ji <xji@chromium.org>

Unreviewed.

Temporarily skip fast/dom/horizontal-scrollbar-in-rtl.html and fast/dom/horizontal-scrollbar-when-dir-change.html due to bug 50203 (after r72852).

  • platform/chromium/test_expectations.txt:
  • platform/win/Skipped:
19:34 Changeset [72868] by jnd@chromium.org
  • 2 edits in trunk/WebKitTools

2010-11-29 Johnny Ding <jnd@chromium.org>

Unreviewed: Add myself to the list of Committers.

  • Scripts/webkitpy/common/config/committers.py:
19:28 Changeset [72867] by xji@chromium.org
  • 1 edit
    3 adds in trunk/LayoutTests

2010-11-29 Xiaomei Ji <xji@chromium.org>

Unreviewed rebaseline for Win7 after r72852.

  • platform/win/fast/block: Added.
  • platform/win/fast/block/basic: Added.
  • platform/win/fast/block/basic/truncation-rtl-expected.txt: Added.
19:20 Changeset [72866] by jianli@chromium.org
  • 8 edits
    3 adds in trunk

Add send(ArrayBuffer) to XMLHttpRequest per XMLHttpRequest Level 2 spec
https://bugs.webkit.org/show_bug.cgi?id=50199

Reviewed by David Levin.

WebCore:

Test: http/tests/xmlhttprequest/send-array-buffer.html

  • bindings/js/JSXMLHttpRequestCustom.cpp:

(WebCore::JSXMLHttpRequest::send):

  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp:

(WebCore::V8XMLHttpRequest::sendCallback):

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::send):

  • xml/XMLHttpRequest.h:

LayoutTests:

  • http/tests/xmlhttprequest/resources/post-echo-as-ascii.cgi: Added.
  • http/tests/xmlhttprequest/send-array-buffer-expected.txt: Added.
  • http/tests/xmlhttprequest/send-array-buffer.html: Added.
  • platform/gtk/Skipped:
  • platform/qt/Skipped:
19:16 Changeset [72865] by xji@chromium.org
  • 3 edits in trunk/LayoutTests

2010-11-29 Xiaomei Ji <xji@chromium.org>

Unreviewed.

Skip fast/dom/tab-in-right-alignment.html for GTK and Win due to
unimplemented textInputController (after r72847).

  • platform/gtk/Skipped:
  • platform/win/Skipped:
19:11 Changeset [72864] by jamesr@google.com
  • 5 edits
    15 deletes in trunk

2010-11-29 James Robinson <jamesr@chromium.org>

[chromium] REGRESSION(72470): Crash in skia on some images
https://bugs.webkit.org/show_bug.cgi?id=50201

Reverts r72470

  • platform/chromium-linux/svg/custom/image-rescale-expected.checksum: Removed.
  • platform/chromium-linux/svg/custom/image-rescale-expected.png: Removed.
  • platform/chromium-linux/svg/custom/image-rescale-expected.txt: Removed.
  • platform/chromium-linux/svg/custom/image-rescale-scroll-expected.checksum: Removed.
  • platform/chromium-linux/svg/custom/image-rescale-scroll-expected.png: Removed.
  • platform/chromium-linux/svg/custom/image-rescale-scroll-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
  • platform/mac/svg/custom/image-rescale-expected.checksum: Removed.
  • platform/mac/svg/custom/image-rescale-expected.png: Removed.
  • platform/mac/svg/custom/image-rescale-expected.txt: Removed.
  • platform/mac/svg/custom/image-rescale-scroll-expected.checksum: Removed.
  • platform/mac/svg/custom/image-rescale-scroll-expected.png: Removed.
  • platform/mac/svg/custom/image-rescale-scroll-expected.txt: Removed.
  • platform/mac/test_expectations.txt:
  • svg/custom/image-rescale-scroll.html: Removed.
  • svg/custom/image-rescale.svg: Removed.
  • svg/custom/resources/image-rescale.jpg: Removed.

2010-11-29 James Robinson <jamesr@chromium.org>

[chromium] REGRESSION(72470): Crash in skia on some images
https://bugs.webkit.org/show_bug.cgi?id=50201

Reverts r72470

  • platform/graphics/skia/ImageSkia.cpp: (WebCore::computeResamplingMode): (WebCore::drawResampledBitmap):
19:06 Changeset [72863] by dimich@chromium.org
  • 2 edits in trunk/WebCore

Crash when iframe transfers from one page to another and has child frames.
https://bugs.webkit.org/show_bug.cgi?id=50200

Reviewed by David Levin.

  • page/Frame.cpp:

(WebCore::Frame::transferChildFrameToNewDocument):
avoid overriding 'didTransfer' which has the result of previous check.

19:00 Changeset [72862] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2010-11-29 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed reabseline for r72852.

  • platform/gtk/fast/block/basic/truncation-rtl-expected.txt:
18:54 Changeset [72861] by rniwa@webkit.org
  • 9 edits
    4 adds in trunk

2010-11-19 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by David Hyatt.

up arrow doesn't work with RTL text with word wrapping
https://bugs.webkit.org/show_bug.cgi?id=41987

The bug was caused by positionForPoint's not returning the correct affinity when the x coordiate
is to the left of the first line, and startOfLine's incorrectly moving position to the previous candidate.

Fixed the bug by returning upstream VisiblePosition in positionForPoint if the first inline text box's offset
is greater than 0. Also removed the code added by http://trac.webkit.org/changeset/23608 since this changeset
does not add any test, and the problem described in the changelog reproduces regardless of the code's presence.

Tests: editing/selection/click-left-of-rtl-wrapping-text.html

editing/selection/modify-up-on-rtl-wrapping-text.html

  • editing/visible_units.cpp: (WebCore::startOfLine):
  • rendering/RenderText.cpp: (WebCore::RenderText::positionForPoint):

2010-11-29 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by David Hyatt.

up arrow doesn't work with RTL text with word wrapping
https://bugs.webkit.org/show_bug.cgi?id=41987

Added tests to ensure WebKit places caret at the right position in soft-wrapping RTL text when clicking
to the left of RTL text or when moving upwards at the end of line.

  • editing/selection/click-left-of-rtl-wrapping-text-expected.txt: Added.
  • editing/selection/click-left-of-rtl-wrapping-text.html: Added.
  • editing/selection/home-end-expected.txt: RTL's expected result now matches LTR's.
  • editing/selection/modify-up-on-rtl-wrapping-text-expected.txt: Added.
  • editing/selection/modify-up-on-rtl-wrapping-text.html: Added.
  • platform/chromium-win/editing/selection/extend-selection-home-end-expected.txt: RTL's expected result now matches LTR's.
  • platform/gtk/editing/selection/extend-selection-home-end-expected.txt: Ditto.
  • platform/mac/editing/selection/extend-selection-home-end-expected.txt: Ditto.
  • platform/win/editing/selection/extend-selection-home-end-expected.txt: Ditto.
18:34 Changeset [72860] by commit-queue@webkit.org
  • 3 edits
    1 add in trunk/WebCore

2010-11-29 Ilya Sherman <isherman@chromium.org>

Reviewed by Kent Tamura.

Ensure that option elements are rendered with normal font weight on Windows/Linux
https://bugs.webkit.org/show_bug.cgi?id=50055

  • WebCore.gyp/WebCore.gyp: include themeChromiumSkia.css
  • css/themeChromiumSkia.css: Added. (option): font-weight: normal !important;
  • rendering/RenderThemeChromiumSkia.cpp: (WebCore::RenderThemeChromiumSkia::extraDefaultStyleSheet): include themeChromiumSkia.css
18:07 Changeset [72859] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

<rdar://problem/8694997> DumpRenderTree fails to build.

Reviewed by Adele Peterson.

  • DumpRenderTree/mac/PerlSupport/Makefile: Skip generating wrappers.
18:06 Changeset [72858] by mrowe@apple.com
  • 2 edits
    2 moves in trunk/WebKitTools

<rdar://problem/8694997> DumpRenderTree fails to build.

Reviewed by Adele Peterson.

  • DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupportPregenerated.pm: Renamed from WebKitTools/DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupportTiger.pm.
  • DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport_wrapPregenerated.c: Renamed from WebKitTools/DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport_wrapTiger.c.
  • DumpRenderTree/mac/PerlSupport/Makefile:
17:55 Changeset [72857] by bfulgham@webkit.org
  • 2 edits in trunk/WebKit2

Unreviewed build fix.

  • win/WebKit2.vcproj: Add missing vsprops association for

Debug_Cairo_CFLite target.

17:51 Changeset [72856] by bfulgham@webkit.org
  • 2 edits in trunk/WebKit/win

Unreviewed build correction.

  • WebKit.vcproj/WebKit.vcproj: Update WebKit project to use WinCairo.vsprops definition for appropriate build targets.
17:41 Changeset [72855] by bfulgham@webkit.org
  • 3 edits in trunk/WebCore

Unreviewed build fix.

  • WebCore.vcproj/WebCoreCairo.vsprops: Provide missing WIN_CAIRO definition so that proper targets are build.
  • platform/graphics/win/cairo/FontPlatformData.h:

(WebCore::FontPlatformData::orientation): Add missing implementation.

17:40 Changeset [72854] by xji@chromium.org
  • 2 edits in trunk/LayoutTests

2010-11-29 Xiaomei Ji <xji@chromium.org>

Reviewed by NOBODY.

Rebaseline truncation-rtl-expected.txt after http://trac.webkit.org/changeset/72852

  • platform/qt/fast/block/basic/truncation-rtl-expected.txt:
17:18 Changeset [72853] by crogers@google.com
  • 8 edits
    1 delete in trunk

2010-11-29 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

Switch web audio code to use FloatPoint3D instead of Vector3
https://bugs.webkit.org/show_bug.cgi?id=50186

  • wtf/Vector3.h: Removed.

2010-11-29 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

Switch web audio code to use FloatPoint3D instead of Vector3
https://bugs.webkit.org/show_bug.cgi?id=50186

No new tests since audio API is not yet implemented.

  • platform/audio/Cone.cpp: (WebCore::ConeEffect::gain):
  • platform/audio/Cone.h:
  • platform/graphics/FloatPoint3D.h: (WebCore::FloatPoint3D::isZero): (WebCore::operator*): (WebCore::FloatPoint3D::distanceTo):
  • webaudio/AudioListener.h: (WebCore::AudioListener::setPosition): (WebCore::AudioListener::position): (WebCore::AudioListener::setOrientation): (WebCore::AudioListener::orientation): (WebCore::AudioListener::setUpVector): (WebCore::AudioListener::upVector): (WebCore::AudioListener::setVelocity): (WebCore::AudioListener::velocity):
  • webaudio/AudioPannerNode.cpp: (WebCore::AudioPannerNode::AudioPannerNode): (WebCore::AudioPannerNode::getAzimuthElevation): (WebCore::AudioPannerNode::dopplerRate): (WebCore::AudioPannerNode::distanceConeGain):
  • webaudio/AudioPannerNode.h: (WebCore::AudioPannerNode::position): (WebCore::AudioPannerNode::setPosition): (WebCore::AudioPannerNode::orientation): (WebCore::AudioPannerNode::setOrientation): (WebCore::AudioPannerNode::velocity): (WebCore::AudioPannerNode::setVelocity):
17:11 Changeset [72852] by xji@chromium.org
  • 17 edits
    12 adds in trunk

2010-11-29 Jeremy Moskovich <jeremy@chromium.org>

Reviewed by David Hyatt.

Right-to-left pages should be scrollable to reveal left overflow.
https://bugs.webkit.org/show_bug.cgi?id=23556

Set and get the original x-axis scroll position and reset scroll position on HOME/END key press.
Modify WebFrameView to support setting the initial horizontal scroller's thumb position to the right for
pages with a left overflow.

  • WebView/WebDynamicScrollBarsView.h:
  • WebView/WebDynamicScrollBarsView.mm: (-[WebDynamicScrollBarsView inProgramaticScroll]): (-[WebDynamicScrollBarsView refreshInitialScrollbarPosition]): (-[WebDynamicScrollBarsView updateScrollers]): (-[WebDynamicScrollBarsView reflectScrolledClipView:]): (-[WebDynamicScrollBarsView setScrollOriginX:]): (-[WebDynamicScrollBarsView scrollOriginX]):
  • WebView/WebFrameView.mm: (-[WebFrameView _scrollToBeginningOfDocument]): (-[WebFrameView _scrollToEndOfDocument]):
  • WebView/WebHTMLView.mm: (-[WebHTMLView _frameOrBoundsChanged]):

2010-11-29 Xiaomei Ji <xji@chromium.org>

Reviewed by David Hyatt.

Right-to-left pages should be scrollable to reveal left overflow.
https://bugs.webkit.org/show_bug.cgi?id=23556

For RTL page, save left layout overflow and include it into the document
size during layout. Use the left layout overflow when scroll and paint
the page. Behavior on LTR page should be untouched since left layout
overflow is set as 0 for LTR page.

Tests: fast/dom/horizontal-scrollbar-in-rtl-doesnt-fire-onscroll.html

fast/dom/horizontal-scrollbar-in-rtl.html
fast/dom/horizontal-scrollbar-when-dir-change.html
fast/dom/left-overflow-in-ltr.html
fast/dom/right-overflow-in-rtl.html

  • page/FrameView.cpp: (WebCore::FrameView::adjustViewSize): Save negative of left layout overflow as scroll X origin. And includes left layout overflow into document size.
  • page/mac/WebCoreFrameView.h: Add methods for setting and getting scroll X origin.
  • platform/ScrollView.cpp: (WebCore::ScrollView::ScrollView): (WebCore::ScrollView::maximumScrollPosition): Minus scroll X origin from maximum horizontal scroll position. (WebCore::ScrollView::minimumScrollPosition): (WebCore::ScrollView::adjustScrollPositionWithinRange): (WebCore::ScrollView::valueChanged): (WebCore::ScrollView::setScrollPosition): (WebCore::ScrollView::updateScrollbars): (WebCore::ScrollView::wheelEvent):
  • platform/ScrollView.h:
  • platform/mac/ScrollViewMac.mm: (WebCore::ScrollView::platformSetContentsSize): (WebCore::ScrollView::platformSetScrollPosition): (WebCore::ScrollView::platformSetScrollOriginX):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::styleDidChange): (WebCore::RenderBox::paintRootBoxDecorations): Include left layout overflow into canvas size.
  • rendering/RenderView.cpp: (WebCore::RenderView::layout): Save left layout overflow. (WebCore::RenderView::docLeft): (WebCore::RenderView::docWidth): Include left layout overflow into doc width for RTL page.
  • rendering/RenderView.h:

2010-11-29 Xiaomei Ji <xji@chromium.org>

Reviewed by David Hyatt.

Right-to-left pages should be scrollable to reveal left overflow.
https://bugs.webkit.org/show_bug.cgi?id=23556

For RTL page, save left layout overflow and include it into the document
size during layout. Use the left layout overflow when scroll and paint
the page. Behavior on LTR page should be untouched since left layout
overflow is set as 0 for LTR page.

  • fast/dom/horizontal-scrollbar-in-rtl-doesnt-fire-onscroll-expected.txt: Added.
  • fast/dom/horizontal-scrollbar-in-rtl-doesnt-fire-onscroll.html: Added.
  • fast/dom/horizontal-scrollbar-in-rtl.html: Added.
  • fast/dom/horizontal-scrollbar-when-dir-change.html: Added.
  • fast/dom/left-overflow-in-ltr.html: Added.
  • fast/dom/right-overflow-in-rtl.html: Added.
  • platform/chromium/fast/dom/horizontal-scrollbar-in-rtl-expected.txt: Added.
  • platform/chromium/fast/dom/horizontal-scrollbar-when-dir-change-expected.txt: Added.
  • platform/mac/fast/block/basic/truncation-rtl-expected.checksum:
  • platform/mac/fast/block/basic/truncation-rtl-expected.txt:
  • platform/mac/fast/dom/horizontal-scrollbar-in-rtl-expected.txt: Added.
  • platform/mac/fast/dom/horizontal-scrollbar-when-dir-change-expected.txt: Added.
  • platform/mac/fast/dom/left-overflow-in-ltr-expected.txt: Added.
  • platform/mac/fast/dom/right-overflow-in-rtl-expected.txt: Added.
  • fast/dom/horizontal-scrollbar-in-rtl-doesnt-fire-onscroll-expected.txt: Added.
  • fast/dom/horizontal-scrollbar-in-rtl-doesnt-fire-onscroll.html: Added.
  • fast/dom/horizontal-scrollbar-in-rtl.html: Added.
  • fast/dom/horizontal-scrollbar-when-dir-change.html: Added.
  • fast/dom/left-overflow-in-ltr.html: Added.
  • fast/dom/right-overflow-in-rtl.html: Added.
  • platform/chromium/fast/dom/horizontal-scrollbar-in-rtl-expected.txt: Added.
  • platform/chromium/fast/dom/horizontal-scrollbar-when-dir-change-expected.txt: Added.
  • platform/mac/fast/block/basic/truncation-rtl-expected.checksum:
  • platform/mac/fast/block/basic/truncation-rtl-expected.txt:
  • platform/mac/fast/dom/horizontal-scrollbar-in-rtl-expected.txt: Added.
  • platform/mac/fast/dom/horizontal-scrollbar-when-dir-change-expected.txt: Added.
  • platform/mac/fast/dom/left-overflow-in-ltr-expected.txt: Added.
  • platform/mac/fast/dom/right-overflow-in-rtl-expected.txt: Added.
16:57 Changeset [72851] by andersca@apple.com
  • 3 edits in trunk/WebKit2

Cursor does not always change back to arrow when exiting image document
https://bugs.webkit.org/show_bug.cgi?id=50190
<rdar://problem/8665265>

Reviewed by Sam Weinig.

  • Shared/mac/WebEventFactory.mm:

(WebKit::mouseEventTypeForEvent):
(WebKit::globalPointForEvent):
(WebKit::pointForEvent):
Handle the NSMouseEntered and NSMouseExited events.

  • UIProcess/API/mac/WKView.mm:

(-[WKView initWithFrame:pageNamespaceRef:hiddenFromInjectedBundle:]):
We want entered and exited events for this tracking area.
Add mouseEntered and mouseExited handlers.

16:53 Changeset [72850] by simon.fraser@apple.com
  • 6 edits
    3 adds
    2 deletes in trunk

2010-11-29 Simon Fraser <simon.fraser@apple.com>

Reviewed by Ojan Vafai.

bunch of pixel failures after http://trac.webkit.org/changeset/72839/
https://bugs.webkit.org/show_bug.cgi?id=50188

We need to call updateLayerTransform() for reflections, and
table rows as well.

  • rendering/RenderReplica.cpp: (WebCore::RenderReplica::layout):
  • rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::layout):
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::layoutRows):
16:40 Changeset [72849] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

2010-11-29 Ojan Vafai <ojan@chromium.org>

Mark tests as failing after http://trac.webkit.org/changeset/72839/.

  • platform/chromium/test_expectations.txt:
16:17 Changeset [72848] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

2010-11-29 Ojan Vafai <ojan@chromium.org>

Mark fast/dom/StyleSheet/gc-declaration-parent-rule.html failing after http://trac.webkit.org/changeset/72833/

  • platform/chromium/test_expectations.txt:
16:12 Changeset [72847] by xji@chromium.org
  • 6 edits
    2 adds in trunk

2010-11-29 Xiaomei Ji <xji@chromium.org>

Reviewed by David Hyatt.

Fix tab overflow problem when alignment is not left.
https://bugs.webkit.org/show_bug.cgi?id=25459

I checked WordPad in Windows, TextEdit in Mac, OpenOffice, and Google doc.
In all of them, (when the writing mode is horizontal) when the alignment is not
left alignment, the length of tab is computed based on the tab's position
relative to the left start of line, not based on the tab's position relative
to the left edge of the document.

WebKit should follow the same.

The m_xPos in each TextRun should be relative to the left start of the line,
not left start of its containing block (in right alignment and center alignment,
left start of the line is not the same as left start of the containing block).
So, when the text is drawn, the width of tab is consistent with the width
computed in RenderBlock::computeInlineDirectionPositionsForLine().

I did not test vertical writing mode, but I think the same rule should apply.

Test: fast/dom/tab-in-right-alignment.html

  • platform/graphics/TextRun.h:
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::textPos):
  • rendering/InlineTextBox.h:

2010-11-29 Xiaomei Ji <xji@chromium.org>

Reviewed by David Hyatt.

Fix tab overflow problem when alignment is not left.
https://bugs.webkit.org/show_bug.cgi?id=25459

I checked WordPad in Windows, TextEdit in Mac, OpenOffice, and Google doc.
In all of them, (when the writing mode is horizontal) when the alignment is not
left alignment, the length of tab is computed based on the tab's position
relative to the left start of line, not based on the tab's position relative
to the left edge of the document.

WebKit should follow the same.

The m_xPos in each TextRun should be relative to the left start of the line,
not left start of its containing block (in right alignment and center alignment,
left start of the line is not the same as left start of the containing block).
So, when the text is drawn, the width of tab is consistent with the width
computed in RenderBlock::computeInlineDirectionPositionsForLine().

I did not test vertical writing mode, but I think the same rule should apply.

  • fast/dom/tab-in-right-alignment-expected.txt: Added.
  • fast/dom/tab-in-right-alignment.html: Added.
  • platform/qt/Skipped:
16:09 Changeset [72846] by sfalken@apple.com
  • 5 edits
    2 adds in trunk

2010-11-29 Steve Falkenburg <sfalken@apple.com>

Reviewed by Adam Roben.

Add a mechanism for Windows pre-build/pre-link/post-build events to be separated into individual cmd files
https://bugs.webkit.org/show_bug.cgi?id=49858

We're migrating our prebuild/prelink/postbuild steps out of vcproj and vsprops files:

  • To simplify editing (editing vsprops build steps is confusing).
  • For more readable diffs.

2010-11-19 Steve Falkenburg <sfalken@apple.com>

Reviewed by Adam Roben.

Add a mechanism for Windows pre-build/pre-link/post-build events to be separated into individual cmd files
https://bugs.webkit.org/show_bug.cgi?id=49858


We're migrating our prebuild/prelink/postbuild steps out of vcproj and vsprops files:

  • To simplify editing (editing vsprops build steps is confusing).
  • For more readable diffs.


To add a prebuild/prelink/postbuild step for a vcproj,
Add a new file named {ProjectName}PreBuild|PreLink|PostBuild.cmd to the project directory.
For example, a WTF prebuild script would be named WTFPreBuild.cmd and would be located
in the directory JavaScriptCore/JavaScriptCore.vcproj/WTF (alongside WTF.vcproj).

  • win/tools/vsprops/common.vsprops:
  • win/tools/vsprops/release.vsprops:
15:51 Changeset [72845] by simon.fraser@apple.com
  • 1 edit
    1 add in trunk/LayoutTests

2010-11-29 Simon Fraser <simon.fraser@apple.com>

Add Qt-specific result.

  • platform/qt/fast/overflow/overflow-update-transform-expected.txt: Added.
15:48 Changeset [72844] by tkent@chromium.org
  • 3 edits in trunk/WebKit/chromium

[Chromium] Add substitution parameters to WebKitClient::queryLocalizedString()
https://bugs.webkit.org/show_bug.cgi?id=50053

Reviewed by Darin Fisher.

  • public/WebKitClient.h:

(WebKit::WebKitClient::queryLocalizedString): Add overload functions with

substitution string parameters, and remove the integer parameter overload.

  • src/LocalizedStrings.cpp:

(WebCore::query): Add string parameter overloads, and remove the integer parameter overload.
(WebCore::multipleFileUploadText): Call the string parameter query().
(WebCore::validationMessageTooLongText): Pass the parameters to query().
(WebCore::validationMessageRangeUnderflowText): ditto.
(WebCore::validationMessageRangeOverflowText): ditto.
(WebCore::validationMessageStepMismatchText): ditto.

15:37 Changeset [72843] by mnaganov@chromium.org
  • 9 edits in trunk/WebCore

2010-11-29 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Pavel Feldman.

WebInspector: Request JSON-serialized heap snapshot from JS engine.
This simplifies heap snapshots interaction and API. Instead of
having objects representing snapshot entities, the whole snapshot
is transferred to WebInspector and parsed there.

https://bugs.webkit.org/show_bug.cgi?id=49974

  • bindings/js/ScriptHeapSnapshot.h: (WebCore::ScriptHeapSnapshot::OutputStream::~OutputStream): (WebCore::ScriptHeapSnapshot::~ScriptHeapSnapshot): (WebCore::ScriptHeapSnapshot::writeJSON): (WebCore::ScriptHeapSnapshot::ScriptHeapSnapshot):
  • bindings/v8/ScriptHeapSnapshot.cpp: (WebCore::ScriptHeapSnapshot::writeJSON):
  • bindings/v8/ScriptHeapSnapshot.h: (WebCore::ScriptHeapSnapshot::OutputStream::~OutputStream):
  • inspector/Inspector.idl:
  • inspector/InspectorProfilerAgent.cpp: (WebCore::InspectorProfilerAgent::getProfile):
  • inspector/front-end/HeapSnapshotView.js: (WebInspector.HeapSnapshotEdgesIterator): (WebInspector.HeapSnapshotEdgesIterator.prototype.get done): (WebInspector.HeapSnapshotEdgesIterator.prototype.get isElement): (WebInspector.HeapSnapshotEdgesIterator.prototype.get isHidden): (WebInspector.HeapSnapshotEdgesIterator.prototype.get name): (WebInspector.HeapSnapshotEdgesIterator.prototype.next): (WebInspector.HeapSnapshotEdgesIterator.prototype.get node): (WebInspector.HeapSnapshotEdgesIterator.prototype.get nodeIndex): (WebInspector.HeapSnapshotEdgesIterator.prototype._getNameOrIndex): (WebInspector.HeapSnapshotEdgesIterator.prototype._getType): (WebInspector.HeapSnapshotNodeWrapper): (WebInspector.HeapSnapshotNodeWrapper.prototype.get edges): (WebInspector.HeapSnapshotNodeWrapper.prototype.get edgesCount): (WebInspector.HeapSnapshotNodeWrapper.prototype.get instancesCount): (WebInspector.HeapSnapshotNodeWrapper.prototype.get isHidden): (WebInspector.HeapSnapshotNodeWrapper.prototype.get name): (WebInspector.HeapSnapshotNodeWrapper.prototype.get selfSize): (WebInspector.HeapSnapshotNodeWrapper.prototype._getName): (WebInspector.HeapSnapshotNodeWrapper.prototype._getEdges): (WebInspector.HeapSnapshotNodeWrapper.prototype._getType): (WebInspector.HeapSnapshot): (WebInspector.HeapSnapshot.prototype._init): (WebInspector.HeapSnapshot.prototype.get rootEdges): (WebInspector.HeapSnapshotView.prototype.snapshotLoaded): (WebInspector.HeapSnapshotView.prototype._loadProfile.processLoadedSnapshot): (WebInspector.HeapSnapshotView.prototype._loadProfile): (WebInspector.HeapSnapshotView.prototype._convertSnapshot): (WebInspector.HeapSnapshotView.prototype._prepareProfile.mergeRetainers): (WebInspector.HeapSnapshotView.prototype._prepareProfile): (WebInspector.HeapSnapshotView.prototype._sortData):
  • inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel): (WebInspector.ProfilesPanel.prototype.addHeapSnapshotChunk): (WebInspector.ProfilesPanel.prototype.finishHeapSnapshot):
  • inspector/front-end/inspector.js: (WebInspector.addHeapSnapshotChunk): (WebInspector.finishHeapSnapshot):
15:35 Changeset [72842] by ggaren@apple.com
  • 4 edits in trunk

Improved accuracy of command-line SunSpider.

Reviewed by Gavin Barraclough.

JavaScriptCore:

  • jsc.cpp:

(functionRun): Changed the "run" function to run a given test in
its own global object. Previously, all tests ran in the same global
object, which created name conflicts, and made globals from previous
tests artificially survive into later tests.

Also changed "run" to return the elapsed milliseconds when running a
given test, for slightly more accurate numbers.

(functionCheckSyntax): Ditto on returning elapsed milliseconds.

SunSpider:

  • resources/sunspider-standalone-driver.js: Use the returned number of

elapsed milliseconds from "run" and "checkSyntax" instead of measuring
ourselves, for slightly more accurate numbers.

15:34 Changeset [72841] by andersca@apple.com
  • 19 edits in trunk/WebKit2

Should be able to pause and resume downloads
https://bugs.webkit.org/show_bug.cgi?id=50185
<rdar://problem/8691135>

Reviewed by Darin Adler.

  • UIProcess/API/C/WKContext.h:

Add didCancel callback.

  • UIProcess/API/C/WKDownload.cpp:

(WKDownloadGetResumeData):
(WKDownloadCancel):
Call the respective DownloadProxy member functions.

  • UIProcess/API/C/WKDownload.h:
  • UIProcess/Downloads/DownloadProxy.cpp:

(WebKit::DownloadProxy::cancel):
Send Cancel to the WebProcess.

(WebKit::DownloadProxy::didFail):
This now takes a resumeData reference.

(WebKit::DownloadProxy::didCancel):
Set the resume data and call didCancel.

  • UIProcess/Downloads/DownloadProxy.h:

(WebKit::DownloadProxy::resumeData):
Return the resume data.

  • UIProcess/Downloads/DownloadProxy.messages.in:

Add DidCancel message, Add resume data to DidFail.

  • UIProcess/WebDownloadClient.cpp:

(WebKit::WebDownloadClient::didCancel):
Call the didCancel context client function.

  • WebProcess/Downloads/Download.cpp:

(WebKit::Download::didFail):
This now takes a resume data argument as well.

(WebKit::Download::didCancel):
Send DidCancel.

  • WebProcess/Downloads/DownloadManager.cpp:

(WebKit::DownloadManager::cancelDownload):
Look up the download and cancel it.

  • WebProcess/Downloads/cf/DownloadCFNet.cpp:

(WebKit::Download::cancel):
Add stub.

  • WebProcess/Downloads/mac/DownloadMac.mm:

(WebKit::Download::cancel):
Cancel the download.

(-[WKDownloadAsDelegate download:didFailWithError:]):
Pass the resume data along.

  • WebProcess/Downloads/qt/DownloadQt.cpp:

(WebKit::Download::cancel):
Add stub.

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::cancelDownload):
Ask the download manager to cancel the download.

  • WebProcess/WebProcess.h:
  • WebProcess/WebProcess.messages.in:

Add CancelDownload message.

15:28 Changeset [72840] by dimich@chromium.org
  • 2 edits
    2 adds in trunk/LayoutTests

[Chromium] Unreviewed, updated expectations for a test fixed on Chromium side.
http://code.google.com/p/chromium/issues/detail?id=61655

  • platform/chromium-mac/security/block-test-no-port-expected.txt: Added.
  • platform/chromium-win/security/block-test-no-port-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
15:13 Changeset [72839] by simon.fraser@apple.com
  • 11 edits
    2 adds in trunk

2010-11-29 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dave Hyatt.

layer()->currentTransform() is stale when layout changes the box size
https://bugs.webkit.org/show_bug.cgi?id=50175

RenderLayer::updateTransform() is fairly expensive, so we
have to avoid calling it from RenderBox::applyLayerTransformToRect()
every time. This requires that we update the layer's transform
during layout, instead of from updateLayerPositions() which is too late.

So call updateLayerTransform() from the various layout methods
on renderers that can be transformed, and remove it from
updateLayerPositions().

Test: fast/overflow/overflow-update-transform.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock): (WebCore::RenderBlock::layoutOnlyPositionedObjects):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::applyLayerTransformToRect): (WebCore::RenderBox::updateLayerTransform):
  • rendering/RenderBox.h:
  • rendering/RenderEmbeddedObject.cpp: (WebCore::RenderEmbeddedObject::layout):
  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutBlock):
  • rendering/RenderIFrame.cpp: (WebCore::RenderIFrame::layout):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateLayerPositions):
  • rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::layout):
  • rendering/RenderTable.cpp: (WebCore::RenderTable::layout):
15:03 Changeset [72838] by crogers@google.com
  • 3 edits
    3 adds in trunk/WebCore

2010-11-29 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

Add remaining custom JSC web audio bindings
https://bugs.webkit.org/show_bug.cgi?id=50172

No new tests since audio API is not yet implemented.

  • bindings/js/JSAudioBufferSourceNodeCustom.cpp: Added. (WebCore::JSAudioBufferSourceNode::setBuffer):
  • bindings/js/JSConvolverNodeCustom.cpp: Added. (WebCore::JSConvolverNode::setBuffer):
  • bindings/js/JSJavaScriptAudioNodeCustom.cpp: Added. (WebCore::JSJavaScriptAudioNode::markChildren):
  • webaudio/AudioBufferSourceNode.idl:
  • webaudio/ConvolverNode.idl:
14:48 Changeset [72837] by ojan@chromium.org
  • 2 edits
    4 adds in trunk/LayoutTests

2010-11-29 Ojan Vafai <ojan@chromium.org>

[Chromium] Mark tests as failing after http://trac.webkit.org/changeset/72819.
And rebaseline loader/reload-subresource-when-type-changes.html after
http://trac.webkit.org/changeset/72817. The difference is that V8 logs a different
error string.

  • platform/chromium-mac/loader/reload-subresource-when-type-changes-expected.txt: Added.
  • platform/chromium-win/loader/reload-subresource-when-type-changes-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
14:45 Changeset [72836] by xan@webkit.org
  • 4 edits in trunk

2010-11-29 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

  • configure.ac: bump version for 1.3.7 release.

WebKit/gtk:

2010-11-29 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

  • NEWS: update for 1.3.7 release.
14:44 Changeset [72835] by yael.aharon@nokia.com
  • 4 edits
    3 adds in trunk

HTMLFormElement.elements doesn't include fieldsets
https://bugs.webkit.org/show_bug.cgi?id=48193

Reviewed by Darin Adler.

WebCore:

Add fieldset and keygen to the list of form collection elements, by making them enumeratable.
This patch does not add object element to the list. A separate bug will do that.

Test: fast/forms/form-collection-elements.html

  • html/HTMLFieldSetElement.h:

(WebCore::HTMLFieldSetElement::isEnumeratable):

  • html/HTMLKeygenElement.h:

(WebCore::HTMLKeygenElement::isEnumeratable):

LayoutTests:

  • fast/forms/form-collection-elements-expected.txt: Added.
  • fast/forms/form-collection-elements.html: Added.
  • fast/forms/script-tests/form-collection-elements.js: Added.
14:35 Changeset [72834] by xan@webkit.org
  • 2 edits in trunk/WebCore

2010-11-29 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

Get distcheck going.

  • GNUmakefile.am:
14:24 Changeset [72833] by ap@apple.com
  • 3 edits
    2 adds in trunk

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=50181
CSS style declarations don't GC protect parents

Test: fast/dom/StyleSheet/gc-declaration-parent-rule.html

  • bindings/js/JSCSSStyleDeclarationCustom.cpp: (WebCore::JSCSSStyleDeclaration::markChildren): Protect the parent rule.
14:10 Changeset [72832] by loislo@chromium.org
  • 3 edits in trunk/WebCore

2010-11-29 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: UI fix. In Timeline, Paint events "Location" value is displayed
in a confusing manner. The format string should be changed from %d x %d
pattern to (%d, %d).

https://bugs.webkit.org/show_bug.cgi?id=50178

  • English.lproj/localizedStrings.js:
  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent):
14:06 Changeset [72831] by darin@apple.com
  • 4 edits in trunk

2010-11-29 Darin Adler <darin@apple.com>

Reviewed by Andreas Kling.

Remove a couple unneeded overflow checks
https://bugs.webkit.org/show_bug.cgi?id=49816

  • wtf/text/CString.cpp: (WTF::CString::init): Use an ASSERT instead of an overflow check with CRASH.

2010-11-29 Darin Adler <darin@apple.com>

Reviewed by Andreas Kling.

Remove a couple unneeded overflow checks
https://bugs.webkit.org/show_bug.cgi?id=49816

  • platform/text/TextCodecUTF16.cpp: (WebCore::TextCodecUTF16::encode): Use an ASSERT instead of an overflow check with CRASH.
14:02 Changeset [72830] by ojan@chromium.org
  • 3 edits in trunk/LayoutTests

2010-11-29 Gavin Peters <gavinp@chromium.org>

Reviewed by Ojan Vafai.

unloadable-script not testing both cases
https://bugs.webkit.org/show_bug.cgi?id=50177

  • http/tests/misc/unloadable-script-expected.txt:
  • http/tests/misc/unloadable-script.html:
13:47 Changeset [72829] by mitz@apple.com
  • 2 edits in trunk/WebKitLibraries

WebKitSystemInterface.h piece of r72438.

Patch by Anders Carlsson <andersca@apple.com> on 2010-11-29
Reviewed by Sam Weinig and Simon Fraser.

  • WebKitSystemInterface.h:
13:43 Changeset [72828] by tony@chromium.org
  • 2 edits in trunk/WebCore

2010-11-29 Tony Chang <tony@chromium.org>

Unreviewed, disable warnings again on chromium linux

  • WebCore.gyp/WebCore.gyp:
13:38 Changeset [72827] by dglazkov@chromium.org
  • 1 edit
    1 delete in trunk/WebKit/chromium

2010-11-29 Dimitri Glazkov <dglazkov@chromium.org>

Remove Build directory that was erroneously added in r72103.

  • Build: Removed.
13:37 Changeset [72826] by commit-queue@webkit.org
  • 18 edits
    4 adds
    2 deletes in trunk

2010-11-29 Cosmin Truta <ctruta@chromium.org>

Reviewed by Nikolas Zimmermann.

getBoundingClientRect: Do not truncate the coordinates to integers
https://bugs.webkit.org/show_bug.cgi?id=48110

Enhanced some of the tests for getBoundingClientRect, and added zooming tests.

  • css3/zoom-coords-expected.txt: Updated.
  • css3/zoom-coords.xhtml: Wrapped the <svg> elements in a <div>, to avoid re-layout on zooming or resizing. Added a test for getBoundingClientRect on unzoomed elements.
  • fast/dom/Element/getBoundingClientRect-expected.txt: Updated.
  • fast/dom/Element/getBoundingClientRect.html: Accounted for non-integer coordinates; used the Ahem font for uniform results; removed the hard-coded dependencies on font metrics.
  • fast/dom/Range/getBoundingClientRect-expected.txt: Updated.
  • fast/dom/Range/getBoundingClientRect.html: Accounted for non-integer coordinates; used the Ahem font for uniform results; removed the hard-coded dependencies on font metrics.
  • platform/chromium-win/fast/dom/Element/getBoundingClientRect-expected.txt: Deleted.
  • platform/chromium-win/fast/dom/Range/getBoundingClientRect-expected.txt: Deleted.
  • svg/custom/getBBox-js.svg: Fixed indentation.
  • svg/custom/getBoundingClientRect.xhtml: Wrapped the <svg> elements in a <div>, to avoid re-layout on zooming or resizing.
  • svg/zoom/page/zoom-getBoundingClientRect-expected.txt: Added.
  • svg/zoom/page/zoom-getBoundingClientRect.xhtml: Added.
  • svg/zoom/page/zoom-zoom-coords-expected.txt: Added.
  • svg/zoom/page/zoom-zoom-coords.xhtml: Added.
  • svg/zoom/resources/testPageZoom.js: Added call to completeDynamicTest on post-zoom. (completeDynamicTest): Added.

2010-11-29 Cosmin Truta <ctruta@chromium.org>

Reviewed by Nikolas Zimmermann.

getBoundingClientRect: Do not truncate the coordinates to integers
https://bugs.webkit.org/show_bug.cgi?id=48110

Remove the float-to-int coordinate conversions inside getBoundingClientRect,
to comply with the CSSOM View Module API.

Tests: fast/dom/Element/getBoundingClientRect.html

fast/dom/Range/getBoundingClientRect.html
svg/zoom/page/zoom-getBoundingClientRect.xhtml
svg/zoom/page/zoom-zoom-coords.xhtml

  • dom/ClientRect.cpp: (WebCore::ClientRect::ClientRect): Added overload to allow a FloatRect argument.
  • dom/ClientRect.h: (WebCore::ClientRect::create): Ditto.
  • dom/Element.cpp: (Element::getBoundingClientRect): Removed conversion from FloatRect to IntRect.
  • dom/Range.cpp: (WebCore::Range::getBoundingClientRect): Ditto.
  • rendering/RenderObject.h: (adjustIntRectForAbsoluteZoom): Removed. (adjustFloatRectForAbsoluteZoom): Added.
  • rendering/style/RenderStyle.h: (adjustFloatForAbsoluteZoom): Added.
13:27 Changeset [72825] by dglazkov@chromium.org
  • 5 edits in trunk/WebCore

2010-11-29 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Darin Adler.

Converge means of querying a parent node into one way, which is Node::parentNode.
https://bugs.webkit.org/show_bug.cgi?id=49686

A follow-up to r72259, which explicitly forbids further use of Node::parent by
making it private.

No change in behavior, so no new tests.

  • dom/Document.cpp: (WebCore::Document::styleForElementIgnoringPendingStylesheets): Changed to use parentNode. (WebCore::Document::hoveredNodeDetached): Ditto. (WebCore::Document::activeChainNodeDetached): Ditto.
  • dom/Node.h: Made Node::parent private.
  • page/SpatialNavigation.cpp: (WebCore::canBeScrolledIntoView): Changed to use parentNode.
  • xml/XSLTProcessorQt.cpp: (WebCore::XSLTProcessor::transformToString): Ditto.
13:22 Changeset [72824] by tony@chromium.org
  • 3 edits in trunk/WebCore

2010-11-29 Tony Chang <tony@chromium.org>

Reviewed by James Robinson.

[chromium] try to enable WebCore compiler warnings on linux
https://bugs.webkit.org/show_bug.cgi?id=50168

  • WebCore.gyp/WebCore.gyp:
  • platform/graphics/chromium/FontLinux.cpp: (WebCore::TextRunWalker::setPadding): (WebCore::TextRunWalker::setGlyphXPositions): (WebCore::glyphIndexForXPositionInScriptRun):
13:09 Changeset [72823] by aroben@apple.com
  • 2 edits in trunk/JavaScriptCore

Robustify react-to-vsprops-changes.py against changes to its location or the location of the .vsprops files

Suggested by John Sullivan.

Removed file_modification_times.
(main): Use glob.glob to find the .vsprops files and assert that we found some.

13:08 Changeset [72822] by aroben@apple.com
  • 2 edits in trunk/JavaScriptCore

Touch wtf/Platform.h whenever any .vsprops file changes

This will cause all files to be recompiled, which will make changes to
preprocessor macros (e.g., ENABLE_*) actually take effect.

Fixes <http://webkit.org/b/50167> Windows build fails when ENABLE_*
macros are changed (because not enough files are rebuilt)

Reviewed by John Sullivan.

(main): Touch wtf/Platform.h if it's older than any .vsprops file. Also
added some comments and logging to make it clearer what the script is
doing and why.

13:01 Changeset [72821] by aroben@apple.com
  • 2 edits in trunk/JavaScriptCore

Update react-to-vsprops-changes.py after r72555

.vsprops files are no longer accessed relative to $WebKitLibrariesDir.

Fixes <http://webkit.org/b/50166> REGRESSION (r72555):
react-to-vsprops-changes.py no longer works for people with a
non-default $WebKitLibrariesDir

Reviewed by John Sullivan.

(main): Always look in WebKitLibraries/win for .vsprops files, not in
$WebKitLibrariesDir.

12:43 Changeset [72820] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

2010-11-29 Ojan Vafai <ojan@chromium.org>

Unreviewed build fix.

Mark tests as failing after http://trac.webkit.org/changeset/72817/
to green chromium tree.

  • platform/chromium/test_expectations.txt:
12:36 Changeset [72819] by ap@apple.com
  • 4 edits
    4 adds in trunk

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=50165
CSS style rules don't GC protect parents

Tests: fast/dom/StyleSheet/gc-parent-rule.html

fast/dom/StyleSheet/gc-parent-stylesheet.html

  • bindings/js/JSCSSRuleCustom.cpp: (WebCore::JSCSSRule::markChildren): Mark parents. The code is super naive compared to what we have for nodes - but CSSOM has shallow hierarchies, so it should be OK.
  • css/CSSRule.idl: Added CustomMarkFunction.
12:22 Changeset [72818] by ojan@chromium.org
  • 4 edits in trunk/LayoutTests

2010-11-29 Ojan Vafai <ojan@chromium.org>

Unreviewed. Build fix.

New test expectations and test_expectations update due to http://trac.webkit.org/changeset/72813/.

  • platform/chromium-mac/fast/js/regexp-overflow-expected.txt:
  • platform/chromium-win/fast/js/regexp-overflow-expected.txt:
  • platform/chromium/test_expectations.txt:
11:45 Changeset [72817] by commit-queue@webkit.org
  • 3 edits
    2 moves
    6 adds in trunk

2010-11-29 Gavin Peters <gavinp@chromium.org>

Reviewed by Adam Barth.

Web page can prevent WebKit from loading subresources on other
pages (cache poisoning)
https://bugs.webkit.org/show_bug.cgi?id=35404

  • http/tests/misc/unloadable-script-expected.txt: Renamed from LayoutTests/fast/loader/unloadable-script-expected.txt.
  • http/tests/misc/unloadable-script.html: Renamed from LayoutTests/fast/loader/unloadable-script.html.
  • loader/reload-subresource-when-type-changes-expected.txt: Added.
  • loader/reload-subresource-when-type-changes.html: Added.
  • loader/resources/image1.png: Added.
  • loader/resources/image2.png: Added.
  • loader/resources/reload-subresource-when-type-changes.js: Added.

2010-11-29 Gavin Peters <gavinp@chromium.org>

Reviewed by Adam Barth.

Web page can prevent WebKit from loading subresources on other
pages (cache poisoning)
https://bugs.webkit.org/show_bug.cgi?id=35404

Tests: http/tests/misc/unloadable-script.html

loader/reload-subresource-when-type-changes.html

  • loader/cache/MemoryCache.cpp: (WebCore::MemoryCache::requestResource):
11:44 Changeset [72816] by kbalazs@webkit.org
  • 5 edits in trunk/WebKit2

2010-11-29 Balazs Kelemen <kbalazs@webkit.org>

Reviewed by Adam Roben.

[WK2] Support repeating timers
https://bugs.webkit.org/show_bug.cgi?id=50024

Added boolean member for TimerBase on PLATFORM(WIN)
and PLATFORM(QT) to be able to differentiate between
repeating and one shot operating mode. Change the confusing
signature of TimerBase::start: use a bool for selecting
operating mode.

  • Platform/RunLoop.h: (RunLoop::TimerBase::startRepeating): (RunLoop::TimerBase::startOneShot):
  • Platform/mac/RunLoopMac.mm: (RunLoop::TimerBase::start):
  • Platform/qt/RunLoopQt.cpp: (RunLoop::TimerBase::timerFired): Only stop the timer if it is not in repeating mode. (RunLoop::TimerBase::TimerBase): (RunLoop::TimerBase::start):
  • Platform/win/RunLoopWin.cpp: (RunLoop::TimerBase::timerFired): Only stop the timer if it is not in repeating mode. (RunLoop::TimerBase::TimerBase): (RunLoop::TimerBase::start):
11:31 QtWebKitContrib edited by siddharth.mathur@nokia.com
added Webkit with Git links (diff)
11:19 Changeset [72815] by aroben@apple.com
  • 1 edit
    4 adds in trunk/LayoutTests

Check in new Windows results after r72678

Right-clicking no longer triggers a selection in DRT on Windows, so we
don't match Mac anymore.

  • platform/win/editing/selection/5109817-expected.checksum: Added.
  • platform/win/editing/selection/5109817-expected.png: Added.
  • platform/win/editing/selection/5109817-expected.txt: Added.
  • platform/win/editing/selection/5354455-1-expected.txt: Added.
11:08 Changeset [72814] by simon.fraser@apple.com
  • 3 edits
    2 adds in trunk

2010-11-29 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

Crash in WebCore::CSSStyleSelector::loadPendingImages
https://bugs.webkit.org/show_bug.cgi?id=50149

Null-check style->boxReflect() when loading pending style images.

Test: fast/reflections/pending-reflection-mask-crash.html

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::loadPendingImages):
10:52 Changeset [72813] by barraclough@apple.com
  • 10 edits
    3 adds in trunk

Bug 48100 - YARR allows what seems like a bogus character-class range

Reviewed by Sam Weinig.

JavaScriptCore:

Per ECMA-262 character classes containing character ranges containing
character classes are invalid, eg:

/[\d-x]/
/[x-\d]/
/[\d-\d]/

These should throw a syntax error.

  • yarr/RegexParser.h:

LayoutTests:

Add/update layout test results.

  • fast/js/regexp-overflow-expected.txt:
  • fast/js/regexp-ranges-and-escaped-hyphens-expected.txt:
  • fast/js/script-tests/regexp-overflow.js:
  • fast/js/script-tests/regexp-ranges-and-escaped-hyphens.js:
  • fast/regex/invalid-range-in-class-expected.txt: Added.
  • fast/regex/invalid-range-in-class.html: Added.
  • fast/regex/script-tests/invalid-range-in-class.js: Added.
  • fast/regex/test1-expected.txt:
  • fast/regex/test4-expected.txt:
  • fast/regex/testinput4:
10:46 Changeset [72812] by andersca@apple.com
  • 8 edits in trunk/WebKit2

Downloads: When the web process crashes, call error callbacks for pending downloads
https://bugs.webkit.org/show_bug.cgi?id=50164
<rdar://problem/8691170>

Reviewed by Sam Weinig.

  • UIProcess/API/C/WKContext.h:

Add processDidCrash callback.

  • UIProcess/Downloads/DownloadProxy.cpp:

(WebKit::DownloadProxy::~DownloadProxy):
Assert that the web context is null.

(WebKit::DownloadProxy::processDidClose):
Call the processDidCrash callback.

(WebKit::DownloadProxy::didFinish):
(WebKit::DownloadProxy::didFail):
Call downloadFinished.

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::processDidClose):
Call processDidClose on all pending downloads.

(WebKit::WebContext::downloadFinished):
Remove the download proxy from the map.

  • UIProcess/WebDownloadClient.cpp:

(WebKit::WebDownloadClient::processDidCrash):
Call the processDidCrash callback function.

10:36 Changeset [72811] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2010-11-29 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: crash upon inspecting user style sheet.
https://bugs.webkit.org/show_bug.cgi?id=50109

  • inspector/InspectorStyleSheet.cpp: (WebCore::InspectorStyleSheet::resourceStyleSheetText):
10:22 QtWebKitRelease21 edited by ossy@webkit.org
Add buildbot link (diff)
10:19 Changeset [72810] by caseq@chromium.org
  • 4 edits in trunk/WebKit/chromium

2010-11-29 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Darin Fisher.

Web Inspector: [Chromium] Expose extension API to select a node in WebInspector
Added WebDevToolsAgent::inspect()
https://bugs.webkit.org/show_bug.cgi?id=49727

  • public/WebDevToolsAgent.h:
  • src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::inspectNode):
  • src/WebDevToolsAgentImpl.h:
10:18 QtWebKitRelease20 edited by ossy@webkit.org
Add buildbot link (diff)
10:17 Changeset [72809] by paroga@webkit.org
  • 2 edits in trunk/WebCore

2010-11-29 Patrick Gansterer <paroga@webkit.org>

Reviewed by Adam Roben.

[WINCE] Implement WebCore::directoryName
https://bugs.webkit.org/show_bug.cgi?id=50031

Also fix handling of paths without path separator.

  • platform/wince/FileSystemWinCE.cpp: (WebCore::reverseFindPathSeparator): (WebCore::makeAllDirectories): (WebCore::pathGetFileName): (WebCore::directoryName):
09:52 Changeset [72808] by paroga@webkit.org
  • 2 edits in trunk/WebCore

2010-11-29 Patrick Gansterer <paroga@webkit.org>

Reviewed by Adam Roben.

Simplify directoryName in FileSystemWin.cpp
https://bugs.webkit.org/show_bug.cgi?id=50028

  • platform/win/FileSystemWin.cpp: (WebCore::directoryName):
09:52 Changeset [72807] by dglazkov@chromium.org
  • 4 edits
    2 adds in trunk

2010-11-24 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Darin Adler.

REGRESSION (r71934): Main search field at Apple tech specs does not accept typing
https://bugs.webkit.org/show_bug.cgi?id=49868

  • fast/forms/disabled-search-input-expected.txt: Added.
  • fast/forms/disabled-search-input.html: Added.

2010-11-24 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Darin Adler.

REGRESSION (r71934): Main search field at Apple tech specs does not accept typing
https://bugs.webkit.org/show_bug.cgi?id=49868

The problem here was that the inner text element of search input was first laid out as
disabled and thus with a 0-height. This would prevent a hit test to ever reach it, even
if it's enabled.

Test: fast/forms/disabled-search-input.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::hasLineIfEmpty): Removed a check for textarea that is no longer necessary.
  • rendering/TextControlInnerElements.cpp: (WebCore::RenderTextControlInnerBlock::hasLineIfEmpty): Added an override to ensure that

an empty inner text element is always one-line high.

09:42 Changeset [72806] by dglazkov@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-11-29 Dimitri Glazkov <dglazkov@chromium.org>

[Chromium] Remove python_24 dependency, because it is no longer necessary.

  • DEPS: Removed python_24 dependency.
09:39 Changeset [72805] by vitalyr@chromium.org
  • 2 edits in trunk/LayoutTests

2010-11-29 Vitaly Repeshko <vitalyr@chromium.org>

Unreviewed.

[chromium] Updating test expecations.

  • platform/chromium/test_expectations.txt:
09:23 Changeset [72804] by mario@webkit.org
  • 2 edits in trunk/WebKitTools

2010-11-29 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Null-check needed in DRT's AccessibilityUIElement::allAtributes()
https://bugs.webkit.org/show_bug.cgi?id=50154

Added missing checks to allAttributes().

  • DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: (AccessibilityUIElement::allAttributes): Added missing checks.
09:01 Changeset [72803] by inferno@chromium.org
  • 2 edits in trunk/LayoutTests

2010-11-29 Abhishek Arya <inferno@chromium.org>

Unreviewed.

Try fixing python test failure from commit 72802.

  • platform/mac/test_expectations.txt:
08:18 Changeset [72802] by inferno@chromium.org
  • 5 edits
    35 adds in trunk

2010-11-29 W. James MacLean <wjmaclean@chromium.org>

Reviewed by Dirk Schulze.

Large input numbers cause overflow during SVG parsing, leading to crash
https://bugs.webkit.org/show_bug.cgi?id=49546

Values outside the range supported by float lead to Infinity() or NaN()
during parsing, leading to subsequent crashes. Modified
parser to verify number is in the supported range, and return false if not.

Tests: svg/custom/svg-parse-overflow-1.html

svg/custom/svg-parse-overflow-2.html
svg/custom/svg-parse-overflow-3.html
svg/custom/svg-parse-overflow-4.html
svg/custom/svg-parse-overflow-5.html

  • svg/SVGParserUtilities.cpp: (WebCore::isValidRange): (WebCore::genericParseNumber):

2010-11-29 W. James MacLean <wjmaclean@chromium.org>

Reviewed by Dirk Schulze.

Large input numbers cause overflow during SVG parsing, leading to crash
https://bugs.webkit.org/show_bug.cgi?id=49546

Values outside the range supported by float lead to Infinity() or NaN()
during parsing, leading to subsequent crashes. Modified
parser to verify number is in the supported range, and return false if not.

  • platform/chromium-linux/svg/custom/svg-parse-overflow-1-expected.checksum: Added.
  • platform/chromium-linux/svg/custom/svg-parse-overflow-1-expected.png: Added.
  • platform/chromium-linux/svg/custom/svg-parse-overflow-1-expected.txt: Added.
  • platform/chromium-linux/svg/custom/svg-parse-overflow-2-expected.checksum: Added.
  • platform/chromium-linux/svg/custom/svg-parse-overflow-2-expected.png: Added.
  • platform/chromium-linux/svg/custom/svg-parse-overflow-2-expected.txt: Added.
  • platform/chromium-linux/svg/custom/svg-parse-overflow-3-expected.checksum: Added.
  • platform/chromium-linux/svg/custom/svg-parse-overflow-3-expected.png: Added.
  • platform/chromium-linux/svg/custom/svg-parse-overflow-3-expected.txt: Added.
  • platform/chromium-linux/svg/custom/svg-parse-overflow-4-expected.checksum: Added.
  • platform/chromium-linux/svg/custom/svg-parse-overflow-4-expected.png: Added.
  • platform/chromium-linux/svg/custom/svg-parse-overflow-4-expected.txt: Added.
  • platform/chromium-linux/svg/custom/svg-parse-overflow-5-expected.checksum: Added.
  • platform/chromium-linux/svg/custom/svg-parse-overflow-5-expected.png: Added.
  • platform/chromium-linux/svg/custom/svg-parse-overflow-5-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
  • platform/mac/svg/custom/svg-parse-overflow-1-expected.checksum: Added.
  • platform/mac/svg/custom/svg-parse-overflow-1-expected.png: Added.
  • platform/mac/svg/custom/svg-parse-overflow-1-expected.txt: Added.
  • platform/mac/svg/custom/svg-parse-overflow-2-expected.checksum: Added.
  • platform/mac/svg/custom/svg-parse-overflow-2-expected.png: Added.
  • platform/mac/svg/custom/svg-parse-overflow-2-expected.txt: Added.
  • platform/mac/svg/custom/svg-parse-overflow-3-expected.checksum: Added.
  • platform/mac/svg/custom/svg-parse-overflow-3-expected.png: Added.
  • platform/mac/svg/custom/svg-parse-overflow-3-expected.txt: Added.
  • platform/mac/svg/custom/svg-parse-overflow-4-expected.checksum: Added.
  • platform/mac/svg/custom/svg-parse-overflow-4-expected.png: Added.
  • platform/mac/svg/custom/svg-parse-overflow-4-expected.txt: Added.
  • platform/mac/svg/custom/svg-parse-overflow-5-expected.checksum: Added.
  • platform/mac/svg/custom/svg-parse-overflow-5-expected.png: Added.
  • platform/mac/svg/custom/svg-parse-overflow-5-expected.txt: Added.
  • platform/mac/test_expectations.txt:
  • svg/custom/svg-parse-overflow-1.html: Added.
  • svg/custom/svg-parse-overflow-2.html: Added.
  • svg/custom/svg-parse-overflow-3.html: Added.
  • svg/custom/svg-parse-overflow-4.html: Added.
  • svg/custom/svg-parse-overflow-5.html: Added.
08:16 Changeset [72801] by tonikitoo@webkit.org
  • 2 edits in trunk/LayoutTests

2010-11-29 Antonio Gomes <agomes@rim.com>

Rubber stamped by Csaba Osztrogonác.

Clean up mac-wk2 Skipped file wrt spatial navigation tests.

  • platform/mac-wk2/Skipped:
08:04 Changeset [72800] by yurys@chromium.org
  • 8 edits
    3 adds in trunk

2010-11-29 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: display name of an object constructor as the object's type
https://bugs.webkit.org/show_bug.cgi?id=50063

Name of the function that has created given object is used as the object's
type when it's displayed in the inspector front-end(in case of V8). Before
this change, it was always a value of the object's constructor.name property
which is confusing in some cases(see the test).

Removed check for jsEngine from the InjectedScript.js, all VM-specific code
is now encapsulated on the bindings layer.

Test: inspector/console-object-constructor-name.html

  • bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::createInjectedScript): (WebCore::JSInjectedScriptHost::constructorName):
  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::createInjectedScript): (WebCore::V8InjectedScriptHost::constructorNameCallback):
  • inspector/InjectedScriptHost.idl:
  • inspector/front-end/InjectedScript.js: (injectedScriptConstructor.):

2010-11-29 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: display name of an object constructor as the object's type
https://bugs.webkit.org/show_bug.cgi?id=50063

  • inspector/console-object-constructor-name-expected.txt: Added.
  • inspector/console-object-constructor-name.html: Added.
  • inspector/extensions-events-expected.txt:
  • platform/chromium/inspector/console-object-constructor-name-expected.txt: Added.
07:51 Changeset [72799] by jeremy@chromium.org
  • 2 edits in trunk/WebCore

2010-11-29 Jeremy Moskovich <jeremy@chromium.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=24346

Remove temporary workaround to load Gears plugin.

  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::rendererIsNeeded):
07:45 Changeset [72798] by philn@webkit.org
  • 2 edits in trunk/LayoutTests

2010-11-29 Philippe Normand <pnormand@igalia.com>

Unreviewed, skipping crashing test.

[GStreamer] fast/events/tabindex-focus-blur-all.html crashes
https://bugs.webkit.org/show_bug.cgi?id=50155

  • platform/gtk/Skipped:
07:40 Changeset [72797] by yael.aharon@nokia.com
  • 4 edits in trunk/WebCore

Spatial Navigation: Store more information in FocusCandidate
https://bugs.webkit.org/show_bug.cgi?id=50153

Reviewed by Antonio Gomes.

More information should be stored in FocusCandidate, to avoid
recalculating it when running the spatial navigation algorithm.

No new tests, since this is code refactoring only.

  • page/FocusController.cpp:

(WebCore::updateFocusCandidateIfNeeded):
(WebCore::FocusController::findFocusCandidateInContainer):
(WebCore::FocusController::advanceFocusDirectionallyInContainer):

  • page/SpatialNavigation.cpp:

(WebCore::FocusCandidate::FocusCandidate):
(WebCore::canBeScrolledIntoView):

  • page/SpatialNavigation.h:

(WebCore::FocusCandidate::FocusCandidate):

07:12 Changeset [72796] by dglazkov@chromium.org
  • 6 edits in trunk

2010-11-29 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Darin Adler.

Use the right focusable check to avoid multiple focus/blur events being fired from inside of the shadow DOM.
https://bugs.webkit.org/show_bug.cgi?id=49977

  • fast/events/shadow-boundary-crossing-2.html: Added a test for multiple focus events.
  • fast/events/shadow-boundary-crossing-2-expected.txt: Added new test expectation.

2010-11-29 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Darin Adler.

Use the right focusable check to avoid multiple focus/blur events being fired from inside of the shadow DOM.
https://bugs.webkit.org/show_bug.cgi?id=49977

  • editing/SelectionController.cpp: (WebCore::SelectionController::setFocusedNodeIfNeeded): Added a FIXME to remove redundant code.
  • page/EventHandler.cpp: (WebCore::EventHandler::dispatchMouseEvent): Changed to use isMouseFocusable, which is what shadow DOM elements

override, and added a FIXME to convert to use shadow DOM-aware traversal instead of render tree traversal.

Test: fast/events/shadow-boundary-crossing-2.html

07:06 Changeset [72795] by aroben@apple.com
  • 2 edits in trunk/WebCore

Windows build fix after r72715

  • WebCore.vcproj/WebCore.vcproj: Add a missing </File> tag to fix an

XML syntax error.

06:47 Changeset [72794] by commit-queue@webkit.org
  • 6 edits
    1 delete in trunk

2010-11-29 Bernhard Bauer <bauerb@chromium.org>

Reviewed by Jeremy Orlow.

Remove databaseFileName from IDBFactoryBackendImpl
https://bugs.webkit.org/show_bug.cgi?id=50150

No new tests, since functionality is unchanged.

  • storage/IDBFactoryBackendImpl.cpp: (WebCore::openSQLiteDatabase):
  • storage/IDBFactoryBackendImpl.h:

2010-11-29 Bernhard Bauer <bauerb@chromium.org>

Reviewed by Jeremy Orlow.

Remove databaseFileName from WebIDBFactory
https://bugs.webkit.org/show_bug.cgi?id=50150

  • WebKit.gyp:
  • public/WebIDBFactory.h: (WebKit::WebIDBFactory::open):
  • src/WebIDBFactory.cpp: Removed.
06:29 Changeset [72793] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-11-29 Philippe Normand <pnormand@igalia.com>

Reviewed by Xan Lopez.

[GStreamer] take video sink ownership with gst_object API
https://bugs.webkit.org/show_bug.cgi?id=49011

Use gst_object_ref_sink instead of g_object_ref_sink to avoid
possible leaks.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):
05:28 Changeset [72792] by laszlo.1.gombos@nokia.com
  • 6 edits in trunk

2010-11-29 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Allow pre-generation for package builds for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=50139

Use a build variable for the generated directory path and set the
value based on CONFIG just like for WebKit1.

For non-package builds use a relative base path for the
genrated directory just like for WebKit1.

  • DerivedSources.pro:
  • WebKit2.pro:

2010-11-29 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Allow pre-generation for package builds for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=50139

Use a build variable for the generated directory path and set the
value based on CONFIG just like for WebKit1.

For non-package builds use a relative base path for the
genrated directory just like for WebKit1.

  • WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
  • WebKitTestRunner/qt/WebKitTestRunner.pro:
05:20 Changeset [72791] by yael.aharon@nokia.com
  • 2 edits in trunk/LayoutTests

[Mac] fast/events/spatial-navigation/snav-unit-overflow-and-scroll-in-direction.html fails
https://bugs.webkit.org/show_bug.cgi?id=47449

Reviewed by Antonio Gomes.

Remove test from skip list, it is passing now.

  • platform/mac/Skipped:
05:15 Changeset [72790] by yael.aharon@nokia.com
  • 2 edits in trunk/LayoutTests

[Mac] fast/events/spatial-navigation/snav-iframe-with-offscreen-focusable-element.html fails
https://bugs.webkit.org/show_bug.cgi?id=47448

Reviewed by Antonio Gomes.

Remove test from skip list, it is passing now and does not depend on font metrics anymore.

  • platform/mac/Skipped:
04:35 Changeset [72789] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit/gtk

2010-11-29 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Xan Lopez.

[Gtk] Tooltips should be fully keyboard accessible
https://bugs.webkit.org/show_bug.cgi?id=25525

Position the tooltip under the current focused element when the
tooltip has been triggered using the keyboard.

  • webkit/webkitwebview.cpp: (webkit_web_view_query_tooltip): (webkit_web_view_show_help): (webkit_web_view_class_init):
04:05 Changeset [72788] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-11-29 Jan Erik Hanssen <jhanssen@sencha.com>

Reviewed by Kenneth Rohde Christiansen.

QtWebKit asserts when selecting elided text.
https://bugs.webkit.org/show_bug.cgi?id=45391

Ensure that the length passed to fromRawDataWithoutRef() does
not exceed the length of the string.

  • platform/graphics/qt/FontQt.cpp: (WebCore::Font::selectionRectForSimpleText):
03:50 Changeset [72787] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit/gtk

2010-11-29 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Xan Lopez.

[GTK] Tooltips not shown when scrolling
https://bugs.webkit.org/show_bug.cgi?id=50143

Convert tooltip area to window coordinates so that tooltips are
shown even after scrolling.

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::mouseDidMoveOverElement):
03:28 Changeset [72786] by apavlov@chromium.org
  • 4 edits in trunk/WebCore

2010-11-26 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Styles Gear Menu Choice to Display Colors "As Authored"
https://bugs.webkit.org/show_bug.cgi?id=31614

  • English.lproj/localizedStrings.js:
  • inspector/front-end/Color.js: (WebInspector.Color.prototype.toString): (WebInspector.Color.prototype._parse.this.rgba.set 0): (WebInspector.Color.prototype._parse.set WebInspector): (WebInspector.Color.prototype._parse):
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertyTreeElement.prototype.updateTitle.processColor.nextFormat): (WebInspector.StylePropertyTreeElement.prototype.updateTitle.processColor.changeColorDisplay):
02:41 Changeset [72785] by hans@chromium.org
  • 2 edits in trunk/LayoutTests

2010-11-29 Hans Wennborg <hans@chromium.org>

Reviewed by Jeremy Orlow.

IndexedDB: update tutorial.html
https://bugs.webkit.org/show_bug.cgi?id=50140

removeObjectStore() was renamed to deleteObjectStore()

  • storage/indexeddb/tutorial.html:
02:12 Changeset [72784] by commit-queue@webkit.org
  • 5 edits
    3 adds in trunk

2010-11-29 Helder Correia <helder@sencha.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] fillRect shadow has incorrect behavior when using ctx.scale(x,y)
https://bugs.webkit.org/show_bug.cgi?id=50141

New fast canvas test to ensure correct fillRect shadow when using
ctx.scale(x,y).

  • fast/canvas/canvas-scale-fillRect-shadow-expected.txt: Added.
  • fast/canvas/canvas-scale-fillRect-shadow.html: Added.
  • fast/canvas/script-tests/canvas-scale-fillRect-shadow.js: Added.

2010-11-29 Helder Correia <helder@sencha.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] fillRect shadow has incorrect behavior when using ctx.scale(x,y)
https://bugs.webkit.org/show_bug.cgi?id=50141

Don't apply scaling transformation to shadow offsets.

Test: fast/canvas/canvas-scale-fillRect-shadow.html

  • platform/graphics/ContextShadow.h:
  • platform/graphics/qt/ContextShadowQt.cpp: (WebCore::ContextShadow::beginShadowLayer): (WebCore::ContextShadow::endShadowLayer):
  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::fillRect):

11/28/10:

22:45 Changeset [72783] by dglazkov@chromium.org
  • 7 edits in trunk

2010-11-28 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Darin Adler.

Default event handlers should also be using event retargeting.
https://bugs.webkit.org/show_bug.cgi?id=49986

  • fast/events/shadow-boundary-crossing-2.html: Added a test.
  • fast/events/shadow-boundary-crossing-2-expected.txt: Modified expectations to include new test.

2010-11-28 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Darin Adler.

Default event handlers should also be using event retargeting.
https://bugs.webkit.org/show_bug.cgi?id=49986

Test: fast/events/shadow-boundary-crossing-2.html

  • dom/EventContext.cpp: (WebCore::EventContext::defaultEventHandler): Added.
  • dom/EventContext.h: Added decl.
  • dom/Node.cpp: (WebCore::Node::dispatchGenericEvent): Changed to use event retargeting for

default event handlers.

17:06 Changeset [72782] by morrita@google.com
  • 7 edits in trunk

2010-11-23 MORITA Hajime <morrita@google.com>

Reviewed by Kent Tamura.

REGRESSION: Text on <input type="search"> is not spellchecked.
https://bugs.webkit.org/show_bug.cgi?id=49651

  • editing/spelling/spellcheck-attribute.html: Added <input type="search"> cases.
  • editing/spelling/spellcheck-attribute-expected.txt:

2010-11-23 MORITA Hajime <morrita@google.com>

Reviewed by Kent Tamura.

REGRESSION: Text on <input type="search"> is not spellchecked.
https://bugs.webkit.org/show_bug.cgi?id=49651

TextControlInnerElement::isSpellCheckingEnabled() didn't consider
non-root shadow elelements and always went false for <input type="search>.
This change unifies shadow and host handling into Element::isSpellCheckingEnabled().

Test: editing/spelling/spellcheck-attribute.html

  • dom/Element.cpp: (WebCore::Element::isSpellCheckingEnabled):
  • rendering/TextControlInnerElements.cpp:
  • rendering/TextControlInnerElements.h:
16:45 Changeset [72781] by barraclough@apple.com
  • 8 edits
    6 adds in trunk

Bug 48101 - Yarr gives different results for /(?:a*?){2,}/

Reviewed by Sam Weinig.

JavaScriptCore:

The test cases in the linked mozilla bug demostrate a couple of
problems in subpattern matching. These bugs lie in the optimized
cases - for matching parentheses with a quantity count of 1, and
for matching greedy quantified parentheses at the end of a regex
(which do not backtrack).

In both of these cases we are failing to correctly handle empty
matches. In the case of parenthese-single matches (quantity count
one) we are failing to test for empty matches at all. In the case
of terminal subpattern matches we do currenty check, however there
is a subtler bug here too. In the case of an empty match we will
presently immediately fall through to the next alternative (or
complete the regex match), whereas upon a failed match we should
be backtracking into the failing alternative, to give it a chance
to match further (e.g. consider /a??b?|a/.exec("ab") - upon first
attempting to match the first alternative this will match the empty
string - since a?? is non-greedy, however rather than moving on to
the second alternative we should be re-matching the first one, at
which point the non-greedy a?? will match, and as such the result
should be "ab", not "a").

Terminal sunpattern matching contains a second bug, too. The frame
location values in the subpattern should be being allocated with
the outer disjunction's frame (as we do for the parentheses-single
optimization). Consider the following three regexes:

/a*(?:b*)*c*/
/a*(?:b*)c*/
/a*(?:b*)*/

Considering only the frame location required by the atoms a,b, and
c, (ignoring space associated with the nested subpattern) the first
regex (a normal subpattern match) requires a frame size of 2 for
the outer disjunction, (to backtrack terms a & c), with each
iteration of the subpattern requiring a frame of size 1 (in order
to backtrack b). In the case of the second regex (where the
parentheses-single optimization will kick in) the outer frame must
be set up with a frame size of 3, since the outer frame will also
be used when running the nested subpattern. We will currently only
allocate a farme of size 1 for the outer disjuntion (to contain a),
howver the frame size should be 2 (since the subpattern will be
evaluated in the outer frame). In addition to failing to allocate
frame space the frame offsets are also presently invalid - in the
case of the last regex b's frame location will be set assuming it
to be the first term in the frame, whereas in this case b lies
after the term a, and should be taking a separate frame location.

In order to correctly allocate the frame for terminal subpattern
matches we must move this optimization back up from the JIT into
the compiler (and thus interpreter too), since this is where the
frame allocation takes place.

  • yarr/RegexCompiler.cpp:

(JSC::Yarr::RegexPatternConstructor::setupAlternativeOffsets):
(JSC::Yarr::RegexPatternConstructor::checkForTerminalParentheses):
(JSC::Yarr::compileRegex):

  • yarr/RegexInterpreter.cpp:

(JSC::Yarr::Interpreter::matchParenthesesOnceBegin):
(JSC::Yarr::Interpreter::matchParenthesesOnceEnd):
(JSC::Yarr::Interpreter::backtrackParenthesesOnceBegin):
(JSC::Yarr::Interpreter::backtrackParenthesesOnceEnd):
(JSC::Yarr::Interpreter::matchParenthesesTerminalBegin):
(JSC::Yarr::Interpreter::matchParenthesesTerminalEnd):
(JSC::Yarr::Interpreter::backtrackParenthesesTerminalBegin):
(JSC::Yarr::Interpreter::backtrackParenthesesTerminalEnd):
(JSC::Yarr::Interpreter::matchDisjunction):
(JSC::Yarr::ByteCompiler::atomParenthesesOnceBegin):
(JSC::Yarr::ByteCompiler::atomParenthesesTerminalBegin):
(JSC::Yarr::ByteCompiler::atomParenthesesSubpatternBegin):
(JSC::Yarr::ByteCompiler::atomParentheticalAssertionEnd):
(JSC::Yarr::ByteCompiler::atomParenthesesSubpatternEnd):
(JSC::Yarr::ByteCompiler::atomParenthesesOnceEnd):
(JSC::Yarr::ByteCompiler::atomParenthesesTerminalEnd):
(JSC::Yarr::ByteCompiler::emitDisjunction):

  • yarr/RegexInterpreter.h:
  • yarr/RegexJIT.cpp:

(JSC::Yarr::RegexGenerator::generateParenthesesSingle):
(JSC::Yarr::RegexGenerator::generateParenthesesGreedyNoBacktrack):
(JSC::Yarr::RegexGenerator::generateTerm):

  • yarr/RegexPattern.h:

(JSC::Yarr::PatternTerm::PatternTerm):

LayoutTests:

Add layout tests for corner cases of repeat matches in regular expressions,
and of the examples documented in the ECMA-262 spec .

  • fast/regex/ecma-regex-examples-expected.txt: Added.
  • fast/regex/ecma-regex-examples.html: Added.
  • fast/regex/repeat-match-waldemar-expected.txt: Added.
  • fast/regex/repeat-match-waldemar.html: Added.
  • fast/regex/script-tests/ecma-regex-examples.js: Added.
  • fast/regex/script-tests/repeat-match-waldemar.js: Added.
10:51 Changeset [72780] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-11-28 Antonio Gomes <agomes@rim.com>

Reviewed by Kenneth Rohde Christiansen.

Spatial Navigation: use isSpatialNaviagtionEnabled from SpatialNavigation.h in HTMLInputElement::defaultEventHandler
https://bugs.webkit.org/show_bug.cgi?id=50131

For all isSpatialNavigationEnabled calls throughout WebCore, we decided to use the static method in
SpatialNavigation.h instead of directly checking from the one in Settings.h. Reason: in a soon future,
there will be a isCaretBrowsing check incorporated into this method (and probably renaming it accordingly)
to avoid feature conflicts (spatial navigation x caret browsing).

No new tests needed.

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler):
10:32 Changeset [72779] by laszlo.1.gombos@nokia.com
  • 4 edits in trunk

2010-11-28 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Move some build logic from Qt to platform independent code
https://bugs.webkit.org/show_bug.cgi?id=50134

Remove the creation of the directories under $$OUTPUT_DIR/include
as these will be handled by the fwheader_generator target.

Remove the explicit generation of $$OUTPUT_DIR/WebKit2/generated as
this is not required.

  • DerivedSources.pro:

2010-11-28 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Move some build logic from Qt to platform independent code
https://bugs.webkit.org/show_bug.cgi?id=50134

Create target directories inside generate-forwarding-headers.pl.

  • Scripts/generate-forwarding-headers.pl:
09:34 Changeset [72778] by laszlo.1.gombos@nokia.com
  • 2 edits in trunk

2010-11-28 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Antonio Gomes.

[Qt] Remove unused BASE_DIR from the build system
https://bugs.webkit.org/show_bug.cgi?id=50132

  • WebKit.pri:

11/27/10:

18:54 Changeset [72777] by commit-queue@webkit.org
  • 13 edits
    1 add in trunk/WebCore

2010-11-27 Benjamin Kalman <kalman@chromium.org>

Reviewed by Darin Adler.

Move Position::EditingBoundaryCrossingRule to a new header file
https://bugs.webkit.org/show_bug.cgi?id=49630

  • GNUmakefile.am:
  • WebCore.exp.in:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/Position.cpp: (WebCore::downstreamIgnoringEditingBoundaries): (WebCore::upstreamIgnoringEditingBoundaries):
  • dom/Position.h:
  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::doApply):
  • editing/EditingBoundary.h: Added.
  • editing/visible_units.cpp: (WebCore::startOfParagraph): (WebCore::endOfParagraph): (WebCore::isStartOfParagraph): (WebCore::isEndOfParagraph):
  • editing/visible_units.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::createVisiblePosition):
01:15 Changeset [72776] by rwlbuis@webkit.org
  • 4 edits
    3 adds in trunk

2010-11-26 Rob Buis <rwlbuis@gmail.com>

Reviewed by Simon Fraser.

Percentage z offset in transform-origin should make the property invalid
https://bugs.webkit.org/show_bug.cgi?id=48704

Discard transform-origin property when parsing invalid Z value.

Test: fast/css/transform-origin-parsing.html

  • css/CSSParser.cpp: (WebCore::CSSParser::parseTransformOriginShorthand): (WebCore::CSSParser::parseTransformOrigin):
  • css/CSSParser.h:

11/26/10:

12:40 Changeset [72775] by loislo@chromium.org
  • 2 edits in trunk/LayoutTests

2010-11-26 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed fix for chromium test expectations.

  • platform/chromium-gpu/test_expectations.txt: added: BUGWK50112 WIN LINUX : fast/canvas/canvas-createPattern-fillRect-shadow.html = TEXT
12:18 Changeset [72774] by mitz@apple.com
  • 8 edits in trunk/WebCore

<rdar://problem/8681368> Avoid unnecessary calls to CTFontGetPlatformFont()
https://bugs.webkit.org/show_bug.cgi?id=50096

Reviewed by Antti Koivisto.

No new test, since functionality is unchanged.

  • platform/graphics/chromium/CrossProcessFontLoading.mm:

(WebCore::FontPlatformData::loadFont): Removed the ATSUFontID argument.

  • platform/graphics/cocoa/FontPlatformData.h:

(WebCore::FontPlatformData::FontPlatformData): Ditto.
(WebCore::FontPlatformData::operator==): Removed comparison of font IDs.

  • platform/graphics/cocoa/FontPlatformDataCocoa.mm:

(WebCore::FontPlatformData::loadFont): Removed the ATSUFontID argument.
(WebCore::FontPlatformData::FontPlatformData): Updated.
(WebCore::FontPlatformData::operator=): Removed copying of font ID.
(WebCore::FontPlatformData::setFont): Removed setting of font ID.

  • platform/graphics/mac/ComplexTextControllerATSUI.cpp:

(WebCore::initializeATSUStyle): Call CTFontGetPlatformFont() here if necessary.

  • platform/graphics/mac/FontCustomPlatformData.cpp:

(WebCore::FontCustomPlatformData::fontPlatformData): Updated for FontPlatformData change.
(WebCore::createFontCustomPlatformData): Updated for FontCustomPlatformData change.

  • platform/graphics/mac/FontCustomPlatformData.h:

(WebCore::FontCustomPlatformData::FontCustomPlatformData): Removed ATSUFontID argument and
data member.

  • platform/graphics/mac/SimpleFontDataATSUI.mm:

(WebCore::SimpleFontData::checkShapesArabic): Call CTFontGetPlatformFont() here if necessary.

10:01 Changeset [72773] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-11-26 François Sausset <sausset@gmail.com>

Reviewed by Daniel Bates.

MathML: code cleaning needed in MathMLInlineContainerElement.cpp
https://bugs.webkit.org/show_bug.cgi?id=50069

Unnecessary namespace was removed and style was adjusted.

  • mathml/MathMLInlineContainerElement.cpp: (WebCore::MathMLInlineContainerElement::createRenderer):
09:43 Changeset [72772] by commit-queue@webkit.org
  • 3 edits in trunk/WebKit/gtk

2010-11-26 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Xan Lopez.

[GTK] Inspector: add a way to inspect a WebKitDOMNode
https://bugs.webkit.org/show_bug.cgi?id=49903

  • webkit/webkitwebinspector.cpp: (webkit_web_inspector_inspect_node):
  • webkit/webkitwebinspector.h:
08:58 Changeset [72771] by andreip@google.com
  • 32 edits in trunk

2010-11-26 Andrei Popescu <andreip@google.com>

Reviewed by Jeremy Orlow.

IDBDatabase and IDBObjectStore remove* methods should be renamed to delete*
https://bugs.webkit.org/show_bug.cgi?id=50113

  • storage/indexeddb/objectstore-basics-expected.txt:
  • storage/indexeddb/objectstore-basics.html:
  • storage/indexeddb/objectstore-removeobjectstore-expected.txt:
  • storage/indexeddb/objectstore-removeobjectstore.html:
  • storage/indexeddb/resources/shared.js: (deleteAllObjectStores):
  • storage/indexeddb/transaction-basics-expected.txt:
  • storage/indexeddb/transaction-basics.html:

2010-11-26 Andrei Popescu <andreip@google.com>

Reviewed by Jeremy Orlow.

IDBDatabase and IDBObjectStore remove* methods should be renamed to delete*
https://bugs.webkit.org/show_bug.cgi?id=50113

Modified exisiting layout tests to cover this change.

  • storage/IDBDatabase.cpp: (WebCore::IDBDatabase::deleteObjectStore):
  • storage/IDBDatabase.h:
  • storage/IDBDatabase.idl:
  • storage/IDBDatabaseBackendImpl.cpp: (WebCore::IDBDatabaseBackendImpl::deleteObjectStore): (WebCore::IDBDatabaseBackendImpl::deleteObjectStoreInternal):
  • storage/IDBDatabaseBackendImpl.h:
  • storage/IDBDatabaseBackendInterface.h:
  • storage/IDBObjectStore.cpp: (WebCore::IDBObjectStore::deleteFunction): (WebCore::IDBObjectStore::deleteIndex):
  • storage/IDBObjectStore.h:
  • storage/IDBObjectStore.idl:
  • storage/IDBObjectStoreBackendImpl.cpp: (WebCore::IDBObjectStoreBackendImpl::deleteFunction): (WebCore::IDBObjectStoreBackendImpl::deleteInternal): (WebCore::IDBObjectStoreBackendImpl::deleteIndex): (WebCore::IDBObjectStoreBackendImpl::deleteIndexInternal):
  • storage/IDBObjectStoreBackendImpl.h:
  • storage/IDBObjectStoreBackendInterface.h:

2010-11-26 Andrei Popescu <andreip@google.com>

Reviewed by Jeremy Orlow.

IDBDatabase and IDBObjectStore remove* methods should be renamed to delete*
https://bugs.webkit.org/show_bug.cgi?id=50113

  • public/WebIDBDatabase.h: (WebKit::WebIDBDatabase::deleteObjectStore): (WebKit::WebIDBDatabase::removeObjectStore):
  • public/WebIDBObjectStore.h: (WebKit::WebIDBObjectStore::remove): (WebKit::WebIDBObjectStore::deleteFunction): (WebKit::WebIDBObjectStore::deleteIndex):
  • src/IDBDatabaseProxy.cpp: (WebCore::IDBDatabaseProxy::deleteObjectStore):
  • src/IDBDatabaseProxy.h:
  • src/IDBObjectStoreProxy.cpp: (WebCore::IDBObjectStoreProxy::deleteFunction): (WebCore::IDBObjectStoreProxy::deleteIndex):
  • src/IDBObjectStoreProxy.h:
  • src/WebIDBDatabaseImpl.cpp: (WebKit::WebIDBDatabaseImpl::deleteObjectStore):
  • src/WebIDBDatabaseImpl.h:
  • src/WebIDBObjectStoreImpl.cpp: (WebKit::WebIDBObjectStoreImpl::deleteFunction): (WebKit::WebIDBObjectStoreImpl::deleteIndex):
  • src/WebIDBObjectStoreImpl.h:
08:53 Changeset [72770] by commit-queue@webkit.org
  • 21 edits
    18 deletes in trunk

2010-11-26 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r72701.
http://trac.webkit.org/changeset/72701
https://bugs.webkit.org/show_bug.cgi?id=50114

REGRESSION: bad transform matrix on content layer (Requested
by backer on #webkit).

  • compositing/lots-of-img-layers-with-opacity.html: Removed.
  • compositing/lots-of-img-layers.html: Removed.
  • platform/chromium-gpu-win/compositing/lots-of-img-layers-expected.checksum: Removed.
  • platform/chromium-gpu-win/compositing/lots-of-img-layers-expected.png: Removed.
  • platform/chromium-gpu-win/compositing/lots-of-img-layers-expected.txt: Removed.
  • platform/chromium-gpu-win/compositing/lots-of-img-layers-with-opacity-expected.checksum: Removed.
  • platform/chromium-gpu-win/compositing/lots-of-img-layers-with-opacity-expected.png: Removed.
  • platform/chromium-gpu-win/compositing/lots-of-img-layers-with-opacity-expected.txt: Removed.
  • platform/chromium-gpu/test_expectations.txt:
  • platform/mac/compositing/lots-of-img-layers-expected.checksum: Removed.
  • platform/mac/compositing/lots-of-img-layers-expected.png: Removed.
  • platform/mac/compositing/lots-of-img-layers-expected.txt: Removed.
  • platform/mac/compositing/lots-of-img-layers-with-opacity-expected.checksum: Removed.
  • platform/mac/compositing/lots-of-img-layers-with-opacity-expected.png: Removed.
  • platform/mac/compositing/lots-of-img-layers-with-opacity-expected.txt: Removed.

2010-11-26 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r72701.
http://trac.webkit.org/changeset/72701
https://bugs.webkit.org/show_bug.cgi?id=50114

REGRESSION: bad transform matrix on content layer (Requested
by backer on #webkit).

  • WebCore.gypi:
  • platform/graphics/chromium/Canvas2DLayerChromium.cpp: (WebCore::Canvas2DLayerChromium::updateContents):
  • platform/graphics/chromium/Canvas2DLayerChromium.h:
  • platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::cleanupResources): (WebCore::ContentLayerChromium::updateContents): (WebCore::ContentLayerChromium::updateTextureRect): (WebCore::ContentLayerChromium::draw):
  • platform/graphics/chromium/ContentLayerChromium.h:
  • platform/graphics/chromium/ImageLayerChromium.cpp: (WebCore::ImageLayerChromium::updateContents):
  • platform/graphics/chromium/ImageLayerChromium.h:
  • platform/graphics/chromium/LayerChromium.h: (WebCore::LayerChromium::contentsDirty): (WebCore::LayerChromium::updateContents): (WebCore::LayerChromium::draw):
  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::LayerRendererChromium): (WebCore::LayerRendererChromium::prepareToDrawLayers): (WebCore::LayerRendererChromium::drawLayers): (WebCore::LayerRendererChromium::updateLayersRecursive): (WebCore::LayerRendererChromium::useRenderSurface): (WebCore::LayerRendererChromium::drawLayer): (WebCore::LayerRendererChromium::initializeSharedObjects): (WebCore::LayerRendererChromium::cleanupSharedObjects):
  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/LayerTexture.cpp: Removed.
  • platform/graphics/chromium/LayerTexture.h: Removed.
  • platform/graphics/chromium/PluginLayerChromium.cpp: (WebCore::PluginLayerChromium::updateContents):
  • platform/graphics/chromium/PluginLayerChromium.h:
  • platform/graphics/chromium/RenderSurfaceChromium.cpp: (WebCore::RenderSurfaceChromium::RenderSurfaceChromium): (WebCore::RenderSurfaceChromium::cleanupResources): (WebCore::RenderSurfaceChromium::prepareContentsTexture):
  • platform/graphics/chromium/RenderSurfaceChromium.h:
  • platform/graphics/chromium/TextureManager.cpp: Removed.
  • platform/graphics/chromium/TextureManager.h: Removed.
  • platform/graphics/chromium/VideoLayerChromium.cpp: (WebCore::VideoLayerChromium::updateContents):
  • platform/graphics/chromium/VideoLayerChromium.h:
  • platform/graphics/chromium/WebGLLayerChromium.cpp: (WebCore::WebGLLayerChromium::updateContents):
  • platform/graphics/chromium/WebGLLayerChromium.h:
08:51 Changeset [72769] by jorlow@chromium.org
  • 3 edits in trunk/WebCore

2010-11-26 Jeremy Orlow <jorlow@chromium.org>

Unreviewed build fix.

  • storage/IDBIndex.cpp: (WebCore::IDBIndex::openCursor): (WebCore::IDBIndex::openKeyCursor):
  • storage/IDBObjectStore.cpp: (WebCore::IDBObjectStore::openCursor):
08:44 Changeset [72768] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-11-26 Sergio Villar Senin <svillar@igalia.com>

Reviewed by Xan Lopez.

[GTK] SoupCache should not ignore loader's conditional requests
https://bugs.webkit.org/show_bug.cgi?id=50101

SoupCache must not handle WebKit loader conditional requests and
thus should never return its own cached response if any. This was
causing frequent resource load failures as WebCore was trying to
revalidate its own resources and was not getting any expected
result.

  • platform/network/soup/cache/webkit/soup-cache.c: (webkit_soup_cache_has_response): check the presence of conditional request headers when deciding whether the cache has a valid response for a given request.
08:37 Changeset [72767] by jorlow@chromium.org
  • 20 edits in trunk

2010-11-26 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Steve Block.

Make IDBKeyRange match the spec
https://bugs.webkit.org/show_bug.cgi?id=50105

Remove flags and instead add two booleans for being open.
Change left to lower and right to upper everywhere.

  • storage/indexeddb/constants-expected.txt:
  • storage/indexeddb/constants.html:
  • storage/indexeddb/index-cursor.html:
  • storage/indexeddb/keyrange-expected.txt:
  • storage/indexeddb/keyrange.html:
  • storage/indexeddb/objectstore-cursor.html:
  • storage/indexeddb/open-cursor.html:
  • storage/indexeddb/tutorial.html:

2010-11-26 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Steve Block.

Make IDBKeyRange match the spec
https://bugs.webkit.org/show_bug.cgi?id=50105

Remove flags and instead add two booleans for being open.
Change left to lower and right to upper everywhere.

  • storage/IDBIndexBackendImpl.cpp: (WebCore::IDBIndexBackendImpl::openCursorInternal):
  • storage/IDBKey.cpp: (WebCore::IDBKey::lowerCursorWhereFragment): (WebCore::IDBKey::upperCursorWhereFragment):
  • storage/IDBKey.h:
  • storage/IDBKeyRange.cpp: (WebCore::IDBKeyRange::IDBKeyRange): (WebCore::IDBKeyRange::only): (WebCore::IDBKeyRange::lowerBound): (WebCore::IDBKeyRange::upperBound): (WebCore::IDBKeyRange::bound): (WebCore::IDBKeyRange::lowerWhereClauseComparisonOperator): (WebCore::IDBKeyRange::upperWhereClauseComparisonOperator):
  • storage/IDBKeyRange.h: (WebCore::IDBKeyRange::create): (WebCore::IDBKeyRange::lower): (WebCore::IDBKeyRange::upper): (WebCore::IDBKeyRange::lowerOpen): (WebCore::IDBKeyRange::upperOpen):
  • storage/IDBKeyRange.idl:
  • storage/IDBObjectStoreBackendImpl.cpp: (WebCore::IDBObjectStoreBackendImpl::openCursorInternal):

2010-11-26 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Steve Block.

Make IDBKeyRange match the spec
https://bugs.webkit.org/show_bug.cgi?id=50105

Remove flags and instead add two booleans for being open.
Change left to lower and right to upper everywhere.

  • public/WebIDBKeyRange.h: (WebKit::WebIDBKeyRange::WebIDBKeyRange):
  • src/WebIDBKeyRange.cpp: (WebKit::WebIDBKeyRange::assign): (WebKit::WebIDBKeyRange::left): (WebKit::WebIDBKeyRange::right): (WebKit::WebIDBKeyRange::lower): (WebKit::WebIDBKeyRange::upper): (WebKit::WebIDBKeyRange::lowerOpen): (WebKit::WebIDBKeyRange::upperOpen): (WebKit::WebIDBKeyRange::flags):
08:33 Changeset [72766] by jorlow@chromium.org
  • 17 edits in trunk

2010-11-25 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Steve Block.

Convert open*Cursor and createIndex over to using OptionsObject
https://bugs.webkit.org/show_bug.cgi?id=50093

  • storage/indexeddb/index-cursor.html:
  • storage/indexeddb/objectstore-basics-expected.txt:
  • storage/indexeddb/objectstore-basics.html:
  • storage/indexeddb/objectstore-cursor.html:
  • storage/indexeddb/open-cursor-expected.txt:
  • storage/indexeddb/open-cursor.html:
  • storage/indexeddb/tutorial.html:

2010-11-25 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Steve Block.

Convert open*Cursor and createIndex over to using OptionsObject
https://bugs.webkit.org/show_bug.cgi?id=50093

Add IDBKeyRange to OptionsObject's parsing abilities. Switch
more APIs over to using it.

  • bindings/v8/OptionsObject.cpp: (WebCore::OptionsObject::getKeyDOMStringList): (WebCore::OptionsObject::getKeyKeyRange):
  • bindings/v8/OptionsObject.h:
  • storage/IDBIndex.cpp: (WebCore::IDBIndex::openCursor): (WebCore::IDBIndex::openKeyCursor):
  • storage/IDBIndex.h: (WebCore::IDBIndex::openCursor): (WebCore::IDBIndex::openKeyCursor):
  • storage/IDBIndex.idl:
  • storage/IDBObjectStore.cpp: (WebCore::IDBObjectStore::createIndex): (WebCore::IDBObjectStore::openCursor):
  • storage/IDBObjectStore.h: (WebCore::IDBObjectStore::createIndex): (WebCore::IDBObjectStore::openCursor):
  • storage/IDBObjectStore.idl:
08:30 Changeset [72765] by jorlow@chromium.org
  • 24 edits
    2 moves
    2 adds in trunk

2010-11-25 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Steve Block.

Clean up IDBDatabase.transaction and add checks to IDBTransaction.objectStore
https://bugs.webkit.org/show_bug.cgi?id=50081

  • storage/indexeddb/create-and-remove-object-store-expected.txt: Renamed from LayoutTests/storage/indexeddb/createAndRemoveObjectStore-expected.txt.
  • storage/indexeddb/create-and-remove-object-store.html: Renamed from LayoutTests/storage/indexeddb/createAndRemoveObjectStore.html.
  • storage/indexeddb/create-object-store-options-expected.txt:
  • storage/indexeddb/create-object-store-options.html:
  • storage/indexeddb/resources/shared.js: (evalAndExpectException):
  • storage/indexeddb/transaction-and-objectstore-calls-expected.txt: Added.
  • storage/indexeddb/transaction-and-objectstore-calls.html: Added.
  • storage/indexeddb/tutorial.html:

2010-11-25 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Steve Block.

Clean up IDBDatabase.transaction and add checks to IDBTransaction.objectStore
https://bugs.webkit.org/show_bug.cgi?id=50081

IDBDatabase.transaction should use the new optional OptionsObject way
of taking optional paramters. Modify that object to get numbers and
domStringLists from it. Verify that any requested resources exist and
return an exception if not.

When IDBTransaction.objectStore is called, verify that it's one of the
requested resources. Also verify that it still exists. Plumb the
exception code to make this work.

Tests: storage/indexeddb/create-and-remove-object-store.html

storage/indexeddb/transaction-and-objectstore-calls.html

  • bindings/v8/OptionsObject.cpp: (WebCore::OptionsObject::getKeyInteger): (WebCore::OptionsObject::getKeyString): (WebCore::OptionsObject::getKeyDOMStringList):
  • bindings/v8/OptionsObject.h:
  • storage/IDBDatabase.cpp: (WebCore::IDBDatabase::createObjectStore): (WebCore::IDBDatabase::transaction):
  • storage/IDBDatabase.h: (WebCore::IDBDatabase::transaction):
  • storage/IDBDatabase.idl:
  • storage/IDBDatabaseBackendImpl.cpp: (WebCore::IDBDatabaseBackendImpl::transaction):
  • storage/IDBTransaction.cpp: (WebCore::IDBTransaction::objectStore):
  • storage/IDBTransactionBackendImpl.cpp: (WebCore::IDBTransactionBackendImpl::IDBTransactionBackendImpl): (WebCore::IDBTransactionBackendImpl::objectStore):
  • storage/IDBTransactionBackendImpl.h:
  • storage/IDBTransactionBackendInterface.h:

2010-11-25 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Steve Block.

Clean up IDBDatabase.transaction and add checks to IDBTransaction.objectStore
https://bugs.webkit.org/show_bug.cgi?id=50081

Plumb IDBTransaction.objectStore's exception code.

  • public/WebIDBTransaction.h: (WebKit::WebIDBTransaction::objectStore):
  • src/IDBDatabaseProxy.cpp: (WebCore::IDBDatabaseProxy::transaction):
  • src/IDBTransactionBackendProxy.cpp: (WebCore::IDBTransactionBackendProxy::objectStore):
  • src/IDBTransactionBackendProxy.h:
  • src/WebIDBDatabaseImpl.cpp: (WebKit::WebIDBDatabaseImpl::createObjectStore): (WebKit::WebIDBDatabaseImpl::transaction):
  • src/WebIDBTransactionImpl.cpp: (WebKit::WebIDBTransactionImpl::objectStore):
  • src/WebIDBTransactionImpl.h:
08:18 Changeset [72764] by mario@webkit.org
  • 5 edits in trunk

2010-11-26 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Xan Lopez.

[GTK] events missing when a document is (re)loaded
https://bugs.webkit.org/show_bug.cgi?id=25831

Make sure webArea returns a proper name and that a signal
'state-change::defunct' is emitted when detaching the wrapper.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_get_name): Returns the current document's title as fallback mechanism for webArea objects. (webkit_accessible_detach): Emit 'state-change::defunct' function as soon as the wrapper is detached from the related core object.

2010-11-26 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Xan Lopez.

[GTK] events missing when a document is (re)loaded
https://bugs.webkit.org/show_bug.cgi?id=25831

Emit the right signals when reloading a document.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::notifyAccessibilityStatus): New function, to make sure the signals involved in reloading a document are properly emitted. (WebKit::notifyStatus): Also notify accessibility if enabled.

New unit test to check the signals are being actually emitted.

  • tests/testatk.c: (stateChangedCb): Callback for 'state-change' signal emitted by the accessible object associated to the webView. (documentReloadCb): Callback for 'reload' signal. (documentLoadCompleteCb): Callback for 'load-complete' signal. (webviewLoadStatusChangedCb): Callback for 'notify::load-status' signal, emitted by the WebKitWebView object (not the AtkObject). (testWebkitAtkDocumentReloadEvents): New unit test. (main): Added the new unit test.
08:01 Changeset [72763] by loislo@chromium.org
  • 2 edits in trunk/LayoutTests

2010-11-26 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed fix for chromium test expectations.
fast/canvas/canvas-createPattern-fillRect-shadow.html was disabled
for Win and Linux.

  • platform/chromium/test_expectations.txt: added: BUGWK50112 WIN LINUX : fast/canvas/canvas-createPattern-fillRect-shadow.html = TEXT
07:52 Changeset [72762] by commit-queue@webkit.org
  • 3 edits in trunk/WebCore

2010-11-26 Sergio Villar Senin <svillar@igalia.com>

Reviewed by Xan Lopez.

[Gtk] ASSERT(d->m_response.isNull()) in contentSniffedCallback
https://bugs.webkit.org/show_bug.cgi?id=50083

ResourceHandleSoup should not listen to content-sniffed signal
when content sniffing is not enabled. This will prevent us
reaching an assertion on content-sniffed callback

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::startHttp):
  • platform/network/soup/cache/soup-request-http.c: (conditional_get_ready_cb): added a comment with the possible fix for a pure libsoup HTTP cache. (send_async_cb): prevent an early object finalization adding a reference. (webkit_soup_request_http_send_async): Ditto.
07:36 Changeset [72761] by reni@webkit.org
  • 3 edits in trunk/WebCore

[Qt] Remove empty ScrollView::platformInit/platformDestroy
https://bugs.webkit.org/show_bug.cgi?id=50079

Reviewed by Antonio Gomes.

No new test is needed.

  • platform/ScrollView.cpp:

(WebCore::ScrollView::wheelEvent):

  • platform/qt/ScrollViewQt.cpp:
06:59 Changeset [72760] by hans@chromium.org
  • 3 edits in trunk/LayoutTests

2010-11-26 Hans Wennborg <hans@chromium.org>

Reviewed by Jeremy Orlow.

IndexedDB: Test inserting invalid values in object store
https://bugs.webkit.org/show_bug.cgi?id=50110

Add tests to make sure we throw exceptions when a user tries
to insert invalid data in the object store.

  • storage/indexeddb/objectstore-basics-expected.txt:
  • storage/indexeddb/objectstore-basics.html:
06:54 Changeset [72759] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2010-11-26 Pavel Feldman <pfeldman@chromium.org>

Not reviewed. Fixing inspector tests.

  • inspector/front-end/Resource.js: (WebInspector.Resource.prototype.set timing):
04:51 Changeset [72758] by pfeldman@chromium.org
  • 7 edits in trunk/WebCore

2010-11-25 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: UI polish for Network and Resources panels.
https://bugs.webkit.org/show_bug.cgi?id=50100

  • Fixed timing inconsistencies
  • Made grid user-selectable
  • Selection in network panel is made on name column only
  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel): (WebInspector.NetworkPanel.prototype._toggleGridMode): (WebInspector.NetworkDataGridNode.prototype.createCells): (WebInspector.NetworkDataGridNode.prototype.select): (WebInspector.NetworkDataGridNode.prototype.get selectable): (WebInspector.NetworkDataGridNode.prototype._createTimelineCell): (WebInspector.NetworkDataGridNode.prototype.refreshGraph): (WebInspector.NetworkDataGridNode.prototype._refreshLabelPositions):
  • inspector/front-end/Popover.js: (WebInspector.PopoverHelper): (WebInspector.PopoverHelper.prototype.setTimeout): (WebInspector.PopoverHelper.prototype._mouseMove): (WebInspector.PopoverHelper.prototype._handleMouseAction):
  • inspector/front-end/Resource.js: (WebInspector.Resource.prototype.get responseReceivedTime): (WebInspector.Resource.prototype.set endTime): (WebInspector.Resource.prototype.set timing):
  • inspector/front-end/ResourceManager.js: (WebInspector.ResourceManager.prototype.didReceiveResponse): (WebInspector.ResourceManager.prototype.didFinishLoading):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.FrameResourceTreeElement.prototype._ondragstart):
  • inspector/front-end/networkPanel.css: (.network-sidebar .data-grid td:not(.network-summary)): (.network-sidebar .data-grid td.name-column): (.network.panel:not(.viewing-resource) .network-sidebar td.name-column:hover): (.network-timing-row): (.network-timing-bar): (.network-timing-bar-title): (.resource-timing-view):
03:52 Changeset [72757] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

2010-11-26 Helder Correia <helder@sencha.com>

Reviewed by Ariya Hidayat.

[Qt] Blur shadow for rectangle fill
https://bugs.webkit.org/show_bug.cgi?id=44488

New fast canvas test to ensure fillRect shadow (with and without blur).

  • fast/canvas/canvas-fillRect-shadow-expected.txt: Added.
  • fast/canvas/canvas-fillRect-shadow.html: Added.
  • fast/canvas/script-tests/canvas-fillRect-shadow.js: Added.

2010-11-26 Helder Correia <helder@sencha.com>

Reviewed by Ariya Hidayat.

[Qt] Blur shadow for rectangle fill
https://bugs.webkit.org/show_bug.cgi?id=44488

Shadow color opacity needs to be set when blurring shadow with
ContextShadow.

Test: fast/canvas/canvas-fillRect-shadow.html

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::fillRect):
03:25 Changeset [72756] by commit-queue@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

2010-11-26 Helder Correia <helder@sencha.com>

Reviewed by Kenneth Rohde Christiansen.

New fast canvas test: createPattern + fillRect with shadow
https://bugs.webkit.org/show_bug.cgi?id=50104

Ensure that fillRect works correctly with an image pattern with
transparency set as the fillStyle.

  • fast/canvas/canvas-createPattern-fillRect-shadow-expected.txt: Added.
  • fast/canvas/canvas-createPattern-fillRect-shadow.html: Added.
  • fast/canvas/script-tests/canvas-createPattern-fillRect-shadow.js: Added.
03:21 Changeset [72755] by caseq@chromium.org
  • 2 edits in trunk/LayoutTests

2010-11-25 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: LayoutTest/inspector/extnesions.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=50076

  • inspector/extensions-test.js: (initialize_ExtensionsTest.dumpSidebarContent):
03:03 Changeset [72754] by hans@chromium.org
  • 24 edits in trunk

2010-11-26 Hans Wennborg <hans@chromium.org>

Reviewed by Jeremy Orlow.

IndexedDB: Rename IDBDatabase.objectStores to objectStoreNames
https://bugs.webkit.org/show_bug.cgi?id=50102

Update layout tests to use the new name.

  • storage/indexeddb/database-basics-expected.txt:
  • storage/indexeddb/database-basics.html:
  • storage/indexeddb/database-quota-expected.txt:
  • storage/indexeddb/database-quota.html:
  • storage/indexeddb/objectstore-basics-expected.txt:
  • storage/indexeddb/objectstore-basics.html:
  • storage/indexeddb/resources/shared.js: (deleteAllObjectStores):
  • storage/indexeddb/transaction-basics-expected.txt:
  • storage/indexeddb/transaction-basics.html:
  • storage/indexeddb/tutorial.html:

2010-11-26 Hans Wennborg <hans@chromium.org>

Reviewed by Jeremy Orlow.

IndexedDB: Rename IDBDatabase.objectStores to objectStoreNames
https://bugs.webkit.org/show_bug.cgi?id=50102

Rename as per the spec: http://dvcs.w3.org/hg/IndexedDB/raw-file/tip/Overview.html#database-interface

  • manual-tests/indexeddb-persists.html:
  • storage/IDBDatabase.h: (WebCore::IDBDatabase::objectStoreNames):
  • storage/IDBDatabase.idl:
  • storage/IDBDatabaseBackendImpl.cpp: (WebCore::IDBDatabaseBackendImpl::objectStoreNames): (WebCore::IDBDatabaseBackendImpl::setVersion): (WebCore::IDBDatabaseBackendImpl::transaction):
  • storage/IDBDatabaseBackendImpl.h:
  • storage/IDBDatabaseBackendInterface.h:

2010-11-26 Hans Wennborg <hans@chromium.org>

Reviewed by Jeremy Orlow.

IndexedDB: Rename IDBDatabase.objectStores to objectStoreNames
https://bugs.webkit.org/show_bug.cgi?id=50102

Rename as per the spec: http://dvcs.w3.org/hg/IndexedDB/raw-file/tip/Overview.html#database-interface

  • public/WebIDBDatabase.h: (WebKit::WebIDBDatabase::objectStores): (WebKit::WebIDBDatabase::objectStoreNames):
  • src/IDBDatabaseProxy.cpp: (WebCore::IDBDatabaseProxy::objectStoreNames):
  • src/IDBDatabaseProxy.h:
  • src/WebIDBDatabaseImpl.cpp: (WebKit::WebIDBDatabaseImpl::objectStoreNames):
  • src/WebIDBDatabaseImpl.h:
02:52 Changeset [72753] by andreip@google.com
  • 48 edits in trunk

Remove description

11/25/10:

22:47 Changeset [72752] by yuzo@google.com
  • 2 edits in trunk/LayoutTests

2010-11-25 Yuzo Fujishima <yuzo@google.com>

Unreviewed Chromium test expectaion change.
fast/css/font-face-data-uri.html now passes for WIN and LINUX.

  • platform/chromium/test_expectations.txt:
21:37 Changeset [72751] by yuzo@google.com
  • 2 edits in trunk/LayoutTests

2010-11-25 Yuzo Fujishima <yuzo@google.com>

Unreviewed attempt to fix test falkiness.

  • fast/css/font-face-data-uri.html:
20:54 Changeset [72750] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

2010-11-25 Kenichi Ishibashi <bashi@google.com>

Reviewed by Kent Tamura.

Assertion failure by resetting <output> twice
https://bugs.webkit.org/show_bug.cgi?id=50095

Adds a test that ensures assertion failures don't occur when
updating the value of an output element.

  • fast/forms/output-reset-assertion-failed-expected.txt: Added.
  • fast/forms/output-reset-assertion-failed.html: Added.
  • fast/forms/script-tests/output-reset-assertion-failed.js: Added.

2010-11-25 Kenichi Ishibashi <bashi@google.com>

Reviewed by Kent Tamura.

Assertion failure by resetting <output> twice
https://bugs.webkit.org/show_bug.cgi?id=50095

Don't call setTextContentInternal() when the value wouldn't
be changed.

Test: fast/forms/output-reset-assertion-failed.html

  • html/HTMLOutputElement.cpp: (WebCore::HTMLOutputElement::HTMLOutputElement): Calls setTextContentInternal() if and only if needed. (WebCore::HTMLOutputElement::reset): Ditto. (WebCore::HTMLOutputElement::setValue): Ditto. (WebCore::HTMLOutputElement::setDefaultValue): Ditto.
19:52 Changeset [72749] by yuzo@google.com
  • 2 edits in trunk/LayoutTests

2010-11-25 Yuzo Fujishima <yuzo@google.com>

Reviewed by Kent Tamura.

Fix for Bug 49898 - LayoutTests/fast/css/font-face-data-uri.html doesn't test what it claims to
https://bugs.webkit.org/show_bug.cgi?id=49898

  • fast/css/font-face-data-uri.html: Use local font as reference. Use polling to ensure that the web font is loaded.
18:02 WinCE edited by paroga@webkit.org
(diff)
17:23 cmake-2.8.3-ce-win32-x86-diff.zip attached to WinCE by paroga@webkit.org
CMake 2.3.8 with WinCE support
16:36 Changeset [72748] by rniwa@webkit.org
  • 3 edits
    2 adds in trunk

2010-11-24 Ryosuke Niwa <rniwa@webkit.org>

Crash when moving caret around a word with a first-letter rule and whitespace is not collapsible.
https://bugs.webkit.org/show_bug.cgi?id=49652

Fixed the crash by giving the correct end offset to emitText in handleTextNode.

This patch does not fix a bug in TextIterator that incorrectly calculates
the end offset of a word with a first-letter rule as demonstrated in the layout test
because fixing the bug requires an overhaul of TextIterator and new behavior is consistent
with the case when whitespace is collapsible.

Test: editing/text-iterator/first-letter-word-boundary.html

  • editing/TextIterator.cpp: (WebCore::TextIterator::handleTextNode):

2010-11-24 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Kent Tamura.

Added a test to ensure WebKit does not crash when moving carets around a word
with a first-letter rule. While WebKit no longer crashes, the test demonstrates a bug
that the position offset at the end of word is incorrect.

  • editing/text-iterator/first-letter-word-boundary-expected.txt: Added.
  • editing/text-iterator/first-letter-word-boundary.html: Added.
16:22 Changeset [72747] by commit-queue@webkit.org
  • 4 edits in trunk/WebCore

2010-11-25 Mike Lawther <mikelawther@chromium.org>

Reviewed by Kent Tamura.

Fix typos in CSS grammar (HERZ -> HERTZ)
https://bugs.webkit.org/show_bug.cgi?id=50094

  • css/CSSGrammar.y:
  • css/CSSParser.cpp: (WebCore::CSSParser::lex):
  • css/tokenizer.flex:
12:40 Changeset [72746] by loislo@chromium.org
  • 4 edits in trunk

2010-11-25 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed. Enable test for Win Release chromuim.

  • platform/chromium/test_expectations.txt: changed: BUGWK46940 WIN DEBUG : fast/dom/Window/window-screen-properties.html = TEXT

2010-11-25 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed. Roll chromium 67004:67404.

  • DEPS:
12:33 Changeset [72745] by tonikitoo@webkit.org
  • 2 edits in trunk/WebKit/gtk

2010-11-25 Antonio Gomes <agomes@rim.com>

Unreviewed build fix for GTK+ when --release and -no-video are passed to build-webkit

Build problem with --gtk --no-video
https://bugs.webkit.org/show_bug.cgi?id=50003

Patch suggested by Philippe Normand <pnormand@igalia.com>.

  • WebCoreSupport/ChromeClientGtk.cpp:
  • webkit/webkitprivate.cpp:
12:31 Changeset [72744] by tonikitoo@webkit.org
  • 4 edits in trunk

Revertted accidentally committed code in r72742

12:29 Changeset [72743] by antti@apple.com
  • 6 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=50078
Simplify CachedResource error handling code by getting rid of the m_httpStatusCodeErrorOccurred boolean.

Reviewed by Dan Bernstein.

  • loader/cache/CachedImage.cpp:

(WebCore::CachedImage::CachedImage):

  • loader/cache/CachedImage.h:

(WebCore::CachedImage::shouldIgnoreHTTPStatusCodeErrors):

  • loader/cache/CachedResource.h:

(WebCore::CachedResource::shouldIgnoreHTTPStatusCodeErrors):
(WebCore::CachedResource::httpStatusCodeErrorOccurred):

  • loader/loader.cpp:

(WebCore::Loader::didReceiveData):

12:25 Changeset [72742] by tonikitoo@webkit.org
  • 4 edits in trunk

martin

11:37 Changeset [72741] by andreas.kling@nokia.com
  • 2 edits in trunk/WebCore

2010-11-25 Andreas Kling <kling@webkit.org>

Reviewed by Tor Arne Vestbø.

[Qt] Remove unnecessary save/restore in GraphicsContext::drawConvexPolygon()
https://bugs.webkit.org/show_bug.cgi?id=50085

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::drawConvexPolygon): Remember the previous antialiasing mode and reset it after we're done.
10:36 Changeset [72740] by benm@google.com
  • 3 edits in trunk/WebCore

2010-11-25 Ben Murdoch <benm@google.com>

Reviewed by Steve Block.

Potential crash in JavaClassV8.cpp
https://bugs.webkit.org/show_bug.cgi?id=50016

It is possible that we attempt to free uninitialised
memory in the JavaClass destrctor when using V8 in the
case that the JVM could not find the class in the constructor.

It turns out that the troublesome m_name is not acutally
used anywhere, so we remove it in this patch.

No new tests, just removing dead code.

  • bridge/jni/v8/JavaClassV8.cpp: Remove unused m_name.
  • bridge/jni/v8/JavaClassV8.h: Ditto.
10:21 Changeset [72739] by andreas.kling@nokia.com
  • 2 edits in trunk/WebKit/qt

2010-11-25 Norbert Leser <norbert.leser@nokia.com>

Reviewed by Laszlo Gombos.

Updated Symbian DEF file for ARM target due to API changes
via committs r72600-72603 (see bug# 46810)

  • symbian/eabi/QtWebKitu.def:
10:18 Changeset [72738] by hans@chromium.org
  • 8 edits in trunk

2010-11-25 Hans Wennborg <hans@chromium.org>

Reviewed by Jeremy Orlow.

IndexedDB: Better errors for not yet implemented features
https://bugs.webkit.org/show_bug.cgi?id=50075

Test that inserting a record where the key is a Date (either
explicitly, or via a key path) yields an error.

Test that calling createObjectStore with autoIncrement = true
raises an exception.

  • storage/indexeddb/create-object-store-options-expected.txt:
  • storage/indexeddb/create-object-store-options.html:
  • storage/indexeddb/objectstore-basics-expected.txt:
  • storage/indexeddb/objectstore-basics.html:

2010-11-25 Hans Wennborg <hans@chromium.org>

Reviewed by Jeremy Orlow.

IndexedDB: Better errors for not yet implemented features
https://bugs.webkit.org/show_bug.cgi?id=50075

Raise an exception if createObjectStore is called with autoIncrement
set to true.

Be a little bit more explicit in IDBBindingUtilities that we don't
allow using Date objects as keys yet.

  • bindings/v8/IDBBindingUtilities.cpp: (WebCore::createIDBKeyFromValue):
  • storage/IDBDatabase.cpp: (WebCore::IDBDatabase::createObjectStore):
  • storage/IDBObjectStoreBackendImpl.cpp: (WebCore::IDBObjectStoreBackendImpl::putInternal):
10:01 Changeset [72737] by pfeldman@chromium.org
  • 7 edits in trunk/WebCore

2010-11-25 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: highlight diffs of revisions against base version.
https://bugs.webkit.org/show_bug.cgi?id=50088

  • inspector/front-end/CSSStyleModel.js: (WebInspector.CSSStyleModel.prototype._styleSheetChanged.callback): (WebInspector.CSSStyleModel.prototype._styleSheetChanged):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel): (WebInspector.ResourcesPanel.prototype.show): (WebInspector.ResourcesPanel.prototype._showResourceView.callback): (WebInspector.ResourcesPanel.prototype._showResourceView): (WebInspector.ResourcesPanel.prototype._applyDiffMarkup): (WebInspector.FrameResourceTreeElement.prototype._contentChanged):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype.markDiff): (WebInspector.SourceFrame.prototype._createViewerIfNeeded): (WebInspector.SourceFrame.prototype._updateDiffDecorations.addDecorations): (WebInspector.SourceFrame.prototype._updateDiffDecorations): (WebInspector.SourceFrame.prototype._removeDiffDecorations):
  • inspector/front-end/SourceView.js:
  • inspector/front-end/textViewer.css: (.webkit-line-number): (.diff-container .webkit-added-line .webkit-line-content): (.diff-container .webkit-removed-line .webkit-line-content): (.diff-container .webkit-changed-line .webkit-line-content):
  • inspector/front-end/utilities.js:
09:50 Changeset [72736] by commit-queue@webkit.org
  • 4 edits in trunk/WebCore

2010-11-25 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r72732.
http://trac.webkit.org/changeset/72732
https://bugs.webkit.org/show_bug.cgi?id=50089

Made Qt bot sad and crashy (Requested by Ossy on #webkit).

  • platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
  • platform/network/qt/QNetworkReplyHandler.h:
  • platform/network/qt/ResourceHandleQt.cpp: (WebCore::WebCoreSynchronousLoader::didFinishLoading): (WebCore::WebCoreSynchronousLoader::didFail): (WebCore::ResourceHandle::loadResourceSynchronously):
09:17 Changeset [72735] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-11-25 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r72734.
http://trac.webkit.org/changeset/72734
https://bugs.webkit.org/show_bug.cgi?id=50086

Backing out 72732 which made Qt sad and crashy (Requested by
kling on #webkit).

  • platform/network/qt/ResourceHandleQt.cpp: (WebCore::ResourceHandle::loadResourceSynchronously):
08:51 Changeset [72734] by andreas.kling@nokia.com
  • 2 edits in trunk/WebCore

2010-11-25 Andreas Kling <kling@webkit.org>

Unreviewed crash fix for Qt 4.6.x.

Check that QNetworkReplyHandler::reply() doesn't return null before
using it (this code needs to work for Qt 4.6 as well.)

  • platform/network/qt/ResourceHandleQt.cpp: (WebCore::ResourceHandle::loadResourceSynchronously):
08:37 Changeset [72733] by commit-queue@webkit.org
  • 11 edits in trunk/WebCore

2010-11-25 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r72727.
http://trac.webkit.org/changeset/72727
https://bugs.webkit.org/show_bug.cgi?id=50084

Broke dom-breakpoints test on chromium win (Requested by
podivilov on #webkit).

  • inspector/InspectorController.cpp: (WebCore::InspectorController::setNativeBreakpoint):
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::InspectorDOMAgent): (WebCore::InspectorDOMAgent::discardBindings): (WebCore::InspectorDOMAgent::setDOMBreakpoint): (WebCore::InspectorDOMAgent::removeDOMBreakpoint): (WebCore::InspectorDOMAgent::descriptionForDOMEvent): (WebCore::InspectorDOMAgent::removeBreakpointsForNode): (WebCore::InspectorDOMAgent::createBreakpointId):
  • inspector/InspectorDOMAgent.h:
  • inspector/front-end/BreakpointManager.js: (WebInspector.BreakpointManager.prototype.reset): (WebInspector.BreakpointManager.prototype.createDOMBreakpoint): (WebInspector.BreakpointManager.prototype._updateNativeBreakpointsInSettings): (WebInspector.BreakpointManager.prototype.restoreBreakpoints): (WebInspector.BreakpointManager.prototype.restoreDOMBreakpoints): (WebInspector.DOMBreakpoint): (WebInspector.DOMBreakpoint.prototype.populateLabelElement): (WebInspector.EventListenerBreakpoint): (WebInspector.XHRBreakpoint):
  • inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.BreakpointsSidebarPane): (WebInspector.BreakpointsSidebarPane.prototype.reset): (WebInspector.EventListenerBreakpointsSidebarPane): (WebInspector.EventListenerBreakpointsSidebarPane.prototype.reset):
  • inspector/front-end/DOMAgent.js: (WebInspector.DOMAgent.prototype._setDocument):
  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.reset):
  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype._populateTagContextMenu.handlerFunction): (WebInspector.ElementsTreeElement.prototype._populateTagContextMenu):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.reset):
  • inspector/front-end/inspector.js: (WebInspector.reset): (WebInspector.didCommitLoad):
08:19 Changeset [72732] by commit-queue@webkit.org
  • 4 edits in trunk/WebCore

2010-11-25 Peter Hartmann <peter.hartmann@nokia.com>

Reviewed by Andreas Kling.

[Qt] enable usage of synchronous HTTP feature in Qt
https://bugs.webkit.org/show_bug.cgi?id=37191

Currently, we spin an event loop when doing synchronous calls to
wait for completion. This patch uses synchronous requests in Qt,
if available, and spins the event loop as a fallback solution.
Patch by Simon Hausmann and Peter Hartmann.

  • platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
  • platform/network/qt/QNetworkReplyHandler.h:
  • platform/network/qt/ResourceHandleQt.cpp: (WebCore::WebCoreSynchronousLoader::setReplyFinished): (WebCore::WebCoreSynchronousLoader::WebCoreSynchronousLoader): (WebCore::WebCoreSynchronousLoader::didFinishLoading): (WebCore::WebCoreSynchronousLoader::didFail): (WebCore::WebCoreSynchronousLoader::waitForCompletion): (WebCore::ResourceHandle::loadResourceSynchronously):
06:40 Changeset [72731] by hans@chromium.org
  • 2 edits in trunk/WebCore

2010-11-25 Hans Wennborg <hans@chromium.org>

Reviewed by Jeremy Orlow.

V8 Bindings: remove faulty include in OptionsObject.h
https://bugs.webkit.org/show_bug.cgi?id=50073

There is no <wtf/NonCopyable.h>, and the code doesn't try to use it
either.

No new functionality, no new tests.

  • bindings/v8/OptionsObject.h:
06:36 Changeset [72730] by kenneth@webkit.org
  • 2 edits in trunk/WebCore

2010-11-25 Kenneth Rohde Christiansen <kenneth@webkit.org>

Reviewed by Simon Hausmann.

Actually handle targetDensityDpi in computeViewportAttributes
https://bugs.webkit.org/show_bug.cgi?id=50068

  • dom/ViewportArguments.cpp: (WebCore::computeViewportAttributes):
06:11 Changeset [72729] by loislo@chromium.org
  • 2 edits in trunk/LayoutTests

2010-11-25 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed. Enable tests in chromium.
5109817.html was fixed upstream r72678.
validationMessage was fixed downstream r67382.

  • platform/chromium/test_expectations.txt: removed: BUG10369 MAC : editing/selection/5109817.html = FAIL removed: BUG28264 : fast/forms/validationMessage.html = FAIL
06:05 Changeset [72728] by jorlow@chromium.org
  • 24 edits
    1 copy
    4 adds in trunk

2010-11-25 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Steve Block.

Add an OptionsObject class for IndexedDB (and later Geolocation)
https://bugs.webkit.org/show_bug.cgi?id=50030

  • storage/indexeddb/create-object-store-options-expected.txt: Added.
  • storage/indexeddb/create-object-store-options.html: Added.
  • storage/indexeddb/tutorial.html:

2010-11-25 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Steve Block.

Add an OptionsObject class for IndexedDB (and later Geolocation)
https://bugs.webkit.org/show_bug.cgi?id=50030

Geolocation and IndexedDB both have the concept of an optional
parameter that has various options supplied with it. In
Geolocation this was done with custom bindings, but I'm trying to
avoid that for IndexedDB.

This first patch implements it in V8 and makes createObjectStore use it.
The next patch will cover Geolocation and JSC.

Test: storage/indexeddb/create-object-store-options.html

  • WebCore.gypi:
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/scripts/test/CPP/WebDOMTestObj.cpp: (WebDOMTestObj::optionsObject):
  • bindings/scripts/test/CPP/WebDOMTestObj.h:
  • bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListener.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: (webkit_dom_test_obj_options_object):
  • bindings/scripts/test/GObject/WebKitDOMTestObj.h:
  • bindings/scripts/test/JS/JSTestObj.cpp: (WebCore::jsTestObjPrototypeFunctionOptionsObject):
  • bindings/scripts/test/JS/JSTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.mm: (-[DOMTestObj optionsObject:ooo:]):
  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp: (WebCore::ConfigureV8TestMediaQueryListListenerTemplate):
  • bindings/scripts/test/V8/V8TestObj.cpp: (WebCore::TestObjInternal::optionsObjectCallback):
  • bindings/v8/OptionsObject.cpp: Added. (WebCore::OptionsObject::OptionsObject): (WebCore::OptionsObject::~OptionsObject): (WebCore::OptionsObject::operator=): (WebCore::OptionsObject::undefinedOrNull): (WebCore::OptionsObject::getKeyBool): (WebCore::OptionsObject::getKeyString): (WebCore::OptionsObject::getKey):
  • bindings/v8/OptionsObject.h:
  • bindings/js/OptionsObject.h:
  • storage/IDBDatabase.cpp: (WebCore::IDBDatabase::createObjectStore):
  • storage/IDBDatabase.h: (WebCore::IDBDatabase::createObjectStore):
  • storage/IDBDatabase.idl:

2010-11-25 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Steve Block.

Add exception code to WebIDBTransaction::objectStore
https://bugs.webkit.org/show_bug.cgi?id=50030

  • public/WebIDBTransaction.h: (WebKit::WebIDBTransaction::objectStore):
05:56 Changeset [72727] by podivilov@chromium.org
  • 11 edits in trunk/WebCore

2010-11-24 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: set DOM breakpoints by path.
https://bugs.webkit.org/show_bug.cgi?id=50017

This change is needed to be able to push DOM breakpoints for all URL's to backend
at frontend load.

  • inspector/InspectorController.cpp: (WebCore::InspectorController::setNativeBreakpoint):
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::InspectorDOMAgent): (WebCore::InspectorDOMAgent::discardBindings): (WebCore::InspectorDOMAgent::setDOMBreakpoint): (WebCore::InspectorDOMAgent::removeDOMBreakpoint): (WebCore::InspectorDOMAgent::descriptionForDOMEvent): (WebCore::InspectorDOMAgent::removeBreakpointsForNode):
  • inspector/InspectorDOMAgent.h:
  • inspector/front-end/BreakpointManager.js: (WebInspector.BreakpointManager.prototype.reset): (WebInspector.BreakpointManager.prototype.createDOMBreakpoint): (WebInspector.BreakpointManager.prototype._updateNativeBreakpointsInSettings): (WebInspector.BreakpointManager.prototype.restoreBreakpoints): (WebInspector.DOMBreakpoint): (WebInspector.DOMBreakpoint.prototype._setNodeId): (WebInspector.DOMBreakpoint.prototype.populateLabelElement): (WebInspector.EventListenerBreakpoint): (WebInspector.XHRBreakpoint):
  • inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.BreakpointsSidebarPane): (WebInspector.BreakpointsSidebarPane.prototype._reset): (WebInspector.EventListenerBreakpointsSidebarPane): (WebInspector.EventListenerBreakpointsSidebarPane.prototype._reset):
  • inspector/front-end/DOMAgent.js: (WebInspector.DOMAgent.prototype._setDocument):
  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.reset):
  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype._populateTagContextMenu.handlerFunction): (WebInspector.ElementsTreeElement.prototype._populateTagContextMenu):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.reset):
  • inspector/front-end/inspector.js: (WebInspector.reset): (WebInspector.didCommitLoad):
05:40 Changeset [72726] by andreas.kling@nokia.com
  • 4 edits in trunk/WebKit/qt

2010-11-25 Kenneth Rohde Christiansen <kenneth@webkit.org>

Reviewed by Andreas Kling and Simon Hausmann.

[Qt] Calculate the -webkit-pixel-radio using the device DPI.
http://webkit.org/b/50059

Also, update the documentation on what a DIP is and how to override
the device DPI in the case the system reports the wrong one (which
unfortunately is common on X11).

  • Api/qwebpage.cpp: (QWebPagePrivate::QWebPagePrivate): (QWebPage::viewportAttributesForSize):
  • Api/qwebpage_p.h:
  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::scaleFactor):
05:21 Changeset [72725] by pfeldman@chromium.org
  • 5 edits in trunk/WebCore

2010-11-25 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: reuse code for recreating resource views.
https://bugs.webkit.org/show_bug.cgi?id=50066

  • inspector/front-end/NetworkItemView.js: (WebInspector.NetworkItemView):
  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype.refreshResource):
  • inspector/front-end/ResourceManager.js: (WebInspector.ResourceManager.resourceViewTypeMatchesResource): (WebInspector.ResourceManager.resourceViewForResource): (WebInspector.ResourceManager.recreateResourceView):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.FrameResourceTreeElement.prototype._contentChanged):
02:09 Changeset [72724] by loislo@chromium.org
  • 2 edits in trunk/LayoutTests

2010-11-25 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed. Upstream chromium test expectations.

BUGCR64401 WIN : fast/filesystem/op-copy.html = TEXT
was added.

  • platform/chromium/test_expectations.txt:
02:04 Changeset [72723] by hans@chromium.org
  • 8 edits in trunk

2010-11-25 Hans Wennborg <hans@chromium.org>

Reviewed by Jeremy Orlow.

IndexedDB: Disallow inserting records with NULL keys
https://bugs.webkit.org/show_bug.cgi?id=50033

Test inserting records with NULL key and make sure it fails.

Update layout tests that previously inserted NULL keys.

  • storage/indexeddb/index-cursor.html:
  • storage/indexeddb/objectstore-basics-expected.txt:
  • storage/indexeddb/objectstore-basics.html:
  • storage/indexeddb/objectstore-cursor.html:

2010-11-25 Hans Wennborg <hans@chromium.org>

Reviewed by Jeremy Orlow.

IndexedDB: Disallow inserting records with NULL keys
https://bugs.webkit.org/show_bug.cgi?id=50033

Disallow inserting records with null keys into the object store.

  • storage/IDBKey.h:
  • storage/IDBObjectStoreBackendImpl.cpp: (WebCore::IDBObjectStoreBackendImpl::putInternal):
01:38 Changeset [72722] by philn@webkit.org
  • 3 edits in trunk/WebCore

2010-11-25 Philippe Normand <pnormand@igalia.com>

Rubber-stamped by Xan Lopez.

g_signal_accumulator_first_wins was introduced in glib 2.27.1 so
no need to use our version if that version of glib is used during
the build.

  • platform/gtk/GtkVersioning.c:
  • platform/gtk/GtkVersioning.h:
Note: See TracTimeline for information about the timeline view.