Timeline


and

12/25/10:

21:05 Changeset [74664] by kbr@google.com

2010-12-25 Kenneth Russell <kbr@google.com>

Unreviewed, Chromium test expectations update.

  • platform/chromium-gpu/test_expectations.txt: Win Debug: Marked compositing/tiling/huge-layer-img.html as TIMEOUT. Marked fast/canvas/webgl/gl-object-get-calls.html as a flaky crash.
  • platform/chromium/test_expectations.txt: Adjusted expectations for the following tests: fast/canvas/shadow-offset-7.html svg/batik/paints/gradientLimit.svg fast/events/touch/touch-target.html canvas/philip/tests/2d.gradient.radial.cone.top.html fast/css/box-shadow.html
17:49 Changeset [74663] by commit-queue@webkit.org

2010-12-25 Peter Rybin <peter.rybin@gmail.com>

Reviewed by Adam Barth.

Adds currentColumn (and currentLine) to SegmentedString. Switches
HTMLTreeBuilder to HTMLDocumentParser::textPosition when it
needs position for a <script> tag.

SegmentedString should provide column position
https://bugs.webkit.org/show_bug.cgi?id=51311

  • html/parser/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::HTMLDocumentParser): (WebCore::HTMLDocumentParser::textPosition):
  • html/parser/HTMLInputStream.h: (WebCore::HTMLInputStream::current): (WebCore::InsertionPointRecord::InsertionPointRecord): (WebCore::InsertionPointRecord::~InsertionPointRecord):
  • html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::HTMLTreeBuilder): (WebCore::HTMLTreeBuilder::processScriptStartTag):
  • html/parser/HTMLTreeBuilder.h: (WebCore::HTMLTreeBuilder::create):
  • platform/text/SegmentedString.cpp: (WebCore::SegmentedString::operator=): (WebCore::SegmentedString::numberOfCharactersConsumedSlow): (WebCore::SegmentedString::advanceSlowCase): (WebCore::SegmentedString::currentLine): (WebCore::SegmentedString::currentColumn): (WebCore::SegmentedString::setCurrentPosition):
  • platform/text/SegmentedString.h: (WebCore::SegmentedString::SegmentedString): (WebCore::SegmentedString::advancePastNewline): (WebCore::SegmentedString::advance): (WebCore::SegmentedString::numberOfCharactersConsumed):
16:38 Changeset [74662] by commit-queue@webkit.org

2010-12-25 Andreas Kling <kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

GraphicsContext: Don't pass StrokeStyle (enum) as const reference
https://bugs.webkit.org/show_bug.cgi?id=51608

  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::setStrokeStyle): (WebCore::GraphicsContext::setPlatformStrokeStyle): (WebCore::GraphicsContext::adjustLineToPixelBoundaries):
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::setPlatformStrokeStyle):
  • platform/graphics/haiku/GraphicsContextHaiku.cpp: (WebCore::GraphicsContext::setPlatformStrokeStyle):
  • platform/graphics/openvg/GraphicsContextOpenVG.cpp: (WebCore::GraphicsContext::setPlatformStrokeStyle):
  • platform/graphics/openvg/PainterOpenVG.cpp: (WebCore::PainterOpenVG::setStrokeStyle):
  • platform/graphics/openvg/PainterOpenVG.h:
  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::setPlatformStrokeStyle):
  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::setPlatformStrokeStyle):
12:53 Changeset [74661] by weinig@apple.com

Fill in some more preferences for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=51610

Reviewed by Dan Bernstein.

  • Shared/WebPreferencesStore.h:
  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetAuthorAndUserStylesEnabled):
(WKPreferencesGetAuthorAndUserStylesEnabled):
(WKPreferencesSetWebArchiveDebugModeEnabled):
(WKPreferencesGetWebArchiveDebugModeEnabled):
(WKPreferencesSetLocalFileContentSniffingEnabled):
(WKPreferencesGetLocalFileContentSniffingEnabled):
(WKPreferencesSetPageCacheEnabled):
(WKPreferencesGetPageCacheEnabled):
(WKPreferencesSetPaginateDuringLayoutEnabled):
(WKPreferencesGetPaginateDuringLayoutEnabled):
(WKPreferencesSetDOMPasteAllowedEnabled):
(WKPreferencesGetDOMPasteAllowedEnabled):

  • UIProcess/API/C/WKPreferences.h:
  • UIProcess/API/C/WKPreferencesPrivate.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):
Pipe through some more preferences.

12:21 Changeset [74660] by paroga@webkit.org

2010-12-25 Patrick Gansterer <paroga@webkit.org>

Unreviewed WinCE buildfix after r74334.

  • CMakeListsWinCE.txt:
01:52 Changeset [74659] by philn@webkit.org

2010-12-25 Philippe Normand <pnormand@igalia.com>

Unreviewed, skip another GTK media test reporting wrong duration,
see bug 50518.

  • platform/gtk/Skipped:

12/24/10:

22:00 Changeset [74658] by kbr@google.com

2010-12-24 Kenneth Russell <kbr@google.com>

Unreviewed, Chromium test expectations update.
svg/batik/paints/gradientLimit.svg fails on Linux Debug as well.

  • platform/chromium/test_expectations.txt:
17:52 Changeset [74657] by mitz@apple.com

REGRESSION (r74648): XHR layout test failures
https://bugs.webkit.org/show_bug.cgi?id=51603

Reviewed by Alexey Proskuryakov.

Reverted r74648.

WebCore:

  • WebCore.exp.in:

WebKit2:

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didReceiveAuthenticationChallenge):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::shouldUseCredentialStorage):

  • WebProcess/mac/WebProcessMainMac.mm:

(WebKit::WebProcessMain):

14:33 Changeset [74656] by philn@webkit.org

2010-12-24 Philippe Normand <pnormand@igalia.com>

Unreviewed, skip failing media test on GTK.

  • platform/gtk/Skipped: Skip media/controls-after-reload.html.
13:43 Changeset [74655] by philn@webkit.org

2010-12-24 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r74632.
http://trac.webkit.org/changeset/74632
https://bugs.webkit.org/show_bug.cgi?id=51600

makes test-webkitpy hang forever on GTK (Requested by philn-tp
on #webkit).

  • Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
  • Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
13:26 Changeset [74654] by simon.fraser@apple.com

2010-12-24 Simon Fraser <simon.fraser@apple.com>

Fix the Qt build after r74650.

  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
13:24 Changeset [74653] by andreip@google.com

2010-12-24 Andrei Popescu <andreip@google.com>

Unreviewed, build fix.

[Chromium] http/tests/xmlhttprequest/basic-auth-nopassword.html needs Mac, Windows and Linux specific test expectations
https://bugs.webkit.org/show_bug.cgi?id=51589

  • platform/chromium-win/http/tests/xmlhttprequest/basic-auth-nopassword-expected.txt: Added.
  • platform/chromium-win/http/tests/xmlhttprequest/basic-auth-nouser-expected.txt: Added.
13:13 Changeset [74652] by mitz@apple.com

Try to fix the Qt build after r74648.

  • WebCore.gypi:
  • WebCore.pro:
  • platform/network/qt/CredentialStorageQt.cpp: Added.

(WebCore::CredentialStorage::getFromPersistentStorage):

12:57 Changeset [74651] by philn@webkit.org

2010-12-24 Philippe Normand <pnormand@igalia.com>

Unreviewed, updated GTK media tests baselines after r74643.

  • platform/gtk/media/audio-controls-rendering-expected.txt:
  • platform/gtk/media/controls-after-reload-expected.txt:
  • platform/gtk/media/controls-strict-expected.txt:
  • platform/gtk/media/controls-styling-expected.txt:
  • platform/gtk/media/video-controls-rendering-expected.txt:
  • platform/gtk/media/video-display-toggle-expected.txt:
  • platform/gtk/media/video-empty-source-expected.txt:
  • platform/gtk/media/video-no-audio-expected.txt:
12:55 Changeset [74650] by commit-queue@webkit.org

2010-12-24 Benjamin Poulain <ikipou@gmail.com>

Reviewed by Darin Adler.

[Qt] [WK2] WebKit 2 does not build on mac, missing reference to RetainPtr
https://bugs.webkit.org/show_bug.cgi?id=51598

Fix the build, add the missing header.

  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
12:46 Changeset [74649] by simon.fraser@apple.com

2010-12-24 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

CSSStyleSelector cleanup
https://bugs.webkit.org/show_bug.cgi?id=51597

Make some methods const. Add assertion to checkOneSelector, with the
intention of later removing the if (!e) check (this is hot code).

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::locateCousinList): (WebCore::CSSStyleSelector::canShareStyleWithElement): (WebCore::CSSStyleSelector::locateSharedStyle): (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): (WebCore::CSSStyleSelector::mmLength): (WebCore::CSSStyleSelector::inchLength): (WebCore::CSSStyleSelector::getColorFromPrimitiveValue): (WebCore::CSSStyleSelector::hasSelectorForAttribute):
  • css/CSSStyleSelector.h: (WebCore::CSSStyleSelector::fontSelector):
12:24 Changeset [74648] by mitz@apple.com

<rdar://problem/8758386> The web process uses its own credential storage
https://bugs.webkit.org/show_bug.cgi?id=51599

Reviewed by Anders Carlsson.

WebCore:

  • WebCore.exp.in: Export CredentialStorage::getFromPersistentStorage(), Credential::hasPassword(),

and Credential::isEmpty().

WebKit2:

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didReceiveAuthenticationChallenge): Try to answer the challenge using
the UI process’s credential storage first.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::shouldUseCredentialStorage): Prevent the web process from using
its own credential storage.

  • WebProcess/mac/WebProcessMainMac.mm:

(WebKit::WebProcessMain): Ditto.

11:36 Changeset [74647] by darin@apple.com

Rebased Leopard to expect the same kind of stack failure
as Windows, rather than the success expected on Snow Leopard
and many other platforms.

  • platform/mac-leopard/fast/js/large-expressions-expected.txt:

Copied from platform/win/fast/js/large-expressions-expected.txt.

11:36 Changeset [74646] by yurys@chromium.org

2010-12-24 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Darin Adler.

[V8] Rename V8CustomEventListener.{h,cpp} to V8EventListener.{h,cpp}
https://bugs.webkit.org/show_bug.cgi?id=51595

  • WebCore.gypi:
  • bindings/v8/V8DOMWrapper.cpp:
  • bindings/v8/V8EventListener.cpp: Renamed from WebCore/bindings/v8/custom/V8CustomEventListener.cpp. (WebCore::V8EventListener::V8EventListener): (WebCore::V8EventListener::getListenerFunction): (WebCore::V8EventListener::callListenerFunction):
  • bindings/v8/V8EventListener.h: Renamed from WebCore/bindings/v8/custom/V8CustomEventListener.h. (WebCore::V8EventListener::create):
  • bindings/v8/V8EventListenerList.h:
  • bindings/v8/V8WorkerContextEventListener.h:
  • bindings/v8/custom/V8DOMWindowCustom.cpp:
  • bindings/v8/custom/V8LocationCustom.cpp:
  • bindings/v8/custom/V8NodeCustom.cpp:
  • bindings/v8/custom/V8NotificationCenterCustom.cpp:
11:26 Changeset [74645] by jberlin@webkit.org

Add Windows-specific (failing) expected results for
http/tests/xmlhttprequest/basic-auth-nouser.html and basic-auth-nopassword.html in order to
get the Windows 7 Release test bot green again. Unreviewed.
https://bugs.webkit.org/show_bug.cgi?id=51596

  • platform/win/http/tests/xmlhttprequest/basic-auth-nopassword-expected.txt: Added.
  • platform/win/http/tests/xmlhttprequest/basic-auth-nouser-expected.txt: Added.
11:26 Changeset [74644] by darin@apple.com

Updated makefiles used by Apple engineers to fix build with the
new JavaScriptGlue location.

  • Makefile: Told this to build JavaScriptGlue. Some day we might

want it to descend into Sources instead and use the Makefile there,
but there are problems with sequencing the project builds, so that
can wait.

  • Sources/Makefile.shared: Added.
11:02 Changeset [74643] by commit-queue@webkit.org

2010-12-24 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Xan Lopez.

[GTK] Show current time / total in media player
https://bugs.webkit.org/show_bug.cgi?id=51535

  • css/mediaControlsGtk.css: (audio::-webkit-media-controls-current-time-display, video::-webkit-media-controls-current-time-display):
  • platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::formatMediaControlsCurrentTime): (WebCore::RenderThemeGtk::paintMediaCurrentTime):
  • platform/gtk/RenderThemeGtk.h:
10:55 Changeset [74642] by commit-queue@webkit.org

2010-12-24 Jan Erik Hanssen <jhanssen@sencha.com>

Reviewed by Eric Seidel.

Clean up CSSRuleData in CSSStyleSelector.h
https://bugs.webkit.org/show_bug.cgi?id=27753

Move CSSRuleData and CSSRuleDataList from CSSStyleSelector.h to the .cpp file.

  • css/CSSStyleSelector.cpp: (WebCore::CSSRuleData::CSSRuleData): (WebCore::CSSRuleData::~CSSRuleData): (WebCore::CSSRuleData::position): (WebCore::CSSRuleData::rule): (WebCore::CSSRuleData::selector): (WebCore::CSSRuleData::next): (WebCore::CSSRuleDataList::CSSRuleDataList): (WebCore::CSSRuleDataList::~CSSRuleDataList): (WebCore::CSSRuleDataList::first): (WebCore::CSSRuleDataList::last): (WebCore::CSSRuleDataList::append):
  • css/CSSStyleSelector.h:
10:54 Changeset [74641] by jberlin@webkit.org

Skip the new editing/input/ime-composition-clearpreedit.html test since textInputController
is unimplemented in the DRT for Windows. Unreviewed.
https://bugs.webkit.org/show_bug.cgi?id=32021

  • platform/win/Skipped:
10:43 Changeset [74640] by commit-queue@webkit.org

2010-12-24 Ryuan Choi <ryuan.choi@samsung.com>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Screen doesn't be rendered when changing size of EWebLauncher
https://bugs.webkit.org/show_bug.cgi?id=43528

Remove on_resize because ewk_view_fixed_layout_size_set should not be
called on callback of EVAS_CALLBACK_RESIZE. As it change size of
FrameView, rendering was ignored when _ewk_view_smart_calculate was
called.

  • EWebLauncher/main.c: (browserCreate):
10:21 Changeset [74639] by eric@webkit.org

2010-12-24 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

webkit-patch (or a pre-commit hook) needs to prevent bad ChangeLog changes
https://bugs.webkit.org/show_bug.cgi?id=28291

This is a start. At least now webkit-patch will prompt when your ChangeLog looks questionable.
We could do more advanced things, like parsing the ChangeLog (with changelog.py) and comparing that
to strings with find in the diff.
Since non-interactive always returns the default, this should cause patches with bad changelogs to fail on the commit-queue.

  • Scripts/webkitpy/common/checkout/api.py:
  • Scripts/webkitpy/common/checkout/diff_parser.py:
  • Scripts/webkitpy/tool/steps/abstractstep.py:
  • Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
  • Scripts/webkitpy/tool/steps/validatechangelogs.py: Copied from Tools/Scripts/webkitpy/tool/steps/validatereviewer.py.
  • Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
  • Scripts/webkitpy/tool/steps/validatereviewer.py:
10:20 Changeset [74638] by yurys@chromium.org

2010-12-24 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Fix compilation on Windows.

  • inspector/InspectorStyleSheet.cpp: (WebCore::InspectorStyle::~InspectorStyle): added explicit empty destructor
  • inspector/InspectorStyleSheet.h:
09:51 Changeset [74637] by yurys@chromium.org

2010-12-24 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Darin Adler.

inspector/debugger-step-out.html crashing intermittently in the bots
https://bugs.webkit.org/show_bug.cgi?id=50868

Use RefPtr rather instead of raw pointers when keeping references
to refcounted objects.

  • inspector/InspectorCSSAgent.cpp: (WebCore::InspectorCSSAgent::getStylesForNode2): (WebCore::InspectorCSSAgent::getComputedStyleForNode2):
  • inspector/InspectorStyleSheet.cpp: (WebCore::InspectorStyle::create): (WebCore::InspectorStyle::InspectorStyle): (WebCore::InspectorStyle::buildObjectForStyle): (WebCore::InspectorStyle::setPropertyText): (WebCore::InspectorStyle::toggleProperty): (WebCore::InspectorStyle::styleText): (WebCore::InspectorStyle::populateAllProperties): (WebCore::InspectorStyle::replacePropertyInStyleText): (WebCore::InspectorStyleSheet::create): (WebCore::InspectorStyleSheet::InspectorStyleSheet): (WebCore::InspectorStyleSheetForInlineStyle::create): (WebCore::InspectorStyleSheetForInlineStyle::InspectorStyleSheetForInlineStyle): (WebCore::InspectorStyleSheetForInlineStyle::getStyleAttributeRanges):
  • inspector/InspectorStyleSheet.h: (WebCore::InspectorStyle::cssStyle): (WebCore::InspectorStyleSheet::pageStyleSheet):
09:31 Changeset [74636] by jschuh@chromium.org

2010-12-24 Justin Schuh <jschuh@chromium.org>

Reviewed by Nikolas Zimmermann.

SVGElementInstance::m_useElement should be cleared when use element is removed from document
https://bugs.webkit.org/show_bug.cgi?id=51486

Test: svg/custom/use-instanceRoot-with-use-removed.svg

  • svg/SVGElementInstance.cpp: (WebCore::SVGElementInstance::invalidateAllInstancesOfElement):
  • svg/SVGElementInstance.h: (WebCore::SVGElementInstance::clearUseElement):
  • svg/SVGUseElement.cpp: (WebCore::SVGUseElement::removedFromDocument): (WebCore::ShadowTreeUpdateBlocker::if): (WebCore::SVGUseElement::detachInstance): (WebCore::SVGUseElement::detach):
  • svg/SVGUseElement.h:

2010-12-24 Justin Schuh <jschuh@chromium.org>

Reviewed by Nikolas Zimmermann.

SVGElementInstance::m_useElement should be cleared when use element is removed from document
https://bugs.webkit.org/show_bug.cgi?id=51486

  • svg/custom/use-instanceRoot-with-use-removed-expected.txt: Added.
  • svg/custom/use-instanceRoot-with-use-removed.svg: Added.
09:01 Changeset [74635] by yurys@chromium.org

2010-12-23 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Missing Localized Strings
https://bugs.webkit.org/show_bug.cgi?id=51542

Added missing strings: "WebSocket", "Frames", "Text", "Transfer",
"Preserve Log upon Navigation", and "Go to Line".

  • English.lproj/localizedStrings.js:
08:39 Changeset [74634] by apavlov@chromium.org

2010-12-24 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Inline HTML style property out of sync with element.style in Sidebar
https://bugs.webkit.org/show_bug.cgi?id=51478

Now the element attribute modifications (including "style") are tracked, which results in the
source offsets update (in the backend) and Styles/Metrics pane updates (in the frontend)
on the "style" attribute modification through the Elements tree. Also, it appears that
a complete "style" attribute removal destroys the inline style declaration
(StyledElement::m_inlineStyleDecl), while the code used to rely on it being immutable (hence a crash).

Test: inspector/elements-delete-inline-style.html

WebCore:

  • inspector/InspectorCSSAgent.cpp: (WebCore::InspectorCSSAgent::didModifyDOMAttr):
  • inspector/InspectorCSSAgent.h:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::didModifyDOMAttr):
  • inspector/InspectorDOMAgent.h:
  • inspector/InspectorStyleSheet.cpp: (WebCore::InspectorStyleSheetForInlineStyle::InspectorStyleSheetForInlineStyle): (WebCore::InspectorStyleSheetForInlineStyle::didModifyElementAttribute): (WebCore::InspectorStyleSheetForInlineStyle::text): (WebCore::InspectorStyleSheetForInlineStyle::setStyleText): (WebCore::InspectorStyleSheetForInlineStyle::getStyleAttributeRanges):
  • inspector/InspectorStyleSheet.h:
  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted):


LayoutTests:

  • http/tests/inspector/inspector-test2.js: (initialize_InspectorTest.InspectorTest.addResults): (initialize_InspectorTest.InspectorTest.createKeyEvent):
  • inspector/elements-delete-inline-style-expected.txt: Added.
  • inspector/elements-delete-inline-style.html: Added.
  • inspector/elements-tests2.js: Added. (initialize_ElementTest.InspectorTest.expandDOMSubtree.processChildren): (initialize_ElementTest.InspectorTest.expandDOMSubtree): (initialize_ElementTest.InspectorTest.expandDOMSubtreeAndRun): (initialize_ElementTest.InspectorTest.nodeForId): (initialize_ElementTest.InspectorTest.selectElementAndRun): (initialize_ElementTest.InspectorTest.dumpSelectedElementStyles): (initialize_ElementTest.InspectorTest.getSelectedElementStyles): (initialize_ElementTest.InspectorTest.getElementStylePropertyTreeItem): (initialize_ElementTest.InspectorTest.dumpStyleTreeOutline): (initialize_ElementTest.InspectorTest.dumpStyleTreeItem): (initialize_ElementTest):
  • inspector/styles-add-blank-property.html: Remove unnecessary function.
04:18 Changeset [74633] by commit-queue@webkit.org

2010-12-24 Benjamin Kalman <kalman@chromium.org>

Reviewed by Ryosuke Niwa.

editing/selection/caret-* tests need rebaseline for gtk
https://bugs.webkit.org/show_bug.cgi?id=51578

Rebaseline editing/selection/caret-* tests for gtk.

  • platform/gtk/editing/selection/caret-ltr-2-expected.checksum: Added.
  • platform/gtk/editing/selection/caret-ltr-2-expected.png: Added.
  • platform/gtk/editing/selection/caret-ltr-2-expected.txt: Added.
  • platform/gtk/editing/selection/caret-ltr-2-left-expected.checksum: Added.
  • platform/gtk/editing/selection/caret-ltr-2-left-expected.png: Added.
  • platform/gtk/editing/selection/caret-ltr-2-left-expected.txt: Added.
  • platform/gtk/editing/selection/caret-ltr-expected.checksum: Added.
  • platform/gtk/editing/selection/caret-ltr-expected.png: Added.
  • platform/gtk/editing/selection/caret-ltr-expected.txt: Added.
  • platform/gtk/editing/selection/caret-ltr-right-expected.checksum: Added.
  • platform/gtk/editing/selection/caret-ltr-right-expected.png: Added.
  • platform/gtk/editing/selection/caret-ltr-right-expected.txt: Added.
  • platform/gtk/editing/selection/caret-rtl-2-left-expected.checksum: Added.
  • platform/gtk/editing/selection/caret-rtl-2-left-expected.png: Added.
  • platform/gtk/editing/selection/caret-rtl-2-left-expected.txt: Added.
  • platform/gtk/editing/selection/caret-rtl-right-expected.checksum: Added.
  • platform/gtk/editing/selection/caret-rtl-right-expected.png: Added.
  • platform/gtk/editing/selection/caret-rtl-right-expected.txt: Added.
04:12 Changeset [74632] by dpranke@chromium.org

2010-12-24 Dirk Pranke <dpranke@chromium.org>

Reviewed by Kenneth Russell.

Modify new-run-webkit-tests to shut up and exit when all the threads
are wedged so that test runs complete faster and we don't end up
w/ enormous log files.

https://bugs.webkit.org/show_bug.cgi?id=51572

  • Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
  • Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
04:05 Changeset [74631] by commit-queue@webkit.org

2010-12-24 Noel Gordon <noel.gordon@gmail.com>

Reviewed by Andreas Kling.

[chromium] Fix a style nit in the JPEG encoder
https://bugs.webkit.org/show_bug.cgi?id=51574

  • platform/image-encoders/skia/JPEGImageEncoder.cpp: nit begone.
04:02 Changeset [74630] by apavlov@chromium.org

2010-12-23 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Maciej Stachowiak.

Web Inspector: CSS shorthand properties expand unnecessarily
https://bugs.webkit.org/show_bug.cgi?id=36304

"border-radius" is a shorthand property that has a "non-standard" format and longhands, see
http://www.w3.org/TR/css3-background/#border-radius for reference. CSSParser does not use the
standard parseShorthand() or parse4Values() methods but instead a custom parseBorderRadius() method.
This method didn't use to create a ShorthandScope instance and set the m_implicitShorthand value
appropriately when adding implicit longhands, thus they were added as normal properties
found in the CSS (neither implicit, nor longhands). This is now fixed.

WebCore:

  • css/CSSParser.cpp: (WebCore::CSSParser::parseBorderRadius):

LayoutTests:

  • inspector/elements-panel-styles-expected.txt:
  • inspector/resources/elements-panel-styles.css: (.foo):
03:54 Changeset [74629] by jschuh@chromium.org

2010-12-24 Justin Schuh <jschuh@chromium.org>

Reviewed by Darin Adler.

setTargetAttributeAnimatedValue should check for a null shadowTreeElement.
https://bugs.webkit.org/show_bug.cgi?id=51576

  • svg/custom/animate-disallowed-use-element-expected.txt: Added.
  • svg/custom/animate-disallowed-use-element.svg: Added.

2010-12-24 Justin Schuh <jschuh@chromium.org>

Reviewed by Darin Adler.

setTargetAttributeAnimatedValue should check for a null shadowTreeElement.
https://bugs.webkit.org/show_bug.cgi?id=51576

Disallowed elements may be pruned from the shadow tree, leaving a null
shadowTreeElement. We should check for that before setting attributes.

Test: svg/custom/animate-disallowed-use-element.svg

  • svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::setTargetAttributeAnimatedValue):
03:50 Changeset [74628] by evan@chromium.org

2010-12-24 Evan Martin <evan@chromium.org>

Reviewed by Darin Adler.

TextMetrics::width is an integer, but the member is a float
https://bugs.webkit.org/show_bug.cgi?id=51566

Change the return type to a float.

No tests, fixing a compiler warning.
(I was unable to produce a difference in the values exposed to pages
with a float versus the previous conversion to an integer.)

  • html/TextMetrics.h: (WebCore::TextMetrics::width):
03:47 Changeset [74627] by andreip@google.com

2010-12-24 Andrei Popescu <andreip@google.com>

Unreviewed build fix.

Add Chromium-mac test expectation for the layout test below.
[Chromium] http/tests/xmlhttprequest/basic-auth-nopassword.html needs Mac specific test expectations
https://bugs.webkit.org/show_bug.cgi?id=51589

  • platform/chromium-mac/http/tests/xmlhttprequest/basic-auth-nopassword-expected.txt: Added.
03:27 Changeset [74626] by commit-queue@webkit.org

2010-12-24 Ryuan Choi <ryuan.choi@samsung.com>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Add option to enable Touch Events.
https://bugs.webkit.org/show_bug.cgi?id=49125

Add ENABLE_TOUCH_EVENTS option.

  • cmake/OptionsEfl.cmake:
  • cmakeconfig.h.cmake:

2010-12-24 Ryuan Choi <ryuan.choi@samsung.com>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Add option to enable Touch Events.
https://bugs.webkit.org/show_bug.cgi?id=49125

Add files for EFL to support TOUCH_EVENTS.

  • CMakeLists.txt:
  • CMakeListsEfl.txt:
  • platform/PlatformTouchEvent.h: Add EFL related constructor.
  • platform/PlatformTouchPoint.h: ditto.
  • platform/efl/PlatformTouchEventEfl.cpp: Added. (WebCore::PlatformTouchEvent::PlatformTouchEvent):
  • platform/efl/PlatformTouchPointEfl.cpp: Added. (WebCore::PlatformTouchPoint::PlatformTouchPoint):

2010-12-24 Ryuan Choi <ryuan.choi@samsung.com>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Add option to enable Touch Events.
https://bugs.webkit.org/show_bug.cgi?id=49125

Implement ewk_frame_feed_touch_event to feed touch events. Because EFL
doesn't have touch events, Application should generate and pass it.

  • WebCoreSupport/ChromeClientEfl.h: (WebCore::ChromeClientEfl::needTouchEvents):
  • ewk/ewk_frame.cpp: (ewk_frame_feed_touch_event):
  • ewk/ewk_frame.h:
03:23 Changeset [74625] by gyuyoung.kim@samsung.com

2010-12-24 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Return an empty string instead of 'application/octet-stream' in getMIMETypeForExtension()
https://bugs.webkit.org/show_bug.cgi?id=51457

WebKit EFL can't play html5 audio because of wrong mime type checking.
So, 'application/octet-stream' is changed with an empty string.

  • platform/efl/MIMETypeRegistryEfl.cpp: (WebCore::MIMETypeRegistry::getMIMETypeForExtension): Returns an empty string instead of application/octet-stream when it can't find proper mime type.
03:09 Changeset [74624] by andreip@google.com

2010-12-24 Andrei Popescu <andreip@google.com>

Unreviewed. Update Chromium test expectations.

Mark editing/input/ime-composition-clearpreedit.html.html as TEXT.
This test was added in http://trac.webkit.org/changeset/74605 and
fails in Chromium.

  • platform/chromium/test_expectations.txt:
03:05 Changeset [74623] by eric@webkit.org

2010-12-24 Eric Seidel <eric@webkit.org>

Reviewed by David Levin.

commit-queue should better explain how it will re-open bugs and follow duplicate chains
https://bugs.webkit.org/show_bug.cgi?id=51549

I've had multiple people ask me about the commit-queue's behavior
regarding reporting flaky tests. I figured it would be best to just
have the queue explain itself in the bugs it files.

  • Scripts/webkitpy/tool/bot/flakytestreporter.py:
  • Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
02:38 Changeset [74622] by jschuh@chromium.org

2010-12-24 Justin Schuh <jschuh@chromium.org>

Reviewed by Darin Adler.

SVGFontFaceElement::rebuildFontFace() should exit when not in document
https://bugs.webkit.org/show_bug.cgi?id=51571

  • svg/custom/use-invalid-font-face-expected.txt: Added.
  • svg/custom/use-invalid-font-face.svg: Added.

2010-12-24 Justin Schuh <jschuh@chromium.org>

Reviewed by Darin Adler.

SVGFontFaceElement::rebuildFontFace() should exit when not in document
https://bugs.webkit.org/show_bug.cgi?id=51571

We were hitting a NULL deref crash. Since most of the callers checked
inDocument() anyway, I moved it into the start of rebuildFontFace.

Test: svg/custom/use-invalid-font-face.svg

  • svg/SVGFontFaceElement.cpp: (WebCore::SVGFontFaceElement::parseMappedAttribute): (WebCore::SVGFontFaceElement::rebuildFontFace): (WebCore::SVGFontFaceElement::childrenChanged):
02:19 Changeset [74621] by hamaji@chromium.org

2010-12-24 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Eric Seidel.

check-webkit-style: should ignore "wrong" namings in JavaScriptCore/qt
https://bugs.webkit.org/show_bug.cgi?id=51467

  • Scripts/webkitpy/style/checker.py:
  • Scripts/webkitpy/style/checker_unittest.py:
02:12 Changeset [74620] by philn@webkit.org

2010-12-21 Philippe Normand <pnormand@igalia.com>

Reviewed by Eric Seidel.

[GTK] minimal build with --database fails
https://bugs.webkit.org/show_bug.cgi?id=51394

  • webkit/webkitprivate.cpp: (webkit_init): Use cacheStorage() only if the OFFLINE_WEB_APPLICATIONS feature is enabled.
02:00 Changeset [74619] by jschuh@chromium.org

2010-12-24 Justin Schuh <jschuh@chromium.org>

Reviewed by Darin Adler.

Remove unnecessary check in CSSCanvasValue::canvasDestroyed().
https://bugs.webkit.org/show_bug.cgi?id=51564

This check was duplicating an ASSERT for a case fixed in r73927.
Now that the bug is fixed the check is no longer necessary.

Removing dead code, so no new tests needed.

  • css/CSSCanvasValue.cpp: (WebCore::CSSCanvasValue::canvasDestroyed):
01:01 Changeset [74618] by abarth@webkit.org

Move JavaScriptGlue into Sources
https://bugs.webkit.org/show_bug.cgi?id=51583

Rubber-stamped by Eric Seidel.

Actually perform the move.

  • JavaScriptGlue: Removed.
  • JavaScriptGlue/Configurations: Removed.
  • JavaScriptGlue/Configurations/Base.xcconfig: Removed.
  • JavaScriptGlue/Configurations/DebugRelease.xcconfig: Removed.
  • JavaScriptGlue/Configurations/JavaScriptGlue.xcconfig: Removed.
  • JavaScriptGlue/Configurations/Version.xcconfig: Removed.
  • JavaScriptGlue/English.lproj: Removed.
  • JavaScriptGlue/English.lproj/InfoPlist.strings: Removed.
  • JavaScriptGlue/ForwardingHeaders: Removed.
  • JavaScriptGlue/ForwardingHeaders/masm: Removed.
  • JavaScriptGlue/ForwardingHeaders/masm/X86Assembler.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/profiler: Removed.
  • JavaScriptGlue/ForwardingHeaders/profiler/Profiler.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/runtime: Removed.
  • JavaScriptGlue/ForwardingHeaders/runtime/CallFrame.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/ASCIICType.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/AlwaysInline.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/Assertions.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/Atomics.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/Bitmap.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/BumpPointerAllocator.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/CrossThreadRefCounted.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/CurrentTime.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/DateInstanceCache.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/DateMath.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/FastAllocBase.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/FastMalloc.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/FixedArray.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/Forward.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/HashCountedSet.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/HashFunctions.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/HashMap.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/HashSet.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/HashTraits.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/ListHashSet.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/ListRefPtr.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/Locker.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/MainThread.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/MathExtras.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/Noncopyable.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/NotFound.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/OSAllocator.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/OwnArrayPtr.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/OwnArrayPtrCommon.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/OwnFastMallocPtr.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/OwnPtr.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/OwnPtrCommon.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/PageAllocation.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/PageAllocationAligned.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/PageBlock.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/PageReservation.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/PassOwnArrayPtr.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/PassOwnPtr.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/PassRefPtr.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/Platform.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/PossiblyNull.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/PtrAndFlags.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/RandomNumber.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/RefCounted.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/RefPtr.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/StackBounds.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/StdLibExtras.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/StringHasher.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/ThreadSafeShared.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/ThreadSpecific.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/Threading.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/ThreadingPrimitives.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/UnusedParam.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/VMTags.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/ValueCheck.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/Vector.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/VectorTraits.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/WTFThreadData.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/text: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/text/CString.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/text/StringHash.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/text/StringImpl.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/text/StringImplBase.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/text/TextPosition.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/text/WTFString.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/unicode: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/unicode/Unicode.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/unicode/icu: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/unicode/icu/UnicodeIcu.h: Removed.
  • JavaScriptGlue/Info.plist: Removed.
  • JavaScriptGlue/JSBase.cpp: Removed.
  • JavaScriptGlue/JSBase.h: Removed.
  • JavaScriptGlue/JSObject.cpp: Removed.
  • JavaScriptGlue/JSObject.h: Removed.
  • JavaScriptGlue/JSRun.cpp: Removed.
  • JavaScriptGlue/JSRun.h: Removed.
  • JavaScriptGlue/JSUtils.cpp: Removed.
  • JavaScriptGlue/JSUtils.h: Removed.
  • JavaScriptGlue/JSValueWrapper.cpp: Removed.
  • JavaScriptGlue/JSValueWrapper.h: Removed.
  • JavaScriptGlue/JavaScriptGlue.cpp: Removed.
  • JavaScriptGlue/JavaScriptGlue.exp: Removed.
  • JavaScriptGlue/JavaScriptGlue.h: Removed.
  • JavaScriptGlue/JavaScriptGlue.xcodeproj: Removed.
  • JavaScriptGlue/JavaScriptGlue.xcodeproj/project.pbxproj: Removed.
  • JavaScriptGlue/LICENSE: Removed.
  • JavaScriptGlue/Makefile: Removed.
  • JavaScriptGlue/UserObjectImp.cpp: Removed.
  • JavaScriptGlue/UserObjectImp.h: Removed.
  • JavaScriptGlue/config.h: Removed.
  • JavaScriptGlue/icu: Removed.
  • JavaScriptGlue/icu/LICENSE: Removed.
  • JavaScriptGlue/icu/README: Removed.
  • JavaScriptGlue/icu/unicode: Removed.
  • JavaScriptGlue/icu/unicode/platform.h: Removed.
  • JavaScriptGlue/icu/unicode/putil.h: Removed.
  • JavaScriptGlue/icu/unicode/uchar.h: Removed.
  • JavaScriptGlue/icu/unicode/ucnv.h: Removed.
  • JavaScriptGlue/icu/unicode/ucnv_err.h: Removed.
  • JavaScriptGlue/icu/unicode/uconfig.h: Removed.
  • JavaScriptGlue/icu/unicode/uenum.h: Removed.
  • JavaScriptGlue/icu/unicode/uiter.h: Removed.
  • JavaScriptGlue/icu/unicode/umachine.h: Removed.
  • JavaScriptGlue/icu/unicode/urename.h: Removed.
  • JavaScriptGlue/icu/unicode/ustring.h: Removed.
  • JavaScriptGlue/icu/unicode/utf.h: Removed.
  • JavaScriptGlue/icu/unicode/utf16.h: Removed.
  • JavaScriptGlue/icu/unicode/utf8.h: Removed.
  • JavaScriptGlue/icu/unicode/utf_old.h: Removed.
  • JavaScriptGlue/icu/unicode/utypes.h: Removed.
  • JavaScriptGlue/icu/unicode/uversion.h: Removed.
  • JavaScriptGlue/testjsglue.cpp: Removed.
  • Makefile:
  • Sources: Added.
  • Sources/JavaScriptGlue: Copied from JavaScriptGlue.
  • Sources/Makefile: Added.

Tools:

These tools refer to JavaScriptGlue and need to be updated to its new
location.

  • Scripts/build-webkit:
  • Scripts/do-file-rename:
  • Scripts/do-webcore-rename:
  • Scripts/webkitpy/common/config/build.py:
  • Scripts/webkitpy/common/config/build_unittest.py:

Websites/bugs.webkit.org:

PrettyPatch keeps a list of the top-level directories that exist in
trac.

  • PrettyPatch/PrettyPatch.rb:
00:06 Changeset [74617] by paroga@webkit.org

2010-12-24 Patrick Gansterer <paroga@webkit.org>

Reviewed by Eric Seidel.

[WINCE] Add CPU(MIPS) detection
https://bugs.webkit.org/show_bug.cgi?id=51342

WinCE usually defines MIPS and _MIPS_.

  • wtf/Platform.h:

12/23/10:

22:14 Changeset [74616] by lforschler@apple.com

2010-12-23 Lucas Forschler <lforschler@apple.com>

Reviewed by Eric Seidel.

Bug 51539 - update iexploder scripts to point to new location

  • Scripts/run-iexploder-tests:
  • Scripts/update-iexploder-cssproperties:
22:11 Changeset [74615] by mitz@apple.com

Make dragging work again after r74591.

Reviewed by Sam Weinig.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didReceiveEvent): Fixed a typo.

22:05 Changeset [74614] by yutak@chromium.org

2010-12-23 Yuta Kitamura <yutak@chromium.org>

Unreviewed. Update GTK's Skipped file.

[GTK] http/tests/inspector/console-websocket-error.html hangs
https://bugs.webkit.org/show_bug.cgi?id=51380

  • platform/gtk/Skipped:
21:26 Changeset [74613] by ariya@webkit.org

Unreviewed GTK fix after r74609: put the right file name in the Skipped file.

20:59 Changeset [74612] by yutak@chromium.org

2010-12-23 Yuta Kitamura <yutak@chromium.org>

Unreviewed. Update Chromium test expectations.

Mark http/tests/inspector/console-websocket-error.html as SLOW on WIN DEBUG.

  • platform/chromium/test_expectations.txt:
20:50 Changeset [74611] by yutak@chromium.org

2010-12-22 Yuta Kitamura <yutak@chromium.org>

Reviewed by Alexey Proskuryakov.

[GTK] http/tests/inspector/console-websocket-error.html hangs
https://bugs.webkit.org/show_bug.cgi?id=51380

The test should call dumpConsoleMessages() even if WebSocket is not supported
or a WebSocket object goes to an unexpected state.

  • http/tests/inspector/console-websocket-error.html:
  • platform/gtk/Skipped:
  • platform/mac-leopard/http/tests/inspector/console-websocket-error-expected.txt:
  • platform/mac/http/tests/inspector/console-websocket-error-expected.txt:
20:31 Changeset [74610] by evan@chromium.org

2010-12-23 Evan Martin <evan@chromium.org>

Reviewed by Darin Adler.

ViewportArguments.h uses an enum to intialize a bool
https://bugs.webkit.org/show_bug.cgi?id=50982

Initialize userScalable to true, rather than -1.
No tests; fixes a compiler warning.

  • dom/ViewportArguments.h: (WebCore::ViewportArguments::ViewportArguments):
20:06 Changeset [74609] by ariya@webkit.org

[Qt] User name/password stripped from URLs
https://bugs.webkit.org/show_bug.cgi?id=36232

Patch by Jan Erik Hanssen <jhanssen@sencha.com> on 2010-12-23
Reviewed by Adam Barth.

WebCore:

If a username but no password or no username but a password is present
in a URL, QtWebKit won't send any authentication information down to Qt
as it should.

Tests: http/tests/xmlhttprequest/basic-auth-nopassword.html

http/tests/xmlhttprequest/basic-auth-nouser.html

  • platform/network/qt/ResourceHandleQt.cpp:

(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::loadResourceSynchronously):

LayoutTests:

Test authentication cases where a username but no password and
no username but a password is present.

  • http/tests/xmlhttprequest/basic-auth-nopassword-expected.txt: Added.
  • http/tests/xmlhttprequest/basic-auth-nopassword.html: Added.
  • http/tests/xmlhttprequest/basic-auth-nouser-expected.txt: Added.
  • http/tests/xmlhttprequest/basic-auth-nouser.html: Added.
  • http/tests/xmlhttprequest/resources/basic-auth-nouserpass/basic-auth-nouserpass.php: Added.
  • platform/gtk/Skipped:
  • platform/mac-leopard/http/tests/xmlhttprequest/basic-auth-nopassword-expected.txt: Added.
  • platform/mac-snowleopard/http/tests/xmlhttprequest/basic-auth-nopassword-expected.txt: Added.
  • platform/mac-tiger/http/tests/xmlhttprequest/basic-auth-nopassword-expected.txt: Added.
  • platform/qt/Skipped:
19:40 Changeset [74608] by rniwa@webkit.org

2010-12-23 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed Qt rebaseline for r74593.

Added the forgotten blank line at the end.

  • platform/qt/editing/pasteboard/copy-in-password-field-expected.txt:
19:18 Changeset [74607] by rniwa@webkit.org

2010-12-23 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed Qt rebaseline for r74593.

  • platform/qt/editing/pasteboard/copy-in-password-field-expected.txt: Added.
18:56 Changeset [74606] by rniwa@webkit.org

2010-12-23 Ryosuke Niwa <rniwa@webkit.org>

More unreviewed Chromium rebaselines for r74593.

  • platform/chromium-linux/editing/deleting/smart-delete-002-expected.txt:
  • platform/chromium-linux/editing/pasteboard/subframe-dragndrop-1-expected.txt:
  • platform/chromium-win/editing/pasteboard/paste-xml-expected.txt:
18:53 Changeset [74605] by commit-queue@webkit.org

2010-12-23 Jan Erik Hanssen <jhanssen@sencha.com>

Reviewed by Alexey Proskuryakov.

[Qt] Composition text is not removed from the editor when composition is cancelled
https://bugs.webkit.org/show_bug.cgi?id=29391

Ensure that the composition text is cleared when an empty QInputMethodEvent
is received and the editor is in composition mode.

  • editing/input/ime-composition-clearpreedit-expected.txt: Added.
  • editing/input/ime-composition-clearpreedit.html: Added.
  • platform/gtk/Skipped:
  • platform/mac-wk2/Skipped:
  • platform/qt-wk2/Skipped:

2010-12-23 Jan Erik Hanssen <jhanssen@sencha.com>

Reviewed by Alexey Proskuryakov.

[Qt] Composition text is not removed from the editor when composition is cancelled
https://bugs.webkit.org/show_bug.cgi?id=29391

Ensure that the composition text is cleared when an empty QInputMethodEvent
is received and the editor is in composition mode.

  • Api/qwebpage.cpp: (QWebPagePrivate::inputMethodEvent):
18:38 Changeset [74604] by rniwa@webkit.org

2010-12-23 Benjamin Kalman <kalman@chromium.org>

Reviewed by Ryosuke Niwa.

Selection becomes stale when CharacterData is manipulated directly
https://bugs.webkit.org/show_bug.cgi?id=51389

Rebaseline GTK tests.

  • platform/gtk/editing/deleting/collapse-whitespace-3587601-fix-expected.txt:
  • platform/gtk/editing/deleting/delete-3608430-fix-expected.txt:
  • platform/gtk/editing/deleting/delete-3608445-fix-expected.txt:
  • platform/gtk/editing/deleting/delete-3608462-fix-expected.txt:
  • platform/gtk/editing/deleting/delete-and-undo-expected.txt:
  • platform/gtk/editing/deleting/delete-block-merge-contents-010-expected.txt:
  • platform/gtk/editing/deleting/delete-br-007-expected.txt:
  • platform/gtk/editing/deleting/delete-contiguous-ws-001-expected.txt:
  • platform/gtk/editing/deleting/delete-leading-ws-001-expected.txt:
  • platform/gtk/editing/deleting/delete-line-end-ws-001-expected.txt:
  • platform/gtk/editing/deleting/delete-line-end-ws-002-expected.txt:
  • platform/gtk/editing/deleting/delete-listitem-001-expected.txt:
  • platform/gtk/editing/deleting/delete-tab-002-expected.txt:
  • platform/gtk/editing/deleting/delete-tab-004-expected.txt:
  • platform/gtk/editing/deleting/delete-trailing-ws-002-expected.txt:
  • platform/gtk/editing/deleting/delete-ws-fixup-001-expected.txt:
  • platform/gtk/editing/deleting/delete-ws-fixup-002-expected.txt:
  • platform/gtk/editing/deleting/forward-delete-expected.txt:
  • platform/gtk/editing/deleting/smart-delete-003-expected.txt:
  • platform/gtk/editing/deleting/smart-delete-004-expected.txt:
  • platform/gtk/editing/execCommand/insertHorizontalRule-expected.txt:
  • platform/gtk/editing/inserting/insert-3654864-fix-expected.txt:
  • platform/gtk/editing/inserting/insert-after-delete-001-expected.txt:
  • platform/gtk/editing/inserting/insert-div-003-expected.txt:
  • platform/gtk/editing/inserting/insert-div-024-expected.txt:
  • platform/gtk/editing/inserting/insert-space-in-empty-doc-expected.txt:
  • platform/gtk/editing/inserting/insert-text-with-newlines-expected.txt:
  • platform/gtk/editing/inserting/typing-001-expected.txt:
  • platform/gtk/editing/inserting/typing-002-expected.txt:
  • platform/gtk/editing/inserting/typing-003-expected.txt:
  • platform/gtk/editing/inserting/typing-around-br-001-expected.txt:
  • platform/gtk/editing/inserting/typing-around-image-001-expected.txt:
  • platform/gtk/editing/pasteboard/4076267-2-expected.txt:
  • platform/gtk/editing/pasteboard/4076267-3-expected.txt:
  • platform/gtk/editing/pasteboard/cut-text-001-expected.txt:
  • platform/gtk/editing/pasteboard/paste-text-001-expected.txt:
  • platform/gtk/editing/pasteboard/paste-xml-expected.txt:
  • platform/gtk/editing/pasteboard/subframe-dragndrop-1-expected.txt:
  • platform/gtk/editing/spelling/spelling-expected.txt:
  • platform/gtk/editing/style/style-3681552-fix-001-expected.txt:
  • platform/gtk/editing/style/style-3681552-fix-002-expected.txt:
  • platform/gtk/editing/style/typing-style-001-expected.txt:
  • platform/gtk/editing/style/typing-style-002-expected.txt:
  • platform/gtk/editing/style/unbold-in-bold-expected.txt:
  • platform/gtk/editing/undo/4063751-expected.txt:
  • platform/gtk/editing/undo/redo-typing-001-expected.txt:
  • platform/gtk/editing/undo/undo-combined-delete-boundary-expected.txt:
  • platform/gtk/editing/undo/undo-combined-delete-expected.txt:
  • platform/gtk/editing/undo/undo-delete-boundary-expected.txt:
  • platform/gtk/editing/undo/undo-delete-expected.txt:
  • platform/gtk/editing/undo/undo-forward-delete-boundary-expected.txt:
  • platform/gtk/editing/undo/undo-forward-delete-expected.txt:
  • platform/gtk/editing/undo/undo-misspellings-expected.txt:
18:33 Changeset [74603] by rniwa@webkit.org

2010-12-23 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

queryCommandValue("FormatBlock") does not respect editing boundaries
https://bugs.webkit.org/show_bug.cgi?id=51219

Added test cases to ensure queryCommandValue("FormatBlock") respects editing boundaries.

  • editing/execCommand/query-format-block-expected.txt:
  • editing/execCommand/script-tests/query-format-block.js:

2010-12-23 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

queryCommandValue("FormatBlock") does not respect editing boundaries
https://bugs.webkit.org/show_bug.cgi?id=51219

Fixed the bug by checking the element we found in elementForFormatBlockCommand
does not contain the editable root.

  • editing/FormatBlockCommand.cpp: (WebCore::FormatBlockCommand::elementForFormatBlockCommand):
18:17 Changeset [74602] by rniwa@webkit.org

2010-12-23 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed Chromium rebaselines for r74593.

  • platform/chromium-linux/editing/deleting/smart-delete-001-expected.txt:
  • platform/chromium-linux/editing/deleting/smart-delete-003-expected.txt:
  • platform/chromium-linux/editing/deleting/smart-delete-004-expected.txt:
  • platform/chromium-win/editing/deleting/collapse-whitespace-3587601-fix-expected.txt:
  • platform/chromium-win/editing/deleting/delete-3608430-fix-expected.txt:
  • platform/chromium-win/editing/deleting/delete-3608445-fix-expected.txt:
  • platform/chromium-win/editing/deleting/delete-3608462-fix-expected.txt:
  • platform/chromium-win/editing/deleting/delete-after-span-ws-001-expected.txt:
  • platform/chromium-win/editing/deleting/delete-after-span-ws-002-expected.txt:
  • platform/chromium-win/editing/deleting/delete-after-span-ws-003-expected.txt:
  • platform/chromium-win/editing/deleting/delete-and-undo-expected.txt:
  • platform/chromium-win/editing/deleting/delete-block-merge-contents-010-expected.txt:
  • platform/chromium-win/editing/deleting/delete-block-table-expected.txt:
  • platform/chromium-win/editing/deleting/delete-br-007-expected.txt:
  • platform/chromium-win/editing/deleting/delete-character-001-expected.txt:
  • platform/chromium-win/editing/deleting/delete-contiguous-ws-001-expected.txt:
  • platform/chromium-win/editing/deleting/delete-hr-expected.txt:
  • platform/chromium-win/editing/deleting/delete-leading-ws-001-expected.txt:
  • platform/chromium-win/editing/deleting/delete-line-end-ws-001-expected.txt:
  • platform/chromium-win/editing/deleting/delete-line-end-ws-002-expected.txt:
  • platform/chromium-win/editing/deleting/delete-listitem-001-expected.txt:
  • platform/chromium-win/editing/deleting/delete-selection-001-expected.txt:
  • platform/chromium-win/editing/deleting/delete-tab-001-expected.txt:
  • platform/chromium-win/editing/deleting/delete-tab-002-expected.txt:
  • platform/chromium-win/editing/deleting/delete-tab-003-expected.txt:
  • platform/chromium-win/editing/deleting/delete-tab-004-expected.txt:
  • platform/chromium-win/editing/deleting/delete-trailing-ws-001-expected.txt:
  • platform/chromium-win/editing/deleting/delete-trailing-ws-002-expected.txt:
  • platform/chromium-win/editing/deleting/delete-ws-fixup-001-expected.txt:
  • platform/chromium-win/editing/deleting/delete-ws-fixup-002-expected.txt:
  • platform/chromium-win/editing/deleting/forward-delete-expected.txt:
  • platform/chromium-win/editing/deleting/non-smart-delete-expected.txt:
  • platform/chromium-win/editing/deleting/smart-delete-001-expected.txt:
  • platform/chromium-win/editing/deleting/smart-delete-003-expected.txt:
  • platform/chromium-win/editing/deleting/smart-delete-004-expected.txt:
  • platform/chromium-win/editing/execCommand/insertHorizontalRule-expected.txt:
  • platform/chromium-win/editing/inserting/4278698-expected.txt:
  • platform/chromium-win/editing/inserting/editing-empty-divs-expected.txt:
  • platform/chromium-win/editing/inserting/insert-3654864-fix-expected.txt:
  • platform/chromium-win/editing/inserting/insert-after-delete-001-expected.txt:
  • platform/chromium-win/editing/inserting/insert-br-003-expected.txt:
  • platform/chromium-win/editing/inserting/insert-br-006-expected.txt:
  • platform/chromium-win/editing/inserting/insert-br-007-expected.txt:
  • platform/chromium-win/editing/inserting/insert-br-008-expected.txt:
  • platform/chromium-win/editing/inserting/insert-br-009-expected.txt:
  • platform/chromium-win/editing/inserting/insert-br-at-tabspan-002-expected.txt:
  • platform/chromium-win/editing/inserting/insert-br-at-tabspan-003-expected.txt:
  • platform/chromium-win/editing/inserting/insert-div-003-expected.txt:
  • platform/chromium-win/editing/inserting/insert-div-006-expected.txt:
  • platform/chromium-win/editing/inserting/insert-div-008-expected.txt:
  • platform/chromium-win/editing/inserting/insert-div-024-expected.txt:
  • platform/chromium-win/editing/inserting/insert-space-in-empty-doc-expected.txt:
  • platform/chromium-win/editing/inserting/insert-tab-003-expected.txt:
  • platform/chromium-win/editing/inserting/insert-text-at-tabspan-001-expected.txt:
  • platform/chromium-win/editing/inserting/insert-text-at-tabspan-002-expected.txt:
  • platform/chromium-win/editing/inserting/insert-text-with-newlines-expected.txt:
  • platform/chromium-win/editing/inserting/typing-001-expected.txt:
  • platform/chromium-win/editing/inserting/typing-002-expected.txt:
  • platform/chromium-win/editing/inserting/typing-003-expected.txt:
  • platform/chromium-win/editing/inserting/typing-around-br-001-expected.txt:
  • platform/chromium-win/editing/inserting/typing-around-image-001-expected.txt:
  • platform/chromium-win/editing/pasteboard/4076267-2-expected.txt:
  • platform/chromium-win/editing/pasteboard/4076267-3-expected.txt:
  • platform/chromium-win/editing/pasteboard/bad-placeholder-expected.txt:
  • platform/chromium-win/editing/pasteboard/cut-text-001-expected.txt:
  • platform/chromium-win/editing/pasteboard/interchange-newline-1-expected.txt:
  • platform/chromium-win/editing/pasteboard/merge-end-1-expected.txt:
  • platform/chromium-win/editing/pasteboard/merge-end-2-expected.txt:
  • platform/chromium-win/editing/pasteboard/merge-end-4-expected.txt:
  • platform/chromium-win/editing/pasteboard/merge-end-list-expected.txt:
  • platform/chromium-win/editing/pasteboard/merge-end-table-expected.txt:
  • platform/chromium-win/editing/pasteboard/paste-match-style-001-expected.txt:
  • platform/chromium-win/editing/pasteboard/paste-text-001-expected.txt:
  • platform/chromium-win/editing/pasteboard/paste-text-019-expected.txt:
  • platform/chromium-win/editing/pasteboard/paste-text-at-tabspan-001-expected.txt:
  • platform/chromium-win/editing/pasteboard/paste-text-at-tabspan-002-expected.txt:
  • platform/chromium-win/editing/pasteboard/paste-text-at-tabspan-003-expected.txt:
  • platform/chromium-win/editing/pasteboard/pasting-object-expected.txt:
  • platform/chromium-win/editing/pasteboard/smart-paste-002-expected.txt:
  • platform/chromium-win/editing/pasteboard/smart-paste-006-expected.txt:
  • platform/chromium-win/editing/pasteboard/smart-paste-007-expected.txt:
  • platform/chromium-win/editing/spelling/spelling-expected.txt:
  • platform/chromium-win/editing/style/style-3681552-fix-001-expected.txt:
  • platform/chromium-win/editing/style/style-3681552-fix-002-expected.txt:
  • platform/chromium-win/editing/style/style-boundary-002-expected.txt:
  • platform/chromium-win/editing/style/style-boundary-005-expected.txt:
  • platform/chromium-win/editing/style/typing-style-001-expected.txt:
  • platform/chromium-win/editing/style/typing-style-002-expected.txt:
  • platform/chromium-win/editing/style/unbold-in-bold-expected.txt:
  • platform/chromium-win/editing/undo/4063751-expected.txt:
  • platform/chromium-win/editing/undo/redo-typing-001-expected.txt:
  • platform/chromium-win/editing/undo/undo-combined-delete-boundary-expected.txt:
  • platform/chromium-win/editing/undo/undo-combined-delete-expected.txt:
  • platform/chromium-win/editing/undo/undo-delete-boundary-expected.txt:
  • platform/chromium-win/editing/undo/undo-delete-expected.txt:
  • platform/chromium-win/editing/undo/undo-forward-delete-boundary-expected.txt:
  • platform/chromium-win/editing/undo/undo-forward-delete-expected.txt:
  • platform/chromium-win/editing/undo/undo-misspellings-expected.txt:
  • platform/chromium-win/editing/undo/undo-typing-001-expected.txt:
  • platform/chromium-win/editing/unsupported-content/list-type-after-expected.txt:
  • platform/chromium-win/editing/unsupported-content/list-type-before-expected.txt:
  • platform/chromium-win/editing/unsupported-content/table-type-after-expected.txt:
  • platform/chromium-win/editing/unsupported-content/table-type-before-expected.txt:
18:14 Changeset [74601] by rniwa@webkit.org

2010-12-23 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

FormatBlock doesn't preserve typing style but it should
https://bugs.webkit.org/show_bug.cgi?id=51140

Added a test to type text after bolding the typing style and executing a FormatBlock command.
Because FormatBlock command preserves typing style, the typed text should be in bold.

  • editing/execCommand/format-block-typing-style.html: Added.

2010-12-23 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

FormatBlock doesn't preserve typing style but it should
https://bugs.webkit.org/show_bug.cgi?id=51140

Fixed the bug by making preserveTypingStyle return true.

Test: editing/execCommand/format-block-typing-style.html

  • editing/FormatBlockCommand.h: (WebCore::FormatBlockCommand::preservesTypingStyle):
17:40 Changeset [74600] by barraclough@apple.com

Rename RegexCompiler.cpp to RegexPattern.cpp.
Implicitly call compileRegex from RegexPattern's constructor.

Reviewed by Sam Weinig.

(JSC::RegExp::compile):

  • yarr/RegexCompiler.cpp: Removed.
  • yarr/RegexCompiler.h: Removed.
  • yarr/RegexInterpreter.cpp:
  • yarr/RegexJIT.cpp:
  • yarr/RegexPattern.cpp: Copied from JavaScriptCore/yarr/RegexCompiler.cpp.

(JSC::Yarr::compileRegex):
(JSC::Yarr::RegexPattern::RegexPattern):

  • yarr/RegexPattern.h:
17:36 Changeset [74599] by rniwa@webkit.org

2010-12-23 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed Qt rebaselines for r74593.

  • platform/qt/editing/deleting/delete-3608445-fix-expected.txt:
  • platform/qt/editing/deleting/delete-after-span-ws-001-expected.txt:
  • platform/qt/editing/deleting/delete-after-span-ws-002-expected.txt:
  • platform/qt/editing/deleting/delete-after-span-ws-003-expected.txt:
  • platform/qt/editing/deleting/delete-block-merge-contents-010-expected.txt:
  • platform/qt/editing/deleting/delete-character-001-expected.txt:
  • platform/qt/editing/deleting/delete-hr-expected.txt:
  • platform/qt/editing/deleting/delete-line-end-ws-001-expected.txt:
  • platform/qt/editing/deleting/delete-selection-001-expected.txt:
  • platform/qt/editing/deleting/delete-trailing-ws-001-expected.txt:
  • platform/qt/editing/deleting/delete-trailing-ws-002-expected.txt:
  • platform/qt/editing/deleting/non-smart-delete-expected.txt:
  • platform/qt/editing/deleting/smart-delete-001-expected.txt:
  • platform/qt/editing/deleting/smart-delete-003-expected.txt:
  • platform/qt/editing/deleting/smart-delete-004-expected.txt:
  • platform/qt/editing/inserting/insert-3654864-fix-expected.txt:
  • platform/qt/editing/inserting/insert-after-delete-001-expected.txt:
  • platform/qt/editing/inserting/insert-br-003-expected.txt:
  • platform/qt/editing/inserting/insert-br-006-expected.txt:
  • platform/qt/editing/inserting/insert-br-007-expected.txt:
  • platform/qt/editing/inserting/insert-br-008-expected.txt:
  • platform/qt/editing/inserting/insert-br-009-expected.txt:
  • platform/qt/editing/inserting/insert-br-at-tabspan-002-expected.txt:
  • platform/qt/editing/inserting/insert-br-at-tabspan-003-expected.txt:
  • platform/qt/editing/inserting/insert-div-003-expected.txt:
  • platform/qt/editing/inserting/insert-div-006-expected.txt:
  • platform/qt/editing/inserting/insert-div-008-expected.txt:
  • platform/qt/editing/inserting/insert-div-024-expected.txt:
  • platform/qt/editing/inserting/insert-space-in-empty-doc-expected.txt:
  • platform/qt/editing/inserting/insert-text-at-tabspan-001-expected.txt:
  • platform/qt/editing/inserting/insert-text-at-tabspan-002-expected.txt:
  • platform/qt/editing/inserting/typing-001-expected.txt:
  • platform/qt/editing/inserting/typing-002-expected.txt:
  • platform/qt/editing/inserting/typing-003-expected.txt:
  • platform/qt/editing/inserting/typing-around-br-001-expected.txt:
  • platform/qt/editing/inserting/typing-around-image-001-expected.txt:
  • platform/qt/editing/pasteboard/4076267-3-expected.txt:
  • platform/qt/editing/pasteboard/cut-text-001-expected.txt:
  • platform/qt/editing/pasteboard/interchange-newline-1-expected.txt:
  • platform/qt/editing/pasteboard/merge-end-1-expected.txt:
  • platform/qt/editing/pasteboard/merge-end-2-expected.txt:
  • platform/qt/editing/pasteboard/merge-end-4-expected.txt:
  • platform/qt/editing/pasteboard/merge-end-list-expected.txt:
  • platform/qt/editing/pasteboard/merge-end-table-expected.txt:
  • platform/qt/editing/pasteboard/paste-match-style-001-expected.txt:
  • platform/qt/editing/pasteboard/paste-text-019-expected.txt:
  • platform/qt/editing/pasteboard/paste-text-at-tabspan-002-expected.txt:
  • platform/qt/editing/pasteboard/paste-text-at-tabspan-003-expected.txt:
  • platform/qt/editing/pasteboard/pasting-object-expected.txt:
  • platform/qt/editing/pasteboard/smart-paste-002-expected.txt:
  • platform/qt/editing/pasteboard/smart-paste-006-expected.txt:
  • platform/qt/editing/pasteboard/smart-paste-007-expected.txt:
  • platform/qt/editing/style/remove-underline-from-stylesheet-expected.txt:
  • platform/qt/editing/undo/redo-style-expected.txt:
17:19 Changeset [74598] by evan@chromium.org

2010-12-23 Evan Martin <evan@chromium.org>

Reviewed by Ryosuke Niwa.

[chromium] LayoutTestController warning in float->int conversion
https://bugs.webkit.org/show_bug.cgi?id=51553

Rather than reading an int, converting to a float, then getting a compiler
warning on passing the float to something that expects an int, instead
just pass around ints.

No tests, fixes a compiler warning.

  • DumpRenderTree/chromium/LayoutTestController.cpp: (parsePageSizeParameters): (LayoutTestController::pageNumberForElementById): (LayoutTestController::numberOfPages):
17:16 Changeset [74597] by jberlin@webkit.org

Need WebKit2 API to create a SecurityOrigin from protocol, host, and port
https://bugs.webkit.org/show_bug.cgi?id=51563

Reviewed by Sam Weinig.

WebCore:

Add SecurityOrigin::create(const String& protocol, const String& host, int port).

  • WebCore.exp.in:

Export the symbols for WebCore::SecurityOrigin::create(String, String, int).

  • page/SecurityOrigin.cpp:

(WebCore::SecurityOrigin::createFromDatabaseIdentifier):
Use the constant MaxAllowedPort.
(WebCore::SecurityOrigin::create):
Sanitizing based off of that done in createFromDatabaseIdentifier.

  • page/SecurityOrigin.h:

WebKit2:

Add WKSecurityOriginCreate(WKStringRef protocol, WKStringRef host, int port).

  • Shared/API/c/WKSecurityOrigin.cpp:

(WKSecurityOriginCreateFromIdentifier):
Renamed so as not to clash with the new WKSecurityOriginCreate.
(WKSecurityOriginCreate):

  • Shared/API/c/WKSecurityOrigin.h:
  • Shared/WebSecurityOrigin.h:

(WebKit::WebSecurityOrigin::create):

17:11 Changeset [74596] by paroga@webkit.org

2010-12-23 Patrick Gansterer <paroga@webkit.org>

Unreviewed build fix for WinCE after r73802.

Reapply r70812:
Port ContextMenuItemWin.cpp to WinCE
https://bugs.webkit.org/show_bug.cgi?id=48407

  • platform/win/ContextMenuItemWin.cpp:
17:03 Changeset [74595] by paroga@webkit.org

2010-12-23 Patrick Gansterer <paroga@webkit.org>

Unreviewed build fix for WinCE after r74360.

Move the OS(WINDOWS) section after the OS(WINCE) section
and add missing argument to the getStackMax call.

  • wtf/StackBounds.cpp: (WTF::StackBounds::initialize):
16:55 Changeset [74594] by abarth@webkit.org

2010-12-23 Adam Barth <abarth@webkit.org>

Remove include of non-existant file.

  • bindings/v8/custom/V8DOMWindowCustom.cpp:
16:22 Changeset [74593] by rniwa@webkit.org

2010-12-23 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

Selection becomes stale when CharacterData is manipulated directly
https://bugs.webkit.org/show_bug.cgi?id=51389

The bug was caused by SelectionController's not adjusting selection when CharacterData's
m_data is modified by its API.

Fixed the bug by adding textWillBeReplaced to SelectionController and calling it in
CharacterData::textWillBeReplaced. Added newLength to setDataAndUpdate, which is passed to
textWillBeReplaced because inserting, replacing, or removing data may require moving
the offset of the selection end points (done by shouldRemovePositionAfterAdoptingTextReplacement).

Also fixed the condition for determining whether or not a node intersects the selection
in respondToNodeModification, which is extracted from nodeWillBeRemoved. The old condition
failed to recognize certain cases when selection started and ended with non-zero offsets.

Tests: editing/selection/character-data-mutation-crash.html

editing/selection/character-data-mutation.html

  • dom/CharacterData.cpp: (WebCore::CharacterData::setData): Passes newLegnth to setDataAndUpdate. (WebCore::CharacterData::appendData): Ditto. (WebCore::CharacterData::insertData): Ditto. (WebCore::CharacterData::deleteData): Ditto. (WebCore::CharacterData::replaceData): Ditto. (WebCore::CharacterData::setDataAndUpdate): Added newLegnth to the argument list, and renamed lengthOfReplacedData to oldLength; calls textWillBeReplaced.
  • dom/CharacterData.h:
  • editing/SelectionController.cpp: (WebCore::removingNodeRemovesPosition): Removed indentations from blank lines. (WebCore::SelectionController::nodeWillBeRemoved): Calls nodeWillBeRemoved. (WebCore::SelectionController::respondToNodeModification): Extracted from nodeWillBeRemoved; fixed the logic to figure out whether a node is inside the range or not. (WebCore::shouldRemovePositionAfterAdoptingTextReplacement): Added. (WebCore::SelectionController::textWillBeReplaced): Added.
  • editing/SelectionController.h:

2010-12-23 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

Selection becomes stale when CharacterData is manipulated directly
https://bugs.webkit.org/show_bug.cgi?id=51389

Added tests to ensure WebKit adjusts or clears selection when the start container
or the end container of the selection's first range is modified by CharacterData's API.

Many editing tests had to be rebaselined due to different editing delegate dumps
caused by WebKit's properly adjusting selection's offsets as editing commands modify the DOM.

  • editing/deleting/delete-by-word-001-expected.txt:
  • editing/deleting/delete-by-word-002-expected.txt:
  • editing/deleting/delete-ligature-001-expected.txt:
  • editing/deleting/delete-ligature-002-expected.txt:
  • editing/deleting/delete-ligature-003-expected.txt:
  • editing/deleting/skip-virama-001-expected.txt:
  • editing/execCommand/createLink-expected.txt:
  • editing/execCommand/hilitecolor-expected.txt:
  • editing/execCommand/unlink-expected.txt:
  • editing/inserting/insert-thai-characters-001-expected.txt:
  • editing/pasteboard/copy-in-password-field-expected.txt:
  • editing/pasteboard/paste-into-anchor-text-expected.txt:
  • editing/selection/character-data-mutation-crash-expected.txt: Added.
  • editing/selection/character-data-mutation-crash.html: Added.
  • editing/selection/character-data-mutation-expected.txt: Added.
  • editing/selection/character-data-mutation.html: Added.
  • editing/style/remove-underline-from-stylesheet-expected.txt:
  • editing/style/typing-style-003-expected.txt:
  • editing/undo/redo-style-expected.txt:
  • platform/mac/editing/deleting/collapse-whitespace-3587601-fix-expected.txt:
  • platform/mac/editing/deleting/delete-3608430-fix-expected.txt:
  • platform/mac/editing/deleting/delete-3608445-fix-expected.txt:
  • platform/mac/editing/deleting/delete-3608462-fix-expected.txt:
  • platform/mac/editing/deleting/delete-after-span-ws-001-expected.txt:
  • platform/mac/editing/deleting/delete-after-span-ws-002-expected.txt:
  • platform/mac/editing/deleting/delete-after-span-ws-003-expected.txt:
  • platform/mac/editing/deleting/delete-and-undo-expected.txt:
  • platform/mac/editing/deleting/delete-block-merge-contents-010-expected.txt:
  • platform/mac/editing/deleting/delete-block-table-expected.txt:
  • platform/mac/editing/deleting/delete-br-007-expected.txt:
  • platform/mac/editing/deleting/delete-character-001-expected.txt:
  • platform/mac/editing/deleting/delete-contiguous-ws-001-expected.txt:
  • platform/mac/editing/deleting/delete-hr-expected.txt:
  • platform/mac/editing/deleting/delete-leading-ws-001-expected.txt:
  • platform/mac/editing/deleting/delete-line-end-ws-001-expected.txt:
  • platform/mac/editing/deleting/delete-line-end-ws-002-expected.txt:
  • platform/mac/editing/deleting/delete-listitem-001-expected.txt:
  • platform/mac/editing/deleting/delete-selection-001-expected.txt:
  • platform/mac/editing/deleting/delete-tab-001-expected.txt:
  • platform/mac/editing/deleting/delete-tab-002-expected.txt:
  • platform/mac/editing/deleting/delete-tab-003-expected.txt:
  • platform/mac/editing/deleting/delete-tab-004-expected.txt:
  • platform/mac/editing/deleting/delete-trailing-ws-001-expected.txt:
  • platform/mac/editing/deleting/delete-trailing-ws-002-expected.txt:
  • platform/mac/editing/deleting/delete-ws-fixup-001-expected.txt:
  • platform/mac/editing/deleting/delete-ws-fixup-002-expected.txt:
  • platform/mac/editing/deleting/forward-delete-expected.txt:
  • platform/mac/editing/deleting/non-smart-delete-expected.txt:
  • platform/mac/editing/deleting/smart-delete-001-expected.txt:
  • platform/mac/editing/deleting/smart-delete-002-expected.txt:
  • platform/mac/editing/deleting/smart-delete-003-expected.txt:
  • platform/mac/editing/deleting/smart-delete-004-expected.txt:
  • platform/mac/editing/execCommand/insertHorizontalRule-expected.txt:
  • platform/mac/editing/input/firstrectforcharacterrange-styled-expected.txt:
  • platform/mac/editing/input/text-input-controller-expected.txt:
  • platform/mac/editing/inserting/4278698-expected.txt:
  • platform/mac/editing/inserting/editing-empty-divs-expected.txt:
  • platform/mac/editing/inserting/insert-3654864-fix-expected.txt:
  • platform/mac/editing/inserting/insert-after-delete-001-expected.txt:
  • platform/mac/editing/inserting/insert-br-003-expected.txt:
  • platform/mac/editing/inserting/insert-br-006-expected.txt:
  • platform/mac/editing/inserting/insert-br-007-expected.txt:
  • platform/mac/editing/inserting/insert-br-008-expected.txt:
  • platform/mac/editing/inserting/insert-br-009-expected.txt:
  • platform/mac/editing/inserting/insert-br-at-tabspan-002-expected.txt:
  • platform/mac/editing/inserting/insert-br-at-tabspan-003-expected.txt:
  • platform/mac/editing/inserting/insert-div-003-expected.txt:
  • platform/mac/editing/inserting/insert-div-006-expected.txt:
  • platform/mac/editing/inserting/insert-div-008-expected.txt:
  • platform/mac/editing/inserting/insert-div-024-expected.txt:
  • platform/mac/editing/inserting/insert-space-in-empty-doc-expected.txt:
  • platform/mac/editing/inserting/insert-tab-003-expected.txt:
  • platform/mac/editing/inserting/insert-text-at-tabspan-001-expected.txt:
  • platform/mac/editing/inserting/insert-text-at-tabspan-002-expected.txt:
  • platform/mac/editing/inserting/insert-text-with-newlines-expected.txt:
  • platform/mac/editing/inserting/typing-001-expected.txt:
  • platform/mac/editing/inserting/typing-002-expected.txt:
  • platform/mac/editing/inserting/typing-003-expected.txt:
  • platform/mac/editing/inserting/typing-around-br-001-expected.txt:
  • platform/mac/editing/inserting/typing-around-image-001-expected.txt:
  • platform/mac/editing/pasteboard/4076267-2-expected.txt:
  • platform/mac/editing/pasteboard/4076267-3-expected.txt:
  • platform/mac/editing/pasteboard/bad-placeholder-expected.txt:
  • platform/mac/editing/pasteboard/cut-text-001-expected.txt:
  • platform/mac/editing/pasteboard/emacs-ctrl-a-k-y-expected.txt:
  • platform/mac/editing/pasteboard/emacs-ctrl-k-y-001-expected.txt:
  • platform/mac/editing/pasteboard/interchange-newline-1-expected.txt:
  • platform/mac/editing/pasteboard/merge-end-1-expected.txt:
  • platform/mac/editing/pasteboard/merge-end-2-expected.txt:
  • platform/mac/editing/pasteboard/merge-end-4-expected.txt:
  • platform/mac/editing/pasteboard/merge-end-list-expected.txt:
  • platform/mac/editing/pasteboard/merge-end-table-expected.txt:
  • platform/mac/editing/pasteboard/paste-match-style-001-expected.txt:
  • platform/mac/editing/pasteboard/paste-text-001-expected.txt:
  • platform/mac/editing/pasteboard/paste-text-019-expected.txt:
  • platform/mac/editing/pasteboard/paste-text-at-tabspan-001-expected.txt:
  • platform/mac/editing/pasteboard/paste-text-at-tabspan-002-expected.txt:
  • platform/mac/editing/pasteboard/paste-text-at-tabspan-003-expected.txt:
  • platform/mac/editing/pasteboard/paste-xml-expected.txt:
  • platform/mac/editing/pasteboard/pasting-object-expected.txt:
  • platform/mac/editing/pasteboard/smart-paste-002-expected.txt:
  • platform/mac/editing/pasteboard/smart-paste-006-expected.txt:
  • platform/mac/editing/pasteboard/smart-paste-007-expected.txt:
  • platform/mac/editing/pasteboard/subframe-dragndrop-1-expected.txt:
  • platform/mac/editing/spelling/spelling-expected.txt:
  • platform/mac/editing/style/style-3681552-fix-001-expected.txt:
  • platform/mac/editing/style/style-3681552-fix-002-expected.txt:
  • platform/mac/editing/style/style-boundary-002-expected.txt:
  • platform/mac/editing/style/style-boundary-005-expected.txt:
  • platform/mac/editing/style/typing-style-001-expected.txt:
  • platform/mac/editing/style/typing-style-002-expected.txt:
  • platform/mac/editing/style/unbold-in-bold-expected.txt:
  • platform/mac/editing/undo/4063751-expected.txt:
  • platform/mac/editing/undo/redo-typing-001-expected.txt:
  • platform/mac/editing/undo/undo-combined-delete-boundary-expected.txt:
  • platform/mac/editing/undo/undo-combined-delete-expected.txt:
  • platform/mac/editing/undo/undo-delete-boundary-expected.txt:
  • platform/mac/editing/undo/undo-delete-expected.txt:
  • platform/mac/editing/undo/undo-forward-delete-boundary-expected.txt:
  • platform/mac/editing/undo/undo-forward-delete-expected.txt:
  • platform/mac/editing/undo/undo-misspellings-expected.txt:
  • platform/mac/editing/undo/undo-typing-001-expected.txt:
  • platform/mac/editing/unsupported-content/list-type-after-expected.txt:
  • platform/mac/editing/unsupported-content/list-type-before-expected.txt:
  • platform/mac/editing/unsupported-content/table-type-after-expected.txt:
  • platform/mac/editing/unsupported-content/table-type-before-expected.txt:
16:00 Changeset [74592] by abarth@webkit.org

2010-12-23 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Remove unneeded V8 bindings files
https://bugs.webkit.org/show_bug.cgi?id=51570

  • WebCore.gypi:
  • bindings/generic/BindingDOMWindow.h: Removed.
  • bindings/v8/specialization/V8BindingDOMWindow.h: Removed.
15:55 Changeset [74591] by andersca@apple.com

2010-12-23 Anders Carlsson <andersca@apple.com>

Reviewed by Simon Fraser.

Ensure that we are not getting too many mouse move events
https://bugs.webkit.org/show_bug.cgi?id=51568
<rdar://problem/7881470>
<rdar://problem/8735512>

Implement throttling of mouse move events.

  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::WebPageProxy): Initialize m_processingMouseMoveEvent to false.

(WebKit::WebPageProxy::handleMouseEvent):
If we're already processing a mouse move events, just update
m_nextMouseMoveEvent and return.


(WebKit::WebPageProxy::didReceiveEvent):
If we received a mouse move event, send the next mouse move event if there is one.

15:43 Changeset [74590] by mitz@apple.com

Build fix.

  • editing/EditorCommand.cpp:

(WebCore::enabledDismissCorrectionPanel):

15:42 Changeset [74589] by darin@apple.com

Try to fix crash seen on GTK bot.

  • editing/EditorCommand.cpp:

(WebCore::internalCommand): Add back empty string check I accidentally deleted in r74580.

  • WebCore.xcodeproj/project.pbxproj: Let Xcode edit the file.
15:36 Changeset [74588] by bweinstein@apple.com

Assertion when loading www.yahoo.com in WebKit2 under decodeResourceRequest
https://bugs.webkit.org/show_bug.cgi?id=51562

Reviewed by Anders Carlsson.

Don't assert that our data reference isn't empty when we try to get the data from it.
If it is empty, just return 0.

All callers are safe with this function returning 0.

  • Platform/CoreIPC/DataReference.h:

(CoreIPC::DataReference::data): Change the assert to an early return.

  • Shared/cf/ArgumentCodersCF.cpp:

(CoreIPC::decode): Add an assert, and remove a ternarny operator because the function now does

this for us (if the data is empty, return 0).

15:15 Changeset [74587] by kbr@google.com

2010-12-23 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r74561.
http://trac.webkit.org/changeset/74561
https://bugs.webkit.org/show_bug.cgi?id=51565

"Broke Chromium UI tests on Vista" (Requested by kbr_google on
#webkit).

  • src/GraphicsContext3DChromium.cpp: (WebCore::GraphicsContext3DInternal::paintRenderingResultsToCanvas):

2010-12-23 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r74561.
http://trac.webkit.org/changeset/74561
https://bugs.webkit.org/show_bug.cgi?id=51565

"Broke Chromium UI tests on Vista" (Requested by kbr_google on
#webkit).

  • platform/graphics/chromium/ImageLayerChromium.cpp: (WebCore::ImageLayerChromium::updateContentsIfDirty):
  • platform/graphics/skia/GraphicsContext3DSkia.cpp: (WebCore::GraphicsContext3D::getImageData):
15:10 Changeset [74586] by commit-queue@webkit.org

2010-12-23 Yongjun Zhang <yongjun_zhang@apple.com>

Reviewed by Darin Adler.

WebKit crashes at DebuggerCallFrame::functionName() if m_callFrame is the top global callframe.
https://bugs.webkit.org/show_bug.cgi?id=38535

WebScriptDebugger in WebKit has empty implementations for willExecuteProgram and didExecuteProgram. As a result,
if the top call frame is from a program, WebKitScriptDebugger doesn't record that callframe as the top frame, and
WebScriptDebugger's callframe stack is wrong from this point. That could cause crash if we trying to access the top
call frame from this stack when an exception throws because the saved top frame could be invalid.

To fix that, we need to maintain the call frame stack in willExecuteProgram and didExecuteProgram, as we did in
callEvent and returnEvent.

  • WebView/WebScriptDebugger.mm: (WebScriptDebugger::willExecuteProgram): (WebScriptDebugger::didExecuteProgram):
15:08 Changeset [74585] by kbr@google.com

2010-12-23 Kenneth Russell <kbr@google.com>

Unreviewed Chromium test expectations update. Fix botched update
of fast/css/box-shadow.html expectation; needed to be FAIL, not
IMAGE+TEXT IMAGE.

  • platform/chromium/test_expectations.txt:
14:49 Changeset [74584] by weinig@apple.com

Fix incorrect assertion causing all pages with subframes to crash.

  • UIProcess/WebFrameProxy.cpp:

(WebKit::WebFrameProxy::appendChild):

14:40 Changeset [74583] by darin@apple.com

Fixed out-of-order ChangeLog.

14:34 Changeset [74582] by andersca@apple.com

2010-12-23 Darin Adler <darin@apple.com>

Reviewed by Sam Weinig.

WKView should not try to do asynchronous validation for selectors that are not editor commands
https://bugs.webkit.org/show_bug.cgi?id=51555

  • UIProcess/API/mac/WKView.mm: (-[WKView validateUserInterfaceItem:]): Removed the special case for startSpeaking. Added call to commandIsSupportedFromMenuOrKeyBinding so we only try to do validation for commands that are supported. Tweaked comments and added some bug numbers. (-[WKView _setUserInterfaceItemState:enabled:state:]): Tweaked comment and added bug number.
14:23 Changeset [74581] by mihaip@chromium.org

2010-12-23 Mihai Parparita <mihaip@chromium.org>

Reviewed by Kent Tamura.

[Chromium] Add WebThemeEngine for Mac to allow scrollbar rendering to be overridden for the DRT
https://bugs.webkit.org/show_bug.cgi?id=51507

Adds WebThemeEngine for the Mac (it already has parallel definitions for
Windows and Linux) so that scrollbar thumb rendering can be overridden
for the DRT (to be consistent with the NSScroller-based rendering
used by the Mac port).

No new tests since the functionality is not exposed yet. Eventually will
result in the Chromium/Mac port being able to use the same pixel
baselines for layout tests as the Mac port.

  • platform/chromium/ChromiumBridge.h:
  • platform/chromium/ScrollbarThemeChromiumMac.mm: (WebCore::scrollbarStateToThemeState): (WebCore::ScrollbarThemeChromiumMac::paint):

2010-12-23 Mihai Parparita <mihaip@chromium.org>

Reviewed by Kent Tamura.

[Chromium] Add WebThemeEngine for Mac to allow scrollbar rendering to be overridden for the DRT
https://bugs.webkit.org/show_bug.cgi?id=51507

Adds WebThemeEngine for the Mac (it already has parallel definitions for
Windows and Linux) so that scrollbar thumb rendering can be overridden
for the DRT (to be consistent with the NSScroller-based rendering
used by the Mac port).

  • public/mac/WebThemeEngine.h: Added. (WebKit::WebThemeEngine::paintScrollbarThumb):
  • src/AssertMatchingEnums.cpp:
  • src/ChromiumBridge.cpp: (WebCore::ChromiumBridge::paintScrollbarThumb):
14:20 Changeset [74580] by darin@apple.com

2010-12-23 Darin Adler <darin@apple.com>

Reviewed by Sam Weinig.

WKView should not try to do asynchronous validation for selectors that are not editor commands
https://bugs.webkit.org/show_bug.cgi?id=51555

  • WebCore.exp.in: Added commandIsSupportedFromMenuOrKeyBinding.
  • editing/Editor.h: Reordered arguments in the Editor::Command constructor and the data members too so the frame is last. Added commandIsSupportedFromMenuOrKeyBinding.
  • editing/EditorCommand.cpp: (WebCore::supported): Removed the EditorCommandSource argument. These functions are now only used when called from DOM. (WebCore::supportedFromMenuOrKeyBinding): Ditto. (WebCore::supportedCopyCut): Ditto. (WebCore::supportedPaste): Ditto. (WebCore::enabledDismissCorrectionPanel): Changed the supported function to an enabled function. It was incorrect to say that this is "supported" only when the correction panel is up. Correct to say that it is "enabled" only then. And also probably OK to enable it even when the selection is not in editable text, as long as the panel is up. (WebCore::createCommandMap): Moved conditional commands out of the main array into a separate section at the end. (WebCore::internalCommand): Added. (WebCore::Editor::command): Changed to use the new internalCommand function and simplified by relying on the null check in the Command constructor. (WebCore::Editor::commandIsSupportedFromMenuOrKeyBinding): Added. (WebCore::Editor::Command::Command): Removed unneeded initialization of m_source, which is never looked at if m_command is 0. Added feature of passing a null command pointer to the non-default constructor. (WebCore::Editor::Command::isSupported): Changed to only call the per-command isSupported function when the command source is DOM. Accordingly that function is now called isSupportedFromDOM.

2010-12-23 Darin Adler <darin@apple.com>

Reviewed by Sam Weinig.

WKView should not try to do asynchronous validation for selectors that are not editor commands
https://bugs.webkit.org/show_bug.cgi?id=51555

  • UIProcess/API/mac/WKView.mm: (-[WKView validateUserInterfaceItem:]): Removed the special case for startSpeaking. Added call to commandIsSupportedFromMenuOrKeyBinding so we only try to do validation for commands that are supported. Tweaked comments and added some bug numbers. (-[WKView _setUserInterfaceItemState:enabled:state:]): Tweaked comment and added bug number.
14:15 Changeset [74579] by mdelaney@apple.com

2010-12-23 Matthew Delaney <mdelaney@apple.com>

Reviewed by Simon Fraser.

Incorrect layer property used noted as changed in GraphicsLayerCA::setAcceleratesDrawing
https://bugs.webkit.org/show_bug.cgi?id=51560

No new tests.

  • platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::setAcceleratesDrawing):
13:55 WebKit Team edited by evan@chromium.org
add myself to commiter list (diff)
13:28 Changeset [74578] by ajwong@chromium.org

Unreviewed. Chromium layout test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=51500

Rebaseline media control layout tests due to pixel diff from r74535

  • platform/chromium-linux/media/audio-controls-rendering-expected.checksum:
  • platform/chromium-linux/media/audio-controls-rendering-expected.png:
  • platform/chromium-linux/media/controls-after-reload-expected.checksum:
  • platform/chromium-linux/media/controls-after-reload-expected.png:
  • platform/chromium-linux/media/controls-strict-expected.checksum:
  • platform/chromium-linux/media/controls-strict-expected.png:
  • platform/chromium-linux/media/controls-styling-expected.checksum:
  • platform/chromium-linux/media/controls-styling-expected.png:
  • platform/chromium-linux/media/controls-without-preload-expected.checksum:
  • platform/chromium-linux/media/controls-without-preload-expected.png:
  • platform/chromium-linux/media/video-controls-rendering-expected.checksum:
  • platform/chromium-linux/media/video-controls-rendering-expected.png:
  • platform/chromium-linux/media/video-display-toggle-expected.checksum:
  • platform/chromium-linux/media/video-display-toggle-expected.png:
  • platform/chromium-linux/media/video-empty-source-expected.checksum:
  • platform/chromium-linux/media/video-empty-source-expected.png:
  • platform/chromium-linux/media/video-no-audio-expected.checksum:
  • platform/chromium-linux/media/video-no-audio-expected.png:
  • platform/chromium-linux/media/video-volume-slider-expected.checksum:
  • platform/chromium-linux/media/video-volume-slider-expected.png:
  • platform/chromium-mac/media/audio-controls-rendering-expected.checksum:
  • platform/chromium-mac/media/audio-controls-rendering-expected.png:
  • platform/chromium-mac/media/audio-controls-rendering-expected.txt:
  • platform/chromium-mac/media/controls-after-reload-expected.checksum:
  • platform/chromium-mac/media/controls-after-reload-expected.png:
  • platform/chromium-mac/media/controls-after-reload-expected.txt:
  • platform/chromium-mac/media/controls-strict-expected.checksum:
  • platform/chromium-mac/media/controls-strict-expected.png:
  • platform/chromium-mac/media/controls-strict-expected.txt:
  • platform/chromium-mac/media/controls-styling-expected.checksum:
  • platform/chromium-mac/media/controls-styling-expected.png:
  • platform/chromium-mac/media/controls-styling-expected.txt:
  • platform/chromium-mac/media/controls-without-preload-expected.checksum:
  • platform/chromium-mac/media/controls-without-preload-expected.png:
  • platform/chromium-mac/media/controls-without-preload-expected.txt:
  • platform/chromium-mac/media/video-display-toggle-expected.checksum:
  • platform/chromium-mac/media/video-display-toggle-expected.png:
  • platform/chromium-mac/media/video-display-toggle-expected.txt:
  • platform/chromium-mac/media/video-empty-source-expected.checksum:
  • platform/chromium-mac/media/video-empty-source-expected.png:
  • platform/chromium-mac/media/video-empty-source-expected.txt:
  • platform/chromium-mac/media/video-no-audio-expected.checksum:
  • platform/chromium-mac/media/video-no-audio-expected.png:
  • platform/chromium-mac/media/video-no-audio-expected.txt:
  • platform/chromium-mac/media/video-volume-slider-expected.checksum:
  • platform/chromium-mac/media/video-volume-slider-expected.png:
  • platform/chromium-mac/media/video-volume-slider-expected.txt:
  • platform/chromium-win/media/audio-controls-rendering-expected.checksum:
  • platform/chromium-win/media/audio-controls-rendering-expected.png:
  • platform/chromium-win/media/audio-controls-rendering-expected.txt:
  • platform/chromium-win/media/controls-after-reload-expected.checksum:
  • platform/chromium-win/media/controls-after-reload-expected.png:
  • platform/chromium-win/media/controls-after-reload-expected.txt:
  • platform/chromium-win/media/controls-strict-expected.checksum:
  • platform/chromium-win/media/controls-strict-expected.png:
  • platform/chromium-win/media/controls-strict-expected.txt:
  • platform/chromium-win/media/controls-styling-expected.checksum:
  • platform/chromium-win/media/controls-styling-expected.png:
  • platform/chromium-win/media/controls-styling-expected.txt:
  • platform/chromium-win/media/controls-without-preload-expected.checksum:
  • platform/chromium-win/media/controls-without-preload-expected.png:
  • platform/chromium-win/media/controls-without-preload-expected.txt:
  • platform/chromium-win/media/video-controls-rendering-expected.checksum:
  • platform/chromium-win/media/video-controls-rendering-expected.png:
  • platform/chromium-win/media/video-controls-rendering-expected.txt:
  • platform/chromium-win/media/video-display-toggle-expected.checksum:
  • platform/chromium-win/media/video-display-toggle-expected.png:
  • platform/chromium-win/media/video-display-toggle-expected.txt:
  • platform/chromium-win/media/video-empty-source-expected.checksum:
  • platform/chromium-win/media/video-empty-source-expected.png:
  • platform/chromium-win/media/video-empty-source-expected.txt:
  • platform/chromium-win/media/video-no-audio-expected.checksum:
  • platform/chromium-win/media/video-no-audio-expected.png:
  • platform/chromium-win/media/video-no-audio-expected.txt:
  • platform/chromium-win/media/video-volume-slider-expected.checksum:
  • platform/chromium-win/media/video-volume-slider-expected.png:
  • platform/chromium-win/media/video-volume-slider-expected.txt:
  • platform/chromium/test_expectations.txt:
13:08 Changeset [74577] by commit-queue@webkit.org

2010-12-23 Jan Erik Hanssen <jhanssen@sencha.com>

Reviewed by Andreas Kling.

[Qt] copy and paste greek symbols to Word, TextEdit results in ?'s being shown
https://bugs.webkit.org/show_bug.cgi?id=35635

Explicitly set text/html data on QClipboard as UTF-8 and also include a <meta>
tag informing the OS that the data is in UTF-8 format.

  • platform/qt/PasteboardQt.cpp: (WebCore::Pasteboard::writeSelection):

2010-12-23 Jan Erik Hanssen <jhanssen@sencha.com>

Reviewed by Andreas Kling.

[Qt] copy and paste greek symbols to Word, TextEdit results in ?'s being shown
https://bugs.webkit.org/show_bug.cgi?id=35635

Test that QClipboard contains the charset information and unicode data
after copying unicode text.

  • tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::macCopyUnicodeToClipboard):
13:02 Changeset [74576] by kbr@google.com

2010-12-23 Kenneth Russell <kbr@google.com>

Unreviewed Chromium expectations update. Suppress crashes seen on
Windows with fast/canvas/webgl/canvas-test.html and
fast/canvas/webgl/gl-pixelstorei.html.

  • platform/chromium/test_expectations.txt:
12:58 Changeset [74575] by weinig@apple.com

<rdar://problem/8799032>
REGRESSION(r74436) Crash opening many pages with WebKit2

Reviewed by Anders Carlsson.

  • Shared/cf/ArgumentCodersCF.cpp:

(CoreIPC::decode):
Fix paste-o. Decode into a CFDataRef not a CFDictionaryRef
when decoding CFDataRefs.

12:38 Changeset [74574] by jschuh@chromium.org

2010-12-23 Justin Schuh <jschuh@chromium.org>

Reviewed by Eric Seidel.

CSSCursorImageValue destructor should clear referenced element.
https://bugs.webkit.org/show_bug.cgi?id=51417

Calls correct method to clear image and renames method to avoid future confusion.

Test: svg/css/cursor-image-replace.svg

  • css/CSSCursorImageValue.cpp: (WebCore::CSSCursorImageValue::~CSSCursorImageValue):
  • svg/SVGElement.cpp: (WebCore::SVGElement::cursorImageValueRemoved):
  • svg/SVGElement.h:

2010-12-23 Justin Schuh <jschuh@chromium.org>

Reviewed by Eric Seidel.

CSSCursorImageValue destructor should clear referenced element.
https://bugs.webkit.org/show_bug.cgi?id=51417

  • svg/css/cursor-image-replace-expected.txt: Added.
  • svg/css/cursor-image-replace.svg: Added.
12:22 Changeset [74573] by kbr@google.com

2010-12-23 Kenneth Russell <kbr@google.com>

Unreviewed Chromium expectations update. Allow
fast/css/box-shadow.html to fail with IMAGE as well as IMAGE+TEXT.

  • platform/chromium/test_expectations.txt:
12:11 Changeset [74572] by weinig@apple.com

Fix build.

  • src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::didSaveToPageCache):
(WebKit::FrameLoaderClientImpl::didRestoreFromPageCache):

12:10 Changeset [74571] by weinig@apple.com

WebKit2 needs to mirror the frame tree in the UIProcess
https://bugs.webkit.org/show_bug.cgi?id=51546

Reviewed by Darin Adler.

WebCore:

  • Add client functions to notify that a frame has been added or removed from the page cache.
  • history/CachedFrame.cpp:

(WebCore::CachedFrameBase::restore):
(WebCore::CachedFrame::CachedFrame):

  • history/CachedFrame.h:
  • loader/EmptyClients.h:

(WebCore::EmptyFrameLoaderClient::didSaveToPageCache):
(WebCore::EmptyFrameLoaderClient::didRestoreFromPageCache):

  • loader/FrameLoaderClient.h:

WebKit/chromium:

  • Add client functions to notify that a frame has been added or removed from the page cache.
  • src/FrameLoaderClientImpl.cpp:

(WebKit::WebFrameLoaderClientImpl::didSaveToPageCache):
(WebKit::WebFrameLoaderClientImpl::didRestoreFromPageCache):

  • src/FrameLoaderClientImpl.h:

WebKit/efl:

  • Add client functions to notify that a frame has been added or removed from the page cache.
  • WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore::FrameLoaderClientEfl::didSaveToPageCache):
(WebCore::FrameLoaderClientEfl::didRestoreFromPageCache):

  • WebCoreSupport/FrameLoaderClientEfl.h:

WebKit/gtk:

  • Add client functions to notify that a frame has been added or removed from the page cache.
  • WebCoreSupport/FrameLoaderClientGtk.cpp:

(WebKit::FrameLoaderClient::didSaveToPageCache):
(WebKit::FrameLoaderClient::didRestoreFromPageCache):

  • WebCoreSupport/FrameLoaderClientGtk.h:

WebKit/haiku:

  • Add client functions to notify that a frame has been added or removed from the page cache.
  • WebCoreSupport/FrameLoaderClientHaiku.cpp:

(WebCore::FrameLoaderClientHaiku::didSaveToPageCache):
(WebCore::FrameLoaderClientHaiku::didRestoreFromPageCache):

  • WebCoreSupport/FrameLoaderClientHaiku.h:

WebKit/mac:

  • Add client functions to notify that a frame has been added or removed from the page cache.
  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::didSaveToPageCache):
(WebFrameLoaderClient::didRestoreFromPageCache):

WebKit/qt:

  • Add client functions to notify that a frame has been added or removed from the page cache.
  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::didSaveToPageCache):
(WebCore::FrameLoaderClientQt::didRestoreFromPageCache):

  • WebCoreSupport/FrameLoaderClientQt.h:

WebKit/win:

  • Add client functions to notify that a frame has been added or removed from the page cache.
  • WebCoreSupport/WebFrameLoaderClient.cpp:

(WebFrameLoaderClient::didSaveToPageCache):
(WebFrameLoaderClient::didRestoreFromPageCache):

  • WebCoreSupport/WebFrameLoaderClient.h:

WebKit/wince:

  • Add client functions to notify that a frame has been added or removed from the page cache.
  • WebCoreSupport/FrameLoaderClientWinCE.cpp:

(WebKit::FrameLoaderClientWinCE::didSaveToPageCache):
(WebKit::FrameLoaderClientWinCE::didRestoreFromPageCache):

  • WebCoreSupport/FrameLoaderClientWinCE.h:

WebKit/wx:

  • Add client functions to notify that a frame has been added or removed from the page cache.
  • WebKitSupport/FrameLoaderClientWx.cpp:

(WebCore::FrameLoaderClientWx::didSaveToPageCache):
(WebCore::FrameLoaderClientWx::didRestoreFromPageCache):

  • WebKitSupport/FrameLoaderClientWx.h:

WebKit2:

  • UIProcess/API/C/WKFrame.cpp:

(WKFrameCopyChildFrames):

  • UIProcess/API/C/WKFrame.h:

Add API to get the child frames of a frame.

  • UIProcess/WebFrameProxy.cpp:

(WebKit::WebFrameProxy::WebFrameProxy):
(WebKit::WebFrameProxy::disconnect):
(WebKit::WebFrameProxy::appendChild):
(WebKit::WebFrameProxy::removeChild):
(WebKit::WebFrameProxy::isDescendantOf):
(WebKit::WebFrameProxy::dumpFrameTree):
(WebKit::WebFrameProxy::didRemoveFromHierarchy):
(WebKit::WebFrameProxy::childFrames):

  • UIProcess/WebFrameProxy.h:

(WebKit::WebFrameProxy::parentFrame): Add getter.
(WebKit::WebFrameProxy::nextSibling): Add getter.
(WebKit::WebFrameProxy::previousSibling): Add getter.
(WebKit::WebFrameProxy::firstChild): Add getter.
(WebKit::WebFrameProxy::lastChild): Add getter.
Make frames keep track of their subframes.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didCreateSubframe):
Use the now passed parentID to insert the frame into the hierarchy

(WebKit::WebPageProxy::didSaveFrameToPageCache):
When a frame is added to the page cache, remove it from the hierarchy.

(WebKit::WebPageProxy::didRestoreFrameFromPageCache):
When a frame is restored from the page cache, add it back to the hierarchy.

(WebKit::WebPageProxy::didRemoveFrameFromHierarchy):
Detached frames should also be removed from the hierarchy.

  • UIProcess/WebPageProxy.h:

Add new declarations for didSaveFrameToPageCache and didRestoreFrameFromPageCache.

  • UIProcess/WebPageProxy.messages.in:

Add messages for DidSaveFrameToPageCache and DidRestoreFrameFromPageCache.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::savePlatformDataToCachedFrame):
(WebKit::WebFrameLoaderClient::transitionToCommittedFromCachedFrame):
Remove notImplemented, there is no work we need to do here.

(WebKit::WebFrameLoaderClient::didSaveToPageCache):
(WebKit::WebFrameLoaderClient::didRestoreFromPageCache):
Send message to UIProcess to indicate this happened.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::createSubframe):
Send parent frameID in addition to our own in the message to UIProcess.

11:57 Changeset [74570] by mdelaney@apple.com

2010-12-22 Matthew Delaney <mdelaney@apple.com>

Reviewed by Simon Fraser.

Add setNeedsStyleRecalc for getting canvas contexts that use IOSurfaces
This patch also changes USE_IOSURFACE to instead follow USE(IOSURFACE)
https://bugs.webkit.org/show_bug.cgi?id=51279

  • html/HTMLCanvasElement.cpp: For IOSurface, use setNeedsStyleRecalc
  • html/canvas/CanvasRenderingContext2D.cpp: Use new flag
  • platform/graphics/ImageBuffer.h: Use new flag
  • platform/graphics/cg/ImageBufferCG.cpp: Use new flag

2010-12-22 Matthew Delaney <mdelaney@apple.com>

Reviewed by Simon Fraser.

Add setNeedsStyleRecalc for getting canvas contexts that use IOSurfaces
https://bugs.webkit.org/show_bug.cgi?id=51279

  • platform/mac-snowleopard/platform/mac/compositing: Added.
  • platform/mac-snowleopard/platform/mac/compositing/canvas: Added.
  • platform/mac-snowleopard/platform/mac/compositing/canvas/accelerated-canvas-compositing-expected.txt: Added.
  • platform/mac/compositing/canvas: Added.
  • platform/mac/compositing/canvas/accelerated-canvas-compositing-expected.txt: Added.
  • platform/mac/compositing/canvas/accelerated-canvas-compositing.html: Added.
11:33 Changeset [74569] by andersca@apple.com

2010-12-23 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

New popup windows open disproportionately big
https://bugs.webkit.org/show_bug.cgi?id=51547
<rdar://problem/8637029>

  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::createNewPage): Pass the correct size back to the UI process.
  • WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::pageRect): Implement this and return the size of the page.
11:16 Changeset [74568] by enne@google.com

2010-12-20 Adrienne Walker <enne@google.com>

Reviewed by Kenneth Russell.

[chromium] Tile root layer of the compositor.
https://bugs.webkit.org/show_bug.cgi?id=49947

Refactor root layer update and drawing from LayerRendererChromium into
LayerTilerChromium. The root layer is now drawn as multiple tiles
rather than as one single large texture. Scrollbars are now drawn
separately rather than as part of the root layer.

Test: LayoutTests/compositing/

  • WebCore.gypi:
  • page/FrameView.cpp: (WebCore::FrameView::repaintContentRectangle):
  • platform/ScrollView.cpp: (WebCore::ScrollView::ScrollView): (WebCore::ScrollView::setClipsRepaints):
  • platform/ScrollView.h: (WebCore::ScrollView::clipsRepaints):
  • platform/graphics/chromium/LayerChromium.h:
  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::LayerRendererChromium): (WebCore::LayerRendererChromium::~LayerRendererChromium): (WebCore::LayerRendererChromium::useShader): (WebCore::LayerRendererChromium::verticalScrollbarRect): (WebCore::LayerRendererChromium::horizontalScrollbarRect): (WebCore::LayerRendererChromium::invalidateRootLayerRect): (WebCore::LayerRendererChromium::updateAndDrawRootLayer): (WebCore::LayerRendererChromium::drawLayers): (WebCore::LayerRendererChromium::setRootLayer): (WebCore::LayerRendererChromium::initializeSharedObjects): (WebCore::LayerRendererChromium::cleanupSharedObjects):
  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/LayerTilerChromium.cpp: Added. (WebCore::LayerTilerChromium::create): (WebCore::LayerTilerChromium::LayerTilerChromium): (WebCore::LayerTilerChromium::~LayerTilerChromium): (WebCore::LayerTilerChromium::layerRendererContext): (WebCore::LayerTilerChromium::setTileSize): (WebCore::LayerTilerChromium::reset): (WebCore::LayerTilerChromium::createTile): (WebCore::LayerTilerChromium::invalidateTiles): (WebCore::LayerTilerChromium::contentRectToTileIndices): (WebCore::LayerTilerChromium::contentRectToLayerRect): (WebCore::LayerTilerChromium::layerRectToContentRect): (WebCore::LayerTilerChromium::tileIndex): (WebCore::LayerTilerChromium::tileContentRect): (WebCore::LayerTilerChromium::tileLayerRect): (WebCore::LayerTilerChromium::invalidateRect): (WebCore::LayerTilerChromium::invalidateEntireLayer): (WebCore::LayerTilerChromium::update): (WebCore::LayerTilerChromium::setLayerPosition): (WebCore::LayerTilerChromium::draw): (WebCore::LayerTilerChromium::resizeLayer): (WebCore::LayerTilerChromium::growLayerToContain): (WebCore::LayerTilerChromium::Tile::~Tile): (WebCore::LayerTilerChromium::Tile::releaseTextureId):
  • platform/graphics/chromium/LayerTilerChromium.h: Added. (WebCore::LayerTilerChromium::Tile::Tile): (WebCore::LayerTilerChromium::Tile::textureId): (WebCore::LayerTilerChromium::Tile::dirty): (WebCore::LayerTilerChromium::Tile::clearDirty): (WebCore::LayerTilerChromium::layerRenderer):

2010-12-20 Adrienne Walker <enne@google.com>

Reviewed by Kenneth Russell.

[chromium] Tile root layer of the compositor.
https://bugs.webkit.org/show_bug.cgi?id=49947

Refactor root layer logic out of WebViewImpl and into
LayerTilerChromium. The painting is now done through an interface
rather than directly in WebViewImpl.

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::scrollRootLayerRect): (WebKit::WebViewImpl::invalidateRootLayerRect): (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): (WebKit::WebViewImplTilePaintInterface::WebViewImplTilePaintInterface): (WebKit::WebViewImplTilePaintInterface::paint): (WebKit::WebViewImplScrollbarPaintInterface::WebViewImplScrollbarPaintInterface): (WebKit::WebViewImplScrollbarPaintInterface::paint): (WebKit::WebViewImpl::doComposite):
  • src/WebViewImpl.h:
11:06 Changeset [74567] by kbr@google.com

2010-12-23 Kenneth Russell <kbr@google.com>

Unreviewed Chromium expectations update. Fix incorrect syntax for
fast/css/box-shadow.html suppression and state that
fast/events/touch/touch-target.html may timeout.

  • platform/chromium/test_expectations.txt:
10:59 Changeset [74566] by rniwa@webkit.org

2010-12-22 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Eric Seidel.

Editor.h doesn't need to include SelectionController.h
https://bugs.webkit.org/show_bug.cgi?id=51441

Renamed SelectionController::EDirection to SelectionDirection.

  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::executeCommand):

2010-12-22 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Eric Seidel.

Editor.h doesn't need to include SelectionController.h
https://bugs.webkit.org/show_bug.cgi?id=51441

Renamed SelectionController::EDirection to SelectionDirection.

  • WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::handleKeyboardEvent):

2010-12-22 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Eric Seidel.

Editor.h doesn't need to include SelectionController.h
https://bugs.webkit.org/show_bug.cgi?id=51441

Renamed SelectionController::EDirection to SelectionDirection.

  • WebView/WebFrame.mm: (-[WebFrame _rangeByAlteringCurrentSelection:SelectionController::direction:granularity:]): Takes SelectionDirection instead of SelectionController::EDirection.
  • WebView/WebFrameInternal.h:
  • WebView/WebTextCompletionController.mm: (-[WebTextCompletionController doCompletion]): Calls _rangeByAlteringCurrentSelection:SelectionController.

2010-12-22 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Eric Seidel.

Editor.h doesn't need to include SelectionController.h
https://bugs.webkit.org/show_bug.cgi?id=51441

Renamed SelectionController::EDirection to SelectionDirection.

  • WebCoreSupport/EditorClientHaiku.cpp: (WebCore::EditorClientHaiku::handleKeyboardEvent):

2010-12-22 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Eric Seidel.

Editor.h doesn't need to include SelectionController.h
https://bugs.webkit.org/show_bug.cgi?id=51441

Renamed SelectionController::EDirection to SelectionDirection.

  • WebCoreSupport/EditorClientWinCE.cpp: (WebKit::EditorClientWinCE::handleEditingKeyboardEvent):

2010-12-22 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Eric Seidel.

Editor.h doesn't need to include SelectionController.h
https://bugs.webkit.org/show_bug.cgi?id=51441

Renamed SelectionController::EDirection to SelectionDirection.

  • WebCoreSupport/EditorClientEfl.cpp: (WebCore::EditorClientEfl::handleEditingKeyboardEvent):

2010-12-22 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Eric Seidel.

Editor.h doesn't need to include SelectionController.h
https://bugs.webkit.org/show_bug.cgi?id=51441

Removed #include <Selection.h> from Editor.h.
Also extracted WritingDirection.h from EditingStyle.h and renamed SelectionController::EDirection
to SelectionDirection and moved its declaration from SelectionController.h to VisibleSelection.h

  • WebCore.exp.in: Signature changes.
  • WebCore.xcodeproj/project.pbxproj: Added WritingDirection.h
  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::visiblePositionRangeForLine): Change due to SelectionDirection.
  • editing/EditingStyle.h: Removed WritingDirection and included WritingDirection.h
  • editing/Editor.cpp: (WebCore::Editor::deleteWithDirection): Change due to SelectionDirection. (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): Ditto. (WebCore::Editor::markMisspellingsAfterTypingToWord): Ditto.
  • editing/Editor.h: Removed SelectionController.h; added DocumentMarker.h, Timer.h, VisibleSelection.h and WritingDirection.h; forward declared CSSMutableStyleDeclaration.
  • editing/EditorCommand.cpp: (WebCore::executeDeleteBackward): Change due to SelectionDirection. (WebCore::executeDeleteBackwardByDecomposingPreviousCharacter): Ditto. (WebCore::executeDeleteForward): Ditto. (WebCore::executeDeleteToBeginningOfLine): Ditto. (WebCore::executeDeleteToBeginningOfParagraph): Ditto. (WebCore::executeDeleteToEndOfLine): Ditto. (WebCore::executeDeleteToEndOfParagraph): Ditto. (WebCore::executeDeleteWordBackward): Ditto. (WebCore::executeDeleteWordForward): Ditto. (WebCore::executeForwardDelete): Ditto. (WebCore::executeMoveBackward): Ditto. (WebCore::executeMoveBackwardAndModifySelection): Ditto. (WebCore::executeMoveDown): Ditto. (WebCore::executeMoveDownAndModifySelection): Ditto. (WebCore::executeMoveForward): Ditto. (WebCore::executeMoveForwardAndModifySelection): Ditto. (WebCore::executeMoveLeft): Ditto. (WebCore::executeMoveLeftAndModifySelection): Ditto. (WebCore::executeMoveRight): Ditto. (WebCore::executeMoveRightAndModifySelection): Ditto. (WebCore::executeMoveToBeginningOfDocument): Ditto. (WebCore::executeMoveToBeginningOfDocumentAndModifySelection): Ditto. (WebCore::executeMoveToBeginningOfLine): Ditto. (WebCore::executeMoveToBeginningOfLineAndModifySelection): Ditto. (WebCore::executeMoveToBeginningOfParagraph): Ditto. (WebCore::executeMoveToBeginningOfParagraphAndModifySelection): Ditto. (WebCore::executeMoveToBeginningOfSentence): Ditto. (WebCore::executeMoveToBeginningOfSentenceAndModifySelection): Ditto. (WebCore::executeMoveToEndOfDocument): Ditto. (WebCore::executeMoveToEndOfDocumentAndModifySelection): Ditto. (WebCore::executeMoveToEndOfSentence): Ditto. (WebCore::executeMoveToEndOfSentenceAndModifySelection): Ditto. (WebCore::executeMoveToEndOfLine): Ditto. (WebCore::executeMoveToEndOfLineAndModifySelection): Ditto. (WebCore::executeMoveToEndOfParagraph): Ditto. (WebCore::executeMoveToEndOfParagraphAndModifySelection): Ditto. (WebCore::executeMoveParagraphBackwardAndModifySelection): Ditto. (WebCore::executeMoveParagraphForwardAndModifySelection): Ditto. (WebCore::executeMoveUp): Ditto. (WebCore::executeMoveUpAndModifySelection): Ditto. (WebCore::executeMoveWordBackward): Ditto. (WebCore::executeMoveWordBackwardAndModifySelection): Ditto. (WebCore::executeMoveWordForward): Ditto. (WebCore::executeMoveWordForwardAndModifySelection): Ditto. (WebCore::executeMoveWordLeft): Ditto. (WebCore::executeMoveWordLeftAndModifySelection): Ditto. (WebCore::executeMoveWordRight): Ditto. (WebCore::executeMoveWordRightAndModifySelection): Ditto. (WebCore::executeMoveToLeftEndOfLine): Ditto. (WebCore::executeMoveToLeftEndOfLineAndModifySelection): Ditto. (WebCore::executeMoveToRightEndOfLine): Ditto. (WebCore::executeMoveToRightEndOfLineAndModifySelection): Ditto.
  • editing/SelectionController.cpp: (WebCore::SelectionController::willBeModified): Takes SelectionDirection instead of EDirection. (WebCore::SelectionController::modify): Ditto.
  • editing/SelectionController.h: Change due to SelectionDirection.
  • editing/TypingCommand.cpp: (WebCore::TypingCommand::deleteKeyPressed): Ditto. (WebCore::TypingCommand::forwardDeleteKeyPressed): Ditto.
  • editing/VisibleSelection.h: Added SelectionDirection, renamed and moved from EDirection in SelectionController.h
  • editing/WritingDirection.h: Added.
  • page/DOMSelection.cpp: (WebCore::DOMSelection::modify): Change due to SelectionDirection. (WebCore::DOMSelection::deleteFromDocument): Ditto.
  • page/EventHandler.cpp: (WebCore::EventHandler::handleKeyboardSelectionMovement): Ditto.
  • page/Frame.h: Includes SelectionController.h.
10:17 Changeset [74565] by lforschler@apple.com

2010-12-23 Lucas Forschler <lforschler@apple.com>

Reviewed by Darin Adler.

Bug 51537 - iexploder needs cleanup

  • iExploder/htdocs: Removed.
  • iExploder/htdocs/config.rb: Removed.
  • iExploder/htdocs/cssproperties.in: Removed.
  • iExploder/htdocs/cssvalues.in: Removed.
  • iExploder/htdocs/htmlattrs.in: Removed.
  • iExploder/htdocs/htmltags.in: Removed.
  • iExploder/htdocs/htmlvalues.in: Removed.
  • iExploder/htdocs/iexploder.cgi: Removed.
  • iExploder/htdocs/iexploder.rb: Removed.
  • iExploder/htdocs/index.html: Removed.
  • iExploder/htdocs/webserver.rb: Removed.
  • iExploder/iexploder-1.7.2/output: Removed.
  • iExploder/tools: Removed.
  • iExploder/tools/lasthit.rb: Removed.
  • iExploder/tools/osx_last_crash.rb: Removed.
  • iExploder/tools/showtest.rb: Removed.
10:16 Changeset [74564] by andersca@apple.com

2010-12-23 Anders Carlsson <andersca@apple.com>

Reviewed by John Sullivan.

Nothing happens clicking "launch live player" on live.cnn.com
https://bugs.webkit.org/show_bug.cgi?id=51540
<rdar://problem/8791086>

Implement NPN_PushPopupsEnabledState/NPN_PopPopupsEnabledState.

  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp: (WebKit::NPN_PushPopupsEnabledState): Call NetscapePlugin::pushPopupsEnabledState.

(WebKit::NPN_PopPopupsEnabledState):
Call NetscapePlugin::popPopupsEnabledState.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp: (WebKit::NetscapePlugin::pushPopupsEnabledState): Append the boolean to the vector.

(WebKit::NetscapePlugin::popPopupsEnabledState):
Remove the last boolean from the vector.

(WebKit::NetscapePlugin::allowPopups):
Return the last boolean from the vector.

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:
  • WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::performJavaScriptURLRequest): Update the "allowPopupsFromPlugin" state.
09:45 Changeset [74563] by abarth@webkit.org

2010-12-23 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Move V8 to WebCore's implementation of showModalDialog
https://bugs.webkit.org/show_bug.cgi?id=51527

This code is basically verbatim translation from the JavaScriptCore
bindings. The only intentional difference is in the world selection
for the dialog's frame. I suspect JavaScriptCore's bindings have a
subtle bug there.

In this patch, I also remove a bunch of now-unneeded code in the
generic bindings.

  • bindings/generic/BindingDOMWindow.h:
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::DialogHandler::dialogCreated): (WebCore::setUpDialog):
  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::DialogHandler::DialogHandler): (WebCore::DialogHandler::dialogCreated): (WebCore::DialogHandler::returnValue): (WebCore::setUpDialog): (WebCore::V8DOMWindow::showModalDialogCallback): (WebCore::V8DOMWindow::openCallback):
  • bindings/v8/specialization/V8BindingDOMWindow.h:
09:26 Changeset [74562] by apavlov@chromium.org

2010-12-23 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Joseph Pecoraro.

Web Inspector: Can't backspace from CSS value to CSS key field
https://bugs.webkit.org/show_bug.cgi?id=51476

  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertyTreeElement.prototype.): (WebInspector.StylePropertyTreeElement.prototype):
08:56 Changeset [74561] by commit-queue@webkit.org

2010-12-23 W. James MacLean <wjmaclean@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Add asserts to test for contiguous-pixel Skia bitmaps.
https://bugs.webkit.org/show_bug.cgi?id=51186

No new tests. Behaviour not changed, but need the asserts to detect when assumptions violated.

  • platform/graphics/chromium/ImageLayerChromium.cpp: (WebCore::ImageLayerChromium::updateContentsIfDirty):
  • platform/graphics/skia/GraphicsContext3DSkia.cpp: (WebCore::GraphicsContext3D::getImageData):

2010-12-23 W. James MacLean <wjmaclean@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Add asserts to test for contiguous-pixel Skia bitmaps.
https://bugs.webkit.org/show_bug.cgi?id=51186

Add asserts to detect if assumptions (about contiguous pixels in Skia bitmaps) are violated.

  • src/GraphicsContext3DChromium.cpp: (WebCore::GraphicsContext3DInternal::paintRenderingResultsToCanvas):
08:53 Changeset [74560] by jberlin@webkit.org

Add Windows-XP-specific (failing) expected results for
fast/profiler/throw-exception-from-eval-expected.html in order to get the Windows XP Debug
test bot green again. Unreviewed.
https://bugs.webkit.org/show_bug.cgi?id=49801

  • platform/win-xp/fast/profiler: Added.
  • platform/win-xp/fast/profiler/throw-exception-from-eval-expected.txt: Added.
08:39 Changeset [74559] by commit-queue@webkit.org

2010-12-23 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Make 'single' the default backing store in EWebLauncher
https://bugs.webkit.org/show_bug.cgi?id=51534

'single' is the simplest backing store and the one intended to be the
default in the test browser. By mistake the tiled backing store was
left as default in r72617.

  • EWebLauncher/main.c: (browserCreate): ditto.
08:23 Changeset [74558] by commit-queue@webkit.org

2010-12-23 Dawit Alemayehu <adawit@kde.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Add a 'hasSelection' function to QWebView and QWebPage.
https://bugs.webkit.org/show_bug.cgi?id=48722

This is a convenience API that optimizes the case where checking for
the presence of selected content and accessing the selected content
are two separate actions in the client. See comment #12 in the above
bug report link for details.

  • Api/qwebpage.cpp: (QWebPage::hasSelection):
  • Api/qwebpage.h:
  • Api/qwebview.cpp: (QWebView::hasSelection):
  • Api/qwebview.h:
  • tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::textSelection):
06:45 Changeset [74557] by jeremy@chromium.org

2010-12-23 Jeremy Moskovich <jeremy@chromium.org>

Unreviewed new Chromium baselines and test expectations update.

  • platform/chromium-linux/fast/layers/video-layer-expected.checksum:
  • platform/chromium-linux/fast/layers/video-layer-expected.png:
  • platform/chromium-mac/fast/layers/video-layer-expected.checksum:
  • platform/chromium-mac/fast/layers/video-layer-expected.png:
  • platform/chromium-mac/fast/layers/video-layer-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-win/fast/layers/video-layer-expected.checksum:
  • platform/chromium-win/fast/layers/video-layer-expected.png:
  • platform/chromium-win/fast/layers/video-layer-expected.txt:
  • platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium/test_expectations.txt:
06:41 Changeset [74556] by commit-queue@webkit.org

2010-12-23 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Fix ContextMenu removal
https://bugs.webkit.org/show_bug.cgi?id=51530

Fix ContextMenu removal

In r74207 the support for ContextMenu was removed from EFL while the
code is being ported to the new CROSS_PLATFORM_MENUS due to build
breakage. However there were some missing removals in the shutdown
logic that introduced a bug, leading to a segmentation fault when
ContexController was destroyed.

The best way to effectively disable the ContextMenu is to conditionally
compile the meaningful stuff by surrounding with "#if
ENABLE(CONTEXT_MENUS)" and then disabling it in CMake.

  • cmake/OptionsEfl.cmake: Disable ContextMenu and don't pretend we implement CROSS_PLATFORM_MENUS yet.

2010-12-23 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Fix ContextMenu removal
https://bugs.webkit.org/show_bug.cgi?id=51530

Fix ContextMenu removal

In r74207 the support for ContextMenu was removed from EFL while the
code is being ported to the new CROSS_PLATFORM_MENUS due to build
breakage. However there were some missing removals in the shutdown
logic that introduced a bug, leading to a segmentation fault when
ContexController was destroyed.

The best way to effectively disable the ContextMenu is to conditionally
compile the meaningful stuff by surrounding with "#if
ENABLE(CONTEXT_MENUS)" and then disabling it in CMake.

  • ewk/ewk_contextmenu.cpp: surround need parts with #if ENABLE(CONTEXT_MENUS). (ewk_context_menu_destroy): ditto. (ewk_context_menu_item_select): ditto.
  • ewk/ewk_private.h: ditto.
  • ewk/ewk_view.cpp: ditto.
06:24 Changeset [74555] by commit-queue@webkit.org

2010-12-23 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

Fix check by undefined macro
https://bugs.webkit.org/show_bug.cgi?id=51531

Fix check by undefined macro

When building EFL port with libsoup, BUILDING_GTK is not defined,
leading to warnings during compile. We actually have to use an #ifdef
instead of an #if.

No change in functionality so no new tests.

  • platform/network/soup/cache/webkit/soup-cache.h:
06:08 Changeset [74554] by commit-queue@webkit.org

2010-12-23 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Clean warnings in Tiled Backing Store
https://bugs.webkit.org/show_bug.cgi?id=51529

Tiled backing store in EFL was giving the following warnings that are
gone now:

  • Static function defined but not used;
  • Comparison between signed and unsigned integer expressions;
  • ewk/ewk_tiled_backing_store.c: (_ewk_tiled_backing_store_item_fill): (_ewk_tiled_backing_store_smart_calculate):
  • ewk/ewk_tiled_matrix.c: (_ewk_tile_matrix_slicer_setup):
05:49 Changeset [74553] by commit-queue@webkit.org

2010-12-23 Jonathan Dixon <joth@chromium.org>

Reviewed by Steve Block.

TouchEvents does not support multi-touch on a page with multiple touch targets
https://bugs.webkit.org/show_bug.cgi?id=51258

  • fast/events/touch/multi-touch-grouped-targets-expected.txt: Added.
  • fast/events/touch/multi-touch-grouped-targets.html: Added.
  • fast/events/touch/script-tests/multi-touch-grouped-targets.js: Added. (declareTouchHandler.return.shouldBe): (declareTouchHandler): (touchEndHandler): Added new test that ensures both test targets receive events when hit by multiple touch points from the same platform event.
  • fast/events/touch/script-tests/touch-target-limited.js: (declareTouchStart.return.touchStartHandler): (declareTouchStart): (declareTouchMove.return.touchMoveHandler): (declareTouchMove):
  • fast/events/touch/script-tests/touch-target.js: (declareTouchStart.return.touchStartHandler): (declareTouchStart): (declareTouchMove.return.touchMoveHandler): (declareTouchMove):
  • fast/events/touch/touch-target-expected.txt:
  • fast/events/touch/touch-target-limited-expected.txt: Updated & rebaselined existing tests to reflect new expectations.

2010-12-23 Jonathan Dixon <joth@chromium.org>

Reviewed by Steve Block.

TouchEvents does not support multi-touch on a page with multiple touch targets
https://bugs.webkit.org/show_bug.cgi?id=51258

Test: fast/events/touch/multi-touch-grouped-targets.html

  • page/EventHandler.cpp: (WebCore::eventNameForTouchPointState): (WebCore::EventHandler::handleTouchEvent): Redesigned event handler to ensure all event targets involved in a given multitouch event get the appropriate event(s) fired.
  • platform/PlatformTouchPoint.h: Added end-stop marker for State enum.
05:23 Changeset [74552] by commit-queue@webkit.org

2010-12-23 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Subject: [webkit 4/4] [EFL] Remove non-sense workaround
https://bugs.webkit.org/show_bug.cgi?id=51533

There's no point in concatenating env("HOME") with "blah", so remove
option from EWebLauncher.

  • EWebLauncher/main.c: (main): ditto.
05:14 Changeset [74551] by philn@webkit.org

2010-12-23 Philippe Normand <pnormand@igalia.com>

Reviewed by Xan Lopez.

[GTK] media/audio-data-url.html fails since r75504
https://bugs.webkit.org/show_bug.cgi?id=51525

Make the GStreamer media-player advertize 3gpp mime-types as
supported if the 3gp caps are in the typefind factories.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::mimeTypeCache):
05:09 Changeset [74550] by jeremy@chromium.org

2010-12-23 Jeremy Moskovich <jeremy@chromium.org>

Unreviewed test expectations update.

Fix duplicate expectation warning for media/video-controls-rendering.html introduced in r74535.

  • platform/chromium/test_expectations.txt:
04:56 Changeset [74549] by tkent@chromium.org

Refactor HTMLInputElement: Move a part of HTMLInputElement::defaultEventHandler()
to InputTypes.
https://bugs.webkit.org/show_bug.cgi?id=51093

Reviewed by Dimitri Glazkov.

Move BeforeTextInserted and Wheel event handling, event forwarding to
renderers, and the isindex form submission quirk code to InputTypes.
Also, change the return types of InputType event handlers from 'bool'
to 'void'. We use Event::defaultHandled() to decide whether event
handling should be stopped.

No new tests because this is just a refactoring.

  • html/BaseButtonInputType.cpp: bool->void changes

(WebCore::BaseButtonInputType::handleKeydownEvent):
(WebCore::BaseButtonInputType::handleKeypressEvent):
(WebCore::BaseButtonInputType::handleKeyupEvent):

  • html/BaseButtonInputType.h: ditto.
  • html/BaseCheckableInputType.cpp: ditto.

(WebCore::BaseCheckableInputType::handleKeydownEvent):
(WebCore::BaseCheckableInputType::handleKeypressEvent):

  • html/BaseCheckableInputType.h: ditto.
  • html/BaseDateAndTimeInputType.cpp:

(WebCore::BaseDateAndTimeInputType::handleKeydownEvent): ditto.
(WebCore::BaseDateAndTimeInputType::handleWheelEvent): Just calls handleWheelEventForSpinButton().

  • html/BaseDateAndTimeInputType.h: bool->void change and handleWhellEvent() addition.
  • html/CheckboxInputType.cpp: bool->void change

(WebCore::CheckboxInputType::handleKeyupEvent):

  • html/CheckboxInputType.h: ditto.
  • html/FileInputType.cpp: ditto.

(WebCore::FileInputType::handleDOMActivateEvent):

  • html/FileInputType.h: ditto.
  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::defaultEventHandler):

  • Change return-value handling of InputType event handlers
  • Move out beforeTextInserted/wheel event handling and isindex form quirk.
  • html/HTMLInputElement.h:

(WebCore::HTMLInputElement::handleBeforeTextInsertedEvent):

Added so that InputType can call InputElement::handleBeforeTextInsertedEvent().

  • html/ImageInputType.cpp: bool->void change

(WebCore::ImageInputType::handleDOMActivateEvent):

  • html/ImageInputType.h: ditto.
  • html/InputType.cpp: ditto.

(WebCore::InputType::handleClickEvent):
(WebCore::InputType::handleDOMActivateEvent):
(WebCore::InputType::handleKeydownEvent):
(WebCore::InputType::handleKeypressEvent):
(WebCore::InputType::handleKeyupEvent):
(WebCore::InputType::handleBeforeTextInsertedEvent):
(WebCore::InputType::handleWheelEvent): Added default implementation.
(WebCore::InputType::forwardEvent): ditto.
(WebCore::InputType::formForSubmission): ditto.

  • html/InputType.h:
  • html/IsIndexInputType.cpp:

(WebCore::IsIndexInputType::formForSubmission): Moved from HTMLInputElement.cpp.

  • html/IsIndexInputType.h:
  • html/NumberInputType.cpp:

(WebCore::isNumberCharacter): Moved from HTMLInputElement.cpp.
(WebCore::NumberInputType::handleKeydownEvent): bool->void change.
(WebCore::NumberInputType::handleBeforeTextInsertedEvent): Moved from HTMInputElement.cpp.
(WebCore::NumberInputType::handleWheelEvent): Added. Just calls handleWheelEventForSpinButton().

  • html/NumberInputType.h:
  • html/RadioInputType.cpp: bool->void changes.

(WebCore::RadioInputType::handleClickEvent):
(WebCore::RadioInputType::handleKeydownEvent):
(WebCore::RadioInputType::handleKeyupEvent):

  • html/RadioInputType.h:
  • html/RangeInputType.cpp:

(WebCore::RangeInputType::handleKeydownEvent): ditto.
(WebCore::RangeInputType::forwardEvent): Moved from HTMLInputElement.cpp.

  • html/RangeInputType.h:
  • html/ResetInputType.cpp: bool->void change.

(WebCore::ResetInputType::handleDOMActivateEvent):

  • html/ResetInputType.h: ditto.
  • html/SubmitInputType.cpp: ditto.

(WebCore::SubmitInputType::handleDOMActivateEvent):

  • html/SubmitInputType.h: ditto.
  • html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::handleKeydownEvent): bool->void change.
(WebCore::TextFieldInputType::handleKeydownEventForSpinButton): ditto.
(WebCore::TextFieldInputType::handleWheelEventForSpinButton): Moved from HTMLInputElement.cpp.
(WebCore::TextFieldInputType::forwardEvent): ditto.

  • html/TextFieldInputType.h:
03:12 Changeset [74548] by apavlov@chromium.org

2010-12-23 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Joseph Pecoraro.

Web Inspector: After scrolling new property value and cancelling, removed property remains active in page style
https://bugs.webkit.org/show_bug.cgi?id=51390

  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertyTreeElement.prototype):
02:38 Changeset [74547] by ossy@webkit.org

Unreviewed. Update Qt specific expected file after r74539.

  • platform/qt/fast/dom/Window/window-properties-expected.txt:
02:20 Changeset [74546] by commit-queue@webkit.org

2010-12-23 Benjamin Kalman <kalman@chromium.org>

Reviewed by Eric Seidel.

QT linux has RTL line movement bug that causes editing/selection/extend-to-line-boundary.html to fail
https://bugs.webkit.org/show_bug.cgi?id=51514

Add different baseline to editing/selection/extend-to-line-boundary.html for qt-linux that
takes into account the RTL bug.

  • platform/qt-linux/editing/selection/extend-to-line-boundary-expected.txt: Added.
01:54 Changeset [74545] by antti@apple.com

Not reviewed.

Another attempt.

  • http/tests/local/slow-css-pass.cgi:
01:20 Changeset [74544] by loislo@chromium.org

2010-12-23 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Eric Seidel.

Web Inspector: chromium: inspector's tests are quite slow especially at windows(Debug).

Almost all inspector's tests become flaky on chromium Win(dbg) after switching to DRT.
I just discovered that we have two additional GC runs per each WebViewHost.
Test_shell had no such calls.
These gc runs eat 15% of cpu time.

https://bugs.webkit.org/show_bug.cgi?id=51479

  • DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::~WebViewHost):
01:18 Changeset [74543] by antti@apple.com

Not reviewed.

Flaky Test: http/tests/local/stylesheet-and-script-load-order-media-print.html

Try to fix flakiness.

  • http/tests/local/slow-css-pass.cgi:
00:17 Changeset [74542] by gyuyoung.kim@samsung.com

2010-12-23 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Unreviewed build warning fix.

[EFL] Remove warning messages during the webkit efl compiling
https://bugs.webkit.org/show_bug.cgi?id=51520

Remove build warning messages.

  • ewk/ewk_view.cpp: (_ewk_view_smart_show): (_ewk_view_smart_hide):
  • ewk/ewk_view.h:
00:00 Changeset [74541] by commit-queue@webkit.org

2010-12-23 Noel Gordon <noel.gordon@gmail.com>

Reviewed by Adam Barth.

[chromium] Reduce canvas.toDataURL("image/png") run-time costs 300%
https://bugs.webkit.org/show_bug.cgi?id=51455

Chromium uses the libpng compression defaults. Good compression results,
but at much larger run-time cost compared to other browsers. Chrome is 2
times slower than Mozilla 3.6.12 and 3-4 times slower than Safari 5.0.3.

libpng has supported alternative compression methods for some time, they
better meet the dual goals of good compression and run-time cost for the
on-line case, and are well-documented. Here use Huffman encoding. It's
2-20% faster than other encodings (Z_RLE, Z_FILTERED) and the compressed
size is within 1% of the Safari 5.0.3 result independent of image size.

No change in behaviour, so no new tests.

  • platform/image-encoders/skia/PNGImageEncoder.cpp: (WebCore::PNGImageEncoder::encode): Apply Huffman image encoding.

12/22/10:

23:43 Changeset [74540] by commit-queue@webkit.org

2010-12-22 Noel Gordon <noel.gordon@gmail.com>

Reviewed by Darin Fisher.

[chromium] Optimize canvas.toDataURL("image/png") unpremultiplication loop
https://bugs.webkit.org/show_bug.cgi?id=51321

Follow on from r73890, unroll the SkUnPreMultiply::PMColorToColor() call for
the "image/png" encoder case viz., compute the unpremultiplication in-place.
See https://bugs.webkit.org/show_bug.cgi?id=50804 for reference.

No new tests: canvas.toDataURL() is covered by existing tests.

  • platform/image-encoders/skia/PNGImageEncoder.cpp: (WebCore::preMultipliedBGRAtoRGBA):
22:55 Changeset [74539] by ariya@webkit.org

2010-12-22 Ariya Hidayat <ariya@sencha.com>

Reviewed by Simon Fraser.

Implement skewX() and skewY() for CSSMatrix.
https://bugs.webkit.org/show_bug.cgi?id=38335

  • fast/dom/Window/window-properties-expected.txt: Adjusted.
  • transforms/cssmatrix-2d-interface.xhtml: Added tests for skewX() and skewY().
  • transforms/cssmatrix-2d-interface-expected.txt: Adjusted.

2010-12-22 Ariya Hidayat <ariya@sencha.com>

Reviewed by Simon Fraser.

Implement skewX() and skewY() for CSSMatrix.
https://bugs.webkit.org/show_bug.cgi?id=38335

  • css/WebKitCSSMatrix.cpp: (WebCore::WebKitCSSMatrix::skew): Implemented skewX() and skewY().
  • css/WebKitCSSMatrix.h: Added skewX() and skewY().
  • css/WebKitCSSMatrix.idl: Added skewX() and skewY().
21:45 Changeset [74538] by simon.fraser@apple.com

2010-12-22 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

Support unprefixed box-shadow property
https://bugs.webkit.org/show_bug.cgi?id=51448

Add support for the box-shadow CSS property. We'll currently render this
similarly to -webkit-box-shadow, but a later fix will adjust the blur radius
handling to match the spec.

Test: fast/css/box-shadow.html

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Implement getComputedStyle for box-shadow
  • css/CSSParser.cpp: (WebCore::CSSParser::parseValue): (WebCore::ShadowParseContext::ShadowParseContext): (WebCore::ShadowParseContext::commitValue): (WebCore::ShadowParseContext::commitLength): (WebCore::ShadowParseContext::commitColor): Support CSSPropertyBoxShadow
  • css/CSSPropertyNames.in: add box-shadow
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): Add CSSPropertyBoxShadow, and store in the ShadowData if this is -webkit-box-shadow or not. We'll use this to adjust radii later.
  • css/SVGCSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applySVGProperty): Add CSSPropertyBoxShadow.
  • page/animation/AnimationBase.cpp: (WebCore::blendFunc): (WebCore::PropertyWrapperShadow::blend): (WebCore::AnimationBase::ensurePropertyMap): Support animations of box-shadow.
  • rendering/style/ShadowData.cpp: Store a flag to say if this is a -webkit-box-shadow. (WebCore::ShadowData::ShadowData): (WebCore::ShadowData::operator==):
  • rendering/style/ShadowData.h: (WebCore::ShadowData::ShadowData): (WebCore::ShadowData::isWebkitBoxShadow):
21:39 Changeset [74537] by msaboff@apple.com

2010-12-22 Michael Saboff <msaboff@apple.com>

Reviewed by Sam Weinig.

REGRESSION: Can't shadow/overwrite window.constructor
(causes TypeError exception)
https://bugs.webkit.org/show_bug.cgi?id=48953

Added code in the javascript code generator to create a setter for
a constructor if the new extended attribute ReplaceableConstructor
is present for the interface.

  • bindings/scripts/CodeGeneratorJS.pm:
  • page/DOMWindow.idl:

2010-12-22 Michael Saboff <msaboff@apple.com>

Reviewed by Sam Weinig.

REGRESSION: Can't shadow/overwrite window.constructor
(causes TypeError exception)
https://bugs.webkit.org/show_bug.cgi?id=48953

Changed cross-frame-access-put test results to reflect that setting
the window constructor will be disallowed due to cross frame security
checking.
Added a new test to check that we can change window.constructor.

  • fast/dom/Window/window-constructor-settable-expected.txt: Added.
  • fast/dom/Window/window-constructor-settable.html: Added.
  • http/tests/security/cross-frame-access-put-expected.txt:
21:27 Changeset [74536] by mihaip@chromium.org

2010-12-22 Mihai Parparita <mihaip@chromium.org>

Unreviewed test expectations update. fast/canvas/fillText-shadow.html
fails with Skia in the GPU suite too.

  • platform/chromium-gpu/test_expectations.txt:
21:25 Changeset [74535] by commit-queue@webkit.org

2010-12-22 Steve Lacey <sjl@chromium.org>

Reviewed by David Levin.

Change css for chromium media controls to deal with the timeline
not expanding when the current time disappears. This happens when
the width of the control drops below 240px.

This change results in a minor pixel difference - the timebar now
aligns better with the time and when the time is not displayed is
now perfectly centered. Disabling the affected tests for now
and will rebaseline.

https://bugs.webkit.org/show_bug.cgi?id=51500

  • platform/chromium/test_expectations.txt:

2010-12-22 Steve Lacey <sjl@chromium.org>

Reviewed by David Levin.

Change css for chromium media controls to deal with the timeline
not expanding when the current time disappears. This happens when
the width of the control drops below 240px.

This change results in a minor pixel difference - the timebar now
aligns better with the time and when the time is not displayed is
now perfectly centered. Disabling the affected tests for now
and will rebaseline.

https://bugs.webkit.org/show_bug.cgi?id=51500

  • css/mediaControlsChromium.css: (audio::-webkit-media-controls-timeline-container, video::-webkit-media-controls-timeline-container): (audio::-webkit-media-controls-current-time-display, video::-webkit-media-controls-current-time-display): (audio::-webkit-media-controls-time-remaining-display, video::-webkit-media-controls-time-remaining-display): (audio::-webkit-media-controls-timeline, video::-webkit-media-controls-timeline):
21:05 Changeset [74534] by mihaip@chromium.org

2010-12-22 Mihai Parparita <mihaip@chromium.org>

Unreviewed test expectations update. fast/canvas/fillText-shadow.html
fails with Skia.

  • platform/chromium/test_expectations.txt:
20:01 Changeset [74533] by jberlin@webkit.org

Add Windows-specific (failing) expected results for media/audio-data-url.html in order to get
the Windows 7 Release test bot green again. Unreviewed.
https://bugs.webkit.org/show_bug.cgi?id=51518

  • platform/win/media/audio-data-url-expected.txt: Added.
19:25 Changeset [74532] by mihaip@chromium.org

2010-12-22 Mihai Parparita <mihaip@chromium.org>

Reviewed by Simon Fraser.

the shadow direction is negated in canvas context shadowOffsetY.
https://bugs.webkit.org/show_bug.cgi?id=25619

Add test to verify that shadowOffsetY is handled correctly.

  • fast/canvas/fillText-shadow-expected.txt: Added.
  • fast/canvas/fillText-shadow.html: Added.

2010-12-22 Mihai Parparita <mihaip@chromium.org>

Reviewed by Simon Fraser.

the shadow direction is negated in canvas context shadowOffsetY.
https://bugs.webkit.org/show_bug.cgi?id=25619

Invert shadow offset Y direction in 0-blur path in FontMac::drawGlyps
if we're not transforming shadows (i.e. are rendering in a canvas). Also
use CG shadows if there's a non-translate/flip transform applied
(shadow offsets are supposed to ignore transforms, but the naive/simple
implementation was taking them into account).

Also does the equivalent changes to FontCGWin.

Test: fast/canvas/fillText-shadow.html

  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::shadowsIgnoreTransforms):
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/mac/FontMac.mm: (WebCore::Font::drawGlyphs):
  • platform/graphics/win/FontCGWin.cpp: (WebCore::Font::drawGlyphs):
18:59 Changeset [74531] by andersca@apple.com

2010-12-22 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Webkit2: WebProcess crashes when Private browsing is turned on on yahoo.com
https://bugs.webkit.org/show_bug.cgi?id=51516
<rdar://problem/8766995>

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp: (WebKit::NetscapePlugin::NPP_SetValue): Add a null check for NPP_SetValue.
18:53 Changeset [74530] by andersca@apple.com

2010-12-22 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

REGRESSION (WK2): Plugins swallow CMD-W, CMD-Q, and probably other shortcuts
https://bugs.webkit.org/show_bug.cgi?id=51515
<rdar://problem/8740926>

Always return false for keyboard events where the command key is down.

  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm: (WebKit::NetscapePlugin::platformHandleKeyboardEvent):
18:44 Changeset [74529] by tonyg@chromium.org

2010-12-22 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r74503.
http://trac.webkit.org/changeset/74503
https://bugs.webkit.org/show_bug.cgi?id=51513

breaks chromium mac debug compile (Requested by tonyg-cr on
#webkit).

  • platform/graphics/chromium/ImageLayerChromium.cpp: (WebCore::ImageLayerChromium::updateContentsIfDirty):
  • platform/graphics/skia/GraphicsContext3DSkia.cpp: (WebCore::GraphicsContext3D::getImageData):

2010-12-22 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r74503.
http://trac.webkit.org/changeset/74503
https://bugs.webkit.org/show_bug.cgi?id=51513

breaks chromium mac debug compile (Requested by tonyg-cr on
#webkit).

  • src/GraphicsContext3DChromium.cpp: (WebCore::GraphicsContext3DInternal::paintRenderingResultsToCanvas):
17:57 Changeset [74528] by weinig@apple.com

WebProcess should be terminated if invalid frameIDs are
passed to the UIProcess.
https://bugs.webkit.org/show_bug.cgi?id=51508

Reviewed by Darin Adler.

  • Introduce a mechanism to mark a messages as invalid due to reasons other than in ability to decode the message, eg. an invalid frameID is passed in a message.
  • Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::Connection):
(CoreIPC::Connection::markCurrentlyDispatchedMessageAsInvalid): Sets
the m_didReceiveInvalidMessage bit so that it can be picked up in
(CoreIPC::Connection::dispatchMessages): Check for m_didReceiveInvalidMessage in
addition to tainted arguments.

  • Platform/CoreIPC/Connection.h:

Add base macro for others to extend, that calls markCurrentlyDispatchedMessageAsInvalid()
ASSERTs, and returns.

  • UIProcess/WebPageProxy.cpp:

Add Message checks for all WebFrameProxy's gotten from frameIDs passed
over the wire.

  • UIProcess/WebProcessProxy.cpp:

(WebKit::isGoodMapKey):
Checks that the key can be inserted safely into a map (eg. not the empty or deleted value).

(WebKit::WebProcessProxy::webFrame):
Return null for bad keys (eg. 0 or -1).

(WebKit::WebProcessProxy::canCreateFrame):
Added. Checks that the ID is good and not in the map yet. Used
as a consistency check before creating frames.

(WebKit::WebProcessProxy::frameCreated):
ASSERT that the key is good, in addition to not in the map yet.

(WebKit::WebProcessProxy::didDestroyFrame):
ASSERT that the key is good.

  • UIProcess/WebProcessProxy.h:

Move WebFrameProxy HashMap type into a typedef.

17:45 Changeset [74527] by darin@apple.com

2010-12-22 Darin Adler <darin@apple.com>

Reviewed by Anders Carlsson.

WebKit2 needs a way to return the main resource data
https://bugs.webkit.org/show_bug.cgi?id=51510

  • UIProcess/API/C/WKFrame.cpp: (WKFrameGetMainResourceData): Added. (callGetMainResourceDataBlockAndDispose): Added. (WKFrameGetMainResourceData_b): Added.
  • UIProcess/API/C/WKFrame.h: Added WKFrameGetMainResourceData.
  • UIProcess/WebFrameProxy.cpp: (WebKit::WebFrameProxy::getMainResourceData): Added.
  • UIProcess/WebFrameProxy.h: Ditto.
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::getMainResourceDataOfFrame): Added. (WebKit::WebPageProxy::dataCallback): Replaced the individual callbacks with just these two. (WebKit::WebPageProxy::stringCallback): Ditto.
  • UIProcess/WebPageProxy.h: Ditto.
  • UIProcess/WebPageProxy.messages.in: Ditto.
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::runJavaScriptInMainFrame): Send the string callback message instead of a specific one. (WebKit::WebPage::getContentsAsString): Ditto. (WebKit::WebPage::getRenderTreeExternalRepresentation): Ditto. (WebKit::WebPage::getSelectionOrContentsAsString): Ditto. (WebKit::WebPage::getSourceForFrame): Ditto. (WebKit::WebPage::getMainResourceDataOfFrame): Added. (WebKit::WebPage::getWebArchiveOfFrame): Send the data callback message instead of a specific one.
  • WebProcess/WebPage/WebPage.h: Added getMainResourceDataOfFrame.
  • WebProcess/WebPage/WebPage.messages.in: Ditto.
17:35 Changeset [74526] by mitz@apple.com

Replace runtime checks for hyphenation API availability with compile-time checks.

Reviewed by Darin Adler.

  • platform/text/cf/HyphenationCF.cpp:

(WebCore::::createValueForNullKey): Changed to use CFLocaleCopyCurrent() instead of using the
search locale, which is empty on Windows. On Mac, this is equivalent to using the search locale.
(WebCore::canHyphenate): Added this implementation for when the hyphenation API is not available.
It is identical to the implementation in Hyphenation.cpp.
(WebCore::lastHyphenLocation): Ditto.

17:26 Changeset [74525] by dpranke@chromium.org

2010-12-22 Dirk Pranke <dpranke@chromium.org>

Reviewed by Ojan Vafai.

This change splits out the TestRunner class into its own file.
When we fork the code for message passing, we will create a new
TestRunner, and this change will allow that to be more modular.

While we're at it, split out TestInput and ResultSummary into
their own files, to reduce the size of run_webkit_tests to
something more managable.

https://bugs.webkit.org/show_bug.cgi?id=51092

  • Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
  • Scripts/webkitpy/layout_tests/layout_package/result_summary.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_input.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:

2010-12-22 Dirk Pranke <dpranke@chromium.org>

Reviewed by Ojan Vafai.

nrwt multiprocessing - start over, prepare to fork the code

This code cleans up the signatures and implementation of the
TestRunner class so we can easily fork it to run either the
stable implementation or the new, unstable message-passing
implementation. The two variants will have different
implementations of the run_tests() method. We will switch
between the two based on the setting for the '--worker-model'
switch. We rename the two currently valid values to 'old-inline'
and 'old-threads'.

https://bugs.webkit.org/show_bug.cgi?id=51081

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
17:17 Changeset [74524] by simon.fraser@apple.com

2010-12-22 Simon Fraser <simon.fraser@apple.com>

Reviewed by Darin Adler.

Cache snapshots of plug-ins before painting, to avoid script running during painting
https://bugs.webkit.org/show_bug.cgi?id=51493

When FrameView is asked to do a flattening paint (e.g. when Safari snapshots,
or when printing), plug-ins which otherwise use the CA rendering model
are sent a paint event. Some plug-ins may run script while handling this event,
or out of process plug-ins may process queued requests at this time. Running
script while inside layout or painting can have bad consequences, because it
can result in arbitrary changes to the render tree.

This patch avoids sending plug-ins paint events inside of painting. Instead,
we ask the plug-ins to cache a snapshot before we paint, and then the software
paint simply draws that snapshot.

Requires manual test, because the bug happens when Safari does
a page snapshot. It's not possible to tell the Test Netscape Plug-in
to paint without laying out, making an automated test impossible.

  • manual-tests/plugins/plugin-paint-causes-layout.html: Added.
  • page/FrameView.h:
  • page/FrameView.cpp: (WebCore::FrameView::paintContents): Notify all enclosed widgets that a flattening paint is going to happen. (WebCore::FrameView::notifyWidgetsInAllFrames): Utility method that tells the RenderView in all subframes to notify their widgets.
  • platform/Widget.h: (WebCore::Widget::notifyWidget): Generic method that can be used to send messages to widgets. Current messages are just 'before flattening paint' and 'after flattening paint'. Message has no payload.
  • rendering/RenderView.h:
  • rendering/RenderView.cpp: (WebCore::RenderView::getRetainedWidgets): (WebCore::RenderView::releaseWidgets): Factor code out of updateWidgetPositions(), since we use it in two places now.

(WebCore::RenderView::updateWidgetPositions): Use getRetainedWidgets() etc.
(WebCore::RenderView::notifyWidgets): Retain all the widgets, then send
them all the message.

  • rendering/RenderWidget.h:
  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::notifyWidget): Pass the message to the widget.
  • Plugins/Hosted/WebHostedNetscapePluginView.mm: (-[WebHostedNetscapePluginView drawRect:]): If we have a cached snapshot, draw it. Also only send the snapshot message to the plugin proxy if we know we're snapshotting, since even if creating the snapshot image failed, we still don't want to call to the plug-in.
  • Plugins/WebBaseNetscapePluginView.h: Add a retained NSImage member for the snapshot.
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView cacheSnapshot]): Create an image and draw the snapshot into it. (-[WebBaseNetscapePluginView clearCachedSnapshot]): Clear the snapshot.
  • Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView drawRect:]): If we have a cached snapshot, use it.
  • WebCoreSupport/WebFrameLoaderClient.mm: (NetscapePluginWidget::notifyWidget): Implement notifyWidget() and use it to cache and clear the snapshots.
16:55 Changeset [74523] by dpranke@chromium.org

2010-12-22 Dirk Pranke <dpranke@chromium.org>

Reviewed by Ojan Vafai.

nrwt multiprocessing - start over, prepare to fork the code

This code cleans up the signatures and implementation of the
TestRunner class so we can easily fork it to run either the
stable implementation or the new, unstable message-passing
implementation. The two variants will have different
implementations of the run_tests() method. We will switch
between the two based on the setting for the '--worker-model'
switch. We rename the two currently valid values to 'old-inline'
and 'old-threads'.

https://bugs.webkit.org/show_bug.cgi?id=51081

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
16:50 Changeset [74522] by darin@apple.com
  • WebProcess/WebPage/WebPage.cpp: Add #if to try to fix non-Mac builds.
16:44 Changeset [74521] by darin@apple.com

2010-12-22 Darin Adler <darin@apple.com>

Reviewed by Anders Carlsson.

Make Speech menu items work in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=51504

  • UIProcess/API/C/WKFrame.cpp: (WKFrameGetWebArchive): Updated to use new-named typedef.
  • UIProcess/API/C/WKPage.cpp: (WKPageRunJavaScriptInMainFrame): Ditto. (WKPageRenderTreeExternalRepresentation): Ditto. (WKPageGetSourceForFrame): Ditto. (WKPageGetContentsAsString): Ditto.
  • UIProcess/API/mac/WKView.mm: (menuItem): Added. Helper function to make it easy to call menu item functions on arbitrary user interface items. (toolbarItem): Ditto. (-[WKView validateUserInterfaceItem:]): Added validation for startSpeaking and stopSpeaking commands. Reworked the code to fix a bug where toggleContinuousSpellChecking would always be enabled even when it should be disabled. Reworked the asynchronous validation code so it works for items other than menu items and can also handle more than one item for the same command. Added some comments. (speakString): Added. Helper function to be used as a callback when we get the selection or contents to speak. (-[WKView startSpeaking:]): Added. Uses getSelectionOrContentsAsString. (-[WKView stopSpeaking:]): Added. (-[WKView _setUserInterfaceItemState:enabled:state:]): Reworked to work with the changes to validateUserInterfaceItem above.
  • UIProcess/WebFrameProxy.cpp: (WebKit::WebFrameProxy::isDisplayingMarkupDocument): Added a FIXME about a problem I noticed. (WebKit::WebFrameProxy::didCommitLoad): Tweaked argument name. (WebKit::WebFrameProxy::getWebArchive): Changed to use new-named typedef.
  • UIProcess/WebFrameProxy.h: Changed WebArchiveCallback to DataCallaback.
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::close): Invalidate the two callback maps since we only have two now. (WebKit::WebPageProxy::runJavaScriptInMainFrame): Changed to use merged maps and typedefs so we don't need a separate callback map for each function. (WebKit::WebPageProxy::getRenderTreeExternalRepresentation): Ditto. (WebKit::WebPageProxy::getSourceForFrame): Ditto. (WebKit::WebPageProxy::getContentsAsString): Ditto. (WebKit::WebPageProxy::getSelectionOrContentsAsString): Added. (WebKit::WebPageProxy::getWebArchiveOfFrame): Ditto. (WebKit::WebPageProxy::didGetContentsAsString): Ditto. (WebKit::WebPageProxy::didGetSelectionOrContentsAsString): Ditto. (WebKit::WebPageProxy::didRunJavaScriptInMainFrame): Ditto. (WebKit::WebPageProxy::didGetRenderTreeExternalRepresentation): Ditto. (WebKit::WebPageProxy::didGetSourceForFrame): Ditto. (WebKit::WebPageProxy::didGetWebArchiveOfFrame): Ditto. (WebKit::WebPageProxy::processDidCrash): Ditto.
  • UIProcess/WebPageProxy.h: Updated for changes above.
  • UIProcess/WebPageProxy.messages.in: Added DidGetSelectionOrContentsAsString, GetIsSpeaking, Speak, and StopSpeaking.
  • UIProcess/mac/WebPageProxyMac.mm: (WebKit::WebPageProxy::getIsSpeaking): Added. (WebKit::WebPageProxy::speak): Added. (WebKit::WebPageProxy::stopSpeaking): Added.
  • WebProcess/WebCoreSupport/mac/WebContextMenuClientMac.mm: (WebKit::WebContextMenuClient::isSpeaking): Call WebPage instead of doing the work directly, so it can run in the UI process. (WebKit::WebContextMenuClient::speak): Ditto. (WebKit::WebContextMenuClient::stopSpeaking): Ditto. (WebKit::WebContextMenuClient::searchWithSpotlight): Added FIXME comment and changed code to avoid a C-style cast.
  • WebProcess/WebPage/WebFrame.cpp: (WebKit::WebFrame::selectionAsString): Added.
  • WebProcess/WebPage/WebFrame.h: Ditto.
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::changeAcceleratedCompositingMode): Use sendSync in the modern way instead of explicitly calling WebProcess. (WebKit::WebPage::getSelectionOrContentsAsString): Added. (WebKit::WebPage::isSpeaking): Added. (WebKit::WebPage::speak): Added. (WebKit::WebPage::stopSpeaking): Added.
  • WebProcess/WebPage/WebPage.h: Added functions.
  • WebProcess/WebPage/WebPage.messages.in: Added GetSelectionOrContentsAsString.
16:39 Changeset [74520] by laszlo.1.gombos@nokia.com

2010-12-22 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Unreviewed build fix.

[Symbian] Make sure OSAllocatorSymbian builds

This patch only addresses the build problem.

https://bugs.webkit.org/show_bug.cgi?id=51128 tracks the full
(re)implementation of the Symbian allocator.

  • wtf/OSAllocatorSymbian.cpp: (WTF::OSAllocator::reserveUncommitted): (WTF::OSAllocator::reserveAndCommit): (WTF::OSAllocator::commit):
16:36 Changeset [74519] by jianli@chromium.org

Merge 74435 - Rebaseline test for r74427.

  • http/tests/local/formdata/send-form-data-with-sliced-file-expected.txt: Updated.

TBR=jianli@chromium.org
Review URL: http://codereview.chromium.org/6042006

16:36 Changeset [74518] by andersca@apple.com

Fix build.

  • Platform/mac/MachUtilities.cpp:
16:33 Changeset [74517] by jianli@chromium.org

Merge 74427 - 2010-12-21 Jian Li <jianli@chromium.org>

Reviewed by Darin Adler.

Fix bug 51366: REGRESSION (r66452): Form data no longer contains
'Content-Type' header for files with unrecognized extensions
https://bugs.webkit.org/show_bug.cgi?id=51366

Test: http/tests/local/formdata/form-data-with-unknown-file-extension.html

  • platform/network/FormData.cpp: (WebCore::FormData::appendKeyValuePairItems):

2010-12-21 Jian Li <jianli@chromium.org>

Reviewed by Darin Adler.

Fix bug 51366: REGRESSION (r66452): Form data no longer contains
'Content-Type' header for files with unrecognized extensions
https://bugs.webkit.org/show_bug.cgi?id=51366

  • http/tests/local/formdata/form-data-with-unknown-file-extension-expected.txt: Added.
  • http/tests/local/formdata/form-data-with-unknown-file-extension.html: Added.
  • http/tests/local/resources/file.invalid: Added.

TBR=jianli@chromium.org
Review URL: http://codereview.chromium.org/6077007

16:27 Changeset [74516] by enne@google.com

2010-12-22 Adrienne Walker <enne@google.com>

Reviewed by Kenneth Russell.

Fix null pointer deref when restoring a lost WebGL context.
https://bugs.webkit.org/show_bug.cgi?id=51494

No new tests, as context restored events are not currently testable.

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::initializeNewContext): (WebCore::WebGLRenderingContext::restoreContext):
16:16 Changeset [74515] by commit-queue@webkit.org

2010-12-22 Adam Bergkvist <adam.bergkvist@ericsson.com>

Reviewed by Martin Robinson.

[GTK] Building with Blob support fails again
https://bugs.webkit.org/show_bug.cgi?id=51392

Build fix.

  • GNUmakefile.am:
16:15 Changeset [74514] by andersca@apple.com

2010-12-22 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler.

Detect WebProcess crashes sooner, without waiting for ReportCrash to finish
https://bugs.webkit.org/show_bug.cgi?id=51505

  • Platform/CoreIPC/CoreIPCMessageKinds.h: Add SetExceptionPort.
  • Platform/CoreIPC/mac/ConnectionMac.cpp: (CoreIPC::Connection::platformInvalidate): If we have an exception port, unregister it.

(CoreIPC::Connection::platformInitialize):
Set m_exceptionPort to null.

(CoreIPC::Connection::open):
If we have an exception port, register an event handler for it and send it over
to the other side.

(CoreIPC::Connection::receiveSourceEventHandler):
Handle the SetExceptionPort message.

(CoreIPC::Connection::exceptionSourceEventHandler):
Receive the message, forward it to the real exception handler and call connectionDidClose.

(CoreIPC::Connection::setShouldCloseConnectionOnMachExceptions):
Create an exception port.

  • Platform/mac/MachUtilities.cpp: (machExceptionPort): (setMachExceptionPort):
  • Platform/mac/MachUtilities.h: Add helper functions for getting and setting the mach exception port.
  • UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::didFinishLaunching): Call setShouldCloseConnectionOnMachExceptions on Mac.
16:13 Changeset [74513] by mitz@apple.com

2010-12-22 Dan Bernstein <mitz@apple.com>

Reviewed by Anders Carlsson.

canHyphenate() always returns true for the default locale
https://bugs.webkit.org/show_bug.cgi?id=51506

No test, since this change only affects performance.

  • platform/text/cf/HyphenationCF.cpp: (WebCore::::createValueForNullKey): Return 0 if hyphenation is not supported for the default locale. (WebCore::::createValueForKey): Removed whitespace.
15:58 Changeset [74512] by ariya@webkit.org

2010-12-22 Ariya Hidayat <ariya@sencha.com>

Reviewed by Simon Fraser.

Transform applied via CSSMatrix does not take full page zoom into account
https://bugs.webkit.org/show_bug.cgi?id=24808

The bug has been fixed with r74430 and r74451.
These two are just the tests.

  • transforms/2d/cssmatrix-2d-zoom-expected.checksum: Added.
  • transforms/2d/cssmatrix-2d-zoom-expected.png: Added.
  • transforms/2d/cssmatrix-2d-zoom-expected.txt: Added.
  • transforms/2d/cssmatrix-2d-zoom.html: Added.
  • transforms/3d/general/cssmatrix-3d-zoom-expected.checksum: Added.
  • transforms/3d/general/cssmatrix-3d-zoom-expected.png: Added.
  • transforms/3d/general/cssmatrix-3d-zoom-expected.txt: Added.
  • transforms/3d/general/cssmatrix-3d-zoom.html: Added.
15:47 Changeset [74511] by victorw@chromium.org

2010-12-22 Victor Wang <victorw@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Update chromium archive test result url in rebaseline script.

https://bugs.webkit.org/show_bug.cgi?id=51503

  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
15:34 Changeset [74510] by jianli@chromium.org

Tests that File.type returns empty string for file with invalid extension.
https://bugs.webkit.org/show_bug.cgi?id=51501

Reviewed by David Levin.

  • editing/pasteboard/file-input-files-access-expected.txt:
  • editing/pasteboard/resources/file.invalidext: Added.
  • editing/pasteboard/script-tests/file-input-files-access.js:
15:32 Changeset [74509] by commit-queue@webkit.org

2010-12-22 Steve Lacey <sjl@chromium.org>

Reviewed by David Levin.

[chromium] Rebaseline chromium media/controls-styling layout test and re-enable.
https://bugs.webkit.org/show_bug.cgi?id=51427

  • platform/chromium-linux/media/controls-styling-expected.checksum: Added.
  • platform/chromium-linux/media/controls-styling-expected.png: Added.
  • platform/chromium-mac/media/controls-styling-expected.checksum: Added.
  • platform/chromium-mac/media/controls-styling-expected.png: Added.
  • platform/chromium-mac/media/controls-styling-expected.txt: Added.
  • platform/chromium-win/media/controls-styling-expected.checksum: Added.
  • platform/chromium-win/media/controls-styling-expected.png: Added.
  • platform/chromium-win/media/controls-styling-expected.txt:
  • platform/chromium/test_expectations.txt:
15:30 Changeset [74508] by andersca@apple.com

2010-12-22 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Move Mach message receiving code out into a new function
https://bugs.webkit.org/show_bug.cgi?id=51502

  • Platform/CoreIPC/mac/ConnectionMac.cpp: (CoreIPC::readFromMachPort): (CoreIPC::Connection::receiveSourceEventHandler):
15:05 Changeset [74507] by commit-queue@webkit.org

2010-12-22 Jeff Miller <jeffm@apple.com>

Reviewed by Sam Weinig.

InjectedBundle methods should use the relative URL constructor for KURL instead of the ParsedURLStringTag version
https://bugs.webkit.org/show_bug.cgi?id=51491

The url passed to various InjectedBundle methods is not from KURL::string(), i.e. it has not already been parsed by KURL,
so we have to use the relative URL constructor for KURL instead of the ParsedURLStringTag version.

  • WebProcess/InjectedBundle/InjectedBundle.cpp: (WebKit::InjectedBundle::addUserScript): (WebKit::InjectedBundle::addUserStyleSheet): (WebKit::InjectedBundle::removeUserScript): (WebKit::InjectedBundle::removeUserStyleSheet):
14:39 Changeset [74506] by yurys@chromium.org

2010-12-22 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Joseph Pecoraro.

Web Inspector: script name gets parsed as HTML in Call stack panel
https://bugs.webkit.org/show_bug.cgi?id=51468

  • inspector/front-end/Placard.js: (WebInspector.Placard.prototype.set subtitle):
14:22 Changeset [74505] by xan@webkit.org

2010-12-22 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

  • configure.ac: bump version to 1.3.9.

WebKit/gtk:

2010-12-22 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

  • NEWS: update for 1.3.9 release.
14:11 Changeset [74504] by eric.carlson@apple.com

2010-12-22 Eric Carlson <eric.carlson@apple.com>

Reviewed by Darin Adler.

MediaPlayer should look for MIME type in data: URL
https://bugs.webkit.org/show_bug.cgi?id=51195

If no MIME type is passed from the media element for a data: URL, try to get it from
the URL itself.

No new tests are possible because the MIME type is just passed to the media engine.

  • platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::load):
14:03 Changeset [74503] by commit-queue@webkit.org

2010-12-22 W. James MacLean <wjmaclean@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Add asserts to test for contiguous-pixel Skia bitmaps.
https://bugs.webkit.org/show_bug.cgi?id=51186

No new tests. Behaviour not changed, but need the asserts to detect when assumptions violated.

  • platform/graphics/chromium/ImageLayerChromium.cpp: (WebCore::ImageLayerChromium::updateContentsIfDirty):
  • platform/graphics/skia/GraphicsContext3DSkia.cpp: (WebCore::GraphicsContext3D::getImageData):

2010-12-22 W. James MacLean <wjmaclean@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Add asserts to test for contiguous-pixel Skia bitmaps.
https://bugs.webkit.org/show_bug.cgi?id=51186

Add asserts to detect if assumptions (about contiguous pixels in Skia bitmaps) are violated.

  • src/GraphicsContext3DChromium.cpp: (WebCore::GraphicsContext3DInternal::paintRenderingResultsToCanvas):
13:42 Changeset [74502] by commit-queue@webkit.org

2010-12-22 Shane Stephens <shanestephens@google.com>

Reviewed by David Levin.

[Chromium] SLOW lines in chromium test_expectations.txt for svg tests which are no longer slow.
https://bugs.webkit.org/show_bug.cgi?id=51429

  • platform/chromium/test_expectations.txt:
13:34 Changeset [74501] by cfleizach@apple.com

WebCore: WAI-ARIA menubar role mapped to AXGroup, should be AXMenuBar
https://bugs.webkit.org/show_bug.cgi?id=51488

Reviewed by Darin Adler.

Test: platform/mac/accessibility/aria-menubar.html

  • accessibility/AccessibilityObject.cpp:

(WebCore::createARIARoleMap):

LayoutTests: Update fast/canvas/webgl/gl-uniform-arrays.html to bring in sync with Khronos
https://bugs.webkit.org/show_bug.cgi?id=51489

Patch by Kenneth Russell <kbr@google.com> on 2010-12-22
Reviewed by David Levin.

  • fast/canvas/webgl/gl-uniform-arrays-expected.txt:
  • fast/canvas/webgl/gl-uniform-arrays.html:
13:26 Changeset [74500] by darin@apple.com

Move more of WebPageProxy::didCommitLoadForFrame into WebFrameProxy::didCommitLoad.

Reviewed by Sam Weinig.

  • UIProcess/WebFrameProxy.cpp:

(WebKit::WebFrameProxy::didCommitLoad): Added type and certificate info arguments,
and set m_MIMEType, m_isFrameSet, and m_certificateInfo.

  • UIProcess/WebFrameProxy.h: Removed setMIMEType and setCertificateInfo and added

arguments to didCommitLoad.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didCommitLoadForFrame): Removed code that is now inside the
WebFrameProxy::didCommitLoad function.

13:13 Changeset [74499] by kbr@google.com

2010-12-22 Kenneth Russell <kbr@google.com>

Reviewed by David Levin.

Update fast/canvas/webgl/gl-uniform-arrays.html to bring in sync with Khronos
https://bugs.webkit.org/show_bug.cgi?id=51489

  • fast/canvas/webgl/gl-uniform-arrays-expected.txt:
  • fast/canvas/webgl/gl-uniform-arrays.html:
13:05 Changeset [74498] by lforschler@apple.com

2010-12-22 Lucas Forschler <lforschler@apple.com>

Reviewed by Alice Liu.

<rdar://problem/8633222> record-memory-win needs to record memory used by the webprocess.
Verified on Chrome, Safari, and IE.
With this change, we will record memory from a parent browser window and all child processes.

  • record-memory-win/main.cpp: (ProcessArgs): (PrintUsage): (getMemoryInfo): (printProcessInfo): (evalProcesses): (UseImage): (QueryContinuously): (ElapsedTime):
13:05 Changeset [74497] by zmo@google.com

2010-12-22 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

CopyTex{Sub}Image2D check always if the bound fbo's internal color format is compatible
https://bugs.webkit.org/show_bug.cgi?id=51423

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::copyTexImage2D): Remove the isGLES2Compliant flag around format compatibility checking. (WebCore::WebGLRenderingContext::copyTexSubImage2D): Ditto. (WebCore::WebGLRenderingContext::getBoundFramebufferColorFormat): Helper function to get bound framebuffer's color format; deal with the case of webgl's internal fbo.
  • html/canvas/WebGLRenderingContext.h:

2010-12-22 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

CopyTex{Sub}Image2D check always if the bound fbo's internal color format is compatible
https://bugs.webkit.org/show_bug.cgi?id=51423

  • fast/canvas/webgl/tex-input-validation-expected.txt: Add test cases for copying from webgl's internal FBO.
  • fast/canvas/webgl/tex-input-validation.html: Ditto.
12:53 Changeset [74496] by xan@webkit.org

2010-12-22 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

[GTK] Compilation fixes with GTK+ 2.91.7
https://bugs.webkit.org/show_bug.cgi?id=51487

  • configure.ac: depend on GTK+ 2.91.7 when using GTK+ 3.x.

WebCore:

2010-12-22 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

[GTK] Compilation fixes with GTK+ 2.91.7
https://bugs.webkit.org/show_bug.cgi?id=51487

  • platform/gtk/GtkVersioning.h: do not define GDK_DISPLAY for backwards compatibility, it's now defined again in GTK+ 3.x.
  • platform/gtk/PasteboardHelper.cpp: do not call GDK functions to initialize global static variables (!). These are called when the .so is loaded, and they now require GType to be initialized and will crash. Initialize them once from the ctor, which is a more common pattern anyway. (WebCore::initGdkAtoms): new method to initialize static variables. (WebCore::PasteboardHelper::PasteboardHelper): call it.
  • plugins/gtk/PluginViewGtk.cpp: do not include gdkconfig.h when using GTK+ 3.x, since it's no longer installed.
12:53 Changeset [74495] by lforschler@apple.com

2010-12-22 Lucas Forschler <lforschler@apple.com>

Unreviewed rollout r74489, because it was missing changelog.

  • record-memory-win/main.cpp:
12:22 Changeset [74494] by darin@apple.com

2010-12-21 Darin Adler <darin@apple.com>

Reviewed by Brady Eidson and Sam Weinig.

Add a way to get a web archive in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=51437

  • UIProcess/API/C/WKFrame.cpp: (WKFrameGetWebArchive): Added. (callGetWebArchiveBlockAndDispose): Added. (WKFrameGetWebArchive_b): Added.
  • UIProcess/API/C/WKFrame.h: Added functions above.
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::close): Clear out m_webArchiveCallbacks. (WebKit::WebPageProxy::getWebArchiveOfFrame): Added. (WebKit::WebPageProxy::didGetWebArchiveOfFrame): Added. (WebKit::WebPageProxy::processDidCrash): Clear out m_webArchiveCallbacks.
  • UIProcess/WebPageProxy.h: Added functions above.
  • UIProcess/WebPageProxy.messages.in: Added DidGetWebArchiveOfFrame.
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::getWebArchiveOfFrame): Added.
  • WebProcess/WebPage/WebPage.h: Added function above.
  • WebProcess/WebPage/WebPage.messages.in: Added GetWebArchiveOfFrame.
12:15 Changeset [74493] by krit@webkit.org

2010-12-22 Dirk Schulze <krit@wbekit.org>

Reviewed by Nikolas Zimmermann.

Cleanup SVG code according to the webkit style rules 2
https://bugs.webkit.org/show_bug.cgi?id=51461

Second patch to fix indention and other style issues according to the WebKit style rules in the SVG code.

No changes of functionality, so no new tests.

  • svg/SVGFEDisplacementMapElement.cpp: (WebCore::SVGFEDisplacementMapElement::stringToChannel):
  • svg/SVGFEDistantLightElement.h:
  • svg/SVGFEFuncAElement.h:
  • svg/SVGFEFuncBElement.h:
  • svg/SVGFEFuncGElement.h:
  • svg/SVGFEFuncRElement.h:
  • svg/SVGFEMergeElement.cpp: (WebCore::SVGFEMergeElement::build):
  • svg/SVGFEMorphologyElement.cpp:
  • svg/SVGFEPointLightElement.h:
  • svg/SVGFESpecularLightingElement.cpp: (WebCore::SVGFESpecularLightingElement::findLights):
  • svg/SVGFESpotLightElement.h:
  • svg/SVGFitToViewBox.cpp: (WebCore::SVGFitToViewBox::parseViewBox): (WebCore::SVGFitToViewBox::isKnownAttribute):
  • svg/SVGFontFaceElement.cpp: (WebCore::cssPropertyIdForSVGAttributeName):
  • svg/SVGFontFaceElement.h: (WebCore::SVGFontFaceElement::associatedFontElement):
  • svg/SVGFontFaceNameElement.h:
  • svg/SVGFontFaceSrcElement.cpp:
  • svg/SVGFontFaceSrcElement.h:
  • svg/SVGFontFaceUriElement.h:
  • svg/SVGForeignObjectElement.h:
  • svg/SVGGlyphElement.cpp: (WebCore::parseArabicForm): (WebCore::parseOrientation):
  • svg/SVGGlyphElement.h: (WebCore::SVGGlyphIdentifier::SVGGlyphIdentifier): (WebCore::SVGGlyphIdentifier::inheritedValue): (WebCore::SVGGlyphIdentifier::operator==): (WebCore::SVGGlyphElement::rendererIsNeeded):
  • svg/SVGGlyphMap.h: (WebCore::GlyphMapNode::GlyphMapNode): (WebCore::GlyphMapNode::create): (WebCore::SVGGlyphMap::SVGGlyphMap): (WebCore::SVGGlyphMap::add): (WebCore::SVGGlyphMap::compareGlyphPriority): (WebCore::SVGGlyphMap::get): (WebCore::SVGGlyphMap::clear):
  • svg/SVGGradientElement.cpp:
  • svg/SVGHKernElement.cpp:
  • svg/SVGHKernElement.h: (WebCore::SVGHKernElement::rendererIsNeeded):
  • svg/SVGImageElement.h:
  • svg/SVGImageLoader.cpp:
  • svg/SVGImageLoader.h:
  • svg/SVGLangSpace.cpp: (WebCore::SVGLangSpace::parseMappedAttribute): (WebCore::SVGLangSpace::isKnownAttribute):
  • svg/SVGLangSpace.h: (WebCore::SVGLangSpace::xmllang):
  • svg/SVGMetadataElement.h:
  • svg/SVGMissingGlyphElement.h: (WebCore::SVGMissingGlyphElement::rendererIsNeeded):
  • svg/SVGPaint.cpp: (WebCore::SVGPaint::cssText):
  • svg/SVGPaint.h: (WebCore::SVGPaint::create): (WebCore::SVGPaint::paintType): (WebCore::SVGPaint::isSVGPaint):
  • svg/SVGParserUtilities.cpp:
  • svg/SVGParserUtilities.h: (WebCore::isWhitespace): (WebCore::skipOptionalSpaces): (WebCore::skipOptionalSpacesOrDelimiter):
  • svg/SVGPathElement.cpp:
  • svg/SVGPathParserFactory.h:
  • svg/SVGPathSegList.h:
11:51 Changeset [74492] by cfleizach@apple.com

AX: WAI-ARIA textbox role needs different AXRole, depending on value of aria-multiline property
https://bugs.webkit.org/show_bug.cgi?id=51481

WebCore:

Reviewed by Sam Weinig.

Support aria-multiline and use it to change the role of an ARIA "textbox"
from AXTextArea to AXTextField.

Test: platform/mac/accessibility/aria-multiline.html

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::ariaIsMultiline):

  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::isPasswordField):
(WebCore::AccessibilityObject::isTextControl):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::determineAriaRoleAttribute):

  • accessibility/AccessibilityRenderObject.h:
  • html/HTMLAttributeNames.in:

LayoutTests:

Reviewed by Sam Weining.

  • platform/mac/accessibility/aria-multiline-expected.txt: Added.
  • platform/mac/accessibility/aria-multiline.html: Added.
11:26 WebKit Team edited by rniwa@webkit.org
Adding myself as a reviewer (diff)
11:23 CSS21Results edited by simon.fraser@apple.com
(diff)
11:19 Changeset [74491] by simon.fraser@apple.com

2010-12-22 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

CSS 2.1 failure: counter-increment-013 fails
https://bugs.webkit.org/show_bug.cgi?id=51483

Clamp the counter-increment property to the valid range of signed
integers.

Test: fast/css/counters/counter-increment-overflow.html

  • css/CSSParser.cpp: (WebCore::clampToSignedInteger): (WebCore::CSSParser::parseCounter):
11:11 Changeset [74490] by rniwa@webkit.org

2010-12-22 Ryosuke Niwa <rniwa@webkit.org>

Adding myself as a reviewer.

  • Scripts/webkitpy/common/config/committers.py:
11:10 Changeset [74489] by lforschler@apple.com
11:03 Changeset [74488] by mitz@apple.com

Changed WebKitTools to Tools.

JavaScriptCore:

WebKit/win:

  • WebKit.vcproj/WebKit.sln:
10:56 Changeset [74487] by mitz@apple.com

Changed WebKitTools to Tools in script build phases.

Rubber-stamped by Mark Rowe.

JavaScriptCore:

JavaScriptGlue:

  • JavaScriptGlue.xcodeproj/project.pbxproj:

WebCore:

  • WebCore.xcodeproj/project.pbxproj:

WebKit:

  • WebKit.xcodeproj/project.pbxproj:
10:50 Changeset [74486] by chang.shu@nokia.com

2010-12-22 Chang Shu <chang.shu@nokia.com>

Unreviewed layout test fix.

Revert changeset 74481: http://trac.webkit.org/changeset/74481,
as it causes regression on layout tests.

  • platform/qt/Skipped:
10:41 Changeset [74485] by tonyg@chromium.org

2010-12-22 Tony Gentilcore <tonyg@chromium.org>

Unreviewed build fix.

[chromium] console-websocket-error sometimes times out
https://bugs.webkit.org/show_bug.cgi?id=51482

  • platform/chromium/test_expectations.txt:
10:36 Changeset [74484] by vangelis@chromium.org

2010-12-21 Vangelis Kokkevis <vangelis@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Fixing crash with empty render surfaces.
https://bugs.webkit.org/show_bug.cgi?id=51432

Test: platform/chromium/compositing/empty-render-surface-crasher.html

  • platform/graphics/chromium/RenderSurfaceChromium.cpp: (WebCore::RenderSurfaceChromium::draw):

2010-12-21 Vangelis Kokkevis <vangelis@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Enabling layout tests in platform/chromium/compositing
and adding new layout test to check for crash on empty render surfaces.
https://bugs.webkit.org/show_bug.cgi?id=51432

  • platform/chromium-gpu/test_expectations.txt:
  • platform/chromium/compositing/empty-render-surface-crasher-expected.txt: Added.
  • platform/chromium/compositing/empty-render-surface-crasher.html: Added.
10:16 Changeset [74483] by scherkus@chromium.org

2010-12-22 Andrew Scherkus <scherkus@chromium.org>

Unreviewed. Adding myself to committers.py.

  • Scripts/webkitpy/common/config/committers.py:
10:12 Changeset [74482] by ariya@webkit.org

2010-12-22 Ariya Hidayat <ariya@sencha.com>

Reviewed by Kenneth Rohde Christiansen.

TestNetscapePlugIn should use #if defined
https://bugs.webkit.org/show_bug.cgi?id=51471

  • DumpRenderTree/TestNetscapePlugIn/main.cpp: (NP_Initialize): (NPP_New):
08:25 Changeset [74481] by commit-queue@webkit.org

2010-12-22 Krithigassree Sambamurthy <krithigassree.sambamurthy@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] LayoutTests/http/tests/appcache/auth.html failed and skipped
https://bugs.webkit.org/show_bug.cgi?id=36688

  • platform/qt/Skipped: Unskip auth.html which now passes. Using Qt4.7.
08:22 Changeset [74480] by loislo@chromium.org

2010-12-22 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [chromium] DRT inspector layout tests are flaky in debug.

DevTools window should be closed explicitly because it has custom deinitialization code.

https://bugs.webkit.org/show_bug.cgi?id=50722

  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::closeRemainingWindows):
07:41 Changeset [74479] by jberlin@webkit.org

Add Windows-specific expected results for fast/js/large-expressions.html in order to get
the Windows 7 Release test bot green again. Unreviewed.
https://bugs.webkit.org/show_bug.cgi?id=51469

  • platform/win/fast/js/large-expressions-expected.txt: Added.
07:31 Changeset [74478] by levin@chromium.org

check-webkit-style shouldn't complaint about underscores in variables in objective C files.
https://bugs.webkit.org/show_bug.cgi?id=51452

Reviewed by Shinichiro Hamaji.

  • Scripts/webkitpy/style/checkers/cpp.py:

(_FileState.init): Added the information to determine if a file is C or Objective C.
Using the file extension if possible but falling back to the file contents if we have a header file.
(_FileState.is_objective_c): Determine if we have an Objective C by examining the file contents if needed.
(_FileState.is_c_or_objective_c):
(check_using_std): Changed to using _FileState to determine the file type.
(check_max_min_macros): Ditto.
(check_for_null): Ditto.
(check_style): Changed the parameters to various calls since they now need _FileState
to determine the file type.
(check_language): Added the file_state parameter so it could be passed
to check_identifier_name_in_declaration.
(check_identifier_name_in_declaration): Don't warn about underscores in variables if
this is an Objective C file.
(_process_lines): Added information for the _FileState constructor (and moved the
call to a place that had the information).

  • Scripts/webkitpy/style/checkers/cpp_unittest.py:

(CppFunctionsTest.test_is_c_or_objective_c): Changed the tests to use FileState and exercise
its functionality.
(WebKitStyleTest.test_names): Add tests for underscores in Objective C files.

06:17 Changeset [74477] by podivilov@chromium.org

2010-12-21 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: persist JavaScript breakpoints in frontend settings.
https://bugs.webkit.org/show_bug.cgi?id=48434

  • http/tests/inspector/debugger-test2.js: (initialize_DebuggerTest.InspectorTest.setBreakpoint):
  • inspector/debugger-breakpoints-not-activated-on-reload.html:
  • inspector/debugger-pause-on-breakpoint.html:
  • inspector/report-protocol-errors-expected.txt:
  • inspector/report-protocol-errors.html:

2010-12-21 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: persist JavaScript breakpoints in frontend settings.
https://bugs.webkit.org/show_bug.cgi?id=48434

  • bindings/js/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::setBreakpoint): (WebCore::ScriptDebugServer::removeBreakpoint):
  • bindings/js/ScriptDebugServer.h:
  • bindings/v8/DebuggerScript.js: ():
  • bindings/v8/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::setBreakpoint): (WebCore::ScriptDebugServer::removeBreakpoint):
  • bindings/v8/ScriptDebugServer.h:
  • inspector/Inspector.idl:
  • inspector/InspectorBackend.cpp:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::enableDebuggerFromFrontend): (WebCore::InspectorController::setStickyBreakpoints): (WebCore::InspectorController::restoreStickyBreakpoint):
  • inspector/InspectorController.h:
  • inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent): (WebCore::InspectorDebuggerAgent::setStickyBreakpoint): (WebCore::InspectorDebuggerAgent::setBreakpoint): (WebCore::InspectorDebuggerAgent::removeBreakpoint): (WebCore::InspectorDebuggerAgent::restoreBreakpoint): (WebCore::InspectorDebuggerAgent::clearForPageNavigation): (WebCore::InspectorDebuggerAgent::didParseSource):
  • inspector/InspectorDebuggerAgent.h:
  • inspector/front-end/Breakpoint.js: (WebInspector.Breakpoint): (WebInspector.Breakpoint.prototype.remove):
  • inspector/front-end/BreakpointManager.js: (WebInspector.BreakpointManager): (WebInspector.DOMBreakpoint.prototype._serializeToJSON): (WebInspector.JavaScriptBreakpoint): (WebInspector.XHRBreakpoint.prototype._serializeToJSON):
  • inspector/front-end/DebuggerModel.js: (WebInspector.DebuggerModel):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._debuggerPaused):
  • inspector/front-end/SourceFrame.js:
06:00 Changeset [74476] by antti@apple.com

WebCore: https://bugs.webkit.org/show_bug.cgi?id=51354
Don't block rendering and script execution on deferred stylesheets

Reviewed by Alexey Proskuryakov.

  • Don't add low priority stylesheets to the document pending sheet count.
  • Resolve media attribute fully for the link element stylesheet load.

Test: http/tests/local/stylesheet-and-script-load-order-media-print.html

  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::HTMLLinkElement):
(WebCore::HTMLLinkElement::~HTMLLinkElement):
(WebCore::HTMLLinkElement::setDisabledState):
(WebCore::HTMLLinkElement::process):
(WebCore::HTMLLinkElement::sheetLoaded):
(WebCore::HTMLLinkElement::addPendingSheet):
(WebCore::HTMLLinkElement::removePendingSheet):

  • html/HTMLLinkElement.h:

LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=51354
Don't block rendering and script execution on deferred stylesheets

Reviewed by Alexey Proskuryakov.

  • http/tests/local/link-stylesheet-load-order-expected.txt:
  • http/tests/local/link-stylesheet-load-order-preload-expected.txt:
  • http/tests/local/resources/check-stylesheet-not-loaded.js: Added.
  • http/tests/local/stylesheet-and-script-load-order-media-print-expected.txt: Added.
  • http/tests/local/stylesheet-and-script-load-order-media-print.html: Added.
05:34 Changeset [74475] by podivilov@chromium.org

2010-12-22 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r74473.
http://trac.webkit.org/changeset/74473
https://bugs.webkit.org/show_bug.cgi?id=51463

broke compilation on leopard intel release (Requested by
podivilov on #webkit).

  • http/tests/inspector/debugger-test2.js:
  • inspector/debugger-breakpoints-not-activated-on-reload.html:
  • inspector/debugger-pause-on-breakpoint.html:
  • inspector/report-protocol-errors-expected.txt:
  • inspector/report-protocol-errors.html:

2010-12-22 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r74473.
http://trac.webkit.org/changeset/74473
https://bugs.webkit.org/show_bug.cgi?id=51463

broke compilation on leopard intel release (Requested by
podivilov on #webkit).

  • bindings/js/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::setBreakpoint): (WebCore::ScriptDebugServer::removeBreakpoint):
  • bindings/js/ScriptDebugServer.h:
  • bindings/v8/DebuggerScript.js: ():
  • bindings/v8/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::setBreakpoint): (WebCore::ScriptDebugServer::removeBreakpoint):
  • bindings/v8/ScriptDebugServer.h:
  • inspector/Inspector.idl:
  • inspector/InspectorBackend.cpp:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::enableDebuggerFromFrontend): (WebCore::InspectorController::setStickyBreakpoints): (WebCore::InspectorController::restoreStickyBreakpoint): (WebCore::InspectorController::breakpointsSettingKey): (WebCore::InspectorController::loadBreakpoints): (WebCore::InspectorController::saveBreakpoints):
  • inspector/InspectorController.h:
  • inspector/InspectorDebuggerAgent.cpp: (WebCore::formatBreakpointId): (WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent): (WebCore::InspectorDebuggerAgent::setBreakpoint): (WebCore::InspectorDebuggerAgent::removeBreakpoint): (WebCore::InspectorDebuggerAgent::clearForPageNavigation): (WebCore::InspectorDebuggerAgent::md5Base16): (WebCore::InspectorDebuggerAgent::loadBreakpoints): (WebCore::InspectorDebuggerAgent::saveBreakpoints): (WebCore::InspectorDebuggerAgent::didParseSource):
  • inspector/InspectorDebuggerAgent.h:
  • inspector/front-end/Breakpoint.js: (WebInspector.Breakpoint): (WebInspector.Breakpoint.jsBreakpointId): (WebInspector.Breakpoint.prototype.set enabled): (WebInspector.Breakpoint.prototype.get id): (WebInspector.Breakpoint.prototype.set condition): (WebInspector.Breakpoint.prototype.remove):
  • inspector/front-end/BreakpointManager.js: (WebInspector.BreakpointManager): (WebInspector.BreakpointManager.prototype._createDOMBreakpoint): (WebInspector.BreakpointManager.prototype._createEventListenerBreakpoint): (WebInspector.BreakpointManager.prototype._createXHRBreakpoint): (WebInspector.BreakpointManager.prototype._setNativeBreakpoint): (WebInspector.BreakpointManager.prototype._setNativeBreakpointEnabled): (WebInspector.BreakpointManager.prototype._removeNativeBreakpoint): (WebInspector.BreakpointManager.prototype.breakpointViewForEventData): (WebInspector.BreakpointManager.prototype._projectChanged): (WebInspector.BreakpointManager.prototype.restoreDOMBreakpoints): (WebInspector.BreakpointManager.prototype._saveBreakpoints): (WebInspector.BreakpointManager.prototype._validateBreakpoints): (WebInspector.DOMBreakpoint.prototype._serializeToJSON): (WebInspector.EventListenerBreakpoint.prototype._serializeToJSON): (WebInspector.XHRBreakpoint.prototype._serializeToJSON): (WebInspector.NativeBreakpointView.prototype.set enabled): (WebInspector.NativeBreakpointView.prototype.remove):
  • inspector/front-end/DebuggerModel.js: (WebInspector.DebuggerModel): (WebInspector.DebuggerModel.prototype.setOneTimeBreakpoint): (WebInspector.DebuggerModel.prototype.removeOneTimeBreakpoint): (WebInspector.DebuggerModel.prototype.setBreakpoint): (WebInspector.DebuggerModel.prototype.findBreakpoint): (WebInspector.DebuggerModel.prototype.reset): (WebInspector.DebuggerModel.prototype._setBreakpoint): (WebInspector.DebuggerModel.prototype._breakpointRemoved): (WebInspector.DebuggerModel.prototype._setBreakpointOnBackend): (WebInspector.DebuggerModel.prototype.breakpointRestored): (WebInspector.DebuggerModel.prototype.pausedScript): (WebInspector.DebuggerModel.prototype.resumedScript):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.continueToLine): (WebInspector.ScriptsPanel.prototype._debuggerPaused):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._contextMenu.addConditionalBreakpoint.didEditBreakpointCondition): (WebInspector.SourceFrame.prototype._contextMenu.addConditionalBreakpoint): (WebInspector.SourceFrame.prototype._contextMenu.else.editBreakpointCondition.didEditBreakpointCondition): (WebInspector.SourceFrame.prototype._contextMenu.else.editBreakpointCondition): (WebInspector.SourceFrame.prototype._contextMenu): (WebInspector.SourceFrame.prototype._mouseDown): (WebInspector.SourceFrame.prototype._continueToLine): (WebInspector.SourceFrame.prototype._setBreakpoint):
05:23 Changeset [74474] by andreip@google.com

2010-12-22 Andrei Popescu <andreip@google.com>

Unreviewed build fix.

Fix Chromium Linux shared library build.
[Chromium] r74431 broke the Chromium Linux shared library build
https://bugs.webkit.org/show_bug.cgi?id=51462

05:13 Changeset [74473] by podivilov@chromium.org

2010-12-21 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: persist JavaScript breakpoints in frontend settings.
https://bugs.webkit.org/show_bug.cgi?id=48434

  • http/tests/inspector/debugger-test2.js: (initialize_DebuggerTest.InspectorTest.setBreakpoint):
  • inspector/debugger-breakpoints-not-activated-on-reload.html:
  • inspector/debugger-pause-on-breakpoint.html:
  • inspector/report-protocol-errors-expected.txt:
  • inspector/report-protocol-errors.html:

2010-12-21 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: persist JavaScript breakpoints in frontend settings.
https://bugs.webkit.org/show_bug.cgi?id=48434

  • bindings/js/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::setBreakpoint): (WebCore::ScriptDebugServer::removeBreakpoint):
  • bindings/js/ScriptDebugServer.h:
  • bindings/v8/DebuggerScript.js: ():
  • bindings/v8/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::setBreakpoint): (WebCore::ScriptDebugServer::removeBreakpoint):
  • bindings/v8/ScriptDebugServer.h:
  • inspector/Inspector.idl:
  • inspector/InspectorBackend.cpp:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::enableDebuggerFromFrontend): (WebCore::InspectorController::setStickyBreakpoints): (WebCore::InspectorController::restoreStickyBreakpoint):
  • inspector/InspectorController.h:
  • inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent): (WebCore::InspectorDebuggerAgent::setStickyBreakpoint): (WebCore::InspectorDebuggerAgent::setBreakpoint): (WebCore::InspectorDebuggerAgent::removeBreakpoint): (WebCore::InspectorDebuggerAgent::restoreBreakpoint): (WebCore::InspectorDebuggerAgent::clearForPageNavigation): (WebCore::InspectorDebuggerAgent::didParseSource):
  • inspector/InspectorDebuggerAgent.h:
  • inspector/front-end/Breakpoint.js: (WebInspector.Breakpoint): (WebInspector.Breakpoint.prototype.remove):
  • inspector/front-end/BreakpointManager.js: (WebInspector.BreakpointManager): (WebInspector.DOMBreakpoint.prototype._serializeToJSON): (WebInspector.JavaScriptBreakpoint): (WebInspector.XHRBreakpoint.prototype._serializeToJSON):
  • inspector/front-end/DebuggerModel.js: (WebInspector.DebuggerModel):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._debuggerPaused):
  • inspector/front-end/SourceFrame.js:
04:25 Changeset [74472] by krit@webkit.org

2010-12-22 Dirk Schulze <krit@wbekit.org>

Reviewed by Nikolas Zimmermann.

Cleanup SVG code according to the webkit style rules 1
https://bugs.webkit.org/show_bug.cgi?id=51411

First patch to fix indention and other style issues according to the WebKit style rules in the SVG code.

No change of functionality.

  • svg/ColorDistance.cpp: (WebCore::ColorDistance::isZero):
  • svg/ColorDistance.h:
  • svg/ElementTimeControl.h: (WebCore::ElementTimeControl::~ElementTimeControl):
  • svg/LinearGradientAttributes.h: (WebCore::LinearGradientAttributes::LinearGradientAttributes): (WebCore::LinearGradientAttributes::x1): (WebCore::LinearGradientAttributes::y1): (WebCore::LinearGradientAttributes::x2): (WebCore::LinearGradientAttributes::y2): (WebCore::LinearGradientAttributes::setX1): (WebCore::LinearGradientAttributes::setY1): (WebCore::LinearGradientAttributes::setX2): (WebCore::LinearGradientAttributes::setY2): (WebCore::LinearGradientAttributes::hasX1): (WebCore::LinearGradientAttributes::hasY1): (WebCore::LinearGradientAttributes::hasX2): (WebCore::LinearGradientAttributes::hasY2):
  • svg/RadialGradientAttributes.h: (WebCore::RadialGradientAttributes::RadialGradientAttributes): (WebCore::RadialGradientAttributes::cx): (WebCore::RadialGradientAttributes::cy): (WebCore::RadialGradientAttributes::r): (WebCore::RadialGradientAttributes::fx): (WebCore::RadialGradientAttributes::fy): (WebCore::RadialGradientAttributes::setCx): (WebCore::RadialGradientAttributes::setCy): (WebCore::RadialGradientAttributes::setR): (WebCore::RadialGradientAttributes::setFx): (WebCore::RadialGradientAttributes::setFy): (WebCore::RadialGradientAttributes::hasCx): (WebCore::RadialGradientAttributes::hasCy): (WebCore::RadialGradientAttributes::hasR): (WebCore::RadialGradientAttributes::hasFx): (WebCore::RadialGradientAttributes::hasFy):
  • svg/SVGAngle.cpp:
  • svg/SVGAnimateColorElement.h:
  • svg/SVGAnimateElement.cpp: (WebCore::SVGAnimateElement::calculateAnimatedValue): (WebCore::SVGAnimateElement::calculateDistance):
  • svg/SVGAnimateElement.h:
  • svg/SVGAnimateMotionElement.cpp:
  • svg/SVGAnimateMotionElement.h:
  • svg/SVGAnimatedNumber.h:
  • svg/SVGAnimationElement.cpp: (WebCore::parseKeyTimes): (WebCore::SVGAnimationElement::currentValuesForValuesAnimation): (WebCore::SVGAnimationElement::updateAnimation):
  • svg/SVGClipPathElement.cpp: (WebCore::SVGClipPathElement::svgAttributeChanged):
  • svg/SVGColor.h: (WebCore::SVGColor::create): (WebCore::SVGColor::createCurrentColor): (WebCore::SVGColor::colorType): (WebCore::SVGColor::setRGBColor): (WebCore::SVGColor::color): (WebCore::SVGColor::isSVGColor):
  • svg/SVGCursorElement.cpp: (WebCore::SVGCursorElement::svgAttributeChanged):
  • svg/SVGCursorElement.h:
  • svg/SVGDescElement.h: (WebCore::SVGDescElement::rendererIsNeeded):
  • svg/SVGDocument.cpp:
  • svg/SVGDocument.h: (WebCore::SVGDocument::create): (WebCore::SVGDocument::isSVGDocument):
  • svg/SVGElement.h: (WebCore::SVGElement::isStyled): (WebCore::SVGElement::isStyledTransformable): (WebCore::SVGElement::isStyledLocatable): (WebCore::SVGElement::isSVG): (WebCore::SVGElement::isFilterEffect): (WebCore::SVGElement::isGradientStop): (WebCore::SVGElement::isTextContent): (WebCore::SVGElement::isValid): (WebCore::SVGElement::svgAttributeChanged): (WebCore::SVGElement::synchronizeProperty): (WebCore::SVGElement::supplementalTransform): (WebCore::SVGElement::invalidateSVGAttributes): (WebCore::SVGElement::rendererIsNeeded): (WebCore::SVGElement::needsPendingResourceHandling): (WebCore::SVGElement::buildPendingResource):
  • svg/SVGElementInstance.h: (WebCore::SVGElementInstance::create): (WebCore::SVGElementInstance::correspondingElement): (WebCore::SVGElementInstance::correspondingUseElement): (WebCore::SVGElementInstance::shadowTreeElement): (WebCore::SVGElementInstance::parentNode): (WebCore::SVGElementInstance::previousSibling): (WebCore::SVGElementInstance::nextSibling): (WebCore::SVGElementInstance::firstChild): (WebCore::SVGElementInstance::lastChild): (WebCore::SVGElementInstance::ownerDocument): (WebCore::SVGElementInstance::toNode): (WebCore::SVGElementInstance::toSVGElementInstance): (WebCore::SVGElementInstance::hasChildNodes): (WebCore::SVGElementInstance::setFirstChild): (WebCore::SVGElementInstance::setLastChild): (WebCore::SVGElementInstance::setNextSibling): (WebCore::SVGElementInstance::setPreviousSibling): (WebCore::SVGElementInstance::refEventTarget): (WebCore::SVGElementInstance::derefEventTarget):
  • svg/SVGElementInstanceList.h: (WebCore::SVGElementInstanceList::create):
  • svg/SVGException.h: (WebCore::SVGException::create): (WebCore::SVGException::SVGException):
  • svg/SVGFEColorMatrixElement.cpp: (WebCore::SVGFEColorMatrixElement::parseMappedAttribute):
  • svg/SVGFEComponentTransferElement.cpp: (WebCore::SVGFEComponentTransferElement::build):
  • svg/SVGFEDiffuseLightingElement.cpp: (WebCore::SVGFEDiffuseLightingElement::findLights):
  • svg/SVGFont.cpp: (WebCore::convertEmUnitToPixel):
  • svg/SVGUseElement.cpp: (WebCore::isDirectReference):
04:17 Changeset [74471] by andreip@google.com

2010-12-22 Andrei Popescu <andreip@google.com>

Unreviewed buildfix.

[v8] trunk/LayoutTests/fast/js/large-expressions.html fails since r74402
https://bugs.webkit.org/show_bug.cgi?id=51391

  • platform/chromium-mac/fast/js/large-expressions-expected.txt:
  • platform/chromium-win/fast/js/large-expressions-expected.txt:
03:38 Changeset [74470] by commit-queue@webkit.org

2010-12-22 Dai Mikurube <dmikurube@google.com>

Reviewed by Kent Tamura.

https://bugs.webkit.org/show_bug.cgi?id=51289
Initial state of checkValidity() and :invalid are incorrect with <select required>

  • fast/css/pseudo-valid-007-expected.txt:
  • fast/css/pseudo-valid-007.html:
  • fast/forms/checkValidity-002-expected.txt:
  • fast/forms/checkValidity-002.html:

2010-12-22 Dai Mikurube <dmikurube@google.com>

Reviewed by Kent Tamura.

https://bugs.webkit.org/show_bug.cgi?id=51289
Initial state of checkValidity() and :invalid are incorrect with <select required>

  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::childrenChanged): setNeedsValidityCheck() after <select>'s children change.
03:24 Changeset [74469] by kov@webkit.org

Tagging 1.3.8.

03:05 Changeset [74468] by apavlov@chromium.org

2010-12-22 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Joseph Pecoraro.

Web Inspector: Styles pane fails to display properties from a broken CSS rule correctly
https://bugs.webkit.org/show_bug.cgi?id=51405

  • inspector/styles-new-API-expected.txt:
  • inspector/styles-new-API.html:

2010-12-22 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Joseph Pecoraro.

Web Inspector: Styles pane fails to display properties from a broken CSS rule correctly
https://bugs.webkit.org/show_bug.cgi?id=51405

Invoke markPropertyStart() after the parser has restored after an error.

  • css/CSSGrammar.y:
00:50 Changeset [74467] by gyuyoung.kim@samsung.com

2010-12-22 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Antonio Gomes.

[EFL] Sets default user agent
https://bugs.webkit.org/show_bug.cgi?id=47903

Add macros for WebKit EFL and User Agent.

  • cmake/OptionsEfl.cmake:
  • cmakeconfig.h.cmake:

2010-12-22 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Antonio Gomes.

[EFL] Sets default user agent
https://bugs.webkit.org/show_bug.cgi?id=47903

If applcation(e.g EWebLauncher) doesn't set user agent, WebKit EFL doesn't
set user agent. However, we need to set user agent by default. Because, some
web sites send different pages according to user agent.

  • ewk/ewk_private.h:
  • ewk/ewk_settings.cpp: (_ewk_settings_webkit_platform): (_ewk_settings_webkit_os_version): (ewk_settings_default_user_agent_get):
  • ewk/ewk_view.cpp: (_ewk_view_priv_new):
00:37 Changeset [74466] by commit-queue@webkit.org

2010-12-22 Dai Mikurube <dmikurube@google.com>

Reviewed by Kent Tamura.

Assertion failure with <select multiple required>
https://bugs.webkit.org/show_bug.cgi?id=51260

  • fast/forms/resources/select-live-pseudo-selectors.js:
  • fast/forms/select-live-pseudo-selectors-expected.txt:

2010-12-22 Dai Mikurube <dmikurube@google.com>

Reviewed by Kent Tamura.

Assertion failure with <select multiple required>
https://bugs.webkit.org/show_bug.cgi?id=51260

Test: fast/css/pseudo-valid-select-click.html

  • dom/SelectElement.cpp: updateValidity() after selecting some options of ListBox-typed <select> elements to update valid() cache. (WebCore::SelectElement::updateListBoxSelection):

12/21/10:

23:16 Changeset [74465] by darin@apple.com

Unreviewed correction to unreviewed build fix for r74447.

Inappropriate code was left behind in sourceURI function for non-Dashboard platforms.

  • html/HTMLImageLoader.cpp:

(WebCore::HTMLImageLoader::sourceURI): Change the logic so all the bug-workaround
logic is inside the #ifdef.

22:20 Changeset [74464] by tonyg@chromium.org

2010-12-21 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r74462.
http://trac.webkit.org/changeset/74462
https://bugs.webkit.org/show_bug.cgi?id=51449

broke chromium win (Requested by tonyg-cr on #webkit).

21:58 Changeset [74463] by simon.fraser@apple.com

2010-12-21 Simon Fraser <simon.fraser@apple.com>

Reviewed by Darin Adler.

Include the shadow color space as part of the GraphicsContext state
https://bugs.webkit.org/show_bug.cgi?id=51420

Include the ColorSpace for the shadow color as part of the graphics
state. This will be used later for a shadow implementation that
does not rely on platform shadow code.

  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::setShadow): (WebCore::GraphicsContext::clearShadow): (WebCore::GraphicsContext::getShadow):
  • platform/graphics/GraphicsContext.h: (WebCore::GraphicsContextState::GraphicsContextState):
  • platform/graphics/chromium/FontChromiumWin.cpp: (WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::drawGlyphs): (WebCore::Font::drawComplexText):
  • platform/graphics/mac/FontMac.mm: (WebCore::Font::drawGlyphs):
  • platform/graphics/skia/SkiaFontWin.cpp: (WebCore::windowsCanHandleDrawTextShadow):
  • platform/graphics/win/FontCGWin.cpp: (WebCore::drawGDIGlyphs): (WebCore::Font::drawGlyphs):
  • platform/graphics/wince/GraphicsContextWinCE.cpp: (WebCore::GraphicsContext::fillRoundedRect): (WebCore::GraphicsContext::drawText):
21:56 Changeset [74462] by tonyg@chromium.org

2010-12-21 Tony Gentilcore <tonyg@chromium.org>

Unreviewed build fix.

[chromium] Build fix after r74431
https://bugs.webkit.org/show_bug.cgi?id=51447

21:55 Changeset [74461] by barraclough@apple.com

Bug 26276 - Need a mechanism to determine stack extent

Reviewed by Oliver Hunt.

Correctly measuring available stack increases the size of expression we can handle!

  • fast/js/large-expressions-expected.txt:
  • fast/js/script-tests/large-expressions.js:
21:40 Changeset [74460] by laszlo.1.gombos@nokia.com

2010-12-21 Siddharth Mathur <siddharth.mathur@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] [WK2] Guard gcc-specific syntax

  • WebKit2.pro: Non-gcc based compliers choke on the "-include" syntax for preinclude, make sure it has guard around it.
21:09 Changeset [74459] by tonyg@chromium.org

2010-12-21 Dan Bernstein <mitz@apple.com>

Reviewed by Sam Weinig.

<rdar://problem/8668230> REGRESSION (r71884): Returning alternate requests from willSendRequest can prevent other requests from ever being sent
https://bugs.webkit.org/show_bug.cgi?id=51413

  • platform/mac/security/block-test-expected.txt: Reverted r71884.
21:09 Changeset [74458] by barraclough@apple.com

Windows build fix.

20:54 Changeset [74457] by barraclough@apple.com

Windows build fix.

20:39 Changeset [74456] by barraclough@apple.com

Speculative build fix.

  • jit/ExecutableAllocator.cpp:

(JSC::ExecutableAllocator::underMemoryPressure):

20:29 Changeset [74455] by barraclough@apple.com

Bug 26276 - Need a mechanism to determine stack extent

Reviewed by Oliver Hunt.

This patch adds accurate stack size calculation for:

DARWIN, QNX, UNIX

We still need to fix:

WINDOWS, SOLARIS, OPENBSD, SYMBIAN, HAIKU, WINCE

  • wtf/StackBounds.cpp:

(WTF::StackBounds::initialize):

20:18 Changeset [74454] by barraclough@apple.com

Reviewed by Geoff Garen.


<rdar://problem/8765333> CRASH running out of executable memory, loading io9.com
https://bugs.webkit.org/show_bug.cgi?id=51443

The problem here is that each page uses a reasonable amount of memory, (~4Mb),
and that when miultiple pages are open we keep all JIT code for all functions
in all pages alive.

Add a check to detect high memory pressure situations in the executable allocator
(>50% of available memory allocated), and upon a top level entry into JSC (no code
running on the stack) in this situation throw away all JIT code.

(JSC::Debugger::recompileAllJSFunctions): stop passing exec to recompile.

  • jit/ExecutableAllocator.h:
  • jit/ExecutableAllocatorFixedVMPool.cpp:

(JSC::ExecutablePool::systemAlloc): Count allocations.
(JSC::ExecutablePool::systemRelease): Count deallocations.
(JSC::ExecutablePool::underMemoryPressure): Check memory pressure.

  • jit/ExecutableAllocatorPosix.cpp:

(JSC::ExecutablePool::underMemoryPressure): Stub out; only meaningful with FixedVMPool.

  • jit/ExecutableAllocatorWin.cpp:

(JSC::ExecutablePool::underMemoryPressure): Stub out; only meaningful with FixedVMPool.

  • runtime/Executable.cpp:

(JSC::FunctionExecutable::recompile): Remove ExecState argument to recompile.

  • runtime/Executable.h:
  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::recompileAllJSFunctions): throws away all JIT code.

  • runtime/JSGlobalData.h:
  • runtime/JSGlobalObject.h:

(JSC::DynamicGlobalObjectScope::DynamicGlobalObjectScope): add check / call to throw away.

20:10 Changeset [74453] by mitz@apple.com

2010-12-21 Dan Bernstein <mitz@apple.com>

Reviewed by Sam Weinig.

<rdar://problem/8668230> REGRESSION (r71884): Returning alternate requests from willSendRequest can prevent other requests from ever being sent
https://bugs.webkit.org/show_bug.cgi?id=51413

71884 was wrong in moving willSendRequest to ResourceLoader::start(). It’s wrong to do all the
scheduling, which is host-dependent, before calling willSendRequest, because the latter can
change the host.

  • loader/NetscapePlugInStreamLoader.cpp: (WebCore::NetscapePlugInStreamLoader::create): Check the return value from ResourceLoader::init() and return 0 if it is false.
  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::init): Made this function return a boolean. Moved the call to willSendRequest() from start() into here. Return false if willSendRequest() canceled the request. (WebCore::ResourceLoader::start): Moved the call to willSendRequest() from here to init().
  • loader/ResourceLoader.h:
  • loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::create): Check the return value from ResourceLoader::init() and return 0 if it is false.

2010-12-21 Dan Bernstein <mitz@apple.com>

Reviewed by Sam Weinig.

<rdar://problem/8668230> REGRESSION (r71884): Returning alternate requests from willSendRequest can prevent other requests from ever being sent
https://bugs.webkit.org/show_bug.cgi?id=51413

  • platform/mac/security/block-test-expected.txt: Reverted r71884.
19:44 Changeset [74452] by commit-queue@webkit.org

2010-12-21 Benjamin Kalman <kalman@chromium.org>

Reviewed by Darin Adler.

Shift-End does not select to the end of the line
https://bugs.webkit.org/show_bug.cgi?id=50610

Add regression test that shift-end selects to the end of the line for both LTR and RTL text.
Rebaseline a test which assumed incorrect behaviour of shift-end not selecting to the end of
the line, but rather moving cursor to the start of the line above.

  • editing/selection/extend-selection-home-end-expected.txt: New baseline.
  • editing/selection/extend-to-line-boundary-expected.txt: Added.
  • editing/selection/extend-to-line-boundary.html: Added.
  • platform/win/editing/selection/extend-selection-home-end-expected.txt: New baseline.

2010-12-21 Benjamin Kalman <kalman@chromium.org>

Reviewed by Darin Adler.

Shift-End does not select to the end of the line
https://bugs.webkit.org/show_bug.cgi?id=50610

Let the VisiblePosition affinity for end of line selection to be set by
visibleEnd/visibleStart rather than using end/start and always using UPSTREAM.

Test: editing/selection/extend-to-line-boundary.html

  • editing/SelectionController.cpp: (WebCore::SelectionController::positionForPlatform): Use visibleStart/visibleEnd rather than start/end. (WebCore::SelectionController::modifyExtendingForward): Don't explicitly use UPSTREAM affinity.
19:42 Changeset [74451] by ariya@webkit.org

2010-12-21 Jan Erik Hanssen <jhanssen@sencha.com>

Reviewed by Simon Fraser.

matrix3d() must take the zoom factor into account
https://bugs.webkit.org/show_bug.cgi?id=51408

  • transforms/3d/general/matrix-with-zoom-3d-expected.checksum: Added.
  • transforms/3d/general/matrix-with-zoom-3d-expected.png: Added.
  • transforms/3d/general/matrix-with-zoom-3d-expected.txt: Added.
  • transforms/3d/general/matrix-with-zoom-3d.html: Added.

2010-12-21 Jan Erik Hanssen <jhanssen@sencha.com>

Reviewed by Simon Fraser.

matrix3d() must take the zoom factor into account
https://bugs.webkit.org/show_bug.cgi?id=51408

Test: transforms/3d/general/matrix-with-zoom-3d.html

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::createTransformOperations):
19:25 Changeset [74450] by aestes@apple.com

2010-12-21 Andy Estes <aestes@apple.com>

Reviewed by Mark Rowe.

Do not build non-Intel architectures for WebKit2-related projects.
https://bugs.webkit.org/show_bug.cgi?id=51440

  • MiniBrowser/Configurations/Base.xcconfig: Only build for i386 and x86_64.
  • TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
  • WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
19:10 Changeset [74449] by abarth@webkit.org

2010-12-21 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Move V8 to common implementation of window.open
https://bugs.webkit.org/show_bug.cgi?id=51385

I also changed some function names to match WebKit style. There's a
bunch of code we can remove in the generic bindings now. I'll do that
in the next patch.

  • bindings/generic/BindingDOMWindow.h: (WebCore::::open):
  • bindings/generic/BindingFrame.h: (WebCore::::navigateIfAllowed):
  • bindings/generic/BindingSecurity.h: (WebCore::::canAccessWindow): (WebCore::::allowPopUp): (WebCore::::shouldAllowNavigation):
  • bindings/generic/GenericBinding.h: (WebCore::completeURL):
  • bindings/js/JSDOMBinding.cpp: (WebCore::toLexicalFrame): (WebCore::toDynamicFrame):
  • bindings/js/specialization/JSBindingState.cpp: (WebCore::::activeFrame): (WebCore::::firstFrame):
  • bindings/js/specialization/JSBindingState.h:
  • bindings/v8/V8Utilities.cpp: (WebCore::callingOrEnteredFrame):
  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8DOMWindow::locationAccessorSetter): (WebCore::V8DOMWindow::openCallback):
  • bindings/v8/specialization/V8BindingState.cpp: (WebCore::::activeWindow): (WebCore::::firstWindow): (WebCore::::activeFrame): (WebCore::::firstFrame):
  • bindings/v8/specialization/V8BindingState.h:
18:40 Changeset [74448] by rniwa@webkit.org

2010-12-21 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed build fix for r74447.

Call usesDashboardBackwardCompatibilityMode() only if DASHBOARD_SUPPORT is enabled.

  • html/HTMLImageLoader.cpp: (WebCore::HTMLImageLoader::sourceURI):
18:19 Changeset [74447] by mitz@apple.com

WebCore: <rdar://problem/8725702> REGRESSION (r68854): Broken image icon seen in the Address Book Dashboard widget

Reviewed by John Sullivan.

Test: platform/mac/fast/dom/HTMLImageElement/dashboard-src-quirk.html

The Address Book widget sets the src attribute of an img element to a string that looks like a CSS
URL value. This used to work prior to r68854, because some DOM attribute parsing functions were using
the wrong function to parse URL attributes (last named deprecatedParseURL).

  • html/HTMLImageLoader.cpp:

(WebCore::HTMLImageLoader::sourceURI): In Dashboard, check if the src attribute begins with 'url("'
and ends with '")', and if so, strip those away.

LayoutTests: <rdar://problem/8725702> REGRESSION(r68854): Broken image icon seen in the Address Book Dashboard widget

Reviewed by John Sullivan.

  • platform/mac/fast/dom/HTMLImageElement/dashboard-src-quirk-expected.txt: Added.
  • platform/mac/fast/dom/HTMLImageElement/dashboard-src-quirk.html: Added.
  • platform/mac/fast/dom/HTMLImageElement/resources: Added.
  • platform/mac/fast/dom/HTMLImageElement/resources/blue_rect.jpg: Added.
18:16 Changeset [74446] by cwzwarich@webkit.org

Reviewed by Darin Adler.

-[WebBasePluginPackage isNativeLibraryData:] integer underflows on zero-sized data
https://bugs.webkit.org/show_bug.cgi?id=51431
<rdar://problem/8791757>

  • Plugins/WebBasePluginPackage.mm:

(-[WebBasePluginPackage isNativeLibraryData:]): Change an arithmetic expression so
it doesn't underflow.

18:01 Changeset [74445] by andersca@apple.com

2010-12-21 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler.

Can't stop QT music on santastreefarm.com
https://bugs.webkit.org/show_bug.cgi?id=51438
<rdar://problem/8741152>

Implement NPN_ConvertPoint.

  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp: (WebKit::NPN_ConvertPoint): Call NetscapePlugin::convertPoint.

(WebKit::initializeBrowserFuncs):
Only initialize NPN_ConvertPoint and NPN_PopUpContextMenu on Mac.

  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm: (WebKit::NetscapePlugin::convertPoint): Implement conversion routines.

(WebKit::NetscapePlugin::windowAndViewFramesChanged):
Keep track of the window and view frames, they are needed to do coordinate conversion.

17:59 Changeset [74444] by rniwa@webkit.org

2010-12-21 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

CharacterData needs cleanup
https://bugs.webkit.org/show_bug.cgi?id=51426

Extracted CharacterData::setDataAndNotify and CharacterData::updateRenderer.

  • dom/CharacterData.cpp: (WebCore::CharacterData::setData): Calls setDataAndUpdate. (WebCore::CharacterData::parserAppendData): Ditto. (WebCore::CharacterData::appendData): Ditto. (WebCore::CharacterData::insertData): Ditto. (WebCore::CharacterData::deleteData): Ditto. (WebCore::CharacterData::replaceData): Ditto. (WebCore::CharacterData::setDataAndUpdate): Added. (WebCore::CharacterData::updateRenderer): Added. (WebCore::CharacterData::dispatchModifiedEvent): Renamed prevValue to oldData.
  • dom/CharacterData.h:
17:41 Changeset [74443] by tonyg@chromium.org

2010-12-21 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r74420.
http://trac.webkit.org/changeset/74420
https://bugs.webkit.org/show_bug.cgi?id=51436

causes editing/pasteboard/paste-noscript-xhtml.xhtml to crash
(Requested by tonyg-cr on #webkit).

  • dom/DocumentParser.cpp:
  • dom/DocumentParser.h:
  • html/parser/HTMLDocumentParser.cpp:
  • html/parser/HTMLDocumentParser.h:
  • html/parser/HTMLParserScheduler.cpp: (WebCore::HTMLParserScheduler::HTMLParserScheduler):
  • html/parser/HTMLParserScheduler.h: (WebCore::HTMLParserScheduler::isScheduledForResume):
  • page/PageGroupLoadDeferrer.cpp: (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer): (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
17:34 Changeset [74442] by kbr@google.com

2010-12-21 Kenneth Russell <kbr@google.com>

Reviewed by Darin Fisher.

Enable extensions used in accelerated 2D canvas implementation
https://bugs.webkit.org/show_bug.cgi?id=51433

Call Extensions3D::ensureEnabled() for all supported extensions
the accelerated 2D Canvas implementation uses. Tested with a few
layout tests previously failing when run in Chromium due to OpenGL
INVALID_ENUM and other errors.

  • platform/graphics/gpu/DrawingBuffer.cpp: (WebCore::DrawingBuffer::create):
  • platform/graphics/gpu/SharedGraphicsContext3D.cpp: (WebCore::SharedGraphicsContext3D::SharedGraphicsContext3D): (WebCore::SharedGraphicsContext3D::supportsBGRA):
  • platform/graphics/gpu/SharedGraphicsContext3D.h:
17:30 Changeset [74441] by barraclough@apple.com

<rdar://problem/8241425> JIT executable memory excessive usage due to regex caching
https://bugs.webkit.org/show_bug.cgi?id=51434

Reviewed by Geoff Garen.

Reduce the amount of memory the RegExpCache can hold on to on iOS.
Currently the RegExpCache can hold 256 RegExp objects. If each falls into a separate
ExecutablePool, with a common size of 16Kb, this means we end up holding onto 4Mb of
memory. Firstly, we can reduce this by simply reducing the size of the cache to 32
entries. Secondly, we can use a separate set of ExecutablePools for JIT code generated
from RegExp objects. This helps in two ways (1) it increases the probability that
RegExps in the cache share the same pool, and (2) it means that a RegExp can't end
up holding on to a large ExecutablePool containing a translation of JS code.
(A RegExp could end up keeping a larger RegExp alive that happened to be sharing the
same pool, but large RegExp patterns are less common).

  • runtime/JSGlobalData.h:
  • runtime/RegExpCache.h:
  • yarr/RegexJIT.cpp:

(JSC::Yarr::RegexGenerator::compile):

17:08 Changeset [74440] by zmo@google.com

2010-12-21 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

WebGLRenderingContext needs to zero textures and renderbuffers
https://bugs.webkit.org/show_bug.cgi?id=49355

  • src/WebGraphicsContext3DDefaultImpl.cpp: (WebKit::WebGraphicsContext3DDefaultImpl::texImage2D): Generate an INVALID_VALUE if pixels==null is passed in.

2010-12-21 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

WebGLRenderingContext needs to zero textures and renderbuffers
https://bugs.webkit.org/show_bug.cgi?id=49355

Test: fast/canvas/webgl/uninitialized-test.html

  • html/canvas/WebGLFramebuffer.cpp: (WebCore::WebGLFramebuffer::onAccess): Use a parameter to decide if renderbuffer initialization is needed. (WebCore::WebGLFramebuffer::initializeRenderbuffers): Don't return false if color buffer doesn't exist.
  • html/canvas/WebGLFramebuffer.h: Modify onAccess with an added parameter.
  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::clear): Call onAccess with an added parameter. (WebCore::WebGLRenderingContext::copyTexImage2D): Ditto. (WebCore::WebGLRenderingContext::copyTexSubImage2D): Ditto. (WebCore::WebGLRenderingContext::drawArrays): Ditto. (WebCore::WebGLRenderingContext::drawElements): Ditto. (WebCore::WebGLRenderingContext::readPixels): Ditto. (WebCore::WebGLRenderingContext::texImage2DBase): Create buffer data of 0s if input is null to initialize textures.
  • platform/graphics/GraphicsContext3D.cpp: (WebCore::GraphicsContext3D::texImage2DResourceSafe): Helper function that initialize all pixels to 0.
  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/chromium/Canvas2DLayerChromium.cpp: (WebCore::Canvas2DLayerChromium::updateContentsIfDirty): Use texImage2DResourceSafe.
  • platform/graphics/chromium/DrawingBufferChromium.cpp: (WebCore::generateColorTexture): Ditto.
  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::prepareToDrawLayers): Ditto.
  • platform/graphics/chromium/TextureManager.cpp: (WebCore::TextureManager::requestTexture): Ditto.
  • platform/graphics/chromium/VideoLayerChromium.cpp: (WebCore::VideoLayerChromium::allocateTexture): Ditto.
  • platform/graphics/gpu/DrawingBuffer.cpp: (WebCore::DrawingBuffer::reset): Use texImage2DResourceSafe; also, only initialize depth/stencil buffer.
  • platform/graphics/gpu/SharedGraphicsContext3D.cpp: (WebCore::SharedGraphicsContext3D::texImage2D): Use texImage2DResourceSafe.
  • platform/graphics/gpu/Texture.cpp: (WebCore::Texture::create): Ditto.
  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp: (WebCore::GraphicsContext3D::texImage2D): Generate an INVALID_VALUE if pixels==null is passed in.

2010-12-21 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

WebGLRenderingContext needs to zero textures and renderbuffers
https://bugs.webkit.org/show_bug.cgi?id=49355

  • fast/canvas/webgl/uninitialized-test-expected.txt: Added.
  • fast/canvas/webgl/uninitialized-test.html: Added.
17:06 Changeset [74439] by crogers@google.com

2010-12-21 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

Add AudioBusChromium for decoding audio file data
https://bugs.webkit.org/show_bug.cgi?id=51430

No new tests since audio API is not yet implemented.

  • platform/audio/chromium: Added.
  • platform/audio/chromium/AudioBusChromium.cpp: Added. (WebCore::createBusFromInMemoryAudioFile):
16:45 Changeset [74438] by kbr@google.com

2010-12-21 Kenneth Russell <kbr@google.com>

Unreviewed test expectations update. Remove the following five
expected text differences from the chromium-gpu test expectations
file, because these tests are now passing in DumpRenderTree (and
Chromium with --in-process-webgl --disable-accelerated-compositing):

canvas/philip/tests/2d.shadow.transform.2.html
canvas/philip/tests/2d.imageData.get.source.outside.html
fast/canvas/canvas-scale-fillRect-shadow.html
fast/canvas/canvas-scale-fillPath-shadow.html
fast/canvas/canvas-scale-strokePath-shadow.html

  • platform/chromium-gpu/test_expectations.txt:
16:43 Changeset [74437] by barraclough@apple.com

Windows build fix.

16:37 Changeset [74436] by weinig@apple.com

Implement encoding/decoding of ResourceRequest and
ResourceResponse for Windows/CFNetwork.

Reviewed by Anders Carlsson.

  • Shared/win/WebCoreArgumentCodersWin.cpp:

(CoreIPC::encodeResourceRequest):
(CoreIPC::decodeResourceRequest):
(CoreIPC::encodeResourceResponse):
(CoreIPC::decodeResourceResponse):

  • win/WebKit2.vcproj:
  • win/WebKit2Common.vsprops:
16:11 Changeset [74435] by aestes@apple.com

Rebaseline test for r74427.

  • http/tests/local/formdata/send-form-data-with-sliced-file-expected.txt: Updated.
16:04 Changeset [74434] by barraclough@apple.com

Eeeep! build fix!

  • wtf/OSAllocator.h:

(WTF::OSAllocator::decommitAndRelease):

16:01 Changeset [74433] by crogers@google.com

2010-12-21 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

Add web audio spatialization resource files
https://bugs.webkit.org/show_bug.cgi?id=50998

No new tests since audio API is not yet implemented.

  • platform/audio/HRTFElevation.cpp: (WebCore::HRTFElevation::calculateKernelsForAzimuthElevation):
  • platform/audio/mac/AudioBusMac.mm: (WebCore::AudioBus::loadPlatformResource):
  • platform/audio/resources: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T000_P000.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T000_P015.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T000_P030.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T000_P045.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T000_P060.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T000_P075.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T000_P090.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T000_P315.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T000_P330.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T000_P345.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T015_P000.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T015_P015.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T015_P030.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T015_P045.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T015_P060.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T015_P075.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T015_P090.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T015_P315.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T015_P330.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T015_P345.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T030_P000.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T030_P015.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T030_P030.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T030_P045.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T030_P060.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T030_P075.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T030_P090.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T030_P315.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T030_P330.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T030_P345.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T045_P000.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T045_P015.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T045_P030.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T045_P045.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T045_P060.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T045_P075.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T045_P090.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T045_P315.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T045_P330.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T045_P345.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T060_P000.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T060_P015.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T060_P030.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T060_P045.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T060_P060.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T060_P075.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T060_P090.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T060_P315.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T060_P330.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T060_P345.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T075_P000.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T075_P015.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T075_P030.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T075_P045.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T075_P060.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T075_P075.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T075_P090.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T075_P315.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T075_P330.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T075_P345.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T090_P000.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T090_P015.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T090_P030.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T090_P045.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T090_P060.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T090_P075.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T090_P090.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T090_P315.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T090_P330.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T090_P345.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T105_P000.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T105_P015.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T105_P030.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T105_P045.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T105_P060.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T105_P075.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T105_P090.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T105_P315.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T105_P330.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T105_P345.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T120_P000.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T120_P015.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T120_P030.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T120_P045.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T120_P060.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T120_P075.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T120_P090.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T120_P315.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T120_P330.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T120_P345.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T135_P000.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T135_P015.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T135_P030.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T135_P045.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T135_P060.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T135_P075.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T135_P090.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T135_P315.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T135_P330.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T135_P345.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T150_P000.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T150_P015.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T150_P030.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T150_P045.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T150_P060.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T150_P075.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T150_P090.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T150_P315.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T150_P330.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T150_P345.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T165_P000.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T165_P015.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T165_P030.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T165_P045.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T165_P060.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T165_P075.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T165_P090.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T165_P315.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T165_P330.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T165_P345.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T180_P000.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T180_P015.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T180_P030.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T180_P045.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T180_P060.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T180_P075.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T180_P090.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T180_P315.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T180_P330.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T180_P345.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T195_P000.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T195_P015.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T195_P030.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T195_P045.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T195_P060.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T195_P075.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T195_P090.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T195_P315.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T195_P330.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T195_P345.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T210_P000.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T210_P015.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T210_P030.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T210_P045.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T210_P060.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T210_P075.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T210_P090.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T210_P315.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T210_P330.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T210_P345.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T225_P000.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T225_P015.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T225_P030.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T225_P045.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T225_P060.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T225_P075.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T225_P090.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T225_P315.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T225_P330.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T225_P345.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T240_P000.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T240_P015.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T240_P030.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T240_P045.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T240_P060.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T240_P075.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T240_P090.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T240_P315.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T240_P330.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T240_P345.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T255_P000.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T255_P015.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T255_P030.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T255_P045.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T255_P060.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T255_P075.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T255_P090.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T255_P315.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T255_P330.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T255_P345.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T270_P000.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T270_P015.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T270_P030.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T270_P045.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T270_P060.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T270_P075.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T270_P090.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T270_P315.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T270_P330.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T270_P345.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T285_P000.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T285_P015.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T285_P030.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T285_P045.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T285_P060.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T285_P075.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T285_P090.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T285_P315.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T285_P330.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T285_P345.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T300_P000.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T300_P015.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T300_P030.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T300_P045.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T300_P060.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T300_P075.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T300_P090.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T300_P315.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T300_P330.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T300_P345.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T315_P000.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T315_P015.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T315_P030.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T315_P045.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T315_P060.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T315_P075.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T315_P090.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T315_P315.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T315_P330.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T315_P345.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T330_P000.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T330_P015.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T330_P030.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T330_P045.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T330_P060.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T330_P075.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T330_P090.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T330_P315.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T330_P330.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T330_P345.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T345_P000.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T345_P015.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T345_P030.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T345_P045.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T345_P060.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T345_P075.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T345_P090.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T345_P315.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T345_P330.wav: Added.
  • platform/audio/resources/IRC_Composite_C_R0195_T345_P345.wav: Added.
15:56 Changeset [74432] by barraclough@apple.com

Ooops, fixed typo in comment.

  • wtf/OSAllocator.h:
15:53 Changeset [74431] by barraclough@apple.com

JavaScriptCore: Added PageAllocationAligned, a cross-platform abstraction for memory allocations with arbitrary alignment requirements
https://bugs.webkit.org/show_bug.cgi?id=51359

Patch by Geoffrey Garen <ggaren@apple.com> on 2010-12-21
Reviewed by Gavin Barraclough & Oliver Hunt.

I think this patch fixes <rdar://problem/8107952> [5.0.1] WER crash in
Heap::allocateBlock (1902752929), and some other leaks and crashes as well.

  • runtime/AlignedMemoryAllocator.h: Removed. Supplanted by

PageAllocationAligned.

  • runtime/Collector.cpp:

(JSC::Heap::destroy):
(JSC::Heap::allocateBlock):
(JSC::Heap::freeBlock):
(JSC::Heap::addWeakGCHandle):

  • runtime/Collector.h: Switched from AlignedMemoryAllocator to

PageAllocationAligned.

  • runtime/GCHandle.cpp:
  • runtime/GCHandle.h: Ditto.
  • wtf/PageAllocation.h:

(WTF::PageAllocation::PageAllocation): Removed aligned memory allocation
functions. Supplanted by PageAllocationAligned.

  • wtf/PageAllocationAligned.cpp: Added.

(WTF::PageAllocationAligned::allocate):
(WTF::PageAllocationAligned::deallocate):

  • wtf/PageAllocationAligned.h: Added.

(WTF::PageAllocationAligned::PageAllocationAligned): New cross-platform
class for doing aligned memory allocation. This class properly matches
allocation and deallocation library calls, fixing a long-standing bug
in PageAllocation.

  • wtf/Platform.h: Removed some defunction VM platform defines.
  • wtf/wtf.pri: Updated build files.

JavaScriptGlue: Added PageAllocationAligned, a cross-platform abstraction for memory allocations with arbitrary alignment requirements
https://bugs.webkit.org/show_bug.cgi?id=51359

Patch by Geoffrey Garen <ggaren@apple.com> on 2010-12-21
Reviewed by Gavin Barraclough & Oliver Hunt.

  • ForwardingHeaders/wtf/PageAllocationAligned.h: Added.

WebCore: Added PageAllocationAligned, a cross-platform abstraction for memory allocations with arbitrary alignment requirements
https://bugs.webkit.org/show_bug.cgi?id=51359

Patch by Geoffrey Garen <ggaren@apple.com> on 2010-12-21
Reviewed by Gavin Barraclough & Oliver Hunt.

  • ForwardingHeaders/wtf/PageAllocationAligned.h: Added.
15:26 Changeset [74430] by ariya@webkit.org

2010-12-21 Ariya Hidayat <ariya@sencha.com>

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=49774
Need to scale translation values in matrix() by the zoom factor.

  • fast/transforms/matrix-with-zoom-expected.checksum: Added.
  • fast/transforms/matrix-with-zoom-expected.png: Added.
  • fast/transforms/matrix-with-zoom-expected.txt: Added.
  • fast/transforms/matrix-with-zoom.html: Added.

2010-12-21 Ariya Hidayat <ariya@sencha.com>

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=49774
Need to scale translation values in matrix() by the zoom factor.

Test: fast/transforms/matrix-with-zoom.html

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::createTransformOperations):
15:19 Changeset [74429] by weinig@apple.com

Add serialization for CFURLRequestRef and CFURLResponseRef.

Reviewed by Anders Carlsson.

  • win/include/WebKitSystemInterface/WebKitSystemInterface.h:
  • win/lib/WebKitSystemInterface.lib:
14:54 Changeset [74428] by oliver@apple.com

2010-12-21 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

ASSERTION FAILED: base->index() == m_codeBlock->argumentsRegister() while loading taobao.com
https://bugs.webkit.org/show_bug.cgi?id=49006

This problem was caused by having a parameter named 'arguments'.
The fix is to treat parameters named 'arguments' as shadowing
the actual arguments property, and so logically turn the function
into one that doesn't "use" arguments.

This required a bit of fiddling in the parser to ensure we correctly
propagate the 'feature' of shadowing is set correctly.

  • bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::createArgumentsIfNecessary): Change assertion to an early return as we may now reference a property named 'arguments' without being in a function that has the ArgumentsFeature
  • parser/JSParser.cpp: (JSC::JSParser::Scope::Scope): (JSC::JSParser::Scope::declareParameter): (JSC::JSParser::Scope::shadowsArguments): (JSC::JSParser::parseProgram): (JSC::JSParser::parseFormalParameters): (JSC::JSParser::parseFunctionInfo):
  • parser/Nodes.h: (JSC::ScopeNode::usesArguments):

2010-12-21 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

ASSERTION FAILED: base->index() == m_codeBlock->argumentsRegister() while loading taobao.com
https://bugs.webkit.org/show_bug.cgi?id=49006

Add new tests to cover the cases of a parameter named arguments being used.
Also correct a couple of existing (incorrect) tests.

  • fast/js/arguments-expected.txt:
  • fast/js/script-tests/arguments.js: (argumentsVarUndefined): (argumentsConstUndefined): (shadowedArgumentsLength): (shadowedArgumentsCallee): (shadowedArgumentsIndex):
14:36 Changeset [74427] by aestes@apple.com

2010-12-21 Jian Li <jianli@chromium.org>

Reviewed by Darin Adler.

Fix bug 51366: REGRESSION (r66452): Form data no longer contains
'Content-Type' header for files with unrecognized extensions
https://bugs.webkit.org/show_bug.cgi?id=51366

Test: http/tests/local/formdata/form-data-with-unknown-file-extension.html

  • platform/network/FormData.cpp: (WebCore::FormData::appendKeyValuePairItems):

2010-12-21 Jian Li <jianli@chromium.org>

Reviewed by Darin Adler.

Fix bug 51366: REGRESSION (r66452): Form data no longer contains
'Content-Type' header for files with unrecognized extensions
https://bugs.webkit.org/show_bug.cgi?id=51366

  • http/tests/local/formdata/form-data-with-unknown-file-extension-expected.txt: Added.
  • http/tests/local/formdata/form-data-with-unknown-file-extension.html: Added.
  • http/tests/local/resources/file.invalid: Added.
14:24 Changeset [74426] by darin@apple.com

2010-12-21 Darin Adler <darin@apple.com>

Reviewed by Sam Weinig.

Mac WebKit delivers an extra didCommit when loading web archives
https://bugs.webkit.org/show_bug.cgi?id=51419

Could not find a simple way to test this in WebKit1, but in WebKit2
it leads to an immediate failure when loading a web archive. Tested
that making the Mac share the same code path with other platforms
works fine in WebKit1.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::finishedLoadingDocument): Removed special case for the Mac platform. Also removed the call to isArchiveMimeType since we get a 0 from ArchiveFactory::create in that case.
  • loader/archive/ArchiveFactory.cpp: (WebCore::ArchiveFactory::isArchiveMimeType): Hardened slightly by adding a special case for null and empty strings, since hash tables can't handle null strings. (WebCore::ArchiveFactory::create): Ditto.

2010-12-21 Darin Adler <darin@apple.com>

Reviewed by Sam Weinig.

Mac WebKit delivers an extra didCommit when loading web archives
https://bugs.webkit.org/show_bug.cgi?id=51419

  • UIProcess/WebFrameProxy.cpp: (WebKit::WebFrameProxy::didStartProvisionalLoad): Added assertions so we catch inconsistencies here instead of at the application level. Later, we will have to decide what to do in cases these assertions fail. The right policy is probably to consider it a web process failure and do whatever we do for those. (WebKit::WebFrameProxy::didReceiveServerRedirectForProvisionalLoad): Ditto. (WebKit::WebFrameProxy::didFailProvisionalLoad): Ditto. (WebKit::WebFrameProxy::didCommitLoad): Ditto. (WebKit::WebFrameProxy::didFinishLoad): Ditto. (WebKit::WebFrameProxy::didFailLoad): Ditto.
13:28 Changeset [74425] by andersca@apple.com

Fix Snow Leopard build.

  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:

(WebKit::NPN_GetValue):

13:22 Changeset [74424] by dbates@webkit.org

2010-12-21 Daniel Bates <dbates@rim.com>

Reviewed by Eric Seidel and Darin Adler.

Deallocate GregorianDateTime.timeZone (if allocated) when copying so that we don't leak memory.
https://bugs.webkit.org/show_bug.cgi?id=51367

Inspired by a patch by George Staikos.

  • wtf/DateMath.cpp: (JSC::msToGregorianDateTime): Modified to set timeZone to nullptr since timeZone is now of type OwnPtrArray<char>.
  • wtf/DateMath.h: Change timeZone to type OwnArrayPtr<char>; Removed destructor since it is no longer needed. (JSC::GregorianDateTime::GregorianDateTime): Modified to use OwnPtrArray semantics for timeZone. (JSC::GregorianDateTime::operator tm): Ditto. (JSC::GregorianDateTime::copyFrom): Ditto.

2010-12-21 Daniel Bates <dbates@rim.com>

Reviewed by Eric Seidel and Darin Adler.

Deallocate GregorianDateTime.timeZone (if allocated) when copying so that we don't leak memory.
https://bugs.webkit.org/show_bug.cgi?id=51367

Add forwarding header for PassOwnArrayPtr.h.

  • ForwardingHeaders/wtf/PassOwnArrayPtr.h: Added.
13:18 Changeset [74423] by andersca@apple.com

Fix crash when a Carbon plug-in fails to initialize correctly
https://bugs.webkit.org/show_bug.cgi?id=51415

Reviewed by Dan Bernstein.

  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:

(WebKit::NPN_GetValue):
Don't claim to support the QuickDraw event model.

  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:

(WebKit::NetscapePlugin::platformDestroy):
Only try to remove the window from the map if it's not null.

12:59 Changeset [74422] by andersca@apple.com

2010-12-21 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler.

Add ArgumentCoder support for CFDataRef
https://bugs.webkit.org/show_bug.cgi?id=51412

  • Shared/cf/ArgumentCodersCF.cpp: (CoreIPC::typeFromCFTypeRef): (CoreIPC::encode): (CoreIPC::decode):
  • Shared/cf/ArgumentCodersCF.h:
12:15 Changeset [74421] by mihaip@chromium.org

2010-12-21 Mihai Parparita <mihaip@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Rename WebThemeEngine/ControlDRT to WebThemeEngine/ControlDRTWin
https://bugs.webkit.org/show_bug.cgi?id=51406

Rename WebThemeControlDRT to WebThemeControlDRTWin and WebThemeEngineDRT
to WebThemeEngineDRTWin and update references everywhere.

  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/chromium/TestShellWin.cpp:
  • DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.cpp.
  • DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.h.
  • DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.cpp.
  • DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.h.
11:24 Changeset [74420] by commit-queue@webkit.org

2010-12-21 Yong Li <yoli@rim.com>

Reviewed by Adam Barth.

Suspend HTMLParserScheduler when page load is deferred to
avoid potential JS re-entrancy. Otherwise, when JS execution is triggered
from an external script or by events, and is blocked by a modal dialog,
WebKit can parse more HTML source and also start another JS execution.

https://bugs.webkit.org/show_bug.cgi?id=48077

Test case: WebCore/manual-tests/bugzilla-48077.html.

  • dom/DocumentParser.cpp: (WebCore::DocumentParser::suspendParsing): (WebCore::DocumentParser::resumeParsing):
  • dom/DocumentParser.h:
  • html/parser/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::suspendParsing): (WebCore::HTMLDocumentParser::resumeParsing):
  • html/parser/HTMLParserScheduler.cpp: (WebCore::HTMLParserScheduler::HTMLParserScheduler): (WebCore::HTMLParserScheduler::suspend): (WebCore::HTMLParserScheduler::resume):
  • html/parser/HTMLParserScheduler.h: (WebCore::HTMLParserScheduler::isScheduledForResume):
  • page/PageGroupLoadDeferrer.cpp: (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer): (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
11:20 Changeset [74419] by tonyg@chromium.org

2010-12-21 Tony Gentilcore <tonyg@chromium.org>

Unreviewed build fix.

[chromium] Marking fast/canvas/shadow-offset-*.html flaky on mac debug
https://bugs.webkit.org/show_bug.cgi?id=51409

  • platform/chromium/test_expectations.txt:
10:29 Changeset [74418] by andersca@apple.com

2010-12-21 Anders Carlsson <andersca@apple.com>

Reviewed by John Sullivan.

Clicking missing plug-in text does not show a sheet
https://bugs.webkit.org/show_bug.cgi?id=51403

  • WebCore.exp.in: Export symbols needed by WebKit2.
  • WebCore.xcodeproj/project.pbxproj: Make HTMLPlugInImageElement.h a private header.
  • html/HTMLPlugInImageElement.h: (WebCore::HTMLPlugInImageElement::serviceType): (WebCore::HTMLPlugInImageElement::url): Make these member functions public.

2010-12-21 Anders Carlsson <andersca@apple.com>

Reviewed by John Sullivan.

Clicking missing plug-in text does not show a sheet
https://bugs.webkit.org/show_bug.cgi?id=51403

Update for changes to the WebPageUIClient.

  • MiniBrowser/mac/BrowserWindowController.m: (-[BrowserWindowController awakeFromNib]):
  • WebKitTestRunner/TestController.cpp: (WTR::createOtherPage): (WTR::TestController::initialize):

2010-12-21 Anders Carlsson <andersca@apple.com>

Reviewed by John Sullivan.

Clicking missing plug-in text does not show a sheet
https://bugs.webkit.org/show_bug.cgi?id=51403

  • UIProcess/API/C/WKPage.h: Add missingPluginButtonClicked to WKPageUIClient.
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::missingPluginButtonClicked): Call the WebUIClient member function.
  • UIProcess/WebPageProxy.messages.in: Add MissingPluginButtonClicked message.
  • UIProcess/WebUIClient.cpp: (WebKit::WebUIClient::missingPluginButtonClicked): Call the WKPageUIClient callback.
  • UIProcess/WebUIClient.h:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::shouldMissingPluginMessageBeButton): Always return true for now.

(WebKit::WebChromeClient::missingPluginButtonClicked):
Send a MissingPluginButtonClicked message.

09:56 Changeset [74417] by tonyg@chromium.org

2010-12-21 Tony Gentilcore <tonyg@chromium.org>

Unreviewed build fix.

Rebaseline fast/js/large-expressions.html
https://bugs.webkit.org/show_bug.cgi?id=51404

  • platform/chromium-mac/fast/js/large-expressions-expected.txt:
  • platform/chromium-win/fast/js/large-expressions-expected.txt:
09:41 Changeset [74416] by abecsi@webkit.org

2010-12-21 Andras Becsi <abecsi@webkit.org>

Unreviewed build fix.

[Qt] Fix the build with USE_GSTREAMER=1

No new tests needed.

  • WebCore.pro: remove nonexisting DataSourceGStreamer sources.
08:56 Changeset [74415] by commit-queue@webkit.org

2010-12-21 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r74402.
http://trac.webkit.org/changeset/74402
https://bugs.webkit.org/show_bug.cgi?id=51402

This patch broke the Windows 7 Release Layout Tests (Requested
by jessieberlin on #webkit).

  • wtf/StackBounds.cpp: (WTF::estimateStackBound): (WTF::StackBounds::initialize):

2010-12-21 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r74402.
http://trac.webkit.org/changeset/74402
https://bugs.webkit.org/show_bug.cgi?id=51402

This patch broke the Windows 7 Release Layout Tests (Requested
by jessieberlin on #webkit).

  • fast/js/large-expressions-expected.txt:
  • fast/js/script-tests/large-expressions.js:
08:33 EFLWebKit edited by demarchi@webkit.org
(diff)
07:52 Changeset [74414] by andreip@google.com

2010-12-21 Andrei Popescu <andreip@google.com>

Unreviewed build fix.

Update the test expectations to mark these tests as timing out.
[Chromium] inspector/console-dir-global.html and inspector/debugger-expand-scope.html are timing out on OSX
https://bugs.webkit.org/show_bug.cgi?id=51398

  • platform/chromium/test_expectations.txt:
06:59 Changeset [74413] by andreip@google.com

2010-12-21 Andrei Popescu <andreip@google.com>

Unreviewed build fix.

Rebaseline fast/js/large-expressions.html
[v8] trunk/LayoutTests/fast/js/large-expressions.html fails since r74402
https://bugs.webkit.org/show_bug.cgi?id=51391

  • platform/chromium-mac/fast/js/large-expressions-expected.txt:
  • platform/chromium-win/fast/js/large-expressions-expected.txt:
  • platform/chromium/test_expectations.txt:
06:42 Changeset [74412] by ossy@webkit.org

Unify the name of parentheses in YARR: rename parenthesis to
parentheses.

Patch by Peter Varga <pvarga@inf.u-szeged.hu> on 2010-12-21
Reviewed by Csaba Osztrogonác.

  • yarr/RegexCompiler.cpp:

(JSC::Yarr::RegexPatternConstructor::atomParenthesesEnd):

06:28 Changeset [74411] by andreip@google.com

2010-12-21 Andrei Popescu <andreip@google.com>

Unreviewed build fix.

[v8] trunk/LayoutTests/fast/js/large-expressions-expected.txt fails since r74402
https://bugs.webkit.org/show_bug.cgi?id=51391

Udpate Chromium layout test expectations temporarily while
we look for a fix for the above test.

  • platform/chromium/test_expectations.txt:
05:29 Changeset [74410] by andreip@google.com

2010-12-21 Andrei Popescu <andreip@google.com>

Unreviewed build fix.

[Chromium] media/audio-controls-rendering.html and fast/gradients/gradient-after-transparent-border.html need rebaselining
https://bugs.webkit.org/show_bug.cgi?id=51388

  • platform/chromium-linux/fast/gradients/gradient-after-transparent-border-expected.checksum: Added.
  • platform/chromium-linux/fast/gradients/gradient-after-transparent-border-expected.png: Added.
  • platform/chromium-linux/media/audio-controls-rendering-expected.checksum:
  • platform/chromium-linux/media/audio-controls-rendering-expected.png:
  • platform/chromium-mac/fast/gradients/gradient-after-transparent-border-expected.checksum: Added.
  • platform/chromium-mac/fast/gradients/gradient-after-transparent-border-expected.png: Added.
  • platform/chromium-win/media/audio-controls-rendering-expected.checksum:
  • platform/chromium-win/media/audio-controls-rendering-expected.png:
05:11 Changeset [74409] by commit-queue@webkit.org

2010-12-21 Mahesh Kulkarni <mahesh.kulkarni@nokia.com>

Reviewed by Andreas Kling.

[Qt] QtWebKit doesn't build in debug on Windows
https://bugs.webkit.org/show_bug.cgi?id=41930

Disable incremental linking in windows 32bit debug version as webkit is so
big it fails to link incremental.

Build fix. No new test cases added.

  • WebCore.pro:
04:55 Changeset [74408] by eric@webkit.org

2010-12-21 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

commit-queue will report constant failures as flaky if other tests flake
https://bugs.webkit.org/show_bug.cgi?id=51272

This patch just removes functionality and adds testing.
Previously we attempted to report flaky tests when we had
two different tests fail in a row. However, since we stop
running the tests at the first failure, our code was wrong in
trying to determine flakiness from the incomplete runs.

Originally I posted an alternate patch:
https://bug-51272-attachments.webkit.org/attachment.cgi?id=77078
which fixed our flaky logic in this case, however it was decided
that that patch would be too difficult to maintain, so now
I'm just removing the broken logic.

This will dramatically cut-down on our flaky-test false positives
at the (small) cost of the queues being unable to report
any flakiness if the tree is very flaky. (With at least one test
flaking on every run, we'll never report failures anymore.) I think
this is a tradeoff worth making.

  • Scripts/webkitpy/tool/bot/commitqueuetask.py:
  • Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
04:39 Changeset [74407] by laszlo.1.gombos@nokia.com

2010-12-21 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Andreas Kling.

[Qt] Set BUILDING_QT consistently
https://bugs.webkit.org/show_bug.cgi?id=51341

  • JavaScriptCore.pri: Remove the definition of BUILDING_QT as it is already defined in WebKit.pri.

2010-12-21 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Andreas Kling.

[Qt] Set BUILDING_QT consistently
https://bugs.webkit.org/show_bug.cgi?id=51341

  • WebKit2.pro: Remove the definition of BUILDING_QT as it is already defined in WebKit.pri.
01:55 Changeset [74406] by commit-queue@webkit.org

2010-12-21 Dominic Cooney <dominicc@google.com>

Reviewed by Adam Barth.

Rename Node::isShadowNode to isShadowRoot
https://bugs.webkit.org/show_bug.cgi?id=51060

The method gets whether the node is the root of a shadow tree;
renamed to reflect intent.

A simple rename--no new tests needed.

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::initForStyleResolve): (WebCore::CSSStyleSelector::SelectorChecker::checkSelector):
  • dom/Node.cpp: (WebCore::Node::shadowTreeRootNode): (WebCore::Node::isInShadowTree): (WebCore::eventTargetRespectingSVGTargetRules): (WebCore::Node::getEventAncestors):
  • dom/Node.h: (WebCore::Node::isShadowRoot):
  • dom/Range.cpp: (WebCore::Range::checkNodeBA):
  • page/DragController.cpp: (WebCore::asFileInput):
  • page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEvent): (WebCore::EventHandler::dispatchMouseEvent):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::hasLineIfEmpty):
  • rendering/TextControlInnerElements.cpp: (WebCore::TextControlInnerElement::attachInnerElement):
  • svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::title):
  • svg/SVGUseElement.cpp: (WebCore::ShadowTreeUpdateBlocker::while):
  • svg/animation/SVGSMILElement.cpp: (WebCore::SVGSMILElement::insertedIntoDocument):
00:34 Changeset [74405] by eric@webkit.org

2010-12-20 Eric Seidel <eric@webkit.org>

Unreviewed.

Removed a non-utf8 character from this file.
Looks like it was accidentally added in:
http://trac.webkit.org/changeset/72669
Which caused troubles for the contributor working on bug 51382.

Note: See TracTimeline for information about the timeline view.