Timeline


and

12/28/10:

23:45 Changeset [74734] by commit-queue@webkit.org

2010-12-28 Pratik Solanki <psolanki@apple.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=51522
Use deviceRGBColorSpaceRef() instead of calling CGColorSpaceCreateDeviceRGB()

  • page/win/FrameCGWin.cpp: (WebCore::imageFromRect):
  • platform/graphics/cg/GradientCG.cpp: (WebCore::Gradient::platformGradient):
  • platform/graphics/cg/GraphicsContext3DCG.cpp: (WebCore::GraphicsContext3D::paintToCanvas):
  • platform/graphics/cg/ImageCG.cpp: (WebCore::BitmapImage::checkForSolidColor):
  • platform/graphics/gstreamer/ImageGStreamerCG.mm: (ImageGStreamer::ImageGStreamer):
  • platform/graphics/win/GraphicsContextCGWin.cpp: (WebCore::CGContextWithHDC): (WebCore::GraphicsContext::releaseWindowsContext): (WebCore::GraphicsContext::drawWindowsBitmap):
  • platform/graphics/win/ImageCGWin.cpp: (WebCore::BitmapImage::create): (WebCore::BitmapImage::getHBITMAPOfSize):
  • platform/image-decoders/cg/ImageDecoderCG.cpp: (WebCore::createColorSpace):
  • platform/win/DragImageCGWin.cpp: (WebCore::allocImage): (WebCore::createCgContextFromBitmap):
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintMenuListButtonGradients): (WebCore::RenderThemeMac::paintSliderTrack):
  • rendering/RenderThemeSafari.cpp: (WebCore::RenderThemeSafari::paintMenuListButtonGradients): (WebCore::RenderThemeSafari::paintSliderTrack):
16:59 Changeset [74733] by dbates@webkit.org

2010-12-28 Daniel Bates <dbates@rim.com>

Reviewed by Sam Weinig.

Substitute MARK: for compiler-specific #pragma mark
https://bugs.webkit.org/show_bug.cgi?id=51657

For consistency, we should substitute " MARK:" for compiler-
specific "#pragma mark" in the source files for the Mac port.

  • History/WebHistory.mm:
  • Plugins/WebBaseNetscapePluginView.mm:
  • Plugins/WebNetscapePluginView.mm:
  • WebCoreSupport/WebInspectorClient.mm:
  • WebCoreSupport/WebSecurityOrigin.mm:
  • WebView/WebPDFView.mm:
  • WebView/WebVideoFullscreenController.mm:
  • WebView/WebVideoFullscreenHUDWindowController.mm:

2010-12-28 Daniel Bates <dbates@rim.com>

Reviewed by Sam Weinig.

Substitute MARK: for compiler-specific #pragma mark
https://bugs.webkit.org/show_bug.cgi?id=51657

Fix compilation warnings about "#pragma mark" on GTK+ bots by
substituting " MARK:" for "#pragma mark", which provides
analogous code-bookmarking functionality under Xcode.

  • platform/graphics/cg/PathCG.cpp:
  • platform/graphics/mac/WebLayer.mm:

2010-12-28 Daniel Bates <dbates@rim.com>

Reviewed by Sam Weinig.

Substitute MARK: for compiler-specific #pragma mark
https://bugs.webkit.org/show_bug.cgi?id=51657

Fix future compilation warnings about "#pragma mark" on GTK+ bots by
substituting " MARK:" for "#pragma mark", which provides
analogous code-bookmarking functionality under Xcode.

Also, for consistency, we should substitute " MARK:" for compiler-
specific "#pragma mark" in the source files for the Mac port.

  • DumpRenderTree/AccessibilityTextMarker.cpp:
  • DumpRenderTree/cf/WebArchiveDumpSupport.h:
  • DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
  • DumpRenderTree/mac/ObjCController.m:
  • MiniBrowser/mac/AppDelegate.m:
  • MiniBrowser/mac/BrowserWindowController.m:
16:56 Changeset [74732] by dbates@webkit.org

2010-12-28 Daniel Bates <dbates@rim.com>

Reviewed by Antonio Gomes.

Add comment to test case fast/repaint/no-caret-repaint-in-non-content-editable-element.html
to clarify caret browsing disabled
https://bugs.webkit.org/show_bug.cgi?id=51633

Add a comment to test case fast/repaint/no-caret-repaint-in-non-content-editable-element.html
that explains that this test is only applicable when caret browsing is disabled.

  • fast/repaint/no-caret-repaint-in-non-content-editable-element.html:
16:39 Changeset [74731] by mrobinson@webkit.org

2010-12-28 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Closing a window during an onload event can trigger serious GLib warnings
https://bugs.webkit.org/show_bug.cgi?id=51686

Don't emit the close-web-view signal immediately during execution of closeWindowSoon.
The signal handler may choose to destroy the web view while handling that signal,
which may remove the last reference to the web view. FrameLoaderClient depends on the
view still existing though. Instead, let the caller finish executing and emit the signal
after a 0 length timeout. This matches the behavior on the Windows and Mac ports.

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::ChromeClient): Initialize the timer id. (WebKit::emitCloseWebViewSignalLater): Callback for the timer. (WebKit::ChromeClient::closeWindowSoon): Do the actual signal invocation after the caller finishes its tasks.
  • WebCoreSupport/ChromeClientGtk.h: Add a new member for the timer id. We can use this to prevent emitting the close-web-view signal twice.
15:39 Changeset [74730] by mrobinson@webkit.org

2010-12-28 Martin Robinson <mrobinson@igalia.com>

Reviewed by Eric Seidel.

[GTK] Clean up usage of NULL in webkitwebframe.cpp
https://bugs.webkit.org/show_bug.cgi?id=51685

Replace occurrences of NULL with 0, in webkitwebframe.cpp. Not all
uses of NULL have been changed, as certain GLib functions require
an explicit NULL as a sentinel.

  • webkit/webkitwebframe.cpp: (webkit_web_frame_get_data_source_from_core_loader): (webkit_web_frame_class_init): (webkit_web_frame_new): (webkit_web_frame_get_title): (webkit_web_frame_get_uri): (webkit_web_frame_get_web_view): (webkit_web_frame_get_name): (webkit_web_frame_get_parent): (webkit_web_frame_load_string): (webkit_web_frame_load_alternate_string): (webkit_web_frame_find_frame): (webkit_web_frame_get_global_context): (webkit_web_frame_get_data_source): (webkit_web_frame_get_provisional_data_source): (webkit_web_frame_print_full): (webkit_web_frame_get_security_origin): (webkit_web_frame_get_network_response):
15:16 Changeset [74729] by kbr@google.com

2010-12-28 Kenneth Russell <kbr@google.com>

Reviewed by Eric Seidel.

Make fast/canvas/canvas-save-restore-with-path.js more robust
https://bugs.webkit.org/show_bug.cgi?id=51665

  • fast/canvas/canvas-save-restore-with-path-expected.txt:
  • fast/canvas/canvas-save-restore-with-path.js:
14:56 Changeset [74728] by commit-queue@webkit.org

2010-12-28 Jan Erik Hanssen <jhanssen@sencha.com>

Reviewed by Eric Seidel.

[Qt] GraphicsContext::getCTM() does not need to make a copy of QPainter::combinedTransform()
https://bugs.webkit.org/show_bug.cgi?id=51687

Use a const reference instead of a copy of QPainter::combinedTransform()
in GraphicsContext::getCTM()

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::getCTM):
14:45 Changeset [74727] by commit-queue@webkit.org

2010-12-28 Helder Correia <helder@sencha.com>

Reviewed by Eric Seidel.

JSON.stringify must exist as a function taking 3 parameters
https://bugs.webkit.org/show_bug.cgi?id=51667

The reported function length is 1 instead.

Test: ietestcenter/Javascript/15.12.3-0-2.html

  • runtime/JSONObject.cpp:

2010-12-28 Helder Correia <helder@sencha.com>

Reviewed by Eric Seidel.

JSON.stringify must exist as a function taking 3 parameters
https://bugs.webkit.org/show_bug.cgi?id=51667

The reported function length is 1 instead.

  • ietestcenter/Javascript/15.12.3-0-2-expected.txt:
14:20 Changeset [74726] by commit-queue@webkit.org

2010-12-28 Xan Lopez <xlopez@igalia.com>

Reviewed by Eric Seidel.

Add --no-build option to run-sunspider
https://bugs.webkit.org/show_bug.cgi?id=51658

  • Scripts/run-sunspider: add --no-build flag to skip building phase.
14:16 Fingerprinting edited by robert@roberthogan.net
(diff)
14:14 Changeset [74725] by commit-queue@webkit.org

2010-12-28 Takashi Toyoshima <toyoshim@google.com>

Reviewed by Eric Seidel.

gcc detected 'control reaches end of non-void function' with
-finstrument-functions option.
https://bugs.webkit.org/show_bug.cgi?id=51669

No new tests. These fixes are trivial.

  • dom/Element.cpp: (WebCore::Element::childTypeAllowed):
  • inspector/InspectorResourceAgent.cpp: (WebCore::cachedResourceTypeString):
14:11 Fingerprinting created by robert@roberthogan.net
13:57 Changeset [74724] by tonyg@chromium.org

2010-12-28 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Eric Seidel.

Remove unused member of PendingScript
https://bugs.webkit.org/show_bug.cgi?id=51684

This was used when HTMLScriptRunner::runScript created a PendingScript
for inline scripts. But now it just calls executeScript() directly.
External scripts always have the minimum starting line number.

No new tests because no changed functionality.

  • dom/PendingScript.cpp: (WebCore::PendingScript::releaseElementAndClear):
  • dom/PendingScript.h: (WebCore::PendingScript::PendingScript): (WebCore::PendingScript::operator=):
  • html/parser/HTMLScriptRunner.cpp: (WebCore::HTMLScriptRunner::sourceFromPendingScript):
13:57 Changeset [74723] by tonikitoo@webkit.org

2010-12-20 Antonio Gomes <agomes@rim.com>

Reviewed by Daniel Bates.

Spatial Navigation: code clean up (Part VI)
https://bugs.webkit.org/show_bug.cgi?id=50666

No new tests needed.

  • page/FocusController.cpp: (WebCore::updatFocusCandidateIfNeeded): Assert renderer() and isElementNode() now that we are bailing out earlier in both the FocusCandidate constructor and FocusController::findFocusCandidateInContainer().
  • page/SpatialNavigation.h: Swapped the parameters order in canScrollInDirection and virtualRectForAreaElementAndDirection functions. (WebCore::FocusController::findFocusCandidateInContainer): (WebCore::FocusController::advanceFocusDirectionallyInContainer): Adjusted call sites of canScrollInDirection(), and added an early return if !isElementNode(). (WebCore::FocusController::advanceFocusDirectionally): Adjusted call site of virtualRectForAreaElementAndDirection().
  • page/SpatialNavigation.cpp: (WebCore::FocusCandidate::FocusCandidate): Assert if node is not an Element node. (WebCore::isScrollableNode): Renamed from isScrollableContainerNode. (WebCore::scrollInDirection): Adjusted call site after function name change; (WebCore::scrollableEnclosingBoxOrParentFrameForNodeInDi:rection): Assert if node is a Document node. (WebCore::canScrollInDirection): Signature changed. (WebCore::canBeScrolledIntoView): Ditto. (WebCore::virtualRectForAreaElementAndDirection): Ditto.
13:53 Changeset [74722] by enne@google.com

2010-12-28 Adrienne Walker <enne@google.com>

Reviewed by Kenneth Russell.

[chromium] Fix tiled compositor assertion after GPU process recovery.
https://bugs.webkit.org/show_bug.cgi?id=51682

After the GPU process recovers, the layer size is set to IntSize(),
but IntRect::unite() has a special case for empty rects. This
behavior was causing the layer size to be too small, causing an
out-of-bounds array access elsewhere.

No new tests.

  • platform/graphics/chromium/LayerTilerChromium.cpp: (WebCore::LayerTilerChromium::growLayerToContain):
13:36 Changeset [74721] by commit-queue@webkit.org

2010-12-28 Helder Correia <helder@sencha.com>

Reviewed by Sam Weinig.

JSON.parse must exist as a function taking 2 parameters
https://bugs.webkit.org/show_bug.cgi?id=51666

Support for revivers was introduced in bug 26591, but the function
length has since remained unchanged.

Test: ietestcenter/Javascript/15.12.2-0-2.html

  • runtime/JSONObject.cpp:

2010-12-28 Helder Correia <helder@sencha.com>

Reviewed by Sam Weinig.

JSON.parse must exist as a function taking 2 parameters
https://bugs.webkit.org/show_bug.cgi?id=51666

Support for revivers was introduced in bug 26591, but the function
length has since remained unchanged.

  • ietestcenter/Javascript/15.12.2-0-2-expected.txt: Change expected result to success.
13:35 Changeset [74720] by zmo@google.com

2010-12-23 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Initialize to 0 for undefined values in CopyTexImage2D
https://bugs.webkit.org/show_bug.cgi?id=51421

  • src/GraphicsContext3DChromium.cpp: Implement getInternalFramebufferSize(). (WebCore::GraphicsContext3DInternal::getInternalFramebufferSize):
  • src/GraphicsContext3DInternal.h:

2010-12-23 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Initialize to 0 for undefined values in CopyTexImage2D
https://bugs.webkit.org/show_bug.cgi?id=51421

  • html/canvas/WebGLFramebuffer.cpp: Track width/height/internalFormat of color buffer. (WebCore::WebGLFramebuffer::WebGLFramebuffer): (WebCore::WebGLFramebuffer::setAttachment): (WebCore::WebGLFramebuffer::getWidth): (WebCore::WebGLFramebuffer::getHeight): (WebCore::WebGLFramebuffer::getColorBufferFormat):
  • html/canvas/WebGLFramebuffer.h:
  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::copyTexImage2D): Initialize undefined pixels to 0. (WebCore::WebGLRenderingContext::copyTexSubImage2D): (WebCore::WebGLRenderingContext::framebufferTexture2D): (WebCore::WebGLRenderingContext::renderbufferStorage): (WebCore::WebGLRenderingContext::getBoundFramebufferWidth): (WebCore::WebGLRenderingContext::getBoundFramebufferHeight):
  • html/canvas/WebGLRenderingContext.h:
  • html/canvas/WebGLTexture.cpp: Track width/height/internalFormat of a texture by target/level. (WebCore::WebGLTexture::getInternalFormat): (WebCore::WebGLTexture::getWidth): (WebCore::WebGLTexture::getHeight): (WebCore::WebGLTexture::mapTargetToIndex): (WebCore::WebGLTexture::getLevelInfo):
  • html/canvas/WebGLTexture.h: (WebCore::WebGLTexture::isTexture):
  • platform/graphics/GraphicsContext3D.h: Add getInternalFramebufferSize() function.
  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp: (WebCore::GraphicsContext3D::getInternalFramebufferSize):
  • platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3D::getInternalFramebufferSize):

2010-12-23 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Initialize to 0 for undefined values in CopyTexImage2D
https://bugs.webkit.org/show_bug.cgi?id=51421

  • fast/canvas/webgl/uninitialized-test-expected.txt: Add test cases for copyTexImage2D.
  • fast/canvas/webgl/uninitialized-test.html: Ditto.
13:26 Changeset [74719] by zmo@google.com

2010-12-23 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Map GLsizei to long instead of unsigned long in WebGLRenderingContext and GraphicsContext3D
https://bugs.webkit.org/show_bug.cgi?id=39855

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::copyTexImage2D): Map GLsizei to long. (WebCore::WebGLRenderingContext::copyTexSubImage2D): Ditto. (WebCore::WebGLRenderingContext::renderbufferStorage): Ditto. (WebCore::WebGLRenderingContext::scissor): Ditto. (WebCore::WebGLRenderingContext::texImage2DBase): Ditto. (WebCore::WebGLRenderingContext::texImage2D): Ditto. (WebCore::WebGLRenderingContext::texSubImage2DBase): Ditto. (WebCore::WebGLRenderingContext::texSubImage2DImpl): Ditto. (WebCore::WebGLRenderingContext::texSubImage2D): Ditto. (WebCore::WebGLRenderingContext::viewport): Ditto. (WebCore::WebGLRenderingContext::validateSize): Check the sizes are non-negative.
  • html/canvas/WebGLRenderingContext.h:
  • html/canvas/WebGLRenderingContext.idl:

2010-12-28 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Map GLsizei to long instead of unsigned long in WebGLRenderingContext and GraphicsContext3D
https://bugs.webkit.org/show_bug.cgi?id=39855

  • fast/canvas/webgl/invalid-passed-params-expected.txt: Add test cases for negative offset/width/height.
  • fast/canvas/webgl/invalid-passed-params.html: Ditto.
12:01 Changeset [74718] by kbr@google.com

2010-12-28 Kenneth Russell <kbr@google.com>

Unreviewed, Chromium test expectations update. Mark
fast/forms/input-text-paste-maxlength.html as a flaky crash on
Linux Release as well as Debug.

  • platform/chromium/test_expectations.txt:
11:36 Changeset [74717] by kbr@google.com

2010-12-28 Kenneth Russell <kbr@google.com>

Unreviewed, Chromium test expectations update.

Marked inspector/styles-source-lines.html as a flaky failure on
Win Debug and
http/tests/inspector/extensions-resources-redirect.html as a flaky
timeout on Win Release.

  • platform/chromium/test_expectations.txt:
11:18 Changeset [74716] by inferno@chromium.org

2010-12-28 Abhishek Arya <inferno@chromium.org>

Reviewed by Kenneth Russell.

Fix crash with invalid font in m_fontList by not drawing text when a custom font is in the
process of loading.
https://bugs.webkit.org/show_bug.cgi?id=51681

Test: canvas/philip/tests/2d.text-custom-font-load-crash.html

  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::drawTextInternal): bail out if a custom font is loading.
  • platform/graphics/Font.cpp: (WebCore::Font::operator==): Replace condition with new function loadingCustomFonts() (WebCore::Font::drawText): Replace condition with new function loadingCustomFonts() (WebCore::Font::drawEmphasisMarks): Replace condition with new function loadingCustomFonts()
  • platform/graphics/Font.h: (WebCore::Font::loadingCustomFonts): new function that returns if a custom font is loading.

2010-12-28 Abhishek Arya <inferno@chromium.org>

Reviewed by Kenneth Russell.

Tests that we do not crash when drawing text during custom font load.
https://bugs.webkit.org/show_bug.cgi?id=51681

  • canvas/philip/tests/2d.text-custom-font-load-crash-expected.txt: Added.
  • canvas/philip/tests/2d.text-custom-font-load-crash.html: Added.
10:55 Changeset [74715] by dglazkov@chromium.org

2010-12-28 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Eric Seidel.

Combine setShadowRoot and clearShadowRoot into a simpler API
https://bugs.webkit.org/show_bug.cgi?id=50971

No change in behavior, and API is not used yet.

  • dom/Element.cpp: (WebCore::Element::setShadowRoot): Combined clearing and setting of

the shadowRoot, also hooked up with setting and clearing of the
corresponding shadowHost values.

  • dom/Element.h: renamed clearShadowRoot to removeShadowRoot and made it

private.

  • dom/Node.h: Made shadow host-related functions public so that

Element::setShadowRoot can access setShadowHost. It seems logical
to make shadowHost public as well to keep the defs together.

10:11 Changeset [74714] by caseq@chromium.org

2010-12-28 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Chromium] Expose extension API to select a node in WebInspector
Do not request content for resources with non-numeric identifiers.
https://bugs.webkit.org/show_bug.cgi?id=49727

Test: http/tests/inspector/extensions-resources-redirect.html

  • inspector/front-end/NetworkManager.js: (WebInspector.NetworkManager.prototype._appendRedirect):

2010-12-28 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Chromium] Expose extension API to select a node in WebInspector
Do not request content for resources with non-numeric identifiers.
https://bugs.webkit.org/show_bug.cgi?id=49727

  • http/tests/inspector/extensions-resources-redirect-expected.txt: Added.
  • http/tests/inspector/extensions-resources-redirect.html: Added.
  • http/tests/inspector/extensions-resources-test.js: Added. (extension_getResourceByUrl.onHAR): (extension_getResourceByUrl):
  • inspector/extensions-resources-expected.txt:
  • inspector/extensions-resources.html:
  • platform/mac-leopard/inspector/extensions-resources-expected.txt:
09:58 Changeset [74713] by loislo@chromium.org

2010-12-28 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed build fix for Qt.

ResourceTreeModel.js was added.

  • inspector/front-end/WebKit.qrc:
09:24 Changeset [74712] by mnaganov@chromium.org

2010-12-28 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Pavel Feldman.

[Chromium] Fix memory leak in Profiles tab concerned with heap profiles views.

https://bugs.webkit.org/show_bug.cgi?id=51680

  • inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype._reset):
07:55 Changeset [74711] by kbr@google.com

2010-12-28 Kenneth Russell <kbr@google.com>

Unreviewed, Chromium test expectations update. Coalesce WebGL
expectations for chromium-gpu platform and fix duplicate
expectation for gl-object-get-calls.html accidentally introduced
on Windows Debug.

  • platform/chromium-gpu/test_expectations.txt:
07:32 Changeset [74710] by apavlov@chromium.org

2010-12-28 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: REGRESSION: Clicking image resource in style sidebar doesn't actually go to resource anymore
https://bugs.webkit.org/show_bug.cgi?id=51663

  • inspector/elements-tests2.js: (initialize_ElementTest.InspectorTest.dumpSelectedElementStyles): Drive-by: remove bad test exit code.
  • inspector/resources/styles-url-linkify-iframe.html: Added.
  • inspector/resources/styles-url-linkify.css: Added. (#local):
  • inspector/styles-url-linkify-expected.txt: Added.
  • inspector/styles-url-linkify.html: Added.

2010-12-28 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: REGRESSION: Clicking image resource in style sidebar doesn't actually go to resource anymore
https://bugs.webkit.org/show_bug.cgi?id=51663

The base URI is now computed correctly for links from CSS property uri(...) values. Additionally,
optional quotes/apostrophes and spaces are now allowed inside uri(...).

Test: inspector/styles-url-linkify.html

  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertyTreeElement.prototype.updateTitle.linkifyURL): (WebInspector.StylePropertyTreeElement.prototype.updateTitle):
07:11 Changeset [74709] by loislo@chromium.org

2010-12-21 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Protocol cleanup task. Introduce Network, DOMStorage and Database domains.

Domain was changed for Resources, FileSystem etc. related methods.
ResourcesManager was renamed to NetworkManager.
ResourceTreeModel was extracted as separate file.
FileSystem, Database, DOMStorage and ApplicationCache methods were
removed from NetworkManager and added to corresponding classes.

https://bugs.webkit.org/show_bug.cgi?id=51334

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/CodeGeneratorInspector.pm:
  • inspector/Inspector.idl:
  • inspector/front-end/AuditRules.js: (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback.selectorsCallback):
  • inspector/front-end/CSSStyleModel.js: (WebInspector.CSSStyleModel.prototype._styleSheetChanged.callback): (WebInspector.CSSStyleModel.prototype._styleSheetChanged):
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.addMessage): (WebInspector.ConsoleView.prototype.clearMessages):
  • inspector/front-end/DOMAgent.js: (WebInspector.ApplicationCache.updateApplicationCacheStatus): (WebInspector.ApplicationCache.updateNetworkState):
  • inspector/front-end/DOMStorage.js: (WebInspector.DOMStorage.addDOMStorage): (WebInspector.DOMStorage.selectDOMStorage): (WebInspector.DOMStorage.updateDOMStorage):
  • inspector/front-end/Database.js: (WebInspector.Database.prototype.executeSql): (WebInspector.Database.addDatabase): (WebInspector.Database.selectDatabase): (WebInspector.Database.sqlTransactionSucceeded): (WebInspector.Database.sqlTransactionFailed):
  • inspector/front-end/FileSystemView.js: (WebInspector.FileSystem.didGetFileSystemPath): (WebInspector.FileSystem.didGetFileSystemError): (WebInspector.FileSystem.didGetFileSystemDisabled):
  • inspector/front-end/NetworkItemView.js: (WebInspector.NetworkItemView):
  • inspector/front-end/NetworkManager.js: Added. (WebInspector.NetworkManager): (WebInspector.NetworkManager.prototype._createResource): (WebInspector.NetworkManager.prototype.identifierForInitialRequest): (WebInspector.NetworkManager.prototype.willSendRequest): (WebInspector.NetworkManager.prototype._updateResourceWithRequest): (WebInspector.NetworkManager.prototype._appendRedirect): (WebInspector.NetworkManager.prototype.markResourceAsCached): (WebInspector.NetworkManager.prototype.didReceiveResponse): (WebInspector.NetworkManager.prototype._updateResourceWithResponse): (WebInspector.NetworkManager.prototype.didReceiveContentLength): (WebInspector.NetworkManager.prototype.didFinishLoading): (WebInspector.NetworkManager.prototype.didFailLoading): (WebInspector.NetworkManager.prototype.didLoadResourceFromMemoryCache): (WebInspector.NetworkManager.prototype._updateResourceWithCachedResource): (WebInspector.NetworkManager.prototype.setInitialContent): (WebInspector.NetworkManager.prototype.didCommitLoadForFrame): (WebInspector.NetworkManager.prototype.frameDetachedFromParent): (WebInspector.NetworkManager.prototype.didCreateWebSocket): (WebInspector.NetworkManager.prototype.willSendWebSocketHandshakeRequest): (WebInspector.NetworkManager.prototype.didReceiveWebSocketHandshakeResponse): (WebInspector.NetworkManager.prototype.didCloseWebSocket): (WebInspector.NetworkManager.prototype._processCachedResources): (WebInspector.NetworkManager.prototype._addFramesRecursively): (WebInspector.NetworkManager.requestContent):
  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype.refreshResource):
  • inspector/front-end/Resource.js: (WebInspector.Resource.prototype._innerRequestContent):
  • inspector/front-end/ResourceManager.js: Removed.
  • inspector/front-end/ResourceTreeModel.js: Added. (WebInspector.ResourceTreeModel): (WebInspector.ResourceTreeModel.prototype.addOrUpdateFrame): (WebInspector.ResourceTreeModel.prototype.didCommitLoadForFrame): (WebInspector.ResourceTreeModel.prototype.frameDetachedFromParent): (WebInspector.ResourceTreeModel.prototype._clearChildFramesAndResources): (WebInspector.ResourceTreeModel.prototype.addResourceToFrame): (WebInspector.ResourceTreeModel.prototype._clearResources): (WebInspector.ResourceTreeModel.prototype.forAllResources): (WebInspector.ResourceTreeModel.prototype.addConsoleMessage): (WebInspector.ResourceTreeModel.prototype.clearConsoleMessages): (WebInspector.ResourceTreeModel.prototype._callForFrameResources): (WebInspector.ResourceTreeModel.prototype.resourceForURL): (WebInspector.ResourceTreeModel.prototype.bindResourceURL): (WebInspector.ResourceTreeModel.prototype._unbindResourceURL): (WebInspector.ResourceTreeModel.createResource):
  • inspector/front-end/ResourceView.js: (WebInspector.ResourceView.createResourceView): (WebInspector.ResourceView.resourceViewTypeMatchesResource): (WebInspector.ResourceView.resourceViewForResource): (WebInspector.ResourceView.recreateResourceView): (WebInspector.ResourceView.existingResourceViewForResource):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.canShowSourceLine): (WebInspector.ResourcesPanel.prototype.showSourceLine): (WebInspector.ResourcesPanel.prototype.showResource): (WebInspector.ResourcesPanel.prototype.get searchableViews.callback): (WebInspector.ResourcesPanel.prototype.get searchableViews): (WebInspector.FrameResourceTreeElement.prototype._errorsWarningsUpdated): (WebInspector.FrameResourceTreeElement.prototype._contentChanged):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._addScript): (WebInspector.ScriptsPanel.prototype.reset): (WebInspector.ScriptsPanel.prototype._sourceFrameForResource): (WebInspector.ScriptsPanel.prototype._showScriptOrResource):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js: (WebInspector.forAllResources): (WebInspector.resourceForURL):

12/27/10:

21:33 Changeset [74708] by commit-queue@webkit.org

2010-12-27 Helder Correia <helder@sencha.com>

Reviewed by Ariya Hidayat.

ContextShadow should use AffineTransform instead of TransformationMatrix
https://bugs.webkit.org/show_bug.cgi?id=51661

ContextShadow needs the CTM to make sure shadows are not affected by
transformations when drawing on a canvas. AffineTransform is sufficient
in this case.

Existing tests: fast/canvas/canvas*shadow*html

  • platform/graphics/ContextShadow.cpp: (WebCore::ContextShadow::mustUseContextShadow): (WebCore::ContextShadow::adjustBlurDistance): (WebCore::ContextShadow::calculateLayerBoundingRect):
  • platform/graphics/ContextShadow.h:
  • platform/graphics/cairo/ContextShadowCairo.cpp: (WebCore::ContextShadow::getTransformationMatrixFromContext):
  • platform/graphics/qt/ContextShadowQt.cpp: (WebCore::ContextShadow::getTransformationMatrixFromContext):
21:15 Changeset [74707] by commit-queue@webkit.org

2010-12-27 Ryuan Choi <ryuan.choi@samsung.com>

Reviewed by David Levin.

[EFL] Change path of eflsymbols.filter
https://bugs.webkit.org/show_bug.cgi?id=51659

  • Sources/cmake/OptionsEfl.cmake:
18:05 Changeset [74706] by dbates@webkit.org

2010-12-27 Daniel Bates <dbates@rim.com>

Rubber-stamped by Martin Robinson.

Append the directory Tools/DumpRenderTree to the list of directories that
do-webcore-rename should search so that it can rename DRT files and
source code.

  • Scripts/do-webcore-rename:
17:40 Changeset [74705] by mrobinson@webkit.org

2010-12-27 Martin Robinson <mrobinson@igalia.com>

Reviewed by Daniel Bates.

Try to fix my previous commit for Mac by stepping up the precision of pi even more
using Math.PI.

  • fast/canvas/canvas-save-restore-with-path.js: Use Math.PI instead of a hard-coded estimation.
17:39 Changeset [74704] by weinig@apple.com

WebKit2 snapshots should contain accelerated content
<rdar://problem/8807393>
https://bugs.webkit.org/show_bug.cgi?id=51660

Reviewed by Anders Carlsson.

When creating a snapshot, flatten the layer tree for painting so that
accelerated content is included in the snapshot.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::snapshotInViewCoordinates):
(WebKit::WebPage::snapshotInDocumentCoordinates):

17:03 Changeset [74703] by dbates@webkit.org

2010-12-27 Daniel Bates <dbates@rim.com>

Attempt to fix the WebKit2 Windows build after changeset 74698
<http://trac.webkit.org/changeset/74698> (bug #51656).

Add "..\Shared\API\c\WKImage.h" to WebKit2Generated.make.

  • win/WebKit2Generated.make:
16:50 Changeset [74702] by kbr@google.com

2010-12-27 Kenneth Russell <kbr@google.com>

Unreviewed, Chromium test expectations update. Generalize
suppressions for Chromium bugs 67732 and 67139 to cover Linux
Debug.

  • platform/chromium/test_expectations.txt:
16:44 Changeset [74701] by dbates@webkit.org

2010-12-27 Daniel Bates <dbates@rim.com>

Fix the first sentence of the change log message for changeset 74700
<http://trac.webkit.org/changeset/74700> (bug #51634).

As pointed out by Dan Bernstein, it should read: "Rename HTMLFrameElementBase::getMarginWidth()
and HTMLFrameElementBase::getMarginHeight() to HTMLFrameElementBase::marginWidth() and
HTMLFrameElementBase::marginHeight(), respectively."

16:21 Changeset [74700] by dbates@webkit.org

2010-12-27 Daniel Bates <dbates@rim.com>

Reviewed by Antonio Gomes.

Clean up: Rename HTMLFrameElementBase::getMarginWidth() and HTMLFrameElementBase::getMarginHeight()
https://bugs.webkit.org/show_bug.cgi?id=51634

Rename HTMLFrameElementBase::getMarginWidth() and HTMLFrameElementBase::getMarginHeight()
to HTMLFrameElementBase::marginHeight() and HTMLFrameElementBase::marginHeight(), respectively.
This will make the names of these getters consistent with the naming convention we use for
getters.

  • html/HTMLBodyElement.cpp: (WebCore::HTMLBodyElement::insertedIntoDocument):
  • html/HTMLFrameElementBase.h: (WebCore::HTMLFrameElementBase::marginWidth): Renamed; Formerly getMarginWidth(). (WebCore::HTMLFrameElementBase::marginHeight): Renamed; Formerly getMarginHeight().
  • loader/SubframeLoader.cpp: (WebCore::SubframeLoader::loadSubframe):
  • page/FrameView.cpp: (WebCore::FrameView::init):
  • rendering/RenderEmbeddedObject.cpp: (WebCore::RenderEmbeddedObject::viewCleared): Also renamed variables marginw and marginh to marginWidth and marginHeight, respectively. This makes the names of these variables consistent with the names of similar variables in SubframeLoader::loadSubframe() and FrameView::init().
  • rendering/RenderFrame.cpp: (WebCore::RenderFrame::viewCleared): Ditto.
16:17 Changeset [74699] by mrobinson@webkit.org

2010-12-27 Martin Robinson <mrobinson@igalia.com>

Reviewed by Daniel Bates.

[Cairo] fast/canvas/canvas-save-restore-with-path.html fails with some versions of Cairo
https://bugs.webkit.org/show_bug.cgi?id=51655

Increase the precision of pi used in this test case. It appears that
some Cairo versions or processors are sensitive to rounding errors here.

  • fast/canvas/canvas-save-restore-with-path.js: Increase pi precision.
16:01 Changeset [74698] by weinig@apple.com

WebKit2: Add API for getting snapshots
https://bugs.webkit.org/show_bug.cgi?id=51656

Reviewed by Anders Carlsson.

  • Shared/API/c/WKBase.h:
  • Shared/API/c/WKImage.cpp: Added.

(WKImageGetTypeID):
(WKImageCreate):
(WKImageGetSize):

  • Shared/API/c/WKImage.h: Added.
  • Shared/WebImage.cpp: Added.

(WebKit::WebImage::create):
(WebKit::WebImage::size):

  • Shared/WebImage.h: Added.

(WebKit::WebImage::backingStore):
(WebKit::WebImage::WebImage):
(WebKit::WebImage::type):
Add a general purpose API image class.

  • Shared/API/c/cg: Added.
  • Shared/API/c/cg/WKImageCG.cpp: Added.

(WKImageCreateCGImage):

  • Shared/API/c/cg/WKImageCG.h: Added.

Add function to convert a WKImageRef to a CGImageRef for platforms that use CG.

  • Shared/API/c/WKSharedAPICast.h:

(WebKit::toFloatRect):
(WebKit::toIntSize):
(WebKit::toIntPoint):
(WebKit::toIntRect):
(WebKit::toImageOptions):
Make conversion functions that are ambiguous more explicit.

  • Shared/APIObject.h:
  • Shared/BackingStore.h:

(WebKit::BackingStore::isBackedBySharedMemory):

  • Shared/ImageOptions.h: Added.
  • Shared/UserMessageCoders.h:

(WebKit::UserMessageEncoder::baseEncode):
(WebKit::UserMessageDecoder::baseDecode):
Allow a WKImageRef to be passed in user messages. Right now, it only
works if the image is sharable.

  • UIProcess/API/C/WKPage.cpp:

(WKPageScaleWebView):

  • UIProcess/WebUIClient.cpp:

(WebKit::WebUIClient::windowFrame):
Use the more explicit conversion function name.

  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageCreateSnapshotInViewCoordinates):
(WKBundlePageCreateSnapshotInDocumentCoordinates):

  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/InjectedBundle/API/c/WKBundlePageOverlay.cpp:

(WKBundlePageOverlaySetNeedsDisplay):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::snapshotInViewCoordinates):
(WebKit::WebPage::snapshotInDocumentCoordinates):
Add function to take the snapshot.

  • WebProcess/WebPage/WebPage.h:
  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:

Add new files.

14:48 Changeset [74697] by mrobinson@webkit.org

2010-12-27 Martin Robinson <mrobinson@igalia.com>

Reviewed by Ryosuke Niwa.

[GTK] EditorClient::generateEditorCommands queues up "null string" commands
https://bugs.webkit.org/show_bug.cgi?id=51569

Prevent adding "null string" editor commands by first checking whether or not
the command string is null in generateEditorCommands before appending it to the
list of pending editor command strings.

  • WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::generateEditorCommands): Check for the null string (no command for this key combination) before appending a command string to the list of pending editor commands. (WebKit::EditorClient::executePendingEditorCommands): Add an ASSERT which detects null command strings.
14:37 Changeset [74696] by mrobinson@webkit.org

2010-12-27 Martin Robinson <mrobinson@igalia.com>

Reviewed by Daniel Bates.

[GTK] RenderThemeGtk::m_HScale and RenderThemeGtk::m_VScale are not initialized
https://bugs.webkit.org/show_bug.cgi?id=51654

Properly initialize slider members of RenderThemeGtk. This can lead to test crashes
on some debug configurations.

No new tests. This is already covered by current slider tests. It isn't crashing on
the bots, but it does crash locally.

  • platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::RenderThemeGtk): Properly initialize members.
13:41 Changeset [74695] by darin@apple.com

2010-12-27 Jake Helfert <jake@jakeonthenet.com>

Reviewed and reworked by Darin Adler.

Building WebKit with Visual Studio 2010 fails due
to ambiguous assignment operator errors.
https://bugs.webkit.org/show_bug.cgi?id=51116

  • wtf/NullPtr.h: Added a HAVE(NULLPTR) definition for use with Platform.h HAVE macro, and included the Visual Studio 2010 compiler as one of the ones that has nullptr.
  • wtf/NullPtr.cpp: Updated condition to match.


  • wtf/PassOwnArrayPtr.h: Don't include the operator=(nullptr_t) overload if we are compiling in loose mode and the compiler has nullptr, because assignment of 0 will otherwise encounter ambiguitity with this overload and the overload for loose mode that takes a raw pointer. The conditional can be removed when we get rid of loose mode.
  • wtf/PassOwnPtr.h: Ditto.
  • wtf/PassRefPtr.h: Don't include the operator=(nullptr_t) overload if the compiler has nullptr, because assignment of 0 would be ambiguous with the overload that takes a raw pointer. The conditional can be removed if we ever decide we no longer need to support assigning 0, but might need a way to catch that usage on older compilers.
  • wtf/RefPtr.h: Ditto.
  • wtf/RetainPtr.h: Ditto
  • JavaScriptCore.xcodeproj/project.pbxproj: Added NullPtr.cpp, accidentally omitted when the file was first added.
13:13 Changeset [74694] by eric@webkit.org

2010-12-27 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

build-webkit should detect missing Java SDK and explain how to install it
https://bugs.webkit.org/show_bug.cgi?id=51651

  • Scripts/build-webkit:
13:04 Changeset [74693] by weinig@apple.com

WebKit2: Add additional API for managing databases
https://bugs.webkit.org/show_bug.cgi?id=51629

Reviewed by Anders Carlsson.

  • Adds client for the database manager to get notifications of changes to databases.
  • UIProcess/API/C/WKDatabaseManager.cpp:

(WKDatabaseManagerSetClient):

  • UIProcess/API/C/WKDatabaseManager.h:
  • UIProcess/WebDatabaseManagerProxy.cpp:

(WebKit::WebDatabaseManagerProxy::initializeClient):
(WebKit::WebDatabaseManagerProxy::didModifyOrigin):
(WebKit::WebDatabaseManagerProxy::didModifyDatabase):

  • UIProcess/WebDatabaseManagerProxy.h:
  • UIProcess/WebDatabaseManagerProxy.messages.in:
  • UIProcess/WebDatabaseManagerProxyClient.cpp: Added.

(WebKit::WebDatabaseManagerProxyClient::didModifyOrigin):
(WebKit::WebDatabaseManagerProxyClient::didModifyDatabase):

  • UIProcess/WebDatabaseManagerProxyClient.h: Added.
  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebCoreSupport/WebDatabaseManager.cpp:

(WebKit::WebDatabaseManager::WebDatabaseManager):
(WebKit::WebDatabaseManager::~WebDatabaseManager):
(WebKit::WebDatabaseManager::dispatchDidModifyOrigin):
(WebKit::WebDatabaseManager::dispatchDidModifyDatabase):

  • WebProcess/WebCoreSupport/WebDatabaseManager.h:
  • win/WebKit2.vcproj:
11:41 Changeset [74692] by weinig@apple.com

Fix Makefile based build.

11:21 Changeset [74691] by xan@webkit.org

2010-12-27 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

Remove unneeded includes from our headers.

  • WebCoreSupport/PasteboardHelperGtk.h: ditto.
  • webkit/webkitprivate.h: ditto.
  • webkit/webkitsoupauthdialog.h: ditto.
11:17 Changeset [74690] by weinig@apple.com

WebKit2: Add additional API for managing databases
https://bugs.webkit.org/show_bug.cgi?id=51629

Reviewed by Anders Carlsson.

  • Adds WKDatabaseManagerGetDatabasesByOrigin, which asynchronously returns an array of dictionaries containing details about each origin using databases and details about each database. Keys were added for accessing the data in the dictionaries.
  • Adds WKDatabaseManagerDeleteDatabasesWithNameForOrigin to delete a database with a specific identifier.
  • Adds WKDatabaseManagerSetQuotaForOrigin to set the quota for an origin.
  • Shared/OriginAndDatabases.cpp: Added.

(WebKit::OriginAndDatabases::encode):
(WebKit::OriginAndDatabases::decode):

  • Shared/OriginAndDatabases.h: Added.
  • Shared/WebCoreArgumentCoders.h:
  • UIProcess/API/C/WKDatabaseManager.cpp:

(WKDatabaseManagerGetOriginKey):
(WKDatabaseManagerGetOriginQuotaKey):
(WKDatabaseManagerGetOriginUsageKey):
(WKDatabaseManagerGetDatabaseDetailsKey):
(WKDatabaseManagerGetDatabaseDetailsNameKey):
(WKDatabaseManagerGetDatabaseDetailsDisplayNameKey):
(WKDatabaseManagerGetDatabaseDetailsExpectedUsageKey):
(WKDatabaseManagerGetDatabaseDetailsCurrentUsageKey):
(WKDatabaseManagerGetDatabasesByOrigin):
(callGetDatabasesByOriginBlockAndDispose):
(WKDatabaseManagerGetDatabasesByOrigin_b):
(WKDatabaseManagerGetDatabaseOrigins):
(callGetDatabaseOriginsBlockBlockAndDispose):
(WKDatabaseManagerGetDatabaseOrigins_b):
(WKDatabaseManagerDeleteDatabasesWithNameForOrigin):
(WKDatabaseManagerDeleteDatabasesForOrigin):
(WKDatabaseManagerDeleteAllDatabases):
(WKDatabaseManagerSetQuotaForOrigin):

  • UIProcess/API/C/WKDatabaseManager.h:
  • UIProcess/WebDatabaseManagerProxy.cpp:

(WebKit::WebDatabaseManagerProxy::originKey):
(WebKit::WebDatabaseManagerProxy::originQuotaKey):
(WebKit::WebDatabaseManagerProxy::originUsageKey):
(WebKit::WebDatabaseManagerProxy::databaseDetailsKey):
(WebKit::WebDatabaseManagerProxy::databaseDetailsNameKey):
(WebKit::WebDatabaseManagerProxy::databaseDetailsDisplayNameKey):
(WebKit::WebDatabaseManagerProxy::databaseDetailsExpectedUsageKey):
(WebKit::WebDatabaseManagerProxy::databaseDetailsCurrentUsageKey):
(WebKit::WebDatabaseManagerProxy::invalidate):
(WebKit::WebDatabaseManagerProxy::getDatabasesByOrigin):
(WebKit::WebDatabaseManagerProxy::didGetDatabasesByOrigin):
(WebKit::WebDatabaseManagerProxy::getDatabaseOrigins):
(WebKit::WebDatabaseManagerProxy::didGetDatabaseOrigins):
(WebKit::WebDatabaseManagerProxy::deleteDatabaseWithNameForOrigin):
(WebKit::WebDatabaseManagerProxy::deleteDatabasesForOrigin):
(WebKit::WebDatabaseManagerProxy::setQuotaForOrigin):

  • UIProcess/WebDatabaseManagerProxy.h:
  • UIProcess/WebDatabaseManagerProxy.messages.in:
  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebCoreSupport/WebDatabaseManager.cpp:

(WebKit::WebDatabaseManager::getDatabasesByOrigin):
(WebKit::WebDatabaseManager::deleteDatabaseWithNameForOrigin):
(WebKit::WebDatabaseManager::setQuotaForOrigin):

  • WebProcess/WebCoreSupport/WebDatabaseManager.h:
  • WebProcess/WebCoreSupport/WebDatabaseManager.messages.in:
  • win/WebKit2.vcproj:
11:07 Changeset [74689] by mrobinson@webkit.org

2010-12-26 Martin Robinson <mrobinson@igalia.com>

Reviewed by Daniel Bates.

[GTK] Add support for build-jsc
https://bugs.webkit.org/show_bug.cgi?id=51625

Add GTK+ support to build-jsc now that building the jsc executable as
a standalone target is easy.

  • Scripts/build-jsc: Call buildGtkProject for the GTK+ case now.
  • Scripts/build-webkit: Pass in the proper target name to buildGtkProject.
  • Scripts/webkitdirs.pm: Actually process the project parameter in buildGtkProject and pass it along to buildAutotoolsProject.
10:50 Changeset [74688] by levin@chromium.org

check-webkit-style check for meaningless variable names in function declarations.
https://bugs.webkit.org/show_bug.cgi?id=51523

Reviewed by Eric Seidel.

  • Scripts/webkitpy/style/checker.py: Exempted JavaScriptCore/jit/JITStubs.cpp

from the new check and whitespace/parens because the syntax is unusual and
produced a fair number of positives for these checks.

  • Scripts/webkitpy/style/checkers/cpp.py:

(_convert_to_lower_with_underscores): Used as a canonical form for type names
and parameter names when determining if the parameter name is useless.
(_create_acronym): Used to check for redundant variable names in cases like "ExceptionCode ec"
(Parameter.lower_with_underscores_name): Gives back the parameter name in a lower_with_underscore
format.
(_check_parameter_name_against_text): Checks to see if the parameter name is in the
text or an acronym of it.
(check_function_definition): Checks function definitions for meaningless variable names.
(process_line): Added call to check_function_definition.

  • Scripts/webkitpy/style/checkers/cpp_unittest.py:

(CppFunctionsTest.test_convert_to_lower_with_underscores): Test for _convert_to_lower_with_underscores.
(CppFunctionsTest.test_create_acronym): Test for _create_acronym.
(CppFunctionsTest.test_check_parameter_against_text): Test for _check_parameter_against_text.
(CppStyleTestBase.perform_single_line_lint): Removed the parameter name check
because when only checking a snippet, there are a lot of bogus functions.
(CppStyleTestBase.perform_multi_line_lint): Ditto and removed a bogus filter
that I put there previously and just noticed.
(WebKitStyleTest.test_parameter_names): Tests for the functionality -- both
check_function_definition and process_line.

10:46 Changeset [74687] by commit-queue@webkit.org

2010-12-27 Kenji Imasaki <imasaki@chromium.org>

Reviewed by David Levin.

remove entries for media related non-flaky tests.
https://bugs.webkit.org/show_bug.cgi?id=51225

  • platform/chromium/test_expectations.txt:
09:41 Changeset [74686] by antonm@chromium.org

2010-12-27 Anton Muhin <antonm@chromium.org>

Reviewed by David Levin.

[v8] Remove unused methods to protect/unprotect wrappers during garbage collection
https://bugs.webkit.org/show_bug.cgi?id=51648

  • bindings/v8/ScriptController.cpp:
  • bindings/v8/ScriptController.h:
  • bindings/v8/V8GCController.cpp: (WebCore::V8GCController::gcEpilogue):
  • bindings/v8/V8GCController.h:
09:37 Changeset [74685] by commit-queue@webkit.org

2010-12-27 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Disable flash plugin in GtkLauncher when using gtk3
https://bugs.webkit.org/show_bug.cgi?id=51591

Flash plugin uses gtk2 that is incompatible with gtk3 making
webkit crash when it's built with gtk3.

  • GtkLauncher/main.c: (main):
09:10 Changeset [74684] by commit-queue@webkit.org

2010-12-27 Rafael Antognolli <antognolli@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Set the frame smart object base clipper to non-static.
https://bugs.webkit.org/show_bug.cgi?id=51552

The base clipper of the clipped smart object, which is the parent
class of the ewk_frame class is a static clipper. It's normally only
used for showing/hiding the object, but in the case of the ewk_frame,
it needs to clip the object to its dimension, in order to clip
scrollbars of inner frames.

Setting it to non-static makes the clipper to be automatically moved
by the parent class, thus staying on the correct position when the
frame is moved.

This change needed to be done after the adoption of the static clipper
on the clipped smart base class.

  • ewk/ewk_frame.cpp: (_ewk_frame_smart_add):
06:51 Changeset [74683] by yurys@chromium.org

2010-12-27 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Removed trailing spaces from a localized
string to make it the same as the one used in the code.

  • English.lproj/localizedStrings.js:
06:36 Changeset [74682] by philn@webkit.org

2010-12-27 Philippe Normand <pnormand@igalia.com>

Unreviewed, skip another GTK media test reporting wrong duration,
see bug 51602.

  • platform/gtk/Skipped:
06:10 Changeset [74681] by yael.aharon@nokia.com

2010-12-27 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Eric Seidel.

Browser is failing 16 baseline test from Selector API Test Suite
https://bugs.webkit.org/show_bug.cgi?id=42968

Update the expected result for the test.

  • fast/dom/SelectorAPI/resig-SelectorsAPI-test-expected.txt:

2010-12-27 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Eric Seidel.

Browser is failing 16 baseline test from Selector API Test Suite
https://bugs.webkit.org/show_bug.cgi?id=42968

Throw an exception if there is no argument to querySelector or
querySelectorAll. This replaces the current behavior of passing the string
"undefined" as the argument.

No new tests, just updating the existing results for
fast/dom/SelectorAPI/resig-SelectorAPI-test.xhtml.

  • dom/Document.idl:
  • dom/DocumentFragment.idl:
  • dom/Element.idl:
03:32 Changeset [74680] by hamaji@chromium.org

2010-12-27 Shinichiro Hamaji <shinichiro.hamaji@gmail.com>

Chromium expectation update.

Suppress fast/canvas/webgl/tex-image-with-format-and-type on linux debug

  • platform/chromium/test_expectations.txt:
00:06 Changeset [74679] by morrita@google.com

2010-12-27 MORITA Hajime <morrita@google.com>

Unreviewed expectation updates.

  • platform/chromium-linux/fast/box-shadow/spread-multiple-normal-expected.checksum: Added.
  • platform/chromium-linux/fast/box-shadow/spread-multiple-normal-expected.png: Added.
  • platform/chromium-win/fast/box-shadow/spread-multiple-normal-expected.checksum: Added.
  • platform/chromium-win/fast/box-shadow/spread-multiple-normal-expected.png: Added.

12/26/10:

23:27 Changeset [74678] by abarth@webkit.org

Fix bug number in previous commit.

23:24 Changeset [74677] by abarth@webkit.org

2010-12-26 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

[Meta] Move source code into Sources
https://bugs.webkit.org/show_bug.cgi?id=51606

  • PrettyPatch/PrettyPatch.rb:
    • Remove reference to non-existant autotools directory.

2010-12-26 Adam Barth <abarth@webkit.org>

Reviewed by Eric Siedel.

[Meta] Move source code into Sources
https://bugs.webkit.org/show_bug.cgi?id=51606

  • .gitignore:
  • GNUmakefile.am:
  • Sources/autotools: Copied from autotools.
  • autogen.sh:
  • autotools: Removed.
  • autotools/acinclude.m4: Removed.
  • autotools/dolt.m4: Removed.
  • autotools/gsettings.m4: Removed.
  • autotools/symbols.filter: Removed.
  • autotools/webkit.m4: Removed.
  • configure.ac:
23:00 Changeset [74676] by abarth@webkit.org

2010-12-26 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Move cmake into Sources
https://bugs.webkit.org/show_bug.cgi?id=51631

  • PrettyPatch/PrettyPatch.rb:

2010-12-26 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Move cmake into Sources
https://bugs.webkit.org/show_bug.cgi?id=51631

  • CMakeLists.txt:
  • Sources/cmake: Copied from cmake.
  • cmake: Removed.
  • cmake/FindCFLite.cmake: Removed.
  • cmake/FindCairo.cmake: Removed.
  • cmake/FindEFL.cmake: Removed.
  • cmake/FindFontconfig.cmake: Removed.
  • cmake/FindFreetype.cmake: Removed.
  • cmake/FindGDK-PixBuf.cmake: Removed.
  • cmake/FindGDK.cmake: Removed.
  • cmake/FindGIO.cmake: Removed.
  • cmake/FindGStreamer-App.cmake: Removed.
  • cmake/FindGStreamer-Base.cmake: Removed.
  • cmake/FindGStreamer-Interfaces.cmake: Removed.
  • cmake/FindGStreamer-Pbutils.cmake: Removed.
  • cmake/FindGStreamer-Plugins-Base.cmake: Removed.
  • cmake/FindGStreamer-Video.cmake: Removed.
  • cmake/FindGStreamer.cmake: Removed.
  • cmake/FindGlib.cmake: Removed.
  • cmake/FindGperf.cmake: Removed.
  • cmake/FindGthread.cmake: Removed.
  • cmake/FindICU.cmake: Removed.
  • cmake/FindLibSoup2.cmake: Removed.
  • cmake/FindLibXlst.cmake: Removed.
  • cmake/FindPango.cmake: Removed.
  • cmake/FindSqlite.cmake: Removed.
  • cmake/LibFindMacros.cmake: Removed.
  • cmake/OptionsCommon.cmake: Removed.
  • cmake/OptionsEfl.cmake: Removed.
  • cmake/OptionsWinCE.cmake: Removed.
  • cmake/OptionsWindows.cmake: Removed.
  • cmake/WebKitEfl.cmake: Removed.
  • cmake/WebKitFS.cmake: Removed.
  • cmake/WebKitFeatures.cmake: Removed.
  • cmake/WebKitHelpers.cmake: Removed.
  • cmake/WebKitMacros.cmake: Removed.
  • cmake/WebKitPackaging.cmake: Removed.
  • cmake/eflsymbols.filter: Removed.
22:11 Changeset [74675] by abarth@webkit.org

2010-12-26 Adam Barth <abarth@webkit.org>

Fix some references to the old location of the WebKit website in git
metadata files.

  • .gitattributes:
21:51 Changeset [74674] by abarth@webkit.org

Move ANGLE to Sources/ThirdParty
https://bugs.webkit.org/show_bug.cgi?id=51605

Reviewed by Eric Seidel.

Actually move ANGLE and update the Makefile.

  • ANGLE: Removed.
  • ANGLE/ANGLE.xcodeproj: Removed.
  • ANGLE/ANGLE.xcodeproj/project.pbxproj: Removed.
  • ANGLE/Configurations: Removed.
  • ANGLE/Configurations/ANGLE.xcconfig: Removed.
  • ANGLE/Configurations/Base.xcconfig: Removed.
  • ANGLE/Configurations/DebugRelease.xcconfig: Removed.
  • ANGLE/Makefile: Removed.
  • ANGLE/include: Removed.
  • ANGLE/include/EGL: Removed.
  • ANGLE/include/EGL/egl.h: Removed.
  • ANGLE/include/EGL/eglext.h: Removed.
  • ANGLE/include/EGL/eglplatform.h: Removed.
  • ANGLE/include/GLES2: Removed.
  • ANGLE/include/GLES2/gl2.h: Removed.
  • ANGLE/include/GLES2/gl2ext.h: Removed.
  • ANGLE/include/GLES2/gl2platform.h: Removed.
  • ANGLE/include/GLSLANG: Removed.
  • ANGLE/include/GLSLANG/ShaderLang.h: Removed.
  • ANGLE/include/KHR: Removed.
  • ANGLE/include/KHR/khrplatform.h: Removed.
  • ANGLE/src: Removed.
  • ANGLE/src/build_angle.xcodeproj: Removed.
  • ANGLE/src/build_angle.xcodeproj/project.pbxproj: Removed.
  • ANGLE/src/common: Removed.
  • ANGLE/src/common/angleutils.h: Removed.
  • ANGLE/src/common/debug.cpp: Removed.
  • ANGLE/src/common/debug.h: Removed.
  • ANGLE/src/compiler: Removed.
  • ANGLE/src/compiler/BaseTypes.h: Removed.
  • ANGLE/src/compiler/CodeGenGLSL.cpp: Removed.
  • ANGLE/src/compiler/CodeGenHLSL.cpp: Removed.
  • ANGLE/src/compiler/Common.h: Removed.
  • ANGLE/src/compiler/ConstantUnion.h: Removed.
  • ANGLE/src/compiler/InfoSink.cpp: Removed.
  • ANGLE/src/compiler/InfoSink.h: Removed.
  • ANGLE/src/compiler/Initialize.cpp: Removed.
  • ANGLE/src/compiler/Initialize.h: Removed.
  • ANGLE/src/compiler/InitializeDll.cpp: Removed.
  • ANGLE/src/compiler/InitializeDll.h: Removed.
  • ANGLE/src/compiler/InitializeGlobals.h: Removed.
  • ANGLE/src/compiler/InitializeParseContext.h: Removed.
  • ANGLE/src/compiler/IntermTraverse.cpp: Removed.
  • ANGLE/src/compiler/Intermediate.cpp: Removed.
  • ANGLE/src/compiler/MMap.h: Removed.
  • ANGLE/src/compiler/OutputGLSL.cpp: Removed.
  • ANGLE/src/compiler/OutputGLSL.h: Removed.
  • ANGLE/src/compiler/OutputHLSL.cpp: Removed.
  • ANGLE/src/compiler/OutputHLSL.h: Removed.
  • ANGLE/src/compiler/ParseHelper.cpp: Removed.
  • ANGLE/src/compiler/ParseHelper.h: Removed.
  • ANGLE/src/compiler/PoolAlloc.cpp: Removed.
  • ANGLE/src/compiler/PoolAlloc.h: Removed.
  • ANGLE/src/compiler/QualifierAlive.cpp: Removed.
  • ANGLE/src/compiler/QualifierAlive.h: Removed.
  • ANGLE/src/compiler/RemoveTree.cpp: Removed.
  • ANGLE/src/compiler/RemoveTree.h: Removed.
  • ANGLE/src/compiler/ShHandle.h: Removed.
  • ANGLE/src/compiler/ShaderLang.cpp: Removed.
  • ANGLE/src/compiler/SymbolTable.cpp: Removed.
  • ANGLE/src/compiler/SymbolTable.h: Removed.
  • ANGLE/src/compiler/TranslatorGLSL.cpp: Removed.
  • ANGLE/src/compiler/TranslatorGLSL.h: Removed.
  • ANGLE/src/compiler/TranslatorHLSL.cpp: Removed.
  • ANGLE/src/compiler/TranslatorHLSL.h: Removed.
  • ANGLE/src/compiler/Types.h: Removed.
  • ANGLE/src/compiler/UnfoldSelect.cpp: Removed.
  • ANGLE/src/compiler/UnfoldSelect.h: Removed.
  • ANGLE/src/compiler/debug.cpp: Removed.
  • ANGLE/src/compiler/debug.h: Removed.
  • ANGLE/src/compiler/glslang.l: Removed.
  • ANGLE/src/compiler/glslang.y: Removed.
  • ANGLE/src/compiler/intermOut.cpp: Removed.
  • ANGLE/src/compiler/intermediate.h: Removed.
  • ANGLE/src/compiler/localintermediate.h: Removed.
  • ANGLE/src/compiler/osinclude.h: Removed.
  • ANGLE/src/compiler/ossource_posix.cpp: Removed.
  • ANGLE/src/compiler/ossource_win.cpp: Removed.
  • ANGLE/src/compiler/parseConst.cpp: Removed.
  • ANGLE/src/compiler/preprocessor: Removed.
  • ANGLE/src/compiler/preprocessor/atom.c: Removed.
  • ANGLE/src/compiler/preprocessor/atom.h: Removed.
  • ANGLE/src/compiler/preprocessor/compile.h: Removed.
  • ANGLE/src/compiler/preprocessor/cpp.c: Removed.
  • ANGLE/src/compiler/preprocessor/cpp.h: Removed.
  • ANGLE/src/compiler/preprocessor/cppstruct.c: Removed.
  • ANGLE/src/compiler/preprocessor/memory.c: Removed.
  • ANGLE/src/compiler/preprocessor/memory.h: Removed.
  • ANGLE/src/compiler/preprocessor/parser.h: Removed.
  • ANGLE/src/compiler/preprocessor/preprocess.h: Removed.
  • ANGLE/src/compiler/preprocessor/scanner.c: Removed.
  • ANGLE/src/compiler/preprocessor/scanner.h: Removed.
  • ANGLE/src/compiler/preprocessor/slglobals.h: Removed.
  • ANGLE/src/compiler/preprocessor/symbols.c: Removed.
  • ANGLE/src/compiler/preprocessor/symbols.h: Removed.
  • ANGLE/src/compiler/preprocessor/tokens.c: Removed.
  • ANGLE/src/compiler/preprocessor/tokens.h: Removed.
  • ANGLE/src/compiler/tools: Removed.
  • ANGLE/src/compiler/unistd.h: Removed.
  • ANGLE/src/libEGL: Removed.
  • ANGLE/src/libEGL/Config.cpp: Removed.
  • ANGLE/src/libEGL/Config.h: Removed.
  • ANGLE/src/libEGL/Display.cpp: Removed.
  • ANGLE/src/libEGL/Display.h: Removed.
  • ANGLE/src/libEGL/Surface.cpp: Removed.
  • ANGLE/src/libEGL/Surface.h: Removed.
  • ANGLE/src/libEGL/libEGL.cpp: Removed.
  • ANGLE/src/libEGL/libEGL.def: Removed.
  • ANGLE/src/libEGL/libEGL.vcproj: Removed.
  • ANGLE/src/libEGL/main.cpp: Removed.
  • ANGLE/src/libEGL/main.h: Removed.
  • ANGLE/src/libGLESv2: Removed.
  • ANGLE/src/libGLESv2/Blit.cpp: Removed.
  • ANGLE/src/libGLESv2/Blit.h: Removed.
  • ANGLE/src/libGLESv2/Buffer.cpp: Removed.
  • ANGLE/src/libGLESv2/Buffer.h: Removed.
  • ANGLE/src/libGLESv2/Context.cpp: Removed.
  • ANGLE/src/libGLESv2/Context.h: Removed.
  • ANGLE/src/libGLESv2/Framebuffer.cpp: Removed.
  • ANGLE/src/libGLESv2/Framebuffer.h: Removed.
  • ANGLE/src/libGLESv2/Program.cpp: Removed.
  • ANGLE/src/libGLESv2/Program.h: Removed.
  • ANGLE/src/libGLESv2/RefCountObject.cpp: Removed.
  • ANGLE/src/libGLESv2/RefCountObject.h: Removed.
  • ANGLE/src/libGLESv2/Renderbuffer.cpp: Removed.
  • ANGLE/src/libGLESv2/Renderbuffer.h: Removed.
  • ANGLE/src/libGLESv2/ResourceManager.cpp: Removed.
  • ANGLE/src/libGLESv2/ResourceManager.h: Removed.
  • ANGLE/src/libGLESv2/Shader.cpp: Removed.
  • ANGLE/src/libGLESv2/Shader.h: Removed.
  • ANGLE/src/libGLESv2/Texture.cpp: Removed.
  • ANGLE/src/libGLESv2/Texture.h: Removed.
  • ANGLE/src/libGLESv2/geometry: Removed.
  • ANGLE/src/libGLESv2/geometry/IndexDataManager.cpp: Removed.
  • ANGLE/src/libGLESv2/geometry/IndexDataManager.h: Removed.
  • ANGLE/src/libGLESv2/geometry/VertexDataManager.cpp: Removed.
  • ANGLE/src/libGLESv2/geometry/VertexDataManager.h: Removed.
  • ANGLE/src/libGLESv2/geometry/backend.cpp: Removed.
  • ANGLE/src/libGLESv2/geometry/backend.h: Removed.
  • ANGLE/src/libGLESv2/geometry/dx9.cpp: Removed.
  • ANGLE/src/libGLESv2/geometry/dx9.h: Removed.
  • ANGLE/src/libGLESv2/geometry/vertexconversion.h: Removed.
  • ANGLE/src/libGLESv2/libGLESv2.cpp: Removed.
  • ANGLE/src/libGLESv2/libGLESv2.def: Removed.
  • ANGLE/src/libGLESv2/libGLESv2.vcproj: Removed.
  • ANGLE/src/libGLESv2/main.cpp: Removed.
  • ANGLE/src/libGLESv2/main.h: Removed.
  • ANGLE/src/libGLESv2/mathutil.h: Removed.
  • ANGLE/src/libGLESv2/utilities.cpp: Removed.
  • ANGLE/src/libGLESv2/utilities.h: Removed.
  • Makefile:
  • Sources/ThirdParty: Added.
  • Sources/ThirdParty/ANGLE: Copied from ANGLE.

Tools:

  • Scripts/build-webkit:
    • Point to the new ANGLE location.
20:42 Changeset [74673] by morrita@google.com

2010-12-26 MORITA Hajime <morrita@google.com>

Reviewed by Dan Bernstein.

For box-shadow, non-primary shadows should have specified radii.
https://bugs.webkit.org/show_bug.cgi?id=51386

  • fast/box-shadow/spread-multiple-normal-expected.txt: Added.
  • fast/box-shadow/spread-multiple-normal.html: Added.
  • fast/box-shadow/spread-multiple-normal-expected.checksum: Added.
  • fast/box-shadow/spread-multiple-normal-expected.png: Added.

2010-12-26 MORITA Hajime <morrita@google.com>

Reviewed by Dan Bernstein.

For box-shadow, non-primary shadows should have specified radii.
https://bugs.webkit.org/show_bug.cgi?id=51386

On paintBoxShadow(), the spread value accidentally accumulated accidentally
during the loop, which should be applied individually for radius of each shadow.
This change makes the radii for rects computed for each shadow.

Test: fast/box-shadow/spread-multiple-normal.html

  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintBoxShadow):
14:13 Changeset [74672] by commit-queue@webkit.org

2010-12-26 Xan Lopez <xlopez@igalia.com>

Reviewed by Eric Seidel.

[GTK] Add standalone target for JSC
https://bugs.webkit.org/show_bug.cgi?id=51607

  • GNUmakefile.am: add convenience target to only build jsc and its dependencies.
14:00 Changeset [74671] by paroga@webkit.org

2010-12-26 Patrick Gansterer <paroga@webkit.org>

Reviewed by Eric Seidel.

Improve output of HTML parser benchmark
https://bugs.webkit.org/show_bug.cgi?id=51611

Calculate and show median, min and max values.

  • benchmarks/parser/html-parser.html:
12:27 Changeset [74670] by levin@chromium.org

2010-12-26 David Levin <levin@chromium.org>

Reviewed by Eric Seidel.

check-webkit-style should be able to parse function declaration parameters.
https://bugs.webkit.org/show_bug.cgi?id=51451

  • Scripts/webkitpy/style/checkers/cpp.py: (Position.init): Holds simple position information (row, column). (Parameter.init): Holds information about a parameter. (SingleLineView.init): Converts multiple lines into a single line for simpler searches. (SingleLineView.convert_column_to_row): Returns the original row given a column. (create_skeleton_parameters): Simplifies a parameter list for easier searching. (find_parameter_name_index): Finds where the parameter name is. (parameter_list): Generates the list of parameters for a function. (_FunctionState.begin): Added information to allow determining the parameters on demand. (_FunctionState.get_parameter_list): Returns a tuple of function parameters. (detect_functions): Improve function detection for operator functions and determine where the parameters end and pass that to _FunctionState.begin.
  • Scripts/webkitpy/style/checkers/cpp_unittest.py: (CppFunctionsTest.test_parameter): Verifies Parameter functionality. (CppFunctionsTest.test_single_line_view): Verifies SingleLineView functionality. (CppFunctionsTest.test_create_skeleton_parameters): Verifies create_skeleton_parameters. (CppFunctionsTest.test_find_parameter_name_index): Verifies find_parameter_name_index. (CppFunctionsTest.test_parameter_list): Does some minimal verification for parameter list. Much more thorough verification is done as part of FunctionDetectionTest.test_parameter_list. (FunctionDetectionTest.perform_function_detection): Added support for verifying the parameters found. (FunctionDetectionTest.test_function_declaration_detection): Added more function detection test to verify that we catch the operator functions. (FunctionDetectionTest.test_ignore_macros): Verify that function detection ignores macros. (FunctionDetectionTest.test_parameter_list): Added tests to verify the parameter parsing. (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_bad_test_doesnt_break): Removed because the error. The test is about the bad function name. Fixing the name makes the test exactly like test_function_length_check_definition_severity1_for_test.
11:41 Changeset [74669] by andersca@apple.com

Rename DrawingAreaMessage and DrawingAreaLegacyMessage and
DrawingAreaProxyMessage to DrawingAreaProxyLegacyMessage.

Reviewed by Dan Bernstein.

  • Platform/CoreIPC/MessageID.h:
  • Shared/CoreIPCSupport/DrawingAreaMessageKinds.h:
  • Shared/CoreIPCSupport/DrawingAreaProxyMessageKinds.h:
  • UIProcess/ChunkedUpdateDrawingAreaProxy.cpp:

(WebKit::ChunkedUpdateDrawingAreaProxy::paint):
(WebKit::ChunkedUpdateDrawingAreaProxy::setPageIsVisible):
(WebKit::ChunkedUpdateDrawingAreaProxy::update):
(WebKit::ChunkedUpdateDrawingAreaProxy::sendSetSize):
(WebKit::ChunkedUpdateDrawingAreaProxy::didReceiveMessage):

  • UIProcess/LayerBackedDrawingAreaProxy.cpp:

(WebKit::LayerBackedDrawingAreaProxy::sizeDidChange):
(WebKit::LayerBackedDrawingAreaProxy::setPageIsVisible):
(WebKit::LayerBackedDrawingAreaProxy::update):
(WebKit::LayerBackedDrawingAreaProxy::didReceiveMessage):
(WebKit::LayerBackedDrawingAreaProxy::didReceiveSyncMessage):

  • UIProcess/TiledDrawingAreaProxy.cpp:

(WebKit::TiledDrawingAreaProxy::sizeDidChange):
(WebKit::TiledDrawingAreaProxy::setPageIsVisible):
(WebKit::TiledDrawingAreaProxy::didReceiveMessage):
(WebKit::TiledDrawingAreaProxy::requestTileUpdate):
(WebKit::TiledDrawingAreaProxy::waitUntilUpdatesComplete):
(WebKit::TiledDrawingAreaProxy::takeSnapshot):
(WebKit::TiledDrawingAreaProxy::removeTile):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didReceiveMessage):
(WebKit::WebPageProxy::didReceiveSyncMessage):

  • WebProcess/WebPage/ChunkedUpdateDrawingArea.cpp:

(WebKit::ChunkedUpdateDrawingArea::display):
(WebKit::ChunkedUpdateDrawingArea::setSize):
(WebKit::ChunkedUpdateDrawingArea::didReceiveMessage):

  • WebProcess/WebPage/LayerBackedDrawingArea.cpp:

(WebKit::LayerBackedDrawingArea::setSize):
(WebKit::LayerBackedDrawingArea::didReceiveMessage):

  • WebProcess/WebPage/TiledDrawingArea.cpp:

(WebKit::TiledDrawingArea::display):
(WebKit::TiledDrawingArea::setSize):
(WebKit::TiledDrawingArea::updateTile):
(WebKit::TiledDrawingArea::tileUpdateTimerFired):
(WebKit::TiledDrawingArea::didReceiveMessage):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::didReceiveMessage):

  • WebProcess/WebPage/mac/LayerBackedDrawingAreaMac.mm:

(WebKit::LayerBackedDrawingArea::attachCompositingContext):

11:26 Changeset [74668] by andersca@apple.com

Drawing area cleanup. Remove a bunch of redundant functions that just ended
up calling setNeedsDisplay.

Reviewed by Sam Weinig.

  • UIProcess/DrawingAreaProxy.h:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::invalidateWindow):
(WebKit::WebChromeClient::invalidateContentsAndWindow):
(WebKit::WebChromeClient::invalidateContentsForSlowScroll):

  • WebProcess/WebPage/ChunkedUpdateDrawingArea.cpp:
  • WebProcess/WebPage/ChunkedUpdateDrawingArea.h:
  • WebProcess/WebPage/DrawingArea.h:
  • WebProcess/WebPage/LayerBackedDrawingArea.cpp:
  • WebProcess/WebPage/LayerBackedDrawingArea.h:
  • WebProcess/WebPage/TiledDrawingArea.cpp:
  • WebProcess/WebPage/TiledDrawingArea.h:
08:57 Changeset [74667] by kbr@google.com

2010-12-26 Kenneth Russell <kbr@google.com>

Unreviewed, Chromium expectations fix. Fix broken (duplicate)
expectations for
canvas/philip/tests/2d.gradient.radial.cone.top.html.

  • platform/chromium/test_expectations.txt:
08:04 Changeset [74666] by inferno@chromium.org

2010-12-26 Abhishek Arya <inferno@chromium.org>

Reviewed by Simon Fraser.

Remove the bad assert in paintPaginatedChildLayer, hitTestPaginatedChildLayer.
https://bugs.webkit.org/show_bug.cgi?id=48772

Test: fast/multicol/renderer-positioned-assert-crash.html

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintPaginatedChildLayer): (WebCore::RenderLayer::hitTestPaginatedChildLayer):

2010-12-26 Abhishek Arya <inferno@chromium.org>

Reviewed by Simon Fraser.

Tests passes if it does not crash.
https://bugs.webkit.org/show_bug.cgi?id=48772

  • fast/multicol/renderer-positioned-assert-crash-expected.txt: Added.
  • fast/multicol/renderer-positioned-assert-crash.html: Added.
02:04 Changeset [74665] by paroga@webkit.org

2010-12-26 Patrick Gansterer <paroga@webkit.org>

Unreviewed WinCE buildfix after r74626.

  • cmake/OptionsWinCE.cmake:

12/25/10:

21:05 Changeset [74664] by kbr@google.com

2010-12-25 Kenneth Russell <kbr@google.com>

Unreviewed, Chromium test expectations update.

  • platform/chromium-gpu/test_expectations.txt: Win Debug: Marked compositing/tiling/huge-layer-img.html as TIMEOUT. Marked fast/canvas/webgl/gl-object-get-calls.html as a flaky crash.
  • platform/chromium/test_expectations.txt: Adjusted expectations for the following tests: fast/canvas/shadow-offset-7.html svg/batik/paints/gradientLimit.svg fast/events/touch/touch-target.html canvas/philip/tests/2d.gradient.radial.cone.top.html fast/css/box-shadow.html
17:49 Changeset [74663] by commit-queue@webkit.org

2010-12-25 Peter Rybin <peter.rybin@gmail.com>

Reviewed by Adam Barth.

Adds currentColumn (and currentLine) to SegmentedString. Switches
HTMLTreeBuilder to HTMLDocumentParser::textPosition when it
needs position for a <script> tag.

SegmentedString should provide column position
https://bugs.webkit.org/show_bug.cgi?id=51311

  • html/parser/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::HTMLDocumentParser): (WebCore::HTMLDocumentParser::textPosition):
  • html/parser/HTMLInputStream.h: (WebCore::HTMLInputStream::current): (WebCore::InsertionPointRecord::InsertionPointRecord): (WebCore::InsertionPointRecord::~InsertionPointRecord):
  • html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::HTMLTreeBuilder): (WebCore::HTMLTreeBuilder::processScriptStartTag):
  • html/parser/HTMLTreeBuilder.h: (WebCore::HTMLTreeBuilder::create):
  • platform/text/SegmentedString.cpp: (WebCore::SegmentedString::operator=): (WebCore::SegmentedString::numberOfCharactersConsumedSlow): (WebCore::SegmentedString::advanceSlowCase): (WebCore::SegmentedString::currentLine): (WebCore::SegmentedString::currentColumn): (WebCore::SegmentedString::setCurrentPosition):
  • platform/text/SegmentedString.h: (WebCore::SegmentedString::SegmentedString): (WebCore::SegmentedString::advancePastNewline): (WebCore::SegmentedString::advance): (WebCore::SegmentedString::numberOfCharactersConsumed):
16:38 Changeset [74662] by commit-queue@webkit.org

2010-12-25 Andreas Kling <kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

GraphicsContext: Don't pass StrokeStyle (enum) as const reference
https://bugs.webkit.org/show_bug.cgi?id=51608

  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::setStrokeStyle): (WebCore::GraphicsContext::setPlatformStrokeStyle): (WebCore::GraphicsContext::adjustLineToPixelBoundaries):
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::setPlatformStrokeStyle):
  • platform/graphics/haiku/GraphicsContextHaiku.cpp: (WebCore::GraphicsContext::setPlatformStrokeStyle):
  • platform/graphics/openvg/GraphicsContextOpenVG.cpp: (WebCore::GraphicsContext::setPlatformStrokeStyle):
  • platform/graphics/openvg/PainterOpenVG.cpp: (WebCore::PainterOpenVG::setStrokeStyle):
  • platform/graphics/openvg/PainterOpenVG.h:
  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::setPlatformStrokeStyle):
  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::setPlatformStrokeStyle):
12:53 Changeset [74661] by weinig@apple.com

Fill in some more preferences for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=51610

Reviewed by Dan Bernstein.

  • Shared/WebPreferencesStore.h:
  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetAuthorAndUserStylesEnabled):
(WKPreferencesGetAuthorAndUserStylesEnabled):
(WKPreferencesSetWebArchiveDebugModeEnabled):
(WKPreferencesGetWebArchiveDebugModeEnabled):
(WKPreferencesSetLocalFileContentSniffingEnabled):
(WKPreferencesGetLocalFileContentSniffingEnabled):
(WKPreferencesSetPageCacheEnabled):
(WKPreferencesGetPageCacheEnabled):
(WKPreferencesSetPaginateDuringLayoutEnabled):
(WKPreferencesGetPaginateDuringLayoutEnabled):
(WKPreferencesSetDOMPasteAllowedEnabled):
(WKPreferencesGetDOMPasteAllowedEnabled):

  • UIProcess/API/C/WKPreferences.h:
  • UIProcess/API/C/WKPreferencesPrivate.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):
Pipe through some more preferences.

12:21 Changeset [74660] by paroga@webkit.org

2010-12-25 Patrick Gansterer <paroga@webkit.org>

Unreviewed WinCE buildfix after r74334.

  • CMakeListsWinCE.txt:
01:52 Changeset [74659] by philn@webkit.org

2010-12-25 Philippe Normand <pnormand@igalia.com>

Unreviewed, skip another GTK media test reporting wrong duration,
see bug 50518.

  • platform/gtk/Skipped:

12/24/10:

22:00 Changeset [74658] by kbr@google.com

2010-12-24 Kenneth Russell <kbr@google.com>

Unreviewed, Chromium test expectations update.
svg/batik/paints/gradientLimit.svg fails on Linux Debug as well.

  • platform/chromium/test_expectations.txt:
17:52 Changeset [74657] by mitz@apple.com

REGRESSION (r74648): XHR layout test failures
https://bugs.webkit.org/show_bug.cgi?id=51603

Reviewed by Alexey Proskuryakov.

Reverted r74648.

WebCore:

  • WebCore.exp.in:

WebKit2:

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didReceiveAuthenticationChallenge):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::shouldUseCredentialStorage):

  • WebProcess/mac/WebProcessMainMac.mm:

(WebKit::WebProcessMain):

14:33 Changeset [74656] by philn@webkit.org

2010-12-24 Philippe Normand <pnormand@igalia.com>

Unreviewed, skip failing media test on GTK.

  • platform/gtk/Skipped: Skip media/controls-after-reload.html.
13:43 Changeset [74655] by philn@webkit.org

2010-12-24 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r74632.
http://trac.webkit.org/changeset/74632
https://bugs.webkit.org/show_bug.cgi?id=51600

makes test-webkitpy hang forever on GTK (Requested by philn-tp
on #webkit).

  • Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
  • Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
13:26 Changeset [74654] by simon.fraser@apple.com

2010-12-24 Simon Fraser <simon.fraser@apple.com>

Fix the Qt build after r74650.

  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
13:24 Changeset [74653] by andreip@google.com

2010-12-24 Andrei Popescu <andreip@google.com>

Unreviewed, build fix.

[Chromium] http/tests/xmlhttprequest/basic-auth-nopassword.html needs Mac, Windows and Linux specific test expectations
https://bugs.webkit.org/show_bug.cgi?id=51589

  • platform/chromium-win/http/tests/xmlhttprequest/basic-auth-nopassword-expected.txt: Added.
  • platform/chromium-win/http/tests/xmlhttprequest/basic-auth-nouser-expected.txt: Added.
13:13 Changeset [74652] by mitz@apple.com

Try to fix the Qt build after r74648.

  • WebCore.gypi:
  • WebCore.pro:
  • platform/network/qt/CredentialStorageQt.cpp: Added.

(WebCore::CredentialStorage::getFromPersistentStorage):

12:57 Changeset [74651] by philn@webkit.org

2010-12-24 Philippe Normand <pnormand@igalia.com>

Unreviewed, updated GTK media tests baselines after r74643.

  • platform/gtk/media/audio-controls-rendering-expected.txt:
  • platform/gtk/media/controls-after-reload-expected.txt:
  • platform/gtk/media/controls-strict-expected.txt:
  • platform/gtk/media/controls-styling-expected.txt:
  • platform/gtk/media/video-controls-rendering-expected.txt:
  • platform/gtk/media/video-display-toggle-expected.txt:
  • platform/gtk/media/video-empty-source-expected.txt:
  • platform/gtk/media/video-no-audio-expected.txt:
12:55 Changeset [74650] by commit-queue@webkit.org

2010-12-24 Benjamin Poulain <ikipou@gmail.com>

Reviewed by Darin Adler.

[Qt] [WK2] WebKit 2 does not build on mac, missing reference to RetainPtr
https://bugs.webkit.org/show_bug.cgi?id=51598

Fix the build, add the missing header.

  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
12:46 Changeset [74649] by simon.fraser@apple.com

2010-12-24 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

CSSStyleSelector cleanup
https://bugs.webkit.org/show_bug.cgi?id=51597

Make some methods const. Add assertion to checkOneSelector, with the
intention of later removing the if (!e) check (this is hot code).

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::locateCousinList): (WebCore::CSSStyleSelector::canShareStyleWithElement): (WebCore::CSSStyleSelector::locateSharedStyle): (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): (WebCore::CSSStyleSelector::mmLength): (WebCore::CSSStyleSelector::inchLength): (WebCore::CSSStyleSelector::getColorFromPrimitiveValue): (WebCore::CSSStyleSelector::hasSelectorForAttribute):
  • css/CSSStyleSelector.h: (WebCore::CSSStyleSelector::fontSelector):
12:24 Changeset [74648] by mitz@apple.com

<rdar://problem/8758386> The web process uses its own credential storage
https://bugs.webkit.org/show_bug.cgi?id=51599

Reviewed by Anders Carlsson.

WebCore:

  • WebCore.exp.in: Export CredentialStorage::getFromPersistentStorage(), Credential::hasPassword(),

and Credential::isEmpty().

WebKit2:

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didReceiveAuthenticationChallenge): Try to answer the challenge using
the UI process’s credential storage first.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::shouldUseCredentialStorage): Prevent the web process from using
its own credential storage.

  • WebProcess/mac/WebProcessMainMac.mm:

(WebKit::WebProcessMain): Ditto.

11:36 Changeset [74647] by darin@apple.com

Rebased Leopard to expect the same kind of stack failure
as Windows, rather than the success expected on Snow Leopard
and many other platforms.

  • platform/mac-leopard/fast/js/large-expressions-expected.txt:

Copied from platform/win/fast/js/large-expressions-expected.txt.

11:36 Changeset [74646] by yurys@chromium.org

2010-12-24 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Darin Adler.

[V8] Rename V8CustomEventListener.{h,cpp} to V8EventListener.{h,cpp}
https://bugs.webkit.org/show_bug.cgi?id=51595

  • WebCore.gypi:
  • bindings/v8/V8DOMWrapper.cpp:
  • bindings/v8/V8EventListener.cpp: Renamed from WebCore/bindings/v8/custom/V8CustomEventListener.cpp. (WebCore::V8EventListener::V8EventListener): (WebCore::V8EventListener::getListenerFunction): (WebCore::V8EventListener::callListenerFunction):
  • bindings/v8/V8EventListener.h: Renamed from WebCore/bindings/v8/custom/V8CustomEventListener.h. (WebCore::V8EventListener::create):
  • bindings/v8/V8EventListenerList.h:
  • bindings/v8/V8WorkerContextEventListener.h:
  • bindings/v8/custom/V8DOMWindowCustom.cpp:
  • bindings/v8/custom/V8LocationCustom.cpp:
  • bindings/v8/custom/V8NodeCustom.cpp:
  • bindings/v8/custom/V8NotificationCenterCustom.cpp:
11:26 Changeset [74645] by jberlin@webkit.org

Add Windows-specific (failing) expected results for
http/tests/xmlhttprequest/basic-auth-nouser.html and basic-auth-nopassword.html in order to
get the Windows 7 Release test bot green again. Unreviewed.
https://bugs.webkit.org/show_bug.cgi?id=51596

  • platform/win/http/tests/xmlhttprequest/basic-auth-nopassword-expected.txt: Added.
  • platform/win/http/tests/xmlhttprequest/basic-auth-nouser-expected.txt: Added.
11:26 Changeset [74644] by darin@apple.com

Updated makefiles used by Apple engineers to fix build with the
new JavaScriptGlue location.

  • Makefile: Told this to build JavaScriptGlue. Some day we might

want it to descend into Sources instead and use the Makefile there,
but there are problems with sequencing the project builds, so that
can wait.

  • Sources/Makefile.shared: Added.
11:02 Changeset [74643] by commit-queue@webkit.org

2010-12-24 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Xan Lopez.

[GTK] Show current time / total in media player
https://bugs.webkit.org/show_bug.cgi?id=51535

  • css/mediaControlsGtk.css: (audio::-webkit-media-controls-current-time-display, video::-webkit-media-controls-current-time-display):
  • platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::formatMediaControlsCurrentTime): (WebCore::RenderThemeGtk::paintMediaCurrentTime):
  • platform/gtk/RenderThemeGtk.h:
10:55 Changeset [74642] by commit-queue@webkit.org

2010-12-24 Jan Erik Hanssen <jhanssen@sencha.com>

Reviewed by Eric Seidel.

Clean up CSSRuleData in CSSStyleSelector.h
https://bugs.webkit.org/show_bug.cgi?id=27753

Move CSSRuleData and CSSRuleDataList from CSSStyleSelector.h to the .cpp file.

  • css/CSSStyleSelector.cpp: (WebCore::CSSRuleData::CSSRuleData): (WebCore::CSSRuleData::~CSSRuleData): (WebCore::CSSRuleData::position): (WebCore::CSSRuleData::rule): (WebCore::CSSRuleData::selector): (WebCore::CSSRuleData::next): (WebCore::CSSRuleDataList::CSSRuleDataList): (WebCore::CSSRuleDataList::~CSSRuleDataList): (WebCore::CSSRuleDataList::first): (WebCore::CSSRuleDataList::last): (WebCore::CSSRuleDataList::append):
  • css/CSSStyleSelector.h:
10:54 Changeset [74641] by jberlin@webkit.org

Skip the new editing/input/ime-composition-clearpreedit.html test since textInputController
is unimplemented in the DRT for Windows. Unreviewed.
https://bugs.webkit.org/show_bug.cgi?id=32021

  • platform/win/Skipped:
10:43 Changeset [74640] by commit-queue@webkit.org

2010-12-24 Ryuan Choi <ryuan.choi@samsung.com>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Screen doesn't be rendered when changing size of EWebLauncher
https://bugs.webkit.org/show_bug.cgi?id=43528

Remove on_resize because ewk_view_fixed_layout_size_set should not be
called on callback of EVAS_CALLBACK_RESIZE. As it change size of
FrameView, rendering was ignored when _ewk_view_smart_calculate was
called.

  • EWebLauncher/main.c: (browserCreate):
10:21 Changeset [74639] by eric@webkit.org

2010-12-24 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

webkit-patch (or a pre-commit hook) needs to prevent bad ChangeLog changes
https://bugs.webkit.org/show_bug.cgi?id=28291

This is a start. At least now webkit-patch will prompt when your ChangeLog looks questionable.
We could do more advanced things, like parsing the ChangeLog (with changelog.py) and comparing that
to strings with find in the diff.
Since non-interactive always returns the default, this should cause patches with bad changelogs to fail on the commit-queue.

  • Scripts/webkitpy/common/checkout/api.py:
  • Scripts/webkitpy/common/checkout/diff_parser.py:
  • Scripts/webkitpy/tool/steps/abstractstep.py:
  • Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
  • Scripts/webkitpy/tool/steps/validatechangelogs.py: Copied from Tools/Scripts/webkitpy/tool/steps/validatereviewer.py.
  • Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
  • Scripts/webkitpy/tool/steps/validatereviewer.py:
10:20 Changeset [74638] by yurys@chromium.org

2010-12-24 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Fix compilation on Windows.

  • inspector/InspectorStyleSheet.cpp: (WebCore::InspectorStyle::~InspectorStyle): added explicit empty destructor
  • inspector/InspectorStyleSheet.h:
09:51 Changeset [74637] by yurys@chromium.org

2010-12-24 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Darin Adler.

inspector/debugger-step-out.html crashing intermittently in the bots
https://bugs.webkit.org/show_bug.cgi?id=50868

Use RefPtr rather instead of raw pointers when keeping references
to refcounted objects.

  • inspector/InspectorCSSAgent.cpp: (WebCore::InspectorCSSAgent::getStylesForNode2): (WebCore::InspectorCSSAgent::getComputedStyleForNode2):
  • inspector/InspectorStyleSheet.cpp: (WebCore::InspectorStyle::create): (WebCore::InspectorStyle::InspectorStyle): (WebCore::InspectorStyle::buildObjectForStyle): (WebCore::InspectorStyle::setPropertyText): (WebCore::InspectorStyle::toggleProperty): (WebCore::InspectorStyle::styleText): (WebCore::InspectorStyle::populateAllProperties): (WebCore::InspectorStyle::replacePropertyInStyleText): (WebCore::InspectorStyleSheet::create): (WebCore::InspectorStyleSheet::InspectorStyleSheet): (WebCore::InspectorStyleSheetForInlineStyle::create): (WebCore::InspectorStyleSheetForInlineStyle::InspectorStyleSheetForInlineStyle): (WebCore::InspectorStyleSheetForInlineStyle::getStyleAttributeRanges):
  • inspector/InspectorStyleSheet.h: (WebCore::InspectorStyle::cssStyle): (WebCore::InspectorStyleSheet::pageStyleSheet):
09:31 Changeset [74636] by jschuh@chromium.org

2010-12-24 Justin Schuh <jschuh@chromium.org>

Reviewed by Nikolas Zimmermann.

SVGElementInstance::m_useElement should be cleared when use element is removed from document
https://bugs.webkit.org/show_bug.cgi?id=51486

Test: svg/custom/use-instanceRoot-with-use-removed.svg

  • svg/SVGElementInstance.cpp: (WebCore::SVGElementInstance::invalidateAllInstancesOfElement):
  • svg/SVGElementInstance.h: (WebCore::SVGElementInstance::clearUseElement):
  • svg/SVGUseElement.cpp: (WebCore::SVGUseElement::removedFromDocument): (WebCore::ShadowTreeUpdateBlocker::if): (WebCore::SVGUseElement::detachInstance): (WebCore::SVGUseElement::detach):
  • svg/SVGUseElement.h:

2010-12-24 Justin Schuh <jschuh@chromium.org>

Reviewed by Nikolas Zimmermann.

SVGElementInstance::m_useElement should be cleared when use element is removed from document
https://bugs.webkit.org/show_bug.cgi?id=51486

  • svg/custom/use-instanceRoot-with-use-removed-expected.txt: Added.
  • svg/custom/use-instanceRoot-with-use-removed.svg: Added.
09:01 Changeset [74635] by yurys@chromium.org

2010-12-23 Joseph Pecoraro <joepeck@webkit.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Missing Localized Strings
https://bugs.webkit.org/show_bug.cgi?id=51542

Added missing strings: "WebSocket", "Frames", "Text", "Transfer",
"Preserve Log upon Navigation", and "Go to Line".

  • English.lproj/localizedStrings.js:
08:39 Changeset [74634] by apavlov@chromium.org

2010-12-24 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Inline HTML style property out of sync with element.style in Sidebar
https://bugs.webkit.org/show_bug.cgi?id=51478

Now the element attribute modifications (including "style") are tracked, which results in the
source offsets update (in the backend) and Styles/Metrics pane updates (in the frontend)
on the "style" attribute modification through the Elements tree. Also, it appears that
a complete "style" attribute removal destroys the inline style declaration
(StyledElement::m_inlineStyleDecl), while the code used to rely on it being immutable (hence a crash).

Test: inspector/elements-delete-inline-style.html

WebCore:

  • inspector/InspectorCSSAgent.cpp: (WebCore::InspectorCSSAgent::didModifyDOMAttr):
  • inspector/InspectorCSSAgent.h:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::didModifyDOMAttr):
  • inspector/InspectorDOMAgent.h:
  • inspector/InspectorStyleSheet.cpp: (WebCore::InspectorStyleSheetForInlineStyle::InspectorStyleSheetForInlineStyle): (WebCore::InspectorStyleSheetForInlineStyle::didModifyElementAttribute): (WebCore::InspectorStyleSheetForInlineStyle::text): (WebCore::InspectorStyleSheetForInlineStyle::setStyleText): (WebCore::InspectorStyleSheetForInlineStyle::getStyleAttributeRanges):
  • inspector/InspectorStyleSheet.h:
  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted):


LayoutTests:

  • http/tests/inspector/inspector-test2.js: (initialize_InspectorTest.InspectorTest.addResults): (initialize_InspectorTest.InspectorTest.createKeyEvent):
  • inspector/elements-delete-inline-style-expected.txt: Added.
  • inspector/elements-delete-inline-style.html: Added.
  • inspector/elements-tests2.js: Added. (initialize_ElementTest.InspectorTest.expandDOMSubtree.processChildren): (initialize_ElementTest.InspectorTest.expandDOMSubtree): (initialize_ElementTest.InspectorTest.expandDOMSubtreeAndRun): (initialize_ElementTest.InspectorTest.nodeForId): (initialize_ElementTest.InspectorTest.selectElementAndRun): (initialize_ElementTest.InspectorTest.dumpSelectedElementStyles): (initialize_ElementTest.InspectorTest.getSelectedElementStyles): (initialize_ElementTest.InspectorTest.getElementStylePropertyTreeItem): (initialize_ElementTest.InspectorTest.dumpStyleTreeOutline): (initialize_ElementTest.InspectorTest.dumpStyleTreeItem): (initialize_ElementTest):
  • inspector/styles-add-blank-property.html: Remove unnecessary function.
04:18 Changeset [74633] by commit-queue@webkit.org

2010-12-24 Benjamin Kalman <kalman@chromium.org>

Reviewed by Ryosuke Niwa.

editing/selection/caret-* tests need rebaseline for gtk
https://bugs.webkit.org/show_bug.cgi?id=51578

Rebaseline editing/selection/caret-* tests for gtk.

  • platform/gtk/editing/selection/caret-ltr-2-expected.checksum: Added.
  • platform/gtk/editing/selection/caret-ltr-2-expected.png: Added.
  • platform/gtk/editing/selection/caret-ltr-2-expected.txt: Added.
  • platform/gtk/editing/selection/caret-ltr-2-left-expected.checksum: Added.
  • platform/gtk/editing/selection/caret-ltr-2-left-expected.png: Added.
  • platform/gtk/editing/selection/caret-ltr-2-left-expected.txt: Added.
  • platform/gtk/editing/selection/caret-ltr-expected.checksum: Added.
  • platform/gtk/editing/selection/caret-ltr-expected.png: Added.
  • platform/gtk/editing/selection/caret-ltr-expected.txt: Added.
  • platform/gtk/editing/selection/caret-ltr-right-expected.checksum: Added.
  • platform/gtk/editing/selection/caret-ltr-right-expected.png: Added.
  • platform/gtk/editing/selection/caret-ltr-right-expected.txt: Added.
  • platform/gtk/editing/selection/caret-rtl-2-left-expected.checksum: Added.
  • platform/gtk/editing/selection/caret-rtl-2-left-expected.png: Added.
  • platform/gtk/editing/selection/caret-rtl-2-left-expected.txt: Added.
  • platform/gtk/editing/selection/caret-rtl-right-expected.checksum: Added.
  • platform/gtk/editing/selection/caret-rtl-right-expected.png: Added.
  • platform/gtk/editing/selection/caret-rtl-right-expected.txt: Added.
04:12 Changeset [74632] by dpranke@chromium.org

2010-12-24 Dirk Pranke <dpranke@chromium.org>

Reviewed by Kenneth Russell.

Modify new-run-webkit-tests to shut up and exit when all the threads
are wedged so that test runs complete faster and we don't end up
w/ enormous log files.

https://bugs.webkit.org/show_bug.cgi?id=51572

  • Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
  • Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
04:05 Changeset [74631] by commit-queue@webkit.org

2010-12-24 Noel Gordon <noel.gordon@gmail.com>

Reviewed by Andreas Kling.

[chromium] Fix a style nit in the JPEG encoder
https://bugs.webkit.org/show_bug.cgi?id=51574

  • platform/image-encoders/skia/JPEGImageEncoder.cpp: nit begone.
04:02 Changeset [74630] by apavlov@chromium.org

2010-12-23 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Maciej Stachowiak.

Web Inspector: CSS shorthand properties expand unnecessarily
https://bugs.webkit.org/show_bug.cgi?id=36304

"border-radius" is a shorthand property that has a "non-standard" format and longhands, see
http://www.w3.org/TR/css3-background/#border-radius for reference. CSSParser does not use the
standard parseShorthand() or parse4Values() methods but instead a custom parseBorderRadius() method.
This method didn't use to create a ShorthandScope instance and set the m_implicitShorthand value
appropriately when adding implicit longhands, thus they were added as normal properties
found in the CSS (neither implicit, nor longhands). This is now fixed.

WebCore:

  • css/CSSParser.cpp: (WebCore::CSSParser::parseBorderRadius):

LayoutTests:

  • inspector/elements-panel-styles-expected.txt:
  • inspector/resources/elements-panel-styles.css: (.foo):
03:54 Changeset [74629] by jschuh@chromium.org

2010-12-24 Justin Schuh <jschuh@chromium.org>

Reviewed by Darin Adler.

setTargetAttributeAnimatedValue should check for a null shadowTreeElement.
https://bugs.webkit.org/show_bug.cgi?id=51576

  • svg/custom/animate-disallowed-use-element-expected.txt: Added.
  • svg/custom/animate-disallowed-use-element.svg: Added.

2010-12-24 Justin Schuh <jschuh@chromium.org>

Reviewed by Darin Adler.

setTargetAttributeAnimatedValue should check for a null shadowTreeElement.
https://bugs.webkit.org/show_bug.cgi?id=51576

Disallowed elements may be pruned from the shadow tree, leaving a null
shadowTreeElement. We should check for that before setting attributes.

Test: svg/custom/animate-disallowed-use-element.svg

  • svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::setTargetAttributeAnimatedValue):
03:50 Changeset [74628] by evan@chromium.org

2010-12-24 Evan Martin <evan@chromium.org>

Reviewed by Darin Adler.

TextMetrics::width is an integer, but the member is a float
https://bugs.webkit.org/show_bug.cgi?id=51566

Change the return type to a float.

No tests, fixing a compiler warning.
(I was unable to produce a difference in the values exposed to pages
with a float versus the previous conversion to an integer.)

  • html/TextMetrics.h: (WebCore::TextMetrics::width):
03:47 Changeset [74627] by andreip@google.com

2010-12-24 Andrei Popescu <andreip@google.com>

Unreviewed build fix.

Add Chromium-mac test expectation for the layout test below.
[Chromium] http/tests/xmlhttprequest/basic-auth-nopassword.html needs Mac specific test expectations
https://bugs.webkit.org/show_bug.cgi?id=51589

  • platform/chromium-mac/http/tests/xmlhttprequest/basic-auth-nopassword-expected.txt: Added.
03:27 Changeset [74626] by commit-queue@webkit.org

2010-12-24 Ryuan Choi <ryuan.choi@samsung.com>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Add option to enable Touch Events.
https://bugs.webkit.org/show_bug.cgi?id=49125

Add ENABLE_TOUCH_EVENTS option.

  • cmake/OptionsEfl.cmake:
  • cmakeconfig.h.cmake:

2010-12-24 Ryuan Choi <ryuan.choi@samsung.com>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Add option to enable Touch Events.
https://bugs.webkit.org/show_bug.cgi?id=49125

Add files for EFL to support TOUCH_EVENTS.

  • CMakeLists.txt:
  • CMakeListsEfl.txt:
  • platform/PlatformTouchEvent.h: Add EFL related constructor.
  • platform/PlatformTouchPoint.h: ditto.
  • platform/efl/PlatformTouchEventEfl.cpp: Added. (WebCore::PlatformTouchEvent::PlatformTouchEvent):
  • platform/efl/PlatformTouchPointEfl.cpp: Added. (WebCore::PlatformTouchPoint::PlatformTouchPoint):

2010-12-24 Ryuan Choi <ryuan.choi@samsung.com>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Add option to enable Touch Events.
https://bugs.webkit.org/show_bug.cgi?id=49125

Implement ewk_frame_feed_touch_event to feed touch events. Because EFL
doesn't have touch events, Application should generate and pass it.

  • WebCoreSupport/ChromeClientEfl.h: (WebCore::ChromeClientEfl::needTouchEvents):
  • ewk/ewk_frame.cpp: (ewk_frame_feed_touch_event):
  • ewk/ewk_frame.h:
03:23 Changeset [74625] by gyuyoung.kim@samsung.com

2010-12-24 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Return an empty string instead of 'application/octet-stream' in getMIMETypeForExtension()
https://bugs.webkit.org/show_bug.cgi?id=51457

WebKit EFL can't play html5 audio because of wrong mime type checking.
So, 'application/octet-stream' is changed with an empty string.

  • platform/efl/MIMETypeRegistryEfl.cpp: (WebCore::MIMETypeRegistry::getMIMETypeForExtension): Returns an empty string instead of application/octet-stream when it can't find proper mime type.
03:09 Changeset [74624] by andreip@google.com

2010-12-24 Andrei Popescu <andreip@google.com>

Unreviewed. Update Chromium test expectations.

Mark editing/input/ime-composition-clearpreedit.html.html as TEXT.
This test was added in http://trac.webkit.org/changeset/74605 and
fails in Chromium.

  • platform/chromium/test_expectations.txt:
03:05 Changeset [74623] by eric@webkit.org

2010-12-24 Eric Seidel <eric@webkit.org>

Reviewed by David Levin.

commit-queue should better explain how it will re-open bugs and follow duplicate chains
https://bugs.webkit.org/show_bug.cgi?id=51549

I've had multiple people ask me about the commit-queue's behavior
regarding reporting flaky tests. I figured it would be best to just
have the queue explain itself in the bugs it files.

  • Scripts/webkitpy/tool/bot/flakytestreporter.py:
  • Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
02:38 Changeset [74622] by jschuh@chromium.org

2010-12-24 Justin Schuh <jschuh@chromium.org>

Reviewed by Darin Adler.

SVGFontFaceElement::rebuildFontFace() should exit when not in document
https://bugs.webkit.org/show_bug.cgi?id=51571

  • svg/custom/use-invalid-font-face-expected.txt: Added.
  • svg/custom/use-invalid-font-face.svg: Added.

2010-12-24 Justin Schuh <jschuh@chromium.org>

Reviewed by Darin Adler.

SVGFontFaceElement::rebuildFontFace() should exit when not in document
https://bugs.webkit.org/show_bug.cgi?id=51571

We were hitting a NULL deref crash. Since most of the callers checked
inDocument() anyway, I moved it into the start of rebuildFontFace.

Test: svg/custom/use-invalid-font-face.svg

  • svg/SVGFontFaceElement.cpp: (WebCore::SVGFontFaceElement::parseMappedAttribute): (WebCore::SVGFontFaceElement::rebuildFontFace): (WebCore::SVGFontFaceElement::childrenChanged):
02:19 Changeset [74621] by hamaji@chromium.org

2010-12-24 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Eric Seidel.

check-webkit-style: should ignore "wrong" namings in JavaScriptCore/qt
https://bugs.webkit.org/show_bug.cgi?id=51467

  • Scripts/webkitpy/style/checker.py:
  • Scripts/webkitpy/style/checker_unittest.py:
02:12 Changeset [74620] by philn@webkit.org

2010-12-21 Philippe Normand <pnormand@igalia.com>

Reviewed by Eric Seidel.

[GTK] minimal build with --database fails
https://bugs.webkit.org/show_bug.cgi?id=51394

  • webkit/webkitprivate.cpp: (webkit_init): Use cacheStorage() only if the OFFLINE_WEB_APPLICATIONS feature is enabled.
02:00 Changeset [74619] by jschuh@chromium.org

2010-12-24 Justin Schuh <jschuh@chromium.org>

Reviewed by Darin Adler.

Remove unnecessary check in CSSCanvasValue::canvasDestroyed().
https://bugs.webkit.org/show_bug.cgi?id=51564

This check was duplicating an ASSERT for a case fixed in r73927.
Now that the bug is fixed the check is no longer necessary.

Removing dead code, so no new tests needed.

  • css/CSSCanvasValue.cpp: (WebCore::CSSCanvasValue::canvasDestroyed):
01:01 Changeset [74618] by abarth@webkit.org

Move JavaScriptGlue into Sources
https://bugs.webkit.org/show_bug.cgi?id=51583

Rubber-stamped by Eric Seidel.

Actually perform the move.

  • JavaScriptGlue: Removed.
  • JavaScriptGlue/Configurations: Removed.
  • JavaScriptGlue/Configurations/Base.xcconfig: Removed.
  • JavaScriptGlue/Configurations/DebugRelease.xcconfig: Removed.
  • JavaScriptGlue/Configurations/JavaScriptGlue.xcconfig: Removed.
  • JavaScriptGlue/Configurations/Version.xcconfig: Removed.
  • JavaScriptGlue/English.lproj: Removed.
  • JavaScriptGlue/English.lproj/InfoPlist.strings: Removed.
  • JavaScriptGlue/ForwardingHeaders: Removed.
  • JavaScriptGlue/ForwardingHeaders/masm: Removed.
  • JavaScriptGlue/ForwardingHeaders/masm/X86Assembler.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/profiler: Removed.
  • JavaScriptGlue/ForwardingHeaders/profiler/Profiler.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/runtime: Removed.
  • JavaScriptGlue/ForwardingHeaders/runtime/CallFrame.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/ASCIICType.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/AlwaysInline.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/Assertions.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/Atomics.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/Bitmap.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/BumpPointerAllocator.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/CrossThreadRefCounted.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/CurrentTime.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/DateInstanceCache.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/DateMath.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/FastAllocBase.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/FastMalloc.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/FixedArray.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/Forward.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/HashCountedSet.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/HashFunctions.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/HashMap.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/HashSet.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/HashTraits.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/ListHashSet.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/ListRefPtr.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/Locker.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/MainThread.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/MathExtras.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/Noncopyable.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/NotFound.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/OSAllocator.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/OwnArrayPtr.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/OwnArrayPtrCommon.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/OwnFastMallocPtr.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/OwnPtr.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/OwnPtrCommon.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/PageAllocation.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/PageAllocationAligned.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/PageBlock.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/PageReservation.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/PassOwnArrayPtr.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/PassOwnPtr.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/PassRefPtr.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/Platform.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/PossiblyNull.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/PtrAndFlags.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/RandomNumber.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/RefCounted.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/RefPtr.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/StackBounds.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/StdLibExtras.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/StringHasher.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/ThreadSafeShared.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/ThreadSpecific.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/Threading.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/ThreadingPrimitives.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/UnusedParam.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/VMTags.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/ValueCheck.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/Vector.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/VectorTraits.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/WTFThreadData.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/text: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/text/CString.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/text/StringHash.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/text/StringImpl.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/text/StringImplBase.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/text/TextPosition.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/text/WTFString.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/unicode: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/unicode/Unicode.h: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/unicode/icu: Removed.
  • JavaScriptGlue/ForwardingHeaders/wtf/unicode/icu/UnicodeIcu.h: Removed.
  • JavaScriptGlue/Info.plist: Removed.
  • JavaScriptGlue/JSBase.cpp: Removed.
  • JavaScriptGlue/JSBase.h: Removed.
  • JavaScriptGlue/JSObject.cpp: Removed.
  • JavaScriptGlue/JSObject.h: Removed.
  • JavaScriptGlue/JSRun.cpp: Removed.
  • JavaScriptGlue/JSRun.h: Removed.
  • JavaScriptGlue/JSUtils.cpp: Removed.
  • JavaScriptGlue/JSUtils.h: Removed.
  • JavaScriptGlue/JSValueWrapper.cpp: Removed.
  • JavaScriptGlue/JSValueWrapper.h: Removed.
  • JavaScriptGlue/JavaScriptGlue.cpp: Removed.
  • JavaScriptGlue/JavaScriptGlue.exp: Removed.
  • JavaScriptGlue/JavaScriptGlue.h: Removed.
  • JavaScriptGlue/JavaScriptGlue.xcodeproj: Removed.
  • JavaScriptGlue/JavaScriptGlue.xcodeproj/project.pbxproj: Removed.
  • JavaScriptGlue/LICENSE: Removed.
  • JavaScriptGlue/Makefile: Removed.
  • JavaScriptGlue/UserObjectImp.cpp: Removed.
  • JavaScriptGlue/UserObjectImp.h: Removed.
  • JavaScriptGlue/config.h: Removed.
  • JavaScriptGlue/icu: Removed.
  • JavaScriptGlue/icu/LICENSE: Removed.
  • JavaScriptGlue/icu/README: Removed.
  • JavaScriptGlue/icu/unicode: Removed.
  • JavaScriptGlue/icu/unicode/platform.h: Removed.
  • JavaScriptGlue/icu/unicode/putil.h: Removed.
  • JavaScriptGlue/icu/unicode/uchar.h: Removed.
  • JavaScriptGlue/icu/unicode/ucnv.h: Removed.
  • JavaScriptGlue/icu/unicode/ucnv_err.h: Removed.
  • JavaScriptGlue/icu/unicode/uconfig.h: Removed.
  • JavaScriptGlue/icu/unicode/uenum.h: Removed.
  • JavaScriptGlue/icu/unicode/uiter.h: Removed.
  • JavaScriptGlue/icu/unicode/umachine.h: Removed.
  • JavaScriptGlue/icu/unicode/urename.h: Removed.
  • JavaScriptGlue/icu/unicode/ustring.h: Removed.
  • JavaScriptGlue/icu/unicode/utf.h: Removed.
  • JavaScriptGlue/icu/unicode/utf16.h: Removed.
  • JavaScriptGlue/icu/unicode/utf8.h: Removed.
  • JavaScriptGlue/icu/unicode/utf_old.h: Removed.
  • JavaScriptGlue/icu/unicode/utypes.h: Removed.
  • JavaScriptGlue/icu/unicode/uversion.h: Removed.
  • JavaScriptGlue/testjsglue.cpp: Removed.
  • Makefile:
  • Sources: Added.
  • Sources/JavaScriptGlue: Copied from JavaScriptGlue.
  • Sources/Makefile: Added.

Tools:

These tools refer to JavaScriptGlue and need to be updated to its new
location.

  • Scripts/build-webkit:
  • Scripts/do-file-rename:
  • Scripts/do-webcore-rename:
  • Scripts/webkitpy/common/config/build.py:
  • Scripts/webkitpy/common/config/build_unittest.py:

Websites/bugs.webkit.org:

PrettyPatch keeps a list of the top-level directories that exist in
trac.

  • PrettyPatch/PrettyPatch.rb:
00:06 Changeset [74617] by paroga@webkit.org

2010-12-24 Patrick Gansterer <paroga@webkit.org>

Reviewed by Eric Seidel.

[WINCE] Add CPU(MIPS) detection
https://bugs.webkit.org/show_bug.cgi?id=51342

WinCE usually defines MIPS and _MIPS_.

  • wtf/Platform.h:
Note: See TracTimeline for information about the timeline view.