Timeline


and

12/29/10:

23:55 Changeset [74786] by inferno@chromium.org

2010-12-29 Abhishek Arya <inferno@chromium.org>

Unreviewed.

Add 'PASS' to layout test since test failing on chromium due to empty expectations.
Filed webkit bug 51734 to track gtk test failure and skipping test for now.

  • fast/multicol/span/double-merge-anonymous-block-crash-expected.txt:
  • fast/multicol/span/double-merge-anonymous-block-crash.html:
  • platform/gtk/Skipped:
23:41 Changeset [74785] by pfeldman@chromium.org

2010-12-29 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: extract Database & DOM Storage agents; remove InspectorBackend.
https://bugs.webkit.org/show_bug.cgi?id=51707

This change brushes up storage agents + removes redundant InspectorBackend class.

  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/CodeGeneratorInspector.pm:
  • inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::databaseForId): (WebCore::InjectedScriptHost::selectDatabase): (WebCore::InjectedScriptHost::selectDOMStorage): (WebCore::InjectedScriptHost::inspectorDOMAgent):
  • inspector/Inspector.idl:
  • inspector/InspectorBackend.cpp: Removed.
  • inspector/InspectorBackend.h: Removed.
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::~InspectorController): (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::releaseFrontendLifetimeAgents): (WebCore::InspectorController::didUseDOMStorage): (WebCore::InspectorController::setInjectedScriptSource): (WebCore::InspectorController::dispatchOnInjectedScript): (WebCore::InspectorController::releaseWrapperObjectGroup):
  • inspector/InspectorController.h:
  • inspector/InspectorDOMStorageAgent.cpp: Added. (WebCore::InspectorDOMStorageAgent::~InspectorDOMStorageAgent): (WebCore::InspectorDOMStorageAgent::getDOMStorageEntries): (WebCore::InspectorDOMStorageAgent::setDOMStorageItem): (WebCore::InspectorDOMStorageAgent::removeDOMStorageItem): (WebCore::InspectorDOMStorageAgent::selectDOMStorage): (WebCore::InspectorDOMStorageAgent::InspectorDOMStorageAgent): (WebCore::InspectorDOMStorageAgent::getDOMStorageResourceForId):
  • inspector/InspectorDOMStorageAgent.h: Copied from WebCore/inspector/InspectorStorageAgent.h. (WebCore::InspectorDOMStorageAgent::create): (WebCore::InspectorDOMStorageAgent::frontend):
  • inspector/InspectorDatabaseAgent.cpp: Renamed from WebCore/inspector/InspectorStorageAgent.cpp. (WebCore::InspectorDatabaseAgent::~InspectorDatabaseAgent): (WebCore::InspectorDatabaseAgent::getDatabaseTableNames): (WebCore::InspectorDatabaseAgent::executeSQL): (WebCore::InspectorDatabaseAgent::databaseForId): (WebCore::InspectorDatabaseAgent::selectDatabase): (WebCore::InspectorDatabaseAgent::clearFrontend): (WebCore::InspectorDatabaseAgent::InspectorDatabaseAgent):
  • inspector/InspectorDatabaseAgent.h: Renamed from WebCore/inspector/InspectorStorageAgent.h. (WebCore::InspectorDatabaseAgent::create): (WebCore::InspectorDatabaseAgent::frontend):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.show): (WebInspector.ScriptsPanel.prototype.attachDebuggerWhenShown): (WebInspector.ScriptsPanel.prototype._toggleDebugging):
23:20 Changeset [74784] by paroga@webkit.org

2010-12-29 Patrick Gansterer <paroga@webkit.org>

Unreviewed WinCE buildfix.

  • WinCELauncher/main.cpp: Add missing include.
23:00 Changeset [74783] by krit@webkit.org

2010-12-29 Dirk Schulze <krit@webkit.org>

Unreviewed fix of the misspelled email address in commit 74782.

22:49 Changeset [74782] by krit@webkit.org

2010-12-29 Dirk Schulze <krit@wbekit.org>

Reviewed by Darin Adler.

Cleanup SVG code according to the webkit style rules 3
https://bugs.webkit.org/show_bug.cgi?id=51490

Last patch to fix indention and other style issues according to the WebKit style rules in the SVG code.
Just one file can't be fixed for check-webkit-style.

  • SVGAllInOne.cpp: check-webkit-style wants a config.h at the beginning

No changes of functionality, so no new tests.

  • svg/SVGAllInOne.cpp:
  • svg/SVGImage.cpp:
  • svg/SVGLength.cpp: (WebCore::SVGLength::setValue):
  • svg/SVGPolygonElement.h:
  • svg/SVGPolylineElement.h:
  • svg/SVGPreserveAspectRatio.cpp: (WebCore::SVGPreserveAspectRatio::parsePreserveAspectRatio): (WebCore::SVGPreserveAspectRatio::transformRect):
  • svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::viewport):
  • svg/SVGSetElement.h:
  • svg/SVGStylable.h: (WebCore::SVGStylable::~SVGStylable):
  • svg/SVGStyledLocatableElement.h: (WebCore::SVGStyledLocatableElement::localCoordinateSpaceTransform): (WebCore::SVGStyledLocatableElement::isStyledLocatable):
  • svg/SVGStyledTransformableElement.cpp: (WebCore::SVGStyledTransformableElement::isKnownAttribute):
  • svg/SVGSwitchElement.cpp: (WebCore::SVGSwitchElement::childShouldCreateRenderer):
  • svg/SVGTests.cpp: (WebCore::SVGTests::parseMappedAttribute):
  • svg/SVGTextContentElement.cpp: (WebCore::SVGTextContentElement::isKnownAttribute):
  • svg/SVGTextPathElement.cpp:
  • svg/SVGTextPathElement.h:
  • svg/SVGTitleElement.h: (WebCore::SVGTitleElement::rendererIsNeeded):
  • svg/SVGTransformDistance.cpp: (WebCore::SVGTransformDistance::SVGTransformDistance): (WebCore::SVGTransformDistance::scaledDistance): (WebCore::SVGTransformDistance::addSVGTransforms): (WebCore::SVGTransformDistance::addSVGTransform): (WebCore::SVGTransformDistance::addToSVGTransform): (WebCore::SVGTransformDistance::isZero):
  • svg/SVGTransformList.cpp:
  • svg/SVGURIReference.cpp: (WebCore::SVGURIReference::getTarget):
  • svg/SVGVKernElement.h:
  • svg/SVGViewSpec.cpp: (WebCore::SVGViewSpec::parseViewSpec):
  • svg/SVGZoomAndPan.h: (WebCore::SVGZoomAndPan::SVGZoomAndPan): (WebCore::SVGZoomAndPan::~SVGZoomAndPan): (WebCore::SVGZoomAndPan::zoomAndPan):
  • svg/SVGZoomEvent.h: (WebCore::SVGZoomEvent::create):
  • svg/animation/SMILTime.cpp: (WebCore::operator*):
  • svg/animation/SMILTime.h: (WebCore::SMILTime::SMILTime): (WebCore::SMILTime::unresolved): (WebCore::SMILTime::indefinite): (WebCore::SMILTime::operator=): (WebCore::SMILTime::value): (WebCore::SMILTime::isFinite): (WebCore::SMILTime::isIndefinite): (WebCore::SMILTime::isUnresolved): (WebCore::operator==): (WebCore::operator!): new operator checks for 0 or infinite values. (WebCore::operator!=): (WebCore::operator>): (WebCore::operator<): (WebCore::operator>=): (WebCore::operator<=):
  • svg/animation/SMILTimeContainer.h: (WebCore::SMILTimeContainer::create): (WebCore::SMILTimeContainer::setDocumentOrderIndexesDirty):
  • svg/animation/SVGSMILElement.cpp: (WebCore::ConditionEventListener::operator==): (WebCore::SVGSMILElement::repeatingDuration): (WebCore::SVGSMILElement::resolveInterval): (WebCore::SVGSMILElement::calculateAnimationPercentAndRepeat):
  • svg/animation/SVGSMILElement.h: (WebCore::SVGSMILElement::timeContainer): (WebCore::SVGSMILElement::intervalBegin): (WebCore::SVGSMILElement::intervalEnd): (WebCore::SVGSMILElement::previousIntervalBegin): (WebCore::SVGSMILElement::documentOrderIndex): (WebCore::SVGSMILElement::setDocumentOrderIndex):
  • svg/graphics/SVGImage.h: (WebCore::SVGImage::create): (WebCore::SVGImage::destroyDecodedData): (WebCore::SVGImage::decodedSize): (WebCore::SVGImage::frameAtIndex):
  • svg/graphics/filters/SVGFilterBuilder.h: (WebCore::SVGFilterBuilder::create): (WebCore::SVGFilterBuilder::lastEffect): (WebCore::SVGFilterBuilder::getEffectReferences): (WebCore::SVGFilterBuilder::addBuiltinEffects):
22:36 Changeset [74781] by inferno@chromium.org

2010-12-29 Abhishek Arya <inferno@chromium.org>

Reviewed by Darin Adler.

ASSERT(oldchild->parent() == owner) fails.
https://bugs.webkit.org/show_bug.cgi?id=50480

In RenderBlock removeChild function, when the inlineChildrenBlock(equal to prev or next)
is reparented to blockChildrenBlock, it is no longer a child of "this". This causes the
assertion failure when removeChildNode executes on the child(equal to prev or next).
Fix a typo in canMergeContiguousAnonymousBlocks.

Test: fast/multicol/span/double-merge-anonymous-block-crash.html

  • rendering/RenderBlock.cpp: (WebCore::canMergeContiguousAnonymousBlocks): fix typo, change prev to next. (WebCore::RenderBlock::removeChild): if prev or not is reparented, then set it to zero.

2010-12-29 Abhishek Arya <inferno@chromium.org>

Reviewed by Darin Adler.

Tests that we do not crash when merging anonymous blocks.
https://bugs.webkit.org/show_bug.cgi?id=50480

  • fast/multicol/span/double-merge-anonymous-block-crash-expected.txt: Added.
  • fast/multicol/span/double-merge-anonymous-block-crash.html: Added.
22:03 Changeset [74780] by dbates@webkit.org

2010-12-29 Daniel Bates <dbates@rim.com>

Reviewed by Darin Adler.

svn-apply updates date of wrong change log entry for a change log diff that
contains two consecutive entries with the same author and date
https://bugs.webkit.org/show_bug.cgi?id=46061

Fixes an issue where the date of the wrong change log entry may be modified.
Moreover, changes fixChangeLogPatch() to move entries inserted earlier
in a ChangeLog file to the top of the file.

Currently, fixChangeLogPatch() explicitly bails out and returns an unchanged
diff when it detects that the diff inserts a change log entry earlier in a
ChangeLog. It is unusual to land a patch that has such a deliberate ChangeLog
change. With the advent of the commit-queue this functionality of bailing out
and hence landing the patch as-is is harmful to the accuracy of the ChangeLog.
Instead, we should always move the change log entry to the top of the ChangeLog file.

A side-effect of this change is that setChangeLogDateAndReviewer() now updates
the date line of the correct change log entry in a ChangeLog diff.

  • Scripts/VCSUtils.pm: Modified fixChangeLogPatch() to move entries inserted earlier to the top.
  • Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl: Updated the following unit tests now that we move entries inserted earlier to the top:
    • "fixChangeLogPatch: New entry inserted in middle." (formerly named "fixChangeLogPatch: [no change] New entry inserted in middle.")
  • "fixChangeLogPatch: New entry inserted earlier in the file, but after an entry with the same author and date." (formerly named "fixChangeLogPatch: [no change] New entry inserted earlier in the file, but after an entry with the same author and date.")
  • Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatchThenSetChangeLogDateAndReviewer.pl: Added.
21:43 Changeset [74779] by jschuh@chromium.org

2010-12-29 Justin Schuh <jschuh@chromium.org>

Reviewed by Darin Adler.

Check SVG element type in FrameView::scrollToAnchor
https://bugs.webkit.org/show_bug.cgi?id=51718

Test: svg/custom/scroll-to-anchor-in-symbol.svg

  • page/FrameView.cpp: (WebCore::FrameView::scrollToAnchor):

2010-12-29 Justin Schuh <jschuh@chromium.org>

Reviewed by Darin Adler.

Check SVG element type in FrameView::scrollToAnchor
https://bugs.webkit.org/show_bug.cgi?id=51718

  • svg/custom/scroll-to-anchor-in-symbol-expected.txt: Added.
  • svg/custom/scroll-to-anchor-in-symbol.svg: Added.
20:07 Changeset [74778] by antonm@chromium.org

2010-12-29 Anton Muhin <antonm@chromium.org>

Reviewed by Eric Seidel.

[v8] Minor cleanup: remove unused method (the only method which can mutate context of V8DOMWindowShell)
https://bugs.webkit.org/show_bug.cgi?id=51704

  • bindings/v8/V8DOMWindowShell.cpp:
  • bindings/v8/V8DOMWindowShell.h:
19:54 Changeset [74777] by zmo@google.com

2010-12-29 Zhenyao Mo <zmo@google.com>

Reviewed by Eric Seidel.

drawElements should raise INVALID_OPERATION if offset is not a multiple of the type size
https://bugs.webkit.org/show_bug.cgi?id=51726

  • fast/canvas/webgl/draw-elements-out-of-bounds-expected.txt:
  • fast/canvas/webgl/draw-elements-out-of-bounds.html: Add test cases to verify the behavior.
19:16 Changeset [74776] by commit-queue@webkit.org

2010-12-29 Konstantin Tokarev <annulen@yandex.ru>

Reviewed by Eric Seidel.

[Qt] Fixed compatibility with gold linker on X11 platforms
https://bugs.webkit.org/show_bug.cgi?id=51700

  • DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: Linked TestNetscapePlugin with libX11 on Unix platforms
19:16 Changeset [74775] by commit-queue@webkit.org

2010-12-29 Kenichi Ishibashi <bashi@google.com>

Reviewed by Darin Adler.

Use a HashMap for m_continuation to save memory
https://bugs.webkit.org/show_bug.cgi?id=43716

Saving memory consumption by applying a HashMap convention to
continuation pointers of RenderInline and RenderBlock classes.

  • rendering/RenderBlock.cpp: Removed m_continuation. (WebCore::RenderBlock::RenderBlock): (WebCore::RenderBlock::destroy): (WebCore::RenderBlock::inlineElementContinuation): (WebCore::RenderBlock::blockElementContinuation):
  • rendering/RenderBlock.h: Removed m_continuation.
  • rendering/RenderBoxModelObject.cpp: Added a hash map for continuations. (WebCore::RenderBoxModelObject::destroy): Added an assertion. (WebCore::RenderBoxModelObject::continuation): Added. (WebCore::RenderBoxModelObject::setContinuation): Added.
  • rendering/RenderBoxModelObject.h:
  • rendering/RenderInline.cpp: Removed m_continuation. (WebCore::RenderInline::RenderInline): (WebCore::RenderInline::destroy): (WebCore::RenderInline::inlineElementContinuation):
  • rendering/RenderInline.h: Removed m_continuation.
18:08 Changeset [74774] by commit-queue@webkit.org

2010-12-29 Ademar de Souza Reis Jr <ademar.reis@openbossa.org>

Reviewed by Darin Adler.

Circular dependency in webkitpy.common.checkout.changelog module
https://bugs.webkit.org/show_bug.cgi?id=50475

Remove automatic import of api.Checkout module when any checkout/
submodule is imported (e.g.: when checkout.scm.Git is imported).

  • Scripts/webkitpy/common/checkout/init.py:
17:16 Changeset [74773] by mihaip@chromium.org

2010-12-29 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium expectations update.

Remove failing expectations for three Mac tests that no longer fail.
Remove failing expectations for two canvas tests that no longer crash
(r74561, which caused the failing assert, was rolled out with r74587).

  • platform/chromium/test_expectations.txt:
17:05 Changeset [74772] by mihaip@chromium.org

2010-12-29 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium expectations update.
fast/js/numeric-escapes-in-string-literals.html fails because V8 does
not support ECMAScript strict mode.

  • platform/chromium/test_expectations.txt:
17:00 Changeset [74771] by mihaip@chromium.org

2010-12-29 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium expectations update. Mark two more inspector tests
as flaky.

  • platform/chromium/test_expectations.txt:
16:44 Changeset [74770] by mihaip@chromium.org

2010-12-29 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium expectations update. Mark a few more tests as flaky.

  • platform/chromium/test_expectations.txt:
16:14 Changeset [74769] by mihaip@chromium.org

2010-12-29 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium expectations update.

fast/canvas/shadow-offset-* are flaky when run in the GPU suite too.

  • platform/chromium-gpu/test_expectations.txt:
16:11 Changeset [74768] by mihaip@chromium.org

2010-12-29 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium expectations update.

Make expectation for http/tests/media/reload-after-dialog.html not
trigger a duplication error for the debug Linux builder.

Remove expectation for platform/gtk/fast/text/emphasis-overlap.html, it
was removed in r74346.

  • platform/chromium/test_expectations.txt:
16:00 Changeset [74767] by barraclough@apple.com

Bug 51724 - In strict mode string literals should allow \0, but disallow \8 and \9.

Reviewed by Sam Weinig.

JavaScriptCore:

  • parser/Lexer.cpp:

(JSC::Lexer::parseString):

LayoutTests:

  • fast/js/numeric-escapes-in-string-literals-expected.txt: Added.
  • fast/js/numeric-escapes-in-string-literals.html: Added.
  • fast/js/script-tests/numeric-escapes-in-string-literals.js: Added.

(test):

15:46 Changeset [74766] by mrobinson@webkit.org

2010-12-27 Amruth Raj <amruthraj@motorola.com> and Ravi Kasibhatla <ravi.kasibhatla@motorola.com>

Reviewed by Martin Robinson.

[GTK] Enable building whatever already exists of WebKit2
https://bugs.webkit.org/show_bug.cgi?id=37369

No new functionality added or deleted. Only makefile change. Hence, no tests added.

  • GNUmakefile.am: Removed bindings/gobject from webcore_sources & webcore_cppflags and added them to WebKit/gtk/GNUmakefile.am
  • platform/network/soup/cache/webkit/soup-cache.h: Remove include <webkit/webkitdefines.h> and declare WEBKIT_API directly

2010-12-15 Amruth Raj <amruthraj@motorola.com> and Ravi Kasibhatla <ravi.kasibhatla@motorola.com>

Reviewed by Martin Robinson.

[GTK] Enable building whatever already exists of WebKit2
https://bugs.webkit.org/show_bug.cgi?id=37369

  • GNUmakefile.am: Added.
  • WebKit2Prefix.h: Included WebCore/config.h for GTK port as the first header file for WebKit2 sources files.
  • gtk: Added.
  • gtk/webkit2.pc.in: Added.
14:58 Changeset [74765] by mrobinson@webkit.org

2010-12-29 Martin Robinson <mrobinson@igalia.com>

Build fix for GTK+.

  • webkit/webkitwebinspector.cpp: Add missing DumpRenderTreeSupportGtk include.
14:57 Changeset [74764] by eric@webkit.org

2010-12-29 Eric Seidel <eric@webkit.org>

Unreviewed.

Simplify make-hash-tools.pl
https://bugs.webkit.org/show_bug.cgi?id=49922

Added HashTools.h to the project file now that its not autogenerated.
I also sorted the project file using sort-xcode-project-file

  • WebCore.xcodeproj/project.pbxproj:
14:56 Changeset [74763] by mihaip@chromium.org

2010-12-29 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium expectations update. Mark another test as flaky.

  • platform/chromium/test_expectations.txt:
14:34 Changeset [74762] by mrobinson@webkit.org

2010-12-29 Martin Robinson <mrobinson@igalia.com>

[GTK] GSettings warning is concealing real warnings on the build bots
https://bugs.webkit.org/show_bug.cgi?id=51691

Reviewed by Xan Lopez.

Do not print the GSettings warning message when running in DumpRenderTree.

  • webkit/webkitwebinspector.cpp: (inspectorGSettings): Do not print the GSettings warning if we are running in DumpRenderTree. This should clean up the test results page a great deal.
14:22 Changeset [74761] by pfeldman@chromium.org

2010-12-29 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: revert r74755 and 74757.

14:20 Changeset [74760] by mrobinson@webkit.org

2010-12-29 Martin Robinson <mrobinson@igalia.com>

Reviewed by Sam Weinig.

JSDataViewCustom.cpp gives the fastcall calling convention to functions called via C++
https://bugs.webkit.org/show_bug.cgi?id=51722

Remove the JSC_HOST_CALL from methods that are called from C++. JSC_HOST_CALL gives
methods the fastcall calling convention, which leads to runtime errors when they are
called from C++. Also remove a bit of unnecessary code duplication.

No new tests. This is covered by fast/canvas/webgl/data-view-test.html.

  • bindings/js/JSDataViewCustom.cpp: (WebCore::getDataViewMember): Remove duplicated code. (WebCore::JSDataView::getInt8): Remove JSC_HOST_CALL. (WebCore::JSDataView::getUint8): Ditto. (WebCore::JSDataView::getFloat32): Ditto. (WebCore::JSDataView::getFloat64): Ditto. (WebCore::setDataViewMember): Remove duplicated code. (WebCore::JSDataView::setInt8): Remove JSC_HOST_CALL. (WebCore::JSDataView::setUint8): Ditto.
14:18 Changeset [74759] by mitz@apple.com

A more robust fix for https://bugs.webkit.org/show_bug.cgi?id=51681

Reviewed by Kenneth Russel.

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::attach): Added. Like recalcStyle(), calls
CanvasRenderingContext2D::updateFont() if necessary. This covers the case of a detach/
attach-type style recalc.

  • html/HTMLCanvasElement.h:
  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::drawTextInternal): Removed the early return added in
r74716. A font that is loading custom fonts is okay to use, as long as it is valid.
(WebCore::CanvasRenderingContext2D::accessFont): Added a call to
Document::updateStyleIfNeeded(). This ensures that any pending style recalc will take place
and update the font if it is invalid.

  • platform/graphics/Font.h:

(WebCore::Font::loadingCustomFonts): Made this private.

13:43 Changeset [74758] by mihaip@chromium.org

2010-12-29 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium expectations update.

fast/canvas/webgl/tex-image-with-format-and-type.html is flaky in
the GPU suite too.

  • platform/chromium/test_expectations.txt:
  • platform/chromium-gpu/test_expectations.txt:
13:39 Changeset [74757] by pfeldman@chromium.org

2010-12-29 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: Qt build fix.

  • inspector/InspectorController.cpp:
13:38 Changeset [74756] by mihaip@chromium.org

2010-12-29 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium expectations update.

Remove failure expectations for tests that no longer fail:

  • fast/images/svg-as-background.html has not timed out for as long as the flakiness dashboard has history
  • svg/W3C-SVG-1.1/animate-elem-03-t.svg has not failed for as long as the flakiness dashboard has history
  • platform/chromium/test_expectations.txt:
13:30 Changeset [74755] by pfeldman@chromium.org

2010-12-29 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: extract Database & DOM Storage
agents; remove InspectorBackend.
https://bugs.webkit.org/show_bug.cgi?id=51707

This change brushes up storage agents + removes redundant
InspectorBackend class.

  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/CodeGeneratorInspector.pm:
  • inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::databaseForId): (WebCore::InjectedScriptHost::selectDatabase): (WebCore::InjectedScriptHost::selectDOMStorage): (WebCore::InjectedScriptHost::inspectorDOMAgent):
  • inspector/Inspector.idl:
  • inspector/InspectorBackend.cpp: Removed.
  • inspector/InspectorBackend.h: Removed.
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::~InspectorController): (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::releaseFrontendLifetimeAgents): (WebCore::InspectorController::didUseDOMStorage): (WebCore::InspectorController::setInjectedScriptSource): (WebCore::InspectorController::dispatchOnInjectedScript): (WebCore::InspectorController::releaseWrapperObjectGroup):
  • inspector/InspectorController.h:
  • inspector/InspectorDOMStorageAgent.cpp: Added. (WebCore::InspectorDOMStorageAgent::~InspectorDOMStorageAgent): (WebCore::InspectorDOMStorageAgent::getDOMStorageEntries): (WebCore::InspectorDOMStorageAgent::setDOMStorageItem): (WebCore::InspectorDOMStorageAgent::removeDOMStorageItem): (WebCore::InspectorDOMStorageAgent::selectDOMStorage): (WebCore::InspectorDOMStorageAgent::InspectorDOMStorageAgent): (WebCore::InspectorDOMStorageAgent::getDOMStorageResourceForId):
  • inspector/InspectorDOMStorageAgent.h: Copied from WebCore/inspector/InspectorStorageAgent.h. (WebCore::InspectorDOMStorageAgent::create): (WebCore::InspectorDOMStorageAgent::frontend):
  • inspector/InspectorDatabaseAgent.cpp: Renamed from WebCore/inspector/InspectorStorageAgent.cpp. (WebCore::InspectorDatabaseAgent::~InspectorDatabaseAgent): (WebCore::InspectorDatabaseAgent::getDatabaseTableNames): (WebCore::InspectorDatabaseAgent::executeSQL): (WebCore::InspectorDatabaseAgent::databaseForId): (WebCore::InspectorDatabaseAgent::selectDatabase): (WebCore::InspectorDatabaseAgent::clearFrontend): (WebCore::InspectorDatabaseAgent::InspectorDatabaseAgent):
  • inspector/InspectorDatabaseAgent.h: Renamed from WebCore/inspector/InspectorStorageAgent.h. (WebCore::InspectorDatabaseAgent::create): (WebCore::InspectorDatabaseAgent::frontend):
  • inspector/InspectorFrontendClientLocal.cpp:
  • inspector/InspectorFrontendClientLocal.h:
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.show):
13:24 Changeset [74754] by mihaip@chromium.org

2010-12-29 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium expectations update.
Add recent upstream expectations Chromium changes.

  • platform/chromium/test_expectations.txt:
12:49 Changeset [74753] by mihaip@chromium.org

2010-12-29 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium expectations update.
Mark http/tests/incremental/split-hex-entities.pl as flaky.

  • platform/chromium/test_expectations.txt:
12:39 Changeset [74752] by tonyg@chromium.org

2010-12-29 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Eric Seidel.

Assertion failure: element->inDocument() in AsyncScriptRunner::executeScriptSoon()
https://bugs.webkit.org/show_bug.cgi?id=51067

  • fast/dom/HTMLScriptElement/move-in-beforeload-expected.txt: Added.
  • fast/dom/HTMLScriptElement/move-in-beforeload.html: Added.
  • fast/dom/HTMLScriptElement/remove-in-beforeload-expected.txt: Added.
  • fast/dom/HTMLScriptElement/remove-in-beforeload.html: Added.

2010-12-29 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Eric Seidel.

Assertion failure: element->inDocument() in AsyncScriptRunner::executeScriptSoon()
https://bugs.webkit.org/show_bug.cgi?id=51067

Typically when a script element is removed from the document, the cached script
client is removed. However, during the before load event, the cached script client
hasn't been created yet so it can't be removed.

This patch handles that case by explicitly checking if the script element was
removed during the beforeload event. Also, it avoids caching the Document references
over the arbitrary script execution in the before load event.

Test: fast/dom/HTMLScriptElement/move-in-beforeload.html

fast/dom/HTMLScriptElement/remove-in-beforeload.html

  • dom/ScriptElement.cpp: (WebCore::ScriptElement::requestScript):
12:02 Changeset [74751] by mitz@apple.com

<rdar://problem/8758191> REGRESSION (r72887): Mail crashes when doing searches in a message due to method name conflict
https://bugs.webkit.org/show_bug.cgi?id=51717

Reviewed by Ada Chan.

Renamed -findString:options: to -_findString:options: in the WebDocumentOptionsSearching
protocol to avoid conflict with -[WebHTMLView(MailExtras) findString:options:] which Mail defines.

  • WebView/WebDocumentInternal.h:
  • WebView/WebHTMLView.mm:

(-[WebHTMLView searchFor:direction:caseSensitive:wrap:startInSelection:]):
(-[WebHTMLView _findString:options:]):

  • WebView/WebView.mm:

(findString):

11:20 Changeset [74750] by mihaip@chromium.org

2010-12-29 Mihai Parparita <mihaip@chromium.org>

Unreviewed, rolling out r74748.
http://trac.webkit.org/changeset/74748

r74735 was rolled out with r74749, the expectations update
should be rolled out too

  • platform/chromium-mac/fast/events/ime-composition-events-001-expected.txt: Added.
  • platform/chromium-win/fast/events/ime-composition-events-001-expected.txt: Added.
  • platform/chromium/fast/events/ime-composition-events-001-expected.txt: Removed.
11:13 Changeset [74749] by commit-queue@webkit.org

2010-12-29 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r74735.
http://trac.webkit.org/changeset/74735
https://bugs.webkit.org/show_bug.cgi?id=51715

assert failures on fast/forms/input-maxlength-ime-
completed.html (Requested by mihaip on #webkit).

  • platform/chromium/test_expectations.txt:

2010-12-29 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r74735.
http://trac.webkit.org/changeset/74735
https://bugs.webkit.org/show_bug.cgi?id=51715

assert failures on fast/forms/input-maxlength-ime-
completed.html (Requested by mihaip on #webkit).

  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::setMarkedText):
10:17 Changeset [74748] by mihaip@chromium.org

2010-12-29 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium baselines. Update Chromium baselines for
fast/events/ime-composition-events-001.html after r74735 (the
new baselines are closer to the upstream Mac ones).

  • platform/chromium-mac/fast/events/ime-composition-events-001-expected.txt: Removed.
  • platform/chromium-win/fast/events/ime-composition-events-001-expected.txt: Removed.
  • platform/chromium/fast/events/ime-composition-events-001-expected.txt: Added.
10:12 Changeset [74747] by mihaip@chromium.org

2010-12-29 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium baselines. Add Chromium baselines for the
layout test added by r74743.

  • platform/chromium-linux/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.checksum: Added.
  • platform/chromium-linux/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.png: Added.
  • platform/chromium-mac/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.checksum: Added.
  • platform/chromium-mac/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.png: Added.
  • platform/chromium-win/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.checksum: Added.
  • platform/chromium-win/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.png: Added.
  • platform/chromium-win/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt: Added.
10:03 Changeset [74746] by mrobinson@webkit.org

2010-12-29 Martin Robinson <mrobinson@igalia.com>

Reviewed by Ojan Vafai.

prepare-ChangeLog should support the -g option for specifying the git-commit
https://bugs.webkit.org/show_bug.cgi?id=51708

Add a -g shortcut for the --git-commit prepare-ChangeLog option. This matches
webkit-patch, though the exact meaning of the two options remain different.

  • Scripts/prepare-ChangeLog: Add -g.
10:01 Changeset [74745] by apavlov@chromium.org

2010-12-29 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Element highlight tooltip displays wrong element size when zoomed in
https://bugs.webkit.org/show_bug.cgi?id=51703

  • inspector/InspectorController.cpp: (WebCore::InspectorController::drawElementTitle):
08:00 Changeset [74744] by yael.aharon@nokia.com

[HTML5][Forms] Support for :in-range and :out-of-range CSS selectors
https://bugs.webkit.org/show_bug.cgi?id=29071

Reviewed by Kent Tamura.

WebCore:

Use InputType::rangeUnderflow() and InputType::rangeOverflow()
to determine if a control is in-range or out-of-range.

Tests: fast/css/pseudo-in-range-invalid-value.html

fast/css/pseudo-in-range.html
fast/css/pseudo-out-of-range.html

  • css/CSSSelector.cpp:

(WebCore::CSSSelector::pseudoId):
(WebCore::nameToPseudoTypeMap):
(WebCore::CSSSelector::extractPseudoType):

  • css/CSSSelector.h:
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::canShareStyleWithElement):
(WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):

  • dom/Element.h:

(WebCore::Element::isInRange):
(WebCore::Element::isOutOfRange):

  • html/BaseDateAndTimeInputType.cpp:

(WebCore::BaseDateAndTimeInputType::supportsRangeLimitation):

  • html/BaseDateAndTimeInputType.h:
  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::isInRange):
(WebCore::HTMLInputElement::isOutOfRange):

  • html/HTMLInputElement.h:
  • html/InputType.cpp:

(WebCore::InputType::supportsRangeLimitation):

  • html/InputType.h:
  • html/NumberInputType.cpp:

(WebCore::NumberInputType::supportsRangeLimitation):

  • html/NumberInputType.h:
  • html/RangeInputType.cpp:

(WebCore::RangeInputType::supportsRangeLimitation):

  • html/RangeInputType.h:

LayoutTests:

  • fast/css/pseudo-in-range-expected.txt: Added.
  • fast/css/pseudo-in-range-invalid-value-expected.txt: Added.
  • fast/css/pseudo-in-range-invalid-value.html: Added.
  • fast/css/pseudo-in-range.html: Added.
  • fast/css/pseudo-out-of-range-expected.txt: Added.
  • fast/css/pseudo-out-of-range.html: Added.
  • fast/css/script-tests/pseudo-in-range-invalid-value.js: Added.
  • fast/css/script-tests/pseudo-in-range.js: Added.
  • fast/css/script-tests/pseudo-out-of-range.js: Added.
07:50 Changeset [74743] by inferno@chromium.org

2010-12-29 Abhishek Arya <inferno@chromium.org>

Reviewed by Eric Seidel.

When cloning an anonymous block, make sure to set the childrenInline flag based
on the state of the block to be cloned.
https://bugs.webkit.org/show_bug.cgi?id=51489

Test: fast/multicol/span/clone-anonymous-block-non-inline-child-crash.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::clone): add code to handle cloning of anonymous blocks. (WebCore::RenderBlock::splitBlocks): remove anonymous block creation calls since it is now handled by clone().

2010-12-29 Abhishek Arya <inferno@chromium.org>

Reviewed by Eric Seidel.

Tests that cloning an anonymous block with non inline children does not crash.
https://bugs.webkit.org/show_bug.cgi?id=51489

  • fast/multicol/span/clone-anonymous-block-non-inline-child-crash.html: Added.
  • platform/mac/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.checksum: Added.
  • platform/mac/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.png: Added.
  • platform/mac/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt: Added.
07:38 Changeset [74742] by paroga@webkit.org

2010-12-29 Patrick Gansterer <paroga@webkit.org>

Unreviewed build fix for WinCE after r73802.

Reapply parts from r72585:
Port ContextMenuWin.cpp to WinCE
https://bugs.webkit.org/show_bug.cgi?id=48408

  • CMakeLists.txt:
  • platform/ContextMenu.h:
  • platform/win/ContextMenuWin.cpp: (WebCore::ContextMenu::getContextMenuItems): (WebCore::ContextMenu::createNativeMenuFromItems):

2010-12-29 Patrick Gansterer <paroga@webkit.org>

Unreviewed build fix for WinCE after r73802.

  • WebCoreSupport/ContextMenuClientWinCE.cpp: (WebKit::ContextMenuClientWinCE::customizeMenu):
  • WebCoreSupport/ContextMenuClientWinCE.h:
05:39 Changeset [74741] by kent.hansen@nokia.com

2010-12-29 Kent Hansen <kent.hansen@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Fix compilation with Qt in namespace
https://bugs.webkit.org/show_bug.cgi?id=51701

  • QtTestBrowser/webview.h:

2010-12-29 Kent Hansen <kent.hansen@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Fix compilation with Qt in namespace
https://bugs.webkit.org/show_bug.cgi?id=51701

  • platform/graphics/ContextShadow.h:
  • platform/graphics/GraphicsContext3D.h:
  • platform/network/NetworkingContext.h:
  • platform/network/qt/QtNAMThreadSafeProxy.h:
  • plugins/PluginView.h:

2010-12-29 Kent Hansen <kent.hansen@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Fix compilation with Qt in namespace
https://bugs.webkit.org/show_bug.cgi?id=51701

  • Api/qwebkitplatformplugin.h:
  • WebCoreSupport/InspectorServerQt.h:
  • tests/hybridPixmap/widget.h:
04:41 Fingerprinting edited by robert@roberthogan.net
(diff)
03:53 Changeset [74740] by apavlov@chromium.org

2010-12-28 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: A disabled style property should get enabled when edited
https://bugs.webkit.org/show_bug.cgi?id=51679

  • inspector/styles-disable-then-change-expected.txt: Added.
  • inspector/styles-disable-then-change.html: Added.

2010-12-28 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: A disabled style property should get enabled when edited
https://bugs.webkit.org/show_bug.cgi?id=51679

Test: inspector/styles-disable-then-change.html

  • inspector/front-end/CSSStyleModel.js: (WebInspector.CSSProperty.prototype.setText): (WebInspector.CSSProperty.prototype.setText.callback):
03:35 Changeset [74739] by paroga@webkit.org

2010-12-29 Patrick Gansterer <paroga@webkit.org>

Unreviewed. Use gcc as default preprocessor.

  • Sources/cmake/OptionsCommon.cmake:

2010-12-29 Patrick Gansterer <paroga@webkit.org>

Reviewed by Andreas Kling.

[CMake] Remove WebKitGenerators
https://bugs.webkit.org/show_bug.cgi?id=50445

  • CMakeLists.txt: Pass preprocessor to generate-bindings.pl.
03:22 Changeset [74738] by commit-queue@webkit.org

2010-12-29 Juha Savolainen <juha.savolainen@weego.fi>

Reviewed by Kenneth Rohde Christiansen.

[Qt] [WK2] Added more webattributes to the qwkpreferences
https://bugs.webkit.org/show_bug.cgi?id=51697

Added PrivateBrowsingEnabled, DeveloperExtrasEnabled, DnsPrefetchEnabled attributes

  • UIProcess/API/qt/qwkpreferences.cpp: (QWKPreferences::testAttribute): (QWKPreferences::setAttribute):
  • UIProcess/API/qt/qwkpreferences.h:
01:32 Changeset [74737] by commit-queue@webkit.org

2010-12-29 Helder Correia <helder@sencha.com>

Reviewed by Eric Seidel.

<VT> and <FF> are not valid JSON whitespace characters
https://bugs.webkit.org/show_bug.cgi?id=51671

Vertical Tab and Form Feed are not allowed white spaces by the JSON
RFC 4627: http://www.ietf.org/rfc/rfc4627.txt (2. JSON Grammar).

Tests: ietestcenter/Javascript/15.12.1.1-0-2.html

ietestcenter/Javascript/15.12.1.1-0-3.html

  • runtime/LiteralParser.cpp: (JSC::isJSONWhiteSpace): (JSC::LiteralParser::Lexer::lex):

2010-12-29 Helder Correia <helder@sencha.com>

Reviewed by Eric Seidel.

<VT> and <FF> are not valid JSON whitespace characters
https://bugs.webkit.org/show_bug.cgi?id=51671

Vertical Tab and Form Feed are not allowed white spaces by the JSON
RFC 4627: http://www.ietf.org/rfc/rfc4627.txt (2. JSON Grammar).

  • ietestcenter/Javascript/15.12.1.1-0-2-expected.txt:
  • ietestcenter/Javascript/15.12.1.1-0-3-expected.txt:
01:30 Changeset [74736] by philn@webkit.org

2010-12-29 Philippe Normand <pnormand@igalia.com>

Unreviewed, skip flaky test on GTK.

[GTK] editing/selection/extend-by-character-004.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=51699

  • platform/gtk/Skipped:
01:22 Changeset [74735] by commit-queue@webkit.org

2010-12-29 Zhe Su <suzhe@chromium.org>

Reviewed by Eric Seidel.

Remove entry for editing/input/ime-composition-clearpreedit.html test.
https://bugs.webkit.org/show_bug.cgi?id=51693

  • platform/chromium/test_expectations.txt:

2010-12-29 Zhe Su <suzhe@chromium.org>

Reviewed by Eric Seidel.

Fix editing/input/ime-composition-clearpreedit.html test in chromium
by removing the line "editor->confirmComposition(text);" from
WebFrameImpl::setMarkedText() method, because that line will insert the
text into the focused node, which is apparently wrong.

https://bugs.webkit.org/show_bug.cgi?id=51693

  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::setMarkedText):

12/28/10:

23:45 Changeset [74734] by commit-queue@webkit.org

2010-12-28 Pratik Solanki <psolanki@apple.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=51522
Use deviceRGBColorSpaceRef() instead of calling CGColorSpaceCreateDeviceRGB()

  • page/win/FrameCGWin.cpp: (WebCore::imageFromRect):
  • platform/graphics/cg/GradientCG.cpp: (WebCore::Gradient::platformGradient):
  • platform/graphics/cg/GraphicsContext3DCG.cpp: (WebCore::GraphicsContext3D::paintToCanvas):
  • platform/graphics/cg/ImageCG.cpp: (WebCore::BitmapImage::checkForSolidColor):
  • platform/graphics/gstreamer/ImageGStreamerCG.mm: (ImageGStreamer::ImageGStreamer):
  • platform/graphics/win/GraphicsContextCGWin.cpp: (WebCore::CGContextWithHDC): (WebCore::GraphicsContext::releaseWindowsContext): (WebCore::GraphicsContext::drawWindowsBitmap):
  • platform/graphics/win/ImageCGWin.cpp: (WebCore::BitmapImage::create): (WebCore::BitmapImage::getHBITMAPOfSize):
  • platform/image-decoders/cg/ImageDecoderCG.cpp: (WebCore::createColorSpace):
  • platform/win/DragImageCGWin.cpp: (WebCore::allocImage): (WebCore::createCgContextFromBitmap):
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintMenuListButtonGradients): (WebCore::RenderThemeMac::paintSliderTrack):
  • rendering/RenderThemeSafari.cpp: (WebCore::RenderThemeSafari::paintMenuListButtonGradients): (WebCore::RenderThemeSafari::paintSliderTrack):
16:59 Changeset [74733] by dbates@webkit.org

2010-12-28 Daniel Bates <dbates@rim.com>

Reviewed by Sam Weinig.

Substitute MARK: for compiler-specific #pragma mark
https://bugs.webkit.org/show_bug.cgi?id=51657

For consistency, we should substitute " MARK:" for compiler-
specific "#pragma mark" in the source files for the Mac port.

  • History/WebHistory.mm:
  • Plugins/WebBaseNetscapePluginView.mm:
  • Plugins/WebNetscapePluginView.mm:
  • WebCoreSupport/WebInspectorClient.mm:
  • WebCoreSupport/WebSecurityOrigin.mm:
  • WebView/WebPDFView.mm:
  • WebView/WebVideoFullscreenController.mm:
  • WebView/WebVideoFullscreenHUDWindowController.mm:

2010-12-28 Daniel Bates <dbates@rim.com>

Reviewed by Sam Weinig.

Substitute MARK: for compiler-specific #pragma mark
https://bugs.webkit.org/show_bug.cgi?id=51657

Fix compilation warnings about "#pragma mark" on GTK+ bots by
substituting " MARK:" for "#pragma mark", which provides
analogous code-bookmarking functionality under Xcode.

  • platform/graphics/cg/PathCG.cpp:
  • platform/graphics/mac/WebLayer.mm:

2010-12-28 Daniel Bates <dbates@rim.com>

Reviewed by Sam Weinig.

Substitute MARK: for compiler-specific #pragma mark
https://bugs.webkit.org/show_bug.cgi?id=51657

Fix future compilation warnings about "#pragma mark" on GTK+ bots by
substituting " MARK:" for "#pragma mark", which provides
analogous code-bookmarking functionality under Xcode.

Also, for consistency, we should substitute " MARK:" for compiler-
specific "#pragma mark" in the source files for the Mac port.

  • DumpRenderTree/AccessibilityTextMarker.cpp:
  • DumpRenderTree/cf/WebArchiveDumpSupport.h:
  • DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
  • DumpRenderTree/mac/ObjCController.m:
  • MiniBrowser/mac/AppDelegate.m:
  • MiniBrowser/mac/BrowserWindowController.m:
16:56 Changeset [74732] by dbates@webkit.org

2010-12-28 Daniel Bates <dbates@rim.com>

Reviewed by Antonio Gomes.

Add comment to test case fast/repaint/no-caret-repaint-in-non-content-editable-element.html
to clarify caret browsing disabled
https://bugs.webkit.org/show_bug.cgi?id=51633

Add a comment to test case fast/repaint/no-caret-repaint-in-non-content-editable-element.html
that explains that this test is only applicable when caret browsing is disabled.

  • fast/repaint/no-caret-repaint-in-non-content-editable-element.html:
16:39 Changeset [74731] by mrobinson@webkit.org

2010-12-28 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Closing a window during an onload event can trigger serious GLib warnings
https://bugs.webkit.org/show_bug.cgi?id=51686

Don't emit the close-web-view signal immediately during execution of closeWindowSoon.
The signal handler may choose to destroy the web view while handling that signal,
which may remove the last reference to the web view. FrameLoaderClient depends on the
view still existing though. Instead, let the caller finish executing and emit the signal
after a 0 length timeout. This matches the behavior on the Windows and Mac ports.

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::ChromeClient): Initialize the timer id. (WebKit::emitCloseWebViewSignalLater): Callback for the timer. (WebKit::ChromeClient::closeWindowSoon): Do the actual signal invocation after the caller finishes its tasks.
  • WebCoreSupport/ChromeClientGtk.h: Add a new member for the timer id. We can use this to prevent emitting the close-web-view signal twice.
15:39 Changeset [74730] by mrobinson@webkit.org

2010-12-28 Martin Robinson <mrobinson@igalia.com>

Reviewed by Eric Seidel.

[GTK] Clean up usage of NULL in webkitwebframe.cpp
https://bugs.webkit.org/show_bug.cgi?id=51685

Replace occurrences of NULL with 0, in webkitwebframe.cpp. Not all
uses of NULL have been changed, as certain GLib functions require
an explicit NULL as a sentinel.

  • webkit/webkitwebframe.cpp: (webkit_web_frame_get_data_source_from_core_loader): (webkit_web_frame_class_init): (webkit_web_frame_new): (webkit_web_frame_get_title): (webkit_web_frame_get_uri): (webkit_web_frame_get_web_view): (webkit_web_frame_get_name): (webkit_web_frame_get_parent): (webkit_web_frame_load_string): (webkit_web_frame_load_alternate_string): (webkit_web_frame_find_frame): (webkit_web_frame_get_global_context): (webkit_web_frame_get_data_source): (webkit_web_frame_get_provisional_data_source): (webkit_web_frame_print_full): (webkit_web_frame_get_security_origin): (webkit_web_frame_get_network_response):
15:16 Changeset [74729] by kbr@google.com

2010-12-28 Kenneth Russell <kbr@google.com>

Reviewed by Eric Seidel.

Make fast/canvas/canvas-save-restore-with-path.js more robust
https://bugs.webkit.org/show_bug.cgi?id=51665

  • fast/canvas/canvas-save-restore-with-path-expected.txt:
  • fast/canvas/canvas-save-restore-with-path.js:
14:56 Changeset [74728] by commit-queue@webkit.org

2010-12-28 Jan Erik Hanssen <jhanssen@sencha.com>

Reviewed by Eric Seidel.

[Qt] GraphicsContext::getCTM() does not need to make a copy of QPainter::combinedTransform()
https://bugs.webkit.org/show_bug.cgi?id=51687

Use a const reference instead of a copy of QPainter::combinedTransform()
in GraphicsContext::getCTM()

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::getCTM):
14:45 Changeset [74727] by commit-queue@webkit.org

2010-12-28 Helder Correia <helder@sencha.com>

Reviewed by Eric Seidel.

JSON.stringify must exist as a function taking 3 parameters
https://bugs.webkit.org/show_bug.cgi?id=51667

The reported function length is 1 instead.

Test: ietestcenter/Javascript/15.12.3-0-2.html

  • runtime/JSONObject.cpp:

2010-12-28 Helder Correia <helder@sencha.com>

Reviewed by Eric Seidel.

JSON.stringify must exist as a function taking 3 parameters
https://bugs.webkit.org/show_bug.cgi?id=51667

The reported function length is 1 instead.

  • ietestcenter/Javascript/15.12.3-0-2-expected.txt:
14:20 Changeset [74726] by commit-queue@webkit.org

2010-12-28 Xan Lopez <xlopez@igalia.com>

Reviewed by Eric Seidel.

Add --no-build option to run-sunspider
https://bugs.webkit.org/show_bug.cgi?id=51658

  • Scripts/run-sunspider: add --no-build flag to skip building phase.
14:16 Fingerprinting edited by robert@roberthogan.net
(diff)
14:14 Changeset [74725] by commit-queue@webkit.org

2010-12-28 Takashi Toyoshima <toyoshim@google.com>

Reviewed by Eric Seidel.

gcc detected 'control reaches end of non-void function' with
-finstrument-functions option.
https://bugs.webkit.org/show_bug.cgi?id=51669

No new tests. These fixes are trivial.

  • dom/Element.cpp: (WebCore::Element::childTypeAllowed):
  • inspector/InspectorResourceAgent.cpp: (WebCore::cachedResourceTypeString):
14:11 Fingerprinting created by robert@roberthogan.net
13:57 Changeset [74724] by tonyg@chromium.org

2010-12-28 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Eric Seidel.

Remove unused member of PendingScript
https://bugs.webkit.org/show_bug.cgi?id=51684

This was used when HTMLScriptRunner::runScript created a PendingScript
for inline scripts. But now it just calls executeScript() directly.
External scripts always have the minimum starting line number.

No new tests because no changed functionality.

  • dom/PendingScript.cpp: (WebCore::PendingScript::releaseElementAndClear):
  • dom/PendingScript.h: (WebCore::PendingScript::PendingScript): (WebCore::PendingScript::operator=):
  • html/parser/HTMLScriptRunner.cpp: (WebCore::HTMLScriptRunner::sourceFromPendingScript):
13:57 Changeset [74723] by tonikitoo@webkit.org

2010-12-20 Antonio Gomes <agomes@rim.com>

Reviewed by Daniel Bates.

Spatial Navigation: code clean up (Part VI)
https://bugs.webkit.org/show_bug.cgi?id=50666

No new tests needed.

  • page/FocusController.cpp: (WebCore::updatFocusCandidateIfNeeded): Assert renderer() and isElementNode() now that we are bailing out earlier in both the FocusCandidate constructor and FocusController::findFocusCandidateInContainer().
  • page/SpatialNavigation.h: Swapped the parameters order in canScrollInDirection and virtualRectForAreaElementAndDirection functions. (WebCore::FocusController::findFocusCandidateInContainer): (WebCore::FocusController::advanceFocusDirectionallyInContainer): Adjusted call sites of canScrollInDirection(), and added an early return if !isElementNode(). (WebCore::FocusController::advanceFocusDirectionally): Adjusted call site of virtualRectForAreaElementAndDirection().
  • page/SpatialNavigation.cpp: (WebCore::FocusCandidate::FocusCandidate): Assert if node is not an Element node. (WebCore::isScrollableNode): Renamed from isScrollableContainerNode. (WebCore::scrollInDirection): Adjusted call site after function name change; (WebCore::scrollableEnclosingBoxOrParentFrameForNodeInDi:rection): Assert if node is a Document node. (WebCore::canScrollInDirection): Signature changed. (WebCore::canBeScrolledIntoView): Ditto. (WebCore::virtualRectForAreaElementAndDirection): Ditto.
13:53 Changeset [74722] by enne@google.com

2010-12-28 Adrienne Walker <enne@google.com>

Reviewed by Kenneth Russell.

[chromium] Fix tiled compositor assertion after GPU process recovery.
https://bugs.webkit.org/show_bug.cgi?id=51682

After the GPU process recovers, the layer size is set to IntSize(),
but IntRect::unite() has a special case for empty rects. This
behavior was causing the layer size to be too small, causing an
out-of-bounds array access elsewhere.

No new tests.

  • platform/graphics/chromium/LayerTilerChromium.cpp: (WebCore::LayerTilerChromium::growLayerToContain):
13:36 Changeset [74721] by commit-queue@webkit.org

2010-12-28 Helder Correia <helder@sencha.com>

Reviewed by Sam Weinig.

JSON.parse must exist as a function taking 2 parameters
https://bugs.webkit.org/show_bug.cgi?id=51666

Support for revivers was introduced in bug 26591, but the function
length has since remained unchanged.

Test: ietestcenter/Javascript/15.12.2-0-2.html

  • runtime/JSONObject.cpp:

2010-12-28 Helder Correia <helder@sencha.com>

Reviewed by Sam Weinig.

JSON.parse must exist as a function taking 2 parameters
https://bugs.webkit.org/show_bug.cgi?id=51666

Support for revivers was introduced in bug 26591, but the function
length has since remained unchanged.

  • ietestcenter/Javascript/15.12.2-0-2-expected.txt: Change expected result to success.
13:35 Changeset [74720] by zmo@google.com

2010-12-23 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Initialize to 0 for undefined values in CopyTexImage2D
https://bugs.webkit.org/show_bug.cgi?id=51421

  • src/GraphicsContext3DChromium.cpp: Implement getInternalFramebufferSize(). (WebCore::GraphicsContext3DInternal::getInternalFramebufferSize):
  • src/GraphicsContext3DInternal.h:

2010-12-23 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Initialize to 0 for undefined values in CopyTexImage2D
https://bugs.webkit.org/show_bug.cgi?id=51421

  • html/canvas/WebGLFramebuffer.cpp: Track width/height/internalFormat of color buffer. (WebCore::WebGLFramebuffer::WebGLFramebuffer): (WebCore::WebGLFramebuffer::setAttachment): (WebCore::WebGLFramebuffer::getWidth): (WebCore::WebGLFramebuffer::getHeight): (WebCore::WebGLFramebuffer::getColorBufferFormat):
  • html/canvas/WebGLFramebuffer.h:
  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::copyTexImage2D): Initialize undefined pixels to 0. (WebCore::WebGLRenderingContext::copyTexSubImage2D): (WebCore::WebGLRenderingContext::framebufferTexture2D): (WebCore::WebGLRenderingContext::renderbufferStorage): (WebCore::WebGLRenderingContext::getBoundFramebufferWidth): (WebCore::WebGLRenderingContext::getBoundFramebufferHeight):
  • html/canvas/WebGLRenderingContext.h:
  • html/canvas/WebGLTexture.cpp: Track width/height/internalFormat of a texture by target/level. (WebCore::WebGLTexture::getInternalFormat): (WebCore::WebGLTexture::getWidth): (WebCore::WebGLTexture::getHeight): (WebCore::WebGLTexture::mapTargetToIndex): (WebCore::WebGLTexture::getLevelInfo):
  • html/canvas/WebGLTexture.h: (WebCore::WebGLTexture::isTexture):
  • platform/graphics/GraphicsContext3D.h: Add getInternalFramebufferSize() function.
  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp: (WebCore::GraphicsContext3D::getInternalFramebufferSize):
  • platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3D::getInternalFramebufferSize):

2010-12-23 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Initialize to 0 for undefined values in CopyTexImage2D
https://bugs.webkit.org/show_bug.cgi?id=51421

  • fast/canvas/webgl/uninitialized-test-expected.txt: Add test cases for copyTexImage2D.
  • fast/canvas/webgl/uninitialized-test.html: Ditto.
13:26 Changeset [74719] by zmo@google.com

2010-12-23 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Map GLsizei to long instead of unsigned long in WebGLRenderingContext and GraphicsContext3D
https://bugs.webkit.org/show_bug.cgi?id=39855

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::copyTexImage2D): Map GLsizei to long. (WebCore::WebGLRenderingContext::copyTexSubImage2D): Ditto. (WebCore::WebGLRenderingContext::renderbufferStorage): Ditto. (WebCore::WebGLRenderingContext::scissor): Ditto. (WebCore::WebGLRenderingContext::texImage2DBase): Ditto. (WebCore::WebGLRenderingContext::texImage2D): Ditto. (WebCore::WebGLRenderingContext::texSubImage2DBase): Ditto. (WebCore::WebGLRenderingContext::texSubImage2DImpl): Ditto. (WebCore::WebGLRenderingContext::texSubImage2D): Ditto. (WebCore::WebGLRenderingContext::viewport): Ditto. (WebCore::WebGLRenderingContext::validateSize): Check the sizes are non-negative.
  • html/canvas/WebGLRenderingContext.h:
  • html/canvas/WebGLRenderingContext.idl:

2010-12-28 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Map GLsizei to long instead of unsigned long in WebGLRenderingContext and GraphicsContext3D
https://bugs.webkit.org/show_bug.cgi?id=39855

  • fast/canvas/webgl/invalid-passed-params-expected.txt: Add test cases for negative offset/width/height.
  • fast/canvas/webgl/invalid-passed-params.html: Ditto.
12:01 Changeset [74718] by kbr@google.com

2010-12-28 Kenneth Russell <kbr@google.com>

Unreviewed, Chromium test expectations update. Mark
fast/forms/input-text-paste-maxlength.html as a flaky crash on
Linux Release as well as Debug.

  • platform/chromium/test_expectations.txt:
11:36 Changeset [74717] by kbr@google.com

2010-12-28 Kenneth Russell <kbr@google.com>

Unreviewed, Chromium test expectations update.

Marked inspector/styles-source-lines.html as a flaky failure on
Win Debug and
http/tests/inspector/extensions-resources-redirect.html as a flaky
timeout on Win Release.

  • platform/chromium/test_expectations.txt:
11:18 Changeset [74716] by inferno@chromium.org

2010-12-28 Abhishek Arya <inferno@chromium.org>

Reviewed by Kenneth Russell.

Fix crash with invalid font in m_fontList by not drawing text when a custom font is in the
process of loading.
https://bugs.webkit.org/show_bug.cgi?id=51681

Test: canvas/philip/tests/2d.text-custom-font-load-crash.html

  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::drawTextInternal): bail out if a custom font is loading.
  • platform/graphics/Font.cpp: (WebCore::Font::operator==): Replace condition with new function loadingCustomFonts() (WebCore::Font::drawText): Replace condition with new function loadingCustomFonts() (WebCore::Font::drawEmphasisMarks): Replace condition with new function loadingCustomFonts()
  • platform/graphics/Font.h: (WebCore::Font::loadingCustomFonts): new function that returns if a custom font is loading.

2010-12-28 Abhishek Arya <inferno@chromium.org>

Reviewed by Kenneth Russell.

Tests that we do not crash when drawing text during custom font load.
https://bugs.webkit.org/show_bug.cgi?id=51681

  • canvas/philip/tests/2d.text-custom-font-load-crash-expected.txt: Added.
  • canvas/philip/tests/2d.text-custom-font-load-crash.html: Added.
10:55 Changeset [74715] by dglazkov@chromium.org

2010-12-28 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Eric Seidel.

Combine setShadowRoot and clearShadowRoot into a simpler API
https://bugs.webkit.org/show_bug.cgi?id=50971

No change in behavior, and API is not used yet.

  • dom/Element.cpp: (WebCore::Element::setShadowRoot): Combined clearing and setting of

the shadowRoot, also hooked up with setting and clearing of the
corresponding shadowHost values.

  • dom/Element.h: renamed clearShadowRoot to removeShadowRoot and made it

private.

  • dom/Node.h: Made shadow host-related functions public so that

Element::setShadowRoot can access setShadowHost. It seems logical
to make shadowHost public as well to keep the defs together.

10:11 Changeset [74714] by caseq@chromium.org

2010-12-28 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Chromium] Expose extension API to select a node in WebInspector
Do not request content for resources with non-numeric identifiers.
https://bugs.webkit.org/show_bug.cgi?id=49727

Test: http/tests/inspector/extensions-resources-redirect.html

  • inspector/front-end/NetworkManager.js: (WebInspector.NetworkManager.prototype._appendRedirect):

2010-12-28 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Chromium] Expose extension API to select a node in WebInspector
Do not request content for resources with non-numeric identifiers.
https://bugs.webkit.org/show_bug.cgi?id=49727

  • http/tests/inspector/extensions-resources-redirect-expected.txt: Added.
  • http/tests/inspector/extensions-resources-redirect.html: Added.
  • http/tests/inspector/extensions-resources-test.js: Added. (extension_getResourceByUrl.onHAR): (extension_getResourceByUrl):
  • inspector/extensions-resources-expected.txt:
  • inspector/extensions-resources.html:
  • platform/mac-leopard/inspector/extensions-resources-expected.txt:
09:58 Changeset [74713] by loislo@chromium.org

2010-12-28 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed build fix for Qt.

ResourceTreeModel.js was added.

  • inspector/front-end/WebKit.qrc:
09:24 Changeset [74712] by mnaganov@chromium.org

2010-12-28 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Pavel Feldman.

[Chromium] Fix memory leak in Profiles tab concerned with heap profiles views.

https://bugs.webkit.org/show_bug.cgi?id=51680

  • inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype._reset):
07:55 Changeset [74711] by kbr@google.com

2010-12-28 Kenneth Russell <kbr@google.com>

Unreviewed, Chromium test expectations update. Coalesce WebGL
expectations for chromium-gpu platform and fix duplicate
expectation for gl-object-get-calls.html accidentally introduced
on Windows Debug.

  • platform/chromium-gpu/test_expectations.txt:
07:32 Changeset [74710] by apavlov@chromium.org

2010-12-28 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: REGRESSION: Clicking image resource in style sidebar doesn't actually go to resource anymore
https://bugs.webkit.org/show_bug.cgi?id=51663

  • inspector/elements-tests2.js: (initialize_ElementTest.InspectorTest.dumpSelectedElementStyles): Drive-by: remove bad test exit code.
  • inspector/resources/styles-url-linkify-iframe.html: Added.
  • inspector/resources/styles-url-linkify.css: Added. (#local):
  • inspector/styles-url-linkify-expected.txt: Added.
  • inspector/styles-url-linkify.html: Added.

2010-12-28 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: REGRESSION: Clicking image resource in style sidebar doesn't actually go to resource anymore
https://bugs.webkit.org/show_bug.cgi?id=51663

The base URI is now computed correctly for links from CSS property uri(...) values. Additionally,
optional quotes/apostrophes and spaces are now allowed inside uri(...).

Test: inspector/styles-url-linkify.html

  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertyTreeElement.prototype.updateTitle.linkifyURL): (WebInspector.StylePropertyTreeElement.prototype.updateTitle):
07:11 Changeset [74709] by loislo@chromium.org

2010-12-21 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Protocol cleanup task. Introduce Network, DOMStorage and Database domains.

Domain was changed for Resources, FileSystem etc. related methods.
ResourcesManager was renamed to NetworkManager.
ResourceTreeModel was extracted as separate file.
FileSystem, Database, DOMStorage and ApplicationCache methods were
removed from NetworkManager and added to corresponding classes.

https://bugs.webkit.org/show_bug.cgi?id=51334

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/CodeGeneratorInspector.pm:
  • inspector/Inspector.idl:
  • inspector/front-end/AuditRules.js: (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback.selectorsCallback):
  • inspector/front-end/CSSStyleModel.js: (WebInspector.CSSStyleModel.prototype._styleSheetChanged.callback): (WebInspector.CSSStyleModel.prototype._styleSheetChanged):
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.addMessage): (WebInspector.ConsoleView.prototype.clearMessages):
  • inspector/front-end/DOMAgent.js: (WebInspector.ApplicationCache.updateApplicationCacheStatus): (WebInspector.ApplicationCache.updateNetworkState):
  • inspector/front-end/DOMStorage.js: (WebInspector.DOMStorage.addDOMStorage): (WebInspector.DOMStorage.selectDOMStorage): (WebInspector.DOMStorage.updateDOMStorage):
  • inspector/front-end/Database.js: (WebInspector.Database.prototype.executeSql): (WebInspector.Database.addDatabase): (WebInspector.Database.selectDatabase): (WebInspector.Database.sqlTransactionSucceeded): (WebInspector.Database.sqlTransactionFailed):
  • inspector/front-end/FileSystemView.js: (WebInspector.FileSystem.didGetFileSystemPath): (WebInspector.FileSystem.didGetFileSystemError): (WebInspector.FileSystem.didGetFileSystemDisabled):
  • inspector/front-end/NetworkItemView.js: (WebInspector.NetworkItemView):
  • inspector/front-end/NetworkManager.js: Added. (WebInspector.NetworkManager): (WebInspector.NetworkManager.prototype._createResource): (WebInspector.NetworkManager.prototype.identifierForInitialRequest): (WebInspector.NetworkManager.prototype.willSendRequest): (WebInspector.NetworkManager.prototype._updateResourceWithRequest): (WebInspector.NetworkManager.prototype._appendRedirect): (WebInspector.NetworkManager.prototype.markResourceAsCached): (WebInspector.NetworkManager.prototype.didReceiveResponse): (WebInspector.NetworkManager.prototype._updateResourceWithResponse): (WebInspector.NetworkManager.prototype.didReceiveContentLength): (WebInspector.NetworkManager.prototype.didFinishLoading): (WebInspector.NetworkManager.prototype.didFailLoading): (WebInspector.NetworkManager.prototype.didLoadResourceFromMemoryCache): (WebInspector.NetworkManager.prototype._updateResourceWithCachedResource): (WebInspector.NetworkManager.prototype.setInitialContent): (WebInspector.NetworkManager.prototype.didCommitLoadForFrame): (WebInspector.NetworkManager.prototype.frameDetachedFromParent): (WebInspector.NetworkManager.prototype.didCreateWebSocket): (WebInspector.NetworkManager.prototype.willSendWebSocketHandshakeRequest): (WebInspector.NetworkManager.prototype.didReceiveWebSocketHandshakeResponse): (WebInspector.NetworkManager.prototype.didCloseWebSocket): (WebInspector.NetworkManager.prototype._processCachedResources): (WebInspector.NetworkManager.prototype._addFramesRecursively): (WebInspector.NetworkManager.requestContent):
  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype.refreshResource):
  • inspector/front-end/Resource.js: (WebInspector.Resource.prototype._innerRequestContent):
  • inspector/front-end/ResourceManager.js: Removed.
  • inspector/front-end/ResourceTreeModel.js: Added. (WebInspector.ResourceTreeModel): (WebInspector.ResourceTreeModel.prototype.addOrUpdateFrame): (WebInspector.ResourceTreeModel.prototype.didCommitLoadForFrame): (WebInspector.ResourceTreeModel.prototype.frameDetachedFromParent): (WebInspector.ResourceTreeModel.prototype._clearChildFramesAndResources): (WebInspector.ResourceTreeModel.prototype.addResourceToFrame): (WebInspector.ResourceTreeModel.prototype._clearResources): (WebInspector.ResourceTreeModel.prototype.forAllResources): (WebInspector.ResourceTreeModel.prototype.addConsoleMessage): (WebInspector.ResourceTreeModel.prototype.clearConsoleMessages): (WebInspector.ResourceTreeModel.prototype._callForFrameResources): (WebInspector.ResourceTreeModel.prototype.resourceForURL): (WebInspector.ResourceTreeModel.prototype.bindResourceURL): (WebInspector.ResourceTreeModel.prototype._unbindResourceURL): (WebInspector.ResourceTreeModel.createResource):
  • inspector/front-end/ResourceView.js: (WebInspector.ResourceView.createResourceView): (WebInspector.ResourceView.resourceViewTypeMatchesResource): (WebInspector.ResourceView.resourceViewForResource): (WebInspector.ResourceView.recreateResourceView): (WebInspector.ResourceView.existingResourceViewForResource):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.canShowSourceLine): (WebInspector.ResourcesPanel.prototype.showSourceLine): (WebInspector.ResourcesPanel.prototype.showResource): (WebInspector.ResourcesPanel.prototype.get searchableViews.callback): (WebInspector.ResourcesPanel.prototype.get searchableViews): (WebInspector.FrameResourceTreeElement.prototype._errorsWarningsUpdated): (WebInspector.FrameResourceTreeElement.prototype._contentChanged):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._addScript): (WebInspector.ScriptsPanel.prototype.reset): (WebInspector.ScriptsPanel.prototype._sourceFrameForResource): (WebInspector.ScriptsPanel.prototype._showScriptOrResource):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js: (WebInspector.forAllResources): (WebInspector.resourceForURL):

12/27/10:

21:33 Changeset [74708] by commit-queue@webkit.org

2010-12-27 Helder Correia <helder@sencha.com>

Reviewed by Ariya Hidayat.

ContextShadow should use AffineTransform instead of TransformationMatrix
https://bugs.webkit.org/show_bug.cgi?id=51661

ContextShadow needs the CTM to make sure shadows are not affected by
transformations when drawing on a canvas. AffineTransform is sufficient
in this case.

Existing tests: fast/canvas/canvas*shadow*html

  • platform/graphics/ContextShadow.cpp: (WebCore::ContextShadow::mustUseContextShadow): (WebCore::ContextShadow::adjustBlurDistance): (WebCore::ContextShadow::calculateLayerBoundingRect):
  • platform/graphics/ContextShadow.h:
  • platform/graphics/cairo/ContextShadowCairo.cpp: (WebCore::ContextShadow::getTransformationMatrixFromContext):
  • platform/graphics/qt/ContextShadowQt.cpp: (WebCore::ContextShadow::getTransformationMatrixFromContext):
21:15 Changeset [74707] by commit-queue@webkit.org

2010-12-27 Ryuan Choi <ryuan.choi@samsung.com>

Reviewed by David Levin.

[EFL] Change path of eflsymbols.filter
https://bugs.webkit.org/show_bug.cgi?id=51659

  • Sources/cmake/OptionsEfl.cmake:
18:05 Changeset [74706] by dbates@webkit.org

2010-12-27 Daniel Bates <dbates@rim.com>

Rubber-stamped by Martin Robinson.

Append the directory Tools/DumpRenderTree to the list of directories that
do-webcore-rename should search so that it can rename DRT files and
source code.

  • Scripts/do-webcore-rename:
17:40 Changeset [74705] by mrobinson@webkit.org

2010-12-27 Martin Robinson <mrobinson@igalia.com>

Reviewed by Daniel Bates.

Try to fix my previous commit for Mac by stepping up the precision of pi even more
using Math.PI.

  • fast/canvas/canvas-save-restore-with-path.js: Use Math.PI instead of a hard-coded estimation.
17:39 Changeset [74704] by weinig@apple.com

WebKit2 snapshots should contain accelerated content
<rdar://problem/8807393>
https://bugs.webkit.org/show_bug.cgi?id=51660

Reviewed by Anders Carlsson.

When creating a snapshot, flatten the layer tree for painting so that
accelerated content is included in the snapshot.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::snapshotInViewCoordinates):
(WebKit::WebPage::snapshotInDocumentCoordinates):

17:03 Changeset [74703] by dbates@webkit.org

2010-12-27 Daniel Bates <dbates@rim.com>

Attempt to fix the WebKit2 Windows build after changeset 74698
<http://trac.webkit.org/changeset/74698> (bug #51656).

Add "..\Shared\API\c\WKImage.h" to WebKit2Generated.make.

  • win/WebKit2Generated.make:
16:50 Changeset [74702] by kbr@google.com

2010-12-27 Kenneth Russell <kbr@google.com>

Unreviewed, Chromium test expectations update. Generalize
suppressions for Chromium bugs 67732 and 67139 to cover Linux
Debug.

  • platform/chromium/test_expectations.txt:
16:44 Changeset [74701] by dbates@webkit.org

2010-12-27 Daniel Bates <dbates@rim.com>

Fix the first sentence of the change log message for changeset 74700
<http://trac.webkit.org/changeset/74700> (bug #51634).

As pointed out by Dan Bernstein, it should read: "Rename HTMLFrameElementBase::getMarginWidth()
and HTMLFrameElementBase::getMarginHeight() to HTMLFrameElementBase::marginWidth() and
HTMLFrameElementBase::marginHeight(), respectively."

16:21 Changeset [74700] by dbates@webkit.org

2010-12-27 Daniel Bates <dbates@rim.com>

Reviewed by Antonio Gomes.

Clean up: Rename HTMLFrameElementBase::getMarginWidth() and HTMLFrameElementBase::getMarginHeight()
https://bugs.webkit.org/show_bug.cgi?id=51634

Rename HTMLFrameElementBase::getMarginWidth() and HTMLFrameElementBase::getMarginHeight()
to HTMLFrameElementBase::marginHeight() and HTMLFrameElementBase::marginHeight(), respectively.
This will make the names of these getters consistent with the naming convention we use for
getters.

  • html/HTMLBodyElement.cpp: (WebCore::HTMLBodyElement::insertedIntoDocument):
  • html/HTMLFrameElementBase.h: (WebCore::HTMLFrameElementBase::marginWidth): Renamed; Formerly getMarginWidth(). (WebCore::HTMLFrameElementBase::marginHeight): Renamed; Formerly getMarginHeight().
  • loader/SubframeLoader.cpp: (WebCore::SubframeLoader::loadSubframe):
  • page/FrameView.cpp: (WebCore::FrameView::init):
  • rendering/RenderEmbeddedObject.cpp: (WebCore::RenderEmbeddedObject::viewCleared): Also renamed variables marginw and marginh to marginWidth and marginHeight, respectively. This makes the names of these variables consistent with the names of similar variables in SubframeLoader::loadSubframe() and FrameView::init().
  • rendering/RenderFrame.cpp: (WebCore::RenderFrame::viewCleared): Ditto.
16:17 Changeset [74699] by mrobinson@webkit.org

2010-12-27 Martin Robinson <mrobinson@igalia.com>

Reviewed by Daniel Bates.

[Cairo] fast/canvas/canvas-save-restore-with-path.html fails with some versions of Cairo
https://bugs.webkit.org/show_bug.cgi?id=51655

Increase the precision of pi used in this test case. It appears that
some Cairo versions or processors are sensitive to rounding errors here.

  • fast/canvas/canvas-save-restore-with-path.js: Increase pi precision.
16:01 Changeset [74698] by weinig@apple.com

WebKit2: Add API for getting snapshots
https://bugs.webkit.org/show_bug.cgi?id=51656

Reviewed by Anders Carlsson.

  • Shared/API/c/WKBase.h:
  • Shared/API/c/WKImage.cpp: Added.

(WKImageGetTypeID):
(WKImageCreate):
(WKImageGetSize):

  • Shared/API/c/WKImage.h: Added.
  • Shared/WebImage.cpp: Added.

(WebKit::WebImage::create):
(WebKit::WebImage::size):

  • Shared/WebImage.h: Added.

(WebKit::WebImage::backingStore):
(WebKit::WebImage::WebImage):
(WebKit::WebImage::type):
Add a general purpose API image class.

  • Shared/API/c/cg: Added.
  • Shared/API/c/cg/WKImageCG.cpp: Added.

(WKImageCreateCGImage):

  • Shared/API/c/cg/WKImageCG.h: Added.

Add function to convert a WKImageRef to a CGImageRef for platforms that use CG.

  • Shared/API/c/WKSharedAPICast.h:

(WebKit::toFloatRect):
(WebKit::toIntSize):
(WebKit::toIntPoint):
(WebKit::toIntRect):
(WebKit::toImageOptions):
Make conversion functions that are ambiguous more explicit.

  • Shared/APIObject.h:
  • Shared/BackingStore.h:

(WebKit::BackingStore::isBackedBySharedMemory):

  • Shared/ImageOptions.h: Added.
  • Shared/UserMessageCoders.h:

(WebKit::UserMessageEncoder::baseEncode):
(WebKit::UserMessageDecoder::baseDecode):
Allow a WKImageRef to be passed in user messages. Right now, it only
works if the image is sharable.

  • UIProcess/API/C/WKPage.cpp:

(WKPageScaleWebView):

  • UIProcess/WebUIClient.cpp:

(WebKit::WebUIClient::windowFrame):
Use the more explicit conversion function name.

  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageCreateSnapshotInViewCoordinates):
(WKBundlePageCreateSnapshotInDocumentCoordinates):

  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/InjectedBundle/API/c/WKBundlePageOverlay.cpp:

(WKBundlePageOverlaySetNeedsDisplay):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::snapshotInViewCoordinates):
(WebKit::WebPage::snapshotInDocumentCoordinates):
Add function to take the snapshot.

  • WebProcess/WebPage/WebPage.h:
  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:

Add new files.

14:48 Changeset [74697] by mrobinson@webkit.org

2010-12-27 Martin Robinson <mrobinson@igalia.com>

Reviewed by Ryosuke Niwa.

[GTK] EditorClient::generateEditorCommands queues up "null string" commands
https://bugs.webkit.org/show_bug.cgi?id=51569

Prevent adding "null string" editor commands by first checking whether or not
the command string is null in generateEditorCommands before appending it to the
list of pending editor command strings.

  • WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::generateEditorCommands): Check for the null string (no command for this key combination) before appending a command string to the list of pending editor commands. (WebKit::EditorClient::executePendingEditorCommands): Add an ASSERT which detects null command strings.
14:37 Changeset [74696] by mrobinson@webkit.org

2010-12-27 Martin Robinson <mrobinson@igalia.com>

Reviewed by Daniel Bates.

[GTK] RenderThemeGtk::m_HScale and RenderThemeGtk::m_VScale are not initialized
https://bugs.webkit.org/show_bug.cgi?id=51654

Properly initialize slider members of RenderThemeGtk. This can lead to test crashes
on some debug configurations.

No new tests. This is already covered by current slider tests. It isn't crashing on
the bots, but it does crash locally.

  • platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::RenderThemeGtk): Properly initialize members.
13:41 Changeset [74695] by darin@apple.com

2010-12-27 Jake Helfert <jake@jakeonthenet.com>

Reviewed and reworked by Darin Adler.

Building WebKit with Visual Studio 2010 fails due
to ambiguous assignment operator errors.
https://bugs.webkit.org/show_bug.cgi?id=51116

  • wtf/NullPtr.h: Added a HAVE(NULLPTR) definition for use with Platform.h HAVE macro, and included the Visual Studio 2010 compiler as one of the ones that has nullptr.
  • wtf/NullPtr.cpp: Updated condition to match.


  • wtf/PassOwnArrayPtr.h: Don't include the operator=(nullptr_t) overload if we are compiling in loose mode and the compiler has nullptr, because assignment of 0 will otherwise encounter ambiguitity with this overload and the overload for loose mode that takes a raw pointer. The conditional can be removed when we get rid of loose mode.
  • wtf/PassOwnPtr.h: Ditto.
  • wtf/PassRefPtr.h: Don't include the operator=(nullptr_t) overload if the compiler has nullptr, because assignment of 0 would be ambiguous with the overload that takes a raw pointer. The conditional can be removed if we ever decide we no longer need to support assigning 0, but might need a way to catch that usage on older compilers.
  • wtf/RefPtr.h: Ditto.
  • wtf/RetainPtr.h: Ditto
  • JavaScriptCore.xcodeproj/project.pbxproj: Added NullPtr.cpp, accidentally omitted when the file was first added.
13:13 Changeset [74694] by eric@webkit.org

2010-12-27 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

build-webkit should detect missing Java SDK and explain how to install it
https://bugs.webkit.org/show_bug.cgi?id=51651

  • Scripts/build-webkit:
13:04 Changeset [74693] by weinig@apple.com

WebKit2: Add additional API for managing databases
https://bugs.webkit.org/show_bug.cgi?id=51629

Reviewed by Anders Carlsson.

  • Adds client for the database manager to get notifications of changes to databases.
  • UIProcess/API/C/WKDatabaseManager.cpp:

(WKDatabaseManagerSetClient):

  • UIProcess/API/C/WKDatabaseManager.h:
  • UIProcess/WebDatabaseManagerProxy.cpp:

(WebKit::WebDatabaseManagerProxy::initializeClient):
(WebKit::WebDatabaseManagerProxy::didModifyOrigin):
(WebKit::WebDatabaseManagerProxy::didModifyDatabase):

  • UIProcess/WebDatabaseManagerProxy.h:
  • UIProcess/WebDatabaseManagerProxy.messages.in:
  • UIProcess/WebDatabaseManagerProxyClient.cpp: Added.

(WebKit::WebDatabaseManagerProxyClient::didModifyOrigin):
(WebKit::WebDatabaseManagerProxyClient::didModifyDatabase):

  • UIProcess/WebDatabaseManagerProxyClient.h: Added.
  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebCoreSupport/WebDatabaseManager.cpp:

(WebKit::WebDatabaseManager::WebDatabaseManager):
(WebKit::WebDatabaseManager::~WebDatabaseManager):
(WebKit::WebDatabaseManager::dispatchDidModifyOrigin):
(WebKit::WebDatabaseManager::dispatchDidModifyDatabase):

  • WebProcess/WebCoreSupport/WebDatabaseManager.h:
  • win/WebKit2.vcproj:
11:41 Changeset [74692] by weinig@apple.com

Fix Makefile based build.

11:21 Changeset [74691] by xan@webkit.org

2010-12-27 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

Remove unneeded includes from our headers.

  • WebCoreSupport/PasteboardHelperGtk.h: ditto.
  • webkit/webkitprivate.h: ditto.
  • webkit/webkitsoupauthdialog.h: ditto.
11:17 Changeset [74690] by weinig@apple.com

WebKit2: Add additional API for managing databases
https://bugs.webkit.org/show_bug.cgi?id=51629

Reviewed by Anders Carlsson.

  • Adds WKDatabaseManagerGetDatabasesByOrigin, which asynchronously returns an array of dictionaries containing details about each origin using databases and details about each database. Keys were added for accessing the data in the dictionaries.
  • Adds WKDatabaseManagerDeleteDatabasesWithNameForOrigin to delete a database with a specific identifier.
  • Adds WKDatabaseManagerSetQuotaForOrigin to set the quota for an origin.
  • Shared/OriginAndDatabases.cpp: Added.

(WebKit::OriginAndDatabases::encode):
(WebKit::OriginAndDatabases::decode):

  • Shared/OriginAndDatabases.h: Added.
  • Shared/WebCoreArgumentCoders.h:
  • UIProcess/API/C/WKDatabaseManager.cpp:

(WKDatabaseManagerGetOriginKey):
(WKDatabaseManagerGetOriginQuotaKey):
(WKDatabaseManagerGetOriginUsageKey):
(WKDatabaseManagerGetDatabaseDetailsKey):
(WKDatabaseManagerGetDatabaseDetailsNameKey):
(WKDatabaseManagerGetDatabaseDetailsDisplayNameKey):
(WKDatabaseManagerGetDatabaseDetailsExpectedUsageKey):
(WKDatabaseManagerGetDatabaseDetailsCurrentUsageKey):
(WKDatabaseManagerGetDatabasesByOrigin):
(callGetDatabasesByOriginBlockAndDispose):
(WKDatabaseManagerGetDatabasesByOrigin_b):
(WKDatabaseManagerGetDatabaseOrigins):
(callGetDatabaseOriginsBlockBlockAndDispose):
(WKDatabaseManagerGetDatabaseOrigins_b):
(WKDatabaseManagerDeleteDatabasesWithNameForOrigin):
(WKDatabaseManagerDeleteDatabasesForOrigin):
(WKDatabaseManagerDeleteAllDatabases):
(WKDatabaseManagerSetQuotaForOrigin):

  • UIProcess/API/C/WKDatabaseManager.h:
  • UIProcess/WebDatabaseManagerProxy.cpp:

(WebKit::WebDatabaseManagerProxy::originKey):
(WebKit::WebDatabaseManagerProxy::originQuotaKey):
(WebKit::WebDatabaseManagerProxy::originUsageKey):
(WebKit::WebDatabaseManagerProxy::databaseDetailsKey):
(WebKit::WebDatabaseManagerProxy::databaseDetailsNameKey):
(WebKit::WebDatabaseManagerProxy::databaseDetailsDisplayNameKey):
(WebKit::WebDatabaseManagerProxy::databaseDetailsExpectedUsageKey):
(WebKit::WebDatabaseManagerProxy::databaseDetailsCurrentUsageKey):
(WebKit::WebDatabaseManagerProxy::invalidate):
(WebKit::WebDatabaseManagerProxy::getDatabasesByOrigin):
(WebKit::WebDatabaseManagerProxy::didGetDatabasesByOrigin):
(WebKit::WebDatabaseManagerProxy::getDatabaseOrigins):
(WebKit::WebDatabaseManagerProxy::didGetDatabaseOrigins):
(WebKit::WebDatabaseManagerProxy::deleteDatabaseWithNameForOrigin):
(WebKit::WebDatabaseManagerProxy::deleteDatabasesForOrigin):
(WebKit::WebDatabaseManagerProxy::setQuotaForOrigin):

  • UIProcess/WebDatabaseManagerProxy.h:
  • UIProcess/WebDatabaseManagerProxy.messages.in:
  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebCoreSupport/WebDatabaseManager.cpp:

(WebKit::WebDatabaseManager::getDatabasesByOrigin):
(WebKit::WebDatabaseManager::deleteDatabaseWithNameForOrigin):
(WebKit::WebDatabaseManager::setQuotaForOrigin):

  • WebProcess/WebCoreSupport/WebDatabaseManager.h:
  • WebProcess/WebCoreSupport/WebDatabaseManager.messages.in:
  • win/WebKit2.vcproj:
11:07 Changeset [74689] by mrobinson@webkit.org

2010-12-26 Martin Robinson <mrobinson@igalia.com>

Reviewed by Daniel Bates.

[GTK] Add support for build-jsc
https://bugs.webkit.org/show_bug.cgi?id=51625

Add GTK+ support to build-jsc now that building the jsc executable as
a standalone target is easy.

  • Scripts/build-jsc: Call buildGtkProject for the GTK+ case now.
  • Scripts/build-webkit: Pass in the proper target name to buildGtkProject.
  • Scripts/webkitdirs.pm: Actually process the project parameter in buildGtkProject and pass it along to buildAutotoolsProject.
10:50 Changeset [74688] by levin@chromium.org

check-webkit-style check for meaningless variable names in function declarations.
https://bugs.webkit.org/show_bug.cgi?id=51523

Reviewed by Eric Seidel.

  • Scripts/webkitpy/style/checker.py: Exempted JavaScriptCore/jit/JITStubs.cpp

from the new check and whitespace/parens because the syntax is unusual and
produced a fair number of positives for these checks.

  • Scripts/webkitpy/style/checkers/cpp.py:

(_convert_to_lower_with_underscores): Used as a canonical form for type names
and parameter names when determining if the parameter name is useless.
(_create_acronym): Used to check for redundant variable names in cases like "ExceptionCode ec"
(Parameter.lower_with_underscores_name): Gives back the parameter name in a lower_with_underscore
format.
(_check_parameter_name_against_text): Checks to see if the parameter name is in the
text or an acronym of it.
(check_function_definition): Checks function definitions for meaningless variable names.
(process_line): Added call to check_function_definition.

  • Scripts/webkitpy/style/checkers/cpp_unittest.py:

(CppFunctionsTest.test_convert_to_lower_with_underscores): Test for _convert_to_lower_with_underscores.
(CppFunctionsTest.test_create_acronym): Test for _create_acronym.
(CppFunctionsTest.test_check_parameter_against_text): Test for _check_parameter_against_text.
(CppStyleTestBase.perform_single_line_lint): Removed the parameter name check
because when only checking a snippet, there are a lot of bogus functions.
(CppStyleTestBase.perform_multi_line_lint): Ditto and removed a bogus filter
that I put there previously and just noticed.
(WebKitStyleTest.test_parameter_names): Tests for the functionality -- both
check_function_definition and process_line.

10:46 Changeset [74687] by commit-queue@webkit.org

2010-12-27 Kenji Imasaki <imasaki@chromium.org>

Reviewed by David Levin.

remove entries for media related non-flaky tests.
https://bugs.webkit.org/show_bug.cgi?id=51225

  • platform/chromium/test_expectations.txt:
09:41 Changeset [74686] by antonm@chromium.org

2010-12-27 Anton Muhin <antonm@chromium.org>

Reviewed by David Levin.

[v8] Remove unused methods to protect/unprotect wrappers during garbage collection
https://bugs.webkit.org/show_bug.cgi?id=51648

  • bindings/v8/ScriptController.cpp:
  • bindings/v8/ScriptController.h:
  • bindings/v8/V8GCController.cpp: (WebCore::V8GCController::gcEpilogue):
  • bindings/v8/V8GCController.h:
09:37 Changeset [74685] by commit-queue@webkit.org

2010-12-27 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Disable flash plugin in GtkLauncher when using gtk3
https://bugs.webkit.org/show_bug.cgi?id=51591

Flash plugin uses gtk2 that is incompatible with gtk3 making
webkit crash when it's built with gtk3.

  • GtkLauncher/main.c: (main):
09:10 Changeset [74684] by commit-queue@webkit.org

2010-12-27 Rafael Antognolli <antognolli@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Set the frame smart object base clipper to non-static.
https://bugs.webkit.org/show_bug.cgi?id=51552

The base clipper of the clipped smart object, which is the parent
class of the ewk_frame class is a static clipper. It's normally only
used for showing/hiding the object, but in the case of the ewk_frame,
it needs to clip the object to its dimension, in order to clip
scrollbars of inner frames.

Setting it to non-static makes the clipper to be automatically moved
by the parent class, thus staying on the correct position when the
frame is moved.

This change needed to be done after the adoption of the static clipper
on the clipped smart base class.

  • ewk/ewk_frame.cpp: (_ewk_frame_smart_add):
06:51 Changeset [74683] by yurys@chromium.org

2010-12-27 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Removed trailing spaces from a localized
string to make it the same as the one used in the code.

  • English.lproj/localizedStrings.js:
06:36 Changeset [74682] by philn@webkit.org

2010-12-27 Philippe Normand <pnormand@igalia.com>

Unreviewed, skip another GTK media test reporting wrong duration,
see bug 51602.

  • platform/gtk/Skipped:
06:10 Changeset [74681] by yael.aharon@nokia.com

2010-12-27 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Eric Seidel.

Browser is failing 16 baseline test from Selector API Test Suite
https://bugs.webkit.org/show_bug.cgi?id=42968

Update the expected result for the test.

  • fast/dom/SelectorAPI/resig-SelectorsAPI-test-expected.txt:

2010-12-27 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Eric Seidel.

Browser is failing 16 baseline test from Selector API Test Suite
https://bugs.webkit.org/show_bug.cgi?id=42968

Throw an exception if there is no argument to querySelector or
querySelectorAll. This replaces the current behavior of passing the string
"undefined" as the argument.

No new tests, just updating the existing results for
fast/dom/SelectorAPI/resig-SelectorAPI-test.xhtml.

  • dom/Document.idl:
  • dom/DocumentFragment.idl:
  • dom/Element.idl:
03:32 Changeset [74680] by hamaji@chromium.org

2010-12-27 Shinichiro Hamaji <shinichiro.hamaji@gmail.com>

Chromium expectation update.

Suppress fast/canvas/webgl/tex-image-with-format-and-type on linux debug

  • platform/chromium/test_expectations.txt:
00:06 Changeset [74679] by morrita@google.com

2010-12-27 MORITA Hajime <morrita@google.com>

Unreviewed expectation updates.

  • platform/chromium-linux/fast/box-shadow/spread-multiple-normal-expected.checksum: Added.
  • platform/chromium-linux/fast/box-shadow/spread-multiple-normal-expected.png: Added.
  • platform/chromium-win/fast/box-shadow/spread-multiple-normal-expected.checksum: Added.
  • platform/chromium-win/fast/box-shadow/spread-multiple-normal-expected.png: Added.

12/26/10:

23:27 Changeset [74678] by abarth@webkit.org

Fix bug number in previous commit.

23:24 Changeset [74677] by abarth@webkit.org

2010-12-26 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

[Meta] Move source code into Sources
https://bugs.webkit.org/show_bug.cgi?id=51606

  • PrettyPatch/PrettyPatch.rb:
    • Remove reference to non-existant autotools directory.

2010-12-26 Adam Barth <abarth@webkit.org>

Reviewed by Eric Siedel.

[Meta] Move source code into Sources
https://bugs.webkit.org/show_bug.cgi?id=51606

  • .gitignore:
  • GNUmakefile.am:
  • Sources/autotools: Copied from autotools.
  • autogen.sh:
  • autotools: Removed.
  • autotools/acinclude.m4: Removed.
  • autotools/dolt.m4: Removed.
  • autotools/gsettings.m4: Removed.
  • autotools/symbols.filter: Removed.
  • autotools/webkit.m4: Removed.
  • configure.ac:
23:00 Changeset [74676] by abarth@webkit.org

2010-12-26 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Move cmake into Sources
https://bugs.webkit.org/show_bug.cgi?id=51631

  • PrettyPatch/PrettyPatch.rb:

2010-12-26 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Move cmake into Sources
https://bugs.webkit.org/show_bug.cgi?id=51631

  • CMakeLists.txt:
  • Sources/cmake: Copied from cmake.
  • cmake: Removed.
  • cmake/FindCFLite.cmake: Removed.
  • cmake/FindCairo.cmake: Removed.
  • cmake/FindEFL.cmake: Removed.
  • cmake/FindFontconfig.cmake: Removed.
  • cmake/FindFreetype.cmake: Removed.
  • cmake/FindGDK-PixBuf.cmake: Removed.
  • cmake/FindGDK.cmake: Removed.
  • cmake/FindGIO.cmake: Removed.
  • cmake/FindGStreamer-App.cmake: Removed.
  • cmake/FindGStreamer-Base.cmake: Removed.
  • cmake/FindGStreamer-Interfaces.cmake: Removed.
  • cmake/FindGStreamer-Pbutils.cmake: Removed.
  • cmake/FindGStreamer-Plugins-Base.cmake: Removed.
  • cmake/FindGStreamer-Video.cmake: Removed.
  • cmake/FindGStreamer.cmake: Removed.
  • cmake/FindGlib.cmake: Removed.
  • cmake/FindGperf.cmake: Removed.
  • cmake/FindGthread.cmake: Removed.
  • cmake/FindICU.cmake: Removed.
  • cmake/FindLibSoup2.cmake: Removed.
  • cmake/FindLibXlst.cmake: Removed.
  • cmake/FindPango.cmake: Removed.
  • cmake/FindSqlite.cmake: Removed.
  • cmake/LibFindMacros.cmake: Removed.
  • cmake/OptionsCommon.cmake: Removed.
  • cmake/OptionsEfl.cmake: Removed.
  • cmake/OptionsWinCE.cmake: Removed.
  • cmake/OptionsWindows.cmake: Removed.
  • cmake/WebKitEfl.cmake: Removed.
  • cmake/WebKitFS.cmake: Removed.
  • cmake/WebKitFeatures.cmake: Removed.
  • cmake/WebKitHelpers.cmake: Removed.
  • cmake/WebKitMacros.cmake: Removed.
  • cmake/WebKitPackaging.cmake: Removed.
  • cmake/eflsymbols.filter: Removed.
22:11 Changeset [74675] by abarth@webkit.org

2010-12-26 Adam Barth <abarth@webkit.org>

Fix some references to the old location of the WebKit website in git
metadata files.

  • .gitattributes:
21:51 Changeset [74674] by abarth@webkit.org

Move ANGLE to Sources/ThirdParty
https://bugs.webkit.org/show_bug.cgi?id=51605

Reviewed by Eric Seidel.

Actually move ANGLE and update the Makefile.

  • ANGLE: Removed.
  • ANGLE/ANGLE.xcodeproj: Removed.
  • ANGLE/ANGLE.xcodeproj/project.pbxproj: Removed.
  • ANGLE/Configurations: Removed.
  • ANGLE/Configurations/ANGLE.xcconfig: Removed.
  • ANGLE/Configurations/Base.xcconfig: Removed.
  • ANGLE/Configurations/DebugRelease.xcconfig: Removed.
  • ANGLE/Makefile: Removed.
  • ANGLE/include: Removed.
  • ANGLE/include/EGL: Removed.
  • ANGLE/include/EGL/egl.h: Removed.
  • ANGLE/include/EGL/eglext.h: Removed.
  • ANGLE/include/EGL/eglplatform.h: Removed.
  • ANGLE/include/GLES2: Removed.
  • ANGLE/include/GLES2/gl2.h: Removed.
  • ANGLE/include/GLES2/gl2ext.h: Removed.
  • ANGLE/include/GLES2/gl2platform.h: Removed.
  • ANGLE/include/GLSLANG: Removed.
  • ANGLE/include/GLSLANG/ShaderLang.h: Removed.
  • ANGLE/include/KHR: Removed.
  • ANGLE/include/KHR/khrplatform.h: Removed.
  • ANGLE/src: Removed.
  • ANGLE/src/build_angle.xcodeproj: Removed.
  • ANGLE/src/build_angle.xcodeproj/project.pbxproj: Removed.
  • ANGLE/src/common: Removed.
  • ANGLE/src/common/angleutils.h: Removed.
  • ANGLE/src/common/debug.cpp: Removed.
  • ANGLE/src/common/debug.h: Removed.
  • ANGLE/src/compiler: Removed.
  • ANGLE/src/compiler/BaseTypes.h: Removed.
  • ANGLE/src/compiler/CodeGenGLSL.cpp: Removed.
  • ANGLE/src/compiler/CodeGenHLSL.cpp: Removed.
  • ANGLE/src/compiler/Common.h: Removed.
  • ANGLE/src/compiler/ConstantUnion.h: Removed.
  • ANGLE/src/compiler/InfoSink.cpp: Removed.
  • ANGLE/src/compiler/InfoSink.h: Removed.
  • ANGLE/src/compiler/Initialize.cpp: Removed.
  • ANGLE/src/compiler/Initialize.h: Removed.
  • ANGLE/src/compiler/InitializeDll.cpp: Removed.
  • ANGLE/src/compiler/InitializeDll.h: Removed.
  • ANGLE/src/compiler/InitializeGlobals.h: Removed.
  • ANGLE/src/compiler/InitializeParseContext.h: Removed.
  • ANGLE/src/compiler/IntermTraverse.cpp: Removed.
  • ANGLE/src/compiler/Intermediate.cpp: Removed.
  • ANGLE/src/compiler/MMap.h: Removed.
  • ANGLE/src/compiler/OutputGLSL.cpp: Removed.
  • ANGLE/src/compiler/OutputGLSL.h: Removed.
  • ANGLE/src/compiler/OutputHLSL.cpp: Removed.
  • ANGLE/src/compiler/OutputHLSL.h: Removed.
  • ANGLE/src/compiler/ParseHelper.cpp: Removed.
  • ANGLE/src/compiler/ParseHelper.h: Removed.
  • ANGLE/src/compiler/PoolAlloc.cpp: Removed.
  • ANGLE/src/compiler/PoolAlloc.h: Removed.
  • ANGLE/src/compiler/QualifierAlive.cpp: Removed.
  • ANGLE/src/compiler/QualifierAlive.h: Removed.
  • ANGLE/src/compiler/RemoveTree.cpp: Removed.
  • ANGLE/src/compiler/RemoveTree.h: Removed.
  • ANGLE/src/compiler/ShHandle.h: Removed.
  • ANGLE/src/compiler/ShaderLang.cpp: Removed.
  • ANGLE/src/compiler/SymbolTable.cpp: Removed.
  • ANGLE/src/compiler/SymbolTable.h: Removed.
  • ANGLE/src/compiler/TranslatorGLSL.cpp: Removed.
  • ANGLE/src/compiler/TranslatorGLSL.h: Removed.
  • ANGLE/src/compiler/TranslatorHLSL.cpp: Removed.
  • ANGLE/src/compiler/TranslatorHLSL.h: Removed.
  • ANGLE/src/compiler/Types.h: Removed.
  • ANGLE/src/compiler/UnfoldSelect.cpp: Removed.
  • ANGLE/src/compiler/UnfoldSelect.h: Removed.
  • ANGLE/src/compiler/debug.cpp: Removed.
  • ANGLE/src/compiler/debug.h: Removed.
  • ANGLE/src/compiler/glslang.l: Removed.
  • ANGLE/src/compiler/glslang.y: Removed.
  • ANGLE/src/compiler/intermOut.cpp: Removed.
  • ANGLE/src/compiler/intermediate.h: Removed.
  • ANGLE/src/compiler/localintermediate.h: Removed.
  • ANGLE/src/compiler/osinclude.h: Removed.
  • ANGLE/src/compiler/ossource_posix.cpp: Removed.
  • ANGLE/src/compiler/ossource_win.cpp: Removed.
  • ANGLE/src/compiler/parseConst.cpp: Removed.
  • ANGLE/src/compiler/preprocessor: Removed.
  • ANGLE/src/compiler/preprocessor/atom.c: Removed.
  • ANGLE/src/compiler/preprocessor/atom.h: Removed.
  • ANGLE/src/compiler/preprocessor/compile.h: Removed.
  • ANGLE/src/compiler/preprocessor/cpp.c: Removed.
  • ANGLE/src/compiler/preprocessor/cpp.h: Removed.
  • ANGLE/src/compiler/preprocessor/cppstruct.c: Removed.
  • ANGLE/src/compiler/preprocessor/memory.c: Removed.
  • ANGLE/src/compiler/preprocessor/memory.h: Removed.
  • ANGLE/src/compiler/preprocessor/parser.h: Removed.
  • ANGLE/src/compiler/preprocessor/preprocess.h: Removed.
  • ANGLE/src/compiler/preprocessor/scanner.c: Removed.
  • ANGLE/src/compiler/preprocessor/scanner.h: Removed.
  • ANGLE/src/compiler/preprocessor/slglobals.h: Removed.
  • ANGLE/src/compiler/preprocessor/symbols.c: Removed.
  • ANGLE/src/compiler/preprocessor/symbols.h: Removed.
  • ANGLE/src/compiler/preprocessor/tokens.c: Removed.
  • ANGLE/src/compiler/preprocessor/tokens.h: Removed.
  • ANGLE/src/compiler/tools: Removed.
  • ANGLE/src/compiler/unistd.h: Removed.
  • ANGLE/src/libEGL: Removed.
  • ANGLE/src/libEGL/Config.cpp: Removed.
  • ANGLE/src/libEGL/Config.h: Removed.
  • ANGLE/src/libEGL/Display.cpp: Removed.
  • ANGLE/src/libEGL/Display.h: Removed.
  • ANGLE/src/libEGL/Surface.cpp: Removed.
  • ANGLE/src/libEGL/Surface.h: Removed.
  • ANGLE/src/libEGL/libEGL.cpp: Removed.
  • ANGLE/src/libEGL/libEGL.def: Removed.
  • ANGLE/src/libEGL/libEGL.vcproj: Removed.
  • ANGLE/src/libEGL/main.cpp: Removed.
  • ANGLE/src/libEGL/main.h: Removed.
  • ANGLE/src/libGLESv2: Removed.
  • ANGLE/src/libGLESv2/Blit.cpp: Removed.
  • ANGLE/src/libGLESv2/Blit.h: Removed.
  • ANGLE/src/libGLESv2/Buffer.cpp: Removed.
  • ANGLE/src/libGLESv2/Buffer.h: Removed.
  • ANGLE/src/libGLESv2/Context.cpp: Removed.
  • ANGLE/src/libGLESv2/Context.h: Removed.
  • ANGLE/src/libGLESv2/Framebuffer.cpp: Removed.
  • ANGLE/src/libGLESv2/Framebuffer.h: Removed.
  • ANGLE/src/libGLESv2/Program.cpp: Removed.
  • ANGLE/src/libGLESv2/Program.h: Removed.
  • ANGLE/src/libGLESv2/RefCountObject.cpp: Removed.
  • ANGLE/src/libGLESv2/RefCountObject.h: Removed.
  • ANGLE/src/libGLESv2/Renderbuffer.cpp: Removed.
  • ANGLE/src/libGLESv2/Renderbuffer.h: Removed.
  • ANGLE/src/libGLESv2/ResourceManager.cpp: Removed.
  • ANGLE/src/libGLESv2/ResourceManager.h: Removed.
  • ANGLE/src/libGLESv2/Shader.cpp: Removed.
  • ANGLE/src/libGLESv2/Shader.h: Removed.
  • ANGLE/src/libGLESv2/Texture.cpp: Removed.
  • ANGLE/src/libGLESv2/Texture.h: Removed.
  • ANGLE/src/libGLESv2/geometry: Removed.
  • ANGLE/src/libGLESv2/geometry/IndexDataManager.cpp: Removed.
  • ANGLE/src/libGLESv2/geometry/IndexDataManager.h: Removed.
  • ANGLE/src/libGLESv2/geometry/VertexDataManager.cpp: Removed.
  • ANGLE/src/libGLESv2/geometry/VertexDataManager.h: Removed.
  • ANGLE/src/libGLESv2/geometry/backend.cpp: Removed.
  • ANGLE/src/libGLESv2/geometry/backend.h: Removed.
  • ANGLE/src/libGLESv2/geometry/dx9.cpp: Removed.
  • ANGLE/src/libGLESv2/geometry/dx9.h: Removed.
  • ANGLE/src/libGLESv2/geometry/vertexconversion.h: Removed.
  • ANGLE/src/libGLESv2/libGLESv2.cpp: Removed.
  • ANGLE/src/libGLESv2/libGLESv2.def: Removed.
  • ANGLE/src/libGLESv2/libGLESv2.vcproj: Removed.
  • ANGLE/src/libGLESv2/main.cpp: Removed.
  • ANGLE/src/libGLESv2/main.h: Removed.
  • ANGLE/src/libGLESv2/mathutil.h: Removed.
  • ANGLE/src/libGLESv2/utilities.cpp: Removed.
  • ANGLE/src/libGLESv2/utilities.h: Removed.
  • Makefile:
  • Sources/ThirdParty: Added.
  • Sources/ThirdParty/ANGLE: Copied from ANGLE.

Tools:

  • Scripts/build-webkit:
    • Point to the new ANGLE location.
20:42 Changeset [74673] by morrita@google.com

2010-12-26 MORITA Hajime <morrita@google.com>

Reviewed by Dan Bernstein.

For box-shadow, non-primary shadows should have specified radii.
https://bugs.webkit.org/show_bug.cgi?id=51386

  • fast/box-shadow/spread-multiple-normal-expected.txt: Added.
  • fast/box-shadow/spread-multiple-normal.html: Added.
  • fast/box-shadow/spread-multiple-normal-expected.checksum: Added.
  • fast/box-shadow/spread-multiple-normal-expected.png: Added.

2010-12-26 MORITA Hajime <morrita@google.com>

Reviewed by Dan Bernstein.

For box-shadow, non-primary shadows should have specified radii.
https://bugs.webkit.org/show_bug.cgi?id=51386

On paintBoxShadow(), the spread value accidentally accumulated accidentally
during the loop, which should be applied individually for radius of each shadow.
This change makes the radii for rects computed for each shadow.

Test: fast/box-shadow/spread-multiple-normal.html

  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintBoxShadow):
14:13 Changeset [74672] by commit-queue@webkit.org

2010-12-26 Xan Lopez <xlopez@igalia.com>

Reviewed by Eric Seidel.

[GTK] Add standalone target for JSC
https://bugs.webkit.org/show_bug.cgi?id=51607

  • GNUmakefile.am: add convenience target to only build jsc and its dependencies.
14:00 Changeset [74671] by paroga@webkit.org

2010-12-26 Patrick Gansterer <paroga@webkit.org>

Reviewed by Eric Seidel.

Improve output of HTML parser benchmark
https://bugs.webkit.org/show_bug.cgi?id=51611

Calculate and show median, min and max values.

  • benchmarks/parser/html-parser.html:
12:27 Changeset [74670] by levin@chromium.org

2010-12-26 David Levin <levin@chromium.org>

Reviewed by Eric Seidel.

check-webkit-style should be able to parse function declaration parameters.
https://bugs.webkit.org/show_bug.cgi?id=51451

  • Scripts/webkitpy/style/checkers/cpp.py: (Position.init): Holds simple position information (row, column). (Parameter.init): Holds information about a parameter. (SingleLineView.init): Converts multiple lines into a single line for simpler searches. (SingleLineView.convert_column_to_row): Returns the original row given a column. (create_skeleton_parameters): Simplifies a parameter list for easier searching. (find_parameter_name_index): Finds where the parameter name is. (parameter_list): Generates the list of parameters for a function. (_FunctionState.begin): Added information to allow determining the parameters on demand. (_FunctionState.get_parameter_list): Returns a tuple of function parameters. (detect_functions): Improve function detection for operator functions and determine where the parameters end and pass that to _FunctionState.begin.
  • Scripts/webkitpy/style/checkers/cpp_unittest.py: (CppFunctionsTest.test_parameter): Verifies Parameter functionality. (CppFunctionsTest.test_single_line_view): Verifies SingleLineView functionality. (CppFunctionsTest.test_create_skeleton_parameters): Verifies create_skeleton_parameters. (CppFunctionsTest.test_find_parameter_name_index): Verifies find_parameter_name_index. (CppFunctionsTest.test_parameter_list): Does some minimal verification for parameter list. Much more thorough verification is done as part of FunctionDetectionTest.test_parameter_list. (FunctionDetectionTest.perform_function_detection): Added support for verifying the parameters found. (FunctionDetectionTest.test_function_declaration_detection): Added more function detection test to verify that we catch the operator functions. (FunctionDetectionTest.test_ignore_macros): Verify that function detection ignores macros. (FunctionDetectionTest.test_parameter_list): Added tests to verify the parameter parsing. (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_bad_test_doesnt_break): Removed because the error. The test is about the bad function name. Fixing the name makes the test exactly like test_function_length_check_definition_severity1_for_test.
11:41 Changeset [74669] by andersca@apple.com

Rename DrawingAreaMessage and DrawingAreaLegacyMessage and
DrawingAreaProxyMessage to DrawingAreaProxyLegacyMessage.

Reviewed by Dan Bernstein.

  • Platform/CoreIPC/MessageID.h:
  • Shared/CoreIPCSupport/DrawingAreaMessageKinds.h:
  • Shared/CoreIPCSupport/DrawingAreaProxyMessageKinds.h:
  • UIProcess/ChunkedUpdateDrawingAreaProxy.cpp:

(WebKit::ChunkedUpdateDrawingAreaProxy::paint):
(WebKit::ChunkedUpdateDrawingAreaProxy::setPageIsVisible):
(WebKit::ChunkedUpdateDrawingAreaProxy::update):
(WebKit::ChunkedUpdateDrawingAreaProxy::sendSetSize):
(WebKit::ChunkedUpdateDrawingAreaProxy::didReceiveMessage):

  • UIProcess/LayerBackedDrawingAreaProxy.cpp:

(WebKit::LayerBackedDrawingAreaProxy::sizeDidChange):
(WebKit::LayerBackedDrawingAreaProxy::setPageIsVisible):
(WebKit::LayerBackedDrawingAreaProxy::update):
(WebKit::LayerBackedDrawingAreaProxy::didReceiveMessage):
(WebKit::LayerBackedDrawingAreaProxy::didReceiveSyncMessage):

  • UIProcess/TiledDrawingAreaProxy.cpp:

(WebKit::TiledDrawingAreaProxy::sizeDidChange):
(WebKit::TiledDrawingAreaProxy::setPageIsVisible):
(WebKit::TiledDrawingAreaProxy::didReceiveMessage):
(WebKit::TiledDrawingAreaProxy::requestTileUpdate):
(WebKit::TiledDrawingAreaProxy::waitUntilUpdatesComplete):
(WebKit::TiledDrawingAreaProxy::takeSnapshot):
(WebKit::TiledDrawingAreaProxy::removeTile):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didReceiveMessage):
(WebKit::WebPageProxy::didReceiveSyncMessage):

  • WebProcess/WebPage/ChunkedUpdateDrawingArea.cpp:

(WebKit::ChunkedUpdateDrawingArea::display):
(WebKit::ChunkedUpdateDrawingArea::setSize):
(WebKit::ChunkedUpdateDrawingArea::didReceiveMessage):

  • WebProcess/WebPage/LayerBackedDrawingArea.cpp:

(WebKit::LayerBackedDrawingArea::setSize):
(WebKit::LayerBackedDrawingArea::didReceiveMessage):

  • WebProcess/WebPage/TiledDrawingArea.cpp:

(WebKit::TiledDrawingArea::display):
(WebKit::TiledDrawingArea::setSize):
(WebKit::TiledDrawingArea::updateTile):
(WebKit::TiledDrawingArea::tileUpdateTimerFired):
(WebKit::TiledDrawingArea::didReceiveMessage):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::didReceiveMessage):

  • WebProcess/WebPage/mac/LayerBackedDrawingAreaMac.mm:

(WebKit::LayerBackedDrawingArea::attachCompositingContext):

11:26 Changeset [74668] by andersca@apple.com

Drawing area cleanup. Remove a bunch of redundant functions that just ended
up calling setNeedsDisplay.

Reviewed by Sam Weinig.

  • UIProcess/DrawingAreaProxy.h:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::invalidateWindow):
(WebKit::WebChromeClient::invalidateContentsAndWindow):
(WebKit::WebChromeClient::invalidateContentsForSlowScroll):

  • WebProcess/WebPage/ChunkedUpdateDrawingArea.cpp:
  • WebProcess/WebPage/ChunkedUpdateDrawingArea.h:
  • WebProcess/WebPage/DrawingArea.h:
  • WebProcess/WebPage/LayerBackedDrawingArea.cpp:
  • WebProcess/WebPage/LayerBackedDrawingArea.h:
  • WebProcess/WebPage/TiledDrawingArea.cpp:
  • WebProcess/WebPage/TiledDrawingArea.h:
08:57 Changeset [74667] by kbr@google.com

2010-12-26 Kenneth Russell <kbr@google.com>

Unreviewed, Chromium expectations fix. Fix broken (duplicate)
expectations for
canvas/philip/tests/2d.gradient.radial.cone.top.html.

  • platform/chromium/test_expectations.txt:
08:04 Changeset [74666] by inferno@chromium.org

2010-12-26 Abhishek Arya <inferno@chromium.org>

Reviewed by Simon Fraser.

Remove the bad assert in paintPaginatedChildLayer, hitTestPaginatedChildLayer.
https://bugs.webkit.org/show_bug.cgi?id=48772

Test: fast/multicol/renderer-positioned-assert-crash.html

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintPaginatedChildLayer): (WebCore::RenderLayer::hitTestPaginatedChildLayer):

2010-12-26 Abhishek Arya <inferno@chromium.org>

Reviewed by Simon Fraser.

Tests passes if it does not crash.
https://bugs.webkit.org/show_bug.cgi?id=48772

  • fast/multicol/renderer-positioned-assert-crash-expected.txt: Added.
  • fast/multicol/renderer-positioned-assert-crash.html: Added.
02:04 Changeset [74665] by paroga@webkit.org

2010-12-26 Patrick Gansterer <paroga@webkit.org>

Unreviewed WinCE buildfix after r74626.

  • cmake/OptionsWinCE.cmake:

12/25/10:

21:05 Changeset [74664] by kbr@google.com

2010-12-25 Kenneth Russell <kbr@google.com>

Unreviewed, Chromium test expectations update.

  • platform/chromium-gpu/test_expectations.txt: Win Debug: Marked compositing/tiling/huge-layer-img.html as TIMEOUT. Marked fast/canvas/webgl/gl-object-get-calls.html as a flaky crash.
  • platform/chromium/test_expectations.txt: Adjusted expectations for the following tests: fast/canvas/shadow-offset-7.html svg/batik/paints/gradientLimit.svg fast/events/touch/touch-target.html canvas/philip/tests/2d.gradient.radial.cone.top.html fast/css/box-shadow.html
17:49 Changeset [74663] by commit-queue@webkit.org

2010-12-25 Peter Rybin <peter.rybin@gmail.com>

Reviewed by Adam Barth.

Adds currentColumn (and currentLine) to SegmentedString. Switches
HTMLTreeBuilder to HTMLDocumentParser::textPosition when it
needs position for a <script> tag.

SegmentedString should provide column position
https://bugs.webkit.org/show_bug.cgi?id=51311

  • html/parser/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::HTMLDocumentParser): (WebCore::HTMLDocumentParser::textPosition):
  • html/parser/HTMLInputStream.h: (WebCore::HTMLInputStream::current): (WebCore::InsertionPointRecord::InsertionPointRecord): (WebCore::InsertionPointRecord::~InsertionPointRecord):
  • html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::HTMLTreeBuilder): (WebCore::HTMLTreeBuilder::processScriptStartTag):
  • html/parser/HTMLTreeBuilder.h: (WebCore::HTMLTreeBuilder::create):
  • platform/text/SegmentedString.cpp: (WebCore::SegmentedString::operator=): (WebCore::SegmentedString::numberOfCharactersConsumedSlow): (WebCore::SegmentedString::advanceSlowCase): (WebCore::SegmentedString::currentLine): (WebCore::SegmentedString::currentColumn): (WebCore::SegmentedString::setCurrentPosition):
  • platform/text/SegmentedString.h: (WebCore::SegmentedString::SegmentedString): (WebCore::SegmentedString::advancePastNewline): (WebCore::SegmentedString::advance): (WebCore::SegmentedString::numberOfCharactersConsumed):
16:38 Changeset [74662] by commit-queue@webkit.org

2010-12-25 Andreas Kling <kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

GraphicsContext: Don't pass StrokeStyle (enum) as const reference
https://bugs.webkit.org/show_bug.cgi?id=51608

  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::setStrokeStyle): (WebCore::GraphicsContext::setPlatformStrokeStyle): (WebCore::GraphicsContext::adjustLineToPixelBoundaries):
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::setPlatformStrokeStyle):
  • platform/graphics/haiku/GraphicsContextHaiku.cpp: (WebCore::GraphicsContext::setPlatformStrokeStyle):
  • platform/graphics/openvg/GraphicsContextOpenVG.cpp: (WebCore::GraphicsContext::setPlatformStrokeStyle):
  • platform/graphics/openvg/PainterOpenVG.cpp: (WebCore::PainterOpenVG::setStrokeStyle):
  • platform/graphics/openvg/PainterOpenVG.h:
  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::setPlatformStrokeStyle):
  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::setPlatformStrokeStyle):
12:53 Changeset [74661] by weinig@apple.com

Fill in some more preferences for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=51610

Reviewed by Dan Bernstein.

  • Shared/WebPreferencesStore.h:
  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetAuthorAndUserStylesEnabled):
(WKPreferencesGetAuthorAndUserStylesEnabled):
(WKPreferencesSetWebArchiveDebugModeEnabled):
(WKPreferencesGetWebArchiveDebugModeEnabled):
(WKPreferencesSetLocalFileContentSniffingEnabled):
(WKPreferencesGetLocalFileContentSniffingEnabled):
(WKPreferencesSetPageCacheEnabled):
(WKPreferencesGetPageCacheEnabled):
(WKPreferencesSetPaginateDuringLayoutEnabled):
(WKPreferencesGetPaginateDuringLayoutEnabled):
(WKPreferencesSetDOMPasteAllowedEnabled):
(WKPreferencesGetDOMPasteAllowedEnabled):

  • UIProcess/API/C/WKPreferences.h:
  • UIProcess/API/C/WKPreferencesPrivate.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):
Pipe through some more preferences.

12:21 Changeset [74660] by paroga@webkit.org

2010-12-25 Patrick Gansterer <paroga@webkit.org>

Unreviewed WinCE buildfix after r74334.

  • CMakeListsWinCE.txt:
01:52 Changeset [74659] by philn@webkit.org

2010-12-25 Philippe Normand <pnormand@igalia.com>

Unreviewed, skip another GTK media test reporting wrong duration,
see bug 50518.

  • platform/gtk/Skipped:
Note: See TracTimeline for information about the timeline view.