Timeline


and

12/31/10:

22:54 Changeset [74845] by tkent@chromium.org
  • 371 edits in trunk/LayoutTests

Unreviewed, test expectation update.

r74844 enabled spell checker on Chromium Linux and Chromium
Windows. So we need to update all of images with misspelled words.

  • platform/chromium-linux/editing/deleting/delete-3928305-fix-expected.checksum:
  • platform/chromium-linux/editing/deleting/delete-3928305-fix-expected.png:
  • platform/chromium-linux/editing/deleting/delete-3959464-fix-expected.checksum:
  • platform/chromium-linux/editing/deleting/delete-3959464-fix-expected.png:
  • platform/chromium-linux/editing/deleting/delete-and-undo-expected.checksum:
  • platform/chromium-linux/editing/deleting/delete-and-undo-expected.png:
  • platform/chromium-linux/editing/deleting/delete-block-contents-003-expected.checksum:
  • platform/chromium-linux/editing/deleting/delete-block-contents-003-expected.png:
  • platform/chromium-linux/editing/deleting/delete-contiguous-ws-001-expected.checksum:
  • platform/chromium-linux/editing/deleting/delete-contiguous-ws-001-expected.png:
  • platform/chromium-linux/editing/deleting/delete-tab-002-expected.checksum:
  • platform/chromium-linux/editing/deleting/delete-tab-002-expected.png:
  • platform/chromium-linux/editing/deleting/delete-tab-003-expected.checksum:
  • platform/chromium-linux/editing/deleting/delete-tab-003-expected.png:
  • platform/chromium-linux/editing/deleting/delete-to-select-table-expected.checksum:
  • platform/chromium-linux/editing/deleting/delete-to-select-table-expected.png:
  • platform/chromium-linux/editing/deleting/delete-trailing-ws-002-expected.checksum:
  • platform/chromium-linux/editing/deleting/delete-trailing-ws-002-expected.png:
  • platform/chromium-linux/editing/deleting/delete-ws-fixup-001-expected.checksum:
  • platform/chromium-linux/editing/deleting/delete-ws-fixup-001-expected.png:
  • platform/chromium-linux/editing/deleting/delete-ws-fixup-002-expected.checksum:
  • platform/chromium-linux/editing/deleting/delete-ws-fixup-002-expected.png:
  • platform/chromium-linux/editing/execCommand/5569741-expected.checksum:
  • platform/chromium-linux/editing/execCommand/5569741-expected.png:
  • platform/chromium-linux/editing/execCommand/insert-list-and-stitch-expected.checksum:
  • platform/chromium-linux/editing/execCommand/insert-list-and-stitch-expected.png:
  • platform/chromium-linux/editing/execCommand/insertHorizontalRule-expected.checksum:
  • platform/chromium-linux/editing/execCommand/insertHorizontalRule-expected.png:
  • platform/chromium-linux/editing/execCommand/outdent-selection-expected.checksum:
  • platform/chromium-linux/editing/execCommand/outdent-selection-expected.png:
  • platform/chromium-linux/editing/inserting/5418891-expected.checksum:
  • platform/chromium-linux/editing/inserting/5418891-expected.png:
  • platform/chromium-linux/editing/inserting/editing-empty-divs-expected.checksum:
  • platform/chromium-linux/editing/inserting/editing-empty-divs-expected.png:
  • platform/chromium-linux/editing/inserting/insert-3907422-fix-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-3907422-fix-expected.png:
  • platform/chromium-linux/editing/inserting/insert-br-004-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-br-004-expected.png:
  • platform/chromium-linux/editing/inserting/insert-br-005-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-br-005-expected.png:
  • platform/chromium-linux/editing/inserting/insert-br-007-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-br-007-expected.png:
  • platform/chromium-linux/editing/inserting/insert-div-007-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-div-007-expected.png:
  • platform/chromium-linux/editing/inserting/insert-div-012-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-div-012-expected.png:
  • platform/chromium-linux/editing/inserting/insert-div-013-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-div-013-expected.png:
  • platform/chromium-linux/editing/inserting/insert-div-014-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-div-014-expected.png:
  • platform/chromium-linux/editing/inserting/insert-div-015-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-div-015-expected.png:
  • platform/chromium-linux/editing/inserting/insert-div-016-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-div-016-expected.png:
  • platform/chromium-linux/editing/inserting/insert-div-017-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-div-017-expected.png:
  • platform/chromium-linux/editing/inserting/insert-div-018-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-div-018-expected.png:
  • platform/chromium-linux/editing/inserting/insert-div-019-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-div-019-expected.png:
  • platform/chromium-linux/editing/inserting/insert-div-020-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-div-020-expected.png:
  • platform/chromium-linux/editing/inserting/insert-div-021-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-div-021-expected.png:
  • platform/chromium-linux/editing/inserting/insert-div-022-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-div-022-expected.png:
  • platform/chromium-linux/editing/inserting/insert-div-025-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-div-025-expected.png:
  • platform/chromium-linux/editing/inserting/insert-div-027-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-div-027-expected.png:
  • platform/chromium-linux/editing/inserting/insert-paragraph-02-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-paragraph-02-expected.png:
  • platform/chromium-linux/editing/inserting/insert-paragraph-03-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-paragraph-03-expected.png:
  • platform/chromium-linux/editing/inserting/insert-tab-002-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-tab-002-expected.png:
  • platform/chromium-linux/editing/inserting/insert-tab-003-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-tab-003-expected.png:
  • platform/chromium-linux/editing/inserting/insert-text-with-newlines-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-text-with-newlines-expected.png:
  • platform/chromium-linux/editing/inserting/paragraph-separator-01-expected.checksum:
  • platform/chromium-linux/editing/inserting/paragraph-separator-01-expected.png:
  • platform/chromium-linux/editing/inserting/paragraph-separator-02-expected.checksum:
  • platform/chromium-linux/editing/inserting/paragraph-separator-02-expected.png:
  • platform/chromium-linux/editing/inserting/paragraph-separator-03-expected.checksum:
  • platform/chromium-linux/editing/inserting/paragraph-separator-03-expected.png:
  • platform/chromium-linux/editing/inserting/return-key-with-selection-001-expected.checksum:
  • platform/chromium-linux/editing/inserting/return-key-with-selection-001-expected.png:
  • platform/chromium-linux/editing/inserting/return-key-with-selection-002-expected.checksum:
  • platform/chromium-linux/editing/inserting/return-key-with-selection-002-expected.png:
  • platform/chromium-linux/editing/inserting/return-key-with-selection-003-expected.checksum:
  • platform/chromium-linux/editing/inserting/return-key-with-selection-003-expected.png:
  • platform/chromium-linux/editing/inserting/typing-002-expected.checksum:
  • platform/chromium-linux/editing/inserting/typing-002-expected.png:
  • platform/chromium-linux/editing/inserting/typing-around-br-001-expected.checksum:
  • platform/chromium-linux/editing/inserting/typing-around-br-001-expected.png:
  • platform/chromium-linux/editing/pasteboard/4242293-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/4242293-expected.png:
  • platform/chromium-linux/editing/pasteboard/4944770-1-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/4944770-1-expected.png:
  • platform/chromium-linux/editing/pasteboard/8145-2-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/8145-2-expected.png:
  • platform/chromium-linux/editing/pasteboard/cut-text-001-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/cut-text-001-expected.png:
  • platform/chromium-linux/editing/pasteboard/interchange-newline-1-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/interchange-newline-1-expected.png:
  • platform/chromium-linux/editing/pasteboard/merge-after-delete-1-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/merge-after-delete-1-expected.png:
  • platform/chromium-linux/editing/pasteboard/merge-after-delete-2-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/merge-after-delete-2-expected.png:
  • platform/chromium-linux/editing/pasteboard/merge-after-delete-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/merge-after-delete-expected.png:
  • platform/chromium-linux/editing/pasteboard/merge-end-4-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/merge-end-4-expected.png:
  • platform/chromium-linux/editing/pasteboard/merge-end-blockquote-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/merge-end-blockquote-expected.png:
  • platform/chromium-linux/editing/pasteboard/merge-end-list-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/merge-end-list-expected.png:
  • platform/chromium-linux/editing/pasteboard/merge-end-table-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/merge-end-table-expected.png:
  • platform/chromium-linux/editing/pasteboard/paste-blockquote-3-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/paste-blockquote-3-expected.png:
  • platform/chromium-linux/editing/pasteboard/paste-text-001-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/paste-text-001-expected.png:
  • platform/chromium-linux/editing/pasteboard/paste-text-012-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/paste-text-012-expected.png:
  • platform/chromium-linux/editing/pasteboard/paste-text-013-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/paste-text-013-expected.png:
  • platform/chromium-linux/editing/pasteboard/paste-text-014-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/paste-text-014-expected.png:
  • platform/chromium-linux/editing/pasteboard/paste-text-019-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/paste-text-019-expected.png:
  • platform/chromium-linux/editing/pasteboard/paste-xml-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/paste-xml-expected.png:
  • platform/chromium-linux/editing/pasteboard/undoable-fragment-removes-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/undoable-fragment-removes-expected.png:
  • platform/chromium-linux/editing/selection/13804-expected.checksum:
  • platform/chromium-linux/editing/selection/13804-expected.png:
  • platform/chromium-linux/editing/selection/5234383-1-expected.checksum:
  • platform/chromium-linux/editing/selection/5234383-1-expected.png:
  • platform/chromium-linux/editing/selection/5234383-2-expected.checksum:
  • platform/chromium-linux/editing/selection/5234383-2-expected.png:
  • platform/chromium-linux/editing/selection/extend-by-word-001-expected.checksum:
  • platform/chromium-linux/editing/selection/extend-by-word-001-expected.png:
  • platform/chromium-linux/editing/selection/move-backwords-by-word-001-expected.checksum:
  • platform/chromium-linux/editing/selection/move-backwords-by-word-001-expected.png:
  • platform/chromium-linux/editing/selection/move-by-character-001-expected.checksum:
  • platform/chromium-linux/editing/selection/move-by-character-001-expected.png:
  • platform/chromium-linux/editing/selection/move-by-line-001-expected.checksum:
  • platform/chromium-linux/editing/selection/move-by-line-001-expected.png:
  • platform/chromium-linux/editing/selection/move-by-word-001-expected.checksum:
  • platform/chromium-linux/editing/selection/move-by-word-001-expected.png:
  • platform/chromium-linux/editing/selection/select-from-textfield-outwards-expected.checksum:
  • platform/chromium-linux/editing/selection/select-from-textfield-outwards-expected.png:
  • platform/chromium-linux/editing/selection/unrendered-002-expected.checksum:
  • platform/chromium-linux/editing/selection/unrendered-002-expected.png:
  • platform/chromium-linux/editing/spelling/spelling-expected.checksum:
  • platform/chromium-linux/editing/spelling/spelling-expected.png:
  • platform/chromium-linux/editing/style/5046875-2-expected.checksum:
  • platform/chromium-linux/editing/style/5046875-2-expected.png:
  • platform/chromium-linux/editing/style/block-styles-007-expected.checksum:
  • platform/chromium-linux/editing/style/block-styles-007-expected.png:
  • platform/chromium-linux/editing/style/create-block-for-style-002-expected.checksum:
  • platform/chromium-linux/editing/style/create-block-for-style-002-expected.png:
  • platform/chromium-linux/editing/style/create-block-for-style-003-expected.checksum:
  • platform/chromium-linux/editing/style/create-block-for-style-003-expected.png:
  • platform/chromium-linux/editing/style/create-block-for-style-004-expected.checksum:
  • platform/chromium-linux/editing/style/create-block-for-style-004-expected.png:
  • platform/chromium-linux/editing/style/create-block-for-style-006-expected.checksum:
  • platform/chromium-linux/editing/style/create-block-for-style-006-expected.png:
  • platform/chromium-linux/editing/style/create-block-for-style-008-expected.checksum:
  • platform/chromium-linux/editing/style/create-block-for-style-008-expected.png:
  • platform/chromium-linux/editing/style/create-block-for-style-009-expected.checksum:
  • platform/chromium-linux/editing/style/create-block-for-style-009-expected.png:
  • platform/chromium-linux/editing/style/create-block-for-style-011-expected.checksum:
  • platform/chromium-linux/editing/style/create-block-for-style-011-expected.png:
  • platform/chromium-linux/editing/style/create-block-for-style-012-expected.checksum:
  • platform/chromium-linux/editing/style/create-block-for-style-012-expected.png:
  • platform/chromium-linux/editing/style/create-block-for-style-013-expected.checksum:
  • platform/chromium-linux/editing/style/create-block-for-style-013-expected.png:
  • platform/chromium-linux/fast/dom/blur-contenteditable-expected.checksum:
  • platform/chromium-linux/fast/dom/blur-contenteditable-expected.png:
  • platform/chromium-win/editing/deleting/delete-3928305-fix-expected.checksum:
  • platform/chromium-win/editing/deleting/delete-3928305-fix-expected.png:
  • platform/chromium-win/editing/deleting/delete-3959464-fix-expected.checksum:
  • platform/chromium-win/editing/deleting/delete-3959464-fix-expected.png:
  • platform/chromium-win/editing/deleting/delete-and-undo-expected.checksum:
  • platform/chromium-win/editing/deleting/delete-and-undo-expected.png:
  • platform/chromium-win/editing/deleting/delete-block-contents-003-expected.checksum:
  • platform/chromium-win/editing/deleting/delete-block-contents-003-expected.png:
  • platform/chromium-win/editing/deleting/delete-contiguous-ws-001-expected.checksum:
  • platform/chromium-win/editing/deleting/delete-contiguous-ws-001-expected.png:
  • platform/chromium-win/editing/deleting/delete-tab-002-expected.checksum:
  • platform/chromium-win/editing/deleting/delete-tab-002-expected.png:
  • platform/chromium-win/editing/deleting/delete-tab-003-expected.checksum:
  • platform/chromium-win/editing/deleting/delete-tab-003-expected.png:
  • platform/chromium-win/editing/deleting/delete-to-select-table-expected.checksum:
  • platform/chromium-win/editing/deleting/delete-to-select-table-expected.png:
  • platform/chromium-win/editing/deleting/delete-trailing-ws-002-expected.checksum:
  • platform/chromium-win/editing/deleting/delete-trailing-ws-002-expected.png:
  • platform/chromium-win/editing/deleting/delete-ws-fixup-001-expected.checksum:
  • platform/chromium-win/editing/deleting/delete-ws-fixup-001-expected.png:
  • platform/chromium-win/editing/deleting/delete-ws-fixup-002-expected.checksum:
  • platform/chromium-win/editing/deleting/delete-ws-fixup-002-expected.png:
  • platform/chromium-win/editing/deleting/smart-delete-002-expected.checksum:
  • platform/chromium-win/editing/deleting/smart-delete-002-expected.png:
  • platform/chromium-win/editing/deleting/smart-delete-003-expected.checksum:
  • platform/chromium-win/editing/deleting/smart-delete-003-expected.png:
  • platform/chromium-win/editing/deleting/smart-delete-004-expected.checksum:
  • platform/chromium-win/editing/deleting/smart-delete-004-expected.png:
  • platform/chromium-win/editing/execCommand/5569741-expected.checksum:
  • platform/chromium-win/editing/execCommand/5569741-expected.png:
  • platform/chromium-win/editing/execCommand/insert-list-and-stitch-expected.checksum:
  • platform/chromium-win/editing/execCommand/insert-list-and-stitch-expected.png:
  • platform/chromium-win/editing/execCommand/insertHorizontalRule-expected.checksum:
  • platform/chromium-win/editing/execCommand/insertHorizontalRule-expected.png:
  • platform/chromium-win/editing/execCommand/outdent-selection-expected.checksum:
  • platform/chromium-win/editing/execCommand/outdent-selection-expected.png:
  • platform/chromium-win/editing/inserting/5418891-expected.checksum:
  • platform/chromium-win/editing/inserting/5418891-expected.png:
  • platform/chromium-win/editing/inserting/editing-empty-divs-expected.checksum:
  • platform/chromium-win/editing/inserting/editing-empty-divs-expected.png:
  • platform/chromium-win/editing/inserting/insert-3907422-fix-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-3907422-fix-expected.png:
  • platform/chromium-win/editing/inserting/insert-br-004-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-br-004-expected.png:
  • platform/chromium-win/editing/inserting/insert-br-005-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-br-005-expected.png:
  • platform/chromium-win/editing/inserting/insert-br-007-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-br-007-expected.png:
  • platform/chromium-win/editing/inserting/insert-div-007-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-div-007-expected.png:
  • platform/chromium-win/editing/inserting/insert-div-012-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-div-012-expected.png:
  • platform/chromium-win/editing/inserting/insert-div-013-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-div-013-expected.png:
  • platform/chromium-win/editing/inserting/insert-div-014-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-div-014-expected.png:
  • platform/chromium-win/editing/inserting/insert-div-015-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-div-015-expected.png:
  • platform/chromium-win/editing/inserting/insert-div-016-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-div-016-expected.png:
  • platform/chromium-win/editing/inserting/insert-div-017-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-div-017-expected.png:
  • platform/chromium-win/editing/inserting/insert-div-018-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-div-018-expected.png:
  • platform/chromium-win/editing/inserting/insert-div-019-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-div-019-expected.png:
  • platform/chromium-win/editing/inserting/insert-div-020-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-div-020-expected.png:
  • platform/chromium-win/editing/inserting/insert-div-021-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-div-021-expected.png:
  • platform/chromium-win/editing/inserting/insert-div-022-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-div-022-expected.png:
  • platform/chromium-win/editing/inserting/insert-div-025-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-div-025-expected.png:
  • platform/chromium-win/editing/inserting/insert-div-027-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-div-027-expected.png:
  • platform/chromium-win/editing/inserting/insert-paragraph-02-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-paragraph-02-expected.png:
  • platform/chromium-win/editing/inserting/insert-paragraph-03-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-paragraph-03-expected.png:
  • platform/chromium-win/editing/inserting/insert-tab-002-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-tab-002-expected.png:
  • platform/chromium-win/editing/inserting/insert-tab-003-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-tab-003-expected.png:
  • platform/chromium-win/editing/inserting/insert-text-with-newlines-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-text-with-newlines-expected.png:
  • platform/chromium-win/editing/inserting/paragraph-separator-01-expected.checksum:
  • platform/chromium-win/editing/inserting/paragraph-separator-01-expected.png:
  • platform/chromium-win/editing/inserting/paragraph-separator-02-expected.checksum:
  • platform/chromium-win/editing/inserting/paragraph-separator-02-expected.png:
  • platform/chromium-win/editing/inserting/paragraph-separator-03-expected.checksum:
  • platform/chromium-win/editing/inserting/paragraph-separator-03-expected.png:
  • platform/chromium-win/editing/inserting/return-key-with-selection-001-expected.checksum:
  • platform/chromium-win/editing/inserting/return-key-with-selection-001-expected.png:
  • platform/chromium-win/editing/inserting/return-key-with-selection-002-expected.checksum:
  • platform/chromium-win/editing/inserting/return-key-with-selection-002-expected.png:
  • platform/chromium-win/editing/inserting/return-key-with-selection-003-expected.checksum:
  • platform/chromium-win/editing/inserting/return-key-with-selection-003-expected.png:
  • platform/chromium-win/editing/inserting/typing-002-expected.checksum:
  • platform/chromium-win/editing/inserting/typing-002-expected.png:
  • platform/chromium-win/editing/inserting/typing-around-br-001-expected.checksum:
  • platform/chromium-win/editing/inserting/typing-around-br-001-expected.png:
  • platform/chromium-win/editing/pasteboard/4242293-expected.checksum:
  • platform/chromium-win/editing/pasteboard/4242293-expected.png:
  • platform/chromium-win/editing/pasteboard/4944770-1-expected.checksum:
  • platform/chromium-win/editing/pasteboard/4944770-1-expected.png:
  • platform/chromium-win/editing/pasteboard/8145-2-expected.checksum:
  • platform/chromium-win/editing/pasteboard/8145-2-expected.png:
  • platform/chromium-win/editing/pasteboard/cut-text-001-expected.checksum:
  • platform/chromium-win/editing/pasteboard/cut-text-001-expected.png:
  • platform/chromium-win/editing/pasteboard/interchange-newline-1-expected.checksum:
  • platform/chromium-win/editing/pasteboard/interchange-newline-1-expected.png:
  • platform/chromium-win/editing/pasteboard/merge-after-delete-1-expected.checksum:
  • platform/chromium-win/editing/pasteboard/merge-after-delete-1-expected.png:
  • platform/chromium-win/editing/pasteboard/merge-after-delete-2-expected.checksum:
  • platform/chromium-win/editing/pasteboard/merge-after-delete-2-expected.png:
  • platform/chromium-win/editing/pasteboard/merge-after-delete-expected.checksum:
  • platform/chromium-win/editing/pasteboard/merge-after-delete-expected.png:
  • platform/chromium-win/editing/pasteboard/merge-end-4-expected.checksum:
  • platform/chromium-win/editing/pasteboard/merge-end-4-expected.png:
  • platform/chromium-win/editing/pasteboard/merge-end-blockquote-expected.checksum:
  • platform/chromium-win/editing/pasteboard/merge-end-blockquote-expected.png:
  • platform/chromium-win/editing/pasteboard/merge-end-list-expected.checksum:
  • platform/chromium-win/editing/pasteboard/merge-end-list-expected.png:
  • platform/chromium-win/editing/pasteboard/merge-end-table-expected.checksum:
  • platform/chromium-win/editing/pasteboard/merge-end-table-expected.png:
  • platform/chromium-win/editing/pasteboard/paste-blockquote-3-expected.checksum:
  • platform/chromium-win/editing/pasteboard/paste-blockquote-3-expected.png:
  • platform/chromium-win/editing/pasteboard/paste-text-001-expected.checksum:
  • platform/chromium-win/editing/pasteboard/paste-text-001-expected.png:
  • platform/chromium-win/editing/pasteboard/paste-text-012-expected.checksum:
  • platform/chromium-win/editing/pasteboard/paste-text-012-expected.png:
  • platform/chromium-win/editing/pasteboard/paste-text-013-expected.checksum:
  • platform/chromium-win/editing/pasteboard/paste-text-013-expected.png:
  • platform/chromium-win/editing/pasteboard/paste-text-014-expected.checksum:
  • platform/chromium-win/editing/pasteboard/paste-text-014-expected.png:
  • platform/chromium-win/editing/pasteboard/paste-text-019-expected.checksum:
  • platform/chromium-win/editing/pasteboard/paste-text-019-expected.png:
  • platform/chromium-win/editing/pasteboard/paste-xml-expected.checksum:
  • platform/chromium-win/editing/pasteboard/paste-xml-expected.png:
  • platform/chromium-win/editing/pasteboard/undoable-fragment-removes-expected.checksum:
  • platform/chromium-win/editing/pasteboard/undoable-fragment-removes-expected.png:
  • platform/chromium-win/editing/selection/13804-expected.checksum:
  • platform/chromium-win/editing/selection/13804-expected.png:
  • platform/chromium-win/editing/selection/5234383-1-expected.checksum:
  • platform/chromium-win/editing/selection/5234383-1-expected.png:
  • platform/chromium-win/editing/selection/5234383-2-expected.checksum:
  • platform/chromium-win/editing/selection/5234383-2-expected.png:
  • platform/chromium-win/editing/selection/extend-by-word-001-expected.checksum:
  • platform/chromium-win/editing/selection/extend-by-word-001-expected.png:
  • platform/chromium-win/editing/selection/move-backwords-by-word-001-expected.checksum:
  • platform/chromium-win/editing/selection/move-backwords-by-word-001-expected.png:
  • platform/chromium-win/editing/selection/move-by-character-001-expected.checksum:
  • platform/chromium-win/editing/selection/move-by-character-001-expected.png:
  • platform/chromium-win/editing/selection/move-by-line-001-expected.checksum:
  • platform/chromium-win/editing/selection/move-by-line-001-expected.png:
  • platform/chromium-win/editing/selection/move-by-word-001-expected.checksum:
  • platform/chromium-win/editing/selection/move-by-word-001-expected.png:
  • platform/chromium-win/editing/selection/select-from-textfield-outwards-expected.checksum:
  • platform/chromium-win/editing/selection/select-from-textfield-outwards-expected.png:
  • platform/chromium-win/editing/selection/unrendered-002-expected.checksum:
  • platform/chromium-win/editing/selection/unrendered-002-expected.png:
  • platform/chromium-win/editing/spelling/spelling-expected.checksum:
  • platform/chromium-win/editing/spelling/spelling-expected.png:
  • platform/chromium-win/editing/style/5046875-2-expected.checksum:
  • platform/chromium-win/editing/style/5046875-2-expected.png:
  • platform/chromium-win/editing/style/block-styles-007-expected.checksum:
  • platform/chromium-win/editing/style/block-styles-007-expected.png:
  • platform/chromium-win/editing/style/create-block-for-style-002-expected.checksum:
  • platform/chromium-win/editing/style/create-block-for-style-002-expected.png:
  • platform/chromium-win/editing/style/create-block-for-style-003-expected.checksum:
  • platform/chromium-win/editing/style/create-block-for-style-003-expected.png:
  • platform/chromium-win/editing/style/create-block-for-style-004-expected.checksum:
  • platform/chromium-win/editing/style/create-block-for-style-004-expected.png:
  • platform/chromium-win/editing/style/create-block-for-style-006-expected.checksum:
  • platform/chromium-win/editing/style/create-block-for-style-006-expected.png:
  • platform/chromium-win/editing/style/create-block-for-style-008-expected.checksum:
  • platform/chromium-win/editing/style/create-block-for-style-008-expected.png:
  • platform/chromium-win/editing/style/create-block-for-style-009-expected.checksum:
  • platform/chromium-win/editing/style/create-block-for-style-009-expected.png:
  • platform/chromium-win/editing/style/create-block-for-style-011-expected.checksum:
  • platform/chromium-win/editing/style/create-block-for-style-011-expected.png:
  • platform/chromium-win/editing/style/create-block-for-style-012-expected.checksum:
  • platform/chromium-win/editing/style/create-block-for-style-012-expected.png:
  • platform/chromium-win/editing/style/create-block-for-style-013-expected.checksum:
  • platform/chromium-win/editing/style/create-block-for-style-013-expected.png:
  • platform/chromium-win/fast/dom/blur-contenteditable-expected.checksum:
  • platform/chromium-win/fast/dom/blur-contenteditable-expected.png:
22:06 Changeset [74844] by tkent@chromium.org
  • 2 edits in trunk/Tools

2010-12-31 Kent Tamura <tkent@chromium.org>

Reviewed by Eric Seidel.

[DRT/Chromium] Enable mock spell checker on non-OSX
https://bugs.webkit.org/show_bug.cgi?id=51401

  • DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::spellCheck):
18:38 Changeset [74843] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-12-31 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

fast/loader/about-blank-hash-change.html fails on Chromium
https://bugs.webkit.org/show_bug.cgi?id=51788

I'm unable to reproduce the failure locally, so this patch is slightly
speculative. We need to be slighly more careful how we compare the
fragment identifiers for Chromium because Chromium uses a URL parser
that is more agressive about canonicalization.

  • page/Location.cpp: (WebCore::Location::setHash):
18:17 Changeset [74842] by mrobinson@webkit.org
  • 3 edits in trunk/WebCore

2010-12-31 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Use GLib/GIO API for FileSystemGtk implementation
https://bugs.webkit.org/show_bug.cgi?id=51617

Complete implementation of FileSystem platform code for GLib. This
converts remaining API points using POSIX calls to platform-independent
GLib calls and fixes other compilation errors.

No new tests. This code will be tested when an implementation
of beginDragWithFiles is complete.

(WebCore::JSDirectoryEntry::getFile):
(WebCore::JSDirectoryEntry::getDirectory):

  • platform/FileSystem.h: Added forward declarations for GLib types to avoid GLib includes and changed the PlatformFileHandle to be a GIOStream.
  • platform/gtk/FileSystemGtk.cpp: (WebCore::openTemporaryFile): Reimplement using only GLib calls. (WebCore::openFile): Ditto. (WebCore::closeFile): Ditto. (WebCore::seekFile): Added implementation. (WebCore::writeToFile): Reimplement using only GLib calls. (WebCore::readFromFile): Ditto.
16:58 Changeset [74841] by darin@apple.com
  • 12 edits in trunk/WebCore

2010-12-31 Darin Adler <darin@apple.com>

Reviewed by Dan Bernstein.

Some renaming and refactoring of form element code
https://bugs.webkit.org/show_bug.cgi?id=51784

  • bindings/js/JSHTMLSelectElementCustom.cpp: (WebCore::JSHTMLSelectElement::remove): Call new overload of remove for option elements instead of putting the logic in the binding.
  • html/HTMLButtonElement.cpp: (WebCore::HTMLButtonElement::HTMLButtonElement): Updated for name changes. (WebCore::HTMLButtonElement::defaultEventHandler): Renamed argument to "event" instead of "evt". Also updated for name changes. (WebCore::HTMLButtonElement::isActivatedSubmit): Ditto. (WebCore::HTMLButtonElement::setActivatedSubmit): Ditto. (WebCore::HTMLButtonElement::appendFormData): Ditto.
  • html/HTMLButtonElement.h: Renamed m_activeSubmit to m_isActivatedSubmit to match the getter function name. The name still doesn't seem great.
  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::HTMLFormElement): Updated for name changes. (WebCore::HTMLFormElement::~HTMLFormElement): Use autoComplete function instead of m_autocomplete data member. (WebCore::HTMLFormElement::rendererIsNeeded): Use m_wasDemoted data member instead of otherwise-unused isDemoted function. (WebCore::HTMLFormElement::submitImplicitly): Updated for name changes. (WebCore::HTMLFormElement::validateInteractively): Removed code to clear m_insubmit. This is now handled by the caller, prepareForSubmission. (WebCore::HTMLFormElement::prepareForSubmission): Renamed. Updated for name changes. Moved code to clear m_isSubmittingOrPreparingForSubmission here from validateInteractively. Removed unneeded check of m_doingsubmit boolean before setting it. (WebCore::HTMLFormElement::submit): Factored this function into two. One for JavaScript and one for non-JavaScript. Neither function needs a frame argument, because the question being asked, anyPageIsProcessingUserGesture, is a question asked of an entire page group, not a specific frame or page, so it's not important which is the active frame. (WebCore::HTMLFormElement::submitFromJavaScript): Ditto. (WebCore::HTMLFormElement::reset): Updated for name changes. (WebCore::HTMLFormElement::parseMappedAttribute): Removed code to parse acceptAttr and got rid of code to set m_autocomplete. (WebCore::HTMLFormElement::elementForAlias): Changed return type to a raw pointer. (WebCore::HTMLFormElement::getNamedElements): Updated to use raw pointer and the vector find function. Added a FIXME about the comment. (WebCore::HTMLFormElement::documentDidBecomeActive): Use autoComplete function instead of m_autocomplete data member. (WebCore::HTMLFormElement::willMoveToNewOwnerDocument): Ditto. (WebCore::HTMLFormElement::didMoveToNewOwnerDocument): Ditto. (WebCore::HTMLFormElement::autoComplete): Ditto.
  • html/HTMLFormElement.h: Added a FIXME about renaming the autoComplete function. Renamed prepareSubmit to prepareForSubmission. Got rid of the frame argument from the submit function and added a new submitFromJavaScript variant. Removed the unneeded isDemoted function. Changed the return type of elementForAlias to a raw pointer. Removed m_autocomplete. Renamed m_insubmit to m_isSubmittingOrPreparingForSubmission, m_doingsubmit to m_shouldSubmit, m_inreset to m_inResetFunction, m_malformed to m_wasMalformed, m_demoted to m_wasDemoted. Use plain bool instead of bitfields.
  • html/HTMLFormElement.idl: Use the function named submitFromJavaScript instead of using CallWith=DynamicFrame because we don't need to know what frame is calling. If we did, it's not clear that the "dynamic" frame would be the right one anyway.
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::remove): Added an overload that takes an option element, since the JavaScript binding supports this.
  • html/HTMLSelectElement.h: Ditto.
  • html/ImageInputType.cpp: (WebCore::ImageInputType::handleDOMActivateEvent): Updated for name changes.
  • html/ImageInputType.h: Ditto.
  • html/SubmitInputType.cpp: (WebCore::SubmitInputType::handleDOMActivateEvent): Ditto.
16:48 Changeset [74840] by jberlin@webkit.org
  • 2 edits
    1 delete in trunk/LayoutTests

The correct temporary fix for media/video-element-other-namespace-crash.html timing out on
the Windows 7 Release Test bots is to add it to the Windows skipped list.

Unreviewed.

https://bugs.webkit.org/show_bug.cgi?id=51787

  • platform/win/Skipped:
  • platform/win/media/video-element-other-namespace-crash-expected.txt: Removed.
16:36 Changeset [74839] by dbates@webkit.org
  • 2 edits in trunk/WebCore

2010-12-31 Daniel Bates <dbates@rim.com>

Reviewed by Darin Adler.

Pass style for <area> instead of associated <img> when querying whether
the theme draws the focus ring for an <area>
https://bugs.webkit.org/show_bug.cgi?id=51632

Fixes an issue where the style for the associated <img> of an <area>
was passed when considering whether the theme should draw a focus ring
for the <area>. Instead, we should pass the theme the style for the <area>.

It's not possible to test this at this time since there are no themes
that override focus ring drawing for <area>s.

  • rendering/RenderImage.cpp: (WebCore::RenderImage::paintFocusRing): Moved call to RenderTheme::supportsFocusRing() such that it's called with respect to the focused <area>.
14:46 Changeset [74838] by abarth@webkit.org
  • 2 edits in trunk/WebKit

2010-12-31 Adam Barth <abarth@webkit.org>

Update SVN ignore property to hide two more external dependencies.

  • chromium: Modified property svn:ignore.
14:10 Changeset [74837] by jberlin@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

Add Windows-specific (failing) expected results for
media/video-element-other-namespace-crash.html in order to get the Windows 7 Release test bot green again.
Unreviewed.
https://bugs.webkit.org/show_bug.cgi?id=51787

  • platform/win/media/video-element-other-namespace-crash-expected.txt: Added.
13:45 Changeset [74836] by jberlin@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Add Windows-specific (failing) expected results for
svg/dom/length-list-parser.html in order to get the Windows 7 Release test bot green again.
Unreviewed.
https://bugs.webkit.org/show_bug.cgi?id=51786

  • platform/win/svg/dom: Added.
  • platform/win/svg/dom/length-list-parser-expected.txt: Added.
12:36 Changeset [74835] by abarth@webkit.org
  • 1 edit
    1 delete in trunk/LayoutTests

2010-12-31 Adam Barth <abarth@webkit.org>

Remove custom Chromium expectation for invalid-protocol. Now that we
share more code with JavaScriptCore, we throw exactly the same
exception and therefore can share results.

  • platform/chromium/fast/dom/Window/invalid-protocol-expected.txt: Removed.
12:12 Changeset [74834] by darin@apple.com
  • 2 edits in trunk/WebCore
  • WebCore.xcodeproj/project.pbxproj: Added back the language.

Developers should be using Xcode 3.2.5 or newer.

11:56 Changeset [74833] by abarth@webkit.org
  • 8 edits in trunk/WebCore

2010-12-31 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Move V8 to WebCore Location implementation
https://bugs.webkit.org/show_bug.cgi?id=51768

  • bindings/generic/BindingFrame.h:
  • bindings/generic/BindingLocation.h:
  • bindings/v8/V8Binding.h:
  • bindings/v8/V8DOMWindowShell.cpp: (WebCore::V8DOMWindowShell::setLocation):
  • bindings/v8/V8Utilities.cpp:
  • bindings/v8/V8Utilities.h:
  • bindings/v8/custom/V8LocationCustom.cpp: (WebCore::V8Location::hashAccessorSetter): (WebCore::V8Location::hostAccessorSetter): (WebCore::V8Location::hostnameAccessorSetter): (WebCore::V8Location::hrefAccessorSetter): (WebCore::V8Location::pathnameAccessorSetter): (WebCore::V8Location::portAccessorSetter): (WebCore::V8Location::protocolAccessorSetter): (WebCore::V8Location::searchAccessorSetter): (WebCore::V8Location::reloadCallback): (WebCore::V8Location::replaceCallback): (WebCore::V8Location::assignCallback):
09:58 Changeset [74832] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-12-31 Yi Shen <yi.4.shen@nokia.com>

Reviewed by Eric Seidel.

Make retrieving extraMediaControlsStyleSheet be page dependent.
https://bugs.webkit.org/show_bug.cgi?id=51752

Use themeForPage to retrieve extraMediaControlsStyleSheet for media
controls.

No new tests because no platform-specific theme implementation uses
the passed page pointer yet.

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::styleForElement):
08:11 Changeset [74831] by abarth@webkit.org
  • 1 edit
    1 delete in trunk/Tools

2010-12-31 Adam Barth <abarth@webkit.org>

Reviewed by Ariya Hidayat.

Remove Tools/Scripts/wkstyle
https://bugs.webkit.org/show_bug.cgi?id=51774

This script appears to not have been touched in a while and seems to
have been replaced by check-webkit-style.

  • Scripts/wkstyle: Removed.
05:02 Changeset [74830] by loislo@chromium.org
  • 2 edits in trunk/WebCore

2010-12-31 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [REGRESSION] WebInspector.ResourcesPanel.prototype.canShowSourceLine() broken.

https://bugs.webkit.org/show_bug.cgi?id=51709

  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.canShowSourceLine):
04:43 Changeset [74829] by paroga@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-12-31 Patrick Gansterer <paroga@webkit.org>

Reviewed by Darin Adler.

Add a fast case for ASCII strings in HashAndUTF8CharactersTranslator::equal
https://bugs.webkit.org/show_bug.cgi?id=50517

This change shows about 2% performance win on the xml-parser benchmark.

  • wtf/text/AtomicString.cpp: (WTF::HashAndUTF8CharactersTranslator::equal):
03:59 Changeset [74828] by paroga@webkit.org
  • 3 edits in trunk/WebCore

2010-12-31 Patrick Gansterer <paroga@webkit.org>

Unreviewed build fix after r74800.

  • bindings/js/JSDOMWindowCustom.cpp: Add missing header.
  • bindings/js/JSLocationCustom.cpp: Ditto.
03:47 Changeset [74827] by loislo@chromium.org
  • 2 edits in trunk/Tools

2010-12-31 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed. Coding style fix.

  • DumpRenderTree/chromium/TestShell.h:
03:41 Changeset [74826] by loislo@chromium.org
  • 4 edits in trunk/Tools

2010-12-31 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Chromium] Inspector's tests are very slow on Win(Dbg).

It was a problem with Chromium DRT. DevToolsAgent object instance was
attached not only to the inspected page but to the DevTools window too.
As result all the inspector files were interpreted as a content of inspected page
and were transfered to the DevTools scripts panel for debugging etc.

https://bugs.webkit.org/show_bug.cgi?id=51735

  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::TestShell): (TestShell::bindJSObjectsToWindow): (TestShell::createNewWindow):
  • DumpRenderTree/chromium/TestShell.h:
02:16 Changeset [74825] by abarth@webkit.org
  • 2 edits
    1 copy
    1 add
    1 delete in trunk

Move HTML and XML parser benchmarks into PerformanceTests/Parser
https://bugs.webkit.org/show_bug.cgi?id=51772

Rubber-stamped by Eric Seidel.

Actually move the directory.

  • PerformanceTests/Parser: Copied from WebCore/benchmarks/parser.

PerformanceTests/Parser:

Add a ChangeLog for tracking changes to the Parser PerformanceTest.

  • ChangeLog: Added.

WebCore:

Remove the benchmarks folder now that it's empty. Future benchmarks
should go in the PerformanceTests directory.

  • benchmarks: Removed.
  • benchmarks/parser: Removed.
  • benchmarks/parser/html-parser.html: Removed.
  • benchmarks/parser/resources: Removed.
  • benchmarks/parser/resources/html5.html: Removed.
  • benchmarks/parser/resources/runner.js: Removed.
  • benchmarks/parser/xml-parser.html: Removed.
02:01 Changeset [74824] by abarth@webkit.org
  • 2 edits
    2 copies in trunk/WebCore

2010-12-31 Patrick Gansterer <paroga@webkit.org>

Reviewed by Adam Barth.

Add XML parser benchmark
https://bugs.webkit.org/show_bug.cgi?id=51612

Move the JavaScript code of html parser into a separate file to share it with xml parser.

  • benchmarks/parser/html-parser.html:
  • benchmarks/parser/resources/runner.js: Copied from WebCore/benchmarks/parser/html-parser.html. (runFunction): (run): (start):
  • benchmarks/parser/xml-parser.html: Copied from WebCore/benchmarks/parser/html-parser.html.
01:51 Changeset [74823] by abarth@webkit.org
  • 9 edits
    1 move in trunk

Move PageLoadTests to PerformanceTests/PageLoad
https://bugs.webkit.org/show_bug.cgi?id=51771

Rubber-stamped by Eric Seidel.

Actually move the directory.

  • PageLoadTests: Removed.
  • PageLoadTests/svg: Removed.
  • PageLoadTests/svg/LICENSES: Removed.
  • PageLoadTests/svg/files: Removed.
  • PageLoadTests/svg/files/33041-Samurai.svg: Removed.
  • PageLoadTests/svg/files/42450-under the see.svg: Removed.
  • PageLoadTests/svg/files/42470-flower_from_my_garden_v2.svg: Removed.
  • PageLoadTests/svg/files/44057-drops on a blade.svg: Removed.
  • PageLoadTests/svg/files/Harvey_Rayner.svg: Removed.
  • PageLoadTests/svg/files/az-lizard_benji_park_01.svg: Removed.
  • PageLoadTests/svg/files/bamboo_01.svg: Removed.
  • PageLoadTests/svg/files/cacuts_01.svg: Removed.
  • PageLoadTests/svg/files/cowboy.svg: Removed.
  • PageLoadTests/svg/files/crawfish2_ganson.svg: Removed.
  • PageLoadTests/svg/files/deb9frac1.svg: Removed.
  • PageLoadTests/svg/files/food_leif_lodahl_01.svg: Removed.
  • PageLoadTests/svg/files/france.svg: Removed.
  • PageLoadTests/svg/files/francobollo_gnome_ezechi_02.svg: Removed.
  • PageLoadTests/svg/files/gearflowers.svg: Removed.
  • PageLoadTests/svg/files/hereGear4.svg: Removed.
  • PageLoadTests/svg/files/mtsthelens.svg: Removed.
  • PageLoadTests/svg/files/mtsthelens0.jpg: Removed.
  • PageLoadTests/svg/files/world-iso.svg: Removed.
  • PageLoadTests/svg/files/worldcup.svg: Removed.
  • PageLoadTests/svg/svg.pltsuite: Removed.
  • PerformanceTests/PageLoad: Copied from PageLoadTests.
  • Sources/cmake/WebKitPackaging.cmake:

PerformanceTests/PageLoad:

Update URLs to point to the new directory name.

  • svg/svg.pltsuite:

Tools:

Update references to PageLoadTests to point to the new location.

  • Scripts/run-pageloadtest:
  • Scripts/webkitpy/common/config/build.py:

Websites/bugs.webkit.org:

Update list of top-level open-source directories.

  • PrettyPatch/PrettyPatch.rb:
01:28 Changeset [74822] by abarth@webkit.org
  • 7 edits
    1 move
    1 add in trunk

Move SunSpider into PerformanceTests
https://bugs.webkit.org/show_bug.cgi?id=51769

Rubber-stamped by Eric Seidel.

Actually move the directory.

  • PerformanceTests: Added.
  • PerformanceTests/SunSpider: Copied from SunSpider.
  • Sources/cmake/WebKitPackaging.cmake:
  • SunSpider: Removed.
  • SunSpider/SunSpider.make: Removed.
  • SunSpider/TODO: Removed.
  • SunSpider/UNCOVERED: Removed.
  • SunSpider/hosted: Removed.
  • SunSpider/hosted/json2.js: Removed.
  • SunSpider/hosted/sunspider.css: Removed.
  • SunSpider/hosted/sunspider.html: Removed.
  • SunSpider/hosted/versions.html: Removed.
  • SunSpider/make-hosted: Removed.
  • SunSpider/resources: Removed.
  • SunSpider/resources/TEMPLATE.html: Removed.
  • SunSpider/resources/driver-TEMPLATE.html: Removed.
  • SunSpider/resources/results-TEMPLATE.html: Removed.
  • SunSpider/resources/sunspider-analyze-results.js: Removed.
  • SunSpider/resources/sunspider-compare-results.js: Removed.
  • SunSpider/resources/sunspider-standalone-compare.js: Removed.
  • SunSpider/resources/sunspider-standalone-driver.js: Removed.
  • SunSpider/sunspider: Removed.
  • SunSpider/sunspider-compare-results: Removed.
  • SunSpider/tests: Removed.
  • SunSpider/tests/parse-only: Removed.
  • SunSpider/tests/parse-only/LIST: Removed.
  • SunSpider/tests/parse-only/concat-jquery-mootools-prototype.js: Removed.
  • SunSpider/tests/parse-only/jquery-1.3.2.js: Removed.
  • SunSpider/tests/parse-only/mootools-1.2.2-core-nc.js: Removed.
  • SunSpider/tests/parse-only/prototype-1.6.0.3.js: Removed.
  • SunSpider/tests/sunspider-0.9: Removed.
  • SunSpider/tests/sunspider-0.9.1: Removed.
  • SunSpider/tests/sunspider-0.9.1/3d-cube.js: Removed.
  • SunSpider/tests/sunspider-0.9.1/3d-morph.js: Removed.
  • SunSpider/tests/sunspider-0.9.1/3d-raytrace.js: Removed.
  • SunSpider/tests/sunspider-0.9.1/LIST: Removed.
  • SunSpider/tests/sunspider-0.9.1/access-binary-trees.js: Removed.
  • SunSpider/tests/sunspider-0.9.1/access-fannkuch.js: Removed.
  • SunSpider/tests/sunspider-0.9.1/access-nbody.js: Removed.
  • SunSpider/tests/sunspider-0.9.1/access-nsieve.js: Removed.
  • SunSpider/tests/sunspider-0.9.1/bitops-3bit-bits-in-byte.js: Removed.
  • SunSpider/tests/sunspider-0.9.1/bitops-bits-in-byte.js: Removed.
  • SunSpider/tests/sunspider-0.9.1/bitops-bitwise-and.js: Removed.
  • SunSpider/tests/sunspider-0.9.1/bitops-nsieve-bits.js: Removed.
  • SunSpider/tests/sunspider-0.9.1/controlflow-recursive.js: Removed.
  • SunSpider/tests/sunspider-0.9.1/crypto-aes.js: Removed.
  • SunSpider/tests/sunspider-0.9.1/crypto-md5.js: Removed.
  • SunSpider/tests/sunspider-0.9.1/crypto-sha1.js: Removed.
  • SunSpider/tests/sunspider-0.9.1/date-format-tofte.js: Removed.
  • SunSpider/tests/sunspider-0.9.1/date-format-xparb.js: Removed.
  • SunSpider/tests/sunspider-0.9.1/math-cordic.js: Removed.
  • SunSpider/tests/sunspider-0.9.1/math-partial-sums.js: Removed.
  • SunSpider/tests/sunspider-0.9.1/math-spectral-norm.js: Removed.
  • SunSpider/tests/sunspider-0.9.1/regexp-dna.js: Removed.
  • SunSpider/tests/sunspider-0.9.1/string-base64.js: Removed.
  • SunSpider/tests/sunspider-0.9.1/string-fasta.js: Removed.
  • SunSpider/tests/sunspider-0.9.1/string-tagcloud.js: Removed.
  • SunSpider/tests/sunspider-0.9.1/string-unpack-code.js: Removed.
  • SunSpider/tests/sunspider-0.9.1/string-validate-input.js: Removed.
  • SunSpider/tests/sunspider-0.9/3d-cube.js: Removed.
  • SunSpider/tests/sunspider-0.9/3d-morph.js: Removed.
  • SunSpider/tests/sunspider-0.9/3d-raytrace.js: Removed.
  • SunSpider/tests/sunspider-0.9/LIST: Removed.
  • SunSpider/tests/sunspider-0.9/access-binary-trees.js: Removed.
  • SunSpider/tests/sunspider-0.9/access-fannkuch.js: Removed.
  • SunSpider/tests/sunspider-0.9/access-nbody.js: Removed.
  • SunSpider/tests/sunspider-0.9/access-nsieve.js: Removed.
  • SunSpider/tests/sunspider-0.9/bitops-3bit-bits-in-byte.js: Removed.
  • SunSpider/tests/sunspider-0.9/bitops-bits-in-byte.js: Removed.
  • SunSpider/tests/sunspider-0.9/bitops-bitwise-and.js: Removed.
  • SunSpider/tests/sunspider-0.9/bitops-nsieve-bits.js: Removed.
  • SunSpider/tests/sunspider-0.9/controlflow-recursive.js: Removed.
  • SunSpider/tests/sunspider-0.9/crypto-aes.js: Removed.
  • SunSpider/tests/sunspider-0.9/crypto-md5.js: Removed.
  • SunSpider/tests/sunspider-0.9/crypto-sha1.js: Removed.
  • SunSpider/tests/sunspider-0.9/date-format-tofte.js: Removed.
  • SunSpider/tests/sunspider-0.9/date-format-xparb.js: Removed.
  • SunSpider/tests/sunspider-0.9/math-cordic.js: Removed.
  • SunSpider/tests/sunspider-0.9/math-partial-sums.js: Removed.
  • SunSpider/tests/sunspider-0.9/math-spectral-norm.js: Removed.
  • SunSpider/tests/sunspider-0.9/regexp-dna.js: Removed.
  • SunSpider/tests/sunspider-0.9/string-base64.js: Removed.
  • SunSpider/tests/sunspider-0.9/string-fasta.js: Removed.
  • SunSpider/tests/sunspider-0.9/string-tagcloud.js: Removed.
  • SunSpider/tests/sunspider-0.9/string-unpack-code.js: Removed.
  • SunSpider/tests/sunspider-0.9/string-validate-input.js: Removed.
  • SunSpider/tests/ubench: Removed.
  • SunSpider/tests/ubench/LIST: Removed.
  • SunSpider/tests/ubench/function-closure.js: Removed.
  • SunSpider/tests/ubench/function-correct-args.js: Removed.
  • SunSpider/tests/ubench/function-empty.js: Removed.
  • SunSpider/tests/ubench/function-excess-args.js: Removed.
  • SunSpider/tests/ubench/function-missing-args.js: Removed.
  • SunSpider/tests/ubench/function-sum.js: Removed.
  • SunSpider/tests/ubench/loop-empty-resolve.js: Removed.
  • SunSpider/tests/ubench/loop-empty.js: Removed.
  • SunSpider/tests/ubench/loop-sum.js: Removed.
  • SunSpider/tests/v8-v4: Removed.
  • SunSpider/tests/v8-v4/LIST: Removed.
  • SunSpider/tests/v8-v4/v8-crypto.js: Removed.
  • SunSpider/tests/v8-v4/v8-deltablue.js: Removed.
  • SunSpider/tests/v8-v4/v8-earley-boyer.js: Removed.
  • SunSpider/tests/v8-v4/v8-raytrace.js: Removed.
  • SunSpider/tests/v8-v4/v8-regexp.js: Removed.
  • SunSpider/tests/v8-v4/v8-richards.js: Removed.
  • SunSpider/tests/v8-v4/v8-splay.js: Removed.
  • SunSpider/tests/v8-v5: Removed.
  • SunSpider/tests/v8-v5/LIST: Removed.
  • SunSpider/tests/v8-v5/v8-crypto.js: Removed.
  • SunSpider/tests/v8-v5/v8-deltablue.js: Removed.
  • SunSpider/tests/v8-v5/v8-earley-boyer.js: Removed.
  • SunSpider/tests/v8-v5/v8-raytrace.js: Removed.
  • SunSpider/tests/v8-v5/v8-regexp.js: Removed.
  • SunSpider/tests/v8-v5/v8-richards.js: Removed.
  • SunSpider/tests/v8-v5/v8-splay.js: Removed.
  • SunSpider/tests/v8-v6: Removed.
  • SunSpider/tests/v8-v6/LIST: Removed.
  • SunSpider/tests/v8-v6/v8-crypto.js: Removed.
  • SunSpider/tests/v8-v6/v8-deltablue.js: Removed.
  • SunSpider/tests/v8-v6/v8-earley-boyer.js: Removed.
  • SunSpider/tests/v8-v6/v8-raytrace.js: Removed.
  • SunSpider/tests/v8-v6/v8-regexp.js: Removed.
  • SunSpider/tests/v8-v6/v8-richards.js: Removed.
  • SunSpider/tests/v8-v6/v8-splay.js: Removed.
  • SunSpider/xcopy.excludes: Removed.

Tools:

Update these scripts to point to the new location.

  • Scripts/run-sunspider:
  • Scripts/sunspider-compare-results:

Websites/bugs.webkit.org:

Update list of top-level open-source directories.

  • PrettyPatch/PrettyPatch.rb:

12/30/10:

20:02 Changeset [74821] by mihaip@chromium.org
  • 5 edits
    2 adds in trunk

2010-12-30 Mihai Parparita <mihaip@chromium.org>

Reviewed by Kent Tamura.

[Chromium] Add WebThemeEngineDRTMac so that Chromium DRT scrollbar rendering can match the Mac port's
https://bugs.webkit.org/show_bug.cgi?id=51728

Add implementation of the Mac WebThemeEngine that uses an NSScroller
to render top-level scrollbars. This makes them match the Mac port's
use of an NSScrollView, which means that we'll be able to share more
pixel baselines.

The new rendering code will not be activated until the
USE_WEB_THEME_ENGINE_TO_PAINT_THUMB #define is fliped in
ScrollbarThemeChromiumMac.

  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/chromium/TestShellMac.mm: (platformInit):
  • DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Added.
  • DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Added. (+[FakeActiveWindow alwaysActiveWindow]): (+[FakeActiveWindow alwaysInactiveWindow]): (-[FakeActiveWindow initWithActiveControls:]): (-[FakeActiveWindow _hasActiveControls]): (WebThemeEngineDRTMac::paintScrollbarThumb): (stateToHIEnableState): (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb): (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):

2010-12-30 Mihai Parparita <mihaip@chromium.org>

Reviewed by Kent Tamura.

[Chromium] Add WebThemeEngineDRTMac so that Chromium DRT scrollbar rendering can match the Mac port's
https://bugs.webkit.org/show_bug.cgi?id=51728

Roll DEPS to pick up WebThemeEngine changes.

  • DEPS:
18:44 Changeset [74820] by zmo@google.com
  • 3 edits in trunk/LayoutTests

2010-12-29 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Update validation of stencil mask and ref values
https://bugs.webkit.org/show_bug.cgi?id=50716

  • fast/canvas/webgl/webgl-specific-expected.txt: Sync with khronos: refactor the test, also update the stencil setting test due to spec change.
  • fast/canvas/webgl/webgl-specific.html: Ditto.
17:53 Changeset [74819] by inferno@chromium.org
  • 2 edits in trunk/LayoutTests

2010-12-30 Abhishek Arya <inferno@chromium.org>

Unreviewed.

Skipping media/video-element-other-namespace-crash.html for chromium
since it uses codecs that chromium does not support.

  • platform/chromium/test_expectations.txt:
17:30 Changeset [74818] by zmo@google.com
  • 3 edits in trunk/WebCore

2010-12-29 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Update validation of stencil mask and ref values
https://bugs.webkit.org/show_bug.cgi?id=50716

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::initializeNewContext): Initialize cached stencil settings. (WebCore::WebGLRenderingContext::drawArrays): Validate stencil settings. (WebCore::WebGLRenderingContext::drawElements): Ditto. (WebCore::WebGLRenderingContext::stencilFunc): Cache stencil settings, but generate no error. (WebCore::WebGLRenderingContext::stencilFuncSeparate): Ditto. (WebCore::WebGLRenderingContext::stencilMask): Ditto. (WebCore::WebGLRenderingContext::stencilMaskSeparate): Ditto. (WebCore::WebGLRenderingContext::validateStencilSettings): Helper function to validate stencil settings.
  • html/canvas/WebGLRenderingContext.h: Declare stencil setting members.

2010-12-29 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Update validation of stencil mask and ref values
https://bugs.webkit.org/show_bug.cgi?id=50716

  • fast/canvas/webgl/webgl-specific-expected.txt: Sync with khronos: refactor the test, also update the stencil setting test due to spec change.
  • fast/canvas/webgl/webgl-specific.html: Ditto.
17:03 Changeset [74817] by mrobinson@webkit.org
  • 4 edits
    2 adds in trunk/WebCore

2010-12-30 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Fork pieces of RenderThemeGtk that will differ for GTK+ 3
https://bugs.webkit.org/show_bug.cgi?id=51755

Split out pieces of RenderThemeGtk into RenderThemeGtk2 and RenderThemeGtk3
if they are going to differ between GTK+ 2.x and GTK+ 3.x. This is the preliminary
step to landing support for the new GTK+ 3.x theming API.

No new tests. This should not change functionality.

  • GNUmakefile.am: Add RenderThemeGtk2 and RenderThemeGtk3 to the sources list.
  • platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::adjustTextFieldStyle): Call the setTextInputBorders static method. (WebCore::RenderThemeGtk::adjustTextAreaStyle): Ditto. (WebCore::RenderThemeGtk::paintMediaButton): Ditto. (WebCore::RenderThemeGtk::adjustProgressBarStyle): ditto.
  • platform/gtk/RenderThemeGtk.h: Make setTextInputBorders a method, so that it can be exist in RenderThemeGtk{2,3} and be called from RenderThemeGtk.
  • platform/gtk/RenderThemeGtk2.cpp: Added. A fork of the bits of RenderThemeGtk that will eventually be platform-dependent.
  • platform/gtk/RenderThemeGtk3.cpp: Added. Ditto.
16:50 Changeset [74816] by jschuh@chromium.org
  • 5 edits
    2 adds in trunk

2010-12-30 Justin Schuh <jschuh@chromium.org>

Reviewed by James Robinson.

Reverting r74292 because it introduced a crash with ruby text.
https://bugs.webkit.org/show_bug.cgi?id=51637

Test: fast/css/counters/counter-ruby-text-cleared.html

  • rendering/RenderCounter.cpp: (WebCore::findPlaceForCounter):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::addChild):
  • rendering/RenderObjectChildList.cpp: (WebCore::RenderObjectChildList::appendChildNode): (WebCore::RenderObjectChildList::insertChildNode):

2010-12-30 Justin Schuh <jschuh@chromium.org>

Reviewed by James Robinson.

Check for crash when deleting ruby text with counters.
https://bugs.webkit.org/show_bug.cgi?id=51637

  • fast/css/counters/counter-ruby-text-cleared-expected.txt: Added.
  • fast/css/counters/counter-ruby-text-cleared.html: Added.
16:39 Changeset [74815] by paroga@webkit.org
  • 3 edits in trunk/JavaScriptCore

2010-12-30 Patrick Gansterer <paroga@webkit.org>

Reviewed by Ariya Hidayat.

[CMake] Add WTF_HEADERS
https://bugs.webkit.org/show_bug.cgi?id=51741

Add the WTF headers to show them in Visual Studio.

  • wtf/CMakeLists.txt:
  • wtf/CMakeListsWinCE.txt:
16:24 Changeset [74814] by darin@apple.com
  • 7 edits
    2 deletes in trunk/WebCore

2010-12-30 Darin Adler <darin@apple.com>

Reviewed by David Kilzer.

Remove unused JSBinding source files
https://bugs.webkit.org/show_bug.cgi?id=51762

  • bindings/js/JSBinding.h: Removed.
  • bindings/js/specialization: Removed.
  • bindings/js/specialization/JSBindingState.cpp: Removed.
  • bindings/js/specialization/JSBindingState.h: Removed.
  • CMakeLists.txt: Removed references to files.
  • GNUmakefile.am: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • bindings/js/JSBindingsAllInOne.cpp: Ditto.
15:47 Changeset [74813] by commit-queue@webkit.org
  • 7 edits in trunk

2010-12-30 Konstantin Tokarev <annulen@yandex.ru>

Reviewed by David Kilzer.

[Qt] Don't build wtf/TCSystemAlloc.cpp if --system-malloc option is
used
https://bugs.webkit.org/show_bug.cgi?id=51672

  • WebKit.pri: Replaced USE_SYSTEM_MALLOC with USE_SYSTEM_MALLOC=1

2010-12-30 Konstantin Tokarev <annulen@yandex.ru>

Reviewed by David Kilzer.

[Qt] Don't build wtf/TCSystemAlloc.cpp if --system-malloc option is
used
https://bugs.webkit.org/show_bug.cgi?id=51672

  • wtf/wtf.pri: Replaced USE_SYSTEM_MALLOC with USE_SYSTEM_MALLOC=1

2010-12-30 Konstantin Tokarev <annulen@yandex.ru>

Reviewed by David Kilzer.

[Qt] Don't build wtf/TCSystemAlloc.cpp if --system-malloc option is
used
https://bugs.webkit.org/show_bug.cgi?id=51672

  • DumpRenderTree/qt/DumpRenderTree.pro: Replaced USE_SYSTEM_MALLOC with USE_SYSTEM_MALLOC=1
  • WebKitTestRunner/qt/WebKitTestRunner.pro: Replaced USE_SYSTEM_MALLOC with USE_SYSTEM_MALLOC=1
15:41 Changeset [74812] by tonyg@chromium.org
  • 13 edits in trunk/WebCore

2010-12-30 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Darin Adler.

Remove Document.h include from some headers where it isn't necessary
https://bugs.webkit.org/show_bug.cgi?id=51730

No new tests because no new functionality.

  • editing/EditingStyle.cpp:
  • editing/EditingStyle.h:
  • editing/SelectionController.h:
  • editing/visible_units.h:
  • html/HTMLAudioElement.h:
  • html/HTMLBodyElement.h:
  • inspector/InspectorCSSAgent.h:
  • inspector/InspectorDOMAgent.h:
  • inspector/InspectorInstrumentation.h:
  • xml/DOMParser.cpp:
  • xml/DOMParser.h: (WebCore::DOMParser::create): (WebCore::DOMParser::DOMParser):
15:30 Changeset [74811] by laszlo.1.gombos@nokia.com
  • 2 edits in trunk/Tools

2010-12-30 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by David Kilzer.

[Qt] [Symbian] Fix build-webkit script for Symbian
https://bugs.webkit.org/show_bug.cgi?id=51509

Set the OUTPUT_DIR for Symbian to be the same as the source
directory.

  • Scripts/webkitdirs.pm:
13:55 Changeset [74810] by paroga@webkit.org
  • 2 edits in trunk/WebCore

2010-12-30 Benjamin C Meyer <bmeyer@rim.com>

Reviewed by Darin Adler.

bindings/js/JSDesktopNotificationsCustom.cpp is not included in the cmake build
which is required when NOTIFICATIONS is enabled.

https://bugs.webkit.org/show_bug.cgi?id=51761

  • CMakeLists.txt:
13:46 Changeset [74809] by mrobinson@webkit.org
  • 3 edits in trunk/Tools

2010-12-30 Martin Robinson <mrobinson@igalia.com>

Reviewed by Darin Adler.

check-webkit-style should ignore NULL usage in calls to gtk_widget_style_get
https://bugs.webkit.org/show_bug.cgi?id=51758

Add a check-webkit-style exception for gtk_widget_style_get and NULL usage.

  • Scripts/webkitpy/style/checkers/cpp.py: Add the exception.
  • Scripts/webkitpy/style/checkers/cpp_unittest.py: Add some tests for this.
12:59 Changeset [74808] by antti@apple.com
  • 2 edits in trunk/WebCore

Not reviewed.

Revert accidental project file change.

  • WebCore.xcodeproj/project.pbxproj:
12:57 Changeset [74807] by antti@apple.com
  • 11 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=51134
Move loading related code from MemoryCache to CachedResourceLoader

Reviewed by Darin Adler.

  • Merge MemoryCache::requestResource to CachedResourceLoader::requestResource
  • Merge MemoryCache::requestUserCSSStyleSheet to CachedResourceLoader::requestUserCSSStyleSheet
  • Move MemoryCache::revalidateResource to CachedResourceLoader::revalidateResource
  • Add MemoryCache::add
  • Refactor the decision on whether to reload, revalidate or use the existing resource to a single function, CachedResourceLoader::determineRevalidationPolicy
  • css/CSSImageValue.cpp:

(WebCore::CSSImageValue::cachedImage):

Remove a code path that called MemoryCache::requestResource directly. This code path would have crashed
if ever taken (since it passes null CachedResourceLoader pointer).


  • loader/ImageLoader.cpp:

(WebCore::ImageLoader::updateFromElement):

  • loader/cache/CachedImage.cpp:
  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::CachedResource):
(WebCore::CachedResource::~CachedResource):
(WebCore::CachedResource::mustRevalidateDueToCacheHeaders):

Moved tests that were not about cache headers to CachedResourceLoader::determineRevalidationPolicy and renamed.


(WebCore::CachedResource::setLoadPriority):

Check for Unresolved value before setting.


  • loader/cache/CachedResource.h:

(WebCore::CachedResource::setOwningCachedResourceLoader):

Rename to be bit less mysterious.


  • loader/cache/CachedResourceLoader.cpp:

(WebCore::createResource):

This was moved from MemoryCache.


(WebCore::CachedResourceLoader::~CachedResourceLoader):
(WebCore::CachedResourceLoader::determineRevalidationPolicy):
(WebCore::CachedResourceLoader::requestUserCSSStyleSheet):

This was moved/merged from MemoryCache.


(WebCore::CachedResourceLoader::canRequest):
(WebCore::CachedResourceLoader::requestResource):

This combines MemoryCache::requestResource and the existing method.


(WebCore::CachedResourceLoader::revalidateResource):

This was moved from MemoryCache.


(WebCore::CachedResourceLoader::loadResource):

New method for initiating loading.


(WebCore::CachedResourceLoader::notifyLoadedFromMemoryCache):

Renamed the mysterious CachedResourceLoader::checkCacheObjectStatus


  • loader/cache/CachedResourceLoader.h:
  • loader/cache/MemoryCache.cpp:

(WebCore::MemoryCache::add):

  • loader/cache/MemoryCache.h:

(WebCore::MemoryCache::remove):

12:53 Changeset [74806] by steveblock@google.com
  • 2 edits in trunk/WebCore

2010-12-30 Steve Block <steveblock@google.com>

Reviewed by Gavin Barraclough.

Enable JSC Rich Source Info for Android even when Inspector and Debugger are disabled
https://bugs.webkit.org/show_bug.cgi?id=51740

This is a policy decision for Android.

No new tests, simply enabling existing, tested code on Android.

  • bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::supportsRichSourceInfo):
12:29 Changeset [74805] by mihaip@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

2010-12-30 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium baseline update.

[Chromium] svg/dom/length-list-parser.html fails on Chromium Linux after r74788 and r74803
https://bugs.webkit.org/show_bug.cgi?id=51759

r74803 added chromium-win baselines for svg/dom/length-list-parser.html
but chromium-linux shouldn't use them (despite having them in its
fallback path). Copy the base expectations into chromium-linux.

  • platform/chromium-linux/svg/dom/length-list-parser-expected.txt: Added.
12:21 Changeset [74804] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2010-12-30 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium expectations update.

Mark a few inspector tests as slow, they occasionally time out with
debug builds.

  • platform/chromium/test_expectations.txt:
11:40 Changeset [74803] by jschuh@chromium.org
  • 2 edits
    1 add in trunk/LayoutTests

2010-12-30 Justin Schuh <jschuh@chromium.org>

Unreviewed.

chromium test expectations after r74788 for svg/dom/length-list-parser.html

  • platform/chromium-win/svg/dom/length-list-parser-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
11:34 Changeset [74802] by paroga@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-12-30 Patrick Gansterer <paroga@webkit.org>

Reviewed by Darin Adler.

Use OS(WINDOWS) instead of COMPILER(MSVC) in FastMalloc.cpp
https://bugs.webkit.org/show_bug.cgi?id=51743

Most of the ifdefs belong to windows and not to the MSVC compiler.

  • wtf/FastMalloc.cpp:
11:31 Changeset [74801] by yael.aharon@nokia.com
  • 6 edits
    2 adds in trunk

REGRESSION: fast/dom/cssTarget-crash.html fails
https://bugs.webkit.org/show_bug.cgi?id=20342

Reviewed by Adam Barth.

WebCore:

Do not reload the page when submitting a form, using "GET" method, and the
form action url matches the location url, except for the fragment.

Test: fast/forms/submit-change-fragment.html

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadURL):
(WebCore::FrameLoader::loadWithDocumentLoader):
(WebCore::FrameLoader::shouldScrollToAnchor):

  • loader/FrameLoader.h:

LayoutTests:

  • fast/forms/submit-change-fragment-expected.txt: Added.
  • fast/forms/submit-change-fragment.html: Added.
  • platform/mac/Skipped:
  • platform/qt/Skipped:
11:27 Changeset [74800] by darin@apple.com
  • 13 edits in trunk/WebCore

2010-12-30 Darin Adler <darin@apple.com>

Reviewed by Adam Barth.

Move security logic out of the JavaScript binding for location into the DOM class
https://bugs.webkit.org/show_bug.cgi?id=51714

  • WebCore.xcodeproj/project.pbxproj: Removed JSBindingState.cpp, JSBindingState.h, and JSBinding.h. Later, we'll remove them from other project files and delete the source files.
  • bindings/js/JSBinding.h: Emptied out, marked for later deletion.
  • bindings/js/JSDOMBinding.cpp: Removed unused overload of the jsOwnedStringOrNull function, unused shouldAllowNavigation function, unused allowSettingSrcToJavascriptURL function, unused toLexicalFrame function, unused completeURL function, unused getCachedDOMStructure and cacheDOMStructure overloads, and unused getCachedDOMConstructor and cacheDOMConstruction functions. (WebCore::activeDOMWindow): Added. (WebCore::firstDOMWindow): Added. (WebCore::toDynamicFrame): Changed to use firstDOMWindow instead of calling through JSBindingState, since the latter is an unneeded abstraction. (WebCore::processingUserGesture): Changed to call ScriptController's function rather than calling through JSBindingState, which is an unneeded abstraction
  • bindings/js/JSDOMBinding.h: Removed the functions mentioned above. Added activeDOMWindow and firstDOMWindow. Also added a FIXME for the extremely poorly named allowsAccessFromFrame functions, which answer the question of whether script is allowed access *to* a frame.
  • bindings/js/JSDOMWindowCustom.cpp: Removed many unneeded includes. (WebCore::JSDOMWindow::setLocation): Streamlined by using the new activeDOMWindow and firstDOMWindow functions. (WebCore::JSDOMWindow::open): Ditto. (WebCore::JSDOMWindow::showModalDialog): Ditto. (WebCore::JSDOMWindow::postMessage): Ditto.
  • bindings/js/JSLocationCustom.cpp: (WebCore::JSLocation::setHref): Changed to pass the active and first windows through to the Location::setHref function, with it doing the rest of the work. This moves work out of the DOM binding that belongs in the DOM itself. Eventually such functions could even be automatically generated by the bindings script. (WebCore::JSLocation::setProtocol): Ditto. (WebCore::JSLocation::setHost): Ditto. (WebCore::JSLocation::setHostname): Ditto. (WebCore::JSLocation::setPort): Ditto. (WebCore::JSLocation::setPathname): Ditto. (WebCore::JSLocation::setSearch): Ditto. (WebCore::JSLocation::setHash): Ditto. (WebCore::JSLocation::replace): Ditto. (WebCore::JSLocation::reload): Ditto. (WebCore::JSLocation::assign): Ditto.
  • bindings/js/specialization/JSBindingState.cpp: Emptied out, marked for later deletion.
  • bindings/js/specialization/JSBindingState.h: Emptied out, marked for later deletion.
  • page/DOMWindow.cpp: (WebCore::DOMWindow::setLocation): Added a SetLocationLocking argument that allows us to use this function for Location::replace, which is the same as setLocation except that it locks both history and the back/forward list.
  • page/DOMWindow.h: Ditto.
  • page/Location.cpp: (WebCore::Location::setHref): Added. Uses DOMWindow::setLocation so that the security logic there does not have to be repeated or even refactored. (WebCore::Location::setProtocol): Ditto. (WebCore::Location::setHost): Ditto. (WebCore::Location::setHostname): Ditto. (WebCore::Location::setPort): Ditto. (WebCore::Location::setPathname): Ditto. (WebCore::Location::setSearch): Ditto. (WebCore::Location::setHash): Ditto. (WebCore::Location::assign): Ditto. (WebCore::Location::replace): Ditto. (WebCore::Location::reload): Added. Security logic was refactored from the code in JSLocationCustom.cpp. Added a FIXME about the fact that this security logic seems possibly unneeded.
  • page/Location.h: Fixed indentation on the whole file. Added the new functions above. (WebCore::Location::create): (WebCore::Location::frame):
09:26 Changeset [74799] by apavlov@chromium.org
  • 3 edits in trunk/WebCore

2010-12-30 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Pasting a style property with value should automatically split it into prop/value
https://bugs.webkit.org/show_bug.cgi?id=51581

The "paste" DOM event is handled for the CSS property name field to parse out the name and value parts
of a CSS property being pasted (by the first ':' found). The property is committed (if not a new one),
and the edit focus is transferred to the value field.

  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertyTreeElement.prototype.selectElement): (WebInspector.StylePropertyTreeElement.prototype):
  • inspector/front-end/inspector.js: (WebInspector.completeURL): Drive-by: return full URLs as-is. (WebInspector.startEditing.cleanUpAfterEditing): (WebInspector.startEditing): (WebInspector.startEditing.pasteEventListener): (WebInspector.startEditing.keyDownEventListener):
07:32 Changeset [74798] by podivilov@chromium.org
  • 2 edits in trunk/WebCore

2010-12-30 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: breakpoint is not disabled when clicking on breakpoints sidebar pane checkbox.
https://bugs.webkit.org/show_bug.cgi?id=51745

  • inspector/front-end/Breakpoint.js: (WebInspector.Breakpoint.prototype.set enabled):
07:28 Changeset [74797] by podivilov@chromium.org
  • 2 edits in trunk/WebCore

2010-12-30 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: call stack shows "Paused on a JavaScript breakpoint" when stepping.
https://bugs.webkit.org/show_bug.cgi?id=51748

  • inspector/front-end/CallStackSidebarPane.js: (WebInspector.CallStackSidebarPane.prototype.update): (WebInspector.CallStackSidebarPane.prototype.registerShortcuts): (WebInspector.CallStackSidebarPane.prototype._scriptBreakpointHit): (WebInspector.CallStackSidebarPane.prototype._nativeBreakpointHit):
05:11 Changeset [74796] by philn@webkit.org
  • 2 edits in trunk/LayoutTests

2010-12-30 Philippe Normand <pnormand@igalia.com>

Unreviewed, unskip the test, it's running fine locally.

media/audio-delete-while-slider-thumb-clicked.html fails
https://bugs.webkit.org/show_bug.cgi?id=37546

  • platform/gtk/Skipped:
05:04 Changeset [74795] by mnaganov@chromium.org
  • 6 edits
    1 copy in trunk/WebCore

2010-12-30 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Fix leak of MemoryInfo wrappers introduced in r57004 (see issue 51712).

https://bugs.webkit.org/show_bug.cgi?id=51713

  • WebCore.gypi:
  • WebCore.pro:
  • bindings/v8/custom/V8ConsoleCustom.cpp: (WebCore::V8Console::memoryAccessorGetter):
  • bindings/v8/custom/V8PerformanceCustom.cpp: Copied from V8ConsoleCustom.cpp. (WebCore::V8Performance::memoryAccessorGetter):
  • page/Console.idl:
  • page/Performance.idl:
03:32 Changeset [74794] by steveblock@google.com
  • 2 edits in trunk/WebCore

2010-12-30 Steve Block <steveblock@google.com>

Reviewed by Sam Weinig.

Visiting macnn.com often causes SQL spew via geolocation database
https://bugs.webkit.org/show_bug.cgi?id=51557

If the Geolocation position cache database path has not been set, early-out
rather than using an empty path and thus failing to open the database.
This avoids SQL log spew.

Also, avoid starting the database thread until the path has been set, and
shorten the thread name to avoid warnings due to exceeding 30 characters.

No new tests, implementation clean-up only.

  • page/GeolocationPositionCache.cpp: (WebCore::GeolocationPositionCache::addUser): (WebCore::GeolocationPositionCache::removeUser): (WebCore::GeolocationPositionCache::setDatabasePath): (WebCore::GeolocationPositionCache::startBackgroundThread):
03:02 Changeset [74793] by philn@webkit.org
  • 2 edits in trunk/LayoutTests

2010-12-30 Philippe Normand <pnormand@igalia.com>

Unreviewed, skipping another editing flacky test.

  • platform/gtk/Skipped: skip editing/selection/extend-by-character-005.html.
02:17 Changeset [74792] by philn@webkit.org
  • 8 edits in trunk

2010-12-29 Philippe Normand <pnormand@igalia.com>

Reviewed by Martin Robinson.

[GTK] minimal build fails at link time due to missing sqlite3 symbols
https://bugs.webkit.org/show_bug.cgi?id=51327

  • configure.ac: Error out if SQLite3 wasn't found while at least one of the features depending on it has been enabled.

WebCore:

Reviewed by Martin Robinson.

[GTK] minimal build fails at link time due to missing sqlite3 symbols
https://bugs.webkit.org/show_bug.cgi?id=51327

Guard the code calling sqlite3 with the ENABLE(DATABASE) check.

No new tests, build fix only.

  • platform/sql/SQLiteAuthorizer.cpp:
  • platform/sql/SQLiteDatabase.cpp:
  • platform/sql/SQLiteFileSystem.cpp:
  • platform/sql/SQLiteStatement.cpp:
  • platform/sql/SQLiteTransaction.cpp:
01:29 Changeset [74791] by hamaji@chromium.org
  • 2 edits in trunk/LayoutTests

2010-12-30 Shinichiro Hamaji <shinichiro.hamaji@gmail.com>

Chromium test expectation update for svg/dom/length-list-parser.html

  • platform/chromium/test_expectations.txt:
01:25 Changeset [74790] by hamaji@chromium.org
  • 2 edits in trunk/LayoutTests

2010-12-30 Shinichiro Hamaji <shinichiro.hamaji@gmail.com>

Chromium test expectation update for media/video-element-other-namespace-crash.html

  • platform/chromium/test_expectations.txt:
01:18 WinCE edited by paroga@webkit.org
(diff)
00:29 Changeset [74789] by inferno@chromium.org
  • 2 edits in trunk/LayoutTests

2010-12-30 Abhishek Arya <inferno@chromium.org>

Unreviewed.

Skip media/video-element-other-namespace-crash.html, like other media tests on qt platform.

  • platform/qt/Skipped:
00:12 Changeset [74788] by jschuh@chromium.org
  • 5 edits in trunk

2010-12-30 Justin Schuh <jschuh@chromium.org>

Reviewed by Dirk Schulze.

Prevent stringToLengthType() from skipping past end-of-string on invalid length unit.
https://bugs.webkit.org/show_bug.cgi?id=51692

  • svg/SVGLength.cpp: (WebCore::stringToLengthType): (WebCore::SVGLength::setValueAsString):

2010-12-30 Justin Schuh <jschuh@chromium.org>

Reviewed by Dirk Schulze.

Adding long float string to improve test coverage.
https://bugs.webkit.org/show_bug.cgi?id=51692

  • svg/dom/length-list-parser.html:
  • svg/dom/length-list-parser-expected.txt:
00:02 Changeset [74787] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

2010-12-30 Abhishek Arya <inferno@chromium.org>

Reviewed by Eric Seidel.

Create a helper function for finding descendent video elements for a node.
https://bugs.webkit.org/show_bug.cgi?id=51696

Test: media/video-element-other-namespace-crash.html

  • html/MediaDocument.cpp: (WebCore::descendentVideoElement): helper function. (WebCore::MediaDocument::defaultEventHandler): use the new helper function. fix code repetitions. (WebCore::MediaDocument::replaceMediaElementTimerFired): use the new helper function.

2010-12-30 Abhishek Arya <inferno@chromium.org>

Reviewed by Eric Seidel.

Tests that we do not crash when trying to find video elements in the media document.
https://bugs.webkit.org/show_bug.cgi?id=51696

  • media/video-element-other-namespace-crash-expected.txt: Added.
  • media/video-element-other-namespace-crash.html: Added.

12/29/10:

23:55 Changeset [74786] by inferno@chromium.org
  • 4 edits in trunk/LayoutTests

2010-12-29 Abhishek Arya <inferno@chromium.org>

Unreviewed.

Add 'PASS' to layout test since test failing on chromium due to empty expectations.
Filed webkit bug 51734 to track gtk test failure and skipping test for now.

  • fast/multicol/span/double-merge-anonymous-block-crash-expected.txt:
  • fast/multicol/span/double-merge-anonymous-block-crash.html:
  • platform/gtk/Skipped:
23:41 Changeset [74785] by pfeldman@chromium.org
  • 15 edits
    1 copy
    2 moves
    1 add
    2 deletes in trunk

2010-12-29 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: extract Database & DOM Storage agents; remove InspectorBackend.
https://bugs.webkit.org/show_bug.cgi?id=51707

This change brushes up storage agents + removes redundant InspectorBackend class.

  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/CodeGeneratorInspector.pm:
  • inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::databaseForId): (WebCore::InjectedScriptHost::selectDatabase): (WebCore::InjectedScriptHost::selectDOMStorage): (WebCore::InjectedScriptHost::inspectorDOMAgent):
  • inspector/Inspector.idl:
  • inspector/InspectorBackend.cpp: Removed.
  • inspector/InspectorBackend.h: Removed.
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::~InspectorController): (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::releaseFrontendLifetimeAgents): (WebCore::InspectorController::didUseDOMStorage): (WebCore::InspectorController::setInjectedScriptSource): (WebCore::InspectorController::dispatchOnInjectedScript): (WebCore::InspectorController::releaseWrapperObjectGroup):
  • inspector/InspectorController.h:
  • inspector/InspectorDOMStorageAgent.cpp: Added. (WebCore::InspectorDOMStorageAgent::~InspectorDOMStorageAgent): (WebCore::InspectorDOMStorageAgent::getDOMStorageEntries): (WebCore::InspectorDOMStorageAgent::setDOMStorageItem): (WebCore::InspectorDOMStorageAgent::removeDOMStorageItem): (WebCore::InspectorDOMStorageAgent::selectDOMStorage): (WebCore::InspectorDOMStorageAgent::InspectorDOMStorageAgent): (WebCore::InspectorDOMStorageAgent::getDOMStorageResourceForId):
  • inspector/InspectorDOMStorageAgent.h: Copied from WebCore/inspector/InspectorStorageAgent.h. (WebCore::InspectorDOMStorageAgent::create): (WebCore::InspectorDOMStorageAgent::frontend):
  • inspector/InspectorDatabaseAgent.cpp: Renamed from WebCore/inspector/InspectorStorageAgent.cpp. (WebCore::InspectorDatabaseAgent::~InspectorDatabaseAgent): (WebCore::InspectorDatabaseAgent::getDatabaseTableNames): (WebCore::InspectorDatabaseAgent::executeSQL): (WebCore::InspectorDatabaseAgent::databaseForId): (WebCore::InspectorDatabaseAgent::selectDatabase): (WebCore::InspectorDatabaseAgent::clearFrontend): (WebCore::InspectorDatabaseAgent::InspectorDatabaseAgent):
  • inspector/InspectorDatabaseAgent.h: Renamed from WebCore/inspector/InspectorStorageAgent.h. (WebCore::InspectorDatabaseAgent::create): (WebCore::InspectorDatabaseAgent::frontend):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.show): (WebInspector.ScriptsPanel.prototype.attachDebuggerWhenShown): (WebInspector.ScriptsPanel.prototype._toggleDebugging):
23:20 Changeset [74784] by paroga@webkit.org
  • 2 edits in trunk/Tools

2010-12-29 Patrick Gansterer <paroga@webkit.org>

Unreviewed WinCE buildfix.

  • WinCELauncher/main.cpp: Add missing include.
23:00 Changeset [74783] by krit@webkit.org
  • 1 edit in trunk/WebCore/ChangeLog

2010-12-29 Dirk Schulze <krit@webkit.org>

Unreviewed fix of the misspelled email address in commit 74782.

22:49 Changeset [74782] by krit@webkit.org
  • 32 edits in trunk/WebCore

2010-12-29 Dirk Schulze <krit@wbekit.org>

Reviewed by Darin Adler.

Cleanup SVG code according to the webkit style rules 3
https://bugs.webkit.org/show_bug.cgi?id=51490

Last patch to fix indention and other style issues according to the WebKit style rules in the SVG code.
Just one file can't be fixed for check-webkit-style.

  • SVGAllInOne.cpp: check-webkit-style wants a config.h at the beginning

No changes of functionality, so no new tests.

  • svg/SVGAllInOne.cpp:
  • svg/SVGImage.cpp:
  • svg/SVGLength.cpp: (WebCore::SVGLength::setValue):
  • svg/SVGPolygonElement.h:
  • svg/SVGPolylineElement.h:
  • svg/SVGPreserveAspectRatio.cpp: (WebCore::SVGPreserveAspectRatio::parsePreserveAspectRatio): (WebCore::SVGPreserveAspectRatio::transformRect):
  • svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::viewport):
  • svg/SVGSetElement.h:
  • svg/SVGStylable.h: (WebCore::SVGStylable::~SVGStylable):
  • svg/SVGStyledLocatableElement.h: (WebCore::SVGStyledLocatableElement::localCoordinateSpaceTransform): (WebCore::SVGStyledLocatableElement::isStyledLocatable):
  • svg/SVGStyledTransformableElement.cpp: (WebCore::SVGStyledTransformableElement::isKnownAttribute):
  • svg/SVGSwitchElement.cpp: (WebCore::SVGSwitchElement::childShouldCreateRenderer):
  • svg/SVGTests.cpp: (WebCore::SVGTests::parseMappedAttribute):
  • svg/SVGTextContentElement.cpp: (WebCore::SVGTextContentElement::isKnownAttribute):
  • svg/SVGTextPathElement.cpp:
  • svg/SVGTextPathElement.h:
  • svg/SVGTitleElement.h: (WebCore::SVGTitleElement::rendererIsNeeded):
  • svg/SVGTransformDistance.cpp: (WebCore::SVGTransformDistance::SVGTransformDistance): (WebCore::SVGTransformDistance::scaledDistance): (WebCore::SVGTransformDistance::addSVGTransforms): (WebCore::SVGTransformDistance::addSVGTransform): (WebCore::SVGTransformDistance::addToSVGTransform): (WebCore::SVGTransformDistance::isZero):
  • svg/SVGTransformList.cpp:
  • svg/SVGURIReference.cpp: (WebCore::SVGURIReference::getTarget):
  • svg/SVGVKernElement.h:
  • svg/SVGViewSpec.cpp: (WebCore::SVGViewSpec::parseViewSpec):
  • svg/SVGZoomAndPan.h: (WebCore::SVGZoomAndPan::SVGZoomAndPan): (WebCore::SVGZoomAndPan::~SVGZoomAndPan): (WebCore::SVGZoomAndPan::zoomAndPan):
  • svg/SVGZoomEvent.h: (WebCore::SVGZoomEvent::create):
  • svg/animation/SMILTime.cpp: (WebCore::operator*):
  • svg/animation/SMILTime.h: (WebCore::SMILTime::SMILTime): (WebCore::SMILTime::unresolved): (WebCore::SMILTime::indefinite): (WebCore::SMILTime::operator=): (WebCore::SMILTime::value): (WebCore::SMILTime::isFinite): (WebCore::SMILTime::isIndefinite): (WebCore::SMILTime::isUnresolved): (WebCore::operator==): (WebCore::operator!): new operator checks for 0 or infinite values. (WebCore::operator!=): (WebCore::operator>): (WebCore::operator<): (WebCore::operator>=): (WebCore::operator<=):
  • svg/animation/SMILTimeContainer.h: (WebCore::SMILTimeContainer::create): (WebCore::SMILTimeContainer::setDocumentOrderIndexesDirty):
  • svg/animation/SVGSMILElement.cpp: (WebCore::ConditionEventListener::operator==): (WebCore::SVGSMILElement::repeatingDuration): (WebCore::SVGSMILElement::resolveInterval): (WebCore::SVGSMILElement::calculateAnimationPercentAndRepeat):
  • svg/animation/SVGSMILElement.h: (WebCore::SVGSMILElement::timeContainer): (WebCore::SVGSMILElement::intervalBegin): (WebCore::SVGSMILElement::intervalEnd): (WebCore::SVGSMILElement::previousIntervalBegin): (WebCore::SVGSMILElement::documentOrderIndex): (WebCore::SVGSMILElement::setDocumentOrderIndex):
  • svg/graphics/SVGImage.h: (WebCore::SVGImage::create): (WebCore::SVGImage::destroyDecodedData): (WebCore::SVGImage::decodedSize): (WebCore::SVGImage::frameAtIndex):
  • svg/graphics/filters/SVGFilterBuilder.h: (WebCore::SVGFilterBuilder::create): (WebCore::SVGFilterBuilder::lastEffect): (WebCore::SVGFilterBuilder::getEffectReferences): (WebCore::SVGFilterBuilder::addBuiltinEffects):
22:36 Changeset [74781] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

2010-12-29 Abhishek Arya <inferno@chromium.org>

Reviewed by Darin Adler.

ASSERT(oldchild->parent() == owner) fails.
https://bugs.webkit.org/show_bug.cgi?id=50480

In RenderBlock removeChild function, when the inlineChildrenBlock(equal to prev or next)
is reparented to blockChildrenBlock, it is no longer a child of "this". This causes the
assertion failure when removeChildNode executes on the child(equal to prev or next).
Fix a typo in canMergeContiguousAnonymousBlocks.

Test: fast/multicol/span/double-merge-anonymous-block-crash.html

  • rendering/RenderBlock.cpp: (WebCore::canMergeContiguousAnonymousBlocks): fix typo, change prev to next. (WebCore::RenderBlock::removeChild): if prev or not is reparented, then set it to zero.

2010-12-29 Abhishek Arya <inferno@chromium.org>

Reviewed by Darin Adler.

Tests that we do not crash when merging anonymous blocks.
https://bugs.webkit.org/show_bug.cgi?id=50480

  • fast/multicol/span/double-merge-anonymous-block-crash-expected.txt: Added.
  • fast/multicol/span/double-merge-anonymous-block-crash.html: Added.
22:03 Changeset [74780] by dbates@webkit.org
  • 3 edits
    1 add in trunk/Tools

2010-12-29 Daniel Bates <dbates@rim.com>

Reviewed by Darin Adler.

svn-apply updates date of wrong change log entry for a change log diff that
contains two consecutive entries with the same author and date
https://bugs.webkit.org/show_bug.cgi?id=46061

Fixes an issue where the date of the wrong change log entry may be modified.
Moreover, changes fixChangeLogPatch() to move entries inserted earlier
in a ChangeLog file to the top of the file.

Currently, fixChangeLogPatch() explicitly bails out and returns an unchanged
diff when it detects that the diff inserts a change log entry earlier in a
ChangeLog. It is unusual to land a patch that has such a deliberate ChangeLog
change. With the advent of the commit-queue this functionality of bailing out
and hence landing the patch as-is is harmful to the accuracy of the ChangeLog.
Instead, we should always move the change log entry to the top of the ChangeLog file.

A side-effect of this change is that setChangeLogDateAndReviewer() now updates
the date line of the correct change log entry in a ChangeLog diff.

  • Scripts/VCSUtils.pm: Modified fixChangeLogPatch() to move entries inserted earlier to the top.
  • Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl: Updated the following unit tests now that we move entries inserted earlier to the top:
    • "fixChangeLogPatch: New entry inserted in middle." (formerly named "fixChangeLogPatch: [no change] New entry inserted in middle.")
  • "fixChangeLogPatch: New entry inserted earlier in the file, but after an entry with the same author and date." (formerly named "fixChangeLogPatch: [no change] New entry inserted earlier in the file, but after an entry with the same author and date.")
  • Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatchThenSetChangeLogDateAndReviewer.pl: Added.
21:43 Changeset [74779] by jschuh@chromium.org
  • 3 edits
    2 adds in trunk

2010-12-29 Justin Schuh <jschuh@chromium.org>

Reviewed by Darin Adler.

Check SVG element type in FrameView::scrollToAnchor
https://bugs.webkit.org/show_bug.cgi?id=51718

Test: svg/custom/scroll-to-anchor-in-symbol.svg

  • page/FrameView.cpp: (WebCore::FrameView::scrollToAnchor):

2010-12-29 Justin Schuh <jschuh@chromium.org>

Reviewed by Darin Adler.

Check SVG element type in FrameView::scrollToAnchor
https://bugs.webkit.org/show_bug.cgi?id=51718

  • svg/custom/scroll-to-anchor-in-symbol-expected.txt: Added.
  • svg/custom/scroll-to-anchor-in-symbol.svg: Added.
20:07 Changeset [74778] by antonm@chromium.org
  • 3 edits in trunk/WebCore

2010-12-29 Anton Muhin <antonm@chromium.org>

Reviewed by Eric Seidel.

[v8] Minor cleanup: remove unused method (the only method which can mutate context of V8DOMWindowShell)
https://bugs.webkit.org/show_bug.cgi?id=51704

  • bindings/v8/V8DOMWindowShell.cpp:
  • bindings/v8/V8DOMWindowShell.h:
19:54 Changeset [74777] by zmo@google.com
  • 3 edits in trunk/LayoutTests

2010-12-29 Zhenyao Mo <zmo@google.com>

Reviewed by Eric Seidel.

drawElements should raise INVALID_OPERATION if offset is not a multiple of the type size
https://bugs.webkit.org/show_bug.cgi?id=51726

  • fast/canvas/webgl/draw-elements-out-of-bounds-expected.txt:
  • fast/canvas/webgl/draw-elements-out-of-bounds.html: Add test cases to verify the behavior.
19:16 Changeset [74776] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

2010-12-29 Konstantin Tokarev <annulen@yandex.ru>

Reviewed by Eric Seidel.

[Qt] Fixed compatibility with gold linker on X11 platforms
https://bugs.webkit.org/show_bug.cgi?id=51700

  • DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: Linked TestNetscapePlugin with libX11 on Unix platforms
19:16 Changeset [74775] by commit-queue@webkit.org
  • 7 edits in trunk/WebCore

2010-12-29 Kenichi Ishibashi <bashi@google.com>

Reviewed by Darin Adler.

Use a HashMap for m_continuation to save memory
https://bugs.webkit.org/show_bug.cgi?id=43716

Saving memory consumption by applying a HashMap convention to
continuation pointers of RenderInline and RenderBlock classes.

  • rendering/RenderBlock.cpp: Removed m_continuation. (WebCore::RenderBlock::RenderBlock): (WebCore::RenderBlock::destroy): (WebCore::RenderBlock::inlineElementContinuation): (WebCore::RenderBlock::blockElementContinuation):
  • rendering/RenderBlock.h: Removed m_continuation.
  • rendering/RenderBoxModelObject.cpp: Added a hash map for continuations. (WebCore::RenderBoxModelObject::destroy): Added an assertion. (WebCore::RenderBoxModelObject::continuation): Added. (WebCore::RenderBoxModelObject::setContinuation): Added.
  • rendering/RenderBoxModelObject.h:
  • rendering/RenderInline.cpp: Removed m_continuation. (WebCore::RenderInline::RenderInline): (WebCore::RenderInline::destroy): (WebCore::RenderInline::inlineElementContinuation):
  • rendering/RenderInline.h: Removed m_continuation.
18:08 Changeset [74774] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

2010-12-29 Ademar de Souza Reis Jr <ademar.reis@openbossa.org>

Reviewed by Darin Adler.

Circular dependency in webkitpy.common.checkout.changelog module
https://bugs.webkit.org/show_bug.cgi?id=50475

Remove automatic import of api.Checkout module when any checkout/
submodule is imported (e.g.: when checkout.scm.Git is imported).

  • Scripts/webkitpy/common/checkout/init.py:
17:16 Changeset [74773] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2010-12-29 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium expectations update.

Remove failing expectations for three Mac tests that no longer fail.
Remove failing expectations for two canvas tests that no longer crash
(r74561, which caused the failing assert, was rolled out with r74587).

  • platform/chromium/test_expectations.txt:
17:05 Changeset [74772] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2010-12-29 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium expectations update.
fast/js/numeric-escapes-in-string-literals.html fails because V8 does
not support ECMAScript strict mode.

  • platform/chromium/test_expectations.txt:
17:00 Changeset [74771] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2010-12-29 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium expectations update. Mark two more inspector tests
as flaky.

  • platform/chromium/test_expectations.txt:
16:44 Changeset [74770] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2010-12-29 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium expectations update. Mark a few more tests as flaky.

  • platform/chromium/test_expectations.txt:
16:14 Changeset [74769] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2010-12-29 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium expectations update.

fast/canvas/shadow-offset-* are flaky when run in the GPU suite too.

  • platform/chromium-gpu/test_expectations.txt:
16:11 Changeset [74768] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2010-12-29 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium expectations update.

Make expectation for http/tests/media/reload-after-dialog.html not
trigger a duplication error for the debug Linux builder.

Remove expectation for platform/gtk/fast/text/emphasis-overlap.html, it
was removed in r74346.

  • platform/chromium/test_expectations.txt:
16:00 Changeset [74767] by barraclough@apple.com
  • 3 edits
    3 adds in trunk

Bug 51724 - In strict mode string literals should allow \0, but disallow \8 and \9.

Reviewed by Sam Weinig.

JavaScriptCore:

  • parser/Lexer.cpp:

(JSC::Lexer::parseString):

LayoutTests:

  • fast/js/numeric-escapes-in-string-literals-expected.txt: Added.
  • fast/js/numeric-escapes-in-string-literals.html: Added.
  • fast/js/script-tests/numeric-escapes-in-string-literals.js: Added.

(test):

15:46 Changeset [74766] by mrobinson@webkit.org
  • 8 edits
    2 adds in trunk

2010-12-27 Amruth Raj <amruthraj@motorola.com> and Ravi Kasibhatla <ravi.kasibhatla@motorola.com>

Reviewed by Martin Robinson.

[GTK] Enable building whatever already exists of WebKit2
https://bugs.webkit.org/show_bug.cgi?id=37369

No new functionality added or deleted. Only makefile change. Hence, no tests added.

  • GNUmakefile.am: Removed bindings/gobject from webcore_sources & webcore_cppflags and added them to WebKit/gtk/GNUmakefile.am
  • platform/network/soup/cache/webkit/soup-cache.h: Remove include <webkit/webkitdefines.h> and declare WEBKIT_API directly

2010-12-15 Amruth Raj <amruthraj@motorola.com> and Ravi Kasibhatla <ravi.kasibhatla@motorola.com>

Reviewed by Martin Robinson.

[GTK] Enable building whatever already exists of WebKit2
https://bugs.webkit.org/show_bug.cgi?id=37369

  • GNUmakefile.am: Added.
  • WebKit2Prefix.h: Included WebCore/config.h for GTK port as the first header file for WebKit2 sources files.
  • gtk: Added.
  • gtk/webkit2.pc.in: Added.
14:58 Changeset [74765] by mrobinson@webkit.org
  • 2 edits in trunk/WebKit/gtk

2010-12-29 Martin Robinson <mrobinson@igalia.com>

Build fix for GTK+.

  • webkit/webkitwebinspector.cpp: Add missing DumpRenderTreeSupportGtk include.
14:57 Changeset [74764] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-12-29 Eric Seidel <eric@webkit.org>

Unreviewed.

Simplify make-hash-tools.pl
https://bugs.webkit.org/show_bug.cgi?id=49922

Added HashTools.h to the project file now that its not autogenerated.
I also sorted the project file using sort-xcode-project-file

  • WebCore.xcodeproj/project.pbxproj:
14:56 Changeset [74763] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2010-12-29 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium expectations update. Mark another test as flaky.

  • platform/chromium/test_expectations.txt:
14:34 Changeset [74762] by mrobinson@webkit.org
  • 2 edits in trunk/WebKit/gtk

2010-12-29 Martin Robinson <mrobinson@igalia.com>

[GTK] GSettings warning is concealing real warnings on the build bots
https://bugs.webkit.org/show_bug.cgi?id=51691

Reviewed by Xan Lopez.

Do not print the GSettings warning message when running in DumpRenderTree.

  • webkit/webkitwebinspector.cpp: (inspectorGSettings): Do not print the GSettings warning if we are running in DumpRenderTree. This should clean up the test results page a great deal.
14:22 Changeset [74761] by pfeldman@chromium.org
  • 15 edits
    1 copy
    2 moves
    1 add
    2 deletes in trunk

2010-12-29 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: revert r74755 and 74757.

14:20 Changeset [74760] by mrobinson@webkit.org
  • 2 edits in trunk/WebCore

2010-12-29 Martin Robinson <mrobinson@igalia.com>

Reviewed by Sam Weinig.

JSDataViewCustom.cpp gives the fastcall calling convention to functions called via C++
https://bugs.webkit.org/show_bug.cgi?id=51722

Remove the JSC_HOST_CALL from methods that are called from C++. JSC_HOST_CALL gives
methods the fastcall calling convention, which leads to runtime errors when they are
called from C++. Also remove a bit of unnecessary code duplication.

No new tests. This is covered by fast/canvas/webgl/data-view-test.html.

  • bindings/js/JSDataViewCustom.cpp: (WebCore::getDataViewMember): Remove duplicated code. (WebCore::JSDataView::getInt8): Remove JSC_HOST_CALL. (WebCore::JSDataView::getUint8): Ditto. (WebCore::JSDataView::getFloat32): Ditto. (WebCore::JSDataView::getFloat64): Ditto. (WebCore::setDataViewMember): Remove duplicated code. (WebCore::JSDataView::setInt8): Remove JSC_HOST_CALL. (WebCore::JSDataView::setUint8): Ditto.
14:18 Changeset [74759] by mitz@apple.com
  • 5 edits in trunk/WebCore

A more robust fix for https://bugs.webkit.org/show_bug.cgi?id=51681

Reviewed by Kenneth Russel.

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::attach): Added. Like recalcStyle(), calls
CanvasRenderingContext2D::updateFont() if necessary. This covers the case of a detach/
attach-type style recalc.

  • html/HTMLCanvasElement.h:
  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::drawTextInternal): Removed the early return added in
r74716. A font that is loading custom fonts is okay to use, as long as it is valid.
(WebCore::CanvasRenderingContext2D::accessFont): Added a call to
Document::updateStyleIfNeeded(). This ensures that any pending style recalc will take place
and update the font if it is invalid.

  • platform/graphics/Font.h:

(WebCore::Font::loadingCustomFonts): Made this private.

13:43 Changeset [74758] by mihaip@chromium.org
  • 3 edits in trunk/LayoutTests

2010-12-29 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium expectations update.

fast/canvas/webgl/tex-image-with-format-and-type.html is flaky in
the GPU suite too.

  • platform/chromium/test_expectations.txt:
  • platform/chromium-gpu/test_expectations.txt:
13:39 Changeset [74757] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2010-12-29 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: Qt build fix.

  • inspector/InspectorController.cpp:
13:38 Changeset [74756] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2010-12-29 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium expectations update.

Remove failure expectations for tests that no longer fail:

  • fast/images/svg-as-background.html has not timed out for as long as the flakiness dashboard has history
  • svg/W3C-SVG-1.1/animate-elem-03-t.svg has not failed for as long as the flakiness dashboard has history
  • platform/chromium/test_expectations.txt:
13:30 Changeset [74755] by pfeldman@chromium.org
  • 15 edits
    1 copy
    2 moves
    1 add
    2 deletes in trunk

2010-12-29 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: extract Database & DOM Storage
agents; remove InspectorBackend.
https://bugs.webkit.org/show_bug.cgi?id=51707

This change brushes up storage agents + removes redundant
InspectorBackend class.

  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/CodeGeneratorInspector.pm:
  • inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::databaseForId): (WebCore::InjectedScriptHost::selectDatabase): (WebCore::InjectedScriptHost::selectDOMStorage): (WebCore::InjectedScriptHost::inspectorDOMAgent):
  • inspector/Inspector.idl:
  • inspector/InspectorBackend.cpp: Removed.
  • inspector/InspectorBackend.h: Removed.
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::~InspectorController): (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::releaseFrontendLifetimeAgents): (WebCore::InspectorController::didUseDOMStorage): (WebCore::InspectorController::setInjectedScriptSource): (WebCore::InspectorController::dispatchOnInjectedScript): (WebCore::InspectorController::releaseWrapperObjectGroup):
  • inspector/InspectorController.h:
  • inspector/InspectorDOMStorageAgent.cpp: Added. (WebCore::InspectorDOMStorageAgent::~InspectorDOMStorageAgent): (WebCore::InspectorDOMStorageAgent::getDOMStorageEntries): (WebCore::InspectorDOMStorageAgent::setDOMStorageItem): (WebCore::InspectorDOMStorageAgent::removeDOMStorageItem): (WebCore::InspectorDOMStorageAgent::selectDOMStorage): (WebCore::InspectorDOMStorageAgent::InspectorDOMStorageAgent): (WebCore::InspectorDOMStorageAgent::getDOMStorageResourceForId):
  • inspector/InspectorDOMStorageAgent.h: Copied from WebCore/inspector/InspectorStorageAgent.h. (WebCore::InspectorDOMStorageAgent::create): (WebCore::InspectorDOMStorageAgent::frontend):
  • inspector/InspectorDatabaseAgent.cpp: Renamed from WebCore/inspector/InspectorStorageAgent.cpp. (WebCore::InspectorDatabaseAgent::~InspectorDatabaseAgent): (WebCore::InspectorDatabaseAgent::getDatabaseTableNames): (WebCore::InspectorDatabaseAgent::executeSQL): (WebCore::InspectorDatabaseAgent::databaseForId): (WebCore::InspectorDatabaseAgent::selectDatabase): (WebCore::InspectorDatabaseAgent::clearFrontend): (WebCore::InspectorDatabaseAgent::InspectorDatabaseAgent):
  • inspector/InspectorDatabaseAgent.h: Renamed from WebCore/inspector/InspectorStorageAgent.h. (WebCore::InspectorDatabaseAgent::create): (WebCore::InspectorDatabaseAgent::frontend):
  • inspector/InspectorFrontendClientLocal.cpp:
  • inspector/InspectorFrontendClientLocal.h:
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.show):
13:24 Changeset [74754] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2010-12-29 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium expectations update.
Add recent upstream expectations Chromium changes.

  • platform/chromium/test_expectations.txt:
12:49 Changeset [74753] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2010-12-29 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium expectations update.
Mark http/tests/incremental/split-hex-entities.pl as flaky.

  • platform/chromium/test_expectations.txt:
12:39 Changeset [74752] by tonyg@chromium.org
  • 3 edits
    5 adds in trunk

2010-12-29 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Eric Seidel.

Assertion failure: element->inDocument() in AsyncScriptRunner::executeScriptSoon()
https://bugs.webkit.org/show_bug.cgi?id=51067

  • fast/dom/HTMLScriptElement/move-in-beforeload-expected.txt: Added.
  • fast/dom/HTMLScriptElement/move-in-beforeload.html: Added.
  • fast/dom/HTMLScriptElement/remove-in-beforeload-expected.txt: Added.
  • fast/dom/HTMLScriptElement/remove-in-beforeload.html: Added.

2010-12-29 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Eric Seidel.

Assertion failure: element->inDocument() in AsyncScriptRunner::executeScriptSoon()
https://bugs.webkit.org/show_bug.cgi?id=51067

Typically when a script element is removed from the document, the cached script
client is removed. However, during the before load event, the cached script client
hasn't been created yet so it can't be removed.

This patch handles that case by explicitly checking if the script element was
removed during the beforeload event. Also, it avoids caching the Document references
over the arbitrary script execution in the before load event.

Test: fast/dom/HTMLScriptElement/move-in-beforeload.html

fast/dom/HTMLScriptElement/remove-in-beforeload.html

  • dom/ScriptElement.cpp: (WebCore::ScriptElement::requestScript):
12:02 Changeset [74751] by mitz@apple.com
  • 4 edits in trunk/WebKit/mac

<rdar://problem/8758191> REGRESSION (r72887): Mail crashes when doing searches in a message due to method name conflict
https://bugs.webkit.org/show_bug.cgi?id=51717

Reviewed by Ada Chan.

Renamed -findString:options: to -_findString:options: in the WebDocumentOptionsSearching
protocol to avoid conflict with -[WebHTMLView(MailExtras) findString:options:] which Mail defines.

  • WebView/WebDocumentInternal.h:
  • WebView/WebHTMLView.mm:

(-[WebHTMLView searchFor:direction:caseSensitive:wrap:startInSelection:]):
(-[WebHTMLView _findString:options:]):

  • WebView/WebView.mm:

(findString):

11:20 Changeset [74750] by mihaip@chromium.org
  • 1 edit
    2 adds
    1 delete in trunk/LayoutTests

2010-12-29 Mihai Parparita <mihaip@chromium.org>

Unreviewed, rolling out r74748.
http://trac.webkit.org/changeset/74748

r74735 was rolled out with r74749, the expectations update
should be rolled out too

  • platform/chromium-mac/fast/events/ime-composition-events-001-expected.txt: Added.
  • platform/chromium-win/fast/events/ime-composition-events-001-expected.txt: Added.
  • platform/chromium/fast/events/ime-composition-events-001-expected.txt: Removed.
11:13 Changeset [74749] by commit-queue@webkit.org
  • 4 edits in trunk

2010-12-29 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r74735.
http://trac.webkit.org/changeset/74735
https://bugs.webkit.org/show_bug.cgi?id=51715

assert failures on fast/forms/input-maxlength-ime-
completed.html (Requested by mihaip on #webkit).

  • platform/chromium/test_expectations.txt:

2010-12-29 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r74735.
http://trac.webkit.org/changeset/74735
https://bugs.webkit.org/show_bug.cgi?id=51715

assert failures on fast/forms/input-maxlength-ime-
completed.html (Requested by mihaip on #webkit).

  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::setMarkedText):
10:17 Changeset [74748] by mihaip@chromium.org
  • 1 edit
    1 add
    2 deletes in trunk/LayoutTests

2010-12-29 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium baselines. Update Chromium baselines for
fast/events/ime-composition-events-001.html after r74735 (the
new baselines are closer to the upstream Mac ones).

  • platform/chromium-mac/fast/events/ime-composition-events-001-expected.txt: Removed.
  • platform/chromium-win/fast/events/ime-composition-events-001-expected.txt: Removed.
  • platform/chromium/fast/events/ime-composition-events-001-expected.txt: Added.
10:12 Changeset [74747] by mihaip@chromium.org
  • 1 edit
    7 adds in trunk/LayoutTests

2010-12-29 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium baselines. Add Chromium baselines for the
layout test added by r74743.

  • platform/chromium-linux/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.checksum: Added.
  • platform/chromium-linux/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.png: Added.
  • platform/chromium-mac/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.checksum: Added.
  • platform/chromium-mac/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.png: Added.
  • platform/chromium-win/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.checksum: Added.
  • platform/chromium-win/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.png: Added.
  • platform/chromium-win/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt: Added.
10:03 Changeset [74746] by mrobinson@webkit.org
  • 2 edits in trunk/Tools

2010-12-29 Martin Robinson <mrobinson@igalia.com>

Reviewed by Ojan Vafai.

prepare-ChangeLog should support the -g option for specifying the git-commit
https://bugs.webkit.org/show_bug.cgi?id=51708

Add a -g shortcut for the --git-commit prepare-ChangeLog option. This matches
webkit-patch, though the exact meaning of the two options remain different.

  • Scripts/prepare-ChangeLog: Add -g.
10:01 Changeset [74745] by apavlov@chromium.org
  • 2 edits in trunk/WebCore

2010-12-29 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Element highlight tooltip displays wrong element size when zoomed in
https://bugs.webkit.org/show_bug.cgi?id=51703

  • inspector/InspectorController.cpp: (WebCore::InspectorController::drawElementTitle):
08:00 Changeset [74744] by yael.aharon@nokia.com
  • 16 edits
    9 adds in trunk

[HTML5][Forms] Support for :in-range and :out-of-range CSS selectors
https://bugs.webkit.org/show_bug.cgi?id=29071

Reviewed by Kent Tamura.

WebCore:

Use InputType::rangeUnderflow() and InputType::rangeOverflow()
to determine if a control is in-range or out-of-range.

Tests: fast/css/pseudo-in-range-invalid-value.html

fast/css/pseudo-in-range.html
fast/css/pseudo-out-of-range.html

  • css/CSSSelector.cpp:

(WebCore::CSSSelector::pseudoId):
(WebCore::nameToPseudoTypeMap):
(WebCore::CSSSelector::extractPseudoType):

  • css/CSSSelector.h:
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::canShareStyleWithElement):
(WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):

  • dom/Element.h:

(WebCore::Element::isInRange):
(WebCore::Element::isOutOfRange):

  • html/BaseDateAndTimeInputType.cpp:

(WebCore::BaseDateAndTimeInputType::supportsRangeLimitation):

  • html/BaseDateAndTimeInputType.h:
  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::isInRange):
(WebCore::HTMLInputElement::isOutOfRange):

  • html/HTMLInputElement.h:
  • html/InputType.cpp:

(WebCore::InputType::supportsRangeLimitation):

  • html/InputType.h:
  • html/NumberInputType.cpp:

(WebCore::NumberInputType::supportsRangeLimitation):

  • html/NumberInputType.h:
  • html/RangeInputType.cpp:

(WebCore::RangeInputType::supportsRangeLimitation):

  • html/RangeInputType.h:

LayoutTests:

  • fast/css/pseudo-in-range-expected.txt: Added.
  • fast/css/pseudo-in-range-invalid-value-expected.txt: Added.
  • fast/css/pseudo-in-range-invalid-value.html: Added.
  • fast/css/pseudo-in-range.html: Added.
  • fast/css/pseudo-out-of-range-expected.txt: Added.
  • fast/css/pseudo-out-of-range.html: Added.
  • fast/css/script-tests/pseudo-in-range-invalid-value.js: Added.
  • fast/css/script-tests/pseudo-in-range.js: Added.
  • fast/css/script-tests/pseudo-out-of-range.js: Added.
07:50 Changeset [74743] by inferno@chromium.org
  • 3 edits
    4 adds in trunk

2010-12-29 Abhishek Arya <inferno@chromium.org>

Reviewed by Eric Seidel.

When cloning an anonymous block, make sure to set the childrenInline flag based
on the state of the block to be cloned.
https://bugs.webkit.org/show_bug.cgi?id=51489

Test: fast/multicol/span/clone-anonymous-block-non-inline-child-crash.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::clone): add code to handle cloning of anonymous blocks. (WebCore::RenderBlock::splitBlocks): remove anonymous block creation calls since it is now handled by clone().

2010-12-29 Abhishek Arya <inferno@chromium.org>

Reviewed by Eric Seidel.

Tests that cloning an anonymous block with non inline children does not crash.
https://bugs.webkit.org/show_bug.cgi?id=51489

  • fast/multicol/span/clone-anonymous-block-non-inline-child-crash.html: Added.
  • platform/mac/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.checksum: Added.
  • platform/mac/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.png: Added.
  • platform/mac/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt: Added.
07:38 Changeset [74742] by paroga@webkit.org
  • 6 edits in trunk

2010-12-29 Patrick Gansterer <paroga@webkit.org>

Unreviewed build fix for WinCE after r73802.

Reapply parts from r72585:
Port ContextMenuWin.cpp to WinCE
https://bugs.webkit.org/show_bug.cgi?id=48408

  • CMakeLists.txt:
  • platform/ContextMenu.h:
  • platform/win/ContextMenuWin.cpp: (WebCore::ContextMenu::getContextMenuItems): (WebCore::ContextMenu::createNativeMenuFromItems):

2010-12-29 Patrick Gansterer <paroga@webkit.org>

Unreviewed build fix for WinCE after r73802.

  • WebCoreSupport/ContextMenuClientWinCE.cpp: (WebKit::ContextMenuClientWinCE::customizeMenu):
  • WebCoreSupport/ContextMenuClientWinCE.h:
05:39 Changeset [74741] by kent.hansen@nokia.com
  • 12 edits in trunk

2010-12-29 Kent Hansen <kent.hansen@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Fix compilation with Qt in namespace
https://bugs.webkit.org/show_bug.cgi?id=51701

  • QtTestBrowser/webview.h:

2010-12-29 Kent Hansen <kent.hansen@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Fix compilation with Qt in namespace
https://bugs.webkit.org/show_bug.cgi?id=51701

  • platform/graphics/ContextShadow.h:
  • platform/graphics/GraphicsContext3D.h:
  • platform/network/NetworkingContext.h:
  • platform/network/qt/QtNAMThreadSafeProxy.h:
  • plugins/PluginView.h:

2010-12-29 Kent Hansen <kent.hansen@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Fix compilation with Qt in namespace
https://bugs.webkit.org/show_bug.cgi?id=51701

  • Api/qwebkitplatformplugin.h:
  • WebCoreSupport/InspectorServerQt.h:
  • tests/hybridPixmap/widget.h:
04:41 Fingerprinting edited by robert@roberthogan.net
(diff)
03:53 Changeset [74740] by apavlov@chromium.org
  • 3 edits
    2 adds in trunk

2010-12-28 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: A disabled style property should get enabled when edited
https://bugs.webkit.org/show_bug.cgi?id=51679

  • inspector/styles-disable-then-change-expected.txt: Added.
  • inspector/styles-disable-then-change.html: Added.

2010-12-28 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: A disabled style property should get enabled when edited
https://bugs.webkit.org/show_bug.cgi?id=51679

Test: inspector/styles-disable-then-change.html

  • inspector/front-end/CSSStyleModel.js: (WebInspector.CSSProperty.prototype.setText): (WebInspector.CSSProperty.prototype.setText.callback):
03:35 Changeset [74739] by paroga@webkit.org
  • 4 edits in trunk

2010-12-29 Patrick Gansterer <paroga@webkit.org>

Unreviewed. Use gcc as default preprocessor.

  • Sources/cmake/OptionsCommon.cmake:

2010-12-29 Patrick Gansterer <paroga@webkit.org>

Reviewed by Andreas Kling.

[CMake] Remove WebKitGenerators
https://bugs.webkit.org/show_bug.cgi?id=50445

  • CMakeLists.txt: Pass preprocessor to generate-bindings.pl.
03:22 Changeset [74738] by commit-queue@webkit.org
  • 3 edits in trunk/WebKit2

2010-12-29 Juha Savolainen <juha.savolainen@weego.fi>

Reviewed by Kenneth Rohde Christiansen.

[Qt] [WK2] Added more webattributes to the qwkpreferences
https://bugs.webkit.org/show_bug.cgi?id=51697

Added PrivateBrowsingEnabled, DeveloperExtrasEnabled, DnsPrefetchEnabled attributes

  • UIProcess/API/qt/qwkpreferences.cpp: (QWKPreferences::testAttribute): (QWKPreferences::setAttribute):
  • UIProcess/API/qt/qwkpreferences.h:
01:32 Changeset [74737] by commit-queue@webkit.org
  • 5 edits in trunk

2010-12-29 Helder Correia <helder@sencha.com>

Reviewed by Eric Seidel.

<VT> and <FF> are not valid JSON whitespace characters
https://bugs.webkit.org/show_bug.cgi?id=51671

Vertical Tab and Form Feed are not allowed white spaces by the JSON
RFC 4627: http://www.ietf.org/rfc/rfc4627.txt (2. JSON Grammar).

Tests: ietestcenter/Javascript/15.12.1.1-0-2.html

ietestcenter/Javascript/15.12.1.1-0-3.html

  • runtime/LiteralParser.cpp: (JSC::isJSONWhiteSpace): (JSC::LiteralParser::Lexer::lex):

2010-12-29 Helder Correia <helder@sencha.com>

Reviewed by Eric Seidel.

<VT> and <FF> are not valid JSON whitespace characters
https://bugs.webkit.org/show_bug.cgi?id=51671

Vertical Tab and Form Feed are not allowed white spaces by the JSON
RFC 4627: http://www.ietf.org/rfc/rfc4627.txt (2. JSON Grammar).

  • ietestcenter/Javascript/15.12.1.1-0-2-expected.txt:
  • ietestcenter/Javascript/15.12.1.1-0-3-expected.txt:
01:30 Changeset [74736] by philn@webkit.org
  • 2 edits in trunk/LayoutTests

2010-12-29 Philippe Normand <pnormand@igalia.com>

Unreviewed, skip flaky test on GTK.

[GTK] editing/selection/extend-by-character-004.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=51699

  • platform/gtk/Skipped:
01:22 Changeset [74735] by commit-queue@webkit.org
  • 4 edits in trunk

2010-12-29 Zhe Su <suzhe@chromium.org>

Reviewed by Eric Seidel.

Remove entry for editing/input/ime-composition-clearpreedit.html test.
https://bugs.webkit.org/show_bug.cgi?id=51693

  • platform/chromium/test_expectations.txt:

2010-12-29 Zhe Su <suzhe@chromium.org>

Reviewed by Eric Seidel.

Fix editing/input/ime-composition-clearpreedit.html test in chromium
by removing the line "editor->confirmComposition(text);" from
WebFrameImpl::setMarkedText() method, because that line will insert the
text into the focused node, which is apparently wrong.

https://bugs.webkit.org/show_bug.cgi?id=51693

  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::setMarkedText):

12/28/10:

23:45 Changeset [74734] by commit-queue@webkit.org
  • 12 edits in trunk/WebCore

2010-12-28 Pratik Solanki <psolanki@apple.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=51522
Use deviceRGBColorSpaceRef() instead of calling CGColorSpaceCreateDeviceRGB()

  • page/win/FrameCGWin.cpp: (WebCore::imageFromRect):
  • platform/graphics/cg/GradientCG.cpp: (WebCore::Gradient::platformGradient):
  • platform/graphics/cg/GraphicsContext3DCG.cpp: (WebCore::GraphicsContext3D::paintToCanvas):
  • platform/graphics/cg/ImageCG.cpp: (WebCore::BitmapImage::checkForSolidColor):
  • platform/graphics/gstreamer/ImageGStreamerCG.mm: (ImageGStreamer::ImageGStreamer):
  • platform/graphics/win/GraphicsContextCGWin.cpp: (WebCore::CGContextWithHDC): (WebCore::GraphicsContext::releaseWindowsContext): (WebCore::GraphicsContext::drawWindowsBitmap):
  • platform/graphics/win/ImageCGWin.cpp: (WebCore::BitmapImage::create): (WebCore::BitmapImage::getHBITMAPOfSize):
  • platform/image-decoders/cg/ImageDecoderCG.cpp: (WebCore::createColorSpace):
  • platform/win/DragImageCGWin.cpp: (WebCore::allocImage): (WebCore::createCgContextFromBitmap):
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintMenuListButtonGradients): (WebCore::RenderThemeMac::paintSliderTrack):
  • rendering/RenderThemeSafari.cpp: (WebCore::RenderThemeSafari::paintMenuListButtonGradients): (WebCore::RenderThemeSafari::paintSliderTrack):
16:59 Changeset [74733] by dbates@webkit.org
  • 19 edits in trunk

2010-12-28 Daniel Bates <dbates@rim.com>

Reviewed by Sam Weinig.

Substitute MARK: for compiler-specific #pragma mark
https://bugs.webkit.org/show_bug.cgi?id=51657

For consistency, we should substitute " MARK:" for compiler-
specific "#pragma mark" in the source files for the Mac port.

  • History/WebHistory.mm:
  • Plugins/WebBaseNetscapePluginView.mm:
  • Plugins/WebNetscapePluginView.mm:
  • WebCoreSupport/WebInspectorClient.mm:
  • WebCoreSupport/WebSecurityOrigin.mm:
  • WebView/WebPDFView.mm:
  • WebView/WebVideoFullscreenController.mm:
  • WebView/WebVideoFullscreenHUDWindowController.mm:

2010-12-28 Daniel Bates <dbates@rim.com>

Reviewed by Sam Weinig.

Substitute MARK: for compiler-specific #pragma mark
https://bugs.webkit.org/show_bug.cgi?id=51657

Fix compilation warnings about "#pragma mark" on GTK+ bots by
substituting " MARK:" for "#pragma mark", which provides
analogous code-bookmarking functionality under Xcode.

  • platform/graphics/cg/PathCG.cpp:
  • platform/graphics/mac/WebLayer.mm:

2010-12-28 Daniel Bates <dbates@rim.com>

Reviewed by Sam Weinig.

Substitute MARK: for compiler-specific #pragma mark
https://bugs.webkit.org/show_bug.cgi?id=51657

Fix future compilation warnings about "#pragma mark" on GTK+ bots by
substituting " MARK:" for "#pragma mark", which provides
analogous code-bookmarking functionality under Xcode.

Also, for consistency, we should substitute " MARK:" for compiler-
specific "#pragma mark" in the source files for the Mac port.

  • DumpRenderTree/AccessibilityTextMarker.cpp:
  • DumpRenderTree/cf/WebArchiveDumpSupport.h:
  • DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
  • DumpRenderTree/mac/ObjCController.m:
  • MiniBrowser/mac/AppDelegate.m:
  • MiniBrowser/mac/BrowserWindowController.m:
16:56 Changeset [74732] by dbates@webkit.org
  • 2 edits in trunk/LayoutTests

2010-12-28 Daniel Bates <dbates@rim.com>

Reviewed by Antonio Gomes.

Add comment to test case fast/repaint/no-caret-repaint-in-non-content-editable-element.html
to clarify caret browsing disabled
https://bugs.webkit.org/show_bug.cgi?id=51633

Add a comment to test case fast/repaint/no-caret-repaint-in-non-content-editable-element.html
that explains that this test is only applicable when caret browsing is disabled.

  • fast/repaint/no-caret-repaint-in-non-content-editable-element.html:
16:39 Changeset [74731] by mrobinson@webkit.org
  • 3 edits in trunk/WebKit/gtk

2010-12-28 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Closing a window during an onload event can trigger serious GLib warnings
https://bugs.webkit.org/show_bug.cgi?id=51686

Don't emit the close-web-view signal immediately during execution of closeWindowSoon.
The signal handler may choose to destroy the web view while handling that signal,
which may remove the last reference to the web view. FrameLoaderClient depends on the
view still existing though. Instead, let the caller finish executing and emit the signal
after a 0 length timeout. This matches the behavior on the Windows and Mac ports.

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::ChromeClient): Initialize the timer id. (WebKit::emitCloseWebViewSignalLater): Callback for the timer. (WebKit::ChromeClient::closeWindowSoon): Do the actual signal invocation after the caller finishes its tasks.
  • WebCoreSupport/ChromeClientGtk.h: Add a new member for the timer id. We can use this to prevent emitting the close-web-view signal twice.
15:39 Changeset [74730] by mrobinson@webkit.org
  • 2 edits in trunk/WebKit/gtk

2010-12-28 Martin Robinson <mrobinson@igalia.com>

Reviewed by Eric Seidel.

[GTK] Clean up usage of NULL in webkitwebframe.cpp
https://bugs.webkit.org/show_bug.cgi?id=51685

Replace occurrences of NULL with 0, in webkitwebframe.cpp. Not all
uses of NULL have been changed, as certain GLib functions require
an explicit NULL as a sentinel.

  • webkit/webkitwebframe.cpp: (webkit_web_frame_get_data_source_from_core_loader): (webkit_web_frame_class_init): (webkit_web_frame_new): (webkit_web_frame_get_title): (webkit_web_frame_get_uri): (webkit_web_frame_get_web_view): (webkit_web_frame_get_name): (webkit_web_frame_get_parent): (webkit_web_frame_load_string): (webkit_web_frame_load_alternate_string): (webkit_web_frame_find_frame): (webkit_web_frame_get_global_context): (webkit_web_frame_get_data_source): (webkit_web_frame_get_provisional_data_source): (webkit_web_frame_print_full): (webkit_web_frame_get_security_origin): (webkit_web_frame_get_network_response):
15:16 Changeset [74729] by kbr@google.com
  • 3 edits in trunk/LayoutTests

2010-12-28 Kenneth Russell <kbr@google.com>

Reviewed by Eric Seidel.

Make fast/canvas/canvas-save-restore-with-path.js more robust
https://bugs.webkit.org/show_bug.cgi?id=51665

  • fast/canvas/canvas-save-restore-with-path-expected.txt:
  • fast/canvas/canvas-save-restore-with-path.js:
14:56 Changeset [74728] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-12-28 Jan Erik Hanssen <jhanssen@sencha.com>

Reviewed by Eric Seidel.

[Qt] GraphicsContext::getCTM() does not need to make a copy of QPainter::combinedTransform()
https://bugs.webkit.org/show_bug.cgi?id=51687

Use a const reference instead of a copy of QPainter::combinedTransform()
in GraphicsContext::getCTM()

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::getCTM):
14:45 Changeset [74727] by commit-queue@webkit.org
  • 4 edits in trunk

2010-12-28 Helder Correia <helder@sencha.com>

Reviewed by Eric Seidel.

JSON.stringify must exist as a function taking 3 parameters
https://bugs.webkit.org/show_bug.cgi?id=51667

The reported function length is 1 instead.

Test: ietestcenter/Javascript/15.12.3-0-2.html

  • runtime/JSONObject.cpp:

2010-12-28 Helder Correia <helder@sencha.com>

Reviewed by Eric Seidel.

JSON.stringify must exist as a function taking 3 parameters
https://bugs.webkit.org/show_bug.cgi?id=51667

The reported function length is 1 instead.

  • ietestcenter/Javascript/15.12.3-0-2-expected.txt:
14:20 Changeset [74726] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

2010-12-28 Xan Lopez <xlopez@igalia.com>

Reviewed by Eric Seidel.

Add --no-build option to run-sunspider
https://bugs.webkit.org/show_bug.cgi?id=51658

  • Scripts/run-sunspider: add --no-build flag to skip building phase.
14:16 Fingerprinting edited by robert@roberthogan.net
(diff)
14:14 Changeset [74725] by commit-queue@webkit.org
  • 3 edits in trunk/WebCore

2010-12-28 Takashi Toyoshima <toyoshim@google.com>

Reviewed by Eric Seidel.

gcc detected 'control reaches end of non-void function' with
-finstrument-functions option.
https://bugs.webkit.org/show_bug.cgi?id=51669

No new tests. These fixes are trivial.

  • dom/Element.cpp: (WebCore::Element::childTypeAllowed):
  • inspector/InspectorResourceAgent.cpp: (WebCore::cachedResourceTypeString):
14:11 Fingerprinting created by robert@roberthogan.net
13:57 Changeset [74724] by tonyg@chromium.org
  • 4 edits in trunk/WebCore

2010-12-28 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Eric Seidel.

Remove unused member of PendingScript
https://bugs.webkit.org/show_bug.cgi?id=51684

This was used when HTMLScriptRunner::runScript created a PendingScript
for inline scripts. But now it just calls executeScript() directly.
External scripts always have the minimum starting line number.

No new tests because no changed functionality.

  • dom/PendingScript.cpp: (WebCore::PendingScript::releaseElementAndClear):
  • dom/PendingScript.h: (WebCore::PendingScript::PendingScript): (WebCore::PendingScript::operator=):
  • html/parser/HTMLScriptRunner.cpp: (WebCore::HTMLScriptRunner::sourceFromPendingScript):
13:57 Changeset [74723] by tonikitoo@webkit.org
  • 4 edits in trunk/WebCore

2010-12-20 Antonio Gomes <agomes@rim.com>

Reviewed by Daniel Bates.

Spatial Navigation: code clean up (Part VI)
https://bugs.webkit.org/show_bug.cgi?id=50666

No new tests needed.

  • page/FocusController.cpp: (WebCore::updatFocusCandidateIfNeeded): Assert renderer() and isElementNode() now that we are bailing out earlier in both the FocusCandidate constructor and FocusController::findFocusCandidateInContainer().
  • page/SpatialNavigation.h: Swapped the parameters order in canScrollInDirection and virtualRectForAreaElementAndDirection functions. (WebCore::FocusController::findFocusCandidateInContainer): (WebCore::FocusController::advanceFocusDirectionallyInContainer): Adjusted call sites of canScrollInDirection(), and added an early return if !isElementNode(). (WebCore::FocusController::advanceFocusDirectionally): Adjusted call site of virtualRectForAreaElementAndDirection().
  • page/SpatialNavigation.cpp: (WebCore::FocusCandidate::FocusCandidate): Assert if node is not an Element node. (WebCore::isScrollableNode): Renamed from isScrollableContainerNode. (WebCore::scrollInDirection): Adjusted call site after function name change; (WebCore::scrollableEnclosingBoxOrParentFrameForNodeInDi:rection): Assert if node is a Document node. (WebCore::canScrollInDirection): Signature changed. (WebCore::canBeScrolledIntoView): Ditto. (WebCore::virtualRectForAreaElementAndDirection): Ditto.
13:53 Changeset [74722] by enne@google.com
  • 2 edits in trunk/WebCore

2010-12-28 Adrienne Walker <enne@google.com>

Reviewed by Kenneth Russell.

[chromium] Fix tiled compositor assertion after GPU process recovery.
https://bugs.webkit.org/show_bug.cgi?id=51682

After the GPU process recovers, the layer size is set to IntSize(),
but IntRect::unite() has a special case for empty rects. This
behavior was causing the layer size to be too small, causing an
out-of-bounds array access elsewhere.

No new tests.

  • platform/graphics/chromium/LayerTilerChromium.cpp: (WebCore::LayerTilerChromium::growLayerToContain):
13:36 Changeset [74721] by commit-queue@webkit.org
  • 4 edits in trunk

2010-12-28 Helder Correia <helder@sencha.com>

Reviewed by Sam Weinig.

JSON.parse must exist as a function taking 2 parameters
https://bugs.webkit.org/show_bug.cgi?id=51666

Support for revivers was introduced in bug 26591, but the function
length has since remained unchanged.

Test: ietestcenter/Javascript/15.12.2-0-2.html

  • runtime/JSONObject.cpp:

2010-12-28 Helder Correia <helder@sencha.com>

Reviewed by Sam Weinig.

JSON.parse must exist as a function taking 2 parameters
https://bugs.webkit.org/show_bug.cgi?id=51666

Support for revivers was introduced in bug 26591, but the function
length has since remained unchanged.

  • ietestcenter/Javascript/15.12.2-0-2-expected.txt: Change expected result to success.
13:35 Changeset [74720] by zmo@google.com
  • 16 edits in trunk

2010-12-23 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Initialize to 0 for undefined values in CopyTexImage2D
https://bugs.webkit.org/show_bug.cgi?id=51421

  • src/GraphicsContext3DChromium.cpp: Implement getInternalFramebufferSize(). (WebCore::GraphicsContext3DInternal::getInternalFramebufferSize):
  • src/GraphicsContext3DInternal.h:

2010-12-23 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Initialize to 0 for undefined values in CopyTexImage2D
https://bugs.webkit.org/show_bug.cgi?id=51421

  • html/canvas/WebGLFramebuffer.cpp: Track width/height/internalFormat of color buffer. (WebCore::WebGLFramebuffer::WebGLFramebuffer): (WebCore::WebGLFramebuffer::setAttachment): (WebCore::WebGLFramebuffer::getWidth): (WebCore::WebGLFramebuffer::getHeight): (WebCore::WebGLFramebuffer::getColorBufferFormat):
  • html/canvas/WebGLFramebuffer.h:
  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::copyTexImage2D): Initialize undefined pixels to 0. (WebCore::WebGLRenderingContext::copyTexSubImage2D): (WebCore::WebGLRenderingContext::framebufferTexture2D): (WebCore::WebGLRenderingContext::renderbufferStorage): (WebCore::WebGLRenderingContext::getBoundFramebufferWidth): (WebCore::WebGLRenderingContext::getBoundFramebufferHeight):
  • html/canvas/WebGLRenderingContext.h:
  • html/canvas/WebGLTexture.cpp: Track width/height/internalFormat of a texture by target/level. (WebCore::WebGLTexture::getInternalFormat): (WebCore::WebGLTexture::getWidth): (WebCore::WebGLTexture::getHeight): (WebCore::WebGLTexture::mapTargetToIndex): (WebCore::WebGLTexture::getLevelInfo):
  • html/canvas/WebGLTexture.h: (WebCore::WebGLTexture::isTexture):
  • platform/graphics/GraphicsContext3D.h: Add getInternalFramebufferSize() function.
  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp: (WebCore::GraphicsContext3D::getInternalFramebufferSize):
  • platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3D::getInternalFramebufferSize):

2010-12-23 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Initialize to 0 for undefined values in CopyTexImage2D
https://bugs.webkit.org/show_bug.cgi?id=51421

  • fast/canvas/webgl/uninitialized-test-expected.txt: Add test cases for copyTexImage2D.
  • fast/canvas/webgl/uninitialized-test.html: Ditto.
13:26 Changeset [74719] by zmo@google.com
  • 7 edits in trunk

2010-12-23 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Map GLsizei to long instead of unsigned long in WebGLRenderingContext and GraphicsContext3D
https://bugs.webkit.org/show_bug.cgi?id=39855

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::copyTexImage2D): Map GLsizei to long. (WebCore::WebGLRenderingContext::copyTexSubImage2D): Ditto. (WebCore::WebGLRenderingContext::renderbufferStorage): Ditto. (WebCore::WebGLRenderingContext::scissor): Ditto. (WebCore::WebGLRenderingContext::texImage2DBase): Ditto. (WebCore::WebGLRenderingContext::texImage2D): Ditto. (WebCore::WebGLRenderingContext::texSubImage2DBase): Ditto. (WebCore::WebGLRenderingContext::texSubImage2DImpl): Ditto. (WebCore::WebGLRenderingContext::texSubImage2D): Ditto. (WebCore::WebGLRenderingContext::viewport): Ditto. (WebCore::WebGLRenderingContext::validateSize): Check the sizes are non-negative.
  • html/canvas/WebGLRenderingContext.h:
  • html/canvas/WebGLRenderingContext.idl:

2010-12-28 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Map GLsizei to long instead of unsigned long in WebGLRenderingContext and GraphicsContext3D
https://bugs.webkit.org/show_bug.cgi?id=39855

  • fast/canvas/webgl/invalid-passed-params-expected.txt: Add test cases for negative offset/width/height.
  • fast/canvas/webgl/invalid-passed-params.html: Ditto.
12:01 Changeset [74718] by kbr@google.com
  • 2 edits in trunk/LayoutTests

2010-12-28 Kenneth Russell <kbr@google.com>

Unreviewed, Chromium test expectations update. Mark
fast/forms/input-text-paste-maxlength.html as a flaky crash on
Linux Release as well as Debug.

  • platform/chromium/test_expectations.txt:
11:36 Changeset [74717] by kbr@google.com
  • 2 edits in trunk/LayoutTests

2010-12-28 Kenneth Russell <kbr@google.com>

Unreviewed, Chromium test expectations update.

Marked inspector/styles-source-lines.html as a flaky failure on
Win Debug and
http/tests/inspector/extensions-resources-redirect.html as a flaky
timeout on Win Release.

  • platform/chromium/test_expectations.txt:
11:18 Changeset [74716] by inferno@chromium.org
  • 5 edits
    2 adds in trunk

2010-12-28 Abhishek Arya <inferno@chromium.org>

Reviewed by Kenneth Russell.

Fix crash with invalid font in m_fontList by not drawing text when a custom font is in the
process of loading.
https://bugs.webkit.org/show_bug.cgi?id=51681

Test: canvas/philip/tests/2d.text-custom-font-load-crash.html

  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::drawTextInternal): bail out if a custom font is loading.
  • platform/graphics/Font.cpp: (WebCore::Font::operator==): Replace condition with new function loadingCustomFonts() (WebCore::Font::drawText): Replace condition with new function loadingCustomFonts() (WebCore::Font::drawEmphasisMarks): Replace condition with new function loadingCustomFonts()
  • platform/graphics/Font.h: (WebCore::Font::loadingCustomFonts): new function that returns if a custom font is loading.

2010-12-28 Abhishek Arya <inferno@chromium.org>

Reviewed by Kenneth Russell.

Tests that we do not crash when drawing text during custom font load.
https://bugs.webkit.org/show_bug.cgi?id=51681

  • canvas/philip/tests/2d.text-custom-font-load-crash-expected.txt: Added.
  • canvas/philip/tests/2d.text-custom-font-load-crash.html: Added.
10:55 Changeset [74715] by dglazkov@chromium.org
  • 4 edits in trunk/WebCore

2010-12-28 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Eric Seidel.

Combine setShadowRoot and clearShadowRoot into a simpler API
https://bugs.webkit.org/show_bug.cgi?id=50971

No change in behavior, and API is not used yet.

  • dom/Element.cpp: (WebCore::Element::setShadowRoot): Combined clearing and setting of

the shadowRoot, also hooked up with setting and clearing of the
corresponding shadowHost values.

  • dom/Element.h: renamed clearShadowRoot to removeShadowRoot and made it

private.

  • dom/Node.h: Made shadow host-related functions public so that

Element::setShadowRoot can access setShadowHost. It seems logical
to make shadowHost public as well to keep the defs together.

10:11 Changeset [74714] by caseq@chromium.org
  • 6 edits
    3 adds in trunk

2010-12-28 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Chromium] Expose extension API to select a node in WebInspector
Do not request content for resources with non-numeric identifiers.
https://bugs.webkit.org/show_bug.cgi?id=49727

Test: http/tests/inspector/extensions-resources-redirect.html

  • inspector/front-end/NetworkManager.js: (WebInspector.NetworkManager.prototype._appendRedirect):

2010-12-28 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Chromium] Expose extension API to select a node in WebInspector
Do not request content for resources with non-numeric identifiers.
https://bugs.webkit.org/show_bug.cgi?id=49727

  • http/tests/inspector/extensions-resources-redirect-expected.txt: Added.
  • http/tests/inspector/extensions-resources-redirect.html: Added.
  • http/tests/inspector/extensions-resources-test.js: Added. (extension_getResourceByUrl.onHAR): (extension_getResourceByUrl):
  • inspector/extensions-resources-expected.txt:
  • inspector/extensions-resources.html:
  • platform/mac-leopard/inspector/extensions-resources-expected.txt:
09:58 Changeset [74713] by loislo@chromium.org
  • 2 edits in trunk/WebCore

2010-12-28 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed build fix for Qt.

ResourceTreeModel.js was added.

  • inspector/front-end/WebKit.qrc:
09:24 Changeset [74712] by mnaganov@chromium.org
  • 2 edits in trunk/WebCore

2010-12-28 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Pavel Feldman.

[Chromium] Fix memory leak in Profiles tab concerned with heap profiles views.

https://bugs.webkit.org/show_bug.cgi?id=51680

  • inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype._reset):
07:55 Changeset [74711] by kbr@google.com
  • 2 edits in trunk/LayoutTests

2010-12-28 Kenneth Russell <kbr@google.com>

Unreviewed, Chromium test expectations update. Coalesce WebGL
expectations for chromium-gpu platform and fix duplicate
expectation for gl-object-get-calls.html accidentally introduced
on Windows Debug.

  • platform/chromium-gpu/test_expectations.txt:
07:32 Changeset [74710] by apavlov@chromium.org
  • 4 edits
    4 adds in trunk

2010-12-28 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: REGRESSION: Clicking image resource in style sidebar doesn't actually go to resource anymore
https://bugs.webkit.org/show_bug.cgi?id=51663

  • inspector/elements-tests2.js: (initialize_ElementTest.InspectorTest.dumpSelectedElementStyles): Drive-by: remove bad test exit code.
  • inspector/resources/styles-url-linkify-iframe.html: Added.
  • inspector/resources/styles-url-linkify.css: Added. (#local):
  • inspector/styles-url-linkify-expected.txt: Added.
  • inspector/styles-url-linkify.html: Added.

2010-12-28 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: REGRESSION: Clicking image resource in style sidebar doesn't actually go to resource anymore
https://bugs.webkit.org/show_bug.cgi?id=51663

The base URI is now computed correctly for links from CSS property uri(...) values. Additionally,
optional quotes/apostrophes and spaces are now allowed inside uri(...).

Test: inspector/styles-url-linkify.html

  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertyTreeElement.prototype.updateTitle.linkifyURL): (WebInspector.StylePropertyTreeElement.prototype.updateTitle):
07:11 Changeset [74709] by loislo@chromium.org
  • 21 edits
    2 adds
    1 delete in trunk/WebCore

2010-12-21 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Protocol cleanup task. Introduce Network, DOMStorage and Database domains.

Domain was changed for Resources, FileSystem etc. related methods.
ResourcesManager was renamed to NetworkManager.
ResourceTreeModel was extracted as separate file.
FileSystem, Database, DOMStorage and ApplicationCache methods were
removed from NetworkManager and added to corresponding classes.

https://bugs.webkit.org/show_bug.cgi?id=51334

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/CodeGeneratorInspector.pm:
  • inspector/Inspector.idl:
  • inspector/front-end/AuditRules.js: (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback.selectorsCallback):
  • inspector/front-end/CSSStyleModel.js: (WebInspector.CSSStyleModel.prototype._styleSheetChanged.callback): (WebInspector.CSSStyleModel.prototype._styleSheetChanged):
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.addMessage): (WebInspector.ConsoleView.prototype.clearMessages):
  • inspector/front-end/DOMAgent.js: (WebInspector.ApplicationCache.updateApplicationCacheStatus): (WebInspector.ApplicationCache.updateNetworkState):
  • inspector/front-end/DOMStorage.js: (WebInspector.DOMStorage.addDOMStorage): (WebInspector.DOMStorage.selectDOMStorage): (WebInspector.DOMStorage.updateDOMStorage):
  • inspector/front-end/Database.js: (WebInspector.Database.prototype.executeSql): (WebInspector.Database.addDatabase): (WebInspector.Database.selectDatabase): (WebInspector.Database.sqlTransactionSucceeded): (WebInspector.Database.sqlTransactionFailed):
  • inspector/front-end/FileSystemView.js: (WebInspector.FileSystem.didGetFileSystemPath): (WebInspector.FileSystem.didGetFileSystemError): (WebInspector.FileSystem.didGetFileSystemDisabled):
  • inspector/front-end/NetworkItemView.js: (WebInspector.NetworkItemView):
  • inspector/front-end/NetworkManager.js: Added. (WebInspector.NetworkManager): (WebInspector.NetworkManager.prototype._createResource): (WebInspector.NetworkManager.prototype.identifierForInitialRequest): (WebInspector.NetworkManager.prototype.willSendRequest): (WebInspector.NetworkManager.prototype._updateResourceWithRequest): (WebInspector.NetworkManager.prototype._appendRedirect): (WebInspector.NetworkManager.prototype.markResourceAsCached): (WebInspector.NetworkManager.prototype.didReceiveResponse): (WebInspector.NetworkManager.prototype._updateResourceWithResponse): (WebInspector.NetworkManager.prototype.didReceiveContentLength): (WebInspector.NetworkManager.prototype.didFinishLoading): (WebInspector.NetworkManager.prototype.didFailLoading): (WebInspector.NetworkManager.prototype.didLoadResourceFromMemoryCache): (WebInspector.NetworkManager.prototype._updateResourceWithCachedResource): (WebInspector.NetworkManager.prototype.setInitialContent): (WebInspector.NetworkManager.prototype.didCommitLoadForFrame): (WebInspector.NetworkManager.prototype.frameDetachedFromParent): (WebInspector.NetworkManager.prototype.didCreateWebSocket): (WebInspector.NetworkManager.prototype.willSendWebSocketHandshakeRequest): (WebInspector.NetworkManager.prototype.didReceiveWebSocketHandshakeResponse): (WebInspector.NetworkManager.prototype.didCloseWebSocket): (WebInspector.NetworkManager.prototype._processCachedResources): (WebInspector.NetworkManager.prototype._addFramesRecursively): (WebInspector.NetworkManager.requestContent):
  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype.refreshResource):
  • inspector/front-end/Resource.js: (WebInspector.Resource.prototype._innerRequestContent):
  • inspector/front-end/ResourceManager.js: Removed.
  • inspector/front-end/ResourceTreeModel.js: Added. (WebInspector.ResourceTreeModel): (WebInspector.ResourceTreeModel.prototype.addOrUpdateFrame): (WebInspector.ResourceTreeModel.prototype.didCommitLoadForFrame): (WebInspector.ResourceTreeModel.prototype.frameDetachedFromParent): (WebInspector.ResourceTreeModel.prototype._clearChildFramesAndResources): (WebInspector.ResourceTreeModel.prototype.addResourceToFrame): (WebInspector.ResourceTreeModel.prototype._clearResources): (WebInspector.ResourceTreeModel.prototype.forAllResources): (WebInspector.ResourceTreeModel.prototype.addConsoleMessage): (WebInspector.ResourceTreeModel.prototype.clearConsoleMessages): (WebInspector.ResourceTreeModel.prototype._callForFrameResources): (WebInspector.ResourceTreeModel.prototype.resourceForURL): (WebInspector.ResourceTreeModel.prototype.bindResourceURL): (WebInspector.ResourceTreeModel.prototype._unbindResourceURL): (WebInspector.ResourceTreeModel.createResource):
  • inspector/front-end/ResourceView.js: (WebInspector.ResourceView.createResourceView): (WebInspector.ResourceView.resourceViewTypeMatchesResource): (WebInspector.ResourceView.resourceViewForResource): (WebInspector.ResourceView.recreateResourceView): (WebInspector.ResourceView.existingResourceViewForResource):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.canShowSourceLine): (WebInspector.ResourcesPanel.prototype.showSourceLine): (WebInspector.ResourcesPanel.prototype.showResource): (WebInspector.ResourcesPanel.prototype.get searchableViews.callback): (WebInspector.ResourcesPanel.prototype.get searchableViews): (WebInspector.FrameResourceTreeElement.prototype._errorsWarningsUpdated): (WebInspector.FrameResourceTreeElement.prototype._contentChanged):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._addScript): (WebInspector.ScriptsPanel.prototype.reset): (WebInspector.ScriptsPanel.prototype._sourceFrameForResource): (WebInspector.ScriptsPanel.prototype._showScriptOrResource):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js: (WebInspector.forAllResources): (WebInspector.resourceForURL):

12/27/10:

21:33 Changeset [74708] by commit-queue@webkit.org
  • 5 edits in trunk/WebCore

2010-12-27 Helder Correia <helder@sencha.com>

Reviewed by Ariya Hidayat.

ContextShadow should use AffineTransform instead of TransformationMatrix
https://bugs.webkit.org/show_bug.cgi?id=51661

ContextShadow needs the CTM to make sure shadows are not affected by
transformations when drawing on a canvas. AffineTransform is sufficient
in this case.

Existing tests: fast/canvas/canvas*shadow*html

  • platform/graphics/ContextShadow.cpp: (WebCore::ContextShadow::mustUseContextShadow): (WebCore::ContextShadow::adjustBlurDistance): (WebCore::ContextShadow::calculateLayerBoundingRect):
  • platform/graphics/ContextShadow.h:
  • platform/graphics/cairo/ContextShadowCairo.cpp: (WebCore::ContextShadow::getTransformationMatrixFromContext):
  • platform/graphics/qt/ContextShadowQt.cpp: (WebCore::ContextShadow::getTransformationMatrixFromContext):
21:15 Changeset [74707] by commit-queue@webkit.org
  • 2 edits in trunk

2010-12-27 Ryuan Choi <ryuan.choi@samsung.com>

Reviewed by David Levin.

[EFL] Change path of eflsymbols.filter
https://bugs.webkit.org/show_bug.cgi?id=51659

  • Sources/cmake/OptionsEfl.cmake:
18:05 Changeset [74706] by dbates@webkit.org
  • 2 edits in trunk/Tools

2010-12-27 Daniel Bates <dbates@rim.com>

Rubber-stamped by Martin Robinson.

Append the directory Tools/DumpRenderTree to the list of directories that
do-webcore-rename should search so that it can rename DRT files and
source code.

  • Scripts/do-webcore-rename:
17:40 Changeset [74705] by mrobinson@webkit.org
  • 2 edits in trunk/LayoutTests

2010-12-27 Martin Robinson <mrobinson@igalia.com>

Reviewed by Daniel Bates.

Try to fix my previous commit for Mac by stepping up the precision of pi even more
using Math.PI.

  • fast/canvas/canvas-save-restore-with-path.js: Use Math.PI instead of a hard-coded estimation.
17:39 Changeset [74704] by weinig@apple.com
  • 2 edits in trunk/WebKit2

WebKit2 snapshots should contain accelerated content
<rdar://problem/8807393>
https://bugs.webkit.org/show_bug.cgi?id=51660

Reviewed by Anders Carlsson.

When creating a snapshot, flatten the layer tree for painting so that
accelerated content is included in the snapshot.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::snapshotInViewCoordinates):
(WebKit::WebPage::snapshotInDocumentCoordinates):

17:03 Changeset [74703] by dbates@webkit.org
  • 2 edits in trunk/WebKit2

2010-12-27 Daniel Bates <dbates@rim.com>

Attempt to fix the WebKit2 Windows build after changeset 74698
<http://trac.webkit.org/changeset/74698> (bug #51656).

Add "..\Shared\API\c\WKImage.h" to WebKit2Generated.make.

  • win/WebKit2Generated.make:
16:50 Changeset [74702] by kbr@google.com
  • 2 edits in trunk/LayoutTests

2010-12-27 Kenneth Russell <kbr@google.com>

Unreviewed, Chromium test expectations update. Generalize
suppressions for Chromium bugs 67732 and 67139 to cover Linux
Debug.

  • platform/chromium/test_expectations.txt:
16:44 Changeset [74701] by dbates@webkit.org
  • 1 edit in trunk/WebCore/ChangeLog

2010-12-27 Daniel Bates <dbates@rim.com>

Fix the first sentence of the change log message for changeset 74700
<http://trac.webkit.org/changeset/74700> (bug #51634).

As pointed out by Dan Bernstein, it should read: "Rename HTMLFrameElementBase::getMarginWidth()
and HTMLFrameElementBase::getMarginHeight() to HTMLFrameElementBase::marginWidth() and
HTMLFrameElementBase::marginHeight(), respectively."

16:21 Changeset [74700] by dbates@webkit.org
  • 7 edits in trunk/WebCore

2010-12-27 Daniel Bates <dbates@rim.com>

Reviewed by Antonio Gomes.

Clean up: Rename HTMLFrameElementBase::getMarginWidth() and HTMLFrameElementBase::getMarginHeight()
https://bugs.webkit.org/show_bug.cgi?id=51634

Rename HTMLFrameElementBase::getMarginWidth() and HTMLFrameElementBase::getMarginHeight()
to HTMLFrameElementBase::marginHeight() and HTMLFrameElementBase::marginHeight(), respectively.
This will make the names of these getters consistent with the naming convention we use for
getters.

  • html/HTMLBodyElement.cpp: (WebCore::HTMLBodyElement::insertedIntoDocument):
  • html/HTMLFrameElementBase.h: (WebCore::HTMLFrameElementBase::marginWidth): Renamed; Formerly getMarginWidth(). (WebCore::HTMLFrameElementBase::marginHeight): Renamed; Formerly getMarginHeight().
  • loader/SubframeLoader.cpp: (WebCore::SubframeLoader::loadSubframe):
  • page/FrameView.cpp: (WebCore::FrameView::init):
  • rendering/RenderEmbeddedObject.cpp: (WebCore::RenderEmbeddedObject::viewCleared): Also renamed variables marginw and marginh to marginWidth and marginHeight, respectively. This makes the names of these variables consistent with the names of similar variables in SubframeLoader::loadSubframe() and FrameView::init().
  • rendering/RenderFrame.cpp: (WebCore::RenderFrame::viewCleared): Ditto.
16:17 Changeset [74699] by mrobinson@webkit.org
  • 2 edits in trunk/LayoutTests

2010-12-27 Martin Robinson <mrobinson@igalia.com>

Reviewed by Daniel Bates.

[Cairo] fast/canvas/canvas-save-restore-with-path.html fails with some versions of Cairo
https://bugs.webkit.org/show_bug.cgi?id=51655

Increase the precision of pi used in this test case. It appears that
some Cairo versions or processors are sensitive to rounding errors here.

  • fast/canvas/canvas-save-restore-with-path.js: Increase pi precision.
16:01 Changeset [74698] by weinig@apple.com
  • 16 edits
    8 adds in trunk/WebKit2

WebKit2: Add API for getting snapshots
https://bugs.webkit.org/show_bug.cgi?id=51656

Reviewed by Anders Carlsson.

  • Shared/API/c/WKBase.h:
  • Shared/API/c/WKImage.cpp: Added.

(WKImageGetTypeID):
(WKImageCreate):
(WKImageGetSize):

  • Shared/API/c/WKImage.h: Added.
  • Shared/WebImage.cpp: Added.

(WebKit::WebImage::create):
(WebKit::WebImage::size):

  • Shared/WebImage.h: Added.

(WebKit::WebImage::backingStore):
(WebKit::WebImage::WebImage):
(WebKit::WebImage::type):
Add a general purpose API image class.

  • Shared/API/c/cg: Added.
  • Shared/API/c/cg/WKImageCG.cpp: Added.

(WKImageCreateCGImage):

  • Shared/API/c/cg/WKImageCG.h: Added.

Add function to convert a WKImageRef to a CGImageRef for platforms that use CG.

  • Shared/API/c/WKSharedAPICast.h:

(WebKit::toFloatRect):
(WebKit::toIntSize):
(WebKit::toIntPoint):
(WebKit::toIntRect):
(WebKit::toImageOptions):
Make conversion functions that are ambiguous more explicit.

  • Shared/APIObject.h:
  • Shared/BackingStore.h:

(WebKit::BackingStore::isBackedBySharedMemory):

  • Shared/ImageOptions.h: Added.
  • Shared/UserMessageCoders.h:

(WebKit::UserMessageEncoder::baseEncode):
(WebKit::UserMessageDecoder::baseDecode):
Allow a WKImageRef to be passed in user messages. Right now, it only
works if the image is sharable.

  • UIProcess/API/C/WKPage.cpp:

(WKPageScaleWebView):

  • UIProcess/WebUIClient.cpp:

(WebKit::WebUIClient::windowFrame):
Use the more explicit conversion function name.

  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageCreateSnapshotInViewCoordinates):
(WKBundlePageCreateSnapshotInDocumentCoordinates):

  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/InjectedBundle/API/c/WKBundlePageOverlay.cpp:

(WKBundlePageOverlaySetNeedsDisplay):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::snapshotInViewCoordinates):
(WebKit::WebPage::snapshotInDocumentCoordinates):
Add function to take the snapshot.

  • WebProcess/WebPage/WebPage.h:
  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:

Add new files.

14:48 Changeset [74697] by mrobinson@webkit.org
  • 2 edits in trunk/WebKit/gtk

2010-12-27 Martin Robinson <mrobinson@igalia.com>

Reviewed by Ryosuke Niwa.

[GTK] EditorClient::generateEditorCommands queues up "null string" commands
https://bugs.webkit.org/show_bug.cgi?id=51569

Prevent adding "null string" editor commands by first checking whether or not
the command string is null in generateEditorCommands before appending it to the
list of pending editor command strings.

  • WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::generateEditorCommands): Check for the null string (no command for this key combination) before appending a command string to the list of pending editor commands. (WebKit::EditorClient::executePendingEditorCommands): Add an ASSERT which detects null command strings.
14:37 Changeset [74696] by mrobinson@webkit.org
  • 2 edits in trunk/WebCore

2010-12-27 Martin Robinson <mrobinson@igalia.com>

Reviewed by Daniel Bates.

[GTK] RenderThemeGtk::m_HScale and RenderThemeGtk::m_VScale are not initialized
https://bugs.webkit.org/show_bug.cgi?id=51654

Properly initialize slider members of RenderThemeGtk. This can lead to test crashes
on some debug configurations.

No new tests. This is already covered by current slider tests. It isn't crashing on
the bots, but it does crash locally.

  • platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::RenderThemeGtk): Properly initialize members.
13:41 Changeset [74695] by darin@apple.com
  • 9 edits in trunk/JavaScriptCore

2010-12-27 Jake Helfert <jake@jakeonthenet.com>

Reviewed and reworked by Darin Adler.

Building WebKit with Visual Studio 2010 fails due
to ambiguous assignment operator errors.
https://bugs.webkit.org/show_bug.cgi?id=51116

  • wtf/NullPtr.h: Added a HAVE(NULLPTR) definition for use with Platform.h HAVE macro, and included the Visual Studio 2010 compiler as one of the ones that has nullptr.
  • wtf/NullPtr.cpp: Updated condition to match.


  • wtf/PassOwnArrayPtr.h: Don't include the operator=(nullptr_t) overload if we are compiling in loose mode and the compiler has nullptr, because assignment of 0 will otherwise encounter ambiguitity with this overload and the overload for loose mode that takes a raw pointer. The conditional can be removed when we get rid of loose mode.
  • wtf/PassOwnPtr.h: Ditto.
  • wtf/PassRefPtr.h: Don't include the operator=(nullptr_t) overload if the compiler has nullptr, because assignment of 0 would be ambiguous with the overload that takes a raw pointer. The conditional can be removed if we ever decide we no longer need to support assigning 0, but might need a way to catch that usage on older compilers.
  • wtf/RefPtr.h: Ditto.
  • wtf/RetainPtr.h: Ditto
  • JavaScriptCore.xcodeproj/project.pbxproj: Added NullPtr.cpp, accidentally omitted when the file was first added.
13:13 Changeset [74694] by eric@webkit.org
  • 2 edits in trunk/Tools

2010-12-27 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

build-webkit should detect missing Java SDK and explain how to install it
https://bugs.webkit.org/show_bug.cgi?id=51651

  • Scripts/build-webkit:
13:04 Changeset [74693] by weinig@apple.com
  • 11 edits
    2 adds in trunk/WebKit2

WebKit2: Add additional API for managing databases
https://bugs.webkit.org/show_bug.cgi?id=51629

Reviewed by Anders Carlsson.

  • Adds client for the database manager to get notifications of changes to databases.
  • UIProcess/API/C/WKDatabaseManager.cpp:

(WKDatabaseManagerSetClient):

  • UIProcess/API/C/WKDatabaseManager.h:
  • UIProcess/WebDatabaseManagerProxy.cpp:

(WebKit::WebDatabaseManagerProxy::initializeClient):
(WebKit::WebDatabaseManagerProxy::didModifyOrigin):
(WebKit::WebDatabaseManagerProxy::didModifyDatabase):

  • UIProcess/WebDatabaseManagerProxy.h:
  • UIProcess/WebDatabaseManagerProxy.messages.in:
  • UIProcess/WebDatabaseManagerProxyClient.cpp: Added.

(WebKit::WebDatabaseManagerProxyClient::didModifyOrigin):
(WebKit::WebDatabaseManagerProxyClient::didModifyDatabase):

  • UIProcess/WebDatabaseManagerProxyClient.h: Added.
  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebCoreSupport/WebDatabaseManager.cpp:

(WebKit::WebDatabaseManager::WebDatabaseManager):
(WebKit::WebDatabaseManager::~WebDatabaseManager):
(WebKit::WebDatabaseManager::dispatchDidModifyOrigin):
(WebKit::WebDatabaseManager::dispatchDidModifyDatabase):

  • WebProcess/WebCoreSupport/WebDatabaseManager.h:
  • win/WebKit2.vcproj:
11:41 Changeset [74692] by weinig@apple.com
  • 1 edit
    2 adds in trunk/Sources

Fix Makefile based build.

11:21 Changeset [74691] by xan@webkit.org
  • 4 edits in trunk/WebKit/gtk

2010-12-27 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

Remove unneeded includes from our headers.

  • WebCoreSupport/PasteboardHelperGtk.h: ditto.
  • webkit/webkitprivate.h: ditto.
  • webkit/webkitsoupauthdialog.h: ditto.
11:17 Changeset [74690] by weinig@apple.com
  • 13 edits
    2 adds in trunk/WebKit2

WebKit2: Add additional API for managing databases
https://bugs.webkit.org/show_bug.cgi?id=51629

Reviewed by Anders Carlsson.

  • Adds WKDatabaseManagerGetDatabasesByOrigin, which asynchronously returns an array of dictionaries containing details about each origin using databases and details about each database. Keys were added for accessing the data in the dictionaries.
  • Adds WKDatabaseManagerDeleteDatabasesWithNameForOrigin to delete a database with a specific identifier.
  • Adds WKDatabaseManagerSetQuotaForOrigin to set the quota for an origin.
  • Shared/OriginAndDatabases.cpp: Added.

(WebKit::OriginAndDatabases::encode):
(WebKit::OriginAndDatabases::decode):

  • Shared/OriginAndDatabases.h: Added.
  • Shared/WebCoreArgumentCoders.h:
  • UIProcess/API/C/WKDatabaseManager.cpp:

(WKDatabaseManagerGetOriginKey):
(WKDatabaseManagerGetOriginQuotaKey):
(WKDatabaseManagerGetOriginUsageKey):
(WKDatabaseManagerGetDatabaseDetailsKey):
(WKDatabaseManagerGetDatabaseDetailsNameKey):
(WKDatabaseManagerGetDatabaseDetailsDisplayNameKey):
(WKDatabaseManagerGetDatabaseDetailsExpectedUsageKey):
(WKDatabaseManagerGetDatabaseDetailsCurrentUsageKey):
(WKDatabaseManagerGetDatabasesByOrigin):
(callGetDatabasesByOriginBlockAndDispose):
(WKDatabaseManagerGetDatabasesByOrigin_b):
(WKDatabaseManagerGetDatabaseOrigins):
(callGetDatabaseOriginsBlockBlockAndDispose):
(WKDatabaseManagerGetDatabaseOrigins_b):
(WKDatabaseManagerDeleteDatabasesWithNameForOrigin):
(WKDatabaseManagerDeleteDatabasesForOrigin):
(WKDatabaseManagerDeleteAllDatabases):
(WKDatabaseManagerSetQuotaForOrigin):

  • UIProcess/API/C/WKDatabaseManager.h:
  • UIProcess/WebDatabaseManagerProxy.cpp:

(WebKit::WebDatabaseManagerProxy::originKey):
(WebKit::WebDatabaseManagerProxy::originQuotaKey):
(WebKit::WebDatabaseManagerProxy::originUsageKey):
(WebKit::WebDatabaseManagerProxy::databaseDetailsKey):
(WebKit::WebDatabaseManagerProxy::databaseDetailsNameKey):
(WebKit::WebDatabaseManagerProxy::databaseDetailsDisplayNameKey):
(WebKit::WebDatabaseManagerProxy::databaseDetailsExpectedUsageKey):
(WebKit::WebDatabaseManagerProxy::databaseDetailsCurrentUsageKey):
(WebKit::WebDatabaseManagerProxy::invalidate):
(WebKit::WebDatabaseManagerProxy::getDatabasesByOrigin):
(WebKit::WebDatabaseManagerProxy::didGetDatabasesByOrigin):
(WebKit::WebDatabaseManagerProxy::getDatabaseOrigins):
(WebKit::WebDatabaseManagerProxy::didGetDatabaseOrigins):
(WebKit::WebDatabaseManagerProxy::deleteDatabaseWithNameForOrigin):
(WebKit::WebDatabaseManagerProxy::deleteDatabasesForOrigin):
(WebKit::WebDatabaseManagerProxy::setQuotaForOrigin):

  • UIProcess/WebDatabaseManagerProxy.h:
  • UIProcess/WebDatabaseManagerProxy.messages.in:
  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebCoreSupport/WebDatabaseManager.cpp:

(WebKit::WebDatabaseManager::getDatabasesByOrigin):
(WebKit::WebDatabaseManager::deleteDatabaseWithNameForOrigin):
(WebKit::WebDatabaseManager::setQuotaForOrigin):

  • WebProcess/WebCoreSupport/WebDatabaseManager.h:
  • WebProcess/WebCoreSupport/WebDatabaseManager.messages.in:
  • win/WebKit2.vcproj:
11:07 Changeset [74689] by mrobinson@webkit.org
  • 4 edits in trunk/Tools

2010-12-26 Martin Robinson <mrobinson@igalia.com>

Reviewed by Daniel Bates.

[GTK] Add support for build-jsc
https://bugs.webkit.org/show_bug.cgi?id=51625

Add GTK+ support to build-jsc now that building the jsc executable as
a standalone target is easy.

  • Scripts/build-jsc: Call buildGtkProject for the GTK+ case now.
  • Scripts/build-webkit: Pass in the proper target name to buildGtkProject.
  • Scripts/webkitdirs.pm: Actually process the project parameter in buildGtkProject and pass it along to buildAutotoolsProject.
10:50 Changeset [74688] by levin@chromium.org
  • 4 edits in trunk/Tools

check-webkit-style check for meaningless variable names in function declarations.
https://bugs.webkit.org/show_bug.cgi?id=51523

Reviewed by Eric Seidel.

  • Scripts/webkitpy/style/checker.py: Exempted JavaScriptCore/jit/JITStubs.cpp

from the new check and whitespace/parens because the syntax is unusual and
produced a fair number of positives for these checks.

  • Scripts/webkitpy/style/checkers/cpp.py:

(_convert_to_lower_with_underscores): Used as a canonical form for type names
and parameter names when determining if the parameter name is useless.
(_create_acronym): Used to check for redundant variable names in cases like "ExceptionCode ec"
(Parameter.lower_with_underscores_name): Gives back the parameter name in a lower_with_underscore
format.
(_check_parameter_name_against_text): Checks to see if the parameter name is in the
text or an acronym of it.
(check_function_definition): Checks function definitions for meaningless variable names.
(process_line): Added call to check_function_definition.

  • Scripts/webkitpy/style/checkers/cpp_unittest.py:

(CppFunctionsTest.test_convert_to_lower_with_underscores): Test for _convert_to_lower_with_underscores.
(CppFunctionsTest.test_create_acronym): Test for _create_acronym.
(CppFunctionsTest.test_check_parameter_against_text): Test for _check_parameter_against_text.
(CppStyleTestBase.perform_single_line_lint): Removed the parameter name check
because when only checking a snippet, there are a lot of bogus functions.
(CppStyleTestBase.perform_multi_line_lint): Ditto and removed a bogus filter
that I put there previously and just noticed.
(WebKitStyleTest.test_parameter_names): Tests for the functionality -- both
check_function_definition and process_line.

10:46 Changeset [74687] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

2010-12-27 Kenji Imasaki <imasaki@chromium.org>

Reviewed by David Levin.

remove entries for media related non-flaky tests.
https://bugs.webkit.org/show_bug.cgi?id=51225

  • platform/chromium/test_expectations.txt:
09:41 Changeset [74686] by antonm@chromium.org
  • 5 edits in trunk/WebCore

2010-12-27 Anton Muhin <antonm@chromium.org>

Reviewed by David Levin.

[v8] Remove unused methods to protect/unprotect wrappers during garbage collection
https://bugs.webkit.org/show_bug.cgi?id=51648

  • bindings/v8/ScriptController.cpp:
  • bindings/v8/ScriptController.h:
  • bindings/v8/V8GCController.cpp: (WebCore::V8GCController::gcEpilogue):
  • bindings/v8/V8GCController.h:
09:37 Changeset [74685] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

2010-12-27 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Disable flash plugin in GtkLauncher when using gtk3
https://bugs.webkit.org/show_bug.cgi?id=51591

Flash plugin uses gtk2 that is incompatible with gtk3 making
webkit crash when it's built with gtk3.

  • GtkLauncher/main.c: (main):
09:10 Changeset [74684] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit/efl

2010-12-27 Rafael Antognolli <antognolli@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Set the frame smart object base clipper to non-static.
https://bugs.webkit.org/show_bug.cgi?id=51552

The base clipper of the clipped smart object, which is the parent
class of the ewk_frame class is a static clipper. It's normally only
used for showing/hiding the object, but in the case of the ewk_frame,
it needs to clip the object to its dimension, in order to clip
scrollbars of inner frames.

Setting it to non-static makes the clipper to be automatically moved
by the parent class, thus staying on the correct position when the
frame is moved.

This change needed to be done after the adoption of the static clipper
on the clipped smart base class.

  • ewk/ewk_frame.cpp: (_ewk_frame_smart_add):
06:51 Changeset [74683] by yurys@chromium.org
  • 2 edits in trunk/WebCore

2010-12-27 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Removed trailing spaces from a localized
string to make it the same as the one used in the code.

  • English.lproj/localizedStrings.js:
06:36 Changeset [74682] by philn@webkit.org
  • 2 edits in trunk/LayoutTests

2010-12-27 Philippe Normand <pnormand@igalia.com>

Unreviewed, skip another GTK media test reporting wrong duration,
see bug 51602.

  • platform/gtk/Skipped:
06:10 Changeset [74681] by yael.aharon@nokia.com
  • 6 edits in trunk

2010-12-27 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Eric Seidel.

Browser is failing 16 baseline test from Selector API Test Suite
https://bugs.webkit.org/show_bug.cgi?id=42968

Update the expected result for the test.

  • fast/dom/SelectorAPI/resig-SelectorsAPI-test-expected.txt:

2010-12-27 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Eric Seidel.

Browser is failing 16 baseline test from Selector API Test Suite
https://bugs.webkit.org/show_bug.cgi?id=42968

Throw an exception if there is no argument to querySelector or
querySelectorAll. This replaces the current behavior of passing the string
"undefined" as the argument.

No new tests, just updating the existing results for
fast/dom/SelectorAPI/resig-SelectorAPI-test.xhtml.

  • dom/Document.idl:
  • dom/DocumentFragment.idl:
  • dom/Element.idl:
03:32 Changeset [74680] by hamaji@chromium.org
  • 2 edits in trunk/LayoutTests

2010-12-27 Shinichiro Hamaji <shinichiro.hamaji@gmail.com>

Chromium expectation update.

Suppress fast/canvas/webgl/tex-image-with-format-and-type on linux debug

  • platform/chromium/test_expectations.txt:
00:06 Changeset [74679] by morrita@google.com
  • 1 edit
    4 adds in trunk/LayoutTests

2010-12-27 MORITA Hajime <morrita@google.com>

Unreviewed expectation updates.

  • platform/chromium-linux/fast/box-shadow/spread-multiple-normal-expected.checksum: Added.
  • platform/chromium-linux/fast/box-shadow/spread-multiple-normal-expected.png: Added.
  • platform/chromium-win/fast/box-shadow/spread-multiple-normal-expected.checksum: Added.
  • platform/chromium-win/fast/box-shadow/spread-multiple-normal-expected.png: Added.
Note: See TracTimeline for information about the timeline view.