Timeline


and

01/03/11:

22:47 Changeset [74958] by tkent@chromium.org

2011-01-03 Kent Tamura <tkent@chromium.org>

Unreviewed, test expectation update

Add expectations of r74954 tests for Chromium.

  • platform/chromium-linux/fast/css-generated-content/table-before-after-child-add-expected.checksum: Added.
  • platform/chromium-linux/fast/css-generated-content/table-before-after-child-add-expected.png: Added.
  • platform/chromium-linux/fast/css-generated-content/table-cell-before-after-child-add-expected.checksum: Added.
  • platform/chromium-linux/fast/css-generated-content/table-cell-before-after-child-add-expected.png: Added.
  • platform/chromium-linux/fast/css-generated-content/table-row-before-after-child-add-expected.checksum: Added.
  • platform/chromium-linux/fast/css-generated-content/table-row-before-after-child-add-expected.png: Added.
  • platform/chromium-linux/fast/css-generated-content/table-table-before-after-child-add-expected.checksum: Added.
  • platform/chromium-linux/fast/css-generated-content/table-table-before-after-child-add-expected.png: Added.
  • platform/chromium-mac/fast/css-generated-content/table-before-after-child-add-expected.checksum: Added.
  • platform/chromium-mac/fast/css-generated-content/table-before-after-child-add-expected.png: Added.
  • platform/chromium-mac/fast/css-generated-content/table-cell-before-after-child-add-expected.checksum: Added.
  • platform/chromium-mac/fast/css-generated-content/table-cell-before-after-child-add-expected.png: Added.
  • platform/chromium-mac/fast/css-generated-content/table-row-before-after-child-add-expected.checksum: Added.
  • platform/chromium-mac/fast/css-generated-content/table-row-before-after-child-add-expected.png: Added.
  • platform/chromium-mac/fast/css-generated-content/table-table-before-after-child-add-expected.checksum: Added.
  • platform/chromium-mac/fast/css-generated-content/table-table-before-after-child-add-expected.png: Added.
  • platform/chromium-win/fast/css-generated-content/table-before-after-child-add-expected.checksum: Added.
  • platform/chromium-win/fast/css-generated-content/table-before-after-child-add-expected.png: Added.
  • platform/chromium-win/fast/css-generated-content/table-before-after-child-add-expected.txt: Added.
  • platform/chromium-win/fast/css-generated-content/table-cell-before-after-child-add-expected.checksum: Added.
  • platform/chromium-win/fast/css-generated-content/table-cell-before-after-child-add-expected.png: Added.
  • platform/chromium-win/fast/css-generated-content/table-cell-before-after-child-add-expected.txt: Added.
  • platform/chromium-win/fast/css-generated-content/table-row-before-after-child-add-expected.checksum: Added.
  • platform/chromium-win/fast/css-generated-content/table-row-before-after-child-add-expected.png: Added.
  • platform/chromium-win/fast/css-generated-content/table-row-before-after-child-add-expected.txt: Added.
  • platform/chromium-win/fast/css-generated-content/table-table-before-after-child-add-expected.checksum: Added.
  • platform/chromium-win/fast/css-generated-content/table-table-before-after-child-add-expected.png: Added.
  • platform/chromium-win/fast/css-generated-content/table-table-before-after-child-add-expected.txt: Added.
22:20 Changeset [74957] by ddkilzer@apple.com

WebCore: HTML5 Conformance Test failure: approved/xhtml5/object_border_pixel.xhtml
https://bugs.webkit.org/show_bug.cgi?id=48596

Patch by Julie-Jeongeun-Kim <Jeongeun.Kim@obigo.com> on 2011-01-03
Reviewed by Darin Adler.

border attribute was not parsed in HTMLObjectElement.
I added code for it as HTMLImageElement handled.

new test:fast/html/object-border.html

  • html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::parseMappedAttribute):

LayoutTests: HTML5 Conformance Test failure: approved/xhtml5/object_border_pixel.xhtml
https://bugs.webkit.org/show_bug.cgi?id=48596

Patch by Julie-Jeongeun-Kim <Jeongeun.Kim@obigo.com> on 2011-01-03
Reviewed by Darin Adler.

  • fast/html/object-border-expected.txt: Added.
  • fast/html/object-border.html: Added.
  • fast/html/resources/images/blue-border.png: Added.
  • fast/html/resources/images/blue.png: Added.
21:36 Changeset [74956] by darin@apple.com

Try to fix Chromium build.

  • history/HistoryItem.cpp:

(WebCore::HistoryItem::encodeBackForwardTreeNode): Added a V8 case here.
Not sure this ever will be used with V8.
(WebCore::HistoryItem::decodeBackForwardTree): Ditto.

21:31 Changeset [74955] by darin@apple.com

Try to fix Leopard build.

  • history/HistoryItem.cpp: Use a consistent type, uint64_t, for the

size variable.

18:27 Changeset [74954] by inferno@chromium.org

2011-01-01 Abhishek Arya <inferno@chromium.org>

Reviewed by Darin Adler.

Fixes before child calculation when adding anonymous childs to table parts.
https://bugs.webkit.org/show_bug.cgi?id=50932

Fix in r74364 was incomplete. When before child is equal to the table part(to
which the new child is getting added), it confuses the table part to add it
incorrectly as an after child. The patch fixes by passing the before child as
the table part's first child.

Tests: fast/css-generated-content/table-before-after-child-add.html

fast/css-generated-content/table-cell-before-after-child-add.html
fast/css-generated-content/table-row-before-after-child-add.html
fast/css-generated-content/table-row-before-after-child-add.html

  • rendering/RenderTable.cpp: (WebCore::RenderTable::addChild):
  • rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::addChild):
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::addChild):

2010-12-20 Abhishek Arya <inferno@chromium.org>

Reviewed by Darin Adler.

Tests that "before" and "after" childs are added to table correctly.
https://bugs.webkit.org/show_bug.cgi?id=50932

  • fast/css-generated-content/table-before-after-child-add.html: Added.
  • fast/css-generated-content/table-before-child-add.html: Removed.
  • fast/css-generated-content/table-cell-before-after-child-add.html: Added.
  • fast/css-generated-content/table-row-before-after-child-add.html: Added.
  • platform/mac/fast/css-generated-content/table-before-after-child-add-expected.checksum: Added.
  • platform/mac/fast/css-generated-content/table-before-after-child-add-expected.png: Added.
  • platform/mac/fast/css-generated-content/table-before-after-child-add-expected.txt: Added.
  • platform/mac/fast/css-generated-content/table-before-child-add-expected.txt: Removed.
  • platform/mac/fast/css-generated-content/table-cell-before-after-child-add-expected.checksum: Added.
  • platform/mac/fast/css-generated-content/table-cell-before-after-child-add-expected.png: Added.
  • platform/mac/fast/css-generated-content/table-cell-before-after-child-add-expected.txt: Added.
  • platform/mac/fast/css-generated-content/table-row-before-after-child-add-expected.checksum: Added.
  • platform/mac/fast/css-generated-content/table-row-before-after-child-add-expected.png: Added.
  • platform/mac/fast/css-generated-content/table-row-before-after-child-add-expected.txt: Added.
  • platform/mac/fast/css-generated-content/table-table-before-after-child-add-expected.checksum: Added.
  • platform/mac/fast/css-generated-content/table-table-before-after-child-add-expected.png: Added.
  • platform/mac/fast/css-generated-content/table-table-before-after-child-add-expected.txt: Added.
18:02 Changeset [74953] by mitz@apple.com

Shrink HTMLTableCellElement
https://bugs.webkit.org/show_bug.cgi?id=51858

Reviewed by Simon Fraser.

  • html/HTMLTableCellElement.cpp:

(WebCore::HTMLTableCellElement::HTMLTableCellElement): Removed intialization of m_row and
m_col.

  • html/HTMLTableCellElement.h: Removed m_row and m_col and their accessors.
17:57 Changeset [74952] by darin@apple.com

Fix build.

  • platform/network/FormData.cpp:

(WebCore::FormData::create): Roll back uint8_t change.
(WebCore::FormData::flatten): Ditto.
(WebCore::FormData::flattenToString): Ditto.
(WebCore::encode): Ditto.
(WebCore::decode): Ditto.
(WebCore::FormData::encodeForBackForward):

  • platform/network/FormData.h: Ditto.
  • platform/network/mac/FormDataStreamMac.mm:

(WebCore::advanceCurrentStream): Ditto.

17:35 Changeset [74951] by darin@apple.com

2011-01-03 Darin Adler <darin@apple.com>

Reviewed by Brady Eidson.

Add code to encode/decode the back/forward tree
https://bugs.webkit.org/show_bug.cgi?id=51853

  • history/HistoryItem.cpp: (WebCore::HistoryItem::encodeBackForwardTree): Added. (WebCore::HistoryItem::encodeBackForwardTreeNode): Added. (WebCore::HistoryItem::decodeBackForwardTree): Added.
  • history/HistoryItem.h: Added functions above.
  • platform/network/FormData.cpp: (WebCore::FormData::create): Changed type to Vector<uint8_t> instead of Vector<char>. This type is used in our newer code for vectors of bytes. (WebCore::FormData::flatten): Ditto. (WebCore::FormData::flattenToString): Ditto. Had to add a cast here. (WebCore::FormData::encodeForBackForward): Added. (WebCore::FormData::decodeForBackForward): Added.
  • platform/network/FormData.h: Changed type to Vector<uint8_t> instead of Vector<char>. Also made some single-argument constructors explicit. Also added the new functions.
  • platform/network/mac/FormDataStreamMac.mm: (WebCore::advanceCurrentStream): Changed to use uint8_t to match above.
17:28 Changeset [74950] by simon.fraser@apple.com

2011-01-03 Simon Fraser <simon.fraser@apple.com>

Attempt to fix GTK build.

  • platform/graphics/gtk/FontGtk.cpp: (WebCore::drawGlyphsShadow):
16:54 Changeset [74949] by psolanki@apple.com

Mac build fix. Define WTF_USE_CFNETWORK for Windows build only.

  • WebCoreSupport/WebInspectorClientCF.cpp:
16:39 Changeset [74948] by bweinstein@apple.com

Windows build fix. Define WTF_USE_CFNETWORK in WebInspectorClientCF.

  • WebCoreSupport/WebInspectorClientCF.cpp:
16:21 Changeset [74947] by commit-queue@webkit.org

2011-01-03 Helder Correia <helder@sencha.com>

Reviewed by Simon Fraser.

ContextShadow can avoid code duplication for getting the CTM
https://bugs.webkit.org/show_bug.cgi?id=51799

ContextShadow defines its own getTransformationMatrixFromContext()
which does exactly the same as GraphicsContext::getCTM().

Existing tests: fast/canvas/canvas*shadow*html

  • platform/graphics/ContextShadow.cpp: (WebCore::ContextShadow::mustUseContextShadow): (WebCore::ContextShadow::adjustBlurDistance): (WebCore::ContextShadow::calculateLayerBoundingRect):
  • platform/graphics/ContextShadow.h:
  • platform/graphics/cairo/ContextShadowCairo.cpp: (WebCore::ContextShadow::beginShadowLayer): (WebCore::ContextShadow::endShadowLayer): (WebCore::ContextShadow::drawRectShadowWithoutTiling):
  • platform/graphics/cairo/FontCairo.cpp: (WebCore::drawGlyphsShadow):
  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::drawPathShadow):
  • platform/graphics/cairo/ImageCairo.cpp: (WebCore::BitmapImage::draw):
  • platform/graphics/gtk/FontGtk.cpp: (WebCore::drawGlyphsShadow):
  • platform/graphics/qt/ContextShadowQt.cpp: (WebCore::ContextShadow::beginShadowLayer): (WebCore::ContextShadow::endShadowLayer):
  • platform/graphics/qt/FontQt.cpp: (WebCore::drawTextCommon):
  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::fillRoundedRect):
  • platform/graphics/qt/ImageQt.cpp: (WebCore::BitmapImage::draw):
  • platform/graphics/qt/StillImageQt.cpp: (WebCore::StillImage::draw):
16:09 Changeset [74946] by darin@apple.com

2011-01-03 Darin Adler <darin@apple.com>

Reviewed by Dan Bernstein.

InsertTextCommand::m_charactersAdded is unused
https://bugs.webkit.org/show_bug.cgi?id=51849

  • editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::InsertTextCommand): Don't initialize m_charactersAdded. (WebCore::InsertTextCommand::input): Don't update m_charactersAdded.
  • editing/InsertTextCommand.h: Removed charactersAdded function and m_charactersAdded data member.
15:56 Changeset [74945] by commit-queue@webkit.org

2011-01-03 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Move paintMenuListButton() to RenderThemeGtk.cpp
https://bugs.webkit.org/show_bug.cgi?id=51832

Method paintMenuListButton() contains code common to both gtk 2
and 3, so it can be moved to RenderThemeGtk.cpp instead of
duplicating it.

  • platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::paintMenuListButton):
  • platform/gtk/RenderThemeGtk2.cpp:
  • platform/gtk/RenderThemeGtk3.cpp:
15:52 WebKit Team edited by psolanki@apple.com
Adding myself to the committers list. (diff)
15:52 Changeset [74944] by xan@webkit.org

2011-01-03 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

  • autogen.sh: also pass $ACLOCAL_FLAGS for tools that set that env variable (like jhbuild).
15:45 Changeset [74943] by psolanki@apple.com

2011-01-03 Pratik Solanki <psolanki@apple.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=51850
Put CFNetwork loader code inside USE(CFNETWORK)

Add USE(CFNETWORK) macros around all the cf/mac network files. Also added all CFNetwork
files to the WebCore Xcode project.

  • WebCore.xcodeproj/project.pbxproj:
  • loader/cf/ResourceLoaderCFNet.cpp:
  • loader/mac/ResourceLoaderMac.mm:
  • platform/network/cf/AuthenticationCF.cpp:
  • platform/network/cf/AuthenticationCF.h:
  • platform/network/cf/CookieJarCFNet.cpp:
  • platform/network/cf/CookieStorageCFNet.cpp:
  • platform/network/cf/CookieStorageCFNet.h:
  • platform/network/cf/CredentialStorageCFNet.cpp:
  • platform/network/cf/FormDataStreamCFNet.cpp:
  • platform/network/cf/FormDataStreamCFNet.h:
  • platform/network/cf/LoaderRunLoopCF.cpp:
  • platform/network/cf/LoaderRunLoopCF.h:
  • platform/network/cf/ResourceError.h:
  • platform/network/cf/ResourceHandleCFNet.cpp:
  • platform/network/cf/ResourceRequest.h:
  • platform/network/cf/ResourceRequestCFNet.cpp:
  • platform/network/cf/ResourceRequestCFNet.h:
  • platform/network/cf/ResourceResponse.h:
  • platform/network/cf/ResourceResponseCFNet.cpp:
  • platform/network/mac/AuthenticationMac.h:
  • platform/network/mac/AuthenticationMac.mm:
  • platform/network/mac/FormDataStreamMac.h:
  • platform/network/mac/FormDataStreamMac.mm:
  • platform/network/mac/ResourceError.h:
  • platform/network/mac/ResourceHandleMac.mm:
  • platform/network/mac/ResourceRequest.h:
  • platform/network/mac/ResourceRequestMac.mm:
  • platform/network/mac/ResourceResponse.h:
  • platform/network/mac/ResourceResponseMac.mm:
15:43 Changeset [74942] by xan@webkit.org

2011-01-03 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

Use autoreconf instead of calling manually all the usual commands.

  • autogen.sh: call autoreconf instead of aclocal/autoheader/autoconf/automake/libtoolize.
15:42 Changeset [74941] by commit-queue@webkit.org

2011-01-03 Yi Shen <yi.4.shen@nokia.com>

Reviewed by Adam Barth.

[Qt] Add SelectAll option to the context menu for the editor
https://bugs.webkit.org/show_bug.cgi?id=50049

Set shortcut for the SelectAll action.

  • QtTestBrowser/mainwindow.cpp: (MainWindow::buildUI):

2011-01-03 Yi Shen <yi.4.shen@nokia.com>

Reviewed by Adam Barth.

[Qt] Add SelectAll option to the context menu for the editor
https://bugs.webkit.org/show_bug.cgi?id=50049

Enable SelectAll for the Qt context menu.

  • page/ContextMenuController.cpp: (WebCore::ContextMenuController::populate):
  • platform/ContextMenuItem.h:
  • platform/LocalizationStrategy.h:
  • platform/LocalizedStrings.cpp: (WebCore::contextMenuItemTagSelectAll):
  • platform/LocalizedStrings.h:

2011-01-03 Yi Shen <yi.4.shen@nokia.com>

Reviewed by Adam Barth.

[Qt] Add SelectAll option to the context menu for the editor
https://bugs.webkit.org/show_bug.cgi?id=50049

Enable SelectAll for the Qt context menu.

  • Api/qwebpage.cpp: (webActionForContextMenuAction): (QWebPage::action):
  • WebCoreSupport/WebPlatformStrategies.cpp: (WebPlatformStrategies::contextMenuItemTagSelectAll):
  • WebCoreSupport/WebPlatformStrategies.h:

2011-01-03 Yi Shen <yi.4.shen@nokia.com>

Reviewed by Adam Barth.

[Qt] Add SelectAll option to the context menu for the editor
https://bugs.webkit.org/show_bug.cgi?id=50049

Add WebPlatformStrategies::contextMenuItemTagSelectAll for Qt.

  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp: (WebKit::WebPlatformStrategies::contextMenuItemTagSelectAll):
  • WebProcess/WebCoreSupport/WebPlatformStrategies.h:
14:25 Changeset [74940] by weinig@apple.com

Reviewed, tweaked and landed by Sam Weinig.

Patch by Chris Fleizach <cfleizach@apple.com> on 2011-01-03
WebKit2: Accessibility support (42130)
<rdar://problem/7660629>

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
13:53 Changeset [74939] by mihaip@chromium.org

2011-01-03 Mihai Parparita <mihaip@chromium.org>

Unreviewed, Chromium test expectation update.

Group tests that fail on Leopard but pass on Snow Leopard (due to
stale platform/mac baselines).

  • platform/chromium/test_expectations.txt:
13:42 Changeset [74938] by paroga@webkit.org

2011-01-03 Patrick Gansterer <paroga@webkit.org>

Reviewed by Darin Adler.

[WINCE] Provide third party directory via environment variable
https://bugs.webkit.org/show_bug.cgi?id=51643

  • Source/cmake/OptionsWinCE.cmake:
13:40 Changeset [74937] by mitz@apple.com

Shrink RootInlineBox
https://bugs.webkit.org/show_bug.cgi?id=51847

Reviewed by Darin Adler.

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::alignBoxesInBlockDirection): Changed to use the baselineType()
accessor.

  • rendering/RootInlineBox.h: Rolled m_baselineType into a bitfield. Changed its type to

unsigned because otherwise MSVC treats it as signed.
(WebCore::RootInlineBox::baselineType): Added a cast.

13:38 Changeset [74936] by darin@apple.com
  • wtf/Forward.h: Added Decoder and Encoder.

Reviewed by Brady Eidson.

13:36 Changeset [74935] by kov@webkit.org

Adding files I missed in my last git add. *shame*

13:21 Changeset [74934] by levin@chromium.org

2011-01-03 David Levin <levin@chromium.org>

Reviewed by Eric Seidel.

check-webkit-style shouldn't consider "value" automatically to be a meaningless name.
https://bugs.webkit.org/show_bug.cgi?id=51842

  • Scripts/webkitpy/style/checkers/cpp.py: Remove the check for value.
  • Scripts/webkitpy/style/checkers/cpp_unittest.py: Remove the test for value.
13:20 Changeset [74933] by kov@webkit.org

WebKit/gtk

2011-01-03 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Martin Robinson.

[GTK] Split webkitprivate.{cpp,h} in more manageable chunks
https://bugs.webkit.org/show_bug.cgi?id=50698

Final patch, removing webkitprivate.{cpp,h}, and adding a
webkitglobals module to hold non-object-specific functions and
definitions that do not make sense on their own.

  • GNUmakefile.am:
  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::createWindow):
  • WebCoreSupport/ContextMenuClientGtk.cpp:
  • WebCoreSupport/DocumentLoaderGtk.cpp: (WebKit::DocumentLoader::attachToFrame):
  • WebCoreSupport/DragClientGtk.cpp:
  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
  • WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::ignoreWordInSpellDocument): (WebKit::EditorClient::learnWord): (WebKit::EditorClient::checkSpellingOfString): (WebKit::EditorClient::getGuessesForWord):
  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::createDocumentLoader):
  • WebCoreSupport/InspectorClientGtk.cpp:
  • webkit/webkit.h:
  • webkit/webkitapplicationcache.cpp: (webkit_application_cache_set_maximum_size):
  • webkit/webkitdownload.cpp: (webkit_download_class_init):
  • webkit/webkitgeolocationpolicydecision.cpp:
  • webkit/webkitglobals.cpp: Added. (webkit_get_default_session): (webkit_set_cache_model): (webkit_get_cache_model): (webkit_get_web_plugin_database): (currentToplevelCallback): (closeIconDatabaseOnExit): (webkitInit): (WebKit::pasteboardHelperInstance):
  • webkit/webkitglobals.h: Added.
  • webkit/webkitglobalsprivate.h: Copied from WebKit/gtk/webkit/webkitwebsettingsprivate.h.
  • webkit/webkithittestresult.cpp: (webkit_hit_test_result_class_init):
  • webkit/webkitnetworkrequest.cpp: (webkit_network_request_class_init):
  • webkit/webkitnetworkresponse.cpp: (webkit_network_response_class_init):
  • webkit/webkitprivate.cpp: Removed.
  • webkit/webkitprivate.h: Removed.
  • webkit/webkitsecurityorigin.cpp:
  • webkit/webkitviewportattributes.cpp:
  • webkit/webkitwebbackforwardlist.cpp: (webkit_web_back_forward_list_class_init):
  • webkit/webkitwebdatabase.cpp:
  • webkit/webkitwebdatasource.cpp: (webkit_web_data_source_class_init): (webkit_web_data_source_new_with_request): (WebKit::kitNew):
  • webkit/webkitwebframe.cpp: (webkit_web_frame_class_init):
  • webkit/webkitwebframeprivate.h:
  • webkit/webkitwebhistoryitem.cpp: (webkit_web_history_item_class_init):
  • webkit/webkitwebinspector.cpp:
  • webkit/webkitwebnavigationaction.cpp:
  • webkit/webkitwebplugin.cpp: (webkit_web_plugin_class_init):
  • webkit/webkitwebplugindatabase.cpp: (webkit_web_plugin_database_class_init):
  • webkit/webkitwebpluginprivate.h:
  • webkit/webkitwebpolicydecision.cpp:
  • webkit/webkitwebresource.cpp:
  • webkit/webkitwebsettings.cpp: (webkit_web_settings_class_init): (webkitWebViewGetEnchantDicts): (WebKit::core):
  • webkit/webkitwebsettingsprivate.h:
  • webkit/webkitwebview.cpp: (webkit_web_view_class_init): (webkit_web_view_update_settings): (webkit_web_view_settings_notify):
  • webkit/webkitwebview.h:
  • webkit/webkitwebwindowfeatures.cpp: (webkit_web_window_features_class_init): (WebKit::kitNew):

WebCore

2011-01-03 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Martin Robinson.

[GTK] Split webkitprivate.{cpp,h} in more manageable chunks
https://bugs.webkit.org/show_bug.cgi?id=50698

Fix DOM bindings generation to no longer include the now-gone
webkitprivate.h header, including the appropriate replacements
instead.

  • bindings/scripts/CodeGeneratorGObject.pm:
13:16 Changeset [74932] by commit-queue@webkit.org

2011-01-03 Antonio Gomes <agomes@rim.com>

Unreviewed crash fix.

Follow up of r74891: potential crash fix (bogus assertion).

  • WebCoreSupport/EditorClientQt.cpp: (WebCore::editorCommandForKeyDownEvent):
13:13 Changeset [74931] by mihaip@chromium.org

2011-01-03 Mihai Parparita <mihaip@chromium.org>

Unreviewed, Chromium test expectation update.

Missed a few failing tests.

  • platform/chromium/test_expectations.txt:
13:10 Changeset [74930] by paroga@webkit.org

2011-01-03 Patrick Gansterer <paroga@webkit.org>

Reviewed by David Kilzer.

[WINCE] Adds a build slave.
https://bugs.webkit.org/show_bug.cgi?id=50523

  • BuildSlaveSupport/build.webkit.org-config/config.json: Add an entry for a release build of the WinCE port.
  • BuildSlaveSupport/build.webkit.org-config/master.cfg: Add platform flag to build the WinCE port.
13:04 Changeset [74929] by mihaip@chromium.org

2011-01-03 Mihai Parparita <mihaip@chromium.org>

Unreviewed, Chromium test expectation update.

Remove fast/, printing/, svg/, tables/ and transforms/ chromium-mac
baselines that are no longer necessary after r74892 (now that
chromium-mac scrollbars match mac ones).

  • platform/chromium-mac-leopard/fast/text/international/bidi-neutral-run-expected.checksum: Removed.
  • platform/chromium-mac-leopard/fast/text/international/bidi-neutral-run-expected.png: Removed.
  • platform/chromium-mac/fast/css/text-overflow-ellipsis-strict-expected.checksum: Removed.
  • platform/chromium-mac/fast/css/text-overflow-ellipsis-strict-expected.png: Removed.
  • platform/chromium-mac/fast/events/autoscroll-expected.checksum: Removed.
  • platform/chromium-mac/fast/events/autoscroll-expected.png: Removed.
  • platform/chromium-mac/fast/events/reveal-link-when-focused-expected.checksum: Removed.
  • platform/chromium-mac/fast/events/reveal-link-when-focused-expected.png: Removed.
  • platform/chromium-mac/fast/events/standalone-image-drag-to-editable-expected.checksum: Removed.
  • platform/chromium-mac/fast/events/standalone-image-drag-to-editable-expected.png: Removed.
  • platform/chromium-mac/fast/forms/basic-textareas-expected.checksum: Removed.
  • platform/chromium-mac/fast/forms/basic-textareas-expected.png: Removed.
  • platform/chromium-mac/fast/forms/basic-textareas-quirks-expected.checksum: Removed.
  • platform/chromium-mac/fast/forms/basic-textareas-quirks-expected.png: Removed.
  • platform/chromium-mac/fast/forms/button-default-title-expected.checksum: Removed.
  • platform/chromium-mac/fast/forms/button-default-title-expected.png: Removed.
  • platform/chromium-mac/fast/frames/frame-scrolling-attribute-expected.checksum: Removed.
  • platform/chromium-mac/fast/frames/frame-scrolling-attribute-expected.png: Removed.
  • platform/chromium-mac/fast/frames/iframe-scrolling-attribute-expected.checksum: Removed.
  • platform/chromium-mac/fast/frames/iframe-scrolling-attribute-expected.png: Removed.
  • platform/chromium-mac/fast/invalid/residual-style-expected.checksum: Removed.
  • platform/chromium-mac/fast/invalid/residual-style-expected.png: Removed.
  • platform/chromium-mac/fast/lists/001-vertical-expected.checksum: Removed.
  • platform/chromium-mac/fast/lists/001-vertical-expected.png: Removed.
  • platform/chromium-mac/fast/lists/008-vertical-expected.checksum: Removed.
  • platform/chromium-mac/fast/lists/008-vertical-expected.png: Removed.
  • platform/chromium-mac/fast/media/mq-relative-constraints-02-expected.checksum: Removed.
  • platform/chromium-mac/fast/media/mq-relative-constraints-02-expected.png: Removed.
  • platform/chromium-mac/fast/media/mq-relative-constraints-03-expected.checksum: Removed.
  • platform/chromium-mac/fast/media/mq-relative-constraints-03-expected.png: Removed.
  • platform/chromium-mac/fast/media/mq-relative-constraints-04-expected.checksum: Removed.
  • platform/chromium-mac/fast/media/mq-relative-constraints-04-expected.png: Removed.
  • platform/chromium-mac/fast/media/mq-relative-constraints-05-expected.checksum: Removed.
  • platform/chromium-mac/fast/media/mq-relative-constraints-05-expected.png: Removed.
  • platform/chromium-mac/fast/media/mq-relative-constraints-06-expected.checksum: Removed.
  • platform/chromium-mac/fast/media/mq-relative-constraints-06-expected.png: Removed.
  • platform/chromium-mac/fast/media/mq-relative-constraints-07-expected.checksum: Removed.
  • platform/chromium-mac/fast/media/mq-relative-constraints-07-expected.png: Removed.
  • platform/chromium-mac/fast/media/mq-relative-constraints-08-expected.checksum: Removed.
  • platform/chromium-mac/fast/media/mq-relative-constraints-08-expected.png: Removed.
  • platform/chromium-mac/fast/media/mq-relative-constraints-09-expected.checksum: Removed.
  • platform/chromium-mac/fast/media/mq-relative-constraints-09-expected.png: Removed.
  • platform/chromium-mac/fast/media/mq-width-absolute-01-expected.checksum: Removed.
  • platform/chromium-mac/fast/media/mq-width-absolute-01-expected.png: Removed.
  • platform/chromium-mac/fast/media/mq-width-absolute-02-expected.checksum: Removed.
  • platform/chromium-mac/fast/media/mq-width-absolute-02-expected.png: Removed.
  • platform/chromium-mac/fast/media/mq-width-absolute-03-expected.checksum: Removed.
  • platform/chromium-mac/fast/media/mq-width-absolute-03-expected.png: Removed.
  • platform/chromium-mac/fast/media/mq-width-absolute-04-expected.checksum: Removed.
  • platform/chromium-mac/fast/media/mq-width-absolute-04-expected.png: Removed.
  • platform/chromium-mac/fast/multicol/client-rects-expected.checksum: Removed.
  • platform/chromium-mac/fast/multicol/column-break-with-balancing-expected.checksum: Removed.
  • platform/chromium-mac/fast/multicol/column-break-with-balancing-expected.png: Removed.
  • platform/chromium-mac/fast/multicol/float-multicol-expected.checksum: Removed.
  • platform/chromium-mac/fast/multicol/float-multicol-expected.png: Removed.
  • platform/chromium-mac/fast/multicol/float-paginate-complex-expected.checksum: Removed.
  • platform/chromium-mac/fast/multicol/float-paginate-complex-expected.png: Removed.
  • platform/chromium-mac/fast/multicol/float-paginate-expected.checksum: Removed.
  • platform/chromium-mac/fast/multicol/float-paginate-expected.png: Removed.
  • platform/chromium-mac/fast/multicol/layers-in-multicol-expected.checksum: Removed.
  • platform/chromium-mac/fast/multicol/layers-in-multicol-expected.png: Removed.
  • platform/chromium-mac/fast/multicol/layers-split-across-columns-expected.checksum: Removed.
  • platform/chromium-mac/fast/multicol/paginate-block-replaced-expected.checksum: Removed.
  • platform/chromium-mac/fast/multicol/span/anonymous-style-inheritance-expected.checksum: Removed.
  • platform/chromium-mac/fast/multicol/span/anonymous-style-inheritance-expected.png: Removed.
  • platform/chromium-mac/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.checksum: Removed.
  • platform/chromium-mac/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.png: Removed.
  • platform/chromium-mac/fast/multicol/span/span-as-immediate-child-generated-content-expected.checksum: Removed.
  • platform/chromium-mac/fast/multicol/span/span-as-immediate-child-generated-content-expected.png: Removed.
  • platform/chromium-mac/fast/multicol/span/span-as-immediate-child-property-removal-expected.checksum: Removed.
  • platform/chromium-mac/fast/multicol/span/span-as-immediate-child-property-removal-expected.png: Removed.
  • platform/chromium-mac/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.checksum: Removed.
  • platform/chromium-mac/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.png: Removed.
  • platform/chromium-mac/fast/multicol/span/span-as-immediate-columns-child-expected.checksum: Removed.
  • platform/chromium-mac/fast/multicol/span/span-as-immediate-columns-child-removal-expected.checksum: Removed.
  • platform/chromium-mac/fast/multicol/span/span-as-immediate-columns-child-removal-expected.png: Removed.
  • platform/chromium-mac/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.checksum: Removed.
  • platform/chromium-mac/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png: Removed.
  • platform/chromium-mac/fast/multicol/span/span-as-nested-columns-child-expected.checksum: Removed.
  • platform/chromium-mac/fast/multicol/span/span-as-nested-columns-child-expected.png: Removed.
  • platform/chromium-mac/fast/multicol/span/span-margin-collapsing-expected.checksum: Removed.
  • platform/chromium-mac/fast/multicol/span/span-margin-collapsing-expected.png: Removed.
  • platform/chromium-mac/fast/multicol/table-vertical-align-expected.checksum: Removed.
  • platform/chromium-mac/fast/multicol/table-vertical-align-expected.png: Removed.
  • platform/chromium-mac/fast/repaint/overflow-scroll-body-appear-expected.checksum: Removed.
  • platform/chromium-mac/fast/repaint/overflow-scroll-body-appear-expected.png: Removed.
  • platform/chromium-mac/fast/table/027-vertical-expected.checksum: Removed.
  • platform/chromium-mac/fast/table/027-vertical-expected.png: Removed.
  • platform/chromium-mac/fast/table/028-vertical-expected.checksum: Removed.
  • platform/chromium-mac/fast/table/028-vertical-expected.png: Removed.
  • platform/chromium-mac/fast/table/038-vertical-expected.checksum: Removed.
  • platform/chromium-mac/fast/table/038-vertical-expected.png: Removed.
  • platform/chromium-mac/fast/table/040-vertical-expected.checksum: Removed.
  • platform/chromium-mac/fast/table/040-vertical-expected.png: Removed.
  • platform/chromium-mac/fast/table/border-collapsing/002-vertical-expected.checksum: Removed.
  • platform/chromium-mac/fast/table/border-collapsing/002-vertical-expected.png: Removed.
  • platform/chromium-mac/fast/table/border-collapsing/equal-precedence-resolution-vertical-expected.checksum: Removed.
  • platform/chromium-mac/fast/table/border-collapsing/equal-precedence-resolution-vertical-expected.png: Removed.
  • platform/chromium-mac/fast/table/table-display-types-vertical-expected.checksum: Removed.
  • platform/chromium-mac/fast/table/table-display-types-vertical-expected.png: Removed.
  • platform/chromium-mac/fast/text/backslash-to-yen-sign-euc-expected.checksum: Removed.
  • platform/chromium-mac/fast/text/backslash-to-yen-sign-euc-expected.png: Removed.
  • platform/chromium-mac/fast/text/text-letter-spacing-expected.checksum: Removed.
  • platform/chromium-mac/fast/text/text-letter-spacing-expected.png: Removed.
  • platform/chromium-mac/fast/transforms/rotated-transform-affects-scrolling-1-expected.checksum: Removed.
  • platform/chromium-mac/fast/transforms/rotated-transform-affects-scrolling-1-expected.png: Removed.
  • platform/chromium-mac/fast/transforms/rotated-transform-affects-scrolling-2-expected.checksum: Removed.
  • platform/chromium-mac/fast/transforms/rotated-transform-affects-scrolling-2-expected.png: Removed.
  • platform/chromium-mac/printing/return-from-printing-mode-expected.checksum: Removed.
  • platform/chromium-mac/printing/return-from-printing-mode-expected.png: Removed.
  • platform/chromium-mac/svg/custom/altglyph-expected.checksum: Removed.
  • platform/chromium-mac/svg/custom/altglyph-expected.png: Removed.
  • platform/chromium-mac/svg/custom/getscreenctm-in-scrollable-svg-area-expected.checksum: Removed.
  • platform/chromium-mac/svg/custom/getscreenctm-in-scrollable-svg-area-expected.png: Removed.
  • platform/chromium-mac/svg/custom/junk-data-expected.checksum: Removed.
  • platform/chromium-mac/svg/custom/junk-data-expected.png: Removed.
  • platform/chromium-mac/svg/custom/missing-xlink-expected.checksum: Removed.
  • platform/chromium-mac/svg/custom/missing-xlink-expected.png: Removed.
  • platform/chromium-mac/svg/custom/text-xy-updates-SVGList-expected.checksum: Removed.
  • platform/chromium-mac/svg/custom/text-xy-updates-SVGList-expected.png: Removed.
  • platform/chromium-mac/svg/dom/SVGLengthList-appendItem-expected.checksum: Removed.
  • platform/chromium-mac/svg/dom/SVGLengthList-appendItem-expected.png: Removed.
  • platform/chromium-mac/svg/dom/SVGLengthList-initialize-expected.checksum: Removed.
  • platform/chromium-mac/svg/dom/SVGLengthList-initialize-expected.png: Removed.
  • platform/chromium-mac/svg/dom/SVGLengthList-insertItemBefore-expected.checksum: Removed.
  • platform/chromium-mac/svg/dom/SVGLengthList-insertItemBefore-expected.png: Removed.
  • platform/chromium-mac/svg/dom/SVGLengthList-removeItem-expected.checksum: Removed.
  • platform/chromium-mac/svg/dom/SVGLengthList-removeItem-expected.png: Removed.
  • platform/chromium-mac/svg/dom/SVGLengthList-replaceItem-expected.checksum: Removed.
  • platform/chromium-mac/svg/dom/SVGLengthList-replaceItem-expected.png: Removed.
  • platform/chromium-mac/svg/dom/SVGLengthList-xml-dom-modifications-expected.checksum: Removed.
  • platform/chromium-mac/svg/dom/SVGLengthList-xml-dom-modifications-expected.png: Removed.
  • platform/chromium-mac/svg/dom/SVGNumberList-basics-expected.checksum: Removed.
  • platform/chromium-mac/svg/dom/SVGNumberList-basics-expected.png: Removed.
  • platform/chromium-mac/svg/dom/SVGPathSegList-appendItem-expected.checksum: Removed.
  • platform/chromium-mac/svg/dom/SVGPathSegList-appendItem-expected.png: Removed.
  • platform/chromium-mac/svg/dom/SVGPathSegList-clear-and-initialize-expected.checksum: Removed.
  • platform/chromium-mac/svg/dom/SVGPathSegList-clear-and-initialize-expected.png: Removed.
  • platform/chromium-mac/svg/dom/SVGPathSegList-insertItemBefore-expected.checksum: Removed.
  • platform/chromium-mac/svg/dom/SVGPathSegList-insertItemBefore-expected.png: Removed.
  • platform/chromium-mac/svg/dom/SVGPathSegList-removeItem-expected.checksum: Removed.
  • platform/chromium-mac/svg/dom/SVGPathSegList-removeItem-expected.png: Removed.
  • platform/chromium-mac/svg/dom/SVGPathSegList-replaceItem-expected.checksum: Removed.
  • platform/chromium-mac/svg/dom/SVGPathSegList-replaceItem-expected.png: Removed.
  • platform/chromium-mac/svg/dom/SVGPointList-basics-expected.checksum: Removed.
  • platform/chromium-mac/svg/dom/SVGPointList-basics-expected.png: Removed.
  • platform/chromium-mac/svg/dom/SVGStringList-basics-expected.checksum: Removed.
  • platform/chromium-mac/svg/dom/SVGStringList-basics-expected.png: Removed.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.checksum: Removed.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.png: Removed.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.checksum: Removed.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.png: Removed.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.checksum: Removed.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.png: Removed.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.checksum: Removed.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.png: Removed.
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.checksum: Removed.
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.png: Removed.
  • platform/chromium-mac/svg/dynamic-updates/SVGLineElement-svgdom-requiredFeatures-expected.checksum: Removed.
  • platform/chromium-mac/svg/dynamic-updates/SVGLineElement-svgdom-requiredFeatures-expected.png: Removed.
  • platform/chromium-mac/svg/dynamic-updates/SVGPatternElement-svgdom-patternTransform-prop-expected.checksum: Removed.
  • platform/chromium-mac/svg/dynamic-updates/SVGUseElement-dom-requiredFeatures-expected.checksum: Removed.
  • platform/chromium-mac/svg/dynamic-updates/SVGUseElement-dom-requiredFeatures-expected.png: Removed.
  • platform/chromium-mac/svg/in-html/circle-expected.checksum: Removed.
  • platform/chromium-mac/svg/in-html/circle-expected.png: Removed.
  • platform/chromium-mac/svg/text/kerning-expected.checksum: Removed.
  • platform/chromium-mac/svg/zoom/page/absolute-sized-document-scrollbars-expected.checksum: Removed.
  • platform/chromium-mac/svg/zoom/page/absolute-sized-document-scrollbars-expected.png: Removed.
  • platform/chromium-mac/svg/zoom/page/relative-sized-document-scrollbars-expected.checksum: Removed.
  • platform/chromium-mac/svg/zoom/page/relative-sized-document-scrollbars-expected.png: Removed.
  • platform/chromium-mac/svg/zoom/page/zoom-svg-float-border-padding-expected.checksum: Removed.
  • platform/chromium-mac/svg/zoom/page/zoom-svg-float-border-padding-expected.png: Removed.
  • platform/chromium-mac/svg/zoom/text/zoom-svg-float-border-padding-expected.checksum: Removed.
  • platform/chromium-mac/svg/zoom/text/zoom-svg-float-border-padding-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug96334-expected.checksum: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug96343-expected.checksum: Removed.
  • platform/chromium-mac/tables/mozilla/collapsing_borders/bug41262-3-expected.checksum: Removed.
  • platform/chromium-mac/tables/mozilla/collapsing_borders/bug41262-3-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/other/wa_table_thtd_rowspan-expected.checksum: Removed.
  • platform/chromium-mac/tables/mozilla/other/wa_table_thtd_rowspan-expected.png: Removed.
  • platform/chromium-mac/transforms/2d/transform-fixed-container-expected.checksum: Removed.
  • platform/chromium-mac/transforms/2d/transform-fixed-container-expected.png: Removed.
  • platform/chromium/test_expectations.txt:
13:04 Changeset [74928] by paroga@webkit.org

2011-01-03 Patrick Gansterer <paroga@webkit.org>

Reviewed by David Kilzer.

Add WinCE support to build-webkit
https://bugs.webkit.org/show_bug.cgi?id=51642

  • Scripts/build-webkit:
  • Scripts/webkitdirs.pm:
12:59 Changeset [74927] by eric@webkit.org

2011-01-03 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
https://bugs.webkit.org/show_bug.cgi?id=51802

I'm not the biggest fan of the test_failures or test_results classes,
but it's better to have one shared set of classes, than separate ones
for new vs. old run-webkit-test result handling.

This moves the ORWT results class "LayoutTestResults" over to using
TestResult and TestFailure classes, making it easy for us to
make all our sheriff-bot and other webkitpy code NRWT ready.

This also makes it a trivial patch to generate results.json information
from ORWT results.html files (for flaky test analysis, etc.) as well
as making it a one-liner to report test failure types when the
commit-queue sees flaky tests.

This patch tried not to add new functionality, but only to replace
the guts of LayoutTestResults, while adding unit tests and hoping
not to break anything.

I also moved callers which assumed User.prompt* were static/class methods
to using them as instance methods (since we'll eventually want to make them such).

In the process of re-writing things, I broke the rebaseline command, so I wrote
a unit test to catch my breakage were I do do so again in the future.

  • Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
  • Scripts/webkitpy/common/net/layouttestresults.py:
  • Scripts/webkitpy/common/net/layouttestresults_unittest.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_results.py:
  • Scripts/webkitpy/tool/commands/queries.py:
  • Scripts/webkitpy/tool/commands/rebaseline.py:
  • Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
  • Scripts/webkitpy/tool/mocktool.py:
12:57 Changeset [74926] by beidson@apple.com

Add Encode/Decode machinery Darin and I plan to work with for back/forward stuff in WebKit2.

Reviewed by Darin Adler.

Source/JavaScriptCore:

Starting out with a pure virtual interface to be implemented in WK2, but we might change that later.

  • wtf/Decoder.h: Added.
  • wtf/Encoder.h: Added.

WebCore:

  • ForwardingHeaders/wtf/Decoder.h: Added.
  • ForwardingHeaders/wtf/Encoder.h: Added.
12:40 Changeset [74925] by abarth@webkit.org

2011-01-03 Adam Barth <abarth@webkit.org>

Reviewed by Simon Fraser.

webkit-patch shouldn't waste time cleaning a working directory that's already clean
https://bugs.webkit.org/show_bug.cgi?id=51840

  • Scripts/webkitpy/common/checkout/scm.py:
12:36 Changeset [74924] by mihaip@chromium.org

2011-01-03 Mihai Parparita <mihaip@chromium.org>

Unreviewed, Chromium test expectation update.

New gradient tests fail on chromium-mac too.

  • platform/chromium/test_expectations.txt:
12:26 Changeset [74923] by mihaip@chromium.org

2011-01-03 Mihai Parparita <mihaip@chromium.org>

Unreviewed, Chromium test expectation update.

Remove editing/, fast/backgrounds, fast/block, fast/blockflow, and
fast/borders chromium-mac baselines that are no longer necessary after
r74892 (now that chromium-mac scrollbars match mac ones).

  • platform/chromium-mac/editing/deleting/delete-after-span-ws-001-expected.checksum: Removed.
  • platform/chromium-mac/editing/deleting/delete-after-span-ws-001-expected.png: Removed.
  • platform/chromium-mac/editing/deleting/delete-after-span-ws-002-expected.checksum: Removed.
  • platform/chromium-mac/editing/deleting/delete-after-span-ws-002-expected.png: Removed.
  • platform/chromium-mac/editing/deleting/delete-after-span-ws-003-expected.checksum: Removed.
  • platform/chromium-mac/editing/deleting/delete-after-span-ws-003-expected.png: Removed.
  • platform/chromium-mac/editing/deleting/delete-line-end-ws-001-expected.checksum: Removed.
  • platform/chromium-mac/editing/deleting/delete-line-end-ws-001-expected.png: Removed.
  • platform/chromium-mac/editing/deleting/delete-line-end-ws-002-expected.checksum: Removed.
  • platform/chromium-mac/editing/deleting/delete-line-end-ws-002-expected.png: Removed.
  • platform/chromium-mac/editing/inserting/insert-div-023-expected.checksum: Removed.
  • platform/chromium-mac/editing/inserting/insert-div-023-expected.png: Removed.
  • platform/chromium-mac/editing/selection/focus_editable_html-expected.checksum: Removed.
  • platform/chromium-mac/editing/selection/focus_editable_html-expected.png: Removed.
  • platform/chromium-mac/editing/selection/iframe-expected.checksum: Removed.
  • platform/chromium-mac/editing/selection/iframe-expected.png: Removed.
  • platform/chromium-mac/editing/selection/select-all-001-expected.checksum: Removed.
  • platform/chromium-mac/editing/selection/select-all-001-expected.png: Removed.
  • platform/chromium-mac/editing/selection/select-all-002-expected.checksum: Removed.
  • platform/chromium-mac/editing/selection/select-all-002-expected.png: Removed.
  • platform/chromium-mac/editing/selection/select-all-003-expected.checksum: Removed.
  • platform/chromium-mac/editing/selection/select-all-003-expected.png: Removed.
  • platform/chromium-mac/editing/selection/select-all-004-expected.checksum: Removed.
  • platform/chromium-mac/editing/selection/select-all-004-expected.png: Removed.
  • platform/chromium-mac/editing/selection/unrendered-001-expected.checksum: Removed.
  • platform/chromium-mac/editing/selection/unrendered-001-expected.png: Removed.
  • platform/chromium-mac/editing/selection/unrendered-002-expected.checksum: Removed.
  • platform/chromium-mac/editing/selection/unrendered-002-expected.png: Removed.
  • platform/chromium-mac/editing/selection/unrendered-003-expected.checksum: Removed.
  • platform/chromium-mac/editing/selection/unrendered-003-expected.png: Removed.
  • platform/chromium-mac/editing/selection/unrendered-004-expected.checksum: Removed.
  • platform/chromium-mac/editing/selection/unrendered-004-expected.png: Removed.
  • platform/chromium-mac/editing/selection/unrendered-005-expected.checksum: Removed.
  • platform/chromium-mac/editing/selection/unrendered-005-expected.png: Removed.
  • platform/chromium-mac/fast/backgrounds/background-inherit-color-bug-expected.checksum: Removed.
  • platform/chromium-mac/fast/backgrounds/background-inherit-color-bug-expected.png: Removed.
  • platform/chromium-mac/fast/block/basic/016-expected.checksum: Removed.
  • platform/chromium-mac/fast/block/basic/truncation-rtl-expected.checksum: Removed.
  • platform/chromium-mac/fast/block/basic/truncation-rtl-expected.png: Removed.
  • platform/chromium-mac/fast/blockflow/border-radius-clipping-vertical-lr-expected.checksum: Removed.
  • platform/chromium-mac/fast/blockflow/border-radius-clipping-vertical-lr-expected.png: Removed.
  • platform/chromium-mac/fast/blockflow/box-shadow-vertical-lr-expected.checksum: Removed.
  • platform/chromium-mac/fast/blockflow/box-shadow-vertical-lr-expected.png: Removed.
  • platform/chromium-mac/fast/blockflow/box-shadow-vertical-rl-expected.checksum: Removed.
  • platform/chromium-mac/fast/blockflow/fieldsets-expected.checksum: Removed.
  • platform/chromium-mac/fast/blockflow/fieldsets-expected.png: Removed.
  • platform/chromium-mac/fast/borders/border-image-scale-transform-expected.checksum: Removed.
  • platform/chromium-mac/fast/borders/border-image-scale-transform-expected.png: Removed.
  • platform/chromium/test_expectations.txt:
12:08 Changeset [74922] by laszlo.1.gombos@nokia.com

2011-01-03 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Unreviewed build fix.

[Qt] Add NullPtr.cpp introduced in r71155 to the Qt build system.

This fix is required for builds where HAVE(NULLPTR) is false
(e.g. some MSVC and Symbian builds).

  • wtf/wtf.pri:
12:02 Changeset [74921] by mihaip@chromium.org

2011-01-03 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium test expectation update.

Add failing expectations for tests that depend on elliptical gradient
support.

  • platform/chromium/test_expectations.txt:
12:01 Changeset [74920] by cfleizach@apple.com

AX: Regression: WebKit no longer auto-scrolls with VoiceOver navigation
https://bugs.webkit.org/show_bug.cgi?id=51833

Reviewed by Darin Adler.

WebCore:

Make sure the web area returns the contentsSize, not the same size as what is displayed.

Test: platform/mac/accessibility/webarea-size-equals-content-size.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::boundingBoxRect):

LayoutTests:

  • platform/mac/accessibility/webarea-size-equals-content-size-expected.txt: Added.
  • platform/mac/accessibility/webarea-size-equals-content-size.html: Added.
11:57 Changeset [74919] by simon.fraser@apple.com

2011-01-03 Simon Fraser <simon.fraser@apple.com>

Fix warning in 32-bit builds.

  • css/CSSGradientValue.cpp: (WebCore::CSSLinearGradientValue::createGradient):
11:50 Changeset [74918] by mihaip@chromium.org

2011-01-03 Mihai Parparita <mihaip@chromium.org>

Unreviewed, Chromium test expectation update.

Remove css2.1/ chromium-mac baselines that are no longer necessary after
r74892 (now that chromium-mac scrollbars match mac ones).

  • platform/chromium-mac/css2.1/t0803-c5502-mrgn-r-02-c-expected.checksum: Removed.
  • platform/chromium-mac/css2.1/t0803-c5502-mrgn-r-02-c-expected.png: Removed.
  • platform/chromium-mac/css2.1/t0803-c5505-mrgn-02-c-expected.checksum: Removed.
  • platform/chromium-mac/css2.1/t0803-c5505-mrgn-02-c-expected.png: Removed.
  • platform/chromium-mac/css2.1/t080301-c411-vt-mrgn-00-b-expected.checksum: Removed.
  • platform/chromium-mac/css2.1/t080301-c411-vt-mrgn-00-b-expected.png: Removed.
  • platform/chromium-mac/css2.1/t0905-c5525-fltclr-00-c-ag-expected.checksum: Removed.
  • platform/chromium-mac/css2.1/t0905-c5525-fltclr-00-c-ag-expected.png: Removed.
  • platform/chromium-mac/css2.1/t0905-c5525-fltmrgn-00-c-ag-expected.checksum: Removed.
  • platform/chromium-mac/css2.1/t0905-c5525-fltmrgn-00-c-ag-expected.png: Removed.
  • platform/chromium-mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.checksum: Removed.
  • platform/chromium-mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png: Removed.
  • platform/chromium-mac/css2.1/t0905-c5526-fltclr-00-c-ag-expected.checksum: Removed.
  • platform/chromium-mac/css2.1/t0905-c5526-fltclr-00-c-ag-expected.png: Removed.
  • platform/chromium-mac/css2.1/t1002-c5523-width-02-b-g-expected.checksum: Removed.
  • platform/chromium-mac/css2.1/t1002-c5523-width-02-b-g-expected.png: Removed.
  • platform/chromium-mac/css2.1/t1202-counters-08-b-expected.checksum: Removed.
  • platform/chromium-mac/css2.1/t1202-counters-08-b-expected.png: Removed.
  • platform/chromium-mac/css2.1/t1202-counters-09-b-expected.checksum: Removed.
  • platform/chromium-mac/css2.1/t1202-counters-09-b-expected.png: Removed.
  • platform/chromium-mac/css2.1/t140201-c535-bg-fixd-00-b-g-expected.checksum: Removed.
  • platform/chromium-mac/css2.1/t140201-c535-bg-fixd-00-b-g-expected.png: Removed.
  • platform/chromium-mac/css2.1/t140201-c537-bgfxps-00-c-ag-expected.checksum: Removed.
  • platform/chromium-mac/css2.1/t140201-c537-bgfxps-00-c-ag-expected.png: Removed.
  • platform/chromium-mac/css2.1/t1508-c527-font-07-b-expected.checksum: Removed.
  • platform/chromium-mac/css2.1/t1508-c527-font-07-b-expected.png: Removed.
  • platform/chromium/test_expectations.txt:
11:43 Changeset [74917] by mihaip@chromium.org

2011-01-03 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium test expectation update.

Remove failing expectations for tests that now pass (due to r74892).

  • platform/chromium/test_expectations.txt:
11:37 Changeset [74916] by commit-queue@webkit.org

2011-01-03 Benjamin C Meyer <bmeyer@rim.com>

Reviewed by Daniel Bates.

In the cmake build system move logic related to ENABLE_NOTIFICATIONS into its own block.
https://bugs.webkit.org/show_bug.cgi?id=51827

  • CMakeLists.txt:
11:36 Changeset [74915] by simon.fraser@apple.com

2011-01-03 Simon Fraser <simon.fraser@apple.com>

Reviewed by David Hyatt.

Implement -webkit-linear-gradient and -webkit-radial-gradient
https://bugs.webkit.org/show_bug.cgi?id=28152

Add support for -webkit-radial-gradients.

Tests: fast/gradients/css3-radial-gradients.html

fast/gradients/css3-radial-gradients2.html

  • css/CSSGradientValue.cpp: (WebCore::blend): Used to blend colors, which is necessary when truncating the start of radial gradients. (WebCore::GradientStop): Small struct to aid gradient stop processing. (WebCore::CSSGradientValue::addStops): Rename 'positions' to 'stops', and store the color so that we can blend it when truncating radial gradients. Changed to handle both linear and radial gradients. (WebCore::CSSRadialGradientValue::cssText): Update to follow the spec. (WebCore::CSSRadialGradientValue::resolveRadius): Stylistic change. (WebCore::distanceToClosestCorner): New utility method. (WebCore::distanceToFarthestCorner): Ditto. (WebCore::CSSRadialGradientValue::createGradient): New logic to deal with shape and fill rules.
  • css/CSSGradientValue.h: (WebCore::CSSGradientValue::isLinearGradient): Color-stop processing needs to know what kind of gradient it's dealing with, so add new isFooGradient methods. (WebCore::CSSGradientValue::isRadialGradient): Ditto. (WebCore::CSSLinearGradientValue::isLinearGradient): (WebCore::CSSRadialGradientValue::setShape): New setters for shape, size etc. (WebCore::CSSRadialGradientValue::setSizingBehavior): (WebCore::CSSRadialGradientValue::setEndHorizontalSize): (WebCore::CSSRadialGradientValue::setEndVerticalSize): (WebCore::CSSRadialGradientValue::isRadialGradient):
  • css/CSSParser.h:
  • css/CSSParser.h: Pass a CSSParserValueList* into parseFillPositionXY() and parseFillPosition() so we can use parseFillPosition() when parsing a gradient function.
  • css/CSSParser.cpp: (WebCore::CSSParser::parseFillPositionXY): Pass in a CSSParserValueList* (WebCore::CSSParser::parseFillPosition): Ditto (WebCore::CSSParser::parseFillProperty): Pass m_valueList to parseFillPosition. (WebCore::CSSParser::parseTransformOriginShorthand): Ditto (WebCore::CSSParser::parseRadialGradient): Flesh out radial gradient parsing. (WebCore::CSSParser::parseTransformOrigin): Pass m_valueList to parseFillPosition. (WebCore::CSSParser::parsePerspectiveOrigin): Ditto
  • css/CSSValueKeywords.in: New keywords for radial gradient shape and fill behaviors.
  • platform/graphics/Gradient.cpp: (WebCore::Gradient::Gradient): Pass aspect ratio for elliptical gradients.
  • platform/graphics/Gradient.h: Add aspect ratio for elliptical gradients. (WebCore::Gradient::create): (WebCore::Gradient::startRadius): Expose radii. (WebCore::Gradient::endRadius): (WebCore::Gradient::setStartRadius): Setters are required for when we need to scale color stops. (WebCore::Gradient::setEndRadius): (WebCore::Gradient::aspectRatio):
  • platform/graphics/cg/GradientCG.cpp: (WebCore::Gradient::paint): For elliptical gradients, scale the CTM.
  • platform/graphics/wince/GraphicsContextWinCE.cpp: (WebCore::GraphicsContext::fillRect): Use start/endRadius() rather than r0() and r1().
11:33 Changeset [74914] by abarth@webkit.org

2011-01-03 Adam Barth <abarth@webkit.org>

Reviewed by Simon Fraser.

webkit-patch should only hide update output if --quiet
https://bugs.webkit.org/show_bug.cgi?id=51838

As requested by smfr.

  • Scripts/webkitpy/tool/steps/update.py:
11:33 Changeset [74913] by mitz@apple.com

2011-01-03 Dan Bernstein <mitz@apple.com>

Reviewed by Simon Fraser.

Remove the unused RenderTableCell::m_percentageHeight
https://bugs.webkit.org/show_bug.cgi?id=51837

  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::RenderTableCell): Removed initialization of m_percentageHeight.
  • rendering/RenderTableCell.h: Removed m_percentageHeight.
11:31 Changeset [74912] by simon.fraser@apple.com

2011-01-03 Simon Fraser <simon.fraser@apple.com>

Reviewed by David Hyatt.

Implement -webkit-linear-gradient and -webkit-radial-gradient
https://bugs.webkit.org/show_bug.cgi?id=28152

Add support for the parsing and rendering of non-repeating CSS3 linear gradients,
according to <http://dev.w3.org/csswg/css3-images/#linear-gradients>.

Tests: fast/gradients/css3-color-stop-units.html

fast/gradients/css3-color-stops.html
fast/gradients/css3-gradient-parsing.html
fast/gradients/css3-linear-angle-gradients.html

  • css/CSSGradientValue.h: Add subclasses of CSSGradientValue for linear and radial gradients.
  • css/CSSGradientValue.cpp: (WebCore::CSSGradientValue::image): Add FIXME comment about why we can't cache the gradient sometimes. (WebCore::compareStops): positions are CSSValues now. (WebCore::CSSGradientValue::sortStopsIfNeeded): Add assertion that this is only called for old-style gradients. (WebCore::CSSGradientValue::addStops): New method that handles the spec rules about missing positions, ensuring that stop position is ordered, and spacing out stops without positions. Also normalize gradients which use stops outside the 0-1 range so that platforms can render them correctly. (WebCore::positionFromValue): Determin the position on the gradient line for percentage, number and length values. (WebCore::CSSGradientValue::computeEndPoint): (WebCore::CSSLinearGradientValue::cssText): (WebCore::endPointsFromAngle): Compute endpoints for a gradient which covers the rectangle given an angle. (WebCore::CSSLinearGradientValue::createGradient): (WebCore::CSSRadialGradientValue::cssText): (WebCore::CSSRadialGradientValue::resolveRadius): (WebCore::CSSRadialGradientValue::createGradient):
  • css/CSSParser.cpp: (WebCore::CSSParser::parseValue): Style fix. (WebCore::CSSParser::parseContent): Use isGeneratedImageValue() and parseGeneratedImage() (WebCore::CSSParser::parseFillImage): Use isGeneratedImageValue() and parseGeneratedImage() (WebCore::CSSParser::parseBorderImage): Use isGeneratedImageValue() and parseGeneratedImage() (WebCore::parseDeprecatedGradientPoint): Renamed to indicate that it's only used for -webkit-gradient. (WebCore::parseDeprecatedGradientColorStop): Renamed to indicate that it's only used for -webkit-gradient, and fixed to store CSSValues for the stop position. (WebCore::CSSParser::parseDeprecatedGradient): Renamed to indicate that it's only used for -webkit-gradient, and create CSSLinearGradientValue and CSSRadialGradientValue as appropriate. (WebCore::valueFromSideKeyword): (WebCore::parseGradientColorOrKeyword): Color parsing utility. (WebCore::CSSParser::parseLinearGradient): New method to parse linear gradients. (WebCore::CSSParser::parseRadialGradient): Stub for new method to parse radial gradients. (WebCore::CSSParser::isGeneratedImageValue): Detect gradients and CSS canvas. (WebCore::CSSParser::parseGeneratedImage): Parser for generated images like gradients and CSS canvas.
  • css/CSSParser.h:
  • platform/graphics/Gradient.h: (WebCore::Gradient::setP0): We need to be able to change the points when normalizing gradients. (WebCore::Gradient::setP1): Ditto.
11:18 Changeset [74911] by mihaip@chromium.org

2011-01-03 Mihai Parparita <mihaip@chromium.org>

Unreviewed, Chromium test expectation update.

Missed a few failing tests.

  • platform/chromium/test_expectations.txt:
11:04 Changeset [74910] by abarth@webkit.org

2011-01-03 Adam Barth <abarth@webkit.org>

Reviewed by David Levin.

commit-queue shouldn't reject patches twice if two bots process the same patch
https://bugs.webkit.org/show_bug.cgi?id=51805

Before raising an error, we first check whether the patch is still in
the commit-queue. This check is still racy, of course, but the time
window is much smaller.

  • Scripts/webkitpy/tool/bot/commitqueuetask.py:
11:01 Changeset [74909] by noam.rosenthal@nokia.com

2011-01-03 Noam Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Andreas Kling.

[Qt] document.getElementById(...) doesn't return the right object in combination with QGraphicsWidget
https://bugs.webkit.org/show_bug.cgi?id=51464

Added a way to bind any QObject created as a plugin to JavaScript,
by adding a custom member (qtObject) to WebCore::Widget.
Added a test to tst_qwebpage to make sure plugins created
as QGraphicsWidget are accessible through JavaScript.

  • bindings/js/ScriptControllerQt.cpp: (WebCore::ScriptController::createScriptInstanceForWidget):
  • platform/Widget.h:
  • platform/qt/WidgetQt.cpp: (WebCore::Widget::Widget): (WebCore::Widget::setBindingObject): (WebCore::Widget::bindingObject):

2011-01-03 Noam Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Andreas Kling.

[Qt] document.getElementById(...) doesn't return the right object in combination with QGraphicsWidget
https://bugs.webkit.org/show_bug.cgi?id=51464

Added a way to bind any QObject created as a plugin to JavaScript,
by adding a custom membe to WebCore::Widget.
Added a test to make sure plugins created as QGraphicsWidget are
accessible through JavaScript.

  • WebCoreSupport/FrameLoaderClientQt.cpp:
  • tests/qwebpage/tst_qwebpage.cpp: (PluginPage::createPlugin): (tst_QWebPage::graphicsWidgetPlugin):
10:55 Changeset [74908] by hyatt@apple.com

https://bugs.webkit.org/show_bug.cgi?id=51328

Reviewed by Simon Fraser.

WebCore:

Printing on a page with body { height: 100% } clips out the overflow contents. This happened
because the computePageRects function was never correct. It was using the layer's width and height
for the document's width and height, and the layer no longer includes overflow in its width and
height. It was also incorrectly assuming the first page would begin at (0,0), and this is an invalid
assumption in RTL or vertical text environments.

Added printing/page-count-percentage-height.html

  • page/PrintContext.cpp:

(WebCore::PrintContext::computePageRects):
(WebCore::PrintContext::computePageRectsWithPageSizeInternal):

LayoutTests:

Add layout test for printing clipping bug.

  • printing/page-count-percentage-height-expected.txt: Added.
  • printing/page-count-percentage-height.html: Added.
  • printing/script-tests/page-count-percentage-height.js: Added.

(test):

10:41 Changeset [74907] by ossy@webkit.org

Unreviewed, rolling out unnecessary r74905.

[Qt] DRT sideeffect revealed by r74896
https://bugs.webkit.org/show_bug.cgi?id=51829

  • platform/qt/Skipped:
10:40 Changeset [74906] by weinig@apple.com

Make run-api-tests less chatty.
https://bugs.webkit.org/show_bug.cgi?id=51831

Reviewed by Anders Carlsson.

  • Make script quiet by default and add --verbose option (replacing --quiet).
  • When not verbose, pipe stdout and stderr to devnull.
  • Scripts/run-api-tests:
10:33 Changeset [74905] by ossy@webkit.org

Unreviewed fix.

[Qt] DRT sideeffect revealed by r74896
https://bugs.webkit.org/show_bug.cgi?id=51829

  • platform/qt/Skipped: http/tests/misc/401-alternative-content.php added until fix.
10:29 Changeset [74904] by mihaip@chromium.org

2011-01-03 Mihai Parparita <mihaip@chromium.org>

Unreviewed, Chromium test expectation update.

Fix duplicate expectation.

  • platform/chromium/test_expectations.txt:
10:26 Changeset [74903] by xan@webkit.org

2011-01-03 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Disable superfluous GNU make built-in implicit rules
https://bugs.webkit.org/show_bug.cgi?id=51826

GNU make ships some superflous built-in rules that we never use
and that end up adding up to a very significant portion of our
total Makefile processing time. Disable them completely by
defining the rule without any recipe, as suggested by the GNU make
manual (10.5.6, Cancelling Implicit Rules).

In my system the null-build goes from:

make 43.51s user 12.77s system 99% cpu 56.628 total

to:

make 31.45s user 11.59s system 99% cpu 43.227 total

  • GNUmakefile.am: disable implicit built-in rules.
10:24 Changeset [74902] by psolanki@apple.com

2011-01-03 Pratik Solanki <psolanki@apple.com>

Unreviewed. Adding myself to committers.py.

  • Scripts/webkitpy/common/config/committers.py:
10:12 Changeset [74901] by laszlo.1.gombos@nokia.com

2011-01-03 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Unreviewed, build fix.

[Qt] Add back auth.html to the skipped list after r74896.

  • platform/qt/Skipped: Add http/tests/appcache/auth.html to the list.
10:10 Changeset [74900] by ossy@webkit.org

[Qt] Unreviewed buildfix for --minimal build after r74895.

  • html/InputType.cpp: Missing include added.
  • html/NumberInputType.cpp: Missing include added.
09:59 Changeset [74899] by dbates@webkit.org

2011-01-03 Daniel Bates <dbates@rim.com>

Attempt to fix the Chromium Linux Release build after changeset 74895 <http://trac.webkit.org/changeset/74895>.

The portion of the patch in <https://bugs.webkit.org/show_bug.cgi?id=51791> that modified the
file src/WebSearchableFormData.cpp was not landed (why?). Although the change log entry
associated with this change was landed.

  • src/WebSearchableFormData.cpp: (HTMLNames::IsInDefaultState):
09:53 Changeset [74898] by mihaip@chromium.org

2011-01-03 Mihai Parparita <mihaip@chromium.org>

Unreviewed. Update .gitignore with new JavaScriptCore location.

  • .gitignore:
09:48 Changeset [74897] by mihaip@chromium.org

2011-01-03 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by David Levin.

[Qt] Unskip some passing tests as the bot is migrated to Qt 4.7+
https://bugs.webkit.org/show_bug.cgi?id=51819

  • platform/qt/Skipped: Remove passing HTTP tests. Keep timer-vs-loading.html as it is still failing.
  • platform/qt/http/tests/loading/bad-scheme-subframe-expected.txt: Match the expected results with chromium to pass the test.
09:31 QtWebKitReleases edited by ademar.reis@openbossa.org
(diff)
09:28 QtWebKit edited by ademar.reis@openbossa.org
(diff)
09:26 Changeset [74896] by laszlo.1.gombos@nokia.com

2011-01-03 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by David Levin.

[Qt] Unskip some passing tests as the bot is migrated to Qt 4.7+
https://bugs.webkit.org/show_bug.cgi?id=51819

  • platform/qt/Skipped: Remove passing HTTP tests. Keep timer-vs-loading.html as it is still failing.
  • platform/qt/http/tests/loading/bad-scheme-subframe-expected.txt: Match the expected results with chromium to pass the test.
09:21 Changeset [74895] by darin@apple.com

2011-01-02 Darin Adler <darin@apple.com>

Reviewed by Kent Tamura.

Eliminate HTMLInputElement::m_deprecatedTypeNumber, other input refactoring and renaming
https://bugs.webkit.org/show_bug.cgi?id=51791

  • src/WebSearchableFormData.cpp: (HTMLNames::IsInDefaultState): Use hasAttribute(checkedAttr) to find out whether a button should be checked by default, rather than calling the defaultChecked function.

2011-01-02 Darin Adler <darin@apple.com>

Reviewed by Kent Tamura.

Eliminate HTMLInputElement::m_deprecatedTypeNumber, other input refactoring and renaming
https://bugs.webkit.org/show_bug.cgi?id=51791

  • dom/InputElement.h: Make sanitizeValueForTextField public so it can be called by InputType.
  • html/BaseButtonInputType.cpp: (WebCore::BaseButtonInputType::accessKeyAction): Added. (WebCore::BaseButtonInputType::storesValueSeparateFromAttribute): Added.
  • html/BaseButtonInputType.h: Ditto.
  • html/BaseCheckableInputType.cpp: (WebCore::BaseCheckableInputType::canSetStringValue): Added. (WebCore::BaseCheckableInputType::accessKeyAction): Added. (WebCore::BaseCheckableInputType::fallbackValue): Added. (WebCore::BaseCheckableInputType::storesValueSeparateFromAttribute): Added. (WebCore::BaseCheckableInputType::isCheckable): Added.
  • html/BaseCheckableInputType.h: Ditto.
  • html/BaseDateAndTimeInputType.cpp: (WebCore::BaseDateAndTimeInputType::hasSpinButton): Added.
  • html/BaseDateAndTimeInputType.h: Ditto.
  • html/BaseTextInputType.h: Made more functions private.
  • html/ButtonInputType.cpp: (WebCore::ButtonInputType::isTextButton): Added.
  • html/ButtonInputType.h: Ditto.
  • html/CheckboxInputType.cpp: (WebCore::CheckboxInputType::willDispatchClick): Added. (WebCore::CheckboxInputType::didDispatchClick): Added. (WebCore::CheckboxInputType::isCheckbox): Added.
  • html/CheckboxInputType.h: Ditto.
  • html/DateTimeInputType.cpp: (WebCore::DateTimeInputType::scaledStepValueShouldBeInteger): Fixed typo in name of this function.
  • html/DateTimeInputType.h: Ditto.
  • html/DateTimeLocalInputType.cpp: (WebCore::DateTimeLocalInputType::scaledStepValueShouldBeInteger): Ditto.
  • html/DateTimeLocalInputType.h: Ditto.
  • html/EmailInputType.cpp: (WebCore::EmailInputType::isEmailField): Added.
  • html/EmailInputType.h: Ditto.
  • html/FileInputType.cpp: (WebCore::FileInputType::FileInputType): Added. (WebCore::FileInputType::canSetStringValue): Added. (WebCore::FileInputType::canChangeFromAnotherType): Added. (WebCore::FileInputType::files): Added. (WebCore::FileInputType::canSetValue): Added. (WebCore::FileInputType::getTypeSpecificValue): Added. (WebCore::FileInputType::storesValueSeparateFromAttribute): Added. (WebCore::FileInputType::setFileList): Added. (WebCore::FileInputType::isFileUpload): Added.
  • html/FileInputType.h: Ditto.
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::HTMLInputElement): Updated for data member renaming and removal. (WebCore::HTMLInputElement::isValidValue): Call canSetStringValue instead of checking specific type numbers. (WebCore::HTMLInputElement::getAllowedValueStepWithDecimalPlaces): Use fastGetAttribute and fixed typo in the name of the scaledStepValueShouldBeInteger function. (WebCore::HTMLInputElement::isKeyboardFocusable): Call InputType::isKeyboardFocusable; moved most of the type-specific logic there. (WebCore::HTMLInputElement::shouldUseInputMethod): Call InputType::shouldUseInputMethod; moved the type-specific logic there. (WebCore::HTMLInputElement::handleBlurEvent): Call InputType::handleBlurEvent; moved the type-specific logic there. (WebCore::HTMLInputElement::setType): Tweak the names and types in this function. (WebCore::HTMLInputElement::updateType): Removed the code that set m_deprecatedTypeNumber. Compare types by comparing the value from formControlType. Removed file-specific logic and instead call InputType::canChangeFromAnotherType. Streamlined the logic for activation callbacks. (WebCore::HTMLInputElement::accessKeyAction): Call InputType::accessKeyAction; moved the type-specific logic there. (WebCore::HTMLInputElement::mapToEntry): Call InputType::shouldRespectHeightAndWidthAttributes and InputType::shouldRespectAlignAttribute. (WebCore::HTMLInputElement::parseMappedAttribute): Updated for name changes and the removal of m_defaultChecked. Changed the alt attribute logic to be based on the class of the renderer. Call InputType::srcAttributeChanged and moved the type-specific logic there. Call shouldRespectAlignAttribute and shouldRespectHeightAndWidthAttributes rather than having type-specific logic here. Call minOrMaxAttributeChanged. (WebCore::HTMLInputElement::rendererIsNeeded): Call InputType::rendererIsNeeded; moved the type-specific logic there. (WebCore::HTMLInputElement::attach): Removed the unneeded m_inited flag, which was redundant with the m_haveType flag. Call InputType::attach; moved the type-specific logic there. (WebCore::HTMLInputElement::altText): Use fastGetAttribute. (WebCore::HTMLInputElement::isSuccessfulSubmitButton): Call InputType::canBeSuccessfulSubmitButton; moved the type-specific logic there. (WebCore::HTMLInputElement::isActivatedSubmit): Updated for name changes. (WebCore::HTMLInputElement::setActivatedSubmit): Ditto. (WebCore::HTMLInputElement::reset): Updated to use InputType::storesValueSeparateFromAttribute. Also use hasAttribute(checkedAttr) rather than m_defaultChecked, since both are the same. Also updated for name change. (WebCore::HTMLInputElement::setChecked): Updated for name changes. Also added call to InputType::shouldSendChangeEventAfterCheckedChanged and moved the type-specific logic there. (WebCore::HTMLInputElement::setIndeterminate): Call isCheckable to see if indeterminate is allowed. Also updated for name changes. (WebCore::HTMLInputElement::copyNonAttributeProperties): Updated for name changes and removed data members. (WebCore::HTMLInputElement::value): Call InputType::getTypeSpecificValue and InputType::fallbackValue. Moved the type-specific logic there. (WebCore::HTMLInputElement::valueWithDefault): Call InputType::defaultValue. Moved the type-specific logic there. (WebCore::HTMLInputElement::setSuggestedValue): Call InputType::canSetSuggestedValue. Moved the type-specific logic there. (WebCore::HTMLInputElement::setValue): Call InputType::canSetValue. Moved the type-specific logic there. Clear the file list if it exists rather than checking the type explicitly. We could probably do that a more elegant way. (WebCore::HTMLInputElement::placeholder): Use fastGetAttribute. (WebCore::HTMLInputElement::setValueFromRenderer): Use the isFileUpload function in the assertion. (WebCore::HTMLInputElement::setFileListFromRenderer): Put most of the code from this function into FileInputType::setFileList. (WebCore::HTMLInputElement::preDispatchEventHandler): Changed to call InputType::willDispatchClick, which does the type-specific work. Still need to use a single struct for all types, because the type of the element could change during the event handling. (WebCore::HTMLInputElement::postDispatchEventHandler): Changed to call InputType::didDispatchClick. (WebCore::HTMLInputElement::defaultValue): Use fastGetAttribute. (WebCore::HTMLInputElement::accept): Use fastGetAttribute. (WebCore::HTMLInputElement::alt): Use fastGetAttribute. (WebCore::HTMLInputElement::src): Use fastGetAttribute. (WebCore::HTMLInputElement::setAutofilled): Updated for name changes. (WebCore::HTMLInputElement::files): Use InputType::files. (WebCore::HTMLInputElement::isAcceptableValue): Use InputType::isAcceptableValue. (WebCore::HTMLInputElement::sanitizeValue): Use InputType::sanitizeValue. (WebCore::HTMLInputElement::hasUnacceptableValue): Use InputType::hasUnacceptableValue. (WebCore::HTMLInputElement::needsActivationCallback): Use InputType::shouldResetOnDocumentActivation. (WebCore::HTMLInputElement::willMoveToNewOwnerDocument): Use InputType::willMoveToNewOwnerDocument. (WebCore::HTMLInputElement::dataList): Use InputType::shouldRespectListAttribute. (WebCore::HTMLInputElement::selectedOption): Tweaked logic and naming a bit. (WebCore::HTMLInputElement::stepUpFromRenderer): Use fastGetAttribute. (WebCore::HTMLInputElement::isSpeechEnabled): Use InputType::shouldRespectSpeechAttribute. (WebCore::HTMLInputElement::isTextButton): No longer inline. Calls through to InputType. (WebCore::HTMLInputElement::isRadioButton): Ditto. (WebCore::HTMLInputElement::isSearchField): Ditto. (WebCore::HTMLInputElement::isInputTypeHidden): Ditto. (WebCore::HTMLInputElement::isPasswordField): Ditto. (WebCore::HTMLInputElement::isCheckbox): Ditto. (WebCore::HTMLInputElement::isText): Ditto. (WebCore::HTMLInputElement::isEmailField): Ditto. (WebCore::HTMLInputElement::isFileUpload): Ditto. (WebCore::HTMLInputElement::isImageButton): Ditto. (WebCore::HTMLInputElement::isNumberField): Ditto. (WebCore::HTMLInputElement::isSubmitButton): Ditto. (WebCore::HTMLInputElement::isTelephoneField): Ditto. (WebCore::HTMLInputElement::isURLField): Ditto. (WebCore::HTMLInputElement::isEnumeratable): Ditto. (WebCore::HTMLInputElement::isChecked): No longer inline. Calls InputType::isCheckable. (WebCore::HTMLInputElement::hasSpinButton): No longer inline. Calls through to InputType. (WebCore::HTMLInputElement::supportsPlaceholder): No longer inline. Calls isTextType as before, but with no special case for ISINDEX. That special case was unneeded since it returns true from isTextType. (WebCore::HTMLInputElement::checkedRadioButtons): No longer inline. (WebCore::HTMLInputElement::handleBeforeTextInsertedEvent): No longer inline.
  • html/HTMLInputElement.h: Removed multiple unneeded includes. The big one is probably InputType.h, but also HTMLFormElement.h. Removed unneeded forward declarations. Made many functions no longer inline since they now need to make virtual function dispatches. Removed the unneeded defaultChecked and webkitdirectory functions. Both are handled by HTML attribute reflection for DOM bindings, and the callers instead can get at the attribute. Made updateCheckedRadioButtons public so it can be called by an InputType class. Removed DeprecatedInputType, InputTypeMap, createTypeMap, deprecatedInputType, allowsIndeterminate, respectHeightAndWidthAttrs, storesValueSeparateFromAttribute, m_imageLoader, m_fileList, m_deprecatedTypeNumber, m_defaultChecked, and m_inited. Renamed m_checked to m_isChecked, m_useDefaultChecked to m_reflectsCheckedAttribute, m_indeterminate tom_isIndeterminate, m_haveType to m_hasType, m_activeSubmit to m_isActivatedSubmit, and m_autofilled to m_isAutofilled.


  • html/HiddenInputType.cpp: (WebCore::HiddenInputType::accessKeyAction): Added. (WebCore::HiddenInputType::rendererIsNeeded) Added.: (WebCore::HiddenInputType::storesValueSeparateFromAttribute): Added. (WebCore::HiddenInputType::isHiddenType): Added. (WebCore::HiddenInputType::shouldRespectHeightAndWidthAttributes): Added.
  • html/HiddenInputType.h: Ditto.
  • html/ImageInputType.cpp: (WebCore::ImageInputType::ImageInputType): Moved out of the header file. (WebCore::ImageInputType::srcAttributeChanged): Added. (WebCore::ImageInputType::attach): Added. (WebCore::ImageInputType::willMoveToNewOwnerDocument): Added. (WebCore::ImageInputType::shouldRespectAlignAttribute): Added. (WebCore::ImageInputType::canBeSuccessfulSubmitButton): Added. (WebCore::ImageInputType::isImageButton): Added. (WebCore::ImageInputType::isEnumeratable): Added. (WebCore::ImageInputType::shouldRespectHeightAndWidthAttributes): Added.
  • html/ImageInputType.h: Ditto.
  • html/InputType.cpp: (WebCore::InputType::create): Changed argument type to String. There is no value in taking an AtomicString here. (WebCore::InputType::scaledStepValueShouldBeInteger): Fixed typo in this function name. (WebCore::InputType::canSetStringValue): Added. (WebCore::InputType::isKeyboardFocusable): Added. (WebCore::InputType::shouldUseInputMethod): Added. (WebCore::InputType::handleBlurEvent): Added. (WebCore::InputType::accessKeyAction): Added. (WebCore::InputType::attach): Added. (WebCore::InputType::srcAttributeChanged): Added. (WebCore::InputType::willMoveToNewOwnerDocument): Added. (WebCore::InputType::shouldRespectAlignAttribute): Added. (WebCore::InputType::canChangeFromAnotherType): Added. (WebCore::InputType::minOrMaxAttributeChanged): Added. (WebCore::InputType::canBeSuccessfulSubmitButton): Added. (WebCore::InputType::rendererIsNeeded): Added. (WebCore::InputType::files): Added. (WebCore::InputType::getTypeSpecificValue): Added. (WebCore::InputType::fallbackValue): Added. (WebCore::InputType::defaultValue): Added. (WebCore::InputType::canSetSuggestedValue): Added. (WebCore::InputType::shouldSendChangeEventAfterCheckedChanged): Added. (WebCore::InputType::storesValueSeparateFromAttribute): Added. (WebCore::InputType::canSetValue): Added. (WebCore::InputType::willDispatchClick): Added. (WebCore::InputType::didDispatchClick): Added. (WebCore::InputType::isAcceptableValue): Added. (WebCore::InputType::sanitizeValue): Added. (WebCore::InputType::hasUnacceptableValue): Added. (WebCore::InputType::setFileList): Added. (WebCore::InputType::shouldResetOnDocumentActivation): Added. (WebCore::InputType::shouldRespectListAttribute): Added. (WebCore::InputType::shouldRespectSpeechAttribute): Added. (WebCore::InputType::isTextButton): Added. (WebCore::InputType::isRadioButton): Added. (WebCore::InputType::isSearchField): Added. (WebCore::InputType::isHiddenType): Added. (WebCore::InputType::isPasswordField): Added. (WebCore::InputType::isCheckbox): Added. (WebCore::InputType::isEmailField): Added. (WebCore::InputType::isFileUpload): Added. (WebCore::InputType::isImageButton): Added. (WebCore::InputType::isNumberField): Added. (WebCore::InputType::isSubmitButton): Added. (WebCore::InputType::isTelephoneField): Added. (WebCore::InputType::isURLField): Added. (WebCore::InputType::isEnumeratable): Added. (WebCore::InputType::isCheckable): Added. (WebCore::InputType::hasSpinButton): Added. (WebCore::InputType::shouldRespectHeightAndWidthAttributes): Added.
  • html/InputType.h: Removed unneeded ExceptionCode.h include and used a typedef instead as we do when we want for forward declare it. Added includes and forward declarations needed for new functions. Added ClickHandlingState structure. Changed the argument to create to a String rather than AtomicString. Added many virtual functions.


  • html/IsIndexInputType.cpp: (WebCore::IsIndexInputType::shouldRespectListAttribute): Added.
  • html/IsIndexInputType.h: Ditto.
  • html/NumberInputType.cpp: (WebCore::NumberInputType::handleBlurEvent): Added. (WebCore::NumberInputType::isAcceptableValue): Added. (WebCore::NumberInputType::sanitizeValue): Added. (WebCore::NumberInputType::hasUnacceptableValue): Added. (WebCore::NumberInputType::shouldRespectSpeechAttribute): Added. (WebCore::NumberInputType::isNumberField): Added. (WebCore::NumberInputType::hasSpinButton): Added.
  • html/NumberInputType.h: Ditto.
  • html/PasswordInputType.cpp: (WebCore::PasswordInputType::shouldUseInputMethod): Added. (WebCore::PasswordInputType::shouldResetOnDocumentActivation): Added. (WebCore::PasswordInputType::shouldRespectListAttribute): Added. (WebCore::PasswordInputType::shouldRespectSpeechAttribute): Added. (WebCore::PasswordInputType::isPasswordField): Added.
  • html/PasswordInputType.h: Ditto.
  • html/RadioInputType.cpp: (WebCore::RadioInputType::isKeyboardFocusable): Added. (WebCore::RadioInputType::attach): Added. (WebCore::RadioInputType::shouldSendChangeEventAfterCheckedChanged): Added. (WebCore::RadioInputType::willDispatchClick): Added. (WebCore::RadioInputType::didDispatchClick): Added. (WebCore::RadioInputType::isRadioButton): Added.
  • html/RadioInputType.h: Ditto.
  • html/RangeInputType.cpp: (WebCore::RangeInputType::accessKeyAction): Added. (WebCore::RangeInputType::minOrMaxAttributeChanged): Added. (WebCore::RangeInputType::fallbackValue): Added. (WebCore::RangeInputType::sanitizeValue): Added. (WebCore::RangeInputType::shouldRespectListAttribute): Added.
  • html/RangeInputType.h: Ditto.
  • html/ResetInputType.cpp: (WebCore::ResetInputType::defaultValue): Added. (WebCore::ResetInputType::isTextButton): Added.
  • html/ResetInputType.h: Ditto.
  • html/SearchInputType.cpp: (WebCore::SearchInputType::shouldRespectSpeechAttribute): Added. (WebCore::SearchInputType::isSearchField): Added.
  • html/SearchInputType.h: Ditto.
  • html/SubmitInputType.cpp: (WebCore::SubmitInputType::canBeSuccessfulSubmitButton): Added. (WebCore::SubmitInputType::defaultValue): Added. (WebCore::SubmitInputType::isSubmitButton): Added. (WebCore::SubmitInputType::isTextButton): Added.
  • html/SubmitInputType.h: Ditto.
  • html/TelephoneInputType.cpp: (WebCore::TelephoneInputType::shouldRespectSpeechAttribute): Added. (WebCore::TelephoneInputType::isTelephoneField): Added.
  • html/TelephoneInputType.h: Ditto.
  • html/TextFieldInputType.cpp: (WebCore::TextFieldInputType::shouldUseInputMethod): Added. (WebCore::TextFieldInputType::sanitizeValue): Added. (WebCore::TextFieldInputType::shouldRespectListAttribute): Added.
  • html/TextFieldInputType.h: Ditto.
  • html/TextInputType.cpp: (WebCore::TextInputType::canSetSuggestedValue): Added. (WebCore::TextInputType::shouldRespectSpeechAttribute): Added.
  • html/TextInputType.h: Ditto.
  • html/TimeInputType.cpp: (WebCore::TimeInputType::scaledStepValueShouldBeInteger): Fixed typo in the name of this function.
  • html/TimeInputType.h: Ditto.
  • html/URLInputType.cpp: (WebCore::URLInputType::isURLField): Added.
  • html/URLInputType.h: Ditto.
09:11 Changeset [74894] by mihaip@chromium.org

2011-01-03 Mihai Parparita <mihaip@chromium.org>

Unreviewed, Chromium test expectation update.

Update expectations after r74892. A bunch of previously failing tests
now pass (since they match scrollbars with the mac port). Some tests
also started to fail, they should be fixed by removing their
chromium-mac baselines.

  • platform/chromium/test_expectations.txt:
09:02 Changeset [74893] by weinig@apple.com

Ensure that the correct initial focusable area is focused when tabbing
and shift-tabbing into the WKView.

Reviewed by Anders Carlsson.

  • UIProcess/API/mac/WKView.mm:

(-[WKView becomeFirstResponder]): Use the keyViewSelectionDirection to set
the initial focus.

08:16 Changeset [74892] by mihaip@chromium.org

2011-01-03 Mihai Parparita <mihaip@chromium.org>

Unreviewed.

NSScrollView-based scrollbars and ScrollBarTheme-based scrollbars don't look the same
https://bugs.webkit.org/show_bug.cgi?id=51151

Flip switch to use WebThemeEngine for Chromium/Mac scrollbar rendering,
so that it can match Safari's (and thus use the same baselines).

No new tests, should be covered by layout tests (which will need
expectation changes)

  • platform/chromium/ScrollbarThemeChromiumMac.mm:
08:04 Changeset [74891] by tonikitoo@webkit.org

2011-01-02 Antonio Gomes <agomes@rim.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Refactor EditorClientQt::handleKeyboardEvent
https://bugs.webkit.org/show_bug.cgi?id=51306

EditorClientQt::handleKeyboardEvent relies on QWebPagePrivate::editorActionForKeyEvent()
to handle all editor commands that have a QAction associted with it.
In practice, that covers most of editor commands (as one can see in editorCommandWebActions,
in qwebpage.cpp). However, there are some key down events that are associated to no QAction
or need special handling when features like spatial navigation or
caret browsing are enabled. Currently, these cases are being handled with confusing
and nested if/else switch's statements in EditorClientQt::handleKeyboardEvent(),
and the code is hardly readable.

This patch introduces a mapping hash for those cases, simplifying much
the code. Basically, nested switches statements mixed with if/else's were
refactored, and early returns were added right after an event gets consumed
by the Editor.

Since it is a refactor only patch, there is no funcionality change at
all, and then no new tests are being added.

  • WebCoreSupport/EditorClientQt.cpp: (WebCore::interpretKeyEvent): (WebCore::EditorClientQt::handleKeyboardEvent):
07:50 Changeset [74890] by commit-queue@webkit.org

2011-01-03 Antonio Gomes <agomes@rim.com>

Unreviewed build fix for WebKit/Gtk+.

RenderThemeGtk::initMediaColors() in RenderThemeGtk2.cpp needs to be
guarded by ENABLE(VIDEO), as it is in its header.

No new tests.

  • platform/gtk/RenderThemeGtk2.cpp:
06:00 Changeset [74889] by commit-queue@webkit.org

2011-01-03 Koan-Sin Tan <koansin.tan@gmail.com>

Reviewed by Xan Lopez.

"Tool/Scripts/run-launcher --gtk" stopped working after 74855
https://bugs.webkit.org/show_bug.cgi?id=51806

Originally, the $libraryName is 'JavaScriptCore'. When building release
one, the $libraryDir was 'WebKitBuild/Release/JavaScriptCore/../.libs/'
which doesn't exist anymore ('WebKitBuild/Release/JavaScriptCore'
is 'WebKitBuild/Release/Source/JavaScriptCore' now), and
'WebKitBuild/Release/Source/JavaScriptCore/../../.libs' looks weird,
so make it 'WebKitBuild/Release/.libs'

  • Scripts/webkitdirs.pm:

01/02/11:

21:45 Changeset [74888] by abarth@webkit.org

2011-01-02 Adam Barth <abarth@webkit.org>

Skip this test for now. It's been failing for a while. I'm
investigating the root cause now, but having this red on the buildbot
isn't productive.

  • platform/mac/Skipped:
20:53 Changeset [74887] by mitz@apple.com

<rdar://problem/8812159> Update copyright strings

Rubber-stamped by Simon Fraser.

Source/JavaScriptCore:

  • Info.plist:

Source/JavaScriptGlue:

  • Info.plist:

WebCore:

  • Info.plist:

WebKit/mac:

  • Info.plist:

WebKit2:

  • Info.plist:
  • WebProcess/Info.plist:

WebKitLibraries:

  • win/tools/scripts/COPYRIGHT-END-YEAR:
20:45 Changeset [74886] by mitz@apple.com

<rdar://problem/8806570> REGRESSION (r73337): Incorrect text match count when a match occurs in a text field
https://bugs.webkit.org/show_bug.cgi?id=51623

Reviewed by Sam Weinig.

  • editing/Editor.cpp:

(WebCore::Editor::countMatchesForText): Actually remember the original search range end
container and offset and restore them when needed, instead of using two references to the
same Range.

  • manual-tests/find-count-matches-after-text-control.html: Added.
19:29 Changeset [74885] by tkent@chromium.org

2011-01-02 Kent Tamura <tkent@chromium.org>

Unreviewed, test expectation update.

Two more fixes.

  • platform/chromium/test_expectations.txt:
19:18 Changeset [74884] by tkent@chromium.org

2011-01-02 Kent Tamura <tkent@chromium.org>

Unreviewed, correct test_expectations.txt syntax.

  • platform/chromium/test_expectations.txt:
18:18 Changeset [74883] by tkent@chromium.org

2011-01-02 Kent Tamura <tkent@chromium.org>

Unreviewed, test expectation update.

  • Add expectation files for application-plugin-plugins-disabled.html
  • Add some flaky tests to test_expectations.txt
  • platform/chromium-linux/plugins/application-plugin-plugins-disabled-expected.checksum: Added.
  • platform/chromium-linux/plugins/application-plugin-plugins-disabled-expected.png: Added.
  • platform/chromium-mac/plugins/application-plugin-plugins-disabled-expected.checksum: Added.
  • platform/chromium-mac/plugins/application-plugin-plugins-disabled-expected.png: Added.
  • platform/chromium-win/plugins/application-plugin-plugins-disabled-expected.checksum: Added.
  • platform/chromium-win/plugins/application-plugin-plugins-disabled-expected.png: Added.
  • platform/chromium-win/plugins/application-plugin-plugins-disabled-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
17:29 Changeset [74882] by benjamin.poulain@nokia.com

2011-01-02 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Csaba Osztrogonác.

WebKit 2 does not build on 64bits with a recent GCC
https://bugs.webkit.org/show_bug.cgi?id=51754

Use explicitely 64 bits types for the attributes of DatabaseDetails.

  • storage/DatabaseDetails.h: (WebCore::DatabaseDetails::expectedUsage): (WebCore::DatabaseDetails::currentUsage):

2011-01-02 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Csaba Osztrogonác.

WebKit 2 does not build on 64bits with a recent GCC
https://bugs.webkit.org/show_bug.cgi?id=51754

Change the argument coding for DatabaseDetails to use explicitely the 64 bits type.

  • Shared/OriginAndDatabases.h:
  • Shared/WebCoreArgumentCoders.h:
17:06 Changeset [74881] by paroga@webkit.org

2011-01-02 Patrick Gansterer <paroga@webkit.org>

Reviewed by Adam Barth.

Make EFL a core builder
https://bugs.webkit.org/show_bug.cgi?id=51804

  • Scripts/webkitpy/common/net/buildbot/buildbot.py:
  • Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
16:08 Changeset [74880] by ossy@webkit.org

[Qt] Unreviewed fix after r74855 and r74875.

  • BuildSlaveSupport/built-product-archive:
    • Create directories explicitly.
    • Pass shell=True to subprocess.call().
15:38 Changeset [74879] by paroga@webkit.org

2011-01-02 Patrick Gansterer <paroga@webkit.org>

Unreviewed WinCE build fix for r74868.

  • platform/graphics/wince/ImageBufferWinCE.cpp: (WebCore::getImageData):
15:26 Changeset [74878] by ossy@webkit.org

Fix GTK+ build after r74855.

Reviewed by Xan Lopez.

  • GNUmakefile.am: Fix include pathes.
14:27 Changeset [74877] by commit-queue@webkit.org

2011-01-02 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r74847.
http://trac.webkit.org/changeset/74847
https://bugs.webkit.org/show_bug.cgi?id=51803

"Preprocessor guards should be in header files" (Requested by
ap on #webkit).

  • bindings/js/JSDOMWindowBase.cpp:
  • dom/Document.cpp: (WebCore::Document::recalcStyle):
  • html/HTMLDocument.cpp:
  • loader/FrameLoader.cpp:
  • loader/ResourceLoadNotifier.cpp:
  • page/Chrome.cpp:
  • page/Console.cpp:
  • page/ContextMenuController.cpp:
  • page/DOMWindow.cpp: (WebCore::DOMWindow::dispatchEvent):
  • page/EventHandler.cpp:
  • page/Page.cpp:
  • storage/Database.cpp:
  • workers/AbstractWorker.cpp:
  • workers/DefaultSharedWorkerRepository.cpp:
  • workers/SharedWorker.cpp:
  • workers/Worker.cpp:
  • workers/WorkerContext.cpp:
  • workers/WorkerMessagingProxy.cpp:
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::callReadyStateChangeListener):
14:11 Changeset [74876] by robert@webkit.org

2011-01-02 Robert Hogan <robert@webkit.org>

Unreviewed, update expected results.

Update expected results for tests added in r74872

Skip test on Qt as Qt Styled Widgets are no longer getting
rendered when plugins are disabled. This is a bug.

  • platform/gtk/plugins/application-plugin-plugins-disabled-expected.txt: Copied from LayoutTests/plugins/application-plugin-plugins-disabled-expected.txt.
  • platform/qt/Skipped:
  • plugins/application-plugin-plugins-disabled-expected.txt:
13:44 Changeset [74875] by ossy@webkit.org

[Qt] Unreviewed fix after r74855.

Move JavaScriptCore to Source
https://bugs.webkit.org/show_bug.cgi?id=51604

  • BuildSlaveSupport/built-product-archive: JavaScriptCore -> Source/JavaScriptCore
13:28 Changeset [74874] by ossy@webkit.org

[Qt] Unreviewed run-javasriptcore-tests fix after r74855.

Move JavaScriptCore to Source
https://bugs.webkit.org/show_bug.cgi?id=51604

  • Scripts/webkitdirs.pm:
13:16 Changeset [74873] by ossy@webkit.org

Move JavaScriptCore to Source
https://bugs.webkit.org/show_bug.cgi?id=51604

Reviewed by Adam Barth.

Workaround until moving all sources to Source directory is finished.

  • Scripts/generate-forwarding-headers.pl: Add Sources to searching path for JavaScriptCore.
13:13 Changeset [74872] by robert@webkit.org

2011-01-02 Robert Hogan <robert@webkit.org>

Unreviewed.

Layout tests from changeset r56661 were missed

This test was accidentally omitted from changeset 56661.

See also https://webkit.org/b/32196

https://bugs.webkit.org/show_bug.cgi?id=42562

  • platform/qt/plugins/application-plugin-plugins-disabled-expected.txt: Added.
  • plugins/application-plugin-plugins-disabled-expected.txt: Added.
  • plugins/application-plugin-plugins-disabled.html: Added.
11:31 Changeset [74871] by paroga@webkit.org

2011-01-02 Patrick Gansterer <paroga@webkit.org>

[CMake] Unreviewed build fix.

  • CMakeLists.txt:
11:16 Changeset [74870] by paroga@webkit.org

2011-01-02 Patrick Gansterer <paroga@webkit.org>

[CMake] Unreviewed build fix.

  • CMakeLists.txt:
  • Source/cmake/OptionsCommon.cmake:
08:06 Changeset [74869] by robert@webkit.org

2011-01-02 Robert Hogan <robert@webkit.org>

Unreviewed, build fix.

[Qt] Fix DRT build after 74855

  • DumpRenderTree/qt/DumpRenderTree.pro:
02:38 Changeset [74868] by krit@webkit.org

2011-01-02 Dirk Schulze <krit@webkit.org>

Reviewed by Simon Fraser.

Clarify ImageBuffer and ImageData relationship
https://bugs.webkit.org/show_bug.cgi?id=51297

Use ByteArray instead of ImageData.

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::doPixelReadbackToCanvas):

2011-01-02 Dirk Schulze <krit@webkit.org>

Reviewed by Simon Fraser.

Clarify ImageBuffer and ImageData relationship
https://bugs.webkit.org/show_bug.cgi?id=51297

Remove references to ImageData and CanvasPixelArray from ImageBuffer and SVG filter/masker code,
since this was a layering violation, and replaced it by ByteArray.

No change of functionality, so no new test added.

  • html/ImageData.cpp: (WebCore::ImageData::create): (WebCore::ImageData::ImageData):
  • html/ImageData.h: Added new constructor with ByteArray input. (WebCore::ImageData::width): (WebCore::ImageData::height): (WebCore::ImageData::data):
  • html/canvas/CanvasPixelArray.cpp: (WebCore::CanvasPixelArray::create): (WebCore::CanvasPixelArray::CanvasPixelArray):
  • html/canvas/CanvasPixelArray.h: New conctructor with ByteArray input, used by HTML Canvas. (WebCore::CanvasPixelArray::data): (WebCore::CanvasPixelArray::length): (WebCore::CanvasPixelArray::set): (WebCore::CanvasPixelArray::get):
  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::getImageData): (WebCore::CanvasRenderingContext2D::putImageData):
  • platform/graphics/ImageBuffer.h:
  • platform/graphics/cairo/ImageBufferCairo.cpp: (WebCore::getImageData): (WebCore::ImageBuffer::getUnmultipliedImageData): (WebCore::ImageBuffer::getPremultipliedImageData): (WebCore::putImageData): (WebCore::ImageBuffer::putUnmultipliedImageData): (WebCore::ImageBuffer::putPremultipliedImageData):
  • platform/graphics/cg/ImageBufferCG.cpp: (WebCore::getImageData): (WebCore::ImageBuffer::getUnmultipliedImageData): (WebCore::ImageBuffer::getPremultipliedImageData): (WebCore::putImageData): (WebCore::ImageBuffer::putUnmultipliedImageData): (WebCore::ImageBuffer::putPremultipliedImageData):
  • platform/graphics/filters/FEBlend.cpp: (WebCore::FEBlend::apply):
  • platform/graphics/filters/FEColorMatrix.cpp: (WebCore::FEColorMatrix::apply):
  • platform/graphics/filters/FEComponentTransfer.cpp: (WebCore::FEComponentTransfer::apply):
  • platform/graphics/filters/FEComposite.cpp: (WebCore::FEComposite::apply):
  • platform/graphics/filters/FEConvolveMatrix.cpp: (WebCore::setDestinationPixels): (WebCore::FEConvolveMatrix::apply):
  • platform/graphics/filters/FEConvolveMatrix.h:
  • platform/graphics/filters/FEDisplacementMap.cpp: (WebCore::FEDisplacementMap::apply):
  • platform/graphics/filters/FEGaussianBlur.cpp: (WebCore::FEGaussianBlur::apply):
  • platform/graphics/filters/FELighting.cpp: (WebCore::FELighting::apply):
  • platform/graphics/filters/FEMorphology.cpp: (WebCore::FEMorphology::apply):
  • platform/graphics/filters/FETurbulence.cpp: (WebCore::FETurbulence::apply):
  • platform/graphics/filters/FilterEffect.cpp: (WebCore::FilterEffect::asImageBuffer): (WebCore::FilterEffect::asUnmultipliedImage): (WebCore::FilterEffect::asPremultipliedImage): (WebCore::FilterEffect::copyImageBytes): (WebCore::FilterEffect::copyUnmultipliedImage): (WebCore::FilterEffect::copyPremultipliedImage): (WebCore::FilterEffect::createUnmultipliedImageResult): (WebCore::FilterEffect::createPremultipliedImageResult):
  • platform/graphics/filters/FilterEffect.h:
  • platform/graphics/qt/ImageBufferQt.cpp: (WebCore::getImageData): (WebCore::ImageBuffer::getUnmultipliedImageData): (WebCore::ImageBuffer::getPremultipliedImageData): (WebCore::putImageData): (WebCore::ImageBuffer::putUnmultipliedImageData): (WebCore::ImageBuffer::putPremultipliedImageData):
  • platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::getImageData): (WebCore::ImageBuffer::getUnmultipliedImageData): (WebCore::ImageBuffer::getPremultipliedImageData): (WebCore::putImageData): (WebCore::ImageBuffer::putUnmultipliedImageData): (WebCore::ImageBuffer::putPremultipliedImageData):
  • platform/graphics/wince/ImageBufferWinCE.cpp: (WebCore::getImageData): (WebCore::ImageBuffer::getUnmultipliedImageData): (WebCore::ImageBuffer::getPremultipliedImageData): (WebCore::putImageData): (WebCore::ImageBuffer::putUnmultipliedImageData): (WebCore::ImageBuffer::putPremultipliedImageData):
  • platform/graphics/wx/ImageBufferWx.cpp: (WebCore::ImageBuffer::getUnmultipliedImageData): (WebCore::ImageBuffer::getPremultipliedImageData): (WebCore::ImageBuffer::putUnmultipliedImageData): (WebCore::ImageBuffer::putPremultipliedImageData):
  • rendering/RenderSVGResourceMasker.cpp: (WebCore::RenderSVGResourceMasker::drawContentIntoMaskImage):
01:51 Changeset [74867] by xan@webkit.org

2011-01-02 Xan Lopez <xlopez@igalia.com>

Fix GTK+ build.

  • GNUmakefile.am: tests do actually include JSC.
01:12 Changeset [74866] by abarth@webkit.org

2011-01-02 Adam Barth <abarth@webkit.org>

One more .. missing in the Qt build.

  • jsc.pro:
01:06 Changeset [74865] by xan@webkit.org

WebKit/gtk:

2011-01-02 Xan Lopez <xlopez@igalia.com>

Fix GTK+ build.

  • GNUmakefile.am: remove individual -I$(srcdir)/Source when we'll already get them from javascriptcore_cppflags, and add it for the introspection build (which is not tested in the bots).

JavaScriptCore:

2011-01-02 Xan Lopez <xlopez@igalia.com>

Fix GTK+ build.

  • GNUmakefile.am: add -I$(srcdir)/Source to the JSC cppflags so that anyone can include its headers without adding the prefix 'Source/'.
00:28 Changeset [74864] by abarth@webkit.org

2011-01-02 Adam Barth <abarth@webkit.org>

Speculative build fix for GTK. Add Source to the include paths.

  • GNUmakefile.am:
00:15 Changeset [74863] by abarth@webkit.org

2011-01-02 Carl Lobo <carllobo@gmail.com>

Reviewed by Adam Barth.

Fix Windows Build for non-production where VSPropsRedirectionDir is not defined.
https://bugs.webkit.org/show_bug.cgi?id=51797

01/01/11:

23:52 Changeset [74862] by abarth@webkit.org

2011-01-01 Adam Barth <abarth@webkit.org>

Speculative build fix for Qt. Add some more include paths.

  • WebKit2.pro:
23:42 Changeset [74861] by abarth@webkit.org

2011-01-01 Adam Barth <abarth@webkit.org>

Fix relative include paths in an attempt to fix the Qt build.

23:14 Changeset [74860] by abarth@webkit.org

2011-01-01 Adam Barth <abarth@webkit.org>

Another speculative build fix for GTK.

  • GNUmakefile.am:
23:09 Changeset [74859] by abarth@webkit.org

2011-01-01 Adam Barth <abarth@webkit.org>

Speculative build fix for GTK. Update the paths in GNUmakefile to
include "Source".

  • GNUmakefile.am:
22:46 Changeset [74858] by abarth@webkit.org

2011-01-01 Adam Barth <abarth@webkit.org>

Remove the assumption from the Qt and Gtk builds that every project is
in the root directory.

  • Scripts/build-webkit:
22:40 Changeset [74857] by abarth@webkit.org

2011-01-01 Adam Barth <abarth@webkit.org>

Update relative paths in JavaScriptCore.gyp to account for the extra
level of directories.

22:28 Changeset [74856] by abarth@webkit.org

2011-01-01 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Teach svn-apply how to apply patches even though JavaScriptCore has moved
https://bugs.webkit.org/show_bug.cgi?id=51796

After this change, svn-apply will magically apply patches to
JavaScriptCore/foo to Source/JavaScriptCore/foo.

  • Scripts/VCSUtils.pm:
22:22 Changeset [74855] by abarth@webkit.org

Move JavaScriptCore to Source
https://bugs.webkit.org/show_bug.cgi?id=51604

Reviewed by Eric Seidel.

Update references to JavaScriptCore to point to the new location.

  • Android.mk:
  • CMakeLists.txt:
  • DerivedSources.pro:
  • GNUmakefile.am:
  • Makefile:
  • WebKit.pri:
  • WebKit.pro:
  • wscript:

Tools:

Update references to JavaScriptCore to point to the new location.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:
  • DumpRenderTree/qt/DumpRenderTree.pro:
  • DumpRenderTree/qt/ImageDiff.pro:
  • DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
  • DumpRenderTree/wscript:
  • Scripts/build-jsc:
  • Scripts/build-webkit:
  • Scripts/do-file-rename:
  • Scripts/do-webcore-rename:
  • Scripts/run-javascriptcore-tests:
  • Scripts/update-javascriptcore-test-results:
  • Scripts/webkitdirs.pm:
  • Scripts/webkitpy/common/config/build_unittest.py:
  • Scripts/webkitpy/style/checker.py:
  • Scripts/webkitpy/style/checker_unittest.py:
  • Scripts/webkitpy/style/checkers/cpp_unittest.py:
  • WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
  • WebKitTestRunner/qt/WebKitTestRunner.pro:
  • wx/build/settings.py:

WebCore:

Update references to JavaScriptCore.

  • Android.derived.jscbindings.mk:
  • Android.v8bindings.mk:
  • CMakeLists.txt:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.pro:
    • These changes are subtle and might not be 100% correct.
  • move-js-headers.sh:

WebKit/chromium:

WebKit/gtk:

  • GNUmakefile.am:
  • docs/GNUmakefile.am:

WebKit/qt:

  • WebKit_pch.h:
  • docs/qtwebkit.qdocconf:

WebKit/win:

  • WebKit.vcproj/WebKit.sln:

WebKit/wx:

  • bindings/python/wscript:
  • wscript:

WebKit2:

Websites/bugs.webkit.org:

  • PrettyPatch/PrettyPatch.rb:

Websites/webkit.org:

  • coding/assertion-guidelines.html:
20:33 Changeset [74854] by abarth@webkit.org

2011-01-01 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

forbid sandboxed frames to call top.close() when allow-same-origin is not setted
https://bugs.webkit.org/show_bug.cgi?id=38340

We now pass the ScriptExecutionContext to window.close so it can find
the Frame and check whether navigation is allowed. This check will
almost always pass because you can only close top-level frames, but the
check will fail when the calling script is sandboxed.

Tests: fast/frames/sandboxed-iframe-close-top-noclose.html

fast/frames/sandboxed-iframe-close-top.html

  • page/DOMWindow.cpp: (WebCore::DOMWindow::close):
  • page/DOMWindow.h:
  • page/DOMWindow.idl:

2011-01-01 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

forbid sandboxed frames to call top.close() when allow-same-origin is not setted
https://bugs.webkit.org/show_bug.cgi?id=38340

Test the interaction between the HTML5 sandbox and window.close.

  • fast/frames/resources/close-top.html: Added.
  • fast/frames/resources/sandboxed-iframe-close-top-does-close.html: Added.
  • fast/frames/resources/sandboxed-iframe-close-top-does-not-close.html: Added.
  • fast/frames/sandboxed-iframe-close-top-expected.txt: Added.
  • fast/frames/sandboxed-iframe-close-top-noclose-expected.txt: Added.
  • fast/frames/sandboxed-iframe-close-top-noclose.html: Added.
  • fast/frames/sandboxed-iframe-close-top.html: Added.
18:28 Changeset [74853] by abarth@webkit.org

2011-01-01 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

sandbox iframes have access to top.history methods
https://bugs.webkit.org/show_bug.cgi?id=38152

To enforce the sandbox restrictions on History, we need to pass the
ScriptExecutionContext to WebCore. This patch leaves the original
History methods in place because they are used directly by folks who
don't care about security checks.

Test: fast/frames/sandboxed-iframe-history-denied.html

  • page/History.cpp: (WebCore::History::back): (WebCore::History::forward): (WebCore::History::go):
  • page/History.h:
  • page/History.idl:

2011-01-01 Justin Schuh <jschuh@chromium.org>

Reviewed by Eric Seidel.

sandbox iframes have access to top.history methods
https://bugs.webkit.org/show_bug.cgi?id=38152

Test that sandboxed iframes cannot use history to navigate the top
frame. This test is less than ideal, as described in the test itself.
If I was really on top of things, I'd add a test for successful use of
the history API when allow-top-navigation is set, but that test would
be complicated and I'm lazy (enough to copy directly from abarth).

  • fast/frames/sandboxed-iframe-history-denied-expected.txt: Added.
  • fast/frames/sandboxed-iframe-history-denied.html: Added.
18:04 Changeset [74852] by abarth@webkit.org

Move Sources to Source
https://bugs.webkit.org/show_bug.cgi?id=51794

Reviewed by Eric Seidel.

Update build files to point to the new location.

  • CMakeLists.txt:
  • GNUmakefile.am:
  • Makefile:
  • autogen.sh:
  • configure.ac:

Tools:

Update scripts to point to the new location.

  • Scripts/build-webkit:
  • Scripts/do-file-rename:
  • Scripts/do-webcore-rename:
  • Scripts/webkitpy/common/config/build.py:
  • Scripts/webkitpy/common/config/build_unittest.py:

Websites/bugs.webkit.org:

  • PrettyPatch/PrettyPatch.rb:
17:50 Changeset [74851] by abarth@webkit.org

2011-01-01 Adam Barth <abarth@webkit.org>

Remove empty file.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/DOMAllInOne.cpp:
  • dom/Entity.cpp: Removed.
17:43 Changeset [74850] by abarth@webkit.org

2011-01-01 Adam Barth <abarth@webkit.org>

Remove empty file.

  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/JSPopStateEventCustom.cpp: Removed.
17:37 Changeset [74849] by abarth@webkit.org

2011-01-01 Adam Barth <abarth@webkit.org>

Remove empty files.

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/generic/BindingFrame.h: Removed.
  • bindings/generic/BindingLocation.h: Removed.
16:35 Changeset [74848] by mitz@apple.com

Changed WebKit2.xcodeproj's svn:ignore property up to match other projects'

10:00 Changeset [74847] by commit-queue@webkit.org

2011-01-01 Konstantin Tokarev <annulen@yandex.ru>

Reviewed by Darin Adler.

Don't include Inspector headers when Inspector is disabled
https://bugs.webkit.org/show_bug.cgi?id=51789

  • bindings/js/JSDOMWindowBase.cpp: Include Inspector headers when Inspector is enabled
  • dom/Document.cpp: Include Inspector headers when Inspector is enabled (WebCore::Document::recalcStyle): Disabled InspectorInstrumentationCookie handling
  • html/HTMLDocument.cpp: Include Inspector headers when Inspector is enabled
  • loader/FrameLoader.cpp: Include Inspector headers when Inspector is enabled
  • loader/ResourceLoadNotifier.cpp: Include Inspector headers when Inspector is enabled
  • page/Chrome.cpp: Include Inspector headers when Inspector is enabled
  • page/Console.cpp: Include Inspector headers when Inspector is enabled
  • page/ContextMenuController.cpp: Include Inspector headers when Inspector is enabled
  • page/DOMWindow.cpp: Include Inspector headers when Inspector is enabled (WebCore::DOMWindow::dispatchEvent): Disabled InspectorInstrumentationCookie handling
  • page/EventHandler.cpp: Include Inspector headers when Inspector is enabled
  • page/Page.cpp: Include Inspector headers when Inspector is enabled
  • storage/Database.cpp: Include Inspector headers when Inspector is enabled
  • workers/AbstractWorker.cpp: Include Inspector headers when Inspector is enabled
  • workers/DefaultSharedWorkerRepository.cpp: Include Inspector headers when Inspector is enabled
  • workers/SharedWorker.cpp: Include Inspector headers when Inspector is enabled
  • workers/Worker.cpp: Include Inspector headers when Inspector is enabled
  • workers/WorkerContext.cpp: Include Inspector headers when Inspector is enabled
  • workers/WorkerMessagingProxy.cpp: Include Inspector headers when Inspector is enabled
  • xml/XMLHttpRequest.cpp: Include Inspector headers when Inspector is enabled (WebCore::XMLHttpRequest::callReadyStateChangeListener): Disabled InspectorInstrumentationCookie handling
03:01 Changeset [74846] by tkent@chromium.org

2011-01-01 Kent Tamura <tkent@chromium.org>

Unreviewed, test expectation update.

One more rebaseline for a spelling test, and remove passing tests from
test_expectations.txt.

  • platform/chromium-linux/editing/spelling/inline_spelling_markers-expected.checksum: Added.
  • platform/chromium-linux/editing/spelling/inline_spelling_markers-expected.png: Added.
  • platform/chromium-win/editing/spelling/inline_spelling_markers-expected.checksum: Added.
  • platform/chromium-win/editing/spelling/inline_spelling_markers-expected.png: Added.
  • platform/chromium-win/editing/spelling/inline_spelling_markers-expected.txt: Added.
  • platform/chromium/test_expectations.txt:

12/31/10:

22:54 Changeset [74845] by tkent@chromium.org

Unreviewed, test expectation update.

r74844 enabled spell checker on Chromium Linux and Chromium
Windows. So we need to update all of images with misspelled words.

  • platform/chromium-linux/editing/deleting/delete-3928305-fix-expected.checksum:
  • platform/chromium-linux/editing/deleting/delete-3928305-fix-expected.png:
  • platform/chromium-linux/editing/deleting/delete-3959464-fix-expected.checksum:
  • platform/chromium-linux/editing/deleting/delete-3959464-fix-expected.png:
  • platform/chromium-linux/editing/deleting/delete-and-undo-expected.checksum:
  • platform/chromium-linux/editing/deleting/delete-and-undo-expected.png:
  • platform/chromium-linux/editing/deleting/delete-block-contents-003-expected.checksum:
  • platform/chromium-linux/editing/deleting/delete-block-contents-003-expected.png:
  • platform/chromium-linux/editing/deleting/delete-contiguous-ws-001-expected.checksum:
  • platform/chromium-linux/editing/deleting/delete-contiguous-ws-001-expected.png:
  • platform/chromium-linux/editing/deleting/delete-tab-002-expected.checksum:
  • platform/chromium-linux/editing/deleting/delete-tab-002-expected.png:
  • platform/chromium-linux/editing/deleting/delete-tab-003-expected.checksum:
  • platform/chromium-linux/editing/deleting/delete-tab-003-expected.png:
  • platform/chromium-linux/editing/deleting/delete-to-select-table-expected.checksum:
  • platform/chromium-linux/editing/deleting/delete-to-select-table-expected.png:
  • platform/chromium-linux/editing/deleting/delete-trailing-ws-002-expected.checksum:
  • platform/chromium-linux/editing/deleting/delete-trailing-ws-002-expected.png:
  • platform/chromium-linux/editing/deleting/delete-ws-fixup-001-expected.checksum:
  • platform/chromium-linux/editing/deleting/delete-ws-fixup-001-expected.png:
  • platform/chromium-linux/editing/deleting/delete-ws-fixup-002-expected.checksum:
  • platform/chromium-linux/editing/deleting/delete-ws-fixup-002-expected.png:
  • platform/chromium-linux/editing/execCommand/5569741-expected.checksum:
  • platform/chromium-linux/editing/execCommand/5569741-expected.png:
  • platform/chromium-linux/editing/execCommand/insert-list-and-stitch-expected.checksum:
  • platform/chromium-linux/editing/execCommand/insert-list-and-stitch-expected.png:
  • platform/chromium-linux/editing/execCommand/insertHorizontalRule-expected.checksum:
  • platform/chromium-linux/editing/execCommand/insertHorizontalRule-expected.png:
  • platform/chromium-linux/editing/execCommand/outdent-selection-expected.checksum:
  • platform/chromium-linux/editing/execCommand/outdent-selection-expected.png:
  • platform/chromium-linux/editing/inserting/5418891-expected.checksum:
  • platform/chromium-linux/editing/inserting/5418891-expected.png:
  • platform/chromium-linux/editing/inserting/editing-empty-divs-expected.checksum:
  • platform/chromium-linux/editing/inserting/editing-empty-divs-expected.png:
  • platform/chromium-linux/editing/inserting/insert-3907422-fix-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-3907422-fix-expected.png:
  • platform/chromium-linux/editing/inserting/insert-br-004-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-br-004-expected.png:
  • platform/chromium-linux/editing/inserting/insert-br-005-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-br-005-expected.png:
  • platform/chromium-linux/editing/inserting/insert-br-007-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-br-007-expected.png:
  • platform/chromium-linux/editing/inserting/insert-div-007-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-div-007-expected.png:
  • platform/chromium-linux/editing/inserting/insert-div-012-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-div-012-expected.png:
  • platform/chromium-linux/editing/inserting/insert-div-013-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-div-013-expected.png:
  • platform/chromium-linux/editing/inserting/insert-div-014-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-div-014-expected.png:
  • platform/chromium-linux/editing/inserting/insert-div-015-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-div-015-expected.png:
  • platform/chromium-linux/editing/inserting/insert-div-016-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-div-016-expected.png:
  • platform/chromium-linux/editing/inserting/insert-div-017-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-div-017-expected.png:
  • platform/chromium-linux/editing/inserting/insert-div-018-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-div-018-expected.png:
  • platform/chromium-linux/editing/inserting/insert-div-019-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-div-019-expected.png:
  • platform/chromium-linux/editing/inserting/insert-div-020-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-div-020-expected.png:
  • platform/chromium-linux/editing/inserting/insert-div-021-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-div-021-expected.png:
  • platform/chromium-linux/editing/inserting/insert-div-022-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-div-022-expected.png:
  • platform/chromium-linux/editing/inserting/insert-div-025-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-div-025-expected.png:
  • platform/chromium-linux/editing/inserting/insert-div-027-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-div-027-expected.png:
  • platform/chromium-linux/editing/inserting/insert-paragraph-02-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-paragraph-02-expected.png:
  • platform/chromium-linux/editing/inserting/insert-paragraph-03-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-paragraph-03-expected.png:
  • platform/chromium-linux/editing/inserting/insert-tab-002-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-tab-002-expected.png:
  • platform/chromium-linux/editing/inserting/insert-tab-003-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-tab-003-expected.png:
  • platform/chromium-linux/editing/inserting/insert-text-with-newlines-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-text-with-newlines-expected.png:
  • platform/chromium-linux/editing/inserting/paragraph-separator-01-expected.checksum:
  • platform/chromium-linux/editing/inserting/paragraph-separator-01-expected.png:
  • platform/chromium-linux/editing/inserting/paragraph-separator-02-expected.checksum:
  • platform/chromium-linux/editing/inserting/paragraph-separator-02-expected.png:
  • platform/chromium-linux/editing/inserting/paragraph-separator-03-expected.checksum:
  • platform/chromium-linux/editing/inserting/paragraph-separator-03-expected.png:
  • platform/chromium-linux/editing/inserting/return-key-with-selection-001-expected.checksum:
  • platform/chromium-linux/editing/inserting/return-key-with-selection-001-expected.png:
  • platform/chromium-linux/editing/inserting/return-key-with-selection-002-expected.checksum:
  • platform/chromium-linux/editing/inserting/return-key-with-selection-002-expected.png:
  • platform/chromium-linux/editing/inserting/return-key-with-selection-003-expected.checksum:
  • platform/chromium-linux/editing/inserting/return-key-with-selection-003-expected.png:
  • platform/chromium-linux/editing/inserting/typing-002-expected.checksum:
  • platform/chromium-linux/editing/inserting/typing-002-expected.png:
  • platform/chromium-linux/editing/inserting/typing-around-br-001-expected.checksum:
  • platform/chromium-linux/editing/inserting/typing-around-br-001-expected.png:
  • platform/chromium-linux/editing/pasteboard/4242293-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/4242293-expected.png:
  • platform/chromium-linux/editing/pasteboard/4944770-1-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/4944770-1-expected.png:
  • platform/chromium-linux/editing/pasteboard/8145-2-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/8145-2-expected.png:
  • platform/chromium-linux/editing/pasteboard/cut-text-001-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/cut-text-001-expected.png:
  • platform/chromium-linux/editing/pasteboard/interchange-newline-1-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/interchange-newline-1-expected.png:
  • platform/chromium-linux/editing/pasteboard/merge-after-delete-1-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/merge-after-delete-1-expected.png:
  • platform/chromium-linux/editing/pasteboard/merge-after-delete-2-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/merge-after-delete-2-expected.png:
  • platform/chromium-linux/editing/pasteboard/merge-after-delete-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/merge-after-delete-expected.png:
  • platform/chromium-linux/editing/pasteboard/merge-end-4-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/merge-end-4-expected.png:
  • platform/chromium-linux/editing/pasteboard/merge-end-blockquote-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/merge-end-blockquote-expected.png:
  • platform/chromium-linux/editing/pasteboard/merge-end-list-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/merge-end-list-expected.png:
  • platform/chromium-linux/editing/pasteboard/merge-end-table-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/merge-end-table-expected.png:
  • platform/chromium-linux/editing/pasteboard/paste-blockquote-3-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/paste-blockquote-3-expected.png:
  • platform/chromium-linux/editing/pasteboard/paste-text-001-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/paste-text-001-expected.png:
  • platform/chromium-linux/editing/pasteboard/paste-text-012-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/paste-text-012-expected.png:
  • platform/chromium-linux/editing/pasteboard/paste-text-013-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/paste-text-013-expected.png:
  • platform/chromium-linux/editing/pasteboard/paste-text-014-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/paste-text-014-expected.png:
  • platform/chromium-linux/editing/pasteboard/paste-text-019-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/paste-text-019-expected.png:
  • platform/chromium-linux/editing/pasteboard/paste-xml-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/paste-xml-expected.png:
  • platform/chromium-linux/editing/pasteboard/undoable-fragment-removes-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/undoable-fragment-removes-expected.png:
  • platform/chromium-linux/editing/selection/13804-expected.checksum:
  • platform/chromium-linux/editing/selection/13804-expected.png:
  • platform/chromium-linux/editing/selection/5234383-1-expected.checksum:
  • platform/chromium-linux/editing/selection/5234383-1-expected.png:
  • platform/chromium-linux/editing/selection/5234383-2-expected.checksum:
  • platform/chromium-linux/editing/selection/5234383-2-expected.png:
  • platform/chromium-linux/editing/selection/extend-by-word-001-expected.checksum:
  • platform/chromium-linux/editing/selection/extend-by-word-001-expected.png:
  • platform/chromium-linux/editing/selection/move-backwords-by-word-001-expected.checksum:
  • platform/chromium-linux/editing/selection/move-backwords-by-word-001-expected.png:
  • platform/chromium-linux/editing/selection/move-by-character-001-expected.checksum:
  • platform/chromium-linux/editing/selection/move-by-character-001-expected.png:
  • platform/chromium-linux/editing/selection/move-by-line-001-expected.checksum:
  • platform/chromium-linux/editing/selection/move-by-line-001-expected.png:
  • platform/chromium-linux/editing/selection/move-by-word-001-expected.checksum:
  • platform/chromium-linux/editing/selection/move-by-word-001-expected.png:
  • platform/chromium-linux/editing/selection/select-from-textfield-outwards-expected.checksum:
  • platform/chromium-linux/editing/selection/select-from-textfield-outwards-expected.png:
  • platform/chromium-linux/editing/selection/unrendered-002-expected.checksum:
  • platform/chromium-linux/editing/selection/unrendered-002-expected.png:
  • platform/chromium-linux/editing/spelling/spelling-expected.checksum:
  • platform/chromium-linux/editing/spelling/spelling-expected.png:
  • platform/chromium-linux/editing/style/5046875-2-expected.checksum:
  • platform/chromium-linux/editing/style/5046875-2-expected.png:
  • platform/chromium-linux/editing/style/block-styles-007-expected.checksum:
  • platform/chromium-linux/editing/style/block-styles-007-expected.png:
  • platform/chromium-linux/editing/style/create-block-for-style-002-expected.checksum:
  • platform/chromium-linux/editing/style/create-block-for-style-002-expected.png:
  • platform/chromium-linux/editing/style/create-block-for-style-003-expected.checksum:
  • platform/chromium-linux/editing/style/create-block-for-style-003-expected.png:
  • platform/chromium-linux/editing/style/create-block-for-style-004-expected.checksum:
  • platform/chromium-linux/editing/style/create-block-for-style-004-expected.png:
  • platform/chromium-linux/editing/style/create-block-for-style-006-expected.checksum:
  • platform/chromium-linux/editing/style/create-block-for-style-006-expected.png:
  • platform/chromium-linux/editing/style/create-block-for-style-008-expected.checksum:
  • platform/chromium-linux/editing/style/create-block-for-style-008-expected.png:
  • platform/chromium-linux/editing/style/create-block-for-style-009-expected.checksum:
  • platform/chromium-linux/editing/style/create-block-for-style-009-expected.png:
  • platform/chromium-linux/editing/style/create-block-for-style-011-expected.checksum:
  • platform/chromium-linux/editing/style/create-block-for-style-011-expected.png:
  • platform/chromium-linux/editing/style/create-block-for-style-012-expected.checksum:
  • platform/chromium-linux/editing/style/create-block-for-style-012-expected.png:
  • platform/chromium-linux/editing/style/create-block-for-style-013-expected.checksum:
  • platform/chromium-linux/editing/style/create-block-for-style-013-expected.png:
  • platform/chromium-linux/fast/dom/blur-contenteditable-expected.checksum:
  • platform/chromium-linux/fast/dom/blur-contenteditable-expected.png:
  • platform/chromium-win/editing/deleting/delete-3928305-fix-expected.checksum:
  • platform/chromium-win/editing/deleting/delete-3928305-fix-expected.png:
  • platform/chromium-win/editing/deleting/delete-3959464-fix-expected.checksum:
  • platform/chromium-win/editing/deleting/delete-3959464-fix-expected.png:
  • platform/chromium-win/editing/deleting/delete-and-undo-expected.checksum:
  • platform/chromium-win/editing/deleting/delete-and-undo-expected.png:
  • platform/chromium-win/editing/deleting/delete-block-contents-003-expected.checksum:
  • platform/chromium-win/editing/deleting/delete-block-contents-003-expected.png:
  • platform/chromium-win/editing/deleting/delete-contiguous-ws-001-expected.checksum:
  • platform/chromium-win/editing/deleting/delete-contiguous-ws-001-expected.png:
  • platform/chromium-win/editing/deleting/delete-tab-002-expected.checksum:
  • platform/chromium-win/editing/deleting/delete-tab-002-expected.png:
  • platform/chromium-win/editing/deleting/delete-tab-003-expected.checksum:
  • platform/chromium-win/editing/deleting/delete-tab-003-expected.png:
  • platform/chromium-win/editing/deleting/delete-to-select-table-expected.checksum:
  • platform/chromium-win/editing/deleting/delete-to-select-table-expected.png:
  • platform/chromium-win/editing/deleting/delete-trailing-ws-002-expected.checksum:
  • platform/chromium-win/editing/deleting/delete-trailing-ws-002-expected.png:
  • platform/chromium-win/editing/deleting/delete-ws-fixup-001-expected.checksum:
  • platform/chromium-win/editing/deleting/delete-ws-fixup-001-expected.png:
  • platform/chromium-win/editing/deleting/delete-ws-fixup-002-expected.checksum:
  • platform/chromium-win/editing/deleting/delete-ws-fixup-002-expected.png:
  • platform/chromium-win/editing/deleting/smart-delete-002-expected.checksum:
  • platform/chromium-win/editing/deleting/smart-delete-002-expected.png:
  • platform/chromium-win/editing/deleting/smart-delete-003-expected.checksum:
  • platform/chromium-win/editing/deleting/smart-delete-003-expected.png:
  • platform/chromium-win/editing/deleting/smart-delete-004-expected.checksum:
  • platform/chromium-win/editing/deleting/smart-delete-004-expected.png:
  • platform/chromium-win/editing/execCommand/5569741-expected.checksum:
  • platform/chromium-win/editing/execCommand/5569741-expected.png:
  • platform/chromium-win/editing/execCommand/insert-list-and-stitch-expected.checksum:
  • platform/chromium-win/editing/execCommand/insert-list-and-stitch-expected.png:
  • platform/chromium-win/editing/execCommand/insertHorizontalRule-expected.checksum:
  • platform/chromium-win/editing/execCommand/insertHorizontalRule-expected.png:
  • platform/chromium-win/editing/execCommand/outdent-selection-expected.checksum:
  • platform/chromium-win/editing/execCommand/outdent-selection-expected.png:
  • platform/chromium-win/editing/inserting/5418891-expected.checksum:
  • platform/chromium-win/editing/inserting/5418891-expected.png:
  • platform/chromium-win/editing/inserting/editing-empty-divs-expected.checksum:
  • platform/chromium-win/editing/inserting/editing-empty-divs-expected.png:
  • platform/chromium-win/editing/inserting/insert-3907422-fix-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-3907422-fix-expected.png:
  • platform/chromium-win/editing/inserting/insert-br-004-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-br-004-expected.png:
  • platform/chromium-win/editing/inserting/insert-br-005-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-br-005-expected.png:
  • platform/chromium-win/editing/inserting/insert-br-007-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-br-007-expected.png:
  • platform/chromium-win/editing/inserting/insert-div-007-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-div-007-expected.png:
  • platform/chromium-win/editing/inserting/insert-div-012-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-div-012-expected.png:
  • platform/chromium-win/editing/inserting/insert-div-013-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-div-013-expected.png:
  • platform/chromium-win/editing/inserting/insert-div-014-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-div-014-expected.png:
  • platform/chromium-win/editing/inserting/insert-div-015-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-div-015-expected.png:
  • platform/chromium-win/editing/inserting/insert-div-016-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-div-016-expected.png:
  • platform/chromium-win/editing/inserting/insert-div-017-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-div-017-expected.png:
  • platform/chromium-win/editing/inserting/insert-div-018-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-div-018-expected.png:
  • platform/chromium-win/editing/inserting/insert-div-019-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-div-019-expected.png:
  • platform/chromium-win/editing/inserting/insert-div-020-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-div-020-expected.png:
  • platform/chromium-win/editing/inserting/insert-div-021-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-div-021-expected.png:
  • platform/chromium-win/editing/inserting/insert-div-022-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-div-022-expected.png:
  • platform/chromium-win/editing/inserting/insert-div-025-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-div-025-expected.png:
  • platform/chromium-win/editing/inserting/insert-div-027-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-div-027-expected.png:
  • platform/chromium-win/editing/inserting/insert-paragraph-02-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-paragraph-02-expected.png:
  • platform/chromium-win/editing/inserting/insert-paragraph-03-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-paragraph-03-expected.png:
  • platform/chromium-win/editing/inserting/insert-tab-002-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-tab-002-expected.png:
  • platform/chromium-win/editing/inserting/insert-tab-003-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-tab-003-expected.png:
  • platform/chromium-win/editing/inserting/insert-text-with-newlines-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-text-with-newlines-expected.png:
  • platform/chromium-win/editing/inserting/paragraph-separator-01-expected.checksum:
  • platform/chromium-win/editing/inserting/paragraph-separator-01-expected.png:
  • platform/chromium-win/editing/inserting/paragraph-separator-02-expected.checksum:
  • platform/chromium-win/editing/inserting/paragraph-separator-02-expected.png:
  • platform/chromium-win/editing/inserting/paragraph-separator-03-expected.checksum:
  • platform/chromium-win/editing/inserting/paragraph-separator-03-expected.png:
  • platform/chromium-win/editing/inserting/return-key-with-selection-001-expected.checksum:
  • platform/chromium-win/editing/inserting/return-key-with-selection-001-expected.png:
  • platform/chromium-win/editing/inserting/return-key-with-selection-002-expected.checksum:
  • platform/chromium-win/editing/inserting/return-key-with-selection-002-expected.png:
  • platform/chromium-win/editing/inserting/return-key-with-selection-003-expected.checksum:
  • platform/chromium-win/editing/inserting/return-key-with-selection-003-expected.png:
  • platform/chromium-win/editing/inserting/typing-002-expected.checksum:
  • platform/chromium-win/editing/inserting/typing-002-expected.png:
  • platform/chromium-win/editing/inserting/typing-around-br-001-expected.checksum:
  • platform/chromium-win/editing/inserting/typing-around-br-001-expected.png:
  • platform/chromium-win/editing/pasteboard/4242293-expected.checksum:
  • platform/chromium-win/editing/pasteboard/4242293-expected.png:
  • platform/chromium-win/editing/pasteboard/4944770-1-expected.checksum:
  • platform/chromium-win/editing/pasteboard/4944770-1-expected.png:
  • platform/chromium-win/editing/pasteboard/8145-2-expected.checksum:
  • platform/chromium-win/editing/pasteboard/8145-2-expected.png:
  • platform/chromium-win/editing/pasteboard/cut-text-001-expected.checksum:
  • platform/chromium-win/editing/pasteboard/cut-text-001-expected.png:
  • platform/chromium-win/editing/pasteboard/interchange-newline-1-expected.checksum:
  • platform/chromium-win/editing/pasteboard/interchange-newline-1-expected.png:
  • platform/chromium-win/editing/pasteboard/merge-after-delete-1-expected.checksum:
  • platform/chromium-win/editing/pasteboard/merge-after-delete-1-expected.png:
  • platform/chromium-win/editing/pasteboard/merge-after-delete-2-expected.checksum:
  • platform/chromium-win/editing/pasteboard/merge-after-delete-2-expected.png:
  • platform/chromium-win/editing/pasteboard/merge-after-delete-expected.checksum:
  • platform/chromium-win/editing/pasteboard/merge-after-delete-expected.png:
  • platform/chromium-win/editing/pasteboard/merge-end-4-expected.checksum:
  • platform/chromium-win/editing/pasteboard/merge-end-4-expected.png:
  • platform/chromium-win/editing/pasteboard/merge-end-blockquote-expected.checksum:
  • platform/chromium-win/editing/pasteboard/merge-end-blockquote-expected.png:
  • platform/chromium-win/editing/pasteboard/merge-end-list-expected.checksum:
  • platform/chromium-win/editing/pasteboard/merge-end-list-expected.png:
  • platform/chromium-win/editing/pasteboard/merge-end-table-expected.checksum:
  • platform/chromium-win/editing/pasteboard/merge-end-table-expected.png:
  • platform/chromium-win/editing/pasteboard/paste-blockquote-3-expected.checksum:
  • platform/chromium-win/editing/pasteboard/paste-blockquote-3-expected.png:
  • platform/chromium-win/editing/pasteboard/paste-text-001-expected.checksum:
  • platform/chromium-win/editing/pasteboard/paste-text-001-expected.png:
  • platform/chromium-win/editing/pasteboard/paste-text-012-expected.checksum:
  • platform/chromium-win/editing/pasteboard/paste-text-012-expected.png:
  • platform/chromium-win/editing/pasteboard/paste-text-013-expected.checksum:
  • platform/chromium-win/editing/pasteboard/paste-text-013-expected.png:
  • platform/chromium-win/editing/pasteboard/paste-text-014-expected.checksum:
  • platform/chromium-win/editing/pasteboard/paste-text-014-expected.png:
  • platform/chromium-win/editing/pasteboard/paste-text-019-expected.checksum:
  • platform/chromium-win/editing/pasteboard/paste-text-019-expected.png:
  • platform/chromium-win/editing/pasteboard/paste-xml-expected.checksum:
  • platform/chromium-win/editing/pasteboard/paste-xml-expected.png:
  • platform/chromium-win/editing/pasteboard/undoable-fragment-removes-expected.checksum:
  • platform/chromium-win/editing/pasteboard/undoable-fragment-removes-expected.png:
  • platform/chromium-win/editing/selection/13804-expected.checksum:
  • platform/chromium-win/editing/selection/13804-expected.png:
  • platform/chromium-win/editing/selection/5234383-1-expected.checksum:
  • platform/chromium-win/editing/selection/5234383-1-expected.png:
  • platform/chromium-win/editing/selection/5234383-2-expected.checksum:
  • platform/chromium-win/editing/selection/5234383-2-expected.png:
  • platform/chromium-win/editing/selection/extend-by-word-001-expected.checksum:
  • platform/chromium-win/editing/selection/extend-by-word-001-expected.png:
  • platform/chromium-win/editing/selection/move-backwords-by-word-001-expected.checksum:
  • platform/chromium-win/editing/selection/move-backwords-by-word-001-expected.png:
  • platform/chromium-win/editing/selection/move-by-character-001-expected.checksum:
  • platform/chromium-win/editing/selection/move-by-character-001-expected.png:
  • platform/chromium-win/editing/selection/move-by-line-001-expected.checksum:
  • platform/chromium-win/editing/selection/move-by-line-001-expected.png:
  • platform/chromium-win/editing/selection/move-by-word-001-expected.checksum:
  • platform/chromium-win/editing/selection/move-by-word-001-expected.png:
  • platform/chromium-win/editing/selection/select-from-textfield-outwards-expected.checksum:
  • platform/chromium-win/editing/selection/select-from-textfield-outwards-expected.png:
  • platform/chromium-win/editing/selection/unrendered-002-expected.checksum:
  • platform/chromium-win/editing/selection/unrendered-002-expected.png:
  • platform/chromium-win/editing/spelling/spelling-expected.checksum:
  • platform/chromium-win/editing/spelling/spelling-expected.png:
  • platform/chromium-win/editing/style/5046875-2-expected.checksum:
  • platform/chromium-win/editing/style/5046875-2-expected.png:
  • platform/chromium-win/editing/style/block-styles-007-expected.checksum:
  • platform/chromium-win/editing/style/block-styles-007-expected.png:
  • platform/chromium-win/editing/style/create-block-for-style-002-expected.checksum:
  • platform/chromium-win/editing/style/create-block-for-style-002-expected.png:
  • platform/chromium-win/editing/style/create-block-for-style-003-expected.checksum:
  • platform/chromium-win/editing/style/create-block-for-style-003-expected.png:
  • platform/chromium-win/editing/style/create-block-for-style-004-expected.checksum:
  • platform/chromium-win/editing/style/create-block-for-style-004-expected.png:
  • platform/chromium-win/editing/style/create-block-for-style-006-expected.checksum:
  • platform/chromium-win/editing/style/create-block-for-style-006-expected.png:
  • platform/chromium-win/editing/style/create-block-for-style-008-expected.checksum:
  • platform/chromium-win/editing/style/create-block-for-style-008-expected.png:
  • platform/chromium-win/editing/style/create-block-for-style-009-expected.checksum:
  • platform/chromium-win/editing/style/create-block-for-style-009-expected.png:
  • platform/chromium-win/editing/style/create-block-for-style-011-expected.checksum:
  • platform/chromium-win/editing/style/create-block-for-style-011-expected.png:
  • platform/chromium-win/editing/style/create-block-for-style-012-expected.checksum:
  • platform/chromium-win/editing/style/create-block-for-style-012-expected.png:
  • platform/chromium-win/editing/style/create-block-for-style-013-expected.checksum:
  • platform/chromium-win/editing/style/create-block-for-style-013-expected.png:
  • platform/chromium-win/fast/dom/blur-contenteditable-expected.checksum:
  • platform/chromium-win/fast/dom/blur-contenteditable-expected.png:
22:06 Changeset [74844] by tkent@chromium.org

2010-12-31 Kent Tamura <tkent@chromium.org>

Reviewed by Eric Seidel.

[DRT/Chromium] Enable mock spell checker on non-OSX
https://bugs.webkit.org/show_bug.cgi?id=51401

  • DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::spellCheck):
18:38 Changeset [74843] by abarth@webkit.org

2010-12-31 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

fast/loader/about-blank-hash-change.html fails on Chromium
https://bugs.webkit.org/show_bug.cgi?id=51788

I'm unable to reproduce the failure locally, so this patch is slightly
speculative. We need to be slighly more careful how we compare the
fragment identifiers for Chromium because Chromium uses a URL parser
that is more agressive about canonicalization.

  • page/Location.cpp: (WebCore::Location::setHash):
18:17 Changeset [74842] by mrobinson@webkit.org

2010-12-31 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Use GLib/GIO API for FileSystemGtk implementation
https://bugs.webkit.org/show_bug.cgi?id=51617

Complete implementation of FileSystem platform code for GLib. This
converts remaining API points using POSIX calls to platform-independent
GLib calls and fixes other compilation errors.

No new tests. This code will be tested when an implementation
of beginDragWithFiles is complete.

(WebCore::JSDirectoryEntry::getFile):
(WebCore::JSDirectoryEntry::getDirectory):

  • platform/FileSystem.h: Added forward declarations for GLib types to avoid GLib includes and changed the PlatformFileHandle to be a GIOStream.
  • platform/gtk/FileSystemGtk.cpp: (WebCore::openTemporaryFile): Reimplement using only GLib calls. (WebCore::openFile): Ditto. (WebCore::closeFile): Ditto. (WebCore::seekFile): Added implementation. (WebCore::writeToFile): Reimplement using only GLib calls. (WebCore::readFromFile): Ditto.
16:58 Changeset [74841] by darin@apple.com

2010-12-31 Darin Adler <darin@apple.com>

Reviewed by Dan Bernstein.

Some renaming and refactoring of form element code
https://bugs.webkit.org/show_bug.cgi?id=51784

  • bindings/js/JSHTMLSelectElementCustom.cpp: (WebCore::JSHTMLSelectElement::remove): Call new overload of remove for option elements instead of putting the logic in the binding.
  • html/HTMLButtonElement.cpp: (WebCore::HTMLButtonElement::HTMLButtonElement): Updated for name changes. (WebCore::HTMLButtonElement::defaultEventHandler): Renamed argument to "event" instead of "evt". Also updated for name changes. (WebCore::HTMLButtonElement::isActivatedSubmit): Ditto. (WebCore::HTMLButtonElement::setActivatedSubmit): Ditto. (WebCore::HTMLButtonElement::appendFormData): Ditto.
  • html/HTMLButtonElement.h: Renamed m_activeSubmit to m_isActivatedSubmit to match the getter function name. The name still doesn't seem great.
  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::HTMLFormElement): Updated for name changes. (WebCore::HTMLFormElement::~HTMLFormElement): Use autoComplete function instead of m_autocomplete data member. (WebCore::HTMLFormElement::rendererIsNeeded): Use m_wasDemoted data member instead of otherwise-unused isDemoted function. (WebCore::HTMLFormElement::submitImplicitly): Updated for name changes. (WebCore::HTMLFormElement::validateInteractively): Removed code to clear m_insubmit. This is now handled by the caller, prepareForSubmission. (WebCore::HTMLFormElement::prepareForSubmission): Renamed. Updated for name changes. Moved code to clear m_isSubmittingOrPreparingForSubmission here from validateInteractively. Removed unneeded check of m_doingsubmit boolean before setting it. (WebCore::HTMLFormElement::submit): Factored this function into two. One for JavaScript and one for non-JavaScript. Neither function needs a frame argument, because the question being asked, anyPageIsProcessingUserGesture, is a question asked of an entire page group, not a specific frame or page, so it's not important which is the active frame. (WebCore::HTMLFormElement::submitFromJavaScript): Ditto. (WebCore::HTMLFormElement::reset): Updated for name changes. (WebCore::HTMLFormElement::parseMappedAttribute): Removed code to parse acceptAttr and got rid of code to set m_autocomplete. (WebCore::HTMLFormElement::elementForAlias): Changed return type to a raw pointer. (WebCore::HTMLFormElement::getNamedElements): Updated to use raw pointer and the vector find function. Added a FIXME about the comment. (WebCore::HTMLFormElement::documentDidBecomeActive): Use autoComplete function instead of m_autocomplete data member. (WebCore::HTMLFormElement::willMoveToNewOwnerDocument): Ditto. (WebCore::HTMLFormElement::didMoveToNewOwnerDocument): Ditto. (WebCore::HTMLFormElement::autoComplete): Ditto.
  • html/HTMLFormElement.h: Added a FIXME about renaming the autoComplete function. Renamed prepareSubmit to prepareForSubmission. Got rid of the frame argument from the submit function and added a new submitFromJavaScript variant. Removed the unneeded isDemoted function. Changed the return type of elementForAlias to a raw pointer. Removed m_autocomplete. Renamed m_insubmit to m_isSubmittingOrPreparingForSubmission, m_doingsubmit to m_shouldSubmit, m_inreset to m_inResetFunction, m_malformed to m_wasMalformed, m_demoted to m_wasDemoted. Use plain bool instead of bitfields.
  • html/HTMLFormElement.idl: Use the function named submitFromJavaScript instead of using CallWith=DynamicFrame because we don't need to know what frame is calling. If we did, it's not clear that the "dynamic" frame would be the right one anyway.
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::remove): Added an overload that takes an option element, since the JavaScript binding supports this.
  • html/HTMLSelectElement.h: Ditto.
  • html/ImageInputType.cpp: (WebCore::ImageInputType::handleDOMActivateEvent): Updated for name changes.
  • html/ImageInputType.h: Ditto.
  • html/SubmitInputType.cpp: (WebCore::SubmitInputType::handleDOMActivateEvent): Ditto.
16:48 Changeset [74840] by jberlin@webkit.org

The correct temporary fix for media/video-element-other-namespace-crash.html timing out on
the Windows 7 Release Test bots is to add it to the Windows skipped list.

Unreviewed.

https://bugs.webkit.org/show_bug.cgi?id=51787

  • platform/win/Skipped:
  • platform/win/media/video-element-other-namespace-crash-expected.txt: Removed.
16:36 Changeset [74839] by dbates@webkit.org

2010-12-31 Daniel Bates <dbates@rim.com>

Reviewed by Darin Adler.

Pass style for <area> instead of associated <img> when querying whether
the theme draws the focus ring for an <area>
https://bugs.webkit.org/show_bug.cgi?id=51632

Fixes an issue where the style for the associated <img> of an <area>
was passed when considering whether the theme should draw a focus ring
for the <area>. Instead, we should pass the theme the style for the <area>.

It's not possible to test this at this time since there are no themes
that override focus ring drawing for <area>s.

  • rendering/RenderImage.cpp: (WebCore::RenderImage::paintFocusRing): Moved call to RenderTheme::supportsFocusRing() such that it's called with respect to the focused <area>.
14:46 Changeset [74838] by abarth@webkit.org

2010-12-31 Adam Barth <abarth@webkit.org>

Update SVN ignore property to hide two more external dependencies.

  • chromium: Modified property svn:ignore.
14:10 Changeset [74837] by jberlin@webkit.org

Add Windows-specific (failing) expected results for
media/video-element-other-namespace-crash.html in order to get the Windows 7 Release test bot green again.
Unreviewed.
https://bugs.webkit.org/show_bug.cgi?id=51787

  • platform/win/media/video-element-other-namespace-crash-expected.txt: Added.
13:45 Changeset [74836] by jberlin@webkit.org

Add Windows-specific (failing) expected results for
svg/dom/length-list-parser.html in order to get the Windows 7 Release test bot green again.
Unreviewed.
https://bugs.webkit.org/show_bug.cgi?id=51786

  • platform/win/svg/dom: Added.
  • platform/win/svg/dom/length-list-parser-expected.txt: Added.
12:36 Changeset [74835] by abarth@webkit.org

2010-12-31 Adam Barth <abarth@webkit.org>

Remove custom Chromium expectation for invalid-protocol. Now that we
share more code with JavaScriptCore, we throw exactly the same
exception and therefore can share results.

  • platform/chromium/fast/dom/Window/invalid-protocol-expected.txt: Removed.
12:12 Changeset [74834] by darin@apple.com
  • WebCore.xcodeproj/project.pbxproj: Added back the language.

Developers should be using Xcode 3.2.5 or newer.

11:56 Changeset [74833] by abarth@webkit.org

2010-12-31 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Move V8 to WebCore Location implementation
https://bugs.webkit.org/show_bug.cgi?id=51768

  • bindings/generic/BindingFrame.h:
  • bindings/generic/BindingLocation.h:
  • bindings/v8/V8Binding.h:
  • bindings/v8/V8DOMWindowShell.cpp: (WebCore::V8DOMWindowShell::setLocation):
  • bindings/v8/V8Utilities.cpp:
  • bindings/v8/V8Utilities.h:
  • bindings/v8/custom/V8LocationCustom.cpp: (WebCore::V8Location::hashAccessorSetter): (WebCore::V8Location::hostAccessorSetter): (WebCore::V8Location::hostnameAccessorSetter): (WebCore::V8Location::hrefAccessorSetter): (WebCore::V8Location::pathnameAccessorSetter): (WebCore::V8Location::portAccessorSetter): (WebCore::V8Location::protocolAccessorSetter): (WebCore::V8Location::searchAccessorSetter): (WebCore::V8Location::reloadCallback): (WebCore::V8Location::replaceCallback): (WebCore::V8Location::assignCallback):
09:58 Changeset [74832] by commit-queue@webkit.org

2010-12-31 Yi Shen <yi.4.shen@nokia.com>

Reviewed by Eric Seidel.

Make retrieving extraMediaControlsStyleSheet be page dependent.
https://bugs.webkit.org/show_bug.cgi?id=51752

Use themeForPage to retrieve extraMediaControlsStyleSheet for media
controls.

No new tests because no platform-specific theme implementation uses
the passed page pointer yet.

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::styleForElement):
08:11 Changeset [74831] by abarth@webkit.org

2010-12-31 Adam Barth <abarth@webkit.org>

Reviewed by Ariya Hidayat.

Remove Tools/Scripts/wkstyle
https://bugs.webkit.org/show_bug.cgi?id=51774

This script appears to not have been touched in a while and seems to
have been replaced by check-webkit-style.

  • Scripts/wkstyle: Removed.
05:02 Changeset [74830] by loislo@chromium.org

2010-12-31 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [REGRESSION] WebInspector.ResourcesPanel.prototype.canShowSourceLine() broken.

https://bugs.webkit.org/show_bug.cgi?id=51709

  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.canShowSourceLine):
04:43 Changeset [74829] by paroga@webkit.org

2010-12-31 Patrick Gansterer <paroga@webkit.org>

Reviewed by Darin Adler.

Add a fast case for ASCII strings in HashAndUTF8CharactersTranslator::equal
https://bugs.webkit.org/show_bug.cgi?id=50517

This change shows about 2% performance win on the xml-parser benchmark.

  • wtf/text/AtomicString.cpp: (WTF::HashAndUTF8CharactersTranslator::equal):
03:59 Changeset [74828] by paroga@webkit.org

2010-12-31 Patrick Gansterer <paroga@webkit.org>

Unreviewed build fix after r74800.

  • bindings/js/JSDOMWindowCustom.cpp: Add missing header.
  • bindings/js/JSLocationCustom.cpp: Ditto.
03:47 Changeset [74827] by loislo@chromium.org

2010-12-31 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed. Coding style fix.

  • DumpRenderTree/chromium/TestShell.h:
03:41 Changeset [74826] by loislo@chromium.org

2010-12-31 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Chromium] Inspector's tests are very slow on Win(Dbg).

It was a problem with Chromium DRT. DevToolsAgent object instance was
attached not only to the inspected page but to the DevTools window too.
As result all the inspector files were interpreted as a content of inspected page
and were transfered to the DevTools scripts panel for debugging etc.

https://bugs.webkit.org/show_bug.cgi?id=51735

  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::TestShell): (TestShell::bindJSObjectsToWindow): (TestShell::createNewWindow):
  • DumpRenderTree/chromium/TestShell.h:
02:16 Changeset [74825] by abarth@webkit.org

Move HTML and XML parser benchmarks into PerformanceTests/Parser
https://bugs.webkit.org/show_bug.cgi?id=51772

Rubber-stamped by Eric Seidel.

Actually move the directory.

  • PerformanceTests/Parser: Copied from WebCore/benchmarks/parser.

PerformanceTests/Parser:

Add a ChangeLog for tracking changes to the Parser PerformanceTest.

  • ChangeLog: Added.

WebCore:

Remove the benchmarks folder now that it's empty. Future benchmarks
should go in the PerformanceTests directory.

  • benchmarks: Removed.
  • benchmarks/parser: Removed.
  • benchmarks/parser/html-parser.html: Removed.
  • benchmarks/parser/resources: Removed.
  • benchmarks/parser/resources/html5.html: Removed.
  • benchmarks/parser/resources/runner.js: Removed.
  • benchmarks/parser/xml-parser.html: Removed.
02:01 Changeset [74824] by abarth@webkit.org

2010-12-31 Patrick Gansterer <paroga@webkit.org>

Reviewed by Adam Barth.

Add XML parser benchmark
https://bugs.webkit.org/show_bug.cgi?id=51612

Move the JavaScript code of html parser into a separate file to share it with xml parser.

  • benchmarks/parser/html-parser.html:
  • benchmarks/parser/resources/runner.js: Copied from WebCore/benchmarks/parser/html-parser.html. (runFunction): (run): (start):
  • benchmarks/parser/xml-parser.html: Copied from WebCore/benchmarks/parser/html-parser.html.
01:51 Changeset [74823] by abarth@webkit.org

Move PageLoadTests to PerformanceTests/PageLoad
https://bugs.webkit.org/show_bug.cgi?id=51771

Rubber-stamped by Eric Seidel.

Actually move the directory.

  • PageLoadTests: Removed.
  • PageLoadTests/svg: Removed.
  • PageLoadTests/svg/LICENSES: Removed.
  • PageLoadTests/svg/files: Removed.
  • PageLoadTests/svg/files/33041-Samurai.svg: Removed.
  • PageLoadTests/svg/files/42450-under the see.svg: Removed.
  • PageLoadTests/svg/files/42470-flower_from_my_garden_v2.svg: Removed.
  • PageLoadTests/svg/files/44057-drops on a blade.svg: Removed.
  • PageLoadTests/svg/files/Harvey_Rayner.svg: Removed.
  • PageLoadTests/svg/files/az-lizard_benji_park_01.svg: Removed.
  • PageLoadTests/svg/files/bamboo_01.svg: Removed.
  • PageLoadTests/svg/files/cacuts_01.svg: Removed.
  • PageLoadTests/svg/files/cowboy.svg: Removed.
  • PageLoadTests/svg/files/crawfish2_ganson.svg: Removed.
  • PageLoadTests/svg/files/deb9frac1.svg: Removed.
  • PageLoadTests/svg/files/food_leif_lodahl_01.svg: Removed.
  • PageLoadTests/svg/files/france.svg: Removed.
  • PageLoadTests/svg/files/francobollo_gnome_ezechi_02.svg: Removed.
  • PageLoadTests/svg/files/gearflowers.svg: Removed.
  • PageLoadTests/svg/files/hereGear4.svg: Removed.
  • PageLoadTests/svg/files/mtsthelens.svg: Removed.
  • PageLoadTests/svg/files/mtsthelens0.jpg: Removed.
  • PageLoadTests/svg/files/world-iso.svg: Removed.
  • PageLoadTests/svg/files/worldcup.svg: Removed.
  • PageLoadTests/svg/svg.pltsuite: Removed.
  • PerformanceTests/PageLoad: Copied from PageLoadTests.
  • Sources/cmake/WebKitPackaging.cmake:

PerformanceTests/PageLoad:

Update URLs to point to the new directory name.

  • svg/svg.pltsuite:

Tools:

Update references to PageLoadTests to point to the new location.

  • Scripts/run-pageloadtest:
  • Scripts/webkitpy/common/config/build.py:

Websites/bugs.webkit.org:

Update list of top-level open-source directories.

  • PrettyPatch/PrettyPatch.rb:
01:28 Changeset [74822] by abarth@webkit.org

Move SunSpider into PerformanceTests
https://bugs.webkit.org/show_bug.cgi?id=51769

Rubber-stamped by Eric Seidel.

Actually move the directory.

  • PerformanceTests: Added.
  • PerformanceTests/SunSpider: Copied from SunSpider.
  • Sources/cmake/WebKitPackaging.cmake:
  • SunSpider: Removed.
  • SunSpider/SunSpider.make: Removed.
  • SunSpider/TODO: Removed.
  • SunSpider/UNCOVERED: Removed.
  • SunSpider/hosted: Removed.
  • SunSpider/hosted/json2.js: Removed.
  • SunSpider/hosted/sunspider.css: Removed.
  • SunSpider/hosted/sunspider.html: Removed.
  • SunSpider/hosted/versions.html: Removed.
  • SunSpider/make-hosted: Removed.
  • SunSpider/resources: Removed.
  • SunSpider/resources/TEMPLATE.html: Removed.
  • SunSpider/resources/driver-TEMPLATE.html: Removed.
  • SunSpider/resources/results-TEMPLATE.html: Removed.
  • SunSpider/resources/sunspider-analyze-results.js: Removed.
  • SunSpider/resources/sunspider-compare-results.js: Removed.
  • SunSpider/resources/sunspider-standalone-compare.js: Removed.
  • SunSpider/resources/sunspider-standalone-driver.js: Removed.
  • SunSpider/sunspider: Removed.
  • SunSpider/sunspider-compare-results: Removed.
  • SunSpider/tests: Removed.
  • SunSpider/tests/parse-only: Removed.
  • SunSpider/tests/parse-only/LIST: Removed.
  • SunSpider/tests/parse-only/concat-jquery-mootools-prototype.js: Removed.
  • SunSpider/tests/parse-only/jquery-1.3.2.js: Removed.
  • SunSpider/tests/parse-only/mootools-1.2.2-core-nc.js: Removed.
  • SunSpider/tests/parse-only/prototype-1.6.0.3.js: Removed.
  • SunSpider/tests/sunspider-0.9: Removed.
  • SunSpider/tests/sunspider-0.9.1: Removed.
  • SunSpider/tests/sunspider-0.9.1/3d-cube.js: Removed.
  • SunSpider/tests/sunspider-0.9.1/3d-morph.js: Removed.
  • SunSpider/tests/sunspider-0.9.1/3d-raytrace.js: Removed.
  • SunSpider/tests/sunspider-0.9.1/LIST: Removed.
  • SunSpider/tests/sunspider-0.9.1/access-binary-trees.js: Removed.
  • SunSpider/tests/sunspider-0.9.1/access-fannkuch.js: Removed.
  • SunSpider/tests/sunspider-0.9.1/access-nbody.js: Removed.
  • SunSpider/tests/sunspider-0.9.1/access-nsieve.js: Removed.
  • SunSpider/tests/sunspider-0.9.1/bitops-3bit-bits-in-byte.js: Removed.
  • SunSpider/tests/sunspider-0.9.1/bitops-bits-in-byte.js: Removed.
  • SunSpider/tests/sunspider-0.9.1/bitops-bitwise-and.js: Removed.
  • SunSpider/tests/sunspider-0.9.1/bitops-nsieve-bits.js: Removed.
  • SunSpider/tests/sunspider-0.9.1/controlflow-recursive.js: Removed.
  • SunSpider/tests/sunspider-0.9.1/crypto-aes.js: Removed.
  • SunSpider/tests/sunspider-0.9.1/crypto-md5.js: Removed.
  • SunSpider/tests/sunspider-0.9.1/crypto-sha1.js: Removed.
  • SunSpider/tests/sunspider-0.9.1/date-format-tofte.js: Removed.
  • SunSpider/tests/sunspider-0.9.1/date-format-xparb.js: Removed.
  • SunSpider/tests/sunspider-0.9.1/math-cordic.js: Removed.
  • SunSpider/tests/sunspider-0.9.1/math-partial-sums.js: Removed.
  • SunSpider/tests/sunspider-0.9.1/math-spectral-norm.js: Removed.
  • SunSpider/tests/sunspider-0.9.1/regexp-dna.js: Removed.
  • SunSpider/tests/sunspider-0.9.1/string-base64.js: Removed.
  • SunSpider/tests/sunspider-0.9.1/string-fasta.js: Removed.
  • SunSpider/tests/sunspider-0.9.1/string-tagcloud.js: Removed.
  • SunSpider/tests/sunspider-0.9.1/string-unpack-code.js: Removed.
  • SunSpider/tests/sunspider-0.9.1/string-validate-input.js: Removed.
  • SunSpider/tests/sunspider-0.9/3d-cube.js: Removed.
  • SunSpider/tests/sunspider-0.9/3d-morph.js: Removed.
  • SunSpider/tests/sunspider-0.9/3d-raytrace.js: Removed.
  • SunSpider/tests/sunspider-0.9/LIST: Removed.
  • SunSpider/tests/sunspider-0.9/access-binary-trees.js: Removed.
  • SunSpider/tests/sunspider-0.9/access-fannkuch.js: Removed.
  • SunSpider/tests/sunspider-0.9/access-nbody.js: Removed.
  • SunSpider/tests/sunspider-0.9/access-nsieve.js: Removed.
  • SunSpider/tests/sunspider-0.9/bitops-3bit-bits-in-byte.js: Removed.
  • SunSpider/tests/sunspider-0.9/bitops-bits-in-byte.js: Removed.
  • SunSpider/tests/sunspider-0.9/bitops-bitwise-and.js: Removed.
  • SunSpider/tests/sunspider-0.9/bitops-nsieve-bits.js: Removed.
  • SunSpider/tests/sunspider-0.9/controlflow-recursive.js: Removed.
  • SunSpider/tests/sunspider-0.9/crypto-aes.js: Removed.
  • SunSpider/tests/sunspider-0.9/crypto-md5.js: Removed.
  • SunSpider/tests/sunspider-0.9/crypto-sha1.js: Removed.
  • SunSpider/tests/sunspider-0.9/date-format-tofte.js: Removed.
  • SunSpider/tests/sunspider-0.9/date-format-xparb.js: Removed.
  • SunSpider/tests/sunspider-0.9/math-cordic.js: Removed.
  • SunSpider/tests/sunspider-0.9/math-partial-sums.js: Removed.
  • SunSpider/tests/sunspider-0.9/math-spectral-norm.js: Removed.
  • SunSpider/tests/sunspider-0.9/regexp-dna.js: Removed.
  • SunSpider/tests/sunspider-0.9/string-base64.js: Removed.
  • SunSpider/tests/sunspider-0.9/string-fasta.js: Removed.
  • SunSpider/tests/sunspider-0.9/string-tagcloud.js: Removed.
  • SunSpider/tests/sunspider-0.9/string-unpack-code.js: Removed.
  • SunSpider/tests/sunspider-0.9/string-validate-input.js: Removed.
  • SunSpider/tests/ubench: Removed.
  • SunSpider/tests/ubench/LIST: Removed.
  • SunSpider/tests/ubench/function-closure.js: Removed.
  • SunSpider/tests/ubench/function-correct-args.js: Removed.
  • SunSpider/tests/ubench/function-empty.js: Removed.
  • SunSpider/tests/ubench/function-excess-args.js: Removed.
  • SunSpider/tests/ubench/function-missing-args.js: Removed.
  • SunSpider/tests/ubench/function-sum.js: Removed.
  • SunSpider/tests/ubench/loop-empty-resolve.js: Removed.
  • SunSpider/tests/ubench/loop-empty.js: Removed.
  • SunSpider/tests/ubench/loop-sum.js: Removed.
  • SunSpider/tests/v8-v4: Removed.
  • SunSpider/tests/v8-v4/LIST: Removed.
  • SunSpider/tests/v8-v4/v8-crypto.js: Removed.
  • SunSpider/tests/v8-v4/v8-deltablue.js: Removed.
  • SunSpider/tests/v8-v4/v8-earley-boyer.js: Removed.
  • SunSpider/tests/v8-v4/v8-raytrace.js: Removed.
  • SunSpider/tests/v8-v4/v8-regexp.js: Removed.
  • SunSpider/tests/v8-v4/v8-richards.js: Removed.
  • SunSpider/tests/v8-v4/v8-splay.js: Removed.
  • SunSpider/tests/v8-v5: Removed.
  • SunSpider/tests/v8-v5/LIST: Removed.
  • SunSpider/tests/v8-v5/v8-crypto.js: Removed.
  • SunSpider/tests/v8-v5/v8-deltablue.js: Removed.
  • SunSpider/tests/v8-v5/v8-earley-boyer.js: Removed.
  • SunSpider/tests/v8-v5/v8-raytrace.js: Removed.
  • SunSpider/tests/v8-v5/v8-regexp.js: Removed.
  • SunSpider/tests/v8-v5/v8-richards.js: Removed.
  • SunSpider/tests/v8-v5/v8-splay.js: Removed.
  • SunSpider/tests/v8-v6: Removed.
  • SunSpider/tests/v8-v6/LIST: Removed.
  • SunSpider/tests/v8-v6/v8-crypto.js: Removed.
  • SunSpider/tests/v8-v6/v8-deltablue.js: Removed.
  • SunSpider/tests/v8-v6/v8-earley-boyer.js: Removed.
  • SunSpider/tests/v8-v6/v8-raytrace.js: Removed.
  • SunSpider/tests/v8-v6/v8-regexp.js: Removed.
  • SunSpider/tests/v8-v6/v8-richards.js: Removed.
  • SunSpider/tests/v8-v6/v8-splay.js: Removed.
  • SunSpider/xcopy.excludes: Removed.

Tools:

Update these scripts to point to the new location.

  • Scripts/run-sunspider:
  • Scripts/sunspider-compare-results:

Websites/bugs.webkit.org:

Update list of top-level open-source directories.

  • PrettyPatch/PrettyPatch.rb:

12/30/10:

20:02 Changeset [74821] by mihaip@chromium.org

2010-12-30 Mihai Parparita <mihaip@chromium.org>

Reviewed by Kent Tamura.

[Chromium] Add WebThemeEngineDRTMac so that Chromium DRT scrollbar rendering can match the Mac port's
https://bugs.webkit.org/show_bug.cgi?id=51728

Add implementation of the Mac WebThemeEngine that uses an NSScroller
to render top-level scrollbars. This makes them match the Mac port's
use of an NSScrollView, which means that we'll be able to share more
pixel baselines.

The new rendering code will not be activated until the
USE_WEB_THEME_ENGINE_TO_PAINT_THUMB #define is fliped in
ScrollbarThemeChromiumMac.

  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/chromium/TestShellMac.mm: (platformInit):
  • DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Added.
  • DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Added. (+[FakeActiveWindow alwaysActiveWindow]): (+[FakeActiveWindow alwaysInactiveWindow]): (-[FakeActiveWindow initWithActiveControls:]): (-[FakeActiveWindow _hasActiveControls]): (WebThemeEngineDRTMac::paintScrollbarThumb): (stateToHIEnableState): (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb): (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):

2010-12-30 Mihai Parparita <mihaip@chromium.org>

Reviewed by Kent Tamura.

[Chromium] Add WebThemeEngineDRTMac so that Chromium DRT scrollbar rendering can match the Mac port's
https://bugs.webkit.org/show_bug.cgi?id=51728

Roll DEPS to pick up WebThemeEngine changes.

  • DEPS:
18:44 Changeset [74820] by zmo@google.com

2010-12-29 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Update validation of stencil mask and ref values
https://bugs.webkit.org/show_bug.cgi?id=50716

  • fast/canvas/webgl/webgl-specific-expected.txt: Sync with khronos: refactor the test, also update the stencil setting test due to spec change.
  • fast/canvas/webgl/webgl-specific.html: Ditto.
17:53 Changeset [74819] by inferno@chromium.org

2010-12-30 Abhishek Arya <inferno@chromium.org>

Unreviewed.

Skipping media/video-element-other-namespace-crash.html for chromium
since it uses codecs that chromium does not support.

  • platform/chromium/test_expectations.txt:
17:30 Changeset [74818] by zmo@google.com

2010-12-29 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Update validation of stencil mask and ref values
https://bugs.webkit.org/show_bug.cgi?id=50716

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::initializeNewContext): Initialize cached stencil settings. (WebCore::WebGLRenderingContext::drawArrays): Validate stencil settings. (WebCore::WebGLRenderingContext::drawElements): Ditto. (WebCore::WebGLRenderingContext::stencilFunc): Cache stencil settings, but generate no error. (WebCore::WebGLRenderingContext::stencilFuncSeparate): Ditto. (WebCore::WebGLRenderingContext::stencilMask): Ditto. (WebCore::WebGLRenderingContext::stencilMaskSeparate): Ditto. (WebCore::WebGLRenderingContext::validateStencilSettings): Helper function to validate stencil settings.
  • html/canvas/WebGLRenderingContext.h: Declare stencil setting members.

2010-12-29 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Update validation of stencil mask and ref values
https://bugs.webkit.org/show_bug.cgi?id=50716

  • fast/canvas/webgl/webgl-specific-expected.txt: Sync with khronos: refactor the test, also update the stencil setting test due to spec change.
  • fast/canvas/webgl/webgl-specific.html: Ditto.
17:03 Changeset [74817] by mrobinson@webkit.org

2010-12-30 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Fork pieces of RenderThemeGtk that will differ for GTK+ 3
https://bugs.webkit.org/show_bug.cgi?id=51755

Split out pieces of RenderThemeGtk into RenderThemeGtk2 and RenderThemeGtk3
if they are going to differ between GTK+ 2.x and GTK+ 3.x. This is the preliminary
step to landing support for the new GTK+ 3.x theming API.

No new tests. This should not change functionality.

  • GNUmakefile.am: Add RenderThemeGtk2 and RenderThemeGtk3 to the sources list.
  • platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::adjustTextFieldStyle): Call the setTextInputBorders static method. (WebCore::RenderThemeGtk::adjustTextAreaStyle): Ditto. (WebCore::RenderThemeGtk::paintMediaButton): Ditto. (WebCore::RenderThemeGtk::adjustProgressBarStyle): ditto.
  • platform/gtk/RenderThemeGtk.h: Make setTextInputBorders a method, so that it can be exist in RenderThemeGtk{2,3} and be called from RenderThemeGtk.
  • platform/gtk/RenderThemeGtk2.cpp: Added. A fork of the bits of RenderThemeGtk that will eventually be platform-dependent.
  • platform/gtk/RenderThemeGtk3.cpp: Added. Ditto.
16:50 Changeset [74816] by jschuh@chromium.org

2010-12-30 Justin Schuh <jschuh@chromium.org>

Reviewed by James Robinson.

Reverting r74292 because it introduced a crash with ruby text.
https://bugs.webkit.org/show_bug.cgi?id=51637

Test: fast/css/counters/counter-ruby-text-cleared.html

  • rendering/RenderCounter.cpp: (WebCore::findPlaceForCounter):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::addChild):
  • rendering/RenderObjectChildList.cpp: (WebCore::RenderObjectChildList::appendChildNode): (WebCore::RenderObjectChildList::insertChildNode):

2010-12-30 Justin Schuh <jschuh@chromium.org>

Reviewed by James Robinson.

Check for crash when deleting ruby text with counters.
https://bugs.webkit.org/show_bug.cgi?id=51637

  • fast/css/counters/counter-ruby-text-cleared-expected.txt: Added.
  • fast/css/counters/counter-ruby-text-cleared.html: Added.
16:39 Changeset [74815] by paroga@webkit.org

2010-12-30 Patrick Gansterer <paroga@webkit.org>

Reviewed by Ariya Hidayat.

[CMake] Add WTF_HEADERS
https://bugs.webkit.org/show_bug.cgi?id=51741

Add the WTF headers to show them in Visual Studio.

  • wtf/CMakeLists.txt:
  • wtf/CMakeListsWinCE.txt:
16:24 Changeset [74814] by darin@apple.com

2010-12-30 Darin Adler <darin@apple.com>

Reviewed by David Kilzer.

Remove unused JSBinding source files
https://bugs.webkit.org/show_bug.cgi?id=51762

  • bindings/js/JSBinding.h: Removed.
  • bindings/js/specialization: Removed.
  • bindings/js/specialization/JSBindingState.cpp: Removed.
  • bindings/js/specialization/JSBindingState.h: Removed.
  • CMakeLists.txt: Removed references to files.
  • GNUmakefile.am: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • bindings/js/JSBindingsAllInOne.cpp: Ditto.
15:47 Changeset [74813] by commit-queue@webkit.org

2010-12-30 Konstantin Tokarev <annulen@yandex.ru>

Reviewed by David Kilzer.

[Qt] Don't build wtf/TCSystemAlloc.cpp if --system-malloc option is
used
https://bugs.webkit.org/show_bug.cgi?id=51672

  • WebKit.pri: Replaced USE_SYSTEM_MALLOC with USE_SYSTEM_MALLOC=1

2010-12-30 Konstantin Tokarev <annulen@yandex.ru>

Reviewed by David Kilzer.

[Qt] Don't build wtf/TCSystemAlloc.cpp if --system-malloc option is
used
https://bugs.webkit.org/show_bug.cgi?id=51672

  • wtf/wtf.pri: Replaced USE_SYSTEM_MALLOC with USE_SYSTEM_MALLOC=1

2010-12-30 Konstantin Tokarev <annulen@yandex.ru>

Reviewed by David Kilzer.

[Qt] Don't build wtf/TCSystemAlloc.cpp if --system-malloc option is
used
https://bugs.webkit.org/show_bug.cgi?id=51672

  • DumpRenderTree/qt/DumpRenderTree.pro: Replaced USE_SYSTEM_MALLOC with USE_SYSTEM_MALLOC=1
  • WebKitTestRunner/qt/WebKitTestRunner.pro: Replaced USE_SYSTEM_MALLOC with USE_SYSTEM_MALLOC=1
15:41 Changeset [74812] by tonyg@chromium.org

2010-12-30 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Darin Adler.

Remove Document.h include from some headers where it isn't necessary
https://bugs.webkit.org/show_bug.cgi?id=51730

No new tests because no new functionality.

  • editing/EditingStyle.cpp:
  • editing/EditingStyle.h:
  • editing/SelectionController.h:
  • editing/visible_units.h:
  • html/HTMLAudioElement.h:
  • html/HTMLBodyElement.h:
  • inspector/InspectorCSSAgent.h:
  • inspector/InspectorDOMAgent.h:
  • inspector/InspectorInstrumentation.h:
  • xml/DOMParser.cpp:
  • xml/DOMParser.h: (WebCore::DOMParser::create): (WebCore::DOMParser::DOMParser):
15:30 Changeset [74811] by laszlo.1.gombos@nokia.com

2010-12-30 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by David Kilzer.

[Qt] [Symbian] Fix build-webkit script for Symbian
https://bugs.webkit.org/show_bug.cgi?id=51509

Set the OUTPUT_DIR for Symbian to be the same as the source
directory.

  • Scripts/webkitdirs.pm:
13:55 Changeset [74810] by paroga@webkit.org

2010-12-30 Benjamin C Meyer <bmeyer@rim.com>

Reviewed by Darin Adler.

bindings/js/JSDesktopNotificationsCustom.cpp is not included in the cmake build
which is required when NOTIFICATIONS is enabled.

https://bugs.webkit.org/show_bug.cgi?id=51761

  • CMakeLists.txt:
13:46 Changeset [74809] by mrobinson@webkit.org

2010-12-30 Martin Robinson <mrobinson@igalia.com>

Reviewed by Darin Adler.

check-webkit-style should ignore NULL usage in calls to gtk_widget_style_get
https://bugs.webkit.org/show_bug.cgi?id=51758

Add a check-webkit-style exception for gtk_widget_style_get and NULL usage.

  • Scripts/webkitpy/style/checkers/cpp.py: Add the exception.
  • Scripts/webkitpy/style/checkers/cpp_unittest.py: Add some tests for this.
12:59 Changeset [74808] by antti@apple.com

Not reviewed.

Revert accidental project file change.

  • WebCore.xcodeproj/project.pbxproj:
12:57 Changeset [74807] by antti@apple.com

https://bugs.webkit.org/show_bug.cgi?id=51134
Move loading related code from MemoryCache to CachedResourceLoader

Reviewed by Darin Adler.

  • Merge MemoryCache::requestResource to CachedResourceLoader::requestResource
  • Merge MemoryCache::requestUserCSSStyleSheet to CachedResourceLoader::requestUserCSSStyleSheet
  • Move MemoryCache::revalidateResource to CachedResourceLoader::revalidateResource
  • Add MemoryCache::add
  • Refactor the decision on whether to reload, revalidate or use the existing resource to a single function, CachedResourceLoader::determineRevalidationPolicy
  • css/CSSImageValue.cpp:

(WebCore::CSSImageValue::cachedImage):

Remove a code path that called MemoryCache::requestResource directly. This code path would have crashed
if ever taken (since it passes null CachedResourceLoader pointer).


  • loader/ImageLoader.cpp:

(WebCore::ImageLoader::updateFromElement):

  • loader/cache/CachedImage.cpp:
  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::CachedResource):
(WebCore::CachedResource::~CachedResource):
(WebCore::CachedResource::mustRevalidateDueToCacheHeaders):

Moved tests that were not about cache headers to CachedResourceLoader::determineRevalidationPolicy and renamed.


(WebCore::CachedResource::setLoadPriority):

Check for Unresolved value before setting.


  • loader/cache/CachedResource.h:

(WebCore::CachedResource::setOwningCachedResourceLoader):

Rename to be bit less mysterious.


  • loader/cache/CachedResourceLoader.cpp:

(WebCore::createResource):

This was moved from MemoryCache.


(WebCore::CachedResourceLoader::~CachedResourceLoader):
(WebCore::CachedResourceLoader::determineRevalidationPolicy):
(WebCore::CachedResourceLoader::requestUserCSSStyleSheet):

This was moved/merged from MemoryCache.


(WebCore::CachedResourceLoader::canRequest):
(WebCore::CachedResourceLoader::requestResource):

This combines MemoryCache::requestResource and the existing method.


(WebCore::CachedResourceLoader::revalidateResource):

This was moved from MemoryCache.


(WebCore::CachedResourceLoader::loadResource):

New method for initiating loading.


(WebCore::CachedResourceLoader::notifyLoadedFromMemoryCache):

Renamed the mysterious CachedResourceLoader::checkCacheObjectStatus


  • loader/cache/CachedResourceLoader.h:
  • loader/cache/MemoryCache.cpp:

(WebCore::MemoryCache::add):

  • loader/cache/MemoryCache.h:

(WebCore::MemoryCache::remove):

12:53 Changeset [74806] by steveblock@google.com

2010-12-30 Steve Block <steveblock@google.com>

Reviewed by Gavin Barraclough.

Enable JSC Rich Source Info for Android even when Inspector and Debugger are disabled
https://bugs.webkit.org/show_bug.cgi?id=51740

This is a policy decision for Android.

No new tests, simply enabling existing, tested code on Android.

  • bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::supportsRichSourceInfo):
12:29 Changeset [74805] by mihaip@chromium.org

2010-12-30 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium baseline update.

[Chromium] svg/dom/length-list-parser.html fails on Chromium Linux after r74788 and r74803
https://bugs.webkit.org/show_bug.cgi?id=51759

r74803 added chromium-win baselines for svg/dom/length-list-parser.html
but chromium-linux shouldn't use them (despite having them in its
fallback path). Copy the base expectations into chromium-linux.

  • platform/chromium-linux/svg/dom/length-list-parser-expected.txt: Added.
12:21 Changeset [74804] by mihaip@chromium.org

2010-12-30 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium expectations update.

Mark a few inspector tests as slow, they occasionally time out with
debug builds.

  • platform/chromium/test_expectations.txt:
11:40 Changeset [74803] by jschuh@chromium.org

2010-12-30 Justin Schuh <jschuh@chromium.org>

Unreviewed.

chromium test expectations after r74788 for svg/dom/length-list-parser.html

  • platform/chromium-win/svg/dom/length-list-parser-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
11:34 Changeset [74802] by paroga@webkit.org

2010-12-30 Patrick Gansterer <paroga@webkit.org>

Reviewed by Darin Adler.

Use OS(WINDOWS) instead of COMPILER(MSVC) in FastMalloc.cpp
https://bugs.webkit.org/show_bug.cgi?id=51743

Most of the ifdefs belong to windows and not to the MSVC compiler.

  • wtf/FastMalloc.cpp:
11:31 Changeset [74801] by yael.aharon@nokia.com

REGRESSION: fast/dom/cssTarget-crash.html fails
https://bugs.webkit.org/show_bug.cgi?id=20342

Reviewed by Adam Barth.

WebCore:

Do not reload the page when submitting a form, using "GET" method, and the
form action url matches the location url, except for the fragment.

Test: fast/forms/submit-change-fragment.html

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadURL):
(WebCore::FrameLoader::loadWithDocumentLoader):
(WebCore::FrameLoader::shouldScrollToAnchor):

  • loader/FrameLoader.h:

LayoutTests:

  • fast/forms/submit-change-fragment-expected.txt: Added.
  • fast/forms/submit-change-fragment.html: Added.
  • platform/mac/Skipped:
  • platform/qt/Skipped:
11:27 Changeset [74800] by darin@apple.com

2010-12-30 Darin Adler <darin@apple.com>

Reviewed by Adam Barth.

Move security logic out of the JavaScript binding for location into the DOM class
https://bugs.webkit.org/show_bug.cgi?id=51714

  • WebCore.xcodeproj/project.pbxproj: Removed JSBindingState.cpp, JSBindingState.h, and JSBinding.h. Later, we'll remove them from other project files and delete the source files.
  • bindings/js/JSBinding.h: Emptied out, marked for later deletion.
  • bindings/js/JSDOMBinding.cpp: Removed unused overload of the jsOwnedStringOrNull function, unused shouldAllowNavigation function, unused allowSettingSrcToJavascriptURL function, unused toLexicalFrame function, unused completeURL function, unused getCachedDOMStructure and cacheDOMStructure overloads, and unused getCachedDOMConstructor and cacheDOMConstruction functions. (WebCore::activeDOMWindow): Added. (WebCore::firstDOMWindow): Added. (WebCore::toDynamicFrame): Changed to use firstDOMWindow instead of calling through JSBindingState, since the latter is an unneeded abstraction. (WebCore::processingUserGesture): Changed to call ScriptController's function rather than calling through JSBindingState, which is an unneeded abstraction
  • bindings/js/JSDOMBinding.h: Removed the functions mentioned above. Added activeDOMWindow and firstDOMWindow. Also added a FIXME for the extremely poorly named allowsAccessFromFrame functions, which answer the question of whether script is allowed access *to* a frame.
  • bindings/js/JSDOMWindowCustom.cpp: Removed many unneeded includes. (WebCore::JSDOMWindow::setLocation): Streamlined by using the new activeDOMWindow and firstDOMWindow functions. (WebCore::JSDOMWindow::open): Ditto. (WebCore::JSDOMWindow::showModalDialog): Ditto. (WebCore::JSDOMWindow::postMessage): Ditto.
  • bindings/js/JSLocationCustom.cpp: (WebCore::JSLocation::setHref): Changed to pass the active and first windows through to the Location::setHref function, with it doing the rest of the work. This moves work out of the DOM binding that belongs in the DOM itself. Eventually such functions could even be automatically generated by the bindings script. (WebCore::JSLocation::setProtocol): Ditto. (WebCore::JSLocation::setHost): Ditto. (WebCore::JSLocation::setHostname): Ditto. (WebCore::JSLocation::setPort): Ditto. (WebCore::JSLocation::setPathname): Ditto. (WebCore::JSLocation::setSearch): Ditto. (WebCore::JSLocation::setHash): Ditto. (WebCore::JSLocation::replace): Ditto. (WebCore::JSLocation::reload): Ditto. (WebCore::JSLocation::assign): Ditto.
  • bindings/js/specialization/JSBindingState.cpp: Emptied out, marked for later deletion.
  • bindings/js/specialization/JSBindingState.h: Emptied out, marked for later deletion.
  • page/DOMWindow.cpp: (WebCore::DOMWindow::setLocation): Added a SetLocationLocking argument that allows us to use this function for Location::replace, which is the same as setLocation except that it locks both history and the back/forward list.
  • page/DOMWindow.h: Ditto.
  • page/Location.cpp: (WebCore::Location::setHref): Added. Uses DOMWindow::setLocation so that the security logic there does not have to be repeated or even refactored. (WebCore::Location::setProtocol): Ditto. (WebCore::Location::setHost): Ditto. (WebCore::Location::setHostname): Ditto. (WebCore::Location::setPort): Ditto. (WebCore::Location::setPathname): Ditto. (WebCore::Location::setSearch): Ditto. (WebCore::Location::setHash): Ditto. (WebCore::Location::assign): Ditto. (WebCore::Location::replace): Ditto. (WebCore::Location::reload): Added. Security logic was refactored from the code in JSLocationCustom.cpp. Added a FIXME about the fact that this security logic seems possibly unneeded.
  • page/Location.h: Fixed indentation on the whole file. Added the new functions above. (WebCore::Location::create): (WebCore::Location::frame):
09:26 Changeset [74799] by apavlov@chromium.org

2010-12-30 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Pasting a style property with value should automatically split it into prop/value
https://bugs.webkit.org/show_bug.cgi?id=51581

The "paste" DOM event is handled for the CSS property name field to parse out the name and value parts
of a CSS property being pasted (by the first ':' found). The property is committed (if not a new one),
and the edit focus is transferred to the value field.

  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertyTreeElement.prototype.selectElement): (WebInspector.StylePropertyTreeElement.prototype):
  • inspector/front-end/inspector.js: (WebInspector.completeURL): Drive-by: return full URLs as-is. (WebInspector.startEditing.cleanUpAfterEditing): (WebInspector.startEditing): (WebInspector.startEditing.pasteEventListener): (WebInspector.startEditing.keyDownEventListener):
07:32 Changeset [74798] by podivilov@chromium.org

2010-12-30 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: breakpoint is not disabled when clicking on breakpoints sidebar pane checkbox.
https://bugs.webkit.org/show_bug.cgi?id=51745

  • inspector/front-end/Breakpoint.js: (WebInspector.Breakpoint.prototype.set enabled):
07:28 Changeset [74797] by podivilov@chromium.org

2010-12-30 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: call stack shows "Paused on a JavaScript breakpoint" when stepping.
https://bugs.webkit.org/show_bug.cgi?id=51748

  • inspector/front-end/CallStackSidebarPane.js: (WebInspector.CallStackSidebarPane.prototype.update): (WebInspector.CallStackSidebarPane.prototype.registerShortcuts): (WebInspector.CallStackSidebarPane.prototype._scriptBreakpointHit): (WebInspector.CallStackSidebarPane.prototype._nativeBreakpointHit):
05:11 Changeset [74796] by philn@webkit.org

2010-12-30 Philippe Normand <pnormand@igalia.com>

Unreviewed, unskip the test, it's running fine locally.

media/audio-delete-while-slider-thumb-clicked.html fails
https://bugs.webkit.org/show_bug.cgi?id=37546

  • platform/gtk/Skipped:
05:04 Changeset [74795] by mnaganov@chromium.org

2010-12-30 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Fix leak of MemoryInfo wrappers introduced in r57004 (see issue 51712).

https://bugs.webkit.org/show_bug.cgi?id=51713

  • WebCore.gypi:
  • WebCore.pro:
  • bindings/v8/custom/V8ConsoleCustom.cpp: (WebCore::V8Console::memoryAccessorGetter):
  • bindings/v8/custom/V8PerformanceCustom.cpp: Copied from V8ConsoleCustom.cpp. (WebCore::V8Performance::memoryAccessorGetter):
  • page/Console.idl:
  • page/Performance.idl:
03:32 Changeset [74794] by steveblock@google.com

2010-12-30 Steve Block <steveblock@google.com>

Reviewed by Sam Weinig.

Visiting macnn.com often causes SQL spew via geolocation database
https://bugs.webkit.org/show_bug.cgi?id=51557

If the Geolocation position cache database path has not been set, early-out
rather than using an empty path and thus failing to open the database.
This avoids SQL log spew.

Also, avoid starting the database thread until the path has been set, and
shorten the thread name to avoid warnings due to exceeding 30 characters.

No new tests, implementation clean-up only.

  • page/GeolocationPositionCache.cpp: (WebCore::GeolocationPositionCache::addUser): (WebCore::GeolocationPositionCache::removeUser): (WebCore::GeolocationPositionCache::setDatabasePath): (WebCore::GeolocationPositionCache::startBackgroundThread):
03:02 Changeset [74793] by philn@webkit.org

2010-12-30 Philippe Normand <pnormand@igalia.com>

Unreviewed, skipping another editing flacky test.

  • platform/gtk/Skipped: skip editing/selection/extend-by-character-005.html.
02:17 Changeset [74792] by philn@webkit.org

2010-12-29 Philippe Normand <pnormand@igalia.com>

Reviewed by Martin Robinson.

[GTK] minimal build fails at link time due to missing sqlite3 symbols
https://bugs.webkit.org/show_bug.cgi?id=51327

  • configure.ac: Error out if SQLite3 wasn't found while at least one of the features depending on it has been enabled.

WebCore:

Reviewed by Martin Robinson.

[GTK] minimal build fails at link time due to missing sqlite3 symbols
https://bugs.webkit.org/show_bug.cgi?id=51327

Guard the code calling sqlite3 with the ENABLE(DATABASE) check.

No new tests, build fix only.

  • platform/sql/SQLiteAuthorizer.cpp:
  • platform/sql/SQLiteDatabase.cpp:
  • platform/sql/SQLiteFileSystem.cpp:
  • platform/sql/SQLiteStatement.cpp:
  • platform/sql/SQLiteTransaction.cpp:
01:29 Changeset [74791] by hamaji@chromium.org

2010-12-30 Shinichiro Hamaji <shinichiro.hamaji@gmail.com>

Chromium test expectation update for svg/dom/length-list-parser.html

  • platform/chromium/test_expectations.txt:
01:25 Changeset [74790] by hamaji@chromium.org

2010-12-30 Shinichiro Hamaji <shinichiro.hamaji@gmail.com>

Chromium test expectation update for media/video-element-other-namespace-crash.html

  • platform/chromium/test_expectations.txt:
01:18 WinCE edited by paroga@webkit.org
(diff)
00:29 Changeset [74789] by inferno@chromium.org

2010-12-30 Abhishek Arya <inferno@chromium.org>

Unreviewed.

Skip media/video-element-other-namespace-crash.html, like other media tests on qt platform.

  • platform/qt/Skipped:
00:12 Changeset [74788] by jschuh@chromium.org

2010-12-30 Justin Schuh <jschuh@chromium.org>

Reviewed by Dirk Schulze.

Prevent stringToLengthType() from skipping past end-of-string on invalid length unit.
https://bugs.webkit.org/show_bug.cgi?id=51692

  • svg/SVGLength.cpp: (WebCore::stringToLengthType): (WebCore::SVGLength::setValueAsString):

2010-12-30 Justin Schuh <jschuh@chromium.org>

Reviewed by Dirk Schulze.

Adding long float string to improve test coverage.
https://bugs.webkit.org/show_bug.cgi?id=51692

  • svg/dom/length-list-parser.html:
  • svg/dom/length-list-parser-expected.txt:
00:02 Changeset [74787] by inferno@chromium.org

2010-12-30 Abhishek Arya <inferno@chromium.org>

Reviewed by Eric Seidel.

Create a helper function for finding descendent video elements for a node.
https://bugs.webkit.org/show_bug.cgi?id=51696

Test: media/video-element-other-namespace-crash.html

  • html/MediaDocument.cpp: (WebCore::descendentVideoElement): helper function. (WebCore::MediaDocument::defaultEventHandler): use the new helper function. fix code repetitions. (WebCore::MediaDocument::replaceMediaElementTimerFired): use the new helper function.

2010-12-30 Abhishek Arya <inferno@chromium.org>

Reviewed by Eric Seidel.

Tests that we do not crash when trying to find video elements in the media document.
https://bugs.webkit.org/show_bug.cgi?id=51696

  • media/video-element-other-namespace-crash-expected.txt: Added.
  • media/video-element-other-namespace-crash.html: Added.
Note: See TracTimeline for information about the timeline view.