Timeline


and

01/07/11:

23:37 Changeset [75310] by abarth@webkit.org

2011-01-07 Adam Barth <abarth@webkit.org>

Record expectation for test.

  • platform/chromium/test_expectations.txt:
20:38 Changeset [75309] by mihaip@chromium.org

2011-01-07 Mihai Parparita <mihaip@chromium.org>

Unreviewed, test expectation update.

Update mac-leopard baselines for tests that currently have up to date
Snow Leopard baselines in platform/mac.

  • platform/mac-leopard/fast/css/text-overflow-ellipsis-strict-expected.checksum:
  • platform/mac-leopard/fast/css/text-overflow-ellipsis-strict-expected.png:
  • platform/mac-leopard/fast/invalid/residual-style-expected.checksum:
  • platform/mac-leopard/fast/invalid/residual-style-expected.png:
  • platform/mac-leopard/fast/multicol/span/span-as-immediate-child-generated-content-expected.checksum:
  • platform/mac-leopard/fast/multicol/span/span-as-immediate-child-generated-content-expected.png:
  • platform/mac-leopard/fast/multicol/span/span-as-immediate-child-property-removal-expected.checksum:
  • platform/mac-leopard/fast/multicol/span/span-as-immediate-child-property-removal-expected.png:
  • platform/mac-leopard/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.checksum:
  • platform/mac-leopard/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.png:
  • platform/mac-leopard/fast/multicol/span/span-as-immediate-columns-child-removal-expected.checksum:
  • platform/mac-leopard/fast/multicol/span/span-as-immediate-columns-child-removal-expected.png:
  • platform/mac-leopard/fast/table/027-vertical-expected.checksum:
  • platform/mac-leopard/fast/table/027-vertical-expected.png:
  • platform/mac-leopard/fast/table/028-vertical-expected.checksum:
  • platform/mac-leopard/fast/table/028-vertical-expected.png:
  • platform/mac-leopard/fast/table/038-vertical-expected.checksum:
  • platform/mac-leopard/fast/table/038-vertical-expected.png:
  • platform/mac-leopard/fast/table/040-vertical-expected.checksum:
  • platform/mac-leopard/fast/table/040-vertical-expected.png:
  • platform/mac-leopard/fast/table/border-collapsing/002-vertical-expected.checksum:
  • platform/mac-leopard/fast/table/border-collapsing/002-vertical-expected.png:
  • platform/mac-leopard/fast/table/border-collapsing/equal-precedence-resolution-vertical-expected.checksum:
  • platform/mac-leopard/fast/table/border-collapsing/equal-precedence-resolution-vertical-expected.png:
  • platform/mac-leopard/fast/table/table-display-types-vertical-expected.checksum:
  • platform/mac-leopard/fast/table/table-display-types-vertical-expected.png:
  • platform/mac-leopard/fast/text/backslash-to-yen-sign-euc-expected.checksum:
  • platform/mac-leopard/fast/text/backslash-to-yen-sign-euc-expected.png:
  • platform/mac-leopard/fast/text/international/bidi-neutral-run-expected.checksum:
  • platform/mac-leopard/fast/text/international/bidi-neutral-run-expected.png:
  • platform/mac-leopard/svg/custom/junk-data-expected.checksum:
  • platform/mac-leopard/svg/custom/junk-data-expected.png:
  • platform/mac-leopard/svg/custom/missing-xlink-expected.checksum:
  • platform/mac-leopard/svg/custom/missing-xlink-expected.png:
  • platform/mac-leopard/tables/mozilla/other/wa_table_thtd_rowspan-expected.checksum:
  • platform/mac-leopard/tables/mozilla/other/wa_table_thtd_rowspan-expected.png:
18:59 Changeset [75308] by justin.garcia@apple.com

https://bugs.webkit.org/show_bug.cgi?id=51851
Implement RenderSVGInlineText::localCaretRect()

Reviewed by Dan Bernstein.

WebCore:

  • rendering/svg/RenderSVGInlineText.cpp:

(WebCore::RenderSVGInlineText::localCaretRect): Implemented.

LayoutTests:

  • svg/text/caret-in-svg-text-expected.txt: Added.
  • svg/text/caret-in-svg-text.xhtml: Added.
18:42 Changeset [75307] by rniwa@webkit.org

2011-01-07 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed; Added the missing null pointer check for r75293.

  • dom/Document.cpp: (WebCore::Document::adoptNode):
18:24 Changeset [75306] by slewis@apple.com

WebCore: <rdar://problem/8649617> Migrate memory tracking from Safari to WebKit
https://bugs.webkit.org/show_bug.cgi?id=50799 Add Memory Sampler to WebKit

Reviewed by Geoff Garen.

Add a sampler for printing off process memory statistics.
Export file mode.

  • WebCore.exp.in:

WebKit2: <rdar://problem/8649617> Migrate memory tracking from Safari to WebKit
https://bugs.webkit.org/show_bug.cgi?id=50799 Add Memory Sampler to WebKit

Reviewed by Geoff Garen.

Add a sampler for printing off process memory statistics.
This tool can track:

WebCore

  • FastMalloc allocations bytes (in use or committed)

JavaScriptCore

  • Garbage collector heap bytes (in use or committed)
  • Stack bytes (committed only!)
  • JIT Code bytes (committed only!)

Malloc zones

  • In use bytes for the following zones:
    • Default zone (in use or committed)
    • DispCon zone (in use or committed)
    • Purgable zone (in use or committed)

Task Info

  • Resident size memory (RSIZE)


Data collected is dumped to a temporary file.


Create a sandbox for a temporary file.

  • Shared/SandboxExtension.h:

(WebKit::SandboxExtension::createHandleForTemporaryFile):

  • Shared/mac/SandboxExtensionMac.mm:

(WebKit::SandboxExtension::createHandleForTemporaryFile):

Memory Sampler files

  • Shared/WebMemorySampler.cpp: Added.

(WebKit::WebMemorySampler::shared):
(WebKit::WebMemorySampler::WebMemorySampler):
(WebKit::WebMemorySampler::start):
(WebKit::WebMemorySampler::initializeTimers):
(WebKit::WebMemorySampler::stop):
(WebKit::WebMemorySampler::isRunning):
(WebKit::WebMemorySampler::initializeTempLogFile):
(WebKit::WebMemorySampler::initializeSandboxedLogFile):
(WebKit::WebMemorySampler::writeHeaders):
(WebKit::WebMemorySampler::sampleTimerFired):
(WebKit::WebMemorySampler::stopTimerFired):
(WebKit::WebMemorySampler::appendCurrentMemoryUsageToFile):

  • Shared/WebMemorySampler.h: Added.
  • Shared/mac/WebMemorySampler.mac.mm: Added.

(WebKit::WebMemorySampler::sampleSystemMalloc):
(WebKit::WebMemorySampler::sampleProcessCommittedBytes):
(WebKit::WebMemorySampler::processName):
(WebKit::WebMemorySampler::sampleWebKit):

API to start and stop UIProcess and WebProcess sampling.

  • UIProcess/API/C/WKContext.cpp:

(WKContextStartMemorySampler):
(WKContextStopMemorySampler):

  • UIProcess/API/C/WKContext.h:


Send messages to WebProcess to start and stop memory sampling.

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext):
(WebKit::WebContext::processDidFinishLaunching):
(WebKit::WebContext::startMemorySampler):
(WebKit::WebContext::stopMemorySampler):

  • UIProcess/WebContext.h:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::startMemorySampler):
(WebKit::WebProcess::stopMemorySampler):

  • WebProcess/WebProcess.h:
  • WebProcess/WebProcess.messages.in:
18:15 Changeset [75305] by rniwa@webkit.org

2011-01-06 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Adam Barth.

onbeforeunload is broken for framesets
https://bugs.webkit.org/show_bug.cgi?id=19418

Added beforeunload event support for sub frames. WebKit's implementation tries to match
that of Internet Explorer as much as possible. beforeunload event is fired for each and
every descendent of a frame that is about to navigate.

When a value other than null is returned by a beforeunload handler, a confirmation dialog
is shown for each handler (calls chrome's runBeforeUnloadConfirmPanel) just like it is done
for main frames.

In addition, navigation is forbidden while beforeunload handlers are being called.
Setting values to location.href, location.reload, and other means of navigations are thus
ignored while beforeunload event handler is being ran, matching Internet Explorer's behavior.

Because navigation needs to prevented globally, NavigationDisablerForBeforeUnload is added to
NavigationScheduler.h, which is instantiated as a RAII object in FrameLoader::shouldClose.

Tests: fast/events/before-unload-adopt-subframe-to-outside.html

fast/events/before-unload-adopt-within-subframes.html
fast/events/before-unload-forbidden-navigation.html
fast/events/before-unload-in-multiple-subframes.html
fast/events/before-unload-in-subframe.html
fast/events/before-unload-javascript-navigation.html
fast/events/before-unload-remove-and-add-subframe.html
fact/events/before-unload-remove-itself.html
fast/events/before-unload-with-subframes.html

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::shouldClose): Calls fireBeforeUnloadEvent on m_frame and m_frame's descendents. Returns true only if every call to fireBeforeUnloadEvent returned true. (WebCore::FrameLoader::fireBeforeUnloadEvent): Fires a beforeunload event and calls chrome's runBeforeUnloadConfirmPanel as needed. (WebCore::FrameLoader::continueLoadAfterNavigationPolicy): Calls shouldClose for all frames.
  • loader/FrameLoader.h:
  • loader/NavigationScheduler.cpp: (WebCore::NavigationScheduler::shouldScheduleNavigation): Checks the nullity of Page and calls NavigationDisablerForBeforeUnload::isNavigationAllowed when url is not javascript scheme. (WebCore::NavigationScheduler::scheduleRedirect): Calls shouldScheduleNavigation. (WebCore::NavigationScheduler::scheduleLocationChange): Ditto. (WebCore::NavigationScheduler::scheduleRefresh): Ditto. (WebCore::NavigationScheduler::scheduleHistoryNavigation): Ditto.
  • loader/NavigationScheduler.h: (WebCore::NavigationDisablerForBeforeUnload::NavigationDisablerForBeforeUnload): Disables navigation. (WebCore::NavigationDisablerForBeforeUnload::~NavigationDisablerForBeforeUnload): Enables navigation when called on the last instance of NavigationDisablerForBeforeUnload. (WebCore::NavigationDisablerForBeforeUnload::isNavigationAllowed): Returns true if there are no instance of NavigationDisablerForBeforeUnload left on the stack.

2011-01-06 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Adam Barth.

onbeforeunload is broken for framesets
https://bugs.webkit.org/show_bug.cgi?id=19418

Added tests to ensure WebKit fires beforeunload events for subframes,
and disallows navigation except that of javascript scheme while beforeunload event
handlers are being called.

Also added a test to ensure WebKit fires beforeunload event for subframes exactly
once even if a subframe was moved around within a beforeunload event handler.

A test that ensures beforeunload event is not fired for an iframe if the iframe
was added or removed within a beforeunload event handler is also added.

Furthermore, a test to ensure WebKit does not fire a beforeunload event to an iframe
that has been adopted by a document outside of the unloading document is added.

  • fast/events/before-unload-adopt-subframe-to-outside-expected.txt: Added.
  • fast/events/before-unload-adopt-subframe-to-outside.html: Added.
  • fast/events/before-unload-adopt-within-subframes-expected.txt: Added.
  • fast/events/before-unload-adopt-within-subframes.html: Added.
  • fast/events/before-unload-forbidden-navigation-expected.txt: Added.
  • fast/events/before-unload-forbidden-navigation.html: Added.
  • fast/events/before-unload-in-multiple-subframes-expected.txt: Added.
  • fast/events/before-unload-in-multiple-subframes.html: Added.
  • fast/events/before-unload-in-subframe-expected.txt: Added.
  • fast/events/before-unload-in-subframe.html: Added.
  • fast/events/before-unload-javascript-navigation-expected.txt: Added.
  • fast/events/before-unload-javascript-navigation.html: Added.
  • fast/events/before-unload-remove-and-add-subframe-expected.txt: Added.
  • fast/events/before-unload-remove-and-add-subframe.html: Added.
  • fact/events/before-unload-remove-itself-expected.txt: Added.
  • fact/events/before-unload-remove-itself.html: Added.
  • fast/events/before-unload-with-subframes-expected.txt: Added.
  • fast/events/before-unload-with-subframes.html: Added.
  • fast/events/resources/before-unload-in-subframe-child.html: Added.
  • fast/events/resources/before-unload-in-subframe-destination.html: Added.
  • fast/events/resources/before-unload-in-subframe-fail.html: Added.
  • fast/events/resources/before-unload-with-subframes-parent.html: Added.
17:58 Changeset [75304] by mrowe@apple.com

Merge r74427.

17:58 Changeset [75303] by mrowe@apple.com

Merge r74453.

17:58 Changeset [75302] by mrowe@apple.com

Merge r74375.

17:51 Changeset [75301] by mrowe@apple.com

Versioning.

17:45 Changeset [75300] by mrowe@apple.com

New tag.

17:45 Changeset [75299] by mrowe@apple.com

Remove bogus tag.

17:38 Changeset [75298] by mrobinson@webkit.org

2011-01-07 Martin Robinson <mrobinson@igalia.com>

Reviewed by Mihai Parparita.

fast/dom/Window/window-postmessage-clone-frames.html has some timing issues
https://bugs.webkit.org/show_bug.cgi?id=52032

Fix the timing issue in fast/dom/Window/window-postmessage-clone-frames.html
and move the output console div beyond the file input control, so that output
text does not push it outside the viewport.

  • fast/dom/Window/window-postmessage-clone-frames-expected.txt: Updated results to reflect div movement.
  • fast/dom/Window/window-postmessage-clone-frames.html: Fix the timing and layout issues with this test.
17:34 Changeset [75297] by mrowe@apple.com

New tag.

17:20 Changeset [75296] by mrobinson@webkit.org

2011-01-07 Martin Robinson <mrobinson@igalia.com>

Build fix for GTK+.

  • GNUmakefile.am: Add RenderFullScreen.cpp to the sources list.
  • rendering/RenderFullScreen.cpp: (RenderFullScreen::setAnimating): Guard the call to contentChanged with ENABLED(ACCELERATED_COMPOSITING).
17:15 Changeset [75295] by ojan@chromium.org

2011-01-06 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

side-by-side diffs in the code review tool
https://bugs.webkit.org/show_bug.cgi?id=52019

Support for conversion from the formatted diff to a side-by-side diff.
Maintains comments and new comments can be added.

The main architectural change is that Line elements are no longer necessarily
siblings. Each physical line is now in a LineContainer and LineContainers are
siblings. Each Line corresponds to a Line in the unified diff and has an id (e.g. line12).
A Line can be a LineContainer or a child of a LineContainer.

In this way, converting to side-by-side and, in the future, back to unified is non-lossy.

  • PrettyPatch/PrettyPatch.rb:
  • code-review.js:
16:53 Changeset [75294] by rniwa@webkit.org

2011-01-07 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed; speculative fix for Windows debug build.

  • bindings/js/JSBindingsAllInOne.cpp:
16:49 Changeset [75293] by rniwa@webkit.org

2011-01-07 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Ojan Vafai.

Adopting an iframe to a child frame results in stack overflow
https://bugs.webkit.org/show_bug.cgi?id=52018

Throws an exception when a document adopts an iframe that is an ancestor
of the document in the frame hierarchy. New behavior matches that of Firefox.

Test: fast/html/adopt-parent-frame.html

  • dom/Document.cpp: (WebCore::Document::adoptNode):

2011-01-07 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Ojan Vafai.

Adopting an iframe to a child frame results in stack overflow
https://bugs.webkit.org/show_bug.cgi?id=52018

Added a test to ensure calling adoptNode with an iframe throws an exception
if the adoptee is an ancestor of the document adopting the node in the frame hierarchy.

  • fast/html/adopt-parent-frame-expected.txt: Added.
  • fast/html/adopt-parent-frame.html: Added.
16:38 Changeset [75292] by mihaip@chromium.org

2011-01-07 Mihai Parparita <mihaip@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Scrollbar code cleanup
https://bugs.webkit.org/show_bug.cgi?id=52073

Scrollbar code cleanup:

  • Remove ScrollbarThemeMac.{mm|h} from the mac sources list, we use ScrollbarThemeChromiumMac.{mm|h}
  • Remove USE_WEB_THEME_ENGINE_TO_PAINT_THUMB #define now that switch to WebThemeEngine is permanent
  • Fix typo in Linux scrollbar enum name

No new tests (compiles).

  • WebCore.gypi:
  • platform/chromium/ChromiumBridge.h:
  • platform/chromium/ScrollbarThemeChromiumLinux.cpp: (WebCore::ScrollbarThemeChromiumLinux::paintTrackPiece):
  • platform/chromium/ScrollbarThemeChromiumMac.mm: (WebCore::scrollbarStateToThemeState): (WebCore::ScrollbarThemeChromiumMac::paint):

2011-01-07 Mihai Parparita <mihaip@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Scrollbar code cleanup
https://bugs.webkit.org/show_bug.cgi?id=52073

Scrollbar code cleanup:

  • Fix typo in Linux scrollbar enum name
  • public/linux/WebThemeEngine.h:
  • src/ChromiumBridge.cpp: (WebCore::WebThemePart): (WebCore::GetWebThemeExtraParams):
16:21 Changeset [75291] by mjs@apple.com

2011-01-07 Maciej Stachowiak <mjs@apple.com>

Reviewed by Sam Weinig.

Make WebKitTestRunner rest between loads more robust to avoid test crashes
https://bugs.webkit.org/show_bug.cgi?id=52086

  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::didReceiveMessage):
  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::notifyDone):
  • WebKitTestRunner/TestController.cpp: (WTR::TestController::resetStateToConsistentValues): (WTR::TestController::run):
16:21 Changeset [75290] by jer.noble@apple.com

GTK Linux build fix: isDocumentRunningFullScreenAnimation should
be protected both by ENABLE(FULLSCREEN_API) && USE(ACCELERATED_COMPOSITING)

  • page/FrameView.cpp:
15:59 Changeset [75289] by barraclough@apple.com

Bug 26276 - Need a mechanism to determine stack extent on WINDOWS, SOLARIS, OPENBSD, SYMBIAN, HAIKU, WINCE platforms

Reviewed by Geoff Garen.

Fix for win32. The base of the stack is stored in the "deallocation stack" field of the
Thread Information Block - see: http://en.wikipedia.org/wiki/Win32_Thread_Information_Block
for more information!

  • wtf/StackBounds.cpp:

(WTF::StackBounds::initialize):

15:57 Changeset [75288] by jer.noble@apple.com

Yet another Leopard build fix: NSRect and CGRect are not inter-
changable in 32-bit.

  • WebView/WebFullScreenController.mm:

(-[WebFullScreenController exitFullscreen]):

15:48 Changeset [75287] by commit-queue@webkit.org

2011-01-07 Rafael Weinstein <rafaelw@chromium.org>

Reviewed by Eric Seidel.

Cleanup: Fold shadowParentNode into shadowHost
https://bugs.webkit.org/show_bug.cgi?id=51059

Replaces all uses of shadowParentNode.

No new tests because no behavior has changed.

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::initForStyleResolve):
  • dom/Node.cpp: (WebCore::Node::shadowHost): (WebCore::Node::shadowAncestorNode): (WebCore::eventTargetRespectingSVGTargetRules): (WebCore::Node::getEventAncestors):
  • dom/Node.h:
  • editing/Editor.cpp: (WebCore::Editor::findString):
  • page/DragController.cpp: (WebCore::asFileInput):
  • page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEvent): (WebCore::instanceAssociatedWithShadowTreeElement): (WebCore::EventHandler::dispatchMouseEvent):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::hasLineIfEmpty):
  • rendering/RenderSVGShadowTreeRootContainer.cpp: (WebCore::RenderSVGShadowTreeRootContainer::updateFromElement):
  • svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::title):
15:39 Changeset [75286] by mrobinson@webkit.org

2011-01-07 Martin Robinson <mrobinson@igalia.com>

Add a platform-specific baseline for GTK+ after r75257.

  • platform/gtk/fast/text/emphasis-avoid-ruby-expected.checksum: Added.
  • platform/gtk/fast/text/emphasis-avoid-ruby-expected.png: Added.
  • platform/gtk/fast/text/emphasis-avoid-ruby-expected.txt: Added.
15:39 Changeset [75285] by jer.noble@apple.com

Fix the Leopard build: Replace CoreAnimation SL-only functions
with Leopard equivalents.

  • WebView/WebFullScreenController.mm:

(+[CATransaction setDisableActions:]):
(+[CATransaction setAnimationDuration:]):
(-[WebFullScreenController _animationDuration]):
(-[WebFullscreenWindow initWithContentRect:styleMask:backing:defer:]):

15:35 Changeset [75284] by cmarrin@apple.com

2011-01-07 Chris Marrin <cmarrin@apple.com>

Unreviewed.

I mistakenly included a Windows only file in a
cross platform file.

  • platform/graphics/ca/GraphicsLayerCA.cpp:
15:27 Changeset [75283] by cmarrin@apple.com

2011-01-07 Chris Marrin <cmarrin@apple.com>

Unreviewed.

Get rid of include of <QuartzCore/QuartzCore.h>

  • platform/graphics/ca/GraphicsLayerCA.cpp:
15:18 Changeset [75282] by jer.noble@apple.com

Further build fixes. Add a ENABLE(FULLSCREEN_API) guard around
the implementation of requiresCompositingfForFullScreen.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::requiresCompositingForFullScreen):

15:09 Changeset [75281] by jer.noble@apple.com

No review, build fix only. Removed parameter who was causing
a warning in Release builds.

  • dom/Document.cpp:

(WebCore::Document::webkitDidExitFullScreenForElement):

15:07 Changeset [75280] by cmarrin@apple.com

2011-01-07 Chris Marrin <cmarrin@apple.com>

Unreviewed.

Use new wkCACFLayerGetContextUserData function

  • platform/graphics/ca/win/PlatformCALayerWin.cpp:

2011-01-07 Chris Marrin <cmarrin@apple.com>

Unreviewed.

Minor change to check for null context

  • win/lib/WebKitSystemInterface.lib:
  • win/lib/WebKitSystemInterface_debug.lib:
14:58 Changeset [75279] by jberlin@webkit.org

WebKit2: Need WKBundleFrameCopyProvisionalURL
https://bugs.webkit.org/show_bug.cgi?id=52083

Reviewed by Dan Bernstein.

  • WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:

(WKBundleFrameCopyProvisionalURL):

  • WebProcess/InjectedBundle/API/c/WKBundleFrame.h:
  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::provisionalURL):
Grab the URL from the provisional document loader.

  • WebProcess/WebPage/WebFrame.h:
14:51 Changeset [75278] by jamesr@google.com

2011-01-07 James Robinson <jamesr@chromium.org>

Fix compile bustage due to bad merge in 75276.

  • page/animation/AnimationController.cpp: (WebCore::AnimationControllerPrivate::beginAnimationUpdateTime):
14:45 Changeset [75277] by jer.noble@apple.com

WebCore: Implement WebKit Full Screen support.
https://bugs.webkit.org/show_bug.cgi?id=49481
rdar://problem/8247444

Patch by Jer Noble <jer@kokode.apple.com> on 2010-12-17
Reviewed by Simon Fraser.

Mark for export all those WebCore functions needed by WebFullscreenController.

  • WebCore.exp.in:

WebCore: Implement WebKit Full Screen support.
https://bugs.webkit.org/show_bug.cgi?id=49481
rdar://problem/8247444

Patch by Jer Noble <jer@kokode.apple.com> on 2010-12-17
Reviewed by Simon Fraser.

screenRect is useful for more than just HTMLMediaElements. Promote it into
Element.

  • dom/Element.cpp: Moved into Element from HTMLMediaElement.
  • dom/Element.h: Ditto.
  • dom/Node.cpp:
  • html/HTMLMediaElement.cpp: Moved screenRect into Element.
  • html/HTMLMediaElement.h: Ditto.
  • WebCore.exp.in: Modify the exports list to reflect the new symbol name.

WebCore: Implement WebKit Full Screen support.
https://bugs.webkit.org/show_bug.cgi?id=49481
rdar://problem/8247444

Patch by Jer Noble <jer@kokode.apple.com> on 2010-12-17
Reviewed by Simon Fraser.

The RenderFullScreen is intended to be used by clients of that API to allow a DOM subtree to
be rendered outside its original Frame. Because of this, there are a few areas of the
rendering code which need to be special cased: RenderFullScreen layers should not be clipped
to the viewport, as they will almost always be rendering outside the viewport area;
RenderFullScreen graphics layers should not be reparented by the RenderLayerCompositor, as
the client will likely want to reparent the platformLayer into their own fullscreen platform
window; the FrameView must update the RenderFullScreen graphics layer tree separately from
the root layer, as the two trees are disconnected.

  • page/FrameView.cpp:

(WebCore::FrameView::updateCompositingLayers): Special treatment for fullscreen renderer.
(WebCore::FrameView::syncCompositingStateRecursive): Ditto.
(WebCore::FrameView::paintContents): Ditto.

  • rendering/RenderLayer.h: Add a new ContentChangeType enum entry for FullScreen.
  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::contentChanged): Add support for above.

  • rendering/RenderLayerBacking.cpp:

(WebCore::layerOrAncestorIsFullScreen): New function.
(WebCore::RenderLayerBacking::updateCompositedBounds): Do not clip if the layerOrAncestorIsFullScreen.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::rebuildCompositingLayerTree): Special treatment for fullscreen renderer.
(WebCore::RenderLayerCompositor::requiresCompositingLayer): Ditto.
(WebCore::RenderLayerCompositor::requiresCompositingForFullScreen): Ditto.

  • rendering/RenderLayerCompositor.h:

WebCore: Implement WebKit Full Screen support.
https://bugs.webkit.org/show_bug.cgi?id=49481
rdar://problem/8247444

Patch by Jer Noble <jer@kokode.apple.com> on 2010-12-17
Reviewed by Simon Fraser.

Implemented non-accelerated fullscreen support. The Document will now vend a RenderFullScreen object for clients to
use to relocate the fullscreen element subtree.

  • css/CSSStyleSelector.cpp:

(WebCore::loadFullScreenRulesIfNeeded): Change webkitFullScreen -> webkitIsFullScreen.
(WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Ditto.

  • dom/Document.cpp:

(WebCore::Document::Document): Initialize m_fullScreenRenderer.
(WebCore::Document::detach): Call setFullScreenRenderer(0).
(WebCore::Document::nodeWillBeRemoved): Replicate the logic in webkitWillEnterFullScreenForElement.
(WebCore::Document::webkitWillEnterFullScreenForElement): Detach the fullscreen element to cause

a new RenderFullScreen renderer to be created with the new fullscreen element.

(WebCore::Document::webkitDidEnterFullScreenForElement): Notify clients of a fullscreen change

here, rather in "willEnter", to avoid reentrancy problems when clients remove nodes in response
to webkitfullscreenchange events.

(WebCore::Document::webkitWillExitFullScreenForElement): Recalculate the fullscreen element's style.
(WebCore::Document::webkitDidExitFullScreenForElement): Ditto.
(WebCore::Document::setFullScreenRenderer): Accessor for m_fullScreenRenderer.
(WebCore::Document::setFullScreenRendererSize): Set the style on the m_fullScreenRenderer with a new

size; this keeps clients from having to access the renderer's style directly.

(WebCore::Document::setFullScreenRendererBackgroundColor): Ditto.

  • dom/Document.h:

(WebCore::Document::webkitIsFullScreen): Change webkitFullScreen -> webkitIsFullScreen.
(WebCore::Document::fullScreenRenderer): Accessor.

  • dom/Document.idl:
  • dom/Node.cpp:

(WebCore::Node::createRendererIfNeeded): If the document is in fullscreen mode, create a RenderFullScreen

object to insert between the fullscreen element and its parent.

  • page/ChromeClient.h:

(WebCore::ChromeClient::fullScreenRendererChanged): Added.

  • rendering/MediaControlElements.cpp:

(WebCore::MediaControlFullscreenButtonElement::defaultEventHandler): Change webkitFullScreen -> webkitIsFullScreen.

WebCore: Implement WebKit Full Screen support.
https://bugs.webkit.org/show_bug.cgi?id=49481
rdar://problem/8247444

Patch by Jer Noble <jer@kokode.apple.com> on 2010-12-17
Reviewed by Simon Fraser.

This patch introduces a new RenderObject type: RenderFullScreen. The RenderFullScreen renderer
will be used to implement new FullScreen APIs. Because the RenderFullScreen object will be the
parent of the current fullscreen element, the style rules for fullscreen objects must change to
match.

  • WebCore.xcodeproj/project.pbxproj:
  • rendering/RenderFullScreen.cpp: Added.

(RenderFullScreen::setAnimating): Sets the m_isAnimating flag.
(RenderFullScreen::createFullScreenStyle): Returns a new RenderStyle containing the default stye

for RenderFullScreen objects.

  • rendering/RenderFullScreen.h: Added.

(WebCore::RenderFullScreen::isRenderFullScreen): Added. Overrides the RenderObject version.

  • rendering/RenderObject.h:

(WebCore::RenderObject::isRenderFullScreen): Added. Used for type-checking RenderFullScreen objects.

  • css/fullscreen.css: Modified the contained fullscreen styles.

WebKit/mac: Implement WebKit Full Screen support.
https://bugs.webkit.org/show_bug.cgi?id=49481
rdar://problem/8247444

Patch by Jer Noble <jer@kokode.apple.com> on 2011-01-05
Reviewed by Simon Fraser.

Support the new fullscreen Chrome client requests. WebView will pass
through these requests to a WebFullscreenController.

  • WebCoreSupport/WebChromeClient.h: Add fullScreenRendererChanged().
  • WebView/WebView.mm:

(-[WebView _supportsFullScreenForElement:WebCore::]): Check to see if the fullscreen pref has been enabled.
(-[WebView _enterFullScreenForElement:WebCore::]): Create a WebFullScreenController.
(-[WebView _exitFullScreenForElement:WebCore::]): Request that the WebFullScreenController exit fullscreen.
(-[WebView _fullScreenRendererChanged:WebCore::]): Notify the WebFullScreenController that its renderer has changed.

  • WebView/WebViewData.h: Add ivar newFullscreenController.

Patch by Jer Noble <jer@kokode.apple.com> on 2011-01-05
Reviewed by Simon Fraser.

This patch implements the FullScreen APIs using the new RenderFullScreen renderer and the new
Document client APIs. The RenderFullScreen renderer's CALayer is hosted in a new, fullscreen
window, and a custom CAAnimation animates that layer between the initial screen rect of the
full screen element, to its final value. WebFullscreenController will swap the WebView out of
its original window, and into the fullscreen window. The controller will replace the WebView
with a placeholder view, so that if the placeholder moves or resized while the WebView is
absent, the WebView will move back to the correct location when exiting fullscreen.

  • WebView/WebFullscreenController.h: Added.
  • WebView/WebFullscreenController.mm: Added.

(-[WebFullscreenController windowDidExitFullscreen:]): Close the fullscreen window.
(-[WebFullscreenController windowDidEnterFullscreen:]): Swap the webView back into the fullscreen window.
(-[WebFullscreenController animationDidStop:finished:]): Call windowDid{Exit|Enter}FullScreen as appropriate.
(-[WebFullscreenController applicationDidResignActive:]):
(-[WebFullscreenController applicationDidChangeScreenParameters:]): Resize the fullscreen window to match

the new screen parameters.

(-[WebFullscreenController enterFullscreen:]): Set up the animation that will take the fullscreen element

from its original screen rect into fullscreen.

(-[WebFullscreenController exitFullscreen]): Swap the webView back into its original window.

Set up the animation that will take the fullscreen element back into its original screen
rect.

(-[WebFullscreenController _updatePowerAssertions]): Now checks _isAnyMoviePlaying to determine

whether to disable screensaver and sleep.

(-[WebFullscreenController _isAnyMoviePlaying]): Walks through the sub-tree starting at the fullscreen element

looking for HTMLVideoElements; returns whether any are found to be playing.

(-[WebFullscreenController _animationDuration]): Returns the current animation duration, affected by control

and shift keys.

(-[WebFullscreenWindow canBecomeKeyWindow]): Allow the window to become key.
(-[WebFullscreenWindow keyDown:]): Handle the 'Esc' key.
(-[WebFullscreenWindow cancelOperation:]): Request to exit fullscreen.
(-[WebFullscreenWindow rendererLayer]): Convenience accessor.
(-[WebFullscreenWindow setRendererLayer:]): Ditto.
(-[WebFullscreenWindow backgroundLayer]): Ditto.
(-[WebFullscreenWindow animationView]): Ditto.
(MediaEventListener::MediaEventListener): Implements the EventListener protocol.
(MediaEventListener::handleEvent): Tells its delegate to _updatePowerAssertions.

LayoutTests: Implement WebKit Full Screen support.
https://bugs.webkit.org/show_bug.cgi?id=49481
rdar://problem/8247444

Patch by Jer Noble <jer@kokode.apple.com> on 2011-01-05
Reviewed by Simon Fraser.

Update the tests with new API names and spec values.

  • fullscreen/full-screen-api-expected.txt:
  • fullscreen/full-screen-api.html:
  • fullscreen/full-screen-css.html:
  • fullscreen/full-screen-request-expected.txt:
  • fullscreen/full-screen-request.html:
14:32 Changeset [75276] by jamesr@google.com

2011-01-07 James Robinson <jamesr@chromium.org>

Revert "Implement mozilla's animationTime property"
https://bugs.webkit.org/show_bug.cgi?id=51952

This approach isn't quite right.

  • animations/animation-time-expected.txt: Removed.
  • animations/animation-time.html: Removed.
  • animations/script-tests/animation-time.js: Removed.
  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/win/fast/dom/Window/window-property-descriptors-expected.txt:

2011-01-07 James Robinson <jamesr@chromium.org>

Revert "Implement mozilla's animationTime property"
https://bugs.webkit.org/show_bug.cgi?id=51952

This approach isn't quite right.

  • DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::paintInvalidatedRegion):

2011-01-07 James Robinson <jamesr@chromium.org>

Revert "Implement mozilla's animationTime property"
https://bugs.webkit.org/show_bug.cgi?id=51952

This approach isn't quite right.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.exp.in:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • page/DOMWindow.cpp:
  • page/DOMWindow.h:
  • page/DOMWindow.idl:
  • page/Frame.cpp:
  • page/Frame.h:
  • page/Page.cpp: (WebCore::Page::Page):
  • page/Page.h:
  • page/animation/AnimationController.cpp: (WebCore::AnimationControllerPrivate::beginAnimationUpdateTime):
  • page/animation/AnimationTimeController.cpp: Removed.
  • page/animation/AnimationTimeController.h: Removed.

2011-01-07 James Robinson <jamesr@chromium.org>

Revert "Implement mozilla's animationTime property"
https://bugs.webkit.org/show_bug.cgi?id=51952

This approach isn't quite right.

  • public/WebWidget.h:
  • src/WebPopupMenuImpl.cpp:
  • src/WebPopupMenuImpl.h:
  • src/WebViewImpl.cpp:
  • src/WebViewImpl.h:

2011-01-07 James Robinson <jamesr@chromium.org>

Revert "Implement mozilla's animationTime property"
https://bugs.webkit.org/show_bug.cgi?id=51952

This approach isn't quite right.

  • WebView/WebHTMLView.mm: (-[WebHTMLView drawRect:]):
  • WebView/WebView.mm: (layerSyncRunLoopObserverCallBack):

2011-01-07 James Robinson <jamesr@chromium.org>

Revert "Implement mozilla's animationTime property"
https://bugs.webkit.org/show_bug.cgi?id=51952

This approach isn't quite right.

  • WebProcess/WebPage/ChunkedUpdateDrawingArea.cpp: (WebKit::ChunkedUpdateDrawingArea::display): (WebKit::ChunkedUpdateDrawingArea::setSize):
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::drawRect):
  • WebProcess/WebPage/mac/LayerBackedDrawingAreaMac.mm: (WebKit::LayerBackedDrawingArea::syncCompositingLayers):
14:19 Changeset [75275] by cmarrin@apple.com

2011-01-07 Chris Marrin <cmarrin@apple.com>

Unreviewed.

Added one more API to WKSI to get the user data
out of the CACFContext.

  • win/include/WebKitSystemInterface/WebKitSystemInterface.h:
  • win/lib/WebKitSystemInterface.lib:
  • win/lib/WebKitSystemInterface_debug.lib:
14:13 Changeset [75274] by senorblanco@chromium.org

2011-01-07 Stephen White <senorblanco@chromium.org>

Unreviewed; test expectations update.

  • platform/chromium-gpu/test_expectations.txt: Removed some no-longer-failing tests; moved some lines around to match the CPU results.
  • platform/chromium/test_expectations.txt: Bug assignment and cleanup.
14:06 Changeset [75273] by commit-queue@webkit.org

2011-01-07 Jan Erik Hanssen <jhanssen@sencha.com>

Reviewed by Andreas Kling.

[Qt] Black text on black buttons using a dark theme
https://bugs.webkit.org/show_bug.cgi?id=35024

Implement RenderThemeQt::systemColor to apply the correct colors from the current Qt style.

  • platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::systemColor):
  • platform/qt/RenderThemeQt.h:
13:53 Changeset [75272] by commit-queue@webkit.org

2011-01-07 Amruth Raj <amruthraj@motorola.com> and Ravi Phaneendra Kasibhatla <ravi.kasibhatla@motorola.com>

Reviewed by Martin Robinson.

[GTK] WebKit2 GNUmakefile is out of date from trunk
Adding new stub files for compiling on latest revision
https://bugs.webkit.org/show_bug.cgi?id=51883

  • UIProcess/gtk: Added.
  • UIProcess/gtk/TextCheckerGtk.cpp: Added. (WebKit::TextChecker::state): (WebKit::TextChecker::isContinuousSpellCheckingAllowed): (WebKit::TextChecker::setContinuousSpellCheckingEnabled): (WebKit::TextChecker::setGrammarCheckingEnabled): (WebKit::TextChecker::uniqueSpellDocumentTag): (WebKit::TextChecker::closeSpellDocumentWithTag): (WebKit::TextChecker::checkTextOfParagraph): (WebKit::TextChecker::updateSpellingUIWithMisspelledWord): (WebKit::TextChecker::getGuessesForWord): (WebKit::TextChecker::learnWord): (WebKit::TextChecker::ignoreWord):
  • UIProcess/gtk/WebInspectorGtk.cpp: Added. (WebKit::WebInspectorProxy::platformCreateInspectorPage): (WebKit::WebInspectorProxy::platformOpen): (WebKit::WebInspectorProxy::platformClose): (WebKit::WebInspectorProxy::inspectorPageURL):
  • UIProcess/gtk/WebPageProxyGtk.cpp: Added. (WebKit::WebPageProxy::standardUserAgent):
  • UIProcess/gtk/WebPreferencesGtk.cpp: Added. (WebKit::WebPreferences::platformInitializeStore): (WebKit::WebPreferences::platformUpdateStringValueForKey): (WebKit::WebPreferences::platformUpdateBoolValueForKey): (WebKit::WebPreferences::platformUpdateUInt32ValueForKey):
  • WebProcess/WebCoreSupport/gtk/WebContextMenuClientGtk.cpp: Added. (WebKit::WebContextMenuClient::lookUpInDictionary): (WebKit::WebContextMenuClient::isSpeaking): (WebKit::WebContextMenuClient::speak): (WebKit::WebContextMenuClient::stopSpeaking):
  • WebProcess/WebCoreSupport/gtk/WebDatabaseManagerGtk.cpp: Added. (WebKit::WebDatabaseManager::databaseDirectory):
  • WebProcess/WebCoreSupport/gtk/WebPopupMenuGtk.cpp: Added. (WebKit::WebPopupMenu::setUpPlatformData):
  • WebProcess/WebPage/gtk: Added.
  • WebProcess/WebPage/gtk/WebInspectorGtk.cpp: Added. (WebKit::WebInspector::localizedStringsURL):
13:41 Changeset [75271] by enne@google.com

2011-01-05 Adrienne Walker <enne@google.com>

Reviewed by Kenneth Russell.

Add tests for WebGL's lost context events.
https://bugs.webkit.org/show_bug.cgi?id=51492

  • fast/canvas/webgl/context-lost-expected.txt: Added.
  • fast/canvas/webgl/context-lost-restored-expected.txt: Added.
  • fast/canvas/webgl/context-lost-restored.html: Added.
  • fast/canvas/webgl/context-lost.html: Added.

2011-01-05 Adrienne Walker <enne@google.com>

Reviewed by Kenneth Russell.

Add WEBKIT_lose_context WebGL extension.
https://bugs.webkit.org/show_bug.cgi?id=51492

Tests: fast/canvas/webgl/context-lost-restored.html

fast/canvas/webgl/context-lost.html

  • CMakeLists.txt:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSWebGLRenderingContextCustom.cpp: (WebCore::toJS): (WebCore::JSWebGLRenderingContext::getSupportedExtensions):
  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp: (WebCore::toV8Object): (WebCore::V8WebGLRenderingContext::getSupportedExtensionsCallback):
  • html/canvas/WebGLExtension.h:
  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::WebGLRenderingContextRestoreTimer::fired): (WebCore::WebGLRenderingContext::getExtension): (WebCore::WebGLRenderingContext::getSupportedExtensions): (WebCore::WebGLRenderingContext::forceLostContext): (WebCore::WebGLRenderingContext::onLostContext): (WebCore::WebGLRenderingContext::getNumberOfExtensions): (WebCore::WebGLRenderingContext::getExtensionNumber):
  • html/canvas/WebGLRenderingContext.h:
  • html/canvas/WebKitLoseContext.cpp: Copied from WebCore/html/canvas/WebGLExtension.h. (WebCore::WebKitLoseContext::WebKitLoseContext): (WebCore::WebKitLoseContext::~WebKitLoseContext): (WebCore::WebKitLoseContext::getName): (WebCore::WebKitLoseContext::create): (WebCore::WebKitLoseContext::loseContext):
  • html/canvas/WebKitLoseContext.h: Copied from WebCore/html/canvas/WebGLExtension.h.
  • html/canvas/WebKitLoseContext.idl: Copied from WebCore/html/canvas/WebGLExtension.h.
13:28 Changeset [75270] by cmarrin@apple.com

2011-01-07 Chris Marrin <cmarrin@apple.com>

Unreviewed.

Build fix for Chromium. Missing include.

  • page/animation/AnimationBase.cpp:
13:21 Changeset [75269] by aroben@apple.com

Update react-to-vsprops-changes.py after r74855

13:20 Changeset [75268] by aroben@apple.com

Don't ever call ::SetCursor(0)

Doing so makes the cursor disappear from the screen.

Fixes <http://webkit.org/b/52024> Mouse cursor flashes when moving it
around a WKView before the web process has finished launching

Reviewed by Jon Honeycutt.

  • UIProcess/win/WebView.cpp:

(WebKit::WebView::onSetCursor): If we don't have a cursor to set, just
let Windows do its default thing (which is to set the cursor to the
window class's cursor, which in our case is the arrow cursor).
(WebKit::WebView::cursorToShow): Just return 0 when the page has
crashed so that we'll show the default cursor (which is the arrow
cursor). This change has no visible effect, but seems slightly better
conceptually.
(WebKit::WebView::updateNativeCursor): Don't do anything if we don't
have a cursor to set.

13:19 Changeset [75267] by aroben@apple.com

Fill the WKView with white when the web process hasn't drawn anything yet

Fixes <http://webkit.org/b/52023> WKView accumulates pixel garbage
before web process has had a chance to draw anything (if Aero is
disabled)

Reviewed by Jon Honeycutt.

  • UIProcess/ChunkedUpdateDrawingAreaProxy.cpp:

(WebKit::ChunkedUpdateDrawingAreaProxy::paint):

  • UIProcess/ChunkedUpdateDrawingAreaProxy.h:
  • UIProcess/DrawingAreaProxy.h:
  • UIProcess/LayerBackedDrawingAreaProxy.cpp:

(WebKit::LayerBackedDrawingAreaProxy::paint):

  • UIProcess/LayerBackedDrawingAreaProxy.h:
  • UIProcess/TiledDrawingAreaProxy.cpp:

(WebKit::TiledDrawingAreaProxy::paint):

  • UIProcess/TiledDrawingAreaProxy.h:
  • UIProcess/mac/ChunkedUpdateDrawingAreaProxyMac.mm:

(WebKit::ChunkedUpdateDrawingAreaProxy::platformPaint):

  • UIProcess/qt/ChunkedUpdateDrawingAreaProxyQt.cpp:

(WebKit::ChunkedUpdateDrawingAreaProxy::platformPaint):

  • UIProcess/win/ChunkedUpdateDrawingAreaProxyWin.cpp:

(WebKit::ChunkedUpdateDrawingAreaProxy::platformPaint):

  • UIProcess/win/LayerBackedDrawingAreaProxyWin.cpp:

(WebKit::LayerBackedDrawingAreaProxy::paint):
Changed these functions to return a boolean indicating whether we
actually painted anything.

  • UIProcess/win/WebView.cpp:

(WebKit::WebView::onPaintEvent): Fill with white (and don't call
didDraw) when the DrawingAreaProxy isn't able to paint.

13:08 Changeset [75266] by cmarrin@apple.com

2011-01-07 Chris Marrin <cmarrin@apple.com>

Unreviewed.

Build fix.

  • platform/graphics/ca/win/PlatformCALayerWin.cpp:
13:04 Changeset [75265] by barraclough@apple.com

Source/JavaScriptCore: [GTK] Port scrollbar painting to GtkStyleContext
https://bugs.webkit.org/show_bug.cgi?id=52051

Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2011-01-07
Reviewed by Martin Robinson.

  • wtf/gobject/GTypedefs.h: Add GtkStyleContext forward

declaration.

WebCore: Bug 52035 - Unregistering DOMWrapperWorlds is unsafe

Reviewed by Geoff Garen.

The method DOMWrapperWorld::unregisterWorld() effectively calls the DOMWrapperWorld's
destructor early, in order to release wrappers once we know we no longer intend to use them.
Whilst it is okay to have a method to throw away wrappers (assuming we know we're willing to
lose any state stored on them) it is not okay to deregister the world from the JSGlobalData.
A sequence of events that triggers the bug would look like this:

(1) Create a DOMWrapperWorld.
(2) Register a timer in the world.
(3) Call unregisterWorld() on the world.
(4) Timer goes off, code is executed in the world, creates a Node not attached to a Document.
(5) We attempt to lookup a wrapper map for the world on the JSGlobalData, but because we've

called forgetWorld() none exists.

(6) Attempt to add a wrapper to a NULL map.

Fix the problem by not removing the JSGlobalData's wrapper map until the world really goes away.

  • WebCore.exp.in:
  • bindings/js/DOMWrapperWorld.cpp:

(WebCore::DOMWrapperWorld::DOMWrapperWorld):
(WebCore::DOMWrapperWorld::~DOMWrapperWorld):
(WebCore::DOMWrapperWorld::clearWrappers):

  • bindings/js/DOMWrapperWorld.h:

WebKit/mac: Bug 52035 - Unregistering DOMWrapperWorlds is unsafe

Reviewed by Geoff Garen.

The method DOMWrapperWorld::unregisterWorld() effectively calls the DOMWrapperWorld's
destructor early, in order to release wrappers once we know we no longer intend to use them.
Whilst it is okay to have a method to throw away wrappers (assuming we know we're willing to
lose any state stored on them) it is not okay to deregister the world from the JSGlobalData.
A sequence of events that triggers the bug would look like this:

(1) Create a DOMWrapperWorld.
(2) Register a timer in the world.
(3) Call unregisterWorld() on the world.
(4) Timer goes off, code is executed in the world, creates a Node not attached to a Document.
(5) We attempt to lookup a wrapper map for the world on the JSGlobalData, but because we've

called forgetWorld() none exists.

(6) Attempt to add a wrapper to a NULL map.

Fix the problem by not removing the JSGlobalData's wrapper map until the world really goes away.

  • WebView/WebScriptWorld.mm:

(-[WebScriptWorld unregisterWorld]):

WebKit/win: Bug 52035 - Unregistering DOMWrapperWorlds is unsafe

Reviewed by Geoff Garen.

The method DOMWrapperWorld::unregisterWorld() effectively calls the DOMWrapperWorld's
destructor early, in order to release wrappers once we know we no longer intend to use them.
Whilst it is okay to have a method to throw away wrappers (assuming we know we're willing to
lose any state stored on them) it is not okay to deregister the world from the JSGlobalData.
A sequence of events that triggers the bug would look like this:

(1) Create a DOMWrapperWorld.
(2) Register a timer in the world.
(3) Call unregisterWorld() on the world.
(4) Timer goes off, code is executed in the world, creates a Node not attached to a Document.
(5) We attempt to lookup a wrapper map for the world on the JSGlobalData, but because we've

called forgetWorld() none exists.

(6) Attempt to add a wrapper to a NULL map.

Fix the problem by not removing the JSGlobalData's wrapper map until the world really goes away.

  • WebScriptWorld.cpp:

(WebScriptWorld::unregisterWorld):

12:44 Changeset [75264] by cmarrin@apple.com

2011-01-07 Chris Marrin <cmarrin@apple.com>

Unreviewed.

Adding updated WKSI files missed in http://trac.webkit.org/changeset/75262

  • win/include/WebKitSystemInterface/WebKitSystemInterface.h:
  • win/lib/WebKitSystemInterface.lib:
  • win/lib/WebKitSystemInterface_debug.lib:
12:43 Changeset [75263] by senorblanco@chromium.org

2011-01-07 Stephen White <senorblanco@chromium.org>

Unreviewed; new test baselines and updated chromium expectations.

  • platform/chromium-gpu/test_expectations.txt:
  • platform/chromium-linux/fast/gradients/css3-repeating-linear-gradients-expected.checksum: Added.
  • platform/chromium-linux/fast/gradients/css3-repeating-linear-gradients-expected.png: Added.
  • platform/chromium/test_expectations.txt:
12:00 Changeset [75262] by cmarrin@apple.com

2011-01-07 Chris Marrin <cmarrin@apple.com>

Rubber-stamped by Simon Fraser.

Share code between Mac (CA) and Windows (CACF) GraphicsLayer implementations
https://bugs.webkit.org/show_bug.cgi?id=49388

Final step in unifying GraphicsLayer logic across Win and Mac. This
implements the Windows side classes for PlatformCALayer and supporting
classes. Also changed MediaPlayer to use new PlatformCALayerClient
so it can use PlatformCALayer directly rather than a dummy GraphicsLayer.
WKCACFLayerRenderer now does the task of notifying animations of their
start time. Also commented out an assert in AnimationBase because
AnimationController's frame time is not in sync with the new
AnimationTimeController. I've opened a new bug for that issue:

https://bugs.webkit.org/show_bug.cgi?id=52037


This also includes the Mac side changes backed out in
http://trac.webkit.org/changeset/75227.

11:58 BuildBot edited by dglazkov@chromium.org
(diff)
11:46 Changeset [75261] by japhet@chromium.org

2011-01-07 Nate Chapin <japhet@chromium.org>

Reviewed by Darin Fisher.

Let PingLoader send cookies if FrameLoaderClient permits it.
https://bugs.webkit.org/show_bug.cgi?id=51898

Test: http/tests/navigation/ping-cookie.html

  • loader/PingLoader.cpp: (WebCore::PingLoader::PingLoader): Set m_shouldUseCredentialStorage

at load start time, since we won't be able to call
FrameLoaderClient::shouldUseCredentialStorage() later.

  • loader/PingLoader.h: (WebCore::PingLoader::shouldUseCredentialStorage):
11:41 Changeset [75260] by xan@webkit.org

2011-01-07 Xan Lopez <xlopez@igalia.com>

Unreviewed, rolling out r75256.
http://trac.webkit.org/changeset/75256
https://bugs.webkit.org/show_bug.cgi?id=50869

Broke GTK+ canvas tests

  • platform/gtk/Skipped:

2011-01-07 Xan Lopez <xlopez@igalia.com>

Unreviewed, rolling out r75256.
http://trac.webkit.org/changeset/75256
https://bugs.webkit.org/show_bug.cgi?id=50869

Broke GTK+ canvas tests

  • platform/graphics/cairo/PathCairo.cpp: (WebCore::Path::addArc):
11:32 Changeset [75259] by carlosgc@webkit.org

2011-01-07 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Port scrollbar painting to GtkStyleContext
https://bugs.webkit.org/show_bug.cgi?id=52051

  • wtf/gobject/GTypedefs.h: Add GtkStyleContext forward declaration.

2011-01-07 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Port scrollbar painting to GtkStyleContext
https://bugs.webkit.org/show_bug.cgi?id=52051

Use GtkStyleContext API to paint scrollbars when building with
GTK+ 3.x.

No new tests. This should not change functionality.

  • platform/gtk/RenderThemeGtk.h:
  • platform/gtk/RenderThemeGtk3.cpp: (WebCore::RenderThemeGtk::gtkScrollbarStyle):
  • platform/gtk/ScrollbarThemeGtk.cpp:
  • platform/gtk/ScrollbarThemeGtk.h:
  • platform/gtk/ScrollbarThemeGtk2.cpp: (WebCore::gtkStyleSetCallback): (WebCore::ScrollbarThemeGtk::ScrollbarThemeGtk):
  • platform/gtk/ScrollbarThemeGtk3.cpp: (WebCore::gtkStyleChangedCallback): (WebCore::ScrollbarThemeGtk::ScrollbarThemeGtk): (WebCore::ScrollbarThemeGtk::updateThemeProperties): (WebCore::ScrollbarThemeGtk::paintTrackBackground): (WebCore::ScrollbarThemeGtk::paintScrollbarBackground): (WebCore::ScrollbarThemeGtk::paintThumb): (WebCore::ScrollbarThemeGtk::paintButton):
11:31 Changeset [75258] by jberlin@webkit.org

Unreviewed, rolling out r75205.
http://trac.webkit.org/changeset/75205
https://bugs.webkit.org/show_bug.cgi?id=52026
https://bugs.webkit.org/show_bug.cgi?id=52028
https://bugs.webkit.org/show_bug.cgi?id=52029

The Windows 7 Release Test Bots are fixed.

  • platform/win/animations: Removed.
  • platform/win/animations/animation-time-expected.txt: Removed.
  • platform/win/fast/canvas/canvas-fillRect-gradient-shadow-expected.txt: Removed.
  • platform/win/fast/css/css3-nth-tokens-script-expected.txt: Removed.
  • platform/win/fast/css/css3-nth-tokens-style-expected.txt: Removed.
  • platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
11:27 Changeset [75257] by mitz@apple.com

<rdar://problem/8783318> Text emphasis marks should not appear over characters that have ruby annotations
https://bugs.webkit.org/show_bug.cgi?id=51267

Reviewed by Darin Adler.

WebCore:

Test: fast/text/emphasis-avoid-ruby.html

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::placeBoxesInBlockDirection): Use getEmphasisMarkPosition() to check if
there are text emphasis marks.
(WebCore::InlineFlowBox::addTextBoxVisualOverflow): Ditto.
(WebCore::InlineFlowBox::computeOverAnnotationAdjustment): Ditto.

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::getEmphasisMarkPosition): Added. Returns true and sets the emphasis mark
position if the text is style with emphasis marks and there isn’t a ruby annotation that should
suppress them. Otherwise returns false.
(WebCore::InlineTextBox::paint): Use getEmphasisMarkPosition() to check if emphasis marks should
be painted.

  • rendering/InlineTextBox.h:

LayoutTests:

  • fast/text/emphasis-avoid-ruby-expected.checksum: Added.
  • fast/text/emphasis-avoid-ruby-expected.png: Added.
  • fast/text/emphasis-avoid-ruby-expected.txt: Added.
  • fast/text/emphasis-avoid-ruby.html: Added.
11:08 BuildBot edited by dglazkov@chromium.org
(diff)
11:05 Changeset [75256] by alex@webkit.org

2011-01-07 Alejandro G. Castro <alex@igalia.com>

Reviewed by Martin Robinson.

[cairo] Rendering a lot of arcs on top of each other causes time
outs in some tests
https://bugs.webkit.org/show_bug.cgi?id=50869

We avoid the situation where we have to render the same arc
multiple times over itself. Now it renders just one oval and
moves to the end angle.

  • platform/graphics/cairo/PathCairo.cpp: (WebCore::Path::addArc):

2011-01-07 Alejandro G. Castro <alex@igalia.com>

Reviewed by Martin Robinson.

[cairo] Rendering a lot of arcs on top of each other causes time
outs in some tests
https://bugs.webkit.org/show_bug.cgi?id=50869

Unskip canvas-largedraws.html after improving the performance for
big angles.

  • platform/gtk/Skipped:
10:58 Changeset [75255] by carlosgc@webkit.org

2011-01-07 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Port buttons painting to GtkStyleContext
https://bugs.webkit.org/show_bug.cgi?id=51812

Use GtkStyleContext API to paint buttons when building with GTK+
3.x.

No new tests. This should not change functionality.

  • platform/gtk/RenderThemeGtk3.cpp: (WebCore::adjustRectForFocus): (WebCore::RenderThemeGtk::adjustRepaintRect): (WebCore::RenderThemeGtk::paintButton):
10:52 Changeset [75254] by zmo@google.com

2011-01-07 Zhenyao Mo <zmo@google.com>

Unreviewed, build fix.

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::copyTexSubImage2D):
10:43 Changeset [75253] by jberlin@webkit.org

WebKit2: Need WKBundlePagePrivate equivalent of WebKit1's WebViewPrivate's setDefersCallbacks
https://bugs.webkit.org/show_bug.cgi?id=52038

Reviewed by Jon Honeycutt.

The implementation of WebKit1's WebViewPrivate's setDefersCallbacks on both Windows and Mac
calls WebCore::Page::setDefersLoading.

  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageSetDefersLoading):

  • WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setDefersLoading):

  • WebProcess/WebPage/WebPage.h:
10:35 BuildBot edited by dglazkov@chromium.org
(diff)
10:32 BuildBot edited by dglazkov@chromium.org
(diff)
10:31 BuildBot edited by dglazkov@chromium.org
(diff)
10:26 BuildBot edited by dglazkov@chromium.org
(diff)
10:23 BuildBot edited by dglazkov@chromium.org
(diff)
10:19 Changeset [75252] by zmo@google.com

2011-01-06 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

copyTexSubImage2D shouldn't have undefined pixels
https://bugs.webkit.org/show_bug.cgi?id=51559

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::copyTexImage2D): Refactor to share some code with copyTexSubImage2D through helper function clip2D. (WebCore::WebGLRenderingContext::copyTexSubImage2D): Initialize undefined pixels to 0. (WebCore::WebGLRenderingContext::validateTexFuncLevel): Seperate the validation of level from validateTexFuncParameters. (WebCore::WebGLRenderingContext::validateTexFuncParameters): Ditto.
  • html/canvas/WebGLRenderingContext.h:
  • html/canvas/WebGLTexture.cpp: (WebCore::WebGLTexture::getType): Expose the type of a texture.
  • html/canvas/WebGLTexture.h:

2011-01-06 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

copyTexSubImage2D shouldn't have undefined pixels
https://bugs.webkit.org/show_bug.cgi?id=51559

  • fast/canvas/webgl/uninitialized-test-expected.txt:
  • fast/canvas/webgl/uninitialized-test.html: Add test cases for copyTexSubImage2D.
10:16 BuildBot edited by dglazkov@chromium.org
(diff)
09:51 Changeset [75251] by zmo@google.com

2011-01-07 Takashi Toyoshima <toyoshim@google.com>

Reviewed by Kenneth Russell.

cleanupAfterGraphicsCall() is never called in
WebGLRenderingContext::checkFramebufferStatus()
https://bugs.webkit.org/show_bug.cgi?id=51668

No new tests. This is a trivial bug.

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::checkFramebufferStatus):
09:34 Changeset [75250] by mario@webkit.org

2011-01-07 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Chris Fleizach.

GTK: AX: atk tests need to be updated after recent changes
https://bugs.webkit.org/show_bug.cgi?id=51932

Make sure we can always get the right accesssible parent for an
AtkObject when traversing the hierarchy bottom up.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (isRootObject): New function to check whether an AccessibilityObject is the root one or not, according to the latest changes in the hierarchy. (atkParentOfRootObject): Gets the appropriate AtkObject from GTK's GAIL as the parent of the root AtkObject from WebCore. (webkit_accessible_get_parent): Use atkParentOfRootObject. (webkit_accessible_get_index_in_parent): Ditto. (atkRole): Expose AccessibilityObjects with ScrollAreaRole as AtkObject's of role ATK_ROLE_SCROLLED_PANE.

2011-01-07 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Chris Fleizach.

GTK: AX: atk tests need to be updated after recent changes
https://bugs.webkit.org/show_bug.cgi?id=51932

Fix gtk_widget_get_accessible() in WebKitWebView to keep returning
the AtkObject of role ATK_ROLE_DOCUMENT_FRAME.

With the change to support WK2 accessibility, the root object of
the AX hierarchy is different from what GTK expects as the current
hirarchy right now includes a new accessible object as the parent
of the accessible web area (AXScrollView).

  • webkit/webkitwebview.cpp: (webkit_web_view_get_accessible): Return the first child of the wrapper associated to the root accessible object in the document, to keep everything in the GTK port working as it used to be.

Re-enable skipped ATK unit tests now they are passing again.

  • tests/testatk.c: (main): Re-enable skipped tests.
  • tests/testatkroles.c: (main): Ditto.
09:32 Changeset [75249] by zmo@google.com

2011-01-07 Zhenyao Mo <zmo@google.com>

Unreviewed, Mac 32-bit build fix.
Use float instead of double in GL function arguments to avoid implicit type down casting.

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::blendColor): (WebCore::WebGLRenderingContext::clearColor): (WebCore::WebGLRenderingContext::clearDepth): (WebCore::WebGLRenderingContext::depthRange): (WebCore::WebGLRenderingContext::lineWidth): (WebCore::WebGLRenderingContext::polygonOffset): (WebCore::WebGLRenderingContext::sampleCoverage):
  • html/canvas/WebGLRenderingContext.h:
  • html/canvas/WebGLRenderingContext.idl:
09:26 Changeset [75248] by sfalken@apple.com

Set svn:ignore on Visual Studio .user files inside directories that can contain them.

09:07 Changeset [75247] by dbates@webkit.org

2011-01-07 Daniel Bates <dbates@rim.com>

Reviewed by Martin Robinson.

Enable PCRE computed gotos when compiling with RCVT 4.0 or greater in GNU mode
https://bugs.webkit.org/show_bug.cgi?id=52034

Derived from a patch by Eli Fidler.

RVCT 4 or greater in GNU mode supports the computed goto GNU language extension
as per <http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0348c/ch03s07s12.html>.

  • pcre/pcre_exec.cpp: Modified to check for feature, HAVE(COMPUTED_GOTO), instead of hardcoding the GCC compiler.
  • wtf/Platform.h: Define WTF_COMPILER_RVCT4_OR_GREATER if ARMCC_VERSION >= 400000.
08:56 Changeset [75246] by beidson@apple.com

<rdar://problem/8261624> and https://bugs.webkit.org/show_bug.cgi?id=47355
Change WebKit2 session restoring to restore the full back/forward list.

Reviewed by Darin Adler.

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::registerNewWebBackForwardListItem): Let the UIProcess register its own

WebBackForwardListItems in its ID map upon creation.

  • UIProcess/WebProcessProxy.h:
  • UIProcess/cf/WebPageProxyCF.cpp:

(WebKit::WebPageProxy::restoreFromSessionStateData): Register each new list entry in the

UIProcess ID map.

  • WebProcess/WebPage/WebBackForwardListProxy.cpp:

(WebKit::WebBackForwardListProxy::addItemFromUIProcess): Add this method to register UIProcess

created items without doing any of the other work normally associated with adding a new back/forward item
(such as notifying the UIProcess).

  • WebProcess/WebPage/WebBackForwardListProxy.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::restoreSession): Map all of the back/forward list entries from the UIProcess then

cause a load of the current entry.

08:44 Changeset [75245] by senorblanco@chromium.org

2011-01-07 Stephen White <senorblanco@chromium.org>

Unreviewed; new test results and expectations updates.

Created new results for tests which do not fail on chrome win (failing
Safari results were recently checked in). Also assigned bugs to many
of my recent test_expectations updates.

  • platform/chromium-win/animations/animation-time-expected.txt: Added.
  • platform/chromium-win/fast/css/css3-nth-tokens-script-expected.txt: Added.
  • platform/chromium-win/fast/css/css3-nth-tokens-style-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
08:02 Changeset [75244] by aroben@apple.com

Build master fix

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(RunWebKitTests.start): Don't try to concatenate a list and a string.

07:55 Changeset [75243] by senorblanco@chromium.org

2011-01-07 Stephen White <senorblanco@chromium.org>

Unreviewed; chromium test expectations update.

  • platform/chromium/test_expectations.txt: A few tests that were flaky before are failing more frequently now.
05:59 Changeset [75242] by andreas.kling@nokia.com

2011-01-07 Andreas Kling <kling@webkit.org>

Reviewed by Adam Barth.

[Qt] Add selectedHtml function to QWebView
https://bugs.webkit.org/show_bug.cgi?id=35028

Add QWebView::selectedHtml() and QWebPage::selectedHtml()
which return the current selection range's HTML representation.

  • Api/qwebpage.cpp: (QWebPage::selectedHtml):
  • Api/qwebpage.h:
  • Api/qwebview.cpp: (QWebView::selectedText): (QWebView::selectedHtml):
  • Api/qwebview.h:
  • tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::cursorMovements): (tst_QWebPage::textSelection): (tst_QWebPage::crashTests_LazyInitializationOfMainFrame): (tst_QWebPage::findText):
05:58 Changeset [75241] by carlosgc@webkit.org

2011-01-07 Carlos Garcia Campos <cgarcia@igalia.com> and Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Port slider painting to GtkStyleContext
https://bugs.webkit.org/show_bug.cgi?id=51874

Use GtkStyleContext API to paint sliders when building with GTK+
3.x. Also move the code to adjust media slider to its own method
in RenderThemeGtk.cpp since it's common to both gtk 2 and 3.

No new tests. This should not change functionality.

  • platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::adjustMediaSliderThumbSize):
  • platform/gtk/RenderThemeGtk.h:
  • platform/gtk/RenderThemeGtk2.cpp: (WebCore::RenderThemeGtk::adjustSliderThumbSize):
  • platform/gtk/RenderThemeGtk3.cpp: (WebCore::RenderThemeGtk::paintSliderTrack): (WebCore::RenderThemeGtk::paintSliderThumb): (WebCore::RenderThemeGtk::adjustSliderThumbSize):
05:07 Changeset [75240] by commit-queue@webkit.org

2011-01-07 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>

Reviewed by Csaba Osztrogonác.

run-qtwebkit-tests should be able to kill a testsuite.

Add new option in the script that can setup a timeout for a test.
If the test execution takes more then specified time then the test
would be terminated.

[Qt] run-qtwebkit-tests needs timeout
https://bugs.webkit.org/show_bug.cgi?id=51894

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:
  • Scripts/run-qtwebkit-tests:
04:31 Changeset [75239] by ossy@webkit.org

Unreviewed fix after r75233.

Based on idea from Eric Seidel.

Add remote zip file handling to webkitpy.
https://bugs.webkit.org/show_bug.cgi?id=50901

  • Scripts/webkitpy/common/system/fileset.py: Make python 2.5 happy.
03:26 Changeset [75238] by benjamin.poulain@nokia.com

2011-01-07 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Andreas Kling.

[Qt] [WK2] QtWebKit does not build in debug, FileReader.cpp does not compile
https://bugs.webkit.org/show_bug.cgi?id=51992

Add the missing header. CString is used in debug by the calls to LOG().

  • fileapi/FileReader.cpp:
02:25 Changeset [75237] by alex@webkit.org

2011-01-07 Alejandro G. Castro <alex@igalia.com>

Reviewed by Martin Robinson.

Cairo's ContextShadow may mis-render some box shadows
https://bugs.webkit.org/show_bug.cgi?id=51374

The space required for the internal shadow of the corners was not
correctly considered.

  • platform/graphics/cairo/ContextShadowCairo.cpp: (WebCore::ContextShadow::drawRectShadow):

2011-01-07 Alejandro G. Castro <alex@igalia.com>

Reviewed by Martin Robinson.

Cairo's ContextShadow may mis-render some box shadows
https://bugs.webkit.org/show_bug.cgi?id=51374

Added new test to check rectangular tiled shadows.

  • platform/gtk/fast/css/rect-shadow-tiled-expected.checksum: Added.
  • platform/gtk/fast/css/rect-shadow-tiled-expected.png: Added.
  • platform/gtk/fast/css/rect-shadow-tiled-expected.txt: Added.
  • platform/gtk/fast/css/rect-shadow-tiled.html: Added.
01:49 Changeset [75236] by kinuko@chromium.org

2011-01-07 Kinuko Yasuda <kinuko@chromium.org>

Unreviewed; an attempt to fix chromium bot failures by removing failing test line (they must be failing due to modificationTime accuracy error).

  • fast/filesystem/op-get-metadata-expected.txt:
  • fast/filesystem/resources/op-tests-helper.js: (runOperationTest.OperationTestHelper.this.testMetadataSuccessCallback):
01:46 Changeset [75235] by commit-queue@webkit.org

2011-01-07 Shane Stephens <shanestephens@google.com>

Reviewed by Eric Seidel.

svn-apply: should support git binary delta diffs
https://bugs.webkit.org/show_bug.cgi?id=38864

  • Scripts/VCSUtils.pm:
  • Scripts/svn-apply:

01/06/11:

23:31 Changeset [75234] by jparent@chromium.org

2011-01-06 Julie Parent <jparent@chromium.org>

Reviewed by Eric Seidel.

Test Result Server not removing old results.
https://bugs.webkit.org/show_bug.cgi?id=52012

  • TestResultServer/model/jsonresults.py: Fix off-by-one: Truncate if >= num_runs, not just >.
  • TestResultServer/model/jsonresults_unittest.py: Add unit test to test that merging in a new result with the same value as the last result causes previous result to fall off.
23:13 Changeset [75233] by commit-queue@webkit.org

2011-01-06 James Kozianski <koz@chromium.org>

Reviewed by Mihai Parparita.

Add classes to provide a consistent interface to a set of files.
https://bugs.webkit.org/show_bug.cgi?id=50901

These classes allow us to write code that is agnostic to whether a
particular set of files resides in a local directory or in a zip file
on a remote machine.

  • Scripts/webkitpy/common/system/directoryfileset.py: Added.
  • Scripts/webkitpy/common/system/directoryfileset_unittest.py: Added.
  • Scripts/webkitpy/common/system/fileset.py: Added.
  • Scripts/webkitpy/common/system/filesystem.py:
  • Scripts/webkitpy/common/system/filesystem_mock.py:
  • Scripts/webkitpy/common/system/zipfileset.py: Added.
  • Scripts/webkitpy/common/system/zipfileset_unittest.py: Added.
23:07 Changeset [75232] by kinuko@chromium.org

2011-01-06 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by David Levin.

Add layout tests for Entry.getMetadata (FileSystem API)
https://bugs.webkit.org/show_bug.cgi?id=47311

  • fast/filesystem/op-get-metadata-expected.txt: Added.
  • fast/filesystem/op-get-metadata.html: Added.
  • fast/filesystem/resources/op-get-metadata.js: Added.
  • fast/filesystem/resources/op-tests-helper.js: Updated getMetadata implementation.
22:05 Changeset [75231] by mihaip@chromium.org

2011-01-06 Mihai Parparita <mihaip@chromium.org>

Unreviewed; chromium test expectations update.

Remove failing expectations for tests that started to pass after
rebaselining in r75215.

Make failing expectations added by r75213 more specific (failures are
only on Windows and Linux).

  • platform/chromium/test_expectations.txt:
21:32 Changeset [75230] by eric@webkit.org

2011-01-06 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

NetworkTransaction should log the url it is retrying
https://bugs.webkit.org/show_bug.cgi?id=52043

  • Scripts/webkitpy/common/net/networktransaction.py:
  • Scripts/webkitpy/common/net/networktransaction_unittest.py:
21:24 Changeset [75229] by sfalken@apple.com

Windows build fix.
Import os before using it.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:
21:14 Changeset [75228] by abarth@webkit.org

2011-01-06 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

REGRESSION (r74663): ASSERTION FAILED: m_tokenizer->lineNumber() == line.zeroBasedInt()
https://bugs.webkit.org/show_bug.cgi?id=52013

This test case used to trigger an ASSERT. It's unclear to me whether
there's a more direct way to test this fix.

  • fast/parser/line-number-composite-segmented-string-expected.txt: Added.
  • fast/parser/line-number-composite-segmented-string.html: Added.

2011-01-06 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

REGRESSION (r74663): ASSERTION FAILED: m_tokenizer->lineNumber() == line.zeroBasedInt()
https://bugs.webkit.org/show_bug.cgi?id=52013

When excluding line numbers for composite strings, we forgot to exclude
the line number for the current string!

Test: fast/parser/line-number-composite-segmented-string.html

  • platform/text/SegmentedString.cpp: (WebCore::SegmentedString::setExcludeLineNumbers):
20:53 Changeset [75227] by cmarrin@apple.com

2011-01-06 Chris Marrin <cmarrin@apple.com>

Unreviewed.

Back out changes in http://trac.webkit.org/changeset/75199
This breaks the Windows build. Fixing it on that side. Until
then I'll back this out.

20:32 Changeset [75226] by senorblanco@chromium.org

2011-01-06 Stephen White <senorblanco@chromium.org>

Unreviewed; chromium test expectations update.

  • platform/chromium/test_expectations.txt: New test fast/frames/iframe-reparenting-plugins.html failing on windows.
20:22 Changeset [75225] by eric@webkit.org

2011-01-06 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

StyleQueue fails to report errors when patches have many files
https://bugs.webkit.org/show_bug.cgi?id=52042

This is one of at least two errors preventing style error reporting at the moment.
When we moved to passing the list of files to check explicitly,
we started to exceed the 500 character TEXT field limit for our AppEngine model object.
We could change the type of the QueueStatus.message type, or we could
just teach statusserver.py how to clamp values (and warn when it does).
I chose the latter path.

  • Scripts/webkitpy/common/net/statusserver.py:
19:37 Changeset [75224] by mrobinson@webkit.org

2011-01-06 Martin Robinson <mrobinson@igalia.com>

Add new expected results for GTK+. Skip viewport tests which
have results differing from Opera.

  • fast/dom/left-overflow-in-ltr-expected.txt: Added.
  • fast/dom/right-overflow-in-rtl-expected.txt: Added.
  • fast/viewport/viewport-126-expected.txt: Added.
  • fast/viewport/viewport-127-expected.txt: Added.
  • fast/viewport/viewport-65-expected.txt: Added.
  • fast/viewport/viewport-82-expected.txt: Added.
  • fast/viewport/viewport-84-expected.txt: Added.
  • fast/viewport/viewport-87-expected.txt: Added.
  • platform/gtk/Skipped:
  • platform/gtk/css2.1/t040105-import-10-b-expected.checksum: Added.
  • platform/gtk/css2.1/t040105-import-10-b-expected.png: Added.
  • platform/gtk/css2.1/t040105-import-10-b-expected.txt: Added.
  • platform/gtk/fast/block/positioning/rtl-static-positioning-expected.checksum: Added.
  • platform/gtk/fast/block/positioning/rtl-static-positioning-expected.png: Added.
  • platform/gtk/fast/block/positioning/rtl-static-positioning-expected.txt: Added.
  • platform/gtk/fast/block/positioning/rtl-static-positioning-inline-block-expected.checksum: Added.
  • platform/gtk/fast/block/positioning/rtl-static-positioning-inline-block-expected.png: Added.
  • platform/gtk/fast/block/positioning/rtl-static-positioning-inline-block-expected.txt: Added.
  • platform/gtk/fast/block/positioning/table-cell-static-position-expected.checksum: Added.
  • platform/gtk/fast/block/positioning/table-cell-static-position-expected.png: Added.
  • platform/gtk/fast/block/positioning/table-cell-static-position-expected.txt: Added.
  • platform/gtk/fast/blockflow/Kusa-Makura-background-canvas-expected.checksum: Added.
  • platform/gtk/fast/blockflow/Kusa-Makura-background-canvas-expected.png: Added.
  • platform/gtk/fast/blockflow/Kusa-Makura-background-canvas-expected.txt: Added.
  • platform/gtk/fast/blockflow/japanese-rl-text-with-broken-font-expected.checksum: Added.
  • platform/gtk/fast/blockflow/japanese-rl-text-with-broken-font-expected.png: Added.
  • platform/gtk/fast/blockflow/japanese-rl-text-with-broken-font-expected.txt: Added.
  • platform/gtk/fast/blockflow/vertical-align-table-baseline-expected.checksum: Added.
  • platform/gtk/fast/blockflow/vertical-align-table-baseline-expected.png: Added.
  • platform/gtk/fast/blockflow/vertical-align-table-baseline-expected.txt: Added.
  • platform/gtk/fast/blockflow/vertical-baseline-alignment-expected.checksum: Added.
  • platform/gtk/fast/blockflow/vertical-baseline-alignment-expected.png: Added.
  • platform/gtk/fast/blockflow/vertical-baseline-alignment-expected.txt: Added.
  • platform/gtk/fast/css-generated-content/table-before-after-child-add-expected.checksum: Added.
  • platform/gtk/fast/css-generated-content/table-before-after-child-add-expected.png: Added.
  • platform/gtk/fast/css-generated-content/table-before-after-child-add-expected.txt: Added.
  • platform/gtk/fast/css-generated-content/table-cell-before-after-child-add-expected.checksum: Added.
  • platform/gtk/fast/css-generated-content/table-cell-before-after-child-add-expected.png: Added.
  • platform/gtk/fast/css-generated-content/table-cell-before-after-child-add-expected.txt: Added.
  • platform/gtk/fast/css-generated-content/table-row-before-after-child-add-expected.checksum: Added.
  • platform/gtk/fast/css-generated-content/table-row-before-after-child-add-expected.png: Added.
  • platform/gtk/fast/css-generated-content/table-row-before-after-child-add-expected.txt: Added.
  • platform/gtk/fast/css-generated-content/table-table-before-after-child-add-expected.checksum: Added.
  • platform/gtk/fast/css-generated-content/table-table-before-after-child-add-expected.png: Added.
  • platform/gtk/fast/css-generated-content/table-table-before-after-child-add-expected.txt: Added.
  • platform/gtk/fast/css/box-shadow-expected.checksum: Added.
  • platform/gtk/fast/css/box-shadow-expected.png: Added.
  • platform/gtk/fast/css/box-shadow-expected.txt: Added.
  • platform/gtk/fast/css/focus-ring-detached-expected.checksum: Added.
  • platform/gtk/fast/css/focus-ring-detached-expected.png: Added.
  • platform/gtk/fast/css/focus-ring-detached-expected.txt: Added.
  • platform/gtk/fast/css/focus-ring-multiline-expected.checksum: Added.
  • platform/gtk/fast/css/focus-ring-multiline-expected.png: Added.
  • platform/gtk/fast/css/focus-ring-multiline-expected.txt: Added.
  • platform/gtk/fast/css/focus-ring-outline-color-expected.checksum: Added.
  • platform/gtk/fast/css/focus-ring-outline-color-expected.png: Added.
  • platform/gtk/fast/css/focus-ring-outline-color-expected.txt: Added.
  • platform/gtk/fast/css/focus-ring-outline-offset-expected.checksum: Added.
  • platform/gtk/fast/css/focus-ring-outline-offset-expected.png: Added.
  • platform/gtk/fast/css/focus-ring-outline-offset-expected.txt: Added.
  • platform/gtk/fast/css/focus-ring-outline-width-expected.checksum: Added.
  • platform/gtk/fast/css/focus-ring-outline-width-expected.png: Added.
  • platform/gtk/fast/css/focus-ring-outline-width-expected.txt: Added.
  • platform/gtk/fast/forms/placeholder-position-expected.checksum: Added.
  • platform/gtk/fast/forms/placeholder-position-expected.png: Added.
  • platform/gtk/fast/forms/placeholder-position-expected.txt: Added.
  • platform/gtk/fast/html/marquee-scrollamount-expected.checksum: Added.
  • platform/gtk/fast/html/marquee-scrollamount-expected.png: Added.
  • platform/gtk/fast/html/marquee-scrollamount-expected.txt: Added.
  • platform/gtk/fast/images/gray-scale-jpeg-with-color-profile-expected.checksum: Added.
  • platform/gtk/fast/images/gray-scale-jpeg-with-color-profile-expected.png: Added.
  • platform/gtk/fast/images/gray-scale-jpeg-with-color-profile-expected.txt: Added.
  • platform/gtk/fast/images/imagemap-focus-ring-outline-color-expected.txt: Added.
  • platform/gtk/fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map-expected.checksum: Added.
  • platform/gtk/fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map-expected.png: Added.
  • platform/gtk/fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map-expected.txt: Added.
  • platform/gtk/fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map-expected.txt: Added.
  • platform/gtk/fast/images/imagemap-focus-ring-zoom-expected.txt: Added.
  • platform/gtk/fast/multicol/span/anonymous-before-child-parent-crash-expected.checksum: Added.
  • platform/gtk/fast/multicol/span/anonymous-before-child-parent-crash-expected.png: Added.
  • platform/gtk/fast/multicol/span/anonymous-before-child-parent-crash-expected.txt: Added.
  • platform/gtk/fast/multicol/span/anonymous-split-block-crash-expected.checksum: Added.
  • platform/gtk/fast/multicol/span/anonymous-split-block-crash-expected.png: Added.
  • platform/gtk/fast/multicol/span/anonymous-split-block-crash-expected.txt: Added.
  • platform/gtk/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.checksum: Added.
  • platform/gtk/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.png: Added.
  • platform/gtk/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt: Added.
  • platform/gtk/fast/overflow/overflow-rtl-vertical-expected.checksum: Added.
  • platform/gtk/fast/overflow/overflow-rtl-vertical-expected.png: Added.
  • platform/gtk/fast/overflow/overflow-rtl-vertical-expected.txt: Added.
  • platform/gtk/fast/overflow/overflow-update-transform-expected.checksum: Added.
  • platform/gtk/fast/overflow/overflow-update-transform-expected.png: Added.
  • platform/gtk/fast/overflow/overflow-update-transform-expected.txt: Added.
  • platform/gtk/fast/ruby/nested-ruby-expected.checksum: Added.
  • platform/gtk/fast/ruby/nested-ruby-expected.png: Added.
  • platform/gtk/fast/ruby/nested-ruby-expected.txt: Added.
  • platform/gtk/fast/text/emphasis-expected.checksum: Added.
  • platform/gtk/fast/text/emphasis-expected.png: Added.
  • platform/gtk/fast/text/emphasis-expected.txt: Added.
  • platform/gtk/fast/text/emphasis-vertical-expected.checksum: Added.
  • platform/gtk/fast/text/emphasis-vertical-expected.png: Added.
  • platform/gtk/fast/text/emphasis-vertical-expected.txt: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.checksum: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.png: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.checksum: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.png: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.txt: Added.
  • platform/gtk/svg/custom/image-rescale-clip-expected.checksum: Added.
  • platform/gtk/svg/custom/image-rescale-clip-expected.png: Added.
  • platform/gtk/svg/custom/image-rescale-clip-expected.txt: Added.
  • platform/gtk/svg/custom/image-rescale-scroll-expected.checksum: Added.
  • platform/gtk/svg/custom/image-rescale-scroll-expected.png: Added.
  • platform/gtk/svg/custom/image-rescale-scroll-expected.txt: Added.
  • platform/gtk/svg/dom/SVGPathSegList-cloning-expected.checksum: Added.
  • platform/gtk/svg/dom/SVGPathSegList-cloning-expected.png: Added.
  • platform/gtk/svg/dom/SVGPathSegList-cloning-expected.txt: Added.
  • platform/gtk/svg/dom/SVGPathSegList-segment-modification-expected.checksum: Added.
  • platform/gtk/svg/dom/SVGPathSegList-segment-modification-expected.png: Added.
  • platform/gtk/svg/dom/SVGPathSegList-segment-modification-expected.txt: Added.
  • platform/gtk/svg/dom/SVGPathSegList-xml-dom-synchronization2-expected.checksum: Added.
  • platform/gtk/svg/dom/SVGPathSegList-xml-dom-synchronization2-expected.png: Added.
  • platform/gtk/svg/dom/SVGPathSegList-xml-dom-synchronization2-expected.txt: Added.
  • platform/gtk/svg/filters/feColorMatrix-offset-expected.checksum: Added.
  • platform/gtk/svg/filters/feColorMatrix-offset-expected.png: Added.
  • platform/gtk/svg/filters/feColorMatrix-offset-expected.txt: Added.
18:59 Changeset [75223] by senorblanco@chromium.org

2011-01-06 Stephen White <senorblanco@chromium.org>

Unreviewed; yet another test expectations update.

  • platform/chromium/test_expectations.txt:
18:52 Changeset [75222] by ojan@chromium.org

2011-01-06 Ojan Vafai <ojan@chromium.org>

Fix line context when replying to comments.

  • code-review.js:
18:35 Changeset [75221] by senorblanco@chromium.org

2011-01-06 Stephen White <senorblanco@chromium.org>

Unreviewed; test expectations update.

Add new results for new tests introduced in r75097.

  • platform/chromium-mac/fast/gradients/css3-repeating-linear-gradients-expected.checksum: Added.
  • platform/chromium-mac/fast/gradients/css3-repeating-linear-gradients-expected.png: Added.
  • platform/chromium-win/fast/gradients/css3-repeating-linear-gradients-expected.checksum: Added.
  • platform/chromium-win/fast/gradients/css3-repeating-linear-gradients-expected.png: Added.
  • platform/chromium/test_expectations.txt:


18:25 Changeset [75220] by robert@webkit.org

2011-01-06 Robert Hogan <robert@webkit.org>

[Qt] Update expected results after r75177

Unreviewed, update expected results.

  • platform/qt/fast/dom/prototype-inheritance-expected.txt:
18:11 Changeset [75219] by mrobinson@webkit.org

2011-01-06 Martin Robinson <mrobinson@igalia.com>

Reviewed by Adam Barth.

fast/dom/Window/window-postmessage-clone.html may fail on platforms with larger fonts
https://bugs.webkit.org/show_bug.cgi?id=52027

Move the console output div after the file input control in
fast/dom/Window/window-postmessage-clone.html so that console
text does not push it outside of the viewport.

  • fast/dom/Window/window-postmessage-clone-expected.txt: Updated results to match new text output.
  • fast/dom/Window/window-postmessage-clone.html: Moved console div.
18:06 Changeset [75218] by mrobinson@webkit.org

2011-01-06 Martin Robinson <mrobinson@igalia.com>

Update GTK+-specific results after r75177.

  • platform/gtk/fast/dom/prototype-inheritance-expected.txt: Update results.
17:58 Changeset [75217] by commit-queue@webkit.org

2011-01-06 Jenn Braithwaite <jennb@chromium.org>

Reviewed by Dmitry Titov.

When a live frame is moved between pages, some plug-in DOM methods cease to function
https://bugs.webkit.org/show_bug.cgi?id=45770

  • fast/frames/iframe-reparenting-plugins-expected.txt: Added.
  • fast/frames/iframe-reparenting-plugins.html: Added.
  • fast/frames/resources/iframe-reparenting-plugins-iframe-content.html: Added.
  • fast/frames/resources/iframe-reparenting-plugins-new-page.html: Added.

2011-01-06 Jenn Braithwaite <jennb@chromium.org>

Reviewed by Dmitry Titov.

When a live frame is moved between pages, some plug-in DOM methods cease to function
https://bugs.webkit.org/show_bug.cgi?id=45770

Test: fast/frames/iframe-reparenting-plugins.html

  • page/Frame.cpp: (WebCore::Frame::~Frame): (WebCore::Frame::addObserver): (WebCore::Frame::removeObserver):
  • page/Frame.h: (WebCore::FrameDestructionObserver::~FrameDestructionObserver): Added observer to be notified when frame is destroyed.
  • page/Page.cpp: (WebCore::Page::~Page): (WebCore::Page::refreshPlugins): PluginData no longer stores page pointer.
  • plugins/DOMMimeType.cpp: (WebCore::DOMMimeType::DOMMimeType): (WebCore::DOMMimeType::~DOMMimeType): (WebCore::DOMMimeType::enabledPlugin):
  • plugins/DOMMimeType.h: (WebCore::DOMMimeType::create): (WebCore::DOMMimeType::frameDestroyed): Store frame instead of page pointer in DOMMimeType.
  • plugins/DOMMimeTypeArray.cpp: (WebCore::DOMMimeTypeArray::item): (WebCore::DOMMimeTypeArray::namedItem): Provide frame to create DOMMimeType.
  • plugins/DOMPlugin.cpp: (WebCore::DOMPlugin::DOMPlugin): (WebCore::DOMPlugin::~DOMPlugin): (WebCore::DOMPlugin::item): (WebCore::DOMPlugin::namedItem):
  • plugins/DOMPlugin.h: (WebCore::DOMPlugin::create): (WebCore::DOMPlugin::frameDestroyed): Store frame instead of page pointer in DOMPlugin.
  • plugins/DOMPluginArray.cpp: (WebCore::DOMPluginArray::item): (WebCore::DOMPluginArray::namedItem): Provide frame to create DOMPlugin.
  • plugins/PluginData.cpp: (WebCore::PluginData::PluginData): (WebCore::PluginData::initPlugins):
  • plugins/PluginData.h: No longer stores a pointer to the page. Added page parameter to initPlugins.
  • plugins/PluginDataNone.cpp: (WebCore::PluginData::initPlugins):
  • plugins/chromium/PluginDataChromium.cpp: (WebCore::PluginData::initPlugins):
  • plugins/gtk/PluginDataGtk.cpp: (WebCore::PluginData::initPlugins):
  • plugins/wx/PluginDataWx.cpp: (WebCore::PluginData::initPlugins): Updated platforms to add (unused) page parameter to initPlugins.
17:55 Changeset [75216] by senorblanco@chromium.org

2011-01-06 Stephen White <senorblanco@chromium.org>

Unreviewed; test expectations update.

  • platform/chromium-gpu/test_expectations.txt: Remove duplicate expectations.
17:45 Changeset [75215] by mihaip@chromium.org

2011-01-06 Mihai Parparita <mihaip@chromium.org>

Unreviewed, test expectation update.

Add mac-leopard baselines for tests that currently have Snow Leopard
baselines in platform/mac.

  • platform/mac-leopard/fast/multicol/client-rects-expected.checksum:
  • platform/mac-leopard/fast/multicol/client-rects-expected.png: Added.
  • platform/mac-leopard/fast/multicol/column-break-with-balancing-expected.checksum: Added.
  • platform/mac-leopard/fast/multicol/column-break-with-balancing-expected.png: Added.
  • platform/mac-leopard/fast/multicol/float-multicol-expected.checksum: Added.
  • platform/mac-leopard/fast/multicol/float-multicol-expected.png: Added.
  • platform/mac-leopard/fast/multicol/float-paginate-complex-expected.checksum: Added.
  • platform/mac-leopard/fast/multicol/float-paginate-complex-expected.png: Added.
  • platform/mac-leopard/fast/multicol/float-paginate-expected.checksum: Added.
  • platform/mac-leopard/fast/multicol/float-paginate-expected.png: Added.
  • platform/mac-leopard/fast/multicol/layers-in-multicol-expected.checksum: Added.
  • platform/mac-leopard/fast/multicol/layers-in-multicol-expected.png: Added.
  • platform/mac-leopard/fast/multicol/layers-split-across-columns-expected.checksum: Added.
  • platform/mac-leopard/fast/multicol/layers-split-across-columns-expected.png: Added.
  • platform/mac-leopard/fast/multicol/paginate-block-replaced-expected.checksum: Added.
  • platform/mac-leopard/fast/multicol/paginate-block-replaced-expected.png: Added.
  • platform/mac-leopard/fast/multicol/span/anonymous-style-inheritance-expected.checksum: Added.
  • platform/mac-leopard/fast/multicol/span/anonymous-style-inheritance-expected.png: Added.
  • platform/mac-leopard/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.checksum: Added.
  • platform/mac-leopard/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png: Added.
  • platform/mac-leopard/fast/multicol/span/span-as-nested-columns-child-expected.checksum: Added.
  • platform/mac-leopard/fast/multicol/span/span-as-nested-columns-child-expected.png: Added.
  • platform/mac-leopard/fast/multicol/table-vertical-align-expected.checksum: Added.
  • platform/mac-leopard/fast/multicol/table-vertical-align-expected.png: Added.
  • platform/mac-leopard/fast/repaint/overflow-scroll-body-appear-expected.checksum: Added.
  • platform/mac-leopard/fast/repaint/overflow-scroll-body-appear-expected.png: Added.
17:43 Changeset [75214] by zmo@google.com

2011-01-05 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Define GC3D types to match GL types and use them in GraphicsContext3D
https://bugs.webkit.org/show_bug.cgi?id=45557

  • src/GraphicsContext3DChromium.cpp: (WebCore::GraphicsContext3DInternal::bindAttribLocation): (WebCore::GraphicsContext3DInternal::bufferData): (WebCore::GraphicsContext3DInternal::bufferSubData): (WebCore::GraphicsContext3DInternal::getActiveAttrib): (WebCore::GraphicsContext3DInternal::getActiveUniform): (WebCore::GraphicsContext3DInternal::getAttribLocation): (WebCore::GraphicsContext3DInternal::getString): (WebCore::GraphicsContext3DInternal::getUniformLocation): (WebCore::GraphicsContext3DInternal::texImage2D): (WebCore::GraphicsContext3DInternal::texSubImage2D): (WebCore::GraphicsContext3DInternal::uniform1fv): (WebCore::GraphicsContext3DInternal::uniform1iv): (WebCore::GraphicsContext3DInternal::uniform2fv): (WebCore::GraphicsContext3DInternal::uniform2iv): (WebCore::GraphicsContext3DInternal::uniform3fv): (WebCore::GraphicsContext3DInternal::uniform3iv): (WebCore::GraphicsContext3DInternal::uniform4fv): (WebCore::GraphicsContext3DInternal::uniform4iv): (WebCore::GraphicsContext3DInternal::uniformMatrix2fv): (WebCore::GraphicsContext3DInternal::uniformMatrix3fv): (WebCore::GraphicsContext3DInternal::uniformMatrix4fv):
  • src/GraphicsContext3DInternal.h:

2011-01-05 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Define GC3D types to match GL types and use them in GraphicsContext3D
https://bugs.webkit.org/show_bug.cgi?id=45557

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::readPixels): (WebCore::WebGLRenderingContext::validateTexFuncData):
  • platform/graphics/GraphicsContext3D.cpp: (WebCore::GraphicsContext3D::texImage2DResourceSafe): (WebCore::GraphicsContext3D::computeFormatAndTypeParameters): (WebCore::GraphicsContext3D::extractImageData): (WebCore::GraphicsContext3D::extractTextureData):
  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/cg/GraphicsContext3DCG.cpp: (WebCore::GraphicsContext3D::getImageData):
  • platform/graphics/gpu/SharedGraphicsContext3D.cpp: (WebCore::SharedGraphicsContext3D::enable): (WebCore::SharedGraphicsContext3D::disable): (WebCore::SharedGraphicsContext3D::clear): (WebCore::SharedGraphicsContext3D::drawArrays): (WebCore::SharedGraphicsContext3D::getError): (WebCore::SharedGraphicsContext3D::getIntegerv): (WebCore::SharedGraphicsContext3D::createFramebuffer): (WebCore::SharedGraphicsContext3D::createTexture): (WebCore::SharedGraphicsContext3D::deleteFramebuffer): (WebCore::SharedGraphicsContext3D::deleteTexture): (WebCore::SharedGraphicsContext3D::framebufferTexture2D): (WebCore::SharedGraphicsContext3D::texParameteri): (WebCore::SharedGraphicsContext3D::texImage2D): (WebCore::SharedGraphicsContext3D::texSubImage2D): (WebCore::SharedGraphicsContext3D::readPixels): (WebCore::SharedGraphicsContext3D::setActiveTexture): (WebCore::SharedGraphicsContext3D::bindTexture): (WebCore::SharedGraphicsContext3D::bindFramebuffer):
  • platform/graphics/gpu/SharedGraphicsContext3D.h:
  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp: (WebCore::GraphicsContext3D::activeTexture): (WebCore::GraphicsContext3D::attachShader): (WebCore::GraphicsContext3D::bindAttribLocation): (WebCore::GraphicsContext3D::bindBuffer): (WebCore::GraphicsContext3D::bindFramebuffer): (WebCore::GraphicsContext3D::bindRenderbuffer): (WebCore::GraphicsContext3D::bindTexture): (WebCore::GraphicsContext3D::blendColor): (WebCore::GraphicsContext3D::blendEquation): (WebCore::GraphicsContext3D::blendEquationSeparate): (WebCore::GraphicsContext3D::blendFunc): (WebCore::GraphicsContext3D::blendFuncSeparate): (WebCore::GraphicsContext3D::bufferData): (WebCore::GraphicsContext3D::bufferSubData): (WebCore::GraphicsContext3D::checkFramebufferStatus): (WebCore::GraphicsContext3D::clearColor): (WebCore::GraphicsContext3D::clear): (WebCore::GraphicsContext3D::clearDepth): (WebCore::GraphicsContext3D::clearStencil): (WebCore::GraphicsContext3D::colorMask): (WebCore::GraphicsContext3D::compileShader): (WebCore::GraphicsContext3D::copyTexImage2D): (WebCore::GraphicsContext3D::copyTexSubImage2D): (WebCore::GraphicsContext3D::cullFace): (WebCore::GraphicsContext3D::depthFunc): (WebCore::GraphicsContext3D::depthMask): (WebCore::GraphicsContext3D::depthRange): (WebCore::GraphicsContext3D::detachShader): (WebCore::GraphicsContext3D::disable): (WebCore::GraphicsContext3D::disableVertexAttribArray): (WebCore::GraphicsContext3D::drawArrays): (WebCore::GraphicsContext3D::drawElements): (WebCore::GraphicsContext3D::enable): (WebCore::GraphicsContext3D::enableVertexAttribArray): (WebCore::GraphicsContext3D::framebufferRenderbuffer): (WebCore::GraphicsContext3D::framebufferTexture2D): (WebCore::GraphicsContext3D::frontFace): (WebCore::GraphicsContext3D::generateMipmap): (WebCore::GraphicsContext3D::getActiveAttrib): (WebCore::GraphicsContext3D::getActiveUniform): (WebCore::GraphicsContext3D::getAttachedShaders): (WebCore::GraphicsContext3D::getAttribLocation): (WebCore::GraphicsContext3D::getError): (WebCore::GraphicsContext3D::getString): (WebCore::GraphicsContext3D::hint): (WebCore::GraphicsContext3D::isBuffer): (WebCore::GraphicsContext3D::isEnabled): (WebCore::GraphicsContext3D::isFramebuffer): (WebCore::GraphicsContext3D::isProgram): (WebCore::GraphicsContext3D::isRenderbuffer): (WebCore::GraphicsContext3D::isShader): (WebCore::GraphicsContext3D::isTexture): (WebCore::GraphicsContext3D::lineWidth): (WebCore::GraphicsContext3D::linkProgram): (WebCore::GraphicsContext3D::pixelStorei): (WebCore::GraphicsContext3D::polygonOffset): (WebCore::GraphicsContext3D::readPixels): (WebCore::GraphicsContext3D::renderbufferStorage): (WebCore::GraphicsContext3D::sampleCoverage): (WebCore::GraphicsContext3D::scissor): (WebCore::GraphicsContext3D::stencilFunc): (WebCore::GraphicsContext3D::stencilFuncSeparate): (WebCore::GraphicsContext3D::stencilMask): (WebCore::GraphicsContext3D::stencilMaskSeparate): (WebCore::GraphicsContext3D::stencilOp): (WebCore::GraphicsContext3D::stencilOpSeparate): (WebCore::GraphicsContext3D::texParameterf): (WebCore::GraphicsContext3D::texParameteri): (WebCore::GraphicsContext3D::uniform1f): (WebCore::GraphicsContext3D::uniform1fv): (WebCore::GraphicsContext3D::uniform2f): (WebCore::GraphicsContext3D::uniform2fv): (WebCore::GraphicsContext3D::uniform3f): (WebCore::GraphicsContext3D::uniform3fv): (WebCore::GraphicsContext3D::uniform4f): (WebCore::GraphicsContext3D::uniform4fv): (WebCore::GraphicsContext3D::uniform1i): (WebCore::GraphicsContext3D::uniform1iv): (WebCore::GraphicsContext3D::uniform2i): (WebCore::GraphicsContext3D::uniform2iv): (WebCore::GraphicsContext3D::uniform3i): (WebCore::GraphicsContext3D::uniform3iv): (WebCore::GraphicsContext3D::uniform4i): (WebCore::GraphicsContext3D::uniform4iv): (WebCore::GraphicsContext3D::uniformMatrix2fv): (WebCore::GraphicsContext3D::uniformMatrix3fv): (WebCore::GraphicsContext3D::uniformMatrix4fv): (WebCore::GraphicsContext3D::useProgram): (WebCore::GraphicsContext3D::validateProgram): (WebCore::GraphicsContext3D::vertexAttrib1f): (WebCore::GraphicsContext3D::vertexAttrib1fv): (WebCore::GraphicsContext3D::vertexAttrib2f): (WebCore::GraphicsContext3D::vertexAttrib2fv): (WebCore::GraphicsContext3D::vertexAttrib3f): (WebCore::GraphicsContext3D::vertexAttrib3fv): (WebCore::GraphicsContext3D::vertexAttrib4f): (WebCore::GraphicsContext3D::vertexAttrib4fv): (WebCore::GraphicsContext3D::vertexAttribPointer): (WebCore::GraphicsContext3D::viewport): (WebCore::GraphicsContext3D::getBooleanv): (WebCore::GraphicsContext3D::getBufferParameteriv): (WebCore::GraphicsContext3D::getFloatv): (WebCore::GraphicsContext3D::getFramebufferAttachmentParameteriv): (WebCore::GraphicsContext3D::getIntegerv): (WebCore::GraphicsContext3D::getProgramiv): (WebCore::GraphicsContext3D::getProgramInfoLog): (WebCore::GraphicsContext3D::getRenderbufferParameteriv): (WebCore::GraphicsContext3D::getShaderiv): (WebCore::GraphicsContext3D::getShaderInfoLog): (WebCore::GraphicsContext3D::getTexParameterfv): (WebCore::GraphicsContext3D::getTexParameteriv): (WebCore::GraphicsContext3D::getUniformfv): (WebCore::GraphicsContext3D::getUniformiv): (WebCore::GraphicsContext3D::getUniformLocation): (WebCore::GraphicsContext3D::getVertexAttribfv): (WebCore::GraphicsContext3D::getVertexAttribiv): (WebCore::GraphicsContext3D::getVertexAttribOffset): (WebCore::GraphicsContext3D::texImage2D): (WebCore::GraphicsContext3D::texSubImage2D): (WebCore::GraphicsContext3D::createBuffer): (WebCore::GraphicsContext3D::createFramebuffer): (WebCore::GraphicsContext3D::createProgram): (WebCore::GraphicsContext3D::createRenderbuffer): (WebCore::GraphicsContext3D::createShader): (WebCore::GraphicsContext3D::createTexture): (WebCore::GraphicsContext3D::deleteBuffer): (WebCore::GraphicsContext3D::deleteFramebuffer): (WebCore::GraphicsContext3D::deleteProgram): (WebCore::GraphicsContext3D::deleteRenderbuffer): (WebCore::GraphicsContext3D::deleteShader): (WebCore::GraphicsContext3D::deleteTexture): (WebCore::GraphicsContext3D::sizeInBytes): (WebCore::GraphicsContext3D::synthesizeGLError):
  • platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3D::activeTexture): (WebCore::GraphicsContext3D::attachShader): (WebCore::GraphicsContext3D::getAttachedShaders): (WebCore::GraphicsContext3D::bindAttribLocation): (WebCore::GraphicsContext3D::bindBuffer): (WebCore::GraphicsContext3D::bindFramebuffer): (WebCore::GraphicsContext3D::bindRenderbuffer): (WebCore::GraphicsContext3D::bindTexture): (WebCore::GraphicsContext3D::blendColor): (WebCore::GraphicsContext3D::blendEquation): (WebCore::GraphicsContext3D::blendEquationSeparate): (WebCore::GraphicsContext3D::blendFunc): (WebCore::GraphicsContext3D::blendFuncSeparate): (WebCore::GraphicsContext3D::bufferData): (WebCore::GraphicsContext3D::bufferSubData): (WebCore::GraphicsContext3D::checkFramebufferStatus): (WebCore::GraphicsContext3D::clearColor): (WebCore::GraphicsContext3D::clear): (WebCore::GraphicsContext3D::clearDepth): (WebCore::GraphicsContext3D::clearStencil): (WebCore::GraphicsContext3D::colorMask): (WebCore::GraphicsContext3D::compileShader): (WebCore::GraphicsContext3D::copyTexImage2D): (WebCore::GraphicsContext3D::copyTexSubImage2D): (WebCore::GraphicsContext3D::cullFace): (WebCore::GraphicsContext3D::depthFunc): (WebCore::GraphicsContext3D::depthMask): (WebCore::GraphicsContext3D::depthRange): (WebCore::GraphicsContext3D::detachShader): (WebCore::GraphicsContext3D::disable): (WebCore::GraphicsContext3D::disableVertexAttribArray): (WebCore::GraphicsContext3D::drawArrays): (WebCore::GraphicsContext3D::drawElements): (WebCore::GraphicsContext3D::enable): (WebCore::GraphicsContext3D::enableVertexAttribArray): (WebCore::GraphicsContext3D::framebufferRenderbuffer): (WebCore::GraphicsContext3D::framebufferTexture2D): (WebCore::GraphicsContext3D::frontFace): (WebCore::GraphicsContext3D::generateMipmap): (WebCore::GraphicsContext3D::getActiveAttrib): (WebCore::GraphicsContext3D::getActiveUniform): (WebCore::GraphicsContext3D::getAttribLocation): (WebCore::GraphicsContext3D::getError): (WebCore::GraphicsContext3D::getString): (WebCore::GraphicsContext3D::hint): (WebCore::GraphicsContext3D::isBuffer): (WebCore::GraphicsContext3D::isEnabled): (WebCore::GraphicsContext3D::isFramebuffer): (WebCore::GraphicsContext3D::isProgram): (WebCore::GraphicsContext3D::isRenderbuffer): (WebCore::GraphicsContext3D::isShader): (WebCore::GraphicsContext3D::isTexture): (WebCore::GraphicsContext3D::linkProgram): (WebCore::GraphicsContext3D::pixelStorei): (WebCore::GraphicsContext3D::polygonOffset): (WebCore::GraphicsContext3D::readPixels): (WebCore::GraphicsContext3D::renderbufferStorage): (WebCore::GraphicsContext3D::sampleCoverage): (WebCore::GraphicsContext3D::scissor): (WebCore::GraphicsContext3D::stencilFunc): (WebCore::GraphicsContext3D::stencilFuncSeparate): (WebCore::GraphicsContext3D::stencilMask): (WebCore::GraphicsContext3D::stencilMaskSeparate): (WebCore::GraphicsContext3D::stencilOp): (WebCore::GraphicsContext3D::stencilOpSeparate): (WebCore::GraphicsContext3D::texParameterf): (WebCore::GraphicsContext3D::texParameteri): (WebCore::GraphicsContext3D::uniform1f): (WebCore::GraphicsContext3D::uniform1fv): (WebCore::GraphicsContext3D::uniform2f): (WebCore::GraphicsContext3D::uniform2fv): (WebCore::GraphicsContext3D::uniform3f): (WebCore::GraphicsContext3D::uniform3fv): (WebCore::GraphicsContext3D::uniform4f): (WebCore::GraphicsContext3D::uniform4fv): (WebCore::GraphicsContext3D::uniform1i): (WebCore::GraphicsContext3D::uniform1iv): (WebCore::GraphicsContext3D::uniform2i): (WebCore::GraphicsContext3D::uniform2iv): (WebCore::GraphicsContext3D::uniform3i): (WebCore::GraphicsContext3D::uniform3iv): (WebCore::GraphicsContext3D::uniform4i): (WebCore::GraphicsContext3D::uniform4iv): (WebCore::GraphicsContext3D::uniformMatrix2fv): (WebCore::GraphicsContext3D::uniformMatrix3fv): (WebCore::GraphicsContext3D::uniformMatrix4fv): (WebCore::GraphicsContext3D::useProgram): (WebCore::GraphicsContext3D::validateProgram): (WebCore::GraphicsContext3D::vertexAttrib1f): (WebCore::GraphicsContext3D::vertexAttrib1fv): (WebCore::GraphicsContext3D::vertexAttrib2f): (WebCore::GraphicsContext3D::vertexAttrib2fv): (WebCore::GraphicsContext3D::vertexAttrib3f): (WebCore::GraphicsContext3D::vertexAttrib3fv): (WebCore::GraphicsContext3D::vertexAttrib4f): (WebCore::GraphicsContext3D::vertexAttrib4fv): (WebCore::GraphicsContext3D::vertexAttribPointer): (WebCore::GraphicsContext3D::viewport): (WebCore::GraphicsContext3D::getBooleanv): (WebCore::GraphicsContext3D::getBufferParameteriv): (WebCore::GraphicsContext3D::getFloatv): (WebCore::GraphicsContext3D::getFramebufferAttachmentParameteriv): (WebCore::GraphicsContext3D::getIntegerv): (WebCore::GraphicsContext3D::getProgramiv): (WebCore::GraphicsContext3D::getProgramInfoLog): (WebCore::GraphicsContext3D::getRenderbufferParameteriv): (WebCore::GraphicsContext3D::getShaderiv): (WebCore::GraphicsContext3D::getShaderInfoLog): (WebCore::GraphicsContext3D::getShaderSource): (WebCore::GraphicsContext3D::getTexParameterfv): (WebCore::GraphicsContext3D::getTexParameteriv): (WebCore::GraphicsContext3D::getUniformfv): (WebCore::GraphicsContext3D::getUniformiv): (WebCore::GraphicsContext3D::getUniformLocation): (WebCore::GraphicsContext3D::getVertexAttribfv): (WebCore::GraphicsContext3D::getVertexAttribiv): (WebCore::GraphicsContext3D::getVertexAttribOffset): (WebCore::GraphicsContext3D::texImage2D): (WebCore::GraphicsContext3D::texSubImage2D): (WebCore::GraphicsContext3D::createBuffer): (WebCore::GraphicsContext3D::createFramebuffer): (WebCore::GraphicsContext3D::createProgram): (WebCore::GraphicsContext3D::createRenderbuffer): (WebCore::GraphicsContext3D::createShader): (WebCore::GraphicsContext3D::createTexture): (WebCore::GraphicsContext3D::deleteBuffer): (WebCore::GraphicsContext3D::deleteFramebuffer): (WebCore::GraphicsContext3D::deleteProgram): (WebCore::GraphicsContext3D::deleteRenderbuffer): (WebCore::GraphicsContext3D::deleteShader): (WebCore::GraphicsContext3D::deleteTexture): (WebCore::GraphicsContext3D::sizeInBytes): (WebCore::GraphicsContext3D::synthesizeGLError): (WebCore::GraphicsContext3D::getImageData):
  • platform/graphics/skia/GraphicsContext3DSkia.cpp: (WebCore::GraphicsContext3D::getImageData):
17:03 Changeset [75213] by senorblanco@chromium.org

2011-01-06 Stephen White <senorblanco@chromium.org>

Unreviewed; chromium test expectations update.

  • platform/chromium/test_expectations.txt: Add some expected "failing" tests post-r75205.
16:47 Changeset [75212] by senorblanco@chromium.org

2011-01-06 Stephen White <senorblanco@chromium.org>

Unreviewed; chromium test expectations update.

  • platform/chromium/test_expectations.txt: Remove duplicate expectations.
16:39 Changeset [75211] by sfalken@apple.com

2011-01-06 Steve Falkenburg <sfalken@apple.com>

Reviewed by Stephanie Lewis.


Fix syntax error in script.

Windows bots need to archive/unarchive builds to/from configuration-specific directories
https://bugs.webkit.org/show_bug.cgi?id=51996

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:
16:38 Changeset [75210] by barraclough@apple.com

Bug 52021 - zeroDouble broken on ARMv7

Reviewed by Darin Adler.

The bug here is that zeroDouble was working incorrectly,
leading to op_loop_if_true failing - specifically in the
case where the value being checked is 0.0 encoded as a
double (rather than an integer immediate).

Additionally this patch removes a redundant duplicate compare
in some (many) case.

  • assembler/ARMv7Assembler.h:

(JSC::ARMv7Assembler::vcmp_F64):
(JSC::ARMv7Assembler::vcmpz_F64):

  • assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::branchDoubleNonZero):
(JSC::MacroAssemblerARM::branchDoubleZeroOrNaN):

  • assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::branchDouble):
(JSC::MacroAssemblerARMv7::branchDoubleNonZero):
(JSC::MacroAssemblerARMv7::branchDoubleZeroOrNaN):
(JSC::MacroAssemblerARMv7::compare32):

  • assembler/MacroAssemblerMIPS.h:

(JSC::MacroAssemblerMIPS::branchDoubleNonZero):
(JSC::MacroAssemblerMIPS::branchDoubleZeroOrNaN):

  • assembler/MacroAssemblerX86Common.h:

(JSC::MacroAssemblerX86Common::branchDoubleNonZero):
(JSC::MacroAssemblerX86Common::branchDoubleZeroOrNaN):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_jfalse):
(JSC::JIT::emit_op_jtrue):

16:24 Changeset [75209] by mrobinson@webkit.org

2011-01-06 Martin Robinson <mrobinson@igalia.com>

Reviewed by Eric Seidel.

[GTK] Initial build support for WebGL
https://bugs.webkit.org/show_bug.cgi?id=51716

  • configure.ac: Add a configure option for WebGL.

2011-01-06 Martin Robinson <mrobinson@igalia.com>

Reviewed by Eric Seidel.

[GTK] Initial build support for WebGL
https://bugs.webkit.org/show_bug.cgi?id=51716

Add initial build support for WebGL and insert bits of implementation
necessary for clean compilation into GraphicsContext3D.

No new tests. This is just a build change.

  • GNUmakefile.am: Add missing files to the source lists.
  • platform/graphics/GraphicsContext3D.h: Include IntSize.h as it's used below. Include typedefs necessary for WebGL on GTK+ and consolidate typdefs which are the same across different platforms. X11 headers define the VERSION symbol, so it's necessary to undefine it, since it's used as an enum value.
16:17 Changeset [75208] by msaboff@apple.com

2011-01-06 Michael Saboff <msaboff@apple.com>

Reviewed by Gavin Barraclough.

Enhancement: Add Regexp Debug Compare between JIT and Interpreter
https://bugs.webkit.org/show_bug.cgi?id=51834

2011-01-06 Michael Saboff <msaboff@apple.com>

Reviewed by Gavin Barraclough.

Added debug code to compare the results of JIT regexp with
interpreted regexp and displays discrepencies. This debug code is
controlled by the ENABLE_YARR_JIT_DEBUG macro in wtf/Platform.h and
is only valid if ENABLE_YARR_JIT is enabled.

Fixed a discovered problem in RegExp::printTraceData, changing
m_pattern to the getter pattern().
Also deleted an extraneous semicolon.

Enhancement: Add Regexp Debug Compare between JIT and Interpreter
https://bugs.webkit.org/show_bug.cgi?id=51834

  • runtime/RegExp.cpp: (JSC::RegExp::compile): (JSC::RegExp::match): (JSC::RegExp::printTraceData):
  • wtf/Platform.h:
16:08 Changeset [75207] by commit-queue@webkit.org

2011-01-06 Helder Correia <helder@sencha.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] GraphicsContext::drawConvexPolygon() has unnecessary code for shadow
https://bugs.webkit.org/show_bug.cgi?id=52014

The function is only used by RenderObject to draw box sides.
The shadow branch is never used and thus can be removed.

No new tests are necessary.

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::drawConvexPolygon):
15:39 Changeset [75206] by laszlo.1.gombos@nokia.com

2011-01-06 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Make sure touch is disabled in the minimal configuration
https://bugs.webkit.org/show_bug.cgi?id=51316

No new tests as there is no new functionality.

  • features.pri:
15:29 Changeset [75205] by aroben@apple.com

Add/update Windows-specific test results for recent regressions

Bugs:

http://webkit.org/b/52026
http://webkit.org/b/52028
http://webkit.org/b/52029

  • platform/win/animations/animation-time-expected.txt: Added.
  • platform/win/fast/canvas/canvas-fillRect-gradient-shadow-expected.txt: Added.
  • platform/win/fast/css/css3-nth-tokens-script-expected.txt: Added.
  • platform/win/fast/css/css3-nth-tokens-style-expected.txt: Added.
  • platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
15:29 Changeset [75204] by aroben@apple.com

Update Windows results after r75177

  • platform/win/fast/dom/prototype-inheritance-expected.txt:
15:07 Changeset [75203] by laszlo.1.gombos@nokia.com

2011-01-06 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Unreviewed, fixing WinCE build after r75196.

WinCE port does not (yet) support NPAPI.

  • Scripts/build-webkit:
14:55 Changeset [75202] by mrobinson@webkit.org

2011-01-06 Martin Robinson <mrobinson@igalia.com>

Reviewed by Eric Seidel.

[GTK] Freetype backend does not support WOFF
https://bugs.webkit.org/show_bug.cgi?id=51904

  • platform/gtk/Skipped: Unskip passing WOFF test. Add results.
  • platform/gtk/fast/css/font-face-woff-expected.checksum: Added.
  • platform/gtk/fast/css/font-face-woff-expected.png: Added.
  • platform/gtk/fast/css/font-face-woff-expected.txt: Added.

2011-01-06 Martin Robinson <mrobinson@igalia.com>

Reviewed by Eric Seidel.

[GTK] Freetype backend does not support WOFF
https://bugs.webkit.org/show_bug.cgi?id=51904

  • CMakeListsEfl.txt: Add WOFF support to the sources list.
  • GNUmakefile.am: Add WOFF support to the sources list.
  • platform/graphics/freetype/FontCustomPlatformDataFreeType.cpp: (WebCore::createFontCustomPlatformData): Call the WOFF decoder when appropriate. (WebCore::FontCustomPlatformData::supportsFormat): Advertise support for WOFF.
14:51 Changeset [75201] by mrobinson@webkit.org

2011-01-06 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

GTK: AX: atk tests need to be updated after recent changes
https://bugs.webkit.org/show_bug.cgi?id=51932

Skip ATK unit tests until we can look into what is causing these failures.

  • tests/testatk.c: (main): Skip all tests.
  • tests/testatkroles.c: (main): Ditto.
14:39 Changeset [75200] by simonjam@chromium.org

2011-01-06 James Simonsen <simonjam@chromium.org>

Reviewed by Darin Fisher.

[Web Timing] Remove vendor prefix
https://bugs.webkit.org/show_bug.cgi?id=48922

  • fast/dom/Window/window-properties-performance-expected.txt: Test replaceability.
  • fast/dom/Window/window-properties-performance.html: Ditto.
  • fast/dom/Window/window-properties.html: Rename to performance.
  • fast/dom/resources/navigation-type-matches-querystring.html: Ditto.
  • fast/dom/script-tests/prototype-inheritance.js: Ditto.
  • fast/dom/script-tests/webtiming-document-open.js: Ditto.
  • fast/dom/script-tests/webtiming-navigate-within-document.js: Ditto.
  • fast/dom/script-tests/webtiming.js: Ditto.
  • http/tests/misc/resources/webtiming-one-redirect.html: Ditto.
  • http/tests/misc/resources/webtiming-two-redirects.html: Ditto.

2011-01-06 James Simonsen <simonjam@chromium.org>

Reviewed by Darin Fisher.

[Web Timing] Remove vendor prefix
https://bugs.webkit.org/show_bug.cgi?id=48922

  • page/DOMWindow.cpp: (WebCore::DOMWindow::performance): Rename to performance.
  • page/DOMWindow.h:
  • page/DOMWindow.idl: Rename to performance and make replaceable.

2011-01-06 James Simonsen <simonjam@chromium.org>

Reviewed by Darin Fisher.

[Web Timing] Remove vendor prefix
https://bugs.webkit.org/show_bug.cgi?id=48922

  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::performance): Rename to performance.
14:26 Changeset [75199] by cmarrin@apple.com

2011-01-06 Chris Marrin <cmarrin@apple.com>

Reviewed by Simon Fraser.

Share code between Mac (CA) and Windows (CACF) GraphicsLayer implementations
https://bugs.webkit.org/show_bug.cgi?id=49388

Changed PlatformCALayer API. Added PlatformCALayerClient abstract class which is
used to communicate from PlatformCALayer to the owner. This replaces passing
GraphicsLayerCA pointer when creating PlatformCALayer. It also includes the
API that used to be in PlatformCALayerLayout. GraphicsLayerCA now implements
the PlatformCALayerClient API.

This change has little impact on the Mac side but makes the Windows
interface simpler, especially when handling video layers on Windows.

  • WebCore.xcodeproj/project.pbxproj:
  • config.h:
  • platform/graphics/GraphicsLayer.h: (WebCore::GraphicsLayer::layerDidDisplay): (WebCore::GraphicsLayer::showDebugBorders): (WebCore::GraphicsLayer::showRepaintCounter):
  • platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::platformCALayerAnimationStarted): (WebCore::GraphicsLayerCA::setContentsToImage): (WebCore::GraphicsLayerCA::setContentsToMedia): (WebCore::GraphicsLayerCA::layerDidDisplay): (WebCore::GraphicsLayerCA::updateSublayerList):
  • platform/graphics/ca/GraphicsLayerCA.h: (WebCore::GraphicsLayerCA::platformCALayerLayoutSublayersOfLayer): (WebCore::GraphicsLayerCA::platformCALayerRespondsToLayoutChanges): (WebCore::GraphicsLayerCA::platformCALayerContentsOrientation): (WebCore::GraphicsLayerCA::platformCALayerPaintContents): (WebCore::GraphicsLayerCA::platformCALayerShowDebugBorders): (WebCore::GraphicsLayerCA::platformCALayerShowRepaintCounter): (WebCore::GraphicsLayerCA::platformCALayerIncrementRepaintCount): (WebCore::GraphicsLayerCA::platformCALayerContentsOpaque): (WebCore::GraphicsLayerCA::platformCALayerDrawsContent): (WebCore::GraphicsLayerCA::platformCALayerLayerDidDisplay): (WebCore::GraphicsLayerCA::platformCALayer):
  • platform/graphics/ca/PlatformCALayer.h: (WebCore::PlatformCALayer::owner): (WebCore::PlatformCALayer::animationStarted):
  • platform/graphics/ca/PlatformCALayerClient.h: Added. (WebCore::PlatformCALayerClient::~PlatformCALayerClient):
  • platform/graphics/ca/mac/PlatformCALayerMac.mm: (PlatformCALayer::setOwner): (PlatformCALayer::create): (PlatformCALayer::PlatformCALayer): (PlatformCALayer::contents): (PlatformCALayer::setContents):
  • platform/graphics/mac/WebGLLayer.mm: (-[WebGLLayer display]):
  • platform/graphics/mac/WebLayer.h:
  • platform/graphics/mac/WebLayer.mm: (drawLayerContents): (setLayerNeedsDisplayInRect): (-[WebLayer setNeedsDisplay]): (-[WebLayer display]):
  • platform/graphics/mac/WebTiledLayer.mm: (-[WebTiledLayer setNeedsDisplay]): (-[WebTiledLayer display]):
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::showDebugBorders): (WebCore::RenderLayerBacking::showRepaintCounter):
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::ensureRootPlatformLayer):
  • rendering/RenderLayerCompositor.h: (WebCore::RenderLayerCompositor::compositorShowDebugBorders): (WebCore::RenderLayerCompositor::compositorShowRepaintCounter): (WebCore::RenderLayerCompositor::notifyAnimationStarted): (WebCore::RenderLayerCompositor::notifySyncRequired): (WebCore::RenderLayerCompositor::paintContents): (WebCore::RenderLayerCompositor::showDebugBorders): (WebCore::RenderLayerCompositor::showRepaintCounter):
14:07 Changeset [75198] by tonyg@chromium.org

2011-01-06 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Eric Seidel.

Allow framesets after hidden inputs
https://bugs.webkit.org/show_bug.cgi?id=51998

  • html5lib/resources/webkit01.dat: Demonstrate that the value of the type attribute matters. An input with no type is tested in tests19.dat.

2011-01-06 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Eric Seidel.

Allow framesets after hidden inputs
https://bugs.webkit.org/show_bug.cgi?id=51998

This implements the HTML5 spec update in response to:
http://www.w3.org/Bugs/Public/show_bug.cgi?id=11156

  • html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processStartTagForInBody):
14:01 Changeset [75197] by xan@webkit.org

2011-01-06 Xan Lopez <xlopez@igalia.com>

Reviewed by Darin Adler.

File::Spec->rel2abs in sunspider-compare-results mangles parameters
https://bugs.webkit.org/show_bug.cgi?id=52015

  • Scripts/sunspider-compare-results: call rel2abs on our arguments after the platform has been detected, otherwise the script will mangle things like '--gtk' into '/a/path/--gtk', breaking the detection.
13:49 Changeset [75196] by laszlo.1.gombos@nokia.com

2011-01-06 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Eric Seidel.

Add ENABLE_NETSCAPE_PLUGIN_API, ENABLE_ORIENTATION_EVENTS and ENABLE_TOUCH_EVENTS flags to build-webkit
https://bugs.webkit.org/show_bug.cgi?id=51346

  • Scripts/build-webkit:
13:49 Changeset [75195] by zmo@google.com

2010-12-29 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

vertexAttribPointer should raise INVALID_OPERATION if stride/offset is not multiple of the type size
https://bugs.webkit.org/show_bug.cgi?id=51725

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::vertexAttribPointer):

2010-12-29 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

vertexAttribPointer should raise INVALID_OPERATION if stride/offset is not multiple of the type size
https://bugs.webkit.org/show_bug.cgi?id=51725

  • fast/canvas/webgl/gl-vertexattribpointer-expected.txt:
  • fast/canvas/webgl/gl-vertexattribpointer.html: Sync with khronos.
13:42 Changeset [75194] by zmo@google.com

2011-01-06 Zhenyao Mo <zmo@google.com>

Unreviewed, add glsl-conformance.html to test_expectations.txt temporarily.

  • platform/chromium-gpu/test_expectations.txt:
  • platform/chromium/test_expectations.txt:
13:41 Changeset [75193] by inferno@chromium.org

Merge 75168

BUG=68558

13:32 Changeset [75192] by sfalken@apple.com

2011-01-06 Steve Falkenburg <sfalken@apple.com>

Reviewed by Adam Roben.

Windows bots need to archive/unarchive builds to/from configuration-specific directories
https://bugs.webkit.org/show_bug.cgi?id=51996


After the configuration directory change, we were archiving the incorrect directory for
build product, so we were running tests on the wrong binaries.


This change archives the correct directory, and also unarchives it into a configuration-
specific directory.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg: Use a configuration-specific directory on Windows.
  • BuildSlaveSupport/built-product-archive: Unarchive/archive to/from proper directory.
13:30 Changeset [75191] by eric@webkit.org

2011-01-06 Eric Seidel <eric@webkit.org>

Reviewed by Mihai Parparita.

commit-queue mentions "Text diff mismatch" 4 times instead of once per failure
https://bugs.webkit.org/show_bug.cgi?id=52002

See an example of this here:
https://bugs.webkit.org/show_bug.cgi?id=51314#c2

It's due to the fact that we pass around TestFailure() instance
objects and yet expect them to all compare to be the same.

This is bad. We should either have shared instances of these values
or we should just pass around the class names. There are already hacks
in place to make TestFailure objects pass equality tests, I just added
a hash implementation so they can be used in sets as expected.

  • Scripts/webkitpy/common/net/layouttestresults_unittest.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
13:19 Changeset [75190] by paroga@webkit.org

2011-01-06 Patrick Gansterer <paroga@webkit.org>

Reviewed by Eric Seidel.

[WINCE] Remove JSC::g_stackBase
https://bugs.webkit.org/show_bug.cgi?id=51779

  • wtf/StackBounds.cpp:

2011-01-06 Patrick Gansterer <paroga@webkit.org>

Reviewed by Eric Seidel.

[WINCE] Remove JSC::g_stackBase
https://bugs.webkit.org/show_bug.cgi?id=51779

  • platform/wince/SharedTimerWinCE.cpp: (WebCore::TimerWindowWndProc):
12:54 Changeset [75189] by robert@webkit.org

2011-01-06 Robert Hogan <robert@webkit.org>

Reviewed by Antonio Gomes.

[Qt] Introduce QDRTNode for passing WebCore::Node across JS bridge

This allows LayoutTestController to pass WebCore::Node back to
layout tests.

Also amend nodesFromRect-links-and-text.html and
nodesFromRect-inner-documents.html so that they do not produce
platform-specific results.

Unskip:
fast/dom/nodesFromRect-links-and-text.html
fast/dom/nodesFromRect-inner-documents.html

https://bugs.webkit.org/show_bug.cgi?id=48957

  • fast/dom/nodesFromRect-inner-documents-expected.txt:
  • fast/dom/nodesFromRect-inner-documents.html:
  • fast/dom/nodesFromRect-links-and-text-expected.txt:
  • fast/dom/nodesFromRect-links-and-text.html:
  • fast/dom/resources/nodesFromRect.js: (check): (getTopFor): (getBottomFor):
  • platform/qt/Skipped:

2011-01-06 Robert Hogan <robert@webkit.org>

Reviewed by Antonio Gomes.

[Qt] Introduce QDRTNode for passing WebCore::Node across JS bridge

This allows LayoutTestController to pass WebCore::Node back to
layout tests.

Also amend nodesFromRect-links-and-text.html and
nodesFromRect-inner-documents.html so that they do not produce
platform-specific results.

Unskip:
fast/dom/nodesFromRect-links-and-text.html
fast/dom/nodesFromRect-inner-documents.html

https://bugs.webkit.org/show_bug.cgi?id=48957

  • bridge/qt/qt_runtime.cpp: (JSC::Bindings::QtDRTNodeRuntime::create): (JSC::Bindings::QtDRTNodeRuntime::get): (JSC::Bindings::convertValueToQVariant): (JSC::Bindings::convertQVariantToValue):

2011-01-06 Robert Hogan <robert@webkit.org>

Reviewed by Antonio Gomes.

[Qt] Introduce QDRTNode for passing WebCore::Node across JS bridge

This allows LayoutTestController to pass WebCore::Node back to
layout tests.

Also amend nodesFromRect-links-and-text.html and
nodesFromRect-inner-documents.html so that they do not produce
platform-specific results.

Unskip:
fast/dom/nodesFromRect-links-and-text.html
fast/dom/nodesFromRect-inner-documents.html

https://bugs.webkit.org/show_bug.cgi?id=48957

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (QDRTNode::QDRTNode): (QDRTNode::~QDRTNode): (DumpRenderTreeSupportQt::nodesFromRect):
  • WebCoreSupport/DumpRenderTreeSupportQt.h:
12:53 Changeset [75188] by commit-queue@webkit.org

2011-01-06 Joone Hur <joone.hur@collabora.co.uk>

Reviewed by Eric Seidel.

WML Parser should treat line/column number in a consistent way
https://bugs.webkit.org/show_bug.cgi?id=51601

Add the equality operators to TextPosition class.

  • wtf/text/TextPosition.h: (WTF::TextPosition::operator==): Added. (WTF::TextPosition::operator!=): Added. (WTF::TextPosition::belowRangePosition): Use belowBase() instead of base(). (WTF::ZeroBasedNumber::operator==): Added. (WTF::ZeroBasedNumber::operator!=): Added. (WTF::OneBasedNumber::operator==): Added. (WTF::OneBasedNumber::operator!=): Added.

2011-01-06 Joone Hur <joone.hur@collabora.co.uk>

Reviewed by Eric Seidel.

WML Parser should treat line/column number in a consistent way
https://bugs.webkit.org/show_bug.cgi?id=51601

XML Parser treats line/column number as 1-based values, but WML ErrorHandler treat them as 0-based.
Therefore, this patch allows WML ErrorHandler to use 1-based values.

  • dom/XMLDocumentParser.cpp: (WebCore::XMLDocumentParser::handleError): Treat line/column number as 1 based values.
  • dom/XMLDocumentParser.h: Make textPositionOneBased public and Add TextPosition1(m_lastErrorPosition) to keep error line/column number.
  • dom/XMLDocumentParserLibxml2.cpp: (WebCore::XMLDocumentParser::XMLDocumentParser): Initialize m_lastErrorPosition.
  • dom/XMLDocumentParserQt.cpp: (WebCore::XMLDocumentParser::XMLDocumentParser): Initialize m_lastErrorPosition.
  • wml/WMLErrorHandling.cpp: (WebCore::reportWMLError): Use 1 based value instead of 0 based value to report error line/column number.
12:49 Changeset [75187] by aroben@apple.com

Always show the arrow cursor when the web process has crashed

Fixes <http://webkit.org/b/52006> WKView shows a stale cursor when the
web process crashes

Reviewed by Ada Chan.

  • UIProcess/win/WebView.cpp:

(WebKit::WebView::processDidCrash):
(WebKit::WebView::didRelaunchProcess):
Update the cursor to reflect the new state.

(WebKit::WebView::cursorToShow): Always show the arrow cursor when the
web process has crashed.

12:49 Changeset [75186] by aroben@apple.com

Reduce code duplication in WebView::updateNativeCursor

Fixes <http://webkit.org/b/52005> It's not easy to add new behavior to
WebView::updateNativeCursor

Reviewed by Ada Chan.

  • UIProcess/win/WebView.cpp:

(WebKit::WebView::cursorToShow): Moved code to choose a cursor here...
(WebKit::WebView::updateNativeCursor): ...from here.

  • UIProcess/win/WebView.h: Added cursorToShow.
12:48 Changeset [75185] by aroben@apple.com

Make WKView fill with white when the web process has crashed

Previously we would just draw whatever we had last drawn into the
WKView (i.e., a stale picture of the web page), which was confusing
(because the web page would mysteriously not respond to input) and ugly
(because it wouldn't behave properly if the window was resized).

Fixes <http://webkit.org/b/52004> WKView keeps painting a stale
picture of the web page when the web process crashes

Reviewed by Ada Chan.

  • UIProcess/win/WebView.cpp:

(WebKit::WebView::onPaintEvent): Ported code from -[WKView drawRect:]
to fill with white if the page is invalid or has no DrawingArea. As a
bonus, also ported the call to WebPageProxy::didDraw from that method.

(WebKit::WebView::processDidCrash):
(WebKit::WebView::didRelaunchProcess):
Invalidate our window so that we'll redraw with white or the new page.

12:48 Changeset [75184] by aroben@apple.com

Make WKViews work on Windows after a crashed web process gets relaunched

Fixes <http://webkit.org/b/52001> Relaunching the web process fails to
revivify WKViews on Windows

Reviewed by Ada Chan.

  • UIProcess/win/WebView.cpp:

(WebKit::WebView::didRelaunchProcess): Implemented by porting code from
-[WKView _didRelaunchProcess].

12:47 Changeset [75183] by aroben@apple.com

Remove WebView::m_rect

It was only used in the constructor, and wasn't even kept up-to-date as
the WebView's size changed.

Fixes <http://webkit.org/b/52000> WebView::m_rect is unnecessary

Reviewed by Ada Chan.

  • UIProcess/win/WebView.cpp:
  • UIProcess/win/WebView.h:
12:46 Changeset [75182] by aroben@apple.com

Remove some dead code from WKCACFLayerRenderer

Fixes <http://webkit.org/b/51954> WKCACFLayerRenderer has dead and
redundant code for reacting to changes to the layer tree

Reviewed by Sam Weinig.

  • platform/graphics/win/WKCACFLayerRenderer.cpp:
  • platform/graphics/win/WKCACFLayerRenderer.h:

Removed didFlushContext and the HashMap it depended on. We react to
changes to the layer tree in layerTreeDidChange instead.

12:44 Changeset [75181] by senorblanco@chromium.org

2011-01-06 Stephen White <senorblanco@chromium.org>

Unreviewed; test expectations update.

Update test_expectations.txt files to reflect reality on the canaries.

  • platform/chromium-gpu/test_expectations.txt:
  • platform/chromium/test_expectations.txt:
12:39 Changeset [75180] by paroga@webkit.org

2011-01-06 Patrick Gansterer <paroga@webkit.org>

Reviewed by Gavin Barraclough.

[WINCE] Determine stack extent
https://bugs.webkit.org/show_bug.cgi?id=26276

Scan the stack for writeable pages and use the limits.

  • wtf/StackBounds.cpp: (WTF::detectGrowingDownward): (WTF::isPageWritable): (WTF::getLowerStackBound): (WTF::getUpperStackBound): (WTF::StackBounds::initialize):
12:39 Changeset [75179] by cfleizach@apple.com

AX: "AXExpanded" not exposed on most ARIA roles that use aria-expanded
https://bugs.webkit.org/show_bug.cgi?id=51995

Reviewed by Beth Dakin.

WebCore:

Test: platform/mac/accessibility/aria-expanded-standard-items.html

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::supportsARIAExpanded):
(WebCore::AccessibilityObject::isExpanded):

  • accessibility/AccessibilityObject.h:
  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::isVisited):

  • accessibility/AccessibilityRenderObject.h:
  • accessibility/mac/AccessibilityObjectWrapper.mm:

(-[AccessibilityObjectWrapper additionalAccessibilityAttributeNames]):

LayoutTests:

  • platform/mac/accessibility/aria-expanded-standard-items-expected.txt: Added.
  • platform/mac/accessibility/aria-expanded-standard-items.html: Added.
12:34 Changeset [75178] by evan@chromium.org

2011-01-06 Evan Martin <evan@chromium.org>

Reviewed by Tony Chang.

[gdb] handle inaccessible memory and UChar*
https://bugs.webkit.org/show_bug.cgi?id=52003

To pretty-print a UChar*, we just grope around in the memory
looking for a terminating NUL. We need to handle the exception
that can occur when we poke into an invalid location.

Additionally, the logic for choosing which pretty-printer would
early return before hitting the point where we'd use the UChar*
printer. (Did this ever work? How did it regress?)

  • gdb/webkit.py:
12:28 Changeset [75177] by abarth@webkit.org

2011-01-06 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

prototype-inheritance prints FAIL when it shouldn't
https://bugs.webkit.org/show_bug.cgi?id=52007

Before this patch, we were testing the prototypes of primitive values,
but the rules for primitive values are different than the rules for
objects. Primitive values get their prototypes from the current
lexical scope when they get boxed. This test is designed to test that
objects get their prototypes from their original holder.

In this patch, we skip testing non-object/non-functions. We can add
another test for primitives if we think that would be valuable.

  • fast/dom/prototype-inheritance-expected.txt:
  • fast/dom/script-tests/prototype-inheritance.js:
12:20 Changeset [75176] by jamesr@google.com

2011-01-06 James Robinson <jamesr@chromium.org>

Update expectations for tests that enumerate properties on the window to reflect newly added property.

  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
11:33 Changeset [75175] by zmo@google.com

2010-12-28 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Must generate INVALID_VALUE errors for strings containing out-of-range characters
https://bugs.webkit.org/show_bug.cgi?id=50929

  • html/canvas/WebGLRenderingContext.cpp: Validate characters according to GLSL ES 1.0 spec section 3.1. (WebCore::WebGLRenderingContext::bindAttribLocation): (WebCore::WebGLRenderingContext::getAttribLocation): (WebCore::WebGLRenderingContext::getUniformLocation): (WebCore::WebGLRenderingContext::shaderSource): (WebCore::WebGLRenderingContext::validateString): Helper function to perform the character validation.
  • html/canvas/WebGLRenderingContext.h: Declare validateString().

2010-12-28 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Must generate INVALID_VALUE errors for strings containing out-of-range characters
https://bugs.webkit.org/show_bug.cgi?id=50929

  • fast/canvas/webgl/invalid-passed-params-expected.txt: Add test cases for invalid characters.
  • fast/canvas/webgl/invalid-passed-params.html: Ditto.
11:27 Changeset [75174] by bweinstein@apple.com

WebKit2: Should be able to call into injected bundle to ask if we should allow resource loads
https://bugs.webkit.org/show_bug.cgi?id=51969

Reviewed by Ada Chan.

Tools:

Add shouldLoadResourceForFrame to WTR::InjectedBundlePage.

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::InjectedBundlePage):
(WTR::InjectedBundlePage::shouldLoadResourceForFrame): Stub implementation.

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:

WebKit2:

Add the ability to call into the injected bundle to ask if we should allow resource loads.
If the injected bundle says we should cancel, we clear out the ResourceRequest that was
passed into willSendRequest, which cancels the resource load.

  • WebProcess/InjectedBundle/API/c/WKBundlePage.h: Add the new callback for allowing/cancelling

resource loads.

  • WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:

(WebKit::InjectedBundlePageLoaderClient::shouldLoadResourceForFrame): Calls through to the client.

  • WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchWillSendRequest): Ask the InjectedBundlePageLoaderClient if we

should load the resource or not.

11:23 Changeset [75173] by inferno@chromium.org

2011-01-06 Abhishek Arya <inferno@chromium.org>

Reviewed by Alexey Proskuryakov.

Improve the layouttests from r75168 and make sure that the parent stylesheet value is null
before showing test passed.

  • fast/dom/StyleSheet/removed-media-rule-deleted-parent-crash.html:
  • fast/dom/StyleSheet/removed-stylesheet-rule-deleted-parent-crash.html:
11:14 Changeset [75172] by commit-queue@webkit.org

2011-01-06 Yong Li <yoli@rim.com>

Reviewed by Adam Barth.
Add the test case that is missed in r75066.
https://bugs.webkit.org/show_bug.cgi?id=48077

Test case: WebCore/manual-tests/bugzilla-48077.html.

11:08 Changeset [75171] by commit-queue@webkit.org

2011-01-06 Jeff Miller <jeffm@apple.com>

Reviewed by Darin Adler.

WebKit2: Add APIs to WKBundleFrame to get content bounds and scroll offset
https://bugs.webkit.org/show_bug.cgi?id=51968

  • WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp: (WKBundleFrameGetContentBounds): (WKBundleFrameGetScrollOffset):
  • WebProcess/InjectedBundle/API/c/WKBundleFrame.h: Add WKBundleFrameGetContentBounds() and WKBundleFrameGetScrollOffset().
11:07 Changeset [75170] by mrobinson@webkit.org

2011-01-06 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

Include a new header in the static headers list. This is necessary
so that "make install" installs the header.

  • GNUmakefile.am: Include webkitglobals.h in the header list.
11:07 Changeset [75169] by jamesr@google.com

2011-01-06 James Robinson <jamesr@chromium.org>

Reviewed by Simon Fraser.

Implement mozilla's animationTime property
https://bugs.webkit.org/show_bug.cgi?id=51952

Tests for window.webkitAnimationTime.

  • animations/animation-time-expected.txt: Added.
  • animations/animation-time.html: Added.
  • animations/script-tests/animation-time.js: Added.

2011-01-06 James Robinson <jamesr@chromium.org>

Reviewed by Simon Fraser.

Implement mozilla's animationTime property
https://bugs.webkit.org/show_bug.cgi?id=51952

Chromium DRT support for webkitAnimationTime.

  • DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::paintInvalidatedRegion):

2011-01-06 James Robinson <jamesr@chromium.org>

Reviewed by Simon Fraser.

Implement mozilla's animationTime property
https://bugs.webkit.org/show_bug.cgi?id=51952

Implements mozilla's animationTime property as described here:
https://developer.mozilla.org/en/DOM/window.mozAnimationStartTime
and http://hacks.mozilla.org/2010/08/more-efficient-javascript-animations-with-mozrequestanimationframe/
The property is called webkitAnimationTime as calling it the 'Start' time is not very informative.
This property exposes a notion of a 'current' time to use for declarative animations and allows
scripts to synchronize imperative animations with declarative ones if they choose to. Once queried
this time is saved and used for all declarative animation updates until the embedder paints/composites
the next frame and clears it, or 15ms elapse (in case the embedder isn't producing frames, for example
if the page is in a background tab).

This patch also ensures that all declarative animations started in the same script execution block
are synchronized even if some time elapses while script is running.

Test: fast/animation/animation-time.html

  • WebCore.gypi:
  • page/DOMWindow.cpp: (WebCore::DOMWindow::webkitAnimationTime):
  • page/DOMWindow.h:
  • page/DOMWindow.idl:
  • page/Frame.cpp: (WebCore::Frame::currentAnimationTime):
  • page/Frame.h:
  • page/Page.cpp: (WebCore::Page::Page):
  • page/Page.h: (WebCore::Page::animationTime):
  • page/animation/AnimationController.cpp: (WebCore::AnimationControllerPrivate::beginAnimationUpdateTime):
  • page/animation/AnimationTimeController.cpp: Added. (WebCore::AnimationTimeController::AnimationTimeController): (WebCore::AnimationTimeController::~AnimationTimeController): (WebCore::AnimationTimeController::currentAnimationTime): (WebCore::AnimationTimeController::clearCurrentAnimationTime): (WebCore::AnimationTimeController::clearCurrentAnimationTimeTimerFired):
  • page/animation/AnimationTimeController.h: Added. (WebCore::AnimationTimeController::create):

2011-01-06 James Robinson <jamesr@chromium.org>

Reviewed by Simon Fraser.

Implement mozilla's animationTime property
https://bugs.webkit.org/show_bug.cgi?id=51952

WebKit API support for webkitAnimationTime.

  • public/WebWidget.h:
  • src/WebPopupMenuImpl.cpp: (WebKit::WebPopupMenuImpl::clearCurrentAnimationTime):
  • src/WebPopupMenuImpl.h:
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::clearCurrentAnimationTime):
  • src/WebViewImpl.h:

2011-01-06 James Robinson <jamesr@chromium.org>

Reviewed by Simon Fraser.

Implement mozilla's animationTime property
https://bugs.webkit.org/show_bug.cgi?id=51952

Tells the page to clear the current animation time after producing a frame.

  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::drawRect):
  • WebProcess/WebPage/ChunkedUpdateDrawingArea.cpp: (WebKit::ChunkedUpdateDrawingArea::display): (WebKit::ChunkedUpdateDrawingArea::setSize):
  • WebProcess/WebPage/mac/LayerBackedDrawingAreaMac.mm: (WebKit::LayerBackedDrawingArea::syncCompositingLayers):
10:52 Changeset [75168] by inferno@chromium.org

2011-01-06 Abhishek Arya <inferno@chromium.org>

Reviewed by Simon Fraser.

Null out the parent stylesheet pointer when a css rule is removed.
https://bugs.webkit.org/show_bug.cgi?id=51993

Tests: fast/dom/StyleSheet/removed-media-rule-deleted-parent-crash.html

fast/dom/StyleSheet/removed-stylesheet-rule-deleted-parent-crash.html

  • css/CSSRuleList.cpp: (WebCore::CSSRuleList::deleteRule):
  • css/CSSStyleSheet.cpp: (WebCore::CSSStyleSheet::deleteRule):

2011-01-06 Abhishek Arya <inferno@chromium.org>

Reviewed by Simon Fraser.

Tests that we do not crash when accessing a deleted parent stylesheet
from a removed css rule.
https://bugs.webkit.org/show_bug.cgi?id=51993

  • fast/dom/StyleSheet/removed-media-rule-deleted-parent-crash-expected.txt: Added.
  • fast/dom/StyleSheet/removed-media-rule-deleted-parent-crash.html: Added.
  • fast/dom/StyleSheet/removed-stylesheet-rule-deleted-parent-crash-expected.txt: Added.
  • fast/dom/StyleSheet/removed-stylesheet-rule-deleted-parent-crash.html: Added.
10:47 Changeset [75167] by enne@google.com

2011-01-04 Adrienne Walker <enne@google.com>

Reviewed by Kenneth Russell.

Add test cases for storing NaN in typed arrays.
https://bugs.webkit.org/show_bug.cgi?id=46990

  • fast/canvas/webgl/array-unit-tests-expected.txt:
  • fast/canvas/webgl/array-unit-tests.html:

2011-01-04 Adrienne Walker <enne@google.com>

Reviewed by Kenneth Russell.

NaN in a TypedArray should be converted to zero only for Float32Array.
https://bugs.webkit.org/show_bug.cgi?id=46990

Test: LayoutTests/fast/canvas/webgl/array-unit-tests.html

  • bindings/js/JSArrayBufferViewHelper.h: (WebCore::convertArrayValue): (WebCore::constructArrayBufferView):
  • html/canvas/Float32Array.h: (WebCore::Float32Array::set): (WebCore::Float32Array::item):
10:42 Changeset [75166] by jparent@chromium.org

2011-01-06 Julie Parent <jparent@chromium.org>

Reviewed by Tony Chang.

Test Result Server always truncates number of results to JSON_RESULTS_MAX_BUILDS
https://bugs.webkit.org/show_bug.cgi?id=51217

  • TestResultServer/model/jsonresults.py: Pass num_runs through to _remove_items_over_max_number_of_builds, and use the value. Adds missing documentation.
  • TestResultServer/model/jsonresults_unittest.py: Add unit test to test that truncation happens at smaller value than JSON_RESULTS_MAX_BUILDS. Update test_merge to take a number of builds to truncate at.
10:21 Changeset [75165] by mrobinson@webkit.org

2011-01-06 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Enable blob support by default
https://bugs.webkit.org/show_bug.cgi?id=51994

  • configure.ac: Enable Blob support by default.
10:19 Changeset [75164] by andreip@google.com

2011-01-06 Andrei Popescu <andreip@google.com>

Unreviewed, build fix.

[Chromium] Add elliptical gradient support to GradientSkia
https://bugs.webkit.org/show_bug.cgi?id=51841

Marks fast/gradients/css3-radial-gradients3.html as expected to fail.
Also marks
canvas/philip/tests/2d.shadow.gradient.alpha.html
canvas/philip/tests/2d.shadow.gradient.basic.html
canvas/philip/tests/2d.shadow.gradient.transparent.2.html
as passing on Chromium-mac as a result of r75139.

  • platform/chromium/test_expectations.txt:
10:16 Changeset [75163] by paroga@webkit.org

2011-01-06 Patrick Gansterer <paroga@webkit.org>

Unreviewed Windows build fix for r75161.

  • platform/graphics/cg/GraphicsContextCG.cpp: Missing include added.
09:57 Changeset [75162] by andreip@google.com

2011-01-06 Andrei Popescu <andreip@google.com>

Unreviewed, rolling out r75152.

[Chromium] fast/gradients/css3-radial-gradients3.html needs Chromium-specific results
https://bugs.webkit.org/show_bug.cgi?id=51988

Rolling out since, on closer inspection, the expectations are wrong and the corresponding test really fails.

  • platform/chromium-mac/fast/gradients/css3-radial-gradients3-expected.checksum: Removed.
  • platform/chromium-mac/fast/gradients/css3-radial-gradients3-expected.png: Removed.
  • platform/chromium-win/fast/gradients/css3-radial-gradients3-expected.checksum: Removed.
  • platform/chromium-win/fast/gradients/css3-radial-gradients3-expected.png: Removed.
09:36 Changeset [75161] by paroga@webkit.org

2011-01-06 Patrick Gansterer <paroga@webkit.org>

Unreviewed WinCE build fix for r75139.

Try to remove include after adding forward-declaration in r75145.

  • platform/graphics/Gradient.h:
08:50 Changeset [75160] by reni@webkit.org

https://bugs.webkit.org/show_bug.cgi?id=51811
Merge m_height and m_width members of ImageData into the new m_size member.

Patch by Renata Hodovan <reni@webkit.org> on 2011-01-06
Reviewed by Andreas Kling.

Image (BitmapImage, ImageSource) types in WebKit use IntSize to store their
width and height argument, except ImageData. This patch refactors ImageData
to follow the style of other Image types in WebKit.
Using of PassRefPtrs other than argument passing is not allowed in WebKit anymore.
This patch also refactors the PassRefPtr usages of ImageData.

It's just a refactoring, so we don't need any new tests.

  • bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneSerializer::write):
(WebCore::CloneDeserializer::readTerminal):

  • bindings/v8/SerializedScriptValue.cpp:

(WebCore::ZigZag::Reader::readImageData):

  • html/ImageData.cpp:

(WebCore::ImageData::create):
(WebCore::ImageData::ImageData):

  • html/ImageData.h:

(WebCore::ImageData::size):
(WebCore::ImageData::width):
(WebCore::ImageData::height):

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::createEmptyImageData):
(WebCore::CanvasRenderingContext2D::createImageData):
(WebCore::CanvasRenderingContext2D::getImageData):

  • html/canvas/CanvasRenderingContext2D.h:
  • platform/graphics/haiku/ImageBufferHaiku.cpp:

(WebCore::getImageData):

08:48 Changeset [75159] by jschuh@chromium.org

Merge 70644 - 2010-10-27 Satish Sampath <satish@chromium.org>

Reviewed by Steve Block.

Add runtime flag check before enabling speech input in code.
https://bugs.webkit.org/show_bug.cgi?id=48426

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::isSpeechEnabled): Added runtime flag check.

BUG=68666
TBR=jschuh@chromium.org

08:46 Changeset [75158] by yael.aharon@nokia.com

WebCore: document.querySelector(':nth-child(foo)') should throw a syntax error
https://bugs.webkit.org/show_bug.cgi?id=51231

Reviewed by Darin Adler.

Also fixes
CSSNthSelector parsing code is illegible and buggy (allows "n3" as a valid selector)
https://bugs.webkit.org/show_bug.cgi?id=21815

Add a check in the parser that other than an+b, only "odd" or "even" would be allowed
as parameters to nth selector.

Tests: fast/css/css3-nth-tokens-script.html

fast/css/css3-nth-tokens-style.html

  • css/CSSGrammar.y:
  • css/CSSParser.cpp:

(WebCore::isValidNthToken):

  • css/CSSParser.h:

LayoutTests: document.querySelector(':nth-child(foo)') should throw a syntax error
https://bugs.webkit.org/show_bug.cgi?id=51231
CSSNthSelector parsing code is illegible and buggy (allows "n3" as a valid selector)
https://bugs.webkit.org/show_bug.cgi?id=21815

Reviewed by Darin Adler.

  • fast/css/css3-nth-tokens-script-expected.txt: Added.
  • fast/css/css3-nth-tokens-script.html: Added.
  • fast/css/css3-nth-tokens-style-expected.txt: Added.
  • fast/css/css3-nth-tokens-style.html: Added.
08:31 Changeset [75157] by commit-queue@webkit.org

2011-01-06 Jan Erik Hanssen <jhanssen@sencha.com>

Reviewed by Andreas Kling.

[Qt] crash in QNetworkReplyHandler::sendResponseIfNeeded()
https://bugs.webkit.org/show_bug.cgi?id=51453

Check if m_reply is NULL before accessing.

  • manual-tests/load-deferrer-resume-crash.html: Added.
  • platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::setLoadMode): (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
08:24 Changeset [75156] by darin@apple.com

Redo the half-done rename from the last check-in.
Sorry for the broken build last night.

  • WebProcess/WebPage/WebBackForwardListProxy.cpp:

(WebKit::WebBackForwardListProxy::removeItem): Renamed.

  • WebProcess/WebPage/WebBackForwardListProxy.h: Updated

for new name.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::didRemoveBackForwardItem): Updated to
use the new name.

08:16 Changeset [75155] by andreip@google.com

2011-01-06 Andrei Popescu <andreip@google.com>

Unreviewed, build fix.

[Chromium] canvas/canvas-fillRect-gradient-shadow.html fails on Chromium.
https://bugs.webkit.org/show_bug.cgi?id=51989

Updating the test expectations for the chromium-gpu platform.

  • platform/chromium-gpu/test_expectations.txt:
07:31 Changeset [75154] by andreip@google.com

2011-01-06 Andrei Popescu <andreip@google.com>

Unreviewed, build fix.

[Chromium] canvas/canvas-fillRect-gradient-shadow.html fails on Chromium.
https://bugs.webkit.org/show_bug.cgi?id=51989

Added suppressions for
svg/batik/text/textEffect.svg
svg/batik/text/textEffect3.svg
svg/css/composite-shadow-text.svg
svg/custom/js-late-gradient-and-object-creation.svg
svg/custom/js-late-gradient-creation.svg
svg/text/selection-background-color.xhtml
svg/text/selection-styles.xhtml
svg/text/text-gradient-positioning.svg

These tests are all failing as a result of the same change: r75153.

  • platform/chromium/test_expectations.txt:
06:32 Changeset [75153] by andreip@google.com

2011-01-06 Andrei Popescu <andreip@google.com>

Unreviewed, build fix.

[Chromium] canvas/canvas-fillRect-gradient-shadow.html fails on Chromium.
https://bugs.webkit.org/show_bug.cgi?id=51989

Updating Chromium expectations until we find a fix.

  • platform/chromium/test_expectations.txt:
06:13 Changeset [75152] by andreip@google.com

2011-01-06 Andrei Popescu <andreip@google.com>

Unreviewed, build fix.

[Chromium] fast/gradients/css3-radial-gradients3.html needs Chromium-specific results
https://bugs.webkit.org/show_bug.cgi?id=51988

  • platform/chromium-mac/fast/gradients/css3-radial-gradients3-expected.checksum: Added.
  • platform/chromium-mac/fast/gradients/css3-radial-gradients3-expected.png: Added.
  • platform/chromium-win/fast/gradients/css3-radial-gradients3-expected.checksum: Added.
  • platform/chromium-win/fast/gradients/css3-radial-gradients3-expected.png: Added.
06:04 Changeset [75151] by abecsi@webkit.org

2011-01-06 Andras Becsi <abecsi@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt][V8] Fix the build when DEVICE_ORIENTATION is enabled.

No new tests needed.

  • WebCore.pro: remove duplications and globally add RuntimeEnabledFeatures.
04:48 Changeset [75150] by ossy@webkit.org

Unreviewed.

[Qt] Web Timing related bugs
https://bugs.webkit.org/show_bug.cgi?id=51245

  • platform/qt/Skipped: Add new tests.
    • http/tests/misc/webtiming-origins.html
    • http/tests/misc/webtiming-slow-load.php
03:31 Changeset [75149] by abarth@webkit.org

2011-01-06 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

The EWS should log outside of the working directory
https://bugs.webkit.org/show_bug.cgi?id=51986

This patch prepare us for using git clean -x -d -f in the EWS wrapper
script, which will actually clean the working copy back to a pristine
state instead of leaving untracked directories and ignored files.

  • Scripts/webkitpy/tool/commands/queues.py:
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
02:49 Changeset [75148] by commit-queue@webkit.org

2011-01-06 Helder Correia <helder@sencha.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt][GTK] Use GraphicsContext::hasShadow() in port-specific code
https://bugs.webkit.org/show_bug.cgi?id=51985

r75139 introduced GraphicsContext::hasShadow(). This can now simplify
and unify some code in the Qt and GTK ports.

No new tests necessary for this refactoring.

  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::fillRoundedRect):
  • platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:
  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::drawConvexPolygon): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::fillRoundedRect):
00:41 Changeset [75147] by mjs@apple.com

Fix build for Darin's previous change w/ the obvious renaming.

Rubber stamped by Dan Bernstein.

  • WebProcess/WebPage/WebBackForwardListProxy.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::didRemoveBackForwardItem):

01/05/11:

23:43 Changeset [75146] by jam@chromium.org

2010-12-29 John Abd-El-Malek <jam@chromium.org>

Reviewed by Darin Fisher.

[chromium] Add a WebAutoFillClient interface that moves some functions from WebViewClient
https://bugs.webkit.org/show_bug.cgi?id=51710

  • WebKit.gyp:
  • public/WebAutoFillClient.h: Added. (WebKit::WebAutoFillClient::didAcceptAutoFillSuggestion): (WebKit::WebAutoFillClient::didSelectAutoFillSuggestion): (WebKit::WebAutoFillClient::didClearAutoFillSelection): (WebKit::WebAutoFillClient::removeAutocompleteSugestion): (WebKit::WebAutoFillClient::didAcceptAutocompleteSuggestion): (WebKit::WebAutoFillClient::textFieldDidBeginEditing): (WebKit::WebAutoFillClient::textFieldDidEndEditing): (WebKit::WebAutoFillClient::textFieldDidChange): (WebKit::WebAutoFillClient::textFieldDidReceiveKeyDown): (WebKit::WebAutoFillClient::~WebAutoFillClient):
23:16 Changeset [75145] by darin@apple.com

Fix Chromium Mac build.

  • platform/graphics/Gradient.h: Forward-declare CGContextRef.

This might even make it possible to remove the include of
<CoreGraphics/CoreGraphics.h> for PLATFORM(WIN), but I did not
do that at this time because I don't want to break the Windows
build when fixing the Chromium build.

23:12 Changeset [75144] by darin@apple.com

2011-01-05 Darin Adler <darin@apple.com>

Reviewed by Geoff Garen.

Back/Forward entries in WebKit2 leak
https://bugs.webkit.org/show_bug.cgi?id=51983

Besides fixing the leak, this also fixes a problem where
all history items were sent over to the UI process, but
we wanted to send only back/forward items.

  • UIProcess/WebBackForwardList.cpp: (WebKit::WebBackForwardList::pageClosed): Added. Tells the web process about all the back/forward items being removed. (WebKit::WebBackForwardList::addItem): Ditto. Also removed a redundant call to didChangeBackForwardList. (WebKit::WebBackForwardList::clear): Ditto.
  • UIProcess/WebBackForwardList.h: Added pageClosed.
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::close): Added a call to pageClosed. (WebKit::WebPageProxy::backForwardRemovedItem): Added. Sends a message to the web page in the web process.
  • UIProcess/WebPageProxy.h: Added backForwardRemovedItem.
  • WebProcess/WebPage/WebBackForwardListProxy.cpp: (WebKit::updateBackForwardItem): Added an itemID argument, since callers will now be getting it and we don't want to get it twice. Removed the code to generate an ID. Also removed some local variables to make the code a little tighter and clearer. (WebKit::WK2NotifyHistoryItemChanged): Only call updateBackForwardItem for items that already have IDs. We don't want to send cross-process messages for every history item; just the ones that are top level back/forward items. (WebKit::WebBackForwardListProxy::removeItem): Added. For use when the UI process tells us to remove it. (WebKit::WebBackForwardListProxy::addItem): Added code to assign an ID and put this item into the maps. This is called exactly once on each back/forward item.
  • WebProcess/WebPage/WebBackForwardListProxy.h: Added removeItem.
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::didRemoveBackForwardItem): Added.
  • WebProcess/WebPage/WebPage.h: Added didRemoveBackForwardItem.
  • WebProcess/WebPage/WebPage.messages.in: Added DidRemoveBackForwardItem message.
23:11 Changeset [75143] by sfalken@apple.com

Windows build fix.
Back out attempted change to built-product-archive.

  • BuildSlaveSupport/built-product-archive:
23:00 Changeset [75142] by sfalken@apple.com

Windows build fix.
Include configuration name when unpacking a build archive.

Needed, since we split Windows build results into configuration-specific directories
under WebKitOutputDir.

  • BuildSlaveSupport/built-product-archive:
22:20 Changeset [75141] by sfalken@apple.com

Windows build fix.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops: Revert change to additional library search path needed to find ICU.
22:15 Changeset [75140] by commit-queue@webkit.org

2011-01-05 Xianzhu Wang <wangxianzhu@google.com>

Reviewed by David Levin.

Implement RemoteFontStream's skip behavior (in FontCustomPlatformData.cpp)
https://bugs.webkit.org/show_bug.cgi?id=51736

No new tests. This change has potential effect on @font-face CSS feature
on ports using Skia. Tested on Chromium that this change won't break
fast/css/font-face-remote.html. This change can make the test pass on
other ports using Skia.

  • platform/graphics/skia/FontCustomPlatformData.cpp: (WebCore::RemoteFontStream::read):
22:11 Changeset [75139] by commit-queue@webkit.org

2011-01-05 Helder Correia <helder@sencha.com>

Reviewed by Simon Fraser.

Shadows are not drawn when filling a rect with a gradient fillStyle on Mac and Chromium-Mac
https://bugs.webkit.org/show_bug.cgi?id=51869

GraphicsContext::fillRect(const FloatRect&) is clipping to the rect.
The shadow is being drawn, but getting clipped to the rect being filled.
The solution is to draw the gradient into a CGLayer (when a shadow is
required), then render the layer to the GraphicsContext.

This patch also fixes:
canvas/philip/tests/2d.shadow.gradient.alpha.html
canvas/philip/tests/2d.shadow.gradient.basic.html
canvas/philip/tests/2d.shadow.gradient.transparent.2.html

New test to ensure that shadows are drawn when fillStyle is a gradient,
possibly with some transparency and blur, and specifically using
fillRect.

  • fast/canvas/canvas-fillRect-gradient-shadow-expected.txt: Added.
  • fast/canvas/canvas-fillRect-gradient-shadow.html: Added.
  • fast/canvas/script-tests/canvas-fillRect-gradient-shadow.js: Added.

2011-01-05 Helder Correia <helder@sencha.com>

Reviewed by Simon Fraser.

Shadows are not drawn when filling a rect with a gradient fillStyle on Mac and Chromium-Mac
https://bugs.webkit.org/show_bug.cgi?id=51869

GraphicsContext::fillRect(const FloatRect&) is clipping to the rect.
The shadow is being drawn, but getting clipped to the rect being filled.
The solution is to draw the gradient into a CGLayer (when a shadow is
required), then render the layer to the GraphicsContext.

This patch also fixes:
canvas/philip/tests/2d.shadow.gradient.alpha.html
canvas/philip/tests/2d.shadow.gradient.basic.html
canvas/philip/tests/2d.shadow.gradient.transparent.2.html

Test: fast/canvas/canvas-fillRect-gradient-shadow.html

  • platform/graphics/Gradient.h:
  • platform/graphics/cg/GradientCG.cpp: (WebCore::Gradient::paint):
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::fillRect):
22:02 Changeset [75138] by sfalken@apple.com

2011-01-05 Steve Falkenburg <sfalken@apple.com>

Reviewed by Darin Adler.

Debug and Release builds on Windows clobber each other
https://bugs.webkit.org/show_bug.cgi?id=49185

Changes the structure of WebKitBuild build products directory so we
completely separate each build configuration into independent directories.


Although we previously had per-configuration directories for obj, this change adds
per-configuration directories for bin, lib, obj, and include. Each configuration's
build products are stored within a directory inside of WebKitBuild.


Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).

  • win/tools/vsprops/common.vsprops:

2011-01-05 Steve Falkenburg <sfalken@apple.com>

Reviewed by Darin Adler.

Debug and Release builds on Windows clobber each other
https://bugs.webkit.org/show_bug.cgi?id=49185

Changes the structure of WebKitBuild build products directory so we
completely separate each build configuration into independent directories.


Although we previously had per-configuration directories for obj, this change adds
per-configuration directories for bin, lib, obj, and include. Each configuration's
build products are stored within a directory inside of WebKitBuild.


Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).

  • WebKit.vcproj/InterfacesCommon.vsprops:
  • WebKit.vcproj/InterfacesPostBuild.cmd:
  • WebKit.vcproj/InterfacesPreBuild.cmd:
  • WebKit.vcproj/WebKit.make:
  • WebKit.vcproj/WebKitGUID.vcproj:
  • WebKit.vcproj/WebKitGUIDCommon.vsprops:
  • WebKit.vcproj/WebKitGUIDPostBuild.cmd:
  • WebKit.vcproj/WebKitGUIDPreBuild.cmd:
  • WebKit.vcproj/WebKitLibCommon.vsprops:
  • WebKit.vcproj/WebKitLibPostBuild.cmd:
  • WebKit.vcproj/WebKitLibPreBuild.cmd:

2011-01-05 Steve Falkenburg <sfalken@apple.com>

Reviewed by Darin Adler.

Debug and Release builds on Windows clobber each other
https://bugs.webkit.org/show_bug.cgi?id=49185

Changes the structure of WebKitBuild build products directory so we
completely separate each build configuration into independent directories.


Although we previously had per-configuration directories for obj, this change adds
per-configuration directories for bin, lib, obj, and include. Each configuration's
build products are stored within a directory inside of WebKitBuild.


Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).

  • WebCore.vcproj/QTMovieWinCommon.vsprops:
  • WebCore.vcproj/QTMovieWinPostBuild.cmd:
  • WebCore.vcproj/QTMovieWinPreBuild.cmd:
  • WebCore.vcproj/WebCore.make:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcproj/WebCoreCommon.vsprops:
  • WebCore.vcproj/WebCoreGeneratedCairo.vsprops:
  • WebCore.vcproj/WebCoreGeneratedCommon.vsprops:
  • WebCore.vcproj/WebCoreMediaQT.vsprops:
  • WebCore.vcproj/WebCorePostBuild.cmd:
  • WebCore.vcproj/WebCorePreBuild.cmd:
  • WebCore.vcproj/copyForwardingHeaders.cmd:
  • WebCore.vcproj/copyInspectorFiles.cmd:

2011-01-05 Steve Falkenburg <sfalken@apple.com>

Reviewed by Darin Adler.

Debug and Release builds on Windows clobber each other
https://bugs.webkit.org/show_bug.cgi?id=49185


Changes the structure of WebKitBuild build products directory so we
completely separate each build configuration into independent directories.


Although we previously had per-configuration directories for obj, this change adds
per-configuration directories for bin, lib, obj, and include. Each configuration's
build products are stored within a directory inside of WebKitBuild.


Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).


For PGO, $(ConfigurationBuildDir) points to the same directory (Release_PGO) to allow
for proper operation of the instrumentation/optimization scripts.

2011-01-05 Steve Falkenburg <sfalken@apple.com>

Reviewed by Darin Adler.

Debug and Release builds on Windows clobber each other
https://bugs.webkit.org/show_bug.cgi?id=49185

Changes the structure of WebKitBuild build products directory so we
completely separate each build configuration into independent directories.


Although we previously had per-configuration directories for obj, this change adds
per-configuration directories for bin, lib, obj, and include. Each configuration's
build products are stored within a directory inside of WebKitBuild.


Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).

  • DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
  • DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd:
  • DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd:
  • DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
  • DumpRenderTree/win/DumpRenderTreePostBuild.cmd:
  • DumpRenderTree/win/DumpRenderTreePreBuild.cmd:
  • DumpRenderTree/win/ImageDiffCommon.vsprops:
  • DumpRenderTree/win/ImageDiffPostBuild.cmd:
  • DumpRenderTree/win/ImageDiffPreBuild.cmd:
  • FindSafari/FindSafari.vcproj:
  • MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
  • MiniBrowser/MiniBrowserPostBuild.cmd:
  • MiniBrowser/MiniBrowserPreBuild.cmd:
  • Scripts/webkitdirs.pm:
  • TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
  • TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops:
  • TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd:
  • TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd:
  • TestWebKitAPI/win/copy-resources.cmd:
  • WebKitAPITest/WebKitAPITestCommon.vsprops:
  • WebKitAPITest/WebKitAPITestPostBuild.cmd:
  • WebKitAPITest/WebKitAPITestPreBuild.cmd:
  • WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
  • WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
  • WebKitTestRunner/win/InjectedBundle.vcproj:
  • WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops:
  • WebKitTestRunner/win/InjectedBundlePostBuild.cmd:
  • WebKitTestRunner/win/InjectedBundlePreBuild.cmd:
  • WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd:
  • WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd:
  • WinLauncher/WinLauncherCommon.vsprops:
  • WinLauncher/WinLauncherPostBuild.cmd:
  • WinLauncher/WinLauncherPreBuild.cmd:

2011-01-05 Steve Falkenburg <sfalken@apple.com>

Reviewed by Darin Adler.

Debug and Release builds on Windows clobber each other
https://bugs.webkit.org/show_bug.cgi?id=49185

Changes the structure of WebKitBuild build products directory so we
completely separate each build configuration into independent directories.


Although we previously had per-configuration directories for obj, this change adds
per-configuration directories for bin, lib, obj, and include. Each configuration's
build products are stored within a directory inside of WebKitBuild.


Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).

  • win/WebKit2.make:
  • win/WebKit2.vcproj:
  • win/WebKit2Common.vsprops:
  • win/WebKit2Generated.make:
  • win/WebKit2GeneratedCommon.vsprops:
  • win/WebKit2WebProcessPostBuild.cmd:
  • win/WebKit2WebProcessPreBuild.cmd:
  • win/WebKitPostBuild.cmd:
  • win/WebKitPreBuild.cmd:
21:44 Changeset [75137] by simon.fraser@apple.com

2011-01-05 Simon Fraser <simon.fraser@apple.com>

Reviewed by Ariya Hidayat.

Directly composited SVG images fail to render
https://bugs.webkit.org/show_bug.cgi?id=51975

There was already code, added in r67900, to detect whether an image
may be directly composited, by checking to see if it's a bitmap image.

However, CachedImage::image() returns the nullImage() if m_image is null,
which is a BitmapImage, confusing this test.

Test: compositing/images/direct-svg-image.html

  • loader/cache/CachedImage.cpp: Remove nullImage(), since Image has exactly the same method. (WebCore::CachedImage::image): Use Image::nullImage().
  • loader/cache/CachedImage.h: (WebCore::CachedImage::hasImage): New method to ask whether the m_image is non-null.
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::isDirectlyCompositedImage): Use hasImage() so that we don't test the nullImage.
21:28 Changeset [75136] by simon.fraser@apple.com

2011-01-05 Simon Fraser <simon.fraser@apple.com>

Reviewed by Darin Adler.

Fix percentage values in radius of radial gradients
https://bugs.webkit.org/show_bug.cgi?id=51979

Handle percentage values for the ending size of radial gradients.

Test: fast/gradients/css3-radial-gradients3.html

  • css/CSSGradientValue.cpp: (WebCore::CSSRadialGradientValue::resolveRadius): Add parameter for height or width, which is non-null if percentage values are allowed, and compute percentage values when we see them. (WebCore::CSSRadialGradientValue::createGradient): Pass height or width down to say that percentages are OK when resolving end radii.
  • css/CSSGradientValue.h: New parameter for resolveRadius.
21:16 Changeset [75135] by ap@apple.com

2011-01-05 Alexey Proskuryakov <ap@apple.com>

Reviewed by Anders Carlsson.

https://bugs.webkit.org/show_bug.cgi?id=51973
Make main frame PDF printing work

  • UIProcess/API/mac/PDFViewController.h:
  • UIProcess/API/mac/PDFViewController.mm: (WebKit::PDFViewController::makePrintOperation): Ask PDFDocument to create an NSPrintOperation.
  • UIProcess/API/mac/WKView.h:
  • UIProcess/API/mac/WKView.mm: (-[WKView printOperationWithPrintInfo:forFrame:]): Create a new NSPrintOperation, either from scratch or from a PDF view. (-[WKView canPrintHeadersAndFooters]): Report if the view can be re-paginated to add headers and footers.
20:56 Changeset [75134] by commit-queue@webkit.org

2011-01-05 Jan Erik Hanssen <jhanssen@sencha.com>

Reviewed by Ariya Hidayat.

[Qt] TestNetscapePlugin doesn't link on OS X
https://bugs.webkit.org/show_bug.cgi?id=51948

Only add a dependency on libX11 on X11 systems

  • DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
20:36 Changeset [75133] by ojan@chromium.org

2011-01-05 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

change the way we do comment highlighting in the code review tool
https://bugs.webkit.org/show_bug.cgi?id=51971

Store a space-separated list of base line IDs on each line that has
comments associated with that line. This allows for overlapping comments,
but more importantly, makes adding side-by-side diff support easier.

  • code-review.js:
20:09 Changeset [75132] by commit-queue@webkit.org

2011-01-05 Jeff Miller <jeffm@apple.com>

Reviewed by Adam Roben.

check-webkit-style should allow unnecessary parameter names in WebKit2 APIs because we're matching CF's header style
https://bugs.webkit.org/show_bug.cgi?id=51970

  • Scripts/webkitpy/style/checker.py: Add -readability/naming for WebKit2 C API directories.
19:19 Changeset [75131] by ojan@chromium.org

2011-01-05 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

minor code cleanup for code review tool
https://bugs.webkit.org/show_bug.cgi?id=51962

Consolidates some queries to using shared functions.

  • code-review.js:
18:50 Changeset [75130] by ojan@chromium.org

2011-01-05 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

assorted cleanups to prepare for side-by-side diffing
https://bugs.webkit.org/show_bug.cgi?id=51961

Mostly, use selector queries instead of assuming comments are next siblings.

  • code-review.js:
18:41 Changeset [75129] by simonjam@chromium.org

2011-01-05 James Simonsen <simonjam@chromium.org>

Reviewed by Adam Barth.

[Web Timing] Zero out some values on cross-origin redirects
https://bugs.webkit.org/show_bug.cgi?id=49294

  • fast/dom/script-tests/webtiming.js: (checkTimingBeforeLoad): Remove unload. Its behavior depends on prior navigation and is tested separately. (checkTimingWhileDeferred): Ditto. (checkWebTimingOnDOMContentLoaded): Ditto. (checkWebTimingWhileAsync): Ditto. (checkWebTimingOnLoad): Ditto. (checkWebTimingAfterLoad): Ditto.
  • fast/dom/webtiming-expected.txt:
  • http/tests/misc/resources/webtiming-cross-origin-and-back-redirect1.php: Added.
  • http/tests/misc/resources/webtiming-cross-origin-and-back-redirect2.php: Added.
  • http/tests/misc/resources/webtiming-cross-origin-and-back1.html: Added.
  • http/tests/misc/resources/webtiming-cross-origin-and-back2.html: Added.
  • http/tests/misc/resources/webtiming-cross-origin-redirect.html: Added.
  • http/tests/misc/resources/webtiming-cross-origin-redirect.php: Added.
  • http/tests/misc/resources/webtiming-no-origin.html: Added.
  • http/tests/misc/webtiming-origins-expected.txt: Added.
  • http/tests/misc/webtiming-origins.html: Added.
  • platform/gtk/Skipped: Skip new web timing test.
  • platform/mac/Skipped: Ditto.
  • platform/win/Skipped: Ditto.

2011-01-05 James Simonsen <simonjam@chromium.org>

Reviewed by Adam Barth.

[Web Timing] Zero out some values on cross-origin redirects
https://bugs.webkit.org/show_bug.cgi?id=49294

Tests: http/tests/misc/webtiming-cross-origin-redirect.php

http/tests/misc/webtiming-origins.html

  • loader/DocumentLoadTiming.h: (WebCore::DocumentLoadTiming::DocumentLoadTiming): Add flags for cross-origin redirects and same-origin navigation.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::~FrameLoader): (WebCore::FrameLoader::stopLoading): Don't overwrite previous unload times. (WebCore::FrameLoader::completed): (WebCore::FrameLoader::loadWithDocumentLoader): Remember previous URL to see if navigation is same-origin. (WebCore::FrameLoader::commitProvisionalLoad): Set flag if navigation is same-origin.
  • loader/FrameLoader.h:
  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::willSendRequest): Set flag on cross-origin redirects.
  • page/PerformanceNavigation.cpp: (WebCore::PerformanceNavigation::redirectCount): Clear if cross-origin redirect flag is set.
  • page/PerformanceTiming.cpp: (WebCore::PerformanceTiming::redirectStart): Ditto. (WebCore::PerformanceTiming::redirectEnd): Ditto. (WebCore::PerformanceTiming::unloadEventStart): Clear if cross-origin navigation is set. (WebCore::PerformanceTiming::unloadEventEnd): Ditto.
18:39 Changeset [75128] by andersca@apple.com

<rdar://problem/8750248>
Need a way to create a new DownloadProxy from an arbitrary resource request

Reviewed by Sam Weinig.

<rdar://problem/8750465>
Need a way to start a download in WKDownload

<rdar://problem/8752204>
WK2 Context Menus - "Save linked file" support

  • Shared/ContextMenuState.h: Added.

Add a ContextMenuState struct which contains state for context menus.

  • UIProcess/API/C/WKContext.cpp:

(WKContextDownloadURLRequest):
Call WebContext::download.

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::download):
Send a DownloadRequest message to the web process.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::showContextMenu):
Set the active context menu state.

(WebKit::WebPageProxy::contextMenuItemSelected):
Handle ContextMenuItemTagDownloadImageToDisk and ContextMenuItemTagDownloadLinkToDisk by calling
WebContext::Download, passing the respective URLs.

  • UIProcess/WebPageProxy.messages.in:

ShowContextMenu now takes state as well.

  • WebProcess/WebCoreSupport/WebContextMenuClient.cpp:

(WebKit::WebContextMenuClient::downloadURL):
Assert that this is never reached; downloads are handled in the UI process.

  • WebProcess/WebPage/WebContextMenu.cpp:

(WebKit::WebContextMenu::show):
Pass the context menu state along when sending the ShowContextMenu message.

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::downloadRequest):
Call the shared DownloadManager.

  • WebProcess/WebProcess.messages.in:

Add DownloadRequest message.

  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:

Add ContextMenuState.h.

18:33 Changeset [75127] by ojan@chromium.org

2011-01-05 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

fix message container selector for code review tool
https://bugs.webkit.org/show_bug.cgi?id=51959

  • code-review.js:
18:16 Changeset [75126] by commit-queue@webkit.org

2011-01-05 Helder Correia <helder@sencha.com>

Reviewed by Ariya Hidayat.

[Qt] Default focus ring is too wide
https://bugs.webkit.org/show_bug.cgi?id=51854

This is an intermediate step to solve this bug. Use QPalette::Highlight
instead of default half-transparent black as the focus ring color.

  • platform/qt/editing/selection/caret-and-focus-ring-expected.checksum: Added.
  • platform/qt/editing/selection/caret-and-focus-ring-expected.png: Added.
  • platform/qt/editing/selection/caret-and-focus-ring-expected.txt: Added.
  • platform/qt/fast/css/focus-ring-outline-color-expected.checksum:
  • platform/qt/fast/css/focus-ring-outline-color-expected.png:
  • platform/qt/fast/css/focus-ring-outline-offset-expected.checksum:
  • platform/qt/fast/css/focus-ring-outline-offset-expected.png:
  • platform/qt/fast/css/focus-ring-outline-width-expected.checksum:
  • platform/qt/fast/css/focus-ring-outline-width-expected.png:

2011-01-05 Helder Correia <helder@sencha.com>

Reviewed by Ariya Hidayat.

[Qt] Default focus ring is too wide
https://bugs.webkit.org/show_bug.cgi?id=51854

This is an intermediate step to solve this bug. Use QPalette::Highlight
instead of default half-transparent black as the focus ring color.

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::drawFocusRingForPath):
  • platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::platformFocusRingColor):
  • platform/qt/RenderThemeQt.h:
18:15 Changeset [75125] by eric@webkit.org

2011-01-05 Eric Seidel <eric@webkit.org>

Unreviewed, just fixing one more log error from my previous python patch.

Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
https://bugs.webkit.org/show_bug.cgi?id=51802

webkit-patch failure-reason was logging about parsing errors
due to my misunderstanding of how BeautifulSoup.findAll worked.

Fixed, and added a unit test.

  • Scripts/webkitpy/common/net/layouttestresults.py:
  • Scripts/webkitpy/common/net/layouttestresults_unittest.py:
18:04 Changeset [75124] by benjamin.poulain@nokia.com

2011-01-05 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] [WK2] Add the possibility to open window from the WebProcess in Minibrowser
https://bugs.webkit.org/show_bug.cgi?id=51951

Set a function to QWKPage::setCreateNewPageFunction() in Minibrowser so there is a way
to create new window from WebKit.

  • MiniBrowser/qt/BrowserWindow.cpp: (newPageFunction): (BrowserWindow::BrowserWindow): (BrowserWindow::page): Added to avoid the indirect access to QWKPage spread in the class (BrowserWindow::newWindow): (BrowserWindow::updateUserAgentList): (BrowserWindow::showUserAgentDialog):
  • MiniBrowser/qt/BrowserWindow.h: Add the global variable backingStoreTypeForNewWindow to define the type of the backing store used for new windows.
  • MiniBrowser/qt/main.cpp: (main):
17:38 Changeset [75123] by laszlo.1.gombos@nokia.com

2011-01-05 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Unreviewed build fix.

[Qt] [Symbian] Fix building NPAPI support

NPEvent is mapped to QAction on Symbian. QAction has no
default constructor, so toNP() fails to build. Add a case for
Symbian behind the OS(SYMBIAN) guard.

  • WebProcess/Plugins/Netscape/qt/NetscapePluginQt.cpp: (WebKit::toNP):
17:28 Changeset [75122] by commit-queue@webkit.org

2011-01-05 Jeff Miller <jeffm@apple.com>

Reviewed by Dan Bernstein.

Copy WKImageCG.h to include\WebKit2 in build output
https://bugs.webkit.org/show_bug.cgi?id=51944

  • win/WebKit2Generated.make: Add xcopy command to copy WKImageCG.h.
17:26 Changeset [75121] by beidson@apple.com

Part of <rdar://problem/8261624> and https://bugs.webkit.org/show_bug.cgi?id=47355
Change WebKit2 session restoring to restore the full back/forward list

Reviewed by Sam Weinig.

Add a new message to tell the WebProcess to restore a session state:

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::restoreSession):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in: Add the new message, AND fix the intentional misspellings.


Also, Sam sucks.

Change WebProcess back/forward list item ids to be odd (UIProcess's will be even):

  • WebProcess/WebPage/WebBackForwardListProxy.cpp:

(WebKit::generateHistoryItemID):

Provide accessors to the entries in the list to pass to the WebProcess:

  • UIProcess/WebBackForwardList.h:

(WebKit::WebBackForwardList::entries):
(WebKit::WebBackForwardList::currentIndex):

Add decoding of the saved back/forward list itmes (we already encode them):

  • UIProcess/cf/WebBackForwardListCF.cpp:

(WebKit::generateWebBackForwardItemID):
(WebKit::WebBackForwardList::restoreFromCFDictionaryRepresentation):

Instead of loading the current URL, pass the entire last back to the WebProcess:

  • UIProcess/cf/WebPageProxyCF.cpp:

(WebKit::WebPageProxy::restoreFromSessionStateData):

17:22 Changeset [75120] by simonjam@chromium.org

2011-01-05 James Simonsen <simonjam@chromium.org>

Reviewed by Darin Fisher.

[Web Timing] requestStart and responseStart should be available even if the document is still loading
https://bugs.webkit.org/show_bug.cgi?id=51368

  • http/tests/misc/webtiming-slow-load-expected.txt: Added.
  • http/tests/misc/webtiming-slow-load.php: Added.

2011-01-05 James Simonsen <simonjam@chromium.org>

Reviewed by Darin Fisher.

[Web Timing] requestStart and responseStart should be available even if the document is still loading
https://bugs.webkit.org/show_bug.cgi?id=51368

Test: http/tests/misc/webtiming-slow-load.php

  • page/PerformanceTiming.cpp: (WebCore::getPossiblySkewedTimeInKnownRange): Handle case where response is not yet complete. (WebCore::PerformanceTiming::resourceLoadTimeRelativeToAbsolute): Use full upper bound.
16:41 Changeset [75119] by girish@forwardbias.in

[Qt] QML WebView does not transfer focus to underlying QGraphicsWebView

QML WebView creates QGraphicsWebView as it's child. The WebView is not
setup as a focus proxy of the QGraphicsWebView. Thus, even though the
WebView gets focus, the QGraphicsWebView does not get focus.
In QML, focus proxies or "focus scopes" are created using FocusScope.
This change makes WebView a FocusScope and sets the focus on the
QGraphicsWebView.

Reviewed by Simon Hausmann.
Acked by Aaron Kennedy <aaron.kennedy@nokia.com>

https://bugs.webkit.org/show_bug.cgi?id=51094

  • declarative/qdeclarativewebview.cpp:

(QDeclarativeWebView::init):

16:37 Changeset [75118] by crogers@google.com

2011-01-05 Chris Rogers <crogers@google.com>

Reviewed by Darin Fisher.

Add WebKitClient::createAudioDevice() for Chromium port of web audio API
https://bugs.webkit.org/show_bug.cgi?id=51424

  • WebKit.gyp:
  • public/WebAudioDevice.h: Added. (WebKit::WebAudioDevice::RenderCallback::~RenderCallback): (WebKit::WebAudioDevice::~WebAudioDevice):
  • public/WebKitClient.h: (WebKit::WebKitClient::createAudioDevice):
  • src/AudioDestinationChromium.cpp: Added. (WebCore::AudioDestination::create): (WebCore::AudioDestinationChromium::AudioDestinationChromium): (WebCore::AudioDestinationChromium::~AudioDestinationChromium): (WebCore::AudioDestinationChromium::start): (WebCore::AudioDestinationChromium::stop): (WebCore::AudioDestination::hardwareSampleRate): (WebCore::AudioDestinationChromium::render):
  • src/AudioDestinationChromium.h: Added. (WebCore::AudioDestinationChromium::isPlaying): (WebCore::AudioDestinationChromium::sampleRate):

2011-01-05 Chris Rogers <crogers@google.com>

Reviewed by Darin Fisher.

Add WebKitClient::createAudioDevice() for Chromium port of web audio API
https://bugs.webkit.org/show_bug.cgi?id=51424

No new tests since audio API is not yet implemented.

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
16:32 Changeset [75117] by beidson@apple.com

https://bugs.webkit.org/show_bug.cgi?id=51953
Add a "SessionState" object for IPC messaging.

Reviewed by Darin Adler.

This object includes all data necessary to restore a session state;
For now, this is just the back/forward list to restore.

  • Shared/SessionState.cpp: Added.

(WebKit::SessionState::SessionState):
(WebKit::SessionState::encode):
(WebKit::SessionState::decode):

  • Shared/SessionState.h: Added.

(WebKit::SessionState::list):
(WebKit::SessionState::currentIndex):

  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:
16:28 Changeset [75116] by tkent@chromium.org

2011-01-05 Kent Tamura <tkent@chromium.org>

Unreviewed, test expectation update.

Rebaseline of renderer-destruction-by-invalidateSelection-crash.html

  • platform/chromium-linux/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.checksum:
  • platform/chromium-linux/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png:
  • platform/chromium-mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.checksum: Added.
  • platform/chromium-mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png: Added.
  • platform/chromium-win/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.checksum:
  • platform/chromium-win/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png:
  • platform/chromium-win/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
  • platform/chromium/test_expectations.txt:
16:17 Changeset [75115] by andersca@apple.com

Try again.

  • WebCore.exp.in:
16:10 Changeset [75114] by eric@webkit.org

2011-01-05 Eric Seidel <eric@webkit.org>

Reviewed by Ojan Vafai.

commit-queue should report failure type when reporting flaky tests
https://bugs.webkit.org/show_bug.cgi?id=51900

This patch was a ridiculous amount of plumbing. In the end I like
the NRWT-style TestResult class even less. But now we're passing
a list of TestResult objects from the queue to the FlakyTestReporter.
Thus the FlakyTestReporter can more easily report what type of failure
occurred.

In the process, I found that I was not alone in finding TestResult
cumbersome to use. A bunch of code was trying to create a TestResult
object with default values. However since the constructor didn't make
this easy, some places were getting it wrong (including the TestResult unit test)!
I've fixed the TestResult constructor to have default values for non-essential
arguments.

  • Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
  • Scripts/webkitpy/common/net/layouttestresults.py:
  • Scripts/webkitpy/common/net/layouttestresults_unittest.py:
  • Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_results.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
  • Scripts/webkitpy/tool/bot/commitqueuetask.py:
  • Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
  • Scripts/webkitpy/tool/bot/flakytestreporter.py:
  • Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
  • Scripts/webkitpy/tool/commands/queues.py:
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
15:57 Changeset [75113] by eric@webkit.org

2011-01-05 Eric Seidel <eric@webkit.org>

Unreviewed.

Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
https://bugs.webkit.org/show_bug.cgi?id=51802

Add another unit test to cover a previously missing import.

  • Scripts/webkitpy/common/net/layouttestresults.py:
  • Scripts/webkitpy/common/net/layouttestresults_unittest.py:
15:48 Changeset [75112] by andersca@apple.com

Attempt to fix Leopard build.

  • WebCore.exp.in:
15:38 Changeset [75111] by commit-queue@webkit.org

2011-01-05 Jenn Braithwaite <jennb@chromium.org>

Reviewed by Adam Barth.

fast/encoding/parser-tests.html is slow on debug builds
https://bugs.webkit.org/show_bug.cgi?id=51721

Break up parser tests to run 10 tests per batch.

  • fast/encoding/parser-tests-10-expected.txt: Added.
  • fast/encoding/parser-tests-10.html: Copied from LayoutTests/fast/encoding/parser-tests.html.
  • fast/encoding/parser-tests-100-expected.txt: Added.
  • fast/encoding/parser-tests-100.html: Copied from LayoutTests/fast/encoding/parser-tests.html.
  • fast/encoding/parser-tests-110-expected.txt: Added.
  • fast/encoding/parser-tests-110.html: Copied from LayoutTests/fast/encoding/parser-tests.html.
  • fast/encoding/parser-tests-120-expected.txt: Added.
  • fast/encoding/parser-tests-120.html: Copied from LayoutTests/fast/encoding/parser-tests.html.
  • fast/encoding/parser-tests-20-expected.txt: Added.
  • fast/encoding/parser-tests-20.html: Copied from LayoutTests/fast/encoding/parser-tests.html.
  • fast/encoding/parser-tests-30-expected.txt: Added.
  • fast/encoding/parser-tests-30.html: Copied from LayoutTests/fast/encoding/parser-tests.html.
  • fast/encoding/parser-tests-40-expected.txt: Added.
  • fast/encoding/parser-tests-40.html: Copied from LayoutTests/fast/encoding/parser-tests.html.
  • fast/encoding/parser-tests-50-expected.txt: Added.
  • fast/encoding/parser-tests-50.html: Copied from LayoutTests/fast/encoding/parser-tests.html.
  • fast/encoding/parser-tests-60-expected.txt: Added.
  • fast/encoding/parser-tests-60.html: Copied from LayoutTests/fast/encoding/parser-tests.html.
  • fast/encoding/parser-tests-70-expected.txt: Added.
  • fast/encoding/parser-tests-70.html: Copied from LayoutTests/fast/encoding/parser-tests.html.
  • fast/encoding/parser-tests-80-expected.txt: Added.
  • fast/encoding/parser-tests-80.html: Copied from LayoutTests/fast/encoding/parser-tests.html.
  • fast/encoding/parser-tests-90-expected.txt: Added.
  • fast/encoding/parser-tests-90.html: Copied from LayoutTests/fast/encoding/parser-tests.html.
  • fast/encoding/parser-tests-expected.txt:
  • fast/encoding/parser-tests.html:
  • fast/encoding/resources/parser-tests.js: Added.
15:31 Changeset [75110] by mihaip@chromium.org

2011-01-05 Mihai Parparita <mihaip@chromium.org>

Reviewed by David Levin.

Add mihaip@chromium.org as a reviewer
https://bugs.webkit.org/show_bug.cgi?id=51966

Add myself as a reviewer.

  • Scripts/webkitpy/common/config/committers.py:
15:20 WebKit Team edited by mihaip@chromium.org
(diff)
15:18 Changeset [75109] by hans@chromium.org

2011-01-05 Hans Wennborg <hans@chromium.org>

Reviewed by Jeremy Orlow.

[Chromium] storage/indexeddb/objectstore-basics.html is flaky after r74266
https://bugs.webkit.org/show_bug.cgi?id=51731

Fix the layout test by using a known-good date value rather than
new Date(), which sometimes causes the test to fail.

(The underlying reason for failing to store certain Date values
should of course be fixed too, but that will come in a later patch.)

  • platform/chromium/test_expectations.txt:
  • storage/indexeddb/objectstore-basics-expected.txt:
  • storage/indexeddb/objectstore-basics.html:
15:17 Changeset [75108] by evan@chromium.org

2011-01-05 Evan Martin <evan@chromium.org>

Reviewed by Tony Chang.

[chromium] refactor complex text on Linux
https://bugs.webkit.org/show_bug.cgi?id=51956

Pull out TextRunWalker from FontLinux.cpp. Put it in its own file.
Rename it to ComplexTextController, to match platform/graphics/mac
more closely.

No tests because the change is just renaming a class.

  • WebCore.gyp/WebCore.gyp:
  • platform/graphics/chromium/ComplexTextControllerLinux.cpp: Added. (WebCore::ComplexTextController::ComplexTextController): (WebCore::ComplexTextController::~ComplexTextController): (WebCore::ComplexTextController::isWordBreak): (WebCore::ComplexTextController::determineWordBreakSpacing): (WebCore::ComplexTextController::setPadding): (WebCore::ComplexTextController::reset): (WebCore::ComplexTextController::setBackwardsIteration): (WebCore::ComplexTextController::nextScriptRun): (WebCore::ComplexTextController::widthOfFullRun): (WebCore::ComplexTextController::setupFontForScriptRun): (WebCore::ComplexTextController::allocHarfbuzzFont): (WebCore::ComplexTextController::deleteGlyphArrays): (WebCore::ComplexTextController::createGlyphArrays): (WebCore::ComplexTextController::resetGlyphArrays): (WebCore::ComplexTextController::shapeGlyphs): (WebCore::ComplexTextController::setGlyphXPositions): (WebCore::ComplexTextController::normalizeSpacesAndMirrorChars): (WebCore::ComplexTextController::getNormalizedTextRun):
  • platform/graphics/chromium/ComplexTextControllerLinux.h: Added. (WebCore::ComplexTextController::setWordSpacingAdjustment): (WebCore::ComplexTextController::setLetterSpacingAdjustment): (WebCore::ComplexTextController::letterSpacing): (WebCore::ComplexTextController::setXOffsetToZero): (WebCore::ComplexTextController::rtl): (WebCore::ComplexTextController::glyphs): (WebCore::ComplexTextController::length): (WebCore::ComplexTextController::xPositions): (WebCore::ComplexTextController::advances): (WebCore::ComplexTextController::width): (WebCore::ComplexTextController::logClusters): (WebCore::ComplexTextController::numCodePoints): (WebCore::ComplexTextController::fontPlatformDataForScriptRun): (WebCore::ComplexTextController::isCodepointSpace):
  • platform/graphics/chromium/FontLinux.cpp: (WebCore::Font::drawComplexText): (WebCore::Font::floatWidthForComplexText): (WebCore::glyphIndexForXPositionInScriptRun): (WebCore::Font::offsetForPositionForComplexText): (WebCore::Font::selectionRectForComplexText):
14:46 Changeset [75107] by laszlo.1.gombos@nokia.com

2011-01-05 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Unreviewed build fix.

Include unistd.h for _exit() for non-Windows builds.

Build break noticed on QtWebkit Symbian builds.

  • Shared/ChildProcess.cpp:
14:20 Changeset [75106] by levin@chromium.org

2011-01-05 David Levin <levin@chromium.org>

Reviewed by Darin Fisher.

[chromium] WEBKIT_API and styling fixes for the chromium api.
https://bugs.webkit.org/show_bug.cgi?id=51863

Removed some incorrect uses of WEBKIT_API.
Fixed some abbreviations by making them whole words.

  • public/WebAnimationController.h: Removed WEBKIT_API from virtual functions.
  • public/WebFormElement.h: Removed WEBKIT_API from inline functions and fixed some abbreviations. (WebKit::WebFormElement::WebFormElement): (WebKit::WebFormElement::operator=): (WebKit::WebFormElement::assign):
  • public/WebIDBDatabaseError.h: Ditto. (WebKit::WebIDBDatabaseError::WebIDBDatabaseError): (WebKit::WebIDBDatabaseError::operator=):
  • public/WebInputElement.h: Ditto. (WebKit::WebInputElement::WebInputElement): (WebKit::WebInputElement::operator=): (WebKit::WebInputElement::assign):
  • public/WebLabelElement.h: Ditto. (WebKit::WebLabelElement::WebLabelElement): (WebKit::WebLabelElement::operator=): (WebKit::WebLabelElement::assign):
  • public/WebOptionElement.h: Ditto. (WebKit::WebOptionElement::WebOptionElement): (WebKit::WebOptionElement::operator=): (WebKit::WebOptionElement::assign):
  • public/WebSelectElement.h: Ditto (and minor spacing cleanup). (WebKit::WebSelectElement::WebSelectElement): (WebKit::WebSelectElement::operator=): (WebKit::WebSelectElement::assign):
14:00 Changeset [75105] by senorblanco@chromium.org

2011-01-05 Stephen White <senorblanco@chromium.org>

Unreviewed; test expectations update..

Fix the expectations for the hyphenation tests on chromium-win.

  • platform/chromium/test_expectations.txt:
13:56 Changeset [75104] by senorblanco@chromium.org

2011-01-05 Stephen White <senorblanco@chromium.org>

Unreviewed; test expectations fix.

  • platform/chromium/test_expectations.txt: Add expectations for new tests introduced by r75097.
13:55 Changeset [75103] by psolanki@apple.com

2011-01-05 Pratik Solanki <psolanki@apple.com>

Reviewed by Darin Adler.

Merge cf and mac header files with same name
https://bugs.webkit.org/show_bug.cgi?id=51916

Since most of the code in the header files is identical, we can merge them and have #if
USE(CFNETWORK) to separate out the network specific parts.

  • WebCore.xcodeproj/project.pbxproj:
  • platform/network/cf/AuthenticationChallenge.h: (WebCore::AuthenticationChallenge::sender): (WebCore::AuthenticationChallenge::nsURLAuthenticationChallenge):
  • platform/network/cf/ResourceError.h: (WebCore::ResourceError::ResourceError):
  • platform/network/cf/ResourceRequest.h: (WebCore::ResourceRequest::ResourceRequest):
  • platform/network/cf/ResourceResponse.h: (WebCore::ResourceResponse::ResourceResponse):
  • platform/network/mac/AuthenticationChallenge.h: Removed.
  • platform/network/mac/ResourceError.h: Removed.
  • platform/network/mac/ResourceRequest.h: Removed.
  • platform/network/mac/ResourceResponse.h: Removed.
13:48 Changeset [75102] by andersca@apple.com

Implement word transformation
https://bugs.webkit.org/show_bug.cgi?id=51943

Reviewed by Adele Peterson.

Export Editor functions needed by WebKit2.

  • WebCore.exp.in:
13:45 Changeset [75101] by simonjam@chromium.org

2011-01-05 James Simonsen <simonjam@chromium.org>

Unreviewed. Adding myself to the list of committers.

  • Scripts/webkitpy/common/config/committers.py:
13:45 Changeset [75100] by beidson@apple.com

https://bugs.webkit.org/show_bug.cgi?id=51949
Make WebBackForwardListItem shared, and add encoders and decoders

Reviewed by Darin Adler.

  • Shared/WebBackForwardListItem.cpp: Copied from UIProcess/WebBackForwardListItem.cpp.

(WebKit::WebBackForwardListItem::encode):
(WebKit::WebBackForwardListItem::decode):

  • Shared/WebBackForwardListItem.h: Copied from UIProcess/WebBackForwardListItem.h.
  • UIProcess/WebBackForwardListItem.cpp: Removed.
  • UIProcess/WebBackForwardListItem.h: Removed.
  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:
13:34 Changeset [75099] by eric@webkit.org

2011-01-05 Eric Seidel <eric@webkit.org>

Unreviewed.

Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
https://bugs.webkit.org/show_bug.cgi?id=51802

Fix two exceptions seen on the bots after my original commit.

  • Scripts/webkitpy/common/net/layouttestresults.py:
  • Scripts/webkitpy/common/net/layouttestresults_unittest.py:
13:22 Changeset [75098] by andersca@apple.com

2011-01-05 Anders Carlsson <andersca@apple.com>

Reviewed by Adele Peterson.

Implement word transformation
https://bugs.webkit.org/show_bug.cgi?id=51943

Export Editor functions needed by WebKit2.

  • WebCore.exp.in:

2011-01-05 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Handle smart insert/delete
https://bugs.webkit.org/show_bug.cgi?id=51946

  • Shared/WebPageCreationParameters.cpp: (WebKit::WebPageCreationParameters::encode): (WebKit::WebPageCreationParameters::decode):
  • Shared/WebPageCreationParameters.h: Add isSmartInsertDelete enabled.
  • UIProcess/API/mac/WKView.mm: (-[WKView validateUserInterfaceItem:]): Handle toggleSmartInsertDelete:.

(-[WKView toggleSmartInsertDelete:]):
Toggle the smart insert/delete state.

  • UIProcess/TextChecker.h: Add isSmartInsertDeleteEnabled and setSmartInsertDeleteEnabled.
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::WebPageProxy): Initialize m_isSmartInsertDeleteEnabled.

(WebKit::WebPageProxy::contextMenuItemSelected):
Handle ContextMenuItemTagSmartCopyPaste.

(WebKit::WebPageProxy::setSmartInsertDeleteEnabled):
Update the state and send a SetSmartInsertDeleteEnabled message.

(WebKit::WebPageProxy::creationParameters):
Initialize isSmartInsertDeleteEnabled.

  • UIProcess/WebPageProxy.h: (WebKit::WebPageProxy::isSmartInsertDeleteEnabled): Return m_isSmartInsertDeleteEnabled.
  • UIProcess/mac/TextCheckerMac.mm: (WebKit::TextChecker::isSmartInsertDeleteEnabled): (WebKit::TextChecker::setSmartInsertDeleteEnabled): Store and fetch the smart insert delete state.
  • WebProcess/WebCoreSupport/WebEditorClient.cpp: (WebKit::WebEditorClient::smartInsertDeleteEnabled): Call WebPage::isSmartInsertDeleteEnabled.
  • WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm: (WebKit::WebEditorClient::toggleSmartInsertDelete): Assert that this is never called.
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::WebPage): Initialize m_isSmartInsertDeleteEnabled
  • WebProcess/WebPage/WebPage.h: (WebKit::WebPage::isSmartInsertDeleteEnabled): (WebKit::WebPage::setSmartInsertDeleteEnabled): Add getter and setter.
  • WebProcess/WebPage/WebPage.messages.in: Add SetSmartInsertDeleteEnabled message.
13:06 Changeset [75097] by simon.fraser@apple.com

2011-01-05 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dave Hyatt.

Implement repeating CSS3 gradients
https://bugs.webkit.org/show_bug.cgi?id=51843

Add support for repeating gradients, via the new gradient functions
-webkit-repeating-linear-gradient and -webkit-repeating-radial-gradient.

Tests: fast/gradients/css3-repeating-linear-gradients.html

fast/gradients/css3-repeating-radial-gradients.html

  • css/CSSGradientValue.h: (WebCore::CSSGradientValue::isRepeating): Accessor for whethe the gradient repeats. (WebCore::CSSGradientValue::CSSGradientValue): Pass CSSGradientRepeat in. (WebCore::CSSLinearGradientValue::create): Pass CSSGradientRepeat. (WebCore::CSSLinearGradientValue::CSSLinearGradientValue): Ditto (WebCore::CSSRadialGradientValue::create): Ditto. (WebCore::CSSRadialGradientValue::CSSRadialGradientValue): Ditto.
  • css/CSSGradientValue.cpp: (WebCore::CSSGradientValue::addStops): Pass maxLengthForRepeat, which is used for repeating radial gradients. Add code to repeat the stops, adding stops before the start, and after the end until the 0-N range is covered, where N is large enough to ensure the box is covered. Fix an issue with repeating gradients where if both stops were < 0, it would fail to clamp them to 0.

(WebCore::CSSLinearGradientValue::cssText): Output strings for repeating gradients.
(WebCore::CSSLinearGradientValue::createGradient): maxExtent for linear gradients is 1,
because they are guaranteed to fill the box already.
(WebCore::CSSRadialGradientValue::cssText): Output strings for repeating gradients.
(WebCore::CSSRadialGradientValue::createGradient): Compute the distance to the furthest
corner in order to inform addStops() how much additional extent is required.

  • css/CSSParser.cpp: (WebCore::CSSParser::parseDeprecatedGradient): Old gradients never repeat. (WebCore::CSSParser::parseLinearGradient): Pass down CSSGradientRepeat. (WebCore::CSSParser::parseRadialGradient): Ditto. (WebCore::CSSParser::isGeneratedImageValue): Add repeating gradient functions. (WebCore::CSSParser::parseGeneratedImage): Ditto.
  • css/CSSParser.h: Pass CSSGradientRepeat to gradient functions.
  • platform/graphics/cg/GradientCG.cpp: Remove unused #include.
12:50 Changeset [75096] by senorblanco@chromium.org

2011-01-05 Stephen White <senorblanco@chromium.org>

Unreviewed; test expectations fix.

  • platform/chromium/test_expectations.txt: Add a few failing tests to chromium's test expectations file.
  • platform/chromium-gpu/test_expectations.txt: Mark the shadow-offset tests as crashing on win debug (GPU). Remove a duplicate MAC expectation.
12:33 Changeset [75095] by mrobinson@webkit.org

2011-01-05 Martin Robinson <mrobinson@igalia.com>

Reviewed by Ariya Hidayat.

ContextShadow::blurLayerImage() not endian-safe
https://bugs.webkit.org/show_bug.cgi?id=51822

Correct the channel map in ContextShadow to reflect the different
ordering of pixels on processors with different endianness.

No new tests. This is covered by the existing shadow tests. It was
not discovered, because all of the bots using ContextShadow are
little-endian.

  • platform/graphics/ContextShadow.cpp: (WebCore::ContextShadow::blurLayerImage): Initialize the channel mapping based on machine endianness.
12:26 Changeset [75094] by andersca@apple.com

Fix Windows build.

  • WebProcess/WebPage/WebPage.cpp:
12:19 Changeset [75093] by andersca@apple.com

2011-01-05 Anders Carlsson <andersca@apple.com>

Reviewed by Adele Peterson.

Implement word transformation
https://bugs.webkit.org/show_bug.cgi?id=51943

Export Editor functions needed by WebKit2.

  • WebCore.exp.in:

2011-01-05 Anders Carlsson <andersca@apple.com>

Reviewed by Adele Peterson.

Implement word transformation
https://bugs.webkit.org/show_bug.cgi?id=51943

  • UIProcess/API/mac/WKView.mm: (-[WKView validateUserInterfaceItem:]): Handle the word transformation selectors.

(-[WKView uppercaseWord:]):
(-[WKView lowercaseWord:]):
(-[WKView capitalizeWord:]):
Call down to the WebPageProxy.

  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::uppercaseWord): (WebKit::WebPageProxy::lowercaseWord): (WebKit::WebPageProxy::capitalizeWord): Send messages to the WebPage.
  • WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm: (WebKit::changeWordCase): Add helper function.

(WebKit::WebEditorClient::uppercaseWord):
(WebKit::WebEditorClient::lowercaseWord):
(WebKit::WebEditorClient::capitalizeWord):
Call helper function.

  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::changeSpellingToWord): Call replaceSelectionWithText.

(WebKit::WebPage::uppercaseWord):
(WebKit::WebPage::lowercaseWord):
(WebKit::WebPage::capitalizeWord):
Call the editor functions.

(WebKit::WebPage::replaceSelectionWithText):
New helper function that replaces the selected string with another string.

  • WebProcess/WebPage/WebPage.messages.in: Add new messages.
12:03 Changeset [75092] by mihaip@chromium.org

2011-01-05 Mihai Parparita <mihaip@chromium.org>

Reviewed by Nate Chapin.

[Chromium] Crash when drawing PDF plug-in scrollbars
https://bugs.webkit.org/show_bug.cgi?id=51942

Pepper plug-in scrollbars don't have a parent, guard against that before
seeing if the parent is a FrameView.

Not testable via layout tests, verified fix by hand.

  • platform/chromium/ScrollbarThemeChromiumMac.mm: (WebCore::ScrollbarThemeChromiumMac::paint):
11:59 Changeset [75091] by mnaganov@chromium.org

Revert 73364 - Merge 73229 - 2010-12-02 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Fix heap snapshots loading. Loading is now
conducted by the Profiles panel which prevents accidental
simultaneous attempts to load the same profile several times in
parallel.

https://bugs.webkit.org/show_bug.cgi?id=50427

  • inspector/front-end/HeapSnapshotView.js: (WebInspector.HeapSnapshotView.prototype._loadProfile): (WebInspector.HeapSnapshotView.prototype.processLoadedSnapshot):
  • inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype.loadHeapSnapshot): (WebInspector.ProfilesPanel.prototype.addHeapSnapshotChunk): (WebInspector.ProfilesPanel.prototype.finishHeapSnapshot):

TBR=mnaganov@chromium.org
Review URL: http://codereview.chromium.org/5657001

TBR=yurys@chromium.org
Review URL: http://codereview.chromium.org/6048013

11:59 Changeset [75090] by inferno@chromium.org

Merge 75082

BUG=68439

11:48 Changeset [75089] by ap@apple.com

Reviewed by Anders Carlsson.

https://bugs.webkit.org/show_bug.cgi?id=51935
Add WebKit2 API for largest frame

  • UIProcess/API/C/WKPage.cpp: (WKPageGetFrameSetLargestFrame):
  • UIProcess/API/C/WKPage.h:
11:45 Changeset [75088] by senorblanco@chromium.org

2011-01-05 Stephen White <senorblanco@chromium.org>

Unreviewed; test expectations fix.

Update chromium GPU test_expectations.txt file to match the
layout of the CPU results more closely.

  • platform/chromium-gpu/test_expectations.txt:
11:44 Changeset [75087] by mjs@apple.com

2011-01-05 Maciej Stachowiak <mjs@apple.com>

Reviewed by Anders Carlsson.

Remove entries from WebKit2 skipped list that no longer exist
https://bugs.webkit.org/show_bug.cgi?id=51936

  • platform/mac-wk2/Skipped:
11:41 Changeset [75086] by andersca@apple.com

2011-01-05 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

More work on spelling
https://bugs.webkit.org/show_bug.cgi?id=51939

  • UIProcess/API/mac/WKView.mm: (-[WKView validateUserInterfaceItem:]): Handle changeSpelling: as well.

(-[WKView showGuessPanel:]):
Show or hide the guess panel.

(-[WKView checkSpelling:]):
Pass false to advanceToNextMisspelling.

(-[WKView changeSpelling:]):
Call changeSpellingToWord.

  • UIProcess/TextChecker.h:
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::WebPageProxy): Initialize m_pendingLearnOrIgnoreWordMessageCount.

(WebKit::WebPageProxy::contextMenuItemSelected):
Handle smart toggles directly in the UI process, keep track of whether
we're asked to learn or ignore a word.

(WebKit::WebPageProxy::advanceToNextMisspelling):
Pass the boolean through.

(WebKit::WebPageProxy::changeSpellingToWord):
Send a ChangeSpellingToWord message.

(WebKit::WebPageProxy::learnWord):
(WebKit::WebPageProxy::ignoreWord):
Check that we do have a pending learn or ignore word message. Call through to
the text checker.

(WebKit::WebPageProxy::processDidCrash):
Reset the m_pendingLearnOrIgnoreWordMessageCount variable.

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in: Add new messages.
  • UIProcess/mac/TextCheckerMac.mm: (WebKit::TextChecker::learnWord): (WebKit::TextChecker::ignoreWord): Implement in terms of NSSpellChecker.
  • WebProcess/WebCoreSupport/WebEditorClient.cpp: (WebKit::WebEditorClient::ignoreWordInSpellDocument): (WebKit::WebEditorClient::learnWord): Send IgnoreWord and LearnWord messages.
  • WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm: (WebKit::WebEditorClient::toggleAutomaticQuoteSubstitution): (WebKit::WebEditorClient::toggleAutomaticLinkDetection): (WebKit::WebEditorClient::toggleAutomaticDashSubstitution): (WebKit::WebEditorClient::toggleAutomaticTextReplacement): Add assertions.
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::advanceToNextMisspelling): Pass the bool along to the Editor.

(WebKit::WebPage::changeSpellingToWord):
Replace the selected text.

  • WebProcess/WebPage/WebPage.messages.in: Add new ChangeSpellingToWord message and add a boolean to AdvanceToNextMisspelling.
11:23 Changeset [75085] by bfulgham@webkit.org

Unreviewed build fix.

  • wtf/Encoder.h: Add <stdint.h> include for systems that

do not natively know about uint8_t, etc.

11:15 BuildingQtOnWindows edited by dbates@webkit.org
Removed "C Program Files\SlikSvn\bin\" from Path since this path is not … (diff)
11:09 Changeset [75084] by inferno@chromium.org

2011-01-05 Abhishek Arya <inferno@chromium.org>

Unreviewed.

Update FIXME comment to sound better. Also initialize the block to fix compile.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::removeChild):
11:03 Changeset [75083] by bweinstein@apple.com

Land failing Windows results after r75031. Fixing the tests is being tracked by
https://bugs.webkit.org/show_bug.cgi?id=51912.

  • platform/win/accessibility/document-role-expected.txt:
  • platform/win/accessibility/selection-and-focus-expected.txt:
10:58 Changeset [75082] by inferno@chromium.org

2011-01-05 Abhishek Arya <inferno@chromium.org>

Reviewed by Dave Hyatt.

Do not merge anonymous blocks when one of them is the one getting removed.
https://bugs.webkit.org/show_bug.cgi?id=51919

Test: fast/block/merge-anonymous-block-remove-child-crash.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::removeChild):

2011-01-05 Abhishek Arya <inferno@chromium.org>

Reviewed by Dave Hyatt.

Tests that we do not crash when trying to merge two anonymous blocks,
one of which is getting removed.
https://bugs.webkit.org/show_bug.cgi?id=51919

  • fast/block/merge-anonymous-block-remove-child-crash-expected.txt: Added.
  • fast/block/merge-anonymous-block-remove-child-crash.html: Added.
10:48 Changeset [75081] by mrobinson@webkit.org

2011-01-05 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha.

Build fix for GTK+ 3.x. Remove the call to gtk_range_set_update_policy.
GTK+ 3.x has removed this method and the default in GTK+ 2.x is continuous,
so this call is unnecessary.

  • WebCoreSupport/FullscreenVideoController.cpp: (FullscreenVideoController::createHud): Remove call to gtk_range_set_update_policy().
10:32 Changeset [75080] by rniwa@webkit.org

2011-01-05 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Eric Seidel.

ApplyStyleCommand::applyRelativeFontStyleChange should take EditingStyle*
https://bugs.webkit.org/show_bug.cgi?id=50641

Modified applyRelativeFontStyleChange to take EditingStyle instead of CSSMutableStyleDeclaration.
Also extracted the logic to obtain the font size delta from ApplyStyleCommand to EditingStyle.
The font size delta is now stored as a member variable of EditingStyle as supposed to a property
in CSSMutableStyleDeclration as soon as EditingStyle is instantiated.

No new tests are added since this is a refactoring.

  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::doApply): Calls applyRelativeFontStyleChange. (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange): Takes EditingStyle.
  • editing/ApplyStyleCommand.h:
  • editing/EditingStyle.cpp: (WebCore::EditingStyle::EditingStyle): Initializes m_fontSizeDelta. (WebCore::EditingStyle::init): Ditto. (WebCore::EditingStyle::extractFontSizeDelta): Extracted from applyRelativeFontStyleChange. (WebCore::EditingStyle::isEmpty): Takes care of m_fontSizeDelta. (WebCore::EditingStyle::setStyle): Calls extractFontSizeDelta. (WebCore::EditingStyle::overrideWithStyle): Ditto. (WebCore::EditingStyle::clear): Initializes m_fontSizeDelta. (WebCore::EditingStyle::copy): Calls extractFontSizeDelta.
  • editing/EditingStyle.h: (WebCore::EditingStyle::fontSizeDelta): Added. (WebCore::EditingStyle::hasFontSizeDelta): Added.
  • editing/Editor.h:
10:28 Changeset [75079] by andersca@apple.com

2011-01-05 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Keep track of active text substitution preferences
https://bugs.webkit.org/show_bug.cgi?id=51931

  • Shared/TextCheckerState.h:
  • UIProcess/API/mac/WKView.mm: (-[WKView validateUserInterfaceItem:]): Handle new selectors, mostly copied from WebKit1 code.

(-[WKView orderFrontSubstitutionsPanel:]):
Open the substitution panel.

(-[WKView isAutomaticQuoteSubstitutionEnabled]):
(-[WKView setAutomaticQuoteSubstitutionEnabled:]):
(-[WKView toggleAutomaticQuoteSubstitution:]):
(-[WKView isAutomaticDashSubstitutionEnabled]):
(-[WKView setAutomaticDashSubstitutionEnabled:]):
(-[WKView toggleAutomaticDashSubstitution:]):
(-[WKView isAutomaticLinkDetectionEnabled]):
(-[WKView setAutomaticLinkDetectionEnabled:]):
(-[WKView toggleAutomaticLinkDetection:]):
(-[WKView isAutomaticTextReplacementEnabled]):
(-[WKView setAutomaticTextReplacementEnabled:]):
(-[WKView toggleAutomaticTextReplacement:]):
Call the text checker, and update the state in the web process if needed.

  • UIProcess/TextChecker.h: Add new flags.
  • UIProcess/mac/TextCheckerMac.mm: (WebKit::initializeState): Initialize flags from user defaults.

(WebKit::TextChecker::setAutomaticQuoteSubstitutionEnabled):
(WebKit::TextChecker::setAutomaticDashSubstitutionEnabled):
(WebKit::TextChecker::setAutomaticLinkDetectionEnabled):
(WebKit::TextChecker::setAutomaticTextReplacementEnabled):
Update and save the flags.

  • WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm: (WebKit::WebEditorClient::isAutomaticQuoteSubstitutionEnabled): (WebKit::WebEditorClient::isAutomaticLinkDetectionEnabled): (WebKit::WebEditorClient::isAutomaticDashSubstitutionEnabled): (WebKit::WebEditorClient::isAutomaticTextReplacementEnabled): Get the text checker state.
10:16 Changeset [75078] by commit-queue@webkit.org

2011-01-05 Yi Shen <yi.4.shen@nokia.com>

Reviewed by Andreas Kling.

[Qt] Sync qwebkitplatformplugin.h in the plugin example
https://bugs.webkit.org/show_bug.cgi?id=51882

Make examples/platformplugin/qwebkitplatformplugin.h exactly the same
as the one in the Api folder.

  • examples/platformplugin/qwebkitplatformplugin.h:
10:03 Changeset [75077] by mitz@apple.com

<rdar://problem/8799835> hyphenate-character: auto should fall back to hyphen-minus if the primary font lacks a hyphen glyph
https://bugs.webkit.org/show_bug.cgi?id=51915

Reviewed by Darin Adler.

WebCore:

This changes the results of existing tests in fast/text.

  • platform/graphics/Font.h:
  • platform/graphics/FontFastPath.cpp:

(WebCore::Font::primaryFontHasGlyphForCharacter): Added.

  • rendering/style/RenderStyle.cpp:
  • platform/graphics/qt/FontQt.cpp:

(WebCore::Font::primaryFontHasGlyphForCharacter): Added a stub.
(WebCore::RenderStyle::hyphenString): For hyphenate-character: auto, return a
hyphen only if the primary font has a hyphen glyph, and otherwise return a
hyphen-minus.

LayoutTests:

  • platform/mac/fast/text/basic/014-expected.checksum:
  • platform/mac/fast/text/basic/014-expected.png:
  • platform/mac/fast/text/basic/014-expected.txt:
  • platform/mac/fast/text/capitalize-boundaries-expected.checksum:
  • platform/mac/fast/text/capitalize-boundaries-expected.png:
  • platform/mac/fast/text/capitalize-boundaries-expected.txt:
  • platform/mac/fast/text/midword-break-after-breakable-char-expected.checksum:
  • platform/mac/fast/text/midword-break-after-breakable-char-expected.png:
  • platform/mac/fast/text/midword-break-after-breakable-char-expected.txt:
09:55 Changeset [75076] by laszlo.1.gombos@nokia.com

2011-01-05 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Ariya Hidayat.

[Qt] [Symbian] Make CONFIG-=def_files the default configuration for trunk builds
https://bugs.webkit.org/show_bug.cgi?id=51888

Overrule Qt's default from qconfig.pri for non-production builds so
that CONFIG(def_files) evaluates to false and QtWebKit trunk builds succeed.

No new tests as there is no new functionality.

  • WebCore.pro:
09:50 Changeset [75075] by mitz@apple.com

Cleaned up com.apple.WebProcess.sb

Rubber-stamped by Darin Adler.

  • WebProcess/com.apple.WebProcess.sb: Moved the closing parentheses of multi-line blocks to

their own lines. Changed to use WebKit-standard 4-space indentation.

09:37 Changeset [75074] by commit-queue@webkit.org

2011-01-05 Kundu Suchismita <suchi.kundu@nokia.com>

Reviewed by Andreas Kling.

[Qt]Add local storage settings to QtTestBrowser command line arguments
https://bugs.webkit.org/show_bug.cgi?id=51750

  • QtTestBrowser/main.cpp: (LauncherApplication::handleUserOptions): Local storage settings can be enable form command line arguments for QtTestBrowser.
09:33 Changeset [75073] by commit-queue@webkit.org

2011-01-05 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r74778.
http://trac.webkit.org/changeset/74778
https://bugs.webkit.org/show_bug.cgi?id=51930

Android and QtWebKit-V8 uses V8DOMWindowShell::setContext.
(Requested by bbandix on #webkit).

  • bindings/v8/V8DOMWindowShell.cpp: (WebCore::V8DOMWindowShell::setContext):
  • bindings/v8/V8DOMWindowShell.h:
09:31 Changeset [75072] by cfleizach@apple.com

GTK: AX: DRT needs to use correct root object method.
https://bugs.webkit.org/show_bug.cgi?id=51911

Reviewed by Martin Robinson.

Tools:

  • DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:

(AccessibilityController::rootElement):

WebKit/gtk:

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:

(DumpRenderTreeSupportGtk::getRootAccessibleElement):
(DumpRenderTreeSupportGtk::getFocusedAccessibleElement):

  • WebCoreSupport/DumpRenderTreeSupportGtk.h:
09:27 Changeset [75071] by commit-queue@webkit.org

2011-01-05 Yi Shen <yi.4.shen@nokia.com>

Reviewed by Andreas Kling.

[Qt] Animated GIF images does not animate 10x as expected by default.
https://bugs.webkit.org/show_bug.cgi?id=36818

Add a test animated GIF which should be displayed 2 times and stop.

  • manual-tests/animated-gif-looping.html:
  • manual-tests/resources/animated-2x.gif: Added.
09:23 Changeset [75070] by carlosgc@webkit.org

2011-01-05 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Fork code of ScrollbarThemeGtk that will differ for GTK+ 3
https://bugs.webkit.org/show_bug.cgi?id=51923

Split out pieces of ScrollbarThemeGtk into ScrollbarThemeGtk2 and
ScrollbarThemeGtk3 that will differ between GTK+ 2 and GTK+ 3.

No new tests. This should not change functionality.

  • GNUmakefile.am: Add ScrollbarThemeGtk2.cpp and ScrollbarThemeGtk3.cpp
  • platform/gtk/ScrollbarThemeGtk.cpp: (WebCore::ScrollbarThemeGtk::updateScrollbarsFrameThickness):
  • platform/gtk/ScrollbarThemeGtk.h:
  • platform/gtk/ScrollbarThemeGtk2.cpp: Added. (WebCore::ScrollbarThemeGtk::updateThemeProperties): (WebCore::ScrollbarThemeGtk::paintTrackBackground): (WebCore::ScrollbarThemeGtk::paintScrollbarBackground): (WebCore::ScrollbarThemeGtk::paintThumb): (WebCore::ScrollbarThemeGtk::paintButton):
  • platform/gtk/ScrollbarThemeGtk3.cpp: Added. (WebCore::ScrollbarThemeGtk::updateThemeProperties): (WebCore::ScrollbarThemeGtk::paintTrackBackground): (WebCore::ScrollbarThemeGtk::paintScrollbarBackground): (WebCore::ScrollbarThemeGtk::paintThumb): (WebCore::ScrollbarThemeGtk::paintButton):
08:55 Changeset [75069] by paroga@webkit.org

2011-01-05 Patrick Gansterer <paroga@webkit.org>

Reviewed by Andreas Kling.

[CMake] Fix the usage of SOURCE_GROUP
https://bugs.webkit.org/show_bug.cgi?id=51739

  • Source/cmake/WebKitMacros.cmake:

2011-01-05 Patrick Gansterer <paroga@webkit.org>

Reviewed by Andreas Kling.

[CMake] Fix the usage of SOURCE_GROUP
https://bugs.webkit.org/show_bug.cgi?id=51739

  • CMakeLists.txt:

2011-01-05 Patrick Gansterer <paroga@webkit.org>

Reviewed by Andreas Kling.

[CMake] Fix the usage of SOURCE_GROUP
https://bugs.webkit.org/show_bug.cgi?id=51739

  • CMakeLists.txt:
08:37 Changeset [75068] by abecsi@webkit.org

2011-01-05 Andras Becsi <abecsi@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt][V8] Fix the build after recent changes.

  • pcre/pcre.pri: Correct the path after Source was introduced.

2011-01-05 Andras Becsi <abecsi@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt][V8] Fix the build after recent changes.

No new tests needed.

  • WebCore.pro: Add missing files, and remove obsolete ones.
08:28 Changeset [75067] by paroga@webkit.org

2011-01-05 Patrick Gansterer <paroga@webkit.org>

Reviewed by Andreas Kling.

[WINCE] Remove CMake warning
https://bugs.webkit.org/show_bug.cgi?id=51921

  • Source/cmake/WebKitHelpers.cmake:
07:51 Changeset [75066] by commit-queue@webkit.org

2011-01-05 Yong Li <yoli@rim.com>

Reviewed by Adam Barth.

Suspend HTMLParserScheduler when page load is deferred to
avoid potential JS re-entrancy. Otherwise, when JS execution is triggered
from an external script or by events, and is blocked by a modal dialog,
WebKit can parse more HTML source and also start another JS execution.

https://bugs.webkit.org/show_bug.cgi?id=48077

Test case: WebCore/manual-tests/bugzilla-48077.html.

  • dom/DocumentParser.cpp: (WebCore::DocumentParser::suspendScheduledTasks): (WebCore::DocumentParser::resumeScheduledTasks):
  • dom/DocumentParser.h:
  • html/parser/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::suspendScheduledTasks): (WebCore::HTMLDocumentParser::resumeScheduledTasks):
  • html/parser/HTMLParserScheduler.cpp: (WebCore::HTMLParserScheduler::HTMLParserScheduler): (WebCore::HTMLParserScheduler::suspend): (WebCore::HTMLParserScheduler::resume):
  • html/parser/HTMLParserScheduler.h: (WebCore::HTMLParserScheduler::isScheduledForResume):
  • page/PageGroupLoadDeferrer.cpp: (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer): (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
07:48 Changeset [75065] by hausmann@webkit.org

[GStreamer] MediaPlayerPrivateGStreamer::totalBytes() does not work reliably
https://bugs.webkit.org/show_bug.cgi?id=51926

Reviewed by Kenneth Rohde Christiansen, Gustavo Noronha Silva

Work around potential upstream bug: Querying a GstBin for the duration,
will forward the query to all sink children. Our WebKitWebSrc however
is a bin with only source children, therefore the query fails. Until
this is changed upstream, this patch works around it as follows,
based on suggestion by Philippe Normand and Sebastian Dröge:

When the initial query fails, attempt the same query on all source
pads and take the maximum length reported.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::totalBytes):

07:24 Changeset [75064] by hans@chromium.org

2011-01-05 Hans Wennborg <hans@chromium.org>

Reviewed by David Levin.

[Chromium] WebIDBKey clean-up
https://bugs.webkit.org/show_bug.cgi?id=51925

Remove constructors that are no longer used since the
Chromium side has been updated.

  • public/WebIDBKey.h:
06:11 Changeset [75063] by ossy@webkit.org

Based on idea from Péter Gál.

Patch by Gabor Rapcsanyi <rgabor@inf.u-szeged.hu> on 2011-01-05
Rubber-stamped by Csaba Osztrogonác.

  • Scripts/webkitpy/tool/bot/sheriff.py: Remove unnecessary apostrophes around revision numbers.
05:25 Changeset [75062] by ossy@webkit.org

sheriff-bot should be able to do multi-revision rollouts
https://bugs.webkit.org/show_bug.cgi?id=51176

Patch by Gabor Rapcsanyi <rgabor@inf.u-szeged.hu> on 2011-01-05
Reviewed by Adam Barth.

  • Scripts/webkitpy/tool/bot/irc_command.py:
  • Scripts/webkitpy/tool/bot/sheriff.py:
  • Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
05:13 WinCE edited by paroga@webkit.org
(diff)
05:04 Changeset [75061] by philn@webkit.org

2011-01-05 Philippe Normand <pnormand@igalia.com>

Rubber-stamped by Eric Seidel.

[GStreamer] build fails with gstreamer core 0.10.31 and -plugins-base 0.10.30
https://bugs.webkit.org/show_bug.cgi?id=51810

Based on a patch by Mart Raudsepp.

No new tests, build fix only.

  • platform/graphics/gstreamer/GStreamerGWorld.cpp: (WebCore::GStreamerGWorld::setWindowOverlay): Use the new xoverlay API if the GST_CHECK_PLUGINS_BASE_VERSION macro is defined. It was introduced in same version as the xoverlay API change.
04:39 Changeset [75060] by eric@webkit.org

2011-01-05 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

queues.webkit.org should have per-bot status pages
https://bugs.webkit.org/show_bug.cgi?id=51906

Just adds a /queue-status/QUEUE_NAME/bots/BOT_ID page to show
statuses from a single queue. Now that we have many bots servicing
some queues (commit-queue, win-ews, etc.) its easy to have the messages
you care about scroll off the end of the 15-message limit on the main page.

Eventually we should probably rename /queue-status to /queue or /queues,
but that's fodder for another patch.

  • QueueStatusServer/handlers/queuestatus.py:
  • QueueStatusServer/index.yaml:
  • QueueStatusServer/main.py:
  • QueueStatusServer/templates/includes/singlequeuestatus.html:
    • This probably should use a custom filter instead of hard-coding the URL scheme here, but I couldn't figure out how to easily create such a filter. Most filters work with "strings" so we can't pass the status object. We could add a method to the status object and call that, but that seemed a bit strange too.
  • QueueStatusServer/templates/queuestatus.html:
04:11 Changeset [75059] by commit-queue@webkit.org

2011-01-05 Leo Yang <leo.yang@torchmobile.com.cn>

Reviewed by Dirk Schulze.

Malformed SVG causes crash in updateContainerOffset
https://bugs.webkit.org/show_bug.cgi?id=44610

Test case for recursive svg <use>.
This test case passes if no crash occurs.

  • svg/custom/recursive-use-expected.txt: Added.
  • svg/custom/recursive-use.svg: Added.

2011-01-05 Leo Yang <leo.yang@torchmobile.com.cn>

Reviewed by Dirk Schulze.

Malformed SVG causes crash in updateContainerOffset
https://bugs.webkit.org/show_bug.cgi?id=44610

We should check recursive <use> at the begining of
WebCore::SVGUseElement::buildInstanceTree instead
of at the end of it because the target element's
children may cause infinite recursive <use>.

Test: svg/custom/recursive-use.svg

  • svg/SVGUseElement.cpp: (WebCore::SVGUseElement::buildInstanceTree): (WebCore::SVGUseElement::hasCycleUseReferencing):
  • svg/SVGUseElement.h:
04:03 Changeset [75058] by antti@apple.com

https://bugs.webkit.org/show_bug.cgi?id=51907
Style selector should only be recalculated when the pending sheet count goes to zero

Reviewed by Dan Bernstein.

Shark says this is a significant performance improvement on some sites with lots of stylesheets.

  • dom/Document.cpp:

(WebCore::Document::removePendingSheet):

03:52 Changeset [75057] by antti@apple.com

Not reviewed.

Update a pixel test result for https://bugs.webkit.org/show_bug.cgi?id=8852.

  • platform/mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.checksum:
  • platform/mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png:
02:45 Changeset [75056] by carlosgc@webkit.org

2011-01-05 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Use GtkStyleContext to get platform colors
https://bugs.webkit.org/show_bug.cgi?id=51830

Use GtkStyleContext API to get platform colors when building with
GTK+ 3.x.

No new tests. This should not change functionality.

  • platform/graphics/Color.h: Add specialized constructor for GdkRGBA.
  • platform/graphics/gtk/ColorGtk.cpp: (WebCore::Color::Color): (WebCore::Color::operator GdkRGBA):
  • platform/gtk/RenderThemeGtk3.cpp: (WebCore::RenderThemeGtk::platformActiveSelectionBackgroundColor): (WebCore::RenderThemeGtk::platformInactiveSelectionBackgroundColor): (WebCore::RenderThemeGtk::platformActiveSelectionForegroundColor): (WebCore::RenderThemeGtk::platformInactiveSelectionForegroundColor): (WebCore::RenderThemeGtk::activeListBoxSelectionBackgroundColor): (WebCore::RenderThemeGtk::inactiveListBoxSelectionBackgroundColor): (WebCore::RenderThemeGtk::activeListBoxSelectionForegroundColor): (WebCore::RenderThemeGtk::inactiveListBoxSelectionForegroundColor): (WebCore::RenderThemeGtk::systemColor):
02:18 Changeset [75055] by carlosgc@webkit.org

2011-01-05 Carlos Garcia Campos <cgarcia@igalia.com>

Unreviewed. Build fix for GTK when using gtk+-3 after r75009.

  • platform/gtk/RenderThemeGtk3.cpp: (WebCore::RenderThemeGtk::getStockIcon): Use adoptGRef instead of adoptGRefPtr which doesn't exist.
01:32 Changeset [75054] by ap@apple.com

2011-01-05 Alexey Proskuryakov <ap@apple.com>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=51903
Tell UI process which subframe is largest

  • WebCore.exp.in: Exported FrameView::contentsSize().

2011-01-05 Alexey Proskuryakov <ap@apple.com>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=51903
Tell UI process which subframe is largest

  • UIProcess/WebPageProxy.h: (WebKit::WebPageProxy::frameSetLargestFrame): Remember largest frame in frameset pages.
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::frameDidBecomeFrameSet): Reset stored largest frame if main frame changes to a frameset or back. (WebKit::WebPageProxy::frameSetLargestFrameChanged): Store a new largest frame when notified of a change.
  • UIProcess/WebPageProxy.messages.in: Added FrameSetLargestFrameChanged.
  • WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::area): Calculate area of a frame. (WebKit::findLargestFrameInFrameSet): Find largest first-level subframe in a frameset page. (WebKit::WebChromeClient::contentsSizeChanged): Recalculate largest frame, and notify UI process if it changed.
  • WebProcess/WebCoreSupport/WebChromeClient.h: Store the latest largest frame.
  • WebProcess/WebPage/WebFrame.cpp: (WebKit::WebFrame::size):
  • WebProcess/WebPage/WebFrame.h: Expose frame size.
01:12 Changeset [75053] by carlosgc@webkit.org

2011-01-05 Carlos Garcia Campos <cgarcia@igalia.com>

Unreviewed. Adding myself to the list of committers.

  • Scripts/webkitpy/common/config/committers.py:
00:06 WebKit Team edited by carlosgc@webkit.org
Add myself to committer list (diff)

01/04/11:

23:45 Changeset [75052] by cfleizach@apple.com

2011-01-04 Chris Fleizach <cfleizach@apple.com>

Unreviewed. GTK build fix.

WK2: Support Accessibility
https://bugs.webkit.org/show_bug.cgi?id=51859

  • page/FrameView.cpp: (WebCore::FrameView::axObjectCache):
23:37 Changeset [75051] by sfalken@apple.com

Build fix. Update path to FindSafari after source code reorganization.

23:33 Changeset [75050] by commit-queue@webkit.org

2011-01-04 Koan-Sin Tan <koansin.tan@gmail.com>

Reviewed by David Levin.

check-webkit-style treated some macros with parentheses after #elif as function calls
https://bugs.webkit.org/show_bug.cgi?id=51695

Ingore function call space checking in any preprocessor directives
(things starting with #). Change search() to match() because
preprocessor directives are supposed to be in the beginning of lines.

  • Scripts/webkitpy/style/checkers/cpp.py:
  • Scripts/webkitpy/style/checkers/cpp_unittest.py: make sure there is no false positives for #elif cases
23:24 Changeset [75049] by tkent@chromium.org

2011-01-04 Kent Tamura <tkent@chromium.org>

Unreviewed, test expectation update.

insecure-css-in-main-frame.html is flaky on Chromium-linux too.

  • platform/chromium/test_expectations.txt:
23:21 Changeset [75048] by tkent@chromium.org

2011-01-04 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r74992.
http://trac.webkit.org/changeset/74992
https://bugs.webkit.org/show_bug.cgi?id=51917

Crash in HTMLDocumentParser::suspendScheduledTasks()
(Requested by tkent on #webkit).

  • dom/DocumentParser.cpp:
  • dom/DocumentParser.h:
  • html/parser/HTMLDocumentParser.cpp:
  • html/parser/HTMLDocumentParser.h:
  • html/parser/HTMLParserScheduler.cpp: (WebCore::HTMLParserScheduler::HTMLParserScheduler):
  • html/parser/HTMLParserScheduler.h: (WebCore::HTMLParserScheduler::isScheduledForResume):
  • page/PageGroupLoadDeferrer.cpp: (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer): (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
22:24 Changeset [75047] by benjamin.poulain@nokia.com

2011-01-04 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] [WK2] Add support for non-trivial context menu action
https://bugs.webkit.org/show_bug.cgi?id=51902

Fix the preprocessor guard for ContextMenuItemTagSelectAll in
the implementation of ContextMenuController::contextMenuItemSelected(). The guard was
inconsistent with what is defined in ContextMenuItem.h.

  • page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected):

2011-01-04 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] [WK2] Add support for non-trivial context menu action
https://bugs.webkit.org/show_bug.cgi?id=51902

Implement a call back from the QAction triggered in the UIProcess to the
action in WebProcess.

A few basic actions have been implemented based on this feature.

  • UIProcess/API/qt/qwkpage.cpp: (contextMenuActionForWebAction): (QWKPage::triggerAction): (QWKPage::action):
  • UIProcess/API/qt/qwkpage.h:
  • UIProcess/qt/WebContextMenuProxyQt.cpp: (WebKit::webActionForContextMenuAction):
21:48 Changeset [75046] by laszlo.1.gombos@nokia.com

2011-01-04 Siddharth Mathur <siddharth.mathur@nokia.com>

Reviewed by Laszlo Gombos.

Include unistd.h for sleep() for non-Windows builds.

  • WebProcess/WebProcess.cpp:
  • WebProcess/qt/WebProcessMainQt.cpp:
21:30 Changeset [75045] by tonyg@chromium.org

2011-01-04 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Ryosuke Niwa.

Avoid manual ref/deref in AsyncScriptRunner by using PendingScript
https://bugs.webkit.org/show_bug.cgi?id=51723

ScriptElement should also be able to keep its Element+CachedScript in
a PendingScript, and then executeScriptSoon can accept a PendingScript.
Once HTMLScriptRunner, ScriptElement, and AsyncScriptRunner all use
PendingScripts, then generic request and execute which operate on
PendingScripts can be factored out to avoid code duplicate that we have.

No new tests because no new functionality.

  • dom/AsyncScriptRunner.cpp: (WebCore::AsyncScriptRunner::~AsyncScriptRunner): (WebCore::AsyncScriptRunner::executeScriptSoon): (WebCore::AsyncScriptRunner::timerFired):
  • dom/AsyncScriptRunner.h:
  • dom/PendingScript.h: Add ctor which sets element and cachedScript. Rename adoptElement->setElement.
  • dom/HTMLScriptRunner.cpp: (WebCore::HTMLScriptRunner::requestPendingScript):
20:07 Changeset [75044] by bweinstein@apple.com

Windows build fix. Change the inline type of consumePermanently.

  • Shared/SandboxExtension.h:

(WebKit::SandboxExtension::consumePermanently):

19:30 Changeset [75043] by tkent@chromium.org

2011-01-04 Kent Tamura <tkent@chromium.org>

Unreviewed, test expectation update

  • slow-loading-image-in-pattern.html had a wrong expectation for Chromium-win.
  • insecure-css-in-main-frame.html is flaky on Chromium-win?
  • platform/chromium/test_expectations.txt:
19:10 Changeset [75042] by andersca@apple.com

<rdar://problem/8821203> Sandbox violations trying to access the Safari cache

Reviewed by Dan Bernstein.

  • Shared/SandboxExtension.h:

(WebKit::SandboxExtension::consumePermanently):
New function which consumes a sandbox extension and destroys it, making it impossible
to later revoke it.

  • Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):
Encode and decode the path extension handle.

  • Shared/mac/SandboxExtensionMac.mm:

(WebKit::SandboxExtension::createHandle):
Standardize the path before creating the handle.

  • UIProcess/mac/WebContextMac.mm:

(WebKit::WebContext::platformInitializeWebProcess):
Create a sandbox extension for the cache path.

  • WebProcess/mac/WebProcessMac.mm:

(WebKit::WebProcess::platformInitializeWebProcess):
Consume the sandbox extension.

19:08 Changeset [75041] by andersca@apple.com

Fix build.

  • UIProcess/mac/TextCheckerMac.mm:

(WebKit::TextChecker::getGuessesForWord):

19:08 Changeset [75040] by commit-queue@webkit.org

2011-01-04 Jeff Miller <jeffm@apple.com>

Reviewed by Darin Adler.

Member variable and method naming cleanup to be consistent with WebKit2.
https://bugs.webkit.org/show_bug.cgi?id=51228

  • page/win/EventHandlerWin.cpp: (WebCore::EventHandler::eventActivatedView): Rename activatedWebView() to didActivateWebView().
  • platform/PlatformMouseEvent.h: Rename m_activatedWebView to m_didActivateWebView.

(WebCore::PlatformMouseEvent::PlatformMouseEvent):
Initialize platform-specific member variables in PlatformMouseEvent constructors.

(WebCore::PlatformMouseEvent::didActivateWebView):
Rename activatedWebView() to didActivateWebView().

  • platform/win/PlatformMouseEventWin.cpp: (WebCore::PlatformMouseEvent::PlatformMouseEvent): Rename m_activatedWebView to m_didActivateWebView.

2011-01-04 Jeff Miller <jeffm@apple.com>

Reviewed by Darin Adler.

Mouse events in WebKit2 on Windows need to know whether the click activated the WebView to match WebKit1 behavior.
https://bugs.webkit.org/show_bug.cgi?id=51228

  • Shared/WebEvent.h: (WebKit::WebMouseEvent::didActivateWebView): Add m_didActivateWebView to WebMouseEvent on Windows.
  • Shared/WebEventConversion.cpp: (WebKit::WebKit2PlatformMouseEvent::WebKit2PlatformMouseEvent): Propagate whether the click activated the WebView when converting to a PlatformMouseEvent.
  • Shared/WebMouseEvent.cpp: (WebKit::WebMouseEvent::WebMouseEvent): Add m_didActivateWebView to WebMouseEvent on Windows.

(WebKit::WebMouseEvent::encode):
(WebKit::WebMouseEvent::decode):
Encode and decode new m_didActivateWebView member variable.

  • Shared/win/WebEventFactory.cpp: (WebKit::WebEventFactory::createWebMouseEvent):
  • Shared/win/WebEventFactory.h: Add didActivateWebView parameter to createWebMouseEvent().
  • UIProcess/win/WebView.cpp: (WebKit::WebView::wndProc): (WebKit::WebView::WebView): (WebKit::WebView::onMouseEvent):
  • UIProcess/win/WebView.h: (WebKit::WebView::setWasActivatedByMouseEvent): Keep track of whether the click activated the WebView.
18:21 Changeset [75039] by yael.aharon@nokia.com

2011-01-04 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Darin Adler.

CSS3 :nth-child selector and valid whitespace test fails
https://bugs.webkit.org/show_bug.cgi?id=36279

  • fast/css/css3-nth-space-expected.txt: Added.
  • fast/css/css3-nth-space.html: Added.

2011-01-04 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Darin Adler.

CSS3 :nth-child selector and valid whitespace test fails
https://bugs.webkit.org/show_bug.cgi?id=36279

Teach the tokenizer to allow white spaces around [+/-] signs in nth constructs.

Test: fast/css/css3-nth-space.html

  • css/tokenizer.flex:
18:16 Changeset [75038] by andersca@apple.com

Reviewed and landed by Anders Carlsson.

Patch by Ivan Krstić <ike@apple.com> on 2011-01-04
<rdar://problem/8602585>
<rdar://problem/8711641>

  • WebProcess/com.apple.WebProcess.sb:

Fix a misplaced right parenthesis and add a new system path regex.

18:13 Changeset [75037] by andersca@apple.com

2011-01-04 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

More work on spelling and grammar
https://bugs.webkit.org/show_bug.cgi?id=51910

  • Scripts/webkit2/messages.py: Add special case for WebCore::TextCheckingResult.
  • Shared/NotImplemented.h: Fix macro so that defining DISABLE_NOT_IMPLEMENTED_WARNINGS to 0 will enable the warnings.


  • Shared/WebCoreArgumentCoders.h: Add argument coders for WebCore::GrammarDetail and WebCore::TextCheckingResult.
  • UIProcess/API/mac/WKView.mm: (-[WKView checkSpelling:]): Call advanceToNextMisspelling.
  • UIProcess/TextChecker.h: Add new NSSpellChecker wrappers.
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::WebPageProxy): Initialize the new member variables.

(WebKit::WebPageProxy::~WebPageProxy):
Call TextChecker::closeSpellDocumentWithTag.

(WebKit::WebPageProxy::advanceToNextMisspelling):
Send the AdvanceToNextMisspelling message.

(WebKit::WebPageProxy::spellDocumentTag):
Create a spell document tag if necessary.

(WebKit::WebPageProxy::checkTextOfParagraph):
(WebKit::WebPageProxy::updateSpellingUIWithMisspelledWord):
(WebKit::WebPageProxy::getGuessesForWord):
Call the TextChecker.


  • UIProcess/WebPageProxy.messages.in: Add new messages.
  • UIProcess/mac/TextCheckerMac.mm: (WebKit::TextChecker::uniqueSpellDocumentTag): (WebKit::TextChecker::closeSpellDocumentWithTag): (WebKit::TextChecker::checkTextOfParagraph): (WebKit::TextChecker::updateSpellingUIWithMisspelledWord): (WebKit::TextChecker::getGuessesForWord): Add NSSpellChecker wrappers.
  • UIProcess/qt/TextCheckerQt.cpp:
  • UIProcess/win/TextCheckerWin.cpp: Add stubs.
  • WebProcess/WebCoreSupport/WebEditorClient.cpp: (WebKit::WebEditorClient::isContinuousSpellCheckingEnabled): (WebKit::WebEditorClient::isGrammarCheckingEnabled): Get the text checking state from the web process.

(WebKit::WebEditorClient::updateSpellingUIWithMisspelledWord):
(WebKit::WebEditorClient::getGuessesForWord):
Proxy calls to the UI process.

  • WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm: (WebKit::WebEditorClient::isAutomaticSpellingCorrectionEnabled):


(WebKit::WebEditorClient::checkTextOfParagraph):
Proxy calls to the UI process.

  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::advanceToNextMisspelling): Call the frame.
  • WebProcess/WebPage/WebPage.messages.in: Add AdvanceToNextMisspelling message.
  • WebProcess/WebProcess.cpp: (WebKit::WebProcess::initializeWebProcess): Set the text checker state.
18:09 Changeset [75036] by commit-queue@webkit.org

2011-01-04 Søren Gjesse <sgjesse@chromium.org>

Reviewed by Tony Chang.

Change the --multi-load test option to --stress-opt
https://bugs.webkit.org/show_bug.cgi?id=50751

  • DumpRenderTree/chromium/DumpRenderTree.cpp: (runTest): (main):
  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::TestShell):
  • DumpRenderTree/chromium/TestShell.h: (TestShell::stressOpt): (TestShell::setStressOpt): (TestShell::stressDeopt): (TestShell::setStressDeopt): (TestShell::javaScriptFlags): (TestShell::setJavaScriptFlags):
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
17:45 Changeset [75035] by tonyg@chromium.org

2011-01-04 Tony Gentilcore <tonyg@chromium.org>

Unreviewed expectations update.

Fix text metrics for "You should not see this at all" message
https://bugs.webkit.org/show_bug.cgi?id=51909

  • http/tests/misc/acid3-expected.checksum:
  • http/tests/misc/acid3-expected.png:
  • platform/chromium/test_expectations.txt:
17:36 Changeset [75034] by cfleizach@apple.com

Unreviewed. Build fix.

WK2: Support Accessibility
https://bugs.webkit.org/show_bug.cgi?id=51859

WebCore:

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:

(fallbackObject):

WebKit2:

  • WebProcess/WebPage/mac/AccessibilityWebPageObject.mm:
17:21 Changeset [75033] by cfleizach@apple.com

Unreviewed. Build fix.

WK2: Support Accessibility
https://bugs.webkit.org/show_bug.cgi?id=51859

  • WebProcess/WebPage/mac/AccessibilityWebPageObject.mm:

(-[AccessibilityWebPageObject accessibilityAttributeValue:]):

17:14 Changeset [75032] by commit-queue@webkit.org

2011-01-04 Cosmin Truta <ctruta@chromium.org>

Reviewed by Eric Seidel.

[chromium] PNG compression settings optimized for speed
https://bugs.webkit.org/show_bug.cgi?id=51719

Although Z_HUFFMAN_ONLY is the fastest on hard-to-compress images,
it is also the slowest, by a wide margin, on easy-to-compress images.
Use a more balanced configuration, based on the libpng compression defaults,
but with a faster compression level (3 instead of 6), and a faster filter
("sub" instead of "all").

No change in behaviour, so no new tests.

  • platform/image-encoders/skia/PNGImageEncoder.cpp: (WebCore::PNGImageEncoder::encode):
17:07 Changeset [75031] by cfleizach@apple.com

WK2: Support Accessibility
https://bugs.webkit.org/show_bug.cgi?id=51859

Reviewed by Sam Weinig.

Tools:

Use rootObject() method to get top of accessibility tree.

  • DumpRenderTree/mac/AccessibilityControllerMac.mm:

(AccessibilityController::focusedElement):
(AccessibilityController::rootElement):

WebCore:

WK2 doesn't use platform scroll views anymore. Accessibility code
needs to have its own scroll views.

Test: platform/mac/accessibility/webkit-scrollarea.html

  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.exp.in:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::AXObjectCache):
(WebCore::AXObjectCache::get):
(WebCore::AXObjectCache::getOrCreate):
(WebCore::AXObjectCache::rootObject):
(WebCore::AXObjectCache::remove):
(WebCore::AXObjectCache::handleScrollbarUpdate):

  • accessibility/AXObjectCache.h:

(WebCore::AXObjectCache::handleScrollbarUpdate):

  • accessibility/AccessibilityARIAGrid.h:
  • accessibility/AccessibilityAllInOne.cpp:
  • accessibility/AccessibilityImageMapLink.cpp:
  • accessibility/AccessibilityImageMapLink.h:
  • accessibility/AccessibilityListBoxOption.cpp:
  • accessibility/AccessibilityListBoxOption.h:
  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::updateChildrenIfNecessary):
(WebCore::AccessibilityObject::elementAccessibilityHitTest):
(WebCore::AccessibilityObject::axObjectCache):
(WebCore::AccessibilityObject::focusedUIElement):

  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::isAccessibilityScrollView):
(WebCore::AccessibilityObject::isScrollView):
(WebCore::AccessibilityObject::canSetNumericValue):
(WebCore::AccessibilityObject::scrollBar):
(WebCore::AccessibilityObject::size):
(WebCore::AccessibilityObject::setValue):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::parentObject):
(WebCore::AccessibilityRenderObject::accessibilityHitTest):
(WebCore::AccessibilityRenderObject::updateChildrenIfNecessary):
(WebCore::AccessibilityRenderObject::addChildren):

  • accessibility/AccessibilityRenderObject.h:
  • accessibility/AccessibilityScrollView.cpp: Added.

(WebCore::AccessibilityScrollView::AccessibilityScrollView):
(WebCore::AccessibilityScrollView::create):
(WebCore::AccessibilityScrollView::scrollBar):
(WebCore::AccessibilityScrollView::children):
(WebCore::AccessibilityScrollView::updateChildrenIfNecessary):
(WebCore::AccessibilityScrollView::removeChildScrollbar):
(WebCore::AccessibilityScrollView::addChildScrollbar):
(WebCore::AccessibilityScrollView::addChildren):
(WebCore::AccessibilityScrollView::webAreaObject):
(WebCore::AccessibilityScrollView::accessibilityHitTest):
(WebCore::AccessibilityScrollView::document):
(WebCore::AccessibilityScrollView::elementRect):
(WebCore::AccessibilityScrollView::parentObject):

  • accessibility/AccessibilityScrollView.h: Added.

(WebCore::AccessibilityScrollView::roleValue):
(WebCore::AccessibilityScrollView::scrollView):
(WebCore::AccessibilityScrollView::accessibilityIsIgnored):
(WebCore::AccessibilityScrollView::isAccessibilityScrollView):
(WebCore::toAccessibilityScrollView):

  • accessibility/AccessibilityScrollbar.cpp:

(WebCore::AccessibilityScrollbar::AccessibilityScrollbar):
(WebCore::AccessibilityScrollbar::create):
(WebCore::AccessibilityScrollbar::elementRect):
(WebCore::AccessibilityScrollbar::document):
(WebCore::AccessibilityScrollbar::orientation):
(WebCore::AccessibilityScrollbar::isEnabled):
(WebCore::AccessibilityScrollbar::valueForRange):
(WebCore::AccessibilityScrollbar::setValue):

  • accessibility/AccessibilityScrollbar.h:

(WebCore::AccessibilityScrollbar::setParent):
(WebCore::AccessibilityScrollbar::canSetValueAttribute):
(WebCore::AccessibilityScrollbar::canSetNumericValue):
(WebCore::AccessibilityScrollbar::isAccessibilityScrollbar):
(WebCore::AccessibilityScrollbar::parentObject):
(WebCore::AccessibilityScrollbar::roleValue):

  • accessibility/mac/AccessibilityObjectMac.mm:

(WebCore::AccessibilityObject::accessibilityIgnoreAttachment):

  • accessibility/mac/AccessibilityObjectWrapper.mm:

(-[AccessibilityObjectWrapper accessibilityAttributeNames]):
(-[AccessibilityObjectWrapper remoteAccessibilityParentObject]):
(-[AccessibilityObjectWrapper position]):
(-[AccessibilityObjectWrapper scrollViewParent]):
(-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
(-[AccessibilityObjectWrapper accessibilityHitTest:]):
(-[AccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):

  • dom/Document.cpp:

(WebCore::Document::axObjectCache):

  • loader/EmptyClients.h:

(WebCore::EmptyFrameLoaderClient::accessibilityRemoteObject):

  • loader/FrameLoaderClient.h:
  • page/FrameView.cpp:

(WebCore::FrameView::~FrameView):
(WebCore::FrameView::axObjectCache):

  • page/FrameView.h:
  • platform/ScrollView.cpp:

(WebCore::ScrollView::setHasHorizontalScrollbar):
(WebCore::ScrollView::setHasVerticalScrollbar):

  • platform/Scrollbar.cpp:

(WebCore::Scrollbar::~Scrollbar):
(WebCore::Scrollbar::scroll):
(WebCore::Scrollbar::axObjectCache):

  • platform/Scrollbar.h:
  • platform/Widget.h:

(WebCore::Widget::axObjectCache):

WebKit/gtk:

Use rootObject() method to get top of ax tree.

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:

(DumpRenderTreeSupportGtk::getFocusedAccessibleElement):

  • webkit/webkitwebview.cpp:

(webkit_web_view_get_accessible):

WebKit/mac:

Use rootObject() method to get top of AX tree.

  • WebCoreSupport/WebFrameLoaderClient.h:

(WebFrameLoaderClient::accessibilityRemoteObject):

  • WebView/WebFrame.mm:

(-[WebFrame setAccessibleName:]):
(-[WebFrame accessibilityRoot]):

  • WebView/WebFrameInternal.h:
  • WebView/WebFramePrivate.h:
  • WebView/WebHTMLView.mm:

(-[WebHTMLView accessibilityAttributeValue:]):
(-[WebHTMLView accessibilityFocusedUIElement]):
(-[WebHTMLView accessibilityHitTest:]):
(-[WebHTMLView _accessibilityParentForSubview:]):

WebKit/win:

Use rootObject() method to get the top of the AX tree.

  • AccessibleDocument.cpp:

(AccessibleDocument::AccessibleDocument):

WebKit2:

Implement remote accessibility API to support cross process accessibility
on the Mac platform.

  • Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):

  • Shared/WebProcessCreationParameters.h:
  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::accessibilityChildTokenReceived):

  • UIProcess/API/mac/WKView.mm:

(-[WKView initWithFrame:contextRef:pageGroupRef:]):
(-[WKView _updateWindowAndViewFrames]):
(-[WKView _setAccessibilityChildToken:]):
(-[WKView accessibilityIsIgnored]):
(-[WKView accessibilityHitTest:]):
(-[WKView accessibilityAttributeValue:]):

  • UIProcess/API/mac/WKViewInternal.h:
  • UIProcess/PageClient.h:
  • UIProcess/WebContext.cpp:

(WebKit::WebContext::ensureWebProcess):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::windowAndViewFramesChanged):
(WebKit::WebPageProxy::didReceiveAccessibilityPageToken):
(WebKit::WebPageProxy::sendAccessibilityPresenterToken):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::accessibilityRemoteObject):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::windowAndViewFramesChanged):

  • WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::accessibilityPosition):

  • WebProcess/WebPage/WebPage.messages.in:
  • WebProcess/WebPage/mac/AccessibilityWebPageObject.h: Added.
  • WebProcess/WebPage/mac/AccessibilityWebPageObject.mm: Added.

(-[AccessibilityWebPageObject setWebPage:]):
(-[AccessibilityWebPageObject setRemoteParent:]):
(-[AccessibilityWebPageObject dealloc]):
(-[AccessibilityWebPageObject accessibilityIsIgnored]):
(-[AccessibilityWebPageObject accessibilityAttributeNames]):
(-[AccessibilityWebPageObject accessibilityIsAttributeSettable:]):
(-[AccessibilityWebPageObject accessibilitySetValue:forAttribute:]):
(-[AccessibilityWebPageObject accessibilityActionNames]):
(-[AccessibilityWebPageObject accessibilityChildren]):
(-[AccessibilityWebPageObject accessibilityAttributeValue:]):
(-[AccessibilityWebPageObject accessibilityShouldUseUniqueId]):
(-[AccessibilityWebPageObject accessibilityHitTest:]):
(-[AccessibilityWebPageObject accessibilityFocusedUIElement]):

  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::platformInitialize):
(WebKit::WebPage::sendAccessibilityPresenterToken):
(WebKit::WebPage::accessibilityRemoteObject):

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeWebProcess):

  • WebProcess/WebProcess.h:

(WebKit::WebProcess::presenterApplicationPid):

  • WebProcess/mac/WebProcessMainMac.mm:

(WebKit::WebProcessMain):

LayoutTests:

  • platform/mac/accessibility/webkit-scrollarea-expected.txt: Added.
  • platform/mac/accessibility/webkit-scrollarea.html: Added.
16:53 Changeset [75030] by commit-queue@webkit.org

2011-01-04 W. James MacLean <wjmaclean@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Add support to compositor to composite to offscreen texture.
https://bugs.webkit.org/show_bug.cgi?id=50833

A patch to extend compositor to be able to composite into an offscreen texture instead
of just directly to the display buffer. Builds on RenderSurfaceChromium support.
Explicitly resets alpha channel before rendering to display.

  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::LayerRendererChromium): (WebCore::LayerRendererChromium::updateAndDrawRootLayer): (WebCore::LayerRendererChromium::drawLayers): (WebCore::LayerRendererChromium::setCompositeOffscreen): (WebCore::LayerRendererChromium::useRenderSurface): (WebCore::LayerRendererChromium::setScissorToRect):
  • platform/graphics/chromium/LayerRendererChromium.h: (WebCore::LayerRendererChromium::isCompositingOffscreen): (WebCore::LayerRendererChromium::getOffscreenLayerTexture):
16:50 Changeset [75029] by tkent@chromium.org

2011-01-04 Kent Tamura <tkent@chromium.org>

Unreviewed, test expectation update.

Add home-end-expected.txt for Chromium-win again. It's a
platform-dependent text test.

  • platform/chromium-win/editing/selection/home-end-expected.txt: Added.
16:26 Changeset [75028] by jschuh@chromium.org

Merge 74779 - 2010-12-29 Justin Schuh <jschuh@chromium.org>

Reviewed by Darin Adler.

Check SVG element type in FrameView::scrollToAnchor
https://bugs.webkit.org/show_bug.cgi?id=51718

Test: svg/custom/scroll-to-anchor-in-symbol.svg

  • page/FrameView.cpp: (WebCore::FrameView::scrollToAnchor):

2010-12-29 Justin Schuh <jschuh@chromium.org>

Reviewed by Darin Adler.

Check SVG element type in FrameView::scrollToAnchor
https://bugs.webkit.org/show_bug.cgi?id=51718

  • svg/custom/scroll-to-anchor-in-symbol-expected.txt: Added.
  • svg/custom/scroll-to-anchor-in-symbol.svg: Added.

BUG=68178
TBR=jschuh@chromium.org

16:23 Changeset [75027] by darin@chromium.org

2011-01-04 Darin Fisher <darin@chromium.org>

Reviewed by David Levin.

Update README file with a description of the WEBKIT_API macro and
guidelines for its usage. Also document the various WEBKIT_USING_*
macros.

https://bugs.webkit.org/show_bug.cgi?id=51880

  • README:
16:21 Changeset [75026] by jschuh@chromium.org

Merge 74788 - 2010-12-30 Justin Schuh <jschuh@chromium.org>

Reviewed by Dirk Schulze.

Prevent stringToLengthType() from skipping past end-of-string on invalid length unit.
https://bugs.webkit.org/show_bug.cgi?id=51692

  • svg/SVGLength.cpp: (WebCore::stringToLengthType): (WebCore::SVGLength::setValueAsString):

2010-12-30 Justin Schuh <jschuh@chromium.org>

Reviewed by Dirk Schulze.

Adding long float string to improve test coverage.
https://bugs.webkit.org/show_bug.cgi?id=51692

  • svg/dom/length-list-parser.html:
  • svg/dom/length-list-parser-expected.txt:

BUG=68062
TBR=jschuh@chromium.org

16:17 Changeset [75025] by tkent@chromium.org

2011-01-04 Kent Tamura <tkent@chromium.org>

Unreviewed, test expectation update.

  • platform/chromium/test_expectations.txt: Fix a syntax error in the previous change
16:09 Changeset [75024] by tkent@chromium.org

2011-01-04 Kent Tamura <tkent@chromium.org>

Unreviewed, test expectation update.

  • platform/chromium-win/editing/selection/home-end-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
16:06 Changeset [75023] by evan@chromium.org

2011-01-04 Evan Martin <evan@chromium.org>

Reviewed by Tony Chang.

[chromium] depend on harfbuzz explicitly
https://bugs.webkit.org/show_bug.cgi?id=51895

platform/graphics/chromium uses Harfbuzz directly. Rather than
expecting Skia to adjust the include paths, be explicit about
the dependency.

  • WebCore.gyp/WebCore.gyp:

2011-01-04 Evan Martin <evan@chromium.org>

Reviewed by Tony Chang.

[chromium] depend on harfbuzz explicitly
https://bugs.webkit.org/show_bug.cgi?id=51895

Update Chromium DEPS to pick up newer Chromium version
that simplifies expressing the Harfbuzz dependency.

  • DEPS:
15:57 Changeset [75022] by beidson@apple.com

Get rid of an extra copy in the back/forward item IPC message by using a DataReference.

Reviewed by Darin Adler.

  • UIProcess/WebBackForwardListItem.cpp:

(WebKit::WebBackForwardListItem::WebBackForwardListItem):
(WebKit::WebBackForwardListItem::setBackForwardData):

  • UIProcess/WebBackForwardListItem.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::dataCallback): Get rid of no-longer-needed check for size 0.

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::addBackForwardItem):

  • UIProcess/WebProcessProxy.h:
  • UIProcess/WebProcessProxy.messages.in:
  • WebProcess/WebPage/EncoderAdapter.cpp:

(WebKit::EncoderAdapter::data):

  • WebProcess/WebPage/EncoderAdapter.h:
  • WebProcess/WebPage/WebBackForwardListProxy.cpp:
15:35 Changeset [75021] by beidson@apple.com

Store more data per history entry in the session state blob.

Reviewed by Darin Adler.

  • UIProcess/WebBackForwardListItem.cpp:

(WebKit::WebBackForwardListItem::WebBackForwardListItem):

  • UIProcess/WebBackForwardListItem.h:

(WebKit::WebBackForwardListItem::create):

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::addBackForwardItem):

  • UIProcess/cf/WebBackForwardListCF.cpp:

(WebKit::WebBackForwardList::createCFDictionaryRepresentation):

  • UIProcess/cf/WebPageProxyCF.cpp:
15:28 Changeset [75020] by darin@apple.com

2011-01-04 Darin Adler <darin@apple.com>

Reviewed by Brady Eidson.

Add back/forward encoding and decoding to WebKit2
https://bugs.webkit.org/show_bug.cgi?id=51901

  • WebCore.exp.in: Export functions used in WebKit2.
  • history/HistoryItem.cpp: (WebCore::HistoryItem::encodeBackForwardTree): Use references instead of pointers. (WebCore::HistoryItem::encodeBackForwardTreeNode): Ditto. (WebCore::HistoryItem::decodeBackForwardTree): Ditto.
  • history/HistoryItem.h: Ditto.
  • platform/network/FormData.cpp: (WebCore::encode): Ditto. (WebCore::decode): Ditto. (WebCore::FormData::encodeForBackForward): Ditto. (WebCore::FormData::decodeForBackForward): Ditto.
  • platform/network/FormData.h: Ditto.

2011-01-04 Darin Adler <darin@apple.com>

Reviewed by Brady Eidson.

Add back/forward encoding and decoding to WebKit2
https://bugs.webkit.org/show_bug.cgi?id=51901

  • GNUmakefile.am: Added new source files.
  • WebKit2.pro: Ditto.
  • WebKit2.xcodeproj/project.pbxproj: Ditto.
  • win/WebKit2.vcproj: Ditto.
  • WebProcess/WebPage/DecoderAdapter.cpp: Added.
  • WebProcess/WebPage/DecoderAdapter.h: Added.
  • WebProcess/WebPage/EncoderAdapter.cpp: Added.
  • WebProcess/WebPage/EncoderAdapter.h: Added.
  • WebProcess/WebPage/WebBackForwardListProxy.cpp: (WebKit::updateBackForwardItem): Added code to encode the back/forward tree and send it along. The code to decode needs to wait on Brady's current project.
15:17 Changeset [75019] by dbates@webkit.org

2011-01-04 Daniel Bates <dbates@rim.com>

Fix the Android build after changeset 74975 <http://trac.webkit.org/changeset/74975>
(https://bugs.webkit.org/show_bug.cgi?id=51855).

  • wtf/ThreadingPthreads.cpp: Add include of PassOwnPtr.h. (WTF::runThreadWithRegistration): Use -> instead of . to dereference pointer.
15:05 Changeset [75018] by xji@chromium.org

2011-01-04 Xiaomei Ji <xji@chromium.org>

Reviewed by Dan Bernstein.

Implement sel.modify('move', 'left'/'right', 'lineBoundary').
https://bugs.webkit.org/show_bug.cgi?id=33435

  • editing/SelectionController.cpp: (WebCore::SelectionController::modifyMovingRight): (WebCore::SelectionController::modifyMovingLeft):
  • editing/visible_units.cpp: (WebCore::logicalStartOfLine): (WebCore::logicalEndOfLine): (WebCore::leftBoundaryOfLine): (WebCore::rightBoundaryOfLine):
  • editing/visible_units.h:

2011-01-04 Xiaomei Ji <xji@chromium.org>

Implement sel.modify('move', 'left'/'right', 'lineBoundary').
https://bugs.webkit.org/show_bug.cgi?id=33435

  • editing/selection/home-end-expected.txt:
  • editing/selection/home-end.html:
15:04 Changeset [75017] by mrobinson@webkit.org

2011-01-04 Martin Robinson <mrobinson@igalia.com>

Try to fix the EFL build.

  • wtf/CMakeLists.txt: Remove PlatformRefPtr from the CMake source list.
14:58 Changeset [75016] by mrobinson@webkit.org

2011-01-04 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Use the default CSS text input control border width of relying on the GTK+ theme
https://bugs.webkit.org/show_bug.cgi?id=51887

Update all results that use text areas. These controls now have a 1 pixel
border (the default in html.css) instead of using the border size from the
GTK+ theme.

  • platform/gtk/fast/forms/basic-textareas-expected.txt:
  • platform/gtk/fast/forms/form-element-geometry-expected.txt:
  • platform/gtk/fast/forms/onselect-textarea-expected.txt:
  • platform/gtk/fast/forms/placeholder-stripped-expected.txt:
  • platform/gtk/fast/forms/search-styled-expected.txt:
  • platform/gtk/fast/forms/textAreaLineHeight-expected.txt:
  • platform/gtk/fast/forms/textarea-align-expected.txt:
  • platform/gtk/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
  • platform/gtk/fast/forms/textarea-placeholder-set-attribute-expected.txt:
  • platform/gtk/fast/forms/textarea-placeholder-set-value-expected.txt:
  • platform/gtk/fast/forms/textarea-scroll-height-expected.txt:
  • platform/gtk/fast/forms/textarea-scrollbar-expected.txt:
  • platform/gtk/fast/forms/textarea-scrolled-type-expected.txt:
  • platform/gtk/fast/forms/textarea-setinnerhtml-expected.txt:
  • platform/gtk/fast/forms/textarea-width-expected.txt:

2011-01-04 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Use the default CSS text input control border width of relying on the GTK+ theme
https://bugs.webkit.org/show_bug.cgi?id=51887

Do not rely on the GTK+ theme to determine text control borders. This simplifies
the RenderTheme code, prevents metrics differences between GTK+ 2.x and 3.x and
doesn't break the rendering of any theme that I've encountered.

  • platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::adjustSearchFieldStyle): No longer call setTextInputBorders, but still disable any border radius.
  • platform/gtk/RenderThemeGtk.h: Remove setTextInputBorders and no longer override the default style of text areas and text input controls.
  • platform/gtk/RenderThemeGtk2.cpp: Ditto.
  • platform/gtk/RenderThemeGtk3.cpp: Ditto.
14:58 Changeset [75015] by andersca@apple.com

<rdar://problem/8766999> WebKit2: Sandboxing causes certificate error on access to any HTTPS URL

Reviewed by Sam Weinig.

Allow read access to /Library/Preferences/com.apple.security.plist.

  • WebProcess/com.apple.WebProcess.sb:
14:56 Changeset [75014] by jschuh@chromium.org

Merge 74636 - 2010-12-24 Justin Schuh <jschuh@chromium.org>

Reviewed by Nikolas Zimmermann.

SVGElementInstance::m_useElement should be cleared when use element is removed from document
https://bugs.webkit.org/show_bug.cgi?id=51486

Test: svg/custom/use-instanceRoot-with-use-removed.svg

  • svg/SVGElementInstance.cpp: (WebCore::SVGElementInstance::invalidateAllInstancesOfElement):
  • svg/SVGElementInstance.h: (WebCore::SVGElementInstance::clearUseElement):
  • svg/SVGUseElement.cpp: (WebCore::SVGUseElement::removedFromDocument): (WebCore::ShadowTreeUpdateBlocker::if): (WebCore::SVGUseElement::detachInstance): (WebCore::SVGUseElement::detach):
  • svg/SVGUseElement.h:

2010-12-24 Justin Schuh <jschuh@chromium.org>

Reviewed by Nikolas Zimmermann.

SVGElementInstance::m_useElement should be cleared when use element is removed from document
https://bugs.webkit.org/show_bug.cgi?id=51486

  • svg/custom/use-instanceRoot-with-use-removed-expected.txt: Added.
  • svg/custom/use-instanceRoot-with-use-removed.svg: Added.

BUG=67363
TBR=jschuh@chromium.org

14:56 Changeset [75013] by andersca@apple.com

Build fixes.

  • UIProcess/qt/TextCheckerQt.cpp:
  • UIProcess/win/TextCheckerWin.cpp:
14:49 Changeset [75012] by andersca@apple.com

Don't use macros for the key names.

Reviewed by Darin Adler.

  • UIProcess/mac/TextCheckerMac.mm:
14:47 Changeset [75011] by commit-queue@webkit.org

2011-01-04 James Robinson <jamesr@chromium.org>

Reviewed by Darin Adler.

StackBounds initialization in WTFThreadData should be guarded by #if USE(JSC)
https://bugs.webkit.org/show_bug.cgi?id=51881

The StackBounds class is only used by JavaScriptCore.

  • wtf/WTFThreadData.cpp: (WTF::WTFThreadData::WTFThreadData):
  • wtf/WTFThreadData.h: (WTF::WTFThreadData::resetCurrentIdentifierTable):
14:41 Changeset [75010] by andersca@apple.com

2011-01-04 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Send over text checker state to the web process
https://bugs.webkit.org/show_bug.cgi?id=51896

  • Platform/CoreIPC/Arguments.h: Remove 'const' from the argument, this matches all the other Arguments classes.
  • Shared/TextCheckerState.h: Added. New class with text checker state.
  • Shared/WebProcessCreationParameters.cpp: (WebKit::WebProcessCreationParameters::encode): (WebKit::WebProcessCreationParameters::decode):
  • Shared/WebProcessCreationParameters.h: Add textCheckerState.
  • UIProcess/API/mac/WKView.mm: (-[WKView validateUserInterfaceItem:]): (-[WKView toggleContinuousSpellChecking:]): (-[WKView toggleGrammarChecking:]): (-[WKView toggleAutomaticSpellingCorrection:]): Get the needed flags from the text checker state.
  • UIProcess/TextChecker.h: Add state() function, remove getters.
  • UIProcess/WebContext.cpp: (WebKit::WebContext::ensureWebProcess): Initialize the text checker state.
  • UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::updateTextCheckerState): Send the SetTextCheckerState message to the web process.
  • UIProcess/mac/TextCheckerMac.mm: (WebKit::initializeState): Initialize the state from the user defaults.

(WebKit::TextChecker::state):
Return the state.

(WebKit::TextChecker::setContinuousSpellCheckingEnabled):
(WebKit::TextChecker::setGrammarCheckingEnabled):
(WebKit::TextChecker::setAutomaticSpellingCorrectionEnabled):
Make sure to write the new state.


  • UIProcess/qt/TextCheckerQt.cpp: (WebKit::TextChecker::state):
  • UIProcess/win/TextCheckerWin.cpp: (WebKit::TextChecker::state): Add stubs.
  • WebKit2.xcodeproj/project.pbxproj: Add TextCheckerState.h.
  • WebProcess/WebProcess.cpp: (WebKit::WebProcess::WebProcess): Initialize m_textCheckerState.

(WebKit::WebProcess::setTextCheckerState):
Update.

  • WebProcess/WebProcess.messages.in: Add SetTextCheckerState message.
  • win/WebKit2.vcproj: Add TextCheckerState.h.
14:29 Changeset [75009] by mrobinson@webkit.org

2011-01-03 Martin Robinson <mrobinson@igalia.com>

Reviewed by Darin Adler.

Remove the last non-GObject usage of PlatformRefPtr and move the code to GRefPtr
https://bugs.webkit.org/show_bug.cgi?id=51846

  • GNUmakefile.am: Remove PlatformRefPtr.h from the sources list.
  • JavaScriptCore.vcproj/WTF/WTF.vcproj: Ditto.
  • jit/ExecutableAllocator.h: Change references to PlatformRefPtr to RefPtr. (JSC::ExecutableAllocator::cacheFlush): Ditto.
  • wtf/PlatformRefPtr.h: Removed.
  • wtf/RandomNumber.cpp: Change references to PlatformRefPtr to RefPtr. (WTF::randomNumber): Ditto.
  • wtf/brew/RefPtrBrew.h: Ditto. (WTF::refIfNotNull): Added. (WTF::derefIfNotNull): Added.
  • wtf/brew/ShellBrew.h: Change references to PlatformRefPtr to RefPtr. (WTF::createRefPtrInstance): Modified to return a RefPtr.
  • wtf/gobject/GRefPtr.cpp: (WTF::refGPtr): Moved from PlatformRefPtr here. (WTF::derefGPtr): Ditto.
  • wtf/gobject/GRefPtr.h: Ditto. (WTF::GRefPtr::GRefPtr): Ditto. (WTF::GRefPtr::~GRefPtr): Ditto. (WTF::GRefPtr::clear): Ditto. (WTF::GRefPtr::isHashTableDeletedValue): Ditto. (WTF::GRefPtr::get): Ditto. (WTF::GRefPtr::operator*): Ditto. (WTF::GRefPtr::operator->): Ditto. (WTF::GRefPtr::operator!): Ditto. (WTF::GRefPtr::operator UnspecifiedBoolType): Ditto. (WTF::GRefPtr::hashTableDeletedValue): Ditto. (WTF::::operator): Ditto. (WTF::::swap): Ditto. (WTF::swap): Ditto. (WTF::operator==): Ditto. (WTF::operator!=): Ditto. (WTF::static_pointer_cast): Ditto. (WTF::const_pointer_cast): Ditto. (WTF::getPtr): Ditto. (WTF::adoptGRef): Ditto. (WTF::refGPtr): Ditto. (WTF::derefGPtr): Ditto.

2011-01-03 Martin Robinson <mrobinson@igalia.com>

Reviewed by Darin Adler.

Remove the last non-GObject usage of PlatformRefPtr and move the code to GRefPtr
https://bugs.webkit.org/show_bug.cgi?id=51846

  • DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: Change usage of PlatformRefPtr back to GRefPtr.

2011-01-03 Martin Robinson <mrobinson@igalia.com>

Reviewed by Darin Adler.

Remove the last non-GObject usage of PlatformRefPtr and move the code to GRefPtr
https://bugs.webkit.org/show_bug.cgi?id=51846

No new tests. This should not introduce any functional changes.

Changed all references to PlatformRefPtr in GTK+ code to GRefPtr. Changed
all references to PlatformRefPtr in Brew code to RefPtr.

2011-01-03 Martin Robinson <mrobinson@igalia.com>

Reviewed by Darin Adler.

Remove the last non-GObject usage of PlatformRefPtr and move the code to GRefPtr
https://bugs.webkit.org/show_bug.cgi?id=51846

Changed all references to PlatformRefPtr in GTK+ code to GRefPtr.

14:28 Changeset [75008] by inferno@chromium.org

Merge 74574

BUG=66748

14:21 Changeset [75007] by inferno@chromium.org

Merge 73927

BUG=66560

14:07 Changeset [75006] by ddkilzer@apple.com

<http://webkit.org/b/51890> Move ResourceLoadPriority.h into WebCore/platform/network

Reviewed by Antti Koivisto.

This is needed to prevent a WebCore/platform policy violation in
my next patch.

  • WebCore.gypi: Updated for moved header.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • platform/network/ResourceLoadPriority.h: Renamed from WebCore/loader/ResourceLoadPriority.h.
14:04 Changeset [75005] by mrobinson@webkit.org

2011-01-04 Martin Robinson <mrobinson@igalia.com>

Reviewed by David Levin.

.gitignore should be updated to reflect Sources rename to Source
https://bugs.webkit.org/show_bug.cgi?id=51893

  • .gitignore: Change all paths that reference the "Sources" directory to say "Source".
13:56 Changeset [75004] by ojan@chromium.org

2011-01-04 Ojan Vafai <ojan@chromium.org>

Increment version number to avoid getting the cached JS file.

  • PrettyPatch/PrettyPatch.rb:
13:52 Changeset [75003] by ojan@chromium.org

2010-12-15 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

anchor the toolbar to the bottom of the diff if the diff doesn't take a full screen of height
https://bugs.webkit.org/show_bug.cgi?id=51162

  • PrettyPatch/PrettyPatch.rb:
  • code-review.js:
13:39 Changeset [75002] by inferno@chromium.org

Merge 73818 Build Fix for 552 branch

BUG=65942

13:35 Changeset [75001] by beidson@apple.com
  • storage/StorageMap.h: mesured? Really?

Reviewed by a spell checker.

13:27 Changeset [75000] by commit-queue@webkit.org

2011-01-04 Zhe Su <suzhe@chromium.org>

Reviewed by Kenneth Russell.

  1. Remove entry for editing/input/ime-composition-clearpreedit.html test.
  2. Improve fast/events/ime-composition-events-001.html to cover more cases. And fix test expectations of chromium port. https://bugs.webkit.org/show_bug.cgi?id=51693
  • fast/events/ime-composition-events-001-expected.txt:
  • fast/events/ime-composition-events-001.html:
  • platform/chromium-mac/fast/events/ime-composition-events-001-expected.txt: Removed.
  • platform/chromium-win/fast/events/ime-composition-events-001-expected.txt: Removed.
  • platform/chromium/fast/events/ime-composition-events-001-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
  • platform/qt/fast/events/ime-composition-events-001-expected.txt: Added.

2011-01-04 Zhe Su <suzhe@chromium.org>

Reviewed by Kenneth Russell.

Fix insertText, setMarkedText and unmarkText methods of
TextInputController to call corresponding methods of WebKit::WebView
rather than WebKit::WebFrame. This change matches the behavior of
chromium browser.
insertText corresponds to WebView::confirmComposition(text)
setMarkedText corresponds to WebView::setComposition(...)
unmarkText corresponds to WebView::confirmComposition()
https://bugs.webkit.org/show_bug.cgi?id=51693

  • DumpRenderTree/chromium/TextInputController.cpp: (TextInputController::insertText): (TextInputController::setMarkedText): (TextInputController::unmarkText):

2011-01-04 Zhe Su <suzhe@chromium.org>

Reviewed by Kenneth Russell.

Changes:

  1. Add WebKit::WebWidget::confirmComposition(const WebString& text) This new method corresponds to Editor::confirmComposition(text) and Editor::insertText(text). It'll be used by both DumpRenderTree's TextInputController and chromium browser.
  2. Fix WebFrameImpl::insertText It should call Editor::confirmComposition(text) rather than Editor::insertText(text) if there is an ongoing composition. It matches the behavior of WebKit Mac port.
  3. Fix WebFrameImpl::setMarkedText Editor::confirmComposition(text) shouldn't be called in this method, which incorrectly inserts the text.

https://bugs.webkit.org/show_bug.cgi?id=51693

  • public/WebWidget.h:
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::insertText): (WebKit::WebFrameImpl::setMarkedText):
  • src/WebPopupMenuImpl.cpp: (WebKit::WebPopupMenuImpl::confirmComposition):
  • src/WebPopupMenuImpl.h:
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::confirmComposition):
  • src/WebViewImpl.h:
  • tests/PopupMenuTest.cpp: (WebKit::TestWebWidget::confirmComposition):

2011-01-04 Zhe Su <suzhe@chromium.org>

Reviewed by Kenneth Russell.

Fix test LayoutTests/fast/events/ime-composition-events-001.html.

https://bugs.webkit.org/show_bug.cgi?id=51693

  • Api/qwebpage.cpp: (QWebPagePrivate::inputMethodEvent): Calls editor->insertText() to insert the commit string when no composition text is available.
13:23 Changeset [74999] by beidson@apple.com

Attach a radar # to this FIXME:

  • WebProcess/WebPage/WebBackForwardListProxy.cpp:

Rubberstamped by Anders Carlsson.

13:12 Changeset [74998] by laszlo.1.gombos@nokia.com

2011-01-04 Dihan Wickremasuriya <dihan.wickremasuriya@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] [Symbian] Build system cleanup

After r74811 special handling for the Symbian build is no longer needed.
This patch reverts r58756.

  • WebKit.pri:
13:09 Changeset [74997] by commit-queue@webkit.org

2011-01-04 Carlos Garcia Campos <cgarcia@igalia.com> and Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Port stock icon painting to GtkStyleContext
https://bugs.webkit.org/show_bug.cgi?id=51764

Port stock icon painting for media and search input elements to
GtkStyleContext. Also create the initial machinery for accessing
style contexts for all GTK+ 3.x based widgets.

No new tests. This should not change functionality.

  • platform/gtk/RenderThemeGtk.cpp: (WebCore::paintGdkPixbuf): (WebCore::RenderThemeGtk::paintSearchFieldResultsDecoration): (WebCore::RenderThemeGtk::paintSearchFieldCancelButton): (WebCore::RenderThemeGtk::paintMediaButton):
  • platform/gtk/RenderThemeGtk.h:
  • platform/gtk/RenderThemeGtk2.cpp: (WebCore::RenderThemeGtk::getStockIcon):
  • platform/gtk/RenderThemeGtk3.cpp: (WebCore::gtkStyleChangedCallback): (WebCore::styleContextMap): (WebCore::getStyleContext): (WebCore::RenderThemeGtk::paintMenuList):
12:47 Changeset [74996] by ddkilzer@apple.com

<http://webkit.org/b/51889> WebFrameLoaderClient::createMediaPlayerProxyPlugin() should use WebCore::PluginInfo.name

Reviewed by Eric Carlson.

This originally broke in r61581. It is inside an
ENABLE(PLUGIN_PROXY_FOR_VIDEO) macro, so it didn't break the Mac
build then.

  • WebCoreSupport/WebFrameLoaderClient.mm: Call

(WebFrameLoaderClient::createMediaPlayerProxyPlugin): Updated to
use WebCore::PluginInfo.name instead of
-[WebBasePluginPackage name].

12:46 Changeset [74995] by antti@apple.com

WebCore: Scripts should not be executed before preceding stylesheets are loaded
https://bugs.webkit.org/show_bug.cgi?id=8852

Reviewed by Dave Hyatt.

Block inline script execution on pending stylesheet loads. This matches
other browsers and HTML5.

Tests: fast/tokenizer/inline-script-stylesheet-write.html

fast/tokenizer/inline-script-stylesheet.html

  • dom/PendingScript.cpp:

(WebCore::PendingScript::releaseElementAndClear):

  • dom/PendingScript.h:

(WebCore::PendingScript::PendingScript):
(WebCore::PendingScript::operator=):
(WebCore::PendingScript::startingPosition):
(WebCore::PendingScript::setStartingPosition):

  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::process):

This fixes an unrelated bug with beforeload events that was exposed by the other
changes (fast/dom/beforeload/remove-link-in-beforeload-listener.html).

  • html/parser/HTMLScriptRunner.cpp:

(WebCore::HTMLScriptRunner::sourceFromPendingScript):
(WebCore::HTMLScriptRunner::runScript):

LayoutTests: Scripts should not be executed before preceding stylesheets are loaded
https://bugs.webkit.org/show_bug.cgi?id=8852

Reviewed by Dave Hyatt.

New tests plus a few test with slightly changed output due to different load serialization behavior.

  • fast/tokenizer/inline-script-stylesheet-expected.txt: Added.
  • fast/tokenizer/inline-script-stylesheet-write-expected.txt: Added.
  • fast/tokenizer/inline-script-stylesheet-write.html: Added.
  • fast/tokenizer/inline-script-stylesheet.html: Added.
  • http/tests/security/mixedContent/insecure-css-in-main-frame-expected.txt:
  • platform/mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
12:43 Changeset [74994] by commit-queue@webkit.org

2011-01-04 Xianzhu Wang <wangxianzhu@google.com>

Reviewed by Darin Adler.

Let DataView.getInt8() and DataView.setInt8() use int8_t instead of
ambiguous 'char' to fix fast/canvas/webgl/data-view-test.html failure
on ARM.
https://bugs.webkit.org/show_bug.cgi?id=51861

By the way, changed other getIntXX() and setIntXX() methods to use
more precise integer types.

  • bindings/js/JSDataViewCustom.cpp: (WebCore::setDataViewMember):
  • bindings/v8/custom/V8DataViewCustom.cpp: (WebCore::V8DataView::getInt8Callback): (WebCore::V8DataView::setInt8Callback):
  • html/canvas/DataView.cpp: (WebCore::DataView::getInt8): (WebCore::DataView::setInt8):
  • html/canvas/DataView.h:
  • html/canvas/DataView.idl:
12:34 Changeset [74993] by ossy@webkit.org

Unreviewed trivial fix after r74976.

  • platform/qt/Skipped:
12:20 Changeset [74992] by commit-queue@webkit.org

2011-01-04 Yong Li <yoli@rim.com>

Reviewed by Adam Barth.

Suspend HTMLParserScheduler when page load is deferred to
avoid potential JS re-entrancy. Otherwise, when JS execution is triggered
from an external script or by events, and is blocked by a modal dialog,
WebKit can parse more HTML source and also start another JS execution.

https://bugs.webkit.org/show_bug.cgi?id=48077

Test case: WebCore/manual-tests/bugzilla-48077.html.

  • dom/DocumentParser.cpp: (WebCore::DocumentParser::suspendScheduledTasks): (WebCore::DocumentParser::resumeScheduledTasks):
  • dom/DocumentParser.h:
  • html/parser/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::suspendScheduledTasks): (WebCore::HTMLDocumentParser::resumeScheduledTasks):
  • html/parser/HTMLParserScheduler.cpp: (WebCore::HTMLParserScheduler::HTMLParserScheduler): (WebCore::HTMLParserScheduler::suspend): (WebCore::HTMLParserScheduler::resume):
  • html/parser/HTMLParserScheduler.h: (WebCore::HTMLParserScheduler::isScheduledForResume):
  • page/PageGroupLoadDeferrer.cpp: (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer): (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
12:07 Changeset [74991] by rniwa@webkit.org

Merge 73818 - 2010-12-10 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

REGRESSION(r73799): editing/execCommand/4920488.html fails
https://bugs.webkit.org/show_bug.cgi?id=50854

The regression was caused by Range::processContents's not extracting
m_end.container()->firstChild(). Fixed the bug by always adding the first child.

  • dom/Range.cpp: (WebCore::Range::processContents):

TBR=rniwa@webkit.org
BUG=65942

12:04 Changeset [74990] by rniwa@webkit.org

Merge 73799 - 2010-12-10 Emil Eklund <eae@chromium.org>

Reviewed by Adam Barth.

Fix crash in Range::processContents when modified during mutation event.
https://bugs.webkit.org/show_bug.cgi?id=50710

Test: fast/dom/Range/range-extractContents.html

  • dom/Range.cpp: (WebCore::Range::processContents): Replace raw pointers with RefPtrs and add checks.

2010-12-10 Emil Eklund <eae@chromium.org>

Reviewed by Adam Barth.

Add testcase for range.extractContents crash.
https://bugs.webkit.org/show_bug.cgi?id=50710

  • fast/dom/Range/range-extractContents-expected.txt: Added.
  • fast/dom/Range/range-extractContents.html: Added.

TBR=inferno@chromium.org
BUG=65942

11:49 Changeset [74989] by andersca@apple.com

2011-01-04 Anders Carlsson <andersca@apple.com>

Reviewed by John Sullivan.

Add more spelling/grammar related methods
https://bugs.webkit.org/show_bug.cgi?id=51886

  • UIProcess/API/mac/WKView.mm: (-[WKView validateUserInterfaceItem:]): Handle more selectors.

(-[WKView showGuessPanel:]):
Add stub.

(-[WKView checkSpelling:]):
Ditto.

(-[WKView toggleAutomaticSpellingCorrection:]):
Toggle automatic spelling correction.

  • UIProcess/TextChecker.h: Add setAutomaticSpellingCorrectionEnabled and isAutomaticSpellingCorrectionEnabled.
  • UIProcess/mac/TextCheckerMac.mm: (WebKit::TextChecker::setAutomaticSpellingCorrectionEnabled): (WebKit::TextChecker::isAutomaticSpellingCorrectionEnabled): Update the toggle.
  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
  • WebProcess/WebCoreSupport/mac/WebErrorsMac.mm: Add a Radar URL for the localization FIXMEs.
11:40 Changeset [74988] by bfulgham@webkit.org

Unreviewed build fix.

  • win/WebKit2.vcproj: Correct the missing $(WebKitVSPropsRedirectionDir)

variables that Visual Studio helpfully removes when making changes.

11:38 Changeset [74987] by inferno@chromium.org

Merge 74954

BUG=66760

11:35 Changeset [74986] by inferno@chromium.org

Merge 74364

BUG=66760

11:33 Changeset [74985] by dbates@webkit.org

2011-01-04 Daniel Bates <dbates@rim.com>

Fix the date recorded in the change log entry for changeset 74973 <http://trac.webkit.org/changeset/74973>.
It was recorded as "2011-01-03". Instead, it should be "2011-01-04" to correspond
with the date this changeset was committed.

11:29 Changeset [74984] by inferno@chromium.org

Merge 74787

BUG=68181

11:29 Changeset [74983] by dbates@webkit.org

2011-01-04 Daniel Bates <dbates@rim.com>

Reviewed by Adam Roben.

LEAK: Deallocate instance of ThreadFunctionInvocation if thread creation fails
https://bugs.webkit.org/show_bug.cgi?id=51860

  • wtf/ThreadingWin.cpp: (WTF::createThreadInternal):
11:26 Changeset [74982] by inferno@chromium.org

Merge 74781

BUG=66986

11:24 Changeset [74981] by inferno@chromium.org

Merge 74743

BUG=65796

11:21 Changeset [74980] by bfulgham@webkit.org

Unreviewed build fix.

  • win/WebKit2.vcproj: Disable CG-specific WKImageCG.cpp from

Debug_Cairo_CFLite/Release_Cario_CFLite builds.

11:19 Changeset [74979] by inferno@chromium.org

Merge 73801

BUG=66473

11:16 Changeset [74978] by laszlo.1.gombos@nokia.com

2011-01-04 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Ariya Hidayat.

[Qt][Symbian] Make sure that WebKit headers are included before platform headers on Symbian
https://bugs.webkit.org/show_bug.cgi?id=31273

On Symbian PREPEND_INCLUDEPATH is the best way to make sure that WebKit headers
are included before platform headers. On all other platforms continue to use
INCLUDEPATH (as before). This is a continuation of r65877.

No new tests as there is no new functionality.

11:11 Changeset [74977] by darin@apple.com

Try to fix Windows build.

  • wtf/ThreadingWin.cpp: Added include of PassOwnPtr.h. Fixed paragraphing

of conditional includes.
(WTF::wtfThreadEntryPoint): Use -> instead of . to dereference pointer.
(WTF::createThreadInternal): Tweaked #if to not need separate macro.

11:04 Changeset [74976] by rniwa@webkit.org

2011-01-04 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed; Added editing/selection/caret-bidi-first-and-last-letters.html to Qt's skipped list.
The tracking bug 51884 (https://bugs.webkit.org/show_bug.cgi?id=51884) has been filed.

  • platform/qt/Skipped:
10:56 Changeset [74975] by dbates@webkit.org

2011-01-04 Daniel Bates <dbates@rim.com>

Reviewed by Adam Roben.

Extract ThreadFunctionInvocation into separate file and share between Apple Windows and Android
https://bugs.webkit.org/show_bug.cgi?id=51855

Both the Apple Windows and Android ports implement a similar adapter structure,
called ThreadFunctionInvocation and ThreadData respectively, as part of
their thread creation process. Instead, we should share such an adapter
structure and remove duplicate code.

  • JavaScriptCore.gypi: Added header wtf/ThreadFunctionInvocation.h.
  • wtf/ThreadFunctionInvocation.h: Added. (WTF::ThreadFunctionInvocation::ThreadFunctionInvocation):
  • wtf/ThreadingPthreads.cpp: Removed Android-specific structure ThreadData; Instead, use ThreadFunctionInvocation. (WTF::runThreadWithRegistration): (WTF::createThreadInternal):
  • wtf/ThreadingWin.cpp: Moved structure ThreadFunctionInvocation to its own file so that it can be shared with the Android implementation of createThreadInternal(). (WTF::wtfThreadEntryPoint): Use OwnPtr to hold passed instance of ThreadFunctionInvocation.
10:53 Changeset [74974] by laszlo.1.gombos@nokia.com

2011-01-04 Dihan Wickremasuriya <dihan.wickremasuriya@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] [Symbian] Do not remove 0 byte sized files from productDir

On Symbian productDir points to the source directory. Removing all the
empty files from the productDir directory corrupts the svn repository.

  • Scripts/build-webkit:
10:32 BuildBot edited by wsiegrist@apple.com
Add umask change for slaves (diff)
09:44 Changeset [74973] by dbates@webkit.org

2011-01-03 Daniel Bates <dbates@rim.com>

Reviewed by Darin Adler.

Use builtin_expect when compiling using RVCT in GNU mode
https://bugs.webkit.org/show_bug.cgi?id=51866

Derived from a patch by Dave Tapuska.

  • wtf/AlwaysInline.h:
09:29 Changeset [74972] by tonyg@chromium.org

2011-01-04 Tony Gentilcore <tonyg@chromium.org>

Unreviewed build fix.

Include glib-object.h for GObject
https://bugs.webkit.org/show_bug.cgi?id=51876

  • bindings/gobject/DOMObjectCache.cpp:
09:21 Changeset [74971] by rniwa@webkit.org

2011-01-04 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Dan Bernstein.

Clicking on the first or the last letter of LTR/RTL text in a RTL/LTR block puts caret on the opposite side.
https://bugs.webkit.org/show_bug.cgi?id=50992

Fixed the bug by interchanging the offset when the direction of inline text box and the containing block
does not match. Reused the code added by http://trac.webkit.org/changeset/73553.

Test: editing/selection/caret-bidi-first-and-last-letters.html

  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::offsetForPosition):

2011-01-04 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Dan Bernstein.

Clicking on the first or the last letter of LTR/RTL text in a RTL/LTR block puts caret on the opposite side.
https://bugs.webkit.org/show_bug.cgi?id=50992

Added a test to ensure WebKit places the caret on the side user clicked even when text's natural direction
and the containing block's direction do not match.

  • editing/selection/caret-bidi-first-and-last-letters-expected.txt: Added.
  • editing/selection/caret-bidi-first-and-last-letters.html: Added.
  • editing/selection/resources/caret-edge-shared.js: Avoid calling verify() outside of DRT.
09:05 Changeset [74970] by beidson@apple.com

https://bugs.webkit.org/show_bug.cgi?id=51856
Pass encoded back/forward tree data from the WebProcess to the UIProcess

Reviewed by Darin Adler.

Remove the WKBackForwardListItemCopyOriginalURL API as it's not needed:

  • UIProcess/API/C/WKBackForwardListItem.cpp:
  • UIProcess/API/C/WKBackForwardListItem.h:
  • UIProcess/API/qt/qwkhistory.cpp:
  • UIProcess/API/qt/qwkhistory.h:


  • UIProcess/WebBackForwardListItem.cpp:

(WebKit::WebBackForwardListItem::WebBackForwardListItem):

  • UIProcess/WebBackForwardListItem.h:

(WebKit::WebBackForwardListItem::create):
(WebKit::WebBackForwardListItem::setBackForwardData):
(WebKit::WebBackForwardListItem::backForwardData):

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::addBackForwardItem):

  • UIProcess/WebProcessProxy.h:


  • UIProcess/WebProcessProxy.messages.in:


  • WebProcess/WebPage/WebBackForwardListProxy.cpp:

(WebKit::updateBackForwardItem):

08:56 Changeset [74969] by tonyg@chromium.org

2010-12-29 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Darin Adler.

Remove 2 unnecessary includes from Document.h
https://bugs.webkit.org/show_bug.cgi?id=51727

No new tests because no changed functionality.

  • dom/Document.cpp:
  • dom/Document.h:
  • editing/Editor.cpp:
  • editing/SpellChecker.h:
  • editing/SplitTextNodeCommand.cpp:
  • editing/TextCheckingHelper.cpp:
  • page/FrameView.cpp:
  • page/Page.cpp:
  • rendering/HitTestResult.cpp:
  • rendering/InlineTextBox.cpp:
  • rendering/InlineTextBox.h:
  • rendering/svg/SVGInlineFlowBox.cpp:
07:33 Changeset [74968] by paroga@webkit.org

2011-01-04 Patrick Gansterer <paroga@webkit.org>

Unreviewed WinCE build fix.

  • CMakeListsWinCE.txt: Added missing include directories, files and libraries.
06:01 Changeset [74967] by kbalazs@webkit.org

2011-01-04 Balazs Kelemen <kbalazs@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt][WK2] Incomplete clean up on termination
https://bugs.webkit.org/show_bug.cgi?id=51474

Do not kill the web process to force it's termination.
Fix object destruction and cleanup logic and make the cleanup more reliable.
Do not try to cleanup on crash because it is not reliable.

  • Platform/CoreIPC/qt/ConnectionQt.cpp: (CoreIPC::Connection::platformInvalidate): Do not delete the socket if we do not own it. This is the case with a server connection.
  • Platform/qt/MappedMemoryPool.cpp: Turn MappedMemoryPool into a QObject so the CleanupHandler can destruct it in the same way as the other objects. (WebKit::MappedMemoryPool::instance): (WebKit::MappedMemoryPool::~MappedMemoryPool):
  • Platform/qt/MappedMemoryPool.h: (WebKit::MappedMemoryPool::MappedMemoryPool):
  • Platform/qt/SharedMemoryQt.cpp: (WebKit::SharedMemory::create): No need to care about QCoreApplication::aboutToQuit. It is handled by the CleanupHandler. (WebKit::SharedMemory::~SharedMemory): Ditto.
  • Shared/qt/CleanupHandler.cpp: Renamed from WebKit2/Shared/qt/CrashHandler.cpp. No longer try to handle crash but just normal termination. (WebKit::CleanupHandler::CleanupHandler): Connect deleteObjects with QCoreApplication::aboutToQuit. Ensure appropriate thread affinity. (WebKit::CleanupHandler::sigTermHandler): Stop the main event loop. (WebKit::CleanupHandler::deleteObjects): Use deleteLater instead of delete since it is more reliable.
  • Shared/qt/CleanupHandler.h: Renamed from WebKit2/Shared/qt/CrashHandler.h. (WebKit::CleanupHandler::instance): (WebKit::CleanupHandler::markForCleanup): (WebKit::CleanupHandler::unmark):
  • UIProcess/Launcher/qt/ProcessLauncherQt.cpp: Do not kill the web process immidiately but give it a chance to cleanup. Use QLocalServer::removeServer for assuring that the socket file will be removed. (WebKit::ProcessLauncherHelper::serverName): (WebKit::cleanupAtExit): Renamed from cleanupProcesses. Only kill the web process when it times out terminating. Fixed the bug of changing the list while iterating it over by disconnecting from the processStateChanged slot. (WebKit::QtWebProcess::QtWebProcess): Added missing meta type registration of QProcess::ProcessState. (WebKit::ProcessLauncherHelper::~ProcessLauncherHelper): (WebKit::ProcessLauncherHelper::ProcessLauncherHelper): No need to add the the instance to the CleanupHandler because we will remove the socket file in cleanupAtExit. (WebKit::ProcessLauncherHelper::instance): (WebKit::ProcessLauncher::terminateProcess):
  • WebKit2.pro:
05:44 Changeset [74966] by paroga@webkit.org

2011-01-04 Patrick Gansterer <paroga@webkit.org>

Unreviewed WinCE build fix.

  • WebCoreSupport/ChromeClientWinCE.cpp: (WebKit::ChromeClientWinCE::exceededDatabaseQuota): Added missing semicolon. (WebKit::ChromeClientWinCE::reachedApplicationCacheOriginQuota):
  • WebCoreSupport/ChromeClientWinCE.h:
05:17 Changeset [74965] by commit-queue@webkit.org

2011-01-04 Yi Shen <yi.4.shen@nokia.com>

Reviewed by Simon Hausmann.

Provide an interface to require using fullscreen mediaplayer
https://bugs.webkit.org/show_bug.cgi?id=51133

Only video should be displayed in fullscreen when
requiresFullscreenForVideoPlayback is specified.

No new tests because no client implements requiresFullscreenForVideoPlayback yet.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::updatePlayState):
03:53 Changeset [74964] by benjamin.poulain@nokia.com

2011-01-04 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] [WK2] create an initial implementation of the context menu handling for WebKit 2
https://bugs.webkit.org/show_bug.cgi?id=51825

Implement contextMenuItemVector() for Qt, this method is used in WebKit 2 to get the
platform independent menu informations.

  • platform/qt/ContextMenuQt.cpp: (WebCore::contextMenuItemVector):

2011-01-04 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] [WK2] create an initial implementation of the context menu handling for WebKit 2
https://bugs.webkit.org/show_bug.cgi?id=51825

Implement the necessary methods to get a basic context menu working for Qt.

Only 4 basic WebAction have been added on the UIProcess side: back, forward, stop and reload.

  • UIProcess/API/qt/qgraphicswkview.cpp: (QGraphicsWKView::QGraphicsWKView): (QGraphicsWKView::showContextMenu): (QGraphicsWKViewPrivate::QGraphicsWKViewPrivate):
  • UIProcess/API/qt/qgraphicswkview.h:
  • UIProcess/API/qt/qwkpage.cpp: (QWKPagePrivate::createContextMenuProxy):
  • UIProcess/API/qt/qwkpage.h:
  • UIProcess/qt/WebContextMenuProxyQt.cpp: (WebKit::webActionForContextMenuAction): (WebKit::WebContextMenuProxyQt::WebContextMenuProxyQt): (WebKit::WebContextMenuProxyQt::create): (WebKit::WebContextMenuProxyQt::showContextMenu): (WebKit::WebContextMenuProxyQt::hideContextMenu): (WebKit::WebContextMenuProxyQt::createContextMenu):
  • UIProcess/qt/WebContextMenuProxyQt.h:
02:43 Changeset [74963] by commit-queue@webkit.org

2011-01-04 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r74960.
http://trac.webkit.org/changeset/74960
https://bugs.webkit.org/show_bug.cgi?id=51868

Rollout since we hit an assert after this patch. (Requested by
krit on #webkit).

  • svg/custom/recursive-use-expected.txt: Removed.
  • svg/custom/recursive-use.svg: Removed.

2011-01-04 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r74960.
http://trac.webkit.org/changeset/74960
https://bugs.webkit.org/show_bug.cgi?id=51868

Rollout since we hit an assert after this patch. (Requested by
krit on #webkit).

  • svg/SVGUseElement.cpp: (WebCore::SVGUseElement::buildInstanceTree):
01:43 Changeset [74962] by philn@webkit.org

2011-01-04 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r74961.
http://trac.webkit.org/changeset/74961
https://bugs.webkit.org/show_bug.cgi?id=51867

breaks 32/64-bits debug bots build (Requested by philn-tp on
#webkit).

  • platform/graphics/gstreamer/GStreamerGWorld.cpp: (WebCore::GStreamerGWorld::setWindowOverlay):
01:12 Changeset [74961] by philn@webkit.org

2011-01-03 Philippe Normand <pnormand@igalia.com>

Rubber-stamped by Eric Seidel.

[GStreamer] build fails with gstreamer core 0.10.31 and -plugins-base 0.10.30
https://bugs.webkit.org/show_bug.cgi?id=51810

Based on a patch by Mart Raudsepp.

No new tests, build fix only.

  • platform/graphics/gstreamer/GStreamerGWorld.cpp: (WebCore::GStreamerGWorld::setWindowOverlay): Use the new xoverlay API if the GST_CHECK_PLUGINS_BASE_VERSION macro is defined. It was introduced in same version as the xoverlay API change.
01:11 Changeset [74960] by commit-queue@webkit.org

2011-01-04 Leo Yang <leo.yang@torchmobile.com.cn>

Reviewed by Dirk Schulze.

Malformed SVG causes crash in updateContainerOffset
https://bugs.webkit.org/show_bug.cgi?id=44610

Test case for recursive svg <use>.
This test case passes if no crash occurs.

  • svg/custom/recursive-use-expected.txt: Added.
  • svg/custom/recursive-use.svg: Added.

2011-01-04 Leo Yang <leo.yang@torchmobile.com.cn>

Reviewed by Dirk Schulze.

Malformed SVG causes crash in updateContainerOffset
https://bugs.webkit.org/show_bug.cgi?id=44610

We should check recursive <use> at the begining of
WebCore::SVGUseElement::buildInstanceTree instead
of at the end of it because the target element's
children may cause infinite recursive <use>.

Test: svg/custom/recursive-use.svg

  • svg/SVGUseElement.cpp: (WebCore::SVGUseElement::buildInstanceTree):
00:33 Changeset [74959] by tkent@chromium.org

2011-01-04 Kent Tamura <tkent@chromium.org>

Unreviewed, build fix.

Try to fix Clang build.

  • css/CSSParser.cpp: (WebCore::valueFromSideKeyword): (WebCore::CSSParser::parseLinearGradient):

01/03/11:

22:47 Changeset [74958] by tkent@chromium.org

2011-01-03 Kent Tamura <tkent@chromium.org>

Unreviewed, test expectation update

Add expectations of r74954 tests for Chromium.

  • platform/chromium-linux/fast/css-generated-content/table-before-after-child-add-expected.checksum: Added.
  • platform/chromium-linux/fast/css-generated-content/table-before-after-child-add-expected.png: Added.
  • platform/chromium-linux/fast/css-generated-content/table-cell-before-after-child-add-expected.checksum: Added.
  • platform/chromium-linux/fast/css-generated-content/table-cell-before-after-child-add-expected.png: Added.
  • platform/chromium-linux/fast/css-generated-content/table-row-before-after-child-add-expected.checksum: Added.
  • platform/chromium-linux/fast/css-generated-content/table-row-before-after-child-add-expected.png: Added.
  • platform/chromium-linux/fast/css-generated-content/table-table-before-after-child-add-expected.checksum: Added.
  • platform/chromium-linux/fast/css-generated-content/table-table-before-after-child-add-expected.png: Added.
  • platform/chromium-mac/fast/css-generated-content/table-before-after-child-add-expected.checksum: Added.
  • platform/chromium-mac/fast/css-generated-content/table-before-after-child-add-expected.png: Added.
  • platform/chromium-mac/fast/css-generated-content/table-cell-before-after-child-add-expected.checksum: Added.
  • platform/chromium-mac/fast/css-generated-content/table-cell-before-after-child-add-expected.png: Added.
  • platform/chromium-mac/fast/css-generated-content/table-row-before-after-child-add-expected.checksum: Added.
  • platform/chromium-mac/fast/css-generated-content/table-row-before-after-child-add-expected.png: Added.
  • platform/chromium-mac/fast/css-generated-content/table-table-before-after-child-add-expected.checksum: Added.
  • platform/chromium-mac/fast/css-generated-content/table-table-before-after-child-add-expected.png: Added.
  • platform/chromium-win/fast/css-generated-content/table-before-after-child-add-expected.checksum: Added.
  • platform/chromium-win/fast/css-generated-content/table-before-after-child-add-expected.png: Added.
  • platform/chromium-win/fast/css-generated-content/table-before-after-child-add-expected.txt: Added.
  • platform/chromium-win/fast/css-generated-content/table-cell-before-after-child-add-expected.checksum: Added.
  • platform/chromium-win/fast/css-generated-content/table-cell-before-after-child-add-expected.png: Added.
  • platform/chromium-win/fast/css-generated-content/table-cell-before-after-child-add-expected.txt: Added.
  • platform/chromium-win/fast/css-generated-content/table-row-before-after-child-add-expected.checksum: Added.
  • platform/chromium-win/fast/css-generated-content/table-row-before-after-child-add-expected.png: Added.
  • platform/chromium-win/fast/css-generated-content/table-row-before-after-child-add-expected.txt: Added.
  • platform/chromium-win/fast/css-generated-content/table-table-before-after-child-add-expected.checksum: Added.
  • platform/chromium-win/fast/css-generated-content/table-table-before-after-child-add-expected.png: Added.
  • platform/chromium-win/fast/css-generated-content/table-table-before-after-child-add-expected.txt: Added.
22:20 Changeset [74957] by ddkilzer@apple.com

WebCore: HTML5 Conformance Test failure: approved/xhtml5/object_border_pixel.xhtml
https://bugs.webkit.org/show_bug.cgi?id=48596

Patch by Julie-Jeongeun-Kim <Jeongeun.Kim@obigo.com> on 2011-01-03
Reviewed by Darin Adler.

border attribute was not parsed in HTMLObjectElement.
I added code for it as HTMLImageElement handled.

new test:fast/html/object-border.html

  • html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::parseMappedAttribute):

LayoutTests: HTML5 Conformance Test failure: approved/xhtml5/object_border_pixel.xhtml
https://bugs.webkit.org/show_bug.cgi?id=48596

Patch by Julie-Jeongeun-Kim <Jeongeun.Kim@obigo.com> on 2011-01-03
Reviewed by Darin Adler.

  • fast/html/object-border-expected.txt: Added.
  • fast/html/object-border.html: Added.
  • fast/html/resources/images/blue-border.png: Added.
  • fast/html/resources/images/blue.png: Added.
21:36 Changeset [74956] by darin@apple.com

Try to fix Chromium build.

  • history/HistoryItem.cpp:

(WebCore::HistoryItem::encodeBackForwardTreeNode): Added a V8 case here.
Not sure this ever will be used with V8.
(WebCore::HistoryItem::decodeBackForwardTree): Ditto.

21:31 Changeset [74955] by darin@apple.com

Try to fix Leopard build.

  • history/HistoryItem.cpp: Use a consistent type, uint64_t, for the

size variable.

18:27 Changeset [74954] by inferno@chromium.org

2011-01-01 Abhishek Arya <inferno@chromium.org>

Reviewed by Darin Adler.

Fixes before child calculation when adding anonymous childs to table parts.
https://bugs.webkit.org/show_bug.cgi?id=50932

Fix in r74364 was incomplete. When before child is equal to the table part(to
which the new child is getting added), it confuses the table part to add it
incorrectly as an after child. The patch fixes by passing the before child as
the table part's first child.

Tests: fast/css-generated-content/table-before-after-child-add.html

fast/css-generated-content/table-cell-before-after-child-add.html
fast/css-generated-content/table-row-before-after-child-add.html
fast/css-generated-content/table-row-before-after-child-add.html

  • rendering/RenderTable.cpp: (WebCore::RenderTable::addChild):
  • rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::addChild):
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::addChild):

2010-12-20 Abhishek Arya <inferno@chromium.org>

Reviewed by Darin Adler.

Tests that "before" and "after" childs are added to table correctly.
https://bugs.webkit.org/show_bug.cgi?id=50932

  • fast/css-generated-content/table-before-after-child-add.html: Added.
  • fast/css-generated-content/table-before-child-add.html: Removed.
  • fast/css-generated-content/table-cell-before-after-child-add.html: Added.
  • fast/css-generated-content/table-row-before-after-child-add.html: Added.
  • platform/mac/fast/css-generated-content/table-before-after-child-add-expected.checksum: Added.
  • platform/mac/fast/css-generated-content/table-before-after-child-add-expected.png: Added.
  • platform/mac/fast/css-generated-content/table-before-after-child-add-expected.txt: Added.
  • platform/mac/fast/css-generated-content/table-before-child-add-expected.txt: Removed.
  • platform/mac/fast/css-generated-content/table-cell-before-after-child-add-expected.checksum: Added.
  • platform/mac/fast/css-generated-content/table-cell-before-after-child-add-expected.png: Added.
  • platform/mac/fast/css-generated-content/table-cell-before-after-child-add-expected.txt: Added.
  • platform/mac/fast/css-generated-content/table-row-before-after-child-add-expected.checksum: Added.
  • platform/mac/fast/css-generated-content/table-row-before-after-child-add-expected.png: Added.
  • platform/mac/fast/css-generated-content/table-row-before-after-child-add-expected.txt: Added.
  • platform/mac/fast/css-generated-content/table-table-before-after-child-add-expected.checksum: Added.
  • platform/mac/fast/css-generated-content/table-table-before-after-child-add-expected.png: Added.
  • platform/mac/fast/css-generated-content/table-table-before-after-child-add-expected.txt: Added.
18:02 Changeset [74953] by mitz@apple.com

Shrink HTMLTableCellElement
https://bugs.webkit.org/show_bug.cgi?id=51858

Reviewed by Simon Fraser.

  • html/HTMLTableCellElement.cpp:

(WebCore::HTMLTableCellElement::HTMLTableCellElement): Removed intialization of m_row and
m_col.

  • html/HTMLTableCellElement.h: Removed m_row and m_col and their accessors.
17:57 Changeset [74952] by darin@apple.com

Fix build.

  • platform/network/FormData.cpp:

(WebCore::FormData::create): Roll back uint8_t change.
(WebCore::FormData::flatten): Ditto.
(WebCore::FormData::flattenToString): Ditto.
(WebCore::encode): Ditto.
(WebCore::decode): Ditto.
(WebCore::FormData::encodeForBackForward):

  • platform/network/FormData.h: Ditto.
  • platform/network/mac/FormDataStreamMac.mm:

(WebCore::advanceCurrentStream): Ditto.

17:35 Changeset [74951] by darin@apple.com

2011-01-03 Darin Adler <darin@apple.com>

Reviewed by Brady Eidson.

Add code to encode/decode the back/forward tree
https://bugs.webkit.org/show_bug.cgi?id=51853

  • history/HistoryItem.cpp: (WebCore::HistoryItem::encodeBackForwardTree): Added. (WebCore::HistoryItem::encodeBackForwardTreeNode): Added. (WebCore::HistoryItem::decodeBackForwardTree): Added.
  • history/HistoryItem.h: Added functions above.
  • platform/network/FormData.cpp: (WebCore::FormData::create): Changed type to Vector<uint8_t> instead of Vector<char>. This type is used in our newer code for vectors of bytes. (WebCore::FormData::flatten): Ditto. (WebCore::FormData::flattenToString): Ditto. Had to add a cast here. (WebCore::FormData::encodeForBackForward): Added. (WebCore::FormData::decodeForBackForward): Added.
  • platform/network/FormData.h: Changed type to Vector<uint8_t> instead of Vector<char>. Also made some single-argument constructors explicit. Also added the new functions.
  • platform/network/mac/FormDataStreamMac.mm: (WebCore::advanceCurrentStream): Changed to use uint8_t to match above.
17:28 Changeset [74950] by simon.fraser@apple.com

2011-01-03 Simon Fraser <simon.fraser@apple.com>

Attempt to fix GTK build.

  • platform/graphics/gtk/FontGtk.cpp: (WebCore::drawGlyphsShadow):
16:54 Changeset [74949] by psolanki@apple.com

Mac build fix. Define WTF_USE_CFNETWORK for Windows build only.

  • WebCoreSupport/WebInspectorClientCF.cpp:
16:39 Changeset [74948] by bweinstein@apple.com

Windows build fix. Define WTF_USE_CFNETWORK in WebInspectorClientCF.

  • WebCoreSupport/WebInspectorClientCF.cpp:
16:21 Changeset [74947] by commit-queue@webkit.org

2011-01-03 Helder Correia <helder@sencha.com>

Reviewed by Simon Fraser.

ContextShadow can avoid code duplication for getting the CTM
https://bugs.webkit.org/show_bug.cgi?id=51799

ContextShadow defines its own getTransformationMatrixFromContext()
which does exactly the same as GraphicsContext::getCTM().

Existing tests: fast/canvas/canvas*shadow*html

  • platform/graphics/ContextShadow.cpp: (WebCore::ContextShadow::mustUseContextShadow): (WebCore::ContextShadow::adjustBlurDistance): (WebCore::ContextShadow::calculateLayerBoundingRect):
  • platform/graphics/ContextShadow.h:
  • platform/graphics/cairo/ContextShadowCairo.cpp: (WebCore::ContextShadow::beginShadowLayer): (WebCore::ContextShadow::endShadowLayer): (WebCore::ContextShadow::drawRectShadowWithoutTiling):
  • platform/graphics/cairo/FontCairo.cpp: (WebCore::drawGlyphsShadow):
  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::drawPathShadow):
  • platform/graphics/cairo/ImageCairo.cpp: (WebCore::BitmapImage::draw):
  • platform/graphics/gtk/FontGtk.cpp: (WebCore::drawGlyphsShadow):
  • platform/graphics/qt/ContextShadowQt.cpp: (WebCore::ContextShadow::beginShadowLayer): (WebCore::ContextShadow::endShadowLayer):
  • platform/graphics/qt/FontQt.cpp: (WebCore::drawTextCommon):
  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::fillRoundedRect):
  • platform/graphics/qt/ImageQt.cpp: (WebCore::BitmapImage::draw):
  • platform/graphics/qt/StillImageQt.cpp: (WebCore::StillImage::draw):
16:09 Changeset [74946] by darin@apple.com

2011-01-03 Darin Adler <darin@apple.com>

Reviewed by Dan Bernstein.

InsertTextCommand::m_charactersAdded is unused
https://bugs.webkit.org/show_bug.cgi?id=51849

  • editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::InsertTextCommand): Don't initialize m_charactersAdded. (WebCore::InsertTextCommand::input): Don't update m_charactersAdded.
  • editing/InsertTextCommand.h: Removed charactersAdded function and m_charactersAdded data member.
15:56 Changeset [74945] by commit-queue@webkit.org

2011-01-03 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Move paintMenuListButton() to RenderThemeGtk.cpp
https://bugs.webkit.org/show_bug.cgi?id=51832

Method paintMenuListButton() contains code common to both gtk 2
and 3, so it can be moved to RenderThemeGtk.cpp instead of
duplicating it.

  • platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::paintMenuListButton):
  • platform/gtk/RenderThemeGtk2.cpp:
  • platform/gtk/RenderThemeGtk3.cpp:
15:52 WebKit Team edited by psolanki@apple.com
Adding myself to the committers list. (diff)
15:52 Changeset [74944] by xan@webkit.org

2011-01-03 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

  • autogen.sh: also pass $ACLOCAL_FLAGS for tools that set that env variable (like jhbuild).
15:45 Changeset [74943] by psolanki@apple.com

2011-01-03 Pratik Solanki <psolanki@apple.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=51850
Put CFNetwork loader code inside USE(CFNETWORK)

Add USE(CFNETWORK) macros around all the cf/mac network files. Also added all CFNetwork
files to the WebCore Xcode project.

  • WebCore.xcodeproj/project.pbxproj:
  • loader/cf/ResourceLoaderCFNet.cpp:
  • loader/mac/ResourceLoaderMac.mm:
  • platform/network/cf/AuthenticationCF.cpp:
  • platform/network/cf/AuthenticationCF.h:
  • platform/network/cf/CookieJarCFNet.cpp:
  • platform/network/cf/CookieStorageCFNet.cpp:
  • platform/network/cf/CookieStorageCFNet.h:
  • platform/network/cf/CredentialStorageCFNet.cpp:
  • platform/network/cf/FormDataStreamCFNet.cpp:
  • platform/network/cf/FormDataStreamCFNet.h:
  • platform/network/cf/LoaderRunLoopCF.cpp:
  • platform/network/cf/LoaderRunLoopCF.h:
  • platform/network/cf/ResourceError.h:
  • platform/network/cf/ResourceHandleCFNet.cpp:
  • platform/network/cf/ResourceRequest.h:
  • platform/network/cf/ResourceRequestCFNet.cpp:
  • platform/network/cf/ResourceRequestCFNet.h:
  • platform/network/cf/ResourceResponse.h:
  • platform/network/cf/ResourceResponseCFNet.cpp:
  • platform/network/mac/AuthenticationMac.h:
  • platform/network/mac/AuthenticationMac.mm:
  • platform/network/mac/FormDataStreamMac.h:
  • platform/network/mac/FormDataStreamMac.mm:
  • platform/network/mac/ResourceError.h:
  • platform/network/mac/ResourceHandleMac.mm:
  • platform/network/mac/ResourceRequest.h:
  • platform/network/mac/ResourceRequestMac.mm:
  • platform/network/mac/ResourceResponse.h:
  • platform/network/mac/ResourceResponseMac.mm:
15:43 Changeset [74942] by xan@webkit.org

2011-01-03 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

Use autoreconf instead of calling manually all the usual commands.

  • autogen.sh: call autoreconf instead of aclocal/autoheader/autoconf/automake/libtoolize.
15:42 Changeset [74941] by commit-queue@webkit.org

2011-01-03 Yi Shen <yi.4.shen@nokia.com>

Reviewed by Adam Barth.

[Qt] Add SelectAll option to the context menu for the editor
https://bugs.webkit.org/show_bug.cgi?id=50049

Set shortcut for the SelectAll action.

  • QtTestBrowser/mainwindow.cpp: (MainWindow::buildUI):

2011-01-03 Yi Shen <yi.4.shen@nokia.com>

Reviewed by Adam Barth.

[Qt] Add SelectAll option to the context menu for the editor
https://bugs.webkit.org/show_bug.cgi?id=50049

Enable SelectAll for the Qt context menu.

  • page/ContextMenuController.cpp: (WebCore::ContextMenuController::populate):
  • platform/ContextMenuItem.h:
  • platform/LocalizationStrategy.h:
  • platform/LocalizedStrings.cpp: (WebCore::contextMenuItemTagSelectAll):
  • platform/LocalizedStrings.h:

2011-01-03 Yi Shen <yi.4.shen@nokia.com>

Reviewed by Adam Barth.

[Qt] Add SelectAll option to the context menu for the editor
https://bugs.webkit.org/show_bug.cgi?id=50049

Enable SelectAll for the Qt context menu.

  • Api/qwebpage.cpp: (webActionForContextMenuAction): (QWebPage::action):
  • WebCoreSupport/WebPlatformStrategies.cpp: (WebPlatformStrategies::contextMenuItemTagSelectAll):
  • WebCoreSupport/WebPlatformStrategies.h:

2011-01-03 Yi Shen <yi.4.shen@nokia.com>

Reviewed by Adam Barth.

[Qt] Add SelectAll option to the context menu for the editor
https://bugs.webkit.org/show_bug.cgi?id=50049

Add WebPlatformStrategies::contextMenuItemTagSelectAll for Qt.

  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp: (WebKit::WebPlatformStrategies::contextMenuItemTagSelectAll):
  • WebProcess/WebCoreSupport/WebPlatformStrategies.h:
14:25 Changeset [74940] by weinig@apple.com

Reviewed, tweaked and landed by Sam Weinig.

Patch by Chris Fleizach <cfleizach@apple.com> on 2011-01-03
WebKit2: Accessibility support (42130)
<rdar://problem/7660629>

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
13:53 Changeset [74939] by mihaip@chromium.org

2011-01-03 Mihai Parparita <mihaip@chromium.org>

Unreviewed, Chromium test expectation update.

Group tests that fail on Leopard but pass on Snow Leopard (due to
stale platform/mac baselines).

  • platform/chromium/test_expectations.txt:
13:42 Changeset [74938] by paroga@webkit.org

2011-01-03 Patrick Gansterer <paroga@webkit.org>

Reviewed by Darin Adler.

[WINCE] Provide third party directory via environment variable
https://bugs.webkit.org/show_bug.cgi?id=51643

  • Source/cmake/OptionsWinCE.cmake:
13:40 Changeset [74937] by mitz@apple.com

Shrink RootInlineBox
https://bugs.webkit.org/show_bug.cgi?id=51847

Reviewed by Darin Adler.

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::alignBoxesInBlockDirection): Changed to use the baselineType()
accessor.

  • rendering/RootInlineBox.h: Rolled m_baselineType into a bitfield. Changed its type to

unsigned because otherwise MSVC treats it as signed.
(WebCore::RootInlineBox::baselineType): Added a cast.

13:38 Changeset [74936] by darin@apple.com
  • wtf/Forward.h: Added Decoder and Encoder.

Reviewed by Brady Eidson.

13:36 Changeset [74935] by kov@webkit.org

Adding files I missed in my last git add. *shame*

13:21 Changeset [74934] by levin@chromium.org

2011-01-03 David Levin <levin@chromium.org>

Reviewed by Eric Seidel.

check-webkit-style shouldn't consider "value" automatically to be a meaningless name.
https://bugs.webkit.org/show_bug.cgi?id=51842

  • Scripts/webkitpy/style/checkers/cpp.py: Remove the check for value.
  • Scripts/webkitpy/style/checkers/cpp_unittest.py: Remove the test for value.
13:20 Changeset [74933] by kov@webkit.org

WebKit/gtk

2011-01-03 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Martin Robinson.

[GTK] Split webkitprivate.{cpp,h} in more manageable chunks
https://bugs.webkit.org/show_bug.cgi?id=50698

Final patch, removing webkitprivate.{cpp,h}, and adding a
webkitglobals module to hold non-object-specific functions and
definitions that do not make sense on their own.

  • GNUmakefile.am:
  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::createWindow):
  • WebCoreSupport/ContextMenuClientGtk.cpp:
  • WebCoreSupport/DocumentLoaderGtk.cpp: (WebKit::DocumentLoader::attachToFrame):
  • WebCoreSupport/DragClientGtk.cpp:
  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
  • WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::ignoreWordInSpellDocument): (WebKit::EditorClient::learnWord): (WebKit::EditorClient::checkSpellingOfString): (WebKit::EditorClient::getGuessesForWord):
  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::createDocumentLoader):
  • WebCoreSupport/InspectorClientGtk.cpp:
  • webkit/webkit.h:
  • webkit/webkitapplicationcache.cpp: (webkit_application_cache_set_maximum_size):
  • webkit/webkitdownload.cpp: (webkit_download_class_init):
  • webkit/webkitgeolocationpolicydecision.cpp:
  • webkit/webkitglobals.cpp: Added. (webkit_get_default_session): (webkit_set_cache_model): (webkit_get_cache_model): (webkit_get_web_plugin_database): (currentToplevelCallback): (closeIconDatabaseOnExit): (webkitInit): (WebKit::pasteboardHelperInstance):
  • webkit/webkitglobals.h: Added.
  • webkit/webkitglobalsprivate.h: Copied from WebKit/gtk/webkit/webkitwebsettingsprivate.h.
  • webkit/webkithittestresult.cpp: (webkit_hit_test_result_class_init):
  • webkit/webkitnetworkrequest.cpp: (webkit_network_request_class_init):
  • webkit/webkitnetworkresponse.cpp: (webkit_network_response_class_init):
  • webkit/webkitprivate.cpp: Removed.
  • webkit/webkitprivate.h: Removed.
  • webkit/webkitsecurityorigin.cpp:
  • webkit/webkitviewportattributes.cpp:
  • webkit/webkitwebbackforwardlist.cpp: (webkit_web_back_forward_list_class_init):
  • webkit/webkitwebdatabase.cpp:
  • webkit/webkitwebdatasource.cpp: (webkit_web_data_source_class_init): (webkit_web_data_source_new_with_request): (WebKit::kitNew):
  • webkit/webkitwebframe.cpp: (webkit_web_frame_class_init):
  • webkit/webkitwebframeprivate.h:
  • webkit/webkitwebhistoryitem.cpp: (webkit_web_history_item_class_init):
  • webkit/webkitwebinspector.cpp:
  • webkit/webkitwebnavigationaction.cpp:
  • webkit/webkitwebplugin.cpp: (webkit_web_plugin_class_init):
  • webkit/webkitwebplugindatabase.cpp: (webkit_web_plugin_database_class_init):
  • webkit/webkitwebpluginprivate.h:
  • webkit/webkitwebpolicydecision.cpp:
  • webkit/webkitwebresource.cpp:
  • webkit/webkitwebsettings.cpp: (webkit_web_settings_class_init): (webkitWebViewGetEnchantDicts): (WebKit::core):
  • webkit/webkitwebsettingsprivate.h:
  • webkit/webkitwebview.cpp: (webkit_web_view_class_init): (webkit_web_view_update_settings): (webkit_web_view_settings_notify):
  • webkit/webkitwebview.h:
  • webkit/webkitwebwindowfeatures.cpp: (webkit_web_window_features_class_init): (WebKit::kitNew):

WebCore

2011-01-03 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Martin Robinson.

[GTK] Split webkitprivate.{cpp,h} in more manageable chunks
https://bugs.webkit.org/show_bug.cgi?id=50698

Fix DOM bindings generation to no longer include the now-gone
webkitprivate.h header, including the appropriate replacements
instead.

  • bindings/scripts/CodeGeneratorGObject.pm:
13:16 Changeset [74932] by commit-queue@webkit.org

2011-01-03 Antonio Gomes <agomes@rim.com>

Unreviewed crash fix.

Follow up of r74891: potential crash fix (bogus assertion).

  • WebCoreSupport/EditorClientQt.cpp: (WebCore::editorCommandForKeyDownEvent):
13:13 Changeset [74931] by mihaip@chromium.org

2011-01-03 Mihai Parparita <mihaip@chromium.org>

Unreviewed, Chromium test expectation update.

Missed a few failing tests.

  • platform/chromium/test_expectations.txt:
13:10 Changeset [74930] by paroga@webkit.org

2011-01-03 Patrick Gansterer <paroga@webkit.org>

Reviewed by David Kilzer.

[WINCE] Adds a build slave.
https://bugs.webkit.org/show_bug.cgi?id=50523

  • BuildSlaveSupport/build.webkit.org-config/config.json: Add an entry for a release build of the WinCE port.
  • BuildSlaveSupport/build.webkit.org-config/master.cfg: Add platform flag to build the WinCE port.
13:04 Changeset [74929] by mihaip@chromium.org

2011-01-03 Mihai Parparita <mihaip@chromium.org>

Unreviewed, Chromium test expectation update.

Remove fast/, printing/, svg/, tables/ and transforms/ chromium-mac
baselines that are no longer necessary after r74892 (now that
chromium-mac scrollbars match mac ones).

  • platform/chromium-mac-leopard/fast/text/international/bidi-neutral-run-expected.checksum: Removed.
  • platform/chromium-mac-leopard/fast/text/international/bidi-neutral-run-expected.png: Removed.
  • platform/chromium-mac/fast/css/text-overflow-ellipsis-strict-expected.checksum: Removed.
  • platform/chromium-mac/fast/css/text-overflow-ellipsis-strict-expected.png: Removed.
  • platform/chromium-mac/fast/events/autoscroll-expected.checksum: Removed.
  • platform/chromium-mac/fast/events/autoscroll-expected.png: Removed.
  • platform/chromium-mac/fast/events/reveal-link-when-focused-expected.checksum: Removed.
  • platform/chromium-mac/fast/events/reveal-link-when-focused-expected.png: Removed.
  • platform/chromium-mac/fast/events/standalone-image-drag-to-editable-expected.checksum: Removed.
  • platform/chromium-mac/fast/events/standalone-image-drag-to-editable-expected.png: Removed.
  • platform/chromium-mac/fast/forms/basic-textareas-expected.checksum: Removed.
  • platform/chromium-mac/fast/forms/basic-textareas-expected.png: Removed.
  • platform/chromium-mac/fast/forms/basic-textareas-quirks-expected.checksum: Removed.
  • platform/chromium-mac/fast/forms/basic-textareas-quirks-expected.png: Removed.
  • platform/chromium-mac/fast/forms/button-default-title-expected.checksum: Removed.
  • platform/chromium-mac/fast/forms/button-default-title-expected.png: Removed.
  • platform/chromium-mac/fast/frames/frame-scrolling-attribute-expected.checksum: Removed.
  • platform/chromium-mac/fast/frames/frame-scrolling-attribute-expected.png: Removed.
  • platform/chromium-mac/fast/frames/iframe-scrolling-attribute-expected.checksum: Removed.
  • platform/chromium-mac/fast/frames/iframe-scrolling-attribute-expected.png: Removed.
  • platform/chromium-mac/fast/invalid/residual-style-expected.checksum: Removed.
  • platform/chromium-mac/fast/invalid/residual-style-expected.png: Removed.
  • platform/chromium-mac/fast/lists/001-vertical-expected.checksum: Removed.
  • platform/chromium-mac/fast/lists/001-vertical-expected.png: Removed.
  • platform/chromium-mac/fast/lists/008-vertical-expected.checksum: Removed.
  • platform/chromium-mac/fast/lists/008-vertical-expected.png: Removed.
  • platform/chromium-mac/fast/media/mq-relative-constraints-02-expected.checksum: Removed.
  • platform/chromium-mac/fast/media/mq-relative-constraints-02-expected.png: Removed.
  • platform/chromium-mac/fast/media/mq-relative-constraints-03-expected.checksum: Removed.
  • platform/chromium-mac/fast/media/mq-relative-constraints-03-expected.png: Removed.
  • platform/chromium-mac/fast/media/mq-relative-constraints-04-expected.checksum: Removed.
  • platform/chromium-mac/fast/media/mq-relative-constraints-04-expected.png: Removed.
  • platform/chromium-mac/fast/media/mq-relative-constraints-05-expected.checksum: Removed.
  • platform/chromium-mac/fast/media/mq-relative-constraints-05-expected.png: Removed.
  • platform/chromium-mac/fast/media/mq-relative-constraints-06-expected.checksum: Removed.
  • platform/chromium-mac/fast/media/mq-relative-constraints-06-expected.png: Removed.
  • platform/chromium-mac/fast/media/mq-relative-constraints-07-expected.checksum: Removed.
  • platform/chromium-mac/fast/media/mq-relative-constraints-07-expected.png: Removed.
  • platform/chromium-mac/fast/media/mq-relative-constraints-08-expected.checksum: Removed.
  • platform/chromium-mac/fast/media/mq-relative-constraints-08-expected.png: Removed.
  • platform/chromium-mac/fast/media/mq-relative-constraints-09-expected.checksum: Removed.
  • platform/chromium-mac/fast/media/mq-relative-constraints-09-expected.png: Removed.
  • platform/chromium-mac/fast/media/mq-width-absolute-01-expected.checksum: Removed.
  • platform/chromium-mac/fast/media/mq-width-absolute-01-expected.png: Removed.
  • platform/chromium-mac/fast/media/mq-width-absolute-02-expected.checksum: Removed.
  • platform/chromium-mac/fast/media/mq-width-absolute-02-expected.png: Removed.
  • platform/chromium-mac/fast/media/mq-width-absolute-03-expected.checksum: Removed.
  • platform/chromium-mac/fast/media/mq-width-absolute-03-expected.png: Removed.
  • platform/chromium-mac/fast/media/mq-width-absolute-04-expected.checksum: Removed.
  • platform/chromium-mac/fast/media/mq-width-absolute-04-expected.png: Removed.
  • platform/chromium-mac/fast/multicol/client-rects-expected.checksum: Removed.
  • platform/chromium-mac/fast/multicol/column-break-with-balancing-expected.checksum: Removed.
  • platform/chromium-mac/fast/multicol/column-break-with-balancing-expected.png: Removed.
  • platform/chromium-mac/fast/multicol/float-multicol-expected.checksum: Removed.
  • platform/chromium-mac/fast/multicol/float-multicol-expected.png: Removed.
  • platform/chromium-mac/fast/multicol/float-paginate-complex-expected.checksum: Removed.
  • platform/chromium-mac/fast/multicol/float-paginate-complex-expected.png: Removed.
  • platform/chromium-mac/fast/multicol/float-paginate-expected.checksum: Removed.
  • platform/chromium-mac/fast/multicol/float-paginate-expected.png: Removed.
  • platform/chromium-mac/fast/multicol/layers-in-multicol-expected.checksum: Removed.
  • platform/chromium-mac/fast/multicol/layers-in-multicol-expected.png: Removed.
  • platform/chromium-mac/fast/multicol/layers-split-across-columns-expected.checksum: Removed.
  • platform/chromium-mac/fast/multicol/paginate-block-replaced-expected.checksum: Removed.
  • platform/chromium-mac/fast/multicol/span/anonymous-style-inheritance-expected.checksum: Removed.
  • platform/chromium-mac/fast/multicol/span/anonymous-style-inheritance-expected.png: Removed.
  • platform/chromium-mac/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.checksum: Removed.
  • platform/chromium-mac/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.png: Removed.
  • platform/chromium-mac/fast/multicol/span/span-as-immediate-child-generated-content-expected.checksum: Removed.
  • platform/chromium-mac/fast/multicol/span/span-as-immediate-child-generated-content-expected.png: Removed.
  • platform/chromium-mac/fast/multicol/span/span-as-immediate-child-property-removal-expected.checksum: Removed.
  • platform/chromium-mac/fast/multicol/span/span-as-immediate-child-property-removal-expected.png: Removed.
  • platform/chromium-mac/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.checksum: Removed.
  • platform/chromium-mac/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.png: Removed.
  • platform/chromium-mac/fast/multicol/span/span-as-immediate-columns-child-expected.checksum: Removed.
  • platform/chromium-mac/fast/multicol/span/span-as-immediate-columns-child-removal-expected.checksum: Removed.
  • platform/chromium-mac/fast/multicol/span/span-as-immediate-columns-child-removal-expected.png: Removed.
  • platform/chromium-mac/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.checksum: Removed.
  • platform/chromium-mac/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png: Removed.
  • platform/chromium-mac/fast/multicol/span/span-as-nested-columns-child-expected.checksum: Removed.
  • platform/chromium-mac/fast/multicol/span/span-as-nested-columns-child-expected.png: Removed.
  • platform/chromium-mac/fast/multicol/span/span-margin-collapsing-expected.checksum: Removed.
  • platform/chromium-mac/fast/multicol/span/span-margin-collapsing-expected.png: Removed.
  • platform/chromium-mac/fast/multicol/table-vertical-align-expected.checksum: Removed.
  • platform/chromium-mac/fast/multicol/table-vertical-align-expected.png: Removed.
  • platform/chromium-mac/fast/repaint/overflow-scroll-body-appear-expected.checksum: Removed.
  • platform/chromium-mac/fast/repaint/overflow-scroll-body-appear-expected.png: Removed.
  • platform/chromium-mac/fast/table/027-vertical-expected.checksum: Removed.
  • platform/chromium-mac/fast/table/027-vertical-expected.png: Removed.
  • platform/chromium-mac/fast/table/028-vertical-expected.checksum: Removed.
  • platform/chromium-mac/fast/table/028-vertical-expected.png: Removed.
  • platform/chromium-mac/fast/table/038-vertical-expected.checksum: Removed.
  • platform/chromium-mac/fast/table/038-vertical-expected.png: Removed.
  • platform/chromium-mac/fast/table/040-vertical-expected.checksum: Removed.
  • platform/chromium-mac/fast/table/040-vertical-expected.png: Removed.
  • platform/chromium-mac/fast/table/border-collapsing/002-vertical-expected.checksum: Removed.
  • platform/chromium-mac/fast/table/border-collapsing/002-vertical-expected.png: Removed.
  • platform/chromium-mac/fast/table/border-collapsing/equal-precedence-resolution-vertical-expected.checksum: Removed.
  • platform/chromium-mac/fast/table/border-collapsing/equal-precedence-resolution-vertical-expected.png: Removed.
  • platform/chromium-mac/fast/table/table-display-types-vertical-expected.checksum: Removed.
  • platform/chromium-mac/fast/table/table-display-types-vertical-expected.png: Removed.
  • platform/chromium-mac/fast/text/backslash-to-yen-sign-euc-expected.checksum: Removed.
  • platform/chromium-mac/fast/text/backslash-to-yen-sign-euc-expected.png: Removed.
  • platform/chromium-mac/fast/text/text-letter-spacing-expected.checksum: Removed.
  • platform/chromium-mac/fast/text/text-letter-spacing-expected.png: Removed.
  • platform/chromium-mac/fast/transforms/rotated-transform-affects-scrolling-1-expected.checksum: Removed.
  • platform/chromium-mac/fast/transforms/rotated-transform-affects-scrolling-1-expected.png: Removed.
  • platform/chromium-mac/fast/transforms/rotated-transform-affects-scrolling-2-expected.checksum: Removed.
  • platform/chromium-mac/fast/transforms/rotated-transform-affects-scrolling-2-expected.png: Removed.
  • platform/chromium-mac/printing/return-from-printing-mode-expected.checksum: Removed.
  • platform/chromium-mac/printing/return-from-printing-mode-expected.png: Removed.
  • platform/chromium-mac/svg/custom/altglyph-expected.checksum: Removed.
  • platform/chromium-mac/svg/custom/altglyph-expected.png: Removed.
  • platform/chromium-mac/svg/custom/getscreenctm-in-scrollable-svg-area-expected.checksum: Removed.
  • platform/chromium-mac/svg/custom/getscreenctm-in-scrollable-svg-area-expected.png: Removed.
  • platform/chromium-mac/svg/custom/junk-data-expected.checksum: Removed.
  • platform/chromium-mac/svg/custom/junk-data-expected.png: Removed.
  • platform/chromium-mac/svg/custom/missing-xlink-expected.checksum: Removed.
  • platform/chromium-mac/svg/custom/missing-xlink-expected.png: Removed.
  • platform/chromium-mac/svg/custom/text-xy-updates-SVGList-expected.checksum: Removed.
  • platform/chromium-mac/svg/custom/text-xy-updates-SVGList-expected.png: Removed.
  • platform/chromium-mac/svg/dom/SVGLengthList-appendItem-expected.checksum: Removed.
  • platform/chromium-mac/svg/dom/SVGLengthList-appendItem-expected.png: Removed.
  • platform/chromium-mac/svg/dom/SVGLengthList-initialize-expected.checksum: Removed.
  • platform/chromium-mac/svg/dom/SVGLengthList-initialize-expected.png: Removed.
  • platform/chromium-mac/svg/dom/SVGLengthList-insertItemBefore-expected.checksum: Removed.
  • platform/chromium-mac/svg/dom/SVGLengthList-insertItemBefore-expected.png: Removed.
  • platform/chromium-mac/svg/dom/SVGLengthList-removeItem-expected.checksum: Removed.
  • platform/chromium-mac/svg/dom/SVGLengthList-removeItem-expected.png: Removed.
  • platform/chromium-mac/svg/dom/SVGLengthList-replaceItem-expected.checksum: Removed.
  • platform/chromium-mac/svg/dom/SVGLengthList-replaceItem-expected.png: Removed.
  • platform/chromium-mac/svg/dom/SVGLengthList-xml-dom-modifications-expected.checksum: Removed.
  • platform/chromium-mac/svg/dom/SVGLengthList-xml-dom-modifications-expected.png: Removed.
  • platform/chromium-mac/svg/dom/SVGNumberList-basics-expected.checksum: Removed.
  • platform/chromium-mac/svg/dom/SVGNumberList-basics-expected.png: Removed.
  • platform/chromium-mac/svg/dom/SVGPathSegList-appendItem-expected.checksum: Removed.
  • platform/chromium-mac/svg/dom/SVGPathSegList-appendItem-expected.png: Removed.
  • platform/chromium-mac/svg/dom/SVGPathSegList-clear-and-initialize-expected.checksum: Removed.
  • platform/chromium-mac/svg/dom/SVGPathSegList-clear-and-initialize-expected.png: Removed.
  • platform/chromium-mac/svg/dom/SVGPathSegList-insertItemBefore-expected.checksum: Removed.
  • platform/chromium-mac/svg/dom/SVGPathSegList-insertItemBefore-expected.png: Removed.
  • platform/chromium-mac/svg/dom/SVGPathSegList-removeItem-expected.checksum: Removed.
  • platform/chromium-mac/svg/dom/SVGPathSegList-removeItem-expected.png: Removed.
  • platform/chromium-mac/svg/dom/SVGPathSegList-replaceItem-expected.checksum: Removed.
  • platform/chromium-mac/svg/dom/SVGPathSegList-replaceItem-expected.png: Removed.
  • platform/chromium-mac/svg/dom/SVGPointList-basics-expected.checksum: Removed.
  • platform/chromium-mac/svg/dom/SVGPointList-basics-expected.png: Removed.
  • platform/chromium-mac/svg/dom/SVGStringList-basics-expected.checksum: Removed.
  • platform/chromium-mac/svg/dom/SVGStringList-basics-expected.png: Removed.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.checksum: Removed.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.png: Removed.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.checksum: Removed.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.png: Removed.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.checksum: Removed.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.png: Removed.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.checksum: Removed.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.png: Removed.
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.checksum: Removed.
  • platform/chromium-mac/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.png: Removed.
  • platform/chromium-mac/svg/dynamic-updates/SVGLineElement-svgdom-requiredFeatures-expected.checksum: Removed.
  • platform/chromium-mac/svg/dynamic-updates/SVGLineElement-svgdom-requiredFeatures-expected.png: Removed.
  • platform/chromium-mac/svg/dynamic-updates/SVGPatternElement-svgdom-patternTransform-prop-expected.checksum: Removed.
  • platform/chromium-mac/svg/dynamic-updates/SVGUseElement-dom-requiredFeatures-expected.checksum: Removed.
  • platform/chromium-mac/svg/dynamic-updates/SVGUseElement-dom-requiredFeatures-expected.png: Removed.
  • platform/chromium-mac/svg/in-html/circle-expected.checksum: Removed.
  • platform/chromium-mac/svg/in-html/circle-expected.png: Removed.
  • platform/chromium-mac/svg/text/kerning-expected.checksum: Removed.
  • platform/chromium-mac/svg/zoom/page/absolute-sized-document-scrollbars-expected.checksum: Removed.
  • platform/chromium-mac/svg/zoom/page/absolute-sized-document-scrollbars-expected.png: Removed.
  • platform/chromium-mac/svg/zoom/page/relative-sized-document-scrollbars-expected.checksum: Removed.
  • platform/chromium-mac/svg/zoom/page/relative-sized-document-scrollbars-expected.png: Removed.
  • platform/chromium-mac/svg/zoom/page/zoom-svg-float-border-padding-expected.checksum: Removed.
  • platform/chromium-mac/svg/zoom/page/zoom-svg-float-border-padding-expected.png: Removed.
  • platform/chromium-mac/svg/zoom/text/zoom-svg-float-border-padding-expected.checksum: Removed.
  • platform/chromium-mac/svg/zoom/text/zoom-svg-float-border-padding-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug96334-expected.checksum: Removed.
  • platform/chromium-mac/tables/mozilla/bugs/bug96343-expected.checksum: Removed.
  • platform/chromium-mac/tables/mozilla/collapsing_borders/bug41262-3-expected.checksum: Removed.
  • platform/chromium-mac/tables/mozilla/collapsing_borders/bug41262-3-expected.png: Removed.
  • platform/chromium-mac/tables/mozilla/other/wa_table_thtd_rowspan-expected.checksum: Removed.
  • platform/chromium-mac/tables/mozilla/other/wa_table_thtd_rowspan-expected.png: Removed.
  • platform/chromium-mac/transforms/2d/transform-fixed-container-expected.checksum: Removed.
  • platform/chromium-mac/transforms/2d/transform-fixed-container-expected.png: Removed.
  • platform/chromium/test_expectations.txt:
13:04 Changeset [74928] by paroga@webkit.org

2011-01-03 Patrick Gansterer <paroga@webkit.org>

Reviewed by David Kilzer.

Add WinCE support to build-webkit
https://bugs.webkit.org/show_bug.cgi?id=51642

  • Scripts/build-webkit:
  • Scripts/webkitdirs.pm:
12:59 Changeset [74927] by eric@webkit.org

2011-01-03 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
https://bugs.webkit.org/show_bug.cgi?id=51802

I'm not the biggest fan of the test_failures or test_results classes,
but it's better to have one shared set of classes, than separate ones
for new vs. old run-webkit-test result handling.

This moves the ORWT results class "LayoutTestResults" over to using
TestResult and TestFailure classes, making it easy for us to
make all our sheriff-bot and other webkitpy code NRWT ready.

This also makes it a trivial patch to generate results.json information
from ORWT results.html files (for flaky test analysis, etc.) as well
as making it a one-liner to report test failure types when the
commit-queue sees flaky tests.

This patch tried not to add new functionality, but only to replace
the guts of LayoutTestResults, while adding unit tests and hoping
not to break anything.

I also moved callers which assumed User.prompt* were static/class methods
to using them as instance methods (since we'll eventually want to make them such).

In the process of re-writing things, I broke the rebaseline command, so I wrote
a unit test to catch my breakage were I do do so again in the future.

  • Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
  • Scripts/webkitpy/common/net/layouttestresults.py:
  • Scripts/webkitpy/common/net/layouttestresults_unittest.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_results.py:
  • Scripts/webkitpy/tool/commands/queries.py:
  • Scripts/webkitpy/tool/commands/rebaseline.py:
  • Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
  • Scripts/webkitpy/tool/mocktool.py:
12:57 Changeset [74926] by beidson@apple.com

Add Encode/Decode machinery Darin and I plan to work with for back/forward stuff in WebKit2.

Reviewed by Darin Adler.

Source/JavaScriptCore:

Starting out with a pure virtual interface to be implemented in WK2, but we might change that later.

  • wtf/Decoder.h: Added.
  • wtf/Encoder.h: Added.

WebCore:

  • ForwardingHeaders/wtf/Decoder.h: Added.
  • ForwardingHeaders/wtf/Encoder.h: Added.
12:40 Changeset [74925] by abarth@webkit.org

2011-01-03 Adam Barth <abarth@webkit.org>

Reviewed by Simon Fraser.

webkit-patch shouldn't waste time cleaning a working directory that's already clean
https://bugs.webkit.org/show_bug.cgi?id=51840

  • Scripts/webkitpy/common/checkout/scm.py:
12:36 Changeset [74924] by mihaip@chromium.org

2011-01-03 Mihai Parparita <mihaip@chromium.org>

Unreviewed, Chromium test expectation update.

New gradient tests fail on chromium-mac too.

  • platform/chromium/test_expectations.txt:
12:26 Changeset [74923] by mihaip@chromium.org

2011-01-03 Mihai Parparita <mihaip@chromium.org>

Unreviewed, Chromium test expectation update.

Remove editing/, fast/backgrounds, fast/block, fast/blockflow, and
fast/borders chromium-mac baselines that are no longer necessary after
r74892 (now that chromium-mac scrollbars match mac ones).

  • platform/chromium-mac/editing/deleting/delete-after-span-ws-001-expected.checksum: Removed.
  • platform/chromium-mac/editing/deleting/delete-after-span-ws-001-expected.png: Removed.
  • platform/chromium-mac/editing/deleting/delete-after-span-ws-002-expected.checksum: Removed.
  • platform/chromium-mac/editing/deleting/delete-after-span-ws-002-expected.png: Removed.
  • platform/chromium-mac/editing/deleting/delete-after-span-ws-003-expected.checksum: Removed.
  • platform/chromium-mac/editing/deleting/delete-after-span-ws-003-expected.png: Removed.
  • platform/chromium-mac/editing/deleting/delete-line-end-ws-001-expected.checksum: Removed.
  • platform/chromium-mac/editing/deleting/delete-line-end-ws-001-expected.png: Removed.
  • platform/chromium-mac/editing/deleting/delete-line-end-ws-002-expected.checksum: Removed.
  • platform/chromium-mac/editing/deleting/delete-line-end-ws-002-expected.png: Removed.
  • platform/chromium-mac/editing/inserting/insert-div-023-expected.checksum: Removed.
  • platform/chromium-mac/editing/inserting/insert-div-023-expected.png: Removed.
  • platform/chromium-mac/editing/selection/focus_editable_html-expected.checksum: Removed.
  • platform/chromium-mac/editing/selection/focus_editable_html-expected.png: Removed.
  • platform/chromium-mac/editing/selection/iframe-expected.checksum: Removed.
  • platform/chromium-mac/editing/selection/iframe-expected.png: Removed.
  • platform/chromium-mac/editing/selection/select-all-001-expected.checksum: Removed.
  • platform/chromium-mac/editing/selection/select-all-001-expected.png: Removed.
  • platform/chromium-mac/editing/selection/select-all-002-expected.checksum: Removed.
  • platform/chromium-mac/editing/selection/select-all-002-expected.png: Removed.
  • platform/chromium-mac/editing/selection/select-all-003-expected.checksum: Removed.
  • platform/chromium-mac/editing/selection/select-all-003-expected.png: Removed.
  • platform/chromium-mac/editing/selection/select-all-004-expected.checksum: Removed.
  • platform/chromium-mac/editing/selection/select-all-004-expected.png: Removed.
  • platform/chromium-mac/editing/selection/unrendered-001-expected.checksum: Removed.
  • platform/chromium-mac/editing/selection/unrendered-001-expected.png: Removed.
  • platform/chromium-mac/editing/selection/unrendered-002-expected.checksum: Removed.
  • platform/chromium-mac/editing/selection/unrendered-002-expected.png: Removed.
  • platform/chromium-mac/editing/selection/unrendered-003-expected.checksum: Removed.
  • platform/chromium-mac/editing/selection/unrendered-003-expected.png: Removed.
  • platform/chromium-mac/editing/selection/unrendered-004-expected.checksum: Removed.
  • platform/chromium-mac/editing/selection/unrendered-004-expected.png: Removed.
  • platform/chromium-mac/editing/selection/unrendered-005-expected.checksum: Removed.
  • platform/chromium-mac/editing/selection/unrendered-005-expected.png: Removed.
  • platform/chromium-mac/fast/backgrounds/background-inherit-color-bug-expected.checksum: Removed.
  • platform/chromium-mac/fast/backgrounds/background-inherit-color-bug-expected.png: Removed.
  • platform/chromium-mac/fast/block/basic/016-expected.checksum: Removed.
  • platform/chromium-mac/fast/block/basic/truncation-rtl-expected.checksum: Removed.
  • platform/chromium-mac/fast/block/basic/truncation-rtl-expected.png: Removed.
  • platform/chromium-mac/fast/blockflow/border-radius-clipping-vertical-lr-expected.checksum: Removed.
  • platform/chromium-mac/fast/blockflow/border-radius-clipping-vertical-lr-expected.png: Removed.
  • platform/chromium-mac/fast/blockflow/box-shadow-vertical-lr-expected.checksum: Removed.
  • platform/chromium-mac/fast/blockflow/box-shadow-vertical-lr-expected.png: Removed.
  • platform/chromium-mac/fast/blockflow/box-shadow-vertical-rl-expected.checksum: Removed.
  • platform/chromium-mac/fast/blockflow/fieldsets-expected.checksum: Removed.
  • platform/chromium-mac/fast/blockflow/fieldsets-expected.png: Removed.
  • platform/chromium-mac/fast/borders/border-image-scale-transform-expected.checksum: Removed.
  • platform/chromium-mac/fast/borders/border-image-scale-transform-expected.png: Removed.
  • platform/chromium/test_expectations.txt:
12:08 Changeset [74922] by laszlo.1.gombos@nokia.com

2011-01-03 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Unreviewed build fix.

[Qt] Add NullPtr.cpp introduced in r71155 to the Qt build system.

This fix is required for builds where HAVE(NULLPTR) is false
(e.g. some MSVC and Symbian builds).

  • wtf/wtf.pri:
12:02 Changeset [74921] by mihaip@chromium.org

2011-01-03 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium test expectation update.

Add failing expectations for tests that depend on elliptical gradient
support.

  • platform/chromium/test_expectations.txt:
12:01 Changeset [74920] by cfleizach@apple.com

AX: Regression: WebKit no longer auto-scrolls with VoiceOver navigation
https://bugs.webkit.org/show_bug.cgi?id=51833

Reviewed by Darin Adler.

WebCore:

Make sure the web area returns the contentsSize, not the same size as what is displayed.

Test: platform/mac/accessibility/webarea-size-equals-content-size.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::boundingBoxRect):

LayoutTests:

  • platform/mac/accessibility/webarea-size-equals-content-size-expected.txt: Added.
  • platform/mac/accessibility/webarea-size-equals-content-size.html: Added.
11:57 Changeset [74919] by simon.fraser@apple.com

2011-01-03 Simon Fraser <simon.fraser@apple.com>

Fix warning in 32-bit builds.

  • css/CSSGradientValue.cpp: (WebCore::CSSLinearGradientValue::createGradient):
11:50 Changeset [74918] by mihaip@chromium.org

2011-01-03 Mihai Parparita <mihaip@chromium.org>

Unreviewed, Chromium test expectation update.

Remove css2.1/ chromium-mac baselines that are no longer necessary after
r74892 (now that chromium-mac scrollbars match mac ones).

  • platform/chromium-mac/css2.1/t0803-c5502-mrgn-r-02-c-expected.checksum: Removed.
  • platform/chromium-mac/css2.1/t0803-c5502-mrgn-r-02-c-expected.png: Removed.
  • platform/chromium-mac/css2.1/t0803-c5505-mrgn-02-c-expected.checksum: Removed.
  • platform/chromium-mac/css2.1/t0803-c5505-mrgn-02-c-expected.png: Removed.
  • platform/chromium-mac/css2.1/t080301-c411-vt-mrgn-00-b-expected.checksum: Removed.
  • platform/chromium-mac/css2.1/t080301-c411-vt-mrgn-00-b-expected.png: Removed.
  • platform/chromium-mac/css2.1/t0905-c5525-fltclr-00-c-ag-expected.checksum: Removed.
  • platform/chromium-mac/css2.1/t0905-c5525-fltclr-00-c-ag-expected.png: Removed.
  • platform/chromium-mac/css2.1/t0905-c5525-fltmrgn-00-c-ag-expected.checksum: Removed.
  • platform/chromium-mac/css2.1/t0905-c5525-fltmrgn-00-c-ag-expected.png: Removed.
  • platform/chromium-mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.checksum: Removed.
  • platform/chromium-mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png: Removed.
  • platform/chromium-mac/css2.1/t0905-c5526-fltclr-00-c-ag-expected.checksum: Removed.
  • platform/chromium-mac/css2.1/t0905-c5526-fltclr-00-c-ag-expected.png: Removed.
  • platform/chromium-mac/css2.1/t1002-c5523-width-02-b-g-expected.checksum: Removed.
  • platform/chromium-mac/css2.1/t1002-c5523-width-02-b-g-expected.png: Removed.
  • platform/chromium-mac/css2.1/t1202-counters-08-b-expected.checksum: Removed.
  • platform/chromium-mac/css2.1/t1202-counters-08-b-expected.png: Removed.
  • platform/chromium-mac/css2.1/t1202-counters-09-b-expected.checksum: Removed.
  • platform/chromium-mac/css2.1/t1202-counters-09-b-expected.png: Removed.
  • platform/chromium-mac/css2.1/t140201-c535-bg-fixd-00-b-g-expected.checksum: Removed.
  • platform/chromium-mac/css2.1/t140201-c535-bg-fixd-00-b-g-expected.png: Removed.
  • platform/chromium-mac/css2.1/t140201-c537-bgfxps-00-c-ag-expected.checksum: Removed.
  • platform/chromium-mac/css2.1/t140201-c537-bgfxps-00-c-ag-expected.png: Removed.
  • platform/chromium-mac/css2.1/t1508-c527-font-07-b-expected.checksum: Removed.
  • platform/chromium-mac/css2.1/t1508-c527-font-07-b-expected.png: Removed.
  • platform/chromium/test_expectations.txt:
11:43 Changeset [74917] by mihaip@chromium.org

2011-01-03 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium test expectation update.

Remove failing expectations for tests that now pass (due to r74892).

  • platform/chromium/test_expectations.txt:
11:37 Changeset [74916] by commit-queue@webkit.org

2011-01-03 Benjamin C Meyer <bmeyer@rim.com>

Reviewed by Daniel Bates.

In the cmake build system move logic related to ENABLE_NOTIFICATIONS into its own block.
https://bugs.webkit.org/show_bug.cgi?id=51827

  • CMakeLists.txt:
11:36 Changeset [74915] by simon.fraser@apple.com

2011-01-03 Simon Fraser <simon.fraser@apple.com>

Reviewed by David Hyatt.

Implement -webkit-linear-gradient and -webkit-radial-gradient
https://bugs.webkit.org/show_bug.cgi?id=28152

Add support for -webkit-radial-gradients.

Tests: fast/gradients/css3-radial-gradients.html

fast/gradients/css3-radial-gradients2.html

  • css/CSSGradientValue.cpp: (WebCore::blend): Used to blend colors, which is necessary when truncating the start of radial gradients. (WebCore::GradientStop): Small struct to aid gradient stop processing. (WebCore::CSSGradientValue::addStops): Rename 'positions' to 'stops', and store the color so that we can blend it when truncating radial gradients. Changed to handle both linear and radial gradients. (WebCore::CSSRadialGradientValue::cssText): Update to follow the spec. (WebCore::CSSRadialGradientValue::resolveRadius): Stylistic change. (WebCore::distanceToClosestCorner): New utility method. (WebCore::distanceToFarthestCorner): Ditto. (WebCore::CSSRadialGradientValue::createGradient): New logic to deal with shape and fill rules.
  • css/CSSGradientValue.h: (WebCore::CSSGradientValue::isLinearGradient): Color-stop processing needs to know what kind of gradient it's dealing with, so add new isFooGradient methods. (WebCore::CSSGradientValue::isRadialGradient): Ditto. (WebCore::CSSLinearGradientValue::isLinearGradient): (WebCore::CSSRadialGradientValue::setShape): New setters for shape, size etc. (WebCore::CSSRadialGradientValue::setSizingBehavior): (WebCore::CSSRadialGradientValue::setEndHorizontalSize): (WebCore::CSSRadialGradientValue::setEndVerticalSize): (WebCore::CSSRadialGradientValue::isRadialGradient):
  • css/CSSParser.h:
  • css/CSSParser.h: Pass a CSSParserValueList* into parseFillPositionXY() and parseFillPosition() so we can use parseFillPosition() when parsing a gradient function.
  • css/CSSParser.cpp: (WebCore::CSSParser::parseFillPositionXY): Pass in a CSSParserValueList* (WebCore::CSSParser::parseFillPosition): Ditto (WebCore::CSSParser::parseFillProperty): Pass m_valueList to parseFillPosition. (WebCore::CSSParser::parseTransformOriginShorthand): Ditto (WebCore::CSSParser::parseRadialGradient): Flesh out radial gradient parsing. (WebCore::CSSParser::parseTransformOrigin): Pass m_valueList to parseFillPosition. (WebCore::CSSParser::parsePerspectiveOrigin): Ditto
  • css/CSSValueKeywords.in: New keywords for radial gradient shape and fill behaviors.
  • platform/graphics/Gradient.cpp: (WebCore::Gradient::Gradient): Pass aspect ratio for elliptical gradients.
  • platform/graphics/Gradient.h: Add aspect ratio for elliptical gradients. (WebCore::Gradient::create): (WebCore::Gradient::startRadius): Expose radii. (WebCore::Gradient::endRadius): (WebCore::Gradient::setStartRadius): Setters are required for when we need to scale color stops. (WebCore::Gradient::setEndRadius): (WebCore::Gradient::aspectRatio):
  • platform/graphics/cg/GradientCG.cpp: (WebCore::Gradient::paint): For elliptical gradients, scale the CTM.
  • platform/graphics/wince/GraphicsContextWinCE.cpp: (WebCore::GraphicsContext::fillRect): Use start/endRadius() rather than r0() and r1().
11:33 Changeset [74914] by abarth@webkit.org

2011-01-03 Adam Barth <abarth@webkit.org>

Reviewed by Simon Fraser.

webkit-patch should only hide update output if --quiet
https://bugs.webkit.org/show_bug.cgi?id=51838

As requested by smfr.

  • Scripts/webkitpy/tool/steps/update.py:
11:33 Changeset [74913] by mitz@apple.com

2011-01-03 Dan Bernstein <mitz@apple.com>

Reviewed by Simon Fraser.

Remove the unused RenderTableCell::m_percentageHeight
https://bugs.webkit.org/show_bug.cgi?id=51837

  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::RenderTableCell): Removed initialization of m_percentageHeight.
  • rendering/RenderTableCell.h: Removed m_percentageHeight.
11:31 Changeset [74912] by simon.fraser@apple.com

2011-01-03 Simon Fraser <simon.fraser@apple.com>

Reviewed by David Hyatt.

Implement -webkit-linear-gradient and -webkit-radial-gradient
https://bugs.webkit.org/show_bug.cgi?id=28152

Add support for the parsing and rendering of non-repeating CSS3 linear gradients,
according to <http://dev.w3.org/csswg/css3-images/#linear-gradients>.

Tests: fast/gradients/css3-color-stop-units.html

fast/gradients/css3-color-stops.html
fast/gradients/css3-gradient-parsing.html
fast/gradients/css3-linear-angle-gradients.html

  • css/CSSGradientValue.h: Add subclasses of CSSGradientValue for linear and radial gradients.
  • css/CSSGradientValue.cpp: (WebCore::CSSGradientValue::image): Add FIXME comment about why we can't cache the gradient sometimes. (WebCore::compareStops): positions are CSSValues now. (WebCore::CSSGradientValue::sortStopsIfNeeded): Add assertion that this is only called for old-style gradients. (WebCore::CSSGradientValue::addStops): New method that handles the spec rules about missing positions, ensuring that stop position is ordered, and spacing out stops without positions. Also normalize gradients which use stops outside the 0-1 range so that platforms can render them correctly. (WebCore::positionFromValue): Determin the position on the gradient line for percentage, number and length values. (WebCore::CSSGradientValue::computeEndPoint): (WebCore::CSSLinearGradientValue::cssText): (WebCore::endPointsFromAngle): Compute endpoints for a gradient which covers the rectangle given an angle. (WebCore::CSSLinearGradientValue::createGradient): (WebCore::CSSRadialGradientValue::cssText): (WebCore::CSSRadialGradientValue::resolveRadius): (WebCore::CSSRadialGradientValue::createGradient):
  • css/CSSParser.cpp: (WebCore::CSSParser::parseValue): Style fix. (WebCore::CSSParser::parseContent): Use isGeneratedImageValue() and parseGeneratedImage() (WebCore::CSSParser::parseFillImage): Use isGeneratedImageValue() and parseGeneratedImage() (WebCore::CSSParser::parseBorderImage): Use isGeneratedImageValue() and parseGeneratedImage() (WebCore::parseDeprecatedGradientPoint): Renamed to indicate that it's only used for -webkit-gradient. (WebCore::parseDeprecatedGradientColorStop): Renamed to indicate that it's only used for -webkit-gradient, and fixed to store CSSValues for the stop position. (WebCore::CSSParser::parseDeprecatedGradient): Renamed to indicate that it's only used for -webkit-gradient, and create CSSLinearGradientValue and CSSRadialGradientValue as appropriate. (WebCore::valueFromSideKeyword): (WebCore::parseGradientColorOrKeyword): Color parsing utility. (WebCore::CSSParser::parseLinearGradient): New method to parse linear gradients. (WebCore::CSSParser::parseRadialGradient): Stub for new method to parse radial gradients. (WebCore::CSSParser::isGeneratedImageValue): Detect gradients and CSS canvas. (WebCore::CSSParser::parseGeneratedImage): Parser for generated images like gradients and CSS canvas.
  • css/CSSParser.h:
  • platform/graphics/Gradient.h: (WebCore::Gradient::setP0): We need to be able to change the points when normalizing gradients. (WebCore::Gradient::setP1): Ditto.
11:18 Changeset [74911] by mihaip@chromium.org

2011-01-03 Mihai Parparita <mihaip@chromium.org>

Unreviewed, Chromium test expectation update.

Missed a few failing tests.

  • platform/chromium/test_expectations.txt:
11:04 Changeset [74910] by abarth@webkit.org

2011-01-03 Adam Barth <abarth@webkit.org>

Reviewed by David Levin.

commit-queue shouldn't reject patches twice if two bots process the same patch
https://bugs.webkit.org/show_bug.cgi?id=51805

Before raising an error, we first check whether the patch is still in
the commit-queue. This check is still racy, of course, but the time
window is much smaller.

  • Scripts/webkitpy/tool/bot/commitqueuetask.py:
11:01 Changeset [74909] by noam.rosenthal@nokia.com

2011-01-03 Noam Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Andreas Kling.

[Qt] document.getElementById(...) doesn't return the right object in combination with QGraphicsWidget
https://bugs.webkit.org/show_bug.cgi?id=51464

Added a way to bind any QObject created as a plugin to JavaScript,
by adding a custom member (qtObject) to WebCore::Widget.
Added a test to tst_qwebpage to make sure plugins created
as QGraphicsWidget are accessible through JavaScript.

  • bindings/js/ScriptControllerQt.cpp: (WebCore::ScriptController::createScriptInstanceForWidget):
  • platform/Widget.h:
  • platform/qt/WidgetQt.cpp: (WebCore::Widget::Widget): (WebCore::Widget::setBindingObject): (WebCore::Widget::bindingObject):

2011-01-03 Noam Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Andreas Kling.

[Qt] document.getElementById(...) doesn't return the right object in combination with QGraphicsWidget
https://bugs.webkit.org/show_bug.cgi?id=51464

Added a way to bind any QObject created as a plugin to JavaScript,
by adding a custom membe to WebCore::Widget.
Added a test to make sure plugins created as QGraphicsWidget are
accessible through JavaScript.

  • WebCoreSupport/FrameLoaderClientQt.cpp:
  • tests/qwebpage/tst_qwebpage.cpp: (PluginPage::createPlugin): (tst_QWebPage::graphicsWidgetPlugin):
10:55 Changeset [74908] by hyatt@apple.com

https://bugs.webkit.org/show_bug.cgi?id=51328

Reviewed by Simon Fraser.

WebCore:

Printing on a page with body { height: 100% } clips out the overflow contents. This happened
because the computePageRects function was never correct. It was using the layer's width and height
for the document's width and height, and the layer no longer includes overflow in its width and
height. It was also incorrectly assuming the first page would begin at (0,0), and this is an invalid
assumption in RTL or vertical text environments.

Added printing/page-count-percentage-height.html

  • page/PrintContext.cpp:

(WebCore::PrintContext::computePageRects):
(WebCore::PrintContext::computePageRectsWithPageSizeInternal):

LayoutTests:

Add layout test for printing clipping bug.

  • printing/page-count-percentage-height-expected.txt: Added.
  • printing/page-count-percentage-height.html: Added.
  • printing/script-tests/page-count-percentage-height.js: Added.

(test):

10:41 Changeset [74907] by ossy@webkit.org

Unreviewed, rolling out unnecessary r74905.

[Qt] DRT sideeffect revealed by r74896
https://bugs.webkit.org/show_bug.cgi?id=51829

  • platform/qt/Skipped:
10:40 Changeset [74906] by weinig@apple.com

Make run-api-tests less chatty.
https://bugs.webkit.org/show_bug.cgi?id=51831

Reviewed by Anders Carlsson.

  • Make script quiet by default and add --verbose option (replacing --quiet).
  • When not verbose, pipe stdout and stderr to devnull.
  • Scripts/run-api-tests:
10:33 Changeset [74905] by ossy@webkit.org

Unreviewed fix.

[Qt] DRT sideeffect revealed by r74896
https://bugs.webkit.org/show_bug.cgi?id=51829

  • platform/qt/Skipped: http/tests/misc/401-alternative-content.php added until fix.
10:29 Changeset [74904] by mihaip@chromium.org

2011-01-03 Mihai Parparita <mihaip@chromium.org>

Unreviewed, Chromium test expectation update.

Fix duplicate expectation.

  • platform/chromium/test_expectations.txt:
10:26 Changeset [74903] by xan@webkit.org

2011-01-03 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Disable superfluous GNU make built-in implicit rules
https://bugs.webkit.org/show_bug.cgi?id=51826

GNU make ships some superflous built-in rules that we never use
and that end up adding up to a very significant portion of our
total Makefile processing time. Disable them completely by
defining the rule without any recipe, as suggested by the GNU make
manual (10.5.6, Cancelling Implicit Rules).

In my system the null-build goes from:

make 43.51s user 12.77s system 99% cpu 56.628 total

to:

make 31.45s user 11.59s system 99% cpu 43.227 total

  • GNUmakefile.am: disable implicit built-in rules.
10:24 Changeset [74902] by psolanki@apple.com

2011-01-03 Pratik Solanki <psolanki@apple.com>

Unreviewed. Adding myself to committers.py.

  • Scripts/webkitpy/common/config/committers.py:
10:12 Changeset [74901] by laszlo.1.gombos@nokia.com

2011-01-03 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Unreviewed, build fix.

[Qt] Add back auth.html to the skipped list after r74896.

  • platform/qt/Skipped: Add http/tests/appcache/auth.html to the list.
10:10 Changeset [74900] by ossy@webkit.org

[Qt] Unreviewed buildfix for --minimal build after r74895.

  • html/InputType.cpp: Missing include added.
  • html/NumberInputType.cpp: Missing include added.
09:59 Changeset [74899] by dbates@webkit.org

2011-01-03 Daniel Bates <dbates@rim.com>

Attempt to fix the Chromium Linux Release build after changeset 74895 <http://trac.webkit.org/changeset/74895>.

The portion of the patch in <https://bugs.webkit.org/show_bug.cgi?id=51791> that modified the
file src/WebSearchableFormData.cpp was not landed (why?). Although the change log entry
associated with this change was landed.

  • src/WebSearchableFormData.cpp: (HTMLNames::IsInDefaultState):
09:53 Changeset [74898] by mihaip@chromium.org

2011-01-03 Mihai Parparita <mihaip@chromium.org>

Unreviewed. Update .gitignore with new JavaScriptCore location.

  • .gitignore:
09:48 Changeset [74897] by mihaip@chromium.org

2011-01-03 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by David Levin.

[Qt] Unskip some passing tests as the bot is migrated to Qt 4.7+
https://bugs.webkit.org/show_bug.cgi?id=51819

  • platform/qt/Skipped: Remove passing HTTP tests. Keep timer-vs-loading.html as it is still failing.
  • platform/qt/http/tests/loading/bad-scheme-subframe-expected.txt: Match the expected results with chromium to pass the test.
09:31 QtWebKitReleases edited by ademar.reis@openbossa.org
(diff)
09:28 QtWebKit edited by ademar.reis@openbossa.org
(diff)
09:26 Changeset [74896] by laszlo.1.gombos@nokia.com

2011-01-03 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by David Levin.

[Qt] Unskip some passing tests as the bot is migrated to Qt 4.7+
https://bugs.webkit.org/show_bug.cgi?id=51819

  • platform/qt/Skipped: Remove passing HTTP tests. Keep timer-vs-loading.html as it is still failing.
  • platform/qt/http/tests/loading/bad-scheme-subframe-expected.txt: Match the expected results with chromium to pass the test.
09:21 Changeset [74895] by darin@apple.com

2011-01-02 Darin Adler <darin@apple.com>

Reviewed by Kent Tamura.

Eliminate HTMLInputElement::m_deprecatedTypeNumber, other input refactoring and renaming
https://bugs.webkit.org/show_bug.cgi?id=51791

  • src/WebSearchableFormData.cpp: (HTMLNames::IsInDefaultState): Use hasAttribute(checkedAttr) to find out whether a button should be checked by default, rather than calling the defaultChecked function.

2011-01-02 Darin Adler <darin@apple.com>

Reviewed by Kent Tamura.

Eliminate HTMLInputElement::m_deprecatedTypeNumber, other input refactoring and renaming
https://bugs.webkit.org/show_bug.cgi?id=51791

  • dom/InputElement.h: Make sanitizeValueForTextField public so it can be called by InputType.
  • html/BaseButtonInputType.cpp: (WebCore::BaseButtonInputType::accessKeyAction): Added. (WebCore::BaseButtonInputType::storesValueSeparateFromAttribute): Added.
  • html/BaseButtonInputType.h: Ditto.
  • html/BaseCheckableInputType.cpp: (WebCore::BaseCheckableInputType::canSetStringValue): Added. (WebCore::BaseCheckableInputType::accessKeyAction): Added. (WebCore::BaseCheckableInputType::fallbackValue): Added. (WebCore::BaseCheckableInputType::storesValueSeparateFromAttribute): Added. (WebCore::BaseCheckableInputType::isCheckable): Added.
  • html/BaseCheckableInputType.h: Ditto.
  • html/BaseDateAndTimeInputType.cpp: (WebCore::BaseDateAndTimeInputType::hasSpinButton): Added.
  • html/BaseDateAndTimeInputType.h: Ditto.
  • html/BaseTextInputType.h: Made more functions private.
  • html/ButtonInputType.cpp: (WebCore::ButtonInputType::isTextButton): Added.
  • html/ButtonInputType.h: Ditto.
  • html/CheckboxInputType.cpp: (WebCore::CheckboxInputType::willDispatchClick): Added. (WebCore::CheckboxInputType::didDispatchClick): Added. (WebCore::CheckboxInputType::isCheckbox): Added.
  • html/CheckboxInputType.h: Ditto.
  • html/DateTimeInputType.cpp: (WebCore::DateTimeInputType::scaledStepValueShouldBeInteger): Fixed typo in name of this function.
  • html/DateTimeInputType.h: Ditto.
  • html/DateTimeLocalInputType.cpp: (WebCore::DateTimeLocalInputType::scaledStepValueShouldBeInteger): Ditto.
  • html/DateTimeLocalInputType.h: Ditto.
  • html/EmailInputType.cpp: (WebCore::EmailInputType::isEmailField): Added.
  • html/EmailInputType.h: Ditto.
  • html/FileInputType.cpp: (WebCore::FileInputType::FileInputType): Added. (WebCore::FileInputType::canSetStringValue): Added. (WebCore::FileInputType::canChangeFromAnotherType): Added. (WebCore::FileInputType::files): Added. (WebCore::FileInputType::canSetValue): Added. (WebCore::FileInputType::getTypeSpecificValue): Added. (WebCore::FileInputType::storesValueSeparateFromAttribute): Added. (WebCore::FileInputType::setFileList): Added. (WebCore::FileInputType::isFileUpload): Added.
  • html/FileInputType.h: Ditto.
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::HTMLInputElement): Updated for data member renaming and removal. (WebCore::HTMLInputElement::isValidValue): Call canSetStringValue instead of checking specific type numbers. (WebCore::HTMLInputElement::getAllowedValueStepWithDecimalPlaces): Use fastGetAttribute and fixed typo in the name of the scaledStepValueShouldBeInteger function. (WebCore::HTMLInputElement::isKeyboardFocusable): Call InputType::isKeyboardFocusable; moved most of the type-specific logic there. (WebCore::HTMLInputElement::shouldUseInputMethod): Call InputType::shouldUseInputMethod; moved the type-specific logic there. (WebCore::HTMLInputElement::handleBlurEvent): Call InputType::handleBlurEvent; moved the type-specific logic there. (WebCore::HTMLInputElement::setType): Tweak the names and types in this function. (WebCore::HTMLInputElement::updateType): Removed the code that set m_deprecatedTypeNumber. Compare types by comparing the value from formControlType. Removed file-specific logic and instead call InputType::canChangeFromAnotherType. Streamlined the logic for activation callbacks. (WebCore::HTMLInputElement::accessKeyAction): Call InputType::accessKeyAction; moved the type-specific logic there. (WebCore::HTMLInputElement::mapToEntry): Call InputType::shouldRespectHeightAndWidthAttributes and InputType::shouldRespectAlignAttribute. (WebCore::HTMLInputElement::parseMappedAttribute): Updated for name changes and the removal of m_defaultChecked. Changed the alt attribute logic to be based on the class of the renderer. Call InputType::srcAttributeChanged and moved the type-specific logic there. Call shouldRespectAlignAttribute and shouldRespectHeightAndWidthAttributes rather than having type-specific logic here. Call minOrMaxAttributeChanged. (WebCore::HTMLInputElement::rendererIsNeeded): Call InputType::rendererIsNeeded; moved the type-specific logic there. (WebCore::HTMLInputElement::attach): Removed the unneeded m_inited flag, which was redundant with the m_haveType flag. Call InputType::attach; moved the type-specific logic there. (WebCore::HTMLInputElement::altText): Use fastGetAttribute. (WebCore::HTMLInputElement::isSuccessfulSubmitButton): Call InputType::canBeSuccessfulSubmitButton; moved the type-specific logic there. (WebCore::HTMLInputElement::isActivatedSubmit): Updated for name changes. (WebCore::HTMLInputElement::setActivatedSubmit): Ditto. (WebCore::HTMLInputElement::reset): Updated to use InputType::storesValueSeparateFromAttribute. Also use hasAttribute(checkedAttr) rather than m_defaultChecked, since both are the same. Also updated for name change. (WebCore::HTMLInputElement::setChecked): Updated for name changes. Also added call to InputType::shouldSendChangeEventAfterCheckedChanged and moved the type-specific logic there. (WebCore::HTMLInputElement::setIndeterminate): Call isCheckable to see if indeterminate is allowed. Also updated for name changes. (WebCore::HTMLInputElement::copyNonAttributeProperties): Updated for name changes and removed data members. (WebCore::HTMLInputElement::value): Call InputType::getTypeSpecificValue and InputType::fallbackValue. Moved the type-specific logic there. (WebCore::HTMLInputElement::valueWithDefault): Call InputType::defaultValue. Moved the type-specific logic there. (WebCore::HTMLInputElement::setSuggestedValue): Call InputType::canSetSuggestedValue. Moved the type-specific logic there. (WebCore::HTMLInputElement::setValue): Call InputType::canSetValue. Moved the type-specific logic there. Clear the file list if it exists rather than checking the type explicitly. We could probably do that a more elegant way. (WebCore::HTMLInputElement::placeholder): Use fastGetAttribute. (WebCore::HTMLInputElement::setValueFromRenderer): Use the isFileUpload function in the assertion. (WebCore::HTMLInputElement::setFileListFromRenderer): Put most of the code from this function into FileInputType::setFileList. (WebCore::HTMLInputElement::preDispatchEventHandler): Changed to call InputType::willDispatchClick, which does the type-specific work. Still need to use a single struct for all types, because the type of the element could change during the event handling. (WebCore::HTMLInputElement::postDispatchEventHandler): Changed to call InputType::didDispatchClick. (WebCore::HTMLInputElement::defaultValue): Use fastGetAttribute. (WebCore::HTMLInputElement::accept): Use fastGetAttribute. (WebCore::HTMLInputElement::alt): Use fastGetAttribute. (WebCore::HTMLInputElement::src): Use fastGetAttribute. (WebCore::HTMLInputElement::setAutofilled): Updated for name changes. (WebCore::HTMLInputElement::files): Use InputType::files. (WebCore::HTMLInputElement::isAcceptableValue): Use InputType::isAcceptableValue. (WebCore::HTMLInputElement::sanitizeValue): Use InputType::sanitizeValue. (WebCore::HTMLInputElement::hasUnacceptableValue): Use InputType::hasUnacceptableValue. (WebCore::HTMLInputElement::needsActivationCallback): Use InputType::shouldResetOnDocumentActivation. (WebCore::HTMLInputElement::willMoveToNewOwnerDocument): Use InputType::willMoveToNewOwnerDocument. (WebCore::HTMLInputElement::dataList): Use InputType::shouldRespectListAttribute. (WebCore::HTMLInputElement::selectedOption): Tweaked logic and naming a bit. (WebCore::HTMLInputElement::stepUpFromRenderer): Use fastGetAttribute. (WebCore::HTMLInputElement::isSpeechEnabled): Use InputType::shouldRespectSpeechAttribute. (WebCore::HTMLInputElement::isTextButton): No longer inline. Calls through to InputType. (WebCore::HTMLInputElement::isRadioButton): Ditto. (WebCore::HTMLInputElement::isSearchField): Ditto. (WebCore::HTMLInputElement::isInputTypeHidden): Ditto. (WebCore::HTMLInputElement::isPasswordField): Ditto. (WebCore::HTMLInputElement::isCheckbox): Ditto. (WebCore::HTMLInputElement::isText): Ditto. (WebCore::HTMLInputElement::isEmailField): Ditto. (WebCore::HTMLInputElement::isFileUpload): Ditto. (WebCore::HTMLInputElement::isImageButton): Ditto. (WebCore::HTMLInputElement::isNumberField): Ditto. (WebCore::HTMLInputElement::isSubmitButton): Ditto. (WebCore::HTMLInputElement::isTelephoneField): Ditto. (WebCore::HTMLInputElement::isURLField): Ditto. (WebCore::HTMLInputElement::isEnumeratable): Ditto. (WebCore::HTMLInputElement::isChecked): No longer inline. Calls InputType::isCheckable. (WebCore::HTMLInputElement::hasSpinButton): No longer inline. Calls through to InputType. (WebCore::HTMLInputElement::supportsPlaceholder): No longer inline. Calls isTextType as before, but with no special case for ISINDEX. That special case was unneeded since it returns true from isTextType. (WebCore::HTMLInputElement::checkedRadioButtons): No longer inline. (WebCore::HTMLInputElement::handleBeforeTextInsertedEvent): No longer inline.
  • html/HTMLInputElement.h: Removed multiple unneeded includes. The big one is probably InputType.h, but also HTMLFormElement.h. Removed unneeded forward declarations. Made many functions no longer inline since they now need to make virtual function dispatches. Removed the unneeded defaultChecked and webkitdirectory functions. Both are handled by HTML attribute reflection for DOM bindings, and the callers instead can get at the attribute. Made updateCheckedRadioButtons public so it can be called by an InputType class. Removed DeprecatedInputType, InputTypeMap, createTypeMap, deprecatedInputType, allowsIndeterminate, respectHeightAndWidthAttrs, storesValueSeparateFromAttribute, m_imageLoader, m_fileList, m_deprecatedTypeNumber, m_defaultChecked, and m_inited. Renamed m_checked to m_isChecked, m_useDefaultChecked to m_reflectsCheckedAttribute, m_indeterminate tom_isIndeterminate, m_haveType to m_hasType, m_activeSubmit to m_isActivatedSubmit, and m_autofilled to m_isAutofilled.


  • html/HiddenInputType.cpp: (WebCore::HiddenInputType::accessKeyAction): Added. (WebCore::HiddenInputType::rendererIsNeeded) Added.: (WebCore::HiddenInputType::storesValueSeparateFromAttribute): Added. (WebCore::HiddenInputType::isHiddenType): Added. (WebCore::HiddenInputType::shouldRespectHeightAndWidthAttributes): Added.
  • html/HiddenInputType.h: Ditto.
  • html/ImageInputType.cpp: (WebCore::ImageInputType::ImageInputType): Moved out of the header file. (WebCore::ImageInputType::srcAttributeChanged): Added. (WebCore::ImageInputType::attach): Added. (WebCore::ImageInputType::willMoveToNewOwnerDocument): Added. (WebCore::ImageInputType::shouldRespectAlignAttribute): Added. (WebCore::ImageInputType::canBeSuccessfulSubmitButton): Added. (WebCore::ImageInputType::isImageButton): Added. (WebCore::ImageInputType::isEnumeratable): Added. (WebCore::ImageInputType::shouldRespectHeightAndWidthAttributes): Added.
  • html/ImageInputType.h: Ditto.
  • html/InputType.cpp: (WebCore::InputType::create): Changed argument type to String. There is no value in taking an AtomicString here. (WebCore::InputType::scaledStepValueShouldBeInteger): Fixed typo in this function name. (WebCore::InputType::canSetStringValue): Added. (WebCore::InputType::isKeyboardFocusable): Added. (WebCore::InputType::shouldUseInputMethod): Added. (WebCore::InputType::handleBlurEvent): Added. (WebCore::InputType::accessKeyAction): Added. (WebCore::InputType::attach): Added. (WebCore::InputType::srcAttributeChanged): Added. (WebCore::InputType::willMoveToNewOwnerDocument): Added. (WebCore::InputType::shouldRespectAlignAttribute): Added. (WebCore::InputType::canChangeFromAnotherType): Added. (WebCore::InputType::minOrMaxAttributeChanged): Added. (WebCore::InputType::canBeSuccessfulSubmitButton): Added. (WebCore::InputType::rendererIsNeeded): Added. (WebCore::InputType::files): Added. (WebCore::InputType::getTypeSpecificValue): Added. (WebCore::InputType::fallbackValue): Added. (WebCore::InputType::defaultValue): Added. (WebCore::InputType::canSetSuggestedValue): Added. (WebCore::InputType::shouldSendChangeEventAfterCheckedChanged): Added. (WebCore::InputType::storesValueSeparateFromAttribute): Added. (WebCore::InputType::canSetValue): Added. (WebCore::InputType::willDispatchClick): Added. (WebCore::InputType::didDispatchClick): Added. (WebCore::InputType::isAcceptableValue): Added. (WebCore::InputType::sanitizeValue): Added. (WebCore::InputType::hasUnacceptableValue): Added. (WebCore::InputType::setFileList): Added. (WebCore::InputType::shouldResetOnDocumentActivation): Added. (WebCore::InputType::shouldRespectListAttribute): Added. (WebCore::InputType::shouldRespectSpeechAttribute): Added. (WebCore::InputType::isTextButton): Added. (WebCore::InputType::isRadioButton): Added. (WebCore::InputType::isSearchField): Added. (WebCore::InputType::isHiddenType): Added. (WebCore::InputType::isPasswordField): Added. (WebCore::InputType::isCheckbox): Added. (WebCore::InputType::isEmailField): Added. (WebCore::InputType::isFileUpload): Added. (WebCore::InputType::isImageButton): Added. (WebCore::InputType::isNumberField): Added. (WebCore::InputType::isSubmitButton): Added. (WebCore::InputType::isTelephoneField): Added. (WebCore::InputType::isURLField): Added. (WebCore::InputType::isEnumeratable): Added. (WebCore::InputType::isCheckable): Added. (WebCore::InputType::hasSpinButton): Added. (WebCore::InputType::shouldRespectHeightAndWidthAttributes): Added.
  • html/InputType.h: Removed unneeded ExceptionCode.h include and used a typedef instead as we do when we want for forward declare it. Added includes and forward declarations needed for new functions. Added ClickHandlingState structure. Changed the argument to create to a String rather than AtomicString. Added many virtual functions.


  • html/IsIndexInputType.cpp: (WebCore::IsIndexInputType::shouldRespectListAttribute): Added.
  • html/IsIndexInputType.h: Ditto.
  • html/NumberInputType.cpp: (WebCore::NumberInputType::handleBlurEvent): Added. (WebCore::NumberInputType::isAcceptableValue): Added. (WebCore::NumberInputType::sanitizeValue): Added. (WebCore::NumberInputType::hasUnacceptableValue): Added. (WebCore::NumberInputType::shouldRespectSpeechAttribute): Added. (WebCore::NumberInputType::isNumberField): Added. (WebCore::NumberInputType::hasSpinButton): Added.
  • html/NumberInputType.h: Ditto.
  • html/PasswordInputType.cpp: (WebCore::PasswordInputType::shouldUseInputMethod): Added. (WebCore::PasswordInputType::shouldResetOnDocumentActivation): Added. (WebCore::PasswordInputType::shouldRespectListAttribute): Added. (WebCore::PasswordInputType::shouldRespectSpeechAttribute): Added. (WebCore::PasswordInputType::isPasswordField): Added.
  • html/PasswordInputType.h: Ditto.
  • html/RadioInputType.cpp: (WebCore::RadioInputType::isKeyboardFocusable): Added. (WebCore::RadioInputType::attach): Added. (WebCore::RadioInputType::shouldSendChangeEventAfterCheckedChanged): Added. (WebCore::RadioInputType::willDispatchClick): Added. (WebCore::RadioInputType::didDispatchClick): Added. (WebCore::RadioInputType::isRadioButton): Added.
  • html/RadioInputType.h: Ditto.
  • html/RangeInputType.cpp: (WebCore::RangeInputType::accessKeyAction): Added. (WebCore::RangeInputType::minOrMaxAttributeChanged): Added. (WebCore::RangeInputType::fallbackValue): Added. (WebCore::RangeInputType::sanitizeValue): Added. (WebCore::RangeInputType::shouldRespectListAttribute): Added.
  • html/RangeInputType.h: Ditto.
  • html/ResetInputType.cpp: (WebCore::ResetInputType::defaultValue): Added. (WebCore::ResetInputType::isTextButton): Added.
  • html/ResetInputType.h: Ditto.
  • html/SearchInputType.cpp: (WebCore::SearchInputType::shouldRespectSpeechAttribute): Added. (WebCore::SearchInputType::isSearchField): Added.
  • html/SearchInputType.h: Ditto.
  • html/SubmitInputType.cpp: (WebCore::SubmitInputType::canBeSuccessfulSubmitButton): Added. (WebCore::SubmitInputType::defaultValue): Added. (WebCore::SubmitInputType::isSubmitButton): Added. (WebCore::SubmitInputType::isTextButton): Added.
  • html/SubmitInputType.h: Ditto.
  • html/TelephoneInputType.cpp: (WebCore::TelephoneInputType::shouldRespectSpeechAttribute): Added. (WebCore::TelephoneInputType::isTelephoneField): Added.
  • html/TelephoneInputType.h: Ditto.
  • html/TextFieldInputType.cpp: (WebCore::TextFieldInputType::shouldUseInputMethod): Added. (WebCore::TextFieldInputType::sanitizeValue): Added. (WebCore::TextFieldInputType::shouldRespectListAttribute): Added.
  • html/TextFieldInputType.h: Ditto.
  • html/TextInputType.cpp: (WebCore::TextInputType::canSetSuggestedValue): Added. (WebCore::TextInputType::shouldRespectSpeechAttribute): Added.
  • html/TextInputType.h: Ditto.
  • html/TimeInputType.cpp: (WebCore::TimeInputType::scaledStepValueShouldBeInteger): Fixed typo in the name of this function.
  • html/TimeInputType.h: Ditto.
  • html/URLInputType.cpp: (WebCore::URLInputType::isURLField): Added.
  • html/URLInputType.h: Ditto.
09:11 Changeset [74894] by mihaip@chromium.org

2011-01-03 Mihai Parparita <mihaip@chromium.org>

Unreviewed, Chromium test expectation update.

Update expectations after r74892. A bunch of previously failing tests
now pass (since they match scrollbars with the mac port). Some tests
also started to fail, they should be fixed by removing their
chromium-mac baselines.

  • platform/chromium/test_expectations.txt:
09:02 Changeset [74893] by weinig@apple.com

Ensure that the correct initial focusable area is focused when tabbing
and shift-tabbing into the WKView.

Reviewed by Anders Carlsson.

  • UIProcess/API/mac/WKView.mm:

(-[WKView becomeFirstResponder]): Use the keyViewSelectionDirection to set
the initial focus.

08:16 Changeset [74892] by mihaip@chromium.org

2011-01-03 Mihai Parparita <mihaip@chromium.org>

Unreviewed.

NSScrollView-based scrollbars and ScrollBarTheme-based scrollbars don't look the same
https://bugs.webkit.org/show_bug.cgi?id=51151

Flip switch to use WebThemeEngine for Chromium/Mac scrollbar rendering,
so that it can match Safari's (and thus use the same baselines).

No new tests, should be covered by layout tests (which will need
expectation changes)

  • platform/chromium/ScrollbarThemeChromiumMac.mm:
08:04 Changeset [74891] by tonikitoo@webkit.org

2011-01-02 Antonio Gomes <agomes@rim.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Refactor EditorClientQt::handleKeyboardEvent
https://bugs.webkit.org/show_bug.cgi?id=51306

EditorClientQt::handleKeyboardEvent relies on QWebPagePrivate::editorActionForKeyEvent()
to handle all editor commands that have a QAction associted with it.
In practice, that covers most of editor commands (as one can see in editorCommandWebActions,
in qwebpage.cpp). However, there are some key down events that are associated to no QAction
or need special handling when features like spatial navigation or
caret browsing are enabled. Currently, these cases are being handled with confusing
and nested if/else switch's statements in EditorClientQt::handleKeyboardEvent(),
and the code is hardly readable.

This patch introduces a mapping hash for those cases, simplifying much
the code. Basically, nested switches statements mixed with if/else's were
refactored, and early returns were added right after an event gets consumed
by the Editor.

Since it is a refactor only patch, there is no funcionality change at
all, and then no new tests are being added.

  • WebCoreSupport/EditorClientQt.cpp: (WebCore::interpretKeyEvent): (WebCore::EditorClientQt::handleKeyboardEvent):
07:50 Changeset [74890] by commit-queue@webkit.org

2011-01-03 Antonio Gomes <agomes@rim.com>

Unreviewed build fix for WebKit/Gtk+.

RenderThemeGtk::initMediaColors() in RenderThemeGtk2.cpp needs to be
guarded by ENABLE(VIDEO), as it is in its header.

No new tests.

  • platform/gtk/RenderThemeGtk2.cpp:
06:00 Changeset [74889] by commit-queue@webkit.org

2011-01-03 Koan-Sin Tan <koansin.tan@gmail.com>

Reviewed by Xan Lopez.

"Tool/Scripts/run-launcher --gtk" stopped working after 74855
https://bugs.webkit.org/show_bug.cgi?id=51806

Originally, the $libraryName is 'JavaScriptCore'. When building release
one, the $libraryDir was 'WebKitBuild/Release/JavaScriptCore/../.libs/'
which doesn't exist anymore ('WebKitBuild/Release/JavaScriptCore'
is 'WebKitBuild/Release/Source/JavaScriptCore' now), and
'WebKitBuild/Release/Source/JavaScriptCore/../../.libs' looks weird,
so make it 'WebKitBuild/Release/.libs'

  • Scripts/webkitdirs.pm:
Note: See TracTimeline for information about the timeline view.