Timeline


and

01/18/11:

23:40 Changeset [76104] by antonm@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-01-18 Anton Muhin <antonm@chromium.org>

Reviewed by Adam Barth.

[v8] Minor cleanup: make 2nd argument of removeIfPresnt accept only a value type stored in the DOM map
https://bugs.webkit.org/show_bug.cgi?id=51683

Covered by the existing tests.

  • bindings/v8/DOMDataStore.cpp: (WebCore::DOMDataStore::weakNodeCallback): (WebCore::DOMDataStore::IntrusiveDOMWrapperMap::removeIfPresent):
  • bindings/v8/DOMDataStore.h:
  • bindings/v8/V8DOMMap.h: (WebCore::WeakReferenceMap::removeIfPresent):
23:12 Changeset [76103] by mjs@apple.com
  • 2 edits in trunk/Tools
  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Removed unncessary inculde of WKStringCF.h

Rubber stamped by Csaba Osztrogonac

22:09 Changeset [76102] by eric@webkit.org
  • 1 edit
    2 deletes in trunk/LayoutTests

2011-01-18 Eric Seidel <eric@webkit.org>

Unreviewed, rolling out r76084.
http://trac.webkit.org/changeset/76084
https://bugs.webkit.org/show_bug.cgi?id=52654

Crashes on the bots

  • fast/dom/Window/open-window-empty-url-expected.txt: Removed.
  • fast/dom/Window/open-window-empty-url.html: Removed.
21:15 Changeset [76101] by dpranke@chromium.org
  • 5 edits in trunk/Tools

2011-01-18 Dirk Pranke <dpranke@chromium.org>

Reviewed by Tony Chang.

new-run-webkit-tests: add a --build-directory command line argument

Official Google Chrome builds use a non-standard build directory
location. This patch adds a --build-directory argument that
allows that location to be specified on the command line. Only
Chromium-based builds will use this flag for now, but anyone can
in the future.

There are no unit tests for this since it's difficult to test
until mock filesystems are fully supported in the code. This was
tested by hand for now.

https://bugs.webkit.org/show_bug.cgi?id=52694

  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
20:33 Changeset [76100] by kbr@google.com
  • 4 edits in trunk/Source/JavaScriptCore

2011-01-18 Kenneth Russell <kbr@google.com>

Unreviewed, rolling out r76078.
http://trac.webkit.org/changeset/76078
https://bugs.webkit.org/show_bug.cgi?id=52668

Caused crashes of fast/canvas/webgl/constants.html,
fast/canvas/webgl/gl-enum-tests.html, and possibly other layout
test crashes in Release mode. WebGL crashes were observed with
"run-webkit-tests fast/canvas/webgl". It was necessary to run
multiple tests to provoke the crash.

  • interpreter/RegisterFile.h: (JSC::RegisterFile::markGlobals):
  • runtime/JSActivation.cpp: (JSC::JSActivation::markChildren):
  • runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::markChildren):
20:18 Changeset [76099] by morrita@google.com
  • 1 edit in trunk/Source/WebCore/ChangeLog

Added a reviewer line for the last checkin

20:11 Changeset [76098] by morrita@google.com
  • 11 edits
    1 add in trunk/Source/WebCore

2011-01-18 MORITA Hajime <morrita@google.com>

Refactoring: EventHandler::handleTextInputEvent should accept an enum instead of bools.
https://bugs.webkit.org/show_bug.cgi?id=52608

No new tests. no behavioral change.

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/TextEvent.cpp: (WebCore::TextEvent::create): (WebCore::TextEvent::createForDrop): (WebCore::TextEvent::TextEvent):
  • dom/TextEvent.h: (WebCore::TextEvent::isLineBreak): (WebCore::TextEvent::isBackTab): (WebCore::TextEvent::isPaste): (WebCore::TextEvent::isDrop):
  • dom/TextEventInputType.h: Added. Extracted from TextEvent::TextInputType.
  • editing/EditorCommand.cpp: (WebCore::executeInsertBacktab): (WebCore::executeInsertLineBreak): (WebCore::executeInsertNewline): (WebCore::executeInsertTab):
  • page/EventHandler.cpp: (WebCore::EventHandler::handleTextInputEvent):
  • page/EventHandler.h:
20:08 Changeset [76097] by mjs@apple.com
  • 4 edits in trunk/LayoutTests

2011-01-18 Maciej Stachowiak <mjs@apple.com>

Reviewed by Sam Weinig.

Skip (and in a few cases fix) tests for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=52698

  • editing/pasteboard/copy-null-characters.html: Make this test fail in a more obvious way when it fails.
  • fast/events/scroll-event-does-not-bubble.html: Make this test properly handle the fact that scroll events are async. The job was half-done before.
  • platform/mac-wk2/Skipped: Skip!
19:56 Changeset [76096] by mjs@apple.com
  • 2 edits in trunk/Tools

Not reviewed. Bot fix.

Remove an inadvertently committed debugging print.

  • DumpRenderTree/mac/LayoutTestControllerMac.mm:

(LayoutTestController::notifyDone):

19:55 Changeset [76095] by kbr@google.com
  • 3 edits in trunk/Source/ThirdParty/ANGLE

2011-01-18 Kenneth Russell <kbr@google.com>

Unreviewed, Leopard build fix. Remove flex/bison targets for GLSL
grammar because the generated sources are already checked in.

  • ANGLE.xcodeproj/project.pbxproj:
  • src/build_angle.xcodeproj/project.pbxproj:
19:30 Changeset [76094] by mjs@apple.com
  • 5 edits in trunk/LayoutTests

Not reviewed.

Revert inadvertantly committed test changes.

  • editing/pasteboard/copy-null-characters.html:
  • fast/events/scroll-event-does-not-bubble.html:
  • platform/mac-wk2/Skipped:
  • transitions/remove-transition-style.html:
19:23 Changeset [76093] by kbr@google.com
  • 2 edits in trunk/Source/ThirdParty/ANGLE

2011-01-18 Kenneth Russell <kbr@google.com>

Unreviewed, release build fix. Explicitly cast away const.

  • src/compiler/preprocessor/scanner.c: (ScanFromString):
19:16 Changeset [76092] by mjs@apple.com
  • 14 edits in trunk

2011-01-18 Maciej Stachowiak <mjs@apple.com>

Reviewed by Sam Weinig.

WebKitTestRunner should track loading more like DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=52692

Change load tracking to track the current top loading frame, in the manner of DumpRenderTree.
This makes some tests that call notifyDone multiple times pass.


  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::InjectedBundle): (WTR::InjectedBundle::done):
  • WebKitTestRunner/InjectedBundle/InjectedBundle.h: (WTR::InjectedBundle::topLoadingFrame): (WTR::InjectedBundle::setTopLoadingFrame):
  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::InjectedBundlePage): (WTR::InjectedBundlePage::stopLoading): (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame): (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame): (WTR::InjectedBundlePage::didFinishLoadForFrame): (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::notifyDone):
  • WebKitTestRunner/TestController.cpp: (WTR::TestController::didReceiveMessageFromInjectedBundle):

2011-01-18 Maciej Stachowiak <mjs@apple.com>

Reviewed by Sam Weinig.

WebKitTestRunner should track loading more like DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=52692


Relax the message check in didSaveFrameToPageCache a bit more, since
layout tests were still hitting the old one.

  • UIProcess/WebPageProxy.cpp: (WebKit::isDisconnectedFrame): (WebKit::WebPageProxy::didSaveFrameToPageCache):
19:00 Changeset [76091] by kbr@google.com
  • 77 edits
    21 adds
    5 deletes in trunk/Source

2011-01-18 Ben Vanik <ben.vanik@gmail.com>

Reviewed by Kenneth Russell.

Updating ANGLE in WebKit to r533.
https://bugs.webkit.org/show_bug.cgi?id=47194

  • platform/graphics/ANGLEWebKitBridge.cpp: (WebCore::ANGLEWebKitBridge::ANGLEWebKitBridge): (WebCore::ANGLEWebKitBridge::~ANGLEWebKitBridge): (WebCore::ANGLEWebKitBridge::validateShaderSource): Update to new ANGLE API for shader validation.
  • platform/graphics/ANGLEWebKitBridge.h: (WebCore::ANGLEWebKitBridge::setResources): Renaming types to new names.
  • platform/graphics/mac/GraphicsContext3DMac.mm: (WebCore::GraphicsContext3D::GraphicsContext3D): Initialize ANGLEResources with ANGLE init call to prevent uninitialized variables.

2011-01-18 Ben Vanik <ben.vanik@gmail.com>

Reviewed by Kenneth Russell.

Updating ANGLE in WebKit to r533.
https://bugs.webkit.org/show_bug.cgi?id=47194

  • ANGLE.xcodeproj/project.pbxproj:
  • include/GLSLANG/ShaderLang.h:
  • src/common/debug.cpp: (gl::trace):
  • src/common/debug.h:
  • src/compiler/CodeGenGLSL.cpp: (ConstructCompiler):
  • src/compiler/CodeGenHLSL.cpp: (ConstructCompiler):
  • src/compiler/Common.h: (EncodeSourceLoc): (DecodeSourceLoc):
  • src/compiler/Compiler.cpp: Added. (TShHandleBase::TShHandleBase): (TShHandleBase::~TShHandleBase): (TCompiler::TCompiler): (TCompiler::~TCompiler): (TCompiler::Init): (TCompiler::compile): (TCompiler::InitBuiltInSymbolTable): (TCompiler::clearResults): (TCompiler::validateLimitations): (TCompiler::collectAttribsUniforms):
  • src/compiler/ExtensionBehavior.h: Added.
  • src/compiler/InfoSink.cpp: (TInfoSinkBase::location):
  • src/compiler/InfoSink.h: (TInfoSinkBase::size):
  • src/compiler/Initialize.cpp: (BuiltInFunctionsCommon): (BuiltInFunctionsVertex): (BuiltInFunctionsFragment): (StandardUniforms): (DefaultPrecisionVertex): (DefaultPrecisionFragment): (BuiltInConstants): (TBuiltIns::initialize): (IdentifyBuiltIns): (InitExtensionBehavior):
  • src/compiler/Initialize.h:
  • src/compiler/IntermTraverse.cpp: (TIntermLoop::traverse):
  • src/compiler/Intermediate.cpp: (getOperatorString): (TIntermediate::addBinaryMath): (TIntermediate::addLoop): (TIntermediate::postProcess): (TIntermBinary::promote):
  • src/compiler/OutputGLSL.cpp: (TOutputGLSL::visitUnary): (TOutputGLSL::visitLoop):
  • src/compiler/OutputHLSL.cpp: (sh::OutputHLSL::OutputHLSL): (sh::OutputHLSL::header): (sh::OutputHLSL::visitBinary): (sh::OutputHLSL::visitUnary): (sh::OutputHLSL::visitAggregate): (sh::OutputHLSL::visitLoop): (sh::OutputHLSL::handleExcessiveLoop): (sh::OutputHLSL::argumentString):
  • src/compiler/OutputHLSL.h:
  • src/compiler/ParseHelper.cpp: (ReportInfo): (DefineExtensionMacros): (TParseContext::error): (TParseContext::warning): (TParseContext::reservedErrorCheck): (TParseContext::constructorErrorCheck): (TParseContext::arrayQualifierErrorCheck): (TParseContext::extensionErrorCheck): (TParseContext::areAllChildConst): (PaParseStrings):
  • src/compiler/ParseHelper.h: (TParseContext::TParseContext):
  • src/compiler/PoolAlloc.cpp: (InitializeGlobalPools): (FreeGlobalPools): (SetGlobalPoolAllocator): (TPoolAllocator::TPoolAllocator): (TPoolAllocator::~TPoolAllocator): (TAllocation::checkAllocList):
  • src/compiler/PoolAlloc.h:
  • src/compiler/SearchSymbol.cpp: Added. (sh::SearchSymbol::SearchSymbol): (sh::SearchSymbol::traverse): (sh::SearchSymbol::visitSymbol): (sh::SearchSymbol::foundMatch):
  • src/compiler/SearchSymbol.h: Added.
  • src/compiler/ShHandle.h: (TCompiler::getAsCompiler): (TCompiler::getInfoSink): (TCompiler::getAttribs): (TCompiler::getUniforms): (TCompiler::getShaderType): (TCompiler::getShaderSpec):
  • src/compiler/ShaderLang.cpp: (getVariableMaxLength): (getVariableInfo): (ShInitBuiltInResources): (ShConstructCompiler): (ShCompile): (ShGetInfo): (ShGetInfoLog): (ShGetObjectCode): (ShGetActiveAttrib): (ShGetActiveUniform):
  • src/compiler/SymbolTable.cpp: (TSymbolTableLevel::relateToExtension):
  • src/compiler/SymbolTable.h: (TVariable::shareConstPointer): (TFunction::relateToExtension): (TFunction::getExtension): (TFunction::getParamCount): (TFunction::getParam): (TSymbolTable::getGlobalLevel): (TSymbolTable::relateToOperator): (TSymbolTable::relateToExtension):
  • src/compiler/TranslatorGLSL.cpp: (writeVersion): (TranslatorGLSL::TranslatorGLSL): (TranslatorGLSL::translate):
  • src/compiler/TranslatorGLSL.h:
  • src/compiler/TranslatorHLSL.cpp: (TranslatorHLSL::TranslatorHLSL): (TranslatorHLSL::translate):
  • src/compiler/TranslatorHLSL.h:
  • src/compiler/Types.h: (TType::TType):
  • src/compiler/UnfoldSelect.cpp: (sh::UnfoldSelect::visitSelection):
  • src/compiler/UnfoldSelect.h:
  • src/compiler/ValidateLimitations.cpp: Added. (ValidateLimitations::ValidateLimitations): (ValidateLimitations::visitSymbol): (ValidateLimitations::visitConstantUnion): (ValidateLimitations::visitBinary): (ValidateLimitations::visitUnary): (ValidateLimitations::visitSelection): (ValidateLimitations::visitAggregate): (ValidateLimitations::visitLoop): (ValidateLimitations::visitBranch): (ValidateLimitations::error): (ValidateLimitations::withinLoopBody): (ValidateLimitations::isLoopIndex): (ValidateLimitations::validateLoopType): (ValidateLimitations::validateForLoopHeader): (ValidateLimitations::validateForLoopInit): (ValidateLimitations::validateForLoopCond): (ValidateLimitations::validateForLoopExpr): (ValidateLimitations::validateFunctionCall): (ValidateLimitations::validateOperation): (ValidateLimitations::isConstExpr): (ValidateLimitations::isConstIndexExpr): (ValidateLimitations::validateIndexing):
  • src/compiler/ValidateLimitations.h: Added. (ValidateLimitations::numErrors):
  • src/compiler/VariableInfo.cpp: Added. (arrayBrackets): (getVariableDataType): (getVariableInfo): (getBuiltInVariableInfo): (getUserDefinedVariableInfo): (CollectAttribsUniforms::CollectAttribsUniforms): (CollectAttribsUniforms::visitSymbol): (CollectAttribsUniforms::visitConstantUnion): (CollectAttribsUniforms::visitBinary): (CollectAttribsUniforms::visitUnary): (CollectAttribsUniforms::visitSelection): (CollectAttribsUniforms::visitAggregate): (CollectAttribsUniforms::visitLoop): (CollectAttribsUniforms::visitBranch):
  • src/compiler/VariableInfo.h: Added.
  • src/compiler/VersionGLSL.cpp: Added. (TVersionGLSL::TVersionGLSL): (TVersionGLSL::visitSymbol): (TVersionGLSL::visitConstantUnion): (TVersionGLSL::visitBinary): (TVersionGLSL::visitUnary): (TVersionGLSL::visitSelection): (TVersionGLSL::visitAggregate): (TVersionGLSL::visitLoop): (TVersionGLSL::visitBranch): (TVersionGLSL::updateVersion):
  • src/compiler/VersionGLSL.h: Added. (TVersionGLSL::getVersion):
  • src/compiler/generate_glslang_lexer.sh: Added.
  • src/compiler/generate_glslang_parser.sh: Added.
  • src/compiler/glslang.h: Added.
  • src/compiler/glslang.l:
  • src/compiler/glslang.y:
  • src/compiler/glslang_lex.cpp: Added. (yy_get_next_buffer): (yy_get_previous_state): (yy_try_NUL_trans): (input): (yyrestart): (yy_switch_to_buffer): (yy_load_buffer_state): (yy_create_buffer): (yy_delete_buffer): (yy_init_buffer): (yy_flush_buffer): (yypush_buffer_state): (yypop_buffer_state): (yyensure_buffer_stack): (yy_scan_buffer): (yy_scan_string): (yy_scan_bytes): (yy_push_state): (yy_pop_state): (yy_top_state): (yy_fatal_error): (yyget_extra): (yyget_lineno): (yyget_column): (yyget_in): (yyget_out): (yyget_leng): (yyget_text): (yyset_extra): (yyset_lineno): (yyset_column): (yyset_in): (yyset_out): (yyget_debug): (yyset_debug): (yyget_lval): (yyset_lval): (yylex_init): (yylex_init_extra): (yy_init_globals): (yylex_destroy): (yy_flex_strncpy): (yy_flex_strlen): (yyalloc): (yyrealloc): (yyfree): (string_input): (check_type): (reserved_word): (yyerror): (glslang_initialize): (glslang_finalize): (glslang_scan):
  • src/compiler/glslang_tab.cpp: Added. (yytnamerr): (yysyntax_error): (glslang_parse):
  • src/compiler/glslang_tab.h: Added.
  • src/compiler/intermOut.cpp: (TOutputTraverser::TOutputTraverser): (OutputTreeText): (TOutputTraverser::visitSymbol): (TOutputTraverser::visitBinary): (TOutputTraverser::visitUnary): (TOutputTraverser::visitAggregate): (TOutputTraverser::visitSelection): (TOutputTraverser::visitConstantUnion): (TOutputTraverser::visitLoop): (TOutputTraverser::visitBranch): (TIntermediate::outputTree):
  • src/compiler/intermediate.h: (TIntermLoop::TIntermLoop): (TIntermLoop::getType): (TIntermLoop::getInit): (TIntermLoop::getCondition): (TIntermLoop::getExpression): (TIntermLoop::getBody):
  • src/compiler/localintermediate.h:
  • src/compiler/osinclude.h: (OS_GetTLSValue):
  • src/compiler/ossource_nspr.cpp: Added. (OS_AllocTLSIndex): (OS_SetTLSValue): (OS_FreeTLSIndex):
  • src/compiler/preprocessor/compile.h:
  • src/compiler/preprocessor/cpp.c: (CPPdefine): (CPPelse): (CPPif): (CPPifdef): (CPPerror): (CPPextension): (readCPPline):
  • src/compiler/preprocessor/preprocess.h:
  • src/compiler/preprocessor/scanner.c: (str_getch): (str_ungetch): (ScanFromString): (lFloatConst): (byte_scan): (yylex_CPP): (check_EOF):
  • src/compiler/preprocessor/scanner.h:
  • src/compiler/preprocessor/tokens.c: (RecordToken): (ReadToken):
  • src/compiler/tools: Removed.
  • src/compiler/unistd.h: Removed.
  • src/compiler/util.cpp: Added. (atof_dot):
  • src/compiler/util.h: Added.
  • src/libEGL/Config.cpp: (egl::Config::set):
  • src/libEGL/Display.cpp: (egl::Display::Display): (egl::Display::initialize): (egl::Display::terminate): (egl::Display::createDevice): (egl::Display::resetDevice): (egl::Display::createContext): (egl::Display::destroyContext): (egl::Display::getMinSwapInterval): (egl::Display::getMaxSwapInterval): (egl::Display::getDevice): (egl::Display::getFloatTextureSupport): (egl::Display::getHalfFloatTextureSupport): (egl::Display::getLuminanceTextureSupport): (egl::Display::getLuminanceAlphaTextureSupport): (egl::Display::getBufferPool): (egl::Display::getEventQuerySupport): (egl::Display::getDefaultPresentParameters):
  • src/libEGL/Display.h:
  • src/libEGL/Surface.cpp: (egl::Surface::Surface): (egl::Surface::~Surface): (egl::Surface::release): (egl::Surface::resetSwapChain): (egl::Surface::writeRecordableFlipState): (egl::Surface::restoreState): (egl::SurfaceWindowProc): (egl::Surface::subclassWindow): (egl::Surface::unsubclassWindow): (egl::Surface::checkForOutOfDateSwapChain): (egl::Surface::convertInterval): (egl::Surface::swap): (egl::Surface::getRenderTarget): (egl::Surface::setSwapInterval):
  • src/libEGL/Surface.h:
  • src/libEGL/libEGL.cpp:
  • src/libGLESv2/Blit.cpp: (gl::Blit::copySurfaceToTexture): (gl::Blit::setCommonBlitState):
  • src/libGLESv2/Buffer.cpp: (gl::Buffer::Buffer): (gl::Buffer::~Buffer): (gl::Buffer::bufferData): (gl::Buffer::bufferSubData): (gl::Buffer::getVertexBuffer): (gl::Buffer::getIndexBuffer): (gl::Buffer::invalidateStaticData):
  • src/libGLESv2/Buffer.h:
  • src/libGLESv2/Context.cpp: (gl::Context::Context): (gl::Context::~Context): (gl::Context::makeCurrent): (gl::Context::markAllStateDirty): (gl::Context::setFragmentShaderDerivativeHint): (gl::Context::setEnableVertexAttribArray): (gl::Context::getVertexAttribState): (gl::Context::getVertexAttributes): (gl::Context::createFence): (gl::Context::deleteFence): (gl::Context::bindTexture2D): (gl::Context::bindTextureCubeMap): (gl::Context::getFence): (gl::Context::getTexture2D): (gl::Context::getTextureCubeMap): (gl::Context::getSamplerTexture): (gl::Context::getBooleanv): (gl::Context::getIntegerv): (gl::Context::getQueryParameterInfo): (gl::Context::applyRenderTarget): (gl::Context::applyState): (gl::Context::lookupAttributeMapping): (gl::Context::applyVertexBuffer): (gl::Context::applyIndexBuffer): (gl::Context::readPixels): (gl::Context::clear): (gl::Context::drawArrays): (gl::Context::drawElements): (gl::Context::finish): (gl::Context::drawClosingLine): (gl::Context::getMaximumVaryingVectors): (gl::Context::getMaximumFragmentUniformVectors): (gl::Context::supportsEventQueries): (gl::Context::supportsFloatTextures): (gl::Context::supportsFloatLinearFilter): (gl::Context::supportsFloatRenderableTextures): (gl::Context::supportsHalfFloatTextures): (gl::Context::supportsHalfFloatLinearFilter): (gl::Context::supportsHalfFloatRenderableTextures): (gl::Context::getMaximumRenderbufferDimension): (gl::Context::getMaximumTextureDimension): (gl::Context::getMaximumCubeTextureDimension): (gl::Context::getMaximumTextureLevel): (gl::Context::supportsLuminanceTextures): (gl::Context::supportsLuminanceAlphaTextures): (gl::Context::supports32bitIndices): (gl::Context::getIncompleteTexture): (gl::Context::setVertexAttrib): (gl::Context::initExtensionString): (gl::Context::blitFramebuffer):
  • src/libGLESv2/Context.h: (gl::VertexAttribute::VertexAttribute): (gl::VertexAttribute::typeSize): (gl::VertexAttribute::stride):
  • src/libGLESv2/Fence.cpp: Added. (gl::Fence::Fence): (gl::Fence::~Fence): (gl::Fence::isFence): (gl::Fence::setFence): (gl::Fence::testFence): (gl::Fence::finishFence): (gl::Fence::getFenceiv):
  • src/libGLESv2/Fence.h: Added.
  • src/libGLESv2/Framebuffer.cpp: (gl::Framebuffer::completeness): (gl::DefaultFramebuffer::DefaultFramebuffer): (gl::DefaultFramebuffer::completeness):
  • src/libGLESv2/Program.cpp: (gl::Program::Program): (gl::Program::getSamplerMapping): (gl::Program::getUniformLocation): (gl::Program::setUniform1iv): (gl::Program::applyUniforms): (gl::Program::packVaryings): (gl::Program::linkVaryings): (gl::Program::link): (gl::Program::defineUniform): (gl::Program::createUniform): (gl::Program::applyUniform1iv): (gl::Program::resetInfoLog): (gl::Program::unlink): (gl::Program::getActiveAttribute): (gl::Program::getActiveUniform): (gl::Program::getDxDepthRangeLocation):
  • src/libGLESv2/Program.h:
  • src/libGLESv2/RefCountObject.cpp: (gl::RefCountObject::~RefCountObject):
  • src/libGLESv2/Renderbuffer.cpp: (gl::RenderbufferStorage::RenderbufferStorage): (gl::RenderbufferStorage::isFloatingPoint): (gl::Colorbuffer::Colorbuffer): (gl::DepthStencilbuffer::DepthStencilbuffer):
  • src/libGLESv2/Renderbuffer.h:
  • src/libGLESv2/Shader.cpp: (gl::Shader::Shader): (gl::Shader::parseVaryings): (gl::Shader::compileToHLSL): (gl::VertexShader::parseAttributes):
  • src/libGLESv2/Texture.cpp: (gl::Texture::Texture): (gl::Texture::isFloatingPoint): (gl::Texture::isRenderableFormat): (gl::Texture::selectFormat): (gl::Texture::loadImageData): (gl::Texture::loadAlphaFloatImageData): (gl::Texture::loadAlphaHalfFloatImageData): (gl::Texture::loadLuminanceImageData): (gl::Texture::loadLuminanceFloatImageData): (gl::Texture::loadLuminanceHalfFloatImageData): (gl::Texture::loadLuminanceAlphaImageData): (gl::Texture::loadLuminanceAlphaFloatImageData): (gl::Texture::loadLuminanceAlphaHalfFloatImageData): (gl::Texture::loadRGBFloatImageData): (gl::Texture::loadRGBHalfFloatImageData): (gl::Texture::loadRGBAFloatImageData): (gl::Texture::loadRGBAHalfFloatImageData): (gl::Texture::createSurface): (gl::Texture::setImage): (gl::Texture::setCompressedImage): (gl::Texture::subImage): (gl::Texture::subImageCompressed): (gl::Texture::copyNonRenderable): (gl::Texture::getD3DFormat): (gl::Texture::isRenderable): (gl::Texture2D::Texture2D): (gl::Texture2D::~Texture2D): (gl::Texture2D::redefineTexture): (gl::Texture2D::setImage): (gl::Texture2D::setCompressedImage): (gl::Texture2D::copyImage): (gl::Texture2D::copySubImage): (gl::Texture2D::isComplete): (gl::Texture2D::createTexture): (gl::Texture2D::convertToRenderTarget): (gl::Texture2D::generateMipmaps): (gl::Texture2D::getColorbuffer): (gl::Texture2D::getRenderTarget): (gl::TextureCubeMap::TextureCubeMap): (gl::TextureCubeMap::~TextureCubeMap): (gl::TextureCubeMap::subImage): (gl::TextureCubeMap::subImageCompressed): (gl::TextureCubeMap::isComplete): (gl::TextureCubeMap::createTexture): (gl::TextureCubeMap::convertToRenderTarget): (gl::TextureCubeMap::redefineTexture): (gl::TextureCubeMap::copyImage): (gl::TextureCubeMap::copySubImage): (gl::TextureCubeMap::generateMipmaps): (gl::TextureCubeMap::getColorbuffer): (gl::TextureCubeMap::getRenderTarget): (gl::Texture::TextureColorbufferProxy::TextureColorbufferProxy): (gl::Texture::TextureColorbufferProxy::isFloatingPoint):
  • src/libGLESv2/Texture.h:
  • src/libGLESv2/geometry/IndexDataManager.cpp: (gl::IndexDataManager::IndexDataManager): (gl::IndexDataManager::~IndexDataManager): (gl::convertIndices): (gl::computeRange): (gl::IndexDataManager::prepareIndexData): (gl::IndexDataManager::indexSize): (gl::IndexDataManager::typeSize): (gl::IndexBuffer::IndexBuffer): (gl::IndexBuffer::~IndexBuffer): (gl::IndexBuffer::getBuffer): (gl::IndexBuffer::unmap): (gl::StreamingIndexBuffer::StreamingIndexBuffer): (gl::StreamingIndexBuffer::~StreamingIndexBuffer): (gl::StreamingIndexBuffer::map): (gl::StreamingIndexBuffer::reserveSpace): (gl::StaticIndexBuffer::StaticIndexBuffer): (gl::StaticIndexBuffer::~StaticIndexBuffer): (gl::StaticIndexBuffer::map): (gl::StaticIndexBuffer::reserveSpace): (gl::StaticIndexBuffer::lookupType): (gl::StaticIndexBuffer::lookupRange): (gl::StaticIndexBuffer::addRange):
  • src/libGLESv2/geometry/IndexDataManager.h: (gl::IndexBuffer::size):
  • src/libGLESv2/geometry/VertexDataManager.cpp: (gl::VertexDataManager::VertexDataManager): (gl::VertexDataManager::~VertexDataManager): (gl::VertexDataManager::writeAttributeData): (gl::VertexDataManager::prepareVertexData): (gl::VertexDataManager::spaceRequired): (gl::VertexDataManager::checkVertexCaps): (gl::VertexDataManager::typeIndex): (gl::VertexDataManager::setupAttributes): (gl::VertexBuffer::VertexBuffer): (gl::VertexBuffer::~VertexBuffer): (gl::VertexBuffer::unmap): (gl::VertexBuffer::getBuffer): (gl::ConstantVertexBuffer::ConstantVertexBuffer): (gl::ConstantVertexBuffer::~ConstantVertexBuffer): (gl::ArrayVertexBuffer::ArrayVertexBuffer): (gl::ArrayVertexBuffer::~ArrayVertexBuffer): (gl::ArrayVertexBuffer::addRequiredSpace): (gl::ArrayVertexBuffer::addRequiredSpaceFor): (gl::StreamingVertexBuffer::StreamingVertexBuffer): (gl::StreamingVertexBuffer::~StreamingVertexBuffer): (gl::StreamingVertexBuffer::map): (gl::StreamingVertexBuffer::reserveRequiredSpace): (gl::StaticVertexBuffer::StaticVertexBuffer): (gl::StaticVertexBuffer::~StaticVertexBuffer): (gl::StaticVertexBuffer::map): (gl::StaticVertexBuffer::reserveRequiredSpace): (gl::StaticVertexBuffer::lookupAttribute): (gl::VertexDataManager::formatConverter):
  • src/libGLESv2/geometry/VertexDataManager.h: (gl::ArrayVertexBuffer::size): (gl::VertexDataManager::dirtyCurrentValue):
  • src/libGLESv2/geometry/backend.cpp: Removed.
  • src/libGLESv2/geometry/backend.h: Removed.
  • src/libGLESv2/geometry/dx9.cpp: Removed.
  • src/libGLESv2/geometry/dx9.h: Removed.
  • src/libGLESv2/libGLESv2.cpp:
  • src/libGLESv2/libGLESv2.def:
  • src/libGLESv2/libGLESv2.vcproj:
  • src/libGLESv2/utilities.cpp: (gl::UniformComponentCount): (gl::UniformComponentType): (gl::ComputePixelSize): (gl::CheckTextureFormatType): (gl::IsColorRenderable): (gl::IsDepthRenderable): (gl::IsStencilRenderable): (es2dx::GetAlphaSize): (es2dx::GetRedSize): (es2dx::GetGreenSize): (es2dx::GetBlueSize): (es2dx::GetDepthSize): (es2dx::ConvertPrimitiveType): (dx2es::ConvertBackBufferFormat): (dx2es::ConvertDepthStencilFormat):
  • src/libGLESv2/utilities.h:
18:37 Changeset [76090] by oliver@apple.com
  • 6 edits in trunk

2011-01-18 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

[jsfunfuzz] Assertion asking activation for arguments when arguments is overridden
https://bugs.webkit.org/show_bug.cgi?id=52690

Add a few more tests.

  • fast/js/function-dot-arguments-expected.txt:
  • fast/js/script-tests/function-dot-arguments.js: (overwroteArgumentsInDynamicScope1): (overwroteArgumentsInDynamicScope2): (overwroteArgumentsInDynamicScope3):

2011-01-18 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

[jsfunfuzz] Assertion asking activation for arguments when arguments is overridden
https://bugs.webkit.org/show_bug.cgi?id=52690

Clean up code to retrieve arguments from activation and function objects.
Remove the incorrect assertion from JSActivation's argumentsGetter.

  • interpreter/Interpreter.cpp: (JSC::Interpreter::retrieveArguments):
  • runtime/JSActivation.cpp: (JSC::JSActivation::argumentsGetter):
17:46 Changeset [76089] by beidson@apple.com
  • 2 edits in trunk/Source/WebKit2

<rdar://problem/8860833> and https://bugs.webkit.org/show_bug.cgi?id=52599
UIProcess crash in WebPageProxy::reattachToWebProcess when web process crashes with a new tab/window.

Reviewed by Darin Adler.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::reattachToWebProcessWithItem): Null check item *both* places it is used.

17:44 Changeset [76088] by dimich@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

[Chromium] Not reviewed, adding pixel expectations for new test.

  • platform/chromium-mac/fast/css/background-clip-values-expected.checksum: Added.
  • platform/chromium-mac/fast/css/background-clip-values-expected.png: Added.
17:37 Changeset [76087] by beidson@apple.com
  • 10 edits in trunk/Source/WebKit2

<rdar://problem/8752200> and https://bugs.webkit.org/show_bug.cgi?id=52664
Need WebKit2 API to asynchronously get the resource data for a URL

Reviewed by Maciej Stachowiak.

Rename WKFrameGetMainResourceDataFunction to WKFrameGetResourceDataFunction, and add
new API to get a resource by URL:

  • UIProcess/API/C/WKFrame.cpp:

(WKFrameGetMainResourceData):
(WKFrameGetResourceData):
(callGetResourceDataBlockAndDispose):
(WKFrameGetMainResourceData_b):
(WKFrameGetResourceData_b):

  • UIProcess/API/C/WKFrame.h:

Implement the new API in the UIProcess side:

  • UIProcess/WebFrameProxy.cpp:

(WebKit::WebFrameProxy::getResourceData):

  • UIProcess/WebFrameProxy.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::getResourceDataFromFrame):

  • UIProcess/WebPageProxy.h:

Have the WebProcess get the data and call back to the UIProcess:

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::getResourceDataFromFrame):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
17:30 Changeset [76086] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-01-18 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Make PageClientImpl::scrollView do hardware blitting
https://bugs.webkit.org/show_bug.cgi?id=52689

  • UIProcess/API/mac/PageClientImpl.mm: (WebKit::PageClientImpl::scrollView): Clip the scroll rect and scroll the view.
  • UIProcess/DrawingAreaProxyImpl.cpp: (WebKit::DrawingAreaProxyImpl::incorporateUpdate): Scroll before painting.
17:16 Changeset [76085] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-01-18 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler.

Artifacts when scrolling with new drawing area
https://bugs.webkit.org/show_bug.cgi?id=52682

  • WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::scroll): When scrolling, we want the intersection of the scroll rect and clip rect.
17:13 Changeset [76084] by jberlin@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Add a test that calling window.open with an empty URL does not trigger an assertion or
cause a crash.
https://bugs.webkit.org/show_bug.cgi?id=52654

Reviewed by Adam Roben.

  • fast/dom/Window/open-window-empty-url-expected.txt: Added.
  • fast/dom/Window/open-window-empty-url.html: Added.
17:10 Changeset [76083] by morrita@google.com
  • 23 edits
    2 adds in trunk/Source/WebCore

2011-01-18 MORITA Hajime <morrita@google.com>

Reviewed by Simon Fraser.

Refactoring: Extract RoundedIntRect class
https://bugs.webkit.org/show_bug.cgi?id=51664

RoundedIntRect is a pair of rect and four IntSize objects which represent
corner radii of the rectangle. IntSize is grouped into RoundedIntRect::Radii.
Now RenderStyle::getRoundedBorderFor() and RenderStyle::getRoundedInnerBorderWithBorderWidths()
return RoundedIntRect and GraphicsContext::addRoundedRectClip(), GraphicsContext::fillRoundedRect()
and other functions accept RoundedIntRect as an argument.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::addRoundedRectClip): (WebCore::GraphicsContext::clipOutRoundedRect): (WebCore::GraphicsContext::fillRoundedRect):
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/RoundedIntRect.cpp: Added. (WebCore::RoundedIntRect::Radii::isZero): (WebCore::RoundedIntRect::Radii::scale): (WebCore::RoundedIntRect::Radii::expand): (WebCore::RoundedIntRect::Radii::includeLogicalEdges): (WebCore::RoundedIntRect::Radii::excludeLogicalEdges): (WebCore::RoundedIntRect::RoundedIntRect): (WebCore::RoundedIntRect::includeLogicalEdges): (WebCore::RoundedIntRect::excludeLogicalEdges):
  • platform/graphics/RoundedIntRect.h: Added. (WebCore::RoundedIntRect::Radii::Radii): (WebCore::RoundedIntRect::Radii::setTopLeft): (WebCore::RoundedIntRect::Radii::setTopRight): (WebCore::RoundedIntRect::Radii::setBottomLeft): (WebCore::RoundedIntRect::Radii::setBottomRight): (WebCore::RoundedIntRect::Radii::topLeft): (WebCore::RoundedIntRect::Radii::topRight): (WebCore::RoundedIntRect::Radii::bottomLeft): (WebCore::RoundedIntRect::Radii::bottomRight): (WebCore::RoundedIntRect::Radii::expand): (WebCore::RoundedIntRect::Radii::shrink): (WebCore::RoundedIntRect::rect): (WebCore::RoundedIntRect::radii): (WebCore::RoundedIntRect::isRounded): (WebCore::RoundedIntRect::isEmpty): (WebCore::RoundedIntRect::setRect): (WebCore::RoundedIntRect::setRadii): (WebCore::RoundedIntRect::move): (WebCore::RoundedIntRect::inflate): (WebCore::RoundedIntRect::inflateWithRadii): (WebCore::RoundedIntRect::expandRadii): (WebCore::RoundedIntRect::shrinkRadii):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::pushContentsClip):
  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintFillLayerExtended): (WebCore::RenderBoxModelObject::paintBorder): (WebCore::RenderBoxModelObject::clipBorderSidePolygon): (WebCore::RenderBoxModelObject::paintBoxShadow):
  • rendering/RenderBoxModelObject.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::drawBoxSideFromPath):
  • rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::paint):
  • rendering/RenderThemeChromiumWin.cpp: (WebCore::RenderThemeChromiumWin::paintTextFieldInternal):
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintMenuListButtonGradients): (WebCore::RenderThemeMac::paintSliderTrack):
  • rendering/RenderThemeSafari.cpp: (WebCore::RenderThemeSafari::paintMenuListButtonGradients): (WebCore::RenderThemeSafari::paintSliderTrack):
  • rendering/RenderThemeWinCE.cpp: (WebCore::RenderThemeWinCE::paintSearchFieldCancelButton):
  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::paint):
  • rendering/style/BorderData.h:
  • rendering/style/RenderStyle.cpp: (WebCore::calcRadiiFor): (WebCore::calcConstraintScaleFor): (WebCore::RenderStyle::getRoundedBorderFor): (WebCore::RenderStyle::getRoundedInnerBorderWithBorderWidths):
  • rendering/style/RenderStyle.h: (WebCore::InheritedFlags::setBorderRadius):
16:30 Changeset [76082] by ojan@chromium.org
  • 3 edits in trunk/Websites/bugs.webkit.org

2011-01-18 Ojan Vafai <ojan@chromium.org>

Reviewed by Eric Seidel.

make file expansion use the file at the svn revision the diff was created at
https://bugs.webkit.org/show_bug.cgi?id=52650

This only works for patches created with SVN for now since the git
diff does not include SVN revision numbers in it.

  • PrettyPatch/PrettyPatch.rb:
  • code-review.js:
16:15 Changeset [76081] by mihaip@chromium.org
  • 2 edits in trunk/Tools

2011-01-18 Mihai Parparita <mihaip@chromium.org>

Reviewed by Kent Tamura.

[Chromium] NRWT looking for DRT binary in the wrong path on Mac
https://bugs.webkit.org/show_bug.cgi?id=52678

Update path now that WebKit is inside Source.

  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:
16:15 Changeset [76080] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-01-18 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler.

Use a CGLayer for the backing store when possible
https://bugs.webkit.org/show_bug.cgi?id=52679

  • UIProcess/mac/BackingStoreMac.mm: (WebKit::BackingStore::paint): If there is a layer, paint it into the given context.

(WebKit::BackingStore::backingStoreContext):
If we can get the containing window graphics context, use it to create a
CGLayer that we'll use for the backing store.

(WebKit::BackingStore::scroll):
Paint the layer into itself.

  • UIProcess/mac/WebPageProxyMac.mm: (WebKit::WebPageProxy::containingWindowGraphicsContext): Call the page client.
15:49 Changeset [76079] by robert@webkit.org
  • 7 edits in trunk

2011-01-18 Robert Hogan <robert@webkit.org>

Reviewed by Simon Hausmann.

[Qt] http/tests/incremental/slow-utf8-text.pl fails
https://bugs.webkit.org/show_bug.cgi?id=44282

  • platform/qt/Skipped:

2011-01-18 Robert Hogan <robert@webkit.org>

Reviewed by Simon Hausmann.

[Qt] http/tests/incremental/slow-utf8-text.pl fails
https://bugs.webkit.org/show_bug.cgi?id=44282

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::responseMimeType):
  • WebCoreSupport/DumpRenderTreeSupportQt.h:

2011-01-18 Robert Hogan <robert@webkit.org>

Reviewed by Simon Hausmann.

[Qt] http/tests/incremental/slow-utf8-text.pl fails
https://bugs.webkit.org/show_bug.cgi?id=44282

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::dump):
15:45 Changeset [76078] by ggaren@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

2011-01-18 Geoffrey Garen <ggaren@apple.com>

Reviewed by Darin Adler.

Removed RegisterFile::markGlobals because it was obtuse, and it
unnecessarily relied on conservative marking.
https://bugs.webkit.org/show_bug.cgi?id=52668

  • interpreter/RegisterFile.h: Removed markGlobals.
  • runtime/JSActivation.cpp: (JSC::JSActivation::markChildren): Added a comment explaning why some JSActivations don't always mark their registers arrays.
  • runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::markChildren): Instead of calling markGlobals, mark the registers array directly.
15:40 Changeset [76077] by andersca@apple.com
  • 5 edits in trunk/Source/WebKit2

2011-01-18 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Pass the web page proxy to BackingStore::create
https://bugs.webkit.org/show_bug.cgi?id=52673

  • UIProcess/BackingStore.cpp: (WebKit::BackingStore::create): Add WebPageProxy parameter.


(WebKit::BackingStore::BackingStore):
Add WebPageProxy parameter.

  • UIProcess/BackingStore.h: Add WebPageProxy member variable.
  • UIProcess/DrawingAreaProxyImpl.cpp: (WebKit::DrawingAreaProxyImpl::incorporateUpdate): Pass the web page proxy when creating the backing store.
  • UIProcess/mac/BackingStoreMac.mm: (WebKit::BackingStore::backingStoreContext): Set the default blend mode.
15:31 Changeset [76076] by msaboff@apple.com
  • 5 edits in trunk

2011-01-18 Michael Saboff <msaboff@apple.com>

Reviewed by Oliver Hunt.

<rdar://problem/8875432> Regression: Some text-only e-mails cause hang beneath RegExp::match (52540)
https://bugs.webkit.org/show_bug.cgi?id=52540
https://bugs.webkit.org/show_bug.cgi?id=52662

Directly use backtrack label with parentheses nested under a
non-capturing parentheses. Also linked current parentheses
tail code object for possible parens nested within a non-capturing
parentheses.

  • yarr/YarrJIT.cpp: (JSC::Yarr::YarrGenerator::BacktrackDestination::linkBacktrackToLabel): (JSC::Yarr::YarrGenerator::generateParenthesesSingle):

2011-01-18 Michael Saboff <msaboff@apple.com>

Reviewed by Oliver Hunt.

<rdar://problem/8875432> Regression: Some text-only e-mails cause hang beneath RegExp::match (52540)
https://bugs.webkit.org/show_bug.cgi?id=52540
https://bugs.webkit.org/show_bug.cgi?id=52662

New tests to check for proper linking of parentheses nested under
a non-capturing parentheses.

  • fast/regex/parentheses-expected.txt:
  • fast/regex/script-tests/parentheses.js:
15:27 Changeset [76075] by commit-queue@webkit.org
  • 4 edits in trunk/Source

2011-01-18 Victoria Kirst <vrk@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Adding support for YV16 video frame formats.
https://bugs.webkit.org/show_bug.cgi?id=52345

  • platform/graphics/chromium/VideoLayerChromium.cpp: (WebCore::VideoLayerChromium::determineTextureFormat): (WebCore::VideoLayerChromium::draw):

2011-01-18 Victoria Kirst <vrk@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Adding support for YV16 video frame formats.
https://bugs.webkit.org/show_bug.cgi?id=52345

  • src/VideoFrameChromiumImpl.cpp: (WebKit::VideoFrameChromiumImpl::requiredTextureSize):
15:24 Changeset [76074] by hyatt@apple.com
  • 3 edits
    4 adds in trunk

<rdar://problem/8479998> REGRESSION (r67660): broken button layout at devforums.apple.com

Reviewed by Dan Bernstein.

Exclude floating objects from shrinking to avoid floats. They should never do this. Timing-related bugs could
occur as a result of this mistake, and the change to rewrite pagination to defer layout of floats until they
got encountered on the correct line exposed this issue.

Source/WebCore:

Added /fast/block/float/float-overflow-hidden-containing-block-width.html.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::shrinkToAvoidFloats):

LayoutTests:

Added /fast/block/float/float-overflow-hidden-containing-block-width.html.

  • fast/block/float/float-overflow-hidden-containing-block-width.html: Added.
  • platform/mac/fast/block/float/float-overflow-hidden-containing-block-width-expected.checksum: Added.
  • platform/mac/fast/block/float/float-overflow-hidden-containing-block-width-expected.png: Added.
  • platform/mac/fast/block/float/float-overflow-hidden-containing-block-width-expected.txt: Added.
15:21 Changeset [76073] by dpranke@chromium.org
  • 2 edits in trunk/Tools

2011-01-18 Dirk Pranke <dpranke@chromium.org>

Reviewed by Mihai Parparita.

Fix a small race condition that could cause the unit tests for
new-run-webkit-tests to fail in a multithreaded environment.
There was a small window in the code where one thread would
check to see if a thread had raised an exception, do something,
and then check to see if the thread was alive. If the other
thread raised an exception and exited in between these two
steps, the exception would be lost. Flipping the order of the
two checks fixes the race, since we will now always check for an
exception on the thread before exiting.

https://bugs.webkit.org/show_bug.cgi?id=51579

  • Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
15:08 Changeset [76072] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-01-18 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler.

Factor code to create the backing store bitmap context out into a new function
https://bugs.webkit.org/show_bug.cgi?id=52670

  • UIProcess/BackingStore.h:
  • UIProcess/mac/BackingStoreMac.mm: (WebKit::BackingStore::backingStoreContext): Create the backing store context.

(WebKit::BackingStore::incorporateUpdate):
Call backingStoreContext.

(WebKit::BackingStore::scroll):
Assert that the context is not null.

14:59 Changeset [76071] by eric@webkit.org
  • 6 edits in trunk/Tools

2011-01-18 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

commit-queue dies when test archiving fails
https://bugs.webkit.org/show_bug.cgi?id=52617

I looked at the machine and it had 10 archives already
thus find_unused_name was returning None. I've upped
the limit to 100 (per bug) and tested the case where
find_unused_name returns None (making archive return None).

  • Scripts/webkitpy/common/system/workspace.py:
  • Scripts/webkitpy/common/system/workspace_unittest.py:
  • Scripts/webkitpy/tool/bot/commitqueuetask.py:
  • Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
  • Scripts/webkitpy/tool/commands/queues.py:
14:56 Changeset [76070] by dimich@chromium.org
  • 5 edits
    2 adds in trunk/LayoutTests

[Chromium] Not reviewed, updated expectations for tests
affected by http://trac.webkit.org/changeset/76047

  • platform/chromium-mac/fast/backgrounds/size/backgroundSize22-expected.checksum:
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize22-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize22-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize22-expected.png:
  • platform/chromium-win/fast/css/background-clip-values-expected.checksum: Added.
  • platform/chromium-win/fast/css/background-clip-values-expected.png: Added.
14:55 Changeset [76069] by andersca@apple.com
  • 5 edits in trunk/Source/WebKit2

2011-01-18 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Add PageClientImpl::containingWindowGraphicsContext
https://bugs.webkit.org/show_bug.cgi?id=52666

  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm: (WebKit::PageClientImpl::containingWindowGraphicsContext):
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.h:
14:53 Changeset [76068] by dbates@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-01-18 Daniel Bates <dbates@rim.com>

Reviewed by Gavin Barraclough.

Only use moving memory model assumption in ExecutableAllocator::intializePageSize() for Symbian OS
https://bugs.webkit.org/show_bug.cgi?id=52517

Patch by David Tapuska

Currently, we compile code with respect to the Symbian-specific moving memory model
assumption for all ARMv5 or lower architectures. Instead, we should only compile
such code when building for Symbian OS on those architectures because this model
is Symbian-specific.

  • jit/ExecutableAllocator.cpp: (JSC::ExecutableAllocator::intializePageSize):
14:45 Changeset [76067] by zmo@google.com
  • 3 edits in trunk/Source/WebCore

2011-01-18 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Make CheckedInt<long> and CheckedInt<unsigned long> work
https://bugs.webkit.org/show_bug.cgi?id=52401

  • html/canvas/CheckedInt.h: (WebCore::CheckedInt::CheckedInt): Merge with the patch provided by Benoit Jacob.
  • html/canvas/WebGLBuffer.cpp: (WebCore::WebGLBuffer::associateBufferDataImpl): Use CheckedInt<long> instead of CheckedInt<int>. (WebCore::WebGLBuffer::associateBufferSubDataImpl): Ditto.
14:30 Changeset [76066] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

2011-01-18 Damian Kaleta <dkaleta@apple.com>

Reviewed by Sam Weinig.

WK2 methods WKPageScaleWebView and WKPageGetViewScaleFactor need to have consistent names
https://bugs.webkit.org/show_bug.cgi?id=52647

  • UIProcess/API/C/WKPage.cpp: (WKPageSetScaleFactor): (WKPageGetScaleFactor):
  • UIProcess/API/C/WKPage.h:
14:22 Changeset [76065] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

2011-01-18 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Ask the web page proxy to scroll the view when needed
https://bugs.webkit.org/show_bug.cgi?id=52665

  • UIProcess/DrawingAreaProxyImpl.cpp: (WebKit::DrawingAreaProxyImpl::incorporateUpdate):
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::scrollView):
  • UIProcess/WebPageProxy.h:
14:18 Changeset [76064] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix build.

  • UIProcess/win/WebView.cpp:

(WebKit::WebView::scrollView):

14:11 Changeset [76063] by kbr@google.com
  • 7 edits
    4 adds in trunk

2011-01-18 Kenneth Russell <kbr@google.com>

Reviewed by David Levin.

Must strip comments from WebGL shaders before enforcing character set
https://bugs.webkit.org/show_bug.cgi?id=52390

Strip comments from incoming shaders, preserving line numbers,
before validating that they conform to the ESSL character set.
Revert changes from http://trac.webkit.org/changeset/75735 which
allowed invalid characters to be passed to certain APIs.

Tested with WebGL layout tests, conformance test suite and several
WebGL demos in both Safari and Chromium.

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::StripComments::StripComments::process): (WebCore::WebGLRenderingContext::shaderSource):

2011-01-18 Kenneth Russell <kbr@google.com>

Reviewed by David Levin.

Must strip comments from WebGL shaders before enforcing character set
https://bugs.webkit.org/show_bug.cgi?id=52390

Incorporated non-ASCII GLSL conformance tests from Khronos
repository. Updated and synchronized invalid-passed-params.html
with Khronos repository, undoing changes from
http://trac.webkit.org/changeset/75735 .

  • fast/canvas/webgl/glsl-conformance-expected.txt:
  • fast/canvas/webgl/invalid-passed-params-expected.txt:
  • fast/canvas/webgl/invalid-passed-params.html:
  • fast/canvas/webgl/shaders/00_shaders.txt:
  • fast/canvas/webgl/shaders/misc: Added.
  • fast/canvas/webgl/shaders/misc/00_shaders.txt: Added.
  • fast/canvas/webgl/shaders/misc/non-ascii-comments.vert: Added.
  • fast/canvas/webgl/shaders/misc/non-ascii.vert: Added.
14:08 Changeset [76062] by andersca@apple.com
  • 8 edits in trunk/Source/WebKit2

2011-01-18 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Add PageClient::scrollView
https://bugs.webkit.org/show_bug.cgi?id=52663

  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm: (WebKit::PageClientImpl::scrollView):
  • UIProcess/API/qt/qwkpage.cpp: (QWKPagePrivate::scrollView):
  • UIProcess/API/qt/qwkpage_p.h:
  • UIProcess/PageClient.h:
  • UIProcess/win/WebView.cpp: (WebKit::PageClientImpl::scrollView):
  • UIProcess/win/WebView.h:
13:55 Changeset [76061] by andersca@apple.com
  • 14 edits in trunk/Source/WebKit2

Rename scrollDelta to scrollOffset everywhere.

Reviewed by Sam Weinig.

  • Shared/UpdateInfo.cpp:

(WebKit::UpdateInfo::encode):
(WebKit::UpdateInfo::decode):

  • Shared/UpdateInfo.h:
  • UIProcess/BackingStore.h:
  • UIProcess/mac/BackingStoreMac.mm:

(WebKit::BackingStore::incorporateUpdate):
(WebKit::BackingStore::scroll):

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::scroll):
(WebKit::WebChromeClient::delegatedScrollRequested):

  • WebProcess/WebCoreSupport/WebChromeClient.h:
  • WebProcess/WebPage/ChunkedUpdateDrawingArea.cpp:

(WebKit::ChunkedUpdateDrawingArea::scroll):

  • WebProcess/WebPage/ChunkedUpdateDrawingArea.h:
  • WebProcess/WebPage/DrawingArea.h:
  • WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::scroll):
(WebKit::DrawingAreaImpl::display):

  • WebProcess/WebPage/DrawingAreaImpl.h:
  • WebProcess/WebPage/LayerBackedDrawingArea.cpp:

(WebKit::LayerBackedDrawingArea::scroll):

  • WebProcess/WebPage/LayerBackedDrawingArea.h:
13:46 Changeset [76060] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-01-18 Dimitry Andric <dim@freebsd.org>

Reviewed by Andreas Kling.

Fix linking JavaScriptCore on FreeBSD/amd64
https://bugs.webkit.org/show_bug.cgi?id=52591

Linking of JavaScriptCore on FreeBSD/amd64 fails, for the same reason as
in bug 28422: cti_vm_throw needs a "@plt" suffix, otherwise the linker
complains about the relocation type.

  • jit/JITStubs.cpp: use @plt suffix on x86_64 platforms, for both Linux and FreeBSD.
13:43 Changeset [76059] by dpranke@chromium.org
  • 3 edits in trunk/Tools

2011-01-18 Dirk Pranke <dpranke@chromium.org>

Reviewed by Ojan Vafai.

Update rebaseline-chromium-webkit-tests unit tests to use a mock
filesystem. Also fix a couple of "with" statements missed by
r76050.

https://bugs.webkit.org/show_bug.cgi?id=52487

  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
13:37 Changeset [76058] by cmarrin@apple.com
  • 1 edit
    12 adds in trunk/LayoutTests

2011-01-18 Chris Marrin <cmarrin@apple.com>

Reviewed by Simon Fraser.

Add LayoutTests for new compositing layer logic
https://bugs.webkit.org/show_bug.cgi?id=52657

Add 4 tests checking that the layer tree is properly constructed with nested
layers. The first test is a simple static test of a layer with a 3D transform
with a non-layered parent. It is a pixel test and is just looking for a correct
image. The second test is similar but has a 4 deep hierarchy of <div> element where
only the innermost layer has a 3D transform. It is also a pixel test.
The other 2 tests are the same except that they add and then remove the innermost
layer's transform. It makes sure the layer tree is correct before and after
these changes.

  • compositing/geometry/layer-due-to-layer-children-deep-switch-expected.txt: Added.
  • compositing/geometry/layer-due-to-layer-children-deep-switch.html: Added.
  • compositing/geometry/layer-due-to-layer-children-deep.html: Added.
  • compositing/geometry/layer-due-to-layer-children-switch-expected.txt: Added.
  • compositing/geometry/layer-due-to-layer-children-switch.html: Added.
  • compositing/geometry/layer-due-to-layer-children.html: Added.
  • platform/mac/compositing/geometry/layer-due-to-layer-children-deep-expected.checksum: Added.
  • platform/mac/compositing/geometry/layer-due-to-layer-children-deep-expected.png: Added.
  • platform/mac/compositing/geometry/layer-due-to-layer-children-deep-expected.txt: Added.
  • platform/mac/compositing/geometry/layer-due-to-layer-children-expected.checksum: Added.
  • platform/mac/compositing/geometry/layer-due-to-layer-children-expected.png: Added.
  • platform/mac/compositing/geometry/layer-due-to-layer-children-expected.txt: Added.
13:33 Changeset [76057] by rniwa@webkit.org
  • 7 edits in trunk/Source/WebCore

2011-01-18 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Eric Seidel.

Stop instantiating legacy editing positions in DeleteSelectionCommand, IndentOudentCommand,
InsertLineBreakCommand, InsertListCOmmand.cpp, InsertParagraphSeparatorCommand, and htmlediting.cpp
https://bugs.webkit.org/show_bug.cgi?id=52644

This is a cleanup to stop instantiating legacy editing positions in the following tests.
firstDeepEditingPositionForNode and lastDeepEditingPositionForNode in htmlediting.h are not updated
because doing so requires significant code changes. They are tracked on the bug 52642.

  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::initializeStartEnd): (WebCore::updatePositionForNodeRemoval): (WebCore::DeleteSelectionCommand::removeNode): (WebCore::updatePositionForTextRemoval): (WebCore::DeleteSelectionCommand::handleGeneralDelete):
  • editing/IndentOutdentCommand.cpp: (WebCore::IndentOutdentCommand::outdentParagraph):
  • editing/InsertLineBreakCommand.cpp: (WebCore::InsertLineBreakCommand::doApply):
  • editing/InsertListCommand.cpp: (WebCore::InsertListCommand::doApplyForSingleParagraph): (WebCore::InsertListCommand::unlistifyParagraph): (WebCore::InsertListCommand::listifyParagraph):
  • editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply):
  • editing/htmlediting.cpp: (WebCore::enclosingBlock): (WebCore::enclosingList): (WebCore::enclosingListChild): (WebCore::indexForVisiblePosition): (WebCore::isNodeVisiblyContainedWithin): (WebCore::avoidIntersectionWithNode):
13:29 Changeset [76056] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2011-01-18 Mihai Parparita <mihaip@chromium.org>

Reviewed by Ojan Vafai.

[Chromium] Update Sputnik test expectations
https://bugs.webkit.org/show_bug.cgi?id=52656

Mark Sputnik tests as WONTFIX, so that they don't artificially inflate
our failing test count.

  • platform/chromium/test_expectations.txt:
13:28 Changeset [76055] by sergio@webkit.org
  • 2 edits in trunk/Tools

2011-01-18 Sergio Villar Senin <svillar@igalia.com>

Reviewed by Martin Robinson.

[Gtk] Build fixes for gtk3 build
https://bugs.webkit.org/show_bug.cgi?id=52648

  • DumpRenderTree/gtk/EventSender.cpp: (beginDragWithFilesCallback):
13:28 Changeset [76054] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-01-18 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Get and paint each individual rect in -[WKView drawRect:]
https://bugs.webkit.org/show_bug.cgi?id=52660

  • UIProcess/API/mac/WKView.mm: (-[WKView drawRect:]):
13:24 Changeset [76053] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-01-18 Benjamin Kalman <kalman@chromium.org>

Reviewed by Ryosuke Niwa.

Tweak style in visible_units.cpp and TextIterator.cpp in preparation for another patch
https://bugs.webkit.org/show_bug.cgi?id=52610

This is a purely aesthetic change.

  • editing/TextIterator.cpp: (WebCore::SimplifiedBackwardsTextIterator::advance):
  • editing/visible_units.cpp: (WebCore::previousBoundary):
13:22 Changeset [76052] by mihaip@chromium.org
  • 2 edits in trunk

2011-01-18 Mihai Parparita <mihaip@chromium.org>

Unreviewed. Update .gitignore to reflect that WebKit is now in Source.

  • .gitignore:
13:17 Changeset [76051] by dimich@chromium.org
  • 3 edits in trunk/LayoutTests

[Chromium] Not reviewed, test expectations update.
Added exclusion for new test fast/canvas/canvas-fillPath-alpha-shadow.html

  • platform/chromium-gpu/test_expectations.txt:
  • platform/chromium/test_expectations.txt:
13:10 Changeset [76050] by dpranke@chromium.org
  • 6 edits in trunk/Tools

2011-01-18 Dirk Pranke <dpranke@chromium.org>

Reviewed by Mihai Parparita.

Update rebaseline-chromium-webkit-tests to use filesystem objects
instead of direct references to os.path, shutil, tempfile, etc.

This patch doesn't change anything, but will allow subsequent
patches to change the unit tests to no longer use the real
filesystem.

This patch adds a bunch more methods to the filesystem object as
well.

https://bugs.webkit.org/show_bug.cgi?id=52482

  • Scripts/webkitpy/common/system/filesystem.py:
  • Scripts/webkitpy/common/system/filesystem_mock.py:
  • Scripts/webkitpy/tool/commands/queues.py:
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
13:09 Changeset [76049] by oliver@apple.com
  • 5 edits in trunk

2011-01-18 Oliver Hunt <oliver@apple.com>

Reviewed by Antti Koivisto.

[jsfunfuzz] Assertion in codegen for array of NaN constants
https://bugs.webkit.org/show_bug.cgi?id=52643

Add a testcase to ensure we handle a large number of NaN literals
in (0/0 is folded to NaN automatically during parsing).

  • fast/js/codegen-temporaries-expected.txt:
  • fast/js/script-tests/codegen-temporaries.js:

2011-01-18 Oliver Hunt <oliver@apple.com>

Reviewed by Antti Koivisto.

[jsfunfuzz] Assertion in codegen for array of NaN constants
https://bugs.webkit.org/show_bug.cgi?id=52643

Don't cache NaN literals in the code generator, as NaN doesn't compare
as equal to itself it causes problems when rehashing the number cache.

  • bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::emitLoad):
13:02 Changeset [76048] by commit-queue@webkit.org
  • 7 edits in trunk/Source

2011-01-18 Adam Klein <adamk@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Replace ChromiumBridge::widgetSetCursor with ChromeClient::setCursor
https://bugs.webkit.org/show_bug.cgi?id=42236

  • platform/chromium/ChromiumBridge.h:
  • platform/chromium/WidgetChromium.cpp: (WebCore::Widget::setCursor):

2011-01-18 Adam Klein <adamk@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Replace ChromiumBridge::widgetSetCursor with ChromeClient::setCursor
https://bugs.webkit.org/show_bug.cgi?id=42236

  • src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::setCursor):
  • src/ChromeClientImpl.h:
  • src/ChromiumBridge.cpp:
12:37 Changeset [76047] by commit-queue@webkit.org
  • 5 edits
    3 adds in trunk

2011-01-18 Krithigassree Sambamurthy <krithigassree.sambamurthy@nokia.com>

Reviewed by Simon Fraser.

Support background-clip: content-box
https://bugs.webkit.org/show_bug.cgi?id=48771

Addded content-box as a valid background-clip value.

  • WebCore/css/CSSParser.cpp: (WebCore::parseBackgroundClip):

2011-01-18 Krithigassree Sambamurthy <krithigassree.sambamurthy@nokia.com>

Reviewed by Simon Fraser.

Support background-clip: content-box
https://bugs.webkit.org/show_bug.cgi?id=48771

Added test cases to check the various valid background-clip values.

  • fast/css/background-clip-text-expected.txt:
  • fast/css/background-clip-values-expected.checksum: Added.
  • fast/css/background-clip-values-expected.txt: Added.
  • fast/css/background-clip-values.html: Added.
  • fast/css/script-tests/background-clip-text.js:
12:34 Changeset [76046] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-01-18 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler.

Assertion when loading two URLs in quick succession
https://bugs.webkit.org/show_bug.cgi?id=52649
<rdar://problem/8764645>

If beginLoad is called twice without didStartProvisionalLoad being called in between,
m_pendingProvisionalSandboxExtension would be non-null and an assert would fire.

  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::SandboxExtensionTracker::beginLoad): Instead of asserting that m_pendingProvisionalSandboxExtension is null, invalidate it if it is not null, since that's valid.
12:32 Changeset [76045] by dpranke@chromium.org
  • 4 edits in trunk/Tools

2011-01-18 Dirk Pranke <dpranke@chromium.org>

Reviewed by Mihai Parparita.

new-run-webkit-tests shouldn't crash when you try to run a
directory containing only skipped files.

https://bugs.webkit.org/show_bug.cgi?id=52478

  • Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
  • Scripts/webkitpy/layout_tests/port/test.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
12:27 Changeset [76044] by cfleizach@apple.com
  • 7 edits
    2 adds in trunk

REGRESSION: A problem with Voiceover and finding links
https://bugs.webkit.org/show_bug.cgi?id=52324

Reviewed by Darin Adler.

Source/WebCore:

Fallout from recent change to make WebCore return its own scroll view.

1) There were two scroll views in the hierarchy, one which no needed to be ignored.
2) Hit tests for sub frames needed to be offset.
3) The check for whether an attachment is ignored must happen earlier than using

the helpText to determine if an element should be ignored.

Test: platform/mac/accessibility/iframe-with-title-correct-hierarchy.html

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::elementAccessibilityHitTest):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):

  • accessibility/mac/AccessibilityObjectWrapper.mm:

(-[AccessibilityObjectWrapper scrollViewParent]):

Source/WebKit/mac:

  • WebView/WebDynamicScrollBarsView.mm:

(-[WebDynamicScrollBarsView accessibilityIsIgnored]):

LayoutTests:

  • platform/mac/accessibility/iframe-with-title-correct-hierarchy-expected.txt: Added.
  • platform/mac/accessibility/iframe-with-title-correct-hierarchy.html: Added.
12:09 Changeset [76043] by andersca@apple.com
  • 5 edits in trunk/Source/WebKit2

2011-01-18 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Implement NPN_PopUpContextMenu
https://bugs.webkit.org/show_bug.cgi?id=52646
<rdar://problem/8735616>

  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp: (WebKit::NPN_PopUpContextMenu): Call NetscapePlugin::popUpContextMenu.
  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp: (WebKit::NetscapePlugin::NetscapePlugin): Initialize m_currentMouseEvent.
  • WebProcess/Plugins/Netscape/NetscapePlugin.h: Add m_currentMouseEvent.
  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm: (WebKit::NetscapePlugin::popUpContextMenu): Convert the coordinates from the current mouse event to screen coordinates and call WKPopupContextMenu.

(WebKit::NetscapePlugin::platformHandleMouseEvent):
Update m_currentMouseEvent.

11:56 Changeset [76042] by andersca@apple.com
  • 4 edits in trunk/WebKitLibraries

Add WKPopupContextMenu.

Reviewed by Darin Adler.

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
11:15 Changeset [76041] by aroben@apple.com
  • 2 edits in trunk/Source/WebCore

Call alternate CFHTTPCookie functions if available

Fixes <http://webkit.org/b/52637> <rdar://problem/8878984>.

Reviewed by Darin Adler.

  • platform/network/cf/CookieJarCFNet.cpp: Added soft-linking macros to

pull in the alternate CFHTTPCookie functions.

(WebCore::cookieDomain):
(WebCore::cookieExpirationTime):
(WebCore::cookieName):
(WebCore::cookiePath):
(WebCore::cookieValue):
Added these wrappers around the CFHTTPCookie functions. We call the
alternate functions if they exist, otherwise fall back to the current
functions.

(WebCore::filterCookies):
(WebCore::getRawCookies):
(WebCore::deleteCookie):
Changed to use the wrapper functions.

11:06 Changeset [76040] by jberlin@webkit.org
  • 2 edits in trunk/Source/WebKit2

WebKit2: Do not assert that the provisional and committed URLs cannot be empty/null
https://bugs.webkit.org/show_bug.cgi?id=52641

Reviewed by Darin Adler.

  • UIProcess/WebFrameProxy.cpp:

(WebKit::WebFrameProxy::didStartProvisionalLoad):
(WebKit::WebFrameProxy::didCommitLoad):
(WebKit::WebFrameProxy::didFinishLoad):

11:06 Changeset [76039] by mrobinson@webkit.org
  • 4 edits in trunk

2011-01-18 Martin Robinson <mrobinson@igalia.com>

Reviewed by Eric Seidel.

[GTK] Filenames are converted to URLs during edit drags
https://bugs.webkit.org/show_bug.cgi?id=52096

  • platform/gtk/Skipped: Unskip passing test. Fix a misspelled drag and drop test on the list as well.

2011-01-18 Martin Robinson <mrobinson@igalia.com>

Reviewed by Eric Seidel.

[GTK] Filenames are converted to URLs during edit drags
https://bugs.webkit.org/show_bug.cgi?id=52096

  • platform/gtk/DragDataGtk.cpp: Only advertise and deliver filenames as URLs if the conversion policy allows it. (WebCore::DragData::containsURL): Ditto. (WebCore::DragData::asURL): Ditto.
10:53 Changeset [76038] by jorlow@chromium.org
  • 1 edit
    6 adds in trunk/LayoutTests

2011-01-18 Jeremy Orlow <jorlow@chromium.org>

[Chromium] Create baselines for svg/css/text-gradient-shadow.svg
https://bugs.webkit.org/show_bug.cgi?id=52640

  • platform/chromium-linux/svg/css/text-gradient-shadow-expected.checksum: Added.
  • platform/chromium-linux/svg/css/text-gradient-shadow-expected.png: Added.
  • platform/chromium-mac/svg/css/text-gradient-shadow-expected.checksum: Added.
  • platform/chromium-win/svg/css/text-gradient-shadow-expected.checksum: Added.
  • platform/chromium-win/svg/css/text-gradient-shadow-expected.png: Added.
  • platform/chromium-win/svg/css/text-gradient-shadow-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
10:49 Changeset [76037] by mrobinson@webkit.org
  • 2 edits in trunk/LayoutTests

2011-01-18 Martin Robinson <mrobinson@igalia.com>

Skip two tests which were incorrectly passing before GTK+
had support for beginDragWithFiles.

  • platform/gtk/Skipped: Skip failing tests.
10:24 Changeset [76036] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-01-18 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

ASSERT in plug-in code when going to youtube
https://bugs.webkit.org/show_bug.cgi?id=52638

  • PluginProcess/PluginControllerProxy.cpp: (WebKit::PluginControllerProxy::paintEntirePlugin): Don't try to paint the plug-in if the plug-in frame is empty.
10:15 Changeset [76035] by jknotten@chromium.org
  • 2 edits in trunk/LayoutTests

2011-01-18 John Knottenbelt <jknotten@chromium.org>

Reviewed by Jeremy Orlow.

[Chromium] Adjust test expectations fast/files/revoke-blob-url.html is flaky on linux.
https://bugs.webkit.org/show_bug.cgi?id=52633

Combine test expectations for the test into one line.

  • platform/chromium/test_expectations.txt:
10:11 Changeset [76034] by andersca@apple.com
  • 13 edits in trunk/Source/WebKit2

2011-01-18 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Plug-in hosting WebProcess instances appear in Activity Monitor as WebProcess
https://bugs.webkit.org/show_bug.cgi?id=52635
<rdar://problem/8731337>

  • PluginProcess/PluginProcess.cpp: (WebKit::PluginProcess::initialize): Call platformInitialize.
  • PluginProcess/PluginProcess.h: Add platformInitialize.
  • PluginProcess/mac/PluginProcessMac.mm: (WebKit::PluginProcess::platformInitialize): Set the compositing render server port and the visible application name.
  • Shared/Plugins/PluginProcessCreationParameters.cpp: (WebKit::PluginProcessCreationParameters::encode): (WebKit::PluginProcessCreationParameters::decode): Encode/decode the parent process name.
  • Shared/Plugins/PluginProcessCreationParameters.h: Add parentProcessName.
  • Shared/WebProcessCreationParameters.cpp: (WebKit::WebProcessCreationParameters::encode): (WebKit::WebProcessCreationParameters::decode): Encode/decode the parent process name.
  • Shared/WebProcessCreationParameters.h: Add parentProcessName.
  • UIProcess/Launcher/mac/ProcessLauncherMac.mm: (WebKit::ProcessLauncher::launchProcess): Don't pass the parent process name here.
  • UIProcess/Plugins/mac/PluginProcessProxyMac.mm: (WebKit::PluginProcessProxy::platformInitializePluginProcess): Set the visible name.
  • UIProcess/mac/WebContextMac.mm: (WebKit::WebContext::platformInitializeWebProcess): Pass along the parent process name.
  • WebProcess/mac/WebProcessMac.mm: (WebKit::WebProcess::platformInitializeWebProcess): Set the visible name.
  • WebProcess/mac/WebProcessMainMac.mm: (WebKit::WebProcessMain): Don't set the visible name here. It's done in platformInitializeWebProcess.
10:10 Changeset [76033] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

2011-01-18 Helder Correia <helder@sencha.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Incorrect shadow alpha with semi-transparent solid fillStyle
https://bugs.webkit.org/show_bug.cgi?id=52611

This is related to bug 52559. The shadow color alpha must be multiplied
by the context brush alpha.

New test to ensure correct behavior of canvas with fillPath using a
semi-transparent fillStyle color and a shadow.

  • fast/canvas/canvas-fillPath-alpha-shadow-expected.txt: Added.
  • fast/canvas/canvas-fillPath-alpha-shadow.html: Added.
  • fast/canvas/script-tests/canvas-fillPath-alpha-shadow.js: Added.

2011-01-18 Helder Correia <helder@sencha.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Incorrect shadow alpha with semi-transparent solid fillStyle
https://bugs.webkit.org/show_bug.cgi?id=52611

This is related to bug 52559. The shadow color alpha must be multiplied
by the context brush alpha.

Test: fast/canvas/canvas-fillPath-alpha-shadow.html

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::fillPath):
09:56 Changeset [76032] by jknotten@chromium.org
  • 2 edits in trunk/LayoutTests

2011-01-18 John Knottenbelt <jknotten@chromium.org>

Unreviewed; updated chromium test expectations.

[Chromium] Adjust test expectations fast/files/revoke-blob-url.html is flaky on linux.
https://bugs.webkit.org/show_bug.cgi?id=52633

  • platform/chromium/test_expectations.txt:
09:47 Changeset [76031] by mrobinson@webkit.org
  • 4 edits
    4 adds in trunk

2011-01-18 Adam Bergkvist <adam.bergkvist@ericsson.com> and Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] The GTK+ EventSender needs support for beginDragWithFiles
https://bugs.webkit.org/show_bug.cgi?id=40833

Unskip passing tests, add in a GTK+-specific result and one more result
which is necessary because GTK+ tests run in Xvfb.

  • platform/gtk/Skipped: Unskip tests that are now passing and organize the remaining skipped tests.
  • platform/gtk/fast/forms/input-file-re-render-expected.txt: Added.
  • platform/gtk/http/tests/security/clipboard/clipboard-file-access-expected.txt: Added.

2011-01-18 Adam Bergkvist <adam.bergkvist@ericsson.com> and Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] The GTK+ EventSender needs support for beginDragWithFiles
https://bugs.webkit.org/show_bug.cgi?id=40833

  • DumpRenderTree/gtk/EventSender.cpp: Add a beginDragWithFiles implementation for the GTK+ event sender. (dragWithFilesDragDataGetCallback): Added. (dragWithFilesDragEndCallback): Added. (beginDragWithFilesCallback): Added.
09:40 Changeset [76030] by caseq@chromium.org
  • 7 edits in trunk

2011-01-18 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: fail resource.requestContent() immediately for WebSocket resources
Remove webInspector.resources.Types from test expectations.
https://bugs.webkit.org/show_bug.cgi?id=52628

  • inspector/extensions-api-expected.txt:

2011-01-18 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: fail resource.requestContent() immediately for WebSocket resources
https://bugs.webkit.org/show_bug.cgi?id=52628

  • English.lproj/localizedStrings.js: Rename WebSocket -> WebSockets in resource catetegories (rest are in plural, too)
  • inspector/front-end/ExtensionServer.js: Do not expose webInspector.resources.Types in extensions API (obsolete) (WebInspector.ExtensionServer.prototype._buildExtensionAPIInjectedScript):
  • inspector/front-end/Resource.js: (WebInspector.Resource.Type.toUIString): Remove ResourceType.Media as it's not used. (WebInspector.Resource.Type.toString): ditto. (WebInspector.Resource.prototype.requestContent): Fail immediately for WebSocket resources.
  • inspector/front-end/inspector.js: Rename WebSocket -> WebSockets in resource catetegories (rest are in plural, too)
09:19 Changeset [76029] by commit-queue@webkit.org
  • 3 edits
    4 adds in trunk

2011-01-18 Helder Correia <helder@sencha.com>

Reviewed by Dirk Schulze.

REGRESSION(75139): SVG gradients are not applied to texts
https://bugs.webkit.org/show_bug.cgi?id=52531

r75139 caused a problem with filling and stroking text with a gradient
fill in SVG. The order of CGContextConcatCTM and CGContextClipToRect
was mixed up.

  • platform/mac/svg/css/text-gradient-shadow-expected.checksum: Added.
  • platform/mac/svg/css/text-gradient-shadow-expected.png: Added.
  • platform/mac/svg/css/text-gradient-shadow-expected.txt: Added.
  • svg/css/text-gradient-shadow.svg: Added.

2011-01-18 Helder Correia <helder@sencha.com>

Reviewed by Dirk Schulze.

REGRESSION(75139): SVG gradients are not applied to texts
https://bugs.webkit.org/show_bug.cgi?id=52531

r75139 caused a problem with filling and stroking text with a gradient
fill in SVG. The order of CGContextConcatCTM and CGContextClipToRect
was mixed up.

Test: svg/css/text-gradient-shadow.svg

  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::fillRect):
09:07 Changeset [76028] by jknotten@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-01-18 John Knottenbelt <jknotten@chromium.org>

Reviewed by Jeremy Orlow.

Add pixel test baseline for svg/custom/use-inherit-style.svg
https://bugs.webkit.org/show_bug.cgi?id=52630

  • svg/custom/use-inherit-style-expected.checksum: Added.
  • svg/custom/use-inherit-style-expected.png: Added.
07:56 Changeset [76027] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

2011-01-18 Leo Yang <leo.yang@torchmobile.com.cn>

Reviewed by Nikolas Zimmermann.

Unable to indirectly animate visibility of SVGUseElement
https://bugs.webkit.org/show_bug.cgi?id=50240

Test case to verify if SVGUseElement inherits parent's
style change.

  • svg/custom/use-inherit-style-expected.txt: Added.
  • svg/custom/use-inherit-style.svg: Added.

2011-01-18 Leo Yang <leo.yang@torchmobile.com.cn>

Reviewed by Nikolas Zimmermann.

Unable to indirectly animate visibility of SVGUseElement
https://bugs.webkit.org/show_bug.cgi?id=50240

SVGUseElement::recalcStyle should take care of its shadow
tree's style recalculation when it is called with change >= Inherit
or when childNeedsStyleRecalc() is true because in these two
cases needStyleRecalc() may not be true.

Test: svg/custom/use-inherit-style.svg

  • svg/SVGUseElement.cpp: (WebCore::SVGUseElement::recalcStyle):
07:34 Changeset [76026] by podivilov@chromium.org
  • 5 edits in trunk/Source/WebCore

2011-01-18 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: provide script length to frontend.
https://bugs.webkit.org/show_bug.cgi?id=52620

  • inspector/Inspector.idl:
  • inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::didParseSource):
  • inspector/front-end/DebuggerModel.js: (WebInspector.DebuggerModel.prototype._parsedScriptSource): (WebInspector.DebuggerDispatcher.prototype.parsedScriptSource):
  • inspector/front-end/Script.js: (WebInspector.Script):
07:30 Changeset [76025] by podivilov@chromium.org
  • 1 edit
    1 delete in trunk/LayoutTests

2011-01-18 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, remove wrong chromium expectation for console-xhr-logging test.

  • platform/chromium/http/tests/inspector/console-xhr-logging-expected.txt: Removed.
06:49 BuildingCairoOnWindows edited by d.nusman@re-lion.com
(diff)
06:48 Changeset [76024] by zherczeg@webkit.org
  • 1 edit in trunk/Source/WebCore/ChangeLog

Fixing ChangeLog

Rubber-stamped by Csaba Osztrogonác

Removing a line introduced by
http://trac.webkit.org/changeset/75743/trunk/Source/WebCore/ChangeLog
Removing an unnecessary space before a time stamp.

06:34 Changeset [76023] by podivilov@chromium.org
  • 3 edits in trunk/LayoutTests

2011-01-18 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, test fix for r76019.

  • http/tests/inspector-enabled/console-log-before-frame-navigation-expected.txt:
  • http/tests/inspector-enabled/console-log-before-frame-navigation.html:
06:25 Changeset [76022] by caseq@chromium.org
  • 7 edits in trunk/Source/WebCore

2011-01-17 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [refactoring] use events to notify NetworkManager clients
https://bugs.webkit.org/show_bug.cgi?id=52588

  • inspector/front-end/AuditLauncherView.js: (WebInspector.AuditLauncherView): Do not expose public interface to resource count. Do not reset resource count upon reset(). (WebInspector.AuditLauncherView.prototype._resetResourceCount): (WebInspector.AuditLauncherView.prototype._onResourceStarted): (WebInspector.AuditLauncherView.prototype._onResourceFinished):
  • inspector/front-end/AuditsPanel.js: Do not expose public interface to resource start/finish events.
  • inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer): (WebInspector.ExtensionServer.prototype._notifyResourceFinished): (WebInspector.ExtensionServer.prototype.initExtensions):
  • inspector/front-end/NetworkManager.js: Dispatch events rather than directly call clients. (WebInspector.NetworkManager): (WebInspector.NetworkManager.prototype.willSendRequest): (WebInspector.NetworkManager.prototype.markResourceAsCached): (WebInspector.NetworkManager.prototype.didReceiveResponse): (WebInspector.NetworkManager.prototype.didReceiveContentLength): (WebInspector.NetworkManager.prototype.setInitialContent): (WebInspector.NetworkManager.prototype.didCommitLoadForFrame): (WebInspector.NetworkManager.prototype.willSendWebSocketHandshakeRequest): (WebInspector.NetworkManager.prototype.didReceiveWebSocketHandshakeResponse): (WebInspector.NetworkManager.prototype._startResource): (WebInspector.NetworkManager.prototype._finishResource):
  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel): (WebInspector.NetworkPanel.prototype._onResourceStarted): (WebInspector.NetworkPanel.prototype._appendResource): (WebInspector.NetworkPanel.prototype._onResourceUpdated): (WebInspector.NetworkPanel.prototype._refreshResource): (WebInspector.NetworkPanel.prototype._onMainResourceChanged):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel): (WebInspector.ResourcesPanel.prototype._refreshResource):
06:20 Changeset [76021] by pfeldman@chromium.org
  • 8 edits in trunk

2011-01-18 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: preserve pause on exception state in settings.
https://bugs.webkit.org/show_bug.cgi?id=52619

  • inspector/InspectorController.cpp: (WebCore::InspectorController::getInspectorState):
  • inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::setPauseOnExceptionsState):
  • inspector/InspectorDebuggerAgent.h:
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype.debuggerWasEnabled): (WebInspector.ScriptsPanel.prototype._updatePauseOnExceptionsState): (WebInspector.ScriptsPanel.prototype._togglePauseOnExceptions): (WebInspector.ScriptsPanel.prototype._setPauseOnExceptions):
  • inspector/front-end/Settings.js: (WebInspector.Settings):
  • inspector/front-end/inspector.js: (WebInspector.doLoadedDone.populateInspectorState):
06:09 Changeset [76020] by podivilov@chromium.org
  • 5 edits in trunk/LayoutTests

2011-01-18 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: fix flaky debugger tests.
https://bugs.webkit.org/show_bug.cgi?id=51320

  • http/tests/inspector/debugger-test2.js: (initialize_DebuggerTest.InspectorTest.setBreakpoint): (initialize_DebuggerTest.InspectorTest.showScriptSource): (initialize_DebuggerTest.InspectorTest._showScriptSource):
  • inspector/debugger-pause-on-breakpoint-expected.txt:
  • inspector/debugger-pause-on-breakpoint.html:
05:54 Changeset [76019] by podivilov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-01-18 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [REGRESSION] JavaScript exceptions aren't shown in source frame.
https://bugs.webkit.org/show_bug.cgi?id=52623

  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleMessage): (WebInspector.ConsoleMessage.prototype._formatMessage):
05:42 Changeset [76018] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-01-18 Pavel Feldman <pfeldman@chromium.org>

Revert r76017. No need to guard InspectorInstrumentation
in WebCore.
  • page/Page.cpp: (WebCore::networkStateChanged):
04:44 Changeset [76017] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-01-18 Konstantin Tokarev <annulen@yandex.ru>

Reviewed by Kent Tamura.

Fixed compilation when Inspector is disabled
https://bugs.webkit.org/show_bug.cgi?id=52564

  • page/Page.cpp: (WebCore::networkStateChanged): Added ENABLE(INSPECTOR) guard
04:26 Changeset [76016] by morrita@google.com
  • 23 edits
    2 deletes in trunk/Source/WebCore

2011-01-18 MORITA Hajime <morrita@google.com>

Unreviewed, rolling out r76004, r76005, r76007, and r76011.
http://trac.webkit.org/changeset/76004
http://trac.webkit.org/changeset/76005
http://trac.webkit.org/changeset/76007
http://trac.webkit.org/changeset/76011
https://bugs.webkit.org/show_bug.cgi?id=51664

The r76004 broke pixel tests.
(The failure was missed due to the tolerance.)

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::addRoundedRectClip): (WebCore::GraphicsContext::clipOutRoundedRect):
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/RoundedIntRect.cpp: Removed.
  • platform/graphics/RoundedIntRect.h: Removed.
  • rendering/RenderBox.cpp: (WebCore::RenderBox::pushContentsClip):
  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintFillLayerExtended): (WebCore::RenderBoxModelObject::paintBorder): (WebCore::RenderBoxModelObject::clipBorderSidePolygon): (WebCore::uniformlyExpandBorderRadii): (WebCore::RenderBoxModelObject::paintBoxShadow):
  • rendering/RenderBoxModelObject.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::drawBoxSideFromPath):
  • rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::paint):
  • rendering/RenderThemeChromiumWin.cpp: (WebCore::RenderThemeChromiumWin::paintTextFieldInternal):
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintMenuListButtonGradients): (WebCore::RenderThemeMac::paintSliderTrack):
  • rendering/RenderThemeSafari.cpp: (WebCore::RenderThemeSafari::paintMenuListButtonGradients): (WebCore::RenderThemeSafari::paintSliderTrack):
  • rendering/RenderThemeWinCE.cpp: (WebCore::RenderThemeWinCE::paintSearchFieldCancelButton):
  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::paint):
  • rendering/style/BorderData.h:
  • rendering/style/RenderStyle.cpp: (WebCore::constrainCornerRadiiForRect): (WebCore::RenderStyle::getBorderRadiiForRect): (WebCore::RenderStyle::getInnerBorderRadiiForRectWithBorderWidths):
  • rendering/style/RenderStyle.h:
04:19 Changeset [76015] by hayato@chromium.org
  • 2 edits in trunk

2011-01-18 Hayato Ito <hayato@chromium.org>

Reviewed by Kent Tamura.

Update .gitignore file to reflect a recent WebKit directory movement.

https://bugs.webkit.org/show_bug.cgi?id=52618

  • .gitignore:
04:16 Changeset [76014] by kbalazs@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt][WK2] Not implemented warnings should not break layout tests
https://bugs.webkit.org/show_bug.cgi?id=52616

Reviewed by Csaba Osztrogonác.

  • WebKit2Prefix.h: Define DISABLE_NOT_IMPLEMENTED_WARNINGS on Qt.
03:04 Changeset [76013] by podivilov@chromium.org
  • 10 edits in trunk/Source/WebCore

2011-01-17 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: add source column field to debugger call frames.
https://bugs.webkit.org/show_bug.cgi?id=52443

  • bindings/js/JavaScriptCallFrame.cpp: (WebCore::JavaScriptCallFrame::JavaScriptCallFrame):
  • bindings/js/JavaScriptCallFrame.h: (WebCore::JavaScriptCallFrame::create): (WebCore::JavaScriptCallFrame::line): (WebCore::JavaScriptCallFrame::column): (WebCore::JavaScriptCallFrame::update):
  • bindings/js/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::createCallFrameAndPauseIfNeeded): (WebCore::ScriptDebugServer::updateCallFrameAndPauseIfNeeded): (WebCore::ScriptDebugServer::callEvent): (WebCore::ScriptDebugServer::atStatement): (WebCore::ScriptDebugServer::returnEvent): (WebCore::ScriptDebugServer::exception): (WebCore::ScriptDebugServer::willExecuteProgram): (WebCore::ScriptDebugServer::didExecuteProgram): (WebCore::ScriptDebugServer::didReachBreakpoint):
  • bindings/js/ScriptDebugServer.h:
  • bindings/v8/DebuggerScript.js: ():
  • bindings/v8/JavaScriptCallFrame.cpp: (WebCore::JavaScriptCallFrame::column):
  • bindings/v8/JavaScriptCallFrame.h:
  • inspector/InjectedScriptSource.js: ():
  • inspector/JavaScriptCallFrame.idl:

2011-01-18 Antti Koivisto <antti@apple.com>

Reviewed by Dave Hyatt.

https://bugs.webkit.org/show_bug.cgi?id=52370
<rdar://problem/8856808>
Style sharing optimization no longer works on major web sites

The code in CSSStyleSelector::locateSharedStyle() that tries to share style information between element has been defeated
by widespread use of certain CSS selectors (:first-child pseudo class and similar). The current implementation disables
the sharing optimization for the whole page if one of these constructs is seen in any style sheet used by the page.

This patch gets the style sharing back to 25-40% range on most web sites.

  • css/CSSMutableStyleDeclaration.h: (WebCore::CSSMutableStyleDeclaration::propertiesEqual):

Needed to improve equality checking in NamedNodeMap::mappedMapsEquivalent.

  • css/CSSSelector.h: (WebCore::CSSSelector::isSiblingSelector):

Test for selectors that are affected by the sibling elements.

  • css/CSSStyleSelector.cpp: (WebCore::elementCanUseSimpleDefaultStyle): (WebCore::collectSiblingRulesInDefaultStyle): (WebCore::assertNoSiblingRulesInDefaultStyle):

Extract sibling rules from the MathML default stylesheet.
Assert that no other default stylesheet has them.

(WebCore::CSSStyleSelector::CSSStyleSelector):
(WebCore::CSSStyleSelector::locateCousinList):
(WebCore::CSSStyleSelector::matchesSiblingRules):
(WebCore::CSSStyleSelector::canShareStyleWithElement):
(WebCore::CSSStyleSelector::locateSharedStyle):
(WebCore::CSSStyleSelector::styleForElement):
(WebCore::collectIdsAndSiblingRulesFromList):
(WebCore::CSSRuleSet::collectIdsAndSiblingRules):

Track sibling rules and ids used in the stylesheets to allow much more fine-grained rejection of cases
where style sharing can't be used.

  • css/CSSStyleSelector.h:
  • dom/NamedNodeMap.cpp: (WebCore::NamedNodeMap::mappedMapsEquivalent):

Check also for CSSValue mutation from DOM.

  • mathml/MathMLMathElement.cpp: (WebCore::MathMLMathElement::insertedIntoDocument):
  • mathml/MathMLMathElement.h:

MathML default style sheet has sibling rules which don't get noticed by the normal document
stylesheet parsing.

  • rendering/style/RenderStyle.h: (WebCore::InheritedFlags::setFirstChildState): (WebCore::InheritedFlags::setLastChildState): (WebCore::InheritedFlags::setChildIndex):

These all make style non-shareable (unique).

02:48 Changeset [76012] by antti@apple.com
  • 12 edits in trunk

Source/WebCore: 2011-01-18 Antti Koivisto <antti@apple.com>

Reviewed by Dave Hyatt.

https://bugs.webkit.org/show_bug.cgi?id=52370
<rdar://problem/8856808>
Style sharing optimization no longer works on major web sites

The code in CSSStyleSelector::locateSharedStyle() that tries to share style information between element has been defeated
by widespread use of certain CSS selectors (:first-child pseudo class and similar). The current implementation disables
the sharing optimization for the whole page if one of these constructs is seen in any style sheet used by the page.

This patch gets the style sharing back to 25-40% range on most web sites.

  • css/CSSMutableStyleDeclaration.h:

(WebCore::CSSMutableStyleDeclaration::propertiesEqual):

Needed to improve equality checking in NamedNodeMap::mappedMapsEquivalent.


  • css/CSSSelector.h:

(WebCore::CSSSelector::isSiblingSelector):

Test for selectors that are affected by the sibling elements.


  • css/CSSStyleSelector.cpp:

(WebCore::elementCanUseSimpleDefaultStyle):
(WebCore::collectSiblingRulesInDefaultStyle):
(WebCore::assertNoSiblingRulesInDefaultStyle):

Extract sibling rules from the MathML default stylesheet.
Assert that no other default stylesheet has them.


(WebCore::CSSStyleSelector::CSSStyleSelector):
(WebCore::CSSStyleSelector::locateCousinList):
(WebCore::CSSStyleSelector::matchesSiblingRules):
(WebCore::CSSStyleSelector::canShareStyleWithElement):
(WebCore::CSSStyleSelector::locateSharedStyle):
(WebCore::CSSStyleSelector::styleForElement):
(WebCore::collectIdsAndSiblingRulesFromList):
(WebCore::CSSRuleSet::collectIdsAndSiblingRules):

Track sibling rules and ids used in the stylesheets to allow much more fine-grained rejection of cases
where style sharing can't be used.

  • css/CSSStyleSelector.h:
  • dom/NamedNodeMap.cpp:

(WebCore::NamedNodeMap::mappedMapsEquivalent):

Check also for CSSValue mutation from DOM.


  • mathml/MathMLMathElement.cpp:

(WebCore::MathMLMathElement::insertedIntoDocument):

  • mathml/MathMLMathElement.h:


MathML default style sheet has sibling rules which don't get noticed by the normal document
stylesheet parsing.


  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::setFirstChildState):
(WebCore::InheritedFlags::setLastChildState):
(WebCore::InheritedFlags::setChildIndex):

These all make style non-shareable (unique).

LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=52370
Style sharing optimization no longer works on major web sites

Reviewed by Dave Hyatt.

These are progressions (with no noticable visual change).
MathML code was improperly sharing style.

  • platform/mac/mathml/presentation/fractions-vertical-alignment-expected.txt:
  • platform/mac/mathml/presentation/subsup-expected.txt:
02:37 Changeset [76011] by morrita@google.com
  • 2 edits in trunk/Source/WebCore

2011-01-18 MORITA Hajime <morrita@google.com>

Unreviewed crash fix on release builds.

  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintFillLayerExtended):
02:20 Changeset [76010] by podivilov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-01-18 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, update localizedStrings.js.

  • English.lproj/localizedStrings.js:
02:15 Changeset [76009] by podivilov@chromium.org
  • 7 edits
    1 add in trunk/Source/WebCore

2011-01-11 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: implement script beautifier prototype.
https://bugs.webkit.org/show_bug.cgi?id=51588

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/ScriptFormatter.js: Added. (WebInspector.ScriptFormatter): Implements JavaScript source beautification and conversion between original and formatted line numbers (WebInspector.ScriptFormatter.findLineEndings): (WebInspector.ScriptFormatter.locationToPosition): (WebInspector.ScriptFormatter.positionToLocation): (WebInspector.ScriptFormatter.upperBound): (WebInspector.ScriptFormatter.prototype.format): (WebInspector.ScriptFormatter.prototype.originalLineNumberToFormattedLineNumber): (WebInspector.ScriptFormatter.prototype.formattedLineNumberToOriginalLineNumber): (WebInspector.ScriptFormatter.prototype.originalPositionToFormattedLineNumber): (WebInspector.ScriptFormatter.prototype.formattedLineNumberToOriginalPosition): (WebInspector.ScriptFormatter.prototype._convertPosition):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype._clearCurrentExecutionLine): (WebInspector.ScriptsPanel.prototype._callFrameSelected): (WebInspector.ScriptsPanel.prototype._formatScript):
  • inspector/front-end/SourceFrame.js: Convert original line numbers to UI line numbers and vice versa
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
02:02 Changeset [76008] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Tools

2011-01-18 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Adam Barth.

ews: Add additional watcher to efl ews
https://bugs.webkit.org/show_bug.cgi?id=52613

Add gyuyoung.kim@samsung.com to watcher list of efl-ews.

  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:
01:32 Changeset [76007] by philn@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-01-18 Philippe Normand <pnormand@igalia.com>

Unreviewed, GTK build fix as follow-up of r76004.

  • GNUmakefile.am: Include RoundedIntRect files in the build
01:24 Changeset [76006] by philn@webkit.org
  • 3 edits
    12 deletes in trunk

2011-01-18 Philippe Normand <pnormand@igalia.com>

Unreviewed, rolling out r76002.
http://trac.webkit.org/changeset/76002
https://bugs.webkit.org/show_bug.cgi?id=49790

breaks a bunch of fast/forms tests on mac and GTK

  • fast/forms/select-option-background-color-change.html: Removed.
  • fast/forms/select-option-color-change.html: Removed.
  • fast/forms/select-option-visibility-change.html: Removed.
  • platform/mac/fast/forms/select-option-background-color-change-expected.checksum: Removed.
  • platform/mac/fast/forms/select-option-background-color-change-expected.png: Removed.
  • platform/mac/fast/forms/select-option-background-color-change-expected.txt: Removed.
  • platform/mac/fast/forms/select-option-color-change-expected.checksum: Removed.
  • platform/mac/fast/forms/select-option-color-change-expected.png: Removed.
  • platform/mac/fast/forms/select-option-color-change-expected.txt: Removed.
  • platform/mac/fast/forms/select-option-visibility-change-expected.checksum: Removed.
  • platform/mac/fast/forms/select-option-visibility-change-expected.png: Removed.
  • platform/mac/fast/forms/select-option-visibility-change-expected.txt: Removed.

2011-01-18 Philippe Normand <pnormand@igalia.com>

Unreviewed, rolling out r76002.
http://trac.webkit.org/changeset/76002
https://bugs.webkit.org/show_bug.cgi?id=49790

breaks a bunch of fast/forms tests on mac and GTK

  • html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::setRenderStyle):
01:13 Changeset [76005] by morrita@google.com
  • 2 edits in trunk/Source/WebCore

2011-01-18 MORITA Hajime <morrita@google.com>

Unreviewed windows build fix.

  • WebCore.vcproj/WebCore.vcproj:
00:59 Changeset [76004] by morrita@google.com
  • 21 edits
    2 adds in trunk/Source/WebCore

2011-01-17 MORITA Hajime <morrita@google.com>

Reviewed by Simon Fraser.

Refactoring: Extract RoundedIntRect class
https://bugs.webkit.org/show_bug.cgi?id=51664

RoundedIntRect is a pair of rect and four IntSize objects which represent
corner radii of the rectangle. IntSize is grouped into RoundedIntRect::Radii.
Now RenderStyle::getRoundedBorderFor() and RenderStyle::getRoundedInnerBorderWithBorderWidths()
return RoundedIntRect and GraphicsContext::addRoundedRectClip(), GraphicsContext::fillRoundedRect()
and other functions accept RoundedIntRect as an argument.

No new tests. No behavioral change.

  • Android.mk:
  • CMakeLists.txt:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::addRoundedRectClip): (WebCore::GraphicsContext::clipOutRoundedRect): (WebCore::GraphicsContext::fillRoundedRect):
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/RoundedIntRect.cpp: Added. (WebCore::RoundedIntRect::Radii::isZero): (WebCore::RoundedIntRect::Radii::scale): (WebCore::RoundedIntRect::Radii::expand): (WebCore::RoundedIntRect::Radii::includeLogicalEdges): (WebCore::RoundedIntRect::Radii::excludeLogicalEdges): (WebCore::RoundedIntRect::RoundedIntRect): (WebCore::RoundedIntRect::includeLogicalEdges): (WebCore::RoundedIntRect::excludeLogicalEdges):
  • platform/graphics/RoundedIntRect.h: Added. (WebCore::RoundedIntRect::Radii::Radii): (WebCore::RoundedIntRect::Radii::setTopLeft): (WebCore::RoundedIntRect::Radii::setTopRight): (WebCore::RoundedIntRect::Radii::setBottomLeft): (WebCore::RoundedIntRect::Radii::setBottomRight): (WebCore::RoundedIntRect::Radii::topLeft): (WebCore::RoundedIntRect::Radii::topRight): (WebCore::RoundedIntRect::Radii::bottomLeft): (WebCore::RoundedIntRect::Radii::bottomRight): (WebCore::RoundedIntRect::Radii::expand): (WebCore::RoundedIntRect::Radii::shrink): (WebCore::RoundedIntRect::location): (WebCore::RoundedIntRect::size): (WebCore::RoundedIntRect::x): (WebCore::RoundedIntRect::y): (WebCore::RoundedIntRect::width): (WebCore::RoundedIntRect::height): (WebCore::RoundedIntRect::right): (WebCore::RoundedIntRect::bottom): (WebCore::RoundedIntRect::rect): (WebCore::RoundedIntRect::radii): (WebCore::RoundedIntRect::isRounded): (WebCore::RoundedIntRect::isEmpty): (WebCore::RoundedIntRect::setRect): (WebCore::RoundedIntRect::setRadii): (WebCore::RoundedIntRect::move): (WebCore::RoundedIntRect::inflate): (WebCore::RoundedIntRect::inflateWithRadii): (WebCore::RoundedIntRect::expandRadii): (WebCore::RoundedIntRect::shrinkRadii):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::pushContentsClip):
  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintFillLayerExtended): (WebCore::RenderBoxModelObject::paintBorder): (WebCore::RenderBoxModelObject::clipBorderSidePolygon): (WebCore::RenderBoxModelObject::paintBoxShadow):
  • rendering/RenderBoxModelObject.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::drawBoxSideFromPath):
  • rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::paint):
  • rendering/RenderThemeChromiumWin.cpp: (WebCore::RenderThemeChromiumWin::paintTextFieldInternal):
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintMenuListButtonGradients): (WebCore::RenderThemeMac::paintSliderTrack):
  • rendering/RenderThemeSafari.cpp: (WebCore::RenderThemeSafari::paintMenuListButtonGradients): (WebCore::RenderThemeSafari::paintSliderTrack):
  • rendering/RenderThemeWinCE.cpp: (WebCore::RenderThemeWinCE::paintSearchFieldCancelButton):
  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::paint):
  • rendering/style/BorderData.h:
  • rendering/style/RenderStyle.cpp: (WebCore::calcRadiiFor): (WebCore::calcConstraintScaleFor): (WebCore::RenderStyle::getRoundedBorderFor): (WebCore::RenderStyle::getRoundedInnerBorderWithBorderWidths):
  • rendering/style/RenderStyle.h: (WebCore::InheritedFlags::setBorderRadius):
00:43 Changeset [76003] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed.

[Qt] Fix LoadHTMLStringItem::invoke() after r75966
https://bugs.webkit.org/show_bug.cgi?id=52614

  • platform/qt/Skipped: http/tests/navigation/go-back-to-error-page.html added until fix.
00:00 Changeset [76002] by rwlbuis@webkit.org
  • 3 edits
    12 adds in trunk

2011-01-17 Rob Buis <rwlbuis@gmail.com>

Reviewed by Kent Tamura.

Color changes to option elements in a select multiple aren't drawn immediately
https://bugs.webkit.org/show_bug.cgi?id=49790

Redirect style changes on <option> element to the owner <select> element.

Tests: fast/forms/select-option-background-color-change.html

fast/forms/select-option-color-change.html
fast/forms/select-option-visibility-change.html

  • html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::setRenderStyle):

01/17/11:

23:12 Changeset [76001] by morrita@google.com
  • 3 edits in trunk/Source/WebCore

2011-01-17 MORITA Hajime <morrita@google.com>

Unreviewed, rolling out r75995.
http://trac.webkit.org/changeset/75995
https://bugs.webkit.org/show_bug.cgi?id=51914

Causes assertion failures.

  • dom/Element.cpp: (WebCore::Element::shadowRoot): (WebCore::Element::setShadowRoot): (WebCore::Element::removeShadowRoot):
  • dom/ElementRareData.h: (WebCore::ElementRareData::ElementRareData):
23:08 Changeset [76000] by morrita@google.com
  • 2 edits in trunk/Source/WebCore

2011-01-17 MORITA Hajime <morrita@google.com>

Unreviewed, rolling out r75999.
http://trac.webkit.org/changeset/75999

  • dom/Element.cpp: (WebCore::Element::removeShadowRoot):
22:52 Changeset [75999] by morrita@google.com
  • 2 edits in trunk/Source/WebCore

2011-01-17 MORITA Hajime <morrita@google.com>

Unreviewed crash fix, which introduced at r75995

  • dom/Element.cpp: (WebCore::Element::removeShadowRoot):
22:02 Changeset [75998] by mrowe@apple.com
  • 5 edits in tags/Safari-534.15.15

Versioning.

21:54 Changeset [75997] by mrowe@apple.com
  • 1 copy in tags/Safari-534.15.15

New tag.

21:40 Changeset [75996] by commit-queue@webkit.org
  • 2 edits
    8 adds in trunk/LayoutTests

2011-01-17 Steve Lacey <sjl@chromium.org>

Reviewed by David Levin.

Rebaseline media/video-zoom-controls for chromium.
https://bugs.webkit.org/show_bug.cgi?id=52415

  • platform/chromium-linux/media/video-zoom-controls-expected.checksum: Added.
  • platform/chromium-linux/media/video-zoom-controls-expected.png: Added.
  • platform/chromium-mac/media/video-zoom-controls-expected.checksum: Added.
  • platform/chromium-mac/media/video-zoom-controls-expected.png: Added.
  • platform/chromium-mac/media/video-zoom-controls-expected.txt: Added.
  • platform/chromium-win/media/video-zoom-controls-expected.checksum: Added.
  • platform/chromium-win/media/video-zoom-controls-expected.png: Added.
  • platform/chromium-win/media/video-zoom-controls-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
20:30 Changeset [75995] by morrita@google.com
  • 3 edits in trunk/Source/WebCore

2011-01-17 MORITA Hajime <morrita@google.com>

Reviewed by Dimitri Glazkov.

ElementRareData::m_shadowRoot should not be RefPtr.
https://bugs.webkit.org/show_bug.cgi?id=51914

This change makes m_shadowRoot a raw pointer, as Node::m_parent is.
This change is safe because shadow host pointer is stored as TreeShared::m_parent
which prevents deletion unless set to null.

No test, no behavioral change.

  • dom/Element.cpp: (WebCore::Element::shadowRoot): (WebCore::Element::setShadowRoot): (WebCore::Element::removeShadowRoot):
  • dom/ElementRareData.h: (WebCore::ElementRareData::ElementRareData):
19:49 Changeset [75994] by mjs@apple.com
  • 2 edits in trunk/Source/WebCore

2011-01-17 Maciej Stachowiak <mjs@apple.com>

Reviewed by Dan Bernstein.

Some WebKit2 layout tests crash due to focus being on a frame in the page cache
https://bugs.webkit.org/show_bug.cgi?id=52607

No new tests. Existing tests crash in WebKit2 without this fix.


I suspect there are other consequences besides the WebKit2 crash, but I
was unable to identify any for certain.

  • history/CachedFrame.cpp: (WebCore::CachedFrame::CachedFrame): If a frame still has focus when its page goes in the page cache, reset focus to the main frame.
19:15 Changeset [75993] by dimich@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Not reviewed, test expectations update.
Added TIMEOUT to fast/canvas/canvas-fillPath-pattern-shadow.html

  • platform/chromium-gpu/test_expectations.txt:
19:10 Changeset [75992] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-01-17 Jarred Nicholls <jarred@sencha.com>

Reviewed by Csaba Osztrogonác.

REGRESSION(r75709): Return value of fscanf() shouldn't be ignored.
https://bugs.webkit.org/show_bug.cgi?id=52585

gcc 4.4.4+ has warn_unused_value attribute on fscanf, so we should check
the return value to get around the gcc warning

  • jit/ExecutableAllocatorFixedVMPool.cpp: (JSC::maybeModifyVMPoolSize):
18:10 Changeset [75991] by msaboff@apple.com
  • 5 edits in trunk

2011-01-17 Michael Saboff <msaboff@apple.com>

Reviewed by Oliver Hunt.

[regexfuzz] Crash running regex with lookahead
https://bugs.webkit.org/show_bug.cgi?id=52548

Eliminated agressive chaining of backtracks. This code was overwriting
already valid backtrack information.

  • yarr/YarrJIT.cpp: (JSC::Yarr::YarrGenerator::ParenthesesTail::processBacktracks):

2011-01-17 Michael Saboff <msaboff@apple.com>

Reviewed by Oliver Hunt.

[regexfuzz] Crash running regex with lookahead
https://bugs.webkit.org/show_bug.cgi?id=52548

New tests from regex fuzzer.

  • fast/regex/parentheses-expected.txt:
  • fast/regex/script-tests/parentheses.js:
18:06 Changeset [75990] by dimich@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Not reviewed, test expectations update.
Same as previous patch, now for -gpu file.

  • platform/chromium-gpu/test_expectations.txt:
17:55 Changeset [75989] by dimich@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Not reviewed, test expectations update.
fast/canvas/canvas-fillPath-pattern-shadow.html fails on Win and Linux.

  • platform/chromium/test_expectations.txt:
17:46 Changeset [75988] by aroben@apple.com
  • 10 edits in trunk

Simplify WKCACFLayerRenderer's API

createRenderer/destroyRenderer are now hidden behind setHostWindow.
WKCACFLayerRendererClient::animationsStarted has been removed, as it
was never called. (The work it was supposed to do was already being
accomplished by WKCACFLayerRenderer::render telling each layer that
animations are starting.)

Fixes <http://webkit.org/b/52587> WKCACFLayerRenderer is hard to use

Reviewed by Chris Marrin.

Source/WebCore:

  • platform/graphics/win/MediaPlayerPrivateFullscreenWindow.cpp:

(WebCore::MediaPlayerPrivateFullscreenWindow::createWindow): Moved the
call to setHostWindow here from the WM_CREATE handler. The WM_CREATE
handler was causing the Direct3D device to be created, but MSDN says
you shouldn't create a device while handling WM_CREATE. Removed
no-longer-needed call to createRenderer (setHostWindow does this now)
and the never-needed call to setNeedsDisplay (we never draw into the
root layer; this was just creating an unnecessary backing store the
size of the screen!).
(WebCore::MediaPlayerPrivateFullscreenWindow::wndProc): Moved WM_CREATE
code, as described above. Removed call to destroyRenderer when handling
WM_DESTROY; setHostWindow does this now. Fixed up our WM_PAINT handler
to do a synchronous paint and to clear our dirty region, while I was in
here.

  • platform/graphics/win/WKCACFLayerRenderer.cpp:

(WebCore::WKCACFLayerRenderer::~WKCACFLayerRenderer): Changed to call
setHostWindow instead of destroyRenderer; the former calls the latter
if needed.
(WebCore::WKCACFLayerRenderer::setHostWindow): Moved here from the
header file. Destroys our old renderer (i.e., IDirect3DDevice9) if
we're losing our window, or creates a renderer if we're gaining a
window.
(WebCore::WKCACFLayerRenderer::createRenderer): Updated for WKSI function rename.
(WebCore::WKCACFLayerRenderer::destroyRenderer): Changed to clear the
D3D device from our context before releasing the device.

  • platform/graphics/win/WKCACFLayerRenderer.h: Removed

WKCACFLayerRendererClient::animationsStarted. Removed setNeedsDisplay.
Make createRenderer, destroyRenderer, and renderSoon private.

WebKit/win:

Update for WKCACFLayerRenderer changes

  • WebView.cpp:

(WebView::WebViewWndProc): Removed call to layerRendererBecameVisible
when handling WM_SHOWWINDOW. All this did was try to create the
renderer, but it had already been created in setAcceleratedCompositing,
so wasn't needed.
(WebView::setAcceleratedCompositing): Removed call to createRenderer;
setHostWindow does this for us now.

  • WebView.h: Removed animationsStarted and layerRendererBecameVisible.

WebKitLibraries:

Make it possible to both set and clear a wkCACFContext's D3D device

  • win/include/WebKitSystemInterface/WebKitSystemInterface.h:
  • win/lib/WebKitSystemInterface.lib:
17:45 Changeset [75987] by aroben@apple.com
  • 7 edits in trunk/Source

Paint directly into a GraphicsLayer when using accelerated compositing

Before this patch, we were painting into our normal backing store
HBITMAP, wrapping it in a CGImage, and handing it off to Core
Animation. This had at least two disadvantages:

1) The bitmap could be modified while Core Animation was using it.
2) It introduced extra complexity.

When entering accelerated compositing mode, WebView now creates a
GraphicsLayer to draw into. This GraphicsLayer sits between the root
layer (owned by WKCACFLayerRenderer) and the RenderView's layer. When
WebView invalidates, it just calls setNeedsDisplayInRect on its
GraphicsLayer. When WebView paints, it just tells its
WKCACFLayerRenderer to paint, which will call back to WebView to draw
into the GraphicsLayer if it has a dirty region. This is very similar
to the current implementation of LayerBackedDrawingArea in WebKit2.

Fixes <http://webkit.org/b/52582> WebView should paint directly into a
GraphicsLayer when in accelerated compositing mode

Reviewed by Simon Fraser and Chris Marrin.

WebCore:

Remove special-cased support for providing content for the root layer

Clients will just have to provide content through the normal
GraphicsLayer channels now!

  • platform/graphics/win/WKCACFLayerRenderer.cpp:

(WebCore::WKCACFLayerRenderer::WKCACFLayerRenderer): Removed
initialization of m_backingStoreDirty, which has itself been removed.
(WebCore::WKCACFLayerRenderer::setNeedsDisplay): Moved code to schedule
a sync from here to syncCompositingStateSoon. We only need to call
renderSoon if we don't call syncCompositingStateSoon; the latter
function calls the former.
(WebCore::WKCACFLayerRenderer::paint): Removed code to handle
m_backingStoreDirty. We don't want to know anything about clients'
backing stores.
(WebCore::WKCACFLayerRenderer::syncCompositingStateSoon): Added. Code
came from setNeedsDisplay.

  • platform/graphics/win/WKCACFLayerRenderer.h:

Removed setRootContents[AndDisplay], setBackingStoreDirty, and
m_backingStoreDirty. Made paint() public so that clients can force a
synchronous render (e.g., when handling WM_PAINT).

WebKit/win:

  • WebCoreSupport/WebChromeClient.cpp:

(WebChromeClient::attachRootGraphicsLayer):
(WebChromeClient::scheduleCompositingLayerSync):
Updated for WebView changes.

  • WebView.cpp:

(WebView::repaint): When using accelerated compositing, just invalidate
our backing layer. This matches the behavior of LayerBackedDrawingArea.
(WebView::deleteBackingStore): Removed accelerated compositing code.
The WKCACFLayerRenderer doesn't need to know about our backing store
anymore; we don't use it at all when in accelerated compositing mode.
(WebView::addToDirtyRegion): When using accelerated compositing, just
invalidate our backing layer.
(WebView::scrollBackingStore): Added an assertion that this isn't
called in accelerated compositing mode.
(WebView::sizeChanged): Update our backing layer's size, too, and
invalidate it.
(WebView::updateBackingStore): Added an assertion that this isn't
called in accelerated compositing mode.
(WebView::paint): If we're in accelerated compositing mode, sync our
compositing state. If we're *still* in accelerated compositing mode,
just tell our WKCACFLayerRenderer to paint and clear our dirty region.
(The later changes in this function are just un-indenting code that
used to be inside an if.)

(WebView::paintIntoBackingStore):
(WebView::paintIntoWindow):
Added assertions that these aren't called in accelerated compositing
mode.

(WebView::WebViewWndProc): Updated WM_XP_THEMECHANGED handling for
removal of setRootLayerNeedsDisplay.
(WebView::setRootChildLayer): Changed to take a GraphicsLayer. We now
set the layer as a child of our own backing layer.
(WebView::scheduleCompositingLayerSync): Just call through to
WKCACFLayerRenderer.
(WebView::setAcceleratedCompositing): Create our backing layer and set
it as the child of WKCACFLayerRenderer's root layer.
(WebView::notifyAnimationStarted): Added. We never expect this
GraphicsLayerClient override to be called, as we don't use animations
on our backing layer.
(WebView::notifySyncRequired): Added. Just schedule a sync.
(WebView::paintContents): Added. Just clip and paint!

(WebView::showDebugBorders):
(WebView::showRepaintCounter):
Added. These just call through to Settings.

(WebView::syncCompositingState): Changed to first update layout, then
sync state for our backing layer, then sync WebCore's state. This
matches LayerBackedDrawingArea.

  • WebView.h: WebView now implements the GraphicsLayerClient interface.

Removed setRootLayerNeedsDisplay; it's been replaced by calling
setNeedsDisplay on our backing layer and calling
syncCompositingStateSoon on WKCACFLayerRenderer as needed. Removed
updateRootLayerContents; that function was used to pass our backing
store to Core Animation, which we no longer do. Added m_backingLayer.

17:45 Changeset [75986] by aroben@apple.com
  • 2 edits in trunk/Source/WebCore

Remove contexts from WKCACFContextFlusher before destroying them

We aren't really using WKCACFContextFlusher for anything useful at the
moment, but that will probably change in the near future.

I couldn't come up with a way to test this because it isn't possible to
resize a window in DumpRenderTree.

Fixes <http://webkit.org/b/52573> REGRESSION (r75262): Crash beneath
WKCACFContextFlusher::flushAllContexts when resizing window on page
that uses accelerated compositing

Reviewed by Simon Fraser.

  • platform/graphics/win/WKCACFLayerRenderer.cpp:

(WebCore::WKCACFLayerRenderer::~WKCACFLayerRenderer): Remove our
context from WKCACFContextFlusher. (This code was erroneously removed
from WKCACFLayerRenderer::destroyRenderer in r75262. This is a more
sensible place for it.)

17:44 Changeset [75985] by aroben@apple.com
  • 6 edits in trunk

Don't access the CACFLayerRef's sublayers directly from PlatformCALayer

There might be a secret extra sublayer (the tile parent layer) that
PlatformCALayer doesn't know about. When PlatformCALayer would
encounter this, it would try to use the tile parent layer's
PlatformCALayer wrapper, which was null, and then would crash. We now
ask PlatformCALayerWinInternal for the sublayer list, since that class
knows about the tile parent layer and can exclude it from the sublayer
list.

Covered by compositing/tiling/huge-layer-resize.html.

Fixes <http://webkit.org/b/52597> Crash beneath
PlatformCALayer::adoptSublayers when switching out of tiling mode
(null-dereference of a PlatformCALayer)

Reviewed by Darin Adler and Chris Marrin.

LayoutTests:

Make compositing/tiling/huge-layer-resize.html faster, more reliable,
and more crashy (when there's a WebKit bug)

This test was trying to cause a layout/paint to happen by returning to
the event loop for a certain amount of time via setTimeout. But this
didn't always result in a layout/paint (at least on Windows). We now
force the layout/paint explicitly, which also lets us speed up the test
by removing the setTimeouts.

  • compositing/tiling/huge-layer-resize.html:

(testOnLoad): Changed to use recordLayerTree, which forces a
layout/paint, instead of hoping that setTimeout will do the trick.
(recordLayerTree): Forces a layout/paint, then dumps the layer tree.

Source/WebCore:

  • platform/graphics/ca/win/PlatformCALayerWin.cpp:

(PlatformCALayer::adoptSublayers):
(printLayer):
Changed to use PlatformCALayerWinInternal::getSublayers.

  • platform/graphics/ca/win/PlatformCALayerWinInternal.cpp:

(PlatformCALayerWinInternal::getSublayers): Added. Retrieves the list
of PlatformCALayers that represent our sublayers. Significantly, this
code knows about the tile parent layer and can thus exclude it.

  • platform/graphics/ca/win/PlatformCALayerWinInternal.h: Added

getSublayers.

17:13 Changeset [75984] by wsiegrist@apple.com
  • 1 edit in trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg

2011-01-17 William Siegrist <wsiegrist@apple.com>

Explicitly set mode during file upload to ensure web server can read the files.

17:10 Changeset [75983] by thakis@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-01-17 Nico Weber <thakis@chromium.org>

Unreviewed.

Roll chromium DEPS forward to pick up the skia roll to skia r692.
https://bugs.webkit.org/show_bug.cgi?id=52600

  • DEPS:
16:44 Changeset [75982] by commit-queue@webkit.org
  • 5 edits in trunk/Source

2011-01-17 Naoki Takano <takano.naoki@gmail.com>

Reviewed by Kent Tamura.

[Chromium] Fix popup menu re-positioning when the menu is opened upward, above the corresponding form field.
https://bugs.webkit.org/show_bug.cgi?id=51382
http://crbug.com/60427

Calculate correct location of popup window whenever the items in the window change.

No new tests, because this fix is for Chromium project and hard to test only in WebKit project

  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupContainer::layoutAndCalculateWidgetRect): New Function to layout and calculate popup widget rect. (WebCore::PopupContainer::showPopup): Move widgetRect calculation logic to calculateWidgetRect(). (WebCore::PopupContainer::refresh): Add parameter focusRect to take the location and the size of focus text input field to calculate correct popup window location.
  • platform/chromium/PopupMenuChromium.h: Append new input parameter for refresh().

2011-01-17 Naoki Takano <takano.naoki@gmail.com>

Reviewed by Kent Tamura.

[Chromium] Fix popup menu re-positioning when the menu is opened upward, above the corresponding form field.
https://bugs.webkit.org/show_bug.cgi?id=51382
http://crbug.com/60427

Calculate correct location of popup window whenever the items in the window change.

No new tests, because this fix is for Chromium project and hard to test only in WebKit project

  • WebKit/chromium/src/WebViewImpl.cpp: (WebKit::WebViewImpl::refreshAutoFillPopup): Change the logic in refreshAutoFilPopup() to check both the location and the size of popup window.
16:38 Changeset [75981] by jhoneycutt@apple.com
  • 2 edits in trunk/Source/WebKit2

Windows build fix. Unreviewed.

  • Shared/PrintInfo.cpp:

Use #include, not #import.

16:32 Changeset [75980] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

Actually wrote a FIXME promised for a review comment.

  • UIProcess/API/mac/WKView.mm: (-[WKView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
16:27 Changeset [75979] by ap@apple.com
  • 15 edits
    3 adds in trunk/Source/WebKit2

Reviewed by Anders Carlsson and Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=52595
Make basic printing work in WebKit2

  • Shared/WebPreferencesStore.h:
  • UIProcess/API/C/WKPreferences.cpp: (WKPreferencesSetShouldPrintBackgrounds): (WKPreferencesGetShouldPrintBackgrounds):
  • UIProcess/API/C/WKPreferences.h: Implement a preference for printing backgrounds.
  • Shared/PrintInfo.cpp: Added. (WebKit::PrintInfo::encode): (WebKit::PrintInfo::decode):
  • Shared/PrintInfo.h: Added.
  • Shared/mac/PrintInfoMac.mm: Added. (WebKit::PrintInfo::PrintInfo): A new class for passing page setup information down to the web process.
  • WebKit2.xcodeproj/project.pbxproj:
  • GNUmakefile.am:
  • WebKit2.pro:
  • win/WebKit2.vcproj: Added PrintInfo.
  • Scripts/webkit2/messages.py: Added PrintInfo.h to a list of structs.
  • UIProcess/API/mac/WKView.mm: (WKViewData): Cache page count and geometry. (WebFrameWrapper): Added a wrapper class for adding a WebFrameProxy to an NSDictionary. (-[WKView drawRect:]): Added logging. (setFrameBeingPrinted): Store a frame into NSPrintOperation's NSPrintInfo, so that all methods invoked for this operation would know what's being printed. (frameBeingPrinted): Retrieve this data. (-[WKView printOperationWithPrintInfo:forFrame:]): Create a print operation that's appropriate for the frame. (-[WKView knowsPageRange:]): Ask the web process. (-[WKView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]): Take over printing, because I couldn't make drawRect: work correctly with WebKit custom fit to page implementation. (-[WKView _provideTotalScaleFactorForPrintOperation:]): Help AppKit clip correctly. (-[WKView rectForPage:]): Return a pre-calculated rect.
  • UIProcess/WebPageProxy.h: Added m_isInPrintingMode to track whether the web page is in printing mode. The UI process controls that.
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::WebPageProxy): Initialize m_isInPrintingMode. (WebKit::WebPageProxy::beginPrinting): Change printing mode in web process if the value changes. (WebKit::WebPageProxy::endPrinting): Ditto. (WebKit::WebPageProxy::computePagesForPrinting): Ask the web process about output page geometry. (WebKit::WebPageProxy::drawRectToPDF): Ask the web process about printed page data.
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::close): Delete m_printContext while there is still a Frame pointer. (WebKit::WebPage::updatePreferences): Pass through ShouldPrintBackgrounds. (WebKit::WebPage::beginPrinting): Switch into printing mode (or update parameters if we're already in printing mode). (WebKit::WebPage::endPrinting): Delete m_printContext, implicitly calling end(). (WebKit::WebPage::computePagesForPrinting): Make sure that we're in printing mode, and copmute page rects. (WebKit::WebPage::drawRectToPDF): Added a CG specific function to create a PDF document out of a page rect. It should really work for onscreen content, but we only need it for printing.
  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in: Added BeginPrinting, EndPrinting, ComputePagesForPrinting and DrawRectToPDF.
15:59 Changeset [75978] by mrowe@apple.com
  • 5 edits in tags/Safari-534.15.14

Versioning.

15:31 Changeset [75977] by mrowe@apple.com
  • 1 copy in tags/Safari-534.15.14

New tag.

15:15 Changeset [75976] by mrowe@apple.com
  • 2 edits in trunk/Source/WebCore

Fix the 32-bit build.

  • WebCore.exp.in:
15:14 Changeset [75975] by mitz@apple.com
  • 4 edits
    2 adds in trunk

Use of invalid hash map key in CSSFontFaceSource::getFontData() with 0-sized remote font
https://bugs.webkit.org/show_bug.cgi?id=52598

Reviewed by Darin Adler.

Source/WebCore:

Test: fast/css/font-face-zero-hash-key.html

  • css/CSSFontFaceSource.cpp:

(WebCore::CSSFontFaceSource::getFontData): Add 1 to the font size to avoid a 0 hash key.

  • css/CSSSegmentedFontFace.cpp:

(WebCore::CSSSegmentedFontFace::getFontData): Ditto.

LayoutTests:

  • fast/css/font-face-zero-hash-key-expected.txt: Added.
  • fast/css/font-face-zero-hash-key.html: Added.
15:03 Changeset [75974] by ddkilzer@apple.com
  • 4 edits in trunk/Source

<http://webkit.org/b/52596> Add missing DOMDocument/DOMDocumentFragment headers to Xcode project

Reviewed by Dan Bernstein.

WebCore:

This fixes two issues:

Add missing DOMDocumentFragmentPrivate.h and
DOMDocumentPrivate.h files to the project. These files were
never added to the the project although their *Internal.h
counterparts were added in r16548 and r17390.

Add missing DOMDocumentFragmentInternal.h to the Headers
section. It was moved from Headers to "Copy Generated Headers"
in r31045, but it should have an entry in both sections.

  • WebCore.xcodeproj/project.pbxproj:

WebKit/mac:

  • MigrateHeaders.make: Copy DOMDocumentFragmentPrivate.h and

DOMDocumentPrivate.h to the PrivateHeaders directory.

14:54 Changeset [75973] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

2011-01-17 Helder Correia <helder@sencha.com>

Reviewed by Andreas Kling.

[Qt] Incorrect shadow alpha with pattern fillStyle
https://bugs.webkit.org/show_bug.cgi?id=52559

The shadow color opacity needs to be set on the shadow painter.
This is related to bug 52556.

  • fast/canvas/canvas-fillPath-pattern-shadow-expected.txt: Added.
  • fast/canvas/canvas-fillPath-pattern-shadow.html: Added.
  • fast/canvas/script-tests/canvas-fillPath-pattern-shadow.js: Added.

2011-01-17 Helder Correia <helder@sencha.com>

Reviewed by Andreas Kling.

[Qt] Incorrect shadow alpha with pattern fillStyle
https://bugs.webkit.org/show_bug.cgi?id=52559

The shadow color opacity needs to be set on the shadow painter.
This is related to bug 52556.

Test: fast/canvas/canvas-fillPath-pattern-shadow.html

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::fillPath):
14:48 Changeset [75972] by mrobinson@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-01-17 Martin Robinson <mrobinson@igalia.com>

Reviewed by Andreas Kling.

[GTK] Port a crash fix from libsoup upstream to the libsoup cache code
https://bugs.webkit.org/show_bug.cgi?id=52586

No new tests. This is just a merge from upstream.

  • platform/network/soup/cache/soup-http-input-stream.c: (webkit_soup_http_input_stream_got_chunk): Properly handle unsigned numbers.
13:38 Changeset [75971] by tonyg@chromium.org
  • 23 edits in trunk

2011-01-17 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Alexey Proskuryakov.

Fix some headers with missing or misspelled #ifndef guards
https://bugs.webkit.org/show_bug.cgi?id=52545

  • wtf/RefPtrHashMap.h:

2011-01-17 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Alexey Proskuryakov.

Fix some headers with missing or misspelled #ifndef guards
https://bugs.webkit.org/show_bug.cgi?id=52545

No new tests because no new functionality.

  • ForwardingHeaders/runtime/InitializeThreading.h:
  • editing/SmartReplace.h:
  • loader/CrossOriginAccessControl.h:
  • loader/NetscapePlugInStreamLoader.h:
  • platform/chromium/ClipboardUtilitiesChromium.h:
  • platform/graphics/cairo/DrawErrorUnderline.h:
  • platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:
  • platform/graphics/cg/GraphicsContextPlatformPrivateCG.h:
  • platform/graphics/cg/PDFDocumentImage.h:
  • platform/win/WebCoreTextRenderer.h:

2011-01-17 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Alexey Proskuryakov.

Fix some headers with missing or misspelled #ifndef guards
https://bugs.webkit.org/show_bug.cgi?id=52545

  • WebKitStatistics.h:

2011-01-17 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Alexey Proskuryakov.

Fix some headers with missing or misspelled #ifndef guards
https://bugs.webkit.org/show_bug.cgi?id=52545

  • Shared/UserMessageCoders.h:
  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h:
  • WebProcess/InjectedBundle/InjectedBundleUserMessageCoders.h:
  • WebProcess/WebProcessMain.h:

2011-01-17 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Alexey Proskuryakov.

Fix some headers with missing or misspelled #ifndef guards
https://bugs.webkit.org/show_bug.cgi?id=52545

  • DumpRenderTree/chromium/TestEventPrinter.h:
  • DumpRenderTree/chromium/WebPreferences.h:
13:16 Changeset [75970] by ddkilzer@apple.com
  • 2 edits in trunk/LayoutTests

2011-01-17 David Kilzer <ddkilzer@apple.com>

<http://webkit.org/b/52524> fast/dom/Range/range-clone-contents.html fails only on Windows

Reviewed by Alexey Proskuryakov.

  • platform/win/Skipped: Removed fast/dom/Range/range-clone-contents.html. It appears the Windows buildbots need a clean build.
12:59 Changeset [75969] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-01-17 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: follow-up fix for r52574: do not reuse clear() for navigation.

  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype.clear): (WebInspector.NetworkPanel.prototype.mainResourceChanged):
12:53 Changeset [75968] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

Build fix.

  • Platform/Logging.cpp:
12:47 Changeset [75967] by sergio@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-01-17 Sergio Villar Senin <svillar@igalia.com>

Reviewed by Martin Robinson.

[Gtk] No need to content sniff 304 Not Modified responses
https://bugs.webkit.org/show_bug.cgi?id=52570

Makes no sense to wait for the outcome of content sniffing when WebCore
is validating resources. If we get a 304 Not Modified it means that we can
safely use the cached version of the resource we're asking for.

No new tests because it does not change functionality, it just
calls didReceiveResponse sooner for 304 Not Modified responses.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::gotHeadersCallback):
12:22 Changeset [75966] by jberlin@webkit.org
  • 11 edits
    4 adds in trunk

REGRESSION: Assertion failure in FrameLoader::continueLoadAfterWillSubmitForm() when
navigating back to an unreachable URL
https://bugs.webkit.org/show_bug.cgi?id=52388

Reviewed by Anders Carlsson.

Source/WebCore:

Test: http/tests/navigation/go-back-to-error-page.html

  • history/PageCache.cpp:

(WebCore::PageCache::canCachePageContainingThisFrame):
Do not cache any error pages (which we can recognize as having substitute data and/or an
unreachableURL).

Tools:

Add a third parameter (unreachableURL) to queueLoadHTMLString.

  • DumpRenderTree/LayoutTestController.cpp:

(queueLoadHTMLStringCallback):
(LayoutTestController::queueLoadHTMLString):
(LayoutTestController::queueLoadAlternateHTMLString):

  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/WorkQueueItem.h:

(LoadHTMLStringItem::LoadHTMLStringItem):

  • DumpRenderTree/chromium/LayoutTestController.cpp:

(WorkItemLoadHTMLString::WorkItemLoadHTMLString):
(WorkItemLoadHTMLString::run):
(LayoutTestController::queueLoadHTMLString):

  • DumpRenderTree/gtk/WorkQueueItemGtk.cpp:

(LoadHTMLStringItem::invoke):

  • DumpRenderTree/mac/WorkQueueItemMac.mm:

(LoadHTMLStringItem::invoke):

  • DumpRenderTree/win/WorkQueueItemWin.cpp:

(LoadHTMLStringItem::invoke):

LayoutTests:

Add a test that loads an alternate HTML String for an "unreachable" URL, loads another
page, and then goes back to the "unreachable" URL, which is now reachable.

This tests two things:
1) No assertion failure when going back to an unreachable URL.
2) There is no page cached for the unreachable URL.

  • http/tests/navigation/go-back-to-error-page-expected.txt: Added.
  • http/tests/navigation/go-back-to-error-page.html: Added.
  • http/tests/navigation/resources/page-to-go-back-from.html: Added.
  • http/tests/navigation/resources/page-treated-as-unreachable.html: Added.
12:16 Changeset [75965] by ap@apple.com
  • 3 edits in trunk/Source/WebKit2

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=52592
Add a logging channel for WKView

  • Platform/Logging.cpp:
  • Platform/Logging.h:
12:16 Changeset [75964] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-01-17 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: fixing typo in r75952.

  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkDataGridNode.prototype._refreshNameCell):
12:12 Changeset [75963] by enrica@apple.com
  • 6 edits in trunk/Source

Drag and drop support: refactoring of image from link and image from selection
https://bugs.webkit.org/show_bug.cgi?id=52496

Reviewed by Alexey Proskuryakov.

Source/WebCore:

This work cleans up the Mac code and makes it more similar to the Windows implementation,
avoiding the use of an NSView when the FrameView can be used.
The refactoring is a necessary step towards the complete support of drag and drop
in WebKit2.

  • page/mac/FrameMac.mm:

(WebCore::Frame::imageFromRect): Modified to use FrameView instead of NSView
to generate the image for drag.

Source/WebKit/mac:

This work cleans up the Mac code and makes it more similar to the Windows implementation,
avoiding the use of an NSView when the FrameView can be used.
The refactoring is a necessary step towards the complete support of drag and drop
in WebKit2.

  • WebCoreSupport/WebDragClient.mm:

(WebDragClient::createDragImageForLink): Added.

  • WebView/WebHTMLView.mm: Removed dragImageFromLink and dragImageFromURL.
  • WebView/WebHTMLViewPrivate.h: Removed dragImageFromLink and dragImageFromURL.
12:01 Changeset [75962] by andersca@apple.com
  • 6 edits
    3 adds in trunk/Source/WebKit2

2011-01-17 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Factor bitmap context drawing code out into a shared function
https://bugs.webkit.org/show_bug.cgi?id=52589

  • Platform/cg/CGUtilities.h: Added.
  • Platform/cg/CGUtilities.cpp: Added. (WebKit::paintBitmapContext): New function that will paint a bitmap context into a CGContext.
  • Shared/cg/ShareableBitmapCG.cpp: (WebKit::ShareableBitmap::paint): Use paintBitmapContext.
  • UIProcess/mac/BackingStoreMac.mm: (WebKit::BackingStore::paint): (WebKit::BackingStore::scroll): Use paintBitmapContext.
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:
  • win/WebKit2Common.vsprops: Add CGUtilities.{cpp|h}.
11:50 Changeset [75961] by mitz@apple.com
  • 25 edits in trunk

Update xcodeproj svn:ignore to include xcuserdata.

Rubber-stamped by Mark Rowe.

Examples:

  • NetscapeCocoaPlugin/NetscapeCocoaPlugin.xcodeproj: Modified property svn:ignore.
  • NetscapeCoreAnimationMoviePlugin/NetscapeCoreAnimationMoviePlugin.xcodeproj: Modified property svn:ignore.
  • NetscapeCoreAnimationPlugin/NetscapeCoreAnimationPlugin.xcodeproj: Modified property svn:ignore.
  • NetscapeInputMethodPlugin/NetscapeInputMethodPlugin.xcodeproj: Modified property svn:ignore.

Source/JavaScriptCore:

Source/JavaScriptGlue:

  • JavaScriptGlue.xcodeproj: Modified property svn:ignore.

Source/ThirdParty/ANGLE:

  • ANGLE.xcodeproj: Modified property svn:ignore.
  • src/build_angle.xcodeproj: Modified property svn:ignore.

Source/WebCore:

  • WebCore.xcodeproj: Modified property svn:ignore.
  • manual-tests/NPN_Invoke/NPN_Invoke.xcodeproj: Modified property svn:ignore.

Source/WebKit:

  • WebKit.xcodeproj: Modified property svn:ignore.

Source/WebKit2:

  • WebKit2.xcodeproj: Modified property svn:ignore.

Tools:

  • DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
  • MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
  • TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
  • WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
  • WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.
11:48 Changeset [75960] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

Fixing a typo from a bad merge.

  • UIProcess/API/mac/WKView.mm: (-[WKView canChangeFrameLayout:]):
11:43 Changeset [75959] by ap@apple.com
  • 3 edits in trunk/Source/WebKit2

Reviewed by John Sullivan.

https://bugs.webkit.org/show_bug.cgi?id=52590
Should pass a frame into -[WKView canPrintHeadersAndFooters]

  • UIProcess/API/mac/WKView.h:
  • UIProcess/API/mac/WKView.mm: (-[WKView canChangeFrameLayout:]): Also, renamed the method to canChangeFrameLayout.
11:36 Changeset [75958] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

Leopard build fix.

  • page/PrintContext.cpp: GCC complained about shortening a double value to float.
11:27 WebKit Team edited by thakis@chromium.org
(diff)
10:47 Changeset [75957] by mrowe@apple.com
  • 3 deletes in trunk

Remove a few more empty directories that I missed.

10:41 Changeset [75956] by mrowe@apple.com
  • 87 deletes in trunk

Remove a large number of empty directories.

10:31 Changeset [75955] by ap@apple.com
  • 6 edits in trunk/Source

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=52495

No change in behavior, so no tests.

  • WebCore.exp.in: Export additional methods, as I'm going to use more code from PrintContext.
  • page/PrintContext.cpp: (WebCore::PrintContext::~PrintContext): No need to clear m_pageRects, the object is being destroyed already. (WebCore::PrintContext::pageCount): Changed page count from int to size_t. (WebCore::PrintContext::pageRect): Ditto. (WebCore::PrintContext::computePageRects): Pass allowHorizontalTiling as an argument. PrintContext already has code to calculate scale factor, so it makes sense to make methods that contain it universal (allowHorizontalTiling is always true for Safari). Round page height to an integer, because Mac code does that, and because page height is treated as integer almost everywhere else in code. (WebCore::PrintContext::begin): Allow calling this function multiple times. There is no need to return to screen mode if e.g. "print backgounds" option changes. (WebCore::PrintContext::computeAutomaticScaleFactor): Expose scale factor computation, so that clients don't have to copy it. (WebCore::PrintContext::spoolRect): Add a way to spool a precomputed rect - handy if a request comes from code that doesn't have page number. (WebCore::PrintContext::pageNumberForElement): Page number int -> size_t.
  • page/PrintContext.h: Added comments and FIXMEs. PrintContext needs cleanup, but that depends on deciding how it really needs to work (e.g. whether computePageRects() should cause relayout).
10:25 Changeset [75954] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

2011-01-17 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: skip flaky inspector test (will look at it tomorrow).

  • platform/mac-leopard/Skipped:
10:21 Changeset [75953] by andersca@apple.com
  • 7 edits in trunk/Source/WebKit2

2011-01-17 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Implement scrolling support
https://bugs.webkit.org/show_bug.cgi?id=52502

  • Shared/UpdateInfo.cpp: (WebKit::UpdateInfo::encode): (WebKit::UpdateInfo::decode):
  • Shared/UpdateInfo.h: Add scrollRect and scrollDelta member variables.
  • UIProcess/BackingStore.h: Add scroll member function.
  • UIProcess/DrawingAreaProxyImpl.cpp: (WebKit::DrawingAreaProxyImpl::incorporateUpdate): Repaint the scroll rect. Force a display of the view when the update info contains a scroll rect.
  • UIProcess/mac/BackingStoreMac.mm: (WebKit::BackingStore::incorporateUpdate): Call scroll.

(WebKit::BackingStore::scroll):
Paint the backing store into itself.

  • WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::display): Pass the scroll information in the update info.
09:51 Changeset [75952] by pfeldman@chromium.org
  • 6 edits in trunk/Source/WebCore

2011-01-17 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: unify image data source assignment, add image url
to the image view properties list.
https://bugs.webkit.org/show_bug.cgi?id=52584

  • English.lproj/localizedStrings.js:
  • inspector/front-end/ImageView.js: (WebInspector.ImageView.prototype._createContentIfNeeded.onImageLoad): (WebInspector.ImageView.prototype._createContentIfNeeded):
  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkDataGridNode.prototype._refreshNameCell):
  • inspector/front-end/Resource.js: (WebInspector.Resource.prototype.populateImageSource): (WebInspector.Resource.prototype._contentURL):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.FrameResourceTreeElement.prototype.onattach):
09:28 Changeset [75951] by beidson@apple.com
  • 2 edits in trunk/Source/WebKit

Fix up the make build on Macs

Rubberstamped by Adam Roben.

  • Makefile: Point to the correct Makefile.shared
09:10 Changeset [75950] by caseq@chromium.org
  • 6 edits in trunk

2011-01-17 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Extensions API] webInspector.resources.onFinished is not fired for redirected resources
Make resource start/finish hanlding more consistent.
https://bugs.webkit.org/show_bug.cgi?id=52452

  • inspector/front-end/AuditLauncherView.js: Ignore WebSocket resources when displaying progress indicator (WebInspector.AuditLauncherView.prototype._resetResourceCount): (WebInspector.AuditLauncherView.prototype.resourceStarted): (WebInspector.AuditLauncherView.prototype.resourceFinished):
  • inspector/front-end/NetworkManager.js: (WebInspector.NetworkManager): Factor out resource start/finish logic to _startResource()/_finishResource() (WebInspector.NetworkManager.prototype.identifierForInitialRequest): (WebInspector.NetworkManager.prototype.willSendRequest): (WebInspector.NetworkManager.prototype.markResourceAsCached): (WebInspector.NetworkManager.prototype.didReceiveResponse): (WebInspector.NetworkManager.prototype.didReceiveContentLength): (WebInspector.NetworkManager.prototype.didFinishLoading): (WebInspector.NetworkManager.prototype.didFailLoading): (WebInspector.NetworkManager.prototype.didLoadResourceFromMemoryCache): (WebInspector.NetworkManager.prototype.didCreateWebSocket): (WebInspector.NetworkManager.prototype.willSendWebSocketHandshakeRequest): (WebInspector.NetworkManager.prototype.didReceiveWebSocketHandshakeResponse): (WebInspector.NetworkManager.prototype.didCloseWebSocket): (WebInspector.NetworkManager.prototype._appendRedirect): (WebInspector.NetworkManager.prototype._startResource): (WebInspector.NetworkManager.prototype._finishResource):

2011-01-17 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Extensions API] webInspector.resources.onFinished is not fired for redirected resources
Added test for finished event being sent for redirected resources.
https://bugs.webkit.org/show_bug.cgi?id=52452

  • http/tests/inspector/extensions-resources-redirect-expected.txt:
  • http/tests/inspector/extensions-resources-redirect.html:
08:42 Changeset [75949] by pfeldman@chromium.org
  • 10 edits in trunk/Source/WebCore

2011-01-17 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: restore dom and network state upon frontend reuse.
https://bugs.webkit.org/show_bug.cgi?id=52574

  • inspector/Inspector.idl:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::restoreInspectorStateFromCookie): (WebCore::InspectorController::populateScriptObjects): (WebCore::InspectorController::pushDataCollectedOffline): (WebCore::InspectorController::didCommitLoad):
  • inspector/InspectorController.h:
  • inspector/front-end/NetworkManager.js: (WebInspector.NetworkManager.prototype.reset):
  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype.clear): (WebInspector.NetworkPanel.prototype.mainResourceChanged):
  • inspector/front-end/ResourceTreeModel.js: (WebInspector.ResourceTreeModel): (WebInspector.ResourceTreeModel.prototype.reloadCachedResources):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.clear):
  • inspector/front-end/inspector.js: (WebInspector.frontendReused):
08:38 Changeset [75948] by ossy@webkit.org
  • 2 edits in trunk/Tools

Unreviewed fix after r75908.

Move WebKit into Source
https://bugs.webkit.org/show_bug.cgi?id=52530

  • BuildSlaveSupport/build.webkit.org-config/master.cfg: Add Source to the path for Qt API tests.
08:33 Changeset [75947] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

2011-01-17 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: first timeline-network-resource flakiness.

  • inspector/timeline-network-resource.html:
08:19 Changeset [75946] by caseq@chromium.org
  • 4 edits in trunk/Source/WebKit2

2011-01-17 Andrey Kosyakov <caseq@chromium.org>

Unreviewed. Fixed malformed reference to WebKitVSPropsRedirectionDir that broke win build.

  • win/WebKit2.vcproj:
  • win/WebKit2GeneratedCommon.vsprops:
  • win/WebKit2WebProcess.vcproj:
08:18 Changeset [75945] by ossy@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed buildfix after r75944.

  • WebCore.pro:
08:00 Changeset [75944] by commit-queue@webkit.org
  • 15 edits
    2 adds in trunk/Source

2011-01-17 Yi Shen <yi.4.shen@nokia.com>

Reviewed by Andreas Kling.

[Qt] Extend the Platform Plugin to support full screen video handler
https://bugs.webkit.org/show_bug.cgi?id=51249

Make MediaPlayerPrivateQt support a fullscreen player.

No new tests because LayoutTests/media/media-fullscreen-inline.html already exists.
However, this test failed for Qt (QtMediaPlayer) due to durationchange event getting fired twice.
So, still skip it for Qt.

  • WebCore.pro:
  • features.pri:
  • platform/graphics/qt/MediaPlayerPrivateQt.cpp: (WebCore::MediaPlayerPrivateQt::MediaPlayerPrivateQt): (WebCore::MediaPlayerPrivateQt::removeVideoItem): (WebCore::MediaPlayerPrivateQt::restoreVideoItem):
  • platform/graphics/qt/MediaPlayerPrivateQt.h: (WebCore::MediaPlayerPrivateQt::supportsFullscreen): (WebCore::MediaPlayerPrivateQt::mediaPlayer):

2011-01-17 Yi Shen <yi.4.shen@nokia.com>

Reviewed by Andreas Kling.

[Qt] Extend the Platform Plugin to support full screen video handler
https://bugs.webkit.org/show_bug.cgi?id=51249

Add a new webkit platform plugin interface to support full screen video handler.

  • Api/qwebkitplatformplugin.h: (QWebFullScreenVideoHandler::QWebFullScreenVideoHandler): (QWebFullScreenVideoHandler::~QWebFullScreenVideoHandler):
  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::ChromeClientQt): (WebCore::ChromeClientQt::~ChromeClientQt): (WebCore::ChromeClientQt::fullScreenVideo): (WebCore::ChromeClientQt::supportsFullscreenForNode): (WebCore::ChromeClientQt::requiresFullscreenForVideoPlayback): (WebCore::ChromeClientQt::enterFullscreenForNode): (WebCore::ChromeClientQt::exitFullscreenForNode):
  • WebCoreSupport/ChromeClientQt.h:
  • WebCoreSupport/FullScreenVideoQt.cpp: Added. (WebCore::FullScreenVideoQt::FullScreenVideoQt): (WebCore::FullScreenVideoQt::~FullScreenVideoQt): (WebCore::FullScreenVideoQt::enterFullScreenForNode): (WebCore::FullScreenVideoQt::exitFullScreenForNode): (WebCore::FullScreenVideoQt::aboutToClose): (WebCore::FullScreenVideoQt::mediaPlayer): (WebCore::FullScreenVideoQt::mediaPlayerForNode): (WebCore::FullScreenVideoQt::requiresFullScreenForVideoPlayback):
  • WebCoreSupport/FullScreenVideoQt.h: Added. (WebCore::FullScreenVideoQt::isValid):
  • WebCoreSupport/QtPlatformPlugin.cpp: (WebCore::QtPlatformPlugin::createFullScreenVideoHandler):
  • WebCoreSupport/QtPlatformPlugin.h:
  • examples/platformplugin/WebPlugin.cpp: (FullScreenVideoWidget::FullScreenVideoWidget): (FullScreenVideoWidget::event): (FullScreenVideoWidget::keyPressEvent): (FullScreenVideoHandler::FullScreenVideoHandler): (FullScreenVideoHandler::~FullScreenVideoHandler): (FullScreenVideoHandler::requiresFullScreenForVideoPlayback): (FullScreenVideoHandler::enterFullScreen): (FullScreenVideoHandler::exitFullScreen): (WebPlugin::supportsExtension): (WebPlugin::createExtension):
  • examples/platformplugin/WebPlugin.h: (FullScreenVideoWidget::~FullScreenVideoWidget):
  • examples/platformplugin/platformplugin.pro:
  • examples/platformplugin/qwebkitplatformplugin.h: (QWebFullScreenVideoHandler::QWebFullScreenVideoHandler): (QWebFullScreenVideoHandler::~QWebFullScreenVideoHandler):
07:50 Changeset [75943] by podivilov@chromium.org
  • 5 edits in trunk/LayoutTests

2011-01-17 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: fix flaky debugger tests.
https://bugs.webkit.org/show_bug.cgi?id=51320

  • http/tests/inspector/debugger-test2.js: (initialize_DebuggerTest.InspectorTest.setBreakpoint):
  • inspector/debugger-breakpoints-not-activated-on-reload.html:
  • inspector/debugger-pause-on-breakpoint-expected.txt:
  • inspector/debugger-pause-on-breakpoint.html:
07:42 Changeset [75942] by ossy@webkit.org
  • 2 edits in trunk/Tools

Unreviewed.

Remove accidentally committed debug printing after r75908.

  • Scripts/webkitdirs.pm:
07:38 Changeset [75941] by ossy@webkit.org
  • 280 edits
    556 adds in trunk/LayoutTests

Unreviewed.

Add Qt specific expected results for passing CSS tests.
Compared to Mac png files and Mac expected files.

  • platform/qt/Skipped: Unskip passing tests.
  • platform/qt/css1/[...]: Added.
  • platform/qt/css2.1/[...]: Added.
  • platform/qt/css3/[...]: Added.
06:59 Changeset [75940] by rik@webkit.org
  • 6 edits in trunk

2011-01-17 Anthony Ricaud <rik@webkit.org>

Reviewed by Kent Tamura.

[HTML5] Revert display:none on datalist
https://bugs.webkit.org/show_bug.cgi?id=52214

  • fast/forms/datalist-expected.txt:
  • fast/forms/datalist-nonoption-child-expected.txt:
  • fast/forms/datalist.html:

2011-01-17 Anthony Ricaud <rik@webkit.org>

Reviewed by Kent Tamura.

[HTML5] Revert display:none on datalist
https://bugs.webkit.org/show_bug.cgi?id=52214

  • css/html.css:
06:31 Changeset [75939] by pfeldman@chromium.org
  • 13 edits in trunk/Source

2011-01-17 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: simplify debugger enabling routine.
https://bugs.webkit.org/show_bug.cgi?id=52472

  • inspector/Inspector.idl:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::restoreDebugger): (WebCore::InspectorController::showAndEnableDebugger): (WebCore::InspectorController::enableDebugger):
  • inspector/InspectorController.h:
  • inspector/front-end/DebuggerModel.js:
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.show): (WebInspector.ScriptsPanel.prototype._toggleDebugging):

2011-01-17 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: simplify debugger enabling routine.
https://bugs.webkit.org/show_bug.cgi?id=52472

2011-01-17 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: simplify debugger enabling routine.
https://bugs.webkit.org/show_bug.cgi?id=52472

  • WebInspector.cpp: (WebInspector::toggleDebuggingJavaScript):

2011-01-17 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: simplify debugger enabling routine.
https://bugs.webkit.org/show_bug.cgi?id=52472

  • WebProcess/WebPage/WebInspector.cpp: (WebKit::WebInspector::startJavaScriptDebugging):
06:25 Changeset [75938] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-01-17 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Chromium: updated DevTools tests.

  • src/js/Tests.js: (.TestSuite.prototype._waitForScriptPause): (.TestSuite.prototype._waitUntilScriptsAreParsed.waitForAllScripts): (.TestSuite.prototype._waitUntilScriptsAreParsed):
06:13 Changeset [75937] by podivilov@chromium.org
  • 9 edits in trunk

2011-01-17 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: refactoring: encapsulate lazy initialization of SourceFrame.
https://bugs.webkit.org/show_bug.cgi?id=51738

  • http/tests/inspector/debugger-test2.js: (initialize_DebuggerTest.InspectorTest.showScriptSource): (initialize_DebuggerTest.InspectorTest._showScriptSource):
  • inspector/debugger-pause-in-eval-script-expected.txt:
  • inspector/debugger-pause-in-eval-script.html:

2011-01-17 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: refactoring: encapsulate lazy initialization of SourceFrame.
https://bugs.webkit.org/show_bug.cgi?id=51738

Extract content loading logic from SourceView and ScriptView to ContentProvider implementations.
Pass ContentProvider in SourceFrame constructor to allow SourceFrame manage it's lazy initialization.

  • inspector/front-end/ScriptView.js: (WebInspector.ScriptView): (WebInspector.SourceFrameContentProviderForScript): (WebInspector.SourceFrameContentProviderForScript.prototype.requestContent.didRequestSource): (WebInspector.SourceFrameContentProviderForScript.prototype.requestContent): (WebInspector.SourceFrameContentProviderForScript.prototype.scripts):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._addScript): (WebInspector.ScriptsPanel.prototype.sourceFrameForScript): (WebInspector.ScriptsPanel.prototype._sourceFrameForResource):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame): (WebInspector.SourceFrame.prototype.set visible): (WebInspector.SourceFrame.prototype._createTextViewer): (WebInspector.SourceFrame.prototype._breakpointAdded): (WebInspector.SourceFrame.prototype._breakpoints): (WebInspector.SourceFrame.prototype._sourceIDForLine): (WebInspector.SourceFrame.prototype._sourceIDSet): (WebInspector.SourceFrameContentProvider): (WebInspector.SourceFrameContentProvider.prototype.requestContent): (WebInspector.SourceFrameContentProvider.prototype.scripts):
  • inspector/front-end/SourceView.js: (WebInspector.SourceView): (WebInspector.SourceView.prototype.show): (WebInspector.SourceView.prototype.resize): (WebInspector.SourceView.prototype.performSearch.didFindSearchMatches): (WebInspector.SourceView.prototype.performSearch): (WebInspector.SourceView.prototype.revealLine): (WebInspector.SourceView.prototype.highlightLine): (WebInspector.SourceView.prototype._jumpToSearchResult): (WebInspector.SourceFrameContentProviderForResource): (WebInspector.SourceFrameContentProviderForResource.prototype.requestContent): (WebInspector.SourceFrameContentProviderForResource.prototype.scripts):
06:09 Changeset [75936] by jknotten@chromium.org
  • 2 edits in trunk/Tools

2011-01-17 John Knottenbelt <jknotten@chromium.org>

Unreviewed.

Add myself to committers list
https://bugs.webkit.org/show_bug.cgi?id=52566

  • Scripts/webkitpy/common/config/committers.py:
05:28 Changeset [75935] by kbalazs@webkit.org
  • 4 edits in trunk/Source/WebKit2

2011-01-17 Balazs Kelemen <kbalazs@webkit.org>

Reviewed by Andreas Kling.

[Qt][WK2] Crash due to double destruction of QSharedMemory
https://bugs.webkit.org/show_bug.cgi?id=52569

Avoid deleting the QSharedMemory twice.

  • Platform/qt/SharedMemoryQt.cpp: (WebKit::SharedMemory::~SharedMemory):
  • Shared/qt/CleanupHandler.cpp: Renamed m_inDeleteObjects to m_hasStartedDeleting and added a getter for it. (WebKit::CleanupHandler::CleanupHandler): (WebKit::CleanupHandler::deleteObjects):
  • Shared/qt/CleanupHandler.h: (WebKit::CleanupHandler::unmark): (WebKit::CleanupHandler::hasStartedDeleting):
04:21 Changeset [75934] by jknotten@chromium.org
  • 9 edits
    4 adds in trunk

2011-01-17 John Knottenbelt <jknotten@chromium.org>

Reviewed by Jeremy Orlow.

GeolocationController should call stopUpdating on destruction
https://bugs.webkit.org/show_bug.cgi?id=52216

fast/dom/window-close-crash.html tests that we do not fail the
assertion in the mock GeolocationClient that the GeolocationClient
is not updating when the GeolocationController is destroyed.

  • fast/dom/Geolocation/resources/window-close-popup.html: Added.
  • fast/dom/Geolocation/script-tests/window-close-crash.js: Added. (gotPosition): (waitForWindowToClose): (failedToCreateWatch):
  • fast/dom/Geolocation/window-close-crash-expected.txt: Added.
  • fast/dom/Geolocation/window-close-crash.html: Added.
  • platform/gtk/Skipped:
  • platform/mac-wk2/Skipped:
  • platform/qt-wk2/Skipped:

2011-01-17 John Knottenbelt <jknotten@chromium.org>

Reviewed by Jeremy Orlow.

GeolocationController should call stopUpdating on destruction
https://bugs.webkit.org/show_bug.cgi?id=52216

Test: fast/dom/Geolocation/window-close-crash.html

  • page/GeolocationController.cpp: (WebCore::GeolocationController::~GeolocationController):

2011-01-17 John Knottenbelt <jknotten@chromium.org>

Reviewed by Jeremy Orlow.

GeolocationController should call stopUpdating on destruction
https://bugs.webkit.org/show_bug.cgi?id=52216

fast/dom/Geolocation/window-close-crash.html requires that a
Geolocation watch be started in a secondary window. Consequently,
we need to allow geolocation permission and provide a mock
geolocation position for the secondary window's
GeolocationClientMock.

  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::setGeolocationPermission): (LayoutTestController::setMockGeolocationPosition): (LayoutTestController::setMockGeolocationError):
  • DumpRenderTree/chromium/TestShell.h: (TestShell::windowList):
03:02 Changeset [75933] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-01-17 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: Qt build fix.

  • inspector/InspectorInstrumentation.h:
02:44 Changeset [75932] by pfeldman@chromium.org
  • 30 edits in trunk/Source/WebCore

2011-01-16 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: make WebCore use InspectorInstrumentation
for instrumentation calls.
https://bugs.webkit.org/show_bug.cgi?id=52532

This change makes WebCore classes issue instrumentation signals
by means of InspectorInstrumentation interface. It covered migration
for Document, FrameLoader, Database, DOMStorage, etc. It fixed
instrumentation handling for Console as well. This all is a part
of story described in the bug 52510.

  • dom/Document.cpp: (WebCore::Document::finishedParsing):
  • dom/Document.h:
  • dom/ScriptExecutionContext.h:
  • inspector/InspectorBrowserDebuggerAgent.cpp: (WebCore::InspectorBrowserDebuggerAgent::InspectorBrowserDebuggerAgent): (WebCore::InspectorBrowserDebuggerAgent::setDOMBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::removeDOMBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::willInsertDOMNode): (WebCore::InspectorBrowserDebuggerAgent::willRemoveDOMNode): (WebCore::InspectorBrowserDebuggerAgent::willModifyDOMAttr): (WebCore::InspectorBrowserDebuggerAgent::descriptionForDOMEvent): (WebCore::InspectorBrowserDebuggerAgent::pauseOnNativeEventIfNeeded): (WebCore::InspectorBrowserDebuggerAgent::willSendXMLHttpRequest):
  • inspector/InspectorBrowserDebuggerAgent.h: (WebCore::InspectorBrowserDebuggerAgent::create):
  • inspector/InspectorConsoleAgent.cpp: (WebCore::InspectorConsoleAgent::stopTiming): (WebCore::InspectorConsoleAgent::count):
  • inspector/InspectorConsoleAgent.h:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::~InspectorController): (WebCore::InspectorController::handleMousePress): (WebCore::InspectorController::didClearWindowObjectInWorld): (WebCore::PostWorkerNotificationToFrontendTask::performTask):
  • inspector/InspectorController.h:
  • inspector/InspectorDOMAgent.h:
  • inspector/InspectorDOMStorageAgent.h:
  • inspector/InspectorDatabaseAgent.cpp:
  • inspector/InspectorDatabaseAgent.h:
  • inspector/InspectorFrontendHost.cpp:
  • inspector/InspectorFrontendHost.h:
  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::didClearWindowObjectInWorldImpl): (WebCore::InspectorInstrumentation::inspectedPageDestroyedImpl): (WebCore::InspectorInstrumentation::mouseDidMoveOverElementImpl): (WebCore::InspectorInstrumentation::handleMousePressImpl): (WebCore::InspectorInstrumentation::mainResourceFiredLoadEventImpl): (WebCore::InspectorInstrumentation::mainResourceFiredDOMContentEventImpl): (WebCore::InspectorInstrumentation::frameDetachedFromParentImpl): (WebCore::InspectorInstrumentation::didCommitLoadImpl): (WebCore::InspectorInstrumentation::addMessageToConsoleImpl): (WebCore::InspectorInstrumentation::consoleCountImpl): (WebCore::InspectorInstrumentation::startConsoleTimingImpl): (WebCore::InspectorInstrumentation::stopConsoleTimingImpl): (WebCore::InspectorInstrumentation::consoleMarkTimelineImpl): (WebCore::InspectorInstrumentation::addStartProfilingMessageToConsoleImpl): (WebCore::InspectorInstrumentation::didOpenDatabaseImpl): (WebCore::InspectorInstrumentation::didUseDOMStorageImpl): (WebCore::InspectorInstrumentation::didCreateWorkerImpl): (WebCore::InspectorInstrumentation::didDestroyWorkerImpl): (WebCore::InspectorInstrumentation::didCreateWebSocketImpl): (WebCore::InspectorInstrumentation::willSendWebSocketHandshakeRequestImpl): (WebCore::InspectorInstrumentation::didReceiveWebSocketHandshakeResponseImpl): (WebCore::InspectorInstrumentation::didCloseWebSocketImpl): (WebCore::InspectorInstrumentation::networkStateChangedImpl): (WebCore::InspectorInstrumentation::updateApplicationCacheStatusImpl):
  • inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::inspectorControllerCreated): (WebCore::InspectorInstrumentation::inspectorControllerDeleted): (WebCore::InspectorInstrumentation::didClearWindowObjectInWorld): (WebCore::InspectorInstrumentation::inspectedPageDestroyed): (WebCore::InspectorInstrumentation::willInsertDOMNode): (WebCore::InspectorInstrumentation::didInsertDOMNode): (WebCore::InspectorInstrumentation::willRemoveDOMNode): (WebCore::InspectorInstrumentation::willModifyDOMAttr): (WebCore::InspectorInstrumentation::didModifyDOMAttr): (WebCore::InspectorInstrumentation::mouseDidMoveOverElement): (WebCore::InspectorInstrumentation::handleMousePress): (WebCore::InspectorInstrumentation::characterDataModified): (WebCore::InspectorInstrumentation::willSendXMLHttpRequest): (WebCore::InspectorInstrumentation::didScheduleResourceRequest): (WebCore::InspectorInstrumentation::didInstallTimer): (WebCore::InspectorInstrumentation::didRemoveTimer): (WebCore::InspectorInstrumentation::willCallFunction): (WebCore::InspectorInstrumentation::willChangeXHRReadyState): (WebCore::InspectorInstrumentation::willDispatchEvent): (WebCore::InspectorInstrumentation::willDispatchEventOnWindow): (WebCore::InspectorInstrumentation::willEvaluateScript): (WebCore::InspectorInstrumentation::willFireTimer): (WebCore::InspectorInstrumentation::willLayout): (WebCore::InspectorInstrumentation::willLoadXHR): (WebCore::InspectorInstrumentation::willPaint): (WebCore::InspectorInstrumentation::willRecalculateStyle): (WebCore::InspectorInstrumentation::identifierForInitialRequest): (WebCore::InspectorInstrumentation::willSendRequest): (WebCore::InspectorInstrumentation::markResourceAsCached): (WebCore::InspectorInstrumentation::didLoadResourceFromMemoryCache): (WebCore::InspectorInstrumentation::willReceiveResourceData): (WebCore::InspectorInstrumentation::willReceiveResourceResponse): (WebCore::InspectorInstrumentation::didReceiveContentLength): (WebCore::InspectorInstrumentation::didFinishLoading): (WebCore::InspectorInstrumentation::didFailLoading): (WebCore::InspectorInstrumentation::resourceRetrievedByXMLHttpRequest): (WebCore::InspectorInstrumentation::scriptImported): (WebCore::InspectorInstrumentation::mainResourceFiredLoadEvent): (WebCore::InspectorInstrumentation::mainResourceFiredDOMContentEvent): (WebCore::InspectorInstrumentation::frameDetachedFromParent): (WebCore::InspectorInstrumentation::didCommitLoad): (WebCore::InspectorInstrumentation::willWriteHTML): (WebCore::InspectorInstrumentation::didOpenDatabase): (WebCore::InspectorInstrumentation::didUseDOMStorage): (WebCore::InspectorInstrumentation::didCreateWorker): (WebCore::InspectorInstrumentation::didDestroyWorker): (WebCore::InspectorInstrumentation::didCreateWebSocket): (WebCore::InspectorInstrumentation::willSendWebSocketHandshakeRequest): (WebCore::InspectorInstrumentation::didReceiveWebSocketHandshakeResponse): (WebCore::InspectorInstrumentation::didCloseWebSocket): (WebCore::InspectorInstrumentation::networkStateChanged): (WebCore::InspectorInstrumentation::updateApplicationCacheStatus): (WebCore::InspectorInstrumentation::addMessageToConsole): (WebCore::InspectorInstrumentation::consoleCount): (WebCore::InspectorInstrumentation::startConsoleTiming): (WebCore::InspectorInstrumentation::stopConsoleTiming): (WebCore::InspectorInstrumentation::consoleMarkTimeline): (WebCore::InspectorInstrumentation::addStartProfilingMessageToConsole): (WebCore::InspectorInstrumentation::inspectorControllerForContext): (WebCore::InspectorInstrumentation::inspectorControllerForFrame): (WebCore::InspectorInstrumentation::inspectorControllerForPage): (WebCore::InspectorInstrumentation::inspectorControllerWithFrontendForContext): (WebCore::InspectorInstrumentation::inspectorControllerWithFrontendForDocument): (WebCore::InspectorInstrumentation::inspectorControllerWithFrontendForFrame): (WebCore::InspectorInstrumentation::inspectorControllerWithFrontendForPage):
  • inspector/InspectorState.cpp:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::detachFromParent): (WebCore::FrameLoader::dispatchDidClearWindowObjectInWorld): (WebCore::FrameLoader::dispatchDidCommitLoad):
  • page/Chrome.cpp: (WebCore::Chrome::mouseDidMoveOverElement):
  • page/Console.cpp: (WebCore::Console::addMessage): (WebCore::Console::count): (WebCore::Console::markTimeline): (WebCore::Console::profile): (WebCore::Console::time): (WebCore::Console::timeEnd): (WebCore::Console::group): (WebCore::Console::groupCollapsed): (WebCore::Console::groupEnd):
  • page/DOMWindow.cpp: (WebCore::DOMWindow::sessionStorage): (WebCore::DOMWindow::localStorage): (WebCore::DOMWindow::dispatchLoadEvent):
  • page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEvent):
  • page/Page.cpp: (WebCore::Page::~Page):
  • storage/Database.cpp: (WebCore::Database::openDatabase):
  • workers/AbstractWorker.cpp: (WebCore::AbstractWorker::onDestroyWorker):
  • workers/SharedWorker.cpp: (WebCore::SharedWorker::create):
  • workers/Worker.cpp: (WebCore::Worker::create):
  • workers/WorkerMessagingProxy.cpp:
02:15 Changeset [75931] by abarth@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-01-17 Adam Barth <abarth@webkit.org>

Update path to reflect new WebKit directory location.

  • tests/WebFrameTest.cpp: (WebKit::WebFrameTest::registerMockedURLLoad):
02:08 Changeset [75930] by loislo@chromium.org
  • 3 edits in trunk/LayoutTests

2011-01-14 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Enable inspector's tests for chromium Linux.
https://bugs.webkit.org/show_bug.cgi?id=52445

  • platform/chromium/inspector/timeline-network-resource-expected.txt:
  • platform/chromium/test_expectations.txt:
01:40 Changeset [75929] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Source/WebCore

2011-01-17 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Unreviewed, rolling out r75923.

GTK guy rolls out the r75914.

  • platform/efl/ScrollViewEfl.cpp: (WebCore::ScrollView::platformInit):
01:26 Changeset [75928] by philn@webkit.org
  • 3 edits in trunk/Source/WebKit/gtk

2011-01-17 Philippe Normand <pnormand@igalia.com>

Unreviewed, build fix for 2 GTK tests html file paths.

  • tests/testmimehandling.c: (main):
  • tests/testwebview.c:
01:25 Changeset [75927] by commit-queue@webkit.org
  • 4 edits in trunk

2011-01-17 Helder Correia <helder@sencha.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] fast/canvas/canvas-fillPath-gradient-shadow.html does not pass
https://bugs.webkit.org/show_bug.cgi?id=52556

The shadow color opacity needs to be set on the shadow painter.
Additionally, the gradient brush should be transformed.

  • platform/qt/Skipped: Remove test from skipped list.

2011-01-17 Helder Correia <helder@sencha.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] fast/canvas/canvas-fillPath-gradient-shadow.html does not pass
https://bugs.webkit.org/show_bug.cgi?id=52556

The shadow color opacity needs to be set on the shadow painter.
Additionally, the gradient brush should be transformed.

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::fillPath):
00:50 Changeset [75926] by noam.rosenthal@nokia.com
  • 2 edits in trunk/Source/WebCore

2011-01-17 No'am Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Background image rendering is slow
https://bugs.webkit.org/show_bug.cgi?id=50527

When tiling a scaled pixmap in Image::drawPattern, scale the tile
first and only then draw it to the target. Do so only when drawing
more than one tile.

Tests in fast/backgrounds/size cover this.

  • platform/graphics/qt/ImageQt.cpp: (WebCore::Image::drawPattern):
00:28 Changeset [75925] by laszlo.1.gombos@nokia.com
  • 2 edits in trunk/Source/WebCore

2011-01-17 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Simon Hausmann.

[Qt] [Symbian] Fix building NPAPI support
https://bugs.webkit.org/show_bug.cgi?id=51981

Make sure that npapi.h is always included outside of the extern "C"
linkage declaration block.

No new tests as there is no new functionality.

  • bridge/npruntime.h:
00:26 Changeset [75924] by philn@webkit.org
  • 6 edits in trunk

2011-01-17 Philippe Normand <pnormand@igalia.com>

Unreviewed, rolling out r75914.
http://trac.webkit.org/changeset/75914
https://bugs.webkit.org/show_bug.cgi?id=49177

multiple crashes on GTK

  • platform/gtk/Skipped:

2011-01-17 Philippe Normand <pnormand@igalia.com>

Unreviewed, rolling out r75914.
http://trac.webkit.org/changeset/75914
https://bugs.webkit.org/show_bug.cgi?id=49177

multiple crashes on GTK

  • platform/ScrollView.cpp: (WebCore::ScrollView::removeChild): (WebCore::ScrollView::wheelEvent):
  • platform/gtk/MainFrameScrollbarGtk.cpp: (MainFrameScrollbarGtk::attachAdjustment): (MainFrameScrollbarGtk::gtkValueChanged):
  • platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollView::platformInit): (WebCore::ScrollView::platformAddChild): (WebCore::ScrollView::platformRemoveChild):
00:05 Changeset [75923] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Source/WebCore

2011-01-17 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Unreviewed build fix.

Bug 49177's patch enabled platformInit() in super class(ScrollView).
But, it didn't removed the function in ScrollViewEfl.cpp.

  • platform/efl/ScrollViewEfl.cpp:

01/16/11:

23:54 Changeset [75922] by tkent@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-01-16 Kent Tamura <tkent@chromium.org>

Unreviewed, Chromium-linux build fix.

  • gyp_webkit: Fix a relative path to the top directory.
23:50 Changeset [75921] by mrowe@apple.com
  • 2 edits in tags/Safari-534.15.13/WebCore

Merge r75916.

23:49 Changeset [75920] by mrowe@apple.com
  • 2 edits in tags/Safari-534.15.13/WebCore

Merge r75906.

23:49 Changeset [75919] by mrowe@apple.com
  • 5 edits in tags/Safari-534.15.13

Versioning.

23:37 Changeset [75918] by abarth@webkit.org
  • 4 edits in trunk/Tools

2011-01-16 Adam Barth <abarth@webkit.org>

Update more include paths to reflect WebKit move.

  • DumpRenderTree/chromium/EventSender.cpp: (EventSender::keyDown): (EventSender::needsShiftModifier):
  • DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
  • DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
23:29 Changeset [75917] by tkent@chromium.org
  • 2 edits in trunk/Tools

2011-01-16 Kent Tamura <tkent@chromium.org>

Unreviewed, Chromium build fix.

  • Scripts/update-webkit-chromium: Webkit/chromium -> Source/WebKit/chromium
23:11 Changeset [75916] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

<rdar://problem/8871903> REGRESSION (r75897): Crash with 0-by-0 iframe in scaled WebView

Reviewed by Sam Weinig.

Avoid use of FloatRect::enclosingBoundingBox(), which can stretch an empty
quad to a non-empty rect.

  • rendering/RenderWidget.cpp:

(WebCore::RenderWidget::setWidget):
(WebCore::RenderWidget::updateWidgetPosition):

22:52 Changeset [75915] by abarth@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-01-16 Adam Barth <abarth@webkit.org>

Roll Chromium DEPS to pick up the changes reflecting the new location
of WebKit.

  • DEPS:
22:24 Changeset [75914] by mrobinson@webkit.org
  • 6 edits in trunk

2011-01-16 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] fast/events/scroll-after-click-on-tab-index has been failing on the bots
https://bugs.webkit.org/show_bug.cgi?id=49177

  • platform/gtk/Skipped: Unskip this test, as it's now passing.

2011-01-16 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] fast/events/scroll-after-click-on-tab-index has been failing on the bots
https://bugs.webkit.org/show_bug.cgi?id=49177

  • platform/ScrollView.cpp: Move the platform guards around a little. GTK+ now shares the implementation of platformAddChild and platformRemoveChild, but has its own implementation of removeChild, which knows how to inform main frame scrollbars that they no longer control the WebCore scrollbar.
  • platform/gtk/MainFrameScrollbarGtk.cpp: (MainFrameScrollbarGtk::attachAdjustment): If we are attaching the same adjustment that we already have, bail out early. Apply the value changed signal handler after configuring the adjustment. We don't want our reset of the adjustment to stomp on WebCore values. (MainFrameScrollbarGtk::gtkValueChanged): Do not adjust the value if the WebCore state already matches ours. This prevents some unnecessary recursion
  • platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollView::removeChild): Added, special cases main frame scrollbars which need their adjustments detached.
22:23 Changeset [75913] by mrowe@apple.com
  • 1 copy in tags/Safari-534.15.13

New tag.

22:20 Changeset [75912] by yuzo@google.com
  • 5 edits in trunk/Source/WebCore

2011-01-13 Yuzo Fujishima <yuzo@google.com>

Reviewed by Antti Koivisto.

Fix for Bug 52427 - Inconsistent use of m_cache in CachedResourceLoader
https://bugs.webkit.org/show_bug.cgi?id=52427

In constructor/destructor of CachedResourceLoader, m_cache has been
used to call MemoryCache::addCachedResourceLoader/removeCachedResourceLoader
while cache() is used everywhere else.

Actually addCachedResourceLoader/removeCachedResourceLoader need not be called at all.
Remove the call sites and make MemoryCache non-friend of CachedResourceLoader.

No new tests because the behavior remains the same.

  • loader/cache/CachedResourceLoader.cpp: (WebCore::CachedResourceLoader::CachedResourceLoader): (WebCore::CachedResourceLoader::~CachedResourceLoader):
  • loader/cache/CachedResourceLoader.h:
  • loader/cache/MemoryCache.cpp:
  • loader/cache/MemoryCache.h:
21:59 Changeset [75911] by mrobinson@webkit.org
  • 2 edits in trunk/Tools

2011-01-16 Martin Robinson <mrobinson@igalia.com>

Build fix for GTK+ after source directory movement.

  • GNUmakefile.am: Correct include paths.
21:09 Changeset [75910] by abarth@webkit.org
  • 2 edits in trunk/Tools

2011-01-16 Adam Barth <abarth@webkit.org>

Teach svn-apply about WebKit move.

  • Scripts/VCSUtils.pm:
21:04 Changeset [75909] by abarth@webkit.org
  • 1 move in trunk/Source/WebKit

Move WebKit into Source

21:02 Changeset [75908] by abarth@webkit.org
  • 48 edits in trunk

2011-01-16 Adam Barth <abarth@webkit.org>

Rubber-stamped by Eric Seidel.

Move WebKit into Source
https://bugs.webkit.org/show_bug.cgi?id=52530

  • WebKit.grd:
  • WebKit.gyp:

2011-01-16 Adam Barth <abarth@webkit.org>

Rubber-stamped by Eric Seidel.

Move WebKit into Source
https://bugs.webkit.org/show_bug.cgi?id=52530

  • Api/DerivedSources.pro:
  • declarative/declarative.pro:
  • docs/docs.pri:
  • tests/tests.pri:

2011-01-16 Adam Barth <abarth@webkit.org>

Rubber-stamped by Eric Seidel.

Move WebKit into Source
https://bugs.webkit.org/show_bug.cgi?id=52530

  • GNUmakefile.am:

2011-01-16 Adam Barth <abarth@webkit.org>

Rubber-stamped by Eric Seidel.

Move WebKit into Source
https://bugs.webkit.org/show_bug.cgi?id=52530

  • GNUmakefile.am:

2011-01-16 Adam Barth <abarth@webkit.org>

Rubber-stamped by Eric Seidel.

Move WebKit into Source
https://bugs.webkit.org/show_bug.cgi?id=52530

  • Makefile:
  • scripts/generate-webkitversion.pl:

2011-01-16 Adam Barth <abarth@webkit.org>

Rubber-stamped by Eric Seidel.

Move WebKit into Source
https://bugs.webkit.org/show_bug.cgi?id=52530

  • WebKit.vcproj/Interfaces.vcproj:
  • WebKit.vcproj/WebKit.sln:
  • WebKit.vcproj/WebKit.vcproj:
  • WebKit.vcproj/WebKitGUID.vcproj:

2011-01-16 Adam Barth <abarth@webkit.org>

Rubber-stamped by Eric Seidel.

Move WebKit into Source
https://bugs.webkit.org/show_bug.cgi?id=52530

  • Android.mk:
  • CMakeLists.txt:
  • DerivedSources.pro:
  • GNUmakefile.am:
  • Makefile:
  • WebKit.pri:
  • WebKit.pro:
  • configure.ac:
  • wscript:

2011-01-16 Adam Barth <abarth@webkit.org>

Rubber-stamped by Eric Seidel.

Move WebKit into Source
https://bugs.webkit.org/show_bug.cgi?id=52530

  • DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
  • DumpRenderTree/qt/DumpRenderTreeQt.cpp:
  • DumpRenderTree/qt/DumpRenderTreeQt.h:
  • DumpRenderTree/qt/GCControllerQt.cpp:
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:
  • DumpRenderTree/qt/PlainTextControllerQt.cpp:
  • DumpRenderTree/qt/TextInputControllerQt.cpp:
  • DumpRenderTree/wscript:
  • QtTestBrowser/launcherwindow.h:
  • Scripts/build-webkit:
  • Scripts/webkitdirs.pm:

2011-01-16 Adam Barth <abarth@webkit.org>

Rubber-stamped by Eric Seidel.

Move WebKit into Source
https://bugs.webkit.org/show_bug.cgi?id=52530

2011-01-16 Adam Barth <abarth@webkit.org>

Rubber-stamped by Eric Seidel.

Move WebKit into Source
https://bugs.webkit.org/show_bug.cgi?id=52530

  • WebCore.gyp/WebCore.gyp:
  • WebCore.pri:
  • WebCore.pro:
20:21 Changeset [75907] by mitz@apple.com
  • 2 edits in trunk/WebKit/mac

Assertion failure (!inSetWindow) with in-process plug-in in plugins/destroy-on-setwindow.html
https://bugs.webkit.org/show_bug.cgi?id=52550

Reviewed by Simon Fraser.

  • Plugins/WebNetscapePluginView.mm:

(-[WebNetscapePluginView setWindowIfNecessary]): Removed the assertion, making sure
that inSetWindow remains YES until we exit the top-level setWindowIfNecessary.

19:49 Changeset [75906] by simon.fraser@apple.com
  • 2 edits in trunk/Source/WebCore

2011-01-16 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

frame-removed-during-resize.html test crashes (shows up as image-map-2.html crash)
https://bugs.webkit.org/show_bug.cgi?id=52549

Fix regression from r75900; m_widget->setFrameRect() can run script that
clears m_widget, so null-check it before calling setBoundsSize().

Tested by fast/replaced/frame-removed-during-resize.html

  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::setWidgetGeometry):
18:31 Changeset [75905] by mrowe@apple.com
  • 3 edits in tags/Safari-534.15.12/WebKit/mac

Merge r75893.

18:31 Changeset [75904] by mrowe@apple.com
  • 11 edits in tags/Safari-534.15.12

Merge r75897.

18:31 Changeset [75903] by mrowe@apple.com
  • 4 edits
    2 adds in tags/Safari-534.15.12

Merge r75720.

18:30 Changeset [75902] by mrowe@apple.com
  • 2 edits in tags/Safari-534.15.12/WebCore

Merge r75892.

18:30 Changeset [75901] by mrowe@apple.com
  • 5 edits in tags/Safari-534.15.12

Versioning.

18:01 Changeset [75900] by simon.fraser@apple.com
  • 2 edits in trunk/Source/WebCore

2011-01-16 Simon Fraser <simon.fraser@apple.com>

Keep Leopard build happy.

  • platform/mac/WidgetMac.mm: (WebCore::Widget::setBoundsSize):
17:52 Changeset [75899] by oliver@apple.com
  • 5 edits in trunk

2011-01-16 Oliver Hunt <oliver@apple.com>

Reviewed by Sam Weinig.

[jsfunfuzz] Parser doesn't correctly validate for-loop syntax
https://bugs.webkit.org/show_bug.cgi?id=52516

Add test for the case where a syntax error immediately follows
multiple declarations in a for-loop initialiser.

  • fast/js/parser-syntax-check-expected.txt:
  • fast/js/script-tests/parser-syntax-check.js:

2011-01-16 Oliver Hunt <oliver@apple.com>

Reviewed by Sam Weinig.

[jsfunfuzz] Parser doesn't correctly validate for-loop syntax
https://bugs.webkit.org/show_bug.cgi?id=52516

Ensure that we always check for a semicolon after encountering
multiple declarations in the initialiser portion of a for-loop.

  • parser/JSParser.cpp: (JSC::JSParser::parseForStatement):
17:20 Changeset [75898] by mrowe@apple.com
  • 1 copy in tags/Safari-534.15.12

New tag.

17:07 Changeset [75897] by simon.fraser@apple.com
  • 11 edits in trunk

2011-01-16 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

Issues with iframes and plugins when the WebView is scaled.
<rdar://problem/6213380>

When _scaleWebView has been called on a WebView, iframes
in WebKit1 render and hit-test incorrectly, and plug-ins don't scale up.
This is caused by AppKit NSViews not playing nicely with the scale
applied through style.

Work around most of these issues by adjusting the bounds size
of widgets to allow iframe contents to paint with the correct scale,
and fix various places in the code where we relied on coordinate
transforms via NSViews (which ignore CSS transforms).

  • WebCore.exp.in:
  • platform/Widget.cpp: (WebCore::Widget::setBoundsSize):
  • platform/Widget.h:
  • platform/mac/WidgetMac.mm: (WebCore::Widget::setBoundsSize): (WebCore::Widget::paint):
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::shouldPropagateCompositingToEnclosingIFrame):
  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::setWidgetGeometry): (WebCore::RenderWidget::setWidget): (WebCore::RenderWidget::updateWidgetPosition):
  • rendering/RenderWidget.h:
15:54 Changeset [75896] by oliver@apple.com
  • 7 edits in trunk

2011-01-16 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

Strict mode restrictions on arguments and eval usage aren't complete
https://bugs.webkit.org/show_bug.cgi?id=52528

Add a helper function to aid parse failure tests by testing both direct
eval/global code, and nested code (so that we test the syntax checker
mode as well)

  • fast/js/basic-strict-mode-expected.txt:
  • fast/js/script-tests/basic-strict-mode.js: (shouldBeSyntaxError):

2011-01-16 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

Strict mode restrictions on arguments and eval usage aren't complete
https://bugs.webkit.org/show_bug.cgi?id=52528

Fix a few bugs in strict mode where we incorrect allow mutation of
arguments and eval in the parser.

Alas the "optimisation" used by the syntax checker for validating
binary and unary expressions was too aggressive: we do actually need
a stack for operations and operands although it needn't be as complete
as that used for the full AST builder.

Also disallow assignment to arguments in all cases as allowing arguments
to be assignable is always an error in strict mode, regardless of context.

  • parser/ASTBuilder.h: (JSC::ASTBuilder::BinaryExprContext::BinaryExprContext): (JSC::ASTBuilder::UnaryExprContext::UnaryExprContext):
  • parser/JSParser.cpp: (JSC::JSParser::parseAssignmentExpression): (JSC::JSParser::parseBinaryExpression): (JSC::JSParser::parseUnaryExpression):
  • parser/SyntaxChecker.h: (JSC::SyntaxChecker::BinaryExprContext::BinaryExprContext): (JSC::SyntaxChecker::BinaryExprContext::~BinaryExprContext): (JSC::SyntaxChecker::UnaryExprContext::UnaryExprContext): (JSC::SyntaxChecker::UnaryExprContext::~UnaryExprContext): (JSC::SyntaxChecker::appendBinaryExpressionInfo): (JSC::SyntaxChecker::operatorStackPop):
14:08 Changeset [75895] by robert@webkit.org
  • 2 edits in trunk/LayoutTests

2011-01-16 Robert Hogan <robert@webkit.org>

Unreviewed, re-skip test after r75894.

[Qt] plugins/keyboard-events.html fails after r72717

Re-skip plugins/keyboard-events.html.
Using XKeysymToKeycode(QX11Info::display(), ..) doesn't work on
a headless build, such as the buildbot. So need to solve this a
different way.

https://bugs.webkit.org/show_bug.cgi?id=50050

  • platform/qt/Skipped:
13:08 Changeset [75894] by robert@webkit.org
  • 4 edits in trunk

2011-01-16 Robert Hogan <robert@webkit.org>

Reviewed by Andreas Kling.

[Qt] plugins/keyboard-events.html fails after r72717
https://bugs.webkit.org/show_bug.cgi?id=50050

  • platform/qt/Skipped: Unskip plugins/keyboard-events.html

2011-01-16 Robert Hogan <robert@webkit.org>

Reviewed by Andreas Kling.

[Qt] plugins/keyboard-events.html fails after r72717
https://bugs.webkit.org/show_bug.cgi?id=50050

  • plugins/qt/PluginViewQt.cpp: (WebCore::setXKeyEventSpecificFields): map event text to keycode
12:59 Changeset [75893] by bdakin@apple.com
  • 3 edits in trunk/WebKit/mac

Fix for <rdar://problem/8871204>

Reviewed by Kevin Decker.

Don't try to save elasticity state. Just rely on
NSScrollElasticityAutomatic to restore the correct state.

  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::WebFrameLoaderClient):
(WebFrameLoaderClient::dispatchDidFirstLayout):
(WebFrameLoaderClient::provisionalLoadStarted):

10:04 Changeset [75892] by simon.fraser@apple.com
  • 2 edits in trunk/Source/WebCore

2011-01-16 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

RenderView needs to take transforms on its layer into account
https://bugs.webkit.org/show_bug.cgi?id=52536

The RenderView's coordinate mapping methods failed to
take into account a transform on the RenderView's layer.

No tests because it's not possible to get a transform
on the RenderView's layer through content.

  • rendering/RenderView.cpp: (WebCore::RenderView::mapLocalToContainer): (WebCore::RenderView::mapAbsoluteToLocalPoint):

01/15/11:

21:11 Changeset [75891] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2011-01-15 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Rolled back in r75886.
https://bugs.webkit.org/show_bug.cgi?id=52527


r75886 broke the GTK Linux bot because Linux was -- quite surprisingly --
set up to use the constants for embedded devices.

  • jit/ExecutableAllocatorFixedVMPool.cpp: (JSC::maybeModifyVMPoolSize): Separated Linux constants from embedded constants.
20:22 Changeset [75890] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-01-15 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r75886.
http://trac.webkit.org/changeset/75886
https://bugs.webkit.org/show_bug.cgi?id=52526

"Broke GTK+ 64bit" (Requested by xan_ on #webkit).

  • jit/ExecutableAllocatorFixedVMPool.cpp:
18:14 Changeset [75889] by ddkilzer@apple.com
  • 2 edits in trunk/LayoutTests

Skip fast/dom/Range/range-clone-contents.html on Windows

Not reviewed.

Filed: <https://bugs.webkit.org/show_bug.cgi?id=52524>

  • platform/win/Skipped: Skip test on Windows. The test passes

on all other bots.

16:57 Changeset [75888] by mrowe@apple.com
  • 5 edits in tags/Safari-534.15.9/WebKit/mac

Merge r75873.

16:57 Changeset [75887] by mrowe@apple.com
  • 5 edits in tags/Safari-534.15.9

Versioning.

15:48 Changeset [75886] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

<rdar://problem/8870429> Shrink the executable pool on embedded devices

Reviewed by Sam Weinig.

  • jit/ExecutableAllocatorFixedVMPool.cpp: Dropped the pool size from 32MB

to 16MB.

15:41 Changeset [75885] by commit-queue@webkit.org
  • 14 edits
    2 deletes in trunk

2011-01-15 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r75708.
http://trac.webkit.org/changeset/75708
https://bugs.webkit.org/show_bug.cgi?id=52521

Breaks Qt build if mobility is not installed. (Requested by
benjaminp on #webkit).

  • WebCore.pro:
  • platform/graphics/qt/MediaPlayerPrivateQt.cpp: (WebCore::MediaPlayerPrivateQt::MediaPlayerPrivateQt):
  • platform/graphics/qt/MediaPlayerPrivateQt.h: (WebCore::MediaPlayerPrivateQt::supportsFullscreen):

2011-01-15 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r75708.
http://trac.webkit.org/changeset/75708
https://bugs.webkit.org/show_bug.cgi?id=52521

Breaks Qt build if mobility is not installed. (Requested by
benjaminp on #webkit).

  • Api/qwebkitplatformplugin.h:
  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::ChromeClientQt): (WebCore::ChromeClientQt::~ChromeClientQt):
  • WebCoreSupport/ChromeClientQt.h:
  • WebCoreSupport/FullScreenVideoQt.cpp: Removed.
  • WebCoreSupport/FullScreenVideoQt.h: Removed.
  • WebCoreSupport/QtPlatformPlugin.cpp:
  • WebCoreSupport/QtPlatformPlugin.h:
  • examples/platformplugin/WebPlugin.cpp: (WebPlugin::supportsExtension): (WebPlugin::createExtension):
  • examples/platformplugin/WebPlugin.h:
  • examples/platformplugin/platformplugin.pro:
  • examples/platformplugin/qwebkitplatformplugin.h:
15:39 Changeset [75884] by oliver@apple.com
  • 5 edits in trunk

2011-01-15 Oliver Hunt <oliver@apple.com>

Reviewed by Maciej Stachowiak.

Incorrect behavior changing attributes of an accessor
https://bugs.webkit.org/show_bug.cgi?id=52515

defineProperty doesn't correctly handle changing attributes of an accessor
property. This is because we don't pass the full descriptor to the
putDescriptor helper function, which means we have insufficient information
to do the right thing. Once that's passed the correct behavior is relatively
simple to implement.

  • runtime/JSObject.cpp: (JSC::putDescriptor): (JSC::JSObject::defineOwnProperty):
15:33 Changeset [75883] by mrowe@apple.com
  • 1 copy in tags/Safari-534.15.9

New tag.

12:44 Changeset [75882] by ddkilzer@apple.com
  • 3 edits
    2 adds in trunk

<http://webkit.org/b/52512> REGRESSION(r73818): range.cloneContents() ignores end offset

Reviewed by Adele Peterson.

WebCore:

The fix for Bug 50710 in r73799 introduced an off-by-one error
when copying nodes to a local NodeVector for processing. A fix
was attempted for Bug 50854 in r73818, but instead of stopping
at the end offset, it iterates through all the sibling nodes
because the loop variable (i) is never incremented. To clean
this up, revert back to the code in r73799 and fix the
off-by-one error.

Test: fast/dom/Range/range-clone-contents.html

  • dom/Range.cpp:

(WebCore::Range::processContents): Fix the loop that copies
nodes to a local NodeVector by restoring the code from r73799
and fixing the off-by-one error.

LayoutTests:

  • fast/dom/Range/range-clone-contents-expected.txt: Added.
  • fast/dom/Range/range-clone-contents.html: Added.
12:04 Changeset [75881] by abarth@webkit.org
  • 2 edits in trunk/Tools

2011-01-15 Adam Barth <abarth@webkit.org>

Teach svn-apply about WebKit2 move.

  • Scripts/VCSUtils.pm:
12:02 Changeset [75880] by abarth@webkit.org
  • 32 edits
    1 move in trunk

Move WebKit2 into Source
https://bugs.webkit.org/show_bug.cgi?id=52438

Rubber-stamped by Eric Seidel.

.:

Update reference to WebKit2.

  • DerivedSources.pro:
  • GNUmakefile.am:
  • Makefile:
  • Source/cmake/WebKitPackaging.cmake:
  • WebKit.pro:
  • configure.ac:

Source/WebCore:

  • WebCore.pro:

Source/WebKit2:

  • DerivedSources.pro:
  • GNUmakefile.am:
  • WebKit2.pro:
  • WebProcess.pro:
  • win/WebKit2.vcproj:
  • win/WebKit2WebProcess.vcproj:

Tools:

  • MiniBrowser/qt/MiniBrowser.pro:
  • Scripts/build-webkit:
  • Scripts/do-file-rename:
  • Scripts/do-webcore-rename:
  • Scripts/test-webkitpy:
  • Scripts/webkitdirs.pm:
  • Scripts/webkitpy/style/checker.py:
  • WebKitTestRunner/DerivedSources.pro:
  • WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
  • WebKitTestRunner/qt/WebKitTestRunner.pro:

WebKit/win:

Update reference to WebKit2.

  • WebKit.vcproj/WebKit.sln:

Websites/bugs.webkit.org:

Remove WebKit2 from the list of top-level source directories.

  • PrettyPatch/PrettyPatch.rb:
11:26 Changeset [75879] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-01-15 Joone Hur <joone.hur@collabora.co.uk>

Reviewed by Martin Robinson.

[GTK] Linux build with FileSystem API enabled fails
https://bugs.webkit.org/show_bug.cgi?id=43878

This patch allows WebKitGtk+ to build with FileSystem API option.

No new tests because no new functionality.

  • GNUmakefile.am: Included AsyncFileSystem.h,cpp and Excluded duplicated JSFileException.h,cpp.
  • bindings/js/JSDirectoryEntryCustom.cpp: Included ExceptionCode.h.
06:51 Changeset [75878] by robert@webkit.org
  • 4 edits in trunk

2011-01-15 Robert Hogan <robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] plugins/no-mime-with-valid-extension.html fails

Check extension of resource against installed
plugins when determining mime-type.

https://bugs.webkit.org/show_bug.cgi?id=52288
https://bugs.webkit.org/show_bug.cgi?id=50657

  • platform/qt/Skipped:

2011-01-15 Robert Hogan <robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] plugins/no-mime-with-valid-extension.html fails
Check extension of resource against installed
plugins when determining mime-type.

https://bugs.webkit.org/show_bug.cgi?id=52288
https://bugs.webkit.org/show_bug.cgi?id=50657

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::objectContentType):
06:17 Changeset [75877] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

2011-01-15 Stephen White <senorblanco@chromium.org>

Unreviewed; updated chromium test expectations.

  • platform/chromium-gpu/test_expectations.txt:
06:11 Changeset [75876] by senorblanco@chromium.org
  • 3 edits in trunk/LayoutTests

2011-01-15 Stephen White <senorblanco@chromium.org>

Unreviewed; updated chromium test expectations.

  • platform/chromium-gpu/test_expectations.txt:
  • platform/chromium/test_expectations.txt:
01:33 Changeset [75875] by jochen@chromium.org
  • 5 edits in trunk

2011-01-15 Jochen Eisinger <jochen@chromium.org>

Reviewed by David Levin.

[chromium] remove obsolete createView method
https://bugs.webkit.org/show_bug.cgi?id=52437

  • DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::createView):
  • DumpRenderTree/chromium/WebViewHost.h:

2011-01-15 Jochen Eisinger <jochen@chromium.org>

Reviewed by David Levin.

[chromium] remove obsolete createView method
https://bugs.webkit.org/show_bug.cgi?id=52437

  • public/WebViewClient.h: (WebKit::WebViewClient::createView):
00:58 Changeset [75874] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

2011-01-15 Tony Chang <tony@chromium.org>

Unreviewed, add new test to GTK+ Skipped list.
https://bugs.webkit.org/show_bug.cgi?id=52508

  • platform/gtk/Skipped:

01/14/11:

22:48 Changeset [75873] by simon.fraser@apple.com
  • 5 edits in trunk/WebKit/mac

2011-01-14 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

Plugins render incorrectly with transformed ancestors
https://bugs.webkit.org/show_bug.cgi?id=52507

-[NSView visibleRect] gives the wrong answer if there are CSS transforms
in the ancestor chain of a plugin.

So use of this method with calls to -actualVisibleRectInWindow, which
maps rects through the render tree to compute the correct rect,
clipping via windowClipRect() if necessary.

Not testable, because doing so relies on the behavior of some
plugins, which stop rendering if setWindow passes an empty rect.

  • Plugins/Hosted/WebHostedNetscapePluginView.mm: (-[WebHostedNetscapePluginView updateAndSetWindow]):
  • Plugins/WebBaseNetscapePluginView.h:
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView actualVisibleRectInWindow]):
  • Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
22:35 Changeset [75872] by oliver@apple.com
  • 5 edits in trunk

2011-01-14 Oliver Hunt <oliver@apple.com>

Reviewed by Maciej Stachowiak.

[jsfunfuzz] Incorrect handling of consecutive duplicate labels
https://bugs.webkit.org/show_bug.cgi?id=52505

Add a few tests of consecutive labels containing duplicates to the parser check.

  • fast/js/parser-syntax-check-expected.txt:
  • fast/js/script-tests/parser-syntax-check.js:

2011-01-14 Oliver Hunt <oliver@apple.com>

Reviewed by Maciej Stachowiak.

[jsfunfuzz] Incorrect handling of consecutive duplicate labels
https://bugs.webkit.org/show_bug.cgi?id=52505

Compare StringImpl*'s instead of Identifier*'s when looking for duplicate
labels.

  • parser/JSParser.cpp: (JSC::JSParser::parseExpressionOrLabelStatement):
22:01 Changeset [75871] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit/chromium

2011-01-14 Xiyuan Xia <xiyuan@chromium.org>

Reviewed by Darin Fisher.

Prepare Linux WebThemeEngine interface to support new theme parts.
https://bugs.webkit.org/show_bug.cgi?id=52413

  • public/linux/WebThemeEngine.h:
21:38 Changeset [75870] by commit-queue@webkit.org
  • 12 edits in trunk

2011-01-14 Sam Magnuson <smagnuso@gmail.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Compile with QT_NO_GRAPHICSVIEW
https://bugs.webkit.org/show_bug.cgi?id=49750

  • platform/graphics/qt/GraphicsLayerQt.cpp:
  • platform/graphics/qt/GraphicsLayerQt.h:
  • platform/qt/PlatformMouseEventQt.cpp:

2011-01-14 Sam Magnuson <smagnuso@gmail.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Compile with QT_NO_GRAPHICSVIEW
https://bugs.webkit.org/show_bug.cgi?id=49750

  • Api/qgraphicswebview.cpp:
  • Api/qgraphicswebview.h:
  • Api/qwebpage.cpp: (QWebPage::event):
  • Api/qwebpage_p.h:
  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::createPlugin):
  • WebCoreSupport/PageClientQt.cpp:
  • WebCoreSupport/PageClientQt.h:
20:20 Changeset [75869] by dimich@chromium.org
  • 5 edits
    1 delete in trunk/LayoutTests

Not reviewed, update of Chromium test expectations.
Update of files affected by mass rebaseline in r75828 and r75838

  • platform/chromium-mac/animations/3d/state-at-end-event-transform-expected.checksum:
  • platform/chromium-mac/animations/3d/state-at-end-event-transform-expected.png:
  • platform/chromium-mac/plugins/embed-attributes-style-expected.txt: Removed.
  • platform/chromium-mac/svg/custom/svg-curve-with-relative-cordinates-expected.checksum:
  • platform/chromium-mac/svg/custom/svg-curve-with-relative-cordinates-expected.png:
19:53 Changeset [75868] by simon.fraser@apple.com
  • 1 edit in trunk/Source/JavaScriptCore/ChangeLog

2011-01-14 Simon Fraser <simon.fraser@apple.com>

No review.

Initialize m_operationInProgress after r75855.

  • runtime/Heap.cpp: (JSC::Heap::Heap):
19:32 Changeset [75867] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Reverted accidentally committed code from my last checkin.

  • runtime/Heap.cpp:

(JSC::Heap::markRoots):

19:28 Changeset [75866] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Try to fix the GTK bot.

Reviewed by Sam Weinig.

  • runtime/Heap.cpp:

(JSC::Heap::Heap):
(JSC::Heap::markRoots): Kids, remember to initialize your data members.
Knowing is half the battle.

18:33 Changeset [75865] by dimich@chromium.org
  • 2 edits in trunk/LayoutTests

Not reviewed, update of test expectations.
Ignore new test fast/js/js-continue-break-restrictions.html, it fails for V8.

  • platform/chromium/test_expectations.txt:
18:26 Changeset [75864] by ericu@chromium.org
  • 2 edits
    6 adds in trunk/LayoutTests

2011-01-14 Eric Uhrhane <ericu@chromium.org>

Reviewed by David Levin.

Add tests for FileWriterSync
https://bugs.webkit.org/show_bug.cgi?id=50720

  • fast/filesystem/resources/file-writer-sync-truncate-extend.js: Added.
  • fast/filesystem/workers/file-writer-sync-truncate-extend.html: Added.
  • fast/filesystem/workers/file-writer-sync-truncate-extend-expected.txt: Added.
  • fast/filesystem/resources/file-writer-sync-write-overlapped.js: Added.
  • fast/filesystem/workers/file-writer-sync-write-overlapped.html: Added.
  • fast/filesystem/workers/file-writer-sync-write-overlapped-expected.txt: Added.
  • fast/filesystem/resources/file-writer-utils.js: (assert): Make assert throw, rather than continue. (cleanUp): Always call finishJSTest, even without fileEntryForCleanup.
18:22 Changeset [75863] by paroga@webkit.org
  • 3 edits in trunk/WebKit/efl

2011-01-14 Patrick Gansterer <paroga@webkit.org>

Unreviewed. Try to fix EFL build.

  • ewk/ewk_frame.cpp: (ewk_frame_scroll_add): Added WebCore namespace to IntSize.
  • ewk/ewk_view.cpp: (_ewk_view_viewport_attributes_compute): Ditto.
18:14 Changeset [75862] by oliver@apple.com
  • 5 edits in trunk

2011-01-14 Oliver Hunt <oliver@apple.com>

Reviewed by Stephanie Lewis.

[jsfunfuzz] We should be clearing the lexers temporary character buffers when switching to strict mode
https://bugs.webkit.org/show_bug.cgi?id=52501

Add checks for correct behaviour when the strict mode token is immediately followed
by a value that needs a temporary buffer in the lexer.

  • fast/js/basic-strict-mode-expected.txt:
  • fast/js/script-tests/basic-strict-mode.js:

2011-01-14 Oliver Hunt <oliver@apple.com>

Reviewed by Stephanie Lewis.

[jsfunfuzz] We should be clearing the lexers temporary character buffers when switching to strict mode
https://bugs.webkit.org/show_bug.cgi?id=52501

Clear the temporary character buffers used for reading escaped characters and
numbers.

  • parser/Lexer.h: (JSC::Lexer::setOffset):
18:06 Changeset [75861] by tony@chromium.org
  • 4 edits
    2 adds in trunk

2011-01-14 Tony Chang <tony@chromium.org>

Reviewed by Alexey Proskuryakov.

Strip NUL character when copying text on Windows
https://bugs.webkit.org/show_bug.cgi?id=52236

  • editing/pasteboard/copy-null-characters-expected.txt: Added.
  • editing/pasteboard/copy-null-characters.html: Added.

2011-01-14 Tony Chang <tony@chromium.org>

Reviewed by Alexey Proskuryakov.

Strip NUL character when copying text on Windows
https://bugs.webkit.org/show_bug.cgi?id=52236

Test: editing/pasteboard/copy-null-characters.html

  • editing/Editor.cpp: (WebCore::Editor::selectedText):
  • platform/mac/PasteboardMac.mm: (WebCore::Pasteboard::writeSelection): Use editor()->selectedText() which matches the other platforms.
18:00 Changeset [75860] by mrowe@apple.com
  • 4 edits in tags/Safari-534.15.8/WebCore

Merge r75758.

18:00 Changeset [75859] by mrowe@apple.com
  • 3 edits in tags/Safari-534.15.8/WebKit/mac

Merge r75829.

18:00 Changeset [75858] by mrowe@apple.com
  • 5 edits in tags/Safari-534.15.8

Versioning.

17:59 Changeset [75857] by yuzo@google.com
  • 32 edits in trunk

2011-01-14 Yuzo Fujishima <yuzo@google.com>

Reviewed by Antti Koivisto.

Rename cache() to memoryCache()
https://bugs.webkit.org/show_bug.cgi?id=52433

No new tests because the behavior remains the same.

  • WebCore.exp.in:
  • WebCore.order:
  • history/PageCache.cpp: (WebCore::PageCache::releaseAutoreleasedPagesNow):
  • inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::cachedResource):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::tellClientAboutPastMemoryCacheLoads):
  • loader/archive/cf/LegacyWebArchive.cpp: (WebCore::LegacyWebArchive::create):
  • loader/cache/CachedImage.cpp: (WebCore::CachedImage::allClientsRemoved): (WebCore::CachedImage::data):
  • loader/cache/CachedResource.cpp: (WebCore::CachedResource::~CachedResource): (WebCore::CachedResource::addClientToSet): (WebCore::CachedResource::removeClient): (WebCore::CachedResource::setDecodedSize): (WebCore::CachedResource::setEncodedSize): (WebCore::CachedResource::didAccessDecodedData):
  • loader/cache/CachedResourceLoader.cpp: (WebCore::CachedResourceLoader::CachedResourceLoader): (WebCore::CachedResourceLoader::requestUserCSSStyleSheet): (WebCore::CachedResourceLoader::requestResource): (WebCore::CachedResourceLoader::revalidateResource): (WebCore::CachedResourceLoader::loadResource): (WebCore::CachedResourceLoader::clearPreloads): (WebCore::CachedResourceLoader::printPreloadStats):
  • loader/cache/CachedResourceRequest.cpp: (WebCore::CachedResourceRequest::load): (WebCore::CachedResourceRequest::didFail): (WebCore::CachedResourceRequest::didReceiveResponse):
  • loader/cache/MemoryCache.cpp: (WebCore::memoryCache):
  • loader/cache/MemoryCache.h:

2011-01-14 Yuzo Fujishima <yuzo@google.com>

Reviewed by Antti Koivisto.

Rename cache() to memoryCache()
https://bugs.webkit.org/show_bug.cgi?id=52433

  • src/WebCache.cpp: (WebKit::WebCache::setCapacities): (WebKit::WebCache::clear): (WebKit::WebCache::getUsageStats): (WebKit::WebCache::getResourceTypeStats):

2011-01-14 Yuzo Fujishima <yuzo@google.com>

Reviewed by Antti Koivisto.

Rename cache() to memoryCache()
https://bugs.webkit.org/show_bug.cgi?id=52433

  • webkit/webkitglobals.cpp: (webkit_set_cache_model):

2011-01-14 Yuzo Fujishima <yuzo@google.com>

Reviewed by Antti Koivisto.

Rename cache() to memoryCache()
https://bugs.webkit.org/show_bug.cgi?id=52433

  • Misc/WebCache.mm: (+[WebCache statistics]): (+[WebCache setDisabled:]): (+[WebCache isDisabled]):
  • WebView/WebView.mm: (+[WebView _setCacheModel:]):

2011-01-14 Yuzo Fujishima <yuzo@google.com>

Reviewed by Antti Koivisto.

Rename cache() to memoryCache()
https://bugs.webkit.org/show_bug.cgi?id=52433

  • Api/qwebpage.cpp: (QWebPagePrivate::_q_cleanupLeakMessages):
  • Api/qwebsettings.cpp: (QWebSettings::clearMemoryCaches): (QWebSettings::setObjectCacheCapacities):

2011-01-14 Yuzo Fujishima <yuzo@google.com>

Reviewed by Antti Koivisto.

Rename cache() to memoryCache()
https://bugs.webkit.org/show_bug.cgi?id=52433

  • WebCache.cpp: (WebCache::statistics): (WebCache::empty): (WebCache::setDisabled): (WebCache::disabled):
  • WebView.cpp: (WebView::setCacheModel):

2011-01-14 Yuzo Fujishima <yuzo@google.com>

Reviewed by Antti Koivisto.

Rename cache() to memoryCache()
https://bugs.webkit.org/show_bug.cgi?id=52433

  • WebView.cpp: (wxWebView::SetCachePolicy):

2011-01-14 Yuzo Fujishima <yuzo@google.com>

Reviewed by Antti Koivisto.

Rename cache() to memoryCache()
https://bugs.webkit.org/show_bug.cgi?id=52433

  • WebProcess/WebProcess.cpp: (WebKit::WebProcess::shutdownIfPossible): (WebKit::WebProcess::didClose):
  • WebProcess/mac/WebProcessMac.mm: (WebKit::WebProcess::platformSetCacheModel):
  • WebProcess/win/WebProcessWin.cpp: (WebKit::WebProcess::platformSetCacheModel):
17:52 Changeset [75856] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Try to fix non-Dtrace builds: #include Tracing.h instead of TracingDtrace.h.

  • runtime/Heap.cpp:
17:43 Changeset [75855] by ggaren@apple.com
  • 18 edits
    2 copies in trunk

2011-01-13 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Split out a MarkedSpace strategy object from Heap.
https://bugs.webkit.org/show_bug.cgi?id=52421

  • Misc/WebCoreStatistics.mm: (+[WebCoreStatistics memoryStatistics]): Updated for class move.

2011-01-13 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Split out a MarkedSpace strategy object from Heap.
https://bugs.webkit.org/show_bug.cgi?id=52421


SunSpider reports no change.

  • runtime/Heap.cpp: (JSC::Heap::Heap): (JSC::Heap::destroy): (JSC::Heap::recordExtraCost): (JSC::Heap::allocate): (JSC::Heap::markConservatively): (JSC::Heap::markRoots): (JSC::Heap::objectCount): (JSC::Heap::statistics): (JSC::Heap::size): (JSC::Heap::isBusy): (JSC::Heap::collectAllGarbage): (JSC::Heap::primaryHeapBegin): (JSC::Heap::primaryHeapEnd):
  • runtime/Heap.h: (JSC::Heap::globalData): (JSC::Heap::markedSpace): (JSC::Heap::isCellMarked): (JSC::Heap::checkMarkCell): (JSC::Heap::markCell): Moved all code pertaining to managing chunks of collector memory out of this class. Heap now just delegates to MarkedSpace.
  • runtime/JSCell.h: (JSC::JSCell::Heap::heap): Updated for MarkedSpace delegation.
  • runtime/JSValue.h: Moved the ValueStringPair typedef to help with #includes.
  • runtime/MarkedSpace.cpp: Copied from runtime/Heap.cpp. (JSC::MarkedSpace::MarkedSpace): (JSC::MarkedSpace::destroy): (JSC::MarkedSpace::allocateBlock): (JSC::MarkedSpace::freeBlock): (JSC::MarkedSpace::allocate): (JSC::MarkedSpace::resizeBlocks): (JSC::MarkedSpace::growBlocks): (JSC::MarkedSpace::shrinkBlocks): (JSC::MarkedSpace::markConservatively): (JSC::MarkedSpace::clearMarkBits): (JSC::MarkedSpace::markedCells): (JSC::MarkedSpace::sweep): (JSC::MarkedSpace::objectCount): (JSC::MarkedSpace::addToStatistics): (JSC::MarkedSpace::statistics): (JSC::MarkedSpace::size): (JSC::MarkedSpace::reset): (JSC::MarkedSpace::primaryHeapBegin): (JSC::MarkedSpace::primaryHeapEnd):
  • runtime/MarkedSpace.h: Copied from runtime/Heap.h. (JSC::MarkedSpace::globalData): (JSC::MarkedSpace::didShrink): (JSC::MarkedSpace::cellBlock): (JSC::MarkedSpace::cellOffset): (JSC::MarkedSpace::isCellMarked): (JSC::MarkedSpace::checkMarkCell): (JSC::MarkedSpace::markCell): Moved all code pertaining to managing chunks of collector memory into this class.
  • runtime/MemoryStatistics.cpp: (JSC::heapStatistics):
  • runtime/MemoryStatistics.h: Updated for MarkedSpace delegation.

2011-01-13 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Split out a MarkedSpace strategy object from Heap.
https://bugs.webkit.org/show_bug.cgi?id=52421

  • Shared/mac/WebMemorySampler.mac.mm: (WebKit::WebMemorySampler::sampleWebKit): Updated for class move.
17:40 Changeset [75854] by thakis@chromium.org
  • 5 edits in trunk/LayoutTests

2011-01-14 Nico Weber <thakis@chromium.org>

Unreviewed, test expectations.

Rebaseline gradient test due to updated skia. reed checked the test and
says the new look is right and is an intentional change.
https://bugs.webkit.org/show_bug.cgi?id=52105

  • platform/chromium-linux/svg/batik/paints/gradientLimit-expected.checksum:
  • platform/chromium-linux/svg/batik/paints/gradientLimit-expected.png:
  • platform/chromium-win/svg/batik/paints/gradientLimit-expected.checksum:
  • platform/chromium-win/svg/batik/paints/gradientLimit-expected.png:
17:31 Changeset [75853] by andersca@apple.com
  • 10 edits in trunk/WebKit2

2011-01-14 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Add a new PageClient::displayView function and expose it on WebPageProxy
https://bugs.webkit.org/show_bug.cgi?id=52500

  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm: (WebKit::PageClientImpl::displayView):
  • UIProcess/API/qt/qwkpage.cpp: (QWKPagePrivate::displayView):
  • UIProcess/API/qt/qwkpage_p.h:
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::displayView):
  • UIProcess/WebPageProxy.h:
  • UIProcess/win/WebView.cpp: (WebKit::WebView::displayView):
  • UIProcess/win/WebView.h:
17:22 Changeset [75852] by oliver@apple.com
  • 5 edits
    3 adds in trunk

2011-01-14 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

[jsfunfuzz] parser doesn't enforce continue restrictions correctly.
https://bugs.webkit.org/show_bug.cgi?id=52493

Add a few tests for continue to cover the cases where continue
isn't syntactically valid.

  • fast/js/js-continue-break-restrictions-expected.txt: Added.
  • fast/js/js-continue-break-restrictions.html: Added.
  • fast/js/script-tests/js-continue-break-restrictions.js: Added.

2011-01-14 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

[jsfunfuzz] parser doesn't enforce continue restrictions correctly.
https://bugs.webkit.org/show_bug.cgi?id=52493

This patch reworks handling of break, continue and label statements
to correctly handle all the valid and invalid cases. Previously certain
errors would be missed by the parser in strict mode, but the bytecode
generator needed to handle those cases for non-strict code so nothing
failed, it simply became non-standard behaviour.

Now that we treat break and continue errors as early faults in non-strict
mode as well that safety net has been removed so the parser bugs result in
crashes at codegen time.

  • parser/JSParser.cpp: (JSC::JSParser::ScopeLabelInfo::ScopeLabelInfo): (JSC::JSParser::next): (JSC::JSParser::nextTokenIsColon): (JSC::JSParser::continueIsValid):

Continue is only valid in loops so we can't use breakIsValid()

(JSC::JSParser::pushLabel):

We now track whether the label is for a loop (and is therefore a
valid target for continue.

(JSC::JSParser::popLabel):
(JSC::JSParser::getLabel):

Replace hasLabel with getLabel so that we can validate the target
when parsing continue statements.

(JSC::JSParser::Scope::continueIsValid):
(JSC::JSParser::Scope::pushLabel):
(JSC::JSParser::Scope::getLabel):
(JSC::JSParser::JSParser):
(JSC::JSParser::parseBreakStatement):
(JSC::JSParser::parseContinueStatement):
(JSC::LabelInfo::LabelInfo):
(JSC::JSParser::parseExpressionOrLabelStatement):

Consecutive labels now get handled iteratively so that we can determine
whether they're valid targets for continue.

  • parser/Lexer.cpp: (JSC::Lexer::nextTokenIsColon):
  • parser/Lexer.h: (JSC::Lexer::setOffset):
17:20 Changeset [75851] by mitz@apple.com
  • 5 edits
    1 add in trunk

Source/WebCore: WebCore part of <rdar://problem/8441312> Crash in -[NSView _invalidateGStatesForTree]

Reviewed by Simon Fraser.

  • WebCore.exp.in: Export RenderWidget::suspendWidgetHierarchyUpdates() and

RenderWidget::resumeWidgetHierarchyUpdates().

  • manual-tests/plug-in-mutates-NSView-hierarchy-during-resize.html: Added.
  • rendering/RenderWidget.cpp:

(WebCore::RenderWidget::setWidgetGeometry): Removed the assertion that widget hierarchy updates
are disabled. When this assertion was added, this condition was a subset of the “calling out to
plug-in code is forbidden” condition, hence the assertion was valid. The WebKit part of this
change now suspends widget hierarchy updates even at times where plug-in code is expected to be
called, which invalidates the assertion.

WebKit/mac: WebKit/mac part of <rdar://problem/8441312> Crash in -[NSView _invalidateGStatesForTree]

Reviewed by Simon Fraser.

  • WebView/WebHTMLView.mm:

(-[WebHTMLView _invalidateGStatesForTree]): Override this NSView method, and bracket the call
to the superclass implementation with suspending WebCore Widget hierarchy updates. This ensures
that the NSView tree doesn’t change from under AppKit as it traverses it.

17:19 Changeset [75850] by commit-queue@webkit.org
  • 2 edits in trunk

2011-01-14 Ahmad Sharif <asharif.tools@gmail.com>

Reviewed by Darin Fisher.

When inlining is performed, the progress variable is
declared as uninitialized.
https://bugs.webkit.org/show_bug.cgi?id=51084

  • WebCore: Copied from WebCore.
  • WebCore/page/animation/KeyframeAnimation.cpp: (WebCore::KeyframeAnimation::animate): (WebCore::KeyframeAnimation::getAnimatedStyle):
17:18 Changeset [75849] by andersca@apple.com
  • 2 edits in trunk/WebKit2

2011-01-14 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Implement the "should paint bounds instead of indiviual rects" algorithm from WebKit1
https://bugs.webkit.org/show_bug.cgi?id=52499

  • WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::shouldPaintBoundsRect): Port code from -[WebView _mustDrawUnionedRect:singleRects:count:].

(WebKit::DrawingAreaImpl::display):
If shouldPaintBoundsRect returns true, clear the rects vector and append the bounds rect.

17:17 Changeset [75848] by tonyg@chromium.org
  • 4 edits in trunk

2011-01-14 Tony Gentilcore <tonyg@chromium.org>

Unreviewed build fix.

Fix Qt build after r75837
https://bugs.webkit.org/show_bug.cgi?id=52494

  • rendering/style/StyleRareInheritedData.cpp:
  • rendering/style/StyleRareNonInheritedData.cpp:
17:15 Changeset [75847] by ojan@chromium.org
  • 2 edits in trunk/Websites/bugs.webkit.org

2011-01-14 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

fix expanded lines in the code review tool
https://bugs.webkit.org/show_bug.cgi?id=52498

Fixes them to work now that we have wrapper divs.
Also fixes the long-standing bug that the line numbers
were incorrect sometimes.

  • code-review.js:
17:08 Changeset [75846] by tonyg@chromium.org
  • 4 edits in trunk

2011-01-14 Tony Gentilcore <tonyg@chromium.org>

Unreviewed build fix.

Fix Qt build after r75837
https://bugs.webkit.org/show_bug.cgi?id=52494

  • rendering/style/RenderStyle.cpp:

2011-01-14 Tony Gentilcore <tonyg@chromium.org>

Unreviewed build fix.

Fix Qt build after r75837
https://bugs.webkit.org/show_bug.cgi?id=52494

  • ewk/ewk_view.cpp:
17:02 Changeset [75845] by ojan@chromium.org
  • 3 edits in trunk/Websites/bugs.webkit.org

2011-01-14 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

put remove lines to the left of add lines in sidebyside view
https://bugs.webkit.org/show_bug.cgi?id=52458

Also, sneaking in a fix to make long lines with no whitespace wrap.

  • PrettyPatch/PrettyPatch.rb:
  • code-review.js:
17:00 Changeset [75844] by tonyg@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-01-14 Tony Gentilcore <tonyg@chromium.org>

Unreviewed build fix.

Fix Qt build after r75837
https://bugs.webkit.org/show_bug.cgi?id=52494

  • editing/EditorCommand.cpp:
16:55 Changeset [75843] by tonyg@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-01-14 Tony Gentilcore <tonyg@chromium.org>

Unreviewed build fix.

Fix Qt build after r75837
https://bugs.webkit.org/show_bug.cgi?id=52494

  • editing/ApplyStyleCommand.cpp:
16:44 Changeset [75842] by tonyg@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-01-14 Tony Gentilcore <tonyg@chromium.org>

Unreviewed build fix.

Fix Qt build after r75837
https://bugs.webkit.org/show_bug.cgi?id=52494

  • css/CSSStyleSelector.cpp:
16:42 Changeset [75841] by mjs@apple.com
  • 3 edits in trunk/LayoutTests

2011-01-14 Maciej Stachowiak <mjs@apple.com>

Reviewed by Anders Carlsson.

Fix a few things in the WebKit2 skipped list
https://bugs.webkit.org/show_bug.cgi?id=52484

  • platform/mac-wk2/Skipped: Add/remove some tests to the WK2 skipped list.
  • editing/style/stylewithcss-without-selection.html: Fix this test to avoid referencing an undefined variable in the failure case.
16:35 Changeset [75840] by tonyg@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-01-14 Tony Gentilcore <tonyg@chromium.org>

Unreviewed build fix.

Fix Qt build after r75837
https://bugs.webkit.org/show_bug.cgi?id=52494

  • rendering/InlineFlowBox.h:
  • rendering/RenderBoxModelObject.h:
16:29 Changeset [75839] by paroga@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-01-14 Patrick Gansterer <paroga@webkit.org>

Reviewed by Adam Roben.

Use the Windows thread pool instead of an extra thread for FastMalloc scavenging
https://bugs.webkit.org/show_bug.cgi?id=45186

  • wtf/FastMalloc.cpp: (WTF::TCMalloc_PageHeap::scheduleScavenger): Added missing this pointer to CreateTimerQueueTimer().
16:28 Changeset [75838] by mihaip@chromium.org
  • 231 edits
    230 copies
    16 adds in trunk/LayoutTests

2011-01-14 Mihai Parparita <mihaip@chromium.org>

Update the svg/ pixel expectations for the chromium-mac port.

For the pixel tests that currently fail on Snow Leopard, this moves the
current pixel results to platform/chromium-mac-leopard and adds new
results to platform/chromium-mac.

List of files omitted due to length but composed entirely of moves from
platform/chromium-mac to platform/chromium-mac-leopard and newly added
files in platform/chromium-mac.

16:27 Changeset [75837] by tonyg@chromium.org
  • 56 edits in trunk

2011-01-14 Tony Gentilcore <tonyg@chromium.org>

Reviewed by David Levin.

Do some forward declaration in RenderStyle.h
https://bugs.webkit.org/show_bug.cgi?id=52453

No new tests because no new functionality.

  • css/CSSComputedStyleDeclaration.cpp:
  • css/CSSStyleSelector.cpp:
  • editing/Editor.cpp:
  • page/EventHandler.cpp:
  • rendering/EllipsisBox.cpp:
  • rendering/InlineBox.cpp:
  • rendering/InlineTextBox.cpp:
  • rendering/RenderBlock.cpp:
  • rendering/RenderBlock.h:
  • rendering/RenderBox.cpp:
  • rendering/RenderBox.h:
  • rendering/RenderEmbeddedObject.cpp:
  • rendering/RenderFieldset.cpp:
  • rendering/RenderFileUploadControl.cpp:
  • rendering/RenderFrameSet.cpp:
  • rendering/RenderHTMLCanvas.cpp:
  • rendering/RenderImageResource.cpp:
  • rendering/RenderInputSpeech.cpp:
  • rendering/RenderLayer.h:
  • rendering/RenderLineBoxList.cpp:
  • rendering/RenderListBox.cpp:
  • rendering/RenderMediaControlsChromium.cpp:
  • rendering/RenderObject.cpp:
  • rendering/RenderObject.h:
  • rendering/RenderObjectChildList.cpp:
  • rendering/RenderProgress.cpp:
  • rendering/RenderScrollbarPart.cpp:
  • rendering/RenderTable.cpp:
  • rendering/RenderTable.h:
  • rendering/RenderTableCell.cpp:
  • rendering/RenderTableRow.cpp:
  • rendering/RenderTableSection.cpp:
  • rendering/RenderTheme.cpp:
  • rendering/RenderThemeChromiumSkia.cpp:
  • rendering/RenderThemeChromiumWin.cpp:
  • rendering/RootInlineBox.cpp:
  • rendering/style/RenderStyle.cpp:
  • rendering/style/RenderStyle.h:
  • rendering/style/StyleRareInheritedData.cpp:
16:19 Changeset [75836] by jochen@chromium.org
  • 2 edits in trunk/WebKit/chromium

2011-01-14 Jochen Eisinger <jochen@chromium.org>

Unreviewed, roll chromium deps to r71432.

  • DEPS:
16:16 Changeset [75835] by rniwa@webkit.org
  • 7 edits in trunk/Source/WebCore

2011-01-14 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Eric Seidel.

Stop instantiating legacy editing positions in AccessibilityRenderObject.cpp, Element.cpp,
BreakBlockquoteCommand.cpp, CompositeEditCommand.cpp, and DeleteButtonController.cpp
https://bugs.webkit.org/show_bug.cgi?id=52481

Removed instantiation of legacy editing positions.
Calls to Position::Position are replaced by calls to Position's convenience functions.


Also fixed firstPositionInOrBeforeNode and lastPositionInOrAfterNode so that
they instantiate right positions for text nodes.

  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::setSelectedTextRange):
  • dom/Element.cpp: (WebCore::Element::updateFocusAppearance):
  • editing/BreakBlockquoteCommand.cpp: (WebCore::BreakBlockquoteCommand::doApply):
  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::inputText): (WebCore::CompositeEditCommand::rebalanceWhitespaceAt): (WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary): (WebCore::CompositeEditCommand::moveParagraphs): (WebCore::CompositeEditCommand::breakOutOfEmptyListItem): (WebCore::CompositeEditCommand::breakOutOfEmptyMailBlockquotedParagraph): (WebCore::CompositeEditCommand::splitTreeToNode):
  • editing/DeleteButtonController.cpp: (WebCore::enclosingDeletableElement):
  • editing/htmlediting.h: (WebCore::firstPositionInOrBeforeNode): Instantiates firstPositionInNode instead of positionBeforeNode for a text node. (WebCore::lastPositionInOrAfterNode): Ditto.
16:10 Changeset [75834] by mrowe@apple.com
  • 1 copy in tags/Safari-534.15.8

New tag.

15:46 Changeset [75833] by commit-queue@webkit.org
  • 5 edits
    3 adds in trunk

2011-01-14 Helder Correia <helder@sencha.com>

Reviewed by Simon Fraser.

Shadow is not drawn when filling a path with a gradient
https://bugs.webkit.org/show_bug.cgi?id=51982

This happens in CG and is related to bug 51869, this time to be fixed
in GraphicsContext::fillPath(const Path& path). We need to draw the
gradient clipped to the path on a CGLayer first, and then draw the
layer on the GraphicsContext.

  • fast/canvas/canvas-fillPath-gradient-shadow-expected.txt: Added.
  • fast/canvas/canvas-fillPath-gradient-shadow.html: Added.
  • fast/canvas/script-tests/canvas-fillPath-gradient-shadow.js: Added.
  • platform/chromium/test_expectations.txt: Skipping new test since it fails.
  • platform/qt/Skipped: Ditto.

2011-01-14 Helder Correia <helder@sencha.com>

Reviewed by Simon Fraser.

Shadow is not drawn when filling a path with a gradient
https://bugs.webkit.org/show_bug.cgi?id=51982

This happens in CG and is related to bug 51869, this time to be fixed
in GraphicsContext::fillPath(const Path& path). We need to draw the
gradient clipped to the path on a CGLayer first, and then draw the
layer on the GraphicsContext.

Test: fast/canvas/canvas-fillPath-gradient-shadow.html

  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::fillPath):
15:45 Changeset [75832] by simon.fraser@apple.com
  • 5 edits in trunk/Source/WebCore

2011-01-14 Simon Fraser <simon.fraser@apple.com>

Reviewed by Adam Roben.

Layer syncing should go through the compositor
https://bugs.webkit.org/show_bug.cgi?id=52486

Rather than have FrameView go directly to GraphicsLayer to
sync pending changes, route the call through RenderLayerCompositor.

Add a FIXME about an existing issue with flushing and subframes.

No behavior change, so no tests.

  • page/FrameView.cpp: (WebCore::FrameView::syncCompositingStateForThisFrame):
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::notifySyncRequired):
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::scheduleLayerFlush): (WebCore::RenderLayerCompositor::flushPendingLayerChanges):
  • rendering/RenderLayerCompositor.h: (WebCore::RenderLayerCompositor::notifySyncRequired):
15:37 Changeset [75831] by ojan@chromium.org
  • 2 edits in trunk/Websites/bugs.webkit.org

2011-01-14 Ojan Vafai <ojan@chromium.org>

Fix bad merge in r75816.

  • code-review.js:
15:36 Changeset [75830] by paroga@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-01-14 Patrick Gansterer <paroga@webkit.org>

Reviewed by Adam Roben.

Use the Windows thread pool instead of an extra thread for FastMalloc scavenging
https://bugs.webkit.org/show_bug.cgi?id=45186

r75819 accidentally changed the initial state of the scavenge timer.

  • wtf/FastMalloc.cpp: (WTF::TCMalloc_PageHeap::initializeScavenger): Changed initial state of m_scavengingSuspended to true.
15:35 Changeset [75829] by bdakin@apple.com
  • 3 edits in trunk/WebKit/mac

Fix for <rdar://problem/7793902> Artifacts when scrolling
page in Safari while page is loading

Reviewed by Mark Rowe.

Call setDrawsBackground:YES on the scrollView in
dispatchDidFirstLayout() rather than waiting until
frameLoadCompleted(). Also suspend scrolling elasticity
between provisionalLoadStarted() and dispatchDidFirstLayout()

  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::WebFrameLoaderClient):
(WebFrameLoaderClient::dispatchDidFirstLayout):
(WebFrameLoaderClient::provisionalLoadStarted):

15:04 Changeset [75828] by mihaip@chromium.org
  • 248 edits
    247 copies
    28 adds in trunk/LayoutTests

2011-01-14 Mihai Parparita <mihaip@chromium.org>

Update the pixel expectations for the chromium-mac port.

For the pixel tests that currently fail on Snow Leopard, this moves the
current pixel results to platform/chromium-mac-leopard and adds new
results to platform/chromium-mac.

List of files omitted due to length but composed entirely of moves from
platform/chromium-mac to platform/chromium-mac-leopard and newly added
files in platform/chromium-mac.

14:57 Changeset [75827] by paroga@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-01-14 Patrick Gansterer <paroga@webkit.org>

Unreviewed Windows Release build fix.

  • wtf/FastMalloc.cpp: (WTF::TCMalloc_PageHeap::scavengerTimerFired):
14:57 Changeset [75826] by bweinstein@apple.com
  • 6 edits in trunk

ShouldLoadResourceForFrame should use strings, not URLs.
https://bugs.webkit.org/show_bug.cgi?id=52476

Reviewed by Geoff Garen.

Tools:

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::shouldLoadResourceForFrame): Update to use a WKStringRef.

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:

WebKit2:

  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:

(WebKit::InjectedBundlePageLoaderClient::shouldLoadResourceForFrame): Pass resourceURL as a string instead of

a URL, and rename from subresourceURL to resourceURL.

14:49 Changeset [75825] by paroga@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-01-14 Patrick Gansterer <paroga@webkit.org>

Unreviewed Windows Release build fix.

  • wtf/FastMalloc.cpp: (WTF::TCMalloc_PageHeap::scavengerTimerFired):
14:45 Changeset [75824] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

2011-01-14 Steve Lacey <sjl@chromium.org>

Reviewed by Simon Fraser.

Update media/video-zoom-controls.html to set the video source before initializing the test.
https://bugs.webkit.org/show_bug.cgi?id=52461

  • media/video-zoom-controls.html:
14:40 Changeset [75823] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

2011-01-14 Abhishek Arya <inferno@chromium.org>

Reviewed by David Hyatt.

Fix parent block calculation when trying to find top most node
containing "this" float.
https://bugs.webkit.org/show_bug.cgi?id=51711

Replace use of containingBlock and traverse the parents directly
to check for float existence. containingBlock can skip parents and
jump to the RenderView directly which will cause floats to not get
cleared from intermediate parents.

Test: fast/block/float/floats-not-cleared-crash.html

  • rendering/RenderBox.cpp: (WebCore::RenderBox::removeFloatingOrPositionedChildFromBlockLists):

2011-01-14 Abhishek Arya <inferno@chromium.org>

Reviewed by Dave Hyatt.

Tests that we do not crash due to uncleared floats in parent nodes.
https://bugs.webkit.org/show_bug.cgi?id=51711

  • fast/block/float/floats-not-cleared-crash-expected.txt: Added.
  • fast/block/float/floats-not-cleared-crash.html: Added.
14:39 Changeset [75822] by andersca@apple.com
  • 6 edits in trunk/WebKit2

Fix for <rdar://problem/8711576> The web process should be able to read resources from the UI process.

Reviewed by Sam Weinig.

Based on a patch by Ivan Krstić. This also makes the NSURLCache path a sandbox parameter.

  • Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):
Encode and decode the uiProcessBundleResourcePath member variable.

  • Shared/WebProcessCreationParameters.h:

Add uiProcessBundleResourcePath member variable.

  • UIProcess/mac/WebContextMac.mm:

(WebKit::WebContext::platformInitializeWebProcess):
Set the uiProcessBundleResourcePath member variable.

  • WebProcess/com.apple.WebProcess.sb:

Allow read-only access to UI_PROCESS_BUNDLE_RESOURCE_DIR and all subdirectories.

  • WebProcess/mac/WebProcessMac.mm:

(WebKit::initializeSandbox):
When initializing the sandbox, pass UI_PROCESS_BUNDLE_RESOURCE_DIR.

(WebKit::WebProcess::platformInitializeWebProcess):
Remove the code that would consume a sandbox extension for the url cache path.

14:32 Changeset [75821] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

REGRESSION (r75660): compositing/reflections/load-video-in-reflection.html crashes on Windows 7
https://bugs.webkit.org/show_bug.cgi?id=52397

Unskipping tests that no longer fail on Windows 7 Release. Unreviewed.

  • platform/win/Skipped:

Un-skip compositing/reflections/load-video-in-reflection.html, which appears to be fixed by
http://trac.webkit.org/changeset/75807

14:27 Changeset [75820] by ericu@chromium.org
  • 1 edit in trunk/Tools/Scripts/webkitpy/common/config/committers.py

Add ericu@chromium.org [me] to the committers file.

14:21 Changeset [75819] by paroga@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-01-14 Patrick Gansterer <paroga@webkit.org>

Reviewed by Adam Roben.

Use the Windows thread pool instead of an extra thread for FastMalloc scavenging
https://bugs.webkit.org/show_bug.cgi?id=45186

Use CreateTimerQueueTimer() to start periodicScavenge() and stop it with DeleteTimerQueueTimer().

  • wtf/FastMalloc.cpp: (WTF::TCMalloc_PageHeap::initializeScavenger): (WTF::TCMalloc_PageHeap::isScavengerSuspended): (WTF::TCMalloc_PageHeap::scheduleScavenger): (WTF::TCMalloc_PageHeap::rescheduleScavenger): (WTF::TCMalloc_PageHeap::suspendScavenger): (WTF::scavengerTimerFired): (WTF::TCMalloc_PageHeap::periodicScavenge): (WTF::TCMalloc_PageHeap::signalScavenger):
14:15 Changeset [75818] by tonyg@chromium.org
  • 2 edits in trunk/Tools

2011-01-14 Tony Gentilcore <tonyg@chromium.org>

Reviewed by David Levin.

Add Tony Gentilcore as a reviewer
https://bugs.webkit.org/show_bug.cgi?id=52480

  • Scripts/webkitpy/common/config/committers.py:
14:13 Changeset [75817] by ojan@chromium.org
  • 2 edits in trunk/Websites/bugs.webkit.org

2011-01-14 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

improve line selection with fast drags
https://bugs.webkit.org/show_bug.cgi?id=52477

  • code-review.js:
14:08 WebKit Team edited by tonyg@chromium.org
(diff)
14:00 Changeset [75816] by ojan@chromium.org
  • 2 edits in trunk/Websites/bugs.webkit.org

2011-01-14 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

tweak line selection in code review tool
https://bugs.webkit.org/show_bug.cgi?id=52462

-Improve handling of data-comment-base-line code to deal with
lines that have multiple values.
-Make it so that if you click on the line immediately above
a line that has a comment it will add a new comment instead of
adding lines to the following comment. If the last selected line
overlaps existing comment lines though they will still get
added to the existing comment.

  • code-review.js:
13:59 Changeset [75815] by commit-queue@webkit.org
  • 10 edits
    2 moves
    1 delete in trunk

2011-01-14 Adam Klein <adamk@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Replace BackForwardListClient with BackForwardControllerClient/BackForwardList
https://bugs.webkit.org/show_bug.cgi?id=42237

Remove Chromium-specific implementation from WebCore.

No tests added; this refactor should be covered by existing history-exercising tests.

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • history/BackForwardListChromium.cpp: Removed.
  • history/BackForwardListImpl.h:

2011-01-14 Adam Klein <adamk@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Replace BackForwardListClient with BackForwardControllerClient/BackForwardList
https://bugs.webkit.org/show_bug.cgi?id=42237

Replace Chromium-specific BackForwardListClient in WebCore with a Chromium impl
of the BackForwardList interface.

  • WebKit.gyp:
  • src/BackForwardListChromium.cpp: Copied from WebKit/chromium/src/BackForwardListClientImpl.cpp. (WebKit::BackForwardListChromium::create): (WebKit::BackForwardListChromium::BackForwardListChromium): (WebKit::BackForwardListChromium::~BackForwardListChromium): (WebKit::BackForwardListChromium::addItem): (WebKit::BackForwardListChromium::goToItem): (WebKit::BackForwardListChromium::itemAtIndex): (WebKit::BackForwardListChromium::backListCount): (WebKit::BackForwardListChromium::forwardListCount): (WebKit::BackForwardListChromium::isActive): (WebKit::BackForwardListChromium::close):
  • src/BackForwardListChromium.h: Copied from WebKit/chromium/src/BackForwardListClientImpl.h.
  • src/BackForwardListClientImpl.cpp: Removed.
  • src/BackForwardListClientImpl.h: Removed.
  • src/FrameLoaderClientImpl.cpp:
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::loadHistoryItem): (WebKit::WebFrameImpl::currentHistoryItem):
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::WebViewImpl):
  • src/WebViewImpl.h:
13:51 Changeset [75814] by andersca@apple.com
  • 3 edits in trunk/WebKit2

Delay initializing the sandbox until we get the InitializeWebProcess message.

Reviewed by Sam Weinig.

  • WebProcess/mac/WebProcessMac.mm:

(WebKit::initializeSandbox):
(WebKit::WebProcess::platformInitializeWebProcess):

  • WebProcess/mac/WebProcessMainMac.mm:

(WebKit::WebProcessMain):

13:30 Changeset [75813] by levin@chromium.org
  • 3 edits in trunk/Tools

2011-01-14 David Levin <levin@chromium.org>

Reviewed by Eric Seidel.

check-webkit-style: _FunctionState should keep track of where the function name starts.
https://bugs.webkit.org/show_bug.cgi?id=52454

  • Scripts/webkitpy/style/checkers/cpp.py: Added function_name_start_position to _FunctionState and logic for setting it correctly.
  • Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests.
12:43 Changeset [75812] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit/qt

2011-01-14 Konstantin Tokarev <annulen@yandex.ru>

Reviewed by Laszlo Gombos.

[Qt] Fixed compilation when QT_NO_SHORTCUT is defined
https://bugs.webkit.org/show_bug.cgi?id=52460

This patch fixes compilation when QT_NO_SHORTCUT is defined in Qt
configuration.

  • WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::handleKeyboardEvent): Added QT_NO_SHORTCUT guards
12:39 Changeset [75811] by satish@chromium.org
  • 7 edits
    2 adds in trunk

2011-01-12 Satish Sampath <satish@chromium.org>

Reviewed by Dimitri Glazkov.

Fix a crash when accessing speech input from script.
https://bugs.webkit.org/show_bug.cgi?id=52325

Added a layout test to check enabling/disabling speech input from script.

  • fast/speech/speech-input-scripting-expected.txt: Added.
  • fast/speech/speech-input-scripting.html: Added.

2011-01-12 Satish Sampath <satish@chromium.org>

Reviewed by Dimitri Glazkov.

Fix a crash when accessing speech input from script.
https://bugs.webkit.org/show_bug.cgi?id=52325

Test: fast/speech/speech-input-scripting.html

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::parseMappedAttribute): Recreate renderer when speech input is enabled/disabled.
  • rendering/RenderTextControlSingleLine.cpp: Remove unused code.
  • rendering/RenderTextControlSingleLine.h:
  • rendering/TextControlInnerElements.cpp: Take self references before firing events and check for renderer validity after. (WebCore::InputFieldSpeechButtonElement::defaultEventHandler): (WebCore::InputFieldSpeechButtonElement::setRecognitionResult): (WebCore::InputFieldSpeechButtonElement::detach):
12:35 Changeset [75810] by inferno@chromium.org
  • 4 edits
    2 adds in trunk

2011-01-14 Abhishek Arya <inferno@chromium.org>

Reviewed by David Hyatt.

Prevent merging of anonymous blocks if one of them is already getting
destroyed.
https://bugs.webkit.org/show_bug.cgi?id=52402

Test: fast/block/merge-anonymous-block-remove-child-crash2.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::RenderBlock): initialize m_beingDestroyed to false. (WebCore::RenderBlock::destroy): set m_beingDestroyed to true. (WebCore::canMergeContiguousAnonymousBlocks): do not merge if any or prev or next is being destroyed. (WebCore::RenderBlock::removeChild): remove the hack previously done for preventing oldChild merging with nextBlock's next sibling.
  • rendering/RenderBlock.h: (WebCore::RenderBlock::beingDestroyed): public function for m_beingDestroyed.

2011-01-14 Abhishek Arya <inferno@chromium.org>

Reviewed by David Hyatt.

Tests that we do not crash when trying to merge anonymous blocks, one of which
is already getting destroyed.
https://bugs.webkit.org/show_bug.cgi?id=52402

  • fast/block/merge-anonymous-block-remove-child-crash2-expected.txt: Added.
  • fast/block/merge-anonymous-block-remove-child-crash2.html: Added.
12:30 Changeset [75809] by ojan@chromium.org
  • 2 edits in trunk/Websites/bugs.webkit.org

2011-01-14 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Roben.

fix bugs going back and forth between unified and sidebyside
https://bugs.webkit.org/show_bug.cgi?id=52470

Now that we're appending DOM nodes directly, we only want to
get the first ".text" element in the subtree. In the cases
where there are multiple, their contents are the same.

Also, when making side-by-side expansion lines, we need to
clone the contents so we have a second copy to append to the DOM.

  • code-review.js:
12:27 Changeset [75808] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-01-14 Pavel Feldman <pfeldman@chromium.org>

Not reviewed. Follow up to r75791: fix missing dispatch.
https://bugs.webkit.org/show_bug.cgi?id=52442

  • inspector/front-end/DebuggerModel.js: (WebInspector.DebuggerDispatcher.prototype.breakpointResolved):
12:01 Changeset [75807] by simon.fraser@apple.com
  • 2 edits in trunk/Source/WebCore

2011-01-14 Simon Fraser <simon.fraser@apple.com>

Reviewed by Adam Roben.

Issues with contentsScale in GraphicsLayerCA
https://bugs.webkit.org/show_bug.cgi?id=52463

Fix various issues with the recent contentsScale changes:

  • platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::GraphicsLayerCA): Initialize m_contentsScale to 1. (WebCore::GraphicsLayerCA::updateContentsScale): Only do a setNeedsDisplay() if the layer draws content, otherwise we'll create backing store for empty layers. (WebCore::GraphicsLayerCA::swapFromOrToTiledLayer): Be sure to set contentsScale on the new (tiled or untiled) layer. (WebCore::GraphicsLayerCA::cloneLayer): Clones need contentsScale too.
11:50 Changeset [75806] by laszlo.1.gombos@nokia.com
  • 4 edits in trunk

2011-01-14 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Align import/export directives
https://bugs.webkit.org/show_bug.cgi?id=52208

  • API/JSBase.h: Align import/export directives with WebKit2/Shared/API/c/WKBase.h

2011-01-14 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Align import/export directives
https://bugs.webkit.org/show_bug.cgi?id=52208

  • Shared/API/c/WKBase.h: Align import/export directives with JavaScriptCore/API/JSBase.h.
11:16 Changeset [75805] by tkent@chromium.org
  • 4 edits in trunk/WebKit/chromium

2011-01-14 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Fisher.

[Chromium] WebKit API: Add a function for form interactive validation setting
https://bugs.webkit.org/show_bug.cgi?id=52430

  • public/WebSettings.h: Add a pure setInteractiveFormValidationEnabled().
  • src/WebSettingsImpl.cpp: (WebKit::WebSettingsImpl::setInteractiveFormValidationEnabled): Implemented.
  • src/WebSettingsImpl.h: Add a declaration.
10:54 Changeset [75804] by simon.fraser@apple.com
  • 2 edits in trunk/Source/WebCore

2011-01-14 Simon Fraser <simon.fraser@apple.com>

Let Xcode have it's way with the project file.

  • WebCore.xcodeproj/project.pbxproj:
10:53 Changeset [75803] by simon.fraser@apple.com
  • 3 edits in trunk/Source/WebCore

2011-01-14 Simon Fraser <simon.fraser@apple.com>

Reviewed by Anders Carlsson.

Refactor some FrameView::syncCompositingState code
https://bugs.webkit.org/show_bug.cgi?id=52459

Refactor some code in FrameView related to synchronizing
compositing layer state.

  • page/FrameView.cpp: (WebCore::FrameView::syncCompositingStateForThisFrame): (WebCore::FrameView::syncCompositingStateRecursive): (WebCore::FrameView::paintContents):
  • page/FrameView.h:
10:38 Changeset [75802] by tony@chromium.org
  • 12 edits in trunk/LayoutTests

2011-01-14 Tony Chang <tony@chromium.org>

Unreviewed, updating baselines.

[chromium] rebaseline vertical tests on linux
https://bugs.webkit.org/show_bug.cgi?id=52457

After updating fonts.conf, these tests are now passing.

  • platform/chromium-linux/fast/blockflow/japanese-lr-text-expected.checksum:
  • platform/chromium-linux/fast/blockflow/japanese-lr-text-expected.png:
  • platform/chromium-linux/fast/blockflow/japanese-rl-text-expected.checksum:
  • platform/chromium-linux/fast/blockflow/japanese-rl-text-expected.png:
  • platform/chromium-linux/fast/repaint/japanese-rl-selection-clear-expected.checksum:
  • platform/chromium-linux/fast/repaint/japanese-rl-selection-clear-expected.png:
  • platform/chromium-linux/fast/repaint/japanese-rl-selection-repaint-expected.checksum:
  • platform/chromium-linux/fast/repaint/japanese-rl-selection-repaint-expected.png:
  • platform/chromium-linux/svg/batik/text/verticalText-expected.checksum:
  • platform/chromium-linux/svg/batik/text/verticalText-expected.png:
  • platform/chromium/test_expectations.txt:
10:30 Changeset [75801] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-01-14 Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>

Reviewed by Eric Seidel.

[Qt] Fix build problem introduced by http://trac.webkit.org/changeset/75713
https://bugs.webkit.org/show_bug.cgi?id=30179

  • plugins/symbian/PluginViewSymbian.cpp:
10:09 Changeset [75800] by commit-queue@webkit.org
  • 7 edits in trunk

2011-01-14 Vincent Scheib <scheib@chromium.org>

Reviewed by David Levin.

Add support to DumpRenderTree to use the GPU rather than software renderer
https://bugs.webkit.org/show_bug.cgi?id=52333

  • DumpRenderTree/chromium/DumpRenderTree.cpp: (main):
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

2011-01-14 Vincent Scheib <scheib@chromium.org>

Reviewed by David Levin.

Add support to DumpRenderTree to use the GPU rather than software renderer
https://bugs.webkit.org/show_bug.cgi?id=52333

  • DEPS: Moved forward to take required support from webkit_support.h
  • WebKit.gyp: DumpRenderTree depends on Angle on windows
09:35 Changeset [75799] by tony@chromium.org
  • 4 edits in trunk

2011-01-14 Tony Chang <tony@chromium.org>

Reviewed by Kent Tamura.

[chromium] update fonts.conf to fix 6 linux tests in drt
https://bugs.webkit.org/show_bug.cgi?id=52411

  • platform/chromium/test_expectations.txt:

2011-01-14 Tony Chang <tony@chromium.org>

Reviewed by Kent Tamura.

[chromium] update fonts.conf to fix 6 linux tests in drt
https://bugs.webkit.org/show_bug.cgi?id=52411

  • DumpRenderTree/chromium/fonts.conf: Update to match the copy in

chromium's src/webkit/tools/test_shell/resources/fonts.conf

09:27 Changeset [75798] by carlosgc@webkit.org
  • 16 edits
    1 add in trunk

2011-01-14 Philippe Normand <pnormand@igalia.com>

Reviewed by Martin Robinson.

[GTK] Add volume slider to media player
https://bugs.webkit.org/show_bug.cgi?id=51532

  • platform/gtk/Skipped:
  • platform/gtk/media/audio-controls-rendering-expected.txt:
  • platform/gtk/media/controls-after-reload-expected.txt:
  • platform/gtk/media/controls-strict-expected.txt:
  • platform/gtk/media/controls-styling-expected.txt:
  • platform/gtk/media/video-controls-rendering-expected.txt:
  • platform/gtk/media/video-display-toggle-expected.txt:
  • platform/gtk/media/video-empty-source-expected.txt:
  • platform/gtk/media/video-no-audio-expected.txt:
  • platform/gtk/media/video-volume-slider-expected.txt: Added.

2011-01-14 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Add volume slider to media player
https://bugs.webkit.org/show_bug.cgi?id=51532

  • css/mediaControlsGtk.css: (audio::-webkit-media-controls-panel, video::-webkit-media-controls-panel): (audio::-webkit-media-controls-volume-slider-container, video::-webkit-media-controls-volume-slider-container): (audio::-webkit-media-controls-volume-slider, video::-webkit-media-controls-volume-slider):
  • platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::adjustMediaSliderThumbSize): (WebCore::RenderThemeGtk::paintMediaVolumeSliderContainer): (WebCore::RenderThemeGtk::paintMediaVolumeSliderTrack): (WebCore::RenderThemeGtk::paintMediaVolumeSliderThumb):
  • platform/gtk/RenderThemeGtk.h:
  • platform/gtk/RenderThemeGtk2.cpp: (WebCore::RenderThemeGtk::paintSliderTrack): (WebCore::RenderThemeGtk::paintSliderThumb): (WebCore::RenderThemeGtk::adjustSliderThumbSize):
  • platform/gtk/RenderThemeGtk3.cpp: (WebCore::RenderThemeGtk::paintSliderTrack): (WebCore::RenderThemeGtk::paintSliderThumb): (WebCore::RenderThemeGtk::adjustSliderThumbSize):
09:03 Changeset [75797] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-01-14 Joone Hur <joone.hur@collabora.co.uk>

Reviewed by David Levin.

[GTK] Convert use of raw pointers to GOwnPtr in FileSystemGtk.cpp
https://bugs.webkit.org/show_bug.cgi?id=52434

No new tests. This code will be tested when an implementation
of beginDragWithFiles is complete.

  • platform/gtk/FileSystemGtk.cpp: (WebCore::filenameToString): Use GOwnPtr instead of gchar pointer. (WebCore::fileSystemRepresentation): Ditto. (WebCore::filenameForDisplay): Ditto. (WebCore::pathGetFileName): Ditto.
08:02 Changeset [75796] by msaboff@apple.com
  • 5 edits in trunk

2011-01-14 Michael Saboff <msaboff@apple.com>

Reviewed by Oliver Hunt.

Incorrect backtracking for nested alternatives
https://bugs.webkit.org/show_bug.cgi?id=52387

Added tests to verfiy backtracking of alternatives following
parenthesis.

  • fast/regex/parentheses-expected.txt:
  • fast/regex/script-tests/parentheses.js:

2011-01-14 Michael Saboff <msaboff@apple.com>

Reviewed by Oliver Hunt.

Incorrect backtracking for nested alternatives
https://bugs.webkit.org/show_bug.cgi?id=52387

In the process of propigating a datalabel it wasn't getting connected
to a destination when the destination was an indirect jump. Added
code to recognize a direct backtrack destination that was an indirect
jump and added mechanism to associate DataLabelPtrs with indirect
jump entries.
Removed dead method
BacktrackDestination::linkDataLabelToHereIfExists()

  • yarr/YarrJIT.cpp: (JSC::Yarr::YarrGenerator::IndirectJumpEntry::IndirectJumpEntry): (JSC::Yarr::YarrGenerator::IndirectJumpEntry::addDataLabel): (JSC::Yarr::YarrGenerator::GenerationState::addIndirectJumpEntry): (JSC::Yarr::YarrGenerator::GenerationState::emitIndirectJumpTable): Changes to link indirect jumps with DataLabelPtr's. (JSC::Yarr::YarrGenerator::BacktrackDestination::clearSubDataLabelPtr): (JSC::Yarr::YarrGenerator::TermGenerationState::linkDataLabelToBacktrackIfExists): Updated to handle immediate linking of indirect jumps to DataLabelPtr. (JSC::Yarr::YarrGenerator::generateParenthesesDisjunction): Changed to reflect updated linkDataLabelToBacktrackIfExists().
07:58 Changeset [75795] by podivilov@chromium.org
  • 6 edits in trunk/Source/WebCore

2011-01-14 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: breakpoint text snippet in breakpoints sidebar pane disappears after reload.
https://bugs.webkit.org/show_bug.cgi?id=52215

  • inspector/front-end/Breakpoint.js: (WebInspector.Breakpoint): (WebInspector.Breakpoint.prototype.populateLabelElement):
  • inspector/front-end/Script.js: (WebInspector.Script.prototype.get linesCount): (WebInspector.Script.prototype.sourceLine): (WebInspector.Script.prototype.sourceLine.didRequestSource): (WebInspector.Script.prototype.set source): (WebInspector.Script.prototype.requestSource.didGetScriptSource): (WebInspector.Script.prototype.requestSource):
  • inspector/front-end/ScriptView.js: (WebInspector.ScriptView.prototype.setupSourceFrameIfNeeded.didRequestSource): (WebInspector.ScriptView.prototype.setupSourceFrameIfNeeded):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._addBreakpoint):
  • inspector/front-end/utilities.js: (String.prototype.findAll):
07:49 Changeset [75794] by podivilov@chromium.org
  • 13 edits in trunk/Source

2011-01-14 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: provide script column offset to frontend.
https://bugs.webkit.org/show_bug.cgi?id=52377

  • parser/SourceCode.h: (JSC::SourceCode::SourceCode): (JSC::SourceCode::firstColumn):

2011-01-14 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: provide script column offset to frontend.
https://bugs.webkit.org/show_bug.cgi?id=52377

  • bindings/js/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::dispatchDidParseSource):
  • bindings/js/ScriptSourceCode.h: (WebCore::ScriptSourceCode::ScriptSourceCode):
  • bindings/v8/DebuggerScript.js: ():
  • bindings/v8/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::dispatchDidParseSource):
  • inspector/Inspector.idl:
  • inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::didParseSource):
  • inspector/InspectorDebuggerAgent.h:
  • inspector/ScriptDebugListener.h:
  • inspector/front-end/DebuggerModel.js: (WebInspector.DebuggerModel.prototype.parsedScriptSource):
  • inspector/front-end/Script.js: (WebInspector.Script):
07:28 Changeset [75793] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-01-14 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed one line fix for console-xhr-logging test.

The problem was introduced at r75788.

  • inspector/InspectorBrowserDebuggerAgent.cpp: (WebCore::InspectorBrowserDebuggerAgent::willSendXMLHttpRequest):
06:57 Changeset [75792] by yurys@chromium.org
  • 22 edits
    2 adds in trunk/Source/WebCore

2011-01-13 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: extract console related functionality into InspectorConsoleAgent
https://bugs.webkit.org/show_bug.cgi?id=52282

  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • inspector/CodeGeneratorInspector.pm:
  • inspector/ConsoleMessage.cpp: (WebCore::ConsoleMessage::~ConsoleMessage):
  • inspector/ConsoleMessage.h:
  • inspector/Inspector.idl:
  • inspector/InspectorConsoleAgent.cpp: Added. (WebCore::InspectorConsoleAgent::InspectorConsoleAgent): (WebCore::InspectorConsoleAgent::~InspectorConsoleAgent): (WebCore::InspectorConsoleAgent::setConsoleMessagesEnabled): (WebCore::InspectorConsoleAgent::clearConsoleMessages): (WebCore::InspectorConsoleAgent::reset): (WebCore::InspectorConsoleAgent::setFrontend): (WebCore::InspectorConsoleAgent::addMessageToConsole): (WebCore::InspectorConsoleAgent::startTiming): (WebCore::InspectorConsoleAgent::stopTiming): (WebCore::InspectorConsoleAgent::count): (WebCore::InspectorConsoleAgent::resourceRetrievedByXMLHttpRequest): (WebCore::InspectorConsoleAgent::didReceiveResponse): (WebCore::InspectorConsoleAgent::didFailLoading): (WebCore::InspectorConsoleAgent::addConsoleMessage):
  • inspector/InspectorConsoleAgent.h: Added.
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::clearConsoleMessages): (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::disconnectFrontend): (WebCore::InspectorController::didCommitLoad):
  • inspector/InspectorController.h: (WebCore::InspectorController::consoleAgent):
  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::didReceiveResourceResponseImpl): (WebCore::InspectorInstrumentation::didFailLoadingImpl): (WebCore::InspectorInstrumentation::resourceRetrievedByXMLHttpRequestImpl): (WebCore::InspectorInstrumentation::addMessageToConsole): (WebCore::InspectorInstrumentation::count): (WebCore::InspectorInstrumentation::startTiming): (WebCore::InspectorInstrumentation::stopTiming): (WebCore::InspectorInstrumentation::addStartProfilingMessageToConsole):
  • inspector/InspectorInstrumentation.h:
  • inspector/InspectorProfilerAgent.cpp: (WebCore::InspectorProfilerAgent::addProfileFinishedMessageToConsole): (WebCore::InspectorProfilerAgent::addStartProfilingMessageToConsole):
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView): (WebInspector.ConsoleView.prototype.addConsoleMessage): (WebInspector.ConsoleView.prototype.updateConsoleMessageExpiredCount): (WebInspector.ConsoleView.prototype.consoleMessagesCleared):
  • inspector/front-end/inspector.js:
  • page/Console.cpp: (WebCore::Console::addMessage): (WebCore::Console::count): (WebCore::Console::profile): (WebCore::Console::time): (WebCore::Console::timeEnd): (WebCore::Console::group): (WebCore::Console::groupCollapsed): (WebCore::Console::groupEnd):
  • page/Console.h:
  • page/Console.idl:
06:50 Changeset [75791] by pfeldman@chromium.org
  • 11 edits in trunk

2011-01-14 Pavel Feldman <pfeldman@chromium.org>

Web Inspector: do not use this as protocol message
dispatcher in models / agents.
https://bugs.webkit.org/show_bug.cgi?id=52442

Models should never for InspectorBackend.registerDomainDispatcher("foo", this).
There should be a clear way to tell whether method is being called
from within front-end or by the backend.

  • http/tests/inspector/debugger-test2.js: (initialize_DebuggerTest.InspectorTest.startDebuggerTest.startTest): (initialize_DebuggerTest.InspectorTest.startDebuggerTest): (initialize_DebuggerTest.InspectorTest.completeDebuggerTest.disableDebugger): (initialize_DebuggerTest.InspectorTest.showScriptSource):

2011-01-14 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: do not use this as protocol message
dispatcher in models / agents.
https://bugs.webkit.org/show_bug.cgi?id=52442

Models should never for InspectorBackend.registerDomainDispatcher("foo", this).
There should be a clear way to tell whether method is being called
from within front-end or by the backend.

  • inspector/front-end/DOMAgent.js: (WebInspector.DOMAgent): (WebInspector.DOMAgent.prototype.nodeForId): (WebInspector.DOMAgent.prototype._bindNodes): (WebInspector.DOMAgent.prototype._removeBreakpoints): (WebInspector.DOMDispatcher): (WebInspector.DOMDispatcher.prototype.setDocument): (WebInspector.DOMDispatcher.prototype.attributesUpdated): (WebInspector.DOMDispatcher.prototype.characterDataModified): (WebInspector.DOMDispatcher.prototype.setChildNodes): (WebInspector.DOMDispatcher.prototype.setDetachedRoot): (WebInspector.DOMDispatcher.prototype.childNodeCountUpdated): (WebInspector.DOMDispatcher.prototype.childNodeInserted): (WebInspector.DOMDispatcher.prototype.childNodeRemoved): (WebInspector.DOMDispatcher.prototype.didCommitLoad): (WebInspector.ApplicationCacheDispatcher): (WebInspector.ApplicationCacheDispatcher.prototype.getApplicationCachesAsync): (WebInspector.ApplicationCacheDispatcher.prototype.updateApplicationCacheStatus): (WebInspector.ApplicationCacheDispatcher.prototype.updateNetworkState):
  • inspector/front-end/DOMStorage.js: (WebInspector.DOMStorageDispatcher): (WebInspector.DOMStorageDispatcher.prototype.addDOMStorage): (WebInspector.DOMStorageDispatcher.prototype.selectDOMStorage): (WebInspector.DOMStorageDispatcher.prototype.updateDOMStorage):
  • inspector/front-end/Database.js: (WebInspector.Database.prototype.executeSql): (WebInspector.DatabaseDispatcher): (WebInspector.DatabaseDispatcher.prototype.addDatabase): (WebInspector.DatabaseDispatcher.prototype.selectDatabase): (WebInspector.DatabaseDispatcher.prototype.sqlTransactionSucceeded): (WebInspector.DatabaseDispatcher.prototype.sqlTransactionFailed):
  • inspector/front-end/DebuggerModel.js: (WebInspector.DebuggerModel): (WebInspector.DebuggerModel.prototype._pausedScript): (WebInspector.DebuggerModel.prototype._resumedScript): (WebInspector.DebuggerModel.prototype._parsedScriptSource): (WebInspector.DebuggerModel.prototype._failedToParseScriptSource): (WebInspector.DebuggerDispatcher): (WebInspector.DebuggerDispatcher.prototype.pausedScript): (WebInspector.DebuggerDispatcher.prototype.resumedScript): (WebInspector.DebuggerDispatcher.prototype.parsedScriptSource): (WebInspector.DebuggerDispatcher.prototype.failedToParseScriptSource):
  • inspector/front-end/FileSystemView.js: (WebInspector.FileSystemDispatcher): (WebInspector.FileSystemDispatcher.prototype.getFileSystemPathsAsync): (WebInspector.FileSystemDispatcher.prototype.didGetFileSystemPath): (WebInspector.FileSystemDispatcher.prototype.didGetFileSystemError): (WebInspector.FileSystemDispatcher.prototype.didGetFileSystemDisabled):
  • inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel): (WebInspector.ProfilesPanel.prototype._addProfileHeader): (WebInspector.ProfilesPanel.prototype._removeProfileHeader): (WebInspector.ProfilesPanel.prototype._addHeapSnapshotChunk): (WebInspector.ProfilesPanel.prototype._finishHeapSnapshot): (WebInspector.ProfilesPanel.prototype._setRecordingProfile): (WebInspector.ProfilerDispatcher): (WebInspector.ProfilerDispatcher.prototype.profilerWasEnabled): (WebInspector.ProfilerDispatcher.prototype.profilerWasDisabled): (WebInspector.ProfilerDispatcher.prototype.resetProfiles): (WebInspector.ProfilerDispatcher.prototype.addProfileHeader): (WebInspector.ProfilerDispatcher.prototype.addHeapSnapshotChunk): (WebInspector.ProfilerDispatcher.prototype.finishHeapSnapshot): (WebInspector.ProfilerDispatcher.prototype.setRecordingProfile): (WebInspector.ProfileSidebarTreeElement.prototype.ondelete):
  • inspector/front-end/ResourceTreeModel.js: (WebInspector.ResourceTreeModel):
  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel): (WebInspector.TimelinePanel.prototype._timelineProfilerWasStarted): (WebInspector.TimelinePanel.prototype._timelineProfilerWasStopped): (WebInspector.TimelinePanel.prototype._addRecordToTimeline): (WebInspector.TimelineDispatcher): (WebInspector.TimelineDispatcher.prototype.timelineProfilerWasStarted): (WebInspector.TimelineDispatcher.prototype.timelineProfilerWasStopped): (WebInspector.TimelineDispatcher.prototype.addRecordToTimeline):
06:25 Changeset [75790] by ossy@webkit.org
  • 2 edits in trunk/Source/WebCore

[Qt][V8] Unreviewed buildfix after r75788.

  • inspector/InspectorBrowserDebuggerAgent.cpp:
05:31 Changeset [75789] by caseq@chromium.org
  • 2 edits in trunk/LayoutTests

2011-01-14 Andrey Kosyakov <caseq@chromium.org>

Unreviewed test fix.
Filter out /favicon.ico from page resources list to avoid test expectations mismatch on GTK.

  • http/tests/inspector/extensions-resources-redirect.html:
04:54 Changeset [75788] by loislo@chromium.org
  • 14 edits
    2 adds in trunk/Source/WebCore

2011-01-12 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Extract BrowserDebuggerAgent from InspectorController, InspectorDOMAgent and InspectorDebugger agent.
We have some methods of Debugger which are related to DOM.
Lets extract these methods to BrowserDebugger agent.

http://bugs.webkit.org/show_bug.cgi?id=52294

  • CMakeLists.txt:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/CodeGeneratorInspector.pm:
  • inspector/Inspector.idl:
  • inspector/InspectorBrowserDebuggerAgent.cpp: Added. (WebCore::InspectorBrowserDebuggerAgent::InspectorBrowserDebuggerAgent): (WebCore::InspectorBrowserDebuggerAgent::~InspectorBrowserDebuggerAgent): (WebCore::InspectorBrowserDebuggerAgent::discardBindings): (WebCore::InspectorBrowserDebuggerAgent::setEventListenerBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::removeEventListenerBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::didInsertDOMNode): (WebCore::InspectorBrowserDebuggerAgent::didRemoveDOMNode): (WebCore::InspectorBrowserDebuggerAgent::setDOMBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::removeDOMBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::willInsertDOMNode): (WebCore::InspectorBrowserDebuggerAgent::willRemoveDOMNode): (WebCore::InspectorBrowserDebuggerAgent::willModifyDOMAttr): (WebCore::InspectorBrowserDebuggerAgent::descriptionForDOMEvent): (WebCore::InspectorBrowserDebuggerAgent::hasBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::updateSubtreeBreakpoints): (WebCore::InspectorBrowserDebuggerAgent::pauseOnNativeEventIfNeeded): (WebCore::InspectorBrowserDebuggerAgent::setXHRBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::removeXHRBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::willSendXMLHttpRequest): (WebCore::InspectorBrowserDebuggerAgent::clearForPageNavigation):
  • inspector/InspectorBrowserDebuggerAgent.h: Added. (WebCore::InspectorBrowserDebuggerAgent::create):
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::inspectedPageDestroyed): (WebCore::InspectorController::didCommitLoad): (WebCore::InspectorController::enableDebuggerFromFrontend): (WebCore::InspectorController::disableDebugger): (WebCore::InspectorController::restoreStickyBreakpoints): (WebCore::InspectorController::restoreStickyBreakpoint):
  • inspector/InspectorController.h:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::discardBindings): (WebCore::InspectorDOMAgent::didInsertDOMNode): (WebCore::InspectorDOMAgent::didRemoveDOMNode):
  • inspector/InspectorDOMAgent.h:
  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::willInsertDOMNodeImpl): (WebCore::InspectorInstrumentation::didInsertDOMNodeImpl): (WebCore::InspectorInstrumentation::willRemoveDOMNodeImpl): (WebCore::InspectorInstrumentation::didRemoveDOMNodeImpl): (WebCore::InspectorInstrumentation::willModifyDOMAttrImpl): (WebCore::InspectorInstrumentation::willSendXMLHttpRequestImpl): (WebCore::InspectorInstrumentation::pauseOnNativeEventIfNeeded):
04:33 Changeset [75787] by eric@webkit.org
  • 4 edits in trunk/Tools

2011-01-14 Eric Seidel <eric@webkit.org>

Original patch from Peter Gal <galpater@inf.u-szeged.hu>

Reviewed by Adam Barth.

Fix when running Tools/Scripts/check-webkit-style without arguments.
https://bugs.webkit.org/show_bug.cgi?id=52261#c16

  • Scripts/webkitpy/common/checkout/scm.py: Handle None for changed_files argument better in Git.create_patch method.
  • Scripts/webkitpy/common/checkout/scm_unittest.py:
04:25 Changeset [75786] by caseq@chromium.org
  • 18 edits in trunk

2011-01-14 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: redirected resources not handled properly in Network panel
https://bugs.webkit.org/show_bug.cgi?id=52292

  • inspector/Inspector.idl: Do not pass isMainResource to identifierForInitialRequest() (it's useless, as we may hit provisional load)
  • inspector/InspectorInstrumentation.cpp: Ditto. (WebCore::InspectorInstrumentation::identifierForInitialRequestImpl):
  • inspector/InspectorResourceAgent.cpp: Ditto. (WebCore::InspectorResourceAgent::identifierForInitialRequest):
  • inspector/InspectorResourceAgent.h: Ditto.
  • inspector/InspectorInstrumentation.cpp: Ditto. (WebCore::InspectorInstrumentation::identifierForInitialRequestImpl): Fix main resource detection.
  • inspector/front-end/AuditsPanel.js: WebInspector.networkResources now returns array, not map.
  • inspector/front-end/ConsoleView.js: User WebInspector.resourceById() to get resource (WebInspector.ConsoleMessage.prototype._formatMessage):
  • inspector/front-end/ExtensionServer.js: Ditto. (WebInspector.ExtensionServer.prototype._onRevealAndSelectResource): (WebInspector.ExtensionServer.prototype._onGetResourceContent):
  • inspector/front-end/HAREntry.js: WebInspector.networkResources now returns array, not map (WebInspector.HARLog.prototype.build): (WebInspector.HARLog.prototype._convertResource):
  • inspector/front-end/NetworkManager.js: (WebInspector.NetworkManager): Use appendResource, not refreshResource, when adding a new resource. (WebInspector.NetworkManager.prototype.identifierForInitialRequest): (WebInspector.NetworkManager.prototype.willSendRequest): (WebInspector.NetworkManager.prototype.didLoadResourceFromMemoryCache): (WebInspector.NetworkManager.prototype.setInitialContent): (WebInspector.NetworkManager.prototype.didCommitLoadForFrame): (WebInspector.NetworkManager.prototype.didCreateWebSocket): (WebInspector.NetworkManager.prototype._createResource): always register resource URL with ResourceTreeModel (WebInspector.NetworkManager.prototype._appendRedirect):
  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel): (WebInspector.NetworkPanel.prototype.get resources): (WebInspector.NetworkPanel.prototype.resourceById): (WebInspector.NetworkPanel.prototype.appendResource): Add resource as new iff appendResource was added. (WebInspector.NetworkPanel.prototype.refreshResource): ditto. (WebInspector.NetworkPanel.prototype.mainResourceChanged): Clear console upon arrival of new main resource.
  • inspector/front-end/ResourceTreeModel.js: Expose unbindResourceURL, bind resources automatically upon creation. (WebInspector.ResourceTreeModel.prototype._clearResources): (WebInspector.ResourceTreeModel.prototype.unbindResourceURL): (WebInspector.ResourceTreeModel.prototype._addFramesRecursively): (WebInspector.ResourceTreeModel.prototype.createResource):
  • inspector/front-end/inspector.js: (WebInspector.resourceById):

2011-01-14 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: redirected resources not handled properly in Network panel
Added test for redirected resource presence in HAR
Changed test to request entire HAR log, not multiple HAR entries.
https://bugs.webkit.org/show_bug.cgi?id=52292

  • http/tests/inspector/extensions-resources-redirect-expected.txt:
  • http/tests/inspector/extensions-resources-redirect.html:
  • http/tests/inspector/resource-har-conversion.html:
  • inspector/extensions-resources.html:
02:48 Changeset [75785] by loislo@chromium.org
  • 14 edits
    2 deletes in trunk/Source/WebCore

2011-01-14 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r75783.
http://trac.webkit.org/changeset/75783
https://bugs.webkit.org/show_bug.cgi?id=52439

a bit strange but the same patch have broken mac builds at
linking stage. (Requested by loislo2 on #webkit).

  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/CodeGeneratorInspector.pm:
  • inspector/Inspector.idl:
  • inspector/InspectorBrowserDebuggerAgent.cpp: Removed.
  • inspector/InspectorBrowserDebuggerAgent.h: Removed.
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::inspectedPageDestroyed): (WebCore::InspectorController::didCommitLoad): (WebCore::InspectorController::enableDebuggerFromFrontend): (WebCore::InspectorController::disableDebugger): (WebCore::InspectorController::restoreStickyBreakpoints): (WebCore::InspectorController::restoreStickyBreakpoint): (WebCore::InspectorController::setEventListenerBreakpoint): (WebCore::InspectorController::removeEventListenerBreakpoint): (WebCore::InspectorController::hasEventListenerBreakpoint): (WebCore::InspectorController::setXHRBreakpoint): (WebCore::InspectorController::removeXHRBreakpoint): (WebCore::InspectorController::hasXHRBreakpoint):
  • inspector/InspectorController.h:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::discardBindings): (WebCore::InspectorDOMAgent::setDOMBreakpoint): (WebCore::InspectorDOMAgent::removeDOMBreakpoint): (WebCore::InspectorDOMAgent::shouldBreakOnNodeInsertion): (WebCore::InspectorDOMAgent::shouldBreakOnNodeRemoval): (WebCore::InspectorDOMAgent::shouldBreakOnAttributeModification): (WebCore::InspectorDOMAgent::descriptionForDOMEvent): (WebCore::InspectorDOMAgent::didInsertDOMNode): (WebCore::InspectorDOMAgent::didRemoveDOMNode): (WebCore::InspectorDOMAgent::hasBreakpoint): (WebCore::InspectorDOMAgent::updateSubtreeBreakpoints):
  • inspector/InspectorDOMAgent.h:
  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::willInsertDOMNodeImpl): (WebCore::InspectorInstrumentation::didInsertDOMNodeImpl): (WebCore::InspectorInstrumentation::willRemoveDOMNodeImpl): (WebCore::InspectorInstrumentation::didRemoveDOMNodeImpl): (WebCore::InspectorInstrumentation::willModifyDOMAttrImpl): (WebCore::InspectorInstrumentation::willSendXMLHttpRequestImpl): (WebCore::InspectorInstrumentation::pauseOnNativeEventIfNeeded):
02:24 Changeset [75784] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit/chromium

2011-01-14 Finnur Thorarinsson <finnur.webkit@gmail.com>

Reviewed by Ojan Vafai.

Address some user-select-none issues better in our Find in page scoping
function.

The scoping function is in part based on Editor::countMatchesForText
(formerly Frame::markAllMatchesForText), but was rewritten with
asychronous search and interruptability in mind. At the time the
function was written, countMatchesForText didn't work well with
user-select-none style but that has now changed. While
investigating http://crbug.com/68494 I noticed WebKit had fixed this
very problem in the countMatchesForText and I believe we should make
the same changes in our platform code. Therefore, this changelist
adopts the same approach by integrating:
https://bugs.webkit.org/show_bug.cgi?id=33508
(r53142: handling user-select-none better) and
https://bugs.webkit.org/show_bug.cgi?id=51623
(r74886: handling match within textfield better).
For more details see those changelists.

This changelist, however, is tracked here:
https://bugs.webkit.org/show_bug.cgi?id=52367

The original changelists did not come with layout tests, but I'm adding
a test on the Chromium side for this.

  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::scopeStringMatches):
02:22 Changeset [75783] by loislo@chromium.org
  • 14 edits
    2 adds in trunk/Source/WebCore

2011-01-12 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Extract BrowserDebuggerAgent from InspectorController, InspectorDOMAgent and InspectorDebugger agent.
We have some methods of Debugger which are related to DOM.
Lets extract these methods to BrowserDebugger agent.

http://bugs.webkit.org/show_bug.cgi?id=52294

  • CMakeLists.txt:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/CodeGeneratorInspector.pm:
  • inspector/Inspector.idl:
  • inspector/InspectorBrowserDebuggerAgent.cpp: Added. (WebCore::InspectorBrowserDebuggerAgent::InspectorBrowserDebuggerAgent): (WebCore::InspectorBrowserDebuggerAgent::~InspectorBrowserDebuggerAgent): (WebCore::InspectorBrowserDebuggerAgent::discardBindings): (WebCore::InspectorBrowserDebuggerAgent::setEventListenerBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::removeEventListenerBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::didInsertDOMNode): (WebCore::InspectorBrowserDebuggerAgent::didRemoveDOMNode): (WebCore::InspectorBrowserDebuggerAgent::setDOMBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::removeDOMBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::willInsertDOMNode): (WebCore::InspectorBrowserDebuggerAgent::willRemoveDOMNode): (WebCore::InspectorBrowserDebuggerAgent::willModifyDOMAttr): (WebCore::InspectorBrowserDebuggerAgent::descriptionForDOMEvent): (WebCore::InspectorBrowserDebuggerAgent::hasBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::updateSubtreeBreakpoints): (WebCore::InspectorBrowserDebuggerAgent::pauseOnNativeEventIfNeeded): (WebCore::InspectorBrowserDebuggerAgent::setXHRBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::removeXHRBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::willSendXMLHttpRequest): (WebCore::InspectorBrowserDebuggerAgent::clearForPageNavigation):
  • inspector/InspectorBrowserDebuggerAgent.h: Added. (WebCore::InspectorBrowserDebuggerAgent::create):
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::inspectedPageDestroyed): (WebCore::InspectorController::didCommitLoad): (WebCore::InspectorController::enableDebuggerFromFrontend): (WebCore::InspectorController::disableDebugger): (WebCore::InspectorController::restoreStickyBreakpoints): (WebCore::InspectorController::restoreStickyBreakpoint):
  • inspector/InspectorController.h:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::discardBindings): (WebCore::InspectorDOMAgent::didInsertDOMNode): (WebCore::InspectorDOMAgent::didRemoveDOMNode):
  • inspector/InspectorDOMAgent.h:
  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::willInsertDOMNodeImpl): (WebCore::InspectorInstrumentation::didInsertDOMNodeImpl): (WebCore::InspectorInstrumentation::willRemoveDOMNodeImpl): (WebCore::InspectorInstrumentation::didRemoveDOMNodeImpl): (WebCore::InspectorInstrumentation::willModifyDOMAttrImpl): (WebCore::InspectorInstrumentation::willSendXMLHttpRequestImpl): (WebCore::InspectorInstrumentation::pauseOnNativeEventIfNeeded):
02:05 Changeset [75782] by pfeldman@chromium.org
  • 2 edits in trunk/WebKit/gtk

2011-01-14 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: gtk build fix (2).

  • webkit/webkitwebview.cpp:
02:02 Changeset [75781] by jochen@chromium.org
  • 3 edits in trunk/Tools

2011-01-04 Jochen Eisinger <jochen@chromium.org>

Reviewed by David Levin.

Store the tempdir object in a variable so it doesn't get deleted too early.
https://bugs.webkit.org/show_bug.cgi?id=51875

  • Scripts/update-webkit-auxiliary-libs:
  • Scripts/update-webkit-support-libs:
01:59 Changeset [75780] by pfeldman@chromium.org
  • 2 edits in trunk/WebKit/gtk

2011-01-14 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: gtk build fix.

  • webkit/webkitwebinspector.cpp:
01:52 Changeset [75779] by eric@webkit.org
  • 2 edits in trunk/Tools

2011-01-14 Eric Seidel <eric@webkit.org>

Unreviewed. Make it work in python 2.5.

webkit-patch suggest-reviewers dies when ChangeLogs are missing
https://bugs.webkit.org/show_bug.cgi?id=49158

  • Scripts/webkitpy/common/checkout/api_unittest.py:
01:47 Changeset [75778] by pfeldman@chromium.org
  • 4 edits in trunk

2011-01-14 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: build fix.

  • WebCore.vcproj/WebCore.vcproj:
01:28 Changeset [75777] by pfeldman@chromium.org
  • 13 edits
    2 adds in trunk

2011-01-14 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: extract InspectorSettings from InspectorState,
simplify it.
https://bugs.webkit.org/show_bug.cgi?id=52429

  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/InspectorClient.h:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::inspectorStartsAttached): (WebCore::InspectorController::setInspectorStartsAttached): (WebCore::InspectorController::setInspectorAttachedHeight): (WebCore::InspectorController::inspectorAttachedHeight): (WebCore::InspectorController::setMonitoringXHREnabled): (WebCore::InspectorController::restoreDebugger): (WebCore::InspectorController::restoreProfiler): (WebCore::InspectorController::ensureSettingsLoaded): (WebCore::InspectorController::enableProfiler): (WebCore::InspectorController::disableProfiler): (WebCore::InspectorController::enableDebuggerFromFrontend): (WebCore::InspectorController::disableDebugger):
  • inspector/InspectorController.h:
  • inspector/InspectorSettings.cpp: Added. (WebCore::InspectorSettings::InspectorSettings): (WebCore::InspectorSettings::getBoolean): (WebCore::InspectorSettings::setBoolean): (WebCore::InspectorSettings::getLong): (WebCore::InspectorSettings::setLong): (WebCore::InspectorSettings::registerBoolean): (WebCore::InspectorSettings::registerLong):
  • inspector/InspectorSettings.h: Added.
  • inspector/InspectorState.cpp: (WebCore::InspectorState::InspectorState): (WebCore::InspectorState::setValue): (WebCore::InspectorState::setObject): (WebCore::InspectorState::registerBoolean): (WebCore::InspectorState::registerString): (WebCore::InspectorState::registerLong): (WebCore::InspectorState::registerObject): (WebCore::InspectorState::Property::create):
  • inspector/InspectorState.h: (WebCore::InspectorState::setBoolean): (WebCore::InspectorState::setString): (WebCore::InspectorState::setLong):

2011-01-14 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: extract InspectorSettings from InspectorState,
simplify it.
https://bugs.webkit.org/show_bug.cgi?id=52429

  • WebProcess/WebCoreSupport/WebInspectorClient.cpp:
01:21 Changeset [75776] by loislo@chromium.org
  • 15 edits
    2 deletes in trunk

2011-01-14 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r75774.
http://trac.webkit.org/changeset/75774
https://bugs.webkit.org/show_bug.cgi?id=52431

gtk builds were broken (Requested by loislo2 on #webkit).

  • CMakeLists.txt:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/CodeGeneratorInspector.pm:
  • inspector/Inspector.idl:
  • inspector/InspectorBrowserDebuggerAgent.cpp: Removed.
  • inspector/InspectorBrowserDebuggerAgent.h: Removed.
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::inspectedPageDestroyed): (WebCore::InspectorController::didCommitLoad): (WebCore::InspectorController::enableDebuggerFromFrontend): (WebCore::InspectorController::disableDebugger): (WebCore::InspectorController::restoreStickyBreakpoints): (WebCore::InspectorController::restoreStickyBreakpoint): (WebCore::InspectorController::setEventListenerBreakpoint): (WebCore::InspectorController::removeEventListenerBreakpoint): (WebCore::InspectorController::hasEventListenerBreakpoint): (WebCore::InspectorController::setXHRBreakpoint): (WebCore::InspectorController::removeXHRBreakpoint): (WebCore::InspectorController::hasXHRBreakpoint):
  • inspector/InspectorController.h:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::discardBindings): (WebCore::InspectorDOMAgent::setDOMBreakpoint): (WebCore::InspectorDOMAgent::removeDOMBreakpoint): (WebCore::InspectorDOMAgent::shouldBreakOnNodeInsertion): (WebCore::InspectorDOMAgent::shouldBreakOnNodeRemoval): (WebCore::InspectorDOMAgent::shouldBreakOnAttributeModification): (WebCore::InspectorDOMAgent::descriptionForDOMEvent): (WebCore::InspectorDOMAgent::didInsertDOMNode): (WebCore::InspectorDOMAgent::didRemoveDOMNode): (WebCore::InspectorDOMAgent::hasBreakpoint): (WebCore::InspectorDOMAgent::updateSubtreeBreakpoints):
  • inspector/InspectorDOMAgent.h:
  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::willInsertDOMNodeImpl): (WebCore::InspectorInstrumentation::didInsertDOMNodeImpl): (WebCore::InspectorInstrumentation::willRemoveDOMNodeImpl): (WebCore::InspectorInstrumentation::didRemoveDOMNodeImpl): (WebCore::InspectorInstrumentation::willModifyDOMAttrImpl): (WebCore::InspectorInstrumentation::willSendXMLHttpRequestImpl): (WebCore::InspectorInstrumentation::pauseOnNativeEventIfNeeded):

2011-01-14 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r75774.
http://trac.webkit.org/changeset/75774
https://bugs.webkit.org/show_bug.cgi?id=52431

gtk builds were broken (Requested by loislo2 on #webkit).

  • Scripts/webkitpy/common/checkout/scm.py:
00:56 Changeset [75775] by levin@chromium.org
  • 3 edits in trunk/Tools

check-webkit-style: _FunctionState should detect pure functions.
https://bugs.webkit.org/show_bug.cgi?id=52428

Reviewed by Shinichiro Hamaji.

  • Scripts/webkitpy/style/checkers/cpp.py: Added detection for if a function declaration

is a pure virtual function.

  • Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests for verifying that pure

virtual functions are correctly detected.

00:21 Changeset [75774] by loislo@chromium.org
  • 15 edits
    2 adds in trunk

2011-01-12 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Extract BrowserDebuggerAgent from InspectorController, InspectorDOMAgent and InspectorDebugger agent.
We have some methods of Debugger which are related to DOM.
Lets extract these methods to BrowserDebugger agent.

http://bugs.webkit.org/show_bug.cgi?id=52294

  • CMakeLists.txt:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/CodeGeneratorInspector.pm:
  • inspector/Inspector.idl:
  • inspector/InspectorBrowserDebuggerAgent.cpp: Added. (WebCore::InspectorBrowserDebuggerAgent::InspectorBrowserDebuggerAgent): (WebCore::InspectorBrowserDebuggerAgent::~InspectorBrowserDebuggerAgent): (WebCore::InspectorBrowserDebuggerAgent::discardBindings): (WebCore::InspectorBrowserDebuggerAgent::setEventListenerBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::removeEventListenerBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::didInsertDOMNode): (WebCore::InspectorBrowserDebuggerAgent::didRemoveDOMNode): (WebCore::InspectorBrowserDebuggerAgent::setDOMBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::removeDOMBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::willInsertDOMNode): (WebCore::InspectorBrowserDebuggerAgent::willRemoveDOMNode): (WebCore::InspectorBrowserDebuggerAgent::willModifyDOMAttr): (WebCore::InspectorBrowserDebuggerAgent::descriptionForDOMEvent): (WebCore::InspectorBrowserDebuggerAgent::hasBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::updateSubtreeBreakpoints): (WebCore::InspectorBrowserDebuggerAgent::pauseOnNativeEventIfNeeded): (WebCore::InspectorBrowserDebuggerAgent::setXHRBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::removeXHRBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::willSendXMLHttpRequest): (WebCore::InspectorBrowserDebuggerAgent::clearForPageNavigation):
  • inspector/InspectorBrowserDebuggerAgent.h: Added. (WebCore::InspectorBrowserDebuggerAgent::create):
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::inspectedPageDestroyed): (WebCore::InspectorController::didCommitLoad): (WebCore::InspectorController::enableDebuggerFromFrontend): (WebCore::InspectorController::disableDebugger): (WebCore::InspectorController::restoreStickyBreakpoints): (WebCore::InspectorController::restoreStickyBreakpoint):
  • inspector/InspectorController.h:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::discardBindings): (WebCore::InspectorDOMAgent::didInsertDOMNode): (WebCore::InspectorDOMAgent::didRemoveDOMNode):
  • inspector/InspectorDOMAgent.h:
  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::willInsertDOMNodeImpl): (WebCore::InspectorInstrumentation::didInsertDOMNodeImpl): (WebCore::InspectorInstrumentation::willRemoveDOMNodeImpl): (WebCore::InspectorInstrumentation::didRemoveDOMNodeImpl): (WebCore::InspectorInstrumentation::willModifyDOMAttrImpl): (WebCore::InspectorInstrumentation::willSendXMLHttpRequestImpl): (WebCore::InspectorInstrumentation::pauseOnNativeEventIfNeeded):

2011-01-13 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Just small fix for problem with check-webkit-style.
It just didn't work for this patch.
Old code can't concatenate a list of strings with None.

  • Scripts/webkitpy/common/checkout/scm.py:
00:14 Changeset [75773] by hayato@chromium.org
  • 2 edits in trunk/LayoutTests

2011-01-14 Hayato Ito <hayato@chromium.org>

Unreviewed chromium expectations update.

Exclude http/tests/loading/cross-origin-XHR-willLoadRequest.html (added in r75768)

  • platform/chromium/test_expectations.txt:
Note: See TracTimeline for information about the timeline view.