Timeline



Jan 21, 2011:

11:11 PM Changeset in webkit [76432] by ggaren@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Reorganized MarkedSpace, making many of its functions private.

Reviewed by Beth Dakin.

  • runtime/JSCell.h:

(JSC::JSCell::Heap::heap):

  • runtime/MarkedSpace.h:

(JSC::MarkedSpace::globalData):
(JSC::MarkedSpace::heap):

10:50 PM Changeset in webkit [76431] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Try to fix build: moved helper function out of #ifdef.

  • runtime/MachineStackMarker.cpp:

(JSC::swapIfBackwards):

10:45 PM Changeset in webkit [76430] by ggaren@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

A few of Maciej's review suggestions for my last patch.
https://bugs.webkit.org/show_bug.cgi?id=52946

Rubber-stamped by Maciej Stachowiak.

SunSpider reports no change.

  • runtime/MachineStackMarker.cpp:

(JSC::swapIfBackwards): Added a helper function for handling platforms
where the stack can grow in any direction.

(JSC::MachineStackMarker::markCurrentThreadConservativelyInternal):
(JSC::MachineStackMarker::markOtherThreadConservatively): Use the helper
function.

(JSC::isPointerAligned): Use "!" instead of "==0" because a robot told me to.

(JSC::MachineStackMarker::markConservatively): Changed to use a more
standard looping idiom, and to use the helper function above.

  • runtime/MarkedSpace.h:

(JSC::MarkedSpace::isCellAligned): Use "!" instead of "==0" because a robot told me to.

10:41 PM Changeset in webkit [76429] by abarth@webkit.org
  • 5 edits
    5 adds in trunk

2011-01-21 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Adam Barth.

Regression: new window.onerror() implementation leaks cross-origin Javascript errors
https://bugs.webkit.org/show_bug.cgi?id=52903

In case of an exception in a script from different domain only generic message
will be passed to window.onerror hander.

Tests: http/tests/security/cross-origin-script-window-onerror-redirected.html

http/tests/security/cross-origin-script-window-onerror.html

  • bindings/js/CachedScriptSourceProvider.h: use URL from the resource response to make sure we do all cross origin checks agains real script URL, not the original URL which may have resulted in a sequence of redirects to different domains. (WebCore::CachedScriptSourceProvider::CachedScriptSourceProvider):
  • bindings/v8/ScriptSourceCode.h: same for v8. (WebCore::ScriptSourceCode::url):
  • dom/ScriptExecutionContext.cpp: (WebCore::ScriptExecutionContext::dispatchErrorEvent): in case the error occurred in a script we cannot access provide concise "Script error." message without any information about the error source. This is what Firefox does in this case.

2011-01-21 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Adam Barth.

Regression: new window.onerror() implementation leaks cross-origin Javascript errors
https://bugs.webkit.org/show_bug.cgi?id=52903

A couple of tests to check that window.onerror won't reveal any content of the resource
from a different domain if the latter is referenced via <script src=...>

  • http/tests/security/cross-origin-script-window-onerror-expected.txt: Added.
  • http/tests/security/cross-origin-script-window-onerror-redirected-expected.txt: Added.
  • http/tests/security/cross-origin-script-window-onerror-redirected.html: Added.
  • http/tests/security/cross-origin-script-window-onerror.html: Added.
  • http/tests/security/resources/cross-origin-script.txt: Added.
9:59 PM Changeset in webkit [76428] by abarth@webkit.org
  • 2 edits in trunk/Tools

2011-01-21 Adam Barth <abarth@webkit.org>

Reviewed by Maciej Stachowiak.

Disable mac_unittest.py that fails on some of the Mac bots
https://bugs.webkit.org/show_bug.cgi?id=52947

As noted in the comment, this test does not appear to be correct
because the function this test is testing returns different results
depending on which flavor of Mac the test is run on. This patch
disable the test. Hopefully we can re-enable the test once we've
probably insulated the test from its environment.

  • Scripts/webkitpy/layout_tests/port/mac_unittest.py:
8:57 PM Changeset in webkit [76427] by mjs@apple.com
  • 2 edits in trunk/LayoutTests

2011-01-21 Maciej Stachowiak <mjs@apple.com>

Reviewed by Geoffrey Garen.

Humor the WebKit2 buildbot in its continuing hatred of forms tests
https://bugs.webkit.org/show_bug.cgi?id=52944

  • platform/mac-wk2/Skipped:
8:30 PM Changeset in webkit [76426] by mitz@apple.com
  • 4 edits in trunk/LayoutTests

Updated the results after r76414 fixed text justification in this test.

Rubber-stamped by Mark Rowe.

  • platform/mac/fast/text/justified-text-rect-expected.checksum:
  • platform/mac/fast/text/justified-text-rect-expected.png:
  • platform/mac/fast/text/justified-text-rect-expected.txt:
8:27 PM Changeset in webkit [76425] by ggaren@apple.com
  • 10 edits in trunk/Source/JavaScriptCore

2011-01-21 Geoffrey Garen <ggaren@apple.com>

Reviewed by Maciej Stachowiak.

Cleaned up some conservative marking code.
https://bugs.webkit.org/show_bug.cgi?id=52946


SunSpider reports no change.

  • interpreter/RegisterFile.h: No need for a special marking function, since we already expose a start() and end().
  • runtime/Heap.cpp: (JSC::Heap::registerFile): (JSC::Heap::markRoots):
  • runtime/Heap.h: (JSC::Heap::contains): Migrated markConservatively() to the machine stack marker class. Now, Heap just provides a contains() function, which the machine stack marker uses for checking whether a pointer points into the heap.
  • runtime/MachineStackMarker.cpp: (JSC::MachineStackMarker::markCurrentThreadConservativelyInternal): (JSC::MachineStackMarker::markOtherThreadConservatively): (JSC::isPointerAligned): (JSC::MachineStackMarker::markConservatively):
  • runtime/MachineStackMarker.h: Move the conservative marking code here.
  • runtime/MarkStack.h: (JSC::ConservativeSet::add): (JSC::ConservativeSet::mark): Changed to using a vector instead of hash set. Vector seems to be a bit faster, and it generates smaller code.
  • runtime/MarkedSpace.cpp: (JSC::MarkedSpace::containsSlowCase):
  • runtime/MarkedSpace.h: (JSC::MarkedSpace::isCellAligned): (JSC::MarkedSpace::isPossibleCell): (JSC::MarkedSpace::contains): Kept the code for determining whether a pointer pointed into marked space, and moved the code for marking a set of conservative pointers into the machine stack marker.
  • wtf/HashSet.h: (WTF::::add): Added two missing inlines that I noticed while testing vector vs hash set.
8:00 PM Changeset in webkit [76424] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

2011-01-21 James Robinson <jamesr@chromium.org>

Update chromium test expectations. fast/animation tests should now pass on all chromium configurations.

  • platform/chromium/test_expectations.txt:
7:31 PM Changeset in webkit [76423] by mrowe@apple.com
  • 5 edits in trunk/Source

Versioning.

7:27 PM Changeset in webkit [76422] by mrowe@apple.com
  • 1 copy in tags/Safari-534.16

New tag.

7:22 PM Changeset in webkit [76421] by mitz@apple.com
  • 2 edits in trunk/LayoutTests

Fix test failure.

  • fast/text/justify-nbsp.html: Removed a contenteditable attribute

that was added after generating results.

6:51 PM Changeset in webkit [76420] by andreas.kling@nokia.com
  • 1 edit
    1 delete in trunk/LayoutTests

2011-01-21 Andreas Kling <kling@webkit.org>

Unreviewed, removing the Qt result for r76414 since the test
was actually broken beyond the usual off-by-one metrics.

  • platform/qt/fast/text/justify-nbsp-expected.txt: Removed.
6:11 PM Changeset in webkit [76419] by andreas.kling@nokia.com
  • 1 edit
    1 add in trunk/LayoutTests

2011-01-21 Andreas Kling <kling@webkit.org>

Unreviewed, add Qt-specific result for test added in r76414.

  • platform/qt/fast/text/justify-nbsp-expected.txt: Added.
6:08 PM Changeset in webkit [76418] by ap@apple.com
  • 43 edits in trunk/Source/WebKit2

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=52943
Objective-C files should use #import, not #include

  • UIProcess/API/C/WebKit2.h: This is an interesting one, because it's cross-platform, and there is more than one WKView.h.
  • Platform/mac/ModuleMac.mm:
  • Platform/mac/RunLoopMac.mm:
  • PluginProcess/mac/PluginControllerProxyMac.mm:
  • PluginProcess/mac/PluginProcessMac.mm:
  • PluginProcess/mac/PluginProcessMainMac.mm:
  • Shared/API/c/mac/WKCertificateInfoMac.mm:
  • Shared/API/c/mac/WKURLRequestNS.mm:
  • Shared/API/c/mac/WKURLResponseNS.mm:
  • Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:
  • Shared/mac/PlatformCertificateInfo.mm:
  • Shared/mac/SandboxExtensionMac.mm:
  • Shared/mac/WebCoreArgumentCodersMac.mm:
  • Shared/mac/WebMemorySampler.mac.mm:
  • Shared/mac/WebURLRequestMac.mm:
  • Shared/mac/WebURLResponseMac.mm:
  • UIProcess/API/mac/FindIndicatorWindow.mm:
  • UIProcess/API/mac/WKTextInputWindowController.mm:
  • UIProcess/Launcher/mac/ProcessLauncherMac.mm:
  • UIProcess/Launcher/mac/ThreadLauncherMac.mm:
  • UIProcess/Plugins/mac/PluginInfoStoreMac.mm:
  • UIProcess/Plugins/mac/PluginProcessProxyMac.mm:
  • UIProcess/mac/BackingStoreMac.mm:
  • UIProcess/mac/ChunkedUpdateDrawingAreaProxyMac.mm:
  • UIProcess/mac/LayerBackedDrawingAreaProxyMac.mm:
  • UIProcess/mac/TextCheckerMac.mm:
  • UIProcess/mac/WebContextMac.mm:
  • UIProcess/mac/WebContextMenuProxyMac.mm:
  • UIProcess/mac/WebPageProxyMac.mm:
  • UIProcess/mac/WebPopupMenuProxyMac.mm:
  • UIProcess/mac/WebPreferencesMac.mm:
  • WebProcess/Downloads/mac/DownloadMac.mm:
  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
  • WebProcess/Plugins/Netscape/mac/PluginProxyMac.mm:
  • WebProcess/WebCoreSupport/mac/WebContextMenuClientMac.mm:
  • WebProcess/WebCoreSupport/mac/WebDatabaseManagerMac.mm:
  • WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm:
  • WebProcess/WebCoreSupport/mac/WebErrorsMac.mm:
  • WebProcess/WebCoreSupport/mac/WebPopupMenuMac.mm:
  • WebProcess/WebPage/mac/LayerBackedDrawingAreaMac.mm:
  • WebProcess/WebPage/mac/WebPageMac.mm:
  • WebProcess/mac/WebProcessMac.mm:
5:46 PM Changeset in webkit [76417] by mrowe@apple.com
  • 9 edits in trunk/Source/WebKit2

Fix the WebKit2 build with clang.

Reviewed by Sam Weinig.

  • Scripts/webkit2/messages.py: Add some more structs to the list.
  • UIProcess/DrawingAreaProxy.h: Forward-declare UpdateInfo as a class.
  • UIProcess/TextChecker.h: Forward-declare TextCheckerState as a struct.
  • UIProcess/WebPageProxy.h: Forward-declare ContextMenuState as a struct.
  • UIProcess/mac/TextCheckerMac.mm: Fix the type of the string constants so that they can be passed to

functions expecting NSString* without generating warnings.

  • WebProcess/WebPage/DrawingArea.h: Forward-declare WebPageCreationParameters as a struct.
  • WebProcess/WebPage/DrawingAreaImpl.h: Forward-declare UpdateInfo as a class.
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::getResourceDataFromFrame): Add parens around the assignment in the condition of
the if statement to suppress a warning.

5:46 PM Changeset in webkit [76416] by mrowe@apple.com
  • 3 edits in trunk/Source/WebKit/mac

Fix the build when using Clang by removing some unused variables.

Rubber-stamped by Jon Honeycutt.

  • Plugins/Hosted/WebHostedNetscapePluginView.mm:

(-[WebHostedNetscapePluginView updateAndSetWindow]):

  • WebView/WebFullScreenController.mm:

(-[WebFullScreenController enterFullscreen:]):
(-[WebFullScreenController exitFullscreen]):

5:45 PM Changeset in webkit [76415] by andreas.kling@nokia.com
  • 4 edits in trunk/Source/WebCore

2011-01-21 Andreas Kling <kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Always set composition mode through GraphicsContext
https://bugs.webkit.org/show_bug.cgi?id=52940

GraphicsContext tracks the current composition mode so we should
never call through to the QPainter directly.

  • platform/graphics/GraphicsContext.h:
  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::toQtCompositionMode): Changed this method to a static inline since it's only used by GraphicsContextQt.cpp now.
  • platform/graphics/qt/ImageQt.cpp: (WebCore::Image::drawPattern): (WebCore::BitmapImage::draw):
5:31 PM Changeset in webkit [76414] by mitz@apple.com
  • 3 edits
    4 adds in trunk

Inconsistent handling of no-break space in justification logic
https://bugs.webkit.org/show_bug.cgi?id=52938

Reviewed by Adele Peterson.

Source/WebCore:

Test: fast/text/justify-nbsp.html

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::computeInlineDirectionPositionsForLine): Count no-break space as a
space when computing the distribution of space between text boxes on the line.

LayoutTests:

  • fast/text/justify-nbsp-expected.checksum: Added.
  • fast/text/justify-nbsp-expected.png: Added.
  • fast/text/justify-nbsp-expected.txt: Added.
  • fast/text/justify-nbsp.html: Added.
5:29 PM Changeset in webkit [76413] by dpranke@chromium.org
  • 4 edits in trunk/Tools

2011-01-21 Dirk Pranke <dpranke@chromium.org>

Reviewed by Mihai Parparita.

Fix bug introduced in r76322 that caused NRWT to not actually
read the Skipped files properly.

https://bugs.webkit.org/show_bug.cgi?id=52771

  • Scripts/webkitpy/layout_tests/port/mac_unittest.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
5:19 PM Changeset in webkit [76412] by crogers@google.com
  • 2 edits in trunk/Source/WebKit/chromium

2011-01-21 Chris Rogers <crogers@google.com>

Unreviewed

define HAS_WEBAUDIO_RUNTIMEFEATURES for synchronization with chromium patch landing
https://bugs.webkit.org/show_bug.cgi?id=52941

  • public/WebRuntimeFeatures.h:
5:07 PM Changeset in webkit [76411] by crogers@google.com
  • 2 edits in trunk/Source/WebKit/chromium

2011-01-21 Chris Rogers <crogers@google.com>

Unreviewed

Add HAS_WEBAUDIO_FEATURE_ENABLE define to synchronize with chromium-side patch
https://bugs.webkit.org/show_bug.cgi?id=52939

  • public/WebSettings.h:
4:54 PM Changeset in webkit [76410] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

2011-01-21 Kenji Imasaki <imasaki@chromium.org>

Reviewed by David Levin.

Remove resolved BUG13907 from test expectation file and added
newly filed BUGCR70252 for media/video-zoom.html to keep track
of the issue.

Also, remove non-flaky test (media/audio-only-video-intrinsic-size.htm).

  • platform/chromium/test_expectations.txt:
4:38 PM Changeset in webkit [76409] by mrowe@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Work around a Clang bug <rdar://problem/8876150> that leads to it incorrectly emitting an access
control warning when a client tries to use operator bool exposed above via "using PageBlock::operator bool".

Reviewed by Sam Weinig.

  • wtf/PageAllocation.h:

(WTF::PageAllocation::operator bool):

  • wtf/PageReservation.h:

(WTF::PageReservation::operator bool):

4:16 PM Changeset in webkit [76408] by mrobinson@webkit.org
  • 8 edits in trunk/LayoutTests

2011-01-21 Martin Robinson <mrobinson@igalia.com>

Rebaseline tests that use menulists. Also unskip a non-existent test.

  • platform/gtk/Skipped: Remove non-existent test.
  • platform/gtk/editing/selection/select-box-expected.checksum:
  • platform/gtk/editing/selection/select-box-expected.png:
  • platform/gtk/editing/selection/select-box-expected.txt:
  • platform/gtk/transforms/2d/zoom-menulist-expected.checksum:
  • platform/gtk/transforms/2d/zoom-menulist-expected.png:
  • platform/gtk/transforms/2d/zoom-menulist-expected.txt:
3:52 PM Changeset in webkit [76407] by msaboff@apple.com
  • 5 edits in trunk

2011-01-21 Michael Saboff <msaboff@apple.com>

Reviewed by Oliver Hunt.

[RegexFuzz] Hang with forward assertion
https://bugs.webkit.org/show_bug.cgi?id=52825
<rdar://problem/8894332>

The backtrackTo label from the first term in a list of terms is
being overwritten by processing of subsequent terms. Changed
copyBacktrackToLabel() to check for an existing bcaktrackTo label
before copying and renamed it to propagateBacktrackToLabel() since
it no longer copies.

  • yarr/YarrJIT.cpp: (JSC::Yarr::YarrGenerator::BacktrackDestination::propagateBacktrackToLabel): (JSC::Yarr::YarrGenerator::generateParenthesesSingle):

2011-01-21 Michael Saboff <msaboff@apple.com>

Reviewed by Oliver Hunt.

[RegexFuzz] Hang with forward assertion
https://bugs.webkit.org/show_bug.cgi?id=52825
<rdar://problem/8894332>

New tests to check for functionality and future regression.

  • fast/regex/parentheses-expected.txt:
  • fast/regex/script-tests/parentheses.js:
3:47 PM Changeset in webkit [76406] by commit-queue@webkit.org
  • 4 edits in trunk/Source

2011-01-21 Charlie Reis <creis@chromium.org>

Reviewed by Darin Fisher.

Crash in WebCore::HistoryController::itemsAreClones
https://bugs.webkit.org/show_bug.cgi?id=52819

Adds sanity checks to help diagnose the crash.

  • loader/HistoryController.cpp:

2011-01-21 Charlie Reis <creis@chromium.org>

Reviewed by Darin Fisher.

Crash in WebCore::HistoryController::itemsAreClones
https://bugs.webkit.org/show_bug.cgi?id=52819

Adds sanity checks to help diagnose the crash.

  • src/WebFrameImpl.cpp:
3:45 PM Changeset in webkit [76405] by andreas.kling@nokia.com
  • 3 edits in trunk/Source/WebCore

2011-01-21 Andreas Kling <kling@webkit.org>

Reviewed by Ariya Hidayat.

[Qt] Let QPainter decide whether a composition mode is supported or not

Lacking Porter-Duff support in the paint engine shouldn't exclude the
Source and Source-Over modes (and has nothing to do with the blend
and raster-op modes.)

Delegate this decision to QPainter instead (this will cause warnings
if an unsupported mode is used, but that's a good thing.)

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::clearRect): (WebCore::GraphicsContext::setPlatformCompositeOperation):
  • platform/graphics/qt/TransparencyLayer.h: (WebCore::TransparencyLayer::TransparencyLayer):
3:43 PM Changeset in webkit [76404] by mjs@apple.com
  • 2 edits in trunk/LayoutTests

2011-01-21 Maciej Stachowiak <mjs@apple.com>

Reviewed by Adele Peterson.

Skip a test that's sporadically crashing on the buildbots
https://bugs.webkit.org/show_bug.cgi?id=52932

  • platform/mac-wk2/Skipped:
3:42 PM Changeset in webkit [76403] by bweinstein@apple.com
  • 8 edits in trunk/Source/WebKit2

WebKit2: Need API to stop loading a WKFrame
https://bugs.webkit.org/show_bug.cgi?id=52925

Reviewed by Adam Roben.

  • UIProcess/API/C/WKFrame.cpp:

(WKFrameStopLoading): Call through to WebFrameProxy::stopLoading.

  • UIProcess/API/C/WKFrame.h:
  • UIProcess/WebFrameProxy.cpp:

(WebKit::WebFrameProxy::stopLoading): Send a message to the WebProcess to stop loading the frame

with the passed in ID.

  • UIProcess/WebFrameProxy.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::stopLoadingFrame): Call stopForUserCancel on the passed-in frame.

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in: Add StopLoadingFrame.
3:41 PM Changeset in webkit [76402] by crogers@google.com
  • 2 edits in trunk/Source/WebCore

2011-01-21 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

fix audio build: header file should be "Noncopyable.h" and not "NonCopyable.h"
https://bugs.webkit.org/show_bug.cgi?id=52933

No new tests since this just fixes the build

  • webaudio/RealtimeAnalyser.h:
3:32 PM Changeset in webkit [76401] by weinig@apple.com
  • 2 edits in trunk/Tools

WebKitTestRunner needs the HOME environment variable to be set.
<rdar://problem/8896573>

Reviewed by Geoffrey Sean Garen and Mark Rowe.

  • Scripts/old-run-webkit-tests: Set the HOME environment variable if

it exists.

3:28 PM Changeset in webkit [76400] by crogers@google.com
  • 2 edits in trunk/Source/WebCore

2011-01-21 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

Fix audio build: change ChromiumBridge to PlatformBridge
https://bugs.webkit.org/show_bug.cgi?id=52928

No new tests since audio API is not yet implemented.

  • platform/audio/chromium/AudioBusChromium.cpp: (WebCore::AudioBus::loadPlatformResource):
3:24 PM Changeset in webkit [76399] by ggaren@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

2011-01-21 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Moved the mark stack from global data to the heap, since it pertains
to the heap, and not the virtual machine as a whole.
https://bugs.webkit.org/show_bug.cgi?id=52930


SunSpider reports no change.

  • runtime/Heap.cpp: (JSC::Heap::Heap): (JSC::Heap::markRoots):
  • runtime/Heap.h:
  • runtime/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData):
  • runtime/JSGlobalData.h:
3:23 PM Changeset in webkit [76398] by dpranke@chromium.org
  • 4 edits in trunk/Tools

2011-01-21 Dirk Pranke <dpranke@chromium.org>

Reviewed by Eric Seidel.

Suppress a few remaining integration tests so that none of the
layout_test unit tests ever read from the filesystem or launch
subprocesses that aren't part of the unit tests.

Also fix a minor bug in the printing unit tests that was
incorrectly relying on sys.argv.

https://bugs.webkit.org/show_bug.cgi?id=52863

  • Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
  • Scripts/webkitpy/layout_tests/port/port_testcase.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3:06 PM Changeset in webkit [76397] by crogers@google.com
  • 2 edits
    1 add in trunk/Source/WebCore

2011-01-21 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

Add FFTFrameStub to avoid link errors during bringup on platforms without an FFT implementation
https://bugs.webkit.org/show_bug.cgi?id=52922

No new tests since audio API is not yet implemented.

  • WebCore.gypi:
  • platform/audio/FFTFrameStub.cpp: Added. (WebCore::FFTFrame::FFTFrame): (WebCore::FFTFrame::~FFTFrame): (WebCore::FFTFrame::multiply): (WebCore::FFTFrame::doFFT): (WebCore::FFTFrame::doInverseFFT): (WebCore::FFTFrame::cleanup): (WebCore::FFTFrame::realData): (WebCore::FFTFrame::imagData):
3:01 PM UsingGitWithWebKit edited by mrobinson@webkit.org
Added information about proper svn:mime-type configuration (diff)
2:52 PM Changeset in webkit [76396] by mjs@apple.com
  • 2 edits in trunk/LayoutTests

2011-01-21 Maciej Stachowiak <mjs@apple.com>

Reviewed by Adam Roben.

Skip some newly added tests that use DRT APIs that are not yet available for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=52924

  • platform/mac-wk2/Skipped:
2:32 PM Changeset in webkit [76395] by tony@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-01-21 Tony Chang <tony@chromium.org>

Reviewed by Sam Weinig.

reduce number of FrameLoaderClient::didChangeScrollOffset calls
https://bugs.webkit.org/show_bug.cgi?id=52915

Only notify of changes in scroll offset when there actually is a change.
This regressed in r76291.

Covered by Chromium browser_tests.

  • platform/ScrollAnimator.cpp: (WebCore::ScrollAnimator::scrollToOffsetWithoutAnimation):
2:12 PM Changeset in webkit [76394] by beidson@apple.com
  • 5 edits in trunk/Source/WebKit2

<rdar://problem/8894125> and https://bugs.webkit.org/show_bug.cgi?id=52916
Expose "suggested filename" for a resource based on its resource response.

Reviewed by Adam Roben.

API pieces:

  • WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:

(WKBundleFrameCopySuggestedFilenameForResourceURL):

  • WebProcess/InjectedBundle/API/c/WKBundleFrame.h:


Implementation:

  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::suggestedFilenameForResourceURL): See if the DocumentLoader has

a resource for this URL and, if so, return the response's suggested filename.

  • WebProcess/WebPage/WebFrame.h:
2:09 PM Changeset in webkit [76393] by andersca@apple.com
  • 5 edits in trunk/Source/WebKit2

2011-01-21 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

DrawingAreaProxyImpl::paint should return the unpainted region
https://bugs.webkit.org/show_bug.cgi?id=52918

  • UIProcess/API/mac/WKView.mm: (-[WKView drawRect:]): Add unpaintedRegion parameter.
  • UIProcess/BackingStore.h: (WebKit::BackingStore::size): Add a size getter.
  • UIProcess/DrawingAreaProxyImpl.cpp: (WebKit::DrawingAreaProxyImpl::paint): Initialize the unpainted region to the dirty region, then subtract the painted region.
2:00 PM Changeset in webkit [76392] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-01-21 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: ~InspectorResourceAgent crashes on closing inspected page.
https://bugs.webkit.org/show_bug.cgi?id=52900

  • inspector/InspectorController.cpp: (WebCore::InspectorController::~InspectorController): (WebCore::InspectorController::inspectedPageDestroyed):
1:58 PM Changeset in webkit [76391] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix for <rdar://problem/8896057>

Reviewed by Dan Bernstein and Maciej Stachowiak.

Give the Web Process access to the PubSub agent.

  • WebProcess/com.apple.WebProcess.sb:
1:43 PM Changeset in webkit [76390] by crogers@google.com
  • 21 edits in trunk/Source

2011-01-21 Chris Rogers <crogers@google.com>

Reviewed by Darin Fisher.

Add run-time enable support for the web audio API
https://bugs.webkit.org/show_bug.cgi?id=52741

  • public/WebRuntimeFeatures.h:
  • public/WebSettings.h:
  • src/WebRuntimeFeatures.cpp: (WebKit::WebRuntimeFeatures::enableWebAudio): (WebKit::WebRuntimeFeatures::isWebAudioEnabled):
  • src/WebSettingsImpl.cpp: (WebKit::WebSettingsImpl::setWebAudioEnabled):
  • src/WebSettingsImpl.h:

2011-01-21 Chris Rogers <crogers@google.com>

Reviewed by Darin Fisher.

Add run-time enable support for the web audio API
https://bugs.webkit.org/show_bug.cgi?id=52741

  • WebPreferenceKeysPrivate.h:
  • WebView.cpp: (WebView::notifyPreferencesChanged):

2011-01-21 Chris Rogers <crogers@google.com>

Reviewed by Darin Fisher.

Add run-time enable support for the web audio API
https://bugs.webkit.org/show_bug.cgi?id=52741

  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm: (-[WebPreferences webAudioEnabled]): (-[WebPreferences setWebAudioEnabled:]):
  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]):

2011-01-21 Chris Rogers <crogers@google.com>

Reviewed by Darin Fisher.

Add run-time enable support for the web audio API
https://bugs.webkit.org/show_bug.cgi?id=52741

No new tests since audio API is not yet implemented.

  • WebCore.exp.in:
  • bindings/generic/RuntimeEnabledFeatures.cpp:
  • bindings/generic/RuntimeEnabledFeatures.h: (WebCore::RuntimeEnabledFeatures::setWebkitAudioContextEnabled): (WebCore::RuntimeEnabledFeatures::webkitAudioContextEnabled):
  • page/DOMWindow.idl:
  • page/Settings.cpp: (WebCore::Settings::Settings): (WebCore::Settings::setWebAudioEnabled):
  • page/Settings.h: (WebCore::Settings::webAudioEnabled):
1:33 PM Changeset in webkit [76389] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit/win

Fix windows build.

  • WebScrollBar.h:
1:33 PM Changeset in webkit [76388] by mrobinson@webkit.org
  • 114 edits
    2 adds in trunk

2011-01-21 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Menulist text often collides with separator
https://bugs.webkit.org/show_bug.cgi?id=51155

Rebaseline tests that have different affected by the metrics of
the menulist.

  • platform/gtk/fast/forms/001-expected.checksum:
  • platform/gtk/fast/forms/001-expected.png:
  • platform/gtk/fast/forms/001-expected.txt:
  • platform/gtk/fast/forms/003-expected.checksum:
  • platform/gtk/fast/forms/003-expected.png:
  • platform/gtk/fast/forms/003-expected.txt:
  • platform/gtk/fast/forms/004-expected.checksum:
  • platform/gtk/fast/forms/004-expected.png:
  • platform/gtk/fast/forms/004-expected.txt:
  • platform/gtk/fast/forms/HTMLOptionElement_label01-expected.checksum:
  • platform/gtk/fast/forms/HTMLOptionElement_label01-expected.png:
  • platform/gtk/fast/forms/HTMLOptionElement_label01-expected.txt:
  • platform/gtk/fast/forms/HTMLOptionElement_label02-expected.checksum:
  • platform/gtk/fast/forms/HTMLOptionElement_label02-expected.png:
  • platform/gtk/fast/forms/HTMLOptionElement_label02-expected.txt:
  • platform/gtk/fast/forms/HTMLOptionElement_label03-expected.checksum:
  • platform/gtk/fast/forms/HTMLOptionElement_label03-expected.png:
  • platform/gtk/fast/forms/HTMLOptionElement_label03-expected.txt:
  • platform/gtk/fast/forms/HTMLOptionElement_label04-expected.checksum:
  • platform/gtk/fast/forms/HTMLOptionElement_label04-expected.png:
  • platform/gtk/fast/forms/HTMLOptionElement_label04-expected.txt:
  • platform/gtk/fast/forms/HTMLOptionElement_label06-expected.checksum:
  • platform/gtk/fast/forms/HTMLOptionElement_label06-expected.png:
  • platform/gtk/fast/forms/HTMLOptionElement_label06-expected.txt:
  • platform/gtk/fast/forms/HTMLOptionElement_label07-expected.checksum:
  • platform/gtk/fast/forms/HTMLOptionElement_label07-expected.png:
  • platform/gtk/fast/forms/HTMLOptionElement_label07-expected.txt:
  • platform/gtk/fast/forms/control-clip-overflow-expected.checksum:
  • platform/gtk/fast/forms/control-clip-overflow-expected.png:
  • platform/gtk/fast/forms/control-clip-overflow-expected.txt:
  • platform/gtk/fast/forms/control-restrict-line-height-expected.checksum:
  • platform/gtk/fast/forms/control-restrict-line-height-expected.png:
  • platform/gtk/fast/forms/control-restrict-line-height-expected.txt:
  • platform/gtk/fast/forms/disabled-select-change-index-expected.checksum:
  • platform/gtk/fast/forms/disabled-select-change-index-expected.png:
  • platform/gtk/fast/forms/disabled-select-change-index-expected.txt:
  • platform/gtk/fast/forms/form-element-geometry-expected.checksum:
  • platform/gtk/fast/forms/form-element-geometry-expected.png:
  • platform/gtk/fast/forms/form-element-geometry-expected.txt:
  • platform/gtk/fast/forms/input-file-re-render-expected.checksum: Added.
  • platform/gtk/fast/forms/input-file-re-render-expected.png: Added.
  • platform/gtk/fast/forms/menulist-deselect-update-expected.checksum:
  • platform/gtk/fast/forms/menulist-deselect-update-expected.png:
  • platform/gtk/fast/forms/menulist-deselect-update-expected.txt:
  • platform/gtk/fast/forms/menulist-narrow-width-expected.checksum:
  • platform/gtk/fast/forms/menulist-narrow-width-expected.png:
  • platform/gtk/fast/forms/menulist-narrow-width-expected.txt:
  • platform/gtk/fast/forms/menulist-no-overflow-expected.checksum:
  • platform/gtk/fast/forms/menulist-no-overflow-expected.png:
  • platform/gtk/fast/forms/menulist-no-overflow-expected.txt:
  • platform/gtk/fast/forms/menulist-restrict-line-height-expected.checksum:
  • platform/gtk/fast/forms/menulist-restrict-line-height-expected.png:
  • platform/gtk/fast/forms/menulist-restrict-line-height-expected.txt:
  • platform/gtk/fast/forms/menulist-separator-painting-expected.checksum:
  • platform/gtk/fast/forms/menulist-separator-painting-expected.png:
  • platform/gtk/fast/forms/menulist-separator-painting-expected.txt:
  • platform/gtk/fast/forms/menulist-style-color-expected.checksum:
  • platform/gtk/fast/forms/menulist-style-color-expected.png:
  • platform/gtk/fast/forms/menulist-style-color-expected.txt:
  • platform/gtk/fast/forms/menulist-width-change-expected.checksum:
  • platform/gtk/fast/forms/menulist-width-change-expected.png:
  • platform/gtk/fast/forms/menulist-width-change-expected.txt:
  • platform/gtk/fast/forms/option-script-expected.checksum:
  • platform/gtk/fast/forms/option-script-expected.png:
  • platform/gtk/fast/forms/option-script-expected.txt:
  • platform/gtk/fast/forms/option-strip-whitespace-expected.checksum:
  • platform/gtk/fast/forms/option-strip-whitespace-expected.png:
  • platform/gtk/fast/forms/option-strip-whitespace-expected.txt:
  • platform/gtk/fast/forms/option-text-clip-expected.checksum:
  • platform/gtk/fast/forms/option-text-clip-expected.png:
  • platform/gtk/fast/forms/option-text-clip-expected.txt:
  • platform/gtk/fast/forms/select-align-expected.checksum:
  • platform/gtk/fast/forms/select-align-expected.png:
  • platform/gtk/fast/forms/select-align-expected.txt:
  • platform/gtk/fast/forms/select-baseline-expected.checksum:
  • platform/gtk/fast/forms/select-baseline-expected.png:
  • platform/gtk/fast/forms/select-baseline-expected.txt:
  • platform/gtk/fast/forms/select-change-listbox-to-popup-expected.checksum:
  • platform/gtk/fast/forms/select-change-listbox-to-popup-expected.png:
  • platform/gtk/fast/forms/select-change-listbox-to-popup-expected.txt:
  • platform/gtk/fast/forms/select-dirty-parent-pref-widths-expected.checksum:
  • platform/gtk/fast/forms/select-dirty-parent-pref-widths-expected.png:
  • platform/gtk/fast/forms/select-dirty-parent-pref-widths-expected.txt:
  • platform/gtk/fast/forms/select-disabled-appearance-expected.checksum:
  • platform/gtk/fast/forms/select-disabled-appearance-expected.png:
  • platform/gtk/fast/forms/select-disabled-appearance-expected.txt:
  • platform/gtk/fast/forms/select-initial-position-expected.checksum:
  • platform/gtk/fast/forms/select-initial-position-expected.png:
  • platform/gtk/fast/forms/select-initial-position-expected.txt:
  • platform/gtk/fast/forms/select-selected-expected.checksum:
  • platform/gtk/fast/forms/select-selected-expected.png:
  • platform/gtk/fast/forms/select-selected-expected.txt:
  • platform/gtk/fast/forms/select-size-expected.checksum:
  • platform/gtk/fast/forms/select-size-expected.png:
  • platform/gtk/fast/forms/select-size-expected.txt:
  • platform/gtk/fast/forms/select-style-expected.checksum:
  • platform/gtk/fast/forms/select-style-expected.png:
  • platform/gtk/fast/forms/select-style-expected.txt:
  • platform/gtk/fast/forms/select-visual-hebrew-expected.checksum:
  • platform/gtk/fast/forms/select-visual-hebrew-expected.png:
  • platform/gtk/fast/forms/select-visual-hebrew-expected.txt:
  • platform/gtk/fast/forms/select-writing-direction-natural-expected.checksum:
  • platform/gtk/fast/forms/select-writing-direction-natural-expected.png:
  • platform/gtk/fast/forms/select-writing-direction-natural-expected.txt:
  • platform/gtk/fast/forms/stuff-on-my-optgroup-expected.checksum:
  • platform/gtk/fast/forms/stuff-on-my-optgroup-expected.png:
  • platform/gtk/fast/forms/stuff-on-my-optgroup-expected.txt:

2011-01-21 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Menulist text often collides with separator
https://bugs.webkit.org/show_bug.cgi?id=51155

Move menulist rendering to RenderThemeGtk and correct padding code
for separators in menulists.

  • platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::RenderThemeGtk): Initialize new widget members. (WebCore::RenderThemeGtk::getComboBoxSeparatorWidth): Added. (WebCore::RenderThemeGtk::comboBoxArrowSize): Added. (WebCore::getButtonInnerBorder): Added. (WebCore::RenderThemeGtk::getComboBoxPadding): Do this manually instead of using Mozilla code. (WebCore::RenderThemeGtk::paintMenuList): Ditto. (WebCore::setupWidget): Abstracted this part of the setupWidgetAndAddToContainer out to handle child widgets of comboboxes. (WebCore::RenderThemeGtk::setupWidgetAndAddToContainer): Abstracted out setupWidget. (WebCore::RenderThemeGtk::gtkContainer): Added. (WebCore::getGtkComboBoxButton): Added. (WebCore::getGtkComboBoxPieces): Added. (WebCore::RenderThemeGtk::gtkComboBox): Call setupWidget here. (WebCore::RenderThemeGtk::refreshComboBoxChildren): Added. (WebCore::RenderThemeGtk::gtkComboBoxButton): Added. (WebCore::RenderThemeGtk::gtkComboBoxArrow): Added. (WebCore::RenderThemeGtk::gtkComboBoxSeparator): Added.
  • platform/gtk/RenderThemeGtk.h: Added new members and methods.
  • platform/gtk/WidgetRenderingContext.h: Added new members and methods.
  • platform/gtk/WidgetRenderingContextGtk2.cpp: (WebCore::WidgetRenderingContext::gtkPaintArrow): (WebCore::WidgetRenderingContext::gtkPaintVLine):
  • platform/gtk/WidgetRenderingContextGtk3.cpp: (WebCore::WidgetRenderingContext::gtkPaintArrow): (WebCore::WidgetRenderingContext::gtkPaintVLine):
  • platform/gtk/gtk2drawing.c: Removed code for drawing menulists and buttons. (moz_gtk_init): (moz_gtk_get_widget_border): (moz_gtk_widget_paint):
  • platform/gtk/gtk3drawing.c: (moz_gtk_init): (moz_gtk_get_widget_border): (moz_gtk_widget_paint):
  • platform/gtk/gtkdrawing.h:
1:17 PM Changeset in webkit [76387] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

Fix chromium mac build.

  • platform/chromium/ScrollbarThemeChromiumMac.mm:

(WebCore::scrollbarStateToThemeState):
(WebCore::ScrollbarThemeChromiumMac::paint):

1:10 PM Changeset in webkit [76386] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed trivial fix.

FrameLoader::checkLoadCompleteForThisFrame uses wrong history item
https://bugs.webkit.org/show_bug.cgi?id=48812

  • platform/qt/http/tests/navigation/forward-and-cancel-expected.txt: Updated after r76357.
1:08 PM Changeset in webkit [76385] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

Fix the windows build.

  • platform/ScrollbarThemeComposite.cpp:

(WebCore::ScrollbarThemeComposite::paint):

1:02 PM Changeset in webkit [76384] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

Skip transitions/transition-end-event-destroy-iframe.html on Windows in order to get the
Windows 7 Release bots green. Unreviewed.
https://bugs.webkit.org/show_bug.cgi?id=52913

  • platform/win/Skipped:
12:54 PM Changeset in webkit [76383] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-01-21 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed; another Chromium build fix attempt for r76378.

  • src/WebScrollbarImpl.cpp: (WebKit::WebScrollbar::create): (WebKit::WebScrollbarImpl::WebScrollbarImpl): (WebKit::WebScrollbarImpl::setValue):
12:42 PM Changeset in webkit [76382] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-01-21 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed Chromium build fix attempt for r76378.

  • src/WebScrollbarImpl.cpp: (WebKit::WebScrollbar::create): (WebKit::WebScrollbarImpl::WebScrollbarImpl):
12:34 PM Changeset in webkit [76381] by mjs@apple.com
  • 2 edits in trunk/LayoutTests

2011-01-21 Maciej Stachowiak <mjs@apple.com>

Reviewed by Sam Weinig.

Skip another test that is failing sporadically on the buildbots
https://bugs.webkit.org/show_bug.cgi?id=52908

  • platform/mac-wk2/Skipped:
12:29 PM Changeset in webkit [76380] by crogers@google.com
  • 5 edits in trunk/Source

2011-01-21 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

Add chromium bundled audio spatialization resources to WebAudio.grd
https://bugs.webkit.org/show_bug.cgi?id=52651

  • WebKit.grd:

2011-01-21 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

Add chromium bundled audio spatialization resources to WebAudio.grd
https://bugs.webkit.org/show_bug.cgi?id=52651

No new tests since audio API is not yet implemented.

  • WebCore.gyp/WebCore.gyp:
  • platform/audio/chromium/AudioBusChromium.cpp: (WebCore::AudioBus::loadPlatformResource):
12:26 PM Changeset in webkit [76379] by commit-queue@webkit.org
  • 80 edits in trunk

2011-01-21 Xiyuan Xia <xiyuan@chromium.org>

Reviewed by Tony Chang.

Update chromium/linux baselines after drawing code moved into
WebThemeEngine.
https://bugs.webkit.org/show_bug.cgi?id=52826

  • platform/chromium-linux/css1/box_properties/acid_test-expected.checksum:
  • platform/chromium-linux/css1/box_properties/acid_test-expected.png:
  • platform/chromium-linux/css2.1/t09-c5526c-display-00-e-expected.checksum:
  • platform/chromium-linux/css2.1/t09-c5526c-display-00-e-expected.png:
  • platform/chromium-linux/fast/block/basic/011-expected.checksum:
  • platform/chromium-linux/fast/block/basic/011-expected.png:
  • platform/chromium-linux/fast/block/margin-collapse/103-expected.checksum:
  • platform/chromium-linux/fast/block/margin-collapse/103-expected.png:
  • platform/chromium-linux/fast/css/non-standard-checkbox-size-expected.checksum:
  • platform/chromium-linux/fast/css/non-standard-checkbox-size-expected.png:
  • platform/chromium-linux/fast/dom/HTMLProgressElement/progress-element-expected.checksum:
  • platform/chromium-linux/fast/dom/HTMLProgressElement/progress-element-expected.png:
  • platform/chromium-linux/fast/forms/basic-inputs-expected.checksum:
  • platform/chromium-linux/fast/forms/basic-inputs-expected.png:
  • platform/chromium-linux/fast/forms/basic-selects-expected.checksum:
  • platform/chromium-linux/fast/forms/basic-selects-expected.png:
  • platform/chromium-linux/fast/forms/box-shadow-override-expected.checksum:
  • platform/chromium-linux/fast/forms/box-shadow-override-expected.png:
  • platform/chromium-linux/fast/forms/checkbox-radio-onchange-expected.checksum:
  • platform/chromium-linux/fast/forms/checkbox-radio-onchange-expected.png:
  • platform/chromium-linux/fast/forms/file-input-disabled-expected.checksum:
  • platform/chromium-linux/fast/forms/file-input-disabled-expected.png:
  • platform/chromium-linux/fast/forms/form-element-geometry-expected.checksum:
  • platform/chromium-linux/fast/forms/form-element-geometry-expected.png:
  • platform/chromium-linux/fast/forms/formmove-expected.checksum:
  • platform/chromium-linux/fast/forms/formmove-expected.png:
  • platform/chromium-linux/fast/forms/formmove2-expected.checksum:
  • platform/chromium-linux/fast/forms/formmove2-expected.png:
  • platform/chromium-linux/fast/forms/indeterminate-expected.checksum:
  • platform/chromium-linux/fast/forms/indeterminate-expected.png:
  • platform/chromium-linux/fast/forms/input-appearance-height-expected.checksum:
  • platform/chromium-linux/fast/forms/input-appearance-height-expected.png:
  • platform/chromium-linux/fast/forms/input-value-expected.checksum:
  • platform/chromium-linux/fast/forms/input-value-expected.png:
  • platform/chromium-linux/fast/forms/menulist-restrict-line-height-expected.checksum:
  • platform/chromium-linux/fast/forms/menulist-restrict-line-height-expected.png:
  • platform/chromium-linux/fast/forms/menulist-style-color-expected.checksum:
  • platform/chromium-linux/fast/forms/menulist-style-color-expected.png:
  • platform/chromium-linux/fast/forms/placeholder-position-expected.checksum:
  • platform/chromium-linux/fast/forms/placeholder-position-expected.png: Added property svn:mime-type.
  • platform/chromium-linux/fast/forms/radio-attr-order-expected.checksum:
  • platform/chromium-linux/fast/forms/radio-attr-order-expected.png:
  • platform/chromium-linux/fast/forms/radio-nested-labels-expected.checksum:
  • platform/chromium-linux/fast/forms/radio-nested-labels-expected.png:
  • platform/chromium-linux/fast/forms/radio_checked-expected.checksum:
  • platform/chromium-linux/fast/forms/radio_checked-expected.png:
  • platform/chromium-linux/fast/forms/radio_checked_dynamic-expected.checksum:
  • platform/chromium-linux/fast/forms/radio_checked_dynamic-expected.png:
  • platform/chromium-linux/fast/forms/select-baseline-expected.checksum:
  • platform/chromium-linux/fast/forms/select-baseline-expected.png:
  • platform/chromium-linux/fast/inline/positionedLifetime-expected.checksum:
  • platform/chromium-linux/fast/inline/positionedLifetime-expected.png:
  • platform/chromium-linux/fast/parser/bad-xml-slash-expected.checksum:
  • platform/chromium-linux/fast/parser/bad-xml-slash-expected.png:
  • platform/chromium-linux/fast/replaced/replaced-breaking-expected.checksum:
  • platform/chromium-linux/fast/replaced/replaced-breaking-expected.png:
  • platform/chromium-linux/fast/replaced/width100percent-checkbox-expected.checksum:
  • platform/chromium-linux/fast/replaced/width100percent-checkbox-expected.png:
  • platform/chromium-linux/fast/text/textIteratorNilRenderer-expected.checksum:
  • platform/chromium-linux/fast/text/textIteratorNilRenderer-expected.png:
  • platform/chromium-linux/fast/text/whitespace/normal-after-nowrap-breaking-expected.checksum:
  • platform/chromium-linux/fast/text/whitespace/normal-after-nowrap-breaking-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug1318-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug1318-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug4527-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug4527-expected.png: Added property svn:mime-type.
  • platform/chromium-linux/tables/mozilla_expected_failures/core/captions1-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/core/captions1-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/core/captions2-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/core/captions2-expected.png:

2011-01-21 Xiyuan Xia <xiyuan@chromium.org>

Reviewed by Tony Chang.

Use WebThemeEngine for relevant RenderTheme parts for chromium/linux.
https://bugs.webkit.org/show_bug.cgi?id=52826

  • platform/chromium/ChromiumBridge.h:
  • rendering/RenderThemeChromiumLinux.cpp: (WebCore::getWebThemeState): (WebCore::RenderThemeChromiumLinux::adjustSliderThumbSize): (WebCore::RenderThemeChromiumLinux::paintCheckbox): (WebCore::RenderThemeChromiumLinux::setCheckboxSize): (WebCore::RenderThemeChromiumLinux::paintRadio): (WebCore::RenderThemeChromiumLinux::setRadioSize): (WebCore::RenderThemeChromiumLinux::paintButton): (WebCore::RenderThemeChromiumLinux::paintTextField): (WebCore::RenderThemeChromiumLinux::paintMenuList): (WebCore::RenderThemeChromiumLinux::paintSliderTrack): (WebCore::RenderThemeChromiumLinux::paintSliderThumb): (WebCore::RenderThemeChromiumLinux::adjustInnerSpinButtonStyle): (WebCore::RenderThemeChromiumLinux::paintInnerSpinButton): (WebCore::RenderThemeChromiumLinux::paintProgressBar):
  • rendering/RenderThemeChromiumLinux.h:
  • rendering/RenderThemeChromiumSkia.cpp: (WebCore::RenderThemeChromiumSkia::setCheckboxSize): (WebCore::RenderThemeChromiumSkia::setSizeIfAuto): (WebCore::RenderThemeChromiumSkia::indeterminateProgressValueRectFor):
  • rendering/RenderThemeChromiumSkia.h:

2011-01-21 Xiyuan Xia <xiyuan@chromium.org>

Reviewed by Tony Chang.

Use WebThemeEngine for relevant RenderTheme parts for chromium/linux.
https://bugs.webkit.org/show_bug.cgi?id=52826

  • WebKit.gyp:
  • src/ChromiumBridge.cpp: (WebCore::WebThemePart): (WebCore::GetWebThemeExtraParams):
12:15 PM Changeset in webkit [76378] by weinig@apple.com
  • 59 edits
    2 moves in trunk/Source

Part 2 of "Cleanup Scrollbar/ScrollbarClient relationship"
https://bugs.webkit.org/show_bug.cgi?id=52779

Reviewed by Anders Carlsson.

Rename ScrollbarClient -> ScrollableArea.

Source/WebCore:

  • Also replaces Scrollbar::setClient with Scrollbar::disconnectFromScrollableArea since that was its only use case.
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • accessibility/AccessibilityScrollbar.cpp:

(WebCore::AccessibilityScrollbar::setValue):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):

  • page/FrameView.h:
  • platform/PopupMenuClient.h:
  • platform/ScrollAnimator.cpp:

(WebCore::ScrollAnimator::create):
(WebCore::ScrollAnimator::ScrollAnimator):
(WebCore::ScrollAnimator::scroll):
(WebCore::ScrollAnimator::notityPositionChanged):

  • platform/ScrollAnimator.h:
  • platform/ScrollAnimatorWin.cpp:

(WebCore::ScrollAnimator::create):
(WebCore::ScrollAnimatorWin::ScrollAnimatorWin):
(WebCore::ScrollAnimatorWin::scroll):

  • platform/ScrollAnimatorWin.h:
  • platform/ScrollView.cpp:

(WebCore::ScrollView::scroll):
(WebCore::ScrollView::updateScrollbars):
(WebCore::ScrollView::wheelEvent):

  • platform/ScrollView.h:
  • platform/ScrollableArea.cpp: Copied from WebCore/platform/ScrollbarClient.cpp.

(WebCore::ScrollableArea::ScrollableArea):
(WebCore::ScrollableArea::~ScrollableArea):
(WebCore::ScrollableArea::scroll):
(WebCore::ScrollableArea::scrollToOffsetWithoutAnimation):
(WebCore::ScrollableArea::scrollToXOffsetWithoutAnimation):
(WebCore::ScrollableArea::scrollToYOffsetWithoutAnimation):
(WebCore::ScrollableArea::setScrollOffsetFromAnimation):

  • platform/ScrollableArea.h: Copied from WebCore/platform/ScrollbarClient.h.
  • platform/Scrollbar.cpp:

(WebCore::Scrollbar::createNativeScrollbar):
(WebCore::Scrollbar::Scrollbar):
(WebCore::Scrollbar::offsetDidChange):
(WebCore::Scrollbar::autoscrollPressedPart):
(WebCore::Scrollbar::moveThumb):
(WebCore::Scrollbar::mouseMoved):
(WebCore::Scrollbar::isWindowActive):
(WebCore::Scrollbar::invalidateRect):
(WebCore::Scrollbar::convertToContainingView):
(WebCore::Scrollbar::convertFromContainingView):

  • platform/Scrollbar.h:

(WebCore::Scrollbar::disconnectFromScrollableArea):
(WebCore::Scrollbar::scrollableArea):

  • platform/ScrollbarClient.cpp: Removed.
  • platform/ScrollbarClient.h: Removed.
  • platform/ScrollbarThemeComposite.cpp:
  • platform/chromium/FramelessScrollView.h:
  • platform/chromium/ScrollbarThemeChromium.cpp:

(WebCore::ScrollbarThemeChromium::paintTickmarks):

  • platform/efl/ScrollbarEfl.cpp:

(Scrollbar::createNativeScrollbar):
(ScrollbarEfl::ScrollbarEfl):
(scrollbarEflEdjeMessage):

  • platform/efl/ScrollbarEfl.h:
  • platform/gtk/MainFrameScrollbarGtk.cpp:

(MainFrameScrollbarGtk::create):
(MainFrameScrollbarGtk::MainFrameScrollbarGtk):
(MainFrameScrollbarGtk::gtkValueChanged):

  • platform/gtk/MainFrameScrollbarGtk.h:
  • platform/mac/ScrollAnimatorMac.h:
  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimator::create):
(WebCore::ScrollAnimatorMac::ScrollAnimatorMac):
(WebCore::ScrollAnimatorMac::scroll):

  • platform/mac/ScrollbarThemeMac.mm:

(WebCore::ScrollbarThemeMac::paint):

  • platform/qt/ScrollbarQt.cpp:

(WebCore::Scrollbar::contextMenu):

  • platform/win/PopupMenuWin.cpp:

(WebCore::PopupMenuWin::scrollToRevealSelection):
(WebCore::PopupMenuWin::wndProc):

  • platform/win/PopupMenuWin.h:
  • platform/win/ScrollbarThemeSafari.cpp:

(WebCore::ScrollbarThemeSafari::paintTrackBackground):
(WebCore::ScrollbarThemeSafari::paintButton):
(WebCore::ScrollbarThemeSafari::paintThumb):

  • platform/wx/ScrollbarThemeWx.cpp:

(WebCore::ScrollbarThemeWx::paint):

  • rendering/RenderDataGrid.h:
  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::scrollToOffset):
(WebCore::RenderLayer::destroyScrollbar):
(WebCore::RenderLayer::scroll):

  • rendering/RenderLayer.h:
  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::scrollToRevealElementAtListIndex):
(WebCore::RenderListBox::scroll):
(WebCore::RenderListBox::logicalScroll):
(WebCore::RenderListBox::setScrollTop):
(WebCore::RenderListBox::destroyScrollbar):

  • rendering/RenderListBox.h:
  • rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::createScrollbar):

  • rendering/RenderMenuList.h:
  • rendering/RenderScrollbar.cpp:

(WebCore::RenderScrollbar::createCustomScrollbar):
(WebCore::RenderScrollbar::RenderScrollbar):

  • rendering/RenderScrollbar.h:
  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::createScrollbar):

  • rendering/RenderTextControlSingleLine.h:

Source/WebKit/chromium:

  • src/AutoFillPopupMenuClient.cpp:

(WebKit::AutoFillPopupMenuClient::createScrollbar):

  • src/AutoFillPopupMenuClient.h:
  • src/WebScrollbarImpl.cpp:

(WebKit::WebScrollbarImpl::WebScrollbarImpl):
(WebKit::WebScrollbarImpl::scroll):
(WebKit::WebScrollbarImpl::onMouseWheel):
(WebKit::WebScrollbarImpl::onKeyDown):

  • src/WebScrollbarImpl.h:
  • tests/PopupMenuTest.cpp:

(WebKit::TestPopupMenuClient::createScrollbar):

Source/WebKit/qt:

  • Api/qwebframe.cpp:

(QWebFrame::setScrollBarValue):

Source/WebKit/win:

  • WebScrollBar.cpp:

(WebScrollBar::scroll):

  • WebScrollBar.h:

Source/WebKit2:

  • UIProcess/win/WebPopupMenuProxyWin.cpp:

(WebKit::WebPopupMenuProxyWin::onMouseWheel):
(WebKit::WebPopupMenuProxyWin::scrollToRevealSelection):

  • UIProcess/win/WebPopupMenuProxyWin.h:
12:13 PM Changeset in webkit [76377] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/chromium

2011-01-21 Sailesh Agrawal <sail@chromium.org>

Reviewed by Ryosuke Niwa.

[chromium] Notify WebFrameClient when spellcheck state changes
https://bugs.webkit.org/show_bug.cgi?id=52680

  • public/WebFrameClient.h: (WebKit::WebFrameClient::continuousSpellCheckingEnabledStateChanged):
  • src/EditorClientImpl.cpp: (WebKit::EditorClientImpl::toggleContinuousSpellChecking):
  • src/WebFrameImpl.cpp:
12:01 PM Changeset in webkit [76376] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-01-21 Peter Gal <galpeter@inf.u-szeged.hu>

Reviewed by Darin Adler.

REGRESSION(r76177): All JavaScriptCore tests fail on ARM
https://bugs.webkit.org/show_bug.cgi?id=52814

Get the approximateByteSize value before releasing the OwnPtr.

  • parser/JSParser.cpp: (JSC::JSParser::parseFunctionInfo):
11:51 AM Changeset in webkit [76375] by darin@apple.com
  • 2 edits in trunk/Source/WebCore

Fix Leopard build.

  • rendering/mathml/RenderMathMLFraction.cpp:

(WebCore::RenderMathMLFraction::layout): Use ceilf instead of ceil.

11:44 AM Changeset in webkit [76374] by simon.fraser@apple.com
  • 2 edits in trunk/Source/WebCore

2011-01-21 Simon Fraser <simon.fraser@apple.com>

Reviewed by Sam Weinig.

GraphicsLayer should be non-copyable
https://bugs.webkit.org/show_bug.cgi?id=52909

Use WTF_MAKE_NONCOPYABLE on GraphicsLayer, and WTF_MAKE_FAST_ALLOCATED
on that and KeyframeValueList.

  • platform/graphics/GraphicsLayer.h:
11:40 AM Changeset in webkit [76373] by antonm@chromium.org
  • 3 edits
    2 adds in trunk

2011-01-21 Anton Muhin <antonm@chromium.org>

Reviewed by Nate Chapin.

[v8] Properly deal with the case when conversion to string throws an exception for HTMLCollection accessors
https://bugs.webkit.org/show_bug.cgi?id=52901

  • fast/dom/htmlcollection-conversion-throws-exception-expected.txt: Added.
  • fast/dom/htmlcollection-conversion-throws-exception.html: Added.

2011-01-21 Anton Muhin <antonm@chromium.org>

Reviewed by Nate Chapin.

[v8] Properly deal with the case when conversion to string throws an exception for HTMLCollection accessors
https://bugs.webkit.org/show_bug.cgi?id=52901

Test: fast/dom/htmlcollection-conversion-throws-exception.html

  • bindings/v8/custom/V8HTMLCollectionCustom.cpp: (WebCore::getItem):
11:35 AM Changeset in webkit [76372] by Adam Roben
  • 7 edits
    2 adds in trunk/Source

Separate flushing layer changes from rendering in CACFLayerTreeHost

Old model:

1) A change is made to a GraphicsLayer.
2) CACFLayerTreeHost::flushPendingGraphicsLayerChangesSoon is called, which schedules the

render timer.

3) The timer fires, which calls through to CACFLayerTreeHost::render, which performs the

flush and then renders.

New model:

1) A change is made to a GraphicsLayer.
2) CACFLayerTreeHost::flushPendingGraphicsLayerChangesSoon is called, which tells the new

LayerChangesFlusher singleton that this host has changes that need to be flushed.

3) LayerChangesFlusher sets up a Windows hook that will get called on the next iteration

of the message loop.

4) LayerChangesFlusher's hook is called, which calls through to

CACFLayerTreeHost::flushPendingLayerChangesNow.

5) CACFLayerTreeHost::flushPendingLayerChangesNow schedules the render timer so the changes

that were just flushed to the context will be rendered.

When a change is made to a PlatformCALayer that doesn't have a corresponding GraphicsLayer
(e.g., for rendering <video>), CACFLayerTreeHost::layerTreeDidChange takes care of
scheduling the flush.

This change has three advantages:

1) Whenever we flush layer changes, we first update layout. This can cause the page to

leave compositing mode, which in turn can cause all references to the CACFLayerTreeHost
to be dropped. By separating flushing (and thus updating layout) from rendering, we no
longer have to worry about this happen during rendering.

2) The new model is much more similar to how things work on the Mac, so will hopefully

reduce the number of platform-specific bugs.

3) CACFLayerTreeHost::shouldRender, which was used to make sure we didn't render while a

layout was pending, is no longer needed. It actually hasn't been needed since at least
r75987, but removing it before now would have resulted in a crash whenever a page came
out of compositing mode due to (1).

Fixes <http://webkit.org/b/52852> Flushing layer changes and rendering are intertwined in
CACFLayerTreeHost, but shouldn't be

Reviewed by Simon Fraser.

Source/WebCore:

  • WebCore.vcproj/WebCore.vcproj: Added LayerChangesFlusher.
  • platform/graphics/ca/win/CACFLayerTreeHost.cpp: Added new #include, sorted existing #includes.

(WebCore::CACFLayerTreeHost::CACFLayerTreeHost): Initialize new member.
(WebCore::CACFLayerTreeHost::layerTreeDidChange): If we aren't already flushing changes,
schedule a flush. Removed the call to renderSoon(), which now happens when the flush is
finished.
(WebCore::CACFLayerTreeHost::destroyRenderer): Cancel any pending flush we had scheduled. Also
fixed a bug where we'd fail to clear the context's layer.
(WebCore::CACFLayerTreeHost::render): Removed code to ask the client if we should render, which
is no longer needed. Moved code to flush layer changes from here to
flushPendingLayerChangesNow, which is called via the above-described mechanism.
(WebCore::CACFLayerTreeHost::flushPendingGraphicsLayerChangesSoon): Schedule a flush. Removed
code to schedule a render, which now happens after we've flushed.
(WebCore::CACFLayerTreeHost::flushPendingLayerChangesNow): Added. Some of this code came from
render(). First we flush GraphicsLayer changes from GraphicsLayers to their underlying
PlatformCALayers, then we flush changes from PlatformCALayers to the context, then we
schedule a render so that the changes will be rendered to the screen.

  • platform/graphics/ca/win/CACFLayerTreeHost.h: Removed

CACFLayerTreeHostClient::shouldRender. Added flushPendingLayerChangesNow and
m_isFlushingLayerChanges.

  • platform/graphics/ca/win/LayerChangesFlusher.cpp: Added.

(WebCore::LayerChangesFlusher::shared):
(WebCore::LayerChangesFlusher::LayerChangesFlusher):
(WebCore::LayerChangesFlusher::flushPendingLayerChangesSoon):
(WebCore::LayerChangesFlusher::cancelPendingFlush):
(WebCore::LayerChangesFlusher::hookCallback):
(WebCore::LayerChangesFlusher::hookFired):
(WebCore::LayerChangesFlusher::setHook):
(WebCore::LayerChangesFlusher::removeHook):

  • platform/graphics/ca/win/LayerChangesFlusher.cpp: Added.

(WebCore::LayerChangesFlusher::shared): Returns the singleton.
(WebCore::LayerChangesFlusher::LayerChangesFlusher): Initialize our members.
(WebCore::LayerChangesFlusher::flushPendingLayerChangesSoon): Add the host to the set of
hosts with changes that need to be flushed, and set up our hook if we haven't already.
(WebCore::LayerChangesFlusher::cancelPendingFlush): Remove the host from the set of hosts
with changes that need to be flushed. If we have no more such hosts, remove our hook, unless
we're currently in the process of calling out to our hosts, in which case we'll take care of
the hook once we're done calling out.
(WebCore::LayerChangesFlusher::hookCallback): This is the function that Windows calls when
our hook fires. Just calls through to hookFired on the singleton.
(WebCore::LayerChangesFlusher::hookFired): Tell all the hosts with changes that needed to be
flushed that it's time to flush. If no hosts re-added themselves to our set during this
process, remove our hook.
(WebCore::LayerChangesFlusher::setHook): Calls through to ::SetWindowsHookExW.
(WebCore::LayerChangesFlusher::removeHook): Calls through to ::UnhookWindowsHookEx.

  • platform/graphics/ca/win/LayerChangesFlusher.h: Added.

Source/WebKit/win:

Update for CACFLayerTreeHost changes

  • WebView.cpp:

(WebView::paint): Changed to flush layer changes via CACFLayerTreeHost, which will call back
to our own flushing function if needed.

  • WebView.h: Removed shouldRender, which is no longer used or needed.
11:33 AM Changeset in webkit [76371] by simon.fraser@apple.com
  • 19 edits in trunk/Source/WebCore

2011-01-21 Simon Fraser <simon.fraser@apple.com>

Reviewed by Sam Weinig.

Report the sized used by canvases and types arrays
https://bugs.webkit.org/show_bug.cgi?id=52856

Report the memory cost associated with canvas elements,
and typed arrays to JavaScript as extraCost, so that it
can figure this into its GC behavior.

  • bindings/js/JSArrayBufferViewHelper.h: (WebCore::toJSArrayBufferView): New templatized function, similar to getDOMObjectWrapper() but calls reportExtraMemoryCost() with the byteLength of the array.
  • bindings/js/JSFloat32ArrayCustom.cpp: (WebCore::toJS): Use toJSArrayBufferView.
  • bindings/js/JSInt16ArrayCustom.cpp: (WebCore::toJS): Use toJSArrayBufferView.
  • bindings/js/JSInt32ArrayCustom.cpp: (WebCore::toJS): Use toJSArrayBufferView.
  • bindings/js/JSInt8ArrayCustom.cpp: (WebCore::toJS): Use toJSArrayBufferView.
  • bindings/js/JSUint16ArrayCustom.cpp: (WebCore::toJS): Use toJSArrayBufferView.
  • bindings/js/JSUint32ArrayCustom.cpp: (WebCore::toJS): Use toJSArrayBufferView.
  • bindings/js/JSUint8ArrayCustom.cpp: (WebCore::toJS): Use toJSArrayBufferView.
  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::createImageBuffer): Call heap.reportExtraMemoryCost() with the size of the canvas backing store.
  • html/canvas/TypedArrayBase.h: (WebCore::TypedArrayBase::byteLength): byteLength needs to be public.
  • platform/graphics/ImageBuffer.h: Add dataSize() method.
  • platform/graphics/cairo/ImageBufferCairo.cpp: (WebCore::ImageBuffer::dataSize): Implement dataSize().
  • platform/graphics/cg/ImageBufferCG.cpp: (WebCore::ImageBuffer::dataSize): Implement dataSize().
  • platform/graphics/haiku/ImageBufferHaiku.cpp: (WebCore::ImageBuffer::dataSize): Implement dataSize().
  • platform/graphics/qt/ImageBufferQt.cpp: (WebCore::ImageBuffer::dataSize): Implement dataSize().
  • platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::ImageBuffer::dataSize): Implement dataSize().
  • platform/graphics/wince/ImageBufferWinCE.cpp: (WebCore::ImageBuffer::dataSize): Implement dataSize().
  • platform/graphics/wx/ImageBufferWx.cpp: (WebCore::ImageBuffer::dataSize): Implement dataSize().
11:32 AM Changeset in webkit [76370] by Adam Roben
  • 13 edits
    2 moves in trunk/Source

Rename WKCACFLayerRenderer[Client] to CACFLayerTreeHost[Client]

Also renamed a few functions and data members to match.

Fixes <http://webkit.org/b/52898> WKCACFLayerRenderer sounds like a render object, but isn't

Reviewed by Simon Fraser.

Source/WebCore:

  • WebCore.vcproj/WebCore.vcproj: Updated files' names and paths.
  • WebCore.vcproj/WebCoreQuartzCore.vsprops: Added platform/graphics/ca/win to the include

path.

  • WebCore.vcproj/copyForwardingHeaders.cmd: Copy headers from platform/graphics/ca/win, too.
  • platform/graphics/ca/win/CACFLayerTreeHost.cpp: Renamed from Source/WebCore/platform/graphics/win/WKCACFLayerRenderer.cpp.
  • platform/graphics/ca/win/CACFLayerTreeHost.h: Renamed from Source/WebCore/platform/graphics/win/WKCACFLayerRenderer.h.
  • platform/graphics/ca/win/PlatformCALayerWin.cpp:
  • platform/graphics/win/MediaPlayerPrivateFullscreenWindow.cpp:
  • platform/graphics/win/MediaPlayerPrivateFullscreenWindow.h:

Updated for renames.

Source/WebKit/win:

Update for WKCACFLayerRenderer -> CACFLayerTreeHost rename

Also renamed WebView::m_layerRenderer to WebView::m_layerTreeHost to match.

  • WebPreferences.cpp:
  • WebView.cpp:

(WebView::setAcceleratedCompositing): Also made sure to remove our HWND from the layer tree
host before we get rid of the layer tree host itself.

  • WebView.h:

Source/WebKit2:

Update for WKCACFLayerRenderer -> CACFLayerView rename

  • WebProcess/WebPage/win/LayerBackedDrawingAreaWin.cpp: Just removed all the unnecessary #includes.
11:32 AM Changeset in webkit [76369] by xan@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-01-21 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

Remove unnecessary <stdio.h> include
https://bugs.webkit.org/show_bug.cgi?id=52884

  • jit/JIT.cpp: remove unnecessary include.
11:27 AM Changeset in webkit [76368] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-01-21 Patrick Gansterer <paroga@paroga.com>

Original patch from François Sausset <François Sausset>

Reviewed by Darin Adler.

Code cleaning in rendering/mathml/RenderMathMLFraction.cpp
https://bugs.webkit.org/show_bug.cgi?id=52201

Replace unneeded doubles by floats and remove unneeded casts.

  • rendering/mathml/RenderMathMLFraction.cpp: (WebCore::RenderMathMLFraction::paint):
  • rendering/mathml/RenderMathMLFraction.h:
11:20 AM Changeset in webkit [76367] by levin@chromium.org
  • 2 edits in trunk/Websites/webkit.org

Proposal: Require cross-organizational seconds for reviewer nominations
https://bugs.webkit.org/show_bug.cgi?id=47597

Reviewed by Darin Adler.

This changes the committer/reviewer policy to require an additional
reviewer supporting a reviewer nomination to work for a different
company and different project affiliation from the nominee.

This means reviewer nominations would require four supporting reviewers,
one of which knows the reviewer through the community (irc, email, bugs)
ensuring that the nominee has the open-source collaboration skills
we so highly value here in WebKit.

  • coding/commit-review-policy.html:
11:20 AM Changeset in webkit [76366] by Dimitri Glazkov
  • 4 edits
    2 adds in trunk

2011-01-21 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

REGRESSION(r73618): Clicking on a search input causes a crash.
https://bugs.webkit.org/show_bug.cgi?id=52905

  • fast/dom/search-shadow-host-crash-expected.txt: Added.
  • fast/dom/search-shadow-host-crash.html: Added.

2011-01-21 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

REGRESSION(r73618): Clicking on a search input causes a crash.
https://bugs.webkit.org/show_bug.cgi?id=52905

The problem is caused by TextControlInnerElement being used both as
shadow root and an element in a shadow subtree. The code assumed it is
only used as a shadow root.

Since this code is all just workaround for in-progress conversion to
new shadow DOM, I am just adding a check. This code will disappear
completely once bug 52788 is fixed.

Test: fast/dom/search-shadow-host-crash.html

  • dom/Node.cpp: (WebCore::Node::setShadowHost): Added an ASSERT for early detection

of attempting to stomp on the parentNode.

  • rendering/TextControlInnerElements.cpp: (WebCore::TextControlInnerElement::detach): Added a check to only

clear shadow host if we have one.

11:05 AM Changeset in webkit [76365] by Dimitri Glazkov
  • 3 edits in trunk/LayoutTests

2011-01-21 Dimitri Glazkov <Dimitri Glazkov>

Updated slider expectations after r76147.

  • platform/chromium/test_expectations.txt: Removed test that will start passing.
  • platform/chromium-win/fast/forms/slider-mouse-events-expected.txt: Updated expectation.
11:00 AM Changeset in webkit [76364] by xji@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

2011-01-21 Xiaomei Ji <xji@chromium.org>

Unreviewed.

Rebaseline for leopard after r76319.

  • platform/mac-leopard/fast/dom/52776-expected.txt: Added.
10:50 AM Changeset in webkit [76363] by tony@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-01-21 Tony Chang <tony@chromium.org>

Unreviewed, updating chromium DEPS so we can pull in linux theme changes.

  • DEPS:
10:44 AM Changeset in webkit [76362] by darin@apple.com
  • 2 edits in trunk/Tools

Fix Mac build.

  • MiniBrowser/mac/BrowserWindowController.m:

(-[BrowserWindowController awakeFromNib]): Pass 0 for runModal function.

10:41 AM Changeset in webkit [76361] by darin@apple.com
  • 18 edits in trunk

WebKit2: Implement showModalDialog
https://bugs.webkit.org/show_bug.cgi?id=52855

Reviewed by Dan Bernstein.

Source/WebKit2:

  • Shared/WebPageCreationParameters.h: Added canRunModal.
  • UIProcess/API/C/WKPage.h: Added a runModal function pointer to

WKPageUIClient. Also removed a lot of redundant typedefs and added
a new one, WKPageCallback, for callbacks without arguments or return
values.

  • UIProcess/API/qt/qwkpage.cpp:

(QWKPage::QWKPage): Added a runModal function pointer of 0.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::creationParameters): Set canRunModal
based on return value of WebUIClient::canRunModal.

  • UIProcess/WebPageProxy.h: Added runModal.

Calls WebUIClient::runModal.

  • UIProcess/WebPageProxy.messages.in: Added RunModal message.

Also removed the periods from the phrases in the comments
as Maciej requested a while back.

  • UIProcess/WebUIClient.cpp:

(WebKit::WebUIClient::canRunModal): Added. Returns true or false
based on whether a runModal function was supplied in the
WKPageUIClient structure.
(WebKit::WebUIClient::runModal): Added. Calls the runModal
function from the WKPageUIClient structure.

  • UIProcess/WebUIClient.h: Declared the above functions.
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::canRunModal): Call through to WebPage.
(WebKit::WebChromeClient::runModal): Ditto.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage): Initialize m_canRunModal based on the
creation parameters. Initialize m_isRunningModal to false.
(WebKit::WebPage::close): Stop the nested run loop if we are running modal.
(WebKit::WebPage::runModal): Send a message to ask the UI process to run
modal and then start a nested run loop. It gets stopped when the page is closed.

  • WebProcess/WebPage/WebPage.h: Defined the canRunModal function

and declared the runModal function.

Tools:

This fixes WebKitTestRunner to compile, but more work is probably
needed to get it to pass the tests.

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::runModal): Added. Calls through to the
platform-specific version of runModal.
(WTR::TestController::createOtherPage): Changed to be a private
static member function so it can refer to runModal, which is
a private static member function.
(WTR::TestController::initialize): Pass 0 for the runModal
function since we don't need to run the main window modal.
I suspect this is wrong and will need to change.

  • WebKitTestRunner/TestController.h: Added declarations for

the functions added above.

  • WebKitTestRunner/mac/TestControllerMac.mm:

(WTR::TestController::runModal): Added. Untested implementation.

  • WebKitTestRunner/qt/TestControllerQt.cpp:

(WTR::TestController::runModal): Added.

  • WebKitTestRunner/win/TestControllerWin.cpp:

(WTR::TestController::runModal): Added.

10:41 AM Changeset in webkit [76360] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

2011-01-21 Kenji Imasaki <imasaki@chromium.org>

Reviewed by David Levin.

remove non-flaky tests from test expectation file
https://bugs.webkit.org/show_bug.cgi?id=52746

  • platform/chromium/test_expectations.txt:
10:31 AM Changeset in webkit [76359] by Adam Roben
  • 7 edits in trunk/Source

Replace some "sync compositing state" terminology with "flush pending GraphicsLayer changes"

This seems to be the direction in which our code is moving. I chose "GraphicsLayer" as
opposed to just "layer" because there are cases where we flush changes to CACFLayers that
don't have a corresponding GraphicsLayer.

Fixes <http://webkit.org/b/52894> "Sync compositing state" terminology in
WKCACFLayerRenderer and friends is confusing

Reviewed by Simon Fraser.

Source/WebCore:

  • platform/graphics/win/WKCACFLayerRenderer.cpp:

(WebCore::WKCACFLayerRenderer::WKCACFLayerRenderer):
(WebCore::WKCACFLayerRenderer::render):
Updated for renames.

(WebCore::WKCACFLayerRenderer::flushPendingGraphicsLayerChangesSoon): Renamed from
syncCompositingStateSoon, and updated for other renames.

  • platform/graphics/win/WKCACFLayerRenderer.h: Renamed m_syncLayerChanges to
  • m_shouldFlushPendingGraphicsLayerChanges.

(WebCore::WKCACFLayerRendererClient::flushPendingGraphicsLayerChanges): Renamed from
syncCompositingState.

Source/WebKit/win:

  • WebCoreSupport/WebChromeClient.cpp:

(WebChromeClient::scheduleCompositingLayerSync): Updated for WebView changes.

  • WebView.cpp:

(WebView::paint): Updated for rename.
(WebView::flushPendingGraphicsLayerChangesSoon): Renamed from scheduleCompositingLayerSync.
(WebView::notifySyncRequired): Updated for rename.
(WebView::flushPendingGraphicsLayerChanges): Renamed from syncCompositingState.

  • WebView.h: Did the renames.
10:31 AM Changeset in webkit [76358] by Adam Roben
  • 2 edits in trunk/Source/WebCore

Clean up PlatformCAAnimationWin

Fixes <http://webkit.org/b/52904> PlatformCAAnimationWin is leaky and inefficient

Reviewed by Simon Fraser.

  • platform/graphics/ca/win/PlatformCAAnimationWin.cpp:

(toCACFFillModeType):
(fromCACFFillModeType):
(toCACFValueFunctionType):
(fromCACFValueFunctionType):
Changed to take and return CFStringRefs. There's no need to convert to WebCore::String just
so we can later convert back to CFStringRef.

(toCACFTimingFunction): Fixed leaks by changing this to return a RetainPtr and adopting the
results of CACFTimingFunctionCreate.
(PlatformCAAnimation::PlatformCAAnimation): Changed not to needlessly roundtrip through
WebCore::String. Also changed an ASSERT(0) to ASSERT_NOT_REACHED().

(PlatformCAAnimation::setFillMode):
(PlatformCAAnimation::setTimingFunction):
(PlatformCAAnimation::setValueFunction):
(PlatformCAAnimation::setTimingFunctions):
Updated for changes to the above conversion functions.

10:26 AM Changeset in webkit [76357] by commit-queue@webkit.org
  • 9 edits
    4 adds in trunk

2011-01-21 Charlie Reis <creis@chromium.org>

Reviewed by Darin Fisher.

FrameLoader::checkLoadCompleteForThisFrame uses wrong history item
https://bugs.webkit.org/show_bug.cgi?id=48812

Test that we avoid updating back/forward list on a canceled navigation
if a new navigation is already in process. Also update forward-and-cancel
to go forward, ensuring back/forward state is reset if user clicks stop.

  • http/tests/navigation/back-twice-without-commit-expected.txt: Added.
  • http/tests/navigation/back-twice-without-commit.html: Added.
  • http/tests/navigation/forward-and-cancel-expected.txt:
  • http/tests/navigation/forward-and-cancel.html: Go forward after stop, not back.
  • http/tests/navigation/resources/back-twice-page-2.html: Added.
  • http/tests/navigation/resources/back-twice-page-3.html: Added.
  • http/tests/navigation/resources/forward-and-cancel-frames.html: Reduced delay.

2011-01-21 Charlie Reis <creis@chromium.org>

Reviewed by Darin Fisher.

FrameLoader::checkLoadCompleteForThisFrame uses wrong history item
https://bugs.webkit.org/show_bug.cgi?id=48812

Most calls to stopAllLoaders now clear the history's provisional item(s).
We can now avoid resetting the back/forward state if a new navigation
is in progress.

Test: http/tests/navigation/back-twice-without-commit.html
Test: http/tests/navigation/forward-and-cancel.html

  • loader/FrameLoader.cpp:
  • loader/FrameLoader.h:
  • loader/FrameLoaderTypes.h:
  • WebCore.exp.in: Update stopAllLoaders signature.
10:09 AM Changeset in webkit [76356] by mihaip@chromium.org
  • 2 edits
    2 moves
    2 adds
    2 deletes in trunk/LayoutTests

2011-01-20 Mihai Parparita <mihaip@chromium.org>

Reviewed by Eric Seidel.

[Chromium] Update expectations for compositing/geometry/limit-layer-bounds-overflow-repaint.html
https://bugs.webkit.org/show_bug.cgi?id=52860

The test hasn't had a timeout in a while, remove that expectation so
that we can more easily see if this re-occurs.

Also rebaseline for chromium-gpu-mac (it has the green as 0,128,0, just
like chromium-gpu-win and -linux, for some reason the mac expectation
has it as 17,128,4).

  • platform/chromium-gpu-win/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.checksum: Removed.
  • platform/chromium-gpu-win/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.png: Removed.
  • platform/chromium-gpu/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.checksum: Renamed from LayoutTests/platform/chromium-gpu-linux/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.checksum.
  • platform/chromium-gpu/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.png: Renamed from LayoutTests/platform/chromium-gpu-linux/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.png.
  • platform/chromium-gpu/test_expectations.txt:
9:51 AM Changeset in webkit [76355] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-01-21 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed; Reverted the last change to the text expectation.

  • platform/chromium/test_expectations.txt:
9:39 AM Changeset in webkit [76354] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-01-21 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed Chromium test expectation update.

  • platform/chromium/test_expectations.txt:
9:33 AM Changeset in webkit [76353] by rniwa@webkit.org
  • 2 edits
    9 adds in trunk/LayoutTests

2011-01-21 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed Chromium rebaselines for 76319.

  • platform/chromium-linux/fast/dom/52776-expected.checksum: Added.
  • platform/chromium-linux/fast/dom/52776-expected.png: Added.
  • platform/chromium-linux/fast/dom/52776-expected.txt: Added.
  • platform/chromium-mac/fast/dom/52776-expected.checksum: Added.
  • platform/chromium-mac/fast/dom/52776-expected.png: Added.
  • platform/chromium-mac/fast/dom/52776-expected.txt: Added.
  • platform/chromium-win/fast/dom/52776-expected.checksum: Added.
  • platform/chromium-win/fast/dom/52776-expected.png: Added.
  • platform/chromium-win/fast/dom/52776-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
9:26 AM Changeset in webkit [76352] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

2011-01-21 Tony Chang <tony@chromium.org>

Unreviewed, these tests were fixed in r76330. Still one unknown
failure.

  • platform/chromium/test_expectations.txt:
9:21 AM Changeset in webkit [76351] by Carlos Garcia Campos
  • 6 edits in trunk/Source

2011-01-21 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Show caps lock indicator in password fields
https://bugs.webkit.org/show_bug.cgi?id=52878

Test: manual-tests/password-caps-lock.html

  • platform/gtk/KeyEventGtk.cpp: (WebCore::PlatformKeyboardEvent::currentCapsLockState): Implement currentCapsLockState() using GDK API.
  • platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::paintCapsLockIndicator): Paint an icon in the password field when the caps lock modifier is locked.
  • platform/gtk/RenderThemeGtk.h:

2011-01-21 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Show caps lock indicator in password fields
https://bugs.webkit.org/show_bug.cgi?id=52878

Test: manual-tests/password-caps-lock.html

  • webkit/webkitwebview.cpp: (webkit_web_view_key_release_event): Call capsLockStateMayHaveChanged() when caps lock key is pressed.
8:36 AM Changeset in webkit [76350] by jberlin@webkit.org
  • 5 edits in trunk/LayoutTests

Modify the Windows-specific results after http://trac.webkit.org/changeset/76208 in order to
get the bots green. Unreviewed.
https://bugs.webkit.org/show_bug.cgi?id=52557

  • platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/win/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/win/fast/dom/prototype-inheritance-expected.txt:
  • platform/win/fast/js/global-constructors-expected.txt:
8:22 AM Changeset in webkit [76349] by jberlin@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

Add Windows-specific results for fast/dom/52776.html to get the bot green. Unreviewed.
https://bugs.webkit.org/show_bug.cgi?id=52776

  • platform/win/fast/dom/52776-expected.txt: Added.
8:08 AM Changeset in webkit [76348] by podivilov@chromium.org
  • 9 edits in trunk/Source/WebCore

2011-01-21 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: move sticky breakpoints management from InspectorController to InspectorBrowserDebuggerAgent.
https://bugs.webkit.org/show_bug.cgi?id=52874

This is the first step of debugger api refactoring (see bug 52879).
JavaScript breakpoints are still in the same list as native breakpoints and are restored by InspectorBrowserDebuggerAgent.
The second step will be to move sticky JavaScript breakpoints to InspectorDebuggerAgent.

  • inspector/Inspector.idl:
  • inspector/InspectorBrowserDebuggerAgent.cpp: (WebCore::InspectorBrowserDebuggerAgent::setAllBrowserBreakpoints): (WebCore::InspectorBrowserDebuggerAgent::inspectedURLChanged): (WebCore::InspectorBrowserDebuggerAgent::restoreStickyBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::discardBindings): (WebCore::InspectorBrowserDebuggerAgent::didInsertDOMNode): (WebCore::InspectorBrowserDebuggerAgent::didRemoveDOMNode): (WebCore::InspectorBrowserDebuggerAgent::setDOMBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::removeDOMBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::descriptionForDOMEvent): (WebCore::InspectorBrowserDebuggerAgent::hasBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::updateSubtreeBreakpoints):
  • inspector/InspectorBrowserDebuggerAgent.h:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::restoreInspectorStateFromCookie): (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::didCommitLoad): (WebCore::InspectorController::enableDebugger): (WebCore::InspectorController::resume): (WebCore::InspectorController::inspectedURL):
  • inspector/InspectorController.h:
  • inspector/InspectorState.cpp: (WebCore::InspectorState::InspectorState):
  • inspector/InspectorState.h:
  • inspector/front-end/BreakpointManager.js: (WebInspector.BreakpointManager): (WebInspector.BreakpointManager.prototype._saveBreakpoints):
7:51 AM Changeset in webkit [76347] by jknotten@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-01-21 John Knottenbelt <jknotten@chromium.org>

Reviewed by Jeremy Orlow.

Turn off uninitialized errors for ARM linux build.
https://bugs.webkit.org/show_bug.cgi?id=52893

Fix ARM compiler breakage.

  • WebCore.gyp/WebCore.gyp:
7:00 AM Changeset in webkit [76346] by mnaganov@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-01-21 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Add layout test for the CPU profiler.

This test replaces DevToolsSanityTest.TestProfilerTab from
Chromium's interactive_ui_tests.

https://bugs.webkit.org/show_bug.cgi?id=52634

  • inspector/cpu-profiler-profiling-expected.txt: Added.
  • inspector/cpu-profiler-profiling.html: Added.

[Relanding, this time the test should work in Chromium]

6:41 AM Changeset in webkit [76345] by mnaganov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-01-21 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [Chromium] REGRESSION: Using the "Back" button
while profiling causes renderer crash.

https://bugs.webkit.org/show_bug.cgi?id=52808

  • inspector/InspectorProfilerAgent.cpp: (WebCore::InspectorProfilerAgent::addProfileFinishedMessageToConsole): (WebCore::InspectorProfilerAgent::addStartProfilingMessageToConsole):
4:30 AM Changeset in webkit [76344] by loislo@chromium.org
  • 6 edits in trunk/Source/WebCore

2011-01-20 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: switch page/Console implementation from InspectorController to InspectorInstrumentation.

There are some places in WebCore where we still using direct InspectorController calls.
The idea is to pass all the Inspector related calls via InspectorInstrumentaion which is the
Inspector facade for WebCore.

https://bugs.webkit.org/show_bug.cgi?id=52869

  • inspector/InspectorController.cpp:
  • inspector/InspectorController.h:
  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::addProfileImpl): (WebCore::InspectorInstrumentation::profilerEnabledImpl): (WebCore::InspectorInstrumentation::getCurrentUserInitiatedProfileNameImpl):
  • inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::addProfile): (WebCore::InspectorInstrumentation::profilerEnabled): (WebCore::InspectorInstrumentation::getCurrentUserInitiatedProfileName):
  • page/Console.cpp: (WebCore::Console::profile): (WebCore::Console::profileEnd):
4:16 AM Changeset in webkit [76343] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed.

[Qt] editing/selection/rtl-move-selection-right-left.html fails
https://bugs.webkit.org/show_bug.cgi?id=52883

  • platform/qt/Skipped: editing/selection/rtl-move-selection-right-left.html added until fix.
4:08 AM Changeset in webkit [76342] by sergio@webkit.org
  • 2 edits in trunk/LayoutTests

2011-01-21 Sergio Villar Senin <svillar@igalia.com>

Unreviewed.

[GTK] http/tests/security/drag-drop-same-unique-origin.html fails on bots.
https://bugs.webkit.org/show_bug.cgi?id=52882

Skipping http/tests/security/drag-drop-same-unique-origin.html for gtk.

  • platform/gtk/Skipped:
3:59 AM Changeset in webkit [76341] by podivilov@chromium.org
  • 8 edits in trunk/Source/WebCore

2011-01-12 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: breakpoints are restored incorrectly when reverting live edit.
https://bugs.webkit.org/show_bug.cgi?id=52300

Fix breakpoints restoring when reverting to old revision by using text diff.
Move live edit logic from ScriptsPanel to DebuggerModel.
Eliminate unnecessary editLine delegate in TextViewer.

3:31 AM Changeset in webkit [76340] by commit-queue@webkit.org
  • 55 edits
    1 move
    1 delete in trunk/Source

2011-01-21 Adam Klein <adamk@chromium.org>

Reviewed by Eric Seidel.

[chromium] Rename ChromiumBridge to PlatformBridge
https://bugs.webkit.org/show_bug.cgi?id=52471

No tests added as this is a rename; no change in behavior.

  • WebCore.gypi:
  • bindings/v8/V8DOMWindowShell.cpp: (WebCore::reportFatalErrorInV8):
  • page/PageGroup.cpp: (WebCore::PageGroup::isLinkVisited):
  • platform/android/PlatformBridge.h:
  • platform/audio/chromium/AudioBusChromium.cpp: (WebCore::createBusFromInMemoryAudioFile):
  • platform/chromium/ChromiumBridge.h: Removed.
  • platform/chromium/ChromiumDataObjectLegacy.cpp: (WebCore::ChromiumDataObjectLegacy::getData):
  • platform/chromium/DragDataChromium.cpp: (WebCore::DragData::asURL):
  • platform/chromium/FileSystemChromium.cpp: (WebCore::deleteFile): (WebCore::deleteEmptyDirectory): (WebCore::getFileSize): (WebCore::getFileModificationTime): (WebCore::revealFolderInOS): (WebCore::directoryName): (WebCore::pathByAppendingComponent): (WebCore::makeAllDirectories): (WebCore::fileExists): (WebCore::openFile): (WebCore::closeFile): (WebCore::seekFile): (WebCore::truncateFile): (WebCore::readFromFile): (WebCore::writeToFile):
  • platform/chromium/LanguageChromium.cpp: (WebCore::platformDefaultLanguage):
  • platform/chromium/LinkHashChromium.cpp: (WebCore::visitedLinkHash):
  • platform/chromium/MIMETypeRegistryChromium.cpp: (WebCore::MIMETypeRegistry::getMIMETypeForExtension): (WebCore::MIMETypeRegistry::getPreferredExtensionForMIMEType): (WebCore::MIMETypeRegistry::isSupportedImageMIMEType): (WebCore::MIMETypeRegistry::isSupportedJavaScriptMIMEType): (WebCore::MIMETypeRegistry::isSupportedNonImageMIMEType):
  • platform/chromium/PasteboardChromium.cpp: (WebCore::Pasteboard::writeSelection): (WebCore::Pasteboard::writePlainText): (WebCore::Pasteboard::writeURL): (WebCore::Pasteboard::writeImage): (WebCore::Pasteboard::canSmartReplace): (WebCore::Pasteboard::plainText): (WebCore::Pasteboard::documentFragment):
  • platform/chromium/PlatformBridge.h:
  • platform/chromium/PlatformScreenChromium.cpp: (WebCore::screenDepth): (WebCore::screenDepthPerComponent): (WebCore::screenIsMonochrome): (WebCore::screenRect): (WebCore::screenAvailableRect):
  • platform/chromium/ReadableDataObject.cpp: (WebCore::ReadableDataObject::getData): (WebCore::ReadableDataObject::urlTitle): (WebCore::ReadableDataObject::htmlBaseUrl): (WebCore::ReadableDataObject::filenames): (WebCore::ReadableDataObject::ensureTypeCacheInitialized):
  • platform/chromium/SSLKeyGeneratorChromium.cpp: (WebCore::signedPublicKeyAndChallengeString):
  • platform/chromium/ScrollbarThemeChromium.cpp:
  • platform/chromium/ScrollbarThemeChromiumLinux.cpp: (WebCore::ScrollbarThemeChromiumLinux::scrollbarThickness): (WebCore::ScrollbarThemeChromiumLinux::paintTrackPiece): (WebCore::ScrollbarThemeChromiumLinux::paintButton): (WebCore::ScrollbarThemeChromiumLinux::paintThumb): (WebCore::ScrollbarThemeChromiumLinux::buttonSize): (WebCore::ScrollbarThemeChromiumLinux::minimumThumbLength):
  • platform/chromium/ScrollbarThemeChromiumMac.mm: (WebCore::scrollbarStateToThemeState): (WebCore::ScrollbarThemeChromiumMac::paint):
  • platform/chromium/ScrollbarThemeChromiumWin.cpp: (WebCore::ScrollbarThemeChromiumWin::scrollbarThickness): (WebCore::ScrollbarThemeChromiumWin::paintTrackPiece): (WebCore::ScrollbarThemeChromiumWin::paintButton): (WebCore::ScrollbarThemeChromiumWin::paintThumb): (WebCore::ScrollbarThemeChromiumWin::buttonSize):
  • platform/chromium/SharedTimerChromium.cpp: (WebCore::setSharedTimerFiredFunction): (WebCore::setSharedTimerFireTime): (WebCore::stopSharedTimer):
  • platform/chromium/SuddenTerminationChromium.cpp: (WebCore::disableSuddenTermination): (WebCore::enableSuddenTermination):
  • platform/chromium/SystemTimeChromium.cpp: (WebCore::currentTime):
  • platform/chromium/WritableDataObject.cpp: (WebCore::WritableDataObject::setData):
  • platform/graphics/chromium/CrossProcessFontLoading.mm:
  • platform/graphics/chromium/FontCacheChromiumWin.cpp: (WebCore::fontContainsCharacter): (WebCore::FillLogFont):
  • platform/graphics/chromium/FontCacheLinux.cpp: (WebCore::FontCache::getFontDataForCharacters):
  • platform/graphics/chromium/FontChromiumWin.cpp: (WebCore::Font::drawGlyphs):
  • platform/graphics/chromium/FontPlatformDataChromiumWin.cpp: (WebCore::FontPlatformData::scriptFontProperties):
  • platform/graphics/chromium/FontPlatformDataLinux.cpp: (WebCore::FontPlatformData::querySystemForRenderStyle):
  • platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp: (WebCore::fillBMPGlyphs):
  • platform/graphics/chromium/ImageChromium.cpp: (WebCore::Image::loadPlatformResource):
  • platform/graphics/chromium/ImageChromiumMac.mm: (WebCore::Image::loadPlatformResource):
  • platform/graphics/chromium/SimpleFontDataChromiumWin.cpp: (WebCore::SimpleFontData::platformInit): (WebCore::SimpleFontData::determinePitch): (WebCore::SimpleFontData::platformWidthForGlyph):
  • platform/graphics/chromium/UniscribeHelperTextRun.cpp: (WebCore::UniscribeHelperTextRun::tryToPreloadFont):
  • platform/graphics/skia/FontCustomPlatformData.cpp: (WebCore::FontCustomPlatformData::fontPlatformData):
  • platform/network/chromium/CookieJarChromium.cpp: (WebCore::setCookies): (WebCore::cookies): (WebCore::cookieRequestHeaderFieldValue): (WebCore::cookiesEnabled): (WebCore::getRawCookies): (WebCore::deleteCookie):
  • platform/network/chromium/DNSChromium.cpp: (WebCore::prefetchDNS):
  • platform/qt/PlatformBridge.h:
  • platform/sql/chromium/SQLiteFileSystemChromium.cpp: (WebCore::SQLiteFileSystem::deleteDatabaseFile): (WebCore::SQLiteFileSystem::getDatabaseFileSize):
  • platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp: (chromiumOpen): (chromiumDelete): (chromiumAccess):
  • platform/sql/chromium/SQLiteFileSystemChromiumWin.cpp:
  • plugins/chromium/PluginDataChromium.cpp: (WebCore::PluginCache::plugins):
  • rendering/RenderThemeChromiumMac.mm: (WebCore::RenderThemeChromiumMac::usesTestModeFocusRingColor):
  • rendering/RenderThemeChromiumSkia.cpp: (WebCore::RenderThemeChromiumSkia::caretBlinkInterval):
  • rendering/RenderThemeChromiumWin.cpp: (WebCore::RenderThemeChromiumWin::platformActiveSelectionBackgroundColor): (WebCore::RenderThemeChromiumWin::platformInactiveSelectionBackgroundColor): (WebCore::RenderThemeChromiumWin::platformActiveSelectionForegroundColor): (WebCore::RenderThemeChromiumWin::systemColor): (WebCore::RenderThemeChromiumWin::paintButton): (WebCore::RenderThemeChromiumWin::paintSliderTrack): (WebCore::menuListButtonWidth): (WebCore::RenderThemeChromiumWin::paintMenuList): (WebCore::RenderThemeChromiumWin::paintTextFieldInternal): (WebCore::RenderThemeChromiumWin::paintInnerSpinButton): (WebCore::RenderThemeChromiumWin::paintProgressBar):
  • storage/chromium/IDBFactoryBackendInterface.cpp: (WebCore::IDBFactoryBackendInterface::create): (WebCore::IDBFactoryBackendInterface::~IDBFactoryBackendInterface):
  • storage/chromium/IDBKeyPathBackendImpl.cpp: (WebCore::IDBKeyPathBackendImpl::createIDBKeysFromSerializedValuesAndKeyPath):

2011-01-21 Adam Klein <adamk@chromium.org>

Reviewed by Eric Seidel.

[chromium] Rename ChromiumBridge to PlatformBridge
https://bugs.webkit.org/show_bug.cgi?id=52471

  • WebKit.gyp:
  • src/AssertMatchingEnums.cpp:
  • src/PlatformBridge.cpp: (WebCore::toChromeClientImpl): (WebCore::toWebWidgetClient): (WebCore::getCookieJar): (WebCore::PlatformBridge::cacheMetadata): (WebCore::PlatformBridge::clipboardIsFormatAvailable): (WebCore::PlatformBridge::clipboardReadPlainText): (WebCore::PlatformBridge::clipboardReadHTML): (WebCore::PlatformBridge::clipboardWriteSelection): (WebCore::PlatformBridge::clipboardWritePlainText): (WebCore::PlatformBridge::clipboardWriteURL): (WebCore::PlatformBridge::clipboardWriteImage): (WebCore::PlatformBridge::clipboardWriteData): (WebCore::PlatformBridge::clipboardReadAvailableTypes): (WebCore::PlatformBridge::clipboardReadData): (WebCore::PlatformBridge::clipboardReadFilenames): (WebCore::PlatformBridge::setCookies): (WebCore::PlatformBridge::cookies): (WebCore::PlatformBridge::cookieRequestHeaderFieldValue): (WebCore::PlatformBridge::rawCookies): (WebCore::PlatformBridge::deleteCookie): (WebCore::PlatformBridge::cookiesEnabled): (WebCore::PlatformBridge::prefetchDNS): (WebCore::PlatformBridge::fileExists): (WebCore::PlatformBridge::deleteFile): (WebCore::PlatformBridge::deleteEmptyDirectory): (WebCore::PlatformBridge::getFileSize): (WebCore::PlatformBridge::revealFolderInOS): (WebCore::PlatformBridge::getFileModificationTime): (WebCore::PlatformBridge::directoryName): (WebCore::PlatformBridge::pathByAppendingComponent): (WebCore::PlatformBridge::makeAllDirectories): (WebCore::PlatformBridge::getAbsolutePath): (WebCore::PlatformBridge::isDirectory): (WebCore::PlatformBridge::filePathToURL): (WebCore::PlatformBridge::openFile): (WebCore::PlatformBridge::closeFile): (WebCore::PlatformBridge::seekFile): (WebCore::PlatformBridge::truncateFile): (WebCore::PlatformBridge::readFromFile): (WebCore::PlatformBridge::writeToFile): (WebCore::PlatformBridge::ensureFontLoaded): (WebCore::PlatformBridge::getFontFamilyForCharacters): (WebCore::PlatformBridge::getRenderStyleForStrike): (WebCore::PlatformBridge::loadFont): (WebCore::PlatformBridge::databaseOpenFile): (WebCore::PlatformBridge::databaseDeleteFile): (WebCore::PlatformBridge::databaseGetFileAttributes): (WebCore::PlatformBridge::databaseGetFileSize): (WebCore::PlatformBridge::idbFactory): (WebCore::PlatformBridge::idbShutdown): (WebCore::PlatformBridge::createIDBKeysFromSerializedValuesAndKeyPath): (WebCore::PlatformBridge::signedPublicKeyAndChallengeString): (WebCore::PlatformBridge::computedDefaultLanguage): (WebCore::PlatformBridge::layoutTestMode): (WebCore::PlatformBridge::isSupportedImageMIMEType): (WebCore::PlatformBridge::isSupportedJavaScriptMIMEType): (WebCore::PlatformBridge::isSupportedNonImageMIMEType): (WebCore::PlatformBridge::mimeTypeForExtension): (WebCore::PlatformBridge::mimeTypeFromFile): (WebCore::PlatformBridge::preferredExtensionForMIMEType): (WebCore::PlatformBridge::plugins): (WebCore::PlatformBridge::pluginScriptableObject): (WebCore::PlatformBridge::loadPlatformImageResource): (WebCore::PlatformBridge::loadPlatformAudioResource): (WebCore::PlatformBridge::decodeAudioFileData): (WebCore::PlatformBridge::sandboxEnabled): (WebCore::PlatformBridge::setSharedTimerFiredFunction): (WebCore::PlatformBridge::setSharedTimerFireTime): (WebCore::PlatformBridge::stopSharedTimer): (WebCore::PlatformBridge::decrementStatsCounter): (WebCore::PlatformBridge::incrementStatsCounter): (WebCore::PlatformBridge::histogramCustomCounts): (WebCore::PlatformBridge::histogramEnumeration): (WebCore::PlatformBridge::suddenTerminationChanged): (WebCore::PlatformBridge::currentTime): (WebCore::PlatformBridge::paintButton): (WebCore::PlatformBridge::paintMenuList): (WebCore::PlatformBridge::paintScrollbarArrow): (WebCore::PlatformBridge::paintScrollbarThumb): (WebCore::PlatformBridge::paintScrollbarTrack): (WebCore::PlatformBridge::paintSpinButton): (WebCore::PlatformBridge::paintTextField): (WebCore::PlatformBridge::paintTrackbar): (WebCore::PlatformBridge::paintProgressBar): (WebCore::WebThemePart): (WebCore::WebThemeState): (WebCore::GetWebThemeExtraParams): (WebCore::PlatformBridge::getThemePartSize): (WebCore::PlatformBridge::paintThemePart): (WebCore::PlatformBridge::traceEventBegin): (WebCore::PlatformBridge::traceEventEnd): (WebCore::PlatformBridge::visitedLinkHash): (WebCore::PlatformBridge::isLinkVisited): (WebCore::PlatformBridge::notifyJSOutOfMemory): (WebCore::PlatformBridge::memoryUsageMB): (WebCore::PlatformBridge::actualMemoryUsageMB): (WebCore::PlatformBridge::screenDepth): (WebCore::PlatformBridge::screenDepthPerComponent): (WebCore::PlatformBridge::screenIsMonochrome): (WebCore::PlatformBridge::screenRect): (WebCore::PlatformBridge::screenAvailableRect): (WebCore::PlatformBridge::popupsAllowed): (WebCore::WorkerContextProxy::create):
  • src/ResourceHandle.cpp: (WebCore::ResourceHandle::cacheMetadata):
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::WebFrameImpl): (WebKit::WebFrameImpl::~WebFrameImpl):
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
3:23 AM Changeset in webkit [76339] by eric@webkit.org
  • 2 edits
    1 add in trunk/Tools

2011-01-21 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Split Host object off from WebKitPatch for easier re-use
https://bugs.webkit.org/show_bug.cgi?id=52284

new-run-webkit-tests and other tools are eventually going to want one of these.
Basically you need to inherit from this class if you want to pretend to be a
self.tool object for Steps/Commands.

  • Scripts/webkitpy/common/host.py: Added.
  • Scripts/webkitpy/tool/main.py:
3:14 AM Changeset in webkit [76338] by commit-queue@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

2011-01-21 Helder Correia <helder@sencha.com>

Reviewed by Andreas Kling.

[Qt] svg/css/text-gradient-shadow.svg needs expected results
https://bugs.webkit.org/show_bug.cgi?id=52724

  • platform/qt/svg/css/text-gradient-shadow-expected.checksum: Added.
  • platform/qt/svg/css/text-gradient-shadow-expected.png: Added.
  • platform/qt/svg/css/text-gradient-shadow-expected.txt: Added.
2:06 AM Changeset in webkit [76337] by loislo@chromium.org
  • 6 edits in trunk/Source/WebCore

2011-01-21 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r76335.
http://trac.webkit.org/changeset/76335
https://bugs.webkit.org/show_bug.cgi?id=52875

profiler tests were broken (Requested by loislo on #webkit).

  • inspector/InspectorController.cpp: (WebCore::InspectorController::addProfile): (WebCore::InspectorController::getCurrentUserInitiatedProfileName):
  • inspector/InspectorController.h:
  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::addStartProfilingMessageToConsoleImpl):
  • inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::addStartProfilingMessageToConsole): (WebCore::InspectorInstrumentation::inspectorControllerWithFrontendForPage):
  • page/Console.cpp: (WebCore::Console::profile): (WebCore::Console::profileEnd):
1:34 AM Changeset in webkit [76336] by yurys@chromium.org
  • 7 edits in trunk/LayoutTests

2011-01-21 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Make userscripts/window-onerror-for-isolated-world-*.html give consistent output
https://bugs.webkit.org/show_bug.cgi?id=52870

Call setTimeout from "load" event listener to make sure exception in the setTimeout
callback happens after the one in the listener.

  • platform/chromium/userscripts/window-onerror-for-isolated-world-1-expected.txt:
  • platform/chromium/userscripts/window-onerror-for-isolated-world-2-expected.txt:
  • userscripts/window-onerror-for-isolated-world-1-expected.txt:
  • userscripts/window-onerror-for-isolated-world-1.html:
  • userscripts/window-onerror-for-isolated-world-2-expected.txt:
  • userscripts/window-onerror-for-isolated-world-2.html:
1:24 AM Changeset in webkit [76335] by loislo@chromium.org
  • 6 edits in trunk/Source/WebCore

2011-01-21 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: switch page/Console implementation from InspectorController to InspectorInstrumentation.

There are some places in WebCore where we still using direct InspectorController calls.
The idea is to pass all the Inspector related calls via InspectorInstrumentaion which is the
Inspector facade for WebCore.

https://bugs.webkit.org/show_bug.cgi?id=52869

  • inspector/InspectorController.cpp:
  • inspector/InspectorController.h:
  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::addProfileImpl): (WebCore::InspectorInstrumentation::profilerEnabledImpl): (WebCore::InspectorInstrumentation::getCurrentUserInitiatedProfileNameImpl):
  • inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::addProfile): (WebCore::InspectorInstrumentation::profilerEnabled): (WebCore::InspectorInstrumentation::getCurrentUserInitiatedProfileName):
  • page/Console.cpp: (WebCore::Console::profile): (WebCore::Console::profileEnd):

Jan 20, 2011:

10:10 PM Changeset in webkit [76334] by rniwa@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-01-20 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Maciej Stachowiak.

Added OwnPtrCommon.h because OwnArrayPtr::set calls deleteOwnedPtr.

  • wtf/OwnArrayPtr.h:
9:25 PM Changeset in webkit [76333] by mjs@apple.com
  • 2 edits in trunk/LayoutTests

2011-01-20 Maciej Stachowiak <mjs@apple.com>

Reviewed by Dan Bernstein.

Skip a few more tests that are failing on the bots
https://bugs.webkit.org/show_bug.cgi?id=52865

  • platform/mac-wk2/Skipped:
8:58 PM Changeset in webkit [76332] by paroga@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

2011-01-20 Patrick Gansterer <paroga@webkit.org>

Reviewed by Oliver Hunt.

[WINCE] Remove obsolete JSVALUE32 code
https://bugs.webkit.org/show_bug.cgi?id=52450

Remove the "offset hack" in create_jit_stubs, since we
only support JSVALUE32_64 in the meantime.

  • create_jit_stubs: Removed offset argument
  • jit/JITStubs.cpp:
8:07 PM Changeset in webkit [76331] by ggaren@apple.com
  • 9 edits in trunk/Source/JavaScriptCore

2011-01-20 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

When marking conservatively, guard against reviving dead objects.
https://bugs.webkit.org/show_bug.cgi?id=52840


SunSpider and v8 say no change.

  • interpreter/RegisterFile.h: (JSC::RegisterFile::markCallFrames): Updated to use the ConservativeSet API.
  • runtime/Heap.cpp: (JSC::Heap::recordExtraCost): No need to guard against conservative marking reviving dead objects anymore, since the conservative marking mechanism guards against this now.

(JSC::Heap::markConservatively):
(JSC::Heap::markProtectedObjects):
(JSC::Heap::markTempSortVectors): Don't drain the mark stack inside a
marking function. We want to establish a separation of concerns between
visiting roots and draining the mark stack.

(JSC::Heap::markRoots): Gather the set of conservative references before
clearning mark bits, because conservative marking now uses the mark bits
to determine if a reference is valid, and avoid reviving dead objects.

(JSC::Heap::collectAllGarbage): No need to guard against conservative
marking reviving dead objects anymore, since the conservative marking
mechanism guards against this now.

  • runtime/Heap.h: Updated to use the ConservativeSet API.
  • runtime/MachineStackMarker.cpp: (JSC::MachineStackMarker::markCurrentThreadConservativelyInternal): (JSC::MachineStackMarker::markCurrentThreadConservatively): (JSC::MachineStackMarker::markOtherThreadConservatively): (JSC::MachineStackMarker::markMachineStackConservatively):
  • runtime/MachineStackMarker.h: Ditto.
  • runtime/MarkStack.h: (JSC::ConservativeSet::add): (JSC::ConservativeSet::mark): Added ConservativeSet, for gathering the set of conservative references. This is different from MarkStack, since we don't mark the set until it is completely gathered.
  • runtime/MarkedSpace.cpp: (JSC::MarkedSpace::freeBlock): (JSC::MarkedSpace::resizeBlocks): (JSC::MarkedSpace::markConservatively):
  • runtime/MarkedSpace.h: When marking conservatively, guard against reviving dead objects.
7:46 PM Changeset in webkit [76330] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

Fix failing tests from r76291.

Reviewed by Gavin Barraclough.

  • platform/ScrollView.cpp:

(WebCore::ScrollView::scrollPosition):
(WebCore::ScrollView::updateScrollbars):
Take the scroll origin into account in more places.

7:41 PM Changeset in webkit [76329] by tkent@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-01-20 Kent Tamura <tkent@chromium.org>

Unreviewed, sorting an Xcode project file.

  • WebCore.xcodeproj/project.pbxproj:
7:34 PM Changeset in webkit [76328] by ojan@chromium.org
  • 3 edits in trunk/Websites/bugs.webkit.org

2011-01-20 Ojan Vafai <ojan@chromium.org>

Fix the review tool for image diffs. We would get a javascript error
because image diffs don't have line numbers.

  • code-review.js:
7:29 PM Changeset in webkit [76327] by dimich@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Not reviewed, add a bug number to disabled test.

  • platform/chromium/test_expectations.txt:
7:09 PM Changeset in webkit [76326] by dpranke@chromium.org
  • 2 edits in trunk/Tools

2011-01-20 Dirk Pranke <dpranke@chromium.org>

Reviewed by Adam Barth.

Disable the tests that start and stop the http server and web
server, so that we don't have to worry about port collisions on
the bots.

https://bugs.webkit.org/show_bug.cgi?id=52861

  • Scripts/webkitpy/layout_tests/port/port_testcase.py:
6:40 PM Changeset in webkit [76325] by mjs@apple.com
  • 2 edits in trunk/LayoutTests

2011-01-20 Maciej Stachowiak <mjs@apple.com>

Reviewed by Darin Adler.

Skip some tests that are failing on the WebKit2 bot
https://bugs.webkit.org/show_bug.cgi?id=52858

  • platform/mac-wk2/Skipped: skip or re-skip some tests that fail on the bot for various reasons.
6:35 PM Changeset in webkit [76324] by commit-queue@webkit.org
  • 20 edits
    3 copies in trunk/Source/WebCore

2011-01-20 Ben Vanik <ben.vanik@gmail.com>

Reviewed by Kenneth Russell.

Implementation of the OES_standard_derivatives WebGL extension.
https://bugs.webkit.org/show_bug.cgi?id=51678

Changes are modeled off of the existing OESTextureFloat extension. New files,
extension retrieval, etc all match the existing code.

Changed ANGLEWebKitBridge to allow for multiple sets of the ANGLE shader compiler
options. This supports the enabling of the standard derivatives flag when the
extension is enabled. Refactored the cleanup code to make the destruction of the
compilers (if they had been created) cleaner.

Tested with the WebGL conformance test:
https://cvs.khronos.org/svn/repos/registry/trunk/public/webgl/sdk/tests/conformance/oes-standard-derivatives.html
Passes on WebKit/OSX, Chromium/OSX, and Chromium/Windows.

  • CMakeLists.txt:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSWebGLRenderingContextCustom.cpp: (WebCore::toJS):
  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp: (WebCore::toV8Object):
  • html/canvas/OESStandardDerivatives.cpp: Added. (WebCore::OESStandardDerivatives::OESStandardDerivatives): (WebCore::OESStandardDerivatives::~OESStandardDerivatives): (WebCore::OESStandardDerivatives::getName): (WebCore::OESStandardDerivatives::create):
  • html/canvas/OESStandardDerivatives.h: Added.
  • html/canvas/OESStandardDerivatives.idl: Added.
  • html/canvas/WebGLExtension.h:
  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::getExtension): Enable and return the new extension. (WebCore::WebGLRenderingContext::getParameter): Support extension enum when enabled. (WebCore::WebGLRenderingContext::getSupportedExtensions): (WebCore::WebGLRenderingContext::hint): Validate extension enum when enabled. (WebCore::WebGLRenderingContext::getNumberOfExtensions): (WebCore::WebGLRenderingContext::getExtensionNumber):
  • html/canvas/WebGLRenderingContext.h:
  • platform/graphics/ANGLEWebKitBridge.cpp: (WebCore::ANGLEWebKitBridge::~ANGLEWebKitBridge): Cleaned up compiler cleanup. (WebCore::ANGLEWebKitBridge::cleanupCompilers): Destruct compilers. (WebCore::ANGLEWebKitBridge::setResources): Cleanup existing compilers when changing ANGLE settings. (WebCore::ANGLEWebKitBridge::validateShaderSource): Cleaned up compiler cleanup on error.
  • platform/graphics/ANGLEWebKitBridge.h: (WebCore::ANGLEWebKitBridge::getResources):
  • platform/graphics/Extensions3D.h: Added enumeration for the extension.
  • platform/graphics/GraphicsContext3D.h: lumbing for GraphicsContext3D.
  • platform/graphics/opengl/Extensions3DOpenGL.cpp: (WebCore::Extensions3DOpenGL::Extensions3DOpenGL): Plumbed through a pointer to the GraphicsContext3D to handle resetting the shader compilers. (WebCore::Extensions3DOpenGL::supports): Desktop GL always supports this extension, so always return true. (WebCore::Extensions3DOpenGL::ensureEnabled): Reset shader compilers as required.
  • platform/graphics/opengl/Extensions3DOpenGL.h: Plumbing for GraphicsContext3D.
  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp: (WebCore::GraphicsContext3D::getExtensions): Plumbing for GraphicsContext3D to Extensions3DOpenGL.
6:30 PM Changeset in webkit [76323] by dpranke@chromium.org
  • 2 edits in trunk/Tools

2011-01-20 Dirk Pranke <dpranke@chromium.org>

Reviewed by Eric Seidel.

nrwt: rewrite google_chrome_unittest to use mock filesystem.

https://bugs.webkit.org/show_bug.cgi?id=52772

  • Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
6:30 PM Changeset in webkit [76322] by dpranke@chromium.org
  • 18 edits in trunk/Tools

2011-01-20 Dirk Pranke <dpranke@chromium.org>

Reviewed by Eric Siedel.

nrwt: clean up almost all remaining port references, remove
unnecessary import clauses. The only remaining references are
in places where a mock filesystem makes no sense or can't be
used, and in one routine in port/google_chrome_unittest that
I'll rewrite in a separate patch.

https://bugs.webkit.org/show_bug.cgi?id=52771

  • Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
  • Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
  • Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
  • Scripts/webkitpy/layout_tests/port/google_chrome.py:
  • Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
  • Scripts/webkitpy/layout_tests/port/gtk.py:
  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/port/port_testcase.py:
  • Scripts/webkitpy/layout_tests/port/qt.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/port/win.py:
  • Scripts/webkitpy/layout_tests/test_types/image_diff.py:
6:26 PM Changeset in webkit [76321] by dpranke@chromium.org
  • 3 edits in trunk/Tools

2011-01-20 Dirk Pranke <dpranke@chromium.org>

Reviewed by Mihai Parparita.

remove fs refs from run_webkit_tests, rebaseline_chromium_webkit_tests

https://bugs.webkit.org/show_bug.cgi?id=52762

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
6:18 PM Changeset in webkit [76320] by jer.noble@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed Qt Skipped list update.

Skip the test added in r76296 for platform/qt/.

  • platform/qt/Skipped:
6:09 PM Changeset in webkit [76319] by xji@chromium.org
  • 3 edits
    4 adds in trunk

2011-01-20 Xiaomei Ji <xji@chromium.org>

Reviewed by Dan Bernstein.

Fix regression(r71566): PDF in RTL block might messes up text directionality.
https://bugs.webkit.org/show_bug.cgi?id=52776

Test: fast/dom/52776.html

  • platform/text/BidiResolver.h: (WebCore::::checkDirectionInLowerRaiseEmbeddingLevel): (WebCore::::lowerExplicitEmbeddingLevel): (WebCore::::raiseExplicitEmbeddingLevel): (WebCore::::createBidiRunsForLine):

2011-01-20 Xiaomei Ji <xji@chromium.org>

Reviewed by Dan Bernstein.

Fix regression(r71566): PDF in RTL block might messes up text directionality.
https://bugs.webkit.org/show_bug.cgi?id=52776

  • fast/dom/52776.html: Added.
  • platform/mac/fast/dom/52776-expected.checksum: Added.
  • platform/mac/fast/dom/52776-expected.png: Added.
  • platform/mac/fast/dom/52776-expected.txt: Added.
5:59 PM Changeset in webkit [76318] by bdakin@apple.com
  • 2 edits in trunk/Source/WebCore

Follow-on for <rdar://problem/8890255>

Reviewed by Anders Carlsson.

This fixes a painting error with ScrollbarPainter scrollers
and the new drawing area code path.

  • platform/mac/ScrollbarThemeMac.mm:

(WebCore::updateArrowPlacement):

5:43 PM Changeset in webkit [76317] by dimich@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Updating test expectations after fixing the bug:
https://bugs.webkit.org/show_bug.cgi?id=52062

Patch by Jenn Braithwaite <jennb@chromium.org> on 2011-01-20
Reviewed by Dmitry Titov.

  • platform/chromium/test_expectations.txt:

iframe-reparenting-plugins.html is now passing on Windows.

5:40 PM Changeset in webkit [76316] by tony@chromium.org
  • 2 edits
    5 adds in trunk/LayoutTests

2011-01-20 Tony Chang <tony@chromium.org>

Unreviewed, rebaseline a test added in
http://trac.webkit.org/changeset/76274

  • platform/chromium-linux/svg/custom/pattern-referencing-preserve-aspect-ratio-expected.checksum: Added.
  • platform/chromium-linux/svg/custom/pattern-referencing-preserve-aspect-ratio-expected.png: Added.
  • platform/chromium-win/svg/custom/pattern-referencing-preserve-aspect-ratio-expected.checksum: Added.
  • platform/chromium-win/svg/custom/pattern-referencing-preserve-aspect-ratio-expected.png: Added.
  • platform/chromium-win/svg/custom/pattern-referencing-preserve-aspect-ratio-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
5:31 PM Changeset in webkit [76315] by leviw@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-01-20 Levi Weintraub <leviw@chromium.org>

Unreviewed.

Fixing build breakage.

  • editing/SelectionController.cpp: (WebCore::SelectionController::willBeModified):
5:28 PM Changeset in webkit [76314] by tony@chromium.org
  • 2 edits in trunk/Tools

2011-01-20 Tony Chang <tony@chromium.org>

Reviewed by Ojan Vafai.

[chromium] fix the paths used for the rebaseline tool
https://bugs.webkit.org/show_bug.cgi?id=52857

Some of the bots were renamed so the path to grab the results zip
file has changed.

  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
5:22 PM Changeset in webkit [76313] by commit-queue@webkit.org
  • 2 edits in trunk

2011-01-20 Siddharth Mathur <siddharth.mathur@nokia.com>

Reviewed by Laszlo Gombos.

[Qt][Symbian] Smaller debug symbol size when using RVCT 4.x
https://bugs.webkit.org/show_bug.cgi?id=52835

  • WebKit.pri: Use --remove_unneeded_entities for RVCT 4.x compilers
5:21 PM Changeset in webkit [76312] by leviw@chromium.org
  • 4 edits
    2 adds in trunk

2011-01-20 Levi Weintraub <leviw@chromium.org>

Reviewed by Ryosuke Niwa.

RTL: Caret goes to the opposite direction when pressing an arrow key after selection is made
https://bugs.webkit.org/show_bug.cgi?id=49511

Test: editing/selection/rtl-move-selection-right-left.html

  • editing/SelectionController.cpp: (WebCore::SelectionController::willBeModified): Respecting the direction of the containing block when switching selection base and extent in RTL content.

(WebCore::SelectionController::modifyMovingRight):
(WebCore::SelectionController::modifyMovingLeft):
Using directionOfEnclosingBlock when deciding to use the selection start or end to do the
correct thing for RTL.

2011-01-20 Levi Weintraub <leviw@chromium.org>

Reviewed by Ryosuke Niwa.

RTL: Caret goes to the opposite direction when pressing an arrow key after selection is made
https://bugs.webkit.org/show_bug.cgi?id=49511

  • editing/editing.js: (execMoveSelectionLeftByCharacterCommand): (moveSelectionLeftByCharacterCommand): (execMoveSelectionRightByCharacterCommand): (moveSelectionRightByCharacterCommand): (execExtendSelectionLeftByCharacterCommand): (extendSelectionLeftByCharacterCommand): (execExtendSelectionRightByCharacterCommand): (extendSelectionRightByCharacterCommand): Adding some left/right selection convenience methods for use with RTL tests.
  • editing/selection/rtl-move-selection-right-left-expected.txt: Added.
  • editing/selection/rtl-move-selection-right-left.html: Added.
5:06 PM Changeset in webkit [76311] by dpranke@chromium.org
  • 3 edits in trunk/Tools

2011-01-20 Dirk Pranke <dpranke@chromium.org>

Reviewed by Tony Chang.

Fix bug introduced in r72688 / bug 52768 that broke the
generation of the output filename links in the results.html
output. Apparently none of the unit tests actually checked to
make sure the generated links were correct :(

https://bugs.webkit.org/show_bug.cgi?id=52854

  • Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
4:58 PM Changeset in webkit [76310] by ojan@chromium.org
  • 3 edits in trunk/Websites/bugs.webkit.org

2011-01-20 Ojan Vafai <ojan@chromium.org>

Reviewed by Oliver Hunt.

Could review tool include style failure info?
https://bugs.webkit.org/show_bug.cgi?id=49049

This does not handle patches that have old paths (e.g. without the Source prefix).
Although that would be fairly straightforward to workaround.

  • code-review.js:
4:33 PM Changeset in webkit [76309] by mrowe@apple.com
  • 3 edits
    2 adds in tags/Safari-534.15.17

Merge r76296.

4:33 PM Changeset in webkit [76308] by mrowe@apple.com
  • 5 edits in tags/Safari-534.15.17

Versioning.

4:22 PM Changeset in webkit [76307] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

2011-01-20 Tony Chang <tony@chromium.org>

Unreviewed, mark some rtl scrolling tests as failing to green the chromium bots.

  • platform/chromium/test_expectations.txt:
4:19 PM Changeset in webkit [76306] by ap@apple.com
  • 12 edits in trunk

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=52849
Make window.print work with WebKit2

  • UIProcess/API/qt/qwkpage.cpp: (QWKPage::QWKPage):
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::printFrame):
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/WebUIClient.cpp: (WebKit::WebUIClient::printFrame):
  • UIProcess/WebUIClient.h:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::print): Just pass through deelagte call to a WebKit2 client.
  • UIProcess/API/C/WKPage.h: Also added "Callback" suffix to other printing related function types.
4:13 PM Changeset in webkit [76305] by andersca@apple.com
  • 5 edits in trunk/Source/WebKit2

2011-01-20 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler.

Keep track of the latest update timestamp in the backing store
https://bugs.webkit.org/show_bug.cgi?id=52848

  • Shared/UpdateInfo.h: (WebKit::UpdateInfo::UpdateInfo): Initialize timestamp to 0.
  • UIProcess/BackingStore.cpp: (WebKit::BackingStore::BackingStore): Initialize m_latestUpdateTimestamp to 0.

(WebKit::BackingStore::incorporateUpdate):
If the update is too old, discard it. Otherwise, create a bitmap
and pass it to platformIncorporateUpdate. Finally update the timestamp.

  • UIProcess/BackingStore.h: Add m_latestUpdateTimestamp.
  • UIProcess/mac/BackingStoreMac.mm: (WebKit::BackingStore::platformIncorporateUpdate): Update now that we are already given the shareable bitmap.
4:08 PM Changeset in webkit [76304] by tony@chromium.org
  • 3 edits in trunk/LayoutTests

2011-01-20 Tony Chang <tony@chromium.org>

Unreviewed, chromium test expectation updates.

  • platform/chromium-gpu/test_expectations.txt:
  • platform/chromium/test_expectations.txt:
4:05 PM Changeset in webkit [76303] by Nate Chapin
  • 3 edits
    3 adds in trunk

2011-01-20 Nate Chapin <Nate Chapin>

Reviewed by Adam Barth.

Test for https://bugs.webkit.org/show_bug.cgi?id=52769.

  • fast/dom/Window/Location/resources/set-location-after-close-new-window.html: Added.
  • fast/dom/Window/Location/set-location-after-close-expected.txt: Added.
  • fast/dom/Window/Location/set-location-after-close.html: Added.

2011-01-20 Nate Chapin <Nate Chapin>

Reviewed by Adam Barth.

Null-check m_frame in DOMWindow::setLocation(), since it's
possible to reach this point without it having been checked
already.
https://bugs.webkit.org/show_bug.cgi?id=52769

Test: fast/dom/Window/Location/set-location-after-close.html

  • page/DOMWindow.cpp: (WebCore::DOMWindow::setLocation):
4:04 PM Changeset in webkit [76302] by ojan@chromium.org
  • 3 edits in trunk/Websites/bugs.webkit.org

2011-01-20 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

handle cases where PrettyPatch.rb doesn't linkify filenames
https://bugs.webkit.org/show_bug.cgi?id=52834

  • code-review.js:
3:57 PM Changeset in webkit [76301] by chang.shu@nokia.com
  • 11 edits in trunk

2011-01-20 Chang Shu <chang.shu@nokia.com>

Reviewed by Darin Adler.

setContentEditable with invalid string should throw exception.
https://bugs.webkit.org/show_bug.cgi?id=52057

Updated expected results after the fix. Also corrected test cases.

  • editing/editability/set-invalid-value-expected.txt:
  • editing/editability/set-invalid-value.html: 1. Fixed the getAttribute expectation as "abc" was failed to set. 2. Added additional check for setting empty string.
  • editing/editability/set-value-caseinsensitive-expected.txt:
  • editing/editability/set-value-caseinsensitive.html: Fixed the getAttribute expectations as all strings should be converted to lower cases.
  • fast/dom/element-attribute-js-null-expected.txt:
  • fast/dom/element-attribute-js-null.html: Fixed this existing test as the expectation for setting with null should throw exception instead of "false". Also added handling code when exception was thrown.

2011-01-20 Chang Shu <chang.shu@nokia.com>

Reviewed by Darin Adler.

setContentEditable with invalid string should throw exception.
https://bugs.webkit.org/show_bug.cgi?id=52057

Implemented exception throwing for setContentEditable according to the following spec:
http://www.whatwg.org/specs/web-apps/current-work/multipage/editing.html#attr-contenteditable
Related quotas: "On setting, if the new value is an ASCII case-insensitive match for the
string 'inherit' then the content attribute must be removed, if the new value is an ASCII
case-insensitive match for the string 'true' then the content attribute must be set to the
string 'true', if the new value is an ASCII case-insensitive match for the string 'false'
then the content attribute must be set to the string 'false', and otherwise the attribute
setter must raise a SYNTAX_ERR exception."

  • html/HTMLElement.cpp: (WebCore::HTMLElement::setContentEditable): Throw exception on invalid input strings; Make setting values case-insensitive and also convert them to lower cases according to the spec.
  • html/HTMLElement.h: Add additional parameter ExceptionCode& for function setContentEditable.
  • html/HTMLElement.idl: Add exception throwing support for contentEditable setter.
3:55 PM Changeset in webkit [76300] by sullivan@apple.com
  • 3 edits in trunk/Source/WebKit/mac

Shift-tab doesn't cycle through fields in http authentication panel
https://bugs.webkit.org/show_bug.cgi?id=52850

Reviewed by Mark Rowe.

  • Panels/English.lproj/WebAuthenticationPanel.nib/designable.nib:
  • Panels/English.lproj/WebAuthenticationPanel.nib/keyedobjects.nib:

Re-wired the key loop so that there aren't two views with the same nextKeyView.

3:53 PM Changeset in webkit [76299] by enne@google.com
  • 3 edits
    7 adds in trunk

2011-01-20 Adrienne Walker <enne@google.com>

Reviewed by James Robinson.

[chromium] Add a test for a render surface that the uses alpha channel.
https://bugs.webkit.org/show_bug.cgi?id=52766

  • platform/chromium-gpu/platform/chromium/compositing/render-surface-alpha-blending-expected.checksum: Added.
  • platform/chromium-gpu/platform/chromium/compositing/render-surface-alpha-blending-expected.png: Added.
  • platform/chromium-gpu/platform/chromium/compositing/render-surface-alpha-blending-expected.txt: Added.
  • platform/chromium/compositing/render-surface-alpha-blending.html: Added.

2011-01-19 Adrienne Walker <enne@google.com>

Reviewed by James Robinson.

[chromium] Composited render surfaces should allow writes to alpha channel.
https://bugs.webkit.org/show_bug.cgi?id=52766

Test: LayoutTests/platform/chromium/compositing

  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::drawLayers):
3:49 PM Changeset in webkit [76298] by mrowe@apple.com
  • 1 copy in tags/Safari-534.15.17

New tag.

3:49 PM Changeset in webkit [76297] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-01-20 Siddharth Mathur <siddharth.mathur@nokia.com>

Reviewed by Geoffrey Garen.

[Symbian] Fix StackBounds::initialize()
https://bugs.webkit.org/show_bug.cgi?id=52842

  • wtf/StackBounds.cpp: (WTF::StackBounds::initialize): Use TThreadStackInfo.iLimit for stack limit
3:45 PM Changeset in webkit [76296] by jer.noble@apple.com
  • 3 edits
    2 adds in trunk

2011-01-14 Jer Noble <jer.noble@apple.com>

Reviewed by Eric Carlson.

REGRESSION (r71842): Compass video is not playing in Safari welcome page
https://bugs.webkit.org/show_bug.cgi?id=52506

Test that a delay between loading and playing video does not break playback.

  • media/video-currentTime-delay-expected.txt: Added.
  • media/video-currentTime-delay.html: Added.

2011-01-14 Jer Noble <jer.noble@apple.com>

Reviewed by Eric Carlson.

REGRESSION (r71842): Compass video is not playing in Safari welcome page
https://bugs.webkit.org/show_bug.cgi?id=52506

New test: LayoutTests/media/video-currentTime-delay.html

Call invalidateCachedTime() every time one of the cached property dependencies changes,
i.e. m_paused and m_playbackRate.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::prepareForLoad): (WebCore::HTMLMediaElement::setReadyState): (WebCore::HTMLMediaElement::setPlaybackRate): (WebCore::HTMLMediaElement::mediaPlayerRateChanged):
3:41 PM Changeset in webkit [76295] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit/qt

Fix build.

  • Api/qwebframe.cpp:

(QWebFrame::setScrollBarValue):

3:37 PM Changeset in webkit [76294] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

2011-01-20 Adam Klein <adamk@chromium.org>

Reviewed by Andreas Kling.

[chromium] Remove deprecated WebKit::nameOfInputElement function
https://bugs.webkit.org/show_bug.cgi?id=52824

  • src/DOMUtilitiesPrivate.cpp:
  • src/DOMUtilitiesPrivate.h:
3:19 PM Changeset in webkit [76293] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit/qt

Fix build.

  • Api/qwebframe.cpp:

(QWebFrame::setScrollBarValue):

3:18 PM Changeset in webkit [76292] by bdakin@apple.com
  • 9 edits in trunk/Source

Fix for <rdar://problem/8890255>

Reviewed by Geoffrey Garen.

Source/WebCore:

Allow WebKitSystemInterface to draw scrollbars
when appropriate.

  • WebCore.exp.in:
  • platform/mac/ScrollbarThemeMac.mm:

(WebCore::scrollbarMap):
(+[ScrollbarPrefsObserver appearancePrefsChanged:]):
(WebCore::ScrollbarThemeMac::registerScrollbar):
(WebCore::ScrollbarThemeMac::unregisterScrollbar):
(WebCore::ScrollbarThemeMac::paint):

  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:

Source/WebKit/mac:

Allow WebKitSystemInterface to draw scrollbars
when appropriate.

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

Source/WebKit2:

Allow WebKitSystemInterface to draw scrollbars
when appropriate.

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

3:14 PM Changeset in webkit [76291] by weinig@apple.com
  • 38 edits in trunk/Source

Cleanup Scrollbar/ScrollbarClient relationship
https://bugs.webkit.org/show_bug.cgi?id=52779

Reviewed by Dave Hyatt.

Source/WebCore:

Pipe all scrolling through the ScrollbarClient/ScrollAnimator
rather than through the Scrollbar. The Scrollbar now is just
a "view" on the scroll position of the scrollable area it is
attached to.

There are now two ways to scroll a scrollable area:

  • ScrollbarClient::scroll()
  • ScrollbarClient::scrollToOffsetWithoutAnimation()

Both of these go through the ScrollAnimator (updating its state
or starting an animation). The ScrollAnimator, in turn, now calls
ScrollbarClient::setScrollOffsetFromAnimation, which tells the
Scrollbars to pull a new offset (via Scrollbar::offsetDidChange)
and tells the class that derives from ScrollbarClient to scroll
its contents (via ScrollbarClient::setScrollOffset).

  • WebCore.xcodeproj/project.pbxproj:

Move Scrollbar.cpp to the right place.

  • accessibility/AccessibilityScrollbar.cpp:

(WebCore::AccessibilityScrollbar::setValue):
Initiate the scroll through the scrollbar client, rather than the
scrollbar itself.

  • page/FrameView.cpp:

(WebCore::FrameView::scrollTo):

  • page/FrameView.h:

Condense the two valueChanged overrides to a single override of the
scrollTo function.

  • platform/ScrollAnimator.cpp:

(WebCore::ScrollAnimator::scroll):
(WebCore::ScrollAnimator::scrollToOffsetWithoutAnimation):
(WebCore::ScrollAnimator::currentPosition):
(WebCore::ScrollAnimator::notityPositionChanged):

  • platform/ScrollAnimator.h:
  • platform/ScrollAnimatorWin.cpp:

(WebCore::ScrollAnimatorWin::scrollToOffsetWithoutAnimation):
(WebCore::ScrollAnimatorWin::animateScroll):

  • platform/ScrollAnimatorWin.h:
  • platform/mac/ScrollAnimatorMac.h:
  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::scrollToOffsetWithoutAnimation):
(WebCore::ScrollAnimatorMac::immediateScrollToPoint):
Change setScrollPositionAndStopAnimation to scrollToOffsetWithoutAnimation
and bottleneck all client notification of changed position through a new
notityPositionChanged() function.

  • platform/ScrollView.cpp:

(WebCore::ScrollView::setScrollOffset):
(WebCore::ScrollView::scrollTo):
(WebCore::ScrollView::scrollPosition):
(WebCore::ScrollView::scroll):
(WebCore::ScrollView::updateScrollbars):
(WebCore::ScrollView::wheelEvent):

  • platform/ScrollView.h:

(WebCore::ScrollView::horizontalScrollbar):
(WebCore::ScrollView::verticalScrollbar):
Update to scroll via the ScrollbarClient rather than the Scrollbar.

  • platform/Scrollbar.cpp:

(WebCore::Scrollbar::offsetDidChange):
(WebCore::Scrollbar::autoscrollPressedPart):
(WebCore::Scrollbar::moveThumb):
(WebCore::Scrollbar::mouseMoved):

  • platform/Scrollbar.h:

(WebCore::Scrollbar::setPressedPos):
Change the scrollbar to only updates its offset in response to
an offsetDidChange call.

  • platform/ScrollbarClient.cpp:

(WebCore::ScrollbarClient::scroll):
(WebCore::ScrollbarClient::scrollToOffsetWithoutAnimation):
(WebCore::ScrollbarClient::scrollToXOffsetWithoutAnimation):
(WebCore::ScrollbarClient::scrollToYOffsetWithoutAnimation):
(WebCore::ScrollbarClient::setScrollOffsetFromAnimation):

  • platform/ScrollbarClient.h:

(WebCore::ScrollbarClient::horizontalScrollbar):
(WebCore::ScrollbarClient::verticalScrollbar):
Make the increasingly misnamed ScrollbarClient responsible for
scrolling.

  • platform/efl/ScrollbarEfl.cpp:

(scrollbarEflEdjeMessage):

  • platform/gtk/MainFrameScrollbarGtk.cpp:

(MainFrameScrollbarGtk::gtkValueChanged):

  • platform/qt/ScrollbarQt.cpp:

(WebCore::Scrollbar::contextMenu):
Update to move scrolling through the client.

  • platform/win/PopupMenuWin.cpp:

(WebCore::PopupMenuWin::scrollToRevealSelection):
(WebCore::PopupMenuWin::scrollPosition):
(WebCore::PopupMenuWin::setScrollOffset):
(WebCore::PopupMenuWin::scrollTo):
(WebCore::PopupMenuWin::wndProc):

  • platform/win/PopupMenuWin.h:

(WebCore::PopupMenuWin::verticalScrollbar):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::scrollToOffset):
(WebCore::RenderLayer::scrollTo):
(WebCore::RenderLayer::setScrollOffset):
(WebCore::RenderLayer::scrollPosition):
(WebCore::RenderLayer::updateScrollInfoAfterLayout):
(WebCore::RenderLayer::scroll):

  • rendering/RenderLayer.h:
  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::scrollToRevealElementAtListIndex):
(WebCore::RenderListBox::scroll):
(WebCore::RenderListBox::logicalScroll):
(WebCore::RenderListBox::scrollPosition):
(WebCore::RenderListBox::setScrollOffset):
(WebCore::RenderListBox::scrollTo):
(WebCore::RenderListBox::setScrollTop):

  • rendering/RenderListBox.h:

(WebCore::RenderListBox::verticalScrollbar):
Update to scroll via the ScrollbarClient rather than the Scrollbar.

  • rendering/RenderMarquee.cpp:

(WebCore::RenderMarquee::start):
Simplify initial paint to just do an immediate scroll to the position.

Source/WebKit/chromium:

  • src/WebScrollbarImpl.cpp:

(WebKit::WebScrollbarImpl::WebScrollbarImpl):
(WebKit::WebScrollbarImpl::value):
(WebKit::WebScrollbarImpl::setValue):
(WebKit::WebScrollbarImpl::scroll):
(WebKit::WebScrollbarImpl::onMouseDown):
(WebKit::WebScrollbarImpl::onMouseMove):
(WebKit::WebScrollbarImpl::onMouseWheel):
(WebKit::WebScrollbarImpl::onKeyDown):
(WebKit::WebScrollbarImpl::scrollPosition):
(WebKit::WebScrollbarImpl::setScrollOffset):

  • src/WebScrollbarImpl.h:

Source/WebKit/qt:

  • Api/qwebframe.cpp:

(QWebFrame::setScrollBarValue):

Source/WebKit/win:

  • WebScrollBar.cpp:

(WebScrollBar::WebScrollBar):
(WebScrollBar::setValue):
(WebScrollBar::value):
(WebScrollBar::scroll):
(WebScrollBar::scrollPosition):
(WebScrollBar::setScrollOffset):

  • WebScrollBar.h:

Source/WebKit2:

  • UIProcess/win/WebPopupMenuProxyWin.cpp:

(WebKit::WebPopupMenuProxyWin::scrollPosition):
(WebKit::WebPopupMenuProxyWin::setScrollOffset):
(WebKit::WebPopupMenuProxyWin::scrollTo):
(WebKit::WebPopupMenuProxyWin::onMouseWheel):
(WebKit::WebPopupMenuProxyWin::scrollToRevealSelection):

  • UIProcess/win/WebPopupMenuProxyWin.h:

(WebKit::WebPopupMenuProxyWin::verticalScrollbar):

3:14 PM Changeset in webkit [76290] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-01-20 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed Chromium test expectations fix.

  • platform/chromium/test_expectations.txt:
3:10 PM Changeset in webkit [76289] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

2011-01-20 Tony Chang <tony@chromium.org>

Unreviewed, another attempt at making the chromium gpu tests go green.

  • platform/chromium-gpu/test_expectations.txt:
3:05 PM Changeset in webkit [76288] by dpranke@chromium.org
  • 7 edits in trunk/Tools

2011-01-20 Dirk Pranke <dpranke@chromium.org>

Reviewed by Eric Seidel.

nrwt: remove fs refs from printing, test_failures, test_expectations, text_diff

https://bugs.webkit.org/show_bug.cgi?id=52756

  • Scripts/webkitpy/layout_tests/layout_package/printing.py:
  • Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
  • Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2:53 PM Changeset in webkit [76287] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

2011-01-20 James Robinson <jamesr@chromium.org>

Update expectations for tests that need chromium-side changes.

  • platform/chromium/test_expectations.txt:
2:50 PM Changeset in webkit [76286] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

2011-01-20 Mansi Mithal <mansi.mithal@nokia.com>

Reviewed by Antonio Gomes.

QtTestBrowser should have a seperate menu for Settings
https://bugs.webkit.org/show_bug.cgi?id=52817

Added a new menu item named "Settings"
and moved the "Enable interrupting js scripts" and "Enable js pop up windows" under the "Settings" menu

  • QtTestBrowser/launcherwindow.cpp: (LauncherWindow::createChrome):
2:48 PM Changeset in webkit [76285] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

2011-01-20 Anders Carlsson <andersca@apple.com>

Reviewed by Adam Roben.

Add a timestamp to UpdateInfo
https://bugs.webkit.org/show_bug.cgi?id=52844

  • Shared/UpdateInfo.cpp: (WebKit::UpdateInfo::encode): (WebKit::UpdateInfo::decode):
  • Shared/UpdateInfo.h:
  • WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::setSize): (WebKit::DrawingAreaImpl::display):
2:44 PM Changeset in webkit [76284] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-01-20 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed Chromium test expectation update.

Merged test_expectations.txt in the Chromium tree and
added slow to fast/text/large-text-composed-char-dos.html.

  • platform/chromium/test_expectations.txt:
2:30 PM Changeset in webkit [76283] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

2011-01-20 Tony Chang <tony@chromium.org>

Unreviewed, updating gpu expectations.
These two tests were added to the regular chromiumg test_expectations.txt
in r76228.

  • platform/chromium-gpu/test_expectations.txt:
2:12 PM Changeset in webkit [76282] by paroga@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-01-20 Patrick Gansterer <paroga@webkit.org>

Unreviewed WinCE build fix for r76170.

  • platform/graphics/wince/FontWinCE.cpp: Added a missing include.
  • platform/graphics/wince/ImageBufferData.h: Added a missing include and fixed style.
2:07 PM Changeset in webkit [76281] by weinig@apple.com
  • 2 edits in trunk/Tools

Update update-webkit-localizable-strings with new path to WebKit.

Reviewed by John Sullivan.

  • Scripts/update-webkit-localizable-strings:
2:04 PM Changeset in webkit [76280] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-01-20 Anders Carlsson <andersca@apple.com>

Reviewed by Beth Dakin.

Add Connection::waitForAndDispatchImmediately
https://bugs.webkit.org/show_bug.cgi?id=52841

  • Platform/CoreIPC/Connection.h: (CoreIPC::Connection::waitForAndDispatchImmediately):
2:01 PM Changeset in webkit [76279] by rniwa@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

2011-01-20 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed; Another Chromium rebaseline for r76236.

  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.checksum: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.checksum: Added.
1:50 PM Changeset in webkit [76278] by jamesr@google.com
  • 32 edits
    12 adds in trunk

2011-01-20 James Robinson <jamesr@chromium.org>

Reviewed by Darin Fisher.

Implement mozilla's requestAnimationFrame API
https://bugs.webkit.org/show_bug.cgi?id=51218

Tests for window.webkitRequestAnimationFrame(). The new tests
are in the Skipped lists for platforms that do not set
ENABLE(REQUEST_ANIMATION_FRAME) - which is currently all but chromium.

  • fast/animation/request-animation-frame-cancel-expected.txt: Added.
  • fast/animation/request-animation-frame-cancel.html: Added.

Tests cancelling a callback within a webkitRequestAnimationFrame() callback.

  • fast/animation/request-animation-frame-cancel2-expected.txt: Added.
  • fast/animation/request-animation-frame-cancel2.html: Added.

Tests interactions between multiple webkitRequestAnimationFrame() callbacks.

  • fast/animation/request-animation-frame-display-expected.txt: Added.
  • fast/animation/request-animation-frame-display.html: Added.

Tests changing the display: property of an element within a callback.

  • fast/animation/request-animation-frame-expected.txt: Added.
  • fast/animation/request-animation-frame.html: Added.

Tests the basic use of window.webkitRequestAnimationFrame().

  • fast/animation/request-animation-frame-within-callback-expected.txt: Added.
  • fast/animation/request-animation-frame-within-callback.html: Added.

Tests setting one webkit.webkitRequestAnimationFrame() callback within another.

  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:

2011-01-20 James Robinson <jamesr@chromium.org>

Reviewed by Darin Fisher.

Implement mozilla's requestAnimationFrame API
https://bugs.webkit.org/show_bug.cgi?id=51218

This implements mozilla's proposed requestAnimationFrame API. The idea with this API is that
an author driving an animation from script could use window.requestAnimationFrame(callback)
instead of window.setTimeout(callback, 0) to schedule their update logic and let the browser
decide when to update the animations. This avoids doing unnecessary work when the page content
is offscreen or is being displayed at a different framerate than what the page author expects.

Mozilla's proposal is here: https://developer.mozilla.org/en/DOM/window.mozRequestAnimationFrame
This implements window.mozRequestAnimationFrame as window.webkitRequestAnimationFrame with the
following changes:
*) Only the callback syntax is supported, there is no before paint event
*) webkitRequestAnimationFrame supports a second parameter Element to let the author indicate

what content they intend to animate. That way if the page is being displayed but the element
in question is offscreen, we can avoid invoking the callback.

*) No timestamp is provided to the caller and there is no window.animationStartTime property

(see https://bugs.webkit.org/show_bug.cgi?id=51952 for discussion of this property)

*) window.webkitRequestAnimationFrame returns a numerical id that can be used to cancel the callback

using window.cancelWebkitRequestAnimationFrame, to parallel window.setTimeout()/window.clearTime().

The implementation depends on the embedder scheduling the callbacks since the callback invocation
depends on the page's visibility and the embedder's paint scheduling, neither of which are exposed
to WebCore. The expectation for the embedder is that at some point Chrome::scheduleAnimation() is
called FrameView::serviceScriptedAnimations() should be called for the associated Page's main frame.
Ideally serviceScriptedAnimations() would be called prior to rendering - although in practice the
embedder has to rate limit callbacks and may not be able to tie the callback directly to the
rendering loop.

Tests: fast/animation/request-animation-frame-cancel.html

fast/animation/request-animation-frame-cancel2.html
fast/animation/request-animation-frame-display.html
fast/animation/request-animation-frame-within-callback.html
fast/animation/request-animation-frame.html

  • WebCore.gypi:
  • dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::webkitRequestAnimationFrame): (WebCore::Document::webkitCancelRequestAnimationFrame): (WebCore::Document::serviceScriptedAnimations):
  • dom/Document.h:
  • dom/RequestAnimationFrameCallback.h: Added. (WebCore::RequestAnimationFrameCallback::~RequestAnimationFrameCallback):
  • dom/RequestAnimationFrameCallback.idl: Added.
  • loader/EmptyClients.h: (WebCore::EmptyChromeClient::scheduleAnimation):
  • page/Chrome.cpp: (WebCore::Chrome::scheduleAnimation):
  • page/Chrome.h:
  • page/ChromeClient.h:
  • page/DOMWindow.cpp: (WebCore::DOMWindow::webkitRequestAnimationFrame): (WebCore::DOMWindow::webkitCancelRequestAnimationFrame):
  • page/DOMWindow.h:
  • page/DOMWindow.idl:
  • page/FrameView.cpp: (WebCore::FrameView::scheduleAnimation): (WebCore::FrameView::serviceScriptedAnimations):
  • page/FrameView.h:
  • platform/HostWindow.h:

2011-01-20 James Robinson <jamesr@chromium.org>

Reviewed by Darin Fisher.

Implement mozilla's requestAnimationFrame API
https://bugs.webkit.org/show_bug.cgi?id=51218

Chromium WebKit API support for window.webkitRequestAnimationFrame()

  • features.gypi:
  • public/WebWidget.h:
  • public/WebWidgetClient.h: (WebKit::WebWidgetClient::scheduleAnimation):
  • src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::scheduleAnimation):
  • src/ChromeClientImpl.h:
  • src/WebPopupMenuImpl.cpp: (WebKit::WebPopupMenuImpl::animate): (WebKit::WebPopupMenuImpl::scheduleAnimation):
  • src/WebPopupMenuImpl.h:
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::animate):
  • src/WebViewImpl.h:

2011-01-20 James Robinson <jamesr@chromium.org>

Reviewed by Darin Fisher.

Implement mozilla's requestAnimationFrame API
https://bugs.webkit.org/show_bug.cgi?id=51218

Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.

  • DumpRenderTree/chromium/WebViewHost.cpp: (invokeScheduleComposite): (WebViewHost::scheduleAnimation): (WebViewHost::paintInvalidatedRegion):
  • DumpRenderTree/chromium/WebViewHost.h:
1:39 PM Changeset in webkit [76277] by jamesr@google.com
  • 20 edits in trunk/Source/WebCore

2011-01-20 James Robinson <jamesr@chromium.org>

Reviewed by Nate Chapin.

[v8] CodeGeneratorV8 generates incorrect code for callbacks with no parameters
https://bugs.webkit.org/show_bug.cgi?id=52837

When generating code to invoke a callback with no parameters CodeGeneratorV8.pm was generating the following:
v8::Handle<v8::Value> argv[] = {}; which does not compile in visual studio. Instead, if the argument count
is 0, we can just pass a NULL pointer for the argv parameter.

Test added to bindings/scripts/test/TestCallback.idl and covered by run-bindings-tests. This
patch also includes some spurious changes to the bindings tests golden files (mostly GObject)
because the old golden files were out of date.

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/scripts/test/CPP/WebDOMTestCallback.cpp: (WebDOMTestCallback::callbackWithNoParam):
  • bindings/scripts/test/CPP/WebDOMTestCallback.h:
  • bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp: (webkit_dom_test_callback_callback_with_no_param):
  • bindings/scripts/test/GObject/WebKitDOMTestCallback.h:
  • bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListener.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
  • bindings/scripts/test/JS/JSTestCallback.cpp: (WebCore::JSTestCallback::callbackWithNoParam):
  • bindings/scripts/test/JS/JSTestCallback.h:
  • bindings/scripts/test/JS/JSTestInterface.cpp:
  • bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
  • bindings/scripts/test/JS/JSTestObj.cpp:
  • bindings/scripts/test/ObjC/DOMTestCallback.h:
  • bindings/scripts/test/ObjC/DOMTestCallback.mm: (-[DOMTestCallback callbackWithNoParam]):
  • bindings/scripts/test/TestCallback.idl:
  • bindings/scripts/test/V8/V8TestCallback.cpp: (WebCore::V8TestCallback::callbackWithNoParam):
  • bindings/scripts/test/V8/V8TestCallback.h:
  • bindings/scripts/test/V8/V8TestObj.cpp: (WebCore::TestObjInternal::reflectedUnsignedIntegralAttrAttrGetter):
1:34 PM Changeset in webkit [76276] by jamesr@google.com
  • 4 edits
    2 adds in trunk

2011-01-20 James Robinson <jamesr@chromium.org>

Reviewed by Eric Seidel.

RenderTableSection's setNeedsCellRecalc needs to null check table()
https://bugs.webkit.org/show_bug.cgi?id=52770

Tests ::-webkit-scrollbar-corner inside a table.

  • fast/css-generated-content/table-with-scrollbar-corner-expected.txt: Added.
  • fast/css-generated-content/table-with-scrollbar-corner.html: Added.

2011-01-20 James Robinson <jamesr@chromium.org>

Reviewed by Eric "Baller" Seidel.

RenderTableSection's setNeedsCellRecalc needs to null check table()
https://bugs.webkit.org/show_bug.cgi?id=52770

Null checks table() before deferencing it in RenderTableSection::setNeedsCellRecalc.
This can be null during detach(). Test constructed by Eric Seidel.

Test: fast/css-generated-content/table-with-scrollbar-corner.html

  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::setNeedsCellRecalc):
  • rendering/RenderTableSection.h:
1:31 PM Changeset in webkit [76275] by msaboff@apple.com
  • 5 edits in trunk

2011-01-20 Michael Saboff <msaboff@apple.com>

Reviewed by Oliver Hunt.

<rdar://problem/8890203> [RegexFuzz] Crash in generated code (52773)
https://bugs.webkit.org/show_bug.cgi?id=52773

Fixed case where an existing DataLabelPtr is overwritten. The
replacing DataLabelPtr is now resolved immediately in
linkDataLabelToBacktrackIfExists(). Cleanup - eliminated bool
return value for the routine as it was never used.

  • yarr/YarrJIT.cpp: (JSC::Yarr::YarrGenerator::TermGenerationState::linkDataLabelToBacktrackIfExists):

2011-01-20 Michael Saboff <msaboff@apple.com>

Reviewed by Oliver Hunt.

<rdar://problem/8890203> [RegexFuzz] Crash in generated code (52773)
https://bugs.webkit.org/show_bug.cgi?id=52773

New test to validate fix.

  • fast/regex/parentheses-expected.txt:
  • fast/regex/script-tests/parentheses.js:
1:26 PM Changeset in webkit [76274] by krit@webkit.org
  • 5 edits
    4 adds in trunk

2011-01-20 Dirk Schulze <krit@webkit.org>

Reviewed by Rob Buis.

SVG Pattern doesn't take preserveAspectRatio of references Pattern
https://bugs.webkit.org/show_bug.cgi?id=52802

SVGPattern didn't take preserveAspectRatio of a referenced SVGPattern into account. Store preserveAspectRatio
in PatternAttributes as well, if the attribute was set on the referenced SVGPattern element.

Test: svg/custom/pattern-referencing-preserve-aspect-ratio.svg

  • rendering/svg/RenderSVGResourcePattern.cpp: (WebCore::RenderSVGResourcePattern::buildTileImageTransform):
  • svg/PatternAttributes.h: (WebCore::PatternAttributes::PatternAttributes): (WebCore::PatternAttributes::preserveAspectRatio): (WebCore::PatternAttributes::setPreserveAspectRatio): (WebCore::PatternAttributes::hasPreserveAspectRatio):
  • svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::collectPatternAttributes):

2011-01-20 Dirk Schulze <krit@webkit.org>

Reviewed by Rob Buis.

SVG Pattern doesn't take preserveAspectRatio of references Pattern
https://bugs.webkit.org/show_bug.cgi?id=52802

Added a test case to check that we take preserveAspectRatio of a referenced SVGPattern into account.

  • platform/mac/svg/custom/pattern-referencing-preserve-aspect-ratio-expected.checksum: Added.
  • platform/mac/svg/custom/pattern-referencing-preserve-aspect-ratio-expected.png: Added.
  • platform/mac/svg/custom/pattern-referencing-preserve-aspect-ratio-expected.txt: Added.
  • svg/custom/pattern-referencing-preserve-aspect-ratio.svg: Added.
12:47 PM Changeset in webkit [76273] by mitz@apple.com
  • 4 edits
    5 adds in trunk

<rdar://problem/8765498> REGRESSION (r72141): Cannot order prints with Aperture 3.1

Reviewed by Adele Peterson.

<rdar://problem/8884648> REGRESSION (r72141): Safari hangs when visiting a page on www.bfmtv.com
https://bugs.webkit.org/show_bug.cgi?id=52765

<rdar://problem/8890909> REGRESSION (r72141): Very Slow Rendering With Certain Markup
https://bugs.webkit.org/show_bug.cgi?id=52265

Source/WebCore:

Test: fast/block/line-layout/negative-max-height.html

Integer overflow detection led to a block having a huge height. This manifested as broken layout
in the first bug and as extreme slowness in the latter bugs because of
https://bugs.webkit.org/show_bug.cgi?id=52832

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::alignBoxesInBlockDirection): Clamp maxHeight to 0 so the next line
cannot start above this line. The negative maxHeight also caused the integer overflow detection
logic to give the block a huge height.

LayoutTests:

  • fast/block/line-layout: Added.
  • fast/block/line-layout/negative-max-height-expected.checksum: Added.
  • fast/block/line-layout/negative-max-height-expected.png: Added.
  • fast/block/line-layout/negative-max-height-expected.txt: Added.
  • fast/block/line-layout/negative-max-height.html: Added.
12:41 PM Changeset in webkit [76272] by yi.4.shen@nokia.com
  • 3 edits in trunk/Source/WebCore

2011-01-20 Yi Shen <yi.4.shen@nokia.com>

Reviewed by Eric Carlson.

Clean up the Media Controls CSS for Qt
https://bugs.webkit.org/show_bug.cgi?id=52822

Split the audio::-webkit-media-xxx and video::-webkit-media-xxx rules
in mediaControlsQt.css, and remove the duplicate audio::-webkit-media-xxx
rules from mediaControlsQtFullscreen.css.

  • css/mediaControlsQt.css: (audio::-webkit-media-controls-panel): (video::-webkit-media-controls-panel): (audio::-webkit-media-controls-mute-button): (video::-webkit-media-controls-mute-button): (audio::-webkit-media-controls-play-button): (video::-webkit-media-controls-play-button): (audio::-webkit-media-controls-timeline-container): (video::-webkit-media-controls-timeline-container): (audio::-webkit-media-controls-current-time-display): (video::-webkit-media-controls-current-time-display): (audio::-webkit-media-controls-time-remaining-display): (video::-webkit-media-controls-time-remaining-display): (audio::-webkit-media-controls-timeline): (video::-webkit-media-controls-timeline): (audio::-webkit-media-controls-volume-slider-container): (video::-webkit-media-controls-volume-slider-container): (audio::-webkit-media-controls-volume-slider): (video::-webkit-media-controls-volume-slider): (audio::-webkit-media-controls-seek-back-button): (video::-webkit-media-controls-seek-back-button): (audio::-webkit-media-controls-seek-forward-button): (video::-webkit-media-controls-seek-forward-button): (audio::-webkit-media-controls-fullscreen-button): (video::-webkit-media-controls-fullscreen-button): (audio::-webkit-media-controls-rewind-button): (video::-webkit-media-controls-rewind-button): (audio::-webkit-media-controls-return-to-realtime-button): (video::-webkit-media-controls-return-to-realtime-button): (audio::-webkit-media-controls-toggle-closed-captions-button): (video::-webkit-media-controls-toggle-closed-captions-button):
  • css/mediaControlsQtFullscreen.css: (video::-webkit-media-controls-time-remaining-display): (video::-webkit-media-controls-seek-back-button): (video::-webkit-media-controls-seek-forward-button): (video::-webkit-media-controls-rewind-button): (video::-webkit-media-controls-return-to-realtime-button): (video::-webkit-media-controls-toggle-closed-captions-button):
12:32 PM Changeset in webkit [76271] by ojan@chromium.org
  • 3 edits in trunk/Websites/bugs.webkit.org

2011-01-20 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

fix goofup in http://trac.webkit.org/changeset/76082
https://bugs.webkit.org/show_bug.cgi?id=52830

We were showing the revision number of the patch at the bottom
of the diff and expanding from the bottom of the diff would fail.

Also, removed an unused variable and scoped queries appropriatly
to the file_diff they should have been operating on.

  • PrettyPatch/PrettyPatch.rb:
  • code-review.js:
12:30 PM Changeset in webkit [76270] by ojan@chromium.org
  • 3 edits in trunk/Websites/bugs.webkit.org

2011-01-19 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

[reviewtool] Add a link for annotated trac page on review page
https://bugs.webkit.org/show_bug.cgi?id=52747

-add line numbers to all trac links to the first line in the file diff
-add annotate/review log links
-make file-diff links other than the file name only show when you mouseover the filediff
-fix white-space to only wrap the .text element and it's childen, any of it's siblings/parents

  • PrettyPatch/PrettyPatch.rb:
  • code-review.js:
12:30 PM Changeset in webkit [76269] by rniwa@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-01-20 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed Chromium rebaseline for r76236.

  • platform/chromium-win/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.txt: Added.
11:21 AM Changeset in webkit [76268] by ojan@chromium.org
  • 2 edits in trunk/Websites/bugs.webkit.org

2011-01-14 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

make line selection have a extend only from where you start the selection in the code review tool
https://bugs.webkit.org/show_bug.cgi?id=52485

  • code-review.js:
11:07 AM Changeset in webkit [76267] by kdecker@apple.com
  • 5 edits in trunk/Source/WebKit2

Reviewed by Anders Carlsson.

<rdar://problem/8880689> need a way to obtain the rendered rectangle for box elements
https://bugs.webkit.org/show_bug.cgi?id=52823


  • WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.cpp: (WKBundleNodeHandleGetRenderRect): Added new method that will return a rendered rectangle for box elements
  • WebProcess/InjectedBundle/API/c/WKBundleNodeHandlePrivate.h: Ditto.
  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp: Ditto. (WebKit::InjectedBundleNodeHandle::renderRect): Ditto.
  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h: Ditto.
10:31 AM Changeset in webkit [76266] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-01-20 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [REGRESSION] Canceling of CSS numeric values increment/decrement is broken
https://bugs.webkit.org/show_bug.cgi?id=52816

  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertyTreeElement.prototype):
10:24 AM Changeset in webkit [76265] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-01-20 Dawit Alemayehu <adawit@kde.org>

Reviewed by Andreas Kling.

[Qt] Fix Layering violation in MediaPlayerPrivateQt.
https://bugs.webkit.org/show_bug.cgi?id=52733

No new tests. no behavioral change.

  • platform/graphics/qt/MediaPlayerPrivateQt.cpp: (WebCore::MediaPlayerPrivateQt::commitLoad):
10:20 AM Changeset in webkit [76264] by Nate Chapin
  • 2 edits in trunk/Source/WebCore

2011-01-20 Nate Chapin <Nate Chapin>

Reviewed by Darin Fisher.

[V8] Call malloc and memcpy directly instead of
of strdup in convertV8ObjectToNPVariant() when
converting strings. If there is a null character
in the string, our use of strdup causes us to allocate
too little memory, leading to out of bounds reads.

https://bugs.webkit.org/show_bug.cgi?id=52631

  • bindings/v8/V8NPUtils.cpp: (WebCore::convertV8ObjectToNPVariant):
10:13 AM Changeset in webkit [76263] by abecsi@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-01-20 Andras Becsi <abecsi@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt][WK2] WebKit2 enabled build fails to link

Work around undefined reference linking issues until the buildsystem gets redesigned.
These issues first occured in minimal builds (see BUG 50519).

10:08 AM Changeset in webkit [76262] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit2

2011-01-20 Kimmo Kinnunen <kimmo.t.kinnunen@nokia.com>

Reviewed by Andreas Kling.

Remove null ptr deref that happens when reattaching to
a new web process.

Implement didRelaunchProcess that sets the drawing area size
after the drawing area is re-instantiated.

[Qt][WK2] Null ptr deref in UI process after web process has crashed
https://bugs.webkit.org/show_bug.cgi?id=52796

  • UIProcess/API/qt/qgraphicswkview.cpp: (QGraphicsWKView::QGraphicsWKView):
  • UIProcess/API/qt/qwkpage.cpp: (QWKPagePrivate::QWKPagePrivate): (QWKPagePrivate::init): (QWKPagePrivate::createDrawingAreaProxy): (QWKPagePrivate::didRelaunchProcess): Reset drawing area size after crash.
  • UIProcess/API/qt/qwkpage_p.h:
10:07 AM Changeset in webkit [76261] by Philippe Normand
  • 1 edit
    1 delete in trunk/LayoutTests

2011-01-20 Philippe Normand <pnormand@igalia.com>

Unreviewed, remove GTK result for window-onerror2 as it's the same
as the generic results file.

  • platform/gtk/fast/events/window-onerror2-expected.txt: Removed.
9:49 AM Changeset in webkit [76260] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebCore

2011-01-20 Andreas Kling <kling@webkit.org>

Reviewed by Ariya Hidayat.

[Qt] Fill shadow scratch buffer with proper transparent pixels

QImage::fill() has no Qt::GlobalColor overload in Qt 4.7 (coming in 4.8)
so doing QImage::fill(Qt::transparent) will actually fill all pixels with
the RGBA value 0x00000013.

  • platform/graphics/qt/ContextShadowQt.cpp: (WebCore::ShadowBuffer::scratchImage):
9:15 AM Changeset in webkit [76259] by mjs@apple.com
  • 13 edits in trunk

2011-01-20 Maciej Stachowiak <mjs@apple.com>

Reviewed by Adam Roben.

WebKitTestRunner needs to support layoutTestController.evaluateScriptInIsolatedWorld
https://bugs.webkit.org/show_bug.cgi?id=42327

  • platform/mac-wk2/Skipped: Unskip the tests that needed this.

2011-01-20 Maciej Stachowiak <mjs@apple.com>

Reviewed by Adam Roben.

WebKitTestRunner needs to support layoutTestController.evaluateScriptInIsolatedWorld
https://bugs.webkit.org/show_bug.cgi?id=42327


Added a new API call, WKBundleFrameForJavaScriptContext, that gets the WKBundleFrameRef
that corresponds to a JSContextRef (or null if none).

  • WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp: (WKBundleFrameForJavaScriptContext): Simple wrapper, defers to a WebFrame static method.
  • WebProcess/InjectedBundle/API/c/WKBundleFrame.h:
  • WebProcess/WebPage/WebFrame.cpp: (WebKit::WebFrame::frameForContext): Follow the maze of twisty pointers.
  • WebProcess/WebPage/WebFrame.h:

2011-01-20 Maciej Stachowiak <mjs@apple.com>

Reviewed by Adam Roben.

WebKitTestRunner needs to support layoutTestController.evaluateScriptInIsolatedWorld
https://bugs.webkit.org/show_bug.cgi?id=42327

  • WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Add support for methods that take their normal arguments but also a JSContextRef.
  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: IDL definition for evaluateScriptInIsolatedWorld.
  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::didClearWindowForFrame): Set a magic variable only if this call is for an isolated world.
  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::worldMap): Helper to create a world map. (WTR::LayoutTestController::worldIDForWorld): Map from an ID to a world. (WTR::LayoutTestController::evaluateScriptInIsolatedWorld): The newly added LayoutTestController API.
  • WebKitTestRunner/InjectedBundle/LayoutTestController.h:
9:12 AM Changeset in webkit [76258] by Adam Roben
  • 3 edits
    2 deletes in trunk/Source/WebCore

Remove WKCACFContextFlusher

It wasn't doing anything.

Fixes <http://webkit.org/b/52752> WKCACFContextFlusher is unused

Reviewed by Simon Fraser.

  • WebCore.vcproj/WebCore.vcproj: Removed WKCACFContextFlusher. Also let VS have its way with

the file.

  • platform/graphics/win/WKCACFContextFlusher.cpp: Removed.
  • platform/graphics/win/WKCACFContextFlusher.h: Removed.
  • platform/graphics/win/WKCACFLayerRenderer.cpp:

(WebCore::WKCACFLayerRenderer::~WKCACFLayerRenderer):
(WebCore::WKCACFLayerRenderer::layerTreeDidChange):
Stop telling WKCACFContextFlusher about our context, since it never did anything with it.

9:12 AM Changeset in webkit [76257] by Adam Roben
  • 2 edits in trunk/Source/WebCore

Only flush our own context when we get resized

Fixes <http://webkit.org/b/52751> All WKCACFContexts with uncommitted
changes get flushed whenever any composited page is resized

Reviewed by Simon Fraser.

  • platform/graphics/win/WKCACFLayerRenderer.cpp:

(WebCore::WKCACFLayerRenderer::resize): Just flush our own context, not all contexts
WKCACFContextFlusher knows about. After all, ours is the only one that just got resized!

9:11 AM Changeset in webkit [76256] by Adam Roben
  • 8 edits in trunk/Source

Make WKCACFLayerRenderer ref-counted

This will be needed to handle cases where the client might release its reference to us while
we're calling out to it.

WKCACFLayerRenderer now has a setClient function, which is used rather than passing the
client to create(). This allows clients to null out the client pointer when they're done
with the renderer.

Fixes <http://webkit.org/b/52749> WKCACFLayerRenderer should be
ref-counted

Reviewed by Simon Fraser.

Source/WebCore:

  • platform/graphics/win/MediaPlayerPrivateFullscreenWindow.cpp:

(WebCore::MediaPlayerPrivateFullscreenWindow::MediaPlayerPrivateFullscreenWindow):

  • platform/graphics/win/MediaPlayerPrivateFullscreenWindow.h:

Updated for WKCACFLayerRenderer changes.

  • platform/graphics/win/WKCACFLayerRenderer.cpp:

(WebCore::WKCACFLayerRenderer::acceleratedCompositingAvailable): Updated for changes to
create().
(WebCore::WKCACFLayerRenderer::create): No longer takes a WKCACFLayerRendererClient. Now
returns a PassOwnPtr.
(WebCore::WKCACFLayerRenderer::WKCACFLayerRenderer): No longer takes a
WKCACFLayerRendererClient.

  • platform/graphics/win/WKCACFLayerRenderer.h: Made WKCACFLayerRenderer inherit from

RefCounted.
(WebCore::WKCACFLayerRenderer::setClient): Added this simple setter.

Source/WebKit/win:

Update for WKCACFLayerRenderer changes

  • WebView.cpp:

(WebView::~WebView): Added some assertions to make sure we've gotten rid of our
compositing-related members. My biggest concern was making sure that m_layerRenderer was
gone, which would also mean we had nulled out its client pointer.
(WebView::setAcceleratedCompositing): Changed to call WKCACFLayerRenderer::setClient instead
of passing the client into create(), and to clear out the client before nulling out
m_layerRenderer.

  • WebView.h: Changed m_layerRenderer from an OwnPtr to a RefPtr.
9:11 AM Changeset in webkit [76255] by Adam Roben
  • 2 edits in trunk/Tools

Convert paths in environment variables back to msys-style inside commit-log-editor

When this script gets run from inside git commit, msys-style paths in the environment will
have been turned into Windows-style paths with forward slashes. This screws up functions
like File::Spec->rel2abs, which seem to rely on $PWD having an msys-style path. We convert
the paths back to msys-style before doing anything else.

Fixes <http://webkit.org/b/48527> commit-log-editor uses full paths for section headers when
using msysgit's Perl and multiple ChangeLogs have been edited

Reviewed by David Kilzer.

  • Scripts/commit-log-editor: Call fixEnvironment before doing anything else.

(fixEnvironment): Added. When run in msys in conjunction with git (i.e., when invoked from
inside git commit), convert Windows-style paths in the environment back to msys-style paths.

9:10 AM Changeset in webkit [76254] by Adam Roben
  • 3 edits
    2 adds in trunk

Teach WebView::scrollBackingStore about compositing mode

Test:

compositing/scroll-painted-composited-content.html

Fixes <http://webkit.org/b/52720> REGRESSION (r75987): Assertion failure in
WebView::scrollBackingStore when scrolling page with composited content

Reviewed by Anders Carlsson.

Source/WebKit/win:

  • WebView.cpp:

(WebView::scrollBackingStore): Do something sensible (though naive) when in compositing
mode, rather than incorrectly asserting that this function is never called in that case. For
now we just repaint the entire scrolled region; someday hopefully we can avoid having to
repaint the areas that have just been moved.

LayoutTests:

Add a test that scrolls composited content that has already been painted

  • compositing/scroll-painted-composited-content.html: Added.
  • compositing/scroll-painted-composited-content-expected.txt: Added.
9:08 AM Changeset in webkit [76253] by zoltan@webkit.org
  • 1 edit
    1 add in trunk/Tools

[Win] Unreviewed build fix after r76248.

  • DumpRenderTree/ForwardingHeaders/wtf/FastAllocBase.h: Added.
8:55 AM Changeset in webkit [76252] by alex
  • 2 edits in trunk/Source/WebKit2

2011-01-20 Alejandro G. Castro <alex@igalia.com>

Fix compilation error in GTK WebKit2.

  • Platform/CoreIPC/gtk/ConnectionGtk.cpp: (CoreIPC::readBytesFromSocket): (CoreIPC::writeBytesToSocket):
8:54 AM Changeset in webkit [76251] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

[Qt][V8] Unreviewed buildfix after r76248.

  • bindings/v8/ScriptCachedFrameData.h: Add missing include.
8:53 AM Changeset in webkit [76250] by alex
  • 2 edits in trunk

2011-01-20 Alejandro G. Castro <alex@igalia.com>

Reviewed by Andreas Kling.

[GTK] Fix typo in the webkit2 section of the configure.ac file
https://bugs.webkit.org/show_bug.cgi?id=52801

Fixed typo in the GTK WebKit2 compilation.

  • configure.ac:
8:49 AM Changeset in webkit [76249] by pfeldman@chromium.org
  • 8 edits in trunk/Source/WebCore

2011-01-20 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: enable resource agent upon request.
https://bugs.webkit.org/show_bug.cgi?id=52815

We should not send network-related notifications unless front-end
is interested.

  • inspector/Inspector.idl:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::restoreInspectorStateFromCookie): (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::resourceAgent):
  • inspector/InspectorController.h: (WebCore::InspectorController::consoleAgent): (WebCore::InspectorController::cssAgent): (WebCore::InspectorController::domAgent): (WebCore::InspectorController::injectedScriptAgent): (WebCore::InspectorController::runtimeAgent): (WebCore::InspectorController::databaseAgent): (WebCore::InspectorController::domStorageAgent): (WebCore::InspectorController::fileSystemAgent):
  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::retrieveResourceAgent):
  • inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::restore): (WebCore::InspectorResourceAgent::~InspectorResourceAgent): (WebCore::InspectorResourceAgent::InspectorResourceAgent):
  • inspector/InspectorResourceAgent.h: (WebCore::InspectorResourceAgent::create):
  • inspector/InspectorState.cpp: (WebCore::InspectorState::InspectorState):
  • inspector/InspectorState.h:
8:30 AM Changeset in webkit [76248] by Csaba Osztrogonác
  • 450 edits in trunk

Refactoring of the custom allocation framework
https://bugs.webkit.org/show_bug.cgi?id=49897

Patch by Zoltan Horvath <zoltan@webkit.org> on 2011-01-20
Reviewed by Csaba Osztrogonác.

Source/JavaScriptCore:

Inheriting from FastAllocBase can result in objects getting larger (bug #33896, #46589).
The modification replaces Noncopyable and FastAllocBase classes and these inherits with their
equivalent macro implementation at the necessary places.

  • wtf/FastAllocBase.h: Turn FastAllocBase's implementation into a macro.

Source/WebCore:

Inheriting from FastAllocBase can result in objects getting larger (bug #33896, #46589).
The modification replaces Noncopyable and FastAllocBase classes and these inherits with their
equivalent macro implementation at the necessary places.

Source/WebKit:

Inheriting from FastAllocBase can result in objects getting larger (bug #33896, #46589).
The modification replaces Noncopyable and FastAllocBase classes and these inherits with their
equivalent macro implementation at the necessary places.

Source/WebKit2:

Inheriting from FastAllocBase can result in objects getting larger (bug #33896, #46589).
The modification replaces Noncopyable and FastAllocBase classes and these inherits with their
equivalent macro implementation at the necessary places.

Tools:

Inheriting from FastAllocBase can result in objects getting larger (bug #33896, #46589).
The modification replaces Noncopyable and FastAllocBase classes and these inherits with their
equivalent macro implementation at the necessary places.

8:21 AM Changeset in webkit [76247] by mnaganov@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-01-20 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Chromium] CPU Profiles are cleared when navigating back and forth.

Profiles are now not cleared unless renderer instance was changed.

https://bugs.webkit.org/show_bug.cgi?id=52807

  • inspector/InspectorController.cpp: (WebCore::InspectorController::restoreProfiler):
  • inspector/InspectorProfilerAgent.cpp: (WebCore::InspectorProfilerAgent::resetState): (WebCore::InspectorProfilerAgent::resetFrontendProfiles):
  • inspector/InspectorProfilerAgent.h:
7:59 AM Changeset in webkit [76246] by apavlov@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-01-20 Alexander Pavlov <apavlov@chromium.org>

Unreviewed, add new JS file refs missing from r76116.

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/WebKit.qrc:
7:46 AM Changeset in webkit [76245] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-01-20 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Crash when adding a rule for an ImageDocument
https://bugs.webkit.org/show_bug.cgi?id=52811

  • inspector/InspectorCSSAgent.cpp: (WebCore::InspectorCSSAgent::addRule2): (WebCore::InspectorCSSAgent::viaInspectorStyleSheet):
7:38 AM Changeset in webkit [76244] by yurys@chromium.org
  • 4 edits in trunk/LayoutTests

2011-01-20 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Make fast/events/window-onerror2.html throw exception in deterministic order
https://bugs.webkit.org/show_bug.cgi?id=52813

  • fast/events/window-onerror2-expected.txt:
  • fast/events/window-onerror2.html: call setTimeout from onload handler to make sure exception in the onload handler will be processed before the one in the setTimeout callback
  • platform/chromium/fast/events/window-onerror2-expected.txt:
7:32 AM Changeset in webkit [76243] by yi.4.shen@nokia.com
  • 2 edits in trunk/Tools

2011-01-20 Yi Shen <yi.4.shen@nokia.com>

Unreviewed.

Adding myself to committers.py.

  • Scripts/webkitpy/common/config/committers.py:
7:00 AM Changeset in webkit [76242] by Philippe Normand
  • 1 edit
    1 add in trunk/LayoutTests

2011-01-20 Philippe Normand <pnormand@igalia.com>

Unreviewed, new GTK svg test baselines as follow-up of r76236.

  • platform/gtk/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.txt: Added.
6:52 AM Changeset in webkit [76241] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-01-20 Philippe Normand <pnormand@igalia.com>

Unreviewed, update window-onerror2.html baselines as follow-up of r76216.

  • platform/gtk/fast/events/window-onerror2-expected.txt:
6:50 AM Changeset in webkit [76240] by loislo@chromium.org
  • 5 edits in trunk/Source/WebCore

2011-01-20 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: cleanup InspectorController's friends list.
We have a plan to extract InspectorAgent from InspectorController.
InspectorAgent will be accessible only from InspectorController.
As result we can simply made some methods public and remove long
friends list.

https://bugs.webkit.org/show_bug.cgi?id=52806

  • inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::databaseForId): (WebCore::InjectedScriptHost::selectDatabase): (WebCore::InjectedScriptHost::selectDOMStorage): (WebCore::InjectedScriptHost::inspectorDOMAgent): (WebCore::InjectedScriptHost::frontend):
  • inspector/InspectorBrowserDebuggerAgent.cpp: (WebCore::InspectorBrowserDebuggerAgent::setDOMBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::removeDOMBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::willInsertDOMNode): (WebCore::InspectorBrowserDebuggerAgent::willRemoveDOMNode): (WebCore::InspectorBrowserDebuggerAgent::willModifyDOMAttr): (WebCore::InspectorBrowserDebuggerAgent::descriptionForDOMEvent): (WebCore::InspectorBrowserDebuggerAgent::pauseOnNativeEventIfNeeded): (WebCore::InspectorBrowserDebuggerAgent::willSendXMLHttpRequest):
  • inspector/InspectorController.h: (WebCore::InspectorController::frontend):
  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::willInsertDOMNodeImpl): (WebCore::InspectorInstrumentation::didInsertDOMNodeImpl): (WebCore::InspectorInstrumentation::willRemoveDOMNodeImpl): (WebCore::InspectorInstrumentation::didRemoveDOMNodeImpl): (WebCore::InspectorInstrumentation::willModifyDOMAttrImpl): (WebCore::InspectorInstrumentation::didModifyDOMAttrImpl): (WebCore::InspectorInstrumentation::characterDataModifiedImpl): (WebCore::InspectorInstrumentation::willSendXMLHttpRequestImpl): (WebCore::InspectorInstrumentation::didReceiveResourceResponseImpl): (WebCore::InspectorInstrumentation::didFailLoadingImpl): (WebCore::InspectorInstrumentation::resourceRetrievedByXMLHttpRequestImpl): (WebCore::InspectorInstrumentation::addStartProfilingMessageToConsoleImpl): (WebCore::InspectorInstrumentation::pauseOnNativeEventIfNeeded): (WebCore::InspectorInstrumentation::cancelPauseOnNativeEvent): (WebCore::InspectorInstrumentation::retrieveTimelineAgent): (WebCore::InspectorInstrumentation::retrieveResourceAgent):
6:47 AM Changeset in webkit [76239] by podivilov@chromium.org
  • 6 edits in trunk/Source/WebCore

2011-01-19 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: implement JavaScriptBreakpointsSidebarPane based on events from debugger model.
https://bugs.webkit.org/show_bug.cgi?id=52723

Extract all breakpoints-related presentation code from debugger model to JavaScriptBreakpointSidebarPane.

  • inspector/front-end/Breakpoint.js: (WebInspector.Breakpoint): (WebInspector.Breakpoint.prototype.get data): (WebInspector.Breakpoint.prototype.remove):
  • inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.JavaScriptBreakpointsSidebarPane): (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._breakpointAdded): (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._breakpointRemoved): (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._breakpointEnableChanged): (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._breakpointItemCheckboxClicked): (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._contextMenuEventFired): (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._debuggerPaused): (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._debuggerResumed): (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._addListElement): (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._removeListElement): (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._projectChanged): (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._compare): (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._compareBreakpoints): (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._setupBreakpointElement.didGetSourceLine): (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._setupBreakpointElement): (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._breakpointIdForDebuggerPausedEvent): (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._setBreakpointEnabled): (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._removeBreakpoint): (WebInspector.NativeBreakpointsSidebarPane): (WebInspector.XHRBreakpointsSidebarPane.prototype.addBreakpointItem):
  • inspector/front-end/DebuggerModel.js: (WebInspector.DebuggerModel.prototype.removeBreakpoint): (WebInspector.DebuggerModel.prototype.breakpointForId): (WebInspector.DebuggerModel.prototype._pausedScript): (WebInspector.DebuggerModel.prototype._resumedScript):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel):
  • inspector/front-end/inspector.js:
6:28 AM Changeset in webkit [76238] by Philippe Normand
  • 1 edit
    3 adds in trunk/LayoutTests

2011-01-20 Philippe Normand <pnormand@igalia.com>

Unreviewed, new GTK baselines for 2 new tests.

  • platform/gtk/fast/block/float/float-overflow-hidden-containing-block-width-expected.txt: Added.
  • platform/gtk/svg/css/text-gradient-shadow-expected.txt: Added.
6:23 AM Changeset in webkit [76237] by yurys@chromium.org
  • 4 edits in trunk/LayoutTests

2011-01-20 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Update Chromium test expectations.

  • platform/chromium-win/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-document-write-expected.txt:
  • platform/chromium-win/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-javascript-url-expected.txt:
  • platform/chromium-win/http/tests/security/xss-DENIED-frame-name-expected.txt:
6:11 AM Changeset in webkit [76236] by krit@webkit.org
  • 5 edits
    4 adds in trunk

2011-01-20 Dirk Schulze <krit@webkit.org>

Reviewed by Andreas Kling.

SVG Pattern doesn't take the viewBox of a referenced Pattern
https://bugs.webkit.org/show_bug.cgi?id=52804


SVGPattern element didn't use the viewBox of another SVGPattern element, referenced
by xlink:href. Modified PatternAttributes, to take the value of the viewBox of the
SVGPattern element as well, if the attribute was set.
This gets checked by a W3C SVG test case.

Test: svg/W3C-SVG-1.1-SE/pservers-pattern-04-f.svg

  • rendering/svg/RenderSVGResourcePattern.cpp: (WebCore::RenderSVGResourcePattern::buildTileImageTransform):
  • svg/PatternAttributes.h: (WebCore::PatternAttributes::PatternAttributes): (WebCore::PatternAttributes::viewBox): (WebCore::PatternAttributes::setViewBox): (WebCore::PatternAttributes::hasViewBox):
  • svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::collectPatternAttributes):

2011-01-20 Dirk Schulze <krit@webkit.org>

Reviewed by Andreas Kling.

SVG Pattern doesn't take the viewBox of a referenced Pattern
https://bugs.webkit.org/show_bug.cgi?id=52804


Added a test case of the W3C SVG test suite to check, if we take
the viewBox of a referenced SVGPattern.

  • svg/W3C-SVG-1.1-SE/pservers-pattern-04-f.svg: Added.
  • platform/mac/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.checksum
  • platform/mac/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.png
  • platform/mac/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.txt
5:48 AM Changeset in webkit [76235] by senorblanco@chromium.org
  • 22 edits in trunk

2011-01-19 Stephen White <senorblanco@chromium.org>

[Re-land of r76159 with a compile fix for the Chromium linux shlib
build.]

Reviewed by James Robinson.

Implement accelerated path drawing and clipping for the Canvas2D GPU
path.
https://bugs.webkit.org/show_bug.cgi?id=52627


This is done with a simple curve interpolator and the GLU tesselator,
which is good enough for a 3-5X speedup on
http://ie.microsoft.com/testdrive/Performance/Galactic/Default.html.

Covered by canvas/philip/2d.path.clip.basic.html, and many, many more.
All tests canvas/philip and fast/canvas paths pass with no
regressions, although two have minor pixel differences which require
rebaselining.

  • WebCore.gyp/WebCore.gyp: Add internal_glu include path to chromium build.
  • WebCore.gypi: Add internal_glu files to chromium build.
  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::reset): (WebCore::CanvasRenderingContext2D::platformLayer): Make CanvasRenderingContext2D more robust against failure to create a DrawingBuffer.
  • platform/graphics/chromium/DrawingBufferChromium.cpp: (WebCore::DrawingBuffer::DrawingBuffer): As in DrawingBufferMac.cpp, call reset() from the constructor. Also initialize size to (-1, -1), so reset() doesn't early-out. Add initializers for depthBuffer and stencilBuffer, and remove multisampleDepthStencilBuffer.
  • platform/graphics/chromium/GLES2Canvas.cpp: Remove some unused #includes. (WebCore::GLES2Canvas::State::State): Add clipping state, and implement save/restore via the copy constructor. (WebCore::operator*): (WebCore::Quadratic::Quadratic): (WebCore::Quadratic::fromBezier): (WebCore::Quadratic::evaluate): Quadratic Bezier curve class. (WebCore::Cubic::Cubic): (WebCore::Cubic::fromBezier): (WebCore::Cubic::evaluate): Cubic Bezier curve class. (WebCore::GLES2Canvas::clearRect): Add clipping support to clearRect(). (WebCore::GLES2Canvas::fillPath): Implement fillPath(). (WebCore::GLES2Canvas::fillRect): Add clipping support to fillRect(). (WebCore::GLES2Canvas::clipPath): Implement clipPath(). (WebCore::GLES2Canvas::clipOut): Stub out clipOut() (not called by Canvas 2D). (WebCore::GLES2Canvas::restore): When restoring, draw any remaining clipping paths to the stencil buffer. (WebCore::GLES2Canvas::drawTexturedRect): Add clipping support. (WebCore::interpolateQuadratic): (WebCore::interpolateCubic): Simple curve interpolation, using the Cubic and Quadratic classes. (WebCore::PolygonData::PolygonData): A struct to hold the tesselation data for callbacks. (WebCore::beginData): (WebCore::edgeFlagData): (WebCore::vertexData): (WebCore::endData): (WebCore::combineData): internal_glu tesselation callbacks. (WebCore::GLES2Canvas::createVertexBufferFromPath): Build an interpolated, tesselated vertex buffer and element array buffer from a given path, suitable for filling. (WebCore::GLES2Canvas::beginStencilDraw): Enable stencilling, and disable draws to the color buffer. (WebCore::GLES2Canvas::applyClipping): If clipping is enabled, set the appropriate GL state.
  • platform/graphics/chromium/GLES2Canvas.h: Document the flavours of drawTexturedRect() a bit, so I don't get confused.
  • platform/graphics/gpu/DrawingBuffer.cpp: (WebCore::DrawingBuffer::clear): (WebCore::DrawingBuffer::createSecondaryBuffers): (WebCore::DrawingBuffer::resizeDepthStencil): (WebCore::DrawingBuffer::reset):
  • platform/graphics/gpu/DrawingBuffer.h: Unify m_multisampleDepthStencilBuffer with m_depthStencilBuffer. Implement separate depth and stencil buffers for when OES_packed_depth_stencil is not available. Refactor creation of multisampled and non-multisampled depth and stencil buffers into resizeDepthStencil().
  • platform/graphics/gpu/SharedGraphicsContext3D.cpp: (WebCore::SharedGraphicsContext3D::create): Turn on stencil, turn off depth, turn off antialiasing (for now). (WebCore::SharedGraphicsContext3D::enableStencil):
  • platform/graphics/gpu/SharedGraphicsContext3D.h: Implement stencil enable/disable.
  • platform/graphics/gpu/mac/DrawingBufferMac.mm: (WebCore::DrawingBuffer::DrawingBuffer): Remove m_multisampleDepthStencilBuffer. Set the size to (-1, -1) on creation, so reset() doesn't early-out. Initialize m_depthBuffer and m_stencilBuffer.
  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::canvasClip): (WebCore::GraphicsContext::clipOut): (WebCore::GraphicsContext::clipPath): (WebCore::GraphicsContext::fillPath): Put in GPU hooks for path clipping, and path drawing.
  • platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::canAccelerate): Don't check for clipping paths in canAccelerate() (since we can now accelerate them). (WebCore::PlatformContextSkia::uploadSoftwareToHardware): Don't do clipping when uploading software draws to hardware.
  • thirdparty/glu/README.webkit:
  • thirdparty/glu/gluos.h: #undef MIN and MAX, to fix warnings-as-errors in Chrome/Mac build.
  • thirdparty/glu/libtess/geom.c:
  • thirdparty/glu/libtess/priorityq.c:
  • thirdparty/glu/libtess/render.c: Use do{}while(0) instead of if(1)else construct in macro.
  • thirdparty/glu/libtess/sweep.c: (IsWindingInside): (DoneEdgeDict): Fix some warnings treated as errors for the Linux Release build.

2011-01-19 Stephen White <senorblanco@chromium.org>

Reviewed by James Robinson.


Add two to-be-rebaselined tests for the GPU path.


  • platform/chromium-gpu/test_expectations.txt:
5:46 AM Changeset in webkit [76234] by pfeldman@chromium.org
  • 3 edits in trunk/LayoutTests

2011-01-20 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: rebaselined inspector tests.

  • http/tests/inspector/console-xhr-logging.html:
  • inspector/report-API-errors-expected.txt:
5:14 AM Changeset in webkit [76233] by pfeldman@chromium.org
  • 1 edit in trunk/Source/WebCore/ChangeLog

2011-01-20 Pavel Feldman <pfeldman@chromium.org>

Web Inspector: move releaseObjectGroup to the new Runtime agent.
https://bugs.webkit.org/show_bug.cgi?id=52803
(accedentally landed as r76231)

  • inspector/InspectorContorller.h:
  • inspector/InspectorContorller.cpp:
  • inspector/InspectorRuntimeAgent.h:
  • inspector/InspectorRuntimeAgent.cpp:
4:58 AM Changeset in webkit [76232] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-01-20 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: build fix.

  • inspector/InspectorState.h: (WebCore::InspectorState::setBoolean): (WebCore::InspectorState::setString): (WebCore::InspectorState::setLong):
4:57 AM Changeset in webkit [76231] by pfeldman@chromium.org
  • 5 edits in trunk/Source/WebCore/inspector

2011-01-20 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: build fix.

  • inspector/InspectorState.h: (WebCore::InspectorState::setBoolean): (WebCore::InspectorState::setString): (WebCore::InspectorState::setLong):
4:49 AM Changeset in webkit [76230] by pfeldman@chromium.org
  • 10 edits in trunk/Source/WebCore

2011-01-20 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: further simplify InspectorState.
https://bugs.webkit.org/show_bug.cgi?id=52731

This change moves XHR logging flag into console agent,
removes InspectorState pushing to the front-end.

  • inspector/Inspector.idl:
  • inspector/InspectorConsoleAgent.cpp: (WebCore::InspectorConsoleAgent::InspectorConsoleAgent): (WebCore::InspectorConsoleAgent::resourceRetrievedByXMLHttpRequest): (WebCore::InspectorConsoleAgent::setMonitoringXHREnabled): (WebCore::InspectorConsoleAgent::setConsoleMessagesEnabled): (WebCore::InspectorConsoleAgent::addConsoleMessage):
  • inspector/InspectorConsoleAgent.h:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController):
  • inspector/InspectorController.h: (WebCore::InspectorController::state): (WebCore::InspectorController::settings):
  • inspector/InspectorState.cpp: (WebCore::InspectorState::InspectorState): (WebCore::InspectorState::registerBoolean): (WebCore::InspectorState::registerString): (WebCore::InspectorState::registerLong): (WebCore::InspectorState::registerObject): (WebCore::InspectorState::Property::create):
  • inspector/InspectorState.h:
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.consoleMessagesCleared): (WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.monitoringXHRStateChanged): (WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher): (WebInspector.ConsoleView.prototype._handleContextMenuEvent):
  • inspector/front-end/inspector.js:
4:47 AM Changeset in webkit [76229] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

Unreviewed buildfix.

[Qt][V8] Remove unnecessary files after r76224.

  • WebCore.pro:
4:46 AM Changeset in webkit [76228] by jorlow@chromium.org
  • 10 edits in trunk/LayoutTests

2011-01-20 Jeremy Orlow <jorlow@chromium.org>

[Chromium] Update baselines and add exception.

  • platform/chromium-mac/fast/dom/wrapper-classes-expected.txt:
  • platform/chromium-mac/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-document-write-expected.txt:
  • platform/chromium-mac/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-javascript-url-expected.txt:
  • platform/chromium-mac/http/tests/security/xss-DENIED-frame-name-expected.txt:
  • platform/chromium-win/fast/dom/wrapper-classes-expected.txt:
  • platform/chromium-win/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-document-write-expected.txt:
  • platform/chromium-win/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-javascript-url-expected.txt:
  • platform/chromium-win/http/tests/security/xss-DENIED-frame-name-expected.txt:
  • platform/chromium/test_expectations.txt:
4:38 AM Changeset in webkit [76227] by loislo@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-01-20 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: prepare for extracting InspectorAgent from InspectorController.
https://bugs.webkit.org/show_bug.cgi?id=52797

  • inspector/CodeGeneratorInspector.pm:
  • inspector/InspectorController.h: (WebCore::InspectorController::inspectorAgent): (WebCore::InspectorController::cssAgent): (WebCore::InspectorController::injectedScriptAgent): (WebCore::InspectorController::resourceAgent): (WebCore::InspectorController::runtimeAgent): (WebCore::InspectorController::timelineAgent): (WebCore::InspectorController::databaseAgent): (WebCore::InspectorController::domStorageAgent): (WebCore::InspectorController::fileSystemAgent): (WebCore::InspectorController::browserDebuggerAgent): (WebCore::InspectorController::debuggerAgent): (WebCore::InspectorController::profilerAgent): (WebCore::InspectorController::applicationCacheAgent):
4:36 AM Changeset in webkit [76226] by jorlow@chromium.org
  • 12 edits
    2 deletes in trunk

2011-01-20 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r76215.
http://trac.webkit.org/changeset/76215
https://bugs.webkit.org/show_bug.cgi?id=52799

Caused regressions in Chromium; morrita is going to look at it
tomrorow (Requested by jorlow on #webkit).

  • editing/inserting/insert-composition-whitespace-expected.txt: Removed.
  • editing/inserting/insert-composition-whitespace.html: Removed.

2011-01-20 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r76215.
http://trac.webkit.org/changeset/76215
https://bugs.webkit.org/show_bug.cgi?id=52799

Caused regressions in Chromium; morrita is going to look at it
tomrorow (Requested by jorlow on #webkit).

  • dom/TextEvent.h:
  • dom/TextEventInputType.h:
  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::rebalanceWhitespaceAt):
  • editing/CompositeEditCommand.h:
  • editing/Editor.cpp: (WebCore::Editor::insertTextWithoutSendingTextEvent): (WebCore::Editor::confirmComposition): (WebCore::Editor::setComposition):
  • editing/Editor.h:
  • editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::input):
  • editing/InsertTextCommand.h:
  • editing/TypingCommand.cpp: (WebCore::TypingCommand::TypingCommand): (WebCore::TypingCommand::insertText): (WebCore::TypingCommand::insertTextRunWithoutNewlines):
  • editing/TypingCommand.h: (WebCore::TypingCommand::create):
4:31 AM Changeset in webkit [76225] by podivilov@chromium.org
  • 7 edits in trunk/LayoutTests

2011-01-19 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Eric Seidel.

Web Inspector: enable debugger-pause-on-breakpoint test (fixed by r76129).
https://bugs.webkit.org/show_bug.cgi?id=45291

  • http/tests/inspector/debugger-test2.js: (initialize_DebuggerTest.InspectorTest.setBreakpointInVisibleView):
  • inspector/debugger-breakpoints-not-activated-on-reload.html:
  • inspector/debugger-pause-on-breakpoint.html:
  • platform/gtk/Skipped:
  • platform/mac-leopard/Skipped:
  • platform/win/Skipped:
4:31 AM Changeset in webkit [76224] by yurys@chromium.org
  • 10 edits
    2 deletes in trunk/Source

2010-12-14 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Adam Barth.

[V8] Get rid of delayed exception reporting in V8ConsoleMessage.cpp
https://bugs.webkit.org/show_bug.cgi?id=51044

  • WebCore.gypi:
  • bindings/v8/V8ConsoleMessage.cpp: Removed.
  • bindings/v8/V8ConsoleMessage.h: Removed.
  • bindings/v8/V8DOMWindowShell.cpp: (WebCore::v8UncaughtExceptionHandler): (WebCore::reportUnsafeJavaScriptAccess): (WebCore::V8DOMWindowShell::initContextIfNeeded):
  • bindings/v8/V8Proxy.cpp: (WebCore::addMessageToConsole): (WebCore::logInfo): (WebCore::V8Proxy::reportUnsafeAccessTo): (WebCore::V8Proxy::runScript): (WebCore::V8Proxy::callFunction): (WebCore::V8Proxy::newInstance):
  • bindings/v8/V8Proxy.h:
  • bindings/v8/WorkerContextExecutionProxy.cpp:
  • bindings/v8/specialization/V8BindingState.cpp: (WebCore::::immediatelyReportUnsafeAccessTo):

2010-12-14 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Adam Barth.

[V8] Get rid of delayed exception reporting in V8ConsoleMessage.cpp
https://bugs.webkit.org/show_bug.cgi?id=51044

  • src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::runJavaScriptAlert):
  • src/WebScriptController.cpp: (WebKit::WebScriptController::flushConsoleMessages):
4:28 AM Changeset in webkit [76223] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-01-20 Philippe Normand <pnormand@igalia.com>

Skip failing tests due to missing trailing white space
https://bugs.webkit.org/show_bug.cgi?id=52798

  • platform/gtk/Skipped: Skip 5 http/tests/security tests.
4:16 AM Changeset in webkit [76222] by abarth@webkit.org
  • 2 edits in trunk/Tools

2011-01-20 Adam Barth <abarth@webkit.org>

Reviewed by Tony Chang.

Chromium builders don't delete unversioned directories when DEPS change
https://bugs.webkit.org/show_bug.cgi?id=52745

If we pass this option to gclient sync, gclient will delete directories
that are no longer part of DEPS instead of leaving them around to
confuse us later. Apparently, the downstream buildbots use this option
already.

  • Scripts/update-webkit-chromium:
4:08 AM Changeset in webkit [76221] by morrita@google.com
  • 2 edits in trunk/Source/WebCore

2011-01-19 MORITA Hajime <morrita@google.com>

Reviewed by Eric Seidel.

ShadowElement::m_shadowParent should be removed
https://bugs.webkit.org/show_bug.cgi?id=52558

No new tests. No behavioral change.

  • rendering/ShadowElement.h: (WebCore::ShadowElement::ShadowElement):
2:51 AM Changeset in webkit [76220] by mrobinson@webkit.org
  • 2 edits in trunk/LayoutTests

2011-01-20 Martin Robinson <mrobinson@igalia.com>

Skip a test which requires the textInputController, which
the GTK+ DRT does not have.

  • platform/gtk/Skipped: Skip new test.
2:42 AM Changeset in webkit [76219] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

2011-01-20 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r76172.
http://trac.webkit.org/changeset/76172
https://bugs.webkit.org/show_bug.cgi?id=52792

This test still fails on the 32-bit GTK+ debug bot. (Requested
by mrobinson on #webkit).

  • platform/gtk/Skipped:
2:38 AM Changeset in webkit [76218] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-01-20 MORITA Hajime <morrita@google.com>

Unreviewed, added a skip list entry

  • platform/qt/Skipped:
1:39 AM Changeset in webkit [76217] by hans@chromium.org
  • 11 edits in trunk

2011-01-20 Hans Wennborg <hans@chromium.org>

Reviewed by Jeremy Orlow.

IndexedDB: IDBObjectStore.get should fire onsuccess rather than onerror
https://bugs.webkit.org/show_bug.cgi?id=52725

Update layout tests to expect the onsuccess handler to be fired
when looking up non-existing objects.

  • storage/indexeddb/create-and-remove-object-store-expected.txt:
  • storage/indexeddb/create-and-remove-object-store.html:
  • storage/indexeddb/cursor-delete-expected.txt:
  • storage/indexeddb/cursor-delete.html:
  • storage/indexeddb/objectstore-removeobjectstore-expected.txt:
  • storage/indexeddb/objectstore-removeobjectstore.html:

2011-01-20 Hans Wennborg <hans@chromium.org>

Reviewed by Jeremy Orlow.

IndexedDB: IDBObjectStore.get should fire onsuccess rather than onerror
https://bugs.webkit.org/show_bug.cgi?id=52725

Let IDBObjectStore.get() fire the onsuccess handler with the value
'undefined' for when an object does not exist in the store.

Update SerializedScriptValue to provide such an undefined value.

  • bindings/v8/SerializedScriptValue.cpp: (WebCore::SerializedScriptValue::nullValue): (WebCore::SerializedScriptValue::undefinedValue):
  • bindings/v8/SerializedScriptValue.h:
  • storage/IDBObjectStoreBackendImpl.cpp: (WebCore::IDBObjectStoreBackendImpl::getInternal):
1:28 AM Changeset in webkit [76216] by yurys@chromium.org
  • 41 edits
    2 copies
    2 moves
    47 adds in trunk

2010-12-27 yury semikhatsky <yurys@chromium.org>

reviewed by pavel feldman.

webcore doesn't fire window.onerror event when uncaught javascript exceptions are thrown
https://bugs.webkit.org/show_bug.cgi?id=8519

uncaught exceptions are propagated to window.onerror hander if one is present.
the handler is expected to be a function accepting three arguments: error message,
resource url and line number where the exception occured.

it was decided to dispatch errorevent to all listeners/handlers no matter if they
were created in the same isolated world where the exception occured or not.

tests: fast/events/window-onerror1.html

fast/events/window-onerror10.html
fast/events/window-onerror11.html
fast/events/window-onerror12.html
fast/events/window-onerror2.html
fast/events/window-onerror3.html
fast/events/window-onerror4.html
fast/events/window-onerror5.html
fast/events/window-onerror6.html
fast/events/window-onerror7.html
fast/events/window-onerror8.html
fast/events/window-onerror9.html
http/tests/security/window-onerror-exception-in-iframe.html
userscripts/window-onerror-for-isolated-world-1.html
userscripts/window-onerror-for-isolated-world-2.html

  • android.jscbindings.mk:
  • cmakelists.txt:
  • gnumakefile.am:
  • webcore.gypi:
  • webcore.order:
  • webcore.pro:
  • webcore.vcproj/webcore.vcproj:
  • webcore.xcodeproj/project.pbxproj:
  • bindings/js/jsbindingsallinone.cpp:
  • bindings/js/jsdombinding.cpp: (webcore::reportexception):
  • bindings/js/jserrorhandler.cpp: renamed from webcore/bindings/js/jsworkercontexterrorhandler.cpp. (webcore::jserrorhandler::jserrorhandler): (webcore::jserrorhandler::~jserrorhandler): (webcore::jserrorhandler::handleevent):
  • bindings/js/jserrorhandler.h: copied from webcore/bindings/js/jsworkercontexterrorhandler.h. (webcore::jserrorhandler::create): (webcore::createjserrorhandler):
  • bindings/js/jseventlistener.h:
  • bindings/scripts/codegeneratorjs.pm:
  • bindings/scripts/codegeneratorv8.pm:
  • bindings/v8/v8consolemessage.cpp: (webcore::v8consolemessage::dispatchnow): (webcore::v8consolemessage::handler): the method was changed to use generic webcore exception reporting mechanism which is also used by jsc bindings.
  • bindings/v8/v8consolemessage.h:
  • bindings/v8/v8eventlistener.h:
  • bindings/v8/v8windowerrorhandler.cpp: renamed from webcore/bindings/js/jsworkercontexterrorhandler.h. (webcore::v8windowerrorhandler::v8windowerrorhandler): (webcore::v8windowerrorhandler::calllistenerfunction):
  • bindings/v8/v8windowerrorhandler.h: copied from webcore/dom/errorevent.cpp. (webcore::v8windowerrorhandler::create):
  • bindings/v8/workercontextexecutionproxy.cpp: (webcore::v8messagehandler):
  • bindings/v8/workerscriptcontroller.cpp: (webcore::workerscriptcontroller::evaluate):
  • dom/document.cpp: (webcore::document::erroreventtarget): (webcore::document::logexceptiontoconsole): (webcore::document::addmessage):
  • dom/document.h:
  • dom/errorevent.cpp:
  • dom/errorevent.h:
  • dom/event.cpp: (webcore::event::iserrorevent):
  • dom/event.h:
  • dom/scriptexecutioncontext.cpp: (webcore::scriptexecutioncontext::pendingexception::pendingexception): (webcore::scriptexecutioncontext::scriptexecutioncontext): (webcore::scriptexecutioncontext::reportexception): this method is not virtual anymore to ensure that error event dispatching algorithm is the same in workercontext and in document. (webcore::scriptexecutioncontext::dispatcherrorevent):
  • dom/scriptexecutioncontext.h:
  • websockets/websocket.cpp: (webcore::websocket::connect):
  • websockets/websocketchannel.cpp: (webcore::websocketchannel::didopen): (webcore::websocketchannel::didfail): (webcore::websocketchannel::appendtobuffer):
  • websockets/websockethandshake.cpp: (webcore::websockethandshake::readserverhandshake): (webcore::websockethandshake::readstatusline): (webcore::websockethandshake::readhttpheaders): (webcore::websockethandshake::checkresponseheaders):
  • workers/defaultsharedworkerrepository.cpp: (webcore::postexceptiontask): (webcore::postconsolemessagetask):
  • workers/workercontext.cpp: (webcore::workercontext::workercontext): (webcore::workercontext::erroreventtarget): (webcore::workercontext::logexceptiontoconsole): (webcore::workercontext::addmessage):
  • workers/workercontext.h:
  • workers/workermessagingproxy.cpp: (webcore::workerexceptiontask::performtask): (webcore::postconsolemessagetask):
  • xml/xmlhttprequest.cpp: (webcore::reportunsafeusage):

2010-12-27 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

WebCore doesn't fire window.onerror event when uncaught JavaScript exceptions are thrown
https://bugs.webkit.org/show_bug.cgi?id=8519

Uncaught exceptions are propagated to window.onerror hander if one is present.
The handler is expected to be a function accepting three arguments: error message,
resource url and line number where the exception occured.

  • fast/events/resources/window-onerror.js: Added. (throwException):
  • fast/events/window-onerror1-expected.txt: Added.
  • fast/events/window-onerror1.html: Added.
  • fast/events/window-onerror10-expected.txt: Added.
  • fast/events/window-onerror10.html: Added.
  • fast/events/window-onerror11-expected.txt: Added.
  • fast/events/window-onerror11.html: Added.
  • fast/events/window-onerror12-expected.txt: Added.
  • fast/events/window-onerror12.html: Added.
  • fast/events/window-onerror2-expected.txt: Added.
  • fast/events/window-onerror2.html: Added.
  • fast/events/window-onerror3-expected.txt: Added.
  • fast/events/window-onerror3.html: Added.
  • fast/events/window-onerror4-expected.txt: Added.
  • fast/events/window-onerror4.html: Added.
  • fast/events/window-onerror5-expected.txt: Added.
  • fast/events/window-onerror5.html: Added.
  • fast/events/window-onerror6-expected.txt: Added.
  • fast/events/window-onerror6.html: Added.
  • fast/events/window-onerror7-expected.txt: Added.
  • fast/events/window-onerror7.html: Added.
  • fast/events/window-onerror8-expected.txt: Added.
  • fast/events/window-onerror8.html: Added.
  • fast/events/window-onerror9-expected.txt: Added.
  • fast/events/window-onerror9.html: Added.
  • fast/workers/worker-script-error-expected.txt:
  • http/tests/security/resources/onerror-iframe.html: Added.
  • http/tests/security/window-onerror-exception-in-iframe-expected.txt: Added.
  • http/tests/security/window-onerror-exception-in-iframe.html: Added.
  • platform/chromium-win/fast/workers/worker-script-error-expected.txt:
  • platform/chromium/fast/events/window-onerror1-expected.txt: Added.
  • platform/chromium/fast/events/window-onerror10-expected.txt: Added.
  • platform/chromium/fast/events/window-onerror11-expected.txt: Added.
  • platform/chromium/fast/events/window-onerror2-expected.txt: Added.
  • platform/chromium/fast/events/window-onerror3-expected.txt: Added.
  • platform/chromium/fast/events/window-onerror4-expected.txt: Added.
  • platform/chromium/fast/events/window-onerror5-expected.txt: Added.
  • platform/chromium/fast/events/window-onerror6-expected.txt: Added.
  • platform/chromium/fast/events/window-onerror7-expected.txt: Added.
  • platform/chromium/fast/events/window-onerror8-expected.txt: Added.
  • platform/chromium/fast/events/window-onerror9-expected.txt: Added.
  • platform/chromium/http/tests/security/window-onerror-exception-in-iframe-expected.txt: Added.
  • platform/chromium/userscripts/window-onerror-for-isolated-world-1-expected.txt: Added.
  • platform/chromium/userscripts/window-onerror-for-isolated-world-2-expected.txt: Added.
  • platform/gtk/Skipped:
  • userscripts/window-onerror-for-isolated-world-1-expected.txt: Added.
  • userscripts/window-onerror-for-isolated-world-1.html: Added.
  • userscripts/window-onerror-for-isolated-world-2-expected.txt: Added.
  • userscripts/window-onerror-for-isolated-world-2.html: Added.
1:19 AM Changeset in webkit [76215] by morrita@google.com
  • 12 edits
    2 adds in trunk

2011-01-19 MORITA Hajime <morrita@google.com>

Reviewed by Ryosuke Niwa.

Space and tab characters "sent" by an input method give totally different results than typing them directly.
https://bugs.webkit.org/show_bug.cgi?id=5241

Added a test that exercises continous whitespace characters and tabs inserted by IME.

  • editing/inserting/insert-composition-whitespace-expected.txt: Added.
  • editing/inserting/insert-composition-whitespace.html: Added.

2011-01-19 MORITA Hajime <morrita@google.com>

Reviewed by Ryosuke Niwa.

Space and tab characters "sent" by an input method give totally different results than typing them directly
https://bugs.webkit.org/show_bug.cgi?id=5241

  • Introduced TextEvent::InputTypeComposition and TypingCommand::TextCompositionType to distinguish text input which is originated by composition.
  • Generalized rebalanceWhitespaceAt() to rebalanceWhitespaceOnTextSubstring() to rebalancing range of string on text node, instead of surrounding part of that.

Test: editing/inserting/insert-composition-whitespace.html

  • dom/TextEvent.h: (WebCore::TextEvent::isComposition):
  • dom/TextEventInputType.h: Added TextEventInputComposition as a member of TextEvent::InputType
  • editing/CompositeEditCommand.cpp: (WebCore::containsOnlyWhitespace): (WebCore::CompositeEditCommand::shouldRebalanceLeadingWhitespaceFor): (WebCore::CompositeEditCommand::canRebalance): (WebCore::CompositeEditCommand::rebalanceWhitespaceAt): (WebCore::CompositeEditCommand::rebalanceWhitespaceOnTextSubstring): Added: A generalized version of rebalanceWhitespaceAt(), which takes a range inside Text string.
  • editing/CompositeEditCommand.h:
  • editing/Editor.cpp: (WebCore::Editor::insertTextForConfirmedComposition): Added. (WebCore::Editor::insertTextWithoutSendingTextEvent): (WebCore::Editor::confirmComposition): Now uses insertTextForConfirmedComposition(). (WebCore::Editor::setComposition):
  • editing/Editor.h:
  • editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::input):
  • editing/InsertTextCommand.h:
  • editing/TypingCommand.cpp: (WebCore::TypingCommand::TypingCommand): (WebCore::TypingCommand::insertText): (WebCore::TypingCommand::insertTextRunWithoutNewlines):
  • editing/TypingCommand.h: Added TypingCommand::m_compositionType and TypingCommand::TextCompositionType (WebCore::TypingCommand::setCompositionType): Added. (WebCore::TypingCommand::create):
12:49 AM Changeset in webkit [76214] by mrowe@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Follow-up to r75766 / <rdar://problem/5469576>.

Reviewed by Maciej Stachowiak.

We were failing to initialize the key, causing all sorts of unexpected behavior.

  • wtf/FastMalloc.cpp:

(WTF::setThreadHeap):
(WTF::TCMalloc_ThreadCache::GetThreadHeap):
(WTF::TCMalloc_ThreadCache::InitTSD): Ensure that the key is initialized.

12:15 AM Changeset in webkit [76213] by mjs@apple.com
  • 2 edits in trunk/LayoutTests

2011-01-20 Maciej Stachowiak <mjs@apple.com>

Reviewed by Dan Bernstein.

Skip some tests that are failing on the WebKit2 bot
https://bugs.webkit.org/show_bug.cgi?id=52789

  • platform/mac-wk2/Skipped:

Jan 19, 2011:

11:46 PM Changeset in webkit [76212] by tkent@chromium.org
  • 5 edits in trunk/LayoutTests

2011-01-19 Dominic Cooney <dominicc@google.com>

Reviewed by Kent Tamura.

Update test expectations for QT now that keygen is a HTMLKeygenElement.
https://bugs.webkit.org/show_bug.cgi?id=52787

  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-expected.txt:
  • platform/qt/fast/js/global-constructors-expected.txt:
11:45 PM Changeset in webkit [76211] by mjs@apple.com
  • 2 edits in trunk/LayoutTests

2011-01-19 Maciej Stachowiak <mjs@apple.com>

Reviewed by Dan Bernstein.

Reorganize WebKit2 Skipped list, and remove 56 tests that no longer fail
https://bugs.webkit.org/show_bug.cgi?id=52786

  • platform/mac-wk2/Skipped:
11:36 PM Changeset in webkit [76210] by caseq@chromium.org
  • 3 edits in trunk/LayoutTests

2011-01-19 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Flaky Test: http/tests/inspector/extensions-resources-redirect.html
https://bugs.webkit.org/show_bug.cgi?id=52709

  • http/tests/inspector/extensions-resources-redirect-expected.txt:
  • http/tests/inspector/extensions-resources-redirect.html:
11:02 PM Changeset in webkit [76209] by dimich@chromium.org
  • 1 edit
    1 move in trunk/Source/WebKit/chromium

[Chromium] Unreviewed, build fix.

During revert of 76203, sheriffbot did not revert "rename+change" correctly.

  • src/ChromiumBridge.cpp: Renamed from Source/WebKit/chromium/src/PlatformBridge.cpp.

(WebCore::toChromeClientImpl):
(WebCore::toWebWidgetClient):
(WebCore::getCookieJar):
(WebCore::ChromiumBridge::cacheMetadata):
(WebCore::ChromiumBridge::clipboardIsFormatAvailable):
(WebCore::ChromiumBridge::clipboardReadPlainText):
(WebCore::ChromiumBridge::clipboardReadHTML):
(WebCore::ChromiumBridge::clipboardWriteSelection):
(WebCore::ChromiumBridge::clipboardWritePlainText):
(WebCore::ChromiumBridge::clipboardWriteURL):
(WebCore::ChromiumBridge::clipboardWriteImage):
(WebCore::ChromiumBridge::clipboardWriteData):
(WebCore::ChromiumBridge::clipboardReadAvailableTypes):
(WebCore::ChromiumBridge::clipboardReadData):
(WebCore::ChromiumBridge::clipboardReadFilenames):
(WebCore::ChromiumBridge::setCookies):
(WebCore::ChromiumBridge::cookies):
(WebCore::ChromiumBridge::cookieRequestHeaderFieldValue):
(WebCore::ChromiumBridge::rawCookies):
(WebCore::ChromiumBridge::deleteCookie):
(WebCore::ChromiumBridge::cookiesEnabled):
(WebCore::ChromiumBridge::prefetchDNS):
(WebCore::ChromiumBridge::fileExists):
(WebCore::ChromiumBridge::deleteFile):
(WebCore::ChromiumBridge::deleteEmptyDirectory):
(WebCore::ChromiumBridge::getFileSize):
(WebCore::ChromiumBridge::revealFolderInOS):
(WebCore::ChromiumBridge::getFileModificationTime):
(WebCore::ChromiumBridge::directoryName):
(WebCore::ChromiumBridge::pathByAppendingComponent):
(WebCore::ChromiumBridge::makeAllDirectories):
(WebCore::ChromiumBridge::getAbsolutePath):
(WebCore::ChromiumBridge::isDirectory):
(WebCore::ChromiumBridge::filePathToURL):
(WebCore::ChromiumBridge::openFile):
(WebCore::ChromiumBridge::closeFile):
(WebCore::ChromiumBridge::seekFile):
(WebCore::ChromiumBridge::truncateFile):
(WebCore::ChromiumBridge::readFromFile):
(WebCore::ChromiumBridge::writeToFile):
(WebCore::ChromiumBridge::ensureFontLoaded):
(WebCore::ChromiumBridge::getFontFamilyForCharacters):
(WebCore::ChromiumBridge::getRenderStyleForStrike):
(WebCore::ChromiumBridge::loadFont):
(WebCore::ChromiumBridge::databaseOpenFile):
(WebCore::ChromiumBridge::databaseDeleteFile):
(WebCore::ChromiumBridge::databaseGetFileAttributes):
(WebCore::ChromiumBridge::databaseGetFileSize):
(WebCore::ChromiumBridge::idbFactory):
(WebCore::ChromiumBridge::idbShutdown):
(WebCore::ChromiumBridge::createIDBKeysFromSerializedValuesAndKeyPath):
(WebCore::ChromiumBridge::signedPublicKeyAndChallengeString):
(WebCore::ChromiumBridge::computedDefaultLanguage):
(WebCore::ChromiumBridge::layoutTestMode):
(WebCore::ChromiumBridge::isSupportedImageMIMEType):
(WebCore::ChromiumBridge::isSupportedJavaScriptMIMEType):
(WebCore::ChromiumBridge::isSupportedNonImageMIMEType):
(WebCore::ChromiumBridge::mimeTypeForExtension):
(WebCore::ChromiumBridge::mimeTypeFromFile):
(WebCore::ChromiumBridge::preferredExtensionForMIMEType):
(WebCore::ChromiumBridge::plugins):
(WebCore::ChromiumBridge::pluginScriptableObject):
(WebCore::ChromiumBridge::loadPlatformImageResource):
(WebCore::ChromiumBridge::loadPlatformAudioResource):
(WebCore::ChromiumBridge::decodeAudioFileData):
(WebCore::ChromiumBridge::sandboxEnabled):
(WebCore::ChromiumBridge::setSharedTimerFiredFunction):
(WebCore::ChromiumBridge::setSharedTimerFireTime):
(WebCore::ChromiumBridge::stopSharedTimer):
(WebCore::ChromiumBridge::decrementStatsCounter):
(WebCore::ChromiumBridge::incrementStatsCounter):
(WebCore::ChromiumBridge::histogramCustomCounts):
(WebCore::ChromiumBridge::histogramEnumeration):
(WebCore::ChromiumBridge::suddenTerminationChanged):
(WebCore::ChromiumBridge::currentTime):
(WebCore::ChromiumBridge::paintButton):
(WebCore::ChromiumBridge::paintMenuList):
(WebCore::ChromiumBridge::paintScrollbarArrow):
(WebCore::ChromiumBridge::paintScrollbarThumb):
(WebCore::ChromiumBridge::paintScrollbarTrack):
(WebCore::ChromiumBridge::paintSpinButton):
(WebCore::ChromiumBridge::paintTextField):
(WebCore::ChromiumBridge::paintTrackbar):
(WebCore::ChromiumBridge::paintProgressBar):
(WebCore::WebThemePart):
(WebCore::WebThemeState):
(WebCore::GetWebThemeExtraParams):
(WebCore::ChromiumBridge::getThemePartSize):
(WebCore::ChromiumBridge::paintThemePart):
(WebCore::ChromiumBridge::traceEventBegin):
(WebCore::ChromiumBridge::traceEventEnd):
(WebCore::ChromiumBridge::visitedLinkHash):
(WebCore::ChromiumBridge::isLinkVisited):
(WebCore::ChromiumBridge::notifyJSOutOfMemory):
(WebCore::ChromiumBridge::memoryUsageMB):
(WebCore::ChromiumBridge::actualMemoryUsageMB):
(WebCore::ChromiumBridge::screenDepth):
(WebCore::ChromiumBridge::screenDepthPerComponent):
(WebCore::ChromiumBridge::screenIsMonochrome):
(WebCore::ChromiumBridge::screenRect):
(WebCore::ChromiumBridge::screenAvailableRect):
(WebCore::ChromiumBridge::popupsAllowed):
(WebCore::WorkerContextProxy::create):

10:35 PM Changeset in webkit [76208] by tkent@chromium.org
  • 25 edits
    3 adds
    2 deletes in trunk

2011-01-19 Dominic Cooney <dominicc@google.com>

Reviewed by Kent Tamura.

Make <keygen> no longer appear to be a <select> element to script.
https://bugs.webkit.org/show_bug.cgi?id=52557

The intent is to put <keygen> options into shadow DOM. This change
takes the first step by hiding the <select> element from
JavaScript.

Test: fast/dom/HTMLKeygenElement/keygen.html

  • CMakeLists.txt: Adds new IDL-derived wrapper.
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/gobject/GNUmakefile.am:
  • bindings/gobject/WebKitHTMLElementWrapperFactory.cpp: (WebKit::createKeygenWrapper): (WebKit::createHTMLElementWrapper):
  • bindings/objc/DOM.mm: (WebCore::createElementClassMap): Keygen no longer DOMHTMLSelectElement
  • html/HTMLKeygenElement.h: (WebCore::HTMLKeygenElement::willValidate): Now public.
  • html/HTMLKeygenElement.idl: Added.
  • html/HTMLTagNames.in: Keygen's wrapper is HTMLKeygenElement.
  • page/DOMWindow.idl: Add HTMLKeygenElement constructor.

2011-01-19 Dominic Cooney <dominicc@google.com>

Reviewed by Kent Tamura.

Make <keygen> no longer appear to be a <select> element to script.

https://bugs.webkit.org/show_bug.cgi?id=52557

  • fast/dom/HTMLKeygenElement/keygen-expected.txt: Added.
  • fast/dom/HTMLKeygenElement/keygen-option-select-expected.txt: Removed.
  • fast/dom/HTMLKeygenElement/keygen-option-select.html: Removed.
  • fast/dom/HTMLKeygenElement/keygen.html: Added.
  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/Window/window-property-descriptors-expected.txt:
  • fast/dom/prototype-inheritance-2-expected.txt:
  • fast/dom/prototype-inheritance-expected.txt:
  • fast/dom/wrapper-classes-expected.txt:
  • fast/dom/wrapper-classes.html:
  • fast/js/global-constructors-expected.txt:
  • platform/mac/fast/dom/wrapper-classes-objc-expected.txt:
  • platform/mac/fast/dom/wrapper-classes-objc.html:
10:09 PM Changeset in webkit [76207] by dimich@chromium.org
  • 55 edits
    1 add in trunk/Source

2011-01-19 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r76203.
http://trac.webkit.org/changeset/76203
https://bugs.webkit.org/show_bug.cgi?id=52784

Broke Win compile on Chromium bots (Requested by dimich on
#webkit).

  • WebCore.gypi:
  • bindings/v8/V8DOMWindowShell.cpp: (WebCore::reportFatalErrorInV8):
  • page/PageGroup.cpp: (WebCore::PageGroup::isLinkVisited):
  • platform/android/PlatformBridge.h:
  • platform/audio/chromium/AudioBusChromium.cpp: (WebCore::createBusFromInMemoryAudioFile):
  • platform/chromium/ChromiumBridge.h: Added.
  • platform/chromium/ChromiumDataObjectLegacy.cpp: (WebCore::ChromiumDataObjectLegacy::getData):
  • platform/chromium/DragDataChromium.cpp: (WebCore::DragData::asURL):
  • platform/chromium/FileSystemChromium.cpp: (WebCore::deleteFile): (WebCore::deleteEmptyDirectory): (WebCore::getFileSize): (WebCore::getFileModificationTime): (WebCore::revealFolderInOS): (WebCore::directoryName): (WebCore::pathByAppendingComponent): (WebCore::makeAllDirectories): (WebCore::fileExists): (WebCore::openFile): (WebCore::closeFile): (WebCore::seekFile): (WebCore::truncateFile): (WebCore::readFromFile): (WebCore::writeToFile):
  • platform/chromium/LanguageChromium.cpp: (WebCore::platformDefaultLanguage):
  • platform/chromium/LinkHashChromium.cpp: (WebCore::visitedLinkHash):
  • platform/chromium/MIMETypeRegistryChromium.cpp: (WebCore::MIMETypeRegistry::getMIMETypeForExtension): (WebCore::MIMETypeRegistry::getPreferredExtensionForMIMEType): (WebCore::MIMETypeRegistry::isSupportedImageMIMEType): (WebCore::MIMETypeRegistry::isSupportedJavaScriptMIMEType): (WebCore::MIMETypeRegistry::isSupportedNonImageMIMEType):
  • platform/chromium/PasteboardChromium.cpp: (WebCore::Pasteboard::writeSelection): (WebCore::Pasteboard::writePlainText): (WebCore::Pasteboard::writeURL): (WebCore::Pasteboard::writeImage): (WebCore::Pasteboard::canSmartReplace): (WebCore::Pasteboard::plainText): (WebCore::Pasteboard::documentFragment):
  • platform/chromium/PlatformBridge.h:
  • platform/chromium/PlatformScreenChromium.cpp: (WebCore::screenDepth): (WebCore::screenDepthPerComponent): (WebCore::screenIsMonochrome): (WebCore::screenRect): (WebCore::screenAvailableRect):
  • platform/chromium/ReadableDataObject.cpp: (WebCore::ReadableDataObject::getData): (WebCore::ReadableDataObject::urlTitle): (WebCore::ReadableDataObject::htmlBaseUrl): (WebCore::ReadableDataObject::filenames): (WebCore::ReadableDataObject::ensureTypeCacheInitialized):
  • platform/chromium/SSLKeyGeneratorChromium.cpp: (WebCore::signedPublicKeyAndChallengeString):
  • platform/chromium/ScrollbarThemeChromium.cpp:
  • platform/chromium/ScrollbarThemeChromiumLinux.cpp: (WebCore::ScrollbarThemeChromiumLinux::scrollbarThickness): (WebCore::ScrollbarThemeChromiumLinux::paintTrackPiece): (WebCore::ScrollbarThemeChromiumLinux::paintButton): (WebCore::ScrollbarThemeChromiumLinux::paintThumb): (WebCore::ScrollbarThemeChromiumLinux::buttonSize): (WebCore::ScrollbarThemeChromiumLinux::minimumThumbLength):
  • platform/chromium/ScrollbarThemeChromiumMac.mm: (WebCore::scrollbarStateToThemeState): (WebCore::ScrollbarThemeChromiumMac::paint):
  • platform/chromium/ScrollbarThemeChromiumWin.cpp: (WebCore::ScrollbarThemeChromiumWin::scrollbarThickness): (WebCore::ScrollbarThemeChromiumWin::paintTrackPiece): (WebCore::ScrollbarThemeChromiumWin::paintButton): (WebCore::ScrollbarThemeChromiumWin::paintThumb): (WebCore::ScrollbarThemeChromiumWin::buttonSize):
  • platform/chromium/SharedTimerChromium.cpp: (WebCore::setSharedTimerFiredFunction): (WebCore::setSharedTimerFireTime): (WebCore::stopSharedTimer):
  • platform/chromium/SuddenTerminationChromium.cpp: (WebCore::disableSuddenTermination): (WebCore::enableSuddenTermination):
  • platform/chromium/SystemTimeChromium.cpp: (WebCore::currentTime):
  • platform/chromium/WritableDataObject.cpp: (WebCore::WritableDataObject::setData):
  • platform/graphics/chromium/CrossProcessFontLoading.mm:
  • platform/graphics/chromium/FontCacheChromiumWin.cpp: (WebCore::fontContainsCharacter): (WebCore::FillLogFont):
  • platform/graphics/chromium/FontCacheLinux.cpp: (WebCore::FontCache::getFontDataForCharacters):
  • platform/graphics/chromium/FontChromiumWin.cpp: (WebCore::Font::drawGlyphs):
  • platform/graphics/chromium/FontPlatformDataChromiumWin.cpp: (WebCore::FontPlatformData::scriptFontProperties):
  • platform/graphics/chromium/FontPlatformDataLinux.cpp: (WebCore::FontPlatformData::querySystemForRenderStyle):
  • platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp: (WebCore::fillBMPGlyphs):
  • platform/graphics/chromium/ImageChromium.cpp: (WebCore::Image::loadPlatformResource):
  • platform/graphics/chromium/ImageChromiumMac.mm: (WebCore::Image::loadPlatformResource):
  • platform/graphics/chromium/SimpleFontDataChromiumWin.cpp: (WebCore::SimpleFontData::platformInit): (WebCore::SimpleFontData::determinePitch): (WebCore::SimpleFontData::platformWidthForGlyph):
  • platform/graphics/chromium/UniscribeHelperTextRun.cpp: (WebCore::UniscribeHelperTextRun::tryToPreloadFont):
  • platform/graphics/skia/FontCustomPlatformData.cpp: (WebCore::FontCustomPlatformData::fontPlatformData):
  • platform/network/chromium/CookieJarChromium.cpp: (WebCore::setCookies): (WebCore::cookies): (WebCore::cookieRequestHeaderFieldValue): (WebCore::cookiesEnabled): (WebCore::getRawCookies): (WebCore::deleteCookie):
  • platform/network/chromium/DNSChromium.cpp: (WebCore::prefetchDNS):
  • platform/qt/PlatformBridge.h:
  • platform/sql/chromium/SQLiteFileSystemChromium.cpp: (WebCore::SQLiteFileSystem::deleteDatabaseFile): (WebCore::SQLiteFileSystem::getDatabaseFileSize):
  • platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp: (chromiumOpen): (chromiumDelete): (chromiumAccess):
  • platform/sql/chromium/SQLiteFileSystemChromiumWin.cpp:
  • plugins/chromium/PluginDataChromium.cpp: (WebCore::PluginCache::plugins):
  • rendering/RenderThemeChromiumMac.mm: (WebCore::RenderThemeChromiumMac::usesTestModeFocusRingColor):
  • rendering/RenderThemeChromiumSkia.cpp: (WebCore::RenderThemeChromiumSkia::caretBlinkInterval):
  • rendering/RenderThemeChromiumWin.cpp: (WebCore::RenderThemeChromiumWin::platformActiveSelectionBackgroundColor): (WebCore::RenderThemeChromiumWin::platformInactiveSelectionBackgroundColor): (WebCore::RenderThemeChromiumWin::platformActiveSelectionForegroundColor): (WebCore::RenderThemeChromiumWin::systemColor): (WebCore::RenderThemeChromiumWin::paintButton): (WebCore::RenderThemeChromiumWin::paintSliderTrack): (WebCore::menuListButtonWidth): (WebCore::RenderThemeChromiumWin::paintMenuList): (WebCore::RenderThemeChromiumWin::paintTextFieldInternal): (WebCore::RenderThemeChromiumWin::paintInnerSpinButton): (WebCore::RenderThemeChromiumWin::paintProgressBar):
  • storage/chromium/IDBFactoryBackendInterface.cpp: (WebCore::IDBFactoryBackendInterface::create): (WebCore::IDBFactoryBackendInterface::~IDBFactoryBackendInterface):
  • storage/chromium/IDBKeyPathBackendImpl.cpp: (WebCore::IDBKeyPathBackendImpl::createIDBKeysFromSerializedValuesAndKeyPath):

2011-01-19 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r76203.
http://trac.webkit.org/changeset/76203
https://bugs.webkit.org/show_bug.cgi?id=52784

Broke Win compile on Chromium bots (Requested by dimich on
#webkit).

  • WebKit.gyp:
  • src/AssertMatchingEnums.cpp:
  • src/ChromiumBridge.cpp: Renamed from Source/WebKit/chromium/src/PlatformBridge.cpp. (WebCore::toChromeClientImpl): (WebCore::toWebWidgetClient): (WebCore::getCookieJar): (WebCore::ChromiumBridge::cacheMetadata): (WebCore::ChromiumBridge::clipboardIsFormatAvailable): (WebCore::ChromiumBridge::clipboardReadPlainText): (WebCore::ChromiumBridge::clipboardReadHTML): (WebCore::ChromiumBridge::clipboardWriteSelection): (WebCore::ChromiumBridge::clipboardWritePlainText): (WebCore::ChromiumBridge::clipboardWriteURL): (WebCore::ChromiumBridge::clipboardWriteImage): (WebCore::ChromiumBridge::clipboardWriteData): (WebCore::ChromiumBridge::clipboardReadAvailableTypes): (WebCore::ChromiumBridge::clipboardReadData): (WebCore::ChromiumBridge::clipboardReadFilenames): (WebCore::ChromiumBridge::setCookies): (WebCore::ChromiumBridge::cookies): (WebCore::ChromiumBridge::cookieRequestHeaderFieldValue): (WebCore::ChromiumBridge::rawCookies): (WebCore::ChromiumBridge::deleteCookie): (WebCore::ChromiumBridge::cookiesEnabled): (WebCore::ChromiumBridge::prefetchDNS): (WebCore::ChromiumBridge::fileExists): (WebCore::ChromiumBridge::deleteFile): (WebCore::ChromiumBridge::deleteEmptyDirectory): (WebCore::ChromiumBridge::getFileSize): (WebCore::ChromiumBridge::revealFolderInOS): (WebCore::ChromiumBridge::getFileModificationTime): (WebCore::ChromiumBridge::directoryName): (WebCore::ChromiumBridge::pathByAppendingComponent): (WebCore::ChromiumBridge::makeAllDirectories): (WebCore::ChromiumBridge::getAbsolutePath): (WebCore::ChromiumBridge::isDirectory): (WebCore::ChromiumBridge::filePathToURL): (WebCore::ChromiumBridge::openFile): (WebCore::ChromiumBridge::closeFile): (WebCore::ChromiumBridge::seekFile): (WebCore::ChromiumBridge::truncateFile): (WebCore::ChromiumBridge::readFromFile): (WebCore::ChromiumBridge::writeToFile): (WebCore::ChromiumBridge::ensureFontLoaded): (WebCore::ChromiumBridge::getFontFamilyForCharacters): (WebCore::ChromiumBridge::getRenderStyleForStrike): (WebCore::ChromiumBridge::loadFont): (WebCore::ChromiumBridge::databaseOpenFile): (WebCore::ChromiumBridge::databaseDeleteFile): (WebCore::ChromiumBridge::databaseGetFileAttributes): (WebCore::ChromiumBridge::databaseGetFileSize): (WebCore::ChromiumBridge::idbFactory): (WebCore::ChromiumBridge::idbShutdown): (WebCore::ChromiumBridge::createIDBKeysFromSerializedValuesAndKeyPath): (WebCore::ChromiumBridge::signedPublicKeyAndChallengeString): (WebCore::ChromiumBridge::computedDefaultLanguage): (WebCore::ChromiumBridge::layoutTestMode): (WebCore::ChromiumBridge::isSupportedImageMIMEType): (WebCore::ChromiumBridge::isSupportedJavaScriptMIMEType): (WebCore::ChromiumBridge::isSupportedNonImageMIMEType): (WebCore::ChromiumBridge::mimeTypeForExtension): (WebCore::ChromiumBridge::mimeTypeFromFile): (WebCore::ChromiumBridge::preferredExtensionForMIMEType): (WebCore::ChromiumBridge::plugins): (WebCore::ChromiumBridge::pluginScriptableObject): (WebCore::ChromiumBridge::loadPlatformImageResource): (WebCore::ChromiumBridge::loadPlatformAudioResource): (WebCore::ChromiumBridge::decodeAudioFileData): (WebCore::ChromiumBridge::sandboxEnabled): (WebCore::ChromiumBridge::setSharedTimerFiredFunction): (WebCore::ChromiumBridge::setSharedTimerFireTime): (WebCore::ChromiumBridge::stopSharedTimer): (WebCore::ChromiumBridge::decrementStatsCounter): (WebCore::ChromiumBridge::incrementStatsCounter): (WebCore::ChromiumBridge::histogramCustomCounts): (WebCore::ChromiumBridge::histogramEnumeration): (WebCore::ChromiumBridge::suddenTerminationChanged): (WebCore::ChromiumBridge::currentTime): (WebCore::ChromiumBridge::paintButton): (WebCore::ChromiumBridge::paintMenuList): (WebCore::ChromiumBridge::paintScrollbarArrow): (WebCore::ChromiumBridge::paintScrollbarThumb): (WebCore::ChromiumBridge::paintScrollbarTrack): (WebCore::ChromiumBridge::paintSpinButton): (WebCore::ChromiumBridge::paintTextField): (WebCore::ChromiumBridge::paintTrackbar): (WebCore::ChromiumBridge::paintProgressBar): (WebCore::WebThemePart): (WebCore::WebThemeState): (WebCore::GetWebThemeExtraParams): (WebCore::ChromiumBridge::getThemePartSize): (WebCore::ChromiumBridge::paintThemePart): (WebCore::ChromiumBridge::traceEventBegin): (WebCore::ChromiumBridge::traceEventEnd): (WebCore::ChromiumBridge::visitedLinkHash): (WebCore::ChromiumBridge::isLinkVisited): (WebCore::ChromiumBridge::notifyJSOutOfMemory): (WebCore::ChromiumBridge::memoryUsageMB): (WebCore::ChromiumBridge::actualMemoryUsageMB): (WebCore::ChromiumBridge::screenDepth): (WebCore::ChromiumBridge::screenDepthPerComponent): (WebCore::ChromiumBridge::screenIsMonochrome): (WebCore::ChromiumBridge::screenRect): (WebCore::ChromiumBridge::screenAvailableRect): (WebCore::ChromiumBridge::popupsAllowed): (WebCore::WorkerContextProxy::create):
  • src/ResourceHandle.cpp: (WebCore::ResourceHandle::cacheMetadata):
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::WebFrameImpl): (WebKit::WebFrameImpl::~WebFrameImpl):
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
9:57 PM Changeset in webkit [76206] by commit-queue@webkit.org
  • 3 edits
    6 adds in trunk

2011-01-19 Helder Correia <helder@sencha.com>

Reviewed by Andreas Kling.

[Qt] GraphicsContext::strokePath() paints solid shadows with incorrect alpha
https://bugs.webkit.org/show_bug.cgi?id=52705

This is related to bug 52611. The shadow color alpha must be multiplied
by the context pen alpha. Fixing this results in correct behavior for
Canvas path stroke() and strokeRect() [which relies on stroke()].

  • fast/canvas/canvas-strokePath-alpha-shadow-expected.txt: Added.
  • fast/canvas/canvas-strokePath-alpha-shadow.html: Added.
  • fast/canvas/canvas-strokeRect-alpha-shadow-expected.txt: Added.
  • fast/canvas/canvas-strokeRect-alpha-shadow.html: Added.
  • fast/canvas/script-tests/canvas-strokePath-alpha-shadow.js: Added.
  • fast/canvas/script-tests/canvas-strokeRect-alpha-shadow.js: Added.

2011-01-19 Helder Correia <helder@sencha.com>

Reviewed by Andreas Kling.

[Qt] GraphicsContext::strokePath() paints solid shadows with incorrect alpha
https://bugs.webkit.org/show_bug.cgi?id=52705

This is related to bug 52611. The shadow color alpha must be multiplied
by the context pen alpha. Fixing this results in correct behavior for
Canvas path stroke() and strokeRect() [which relies on stroke()].

Tests: fast/canvas/canvas-strokePath-alpha-shadow.html

fast/canvas/canvas-strokeRect-alpha-shadow.html

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::strokePath):
9:49 PM Changeset in webkit [76205] by darin@chromium.org
  • 10 edits
    16 adds
    9 deletes in trunk

2011-01-19 Darin Fisher <darin@chromium.org>

Reviewed by Mihai Parparita.

Re-initialize the HistoryItem fully when navigating to a HistoryItem,
or replacing a HistoryItem, results in a different URL.

https://bugs.webkit.org/show_bug.cgi?id=49654

This patch also forces all HistoryItems to record the post-redirect
URL. Previously, frames would remember the pre-redirect URL. This is
problematic since other members of the HistoryItem correspond to the
post-redirect URL.

Tests: fast/history/history-replace-updates-current-item.html

http/tests/navigation/redirect-on-back-updates-history-item.html
http/tests/navigation/redirect-on-reload-updates-history-item.html

  • history/HistoryItem.cpp: (WebCore::HistoryItem::HistoryItem): (WebCore::HistoryItem::reset):
  • history/HistoryItem.h:
  • loader/HistoryController.cpp: (WebCore::HistoryController::updateForBackForwardNavigation): (WebCore::HistoryController::updateForReload): (WebCore::HistoryController::updateForStandardLoad): (WebCore::HistoryController::updateForRedirectWithLockedBackForwardList): (WebCore::HistoryController::initializeItem): (WebCore::HistoryController::createItem): (WebCore::HistoryController::createItemTree): (WebCore::HistoryController::updateCurrentItem):
  • loader/HistoryController.h:
9:31 PM Changeset in webkit [76204] by dimich@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed, update of test expectations.

  • platform/chromium/test_expectations.txt:
9:17 PM Changeset in webkit [76203] by commit-queue@webkit.org
  • 55 edits
    1 move
    1 delete in trunk/Source

2011-01-19 Adam Klein <adamk@chromium.org>

Reviewed by Darin Fisher.

[chromium] Rename ChromiumBridge to PlatformBridge
https://bugs.webkit.org/show_bug.cgi?id=52471

No tests added as this is a rename; no change in behavior.

  • WebCore.gypi:
  • bindings/v8/V8DOMWindowShell.cpp: (WebCore::reportFatalErrorInV8):
  • page/PageGroup.cpp: (WebCore::PageGroup::isLinkVisited):
  • platform/android/PlatformBridge.h:
  • platform/audio/chromium/AudioBusChromium.cpp: (WebCore::createBusFromInMemoryAudioFile):
  • platform/chromium/ChromiumBridge.h: Removed.
  • platform/chromium/ChromiumDataObjectLegacy.cpp: (WebCore::ChromiumDataObjectLegacy::getData):
  • platform/chromium/DragDataChromium.cpp: (WebCore::DragData::asURL):
  • platform/chromium/FileSystemChromium.cpp: (WebCore::deleteFile): (WebCore::deleteEmptyDirectory): (WebCore::getFileSize): (WebCore::getFileModificationTime): (WebCore::revealFolderInOS): (WebCore::directoryName): (WebCore::pathByAppendingComponent): (WebCore::makeAllDirectories): (WebCore::fileExists): (WebCore::openFile): (WebCore::closeFile): (WebCore::seekFile): (WebCore::truncateFile): (WebCore::readFromFile): (WebCore::writeToFile):
  • platform/chromium/LanguageChromium.cpp: (WebCore::platformDefaultLanguage):
  • platform/chromium/LinkHashChromium.cpp: (WebCore::visitedLinkHash):
  • platform/chromium/MIMETypeRegistryChromium.cpp: (WebCore::MIMETypeRegistry::getMIMETypeForExtension): (WebCore::MIMETypeRegistry::getPreferredExtensionForMIMEType): (WebCore::MIMETypeRegistry::isSupportedImageMIMEType): (WebCore::MIMETypeRegistry::isSupportedJavaScriptMIMEType): (WebCore::MIMETypeRegistry::isSupportedNonImageMIMEType):
  • platform/chromium/PasteboardChromium.cpp: (WebCore::Pasteboard::writeSelection): (WebCore::Pasteboard::writePlainText): (WebCore::Pasteboard::writeURL): (WebCore::Pasteboard::writeImage): (WebCore::Pasteboard::canSmartReplace): (WebCore::Pasteboard::plainText): (WebCore::Pasteboard::documentFragment):
  • platform/chromium/PlatformBridge.h:
  • platform/chromium/PlatformScreenChromium.cpp: (WebCore::screenDepth): (WebCore::screenDepthPerComponent): (WebCore::screenIsMonochrome): (WebCore::screenRect): (WebCore::screenAvailableRect):
  • platform/chromium/ReadableDataObject.cpp: (WebCore::ReadableDataObject::getData): (WebCore::ReadableDataObject::urlTitle): (WebCore::ReadableDataObject::htmlBaseUrl): (WebCore::ReadableDataObject::filenames): (WebCore::ReadableDataObject::ensureTypeCacheInitialized):
  • platform/chromium/SSLKeyGeneratorChromium.cpp: (WebCore::signedPublicKeyAndChallengeString):
  • platform/chromium/ScrollbarThemeChromium.cpp:
  • platform/chromium/ScrollbarThemeChromiumLinux.cpp: (WebCore::ScrollbarThemeChromiumLinux::scrollbarThickness): (WebCore::ScrollbarThemeChromiumLinux::paintTrackPiece): (WebCore::ScrollbarThemeChromiumLinux::paintButton): (WebCore::ScrollbarThemeChromiumLinux::paintThumb): (WebCore::ScrollbarThemeChromiumLinux::buttonSize): (WebCore::ScrollbarThemeChromiumLinux::minimumThumbLength):
  • platform/chromium/ScrollbarThemeChromiumMac.mm: (WebCore::scrollbarStateToThemeState): (WebCore::ScrollbarThemeChromiumMac::paint):
  • platform/chromium/ScrollbarThemeChromiumWin.cpp: (WebCore::ScrollbarThemeChromiumWin::scrollbarThickness): (WebCore::ScrollbarThemeChromiumWin::paintTrackPiece): (WebCore::ScrollbarThemeChromiumWin::paintButton): (WebCore::ScrollbarThemeChromiumWin::paintThumb): (WebCore::ScrollbarThemeChromiumWin::buttonSize):
  • platform/chromium/SharedTimerChromium.cpp: (WebCore::setSharedTimerFiredFunction): (WebCore::setSharedTimerFireTime): (WebCore::stopSharedTimer):
  • platform/chromium/SuddenTerminationChromium.cpp: (WebCore::disableSuddenTermination): (WebCore::enableSuddenTermination):
  • platform/chromium/SystemTimeChromium.cpp: (WebCore::currentTime):
  • platform/chromium/WritableDataObject.cpp: (WebCore::WritableDataObject::setData):
  • platform/graphics/chromium/CrossProcessFontLoading.mm:
  • platform/graphics/chromium/FontCacheChromiumWin.cpp: (WebCore::fontContainsCharacter): (WebCore::FillLogFont):
  • platform/graphics/chromium/FontCacheLinux.cpp: (WebCore::FontCache::getFontDataForCharacters):
  • platform/graphics/chromium/FontChromiumWin.cpp: (WebCore::Font::drawGlyphs):
  • platform/graphics/chromium/FontPlatformDataChromiumWin.cpp: (WebCore::FontPlatformData::scriptFontProperties):
  • platform/graphics/chromium/FontPlatformDataLinux.cpp: (WebCore::FontPlatformData::querySystemForRenderStyle):
  • platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp: (WebCore::fillBMPGlyphs):
  • platform/graphics/chromium/ImageChromium.cpp: (WebCore::Image::loadPlatformResource):
  • platform/graphics/chromium/ImageChromiumMac.mm: (WebCore::Image::loadPlatformResource):
  • platform/graphics/chromium/SimpleFontDataChromiumWin.cpp: (WebCore::SimpleFontData::platformInit): (WebCore::SimpleFontData::determinePitch): (WebCore::SimpleFontData::platformWidthForGlyph):
  • platform/graphics/chromium/UniscribeHelperTextRun.cpp: (WebCore::UniscribeHelperTextRun::tryToPreloadFont):
  • platform/graphics/skia/FontCustomPlatformData.cpp: (WebCore::FontCustomPlatformData::fontPlatformData):
  • platform/network/chromium/CookieJarChromium.cpp: (WebCore::setCookies): (WebCore::cookies): (WebCore::cookieRequestHeaderFieldValue): (WebCore::cookiesEnabled): (WebCore::getRawCookies): (WebCore::deleteCookie):
  • platform/network/chromium/DNSChromium.cpp: (WebCore::prefetchDNS):
  • platform/qt/PlatformBridge.h:
  • platform/sql/chromium/SQLiteFileSystemChromium.cpp: (WebCore::SQLiteFileSystem::deleteDatabaseFile): (WebCore::SQLiteFileSystem::getDatabaseFileSize):
  • platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp: (chromiumOpen): (chromiumDelete): (chromiumAccess):
  • platform/sql/chromium/SQLiteFileSystemChromiumWin.cpp:
  • plugins/chromium/PluginDataChromium.cpp: (WebCore::PluginCache::plugins):
  • rendering/RenderThemeChromiumMac.mm: (WebCore::RenderThemeChromiumMac::usesTestModeFocusRingColor):
  • rendering/RenderThemeChromiumSkia.cpp: (WebCore::RenderThemeChromiumSkia::caretBlinkInterval):
  • rendering/RenderThemeChromiumWin.cpp: (WebCore::RenderThemeChromiumWin::platformActiveSelectionBackgroundColor): (WebCore::RenderThemeChromiumWin::platformInactiveSelectionBackgroundColor): (WebCore::RenderThemeChromiumWin::platformActiveSelectionForegroundColor): (WebCore::RenderThemeChromiumWin::systemColor): (WebCore::RenderThemeChromiumWin::paintButton): (WebCore::RenderThemeChromiumWin::paintSliderTrack): (WebCore::menuListButtonWidth): (WebCore::RenderThemeChromiumWin::paintMenuList): (WebCore::RenderThemeChromiumWin::paintTextFieldInternal): (WebCore::RenderThemeChromiumWin::paintInnerSpinButton): (WebCore::RenderThemeChromiumWin::paintProgressBar):
  • storage/chromium/IDBFactoryBackendInterface.cpp: (WebCore::IDBFactoryBackendInterface::create): (WebCore::IDBFactoryBackendInterface::~IDBFactoryBackendInterface):
  • storage/chromium/IDBKeyPathBackendImpl.cpp: (WebCore::IDBKeyPathBackendImpl::createIDBKeysFromSerializedValuesAndKeyPath):

2011-01-19 Adam Klein <adamk@chromium.org>

Reviewed by Darin Fisher.

[chromium] Rename ChromiumBridge to PlatformBridge
https://bugs.webkit.org/show_bug.cgi?id=52471

  • WebKit.gyp:
  • src/AssertMatchingEnums.cpp:
  • src/PlatformBridge.cpp: (WebCore::toChromeClientImpl): (WebCore::toWebWidgetClient): (WebCore::getCookieJar): (WebCore::PlatformBridge::cacheMetadata): (WebCore::PlatformBridge::clipboardIsFormatAvailable): (WebCore::PlatformBridge::clipboardReadPlainText): (WebCore::PlatformBridge::clipboardReadHTML): (WebCore::PlatformBridge::clipboardWriteSelection): (WebCore::PlatformBridge::clipboardWritePlainText): (WebCore::PlatformBridge::clipboardWriteURL): (WebCore::PlatformBridge::clipboardWriteImage): (WebCore::PlatformBridge::clipboardWriteData): (WebCore::PlatformBridge::clipboardReadAvailableTypes): (WebCore::PlatformBridge::clipboardReadData): (WebCore::PlatformBridge::clipboardReadFilenames): (WebCore::PlatformBridge::setCookies): (WebCore::PlatformBridge::cookies): (WebCore::PlatformBridge::cookieRequestHeaderFieldValue): (WebCore::PlatformBridge::rawCookies): (WebCore::PlatformBridge::deleteCookie): (WebCore::PlatformBridge::cookiesEnabled): (WebCore::PlatformBridge::prefetchDNS): (WebCore::PlatformBridge::fileExists): (WebCore::PlatformBridge::deleteFile): (WebCore::PlatformBridge::deleteEmptyDirectory): (WebCore::PlatformBridge::getFileSize): (WebCore::PlatformBridge::revealFolderInOS): (WebCore::PlatformBridge::getFileModificationTime): (WebCore::PlatformBridge::directoryName): (WebCore::PlatformBridge::pathByAppendingComponent): (WebCore::PlatformBridge::makeAllDirectories): (WebCore::PlatformBridge::getAbsolutePath): (WebCore::PlatformBridge::isDirectory): (WebCore::PlatformBridge::filePathToURL): (WebCore::PlatformBridge::openFile): (WebCore::PlatformBridge::closeFile): (WebCore::PlatformBridge::seekFile): (WebCore::PlatformBridge::truncateFile): (WebCore::PlatformBridge::readFromFile): (WebCore::PlatformBridge::writeToFile): (WebCore::PlatformBridge::ensureFontLoaded): (WebCore::PlatformBridge::getFontFamilyForCharacters): (WebCore::PlatformBridge::getRenderStyleForStrike): (WebCore::PlatformBridge::loadFont): (WebCore::PlatformBridge::databaseOpenFile): (WebCore::PlatformBridge::databaseDeleteFile): (WebCore::PlatformBridge::databaseGetFileAttributes): (WebCore::PlatformBridge::databaseGetFileSize): (WebCore::PlatformBridge::idbFactory): (WebCore::PlatformBridge::idbShutdown): (WebCore::PlatformBridge::createIDBKeysFromSerializedValuesAndKeyPath): (WebCore::PlatformBridge::signedPublicKeyAndChallengeString): (WebCore::PlatformBridge::computedDefaultLanguage): (WebCore::PlatformBridge::layoutTestMode): (WebCore::PlatformBridge::isSupportedImageMIMEType): (WebCore::PlatformBridge::isSupportedJavaScriptMIMEType): (WebCore::PlatformBridge::isSupportedNonImageMIMEType): (WebCore::PlatformBridge::mimeTypeForExtension): (WebCore::PlatformBridge::mimeTypeFromFile): (WebCore::PlatformBridge::preferredExtensionForMIMEType): (WebCore::PlatformBridge::plugins): (WebCore::PlatformBridge::pluginScriptableObject): (WebCore::PlatformBridge::loadPlatformImageResource): (WebCore::PlatformBridge::loadPlatformAudioResource): (WebCore::PlatformBridge::decodeAudioFileData): (WebCore::PlatformBridge::sandboxEnabled): (WebCore::PlatformBridge::setSharedTimerFiredFunction): (WebCore::PlatformBridge::setSharedTimerFireTime): (WebCore::PlatformBridge::stopSharedTimer): (WebCore::PlatformBridge::decrementStatsCounter): (WebCore::PlatformBridge::incrementStatsCounter): (WebCore::PlatformBridge::histogramCustomCounts): (WebCore::PlatformBridge::histogramEnumeration): (WebCore::PlatformBridge::suddenTerminationChanged): (WebCore::PlatformBridge::currentTime): (WebCore::PlatformBridge::paintButton): (WebCore::PlatformBridge::paintMenuList): (WebCore::PlatformBridge::paintScrollbarArrow): (WebCore::PlatformBridge::paintScrollbarThumb): (WebCore::PlatformBridge::paintScrollbarTrack): (WebCore::PlatformBridge::paintSpinButton): (WebCore::PlatformBridge::paintTextField): (WebCore::PlatformBridge::paintTrackbar): (WebCore::PlatformBridge::paintProgressBar): (WebCore::WebThemePart): (WebCore::WebThemeState): (WebCore::GetWebThemeExtraParams): (WebCore::PlatformBridge::getThemePartSize): (WebCore::PlatformBridge::paintThemePart): (WebCore::PlatformBridge::traceEventBegin): (WebCore::PlatformBridge::traceEventEnd): (WebCore::PlatformBridge::visitedLinkHash): (WebCore::PlatformBridge::isLinkVisited): (WebCore::PlatformBridge::notifyJSOutOfMemory): (WebCore::PlatformBridge::memoryUsageMB): (WebCore::PlatformBridge::actualMemoryUsageMB): (WebCore::PlatformBridge::screenDepth): (WebCore::PlatformBridge::screenDepthPerComponent): (WebCore::PlatformBridge::screenIsMonochrome): (WebCore::PlatformBridge::screenRect): (WebCore::PlatformBridge::screenAvailableRect): (WebCore::PlatformBridge::popupsAllowed): (WebCore::WorkerContextProxy::create):
  • src/ResourceHandle.cpp: (WebCore::ResourceHandle::cacheMetadata):
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::WebFrameImpl): (WebKit::WebFrameImpl::~WebFrameImpl):
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
8:24 PM Changeset in webkit [76202] by dimich@chromium.org
  • 3 edits
    5 deletes in trunk

2011-01-19 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r76187.
http://trac.webkit.org/changeset/76187
https://bugs.webkit.org/show_bug.cgi?id=52778

Broke caret-showing tests on SnowLeopard and Chromium
(Requested by dimich on #webkit).

  • editing/selection/caret-painting-in-overflowing-autowrap-content.html: Removed.
  • editing/selection/resources/iframe-positioning-caret-at-end.html: Removed.
  • platform/mac/editing/selection/caret-painting-in-overflowing-autowrap-content-expected.checksum: Removed.
  • platform/mac/editing/selection/caret-painting-in-overflowing-autowrap-content-expected.png: Removed.
  • platform/mac/editing/selection/caret-painting-in-overflowing-autowrap-content-expected.txt: Removed.

2011-01-19 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r76187.
http://trac.webkit.org/changeset/76187
https://bugs.webkit.org/show_bug.cgi?id=52778

Broke caret-showing tests on SnowLeopard and Chromium
(Requested by dimich on #webkit).

  • rendering/RenderText.cpp: (WebCore::RenderText::localCaretRect):
8:19 PM Changeset in webkit [76201] by yuzo@google.com
  • 3 edits
    2 adds in trunk

2011-01-19 Yuzo Fujishima <yuzo@google.com>

Reviewed by Kent Tamura.

Fix for Bug 52279 - WebCore::RenderBlock::updateFirstLetter crashes for anonymous blocks
https://bugs.webkit.org/show_bug.cgi?id=52279

  • fast/css/first-letter-anonymous-block-crash-expected.txt: Added.
  • fast/css/first-letter-anonymous-block-crash.html: Added.

2011-01-19 Yuzo Fujishima <yuzo@google.com>

Reviewed by Kent Tamura.

Fix for Bug 52279 - WebCore::RenderBlock::updateFirstLetter crashes for anonymous blocks
https://bugs.webkit.org/show_bug.cgi?id=52279

In constructing text fragments to handle first-letter rule, first add
the text for the non-first letters and then remove the original text,
rather than the other way around. Otherwise, the text can be added to
an anoymous block that is different from the original one. This breaks
the assumption that a first letter render object has a non-null sibling
for the non-first letters and causes a crash.

Test: fast/css/first-letter-anonymous-block-crash.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::updateFirstLetter):
8:17 PM Changeset in webkit [76200] by dpranke@chromium.org
  • 6 edits in trunk/Tools

2011-01-19 Dirk Pranke <dpranke@chromium.org>

Unreviewed, build fix - I pulled this patch in to fix an issue
revealed by r76195 running on some new bots). Also fix a couple
of other issues revealed in testing.

nrwt: remove fs refs from layout_package/json*

https://bugs.webkit.org/show_bug.cgi?id=52754

  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
7:55 PM Changeset in webkit [76199] by dpranke@chromium.org
  • 4 edits in trunk/Tools

2011-01-19 Dirk Pranke <dpranke@chromium.org>

Unreviewed, build fix.

Fix a couple of minor bugs discovered while bringing up new bots
for testing.

  • Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
7:52 PM Changeset in webkit [76198] by jamesr@google.com
  • 33 edits
    12 deletes in trunk

2011-01-19 James Robinson <jamesr@chromium.org>

Unreviewed, rolling out r76194.
http://trac.webkit.org/changeset/76194
https://bugs.webkit.org/show_bug.cgi?id=51218

Caused mysterious compile failure on the chromium win
build.webkit.org bots

  • fast/animation/request-animation-frame-cancel-expected.txt: Removed.
  • fast/animation/request-animation-frame-cancel.html: Removed.
  • fast/animation/request-animation-frame-cancel2-expected.txt: Removed.
  • fast/animation/request-animation-frame-cancel2.html: Removed.
  • fast/animation/request-animation-frame-display-expected.txt: Removed.
  • fast/animation/request-animation-frame-display.html: Removed.
  • fast/animation/request-animation-frame-expected.txt: Removed.
  • fast/animation/request-animation-frame-within-callback-expected.txt: Removed.
  • fast/animation/request-animation-frame-within-callback.html: Removed.
  • fast/animation/request-animation-frame.html: Removed.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:

2011-01-19 James Robinson <jamesr@chromium.org>

Unreviewed, rolling out r76194.
http://trac.webkit.org/changeset/76194
https://bugs.webkit.org/show_bug.cgi?id=51218

Caused mysterious compile failure on the chromium win
build.webkit.org bots

  • WebCore.gypi:
  • dom/Document.cpp: (WebCore::Document::Document):
  • dom/Document.h:
  • dom/RequestAnimationFrameCallback.h: Removed.
  • dom/RequestAnimationFrameCallback.idl: Removed.
  • loader/EmptyClients.h:
  • page/Chrome.cpp:
  • page/Chrome.h:
  • page/ChromeClient.h:
  • page/DOMWindow.cpp:
  • page/DOMWindow.h:
  • page/DOMWindow.idl:
  • page/FrameView.cpp:
  • page/FrameView.h:
  • platform/HostWindow.h:

2011-01-19 James Robinson <jamesr@chromium.org>

Unreviewed, rolling out r76194.
http://trac.webkit.org/changeset/76194
https://bugs.webkit.org/show_bug.cgi?id=51218

Caused mysterious compile failure on the chromium win
build.webkit.org bots

  • features.gypi:
  • public/WebWidget.h:
  • public/WebWidgetClient.h:
  • src/ChromeClientImpl.cpp:
  • src/ChromeClientImpl.h:
  • src/WebPopupMenuImpl.cpp:
  • src/WebPopupMenuImpl.h:
  • src/WebViewImpl.cpp:
  • src/WebViewImpl.h:

2011-01-19 James Robinson <jamesr@chromium.org>

Unreviewed, rolling out r76194.
http://trac.webkit.org/changeset/76194
https://bugs.webkit.org/show_bug.cgi?id=51218

Caused mysterious compile failure on the chromium win
build.webkit.org bots

  • DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::paintInvalidatedRegion):
  • DumpRenderTree/chromium/WebViewHost.h:
7:46 PM Changeset in webkit [76197] by simon.fraser@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-01-19 Simon Fraser <simon.fraser@apple.com>

Fix the WebKit2 build.

  • WebProcess/WebPage/mac/LayerBackedDrawingAreaMac.mm: (WebKit::LayerBackedDrawingArea::syncCompositingLayers):
7:20 PM Changeset in webkit [76196] by simon.fraser@apple.com
  • 12 edits in trunk/Source

2011-01-19 Simon Fraser <simon.fraser@apple.com>

Reviewed by Sam Weinig.

GraphicsLayers in subframes can get sync'd multiple times
https://bugs.webkit.org/show_bug.cgi?id=52489

Some cleanup that will work towards fixing this bug.

Tested by existing iframe compositing tests.

  • WebCore.exp.in: syncCompositingStateRecursive() was renamed to syncCompositingStateIncludingSubframes().
  • page/FrameView.h:
  • page/FrameView.cpp: (WebCore::FrameView::syncCompositingStateForThisFrame): Some code cleanup: do all the word we need to do for this frame, including the needsLayout() check. (WebCore::FrameView::syncCompositingStateIncludingSubframes): This is no longer recursive; instead, it iterates over descendant frames via the frame tree, calling syncCompositingStateForThisFrame() on each Frame's view.
  • rendering/RenderLayerCompositor.h: (WebCore::RenderLayerCompositor::isFlushingLayers): Getter for the flag.
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::RenderLayerCompositor): (WebCore::RenderLayerCompositor::flushPendingLayerChanges): Maintain a flag to say if we're flushing, which allows us to assert on re-entrant flushes. (WebCore::RenderLayerCompositor::enclosingCompositorFlushingLayers): Add the ability to get the rootmost compositor that is in the middle of a flush.
7:14 PM Changeset in webkit [76195] by dpranke@chromium.org
  • 5 edits in trunk/Tools

2011-01-19 Dirk Pranke <dpranke@chromium.org>

Reviewed by Mihai Parparita.

remove fs refs from test_runner, dump_render_tree_thread

https://bugs.webkit.org/show_bug.cgi?id=52753

  • Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
6:59 PM Changeset in webkit [76194] by jamesr@google.com
  • 33 edits
    13 adds in trunk

2011-01-19 James Robinson <jamesr@chromium.org>

Reviewed by Darin Fisher.

Implement mozilla's requestAnimationFrame API
https://bugs.webkit.org/show_bug.cgi?id=51218

Tests for window.webkitRequestAnimationFrame(). The new tests
are in the Skipped lists for platforms that do not set
ENABLE(REQUEST_ANIMATION_FRAME) - which is currently all but chromium.

  • fast/animation/request-animation-frame-cancel-expected.txt: Added.
  • fast/animation/request-animation-frame-cancel.html: Added.

Tests cancelling a callback within a webkitRequestAnimationFrame() callback.

  • fast/animation/request-animation-frame-cancel2-expected.txt: Added.
  • fast/animation/request-animation-frame-cancel2.html: Added.

Tests interactions between multiple webkitRequestAnimationFrame() callbacks.

  • fast/animation/request-animation-frame-display-expected.txt: Added.
  • fast/animation/request-animation-frame-display.html: Added.

Tests changing the display: property of an element within a callback.

  • fast/animation/request-animation-frame-expected.txt: Added.
  • fast/animation/request-animation-frame.html: Added.

Tests the basic use of window.webkitRequestAnimationFrame().

  • fast/animation/request-animation-frame-within-callback-expected.txt: Added.
  • fast/animation/request-animation-frame-within-callback.html: Added.

Tests setting one webkit.webkitRequestAnimationFrame() callback within another.

  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:

2011-01-19 James Robinson <jamesr@chromium.org>

Reviewed by Darin Fisher.

Implement mozilla's requestAnimationFrame API
https://bugs.webkit.org/show_bug.cgi?id=51218

This implements mozilla's proposed requestAnimationFrame API. The idea with this API is that
an author driving an animation from script could use window.requestAnimationFrame(callback)
instead of window.setTimeout(callback, 0) to schedule their update logic and let the browser
decide when to update the animations. This avoids doing unnecessary work when the page content
is offscreen or is being displayed at a different framerate than what the page author expects.

Mozilla's proposal is here: https://developer.mozilla.org/en/DOM/window.mozRequestAnimationFrame
This implements window.mozRequestAnimationFrame as window.webkitRequestAnimationFrame with the
following changes:
*) Only the callback syntax is supported, there is no before paint event
*) webkitRequestAnimationFrame supports a second parameter Element to let the author indicate

what content they intend to animate. That way if the page is being displayed but the element
in question is offscreen, we can avoid invoking the callback.

*) No timestamp is provided to the caller and there is no window.animationStartTime property

(see https://bugs.webkit.org/show_bug.cgi?id=51952 for discussion of this property)

*) window.webkitRequestAnimationFrame returns a numerical id that can be used to cancel the callback

using window.cancelWebkitRequestAnimationFrame, to parallel window.setTimeout()/window.clearTime().

The implementation depends on the embedder scheduling the callbacks since the callback invocation
depends on the page's visibility and the embedder's paint scheduling, neither of which are exposed
to WebCore. The expectation for the embedder is that at some point Chrome::scheduleAnimation() is
called FrameView::serviceScriptedAnimations() should be called for the associated Page's main frame.
Ideally serviceScriptedAnimations() would be called prior to rendering - although in practice the
embedder has to rate limit callbacks and may not be able to tie the callback directly to the
rendering loop.

Tests: fast/animation/request-animation-frame-cancel.html

fast/animation/request-animation-frame-cancel2.html
fast/animation/request-animation-frame-display.html
fast/animation/request-animation-frame-within-callback.html
fast/animation/request-animation-frame.html

  • WebCore.gypi:
  • dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::webkitRequestAnimationFrame): (WebCore::Document::webkitCancelRequestAnimationFrame): (WebCore::Document::serviceScriptedAnimations):
  • dom/Document.h:
  • dom/RequestAnimationFrameCallback.h: Added. (WebCore::RequestAnimationFrameCallback::~RequestAnimationFrameCallback):
  • dom/RequestAnimationFrameCallback.idl: Added.
  • loader/EmptyClients.h: (WebCore::EmptyChromeClient::scheduleAnimation):
  • page/Chrome.cpp: (WebCore::Chrome::scheduleAnimation):
  • page/Chrome.h:
  • page/ChromeClient.h:
  • page/DOMWindow.cpp: (WebCore::DOMWindow::webkitRequestAnimationFrame): (WebCore::DOMWindow::webkitCancelRequestAnimationFrame):
  • page/DOMWindow.h:
  • page/DOMWindow.idl:
  • page/FrameView.cpp: (WebCore::FrameView::scheduleAnimation): (WebCore::FrameView::serviceScriptedAnimations):
  • page/FrameView.h:
  • platform/HostWindow.h:

2011-01-19 James Robinson <jamesr@chromium.org>

Reviewed by Darin Fisher.

Implement mozilla's requestAnimationFrame API
https://bugs.webkit.org/show_bug.cgi?id=51218

Chromium WebKit API support for window.webkitRequestAnimationFrame()

  • features.gypi:
  • public/WebWidget.h:
  • public/WebWidgetClient.h: (WebKit::WebWidgetClient::scheduleAnimation):
  • src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::scheduleAnimation):
  • src/ChromeClientImpl.h:
  • src/WebPopupMenuImpl.cpp: (WebKit::WebPopupMenuImpl::animate): (WebKit::WebPopupMenuImpl::scheduleAnimation):
  • src/WebPopupMenuImpl.h:
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::animate):
  • src/WebViewImpl.h:

2011-01-19 James Robinson <jamesr@chromium.org>

Reviewed by Darin Fisher.

Implement mozilla's requestAnimationFrame API
https://bugs.webkit.org/show_bug.cgi?id=51218

Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.

  • DumpRenderTree/chromium/WebViewHost.cpp: (invokeScheduleComposite): (WebViewHost::scheduleAnimation): (WebViewHost::paintInvalidatedRegion):
  • DumpRenderTree/chromium/WebViewHost.h:
6:56 PM Changeset in webkit [76193] by ggaren@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Rolled back in r76078, with crash fixed.
https://bugs.webkit.org/show_bug.cgi?id=52668

Reviewed by Darin Adler.

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::markChildren): Account for the fact that the global
object moves its variables into and out of the register file. While out
of the register file, the symbol table's size is not an accurate count
for the size of the register array, since the BytecodeGenerator might
be compiling, adding items to the symbol table.

6:49 PM Changeset in webkit [76192] by mrobinson@webkit.org
  • 7 edits in trunk/Source/WebCore

2011-01-13 Martin Robinson <mrobinson@igalia.com>

Reviewed by Daniel Bates.

[GTK] Move progress bar painting out of gtk2drawing.c
https://bugs.webkit.org/show_bug.cgi?id=52385

Move progress bar painting to RenderThemeGtk2 and share some animation
logic between the GTK+ 2.x and GTK+ 3.x port.

No new tests. This should not change functionality.

  • platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::animationRepeatIntervalForProgressBar): Moved from RenderThemeGtk3. (WebCore::RenderThemeGtk::animationDurationForProgressBar): Ditto. (WebCore::RenderThemeGtk::calculateProgressRect): Calculate the proper rectangle for the progress indicator given the rect for the maximum size of the indicator.
  • platform/gtk/RenderThemeGtk.h: Added calculateProgressRect declaration and a new widget member for GTK+ 2.x
  • platform/gtk/RenderThemeGtk2.cpp: (WebCore::RenderThemeGtk::platformInit): Added initialization for the new widget member. (WebCore::RenderThemeGtk::paintProgressBar): Paint the progress bar manually instead of calling the old Mozilla code. (WebCore::RenderThemeGtk::gtkProgressBar): Added.
  • platform/gtk/RenderThemeGtk3.cpp: (WebCore::RenderThemeGtk::paintProgressBar): Call calculateProgressRect now to get the area of the progress indicator.
  • platform/gtk/gtk2drawing.c: Remove unused code. (moz_gtk_get_widget_border): (moz_gtk_widget_paint):
  • platform/gtk/gtkdrawing.h: Ditto.
6:18 PM Changeset in webkit [76191] by darin@apple.com
  • 6 edits in trunk/Source/WebKit/mac

2011-01-19 Darin Adler <darin@apple.com>

Reviewed by Sam Weinig.

Would like script debugging protocol method to differentiate between caught and uncaught exceptions
https://bugs.webkit.org/show_bug.cgi?id=52104
rdar://problem/8704226

  • WebView/WebDelegateImplementationCaching.h: Fix type of second integer in CallScriptDebugDelegate function overload to be int to match the actual Objective-C method. Added a new overload that includes a BOOL in the right place. Added a boolean named exceptionWasRaisedExpectsHasHandlerFlag.
  • WebView/WebDelegateImplementationCaching.mm: (CallDelegate): Added overloads as above. (CallScriptDebugDelegate): Ditto.
  • WebView/WebScriptDebugDelegate.h: Added new method with the additional boolean argument. Marked the old method informally deprecated.
  • WebView/WebScriptDebugger.mm: (WebScriptDebugger::exception): Added code to call with or without the boolean depending on exceptionWasRaisedExpectsHasHandlerFlag.
  • WebView/WebView.mm: (-[WebView _cacheScriptDebugDelegateImplementations]): Set up the exceptionWasRaisedExpectsHasHandlerFlag. Also fixed old code that was not guaranteed to set didParseSourceExpectsBaseLineNumber to NO.
6:16 PM Changeset in webkit [76190] by dpranke@chromium.org
  • 3 edits in trunk/Tools

2011-01-19 Dirk Pranke <dpranke@chromium.org>

Unreviewed, build fix.

Fix a few incorrect "self._filesystem" references introduced in
r76184.

  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:
6:13 PM Changeset in webkit [76189] by dimich@chromium.org
  • 22 edits in trunk

[Chromium] Not reviewed, reverts the following changes:
http://trac.webkit.org/changeset/76164 (build fix)
http://trac.webkit.org/changeset/76159 (main change)

The change broke Chromium Linux-shlib build.

Original issue:
Accelerated canvas2D has bad clipping performance.
https://bugs.webkit.org/show_bug.cgi?id=52627

Source/WebCore:

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::reset):
(WebCore::CanvasRenderingContext2D::platformLayer):

  • platform/graphics/chromium/DrawingBufferChromium.cpp:

(WebCore::DrawingBuffer::DrawingBuffer):

  • platform/graphics/chromium/GLES2Canvas.cpp:

(WebCore::GLES2Canvas::State::State):
(WebCore::GLES2Canvas::clearRect):
(WebCore::GLES2Canvas::fillRect):
(WebCore::GLES2Canvas::restore):
(WebCore::GLES2Canvas::drawTexturedRect):

  • platform/graphics/chromium/GLES2Canvas.h:
  • platform/graphics/gpu/DrawingBuffer.cpp:

(WebCore::DrawingBuffer::clear):
(WebCore::DrawingBuffer::createSecondaryBuffers):
(WebCore::DrawingBuffer::reset):

  • platform/graphics/gpu/DrawingBuffer.h:
  • platform/graphics/gpu/SharedGraphicsContext3D.cpp:

(WebCore::SharedGraphicsContext3D::create):

  • platform/graphics/gpu/SharedGraphicsContext3D.h:
  • platform/graphics/gpu/mac/DrawingBufferMac.mm:

(WebCore::DrawingBuffer::DrawingBuffer):

  • platform/graphics/skia/GraphicsContextSkia.cpp:

(WebCore::GraphicsContext::canvasClip):
(WebCore::GraphicsContext::clipOut):
(WebCore::GraphicsContext::clipPath):
(WebCore::GraphicsContext::fillPath):

  • platform/graphics/skia/PlatformContextSkia.cpp:

(WebCore::PlatformContextSkia::canAccelerate):
(WebCore::PlatformContextSkia::uploadSoftwareToHardware):

  • thirdparty/glu/README.webkit:
  • thirdparty/glu/gluos.h:
  • thirdparty/glu/libtess/geom.c:
  • thirdparty/glu/libtess/priorityq.c:
  • thirdparty/glu/libtess/render.c:
  • thirdparty/glu/libtess/sweep.c:

(IsWindingInside):
(DoneEdgeDict):

LayoutTests:

  • platform/chromium-gpu/test_expectations.txt:
6:10 PM Changeset in webkit [76188] by bweinstein@apple.com
  • 3 edits in trunk/Source/WebKit2

WebKit2: Need API to get the parent frame of a frame
https://bugs.webkit.org/show_bug.cgi?id=52774

Reviewed by Darin Adler.

Add the API to get the parent frame of a frame.

  • UIProcess/API/C/WKFrame.cpp:

(WKFrameGetParentFrame):

  • UIProcess/API/C/WKFrame.h:
6:03 PM Changeset in webkit [76187] by leviw@chromium.org
  • 3 edits
    1 copy
    4 adds in trunk

2011-01-19 Levi Weintraub <leviw@google.com>

Reviewed by Darin Adler.

Re-committing this with the proper expected results.

Changing RenderText::localCaretRect to clip to its containing block's logicalLeft and
logicalRightLayoutOverflow instead of simply using logicalLeft and logicalRight, as this
resulted in the caret being placed incorrectly in overflowing editable IFrame content.

Long lines in non-white-space-pre editable documents show cursor in wrong place
https://bugs.webkit.org/show_bug.cgi?id=48132

  • editing/selection/caret-painting-in-overflowing-autowrap-content.html: Added.
  • editing/selection/resources/iframe-positioning-caret-at-end.html: Added.
  • platform/mac/editing/selection/caret-painting-in-overflowing-autowrap-content-expected.checksum: Added.
  • platform/mac/editing/selection/caret-painting-in-overflowing-autowrap-content-expected.png: Added.
  • platform/mac/editing/selection/caret-painting-in-overflowing-autowrap-content-expected.txt: Added.

2011-01-19 Levi Weintraub <leviw@google.com>

Reviewed by Darin Adler.

Re-committing this with the proper expected results.

Changing RenderText::localCaretRect to clip to its containing block's logicalLeft and
logicalRightLayoutOverflow instead of simply using logicalLeft and logicalRight, as this
resulted in the caret being placed incorrectly in overflowing editable IFrame content.

Long lines in non-white-space-pre editable documents show cursor in wrong place
https://bugs.webkit.org/show_bug.cgi?id=48132

Test: editing/selection/caret-painting-in-overflowing-autowrap-content.html

  • rendering/RenderText.cpp: (WebCore::RenderText::localCaretRect):
5:56 PM Changeset in webkit [76186] by enrica@apple.com
  • 15 edits
    3 adds in trunk/Source/WebKit2

WebKit2: add support for drag and drop
https://bugs.webkit.org/show_bug.cgi?id=52343
<rdar://problem/7660558>

Reviewed by Darin Adler.

This patch contains the remaining work to support drag and drop on Mac.
I've added a PasteboardTypes class to encapsulate all the pasteboard formats
supported for drag and drop.
In this implementation we don't support the promised types, since I could not
find an efficient way to do this across processes.
The bulk of the patch consists in creating a shareable bitmap for the drag image,
pass its handle to the UI process and create a new NSImage from it to be given to
AppKit for dragging.
I've added the missing implementation of the methods in the drag client to hook
up the placement of the data in the pasteboard.

  • Shared/mac/PasteboardTypes.h: Added.
  • Shared/mac/PasteboardTypes.mm: Added.

(WebKit::PasteboardTypes::forEditing):
(WebKit::PasteboardTypes::forURL):
(WebKit::PasteboardTypes::forImages):
(WebKit::PasteboardTypes::forImagesWithArchive):

  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::setDragImage): Added.

  • UIProcess/API/mac/WKView.mm:

(-[WKView _registerDraggedTypes]): Refactored to use the new PasteboardTypes class.
(-[WKView initWithFrame:contextRef:pageGroupRef:]):
(-[WKView _setMouseDownEvent:]):
(-[WKView _mouseHandler:]):
(-[WKView mouseDown:]):
(-[WKView mouseUp:]):
(-[WKView mouseDragged:]):
(-[WKView draggedImage:endedAt:operation:]):
(-[WKView draggingEntered:]):
(-[WKView _setDragImage:at:linkDrag:]):

  • UIProcess/API/mac/WKViewInternal.h:
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::setDragImage):
(WebKit::WebPageProxy::dragEnded):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebCoreSupport/WebDragClient.cpp:
  • WebProcess/WebCoreSupport/WebDragClient.h:
  • WebProcess/WebCoreSupport/mac/WebDragClientMac.mm: Added.

(WebKit::fontFromNSFont):
(WebKit::WebDragClient::startDrag): Added implementation.
(WebKit::WebDragClient::createDragImageForLink): Ditto.
(WebKit::writeURL): Helper function.
(WebKit::writeImage): Helper function.
(WebKit::WebDragClient::declareAndWriteDragImage): Added implementation.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::dragEnded):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
5:53 PM Changeset in webkit [76185] by darin@apple.com
  • 13 edits
    5 adds in trunk

2011-01-18 Darin Adler <darin@apple.com>

Reviewed by Geoffrey Garen.

Stack overflow when converting an Error object to string
https://bugs.webkit.org/show_bug.cgi?id=46410

  • fast/js/script-tests/toString-recursion.js: Added.
  • fast/js/toString-recursion-expected.txt: Added.
  • fast/js/toString-recursion.html: Added.

2011-01-18 Darin Adler <darin@apple.com>

Reviewed by Geoffrey Garen.

Stack overflow when converting an Error object to string
https://bugs.webkit.org/show_bug.cgi?id=46410

  • Android.mk: Added StringRecursionChecker.cpp and StringRecursionChecker.h.
  • CMakeLists.txt: Ditto.
  • GNUmakefile.am: Ditto.
  • JavaScriptCore.gypi: Ditto.
  • JavaScriptCore.pro: Ditto.
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Ditto.
  • JavaScriptCore.xcodeproj/project.pbxproj: Ditto.
  • runtime/ArrayPrototype.cpp: (JSC::arrayProtoFuncToString): Use StringRecursionChecker instead of the older hand-written code to do the same thing. (JSC::arrayProtoFuncToLocaleString): Ditto. (JSC::arrayProtoFuncJoin): Ditto.
  • runtime/ErrorPrototype.cpp: (JSC::errorProtoFuncToString): Use StringRecursionChecker.
  • runtime/JSGlobalData.h: Renamed arrayVisitedElements to stringRecursionCheckVisitedObjects.
  • runtime/RegExpPrototype.cpp: (JSC::regExpProtoFuncToString): Use StringRecursionChecker.
  • runtime/StringRecursionChecker.cpp: Added.
  • runtime/StringRecursionChecker.h: Added.
5:49 PM Changeset in webkit [76184] by dpranke@chromium.org
  • 11 edits in trunk/Tools

2011-01-19 Dirk Pranke <dpranke@chromium.org>

Reviewed by Mihai Parparita.

add a .sep property, abspath(), isabs(), mtime(), and
open_text_file_for_writing() to filesystem modules. Some of
these properties are not needed in this patch but will be needed
in subsequent patches (I'm doing this to avoid having to track
multiple versions of a single file).

Also, change most of the port/* modules to use the filesystem
objects instead of referencing the filesystem directly.

https://bugs.webkit.org/show_bug.cgi?id=52748

  • Scripts/webkitpy/common/system/filesystem.py:
  • Scripts/webkitpy/common/system/filesystem_mock.py:
  • Scripts/webkitpy/layout_tests/port/init.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/base_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  • Scripts/webkitpy/layout_tests/port/config.py:
  • Scripts/webkitpy/layout_tests/port/test.py:
  • Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
5:24 PM Changeset in webkit [76183] by morrita@google.com
  • 3 edits in trunk/Source/WebCore

2011-01-18 MORITA Hajime <morrita@google.com>

Reviewed by David Levin.

ElementRareData::m_shadowRoot should not be RefPtr.
https://bugs.webkit.org/show_bug.cgi?id=51914

Makes ElementRareData::m_shadowRoot a raw pointer because
ElementRareData::m_shadowRoot should be like a
ContaineNode::m_firstChild, which is also a raw pointer.
pointer. Which also means that both the shadow root and the shadow
host reference each other as a parent-and-child relationship, via
a raw pointer.

Note that it is safe not to manipulate the ref-count of
m_shadowRoot because Node::m_parent of the shadow root points its
shadow host, and the object isn't deleted even if the refcount is
zero, as long as the node has non-null m_parent. (See TreeShared.)

The shadow root node is finally destroyed inside
removeShadowRoot(), where we store the root node into a local
RefPtr, then make the node's m_parent null, which results the
destroy the node, at the end of the function, by RefPtr::~RefPtr.

No new tests. No behavioral change.

  • dom/Element.cpp: (WebCore::Element::~Element): (WebCore::Element::shadowRoot): (WebCore::Element::setShadowRoot): (WebCore::Element::removeShadowRoot):
  • dom/ElementRareData.h: (WebCore::ElementRareData::ElementRareData): (WebCore::ElementRareData::~ElementRareData):
5:03 PM Changeset in webkit [76182] by mrobinson@webkit.org
  • 6 edits in trunk/Source/WebCore

2011-01-12 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] Move text field painting out of gtk2drawing.c
https://bugs.webkit.org/show_bug.cgi?id=52327

No new tests. This should not change behavior.

  • platform/gtk/RenderThemeGtk2.cpp: (WebCore::RenderThemeGtk::paintButton): Use the setWidgetHasFocus helper. (WebCore::RenderThemeGtk::paintTextField): Do this manually now instead of calling into the Mozilla code.
  • platform/gtk/WidgetRenderingContext.cpp: Added a couple more wrappers for GTK+ theme functions. (WebCore::WidgetRenderingContext::gtkPaintFlatBox): (WebCore::WidgetRenderingContext::gtkPaintShadow):
  • platform/gtk/WidgetRenderingContext.h: Added new method declarations.
  • platform/gtk/gtk2drawing.c: Remove unused code. (moz_gtk_get_widget_border): (moz_gtk_widget_paint):
  • platform/gtk/gtkdrawing.h:
4:40 PM Changeset in webkit [76181] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-01-19 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Put the deprecated Connection member functions next to eachother
https://bugs.webkit.org/show_bug.cgi?id=52767

  • Platform/CoreIPC/Connection.h: (CoreIPC::Connection::sendSync): (CoreIPC::Connection::send):
4:35 PM Changeset in webkit [76180] by oliver@apple.com
  • 13 edits in trunk

2011-01-19 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

Remove non-spec support for callable RegExp
https://bugs.webkit.org/show_bug.cgi?id=28285

Update test results for new behaviour.

  • fast/js/sputnik/Conformance/11_Expressions/11.4_Unary_Operators/11.4.3_The_typeof_Operator/S11.4.3_A3.6-expected.txt:
  • fast/js/sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.7/S15.10.7_A1_T1-expected.txt:
  • fast/js/sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.7/S15.10.7_A1_T2-expected.txt:
  • fast/js/sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.7/S15.10.7_A3_T1-expected.txt:
  • fast/js/sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.7/S15.10.7_A3_T2-expected.txt:
  • fast/loader/stateobjects/pushstate-object-types-expected.txt:
  • fast/regex/cross-frame-callable-expected.txt:
  • fast/regex/script-tests/cross-frame-callable.js: (doTest):

2011-01-19 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

Remove non-spec support for callable RegExp
https://bugs.webkit.org/show_bug.cgi?id=28285

Remove support for callable regexps. If it breaks sites we can
just roll this out.

  • runtime/RegExpObject.cpp:
  • runtime/RegExpObject.h:
  • tests/mozilla/expected.html: update results.
4:27 PM Changeset in webkit [76179] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-01-19 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

When resizing, the web process should repaint the page
https://bugs.webkit.org/show_bug.cgi?id=52764

  • UIProcess/DrawingAreaProxyImpl.cpp: (WebKit::DrawingAreaProxyImpl::didSetSize): Incorporate the update.

(WebKit::DrawingAreaProxyImpl::incorporateUpdate):
Return early if the update bounds rect is empty. This can happen if painting is
disabled and we get a DidSetSize message.

  • WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::setSize): If painting is disabled, just send back an empty UpdateInfo struct. Otherwise, paint and fill in the UpdateInfo struct.

(WebKit::DrawingAreaImpl::display):
Assert that painting is not disabled.

4:13 PM Changeset in webkit [76178] by mjs@apple.com
  • 2 edits in trunk/Tools

2011-01-19 Maciej Stachowiak <mjs@apple.com>

Reviewed by Anders Carlsson.

If resetting between tests times out, treat it as a WebProcess crash
https://bugs.webkit.org/show_bug.cgi?id=52757

  • WebKitTestRunner/TestController.cpp: (WTR::TestController::runTest):
4:13 PM Changeset in webkit [76177] by Antti Koivisto
  • 11 edits in trunk/Source

Cache function offsets to speed up javascript parsing
https://bugs.webkit.org/show_bug.cgi?id=52622

Reviewed by Oliver Hunt.

Use cache to save function offsets and some other info.
This avoids quite a bit of work when reparsing the source.

Source/JavaScriptCore:

  • parser/ASTBuilder.h:
  • parser/JSParser.cpp:

(JSC::JSParser::CachedFunctionInfo::CachedFunctionInfo):
(JSC::JSParser::CachedFunctionInfo::approximateByteSize):
(JSC::JSParser::CachedFunctionInfo::closeBraceToken):
(JSC::JSParser::Scope::copyCapturedVariablesToVector):
(JSC::JSParser::Scope::saveFunctionInfo):
(JSC::JSParser::Scope::restoreFunctionInfo):
(JSC::JSParser::findCachedFunctionInfo):
(JSC::JSParser::JSParser):
(JSC::JSParser::parseProgram):
(JSC::JSParser::parseFunctionInfo):

  • parser/Lexer.h:

(JSC::Lexer::setOffset):
(JSC::Lexer::setLineNumber):
(JSC::Lexer::sourceProvider):

  • parser/SourceProvider.h:

(JSC::SourceProviderCache::SourceProviderCache):
(JSC::SourceProviderCache::~SourceProviderCache):
(JSC::SourceProviderCache::byteSize):
(JSC::SourceProviderCache::add):
(JSC::SourceProviderCache::get):
(JSC::SourceProvider::SourceProvider):
(JSC::SourceProvider::~SourceProvider):
(JSC::SourceProvider::cache):
(JSC::SourceProvider::notifyCacheSizeChanged):
(JSC::SourceProvider::cacheSizeChanged):

  • parser/SyntaxChecker.h:

Source/WebCore:

  • bindings/js/CachedScriptSourceProvider.h:

(WebCore::CachedScriptSourceProvider::cache):
(WebCore::CachedScriptSourceProvider::cacheSizeChanged):
(WebCore::CachedScriptSourceProvider::CachedScriptSourceProvider):

  • bindings/js/ScriptSourceProvider.h:

(WebCore::ScriptSourceProvider::ScriptSourceProvider):

  • loader/cache/CachedScript.cpp:

(WebCore::CachedScript::destroyDecodedData):
(WebCore::CachedScript::sourceProviderCache):
(WebCore::CachedScript::sourceProviderCacheSizeChanged):

  • loader/cache/CachedScript.h:
4:01 PM Changeset in webkit [76176] by mrowe@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Follow-up to r75766 / <rdar://problem/5469576>.

Reviewed by Darin Adler.

  • DerivedSources.make: Evaluate the SDKROOT variable correctly.
3:45 PM Changeset in webkit [76175] by mrobinson@webkit.org
  • 24 edits in trunk

2011-01-11 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] Move toggle button rendering out of gtk2drawing.c
https://bugs.webkit.org/show_bug.cgi?id=52258

Updated results. The metrics of checkboxes and radio buttons have changed,
because the focus rect is no longer considered to be part of the button.

  • platform/gtk/fast/css/non-standard-checkbox-size-expected.txt
  • platform/gtk/fast/forms/001-expected.txt:
  • platform/gtk/fast/forms/basic-inputs-expected.txt:
  • platform/gtk/fast/forms/box-shadow-override-expected.txt:
  • platform/gtk/fast/forms/checkbox-radio-onchange-expected.txt:
  • platform/gtk/fast/forms/file-input-disabled-expected.txt:
  • platform/gtk/fast/forms/form-element-geometry-expected.txt:
  • platform/gtk/fast/forms/formmove-expected.txt:
  • platform/gtk/fast/forms/formmove2-expected.txt:
  • platform/gtk/fast/forms/indeterminate-expected.txt:
  • platform/gtk/fast/forms/input-appearance-height-expected.txt:
  • platform/gtk/fast/forms/input-value-expected.txt:
  • platform/gtk/fast/forms/radio-attr-order-expected.txt:
  • platform/gtk/fast/forms/radio-nested-labels-expected.txt:
  • platform/gtk/fast/forms/radio_checked-expected.txt:
  • platform/gtk/fast/forms/radio_checked_dynamic-expected.txt:

2011-01-11 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] Move toggle button rendering out of gtk2drawing.c
https://bugs.webkit.org/show_bug.cgi?id=52258

  • platform/gtk/RenderThemeGtk.h:
  • platform/gtk/RenderThemeGtk2.cpp: (WebCore::RenderThemeGtk::platformInit): Initialize new button members. (WebCore::adjustRectForFocus): Added this function which inflates a rect based on a widget's exterior focus. (WebCore::RenderThemeGtk::adjustRepaintRect): Account for exterior focus. (WebCore::setToggleSize): Only listen to indicator-size to properly size checkboxes and radio buttons. (WebCore::RenderThemeGtk::setCheckboxSize): Call new setToggleSize properly. (WebCore::paintToggle): Added. (WebCore::RenderThemeGtk::paintCheckbox): Call paintToggle. (WebCore::RenderThemeGtk::setRadioSize): Call new setToggleSize properly. (WebCore::RenderThemeGtk::paintRadio): Call paintToggle. (WebCore::RenderThemeGtk::gtkRadioButton): Added. (WebCore::RenderThemeGtk::gtkCheckButton): Added.
  • platform/gtk/WidgetRenderingContext.cpp: (WebCore::WidgetRenderingContext::WidgetRenderingContext): Use a static extra space variable. This is good enough for all themes that I've tested and prevents having to pass information from RenderThemeGtk about every single type of widget. (WebCore::WidgetRenderingContext::gtkPaintFocus): Use the paintRect to draw instead of m_paintRect. This is important when we're painting something that isn't the size of the total rect. (WebCore::WidgetRenderingContext::gtkPaintCheck): Added. (WebCore::WidgetRenderingContext::gtkPaintOption): Added.
  • platform/gtk/WidgetRenderingContext.h: Updated to reflect new methods.
  • platform/gtk/gtkdrawing.h: Remove newly unused code.
  • platform/gtk/gtk2drawing.c: Ditto.
3:38 PM Changeset in webkit [76174] by tonyg@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-01-19 Tony Gentilcore <tonyg@chromium.org>

Unreviewed build fix.

Build fix for r76170
https://bugs.webkit.org/show_bug.cgi?id=52758

  • platform/graphics/chromium/UniscribeHelperTextRun.cpp:
3:23 PM Changeset in webkit [76173] by ddkilzer@apple.com
  • 4 edits in trunk/Source/WebCore

<http://webkit.org/b/52687> Clean up FrameLoader methods for PLUGIN_PROXY_FOR_VIDEO

Reviewed by Eric Carlson.

  • loader/FrameLoader.cpp: Declare the methods here.

(WebCore::FrameLoader::hideMediaPlayerProxyPlugin):
(WebCore::FrameLoader::showMediaPlayerProxyPlugin):

  • loader/FrameLoader.cpp: Moved methods to here...

(WebCore::FrameLoader::hideMediaPlayerProxyPlugin):
(WebCore::FrameLoader::showMediaPlayerProxyPlugin):

  • loader/SubframeLoader.cpp: ...from here.

(WebCore::FrameLoader::hideMediaPlayerProxyPlugin):
(WebCore::FrameLoader::showMediaPlayerProxyPlugin):

3:21 PM Changeset in webkit [76172] by mrobinson@webkit.org
  • 2 edits in trunk/LayoutTests

2011-01-19 Martin Robinson <mrobinson@igalia.com>

Unskip a test now that the 32-bit debug bot has the 2.4 series of FreeType.

  • platform/gtk/Skipped: Unskip a test.
3:19 PM Changeset in webkit [76171] by commit-queue@webkit.org
  • 2 edits
    1 add in trunk/LayoutTests

2011-01-19 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r76166.
http://trac.webkit.org/changeset/76166
https://bugs.webkit.org/show_bug.cgi?id=52755

The platform-specific baseline should not be removed yet.
(Requested by dglazkov on #webkit).

  • platform/chromium-win/fast/forms/slider-mouse-events-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
3:13 PM Changeset in webkit [76170] by tonyg@chromium.org
  • 52 edits in trunk/Source

2011-01-19 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Mihai Parparita.

Perform some forward declaration
https://bugs.webkit.org/show_bug.cgi?id=52522

No new tests because no new functionality.

  • accessibility/AccessibilityObject.h:
  • css/WebKitCSSMatrix.cpp:
  • html/HTMLAreaElement.cpp:
  • html/canvas/CanvasRenderingContext2D.cpp:
  • inspector/InspectorController.cpp:
  • platform/graphics/FloatPoint.cpp:
  • platform/graphics/Font.cpp:
  • platform/graphics/Font.h:
  • platform/graphics/FontFastPath.cpp:
  • platform/graphics/GraphicsContext.cpp:
  • platform/graphics/ImageBuffer.h:
  • platform/graphics/StringTruncator.cpp:
  • platform/graphics/WidthIterator.cpp:
  • platform/graphics/mac/ComplexTextController.cpp:
  • platform/graphics/mac/ComplexTextControllerCoreText.cpp:
  • platform/graphics/mac/FontComplexTextMac.cpp:
  • platform/graphics/transforms/TransformationMatrix.cpp:
  • platform/graphics/transforms/TransformationMatrix.h:
  • rendering/EllipsisBox.cpp:
  • rendering/InlineTextBox.cpp:
  • rendering/RenderBlock.cpp:
  • rendering/RenderBlockLineLayout.cpp:
  • rendering/RenderEmbeddedObject.cpp:
  • rendering/RenderFileUploadControl.cpp:
  • rendering/RenderFlexibleBox.cpp:
  • rendering/RenderImage.cpp:
  • rendering/RenderListBox.cpp:
  • rendering/RenderListMarker.cpp:
  • rendering/RenderMenuList.cpp:
  • rendering/RenderObject.h:
  • rendering/RenderText.cpp:
  • rendering/RenderTextControl.cpp:
  • rendering/svg/SVGInlineTextBox.cpp:
  • rendering/svg/SVGMarkerLayoutInfo.h:
  • rendering/svg/SVGTextMetrics.cpp:
  • svg/SVGFont.cpp:

2011-01-19 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Mihai Parparita.

Perform some forward declaration
https://bugs.webkit.org/show_bug.cgi?id=52522

  • Misc/WebKitNSStringExtras.mm:
3:12 PM Changeset in webkit [76169] by mjs@apple.com
  • 2 edits
    3 adds in trunk/LayoutTests

2011-01-19 Maciej Stachowiak <mjs@apple.com>

Reviewed by Anders Carlsson.

Skip/fix remaining WebKit2 test failures
https://bugs.webkit.org/show_bug.cgi?id=52744

  • platform/mac-wk2/fast/blockflow/Kusa-Makura-background-canvas-expected.txt: Added WebKit2 mac results. It turns out that WebKit1 on Mac is the only port to report a scroll position other than 0, 0 for this test, so the WebKit2 results are arguably more correct.
  • platform/mac-wk2/fast/blockflow: Added.
  • platform/mac-wk2/fast: Added.
  • platform/mac-wk2/Skipped: Skip a few more tests. (And unskip in some cases where the failures were caused by other tests.)
2:53 PM Changeset in webkit [76168] by dimich@chromium.org
  • 3 edits in trunk/LayoutTests

2011-01-19 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r76152.
http://trac.webkit.org/changeset/76152
https://bugs.webkit.org/show_bug.cgi?id=52750

The original change (76144) was rolled out before (Requested
by dimich on #webkit).

  • platform/gtk/fast/forms/input-text-scroll-left-on-blur-expected.txt:
  • platform/gtk/fast/forms/plaintext-mode-2-expected.txt:
2:45 PM Changeset in webkit [76167] by ap@apple.com
  • 11 edits in trunk

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=52739
Make it possible for a WebKit2 client to print headers and footers

  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::headerHeight): (WebKit::WebPageProxy::footerHeight): (WebKit::WebPageProxy::drawHeader): (WebKit::WebPageProxy::drawFooter):
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebUIClient.cpp: (WebKit::WebUIClient::headerHeight): (WebKit::WebUIClient::footerHeight): (WebKit::WebUIClient::drawHeader): (WebKit::WebUIClient::drawFooter):
  • UIProcess/WebUIClient.h: Pass UIClient calls through.
  • UIProcess/API/mac/WKView.mm: (currentPrintOperationScale): A helper to extract scale factor from the current NSPrintOperation. (-[WKView _adjustPrintingMarginsForHeaderAndFooter]): Copied from WebKit1. Change current print info to account for header and footer height as provided by the client. (-[WKView knowsPageRange:]): Call -[self _adjustPrintingMarginsForHeaderAndFooter]. (-[WKView drawPageBorderWithSize:]): When AppKit asks to print page border, call the client to do that. Code adapted form WebKit1.
  • UIProcess/API/qt/qwkpage: (QWKPage::QWKPage): Added zeroes for new WKPageUIClient members to avoid breaking the build.
2:45 PM Changeset in webkit [76166] by Dimitri Glazkov
  • 2 edits
    1 delete in trunk/LayoutTests

2011-01-19 Dimitri Glazkov <Dimitri Glazkov>

Removed platform-specific expectations for the test that matches
generic baseline after http://trac.webkit.org/changeset/76147.

  • platform/chromium-win/fast/forms/slider-mouse-events-expected.txt: Removed.
  • platform/chromium/test_expectations.txt: Removed expectation to fail.
2:29 PM Changeset in webkit [76165] by enne@google.com
  • 4 edits in trunk/Source/WebCore

2011-01-19 Adrienne Walker <enne@google.com>

Reviewed by Kenneth Russell.

[chromium] Tiled compositor should use texture manager
https://bugs.webkit.org/show_bug.cgi?id=52418

Test: compositing/

  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::~LayerRendererChromium): (WebCore::LayerRendererChromium::cleanupSharedObjects):
  • platform/graphics/chromium/LayerTilerChromium.cpp: (WebCore::LayerTilerChromium::LayerTilerChromium): (WebCore::LayerTilerChromium::reset): (WebCore::LayerTilerChromium::createTile): (WebCore::LayerTilerChromium::update): (WebCore::LayerTilerChromium::draw):
  • platform/graphics/chromium/LayerTilerChromium.h: (WebCore::LayerTilerChromium::Tile::Tile): (WebCore::LayerTilerChromium::Tile::texture):
2:28 PM Changeset in webkit [76164] by senorblanco@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-01-19 Stephen White <senorblanco@chromium.org>

Unreviewed; build fix for chromium.

  • platform/graphics/chromium/GLES2Canvas.cpp: (WebCore::GLES2Canvas::fillPath):
2:26 PM Changeset in webkit [76163] by jberlin@webkit.org
  • 5 edits in trunk/Source/WebKit2

Crash in WebDatabaseManagerProxy::getDatabaseOrigins when called after the WebProcess has
died at least once
https://bugs.webkit.org/show_bug.cgi?id=52730

Reviewed by Darin Adler.

WebDatabaseManagerProxy::invalidate was setting m_webContext to 0, and invalidate gets
called in WebContext::processDidClose. However, m_webContext is only set in the
constructor, which is only called from the constructor of WebContext, so attempting to send
a message to any new WebProcess after the first one died was causing a null deref.

This patch moves setting m_webcontext into clearContext and clearContext is only called in
the WebContext destructor.

This patch also adds checks for a valid WebProcessProxy before attempting to send messages to
the WebProcessProxy so that if the WebProcess has died and has not been revived, it does not
attempt to dereference a null WebProcessProxy.

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::~WebContext):
Call WebDatabaseManagerProxy::clearContext.

  • UIProcess/WebContext.h:

(WebKit::WebContext::hasValidProcess):
Make this method public so that it can be called from WebDatabaseManagerProxy.

  • UIProcess/WebDatabaseManagerProxy.cpp:

(WebKit::WebDatabaseManagerProxy::getDatabasesByOrigin):
If there isn't a valid process, invalidate the callback and return early.
(WebKit::WebDatabaseManagerProxy::getDatabaseOrigins):
Ditto.
(WebKit::WebDatabaseManagerProxy::deleteDatabaseWithNameForOrigin):
If tehre isn't a valid process return early.
(WebKit::WebDatabaseManagerProxy::deleteDatabasesForOrigin):
Ditto.
(WebKit::WebDatabaseManagerProxy::deleteAllDatabases):
Ditto.
(WebKit::WebDatabaseManagerProxy::setQuotaForOrigin):
Ditto.
(WebKit::WebDatabaseManagerProxy::invalidate):
Move setting m_webContext to 0 from here ...

  • UIProcess/WebDatabaseManagerProxy.h:

(WebKit::WebDatabaseManagerProxy::clearContext):
... to here.

2:17 PM Changeset in webkit [76162] by tony@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-01-19 Tony Chang <tony@chromium.org>

Unreviewed, roll chromium deps to pick up fixes for the linux build.

  • DEPS:
2:14 PM Changeset in webkit [76161] by robert@webkit.org
  • 3 edits in trunk/LayoutTests

2011-01-19 Robert Hogan <robert@webkit.org>

Unreviewed fix to r76153.

[Qt] Update expected results after r76153

Update missing expected results from r76153. Matches Mac.
Re-skip http/tests/misc/timer-vs-loading.html - it still times
out on the build bot.

https://bugs.webkit.org/show_bug.cgi?id=52395

  • platform/qt/Skipped:
  • platform/qt/http/tests/loading/simple-subframe-expected.txt:
2:12 PM Changeset in webkit [76160] by dpranke@chromium.org
  • 2 edits in trunk/Tools

2011-01-19 Dirk Pranke <dpranke@chromium.org>

Reviewed by Ojan Vafai.

Change webkitpy/layout_tests/port/test.py to use the
in-memory filesystem for cleaner unit testing. This
change allows us to kill a lot of code that was
specific to the test port, at the cost of being a
little less clear about how things would work if
you didn't have a filesystem.

https://bugs.webkit.org/show_bug.cgi?id=52605

  • Scripts/webkitpy/layout_tests/port/test.py:
2:11 PM Changeset in webkit [76159] by senorblanco@chromium.org
  • 22 edits in trunk

2011-01-18 Stephen White <senorblanco@chromium.org>

Reviewed by James Robinson.

Add two to-be-rebaselined tests for the GPU path.

  • platform/chromium-gpu/test_expectations.txt:

2011-01-18 Stephen White <senorblanco@chromium.org>

Reviewed by James Robinson.

Implement accelerated path drawing and clipping for the Canvas2D GPU
path.
https://bugs.webkit.org/show_bug.cgi?id=52627


This is done with a simple curve interpolator and the GLU tesselator,
which is good enough for a 3-5X speedup on
http://ie.microsoft.com/testdrive/Performance/Galactic/Default.html.

Covered by canvas/philip/2d.path.clip.basic.html, and many, many more.
All tests canvas/philip and fast/canvas paths pass with no
regressions, although two have minor pixel differences which require
rebaselining.

  • WebCore.gyp/WebCore.gyp: Add internal_glu include path to chromium build.
  • WebCore.gypi: Add internal_glu files to chromium build.
  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::reset): (WebCore::CanvasRenderingContext2D::platformLayer): Make CanvasRenderingContext2D more robust against failure to create a DrawingBuffer.
  • platform/graphics/chromium/DrawingBufferChromium.cpp: (WebCore::DrawingBuffer::DrawingBuffer): As in DrawingBufferMac.cpp, call reset() from the constructor. Also initialize size to (-1, -1), so reset() doesn't early-out. Add initializers for depthBuffer and stencilBuffer, and remove multisampleDepthStencilBuffer.
  • platform/graphics/chromium/GLES2Canvas.cpp: Remove some unused #includes. (WebCore::GLES2Canvas::State::State): Add clipping state, and implement save/restore via the copy constructor. (WebCore::operator*): (WebCore::Quadratic::Quadratic): (WebCore::Quadratic::fromBezier): (WebCore::Quadratic::evaluate): Quadratic Bezier curve class. (WebCore::Cubic::Cubic): (WebCore::Cubic::fromBezier): (WebCore::Cubic::evaluate): Cubic Bezier curve class. (WebCore::GLES2Canvas::clearRect): Add clipping support to clearRect(). (WebCore::GLES2Canvas::fillPath): Implement fillPath(). (WebCore::GLES2Canvas::fillRect): Add clipping support to fillRect(). (WebCore::GLES2Canvas::clipPath): Implement clipPath(). (WebCore::GLES2Canvas::clipOut): Stub out clipOut() (not called by Canvas 2D). (WebCore::GLES2Canvas::restore): When restoring, draw any remaining clipping paths to the stencil buffer. (WebCore::GLES2Canvas::drawTexturedRect): Add clipping support. (WebCore::interpolateQuadratic): (WebCore::interpolateCubic): Simple curve interpolation, using the Cubic and Quadratic classes. (WebCore::PolygonData::PolygonData): A struct to hold the tesselation data for callbacks. (WebCore::beginData): (WebCore::edgeFlagData): (WebCore::vertexData): (WebCore::endData): (WebCore::combineData): internal_glu tesselation callbacks. (WebCore::GLES2Canvas::createVertexBufferFromPath): Build an interpolated, tesselated vertex buffer and element array buffer from a given path, suitable for filling. (WebCore::GLES2Canvas::beginStencilDraw): Enable stencilling, and disable draws to the color buffer. (WebCore::GLES2Canvas::applyClipping): If clipping is enabled, set the appropriate GL state.
  • platform/graphics/chromium/GLES2Canvas.h: Document the flavours of drawTexturedRect() a bit, so I don't get confused.
  • platform/graphics/gpu/DrawingBuffer.cpp: (WebCore::DrawingBuffer::clear): (WebCore::DrawingBuffer::createSecondaryBuffers): (WebCore::DrawingBuffer::resizeDepthStencil): (WebCore::DrawingBuffer::reset):
  • platform/graphics/gpu/DrawingBuffer.h: Unify m_multisampleDepthStencilBuffer with m_depthStencilBuffer. Implement separate depth and stencil buffers for when OES_packed_depth_stencil is not available. Refactor creation of multisampled and non-multisampled depth and stencil buffers into resizeDepthStencil().
  • platform/graphics/gpu/SharedGraphicsContext3D.cpp: (WebCore::SharedGraphicsContext3D::create): Turn on stencil, turn off depth, turn off antialiasing (for now). (WebCore::SharedGraphicsContext3D::enableStencil):
  • platform/graphics/gpu/SharedGraphicsContext3D.h: Implement stencil enable/disable.
  • platform/graphics/gpu/mac/DrawingBufferMac.mm: (WebCore::DrawingBuffer::DrawingBuffer): Remove m_multisampleDepthStencilBuffer. Set the size to (-1, -1) on creation, so reset() doesn't early-out. Initialize m_depthBuffer and m_stencilBuffer.
  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::canvasClip): (WebCore::GraphicsContext::clipOut): (WebCore::GraphicsContext::clipPath): (WebCore::GraphicsContext::fillPath): Put in GPU hooks for path clipping, and path drawing.
  • platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::canAccelerate): Don't check for clipping paths in canAccelerate() (since we can now accelerate them). (WebCore::PlatformContextSkia::uploadSoftwareToHardware): Don't do clipping when uploading software draws to hardware.
  • thirdparty/glu/README.webkit:
  • thirdparty/glu/gluos.h: #undef MIN and MAX, to fix warnings-as-errors in Chrome/Mac build.
  • thirdparty/glu/libtess/geom.c:
  • thirdparty/glu/libtess/priorityq.c:
  • thirdparty/glu/libtess/render.c: Use do{}while(0) instead of if(1)else construct in macro.
  • thirdparty/glu/libtess/sweep.c: (IsWindingInside): (DoneEdgeDict): Fix some warnings treated as errors for the Linux Release build.
2:04 PM Changeset in webkit [76158] by dpranke@chromium.org
  • 2 edits in trunk/Tools

2011-01-19 Dirk Pranke <dpranke@chromium.org>

Unreviewed, build fix.

Fix test failure caused by committing attachment 79368 instead
of attachment 79461 on bug 52604.

  • Scripts/webkitpy/common/system/filesystem_mock.py:
1:56 PM Changeset in webkit [76157] by andersca@apple.com
  • 10 edits in trunk/Source/WebKit2

2011-01-19 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Suspend/resume painting as the WKView visibility changes
https://bugs.webkit.org/show_bug.cgi?id=52738

  • UIProcess/DrawingAreaProxy.h: (WebKit::DrawingAreaProxy::visibilityDidChange): Add new member function. It should really be pure virtual once setPageIsVisible is removed.
  • UIProcess/DrawingAreaProxyImpl.cpp: (WebKit::DrawingAreaProxyImpl::visibilityDidChange): Send SuspendPainting/ResumePainting messages based on whether the view is visible or not.

(WebKit::DrawingAreaProxyImpl::setPageIsVisible):
Make this a stub; it should really be removed.

  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::viewStateDidChange): Call visibilityDidChange.
  • UIProcess/WebPageProxy.h: (WebKit::WebPageProxy::isViewVisible): Add new getter.
  • WebProcess/WebPage/DrawingArea.messages.in: Add SuspendPainting and ResumePainting messages.
  • WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::DrawingAreaImpl): Initialize m_isPaintingSuspended.

(WebKit::DrawingAreaImpl::suspendPainting):
Set m_isPaintingSuspended to true and stop the display timer.

(WebKit::DrawingAreaImpl::resumePainting):
Set m_isPaintingSuspended to false.

(WebKit::DrawingAreaImpl::scheduleDisplay):
(WebKit::DrawingAreaImpl::display):
Bail if m_isPaintingSuspended is true.

1:48 PM Changeset in webkit [76156] by dimich@chromium.org
  • 3 edits
    5 deletes in trunk

2011-01-19 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r76144.
http://trac.webkit.org/changeset/76144
https://bugs.webkit.org/show_bug.cgi?id=52737

Broke tests on multiple bots, mostly Chromium Canaries
(Requested by dimich on #webkit).

  • editing/selection/caret-painting-in-overflowing-autowrap-content.html: Removed.
  • editing/selection/resources/iframe-positioning-caret-at-end.html: Removed.
  • platform/mac/editing/selection/caret-painting-in-overflowing-autowrap-content-expected.checksum: Removed.
  • platform/mac/editing/selection/caret-painting-in-overflowing-autowrap-content-expected.png: Removed.
  • platform/mac/editing/selection/caret-painting-in-overflowing-autowrap-content-expected.txt: Removed.

2011-01-19 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r76144.
http://trac.webkit.org/changeset/76144
https://bugs.webkit.org/show_bug.cgi?id=52737

Broke tests on multiple bots, mostly Chromium Canaries
(Requested by dimich on #webkit).

  • rendering/RenderText.cpp: (WebCore::RenderText::localCaretRect):
1:30 PM Changeset in webkit [76155] by dpranke@chromium.org
  • 5 edits in trunk/Tools

2011-01-19 Dirk Pranke <dpranke@chromium.org>

Reviewed by Mihai Parparita.

new-run-webkit-tests: remove use of os.walk, use mock filesystem for better
unit testing. os.walk() is too much of a hassle to implement on
top of the in-memory mock filesystem and adding the necessary
interface to files_under() gives clients a cleaner API anyway
(for this particular usage model).

https://bugs.webkit.org/show_bug.cgi?id=52691

  • Scripts/webkitpy/common/system/filesystem.py:
  • Scripts/webkitpy/common/system/filesystem_mock.py:
  • Scripts/webkitpy/layout_tests/port/test_files.py:
  • Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
1:29 PM Changeset in webkit [76154] by simon.fraser@apple.com
  • 3 edits
    4 adds in trunk

2011-01-19 Simon Fraser <simon.fraser@apple.com>

Reviewed by Adam Roben.

[CSS Gradients] Crash due to out-of-memory with repeating-linear-gradient and latter stop positioned before former
https://bugs.webkit.org/show_bug.cgi?id=52732

When repeating gradient stops, make sure that the first and last stops are not at the same
place, otherwise we'll add stops indefinitely and run out of memory.

Test: fast/gradients/zero-range-repeating-gradient-hang.html

  • css/CSSGradientValue.cpp: (WebCore::CSSGradientValue::addStops):
1:25 PM Changeset in webkit [76153] by robert@webkit.org
  • 2 edits in trunk/LayoutTests

2011-01-19 Robert Hogan <robert@webkit.org>

Reviewed by Simon Hausmann.

[Qt] Unskip passing http tests and annotate Skipped list
https://bugs.webkit.org/show_bug.cgi?id=52395

Unskip:
http/tests/security/xss-DENIED-xsl-document.xml
http/tests/loading/simple-subframe.html

  • platform/qt/Skipped:
  • platform/qt/http/tests/loading/simple-subframe-expected.txt:
1:15 PM Changeset in webkit [76152] by mrobinson@webkit.org
  • 3 edits in trunk/LayoutTests

2011-01-19 Martin Robinson <mrobinson@igalia.com>

Rebaseline two GTK+ tests results after r76144.

  • platform/gtk/fast/forms/input-text-scroll-left-on-blur-expected.txt:
  • platform/gtk/fast/forms/plaintext-mode-2-expected.txt:
1:10 PM Changeset in webkit [76151] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

2011-01-19 Dimitri Glazkov <Dimitri Glazkov>

Added fast/forms/slider-mouse-events.html to expectations to make sure
the new results are good on all bots.

  • platform/chromium/test_expectations.txt: Tweaked expectations.
12:28 PM Changeset in webkit [76150] by dpranke@chromium.org
  • 7 edits in trunk/Tools

2011-01-19 Dirk Pranke <dpranke@chromium.org>

Reviewed by Tony Chang.

Change more modules in the layout-tests code to use the
filesystem wrapper for cleaner unit testing.

This patch also adds the glob() wrapper to the filesystem
abstraction.

https://bugs.webkit.org/show_bug.cgi?id=52604

  • Scripts/webkitpy/layout_tests/port/test_files.py:
  • Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
  • Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
  • Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
  • Scripts/webkitpy/common/system/filesystem.py:
  • Scripts/webkitpy/common/system/filesystem_mock.py:
12:19 PM Changeset in webkit [76149] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebKit2

2011-01-19 Andreas Kling <kling@webkit.org>

Reviewed by Simon Hausmann.

[Qt][WK2] Implement formatLocalizedString() for Qt.

  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp: (WebKit::formatLocalizedString):
12:18 PM Changeset in webkit [76148] by oliver@apple.com
  • 5 edits in trunk

2011-01-19 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

[jsfunfuzz] Defining a function called proto inside an eval triggers an assertion
https://bugs.webkit.org/show_bug.cgi?id=52672

Add tests to ensure that we disallow proto as a function name.

  • fast/js/parser-syntax-check-expected.txt:
  • fast/js/script-tests/parser-syntax-check.js:

2011-01-19 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

[jsfunfuzz] Defining a function called proto inside an eval triggers an assertion
https://bugs.webkit.org/show_bug.cgi?id=52672

Rather than coming up with a somewhat convoluted mechanism to ensure that
developers can override the global objects prototype with a function named
proto and expect it to work, we just disallow it at the syntax level.

  • parser/JSParser.cpp: (JSC::JSParser::parseFunctionInfo):
12:17 PM Changeset in webkit [76147] by Dimitri Glazkov
  • 10 edits in trunk/Source/WebCore

2011-01-14 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

Remove event forwarding logic from input[type=range], simplify event flow and thumb positioning logic.
https://bugs.webkit.org/show_bug.cgi?id=52464

This change has two parts:

1) Utilize shadow DOM event retargeting to get rid of forwarding events

via render tree;

2) Move thumb positioning logic from RenderSlider to SliderThumbElement.

These two are highly co-dependent. It looked ugly when I tried to
separate them.

No change in behavior, covered by existing tests.

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler): Added invocation of

InputType::handleMouseDownEvent.

  • html/InputType.cpp: (WebCore::InputType::handleMouseDownEvent): Added empty decl.
  • html/InputType.h: Added def.
  • html/RangeInputType.cpp: (WebCore::RangeInputType::handleMouseDownEvent): Added to handle the case

when the user clicks on the track of the slider. Also removed the
forwardEvent method.

  • html/RangeInputType.h: Added/removed defs.
  • html/shadow/SliderThumbElement.cpp: (WebCore::SliderThumbElement::dragFrom): Added a helper method to start

dragging from any position.

(WebCore::SliderThumbElement::dragTo): Added a helper method to drag to

specified position.

(WebCore::SliderThumbElement::setPosition): Collapsed most of the positioning

logic in RenderSlider into this method, which is now a simple calculation
and adjusting of thumb position based on supplied coordinates.

(WebCore::SliderThumbElement::startDragging): Added.
(WebCore::SliderThumbElement::stopDragging): Added.
(WebCore::SliderThumbElement::defaultEventHandler): Removed most of the

old position-sniffing logic and replaced with simple calls to start,
stop, and drag the thumb.

  • html/shadow/SliderThumbElement.h: Added defs.
  • rendering/RenderSlider.cpp: Removed a bunch of code that is no longer

necessary.

  • rendering/RenderSlider.h: Removed defs, removed now-unnecessary friendliness.
12:10 PM Changeset in webkit [76146] by commit-queue@webkit.org
  • 22 edits in trunk/Source/WebCore

2011-01-19 Shane Stephens <shanestephens@google.com>

Reviewed by Chris Marrin.

Make AffineTransform and TransformationMatrix do matrix multiplication in the correct order (Column Major)
https://bugs.webkit.org/show_bug.cgi?id=48031

Fixed reversal, renamed matrix methods to be clearer, found all examples of operator* and
operator*= usage and switched operand order.

No new tests as this refactor doesn't add functionality.

  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::baseTransform):
  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::transform): (WebCore::CanvasRenderingContext2D::setTransform):
  • platform/graphics/cg/PatternCG.cpp: (WebCore::Pattern::createPlatformPattern):
  • platform/graphics/chromium/GLES2Canvas.cpp: (WebCore::GLES2Canvas::fillRect): (WebCore::GLES2Canvas::concatCTM): (WebCore::GLES2Canvas::drawQuad):
  • platform/graphics/chromium/TransparencyWin.cpp: (WebCore::TransparencyWin::setupLayerForOpaqueCompositeLayer): (WebCore::TransparencyWin::setupTransformForKeepTransform):
  • platform/graphics/transforms/AffineTransform.cpp: (WebCore::AffineTransform::multiply): (WebCore::AffineTransform::rotate):
  • platform/graphics/transforms/AffineTransform.h: (WebCore::AffineTransform::operator*=): (WebCore::AffineTransform::operator*):
  • platform/graphics/wince/GraphicsContextWinCE.cpp: (WebCore::GraphicsContextPlatformPrivate::concatCTM):
  • platform/graphics/wince/SharedBitmap.cpp: (WebCore::SharedBitmap::drawPattern):
  • rendering/svg/RenderSVGResourceContainer.cpp: (WebCore::RenderSVGResourceContainer::transformOnNonScalingStroke):
  • rendering/svg/RenderSVGResourceGradient.cpp: (WebCore::clipToTextMask): (WebCore::RenderSVGResourceGradient::applyResource):
  • rendering/svg/RenderSVGResourcePattern.cpp: (WebCore::RenderSVGResourcePattern::applyResource):
  • rendering/svg/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::localToBorderBoxTransform):
  • rendering/svg/SVGImageBufferTools.cpp: (WebCore::SVGImageBufferTools::calculateTransformationToOutermostSVGCoordinateSystem): (WebCore::SVGImageBufferTools::renderSubtreeToImageBuffer):
  • rendering/svg/SVGTextLayoutEngine.cpp: (WebCore::SVGTextLayoutEngine::finalizeTransformMatrices):
  • svg/SVGLocatable.cpp: (WebCore::SVGLocatable::computeCTM): (WebCore::SVGLocatable::getTransformToElement):
  • svg/SVGMatrix.h: (WebCore::SVGMatrix::multiply):
  • svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::localCoordinateSpaceTransform): (WebCore::SVGSVGElement::viewBoxToViewTransform):
  • svg/SVGStyledTransformableElement.cpp: (WebCore::SVGStyledTransformableElement::animatedLocalTransform):
  • svg/SVGTextElement.cpp: (WebCore::SVGTextElement::animatedLocalTransform):
  • svg/SVGTransformList.cpp: (WebCore::SVGTransformList::concatenate):
11:31 AM Changeset in webkit [76145] by chang.shu@nokia.com
  • 22 edits in trunk

2011-01-19 Chang Shu <chang.shu@nokia.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=52056

  1. Fixed test cases in the above bug;
  2. Partially fixed test cases in other contentEditable bugs;
  3. Updated expected result for fast/dom/element-attribute-js-null.html. However, the test itself should be fixed later in bug 52057.
  • editing/editability/attr-invalid-string-expected.txt:
  • editing/editability/attr-invalid-string.html:
  • editing/editability/attr-missing-ancestor-false-expected.txt:
  • editing/editability/attr-missing-ancestor-false.html:
  • editing/editability/attr-missing-ancestor-true-expected.txt:
  • editing/editability/attr-missing-ancestor-true.html:
  • editing/editability/attr-missing-parent-ancestor-missing-expected.txt:
  • editing/editability/attr-missing-parent-ancestor-missing.html:
  • editing/editability/attr-missing-parent-false-expected.txt:
  • editing/editability/attr-missing-parent-false.html:
  • editing/editability/attr-missing-parent-true-expected.txt:
  • editing/editability/attr-missing-parent-true.html:
  • editing/editability/set-false-expected.txt:
  • editing/editability/set-inherit-parent-false-expected.txt:
  • editing/editability/set-inherit-parent-true-expected.txt:
  • editing/editability/set-invalid-value-expected.txt:
  • editing/editability/set-true-expected.txt:
  • editing/editability/set-value-caseinsensitive-expected.txt:
  • fast/dom/element-attribute-js-null-expected.txt:

2011-01-19 Chang Shu <chang.shu@nokia.com>

Reviewed by Darin Adler.

The return value of contentEditable() function should depend on the DOM attribute
instead of render style userModify. The code change fixed test cases in the bug
and partially fixed test cases in other contentEditable bugs;

https://bugs.webkit.org/show_bug.cgi?id=52056

  • html/HTMLElement.cpp: (WebCore::HTMLElement::contentEditable):
11:27 AM Changeset in webkit [76144] by leviw@chromium.org
  • 3 edits
    5 adds in trunk

2011-01-19 Levi Weintraub <leviw@chromium.org>

Reviewed by Darin Adler.

Changing RenderText::localCaretRect to clip to its containing block's logicalLeft and
logicalRightLayoutOverflow instead of simply using logicalLeft and logicalRight, as this
resulted in the caret being placed incorrectly in overflowing editable IFrame content.

Long lines in non-white-space-pre editable documents show cursor in wrong place
https://bugs.webkit.org/show_bug.cgi?id=48132

  • editing/selection/caret-painting-in-overflowing-autowrap-content.html: Added.
  • editing/selection/resources/iframe-positioning-caret-at-end.html: Added.
  • platform/mac/editing/selection/caret-painting-in-overflowing-autowrap-content-expected.checksum: Added.
  • platform/mac/editing/selection/caret-painting-in-overflowing-autowrap-content-expected.png: Added.
  • platform/mac/editing/selection/caret-painting-in-overflowing-autowrap-content-expected.txt: Added.

2011-01-19 Levi Weintraub <leviw@chromium.org>

Reviewed by Darin Adler.

Changing RenderText::localCaretRect to clip to its containing block's logicalLeft and
logicalRightLayoutOverflow instead of simply using logicalLeft and logicalRight, as this
resulted in the caret being placed incorrectly in overflowing editable IFrame content.

Long lines in non-white-space-pre editable documents show cursor in wrong place
https://bugs.webkit.org/show_bug.cgi?id=48132

Test: editing/selection/caret-painting-in-overflowing-autowrap-content.html

  • rendering/RenderText.cpp: (WebCore::RenderText::localCaretRect):
11:26 AM Changeset in webkit [76143] by andersca@apple.com
  • 6 edits in trunk/Source/WebKit2

2011-01-19 Chris Marrin <cmarrin@apple.com>

Reviewed by Simon Fraser.

WK2 - Multiple crashes in PlatformCALayer::replaceSublayer
https://bugs.webkit.org/show_bug.cgi?id=52695

Added a hostingLayer as the parent of the existing drawingLayer.
The hostingLayer is now the root which is passed to the
remote context. It never changes except to track the size
of the window. The backingLayer is now a child of the
hostingLayer, which allow it to switch between tiled and
non-tiled.

I also now give back accurate settings for debug borders and
repaint counters.

  • WebProcess/WebPage/LayerBackedDrawingArea.cpp: (WebKit::LayerBackedDrawingArea::LayerBackedDrawingArea): (WebKit::LayerBackedDrawingArea::setSize): (WebKit::LayerBackedDrawingArea::showDebugBorders): (WebKit::LayerBackedDrawingArea::showRepaintCounter):
  • WebProcess/WebPage/LayerBackedDrawingArea.h:
  • WebProcess/WebPage/mac/LayerBackedDrawingAreaMac.mm: (WebKit::LayerBackedDrawingArea::platformInit): (WebKit::LayerBackedDrawingArea::attachCompositingContext): (WebKit::LayerBackedDrawingArea::syncCompositingLayers):
11:17 AM Changeset in webkit [76142] by cmarrin@apple.com
  • 6 edits in trunk/Source

2011-01-19 Chris Marrin <cmarrin@apple.com>

Reviewed by Simon Fraser.

WK2 - Multiple crashes in PlatformCALayer::replaceSublayer
https://bugs.webkit.org/show_bug.cgi?id=52695

Added a hostingLayer as the parent of the existing drawingLayer.
The hostingLayer is now the root which is passed to the
remote context. It never changes except to track the size
of the window. The backingLayer is now a child of the
hostingLayer, which allow it to switch between tiled and
non-tiled.

I also now give back accurate settings for debug borders and
repaint counters.

  • WebProcess/WebPage/LayerBackedDrawingArea.cpp: (WebKit::LayerBackedDrawingArea::LayerBackedDrawingArea): (WebKit::LayerBackedDrawingArea::setSize): (WebKit::LayerBackedDrawingArea::showDebugBorders): (WebKit::LayerBackedDrawingArea::showRepaintCounter):
  • WebProcess/WebPage/LayerBackedDrawingArea.h:
  • WebProcess/WebPage/mac/LayerBackedDrawingAreaMac.mm: (WebKit::LayerBackedDrawingArea::platformInit): (WebKit::LayerBackedDrawingArea::attachCompositingContext): (WebKit::LayerBackedDrawingArea::syncCompositingLayers):

2011-01-19 Chris Marrin <cmarrin@apple.com>

Reviewed by Simon Fraser.

WK2 - Multiple crashes in PlatformCALayer::replaceSublayer
https://bugs.webkit.org/show_bug.cgi?id=52695

Added ASSERTs to the places we assume a non-null superlayer.

  • platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::ensureStructuralLayer): (WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):
10:49 AM Changeset in webkit [76141] by bdakin@apple.com
  • 9 edits in trunk/Source/WebCore

Fix for <rdar://problem/8882916> Overlay scrollers require
content to layout underneath the scrollbar area

Reviewed by Maciej Stachowiak.

The render tree should not include scrollbar size for
overlay scrollers. This patch will allow scrollers on
the WebView to behave like overflow:overlay.

Treat overlay scrollers the same way as the !includeScrollbars
case.

  • platform/ScrollView.cpp:

(WebCore::ScrollView::visibleContentRect):

No corner rect for overlay scrollers.
(WebCore::ScrollView::scrollCornerRect):

usesOverlayScrollbars() currently always returns no.

  • platform/ScrollbarTheme.h:

(WebCore::ScrollbarTheme::usesOverlayScrollbars):

  • platform/mac/ScrollbarThemeMac.h:
  • platform/mac/ScrollbarThemeMac.mm:

(WebCore::ScrollbarThemeMac::usesOverlayScrollbars):

includeVerticalScrollbarSize() and includeHorizontalScrollbarSize()
should return false for overlay scrollers. They already return
false for overflow:overlay.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::includeVerticalScrollbarSize):
(WebCore::RenderBox::includeHorizontalScrollbarSize):

  • rendering/RenderBox.h:

In the render tree, always treat overlay scrollers like
they have a width and height of 0.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::verticalScrollbarWidth):
(WebCore::RenderLayer::horizontalScrollbarHeight):

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::verticalScrollbarWidth):

10:43 AM Changeset in webkit [76140] by leviw@chromium.org
  • 2 edits in trunk/Tools

2011-01-19 Levi Weintraub <leviw@chromium.org>

Unreviewed.

Updating my email addresses and irc nick.

  • Scripts/webkitpy/common/config/committers.py:
10:36 AM Changeset in webkit [76139] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-01-19 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler.

Throttle sending of SetSize messages
https://bugs.webkit.org/show_bug.cgi?id=52727

  • UIProcess/DrawingAreaProxyImpl.cpp: (WebKit::DrawingAreaProxyImpl::DrawingAreaProxyImpl): Initialize m_isWaitingForDidSetSize to false.

(WebKit::DrawingAreaProxyImpl::didSetSize):
Null out the backing store.

(WebKit::DrawingAreaProxyImpl::sendSetSize):
If m_isWaitingForDidSetSize is true, do nothing. Otherwise, set m_isWaitingForDidSetSize
to true and send a SetSize message.

  • UIProcess/DrawingAreaProxyImpl.h: Add m_isWaitingForDidSetSize.
10:34 AM Changeset in webkit [76138] by bweinstein@apple.com
  • 2 edits in trunk/LayoutTests

Update Windows expected results after r76115.

  • platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
10:29 AM Changeset in webkit [76137] by evan@chromium.org
  • 6 edits in trunk

2011-01-18 Evan Martin <evan@chromium.org>

Reviewed by Tony Chang.

[chromium] simplify complex text code, fixing a handful of layout tests
https://bugs.webkit.org/show_bug.cgi?id=52661

  • platform/chromium/test_expectations.txt: Mark 11 tests as expected to pass.

2011-01-18 Evan Martin <evan@chromium.org>

Reviewed by Tony Chang.

[chromium] simplify complex text code, fixing a handful of layout tests
https://bugs.webkit.org/show_bug.cgi?id=52661

Change ComplexTextControllerLinux to lay out RTL text to the left from
the starting point. (Previously it always went to the right.) This allows
us to map pixel offsets more directly into offsets within the text runs,
simplifying a few of the text-fiddling functions (they no longer need to
track the current position, as ComplexTextController now does it).

  • platform/graphics/chromium/ComplexTextControllerLinux.cpp: (WebCore::ComplexTextController::ComplexTextController): (WebCore::ComplexTextController::reset): (WebCore::ComplexTextController::setGlyphXPositions):
  • platform/graphics/chromium/ComplexTextControllerLinux.h: (WebCore::ComplexTextController::offsetX):
  • platform/graphics/chromium/FontLinux.cpp: (WebCore::Font::drawComplexText): (WebCore::Font::floatWidthForComplexText): (WebCore::glyphIndexForXPositionInScriptRun): (WebCore::Font::offsetForPositionForComplexText): (WebCore::Font::selectionRectForComplexText):
10:27 AM Changeset in webkit [76136] by pfeldman@chromium.org
  • 22 edits
    1 copy
    1 add in trunk/Source/WebCore

2011-01-19 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: move methods from InjectedScript domain into DOM,
Runtime and Debugger domains. Introduce InspectorRuntimeAgent.
https://bugs.webkit.org/show_bug.cgi?id=52717

  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/CodeGeneratorInspector.pm:
  • inspector/InjectedScript.cpp: (WebCore::InjectedScript::evaluateOnCallFrame): (WebCore::InjectedScript::getCompletions): (WebCore::InjectedScript::getCompletionsOnCallFrame):
  • inspector/InjectedScript.h:
  • inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::injectedScriptForMainWorld):
  • inspector/InjectedScriptHost.h:
  • inspector/InjectedScriptSource.js: (.): ():
  • inspector/Inspector.idl:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::releaseFrontendLifetimeAgents):
  • inspector/InspectorController.h:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::InspectorDOMAgent): (WebCore::InspectorDOMAgent::resolveNode): (WebCore::InspectorDOMAgent::getNodeProperties): (WebCore::InspectorDOMAgent::getNodePrototypes): (WebCore::InspectorDOMAgent::injectedScriptForNodeId):
  • inspector/InspectorDOMAgent.h: (WebCore::EventListenerInfo::EventListenerInfo): (WebCore::InspectorDOMAgent::DOMListener::~DOMListener): (WebCore::InspectorDOMAgent::create): (WebCore::InspectorDOMAgent::cast): (WebCore::InspectorDOMAgent::documents):
  • inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::evaluateOnCallFrame): (WebCore::InspectorDebuggerAgent::getCompletionsOnCallFrame): (WebCore::InspectorDebuggerAgent::injectedScriptForCallFrameId):
  • inspector/InspectorDebuggerAgent.h:
  • inspector/InspectorRuntimeAgent.cpp: Added. (WebCore::InspectorRuntimeAgent::InspectorRuntimeAgent): (WebCore::InspectorRuntimeAgent::~InspectorRuntimeAgent): (WebCore::InspectorRuntimeAgent::evaluate): (WebCore::InspectorRuntimeAgent::getCompletions): (WebCore::InspectorRuntimeAgent::getProperties): (WebCore::InspectorRuntimeAgent::setPropertyValue): (WebCore::InspectorRuntimeAgent::pushNodeToFrontend): (WebCore::InspectorRuntimeAgent::injectedScriptForObjectId):
  • inspector/InspectorRuntimeAgent.h: Copied from Source/WebCore/inspector/InjectedScript.h. (WebCore::InspectorRuntimeAgent::create):
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.completions):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.doEvalInCallFrame):
10:18 AM Changeset in webkit [76135] by andersca@apple.com
  • 6 edits in trunk/Source/WebKit2

2011-01-19 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler.

Pass WebPageCreationParameters to DrawingArea::create
https://bugs.webkit.org/show_bug.cgi?id=52726

  • WebProcess/WebPage/DrawingArea.cpp: (WebKit::DrawingArea::create):
  • WebProcess/WebPage/DrawingArea.h:
  • WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::create): (WebKit::DrawingAreaImpl::DrawingAreaImpl):
  • WebProcess/WebPage/DrawingAreaImpl.h:
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::WebPage): (WebKit::WebPage::changeAcceleratedCompositingMode):
10:14 AM Changeset in webkit [76134] by tony@chromium.org
  • 4 edits in trunk/Tools

2011-01-19 Tony Chang <tony@chromium.org>

Reviewed by Mihai Parparita.

[chromium] [linux] if check-sys-deps fails, output the failure reason
https://bugs.webkit.org/show_bug.cgi?id=52671

  • Scripts/webkitpy/common/system/executive_mock.py: Add support for

error handler functions.

  • Scripts/webkitpy/layout_tests/port/chromium.py:

output the error text from --check-sys-deps

  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
9:58 AM Changeset in webkit [76133] by msaboff@apple.com
  • 5 edits in trunk

2011-01-19 Michael Saboff <msaboff@apple.com>

Reviewed by Darin Adler.

<rdar://problem/8882994> Regression: Simple nested backtrack hangs
https://bugs.webkit.org/show_bug.cgi?id=52675

The changeset (r76076) for https://bugs.webkit.org/show_bug.cgi?id=52540
broke simple backtracking in some cases. Reworked that change to
link both jumps and labels.

  • yarr/YarrJIT.cpp: (JSC::Yarr::YarrGenerator::BacktrackDestination::hasBacktrackToLabel): (JSC::Yarr::YarrGenerator::TermGenerationState::propagateBacktrackingFrom): (JSC::Yarr::YarrGenerator::generateParenthesesSingle):

2011-01-19 Michael Saboff <msaboff@apple.com>

Reviewed by Darin Adler.

<rdar://problem/8882994> Regression: Simple nested backtrack hangs
https://bugs.webkit.org/show_bug.cgi?id=52675

New tests to support change.

  • fast/regex/parentheses-expected.txt:
  • fast/regex/script-tests/parentheses.js:
9:57 AM Changeset in webkit [76132] by podivilov@chromium.org
  • 7 edits
    4 adds in trunk/Source/WebCore

2011-01-18 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: add UglifyJS parser and formatter files
https://bugs.webkit.org/show_bug.cgi?id=51702

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/ScriptFormatter.js: (WebInspector.ScriptFormatter.positionToLocation): (WebInspector.ScriptFormatter.prototype.format.messageHandler): (WebInspector.ScriptFormatter.prototype.format): (WebInspector.ScriptFormatter.prototype._buildMapping): (WebInspector.ScriptFormatter.prototype._convertPosition):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype.formatSource.didFormat): (WebInspector.SourceFrame.prototype.formatSource):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/parse-js.js: Added. UglifyJS parser.
  • inspector/front-end/process.js: Added. UglifyJS formatter.
  • inspector/front-end/scriptFormatterWorker.js: Added. Worker script that wraps UglifyJS code. (onmessage): (beautify): (loadModule): (require):
  • inspector/front-end/utilities.js: ():
9:48 AM Changeset in webkit [76131] by Csaba Osztrogonác
  • 1 edit
    3 adds in trunk/LayoutTests

Unreviewed.

Add Qt specific expected result for a new test introduced in r76074.
Compared to Mac png files and Mac expected files.

  • platform/qt/fast/block/float/float-overflow-hidden-containing-block-width-expected.checksum: Added.
  • platform/qt/fast/block/float/float-overflow-hidden-containing-block-width-expected.png: Added.
  • platform/qt/fast/block/float/float-overflow-hidden-containing-block-width-expected.txt: Added.
9:47 AM Changeset in webkit [76130] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

2011-01-19 Joone Hur <joone.hur@collabora.co.uk>

Reviewed by Andreas Kling.

[GTK] No need to invalidate empty areas in ChromeClient::invalidateContentsAndWindow
https://bugs.webkit.org/show_bug.cgi?id=52702

Don't call gdk_window_invalidate_rect if an updated rectangle is empty.

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::invalidateContentsAndWindow):
9:01 AM Changeset in webkit [76129] by podivilov@chromium.org
  • 15 edits
    2 adds in trunk

2011-01-19 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [JSC] scripts have incorrect starting line (always 1).
https://bugs.webkit.org/show_bug.cgi?id=52721

  • inspector/debugger-scripts-expected.txt: Added.
  • inspector/debugger-scripts.html: Added.

2011-01-19 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [JSC] scripts have incorrect starting line (always 1).
https://bugs.webkit.org/show_bug.cgi?id=52721

  • debugger/Debugger.cpp: (JSC::Debugger::recompileAllJSFunctions):
  • debugger/Debugger.h:
  • parser/Parser.h: (JSC::Parser::parse):
  • parser/SourceCode.h: (JSC::SourceCode::SourceCode):
  • parser/SourceProvider.h: (JSC::SourceProvider::startPosition):

2011-01-19 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [JSC] scripts have incorrect starting line (always 1).
https://bugs.webkit.org/show_bug.cgi?id=52721

Test: inspector/debugger-scripts.html

  • bindings/js/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::dispatchDidParseSource): (WebCore::ScriptDebugServer::dispatchFailedToParseSource): (WebCore::ScriptDebugServer::sourceParsed):
  • bindings/js/ScriptDebugServer.h:
  • bindings/js/ScriptSourceCode.h: (WebCore::ScriptSourceCode::ScriptSourceCode):
  • bindings/js/StringSourceProvider.h: (WebCore::StringSourceProvider::create): (WebCore::StringSourceProvider::startPosition): (WebCore::StringSourceProvider::StringSourceProvider):

2011-01-19 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [JSC] scripts have incorrect starting line (always 1).
https://bugs.webkit.org/show_bug.cgi?id=52721

  • WebView/WebScriptDebugger.h:
  • WebView/WebScriptDebugger.mm: (toNSString): (WebScriptDebugger::sourceParsed):
8:41 AM Changeset in webkit [76128] by satish@chromium.org
  • 14 edits in trunk/Source

2011-01-19 Satish Sampath <satish@chromium.org>

Reviewed by Jeremy Orlow.

Send origin/url as part of speech input requests to the embedder.
https://bugs.webkit.org/show_bug.cgi?id=52718

  • page/SpeechInput.cpp: (WebCore::SpeechInput::startRecognition): Pass up additional origin parameter.
  • page/SpeechInput.h:
  • page/SpeechInputClient.h:
  • platform/mock/SpeechInputClientMock.cpp: (WebCore::SpeechInputClientMock::startRecognition): Updated prototype.
  • platform/mock/SpeechInputClientMock.h:
  • rendering/TextControlInnerElements.cpp: (WebCore::InputFieldSpeechButtonElement::defaultEventHandler): Pass the frame origin to speech input request.

2011-01-19 Satish Sampath <satish@chromium.org>

Reviewed by Jeremy Orlow.

Send origin/url as part of speech input requests to the embedder.
https://bugs.webkit.org/show_bug.cgi?id=52718

  • public/WebSpeechInputController.h: (WebKit::WebSpeechInputController::startRecognition): Updated prototype.
  • src/SpeechInputClientImpl.cpp: (WebKit::SpeechInputClientImpl::startRecognition): Pass up additional origin parameter.
  • src/SpeechInputClientImpl.h:
  • src/WebSpeechInputControllerMockImpl.cpp: Updated code to pass additional parameter. (WebKit::WebSpeechInputControllerMockImpl::startRecognition):
  • src/WebSpeechInputControllerMockImpl.h: Added new variant of startRecognition method.
8:27 AM Changeset in webkit [76127] by jorlow@chromium.org
  • 3 edits in trunk/LayoutTests

2011-01-19 Jeremy Orlow <jorlow@chromium.org>

This test changed slightly, so rebaseline it. The offsets seem off
but they have been for as long as the files have been upstream so it's
likely a known issue.

  • platform/chromium-win/fast/events/offsetX-offsetY-expected.txt:
  • platform/chromium/test_expectations.txt:
8:24 AM Changeset in webkit [76126] by hans@chromium.org
  • 7 edits
    2 adds in trunk

2011-01-19 Hans Wennborg <hans@chromium.org>

Reviewed by Jeremy Orlow.

IndexedDB: Support auto-increment keys
https://bugs.webkit.org/show_bug.cgi?id=52576

Add layout test for auto increment keys.
Update previous test not to consider auto increment an error.

  • storage/indexeddb/create-object-store-options-expected.txt:
  • storage/indexeddb/create-object-store-options.html:
  • storage/indexeddb/objectstore-autoincrement-expected.txt: Added.
  • storage/indexeddb/objectstore-autoincrement.html: Added.

2011-01-19 Hans Wennborg <hans@chromium.org>

Reviewed by Jeremy Orlow.

IndexedDB: Support auto-increment keys
https://bugs.webkit.org/show_bug.cgi?id=52576

Add support for auto-increment keys.

Test: storage/indexeddb/objectstore-autoincrement.html

  • storage/IDBDatabase.cpp: (WebCore::IDBDatabase::createObjectStore):
  • storage/IDBObjectStoreBackendImpl.cpp: (WebCore::genAutoIncrementKey): (WebCore::IDBObjectStoreBackendImpl::putInternal):
6:42 AM Changeset in webkit [76125] by Csaba Osztrogonác
  • 3 edits in trunk/LayoutTests

Unreviewed.

Update Qt specific expected files after r76115.

  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
6:39 AM Changeset in webkit [76124] by Joseph Pecoraro
  • 3 edits in trunk/LayoutTests

2011-01-19 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Simon Fraser.

Update Test Now that Bug is Fixed
https://bugs.webkit.org/show_bug.cgi?id=52677

  • fast/events/offsetX-offsetY-expected.txt: one more PASS line.
  • fast/events/offsetX-offsetY.html: uncomment and update hit-test location.
6:32 AM Changeset in webkit [76123] by jorlow@chromium.org
  • 1 edit
    2 moves in trunk/LayoutTests

2011-01-19 Jeremy Orlow <jorlow@chromium.org>

Move pixel test results to the proper place.

  • platform/mac/svg/custom/use-inherit-style-expected.checksum: Renamed from LayoutTests/svg/custom/use-inherit-style-expected.checksum.
  • platform/mac/svg/custom/use-inherit-style-expected.png: Renamed from LayoutTests/svg/custom/use-inherit-style-expected.png.
6:31 AM Changeset in webkit [76122] by Csaba Osztrogonác
  • 10 edits in trunk/Source

[Qt] Remove unnecessary "../Source" from paths
after moving source files into Source is finished.

Reviewed by Laszlo Gombos and Tor Arne Vestbø.

Source/JavaScriptCore:

Source/WebCore:

  • WebCore.pri:
  • WebCore.pro:

Source/WebKit/qt:

  • Api/DerivedSources.pro:

Source/WebKit2:

  • DerivedSources.pro:
  • WebKit2.pro:
6:27 AM Changeset in webkit [76121] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-01-19 Benjamin Kalman <kalman@chromium.org>

Reviewed by Darin Adler.

Don't return void from void function String::split
https://bugs.webkit.org/show_bug.cgi?id=52684

  • wtf/text/WTFString.cpp: (WTF::String::split):
6:15 AM Changeset in webkit [76120] by commit-queue@webkit.org
  • 2 edits in trunk

2011-01-19 Kimmo Kinnunen <kimmo.t.kinnunen@nokia.com>

Reviewed by Andreas Kling.

Enable usage of Google ld if it exist but is not on by default.

[Qt] Enable the google ld if it exist but is not on by default
https://bugs.webkit.org/show_bug.cgi?id=52625

  • common.pri: flip the test.
6:01 AM Changeset in webkit [76119] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

2011-01-19 Aparna Nandyal <aparna.nand@wipro.com>

Reviewed by Andreas Kling.

[Qt] QtTestBrowser crashes when closing if Facebook is opened
https://bugs.webkit.org/show_bug.cgi?id=52554

QtNetworkAccessManager is created in a thread and set as
member variable in QWebPage. When the thread is destroyed
the object is still used. So fix will set the object to
NULL once the thread is destroyed.

  • QtTestBrowser/launcherwindow.cpp: (LauncherWindow::~LauncherWindow):
5:55 AM Changeset in webkit [76118] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

2011-01-19 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: fixed flaky inspector test.

  • http/tests/inspector/extensions-resources-redirect.html:
5:27 AM Changeset in webkit [76117] by mnaganov@chromium.org
  • 1 edit
    2 deletes in trunk/LayoutTests

Revert "2011-01-18 Mikhail Naganov <mnaganov@chromium.org>"

Revert r76114 -- added test fails on Chromium canaries.

This reverts commit 89065aef21411b68af89a8fa7ff41dfe14c54a6a.

5:24 AM Changeset in webkit [76116] by apavlov@chromium.org
  • 9 edits
    1 add in trunk

2011-01-19 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Employ TextPrompt for CSS property name/value autocompletion
https://bugs.webkit.org/show_bug.cgi?id=52212

WebInspector.CSSKeywordCompletions contains a hand-written list of accepted CSS property value keywords
for each property. WebInspector.TextPrompt is used to suggest both the name and value keywords while
editing styles, in place of the old custom suggestion code.

WebCore:

  • inspector/front-end/CSSCompletions.js: (WebInspector.CSSCompletions.prototype.startsWith): Fix array-out-of-bounds error.
  • inspector/front-end/CSSKeywordCompletions.js: Added. (WebInspector.CSSKeywordCompletions.forProperty):
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertyTreeElement.prototype.updateTitle): (WebInspector.StylePropertyTreeElement.prototype): ():
  • inspector/front-end/TextPrompt.js: (WebInspector.TextPrompt): (WebInspector.TextPrompt.prototype.removeFromElement): (WebInspector.TextPrompt.prototype._onKeyDown): (WebInspector.TextPrompt.prototype.tabKeyPressed): (WebInspector.TextPrompt.prototype.upKeyPressed): (WebInspector.TextPrompt.prototype.downKeyPressed): (WebInspector.TextPrompt.prototype._moveBackInHistory): (WebInspector.TextPrompt.prototype._moveForwardInHistory):
  • inspector/front-end/inspector.css: (.auto-complete-text, .editing .auto-complete-text):
  • inspector/front-end/inspector.html:

LayoutTests:

  • inspector/styles-add-blank-property.html: Follow the altered event handling.
  • inspector/styles-url-linkify.html: Eliminate flakiness.
4:59 AM BuildingCairoOnWindows edited by d.nusman@re-lion.com
(diff)
4:56 AM Changeset in webkit [76115] by commit-queue@webkit.org
  • 33 edits
    6 adds in trunk

2011-01-19 Dai Mikurube <dmikurube@google.com>

Reviewed by Kent Tamura.

Implement onformchange and onforminput event handlers
https://bugs.webkit.org/show_bug.cgi?id=26141

  • fast/dom/Window/window-properties-expected.txt: Added form events.
  • fast/dom/Window/window-property-descriptors-expected.txt: Added form events.
  • fast/forms/formchange-event-expected.txt: Added.
  • fast/forms/formchange-event.html: Added to test formchange events.
  • fast/forms/forminput-event-expected.txt: Added.
  • fast/forms/forminput-event.html: Added to test forminput events.
  • fast/forms/script-tests/formchange-event.js: Added. (sendKey): (sendText):
  • fast/forms/script-tests/forminput-event.js: Added. (sendKey): (sendText):

2011-01-19 Dai Mikurube <dmikurube@google.com>

Reviewed by Kent Tamura.

Implement onformchange and onforminput event handlers
https://bugs.webkit.org/show_bug.cgi?id=26141

Tests: fast/forms/formchange-event.html

fast/forms/forminput-event.html

  • bindings/scripts/CodeGeneratorGObject.pm: Added event names.
  • dom/Document.h: Added event definitions.
  • dom/Document.idl: Added event definitions.
  • dom/Element.h: Added event definitions.
  • dom/Element.idl: Added event definitions.
  • dom/Event.cpp: (WebCore::Event::fromUserGesture): Added a condition for a formchange event in handling user gestures.
  • dom/EventNames.h: Added event definitions.
  • dom/InputElement.cpp: (WebCore::InputElement::setValueFromRenderer): Replaced a direct dispatchEvent() call into dispatchInputEvents(), a virtual function which broadcasts forminput events for HTML elements.
  • dom/Node.cpp: (WebCore::Node::dispatchInputEvents): Defined basic dispatchInputEvents() described above. (WebCore::Node::dispatchChangeEvents): Defined basic dispatchChangeEvents() described above. (WebCore::Node::defaultEventHandler): Replaced a direct dispatchEvent() call into dispatchInputEvents().
  • dom/Node.h:
  • html/FormAssociatedElement.h: Added isResettable() to check the element is resettable or not.
  • html/HTMLAttributeNames.in: Added event names.
  • html/HTMLElement.cpp: (WebCore::HTMLElement::parseMappedAttribute): Added event handling. (WebCore::HTMLElement::shadowAncestorOwnerForm): Added to get an ancestor <form> element from a shadow element. (WebCore::HTMLElement::dispatchChangeEvents): Defined dispatchChangeEvents() for HTML elements described above. (WebCore::HTMLElement::dispatchInputEvents): Defined dispatchInputEvents() for HTML elements described above.
  • html/HTMLElement.h:
  • html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::dispatchFormControlChangeEvent): Added calling dispatchFormChange() to broadcast formchange events. (WebCore::HTMLFormControlElement::dispatchFormControlInputEvent): Defined newly to dispatch an input event with broadcasting forminput events.
  • html/HTMLFormControlElement.h: Added isResettable().
  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::broadcastFormEvent): Added to broadcast forminput or formchange events. (WebCore::HTMLFormElement::dispatchFormInput): Defined newly to broadcast forminput events. (WebCore::HTMLFormElement::dispatchFormChange): Defined newly to broadcast formchange events.
  • html/HTMLFormElement.h:
  • html/HTMLFormElement.idl: Added dispatchFormInput() and dispatchFormChange() DOM API definitions.
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::stepUpFromRenderer): Replaced a direct dispatchEvent() call into dispatchInputEvents().
  • html/HTMLInputElement.h: Added isResettable().
  • html/HTMLKeygenElement.h: Added isResettable().
  • html/HTMLObjectElement.h: Added isResettable().
  • html/HTMLOutputElement.h: Added isResettable().
  • html/HTMLSelectElement.h: Added isResettable().
  • html/HTMLTextAreaElement.h: Added isResettable().
  • page/DOMWindow.h: Added event definitions.
  • page/DOMWindow.idl: Added event definitions.
  • rendering/TextControlInnerElements.cpp: (WebCore::SearchFieldCancelButtonElement::defaultEventHandler): Replaced a direct dispatchEvent() call into dispatchInputEvents().
4:42 AM Changeset in webkit [76114] by mnaganov@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-01-18 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Add layout test for the CPU profiler.

This test replaces DevToolsSanityTest.TestProfilerTab from
Chromium's interactive_ui_tests.

https://bugs.webkit.org/show_bug.cgi?id=52634

  • inspector/cpu-profiler-profiling-expected.txt: Added.
  • inspector/cpu-profiler-profiling.html: Added.
4:35 AM Changeset in webkit [76113] by mnaganov@chromium.org
  • 2 deletes in trunk/LayoutTests/inspector

Revert accidental r76110..76112

4:24 AM Changeset in webkit [76112] by mnaganov@chromium.org
  • 1 edit in trunk/LayoutTests/inspector/cpu-profiler-profiling.html

works in chromium

4:23 AM Changeset in webkit [76111] by mnaganov@chromium.org
  • 2 edits in trunk/LayoutTests/inspector

works in safari

4:23 AM Changeset in webkit [76110] by mnaganov@chromium.org
  • 2 adds in trunk/LayoutTests/inspector

added test

3:37 AM Changeset in webkit [76109] by caseq@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-01-19 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Extensions API] delete pending callback from callback map before invoking it
https://bugs.webkit.org/show_bug.cgi?id=52707

  • inspector/front-end/ExtensionAPI.js: (WebInspector.injectedExtensionAPI.ExtensionServerClient.prototype._onCallback):
2:34 AM Changeset in webkit [76108] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-01-19 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: updating Chromium devtools sanity tests for downstream use.

  • src/js/Tests.js: (.TestSuite.prototype._checkExecutionLine):
1:32 AM Changeset in webkit [76107] by commit-queue@webkit.org
  • 20 edits in trunk/Source

2011-01-19 Levi Weintraub <leviw@google.com>

Reviewed by Ryosuke Niwa.

Replaced rangeCompliantEquivalent with Position::parentAnchoredEquivalent
and simplified the logic a bit. Unfortunately, Tables and some legacy
editing positions still need to be handled specifically.

remove rangeCompliantEquivalent and replace it with Position methods
https://bugs.webkit.org/show_bug.cgi?id=25057

No new tests as this is a refactor that doesn't change behavior.

  • WebCore.exp.in:
  • dom/Document.cpp: (WebCore::Document::caretRangeFromPoint):
  • dom/Position.cpp: (WebCore::Position::parentAnchoredEquivalent):
  • dom/Position.h:
  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyBlockStyle):
  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::insertNodeAt): (WebCore::CompositeEditCommand::moveParagraphs):
  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::initializePositionData): (WebCore::DeleteSelectionCommand::mergeParagraphs):
  • editing/Editor.cpp: (WebCore::Editor::textDirectionForSelection): (WebCore::Editor::advanceToNextMisspelling):
  • editing/InsertLineBreakCommand.cpp: (WebCore::InsertLineBreakCommand::shouldUseBreakElement):
  • editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply):
  • editing/ReplaceSelectionCommand.cpp: (WebCore::handleStyleSpansBeforeInsertion):
  • editing/VisiblePosition.cpp: (WebCore::makeRange): (WebCore::setStart): (WebCore::setEnd):
  • editing/VisibleSelection.cpp: (WebCore::VisibleSelection::firstRange): (WebCore::VisibleSelection::toNormalizedRange): (WebCore::makeSearchRange):
  • editing/htmlediting.cpp: (WebCore::indexForVisiblePosition):
  • editing/htmlediting.h:
  • editing/visible_units.cpp: (WebCore::previousBoundary): (WebCore::nextBoundary):
  • page/DOMSelection.cpp: (WebCore::anchorPosition): (WebCore::focusPosition): (WebCore::basePosition): (WebCore::extentPosition):

2011-01-19 Levi Weintraub <leviw@google.com>

Reviewed by Ryosuke Niwa.

Updating to use Position::parentAnchoredEquivalent instead of
the old htmlediting rangeCompliantEquivalent.

remove rangeCompliantEquivalent and replace it with Position methods
https://bugs.webkit.org/show_bug.cgi?id=25057

  • WebView/WebFrame.mm: (-[WebFrame _smartDeleteRangeForProposedRange:]):
1:17 AM Changeset in webkit [76106] by yurys@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-01-19 Peter Rybin <peter.rybin@gmail.com>

Reviewed by Yury Semikhatsky.

Web Inspector: script column offset is incorrect
https://bugs.webkit.org/show_bug.cgi?id=52580

Column is updated in 3 places, 2 less probable places contained error.
Fixed now.

  • platform/text/SegmentedString.cpp: (WebCore::SegmentedString::advanceSlowCase):
  • platform/text/SegmentedString.h: (WebCore::SegmentedString::advancePastNewline):
1:00 AM Changeset in webkit [76105] by pfeldman@chromium.org
  • 32 edits
    1 delete in trunk

2011-01-18 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: make InjectedScriptAccess API a part of Web Inspector protocol.
https://bugs.webkit.org/show_bug.cgi?id=52652

Calls served by the InjectedScript should be first class protocol
citizens, not dispatched via single protocol message.

  • http/tests/inspector/extensions-test.js: (initialize_ExtensionsTest.InspectorTest.runExtensionTests):
  • http/tests/inspector/inspector-test2.js: (initialize_InspectorTest.InspectorTest.evaluateInPage):
  • http/tests/inspector/resource-har-conversion.html:
  • inspector/console-command-clear.html:
  • inspector/console-dir-global.html:

2011-01-18 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: make InjectedScriptAccess API a part of Web Inspector protocol.
https://bugs.webkit.org/show_bug.cgi?id=52652

Calls served by the InjectedScript should be first class protocol
citizens, not dispatched via single protocol message.

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/CodeGeneratorInspector.pm:
  • inspector/InjectedScript.cpp: (WebCore::InjectedScript::evaluate): (WebCore::InjectedScript::evaluateInCallFrame): (WebCore::InjectedScript::evaluateOnSelf): (WebCore::InjectedScript::getCompletions): (WebCore::InjectedScript::getProperties): (WebCore::InjectedScript::pushNodeToFrontend): (WebCore::InjectedScript::resolveNode): (WebCore::InjectedScript::getNodeProperties): (WebCore::InjectedScript::getNodePrototypes): (WebCore::InjectedScript::setPropertyValue): (WebCore::InjectedScript::makeCall):
  • inspector/InjectedScript.h:
  • inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::evaluate): (WebCore::InjectedScriptHost::evaluateInCallFrame): (WebCore::InjectedScriptHost::evaluateOnSelf): (WebCore::InjectedScriptHost::getCompletions): (WebCore::InjectedScriptHost::getProperties): (WebCore::InjectedScriptHost::pushNodeToFrontend): (WebCore::InjectedScriptHost::resolveNode): (WebCore::InjectedScriptHost::getNodeProperties): (WebCore::InjectedScriptHost::getNodePrototypes): (WebCore::InjectedScriptHost::setPropertyValue): (WebCore::InjectedScriptHost::injectedScriptForObjectId): (WebCore::InjectedScriptHost::injectedScriptForNodeId): (WebCore::InjectedScriptHost::injectedScriptForMainWorld):
  • inspector/InjectedScriptHost.h:
  • inspector/InjectedScriptSource.js: (.):
  • inspector/Inspector.idl:
  • inspector/InspectorController.cpp:
  • inspector/InspectorController.h:
  • inspector/InspectorValues.cpp: (WebCore::InspectorObject::getNumber):
  • inspector/InspectorValues.h:
  • inspector/front-end/AuditRules.js: (WebInspector.AuditRules.evaluateInTargetWindow):
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.completions): (WebInspector.ConsoleView.prototype.doEvalInWindow):
  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype._createTooltipForNode):
  • inspector/front-end/ExtensionPanel.js: (WebInspector.ExtensionWatchSidebarPane.prototype.setExpression):
  • inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer.prototype._onEvaluateOnInspectedPage):
  • inspector/front-end/InjectedScriptAccess.js: Removed.
  • inspector/front-end/PropertiesSidebarPane.js: (WebInspector.PropertiesSidebarPane.prototype.update.callback): (WebInspector.PropertiesSidebarPane.prototype.update):
  • inspector/front-end/RemoteObject.js: (WebInspector.RemoteObject.resolveNode): (WebInspector.RemoteObject.prototype.getProperties): (WebInspector.RemoteObject.prototype.setPropertyValue): (WebInspector.RemoteObject.prototype.pushNodeToFrontend):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.doEvalInCallFrame):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:

2011-01-18 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: make InjectedScriptAccess API a part of Web Inspector protocol.
https://bugs.webkit.org/show_bug.cgi?id=52652

Calls served by the InjectedScript should be first class protocol
citizens, not dispatched via single protocol message.

  • src/js/Tests.js:

Jan 18, 2011:

11:40 PM Changeset in webkit [76104] by antonm@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-01-18 Anton Muhin <antonm@chromium.org>

Reviewed by Adam Barth.

[v8] Minor cleanup: make 2nd argument of removeIfPresnt accept only a value type stored in the DOM map
https://bugs.webkit.org/show_bug.cgi?id=51683

Covered by the existing tests.

  • bindings/v8/DOMDataStore.cpp: (WebCore::DOMDataStore::weakNodeCallback): (WebCore::DOMDataStore::IntrusiveDOMWrapperMap::removeIfPresent):
  • bindings/v8/DOMDataStore.h:
  • bindings/v8/V8DOMMap.h: (WebCore::WeakReferenceMap::removeIfPresent):
11:12 PM Changeset in webkit [76103] by mjs@apple.com
  • 2 edits in trunk/Tools
  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Removed unncessary inculde of WKStringCF.h

Rubber stamped by Csaba Osztrogonac

10:09 PM Changeset in webkit [76102] by eric@webkit.org
  • 1 edit
    2 deletes in trunk/LayoutTests

2011-01-18 Eric Seidel <eric@webkit.org>

Unreviewed, rolling out r76084.
http://trac.webkit.org/changeset/76084
https://bugs.webkit.org/show_bug.cgi?id=52654

Crashes on the bots

  • fast/dom/Window/open-window-empty-url-expected.txt: Removed.
  • fast/dom/Window/open-window-empty-url.html: Removed.
9:15 PM Changeset in webkit [76101] by dpranke@chromium.org
  • 5 edits in trunk/Tools

2011-01-18 Dirk Pranke <dpranke@chromium.org>

Reviewed by Tony Chang.

new-run-webkit-tests: add a --build-directory command line argument

Official Google Chrome builds use a non-standard build directory
location. This patch adds a --build-directory argument that
allows that location to be specified on the command line. Only
Chromium-based builds will use this flag for now, but anyone can
in the future.

There are no unit tests for this since it's difficult to test
until mock filesystems are fully supported in the code. This was
tested by hand for now.

https://bugs.webkit.org/show_bug.cgi?id=52694

  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
8:33 PM Changeset in webkit [76100] by kbr@google.com
  • 4 edits in trunk/Source/JavaScriptCore

2011-01-18 Kenneth Russell <kbr@google.com>

Unreviewed, rolling out r76078.
http://trac.webkit.org/changeset/76078
https://bugs.webkit.org/show_bug.cgi?id=52668

Caused crashes of fast/canvas/webgl/constants.html,
fast/canvas/webgl/gl-enum-tests.html, and possibly other layout
test crashes in Release mode. WebGL crashes were observed with
"run-webkit-tests fast/canvas/webgl". It was necessary to run
multiple tests to provoke the crash.

  • interpreter/RegisterFile.h: (JSC::RegisterFile::markGlobals):
  • runtime/JSActivation.cpp: (JSC::JSActivation::markChildren):
  • runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::markChildren):
8:18 PM Changeset in webkit [76099] by morrita@google.com
  • 1 edit in trunk/Source/WebCore/ChangeLog

Added a reviewer line for the last checkin

8:11 PM Changeset in webkit [76098] by morrita@google.com
  • 11 edits
    1 add in trunk/Source/WebCore

2011-01-18 MORITA Hajime <morrita@google.com>

Refactoring: EventHandler::handleTextInputEvent should accept an enum instead of bools.
https://bugs.webkit.org/show_bug.cgi?id=52608

No new tests. no behavioral change.

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/TextEvent.cpp: (WebCore::TextEvent::create): (WebCore::TextEvent::createForDrop): (WebCore::TextEvent::TextEvent):
  • dom/TextEvent.h: (WebCore::TextEvent::isLineBreak): (WebCore::TextEvent::isBackTab): (WebCore::TextEvent::isPaste): (WebCore::TextEvent::isDrop):
  • dom/TextEventInputType.h: Added. Extracted from TextEvent::TextInputType.
  • editing/EditorCommand.cpp: (WebCore::executeInsertBacktab): (WebCore::executeInsertLineBreak): (WebCore::executeInsertNewline): (WebCore::executeInsertTab):
  • page/EventHandler.cpp: (WebCore::EventHandler::handleTextInputEvent):
  • page/EventHandler.h:
8:08 PM Changeset in webkit [76097] by mjs@apple.com
  • 4 edits in trunk/LayoutTests

2011-01-18 Maciej Stachowiak <mjs@apple.com>

Reviewed by Sam Weinig.

Skip (and in a few cases fix) tests for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=52698

  • editing/pasteboard/copy-null-characters.html: Make this test fail in a more obvious way when it fails.
  • fast/events/scroll-event-does-not-bubble.html: Make this test properly handle the fact that scroll events are async. The job was half-done before.
  • platform/mac-wk2/Skipped: Skip!
7:56 PM Changeset in webkit [76096] by mjs@apple.com
  • 2 edits in trunk/Tools

Not reviewed. Bot fix.

Remove an inadvertently committed debugging print.

  • DumpRenderTree/mac/LayoutTestControllerMac.mm:

(LayoutTestController::notifyDone):

7:55 PM Changeset in webkit [76095] by kbr@google.com
  • 3 edits in trunk/Source/ThirdParty/ANGLE

2011-01-18 Kenneth Russell <kbr@google.com>

Unreviewed, Leopard build fix. Remove flex/bison targets for GLSL
grammar because the generated sources are already checked in.

  • ANGLE.xcodeproj/project.pbxproj:
  • src/build_angle.xcodeproj/project.pbxproj:
7:30 PM Changeset in webkit [76094] by mjs@apple.com
  • 5 edits in trunk/LayoutTests

Not reviewed.

Revert inadvertantly committed test changes.

  • editing/pasteboard/copy-null-characters.html:
  • fast/events/scroll-event-does-not-bubble.html:
  • platform/mac-wk2/Skipped:
  • transitions/remove-transition-style.html:
7:23 PM Changeset in webkit [76093] by kbr@google.com
  • 2 edits in trunk/Source/ThirdParty/ANGLE

2011-01-18 Kenneth Russell <kbr@google.com>

Unreviewed, release build fix. Explicitly cast away const.

  • src/compiler/preprocessor/scanner.c: (ScanFromString):
7:16 PM Changeset in webkit [76092] by mjs@apple.com
  • 14 edits in trunk

2011-01-18 Maciej Stachowiak <mjs@apple.com>

Reviewed by Sam Weinig.

WebKitTestRunner should track loading more like DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=52692

Change load tracking to track the current top loading frame, in the manner of DumpRenderTree.
This makes some tests that call notifyDone multiple times pass.


  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::InjectedBundle): (WTR::InjectedBundle::done):
  • WebKitTestRunner/InjectedBundle/InjectedBundle.h: (WTR::InjectedBundle::topLoadingFrame): (WTR::InjectedBundle::setTopLoadingFrame):
  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::InjectedBundlePage): (WTR::InjectedBundlePage::stopLoading): (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame): (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame): (WTR::InjectedBundlePage::didFinishLoadForFrame): (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::notifyDone):
  • WebKitTestRunner/TestController.cpp: (WTR::TestController::didReceiveMessageFromInjectedBundle):

2011-01-18 Maciej Stachowiak <mjs@apple.com>

Reviewed by Sam Weinig.

WebKitTestRunner should track loading more like DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=52692


Relax the message check in didSaveFrameToPageCache a bit more, since
layout tests were still hitting the old one.

  • UIProcess/WebPageProxy.cpp: (WebKit::isDisconnectedFrame): (WebKit::WebPageProxy::didSaveFrameToPageCache):
7:00 PM Changeset in webkit [76091] by kbr@google.com
  • 77 edits
    21 adds
    5 deletes in trunk/Source

2011-01-18 Ben Vanik <ben.vanik@gmail.com>

Reviewed by Kenneth Russell.

Updating ANGLE in WebKit to r533.
https://bugs.webkit.org/show_bug.cgi?id=47194

  • platform/graphics/ANGLEWebKitBridge.cpp: (WebCore::ANGLEWebKitBridge::ANGLEWebKitBridge): (WebCore::ANGLEWebKitBridge::~ANGLEWebKitBridge): (WebCore::ANGLEWebKitBridge::validateShaderSource): Update to new ANGLE API for shader validation.
  • platform/graphics/ANGLEWebKitBridge.h: (WebCore::ANGLEWebKitBridge::setResources): Renaming types to new names.
  • platform/graphics/mac/GraphicsContext3DMac.mm: (WebCore::GraphicsContext3D::GraphicsContext3D): Initialize ANGLEResources with ANGLE init call to prevent uninitialized variables.

2011-01-18 Ben Vanik <ben.vanik@gmail.com>

Reviewed by Kenneth Russell.

Updating ANGLE in WebKit to r533.
https://bugs.webkit.org/show_bug.cgi?id=47194

  • ANGLE.xcodeproj/project.pbxproj:
  • include/GLSLANG/ShaderLang.h:
  • src/common/debug.cpp: (gl::trace):
  • src/common/debug.h:
  • src/compiler/CodeGenGLSL.cpp: (ConstructCompiler):
  • src/compiler/CodeGenHLSL.cpp: (ConstructCompiler):
  • src/compiler/Common.h: (EncodeSourceLoc): (DecodeSourceLoc):
  • src/compiler/Compiler.cpp: Added. (TShHandleBase::TShHandleBase): (TShHandleBase::~TShHandleBase): (TCompiler::TCompiler): (TCompiler::~TCompiler): (TCompiler::Init): (TCompiler::compile): (TCompiler::InitBuiltInSymbolTable): (TCompiler::clearResults): (TCompiler::validateLimitations): (TCompiler::collectAttribsUniforms):
  • src/compiler/ExtensionBehavior.h: Added.
  • src/compiler/InfoSink.cpp: (TInfoSinkBase::location):
  • src/compiler/InfoSink.h: (TInfoSinkBase::size):
  • src/compiler/Initialize.cpp: (BuiltInFunctionsCommon): (BuiltInFunctionsVertex): (BuiltInFunctionsFragment): (StandardUniforms): (DefaultPrecisionVertex): (DefaultPrecisionFragment): (BuiltInConstants): (TBuiltIns::initialize): (IdentifyBuiltIns): (InitExtensionBehavior):
  • src/compiler/Initialize.h:
  • src/compiler/IntermTraverse.cpp: (TIntermLoop::traverse):
  • src/compiler/Intermediate.cpp: (getOperatorString): (TIntermediate::addBinaryMath): (TIntermediate::addLoop): (TIntermediate::postProcess): (TIntermBinary::promote):
  • src/compiler/OutputGLSL.cpp: (TOutputGLSL::visitUnary): (TOutputGLSL::visitLoop):
  • src/compiler/OutputHLSL.cpp: (sh::OutputHLSL::OutputHLSL): (sh::OutputHLSL::header): (sh::OutputHLSL::visitBinary): (sh::OutputHLSL::visitUnary): (sh::OutputHLSL::visitAggregate): (sh::OutputHLSL::visitLoop): (sh::OutputHLSL::handleExcessiveLoop): (sh::OutputHLSL::argumentString):
  • src/compiler/OutputHLSL.h:
  • src/compiler/ParseHelper.cpp: (ReportInfo): (DefineExtensionMacros): (TParseContext::error): (TParseContext::warning): (TParseContext::reservedErrorCheck): (TParseContext::constructorErrorCheck): (TParseContext::arrayQualifierErrorCheck): (TParseContext::extensionErrorCheck): (TParseContext::areAllChildConst): (PaParseStrings):
  • src/compiler/ParseHelper.h: (TParseContext::TParseContext):
  • src/compiler/PoolAlloc.cpp: (InitializeGlobalPools): (FreeGlobalPools): (SetGlobalPoolAllocator): (TPoolAllocator::TPoolAllocator): (TPoolAllocator::~TPoolAllocator): (TAllocation::checkAllocList):
  • src/compiler/PoolAlloc.h:
  • src/compiler/SearchSymbol.cpp: Added. (sh::SearchSymbol::SearchSymbol): (sh::SearchSymbol::traverse): (sh::SearchSymbol::visitSymbol): (sh::SearchSymbol::foundMatch):
  • src/compiler/SearchSymbol.h: Added.
  • src/compiler/ShHandle.h: (TCompiler::getAsCompiler): (TCompiler::getInfoSink): (TCompiler::getAttribs): (TCompiler::getUniforms): (TCompiler::getShaderType): (TCompiler::getShaderSpec):
  • src/compiler/ShaderLang.cpp: (getVariableMaxLength): (getVariableInfo): (ShInitBuiltInResources): (ShConstructCompiler): (ShCompile): (ShGetInfo): (ShGetInfoLog): (ShGetObjectCode): (ShGetActiveAttrib): (ShGetActiveUniform):
  • src/compiler/SymbolTable.cpp: (TSymbolTableLevel::relateToExtension):
  • src/compiler/SymbolTable.h: (TVariable::shareConstPointer): (TFunction::relateToExtension): (TFunction::getExtension): (TFunction::getParamCount): (TFunction::getParam): (TSymbolTable::getGlobalLevel): (TSymbolTable::relateToOperator): (TSymbolTable::relateToExtension):
  • src/compiler/TranslatorGLSL.cpp: (writeVersion): (TranslatorGLSL::TranslatorGLSL): (TranslatorGLSL::translate):
  • src/compiler/TranslatorGLSL.h:
  • src/compiler/TranslatorHLSL.cpp: (TranslatorHLSL::TranslatorHLSL): (TranslatorHLSL::translate):
  • src/compiler/TranslatorHLSL.h:
  • src/compiler/Types.h: (TType::TType):
  • src/compiler/UnfoldSelect.cpp: (sh::UnfoldSelect::visitSelection):
  • src/compiler/UnfoldSelect.h:
  • src/compiler/ValidateLimitations.cpp: Added. (ValidateLimitations::ValidateLimitations): (ValidateLimitations::visitSymbol): (ValidateLimitations::visitConstantUnion): (ValidateLimitations::visitBinary): (ValidateLimitations::visitUnary): (ValidateLimitations::visitSelection): (ValidateLimitations::visitAggregate): (ValidateLimitations::visitLoop): (ValidateLimitations::visitBranch): (ValidateLimitations::error): (ValidateLimitations::withinLoopBody): (ValidateLimitations::isLoopIndex): (ValidateLimitations::validateLoopType): (ValidateLimitations::validateForLoopHeader): (ValidateLimitations::validateForLoopInit): (ValidateLimitations::validateForLoopCond): (ValidateLimitations::validateForLoopExpr): (ValidateLimitations::validateFunctionCall): (ValidateLimitations::validateOperation): (ValidateLimitations::isConstExpr): (ValidateLimitations::isConstIndexExpr): (ValidateLimitations::validateIndexing):
  • src/compiler/ValidateLimitations.h: Added. (ValidateLimitations::numErrors):
  • src/compiler/VariableInfo.cpp: Added. (arrayBrackets): (getVariableDataType): (getVariableInfo): (getBuiltInVariableInfo): (getUserDefinedVariableInfo): (CollectAttribsUniforms::CollectAttribsUniforms): (CollectAttribsUniforms::visitSymbol): (CollectAttribsUniforms::visitConstantUnion): (CollectAttribsUniforms::visitBinary): (CollectAttribsUniforms::visitUnary): (CollectAttribsUniforms::visitSelection): (CollectAttribsUniforms::visitAggregate): (CollectAttribsUniforms::visitLoop): (CollectAttribsUniforms::visitBranch):
  • src/compiler/VariableInfo.h: Added.
  • src/compiler/VersionGLSL.cpp: Added. (TVersionGLSL::TVersionGLSL): (TVersionGLSL::visitSymbol): (TVersionGLSL::visitConstantUnion): (TVersionGLSL::visitBinary): (TVersionGLSL::visitUnary): (TVersionGLSL::visitSelection): (TVersionGLSL::visitAggregate): (TVersionGLSL::visitLoop): (TVersionGLSL::visitBranch): (TVersionGLSL::updateVersion):
  • src/compiler/VersionGLSL.h: Added. (TVersionGLSL::getVersion):
  • src/compiler/generate_glslang_lexer.sh: Added.
  • src/compiler/generate_glslang_parser.sh: Added.
  • src/compiler/glslang.h: Added.
  • src/compiler/glslang.l:
  • src/compiler/glslang.y:
  • src/compiler/glslang_lex.cpp: Added. (yy_get_next_buffer): (yy_get_previous_state): (yy_try_NUL_trans): (input): (yyrestart): (yy_switch_to_buffer): (yy_load_buffer_state): (yy_create_buffer): (yy_delete_buffer): (yy_init_buffer): (yy_flush_buffer): (yypush_buffer_state): (yypop_buffer_state): (yyensure_buffer_stack): (yy_scan_buffer): (yy_scan_string): (yy_scan_bytes): (yy_push_state): (yy_pop_state): (yy_top_state): (yy_fatal_error): (yyget_extra): (yyget_lineno): (yyget_column): (yyget_in): (yyget_out): (yyget_leng): (yyget_text): (yyset_extra): (yyset_lineno): (yyset_column): (yyset_in): (yyset_out): (yyget_debug): (yyset_debug): (yyget_lval): (yyset_lval): (yylex_init): (yylex_init_extra): (yy_init_globals): (yylex_destroy): (yy_flex_strncpy): (yy_flex_strlen): (yyalloc): (yyrealloc): (yyfree): (string_input): (check_type): (reserved_word): (yyerror): (glslang_initialize): (glslang_finalize): (glslang_scan):
  • src/compiler/glslang_tab.cpp: Added. (yytnamerr): (yysyntax_error): (glslang_parse):
  • src/compiler/glslang_tab.h: Added.
  • src/compiler/intermOut.cpp: (TOutputTraverser::TOutputTraverser): (OutputTreeText): (TOutputTraverser::visitSymbol): (TOutputTraverser::visitBinary): (TOutputTraverser::visitUnary): (TOutputTraverser::visitAggregate): (TOutputTraverser::visitSelection): (TOutputTraverser::visitConstantUnion): (TOutputTraverser::visitLoop): (TOutputTraverser::visitBranch): (TIntermediate::outputTree):
  • src/compiler/intermediate.h: (TIntermLoop::TIntermLoop): (TIntermLoop::getType): (TIntermLoop::getInit): (TIntermLoop::getCondition): (TIntermLoop::getExpression): (TIntermLoop::getBody):
  • src/compiler/localintermediate.h:
  • src/compiler/osinclude.h: (OS_GetTLSValue):
  • src/compiler/ossource_nspr.cpp: Added. (OS_AllocTLSIndex): (OS_SetTLSValue): (OS_FreeTLSIndex):
  • src/compiler/preprocessor/compile.h:
  • src/compiler/preprocessor/cpp.c: (CPPdefine): (CPPelse): (CPPif): (CPPifdef): (CPPerror): (CPPextension): (readCPPline):
  • src/compiler/preprocessor/preprocess.h:
  • src/compiler/preprocessor/scanner.c: (str_getch): (str_ungetch): (ScanFromString): (lFloatConst): (byte_scan): (yylex_CPP): (check_EOF):
  • src/compiler/preprocessor/scanner.h:
  • src/compiler/preprocessor/tokens.c: (RecordToken): (ReadToken):
  • src/compiler/tools: Removed.
  • src/compiler/unistd.h: Removed.
  • src/compiler/util.cpp: Added. (atof_dot):
  • src/compiler/util.h: Added.
  • src/libEGL/Config.cpp: (egl::Config::set):
  • src/libEGL/Display.cpp: (egl::Display::Display): (egl::Display::initialize): (egl::Display::terminate): (egl::Display::createDevice): (egl::Display::resetDevice): (egl::Display::createContext): (egl::Display::destroyContext): (egl::Display::getMinSwapInterval): (egl::Display::getMaxSwapInterval): (egl::Display::getDevice): (egl::Display::getFloatTextureSupport): (egl::Display::getHalfFloatTextureSupport): (egl::Display::getLuminanceTextureSupport): (egl::Display::getLuminanceAlphaTextureSupport): (egl::Display::getBufferPool): (egl::Display::getEventQuerySupport): (egl::Display::getDefaultPresentParameters):
  • src/libEGL/Display.h:
  • src/libEGL/Surface.cpp: (egl::Surface::Surface): (egl::Surface::~Surface): (egl::Surface::release): (egl::Surface::resetSwapChain): (egl::Surface::writeRecordableFlipState): (egl::Surface::restoreState): (egl::SurfaceWindowProc): (egl::Surface::subclassWindow): (egl::Surface::unsubclassWindow): (egl::Surface::checkForOutOfDateSwapChain): (egl::Surface::convertInterval): (egl::Surface::swap): (egl::Surface::getRenderTarget): (egl::Surface::setSwapInterval):
  • src/libEGL/Surface.h:
  • src/libEGL/libEGL.cpp:
  • src/libGLESv2/Blit.cpp: (gl::Blit::copySurfaceToTexture): (gl::Blit::setCommonBlitState):
  • src/libGLESv2/Buffer.cpp: (gl::Buffer::Buffer): (gl::Buffer::~Buffer): (gl::Buffer::bufferData): (gl::Buffer::bufferSubData): (gl::Buffer::getVertexBuffer): (gl::Buffer::getIndexBuffer): (gl::Buffer::invalidateStaticData):
  • src/libGLESv2/Buffer.h:
  • src/libGLESv2/Context.cpp: (gl::Context::Context): (gl::Context::~Context): (gl::Context::makeCurrent): (gl::Context::markAllStateDirty): (gl::Context::setFragmentShaderDerivativeHint): (gl::Context::setEnableVertexAttribArray): (gl::Context::getVertexAttribState): (gl::Context::getVertexAttributes): (gl::Context::createFence): (gl::Context::deleteFence): (gl::Context::bindTexture2D): (gl::Context::bindTextureCubeMap): (gl::Context::getFence): (gl::Context::getTexture2D): (gl::Context::getTextureCubeMap): (gl::Context::getSamplerTexture): (gl::Context::getBooleanv): (gl::Context::getIntegerv): (gl::Context::getQueryParameterInfo): (gl::Context::applyRenderTarget): (gl::Context::applyState): (gl::Context::lookupAttributeMapping): (gl::Context::applyVertexBuffer): (gl::Context::applyIndexBuffer): (gl::Context::readPixels): (gl::Context::clear): (gl::Context::drawArrays): (gl::Context::drawElements): (gl::Context::finish): (gl::Context::drawClosingLine): (gl::Context::getMaximumVaryingVectors): (gl::Context::getMaximumFragmentUniformVectors): (gl::Context::supportsEventQueries): (gl::Context::supportsFloatTextures): (gl::Context::supportsFloatLinearFilter): (gl::Context::supportsFloatRenderableTextures): (gl::Context::supportsHalfFloatTextures): (gl::Context::supportsHalfFloatLinearFilter): (gl::Context::supportsHalfFloatRenderableTextures): (gl::Context::getMaximumRenderbufferDimension): (gl::Context::getMaximumTextureDimension): (gl::Context::getMaximumCubeTextureDimension): (gl::Context::getMaximumTextureLevel): (gl::Context::supportsLuminanceTextures): (gl::Context::supportsLuminanceAlphaTextures): (gl::Context::supports32bitIndices): (gl::Context::getIncompleteTexture): (gl::Context::setVertexAttrib): (gl::Context::initExtensionString): (gl::Context::blitFramebuffer):
  • src/libGLESv2/Context.h: (gl::VertexAttribute::VertexAttribute): (gl::VertexAttribute::typeSize): (gl::VertexAttribute::stride):
  • src/libGLESv2/Fence.cpp: Added. (gl::Fence::Fence): (gl::Fence::~Fence): (gl::Fence::isFence): (gl::Fence::setFence): (gl::Fence::testFence): (gl::Fence::finishFence): (gl::Fence::getFenceiv):
  • src/libGLESv2/Fence.h: Added.
  • src/libGLESv2/Framebuffer.cpp: (gl::Framebuffer::completeness): (gl::DefaultFramebuffer::DefaultFramebuffer): (gl::DefaultFramebuffer::completeness):
  • src/libGLESv2/Program.cpp: (gl::Program::Program): (gl::Program::getSamplerMapping): (gl::Program::getUniformLocation): (gl::Program::setUniform1iv): (gl::Program::applyUniforms): (gl::Program::packVaryings): (gl::Program::linkVaryings): (gl::Program::link): (gl::Program::defineUniform): (gl::Program::createUniform): (gl::Program::applyUniform1iv): (gl::Program::resetInfoLog): (gl::Program::unlink): (gl::Program::getActiveAttribute): (gl::Program::getActiveUniform): (gl::Program::getDxDepthRangeLocation):
  • src/libGLESv2/Program.h:
  • src/libGLESv2/RefCountObject.cpp: (gl::RefCountObject::~RefCountObject):
  • src/libGLESv2/Renderbuffer.cpp: (gl::RenderbufferStorage::RenderbufferStorage): (gl::RenderbufferStorage::isFloatingPoint): (gl::Colorbuffer::Colorbuffer): (gl::DepthStencilbuffer::DepthStencilbuffer):
  • src/libGLESv2/Renderbuffer.h:
  • src/libGLESv2/Shader.cpp: (gl::Shader::Shader): (gl::Shader::parseVaryings): (gl::Shader::compileToHLSL): (gl::VertexShader::parseAttributes):
  • src/libGLESv2/Texture.cpp: (gl::Texture::Texture): (gl::Texture::isFloatingPoint): (gl::Texture::isRenderableFormat): (gl::Texture::selectFormat): (gl::Texture::loadImageData): (gl::Texture::loadAlphaFloatImageData): (gl::Texture::loadAlphaHalfFloatImageData): (gl::Texture::loadLuminanceImageData): (gl::Texture::loadLuminanceFloatImageData): (gl::Texture::loadLuminanceHalfFloatImageData): (gl::Texture::loadLuminanceAlphaImageData): (gl::Texture::loadLuminanceAlphaFloatImageData): (gl::Texture::loadLuminanceAlphaHalfFloatImageData): (gl::Texture::loadRGBFloatImageData): (gl::Texture::loadRGBHalfFloatImageData): (gl::Texture::loadRGBAFloatImageData): (gl::Texture::loadRGBAHalfFloatImageData): (gl::Texture::createSurface): (gl::Texture::setImage): (gl::Texture::setCompressedImage): (gl::Texture::subImage): (gl::Texture::subImageCompressed): (gl::Texture::copyNonRenderable): (gl::Texture::getD3DFormat): (gl::Texture::isRenderable): (gl::Texture2D::Texture2D): (gl::Texture2D::~Texture2D): (gl::Texture2D::redefineTexture): (gl::Texture2D::setImage): (gl::Texture2D::setCompressedImage): (gl::Texture2D::copyImage): (gl::Texture2D::copySubImage): (gl::Texture2D::isComplete): (gl::Texture2D::createTexture): (gl::Texture2D::convertToRenderTarget): (gl::Texture2D::generateMipmaps): (gl::Texture2D::getColorbuffer): (gl::Texture2D::getRenderTarget): (gl::TextureCubeMap::TextureCubeMap): (gl::TextureCubeMap::~TextureCubeMap): (gl::TextureCubeMap::subImage): (gl::TextureCubeMap::subImageCompressed): (gl::TextureCubeMap::isComplete): (gl::TextureCubeMap::createTexture): (gl::TextureCubeMap::convertToRenderTarget): (gl::TextureCubeMap::redefineTexture): (gl::TextureCubeMap::copyImage): (gl::TextureCubeMap::copySubImage): (gl::TextureCubeMap::generateMipmaps): (gl::TextureCubeMap::getColorbuffer): (gl::TextureCubeMap::getRenderTarget): (gl::Texture::TextureColorbufferProxy::TextureColorbufferProxy): (gl::Texture::TextureColorbufferProxy::isFloatingPoint):
  • src/libGLESv2/Texture.h:
  • src/libGLESv2/geometry/IndexDataManager.cpp: (gl::IndexDataManager::IndexDataManager): (gl::IndexDataManager::~IndexDataManager): (gl::convertIndices): (gl::computeRange): (gl::IndexDataManager::prepareIndexData): (gl::IndexDataManager::indexSize): (gl::IndexDataManager::typeSize): (gl::IndexBuffer::IndexBuffer): (gl::IndexBuffer::~IndexBuffer): (gl::IndexBuffer::getBuffer): (gl::IndexBuffer::unmap): (gl::StreamingIndexBuffer::StreamingIndexBuffer): (gl::StreamingIndexBuffer::~StreamingIndexBuffer): (gl::StreamingIndexBuffer::map): (gl::StreamingIndexBuffer::reserveSpace): (gl::StaticIndexBuffer::StaticIndexBuffer): (gl::StaticIndexBuffer::~StaticIndexBuffer): (gl::StaticIndexBuffer::map): (gl::StaticIndexBuffer::reserveSpace): (gl::StaticIndexBuffer::lookupType): (gl::StaticIndexBuffer::lookupRange): (gl::StaticIndexBuffer::addRange):
  • src/libGLESv2/geometry/IndexDataManager.h: (gl::IndexBuffer::size):
  • src/libGLESv2/geometry/VertexDataManager.cpp: (gl::VertexDataManager::VertexDataManager): (gl::VertexDataManager::~VertexDataManager): (gl::VertexDataManager::writeAttributeData): (gl::VertexDataManager::prepareVertexData): (gl::VertexDataManager::spaceRequired): (gl::VertexDataManager::checkVertexCaps): (gl::VertexDataManager::typeIndex): (gl::VertexDataManager::setupAttributes): (gl::VertexBuffer::VertexBuffer): (gl::VertexBuffer::~VertexBuffer): (gl::VertexBuffer::unmap): (gl::VertexBuffer::getBuffer): (gl::ConstantVertexBuffer::ConstantVertexBuffer): (gl::ConstantVertexBuffer::~ConstantVertexBuffer): (gl::ArrayVertexBuffer::ArrayVertexBuffer): (gl::ArrayVertexBuffer::~ArrayVertexBuffer): (gl::ArrayVertexBuffer::addRequiredSpace): (gl::ArrayVertexBuffer::addRequiredSpaceFor): (gl::StreamingVertexBuffer::StreamingVertexBuffer): (gl::StreamingVertexBuffer::~StreamingVertexBuffer): (gl::StreamingVertexBuffer::map): (gl::StreamingVertexBuffer::reserveRequiredSpace): (gl::StaticVertexBuffer::StaticVertexBuffer): (gl::StaticVertexBuffer::~StaticVertexBuffer): (gl::StaticVertexBuffer::map): (gl::StaticVertexBuffer::reserveRequiredSpace): (gl::StaticVertexBuffer::lookupAttribute): (gl::VertexDataManager::formatConverter):
  • src/libGLESv2/geometry/VertexDataManager.h: (gl::ArrayVertexBuffer::size): (gl::VertexDataManager::dirtyCurrentValue):
  • src/libGLESv2/geometry/backend.cpp: Removed.
  • src/libGLESv2/geometry/backend.h: Removed.
  • src/libGLESv2/geometry/dx9.cpp: Removed.
  • src/libGLESv2/geometry/dx9.h: Removed.
  • src/libGLESv2/libGLESv2.cpp:
  • src/libGLESv2/libGLESv2.def:
  • src/libGLESv2/libGLESv2.vcproj:
  • src/libGLESv2/utilities.cpp: (gl::UniformComponentCount): (gl::UniformComponentType): (gl::ComputePixelSize): (gl::CheckTextureFormatType): (gl::IsColorRenderable): (gl::IsDepthRenderable): (gl::IsStencilRenderable): (es2dx::GetAlphaSize): (es2dx::GetRedSize): (es2dx::GetGreenSize): (es2dx::GetBlueSize): (es2dx::GetDepthSize): (es2dx::ConvertPrimitiveType): (dx2es::ConvertBackBufferFormat): (dx2es::ConvertDepthStencilFormat):
  • src/libGLESv2/utilities.h:
6:37 PM Changeset in webkit [76090] by oliver@apple.com
  • 6 edits in trunk

2011-01-18 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

[jsfunfuzz] Assertion asking activation for arguments when arguments is overridden
https://bugs.webkit.org/show_bug.cgi?id=52690

Add a few more tests.

  • fast/js/function-dot-arguments-expected.txt:
  • fast/js/script-tests/function-dot-arguments.js: (overwroteArgumentsInDynamicScope1): (overwroteArgumentsInDynamicScope2): (overwroteArgumentsInDynamicScope3):

2011-01-18 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

[jsfunfuzz] Assertion asking activation for arguments when arguments is overridden
https://bugs.webkit.org/show_bug.cgi?id=52690

Clean up code to retrieve arguments from activation and function objects.
Remove the incorrect assertion from JSActivation's argumentsGetter.

  • interpreter/Interpreter.cpp: (JSC::Interpreter::retrieveArguments):
  • runtime/JSActivation.cpp: (JSC::JSActivation::argumentsGetter):
5:46 PM Changeset in webkit [76089] by beidson@apple.com
  • 2 edits in trunk/Source/WebKit2

<rdar://problem/8860833> and https://bugs.webkit.org/show_bug.cgi?id=52599
UIProcess crash in WebPageProxy::reattachToWebProcess when web process crashes with a new tab/window.

Reviewed by Darin Adler.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::reattachToWebProcessWithItem): Null check item *both* places it is used.

5:44 PM Changeset in webkit [76088] by dimich@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

[Chromium] Not reviewed, adding pixel expectations for new test.

  • platform/chromium-mac/fast/css/background-clip-values-expected.checksum: Added.
  • platform/chromium-mac/fast/css/background-clip-values-expected.png: Added.
5:37 PM Changeset in webkit [76087] by beidson@apple.com
  • 10 edits in trunk/Source/WebKit2

<rdar://problem/8752200> and https://bugs.webkit.org/show_bug.cgi?id=52664
Need WebKit2 API to asynchronously get the resource data for a URL

Reviewed by Maciej Stachowiak.

Rename WKFrameGetMainResourceDataFunction to WKFrameGetResourceDataFunction, and add
new API to get a resource by URL:

  • UIProcess/API/C/WKFrame.cpp:

(WKFrameGetMainResourceData):
(WKFrameGetResourceData):
(callGetResourceDataBlockAndDispose):
(WKFrameGetMainResourceData_b):
(WKFrameGetResourceData_b):

  • UIProcess/API/C/WKFrame.h:

Implement the new API in the UIProcess side:

  • UIProcess/WebFrameProxy.cpp:

(WebKit::WebFrameProxy::getResourceData):

  • UIProcess/WebFrameProxy.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::getResourceDataFromFrame):

  • UIProcess/WebPageProxy.h:

Have the WebProcess get the data and call back to the UIProcess:

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::getResourceDataFromFrame):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
5:30 PM Changeset in webkit [76086] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-01-18 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Make PageClientImpl::scrollView do hardware blitting
https://bugs.webkit.org/show_bug.cgi?id=52689

  • UIProcess/API/mac/PageClientImpl.mm: (WebKit::PageClientImpl::scrollView): Clip the scroll rect and scroll the view.
  • UIProcess/DrawingAreaProxyImpl.cpp: (WebKit::DrawingAreaProxyImpl::incorporateUpdate): Scroll before painting.
5:16 PM Changeset in webkit [76085] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-01-18 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler.

Artifacts when scrolling with new drawing area
https://bugs.webkit.org/show_bug.cgi?id=52682

  • WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::scroll): When scrolling, we want the intersection of the scroll rect and clip rect.
5:13 PM Changeset in webkit [76084] by jberlin@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Add a test that calling window.open with an empty URL does not trigger an assertion or
cause a crash.
https://bugs.webkit.org/show_bug.cgi?id=52654

Reviewed by Adam Roben.

  • fast/dom/Window/open-window-empty-url-expected.txt: Added.
  • fast/dom/Window/open-window-empty-url.html: Added.
5:10 PM Changeset in webkit [76083] by morrita@google.com
  • 23 edits
    2 adds in trunk/Source/WebCore

2011-01-18 MORITA Hajime <morrita@google.com>

Reviewed by Simon Fraser.

Refactoring: Extract RoundedIntRect class
https://bugs.webkit.org/show_bug.cgi?id=51664

RoundedIntRect is a pair of rect and four IntSize objects which represent
corner radii of the rectangle. IntSize is grouped into RoundedIntRect::Radii.
Now RenderStyle::getRoundedBorderFor() and RenderStyle::getRoundedInnerBorderWithBorderWidths()
return RoundedIntRect and GraphicsContext::addRoundedRectClip(), GraphicsContext::fillRoundedRect()
and other functions accept RoundedIntRect as an argument.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::addRoundedRectClip): (WebCore::GraphicsContext::clipOutRoundedRect): (WebCore::GraphicsContext::fillRoundedRect):
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/RoundedIntRect.cpp: Added. (WebCore::RoundedIntRect::Radii::isZero): (WebCore::RoundedIntRect::Radii::scale): (WebCore::RoundedIntRect::Radii::expand): (WebCore::RoundedIntRect::Radii::includeLogicalEdges): (WebCore::RoundedIntRect::Radii::excludeLogicalEdges): (WebCore::RoundedIntRect::RoundedIntRect): (WebCore::RoundedIntRect::includeLogicalEdges): (WebCore::RoundedIntRect::excludeLogicalEdges):
  • platform/graphics/RoundedIntRect.h: Added. (WebCore::RoundedIntRect::Radii::Radii): (WebCore::RoundedIntRect::Radii::setTopLeft): (WebCore::RoundedIntRect::Radii::setTopRight): (WebCore::RoundedIntRect::Radii::setBottomLeft): (WebCore::RoundedIntRect::Radii::setBottomRight): (WebCore::RoundedIntRect::Radii::topLeft): (WebCore::RoundedIntRect::Radii::topRight): (WebCore::RoundedIntRect::Radii::bottomLeft): (WebCore::RoundedIntRect::Radii::bottomRight): (WebCore::RoundedIntRect::Radii::expand): (WebCore::RoundedIntRect::Radii::shrink): (WebCore::RoundedIntRect::rect): (WebCore::RoundedIntRect::radii): (WebCore::RoundedIntRect::isRounded): (WebCore::RoundedIntRect::isEmpty): (WebCore::RoundedIntRect::setRect): (WebCore::RoundedIntRect::setRadii): (WebCore::RoundedIntRect::move): (WebCore::RoundedIntRect::inflate): (WebCore::RoundedIntRect::inflateWithRadii): (WebCore::RoundedIntRect::expandRadii): (WebCore::RoundedIntRect::shrinkRadii):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::pushContentsClip):
  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintFillLayerExtended): (WebCore::RenderBoxModelObject::paintBorder): (WebCore::RenderBoxModelObject::clipBorderSidePolygon): (WebCore::RenderBoxModelObject::paintBoxShadow):
  • rendering/RenderBoxModelObject.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::drawBoxSideFromPath):
  • rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::paint):
  • rendering/RenderThemeChromiumWin.cpp: (WebCore::RenderThemeChromiumWin::paintTextFieldInternal):
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintMenuListButtonGradients): (WebCore::RenderThemeMac::paintSliderTrack):
  • rendering/RenderThemeSafari.cpp: (WebCore::RenderThemeSafari::paintMenuListButtonGradients): (WebCore::RenderThemeSafari::paintSliderTrack):
  • rendering/RenderThemeWinCE.cpp: (WebCore::RenderThemeWinCE::paintSearchFieldCancelButton):
  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::paint):
  • rendering/style/BorderData.h:
  • rendering/style/RenderStyle.cpp: (WebCore::calcRadiiFor): (WebCore::calcConstraintScaleFor): (WebCore::RenderStyle::getRoundedBorderFor): (WebCore::RenderStyle::getRoundedInnerBorderWithBorderWidths):
  • rendering/style/RenderStyle.h: (WebCore::InheritedFlags::setBorderRadius):
4:30 PM Changeset in webkit [76082] by ojan@chromium.org
  • 3 edits in trunk/Websites/bugs.webkit.org

2011-01-18 Ojan Vafai <ojan@chromium.org>

Reviewed by Eric Seidel.

make file expansion use the file at the svn revision the diff was created at
https://bugs.webkit.org/show_bug.cgi?id=52650

This only works for patches created with SVN for now since the git
diff does not include SVN revision numbers in it.

  • PrettyPatch/PrettyPatch.rb:
  • code-review.js:
4:15 PM Changeset in webkit [76081] by mihaip@chromium.org
  • 2 edits in trunk/Tools

2011-01-18 Mihai Parparita <mihaip@chromium.org>

Reviewed by Kent Tamura.

[Chromium] NRWT looking for DRT binary in the wrong path on Mac
https://bugs.webkit.org/show_bug.cgi?id=52678

Update path now that WebKit is inside Source.

  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:
4:15 PM Changeset in webkit [76080] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-01-18 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler.

Use a CGLayer for the backing store when possible
https://bugs.webkit.org/show_bug.cgi?id=52679

  • UIProcess/mac/BackingStoreMac.mm: (WebKit::BackingStore::paint): If there is a layer, paint it into the given context.

(WebKit::BackingStore::backingStoreContext):
If we can get the containing window graphics context, use it to create a
CGLayer that we'll use for the backing store.

(WebKit::BackingStore::scroll):
Paint the layer into itself.

  • UIProcess/mac/WebPageProxyMac.mm: (WebKit::WebPageProxy::containingWindowGraphicsContext): Call the page client.
3:49 PM Changeset in webkit [76079] by robert@webkit.org
  • 7 edits in trunk

2011-01-18 Robert Hogan <robert@webkit.org>

Reviewed by Simon Hausmann.

[Qt] http/tests/incremental/slow-utf8-text.pl fails
https://bugs.webkit.org/show_bug.cgi?id=44282

  • platform/qt/Skipped:

2011-01-18 Robert Hogan <robert@webkit.org>

Reviewed by Simon Hausmann.

[Qt] http/tests/incremental/slow-utf8-text.pl fails
https://bugs.webkit.org/show_bug.cgi?id=44282

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::responseMimeType):
  • WebCoreSupport/DumpRenderTreeSupportQt.h:

2011-01-18 Robert Hogan <robert@webkit.org>

Reviewed by Simon Hausmann.

[Qt] http/tests/incremental/slow-utf8-text.pl fails
https://bugs.webkit.org/show_bug.cgi?id=44282

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::dump):
3:45 PM Changeset in webkit [76078] by ggaren@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

2011-01-18 Geoffrey Garen <ggaren@apple.com>

Reviewed by Darin Adler.

Removed RegisterFile::markGlobals because it was obtuse, and it
unnecessarily relied on conservative marking.
https://bugs.webkit.org/show_bug.cgi?id=52668

  • interpreter/RegisterFile.h: Removed markGlobals.
  • runtime/JSActivation.cpp: (JSC::JSActivation::markChildren): Added a comment explaning why some JSActivations don't always mark their registers arrays.
  • runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::markChildren): Instead of calling markGlobals, mark the registers array directly.
3:40 PM Changeset in webkit [76077] by andersca@apple.com
  • 5 edits in trunk/Source/WebKit2

2011-01-18 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Pass the web page proxy to BackingStore::create
https://bugs.webkit.org/show_bug.cgi?id=52673

  • UIProcess/BackingStore.cpp: (WebKit::BackingStore::create): Add WebPageProxy parameter.


(WebKit::BackingStore::BackingStore):
Add WebPageProxy parameter.

  • UIProcess/BackingStore.h: Add WebPageProxy member variable.
  • UIProcess/DrawingAreaProxyImpl.cpp: (WebKit::DrawingAreaProxyImpl::incorporateUpdate): Pass the web page proxy when creating the backing store.
  • UIProcess/mac/BackingStoreMac.mm: (WebKit::BackingStore::backingStoreContext): Set the default blend mode.
3:31 PM Changeset in webkit [76076] by msaboff@apple.com
  • 5 edits in trunk

2011-01-18 Michael Saboff <msaboff@apple.com>

Reviewed by Oliver Hunt.

<rdar://problem/8875432> Regression: Some text-only e-mails cause hang beneath RegExp::match (52540)
https://bugs.webkit.org/show_bug.cgi?id=52540
https://bugs.webkit.org/show_bug.cgi?id=52662

Directly use backtrack label with parentheses nested under a
non-capturing parentheses. Also linked current parentheses
tail code object for possible parens nested within a non-capturing
parentheses.

  • yarr/YarrJIT.cpp: (JSC::Yarr::YarrGenerator::BacktrackDestination::linkBacktrackToLabel): (JSC::Yarr::YarrGenerator::generateParenthesesSingle):

2011-01-18 Michael Saboff <msaboff@apple.com>

Reviewed by Oliver Hunt.

<rdar://problem/8875432> Regression: Some text-only e-mails cause hang beneath RegExp::match (52540)
https://bugs.webkit.org/show_bug.cgi?id=52540
https://bugs.webkit.org/show_bug.cgi?id=52662

New tests to check for proper linking of parentheses nested under
a non-capturing parentheses.

  • fast/regex/parentheses-expected.txt:
  • fast/regex/script-tests/parentheses.js:
3:27 PM Changeset in webkit [76075] by commit-queue@webkit.org
  • 4 edits in trunk/Source

2011-01-18 Victoria Kirst <vrk@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Adding support for YV16 video frame formats.
https://bugs.webkit.org/show_bug.cgi?id=52345

  • platform/graphics/chromium/VideoLayerChromium.cpp: (WebCore::VideoLayerChromium::determineTextureFormat): (WebCore::VideoLayerChromium::draw):

2011-01-18 Victoria Kirst <vrk@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Adding support for YV16 video frame formats.
https://bugs.webkit.org/show_bug.cgi?id=52345

  • src/VideoFrameChromiumImpl.cpp: (WebKit::VideoFrameChromiumImpl::requiredTextureSize):
3:24 PM Changeset in webkit [76074] by hyatt@apple.com
  • 3 edits
    4 adds in trunk

<rdar://problem/8479998> REGRESSION (r67660): broken button layout at devforums.apple.com

Reviewed by Dan Bernstein.

Exclude floating objects from shrinking to avoid floats. They should never do this. Timing-related bugs could
occur as a result of this mistake, and the change to rewrite pagination to defer layout of floats until they
got encountered on the correct line exposed this issue.

Source/WebCore:

Added /fast/block/float/float-overflow-hidden-containing-block-width.html.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::shrinkToAvoidFloats):

LayoutTests:

Added /fast/block/float/float-overflow-hidden-containing-block-width.html.

  • fast/block/float/float-overflow-hidden-containing-block-width.html: Added.
  • platform/mac/fast/block/float/float-overflow-hidden-containing-block-width-expected.checksum: Added.
  • platform/mac/fast/block/float/float-overflow-hidden-containing-block-width-expected.png: Added.
  • platform/mac/fast/block/float/float-overflow-hidden-containing-block-width-expected.txt: Added.
3:21 PM Changeset in webkit [76073] by dpranke@chromium.org
  • 2 edits in trunk/Tools

2011-01-18 Dirk Pranke <dpranke@chromium.org>

Reviewed by Mihai Parparita.

Fix a small race condition that could cause the unit tests for
new-run-webkit-tests to fail in a multithreaded environment.
There was a small window in the code where one thread would
check to see if a thread had raised an exception, do something,
and then check to see if the thread was alive. If the other
thread raised an exception and exited in between these two
steps, the exception would be lost. Flipping the order of the
two checks fixes the race, since we will now always check for an
exception on the thread before exiting.

https://bugs.webkit.org/show_bug.cgi?id=51579

  • Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
3:08 PM Changeset in webkit [76072] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-01-18 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler.

Factor code to create the backing store bitmap context out into a new function
https://bugs.webkit.org/show_bug.cgi?id=52670

  • UIProcess/BackingStore.h:
  • UIProcess/mac/BackingStoreMac.mm: (WebKit::BackingStore::backingStoreContext): Create the backing store context.

(WebKit::BackingStore::incorporateUpdate):
Call backingStoreContext.

(WebKit::BackingStore::scroll):
Assert that the context is not null.

2:59 PM Changeset in webkit [76071] by eric@webkit.org
  • 6 edits in trunk/Tools

2011-01-18 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

commit-queue dies when test archiving fails
https://bugs.webkit.org/show_bug.cgi?id=52617

I looked at the machine and it had 10 archives already
thus find_unused_name was returning None. I've upped
the limit to 100 (per bug) and tested the case where
find_unused_name returns None (making archive return None).

  • Scripts/webkitpy/common/system/workspace.py:
  • Scripts/webkitpy/common/system/workspace_unittest.py:
  • Scripts/webkitpy/tool/bot/commitqueuetask.py:
  • Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
  • Scripts/webkitpy/tool/commands/queues.py:
2:56 PM Changeset in webkit [76070] by dimich@chromium.org
  • 5 edits
    2 adds in trunk/LayoutTests

[Chromium] Not reviewed, updated expectations for tests
affected by http://trac.webkit.org/changeset/76047

  • platform/chromium-mac/fast/backgrounds/size/backgroundSize22-expected.checksum:
  • platform/chromium-mac/fast/backgrounds/size/backgroundSize22-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize22-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize22-expected.png:
  • platform/chromium-win/fast/css/background-clip-values-expected.checksum: Added.
  • platform/chromium-win/fast/css/background-clip-values-expected.png: Added.
2:55 PM Changeset in webkit [76069] by andersca@apple.com
  • 5 edits in trunk/Source/WebKit2

2011-01-18 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Add PageClientImpl::containingWindowGraphicsContext
https://bugs.webkit.org/show_bug.cgi?id=52666

  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm: (WebKit::PageClientImpl::containingWindowGraphicsContext):
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.h:
2:53 PM Changeset in webkit [76068] by dbates@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-01-18 Daniel Bates <dbates@rim.com>

Reviewed by Gavin Barraclough.

Only use moving memory model assumption in ExecutableAllocator::intializePageSize() for Symbian OS
https://bugs.webkit.org/show_bug.cgi?id=52517

Patch by David Tapuska

Currently, we compile code with respect to the Symbian-specific moving memory model
assumption for all ARMv5 or lower architectures. Instead, we should only compile
such code when building for Symbian OS on those architectures because this model
is Symbian-specific.

  • jit/ExecutableAllocator.cpp: (JSC::ExecutableAllocator::intializePageSize):
2:45 PM Changeset in webkit [76067] by zmo@google.com
  • 3 edits in trunk/Source/WebCore

2011-01-18 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Make CheckedInt<long> and CheckedInt<unsigned long> work
https://bugs.webkit.org/show_bug.cgi?id=52401

  • html/canvas/CheckedInt.h: (WebCore::CheckedInt::CheckedInt): Merge with the patch provided by Benoit Jacob.
  • html/canvas/WebGLBuffer.cpp: (WebCore::WebGLBuffer::associateBufferDataImpl): Use CheckedInt<long> instead of CheckedInt<int>. (WebCore::WebGLBuffer::associateBufferSubDataImpl): Ditto.
2:30 PM Changeset in webkit [76066] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

2011-01-18 Damian Kaleta <dkaleta@apple.com>

Reviewed by Sam Weinig.

WK2 methods WKPageScaleWebView and WKPageGetViewScaleFactor need to have consistent names
https://bugs.webkit.org/show_bug.cgi?id=52647

  • UIProcess/API/C/WKPage.cpp: (WKPageSetScaleFactor): (WKPageGetScaleFactor):
  • UIProcess/API/C/WKPage.h:
2:22 PM Changeset in webkit [76065] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

2011-01-18 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Ask the web page proxy to scroll the view when needed
https://bugs.webkit.org/show_bug.cgi?id=52665

  • UIProcess/DrawingAreaProxyImpl.cpp: (WebKit::DrawingAreaProxyImpl::incorporateUpdate):
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::scrollView):
  • UIProcess/WebPageProxy.h:
2:18 PM Changeset in webkit [76064] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix build.

  • UIProcess/win/WebView.cpp:

(WebKit::WebView::scrollView):

2:11 PM Changeset in webkit [76063] by kbr@google.com
  • 7 edits
    4 adds in trunk

2011-01-18 Kenneth Russell <kbr@google.com>

Reviewed by David Levin.

Must strip comments from WebGL shaders before enforcing character set
https://bugs.webkit.org/show_bug.cgi?id=52390

Strip comments from incoming shaders, preserving line numbers,
before validating that they conform to the ESSL character set.
Revert changes from http://trac.webkit.org/changeset/75735 which
allowed invalid characters to be passed to certain APIs.

Tested with WebGL layout tests, conformance test suite and several
WebGL demos in both Safari and Chromium.

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::StripComments::StripComments::process): (WebCore::WebGLRenderingContext::shaderSource):

2011-01-18 Kenneth Russell <kbr@google.com>

Reviewed by David Levin.

Must strip comments from WebGL shaders before enforcing character set
https://bugs.webkit.org/show_bug.cgi?id=52390

Incorporated non-ASCII GLSL conformance tests from Khronos
repository. Updated and synchronized invalid-passed-params.html
with Khronos repository, undoing changes from
http://trac.webkit.org/changeset/75735 .

  • fast/canvas/webgl/glsl-conformance-expected.txt:
  • fast/canvas/webgl/invalid-passed-params-expected.txt:
  • fast/canvas/webgl/invalid-passed-params.html:
  • fast/canvas/webgl/shaders/00_shaders.txt:
  • fast/canvas/webgl/shaders/misc: Added.
  • fast/canvas/webgl/shaders/misc/00_shaders.txt: Added.
  • fast/canvas/webgl/shaders/misc/non-ascii-comments.vert: Added.
  • fast/canvas/webgl/shaders/misc/non-ascii.vert: Added.
2:08 PM Changeset in webkit [76062] by andersca@apple.com
  • 8 edits in trunk/Source/WebKit2

2011-01-18 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Add PageClient::scrollView
https://bugs.webkit.org/show_bug.cgi?id=52663

  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm: (WebKit::PageClientImpl::scrollView):
  • UIProcess/API/qt/qwkpage.cpp: (QWKPagePrivate::scrollView):
  • UIProcess/API/qt/qwkpage_p.h:
  • UIProcess/PageClient.h:
  • UIProcess/win/WebView.cpp: (WebKit::PageClientImpl::scrollView):
  • UIProcess/win/WebView.h:
1:55 PM Changeset in webkit [76061] by andersca@apple.com
  • 14 edits in trunk/Source/WebKit2

Rename scrollDelta to scrollOffset everywhere.

Reviewed by Sam Weinig.

  • Shared/UpdateInfo.cpp:

(WebKit::UpdateInfo::encode):
(WebKit::UpdateInfo::decode):

  • Shared/UpdateInfo.h:
  • UIProcess/BackingStore.h:
  • UIProcess/mac/BackingStoreMac.mm:

(WebKit::BackingStore::incorporateUpdate):
(WebKit::BackingStore::scroll):

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::scroll):
(WebKit::WebChromeClient::delegatedScrollRequested):

  • WebProcess/WebCoreSupport/WebChromeClient.h:
  • WebProcess/WebPage/ChunkedUpdateDrawingArea.cpp:

(WebKit::ChunkedUpdateDrawingArea::scroll):

  • WebProcess/WebPage/ChunkedUpdateDrawingArea.h:
  • WebProcess/WebPage/DrawingArea.h:
  • WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::scroll):
(WebKit::DrawingAreaImpl::display):

  • WebProcess/WebPage/DrawingAreaImpl.h:
  • WebProcess/WebPage/LayerBackedDrawingArea.cpp:

(WebKit::LayerBackedDrawingArea::scroll):

  • WebProcess/WebPage/LayerBackedDrawingArea.h:
1:46 PM Changeset in webkit [76060] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-01-18 Dimitry Andric <dim@freebsd.org>

Reviewed by Andreas Kling.

Fix linking JavaScriptCore on FreeBSD/amd64
https://bugs.webkit.org/show_bug.cgi?id=52591

Linking of JavaScriptCore on FreeBSD/amd64 fails, for the same reason as
in bug 28422: cti_vm_throw needs a "@plt" suffix, otherwise the linker
complains about the relocation type.

  • jit/JITStubs.cpp: use @plt suffix on x86_64 platforms, for both Linux and FreeBSD.
1:43 PM Changeset in webkit [76059] by dpranke@chromium.org
  • 3 edits in trunk/Tools

2011-01-18 Dirk Pranke <dpranke@chromium.org>

Reviewed by Ojan Vafai.

Update rebaseline-chromium-webkit-tests unit tests to use a mock
filesystem. Also fix a couple of "with" statements missed by
r76050.

https://bugs.webkit.org/show_bug.cgi?id=52487

  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1:37 PM Changeset in webkit [76058] by cmarrin@apple.com
  • 1 edit
    12 adds in trunk/LayoutTests

2011-01-18 Chris Marrin <cmarrin@apple.com>

Reviewed by Simon Fraser.

Add LayoutTests for new compositing layer logic
https://bugs.webkit.org/show_bug.cgi?id=52657

Add 4 tests checking that the layer tree is properly constructed with nested
layers. The first test is a simple static test of a layer with a 3D transform
with a non-layered parent. It is a pixel test and is just looking for a correct
image. The second test is similar but has a 4 deep hierarchy of <div> element where
only the innermost layer has a 3D transform. It is also a pixel test.
The other 2 tests are the same except that they add and then remove the innermost
layer's transform. It makes sure the layer tree is correct before and after
these changes.

  • compositing/geometry/layer-due-to-layer-children-deep-switch-expected.txt: Added.
  • compositing/geometry/layer-due-to-layer-children-deep-switch.html: Added.
  • compositing/geometry/layer-due-to-layer-children-deep.html: Added.
  • compositing/geometry/layer-due-to-layer-children-switch-expected.txt: Added.
  • compositing/geometry/layer-due-to-layer-children-switch.html: Added.
  • compositing/geometry/layer-due-to-layer-children.html: Added.
  • platform/mac/compositing/geometry/layer-due-to-layer-children-deep-expected.checksum: Added.
  • platform/mac/compositing/geometry/layer-due-to-layer-children-deep-expected.png: Added.
  • platform/mac/compositing/geometry/layer-due-to-layer-children-deep-expected.txt: Added.
  • platform/mac/compositing/geometry/layer-due-to-layer-children-expected.checksum: Added.
  • platform/mac/compositing/geometry/layer-due-to-layer-children-expected.png: Added.
  • platform/mac/compositing/geometry/layer-due-to-layer-children-expected.txt: Added.
1:33 PM Changeset in webkit [76057] by rniwa@webkit.org
  • 7 edits in trunk/Source/WebCore

2011-01-18 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Eric Seidel.

Stop instantiating legacy editing positions in DeleteSelectionCommand, IndentOudentCommand,
InsertLineBreakCommand, InsertListCOmmand.cpp, InsertParagraphSeparatorCommand, and htmlediting.cpp
https://bugs.webkit.org/show_bug.cgi?id=52644

This is a cleanup to stop instantiating legacy editing positions in the following tests.
firstDeepEditingPositionForNode and lastDeepEditingPositionForNode in htmlediting.h are not updated
because doing so requires significant code changes. They are tracked on the bug 52642.

  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::initializeStartEnd): (WebCore::updatePositionForNodeRemoval): (WebCore::DeleteSelectionCommand::removeNode): (WebCore::updatePositionForTextRemoval): (WebCore::DeleteSelectionCommand::handleGeneralDelete):
  • editing/IndentOutdentCommand.cpp: (WebCore::IndentOutdentCommand::outdentParagraph):
  • editing/InsertLineBreakCommand.cpp: (WebCore::InsertLineBreakCommand::doApply):
  • editing/InsertListCommand.cpp: (WebCore::InsertListCommand::doApplyForSingleParagraph): (WebCore::InsertListCommand::unlistifyParagraph): (WebCore::InsertListCommand::listifyParagraph):
  • editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply):
  • editing/htmlediting.cpp: (WebCore::enclosingBlock): (WebCore::enclosingList): (WebCore::enclosingListChild): (WebCore::indexForVisiblePosition): (WebCore::isNodeVisiblyContainedWithin): (WebCore::avoidIntersectionWithNode):
1:29 PM Changeset in webkit [76056] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2011-01-18 Mihai Parparita <mihaip@chromium.org>

Reviewed by Ojan Vafai.

[Chromium] Update Sputnik test expectations
https://bugs.webkit.org/show_bug.cgi?id=52656

Mark Sputnik tests as WONTFIX, so that they don't artificially inflate
our failing test count.

  • platform/chromium/test_expectations.txt:
1:28 PM Changeset in webkit [76055] by sergio@webkit.org
  • 2 edits in trunk/Tools

2011-01-18 Sergio Villar Senin <svillar@igalia.com>

Reviewed by Martin Robinson.

[Gtk] Build fixes for gtk3 build
https://bugs.webkit.org/show_bug.cgi?id=52648

  • DumpRenderTree/gtk/EventSender.cpp: (beginDragWithFilesCallback):
1:28 PM Changeset in webkit [76054] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-01-18 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Get and paint each individual rect in -[WKView drawRect:]
https://bugs.webkit.org/show_bug.cgi?id=52660

  • UIProcess/API/mac/WKView.mm: (-[WKView drawRect:]):
1:24 PM Changeset in webkit [76053] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-01-18 Benjamin Kalman <kalman@chromium.org>

Reviewed by Ryosuke Niwa.

Tweak style in visible_units.cpp and TextIterator.cpp in preparation for another patch
https://bugs.webkit.org/show_bug.cgi?id=52610

This is a purely aesthetic change.

  • editing/TextIterator.cpp: (WebCore::SimplifiedBackwardsTextIterator::advance):
  • editing/visible_units.cpp: (WebCore::previousBoundary):
1:22 PM Changeset in webkit [76052] by mihaip@chromium.org
  • 2 edits in trunk

2011-01-18 Mihai Parparita <mihaip@chromium.org>

Unreviewed. Update .gitignore to reflect that WebKit is now in Source.

  • .gitignore:
1:17 PM Changeset in webkit [76051] by dimich@chromium.org
  • 3 edits in trunk/LayoutTests

[Chromium] Not reviewed, test expectations update.
Added exclusion for new test fast/canvas/canvas-fillPath-alpha-shadow.html

  • platform/chromium-gpu/test_expectations.txt:
  • platform/chromium/test_expectations.txt:
1:10 PM Changeset in webkit [76050] by dpranke@chromium.org
  • 6 edits in trunk/Tools

2011-01-18 Dirk Pranke <dpranke@chromium.org>

Reviewed by Mihai Parparita.

Update rebaseline-chromium-webkit-tests to use filesystem objects
instead of direct references to os.path, shutil, tempfile, etc.

This patch doesn't change anything, but will allow subsequent
patches to change the unit tests to no longer use the real
filesystem.

This patch adds a bunch more methods to the filesystem object as
well.

https://bugs.webkit.org/show_bug.cgi?id=52482

  • Scripts/webkitpy/common/system/filesystem.py:
  • Scripts/webkitpy/common/system/filesystem_mock.py:
  • Scripts/webkitpy/tool/commands/queues.py:
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1:09 PM Changeset in webkit [76049] by oliver@apple.com
  • 5 edits in trunk

2011-01-18 Oliver Hunt <oliver@apple.com>

Reviewed by Antti Koivisto.

[jsfunfuzz] Assertion in codegen for array of NaN constants
https://bugs.webkit.org/show_bug.cgi?id=52643

Add a testcase to ensure we handle a large number of NaN literals
in (0/0 is folded to NaN automatically during parsing).

  • fast/js/codegen-temporaries-expected.txt:
  • fast/js/script-tests/codegen-temporaries.js:

2011-01-18 Oliver Hunt <oliver@apple.com>

Reviewed by Antti Koivisto.

[jsfunfuzz] Assertion in codegen for array of NaN constants
https://bugs.webkit.org/show_bug.cgi?id=52643

Don't cache NaN literals in the code generator, as NaN doesn't compare
as equal to itself it causes problems when rehashing the number cache.

  • bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::emitLoad):
1:02 PM Changeset in webkit [76048] by commit-queue@webkit.org
  • 7 edits in trunk/Source

2011-01-18 Adam Klein <adamk@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Replace ChromiumBridge::widgetSetCursor with ChromeClient::setCursor
https://bugs.webkit.org/show_bug.cgi?id=42236

  • platform/chromium/ChromiumBridge.h:
  • platform/chromium/WidgetChromium.cpp: (WebCore::Widget::setCursor):

2011-01-18 Adam Klein <adamk@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Replace ChromiumBridge::widgetSetCursor with ChromeClient::setCursor
https://bugs.webkit.org/show_bug.cgi?id=42236

  • src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::setCursor):
  • src/ChromeClientImpl.h:
  • src/ChromiumBridge.cpp:
12:37 PM Changeset in webkit [76047] by commit-queue@webkit.org
  • 5 edits
    3 adds in trunk

2011-01-18 Krithigassree Sambamurthy <krithigassree.sambamurthy@nokia.com>

Reviewed by Simon Fraser.

Support background-clip: content-box
https://bugs.webkit.org/show_bug.cgi?id=48771

Addded content-box as a valid background-clip value.

  • WebCore/css/CSSParser.cpp: (WebCore::parseBackgroundClip):

2011-01-18 Krithigassree Sambamurthy <krithigassree.sambamurthy@nokia.com>

Reviewed by Simon Fraser.

Support background-clip: content-box
https://bugs.webkit.org/show_bug.cgi?id=48771

Added test cases to check the various valid background-clip values.

  • fast/css/background-clip-text-expected.txt:
  • fast/css/background-clip-values-expected.checksum: Added.
  • fast/css/background-clip-values-expected.txt: Added.
  • fast/css/background-clip-values.html: Added.
  • fast/css/script-tests/background-clip-text.js:
12:34 PM Changeset in webkit [76046] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-01-18 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler.

Assertion when loading two URLs in quick succession
https://bugs.webkit.org/show_bug.cgi?id=52649
<rdar://problem/8764645>

If beginLoad is called twice without didStartProvisionalLoad being called in between,
m_pendingProvisionalSandboxExtension would be non-null and an assert would fire.

  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::SandboxExtensionTracker::beginLoad): Instead of asserting that m_pendingProvisionalSandboxExtension is null, invalidate it if it is not null, since that's valid.
12:32 PM Changeset in webkit [76045] by dpranke@chromium.org
  • 4 edits in trunk/Tools

2011-01-18 Dirk Pranke <dpranke@chromium.org>

Reviewed by Mihai Parparita.

new-run-webkit-tests shouldn't crash when you try to run a
directory containing only skipped files.

https://bugs.webkit.org/show_bug.cgi?id=52478

  • Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
  • Scripts/webkitpy/layout_tests/port/test.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
12:27 PM Changeset in webkit [76044] by Chris Fleizach
  • 7 edits
    2 adds in trunk

REGRESSION: A problem with Voiceover and finding links
https://bugs.webkit.org/show_bug.cgi?id=52324

Reviewed by Darin Adler.

Source/WebCore:

Fallout from recent change to make WebCore return its own scroll view.

1) There were two scroll views in the hierarchy, one which no needed to be ignored.
2) Hit tests for sub frames needed to be offset.
3) The check for whether an attachment is ignored must happen earlier than using

the helpText to determine if an element should be ignored.

Test: platform/mac/accessibility/iframe-with-title-correct-hierarchy.html

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::elementAccessibilityHitTest):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):

  • accessibility/mac/AccessibilityObjectWrapper.mm:

(-[AccessibilityObjectWrapper scrollViewParent]):

Source/WebKit/mac:

  • WebView/WebDynamicScrollBarsView.mm:

(-[WebDynamicScrollBarsView accessibilityIsIgnored]):

LayoutTests:

  • platform/mac/accessibility/iframe-with-title-correct-hierarchy-expected.txt: Added.
  • platform/mac/accessibility/iframe-with-title-correct-hierarchy.html: Added.
12:09 PM Changeset in webkit [76043] by andersca@apple.com
  • 5 edits in trunk/Source/WebKit2

2011-01-18 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Implement NPN_PopUpContextMenu
https://bugs.webkit.org/show_bug.cgi?id=52646
<rdar://problem/8735616>

  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp: (WebKit::NPN_PopUpContextMenu): Call NetscapePlugin::popUpContextMenu.
  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp: (WebKit::NetscapePlugin::NetscapePlugin): Initialize m_currentMouseEvent.
  • WebProcess/Plugins/Netscape/NetscapePlugin.h: Add m_currentMouseEvent.
  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm: (WebKit::NetscapePlugin::popUpContextMenu): Convert the coordinates from the current mouse event to screen coordinates and call WKPopupContextMenu.

(WebKit::NetscapePlugin::platformHandleMouseEvent):
Update m_currentMouseEvent.

11:56 AM Changeset in webkit [76042] by andersca@apple.com
  • 4 edits in trunk/WebKitLibraries

Add WKPopupContextMenu.

Reviewed by Darin Adler.

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
11:15 AM Changeset in webkit [76041] by Adam Roben
  • 2 edits in trunk/Source/WebCore

Call alternate CFHTTPCookie functions if available

Fixes <http://webkit.org/b/52637> <rdar://problem/8878984>.

Reviewed by Darin Adler.

  • platform/network/cf/CookieJarCFNet.cpp: Added soft-linking macros to

pull in the alternate CFHTTPCookie functions.

(WebCore::cookieDomain):
(WebCore::cookieExpirationTime):
(WebCore::cookieName):
(WebCore::cookiePath):
(WebCore::cookieValue):
Added these wrappers around the CFHTTPCookie functions. We call the
alternate functions if they exist, otherwise fall back to the current
functions.

(WebCore::filterCookies):
(WebCore::getRawCookies):
(WebCore::deleteCookie):
Changed to use the wrapper functions.

11:06 AM Changeset in webkit [76040] by jberlin@webkit.org
  • 2 edits in trunk/Source/WebKit2

WebKit2: Do not assert that the provisional and committed URLs cannot be empty/null
https://bugs.webkit.org/show_bug.cgi?id=52641

Reviewed by Darin Adler.

  • UIProcess/WebFrameProxy.cpp:

(WebKit::WebFrameProxy::didStartProvisionalLoad):
(WebKit::WebFrameProxy::didCommitLoad):
(WebKit::WebFrameProxy::didFinishLoad):

11:06 AM Changeset in webkit [76039] by mrobinson@webkit.org
  • 4 edits in trunk

2011-01-18 Martin Robinson <mrobinson@igalia.com>

Reviewed by Eric Seidel.

[GTK] Filenames are converted to URLs during edit drags
https://bugs.webkit.org/show_bug.cgi?id=52096

  • platform/gtk/Skipped: Unskip passing test. Fix a misspelled drag and drop test on the list as well.

2011-01-18 Martin Robinson <mrobinson@igalia.com>

Reviewed by Eric Seidel.

[GTK] Filenames are converted to URLs during edit drags
https://bugs.webkit.org/show_bug.cgi?id=52096

  • platform/gtk/DragDataGtk.cpp: Only advertise and deliver filenames as URLs if the conversion policy allows it. (WebCore::DragData::containsURL): Ditto. (WebCore::DragData::asURL): Ditto.
10:53 AM Changeset in webkit [76038] by jorlow@chromium.org
  • 1 edit
    6 adds in trunk/LayoutTests

2011-01-18 Jeremy Orlow <jorlow@chromium.org>

[Chromium] Create baselines for svg/css/text-gradient-shadow.svg
https://bugs.webkit.org/show_bug.cgi?id=52640

  • platform/chromium-linux/svg/css/text-gradient-shadow-expected.checksum: Added.
  • platform/chromium-linux/svg/css/text-gradient-shadow-expected.png: Added.
  • platform/chromium-mac/svg/css/text-gradient-shadow-expected.checksum: Added.
  • platform/chromium-win/svg/css/text-gradient-shadow-expected.checksum: Added.
  • platform/chromium-win/svg/css/text-gradient-shadow-expected.png: Added.
  • platform/chromium-win/svg/css/text-gradient-shadow-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
10:49 AM Changeset in webkit [76037] by mrobinson@webkit.org
  • 2 edits in trunk/LayoutTests

2011-01-18 Martin Robinson <mrobinson@igalia.com>

Skip two tests which were incorrectly passing before GTK+
had support for beginDragWithFiles.

  • platform/gtk/Skipped: Skip failing tests.
10:24 AM Changeset in webkit [76036] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-01-18 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

ASSERT in plug-in code when going to youtube
https://bugs.webkit.org/show_bug.cgi?id=52638

  • PluginProcess/PluginControllerProxy.cpp: (WebKit::PluginControllerProxy::paintEntirePlugin): Don't try to paint the plug-in if the plug-in frame is empty.
10:15 AM Changeset in webkit [76035] by jknotten@chromium.org
  • 2 edits in trunk/LayoutTests

2011-01-18 John Knottenbelt <jknotten@chromium.org>

Reviewed by Jeremy Orlow.

[Chromium] Adjust test expectations fast/files/revoke-blob-url.html is flaky on linux.
https://bugs.webkit.org/show_bug.cgi?id=52633

Combine test expectations for the test into one line.

  • platform/chromium/test_expectations.txt:
10:11 AM Changeset in webkit [76034] by andersca@apple.com
  • 13 edits in trunk/Source/WebKit2

2011-01-18 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Plug-in hosting WebProcess instances appear in Activity Monitor as WebProcess
https://bugs.webkit.org/show_bug.cgi?id=52635
<rdar://problem/8731337>

  • PluginProcess/PluginProcess.cpp: (WebKit::PluginProcess::initialize): Call platformInitialize.
  • PluginProcess/PluginProcess.h: Add platformInitialize.
  • PluginProcess/mac/PluginProcessMac.mm: (WebKit::PluginProcess::platformInitialize): Set the compositing render server port and the visible application name.
  • Shared/Plugins/PluginProcessCreationParameters.cpp: (WebKit::PluginProcessCreationParameters::encode): (WebKit::PluginProcessCreationParameters::decode): Encode/decode the parent process name.
  • Shared/Plugins/PluginProcessCreationParameters.h: Add parentProcessName.
  • Shared/WebProcessCreationParameters.cpp: (WebKit::WebProcessCreationParameters::encode): (WebKit::WebProcessCreationParameters::decode): Encode/decode the parent process name.
  • Shared/WebProcessCreationParameters.h: Add parentProcessName.
  • UIProcess/Launcher/mac/ProcessLauncherMac.mm: (WebKit::ProcessLauncher::launchProcess): Don't pass the parent process name here.
  • UIProcess/Plugins/mac/PluginProcessProxyMac.mm: (WebKit::PluginProcessProxy::platformInitializePluginProcess): Set the visible name.
  • UIProcess/mac/WebContextMac.mm: (WebKit::WebContext::platformInitializeWebProcess): Pass along the parent process name.
  • WebProcess/mac/WebProcessMac.mm: (WebKit::WebProcess::platformInitializeWebProcess): Set the visible name.
  • WebProcess/mac/WebProcessMainMac.mm: (WebKit::WebProcessMain): Don't set the visible name here. It's done in platformInitializeWebProcess.
10:10 AM Changeset in webkit [76033] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

2011-01-18 Helder Correia <helder@sencha.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Incorrect shadow alpha with semi-transparent solid fillStyle
https://bugs.webkit.org/show_bug.cgi?id=52611

This is related to bug 52559. The shadow color alpha must be multiplied
by the context brush alpha.

New test to ensure correct behavior of canvas with fillPath using a
semi-transparent fillStyle color and a shadow.

  • fast/canvas/canvas-fillPath-alpha-shadow-expected.txt: Added.
  • fast/canvas/canvas-fillPath-alpha-shadow.html: Added.
  • fast/canvas/script-tests/canvas-fillPath-alpha-shadow.js: Added.

2011-01-18 Helder Correia <helder@sencha.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Incorrect shadow alpha with semi-transparent solid fillStyle
https://bugs.webkit.org/show_bug.cgi?id=52611

This is related to bug 52559. The shadow color alpha must be multiplied
by the context brush alpha.

Test: fast/canvas/canvas-fillPath-alpha-shadow.html

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::fillPath):
9:56 AM Changeset in webkit [76032] by jknotten@chromium.org
  • 2 edits in trunk/LayoutTests

2011-01-18 John Knottenbelt <jknotten@chromium.org>

Unreviewed; updated chromium test expectations.

[Chromium] Adjust test expectations fast/files/revoke-blob-url.html is flaky on linux.
https://bugs.webkit.org/show_bug.cgi?id=52633

  • platform/chromium/test_expectations.txt:
9:47 AM Changeset in webkit [76031] by mrobinson@webkit.org
  • 4 edits
    4 adds in trunk

2011-01-18 Adam Bergkvist <adam.bergkvist@ericsson.com> and Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] The GTK+ EventSender needs support for beginDragWithFiles
https://bugs.webkit.org/show_bug.cgi?id=40833

Unskip passing tests, add in a GTK+-specific result and one more result
which is necessary because GTK+ tests run in Xvfb.

  • platform/gtk/Skipped: Unskip tests that are now passing and organize the remaining skipped tests.
  • platform/gtk/fast/forms/input-file-re-render-expected.txt: Added.
  • platform/gtk/http/tests/security/clipboard/clipboard-file-access-expected.txt: Added.

2011-01-18 Adam Bergkvist <adam.bergkvist@ericsson.com> and Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] The GTK+ EventSender needs support for beginDragWithFiles
https://bugs.webkit.org/show_bug.cgi?id=40833

  • DumpRenderTree/gtk/EventSender.cpp: Add a beginDragWithFiles implementation for the GTK+ event sender. (dragWithFilesDragDataGetCallback): Added. (dragWithFilesDragEndCallback): Added. (beginDragWithFilesCallback): Added.
9:40 AM Changeset in webkit [76030] by caseq@chromium.org
  • 7 edits in trunk

2011-01-18 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: fail resource.requestContent() immediately for WebSocket resources
Remove webInspector.resources.Types from test expectations.
https://bugs.webkit.org/show_bug.cgi?id=52628

  • inspector/extensions-api-expected.txt:

2011-01-18 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: fail resource.requestContent() immediately for WebSocket resources
https://bugs.webkit.org/show_bug.cgi?id=52628

  • English.lproj/localizedStrings.js: Rename WebSocket -> WebSockets in resource catetegories (rest are in plural, too)
  • inspector/front-end/ExtensionServer.js: Do not expose webInspector.resources.Types in extensions API (obsolete) (WebInspector.ExtensionServer.prototype._buildExtensionAPIInjectedScript):
  • inspector/front-end/Resource.js: (WebInspector.Resource.Type.toUIString): Remove ResourceType.Media as it's not used. (WebInspector.Resource.Type.toString): ditto. (WebInspector.Resource.prototype.requestContent): Fail immediately for WebSocket resources.
  • inspector/front-end/inspector.js: Rename WebSocket -> WebSockets in resource catetegories (rest are in plural, too)
9:19 AM Changeset in webkit [76029] by commit-queue@webkit.org
  • 3 edits
    4 adds in trunk

2011-01-18 Helder Correia <helder@sencha.com>

Reviewed by Dirk Schulze.

REGRESSION(75139): SVG gradients are not applied to texts
https://bugs.webkit.org/show_bug.cgi?id=52531

r75139 caused a problem with filling and stroking text with a gradient
fill in SVG. The order of CGContextConcatCTM and CGContextClipToRect
was mixed up.

  • platform/mac/svg/css/text-gradient-shadow-expected.checksum: Added.
  • platform/mac/svg/css/text-gradient-shadow-expected.png: Added.
  • platform/mac/svg/css/text-gradient-shadow-expected.txt: Added.
  • svg/css/text-gradient-shadow.svg: Added.

2011-01-18 Helder Correia <helder@sencha.com>

Reviewed by Dirk Schulze.

REGRESSION(75139): SVG gradients are not applied to texts
https://bugs.webkit.org/show_bug.cgi?id=52531

r75139 caused a problem with filling and stroking text with a gradient
fill in SVG. The order of CGContextConcatCTM and CGContextClipToRect
was mixed up.

Test: svg/css/text-gradient-shadow.svg

  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::fillRect):
9:07 AM Changeset in webkit [76028] by jknotten@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-01-18 John Knottenbelt <jknotten@chromium.org>

Reviewed by Jeremy Orlow.

Add pixel test baseline for svg/custom/use-inherit-style.svg
https://bugs.webkit.org/show_bug.cgi?id=52630

  • svg/custom/use-inherit-style-expected.checksum: Added.
  • svg/custom/use-inherit-style-expected.png: Added.
7:56 AM Changeset in webkit [76027] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

2011-01-18 Leo Yang <leo.yang@torchmobile.com.cn>

Reviewed by Nikolas Zimmermann.

Unable to indirectly animate visibility of SVGUseElement
https://bugs.webkit.org/show_bug.cgi?id=50240

Test case to verify if SVGUseElement inherits parent's
style change.

  • svg/custom/use-inherit-style-expected.txt: Added.
  • svg/custom/use-inherit-style.svg: Added.

2011-01-18 Leo Yang <leo.yang@torchmobile.com.cn>

Reviewed by Nikolas Zimmermann.

Unable to indirectly animate visibility of SVGUseElement
https://bugs.webkit.org/show_bug.cgi?id=50240

SVGUseElement::recalcStyle should take care of its shadow
tree's style recalculation when it is called with change >= Inherit
or when childNeedsStyleRecalc() is true because in these two
cases needStyleRecalc() may not be true.

Test: svg/custom/use-inherit-style.svg

  • svg/SVGUseElement.cpp: (WebCore::SVGUseElement::recalcStyle):
7:34 AM Changeset in webkit [76026] by podivilov@chromium.org
  • 5 edits in trunk/Source/WebCore

2011-01-18 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: provide script length to frontend.
https://bugs.webkit.org/show_bug.cgi?id=52620

  • inspector/Inspector.idl:
  • inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::didParseSource):
  • inspector/front-end/DebuggerModel.js: (WebInspector.DebuggerModel.prototype._parsedScriptSource): (WebInspector.DebuggerDispatcher.prototype.parsedScriptSource):
  • inspector/front-end/Script.js: (WebInspector.Script):
7:30 AM Changeset in webkit [76025] by podivilov@chromium.org
  • 1 edit
    1 delete in trunk/LayoutTests

2011-01-18 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, remove wrong chromium expectation for console-xhr-logging test.

  • platform/chromium/http/tests/inspector/console-xhr-logging-expected.txt: Removed.
6:49 AM BuildingCairoOnWindows edited by d.nusman@re-lion.com
(diff)
6:48 AM Changeset in webkit [76024] by zherczeg@webkit.org
  • 1 edit in trunk/Source/WebCore/ChangeLog

Fixing ChangeLog

Rubber-stamped by Csaba Osztrogonác

Removing a line introduced by
http://trac.webkit.org/changeset/75743/trunk/Source/WebCore/ChangeLog
Removing an unnecessary space before a time stamp.

6:34 AM Changeset in webkit [76023] by podivilov@chromium.org
  • 3 edits in trunk/LayoutTests

2011-01-18 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, test fix for r76019.

  • http/tests/inspector-enabled/console-log-before-frame-navigation-expected.txt:
  • http/tests/inspector-enabled/console-log-before-frame-navigation.html:
6:25 AM Changeset in webkit [76022] by caseq@chromium.org
  • 7 edits in trunk/Source/WebCore

2011-01-17 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [refactoring] use events to notify NetworkManager clients
https://bugs.webkit.org/show_bug.cgi?id=52588

  • inspector/front-end/AuditLauncherView.js: (WebInspector.AuditLauncherView): Do not expose public interface to resource count. Do not reset resource count upon reset(). (WebInspector.AuditLauncherView.prototype._resetResourceCount): (WebInspector.AuditLauncherView.prototype._onResourceStarted): (WebInspector.AuditLauncherView.prototype._onResourceFinished):
  • inspector/front-end/AuditsPanel.js: Do not expose public interface to resource start/finish events.
  • inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer): (WebInspector.ExtensionServer.prototype._notifyResourceFinished): (WebInspector.ExtensionServer.prototype.initExtensions):
  • inspector/front-end/NetworkManager.js: Dispatch events rather than directly call clients. (WebInspector.NetworkManager): (WebInspector.NetworkManager.prototype.willSendRequest): (WebInspector.NetworkManager.prototype.markResourceAsCached): (WebInspector.NetworkManager.prototype.didReceiveResponse): (WebInspector.NetworkManager.prototype.didReceiveContentLength): (WebInspector.NetworkManager.prototype.setInitialContent): (WebInspector.NetworkManager.prototype.didCommitLoadForFrame): (WebInspector.NetworkManager.prototype.willSendWebSocketHandshakeRequest): (WebInspector.NetworkManager.prototype.didReceiveWebSocketHandshakeResponse): (WebInspector.NetworkManager.prototype._startResource): (WebInspector.NetworkManager.prototype._finishResource):
  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel): (WebInspector.NetworkPanel.prototype._onResourceStarted): (WebInspector.NetworkPanel.prototype._appendResource): (WebInspector.NetworkPanel.prototype._onResourceUpdated): (WebInspector.NetworkPanel.prototype._refreshResource): (WebInspector.NetworkPanel.prototype._onMainResourceChanged):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel): (WebInspector.ResourcesPanel.prototype._refreshResource):
6:20 AM Changeset in webkit [76021] by pfeldman@chromium.org
  • 8 edits in trunk

2011-01-18 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: preserve pause on exception state in settings.
https://bugs.webkit.org/show_bug.cgi?id=52619

  • inspector/InspectorController.cpp: (WebCore::InspectorController::getInspectorState):
  • inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::setPauseOnExceptionsState):
  • inspector/InspectorDebuggerAgent.h:
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype.debuggerWasEnabled): (WebInspector.ScriptsPanel.prototype._updatePauseOnExceptionsState): (WebInspector.ScriptsPanel.prototype._togglePauseOnExceptions): (WebInspector.ScriptsPanel.prototype._setPauseOnExceptions):
  • inspector/front-end/Settings.js: (WebInspector.Settings):
  • inspector/front-end/inspector.js: (WebInspector.doLoadedDone.populateInspectorState):
6:09 AM Changeset in webkit [76020] by podivilov@chromium.org
  • 5 edits in trunk/LayoutTests

2011-01-18 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: fix flaky debugger tests.
https://bugs.webkit.org/show_bug.cgi?id=51320

  • http/tests/inspector/debugger-test2.js: (initialize_DebuggerTest.InspectorTest.setBreakpoint): (initialize_DebuggerTest.InspectorTest.showScriptSource): (initialize_DebuggerTest.InspectorTest._showScriptSource):
  • inspector/debugger-pause-on-breakpoint-expected.txt:
  • inspector/debugger-pause-on-breakpoint.html:
5:54 AM Changeset in webkit [76019] by podivilov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-01-18 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [REGRESSION] JavaScript exceptions aren't shown in source frame.
https://bugs.webkit.org/show_bug.cgi?id=52623

  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleMessage): (WebInspector.ConsoleMessage.prototype._formatMessage):
5:42 AM Changeset in webkit [76018] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-01-18 Pavel Feldman <pfeldman@chromium.org>

Revert r76017. No need to guard InspectorInstrumentation
in WebCore.
  • page/Page.cpp: (WebCore::networkStateChanged):
4:44 AM Changeset in webkit [76017] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-01-18 Konstantin Tokarev <Konstantin Tokarev>

Reviewed by Kent Tamura.

Fixed compilation when Inspector is disabled
https://bugs.webkit.org/show_bug.cgi?id=52564

  • page/Page.cpp: (WebCore::networkStateChanged): Added ENABLE(INSPECTOR) guard
4:26 AM Changeset in webkit [76016] by morrita@google.com
  • 23 edits
    2 deletes in trunk/Source/WebCore

2011-01-18 MORITA Hajime <morrita@google.com>

Unreviewed, rolling out r76004, r76005, r76007, and r76011.
http://trac.webkit.org/changeset/76004
http://trac.webkit.org/changeset/76005
http://trac.webkit.org/changeset/76007
http://trac.webkit.org/changeset/76011
https://bugs.webkit.org/show_bug.cgi?id=51664

The r76004 broke pixel tests.
(The failure was missed due to the tolerance.)

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::addRoundedRectClip): (WebCore::GraphicsContext::clipOutRoundedRect):
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/RoundedIntRect.cpp: Removed.
  • platform/graphics/RoundedIntRect.h: Removed.
  • rendering/RenderBox.cpp: (WebCore::RenderBox::pushContentsClip):
  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintFillLayerExtended): (WebCore::RenderBoxModelObject::paintBorder): (WebCore::RenderBoxModelObject::clipBorderSidePolygon): (WebCore::uniformlyExpandBorderRadii): (WebCore::RenderBoxModelObject::paintBoxShadow):
  • rendering/RenderBoxModelObject.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::drawBoxSideFromPath):
  • rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::paint):
  • rendering/RenderThemeChromiumWin.cpp: (WebCore::RenderThemeChromiumWin::paintTextFieldInternal):
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintMenuListButtonGradients): (WebCore::RenderThemeMac::paintSliderTrack):
  • rendering/RenderThemeSafari.cpp: (WebCore::RenderThemeSafari::paintMenuListButtonGradients): (WebCore::RenderThemeSafari::paintSliderTrack):
  • rendering/RenderThemeWinCE.cpp: (WebCore::RenderThemeWinCE::paintSearchFieldCancelButton):
  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::paint):
  • rendering/style/BorderData.h:
  • rendering/style/RenderStyle.cpp: (WebCore::constrainCornerRadiiForRect): (WebCore::RenderStyle::getBorderRadiiForRect): (WebCore::RenderStyle::getInnerBorderRadiiForRectWithBorderWidths):
  • rendering/style/RenderStyle.h:
4:19 AM Changeset in webkit [76015] by hayato@chromium.org
  • 2 edits in trunk

2011-01-18 Hayato Ito <hayato@chromium.org>

Reviewed by Kent Tamura.

Update .gitignore file to reflect a recent WebKit directory movement.

https://bugs.webkit.org/show_bug.cgi?id=52618

  • .gitignore:
4:16 AM Changeset in webkit [76014] by kbalazs@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt][WK2] Not implemented warnings should not break layout tests
https://bugs.webkit.org/show_bug.cgi?id=52616

Reviewed by Csaba Osztrogonác.

  • WebKit2Prefix.h: Define DISABLE_NOT_IMPLEMENTED_WARNINGS on Qt.
3:04 AM Changeset in webkit [76013] by podivilov@chromium.org
  • 10 edits in trunk/Source/WebCore

2011-01-17 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: add source column field to debugger call frames.
https://bugs.webkit.org/show_bug.cgi?id=52443

  • bindings/js/JavaScriptCallFrame.cpp: (WebCore::JavaScriptCallFrame::JavaScriptCallFrame):
  • bindings/js/JavaScriptCallFrame.h: (WebCore::JavaScriptCallFrame::create): (WebCore::JavaScriptCallFrame::line): (WebCore::JavaScriptCallFrame::column): (WebCore::JavaScriptCallFrame::update):
  • bindings/js/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::createCallFrameAndPauseIfNeeded): (WebCore::ScriptDebugServer::updateCallFrameAndPauseIfNeeded): (WebCore::ScriptDebugServer::callEvent): (WebCore::ScriptDebugServer::atStatement): (WebCore::ScriptDebugServer::returnEvent): (WebCore::ScriptDebugServer::exception): (WebCore::ScriptDebugServer::willExecuteProgram): (WebCore::ScriptDebugServer::didExecuteProgram): (WebCore::ScriptDebugServer::didReachBreakpoint):
  • bindings/js/ScriptDebugServer.h:
  • bindings/v8/DebuggerScript.js: ():
  • bindings/v8/JavaScriptCallFrame.cpp: (WebCore::JavaScriptCallFrame::column):
  • bindings/v8/JavaScriptCallFrame.h:
  • inspector/InjectedScriptSource.js: ():
  • inspector/JavaScriptCallFrame.idl:

2011-01-18 Antti Koivisto <Antti Koivisto>

Reviewed by Dave Hyatt.

https://bugs.webkit.org/show_bug.cgi?id=52370
<rdar://problem/8856808>
Style sharing optimization no longer works on major web sites

The code in CSSStyleSelector::locateSharedStyle() that tries to share style information between element has been defeated
by widespread use of certain CSS selectors (:first-child pseudo class and similar). The current implementation disables
the sharing optimization for the whole page if one of these constructs is seen in any style sheet used by the page.

This patch gets the style sharing back to 25-40% range on most web sites.

  • css/CSSMutableStyleDeclaration.h: (WebCore::CSSMutableStyleDeclaration::propertiesEqual):

Needed to improve equality checking in NamedNodeMap::mappedMapsEquivalent.

  • css/CSSSelector.h: (WebCore::CSSSelector::isSiblingSelector):

Test for selectors that are affected by the sibling elements.

  • css/CSSStyleSelector.cpp: (WebCore::elementCanUseSimpleDefaultStyle): (WebCore::collectSiblingRulesInDefaultStyle): (WebCore::assertNoSiblingRulesInDefaultStyle):

Extract sibling rules from the MathML default stylesheet.
Assert that no other default stylesheet has them.

(WebCore::CSSStyleSelector::CSSStyleSelector):
(WebCore::CSSStyleSelector::locateCousinList):
(WebCore::CSSStyleSelector::matchesSiblingRules):
(WebCore::CSSStyleSelector::canShareStyleWithElement):
(WebCore::CSSStyleSelector::locateSharedStyle):
(WebCore::CSSStyleSelector::styleForElement):
(WebCore::collectIdsAndSiblingRulesFromList):
(WebCore::CSSRuleSet::collectIdsAndSiblingRules):

Track sibling rules and ids used in the stylesheets to allow much more fine-grained rejection of cases
where style sharing can't be used.

  • css/CSSStyleSelector.h:
  • dom/NamedNodeMap.cpp: (WebCore::NamedNodeMap::mappedMapsEquivalent):

Check also for CSSValue mutation from DOM.

  • mathml/MathMLMathElement.cpp: (WebCore::MathMLMathElement::insertedIntoDocument):
  • mathml/MathMLMathElement.h:

MathML default style sheet has sibling rules which don't get noticed by the normal document
stylesheet parsing.

  • rendering/style/RenderStyle.h: (WebCore::InheritedFlags::setFirstChildState): (WebCore::InheritedFlags::setLastChildState): (WebCore::InheritedFlags::setChildIndex):

These all make style non-shareable (unique).

2:48 AM Changeset in webkit [76012] by Antti Koivisto
  • 12 edits in trunk

Source/WebCore: 2011-01-18 Antti Koivisto <Antti Koivisto>

Reviewed by Dave Hyatt.

https://bugs.webkit.org/show_bug.cgi?id=52370
<rdar://problem/8856808>
Style sharing optimization no longer works on major web sites

The code in CSSStyleSelector::locateSharedStyle() that tries to share style information between element has been defeated
by widespread use of certain CSS selectors (:first-child pseudo class and similar). The current implementation disables
the sharing optimization for the whole page if one of these constructs is seen in any style sheet used by the page.

This patch gets the style sharing back to 25-40% range on most web sites.

  • css/CSSMutableStyleDeclaration.h:

(WebCore::CSSMutableStyleDeclaration::propertiesEqual):

Needed to improve equality checking in NamedNodeMap::mappedMapsEquivalent.


  • css/CSSSelector.h:

(WebCore::CSSSelector::isSiblingSelector):

Test for selectors that are affected by the sibling elements.


  • css/CSSStyleSelector.cpp:

(WebCore::elementCanUseSimpleDefaultStyle):
(WebCore::collectSiblingRulesInDefaultStyle):
(WebCore::assertNoSiblingRulesInDefaultStyle):

Extract sibling rules from the MathML default stylesheet.
Assert that no other default stylesheet has them.


(WebCore::CSSStyleSelector::CSSStyleSelector):
(WebCore::CSSStyleSelector::locateCousinList):
(WebCore::CSSStyleSelector::matchesSiblingRules):
(WebCore::CSSStyleSelector::canShareStyleWithElement):
(WebCore::CSSStyleSelector::locateSharedStyle):
(WebCore::CSSStyleSelector::styleForElement):
(WebCore::collectIdsAndSiblingRulesFromList):
(WebCore::CSSRuleSet::collectIdsAndSiblingRules):

Track sibling rules and ids used in the stylesheets to allow much more fine-grained rejection of cases
where style sharing can't be used.

  • css/CSSStyleSelector.h:
  • dom/NamedNodeMap.cpp:

(WebCore::NamedNodeMap::mappedMapsEquivalent):

Check also for CSSValue mutation from DOM.


  • mathml/MathMLMathElement.cpp:

(WebCore::MathMLMathElement::insertedIntoDocument):

  • mathml/MathMLMathElement.h:


MathML default style sheet has sibling rules which don't get noticed by the normal document
stylesheet parsing.


  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::setFirstChildState):
(WebCore::InheritedFlags::setLastChildState):
(WebCore::InheritedFlags::setChildIndex):

These all make style non-shareable (unique).

LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=52370
Style sharing optimization no longer works on major web sites

Reviewed by Dave Hyatt.

These are progressions (with no noticable visual change).
MathML code was improperly sharing style.

  • platform/mac/mathml/presentation/fractions-vertical-alignment-expected.txt:
  • platform/mac/mathml/presentation/subsup-expected.txt:
2:37 AM Changeset in webkit [76011] by morrita@google.com
  • 2 edits in trunk/Source/WebCore

2011-01-18 MORITA Hajime <morrita@google.com>

Unreviewed crash fix on release builds.

  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintFillLayerExtended):
2:20 AM Changeset in webkit [76010] by podivilov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-01-18 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, update localizedStrings.js.

  • English.lproj/localizedStrings.js:
2:15 AM Changeset in webkit [76009] by podivilov@chromium.org
  • 7 edits
    1 add in trunk/Source/WebCore

2011-01-11 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: implement script beautifier prototype.
https://bugs.webkit.org/show_bug.cgi?id=51588

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/ScriptFormatter.js: Added. (WebInspector.ScriptFormatter): Implements JavaScript source beautification and conversion between original and formatted line numbers (WebInspector.ScriptFormatter.findLineEndings): (WebInspector.ScriptFormatter.locationToPosition): (WebInspector.ScriptFormatter.positionToLocation): (WebInspector.ScriptFormatter.upperBound): (WebInspector.ScriptFormatter.prototype.format): (WebInspector.ScriptFormatter.prototype.originalLineNumberToFormattedLineNumber): (WebInspector.ScriptFormatter.prototype.formattedLineNumberToOriginalLineNumber): (WebInspector.ScriptFormatter.prototype.originalPositionToFormattedLineNumber): (WebInspector.ScriptFormatter.prototype.formattedLineNumberToOriginalPosition): (WebInspector.ScriptFormatter.prototype._convertPosition):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype._clearCurrentExecutionLine): (WebInspector.ScriptsPanel.prototype._callFrameSelected): (WebInspector.ScriptsPanel.prototype._formatScript):
  • inspector/front-end/SourceFrame.js: Convert original line numbers to UI line numbers and vice versa
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
2:02 AM Changeset in webkit [76008] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Tools

2011-01-18 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Adam Barth.

ews: Add additional watcher to efl ews
https://bugs.webkit.org/show_bug.cgi?id=52613

Add gyuyoung.kim@samsung.com to watcher list of efl-ews.

  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1:32 AM Changeset in webkit [76007] by Philippe Normand
  • 2 edits in trunk/Source/WebCore

2011-01-18 Philippe Normand <pnormand@igalia.com>

Unreviewed, GTK build fix as follow-up of r76004.

  • GNUmakefile.am: Include RoundedIntRect files in the build
1:24 AM Changeset in webkit [76006] by Philippe Normand
  • 3 edits
    12 deletes in trunk

2011-01-18 Philippe Normand <pnormand@igalia.com>

Unreviewed, rolling out r76002.
http://trac.webkit.org/changeset/76002
https://bugs.webkit.org/show_bug.cgi?id=49790

breaks a bunch of fast/forms tests on mac and GTK

  • fast/forms/select-option-background-color-change.html: Removed.
  • fast/forms/select-option-color-change.html: Removed.
  • fast/forms/select-option-visibility-change.html: Removed.
  • platform/mac/fast/forms/select-option-background-color-change-expected.checksum: Removed.
  • platform/mac/fast/forms/select-option-background-color-change-expected.png: Removed.
  • platform/mac/fast/forms/select-option-background-color-change-expected.txt: Removed.
  • platform/mac/fast/forms/select-option-color-change-expected.checksum: Removed.
  • platform/mac/fast/forms/select-option-color-change-expected.png: Removed.
  • platform/mac/fast/forms/select-option-color-change-expected.txt: Removed.
  • platform/mac/fast/forms/select-option-visibility-change-expected.checksum: Removed.
  • platform/mac/fast/forms/select-option-visibility-change-expected.png: Removed.
  • platform/mac/fast/forms/select-option-visibility-change-expected.txt: Removed.

2011-01-18 Philippe Normand <pnormand@igalia.com>

Unreviewed, rolling out r76002.
http://trac.webkit.org/changeset/76002
https://bugs.webkit.org/show_bug.cgi?id=49790

breaks a bunch of fast/forms tests on mac and GTK

  • html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::setRenderStyle):
1:13 AM Changeset in webkit [76005] by morrita@google.com
  • 2 edits in trunk/Source/WebCore

2011-01-18 MORITA Hajime <morrita@google.com>

Unreviewed windows build fix.

  • WebCore.vcproj/WebCore.vcproj:
12:59 AM Changeset in webkit [76004] by morrita@google.com
  • 21 edits
    2 adds in trunk/Source/WebCore

2011-01-17 MORITA Hajime <morrita@google.com>

Reviewed by Simon Fraser.

Refactoring: Extract RoundedIntRect class
https://bugs.webkit.org/show_bug.cgi?id=51664

RoundedIntRect is a pair of rect and four IntSize objects which represent
corner radii of the rectangle. IntSize is grouped into RoundedIntRect::Radii.
Now RenderStyle::getRoundedBorderFor() and RenderStyle::getRoundedInnerBorderWithBorderWidths()
return RoundedIntRect and GraphicsContext::addRoundedRectClip(), GraphicsContext::fillRoundedRect()
and other functions accept RoundedIntRect as an argument.

No new tests. No behavioral change.

  • Android.mk:
  • CMakeLists.txt:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::addRoundedRectClip): (WebCore::GraphicsContext::clipOutRoundedRect): (WebCore::GraphicsContext::fillRoundedRect):
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/RoundedIntRect.cpp: Added. (WebCore::RoundedIntRect::Radii::isZero): (WebCore::RoundedIntRect::Radii::scale): (WebCore::RoundedIntRect::Radii::expand): (WebCore::RoundedIntRect::Radii::includeLogicalEdges): (WebCore::RoundedIntRect::Radii::excludeLogicalEdges): (WebCore::RoundedIntRect::RoundedIntRect): (WebCore::RoundedIntRect::includeLogicalEdges): (WebCore::RoundedIntRect::excludeLogicalEdges):
  • platform/graphics/RoundedIntRect.h: Added. (WebCore::RoundedIntRect::Radii::Radii): (WebCore::RoundedIntRect::Radii::setTopLeft): (WebCore::RoundedIntRect::Radii::setTopRight): (WebCore::RoundedIntRect::Radii::setBottomLeft): (WebCore::RoundedIntRect::Radii::setBottomRight): (WebCore::RoundedIntRect::Radii::topLeft): (WebCore::RoundedIntRect::Radii::topRight): (WebCore::RoundedIntRect::Radii::bottomLeft): (WebCore::RoundedIntRect::Radii::bottomRight): (WebCore::RoundedIntRect::Radii::expand): (WebCore::RoundedIntRect::Radii::shrink): (WebCore::RoundedIntRect::location): (WebCore::RoundedIntRect::size): (WebCore::RoundedIntRect::x): (WebCore::RoundedIntRect::y): (WebCore::RoundedIntRect::width): (WebCore::RoundedIntRect::height): (WebCore::RoundedIntRect::right): (WebCore::RoundedIntRect::bottom): (WebCore::RoundedIntRect::rect): (WebCore::RoundedIntRect::radii): (WebCore::RoundedIntRect::isRounded): (WebCore::RoundedIntRect::isEmpty): (WebCore::RoundedIntRect::setRect): (WebCore::RoundedIntRect::setRadii): (WebCore::RoundedIntRect::move): (WebCore::RoundedIntRect::inflate): (WebCore::RoundedIntRect::inflateWithRadii): (WebCore::RoundedIntRect::expandRadii): (WebCore::RoundedIntRect::shrinkRadii):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::pushContentsClip):
  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintFillLayerExtended): (WebCore::RenderBoxModelObject::paintBorder): (WebCore::RenderBoxModelObject::clipBorderSidePolygon): (WebCore::RenderBoxModelObject::paintBoxShadow):
  • rendering/RenderBoxModelObject.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::drawBoxSideFromPath):
  • rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::paint):
  • rendering/RenderThemeChromiumWin.cpp: (WebCore::RenderThemeChromiumWin::paintTextFieldInternal):
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintMenuListButtonGradients): (WebCore::RenderThemeMac::paintSliderTrack):
  • rendering/RenderThemeSafari.cpp: (WebCore::RenderThemeSafari::paintMenuListButtonGradients): (WebCore::RenderThemeSafari::paintSliderTrack):
  • rendering/RenderThemeWinCE.cpp: (WebCore::RenderThemeWinCE::paintSearchFieldCancelButton):
  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::paint):
  • rendering/style/BorderData.h:
  • rendering/style/RenderStyle.cpp: (WebCore::calcRadiiFor): (WebCore::calcConstraintScaleFor): (WebCore::RenderStyle::getRoundedBorderFor): (WebCore::RenderStyle::getRoundedInnerBorderWithBorderWidths):
  • rendering/style/RenderStyle.h: (WebCore::InheritedFlags::setBorderRadius):
12:43 AM Changeset in webkit [76003] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed.

[Qt] Fix LoadHTMLStringItem::invoke() after r75966
https://bugs.webkit.org/show_bug.cgi?id=52614

  • platform/qt/Skipped: http/tests/navigation/go-back-to-error-page.html added until fix.
12:00 AM Changeset in webkit [76002] by rwlbuis@webkit.org
  • 3 edits
    12 adds in trunk

2011-01-17 Rob Buis <rwlbuis@gmail.com>

Reviewed by Kent Tamura.

Color changes to option elements in a select multiple aren't drawn immediately
https://bugs.webkit.org/show_bug.cgi?id=49790

Redirect style changes on <option> element to the owner <select> element.

Tests: fast/forms/select-option-background-color-change.html

fast/forms/select-option-color-change.html
fast/forms/select-option-visibility-change.html

  • html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::setRenderStyle):

Jan 17, 2011:

11:12 PM Changeset in webkit [76001] by morrita@google.com
  • 3 edits in trunk/Source/WebCore

2011-01-17 MORITA Hajime <morrita@google.com>

Unreviewed, rolling out r75995.
http://trac.webkit.org/changeset/75995
https://bugs.webkit.org/show_bug.cgi?id=51914

Causes assertion failures.

  • dom/Element.cpp: (WebCore::Element::shadowRoot): (WebCore::Element::setShadowRoot): (WebCore::Element::removeShadowRoot):
  • dom/ElementRareData.h: (WebCore::ElementRareData::ElementRareData):
11:08 PM Changeset in webkit [76000] by morrita@google.com
  • 2 edits in trunk/Source/WebCore

2011-01-17 MORITA Hajime <morrita@google.com>

Unreviewed, rolling out r75999.
http://trac.webkit.org/changeset/75999

  • dom/Element.cpp: (WebCore::Element::removeShadowRoot):
10:52 PM Changeset in webkit [75999] by morrita@google.com
  • 2 edits in trunk/Source/WebCore

2011-01-17 MORITA Hajime <morrita@google.com>

Unreviewed crash fix, which introduced at r75995

  • dom/Element.cpp: (WebCore::Element::removeShadowRoot):
10:02 PM Changeset in webkit [75998] by mrowe@apple.com
  • 5 edits in tags/Safari-534.15.15

Versioning.

9:54 PM Changeset in webkit [75997] by mrowe@apple.com
  • 1 copy in tags/Safari-534.15.15

New tag.

9:40 PM Changeset in webkit [75996] by commit-queue@webkit.org
  • 2 edits
    8 adds in trunk/LayoutTests

2011-01-17 Steve Lacey <sjl@chromium.org>

Reviewed by David Levin.

Rebaseline media/video-zoom-controls for chromium.
https://bugs.webkit.org/show_bug.cgi?id=52415

  • platform/chromium-linux/media/video-zoom-controls-expected.checksum: Added.
  • platform/chromium-linux/media/video-zoom-controls-expected.png: Added.
  • platform/chromium-mac/media/video-zoom-controls-expected.checksum: Added.
  • platform/chromium-mac/media/video-zoom-controls-expected.png: Added.
  • platform/chromium-mac/media/video-zoom-controls-expected.txt: Added.
  • platform/chromium-win/media/video-zoom-controls-expected.checksum: Added.
  • platform/chromium-win/media/video-zoom-controls-expected.png: Added.
  • platform/chromium-win/media/video-zoom-controls-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
8:30 PM Changeset in webkit [75995] by morrita@google.com
  • 3 edits in trunk/Source/WebCore

2011-01-17 MORITA Hajime <morrita@google.com>

Reviewed by Dimitri Glazkov.

ElementRareData::m_shadowRoot should not be RefPtr.
https://bugs.webkit.org/show_bug.cgi?id=51914

This change makes m_shadowRoot a raw pointer, as Node::m_parent is.
This change is safe because shadow host pointer is stored as TreeShared::m_parent
which prevents deletion unless set to null.

No test, no behavioral change.

  • dom/Element.cpp: (WebCore::Element::shadowRoot): (WebCore::Element::setShadowRoot): (WebCore::Element::removeShadowRoot):
  • dom/ElementRareData.h: (WebCore::ElementRareData::ElementRareData):
7:49 PM Changeset in webkit [75994] by mjs@apple.com
  • 2 edits in trunk/Source/WebCore

2011-01-17 Maciej Stachowiak <mjs@apple.com>

Reviewed by Dan Bernstein.

Some WebKit2 layout tests crash due to focus being on a frame in the page cache
https://bugs.webkit.org/show_bug.cgi?id=52607

No new tests. Existing tests crash in WebKit2 without this fix.


I suspect there are other consequences besides the WebKit2 crash, but I
was unable to identify any for certain.

  • history/CachedFrame.cpp: (WebCore::CachedFrame::CachedFrame): If a frame still has focus when its page goes in the page cache, reset focus to the main frame.
7:15 PM Changeset in webkit [75993] by dimich@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Not reviewed, test expectations update.
Added TIMEOUT to fast/canvas/canvas-fillPath-pattern-shadow.html

  • platform/chromium-gpu/test_expectations.txt:
7:10 PM Changeset in webkit [75992] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-01-17 Jarred Nicholls <jarred@sencha.com>

Reviewed by Csaba Osztrogonác.

REGRESSION(r75709): Return value of fscanf() shouldn't be ignored.
https://bugs.webkit.org/show_bug.cgi?id=52585

gcc 4.4.4+ has warn_unused_value attribute on fscanf, so we should check
the return value to get around the gcc warning

  • jit/ExecutableAllocatorFixedVMPool.cpp: (JSC::maybeModifyVMPoolSize):
6:10 PM Changeset in webkit [75991] by msaboff@apple.com
  • 5 edits in trunk

2011-01-17 Michael Saboff <msaboff@apple.com>

Reviewed by Oliver Hunt.

[regexfuzz] Crash running regex with lookahead
https://bugs.webkit.org/show_bug.cgi?id=52548

Eliminated agressive chaining of backtracks. This code was overwriting
already valid backtrack information.

  • yarr/YarrJIT.cpp: (JSC::Yarr::YarrGenerator::ParenthesesTail::processBacktracks):

2011-01-17 Michael Saboff <msaboff@apple.com>

Reviewed by Oliver Hunt.

[regexfuzz] Crash running regex with lookahead
https://bugs.webkit.org/show_bug.cgi?id=52548

New tests from regex fuzzer.

  • fast/regex/parentheses-expected.txt:
  • fast/regex/script-tests/parentheses.js:
6:06 PM Changeset in webkit [75990] by dimich@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Not reviewed, test expectations update.
Same as previous patch, now for -gpu file.

  • platform/chromium-gpu/test_expectations.txt:
5:55 PM Changeset in webkit [75989] by dimich@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Not reviewed, test expectations update.
fast/canvas/canvas-fillPath-pattern-shadow.html fails on Win and Linux.

  • platform/chromium/test_expectations.txt:
5:46 PM Changeset in webkit [75988] by Adam Roben
  • 10 edits in trunk

Simplify WKCACFLayerRenderer's API

createRenderer/destroyRenderer are now hidden behind setHostWindow.
WKCACFLayerRendererClient::animationsStarted has been removed, as it
was never called. (The work it was supposed to do was already being
accomplished by WKCACFLayerRenderer::render telling each layer that
animations are starting.)

Fixes <http://webkit.org/b/52587> WKCACFLayerRenderer is hard to use

Reviewed by Chris Marrin.

Source/WebCore:

  • platform/graphics/win/MediaPlayerPrivateFullscreenWindow.cpp:

(WebCore::MediaPlayerPrivateFullscreenWindow::createWindow): Moved the
call to setHostWindow here from the WM_CREATE handler. The WM_CREATE
handler was causing the Direct3D device to be created, but MSDN says
you shouldn't create a device while handling WM_CREATE. Removed
no-longer-needed call to createRenderer (setHostWindow does this now)
and the never-needed call to setNeedsDisplay (we never draw into the
root layer; this was just creating an unnecessary backing store the
size of the screen!).
(WebCore::MediaPlayerPrivateFullscreenWindow::wndProc): Moved WM_CREATE
code, as described above. Removed call to destroyRenderer when handling
WM_DESTROY; setHostWindow does this now. Fixed up our WM_PAINT handler
to do a synchronous paint and to clear our dirty region, while I was in
here.

  • platform/graphics/win/WKCACFLayerRenderer.cpp:

(WebCore::WKCACFLayerRenderer::~WKCACFLayerRenderer): Changed to call
setHostWindow instead of destroyRenderer; the former calls the latter
if needed.
(WebCore::WKCACFLayerRenderer::setHostWindow): Moved here from the
header file. Destroys our old renderer (i.e., IDirect3DDevice9) if
we're losing our window, or creates a renderer if we're gaining a
window.
(WebCore::WKCACFLayerRenderer::createRenderer): Updated for WKSI function rename.
(WebCore::WKCACFLayerRenderer::destroyRenderer): Changed to clear the
D3D device from our context before releasing the device.

  • platform/graphics/win/WKCACFLayerRenderer.h: Removed

WKCACFLayerRendererClient::animationsStarted. Removed setNeedsDisplay.
Make createRenderer, destroyRenderer, and renderSoon private.

WebKit/win:

Update for WKCACFLayerRenderer changes

  • WebView.cpp:

(WebView::WebViewWndProc): Removed call to layerRendererBecameVisible
when handling WM_SHOWWINDOW. All this did was try to create the
renderer, but it had already been created in setAcceleratedCompositing,
so wasn't needed.
(WebView::setAcceleratedCompositing): Removed call to createRenderer;
setHostWindow does this for us now.

  • WebView.h: Removed animationsStarted and layerRendererBecameVisible.

WebKitLibraries:

Make it possible to both set and clear a wkCACFContext's D3D device

  • win/include/WebKitSystemInterface/WebKitSystemInterface.h:
  • win/lib/WebKitSystemInterface.lib:
5:45 PM Changeset in webkit [75987] by Adam Roben
  • 7 edits in trunk/Source

Paint directly into a GraphicsLayer when using accelerated compositing

Before this patch, we were painting into our normal backing store
HBITMAP, wrapping it in a CGImage, and handing it off to Core
Animation. This had at least two disadvantages:

1) The bitmap could be modified while Core Animation was using it.
2) It introduced extra complexity.

When entering accelerated compositing mode, WebView now creates a
GraphicsLayer to draw into. This GraphicsLayer sits between the root
layer (owned by WKCACFLayerRenderer) and the RenderView's layer. When
WebView invalidates, it just calls setNeedsDisplayInRect on its
GraphicsLayer. When WebView paints, it just tells its
WKCACFLayerRenderer to paint, which will call back to WebView to draw
into the GraphicsLayer if it has a dirty region. This is very similar
to the current implementation of LayerBackedDrawingArea in WebKit2.

Fixes <http://webkit.org/b/52582> WebView should paint directly into a
GraphicsLayer when in accelerated compositing mode

Reviewed by Simon Fraser and Chris Marrin.

WebCore:

Remove special-cased support for providing content for the root layer

Clients will just have to provide content through the normal
GraphicsLayer channels now!

  • platform/graphics/win/WKCACFLayerRenderer.cpp:

(WebCore::WKCACFLayerRenderer::WKCACFLayerRenderer): Removed
initialization of m_backingStoreDirty, which has itself been removed.
(WebCore::WKCACFLayerRenderer::setNeedsDisplay): Moved code to schedule
a sync from here to syncCompositingStateSoon. We only need to call
renderSoon if we don't call syncCompositingStateSoon; the latter
function calls the former.
(WebCore::WKCACFLayerRenderer::paint): Removed code to handle
m_backingStoreDirty. We don't want to know anything about clients'
backing stores.
(WebCore::WKCACFLayerRenderer::syncCompositingStateSoon): Added. Code
came from setNeedsDisplay.

  • platform/graphics/win/WKCACFLayerRenderer.h:

Removed setRootContents[AndDisplay], setBackingStoreDirty, and
m_backingStoreDirty. Made paint() public so that clients can force a
synchronous render (e.g., when handling WM_PAINT).

WebKit/win:

  • WebCoreSupport/WebChromeClient.cpp:

(WebChromeClient::attachRootGraphicsLayer):
(WebChromeClient::scheduleCompositingLayerSync):
Updated for WebView changes.

  • WebView.cpp:

(WebView::repaint): When using accelerated compositing, just invalidate
our backing layer. This matches the behavior of LayerBackedDrawingArea.
(WebView::deleteBackingStore): Removed accelerated compositing code.
The WKCACFLayerRenderer doesn't need to know about our backing store
anymore; we don't use it at all when in accelerated compositing mode.
(WebView::addToDirtyRegion): When using accelerated compositing, just
invalidate our backing layer.
(WebView::scrollBackingStore): Added an assertion that this isn't
called in accelerated compositing mode.
(WebView::sizeChanged): Update our backing layer's size, too, and
invalidate it.
(WebView::updateBackingStore): Added an assertion that this isn't
called in accelerated compositing mode.
(WebView::paint): If we're in accelerated compositing mode, sync our
compositing state. If we're *still* in accelerated compositing mode,
just tell our WKCACFLayerRenderer to paint and clear our dirty region.
(The later changes in this function are just un-indenting code that
used to be inside an if.)

(WebView::paintIntoBackingStore):
(WebView::paintIntoWindow):
Added assertions that these aren't called in accelerated compositing
mode.

(WebView::WebViewWndProc): Updated WM_XP_THEMECHANGED handling for
removal of setRootLayerNeedsDisplay.
(WebView::setRootChildLayer): Changed to take a GraphicsLayer. We now
set the layer as a child of our own backing layer.
(WebView::scheduleCompositingLayerSync): Just call through to
WKCACFLayerRenderer.
(WebView::setAcceleratedCompositing): Create our backing layer and set
it as the child of WKCACFLayerRenderer's root layer.
(WebView::notifyAnimationStarted): Added. We never expect this
GraphicsLayerClient override to be called, as we don't use animations
on our backing layer.
(WebView::notifySyncRequired): Added. Just schedule a sync.
(WebView::paintContents): Added. Just clip and paint!

(WebView::showDebugBorders):
(WebView::showRepaintCounter):
Added. These just call through to Settings.

(WebView::syncCompositingState): Changed to first update layout, then
sync state for our backing layer, then sync WebCore's state. This
matches LayerBackedDrawingArea.

  • WebView.h: WebView now implements the GraphicsLayerClient interface.

Removed setRootLayerNeedsDisplay; it's been replaced by calling
setNeedsDisplay on our backing layer and calling
syncCompositingStateSoon on WKCACFLayerRenderer as needed. Removed
updateRootLayerContents; that function was used to pass our backing
store to Core Animation, which we no longer do. Added m_backingLayer.

5:45 PM Changeset in webkit [75986] by Adam Roben
  • 2 edits in trunk/Source/WebCore

Remove contexts from WKCACFContextFlusher before destroying them

We aren't really using WKCACFContextFlusher for anything useful at the
moment, but that will probably change in the near future.

I couldn't come up with a way to test this because it isn't possible to
resize a window in DumpRenderTree.

Fixes <http://webkit.org/b/52573> REGRESSION (r75262): Crash beneath
WKCACFContextFlusher::flushAllContexts when resizing window on page
that uses accelerated compositing

Reviewed by Simon Fraser.

  • platform/graphics/win/WKCACFLayerRenderer.cpp:

(WebCore::WKCACFLayerRenderer::~WKCACFLayerRenderer): Remove our
context from WKCACFContextFlusher. (This code was erroneously removed
from WKCACFLayerRenderer::destroyRenderer in r75262. This is a more
sensible place for it.)

5:44 PM Changeset in webkit [75985] by Adam Roben
  • 6 edits in trunk

Don't access the CACFLayerRef's sublayers directly from PlatformCALayer

There might be a secret extra sublayer (the tile parent layer) that
PlatformCALayer doesn't know about. When PlatformCALayer would
encounter this, it would try to use the tile parent layer's
PlatformCALayer wrapper, which was null, and then would crash. We now
ask PlatformCALayerWinInternal for the sublayer list, since that class
knows about the tile parent layer and can exclude it from the sublayer
list.

Covered by compositing/tiling/huge-layer-resize.html.

Fixes <http://webkit.org/b/52597> Crash beneath
PlatformCALayer::adoptSublayers when switching out of tiling mode
(null-dereference of a PlatformCALayer)

Reviewed by Darin Adler and Chris Marrin.

LayoutTests:

Make compositing/tiling/huge-layer-resize.html faster, more reliable,
and more crashy (when there's a WebKit bug)

This test was trying to cause a layout/paint to happen by returning to
the event loop for a certain amount of time via setTimeout. But this
didn't always result in a layout/paint (at least on Windows). We now
force the layout/paint explicitly, which also lets us speed up the test
by removing the setTimeouts.

  • compositing/tiling/huge-layer-resize.html:

(testOnLoad): Changed to use recordLayerTree, which forces a
layout/paint, instead of hoping that setTimeout will do the trick.
(recordLayerTree): Forces a layout/paint, then dumps the layer tree.

Source/WebCore:

  • platform/graphics/ca/win/PlatformCALayerWin.cpp:

(PlatformCALayer::adoptSublayers):
(printLayer):
Changed to use PlatformCALayerWinInternal::getSublayers.

  • platform/graphics/ca/win/PlatformCALayerWinInternal.cpp:

(PlatformCALayerWinInternal::getSublayers): Added. Retrieves the list
of PlatformCALayers that represent our sublayers. Significantly, this
code knows about the tile parent layer and can thus exclude it.

  • platform/graphics/ca/win/PlatformCALayerWinInternal.h: Added

getSublayers.

5:13 PM Changeset in webkit [75984] by wsiegrist@apple.com
  • 1 edit in trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg

2011-01-17 William Siegrist <wsiegrist@apple.com>

Explicitly set mode during file upload to ensure web server can read the files.

5:10 PM Changeset in webkit [75983] by thakis@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-01-17 Nico Weber <thakis@chromium.org>

Unreviewed.

Roll chromium DEPS forward to pick up the skia roll to skia r692.
https://bugs.webkit.org/show_bug.cgi?id=52600

  • DEPS:
4:44 PM Changeset in webkit [75982] by commit-queue@webkit.org
  • 5 edits in trunk/Source

2011-01-17 Naoki Takano <takano.naoki@gmail.com>

Reviewed by Kent Tamura.

[Chromium] Fix popup menu re-positioning when the menu is opened upward, above the corresponding form field.
https://bugs.webkit.org/show_bug.cgi?id=51382
http://crbug.com/60427

Calculate correct location of popup window whenever the items in the window change.

No new tests, because this fix is for Chromium project and hard to test only in WebKit project

  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupContainer::layoutAndCalculateWidgetRect): New Function to layout and calculate popup widget rect. (WebCore::PopupContainer::showPopup): Move widgetRect calculation logic to calculateWidgetRect(). (WebCore::PopupContainer::refresh): Add parameter focusRect to take the location and the size of focus text input field to calculate correct popup window location.
  • platform/chromium/PopupMenuChromium.h: Append new input parameter for refresh().

2011-01-17 Naoki Takano <takano.naoki@gmail.com>

Reviewed by Kent Tamura.

[Chromium] Fix popup menu re-positioning when the menu is opened upward, above the corresponding form field.
https://bugs.webkit.org/show_bug.cgi?id=51382
http://crbug.com/60427

Calculate correct location of popup window whenever the items in the window change.

No new tests, because this fix is for Chromium project and hard to test only in WebKit project

  • WebKit/chromium/src/WebViewImpl.cpp: (WebKit::WebViewImpl::refreshAutoFillPopup): Change the logic in refreshAutoFilPopup() to check both the location and the size of popup window.
4:38 PM Changeset in webkit [75981] by jhoneycutt@apple.com
  • 2 edits in trunk/Source/WebKit2

Windows build fix. Unreviewed.

  • Shared/PrintInfo.cpp:

Use #include, not #import.

4:32 PM Changeset in webkit [75980] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

Actually wrote a FIXME promised for a review comment.

  • UIProcess/API/mac/WKView.mm: (-[WKView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
4:27 PM Changeset in webkit [75979] by ap@apple.com
  • 15 edits
    3 adds in trunk/Source/WebKit2

Reviewed by Anders Carlsson and Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=52595
Make basic printing work in WebKit2

  • Shared/WebPreferencesStore.h:
  • UIProcess/API/C/WKPreferences.cpp: (WKPreferencesSetShouldPrintBackgrounds): (WKPreferencesGetShouldPrintBackgrounds):
  • UIProcess/API/C/WKPreferences.h: Implement a preference for printing backgrounds.
  • Shared/PrintInfo.cpp: Added. (WebKit::PrintInfo::encode): (WebKit::PrintInfo::decode):
  • Shared/PrintInfo.h: Added.
  • Shared/mac/PrintInfoMac.mm: Added. (WebKit::PrintInfo::PrintInfo): A new class for passing page setup information down to the web process.
  • WebKit2.xcodeproj/project.pbxproj:
  • GNUmakefile.am:
  • WebKit2.pro:
  • win/WebKit2.vcproj: Added PrintInfo.
  • Scripts/webkit2/messages.py: Added PrintInfo.h to a list of structs.
  • UIProcess/API/mac/WKView.mm: (WKViewData): Cache page count and geometry. (WebFrameWrapper): Added a wrapper class for adding a WebFrameProxy to an NSDictionary. (-[WKView drawRect:]): Added logging. (setFrameBeingPrinted): Store a frame into NSPrintOperation's NSPrintInfo, so that all methods invoked for this operation would know what's being printed. (frameBeingPrinted): Retrieve this data. (-[WKView printOperationWithPrintInfo:forFrame:]): Create a print operation that's appropriate for the frame. (-[WKView knowsPageRange:]): Ask the web process. (-[WKView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]): Take over printing, because I couldn't make drawRect: work correctly with WebKit custom fit to page implementation. (-[WKView _provideTotalScaleFactorForPrintOperation:]): Help AppKit clip correctly. (-[WKView rectForPage:]): Return a pre-calculated rect.
  • UIProcess/WebPageProxy.h: Added m_isInPrintingMode to track whether the web page is in printing mode. The UI process controls that.
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::WebPageProxy): Initialize m_isInPrintingMode. (WebKit::WebPageProxy::beginPrinting): Change printing mode in web process if the value changes. (WebKit::WebPageProxy::endPrinting): Ditto. (WebKit::WebPageProxy::computePagesForPrinting): Ask the web process about output page geometry. (WebKit::WebPageProxy::drawRectToPDF): Ask the web process about printed page data.
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::close): Delete m_printContext while there is still a Frame pointer. (WebKit::WebPage::updatePreferences): Pass through ShouldPrintBackgrounds. (WebKit::WebPage::beginPrinting): Switch into printing mode (or update parameters if we're already in printing mode). (WebKit::WebPage::endPrinting): Delete m_printContext, implicitly calling end(). (WebKit::WebPage::computePagesForPrinting): Make sure that we're in printing mode, and copmute page rects. (WebKit::WebPage::drawRectToPDF): Added a CG specific function to create a PDF document out of a page rect. It should really work for onscreen content, but we only need it for printing.
  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in: Added BeginPrinting, EndPrinting, ComputePagesForPrinting and DrawRectToPDF.
3:59 PM Changeset in webkit [75978] by mrowe@apple.com
  • 5 edits in tags/Safari-534.15.14

Versioning.

3:31 PM Changeset in webkit [75977] by mrowe@apple.com
  • 1 copy in tags/Safari-534.15.14

New tag.

3:15 PM Changeset in webkit [75976] by mrowe@apple.com
  • 2 edits in trunk/Source/WebCore

Fix the 32-bit build.

  • WebCore.exp.in:
3:14 PM Changeset in webkit [75975] by mitz@apple.com
  • 4 edits
    2 adds in trunk

Use of invalid hash map key in CSSFontFaceSource::getFontData() with 0-sized remote font
https://bugs.webkit.org/show_bug.cgi?id=52598

Reviewed by Darin Adler.

Source/WebCore:

Test: fast/css/font-face-zero-hash-key.html

  • css/CSSFontFaceSource.cpp:

(WebCore::CSSFontFaceSource::getFontData): Add 1 to the font size to avoid a 0 hash key.

  • css/CSSSegmentedFontFace.cpp:

(WebCore::CSSSegmentedFontFace::getFontData): Ditto.

LayoutTests:

  • fast/css/font-face-zero-hash-key-expected.txt: Added.
  • fast/css/font-face-zero-hash-key.html: Added.
3:03 PM Changeset in webkit [75974] by ddkilzer@apple.com
  • 4 edits in trunk/Source

<http://webkit.org/b/52596> Add missing DOMDocument/DOMDocumentFragment headers to Xcode project

Reviewed by Dan Bernstein.

WebCore:

This fixes two issues:

Add missing DOMDocumentFragmentPrivate.h and
DOMDocumentPrivate.h files to the project. These files were
never added to the the project although their *Internal.h
counterparts were added in r16548 and r17390.

Add missing DOMDocumentFragmentInternal.h to the Headers
section. It was moved from Headers to "Copy Generated Headers"
in r31045, but it should have an entry in both sections.

  • WebCore.xcodeproj/project.pbxproj:

WebKit/mac:

  • MigrateHeaders.make: Copy DOMDocumentFragmentPrivate.h and

DOMDocumentPrivate.h to the PrivateHeaders directory.

2:54 PM Changeset in webkit [75973] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

2011-01-17 Helder Correia <helder@sencha.com>

Reviewed by Andreas Kling.

[Qt] Incorrect shadow alpha with pattern fillStyle
https://bugs.webkit.org/show_bug.cgi?id=52559

The shadow color opacity needs to be set on the shadow painter.
This is related to bug 52556.

  • fast/canvas/canvas-fillPath-pattern-shadow-expected.txt: Added.
  • fast/canvas/canvas-fillPath-pattern-shadow.html: Added.
  • fast/canvas/script-tests/canvas-fillPath-pattern-shadow.js: Added.

2011-01-17 Helder Correia <helder@sencha.com>

Reviewed by Andreas Kling.

[Qt] Incorrect shadow alpha with pattern fillStyle
https://bugs.webkit.org/show_bug.cgi?id=52559

The shadow color opacity needs to be set on the shadow painter.
This is related to bug 52556.

Test: fast/canvas/canvas-fillPath-pattern-shadow.html

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::fillPath):
2:48 PM Changeset in webkit [75972] by mrobinson@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-01-17 Martin Robinson <mrobinson@igalia.com>

Reviewed by Andreas Kling.

[GTK] Port a crash fix from libsoup upstream to the libsoup cache code
https://bugs.webkit.org/show_bug.cgi?id=52586

No new tests. This is just a merge from upstream.

  • platform/network/soup/cache/soup-http-input-stream.c: (webkit_soup_http_input_stream_got_chunk): Properly handle unsigned numbers.
1:38 PM Changeset in webkit [75971] by tonyg@chromium.org
  • 23 edits in trunk

2011-01-17 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Alexey Proskuryakov.

Fix some headers with missing or misspelled #ifndef guards
https://bugs.webkit.org/show_bug.cgi?id=52545

  • wtf/RefPtrHashMap.h:

2011-01-17 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Alexey Proskuryakov.

Fix some headers with missing or misspelled #ifndef guards
https://bugs.webkit.org/show_bug.cgi?id=52545

No new tests because no new functionality.

  • ForwardingHeaders/runtime/InitializeThreading.h:
  • editing/SmartReplace.h:
  • loader/CrossOriginAccessControl.h:
  • loader/NetscapePlugInStreamLoader.h:
  • platform/chromium/ClipboardUtilitiesChromium.h:
  • platform/graphics/cairo/DrawErrorUnderline.h:
  • platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:
  • platform/graphics/cg/GraphicsContextPlatformPrivateCG.h:
  • platform/graphics/cg/PDFDocumentImage.h:
  • platform/win/WebCoreTextRenderer.h:

2011-01-17 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Alexey Proskuryakov.

Fix some headers with missing or misspelled #ifndef guards
https://bugs.webkit.org/show_bug.cgi?id=52545

  • WebKitStatistics.h:

2011-01-17 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Alexey Proskuryakov.

Fix some headers with missing or misspelled #ifndef guards
https://bugs.webkit.org/show_bug.cgi?id=52545

  • Shared/UserMessageCoders.h:
  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h:
  • WebProcess/InjectedBundle/InjectedBundleUserMessageCoders.h:
  • WebProcess/WebProcessMain.h:

2011-01-17 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Alexey Proskuryakov.

Fix some headers with missing or misspelled #ifndef guards
https://bugs.webkit.org/show_bug.cgi?id=52545

  • DumpRenderTree/chromium/TestEventPrinter.h:
  • DumpRenderTree/chromium/WebPreferences.h:
1:16 PM Changeset in webkit [75970] by ddkilzer@apple.com
  • 2 edits in trunk/LayoutTests

2011-01-17 David Kilzer <ddkilzer@apple.com>

<http://webkit.org/b/52524> fast/dom/Range/range-clone-contents.html fails only on Windows

Reviewed by Alexey Proskuryakov.

  • platform/win/Skipped: Removed fast/dom/Range/range-clone-contents.html. It appears the Windows buildbots need a clean build.
12:59 PM Changeset in webkit [75969] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-01-17 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: follow-up fix for r52574: do not reuse clear() for navigation.

  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype.clear): (WebInspector.NetworkPanel.prototype.mainResourceChanged):
12:53 PM Changeset in webkit [75968] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

Build fix.

  • Platform/Logging.cpp:
12:47 PM Changeset in webkit [75967] by sergio@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-01-17 Sergio Villar Senin <svillar@igalia.com>

Reviewed by Martin Robinson.

[Gtk] No need to content sniff 304 Not Modified responses
https://bugs.webkit.org/show_bug.cgi?id=52570

Makes no sense to wait for the outcome of content sniffing when WebCore
is validating resources. If we get a 304 Not Modified it means that we can
safely use the cached version of the resource we're asking for.

No new tests because it does not change functionality, it just
calls didReceiveResponse sooner for 304 Not Modified responses.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::gotHeadersCallback):
12:22 PM Changeset in webkit [75966] by jberlin@webkit.org
  • 11 edits
    4 adds in trunk

REGRESSION: Assertion failure in FrameLoader::continueLoadAfterWillSubmitForm() when
navigating back to an unreachable URL
https://bugs.webkit.org/show_bug.cgi?id=52388

Reviewed by Anders Carlsson.

Source/WebCore:

Test: http/tests/navigation/go-back-to-error-page.html

  • history/PageCache.cpp:

(WebCore::PageCache::canCachePageContainingThisFrame):
Do not cache any error pages (which we can recognize as having substitute data and/or an
unreachableURL).

Tools:

Add a third parameter (unreachableURL) to queueLoadHTMLString.

  • DumpRenderTree/LayoutTestController.cpp:

(queueLoadHTMLStringCallback):
(LayoutTestController::queueLoadHTMLString):
(LayoutTestController::queueLoadAlternateHTMLString):

  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/WorkQueueItem.h:

(LoadHTMLStringItem::LoadHTMLStringItem):

  • DumpRenderTree/chromium/LayoutTestController.cpp:

(WorkItemLoadHTMLString::WorkItemLoadHTMLString):
(WorkItemLoadHTMLString::run):
(LayoutTestController::queueLoadHTMLString):

  • DumpRenderTree/gtk/WorkQueueItemGtk.cpp:

(LoadHTMLStringItem::invoke):

  • DumpRenderTree/mac/WorkQueueItemMac.mm:

(LoadHTMLStringItem::invoke):

  • DumpRenderTree/win/WorkQueueItemWin.cpp:

(LoadHTMLStringItem::invoke):

LayoutTests:

Add a test that loads an alternate HTML String for an "unreachable" URL, loads another
page, and then goes back to the "unreachable" URL, which is now reachable.

This tests two things:
1) No assertion failure when going back to an unreachable URL.
2) There is no page cached for the unreachable URL.

  • http/tests/navigation/go-back-to-error-page-expected.txt: Added.
  • http/tests/navigation/go-back-to-error-page.html: Added.
  • http/tests/navigation/resources/page-to-go-back-from.html: Added.
  • http/tests/navigation/resources/page-treated-as-unreachable.html: Added.
12:16 PM Changeset in webkit [75965] by ap@apple.com
  • 3 edits in trunk/Source/WebKit2

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=52592
Add a logging channel for WKView

  • Platform/Logging.cpp:
  • Platform/Logging.h:
12:16 PM Changeset in webkit [75964] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-01-17 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: fixing typo in r75952.

  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkDataGridNode.prototype._refreshNameCell):
12:12 PM Changeset in webkit [75963] by enrica@apple.com
  • 6 edits in trunk/Source

Drag and drop support: refactoring of image from link and image from selection
https://bugs.webkit.org/show_bug.cgi?id=52496

Reviewed by Alexey Proskuryakov.

Source/WebCore:

This work cleans up the Mac code and makes it more similar to the Windows implementation,
avoiding the use of an NSView when the FrameView can be used.
The refactoring is a necessary step towards the complete support of drag and drop
in WebKit2.

  • page/mac/FrameMac.mm:

(WebCore::Frame::imageFromRect): Modified to use FrameView instead of NSView
to generate the image for drag.

Source/WebKit/mac:

This work cleans up the Mac code and makes it more similar to the Windows implementation,
avoiding the use of an NSView when the FrameView can be used.
The refactoring is a necessary step towards the complete support of drag and drop
in WebKit2.

  • WebCoreSupport/WebDragClient.mm:

(WebDragClient::createDragImageForLink): Added.

  • WebView/WebHTMLView.mm: Removed dragImageFromLink and dragImageFromURL.
  • WebView/WebHTMLViewPrivate.h: Removed dragImageFromLink and dragImageFromURL.
12:01 PM Changeset in webkit [75962] by andersca@apple.com
  • 6 edits
    3 adds in trunk/Source/WebKit2

2011-01-17 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Factor bitmap context drawing code out into a shared function
https://bugs.webkit.org/show_bug.cgi?id=52589

  • Platform/cg/CGUtilities.h: Added.
  • Platform/cg/CGUtilities.cpp: Added. (WebKit::paintBitmapContext): New function that will paint a bitmap context into a CGContext.
  • Shared/cg/ShareableBitmapCG.cpp: (WebKit::ShareableBitmap::paint): Use paintBitmapContext.
  • UIProcess/mac/BackingStoreMac.mm: (WebKit::BackingStore::paint): (WebKit::BackingStore::scroll): Use paintBitmapContext.
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:
  • win/WebKit2Common.vsprops: Add CGUtilities.{cpp|h}.
11:50 AM Changeset in webkit [75961] by mitz@apple.com
  • 25 edits in trunk

Update xcodeproj svn:ignore to include xcuserdata.

Rubber-stamped by Mark Rowe.

Examples:

  • NetscapeCocoaPlugin/NetscapeCocoaPlugin.xcodeproj: Modified property svn:ignore.
  • NetscapeCoreAnimationMoviePlugin/NetscapeCoreAnimationMoviePlugin.xcodeproj: Modified property svn:ignore.
  • NetscapeCoreAnimationPlugin/NetscapeCoreAnimationPlugin.xcodeproj: Modified property svn:ignore.
  • NetscapeInputMethodPlugin/NetscapeInputMethodPlugin.xcodeproj: Modified property svn:ignore.

Source/JavaScriptCore:

Source/JavaScriptGlue:

  • JavaScriptGlue.xcodeproj: Modified property svn:ignore.

Source/ThirdParty/ANGLE:

  • ANGLE.xcodeproj: Modified property svn:ignore.
  • src/build_angle.xcodeproj: Modified property svn:ignore.

Source/WebCore:

  • WebCore.xcodeproj: Modified property svn:ignore.
  • manual-tests/NPN_Invoke/NPN_Invoke.xcodeproj: Modified property svn:ignore.

Source/WebKit:

  • WebKit.xcodeproj: Modified property svn:ignore.

Source/WebKit2:

  • WebKit2.xcodeproj: Modified property svn:ignore.

Tools:

  • DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
  • MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
  • TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
  • WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
  • WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.
11:48 AM Changeset in webkit [75960] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

Fixing a typo from a bad merge.

  • UIProcess/API/mac/WKView.mm: (-[WKView canChangeFrameLayout:]):
11:43 AM Changeset in webkit [75959] by ap@apple.com
  • 3 edits in trunk/Source/WebKit2

Reviewed by John Sullivan.

https://bugs.webkit.org/show_bug.cgi?id=52590
Should pass a frame into -[WKView canPrintHeadersAndFooters]

  • UIProcess/API/mac/WKView.h:
  • UIProcess/API/mac/WKView.mm: (-[WKView canChangeFrameLayout:]): Also, renamed the method to canChangeFrameLayout.
11:36 AM Changeset in webkit [75958] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

Leopard build fix.

  • page/PrintContext.cpp: GCC complained about shortening a double value to float.
11:27 AM WebKit Team edited by thakis@chromium.org
(diff)
10:47 AM Changeset in webkit [75957] by mrowe@apple.com
  • 3 deletes in trunk

Remove a few more empty directories that I missed.

10:41 AM Changeset in webkit [75956] by mrowe@apple.com
  • 87 deletes in trunk

Remove a large number of empty directories.

10:31 AM Changeset in webkit [75955] by ap@apple.com
  • 6 edits in trunk/Source

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=52495

No change in behavior, so no tests.

  • WebCore.exp.in: Export additional methods, as I'm going to use more code from PrintContext.
  • page/PrintContext.cpp: (WebCore::PrintContext::~PrintContext): No need to clear m_pageRects, the object is being destroyed already. (WebCore::PrintContext::pageCount): Changed page count from int to size_t. (WebCore::PrintContext::pageRect): Ditto. (WebCore::PrintContext::computePageRects): Pass allowHorizontalTiling as an argument. PrintContext already has code to calculate scale factor, so it makes sense to make methods that contain it universal (allowHorizontalTiling is always true for Safari). Round page height to an integer, because Mac code does that, and because page height is treated as integer almost everywhere else in code. (WebCore::PrintContext::begin): Allow calling this function multiple times. There is no need to return to screen mode if e.g. "print backgounds" option changes. (WebCore::PrintContext::computeAutomaticScaleFactor): Expose scale factor computation, so that clients don't have to copy it. (WebCore::PrintContext::spoolRect): Add a way to spool a precomputed rect - handy if a request comes from code that doesn't have page number. (WebCore::PrintContext::pageNumberForElement): Page number int -> size_t.
  • page/PrintContext.h: Added comments and FIXMEs. PrintContext needs cleanup, but that depends on deciding how it really needs to work (e.g. whether computePageRects() should cause relayout).
10:25 AM Changeset in webkit [75954] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

2011-01-17 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: skip flaky inspector test (will look at it tomorrow).

  • platform/mac-leopard/Skipped:
10:21 AM Changeset in webkit [75953] by andersca@apple.com
  • 7 edits in trunk/Source/WebKit2

2011-01-17 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Implement scrolling support
https://bugs.webkit.org/show_bug.cgi?id=52502

  • Shared/UpdateInfo.cpp: (WebKit::UpdateInfo::encode): (WebKit::UpdateInfo::decode):
  • Shared/UpdateInfo.h: Add scrollRect and scrollDelta member variables.
  • UIProcess/BackingStore.h: Add scroll member function.
  • UIProcess/DrawingAreaProxyImpl.cpp: (WebKit::DrawingAreaProxyImpl::incorporateUpdate): Repaint the scroll rect. Force a display of the view when the update info contains a scroll rect.
  • UIProcess/mac/BackingStoreMac.mm: (WebKit::BackingStore::incorporateUpdate): Call scroll.

(WebKit::BackingStore::scroll):
Paint the backing store into itself.

  • WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::display): Pass the scroll information in the update info.
9:51 AM Changeset in webkit [75952] by pfeldman@chromium.org
  • 6 edits in trunk/Source/WebCore

2011-01-17 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: unify image data source assignment, add image url
to the image view properties list.
https://bugs.webkit.org/show_bug.cgi?id=52584

  • English.lproj/localizedStrings.js:
  • inspector/front-end/ImageView.js: (WebInspector.ImageView.prototype._createContentIfNeeded.onImageLoad): (WebInspector.ImageView.prototype._createContentIfNeeded):
  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkDataGridNode.prototype._refreshNameCell):
  • inspector/front-end/Resource.js: (WebInspector.Resource.prototype.populateImageSource): (WebInspector.Resource.prototype._contentURL):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.FrameResourceTreeElement.prototype.onattach):
9:28 AM Changeset in webkit [75951] by beidson@apple.com
  • 2 edits in trunk/Source/WebKit

Fix up the make build on Macs

Rubberstamped by Adam Roben.

  • Makefile: Point to the correct Makefile.shared
9:10 AM Changeset in webkit [75950] by caseq@chromium.org
  • 6 edits in trunk

2011-01-17 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Extensions API] webInspector.resources.onFinished is not fired for redirected resources
Make resource start/finish hanlding more consistent.
https://bugs.webkit.org/show_bug.cgi?id=52452

  • inspector/front-end/AuditLauncherView.js: Ignore WebSocket resources when displaying progress indicator (WebInspector.AuditLauncherView.prototype._resetResourceCount): (WebInspector.AuditLauncherView.prototype.resourceStarted): (WebInspector.AuditLauncherView.prototype.resourceFinished):
  • inspector/front-end/NetworkManager.js: (WebInspector.NetworkManager): Factor out resource start/finish logic to _startResource()/_finishResource() (WebInspector.NetworkManager.prototype.identifierForInitialRequest): (WebInspector.NetworkManager.prototype.willSendRequest): (WebInspector.NetworkManager.prototype.markResourceAsCached): (WebInspector.NetworkManager.prototype.didReceiveResponse): (WebInspector.NetworkManager.prototype.didReceiveContentLength): (WebInspector.NetworkManager.prototype.didFinishLoading): (WebInspector.NetworkManager.prototype.didFailLoading): (WebInspector.NetworkManager.prototype.didLoadResourceFromMemoryCache): (WebInspector.NetworkManager.prototype.didCreateWebSocket): (WebInspector.NetworkManager.prototype.willSendWebSocketHandshakeRequest): (WebInspector.NetworkManager.prototype.didReceiveWebSocketHandshakeResponse): (WebInspector.NetworkManager.prototype.didCloseWebSocket): (WebInspector.NetworkManager.prototype._appendRedirect): (WebInspector.NetworkManager.prototype._startResource): (WebInspector.NetworkManager.prototype._finishResource):

2011-01-17 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Extensions API] webInspector.resources.onFinished is not fired for redirected resources
Added test for finished event being sent for redirected resources.
https://bugs.webkit.org/show_bug.cgi?id=52452

  • http/tests/inspector/extensions-resources-redirect-expected.txt:
  • http/tests/inspector/extensions-resources-redirect.html:
8:42 AM Changeset in webkit [75949] by pfeldman@chromium.org
  • 10 edits in trunk/Source/WebCore

2011-01-17 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: restore dom and network state upon frontend reuse.
https://bugs.webkit.org/show_bug.cgi?id=52574

  • inspector/Inspector.idl:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::restoreInspectorStateFromCookie): (WebCore::InspectorController::populateScriptObjects): (WebCore::InspectorController::pushDataCollectedOffline): (WebCore::InspectorController::didCommitLoad):
  • inspector/InspectorController.h:
  • inspector/front-end/NetworkManager.js: (WebInspector.NetworkManager.prototype.reset):
  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype.clear): (WebInspector.NetworkPanel.prototype.mainResourceChanged):
  • inspector/front-end/ResourceTreeModel.js: (WebInspector.ResourceTreeModel): (WebInspector.ResourceTreeModel.prototype.reloadCachedResources):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.clear):
  • inspector/front-end/inspector.js: (WebInspector.frontendReused):
8:38 AM Changeset in webkit [75948] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

Unreviewed fix after r75908.

Move WebKit into Source
https://bugs.webkit.org/show_bug.cgi?id=52530

  • BuildSlaveSupport/build.webkit.org-config/master.cfg: Add Source to the path for Qt API tests.
8:33 AM Changeset in webkit [75947] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

2011-01-17 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: first timeline-network-resource flakiness.

  • inspector/timeline-network-resource.html:
8:19 AM Changeset in webkit [75946] by caseq@chromium.org
  • 4 edits in trunk/Source/WebKit2

2011-01-17 Andrey Kosyakov <caseq@chromium.org>

Unreviewed. Fixed malformed reference to WebKitVSPropsRedirectionDir that broke win build.

  • win/WebKit2.vcproj:
  • win/WebKit2GeneratedCommon.vsprops:
  • win/WebKit2WebProcess.vcproj:
8:18 AM Changeset in webkit [75945] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

Unreviewed buildfix after r75944.

  • WebCore.pro:
8:00 AM Changeset in webkit [75944] by commit-queue@webkit.org
  • 15 edits
    2 adds in trunk/Source

2011-01-17 Yi Shen <yi.4.shen@nokia.com>

Reviewed by Andreas Kling.

[Qt] Extend the Platform Plugin to support full screen video handler
https://bugs.webkit.org/show_bug.cgi?id=51249

Make MediaPlayerPrivateQt support a fullscreen player.

No new tests because LayoutTests/media/media-fullscreen-inline.html already exists.
However, this test failed for Qt (QtMediaPlayer) due to durationchange event getting fired twice.
So, still skip it for Qt.

  • WebCore.pro:
  • features.pri:
  • platform/graphics/qt/MediaPlayerPrivateQt.cpp: (WebCore::MediaPlayerPrivateQt::MediaPlayerPrivateQt): (WebCore::MediaPlayerPrivateQt::removeVideoItem): (WebCore::MediaPlayerPrivateQt::restoreVideoItem):
  • platform/graphics/qt/MediaPlayerPrivateQt.h: (WebCore::MediaPlayerPrivateQt::supportsFullscreen): (WebCore::MediaPlayerPrivateQt::mediaPlayer):

2011-01-17 Yi Shen <yi.4.shen@nokia.com>

Reviewed by Andreas Kling.

[Qt] Extend the Platform Plugin to support full screen video handler
https://bugs.webkit.org/show_bug.cgi?id=51249

Add a new webkit platform plugin interface to support full screen video handler.

  • Api/qwebkitplatformplugin.h: (QWebFullScreenVideoHandler::QWebFullScreenVideoHandler): (QWebFullScreenVideoHandler::~QWebFullScreenVideoHandler):
  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::ChromeClientQt): (WebCore::ChromeClientQt::~ChromeClientQt): (WebCore::ChromeClientQt::fullScreenVideo): (WebCore::ChromeClientQt::supportsFullscreenForNode): (WebCore::ChromeClientQt::requiresFullscreenForVideoPlayback): (WebCore::ChromeClientQt::enterFullscreenForNode): (WebCore::ChromeClientQt::exitFullscreenForNode):
  • WebCoreSupport/ChromeClientQt.h:
  • WebCoreSupport/FullScreenVideoQt.cpp: Added. (WebCore::FullScreenVideoQt::FullScreenVideoQt): (WebCore::FullScreenVideoQt::~FullScreenVideoQt): (WebCore::FullScreenVideoQt::enterFullScreenForNode): (WebCore::FullScreenVideoQt::exitFullScreenForNode): (WebCore::FullScreenVideoQt::aboutToClose): (WebCore::FullScreenVideoQt::mediaPlayer): (WebCore::FullScreenVideoQt::mediaPlayerForNode): (WebCore::FullScreenVideoQt::requiresFullScreenForVideoPlayback):
  • WebCoreSupport/FullScreenVideoQt.h: Added. (WebCore::FullScreenVideoQt::isValid):
  • WebCoreSupport/QtPlatformPlugin.cpp: (WebCore::QtPlatformPlugin::createFullScreenVideoHandler):
  • WebCoreSupport/QtPlatformPlugin.h:
  • examples/platformplugin/WebPlugin.cpp: (FullScreenVideoWidget::FullScreenVideoWidget): (FullScreenVideoWidget::event): (FullScreenVideoWidget::keyPressEvent): (FullScreenVideoHandler::FullScreenVideoHandler): (FullScreenVideoHandler::~FullScreenVideoHandler): (FullScreenVideoHandler::requiresFullScreenForVideoPlayback): (FullScreenVideoHandler::enterFullScreen): (FullScreenVideoHandler::exitFullScreen): (WebPlugin::supportsExtension): (WebPlugin::createExtension):
  • examples/platformplugin/WebPlugin.h: (FullScreenVideoWidget::~FullScreenVideoWidget):
  • examples/platformplugin/platformplugin.pro:
  • examples/platformplugin/qwebkitplatformplugin.h: (QWebFullScreenVideoHandler::QWebFullScreenVideoHandler): (QWebFullScreenVideoHandler::~QWebFullScreenVideoHandler):
7:50 AM Changeset in webkit [75943] by podivilov@chromium.org
  • 5 edits in trunk/LayoutTests

2011-01-17 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: fix flaky debugger tests.
https://bugs.webkit.org/show_bug.cgi?id=51320

  • http/tests/inspector/debugger-test2.js: (initialize_DebuggerTest.InspectorTest.setBreakpoint):
  • inspector/debugger-breakpoints-not-activated-on-reload.html:
  • inspector/debugger-pause-on-breakpoint-expected.txt:
  • inspector/debugger-pause-on-breakpoint.html:
7:42 AM Changeset in webkit [75942] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

Unreviewed.

Remove accidentally committed debug printing after r75908.

  • Scripts/webkitdirs.pm:
7:38 AM Changeset in webkit [75941] by Csaba Osztrogonác
  • 280 edits
    556 adds in trunk/LayoutTests

Unreviewed.

Add Qt specific expected results for passing CSS tests.
Compared to Mac png files and Mac expected files.

  • platform/qt/Skipped: Unskip passing tests.
  • platform/qt/css1/[...]: Added.
  • platform/qt/css2.1/[...]: Added.
  • platform/qt/css3/[...]: Added.
6:59 AM Changeset in webkit [75940] by rik@webkit.org
  • 6 edits in trunk

2011-01-17 Anthony Ricaud <rik@webkit.org>

Reviewed by Kent Tamura.

[HTML5] Revert display:none on datalist
https://bugs.webkit.org/show_bug.cgi?id=52214

  • fast/forms/datalist-expected.txt:
  • fast/forms/datalist-nonoption-child-expected.txt:
  • fast/forms/datalist.html:

2011-01-17 Anthony Ricaud <rik@webkit.org>

Reviewed by Kent Tamura.

[HTML5] Revert display:none on datalist
https://bugs.webkit.org/show_bug.cgi?id=52214

  • css/html.css:
6:31 AM Changeset in webkit [75939] by pfeldman@chromium.org
  • 13 edits in trunk/Source

2011-01-17 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: simplify debugger enabling routine.
https://bugs.webkit.org/show_bug.cgi?id=52472

  • inspector/Inspector.idl:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::restoreDebugger): (WebCore::InspectorController::showAndEnableDebugger): (WebCore::InspectorController::enableDebugger):
  • inspector/InspectorController.h:
  • inspector/front-end/DebuggerModel.js:
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.show): (WebInspector.ScriptsPanel.prototype._toggleDebugging):

2011-01-17 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: simplify debugger enabling routine.
https://bugs.webkit.org/show_bug.cgi?id=52472

2011-01-17 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: simplify debugger enabling routine.
https://bugs.webkit.org/show_bug.cgi?id=52472

  • WebInspector.cpp: (WebInspector::toggleDebuggingJavaScript):

2011-01-17 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: simplify debugger enabling routine.
https://bugs.webkit.org/show_bug.cgi?id=52472

  • WebProcess/WebPage/WebInspector.cpp: (WebKit::WebInspector::startJavaScriptDebugging):
6:25 AM Changeset in webkit [75938] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-01-17 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Chromium: updated DevTools tests.

  • src/js/Tests.js: (.TestSuite.prototype._waitForScriptPause): (.TestSuite.prototype._waitUntilScriptsAreParsed.waitForAllScripts): (.TestSuite.prototype._waitUntilScriptsAreParsed):
6:13 AM Changeset in webkit [75937] by podivilov@chromium.org
  • 9 edits in trunk

2011-01-17 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: refactoring: encapsulate lazy initialization of SourceFrame.
https://bugs.webkit.org/show_bug.cgi?id=51738

  • http/tests/inspector/debugger-test2.js: (initialize_DebuggerTest.InspectorTest.showScriptSource): (initialize_DebuggerTest.InspectorTest._showScriptSource):
  • inspector/debugger-pause-in-eval-script-expected.txt:
  • inspector/debugger-pause-in-eval-script.html:

2011-01-17 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: refactoring: encapsulate lazy initialization of SourceFrame.
https://bugs.webkit.org/show_bug.cgi?id=51738

Extract content loading logic from SourceView and ScriptView to ContentProvider implementations.
Pass ContentProvider in SourceFrame constructor to allow SourceFrame manage it's lazy initialization.

  • inspector/front-end/ScriptView.js: (WebInspector.ScriptView): (WebInspector.SourceFrameContentProviderForScript): (WebInspector.SourceFrameContentProviderForScript.prototype.requestContent.didRequestSource): (WebInspector.SourceFrameContentProviderForScript.prototype.requestContent): (WebInspector.SourceFrameContentProviderForScript.prototype.scripts):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._addScript): (WebInspector.ScriptsPanel.prototype.sourceFrameForScript): (WebInspector.ScriptsPanel.prototype._sourceFrameForResource):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame): (WebInspector.SourceFrame.prototype.set visible): (WebInspector.SourceFrame.prototype._createTextViewer): (WebInspector.SourceFrame.prototype._breakpointAdded): (WebInspector.SourceFrame.prototype._breakpoints): (WebInspector.SourceFrame.prototype._sourceIDForLine): (WebInspector.SourceFrame.prototype._sourceIDSet): (WebInspector.SourceFrameContentProvider): (WebInspector.SourceFrameContentProvider.prototype.requestContent): (WebInspector.SourceFrameContentProvider.prototype.scripts):
  • inspector/front-end/SourceView.js: (WebInspector.SourceView): (WebInspector.SourceView.prototype.show): (WebInspector.SourceView.prototype.resize): (WebInspector.SourceView.prototype.performSearch.didFindSearchMatches): (WebInspector.SourceView.prototype.performSearch): (WebInspector.SourceView.prototype.revealLine): (WebInspector.SourceView.prototype.highlightLine): (WebInspector.SourceView.prototype._jumpToSearchResult): (WebInspector.SourceFrameContentProviderForResource): (WebInspector.SourceFrameContentProviderForResource.prototype.requestContent): (WebInspector.SourceFrameContentProviderForResource.prototype.scripts):
6:09 AM Changeset in webkit [75936] by jknotten@chromium.org
  • 2 edits in trunk/Tools

2011-01-17 John Knottenbelt <jknotten@chromium.org>

Unreviewed.

Add myself to committers list
https://bugs.webkit.org/show_bug.cgi?id=52566

  • Scripts/webkitpy/common/config/committers.py:
5:28 AM Changeset in webkit [75935] by kbalazs@webkit.org
  • 4 edits in trunk/Source/WebKit2

2011-01-17 Balazs Kelemen <kbalazs@webkit.org>

Reviewed by Andreas Kling.

[Qt][WK2] Crash due to double destruction of QSharedMemory
https://bugs.webkit.org/show_bug.cgi?id=52569

Avoid deleting the QSharedMemory twice.

  • Platform/qt/SharedMemoryQt.cpp: (WebKit::SharedMemory::~SharedMemory):
  • Shared/qt/CleanupHandler.cpp: Renamed m_inDeleteObjects to m_hasStartedDeleting and added a getter for it. (WebKit::CleanupHandler::CleanupHandler): (WebKit::CleanupHandler::deleteObjects):
  • Shared/qt/CleanupHandler.h: (WebKit::CleanupHandler::unmark): (WebKit::CleanupHandler::hasStartedDeleting):
4:21 AM Changeset in webkit [75934] by jknotten@chromium.org
  • 9 edits
    4 adds in trunk

2011-01-17 John Knottenbelt <jknotten@chromium.org>

Reviewed by Jeremy Orlow.

GeolocationController should call stopUpdating on destruction
https://bugs.webkit.org/show_bug.cgi?id=52216

fast/dom/window-close-crash.html tests that we do not fail the
assertion in the mock GeolocationClient that the GeolocationClient
is not updating when the GeolocationController is destroyed.

  • fast/dom/Geolocation/resources/window-close-popup.html: Added.
  • fast/dom/Geolocation/script-tests/window-close-crash.js: Added. (gotPosition): (waitForWindowToClose): (failedToCreateWatch):
  • fast/dom/Geolocation/window-close-crash-expected.txt: Added.
  • fast/dom/Geolocation/window-close-crash.html: Added.
  • platform/gtk/Skipped:
  • platform/mac-wk2/Skipped:
  • platform/qt-wk2/Skipped:

2011-01-17 John Knottenbelt <jknotten@chromium.org>

Reviewed by Jeremy Orlow.

GeolocationController should call stopUpdating on destruction
https://bugs.webkit.org/show_bug.cgi?id=52216

Test: fast/dom/Geolocation/window-close-crash.html

  • page/GeolocationController.cpp: (WebCore::GeolocationController::~GeolocationController):

2011-01-17 John Knottenbelt <jknotten@chromium.org>

Reviewed by Jeremy Orlow.

GeolocationController should call stopUpdating on destruction
https://bugs.webkit.org/show_bug.cgi?id=52216

fast/dom/Geolocation/window-close-crash.html requires that a
Geolocation watch be started in a secondary window. Consequently,
we need to allow geolocation permission and provide a mock
geolocation position for the secondary window's
GeolocationClientMock.

  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::setGeolocationPermission): (LayoutTestController::setMockGeolocationPosition): (LayoutTestController::setMockGeolocationError):
  • DumpRenderTree/chromium/TestShell.h: (TestShell::windowList):
3:02 AM Changeset in webkit [75933] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-01-17 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: Qt build fix.

  • inspector/InspectorInstrumentation.h:
2:44 AM Changeset in webkit [75932] by pfeldman@chromium.org
  • 30 edits in trunk/Source/WebCore

2011-01-16 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: make WebCore use InspectorInstrumentation
for instrumentation calls.
https://bugs.webkit.org/show_bug.cgi?id=52532

This change makes WebCore classes issue instrumentation signals
by means of InspectorInstrumentation interface. It covered migration
for Document, FrameLoader, Database, DOMStorage, etc. It fixed
instrumentation handling for Console as well. This all is a part
of story described in the bug 52510.

  • dom/Document.cpp: (WebCore::Document::finishedParsing):
  • dom/Document.h:
  • dom/ScriptExecutionContext.h:
  • inspector/InspectorBrowserDebuggerAgent.cpp: (WebCore::InspectorBrowserDebuggerAgent::InspectorBrowserDebuggerAgent): (WebCore::InspectorBrowserDebuggerAgent::setDOMBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::removeDOMBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::willInsertDOMNode): (WebCore::InspectorBrowserDebuggerAgent::willRemoveDOMNode): (WebCore::InspectorBrowserDebuggerAgent::willModifyDOMAttr): (WebCore::InspectorBrowserDebuggerAgent::descriptionForDOMEvent): (WebCore::InspectorBrowserDebuggerAgent::pauseOnNativeEventIfNeeded): (WebCore::InspectorBrowserDebuggerAgent::willSendXMLHttpRequest):
  • inspector/InspectorBrowserDebuggerAgent.h: (WebCore::InspectorBrowserDebuggerAgent::create):
  • inspector/InspectorConsoleAgent.cpp: (WebCore::InspectorConsoleAgent::stopTiming): (WebCore::InspectorConsoleAgent::count):
  • inspector/InspectorConsoleAgent.h:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::~InspectorController): (WebCore::InspectorController::handleMousePress): (WebCore::InspectorController::didClearWindowObjectInWorld): (WebCore::PostWorkerNotificationToFrontendTask::performTask):
  • inspector/InspectorController.h:
  • inspector/InspectorDOMAgent.h:
  • inspector/InspectorDOMStorageAgent.h:
  • inspector/InspectorDatabaseAgent.cpp:
  • inspector/InspectorDatabaseAgent.h:
  • inspector/InspectorFrontendHost.cpp:
  • inspector/InspectorFrontendHost.h:
  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::didClearWindowObjectInWorldImpl): (WebCore::InspectorInstrumentation::inspectedPageDestroyedImpl): (WebCore::InspectorInstrumentation::mouseDidMoveOverElementImpl): (WebCore::InspectorInstrumentation::handleMousePressImpl): (WebCore::InspectorInstrumentation::mainResourceFiredLoadEventImpl): (WebCore::InspectorInstrumentation::mainResourceFiredDOMContentEventImpl): (WebCore::InspectorInstrumentation::frameDetachedFromParentImpl): (WebCore::InspectorInstrumentation::didCommitLoadImpl): (WebCore::InspectorInstrumentation::addMessageToConsoleImpl): (WebCore::InspectorInstrumentation::consoleCountImpl): (WebCore::InspectorInstrumentation::startConsoleTimingImpl): (WebCore::InspectorInstrumentation::stopConsoleTimingImpl): (WebCore::InspectorInstrumentation::consoleMarkTimelineImpl): (WebCore::InspectorInstrumentation::addStartProfilingMessageToConsoleImpl): (WebCore::InspectorInstrumentation::didOpenDatabaseImpl): (WebCore::InspectorInstrumentation::didUseDOMStorageImpl): (WebCore::InspectorInstrumentation::didCreateWorkerImpl): (WebCore::InspectorInstrumentation::didDestroyWorkerImpl): (WebCore::InspectorInstrumentation::didCreateWebSocketImpl): (WebCore::InspectorInstrumentation::willSendWebSocketHandshakeRequestImpl): (WebCore::InspectorInstrumentation::didReceiveWebSocketHandshakeResponseImpl): (WebCore::InspectorInstrumentation::didCloseWebSocketImpl): (WebCore::InspectorInstrumentation::networkStateChangedImpl): (WebCore::InspectorInstrumentation::updateApplicationCacheStatusImpl):
  • inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::inspectorControllerCreated): (WebCore::InspectorInstrumentation::inspectorControllerDeleted): (WebCore::InspectorInstrumentation::didClearWindowObjectInWorld): (WebCore::InspectorInstrumentation::inspectedPageDestroyed): (WebCore::InspectorInstrumentation::willInsertDOMNode): (WebCore::InspectorInstrumentation::didInsertDOMNode): (WebCore::InspectorInstrumentation::willRemoveDOMNode): (WebCore::InspectorInstrumentation::willModifyDOMAttr): (WebCore::InspectorInstrumentation::didModifyDOMAttr): (WebCore::InspectorInstrumentation::mouseDidMoveOverElement): (WebCore::InspectorInstrumentation::handleMousePress): (WebCore::InspectorInstrumentation::characterDataModified): (WebCore::InspectorInstrumentation::willSendXMLHttpRequest): (WebCore::InspectorInstrumentation::didScheduleResourceRequest): (WebCore::InspectorInstrumentation::didInstallTimer): (WebCore::InspectorInstrumentation::didRemoveTimer): (WebCore::InspectorInstrumentation::willCallFunction): (WebCore::InspectorInstrumentation::willChangeXHRReadyState): (WebCore::InspectorInstrumentation::willDispatchEvent): (WebCore::InspectorInstrumentation::willDispatchEventOnWindow): (WebCore::InspectorInstrumentation::willEvaluateScript): (WebCore::InspectorInstrumentation::willFireTimer): (WebCore::InspectorInstrumentation::willLayout): (WebCore::InspectorInstrumentation::willLoadXHR): (WebCore::InspectorInstrumentation::willPaint): (WebCore::InspectorInstrumentation::willRecalculateStyle): (WebCore::InspectorInstrumentation::identifierForInitialRequest): (WebCore::InspectorInstrumentation::willSendRequest): (WebCore::InspectorInstrumentation::markResourceAsCached): (WebCore::InspectorInstrumentation::didLoadResourceFromMemoryCache): (WebCore::InspectorInstrumentation::willReceiveResourceData): (WebCore::InspectorInstrumentation::willReceiveResourceResponse): (WebCore::InspectorInstrumentation::didReceiveContentLength): (WebCore::InspectorInstrumentation::didFinishLoading): (WebCore::InspectorInstrumentation::didFailLoading): (WebCore::InspectorInstrumentation::resourceRetrievedByXMLHttpRequest): (WebCore::InspectorInstrumentation::scriptImported): (WebCore::InspectorInstrumentation::mainResourceFiredLoadEvent): (WebCore::InspectorInstrumentation::mainResourceFiredDOMContentEvent): (WebCore::InspectorInstrumentation::frameDetachedFromParent): (WebCore::InspectorInstrumentation::didCommitLoad): (WebCore::InspectorInstrumentation::willWriteHTML): (WebCore::InspectorInstrumentation::didOpenDatabase): (WebCore::InspectorInstrumentation::didUseDOMStorage): (WebCore::InspectorInstrumentation::didCreateWorker): (WebCore::InspectorInstrumentation::didDestroyWorker): (WebCore::InspectorInstrumentation::didCreateWebSocket): (WebCore::InspectorInstrumentation::willSendWebSocketHandshakeRequest): (WebCore::InspectorInstrumentation::didReceiveWebSocketHandshakeResponse): (WebCore::InspectorInstrumentation::didCloseWebSocket): (WebCore::InspectorInstrumentation::networkStateChanged): (WebCore::InspectorInstrumentation::updateApplicationCacheStatus): (WebCore::InspectorInstrumentation::addMessageToConsole): (WebCore::InspectorInstrumentation::consoleCount): (WebCore::InspectorInstrumentation::startConsoleTiming): (WebCore::InspectorInstrumentation::stopConsoleTiming): (WebCore::InspectorInstrumentation::consoleMarkTimeline): (WebCore::InspectorInstrumentation::addStartProfilingMessageToConsole): (WebCore::InspectorInstrumentation::inspectorControllerForContext): (WebCore::InspectorInstrumentation::inspectorControllerForFrame): (WebCore::InspectorInstrumentation::inspectorControllerForPage): (WebCore::InspectorInstrumentation::inspectorControllerWithFrontendForContext): (WebCore::InspectorInstrumentation::inspectorControllerWithFrontendForDocument): (WebCore::InspectorInstrumentation::inspectorControllerWithFrontendForFrame): (WebCore::InspectorInstrumentation::inspectorControllerWithFrontendForPage):
  • inspector/InspectorState.cpp:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::detachFromParent): (WebCore::FrameLoader::dispatchDidClearWindowObjectInWorld): (WebCore::FrameLoader::dispatchDidCommitLoad):
  • page/Chrome.cpp: (WebCore::Chrome::mouseDidMoveOverElement):
  • page/Console.cpp: (WebCore::Console::addMessage): (WebCore::Console::count): (WebCore::Console::markTimeline): (WebCore::Console::profile): (WebCore::Console::time): (WebCore::Console::timeEnd): (WebCore::Console::group): (WebCore::Console::groupCollapsed): (WebCore::Console::groupEnd):
  • page/DOMWindow.cpp: (WebCore::DOMWindow::sessionStorage): (WebCore::DOMWindow::localStorage): (WebCore::DOMWindow::dispatchLoadEvent):
  • page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEvent):
  • page/Page.cpp: (WebCore::Page::~Page):
  • storage/Database.cpp: (WebCore::Database::openDatabase):
  • workers/AbstractWorker.cpp: (WebCore::AbstractWorker::onDestroyWorker):
  • workers/SharedWorker.cpp: (WebCore::SharedWorker::create):
  • workers/Worker.cpp: (WebCore::Worker::create):
  • workers/WorkerMessagingProxy.cpp:
2:15 AM Changeset in webkit [75931] by abarth@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-01-17 Adam Barth <abarth@webkit.org>

Update path to reflect new WebKit directory location.

  • tests/WebFrameTest.cpp: (WebKit::WebFrameTest::registerMockedURLLoad):
2:08 AM Changeset in webkit [75930] by loislo@chromium.org
  • 3 edits in trunk/LayoutTests

2011-01-14 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Enable inspector's tests for chromium Linux.
https://bugs.webkit.org/show_bug.cgi?id=52445

  • platform/chromium/inspector/timeline-network-resource-expected.txt:
  • platform/chromium/test_expectations.txt:
1:40 AM Changeset in webkit [75929] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Source/WebCore

2011-01-17 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Unreviewed, rolling out r75923.

GTK guy rolls out the r75914.

  • platform/efl/ScrollViewEfl.cpp: (WebCore::ScrollView::platformInit):
1:26 AM Changeset in webkit [75928] by Philippe Normand
  • 3 edits in trunk/Source/WebKit/gtk

2011-01-17 Philippe Normand <pnormand@igalia.com>

Unreviewed, build fix for 2 GTK tests html file paths.

  • tests/testmimehandling.c: (main):
  • tests/testwebview.c:
1:25 AM Changeset in webkit [75927] by commit-queue@webkit.org
  • 4 edits in trunk

2011-01-17 Helder Correia <helder@sencha.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] fast/canvas/canvas-fillPath-gradient-shadow.html does not pass
https://bugs.webkit.org/show_bug.cgi?id=52556

The shadow color opacity needs to be set on the shadow painter.
Additionally, the gradient brush should be transformed.

  • platform/qt/Skipped: Remove test from skipped list.

2011-01-17 Helder Correia <helder@sencha.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] fast/canvas/canvas-fillPath-gradient-shadow.html does not pass
https://bugs.webkit.org/show_bug.cgi?id=52556

The shadow color opacity needs to be set on the shadow painter.
Additionally, the gradient brush should be transformed.

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::fillPath):
12:50 AM Changeset in webkit [75926] by noam.rosenthal@nokia.com
  • 2 edits in trunk/Source/WebCore

2011-01-17 No'am Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Background image rendering is slow
https://bugs.webkit.org/show_bug.cgi?id=50527

When tiling a scaled pixmap in Image::drawPattern, scale the tile
first and only then draw it to the target. Do so only when drawing
more than one tile.

Tests in fast/backgrounds/size cover this.

  • platform/graphics/qt/ImageQt.cpp: (WebCore::Image::drawPattern):
12:28 AM Changeset in webkit [75925] by Laszlo Gombos
  • 2 edits in trunk/Source/WebCore

2011-01-17 Laszlo Gombos <Laszlo Gombos>

Reviewed by Simon Hausmann.

[Qt] [Symbian] Fix building NPAPI support
https://bugs.webkit.org/show_bug.cgi?id=51981

Make sure that npapi.h is always included outside of the extern "C"
linkage declaration block.

No new tests as there is no new functionality.

  • bridge/npruntime.h:
12:26 AM Changeset in webkit [75924] by Philippe Normand
  • 6 edits in trunk

2011-01-17 Philippe Normand <pnormand@igalia.com>

Unreviewed, rolling out r75914.
http://trac.webkit.org/changeset/75914
https://bugs.webkit.org/show_bug.cgi?id=49177

multiple crashes on GTK

  • platform/gtk/Skipped:

2011-01-17 Philippe Normand <pnormand@igalia.com>

Unreviewed, rolling out r75914.
http://trac.webkit.org/changeset/75914
https://bugs.webkit.org/show_bug.cgi?id=49177

multiple crashes on GTK

  • platform/ScrollView.cpp: (WebCore::ScrollView::removeChild): (WebCore::ScrollView::wheelEvent):
  • platform/gtk/MainFrameScrollbarGtk.cpp: (MainFrameScrollbarGtk::attachAdjustment): (MainFrameScrollbarGtk::gtkValueChanged):
  • platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollView::platformInit): (WebCore::ScrollView::platformAddChild): (WebCore::ScrollView::platformRemoveChild):
12:05 AM Changeset in webkit [75923] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Source/WebCore

2011-01-17 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Unreviewed build fix.

Bug 49177's patch enabled platformInit() in super class(ScrollView).
But, it didn't removed the function in ScrollViewEfl.cpp.

  • platform/efl/ScrollViewEfl.cpp:
Note: See TracTimeline for information about the timeline view.