Context Navigation

← Previous Period
Next Period →

Timeline

01/24/11:

22:44 Changeset [76576] by mihaip@chromium.org

2011-01-24 Mihai Parparita <mihaip@chromium.org>

Unreviewed. Missed move of one m_deleted use to be outside NDEBUG block
in r76575.

loader/cache/CachedResource.cpp: (WebCore::CachedResource::~CachedResource):

22:17 Changeset [76575] by mihaip@chromium.org

2011-01-24 Mihai Parparita <mihaip@chromium.org>

Reviewed by Tony Chang.

Add runtime checks for invariants in memory cache
https://bugs.webkit.org/show_bug.cgi?id=53059

To help track down bug 53045, add some CRASH calls in addition to
ASSERTs, so that we can track down failures in reliability bots.

Just some checks, no new tests necessary.

css/CSSImageValue.cpp: (WebCore::CSSImageValue::cachedImage):
loader/cache/CachedResource.h:
loader/cache/CachedResource.cpp: (WebCore::CachedResource::~CachedResource):

22:15 Changeset [76574] by mjs@apple.com

2011-01-24 Maciej Stachowiak <mjs@apple.com>

Reviewed by Dan Bernstein.

Implement database quota callback to fix storage tests on WebKit2 bot
https://bugs.webkit.org/show_bug.cgi?id=53064

WebKitTestRunner/TestController.cpp: (WTR::exceededDatabaseQuota): (WTR::TestController::createOtherPage): (WTR::TestController::initialize):

22:09 Changeset [76573] by simon.fraser@apple.com

2011-01-24 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

Leaking CSSRuleDataList objects
https://bugs.webkit.org/show_bug.cgi?id=53062

Fix leaked CSSRuleDataLists added to the m_pseudoRules hash.

css/CSSStyleSelector.cpp: (WebCore::CSSRuleSet::~CSSRuleSet):

22:05 Changeset [76572] by tkent@chromium.org

2011-01-24 Kent Tamura <tkent@chromium.org>

Unreviewed, test expectation update.

Chromium-Linux rebaseline for r76567.

platform/chromium-linux/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.checksum:
platform/chromium-linux/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.png:
platform/chromium-linux/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt:
platform/chromium-linux/fast/speech/input-appearance-numberandspeech-expected.checksum:
platform/chromium-linux/fast/speech/input-appearance-numberandspeech-expected.png:
platform/chromium-linux/fast/speech/input-appearance-numberandspeech-expected.txt:
platform/chromium/test_expectations.txt:

21:52 Changeset [76571] by simon.fraser@apple.com

2011-01-24 Simon Fraser <simon.fraser@apple.com>

Reviewed by Eric Seidel.

Refcount Images used in rendering code
https://bugs.webkit.org/show_bug.cgi?id=52701

Change StyleImage::image(RenderObject*, const IntSize&) and
CSSImageGeneratorValue::image(RenderObject*, const IntSize&) to
return PassRefPtr<Image>, and adjust other code accordingly.

This allows us to return one-time images, for example for CSS gradients
whose appearance may change depending on factors other than the renderer
and the destination size.

css/CSSCanvasValue.cpp: (WebCore::CSSCanvasValue::image):
css/CSSCanvasValue.h:
css/CSSGradientValue.cpp: (WebCore::CSSGradientValue::image):
css/CSSGradientValue.h:
css/CSSImageGeneratorValue.h:
rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintFillLayerExtended): (WebCore::RenderBoxModelObject::paintNinePieceImage):
rendering/RenderImage.cpp: (WebCore::RenderImage::paintReplaced): (WebCore::RenderImage::paintIntoRect):
rendering/RenderImageResource.h: (WebCore::RenderImageResource::image):
rendering/RenderImageResourceStyleImage.h: (WebCore::RenderImageResourceStyleImage::image):
rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::paint):
rendering/style/StyleCachedImage.cpp: (WebCore::StyleCachedImage::image):
rendering/style/StyleCachedImage.h:
rendering/style/StyleGeneratedImage.cpp: (WebCore::StyleGeneratedImage::image):
rendering/style/StyleGeneratedImage.h:
rendering/style/StyleImage.h:
rendering/style/StylePendingImage.h: (WebCore::StylePendingImage::image):
rendering/svg/RenderSVGImage.cpp: (WebCore::RenderSVGImage::paint):

21:38 Changeset [76570] by mrobinson@webkit.org

2011-01-24 Martin Robinson <mrobinson@igalia.com>

Skip a slightly different set of tests after r76555. Seems that some of these
failures are cascading.

platform/gtk/Skipped: Update the skipped list.

21:17 Changeset [76569] by tony@chromium.org

2011-01-24 Tony Chang <tony@chromium.org>

Unreviewed, reverting 5 changes of baselines that are incorrect for Linux.
Mark win tests as failing for now.

platform/chromium-linux/fast/css/acid2-expected.txt: Removed.
platform/chromium-linux/fast/css/acid2-pixel-expected.checksum:
platform/chromium-linux/fast/css/acid2-pixel-expected.png:
platform/chromium-linux/fast/css/acid2-pixel-expected.txt: Removed.
platform/chromium-linux/fast/forms/button-sizes-expected.checksum:
platform/chromium-linux/fast/forms/button-sizes-expected.png:
platform/chromium-linux/fast/forms/button-sizes-expected.txt:
platform/chromium-linux/fast/forms/input-button-sizes-expected.checksum:
platform/chromium-linux/fast/forms/input-button-sizes-expected.png:
platform/chromium-linux/fast/forms/input-button-sizes-expected.txt:
platform/chromium-linux/http/tests/misc/acid2-expected.txt: Removed.
platform/chromium-linux/http/tests/misc/acid2-pixel-expected.checksum:
platform/chromium-linux/http/tests/misc/acid2-pixel-expected.png:
platform/chromium-linux/http/tests/misc/acid2-pixel-expected.txt: Removed.
platform/chromium-linux/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt: Removed.
platform/chromium-linux/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt: Removed.
platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-03-t-expected.txt: Removed.
platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt: Removed.
platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-36-t-expected.txt: Removed.
platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-40-t-expected.txt: Removed.
platform/chromium-linux/svg/W3C-SVG-1.1/fonts-desc-02-t-expected.txt: Removed.
platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.txt: Removed.
platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.txt: Removed.
platform/chromium-linux/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.txt: Removed.
platform/chromium-linux/svg/W3C-SVG-1.1/interact-zoom-01-t-expected.txt: Added.
platform/chromium-linux/svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt: Removed.
platform/chromium-linux/svg/W3C-SVG-1.1/render-groups-01-b-expected.txt: Removed.
platform/chromium-linux/svg/W3C-SVG-1.1/render-groups-03-t-expected.txt: Removed.
platform/chromium-linux/svg/W3C-SVG-1.1/text-text-01-b-expected.txt:
platform/chromium-linux/svg/W3C-SVG-1.1/text-text-04-t-expected.txt: Removed.
platform/chromium-linux/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt: Removed.
platform/chromium-linux/svg/custom/svg-fonts-in-html-expected.txt: Removed.
platform/chromium-linux/svg/custom/svg-fonts-with-no-element-reference-expected.txt: Removed.
platform/chromium-linux/svg/hixie/perf/003-expected.txt: Added.
platform/chromium-linux/svg/hixie/perf/004-expected.txt: Added.
platform/chromium-linux/svg/hixie/perf/005-expected.txt: Added.
platform/chromium-linux/svg/hixie/perf/006-expected.txt: Added.
platform/chromium-linux/svg/hixie/viewbox/preserveAspectRatio/001-expected.txt: Added.
platform/chromium-linux/svg/hixie/viewbox/preserveAspectRatio/002-expected.txt: Added.
platform/chromium-linux/svg/text/text-hkern-expected.txt: Removed.
platform/chromium-linux/svg/text/text-hkern-on-vertical-text-expected.checksum: Removed.
platform/chromium-linux/svg/text/text-hkern-on-vertical-text-expected.png: Removed.
platform/chromium-linux/svg/text/text-hkern-on-vertical-text-expected.txt: Removed.
platform/chromium-linux/svg/text/text-text-01-b-expected.checksum:
platform/chromium-linux/svg/text/text-text-01-b-expected.png:
platform/chromium-linux/svg/text/text-text-01-b-expected.txt:
platform/chromium-linux/svg/text/text-text-04-t-expected.txt: Removed.
platform/chromium-linux/svg/text/text-vkern-expected.checksum: Removed.
platform/chromium-linux/svg/text/text-vkern-expected.txt: Removed.
platform/chromium-linux/svg/text/text-vkern-on-horizontal-text-expected.txt: Removed.
platform/chromium-win/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt: Removed.
platform/chromium-win/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt: Removed.
platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-03-t-expected.txt:
platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt:
platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-36-t-expected.txt:
platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-40-t-expected.txt:
platform/chromium-win/svg/W3C-SVG-1.1/fonts-desc-02-t-expected.txt:
platform/chromium-win/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.txt:
platform/chromium-win/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.txt:
platform/chromium-win/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.txt:
platform/chromium-win/svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt:
platform/chromium-win/svg/W3C-SVG-1.1/render-groups-01-b-expected.txt:
platform/chromium-win/svg/W3C-SVG-1.1/render-groups-03-t-expected.txt:
platform/chromium-win/svg/W3C-SVG-1.1/text-text-04-t-expected.txt:
platform/chromium-win/svg/batik/text/xmlSpace-expected.txt:
platform/chromium-win/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt:
platform/chromium-win/svg/custom/svg-fonts-in-html-expected.checksum:
platform/chromium-win/svg/custom/svg-fonts-in-html-expected.png:
platform/chromium-win/svg/custom/svg-fonts-in-html-expected.txt:
platform/chromium-win/svg/custom/svg-fonts-with-no-element-reference-expected.checksum:
platform/chromium-win/svg/custom/svg-fonts-with-no-element-reference-expected.png:
platform/chromium-win/svg/custom/svg-fonts-with-no-element-reference-expected.txt: Removed.
platform/chromium-win/svg/text/text-hkern-expected.txt: Removed.
platform/chromium-win/svg/text/text-hkern-on-vertical-text-expected.checksum:
platform/chromium-win/svg/text/text-hkern-on-vertical-text-expected.png:
platform/chromium-win/svg/text/text-hkern-on-vertical-text-expected.txt: Removed.
platform/chromium-win/svg/text/text-text-04-t-expected.checksum:
platform/chromium-win/svg/text/text-text-04-t-expected.png:
platform/chromium-win/svg/text/text-text-04-t-expected.txt:
platform/chromium-win/svg/text/text-vkern-expected.checksum:
platform/chromium-win/svg/text/text-vkern-expected.png:
platform/chromium-win/svg/text/text-vkern-expected.txt: Removed.
platform/chromium-win/svg/text/text-vkern-on-horizontal-text-expected.txt: Removed.
platform/chromium/test_expectations.txt:

2011-01-24 Tony Chang <tony@chromium.org>

Unreviewed, round ascent and descent to match old code.

platform/graphics/chromium/SimpleFontDataLinux.cpp: (WebCore::SimpleFontData::platformInit):

21:15 Changeset [76568] by simon.fraser@apple.com

2011-01-24 Simon Fraser <simon.fraser@apple.com>

Reviewed by Chris Marrin.

perspective() transform function should take lengths
https://bugs.webkit.org/show_bug.cgi?id=52683

The argument to the perspective() transform function should
be a Length, rather than a bare number. Bare numbers are still
accepted (and treated as px), but this behavior is deprecated.

Test: animations/3d/transform-perspective.html

transforms/3d/general/3dtransform-values.html

css/CSSParser.cpp: (WebCore::CSSParser::parseTransform): Check the units for the perspective() function. Allow bare numbers for backwards compatibility.
css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::createTransformOperations): Convert value to Length.
platform/graphics/transforms/PerspectiveTransformOperation.cpp: (WebCore::clampToPostiveInteger): Helper. (WebCore::PerspectiveTransformOperation::blend): Blend via Lengths.
platform/graphics/transforms/PerspectiveTransformOperation.h: (WebCore::PerspectiveTransformOperation::create): double -> Length. (WebCore::PerspectiveTransformOperation::perspective): Ditto. (WebCore::PerspectiveTransformOperation::isIdentity): Ditto. (WebCore::PerspectiveTransformOperation::apply): Ditto. (WebCore::PerspectiveTransformOperation::PerspectiveTransformOperation): Assert that the Length is a fixed type.

20:38 Changeset [76567] by tkent@chromium.org

2011-01-24 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[Windows] Textfield <input>s have different widths.
https://bugs.webkit.org/show_bug.cgi?id=48405

fast/forms/input-widths-expected.txt: Added.
fast/forms/input-widths.html: Added.

2011-01-24 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[Windows] Textfield <input>s have different widths.
https://bugs.webkit.org/show_bug.cgi?id=48405

Apply the padding override for type=text to other textfield types too.
Reset margin value of outer spin button, which is not used in Windows.
Don't add inner spin button width to the preferred text field width. Text fields should have the identical widths regardless of the existence of spin buttons.

Test: fast/forms/input-widths.html

css/themeWin.css: (input[type="week"]): (input[type="week"]:disabled): (input[type="search"]::-webkit-search-cancel-button): (input::-webkit-outer-spin-button):
rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::preferredContentWidth): Don't add inner spin button width to the preferred width.

20:36 Changeset [76566] by tkent@chromium.org

2011-01-24 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

Some bugs of search cancel button and spin button about state change in
an event handler.
https://bugs.webkit.org/show_bug.cgi?id=46950

fast/forms/input-number-change-type-on-focus-expected.txt: Added.
fast/forms/input-number-change-type-on-focus.html: Added.
fast/forms/search-hide-cancel-on-cancel-expected.txt: Added.
fast/forms/search-hide-cancel-on-cancel.html: Added.

2011-01-24 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

Some bugs of search cancel button and spin button about state change in
an event handler.
https://bugs.webkit.org/show_bug.cgi?id=46950

Fix the following problems:

Type=search field didn't release event capturing
Assertion failure when an input field with spin buttons was changed to another type on focus event.
A input field with spin button didn't release event capturing when it was changed to another type on focus event.

Tests: fast/forms/input-number-change-type-on-focus.html

fast/forms/search-hide-cancel-on-cancel.html

rendering/TextControlInnerElements.cpp: (WebCore::SearchFieldCancelButtonElement::defaultEventHandler):
- Make the variable 'input' RefPtr. It makes the code simpler.
- Remove visibility check on mouseup event. We should release capturing anyway because the cancel button may be invisible if JavaScript code called by the focus event removes the input value.

(WebCore::SpinButtonElement::detach):

Release capturing on detach because it is possible that a spin button node is detached while it is capturing events.

(WebCore::SpinButtonElement::defaultEventHandler):

Take a reference to this and check renderer() after some functions which
may run JavaScript code.

(WebCore::InputFieldSpeechButtonElement::defaultEventHandler):

Make the variable 'input' RefPtr to align other functions in this file.

(WebCore::InputFieldSpeechButtonElement::setRecognitionResult): ditto.

rendering/TextControlInnerElements.h: Declare SpinButtonElement::detach().

19:27 Changeset [76565] by rniwa@webkit.org

2011-01-24 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Ojan Vafai.

Inserting multiple whitespace using text composition (IME) should insert interleaved nbsp and whitespace.
https://bugs.webkit.org/show_bug.cgi?id=52781

The test was rebaselined to have interleaved space and non-breaking space.

editing/inserting/insert-composition-whitespace-expected.txt:
editing/inserting/insert-composition-whitespace.html:

2011-01-24 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Ojan Vafai.

Inserting multiple whitespace using text composition (IME) should insert interleaved nbsp and whitespace.
https://bugs.webkit.org/show_bug.cgi?id=52781

The bug was caused by stringWithRebalancedWhitespace's replacing the space at the beginning of a paragraph
and the end of a paragraph by a non-breaking space after it replaced two consecutive spaces by a space and
non-breaking space pattern, thereby replacing more spaces by non-breaking spaces than needed.

Rewrote the function using Vector<UChar> to fix the bug. New function no longer calls String::replace
multiple times but instead it traverses through the string and replaces a space that immediately follows
another space or appears at the beginning of a paragraph or at the end of a paragraph by a non-break space.

editing/CompositeEditCommand.cpp:
editing/htmlediting.cpp: (WebCore::stringWithRebalancedWhitespace): Written.
editing/htmlediting.h: (WebCore::isWhitespace): Removed from CompositeEditCommand.cpp

18:56 Changeset [76564] by mrobinson@webkit.org

2011-01-24 Martin Robinson <mrobinson@igalia.com>

Skip one more crashing test.

platform/gtk/Skipped: Skip a test.

18:48 Changeset [76563] by andersca@apple.com

Fix build.

WebProcess/mac/WebProcessMac.mm:

(WebKit::initializeSandbox):

18:39 Changeset [76562] by kbr@google.com

2011-01-24 Kenneth Russell <kbr@google.com>

Reviewed by James Robinson.

Web Audio API: port FFTFrame to FFTW
https://bugs.webkit.org/show_bug.cgi?id=52989

Ported FFTFrame class to the open-source FFTW library. Tested with
unit tests from Chris Rogers. Made preliminary changes to GYP
files for conditional compilation of these files; will need to be
adjusted once FFTW is integrated as third-party source.

WebCore.gyp/WebCore.gyp:
WebCore.gypi:
platform/audio/FFTFrame.h:
platform/audio/fftw: Added.
platform/audio/fftw/FFTFrameFFTW.cpp: Added. (WebCore::FFTFrame::FFTFrame): (WebCore::FFTFrame::~FFTFrame): (WebCore::FFTFrame::multiply): (WebCore::FFTFrame::doFFT): (WebCore::FFTFrame::doInverseFFT): (WebCore::FFTFrame::cleanup): (WebCore::FFTFrame::realData): (WebCore::FFTFrame::imagData): (WebCore::FFTFrame::fftwPlanForSize):

18:38 Changeset [76561] by andersca@apple.com

2011-01-24 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Reset the page scale factor on standard frame loads
https://bugs.webkit.org/show_bug.cgi?id=53058
<rdar://problem/8908844>

Add a symbol needed by WebKit2.

WebCore.exp.in:

2011-01-24 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Reset the page scale factor on standard frame loads
https://bugs.webkit.org/show_bug.cgi?id=53058
<rdar://problem/8908844>

UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::scaleWebView): Don't set m_viewScaleFactor here. It will be set in viewScaleFactorDidChange.

(WebKit::WebPageProxy::viewScaleFactorDidChange):
Update m_viewScaleFactor.

UIProcess/WebPageProxy.h: Add viewScaleFactorDidChange.

UIProcess/WebPageProxy.messages.in: Add ViewScaleFactorDidChange message.

WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::dispatchDidCommitLoad): Set the scale factor.

(WebKit::WebFrameLoaderClient::restoreViewState):
Inform the UI process about the new view scale factor.

WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::scaleWebView): Send a ViewScaleFactorDidChange message.

18:21 Changeset [76560] by rniwa@webkit.org

2011-01-24 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Eric Seidel.

Stop instantiating legacy editing positions in InsertTextCommand, MoveSelectionCommand,
ReplaceSelectionCommand, SelectionController, SpellChecker, TypingCommand, and markup.cpp
https://bugs.webkit.org/show_bug.cgi?id=52676

Stop instantiating legacy editing positions in the following files.

editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::prepareForTextInsertion): (WebCore::InsertTextCommand::performTrivialReplace): (WebCore::InsertTextCommand::input): (WebCore::InsertTextCommand::insertTab):
editing/MoveSelectionCommand.cpp: (WebCore::MoveSelectionCommand::doApply):
editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::removeUnrenderedTextNodesAtEnds): (WebCore::ReplaceSelectionCommand::mergeEndIfNeeded): (WebCore::ReplaceSelectionCommand::doApply): (WebCore::ReplaceSelectionCommand::shouldRemoveEndBR): (WebCore::ReplaceSelectionCommand::performTrivialReplace):
editing/SelectionController.cpp: (WebCore::SelectionController::setSelectionFromNone):
editing/SpellChecker.cpp: (WebCore::SpellChecker::didCheck):
editing/TypingCommand.cpp: (WebCore::TypingCommand::makeEditableRootEmpty): (WebCore::TypingCommand::deleteKeyPressed): (WebCore::TypingCommand::forwardDeleteKeyPressed):
editing/markup.cpp: (WebCore::StyledMarkupAccumulator::appendText): (WebCore::StyledMarkupAccumulator::serializeNodes): (WebCore::highestAncestorToWrapMarkup): (WebCore::createMarkup):

18:08 Changeset [76559] by mjs@apple.com

2011-01-24 Maciej Stachowiak <mjs@apple.com>

Reviewed by Anders Carlsson.

Use designated temp directory for the database for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=53052

Adopt the new WK2 API for this.

WebKitTestRunner/TestController.cpp: (WTR::TestController::libraryPathForTesting): (WTR::TestController::initialize):
WebKitTestRunner/TestController.h:
WebKitTestRunner/mac/TestControllerMac.mm: (WTR::TestController::platformLibraryPathForTesting):
WebKitTestRunner/qt/TestControllerQt.cpp: (WTR::TestController::platformLibraryPathForTesting):
WebKitTestRunner/win/TestControllerWin.cpp: (WTR::TestController::platformLibraryPathForTesting):

2011-01-24 Maciej Stachowiak <mjs@apple.com>

Reviewed by Anders Carlsson.

Use designated temp directory for the database for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=53052

Add the API necessary to support this. Database path is now
determined on the UI process side and passed to the Web process.
Reviewed by Anders Carlsson.

GNUmakefile.am:
Shared/WebProcessCreationParameters.cpp: (WebKit::WebProcessCreationParameters::encode): (WebKit::WebProcessCreationParameters::decode):
Shared/WebProcessCreationParameters.h:
UIProcess/API/C/WKContext.cpp: (WKContextSetDatabaseDirectory):
UIProcess/API/C/WKContextPrivate.h:
UIProcess/WebContext.cpp: (WebKit::WebContext::ensureWebProcess): (WebKit::WebContext::databaseDirectory):
UIProcess/WebContext.h: (WebKit::WebContext::setDatabaseDirectory):
UIProcess/mac/WebContextMac.mm: (WebKit::WebContext::platformDefaultDatabaseDirectory):
UIProcess/qt/WebContextQt.cpp: (WebKit::WebContext::platformDefaultDatabaseDirectory):
UIProcess/win/WebContextWin.cpp: (WebKit::WebContext::platformDefaultDatabaseDirectory):
WebKit2.pro:
WebKit2.xcodeproj/project.pbxproj:
WebProcess/WebCoreSupport/WebDatabaseManager.cpp: (WebKit::WebDatabaseManager::initialize): (WebKit::WebDatabaseManager::WebDatabaseManager):
WebProcess/WebCoreSupport/WebDatabaseManager.h:
WebProcess/WebCoreSupport/gtk/WebDatabaseManagerGtk.cpp: Removed.
WebProcess/WebCoreSupport/mac/WebDatabaseManagerMac.mm: Removed.
WebProcess/WebCoreSupport/qt/WebDatabaseManagerQt.cpp: Removed.
WebProcess/WebCoreSupport/win/WebDatabaseManagerWin.cpp: Removed.
WebProcess/WebProcess.cpp: (WebKit::WebProcess::WebProcess): (WebKit::WebProcess::initializeWebProcess):
WebProcess/com.apple.WebProcess.sb:
WebProcess/mac/WebProcessMac.mm: (WebKit::initializeSandbox):
win/WebKit2.vcproj:

18:05 Changeset [76558] by mrobinson@webkit.org

2011-01-24 Martin Robinson <mrobinson@igalia.com>

Skipping failing tests after r76555.

platform/gtk/Skipped: Skip failing tests.

17:36 Changeset [76557] by commit-queue@webkit.org

2011-01-24 Peter Kasting <pkasting@google.com>

Reviewed by Darin Adler.

Roll back r67261 ("Don't fire onclick on middle clicks") due to
regressions.
https://bugs.webkit.org/show_bug.cgi?id=46733

fast/events/mouse-click-events-expected.txt:
fast/events/script-tests/mouse-click-events.js:

2011-01-24 Peter Kasting <pkasting@google.com>

Reviewed by Darin Adler.

Roll back r67261 ("Don't fire onclick on middle clicks") due to
regressions.
https://bugs.webkit.org/show_bug.cgi?id=46733

html/HTMLAnchorElement.cpp: (WebCore::isLinkClick):
html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::preDispatchEventHandler): (WebCore::HTMLInputElement::postDispatchEventHandler): (WebCore::HTMLInputElement::defaultEventHandler):
page/EventHandler.cpp: (WebCore::EventHandler::handleMouseDoubleClickEvent): (WebCore::EventHandler::handleMouseReleaseEvent):

16:58 Changeset [76556] by xji@chromium.org

2011-01-24 Xiaomei Ji <xji@chromium.org>

Unreviewed.

Skip cjk-segmentation.html (introduced in r76548) in QT.
QT skipped range-expand.html, skip cjk-segmentation as well.

platform/qt/Skipped:

16:47 Changeset [76555] by mrobinson@webkit.org

2011-01-24 Martin Robinson <mrobinson@igalia.com>

Reviewed by Eric Seidel.

[GTK] Many DOM XHTML tests time out
https://bugs.webkit.org/show_bug.cgi?id=52553

platform/gtk/Skipped: Unskip tests which are no longer timing out.

2011-01-24 Martin Robinson <mrobinson@igalia.com>

Reviewed by Eric Seidel.

[GTK] Many DOM XHTML tests time out
https://bugs.webkit.org/show_bug.cgi?id=52553

Properly handle the situation where a synchronous load fails before the inner
event loop has started. In this case, we simply do not run the inner event loop,
or else it will block indefinitely (since no GIO or libsoup callbacks will fire).

platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandle::loadResourceSynchronously): Bail out of a synchronous load if it fails up front.

16:46 Changeset [76554] by lforschler@apple.com

Add a new Leopard test bot.

Reviewed by Stephanie Lewis.

BuildSlaveSupport/build.webkit.org-config/config.json:

16:35 Changeset [76553] by gyuyoung.kim@samsung.com

2011-01-24 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Adam Barth.

Add EFL Builder to core waterfall
https://bugs.webkit.org/show_bug.cgi?id=52704

Add EFL Builder to the core waterfall again.

Scripts/webkitpy/common/net/buildbot/buildbot.py:
Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:

16:09 Changeset [76552] by rniwa@webkit.org

2011-01-24 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed Chromium test expectation update for r76548.

platform/chromium/test_expectations.txt:

15:40 Changeset [76551] by bfulgham@webkit.org

Unreviewed build fix.

win/WebKit2.vcproj: Don't build the CG Utilities when building

without CG support.

15:16 Changeset [76550] by andersca@apple.com

2011-01-24 Anders Carlsson <andersca@apple.com>

Reviewed by John Sullivan.

Don't use the timeout checker for non-user-interaction messages
https://bugs.webkit.org/show_bug.cgi?id=53046

UIProcess/ChunkedUpdateDrawingAreaProxy.cpp: (WebKit::ChunkedUpdateDrawingAreaProxy::didSetSize): (WebKit::ChunkedUpdateDrawingAreaProxy::sendSetSize):
UIProcess/LayerBackedDrawingAreaProxy.cpp: (WebKit::LayerBackedDrawingAreaProxy::sizeDidChange): (WebKit::LayerBackedDrawingAreaProxy::didSetSize):

14:42 Changeset [76549] by zmo@google.com

2011-01-24 Zhenyao Mo <zmo@google.com>

Reviewed by Darin Adler.

Remove sizeInBytes from GraphicsContext3D's various implementations
https://bugs.webkit.org/show_bug.cgi?id=52339

src/GraphicsContext3DChromium.cpp:
src/GraphicsContext3DInternal.h:

2011-01-24 Zhenyao Mo <zmo@google.com>

Reviewed by Darin Adler.

Remove sizeInBytes from GraphicsContext3D's various implementations
https://bugs.webkit.org/show_bug.cgi?id=52339

html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::sizeInBytes):
platform/graphics/GraphicsContext3D.h:
platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
platform/graphics/qt/GraphicsContext3DQt.cpp:

14:25 Changeset [76548] by xji@chromium.org

2011-01-24 Xiaomei Ji <xji@chromium.org>

Reviewed by Ryosuke Niwa.

Add test for Chinese Segmentation.
https://bugs.webkit.org/show_bug.cgi?id=52926

The CJK segmentation currently does not work in other ports except Chromium.
Please refer to https://bugs.webkit.org/show_bug.cgi?id=53044 for detail.

fast/text/international/cjk-segmentation-expected.txt: Added.
fast/text/international/cjk-segmentation.html: Added.
platform/chromium/fast/text/international: Added.
platform/chromium/fast/text/international/cjk-segmentation-expected.txt: Added.

14:22 Changeset [76547] by commit-queue@webkit.org

2011-01-24 Xianzhu Wang <wangxianzhu@google.com>

Reviewed by Tony Chang.

new-run-webkit-tests fails to start HTTP server if there are proxy settings
https://bugs.webkit.org/show_bug.cgi?id=52872

Force disabling proxy to resolve the problem.

Scripts/webkitpy/layout_tests/port/http_server_base.py:
Scripts/webkitpy/layout_tests/port/websocket_server.py:

14:17 Changeset [76546] by aroben@apple.com

Windows Production build fix

Source/JavaScriptCore:

JavaScriptCore.vcproj/JavaScriptCore.make: Update for move of JavaScriptCore into Source.

Source/WebCore:

WebCore.vcproj/WebCore.make: Update for move of WebCore into Source.

Source/WebKit/win:

WebKit.vcproj/WebKit.make: Update for move of WebKit into Source.

Source/WebKit2:

win/WebKit2.make: Update for move of WebKit2 into Source.

14:01 Changeset [76545] by wsiegrist@apple.com

2011-01-24 William Siegrist <wsiegrist@apple.com>

Apply fix for https://bugzilla.mozilla.org/show_bug.cgi?id=621591

13:33 Changeset [76544] by mjs@apple.com

2011-01-24 Maciej Stachowiak <mjs@apple.com>

Reviewed by Eric Seidel.

Skip a newly added test that uses textInputController
https://bugs.webkit.org/show_bug.cgi?id=53027

platform/mac-wk2/Skipped:

13:02 Changeset [76543] by jberlin@webkit.org

WebKit2: LayoutTests: The UNIMPLEMENTED warnings in TextCheckerWin should be disabled
https://bugs.webkit.org/show_bug.cgi?id=53029

Reviewed by Adam Roben.

UIProcess/win/TextCheckerWin.cpp:

Disable the warnings for this file.

12:31 Changeset [76542] by andreip@google.com

2011-01-24 Andrei Popescu <andreip@google.com>

Unreviewed, build fix.

LayoutTest/storage/indexeddb/objectstore-autoincrement.html is failing after r76533
https://bugs.webkit.org/show_bug.cgi?id=53032

Fix the expected output, which still had an error.

storage/indexeddb/objectstore-autoincrement-expected.txt:

12:22 Changeset [76541] by antonm@chromium.org

2011-01-24 Anton Muhin <antonm@chromium.org>

Reviewed by Nate Chapin.

[v8] Refactoring: extract IntrusiveDOMWrapperMap into a seprate class and files.
https://bugs.webkit.org/show_bug.cgi?id=52911

Plain refactoring, covered by the existing tests.

WebCore.gypi: IntrusiveDOMWrapperMap.h added.
bindings/v8/DOMDataStore.cpp: IntrusiveDOMWrapperMap is moved out of DOMDataStore class.
bindings/v8/DOMDataStore.h: IntrusiveDOMWrapperMap is moved out of DOMDataStore class.
bindings/v8/IntrusiveDOMWrapperMap.h: Added. (WebCore::ChunkedTable::ChunkedTable): (WebCore::ChunkedTable::add): (WebCore::ChunkedTable::remove): (WebCore::ChunkedTable::clear): (WebCore::ChunkedTable::visit): (WebCore::ChunkedTable::Chunk::Chunk): (WebCore::ChunkedTable::clearEntries): (WebCore::ChunkedTable::visitEntries): (WebCore::IntrusiveDOMWrapperMap::IntrusiveDOMWrapperMap): (WebCore::IntrusiveDOMWrapperMap::get): (WebCore::IntrusiveDOMWrapperMap::set): (WebCore::IntrusiveDOMWrapperMap::contains): (WebCore::IntrusiveDOMWrapperMap::visit): (WebCore::IntrusiveDOMWrapperMap::removeIfPresent): (WebCore::IntrusiveDOMWrapperMap::clear): (WebCore::IntrusiveDOMWrapperMap::ChunkedTableTraits::move): (WebCore::IntrusiveDOMWrapperMap::ChunkedTableTraits::clear): (WebCore::IntrusiveDOMWrapperMap::ChunkedTableTraits::visit):
bindings/v8/StaticDOMDataStore.h: include added.

12:11 Changeset [76540] by commit-queue@webkit.org

2011-01-24 Kenji Imasaki <imasaki@chromium.org>

Reviewed by Jian Li.

[chromium] Remove non-flaky tests from test expectation file
https://bugs.webkit.org/show_bug.cgi?id=53022

platform/chromium/test_expectations.txt:

12:07 Changeset [76539] by jam@chromium.org

Merge 76455 - 2011-01-22 John Abd-El-Malek <jam@chromium.org>

Reviewed by Adam Barth.

[chromium]: Fix WebScrollbarImpl not getting scroll events after recent scrollbar refactoring
https://bugs.webkit.org/show_bug.cgi?id=52967

src/WebScrollbarImpl.cpp: (WebKit::WebScrollbarImpl::horizontalScrollbar): (WebKit::WebScrollbarImpl::verticalScrollbar):
src/WebScrollbarImpl.h:

TBR=jam@chromium.org
Review URL: http://codereview.chromium.org/6392001

11:43 Changeset [76538] by andreip@google.com

2011-01-24 Andrei Popescu <andreip@google.com>

Reviewed by Jeremy Orlow.

LayoutTest/storage/indexeddb/objectstore-autoincrement.html is failing after r76533
https://bugs.webkit.org/show_bug.cgi?id=53032

This fixes the layout test by modifying the arguments to IDBDatabase::transaction.

storage/indexeddb/objectstore-autoincrement-expected.txt:
storage/indexeddb/objectstore-autoincrement.html:

11:42 Changeset [76537] by commit-queue@webkit.org

2011-01-24 Shane Stephens <shanestephens@google.com>

Reviewed by Chris Marrin.

TransformationMatrix multiply operations apply operands in wrong order.
https://bugs.webkit.org/show_bug.cgi?id=52780

Rename TranformationMatrix::multLeft into multiply (the method does a multRight,
not a multLeft).

Remove TransformationMatrix::multiply, which was actually doing a multLeft.

Fix TransformationMatrix::operator* and operator*= such that the operand is
applied to the right-hand side of the matrix that the method is called on.
i.e., previously "a * b" used to compute "b * a", and "a *= b" used to store
"b * a" in "a". This has now been fixed so "a * b" computes "a * b" and
"a *= b" stores "a * b" in "a".

Convert all call sites for these methods to provide operands in the correct order.

No new tests as patch adds no new functionality.

css/WebKitCSSMatrix.cpp: (WebCore::WebKitCSSMatrix::multiply):
platform/graphics/transforms/Matrix3DTransformOperation.h: (WebCore::Matrix3DTransformOperation::apply):
platform/graphics/transforms/MatrixTransformOperation.h: (WebCore::MatrixTransformOperation::apply):
platform/graphics/transforms/TransformationMatrix.cpp: (WebCore::TransformationMatrix::scaleNonUniform): (WebCore::TransformationMatrix::scale3d): (WebCore::TransformationMatrix::rotate3d): (WebCore::TransformationMatrix::skew): (WebCore::TransformationMatrix::applyPerspective): (WebCore::TransformationMatrix::multiply): (WebCore::TransformationMatrix::recompose):
platform/graphics/transforms/TransformationMatrix.h: (WebCore::TransformationMatrix::operator*=): (WebCore::TransformationMatrix::operator*):
rendering/RenderLayer.cpp: (WebCore::transparencyClipBox):
rendering/RenderObject.cpp: (WebCore::RenderObject::getTransformFromContainer):
rendering/TransformState.cpp: (WebCore::TransformState::applyTransform): (WebCore::HitTestingTransformState::applyTransform):

11:33 Changeset [76536] by andersca@apple.com

2011-01-24 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Wait for half a second if we're asked to paint when receiving a DidSetSize message
https://bugs.webkit.org/show_bug.cgi?id=53028

UIProcess/DrawingAreaProxyImpl.cpp: (WebKit::DrawingAreaProxyImpl::paint):

11:18 Changeset [76535] by andersca@apple.com

2011-01-24 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Implement forceRedisplay in the new drawing area
https://bugs.webkit.org/show_bug.cgi?id=53026

WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::forceRepaint):
WebProcess/WebPage/DrawingAreaImpl.h:

11:16 Changeset [76534] by dglazkov@chromium.org

Added codereview.settings file.

11:11 Changeset [76533] by andersca@apple.com

2011-01-24 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Fill unpainted rects with the background color.
https://bugs.webkit.org/show_bug.cgi?id=53025

UIProcess/API/mac/WKView.mm: (drawPageBackground): Add new helper function.

(-[WKView drawRect:]):
Iterate over the unpainted rects and fill them with the background color.

11:10 Changeset [76532] by dglazkov@chromium.org

Branching Chromium 648.

11:01 Changeset [76531] by andreip@google.com

2011-01-24 Andrei Popescu <andreip@google.com>

Reviewed by Nate Chapin.

IndexedDatabase methods should not take arguments of type OptionsObject
https://bugs.webkit.org/show_bug.cgi?id=53012

storage/indexeddb/create-object-store-options-expected.txt:
storage/indexeddb/create-object-store-options.html:
storage/indexeddb/cursor-delete-expected.txt:
storage/indexeddb/cursor-delete.html:
storage/indexeddb/cursor-index-delete-expected.txt:
storage/indexeddb/cursor-index-delete.html:
storage/indexeddb/data-corruption-expected.txt:
storage/indexeddb/data-corruption.html:
storage/indexeddb/database-quota-expected.txt:
storage/indexeddb/database-quota.html:
storage/indexeddb/index-cursor.html:
storage/indexeddb/objectstore-basics-expected.txt:
storage/indexeddb/objectstore-basics.html:
storage/indexeddb/objectstore-cursor.html:
storage/indexeddb/open-cursor-expected.txt:
storage/indexeddb/open-cursor.html:
storage/indexeddb/transaction-and-objectstore-calls-expected.txt:
storage/indexeddb/transaction-and-objectstore-calls.html:
storage/indexeddb/tutorial.html:

2011-01-24 Andrei Popescu <andreip@google.com>

Reviewed by Nate Chapin.

IndexedDatabase methods should not take arguments of type OptionsObject
https://bugs.webkit.org/show_bug.cgi?id=53012

This patch reverts all IDB methods, except IDBDatabase::createObjectStore and
IDBObjectStore::createIndex, to using a plain list of arguments instead of
grouping the various parameters inside a single OptionsObject argument.
This decision was made on public-webapps@w3.org mailing list.

We also add support (v8 only for now) for passing DOMStringList objects as arguments to native
methods. The code for obtaining a DOMStringList object from a JS array of strings existed already
in OptionsObject.cpp, I just copied it to V8Bindings.cpp and taught the v8 code generator how to
use it.

bindings/scripts/CodeGeneratorV8.pm:
bindings/v8/V8Binding.cpp: (WebCore::v8ValueToWebCoreDOMStringList):
bindings/v8/V8Binding.h:
storage/IDBDatabase.cpp: (WebCore::IDBDatabase::transaction):
storage/IDBDatabase.h: (WebCore::IDBDatabase::transaction):
storage/IDBDatabase.idl:
storage/IDBIndex.cpp: (WebCore::IDBIndex::openCursor): (WebCore::IDBIndex::openKeyCursor):
storage/IDBIndex.h: (WebCore::IDBIndex::openCursor): (WebCore::IDBIndex::openKeyCursor):
storage/IDBIndex.idl:
storage/IDBObjectStore.cpp: (WebCore::IDBObjectStore::openCursor):
storage/IDBObjectStore.h: (WebCore::IDBObjectStore::openCursor):
storage/IDBObjectStore.idl:

10:33 Changeset [76530] by commit-queue@webkit.org

2011-01-24 Andreas Kling <kling@webkit.org>

Reviewed by Darin Adler.

check-webkit-style: Update exemptions following Source/ move.
https://bugs.webkit.org/show_bug.cgi?id=53017

Scripts/webkitpy/style/checker.py:
Scripts/webkitpy/style/checker_unittest.py:

09:54 Changeset [76529] by mitz@apple.com

WebKit2 version of <rdar://problem/6097826> Mail's cursor does not become a resize cursor when moving mouse from scrolled email to the horizontal splitter

Reviewed by John Sullivan.

UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::setCursor): If the current cursor comes from a cursor rect, do not override it.

09:40 Changeset [76528] by chang.shu@nokia.com

2011-01-24 Chang Shu <chang.shu@nokia.com>

Reviewed by Darin Adler.

Move contentEditable related test cases to the right place as they are DOM
related instead of editing related.
https://bugs.webkit.org/show_bug.cgi?id=53010

editing/editability: Removed.
editing/editability/attr-empty-string-expected.txt: Removed.
editing/editability/attr-empty-string.html: Removed.
editing/editability/attr-false-string-expected.txt: Removed.
editing/editability/attr-false-string.html: Removed.
editing/editability/attr-invalid-string-expected.txt: Removed.
editing/editability/attr-invalid-string.html: Removed.
editing/editability/attr-missing-ancestor-false-expected.txt: Removed.
editing/editability/attr-missing-ancestor-false.html: Removed.
editing/editability/attr-missing-ancestor-true-expected.txt: Removed.
editing/editability/attr-missing-ancestor-true.html: Removed.
editing/editability/attr-missing-parent-ancestor-missing-expected.txt: Removed.
editing/editability/attr-missing-parent-ancestor-missing.html: Removed.
editing/editability/attr-missing-parent-false-expected.txt: Removed.
editing/editability/attr-missing-parent-false.html: Removed.
editing/editability/attr-missing-parent-true-expected.txt: Removed.
editing/editability/attr-missing-parent-true.html: Removed.
editing/editability/attr-true-string-expected.txt: Removed.
editing/editability/attr-true-string.html: Removed.
editing/editability/set-false-expected.txt: Removed.
editing/editability/set-false.html: Removed.
editing/editability/set-inherit-parent-false-expected.txt: Removed.
editing/editability/set-inherit-parent-false.html: Removed.
editing/editability/set-inherit-parent-true-expected.txt: Removed.
editing/editability/set-inherit-parent-true.html: Removed.
editing/editability/set-invalid-value-expected.txt: Removed.
editing/editability/set-invalid-value.html: Removed.
editing/editability/set-true-expected.txt: Removed.
editing/editability/set-true.html: Removed.
editing/editability/set-value-caseinsensitive-expected.txt: Removed.
editing/editability/set-value-caseinsensitive.html: Removed.
fast/dom/HTMLElement/attr-empty-string-expected.txt: Copied from LayoutTests/editing/editability/attr-empty-string-expected.txt.
fast/dom/HTMLElement/attr-empty-string.html: Copied from LayoutTests/editing/editability/attr-empty-string.html.
fast/dom/HTMLElement/attr-false-string-expected.txt: Copied from LayoutTests/editing/editability/attr-false-string-expected.txt.
fast/dom/HTMLElement/attr-false-string.html: Copied from LayoutTests/editing/editability/attr-false-string.html.
fast/dom/HTMLElement/attr-invalid-string-expected.txt: Copied from LayoutTests/editing/editability/attr-invalid-string-expected.txt.
fast/dom/HTMLElement/attr-invalid-string.html: Copied from LayoutTests/editing/editability/attr-invalid-string.html.
fast/dom/HTMLElement/attr-missing-ancestor-false-expected.txt: Copied from LayoutTests/editing/editability/attr-missing-ancestor-false-expected.txt.
fast/dom/HTMLElement/attr-missing-ancestor-false.html: Copied from LayoutTests/editing/editability/attr-missing-ancestor-false.html.
fast/dom/HTMLElement/attr-missing-ancestor-true-expected.txt: Copied from LayoutTests/editing/editability/attr-missing-ancestor-true-expected.txt.
fast/dom/HTMLElement/attr-missing-ancestor-true.html: Copied from LayoutTests/editing/editability/attr-missing-ancestor-true.html.
fast/dom/HTMLElement/attr-missing-parent-ancestor-missing-expected.txt: Copied from LayoutTests/editing/editability/attr-missing-parent-ancestor-missing-expected.txt.
fast/dom/HTMLElement/attr-missing-parent-ancestor-missing.html: Copied from LayoutTests/editing/editability/attr-missing-parent-ancestor-missing.html.
fast/dom/HTMLElement/attr-missing-parent-false-expected.txt: Copied from LayoutTests/editing/editability/attr-missing-parent-false-expected.txt.
fast/dom/HTMLElement/attr-missing-parent-false.html: Copied from LayoutTests/editing/editability/attr-missing-parent-false.html.
fast/dom/HTMLElement/attr-missing-parent-true-expected.txt: Copied from LayoutTests/editing/editability/attr-missing-parent-true-expected.txt.
fast/dom/HTMLElement/attr-missing-parent-true.html: Copied from LayoutTests/editing/editability/attr-missing-parent-true.html.
fast/dom/HTMLElement/attr-true-string-expected.txt: Copied from LayoutTests/editing/editability/attr-true-string-expected.txt.
fast/dom/HTMLElement/attr-true-string.html: Copied from LayoutTests/editing/editability/attr-true-string.html.
fast/dom/HTMLElement/set-false-expected.txt: Copied from LayoutTests/editing/editability/set-false-expected.txt.
fast/dom/HTMLElement/set-false.html: Copied from LayoutTests/editing/editability/set-false.html.
fast/dom/HTMLElement/set-inherit-parent-false-expected.txt: Copied from LayoutTests/editing/editability/set-inherit-parent-false-expected.txt.
fast/dom/HTMLElement/set-inherit-parent-false.html: Copied from LayoutTests/editing/editability/set-inherit-parent-false.html.
fast/dom/HTMLElement/set-inherit-parent-true-expected.txt: Copied from LayoutTests/editing/editability/set-inherit-parent-true-expected.txt.
fast/dom/HTMLElement/set-inherit-parent-true.html: Copied from LayoutTests/editing/editability/set-inherit-parent-true.html.
fast/dom/HTMLElement/set-invalid-value-expected.txt: Copied from LayoutTests/editing/editability/set-invalid-value-expected.txt.
fast/dom/HTMLElement/set-invalid-value.html: Copied from LayoutTests/editing/editability/set-invalid-value.html.
fast/dom/HTMLElement/set-true-expected.txt: Copied from LayoutTests/editing/editability/set-true-expected.txt.
fast/dom/HTMLElement/set-true.html: Copied from LayoutTests/editing/editability/set-true.html.
fast/dom/HTMLElement/set-value-caseinsensitive-expected.txt: Copied from LayoutTests/editing/editability/set-value-caseinsensitive-expected.txt.
fast/dom/HTMLElement/set-value-caseinsensitive.html: Copied from LayoutTests/editing/editability/set-value-caseinsensitive.html.

09:37 Changeset [76527] by tony@chromium.org

2011-01-24 Tony Chang <tony@chromium.org>

Reviewed by James Robinson.

[chromium] turn off gyp circular dependency checking and roll chromium deps
https://bugs.webkit.org/show_bug.cgi?id=52935

DEPS:
gyp_webkit: Turn off gyp circular dependency checking on Linux

and Win since we don't do these checks in gyp_chromium. It's
just making it harder for us to roll DEPS and have something
explode.

09:35 Changeset [76526] by satish@chromium.org

2011-01-24 Satish Sampath <satish@chromium.org>

Reviewed by Csaba Osztrogonác.

Remove obsolete public/API method in chromium port
https://bugs.webkit.org/show_bug.cgi?id=53015

public/WebSpeechInputController.h: (WebKit::WebSpeechInputController::startRecognition): Removed obsolete method

09:29 Changeset [76525] by abecsi@webkit.org

2011-01-24 Andras Becsi <abecsi@webkit.org>

Rubber-stamped by Csaba Osztrogonác.

[Qt] Move project files into Source
https://bugs.webkit.org/show_bug.cgi?id=52891

DumpRenderTree/qt/ImageDiff.pro: Add missing "Source" to WebKit.pri path

09:25 Changeset [76524] by weinig@apple.com

Add editing/inserting/insert-composition-whitespace.html to the windows
skipped list.

platform/win/Skipped:

08:56 Changeset [76523] by ossy@webkit.org

Unreviewed.

Add Qt specific expected results for passing editing/selections tests.
Compared to Mac png files and Mac expected files. (part 3)

platform/qt/editing/selection/ [...]:

08:50 Changeset [76522] by ossy@webkit.org

Unreviewed.

Add Qt specific expected results for passing editing/selections tests.
Compared to Mac png files and Mac expected files. (part 2)

platform/qt/editing/selection/ [...]:

08:37 Changeset [76521] by ossy@webkit.org

Unreviewed.

Add Qt specific expected results for passing editing/selections tests.
Compared to Mac png files and Mac expected files. (part 1)

platform/qt/editing/selection/ [...]:

08:20 Changeset [76520] by kbalazs@webkit.org

Typo fix.

Rubber-stamped by Csaba Osztrogonác.

UIProcess/Launcher/qt/ProcessLauncherQt.cpp:

(WebKit::ProcessLauncher::launchProcess): Move the bracket to the right place.

07:28 Changeset [76519] by pfeldman@chromium.org

2011-01-24 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: extract dispatch API from network manager.
https://bugs.webkit.org/show_bug.cgi?id=53009

WebCore.xcodeproj/project.pbxproj:
inspector/front-end/NetworkManager.js: (WebInspector.NetworkManager): (WebInspector.NetworkManager.prototype.reset): (WebInspector.NetworkManager.prototype.requestContent): (WebInspector.NetworkManager.prototype._processCachedResources): (WebInspector.NetworkDispatcher): (WebInspector.NetworkDispatcher.prototype._updateResourceWithRequest): (WebInspector.NetworkDispatcher.prototype._updateResourceWithResponse): (WebInspector.NetworkDispatcher.prototype._updateResourceWithCachedResource): (WebInspector.NetworkDispatcher.prototype.identifierForInitialRequest): (WebInspector.NetworkDispatcher.prototype.willSendRequest): (WebInspector.NetworkDispatcher.prototype.didReceiveResponse): (WebInspector.NetworkDispatcher.prototype.didLoadResourceFromMemoryCache): (WebInspector.NetworkDispatcher.prototype.didCommitLoadForFrame): (WebInspector.NetworkDispatcher.prototype.didCreateWebSocket): (WebInspector.NetworkDispatcher.prototype._appendRedirect): (WebInspector.NetworkDispatcher.prototype._startResource): (WebInspector.NetworkDispatcher.prototype._updateResource): (WebInspector.NetworkDispatcher.prototype._finishResource): (WebInspector.NetworkDispatcher.prototype._addFramesRecursively): (WebInspector.NetworkDispatcher.prototype._dispatchEventToListeners): (WebInspector.NetworkDispatcher.prototype._createResource):
inspector/front-end/Resource.js: (WebInspector.Resource.prototype._innerRequestContent):
inspector/front-end/ResourceTreeModel.js: (WebInspector.ResourceTreeModel): (WebInspector.ResourceTreeModel.prototype.reset): (WebInspector.ResourceTreeModel.prototype.unbindResourceURL):

07:20 Changeset [76518] by yurys@chromium.org

2011-01-24 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [JSC] remove ScriptDebugServer::pageCreated
https://bugs.webkit.org/show_bug.cgi?id=53007

It's impossible to create "provisional" inspector for pages which are
not yet created so there is no need to listen for page creation in ScriptDebugServer.

bindings/js/ScriptDebugServer.cpp:
bindings/js/ScriptDebugServer.h:
page/Page.cpp: (WebCore::Page::Page):

07:11 Changeset [76517] by podivilov@chromium.org

2011-01-24 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [REGRESSION] AppCache view on resources panel is broken.
https://bugs.webkit.org/show_bug.cgi?id=53002

inspector/front-end/ApplicationCacheItemsView.js: (WebInspector.ApplicationCacheItemsView.prototype._update):
inspector/front-end/DOMAgent.js: (WebInspector.ApplicationCacheDispatcher.getApplicationCachesAsync):

07:01 Changeset [76516] by reni@webkit.org

[Qt] QWebFramePrivate::renderRelativeCoords() calls QPainter::save/restore more than necessary
https://bugs.webkit.org/show_bug.cgi?id=49915

Reviewed by Andreas Kling.

In the first loop of renderRelativeCoords() the call of QPainter::save/restore is useless, because
the context is saved/stored within the loop.
In the second loop the calls are also avoidable by using inverse translation on context.

Api/qwebframe.cpp:

(QWebFramePrivate::renderRelativeCoords):

06:46 Changeset [76515] by andreas.kling@nokia.com

2011-01-24 Andreas Kling <kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Fix warnings about unregistering an invalid timer
https://bugs.webkit.org/show_bug.cgi?id=53006

The ShadowBuffer's purge timer ID was initialized with 0 which lead
to us calling QObject::killTimer(0), causing some qWarnings.

platform/graphics/qt/ContextShadowQt.cpp: (WebCore::ShadowBuffer::ShadowBuffer): (WebCore::ShadowBuffer::schedulePurge):

06:39 Changeset [76514] by mnaganov@chromium.org

2011-01-21 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Chromium] Fix heap snapshot table sorting.

Fix table sorting to avoid qsort instability artefacts.

https://bugs.webkit.org/show_bug.cgi?id=52914

inspector/front-end/HeapSnapshotView.js: (WebInspector.HeapSnapshotView.prototype._sortData): (WebInspector.HeapSnapshotDataGridList.propertyComparator.comparator): (WebInspector.HeapSnapshotDataGridList.propertyComparator):

06:24 Changeset [76513] by ossy@webkit.org

Unreviewed.

RTL: selection.modify("move", "forward", "line") when cursor is at start of a line does not move down a line
https://bugs.webkit.org/show_bug.cgi?id=51517

platform/qt-linux/editing: Removed.
platform/qt-linux/editing/selection: Removed.
platform/qt-linux/editing/selection/extend-to-line-boundary-expected.txt: Removed.
platform/qt/Skipped: Add editing/selection/extend-to-line-boundary.html until fix.

06:16 Changeset [76512] by podivilov@chromium.org

2011-01-24 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, build fix for r76509.

inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::setBreakpoint):

06:06 Changeset [76511] by mnaganov@chromium.org

2011-01-24 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Find duplicate strings in localizedStrings.js, update it.

https://bugs.webkit.org/show_bug.cgi?id=53005

English.lproj/localizedStrings.js:
Scripts/check-inspector-strings:

06:05 Changeset [76510] by podivilov@chromium.org

2011-01-24 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, build fix for r76509.

bindings/js/ScriptDebugServer.h:

05:55 Changeset [76509] by podivilov@chromium.org

2011-01-24 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: set breakpoints by line:column.
https://bugs.webkit.org/show_bug.cgi?id=52615

CMakeLists.txt:
GNUmakefile.am:
WebCore.gypi:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
bindings/js/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::setBreakpoint): (WebCore::ScriptDebugServer::removeBreakpoint): (WebCore::ScriptDebugServer::hasBreakpoint): (WebCore::ScriptDebugServer::clearBreakpoints):
bindings/js/ScriptDebugServer.h:
bindings/v8/DebuggerScript.js: ():
bindings/v8/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::setBreakpoint):
bindings/v8/ScriptDebugServer.h:
inspector/Inspector.idl:
inspector/InspectorBrowserDebuggerAgent.cpp: (WebCore::InspectorBrowserDebuggerAgent::restoreStickyBreakpoint):
inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::setStickyBreakpoint): (WebCore::InspectorDebuggerAgent::setBreakpoint): (WebCore::InspectorDebuggerAgent::restoreBreakpoint): (WebCore::InspectorDebuggerAgent::didParseSource):
inspector/InspectorDebuggerAgent.h:
inspector/ScriptBreakpoint.cpp: Removed.
inspector/ScriptBreakpoint.h: (WebCore::ScriptBreakpoint::ScriptBreakpoint):
inspector/front-end/Breakpoint.js: (WebInspector.Breakpoint): (WebInspector.Breakpoint.prototype.get url):
inspector/front-end/BreakpointManager.js: (WebInspector.JavaScriptBreakpoint.prototype._serializeToJSON):
inspector/front-end/DebuggerModel.js: (WebInspector.DebuggerModel.prototype.continueToLine): (WebInspector.DebuggerModel.prototype.setBreakpoint): (WebInspector.DebuggerModel.prototype._breakpointSetOnBackend): (WebInspector.DebuggerDispatcher.prototype.breakpointResolved):

05:05 Changeset [76508] by ossy@webkit.org

runtime: Removed. It was accidentally created by r76457.

Rubber-stamped by Csaba Osztrogonác.
Patch by Peter Gal <galpater@inf.u-szeged.hu> on 2011-01-24

04:58 Changeset [76507] by commit-queue@webkit.org

2011-01-24 Kimmo Kinnunen <kimmo.t.kinnunen@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Remove CleanupHandler by passing file descriptors.

Deleting files in signal handler of UI process is not a good idea,
because the memory where filenames are stored might not be valid
after a crash.

To avoid the need of using signal handlers for cleanup,
change following:

1) Avoid passing filenames between processes, pass fds
2) When mmap'ing files, delete them immediately after

opening and mmap'ing them.

3) Pass sockets with fds during fork+exec instead of

passing them via the filesystem.

4) Use mmap'ed files for implementation of SharedMemory.

QSharedMemory does not support cleanup correctly.

Consquences:

Move MappedMemory to SharedMemory, make UpdateChunk use this.
Implement CoreIPC::Attachment using mmaped files.
Send messages using datagram socket. This solution works similiarly to Mach ports on Mac.
Send big messages out-of-line and thus avoid increasing the receive buffer.
Remove MemoryMappedPool and rely on libc/kernel caching of mmapped areas.
Unmap memory areas after use.
When UI process crashes, kill the web process using SIGKILL. This is possible again because cleanup handler is not needed.

[WK2][Qt] Multiple problems with MemoryMappedPool
https://bugs.webkit.org/show_bug.cgi?id=51984

Platform/CoreIPC/Attachment.cpp: (CoreIPC::Attachment::Attachment):
Platform/CoreIPC/Attachment.h: (CoreIPC::Attachment::size): (CoreIPC::Attachment::releaseFileDescriptor): (CoreIPC::Attachment::fileDescriptor):
Platform/CoreIPC/Connection.h:
Platform/CoreIPC/qt/ConnectionQt.cpp: (CoreIPC::MessageInfo::MessageInfo): (CoreIPC::MessageInfo::setMessageBodyOOL): (CoreIPC::MessageInfo::isMessageBodyOOL): (CoreIPC::MessageInfo::bodySize): (CoreIPC::MessageInfo::messageID): (CoreIPC::MessageInfo::attachmentCount): (CoreIPC::Connection::platformInitialize): (CoreIPC::Connection::platformInvalidate): (CoreIPC::SocketNotifierDisableGuard::SocketNotifierDisableGuard): (CoreIPC::SocketNotifierDisableGuard::~SocketNotifierDisableGuard): (CoreIPC::Connection::readyReadHandler): (CoreIPC::Connection::open): (CoreIPC::Connection::platformCanSendOutgoingMessages): (CoreIPC::Connection::sendOutgoingMessage):
Platform/SharedMemory.h:
Platform/WorkQueue.h:
Platform/qt/MappedMemoryPool.cpp: Removed.
Platform/qt/MappedMemoryPool.h: Removed.
Platform/qt/SharedMemoryQt.cpp: (WebKit::SharedMemory::Handle::Handle): (WebKit::SharedMemory::Handle::~Handle): (WebKit::SharedMemory::Handle::isNull): (WebKit::SharedMemory::Handle::encode): (WebKit::SharedMemory::Handle::decode): (WebKit::SharedMemory::Handle::releaseToAttachment): (WebKit::SharedMemory::Handle::adoptFromAttachment): (WebKit::SharedMemory::create): (WebKit::accessModeMMap): (WebKit::SharedMemory::~SharedMemory): (WebKit::accessModeFile): (WebKit::SharedMemory::createHandle):
Platform/qt/WorkQueueQt.cpp: (WorkQueue::registerSocketEventHandler):
Shared/qt/UpdateChunk.cpp: (WebKit::UpdateChunk::UpdateChunk): (WebKit::UpdateChunk::~UpdateChunk): (WebKit::UpdateChunk::encode): (WebKit::UpdateChunk::decode): (WebKit::UpdateChunk::createImage):
Shared/qt/UpdateChunk.h:
UIProcess/Launcher/ProcessLauncher.h:
UIProcess/Launcher/qt/ProcessLauncherQt.cpp: (WebKit::QtWebProcess::QtWebProcess): (WebKit::QtWebProcess::setupChildProcess): (WebKit::ProcessLauncher::launchProcess): (WebKit::ProcessLauncher::platformInvalidate):
UIProcess/Launcher/qt/ThreadLauncherQt.cpp: (WebKit::webThreadBody): (WebKit::ThreadLauncher::createWebThread):
WebKit2.pro:
WebProcess/qt/WebProcessMainQt.cpp: (WebKit::WebProcessMainQt):

04:56 Changeset [76506] by yurys@chromium.org

2011-01-24 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Update Chromium test expectations.

platform/chromium-mac/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-document-write-expected.txt:
platform/chromium-mac/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-javascript-url-expected.txt:
platform/chromium-mac/http/tests/security/xss-DENIED-frame-name-expected.txt:
platform/chromium/test_expectations.txt:

04:46 Changeset [76505] by commit-queue@webkit.org

2011-01-24 Peter Beverloo <peter@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: recognize application/x-font-woff as a valid mime-type.
https://bugs.webkit.org/show_bug.cgi?id=52977

No new tests.

inspector/front-end/inspector.js:

03:55 Changeset [76504] by podivilov@chromium.org

2011-01-24 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, fix for r76497.

inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.show):

03:53 Changeset [76503] by zoltan@webkit.org

[Qt] Regroup MiniBrowser's menubar and add open file action
https://bugs.webkit.org/show_bug.cgi?id=53000

Reviewed by Andreas Kling.

Add File and Develop menu to MiniBrowser's menubar and add open file action to File menu.

MiniBrowser/qt/BrowserWindow.cpp:

(BrowserWindow::BrowserWindow):
(BrowserWindow::openFile):
(BrowserWindow::~BrowserWindow):

MiniBrowser/qt/BrowserWindow.h:

03:52 Changeset [76502] by pvarga@webkit.org

2011-01-24 Peter Varga <pvarga@inf.u-szeged.hu>

Reviewed by Oliver Hunt.

Optimize regex patterns which contain empty alternatives
https://bugs.webkit.org/show_bug.cgi?id=51395

Eliminate the empty alternatives from the regex pattern and convert it to do
the matching in an easier way.

fast/regex/script-tests/slow.js:
fast/regex/slow-expected.txt:

2011-01-24 Peter Varga <pvarga@webkit.org>

Reviewed by Oliver Hunt.

Optimize regex patterns which contain empty alternatives
https://bugs.webkit.org/show_bug.cgi?id=51395

Eliminate the empty alternatives from the regex pattern and convert it to do
the matching in an easier way.

yarr/YarrPattern.cpp: (JSC::Yarr::YarrPatternConstructor::atomParenthesesEnd):

03:51 Changeset [76501] by andreas.kling@nokia.com

2011-01-24 Andreas Kling <kling@webkit.org>

Reviewed by Tor Arne Vestbø.

[Qt] Use rad2deg() from WTF instead of rolling our own.
https://bugs.webkit.org/show_bug.cgi?id=52993

platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::rotate):
platform/graphics/qt/PathQt.cpp: (WebCore::Path::addArc):

03:35 Changeset [76500] by podivilov@chromium.org

2011-01-24 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, test fix for r76497.

http/tests/inspector/debugger-test2.js: (initialize_DebuggerTest.InspectorTest.setBreakpointInVisibleView): (initialize_DebuggerTest.InspectorTest._showScriptSource):

03:22 Changeset [76499] by ossy@webkit.org

Unreviewed fix after r76496

[Qt] Move project files into Source
https://bugs.webkit.org/show_bug.cgi?id=52891

BuildSlaveSupport/build.webkit.org-config/master.cfg: Remove unnecessary "Source" from the path.
BuildSlaveSupport/built-product-archive: Remove unnecessary "Source" from the path.
Scripts/webkitdirs.pm: Add the accidentally removed slash to the path.

02:57 Changeset [76498] by sergio@webkit.org

2011-01-24 Sergio Villar Senin <svillar@igalia.com>

Reviewed by Martin Robinson.

[Gtk] ResourceHandleSoup: do not wait for streams to close to issue didFinishLoading
https://bugs.webkit.org/show_bug.cgi?id=52885

No new tests as it does not change functionality. We will not wait for
the the input stream to close to issue didFinishLoading to
WebCore. We expect a subtle performance improvement with this
patch when loading complex web pages, as we wouldn't have to wait
for the stream to close (which involves creating a thread among
other things).

platform/network/soup/ResourceHandleSoup.cpp: (WebCore::closeCallback): (WebCore::readCallback):

02:38 Changeset [76497] by podivilov@chromium.org

2011-01-21 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: eliminate SourceView and ScriptView classes.
https://bugs.webkit.org/show_bug.cgi?id=52896

SourceView and ScriptView delegate everything to SourceFrame and should be eliminated.

WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
inspector/front-end/GoToLineDialog.js: (WebInspector.GoToLineDialog.prototype._highlightSelectedLine):
inspector/front-end/ResourceView.js: (WebInspector.ResourceView.createResourceView): (WebInspector.ResourceView.resourceViewTypeMatchesResource): (WebInspector.SourceFrameContentProviderForResource): Moved from SourceView.
inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.show): (WebInspector.ResourcesPanel.prototype._applyDiffMarkup): (WebInspector.FrameResourceTreeElement.prototype._errorsWarningsUpdated):
inspector/front-end/ScriptView.js: Removed.
inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._scriptSourceChanged): (WebInspector.ScriptsPanel.prototype._sourceFrameForScriptOrResource): (WebInspector.ScriptsPanel.prototype._showScriptOrResource): (WebInspector.ScriptsPanel.prototype._setPauseOnExceptions): (WebInspector.ScriptsPanel.prototype._formatScript): (WebInspector.SourceFrameContentProviderForScript): Moved from ScriptView.
inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame): (WebInspector.SourceFrame.prototype.show): (WebInspector.SourceFrame.prototype.hide): (WebInspector.SourceFrame.prototype.hasContent): (WebInspector.SourceFrame.prototype._createTextViewer): (WebInspector.SourceFrame.prototype.performSearch.doFindSearchMatches): (WebInspector.SourceFrame.prototype.performSearch):
inspector/front-end/SourceView.js: Removed.
inspector/front-end/WebKit.qrc:
inspector/front-end/inspector.html:

02:36 Changeset [76496] by abecsi@webkit.org

2011-01-24 Andras Becsi <abecsi@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt] Move project files into Source
https://bugs.webkit.org/show_bug.cgi?id=52891

Source/DerivedSources.pro: Copied from DerivedSources.pro.
Source/WebKit.pri: Renamed from WebKit.pri.
Source/WebKit.pro: Added.
Source/common.pri: Renamed from common.pri.
WebKit.pro: Removed.

2011-01-24 Andras Becsi <abecsi@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt] Move project files into Source
https://bugs.webkit.org/show_bug.cgi?id=52891

JavaScriptCore.pri:
JavaScriptCore.pro:
jsc.pro:

2011-01-24 Andras Becsi <abecsi@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt] Move project files into Source
https://bugs.webkit.org/show_bug.cgi?id=52891

No new tests needed.

WebCore.pri:
WebCore.pro:

2011-01-24 Andras Becsi <abecsi@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt] Move project files into Source
https://bugs.webkit.org/show_bug.cgi?id=52891

declarative/declarative.pro:
docs/docs.pri:
tests/tests.pri:

2011-01-24 Andras Becsi <abecsi@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt] Move project files into Source
https://bugs.webkit.org/show_bug.cgi?id=52891

DerivedSources.pro:
WebKit2.pro:
WebProcess.pro:

2011-01-24 Andras Becsi <abecsi@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt] Move project files into Source
https://bugs.webkit.org/show_bug.cgi?id=52891

DerivedSources.pro: Renamed from DerivedSources.pro.
DumpRenderTree/qt/DumpRenderTree.pro:
DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
MiniBrowser/DerivedSources.pro:
MiniBrowser/qt/MiniBrowser.pro:
QtTestBrowser/QtTestBrowser.pro:
Scripts/webkitdirs.pm:
Tools.pro: Added.
WebKitTestRunner/DerivedSources.pro:
WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
WebKitTestRunner/qt/WebKitTestRunner.pro:

02:32 Changeset [76495] by tkent@chromium.org

Unreviewed, trivial fix.

Fix a Chromium-only assertion failure by r76491.
https://bugs.webkit.org/show_bug.cgi?id=38982

Separate icon loading from the FileChooser constructor in order to avoid
ref() before adoptRef().

platform/FileChooser.cpp:

(WebCore::FileChooser::FileChooser):
(WebCore::FileChooser::initialize):
(WebCore::FileChooser::create):

platform/FileChooser.h:

02:27 Changeset [76494] by morrita@google.com

2011-01-24 MORITA Hajime <morrita@google.com>

Reviewed by Kent Tamura.

TextControlInnerElement::m_shadowParent should be removed.
https://bugs.webkit.org/show_bug.cgi?id=52998

No new tests. No behavioral change.

rendering/TextControlInnerElements.cpp: (WebCore::TextControlInnerElement::TextControlInnerElement):
rendering/TextControlInnerElements.h:

02:20 Changeset [76493] by yurys@chromium.org

2011-01-24 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

REGRESSION (r72895): console.trace crashes
https://bugs.webkit.org/show_bug.cgi?id=52981

Use local RefPtr variable for accessing PassRefPtr arguments to make sure the PassRefPtr has non-null value.
Use PassRefPtr for objects whos ownership is passed to the inspector.

GNUmakefile.am:
WebCore.gypi:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
inspector/InspectorConsoleInstrumentation.h: Added. Extract inline methods called from the console into their own header to reduce compilation time of other classes that depend on the inspector instrumentation. (WebCore::InspectorInstrumentation::addMessageToConsole): (WebCore::InspectorInstrumentation::consoleCount): (WebCore::InspectorInstrumentation::startConsoleTiming): (WebCore::InspectorInstrumentation::stopConsoleTiming): (WebCore::InspectorInstrumentation::consoleMarkTimeline): (WebCore::InspectorInstrumentation::addStartProfilingMessageToConsole): (WebCore::InspectorInstrumentation::addProfile): (WebCore::InspectorInstrumentation::profilerEnabled): (WebCore::InspectorInstrumentation::getCurrentUserInitiatedProfileName):
inspector/InspectorDatabaseInstrumentation.h: Added. Extract inline methods called from the datanase code into their own header to reduce compilation time of other classes that depend on the inspector instrumentation. (WebCore::InspectorInstrumentation::didOpenDatabase):
inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::addMessageToConsoleImpl): (WebCore::InspectorInstrumentation::consoleCountImpl): (WebCore::InspectorInstrumentation::stopConsoleTimingImpl): (WebCore::InspectorInstrumentation::consoleMarkTimelineImpl): (WebCore::InspectorInstrumentation::addProfileImpl): (WebCore::InspectorInstrumentation::didOpenDatabaseImpl):
inspector/InspectorInstrumentation.h:
page/Console.cpp: use RefPtr local variable instead of accessing PassRefPtr argument directly. (WebCore::Console::addMessage): (WebCore::Console::trace): (WebCore::Console::count): (WebCore::Console::markTimeline): (WebCore::Console::profileEnd): (WebCore::Console::timeEnd): (WebCore::Console::group): (WebCore::Console::groupCollapsed):
storage/Database.cpp: (WebCore::Database::openDatabase):

01:16 Changeset [76492] by yuzo@google.com

2011-01-24 Yuzo Fujishima <yuzo@google.com>

Unreviewed Chromium test expectation change.

Update Chromim test expectations (LINUX/SVG) in response to r76442, again.

platform/chromium-linux/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt: Added.
platform/chromium-linux/svg/custom/svg-fonts-in-html-expected.txt: Added.
platform/chromium-linux/svg/custom/svg-fonts-with-no-element-reference-expected.txt: Added.
platform/chromium-linux/svg/text/text-hkern-expected.txt: Added.
platform/chromium-linux/svg/text/text-hkern-on-vertical-text-expected.checksum: Added.
platform/chromium-linux/svg/text/text-hkern-on-vertical-text-expected.png: Added.
platform/chromium-linux/svg/text/text-hkern-on-vertical-text-expected.txt: Added.
platform/chromium-linux/svg/text/text-text-04-t-expected.txt: Added.
platform/chromium-linux/svg/text/text-vkern-expected.checksum: Added.
platform/chromium-linux/svg/text/text-vkern-expected.txt: Added.

01:15 Changeset [76491] by tkent@chromium.org

2010-01-24 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Support icon loading for <input type=file>
https://bugs.webkit.org/show_bug.cgi?id=38982

An icon data in Chromium port is represented as WebCore::Image. We
don't need OS-specific code anymore.

WebCore.gypi:
platform/graphics/Icon.h: (WebCore::Icon::create): Add Chromium-specific factory.
platform/graphics/chromium/IconChromium.cpp: Added.
platform/graphics/chromium/IconChromiumLinux.cpp: Removed.
platform/graphics/chromium/IconChromiumMac.cpp: Removed.
platform/graphics/chromium/IconChromiumWin.cpp: Removed.
platform/graphics/chromium/PlatformIcon.h:

2010-01-24 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Support icon loading for <input type=file>
https://bugs.webkit.org/show_bug.cgi?id=38982

Implement ChromeClientImpl::chooseIconForFiles(). It delegates loading
to WebViewClient::queryIconForFiles(), and an implementation of
WebViewClient::queryIconForFiles() loads an icon and passes it to a
FileChooser through WebIconLoadingCompletion.

WebKit.gyp:
public/WebIconLoadingCompletion.h: Added. (WebKit::WebIconLoadingCompletion::~WebIconLoadingCompletion):
public/WebViewClient.h: (WebKit::WebViewClient::queryIconForFiles):
src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::chooseIconForFiles):
src/WebIconLoadingCompletionImpl.cpp: Added. (WebKit::WebIconLoadingCompletionImpl::WebIconLoadingCompletionImpl): (WebKit::WebIconLoadingCompletionImpl::~WebIconLoadingCompletionImpl): (WebKit::WebIconLoadingCompletionImpl::didLoadIcon):
src/WebIconLoadingCompletionImpl.h: Added.

01:10 Changeset [76490] by alex@webkit.org

2011-01-24 Alejandro G. Castro <alex@igalia.com>

Unreviewed, GTK still does not have TestInputController support. Opened
a bug to follow the issue:
https://bugs.webkit.org/show_bug.cgi?id=52997

platform/gtk/Skipped:

01:05 Changeset [76489] by morrita@google.com

2011-01-24 MORITA Hajime <morrita@google.com>

Unreviewed, skipped insert-composition-whitespace.html due to missing DRT feature.

platform/gtk/Skipped:

00:44 Changeset [76488] by podivilov@chromium.org

2011-01-21 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: move search functions from SourceView to SourceFrame.
https://bugs.webkit.org/show_bug.cgi?id=52895

This is the last step before eliminating SourceView and ScriptView since
this classes just delegate everything to SourceFrame.

inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype.set visible): (WebInspector.SourceFrame.prototype._clearLineHighlight): (WebInspector.SourceFrame.prototype._createTextViewer): (WebInspector.SourceFrame.prototype.performSearch.doFindSearchMatches): (WebInspector.SourceFrame.prototype.performSearch): (WebInspector.SourceFrame.prototype.searchCanceled): (WebInspector.SourceFrame.prototype.jumpToFirstSearchResult): (WebInspector.SourceFrame.prototype.jumpToLastSearchResult): (WebInspector.SourceFrame.prototype.jumpToNextSearchResult): (WebInspector.SourceFrame.prototype.jumpToPreviousSearchResult): (WebInspector.SourceFrame.prototype.showingFirstSearchResult): (WebInspector.SourceFrame.prototype.showingLastSearchResult): (WebInspector.SourceFrame.prototype._jumpToSearchResult):
inspector/front-end/SourceView.js: (WebInspector.SourceView.prototype.hide): (WebInspector.SourceView.prototype.searchCanceled): (WebInspector.SourceView.prototype.performSearch): (WebInspector.SourceView.prototype.jumpToFirstSearchResult): (WebInspector.SourceView.prototype.jumpToLastSearchResult): (WebInspector.SourceView.prototype.jumpToNextSearchResult): (WebInspector.SourceView.prototype.jumpToPreviousSearchResult): (WebInspector.SourceView.prototype.showingFirstSearchResult): (WebInspector.SourceView.prototype.showingLastSearchResult): (WebInspector.SourceView.prototype.clearMessages):

00:33 Changeset [76487] by commit-queue@webkit.org

2011-01-24 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r76463.
http://trac.webkit.org/changeset/76463
https://bugs.webkit.org/show_bug.cgi?id=52993

It broke canvas/philip/tests/2d.path.stroke.skew.html
(Requested by Ossy on #webkit).

platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::rotate):
platform/graphics/qt/PathQt.cpp: (WebCore::Path::addArc):

00:33 Changeset [76486] by alex@webkit.org

2011-01-24 Alejandro G. Castro <alex@igalia.com>

Unreviewed, skipped tests failing the 64bits bot and passing in the
32bits bots. Bug following the issue:
https://bugs.webkit.org/show_bug.cgi?id=52996

platform/gtk/Skipped:

01/23/11:

23:52 Changeset [76485] by yuzo@google.com

2011-01-23 Yuzo Fujishima <yuzo@google.com>

Unreviewed Chromium test expectation change.

Update Chromim test expectations (LINUX/SVG) in response to r76442.

platform/chromium-linux/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt: Added.
platform/chromium-linux/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt: Added.
platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-03-t-expected.txt: Added.
platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt: Added.
platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-36-t-expected.txt: Added.
platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-40-t-expected.txt: Added.
platform/chromium-linux/svg/W3C-SVG-1.1/fonts-desc-02-t-expected.txt: Added.
platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.txt: Added.
platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.txt: Added.
platform/chromium-linux/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.txt: Added.
platform/chromium-linux/svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt: Added.
platform/chromium-linux/svg/W3C-SVG-1.1/render-groups-01-b-expected.txt: Added.
platform/chromium-linux/svg/W3C-SVG-1.1/render-groups-03-t-expected.txt: Added.
platform/chromium-linux/svg/W3C-SVG-1.1/text-text-04-t-expected.txt: Added.
platform/chromium-linux/svg/text/text-vkern-on-horizontal-text-expected.txt: Added.
platform/chromium/test_expectations.txt:

23:19 Changeset [76484] by yuzo@google.com

2011-01-23 Yuzo Fujishima <yuzo@google.com>

Unreviewed Chromium test expectation change.

Update Chromim test expectations (WIN/SVG) in response to r76442.

platform/chromium-win/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt:
platform/chromium-win/svg/custom/svg-fonts-in-html-expected.checksum:
platform/chromium-win/svg/custom/svg-fonts-in-html-expected.png:
platform/chromium-win/svg/custom/svg-fonts-in-html-expected.txt:
platform/chromium-win/svg/custom/svg-fonts-with-no-element-reference-expected.checksum:
platform/chromium-win/svg/custom/svg-fonts-with-no-element-reference-expected.png:
platform/chromium-win/svg/custom/svg-fonts-with-no-element-reference-expected.txt: Added.
platform/chromium-win/svg/text/text-hkern-on-vertical-text-expected.checksum:
platform/chromium-win/svg/text/text-hkern-on-vertical-text-expected.png:
platform/chromium-win/svg/text/text-hkern-on-vertical-text-expected.txt: Added.
platform/chromium-win/svg/text/text-text-04-t-expected.checksum:
platform/chromium-win/svg/text/text-text-04-t-expected.png:
platform/chromium-win/svg/text/text-text-04-t-expected.txt:
platform/chromium-win/svg/text/text-vkern-expected.checksum:
platform/chromium-win/svg/text/text-vkern-expected.png:
platform/chromium-win/svg/text/text-vkern-expected.txt: Added.

23:13 Changeset [76483] by caseq@chromium.org

2011-01-23 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: summary bar is not resized properly with the rest of net
https://bugs.webkit.org/show_bug.cgi?id=52881

inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype.updateSidebarWidth): (WebInspector.NetworkPanel.prototype._positionSummaryBar): (WebInspector.NetworkPanel.prototype._toggleGridMode):

22:53 Changeset [76482] by morrita@google.com

2011-01-19 MORITA Hajime <morrita@google.com>

Reviewed by Ryosuke Niwa.

Space and tab characters "sent" by an input method give totally different results than typing them directly.
https://bugs.webkit.org/show_bug.cgi?id=5241

Added a test that exercises continous whitespace characters and tabs inserted by IME.

editing/inserting/insert-composition-whitespace-expected.txt: Added.
editing/inserting/insert-composition-whitespace.html: Added.

2011-01-19 MORITA Hajime <morrita@google.com>

Reviewed by Ryosuke Niwa.

Space and tab characters "sent" by an input method give totally different results than typing them directly
https://bugs.webkit.org/show_bug.cgi?id=5241

Introduced TextEvent::InputTypeComposition and TypingCommand::TextCompositionType to distinguish text input which is originated by composition.
Generalized rebalanceWhitespaceAt() to rebalanceWhitespaceOnTextSubstring() to rebalancing range of string on text node, instead of surrounding part of that.

Test: editing/inserting/insert-composition-whitespace.html

dom/TextEvent.h: (WebCore::TextEvent::isComposition):
dom/TextEventInputType.h: Added TextEventInputComposition as a member of TextEvent::InputType
editing/CompositeEditCommand.cpp: (WebCore::containsOnlyWhitespace): (WebCore::CompositeEditCommand::shouldRebalanceLeadingWhitespaceFor): (WebCore::CompositeEditCommand::canRebalance): (WebCore::CompositeEditCommand::rebalanceWhitespaceAt): (WebCore::CompositeEditCommand::rebalanceWhitespaceOnTextSubstring): Added: A generalized version of rebalanceWhitespaceAt(), which takes a range inside Text string.
editing/CompositeEditCommand.h:
editing/Editor.cpp: (WebCore::Editor::insertTextForConfirmedComposition): Added. (WebCore::Editor::insertTextWithoutSendingTextEvent): (WebCore::Editor::confirmComposition): Now uses insertTextForConfirmedComposition(). (WebCore::Editor::setComposition):
editing/Editor.h:
editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::input):
editing/InsertTextCommand.h:
editing/TypingCommand.cpp: (WebCore::TypingCommand::TypingCommand): (WebCore::TypingCommand::insertText): (WebCore::TypingCommand::insertTextRunWithoutNewlines):
editing/TypingCommand.h: Added TypingCommand::m_compositionType and TypingCommand::TextCompositionType (WebCore::TypingCommand::setCompositionType): Added. (WebCore::TypingCommand::create):

21:37 Changeset [76481] by yuzo@google.com

2011-01-23 Yuzo Fujishima <yuzo@google.com>

Unreviewed Chromium test expectation change.
Update Chromim test expectations (WIN) in response to r76442.

platform/chromium-win/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt: Added.
platform/chromium-win/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt: Added.
platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-03-t-expected.txt:
platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt:
platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-36-t-expected.txt:
platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-40-t-expected.txt:
platform/chromium-win/svg/W3C-SVG-1.1/fonts-desc-02-t-expected.txt:
platform/chromium-win/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.txt:
platform/chromium-win/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.txt:
platform/chromium-win/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.txt:
platform/chromium-win/svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt:
platform/chromium-win/svg/W3C-SVG-1.1/render-groups-01-b-expected.txt:
platform/chromium-win/svg/W3C-SVG-1.1/render-groups-03-t-expected.txt:
platform/chromium-win/svg/W3C-SVG-1.1/text-text-04-t-expected.txt:
platform/chromium-win/svg/batik/text/xmlSpace-expected.txt:
platform/chromium-win/svg/text/text-hkern-expected.txt: Added.
platform/chromium-win/svg/text/text-vkern-on-horizontal-text-expected.txt: Added.
platform/chromium/test_expectations.txt:

20:52 Changeset [76480] by tkent@chromium.org

Merge 76319

2011-01-20 Xiaomei Ji <xji@chromium.org>

Reviewed by Dan Bernstein.

Fix regression(r71566): PDF in RTL block might messes up text directionality.
https://bugs.webkit.org/show_bug.cgi?id=52776

Test: fast/dom/52776.html

platform/text/BidiResolver.h: (WebCore::::checkDirectionInLowerRaiseEmbeddingLevel): (WebCore::::lowerExplicitEmbeddingLevel): (WebCore::::raiseExplicitEmbeddingLevel): (WebCore::::createBidiRunsForLine):

BUG=70234
TBR=laforge

19:48 Changeset [76479] by yuzo@google.com

2011-01-23 Yuzo Fujishima <yuzo@google.com>

Unreviewed Chromium test expectation change.
Mark fast/dom/Document/CaretRangeFromPoint/hittest-relative-to-viewport.html as TEXT for LINUX.

platform/chromium/test_expectations.txt:

19:46 Changeset [76478] by mrowe@apple.com

Follow-up to r76477.

Fix the scripts that detect problematic code such as static initializers
and destructors, weak vtables, inappropriate files in the framework wrappers,
and public headers including private headers. These had all been broken
since the projects were moved in to the Source directory as the paths to the
scripts were not updated at that time.

Source/JavaScriptCore:

JavaScriptCore.xcodeproj/project.pbxproj:

Source/JavaScriptGlue:

JavaScriptGlue.xcodeproj/project.pbxproj:

Source/WebCore:

Stop copying an IDL file in to the framework wrapper. Doing that doesn't even make sense.

WebCore.xcodeproj/project.pbxproj:

Source/WebKit:

WebKit.xcodeproj/project.pbxproj:

19:26 Changeset [76477] by mrowe@apple.com

Build fix after r76459.

Static member variables or globals of types that have constructors or destructors are bad as
they generate static initializers and destructors. This is code that is run either at link time
when the library is loaded in to memory or at application termination time. Both of these are
terrible for performance and are thus outlawed in WebKit code.

The typical solution is to replace the static member or global with a function that allocates
the necessary variable on the heap. The variable is leaked to prevent it from being destroyed
at application termination time. The DEFINE_STATIC_LOCAL macro wraps this in to a concise little
package, but sadly fails to work in this case due to the type containing multiple template
parameters.

inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::inspectorAgents):

inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::bindInspectorAgent):
(WebCore::InspectorInstrumentation::unbindInspectorAgent):
(WebCore::InspectorInstrumentation::inspectorAgentForPage):

18:33 Changeset [76476] by yuzo@google.com

2011-01-23 Yuzo Fujishima <yuzo@google.com>

Unreviewed Chromium test expectation change.
Update Chromim test expectations in response to r76442.

platform/chromium-linux/fast/css/acid2-expected.txt: Added.
platform/chromium-linux/fast/css/acid2-pixel-expected.checksum:
platform/chromium-linux/fast/css/acid2-pixel-expected.png:
platform/chromium-linux/fast/css/acid2-pixel-expected.txt: Added.
platform/chromium-linux/fast/forms/button-sizes-expected.checksum:
platform/chromium-linux/fast/forms/button-sizes-expected.png:
platform/chromium-linux/fast/forms/button-sizes-expected.txt:
platform/chromium-linux/fast/forms/input-button-sizes-expected.checksum:
platform/chromium-linux/fast/forms/input-button-sizes-expected.png:
platform/chromium-linux/fast/forms/input-button-sizes-expected.txt:
platform/chromium-linux/http/tests/misc/acid2-expected.txt: Added.
platform/chromium-linux/http/tests/misc/acid2-pixel-expected.checksum:
platform/chromium-linux/http/tests/misc/acid2-pixel-expected.png:
platform/chromium-linux/http/tests/misc/acid2-pixel-expected.txt: Added.
platform/chromium-linux/svg/W3C-SVG-1.1/interact-zoom-01-t-expected.txt: Removed.
platform/chromium-linux/svg/W3C-SVG-1.1/text-text-01-b-expected.txt:
platform/chromium-linux/svg/hixie/perf/003-expected.txt: Removed.
platform/chromium-linux/svg/hixie/perf/004-expected.txt: Removed.
platform/chromium-linux/svg/hixie/perf/005-expected.txt: Removed.
platform/chromium-linux/svg/hixie/perf/006-expected.txt: Removed.
platform/chromium-linux/svg/hixie/viewbox/preserveAspectRatio/001-expected.txt: Removed.
platform/chromium-linux/svg/hixie/viewbox/preserveAspectRatio/002-expected.txt: Removed.
platform/chromium-linux/svg/text/text-text-01-b-expected.checksum:
platform/chromium-linux/svg/text/text-text-01-b-expected.png:
platform/chromium-linux/svg/text/text-text-01-b-expected.txt:

17:53 Changeset [76475] by vangelis@chromium.org

2011-01-21 Vangelis Kokkevis <vangelis@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Add support for -webkit-mask properties to the
accelerated compositing path.
https://bugs.webkit.org/show_bug.cgi?id=49780

Tests: Existing tests in LayoutTests/compositing/masks

platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::draw): (WebCore::ContentLayerChromium::unreserveContentsTexture): (WebCore::ContentLayerChromium::bindContentsTexture):
platform/graphics/chromium/ContentLayerChromium.h:
platform/graphics/chromium/GraphicsLayerChromium.cpp: (WebCore::GraphicsLayerChromium::setMaskLayer):
platform/graphics/chromium/GraphicsLayerChromium.h:
platform/graphics/chromium/LayerChromium.cpp: (WebCore::LayerChromium::LayerChromium):
platform/graphics/chromium/LayerChromium.h: (WebCore::LayerChromium::setMaskLayer): (WebCore::LayerChromium::maskLayer): (WebCore::LayerChromium::unreserveContentsTexture): (WebCore::LayerChromium::bindContentsTexture):
platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::updateLayersRecursive):
platform/graphics/chromium/LayerTexture.cpp: (WebCore::LayerTexture::bindTexture):
platform/graphics/chromium/RenderSurfaceChromium.cpp: (WebCore::RenderSurfaceChromium::SharedValues::SharedValues): (WebCore::RenderSurfaceChromium::SharedValues::~SharedValues): (WebCore::RenderSurfaceChromium::RenderSurfaceChromium): (WebCore::RenderSurfaceChromium::draw):
platform/graphics/chromium/RenderSurfaceChromium.h: (WebCore::RenderSurfaceChromium::SharedValues::maskShaderProgram): (WebCore::RenderSurfaceChromium::SharedValues::maskShaderSamplerLocation): (WebCore::RenderSurfaceChromium::SharedValues::maskShaderMaskSamplerLocation): (WebCore::RenderSurfaceChromium::SharedValues::maskShaderMatrixLocation): (WebCore::RenderSurfaceChromium::SharedValues::maskShaderAlphaLocation):

17:00 Changeset [76474] by paroga@webkit.org

2011-01-23 Patrick Gansterer <paroga@webkit.org>

Reviewed by Darin Adler.

Use WTF::StringHasher in WebCore
https://bugs.webkit.org/show_bug.cgi?id=52934

Add an additional function to calculate the hash
of data with a runtimedependent size.

wtf/StringHasher.h: (WTF::StringHasher::createBlobHash):

2011-01-23 Patrick Gansterer <paroga@webkit.org>

Reviewed by Darin Adler.

Use WTF::StringHasher in WebCore
https://bugs.webkit.org/show_bug.cgi?id=52934

loader/appcache/ApplicationCacheStorage.cpp: (WebCore::urlHostHash):
platform/LinkHash.cpp: (WebCore::visitedLinkHashInline):
platform/cf/BinaryPropertyList.cpp: (WebCore::IntegerArrayHash::hash):
platform/graphics/wx/FontPlatformDataWx.cpp: (WebCore::FontPlatformData::computeHash):
platform/network/ProtectionSpaceHash.h: (WebCore::ProtectionSpaceHash::hash):

15:50 Changeset [76473] by kdecker@apple.com

2011-01-23 Damian Kaleta <dkaleta@apple.com>

Reviewed by Kevin Decker.

<rdar://problem/8905171>
https://bugs.webkit.org/show_bug.cgi?id=52985

UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::scaleWebView): Eliminated early return inside WebPageProxy::scaleWebView, making it consistent with WebKit1.

15:17 Changeset [76472] by paroga@webkit.org

2011-01-23 Patrick Gansterer <paroga@webkit.org>

Reviewed by David Kilzer.

Add an overload to base64Encode with String output
https://bugs.webkit.org/show_bug.cgi?id=50122

This change removes duplicated code.

inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::resourceContentBase64):
page/DOMWindow.cpp: (WebCore::DOMWindow::btoa):
platform/graphics/skia/FontCustomPlatformData.cpp: (WebCore::createUniqueFontName):
platform/graphics/win/FontCustomPlatformData.cpp: (WebCore::createUniqueFontName):
platform/graphics/wince/FontCustomPlatformData.cpp: (WebCore::createUniqueFontName):
platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::encodeBasicAuthorization):
platform/network/mac/ResourceHandleMac.mm: (WebCore::encodeBasicAuthorization):
platform/text/Base64.cpp: (WebCore::base64Encode):
platform/text/Base64.h: (WebCore::base64Encode):
platform/wince/KeygenWinCE.cpp: (WebCore::WebCore::signedPublicKeyAndChallengeString):

14:57 Changeset [76471] by paroga@webkit.org

2011-01-23 Patrick Gansterer <paroga@webkit.org>

Reviewed by David Kilzer.

Fix comment in String::ascii()
https://bugs.webkit.org/show_bug.cgi?id=52980

wtf/text/WTFString.cpp: (WTF::String::ascii):

14:28 Changeset [76470] by ap@apple.com

2011-01-23 Alexey Proskuryakov <ap@apple.com>

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=52968
Use a separate NSView for printing

Also addresses <rdar://problem/8900148> Improper check for
-[NSGraphicsContext currentContextDrawingToScreen]

UIProcess/API/mac/WKPrintingView.h: Added.
UIProcess/API/mac/WKPrintingView.mm: Added. (-[WKPrintingView initWithFrameProxy:]): (-[WKPrintingView isFlipped]): (-[WKPrintingView _adjustPrintingMarginsForHeaderAndFooter]): (-[WKPrintingView knowsPageRange:]): (-[WKPrintingView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]): (-[WKPrintingView drawPageBorderWithSize:]): (-[WKPrintingView _provideTotalScaleFactorForPrintOperation:]): (-[WKPrintingView rectForPage:]):
UIProcess/API/mac/WKView.mm: (-[WKView drawRect:]): (-[WKView canChangeFrameLayout:]): (-[WKView printOperationWithPrintInfo:forFrame:]):
WebKit2.xcodeproj/project.pbxproj: Moved printing code to a separate view, simplifying as appropriate. The view is currently not referenced by anything in WebKit2 directly, being owned by NSPrintOperation.

14:02 Changeset [76469] by paroga@webkit.org

2011-01-23 Patrick Gansterer <paroga@webkit.org>

Reviewed by David Kilzer.

Add String::containsOnlyLatin1()
https://bugs.webkit.org/show_bug.cgi?id=52979

wtf/text/WTFString.h: (WTF::String::containsOnlyLatin1): (WTF::charactersAreAllLatin1):

2011-01-23 Patrick Gansterer <paroga@webkit.org>

Reviewed by David Kilzer.

Add String::containsOnlyLatin1()
https://bugs.webkit.org/show_bug.cgi?id=52979

Use String::containsOnlyLatin1() instead of isSafeToConvertCharList().

page/DOMWindow.cpp: (WebCore::DOMWindow::btoa): (WebCore::DOMWindow::atob):

13:08 Changeset [76468] by ap@apple.com

2011-01-23 Alexey Proskuryakov <ap@apple.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=15649
Empty STYLE elements are not reflected into the document.styleSheets object

Adding a test for a bug that no longer occurs.

fast/dom/document-stylesheets-empty-style-expected.txt: Added.
fast/dom/document-stylesheets-empty-style.html: Added.

11:50 Changeset [76467] by paroga@webkit.org

2011-01-23 Patrick Gansterer <paroga@webkit.org>

Reviewed by Andreas Kling.

[CMake] Add missing CodeGenerator dependencies
https://bugs.webkit.org/show_bug.cgi?id=52976

CMakeLists.txt:

11:28 Changeset [76466] by yael.aharon@nokia.com

2011-01-23 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt][Symbian] Fix --minimal build
https://bugs.webkit.org/show_bug.cgi?id=52839

Some of the plugins' functionality is reimplemented in
Symbian specific files.
Some of this functionality should be compiled in even if
the guard NETSCAPE_PLUGIN_API is turned off.
This patch moves that functionality out of the
NETSCAPE_PLUGIN_API guard.

Build fix so no new tests.

WebCore.pro:
plugins/symbian/PluginPackageSymbian.cpp:

11:16 Changeset [76465] by paroga@webkit.org

2011-01-23 Patrick Gansterer <paroga@webkit.org>

Reviewed by Oliver Hunt.

Remove obsolete JSVALUE32 code
https://bugs.webkit.org/show_bug.cgi?id=52948

r70111 removed support for JSVALUE32.
ARM, MIPS and X86 support JSVALUE32_64 only.

jit/JITStubs.cpp:

09:33 Changeset [76464] by mitz@apple.com

<rdar://problem/6097826> Mail's cursor does not become a resize cursor when moving mouse from scrolled email to the horizontal splitter

Reviewed by John Sullivan.

WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::setCursor): If the current cursor comes from a cursor rect, do not override it.

08:24 Changeset [76463] by andreas.kling@nokia.com

2011-01-23 Andreas Kling <kling@webkit.org>

Reviewed by Tor Arne Vestbø.

[Qt] Use rad2deg() from WTF instead of rolling our own.

platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::rotate):
platform/graphics/qt/PathQt.cpp: (WebCore::Path::addArc):

06:43 Changeset [76462] by andreas.kling@nokia.com

2011-01-23 Kenneth Rohde Christiansen <kenneth@webkit.org>

Reviewed by Andreas Kling.

Viewport meta: Always adjust device dimensions to the device pixel ratio.

dom/ViewportArguments.cpp: (WebCore::computeViewportAttributes):

06:33 Changeset [76461] by andreas.kling@nokia.com

2011-01-23 Andreas Kling <kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

Don't scale absolute geometry specified by viewport meta tag.

dom/ViewportArguments.cpp: (WebCore::computeViewportAttributes):

02:48 Changeset [76460] by loislo@chromium.org

2011-01-23 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed build fix.

Web Inspector: looks like efl doesn't regenerate InspectorBackendDispatcher.

Touch Inspector.idl.

inspector/Inspector.idl:

01:36 Changeset [76459] by pfeldman@chromium.org

2011-01-22 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: next step in splitting InspectorController.

Splitting InspectorController is a bit tricky process.

As a first step I'll do the next things:
1) rename existing InspectorController to InspectorAgent;
2) s/nspectorController/nspectorAgent/g everywhere in WebCore/inspector but InspectorInstrumentation;
3) create a fake InspectorController derived from the InspectorAgent for the rest of WebCore and WebKit;

The second step is a migration of a small set of functions described in bug 52510 from InspectorAgent to InspectorController.

As far as the second step will have significant changes in the functions' implementation I'll do it as a separate patch.

https://bugs.webkit.org/show_bug.cgi?id=52955

CMakeLists.txt:
GNUmakefile.am:
WebCore.exp.in:
WebCore.gypi:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::JSInjectedScriptHost::nodeForId): (WebCore::JSInjectedScriptHost::selectDOMStorage):
bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::V8InjectedScriptHost::nodeForIdCallback):
inspector/CodeGeneratorInspector.pm:
inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::InjectedScriptHost): (WebCore::InjectedScriptHost::clearConsoleMessages): (WebCore::InjectedScriptHost::databaseForId): (WebCore::InjectedScriptHost::selectDatabase): (WebCore::InjectedScriptHost::selectDOMStorage): (WebCore::InjectedScriptHost::injectedScriptForMainFrame): (WebCore::InjectedScriptHost::inspectorDOMAgent): (WebCore::InjectedScriptHost::frontend): (WebCore::InjectedScriptHost::didCreateWorker): (WebCore::InjectedScriptHost::didDestroyWorker):
inspector/InjectedScriptHost.h: (WebCore::InjectedScriptHost::create): (WebCore::InjectedScriptHost::inspectorAgent): (WebCore::InjectedScriptHost::disconnectController):
inspector/InspectorAgent.cpp: Copied from Source/WebCore/inspector/InspectorController.cpp. (WebCore::InspectorAgent::InspectorAgent): (WebCore::InspectorAgent::~InspectorAgent): (WebCore::InspectorAgent::inspectedPageDestroyed): (WebCore::InspectorAgent::enabled): (WebCore::InspectorAgent::inspectorStartsAttached): (WebCore::InspectorAgent::setInspectorStartsAttached): (WebCore::InspectorAgent::setInspectorAttachedHeight): (WebCore::InspectorAgent::inspectorAttachedHeight): (WebCore::InspectorAgent::searchingForNodeInPage): (WebCore::InspectorAgent::restoreInspectorStateFromCookie): (WebCore::InspectorAgent::inspect): (WebCore::InspectorAgent::focusNode): (WebCore::InspectorAgent::highlight): (WebCore::InspectorAgent::highlightDOMNode): (WebCore::InspectorAgent::highlightFrame): (WebCore::InspectorAgent::hideHighlight): (WebCore::InspectorAgent::mouseDidMoveOverElement): (WebCore::InspectorAgent::handleMousePress): (WebCore::InspectorAgent::setInspectorFrontendClient): (WebCore::InspectorAgent::didClearWindowObjectInWorld): (WebCore::InspectorAgent::setSearchingForNode): (WebCore::InspectorAgent::connectFrontend): (WebCore::InspectorAgent::show): (WebCore::InspectorAgent::showPanel): (WebCore::InspectorAgent::close): (WebCore::InspectorAgent::disconnectFrontend): (WebCore::InspectorAgent::resourceAgent): (WebCore::InspectorAgent::releaseFrontendLifetimeAgents): (WebCore::InspectorAgent::populateScriptObjects): (WebCore::InspectorAgent::pushDataCollectedOffline): (WebCore::InspectorAgent::restoreDebugger): (WebCore::InspectorAgent::restoreProfiler): (WebCore::InspectorAgent::unbindAllResources): (WebCore::InspectorAgent::didCommitLoad): (WebCore::InspectorAgent::mainResourceFiredDOMContentEvent): (WebCore::InspectorAgent::mainResourceFiredLoadEvent): (WebCore::InspectorAgent::isMainResourceLoader): (WebCore::InspectorAgent::willSendRequest): (WebCore::InspectorAgent::ensureSettingsLoaded): (WebCore::InspectorAgent::startTimelineProfiler): (WebCore::InspectorAgent::stopTimelineProfiler): (WebCore::PostWorkerNotificationToFrontendTask::create): (WebCore::PostWorkerNotificationToFrontendTask::PostWorkerNotificationToFrontendTask): (WebCore::PostWorkerNotificationToFrontendTask::performTask): (WebCore::InspectorAgent::postWorkerNotificationToFrontend): (WebCore::InspectorAgent::didCreateWorker): (WebCore::InspectorAgent::didDestroyWorker): (WebCore::InspectorAgent::didOpenDatabase): (WebCore::InspectorAgent::getCookies): (WebCore::InspectorAgent::buildArrayForCookies): (WebCore::InspectorAgent::buildObjectForCookie): (WebCore::InspectorAgent::deleteCookie): (WebCore::InspectorAgent::didUseDOMStorage): (WebCore::InspectorAgent::didCreateWebSocket): (WebCore::InspectorAgent::willSendWebSocketHandshakeRequest): (WebCore::InspectorAgent::didReceiveWebSocketHandshakeResponse): (WebCore::InspectorAgent::didCloseWebSocket): (WebCore::InspectorAgent::isRecordingUserInitiatedProfile): (WebCore::InspectorAgent::startUserInitiatedProfiling): (WebCore::InspectorAgent::stopUserInitiatedProfiling): (WebCore::InspectorAgent::profilerEnabled): (WebCore::InspectorAgent::enableProfiler): (WebCore::InspectorAgent::disableProfiler): (WebCore::InspectorAgent::showAndEnableDebugger): (WebCore::InspectorAgent::enableDebugger): (WebCore::InspectorAgent::disableDebugger): (WebCore::InspectorAgent::resume): (WebCore::InspectorAgent::setAllBrowserBreakpoints): (WebCore::InspectorAgent::evaluateForTestInFrontend): (WebCore::InspectorAgent::didEvaluateForTestInFrontend): (WebCore::quadToPath): (WebCore::drawOutlinedQuad): (WebCore::drawOutlinedQuadWithClip): (WebCore::drawHighlightForBox): (WebCore::drawHighlightForLineBoxesOrSVGRenderer): (WebCore::convertFromFrameToMainFrame): (WebCore::frameToMainFrameOffset): (WebCore::InspectorAgent::drawNodeHighlight): (WebCore::InspectorAgent::drawElementTitle): (WebCore::InspectorAgent::openInInspectedWindow): (WebCore::InspectorAgent::addScriptToEvaluateOnLoad): (WebCore::InspectorAgent::removeAllScriptsToEvaluateOnLoad): (WebCore::InspectorAgent::setInspectorExtensionAPI): (WebCore::InspectorAgent::inspectedURL): (WebCore::InspectorAgent::reloadPage): (WebCore::InspectorAgent::setExtraHeaders):
inspector/InspectorAgent.h: Copied from Source/WebCore/inspector/InspectorController.h. (WebCore::InspectorAgent::inspectorBackendDispatcher): (WebCore::InspectorAgent::inspectorClient): (WebCore::InspectorAgent::injectedScriptHost): (WebCore::InspectorAgent::inspectedPage): (WebCore::InspectorAgent::hideDOMNodeHighlight): (WebCore::InspectorAgent::hideFrameHighlight): (WebCore::InspectorAgent::frontend): (WebCore::InspectorAgent::inspectorController): (WebCore::InspectorAgent::inspectorAgent): (WebCore::InspectorAgent::consoleAgent): (WebCore::InspectorAgent::cssAgent): (WebCore::InspectorAgent::domAgent): (WebCore::InspectorAgent::injectedScriptAgent): (WebCore::InspectorAgent::runtimeAgent): (WebCore::InspectorAgent::timelineAgent): (WebCore::InspectorAgent::databaseAgent): (WebCore::InspectorAgent::domStorageAgent): (WebCore::InspectorAgent::fileSystemAgent): (WebCore::InspectorAgent::browserDebuggerAgent): (WebCore::InspectorAgent::debuggerAgent): (WebCore::InspectorAgent::profilerAgent): (WebCore::InspectorAgent::applicationCacheAgent): (WebCore::InspectorAgent::hasInspectorFrontendClient): (WebCore::InspectorAgent::hasFrontend): (WebCore::InspectorAgent::startProfiling): (WebCore::InspectorAgent::stopProfiling): (WebCore::InspectorAgent::debuggerEnabled): (WebCore::InspectorAgent::state): (WebCore::InspectorAgent::settings):
inspector/InspectorApplicationCacheAgent.cpp: (WebCore::InspectorApplicationCacheAgent::InspectorApplicationCacheAgent): (WebCore::InspectorApplicationCacheAgent::getApplicationCaches):
inspector/InspectorApplicationCacheAgent.h:
inspector/InspectorBrowserDebuggerAgent.cpp: (WebCore::InspectorBrowserDebuggerAgent::InspectorBrowserDebuggerAgent): (WebCore::InspectorBrowserDebuggerAgent::inspectedURLChanged): (WebCore::InspectorBrowserDebuggerAgent::restoreStickyBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::setDOMBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::removeDOMBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::willInsertDOMNode): (WebCore::InspectorBrowserDebuggerAgent::willRemoveDOMNode): (WebCore::InspectorBrowserDebuggerAgent::willModifyDOMAttr): (WebCore::InspectorBrowserDebuggerAgent::descriptionForDOMEvent): (WebCore::InspectorBrowserDebuggerAgent::pauseOnNativeEventIfNeeded): (WebCore::InspectorBrowserDebuggerAgent::willSendXMLHttpRequest):
inspector/InspectorBrowserDebuggerAgent.h: (WebCore::InspectorBrowserDebuggerAgent::create):
inspector/InspectorConsoleAgent.cpp: (WebCore::InspectorConsoleAgent::InspectorConsoleAgent): (WebCore::InspectorConsoleAgent::~InspectorConsoleAgent): (WebCore::InspectorConsoleAgent::clearConsoleMessages): (WebCore::InspectorConsoleAgent::addMessageToConsole): (WebCore::InspectorConsoleAgent::resourceRetrievedByXMLHttpRequest): (WebCore::InspectorConsoleAgent::didReceiveResponse): (WebCore::InspectorConsoleAgent::didFailLoading): (WebCore::InspectorConsoleAgent::setMonitoringXHREnabled): (WebCore::InspectorConsoleAgent::setConsoleMessagesEnabled): (WebCore::InspectorConsoleAgent::addConsoleMessage):
inspector/InspectorConsoleAgent.h:
inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController):
inspector/InspectorController.h:
inspector/InspectorDatabaseAgent.cpp:
inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::create): (WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent): (WebCore::InspectorDebuggerAgent::~InspectorDebuggerAgent): (WebCore::InspectorDebuggerAgent::evaluateOnCallFrame): (WebCore::InspectorDebuggerAgent::getCompletionsOnCallFrame): (WebCore::InspectorDebuggerAgent::currentCallFrames):
inspector/InspectorDebuggerAgent.h:
inspector/InspectorFileSystemAgent.cpp: (WebCore::InspectorFileSystemAgentCallbacks::didOpenFileSystem): (WebCore::InspectorFileSystemAgent::InspectorFileSystemAgent): (WebCore::InspectorFileSystemAgent::stop): (WebCore::InspectorFileSystemAgent::getFileSystemPathAsync): (WebCore::InspectorFileSystemAgent::didGetFileSystemPath): (WebCore::InspectorFileSystemAgent::didGetFileSystemError):
inspector/InspectorFileSystemAgent.h: (WebCore::InspectorFileSystemAgent::create):
inspector/InspectorFrontendHost.cpp: (WebCore::InspectorFrontendHost::setExtensionAPI):
inspector/InspectorProfilerAgent.cpp: (WebCore::InspectorProfilerAgent::create): (WebCore::InspectorProfilerAgent::InspectorProfilerAgent): (WebCore::InspectorProfilerAgent::addProfileFinishedMessageToConsole): (WebCore::InspectorProfilerAgent::addStartProfilingMessageToConsole): (WebCore::InspectorProfilerAgent::startUserInitiatedProfiling): (WebCore::InspectorProfilerAgent::stopUserInitiatedProfiling):
inspector/InspectorProfilerAgent.h:

2011-01-22 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: next step in splitting InspectorController.

#include "InspectorController.h" was added.

https://bugs.webkit.org/show_bug.cgi?id=52955

WebCoreSupport/InspectorServerQt.cpp:

01/22/11:

21:48 Changeset [76458] by mjs@apple.com

2011-01-22 Maciej Stachowiak <mjs@apple.com>

Reviewed by Oliver Hunt.

Skip a test that seems to cause the subsequent test to sporadically fail, and unskip the several tests after it
https://bugs.webkit.org/show_bug.cgi?id=52970

platform/mac-wk2/Skipped:

21:03 Changeset [76457] by ggaren@apple.com

2011-01-22 Geoffrey Garen <ggaren@apple.com>

Reviewed by Dan Bernstein.

ASSERT running run-webkit-tests --threaded.
https://bugs.webkit.org/show_bug.cgi?id=52971

SunSpider and v8 report no change.

runtime/ConservativeSet.cpp: (JSC::ConservativeSet::grow): (JSC::ConservativeSet::add):
runtime/ConservativeSet.h: Tweaked the inline capacity to 128, and the growth policy to 2X, to make SunSpider and v8 happy. (JSC::ConservativeSet::ConservativeSet): (JSC::ConservativeSet::~ConservativeSet): (JSC::ConservativeSet::mark): Use OSAllocator directly, instead of malloc. Malloc is forbidden during a multi-threaded mark phase because it can cause deadlock.

2011-01-22 Geoffrey Garen <ggaren@apple.com>

Reviewed by Dan Bernstein.

Beefed up --threaded mode to catch even more kinds of errors.
https://bugs.webkit.org/show_bug.cgi?id=52971

DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Use a shared context group to force JSC to mark multiple threads. (This used to be the default, but it changed in SnowLeopard.) (runJavaScriptThread): Do more locking and unlocking, and more allocation, to give threading mistakes more chances to show themselves. (startJavaScriptThreads): (stopJavaScriptThreads):

16:33 Changeset [76456] by dbates@webkit.org

2011-01-22 Chris Rogers <crogers@google.com>

Rubber-stamped by Anders Carlsson.

Fix FFTFrameStub to compile properly
https://bugs.webkit.org/show_bug.cgi?id=52969

No new tests since this is a build fix.

platform/audio/FFTFrameStub.cpp: (WebCore::FFTFrame::FFTFrame):

13:55 Changeset [76455] by jam@chromium.org

2011-01-22 John Abd-El-Malek <jam@chromium.org>

Reviewed by Adam Barth.

[chromium]: Fix WebScrollbarImpl not getting scroll events after recent scrollbar refactoring
https://bugs.webkit.org/show_bug.cgi?id=52967

src/WebScrollbarImpl.cpp: (WebKit::WebScrollbarImpl::horizontalScrollbar): (WebKit::WebScrollbarImpl::verticalScrollbar):
src/WebScrollbarImpl.h:

12:11 Changeset [76454] by ggaren@apple.com

2011-01-22 Geoffrey Garen <ggaren@apple.com>

Reviewed by Geoffrey Garen.

Rubber-stamped by Maciej Stachowiak.

A few of Maciej's review suggestions for my last patch.
https://bugs.webkit.org/show_bug.cgi?id=52946

SunSpider reports no change.

Android.mk:
CMakeLists.txt:
GNUmakefile.am:
JavaScriptCore.gypi:
JavaScriptCore.pro:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
JavaScriptCore.xcodeproj/project.pbxproj: Updated build systems.

runtime/ConservativeSet.cpp: Added. (JSC::isPointerAligned): (JSC::ConservativeSet::add):
runtime/ConservativeSet.h: Added. (JSC::ConservativeSet::ConservativeSet): (JSC::ConservativeSet::mark): Split ConservativeSet out into its own file, and moved the conservative check into ConservativeSet::add, making ConservativeSet's responsibility clearer.

runtime/Heap.cpp: (JSC::Heap::markRoots):
runtime/MachineStackMarker.cpp: (JSC::MachineStackMarker::markCurrentThreadConservativelyInternal): (JSC::MachineStackMarker::markOtherThreadConservatively):
runtime/MachineStackMarker.h:
runtime/MarkStack.h: Updated for changes above.

11:56 Changeset [76453] by andersca@apple.com

2011-01-22 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Transparent windows with compositing WebKit2 content show garbage
https://bugs.webkit.org/show_bug.cgi?id=52966
<rdar://problem/8765051>

UIProcess/mac/LayerBackedDrawingAreaProxyMac.mm: (WebKit::LayerBackedDrawingAreaProxy::paint): If the WKView should draw transparent background, do so.

11:36 Changeset [76452] by andersca@apple.com

2011-01-22 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Add an asynchronous WKPageForceRepaint
https://bugs.webkit.org/show_bug.cgi?id=52964
<rdar://problem/8898527>

UIProcess/API/C/WKPage.cpp: (WKPageForceRepaint): Call WebPageProxy::forceRepaint.

UIProcess/API/C/WKPage.h: Add WKPageForceRepaint.

UIProcess/GenericCallback.h: Add a "generic" VoidCallback class.

UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::forceRepaint): Insert the callback in the m_voidCallbacks map and send a forceRepaint message.

(WebKit::WebPageProxy::voidCallback):
Call the right void callback.

(WebKit::WebPageProxy::processDidCrash):
Invalidate m_voidCallbacks.

UIProcess/WebPageProxy.messages.in: Add a VoidCallback message.

WebProcess/WebPage/ChunkedUpdateDrawingArea.cpp: (WebKit::ChunkedUpdateDrawingArea::forceRepaint): Force a repaint.

WebProcess/WebPage/ChunkedUpdateDrawingArea.h: Add forceRepaint.

WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::forceRepaint): Call forceRepaint on the drawing area.

WebProcess/WebPage/WebPage.messages.in: Add a ForceRepaint message.

09:27 Changeset [76451] by robert@webkit.org

2011-01-22 Robert Hogan <robert@webkit.org>

Reviewed by Andreas Kling.

[Qt] Support layoutTestController.addURLToRedirect()
https://bugs.webkit.org/show_bug.cgi?id=52956

platform/qt/Skipped:

2011-01-22 Robert Hogan <robert@webkit.org>

Reviewed by Andreas Kling.

[Qt] Support layoutTestController.addURLToRedirect()
https://bugs.webkit.org/show_bug.cgi?id=52956

WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::addURLToRedirect):
WebCoreSupport/DumpRenderTreeSupportQt.h:
WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::dispatchWillSendRequest):
WebCoreSupport/FrameLoaderClientQt.h:

2011-01-22 Robert Hogan <robert@webkit.org>

Reviewed by Andreas Kling.

[Qt] Support layoutTestController.addURLToRedirect()
https://bugs.webkit.org/show_bug.cgi?id=52956

DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::addURLToRedirect):
DumpRenderTree/qt/LayoutTestControllerQt.h:

08:16 Changeset [76450] by zimmermann@webkit.org

2011-01-22 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed.

REGRESSION: Vertical line metrics incorrect
https://bugs.webkit.org/show_bug.cgi?id=52960

Revert accidently landed mac baseline changes.

platform/mac/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt:
platform/mac/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt:
platform/mac/svg/W3C-SVG-1.1/animate-elem-03-t-expected.txt:
platform/mac/svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt:
platform/mac/svg/W3C-SVG-1.1/animate-elem-36-t-expected.txt:
platform/mac/svg/W3C-SVG-1.1/animate-elem-40-t-expected.txt:
platform/mac/svg/W3C-SVG-1.1/fonts-desc-02-t-expected.txt:
platform/mac/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.txt:
platform/mac/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.txt:
platform/mac/svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt:
platform/mac/svg/W3C-SVG-1.1/render-groups-01-b-expected.txt:
platform/mac/svg/W3C-SVG-1.1/render-groups-03-t-expected.txt:
platform/mac/svg/W3C-SVG-1.1/text-text-04-t-expected.txt:
platform/mac/svg/batik/text/xmlSpace-expected.txt:
platform/mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt:
platform/mac/svg/custom/svg-fonts-in-html-expected.txt:
platform/mac/svg/custom/svg-fonts-with-no-element-reference-expected.txt:
platform/mac/svg/text/text-hkern-expected.txt:
platform/mac/svg/text/text-hkern-on-vertical-text-expected.txt:
platform/mac/svg/text/text-text-04-t-expected.txt:
platform/mac/svg/text/text-vkern-expected.txt:
platform/mac/svg/text/text-vkern-on-horizontal-text-expected.txt:
platform/mac/svg/transforms/text-with-mask-with-svg-transform-expected.txt:

07:14 Changeset [76449] by zimmermann@webkit.org

2011-01-22 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed.

REGRESSION: Vertical line metrics incorrect
https://bugs.webkit.org/show_bug.cgi?id=52960

Rebaselined several text dumps from the bots, after the FontMetrics change.
All show 1px diffs, but are progressions, since the lineSpacing calculation has been improved.
Mac still has the old results - as it depends on a rounding trick at the moment.

platform/gtk/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt:
platform/gtk/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt:
platform/gtk/svg/text/text-hkern-expected.txt:
platform/gtk/svg/text/text-hkern-on-vertical-text-expected.txt:
platform/gtk/svg/text/text-vkern-expected.txt:
platform/gtk/svg/text/text-vkern-on-horizontal-text-expected.txt:
platform/mac/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt:
platform/mac/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt:
platform/mac/svg/W3C-SVG-1.1/animate-elem-03-t-expected.txt:
platform/mac/svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt:
platform/mac/svg/W3C-SVG-1.1/animate-elem-36-t-expected.txt:
platform/mac/svg/W3C-SVG-1.1/animate-elem-40-t-expected.txt:
platform/mac/svg/W3C-SVG-1.1/fonts-desc-02-t-expected.txt:
platform/mac/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.txt:
platform/mac/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.txt:
platform/mac/svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt:
platform/mac/svg/W3C-SVG-1.1/render-groups-01-b-expected.txt:
platform/mac/svg/W3C-SVG-1.1/render-groups-03-t-expected.txt:
platform/mac/svg/W3C-SVG-1.1/text-text-04-t-expected.txt:
platform/mac/svg/batik/text/xmlSpace-expected.txt:
platform/mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt:
platform/mac/svg/custom/svg-fonts-in-html-expected.txt:
platform/mac/svg/custom/svg-fonts-with-no-element-reference-expected.txt:
platform/mac/svg/text/text-hkern-expected.txt:
platform/mac/svg/text/text-hkern-on-vertical-text-expected.txt:
platform/mac/svg/text/text-text-04-t-expected.txt:
platform/mac/svg/text/text-vkern-expected.txt:
platform/mac/svg/text/text-vkern-on-horizontal-text-expected.txt:
platform/mac/svg/transforms/text-with-mask-with-svg-transform-expected.txt:
platform/qt/css2.1/t1507-c526-font-sz-02-b-a-expected.txt:
platform/qt/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt:
platform/qt/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt:
platform/qt/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.txt:
platform/qt/svg/text/text-hkern-expected.txt:
platform/qt/svg/text/text-hkern-on-vertical-text-expected.txt:
platform/qt/svg/text/text-vkern-expected.txt:
platform/qt/svg/text/text-vkern-on-horizontal-text-expected.txt:
platform/qt/svg/transforms/text-with-mask-with-svg-transform-expected.txt:

07:00 Changeset [76448] by andreip@google.com

2011-01-22 Andrei Popescu <andreip@google.com>

Reviewed by Jeremy Orlow.

IndexedDB corrupts data on disk
https://bugs.webkit.org/show_bug.cgi?id=52890

storage/indexeddb/data-corruption-expected.txt: Added.
storage/indexeddb/data-corruption.html: Added.

2011-01-22 Andrei Popescu <andreip@google.com>

Reviewed by Jeremy Orlow.

IndexedDB corrupts data on disk
https://bugs.webkit.org/show_bug.cgi?id=52890

We need to store the SerializedScriptValues on disk in a BLOB column rather than TEXT.
Test: storage/indexeddb/data-corruption.html

platform/sql/SQLiteStatement.cpp: (WebCore::SQLiteStatement::bindBlob): (WebCore::SQLiteStatement::getColumnBlobAsString): (WebCore::SQLiteStatement::getColumnBlobAsVector):
platform/sql/SQLiteStatement.h:
storage/IDBCursorBackendImpl.cpp: (WebCore::IDBCursorBackendImpl::loadCurrentRow):
storage/IDBFactoryBackendImpl.cpp: (WebCore::runCommands): (WebCore::createTables): (WebCore::createMetaDataTable): (WebCore::migrateDatabase):
storage/IDBObjectStoreBackendImpl.cpp: (WebCore::IDBObjectStoreBackendImpl::getInternal): (WebCore::putObjectStoreData):

06:18 Changeset [76447] by zimmermann@webkit.org

2011-01-22 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Fix WinCE build.

platform/graphics/wince/GraphicsContextWinCE.cpp: (WebCore::GraphicsContext::drawText):
rendering/RenderThemeWinCE.cpp: (WebCore::RenderThemeWinCE::adjustMenuListButtonStyle):

06:13 Changeset [76446] by robert@webkit.org

2011-01-22 Robert Hogan <robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] REGRESSION (r72360): http/tests/security/aboutBlank/xss-DENIED-* tests fail
https://bugs.webkit.org/show_bug.cgi?id=49802

platform/qt/Skipped:
platform/qt/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-document-write-expected.txt: Added.
platform/qt/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-javascript-url-expected.txt: Added.
platform/qt/http/tests/security/aboutBlank/xss-DENIED-set-opener-expected.txt: Added.

2011-01-22 Robert Hogan <robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] REGRESSION (r72360): http/tests/security/aboutBlank/xss-DENIED-* tests fail
https://bugs.webkit.org/show_bug.cgi?id=49802

DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): (WebCore::DumpRenderTree::open):

05:46 Changeset [76445] by zimmermann@webkit.org

2011-01-22 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

REGRESSION: Vertical line metrics incorrect
https://bugs.webkit.org/show_bug.cgi?id=52960

SimpleFontDataMac.mm contains a hack to modifiy lineGap/descent for the 'Hiragino' font.
That didn't influence the lineSpacing so far, but does now, causing regressions.

Restore old line spacing behaviour to fix the regression.
Covered by existing fast/blockflow, fast/repaint and fast/text/international test cases.

platform/graphics/FontMetrics.h: (WebCore::FontMetrics::FontMetrics): (WebCore::FontMetrics::floatLineSpacing): (WebCore::FontMetrics::setLineSpacing): (WebCore::FontMetrics::lineSpacing): (WebCore::FontMetrics::reset):
platform/graphics/SimpleFontData.cpp: (WebCore::SimpleFontData::SimpleFontData):
platform/graphics/chromium/SimpleFontDataChromiumWin.cpp: (WebCore::SimpleFontData::platformInit):
platform/graphics/chromium/SimpleFontDataLinux.cpp: (WebCore::SimpleFontData::platformInit):
platform/graphics/freetype/SimpleFontDataFreeType.cpp: (WebCore::SimpleFontData::platformInit):
platform/graphics/haiku/SimpleFontDataHaiku.cpp: (WebCore::SimpleFontData::platformInit):
platform/graphics/mac/SimpleFontDataMac.mm: (WebCore::SimpleFontData::platformInit):
platform/graphics/pango/SimpleFontDataPango.cpp: (WebCore::SimpleFontData::platformInit):
platform/graphics/qt/SimpleFontDataQt.cpp: (WebCore::SimpleFontData::platformInit):
platform/graphics/win/SimpleFontDataCGWin.cpp: (WebCore::SimpleFontData::platformInit):
platform/graphics/win/SimpleFontDataCairoWin.cpp: (WebCore::SimpleFontData::platformInit):
platform/graphics/win/SimpleFontDataWin.cpp: (WebCore::SimpleFontData::initGDIFont):
platform/graphics/wince/SimpleFontDataWinCE.cpp: (WebCore::SimpleFontData::platformInit):
platform/graphics/wx/SimpleFontDataWx.cpp: (WebCore::SimpleFontData::platformInit):

04:52 Changeset [76444] by andreas.kling@nokia.com

2011-01-22 Andreas Kling <kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] fast/backgrounds/svg-as-mask.html fails
https://bugs.webkit.org/show_bug.cgi?id=52906

Transparency layers should start out with in SourceOver mode with
alpha 1.0 (modeled after CGContextBeginTransparencyLayer.)

platform/graphics/qt/TransparencyLayer.h: (WebCore::TransparencyLayer::TransparencyLayer):

04:44 Changeset [76443] by zimmermann@webkit.org

2011-01-22 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed.

Introduce FontMetrics abstraction
https://bugs.webkit.org/show_bug.cgi?id=51456

Fix Chromium/Win build.

platform/graphics/chromium/UniscribeHelperTextRun.cpp: s/->/./ (WebCore::UniscribeHelperTextRun::UniscribeHelperTextRun):

03:46 Changeset [76442] by zimmermann@webkit.org

2011-01-21 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Introduce FontMetrics abstraction
https://bugs.webkit.org/show_bug.cgi?id=51456

src/ExternalPopupMenu.cpp: Use FontMetrics instead of Font to access the metrics. (WebKit::ExternalPopupMenu::getPopupMenuInfo):
src/WebFontImpl.cpp: Ditto. (WebKit::WebFontImpl::ascent): (WebKit::WebFontImpl::descent): (WebKit::WebFontImpl::height): (WebKit::WebFontImpl::lineSpacing): (WebKit::WebFontImpl::xHeight):

2011-01-21 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Introduce FontMetrics abstraction
https://bugs.webkit.org/show_bug.cgi?id=51456

FullscreenVideoController.cpp: Use FontMetrics instead of Font to access the metrics. (FullscreenVideoController::draw):
WebCoreSupport/WebDragClient.cpp: Ditto. (WebDragClient::createDragImageForLink):
WebKitGraphics.cpp: Ditto. (FontMetrics):

2011-01-21 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Introduce FontMetrics abstraction
https://bugs.webkit.org/show_bug.cgi?id=51456

Encapsulate ascent/descent/lineHeight/lineGap methods in a single FontMetrics class, instead of
having to define them in both Font & SimpleFontData. Changed to store floating point values
as default, in order to get accurate information for small sized fonts. All these methods
now have floating-point and integer versions. Whenever an integer variant of these functions
is called, lroundf() is used to round the value.

This makes it possible to support small font-sizes for SVG in a follow-up patch, as well
as fixing rounding issues when using SVG Fonts.

Shouldn't affect existing tests.

GNUmakefile.am: Add FontMetrics.h to build.
WebCore.gypi: Ditto.
WebCore.pro: Ditto.
WebCore.vcproj/WebCore.vcproj: Ditto.
WebCore.xcodeproj/project.pbxproj: Ditto.
accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: Use style->fontMetrics() instead of style->font() to access the metrics. (baselinePositionForAccessibilityRenderObject):
css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::computeLengthDouble):
html/canvas/CanvasRenderingContext2D.cpp: Ditto. (WebCore::CanvasRenderingContext2D::drawTextInternal):
inspector/InspectorController.cpp: Ditto. (WebCore::InspectorController::drawElementTitle):
platform/chromium/PopupMenuChromium.cpp: Ditto. (WebCore::PopupListBox::paintRow): (WebCore::PopupListBox::getRowHeight):
platform/graphics/Font.h: Remove ascent/descent/height/lineGap/lineSpacing/xHeight/unitsPerEm accessor... (WebCore::Font::fontMetrics): ... and only expose a single FontMetrics object here.
platform/graphics/FontFastPath.cpp: Use fontMetrics() to query metrics information. (WebCore::Font::emphasisMarkAscent): (WebCore::Font::emphasisMarkDescent): (WebCore::Font::emphasisMarkHeight): (WebCore::Font::floatWidthForSimpleText):
platform/graphics/FontMetrics.h: Added. (WebCore::FontMetrics::FontMetrics): Creates a FontMetrics object, stored in SimpleFontData. (WebCore::FontMetrics::unitsPerEm): Returns an unsigned describing the unitsPerEm. (WebCore::FontMetrics::setUnitsPerEm): Sets the unitsPerEm value. (WebCore::FontMetrics::floatAscent): Returns the stored m_ascent float. (WebCore::FontMetrics::setAscent): Sets the stored m_ascent float. (WebCore::FontMetrics::floatDescent): Returns the stored m_descent float. (WebCore::FontMetrics::setDescent): Sets the stored m_descent float. (WebCore::FontMetrics::floatHeight): Returns floatAscent() + floatDescent(). (WebCore::FontMetrics::floatLineGap): Returns the stored m_lineGap float. (WebCore::FontMetrics::setLineGap): Sets the stored m_lineGap float. (WebCore::FontMetrics::floatLineSpacing): Returns the stored m_lineSpacing float. (WebCore::FontMetrics::setLineSpacing): Sets the stored m_lineSpacing float. (WebCore::FontMetrics::xHeight): Returns the stored m_xHeight float (no integer version available, hence no 'float' prefix). (WebCore::FontMetrics::setXHeight): Sets the stored m_xHeight float. (WebCore::FontMetrics::ascent): Returns a rounded version of ascent(). (WebCore::FontMetrics::descent): Ditto (for descent). (WebCore::FontMetrics::height): Returns ascent() + descent(). (WebCore::FontMetrics::lineGap): Returns a rounded version of lineGap(). (WebCore::FontMetrics::lineSpacing): Ditto (for lineSpacing). (WebCore::FontMetrics::reset): Nulls all members, used only by the platform variants of SimpleFontData.
platform/graphics/SimpleFontData.cpp: Adapt SVG Fonts code, to initialize the FontMetrics object, as the m_ascent/etc.. members are gone. (WebCore::SimpleFontData::SimpleFontData): (WebCore::SimpleFontData::initCharWidths):
platform/graphics/SimpleFontData.h: Remove ascent/descent/height/lineSpacing/lineGap/xHeight/unitsPerEm accessors, and members, just store a FontMetrics object and expose it. (WebCore::SimpleFontData::fontMetrics): (WebCore::SimpleFontData::avgCharWidth):
platform/graphics/chromium/FontChromiumWin.cpp: Use fontMetrics() to query font metrics. (WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::estimateTextBounds): (WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::drawGlyphs): (WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::estimateTextBounds): (WebCore::Font::drawComplexText):
platform/graphics/chromium/SimpleFontDataChromiumWin.cpp: Adapt platform code, to initialize the FontMetrics object. (WebCore::SimpleFontData::platformInit):
platform/graphics/chromium/SimpleFontDataLinux.cpp: Ditto. (WebCore::SimpleFontData::platformInit):
platform/graphics/chromium/UniscribeHelperTextRun.cpp: Use fontMetrics() to query font metrics. (WebCore::UniscribeHelperTextRun::UniscribeHelperTextRun): (WebCore::UniscribeHelperTextRun::nextWinFontData):
platform/graphics/freetype/SimpleFontDataFreeType.cpp: Adapt platform code, to initialize the FontMetrics object. (WebCore::SimpleFontData::platformInit):
platform/graphics/haiku/SimpleFontDataHaiku.cpp: Ditto. (WebCore::SimpleFontData::platformInit):
platform/graphics/mac/FontComplexTextMac.cpp: Use fontMetrics() to query font metrics. (WebCore::Font::floatWidthForComplexText):
platform/graphics/mac/FontMac.mm: Ditto. (WebCore::showGlyphsWithAdvances):
platform/graphics/mac/SimpleFontDataMac.mm: Adapt platform code, to initialize the FontMetrics object. (WebCore::SimpleFontData::platformInit): (WebCore::SimpleFontData::platformCharWidthInit):
platform/graphics/pango/SimpleFontDataPango.cpp: Ditto. (WebCore::SimpleFontData::platformInit):
platform/graphics/qt/SimpleFontDataQt.cpp: Ditto. (+ Switch to QFontMetricsF to get floating-point accurancy.) (WebCore::SimpleFontData::platformInit):
platform/graphics/win/FontCGWin.cpp: Use fontMetrics() to query font metrics. (WebCore::drawGDIGlyphs):
platform/graphics/win/FontWin.cpp: Ditto. (WebCore::Font::floatWidthForComplexText):
platform/graphics/win/SimpleFontDataCGWin.cpp: Adapt platform code, to initialize the FontMetrics object. (WebCore::SimpleFontData::platformInit): (WebCore::SimpleFontData::platformBoundsForGlyph):
platform/graphics/win/SimpleFontDataCairoWin.cpp: Ditto. (WebCore::SimpleFontData::platformInit):
platform/graphics/win/SimpleFontDataWin.cpp: Ditto. (WebCore::SimpleFontData::initGDIFont):
platform/graphics/wince/GraphicsContextWinCE.cpp: Use fontMetrics() to query font metrics. (WebCore::GraphicsContext::drawText):
platform/graphics/wince/SimpleFontDataWinCE.cpp: Adapt platform code, to initialize the FontMetrics object. (WebCore::SimpleFontData::platformInit):
platform/graphics/wx/SimpleFontDataWx.cpp: Ditto. (WebCore::SimpleFontData::platformInit):
platform/win/PopupMenuWin.cpp: Use style->fontMetrics() instead of style->font() to access the metrics. (WebCore::PopupMenuWin::calculatePositionAndSize): (WebCore::PopupMenuWin::paint):
rendering/EllipsisBox.cpp: Ditto. (WebCore::EllipsisBox::paint): (WebCore::EllipsisBox::nodeAtPoint):
rendering/InlineBox.cpp: Ditto. (WebCore::InlineBox::logicalHeight):
rendering/InlineFlowBox.cpp: Ditto. (WebCore::verticalPositionForBox): (WebCore::InlineFlowBox::computeLogicalBoxHeights): (WebCore::InlineFlowBox::placeBoxesInBlockDirection):
rendering/InlineTextBox.cpp: Ditto. (WebCore::InlineTextBox::paint): (WebCore::InlineTextBox::paintDecoration): (WebCore::InlineTextBox::paintSpellingOrGrammarMarker): (WebCore::InlineTextBox::paintCompositionUnderline):
rendering/RenderBlock.cpp: Ditto. (WebCore::RenderBlock::baselinePosition): (WebCore::RenderBlock::firstLineBoxBaseline): (WebCore::RenderBlock::lastLineBoxBaseline):
rendering/RenderBox.cpp: Ditto. (WebCore::RenderBox::localCaretRect):
rendering/RenderEmbeddedObject.cpp: Ditto. (WebCore::RenderEmbeddedObject::paintReplaced):
rendering/RenderImage.cpp: Ditto. (WebCore::RenderImage::setImageSizeForAltText): (WebCore::RenderImage::paintReplaced):
rendering/RenderInline.cpp: Ditto. (WebCore::RenderInline::baselinePosition):
rendering/RenderListBox.cpp: Ditto. (WebCore::RenderListBox::paintItemForeground): (WebCore::RenderListBox::itemHeight):
rendering/RenderListMarker.cpp: Ditto. (WebCore::RenderListMarker::paint): (WebCore::RenderListMarker::layout): (WebCore::RenderListMarker::computePreferredLogicalWidths): (WebCore::RenderListMarker::updateMargins): (WebCore::RenderListMarker::getRelativeMarkerRect):
rendering/RenderTextControl.cpp: Ditto. (WebCore::RenderTextControl::paintPlaceholder):
rendering/RenderTextControlSingleLine.cpp: Ditto. (WebCore::RenderTextControlSingleLine::createInnerTextStyle):
rendering/RenderThemeWin.cpp: Ditto. (WebCore::RenderThemeWin::adjustMenuListButtonStyle):
rendering/mathml/RenderMathMLFraction.cpp: Ditto. (WebCore::RenderMathMLFraction::baselinePosition):
rendering/style/RenderStyle.h: Add "const FontMetrics& fontMetrics() const" accessor. (WebCore::InheritedFlags::fontMetrics): (WebCore::InheritedFlags::computedLineHeight):
rendering/svg/RenderSVGInlineText.cpp: Use style->fontMetrics() instead of style->font() to access the metrics. (WebCore::RenderSVGInlineText::positionForPoint):
rendering/svg/SVGInlineTextBox.cpp: Ditto. (WebCore::SVGInlineTextBox::selectionRectForTextFragment): (WebCore::positionOffsetForDecoration): (WebCore::SVGInlineTextBox::paintDecorationWithStyle): (WebCore::SVGInlineTextBox::paintTextWithShadows): (WebCore::SVGInlineTextBox::calculateBoundaries):
rendering/svg/SVGTextLayoutEngineBaseline.cpp: Ditto. (WebCore::SVGTextLayoutEngineBaseline::calculateBaselineShift): (WebCore::SVGTextLayoutEngineBaseline::calculateAlignmentBaselineShift): (WebCore::SVGTextLayoutEngineBaseline::calculateGlyphAdvanceAndOrientation):
rendering/svg/SVGTextLayoutEngineSpacing.cpp: Ditto. (WebCore::SVGTextLayoutEngineSpacing::calculateSVGKerning):
rendering/svg/SVGTextMetrics.cpp: Ditto. (WebCore::SVGTextMetrics::SVGTextMetrics):
rendering/svg/SVGTextQuery.cpp: Ditto. (WebCore::calculateGlyphBoundaries):
svg/SVGFontFaceElement.cpp: (WebCore::SVGFontFaceElement::unitsPerEm): Rename defaultUnitsPerEm global to gDefaultUnitsPerEm.
svg/SVGLength.cpp: Use style->fontMetrics() instead of style->font() to access the metrics. (WebCore::SVGLength::convertValueFromUserUnitsToEXS): (WebCore::SVGLength::convertValueFromEXSToUserUnits):

2011-01-21 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Introduce FontMetrics abstraction
https://bugs.webkit.org/show_bug.cgi?id=51456

WebProcess/WebCoreSupport/win/WebPopupMenuWin.cpp: Use FontMetrics instead of Font to access the metrics. (WebKit::WebPopupMenu::setUpPlatformData):

03:36 Changeset [76441] by paroga@webkit.org

2011-01-22 Patrick Gansterer <paroga@webkit.org>

Unreviewed WinCE build fix for r76430.

runtime/MachineStackMarker.cpp: (JSC::swapIfBackwards):

03:02 Changeset [76440] by andreas.kling@nokia.com

2011-01-22 Andreas Kling <kling@webkit.org>

Unreviewed, add Qt-specific result for test added in r76414.

platform/qt/fast/text/justify-nbsp-expected.txt: Added.

02:58 Changeset [76439] by rniwa@webkit.org

2011-01-22 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed Chromium test expectation update.

platform/chromium/test_expectations.txt:

02:51 Changeset [76438] by rniwa@webkit.org

2011-01-22 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Eric Seidel.

Stop instantiating legacy editing positions in VisibleSelection, visible_units.cpp, Frame, and RenderBlock
https://bugs.webkit.org/show_bug.cgi?id=52759

Stopped instantiating legacy editing positions in the following files.

editing/VisibleSelection.cpp: (WebCore::VisibleSelection::adjustSelectionToAvoidCrossingEditingBoundaries):
editing/visible_units.cpp: (WebCore::previousBoundary): (WebCore::previousLinePosition): (WebCore::nextLinePosition): (WebCore::startOfBlock):
page/Frame.cpp: (WebCore::Frame::visiblePositionForPoint):
rendering/RenderBlock.cpp: Removed RenderBlock::positionForRenderer because it was not called anywhere.
rendering/RenderBlock.h: Ditto.

02:00 Changeset [76437] by enne@google.com

2011-01-22 Adrienne Walker <enne@google.com>

Reviewed by James Robinson.

[chromium] Fix compositor repaints for offscreen fixed elements
https://bugs.webkit.org/show_bug.cgi?id=52681

The fast path scrolling was clipping offscreen invalidations.
Additionally, the compositor was ignoring all invalidations that were
entirely out of the content rect.

Test: compositing/ to verify this caused no regressions.
Tested fix manually in browser as I could not generate a LayoutTest that reproduced the bug in run-webkit-tests.

page/FrameView.cpp: (WebCore::FrameView::scrollContentsFastPath):
platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::invalidateRootLayerRect):

01:29 Changeset [76436] by rniwa@webkit.org

2011-01-22 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed Chromium test expectation update.

platform/chromium/test_expectations.txt:

01:23 Changeset [76435] by ap@apple.com

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=52473
Auto-scaling to avoid orphans is broken, remove dysfunctional code

WebView/WebHTMLView.mm: (-[WebHTMLView _setPrinting:minimumPageWidth:height:maximumPageWidth:adjustViewSize:paginateScreenContent:]): (-[WebHTMLView _scaleFactorForPrintOperation:]): (-[WebHTMLView knowsPageRange:]):

01:15 Changeset [76434] by ap@apple.com

2011-01-22 Alexey Proskuryakov <ap@apple.com>

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=52950
Leak in WebPage::drawRectToPDF

WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::drawRectToPDF): Use RetainPtr here, too.

00:22 Changeset [76433] by ap@apple.com

2011-01-22 Alexey Proskuryakov <ap@apple.com>

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=52951
WebKit2 generates a bad PDF for cross process messaging

page/PrintContext.cpp: (WebCore::PrintContext::spoolRect): Use a correct offset to actually draw inside the requested rectangle.

2011-01-22 Alexey Proskuryakov <ap@apple.com>

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=52951
WebKit2 generates a bad PDF for cross process messaging

UIProcess/API/mac/WKView.mm: (-[WKView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]): Use a correct offset when flipping.

01/21/11:

23:11 Changeset [76432] by ggaren@apple.com

Reorganized MarkedSpace, making many of its functions private.

Reviewed by Beth Dakin.

runtime/JSCell.h:

(JSC::JSCell::Heap::heap):

runtime/MarkedSpace.h:

(JSC::MarkedSpace::globalData):
(JSC::MarkedSpace::heap):

22:50 Changeset [76431] by ggaren@apple.com

Try to fix build: moved helper function out of #ifdef.

runtime/MachineStackMarker.cpp:

(JSC::swapIfBackwards):

22:45 Changeset [76430] by ggaren@apple.com

A few of Maciej's review suggestions for my last patch.
https://bugs.webkit.org/show_bug.cgi?id=52946

Rubber-stamped by Maciej Stachowiak.

SunSpider reports no change.

runtime/MachineStackMarker.cpp:

(JSC::swapIfBackwards): Added a helper function for handling platforms
where the stack can grow in any direction.

(JSC::MachineStackMarker::markCurrentThreadConservativelyInternal):
(JSC::MachineStackMarker::markOtherThreadConservatively): Use the helper
function.

(JSC::isPointerAligned): Use "!" instead of "==0" because a robot told me to.

(JSC::MachineStackMarker::markConservatively): Changed to use a more
standard looping idiom, and to use the helper function above.

runtime/MarkedSpace.h:

(JSC::MarkedSpace::isCellAligned): Use "!" instead of "==0" because a robot told me to.

22:41 Changeset [76429] by abarth@webkit.org

2011-01-21 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Adam Barth.

Regression: new window.onerror() implementation leaks cross-origin Javascript errors
https://bugs.webkit.org/show_bug.cgi?id=52903

In case of an exception in a script from different domain only generic message
will be passed to window.onerror hander.

Tests: http/tests/security/cross-origin-script-window-onerror-redirected.html

http/tests/security/cross-origin-script-window-onerror.html

bindings/js/CachedScriptSourceProvider.h: use URL from the resource response to make sure we do all cross origin checks agains real script URL, not the original URL which may have resulted in a sequence of redirects to different domains. (WebCore::CachedScriptSourceProvider::CachedScriptSourceProvider):
bindings/v8/ScriptSourceCode.h: same for v8. (WebCore::ScriptSourceCode::url):
dom/ScriptExecutionContext.cpp: (WebCore::ScriptExecutionContext::dispatchErrorEvent): in case the error occurred in a script we cannot access provide concise "Script error." message without any information about the error source. This is what Firefox does in this case.

2011-01-21 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Adam Barth.

Regression: new window.onerror() implementation leaks cross-origin Javascript errors
https://bugs.webkit.org/show_bug.cgi?id=52903

A couple of tests to check that window.onerror won't reveal any content of the resource
from a different domain if the latter is referenced via <script src=...>

http/tests/security/cross-origin-script-window-onerror-expected.txt: Added.
http/tests/security/cross-origin-script-window-onerror-redirected-expected.txt: Added.
http/tests/security/cross-origin-script-window-onerror-redirected.html: Added.
http/tests/security/cross-origin-script-window-onerror.html: Added.
http/tests/security/resources/cross-origin-script.txt: Added.

21:59 Changeset [76428] by abarth@webkit.org

2011-01-21 Adam Barth <abarth@webkit.org>

Reviewed by Maciej Stachowiak.

Disable mac_unittest.py that fails on some of the Mac bots
https://bugs.webkit.org/show_bug.cgi?id=52947

As noted in the comment, this test does not appear to be correct
because the function this test is testing returns different results
depending on which flavor of Mac the test is run on. This patch
disable the test. Hopefully we can re-enable the test once we've
probably insulated the test from its environment.

Scripts/webkitpy/layout_tests/port/mac_unittest.py:

20:57 Changeset [76427] by mjs@apple.com

2011-01-21 Maciej Stachowiak <mjs@apple.com>

Reviewed by Geoffrey Garen.

Humor the WebKit2 buildbot in its continuing hatred of forms tests
https://bugs.webkit.org/show_bug.cgi?id=52944

platform/mac-wk2/Skipped:

20:30 Changeset [76426] by mitz@apple.com

Updated the results after r76414 fixed text justification in this test.

Rubber-stamped by Mark Rowe.

platform/mac/fast/text/justified-text-rect-expected.checksum:
platform/mac/fast/text/justified-text-rect-expected.png:
platform/mac/fast/text/justified-text-rect-expected.txt:

20:27 Changeset [76425] by ggaren@apple.com

2011-01-21 Geoffrey Garen <ggaren@apple.com>

Reviewed by Maciej Stachowiak.

Cleaned up some conservative marking code.
https://bugs.webkit.org/show_bug.cgi?id=52946

SunSpider reports no change.

interpreter/RegisterFile.h: No need for a special marking function, since we already expose a start() and end().

runtime/Heap.cpp: (JSC::Heap::registerFile): (JSC::Heap::markRoots):
runtime/Heap.h: (JSC::Heap::contains): Migrated markConservatively() to the machine stack marker class. Now, Heap just provides a contains() function, which the machine stack marker uses for checking whether a pointer points into the heap.

runtime/MachineStackMarker.cpp: (JSC::MachineStackMarker::markCurrentThreadConservativelyInternal): (JSC::MachineStackMarker::markOtherThreadConservatively): (JSC::isPointerAligned): (JSC::MachineStackMarker::markConservatively):
runtime/MachineStackMarker.h: Move the conservative marking code here.

runtime/MarkStack.h: (JSC::ConservativeSet::add): (JSC::ConservativeSet::mark): Changed to using a vector instead of hash set. Vector seems to be a bit faster, and it generates smaller code.

runtime/MarkedSpace.cpp: (JSC::MarkedSpace::containsSlowCase):
runtime/MarkedSpace.h: (JSC::MarkedSpace::isCellAligned): (JSC::MarkedSpace::isPossibleCell): (JSC::MarkedSpace::contains): Kept the code for determining whether a pointer pointed into marked space, and moved the code for marking a set of conservative pointers into the machine stack marker.

wtf/HashSet.h: (WTF::::add): Added two missing inlines that I noticed while testing vector vs hash set.

20:00 Changeset [76424] by jamesr@google.com

2011-01-21 James Robinson <jamesr@chromium.org>

Update chromium test expectations. fast/animation tests should now pass on all chromium configurations.

platform/chromium/test_expectations.txt:

19:31 Changeset [76423] by mrowe@apple.com

Versioning.

19:27 Changeset [76422] by mrowe@apple.com

New tag.

19:22 Changeset [76421] by mitz@apple.com

Fix test failure.

fast/text/justify-nbsp.html: Removed a contenteditable attribute

that was added after generating results.

18:51 Changeset [76420] by andreas.kling@nokia.com

2011-01-21 Andreas Kling <kling@webkit.org>

Unreviewed, removing the Qt result for r76414 since the test
was actually broken beyond the usual off-by-one metrics.

platform/qt/fast/text/justify-nbsp-expected.txt: Removed.

18:11 Changeset [76419] by andreas.kling@nokia.com

2011-01-21 Andreas Kling <kling@webkit.org>

Unreviewed, add Qt-specific result for test added in r76414.

platform/qt/fast/text/justify-nbsp-expected.txt: Added.

18:08 Changeset [76418] by ap@apple.com

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=52943
Objective-C files should use #import, not #include

UIProcess/API/C/WebKit2.h: This is an interesting one, because it's cross-platform, and there is more than one WKView.h.

Platform/mac/ModuleMac.mm:
Platform/mac/RunLoopMac.mm:
PluginProcess/mac/PluginControllerProxyMac.mm:
PluginProcess/mac/PluginProcessMac.mm:
PluginProcess/mac/PluginProcessMainMac.mm:
Shared/API/c/mac/WKCertificateInfoMac.mm:
Shared/API/c/mac/WKURLRequestNS.mm:
Shared/API/c/mac/WKURLResponseNS.mm:
Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:
Shared/mac/PlatformCertificateInfo.mm:
Shared/mac/SandboxExtensionMac.mm:
Shared/mac/WebCoreArgumentCodersMac.mm:
Shared/mac/WebMemorySampler.mac.mm:
Shared/mac/WebURLRequestMac.mm:
Shared/mac/WebURLResponseMac.mm:
UIProcess/API/mac/FindIndicatorWindow.mm:
UIProcess/API/mac/WKTextInputWindowController.mm:
UIProcess/Launcher/mac/ProcessLauncherMac.mm:
UIProcess/Launcher/mac/ThreadLauncherMac.mm:
UIProcess/Plugins/mac/PluginInfoStoreMac.mm:
UIProcess/Plugins/mac/PluginProcessProxyMac.mm:
UIProcess/mac/BackingStoreMac.mm:
UIProcess/mac/ChunkedUpdateDrawingAreaProxyMac.mm:
UIProcess/mac/LayerBackedDrawingAreaProxyMac.mm:
UIProcess/mac/TextCheckerMac.mm:
UIProcess/mac/WebContextMac.mm:
UIProcess/mac/WebContextMenuProxyMac.mm:
UIProcess/mac/WebPageProxyMac.mm:
UIProcess/mac/WebPopupMenuProxyMac.mm:
UIProcess/mac/WebPreferencesMac.mm:
WebProcess/Downloads/mac/DownloadMac.mm:
WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
WebProcess/Plugins/Netscape/mac/PluginProxyMac.mm:
WebProcess/WebCoreSupport/mac/WebContextMenuClientMac.mm:
WebProcess/WebCoreSupport/mac/WebDatabaseManagerMac.mm:
WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm:
WebProcess/WebCoreSupport/mac/WebErrorsMac.mm:
WebProcess/WebCoreSupport/mac/WebPopupMenuMac.mm:
WebProcess/WebPage/mac/LayerBackedDrawingAreaMac.mm:
WebProcess/WebPage/mac/WebPageMac.mm:
WebProcess/mac/WebProcessMac.mm:

17:46 Changeset [76417] by mrowe@apple.com

Fix the WebKit2 build with clang.

Reviewed by Sam Weinig.

Scripts/webkit2/messages.py: Add some more structs to the list.
UIProcess/DrawingAreaProxy.h: Forward-declare UpdateInfo as a class.
UIProcess/TextChecker.h: Forward-declare TextCheckerState as a struct.
UIProcess/WebPageProxy.h: Forward-declare ContextMenuState as a struct.
UIProcess/mac/TextCheckerMac.mm: Fix the type of the string constants so that they can be passed to

functions expecting NSString* without generating warnings.

WebProcess/WebPage/DrawingArea.h: Forward-declare WebPageCreationParameters as a struct.
WebProcess/WebPage/DrawingAreaImpl.h: Forward-declare UpdateInfo as a class.
WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::getResourceDataFromFrame): Add parens around the assignment in the condition of
the if statement to suppress a warning.

17:46 Changeset [76416] by mrowe@apple.com

Fix the build when using Clang by removing some unused variables.

Rubber-stamped by Jon Honeycutt.

Plugins/Hosted/WebHostedNetscapePluginView.mm:

(-[WebHostedNetscapePluginView updateAndSetWindow]):

WebView/WebFullScreenController.mm:

(-[WebFullScreenController enterFullscreen:]):
(-[WebFullScreenController exitFullscreen]):

17:45 Changeset [76415] by andreas.kling@nokia.com

2011-01-21 Andreas Kling <kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Always set composition mode through GraphicsContext
https://bugs.webkit.org/show_bug.cgi?id=52940

GraphicsContext tracks the current composition mode so we should
never call through to the QPainter directly.

platform/graphics/GraphicsContext.h:
platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::toQtCompositionMode): Changed this method to a static inline since it's only used by GraphicsContextQt.cpp now.

platform/graphics/qt/ImageQt.cpp: (WebCore::Image::drawPattern): (WebCore::BitmapImage::draw):

17:31 Changeset [76414] by mitz@apple.com

Inconsistent handling of no-break space in justification logic
https://bugs.webkit.org/show_bug.cgi?id=52938

Reviewed by Adele Peterson.

Source/WebCore:

Test: fast/text/justify-nbsp.html

rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::computeInlineDirectionPositionsForLine): Count no-break space as a
space when computing the distribution of space between text boxes on the line.

LayoutTests:

fast/text/justify-nbsp-expected.checksum: Added.
fast/text/justify-nbsp-expected.png: Added.
fast/text/justify-nbsp-expected.txt: Added.
fast/text/justify-nbsp.html: Added.

17:29 Changeset [76413] by dpranke@chromium.org

2011-01-21 Dirk Pranke <dpranke@chromium.org>

Reviewed by Mihai Parparita.

Fix bug introduced in r76322 that caused NRWT to not actually
read the Skipped files properly.

https://bugs.webkit.org/show_bug.cgi?id=52771

Scripts/webkitpy/layout_tests/port/mac_unittest.py:
Scripts/webkitpy/layout_tests/port/webkit.py:
Scripts/webkitpy/layout_tests/port/webkit_unittest.py:

17:19 Changeset [76412] by crogers@google.com

2011-01-21 Chris Rogers <crogers@google.com>

Unreviewed

define HAS_WEBAUDIO_RUNTIMEFEATURES for synchronization with chromium patch landing
https://bugs.webkit.org/show_bug.cgi?id=52941

public/WebRuntimeFeatures.h:

17:07 Changeset [76411] by crogers@google.com

2011-01-21 Chris Rogers <crogers@google.com>

Unreviewed

Add HAS_WEBAUDIO_FEATURE_ENABLE define to synchronize with chromium-side patch
https://bugs.webkit.org/show_bug.cgi?id=52939

public/WebSettings.h:

16:54 Changeset [76410] by commit-queue@webkit.org

2011-01-21 Kenji Imasaki <imasaki@chromium.org>

Reviewed by David Levin.

Remove resolved BUG13907 from test expectation file and added
newly filed BUGCR70252 for media/video-zoom.html to keep track
of the issue.

Also, remove non-flaky test (media/audio-only-video-intrinsic-size.htm).

platform/chromium/test_expectations.txt:

16:38 Changeset [76409] by mrowe@apple.com

Work around a Clang bug <rdar://problem/8876150> that leads to it incorrectly emitting an access
control warning when a client tries to use operator bool exposed above via "using PageBlock::operator bool".

Reviewed by Sam Weinig.

wtf/PageAllocation.h:

(WTF::PageAllocation::operator bool):

wtf/PageReservation.h:

(WTF::PageReservation::operator bool):

16:16 Changeset [76408] by mrobinson@webkit.org

2011-01-21 Martin Robinson <mrobinson@igalia.com>

Rebaseline tests that use menulists. Also unskip a non-existent test.

platform/gtk/Skipped: Remove non-existent test.
platform/gtk/editing/selection/select-box-expected.checksum:
platform/gtk/editing/selection/select-box-expected.png:
platform/gtk/editing/selection/select-box-expected.txt:
platform/gtk/transforms/2d/zoom-menulist-expected.checksum:
platform/gtk/transforms/2d/zoom-menulist-expected.png:
platform/gtk/transforms/2d/zoom-menulist-expected.txt:

15:52 Changeset [76407] by msaboff@apple.com

2011-01-21 Michael Saboff <msaboff@apple.com>

Reviewed by Oliver Hunt.

[RegexFuzz] Hang with forward assertion
https://bugs.webkit.org/show_bug.cgi?id=52825
<rdar://problem/8894332>

The backtrackTo label from the first term in a list of terms is
being overwritten by processing of subsequent terms. Changed
copyBacktrackToLabel() to check for an existing bcaktrackTo label
before copying and renamed it to propagateBacktrackToLabel() since
it no longer copies.

yarr/YarrJIT.cpp: (JSC::Yarr::YarrGenerator::BacktrackDestination::propagateBacktrackToLabel): (JSC::Yarr::YarrGenerator::generateParenthesesSingle):

2011-01-21 Michael Saboff <msaboff@apple.com>

Reviewed by Oliver Hunt.

[RegexFuzz] Hang with forward assertion
https://bugs.webkit.org/show_bug.cgi?id=52825
<rdar://problem/8894332>

New tests to check for functionality and future regression.

fast/regex/parentheses-expected.txt:
fast/regex/script-tests/parentheses.js:

15:47 Changeset [76406] by commit-queue@webkit.org

2011-01-21 Charlie Reis <creis@chromium.org>

Reviewed by Darin Fisher.

Crash in WebCore::HistoryController::itemsAreClones
https://bugs.webkit.org/show_bug.cgi?id=52819

Adds sanity checks to help diagnose the crash.

loader/HistoryController.cpp:

2011-01-21 Charlie Reis <creis@chromium.org>

Reviewed by Darin Fisher.

Crash in WebCore::HistoryController::itemsAreClones
https://bugs.webkit.org/show_bug.cgi?id=52819

Adds sanity checks to help diagnose the crash.

src/WebFrameImpl.cpp:

15:45 Changeset [76405] by andreas.kling@nokia.com

2011-01-21 Andreas Kling <kling@webkit.org>

Reviewed by Ariya Hidayat.

[Qt] Let QPainter decide whether a composition mode is supported or not

Lacking Porter-Duff support in the paint engine shouldn't exclude the
Source and Source-Over modes (and has nothing to do with the blend
and raster-op modes.)

Delegate this decision to QPainter instead (this will cause warnings
if an unsupported mode is used, but that's a good thing.)

platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::clearRect): (WebCore::GraphicsContext::setPlatformCompositeOperation):
platform/graphics/qt/TransparencyLayer.h: (WebCore::TransparencyLayer::TransparencyLayer):

15:43 Changeset [76404] by mjs@apple.com

2011-01-21 Maciej Stachowiak <mjs@apple.com>

Reviewed by Adele Peterson.

Skip a test that's sporadically crashing on the buildbots
https://bugs.webkit.org/show_bug.cgi?id=52932

platform/mac-wk2/Skipped:

15:42 Changeset [76403] by bweinstein@apple.com

WebKit2: Need API to stop loading a WKFrame
https://bugs.webkit.org/show_bug.cgi?id=52925

Reviewed by Adam Roben.

UIProcess/API/C/WKFrame.cpp:

(WKFrameStopLoading): Call through to WebFrameProxy::stopLoading.

UIProcess/API/C/WKFrame.h:
UIProcess/WebFrameProxy.cpp:

(WebKit::WebFrameProxy::stopLoading): Send a message to the WebProcess to stop loading the frame

with the passed in ID.

UIProcess/WebFrameProxy.h:
WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::stopLoadingFrame): Call stopForUserCancel on the passed-in frame.

WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.messages.in: Add StopLoadingFrame.

15:41 Changeset [76402] by crogers@google.com

2011-01-21 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

fix audio build: header file should be "Noncopyable.h" and not "NonCopyable.h"
https://bugs.webkit.org/show_bug.cgi?id=52933

No new tests since this just fixes the build

webaudio/RealtimeAnalyser.h:

15:32 Changeset [76401] by weinig@apple.com

WebKitTestRunner needs the HOME environment variable to be set.
<rdar://problem/8896573>

Reviewed by Geoffrey Sean Garen and Mark Rowe.

Scripts/old-run-webkit-tests: Set the HOME environment variable if

it exists.

15:28 Changeset [76400] by crogers@google.com

2011-01-21 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

Fix audio build: change ChromiumBridge to PlatformBridge
https://bugs.webkit.org/show_bug.cgi?id=52928

No new tests since audio API is not yet implemented.

platform/audio/chromium/AudioBusChromium.cpp: (WebCore::AudioBus::loadPlatformResource):

15:24 Changeset [76399] by ggaren@apple.com

2011-01-21 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Moved the mark stack from global data to the heap, since it pertains
to the heap, and not the virtual machine as a whole.
https://bugs.webkit.org/show_bug.cgi?id=52930

SunSpider reports no change.

runtime/Heap.cpp: (JSC::Heap::Heap): (JSC::Heap::markRoots):
runtime/Heap.h:
runtime/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData):
runtime/JSGlobalData.h:

15:23 Changeset [76398] by dpranke@chromium.org

2011-01-21 Dirk Pranke <dpranke@chromium.org>

Reviewed by Eric Seidel.

Suppress a few remaining integration tests so that none of the
layout_test unit tests ever read from the filesystem or launch
subprocesses that aren't part of the unit tests.

Also fix a minor bug in the printing unit tests that was
incorrectly relying on sys.argv.

https://bugs.webkit.org/show_bug.cgi?id=52863

Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
Scripts/webkitpy/layout_tests/port/port_testcase.py:
Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:

15:06 Changeset [76397] by crogers@google.com

2011-01-21 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

Add FFTFrameStub to avoid link errors during bringup on platforms without an FFT implementation
https://bugs.webkit.org/show_bug.cgi?id=52922

No new tests since audio API is not yet implemented.

WebCore.gypi:
platform/audio/FFTFrameStub.cpp: Added. (WebCore::FFTFrame::FFTFrame): (WebCore::FFTFrame::~FFTFrame): (WebCore::FFTFrame::multiply): (WebCore::FFTFrame::doFFT): (WebCore::FFTFrame::doInverseFFT): (WebCore::FFTFrame::cleanup): (WebCore::FFTFrame::realData): (WebCore::FFTFrame::imagData):

15:01 UsingGitWithWebKit edited by mrobinson@webkit.org

Added information about proper svn:mime-type configuration (diff)

14:52 Changeset [76396] by mjs@apple.com

2011-01-21 Maciej Stachowiak <mjs@apple.com>

Reviewed by Adam Roben.

Skip some newly added tests that use DRT APIs that are not yet available for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=52924

platform/mac-wk2/Skipped:

14:32 Changeset [76395] by tony@chromium.org

2011-01-21 Tony Chang <tony@chromium.org>

Reviewed by Sam Weinig.

reduce number of FrameLoaderClient::didChangeScrollOffset calls
https://bugs.webkit.org/show_bug.cgi?id=52915

Only notify of changes in scroll offset when there actually is a change.
This regressed in r76291.

Covered by Chromium browser_tests.

platform/ScrollAnimator.cpp: (WebCore::ScrollAnimator::scrollToOffsetWithoutAnimation):

14:12 Changeset [76394] by beidson@apple.com

<rdar://problem/8894125> and https://bugs.webkit.org/show_bug.cgi?id=52916
Expose "suggested filename" for a resource based on its resource response.

Reviewed by Adam Roben.

API pieces:

WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:

(WKBundleFrameCopySuggestedFilenameForResourceURL):

WebProcess/InjectedBundle/API/c/WKBundleFrame.h:

Implementation:

WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::suggestedFilenameForResourceURL): See if the DocumentLoader has

a resource for this URL and, if so, return the response's suggested filename.

WebProcess/WebPage/WebFrame.h:

14:09 Changeset [76393] by andersca@apple.com

2011-01-21 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

DrawingAreaProxyImpl::paint should return the unpainted region
https://bugs.webkit.org/show_bug.cgi?id=52918

UIProcess/API/mac/WKView.mm: (-[WKView drawRect:]): Add unpaintedRegion parameter.

UIProcess/BackingStore.h: (WebKit::BackingStore::size): Add a size getter.

UIProcess/DrawingAreaProxyImpl.cpp: (WebKit::DrawingAreaProxyImpl::paint): Initialize the unpainted region to the dirty region, then subtract the painted region.

14:00 Changeset [76392] by pfeldman@chromium.org

2011-01-21 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: ~InspectorResourceAgent crashes on closing inspected page.
https://bugs.webkit.org/show_bug.cgi?id=52900

inspector/InspectorController.cpp: (WebCore::InspectorController::~InspectorController): (WebCore::InspectorController::inspectedPageDestroyed):

13:58 Changeset [76391] by andersca@apple.com

Fix for <rdar://problem/8896057>

Reviewed by Dan Bernstein and Maciej Stachowiak.

Give the Web Process access to the PubSub agent.

WebProcess/com.apple.WebProcess.sb:

13:43 Changeset [76390] by crogers@google.com

2011-01-21 Chris Rogers <crogers@google.com>

Reviewed by Darin Fisher.

Add run-time enable support for the web audio API
https://bugs.webkit.org/show_bug.cgi?id=52741

public/WebRuntimeFeatures.h:
public/WebSettings.h:
src/WebRuntimeFeatures.cpp: (WebKit::WebRuntimeFeatures::enableWebAudio): (WebKit::WebRuntimeFeatures::isWebAudioEnabled):
src/WebSettingsImpl.cpp: (WebKit::WebSettingsImpl::setWebAudioEnabled):
src/WebSettingsImpl.h:

2011-01-21 Chris Rogers <crogers@google.com>

Reviewed by Darin Fisher.

Add run-time enable support for the web audio API
https://bugs.webkit.org/show_bug.cgi?id=52741

WebPreferenceKeysPrivate.h:
WebView.cpp: (WebView::notifyPreferencesChanged):

2011-01-21 Chris Rogers <crogers@google.com>

Reviewed by Darin Fisher.

Add run-time enable support for the web audio API
https://bugs.webkit.org/show_bug.cgi?id=52741

WebView/WebPreferenceKeysPrivate.h:
WebView/WebPreferences.mm: (-[WebPreferences webAudioEnabled]): (-[WebPreferences setWebAudioEnabled:]):
WebView/WebPreferencesPrivate.h:
WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]):

2011-01-21 Chris Rogers <crogers@google.com>

Reviewed by Darin Fisher.

Add run-time enable support for the web audio API
https://bugs.webkit.org/show_bug.cgi?id=52741

No new tests since audio API is not yet implemented.

WebCore.exp.in:
bindings/generic/RuntimeEnabledFeatures.cpp:
bindings/generic/RuntimeEnabledFeatures.h: (WebCore::RuntimeEnabledFeatures::setWebkitAudioContextEnabled): (WebCore::RuntimeEnabledFeatures::webkitAudioContextEnabled):
page/DOMWindow.idl:
page/Settings.cpp: (WebCore::Settings::Settings): (WebCore::Settings::setWebAudioEnabled):
page/Settings.h: (WebCore::Settings::webAudioEnabled):

13:33 Changeset [76389] by weinig@apple.com

Fix windows build.

WebScrollBar.h:

13:33 Changeset [76388] by mrobinson@webkit.org

2011-01-21 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Menulist text often collides with separator
https://bugs.webkit.org/show_bug.cgi?id=51155

Rebaseline tests that have different affected by the metrics of
the menulist.

platform/gtk/fast/forms/001-expected.checksum:
platform/gtk/fast/forms/001-expected.png:
platform/gtk/fast/forms/001-expected.txt:
platform/gtk/fast/forms/003-expected.checksum:
platform/gtk/fast/forms/003-expected.png:
platform/gtk/fast/forms/003-expected.txt:
platform/gtk/fast/forms/004-expected.checksum:
platform/gtk/fast/forms/004-expected.png:
platform/gtk/fast/forms/004-expected.txt:
platform/gtk/fast/forms/HTMLOptionElement_label01-expected.checksum:
platform/gtk/fast/forms/HTMLOptionElement_label01-expected.png:
platform/gtk/fast/forms/HTMLOptionElement_label01-expected.txt:
platform/gtk/fast/forms/HTMLOptionElement_label02-expected.checksum:
platform/gtk/fast/forms/HTMLOptionElement_label02-expected.png:
platform/gtk/fast/forms/HTMLOptionElement_label02-expected.txt:
platform/gtk/fast/forms/HTMLOptionElement_label03-expected.checksum:
platform/gtk/fast/forms/HTMLOptionElement_label03-expected.png:
platform/gtk/fast/forms/HTMLOptionElement_label03-expected.txt:
platform/gtk/fast/forms/HTMLOptionElement_label04-expected.checksum:
platform/gtk/fast/forms/HTMLOptionElement_label04-expected.png:
platform/gtk/fast/forms/HTMLOptionElement_label04-expected.txt:
platform/gtk/fast/forms/HTMLOptionElement_label06-expected.checksum:
platform/gtk/fast/forms/HTMLOptionElement_label06-expected.png:
platform/gtk/fast/forms/HTMLOptionElement_label06-expected.txt:
platform/gtk/fast/forms/HTMLOptionElement_label07-expected.checksum:
platform/gtk/fast/forms/HTMLOptionElement_label07-expected.png:
platform/gtk/fast/forms/HTMLOptionElement_label07-expected.txt:
platform/gtk/fast/forms/control-clip-overflow-expected.checksum:
platform/gtk/fast/forms/control-clip-overflow-expected.png:
platform/gtk/fast/forms/control-clip-overflow-expected.txt:
platform/gtk/fast/forms/control-restrict-line-height-expected.checksum:
platform/gtk/fast/forms/control-restrict-line-height-expected.png:
platform/gtk/fast/forms/control-restrict-line-height-expected.txt:
platform/gtk/fast/forms/disabled-select-change-index-expected.checksum:
platform/gtk/fast/forms/disabled-select-change-index-expected.png:
platform/gtk/fast/forms/disabled-select-change-index-expected.txt:
platform/gtk/fast/forms/form-element-geometry-expected.checksum:
platform/gtk/fast/forms/form-element-geometry-expected.png:
platform/gtk/fast/forms/form-element-geometry-expected.txt:
platform/gtk/fast/forms/input-file-re-render-expected.checksum: Added.
platform/gtk/fast/forms/input-file-re-render-expected.png: Added.
platform/gtk/fast/forms/menulist-deselect-update-expected.checksum:
platform/gtk/fast/forms/menulist-deselect-update-expected.png:
platform/gtk/fast/forms/menulist-deselect-update-expected.txt:
platform/gtk/fast/forms/menulist-narrow-width-expected.checksum:
platform/gtk/fast/forms/menulist-narrow-width-expected.png:
platform/gtk/fast/forms/menulist-narrow-width-expected.txt:
platform/gtk/fast/forms/menulist-no-overflow-expected.checksum:
platform/gtk/fast/forms/menulist-no-overflow-expected.png:
platform/gtk/fast/forms/menulist-no-overflow-expected.txt:
platform/gtk/fast/forms/menulist-restrict-line-height-expected.checksum:
platform/gtk/fast/forms/menulist-restrict-line-height-expected.png:
platform/gtk/fast/forms/menulist-restrict-line-height-expected.txt:
platform/gtk/fast/forms/menulist-separator-painting-expected.checksum:
platform/gtk/fast/forms/menulist-separator-painting-expected.png:
platform/gtk/fast/forms/menulist-separator-painting-expected.txt:
platform/gtk/fast/forms/menulist-style-color-expected.checksum:
platform/gtk/fast/forms/menulist-style-color-expected.png:
platform/gtk/fast/forms/menulist-style-color-expected.txt:
platform/gtk/fast/forms/menulist-width-change-expected.checksum:
platform/gtk/fast/forms/menulist-width-change-expected.png:
platform/gtk/fast/forms/menulist-width-change-expected.txt:
platform/gtk/fast/forms/option-script-expected.checksum:
platform/gtk/fast/forms/option-script-expected.png:
platform/gtk/fast/forms/option-script-expected.txt:
platform/gtk/fast/forms/option-strip-whitespace-expected.checksum:
platform/gtk/fast/forms/option-strip-whitespace-expected.png:
platform/gtk/fast/forms/option-strip-whitespace-expected.txt:
platform/gtk/fast/forms/option-text-clip-expected.checksum:
platform/gtk/fast/forms/option-text-clip-expected.png:
platform/gtk/fast/forms/option-text-clip-expected.txt:
platform/gtk/fast/forms/select-align-expected.checksum:
platform/gtk/fast/forms/select-align-expected.png:
platform/gtk/fast/forms/select-align-expected.txt:
platform/gtk/fast/forms/select-baseline-expected.checksum:
platform/gtk/fast/forms/select-baseline-expected.png:
platform/gtk/fast/forms/select-baseline-expected.txt:
platform/gtk/fast/forms/select-change-listbox-to-popup-expected.checksum:
platform/gtk/fast/forms/select-change-listbox-to-popup-expected.png:
platform/gtk/fast/forms/select-change-listbox-to-popup-expected.txt:
platform/gtk/fast/forms/select-dirty-parent-pref-widths-expected.checksum:
platform/gtk/fast/forms/select-dirty-parent-pref-widths-expected.png:
platform/gtk/fast/forms/select-dirty-parent-pref-widths-expected.txt:
platform/gtk/fast/forms/select-disabled-appearance-expected.checksum:
platform/gtk/fast/forms/select-disabled-appearance-expected.png:
platform/gtk/fast/forms/select-disabled-appearance-expected.txt:
platform/gtk/fast/forms/select-initial-position-expected.checksum:
platform/gtk/fast/forms/select-initial-position-expected.png:
platform/gtk/fast/forms/select-initial-position-expected.txt:
platform/gtk/fast/forms/select-selected-expected.checksum:
platform/gtk/fast/forms/select-selected-expected.png:
platform/gtk/fast/forms/select-selected-expected.txt:
platform/gtk/fast/forms/select-size-expected.checksum:
platform/gtk/fast/forms/select-size-expected.png:
platform/gtk/fast/forms/select-size-expected.txt:
platform/gtk/fast/forms/select-style-expected.checksum:
platform/gtk/fast/forms/select-style-expected.png:
platform/gtk/fast/forms/select-style-expected.txt:
platform/gtk/fast/forms/select-visual-hebrew-expected.checksum:
platform/gtk/fast/forms/select-visual-hebrew-expected.png:
platform/gtk/fast/forms/select-visual-hebrew-expected.txt:
platform/gtk/fast/forms/select-writing-direction-natural-expected.checksum:
platform/gtk/fast/forms/select-writing-direction-natural-expected.png:
platform/gtk/fast/forms/select-writing-direction-natural-expected.txt:
platform/gtk/fast/forms/stuff-on-my-optgroup-expected.checksum:
platform/gtk/fast/forms/stuff-on-my-optgroup-expected.png:
platform/gtk/fast/forms/stuff-on-my-optgroup-expected.txt:

2011-01-21 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Menulist text often collides with separator
https://bugs.webkit.org/show_bug.cgi?id=51155

Move menulist rendering to RenderThemeGtk and correct padding code
for separators in menulists.

platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::RenderThemeGtk): Initialize new widget members. (WebCore::RenderThemeGtk::getComboBoxSeparatorWidth): Added. (WebCore::RenderThemeGtk::comboBoxArrowSize): Added. (WebCore::getButtonInnerBorder): Added. (WebCore::RenderThemeGtk::getComboBoxPadding): Do this manually instead of using Mozilla code. (WebCore::RenderThemeGtk::paintMenuList): Ditto. (WebCore::setupWidget): Abstracted this part of the setupWidgetAndAddToContainer out to handle child widgets of comboboxes. (WebCore::RenderThemeGtk::setupWidgetAndAddToContainer): Abstracted out setupWidget. (WebCore::RenderThemeGtk::gtkContainer): Added. (WebCore::getGtkComboBoxButton): Added. (WebCore::getGtkComboBoxPieces): Added. (WebCore::RenderThemeGtk::gtkComboBox): Call setupWidget here. (WebCore::RenderThemeGtk::refreshComboBoxChildren): Added. (WebCore::RenderThemeGtk::gtkComboBoxButton): Added. (WebCore::RenderThemeGtk::gtkComboBoxArrow): Added. (WebCore::RenderThemeGtk::gtkComboBoxSeparator): Added.
platform/gtk/RenderThemeGtk.h: Added new members and methods.
platform/gtk/WidgetRenderingContext.h: Added new members and methods.
platform/gtk/WidgetRenderingContextGtk2.cpp: (WebCore::WidgetRenderingContext::gtkPaintArrow): (WebCore::WidgetRenderingContext::gtkPaintVLine):
platform/gtk/WidgetRenderingContextGtk3.cpp: (WebCore::WidgetRenderingContext::gtkPaintArrow): (WebCore::WidgetRenderingContext::gtkPaintVLine):
platform/gtk/gtk2drawing.c: Removed code for drawing menulists and buttons. (moz_gtk_init): (moz_gtk_get_widget_border): (moz_gtk_widget_paint):
platform/gtk/gtk3drawing.c: (moz_gtk_init): (moz_gtk_get_widget_border): (moz_gtk_widget_paint):
platform/gtk/gtkdrawing.h:

13:17 Changeset [76387] by weinig@apple.com

Fix chromium mac build.

platform/chromium/ScrollbarThemeChromiumMac.mm:

(WebCore::scrollbarStateToThemeState):
(WebCore::ScrollbarThemeChromiumMac::paint):

13:10 Changeset [76386] by ossy@webkit.org

Unreviewed trivial fix.

FrameLoader::checkLoadCompleteForThisFrame uses wrong history item
https://bugs.webkit.org/show_bug.cgi?id=48812

platform/qt/http/tests/navigation/forward-and-cancel-expected.txt: Updated after r76357.

13:08 Changeset [76385] by weinig@apple.com

Fix the windows build.

platform/ScrollbarThemeComposite.cpp:

(WebCore::ScrollbarThemeComposite::paint):

13:02 Changeset [76384] by jberlin@webkit.org

Skip transitions/transition-end-event-destroy-iframe.html on Windows in order to get the
Windows 7 Release bots green. Unreviewed.
https://bugs.webkit.org/show_bug.cgi?id=52913

platform/win/Skipped:

12:54 Changeset [76383] by rniwa@webkit.org

2011-01-21 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed; another Chromium build fix attempt for r76378.

src/WebScrollbarImpl.cpp: (WebKit::WebScrollbar::create): (WebKit::WebScrollbarImpl::WebScrollbarImpl): (WebKit::WebScrollbarImpl::setValue):

12:42 Changeset [76382] by rniwa@webkit.org

2011-01-21 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed Chromium build fix attempt for r76378.

src/WebScrollbarImpl.cpp: (WebKit::WebScrollbar::create): (WebKit::WebScrollbarImpl::WebScrollbarImpl):

12:34 Changeset [76381] by mjs@apple.com

2011-01-21 Maciej Stachowiak <mjs@apple.com>

Reviewed by Sam Weinig.

Skip another test that is failing sporadically on the buildbots
https://bugs.webkit.org/show_bug.cgi?id=52908

platform/mac-wk2/Skipped:

12:29 Changeset [76380] by crogers@google.com

2011-01-21 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

Add chromium bundled audio spatialization resources to WebAudio.grd
https://bugs.webkit.org/show_bug.cgi?id=52651

WebKit.grd:

2011-01-21 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

Add chromium bundled audio spatialization resources to WebAudio.grd
https://bugs.webkit.org/show_bug.cgi?id=52651

No new tests since audio API is not yet implemented.

WebCore.gyp/WebCore.gyp:
platform/audio/chromium/AudioBusChromium.cpp: (WebCore::AudioBus::loadPlatformResource):

12:26 Changeset [76379] by commit-queue@webkit.org

2011-01-21 Xiyuan Xia <xiyuan@chromium.org>

Reviewed by Tony Chang.

Update chromium/linux baselines after drawing code moved into
WebThemeEngine.
https://bugs.webkit.org/show_bug.cgi?id=52826

platform/chromium-linux/css1/box_properties/acid_test-expected.checksum:
platform/chromium-linux/css1/box_properties/acid_test-expected.png:
platform/chromium-linux/css2.1/t09-c5526c-display-00-e-expected.checksum:
platform/chromium-linux/css2.1/t09-c5526c-display-00-e-expected.png:
platform/chromium-linux/fast/block/basic/011-expected.checksum:
platform/chromium-linux/fast/block/basic/011-expected.png:
platform/chromium-linux/fast/block/margin-collapse/103-expected.checksum:
platform/chromium-linux/fast/block/margin-collapse/103-expected.png:
platform/chromium-linux/fast/css/non-standard-checkbox-size-expected.checksum:
platform/chromium-linux/fast/css/non-standard-checkbox-size-expected.png:
platform/chromium-linux/fast/dom/HTMLProgressElement/progress-element-expected.checksum:
platform/chromium-linux/fast/dom/HTMLProgressElement/progress-element-expected.png:
platform/chromium-linux/fast/forms/basic-inputs-expected.checksum:
platform/chromium-linux/fast/forms/basic-inputs-expected.png:
platform/chromium-linux/fast/forms/basic-selects-expected.checksum:
platform/chromium-linux/fast/forms/basic-selects-expected.png:
platform/chromium-linux/fast/forms/box-shadow-override-expected.checksum:
platform/chromium-linux/fast/forms/box-shadow-override-expected.png:
platform/chromium-linux/fast/forms/checkbox-radio-onchange-expected.checksum:
platform/chromium-linux/fast/forms/checkbox-radio-onchange-expected.png:
platform/chromium-linux/fast/forms/file-input-disabled-expected.checksum:
platform/chromium-linux/fast/forms/file-input-disabled-expected.png:
platform/chromium-linux/fast/forms/form-element-geometry-expected.checksum:
platform/chromium-linux/fast/forms/form-element-geometry-expected.png:
platform/chromium-linux/fast/forms/formmove-expected.checksum:
platform/chromium-linux/fast/forms/formmove-expected.png:
platform/chromium-linux/fast/forms/formmove2-expected.checksum:
platform/chromium-linux/fast/forms/formmove2-expected.png:
platform/chromium-linux/fast/forms/indeterminate-expected.checksum:
platform/chromium-linux/fast/forms/indeterminate-expected.png:
platform/chromium-linux/fast/forms/input-appearance-height-expected.checksum:
platform/chromium-linux/fast/forms/input-appearance-height-expected.png:
platform/chromium-linux/fast/forms/input-value-expected.checksum:
platform/chromium-linux/fast/forms/input-value-expected.png:
platform/chromium-linux/fast/forms/menulist-restrict-line-height-expected.checksum:
platform/chromium-linux/fast/forms/menulist-restrict-line-height-expected.png:
platform/chromium-linux/fast/forms/menulist-style-color-expected.checksum:
platform/chromium-linux/fast/forms/menulist-style-color-expected.png:
platform/chromium-linux/fast/forms/placeholder-position-expected.checksum:
platform/chromium-linux/fast/forms/placeholder-position-expected.png: Added property svn:mime-type.
platform/chromium-linux/fast/forms/radio-attr-order-expected.checksum:
platform/chromium-linux/fast/forms/radio-attr-order-expected.png:
platform/chromium-linux/fast/forms/radio-nested-labels-expected.checksum:
platform/chromium-linux/fast/forms/radio-nested-labels-expected.png:
platform/chromium-linux/fast/forms/radio_checked-expected.checksum:
platform/chromium-linux/fast/forms/radio_checked-expected.png:
platform/chromium-linux/fast/forms/radio_checked_dynamic-expected.checksum:
platform/chromium-linux/fast/forms/radio_checked_dynamic-expected.png:
platform/chromium-linux/fast/forms/select-baseline-expected.checksum:
platform/chromium-linux/fast/forms/select-baseline-expected.png:
platform/chromium-linux/fast/inline/positionedLifetime-expected.checksum:
platform/chromium-linux/fast/inline/positionedLifetime-expected.png:
platform/chromium-linux/fast/parser/bad-xml-slash-expected.checksum:
platform/chromium-linux/fast/parser/bad-xml-slash-expected.png:
platform/chromium-linux/fast/replaced/replaced-breaking-expected.checksum:
platform/chromium-linux/fast/replaced/replaced-breaking-expected.png:
platform/chromium-linux/fast/replaced/width100percent-checkbox-expected.checksum:
platform/chromium-linux/fast/replaced/width100percent-checkbox-expected.png:
platform/chromium-linux/fast/text/textIteratorNilRenderer-expected.checksum:
platform/chromium-linux/fast/text/textIteratorNilRenderer-expected.png:
platform/chromium-linux/fast/text/whitespace/normal-after-nowrap-breaking-expected.checksum:
platform/chromium-linux/fast/text/whitespace/normal-after-nowrap-breaking-expected.png:
platform/chromium-linux/tables/mozilla/bugs/bug1318-expected.checksum:
platform/chromium-linux/tables/mozilla/bugs/bug1318-expected.png:
platform/chromium-linux/tables/mozilla/bugs/bug4527-expected.checksum:
platform/chromium-linux/tables/mozilla/bugs/bug4527-expected.png: Added property svn:mime-type.
platform/chromium-linux/tables/mozilla_expected_failures/core/captions1-expected.checksum:
platform/chromium-linux/tables/mozilla_expected_failures/core/captions1-expected.png:
platform/chromium-linux/tables/mozilla_expected_failures/core/captions2-expected.checksum:
platform/chromium-linux/tables/mozilla_expected_failures/core/captions2-expected.png:

2011-01-21 Xiyuan Xia <xiyuan@chromium.org>

Reviewed by Tony Chang.

Use WebThemeEngine for relevant RenderTheme parts for chromium/linux.
https://bugs.webkit.org/show_bug.cgi?id=52826

platform/chromium/ChromiumBridge.h:
rendering/RenderThemeChromiumLinux.cpp: (WebCore::getWebThemeState): (WebCore::RenderThemeChromiumLinux::adjustSliderThumbSize): (WebCore::RenderThemeChromiumLinux::paintCheckbox): (WebCore::RenderThemeChromiumLinux::setCheckboxSize): (WebCore::RenderThemeChromiumLinux::paintRadio): (WebCore::RenderThemeChromiumLinux::setRadioSize): (WebCore::RenderThemeChromiumLinux::paintButton): (WebCore::RenderThemeChromiumLinux::paintTextField): (WebCore::RenderThemeChromiumLinux::paintMenuList): (WebCore::RenderThemeChromiumLinux::paintSliderTrack): (WebCore::RenderThemeChromiumLinux::paintSliderThumb): (WebCore::RenderThemeChromiumLinux::adjustInnerSpinButtonStyle): (WebCore::RenderThemeChromiumLinux::paintInnerSpinButton): (WebCore::RenderThemeChromiumLinux::paintProgressBar):
rendering/RenderThemeChromiumLinux.h:
rendering/RenderThemeChromiumSkia.cpp: (WebCore::RenderThemeChromiumSkia::setCheckboxSize): (WebCore::RenderThemeChromiumSkia::setSizeIfAuto): (WebCore::RenderThemeChromiumSkia::indeterminateProgressValueRectFor):
rendering/RenderThemeChromiumSkia.h:

2011-01-21 Xiyuan Xia <xiyuan@chromium.org>

Reviewed by Tony Chang.

Use WebThemeEngine for relevant RenderTheme parts for chromium/linux.
https://bugs.webkit.org/show_bug.cgi?id=52826

WebKit.gyp:
src/ChromiumBridge.cpp: (WebCore::WebThemePart): (WebCore::GetWebThemeExtraParams):

12:15 Changeset [76378] by weinig@apple.com

Part 2 of "Cleanup Scrollbar/ScrollbarClient relationship"
https://bugs.webkit.org/show_bug.cgi?id=52779

Reviewed by Anders Carlsson.

Rename ScrollbarClient -> ScrollableArea.

Source/WebCore:

Also replaces Scrollbar::setClient with Scrollbar::disconnectFromScrollableArea since that was its only use case.

CMakeLists.txt:
GNUmakefile.am:
WebCore.gypi:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
accessibility/AccessibilityScrollbar.cpp:

(WebCore::AccessibilityScrollbar::setValue):

css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):

page/FrameView.h:
platform/PopupMenuClient.h:
platform/ScrollAnimator.cpp:

(WebCore::ScrollAnimator::create):
(WebCore::ScrollAnimator::ScrollAnimator):
(WebCore::ScrollAnimator::scroll):
(WebCore::ScrollAnimator::notityPositionChanged):

platform/ScrollAnimator.h:
platform/ScrollAnimatorWin.cpp:

(WebCore::ScrollAnimator::create):
(WebCore::ScrollAnimatorWin::ScrollAnimatorWin):
(WebCore::ScrollAnimatorWin::scroll):

platform/ScrollAnimatorWin.h:
platform/ScrollView.cpp:

(WebCore::ScrollView::scroll):
(WebCore::ScrollView::updateScrollbars):
(WebCore::ScrollView::wheelEvent):

platform/ScrollView.h:
platform/ScrollableArea.cpp: Copied from WebCore/platform/ScrollbarClient.cpp.

(WebCore::ScrollableArea::ScrollableArea):
(WebCore::ScrollableArea::~ScrollableArea):
(WebCore::ScrollableArea::scroll):
(WebCore::ScrollableArea::scrollToOffsetWithoutAnimation):
(WebCore::ScrollableArea::scrollToXOffsetWithoutAnimation):
(WebCore::ScrollableArea::scrollToYOffsetWithoutAnimation):
(WebCore::ScrollableArea::setScrollOffsetFromAnimation):

platform/ScrollableArea.h: Copied from WebCore/platform/ScrollbarClient.h.
platform/Scrollbar.cpp:

(WebCore::Scrollbar::createNativeScrollbar):
(WebCore::Scrollbar::Scrollbar):
(WebCore::Scrollbar::offsetDidChange):
(WebCore::Scrollbar::autoscrollPressedPart):
(WebCore::Scrollbar::moveThumb):
(WebCore::Scrollbar::mouseMoved):
(WebCore::Scrollbar::isWindowActive):
(WebCore::Scrollbar::invalidateRect):
(WebCore::Scrollbar::convertToContainingView):
(WebCore::Scrollbar::convertFromContainingView):

platform/Scrollbar.h:

(WebCore::Scrollbar::disconnectFromScrollableArea):
(WebCore::Scrollbar::scrollableArea):

platform/ScrollbarClient.cpp: Removed.
platform/ScrollbarClient.h: Removed.
platform/ScrollbarThemeComposite.cpp:
platform/chromium/FramelessScrollView.h:
platform/chromium/ScrollbarThemeChromium.cpp:

(WebCore::ScrollbarThemeChromium::paintTickmarks):

platform/efl/ScrollbarEfl.cpp:

(Scrollbar::createNativeScrollbar):
(ScrollbarEfl::ScrollbarEfl):
(scrollbarEflEdjeMessage):

platform/efl/ScrollbarEfl.h:
platform/gtk/MainFrameScrollbarGtk.cpp:

(MainFrameScrollbarGtk::create):
(MainFrameScrollbarGtk::MainFrameScrollbarGtk):
(MainFrameScrollbarGtk::gtkValueChanged):

platform/gtk/MainFrameScrollbarGtk.h:
platform/mac/ScrollAnimatorMac.h:
platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimator::create):
(WebCore::ScrollAnimatorMac::ScrollAnimatorMac):
(WebCore::ScrollAnimatorMac::scroll):

platform/mac/ScrollbarThemeMac.mm:

(WebCore::ScrollbarThemeMac::paint):

platform/qt/ScrollbarQt.cpp:

(WebCore::Scrollbar::contextMenu):

platform/win/PopupMenuWin.cpp:

(WebCore::PopupMenuWin::scrollToRevealSelection):
(WebCore::PopupMenuWin::wndProc):

platform/win/PopupMenuWin.h:
platform/win/ScrollbarThemeSafari.cpp:

(WebCore::ScrollbarThemeSafari::paintTrackBackground):
(WebCore::ScrollbarThemeSafari::paintButton):
(WebCore::ScrollbarThemeSafari::paintThumb):

platform/wx/ScrollbarThemeWx.cpp:

(WebCore::ScrollbarThemeWx::paint):

rendering/RenderDataGrid.h:
rendering/RenderLayer.cpp:

(WebCore::RenderLayer::scrollToOffset):
(WebCore::RenderLayer::destroyScrollbar):
(WebCore::RenderLayer::scroll):

rendering/RenderLayer.h:
rendering/RenderListBox.cpp:

(WebCore::RenderListBox::scrollToRevealElementAtListIndex):
(WebCore::RenderListBox::scroll):
(WebCore::RenderListBox::logicalScroll):
(WebCore::RenderListBox::setScrollTop):
(WebCore::RenderListBox::destroyScrollbar):

rendering/RenderListBox.h:
rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::createScrollbar):

rendering/RenderMenuList.h:
rendering/RenderScrollbar.cpp:

(WebCore::RenderScrollbar::createCustomScrollbar):
(WebCore::RenderScrollbar::RenderScrollbar):

rendering/RenderScrollbar.h:
rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::createScrollbar):

rendering/RenderTextControlSingleLine.h:

Source/WebKit/chromium:

src/AutoFillPopupMenuClient.cpp:

(WebKit::AutoFillPopupMenuClient::createScrollbar):

src/AutoFillPopupMenuClient.h:
src/WebScrollbarImpl.cpp:

(WebKit::WebScrollbarImpl::WebScrollbarImpl):
(WebKit::WebScrollbarImpl::scroll):
(WebKit::WebScrollbarImpl::onMouseWheel):
(WebKit::WebScrollbarImpl::onKeyDown):

src/WebScrollbarImpl.h:
tests/PopupMenuTest.cpp:

(WebKit::TestPopupMenuClient::createScrollbar):

Source/WebKit/qt:

Api/qwebframe.cpp:

(QWebFrame::setScrollBarValue):

Source/WebKit/win:

WebScrollBar.cpp:

(WebScrollBar::scroll):

WebScrollBar.h:

Source/WebKit2:

UIProcess/win/WebPopupMenuProxyWin.cpp:

(WebKit::WebPopupMenuProxyWin::onMouseWheel):
(WebKit::WebPopupMenuProxyWin::scrollToRevealSelection):

UIProcess/win/WebPopupMenuProxyWin.h:

12:13 Changeset [76377] by commit-queue@webkit.org

2011-01-21 Sailesh Agrawal <sail@chromium.org>

Reviewed by Ryosuke Niwa.

[chromium] Notify WebFrameClient when spellcheck state changes
https://bugs.webkit.org/show_bug.cgi?id=52680

public/WebFrameClient.h: (WebKit::WebFrameClient::continuousSpellCheckingEnabledStateChanged):
src/EditorClientImpl.cpp: (WebKit::EditorClientImpl::toggleContinuousSpellChecking):
src/WebFrameImpl.cpp:

12:01 Changeset [76376] by commit-queue@webkit.org

2011-01-21 Peter Gal <galpeter@inf.u-szeged.hu>

Reviewed by Darin Adler.

REGRESSION(r76177): All JavaScriptCore tests fail on ARM
https://bugs.webkit.org/show_bug.cgi?id=52814

Get the approximateByteSize value before releasing the OwnPtr.

parser/JSParser.cpp: (JSC::JSParser::parseFunctionInfo):

11:51 Changeset [76375] by darin@apple.com

Fix Leopard build.

rendering/mathml/RenderMathMLFraction.cpp:

(WebCore::RenderMathMLFraction::layout): Use ceilf instead of ceil.

11:44 Changeset [76374] by simon.fraser@apple.com

2011-01-21 Simon Fraser <simon.fraser@apple.com>

Reviewed by Sam Weinig.

GraphicsLayer should be non-copyable
https://bugs.webkit.org/show_bug.cgi?id=52909

Use WTF_MAKE_NONCOPYABLE on GraphicsLayer, and WTF_MAKE_FAST_ALLOCATED
on that and KeyframeValueList.

platform/graphics/GraphicsLayer.h:

11:40 Changeset [76373] by antonm@chromium.org

2011-01-21 Anton Muhin <antonm@chromium.org>

Reviewed by Nate Chapin.

[v8] Properly deal with the case when conversion to string throws an exception for HTMLCollection accessors
https://bugs.webkit.org/show_bug.cgi?id=52901

fast/dom/htmlcollection-conversion-throws-exception-expected.txt: Added.
fast/dom/htmlcollection-conversion-throws-exception.html: Added.

2011-01-21 Anton Muhin <antonm@chromium.org>

Reviewed by Nate Chapin.

[v8] Properly deal with the case when conversion to string throws an exception for HTMLCollection accessors
https://bugs.webkit.org/show_bug.cgi?id=52901

Test: fast/dom/htmlcollection-conversion-throws-exception.html

bindings/v8/custom/V8HTMLCollectionCustom.cpp: (WebCore::getItem):

11:35 Changeset [76372] by aroben@apple.com

Separate flushing layer changes from rendering in CACFLayerTreeHost

Old model:

1) A change is made to a GraphicsLayer.
2) CACFLayerTreeHost::flushPendingGraphicsLayerChangesSoon is called, which schedules the

render timer.

3) The timer fires, which calls through to CACFLayerTreeHost::render, which performs the

flush and then renders.

New model:

1) A change is made to a GraphicsLayer.
2) CACFLayerTreeHost::flushPendingGraphicsLayerChangesSoon is called, which tells the new

LayerChangesFlusher singleton that this host has changes that need to be flushed.

3) LayerChangesFlusher sets up a Windows hook that will get called on the next iteration

of the message loop.

4) LayerChangesFlusher's hook is called, which calls through to

CACFLayerTreeHost::flushPendingLayerChangesNow.

5) CACFLayerTreeHost::flushPendingLayerChangesNow schedules the render timer so the changes

that were just flushed to the context will be rendered.

When a change is made to a PlatformCALayer that doesn't have a corresponding GraphicsLayer
(e.g., for rendering <video>), CACFLayerTreeHost::layerTreeDidChange takes care of
scheduling the flush.

This change has three advantages:

1) Whenever we flush layer changes, we first update layout. This can cause the page to

leave compositing mode, which in turn can cause all references to the CACFLayerTreeHost
to be dropped. By separating flushing (and thus updating layout) from rendering, we no
longer have to worry about this happen during rendering.

2) The new model is much more similar to how things work on the Mac, so will hopefully

reduce the number of platform-specific bugs.

3) CACFLayerTreeHost::shouldRender, which was used to make sure we didn't render while a

layout was pending, is no longer needed. It actually hasn't been needed since at least
r75987, but removing it before now would have resulted in a crash whenever a page came
out of compositing mode due to (1).

Fixes <http://webkit.org/b/52852> Flushing layer changes and rendering are intertwined in
CACFLayerTreeHost, but shouldn't be

Reviewed by Simon Fraser.

Source/WebCore:

WebCore.vcproj/WebCore.vcproj: Added LayerChangesFlusher.

platform/graphics/ca/win/CACFLayerTreeHost.cpp: Added new #include, sorted existing #includes.

(WebCore::CACFLayerTreeHost::CACFLayerTreeHost): Initialize new member.
(WebCore::CACFLayerTreeHost::layerTreeDidChange): If we aren't already flushing changes,
schedule a flush. Removed the call to renderSoon(), which now happens when the flush is
finished.
(WebCore::CACFLayerTreeHost::destroyRenderer): Cancel any pending flush we had scheduled. Also
fixed a bug where we'd fail to clear the context's layer.
(WebCore::CACFLayerTreeHost::render): Removed code to ask the client if we should render, which
is no longer needed. Moved code to flush layer changes from here to
flushPendingLayerChangesNow, which is called via the above-described mechanism.
(WebCore::CACFLayerTreeHost::flushPendingGraphicsLayerChangesSoon): Schedule a flush. Removed
code to schedule a render, which now happens after we've flushed.
(WebCore::CACFLayerTreeHost::flushPendingLayerChangesNow): Added. Some of this code came from
render(). First we flush GraphicsLayer changes from GraphicsLayers to their underlying
PlatformCALayers, then we flush changes from PlatformCALayers to the context, then we
schedule a render so that the changes will be rendered to the screen.

platform/graphics/ca/win/CACFLayerTreeHost.h: Removed

CACFLayerTreeHostClient::shouldRender. Added flushPendingLayerChangesNow and
m_isFlushingLayerChanges.

platform/graphics/ca/win/LayerChangesFlusher.cpp: Added.

(WebCore::LayerChangesFlusher::shared):
(WebCore::LayerChangesFlusher::LayerChangesFlusher):
(WebCore::LayerChangesFlusher::flushPendingLayerChangesSoon):
(WebCore::LayerChangesFlusher::cancelPendingFlush):
(WebCore::LayerChangesFlusher::hookCallback):
(WebCore::LayerChangesFlusher::hookFired):
(WebCore::LayerChangesFlusher::setHook):
(WebCore::LayerChangesFlusher::removeHook):

platform/graphics/ca/win/LayerChangesFlusher.cpp: Added.

(WebCore::LayerChangesFlusher::shared): Returns the singleton.
(WebCore::LayerChangesFlusher::LayerChangesFlusher): Initialize our members.
(WebCore::LayerChangesFlusher::flushPendingLayerChangesSoon): Add the host to the set of
hosts with changes that need to be flushed, and set up our hook if we haven't already.
(WebCore::LayerChangesFlusher::cancelPendingFlush): Remove the host from the set of hosts
with changes that need to be flushed. If we have no more such hosts, remove our hook, unless
we're currently in the process of calling out to our hosts, in which case we'll take care of
the hook once we're done calling out.
(WebCore::LayerChangesFlusher::hookCallback): This is the function that Windows calls when
our hook fires. Just calls through to hookFired on the singleton.
(WebCore::LayerChangesFlusher::hookFired): Tell all the hosts with changes that needed to be
flushed that it's time to flush. If no hosts re-added themselves to our set during this
process, remove our hook.
(WebCore::LayerChangesFlusher::setHook): Calls through to ::SetWindowsHookExW.
(WebCore::LayerChangesFlusher::removeHook): Calls through to ::UnhookWindowsHookEx.

platform/graphics/ca/win/LayerChangesFlusher.h: Added.

Source/WebKit/win:

Update for CACFLayerTreeHost changes

WebView.cpp:

(WebView::paint): Changed to flush layer changes via CACFLayerTreeHost, which will call back
to our own flushing function if needed.

WebView.h: Removed shouldRender, which is no longer used or needed.

11:33 Changeset [76371] by simon.fraser@apple.com

2011-01-21 Simon Fraser <simon.fraser@apple.com>

Reviewed by Sam Weinig.

Report the sized used by canvases and types arrays
https://bugs.webkit.org/show_bug.cgi?id=52856

Report the memory cost associated with canvas elements,
and typed arrays to JavaScript as extraCost, so that it
can figure this into its GC behavior.

bindings/js/JSArrayBufferViewHelper.h: (WebCore::toJSArrayBufferView): New templatized function, similar to getDOMObjectWrapper() but calls reportExtraMemoryCost() with the byteLength of the array.

bindings/js/JSFloat32ArrayCustom.cpp: (WebCore::toJS): Use toJSArrayBufferView.
bindings/js/JSInt16ArrayCustom.cpp: (WebCore::toJS): Use toJSArrayBufferView.
bindings/js/JSInt32ArrayCustom.cpp: (WebCore::toJS): Use toJSArrayBufferView.
bindings/js/JSInt8ArrayCustom.cpp: (WebCore::toJS): Use toJSArrayBufferView.
bindings/js/JSUint16ArrayCustom.cpp: (WebCore::toJS): Use toJSArrayBufferView.
bindings/js/JSUint32ArrayCustom.cpp: (WebCore::toJS): Use toJSArrayBufferView.
bindings/js/JSUint8ArrayCustom.cpp: (WebCore::toJS): Use toJSArrayBufferView.

html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::createImageBuffer): Call heap.reportExtraMemoryCost() with the size of the canvas backing store.

html/canvas/TypedArrayBase.h: (WebCore::TypedArrayBase::byteLength): byteLength needs to be public.

platform/graphics/ImageBuffer.h: Add dataSize() method.

platform/graphics/cairo/ImageBufferCairo.cpp: (WebCore::ImageBuffer::dataSize): Implement dataSize().
platform/graphics/cg/ImageBufferCG.cpp: (WebCore::ImageBuffer::dataSize): Implement dataSize().
platform/graphics/haiku/ImageBufferHaiku.cpp: (WebCore::ImageBuffer::dataSize): Implement dataSize().
platform/graphics/qt/ImageBufferQt.cpp: (WebCore::ImageBuffer::dataSize): Implement dataSize().
platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::ImageBuffer::dataSize): Implement dataSize().
platform/graphics/wince/ImageBufferWinCE.cpp: (WebCore::ImageBuffer::dataSize): Implement dataSize().
platform/graphics/wx/ImageBufferWx.cpp: (WebCore::ImageBuffer::dataSize): Implement dataSize().

11:32 Changeset [76370] by aroben@apple.com

Rename WKCACFLayerRenderer[Client] to CACFLayerTreeHost[Client]

Also renamed a few functions and data members to match.

Fixes <http://webkit.org/b/52898> WKCACFLayerRenderer sounds like a render object, but isn't

Reviewed by Simon Fraser.

Source/WebCore:

WebCore.vcproj/WebCore.vcproj: Updated files' names and paths.

WebCore.vcproj/WebCoreQuartzCore.vsprops: Added platform/graphics/ca/win to the include

path.

WebCore.vcproj/copyForwardingHeaders.cmd: Copy headers from platform/graphics/ca/win, too.

platform/graphics/ca/win/CACFLayerTreeHost.cpp: Renamed from Source/WebCore/platform/graphics/win/WKCACFLayerRenderer.cpp.
platform/graphics/ca/win/CACFLayerTreeHost.h: Renamed from Source/WebCore/platform/graphics/win/WKCACFLayerRenderer.h.

platform/graphics/ca/win/PlatformCALayerWin.cpp:
platform/graphics/win/MediaPlayerPrivateFullscreenWindow.cpp:
platform/graphics/win/MediaPlayerPrivateFullscreenWindow.h:

Updated for renames.

Source/WebKit/win:

Update for WKCACFLayerRenderer -> CACFLayerTreeHost rename

Also renamed WebView::m_layerRenderer to WebView::m_layerTreeHost to match.

WebPreferences.cpp:
WebView.cpp:

(WebView::setAcceleratedCompositing): Also made sure to remove our HWND from the layer tree
host before we get rid of the layer tree host itself.

WebView.h:

Source/WebKit2:

Update for WKCACFLayerRenderer -> CACFLayerView rename

WebProcess/WebPage/win/LayerBackedDrawingAreaWin.cpp: Just removed all the unnecessary #includes.

11:32 Changeset [76369] by xan@webkit.org

2011-01-21 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

Remove unnecessary <stdio.h> include
https://bugs.webkit.org/show_bug.cgi?id=52884

jit/JIT.cpp: remove unnecessary include.

11:27 Changeset [76368] by commit-queue@webkit.org

2011-01-21 Patrick Gansterer <paroga@paroga.com>

Original patch from François Sausset <sausset@gmail.com>

Reviewed by Darin Adler.

Code cleaning in rendering/mathml/RenderMathMLFraction.cpp
https://bugs.webkit.org/show_bug.cgi?id=52201

Replace unneeded doubles by floats and remove unneeded casts.

rendering/mathml/RenderMathMLFraction.cpp: (WebCore::RenderMathMLFraction::paint):
rendering/mathml/RenderMathMLFraction.h:

11:20 Changeset [76367] by levin@chromium.org

Proposal: Require cross-organizational seconds for reviewer nominations
https://bugs.webkit.org/show_bug.cgi?id=47597

Reviewed by Darin Adler.

This changes the committer/reviewer policy to require an additional
reviewer supporting a reviewer nomination to work for a different
company and different project affiliation from the nominee.

This means reviewer nominations would require four supporting reviewers,
one of which knows the reviewer through the community (irc, email, bugs)
ensuring that the nominee has the open-source collaboration skills
we so highly value here in WebKit.

coding/commit-review-policy.html:

11:20 Changeset [76366] by dglazkov@chromium.org

2011-01-21 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Darin Adler.

REGRESSION(r73618): Clicking on a search input causes a crash.
https://bugs.webkit.org/show_bug.cgi?id=52905

fast/dom/search-shadow-host-crash-expected.txt: Added.
fast/dom/search-shadow-host-crash.html: Added.

2011-01-21 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Darin Adler.

REGRESSION(r73618): Clicking on a search input causes a crash.
https://bugs.webkit.org/show_bug.cgi?id=52905

The problem is caused by TextControlInnerElement being used both as
shadow root and an element in a shadow subtree. The code assumed it is
only used as a shadow root.

Since this code is all just workaround for in-progress conversion to
new shadow DOM, I am just adding a check. This code will disappear
completely once bug 52788 is fixed.

Test: fast/dom/search-shadow-host-crash.html

dom/Node.cpp: (WebCore::Node::setShadowHost): Added an ASSERT for early detection

of attempting to stomp on the parentNode.

rendering/TextControlInnerElements.cpp: (WebCore::TextControlInnerElement::detach): Added a check to only

clear shadow host if we have one.

11:05 Changeset [76365] by dglazkov@chromium.org

2011-01-21 Dimitri Glazkov <dglazkov@chromium.org>

Updated slider expectations after r76147.

platform/chromium/test_expectations.txt: Removed test that will start passing.
platform/chromium-win/fast/forms/slider-mouse-events-expected.txt: Updated expectation.

11:00 Changeset [76364] by xji@chromium.org

2011-01-21 Xiaomei Ji <xji@chromium.org>

Unreviewed.

Rebaseline for leopard after r76319.

platform/mac-leopard/fast/dom/52776-expected.txt: Added.

10:50 Changeset [76363] by tony@chromium.org

2011-01-21 Tony Chang <tony@chromium.org>

Unreviewed, updating chromium DEPS so we can pull in linux theme changes.

DEPS:

10:44 Changeset [76362] by darin@apple.com

Fix Mac build.

MiniBrowser/mac/BrowserWindowController.m:

(-[BrowserWindowController awakeFromNib]): Pass 0 for runModal function.

10:41 Changeset [76361] by darin@apple.com

WebKit2: Implement showModalDialog
https://bugs.webkit.org/show_bug.cgi?id=52855

Reviewed by Dan Bernstein.

Source/WebKit2:

Shared/WebPageCreationParameters.h: Added canRunModal.

UIProcess/API/C/WKPage.h: Added a runModal function pointer to

WKPageUIClient. Also removed a lot of redundant typedefs and added
a new one, WKPageCallback, for callbacks without arguments or return
values.

UIProcess/API/qt/qwkpage.cpp:

(QWKPage::QWKPage): Added a runModal function pointer of 0.

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::creationParameters): Set canRunModal
based on return value of WebUIClient::canRunModal.

UIProcess/WebPageProxy.h: Added runModal.

Calls WebUIClient::runModal.

UIProcess/WebPageProxy.messages.in: Added RunModal message.

Also removed the periods from the phrases in the comments
as Maciej requested a while back.

UIProcess/WebUIClient.cpp:

(WebKit::WebUIClient::canRunModal): Added. Returns true or false
based on whether a runModal function was supplied in the
WKPageUIClient structure.
(WebKit::WebUIClient::runModal): Added. Calls the runModal
function from the WKPageUIClient structure.

UIProcess/WebUIClient.h: Declared the above functions.

WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::canRunModal): Call through to WebPage.
(WebKit::WebChromeClient::runModal): Ditto.

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage): Initialize m_canRunModal based on the
creation parameters. Initialize m_isRunningModal to false.
(WebKit::WebPage::close): Stop the nested run loop if we are running modal.
(WebKit::WebPage::runModal): Send a message to ask the UI process to run
modal and then start a nested run loop. It gets stopped when the page is closed.

WebProcess/WebPage/WebPage.h: Defined the canRunModal function

and declared the runModal function.

Tools:

This fixes WebKitTestRunner to compile, but more work is probably
needed to get it to pass the tests.

WebKitTestRunner/TestController.cpp:

(WTR::TestController::runModal): Added. Calls through to the
platform-specific version of runModal.
(WTR::TestController::createOtherPage): Changed to be a private
static member function so it can refer to runModal, which is
a private static member function.
(WTR::TestController::initialize): Pass 0 for the runModal
function since we don't need to run the main window modal.
I suspect this is wrong and will need to change.

WebKitTestRunner/TestController.h: Added declarations for

the functions added above.

WebKitTestRunner/mac/TestControllerMac.mm:

(WTR::TestController::runModal): Added. Untested implementation.

WebKitTestRunner/qt/TestControllerQt.cpp:

(WTR::TestController::runModal): Added.

WebKitTestRunner/win/TestControllerWin.cpp:

(WTR::TestController::runModal): Added.

10:41 Changeset [76360] by commit-queue@webkit.org

2011-01-21 Kenji Imasaki <imasaki@chromium.org>

Reviewed by David Levin.

remove non-flaky tests from test expectation file
https://bugs.webkit.org/show_bug.cgi?id=52746

platform/chromium/test_expectations.txt:

10:31 Changeset [76359] by aroben@apple.com

Replace some "sync compositing state" terminology with "flush pending GraphicsLayer changes"

This seems to be the direction in which our code is moving. I chose "GraphicsLayer" as
opposed to just "layer" because there are cases where we flush changes to CACFLayers that
don't have a corresponding GraphicsLayer.

Fixes <http://webkit.org/b/52894> "Sync compositing state" terminology in
WKCACFLayerRenderer and friends is confusing

Reviewed by Simon Fraser.

Source/WebCore:

platform/graphics/win/WKCACFLayerRenderer.cpp:

(WebCore::WKCACFLayerRenderer::WKCACFLayerRenderer):
(WebCore::WKCACFLayerRenderer::render):
Updated for renames.

(WebCore::WKCACFLayerRenderer::flushPendingGraphicsLayerChangesSoon): Renamed from
syncCompositingStateSoon, and updated for other renames.

platform/graphics/win/WKCACFLayerRenderer.h: Renamed m_syncLayerChanges to
m_shouldFlushPendingGraphicsLayerChanges.

(WebCore::WKCACFLayerRendererClient::flushPendingGraphicsLayerChanges): Renamed from
syncCompositingState.

Source/WebKit/win:

WebCoreSupport/WebChromeClient.cpp:

(WebChromeClient::scheduleCompositingLayerSync): Updated for WebView changes.

WebView.cpp:

(WebView::paint): Updated for rename.
(WebView::flushPendingGraphicsLayerChangesSoon): Renamed from scheduleCompositingLayerSync.
(WebView::notifySyncRequired): Updated for rename.
(WebView::flushPendingGraphicsLayerChanges): Renamed from syncCompositingState.

WebView.h: Did the renames.

10:31 Changeset [76358] by aroben@apple.com

Clean up PlatformCAAnimationWin

Fixes <http://webkit.org/b/52904> PlatformCAAnimationWin is leaky and inefficient

Reviewed by Simon Fraser.

platform/graphics/ca/win/PlatformCAAnimationWin.cpp:

(toCACFFillModeType):
(fromCACFFillModeType):
(toCACFValueFunctionType):
(fromCACFValueFunctionType):
Changed to take and return CFStringRefs. There's no need to convert to WebCore::String just
so we can later convert back to CFStringRef.

(toCACFTimingFunction): Fixed leaks by changing this to return a RetainPtr and adopting the
results of CACFTimingFunctionCreate.
(PlatformCAAnimation::PlatformCAAnimation): Changed not to needlessly roundtrip through
WebCore::String. Also changed an ASSERT(0) to ASSERT_NOT_REACHED().

(PlatformCAAnimation::setFillMode):
(PlatformCAAnimation::setTimingFunction):
(PlatformCAAnimation::setValueFunction):
(PlatformCAAnimation::setTimingFunctions):
Updated for changes to the above conversion functions.

10:26 Changeset [76357] by commit-queue@webkit.org

2011-01-21 Charlie Reis <creis@chromium.org>

Reviewed by Darin Fisher.

FrameLoader::checkLoadCompleteForThisFrame uses wrong history item
https://bugs.webkit.org/show_bug.cgi?id=48812

Test that we avoid updating back/forward list on a canceled navigation
if a new navigation is already in process. Also update forward-and-cancel
to go forward, ensuring back/forward state is reset if user clicks stop.

http/tests/navigation/back-twice-without-commit-expected.txt: Added.
http/tests/navigation/back-twice-without-commit.html: Added.
http/tests/navigation/forward-and-cancel-expected.txt:
http/tests/navigation/forward-and-cancel.html: Go forward after stop, not back.
http/tests/navigation/resources/back-twice-page-2.html: Added.
http/tests/navigation/resources/back-twice-page-3.html: Added.
http/tests/navigation/resources/forward-and-cancel-frames.html: Reduced delay.

2011-01-21 Charlie Reis <creis@chromium.org>

Reviewed by Darin Fisher.

FrameLoader::checkLoadCompleteForThisFrame uses wrong history item
https://bugs.webkit.org/show_bug.cgi?id=48812

Most calls to stopAllLoaders now clear the history's provisional item(s).
We can now avoid resetting the back/forward state if a new navigation
is in progress.

Test: http/tests/navigation/back-twice-without-commit.html
Test: http/tests/navigation/forward-and-cancel.html

loader/FrameLoader.cpp:
loader/FrameLoader.h:
loader/FrameLoaderTypes.h:
WebCore.exp.in: Update stopAllLoaders signature.

10:09 Changeset [76356] by mihaip@chromium.org

2011-01-20 Mihai Parparita <mihaip@chromium.org>

Reviewed by Eric Seidel.

[Chromium] Update expectations for compositing/geometry/limit-layer-bounds-overflow-repaint.html
https://bugs.webkit.org/show_bug.cgi?id=52860

The test hasn't had a timeout in a while, remove that expectation so
that we can more easily see if this re-occurs.

Also rebaseline for chromium-gpu-mac (it has the green as 0,128,0, just
like chromium-gpu-win and -linux, for some reason the mac expectation
has it as 17,128,4).

platform/chromium-gpu-win/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.checksum: Removed.
platform/chromium-gpu-win/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.png: Removed.
platform/chromium-gpu/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.checksum: Renamed from LayoutTests/platform/chromium-gpu-linux/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.checksum.
platform/chromium-gpu/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.png: Renamed from LayoutTests/platform/chromium-gpu-linux/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.png.
platform/chromium-gpu/test_expectations.txt:

09:51 Changeset [76355] by rniwa@webkit.org

2011-01-21 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed; Reverted the last change to the text expectation.

platform/chromium/test_expectations.txt:

09:39 Changeset [76354] by rniwa@webkit.org

2011-01-21 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed Chromium test expectation update.

platform/chromium/test_expectations.txt:

09:33 Changeset [76353] by rniwa@webkit.org

2011-01-21 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed Chromium rebaselines for 76319.

platform/chromium-linux/fast/dom/52776-expected.checksum: Added.
platform/chromium-linux/fast/dom/52776-expected.png: Added.
platform/chromium-linux/fast/dom/52776-expected.txt: Added.
platform/chromium-mac/fast/dom/52776-expected.checksum: Added.
platform/chromium-mac/fast/dom/52776-expected.png: Added.
platform/chromium-mac/fast/dom/52776-expected.txt: Added.
platform/chromium-win/fast/dom/52776-expected.checksum: Added.
platform/chromium-win/fast/dom/52776-expected.png: Added.
platform/chromium-win/fast/dom/52776-expected.txt: Added.
platform/chromium/test_expectations.txt:

09:26 Changeset [76352] by tony@chromium.org

2011-01-21 Tony Chang <tony@chromium.org>

Unreviewed, these tests were fixed in r76330. Still one unknown
failure.

platform/chromium/test_expectations.txt:

09:21 Changeset [76351] by carlosgc@webkit.org

2011-01-21 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Show caps lock indicator in password fields
https://bugs.webkit.org/show_bug.cgi?id=52878

Test: manual-tests/password-caps-lock.html

platform/gtk/KeyEventGtk.cpp: (WebCore::PlatformKeyboardEvent::currentCapsLockState): Implement currentCapsLockState() using GDK API.
platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::paintCapsLockIndicator): Paint an icon in the password field when the caps lock modifier is locked.
platform/gtk/RenderThemeGtk.h:

2011-01-21 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Show caps lock indicator in password fields
https://bugs.webkit.org/show_bug.cgi?id=52878

Test: manual-tests/password-caps-lock.html

webkit/webkitwebview.cpp: (webkit_web_view_key_release_event): Call capsLockStateMayHaveChanged() when caps lock key is pressed.

08:36 Changeset [76350] by jberlin@webkit.org

Modify the Windows-specific results after http://trac.webkit.org/changeset/76208 in order to
get the bots green. Unreviewed.
https://bugs.webkit.org/show_bug.cgi?id=52557

platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
platform/win/fast/dom/prototype-inheritance-2-expected.txt:
platform/win/fast/dom/prototype-inheritance-expected.txt:
platform/win/fast/js/global-constructors-expected.txt:

08:22 Changeset [76349] by jberlin@webkit.org

Add Windows-specific results for fast/dom/52776.html to get the bot green. Unreviewed.
https://bugs.webkit.org/show_bug.cgi?id=52776

platform/win/fast/dom/52776-expected.txt: Added.

08:08 Changeset [76348] by podivilov@chromium.org

2011-01-21 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: move sticky breakpoints management from InspectorController to InspectorBrowserDebuggerAgent.
https://bugs.webkit.org/show_bug.cgi?id=52874

This is the first step of debugger api refactoring (see bug 52879).
JavaScript breakpoints are still in the same list as native breakpoints and are restored by InspectorBrowserDebuggerAgent.
The second step will be to move sticky JavaScript breakpoints to InspectorDebuggerAgent.

inspector/Inspector.idl:
inspector/InspectorBrowserDebuggerAgent.cpp: (WebCore::InspectorBrowserDebuggerAgent::setAllBrowserBreakpoints): (WebCore::InspectorBrowserDebuggerAgent::inspectedURLChanged): (WebCore::InspectorBrowserDebuggerAgent::restoreStickyBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::discardBindings): (WebCore::InspectorBrowserDebuggerAgent::didInsertDOMNode): (WebCore::InspectorBrowserDebuggerAgent::didRemoveDOMNode): (WebCore::InspectorBrowserDebuggerAgent::setDOMBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::removeDOMBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::descriptionForDOMEvent): (WebCore::InspectorBrowserDebuggerAgent::hasBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::updateSubtreeBreakpoints):
inspector/InspectorBrowserDebuggerAgent.h:
inspector/InspectorController.cpp: (WebCore::InspectorController::restoreInspectorStateFromCookie): (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::didCommitLoad): (WebCore::InspectorController::enableDebugger): (WebCore::InspectorController::resume): (WebCore::InspectorController::inspectedURL):
inspector/InspectorController.h:
inspector/InspectorState.cpp: (WebCore::InspectorState::InspectorState):
inspector/InspectorState.h:
inspector/front-end/BreakpointManager.js: (WebInspector.BreakpointManager): (WebInspector.BreakpointManager.prototype._saveBreakpoints):

07:51 Changeset [76347] by jknotten@chromium.org

2011-01-21 John Knottenbelt <jknotten@chromium.org>

Reviewed by Jeremy Orlow.

Turn off uninitialized errors for ARM linux build.
https://bugs.webkit.org/show_bug.cgi?id=52893

Fix ARM compiler breakage.

WebCore.gyp/WebCore.gyp:

07:00 Changeset [76346] by mnaganov@chromium.org

2011-01-21 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Add layout test for the CPU profiler.

This test replaces DevToolsSanityTest.TestProfilerTab from
Chromium's interactive_ui_tests.

https://bugs.webkit.org/show_bug.cgi?id=52634

inspector/cpu-profiler-profiling-expected.txt: Added.
inspector/cpu-profiler-profiling.html: Added.

[Relanding, this time the test should work in Chromium]

06:41 Changeset [76345] by mnaganov@chromium.org

2011-01-21 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [Chromium] REGRESSION: Using the "Back" button
while profiling causes renderer crash.

https://bugs.webkit.org/show_bug.cgi?id=52808

inspector/InspectorProfilerAgent.cpp: (WebCore::InspectorProfilerAgent::addProfileFinishedMessageToConsole): (WebCore::InspectorProfilerAgent::addStartProfilingMessageToConsole):

04:30 Changeset [76344] by loislo@chromium.org

2011-01-20 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: switch page/Console implementation from InspectorController to InspectorInstrumentation.

There are some places in WebCore where we still using direct InspectorController calls.
The idea is to pass all the Inspector related calls via InspectorInstrumentaion which is the
Inspector facade for WebCore.

https://bugs.webkit.org/show_bug.cgi?id=52869

inspector/InspectorController.cpp:
inspector/InspectorController.h:
inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::addProfileImpl): (WebCore::InspectorInstrumentation::profilerEnabledImpl): (WebCore::InspectorInstrumentation::getCurrentUserInitiatedProfileNameImpl):
inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::addProfile): (WebCore::InspectorInstrumentation::profilerEnabled): (WebCore::InspectorInstrumentation::getCurrentUserInitiatedProfileName):
page/Console.cpp: (WebCore::Console::profile): (WebCore::Console::profileEnd):

04:16 Changeset [76343] by ossy@webkit.org

Unreviewed.

[Qt] editing/selection/rtl-move-selection-right-left.html fails
https://bugs.webkit.org/show_bug.cgi?id=52883

platform/qt/Skipped: editing/selection/rtl-move-selection-right-left.html added until fix.

04:08 Changeset [76342] by sergio@webkit.org

2011-01-21 Sergio Villar Senin <svillar@igalia.com>

Unreviewed.

[GTK] http/tests/security/drag-drop-same-unique-origin.html fails on bots.
https://bugs.webkit.org/show_bug.cgi?id=52882

Skipping http/tests/security/drag-drop-same-unique-origin.html for gtk.

platform/gtk/Skipped:

03:59 Changeset [76341] by podivilov@chromium.org

2011-01-12 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: breakpoints are restored incorrectly when reverting live edit.
https://bugs.webkit.org/show_bug.cgi?id=52300

Fix breakpoints restoring when reverting to old revision by using text diff.
Move live edit logic from ScriptsPanel to DebuggerModel.
Eliminate unnecessary editLine delegate in TextViewer.

inspector/front-end/DebuggerModel.js: (WebInspector.DebuggerModel): (WebInspector.DebuggerModel.prototype.reset): (WebInspector.DebuggerModel.prototype.editScriptSource): (WebInspector.DebuggerModel.prototype._updateScriptSource): (WebInspector.DebuggerModel.prototype.get callFrames): (WebInspector.DebuggerModel.prototype.pausedScript): (WebInspector.DebuggerModel.prototype.resumedScript):
inspector/front-end/Script.js: (WebInspector.Script.prototype.get source):
inspector/front-end/ScriptView.js: (WebInspector.ScriptView):
inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype._scriptSourceChanged):
inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame): (WebInspector.SourceFrame.prototype._createViewerIfNeeded): (WebInspector.SourceFrame.prototype._doubleClick.didEditLine): (WebInspector.SourceFrame.prototype._doubleClick):
inspector/front-end/SourceView.js: (WebInspector.SourceView):
inspector/front-end/TextViewer.js: (WebInspector.TextViewer): (WebInspector.TextViewer.prototype._handleKeyDown): (WebInspector.TextViewer.prototype.editLine.finishEditing): (WebInspector.TextViewer.prototype.editLine): (WebInspector.TextChunk.prototype._createRow):

03:31 Changeset [76340] by commit-queue@webkit.org

2011-01-21 Adam Klein <adamk@chromium.org>

Reviewed by Eric Seidel.

[chromium] Rename ChromiumBridge to PlatformBridge
https://bugs.webkit.org/show_bug.cgi?id=52471

No tests added as this is a rename; no change in behavior.

WebCore.gypi:
bindings/v8/V8DOMWindowShell.cpp: (WebCore::reportFatalErrorInV8):
page/PageGroup.cpp: (WebCore::PageGroup::isLinkVisited):
platform/android/PlatformBridge.h:
platform/audio/chromium/AudioBusChromium.cpp: (WebCore::createBusFromInMemoryAudioFile):
platform/chromium/ChromiumBridge.h: Removed.
platform/chromium/ChromiumDataObjectLegacy.cpp: (WebCore::ChromiumDataObjectLegacy::getData):
platform/chromium/DragDataChromium.cpp: (WebCore::DragData::asURL):
platform/chromium/FileSystemChromium.cpp: (WebCore::deleteFile): (WebCore::deleteEmptyDirectory): (WebCore::getFileSize): (WebCore::getFileModificationTime): (WebCore::revealFolderInOS): (WebCore::directoryName): (WebCore::pathByAppendingComponent): (WebCore::makeAllDirectories): (WebCore::fileExists): (WebCore::openFile): (WebCore::closeFile): (WebCore::seekFile): (WebCore::truncateFile): (WebCore::readFromFile): (WebCore::writeToFile):
platform/chromium/LanguageChromium.cpp: (WebCore::platformDefaultLanguage):
platform/chromium/LinkHashChromium.cpp: (WebCore::visitedLinkHash):
platform/chromium/MIMETypeRegistryChromium.cpp: (WebCore::MIMETypeRegistry::getMIMETypeForExtension): (WebCore::MIMETypeRegistry::getPreferredExtensionForMIMEType): (WebCore::MIMETypeRegistry::isSupportedImageMIMEType): (WebCore::MIMETypeRegistry::isSupportedJavaScriptMIMEType): (WebCore::MIMETypeRegistry::isSupportedNonImageMIMEType):
platform/chromium/PasteboardChromium.cpp: (WebCore::Pasteboard::writeSelection): (WebCore::Pasteboard::writePlainText): (WebCore::Pasteboard::writeURL): (WebCore::Pasteboard::writeImage): (WebCore::Pasteboard::canSmartReplace): (WebCore::Pasteboard::plainText): (WebCore::Pasteboard::documentFragment):
platform/chromium/PlatformBridge.h:
platform/chromium/PlatformScreenChromium.cpp: (WebCore::screenDepth): (WebCore::screenDepthPerComponent): (WebCore::screenIsMonochrome): (WebCore::screenRect): (WebCore::screenAvailableRect):
platform/chromium/ReadableDataObject.cpp: (WebCore::ReadableDataObject::getData): (WebCore::ReadableDataObject::urlTitle): (WebCore::ReadableDataObject::htmlBaseUrl): (WebCore::ReadableDataObject::filenames): (WebCore::ReadableDataObject::ensureTypeCacheInitialized):
platform/chromium/SSLKeyGeneratorChromium.cpp: (WebCore::signedPublicKeyAndChallengeString):
platform/chromium/ScrollbarThemeChromium.cpp:
platform/chromium/ScrollbarThemeChromiumLinux.cpp: (WebCore::ScrollbarThemeChromiumLinux::scrollbarThickness): (WebCore::ScrollbarThemeChromiumLinux::paintTrackPiece): (WebCore::ScrollbarThemeChromiumLinux::paintButton): (WebCore::ScrollbarThemeChromiumLinux::paintThumb): (WebCore::ScrollbarThemeChromiumLinux::buttonSize): (WebCore::ScrollbarThemeChromiumLinux::minimumThumbLength):
platform/chromium/ScrollbarThemeChromiumMac.mm: (WebCore::scrollbarStateToThemeState): (WebCore::ScrollbarThemeChromiumMac::paint):
platform/chromium/ScrollbarThemeChromiumWin.cpp: (WebCore::ScrollbarThemeChromiumWin::scrollbarThickness): (WebCore::ScrollbarThemeChromiumWin::paintTrackPiece): (WebCore::ScrollbarThemeChromiumWin::paintButton): (WebCore::ScrollbarThemeChromiumWin::paintThumb): (WebCore::ScrollbarThemeChromiumWin::buttonSize):
platform/chromium/SharedTimerChromium.cpp: (WebCore::setSharedTimerFiredFunction): (WebCore::setSharedTimerFireTime): (WebCore::stopSharedTimer):
platform/chromium/SuddenTerminationChromium.cpp: (WebCore::disableSuddenTermination): (WebCore::enableSuddenTermination):
platform/chromium/SystemTimeChromium.cpp: (WebCore::currentTime):
platform/chromium/WritableDataObject.cpp: (WebCore::WritableDataObject::setData):
platform/graphics/chromium/CrossProcessFontLoading.mm:
platform/graphics/chromium/FontCacheChromiumWin.cpp: (WebCore::fontContainsCharacter): (WebCore::FillLogFont):
platform/graphics/chromium/FontCacheLinux.cpp: (WebCore::FontCache::getFontDataForCharacters):
platform/graphics/chromium/FontChromiumWin.cpp: (WebCore::Font::drawGlyphs):
platform/graphics/chromium/FontPlatformDataChromiumWin.cpp: (WebCore::FontPlatformData::scriptFontProperties):
platform/graphics/chromium/FontPlatformDataLinux.cpp: (WebCore::FontPlatformData::querySystemForRenderStyle):
platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp: (WebCore::fillBMPGlyphs):
platform/graphics/chromium/ImageChromium.cpp: (WebCore::Image::loadPlatformResource):
platform/graphics/chromium/ImageChromiumMac.mm: (WebCore::Image::loadPlatformResource):
platform/graphics/chromium/SimpleFontDataChromiumWin.cpp: (WebCore::SimpleFontData::platformInit): (WebCore::SimpleFontData::determinePitch): (WebCore::SimpleFontData::platformWidthForGlyph):
platform/graphics/chromium/UniscribeHelperTextRun.cpp: (WebCore::UniscribeHelperTextRun::tryToPreloadFont):
platform/graphics/skia/FontCustomPlatformData.cpp: (WebCore::FontCustomPlatformData::fontPlatformData):
platform/network/chromium/CookieJarChromium.cpp: (WebCore::setCookies): (WebCore::cookies): (WebCore::cookieRequestHeaderFieldValue): (WebCore::cookiesEnabled): (WebCore::getRawCookies): (WebCore::deleteCookie):
platform/network/chromium/DNSChromium.cpp: (WebCore::prefetchDNS):
platform/qt/PlatformBridge.h:
platform/sql/chromium/SQLiteFileSystemChromium.cpp: (WebCore::SQLiteFileSystem::deleteDatabaseFile): (WebCore::SQLiteFileSystem::getDatabaseFileSize):
platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp: (chromiumOpen): (chromiumDelete): (chromiumAccess):
platform/sql/chromium/SQLiteFileSystemChromiumWin.cpp:
plugins/chromium/PluginDataChromium.cpp: (WebCore::PluginCache::plugins):
rendering/RenderThemeChromiumMac.mm: (WebCore::RenderThemeChromiumMac::usesTestModeFocusRingColor):
rendering/RenderThemeChromiumSkia.cpp: (WebCore::RenderThemeChromiumSkia::caretBlinkInterval):
rendering/RenderThemeChromiumWin.cpp: (WebCore::RenderThemeChromiumWin::platformActiveSelectionBackgroundColor): (WebCore::RenderThemeChromiumWin::platformInactiveSelectionBackgroundColor): (WebCore::RenderThemeChromiumWin::platformActiveSelectionForegroundColor): (WebCore::RenderThemeChromiumWin::systemColor): (WebCore::RenderThemeChromiumWin::paintButton): (WebCore::RenderThemeChromiumWin::paintSliderTrack): (WebCore::menuListButtonWidth): (WebCore::RenderThemeChromiumWin::paintMenuList): (WebCore::RenderThemeChromiumWin::paintTextFieldInternal): (WebCore::RenderThemeChromiumWin::paintInnerSpinButton): (WebCore::RenderThemeChromiumWin::paintProgressBar):
storage/chromium/IDBFactoryBackendInterface.cpp: (WebCore::IDBFactoryBackendInterface::create): (WebCore::IDBFactoryBackendInterface::~IDBFactoryBackendInterface):
storage/chromium/IDBKeyPathBackendImpl.cpp: (WebCore::IDBKeyPathBackendImpl::createIDBKeysFromSerializedValuesAndKeyPath):

2011-01-21 Adam Klein <adamk@chromium.org>

Reviewed by Eric Seidel.

[chromium] Rename ChromiumBridge to PlatformBridge
https://bugs.webkit.org/show_bug.cgi?id=52471

WebKit.gyp:
src/AssertMatchingEnums.cpp:
src/PlatformBridge.cpp: (WebCore::toChromeClientImpl): (WebCore::toWebWidgetClient): (WebCore::getCookieJar): (WebCore::PlatformBridge::cacheMetadata): (WebCore::PlatformBridge::clipboardIsFormatAvailable): (WebCore::PlatformBridge::clipboardReadPlainText): (WebCore::PlatformBridge::clipboardReadHTML): (WebCore::PlatformBridge::clipboardWriteSelection): (WebCore::PlatformBridge::clipboardWritePlainText): (WebCore::PlatformBridge::clipboardWriteURL): (WebCore::PlatformBridge::clipboardWriteImage): (WebCore::PlatformBridge::clipboardWriteData): (WebCore::PlatformBridge::clipboardReadAvailableTypes): (WebCore::PlatformBridge::clipboardReadData): (WebCore::PlatformBridge::clipboardReadFilenames): (WebCore::PlatformBridge::setCookies): (WebCore::PlatformBridge::cookies): (WebCore::PlatformBridge::cookieRequestHeaderFieldValue): (WebCore::PlatformBridge::rawCookies): (WebCore::PlatformBridge::deleteCookie): (WebCore::PlatformBridge::cookiesEnabled): (WebCore::PlatformBridge::prefetchDNS): (WebCore::PlatformBridge::fileExists): (WebCore::PlatformBridge::deleteFile): (WebCore::PlatformBridge::deleteEmptyDirectory): (WebCore::PlatformBridge::getFileSize): (WebCore::PlatformBridge::revealFolderInOS): (WebCore::PlatformBridge::getFileModificationTime): (WebCore::PlatformBridge::directoryName): (WebCore::PlatformBridge::pathByAppendingComponent): (WebCore::PlatformBridge::makeAllDirectories): (WebCore::PlatformBridge::getAbsolutePath): (WebCore::PlatformBridge::isDirectory): (WebCore::PlatformBridge::filePathToURL): (WebCore::PlatformBridge::openFile): (WebCore::PlatformBridge::closeFile): (WebCore::PlatformBridge::seekFile): (WebCore::PlatformBridge::truncateFile): (WebCore::PlatformBridge::readFromFile): (WebCore::PlatformBridge::writeToFile): (WebCore::PlatformBridge::ensureFontLoaded): (WebCore::PlatformBridge::getFontFamilyForCharacters): (WebCore::PlatformBridge::getRenderStyleForStrike): (WebCore::PlatformBridge::loadFont): (WebCore::PlatformBridge::databaseOpenFile): (WebCore::PlatformBridge::databaseDeleteFile): (WebCore::PlatformBridge::databaseGetFileAttributes): (WebCore::PlatformBridge::databaseGetFileSize): (WebCore::PlatformBridge::idbFactory): (WebCore::PlatformBridge::idbShutdown): (WebCore::PlatformBridge::createIDBKeysFromSerializedValuesAndKeyPath): (WebCore::PlatformBridge::signedPublicKeyAndChallengeString): (WebCore::PlatformBridge::computedDefaultLanguage): (WebCore::PlatformBridge::layoutTestMode): (WebCore::PlatformBridge::isSupportedImageMIMEType): (WebCore::PlatformBridge::isSupportedJavaScriptMIMEType): (WebCore::PlatformBridge::isSupportedNonImageMIMEType): (WebCore::PlatformBridge::mimeTypeForExtension): (WebCore::PlatformBridge::mimeTypeFromFile): (WebCore::PlatformBridge::preferredExtensionForMIMEType): (WebCore::PlatformBridge::plugins): (WebCore::PlatformBridge::pluginScriptableObject): (WebCore::PlatformBridge::loadPlatformImageResource): (WebCore::PlatformBridge::loadPlatformAudioResource): (WebCore::PlatformBridge::decodeAudioFileData): (WebCore::PlatformBridge::sandboxEnabled): (WebCore::PlatformBridge::setSharedTimerFiredFunction): (WebCore::PlatformBridge::setSharedTimerFireTime): (WebCore::PlatformBridge::stopSharedTimer): (WebCore::PlatformBridge::decrementStatsCounter): (WebCore::PlatformBridge::incrementStatsCounter): (WebCore::PlatformBridge::histogramCustomCounts): (WebCore::PlatformBridge::histogramEnumeration): (WebCore::PlatformBridge::suddenTerminationChanged): (WebCore::PlatformBridge::currentTime): (WebCore::PlatformBridge::paintButton): (WebCore::PlatformBridge::paintMenuList): (WebCore::PlatformBridge::paintScrollbarArrow): (WebCore::PlatformBridge::paintScrollbarThumb): (WebCore::PlatformBridge::paintScrollbarTrack): (WebCore::PlatformBridge::paintSpinButton): (WebCore::PlatformBridge::paintTextField): (WebCore::PlatformBridge::paintTrackbar): (WebCore::PlatformBridge::paintProgressBar): (WebCore::WebThemePart): (WebCore::WebThemeState): (WebCore::GetWebThemeExtraParams): (WebCore::PlatformBridge::getThemePartSize): (WebCore::PlatformBridge::paintThemePart): (WebCore::PlatformBridge::traceEventBegin): (WebCore::PlatformBridge::traceEventEnd): (WebCore::PlatformBridge::visitedLinkHash): (WebCore::PlatformBridge::isLinkVisited): (WebCore::PlatformBridge::notifyJSOutOfMemory): (WebCore::PlatformBridge::memoryUsageMB): (WebCore::PlatformBridge::actualMemoryUsageMB): (WebCore::PlatformBridge::screenDepth): (WebCore::PlatformBridge::screenDepthPerComponent): (WebCore::PlatformBridge::screenIsMonochrome): (WebCore::PlatformBridge::screenRect): (WebCore::PlatformBridge::screenAvailableRect): (WebCore::PlatformBridge::popupsAllowed): (WebCore::WorkerContextProxy::create):
src/ResourceHandle.cpp: (WebCore::ResourceHandle::cacheMetadata):
src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::WebFrameImpl): (WebKit::WebFrameImpl::~WebFrameImpl):
src/WebViewImpl.cpp: (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

03:23 Changeset [76339] by eric@webkit.org

2011-01-21 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Split Host object off from WebKitPatch for easier re-use
https://bugs.webkit.org/show_bug.cgi?id=52284

new-run-webkit-tests and other tools are eventually going to want one of these.
Basically you need to inherit from this class if you want to pretend to be a
self.tool object for Steps/Commands.

Scripts/webkitpy/common/host.py: Added.
Scripts/webkitpy/tool/main.py:

03:14 Changeset [76338] by commit-queue@webkit.org

2011-01-21 Helder Correia <helder@sencha.com>

Reviewed by Andreas Kling.

[Qt] svg/css/text-gradient-shadow.svg needs expected results
https://bugs.webkit.org/show_bug.cgi?id=52724

platform/qt/svg/css/text-gradient-shadow-expected.checksum: Added.
platform/qt/svg/css/text-gradient-shadow-expected.png: Added.
platform/qt/svg/css/text-gradient-shadow-expected.txt: Added.

02:06 Changeset [76337] by loislo@chromium.org

2011-01-21 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r76335.
http://trac.webkit.org/changeset/76335
https://bugs.webkit.org/show_bug.cgi?id=52875

profiler tests were broken (Requested by loislo on #webkit).

inspector/InspectorController.cpp: (WebCore::InspectorController::addProfile): (WebCore::InspectorController::getCurrentUserInitiatedProfileName):
inspector/InspectorController.h:
inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::addStartProfilingMessageToConsoleImpl):
inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::addStartProfilingMessageToConsole): (WebCore::InspectorInstrumentation::inspectorControllerWithFrontendForPage):
page/Console.cpp: (WebCore::Console::profile): (WebCore::Console::profileEnd):

01:34 Changeset [76336] by yurys@chromium.org

2011-01-21 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Make userscripts/window-onerror-for-isolated-world-*.html give consistent output
https://bugs.webkit.org/show_bug.cgi?id=52870

Call setTimeout from "load" event listener to make sure exception in the setTimeout
callback happens after the one in the listener.

platform/chromium/userscripts/window-onerror-for-isolated-world-1-expected.txt:
platform/chromium/userscripts/window-onerror-for-isolated-world-2-expected.txt:
userscripts/window-onerror-for-isolated-world-1-expected.txt:
userscripts/window-onerror-for-isolated-world-1.html:
userscripts/window-onerror-for-isolated-world-2-expected.txt:
userscripts/window-onerror-for-isolated-world-2.html:

01:24 Changeset [76335] by loislo@chromium.org

2011-01-21 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: switch page/Console implementation from InspectorController to InspectorInstrumentation.

There are some places in WebCore where we still using direct InspectorController calls.
The idea is to pass all the Inspector related calls via InspectorInstrumentaion which is the
Inspector facade for WebCore.

https://bugs.webkit.org/show_bug.cgi?id=52869

inspector/InspectorController.cpp:
inspector/InspectorController.h:
inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::addProfileImpl): (WebCore::InspectorInstrumentation::profilerEnabledImpl): (WebCore::InspectorInstrumentation::getCurrentUserInitiatedProfileNameImpl):
inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::addProfile): (WebCore::InspectorInstrumentation::profilerEnabled): (WebCore::InspectorInstrumentation::getCurrentUserInitiatedProfileName):
page/Console.cpp: (WebCore::Console::profile): (WebCore::Console::profileEnd):

01/20/11:

22:10 Changeset [76334] by rniwa@webkit.org

2011-01-20 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Maciej Stachowiak.

Added OwnPtrCommon.h because OwnArrayPtr::set calls deleteOwnedPtr.

wtf/OwnArrayPtr.h:

21:25 Changeset [76333] by mjs@apple.com

2011-01-20 Maciej Stachowiak <mjs@apple.com>

Reviewed by Dan Bernstein.

Skip a few more tests that are failing on the bots
https://bugs.webkit.org/show_bug.cgi?id=52865

platform/mac-wk2/Skipped:

20:58 Changeset [76332] by paroga@webkit.org

2011-01-20 Patrick Gansterer <paroga@webkit.org>

Reviewed by Oliver Hunt.

[WINCE] Remove obsolete JSVALUE32 code
https://bugs.webkit.org/show_bug.cgi?id=52450

Remove the "offset hack" in create_jit_stubs, since we
only support JSVALUE32_64 in the meantime.

create_jit_stubs: Removed offset argument
jit/JITStubs.cpp:

20:07 Changeset [76331] by ggaren@apple.com

2011-01-20 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

When marking conservatively, guard against reviving dead objects.
https://bugs.webkit.org/show_bug.cgi?id=52840

SunSpider and v8 say no change.

interpreter/RegisterFile.h: (JSC::RegisterFile::markCallFrames): Updated to use the ConservativeSet API.

runtime/Heap.cpp: (JSC::Heap::recordExtraCost): No need to guard against conservative marking reviving dead objects anymore, since the conservative marking mechanism guards against this now.

(JSC::Heap::markConservatively):
(JSC::Heap::markProtectedObjects):
(JSC::Heap::markTempSortVectors): Don't drain the mark stack inside a
marking function. We want to establish a separation of concerns between
visiting roots and draining the mark stack.

(JSC::Heap::markRoots): Gather the set of conservative references before
clearning mark bits, because conservative marking now uses the mark bits
to determine if a reference is valid, and avoid reviving dead objects.

(JSC::Heap::collectAllGarbage): No need to guard against conservative
marking reviving dead objects anymore, since the conservative marking
mechanism guards against this now.

runtime/Heap.h: Updated to use the ConservativeSet API.

runtime/MachineStackMarker.cpp: (JSC::MachineStackMarker::markCurrentThreadConservativelyInternal): (JSC::MachineStackMarker::markCurrentThreadConservatively): (JSC::MachineStackMarker::markOtherThreadConservatively): (JSC::MachineStackMarker::markMachineStackConservatively):
runtime/MachineStackMarker.h: Ditto.

runtime/MarkStack.h: (JSC::ConservativeSet::add): (JSC::ConservativeSet::mark): Added ConservativeSet, for gathering the set of conservative references. This is different from MarkStack, since we don't mark the set until it is completely gathered.

runtime/MarkedSpace.cpp: (JSC::MarkedSpace::freeBlock): (JSC::MarkedSpace::resizeBlocks): (JSC::MarkedSpace::markConservatively):
runtime/MarkedSpace.h: When marking conservatively, guard against reviving dead objects.

19:46 Changeset [76330] by weinig@apple.com

Fix failing tests from r76291.

Reviewed by Gavin Barraclough.

platform/ScrollView.cpp:

(WebCore::ScrollView::scrollPosition):
(WebCore::ScrollView::updateScrollbars):
Take the scroll origin into account in more places.

19:41 Changeset [76329] by tkent@chromium.org

2011-01-20 Kent Tamura <tkent@chromium.org>

Unreviewed, sorting an Xcode project file.

WebCore.xcodeproj/project.pbxproj:

19:34 Changeset [76328] by ojan@chromium.org

2011-01-20 Ojan Vafai <ojan@chromium.org>

Fix the review tool for image diffs. We would get a javascript error
because image diffs don't have line numbers.

code-review.js:

19:29 Changeset [76327] by dimich@chromium.org

[Chromium] Not reviewed, add a bug number to disabled test.

platform/chromium/test_expectations.txt:

19:09 Changeset [76326] by dpranke@chromium.org

2011-01-20 Dirk Pranke <dpranke@chromium.org>

Reviewed by Adam Barth.

Disable the tests that start and stop the http server and web
server, so that we don't have to worry about port collisions on
the bots.

https://bugs.webkit.org/show_bug.cgi?id=52861

Scripts/webkitpy/layout_tests/port/port_testcase.py:

18:40 Changeset [76325] by mjs@apple.com

2011-01-20 Maciej Stachowiak <mjs@apple.com>

Reviewed by Darin Adler.

Skip some tests that are failing on the WebKit2 bot
https://bugs.webkit.org/show_bug.cgi?id=52858

platform/mac-wk2/Skipped: skip or re-skip some tests that fail on the bot for various reasons.

18:35 Changeset [76324] by commit-queue@webkit.org

2011-01-20 Ben Vanik <ben.vanik@gmail.com>

Reviewed by Kenneth Russell.

Implementation of the OES_standard_derivatives WebGL extension.
https://bugs.webkit.org/show_bug.cgi?id=51678

Changes are modeled off of the existing OESTextureFloat extension. New files,
extension retrieval, etc all match the existing code.

Changed ANGLEWebKitBridge to allow for multiple sets of the ANGLE shader compiler
options. This supports the enabling of the standard derivatives flag when the
extension is enabled. Refactored the cleanup code to make the destruction of the
compilers (if they had been created) cleaner.

Tested with the WebGL conformance test:
https://cvs.khronos.org/svn/repos/registry/trunk/public/webgl/sdk/tests/conformance/oes-standard-derivatives.html
Passes on WebKit/OSX, Chromium/OSX, and Chromium/Windows.

CMakeLists.txt:
DerivedSources.make:
GNUmakefile.am:
WebCore.gypi:
WebCore.pri:
WebCore.pro:
WebCore.xcodeproj/project.pbxproj:
bindings/js/JSWebGLRenderingContextCustom.cpp: (WebCore::toJS):
bindings/v8/custom/V8WebGLRenderingContextCustom.cpp: (WebCore::toV8Object):
html/canvas/OESStandardDerivatives.cpp: Added. (WebCore::OESStandardDerivatives::OESStandardDerivatives): (WebCore::OESStandardDerivatives::~OESStandardDerivatives): (WebCore::OESStandardDerivatives::getName): (WebCore::OESStandardDerivatives::create):
html/canvas/OESStandardDerivatives.h: Added.
html/canvas/OESStandardDerivatives.idl: Added.
html/canvas/WebGLExtension.h:
html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::getExtension): Enable and return the new extension. (WebCore::WebGLRenderingContext::getParameter): Support extension enum when enabled. (WebCore::WebGLRenderingContext::getSupportedExtensions): (WebCore::WebGLRenderingContext::hint): Validate extension enum when enabled. (WebCore::WebGLRenderingContext::getNumberOfExtensions): (WebCore::WebGLRenderingContext::getExtensionNumber):
html/canvas/WebGLRenderingContext.h:
platform/graphics/ANGLEWebKitBridge.cpp: (WebCore::ANGLEWebKitBridge::~ANGLEWebKitBridge): Cleaned up compiler cleanup. (WebCore::ANGLEWebKitBridge::cleanupCompilers): Destruct compilers. (WebCore::ANGLEWebKitBridge::setResources): Cleanup existing compilers when changing ANGLE settings. (WebCore::ANGLEWebKitBridge::validateShaderSource): Cleaned up compiler cleanup on error.
platform/graphics/ANGLEWebKitBridge.h: (WebCore::ANGLEWebKitBridge::getResources):
platform/graphics/Extensions3D.h: Added enumeration for the extension.
platform/graphics/GraphicsContext3D.h: lumbing for GraphicsContext3D.
platform/graphics/opengl/Extensions3DOpenGL.cpp: (WebCore::Extensions3DOpenGL::Extensions3DOpenGL): Plumbed through a pointer to the GraphicsContext3D to handle resetting the shader compilers. (WebCore::Extensions3DOpenGL::supports): Desktop GL always supports this extension, so always return true. (WebCore::Extensions3DOpenGL::ensureEnabled): Reset shader compilers as required.
platform/graphics/opengl/Extensions3DOpenGL.h: Plumbing for GraphicsContext3D.
platform/graphics/opengl/GraphicsContext3DOpenGL.cpp: (WebCore::GraphicsContext3D::getExtensions): Plumbing for GraphicsContext3D to Extensions3DOpenGL.

18:30 Changeset [76323] by dpranke@chromium.org

2011-01-20 Dirk Pranke <dpranke@chromium.org>

Reviewed by Eric Seidel.

nrwt: rewrite google_chrome_unittest to use mock filesystem.

https://bugs.webkit.org/show_bug.cgi?id=52772

Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:

18:30 Changeset [76322] by dpranke@chromium.org

2011-01-20 Dirk Pranke <dpranke@chromium.org>

Reviewed by Eric Siedel.

nrwt: clean up almost all remaining port references, remove
unnecessary import clauses. The only remaining references are
in places where a mock filesystem makes no sense or can't be
used, and in one routine in port/google_chrome_unittest that
I'll rewrite in a separate patch.

https://bugs.webkit.org/show_bug.cgi?id=52771

Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
Scripts/webkitpy/layout_tests/port/chromium_linux.py:
Scripts/webkitpy/layout_tests/port/chromium_mac.py:
Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
Scripts/webkitpy/layout_tests/port/chromium_win.py:
Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
Scripts/webkitpy/layout_tests/port/google_chrome.py:
Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
Scripts/webkitpy/layout_tests/port/gtk.py:
Scripts/webkitpy/layout_tests/port/mac.py:
Scripts/webkitpy/layout_tests/port/port_testcase.py:
Scripts/webkitpy/layout_tests/port/qt.py:
Scripts/webkitpy/layout_tests/port/webkit.py:
Scripts/webkitpy/layout_tests/port/win.py:
Scripts/webkitpy/layout_tests/test_types/image_diff.py:

18:26 Changeset [76321] by dpranke@chromium.org

2011-01-20 Dirk Pranke <dpranke@chromium.org>

Reviewed by Mihai Parparita.

remove fs refs from run_webkit_tests, rebaseline_chromium_webkit_tests

https://bugs.webkit.org/show_bug.cgi?id=52762

Scripts/webkitpy/layout_tests/run_webkit_tests.py:
Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:

18:18 Changeset [76320] by jer.noble@apple.com

Unreviewed Qt Skipped list update.

Skip the test added in r76296 for platform/qt/.

platform/qt/Skipped:

18:09 Changeset [76319] by xji@chromium.org

2011-01-20 Xiaomei Ji <xji@chromium.org>

Reviewed by Dan Bernstein.

Fix regression(r71566): PDF in RTL block might messes up text directionality.
https://bugs.webkit.org/show_bug.cgi?id=52776

Test: fast/dom/52776.html

platform/text/BidiResolver.h: (WebCore::::checkDirectionInLowerRaiseEmbeddingLevel): (WebCore::::lowerExplicitEmbeddingLevel): (WebCore::::raiseExplicitEmbeddingLevel): (WebCore::::createBidiRunsForLine):

2011-01-20 Xiaomei Ji <xji@chromium.org>

Reviewed by Dan Bernstein.

Fix regression(r71566): PDF in RTL block might messes up text directionality.
https://bugs.webkit.org/show_bug.cgi?id=52776

fast/dom/52776.html: Added.
platform/mac/fast/dom/52776-expected.checksum: Added.
platform/mac/fast/dom/52776-expected.png: Added.
platform/mac/fast/dom/52776-expected.txt: Added.

17:59 Changeset [76318] by bdakin@apple.com

Follow-on for <rdar://problem/8890255>

Reviewed by Anders Carlsson.

This fixes a painting error with ScrollbarPainter scrollers
and the new drawing area code path.

platform/mac/ScrollbarThemeMac.mm:

(WebCore::updateArrowPlacement):

17:43 Changeset [76317] by dimich@chromium.org

[chromium] Updating test expectations after fixing the bug:
https://bugs.webkit.org/show_bug.cgi?id=52062

Patch by Jenn Braithwaite <jennb@chromium.org> on 2011-01-20
Reviewed by Dmitry Titov.

platform/chromium/test_expectations.txt:

iframe-reparenting-plugins.html is now passing on Windows.

17:40 Changeset [76316] by tony@chromium.org

2011-01-20 Tony Chang <tony@chromium.org>

Unreviewed, rebaseline a test added in
http://trac.webkit.org/changeset/76274

platform/chromium-linux/svg/custom/pattern-referencing-preserve-aspect-ratio-expected.checksum: Added.
platform/chromium-linux/svg/custom/pattern-referencing-preserve-aspect-ratio-expected.png: Added.
platform/chromium-win/svg/custom/pattern-referencing-preserve-aspect-ratio-expected.checksum: Added.
platform/chromium-win/svg/custom/pattern-referencing-preserve-aspect-ratio-expected.png: Added.
platform/chromium-win/svg/custom/pattern-referencing-preserve-aspect-ratio-expected.txt: Added.
platform/chromium/test_expectations.txt:

17:31 Changeset [76315] by leviw@chromium.org

2011-01-20 Levi Weintraub <leviw@chromium.org>

Unreviewed.

Fixing build breakage.

editing/SelectionController.cpp: (WebCore::SelectionController::willBeModified):

17:28 Changeset [76314] by tony@chromium.org

2011-01-20 Tony Chang <tony@chromium.org>

Reviewed by Ojan Vafai.

[chromium] fix the paths used for the rebaseline tool
https://bugs.webkit.org/show_bug.cgi?id=52857

Some of the bots were renamed so the path to grab the results zip
file has changed.

Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:

17:22 Changeset [76313] by commit-queue@webkit.org

2011-01-20 Siddharth Mathur <siddharth.mathur@nokia.com>

Reviewed by Laszlo Gombos.

[Qt][Symbian] Smaller debug symbol size when using RVCT 4.x
https://bugs.webkit.org/show_bug.cgi?id=52835

WebKit.pri: Use --remove_unneeded_entities for RVCT 4.x compilers

17:21 Changeset [76312] by leviw@chromium.org

2011-01-20 Levi Weintraub <leviw@chromium.org>

Reviewed by Ryosuke Niwa.

RTL: Caret goes to the opposite direction when pressing an arrow key after selection is made
https://bugs.webkit.org/show_bug.cgi?id=49511

Test: editing/selection/rtl-move-selection-right-left.html

editing/SelectionController.cpp: (WebCore::SelectionController::willBeModified): Respecting the direction of the containing block when switching selection base and extent in RTL content.

(WebCore::SelectionController::modifyMovingRight):
(WebCore::SelectionController::modifyMovingLeft):
Using directionOfEnclosingBlock when deciding to use the selection start or end to do the
correct thing for RTL.

2011-01-20 Levi Weintraub <leviw@chromium.org>

Reviewed by Ryosuke Niwa.

RTL: Caret goes to the opposite direction when pressing an arrow key after selection is made
https://bugs.webkit.org/show_bug.cgi?id=49511

editing/editing.js: (execMoveSelectionLeftByCharacterCommand): (moveSelectionLeftByCharacterCommand): (execMoveSelectionRightByCharacterCommand): (moveSelectionRightByCharacterCommand): (execExtendSelectionLeftByCharacterCommand): (extendSelectionLeftByCharacterCommand): (execExtendSelectionRightByCharacterCommand): (extendSelectionRightByCharacterCommand): Adding some left/right selection convenience methods for use with RTL tests.

editing/selection/rtl-move-selection-right-left-expected.txt: Added.
editing/selection/rtl-move-selection-right-left.html: Added.

17:06 Changeset [76311] by dpranke@chromium.org

2011-01-20 Dirk Pranke <dpranke@chromium.org>

Reviewed by Tony Chang.

Fix bug introduced in r72688 / bug 52768 that broke the
generation of the output filename links in the results.html
output. Apparently none of the unit tests actually checked to
make sure the generated links were correct :(

https://bugs.webkit.org/show_bug.cgi?id=52854

Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:

16:58 Changeset [76310] by ojan@chromium.org

2011-01-20 Ojan Vafai <ojan@chromium.org>

Reviewed by Oliver Hunt.

Could review tool include style failure info?
https://bugs.webkit.org/show_bug.cgi?id=49049

This does not handle patches that have old paths (e.g. without the Source prefix).
Although that would be fairly straightforward to workaround.

code-review.js:

16:33 Changeset [76309] by mrowe@apple.com

Merge r76296.

16:33 Changeset [76308] by mrowe@apple.com

Versioning.

16:22 Changeset [76307] by tony@chromium.org

2011-01-20 Tony Chang <tony@chromium.org>

Unreviewed, mark some rtl scrolling tests as failing to green the chromium bots.

platform/chromium/test_expectations.txt:

16:19 Changeset [76306] by ap@apple.com

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=52849
Make window.print work with WebKit2

UIProcess/API/qt/qwkpage.cpp: (QWKPage::QWKPage):
UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::printFrame):
UIProcess/WebPageProxy.h:
UIProcess/WebPageProxy.messages.in:
UIProcess/WebUIClient.cpp: (WebKit::WebUIClient::printFrame):
UIProcess/WebUIClient.h:
WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::print): Just pass through deelagte call to a WebKit2 client.

UIProcess/API/C/WKPage.h: Also added "Callback" suffix to other printing related function types.

16:13 Changeset [76305] by andersca@apple.com

2011-01-20 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler.

Keep track of the latest update timestamp in the backing store
https://bugs.webkit.org/show_bug.cgi?id=52848

Shared/UpdateInfo.h: (WebKit::UpdateInfo::UpdateInfo): Initialize timestamp to 0.

UIProcess/BackingStore.cpp: (WebKit::BackingStore::BackingStore): Initialize m_latestUpdateTimestamp to 0.

(WebKit::BackingStore::incorporateUpdate):
If the update is too old, discard it. Otherwise, create a bitmap
and pass it to platformIncorporateUpdate. Finally update the timestamp.

UIProcess/BackingStore.h: Add m_latestUpdateTimestamp.

UIProcess/mac/BackingStoreMac.mm: (WebKit::BackingStore::platformIncorporateUpdate): Update now that we are already given the shareable bitmap.

16:08 Changeset [76304] by tony@chromium.org

2011-01-20 Tony Chang <tony@chromium.org>

Unreviewed, chromium test expectation updates.

platform/chromium-gpu/test_expectations.txt:
platform/chromium/test_expectations.txt:

16:05 Changeset [76303] by japhet@chromium.org

2011-01-20 Nate Chapin <japhet@chromium.org>

Reviewed by Adam Barth.

Test for https://bugs.webkit.org/show_bug.cgi?id=52769.

fast/dom/Window/Location/resources/set-location-after-close-new-window.html: Added.
fast/dom/Window/Location/set-location-after-close-expected.txt: Added.
fast/dom/Window/Location/set-location-after-close.html: Added.

2011-01-20 Nate Chapin <japhet@chromium.org>

Reviewed by Adam Barth.

Null-check m_frame in DOMWindow::setLocation(), since it's
possible to reach this point without it having been checked
already.
https://bugs.webkit.org/show_bug.cgi?id=52769

Test: fast/dom/Window/Location/set-location-after-close.html

page/DOMWindow.cpp: (WebCore::DOMWindow::setLocation):

16:04 Changeset [76302] by ojan@chromium.org

2011-01-20 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

handle cases where PrettyPatch.rb doesn't linkify filenames
https://bugs.webkit.org/show_bug.cgi?id=52834

code-review.js:

15:57 Changeset [76301] by chang.shu@nokia.com

2011-01-20 Chang Shu <chang.shu@nokia.com>

Reviewed by Darin Adler.

setContentEditable with invalid string should throw exception.
https://bugs.webkit.org/show_bug.cgi?id=52057

Updated expected results after the fix. Also corrected test cases.

editing/editability/set-invalid-value-expected.txt:
editing/editability/set-invalid-value.html: 1. Fixed the getAttribute expectation as "abc" was failed to set. 2. Added additional check for setting empty string.
editing/editability/set-value-caseinsensitive-expected.txt:
editing/editability/set-value-caseinsensitive.html: Fixed the getAttribute expectations as all strings should be converted to lower cases.
fast/dom/element-attribute-js-null-expected.txt:
fast/dom/element-attribute-js-null.html: Fixed this existing test as the expectation for setting with null should throw exception instead of "false". Also added handling code when exception was thrown.

2011-01-20 Chang Shu <chang.shu@nokia.com>

Reviewed by Darin Adler.

setContentEditable with invalid string should throw exception.
https://bugs.webkit.org/show_bug.cgi?id=52057

Implemented exception throwing for setContentEditable according to the following spec:
http://www.whatwg.org/specs/web-apps/current-work/multipage/editing.html#attr-contenteditable
Related quotas: "On setting, if the new value is an ASCII case-insensitive match for the
string 'inherit' then the content attribute must be removed, if the new value is an ASCII
case-insensitive match for the string 'true' then the content attribute must be set to the
string 'true', if the new value is an ASCII case-insensitive match for the string 'false'
then the content attribute must be set to the string 'false', and otherwise the attribute
setter must raise a SYNTAX_ERR exception."

html/HTMLElement.cpp: (WebCore::HTMLElement::setContentEditable): Throw exception on invalid input strings; Make setting values case-insensitive and also convert them to lower cases according to the spec.
html/HTMLElement.h: Add additional parameter ExceptionCode& for function setContentEditable.
html/HTMLElement.idl: Add exception throwing support for contentEditable setter.

15:55 Changeset [76300] by sullivan@apple.com

Shift-tab doesn't cycle through fields in http authentication panel
https://bugs.webkit.org/show_bug.cgi?id=52850

Reviewed by Mark Rowe.

Panels/English.lproj/WebAuthenticationPanel.nib/designable.nib:
Panels/English.lproj/WebAuthenticationPanel.nib/keyedobjects.nib:

Re-wired the key loop so that there aren't two views with the same nextKeyView.

15:53 Changeset [76299] by enne@google.com

2011-01-20 Adrienne Walker <enne@google.com>

Reviewed by James Robinson.

[chromium] Add a test for a render surface that the uses alpha channel.
https://bugs.webkit.org/show_bug.cgi?id=52766

platform/chromium-gpu/platform/chromium/compositing/render-surface-alpha-blending-expected.checksum: Added.
platform/chromium-gpu/platform/chromium/compositing/render-surface-alpha-blending-expected.png: Added.
platform/chromium-gpu/platform/chromium/compositing/render-surface-alpha-blending-expected.txt: Added.
platform/chromium/compositing/render-surface-alpha-blending.html: Added.

2011-01-19 Adrienne Walker <enne@google.com>

Reviewed by James Robinson.

[chromium] Composited render surfaces should allow writes to alpha channel.
https://bugs.webkit.org/show_bug.cgi?id=52766

Test: LayoutTests/platform/chromium/compositing

platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::drawLayers):

15:49 Changeset [76298] by mrowe@apple.com

New tag.

15:49 Changeset [76297] by commit-queue@webkit.org

2011-01-20 Siddharth Mathur <siddharth.mathur@nokia.com>

Reviewed by Geoffrey Garen.

[Symbian] Fix StackBounds::initialize()
https://bugs.webkit.org/show_bug.cgi?id=52842

wtf/StackBounds.cpp: (WTF::StackBounds::initialize): Use TThreadStackInfo.iLimit for stack limit

15:45 Changeset [76296] by jer.noble@apple.com

2011-01-14 Jer Noble <jer.noble@apple.com>

Reviewed by Eric Carlson.

REGRESSION (r71842): Compass video is not playing in Safari welcome page
https://bugs.webkit.org/show_bug.cgi?id=52506

Test that a delay between loading and playing video does not break playback.

media/video-currentTime-delay-expected.txt: Added.
media/video-currentTime-delay.html: Added.

2011-01-14 Jer Noble <jer.noble@apple.com>

Reviewed by Eric Carlson.

REGRESSION (r71842): Compass video is not playing in Safari welcome page
https://bugs.webkit.org/show_bug.cgi?id=52506

New test: LayoutTests/media/video-currentTime-delay.html

Call invalidateCachedTime() every time one of the cached property dependencies changes,
i.e. m_paused and m_playbackRate.

html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::prepareForLoad): (WebCore::HTMLMediaElement::setReadyState): (WebCore::HTMLMediaElement::setPlaybackRate): (WebCore::HTMLMediaElement::mediaPlayerRateChanged):

15:41 Changeset [76295] by weinig@apple.com

Fix build.

Api/qwebframe.cpp:

(QWebFrame::setScrollBarValue):

15:37 Changeset [76294] by commit-queue@webkit.org

2011-01-20 Adam Klein <adamk@chromium.org>

Reviewed by Andreas Kling.

[chromium] Remove deprecated WebKit::nameOfInputElement function
https://bugs.webkit.org/show_bug.cgi?id=52824

src/DOMUtilitiesPrivate.cpp:
src/DOMUtilitiesPrivate.h:

15:19 Changeset [76293] by weinig@apple.com

Fix build.

Api/qwebframe.cpp:

(QWebFrame::setScrollBarValue):

15:18 Changeset [76292] by bdakin@apple.com

Fix for <rdar://problem/8890255>

Reviewed by Geoffrey Garen.

Source/WebCore:

Allow WebKitSystemInterface to draw scrollbars
when appropriate.

WebCore.exp.in:
platform/mac/ScrollbarThemeMac.mm:

(WebCore::scrollbarMap):
(+[ScrollbarPrefsObserver appearancePrefsChanged:]):
(WebCore::ScrollbarThemeMac::registerScrollbar):
(WebCore::ScrollbarThemeMac::unregisterScrollbar):
(WebCore::ScrollbarThemeMac::paint):

platform/mac/WebCoreSystemInterface.h:
platform/mac/WebCoreSystemInterface.mm:

Source/WebKit/mac:

Allow WebKitSystemInterface to draw scrollbars
when appropriate.

WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

Source/WebKit2:

Allow WebKitSystemInterface to draw scrollbars
when appropriate.

WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

15:14 Changeset [76291] by weinig@apple.com

Cleanup Scrollbar/ScrollbarClient relationship
https://bugs.webkit.org/show_bug.cgi?id=52779

Reviewed by Dave Hyatt.

Source/WebCore:

Pipe all scrolling through the ScrollbarClient/ScrollAnimator
rather than through the Scrollbar. The Scrollbar now is just
a "view" on the scroll position of the scrollable area it is
attached to.

There are now two ways to scroll a scrollable area:

ScrollbarClient::scroll()
ScrollbarClient::scrollToOffsetWithoutAnimation()

Both of these go through the ScrollAnimator (updating its state
or starting an animation). The ScrollAnimator, in turn, now calls
ScrollbarClient::setScrollOffsetFromAnimation, which tells the
Scrollbars to pull a new offset (via Scrollbar::offsetDidChange)
and tells the class that derives from ScrollbarClient to scroll
its contents (via ScrollbarClient::setScrollOffset).

WebCore.xcodeproj/project.pbxproj:

Move Scrollbar.cpp to the right place.

accessibility/AccessibilityScrollbar.cpp:

(WebCore::AccessibilityScrollbar::setValue):
Initiate the scroll through the scrollbar client, rather than the
scrollbar itself.

page/FrameView.cpp:

(WebCore::FrameView::scrollTo):

page/FrameView.h:

Condense the two valueChanged overrides to a single override of the
scrollTo function.

platform/ScrollAnimator.cpp:

(WebCore::ScrollAnimator::scroll):
(WebCore::ScrollAnimator::scrollToOffsetWithoutAnimation):
(WebCore::ScrollAnimator::currentPosition):
(WebCore::ScrollAnimator::notityPositionChanged):

platform/ScrollAnimator.h:
platform/ScrollAnimatorWin.cpp:

(WebCore::ScrollAnimatorWin::scrollToOffsetWithoutAnimation):
(WebCore::ScrollAnimatorWin::animateScroll):

platform/ScrollAnimatorWin.h:
platform/mac/ScrollAnimatorMac.h:
platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::scrollToOffsetWithoutAnimation):
(WebCore::ScrollAnimatorMac::immediateScrollToPoint):
Change setScrollPositionAndStopAnimation to scrollToOffsetWithoutAnimation
and bottleneck all client notification of changed position through a new
notityPositionChanged() function.

platform/ScrollView.cpp:

(WebCore::ScrollView::setScrollOffset):
(WebCore::ScrollView::scrollTo):
(WebCore::ScrollView::scrollPosition):
(WebCore::ScrollView::scroll):
(WebCore::ScrollView::updateScrollbars):
(WebCore::ScrollView::wheelEvent):

platform/ScrollView.h:

(WebCore::ScrollView::horizontalScrollbar):
(WebCore::ScrollView::verticalScrollbar):
Update to scroll via the ScrollbarClient rather than the Scrollbar.

platform/Scrollbar.cpp:

(WebCore::Scrollbar::offsetDidChange):
(WebCore::Scrollbar::autoscrollPressedPart):
(WebCore::Scrollbar::moveThumb):
(WebCore::Scrollbar::mouseMoved):

platform/Scrollbar.h:

(WebCore::Scrollbar::setPressedPos):
Change the scrollbar to only updates its offset in response to
an offsetDidChange call.

platform/ScrollbarClient.cpp:

(WebCore::ScrollbarClient::scroll):
(WebCore::ScrollbarClient::scrollToOffsetWithoutAnimation):
(WebCore::ScrollbarClient::scrollToXOffsetWithoutAnimation):
(WebCore::ScrollbarClient::scrollToYOffsetWithoutAnimation):
(WebCore::ScrollbarClient::setScrollOffsetFromAnimation):

platform/ScrollbarClient.h:

(WebCore::ScrollbarClient::horizontalScrollbar):
(WebCore::ScrollbarClient::verticalScrollbar):
Make the increasingly misnamed ScrollbarClient responsible for
scrolling.

platform/efl/ScrollbarEfl.cpp:

(scrollbarEflEdjeMessage):

platform/gtk/MainFrameScrollbarGtk.cpp:

(MainFrameScrollbarGtk::gtkValueChanged):

platform/qt/ScrollbarQt.cpp:

(WebCore::Scrollbar::contextMenu):
Update to move scrolling through the client.

platform/win/PopupMenuWin.cpp:

(WebCore::PopupMenuWin::scrollToRevealSelection):
(WebCore::PopupMenuWin::scrollPosition):
(WebCore::PopupMenuWin::setScrollOffset):
(WebCore::PopupMenuWin::scrollTo):
(WebCore::PopupMenuWin::wndProc):

platform/win/PopupMenuWin.h:

(WebCore::PopupMenuWin::verticalScrollbar):

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::scrollToOffset):
(WebCore::RenderLayer::scrollTo):
(WebCore::RenderLayer::setScrollOffset):
(WebCore::RenderLayer::scrollPosition):
(WebCore::RenderLayer::updateScrollInfoAfterLayout):
(WebCore::RenderLayer::scroll):

rendering/RenderLayer.h:
rendering/RenderListBox.cpp:

(WebCore::RenderListBox::scrollToRevealElementAtListIndex):
(WebCore::RenderListBox::scroll):
(WebCore::RenderListBox::logicalScroll):
(WebCore::RenderListBox::scrollPosition):
(WebCore::RenderListBox::setScrollOffset):
(WebCore::RenderListBox::scrollTo):
(WebCore::RenderListBox::setScrollTop):

rendering/RenderListBox.h:

(WebCore::RenderListBox::verticalScrollbar):
Update to scroll via the ScrollbarClient rather than the Scrollbar.

rendering/RenderMarquee.cpp:

(WebCore::RenderMarquee::start):
Simplify initial paint to just do an immediate scroll to the position.

Source/WebKit/chromium:

src/WebScrollbarImpl.cpp:

(WebKit::WebScrollbarImpl::WebScrollbarImpl):
(WebKit::WebScrollbarImpl::value):
(WebKit::WebScrollbarImpl::setValue):
(WebKit::WebScrollbarImpl::scroll):
(WebKit::WebScrollbarImpl::onMouseDown):
(WebKit::WebScrollbarImpl::onMouseMove):
(WebKit::WebScrollbarImpl::onMouseWheel):
(WebKit::WebScrollbarImpl::onKeyDown):
(WebKit::WebScrollbarImpl::scrollPosition):
(WebKit::WebScrollbarImpl::setScrollOffset):

src/WebScrollbarImpl.h:

Source/WebKit/qt:

Api/qwebframe.cpp:

(QWebFrame::setScrollBarValue):

Source/WebKit/win:

WebScrollBar.cpp:

(WebScrollBar::WebScrollBar):
(WebScrollBar::setValue):
(WebScrollBar::value):
(WebScrollBar::scroll):
(WebScrollBar::scrollPosition):
(WebScrollBar::setScrollOffset):

WebScrollBar.h:

Source/WebKit2:

UIProcess/win/WebPopupMenuProxyWin.cpp:

(WebKit::WebPopupMenuProxyWin::scrollPosition):
(WebKit::WebPopupMenuProxyWin::setScrollOffset):
(WebKit::WebPopupMenuProxyWin::scrollTo):
(WebKit::WebPopupMenuProxyWin::onMouseWheel):
(WebKit::WebPopupMenuProxyWin::scrollToRevealSelection):

UIProcess/win/WebPopupMenuProxyWin.h:

(WebKit::WebPopupMenuProxyWin::verticalScrollbar):

15:14 Changeset [76290] by rniwa@webkit.org

2011-01-20 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed Chromium test expectations fix.

platform/chromium/test_expectations.txt:

15:10 Changeset [76289] by tony@chromium.org

2011-01-20 Tony Chang <tony@chromium.org>

Unreviewed, another attempt at making the chromium gpu tests go green.

platform/chromium-gpu/test_expectations.txt:

15:05 Changeset [76288] by dpranke@chromium.org

2011-01-20 Dirk Pranke <dpranke@chromium.org>

Reviewed by Eric Seidel.

nrwt: remove fs refs from printing, test_failures, test_expectations, text_diff

https://bugs.webkit.org/show_bug.cgi?id=52756

Scripts/webkitpy/layout_tests/layout_package/printing.py:
Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
Scripts/webkitpy/layout_tests/test_types/text_diff.py:

14:53 Changeset [76287] by jamesr@google.com

2011-01-20 James Robinson <jamesr@chromium.org>

Update expectations for tests that need chromium-side changes.

platform/chromium/test_expectations.txt:

14:50 Changeset [76286] by commit-queue@webkit.org

2011-01-20 Mansi Mithal <mansi.mithal@nokia.com>

Reviewed by Antonio Gomes.

QtTestBrowser should have a seperate menu for Settings
https://bugs.webkit.org/show_bug.cgi?id=52817

Added a new menu item named "Settings"
and moved the "Enable interrupting js scripts" and "Enable js pop up windows" under the "Settings" menu

QtTestBrowser/launcherwindow.cpp: (LauncherWindow::createChrome):

14:48 Changeset [76285] by andersca@apple.com

2011-01-20 Anders Carlsson <andersca@apple.com>

Reviewed by Adam Roben.

Add a timestamp to UpdateInfo
https://bugs.webkit.org/show_bug.cgi?id=52844

Shared/UpdateInfo.cpp: (WebKit::UpdateInfo::encode): (WebKit::UpdateInfo::decode):
Shared/UpdateInfo.h:
WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::setSize): (WebKit::DrawingAreaImpl::display):

14:44 Changeset [76284] by rniwa@webkit.org

2011-01-20 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed Chromium test expectation update.

Merged test_expectations.txt in the Chromium tree and
added slow to fast/text/large-text-composed-char-dos.html.

platform/chromium/test_expectations.txt:

14:30 Changeset [76283] by tony@chromium.org

2011-01-20 Tony Chang <tony@chromium.org>

Unreviewed, updating gpu expectations.
These two tests were added to the regular chromiumg test_expectations.txt
in r76228.

platform/chromium-gpu/test_expectations.txt:

14:12 Changeset [76282] by paroga@webkit.org

2011-01-20 Patrick Gansterer <paroga@webkit.org>

Unreviewed WinCE build fix for r76170.

platform/graphics/wince/FontWinCE.cpp: Added a missing include.
platform/graphics/wince/ImageBufferData.h: Added a missing include and fixed style.

14:07 Changeset [76281] by weinig@apple.com

Update update-webkit-localizable-strings with new path to WebKit.

Reviewed by John Sullivan.

Scripts/update-webkit-localizable-strings:

14:04 Changeset [76280] by andersca@apple.com

2011-01-20 Anders Carlsson <andersca@apple.com>

Reviewed by Beth Dakin.

Add Connection::waitForAndDispatchImmediately
https://bugs.webkit.org/show_bug.cgi?id=52841

Platform/CoreIPC/Connection.h: (CoreIPC::Connection::waitForAndDispatchImmediately):

14:01 Changeset [76279] by rniwa@webkit.org

2011-01-20 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed; Another Chromium rebaseline for r76236.

platform/chromium-linux/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.checksum: Added.
platform/chromium-linux/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.png: Added.
platform/chromium-win/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.checksum: Added.

13:50 Changeset [76278] by jamesr@google.com

2011-01-20 James Robinson <jamesr@chromium.org>

Reviewed by Darin Fisher.

Implement mozilla's requestAnimationFrame API
https://bugs.webkit.org/show_bug.cgi?id=51218

Tests for window.webkitRequestAnimationFrame(). The new tests
are in the Skipped lists for platforms that do not set
ENABLE(REQUEST_ANIMATION_FRAME) - which is currently all but chromium.

fast/animation/request-animation-frame-cancel-expected.txt: Added.
fast/animation/request-animation-frame-cancel.html: Added.

Tests cancelling a callback within a webkitRequestAnimationFrame() callback.

fast/animation/request-animation-frame-cancel2-expected.txt: Added.
fast/animation/request-animation-frame-cancel2.html: Added.

Tests interactions between multiple webkitRequestAnimationFrame() callbacks.

fast/animation/request-animation-frame-display-expected.txt: Added.
fast/animation/request-animation-frame-display.html: Added.

Tests changing the display: property of an element within a callback.

fast/animation/request-animation-frame-expected.txt: Added.
fast/animation/request-animation-frame.html: Added.

Tests the basic use of window.webkitRequestAnimationFrame().

fast/animation/request-animation-frame-within-callback-expected.txt: Added.
fast/animation/request-animation-frame-within-callback.html: Added.

Tests setting one webkit.webkitRequestAnimationFrame() callback within another.

platform/gtk/Skipped:
platform/mac/Skipped:
platform/qt/Skipped:
platform/win/Skipped:

2011-01-20 James Robinson <jamesr@chromium.org>

Reviewed by Darin Fisher.

Implement mozilla's requestAnimationFrame API
https://bugs.webkit.org/show_bug.cgi?id=51218

This implements mozilla's proposed requestAnimationFrame API. The idea with this API is that
an author driving an animation from script could use window.requestAnimationFrame(callback)
instead of window.setTimeout(callback, 0) to schedule their update logic and let the browser
decide when to update the animations. This avoids doing unnecessary work when the page content
is offscreen or is being displayed at a different framerate than what the page author expects.

Mozilla's proposal is here: https://developer.mozilla.org/en/DOM/window.mozRequestAnimationFrame
This implements window.mozRequestAnimationFrame as window.webkitRequestAnimationFrame with the
following changes:
*) Only the callback syntax is supported, there is no before paint event
*) webkitRequestAnimationFrame supports a second parameter Element to let the author indicate

what content they intend to animate. That way if the page is being displayed but the element
in question is offscreen, we can avoid invoking the callback.

*) No timestamp is provided to the caller and there is no window.animationStartTime property

(see https://bugs.webkit.org/show_bug.cgi?id=51952 for discussion of this property)

*) window.webkitRequestAnimationFrame returns a numerical id that can be used to cancel the callback

using window.cancelWebkitRequestAnimationFrame, to parallel window.setTimeout()/window.clearTime().

The implementation depends on the embedder scheduling the callbacks since the callback invocation
depends on the page's visibility and the embedder's paint scheduling, neither of which are exposed
to WebCore. The expectation for the embedder is that at some point Chrome::scheduleAnimation() is
called FrameView::serviceScriptedAnimations() should be called for the associated Page's main frame.
Ideally serviceScriptedAnimations() would be called prior to rendering - although in practice the
embedder has to rate limit callbacks and may not be able to tie the callback directly to the
rendering loop.

Tests: fast/animation/request-animation-frame-cancel.html

fast/animation/request-animation-frame-cancel2.html
fast/animation/request-animation-frame-display.html
fast/animation/request-animation-frame-within-callback.html
fast/animation/request-animation-frame.html

WebCore.gypi:
dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::webkitRequestAnimationFrame): (WebCore::Document::webkitCancelRequestAnimationFrame): (WebCore::Document::serviceScriptedAnimations):
dom/Document.h:
dom/RequestAnimationFrameCallback.h: Added. (WebCore::RequestAnimationFrameCallback::~RequestAnimationFrameCallback):
dom/RequestAnimationFrameCallback.idl: Added.
loader/EmptyClients.h: (WebCore::EmptyChromeClient::scheduleAnimation):
page/Chrome.cpp: (WebCore::Chrome::scheduleAnimation):
page/Chrome.h:
page/ChromeClient.h:
page/DOMWindow.cpp: (WebCore::DOMWindow::webkitRequestAnimationFrame): (WebCore::DOMWindow::webkitCancelRequestAnimationFrame):
page/DOMWindow.h:
page/DOMWindow.idl:
page/FrameView.cpp: (WebCore::FrameView::scheduleAnimation): (WebCore::FrameView::serviceScriptedAnimations):
page/FrameView.h:
platform/HostWindow.h:

2011-01-20 James Robinson <jamesr@chromium.org>

Reviewed by Darin Fisher.

Implement mozilla's requestAnimationFrame API
https://bugs.webkit.org/show_bug.cgi?id=51218

Chromium WebKit API support for window.webkitRequestAnimationFrame()

features.gypi:
public/WebWidget.h:
public/WebWidgetClient.h: (WebKit::WebWidgetClient::scheduleAnimation):
src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::scheduleAnimation):
src/ChromeClientImpl.h:
src/WebPopupMenuImpl.cpp: (WebKit::WebPopupMenuImpl::animate): (WebKit::WebPopupMenuImpl::scheduleAnimation):
src/WebPopupMenuImpl.h:
src/WebViewImpl.cpp: (WebKit::WebViewImpl::animate):
src/WebViewImpl.h:

2011-01-20 James Robinson <jamesr@chromium.org>

Reviewed by Darin Fisher.

Implement mozilla's requestAnimationFrame API
https://bugs.webkit.org/show_bug.cgi?id=51218

Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.

DumpRenderTree/chromium/WebViewHost.cpp: (invokeScheduleComposite): (WebViewHost::scheduleAnimation): (WebViewHost::paintInvalidatedRegion):
DumpRenderTree/chromium/WebViewHost.h:

13:39 Changeset [76277] by jamesr@google.com

2011-01-20 James Robinson <jamesr@chromium.org>

Reviewed by Nate Chapin.

[v8] CodeGeneratorV8 generates incorrect code for callbacks with no parameters
https://bugs.webkit.org/show_bug.cgi?id=52837

When generating code to invoke a callback with no parameters CodeGeneratorV8.pm was generating the following:
v8::Handle<v8::Value> argv[] = {}; which does not compile in visual studio. Instead, if the argument count
is 0, we can just pass a NULL pointer for the argv parameter.

Test added to bindings/scripts/test/TestCallback.idl and covered by run-bindings-tests. This
patch also includes some spurious changes to the bindings tests golden files (mostly GObject)
because the old golden files were out of date.

bindings/scripts/CodeGeneratorV8.pm:
bindings/scripts/test/CPP/WebDOMTestCallback.cpp: (WebDOMTestCallback::callbackWithNoParam):
bindings/scripts/test/CPP/WebDOMTestCallback.h:
bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp: (webkit_dom_test_callback_callback_with_no_param):
bindings/scripts/test/GObject/WebKitDOMTestCallback.h:
bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp:
bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListener.cpp:
bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
bindings/scripts/test/JS/JSTestCallback.cpp: (WebCore::JSTestCallback::callbackWithNoParam):
bindings/scripts/test/JS/JSTestCallback.h:
bindings/scripts/test/JS/JSTestInterface.cpp:
bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
bindings/scripts/test/JS/JSTestObj.cpp:
bindings/scripts/test/ObjC/DOMTestCallback.h:
bindings/scripts/test/ObjC/DOMTestCallback.mm: (-[DOMTestCallback callbackWithNoParam]):
bindings/scripts/test/TestCallback.idl:
bindings/scripts/test/V8/V8TestCallback.cpp: (WebCore::V8TestCallback::callbackWithNoParam):
bindings/scripts/test/V8/V8TestCallback.h:
bindings/scripts/test/V8/V8TestObj.cpp: (WebCore::TestObjInternal::reflectedUnsignedIntegralAttrAttrGetter):

13:34 Changeset [76276] by jamesr@google.com

2011-01-20 James Robinson <jamesr@chromium.org>

Reviewed by Eric Seidel.

RenderTableSection's setNeedsCellRecalc needs to null check table()
https://bugs.webkit.org/show_bug.cgi?id=52770

Tests ::-webkit-scrollbar-corner inside a table.

fast/css-generated-content/table-with-scrollbar-corner-expected.txt: Added.
fast/css-generated-content/table-with-scrollbar-corner.html: Added.

2011-01-20 James Robinson <jamesr@chromium.org>

Reviewed by Eric "Baller" Seidel.

RenderTableSection's setNeedsCellRecalc needs to null check table()
https://bugs.webkit.org/show_bug.cgi?id=52770

Null checks table() before deferencing it in RenderTableSection::setNeedsCellRecalc.
This can be null during detach(). Test constructed by Eric Seidel.

Test: fast/css-generated-content/table-with-scrollbar-corner.html

rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::setNeedsCellRecalc):
rendering/RenderTableSection.h:

13:31 Changeset [76275] by msaboff@apple.com

2011-01-20 Michael Saboff <msaboff@apple.com>

Reviewed by Oliver Hunt.

<rdar://problem/8890203> [RegexFuzz] Crash in generated code (52773)
https://bugs.webkit.org/show_bug.cgi?id=52773

Fixed case where an existing DataLabelPtr is overwritten. The
replacing DataLabelPtr is now resolved immediately in
linkDataLabelToBacktrackIfExists(). Cleanup - eliminated bool
return value for the routine as it was never used.

yarr/YarrJIT.cpp: (JSC::Yarr::YarrGenerator::TermGenerationState::linkDataLabelToBacktrackIfExists):

2011-01-20 Michael Saboff <msaboff@apple.com>

Reviewed by Oliver Hunt.

<rdar://problem/8890203> [RegexFuzz] Crash in generated code (52773)
https://bugs.webkit.org/show_bug.cgi?id=52773

New test to validate fix.

fast/regex/parentheses-expected.txt:
fast/regex/script-tests/parentheses.js:

13:26 Changeset [76274] by krit@webkit.org

2011-01-20 Dirk Schulze <krit@webkit.org>

Reviewed by Rob Buis.

SVG Pattern doesn't take preserveAspectRatio of references Pattern
https://bugs.webkit.org/show_bug.cgi?id=52802

SVGPattern didn't take preserveAspectRatio of a referenced SVGPattern into account. Store preserveAspectRatio
in PatternAttributes as well, if the attribute was set on the referenced SVGPattern element.

Test: svg/custom/pattern-referencing-preserve-aspect-ratio.svg

rendering/svg/RenderSVGResourcePattern.cpp: (WebCore::RenderSVGResourcePattern::buildTileImageTransform):
svg/PatternAttributes.h: (WebCore::PatternAttributes::PatternAttributes): (WebCore::PatternAttributes::preserveAspectRatio): (WebCore::PatternAttributes::setPreserveAspectRatio): (WebCore::PatternAttributes::hasPreserveAspectRatio):
svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::collectPatternAttributes):

2011-01-20 Dirk Schulze <krit@webkit.org>

Reviewed by Rob Buis.

SVG Pattern doesn't take preserveAspectRatio of references Pattern
https://bugs.webkit.org/show_bug.cgi?id=52802

Added a test case to check that we take preserveAspectRatio of a referenced SVGPattern into account.

platform/mac/svg/custom/pattern-referencing-preserve-aspect-ratio-expected.checksum: Added.
platform/mac/svg/custom/pattern-referencing-preserve-aspect-ratio-expected.png: Added.
platform/mac/svg/custom/pattern-referencing-preserve-aspect-ratio-expected.txt: Added.
svg/custom/pattern-referencing-preserve-aspect-ratio.svg: Added.

12:47 Changeset [76273] by mitz@apple.com

<rdar://problem/8765498> REGRESSION (r72141): Cannot order prints with Aperture 3.1

Reviewed by Adele Peterson.

<rdar://problem/8884648> REGRESSION (r72141): Safari hangs when visiting a page on www.bfmtv.com
https://bugs.webkit.org/show_bug.cgi?id=52765

<rdar://problem/8890909> REGRESSION (r72141): Very Slow Rendering With Certain Markup
https://bugs.webkit.org/show_bug.cgi?id=52265

Source/WebCore:

Test: fast/block/line-layout/negative-max-height.html

Integer overflow detection led to a block having a huge height. This manifested as broken layout
in the first bug and as extreme slowness in the latter bugs because of
https://bugs.webkit.org/show_bug.cgi?id=52832

rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::alignBoxesInBlockDirection): Clamp maxHeight to 0 so the next line
cannot start above this line. The negative maxHeight also caused the integer overflow detection
logic to give the block a huge height.

LayoutTests:

fast/block/line-layout: Added.
fast/block/line-layout/negative-max-height-expected.checksum: Added.
fast/block/line-layout/negative-max-height-expected.png: Added.
fast/block/line-layout/negative-max-height-expected.txt: Added.
fast/block/line-layout/negative-max-height.html: Added.

12:41 Changeset [76272] by yi.4.shen@nokia.com

2011-01-20 Yi Shen <yi.4.shen@nokia.com>

Reviewed by Eric Carlson.

Clean up the Media Controls CSS for Qt
https://bugs.webkit.org/show_bug.cgi?id=52822

Split the audio::-webkit-media-xxx and video::-webkit-media-xxx rules
in mediaControlsQt.css, and remove the duplicate audio::-webkit-media-xxx
rules from mediaControlsQtFullscreen.css.

css/mediaControlsQt.css: (audio::-webkit-media-controls-panel): (video::-webkit-media-controls-panel): (audio::-webkit-media-controls-mute-button): (video::-webkit-media-controls-mute-button): (audio::-webkit-media-controls-play-button): (video::-webkit-media-controls-play-button): (audio::-webkit-media-controls-timeline-container): (video::-webkit-media-controls-timeline-container): (audio::-webkit-media-controls-current-time-display): (video::-webkit-media-controls-current-time-display): (audio::-webkit-media-controls-time-remaining-display): (video::-webkit-media-controls-time-remaining-display): (audio::-webkit-media-controls-timeline): (video::-webkit-media-controls-timeline): (audio::-webkit-media-controls-volume-slider-container): (video::-webkit-media-controls-volume-slider-container): (audio::-webkit-media-controls-volume-slider): (video::-webkit-media-controls-volume-slider): (audio::-webkit-media-controls-seek-back-button): (video::-webkit-media-controls-seek-back-button): (audio::-webkit-media-controls-seek-forward-button): (video::-webkit-media-controls-seek-forward-button): (audio::-webkit-media-controls-fullscreen-button): (video::-webkit-media-controls-fullscreen-button): (audio::-webkit-media-controls-rewind-button): (video::-webkit-media-controls-rewind-button): (audio::-webkit-media-controls-return-to-realtime-button): (video::-webkit-media-controls-return-to-realtime-button): (audio::-webkit-media-controls-toggle-closed-captions-button): (video::-webkit-media-controls-toggle-closed-captions-button):
css/mediaControlsQtFullscreen.css: (video::-webkit-media-controls-time-remaining-display): (video::-webkit-media-controls-seek-back-button): (video::-webkit-media-controls-seek-forward-button): (video::-webkit-media-controls-rewind-button): (video::-webkit-media-controls-return-to-realtime-button): (video::-webkit-media-controls-toggle-closed-captions-button):

12:32 Changeset [76271] by ojan@chromium.org

2011-01-20 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

fix goofup in http://trac.webkit.org/changeset/76082
https://bugs.webkit.org/show_bug.cgi?id=52830

We were showing the revision number of the patch at the bottom
of the diff and expanding from the bottom of the diff would fail.

Also, removed an unused variable and scoped queries appropriatly
to the file_diff they should have been operating on.

PrettyPatch/PrettyPatch.rb:
code-review.js:

12:30 Changeset [76270] by ojan@chromium.org

2011-01-19 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

[reviewtool] Add a link for annotated trac page on review page
https://bugs.webkit.org/show_bug.cgi?id=52747

-add line numbers to all trac links to the first line in the file diff
-add annotate/review log links
-make file-diff links other than the file name only show when you mouseover the filediff
-fix white-space to only wrap the .text element and it's childen, any of it's siblings/parents

PrettyPatch/PrettyPatch.rb:
code-review.js:

12:30 Changeset [76269] by rniwa@webkit.org

2011-01-20 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed Chromium rebaseline for r76236.

platform/chromium-win/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.png: Added.
platform/chromium-win/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.txt: Added.

11:21 Changeset [76268] by ojan@chromium.org

2011-01-14 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

make line selection have a extend only from where you start the selection in the code review tool
https://bugs.webkit.org/show_bug.cgi?id=52485

code-review.js:

11:07 Changeset [76267] by kdecker@apple.com

Reviewed by Anders Carlsson.

<rdar://problem/8880689> need a way to obtain the rendered rectangle for box elements
https://bugs.webkit.org/show_bug.cgi?id=52823

WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.cpp: (WKBundleNodeHandleGetRenderRect): Added new method that will return a rendered rectangle for box elements
WebProcess/InjectedBundle/API/c/WKBundleNodeHandlePrivate.h: Ditto.
WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp: Ditto. (WebKit::InjectedBundleNodeHandle::renderRect): Ditto.
WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h: Ditto.

10:31 Changeset [76266] by apavlov@chromium.org

2011-01-20 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [REGRESSION] Canceling of CSS numeric values increment/decrement is broken
https://bugs.webkit.org/show_bug.cgi?id=52816

inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertyTreeElement.prototype):

10:24 Changeset [76265] by commit-queue@webkit.org

2011-01-20 Dawit Alemayehu <adawit@kde.org>

Reviewed by Andreas Kling.

[Qt] Fix Layering violation in MediaPlayerPrivateQt.
https://bugs.webkit.org/show_bug.cgi?id=52733

No new tests. no behavioral change.

platform/graphics/qt/MediaPlayerPrivateQt.cpp: (WebCore::MediaPlayerPrivateQt::commitLoad):

10:20 Changeset [76264] by japhet@chromium.org

2011-01-20 Nate Chapin <japhet@chromium.org>

Reviewed by Darin Fisher.

[V8] Call malloc and memcpy directly instead of
of strdup in convertV8ObjectToNPVariant() when
converting strings. If there is a null character
in the string, our use of strdup causes us to allocate
too little memory, leading to out of bounds reads.

https://bugs.webkit.org/show_bug.cgi?id=52631

bindings/v8/V8NPUtils.cpp: (WebCore::convertV8ObjectToNPVariant):

10:13 Changeset [76263] by abecsi@webkit.org

2011-01-20 Andras Becsi <abecsi@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt][WK2] WebKit2 enabled build fails to link

Work around undefined reference linking issues until the buildsystem gets redesigned.
These issues first occured in minimal builds (see BUG 50519).

JavaScriptCore.pri: link as whole-archive for WebKit2 builds

10:08 Changeset [76262] by commit-queue@webkit.org

2011-01-20 Kimmo Kinnunen <kimmo.t.kinnunen@nokia.com>

Reviewed by Andreas Kling.

Remove null ptr deref that happens when reattaching to
a new web process.

Implement didRelaunchProcess that sets the drawing area size
after the drawing area is re-instantiated.

[Qt][WK2] Null ptr deref in UI process after web process has crashed
https://bugs.webkit.org/show_bug.cgi?id=52796

UIProcess/API/qt/qgraphicswkview.cpp: (QGraphicsWKView::QGraphicsWKView):
UIProcess/API/qt/qwkpage.cpp: (QWKPagePrivate::QWKPagePrivate): (QWKPagePrivate::init): (QWKPagePrivate::createDrawingAreaProxy): (QWKPagePrivate::didRelaunchProcess): Reset drawing area size after crash.
UIProcess/API/qt/qwkpage_p.h:

10:07 Changeset [76261] by philn@webkit.org

2011-01-20 Philippe Normand <pnormand@igalia.com>

Unreviewed, remove GTK result for window-onerror2 as it's the same
as the generic results file.

platform/gtk/fast/events/window-onerror2-expected.txt: Removed.

09:49 Changeset [76260] by andreas.kling@nokia.com

2011-01-20 Andreas Kling <kling@webkit.org>

Reviewed by Ariya Hidayat.

[Qt] Fill shadow scratch buffer with proper transparent pixels

QImage::fill() has no Qt::GlobalColor overload in Qt 4.7 (coming in 4.8)
so doing QImage::fill(Qt::transparent) will actually fill all pixels with
the RGBA value 0x00000013.

platform/graphics/qt/ContextShadowQt.cpp: (WebCore::ShadowBuffer::scratchImage):

09:15 Changeset [76259] by mjs@apple.com

2011-01-20 Maciej Stachowiak <mjs@apple.com>

Reviewed by Adam Roben.

WebKitTestRunner needs to support layoutTestController.evaluateScriptInIsolatedWorld
https://bugs.webkit.org/show_bug.cgi?id=42327

platform/mac-wk2/Skipped: Unskip the tests that needed this.

2011-01-20 Maciej Stachowiak <mjs@apple.com>

Reviewed by Adam Roben.

WebKitTestRunner needs to support layoutTestController.evaluateScriptInIsolatedWorld
https://bugs.webkit.org/show_bug.cgi?id=42327

Added a new API call, WKBundleFrameForJavaScriptContext, that gets the WKBundleFrameRef
that corresponds to a JSContextRef (or null if none).

WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp: (WKBundleFrameForJavaScriptContext): Simple wrapper, defers to a WebFrame static method.
WebProcess/InjectedBundle/API/c/WKBundleFrame.h:
WebProcess/WebPage/WebFrame.cpp: (WebKit::WebFrame::frameForContext): Follow the maze of twisty pointers.
WebProcess/WebPage/WebFrame.h:

2011-01-20 Maciej Stachowiak <mjs@apple.com>

Reviewed by Adam Roben.

WebKitTestRunner needs to support layoutTestController.evaluateScriptInIsolatedWorld
https://bugs.webkit.org/show_bug.cgi?id=42327

WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Add support for methods that take their normal arguments but also a JSContextRef.
WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: IDL definition for evaluateScriptInIsolatedWorld.
WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::didClearWindowForFrame): Set a magic variable only if this call is for an isolated world.
WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::worldMap): Helper to create a world map. (WTR::LayoutTestController::worldIDForWorld): Map from an ID to a world. (WTR::LayoutTestController::evaluateScriptInIsolatedWorld): The newly added LayoutTestController API.
WebKitTestRunner/InjectedBundle/LayoutTestController.h:

09:12 Changeset [76258] by aroben@apple.com

Remove WKCACFContextFlusher

It wasn't doing anything.

Fixes <http://webkit.org/b/52752> WKCACFContextFlusher is unused

Reviewed by Simon Fraser.

WebCore.vcproj/WebCore.vcproj: Removed WKCACFContextFlusher. Also let VS have its way with

the file.

platform/graphics/win/WKCACFContextFlusher.cpp: Removed.
platform/graphics/win/WKCACFContextFlusher.h: Removed.

platform/graphics/win/WKCACFLayerRenderer.cpp:

(WebCore::WKCACFLayerRenderer::~WKCACFLayerRenderer):
(WebCore::WKCACFLayerRenderer::layerTreeDidChange):
Stop telling WKCACFContextFlusher about our context, since it never did anything with it.

09:12 Changeset [76257] by aroben@apple.com

Only flush our own context when we get resized

Fixes <http://webkit.org/b/52751> All WKCACFContexts with uncommitted
changes get flushed whenever any composited page is resized

Reviewed by Simon Fraser.

platform/graphics/win/WKCACFLayerRenderer.cpp:

(WebCore::WKCACFLayerRenderer::resize): Just flush our own context, not all contexts
WKCACFContextFlusher knows about. After all, ours is the only one that just got resized!

09:11 Changeset [76256] by aroben@apple.com

Make WKCACFLayerRenderer ref-counted

This will be needed to handle cases where the client might release its reference to us while
we're calling out to it.

WKCACFLayerRenderer now has a setClient function, which is used rather than passing the
client to create(). This allows clients to null out the client pointer when they're done
with the renderer.

Fixes <http://webkit.org/b/52749> WKCACFLayerRenderer should be
ref-counted

Reviewed by Simon Fraser.

Source/WebCore:

platform/graphics/win/MediaPlayerPrivateFullscreenWindow.cpp:

(WebCore::MediaPlayerPrivateFullscreenWindow::MediaPlayerPrivateFullscreenWindow):

platform/graphics/win/MediaPlayerPrivateFullscreenWindow.h:

Updated for WKCACFLayerRenderer changes.

platform/graphics/win/WKCACFLayerRenderer.cpp:

(WebCore::WKCACFLayerRenderer::acceleratedCompositingAvailable): Updated for changes to
create().
(WebCore::WKCACFLayerRenderer::create): No longer takes a WKCACFLayerRendererClient. Now
returns a PassOwnPtr.
(WebCore::WKCACFLayerRenderer::WKCACFLayerRenderer): No longer takes a
WKCACFLayerRendererClient.

platform/graphics/win/WKCACFLayerRenderer.h: Made WKCACFLayerRenderer inherit from

RefCounted.
(WebCore::WKCACFLayerRenderer::setClient): Added this simple setter.

Source/WebKit/win:

Update for WKCACFLayerRenderer changes

WebView.cpp:

(WebView::~WebView): Added some assertions to make sure we've gotten rid of our
compositing-related members. My biggest concern was making sure that m_layerRenderer was
gone, which would also mean we had nulled out its client pointer.
(WebView::setAcceleratedCompositing): Changed to call WKCACFLayerRenderer::setClient instead
of passing the client into create(), and to clear out the client before nulling out
m_layerRenderer.

WebView.h: Changed m_layerRenderer from an OwnPtr to a RefPtr.

09:11 Changeset [76255] by aroben@apple.com

Convert paths in environment variables back to msys-style inside commit-log-editor

When this script gets run from inside git commit, msys-style paths in the environment will
have been turned into Windows-style paths with forward slashes. This screws up functions
like File::Spec->rel2abs, which seem to rely on $PWD having an msys-style path. We convert
the paths back to msys-style before doing anything else.

Fixes <http://webkit.org/b/48527> commit-log-editor uses full paths for section headers when
using msysgit's Perl and multiple ChangeLogs have been edited

Reviewed by David Kilzer.

Scripts/commit-log-editor: Call fixEnvironment before doing anything else.

(fixEnvironment): Added. When run in msys in conjunction with git (i.e., when invoked from
inside git commit), convert Windows-style paths in the environment back to msys-style paths.

09:10 Changeset [76254] by aroben@apple.com

Teach WebView::scrollBackingStore about compositing mode

Test:

compositing/scroll-painted-composited-content.html

Fixes <http://webkit.org/b/52720> REGRESSION (r75987): Assertion failure in
WebView::scrollBackingStore when scrolling page with composited content

Reviewed by Anders Carlsson.

Source/WebKit/win:

WebView.cpp:

(WebView::scrollBackingStore): Do something sensible (though naive) when in compositing
mode, rather than incorrectly asserting that this function is never called in that case. For
now we just repaint the entire scrolled region; someday hopefully we can avoid having to
repaint the areas that have just been moved.

LayoutTests:

Add a test that scrolls composited content that has already been painted

compositing/scroll-painted-composited-content.html: Added.
compositing/scroll-painted-composited-content-expected.txt: Added.

09:08 Changeset [76253] by zoltan@webkit.org

[Win] Unreviewed build fix after r76248.

DumpRenderTree/ForwardingHeaders/wtf/FastAllocBase.h: Added.

08:55 Changeset [76252] by alex@webkit.org

2011-01-20 Alejandro G. Castro <alex@igalia.com>

Fix compilation error in GTK WebKit2.

Platform/CoreIPC/gtk/ConnectionGtk.cpp: (CoreIPC::readBytesFromSocket): (CoreIPC::writeBytesToSocket):

08:54 Changeset [76251] by ossy@webkit.org

[Qt][V8] Unreviewed buildfix after r76248.

bindings/v8/ScriptCachedFrameData.h: Add missing include.

08:53 Changeset [76250] by alex@webkit.org

2011-01-20 Alejandro G. Castro <alex@igalia.com>

Reviewed by Andreas Kling.

[GTK] Fix typo in the webkit2 section of the configure.ac file
https://bugs.webkit.org/show_bug.cgi?id=52801

Fixed typo in the GTK WebKit2 compilation.

configure.ac:

08:49 Changeset [76249] by pfeldman@chromium.org

2011-01-20 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: enable resource agent upon request.
https://bugs.webkit.org/show_bug.cgi?id=52815

We should not send network-related notifications unless front-end
is interested.

inspector/Inspector.idl:
inspector/InspectorController.cpp: (WebCore::InspectorController::restoreInspectorStateFromCookie): (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::resourceAgent):
inspector/InspectorController.h: (WebCore::InspectorController::consoleAgent): (WebCore::InspectorController::cssAgent): (WebCore::InspectorController::domAgent): (WebCore::InspectorController::injectedScriptAgent): (WebCore::InspectorController::runtimeAgent): (WebCore::InspectorController::databaseAgent): (WebCore::InspectorController::domStorageAgent): (WebCore::InspectorController::fileSystemAgent):
inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::retrieveResourceAgent):
inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::restore): (WebCore::InspectorResourceAgent::~InspectorResourceAgent): (WebCore::InspectorResourceAgent::InspectorResourceAgent):
inspector/InspectorResourceAgent.h: (WebCore::InspectorResourceAgent::create):
inspector/InspectorState.cpp: (WebCore::InspectorState::InspectorState):
inspector/InspectorState.h:

08:30 Changeset [76248] by ossy@webkit.org

Refactoring of the custom allocation framework
https://bugs.webkit.org/show_bug.cgi?id=49897

Patch by Zoltan Horvath <zoltan@webkit.org> on 2011-01-20
Reviewed by Csaba Osztrogonác.

Source/JavaScriptCore:

Inheriting from FastAllocBase can result in objects getting larger (bug #33896, #46589).
The modification replaces Noncopyable and FastAllocBase classes and these inherits with their
equivalent macro implementation at the necessary places.

wtf/FastAllocBase.h: Turn FastAllocBase's implementation into a macro.

Source/WebCore:

Source/WebKit:

Source/WebKit2:

Tools:

08:21 Changeset [76247] by mnaganov@chromium.org

2011-01-20 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Chromium] CPU Profiles are cleared when navigating back and forth.

Profiles are now not cleared unless renderer instance was changed.

https://bugs.webkit.org/show_bug.cgi?id=52807

inspector/InspectorController.cpp: (WebCore::InspectorController::restoreProfiler):
inspector/InspectorProfilerAgent.cpp: (WebCore::InspectorProfilerAgent::resetState): (WebCore::InspectorProfilerAgent::resetFrontendProfiles):
inspector/InspectorProfilerAgent.h:

07:59 Changeset [76246] by apavlov@chromium.org

2011-01-20 Alexander Pavlov <apavlov@chromium.org>

Unreviewed, add new JS file refs missing from r76116.

WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
inspector/front-end/WebKit.qrc:

07:46 Changeset [76245] by apavlov@chromium.org

2011-01-20 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Crash when adding a rule for an ImageDocument
https://bugs.webkit.org/show_bug.cgi?id=52811

inspector/InspectorCSSAgent.cpp: (WebCore::InspectorCSSAgent::addRule2): (WebCore::InspectorCSSAgent::viaInspectorStyleSheet):

07:38 Changeset [76244] by yurys@chromium.org

2011-01-20 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Make fast/events/window-onerror2.html throw exception in deterministic order
https://bugs.webkit.org/show_bug.cgi?id=52813

fast/events/window-onerror2-expected.txt:
fast/events/window-onerror2.html: call setTimeout from onload handler to make sure exception in the onload handler will be processed before the one in the setTimeout callback
platform/chromium/fast/events/window-onerror2-expected.txt:

07:32 Changeset [76243] by yi.4.shen@nokia.com

2011-01-20 Yi Shen <yi.4.shen@nokia.com>

Unreviewed.

Adding myself to committers.py.

Scripts/webkitpy/common/config/committers.py:

07:00 Changeset [76242] by philn@webkit.org

2011-01-20 Philippe Normand <pnormand@igalia.com>

Unreviewed, new GTK svg test baselines as follow-up of r76236.

platform/gtk/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.txt: Added.

06:52 Changeset [76241] by philn@webkit.org

2011-01-20 Philippe Normand <pnormand@igalia.com>

Unreviewed, update window-onerror2.html baselines as follow-up of r76216.

platform/gtk/fast/events/window-onerror2-expected.txt:

06:50 Changeset [76240] by loislo@chromium.org

2011-01-20 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: cleanup InspectorController's friends list.
We have a plan to extract InspectorAgent from InspectorController.
InspectorAgent will be accessible only from InspectorController.
As result we can simply made some methods public and remove long
friends list.

https://bugs.webkit.org/show_bug.cgi?id=52806

inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::databaseForId): (WebCore::InjectedScriptHost::selectDatabase): (WebCore::InjectedScriptHost::selectDOMStorage): (WebCore::InjectedScriptHost::inspectorDOMAgent): (WebCore::InjectedScriptHost::frontend):
inspector/InspectorBrowserDebuggerAgent.cpp: (WebCore::InspectorBrowserDebuggerAgent::setDOMBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::removeDOMBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::willInsertDOMNode): (WebCore::InspectorBrowserDebuggerAgent::willRemoveDOMNode): (WebCore::InspectorBrowserDebuggerAgent::willModifyDOMAttr): (WebCore::InspectorBrowserDebuggerAgent::descriptionForDOMEvent): (WebCore::InspectorBrowserDebuggerAgent::pauseOnNativeEventIfNeeded): (WebCore::InspectorBrowserDebuggerAgent::willSendXMLHttpRequest):
inspector/InspectorController.h: (WebCore::InspectorController::frontend):
inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::willInsertDOMNodeImpl): (WebCore::InspectorInstrumentation::didInsertDOMNodeImpl): (WebCore::InspectorInstrumentation::willRemoveDOMNodeImpl): (WebCore::InspectorInstrumentation::didRemoveDOMNodeImpl): (WebCore::InspectorInstrumentation::willModifyDOMAttrImpl): (WebCore::InspectorInstrumentation::didModifyDOMAttrImpl): (WebCore::InspectorInstrumentation::characterDataModifiedImpl): (WebCore::InspectorInstrumentation::willSendXMLHttpRequestImpl): (WebCore::InspectorInstrumentation::didReceiveResourceResponseImpl): (WebCore::InspectorInstrumentation::didFailLoadingImpl): (WebCore::InspectorInstrumentation::resourceRetrievedByXMLHttpRequestImpl): (WebCore::InspectorInstrumentation::addStartProfilingMessageToConsoleImpl): (WebCore::InspectorInstrumentation::pauseOnNativeEventIfNeeded): (WebCore::InspectorInstrumentation::cancelPauseOnNativeEvent): (WebCore::InspectorInstrumentation::retrieveTimelineAgent): (WebCore::InspectorInstrumentation::retrieveResourceAgent):

06:47 Changeset [76239] by podivilov@chromium.org

2011-01-19 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: implement JavaScriptBreakpointsSidebarPane based on events from debugger model.
https://bugs.webkit.org/show_bug.cgi?id=52723

Extract all breakpoints-related presentation code from debugger model to JavaScriptBreakpointSidebarPane.

inspector/front-end/Breakpoint.js: (WebInspector.Breakpoint): (WebInspector.Breakpoint.prototype.get data): (WebInspector.Breakpoint.prototype.remove):
inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.JavaScriptBreakpointsSidebarPane): (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._breakpointAdded): (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._breakpointRemoved): (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._breakpointEnableChanged): (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._breakpointItemCheckboxClicked): (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._contextMenuEventFired): (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._debuggerPaused): (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._debuggerResumed): (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._addListElement): (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._removeListElement): (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._projectChanged): (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._compare): (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._compareBreakpoints): (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._setupBreakpointElement.didGetSourceLine): (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._setupBreakpointElement): (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._breakpointIdForDebuggerPausedEvent): (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._setBreakpointEnabled): (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._removeBreakpoint): (WebInspector.NativeBreakpointsSidebarPane): (WebInspector.XHRBreakpointsSidebarPane.prototype.addBreakpointItem):
inspector/front-end/DebuggerModel.js: (WebInspector.DebuggerModel.prototype.removeBreakpoint): (WebInspector.DebuggerModel.prototype.breakpointForId): (WebInspector.DebuggerModel.prototype._pausedScript): (WebInspector.DebuggerModel.prototype._resumedScript):
inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel):
inspector/front-end/inspector.js:

06:28 Changeset [76238] by philn@webkit.org

2011-01-20 Philippe Normand <pnormand@igalia.com>

Unreviewed, new GTK baselines for 2 new tests.

platform/gtk/fast/block/float/float-overflow-hidden-containing-block-width-expected.txt: Added.
platform/gtk/svg/css/text-gradient-shadow-expected.txt: Added.

06:23 Changeset [76237] by yurys@chromium.org

2011-01-20 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Update Chromium test expectations.

platform/chromium-win/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-document-write-expected.txt:
platform/chromium-win/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-javascript-url-expected.txt:
platform/chromium-win/http/tests/security/xss-DENIED-frame-name-expected.txt:

06:11 Changeset [76236] by krit@webkit.org

2011-01-20 Dirk Schulze <krit@webkit.org>

Reviewed by Andreas Kling.

SVG Pattern doesn't take the viewBox of a referenced Pattern
https://bugs.webkit.org/show_bug.cgi?id=52804

SVGPattern element didn't use the viewBox of another SVGPattern element, referenced
by xlink:href. Modified PatternAttributes, to take the value of the viewBox of the
SVGPattern element as well, if the attribute was set.
This gets checked by a W3C SVG test case.

Test: svg/W3C-SVG-1.1-SE/pservers-pattern-04-f.svg

rendering/svg/RenderSVGResourcePattern.cpp: (WebCore::RenderSVGResourcePattern::buildTileImageTransform):
svg/PatternAttributes.h: (WebCore::PatternAttributes::PatternAttributes): (WebCore::PatternAttributes::viewBox): (WebCore::PatternAttributes::setViewBox): (WebCore::PatternAttributes::hasViewBox):
svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::collectPatternAttributes):

2011-01-20 Dirk Schulze <krit@webkit.org>

Reviewed by Andreas Kling.

SVG Pattern doesn't take the viewBox of a referenced Pattern
https://bugs.webkit.org/show_bug.cgi?id=52804

Added a test case of the W3C SVG test suite to check, if we take
the viewBox of a referenced SVGPattern.

svg/W3C-SVG-1.1-SE/pservers-pattern-04-f.svg: Added.
platform/mac/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.checksum
platform/mac/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.png
platform/mac/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.txt

05:48 Changeset [76235] by senorblanco@chromium.org

2011-01-19 Stephen White <senorblanco@chromium.org>

[Re-land of r76159 with a compile fix for the Chromium linux shlib
build.]

Reviewed by James Robinson.

Implement accelerated path drawing and clipping for the Canvas2D GPU
path.
https://bugs.webkit.org/show_bug.cgi?id=52627

This is done with a simple curve interpolator and the GLU tesselator,
which is good enough for a 3-5X speedup on
http://ie.microsoft.com/testdrive/Performance/Galactic/Default.html.

Covered by canvas/philip/2d.path.clip.basic.html, and many, many more.
All tests canvas/philip and fast/canvas paths pass with no
regressions, although two have minor pixel differences which require
rebaselining.

WebCore.gyp/WebCore.gyp: Add internal_glu include path to chromium build.
WebCore.gypi: Add internal_glu files to chromium build.
html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::reset): (WebCore::CanvasRenderingContext2D::platformLayer): Make CanvasRenderingContext2D more robust against failure to create a DrawingBuffer.
platform/graphics/chromium/DrawingBufferChromium.cpp: (WebCore::DrawingBuffer::DrawingBuffer): As in DrawingBufferMac.cpp, call reset() from the constructor. Also initialize size to (-1, -1), so reset() doesn't early-out. Add initializers for depthBuffer and stencilBuffer, and remove multisampleDepthStencilBuffer.
platform/graphics/chromium/GLES2Canvas.cpp: Remove some unused #includes. (WebCore::GLES2Canvas::State::State): Add clipping state, and implement save/restore via the copy constructor. (WebCore::operator*): (WebCore::Quadratic::Quadratic): (WebCore::Quadratic::fromBezier): (WebCore::Quadratic::evaluate): Quadratic Bezier curve class. (WebCore::Cubic::Cubic): (WebCore::Cubic::fromBezier): (WebCore::Cubic::evaluate): Cubic Bezier curve class. (WebCore::GLES2Canvas::clearRect): Add clipping support to clearRect(). (WebCore::GLES2Canvas::fillPath): Implement fillPath(). (WebCore::GLES2Canvas::fillRect): Add clipping support to fillRect(). (WebCore::GLES2Canvas::clipPath): Implement clipPath(). (WebCore::GLES2Canvas::clipOut): Stub out clipOut() (not called by Canvas 2D). (WebCore::GLES2Canvas::restore): When restoring, draw any remaining clipping paths to the stencil buffer. (WebCore::GLES2Canvas::drawTexturedRect): Add clipping support. (WebCore::interpolateQuadratic): (WebCore::interpolateCubic): Simple curve interpolation, using the Cubic and Quadratic classes. (WebCore::PolygonData::PolygonData): A struct to hold the tesselation data for callbacks. (WebCore::beginData): (WebCore::edgeFlagData): (WebCore::vertexData): (WebCore::endData): (WebCore::combineData): internal_glu tesselation callbacks. (WebCore::GLES2Canvas::createVertexBufferFromPath): Build an interpolated, tesselated vertex buffer and element array buffer from a given path, suitable for filling. (WebCore::GLES2Canvas::beginStencilDraw): Enable stencilling, and disable draws to the color buffer. (WebCore::GLES2Canvas::applyClipping): If clipping is enabled, set the appropriate GL state.
platform/graphics/chromium/GLES2Canvas.h: Document the flavours of drawTexturedRect() a bit, so I don't get confused.
platform/graphics/gpu/DrawingBuffer.cpp: (WebCore::DrawingBuffer::clear): (WebCore::DrawingBuffer::createSecondaryBuffers): (WebCore::DrawingBuffer::resizeDepthStencil): (WebCore::DrawingBuffer::reset):
platform/graphics/gpu/DrawingBuffer.h: Unify m_multisampleDepthStencilBuffer with m_depthStencilBuffer. Implement separate depth and stencil buffers for when OES_packed_depth_stencil is not available. Refactor creation of multisampled and non-multisampled depth and stencil buffers into resizeDepthStencil().
platform/graphics/gpu/SharedGraphicsContext3D.cpp: (WebCore::SharedGraphicsContext3D::create): Turn on stencil, turn off depth, turn off antialiasing (for now). (WebCore::SharedGraphicsContext3D::enableStencil):
platform/graphics/gpu/SharedGraphicsContext3D.h: Implement stencil enable/disable.
platform/graphics/gpu/mac/DrawingBufferMac.mm: (WebCore::DrawingBuffer::DrawingBuffer): Remove m_multisampleDepthStencilBuffer. Set the size to (-1, -1) on creation, so reset() doesn't early-out. Initialize m_depthBuffer and m_stencilBuffer.
platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::canvasClip): (WebCore::GraphicsContext::clipOut): (WebCore::GraphicsContext::clipPath): (WebCore::GraphicsContext::fillPath): Put in GPU hooks for path clipping, and path drawing.
platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::canAccelerate): Don't check for clipping paths in canAccelerate() (since we can now accelerate them). (WebCore::PlatformContextSkia::uploadSoftwareToHardware): Don't do clipping when uploading software draws to hardware.
thirdparty/glu/README.webkit:
thirdparty/glu/gluos.h: #undef MIN and MAX, to fix warnings-as-errors in Chrome/Mac build.
thirdparty/glu/libtess/geom.c:
thirdparty/glu/libtess/priorityq.c:
thirdparty/glu/libtess/render.c: Use do{}while(0) instead of if(1)else construct in macro.
thirdparty/glu/libtess/sweep.c: (IsWindingInside): (DoneEdgeDict): Fix some warnings treated as errors for the Linux Release build.

2011-01-19 Stephen White <senorblanco@chromium.org>

Reviewed by James Robinson.

Add two to-be-rebaselined tests for the GPU path.

platform/chromium-gpu/test_expectations.txt:

05:46 Changeset [76234] by pfeldman@chromium.org

2011-01-20 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: rebaselined inspector tests.

http/tests/inspector/console-xhr-logging.html:
inspector/report-API-errors-expected.txt:

05:14 Changeset [76233] by pfeldman@chromium.org

2011-01-20 Pavel Feldman <pfeldman@chromium.org>

Web Inspector: move releaseObjectGroup to the new Runtime agent.
https://bugs.webkit.org/show_bug.cgi?id=52803
(accedentally landed as r76231)

inspector/InspectorContorller.h:
inspector/InspectorContorller.cpp:
inspector/InspectorRuntimeAgent.h:
inspector/InspectorRuntimeAgent.cpp:

04:58 Changeset [76232] by pfeldman@chromium.org

2011-01-20 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: build fix.

inspector/InspectorState.h: (WebCore::InspectorState::setBoolean): (WebCore::InspectorState::setString): (WebCore::InspectorState::setLong):

04:57 Changeset [76231] by pfeldman@chromium.org

2011-01-20 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: build fix.

inspector/InspectorState.h: (WebCore::InspectorState::setBoolean): (WebCore::InspectorState::setString): (WebCore::InspectorState::setLong):

04:49 Changeset [76230] by pfeldman@chromium.org

2011-01-20 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: further simplify InspectorState.
https://bugs.webkit.org/show_bug.cgi?id=52731

This change moves XHR logging flag into console agent,
removes InspectorState pushing to the front-end.

inspector/Inspector.idl:
inspector/InspectorConsoleAgent.cpp: (WebCore::InspectorConsoleAgent::InspectorConsoleAgent): (WebCore::InspectorConsoleAgent::resourceRetrievedByXMLHttpRequest): (WebCore::InspectorConsoleAgent::setMonitoringXHREnabled): (WebCore::InspectorConsoleAgent::setConsoleMessagesEnabled): (WebCore::InspectorConsoleAgent::addConsoleMessage):
inspector/InspectorConsoleAgent.h:
inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController):
inspector/InspectorController.h: (WebCore::InspectorController::state): (WebCore::InspectorController::settings):
inspector/InspectorState.cpp: (WebCore::InspectorState::InspectorState): (WebCore::InspectorState::registerBoolean): (WebCore::InspectorState::registerString): (WebCore::InspectorState::registerLong): (WebCore::InspectorState::registerObject): (WebCore::InspectorState::Property::create):
inspector/InspectorState.h:
inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.consoleMessagesCleared): (WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.monitoringXHRStateChanged): (WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher): (WebInspector.ConsoleView.prototype._handleContextMenuEvent):
inspector/front-end/inspector.js:

04:47 Changeset [76229] by ossy@webkit.org

Unreviewed buildfix.

[Qt][V8] Remove unnecessary files after r76224.

WebCore.pro:

04:46 Changeset [76228] by jorlow@chromium.org

2011-01-20 Jeremy Orlow <jorlow@chromium.org>

[Chromium] Update baselines and add exception.

platform/chromium-mac/fast/dom/wrapper-classes-expected.txt:
platform/chromium-mac/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-document-write-expected.txt:
platform/chromium-mac/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-javascript-url-expected.txt:
platform/chromium-mac/http/tests/security/xss-DENIED-frame-name-expected.txt:
platform/chromium-win/fast/dom/wrapper-classes-expected.txt:
platform/chromium-win/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-document-write-expected.txt:
platform/chromium-win/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-javascript-url-expected.txt:
platform/chromium-win/http/tests/security/xss-DENIED-frame-name-expected.txt:
platform/chromium/test_expectations.txt:

04:38 Changeset [76227] by loislo@chromium.org

2011-01-20 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: prepare for extracting InspectorAgent from InspectorController.
https://bugs.webkit.org/show_bug.cgi?id=52797

inspector/CodeGeneratorInspector.pm:
inspector/InspectorController.h: (WebCore::InspectorController::inspectorAgent): (WebCore::InspectorController::cssAgent): (WebCore::InspectorController::injectedScriptAgent): (WebCore::InspectorController::resourceAgent): (WebCore::InspectorController::runtimeAgent): (WebCore::InspectorController::timelineAgent): (WebCore::InspectorController::databaseAgent): (WebCore::InspectorController::domStorageAgent): (WebCore::InspectorController::fileSystemAgent): (WebCore::InspectorController::browserDebuggerAgent): (WebCore::InspectorController::debuggerAgent): (WebCore::InspectorController::profilerAgent): (WebCore::InspectorController::applicationCacheAgent):

04:36 Changeset [76226] by jorlow@chromium.org

2011-01-20 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r76215.
http://trac.webkit.org/changeset/76215
https://bugs.webkit.org/show_bug.cgi?id=52799

Caused regressions in Chromium; morrita is going to look at it
tomrorow (Requested by jorlow on #webkit).

editing/inserting/insert-composition-whitespace-expected.txt: Removed.
editing/inserting/insert-composition-whitespace.html: Removed.

2011-01-20 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r76215.
http://trac.webkit.org/changeset/76215
https://bugs.webkit.org/show_bug.cgi?id=52799

Caused regressions in Chromium; morrita is going to look at it
tomrorow (Requested by jorlow on #webkit).

dom/TextEvent.h:
dom/TextEventInputType.h:
editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::rebalanceWhitespaceAt):
editing/CompositeEditCommand.h:
editing/Editor.cpp: (WebCore::Editor::insertTextWithoutSendingTextEvent): (WebCore::Editor::confirmComposition): (WebCore::Editor::setComposition):
editing/Editor.h:
editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::input):
editing/InsertTextCommand.h:
editing/TypingCommand.cpp: (WebCore::TypingCommand::TypingCommand): (WebCore::TypingCommand::insertText): (WebCore::TypingCommand::insertTextRunWithoutNewlines):
editing/TypingCommand.h: (WebCore::TypingCommand::create):

04:31 Changeset [76225] by podivilov@chromium.org

2011-01-19 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Eric Seidel.

Web Inspector: enable debugger-pause-on-breakpoint test (fixed by r76129).
https://bugs.webkit.org/show_bug.cgi?id=45291

http/tests/inspector/debugger-test2.js: (initialize_DebuggerTest.InspectorTest.setBreakpointInVisibleView):
inspector/debugger-breakpoints-not-activated-on-reload.html:
inspector/debugger-pause-on-breakpoint.html:
platform/gtk/Skipped:
platform/mac-leopard/Skipped:
platform/win/Skipped:

04:31 Changeset [76224] by yurys@chromium.org

2010-12-14 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Adam Barth.

[V8] Get rid of delayed exception reporting in V8ConsoleMessage.cpp
https://bugs.webkit.org/show_bug.cgi?id=51044

WebCore.gypi:
bindings/v8/V8ConsoleMessage.cpp: Removed.
bindings/v8/V8ConsoleMessage.h: Removed.
bindings/v8/V8DOMWindowShell.cpp: (WebCore::v8UncaughtExceptionHandler): (WebCore::reportUnsafeJavaScriptAccess): (WebCore::V8DOMWindowShell::initContextIfNeeded):
bindings/v8/V8Proxy.cpp: (WebCore::addMessageToConsole): (WebCore::logInfo): (WebCore::V8Proxy::reportUnsafeAccessTo): (WebCore::V8Proxy::runScript): (WebCore::V8Proxy::callFunction): (WebCore::V8Proxy::newInstance):
bindings/v8/V8Proxy.h:
bindings/v8/WorkerContextExecutionProxy.cpp:
bindings/v8/specialization/V8BindingState.cpp: (WebCore::::immediatelyReportUnsafeAccessTo):

2010-12-14 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Adam Barth.

[V8] Get rid of delayed exception reporting in V8ConsoleMessage.cpp
https://bugs.webkit.org/show_bug.cgi?id=51044

src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::runJavaScriptAlert):
src/WebScriptController.cpp: (WebKit::WebScriptController::flushConsoleMessages):

04:28 Changeset [76223] by philn@webkit.org

2011-01-20 Philippe Normand <pnormand@igalia.com>

Skip failing tests due to missing trailing white space
https://bugs.webkit.org/show_bug.cgi?id=52798

platform/gtk/Skipped: Skip 5 http/tests/security tests.

04:16 Changeset [76222] by abarth@webkit.org

2011-01-20 Adam Barth <abarth@webkit.org>

Reviewed by Tony Chang.

Chromium builders don't delete unversioned directories when DEPS change
https://bugs.webkit.org/show_bug.cgi?id=52745

If we pass this option to gclient sync, gclient will delete directories
that are no longer part of DEPS instead of leaving them around to
confuse us later. Apparently, the downstream buildbots use this option
already.

Scripts/update-webkit-chromium:

04:08 Changeset [76221] by morrita@google.com

2011-01-19 MORITA Hajime <morrita@google.com>

Reviewed by Eric Seidel.

ShadowElement::m_shadowParent should be removed
https://bugs.webkit.org/show_bug.cgi?id=52558

No new tests. No behavioral change.

rendering/ShadowElement.h: (WebCore::ShadowElement::ShadowElement):

02:51 Changeset [76220] by mrobinson@webkit.org

2011-01-20 Martin Robinson <mrobinson@igalia.com>

Skip a test which requires the textInputController, which
the GTK+ DRT does not have.

platform/gtk/Skipped: Skip new test.

02:42 Changeset [76219] by commit-queue@webkit.org

2011-01-20 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r76172.
http://trac.webkit.org/changeset/76172
https://bugs.webkit.org/show_bug.cgi?id=52792

This test still fails on the 32-bit GTK+ debug bot. (Requested
by mrobinson on #webkit).

platform/gtk/Skipped:

02:38 Changeset [76218] by morrita@google.com

2011-01-20 MORITA Hajime <morrita@google.com>

Unreviewed, added a skip list entry

platform/qt/Skipped:

01:39 Changeset [76217] by hans@chromium.org

2011-01-20 Hans Wennborg <hans@chromium.org>

Reviewed by Jeremy Orlow.

IndexedDB: IDBObjectStore.get should fire onsuccess rather than onerror
https://bugs.webkit.org/show_bug.cgi?id=52725

Update layout tests to expect the onsuccess handler to be fired
when looking up non-existing objects.

storage/indexeddb/create-and-remove-object-store-expected.txt:
storage/indexeddb/create-and-remove-object-store.html:
storage/indexeddb/cursor-delete-expected.txt:
storage/indexeddb/cursor-delete.html:
storage/indexeddb/objectstore-removeobjectstore-expected.txt:
storage/indexeddb/objectstore-removeobjectstore.html:

2011-01-20 Hans Wennborg <hans@chromium.org>

Reviewed by Jeremy Orlow.

IndexedDB: IDBObjectStore.get should fire onsuccess rather than onerror
https://bugs.webkit.org/show_bug.cgi?id=52725

Let IDBObjectStore.get() fire the onsuccess handler with the value
'undefined' for when an object does not exist in the store.

Update SerializedScriptValue to provide such an undefined value.

bindings/v8/SerializedScriptValue.cpp: (WebCore::SerializedScriptValue::nullValue): (WebCore::SerializedScriptValue::undefinedValue):
bindings/v8/SerializedScriptValue.h:
storage/IDBObjectStoreBackendImpl.cpp: (WebCore::IDBObjectStoreBackendImpl::getInternal):

01:28 Changeset [76216] by yurys@chromium.org

2010-12-27 yury semikhatsky <yurys@chromium.org>

reviewed by pavel feldman.

webcore doesn't fire window.onerror event when uncaught javascript exceptions are thrown
https://bugs.webkit.org/show_bug.cgi?id=8519

uncaught exceptions are propagated to window.onerror hander if one is present.
the handler is expected to be a function accepting three arguments: error message,
resource url and line number where the exception occured.

it was decided to dispatch errorevent to all listeners/handlers no matter if they
were created in the same isolated world where the exception occured or not.

tests: fast/events/window-onerror1.html

fast/events/window-onerror10.html
fast/events/window-onerror11.html
fast/events/window-onerror12.html
fast/events/window-onerror2.html
fast/events/window-onerror3.html
fast/events/window-onerror4.html
fast/events/window-onerror5.html
fast/events/window-onerror6.html
fast/events/window-onerror7.html
fast/events/window-onerror8.html
fast/events/window-onerror9.html
http/tests/security/window-onerror-exception-in-iframe.html
userscripts/window-onerror-for-isolated-world-1.html
userscripts/window-onerror-for-isolated-world-2.html

android.jscbindings.mk:
cmakelists.txt:
gnumakefile.am:
webcore.gypi:
webcore.order:
webcore.pro:
webcore.vcproj/webcore.vcproj:
webcore.xcodeproj/project.pbxproj:
bindings/js/jsbindingsallinone.cpp:
bindings/js/jsdombinding.cpp: (webcore::reportexception):
bindings/js/jserrorhandler.cpp: renamed from webcore/bindings/js/jsworkercontexterrorhandler.cpp. (webcore::jserrorhandler::jserrorhandler): (webcore::jserrorhandler::~jserrorhandler): (webcore::jserrorhandler::handleevent):
bindings/js/jserrorhandler.h: copied from webcore/bindings/js/jsworkercontexterrorhandler.h. (webcore::jserrorhandler::create): (webcore::createjserrorhandler):
bindings/js/jseventlistener.h:
bindings/scripts/codegeneratorjs.pm:
bindings/scripts/codegeneratorv8.pm:
bindings/v8/v8consolemessage.cpp: (webcore::v8consolemessage::dispatchnow): (webcore::v8consolemessage::handler): the method was changed to use generic webcore exception reporting mechanism which is also used by jsc bindings.
bindings/v8/v8consolemessage.h:
bindings/v8/v8eventlistener.h:
bindings/v8/v8windowerrorhandler.cpp: renamed from webcore/bindings/js/jsworkercontexterrorhandler.h. (webcore::v8windowerrorhandler::v8windowerrorhandler): (webcore::v8windowerrorhandler::calllistenerfunction):
bindings/v8/v8windowerrorhandler.h: copied from webcore/dom/errorevent.cpp. (webcore::v8windowerrorhandler::create):
bindings/v8/workercontextexecutionproxy.cpp: (webcore::v8messagehandler):
bindings/v8/workerscriptcontroller.cpp: (webcore::workerscriptcontroller::evaluate):
dom/document.cpp: (webcore::document::erroreventtarget): (webcore::document::logexceptiontoconsole): (webcore::document::addmessage):
dom/document.h:
dom/errorevent.cpp:
dom/errorevent.h:
dom/event.cpp: (webcore::event::iserrorevent):
dom/event.h:
dom/scriptexecutioncontext.cpp: (webcore::scriptexecutioncontext::pendingexception::pendingexception): (webcore::scriptexecutioncontext::scriptexecutioncontext): (webcore::scriptexecutioncontext::reportexception): this method is not virtual anymore to ensure that error event dispatching algorithm is the same in workercontext and in document. (webcore::scriptexecutioncontext::dispatcherrorevent):
dom/scriptexecutioncontext.h:
websockets/websocket.cpp: (webcore::websocket::connect):
websockets/websocketchannel.cpp: (webcore::websocketchannel::didopen): (webcore::websocketchannel::didfail): (webcore::websocketchannel::appendtobuffer):
websockets/websockethandshake.cpp: (webcore::websockethandshake::readserverhandshake): (webcore::websockethandshake::readstatusline): (webcore::websockethandshake::readhttpheaders): (webcore::websockethandshake::checkresponseheaders):
workers/defaultsharedworkerrepository.cpp: (webcore::postexceptiontask): (webcore::postconsolemessagetask):
workers/workercontext.cpp: (webcore::workercontext::workercontext): (webcore::workercontext::erroreventtarget): (webcore::workercontext::logexceptiontoconsole): (webcore::workercontext::addmessage):
workers/workercontext.h:
workers/workermessagingproxy.cpp: (webcore::workerexceptiontask::performtask): (webcore::postconsolemessagetask):
xml/xmlhttprequest.cpp: (webcore::reportunsafeusage):

2010-12-27 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

WebCore doesn't fire window.onerror event when uncaught JavaScript exceptions are thrown
https://bugs.webkit.org/show_bug.cgi?id=8519

Uncaught exceptions are propagated to window.onerror hander if one is present.
The handler is expected to be a function accepting three arguments: error message,
resource url and line number where the exception occured.

fast/events/resources/window-onerror.js: Added. (throwException):
fast/events/window-onerror1-expected.txt: Added.
fast/events/window-onerror1.html: Added.
fast/events/window-onerror10-expected.txt: Added.
fast/events/window-onerror10.html: Added.
fast/events/window-onerror11-expected.txt: Added.
fast/events/window-onerror11.html: Added.
fast/events/window-onerror12-expected.txt: Added.
fast/events/window-onerror12.html: Added.
fast/events/window-onerror2-expected.txt: Added.
fast/events/window-onerror2.html: Added.
fast/events/window-onerror3-expected.txt: Added.
fast/events/window-onerror3.html: Added.
fast/events/window-onerror4-expected.txt: Added.
fast/events/window-onerror4.html: Added.
fast/events/window-onerror5-expected.txt: Added.
fast/events/window-onerror5.html: Added.
fast/events/window-onerror6-expected.txt: Added.
fast/events/window-onerror6.html: Added.
fast/events/window-onerror7-expected.txt: Added.
fast/events/window-onerror7.html: Added.
fast/events/window-onerror8-expected.txt: Added.
fast/events/window-onerror8.html: Added.
fast/events/window-onerror9-expected.txt: Added.
fast/events/window-onerror9.html: Added.
fast/workers/worker-script-error-expected.txt:
http/tests/security/resources/onerror-iframe.html: Added.
http/tests/security/window-onerror-exception-in-iframe-expected.txt: Added.
http/tests/security/window-onerror-exception-in-iframe.html: Added.
platform/chromium-win/fast/workers/worker-script-error-expected.txt:
platform/chromium/fast/events/window-onerror1-expected.txt: Added.
platform/chromium/fast/events/window-onerror10-expected.txt: Added.
platform/chromium/fast/events/window-onerror11-expected.txt: Added.
platform/chromium/fast/events/window-onerror2-expected.txt: Added.
platform/chromium/fast/events/window-onerror3-expected.txt: Added.
platform/chromium/fast/events/window-onerror4-expected.txt: Added.
platform/chromium/fast/events/window-onerror5-expected.txt: Added.
platform/chromium/fast/events/window-onerror6-expected.txt: Added.
platform/chromium/fast/events/window-onerror7-expected.txt: Added.
platform/chromium/fast/events/window-onerror8-expected.txt: Added.
platform/chromium/fast/events/window-onerror9-expected.txt: Added.
platform/chromium/http/tests/security/window-onerror-exception-in-iframe-expected.txt: Added.
platform/chromium/userscripts/window-onerror-for-isolated-world-1-expected.txt: Added.
platform/chromium/userscripts/window-onerror-for-isolated-world-2-expected.txt: Added.
platform/gtk/Skipped:
userscripts/window-onerror-for-isolated-world-1-expected.txt: Added.
userscripts/window-onerror-for-isolated-world-1.html: Added.
userscripts/window-onerror-for-isolated-world-2-expected.txt: Added.
userscripts/window-onerror-for-isolated-world-2.html: Added.

01:19 Changeset [76215] by morrita@google.com

2011-01-19 MORITA Hajime <morrita@google.com>

Reviewed by Ryosuke Niwa.

Space and tab characters "sent" by an input method give totally different results than typing them directly.
https://bugs.webkit.org/show_bug.cgi?id=5241

Added a test that exercises continous whitespace characters and tabs inserted by IME.

editing/inserting/insert-composition-whitespace-expected.txt: Added.
editing/inserting/insert-composition-whitespace.html: Added.

2011-01-19 MORITA Hajime <morrita@google.com>

Reviewed by Ryosuke Niwa.

Space and tab characters "sent" by an input method give totally different results than typing them directly
https://bugs.webkit.org/show_bug.cgi?id=5241

Introduced TextEvent::InputTypeComposition and TypingCommand::TextCompositionType to distinguish text input which is originated by composition.
Generalized rebalanceWhitespaceAt() to rebalanceWhitespaceOnTextSubstring() to rebalancing range of string on text node, instead of surrounding part of that.

Test: editing/inserting/insert-composition-whitespace.html

dom/TextEvent.h: (WebCore::TextEvent::isComposition):
dom/TextEventInputType.h: Added TextEventInputComposition as a member of TextEvent::InputType
editing/CompositeEditCommand.cpp: (WebCore::containsOnlyWhitespace): (WebCore::CompositeEditCommand::shouldRebalanceLeadingWhitespaceFor): (WebCore::CompositeEditCommand::canRebalance): (WebCore::CompositeEditCommand::rebalanceWhitespaceAt): (WebCore::CompositeEditCommand::rebalanceWhitespaceOnTextSubstring): Added: A generalized version of rebalanceWhitespaceAt(), which takes a range inside Text string.
editing/CompositeEditCommand.h:
editing/Editor.cpp: (WebCore::Editor::insertTextForConfirmedComposition): Added. (WebCore::Editor::insertTextWithoutSendingTextEvent): (WebCore::Editor::confirmComposition): Now uses insertTextForConfirmedComposition(). (WebCore::Editor::setComposition):
editing/Editor.h:
editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::input):
editing/InsertTextCommand.h:
editing/TypingCommand.cpp: (WebCore::TypingCommand::TypingCommand): (WebCore::TypingCommand::insertText): (WebCore::TypingCommand::insertTextRunWithoutNewlines):
editing/TypingCommand.h: Added TypingCommand::m_compositionType and TypingCommand::TextCompositionType (WebCore::TypingCommand::setCompositionType): Added. (WebCore::TypingCommand::create):

00:49 Changeset [76214] by mrowe@apple.com

Follow-up to r75766 / <rdar://problem/5469576>.

Reviewed by Maciej Stachowiak.

We were failing to initialize the key, causing all sorts of unexpected behavior.

wtf/FastMalloc.cpp:

(WTF::setThreadHeap):
(WTF::TCMalloc_ThreadCache::GetThreadHeap):
(WTF::TCMalloc_ThreadCache::InitTSD): Ensure that the key is initialized.

00:15 Changeset [76213] by mjs@apple.com

2011-01-20 Maciej Stachowiak <mjs@apple.com>

Reviewed by Dan Bernstein.

Skip some tests that are failing on the WebKit2 bot
https://bugs.webkit.org/show_bug.cgi?id=52789

platform/mac-wk2/Skipped:

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed