Timeline



Jan 25, 2011:

11:58 PM Changeset in webkit [76676] by yuzo@google.com
  • 2 edits in trunk/Source/WebCore

2011-01-25 Yuzo Fujishima <yuzo@google.com>

Unreviewed attempt to fix compilation error for Chromium Clang.

  • platform/graphics/mac/ComplexTextController.cpp: (WebCore::ComplexTextController::advance):
11:17 PM Changeset in webkit [76675] by yuzo@google.com
  • 2 edits in trunk/LayoutTests

2011-01-25 Yuzo Fujishima <yuzo@google.com>

Unreviewed Chromium test expectation change

Mark fast/text/offsetForPosition-complex-fallback.html as failing for WIN and LINUX.

  • platform/chromium/test_expectations.txt:
10:08 PM Changeset in webkit [76674] by commit-queue@webkit.org
  • 6 edits
    2 adds in trunk

2011-01-25 Ned Holbrook <nholbrook@apple.com>

Reviewed by Dan Bernstein.

ComplexTextController incorrectly conflates string length and range of indexes
https://bugs.webkit.org/show_bug.cgi?id=52760

  • fast/text/offsetForPosition-complex-fallback-expected.txt: Added.
  • fast/text/offsetForPosition-complex-fallback.html: Added.

2011-01-25 Ned Holbrook <nholbrook@apple.com>

Reviewed by Dan Bernstein.

ComplexTextController incorrectly conflates string length and range of indexes
https://bugs.webkit.org/show_bug.cgi?id=52760

Test: fast/text/offsetForPosition-complex-fallback.html

  • platform/graphics/mac/ComplexTextController.cpp: (WebCore::ComplexTextController::offsetForPosition): (WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun): (WebCore::ComplexTextController::ComplexTextRun::setIsNonMonotonic): (WebCore::ComplexTextController::advance):
  • platform/graphics/mac/ComplexTextController.h: (WebCore::ComplexTextController::ComplexTextRun::create): (WebCore::ComplexTextController::ComplexTextRun::indexEnd):
  • platform/graphics/mac/ComplexTextControllerATSUI.cpp: (WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun):
  • platform/graphics/mac/ComplexTextControllerCoreText.cpp: (WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun): (WebCore::ComplexTextController::collectComplexTextRunsForCharactersCoreText):
9:41 PM Changeset in webkit [76673] by weinig@apple.com
  • 2 edits in trunk/LayoutTests

Make this test a bit more robust agains different scrollbar widths.

  • fast/overflow/overflow-rtl-vertical-origin.html:
9:15 PM Changeset in webkit [76672] by sfalken@apple.com
  • 2 edits in tags/Safari-534.16.2/Source/WebKit/win

Merge r76671.

9:13 PM Changeset in webkit [76671] by sfalken@apple.com
  • 2 edits in trunk/Source/WebKit/win

Windows production build fix.
Build correct configuration of Interfaces for Debug_All.

  • WebKit.vcproj/WebKit.submit.sln:
9:04 PM Changeset in webkit [76670] by sfalken@apple.com
  • 2 edits in tags/Safari-534.16.2/Source/WebCore

Merge r76665.

9:02 PM Changeset in webkit [76669] by weinig@apple.com
  • 3 edits
    2 adds in trunk

Scrollbars don't work correctly for top-to-bottom text in an overflow: scroll area
https://bugs.webkit.org/show_bug.cgi?id=53048

Reviewed by David Hyatt.

Source/WebCore:

Test: fast/overflow/overflow-rtl-vertical-origin.html

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::scrollPosition):
(WebCore::RenderLayer::updateScrollInfoAfterLayout):
Take the scroll origin into account when calculating scrollbars in more places.

LayoutTests:

  • fast/overflow/overflow-rtl-vertical-origin-expected.txt: Added.
  • fast/overflow/overflow-rtl-vertical-origin.html: Added.
8:50 PM Changeset in webkit [76668] by tkent@chromium.org
  • 7 edits
    3 adds in trunk

2011-01-25 Kent Tamura <tkent@chromium.org>

Unreviewed, test expectation update.

  • platform/chromium-win/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.checksum: Added.
  • platform/chromium-win/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.png: Added.
  • platform/chromium-win/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt: Added.
  • platform/chromium-win/fast/speech/input-appearance-numberandspeech-expected.checksum:
  • platform/chromium-win/fast/speech/input-appearance-numberandspeech-expected.png:
  • platform/chromium-win/fast/speech/input-appearance-numberandspeech-expected.txt:
  • platform/chromium/test_expectations.txt:

2011-01-25 Kent Tamura <tkent@chromium.org>

Unreviewed trivial change.

  • DEPS: Roll to r72581 to have a webkit_support fix.
8:47 PM Changeset in webkit [76667] by sfalken@apple.com
  • 5 edits in tags/Safari-534.16.2/Source

Versioning.

8:40 PM Changeset in webkit [76666] by sfalken@apple.com
  • 1 copy in tags/Safari-534.16.2

New tag.

8:39 PM Changeset in webkit [76665] by sfalken@apple.com
  • 2 edits in trunk/Source/WebCore

Windows production build fix.
Use correct configuration-specific path in makefile.

  • WebCore.vcproj/WebCore.make:
8:18 PM Changeset in webkit [76664] by tkent@chromium.org
  • 10 edits
    2 adds in trunk

Radio button group state is not restored correctly
https://bugs.webkit.org/show_bug.cgi?id=50442

Reviewed by Dimitri Glazkov.

Source/WebCore:

Fixes a bug that radio button states are not restored correctly in
a case that non-first radio button in a group is checked.

If "checked" attribute is present, the radio button is checked and
other radio buttons in the group are unchecked. This behavior
disturbs form state restoring. This patch changes this behavior so
that the "checked" attribute handling is delayed after form state
restoring.

Test: fast/forms/state-restore-radio-group.html

  • html/HTMLFormControlElement.h: Make finishParsingChildren() protected so that HTMLInpuElement can call it.
  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::HTMLInputElement):

  • Add createdByParser parameter.
  • Initialize m_stateRestored and m_parsingInProgress.

(WebCore::HTMLInputElement::create): Sync with the constructor.
(WebCore::HTMLInputElement::restoreFormControlState):

Set m_stateRestored in order to refer it in finishParsingChildren().

(WebCore::HTMLInputElement::parseMappedAttribute):

Don't call setChecked() during parsing. Move setNeedsValidityCheck()
to setChecked().

(WebCore::HTMLInputElement::finishParsingChildren):

Call setChecked() if form state is not restored.

(WebCore::HTMLInputElement::setChecked):

Move setNeedsValidityCheck() from parseMappedAttribute() because
finishParsingChildren() also needs to call setNeedsValidityCheck().

  • html/HTMLInputElement.h:
    • Remove the default value of HTMLFormElement* of the HTMLInputElement constructor, and add createdByParser parameter.
    • Introduce m_parsingInProgress and m_stateRestored.
  • html/HTMLIsIndexElement.cpp:

(WebCore::HTMLIsIndexElement::HTMLIsIndexElement):

Sync with the HTMLInputElement constructor change.

  • html/HTMLTagNames.in: Add constructorNeedsCreatedByParser flag.
  • rendering/MediaControlElements.cpp:

(WebCore::MediaControlInputElement::MediaControlInputElement):

Sync with the HTMLInputElement constructor change.

  • rendering/ShadowElement.cpp:

(WebCore::ShadowInputElement::ShadowInputElement): ditto.

  • rendering/ShadowElement.h:

(WebCore::ShadowElement::ShadowElement): ditto.

LayoutTests:

  • fast/forms/state-restore-radio-group-expected.txt: Added.
  • fast/forms/state-restore-radio-group.html: Added.
8:00 PM Changeset in webkit [76663] by tkent@chromium.org
  • 10 edits in trunk

HTMLFormElement::checkValidity() returns incorrect result if 'invalid' events are canceled.
https://bugs.webkit.org/show_bug.cgi?id=52565

Reviewed by Dimitri Glazkov.

Source/WebCore:

  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::validateInteractively):

Check checkInvalidControlsAndCollectUnhandled() result instead of
checking emptiness of unhandled invalid controls list.

(WebCore::HTMLFormElement::checkValidity): ditto.
(WebCore::HTMLFormElement::checkInvalidControlsAndCollectUnhandled):

Renamed from collectUnhandledInvalidControls().
Returns true if there is any invalid control regardless of event canceling.

  • html/HTMLFormElement.h: Rename collectUnhandledInvalidControls() to checkInvalidControlsAndCollectUnhandled().

LayoutTests:

Fix tests and results for the behavior change.

  • fast/forms/checkValidity-cancel-expected.txt:
  • fast/forms/checkValidity-handler-updates-dom-expected.txt:
  • fast/forms/interactive-validation-cancel-expected.txt:
  • fast/forms/interactive-validation-cancel.html:
  • fast/forms/script-tests/checkValidity-cancel.js:
  • fast/forms/script-tests/checkValidity-handler-updates-dom.js:
7:50 PM Changeset in webkit [76662] by tkent@chromium.org
  • 10 edits in trunk

2011-01-25 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

Range and number inputs should reject increment and decrement by
keyboard or mouse wheel if they are disabled or read-only
https://bugs.webkit.org/show_bug.cgi?id=53151

Add checks for 'disabled' and 'readOnly'.

  • fast/forms/input-number-keyoperation-expected.txt:
  • fast/forms/input-number-wheel-expected.txt:
  • fast/forms/range-keyoperation-expected.txt:
  • fast/forms/range-keyoperation.html:
  • fast/forms/script-tests/input-number-keyoperation.js:
  • fast/forms/script-tests/input-number-wheel.js:

2011-01-25 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

Range and number inputs should reject increment and decrement by
keyboard or mouse wheel if they are disabled or read-only
https://bugs.webkit.org/show_bug.cgi?id=53151

  • html/RangeInputType.cpp: (WebCore::RangeInputType::handleKeydownEvent): Check disabled() and readOnly().
  • html/TextFieldInputType.cpp: (WebCore::TextFieldInputType::handleKeydownEventForSpinButton): ditto. (WebCore::TextFieldInputType::handleWheelEventForSpinButton): ditto.
7:44 PM Changeset in webkit [76661] by tkent@chromium.org
  • 17 edits
    2 adds in trunk/Source/WebCore

API to support localized numbers for <input type=number>
https://bugs.webkit.org/show_bug.cgi?id=45730

Reviewed by Dimitri Glazkov.

Introduce platform/text/LocalizedNumber.h, and
LocalizedNumberNone.cpp, which is an empty implementation of the
functions in LocalizedNumber.h. We use LocalizedNumberNone.cpp in
all platforms for now.

A string in a type=number field is parsed as a localized number
first. If the parsing fails, it is parsed as the HTML5 number.

We introduce HTMLInputElement::visibleValue(). It represents a value
which should be drawn by a renderer. HTMLInputElement::value() always
returns a number formatted for HTML5, and visibleValue() may return a
localized number.

No new tests because this doesn't change any behavior.

  • Android.mk: Add LocalizedNumber.h and/or LocalizedNumberNone.cpp.
  • CMakeLists.txt: ditto.
  • GNUmakefile.am: ditto.
  • WebCore.gypi: ditto.
  • WebCore.pro: ditto.
  • WebCore.vcproj/WebCore.vcproj: ditto.
  • WebCore.xcodeproj/project.pbxproj: ditto.
  • dom/InputElement.h: Add visibleValue().
  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::visibleValue): Added. Just call InputType::visibleValue().

  • html/HTMLInputElement.h: Declare visibleValue().
  • html/InputType.cpp:

(WebCore::InputType::visibleValue): Add the default implementation of

visibleValue(), which returns HTMLInputElement::value().

  • html/InputType.h: Add declarations.
  • html/NumberInputType.cpp:

(WebCore::isHTMLNumberCharacter): Renamed from isNumberCharacter().
(WebCore::isNumberCharacter): Calls isLocalizedNumberCharacter() and isHTMLNumberCharacter().
(WebCore::NumberInputType::visibleValue):

Returns a localized number string produced by formatLocalizedNumber().

(WebCore::NumberInputType::isAcceptableValue): Calls parseLocalizedNumber().
(WebCore::NumberInputType::sanitizeValue): Calls parseLocalizedNumber().

  • html/NumberInputType.h: Add declarations.
  • platform/text/LocalizedNumber.h: Added.
  • platform/text/LocalizedNumberNone.cpp: Added.

(WebCore::parseLocalizedNumber):
(WebCore::formatLocalizedNumber):
(WebCore::isLocalizedNumberCharacter):

  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::updateFromElement):

Calls InputElement::visibleValue() instead of value().

  • wml/WMLInputElement.h:

(WebCore::WMLInputElement::visibleValue): Added. It just calls value().

7:29 PM Changeset in webkit [76660] by ap@apple.com
  • 3 edits
    1 add in trunk/Source/WebCore

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=53143
Add IntRectHash

  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/IntRectHash.h: Added.
  • platform/graphics/IntSizeHash.h: Don't do "using WebCore::IntSize"!
7:19 PM Changeset in webkit [76659] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-01-25 Ilya Sherman <isherman@chromium.org>

Reviewed by Ryosuke Niwa.

Remove trailing whitespace in HTMLInputElement.cpp
https://bugs.webkit.org/show_bug.cgi?id=53152

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::updateCheckedRadioButtons): (WebCore::HTMLInputElement::applyStep): (WebCore::HTMLInputElement::updateFocusAppearance): (WebCore::HTMLInputElement::mapToEntry): (WebCore::HTMLInputElement::setAutofilled): (WebCore::HTMLInputElement::willMoveToNewOwnerDocument): (WebCore::HTMLInputElement::didMoveToNewOwnerDocument):
6:13 PM Changeset in webkit [76658] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-01-25 Mike Reed <reed@google.com>

Reviewed by James Robinson.

DrawingBufer::reset() today checks if the new size is the same as its
m_size, and if so, returns immediately. This does not match the
semantics of <canvas>, which wants to clear its contents anytime the
size is specified.
https://bugs.webkit.org/show_bug.cgi?id=53149

Test: Covered by existing <canvas> tests using gpu.

  • platform/graphics/chromium/DrawingBufferChromium.cpp: (WebCore::DrawingBuffer::DrawingBuffer):
  • platform/graphics/gpu/DrawingBuffer.cpp: (WebCore::DrawingBuffer::reset):
5:54 PM Changeset in webkit [76657] by Chris Fleizach
  • 10 edits in trunk/Source/WebKit2

WK2 leaks when a page is closed
https://bugs.webkit.org/show_bug.cgi?id=53100

Reviewed by Darin Adler.

Allow the WKView a chance to clean up on a page close. In this case,
cleaning up means removing the references the accessibility token has
to the window.

  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::pageClosed):

  • UIProcess/API/mac/WKView.mm:

(-[WKView _setRemoteAccessibilityWindow:]):
(-[WKView _setAccessibilityChildToken:]):
(-[WKView _processDidCrash]):
(-[WKView _pageClosed]):

  • UIProcess/API/mac/WKViewInternal.h:
  • UIProcess/API/qt/qwkpage_p.h:

(QWKPagePrivate::pageClosed):

  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::close):

  • UIProcess/win/WebView.cpp:

(WebKit::WebView::pageClosed):

  • UIProcess/win/WebView.h:
5:17 PM Changeset in webkit [76656] by paroga@webkit.org
  • 3 edits
    2 moves in trunk

2011-01-25 Patrick Gansterer <paroga@webkit.org>

Reviewed by Adam Barth.

Move main CMakeLists.txt into Source directory
https://bugs.webkit.org/show_bug.cgi?id=52888

  • CMakeLists.txt: Removed.
  • Source/CMakeLists.txt: Copied from CMakeLists.txt.
  • Source/cmakeconfig.h.cmake: Copied from cmakeconfig.h.cmake.
  • cmakeconfig.h.cmake: Removed.

2011-01-25 Patrick Gansterer <paroga@webkit.org>

Reviewed by Adam Barth.

Move main CMakeLists.txt into Source directory
https://bugs.webkit.org/show_bug.cgi?id=52888

  • Scripts/webkitdirs.pm:
5:07 PM CSS21Results edited by tabatkins@google.com
(diff)
4:50 PM Changeset in webkit [76655] by paroga@webkit.org
  • 2 edits in trunk/Tools

2011-01-25 Patrick Gansterer <paroga@webkit.org>

Reviewed by Eric Seidel.

Improve label text in submit-to-ews
https://bugs.webkit.org/show_bug.cgi?id=53130

  • QueueStatusServer/templates/submittoews.html:
4:39 PM CSS21Results edited by tabatkins@google.com
(diff)
4:36 PM Changeset in webkit [76654] by cmarrin@apple.com
  • 5 edits in trunk/Source/WebKit2

2011-01-25 Chris Marrin <cmarrin@apple.com>

Reviewed by Adam Roben.

Expose WebGL flag set/get in WK2
https://bugs.webkit.org/show_bug.cgi?id=53096

  • Shared/WebPreferencesStore.h:
  • UIProcess/API/C/WKPreferences.cpp: (WKPreferencesSetWebGLEnabled): (WKPreferencesGetWebGLEnabled):
  • UIProcess/API/C/WKPreferencesPrivate.h:
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::updatePreferences):
4:23 PM CSS21Results edited by simon.fraser@apple.com
(diff)
4:18 PM Changeset in webkit [76653] by andersca@apple.com
  • 5 edits
    1 add in trunk/Source/WebKit2

2011-01-25 Anders Carlsson <andersca@apple.com>

Reviewed by Adam Roben.

Add and implement LayerTreeHost::scheduleLayerFlush
https://bugs.webkit.org/show_bug.cgi?id=53135

  • WebKit2.xcodeproj/project.pbxproj: Add LayerTreeHostMac.mm.
  • WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::scheduleCompositingLayerSync): Call LayerTreeHost::scheduleLayerFlush.
  • WebProcess/WebPage/LayerTreeHost.cpp: (WebKit::LayerTreeHost::~LayerTreeHost): Call platformInvalidate().

(WebKit::LayerTreeHost::flushPendingLayerChanges):
Rename from syncCompositingLayers.

  • WebProcess/WebPage/mac/LayerTreeHostMac.mm: Added. (WebKit::LayerTreeHost::scheduleLayerFlush): Create a run loop observer if needed. This code is copied from LayerBackedDrawingAreaMac.mm

(WebKit::LayerTreeHost::platformInvalidate):
Invalidate the run loop observer.

(WebKit::LayerTreeHost::flushPendingLayerChangesRunLoopObserverCallback):
Call flushPendingChanges() and remove the run loop observer if it succeeded.

4:10 PM Changeset in webkit [76652] by inferno@chromium.org
  • 6 edits
    2 adds in trunk

2011-01-25 Cris Neckar <cdn@chromium.org>

Reviewed by Adam Barth.

Test for crash when a window's location changes before creating an object URL.
https://bugs.webkit.org/show_bug.cgi?id=53038

  • fast/dom/window-domurl-crash-expected.txt: Added.
  • fast/dom/window-domurl-crash.html: Added.

2011-01-25 Cris Neckar <cdn@chromium.org>

Reviewed by Adam Barth.

Add a hashset of DOMURLs to ScriptExecutionContext to track back references.
https://bugs.webkit.org/show_bug.cgi?id=53038

Test: fast/dom/window-domurl-crash.html

  • dom/ScriptExecutionContext.cpp: (WebCore::ScriptExecutionContext::~ScriptExecutionContext): (WebCore::ScriptExecutionContext::createdDomUrl): (WebCore::ScriptExecutionContext::destroyedDomUrl):
  • dom/ScriptExecutionContext.h: (WebCore::ScriptExecutionContext::domUrls):
  • html/DOMURL.cpp: (WebCore::DOMURL::DOMURL): (WebCore::DOMURL::~DOMURL): (WebCore::DOMURL::contextDestroyed):
  • html/DOMURL.h: (WebCore::DOMURL::scriptExecutionContext):
4:07 PM CSS21Results edited by simon.fraser@apple.com
(diff)
4:04 PM CSS21Results edited by simon.fraser@apple.com
(diff)
3:59 PM CSS21Results edited by simon.fraser@apple.com
(diff)
3:47 PM Changeset in webkit [76651] by sfalken@apple.com
  • 2 edits in tags/Safari-534.16.1/Source/JavaScriptCore

Merge r76650.

3:46 PM Changeset in webkit [76650] by Adam Roben
  • 2 edits in trunk/Source/JavaScriptCore

Windows Production build fix

Reviewed by Steve Falkenburg.

  • JavaScriptCore.vcproj/JavaScriptCore.make: Set BUILDSTYLE to Release_PGO at the very start

of the file so that ConfigurationBuildDir takes that into account. Also set it the right way
(by redefining the macro) rather than the wrong way (by modifying the environment variable).

3:40 PM Changeset in webkit [76649] by andersca@apple.com
  • 4 edits
    2 adds in trunk/Source/WebKit2

2011-01-25 Anders Carlsson <andersca@apple.com>

Reviewed by Simon Fraser.

Add LayerTreeHost class
https://bugs.webkit.org/show_bug.cgi?id=53132

  • WebKit2.xcodeproj/project.pbxproj: Add LayerTreeHost files.
  • WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::DrawingAreaImpl): Initialize m_layerTreeHost.

(WebKit::DrawingAreaImpl::setRootCompositingLayer):
Call the m_layerTreeHost.

  • WebProcess/WebPage/LayerTreeHost.cpp: Added. (WebKit::LayerTreeHost::attachRootCompositingLayer): (WebKit::LayerTreeHost::detachRootCompositingLayer): Add stubbed out functions.

(WebKit::LayerTreeHost::syncCompositingLayers):
Sync the compositing layers in the main frame.

  • WebProcess/WebPage/LayerTreeHost.h: Added.
3:31 PM Changeset in webkit [76648] by Antti Koivisto
  • 17 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=52983
Eliminate m_tagHistory pointer from CSSSelector

Reviewed by Darin Adler.

Keep the component selectors in the array in CSSSelectorList instead
of maintaining a linked list between them. This allows eliminating
m_tagHistory pointer, shrinking CSSSelector by 25% (selection performance
seems to improve some too due to better locality).

  • WebCore.xcodeproj/project.pbxproj:


Make CSSSelector.h a private header.


  • css/CSSGrammar.y:


Use CSSParserSelector during parsing to keep the tag history in
a linked list. This is flattened to an array after parsing.
Use accessors for setting selector values.
Use OwnPtr in selector vector.


  • css/CSSPageRule.cpp:

(WebCore::CSSPageRule::CSSPageRule):

  • css/CSSPageRule.h:

(WebCore::CSSPageRule::create):

Simplify.


  • css/CSSParser.cpp:

(WebCore::CSSParser::~CSSParser):
(WebCore::CSSParser::createFloatingSelector):
(WebCore::CSSParser::sinkFloatingSelector):
(WebCore::CSSParser::createStyleRule):
(WebCore::CSSParser::updateSpecifiersWithElementName):
(WebCore::CSSParser::createPageRule):

  • css/CSSParser.h:

(WebCore::CSSParser::reusableSelectorVector):

CSSSelector -> CSSParserSelector.
Use OwnPtr in selector vector.


  • css/CSSParserValues.cpp:

(WebCore::CSSParserSelector::CSSParserSelector):
(WebCore::CSSParserSelector::~CSSParserSelector):

  • css/CSSParserValues.h:

(WebCore::CSSParserSelector::releaseSelector):
(WebCore::CSSParserSelector::setTag):
(WebCore::CSSParserSelector::setValue):
(WebCore::CSSParserSelector::setAttribute):
(WebCore::CSSParserSelector::setArgument):
(WebCore::CSSParserSelector::setSimpleSelector):
(WebCore::CSSParserSelector::setMatch):
(WebCore::CSSParserSelector::setRelation):
(WebCore::CSSParserSelector::setForPage):
(WebCore::CSSParserSelector::pseudoType):
(WebCore::CSSParserSelector::isUnknownPseudoElement):
(WebCore::CSSParserSelector::isSimple):
(WebCore::CSSParserSelector::tagHistory):
(WebCore::CSSParserSelector::setTagHistory):

Linked list used during parsing.
Avoid recursive destruction.

  • css/CSSSelector.cpp:

(WebCore::CSSSelector::extractPseudoType):
(WebCore::CSSSelector::operator==):
(WebCore::CSSSelector::selectorText):
(WebCore::CSSSelector::setSimpleSelector):

  • css/CSSSelector.h:

(WebCore::CSSSelector::CSSSelector):
(WebCore::CSSSelector::~CSSSelector):
(WebCore::CSSSelector::tagHistory):
(WebCore::CSSSelector::tag):
(WebCore::CSSSelector::value):
(WebCore::CSSSelector::setTag):
(WebCore::CSSSelector::isLastInTagHistory):
(WebCore::CSSSelector::setNotLastInTagHistory):
(WebCore::CSSSelector::RareData::RareData):
(WebCore::CSSSelector::RareData::~RareData):
(WebCore::CSSSelector::createRareData):
(WebCore::CSSSelector::setValue):

Remove m_tagHistory.
Keep m_value in the union with the rare data pointer instead.
Make m_value and m_tag private, implement accessors.
Add a new bit to indicate end of the tag history (multipart selector).
Eliminate complex destruction. Selectors are now deleted as an array or by a CSSParserSelector chain.


  • css/CSSSelectorList.cpp:

(WebCore::CSSSelectorList::adoptSelectorVector):

Flatten everything to an array.


(WebCore::SelectorNeedsNamespaceResolutionFunctor::operator()):

  • css/CSSSelectorList.h:

(WebCore::CSSSelectorList::hasOneSelector):
(WebCore::CSSSelectorList::next):

Skip over the subparts of multipart selectors to find the next selector.


  • css/CSSStyleRule.h:

(WebCore::CSSStyleRule::adoptSelectorVector):

CSSSelector -> CSSParserSelector.


  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
(WebCore::CSSRuleSet::addRule):
(WebCore::collectIdsAndSiblingRulesFromList):
(WebCore::CSSStyleSelector::matchPageRulesForList):

  • dom/Node.cpp:

(WebCore::Node::querySelector):

  • dom/SelectorNodeList.cpp:

(WebCore::createSelectorNodeList):

Use accessors.

3:25 PM CSS21Results edited by simon.fraser@apple.com
(diff)
3:23 PM Changeset in webkit [76647] by sfalken@apple.com
  • 10 edits in tags/Safari-534.16.1/Source

Merge r76638.

3:20 PM Changeset in webkit [76646] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

2011-01-25 Mansi Mithal <mansi.mithal@nokia.com>

Reviewed by Antonio Gomes.

QtTestBrowser should have a UI Settings to prevent loading images
https://bugs.webkit.org/show_bug.cgi?id=52409

Added a new action item named "DisableAutoLoadImages"
under the "Settings" menu

  • QtTestBrowser/launcherwindow.cpp: (LauncherWindow::createChrome): (LauncherWindow::toggleAutoLoadImages):
  • QtTestBrowser/launcherwindow.h:
3:08 PM Changeset in webkit [76645] by sfalken@apple.com
  • 2 edits in tags/Safari-534.16.1/Source/JavaScriptCore

Merge r76598.

3:07 PM Changeset in webkit [76644] by simonjam@chromium.org
  • 5 edits
    5 adds in trunk

2011-01-25 James Simonsen <simonjam@chromium.org>

Reviewed by Tony Chang.

[Chromium] Support small caps in complex text on linux
https://bugs.webkit.org/show_bug.cgi?id=53051

  • platform/chromium-linux/fast/text/atsui-multiple-renderers-expected.checksum: Added.
  • platform/chromium-linux/fast/text/atsui-multiple-renderers-expected.png: Added.
  • platform/chromium-linux/fast/text/atsui-multiple-renderers-expected.txt: Added.
  • platform/chromium-linux/fast/text/atsui-small-caps-punctuation-size-expected.checksum: Added.
  • platform/chromium-linux/fast/text/atsui-small-caps-punctuation-size-expected.png: Added.
  • platform/chromium/test_expectations.txt: Re-enable 2 tests on linux.

2011-01-25 James Simonsen <simonjam@chromium.org>

Reviewed by Tony Chang.

[Chromium] Support small caps in complex text on linux
https://bugs.webkit.org/show_bug.cgi?id=53051

  • platform/graphics/chromium/ComplexTextControllerLinux.cpp: (WebCore::ComplexTextController::nextScriptRun): Break runs at small caps boundaries. (WebCore::ComplexTextController::setupFontForScriptRun): Setup small caps font data if needed.
  • platform/graphics/chromium/ComplexTextControllerLinux.h: Store small caps text in separate string.
3:02 PM Changeset in webkit [76643] by sfalken@apple.com
  • 8 edits in tags/Safari-534.16.1/Source

Merge r76546.

2:58 PM Applications using WebKit edited by munk666@o2.pl
added Kadu (diff)
2:52 PM Changeset in webkit [76642] by dpranke@chromium.org
  • 10 edits in trunk/Tools

2011-01-25 Dirk Pranke <dpranke@chromium.org>

Reviewed by Tony Chang.

Minor bug fixes and cleanup for filesystem wrappers, port/* test
classes, test_expectations.py. This change adds "test-win" and
"test-mac" variants to the test port so that we can better test
rebaselining, and adds a MockUser() object for reuse in testing.

https://bugs.webkit.org/show_bug.cgi?id=53036

  • Scripts/webkitpy/common/system/filesystem.py:
  • Scripts/webkitpy/common/system/filesystem_mock.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
  • Scripts/webkitpy/layout_tests/port/factory.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/test.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
  • Scripts/webkitpy/tool/mocktool.py:
2:31 PM Changeset in webkit [76641] by sfalken@apple.com
  • 5 edits in tags/Safari-534.16.1/Source

Versioning.

2:23 PM Changeset in webkit [76640] by jer.noble@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed build fix: add failing test to gtk/Skipped.

  • platform/gtk/Skipped:
2:05 PM Changeset in webkit [76639] by sfalken@apple.com
  • 1 copy in tags/Safari-534.16.1

New tag.

1:49 PM Changeset in webkit [76638] by sfalken@apple.com
  • 10 edits in trunk/Source

Windows production build fix.
Use correct environment variable escaping

Rubber-stamped by Adam Roben.

Source/JavaScriptCore:

Source/WebCore:

  • WebCore.vcproj/WebCore.make:

Source/WebKit/win:

  • WebKit.vcproj/WebKit.make:

Source/WebKit2:

  • win/WebKit2.make:
  • win/WebKit2Generated.make:
1:29 PM Changeset in webkit [76637] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-01-25 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Empty URLs are never display isolated
https://bugs.webkit.org/show_bug.cgi?id=53053

This check mirrors the check in the local case. There isn't a good way
to test this with a LayoutTest, but it is tested in Chromium (where
this registry is used).

  • platform/SchemeRegistry.cpp: (WebCore::SchemeRegistry::shouldTreatURLSchemeAsDisplayIsolated):
1:14 PM Changeset in webkit [76636] by weinig@apple.com
  • 5 edits in trunk/Source

2011-01-25 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

Pipe a timestamp down into the PlatformWheelEvent for the Mac.
https://bugs.webkit.org/show_bug.cgi?id=53111

  • platform/PlatformWheelEvent.h: (WebCore::PlatformWheelEvent::PlatformWheelEvent): (WebCore::PlatformWheelEvent::timestamp): Add timestamp member.
  • platform/mac/WheelEventMac.mm: (WebCore::PlatformWheelEvent::PlatformWheelEvent): Initialize the timestamp from the event.

2011-01-25 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Don't inform the UI process about compositing changes when using the new drawing area
https://bugs.webkit.org/show_bug.cgi?id=53120

  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::changeAcceleratedCompositingMode): Return early if we're using the new drawing area.

(WebKit::WebPage::exitAcceleratedCompositingMode):
Call setRootCompositingLayer(0) so the drawing area knows when we leave accelerated compositing.

1:13 PM Changeset in webkit [76635] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2011-01-25 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

JSON.stringify processing time exponentially grows with size of object
https://bugs.webkit.org/show_bug.cgi?id=51922

Remove last use of reserveCapacity from JSON stringification, as it results
in appalling append behaviour when there are a large number of property names
and nothing else.

  • runtime/JSONObject.cpp: (JSC::Stringifier::appendQuotedString):
1:11 PM Changeset in webkit [76634] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-01-25 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Don't inform the UI process about compositing changes when using the new drawing area
https://bugs.webkit.org/show_bug.cgi?id=53120

  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::changeAcceleratedCompositingMode): Return early if we're using the new drawing area.

(WebKit::WebPage::exitAcceleratedCompositingMode):
Call setRootCompositingLayer(0) so the drawing area knows when we leave accelerated compositing.

1:08 PM Changeset in webkit [76633] by rniwa@webkit.org
  • 5 edits
    8 deletes in trunk

2011-01-25 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r76625.
http://trac.webkit.org/changeset/76625
https://bugs.webkit.org/show_bug.cgi?id=53119

"incorrect pixel test results" (Requested by rniwa on
#webkit).

  • rendering/RenderBox.cpp: (WebCore::RenderBox::localCaretRect):

2011-01-25 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r76625.
http://trac.webkit.org/changeset/76625
https://bugs.webkit.org/show_bug.cgi?id=53119

"incorrect pixel test results" (Requested by rniwa on
#webkit).

  • editing/selection/caret-painting-after-paste-undo-rtl.html: Removed.
  • editing/selection/caret-painting-after-paste-undo.html: Removed.
  • platform/mac/editing/deleting/5408255-expected.checksum:
  • platform/mac/editing/deleting/5408255-expected.png:
  • platform/mac/editing/selection/caret-painting-after-paste-undo-expected.checksum: Removed.
  • platform/mac/editing/selection/caret-painting-after-paste-undo-expected.png: Removed.
  • platform/mac/editing/selection/caret-painting-after-paste-undo-expected.txt: Removed.
  • platform/mac/editing/selection/caret-painting-after-paste-undo-rtl-expected.checksum: Removed.
  • platform/mac/editing/selection/caret-painting-after-paste-undo-rtl-expected.png: Removed.
  • platform/mac/editing/selection/caret-painting-after-paste-undo-rtl-expected.txt: Removed.
1:05 PM Changeset in webkit [76632] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

2011-01-25 Tony Chang <tony@chromium.org>

Unreviewed, debugger-scripts.html is failing on windows too.

  • platform/chromium/test_expectations.txt:
1:03 PM Changeset in webkit [76631] by dimich@chromium.org
  • 2 edits
    2 adds in trunk/LayoutTests

[Chromium] Not reviewed, rebaseline for a test.
The difference is because V8 has different error messages.

  • platform/chromium-mac/fast/js/js-continue-break-restrictions-expected.txt: Added.
  • platform/chromium-win/fast/js/js-continue-break-restrictions-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
12:55 PM Changeset in webkit [76630] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

2011-01-25 James Robinson <jamesr@chromium.org>

Remove = TEXT PASS lines for tests that consistently pass.

  • platform/chromium/test_expectations.txt:
12:55 PM Changeset in webkit [76629] by paroga@webkit.org
  • 2 edits in trunk/Source/WebKit/wince

2011-01-25 Patrick Gansterer <paroga@webkit.org>

Reviewed by Adam Roben.

[WINCE] Ensure layouted frame when painting
https://bugs.webkit.org/show_bug.cgi?id=53108

  • WebView.cpp: (WebView::paint):
12:52 PM Changeset in webkit [76628] by jer.noble@apple.com
  • 4 edits in trunk/LayoutTests

Unreviewed build fix: rollback untintentional changes in media expected results.

  • media/video-source-moved-expected.txt:
  • media/video-source-none-supported-expected.txt:
  • LayoutTests/platform/win/media/audio-data-url-expected.txt:
12:48 PM Changeset in webkit [76627] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

2011-01-25 Tony Chang <tony@chromium.org>

Unreviewed, mark inspector/debugger-scripts.html as failing on chromium linux.

  • platform/chromium/test_expectations.txt:
12:41 PM Changeset in webkit [76626] by paroga@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-01-25 Patrick Gansterer <paroga@webkit.org>

Unreviewed WinCE build fix for r76614.

  • platform/FileSystem.h:
12:23 PM CSS21Results edited by tabatkins@google.com
(diff)
12:18 PM CSS21Results edited by tabatkins@google.com
Added bug link for containing-block-032 (diff)
12:17 PM Changeset in webkit [76625] by leviw@chromium.org
  • 5 edits
    8 adds in trunk

2011-01-21 Levi Weintraub <leviw@chromium.org>

Reviewed by Darin Adler.

Adding border and padding to the calculation of the local caret rect for RenderBoxes.

Undo moves caret to invalid position
https://bugs.webkit.org/show_bug.cgi?id=49744

Tests: editing/selection/caret-painting-after-paste-undo-rtl.html

editing/selection/caret-painting-after-paste-undo.html

  • rendering/RenderBox.cpp: (WebCore::RenderBox::localCaretRect):

2011-01-21 Levi Weintraub <leviw@chromium.org>

Reviewed by Darin Adler.

Updating the expected result for 5408255 and adding tests for caret positioning at the
beginning and end of RenderBoxes.

Undo moves caret to invalid position
https://bugs.webkit.org/show_bug.cgi?id=49744

  • editing/selection/caret-painting-after-paste-undo-rtl.html: Added.
  • editing/selection/caret-painting-after-paste-undo.html: Added.
  • platform/mac/editing/deleting/5408255-expected.checksum:
  • platform/mac/editing/deleting/5408255-expected.png:
  • platform/mac/editing/selection/caret-painting-after-paste-undo-expected.checksum: Added.
  • platform/mac/editing/selection/caret-painting-after-paste-undo-expected.png: Added.
  • platform/mac/editing/selection/caret-painting-after-paste-undo-expected.txt: Added.
  • platform/mac/editing/selection/caret-painting-after-paste-undo-rtl-expected.checksum: Added.
  • platform/mac/editing/selection/caret-painting-after-paste-undo-rtl-expected.png: Added.
  • platform/mac/editing/selection/caret-painting-after-paste-undo-rtl-expected.txt: Added.
12:03 PM Changeset in webkit [76624] by tony@chromium.org
  • 1 edit
    4 adds in trunk/LayoutTests

2011-01-25 Tony Chang <tony@chromium.org>

Unreviewed, add chromium-mac baselines after r76599.

The platform/mac-leopard results were stale which is why the expected
text results aren't updated as well.

  • platform/chromium-mac/svg/custom/junk-data-expected.checksum: Added.
  • platform/chromium-mac/svg/custom/junk-data-expected.png: Added.
  • platform/chromium-mac/svg/custom/missing-xlink-expected.checksum: Added.
  • platform/chromium-mac/svg/custom/missing-xlink-expected.png: Added.
12:01 PM Changeset in webkit [76623] by jamesr@google.com
  • 11 edits
    3 copies
    4 adds in trunk/LayoutTests

2011-01-25 James Robinson <jamesr@chromium.org>

Reviewed by Mihai Parparita.

Convert requestAnimationFrame tests to be script-tests
https://bugs.webkit.org/show_bug.cgi?id=53109

This converts the new requestAnimationFrame tests to be proper script-tests using make-script-test-wrapper.

  • fast/animation/request-animation-frame-cancel-expected.txt:
  • fast/animation/request-animation-frame-cancel.html:
  • fast/animation/request-animation-frame-cancel2-expected.txt:
  • fast/animation/request-animation-frame-cancel2.html:
  • fast/animation/request-animation-frame-display-expected.txt:
  • fast/animation/request-animation-frame-display.html:
  • fast/animation/request-animation-frame-expected.txt:
  • fast/animation/request-animation-frame-within-callback-expected.txt:
  • fast/animation/request-animation-frame-within-callback.html:
  • fast/animation/request-animation-frame.html:
  • fast/animation/script-tests/TEMPLATE.html: Added.
  • fast/animation/script-tests/request-animation-frame-cancel.js: Copied from LayoutTests/fast/animation/request-animation-frame-cancel.html.
  • fast/animation/script-tests/request-animation-frame-cancel2.js: Copied from LayoutTests/fast/animation/request-animation-frame-cancel2.html. (secondCallbackId):
  • fast/animation/script-tests/request-animation-frame-display.js: Added.
  • fast/animation/script-tests/request-animation-frame-within-callback.js: Copied from LayoutTests/fast/animation/request-animation-frame-within-callback.html. (window):
  • fast/animation/script-tests/request-animation-frame.js: Added.
11:54 AM Changeset in webkit [76622] by weinig@apple.com
  • 8 edits in trunk/Source

2011-01-25 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

Add hasPreciseScrollingDeltas bit to PlatformWheelEvent on the Mac.
https://bugs.webkit.org/show_bug.cgi?id=53107

  • platform/PlatformWheelEvent.h: (WebCore::PlatformWheelEvent::PlatformWheelEvent): (WebCore::PlatformWheelEvent::hasPreciseScrollingDeltas):
  • platform/mac/WheelEventMac.mm: (WebCore::PlatformWheelEvent::PlatformWheelEvent):

2011-01-25 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

Add hasPreciseScrollingDeltas bit to PlatformWheelEvent on the Mac.
https://bugs.webkit.org/show_bug.cgi?id=53107

  • Shared/WebEvent.h: (WebKit::WebWheelEvent::hasPreciseScrollingDeltas):
  • Shared/WebEventConversion.cpp: (WebKit::WebKit2PlatformWheelEvent::WebKit2PlatformWheelEvent):
  • Shared/WebWheelEvent.cpp: (WebKit::WebWheelEvent::WebWheelEvent):
  • Shared/mac/WebEventFactory.mm: (WebKit::WebEventFactory::createWebWheelEvent):
11:52 AM Changeset in webkit [76621] by jer.noble@apple.com
  • 12 edits
    3 adds in trunk

2011-01-20 Jer Noble <jer.noble@apple.com>

Reviewed by Eric Carlson.

REGRESSION (r72119): Audio never plays on Star Wars intro animation
https://bugs.webkit.org/show_bug.cgi?id=52467

Test the ability to read audio/m4a files. Disabled this new test
on the chromium and qt platforms, as they do not support M4A/AAC.

  • media/audio-mpeg4-supported-expected.txt: Added.
  • media/audio-mpeg4-supported.html: Added.
  • media/content/silence.m4a: Added.
  • platform/chromium/test_expectations.txt:
  • platform/qt/Skipped:

2011-01-20 Jer Noble <jer.noble@apple.com>

Reviewed by Eric Carlson.

REGRESSION (r72119): Audio never plays on Star Wars intro animation
https://bugs.webkit.org/show_bug.cgi?id=52467

QuickTime's eat/m4a movie importer compontent doesn't list audio/m4a as a mime
type which it supports, though it handles .m4a files just fine. Change the way
we build the list of supported MIME Types through a new WebKitSystemInterface
function.

Caused by r72119, which adds system-specific extension->MIME entries to the cache
before global entries, and the system-specific entries include QuickTime's registry
entries which contain the audio/m4a MIME type, while its components do not.

Test: media/audio-mpeg4-supported.html

  • WebCore.vcproj/QTMovieWinCommon.vsprops:
  • platform/graphics/win/QTMovie.cpp: (getMIMETypeCallBack): (initializeSupportedTypes): (QTMovie::countSupportedTypes): gSupportedTypes is now a CFArrayRef. (QTMovie::getSupportedType): Ditto.

2011-01-24 Jer Noble <jer.noble@apple.com>

Reviewed by Eric Carlson.

REGRESSION (r72119): Audio never plays on Star Wars intro animation
https://bugs.webkit.org/show_bug.cgi?id=52467

Add wkGetQuickTimeMIMETypeList() function.

  • win/include/WebKitSystemInterface/WebKitSystemInterface.h:
  • win/lib/WebKitSystemInterface.lib:
11:39 AM Changeset in webkit [76620] by tony@chromium.org
  • 3 edits in trunk/Tools

2011-01-25 Tony Chang <tony@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium] remove unused layoutTestController callback
https://bugs.webkit.org/show_bug.cgi?id=53103

This method is used by a test_shell_test, but not needed by DRT.

  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController):
  • DumpRenderTree/chromium/LayoutTestController.h:
11:39 AM Changeset in webkit [76619] by tony@chromium.org
  • 5 edits in trunk/LayoutTests

2011-01-25 Tony Chang <tony@chromium.org>

Unreviewed, rebaseline a test on chromium-win. Part of r76586 rebaselines.

  • platform/chromium-win/svg/custom/svg-fonts-in-html-expected.checksum:
  • platform/chromium-win/svg/custom/svg-fonts-in-html-expected.png:
  • platform/chromium-win/svg/custom/svg-fonts-in-html-expected.txt:
  • platform/chromium/test_expectations.txt:
11:25 AM Changeset in webkit [76618] by rniwa@webkit.org
  • 11 edits in trunk/LayoutTests

2011-01-25 Ryosuke Niwa <rniwa@webkit.org>

Another unreviewed SVG rebaselines for Chromium.

  • platform/chromium-linux/svg/text/text-text-05-t-expected.checksum:
  • platform/chromium-linux/svg/text/text-text-05-t-expected.png:
  • platform/chromium-mac/svg/text/text-text-05-t-expected.checksum:
  • platform/chromium-mac/svg/text/text-text-05-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.txt:
  • platform/chromium-win/svg/text/text-text-05-t-expected.checksum:
  • platform/chromium-win/svg/text/text-text-05-t-expected.png:
  • platform/chromium-win/svg/text/text-text-05-t-expected.txt:
  • platform/chromium/test_expectations.txt:
11:14 AM Changeset in webkit [76617] by andersca@apple.com
  • 9 edits in trunk/Source/WebKit2

2011-01-25 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

need a way to request the host CALayer render server port
https://bugs.webkit.org/show_bug.cgi?id=53101
<rdar://problem/8913620>

  • PluginProcess/PluginControllerProxy.cpp: (WebKit::PluginControllerProxy::compositingRenderServerPort): Get the render server port from the plug-in process.
  • PluginProcess/PluginControllerProxy.h:
  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp: (WebKit::NPN_GetValue): Call NetscapePlugin::compositingRenderServerPort.
  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm: (WebKit::NetscapePlugin::compositingRenderServerPort): Call PluginController::compositingRenderServerPort.
  • WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::compositingRenderServerPort): Get the render server port from the web process.
  • WebProcess/Plugins/PluginView.h: Add compositingRenderServerPort.
11:07 AM Changeset in webkit [76616] by hans@chromium.org
  • 8 edits in trunk/Source

2011-01-25 Hans Wennborg <hans@chromium.org>

Reviewed by Jeremy Orlow.

IndexedDB: Remove PlatformBridge::idbShutdown()
https://bugs.webkit.org/show_bug.cgi?id=53077

Since Chromium r72157, this is not used anymore. The previous use was
to signal to the embedder that IndexedDB was shutting down, but we
agreed it is better if the embedder keeps track of that itself.

No new tests: this does not change any functionality.

  • platform/chromium/PlatformBridge.h:
  • storage/IDBFactoryBackendInterface.cpp:
  • storage/IDBFactoryBackendInterface.h: (WebCore::IDBFactoryBackendInterface::~IDBFactoryBackendInterface):
  • storage/chromium/IDBFactoryBackendInterface.cpp:

2011-01-25 Hans Wennborg <hans@chromium.org>

Reviewed by Jeremy Orlow.

IndexedDB: Remove PlatformBridge::idbShutdown()
https://bugs.webkit.org/show_bug.cgi?id=53077

Since Chromium r72157, this is not used anymore. Chromium keeps track
of when it shuts down IndexedDB itself.

  • public/WebKitClient.h:
  • src/PlatformBridge.cpp:
11:06 AM Changeset in webkit [76615] by Antti Koivisto
  • 2 edits in trunk/Source/JavaScriptCore

Not reviewed.

Try to fix windows build.

11:03 AM Changeset in webkit [76614] by darin@apple.com
  • 11 edits in trunk/Source

2011-01-25 Darin Adler <darin@apple.com>

Reviewed by Anders Carlsson.

WebKit is using CSBackupSetItemExcluded incorrectly
https://bugs.webkit.org/show_bug.cgi?id=53095
rdar://problem/8790540

  • Misc/WebIconDatabase.mm: (importToWebCoreFormat): Removed code that was calling CSBackupSetItemExcluded. It was incorrect, and this responsibility has been moved to WebCore.

2011-01-25 Darin Adler <darin@apple.com>

Reviewed by Anders Carlsson.

WebKit is using CSBackupSetItemExcluded incorrectly
https://bugs.webkit.org/show_bug.cgi?id=53095
rdar://problem/8790540

  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::performOpenInitialization): Added code to exclude the database from backup one time, and record inside the database that this has been done. (WebCore::IconDatabase::wasExcludedFromBackup): Added. (WebCore::IconDatabase::setWasExcludedFromBackup): Added.
  • loader/icon/IconDatabase.h: Added new functions above.
  • platform/FileSystem.cpp: (WebCore::canExcludeFromBackup): Added. (WebCore::excludeFromBackup): Added.
  • platform/FileSystem.h: Added canExcludeFromBackup, excludeFromBackup, and pathAsURL functions. Cleaned up ifdefs and comments a bit and sorted things alphabetically, particularly platform-specific sections.
  • platform/cf/FileSystemCF.cpp: (WebCore::pathAsURL): Added.
  • platform/mac/FileSystemMac.mm: (WebCore::canExcludeFromBackup): Added. (WebCore::excludeFromBackup): Added.
  • platform/network/cf/FormDataStreamCFNet.cpp: (WebCore::advanceCurrentStream): Changed to call pathAsURL.
  • platform/network/mac/FormDataStreamMac.mm: (WebCore::advanceCurrentStream): Ditto.
10:56 AM Changeset in webkit [76613] by mjs@apple.com
  • 2 edits in trunk/LayoutTests

2011-01-25 Maciej Stachowiak <mjs@apple.com>

Reviewed by Darin Adler.

Skip another new test that uses eventSender
https://bugs.webkit.org/show_bug.cgi?id=53094

  • platform/mac-wk2/Skipped:
10:54 AM Changeset in webkit [76612] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-01-25 Helder Correia <helder@sencha.com>

Reviewed by Dirk Schulze.

REGRESSION(75139): SVG gradients are not applied to texts
https://bugs.webkit.org/show_bug.cgi?id=52531

CGContextConcatCTM should use the CGLayer context, not the
GraphicsContext. Also, the CTM needs to be adjusted (translated).
This fixes SVG text gradient fill.

Test: svg/css/composite-shadow-text.svg

  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::fillRect):
10:46 AM CSS21Results edited by simon.fraser@apple.com
(diff)
10:44 AM Changeset in webkit [76611] by Antti Koivisto
  • 10 edits
    3 adds in trunk/Source/JavaScriptCore

REGRESSION: Leak in JSParser::Scope::copyCapturedVariablesToVector()
https://bugs.webkit.org/show_bug.cgi?id=53061

Reviewed by Oliver Hunt.

Cache did not know about the subclass so failed to fully delete the items.
Got rid of the subclass and moved the classes to separate files.

(JSC::JSParser::Scope::saveFunctionInfo):
(JSC::JSParser::Scope::restoreFunctionInfo):
(JSC::JSParser::findCachedFunctionInfo):
(JSC::JSParser::parseFunctionInfo):

  • parser/SourceProvider.h:
  • parser/SourceProviderCache.cpp: Added.

(JSC::SourceProviderCache::~SourceProviderCache):
(JSC::SourceProviderCache::byteSize):

  • parser/SourceProviderCache.h: Added.

(JSC::SourceProviderCache::SourceProviderCache):
(JSC::SourceProviderCache::add):
(JSC::SourceProviderCache::get):

  • parser/SourceProviderCacheItem.h: Added.

(JSC::SourceProviderCacheItem::SourceProviderCacheItem):
(JSC::SourceProviderCacheItem::approximateByteSize):
(JSC::SourceProviderCacheItem::closeBraceToken):

10:42 AM Changeset in webkit [76610] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

2011-01-25 Benjamin Kalman <kalman@chromium.org>

Reviewed by Ryosuke Niwa.

Cannot extend or modify forward by word over a non-contenteditable region
https://bugs.webkit.org/show_bug.cgi?id=53070

Add regression test.

  • editing/selection/extend-forward-by-word-over-non-editable-expected.txt: Added.
  • editing/selection/extend-forward-by-word-over-non-editable.html: Added.

2011-01-25 Benjamin Kalman <kalman@chromium.org>

Reviewed by Ryosuke Niwa.

Cannot extend or modify forward by word over a non-contenteditable region
https://bugs.webkit.org/show_bug.cgi?id=53070

Test: editing/selection/extend-forward-by-word-over-non-editable.html

Change all instances of honorEditableBoundaryAtOrAfter to honorEditableBoundaryAtOrBefore and vice versa in the
functions which determine the end/start of words/lines/sentences in visible_units.cpp.

This fixes the bug where moving forwards by a word over a non-contenteditable region would place the cursor
inside that region, and then get moved back to the start of the word due to honorEditableBoundaryAtOrBefore.
The cursor is now moved to the end of the region (which is effectively a noop in this case).

  • editing/visible_units.cpp: Change all instances of honorEditableBoundaryAtOrAfter to honorEditableBoundaryAtOrBefore and vice versa. (WebCore::previousWordPosition): (WebCore::nextWordPosition): (WebCore::startOfLine): (WebCore::endOfLine): (WebCore::previousSentencePosition): (WebCore::nextSentencePosition): (WebCore::logicalStartOfLine): (WebCore::logicalEndOfLine):
10:28 AM Changeset in webkit [76609] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-01-25 Marcilio Mendonca <mamendonca@rim.com>

Reviewed by Darin Adler.

Bug 53087: Refactoring: replaced a hanging "else" with a "return"
statement
https://bugs.webkit.org/show_bug.cgi?id=53087.

Refactoring work: Replaced a hanging "else" within an #if PLATFORM(M
with a "return" so that the code is more readable and less error pro
(e.g., "else" doesn't use braces so adding extra lines to the else
block won't have any effect; even worse, code still compiles
successfully.

  • wtf/Assertions.cpp:
10:26 AM Changeset in webkit [76608] by mjs@apple.com
  • 2 edits in trunk/Source/WebKit2

Change some floating point constants from 1.0 to 1.

Rubber stamped by Dan Bernstein.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDidCommitLoad):

10:19 AM Changeset in webkit [76607] by rniwa@webkit.org
  • 36 edits
    2 adds
    2 deletes in trunk/LayoutTests

2011-01-25 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed SVG rebaselines for Chromium.

  • platform/chromium-linux/svg/batik/text/textEffect-expected.checksum:
  • platform/chromium-linux/svg/batik/text/textEffect-expected.png:
  • platform/chromium-linux/svg/batik/text/textEffect-expected.txt: Removed.
  • platform/chromium-linux/svg/batik/text/textEffect3-expected.checksum:
  • platform/chromium-linux/svg/batik/text/textEffect3-expected.png:
  • platform/chromium-linux/svg/batik/text/textEffect3-expected.txt: Removed.
  • platform/chromium-linux/svg/batik/text/textPosition2-expected.txt:
  • platform/chromium-linux/svg/custom/svg-fonts-in-html-expected.checksum:
  • platform/chromium-linux/svg/custom/svg-fonts-in-html-expected.png:
  • platform/chromium-linux/svg/custom/svg-fonts-in-html-expected.txt: Added.
  • platform/chromium-linux/svg/custom/svg-fonts-with-no-element-reference-expected.checksum:
  • platform/chromium-linux/svg/custom/svg-fonts-with-no-element-reference-expected.png:
  • platform/chromium-linux/svg/custom/svg-fonts-without-missing-glyph-expected.checksum:
  • platform/chromium-linux/svg/custom/svg-fonts-without-missing-glyph-expected.png:
  • platform/chromium-linux/svg/text/text-text-06-t-expected.checksum:
  • platform/chromium-linux/svg/text/text-text-06-t-expected.png:
  • platform/chromium-mac/svg/custom/svg-fonts-in-html-expected.checksum:
  • platform/chromium-mac/svg/custom/svg-fonts-in-html-expected.png:
  • platform/chromium-mac/svg/text/text-text-06-t-expected.checksum:
  • platform/chromium-mac/svg/text/text-text-06-t-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/text-text-05-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/text-text-06-t-expected.txt:
  • platform/chromium-win/svg/batik/text/textEffect-expected.checksum:
  • platform/chromium-win/svg/batik/text/textEffect-expected.png:
  • platform/chromium-win/svg/batik/text/textEffect-expected.txt:
  • platform/chromium-win/svg/batik/text/textEffect3-expected.checksum:
  • platform/chromium-win/svg/batik/text/textEffect3-expected.png:
  • platform/chromium-win/svg/batik/text/textEffect3-expected.txt:
  • platform/chromium-win/svg/batik/text/textPosition2-expected.txt:
  • platform/chromium-win/svg/custom/svg-fonts-with-no-element-reference-expected.checksum:
  • platform/chromium-win/svg/custom/svg-fonts-with-no-element-reference-expected.png:
  • platform/chromium-win/svg/custom/svg-fonts-without-missing-glyph-expected.checksum:
  • platform/chromium-win/svg/custom/svg-fonts-without-missing-glyph-expected.png:
  • platform/chromium-win/svg/custom/svg-fonts-without-missing-glyph-expected.txt:
  • platform/chromium-win/svg/text/text-text-06-t-expected.checksum:
  • platform/chromium-win/svg/text/text-text-06-t-expected.png:
  • platform/chromium-win/svg/text/text-text-06-t-expected.txt:
  • platform/chromium/test_expectations.txt:
10:18 AM Changeset in webkit [76606] by yael.aharon@nokia.com
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix.
After r76466, efsrv.lib is used unconditionally.
Don't guard it with ENABLE_NETSCAPE_PLUGIN_API.

  • WebCore.pro:
10:09 AM Changeset in webkit [76605] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

2011-01-25 Tony Chang <tony@chromium.org>

Unreviewed, remove passing chromium win tests.

  • platform/chromium/test_expectations.txt:
9:54 AM Changeset in webkit [76604] by mjs@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-01-25 Maciej Stachowiak <mjs@apple.com>

Reviewed by Anders Carlsson.

Improve scale factor resetting
https://bugs.webkit.org/show_bug.cgi?id=53093


Two key changes:

  • Don't set the scale factor to what it already is, as this causes an uneeded force layout and scroll
  • Don't ever set the scale factor based on a non-main frame committing


This fixes two WebKit2 layout tests.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::dispatchDidCommitLoad):
9:47 AM Changeset in webkit [76603] by zmo@google.com
  • 12 edits in trunk/Source/WebCore

2011-01-24 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Style cleanup for WebGLRenderingContext
https://bugs.webkit.org/show_bug.cgi?id=52352

  • html/canvas/WebGLBuffer.cpp:
  • html/canvas/WebGLBuffer.h:
  • html/canvas/WebGLObject.cpp:
  • html/canvas/WebGLProgram.cpp:
  • html/canvas/WebGLRenderbuffer.cpp:
  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::create): (WebCore::WebGLRenderingContext::blendFunc): (WebCore::WebGLRenderingContext::createShader): (WebCore::WebGLRenderingContext::deleteBuffer): (WebCore::WebGLRenderingContext::deleteShader): (WebCore::WebGLRenderingContext::deleteTexture): (WebCore::WebGLRenderingContext::disableVertexAttribArray): (WebCore::WebGLRenderingContext::validateIndexArrayPrecise): (WebCore::WebGLRenderingContext::validateRenderingState): (WebCore::WebGLRenderingContext::enableVertexAttribArray): (WebCore::WebGLRenderingContext::getUniform): (WebCore::WebGLRenderingContext::detachAndRemoveAllObjects):
  • html/canvas/WebGLRenderingContext.h:
  • html/canvas/WebGLShader.cpp:
  • html/canvas/WebGLTexture.cpp:
  • html/canvas/WebGLUniformLocation.cpp:
  • html/canvas/WebGLUniformLocation.h:
9:43 AM Changeset in webkit [76602] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit/chromium

2011-01-25 Ilya Sherman <isherman@chromium.org>

Reviewed by Darin Fisher.

Chromium WebKit API: Move dispatchFormControlChangeEvent() from WebInputElement to WebFormControlElement
In service of https://code.google.com/p/chromium/issues/detail?id=42716
https://bugs.webkit.org/show_bug.cgi?id=53069

  • public/WebFormControlElement.h:
  • public/WebInputElement.h:
  • src/WebFormControlElement.cpp: (WebKit::WebFormControlElement::dispatchFormControlChangeEvent): Moved from WebInputElement
  • src/WebInputElement.cpp:
9:34 AM Changeset in webkit [76601] by zmo@google.com
  • 7 edits in trunk/Source/WebCore

2011-01-24 Chris Marrin <cmarrin@apple.com>

Reviewed by Eric Seidel.

Change ENABLE_3D_CANVAS to ENABLE_WEBGL
https://bugs.webkit.org/show_bug.cgi?id=53041

  • Configurations/FeatureDefines.xcconfig:
  • DerivedSources.cpp:
  • GNUmakefile.am:
  • WebCore.pro:
  • bindings/generic/RuntimeEnabledFeatures.h:
  • bindings/js/JSArrayBufferCustom.cpp:
  • bindings/js/JSCanvasRenderingContextCustom.cpp: (WebCore::toJS):
  • bindings/js/JSDOMWindowCustom.cpp:
  • bindings/js/JSDataViewCustom.cpp:
  • bindings/js/JSDocumentCustom.cpp:
  • bindings/js/JSFloat32ArrayCustom.cpp:
  • bindings/js/JSHTMLCanvasElementCustom.cpp: (WebCore::JSHTMLCanvasElement::getContext):
  • bindings/js/JSInt16ArrayCustom.cpp:
  • bindings/js/JSInt32ArrayCustom.cpp:
  • bindings/js/JSInt8ArrayCustom.cpp:
  • bindings/js/JSUint16ArrayCustom.cpp:
  • bindings/js/JSUint32ArrayCustom.cpp:
  • bindings/js/JSUint8ArrayCustom.cpp:
  • bindings/js/JSWebGLRenderingContextCustom.cpp:
  • bindings/js/JSXMLHttpRequestCustom.cpp: (WebCore::JSXMLHttpRequest::markChildren): (WebCore::JSXMLHttpRequest::send): (WebCore::JSXMLHttpRequest::response):
  • bindings/v8/custom/V8ArrayBufferCustom.cpp:
  • bindings/v8/custom/V8ArrayBufferViewCustom.h:
  • bindings/v8/custom/V8DataViewCustom.cpp:
  • bindings/v8/custom/V8DocumentCustom.cpp: (WebCore::V8Document::getCSSCanvasContextCallback):
  • bindings/v8/custom/V8Float32ArrayCustom.cpp:
  • bindings/v8/custom/V8HTMLCanvasElementCustom.cpp: (WebCore::V8HTMLCanvasElement::getContextCallback):
  • bindings/v8/custom/V8Int16ArrayCustom.cpp:
  • bindings/v8/custom/V8Int32ArrayCustom.cpp:
  • bindings/v8/custom/V8Int8ArrayCustom.cpp:
  • bindings/v8/custom/V8Uint16ArrayCustom.cpp:
  • bindings/v8/custom/V8Uint32ArrayCustom.cpp:
  • bindings/v8/custom/V8Uint8ArrayCustom.cpp:
  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp: (WebCore::V8XMLHttpRequest::responseAccessorGetter): (WebCore::V8XMLHttpRequest::sendCallback):
  • features.pri:
  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::getContext): (WebCore::HTMLCanvasElement::reset):
  • html/HTMLCanvasElement.h:
  • html/canvas/ArrayBuffer.cpp:
  • html/canvas/ArrayBuffer.idl:
  • html/canvas/ArrayBufferView.cpp:
  • html/canvas/ArrayBufferView.idl:
  • html/canvas/DataView.cpp:
  • html/canvas/DataView.idl:
  • html/canvas/Float32Array.cpp:
  • html/canvas/Float32Array.idl:
  • html/canvas/Int16Array.cpp:
  • html/canvas/Int16Array.idl:
  • html/canvas/Int32Array.cpp:
  • html/canvas/Int32Array.idl:
  • html/canvas/Int8Array.cpp:
  • html/canvas/Int8Array.idl:
  • html/canvas/OESStandardDerivatives.cpp:
  • html/canvas/OESStandardDerivatives.idl:
  • html/canvas/OESTextureFloat.cpp:
  • html/canvas/OESTextureFloat.idl:
  • html/canvas/Uint16Array.cpp:
  • html/canvas/Uint16Array.idl:
  • html/canvas/Uint32Array.cpp:
  • html/canvas/Uint32Array.idl:
  • html/canvas/Uint8Array.cpp:
  • html/canvas/Uint8Array.idl:
  • html/canvas/WebGLActiveInfo.idl:
  • html/canvas/WebGLBuffer.cpp:
  • html/canvas/WebGLBuffer.idl:
  • html/canvas/WebGLContextAttributes.cpp:
  • html/canvas/WebGLContextAttributes.idl:
  • html/canvas/WebGLContextEvent.idl:
  • html/canvas/WebGLExtension.cpp:
  • html/canvas/WebGLFramebuffer.cpp:
  • html/canvas/WebGLFramebuffer.idl:
  • html/canvas/WebGLGetInfo.cpp:
  • html/canvas/WebGLObject.cpp:
  • html/canvas/WebGLProgram.cpp:
  • html/canvas/WebGLProgram.idl:
  • html/canvas/WebGLRenderbuffer.cpp:
  • html/canvas/WebGLRenderbuffer.idl:
  • html/canvas/WebGLRenderingContext.cpp:
  • html/canvas/WebGLRenderingContext.idl:
  • html/canvas/WebGLShader.cpp:
  • html/canvas/WebGLShader.idl:
  • html/canvas/WebGLTexture.cpp:
  • html/canvas/WebGLTexture.idl:
  • html/canvas/WebGLUniformLocation.cpp:
  • html/canvas/WebGLUniformLocation.idl:
  • html/canvas/WebKitLoseContext.cpp:
  • html/canvas/WebKitLoseContext.idl:
  • page/DOMWindow.idl:
  • platform/graphics/ANGLEWebKitBridge.cpp:
  • platform/graphics/GraphicsContext3D.cpp:
  • platform/graphics/cg/GraphicsContext3DCG.cpp:
  • platform/graphics/gpu/DrawingBuffer.cpp:
  • platform/graphics/gpu/mac/DrawingBufferMac.mm:
  • platform/graphics/mac/GraphicsContext3DMac.mm:
  • platform/graphics/mac/WebGLLayer.mm:
  • platform/graphics/opengl/Extensions3DOpenGL.cpp:
  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
  • platform/graphics/qt/Extensions3DQt.cpp:
  • platform/graphics/qt/GraphicsContext3DQt.cpp:
  • platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::GraphicsLayerQtImpl::GraphicsLayerQtImpl): (WebCore::GraphicsLayerQtImpl::paint): (WebCore::GraphicsLayerQtImpl::flushChanges):
  • platform/graphics/qt/GraphicsLayerQt.h:
  • platform/graphics/skia/GraphicsContext3DSkia.cpp:
  • platform/graphics/texmap/GraphicsLayerTextureMapper.h:
  • rendering/RenderLayerBacking.cpp: (WebCore::isAcceleratedCanvas): (WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration): (WebCore::RenderLayerBacking::containsPaintedContent): (WebCore::RenderLayerBacking::contentChanged):
  • webaudio/AudioBuffer.cpp:
  • webaudio/AudioBuffer.idl:
  • webaudio/RealtimeAnalyser.cpp:
  • webaudio/RealtimeAnalyser.h:
  • webaudio/RealtimeAnalyserNode.h:
  • webaudio/RealtimeAnalyserNode.idl:
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::setResponseType): (WebCore::XMLHttpRequest::clearResponse): (WebCore::XMLHttpRequest::didReceiveData):
  • xml/XMLHttpRequest.h:
9:27 AM Changeset in webkit [76600] by cmarrin@apple.com
  • 130 edits in trunk

2011-01-24 Chris Marrin <cmarrin@apple.com>

Reviewed by Eric Seidel.

Change ENABLE_3D_CANVAS to ENABLE_WEBGL
https://bugs.webkit.org/show_bug.cgi?id=53041

  • configure.ac:

2011-01-24 Chris Marrin <cmarrin@apple.com>

Reviewed by Eric Seidel.

Change ENABLE_3D_CANVAS to ENABLE_WEBGL
https://bugs.webkit.org/show_bug.cgi?id=53041

  • Configurations/FeatureDefines.xcconfig:

2011-01-24 Chris Marrin <cmarrin@apple.com>

Reviewed by Eric Seidel.

Change ENABLE_3D_CANVAS to ENABLE_WEBGL
https://bugs.webkit.org/show_bug.cgi?id=53041

  • WebKit.gyp:
  • features.gypi:
  • src/Extensions3DChromium.cpp:
  • src/GraphicsContext3DChromium.cpp:
  • src/WebRuntimeFeatures.cpp: (WebKit::WebRuntimeFeatures::enableWebGL): (WebKit::WebRuntimeFeatures::isWebGLEnabled):

2011-01-24 Chris Marrin <cmarrin@apple.com>

Reviewed by Eric Seidel.

Change ENABLE_3D_CANVAS to ENABLE_WEBGL
https://bugs.webkit.org/show_bug.cgi?id=53041

  • Api/qwebsettings.cpp: (QWebSettingsPrivate::apply):

2011-01-24 Chris Marrin <cmarrin@apple.com>

Reviewed by Eric Seidel.

Change ENABLE_3D_CANVAS to ENABLE_WEBGL
https://bugs.webkit.org/show_bug.cgi?id=53041

  • WebView.cpp: (WebView::notifyPreferencesChanged):

2011-01-24 Chris Marrin <cmarrin@apple.com>

Reviewed by Eric Seidel.

Change ENABLE_3D_CANVAS to ENABLE_WEBGL
https://bugs.webkit.org/show_bug.cgi?id=53041

  • Configurations/FeatureDefines.xcconfig:

2011-01-24 Chris Marrin <cmarrin@apple.com>

Reviewed by Eric Seidel.

Change ENABLE_3D_CANVAS to ENABLE_WEBGL
https://bugs.webkit.org/show_bug.cgi?id=53041

  • Configurations/FeatureDefines.xcconfig:
  • DerivedSources.cpp:
  • GNUmakefile.am:
  • WebCore.pro:
  • bindings/generic/RuntimeEnabledFeatures.h:
  • bindings/js/JSArrayBufferCustom.cpp:
  • bindings/js/JSCanvasRenderingContextCustom.cpp: (WebCore::toJS):
  • bindings/js/JSDOMWindowCustom.cpp:
  • bindings/js/JSDataViewCustom.cpp:
  • bindings/js/JSDocumentCustom.cpp:
  • bindings/js/JSFloat32ArrayCustom.cpp:
  • bindings/js/JSHTMLCanvasElementCustom.cpp: (WebCore::JSHTMLCanvasElement::getContext):
  • bindings/js/JSInt16ArrayCustom.cpp:
  • bindings/js/JSInt32ArrayCustom.cpp:
  • bindings/js/JSInt8ArrayCustom.cpp:
  • bindings/js/JSUint16ArrayCustom.cpp:
  • bindings/js/JSUint32ArrayCustom.cpp:
  • bindings/js/JSUint8ArrayCustom.cpp:
  • bindings/js/JSWebGLRenderingContextCustom.cpp:
  • bindings/js/JSXMLHttpRequestCustom.cpp: (WebCore::JSXMLHttpRequest::markChildren): (WebCore::JSXMLHttpRequest::send): (WebCore::JSXMLHttpRequest::response):
  • bindings/v8/custom/V8ArrayBufferCustom.cpp:
  • bindings/v8/custom/V8ArrayBufferViewCustom.h:
  • bindings/v8/custom/V8DataViewCustom.cpp:
  • bindings/v8/custom/V8DocumentCustom.cpp: (WebCore::V8Document::getCSSCanvasContextCallback):
  • bindings/v8/custom/V8Float32ArrayCustom.cpp:
  • bindings/v8/custom/V8HTMLCanvasElementCustom.cpp: (WebCore::V8HTMLCanvasElement::getContextCallback):
  • bindings/v8/custom/V8Int16ArrayCustom.cpp:
  • bindings/v8/custom/V8Int32ArrayCustom.cpp:
  • bindings/v8/custom/V8Int8ArrayCustom.cpp:
  • bindings/v8/custom/V8Uint16ArrayCustom.cpp:
  • bindings/v8/custom/V8Uint32ArrayCustom.cpp:
  • bindings/v8/custom/V8Uint8ArrayCustom.cpp:
  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp: (WebCore::V8XMLHttpRequest::responseAccessorGetter): (WebCore::V8XMLHttpRequest::sendCallback):
  • features.pri:
  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::getContext): (WebCore::HTMLCanvasElement::reset):
  • html/HTMLCanvasElement.h:
  • html/canvas/ArrayBuffer.cpp:
  • html/canvas/ArrayBuffer.idl:
  • html/canvas/ArrayBufferView.cpp:
  • html/canvas/ArrayBufferView.idl:
  • html/canvas/DataView.cpp:
  • html/canvas/DataView.idl:
  • html/canvas/Float32Array.cpp:
  • html/canvas/Float32Array.idl:
  • html/canvas/Int16Array.cpp:
  • html/canvas/Int16Array.idl:
  • html/canvas/Int32Array.cpp:
  • html/canvas/Int32Array.idl:
  • html/canvas/Int8Array.cpp:
  • html/canvas/Int8Array.idl:
  • html/canvas/OESStandardDerivatives.cpp:
  • html/canvas/OESStandardDerivatives.idl:
  • html/canvas/OESTextureFloat.cpp:
  • html/canvas/OESTextureFloat.idl:
  • html/canvas/Uint16Array.cpp:
  • html/canvas/Uint16Array.idl:
  • html/canvas/Uint32Array.cpp:
  • html/canvas/Uint32Array.idl:
  • html/canvas/Uint8Array.cpp:
  • html/canvas/Uint8Array.idl:
  • html/canvas/WebGLActiveInfo.idl:
  • html/canvas/WebGLBuffer.cpp:
  • html/canvas/WebGLBuffer.idl:
  • html/canvas/WebGLContextAttributes.cpp:
  • html/canvas/WebGLContextAttributes.idl:
  • html/canvas/WebGLContextEvent.idl:
  • html/canvas/WebGLExtension.cpp:
  • html/canvas/WebGLFramebuffer.cpp:
  • html/canvas/WebGLFramebuffer.idl:
  • html/canvas/WebGLGetInfo.cpp:
  • html/canvas/WebGLObject.cpp:
  • html/canvas/WebGLProgram.cpp:
  • html/canvas/WebGLProgram.idl:
  • html/canvas/WebGLRenderbuffer.cpp:
  • html/canvas/WebGLRenderbuffer.idl:
  • html/canvas/WebGLRenderingContext.cpp:
  • html/canvas/WebGLRenderingContext.idl:
  • html/canvas/WebGLShader.cpp:
  • html/canvas/WebGLShader.idl:
  • html/canvas/WebGLTexture.cpp:
  • html/canvas/WebGLTexture.idl:
  • html/canvas/WebGLUniformLocation.cpp:
  • html/canvas/WebGLUniformLocation.idl:
  • html/canvas/WebKitLoseContext.cpp:
  • html/canvas/WebKitLoseContext.idl:
  • page/DOMWindow.idl:
  • platform/graphics/ANGLEWebKitBridge.cpp:
  • platform/graphics/GraphicsContext3D.cpp:
  • platform/graphics/cg/GraphicsContext3DCG.cpp:
  • platform/graphics/gpu/DrawingBuffer.cpp:
  • platform/graphics/gpu/mac/DrawingBufferMac.mm:
  • platform/graphics/mac/GraphicsContext3DMac.mm:
  • platform/graphics/mac/WebGLLayer.mm:
  • platform/graphics/opengl/Extensions3DOpenGL.cpp:
  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
  • platform/graphics/qt/Extensions3DQt.cpp:
  • platform/graphics/qt/GraphicsContext3DQt.cpp:
  • platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::GraphicsLayerQtImpl::GraphicsLayerQtImpl): (WebCore::GraphicsLayerQtImpl::paint): (WebCore::GraphicsLayerQtImpl::flushChanges):
  • platform/graphics/qt/GraphicsLayerQt.h:
  • platform/graphics/skia/GraphicsContext3DSkia.cpp:
  • platform/graphics/texmap/GraphicsLayerTextureMapper.h:
  • rendering/RenderLayerBacking.cpp: (WebCore::isAcceleratedCanvas): (WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration): (WebCore::RenderLayerBacking::containsPaintedContent): (WebCore::RenderLayerBacking::contentChanged):
  • webaudio/AudioBuffer.cpp:
  • webaudio/AudioBuffer.idl:
  • webaudio/RealtimeAnalyser.cpp:
  • webaudio/RealtimeAnalyser.h:
  • webaudio/RealtimeAnalyserNode.h:
  • webaudio/RealtimeAnalyserNode.idl:
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::setResponseType): (WebCore::XMLHttpRequest::clearResponse): (WebCore::XMLHttpRequest::didReceiveData):
  • xml/XMLHttpRequest.h:

2011-01-24 Chris Marrin <cmarrin@apple.com>

Reviewed by Eric Seidel.

Change ENABLE_3D_CANVAS to ENABLE_WEBGL
https://bugs.webkit.org/show_bug.cgi?id=53041

  • Configurations/FeatureDefines.xcconfig:
9:22 AM Changeset in webkit [76599] by zimmermann@webkit.org
  • 13 edits
    12 adds in trunk/LayoutTests

2011-01-25 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed.

Update Leopard svg/ pixel test baselines, to make run-webkit-tests -p pass again with --tolerance 0.
Contains only marginal differences, or updates pixel test results that were forgotten to update.

  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.checksum: Added.
  • platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.png: Added.
  • platform/mac-leopard/svg/W3C-SVG-1.1/filters-composite-02-b-expected.checksum:
  • platform/mac-leopard/svg/W3C-SVG-1.1/filters-composite-02-b-expected.png:
  • platform/mac-leopard/svg/W3C-SVG-1.1/struct-image-07-t-expected.checksum: Added.
  • platform/mac-leopard/svg/W3C-SVG-1.1/struct-image-07-t-expected.png: Added.
  • platform/mac-leopard/svg/W3C-SVG-1.1/struct-use-01-t-expected.checksum: Added.
  • platform/mac-leopard/svg/W3C-SVG-1.1/struct-use-01-t-expected.png: Added.
  • platform/mac-leopard/svg/css/text-gradient-shadow-expected.checksum: Added.
  • platform/mac-leopard/svg/css/text-gradient-shadow-expected.png: Added.
  • platform/mac-leopard/svg/custom/image-rescale-clip-expected.checksum:
  • platform/mac-leopard/svg/custom/image-rescale-clip-expected.png:
  • platform/mac-leopard/svg/custom/image-rescale-scroll-expected.checksum: Added.
  • platform/mac-leopard/svg/custom/image-rescale-scroll-expected.png: Added.
  • platform/mac-leopard/svg/custom/junk-data-expected.checksum:
  • platform/mac-leopard/svg/custom/junk-data-expected.png:
  • platform/mac-leopard/svg/custom/missing-xlink-expected.checksum:
  • platform/mac-leopard/svg/custom/missing-xlink-expected.png:
  • platform/mac-leopard/svg/filters/feComposite-expected.checksum:
  • platform/mac-leopard/svg/filters/feComposite-expected.png:
  • platform/mac-leopard/svg/filters/filter-rounding-issues-expected.checksum: Added.
  • platform/mac-leopard/svg/filters/filter-rounding-issues-expected.png: Added.
  • platform/mac-leopard/svg/repaint/filter-repaint-expected.checksum:
  • platform/mac-leopard/svg/repaint/filter-repaint-expected.png:
9:14 AM Changeset in webkit [76598] by Adam Roben
  • 2 edits in trunk/Source/JavaScriptCore

Windows Production build fix

9:11 AM Changeset in webkit [76597] by mnaganov@chromium.org
  • 17 edits
    2 adds in trunk/Source

2011-01-25 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Chromium] Prepare for landing of detailed heap snapshots.

  • Introduce Preferences.detailedHeapProfiles flag for controlling querying of detailed heap snapshots.
  • Add boilerplate code for the new view.
  • Factor out common code.

https://bugs.webkit.org/show_bug.cgi?id=52624

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • bindings/js/ScriptProfiler.h: (WebCore::ScriptProfiler::HeapSnapshotControl::~HeapSnapshotControl): (WebCore::ScriptProfiler::takeHeapSnapshot):
  • bindings/v8/ScriptProfiler.cpp: (WebCore::ScriptProfiler::takeHeapSnapshot):
  • bindings/v8/ScriptProfiler.h: (WebCore::ScriptProfiler::HeapSnapshotControl::~HeapSnapshotControl):
  • inspector/Inspector.idl:
  • inspector/InspectorProfilerAgent.cpp: (WebCore::InspectorProfilerAgent::takeHeapSnapshot):
  • inspector/InspectorProfilerAgent.h:
  • inspector/front-end/DetailedHeapshotView.js: Added. (WebInspector.DetailedHeapshotView): (WebInspector.DetailedHeapshotView.prototype.get statusBarItems): (WebInspector.DetailedHeapshotView.prototype.get profile): (WebInspector.DetailedHeapshotView.prototype.set profile): (WebInspector.DetailedHeapshotView.prototype.show): (WebInspector.DetailedHeapshotView.prototype.hide): (WebInspector.DetailedHeapshotProfileType): (WebInspector.DetailedHeapshotProfileType.prototype.get buttonTooltip): (WebInspector.DetailedHeapshotProfileType.prototype.get buttonStyle): (WebInspector.DetailedHeapshotProfileType.prototype.buttonClicked): (WebInspector.DetailedHeapshotProfileType.prototype.get welcomeMessage): (WebInspector.DetailedHeapshotProfileType.prototype.createSidebarTreeElementForProfile): (WebInspector.DetailedHeapshotProfileType.prototype.createView):
  • inspector/front-end/HeapSnapshot.js: Added. (WebInspector.HeapSnapshotEdgesIterator): (WebInspector.HeapSnapshotEdgesIterator.prototype.get done): (WebInspector.HeapSnapshotEdgesIterator.prototype.get isElement): (WebInspector.HeapSnapshotEdgesIterator.prototype.get isHidden): (WebInspector.HeapSnapshotEdgesIterator.prototype.get name): (WebInspector.HeapSnapshotEdgesIterator.prototype.next): (WebInspector.HeapSnapshotEdgesIterator.prototype.get node): (WebInspector.HeapSnapshotEdgesIterator.prototype.get nodeIndex): (WebInspector.HeapSnapshotEdgesIterator.prototype._getNameOrIndex): (WebInspector.HeapSnapshotEdgesIterator.prototype._getType): (WebInspector.HeapSnapshotNodeWrapper): (WebInspector.HeapSnapshotNodeWrapper.prototype.get edges): (WebInspector.HeapSnapshotNodeWrapper.prototype.get edgesCount): (WebInspector.HeapSnapshotNodeWrapper.prototype.get instancesCount): (WebInspector.HeapSnapshotNodeWrapper.prototype.get isHidden): (WebInspector.HeapSnapshotNodeWrapper.prototype.get name): (WebInspector.HeapSnapshotNodeWrapper.prototype.get selfSize): (WebInspector.HeapSnapshotNodeWrapper.prototype._getName): (WebInspector.HeapSnapshotNodeWrapper.prototype._getEdges): (WebInspector.HeapSnapshotNodeWrapper.prototype._getType): (WebInspector.HeapSnapshot): (WebInspector.HeapSnapshot.prototype._init): (WebInspector.HeapSnapshot.prototype.get rootEdges):
  • inspector/front-end/HeapSnapshotView.js: (WebInspector.HeapSnapshotProfileType.prototype.buttonClicked):
  • inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype._setRecordingProfile): (WebInspector.ProfilesPanel.prototype._reportHeapSnapshotProgress): (WebInspector.ProfilerDispatcher.prototype.setRecordingProfile): (WebInspector.ProfilerDispatcher.prototype.reportHeapSnapshotProgress):
  • inspector/front-end/Settings.js:
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js: (WebInspector._createPanels):
  • src/js/DevTools.js: ():
9:10 AM Changeset in webkit [76596] by zimmermann@webkit.org
  • 67 edits in trunk/LayoutTests

2011-01-25 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed.

Update Snow Leopard svg/ pixel test baselines, to make run-webkit-tests -p pass again with --tolerance 0.
Contains only marginal differences, or updates pixel test results that were forgotten to update.

  • platform/mac/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/filters-composite-02-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/filters-composite-02-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/struct-image-06-t-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/struct-image-06-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/struct-image-07-t-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/struct-image-07-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/struct-use-01-t-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/struct-use-01-t-expected.png:
  • platform/mac/svg/batik/text/textEffect-expected.checksum:
  • platform/mac/svg/batik/text/textEffect-expected.png:
  • platform/mac/svg/batik/text/textEffect3-expected.checksum:
  • platform/mac/svg/batik/text/textEffect3-expected.png:
  • platform/mac/svg/custom/baseval-animval-equality-expected.checksum:
  • platform/mac/svg/custom/baseval-animval-equality-expected.png:
  • platform/mac/svg/custom/foreign-object-skew-expected.checksum:
  • platform/mac/svg/custom/foreign-object-skew-expected.png:
  • platform/mac/svg/custom/image-rescale-expected.checksum:
  • platform/mac/svg/custom/image-rescale-expected.png:
  • platform/mac/svg/custom/svg-fonts-in-html-expected.checksum:
  • platform/mac/svg/custom/svg-fonts-in-html-expected.png:
  • platform/mac/svg/custom/svg-fonts-with-no-element-reference-expected.checksum:
  • platform/mac/svg/custom/svg-fonts-with-no-element-reference-expected.png:
  • platform/mac/svg/custom/svg-fonts-without-missing-glyph-expected.checksum:
  • platform/mac/svg/custom/svg-fonts-without-missing-glyph-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-expected.png:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.checksum:
  • platform/mac/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.png:
  • platform/mac/svg/filters/feComposite-expected.checksum:
  • platform/mac/svg/filters/feComposite-expected.png:
  • platform/mac/svg/filters/filter-rounding-issues-expected.checksum:
  • platform/mac/svg/filters/filter-rounding-issues-expected.png:
  • platform/mac/svg/filters/filteredImage-expected.checksum:
  • platform/mac/svg/filters/filteredImage-expected.png:
  • platform/mac/svg/repaint/filter-repaint-expected.checksum:
  • platform/mac/svg/repaint/filter-repaint-expected.png:
  • platform/mac/svg/text/text-text-05-t-expected.checksum:
  • platform/mac/svg/text/text-text-05-t-expected.png:
  • platform/mac/svg/text/text-text-06-t-expected.checksum:
  • platform/mac/svg/text/text-text-06-t-expected.png:
8:48 AM Changeset in webkit [76595] by paroga@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-01-25 Patrick Gansterer <paroga@webkit.org>

Reviewed by Eric Seidel.

Add missing defines for COMPILER(RVCT) && CPU(ARM_THUMB2)
https://bugs.webkit.org/show_bug.cgi?id=52949

  • jit/JITStubs.cpp:
8:09 AM Changeset in webkit [76594] by yurys@chromium.org
  • 15 edits in trunk/Source

2011-01-25 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: remove "attached" state related methods from InspectorAgent
https://bugs.webkit.org/show_bug.cgi?id=53086

  • WebCore.exp.in:
  • inspector/InspectorAgent.cpp:
  • inspector/InspectorAgent.h:
  • inspector/InspectorFrontendClientLocal.cpp: (WebCore::InspectorFrontendClientLocal::changeAttachedWindowHeight): (WebCore::InspectorFrontendClientLocal::restoreAttachedWindowHeight):
  • inspector/InspectorSettings.cpp: (WebCore::InspectorSettings::InspectorSettings):
  • inspector/InspectorSettings.h:

2011-01-25 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: remove "attached" state related methods from InspectorAgent
https://bugs.webkit.org/show_bug.cgi?id=53086

  • WebCoreSupport/WebInspectorClientCF.cpp: (WebInspectorClient::sendMessageToFrontend): (WebInspectorClient::inspectorStartsAttached): (WebInspectorClient::setInspectorStartsAttached): (WebInspectorClient::releaseFrontendPage):

2011-01-25 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: remove "attached" state related methods from InspectorAgent
https://bugs.webkit.org/show_bug.cgi?id=53086

  • WebCoreSupport/WebInspectorClient.h:
  • WebCoreSupport/WebInspectorClient.mm: (-[WebInspectorWindowController showWindow:]): (-[WebInspectorWindowController attach]): (-[WebInspectorWindowController detach]):

2011-01-25 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: remove "attached" state related methods from InspectorAgent
https://bugs.webkit.org/show_bug.cgi?id=53086

  • WebCoreSupport/WebInspectorClient.cpp: (WebInspectorFrontendClient::attachWindow): (WebInspectorFrontendClient::detachWindow): (WebInspectorFrontendClient::showWindowWithoutNotifications):
  • WebCoreSupport/WebInspectorClient.h:
7:46 AM Changeset in webkit [76593] by Carlos Garcia Campos
  • 2 edits in trunk/LayoutTests

2011-01-25 Carlos Garcia Campos <cgarcia@igalia.com>

Unreviewed, add bug url for failing test on GTK.

[cairo] Fix LayoutTests/fast/canvas/patternfill-repeat.html
https://bugs.webkit.org/show_bug.cgi?id=53085

  • platform/gtk/Skipped:
7:24 AM Changeset in webkit [76592] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebCore

2011-01-25 Qi Zhang <qi.2.zhang@nokia.com>

Reviewed by Laszlo Gombos.

[Symbian] RVCT fails to compile [U|I]nt[8|16|32]Array.h
https://bugs.webkit.org/show_bug.cgi?id=51873

Replace the using declaration, because it doesn't compile on RVCT, and WINSCW has the same issue.
No new functionality so no new tests.

  • html/canvas/Int32Array.h: (WebCore::Int32Array::set):
  • html/canvas/Int8Array.h: (WebCore::Int8Array::set):
  • html/canvas/Uint16Array.h: (WebCore::Uint16Array::set):
  • html/canvas/Uint32Array.h: (WebCore::Uint32Array::set):
  • html/canvas/Uint8Array.h: (WebCore::Uint8Array::set):
7:15 AM Changeset in webkit [76591] by mario@webkit.org
  • 3 edits in trunk/LayoutTests

2011-01-25 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Antonio Gomes.

fast/spatial-navigation/snav-unit-overflow-and-scroll-in-direction.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=53073

Make the two steps in the flaky test to be executed sequentially.

  • fast/spatial-navigation/snav-unit-overflow-and-scroll-in-direction.html: Fix flaky test by chaining its two steps up.
  • platform/gtk/Skipped: Unskip test.
7:10 AM Changeset in webkit [76590] by zherczeg@webkit.org
  • 14 edits in trunk/Source/WebCore

Repaint SVG elements with filter instead of relayout where possible
https://bugs.webkit.org/show_bug.cgi?id=52200

Reviewed by Dirk Schulze.

This patch allows repainting of filters, when their
attribute changes does not require relayout.

Existing dynamic-update tests cover this feature.

  • platform/graphics/filters/FilterEffect.cpp:

(WebCore::FilterEffect::clearResult): Clearing the currently stored image
before repainting.

  • platform/graphics/filters/FilterEffect.h:
  • rendering/RenderObject.h:

(WebCore::RenderObject::isSVGResourceFilter): Not only the filter primitives,
but filters should also be detected to allow safe testing and casting.

  • rendering/svg/RenderSVGResourceFilter.cpp:

(WebCore::RenderSVGResourceFilter::buildPrimitives): Passing the renderer.
(WebCore::RenderSVGResourceFilter::applyResource):
determineFilterPrimitiveSubregion does not require the filter anymore.
(WebCore::RenderSVGResourceFilter::postApplyResource): Repaint
if lastEffect->hasResult() is false.
(WebCore::RenderSVGResourceFilter::primitiveAttributeChanged):
Searching for all FilterEffects, whose created by the current FilterElement,
and clearing all resulting images depending on those FilterEffects.

  • rendering/svg/RenderSVGResourceFilter.h:

(WebCore::RenderSVGResourceFilter::isSVGResourceFilter):

  • rendering/svg/RenderSVGResourceFilterPrimitive.cpp:

(WebCore::RenderSVGResourceFilterPrimitive::determineFilterPrimitiveSubregion):
The filter argument is unnecessary anymore. But is is still kept as a static
member, since the primitive renderer still does not know about the
FilterEffect objects.

  • rendering/svg/RenderSVGResourceFilterPrimitive.h:

(WebCore::RenderSVGResourceFilterPrimitive::RenderSVGResourceFilterPrimitive):
(WebCore::RenderSVGResourceFilterPrimitive::primitiveAttributeChanged):
Calls RenderSVGResourceFilter::primitiveAttributeChanged.

  • svg/SVGFEDiffuseLightingElement.cpp:

(WebCore::SVGFEDiffuseLightingElement::setFilterEffectAttribute):
Setting the new attribute value for each FilterEffect.
(WebCore::SVGFEDiffuseLightingElement::svgAttributeChanged):

  • svg/SVGFEDiffuseLightingElement.h:

Calling primitiveAttributeChanged.

  • svg/SVGFilterPrimitiveStandardAttributes.cpp:

(WebCore::SVGFilterPrimitiveStandardAttributes::setFilterEffectAttribute):
This function will be removed when all FilterElement implements
their setFilterEffectAttribute

  • svg/SVGFilterPrimitiveStandardAttributes.h:

(WebCore::SVGFilterPrimitiveStandardAttributes::primitiveAttributeChanged):

  • svg/graphics/filters/SVGFilterBuilder.cpp:

(WebCore::SVGFilterBuilder::appendEffectToEffectReferences): The
renderers are assigned to the filter effects.
(WebCore::SVGFilterBuilder::clearEffects):
(WebCore::SVGFilterBuilder::clearResultsRecursive): Recursively
clearing the result images for those filters, whose depend on
the starting filter.

  • svg/graphics/filters/SVGFilterBuilder.h:

(WebCore::SVGFilterBuilder::effectReferences): 'get' is unnecessary
(WebCore::SVGFilterBuilder::effectByRenderer): returns the
FilterEffect belongs to this RenderObject.

5:46 AM Changeset in webkit [76589] by krit@webkit.org
  • 4 edits
    3 adds in trunk

2011-01-25 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG is missing to-animation support for Path
https://bugs.webkit.org/show_bug.cgi?id=52982

Added an animation test to check 'to' animations in combination with SVG paths.

  • svg/animations/animate-path-to-animation-expected.txt: Added.
  • svg/animations/animate-path-to-animation.html: Added.
  • svg/animations/script-tests/animate-path-to-animation.js: Added. (sample1): (sample2): (sample3): (executeTest):

2011-01-25 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG is missing to-animation support for Path
https://bugs.webkit.org/show_bug.cgi?id=52982

SVG was missing 'to' animation support for SVG paths. Even the fallback to discrete
animation did not work and an assert was thrown, because of the missing m_fromPath.
This also influences a test of the W3C test suite. Subtest 2 of animate-elem-83-t.svg passes now.

Test: svg/animations/animate-path-to-animation.html

  • svg/SVGAnimateElement.cpp: (WebCore::SVGAnimateElement::calculateAnimatedValue): Take the value of the last SVGAnimateElement for m_fromPath, since 'to' animations are accumulative. (WebCore::SVGAnimateElement::calculateFromAndToValues): Added support for 'to' animations. (WebCore::SVGAnimateElement::resetToBaseValue): Set m_animatedPath on the first animation element to baseVal.
  • svg/SVGPathByteStream.h: (WebCore::SVGPathByteStream::copySVGPathByteStream): Return copy of current byte stream.
5:34 AM Changeset in webkit [76588] by zimmermann@webkit.org
  • 22 edits in trunk/LayoutTests

2011-01-25 Nikolas Zimmermann <nzimmermann@rim.com>

Introduce FontMetrics abstraction
https://bugs.webkit.org/show_bug.cgi?id=51456

Update gtk/qt baseline.

  • platform/gtk/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt:
  • platform/gtk/svg/custom/svg-fonts-without-missing-glyph-expected.txt:
  • platform/gtk/svg/text/text-hkern-expected.txt:
  • platform/gtk/svg/text/text-hkern-on-vertical-text-expected.txt:
  • platform/gtk/svg/text/text-vkern-expected.txt:
  • platform/gtk/svg/text/text-vkern-on-horizontal-text-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.txt:
  • platform/qt/svg/custom/svg-fonts-with-no-element-reference-expected.txt:
  • platform/qt/svg/custom/svg-fonts-without-missing-glyph-expected.txt:
  • platform/qt/svg/text/text-hkern-expected.txt:
  • platform/qt/svg/text/text-hkern-on-vertical-text-expected.txt:
  • platform/qt/svg/text/text-vkern-expected.txt:
  • platform/qt/svg/text/text-vkern-on-horizontal-text-expected.txt:
  • platform/qt/svg/transforms/text-with-mask-with-svg-transform-expected.txt:
5:32 AM Changeset in webkit [76587] by pfeldman@chromium.org
  • 11 edits in trunk

2011-01-25 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: bind resources to URLs upon adding them into the tree.
https://bugs.webkit.org/show_bug.cgi?id=53013

  • inspector/debugger-scripts-expected.txt:
  • inspector/debugger-scripts.html:

2011-01-25 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: bind resources to URLs upon adding them into the tree.
https://bugs.webkit.org/show_bug.cgi?id=53013

  • inspector/front-end/AuditRules.js: (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback.selectorsCallback):
  • inspector/front-end/CSSStyleModel.js: (WebInspector.CSSStyleModel.prototype._styleSheetChanged.callback): (WebInspector.CSSStyleModel.prototype._styleSheetChanged):
  • inspector/front-end/DebuggerModel.js: (WebInspector.DebuggerModel.prototype._parsedScriptSource):
  • inspector/front-end/NetworkManager.js: (WebInspector.NetworkManager.prototype._processCachedResources): (WebInspector.NetworkManager.prototype.inflightResourceForURL): (WebInspector.NetworkDispatcher): (WebInspector.NetworkDispatcher.prototype.willSendRequest): (WebInspector.NetworkDispatcher.prototype.markResourceAsCached): (WebInspector.NetworkDispatcher.prototype.didReceiveResponse): (WebInspector.NetworkDispatcher.prototype.didReceiveContentLength): (WebInspector.NetworkDispatcher.prototype.didFinishLoading): (WebInspector.NetworkDispatcher.prototype.didFailLoading): (WebInspector.NetworkDispatcher.prototype.willSendWebSocketHandshakeRequest): (WebInspector.NetworkDispatcher.prototype.didReceiveWebSocketHandshakeResponse): (WebInspector.NetworkDispatcher.prototype.didCloseWebSocket): (WebInspector.NetworkDispatcher.prototype._appendRedirect): (WebInspector.NetworkDispatcher.prototype._startResource): (WebInspector.NetworkDispatcher.prototype._finishResource): (WebInspector.NetworkDispatcher.prototype._createResource):
  • inspector/front-end/ResourceTreeModel.js: (WebInspector.ResourceTreeModel.prototype.addResourceToFrame): (WebInspector.ResourceTreeModel.prototype._bindResourceURL): (WebInspector.ResourceTreeModel.prototype._clearResources): (WebInspector.ResourceTreeModel.prototype._unbindResourceURL):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.canShowSourceLine): (WebInspector.ResourcesPanel.prototype.showSourceLine):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._parsedScriptSource): (WebInspector.ScriptsPanel.prototype._addScript):
4:47 AM Changeset in webkit [76586] by zimmermann@webkit.org
  • 42 edits in trunk

2011-01-25 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Introduce FontMetrics abstraction
https://bugs.webkit.org/show_bug.cgi?id=51456

Use accurate floating-point metrics for SVG Font calculations instead of casting float -> integer.
This hopefully fixes differences between 32/64 bit bots.

Needs new layout test results for several platforms, which need to be taken from the bots landing afterwards.

  • platform/graphics/SimpleFontData.cpp: (WebCore::SimpleFontData::SimpleFontData): (WebCore::SimpleFontData::initCharWidths):

2011-01-25 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Introduce FontMetrics abstraction
https://bugs.webkit.org/show_bug.cgi?id=51456

Update mac/mac-leopard pixel baseline after removing the float -> int truncation in the SVG Fonts ascent/descent calculation code.

  • platform/gtk/Skipped: Unskip several tests.
  • platform/mac-leopard/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.checksum:
  • platform/mac-leopard/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.png:
  • platform/mac-leopard/svg/batik/text/textEffect-expected.checksum:
  • platform/mac-leopard/svg/batik/text/textEffect-expected.png:
  • platform/mac-leopard/svg/batik/text/textEffect3-expected.checksum:
  • platform/mac-leopard/svg/batik/text/textEffect3-expected.png:
  • platform/mac-leopard/svg/custom/svg-fonts-in-html-expected.checksum:
  • platform/mac-leopard/svg/custom/svg-fonts-in-html-expected.png:
  • platform/mac-leopard/svg/custom/svg-fonts-with-no-element-reference-expected.checksum:
  • platform/mac-leopard/svg/custom/svg-fonts-with-no-element-reference-expected.png:
  • platform/mac-leopard/svg/custom/svg-fonts-without-missing-glyph-expected.checksum:
  • platform/mac-leopard/svg/custom/svg-fonts-without-missing-glyph-expected.png:
  • platform/mac-leopard/svg/text/text-text-05-t-expected.checksum:
  • platform/mac-leopard/svg/text/text-text-05-t-expected.png:
  • platform/mac-leopard/svg/text/text-text-06-t-expected.checksum:
  • platform/mac-leopard/svg/text/text-text-06-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-24-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.png:
  • platform/mac/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-text-05-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-text-06-t-expected.txt:
  • platform/mac/svg/batik/text/textEffect-expected.txt:
  • platform/mac/svg/batik/text/textEffect3-expected.txt:
  • platform/mac/svg/batik/text/textPosition2-expected.png:
  • platform/mac/svg/batik/text/textPosition2-expected.txt:
  • platform/mac/svg/custom/svg-fonts-in-html-expected.txt:
  • platform/mac/svg/custom/svg-fonts-with-no-element-reference-expected.txt:
  • platform/mac/svg/custom/svg-fonts-without-missing-glyph-expected.txt:
  • platform/mac/svg/text/text-text-05-t-expected.txt:
  • platform/mac/svg/text/text-text-06-t-expected.txt:
  • svg/custom/glyph-transformation-with-hkern-expected.txt:

-This line, and those below, will be ignored--

M LayoutTests/platform/mac-leopard/svg/text/text-text-05-t-expected.checksum
M LayoutTests/platform/mac-leopard/svg/text/text-text-06-t-expected.checksum
M LayoutTests/platform/mac-leopard/svg/text/text-text-05-t-expected.png
M LayoutTests/platform/mac-leopard/svg/text/text-text-06-t-expected.png
M LayoutTests/platform/mac-leopard/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.png
M LayoutTests/platform/mac-leopard/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.checksum
M LayoutTests/platform/mac-leopard/svg/batik/text/textEffect3-expected.checksum
M LayoutTests/platform/mac-leopard/svg/batik/text/textEffect-expected.checksum
M LayoutTests/platform/mac-leopard/svg/batik/text/textEffect-expected.png
M LayoutTests/platform/mac-leopard/svg/batik/text/textEffect3-expected.png
M LayoutTests/platform/mac-leopard/svg/custom/svg-fonts-without-missing-glyph-expected.png
M LayoutTests/platform/mac-leopard/svg/custom/svg-fonts-with-no-element-reference-expected.checksum
M LayoutTests/platform/mac-leopard/svg/custom/svg-fonts-in-html-expected.checksum
M LayoutTests/platform/mac-leopard/svg/custom/svg-fonts-without-missing-glyph-expected.checksum
M LayoutTests/platform/mac-leopard/svg/custom/svg-fonts-with-no-element-reference-expected.png
M LayoutTests/platform/mac-leopard/svg/custom/svg-fonts-in-html-expected.png
M LayoutTests/platform/mac/svg/text/text-text-06-t-expected.txt
M LayoutTests/platform/mac/svg/text/text-text-05-t-expected.txt
M LayoutTests/platform/mac/svg/W3C-SVG-1.1/text-text-05-t-expected.txt
M LayoutTests/platform/mac/svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt
M LayoutTests/platform/mac/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.txt
M LayoutTests/platform/mac/svg/W3C-SVG-1.1/text-text-06-t-expected.txt
M LayoutTests/platform/mac/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.txt
M LayoutTests/platform/mac/svg/W3C-SVG-1.1/animate-elem-24-t-expected.png
M LayoutTests/platform/mac/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.txt
M LayoutTests/platform/mac/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.png
M LayoutTests/platform/mac/svg/batik/text/textEffect3-expected.txt
M LayoutTests/platform/mac/svg/batik/text/textPosition2-expected.png
M LayoutTests/platform/mac/svg/batik/text/textEffect-expected.txt
M LayoutTests/platform/mac/svg/batik/text/textPosition2-expected.txt
M LayoutTests/platform/mac/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.txt
M LayoutTests/platform/mac/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt
M LayoutTests/platform/mac/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.txt
M LayoutTests/platform/mac/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt
M LayoutTests/platform/mac/svg/custom/svg-fonts-in-html-expected.txt
M LayoutTests/platform/mac/svg/custom/svg-fonts-with-no-element-reference-expected.txt
M LayoutTests/platform/mac/svg/custom/svg-fonts-without-missing-glyph-expected.txt
M LayoutTests/platform/gtk/Skipped
M LayoutTests/ChangeLog
M LayoutTests/svg/custom/glyph-transformation-with-hkern-expected.txt
M Source/WebCore/ChangeLog
M Source/WebCore/platform/graphics/SimpleFontData.cpp

4:43 AM Changeset in webkit [76585] by andreas.kling@nokia.com
  • 4 edits in trunk/Source/WebKit2

2011-01-25 Andreas Kling <kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt][WK2] Add QWKPage::processCrashed() signal
https://bugs.webkit.org/show_bug.cgi?id=53076

  • UIProcess/API/qt/qwkpage.cpp: (QWKPagePrivate::processDidCrash):
  • UIProcess/API/qt/qwkpage.h:
  • UIProcess/API/qt/qwkpage_p.h:
3:43 AM Changeset in webkit [76584] by kov@webkit.org
  • 2 edits in trunk/Tools

2011-01-25 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Andreas Kling.

[GTK] Remove 64 bits release bot from the buildbot master
https://bugs.webkit.org/show_bug.cgi?id=52899

Removes the 64 bits release slave from the buildbot configuration,
so that we can use it as an EWS.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
3:38 AM Changeset in webkit [76583] by mario@webkit.org
  • 2 edits in trunk/LayoutTests

2011-01-25 Mario Sanchez Prada <msanchez@igalia.com>

Unreviewed, skipping flaky test on GTK debug bots.

editing/selection/extend-selection-bidi.html test is flaky
https://bugs.webkit.org/show_bug.cgi?id=53074

  • platform/gtk/Skipped: Skipped test.
3:09 AM Changeset in webkit [76582] by mario@webkit.org
  • 2 edits in trunk/LayoutTests

2011-01-25 Mario Sanchez Prada <msanchez@igalia.com>

Unreviewed, skipping flaky test on GTK debug bots.

fast/spatial-navigation/snav-unit-overflow-and-scroll-in-direction.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=53073

  • platform/gtk/Skipped: Skipped test.
1:44 AM Changeset in webkit [76581] by podivilov@chromium.org
  • 11 edits in trunk/Source/WebCore

2011-01-24 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: debugger and browser debugger agents should manage sticky breakpoints independently.
https://bugs.webkit.org/show_bug.cgi?id=52999

  • inspector/Inspector.idl:
  • inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::didCommitLoad): (WebCore::InspectorAgent::enableDebugger): (WebCore::InspectorAgent::inspectedURLWithoutFragment):
  • inspector/InspectorAgent.h:
  • inspector/InspectorBrowserDebuggerAgent.cpp: (WebCore::InspectorBrowserDebuggerAgent::setAllBrowserBreakpoints): (WebCore::InspectorBrowserDebuggerAgent::inspectedURLChanged): (WebCore::InspectorBrowserDebuggerAgent::restoreStickyBreakpoint):
  • inspector/InspectorBrowserDebuggerAgent.h:
  • inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent): (WebCore::InspectorDebuggerAgent::setAllJavaScriptBreakpoints): (WebCore::InspectorDebuggerAgent::inspectedURLChanged): (WebCore::InspectorDebuggerAgent::restoreBreakpoints):
  • inspector/InspectorDebuggerAgent.h:
  • inspector/InspectorState.cpp: (WebCore::InspectorState::InspectorState):
  • inspector/InspectorState.h:
  • inspector/front-end/BreakpointManager.js: (WebInspector.BreakpointManager): (WebInspector.BreakpointManager.prototype._projectChanged): (WebInspector.BreakpointManager.prototype._saveBreakpoints): (WebInspector.BreakpointManager.prototype._pushBreakpointsToBackend):
1:19 AM Changeset in webkit [76580] by mjs@apple.com
  • 2 edits in trunk/LayoutTests

2011-01-24 Maciej Stachowiak <mjs@apple.com>

Reviewed by Nikolas Zimmermann.

Skip some new tests for WebKit2 that use eventSender
https://bugs.webkit.org/show_bug.cgi?id=53068

  • platform/mac-wk2/Skipped:
1:15 AM Changeset in webkit [76579] by podivilov@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-01-25 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, trivial debugger test fix.

  • src/js/Tests.js:
12:43 AM Changeset in webkit [76578] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebCore

2011-01-25 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Crash in some pages containing flash
https://bugs.webkit.org/show_bug.cgi?id=53016

Flash plugin can produce X errors that are handled by the GDK X
error handler, which exits the process. Since we don't want to
crash due to flash bugs, we install a custom error handler to show
a warning when a X error happens without aborting.

  • plugins/gtk/PluginPackageGtk.cpp: (WebCore::webkitgtkXError): (WebCore::PluginPackage::load):
12:33 AM Changeset in webkit [76577] by Carlos Garcia Campos
  • 4 edits in trunk/Source/WebCore

2011-01-25 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Implement spin buttons in RenderThemeGtk
https://bugs.webkit.org/show_bug.cgi?id=51454

Paint inner up/down buttons for spin button elements when building
with GTK+ 3.x.

Test results will land with the GTK+ 2.x version of this patch.

  • platform/gtk/RenderThemeGtk.h:
  • platform/gtk/RenderThemeGtk2.cpp: (WebCore::RenderThemeGtk::adjustInnerSpinButtonStyle): (WebCore::RenderThemeGtk::paintInnerSpinButton):
  • platform/gtk/RenderThemeGtk3.cpp: (WebCore::spinButtonArrowSize): (WebCore::RenderThemeGtk::adjustInnerSpinButtonStyle): (WebCore::paintSpinArrowButton): (WebCore::RenderThemeGtk::paintInnerSpinButton):

Jan 24, 2011:

10:44 PM Changeset in webkit [76576] by mihaip@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-01-24 Mihai Parparita <mihaip@chromium.org>

Unreviewed. Missed move of one m_deleted use to be outside NDEBUG block
in r76575.

  • loader/cache/CachedResource.cpp: (WebCore::CachedResource::~CachedResource):
10:17 PM Changeset in webkit [76575] by mihaip@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-01-24 Mihai Parparita <mihaip@chromium.org>

Reviewed by Tony Chang.

Add runtime checks for invariants in memory cache
https://bugs.webkit.org/show_bug.cgi?id=53059

To help track down bug 53045, add some CRASH calls in addition to
ASSERTs, so that we can track down failures in reliability bots.

Just some checks, no new tests necessary.

  • css/CSSImageValue.cpp: (WebCore::CSSImageValue::cachedImage):
  • loader/cache/CachedResource.h:
  • loader/cache/CachedResource.cpp: (WebCore::CachedResource::~CachedResource):
10:15 PM Changeset in webkit [76574] by mjs@apple.com
  • 2 edits in trunk/Tools

2011-01-24 Maciej Stachowiak <mjs@apple.com>

Reviewed by Dan Bernstein.

Implement database quota callback to fix storage tests on WebKit2 bot
https://bugs.webkit.org/show_bug.cgi?id=53064

  • WebKitTestRunner/TestController.cpp: (WTR::exceededDatabaseQuota): (WTR::TestController::createOtherPage): (WTR::TestController::initialize):
10:09 PM Changeset in webkit [76573] by simon.fraser@apple.com
  • 2 edits in trunk/Source/WebCore

2011-01-24 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

Leaking CSSRuleDataList objects
https://bugs.webkit.org/show_bug.cgi?id=53062

Fix leaked CSSRuleDataLists added to the m_pseudoRules hash.

  • css/CSSStyleSelector.cpp: (WebCore::CSSRuleSet::~CSSRuleSet):
10:05 PM Changeset in webkit [76572] by tkent@chromium.org
  • 8 edits in trunk/LayoutTests

2011-01-24 Kent Tamura <tkent@chromium.org>

Unreviewed, test expectation update.

Chromium-Linux rebaseline for r76567.

  • platform/chromium-linux/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.checksum:
  • platform/chromium-linux/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.png:
  • platform/chromium-linux/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt:
  • platform/chromium-linux/fast/speech/input-appearance-numberandspeech-expected.checksum:
  • platform/chromium-linux/fast/speech/input-appearance-numberandspeech-expected.png:
  • platform/chromium-linux/fast/speech/input-appearance-numberandspeech-expected.txt:
  • platform/chromium/test_expectations.txt:
9:52 PM Changeset in webkit [76571] by simon.fraser@apple.com
  • 18 edits in trunk/Source/WebCore

2011-01-24 Simon Fraser <simon.fraser@apple.com>

Reviewed by Eric Seidel.

Refcount Images used in rendering code
https://bugs.webkit.org/show_bug.cgi?id=52701

Change StyleImage::image(RenderObject*, const IntSize&) and
CSSImageGeneratorValue::image(RenderObject*, const IntSize&) to
return PassRefPtr<Image>, and adjust other code accordingly.

This allows us to return one-time images, for example for CSS gradients
whose appearance may change depending on factors other than the renderer
and the destination size.

  • css/CSSCanvasValue.cpp: (WebCore::CSSCanvasValue::image):
  • css/CSSCanvasValue.h:
  • css/CSSGradientValue.cpp: (WebCore::CSSGradientValue::image):
  • css/CSSGradientValue.h:
  • css/CSSImageGeneratorValue.h:
  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintFillLayerExtended): (WebCore::RenderBoxModelObject::paintNinePieceImage):
  • rendering/RenderImage.cpp: (WebCore::RenderImage::paintReplaced): (WebCore::RenderImage::paintIntoRect):
  • rendering/RenderImageResource.h: (WebCore::RenderImageResource::image):
  • rendering/RenderImageResourceStyleImage.h: (WebCore::RenderImageResourceStyleImage::image):
  • rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::paint):
  • rendering/style/StyleCachedImage.cpp: (WebCore::StyleCachedImage::image):
  • rendering/style/StyleCachedImage.h:
  • rendering/style/StyleGeneratedImage.cpp: (WebCore::StyleGeneratedImage::image):
  • rendering/style/StyleGeneratedImage.h:
  • rendering/style/StyleImage.h:
  • rendering/style/StylePendingImage.h: (WebCore::StylePendingImage::image):
  • rendering/svg/RenderSVGImage.cpp: (WebCore::RenderSVGImage::paint):
9:38 PM Changeset in webkit [76570] by mrobinson@webkit.org
  • 2 edits in trunk/LayoutTests

2011-01-24 Martin Robinson <mrobinson@igalia.com>

Skip a slightly different set of tests after r76555. Seems that some of these
failures are cascading.

  • platform/gtk/Skipped: Update the skipped list.
9:17 PM Changeset in webkit [76569] by tony@chromium.org
  • 44 edits
    7 adds
    36 deletes in trunk

2011-01-24 Tony Chang <tony@chromium.org>

Unreviewed, reverting 5 changes of baselines that are incorrect for Linux.
Mark win tests as failing for now.

  • platform/chromium-linux/fast/css/acid2-expected.txt: Removed.
  • platform/chromium-linux/fast/css/acid2-pixel-expected.checksum:
  • platform/chromium-linux/fast/css/acid2-pixel-expected.png:
  • platform/chromium-linux/fast/css/acid2-pixel-expected.txt: Removed.
  • platform/chromium-linux/fast/forms/button-sizes-expected.checksum:
  • platform/chromium-linux/fast/forms/button-sizes-expected.png:
  • platform/chromium-linux/fast/forms/button-sizes-expected.txt:
  • platform/chromium-linux/fast/forms/input-button-sizes-expected.checksum:
  • platform/chromium-linux/fast/forms/input-button-sizes-expected.png:
  • platform/chromium-linux/fast/forms/input-button-sizes-expected.txt:
  • platform/chromium-linux/http/tests/misc/acid2-expected.txt: Removed.
  • platform/chromium-linux/http/tests/misc/acid2-pixel-expected.checksum:
  • platform/chromium-linux/http/tests/misc/acid2-pixel-expected.png:
  • platform/chromium-linux/http/tests/misc/acid2-pixel-expected.txt: Removed.
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt: Removed.
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt: Removed.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-03-t-expected.txt: Removed.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt: Removed.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-36-t-expected.txt: Removed.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-40-t-expected.txt: Removed.
  • platform/chromium-linux/svg/W3C-SVG-1.1/fonts-desc-02-t-expected.txt: Removed.
  • platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.txt: Removed.
  • platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.txt: Removed.
  • platform/chromium-linux/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.txt: Removed.
  • platform/chromium-linux/svg/W3C-SVG-1.1/interact-zoom-01-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt: Removed.
  • platform/chromium-linux/svg/W3C-SVG-1.1/render-groups-01-b-expected.txt: Removed.
  • platform/chromium-linux/svg/W3C-SVG-1.1/render-groups-03-t-expected.txt: Removed.
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-text-01-b-expected.txt:
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-text-04-t-expected.txt: Removed.
  • platform/chromium-linux/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt: Removed.
  • platform/chromium-linux/svg/custom/svg-fonts-in-html-expected.txt: Removed.
  • platform/chromium-linux/svg/custom/svg-fonts-with-no-element-reference-expected.txt: Removed.
  • platform/chromium-linux/svg/hixie/perf/003-expected.txt: Added.
  • platform/chromium-linux/svg/hixie/perf/004-expected.txt: Added.
  • platform/chromium-linux/svg/hixie/perf/005-expected.txt: Added.
  • platform/chromium-linux/svg/hixie/perf/006-expected.txt: Added.
  • platform/chromium-linux/svg/hixie/viewbox/preserveAspectRatio/001-expected.txt: Added.
  • platform/chromium-linux/svg/hixie/viewbox/preserveAspectRatio/002-expected.txt: Added.
  • platform/chromium-linux/svg/text/text-hkern-expected.txt: Removed.
  • platform/chromium-linux/svg/text/text-hkern-on-vertical-text-expected.checksum: Removed.
  • platform/chromium-linux/svg/text/text-hkern-on-vertical-text-expected.png: Removed.
  • platform/chromium-linux/svg/text/text-hkern-on-vertical-text-expected.txt: Removed.
  • platform/chromium-linux/svg/text/text-text-01-b-expected.checksum:
  • platform/chromium-linux/svg/text/text-text-01-b-expected.png:
  • platform/chromium-linux/svg/text/text-text-01-b-expected.txt:
  • platform/chromium-linux/svg/text/text-text-04-t-expected.txt: Removed.
  • platform/chromium-linux/svg/text/text-vkern-expected.checksum: Removed.
  • platform/chromium-linux/svg/text/text-vkern-expected.txt: Removed.
  • platform/chromium-linux/svg/text/text-vkern-on-horizontal-text-expected.txt: Removed.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt: Removed.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt: Removed.
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-03-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-36-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-40-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/fonts-desc-02-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/render-groups-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/render-groups-03-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/text-text-04-t-expected.txt:
  • platform/chromium-win/svg/batik/text/xmlSpace-expected.txt:
  • platform/chromium-win/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt:
  • platform/chromium-win/svg/custom/svg-fonts-in-html-expected.checksum:
  • platform/chromium-win/svg/custom/svg-fonts-in-html-expected.png:
  • platform/chromium-win/svg/custom/svg-fonts-in-html-expected.txt:
  • platform/chromium-win/svg/custom/svg-fonts-with-no-element-reference-expected.checksum:
  • platform/chromium-win/svg/custom/svg-fonts-with-no-element-reference-expected.png:
  • platform/chromium-win/svg/custom/svg-fonts-with-no-element-reference-expected.txt: Removed.
  • platform/chromium-win/svg/text/text-hkern-expected.txt: Removed.
  • platform/chromium-win/svg/text/text-hkern-on-vertical-text-expected.checksum:
  • platform/chromium-win/svg/text/text-hkern-on-vertical-text-expected.png:
  • platform/chromium-win/svg/text/text-hkern-on-vertical-text-expected.txt: Removed.
  • platform/chromium-win/svg/text/text-text-04-t-expected.checksum:
  • platform/chromium-win/svg/text/text-text-04-t-expected.png:
  • platform/chromium-win/svg/text/text-text-04-t-expected.txt:
  • platform/chromium-win/svg/text/text-vkern-expected.checksum:
  • platform/chromium-win/svg/text/text-vkern-expected.png:
  • platform/chromium-win/svg/text/text-vkern-expected.txt: Removed.
  • platform/chromium-win/svg/text/text-vkern-on-horizontal-text-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:

2011-01-24 Tony Chang <tony@chromium.org>

Unreviewed, round ascent and descent to match old code.

  • platform/graphics/chromium/SimpleFontDataLinux.cpp: (WebCore::SimpleFontData::platformInit):
9:15 PM Changeset in webkit [76568] by simon.fraser@apple.com
  • 8 edits
    2 adds in trunk

2011-01-24 Simon Fraser <simon.fraser@apple.com>

Reviewed by Chris Marrin.

perspective() transform function should take lengths
https://bugs.webkit.org/show_bug.cgi?id=52683

The argument to the perspective() transform function should
be a Length, rather than a bare number. Bare numbers are still
accepted (and treated as px), but this behavior is deprecated.

Test: animations/3d/transform-perspective.html

transforms/3d/general/3dtransform-values.html

  • css/CSSParser.cpp: (WebCore::CSSParser::parseTransform): Check the units for the perspective() function. Allow bare numbers for backwards compatibility.
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::createTransformOperations): Convert value to Length.
  • platform/graphics/transforms/PerspectiveTransformOperation.cpp: (WebCore::clampToPostiveInteger): Helper. (WebCore::PerspectiveTransformOperation::blend): Blend via Lengths.
  • platform/graphics/transforms/PerspectiveTransformOperation.h: (WebCore::PerspectiveTransformOperation::create): double -> Length. (WebCore::PerspectiveTransformOperation::perspective): Ditto. (WebCore::PerspectiveTransformOperation::isIdentity): Ditto. (WebCore::PerspectiveTransformOperation::apply): Ditto. (WebCore::PerspectiveTransformOperation::PerspectiveTransformOperation): Assert that the Length is a fixed type.
8:38 PM Changeset in webkit [76567] by tkent@chromium.org
  • 4 edits
    2 adds in trunk

2011-01-24 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[Windows] Textfield <input>s have different widths.
https://bugs.webkit.org/show_bug.cgi?id=48405

  • fast/forms/input-widths-expected.txt: Added.
  • fast/forms/input-widths.html: Added.

2011-01-24 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[Windows] Textfield <input>s have different widths.
https://bugs.webkit.org/show_bug.cgi?id=48405

  • Apply the padding override for type=text to other textfield types too.
  • Reset margin value of outer spin button, which is not used in Windows.
  • Don't add inner spin button width to the preferred text field width. Text fields should have the identical widths regardless of the existence of spin buttons.

Test: fast/forms/input-widths.html

  • css/themeWin.css: (input[type="week"]): (input[type="week"]:disabled): (input[type="search"]::-webkit-search-cancel-button): (input::-webkit-outer-spin-button):
  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::preferredContentWidth): Don't add inner spin button width to the preferred width.
8:36 PM Changeset in webkit [76566] by tkent@chromium.org
  • 4 edits
    4 adds in trunk

2011-01-24 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

Some bugs of search cancel button and spin button about state change in
an event handler.
https://bugs.webkit.org/show_bug.cgi?id=46950

  • fast/forms/input-number-change-type-on-focus-expected.txt: Added.
  • fast/forms/input-number-change-type-on-focus.html: Added.
  • fast/forms/search-hide-cancel-on-cancel-expected.txt: Added.
  • fast/forms/search-hide-cancel-on-cancel.html: Added.

2011-01-24 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

Some bugs of search cancel button and spin button about state change in
an event handler.
https://bugs.webkit.org/show_bug.cgi?id=46950

Fix the following problems:

  • Type=search field didn't release event capturing
  • Assertion failure when an input field with spin buttons was changed to another type on focus event.
  • A input field with spin button didn't release event capturing when it was changed to another type on focus event.

Tests: fast/forms/input-number-change-type-on-focus.html

fast/forms/search-hide-cancel-on-cancel.html

  • rendering/TextControlInnerElements.cpp: (WebCore::SearchFieldCancelButtonElement::defaultEventHandler):
    • Make the variable 'input' RefPtr. It makes the code simpler.
    • Remove visibility check on mouseup event. We should release capturing anyway because the cancel button may be invisible if JavaScript code called by the focus event removes the input value.

(WebCore::SpinButtonElement::detach):

  • Release capturing on detach because it is possible that a spin button node is detached while it is capturing events.

(WebCore::SpinButtonElement::defaultEventHandler):

Take a reference to this and check renderer() after some functions which
may run JavaScript code.

(WebCore::InputFieldSpeechButtonElement::defaultEventHandler):

Make the variable 'input' RefPtr to align other functions in this file.

(WebCore::InputFieldSpeechButtonElement::setRecognitionResult): ditto.

  • rendering/TextControlInnerElements.h: Declare SpinButtonElement::detach().
7:27 PM Changeset in webkit [76565] by rniwa@webkit.org
  • 7 edits in trunk

2011-01-24 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Ojan Vafai.

Inserting multiple whitespace using text composition (IME) should insert interleaved nbsp and whitespace.
https://bugs.webkit.org/show_bug.cgi?id=52781

The test was rebaselined to have interleaved space and non-breaking space.

  • editing/inserting/insert-composition-whitespace-expected.txt:
  • editing/inserting/insert-composition-whitespace.html:

2011-01-24 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Ojan Vafai.

Inserting multiple whitespace using text composition (IME) should insert interleaved nbsp and whitespace.
https://bugs.webkit.org/show_bug.cgi?id=52781

The bug was caused by stringWithRebalancedWhitespace's replacing the space at the beginning of a paragraph
and the end of a paragraph by a non-breaking space after it replaced two consecutive spaces by a space and
non-breaking space pattern, thereby replacing more spaces by non-breaking spaces than needed.

Rewrote the function using Vector<UChar> to fix the bug. New function no longer calls String::replace
multiple times but instead it traverses through the string and replaces a space that immediately follows
another space or appears at the beginning of a paragraph or at the end of a paragraph by a non-break space.

  • editing/CompositeEditCommand.cpp:
  • editing/htmlediting.cpp: (WebCore::stringWithRebalancedWhitespace): Written.
  • editing/htmlediting.h: (WebCore::isWhitespace): Removed from CompositeEditCommand.cpp
6:56 PM Changeset in webkit [76564] by mrobinson@webkit.org
  • 2 edits in trunk/LayoutTests

2011-01-24 Martin Robinson <mrobinson@igalia.com>

Skip one more crashing test.

  • platform/gtk/Skipped: Skip a test.
6:48 PM Changeset in webkit [76563] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix build.

  • WebProcess/mac/WebProcessMac.mm:

(WebKit::initializeSandbox):

6:39 PM Changeset in webkit [76562] by kbr@google.com
  • 4 edits
    2 adds in trunk/Source/WebCore

2011-01-24 Kenneth Russell <kbr@google.com>

Reviewed by James Robinson.

Web Audio API: port FFTFrame to FFTW
https://bugs.webkit.org/show_bug.cgi?id=52989

Ported FFTFrame class to the open-source FFTW library. Tested with
unit tests from Chris Rogers. Made preliminary changes to GYP
files for conditional compilation of these files; will need to be
adjusted once FFTW is integrated as third-party source.

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • platform/audio/FFTFrame.h:
  • platform/audio/fftw: Added.
  • platform/audio/fftw/FFTFrameFFTW.cpp: Added. (WebCore::FFTFrame::FFTFrame): (WebCore::FFTFrame::~FFTFrame): (WebCore::FFTFrame::multiply): (WebCore::FFTFrame::doFFT): (WebCore::FFTFrame::doInverseFFT): (WebCore::FFTFrame::cleanup): (WebCore::FFTFrame::realData): (WebCore::FFTFrame::imagData): (WebCore::FFTFrame::fftwPlanForSize):
6:38 PM Changeset in webkit [76561] by andersca@apple.com
  • 9 edits in trunk/Source

2011-01-24 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Reset the page scale factor on standard frame loads
https://bugs.webkit.org/show_bug.cgi?id=53058
<rdar://problem/8908844>

Add a symbol needed by WebKit2.

  • WebCore.exp.in:

2011-01-24 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Reset the page scale factor on standard frame loads
https://bugs.webkit.org/show_bug.cgi?id=53058
<rdar://problem/8908844>

  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::scaleWebView): Don't set m_viewScaleFactor here. It will be set in viewScaleFactorDidChange.

(WebKit::WebPageProxy::viewScaleFactorDidChange):
Update m_viewScaleFactor.

  • UIProcess/WebPageProxy.h: Add viewScaleFactorDidChange.
  • UIProcess/WebPageProxy.messages.in: Add ViewScaleFactorDidChange message.
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::dispatchDidCommitLoad): Set the scale factor.

(WebKit::WebFrameLoaderClient::restoreViewState):
Inform the UI process about the new view scale factor.

  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::scaleWebView): Send a ViewScaleFactorDidChange message.
6:21 PM Changeset in webkit [76560] by rniwa@webkit.org
  • 8 edits in trunk/Source/WebCore

2011-01-24 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Eric Seidel.

Stop instantiating legacy editing positions in InsertTextCommand, MoveSelectionCommand,
ReplaceSelectionCommand, SelectionController, SpellChecker, TypingCommand, and markup.cpp
https://bugs.webkit.org/show_bug.cgi?id=52676

Stop instantiating legacy editing positions in the following files.

  • editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::prepareForTextInsertion): (WebCore::InsertTextCommand::performTrivialReplace): (WebCore::InsertTextCommand::input): (WebCore::InsertTextCommand::insertTab):
  • editing/MoveSelectionCommand.cpp: (WebCore::MoveSelectionCommand::doApply):
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::removeUnrenderedTextNodesAtEnds): (WebCore::ReplaceSelectionCommand::mergeEndIfNeeded): (WebCore::ReplaceSelectionCommand::doApply): (WebCore::ReplaceSelectionCommand::shouldRemoveEndBR): (WebCore::ReplaceSelectionCommand::performTrivialReplace):
  • editing/SelectionController.cpp: (WebCore::SelectionController::setSelectionFromNone):
  • editing/SpellChecker.cpp: (WebCore::SpellChecker::didCheck):
  • editing/TypingCommand.cpp: (WebCore::TypingCommand::makeEditableRootEmpty): (WebCore::TypingCommand::deleteKeyPressed): (WebCore::TypingCommand::forwardDeleteKeyPressed):
  • editing/markup.cpp: (WebCore::StyledMarkupAccumulator::appendText): (WebCore::StyledMarkupAccumulator::serializeNodes): (WebCore::highestAncestorToWrapMarkup): (WebCore::createMarkup):
6:08 PM Changeset in webkit [76559] by mjs@apple.com
  • 25 edits
    4 deletes in trunk

2011-01-24 Maciej Stachowiak <mjs@apple.com>

Reviewed by Anders Carlsson.

Use designated temp directory for the database for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=53052


Adopt the new WK2 API for this.

  • WebKitTestRunner/TestController.cpp: (WTR::TestController::libraryPathForTesting): (WTR::TestController::initialize):
  • WebKitTestRunner/TestController.h:
  • WebKitTestRunner/mac/TestControllerMac.mm: (WTR::TestController::platformLibraryPathForTesting):
  • WebKitTestRunner/qt/TestControllerQt.cpp: (WTR::TestController::platformLibraryPathForTesting):
  • WebKitTestRunner/win/TestControllerWin.cpp: (WTR::TestController::platformLibraryPathForTesting):

2011-01-24 Maciej Stachowiak <mjs@apple.com>

Reviewed by Anders Carlsson.

Use designated temp directory for the database for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=53052


Add the API necessary to support this. Database path is now
determined on the UI process side and passed to the Web process.
Reviewed by Anders Carlsson.

  • GNUmakefile.am:
  • Shared/WebProcessCreationParameters.cpp: (WebKit::WebProcessCreationParameters::encode): (WebKit::WebProcessCreationParameters::decode):
  • Shared/WebProcessCreationParameters.h:
  • UIProcess/API/C/WKContext.cpp: (WKContextSetDatabaseDirectory):
  • UIProcess/API/C/WKContextPrivate.h:
  • UIProcess/WebContext.cpp: (WebKit::WebContext::ensureWebProcess): (WebKit::WebContext::databaseDirectory):
  • UIProcess/WebContext.h: (WebKit::WebContext::setDatabaseDirectory):
  • UIProcess/mac/WebContextMac.mm: (WebKit::WebContext::platformDefaultDatabaseDirectory):
  • UIProcess/qt/WebContextQt.cpp: (WebKit::WebContext::platformDefaultDatabaseDirectory):
  • UIProcess/win/WebContextWin.cpp: (WebKit::WebContext::platformDefaultDatabaseDirectory):
  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebCoreSupport/WebDatabaseManager.cpp: (WebKit::WebDatabaseManager::initialize): (WebKit::WebDatabaseManager::WebDatabaseManager):
  • WebProcess/WebCoreSupport/WebDatabaseManager.h:
  • WebProcess/WebCoreSupport/gtk/WebDatabaseManagerGtk.cpp: Removed.
  • WebProcess/WebCoreSupport/mac/WebDatabaseManagerMac.mm: Removed.
  • WebProcess/WebCoreSupport/qt/WebDatabaseManagerQt.cpp: Removed.
  • WebProcess/WebCoreSupport/win/WebDatabaseManagerWin.cpp: Removed.
  • WebProcess/WebProcess.cpp: (WebKit::WebProcess::WebProcess): (WebKit::WebProcess::initializeWebProcess):
  • WebProcess/com.apple.WebProcess.sb:
  • WebProcess/mac/WebProcessMac.mm: (WebKit::initializeSandbox):
  • win/WebKit2.vcproj:
6:05 PM Changeset in webkit [76558] by mrobinson@webkit.org
  • 2 edits in trunk/LayoutTests

2011-01-24 Martin Robinson <mrobinson@igalia.com>

Skipping failing tests after r76555.

  • platform/gtk/Skipped: Skip failing tests.
5:36 PM Changeset in webkit [76557] by commit-queue@webkit.org
  • 7 edits in trunk

2011-01-24 Peter Kasting <pkasting@google.com>

Reviewed by Darin Adler.

Roll back r67261 ("Don't fire onclick on middle clicks") due to
regressions.
https://bugs.webkit.org/show_bug.cgi?id=46733

  • fast/events/mouse-click-events-expected.txt:
  • fast/events/script-tests/mouse-click-events.js:

2011-01-24 Peter Kasting <pkasting@google.com>

Reviewed by Darin Adler.

Roll back r67261 ("Don't fire onclick on middle clicks") due to
regressions.
https://bugs.webkit.org/show_bug.cgi?id=46733

  • html/HTMLAnchorElement.cpp: (WebCore::isLinkClick):
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::preDispatchEventHandler): (WebCore::HTMLInputElement::postDispatchEventHandler): (WebCore::HTMLInputElement::defaultEventHandler):
  • page/EventHandler.cpp: (WebCore::EventHandler::handleMouseDoubleClickEvent): (WebCore::EventHandler::handleMouseReleaseEvent):
4:58 PM Changeset in webkit [76556] by xji@chromium.org
  • 2 edits in trunk/LayoutTests

2011-01-24 Xiaomei Ji <xji@chromium.org>

Unreviewed.

Skip cjk-segmentation.html (introduced in r76548) in QT.
QT skipped range-expand.html, skip cjk-segmentation as well.

  • platform/qt/Skipped:
4:47 PM Changeset in webkit [76555] by mrobinson@webkit.org
  • 4 edits in trunk

2011-01-24 Martin Robinson <mrobinson@igalia.com>

Reviewed by Eric Seidel.

[GTK] Many DOM XHTML tests time out
https://bugs.webkit.org/show_bug.cgi?id=52553

  • platform/gtk/Skipped: Unskip tests which are no longer timing out.

2011-01-24 Martin Robinson <mrobinson@igalia.com>

Reviewed by Eric Seidel.

[GTK] Many DOM XHTML tests time out
https://bugs.webkit.org/show_bug.cgi?id=52553

Properly handle the situation where a synchronous load fails before the inner
event loop has started. In this case, we simply do not run the inner event loop,
or else it will block indefinitely (since no GIO or libsoup callbacks will fire).

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandle::loadResourceSynchronously): Bail out of a synchronous load if it fails up front.
4:46 PM Changeset in webkit [76554] by Lucas Forschler
  • 2 edits in trunk/Tools

Add a new Leopard test bot.

Reviewed by Stephanie Lewis.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
4:35 PM Changeset in webkit [76553] by gyuyoung.kim@samsung.com
  • 3 edits in trunk/Tools

2011-01-24 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Adam Barth.

Add EFL Builder to core waterfall
https://bugs.webkit.org/show_bug.cgi?id=52704

Add EFL Builder to the core waterfall again.

  • Scripts/webkitpy/common/net/buildbot/buildbot.py:
  • Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
4:09 PM Changeset in webkit [76552] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-01-24 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed Chromium test expectation update for r76548.

  • platform/chromium/test_expectations.txt:
3:40 PM Changeset in webkit [76551] by bfulgham@webkit.org
  • 2 edits in trunk/Source/WebKit2

Unreviewed build fix.

  • win/WebKit2.vcproj: Don't build the CG Utilities when building

without CG support.

3:16 PM Changeset in webkit [76550] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-01-24 Anders Carlsson <andersca@apple.com>

Reviewed by John Sullivan.

Don't use the timeout checker for non-user-interaction messages
https://bugs.webkit.org/show_bug.cgi?id=53046

  • UIProcess/ChunkedUpdateDrawingAreaProxy.cpp: (WebKit::ChunkedUpdateDrawingAreaProxy::didSetSize): (WebKit::ChunkedUpdateDrawingAreaProxy::sendSetSize):
  • UIProcess/LayerBackedDrawingAreaProxy.cpp: (WebKit::LayerBackedDrawingAreaProxy::sizeDidChange): (WebKit::LayerBackedDrawingAreaProxy::didSetSize):
2:42 PM Changeset in webkit [76549] by zmo@google.com
  • 8 edits in trunk/Source

2011-01-24 Zhenyao Mo <zmo@google.com>

Reviewed by Darin Adler.

Remove sizeInBytes from GraphicsContext3D's various implementations
https://bugs.webkit.org/show_bug.cgi?id=52339

  • src/GraphicsContext3DChromium.cpp:
  • src/GraphicsContext3DInternal.h:

2011-01-24 Zhenyao Mo <zmo@google.com>

Reviewed by Darin Adler.

Remove sizeInBytes from GraphicsContext3D's various implementations
https://bugs.webkit.org/show_bug.cgi?id=52339

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::sizeInBytes):
  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
  • platform/graphics/qt/GraphicsContext3DQt.cpp:
2:25 PM Changeset in webkit [76548] by xji@chromium.org
  • 1 edit
    4 adds in trunk/LayoutTests

2011-01-24 Xiaomei Ji <xji@chromium.org>

Reviewed by Ryosuke Niwa.

Add test for Chinese Segmentation.
https://bugs.webkit.org/show_bug.cgi?id=52926

The CJK segmentation currently does not work in other ports except Chromium.
Please refer to https://bugs.webkit.org/show_bug.cgi?id=53044 for detail.

  • fast/text/international/cjk-segmentation-expected.txt: Added.
  • fast/text/international/cjk-segmentation.html: Added.
  • platform/chromium/fast/text/international: Added.
  • platform/chromium/fast/text/international/cjk-segmentation-expected.txt: Added.
2:22 PM Changeset in webkit [76547] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

2011-01-24 Xianzhu Wang <wangxianzhu@google.com>

Reviewed by Tony Chang.

new-run-webkit-tests fails to start HTTP server if there are proxy settings
https://bugs.webkit.org/show_bug.cgi?id=52872

Force disabling proxy to resolve the problem.

  • Scripts/webkitpy/layout_tests/port/http_server_base.py:
  • Scripts/webkitpy/layout_tests/port/websocket_server.py:
2:17 PM Changeset in webkit [76546] by Adam Roben
  • 8 edits in trunk/Source

Windows Production build fix

Source/JavaScriptCore:

Source/WebCore:

  • WebCore.vcproj/WebCore.make: Update for move of WebCore into Source.

Source/WebKit/win:

  • WebKit.vcproj/WebKit.make: Update for move of WebKit into Source.

Source/WebKit2:

  • win/WebKit2.make: Update for move of WebKit2 into Source.
2:01 PM Changeset in webkit [76545] by wsiegrist@apple.com
  • 4 edits in trunk/Websites/bugs.webkit.org

2011-01-24 William Siegrist <wsiegrist@apple.com>

Apply fix for https://bugzilla.mozilla.org/show_bug.cgi?id=621591

1:33 PM Changeset in webkit [76544] by mjs@apple.com
  • 2 edits in trunk/LayoutTests

2011-01-24 Maciej Stachowiak <mjs@apple.com>

Reviewed by Eric Seidel.

Skip a newly added test that uses textInputController
https://bugs.webkit.org/show_bug.cgi?id=53027

  • platform/mac-wk2/Skipped:
1:02 PM Changeset in webkit [76543] by jberlin@webkit.org
  • 2 edits in trunk/Source/WebKit2

WebKit2: LayoutTests: The UNIMPLEMENTED warnings in TextCheckerWin should be disabled
https://bugs.webkit.org/show_bug.cgi?id=53029

Reviewed by Adam Roben.

  • UIProcess/win/TextCheckerWin.cpp:

Disable the warnings for this file.

12:31 PM Changeset in webkit [76542] by andreip@google.com
  • 2 edits in trunk/LayoutTests

2011-01-24 Andrei Popescu <andreip@google.com>

Unreviewed, build fix.

LayoutTest/storage/indexeddb/objectstore-autoincrement.html is failing after r76533
https://bugs.webkit.org/show_bug.cgi?id=53032

Fix the expected output, which still had an error.

  • storage/indexeddb/objectstore-autoincrement-expected.txt:
12:22 PM Changeset in webkit [76541] by antonm@chromium.org
  • 5 edits
    1 add in trunk/Source/WebCore

2011-01-24 Anton Muhin <antonm@chromium.org>

Reviewed by Nate Chapin.

[v8] Refactoring: extract IntrusiveDOMWrapperMap into a seprate class and files.
https://bugs.webkit.org/show_bug.cgi?id=52911

Plain refactoring, covered by the existing tests.

  • WebCore.gypi: IntrusiveDOMWrapperMap.h added.
  • bindings/v8/DOMDataStore.cpp: IntrusiveDOMWrapperMap is moved out of DOMDataStore class.
  • bindings/v8/DOMDataStore.h: IntrusiveDOMWrapperMap is moved out of DOMDataStore class.
  • bindings/v8/IntrusiveDOMWrapperMap.h: Added. (WebCore::ChunkedTable::ChunkedTable): (WebCore::ChunkedTable::add): (WebCore::ChunkedTable::remove): (WebCore::ChunkedTable::clear): (WebCore::ChunkedTable::visit): (WebCore::ChunkedTable::Chunk::Chunk): (WebCore::ChunkedTable::clearEntries): (WebCore::ChunkedTable::visitEntries): (WebCore::IntrusiveDOMWrapperMap::IntrusiveDOMWrapperMap): (WebCore::IntrusiveDOMWrapperMap::get): (WebCore::IntrusiveDOMWrapperMap::set): (WebCore::IntrusiveDOMWrapperMap::contains): (WebCore::IntrusiveDOMWrapperMap::visit): (WebCore::IntrusiveDOMWrapperMap::removeIfPresent): (WebCore::IntrusiveDOMWrapperMap::clear): (WebCore::IntrusiveDOMWrapperMap::ChunkedTableTraits::move): (WebCore::IntrusiveDOMWrapperMap::ChunkedTableTraits::clear): (WebCore::IntrusiveDOMWrapperMap::ChunkedTableTraits::visit):
  • bindings/v8/StaticDOMDataStore.h: include added.
12:11 PM Changeset in webkit [76540] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

2011-01-24 Kenji Imasaki <imasaki@chromium.org>

Reviewed by Jian Li.

[chromium] Remove non-flaky tests from test expectation file
https://bugs.webkit.org/show_bug.cgi?id=53022

  • platform/chromium/test_expectations.txt:
12:07 PM Changeset in webkit [76539] by jam@chromium.org
  • 3 edits in branches/chromium/648/Source/WebKit/chromium

Merge 76455 - 2011-01-22 John Abd-El-Malek <jam@chromium.org>

Reviewed by Adam Barth.

[chromium]: Fix WebScrollbarImpl not getting scroll events after recent scrollbar refactoring
https://bugs.webkit.org/show_bug.cgi?id=52967

  • src/WebScrollbarImpl.cpp: (WebKit::WebScrollbarImpl::horizontalScrollbar): (WebKit::WebScrollbarImpl::verticalScrollbar):
  • src/WebScrollbarImpl.h:

TBR=jam@chromium.org
Review URL: http://codereview.chromium.org/6392001

11:43 AM Changeset in webkit [76538] by andreip@google.com
  • 3 edits in trunk/LayoutTests

2011-01-24 Andrei Popescu <andreip@google.com>

Reviewed by Jeremy Orlow.

LayoutTest/storage/indexeddb/objectstore-autoincrement.html is failing after r76533
https://bugs.webkit.org/show_bug.cgi?id=53032

This fixes the layout test by modifying the arguments to IDBDatabase::transaction.

  • storage/indexeddb/objectstore-autoincrement-expected.txt:
  • storage/indexeddb/objectstore-autoincrement.html:
11:42 AM Changeset in webkit [76537] by commit-queue@webkit.org
  • 14 edits in trunk/Source/WebCore

2011-01-24 Shane Stephens <shanestephens@google.com>

Reviewed by Chris Marrin.

TransformationMatrix multiply operations apply operands in wrong order.
https://bugs.webkit.org/show_bug.cgi?id=52780

Rename TranformationMatrix::multLeft into multiply (the method does a multRight,
not a multLeft).

Remove TransformationMatrix::multiply, which was actually doing a multLeft.

Fix TransformationMatrix::operator* and operator*= such that the operand is
applied to the right-hand side of the matrix that the method is called on.
i.e., previously "a * b" used to compute "b * a", and "a *= b" used to store
"b * a" in "a". This has now been fixed so "a * b" computes "a * b" and
"a *= b" stores "a * b" in "a".

Convert all call sites for these methods to provide operands in the correct order.

No new tests as patch adds no new functionality.

  • css/WebKitCSSMatrix.cpp: (WebCore::WebKitCSSMatrix::multiply):
  • platform/graphics/transforms/Matrix3DTransformOperation.h: (WebCore::Matrix3DTransformOperation::apply):
  • platform/graphics/transforms/MatrixTransformOperation.h: (WebCore::MatrixTransformOperation::apply):
  • platform/graphics/transforms/TransformationMatrix.cpp: (WebCore::TransformationMatrix::scaleNonUniform): (WebCore::TransformationMatrix::scale3d): (WebCore::TransformationMatrix::rotate3d): (WebCore::TransformationMatrix::skew): (WebCore::TransformationMatrix::applyPerspective): (WebCore::TransformationMatrix::multiply): (WebCore::TransformationMatrix::recompose):
  • platform/graphics/transforms/TransformationMatrix.h: (WebCore::TransformationMatrix::operator*=): (WebCore::TransformationMatrix::operator*):
  • rendering/RenderLayer.cpp: (WebCore::transparencyClipBox):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::getTransformFromContainer):
  • rendering/TransformState.cpp: (WebCore::TransformState::applyTransform): (WebCore::HitTestingTransformState::applyTransform):
11:33 AM Changeset in webkit [76536] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-01-24 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Wait for half a second if we're asked to paint when receiving a DidSetSize message
https://bugs.webkit.org/show_bug.cgi?id=53028

  • UIProcess/DrawingAreaProxyImpl.cpp: (WebKit::DrawingAreaProxyImpl::paint):
11:18 AM Changeset in webkit [76535] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-01-24 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Implement forceRedisplay in the new drawing area
https://bugs.webkit.org/show_bug.cgi?id=53026

  • WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::forceRepaint):
  • WebProcess/WebPage/DrawingAreaImpl.h:
11:16 AM Changeset in webkit [76534] by Dimitri Glazkov
  • 1 add in branches/chromium/648/codereview.settings

Added codereview.settings file.

11:11 AM Changeset in webkit [76533] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-01-24 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Fill unpainted rects with the background color.
https://bugs.webkit.org/show_bug.cgi?id=53025

  • UIProcess/API/mac/WKView.mm: (drawPageBackground): Add new helper function.

(-[WKView drawRect:]):
Iterate over the unpainted rects and fill them with the background color.

11:10 AM Changeset in webkit [76532] by Dimitri Glazkov
  • 1 copy in branches/chromium/648

Branching Chromium 648.

11:01 AM Changeset in webkit [76531] by andreip@google.com
  • 33 edits in trunk

2011-01-24 Andrei Popescu <andreip@google.com>

Reviewed by Nate Chapin.

IndexedDatabase methods should not take arguments of type OptionsObject
https://bugs.webkit.org/show_bug.cgi?id=53012

  • storage/indexeddb/create-object-store-options-expected.txt:
  • storage/indexeddb/create-object-store-options.html:
  • storage/indexeddb/cursor-delete-expected.txt:
  • storage/indexeddb/cursor-delete.html:
  • storage/indexeddb/cursor-index-delete-expected.txt:
  • storage/indexeddb/cursor-index-delete.html:
  • storage/indexeddb/data-corruption-expected.txt:
  • storage/indexeddb/data-corruption.html:
  • storage/indexeddb/database-quota-expected.txt:
  • storage/indexeddb/database-quota.html:
  • storage/indexeddb/index-cursor.html:
  • storage/indexeddb/objectstore-basics-expected.txt:
  • storage/indexeddb/objectstore-basics.html:
  • storage/indexeddb/objectstore-cursor.html:
  • storage/indexeddb/open-cursor-expected.txt:
  • storage/indexeddb/open-cursor.html:
  • storage/indexeddb/transaction-and-objectstore-calls-expected.txt:
  • storage/indexeddb/transaction-and-objectstore-calls.html:
  • storage/indexeddb/tutorial.html:

2011-01-24 Andrei Popescu <andreip@google.com>

Reviewed by Nate Chapin.

IndexedDatabase methods should not take arguments of type OptionsObject
https://bugs.webkit.org/show_bug.cgi?id=53012

This patch reverts all IDB methods, except IDBDatabase::createObjectStore and
IDBObjectStore::createIndex, to using a plain list of arguments instead of
grouping the various parameters inside a single OptionsObject argument.
This decision was made on public-webapps@w3.org mailing list.

We also add support (v8 only for now) for passing DOMStringList objects as arguments to native
methods. The code for obtaining a DOMStringList object from a JS array of strings existed already
in OptionsObject.cpp, I just copied it to V8Bindings.cpp and taught the v8 code generator how to
use it.

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/V8Binding.cpp: (WebCore::v8ValueToWebCoreDOMStringList):
  • bindings/v8/V8Binding.h:
  • storage/IDBDatabase.cpp: (WebCore::IDBDatabase::transaction):
  • storage/IDBDatabase.h: (WebCore::IDBDatabase::transaction):
  • storage/IDBDatabase.idl:
  • storage/IDBIndex.cpp: (WebCore::IDBIndex::openCursor): (WebCore::IDBIndex::openKeyCursor):
  • storage/IDBIndex.h: (WebCore::IDBIndex::openCursor): (WebCore::IDBIndex::openKeyCursor):
  • storage/IDBIndex.idl:
  • storage/IDBObjectStore.cpp: (WebCore::IDBObjectStore::openCursor):
  • storage/IDBObjectStore.h: (WebCore::IDBObjectStore::openCursor):
  • storage/IDBObjectStore.idl:
10:33 AM Changeset in webkit [76530] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

2011-01-24 Andreas Kling <kling@webkit.org>

Reviewed by Darin Adler.

check-webkit-style: Update exemptions following Source/ move.
https://bugs.webkit.org/show_bug.cgi?id=53017

  • Scripts/webkitpy/style/checker.py:
  • Scripts/webkitpy/style/checker_unittest.py:
9:54 AM Changeset in webkit [76529] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

WebKit2 version of <rdar://problem/6097826> Mail's cursor does not become a resize cursor when moving mouse from scrolled email to the horizontal splitter

Reviewed by John Sullivan.

  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::setCursor): If the current cursor comes from a cursor rect, do not override it.

9:40 AM Changeset in webkit [76528] by chang.shu@nokia.com
  • 1 edit
    30 moves in trunk/LayoutTests

2011-01-24 Chang Shu <chang.shu@nokia.com>

Reviewed by Darin Adler.

Move contentEditable related test cases to the right place as they are DOM
related instead of editing related.
https://bugs.webkit.org/show_bug.cgi?id=53010

  • editing/editability: Removed.
  • editing/editability/attr-empty-string-expected.txt: Removed.
  • editing/editability/attr-empty-string.html: Removed.
  • editing/editability/attr-false-string-expected.txt: Removed.
  • editing/editability/attr-false-string.html: Removed.
  • editing/editability/attr-invalid-string-expected.txt: Removed.
  • editing/editability/attr-invalid-string.html: Removed.
  • editing/editability/attr-missing-ancestor-false-expected.txt: Removed.
  • editing/editability/attr-missing-ancestor-false.html: Removed.
  • editing/editability/attr-missing-ancestor-true-expected.txt: Removed.
  • editing/editability/attr-missing-ancestor-true.html: Removed.
  • editing/editability/attr-missing-parent-ancestor-missing-expected.txt: Removed.
  • editing/editability/attr-missing-parent-ancestor-missing.html: Removed.
  • editing/editability/attr-missing-parent-false-expected.txt: Removed.
  • editing/editability/attr-missing-parent-false.html: Removed.
  • editing/editability/attr-missing-parent-true-expected.txt: Removed.
  • editing/editability/attr-missing-parent-true.html: Removed.
  • editing/editability/attr-true-string-expected.txt: Removed.
  • editing/editability/attr-true-string.html: Removed.
  • editing/editability/set-false-expected.txt: Removed.
  • editing/editability/set-false.html: Removed.
  • editing/editability/set-inherit-parent-false-expected.txt: Removed.
  • editing/editability/set-inherit-parent-false.html: Removed.
  • editing/editability/set-inherit-parent-true-expected.txt: Removed.
  • editing/editability/set-inherit-parent-true.html: Removed.
  • editing/editability/set-invalid-value-expected.txt: Removed.
  • editing/editability/set-invalid-value.html: Removed.
  • editing/editability/set-true-expected.txt: Removed.
  • editing/editability/set-true.html: Removed.
  • editing/editability/set-value-caseinsensitive-expected.txt: Removed.
  • editing/editability/set-value-caseinsensitive.html: Removed.
  • fast/dom/HTMLElement/attr-empty-string-expected.txt: Copied from LayoutTests/editing/editability/attr-empty-string-expected.txt.
  • fast/dom/HTMLElement/attr-empty-string.html: Copied from LayoutTests/editing/editability/attr-empty-string.html.
  • fast/dom/HTMLElement/attr-false-string-expected.txt: Copied from LayoutTests/editing/editability/attr-false-string-expected.txt.
  • fast/dom/HTMLElement/attr-false-string.html: Copied from LayoutTests/editing/editability/attr-false-string.html.
  • fast/dom/HTMLElement/attr-invalid-string-expected.txt: Copied from LayoutTests/editing/editability/attr-invalid-string-expected.txt.
  • fast/dom/HTMLElement/attr-invalid-string.html: Copied from LayoutTests/editing/editability/attr-invalid-string.html.
  • fast/dom/HTMLElement/attr-missing-ancestor-false-expected.txt: Copied from LayoutTests/editing/editability/attr-missing-ancestor-false-expected.txt.
  • fast/dom/HTMLElement/attr-missing-ancestor-false.html: Copied from LayoutTests/editing/editability/attr-missing-ancestor-false.html.
  • fast/dom/HTMLElement/attr-missing-ancestor-true-expected.txt: Copied from LayoutTests/editing/editability/attr-missing-ancestor-true-expected.txt.
  • fast/dom/HTMLElement/attr-missing-ancestor-true.html: Copied from LayoutTests/editing/editability/attr-missing-ancestor-true.html.
  • fast/dom/HTMLElement/attr-missing-parent-ancestor-missing-expected.txt: Copied from LayoutTests/editing/editability/attr-missing-parent-ancestor-missing-expected.txt.
  • fast/dom/HTMLElement/attr-missing-parent-ancestor-missing.html: Copied from LayoutTests/editing/editability/attr-missing-parent-ancestor-missing.html.
  • fast/dom/HTMLElement/attr-missing-parent-false-expected.txt: Copied from LayoutTests/editing/editability/attr-missing-parent-false-expected.txt.
  • fast/dom/HTMLElement/attr-missing-parent-false.html: Copied from LayoutTests/editing/editability/attr-missing-parent-false.html.
  • fast/dom/HTMLElement/attr-missing-parent-true-expected.txt: Copied from LayoutTests/editing/editability/attr-missing-parent-true-expected.txt.
  • fast/dom/HTMLElement/attr-missing-parent-true.html: Copied from LayoutTests/editing/editability/attr-missing-parent-true.html.
  • fast/dom/HTMLElement/attr-true-string-expected.txt: Copied from LayoutTests/editing/editability/attr-true-string-expected.txt.
  • fast/dom/HTMLElement/attr-true-string.html: Copied from LayoutTests/editing/editability/attr-true-string.html.
  • fast/dom/HTMLElement/set-false-expected.txt: Copied from LayoutTests/editing/editability/set-false-expected.txt.
  • fast/dom/HTMLElement/set-false.html: Copied from LayoutTests/editing/editability/set-false.html.
  • fast/dom/HTMLElement/set-inherit-parent-false-expected.txt: Copied from LayoutTests/editing/editability/set-inherit-parent-false-expected.txt.
  • fast/dom/HTMLElement/set-inherit-parent-false.html: Copied from LayoutTests/editing/editability/set-inherit-parent-false.html.
  • fast/dom/HTMLElement/set-inherit-parent-true-expected.txt: Copied from LayoutTests/editing/editability/set-inherit-parent-true-expected.txt.
  • fast/dom/HTMLElement/set-inherit-parent-true.html: Copied from LayoutTests/editing/editability/set-inherit-parent-true.html.
  • fast/dom/HTMLElement/set-invalid-value-expected.txt: Copied from LayoutTests/editing/editability/set-invalid-value-expected.txt.
  • fast/dom/HTMLElement/set-invalid-value.html: Copied from LayoutTests/editing/editability/set-invalid-value.html.
  • fast/dom/HTMLElement/set-true-expected.txt: Copied from LayoutTests/editing/editability/set-true-expected.txt.
  • fast/dom/HTMLElement/set-true.html: Copied from LayoutTests/editing/editability/set-true.html.
  • fast/dom/HTMLElement/set-value-caseinsensitive-expected.txt: Copied from LayoutTests/editing/editability/set-value-caseinsensitive-expected.txt.
  • fast/dom/HTMLElement/set-value-caseinsensitive.html: Copied from LayoutTests/editing/editability/set-value-caseinsensitive.html.
9:37 AM Changeset in webkit [76527] by tony@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

2011-01-24 Tony Chang <tony@chromium.org>

Reviewed by James Robinson.

[chromium] turn off gyp circular dependency checking and roll chromium deps
https://bugs.webkit.org/show_bug.cgi?id=52935

  • DEPS:
  • gyp_webkit: Turn off gyp circular dependency checking on Linux

and Win since we don't do these checks in gyp_chromium. It's
just making it harder for us to roll DEPS and have something
explode.

9:35 AM Changeset in webkit [76526] by satish@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-01-24 Satish Sampath <satish@chromium.org>

Reviewed by Csaba Osztrogonác.

Remove obsolete public/API method in chromium port
https://bugs.webkit.org/show_bug.cgi?id=53015

  • public/WebSpeechInputController.h: (WebKit::WebSpeechInputController::startRecognition): Removed obsolete method
9:29 AM Changeset in webkit [76525] by abecsi@webkit.org
  • 2 edits in trunk/Tools

2011-01-24 Andras Becsi <abecsi@webkit.org>

Rubber-stamped by Csaba Osztrogonác.

[Qt] Move project files into Source
https://bugs.webkit.org/show_bug.cgi?id=52891

  • DumpRenderTree/qt/ImageDiff.pro: Add missing "Source" to WebKit.pri path
9:25 AM Changeset in webkit [76524] by weinig@apple.com
  • 2 edits in trunk/LayoutTests

Add editing/inserting/insert-composition-whitespace.html to the windows
skipped list.

  • platform/win/Skipped:
8:56 AM Changeset in webkit [76523] by Csaba Osztrogonác
  • 42 edits
    115 adds in trunk/LayoutTests

Unreviewed.

Add Qt specific expected results for passing editing/selections tests.
Compared to Mac png files and Mac expected files. (part 3)

  • platform/qt/editing/selection/ [...]:
8:50 AM Changeset in webkit [76522] by Csaba Osztrogonác
  • 10 edits
    72 adds in trunk/LayoutTests

Unreviewed.

Add Qt specific expected results for passing editing/selections tests.
Compared to Mac png files and Mac expected files. (part 2)

  • platform/qt/editing/selection/ [...]:
8:37 AM Changeset in webkit [76521] by Csaba Osztrogonác
  • 55 edits
    240 adds in trunk/LayoutTests

Unreviewed.

Add Qt specific expected results for passing editing/selections tests.
Compared to Mac png files and Mac expected files. (part 1)

  • platform/qt/editing/selection/ [...]:
8:20 AM Changeset in webkit [76520] by kbalazs@webkit.org
  • 2 edits in trunk/Source/WebKit2

Typo fix.

Rubber-stamped by Csaba Osztrogonác.

  • UIProcess/Launcher/qt/ProcessLauncherQt.cpp:

(WebKit::ProcessLauncher::launchProcess): Move the bracket to the right place.

7:28 AM Changeset in webkit [76519] by pfeldman@chromium.org
  • 5 edits in trunk/Source/WebCore

2011-01-24 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: extract dispatch API from network manager.
https://bugs.webkit.org/show_bug.cgi?id=53009

  • WebCore.xcodeproj/project.pbxproj:
  • inspector/front-end/NetworkManager.js: (WebInspector.NetworkManager): (WebInspector.NetworkManager.prototype.reset): (WebInspector.NetworkManager.prototype.requestContent): (WebInspector.NetworkManager.prototype._processCachedResources): (WebInspector.NetworkDispatcher): (WebInspector.NetworkDispatcher.prototype._updateResourceWithRequest): (WebInspector.NetworkDispatcher.prototype._updateResourceWithResponse): (WebInspector.NetworkDispatcher.prototype._updateResourceWithCachedResource): (WebInspector.NetworkDispatcher.prototype.identifierForInitialRequest): (WebInspector.NetworkDispatcher.prototype.willSendRequest): (WebInspector.NetworkDispatcher.prototype.didReceiveResponse): (WebInspector.NetworkDispatcher.prototype.didLoadResourceFromMemoryCache): (WebInspector.NetworkDispatcher.prototype.didCommitLoadForFrame): (WebInspector.NetworkDispatcher.prototype.didCreateWebSocket): (WebInspector.NetworkDispatcher.prototype._appendRedirect): (WebInspector.NetworkDispatcher.prototype._startResource): (WebInspector.NetworkDispatcher.prototype._updateResource): (WebInspector.NetworkDispatcher.prototype._finishResource): (WebInspector.NetworkDispatcher.prototype._addFramesRecursively): (WebInspector.NetworkDispatcher.prototype._dispatchEventToListeners): (WebInspector.NetworkDispatcher.prototype._createResource):
  • inspector/front-end/Resource.js: (WebInspector.Resource.prototype._innerRequestContent):
  • inspector/front-end/ResourceTreeModel.js: (WebInspector.ResourceTreeModel): (WebInspector.ResourceTreeModel.prototype.reset): (WebInspector.ResourceTreeModel.prototype.unbindResourceURL):
7:20 AM Changeset in webkit [76518] by yurys@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-01-24 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [JSC] remove ScriptDebugServer::pageCreated
https://bugs.webkit.org/show_bug.cgi?id=53007

It's impossible to create "provisional" inspector for pages which are
not yet created so there is no need to listen for page creation in ScriptDebugServer.

  • bindings/js/ScriptDebugServer.cpp:
  • bindings/js/ScriptDebugServer.h:
  • page/Page.cpp: (WebCore::Page::Page):
7:11 AM Changeset in webkit [76517] by podivilov@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-01-24 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [REGRESSION] AppCache view on resources panel is broken.
https://bugs.webkit.org/show_bug.cgi?id=53002

  • inspector/front-end/ApplicationCacheItemsView.js: (WebInspector.ApplicationCacheItemsView.prototype._update):
  • inspector/front-end/DOMAgent.js: (WebInspector.ApplicationCacheDispatcher.getApplicationCachesAsync):
7:01 AM Changeset in webkit [76516] by reni@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

[Qt] QWebFramePrivate::renderRelativeCoords() calls QPainter::save/restore more than necessary
https://bugs.webkit.org/show_bug.cgi?id=49915

Reviewed by Andreas Kling.

In the first loop of renderRelativeCoords() the call of QPainter::save/restore is useless, because
the context is saved/stored within the loop.
In the second loop the calls are also avoidable by using inverse translation on context.

  • Api/qwebframe.cpp:

(QWebFramePrivate::renderRelativeCoords):

6:46 AM Changeset in webkit [76515] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebCore

2011-01-24 Andreas Kling <kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Fix warnings about unregistering an invalid timer
https://bugs.webkit.org/show_bug.cgi?id=53006

The ShadowBuffer's purge timer ID was initialized with 0 which lead
to us calling QObject::killTimer(0), causing some qWarnings.

  • platform/graphics/qt/ContextShadowQt.cpp: (WebCore::ShadowBuffer::ShadowBuffer): (WebCore::ShadowBuffer::schedulePurge):
6:39 AM Changeset in webkit [76514] by mnaganov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-01-21 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Chromium] Fix heap snapshot table sorting.

Fix table sorting to avoid qsort instability artefacts.

https://bugs.webkit.org/show_bug.cgi?id=52914

  • inspector/front-end/HeapSnapshotView.js: (WebInspector.HeapSnapshotView.prototype._sortData): (WebInspector.HeapSnapshotDataGridList.propertyComparator.comparator): (WebInspector.HeapSnapshotDataGridList.propertyComparator):
6:24 AM Changeset in webkit [76513] by Csaba Osztrogonác
  • 2 edits
    1 delete in trunk/LayoutTests

Unreviewed.

RTL: selection.modify("move", "forward", "line") when cursor is at start of a line does not move down a line
https://bugs.webkit.org/show_bug.cgi?id=51517

  • platform/qt-linux/editing: Removed.
  • platform/qt-linux/editing/selection: Removed.
  • platform/qt-linux/editing/selection/extend-to-line-boundary-expected.txt: Removed.
  • platform/qt/Skipped: Add editing/selection/extend-to-line-boundary.html until fix.
6:16 AM Changeset in webkit [76512] by podivilov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-01-24 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, build fix for r76509.

  • inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::setBreakpoint):
6:06 AM Changeset in webkit [76511] by mnaganov@chromium.org
  • 4 edits in trunk

2011-01-24 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Find duplicate strings in localizedStrings.js, update it.

https://bugs.webkit.org/show_bug.cgi?id=53005

  • English.lproj/localizedStrings.js:
  • Scripts/check-inspector-strings:
6:05 AM Changeset in webkit [76510] by podivilov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-01-24 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, build fix for r76509.

  • bindings/js/ScriptDebugServer.h:
5:55 AM Changeset in webkit [76509] by podivilov@chromium.org
  • 20 edits
    1 delete in trunk/Source/WebCore

2011-01-24 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: set breakpoints by line:column.
https://bugs.webkit.org/show_bug.cgi?id=52615

  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::setBreakpoint): (WebCore::ScriptDebugServer::removeBreakpoint): (WebCore::ScriptDebugServer::hasBreakpoint): (WebCore::ScriptDebugServer::clearBreakpoints):
  • bindings/js/ScriptDebugServer.h:
  • bindings/v8/DebuggerScript.js: ():
  • bindings/v8/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::setBreakpoint):
  • bindings/v8/ScriptDebugServer.h:
  • inspector/Inspector.idl:
  • inspector/InspectorBrowserDebuggerAgent.cpp: (WebCore::InspectorBrowserDebuggerAgent::restoreStickyBreakpoint):
  • inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::setStickyBreakpoint): (WebCore::InspectorDebuggerAgent::setBreakpoint): (WebCore::InspectorDebuggerAgent::restoreBreakpoint): (WebCore::InspectorDebuggerAgent::didParseSource):
  • inspector/InspectorDebuggerAgent.h:
  • inspector/ScriptBreakpoint.cpp: Removed.
  • inspector/ScriptBreakpoint.h: (WebCore::ScriptBreakpoint::ScriptBreakpoint):
  • inspector/front-end/Breakpoint.js: (WebInspector.Breakpoint): (WebInspector.Breakpoint.prototype.get url):
  • inspector/front-end/BreakpointManager.js: (WebInspector.JavaScriptBreakpoint.prototype._serializeToJSON):
  • inspector/front-end/DebuggerModel.js: (WebInspector.DebuggerModel.prototype.continueToLine): (WebInspector.DebuggerModel.prototype.setBreakpoint): (WebInspector.DebuggerModel.prototype._breakpointSetOnBackend): (WebInspector.DebuggerDispatcher.prototype.breakpointResolved):
5:05 AM Changeset in webkit [76508] by Csaba Osztrogonác
  • 1 edit
    1 delete in trunk
  • runtime: Removed. It was accidentally created by r76457.

Rubber-stamped by Csaba Osztrogonác.
Patch by Peter Gal <galpater@inf.u-szeged.hu> on 2011-01-24

4:58 AM Changeset in webkit [76507] by commit-queue@webkit.org
  • 19 edits
    1 copy
    2 deletes in trunk/Source/WebKit2

2011-01-24 Kimmo Kinnunen <kimmo.t.kinnunen@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Remove CleanupHandler by passing file descriptors.

Deleting files in signal handler of UI process is not a good idea,
because the memory where filenames are stored might not be valid
after a crash.

To avoid the need of using signal handlers for cleanup,
change following:

1) Avoid passing filenames between processes, pass fds
2) When mmap'ing files, delete them immediately after

opening and mmap'ing them.

3) Pass sockets with fds during fork+exec instead of

passing them via the filesystem.

4) Use mmap'ed files for implementation of SharedMemory.

QSharedMemory does not support cleanup correctly.

Consquences:

  • Move MappedMemory to SharedMemory, make UpdateChunk use this.
  • Implement CoreIPC::Attachment using mmaped files.
  • Send messages using datagram socket. This solution works similiarly to Mach ports on Mac.
  • Send big messages out-of-line and thus avoid increasing the receive buffer.
  • Remove MemoryMappedPool and rely on libc/kernel caching of mmapped areas.
  • Unmap memory areas after use.
  • When UI process crashes, kill the web process using SIGKILL. This is possible again because cleanup handler is not needed.

[WK2][Qt] Multiple problems with MemoryMappedPool
https://bugs.webkit.org/show_bug.cgi?id=51984

  • Platform/CoreIPC/Attachment.cpp: (CoreIPC::Attachment::Attachment):
  • Platform/CoreIPC/Attachment.h: (CoreIPC::Attachment::size): (CoreIPC::Attachment::releaseFileDescriptor): (CoreIPC::Attachment::fileDescriptor):
  • Platform/CoreIPC/Connection.h:
  • Platform/CoreIPC/qt/ConnectionQt.cpp: (CoreIPC::MessageInfo::MessageInfo): (CoreIPC::MessageInfo::setMessageBodyOOL): (CoreIPC::MessageInfo::isMessageBodyOOL): (CoreIPC::MessageInfo::bodySize): (CoreIPC::MessageInfo::messageID): (CoreIPC::MessageInfo::attachmentCount): (CoreIPC::Connection::platformInitialize): (CoreIPC::Connection::platformInvalidate): (CoreIPC::SocketNotifierDisableGuard::SocketNotifierDisableGuard): (CoreIPC::SocketNotifierDisableGuard::~SocketNotifierDisableGuard): (CoreIPC::Connection::readyReadHandler): (CoreIPC::Connection::open): (CoreIPC::Connection::platformCanSendOutgoingMessages): (CoreIPC::Connection::sendOutgoingMessage):
  • Platform/SharedMemory.h:
  • Platform/WorkQueue.h:
  • Platform/qt/MappedMemoryPool.cpp: Removed.
  • Platform/qt/MappedMemoryPool.h: Removed.
  • Platform/qt/SharedMemoryQt.cpp: (WebKit::SharedMemory::Handle::Handle): (WebKit::SharedMemory::Handle::~Handle): (WebKit::SharedMemory::Handle::isNull): (WebKit::SharedMemory::Handle::encode): (WebKit::SharedMemory::Handle::decode): (WebKit::SharedMemory::Handle::releaseToAttachment): (WebKit::SharedMemory::Handle::adoptFromAttachment): (WebKit::SharedMemory::create): (WebKit::accessModeMMap): (WebKit::SharedMemory::~SharedMemory): (WebKit::accessModeFile): (WebKit::SharedMemory::createHandle):
  • Platform/qt/WorkQueueQt.cpp: (WorkQueue::registerSocketEventHandler):
  • Shared/qt/UpdateChunk.cpp: (WebKit::UpdateChunk::UpdateChunk): (WebKit::UpdateChunk::~UpdateChunk): (WebKit::UpdateChunk::encode): (WebKit::UpdateChunk::decode): (WebKit::UpdateChunk::createImage):
  • Shared/qt/UpdateChunk.h:
  • UIProcess/Launcher/ProcessLauncher.h:
  • UIProcess/Launcher/qt/ProcessLauncherQt.cpp: (WebKit::QtWebProcess::QtWebProcess): (WebKit::QtWebProcess::setupChildProcess): (WebKit::ProcessLauncher::launchProcess): (WebKit::ProcessLauncher::platformInvalidate):
  • UIProcess/Launcher/qt/ThreadLauncherQt.cpp: (WebKit::webThreadBody): (WebKit::ThreadLauncher::createWebThread):
  • WebKit2.pro:
  • WebProcess/qt/WebProcessMainQt.cpp: (WebKit::WebProcessMainQt):
4:56 AM Changeset in webkit [76506] by yurys@chromium.org
  • 5 edits in trunk/LayoutTests

2011-01-24 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Update Chromium test expectations.

  • platform/chromium-mac/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-document-write-expected.txt:
  • platform/chromium-mac/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-javascript-url-expected.txt:
  • platform/chromium-mac/http/tests/security/xss-DENIED-frame-name-expected.txt:
  • platform/chromium/test_expectations.txt:
4:46 AM Changeset in webkit [76505] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-01-24 Peter Beverloo <peter@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: recognize application/x-font-woff as a valid mime-type.
https://bugs.webkit.org/show_bug.cgi?id=52977

No new tests.

  • inspector/front-end/inspector.js:
3:55 AM Changeset in webkit [76504] by podivilov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-01-24 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, fix for r76497.

  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.show):
3:53 AM Changeset in webkit [76503] by zoltan@webkit.org
  • 3 edits in trunk/Tools

[Qt] Regroup MiniBrowser's menubar and add open file action
https://bugs.webkit.org/show_bug.cgi?id=53000

Reviewed by Andreas Kling.

Add File and Develop menu to MiniBrowser's menubar and add open file action to File menu.

  • MiniBrowser/qt/BrowserWindow.cpp:

(BrowserWindow::BrowserWindow):
(BrowserWindow::openFile):
(BrowserWindow::~BrowserWindow):

  • MiniBrowser/qt/BrowserWindow.h:
3:52 AM Changeset in webkit [76502] by pvarga@webkit.org
  • 5 edits in trunk

2011-01-24 Peter Varga <pvarga@inf.u-szeged.hu>

Reviewed by Oliver Hunt.

Optimize regex patterns which contain empty alternatives
https://bugs.webkit.org/show_bug.cgi?id=51395

Eliminate the empty alternatives from the regex pattern and convert it to do
the matching in an easier way.

  • fast/regex/script-tests/slow.js:
  • fast/regex/slow-expected.txt:

2011-01-24 Peter Varga <pvarga@webkit.org>

Reviewed by Oliver Hunt.

Optimize regex patterns which contain empty alternatives
https://bugs.webkit.org/show_bug.cgi?id=51395

Eliminate the empty alternatives from the regex pattern and convert it to do
the matching in an easier way.

  • yarr/YarrPattern.cpp: (JSC::Yarr::YarrPatternConstructor::atomParenthesesEnd):
3:51 AM Changeset in webkit [76501] by andreas.kling@nokia.com
  • 3 edits in trunk/Source/WebCore

2011-01-24 Andreas Kling <kling@webkit.org>

Reviewed by Tor Arne Vestbø.

[Qt] Use rad2deg() from WTF instead of rolling our own.
https://bugs.webkit.org/show_bug.cgi?id=52993

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::rotate):
  • platform/graphics/qt/PathQt.cpp: (WebCore::Path::addArc):
3:35 AM Changeset in webkit [76500] by podivilov@chromium.org
  • 2 edits in trunk/LayoutTests

2011-01-24 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, test fix for r76497.

  • http/tests/inspector/debugger-test2.js: (initialize_DebuggerTest.InspectorTest.setBreakpointInVisibleView): (initialize_DebuggerTest.InspectorTest._showScriptSource):
3:22 AM Changeset in webkit [76499] by Csaba Osztrogonác
  • 4 edits in trunk/Tools

Unreviewed fix after r76496

[Qt] Move project files into Source
https://bugs.webkit.org/show_bug.cgi?id=52891

  • BuildSlaveSupport/build.webkit.org-config/master.cfg: Remove unnecessary "Source" from the path.
  • BuildSlaveSupport/built-product-archive: Remove unnecessary "Source" from the path.
  • Scripts/webkitdirs.pm: Add the accidentally removed slash to the path.
2:57 AM Changeset in webkit [76498] by sergio@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-01-24 Sergio Villar Senin <svillar@igalia.com>

Reviewed by Martin Robinson.

[Gtk] ResourceHandleSoup: do not wait for streams to close to issue didFinishLoading
https://bugs.webkit.org/show_bug.cgi?id=52885

No new tests as it does not change functionality. We will not wait for
the the input stream to close to issue didFinishLoading to
WebCore. We expect a subtle performance improvement with this
patch when loading complex web pages, as we wouldn't have to wait
for the stream to close (which involves creating a thread among
other things).

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::closeCallback): (WebCore::readCallback):
2:38 AM Changeset in webkit [76497] by podivilov@chromium.org
  • 10 edits
    2 deletes in trunk/Source/WebCore

2011-01-21 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: eliminate SourceView and ScriptView classes.
https://bugs.webkit.org/show_bug.cgi?id=52896

SourceView and ScriptView delegate everything to SourceFrame and should be eliminated.

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/GoToLineDialog.js: (WebInspector.GoToLineDialog.prototype._highlightSelectedLine):
  • inspector/front-end/ResourceView.js: (WebInspector.ResourceView.createResourceView): (WebInspector.ResourceView.resourceViewTypeMatchesResource): (WebInspector.SourceFrameContentProviderForResource): Moved from SourceView.
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.show): (WebInspector.ResourcesPanel.prototype._applyDiffMarkup): (WebInspector.FrameResourceTreeElement.prototype._errorsWarningsUpdated):
  • inspector/front-end/ScriptView.js: Removed.
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._scriptSourceChanged): (WebInspector.ScriptsPanel.prototype._sourceFrameForScriptOrResource): (WebInspector.ScriptsPanel.prototype._showScriptOrResource): (WebInspector.ScriptsPanel.prototype._setPauseOnExceptions): (WebInspector.ScriptsPanel.prototype._formatScript): (WebInspector.SourceFrameContentProviderForScript): Moved from ScriptView.
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame): (WebInspector.SourceFrame.prototype.show): (WebInspector.SourceFrame.prototype.hide): (WebInspector.SourceFrame.prototype.hasContent): (WebInspector.SourceFrame.prototype._createTextViewer): (WebInspector.SourceFrame.prototype.performSearch.doFindSearchMatches): (WebInspector.SourceFrame.prototype.performSearch):
  • inspector/front-end/SourceView.js: Removed.
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
2:36 AM Changeset in webkit [76496] by abecsi@webkit.org
  • 26 edits
    1 copy
    3 moves
    2 adds
    1 delete in trunk

2011-01-24 Andras Becsi <abecsi@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt] Move project files into Source
https://bugs.webkit.org/show_bug.cgi?id=52891

  • Source/DerivedSources.pro: Copied from DerivedSources.pro.
  • Source/WebKit.pri: Renamed from WebKit.pri.
  • Source/WebKit.pro: Added.
  • Source/common.pri: Renamed from common.pri.
  • WebKit.pro: Removed.

2011-01-24 Andras Becsi <abecsi@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt] Move project files into Source
https://bugs.webkit.org/show_bug.cgi?id=52891

2011-01-24 Andras Becsi <abecsi@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt] Move project files into Source
https://bugs.webkit.org/show_bug.cgi?id=52891

No new tests needed.

  • WebCore.pri:
  • WebCore.pro:

2011-01-24 Andras Becsi <abecsi@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt] Move project files into Source
https://bugs.webkit.org/show_bug.cgi?id=52891

  • declarative/declarative.pro:
  • docs/docs.pri:
  • tests/tests.pri:

2011-01-24 Andras Becsi <abecsi@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt] Move project files into Source
https://bugs.webkit.org/show_bug.cgi?id=52891

  • DerivedSources.pro:
  • WebKit2.pro:
  • WebProcess.pro:

2011-01-24 Andras Becsi <abecsi@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt] Move project files into Source
https://bugs.webkit.org/show_bug.cgi?id=52891

  • DerivedSources.pro: Renamed from DerivedSources.pro.
  • DumpRenderTree/qt/DumpRenderTree.pro:
  • DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
  • MiniBrowser/DerivedSources.pro:
  • MiniBrowser/qt/MiniBrowser.pro:
  • QtTestBrowser/QtTestBrowser.pro:
  • Scripts/webkitdirs.pm:
  • Tools.pro: Added.
  • WebKitTestRunner/DerivedSources.pro:
  • WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
  • WebKitTestRunner/qt/WebKitTestRunner.pro:
2:32 AM Changeset in webkit [76495] by tkent@chromium.org
  • 3 edits in trunk/Source/WebCore

Unreviewed, trivial fix.

Fix a Chromium-only assertion failure by r76491.
https://bugs.webkit.org/show_bug.cgi?id=38982

Separate icon loading from the FileChooser constructor in order to avoid
ref() before adoptRef().

  • platform/FileChooser.cpp:

(WebCore::FileChooser::FileChooser):
(WebCore::FileChooser::initialize):
(WebCore::FileChooser::create):

  • platform/FileChooser.h:
2:27 AM Changeset in webkit [76494] by morrita@google.com
  • 3 edits in trunk/Source/WebCore

2011-01-24 MORITA Hajime <morrita@google.com>

Reviewed by Kent Tamura.

TextControlInnerElement::m_shadowParent should be removed.
https://bugs.webkit.org/show_bug.cgi?id=52998

No new tests. No behavioral change.

  • rendering/TextControlInnerElements.cpp: (WebCore::TextControlInnerElement::TextControlInnerElement):
  • rendering/TextControlInnerElements.h:
2:20 AM Changeset in webkit [76493] by yurys@chromium.org
  • 10 edits
    2 adds in trunk/Source/WebCore

2011-01-24 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

REGRESSION (r72895): console.trace crashes
https://bugs.webkit.org/show_bug.cgi?id=52981

  • Use local RefPtr variable for accessing PassRefPtr arguments to make sure the PassRefPtr has non-null value.
  • Use PassRefPtr for objects whos ownership is passed to the inspector.
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/InspectorConsoleInstrumentation.h: Added. Extract inline methods called from the console into their own header to reduce compilation time of other classes that depend on the inspector instrumentation. (WebCore::InspectorInstrumentation::addMessageToConsole): (WebCore::InspectorInstrumentation::consoleCount): (WebCore::InspectorInstrumentation::startConsoleTiming): (WebCore::InspectorInstrumentation::stopConsoleTiming): (WebCore::InspectorInstrumentation::consoleMarkTimeline): (WebCore::InspectorInstrumentation::addStartProfilingMessageToConsole): (WebCore::InspectorInstrumentation::addProfile): (WebCore::InspectorInstrumentation::profilerEnabled): (WebCore::InspectorInstrumentation::getCurrentUserInitiatedProfileName):
  • inspector/InspectorDatabaseInstrumentation.h: Added. Extract inline methods called from the datanase code into their own header to reduce compilation time of other classes that depend on the inspector instrumentation. (WebCore::InspectorInstrumentation::didOpenDatabase):
  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::addMessageToConsoleImpl): (WebCore::InspectorInstrumentation::consoleCountImpl): (WebCore::InspectorInstrumentation::stopConsoleTimingImpl): (WebCore::InspectorInstrumentation::consoleMarkTimelineImpl): (WebCore::InspectorInstrumentation::addProfileImpl): (WebCore::InspectorInstrumentation::didOpenDatabaseImpl):
  • inspector/InspectorInstrumentation.h:
  • page/Console.cpp: use RefPtr local variable instead of accessing PassRefPtr argument directly. (WebCore::Console::addMessage): (WebCore::Console::trace): (WebCore::Console::count): (WebCore::Console::markTimeline): (WebCore::Console::profileEnd): (WebCore::Console::timeEnd): (WebCore::Console::group): (WebCore::Console::groupCollapsed):
  • storage/Database.cpp: (WebCore::Database::openDatabase):
1:16 AM Changeset in webkit [76492] by yuzo@google.com
  • 1 edit
    10 adds in trunk/LayoutTests

2011-01-24 Yuzo Fujishima <yuzo@google.com>

Unreviewed Chromium test expectation change.

Update Chromim test expectations (LINUX/SVG) in response to r76442, again.

  • platform/chromium-linux/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt: Added.
  • platform/chromium-linux/svg/custom/svg-fonts-in-html-expected.txt: Added.
  • platform/chromium-linux/svg/custom/svg-fonts-with-no-element-reference-expected.txt: Added.
  • platform/chromium-linux/svg/text/text-hkern-expected.txt: Added.
  • platform/chromium-linux/svg/text/text-hkern-on-vertical-text-expected.checksum: Added.
  • platform/chromium-linux/svg/text/text-hkern-on-vertical-text-expected.png: Added.
  • platform/chromium-linux/svg/text/text-hkern-on-vertical-text-expected.txt: Added.
  • platform/chromium-linux/svg/text/text-text-04-t-expected.txt: Added.
  • platform/chromium-linux/svg/text/text-vkern-expected.checksum: Added.
  • platform/chromium-linux/svg/text/text-vkern-expected.txt: Added.
1:15 AM Changeset in webkit [76491] by tkent@chromium.org
  • 8 edits
    1 copy
    3 moves in trunk/Source

2010-01-24 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Support icon loading for <input type=file>
https://bugs.webkit.org/show_bug.cgi?id=38982

An icon data in Chromium port is represented as WebCore::Image. We
don't need OS-specific code anymore.

  • WebCore.gypi:
  • platform/graphics/Icon.h: (WebCore::Icon::create): Add Chromium-specific factory.
  • platform/graphics/chromium/IconChromium.cpp: Added.
  • platform/graphics/chromium/IconChromiumLinux.cpp: Removed.
  • platform/graphics/chromium/IconChromiumMac.cpp: Removed.
  • platform/graphics/chromium/IconChromiumWin.cpp: Removed.
  • platform/graphics/chromium/PlatformIcon.h:

2010-01-24 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Support icon loading for <input type=file>
https://bugs.webkit.org/show_bug.cgi?id=38982

Implement ChromeClientImpl::chooseIconForFiles(). It delegates loading
to WebViewClient::queryIconForFiles(), and an implementation of
WebViewClient::queryIconForFiles() loads an icon and passes it to a
FileChooser through WebIconLoadingCompletion.

  • WebKit.gyp:
  • public/WebIconLoadingCompletion.h: Added. (WebKit::WebIconLoadingCompletion::~WebIconLoadingCompletion):
  • public/WebViewClient.h: (WebKit::WebViewClient::queryIconForFiles):
  • src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::chooseIconForFiles):
  • src/WebIconLoadingCompletionImpl.cpp: Added. (WebKit::WebIconLoadingCompletionImpl::WebIconLoadingCompletionImpl): (WebKit::WebIconLoadingCompletionImpl::~WebIconLoadingCompletionImpl): (WebKit::WebIconLoadingCompletionImpl::didLoadIcon):
  • src/WebIconLoadingCompletionImpl.h: Added.
1:10 AM Changeset in webkit [76490] by alex
  • 2 edits in trunk/LayoutTests

2011-01-24 Alejandro G. Castro <alex@igalia.com>

Unreviewed, GTK still does not have TestInputController support. Opened
a bug to follow the issue:
https://bugs.webkit.org/show_bug.cgi?id=52997

  • platform/gtk/Skipped:
1:05 AM Changeset in webkit [76489] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-01-24 MORITA Hajime <morrita@google.com>

Unreviewed, skipped insert-composition-whitespace.html due to missing DRT feature.

  • platform/gtk/Skipped:
12:44 AM Changeset in webkit [76488] by podivilov@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-01-21 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: move search functions from SourceView to SourceFrame.
https://bugs.webkit.org/show_bug.cgi?id=52895

This is the last step before eliminating SourceView and ScriptView since
this classes just delegate everything to SourceFrame.

  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype.set visible): (WebInspector.SourceFrame.prototype._clearLineHighlight): (WebInspector.SourceFrame.prototype._createTextViewer): (WebInspector.SourceFrame.prototype.performSearch.doFindSearchMatches): (WebInspector.SourceFrame.prototype.performSearch): (WebInspector.SourceFrame.prototype.searchCanceled): (WebInspector.SourceFrame.prototype.jumpToFirstSearchResult): (WebInspector.SourceFrame.prototype.jumpToLastSearchResult): (WebInspector.SourceFrame.prototype.jumpToNextSearchResult): (WebInspector.SourceFrame.prototype.jumpToPreviousSearchResult): (WebInspector.SourceFrame.prototype.showingFirstSearchResult): (WebInspector.SourceFrame.prototype.showingLastSearchResult): (WebInspector.SourceFrame.prototype._jumpToSearchResult):
  • inspector/front-end/SourceView.js: (WebInspector.SourceView.prototype.hide): (WebInspector.SourceView.prototype.searchCanceled): (WebInspector.SourceView.prototype.performSearch): (WebInspector.SourceView.prototype.jumpToFirstSearchResult): (WebInspector.SourceView.prototype.jumpToLastSearchResult): (WebInspector.SourceView.prototype.jumpToNextSearchResult): (WebInspector.SourceView.prototype.jumpToPreviousSearchResult): (WebInspector.SourceView.prototype.showingFirstSearchResult): (WebInspector.SourceView.prototype.showingLastSearchResult): (WebInspector.SourceView.prototype.clearMessages):
12:33 AM Changeset in webkit [76487] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-01-24 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r76463.
http://trac.webkit.org/changeset/76463
https://bugs.webkit.org/show_bug.cgi?id=52993

It broke canvas/philip/tests/2d.path.stroke.skew.html
(Requested by Ossy on #webkit).

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::rotate):
  • platform/graphics/qt/PathQt.cpp: (WebCore::Path::addArc):
12:33 AM Changeset in webkit [76486] by alex
  • 2 edits in trunk/LayoutTests

2011-01-24 Alejandro G. Castro <alex@igalia.com>

Unreviewed, skipped tests failing the 64bits bot and passing in the
32bits bots. Bug following the issue:
https://bugs.webkit.org/show_bug.cgi?id=52996

  • platform/gtk/Skipped:

Jan 23, 2011:

11:52 PM Changeset in webkit [76485] by yuzo@google.com
  • 2 edits
    15 adds in trunk/LayoutTests

2011-01-23 Yuzo Fujishima <yuzo@google.com>

Unreviewed Chromium test expectation change.

Update Chromim test expectations (LINUX/SVG) in response to r76442.

  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-03-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-36-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-40-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/fonts-desc-02-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/render-groups-01-b-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/render-groups-03-t-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-text-04-t-expected.txt: Added.
  • platform/chromium-linux/svg/text/text-vkern-on-horizontal-text-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
11:19 PM Changeset in webkit [76484] by yuzo@google.com
  • 14 edits
    3 adds in trunk/LayoutTests

2011-01-23 Yuzo Fujishima <yuzo@google.com>

Unreviewed Chromium test expectation change.

Update Chromim test expectations (WIN/SVG) in response to r76442.

  • platform/chromium-win/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt:
  • platform/chromium-win/svg/custom/svg-fonts-in-html-expected.checksum:
  • platform/chromium-win/svg/custom/svg-fonts-in-html-expected.png:
  • platform/chromium-win/svg/custom/svg-fonts-in-html-expected.txt:
  • platform/chromium-win/svg/custom/svg-fonts-with-no-element-reference-expected.checksum:
  • platform/chromium-win/svg/custom/svg-fonts-with-no-element-reference-expected.png:
  • platform/chromium-win/svg/custom/svg-fonts-with-no-element-reference-expected.txt: Added.
  • platform/chromium-win/svg/text/text-hkern-on-vertical-text-expected.checksum:
  • platform/chromium-win/svg/text/text-hkern-on-vertical-text-expected.png:
  • platform/chromium-win/svg/text/text-hkern-on-vertical-text-expected.txt: Added.
  • platform/chromium-win/svg/text/text-text-04-t-expected.checksum:
  • platform/chromium-win/svg/text/text-text-04-t-expected.png:
  • platform/chromium-win/svg/text/text-text-04-t-expected.txt:
  • platform/chromium-win/svg/text/text-vkern-expected.checksum:
  • platform/chromium-win/svg/text/text-vkern-expected.png:
  • platform/chromium-win/svg/text/text-vkern-expected.txt: Added.
11:13 PM Changeset in webkit [76483] by caseq@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-01-23 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: summary bar is not resized properly with the rest of net
https://bugs.webkit.org/show_bug.cgi?id=52881

  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype.updateSidebarWidth): (WebInspector.NetworkPanel.prototype._positionSummaryBar): (WebInspector.NetworkPanel.prototype._toggleGridMode):
10:53 PM Changeset in webkit [76482] by morrita@google.com
  • 12 edits
    2 adds in trunk

2011-01-19 MORITA Hajime <morrita@google.com>

Reviewed by Ryosuke Niwa.

Space and tab characters "sent" by an input method give totally different results than typing them directly.
https://bugs.webkit.org/show_bug.cgi?id=5241

Added a test that exercises continous whitespace characters and tabs inserted by IME.

  • editing/inserting/insert-composition-whitespace-expected.txt: Added.
  • editing/inserting/insert-composition-whitespace.html: Added.

2011-01-19 MORITA Hajime <morrita@google.com>

Reviewed by Ryosuke Niwa.

Space and tab characters "sent" by an input method give totally different results than typing them directly
https://bugs.webkit.org/show_bug.cgi?id=5241

  • Introduced TextEvent::InputTypeComposition and TypingCommand::TextCompositionType to distinguish text input which is originated by composition.
  • Generalized rebalanceWhitespaceAt() to rebalanceWhitespaceOnTextSubstring() to rebalancing range of string on text node, instead of surrounding part of that.

Test: editing/inserting/insert-composition-whitespace.html

  • dom/TextEvent.h: (WebCore::TextEvent::isComposition):
  • dom/TextEventInputType.h: Added TextEventInputComposition as a member of TextEvent::InputType
  • editing/CompositeEditCommand.cpp: (WebCore::containsOnlyWhitespace): (WebCore::CompositeEditCommand::shouldRebalanceLeadingWhitespaceFor): (WebCore::CompositeEditCommand::canRebalance): (WebCore::CompositeEditCommand::rebalanceWhitespaceAt): (WebCore::CompositeEditCommand::rebalanceWhitespaceOnTextSubstring): Added: A generalized version of rebalanceWhitespaceAt(), which takes a range inside Text string.
  • editing/CompositeEditCommand.h:
  • editing/Editor.cpp: (WebCore::Editor::insertTextForConfirmedComposition): Added. (WebCore::Editor::insertTextWithoutSendingTextEvent): (WebCore::Editor::confirmComposition): Now uses insertTextForConfirmedComposition(). (WebCore::Editor::setComposition):
  • editing/Editor.h:
  • editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::input):
  • editing/InsertTextCommand.h:
  • editing/TypingCommand.cpp: (WebCore::TypingCommand::TypingCommand): (WebCore::TypingCommand::insertText): (WebCore::TypingCommand::insertTextRunWithoutNewlines):
  • editing/TypingCommand.h: Added TypingCommand::m_compositionType and TypingCommand::TextCompositionType (WebCore::TypingCommand::setCompositionType): Added. (WebCore::TypingCommand::create):
9:37 PM Changeset in webkit [76481] by yuzo@google.com
  • 15 edits
    4 adds in trunk/LayoutTests

2011-01-23 Yuzo Fujishima <yuzo@google.com>

Unreviewed Chromium test expectation change.
Update Chromim test expectations (WIN) in response to r76442.

  • platform/chromium-win/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-03-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-36-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-40-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/fonts-desc-02-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/render-groups-01-b-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/render-groups-03-t-expected.txt:
  • platform/chromium-win/svg/W3C-SVG-1.1/text-text-04-t-expected.txt:
  • platform/chromium-win/svg/batik/text/xmlSpace-expected.txt:
  • platform/chromium-win/svg/text/text-hkern-expected.txt: Added.
  • platform/chromium-win/svg/text/text-vkern-on-horizontal-text-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
8:52 PM Changeset in webkit [76480] by tkent@chromium.org
  • 2 edits in branches/chromium/597/WebCore

Merge 76319

2011-01-20 Xiaomei Ji <xji@chromium.org>

Reviewed by Dan Bernstein.

Fix regression(r71566): PDF in RTL block might messes up text directionality.
https://bugs.webkit.org/show_bug.cgi?id=52776

Test: fast/dom/52776.html

  • platform/text/BidiResolver.h: (WebCore::::checkDirectionInLowerRaiseEmbeddingLevel): (WebCore::::lowerExplicitEmbeddingLevel): (WebCore::::raiseExplicitEmbeddingLevel): (WebCore::::createBidiRunsForLine):

BUG=70234
TBR=laforge

7:48 PM Changeset in webkit [76479] by yuzo@google.com
  • 2 edits in trunk/LayoutTests

2011-01-23 Yuzo Fujishima <yuzo@google.com>

Unreviewed Chromium test expectation change.
Mark fast/dom/Document/CaretRangeFromPoint/hittest-relative-to-viewport.html as TEXT for LINUX.

  • platform/chromium/test_expectations.txt:
7:46 PM Changeset in webkit [76478] by mrowe@apple.com
  • 8 edits in trunk/Source

Follow-up to r76477.

Fix the scripts that detect problematic code such as static initializers
and destructors, weak vtables, inappropriate files in the framework wrappers,
and public headers including private headers. These had all been broken
since the projects were moved in to the Source directory as the paths to the
scripts were not updated at that time.

Source/JavaScriptCore:

Source/JavaScriptGlue:

  • JavaScriptGlue.xcodeproj/project.pbxproj:

Source/WebCore:

Stop copying an IDL file in to the framework wrapper. Doing that doesn't even make sense.

  • WebCore.xcodeproj/project.pbxproj:

Source/WebKit:

  • WebKit.xcodeproj/project.pbxproj:
7:26 PM Changeset in webkit [76477] by mrowe@apple.com
  • 3 edits in trunk/Source/WebCore

Build fix after r76459.

Static member variables or globals of types that have constructors or destructors are bad as
they generate static initializers and destructors. This is code that is run either at link time
when the library is loaded in to memory or at application termination time. Both of these are
terrible for performance and are thus outlawed in WebKit code.

The typical solution is to replace the static member or global with a function that allocates
the necessary variable on the heap. The variable is leaked to prevent it from being destroyed
at application termination time. The DEFINE_STATIC_LOCAL macro wraps this in to a concise little
package, but sadly fails to work in this case due to the type containing multiple template
parameters.

  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::inspectorAgents):

  • inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::bindInspectorAgent):
(WebCore::InspectorInstrumentation::unbindInspectorAgent):
(WebCore::InspectorInstrumentation::inspectorAgentForPage):

6:33 PM Changeset in webkit [76476] by yuzo@google.com
  • 15 edits
    4 adds
    7 deletes in trunk/LayoutTests

2011-01-23 Yuzo Fujishima <yuzo@google.com>

Unreviewed Chromium test expectation change.
Update Chromim test expectations in response to r76442.

  • platform/chromium-linux/fast/css/acid2-expected.txt: Added.
  • platform/chromium-linux/fast/css/acid2-pixel-expected.checksum:
  • platform/chromium-linux/fast/css/acid2-pixel-expected.png:
  • platform/chromium-linux/fast/css/acid2-pixel-expected.txt: Added.
  • platform/chromium-linux/fast/forms/button-sizes-expected.checksum:
  • platform/chromium-linux/fast/forms/button-sizes-expected.png:
  • platform/chromium-linux/fast/forms/button-sizes-expected.txt:
  • platform/chromium-linux/fast/forms/input-button-sizes-expected.checksum:
  • platform/chromium-linux/fast/forms/input-button-sizes-expected.png:
  • platform/chromium-linux/fast/forms/input-button-sizes-expected.txt:
  • platform/chromium-linux/http/tests/misc/acid2-expected.txt: Added.
  • platform/chromium-linux/http/tests/misc/acid2-pixel-expected.checksum:
  • platform/chromium-linux/http/tests/misc/acid2-pixel-expected.png:
  • platform/chromium-linux/http/tests/misc/acid2-pixel-expected.txt: Added.
  • platform/chromium-linux/svg/W3C-SVG-1.1/interact-zoom-01-t-expected.txt: Removed.
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-text-01-b-expected.txt:
  • platform/chromium-linux/svg/hixie/perf/003-expected.txt: Removed.
  • platform/chromium-linux/svg/hixie/perf/004-expected.txt: Removed.
  • platform/chromium-linux/svg/hixie/perf/005-expected.txt: Removed.
  • platform/chromium-linux/svg/hixie/perf/006-expected.txt: Removed.
  • platform/chromium-linux/svg/hixie/viewbox/preserveAspectRatio/001-expected.txt: Removed.
  • platform/chromium-linux/svg/hixie/viewbox/preserveAspectRatio/002-expected.txt: Removed.
  • platform/chromium-linux/svg/text/text-text-01-b-expected.checksum:
  • platform/chromium-linux/svg/text/text-text-01-b-expected.png:
  • platform/chromium-linux/svg/text/text-text-01-b-expected.txt:
5:53 PM Changeset in webkit [76475] by vangelis@chromium.org
  • 11 edits in trunk/Source/WebCore

2011-01-21 Vangelis Kokkevis <vangelis@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Add support for -webkit-mask properties to the
accelerated compositing path.
https://bugs.webkit.org/show_bug.cgi?id=49780


Tests: Existing tests in LayoutTests/compositing/masks

  • platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::draw): (WebCore::ContentLayerChromium::unreserveContentsTexture): (WebCore::ContentLayerChromium::bindContentsTexture):
  • platform/graphics/chromium/ContentLayerChromium.h:
  • platform/graphics/chromium/GraphicsLayerChromium.cpp: (WebCore::GraphicsLayerChromium::setMaskLayer):
  • platform/graphics/chromium/GraphicsLayerChromium.h:
  • platform/graphics/chromium/LayerChromium.cpp: (WebCore::LayerChromium::LayerChromium):
  • platform/graphics/chromium/LayerChromium.h: (WebCore::LayerChromium::setMaskLayer): (WebCore::LayerChromium::maskLayer): (WebCore::LayerChromium::unreserveContentsTexture): (WebCore::LayerChromium::bindContentsTexture):
  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::updateLayersRecursive):
  • platform/graphics/chromium/LayerTexture.cpp: (WebCore::LayerTexture::bindTexture):
  • platform/graphics/chromium/RenderSurfaceChromium.cpp: (WebCore::RenderSurfaceChromium::SharedValues::SharedValues): (WebCore::RenderSurfaceChromium::SharedValues::~SharedValues): (WebCore::RenderSurfaceChromium::RenderSurfaceChromium): (WebCore::RenderSurfaceChromium::draw):
  • platform/graphics/chromium/RenderSurfaceChromium.h: (WebCore::RenderSurfaceChromium::SharedValues::maskShaderProgram): (WebCore::RenderSurfaceChromium::SharedValues::maskShaderSamplerLocation): (WebCore::RenderSurfaceChromium::SharedValues::maskShaderMaskSamplerLocation): (WebCore::RenderSurfaceChromium::SharedValues::maskShaderMatrixLocation): (WebCore::RenderSurfaceChromium::SharedValues::maskShaderAlphaLocation):
5:00 PM Changeset in webkit [76474] by paroga@webkit.org
  • 8 edits in trunk/Source

2011-01-23 Patrick Gansterer <paroga@webkit.org>

Reviewed by Darin Adler.

Use WTF::StringHasher in WebCore
https://bugs.webkit.org/show_bug.cgi?id=52934

Add an additional function to calculate the hash
of data with a runtimedependent size.

  • wtf/StringHasher.h: (WTF::StringHasher::createBlobHash):

2011-01-23 Patrick Gansterer <paroga@webkit.org>

Reviewed by Darin Adler.

Use WTF::StringHasher in WebCore
https://bugs.webkit.org/show_bug.cgi?id=52934

  • loader/appcache/ApplicationCacheStorage.cpp: (WebCore::urlHostHash):
  • platform/LinkHash.cpp: (WebCore::visitedLinkHashInline):
  • platform/cf/BinaryPropertyList.cpp: (WebCore::IntegerArrayHash::hash):
  • platform/graphics/wx/FontPlatformDataWx.cpp: (WebCore::FontPlatformData::computeHash):
  • platform/network/ProtectionSpaceHash.h: (WebCore::ProtectionSpaceHash::hash):
3:50 PM Changeset in webkit [76473] by kdecker@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-01-23 Damian Kaleta <dkaleta@apple.com>

Reviewed by Kevin Decker.

<rdar://problem/8905171>
https://bugs.webkit.org/show_bug.cgi?id=52985

  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::scaleWebView): Eliminated early return inside WebPageProxy::scaleWebView, making it consistent with WebKit1.
3:17 PM Changeset in webkit [76472] by paroga@webkit.org
  • 11 edits in trunk/Source/WebCore

2011-01-23 Patrick Gansterer <paroga@webkit.org>

Reviewed by David Kilzer.

Add an overload to base64Encode with String output
https://bugs.webkit.org/show_bug.cgi?id=50122

This change removes duplicated code.

  • inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::resourceContentBase64):
  • page/DOMWindow.cpp: (WebCore::DOMWindow::btoa):
  • platform/graphics/skia/FontCustomPlatformData.cpp: (WebCore::createUniqueFontName):
  • platform/graphics/win/FontCustomPlatformData.cpp: (WebCore::createUniqueFontName):
  • platform/graphics/wince/FontCustomPlatformData.cpp: (WebCore::createUniqueFontName):
  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::encodeBasicAuthorization):
  • platform/network/mac/ResourceHandleMac.mm: (WebCore::encodeBasicAuthorization):
  • platform/text/Base64.cpp: (WebCore::base64Encode):
  • platform/text/Base64.h: (WebCore::base64Encode):
  • platform/wince/KeygenWinCE.cpp: (WebCore::WebCore::signedPublicKeyAndChallengeString):
2:57 PM Changeset in webkit [76471] by paroga@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-01-23 Patrick Gansterer <paroga@webkit.org>

Reviewed by David Kilzer.

Fix comment in String::ascii()
https://bugs.webkit.org/show_bug.cgi?id=52980

  • wtf/text/WTFString.cpp: (WTF::String::ascii):
2:28 PM Changeset in webkit [76470] by ap@apple.com
  • 3 edits
    2 adds in trunk/Source/WebKit2

2011-01-23 Alexey Proskuryakov <ap@apple.com>

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=52968
Use a separate NSView for printing

Also addresses <rdar://problem/8900148> Improper check for
-[NSGraphicsContext currentContextDrawingToScreen]

  • UIProcess/API/mac/WKPrintingView.h: Added.
  • UIProcess/API/mac/WKPrintingView.mm: Added. (-[WKPrintingView initWithFrameProxy:]): (-[WKPrintingView isFlipped]): (-[WKPrintingView _adjustPrintingMarginsForHeaderAndFooter]): (-[WKPrintingView knowsPageRange:]): (-[WKPrintingView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]): (-[WKPrintingView drawPageBorderWithSize:]): (-[WKPrintingView _provideTotalScaleFactorForPrintOperation:]): (-[WKPrintingView rectForPage:]):
  • UIProcess/API/mac/WKView.mm: (-[WKView drawRect:]): (-[WKView canChangeFrameLayout:]): (-[WKView printOperationWithPrintInfo:forFrame:]):
  • WebKit2.xcodeproj/project.pbxproj: Moved printing code to a separate view, simplifying as appropriate. The view is currently not referenced by anything in WebKit2 directly, being owned by NSPrintOperation.
2:02 PM Changeset in webkit [76469] by paroga@webkit.org
  • 4 edits in trunk/Source

2011-01-23 Patrick Gansterer <paroga@webkit.org>

Reviewed by David Kilzer.

Add String::containsOnlyLatin1()
https://bugs.webkit.org/show_bug.cgi?id=52979

  • wtf/text/WTFString.h: (WTF::String::containsOnlyLatin1): (WTF::charactersAreAllLatin1):

2011-01-23 Patrick Gansterer <paroga@webkit.org>

Reviewed by David Kilzer.

Add String::containsOnlyLatin1()
https://bugs.webkit.org/show_bug.cgi?id=52979

Use String::containsOnlyLatin1() instead of isSafeToConvertCharList().

  • page/DOMWindow.cpp: (WebCore::DOMWindow::btoa): (WebCore::DOMWindow::atob):
1:08 PM Changeset in webkit [76468] by ap@apple.com
  • 1 edit
    2 adds in trunk/LayoutTests

2011-01-23 Alexey Proskuryakov <ap@apple.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=15649
Empty STYLE elements are not reflected into the document.styleSheets object

Adding a test for a bug that no longer occurs.

  • fast/dom/document-stylesheets-empty-style-expected.txt: Added.
  • fast/dom/document-stylesheets-empty-style.html: Added.
11:50 AM Changeset in webkit [76467] by paroga@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-01-23 Patrick Gansterer <paroga@webkit.org>

Reviewed by Andreas Kling.

[CMake] Add missing CodeGenerator dependencies
https://bugs.webkit.org/show_bug.cgi?id=52976

  • CMakeLists.txt:
11:28 AM Changeset in webkit [76466] by yael.aharon@nokia.com
  • 3 edits in trunk/Source/WebCore

2011-01-23 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt][Symbian] Fix --minimal build
https://bugs.webkit.org/show_bug.cgi?id=52839

Some of the plugins' functionality is reimplemented in
Symbian specific files.
Some of this functionality should be compiled in even if
the guard NETSCAPE_PLUGIN_API is turned off.
This patch moves that functionality out of the
NETSCAPE_PLUGIN_API guard.

Build fix so no new tests.

  • WebCore.pro:
  • plugins/symbian/PluginPackageSymbian.cpp:
11:16 AM Changeset in webkit [76465] by paroga@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-01-23 Patrick Gansterer <paroga@webkit.org>

Reviewed by Oliver Hunt.

Remove obsolete JSVALUE32 code
https://bugs.webkit.org/show_bug.cgi?id=52948

r70111 removed support for JSVALUE32.
ARM, MIPS and X86 support JSVALUE32_64 only.

  • jit/JITStubs.cpp:
9:33 AM Changeset in webkit [76464] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit/mac

<rdar://problem/6097826> Mail's cursor does not become a resize cursor when moving mouse from scrolled email to the horizontal splitter

Reviewed by John Sullivan.

  • WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::setCursor): If the current cursor comes from a cursor rect, do not override it.

8:24 AM Changeset in webkit [76463] by andreas.kling@nokia.com
  • 3 edits in trunk/Source/WebCore

2011-01-23 Andreas Kling <kling@webkit.org>

Reviewed by Tor Arne Vestbø.

[Qt] Use rad2deg() from WTF instead of rolling our own.

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::rotate):
  • platform/graphics/qt/PathQt.cpp: (WebCore::Path::addArc):
6:43 AM Changeset in webkit [76462] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebCore

2011-01-23 Kenneth Rohde Christiansen <kenneth@webkit.org>

Reviewed by Andreas Kling.

Viewport meta: Always adjust device dimensions to the device pixel ratio.

  • dom/ViewportArguments.cpp: (WebCore::computeViewportAttributes):
6:33 AM Changeset in webkit [76461] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebCore

2011-01-23 Andreas Kling <kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

Don't scale absolute geometry specified by viewport meta tag.

  • dom/ViewportArguments.cpp: (WebCore::computeViewportAttributes):
2:48 AM Changeset in webkit [76460] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-01-23 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed build fix.

Web Inspector: looks like efl doesn't regenerate InspectorBackendDispatcher.

Touch Inspector.idl.

  • inspector/Inspector.idl:
1:36 AM Changeset in webkit [76459] by pfeldman@chromium.org
  • 33 edits
    2 copies in trunk/Source

2011-01-22 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: next step in splitting InspectorController.

Splitting InspectorController is a bit tricky process.

As a first step I'll do the next things:
1) rename existing InspectorController to InspectorAgent;
2) s/nspectorController/nspectorAgent/g everywhere in WebCore/inspector but InspectorInstrumentation;
3) create a fake InspectorController derived from the InspectorAgent for the rest of WebCore and WebKit;

The second step is a migration of a small set of functions described in bug 52510 from InspectorAgent to InspectorController.

As far as the second step will have significant changes in the functions' implementation I'll do it as a separate patch.

https://bugs.webkit.org/show_bug.cgi?id=52955

  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.exp.in:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::JSInjectedScriptHost::nodeForId): (WebCore::JSInjectedScriptHost::selectDOMStorage):
  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::V8InjectedScriptHost::nodeForIdCallback):
  • inspector/CodeGeneratorInspector.pm:
  • inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::InjectedScriptHost): (WebCore::InjectedScriptHost::clearConsoleMessages): (WebCore::InjectedScriptHost::databaseForId): (WebCore::InjectedScriptHost::selectDatabase): (WebCore::InjectedScriptHost::selectDOMStorage): (WebCore::InjectedScriptHost::injectedScriptForMainFrame): (WebCore::InjectedScriptHost::inspectorDOMAgent): (WebCore::InjectedScriptHost::frontend): (WebCore::InjectedScriptHost::didCreateWorker): (WebCore::InjectedScriptHost::didDestroyWorker):
  • inspector/InjectedScriptHost.h: (WebCore::InjectedScriptHost::create): (WebCore::InjectedScriptHost::inspectorAgent): (WebCore::InjectedScriptHost::disconnectController):
  • inspector/InspectorAgent.cpp: Copied from Source/WebCore/inspector/InspectorController.cpp. (WebCore::InspectorAgent::InspectorAgent): (WebCore::InspectorAgent::~InspectorAgent): (WebCore::InspectorAgent::inspectedPageDestroyed): (WebCore::InspectorAgent::enabled): (WebCore::InspectorAgent::inspectorStartsAttached): (WebCore::InspectorAgent::setInspectorStartsAttached): (WebCore::InspectorAgent::setInspectorAttachedHeight): (WebCore::InspectorAgent::inspectorAttachedHeight): (WebCore::InspectorAgent::searchingForNodeInPage): (WebCore::InspectorAgent::restoreInspectorStateFromCookie): (WebCore::InspectorAgent::inspect): (WebCore::InspectorAgent::focusNode): (WebCore::InspectorAgent::highlight): (WebCore::InspectorAgent::highlightDOMNode): (WebCore::InspectorAgent::highlightFrame): (WebCore::InspectorAgent::hideHighlight): (WebCore::InspectorAgent::mouseDidMoveOverElement): (WebCore::InspectorAgent::handleMousePress): (WebCore::InspectorAgent::setInspectorFrontendClient): (WebCore::InspectorAgent::didClearWindowObjectInWorld): (WebCore::InspectorAgent::setSearchingForNode): (WebCore::InspectorAgent::connectFrontend): (WebCore::InspectorAgent::show): (WebCore::InspectorAgent::showPanel): (WebCore::InspectorAgent::close): (WebCore::InspectorAgent::disconnectFrontend): (WebCore::InspectorAgent::resourceAgent): (WebCore::InspectorAgent::releaseFrontendLifetimeAgents): (WebCore::InspectorAgent::populateScriptObjects): (WebCore::InspectorAgent::pushDataCollectedOffline): (WebCore::InspectorAgent::restoreDebugger): (WebCore::InspectorAgent::restoreProfiler): (WebCore::InspectorAgent::unbindAllResources): (WebCore::InspectorAgent::didCommitLoad): (WebCore::InspectorAgent::mainResourceFiredDOMContentEvent): (WebCore::InspectorAgent::mainResourceFiredLoadEvent): (WebCore::InspectorAgent::isMainResourceLoader): (WebCore::InspectorAgent::willSendRequest): (WebCore::InspectorAgent::ensureSettingsLoaded): (WebCore::InspectorAgent::startTimelineProfiler): (WebCore::InspectorAgent::stopTimelineProfiler): (WebCore::PostWorkerNotificationToFrontendTask::create): (WebCore::PostWorkerNotificationToFrontendTask::PostWorkerNotificationToFrontendTask): (WebCore::PostWorkerNotificationToFrontendTask::performTask): (WebCore::InspectorAgent::postWorkerNotificationToFrontend): (WebCore::InspectorAgent::didCreateWorker): (WebCore::InspectorAgent::didDestroyWorker): (WebCore::InspectorAgent::didOpenDatabase): (WebCore::InspectorAgent::getCookies): (WebCore::InspectorAgent::buildArrayForCookies): (WebCore::InspectorAgent::buildObjectForCookie): (WebCore::InspectorAgent::deleteCookie): (WebCore::InspectorAgent::didUseDOMStorage): (WebCore::InspectorAgent::didCreateWebSocket): (WebCore::InspectorAgent::willSendWebSocketHandshakeRequest): (WebCore::InspectorAgent::didReceiveWebSocketHandshakeResponse): (WebCore::InspectorAgent::didCloseWebSocket): (WebCore::InspectorAgent::isRecordingUserInitiatedProfile): (WebCore::InspectorAgent::startUserInitiatedProfiling): (WebCore::InspectorAgent::stopUserInitiatedProfiling): (WebCore::InspectorAgent::profilerEnabled): (WebCore::InspectorAgent::enableProfiler): (WebCore::InspectorAgent::disableProfiler): (WebCore::InspectorAgent::showAndEnableDebugger): (WebCore::InspectorAgent::enableDebugger): (WebCore::InspectorAgent::disableDebugger): (WebCore::InspectorAgent::resume): (WebCore::InspectorAgent::setAllBrowserBreakpoints): (WebCore::InspectorAgent::evaluateForTestInFrontend): (WebCore::InspectorAgent::didEvaluateForTestInFrontend): (WebCore::quadToPath): (WebCore::drawOutlinedQuad): (WebCore::drawOutlinedQuadWithClip): (WebCore::drawHighlightForBox): (WebCore::drawHighlightForLineBoxesOrSVGRenderer): (WebCore::convertFromFrameToMainFrame): (WebCore::frameToMainFrameOffset): (WebCore::InspectorAgent::drawNodeHighlight): (WebCore::InspectorAgent::drawElementTitle): (WebCore::InspectorAgent::openInInspectedWindow): (WebCore::InspectorAgent::addScriptToEvaluateOnLoad): (WebCore::InspectorAgent::removeAllScriptsToEvaluateOnLoad): (WebCore::InspectorAgent::setInspectorExtensionAPI): (WebCore::InspectorAgent::inspectedURL): (WebCore::InspectorAgent::reloadPage): (WebCore::InspectorAgent::setExtraHeaders):
  • inspector/InspectorAgent.h: Copied from Source/WebCore/inspector/InspectorController.h. (WebCore::InspectorAgent::inspectorBackendDispatcher): (WebCore::InspectorAgent::inspectorClient): (WebCore::InspectorAgent::injectedScriptHost): (WebCore::InspectorAgent::inspectedPage): (WebCore::InspectorAgent::hideDOMNodeHighlight): (WebCore::InspectorAgent::hideFrameHighlight): (WebCore::InspectorAgent::frontend): (WebCore::InspectorAgent::inspectorController): (WebCore::InspectorAgent::inspectorAgent): (WebCore::InspectorAgent::consoleAgent): (WebCore::InspectorAgent::cssAgent): (WebCore::InspectorAgent::domAgent): (WebCore::InspectorAgent::injectedScriptAgent): (WebCore::InspectorAgent::runtimeAgent): (WebCore::InspectorAgent::timelineAgent): (WebCore::InspectorAgent::databaseAgent): (WebCore::InspectorAgent::domStorageAgent): (WebCore::InspectorAgent::fileSystemAgent): (WebCore::InspectorAgent::browserDebuggerAgent): (WebCore::InspectorAgent::debuggerAgent): (WebCore::InspectorAgent::profilerAgent): (WebCore::InspectorAgent::applicationCacheAgent): (WebCore::InspectorAgent::hasInspectorFrontendClient): (WebCore::InspectorAgent::hasFrontend): (WebCore::InspectorAgent::startProfiling): (WebCore::InspectorAgent::stopProfiling): (WebCore::InspectorAgent::debuggerEnabled): (WebCore::InspectorAgent::state): (WebCore::InspectorAgent::settings):
  • inspector/InspectorApplicationCacheAgent.cpp: (WebCore::InspectorApplicationCacheAgent::InspectorApplicationCacheAgent): (WebCore::InspectorApplicationCacheAgent::getApplicationCaches):
  • inspector/InspectorApplicationCacheAgent.h:
  • inspector/InspectorBrowserDebuggerAgent.cpp: (WebCore::InspectorBrowserDebuggerAgent::InspectorBrowserDebuggerAgent): (WebCore::InspectorBrowserDebuggerAgent::inspectedURLChanged): (WebCore::InspectorBrowserDebuggerAgent::restoreStickyBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::setDOMBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::removeDOMBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::willInsertDOMNode): (WebCore::InspectorBrowserDebuggerAgent::willRemoveDOMNode): (WebCore::InspectorBrowserDebuggerAgent::willModifyDOMAttr): (WebCore::InspectorBrowserDebuggerAgent::descriptionForDOMEvent): (WebCore::InspectorBrowserDebuggerAgent::pauseOnNativeEventIfNeeded): (WebCore::InspectorBrowserDebuggerAgent::willSendXMLHttpRequest):
  • inspector/InspectorBrowserDebuggerAgent.h: (WebCore::InspectorBrowserDebuggerAgent::create):
  • inspector/InspectorConsoleAgent.cpp: (WebCore::InspectorConsoleAgent::InspectorConsoleAgent): (WebCore::InspectorConsoleAgent::~InspectorConsoleAgent): (WebCore::InspectorConsoleAgent::clearConsoleMessages): (WebCore::InspectorConsoleAgent::addMessageToConsole): (WebCore::InspectorConsoleAgent::resourceRetrievedByXMLHttpRequest): (WebCore::InspectorConsoleAgent::didReceiveResponse): (WebCore::InspectorConsoleAgent::didFailLoading): (WebCore::InspectorConsoleAgent::setMonitoringXHREnabled): (WebCore::InspectorConsoleAgent::setConsoleMessagesEnabled): (WebCore::InspectorConsoleAgent::addConsoleMessage):
  • inspector/InspectorConsoleAgent.h:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController):
  • inspector/InspectorController.h:
  • inspector/InspectorDatabaseAgent.cpp:
  • inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::create): (WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent): (WebCore::InspectorDebuggerAgent::~InspectorDebuggerAgent): (WebCore::InspectorDebuggerAgent::evaluateOnCallFrame): (WebCore::InspectorDebuggerAgent::getCompletionsOnCallFrame): (WebCore::InspectorDebuggerAgent::currentCallFrames):
  • inspector/InspectorDebuggerAgent.h:
  • inspector/InspectorFileSystemAgent.cpp: (WebCore::InspectorFileSystemAgentCallbacks::didOpenFileSystem): (WebCore::InspectorFileSystemAgent::InspectorFileSystemAgent): (WebCore::InspectorFileSystemAgent::stop): (WebCore::InspectorFileSystemAgent::getFileSystemPathAsync): (WebCore::InspectorFileSystemAgent::didGetFileSystemPath): (WebCore::InspectorFileSystemAgent::didGetFileSystemError):
  • inspector/InspectorFileSystemAgent.h: (WebCore::InspectorFileSystemAgent::create):
  • inspector/InspectorFrontendHost.cpp: (WebCore::InspectorFrontendHost::setExtensionAPI):
  • inspector/InspectorProfilerAgent.cpp: (WebCore::InspectorProfilerAgent::create): (WebCore::InspectorProfilerAgent::InspectorProfilerAgent): (WebCore::InspectorProfilerAgent::addProfileFinishedMessageToConsole): (WebCore::InspectorProfilerAgent::addStartProfilingMessageToConsole): (WebCore::InspectorProfilerAgent::startUserInitiatedProfiling): (WebCore::InspectorProfilerAgent::stopUserInitiatedProfiling):
  • inspector/InspectorProfilerAgent.h:

2011-01-22 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: next step in splitting InspectorController.

#include "InspectorController.h" was added.

https://bugs.webkit.org/show_bug.cgi?id=52955

  • WebCoreSupport/InspectorServerQt.cpp:

Jan 22, 2011:

9:48 PM Changeset in webkit [76458] by mjs@apple.com
  • 2 edits in trunk/LayoutTests

2011-01-22 Maciej Stachowiak <mjs@apple.com>

Reviewed by Oliver Hunt.

Skip a test that seems to cause the subsequent test to sporadically fail, and unskip the several tests after it
https://bugs.webkit.org/show_bug.cgi?id=52970

  • platform/mac-wk2/Skipped:
9:03 PM Changeset in webkit [76457] by ggaren@apple.com
  • 5 edits
    1 add in trunk

2011-01-22 Geoffrey Garen <ggaren@apple.com>

Reviewed by Dan Bernstein.

ASSERT running run-webkit-tests --threaded.
https://bugs.webkit.org/show_bug.cgi?id=52971


SunSpider and v8 report no change.

  • runtime/ConservativeSet.cpp: (JSC::ConservativeSet::grow): (JSC::ConservativeSet::add):
  • runtime/ConservativeSet.h: Tweaked the inline capacity to 128, and the growth policy to 2X, to make SunSpider and v8 happy. (JSC::ConservativeSet::ConservativeSet): (JSC::ConservativeSet::~ConservativeSet): (JSC::ConservativeSet::mark): Use OSAllocator directly, instead of malloc. Malloc is forbidden during a multi-threaded mark phase because it can cause deadlock.

2011-01-22 Geoffrey Garen <ggaren@apple.com>

Reviewed by Dan Bernstein.

Beefed up --threaded mode to catch even more kinds of errors.
https://bugs.webkit.org/show_bug.cgi?id=52971

  • DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Use a shared context group to force JSC to mark multiple threads. (This used to be the default, but it changed in SnowLeopard.) (runJavaScriptThread): Do more locking and unlocking, and more allocation, to give threading mistakes more chances to show themselves. (startJavaScriptThreads): (stopJavaScriptThreads):
4:33 PM Changeset in webkit [76456] by dbates@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-01-22 Chris Rogers <crogers@google.com>

Rubber-stamped by Anders Carlsson.

Fix FFTFrameStub to compile properly
https://bugs.webkit.org/show_bug.cgi?id=52969

No new tests since this is a build fix.

  • platform/audio/FFTFrameStub.cpp: (WebCore::FFTFrame::FFTFrame):
1:55 PM Changeset in webkit [76455] by jam@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

2011-01-22 John Abd-El-Malek <jam@chromium.org>

Reviewed by Adam Barth.

[chromium]: Fix WebScrollbarImpl not getting scroll events after recent scrollbar refactoring
https://bugs.webkit.org/show_bug.cgi?id=52967

  • src/WebScrollbarImpl.cpp: (WebKit::WebScrollbarImpl::horizontalScrollbar): (WebKit::WebScrollbarImpl::verticalScrollbar):
  • src/WebScrollbarImpl.h:
12:11 PM Changeset in webkit [76454] by ggaren@apple.com
  • 12 edits
    2 adds in trunk/Source/JavaScriptCore

2011-01-22 Geoffrey Garen <ggaren@apple.com>

Reviewed by Geoffrey Garen.

Rubber-stamped by Maciej Stachowiak.

A few of Maciej's review suggestions for my last patch.
https://bugs.webkit.org/show_bug.cgi?id=52946

SunSpider reports no change.

  • runtime/ConservativeSet.cpp: Added. (JSC::isPointerAligned): (JSC::ConservativeSet::add):
  • runtime/ConservativeSet.h: Added. (JSC::ConservativeSet::ConservativeSet): (JSC::ConservativeSet::mark): Split ConservativeSet out into its own file, and moved the conservative check into ConservativeSet::add, making ConservativeSet's responsibility clearer.
  • runtime/Heap.cpp: (JSC::Heap::markRoots):
  • runtime/MachineStackMarker.cpp: (JSC::MachineStackMarker::markCurrentThreadConservativelyInternal): (JSC::MachineStackMarker::markOtherThreadConservatively):
  • runtime/MachineStackMarker.h:
  • runtime/MarkStack.h: Updated for changes above.
11:56 AM Changeset in webkit [76453] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-01-22 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Transparent windows with compositing WebKit2 content show garbage
https://bugs.webkit.org/show_bug.cgi?id=52966
<rdar://problem/8765051>

  • UIProcess/mac/LayerBackedDrawingAreaProxyMac.mm: (WebKit::LayerBackedDrawingAreaProxy::paint): If the WKView should draw transparent background, do so.
11:36 AM Changeset in webkit [76452] by andersca@apple.com
  • 13 edits in trunk/Source/WebKit2

2011-01-22 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Add an asynchronous WKPageForceRepaint
https://bugs.webkit.org/show_bug.cgi?id=52964
<rdar://problem/8898527>

  • UIProcess/API/C/WKPage.cpp: (WKPageForceRepaint): Call WebPageProxy::forceRepaint.
  • UIProcess/API/C/WKPage.h: Add WKPageForceRepaint.
  • UIProcess/GenericCallback.h: Add a "generic" VoidCallback class.
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::forceRepaint): Insert the callback in the m_voidCallbacks map and send a forceRepaint message.

(WebKit::WebPageProxy::voidCallback):
Call the right void callback.

(WebKit::WebPageProxy::processDidCrash):
Invalidate m_voidCallbacks.

  • UIProcess/WebPageProxy.messages.in: Add a VoidCallback message.
  • WebProcess/WebPage/ChunkedUpdateDrawingArea.cpp: (WebKit::ChunkedUpdateDrawingArea::forceRepaint): Force a repaint.
  • WebProcess/WebPage/ChunkedUpdateDrawingArea.h: Add forceRepaint.
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::forceRepaint): Call forceRepaint on the drawing area.
  • WebProcess/WebPage/WebPage.messages.in: Add a ForceRepaint message.
9:27 AM Changeset in webkit [76451] by robert@webkit.org
  • 10 edits in trunk

2011-01-22 Robert Hogan <robert@webkit.org>

Reviewed by Andreas Kling.

[Qt] Support layoutTestController.addURLToRedirect()
https://bugs.webkit.org/show_bug.cgi?id=52956

  • platform/qt/Skipped:

2011-01-22 Robert Hogan <robert@webkit.org>

Reviewed by Andreas Kling.

[Qt] Support layoutTestController.addURLToRedirect()
https://bugs.webkit.org/show_bug.cgi?id=52956

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::addURLToRedirect):
  • WebCoreSupport/DumpRenderTreeSupportQt.h:
  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::dispatchWillSendRequest):
  • WebCoreSupport/FrameLoaderClientQt.h:

2011-01-22 Robert Hogan <robert@webkit.org>

Reviewed by Andreas Kling.

[Qt] Support layoutTestController.addURLToRedirect()
https://bugs.webkit.org/show_bug.cgi?id=52956

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::addURLToRedirect):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
8:16 AM Changeset in webkit [76450] by zimmermann@webkit.org
  • 24 edits in trunk/LayoutTests

2011-01-22 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed.

REGRESSION: Vertical line metrics incorrect
https://bugs.webkit.org/show_bug.cgi?id=52960

Revert accidently landed mac baseline changes.

  • platform/mac/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-03-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-36-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-40-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/fonts-desc-02-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/render-groups-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/render-groups-03-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-text-04-t-expected.txt:
  • platform/mac/svg/batik/text/xmlSpace-expected.txt:
  • platform/mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt:
  • platform/mac/svg/custom/svg-fonts-in-html-expected.txt:
  • platform/mac/svg/custom/svg-fonts-with-no-element-reference-expected.txt:
  • platform/mac/svg/text/text-hkern-expected.txt:
  • platform/mac/svg/text/text-hkern-on-vertical-text-expected.txt:
  • platform/mac/svg/text/text-text-04-t-expected.txt:
  • platform/mac/svg/text/text-vkern-expected.txt:
  • platform/mac/svg/text/text-vkern-on-horizontal-text-expected.txt:
  • platform/mac/svg/transforms/text-with-mask-with-svg-transform-expected.txt:
7:14 AM Changeset in webkit [76449] by zimmermann@webkit.org
  • 38 edits in trunk/LayoutTests/platform

2011-01-22 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed.

REGRESSION: Vertical line metrics incorrect
https://bugs.webkit.org/show_bug.cgi?id=52960

Rebaselined several text dumps from the bots, after the FontMetrics change.
All show 1px diffs, but are progressions, since the lineSpacing calculation has been improved.
Mac still has the old results - as it depends on a rounding trick at the moment.

  • platform/gtk/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt:
  • platform/gtk/svg/text/text-hkern-expected.txt:
  • platform/gtk/svg/text/text-hkern-on-vertical-text-expected.txt:
  • platform/gtk/svg/text/text-vkern-expected.txt:
  • platform/gtk/svg/text/text-vkern-on-horizontal-text-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-03-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-36-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-40-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/fonts-desc-02-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/render-groups-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/render-groups-03-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-text-04-t-expected.txt:
  • platform/mac/svg/batik/text/xmlSpace-expected.txt:
  • platform/mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt:
  • platform/mac/svg/custom/svg-fonts-in-html-expected.txt:
  • platform/mac/svg/custom/svg-fonts-with-no-element-reference-expected.txt:
  • platform/mac/svg/text/text-hkern-expected.txt:
  • platform/mac/svg/text/text-hkern-on-vertical-text-expected.txt:
  • platform/mac/svg/text/text-text-04-t-expected.txt:
  • platform/mac/svg/text/text-vkern-expected.txt:
  • platform/mac/svg/text/text-vkern-on-horizontal-text-expected.txt:
  • platform/mac/svg/transforms/text-with-mask-with-svg-transform-expected.txt:
  • platform/qt/css2.1/t1507-c526-font-sz-02-b-a-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt:
  • platform/qt/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.txt:
  • platform/qt/svg/text/text-hkern-expected.txt:
  • platform/qt/svg/text/text-hkern-on-vertical-text-expected.txt:
  • platform/qt/svg/text/text-vkern-expected.txt:
  • platform/qt/svg/text/text-vkern-on-horizontal-text-expected.txt:
  • platform/qt/svg/transforms/text-with-mask-with-svg-transform-expected.txt:
7:00 AM Changeset in webkit [76448] by andreip@google.com
  • 7 edits
    2 adds in trunk

2011-01-22 Andrei Popescu <andreip@google.com>

Reviewed by Jeremy Orlow.

IndexedDB corrupts data on disk
https://bugs.webkit.org/show_bug.cgi?id=52890

  • storage/indexeddb/data-corruption-expected.txt: Added.
  • storage/indexeddb/data-corruption.html: Added.

2011-01-22 Andrei Popescu <andreip@google.com>

Reviewed by Jeremy Orlow.

IndexedDB corrupts data on disk
https://bugs.webkit.org/show_bug.cgi?id=52890

We need to store the SerializedScriptValues on disk in a BLOB column rather than TEXT.
Test: storage/indexeddb/data-corruption.html

  • platform/sql/SQLiteStatement.cpp: (WebCore::SQLiteStatement::bindBlob): (WebCore::SQLiteStatement::getColumnBlobAsString): (WebCore::SQLiteStatement::getColumnBlobAsVector):
  • platform/sql/SQLiteStatement.h:
  • storage/IDBCursorBackendImpl.cpp: (WebCore::IDBCursorBackendImpl::loadCurrentRow):
  • storage/IDBFactoryBackendImpl.cpp: (WebCore::runCommands): (WebCore::createTables): (WebCore::createMetaDataTable): (WebCore::migrateDatabase):
  • storage/IDBObjectStoreBackendImpl.cpp: (WebCore::IDBObjectStoreBackendImpl::getInternal): (WebCore::putObjectStoreData):
6:18 AM Changeset in webkit [76447] by zimmermann@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-01-22 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Fix WinCE build.

  • platform/graphics/wince/GraphicsContextWinCE.cpp: (WebCore::GraphicsContext::drawText):
  • rendering/RenderThemeWinCE.cpp: (WebCore::RenderThemeWinCE::adjustMenuListButtonStyle):
6:13 AM Changeset in webkit [76446] by robert@webkit.org
  • 4 edits
    4 adds in trunk

2011-01-22 Robert Hogan <robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] REGRESSION (r72360): http/tests/security/aboutBlank/xss-DENIED-* tests fail
https://bugs.webkit.org/show_bug.cgi?id=49802

  • platform/qt/Skipped:
  • platform/qt/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-document-write-expected.txt: Added.
  • platform/qt/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-javascript-url-expected.txt: Added.
  • platform/qt/http/tests/security/aboutBlank/xss-DENIED-set-opener-expected.txt: Added.

2011-01-22 Robert Hogan <robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] REGRESSION (r72360): http/tests/security/aboutBlank/xss-DENIED-* tests fail
https://bugs.webkit.org/show_bug.cgi?id=49802

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): (WebCore::DumpRenderTree::open):
5:46 AM Changeset in webkit [76445] by zimmermann@webkit.org
  • 15 edits in trunk/Source/WebCore

2011-01-22 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

REGRESSION: Vertical line metrics incorrect
https://bugs.webkit.org/show_bug.cgi?id=52960

SimpleFontDataMac.mm contains a hack to modifiy lineGap/descent for the 'Hiragino' font.
That didn't influence the lineSpacing so far, but does now, causing regressions.

Restore old line spacing behaviour to fix the regression.
Covered by existing fast/blockflow, fast/repaint and fast/text/international test cases.

  • platform/graphics/FontMetrics.h: (WebCore::FontMetrics::FontMetrics): (WebCore::FontMetrics::floatLineSpacing): (WebCore::FontMetrics::setLineSpacing): (WebCore::FontMetrics::lineSpacing): (WebCore::FontMetrics::reset):
  • platform/graphics/SimpleFontData.cpp: (WebCore::SimpleFontData::SimpleFontData):
  • platform/graphics/chromium/SimpleFontDataChromiumWin.cpp: (WebCore::SimpleFontData::platformInit):
  • platform/graphics/chromium/SimpleFontDataLinux.cpp: (WebCore::SimpleFontData::platformInit):
  • platform/graphics/freetype/SimpleFontDataFreeType.cpp: (WebCore::SimpleFontData::platformInit):
  • platform/graphics/haiku/SimpleFontDataHaiku.cpp: (WebCore::SimpleFontData::platformInit):
  • platform/graphics/mac/SimpleFontDataMac.mm: (WebCore::SimpleFontData::platformInit):
  • platform/graphics/pango/SimpleFontDataPango.cpp: (WebCore::SimpleFontData::platformInit):
  • platform/graphics/qt/SimpleFontDataQt.cpp: (WebCore::SimpleFontData::platformInit):
  • platform/graphics/win/SimpleFontDataCGWin.cpp: (WebCore::SimpleFontData::platformInit):
  • platform/graphics/win/SimpleFontDataCairoWin.cpp: (WebCore::SimpleFontData::platformInit):
  • platform/graphics/win/SimpleFontDataWin.cpp: (WebCore::SimpleFontData::initGDIFont):
  • platform/graphics/wince/SimpleFontDataWinCE.cpp: (WebCore::SimpleFontData::platformInit):
  • platform/graphics/wx/SimpleFontDataWx.cpp: (WebCore::SimpleFontData::platformInit):
4:52 AM Changeset in webkit [76444] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebCore

2011-01-22 Andreas Kling <kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] fast/backgrounds/svg-as-mask.html fails
https://bugs.webkit.org/show_bug.cgi?id=52906

Transparency layers should start out with in SourceOver mode with
alpha 1.0 (modeled after CGContextBeginTransparencyLayer.)

  • platform/graphics/qt/TransparencyLayer.h: (WebCore::TransparencyLayer::TransparencyLayer):
4:44 AM Changeset in webkit [76443] by zimmermann@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-01-22 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed.

Introduce FontMetrics abstraction
https://bugs.webkit.org/show_bug.cgi?id=51456

Fix Chromium/Win build.

  • platform/graphics/chromium/UniscribeHelperTextRun.cpp: s/->/./ (WebCore::UniscribeHelperTextRun::UniscribeHelperTextRun):
3:46 AM Changeset in webkit [76442] by zimmermann@webkit.org
  • 68 edits
    1 add in trunk/Source

2011-01-21 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Introduce FontMetrics abstraction
https://bugs.webkit.org/show_bug.cgi?id=51456

  • src/ExternalPopupMenu.cpp: Use FontMetrics instead of Font to access the metrics. (WebKit::ExternalPopupMenu::getPopupMenuInfo):
  • src/WebFontImpl.cpp: Ditto. (WebKit::WebFontImpl::ascent): (WebKit::WebFontImpl::descent): (WebKit::WebFontImpl::height): (WebKit::WebFontImpl::lineSpacing): (WebKit::WebFontImpl::xHeight):

2011-01-21 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Introduce FontMetrics abstraction
https://bugs.webkit.org/show_bug.cgi?id=51456

  • FullscreenVideoController.cpp: Use FontMetrics instead of Font to access the metrics. (FullscreenVideoController::draw):
  • WebCoreSupport/WebDragClient.cpp: Ditto. (WebDragClient::createDragImageForLink):
  • WebKitGraphics.cpp: Ditto. (FontMetrics):

2011-01-21 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Introduce FontMetrics abstraction
https://bugs.webkit.org/show_bug.cgi?id=51456

Encapsulate ascent/descent/lineHeight/lineGap methods in a single FontMetrics class, instead of
having to define them in both Font & SimpleFontData. Changed to store floating point values
as default, in order to get accurate information for small sized fonts. All these methods
now have floating-point and integer versions. Whenever an integer variant of these functions
is called, lroundf() is used to round the value.

This makes it possible to support small font-sizes for SVG in a follow-up patch, as well
as fixing rounding issues when using SVG Fonts.


Shouldn't affect existing tests.

  • GNUmakefile.am: Add FontMetrics.h to build.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: Use style->fontMetrics() instead of style->font() to access the metrics. (baselinePositionForAccessibilityRenderObject):
  • css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::computeLengthDouble):
  • html/canvas/CanvasRenderingContext2D.cpp: Ditto. (WebCore::CanvasRenderingContext2D::drawTextInternal):
  • inspector/InspectorController.cpp: Ditto. (WebCore::InspectorController::drawElementTitle):
  • platform/chromium/PopupMenuChromium.cpp: Ditto. (WebCore::PopupListBox::paintRow): (WebCore::PopupListBox::getRowHeight):
  • platform/graphics/Font.h: Remove ascent/descent/height/lineGap/lineSpacing/xHeight/unitsPerEm accessor... (WebCore::Font::fontMetrics): ... and only expose a single FontMetrics object here.
  • platform/graphics/FontFastPath.cpp: Use fontMetrics() to query metrics information. (WebCore::Font::emphasisMarkAscent): (WebCore::Font::emphasisMarkDescent): (WebCore::Font::emphasisMarkHeight): (WebCore::Font::floatWidthForSimpleText):
  • platform/graphics/FontMetrics.h: Added. (WebCore::FontMetrics::FontMetrics): Creates a FontMetrics object, stored in SimpleFontData. (WebCore::FontMetrics::unitsPerEm): Returns an unsigned describing the unitsPerEm. (WebCore::FontMetrics::setUnitsPerEm): Sets the unitsPerEm value. (WebCore::FontMetrics::floatAscent): Returns the stored m_ascent float. (WebCore::FontMetrics::setAscent): Sets the stored m_ascent float. (WebCore::FontMetrics::floatDescent): Returns the stored m_descent float. (WebCore::FontMetrics::setDescent): Sets the stored m_descent float. (WebCore::FontMetrics::floatHeight): Returns floatAscent() + floatDescent(). (WebCore::FontMetrics::floatLineGap): Returns the stored m_lineGap float. (WebCore::FontMetrics::setLineGap): Sets the stored m_lineGap float. (WebCore::FontMetrics::floatLineSpacing): Returns the stored m_lineSpacing float. (WebCore::FontMetrics::setLineSpacing): Sets the stored m_lineSpacing float. (WebCore::FontMetrics::xHeight): Returns the stored m_xHeight float (no integer version available, hence no 'float' prefix). (WebCore::FontMetrics::setXHeight): Sets the stored m_xHeight float. (WebCore::FontMetrics::ascent): Returns a rounded version of ascent(). (WebCore::FontMetrics::descent): Ditto (for descent). (WebCore::FontMetrics::height): Returns ascent() + descent(). (WebCore::FontMetrics::lineGap): Returns a rounded version of lineGap(). (WebCore::FontMetrics::lineSpacing): Ditto (for lineSpacing). (WebCore::FontMetrics::reset): Nulls all members, used only by the platform variants of SimpleFontData.
  • platform/graphics/SimpleFontData.cpp: Adapt SVG Fonts code, to initialize the FontMetrics object, as the m_ascent/etc.. members are gone. (WebCore::SimpleFontData::SimpleFontData): (WebCore::SimpleFontData::initCharWidths):
  • platform/graphics/SimpleFontData.h: Remove ascent/descent/height/lineSpacing/lineGap/xHeight/unitsPerEm accessors, and members, just store a FontMetrics object and expose it. (WebCore::SimpleFontData::fontMetrics): (WebCore::SimpleFontData::avgCharWidth):
  • platform/graphics/chromium/FontChromiumWin.cpp: Use fontMetrics() to query font metrics. (WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::estimateTextBounds): (WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::drawGlyphs): (WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::estimateTextBounds): (WebCore::Font::drawComplexText):
  • platform/graphics/chromium/SimpleFontDataChromiumWin.cpp: Adapt platform code, to initialize the FontMetrics object. (WebCore::SimpleFontData::platformInit):
  • platform/graphics/chromium/SimpleFontDataLinux.cpp: Ditto. (WebCore::SimpleFontData::platformInit):
  • platform/graphics/chromium/UniscribeHelperTextRun.cpp: Use fontMetrics() to query font metrics. (WebCore::UniscribeHelperTextRun::UniscribeHelperTextRun): (WebCore::UniscribeHelperTextRun::nextWinFontData):
  • platform/graphics/freetype/SimpleFontDataFreeType.cpp: Adapt platform code, to initialize the FontMetrics object. (WebCore::SimpleFontData::platformInit):
  • platform/graphics/haiku/SimpleFontDataHaiku.cpp: Ditto. (WebCore::SimpleFontData::platformInit):
  • platform/graphics/mac/FontComplexTextMac.cpp: Use fontMetrics() to query font metrics. (WebCore::Font::floatWidthForComplexText):
  • platform/graphics/mac/FontMac.mm: Ditto. (WebCore::showGlyphsWithAdvances):
  • platform/graphics/mac/SimpleFontDataMac.mm: Adapt platform code, to initialize the FontMetrics object. (WebCore::SimpleFontData::platformInit): (WebCore::SimpleFontData::platformCharWidthInit):
  • platform/graphics/pango/SimpleFontDataPango.cpp: Ditto. (WebCore::SimpleFontData::platformInit):
  • platform/graphics/qt/SimpleFontDataQt.cpp: Ditto. (+ Switch to QFontMetricsF to get floating-point accurancy.) (WebCore::SimpleFontData::platformInit):
  • platform/graphics/win/FontCGWin.cpp: Use fontMetrics() to query font metrics. (WebCore::drawGDIGlyphs):
  • platform/graphics/win/FontWin.cpp: Ditto. (WebCore::Font::floatWidthForComplexText):
  • platform/graphics/win/SimpleFontDataCGWin.cpp: Adapt platform code, to initialize the FontMetrics object. (WebCore::SimpleFontData::platformInit): (WebCore::SimpleFontData::platformBoundsForGlyph):
  • platform/graphics/win/SimpleFontDataCairoWin.cpp: Ditto. (WebCore::SimpleFontData::platformInit):
  • platform/graphics/win/SimpleFontDataWin.cpp: Ditto. (WebCore::SimpleFontData::initGDIFont):
  • platform/graphics/wince/GraphicsContextWinCE.cpp: Use fontMetrics() to query font metrics. (WebCore::GraphicsContext::drawText):
  • platform/graphics/wince/SimpleFontDataWinCE.cpp: Adapt platform code, to initialize the FontMetrics object. (WebCore::SimpleFontData::platformInit):
  • platform/graphics/wx/SimpleFontDataWx.cpp: Ditto. (WebCore::SimpleFontData::platformInit):
  • platform/win/PopupMenuWin.cpp: Use style->fontMetrics() instead of style->font() to access the metrics. (WebCore::PopupMenuWin::calculatePositionAndSize): (WebCore::PopupMenuWin::paint):
  • rendering/EllipsisBox.cpp: Ditto. (WebCore::EllipsisBox::paint): (WebCore::EllipsisBox::nodeAtPoint):
  • rendering/InlineBox.cpp: Ditto. (WebCore::InlineBox::logicalHeight):
  • rendering/InlineFlowBox.cpp: Ditto. (WebCore::verticalPositionForBox): (WebCore::InlineFlowBox::computeLogicalBoxHeights): (WebCore::InlineFlowBox::placeBoxesInBlockDirection):
  • rendering/InlineTextBox.cpp: Ditto. (WebCore::InlineTextBox::paint): (WebCore::InlineTextBox::paintDecoration): (WebCore::InlineTextBox::paintSpellingOrGrammarMarker): (WebCore::InlineTextBox::paintCompositionUnderline):
  • rendering/RenderBlock.cpp: Ditto. (WebCore::RenderBlock::baselinePosition): (WebCore::RenderBlock::firstLineBoxBaseline): (WebCore::RenderBlock::lastLineBoxBaseline):
  • rendering/RenderBox.cpp: Ditto. (WebCore::RenderBox::localCaretRect):
  • rendering/RenderEmbeddedObject.cpp: Ditto. (WebCore::RenderEmbeddedObject::paintReplaced):
  • rendering/RenderImage.cpp: Ditto. (WebCore::RenderImage::setImageSizeForAltText): (WebCore::RenderImage::paintReplaced):
  • rendering/RenderInline.cpp: Ditto. (WebCore::RenderInline::baselinePosition):
  • rendering/RenderListBox.cpp: Ditto. (WebCore::RenderListBox::paintItemForeground): (WebCore::RenderListBox::itemHeight):
  • rendering/RenderListMarker.cpp: Ditto. (WebCore::RenderListMarker::paint): (WebCore::RenderListMarker::layout): (WebCore::RenderListMarker::computePreferredLogicalWidths): (WebCore::RenderListMarker::updateMargins): (WebCore::RenderListMarker::getRelativeMarkerRect):
  • rendering/RenderTextControl.cpp: Ditto. (WebCore::RenderTextControl::paintPlaceholder):
  • rendering/RenderTextControlSingleLine.cpp: Ditto. (WebCore::RenderTextControlSingleLine::createInnerTextStyle):
  • rendering/RenderThemeWin.cpp: Ditto. (WebCore::RenderThemeWin::adjustMenuListButtonStyle):
  • rendering/mathml/RenderMathMLFraction.cpp: Ditto. (WebCore::RenderMathMLFraction::baselinePosition):
  • rendering/style/RenderStyle.h: Add "const FontMetrics& fontMetrics() const" accessor. (WebCore::InheritedFlags::fontMetrics): (WebCore::InheritedFlags::computedLineHeight):
  • rendering/svg/RenderSVGInlineText.cpp: Use style->fontMetrics() instead of style->font() to access the metrics. (WebCore::RenderSVGInlineText::positionForPoint):
  • rendering/svg/SVGInlineTextBox.cpp: Ditto. (WebCore::SVGInlineTextBox::selectionRectForTextFragment): (WebCore::positionOffsetForDecoration): (WebCore::SVGInlineTextBox::paintDecorationWithStyle): (WebCore::SVGInlineTextBox::paintTextWithShadows): (WebCore::SVGInlineTextBox::calculateBoundaries):
  • rendering/svg/SVGTextLayoutEngineBaseline.cpp: Ditto. (WebCore::SVGTextLayoutEngineBaseline::calculateBaselineShift): (WebCore::SVGTextLayoutEngineBaseline::calculateAlignmentBaselineShift): (WebCore::SVGTextLayoutEngineBaseline::calculateGlyphAdvanceAndOrientation):
  • rendering/svg/SVGTextLayoutEngineSpacing.cpp: Ditto. (WebCore::SVGTextLayoutEngineSpacing::calculateSVGKerning):
  • rendering/svg/SVGTextMetrics.cpp: Ditto. (WebCore::SVGTextMetrics::SVGTextMetrics):
  • rendering/svg/SVGTextQuery.cpp: Ditto. (WebCore::calculateGlyphBoundaries):
  • svg/SVGFontFaceElement.cpp: (WebCore::SVGFontFaceElement::unitsPerEm): Rename defaultUnitsPerEm global to gDefaultUnitsPerEm.
  • svg/SVGLength.cpp: Use style->fontMetrics() instead of style->font() to access the metrics. (WebCore::SVGLength::convertValueFromUserUnitsToEXS): (WebCore::SVGLength::convertValueFromEXSToUserUnits):

2011-01-21 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Introduce FontMetrics abstraction
https://bugs.webkit.org/show_bug.cgi?id=51456

  • WebProcess/WebCoreSupport/win/WebPopupMenuWin.cpp: Use FontMetrics instead of Font to access the metrics. (WebKit::WebPopupMenu::setUpPlatformData):
3:36 AM Changeset in webkit [76441] by paroga@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-01-22 Patrick Gansterer <paroga@webkit.org>

Unreviewed WinCE build fix for r76430.

  • runtime/MachineStackMarker.cpp: (JSC::swapIfBackwards):
3:02 AM Changeset in webkit [76440] by andreas.kling@nokia.com
  • 1 edit
    1 add in trunk/LayoutTests

2011-01-22 Andreas Kling <kling@webkit.org>

Unreviewed, add Qt-specific result for test added in r76414.

  • platform/qt/fast/text/justify-nbsp-expected.txt: Added.
2:58 AM Changeset in webkit [76439] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-01-22 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed Chromium test expectation update.

  • platform/chromium/test_expectations.txt:
2:51 AM Changeset in webkit [76438] by rniwa@webkit.org
  • 6 edits in trunk/Source/WebCore

2011-01-22 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Eric Seidel.

Stop instantiating legacy editing positions in VisibleSelection, visible_units.cpp, Frame, and RenderBlock
https://bugs.webkit.org/show_bug.cgi?id=52759

Stopped instantiating legacy editing positions in the following files.

  • editing/VisibleSelection.cpp: (WebCore::VisibleSelection::adjustSelectionToAvoidCrossingEditingBoundaries):
  • editing/visible_units.cpp: (WebCore::previousBoundary): (WebCore::previousLinePosition): (WebCore::nextLinePosition): (WebCore::startOfBlock):
  • page/Frame.cpp: (WebCore::Frame::visiblePositionForPoint):
  • rendering/RenderBlock.cpp: Removed RenderBlock::positionForRenderer because it was not called anywhere.
  • rendering/RenderBlock.h: Ditto.
2:00 AM Changeset in webkit [76437] by enne@google.com
  • 3 edits in trunk/Source/WebCore

2011-01-22 Adrienne Walker <enne@google.com>

Reviewed by James Robinson.

[chromium] Fix compositor repaints for offscreen fixed elements
https://bugs.webkit.org/show_bug.cgi?id=52681

The fast path scrolling was clipping offscreen invalidations.
Additionally, the compositor was ignoring all invalidations that were
entirely out of the content rect.

Test: compositing/ to verify this caused no regressions.
Tested fix manually in browser as I could not generate a LayoutTest that reproduced the bug in run-webkit-tests.

  • page/FrameView.cpp: (WebCore::FrameView::scrollContentsFastPath):
  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::invalidateRootLayerRect):
1:29 AM Changeset in webkit [76436] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-01-22 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed Chromium test expectation update.

  • platform/chromium/test_expectations.txt:
1:23 AM Changeset in webkit [76435] by ap@apple.com
  • 2 edits in trunk/Source/WebKit/mac

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=52473
Auto-scaling to avoid orphans is broken, remove dysfunctional code

  • WebView/WebHTMLView.mm: (-[WebHTMLView _setPrinting:minimumPageWidth:height:maximumPageWidth:adjustViewSize:paginateScreenContent:]): (-[WebHTMLView _scaleFactorForPrintOperation:]): (-[WebHTMLView knowsPageRange:]):
1:15 AM Changeset in webkit [76434] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-01-22 Alexey Proskuryakov <ap@apple.com>

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=52950
Leak in WebPage::drawRectToPDF

  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::drawRectToPDF): Use RetainPtr here, too.
12:22 AM Changeset in webkit [76433] by ap@apple.com
  • 4 edits in trunk/Source

2011-01-22 Alexey Proskuryakov <ap@apple.com>

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=52951
WebKit2 generates a bad PDF for cross process messaging

  • page/PrintContext.cpp: (WebCore::PrintContext::spoolRect): Use a correct offset to actually draw inside the requested rectangle.

2011-01-22 Alexey Proskuryakov <ap@apple.com>

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=52951
WebKit2 generates a bad PDF for cross process messaging

  • UIProcess/API/mac/WKView.mm: (-[WKView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]): Use a correct offset when flipping.

Jan 21, 2011:

11:11 PM Changeset in webkit [76432] by ggaren@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Reorganized MarkedSpace, making many of its functions private.

Reviewed by Beth Dakin.

  • runtime/JSCell.h:

(JSC::JSCell::Heap::heap):

  • runtime/MarkedSpace.h:

(JSC::MarkedSpace::globalData):
(JSC::MarkedSpace::heap):

10:50 PM Changeset in webkit [76431] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Try to fix build: moved helper function out of #ifdef.

  • runtime/MachineStackMarker.cpp:

(JSC::swapIfBackwards):

10:45 PM Changeset in webkit [76430] by ggaren@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

A few of Maciej's review suggestions for my last patch.
https://bugs.webkit.org/show_bug.cgi?id=52946

Rubber-stamped by Maciej Stachowiak.

SunSpider reports no change.

  • runtime/MachineStackMarker.cpp:

(JSC::swapIfBackwards): Added a helper function for handling platforms
where the stack can grow in any direction.

(JSC::MachineStackMarker::markCurrentThreadConservativelyInternal):
(JSC::MachineStackMarker::markOtherThreadConservatively): Use the helper
function.

(JSC::isPointerAligned): Use "!" instead of "==0" because a robot told me to.

(JSC::MachineStackMarker::markConservatively): Changed to use a more
standard looping idiom, and to use the helper function above.

  • runtime/MarkedSpace.h:

(JSC::MarkedSpace::isCellAligned): Use "!" instead of "==0" because a robot told me to.

10:41 PM Changeset in webkit [76429] by abarth@webkit.org
  • 5 edits
    5 adds in trunk

2011-01-21 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Adam Barth.

Regression: new window.onerror() implementation leaks cross-origin Javascript errors
https://bugs.webkit.org/show_bug.cgi?id=52903

In case of an exception in a script from different domain only generic message
will be passed to window.onerror hander.

Tests: http/tests/security/cross-origin-script-window-onerror-redirected.html

http/tests/security/cross-origin-script-window-onerror.html

  • bindings/js/CachedScriptSourceProvider.h: use URL from the resource response to make sure we do all cross origin checks agains real script URL, not the original URL which may have resulted in a sequence of redirects to different domains. (WebCore::CachedScriptSourceProvider::CachedScriptSourceProvider):
  • bindings/v8/ScriptSourceCode.h: same for v8. (WebCore::ScriptSourceCode::url):
  • dom/ScriptExecutionContext.cpp: (WebCore::ScriptExecutionContext::dispatchErrorEvent): in case the error occurred in a script we cannot access provide concise "Script error." message without any information about the error source. This is what Firefox does in this case.

2011-01-21 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Adam Barth.

Regression: new window.onerror() implementation leaks cross-origin Javascript errors
https://bugs.webkit.org/show_bug.cgi?id=52903

A couple of tests to check that window.onerror won't reveal any content of the resource
from a different domain if the latter is referenced via <script src=...>

  • http/tests/security/cross-origin-script-window-onerror-expected.txt: Added.
  • http/tests/security/cross-origin-script-window-onerror-redirected-expected.txt: Added.
  • http/tests/security/cross-origin-script-window-onerror-redirected.html: Added.
  • http/tests/security/cross-origin-script-window-onerror.html: Added.
  • http/tests/security/resources/cross-origin-script.txt: Added.
9:59 PM Changeset in webkit [76428] by abarth@webkit.org
  • 2 edits in trunk/Tools

2011-01-21 Adam Barth <abarth@webkit.org>

Reviewed by Maciej Stachowiak.

Disable mac_unittest.py that fails on some of the Mac bots
https://bugs.webkit.org/show_bug.cgi?id=52947

As noted in the comment, this test does not appear to be correct
because the function this test is testing returns different results
depending on which flavor of Mac the test is run on. This patch
disable the test. Hopefully we can re-enable the test once we've
probably insulated the test from its environment.

  • Scripts/webkitpy/layout_tests/port/mac_unittest.py:
8:57 PM Changeset in webkit [76427] by mjs@apple.com
  • 2 edits in trunk/LayoutTests

2011-01-21 Maciej Stachowiak <mjs@apple.com>

Reviewed by Geoffrey Garen.

Humor the WebKit2 buildbot in its continuing hatred of forms tests
https://bugs.webkit.org/show_bug.cgi?id=52944

  • platform/mac-wk2/Skipped:
8:30 PM Changeset in webkit [76426] by mitz@apple.com
  • 4 edits in trunk/LayoutTests

Updated the results after r76414 fixed text justification in this test.

Rubber-stamped by Mark Rowe.

  • platform/mac/fast/text/justified-text-rect-expected.checksum:
  • platform/mac/fast/text/justified-text-rect-expected.png:
  • platform/mac/fast/text/justified-text-rect-expected.txt:
8:27 PM Changeset in webkit [76425] by ggaren@apple.com
  • 10 edits in trunk/Source/JavaScriptCore

2011-01-21 Geoffrey Garen <ggaren@apple.com>

Reviewed by Maciej Stachowiak.

Cleaned up some conservative marking code.
https://bugs.webkit.org/show_bug.cgi?id=52946


SunSpider reports no change.

  • interpreter/RegisterFile.h: No need for a special marking function, since we already expose a start() and end().
  • runtime/Heap.cpp: (JSC::Heap::registerFile): (JSC::Heap::markRoots):
  • runtime/Heap.h: (JSC::Heap::contains): Migrated markConservatively() to the machine stack marker class. Now, Heap just provides a contains() function, which the machine stack marker uses for checking whether a pointer points into the heap.
  • runtime/MachineStackMarker.cpp: (JSC::MachineStackMarker::markCurrentThreadConservativelyInternal): (JSC::MachineStackMarker::markOtherThreadConservatively): (JSC::isPointerAligned): (JSC::MachineStackMarker::markConservatively):
  • runtime/MachineStackMarker.h: Move the conservative marking code here.
  • runtime/MarkStack.h: (JSC::ConservativeSet::add): (JSC::ConservativeSet::mark): Changed to using a vector instead of hash set. Vector seems to be a bit faster, and it generates smaller code.
  • runtime/MarkedSpace.cpp: (JSC::MarkedSpace::containsSlowCase):
  • runtime/MarkedSpace.h: (JSC::MarkedSpace::isCellAligned): (JSC::MarkedSpace::isPossibleCell): (JSC::MarkedSpace::contains): Kept the code for determining whether a pointer pointed into marked space, and moved the code for marking a set of conservative pointers into the machine stack marker.
  • wtf/HashSet.h: (WTF::::add): Added two missing inlines that I noticed while testing vector vs hash set.
8:00 PM Changeset in webkit [76424] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

2011-01-21 James Robinson <jamesr@chromium.org>

Update chromium test expectations. fast/animation tests should now pass on all chromium configurations.

  • platform/chromium/test_expectations.txt:
7:31 PM Changeset in webkit [76423] by mrowe@apple.com
  • 5 edits in trunk/Source

Versioning.

7:27 PM Changeset in webkit [76422] by mrowe@apple.com
  • 1 copy in tags/Safari-534.16

New tag.

7:22 PM Changeset in webkit [76421] by mitz@apple.com
  • 2 edits in trunk/LayoutTests

Fix test failure.

  • fast/text/justify-nbsp.html: Removed a contenteditable attribute

that was added after generating results.

6:51 PM Changeset in webkit [76420] by andreas.kling@nokia.com
  • 1 edit
    1 delete in trunk/LayoutTests

2011-01-21 Andreas Kling <kling@webkit.org>

Unreviewed, removing the Qt result for r76414 since the test
was actually broken beyond the usual off-by-one metrics.

  • platform/qt/fast/text/justify-nbsp-expected.txt: Removed.
6:11 PM Changeset in webkit [76419] by andreas.kling@nokia.com
  • 1 edit
    1 add in trunk/LayoutTests

2011-01-21 Andreas Kling <kling@webkit.org>

Unreviewed, add Qt-specific result for test added in r76414.

  • platform/qt/fast/text/justify-nbsp-expected.txt: Added.
6:08 PM Changeset in webkit [76418] by ap@apple.com
  • 43 edits in trunk/Source/WebKit2

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=52943
Objective-C files should use #import, not #include

  • UIProcess/API/C/WebKit2.h: This is an interesting one, because it's cross-platform, and there is more than one WKView.h.
  • Platform/mac/ModuleMac.mm:
  • Platform/mac/RunLoopMac.mm:
  • PluginProcess/mac/PluginControllerProxyMac.mm:
  • PluginProcess/mac/PluginProcessMac.mm:
  • PluginProcess/mac/PluginProcessMainMac.mm:
  • Shared/API/c/mac/WKCertificateInfoMac.mm:
  • Shared/API/c/mac/WKURLRequestNS.mm:
  • Shared/API/c/mac/WKURLResponseNS.mm:
  • Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:
  • Shared/mac/PlatformCertificateInfo.mm:
  • Shared/mac/SandboxExtensionMac.mm:
  • Shared/mac/WebCoreArgumentCodersMac.mm:
  • Shared/mac/WebMemorySampler.mac.mm:
  • Shared/mac/WebURLRequestMac.mm:
  • Shared/mac/WebURLResponseMac.mm:
  • UIProcess/API/mac/FindIndicatorWindow.mm:
  • UIProcess/API/mac/WKTextInputWindowController.mm:
  • UIProcess/Launcher/mac/ProcessLauncherMac.mm:
  • UIProcess/Launcher/mac/ThreadLauncherMac.mm:
  • UIProcess/Plugins/mac/PluginInfoStoreMac.mm:
  • UIProcess/Plugins/mac/PluginProcessProxyMac.mm:
  • UIProcess/mac/BackingStoreMac.mm:
  • UIProcess/mac/ChunkedUpdateDrawingAreaProxyMac.mm:
  • UIProcess/mac/LayerBackedDrawingAreaProxyMac.mm:
  • UIProcess/mac/TextCheckerMac.mm:
  • UIProcess/mac/WebContextMac.mm:
  • UIProcess/mac/WebContextMenuProxyMac.mm:
  • UIProcess/mac/WebPageProxyMac.mm:
  • UIProcess/mac/WebPopupMenuProxyMac.mm:
  • UIProcess/mac/WebPreferencesMac.mm:
  • WebProcess/Downloads/mac/DownloadMac.mm:
  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
  • WebProcess/Plugins/Netscape/mac/PluginProxyMac.mm:
  • WebProcess/WebCoreSupport/mac/WebContextMenuClientMac.mm:
  • WebProcess/WebCoreSupport/mac/WebDatabaseManagerMac.mm:
  • WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm:
  • WebProcess/WebCoreSupport/mac/WebErrorsMac.mm:
  • WebProcess/WebCoreSupport/mac/WebPopupMenuMac.mm:
  • WebProcess/WebPage/mac/LayerBackedDrawingAreaMac.mm:
  • WebProcess/WebPage/mac/WebPageMac.mm:
  • WebProcess/mac/WebProcessMac.mm:
5:46 PM Changeset in webkit [76417] by mrowe@apple.com
  • 9 edits in trunk/Source/WebKit2

Fix the WebKit2 build with clang.

Reviewed by Sam Weinig.

  • Scripts/webkit2/messages.py: Add some more structs to the list.
  • UIProcess/DrawingAreaProxy.h: Forward-declare UpdateInfo as a class.
  • UIProcess/TextChecker.h: Forward-declare TextCheckerState as a struct.
  • UIProcess/WebPageProxy.h: Forward-declare ContextMenuState as a struct.
  • UIProcess/mac/TextCheckerMac.mm: Fix the type of the string constants so that they can be passed to

functions expecting NSString* without generating warnings.

  • WebProcess/WebPage/DrawingArea.h: Forward-declare WebPageCreationParameters as a struct.
  • WebProcess/WebPage/DrawingAreaImpl.h: Forward-declare UpdateInfo as a class.
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::getResourceDataFromFrame): Add parens around the assignment in the condition of
the if statement to suppress a warning.

5:46 PM Changeset in webkit [76416] by mrowe@apple.com
  • 3 edits in trunk/Source/WebKit/mac

Fix the build when using Clang by removing some unused variables.

Rubber-stamped by Jon Honeycutt.

  • Plugins/Hosted/WebHostedNetscapePluginView.mm:

(-[WebHostedNetscapePluginView updateAndSetWindow]):

  • WebView/WebFullScreenController.mm:

(-[WebFullScreenController enterFullscreen:]):
(-[WebFullScreenController exitFullscreen]):

5:45 PM Changeset in webkit [76415] by andreas.kling@nokia.com
  • 4 edits in trunk/Source/WebCore

2011-01-21 Andreas Kling <kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Always set composition mode through GraphicsContext
https://bugs.webkit.org/show_bug.cgi?id=52940

GraphicsContext tracks the current composition mode so we should
never call through to the QPainter directly.

  • platform/graphics/GraphicsContext.h:
  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::toQtCompositionMode): Changed this method to a static inline since it's only used by GraphicsContextQt.cpp now.
  • platform/graphics/qt/ImageQt.cpp: (WebCore::Image::drawPattern): (WebCore::BitmapImage::draw):
5:31 PM Changeset in webkit [76414] by mitz@apple.com
  • 3 edits
    4 adds in trunk

Inconsistent handling of no-break space in justification logic
https://bugs.webkit.org/show_bug.cgi?id=52938

Reviewed by Adele Peterson.

Source/WebCore:

Test: fast/text/justify-nbsp.html

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::computeInlineDirectionPositionsForLine): Count no-break space as a
space when computing the distribution of space between text boxes on the line.

LayoutTests:

  • fast/text/justify-nbsp-expected.checksum: Added.
  • fast/text/justify-nbsp-expected.png: Added.
  • fast/text/justify-nbsp-expected.txt: Added.
  • fast/text/justify-nbsp.html: Added.
5:29 PM Changeset in webkit [76413] by dpranke@chromium.org
  • 4 edits in trunk/Tools

2011-01-21 Dirk Pranke <dpranke@chromium.org>

Reviewed by Mihai Parparita.

Fix bug introduced in r76322 that caused NRWT to not actually
read the Skipped files properly.

https://bugs.webkit.org/show_bug.cgi?id=52771

  • Scripts/webkitpy/layout_tests/port/mac_unittest.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
5:19 PM Changeset in webkit [76412] by crogers@google.com
  • 2 edits in trunk/Source/WebKit/chromium

2011-01-21 Chris Rogers <crogers@google.com>

Unreviewed

define HAS_WEBAUDIO_RUNTIMEFEATURES for synchronization with chromium patch landing
https://bugs.webkit.org/show_bug.cgi?id=52941

  • public/WebRuntimeFeatures.h:
5:07 PM Changeset in webkit [76411] by crogers@google.com
  • 2 edits in trunk/Source/WebKit/chromium

2011-01-21 Chris Rogers <crogers@google.com>

Unreviewed

Add HAS_WEBAUDIO_FEATURE_ENABLE define to synchronize with chromium-side patch
https://bugs.webkit.org/show_bug.cgi?id=52939

  • public/WebSettings.h:
4:54 PM Changeset in webkit [76410] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

2011-01-21 Kenji Imasaki <imasaki@chromium.org>

Reviewed by David Levin.

Remove resolved BUG13907 from test expectation file and added
newly filed BUGCR70252 for media/video-zoom.html to keep track
of the issue.

Also, remove non-flaky test (media/audio-only-video-intrinsic-size.htm).

  • platform/chromium/test_expectations.txt:
4:38 PM Changeset in webkit [76409] by mrowe@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Work around a Clang bug <rdar://problem/8876150> that leads to it incorrectly emitting an access
control warning when a client tries to use operator bool exposed above via "using PageBlock::operator bool".

Reviewed by Sam Weinig.

  • wtf/PageAllocation.h:

(WTF::PageAllocation::operator bool):

  • wtf/PageReservation.h:

(WTF::PageReservation::operator bool):

4:16 PM Changeset in webkit [76408] by mrobinson@webkit.org
  • 8 edits in trunk/LayoutTests

2011-01-21 Martin Robinson <mrobinson@igalia.com>

Rebaseline tests that use menulists. Also unskip a non-existent test.

  • platform/gtk/Skipped: Remove non-existent test.
  • platform/gtk/editing/selection/select-box-expected.checksum:
  • platform/gtk/editing/selection/select-box-expected.png:
  • platform/gtk/editing/selection/select-box-expected.txt:
  • platform/gtk/transforms/2d/zoom-menulist-expected.checksum:
  • platform/gtk/transforms/2d/zoom-menulist-expected.png:
  • platform/gtk/transforms/2d/zoom-menulist-expected.txt:
3:52 PM Changeset in webkit [76407] by msaboff@apple.com
  • 5 edits in trunk

2011-01-21 Michael Saboff <msaboff@apple.com>

Reviewed by Oliver Hunt.

[RegexFuzz] Hang with forward assertion
https://bugs.webkit.org/show_bug.cgi?id=52825
<rdar://problem/8894332>

The backtrackTo label from the first term in a list of terms is
being overwritten by processing of subsequent terms. Changed
copyBacktrackToLabel() to check for an existing bcaktrackTo label
before copying and renamed it to propagateBacktrackToLabel() since
it no longer copies.

  • yarr/YarrJIT.cpp: (JSC::Yarr::YarrGenerator::BacktrackDestination::propagateBacktrackToLabel): (JSC::Yarr::YarrGenerator::generateParenthesesSingle):

2011-01-21 Michael Saboff <msaboff@apple.com>

Reviewed by Oliver Hunt.

[RegexFuzz] Hang with forward assertion
https://bugs.webkit.org/show_bug.cgi?id=52825
<rdar://problem/8894332>

New tests to check for functionality and future regression.

  • fast/regex/parentheses-expected.txt:
  • fast/regex/script-tests/parentheses.js:
3:47 PM Changeset in webkit [76406] by commit-queue@webkit.org
  • 4 edits in trunk/Source

2011-01-21 Charlie Reis <creis@chromium.org>

Reviewed by Darin Fisher.

Crash in WebCore::HistoryController::itemsAreClones
https://bugs.webkit.org/show_bug.cgi?id=52819

Adds sanity checks to help diagnose the crash.

  • loader/HistoryController.cpp:

2011-01-21 Charlie Reis <creis@chromium.org>

Reviewed by Darin Fisher.

Crash in WebCore::HistoryController::itemsAreClones
https://bugs.webkit.org/show_bug.cgi?id=52819

Adds sanity checks to help diagnose the crash.

  • src/WebFrameImpl.cpp:
3:45 PM Changeset in webkit [76405] by andreas.kling@nokia.com
  • 3 edits in trunk/Source/WebCore

2011-01-21 Andreas Kling <kling@webkit.org>

Reviewed by Ariya Hidayat.

[Qt] Let QPainter decide whether a composition mode is supported or not

Lacking Porter-Duff support in the paint engine shouldn't exclude the
Source and Source-Over modes (and has nothing to do with the blend
and raster-op modes.)

Delegate this decision to QPainter instead (this will cause warnings
if an unsupported mode is used, but that's a good thing.)

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::clearRect): (WebCore::GraphicsContext::setPlatformCompositeOperation):
  • platform/graphics/qt/TransparencyLayer.h: (WebCore::TransparencyLayer::TransparencyLayer):
3:43 PM Changeset in webkit [76404] by mjs@apple.com
  • 2 edits in trunk/LayoutTests

2011-01-21 Maciej Stachowiak <mjs@apple.com>

Reviewed by Adele Peterson.

Skip a test that's sporadically crashing on the buildbots
https://bugs.webkit.org/show_bug.cgi?id=52932

  • platform/mac-wk2/Skipped:
3:42 PM Changeset in webkit [76403] by bweinstein@apple.com
  • 8 edits in trunk/Source/WebKit2

WebKit2: Need API to stop loading a WKFrame
https://bugs.webkit.org/show_bug.cgi?id=52925

Reviewed by Adam Roben.

  • UIProcess/API/C/WKFrame.cpp:

(WKFrameStopLoading): Call through to WebFrameProxy::stopLoading.

  • UIProcess/API/C/WKFrame.h:
  • UIProcess/WebFrameProxy.cpp:

(WebKit::WebFrameProxy::stopLoading): Send a message to the WebProcess to stop loading the frame

with the passed in ID.

  • UIProcess/WebFrameProxy.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::stopLoadingFrame): Call stopForUserCancel on the passed-in frame.

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in: Add StopLoadingFrame.
3:41 PM Changeset in webkit [76402] by crogers@google.com
  • 2 edits in trunk/Source/WebCore

2011-01-21 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

fix audio build: header file should be "Noncopyable.h" and not "NonCopyable.h"
https://bugs.webkit.org/show_bug.cgi?id=52933

No new tests since this just fixes the build

  • webaudio/RealtimeAnalyser.h:
3:32 PM Changeset in webkit [76401] by weinig@apple.com
  • 2 edits in trunk/Tools

WebKitTestRunner needs the HOME environment variable to be set.
<rdar://problem/8896573>

Reviewed by Geoffrey Sean Garen and Mark Rowe.

  • Scripts/old-run-webkit-tests: Set the HOME environment variable if

it exists.

3:28 PM Changeset in webkit [76400] by crogers@google.com
  • 2 edits in trunk/Source/WebCore

2011-01-21 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

Fix audio build: change ChromiumBridge to PlatformBridge
https://bugs.webkit.org/show_bug.cgi?id=52928

No new tests since audio API is not yet implemented.

  • platform/audio/chromium/AudioBusChromium.cpp: (WebCore::AudioBus::loadPlatformResource):
3:24 PM Changeset in webkit [76399] by ggaren@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

2011-01-21 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Moved the mark stack from global data to the heap, since it pertains
to the heap, and not the virtual machine as a whole.
https://bugs.webkit.org/show_bug.cgi?id=52930


SunSpider reports no change.

  • runtime/Heap.cpp: (JSC::Heap::Heap): (JSC::Heap::markRoots):
  • runtime/Heap.h:
  • runtime/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData):
  • runtime/JSGlobalData.h:
3:23 PM Changeset in webkit [76398] by dpranke@chromium.org
  • 4 edits in trunk/Tools

2011-01-21 Dirk Pranke <dpranke@chromium.org>

Reviewed by Eric Seidel.

Suppress a few remaining integration tests so that none of the
layout_test unit tests ever read from the filesystem or launch
subprocesses that aren't part of the unit tests.

Also fix a minor bug in the printing unit tests that was
incorrectly relying on sys.argv.

https://bugs.webkit.org/show_bug.cgi?id=52863

  • Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
  • Scripts/webkitpy/layout_tests/port/port_testcase.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3:06 PM Changeset in webkit [76397] by crogers@google.com
  • 2 edits
    1 add in trunk/Source/WebCore

2011-01-21 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

Add FFTFrameStub to avoid link errors during bringup on platforms without an FFT implementation
https://bugs.webkit.org/show_bug.cgi?id=52922

No new tests since audio API is not yet implemented.

  • WebCore.gypi:
  • platform/audio/FFTFrameStub.cpp: Added. (WebCore::FFTFrame::FFTFrame): (WebCore::FFTFrame::~FFTFrame): (WebCore::FFTFrame::multiply): (WebCore::FFTFrame::doFFT): (WebCore::FFTFrame::doInverseFFT): (WebCore::FFTFrame::cleanup): (WebCore::FFTFrame::realData): (WebCore::FFTFrame::imagData):
3:01 PM UsingGitWithWebKit edited by mrobinson@webkit.org
Added information about proper svn:mime-type configuration (diff)
2:52 PM Changeset in webkit [76396] by mjs@apple.com
  • 2 edits in trunk/LayoutTests

2011-01-21 Maciej Stachowiak <mjs@apple.com>

Reviewed by Adam Roben.

Skip some newly added tests that use DRT APIs that are not yet available for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=52924

  • platform/mac-wk2/Skipped:
2:32 PM Changeset in webkit [76395] by tony@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-01-21 Tony Chang <tony@chromium.org>

Reviewed by Sam Weinig.

reduce number of FrameLoaderClient::didChangeScrollOffset calls
https://bugs.webkit.org/show_bug.cgi?id=52915

Only notify of changes in scroll offset when there actually is a change.
This regressed in r76291.

Covered by Chromium browser_tests.

  • platform/ScrollAnimator.cpp: (WebCore::ScrollAnimator::scrollToOffsetWithoutAnimation):
2:12 PM Changeset in webkit [76394] by beidson@apple.com
  • 5 edits in trunk/Source/WebKit2

<rdar://problem/8894125> and https://bugs.webkit.org/show_bug.cgi?id=52916
Expose "suggested filename" for a resource based on its resource response.

Reviewed by Adam Roben.

API pieces:

  • WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:

(WKBundleFrameCopySuggestedFilenameForResourceURL):

  • WebProcess/InjectedBundle/API/c/WKBundleFrame.h:


Implementation:

  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::suggestedFilenameForResourceURL): See if the DocumentLoader has

a resource for this URL and, if so, return the response's suggested filename.

  • WebProcess/WebPage/WebFrame.h:
2:09 PM Changeset in webkit [76393] by andersca@apple.com
  • 5 edits in trunk/Source/WebKit2

2011-01-21 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

DrawingAreaProxyImpl::paint should return the unpainted region
https://bugs.webkit.org/show_bug.cgi?id=52918

  • UIProcess/API/mac/WKView.mm: (-[WKView drawRect:]): Add unpaintedRegion parameter.
  • UIProcess/BackingStore.h: (WebKit::BackingStore::size): Add a size getter.
  • UIProcess/DrawingAreaProxyImpl.cpp: (WebKit::DrawingAreaProxyImpl::paint): Initialize the unpainted region to the dirty region, then subtract the painted region.
2:00 PM Changeset in webkit [76392] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-01-21 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: ~InspectorResourceAgent crashes on closing inspected page.
https://bugs.webkit.org/show_bug.cgi?id=52900

  • inspector/InspectorController.cpp: (WebCore::InspectorController::~InspectorController): (WebCore::InspectorController::inspectedPageDestroyed):
1:58 PM Changeset in webkit [76391] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix for <rdar://problem/8896057>

Reviewed by Dan Bernstein and Maciej Stachowiak.

Give the Web Process access to the PubSub agent.

  • WebProcess/com.apple.WebProcess.sb:
1:43 PM Changeset in webkit [76390] by crogers@google.com
  • 21 edits in trunk/Source

2011-01-21 Chris Rogers <crogers@google.com>

Reviewed by Darin Fisher.

Add run-time enable support for the web audio API
https://bugs.webkit.org/show_bug.cgi?id=52741

  • public/WebRuntimeFeatures.h:
  • public/WebSettings.h:
  • src/WebRuntimeFeatures.cpp: (WebKit::WebRuntimeFeatures::enableWebAudio): (WebKit::WebRuntimeFeatures::isWebAudioEnabled):
  • src/WebSettingsImpl.cpp: (WebKit::WebSettingsImpl::setWebAudioEnabled):
  • src/WebSettingsImpl.h:

2011-01-21 Chris Rogers <crogers@google.com>

Reviewed by Darin Fisher.

Add run-time enable support for the web audio API
https://bugs.webkit.org/show_bug.cgi?id=52741

  • WebPreferenceKeysPrivate.h:
  • WebView.cpp: (WebView::notifyPreferencesChanged):

2011-01-21 Chris Rogers <crogers@google.com>

Reviewed by Darin Fisher.

Add run-time enable support for the web audio API
https://bugs.webkit.org/show_bug.cgi?id=52741

  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm: (-[WebPreferences webAudioEnabled]): (-[WebPreferences setWebAudioEnabled:]):
  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]):

2011-01-21 Chris Rogers <crogers@google.com>

Reviewed by Darin Fisher.

Add run-time enable support for the web audio API
https://bugs.webkit.org/show_bug.cgi?id=52741

No new tests since audio API is not yet implemented.

  • WebCore.exp.in:
  • bindings/generic/RuntimeEnabledFeatures.cpp:
  • bindings/generic/RuntimeEnabledFeatures.h: (WebCore::RuntimeEnabledFeatures::setWebkitAudioContextEnabled): (WebCore::RuntimeEnabledFeatures::webkitAudioContextEnabled):
  • page/DOMWindow.idl:
  • page/Settings.cpp: (WebCore::Settings::Settings): (WebCore::Settings::setWebAudioEnabled):
  • page/Settings.h: (WebCore::Settings::webAudioEnabled):
1:33 PM Changeset in webkit [76389] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit/win

Fix windows build.

  • WebScrollBar.h:
1:33 PM Changeset in webkit [76388] by mrobinson@webkit.org
  • 114 edits
    2 adds in trunk

2011-01-21 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Menulist text often collides with separator
https://bugs.webkit.org/show_bug.cgi?id=51155

Rebaseline tests that have different affected by the metrics of
the menulist.

  • platform/gtk/fast/forms/001-expected.checksum:
  • platform/gtk/fast/forms/001-expected.png:
  • platform/gtk/fast/forms/001-expected.txt:
  • platform/gtk/fast/forms/003-expected.checksum:
  • platform/gtk/fast/forms/003-expected.png:
  • platform/gtk/fast/forms/003-expected.txt:
  • platform/gtk/fast/forms/004-expected.checksum:
  • platform/gtk/fast/forms/004-expected.png:
  • platform/gtk/fast/forms/004-expected.txt:
  • platform/gtk/fast/forms/HTMLOptionElement_label01-expected.checksum:
  • platform/gtk/fast/forms/HTMLOptionElement_label01-expected.png:
  • platform/gtk/fast/forms/HTMLOptionElement_label01-expected.txt:
  • platform/gtk/fast/forms/HTMLOptionElement_label02-expected.checksum:
  • platform/gtk/fast/forms/HTMLOptionElement_label02-expected.png:
  • platform/gtk/fast/forms/HTMLOptionElement_label02-expected.txt:
  • platform/gtk/fast/forms/HTMLOptionElement_label03-expected.checksum:
  • platform/gtk/fast/forms/HTMLOptionElement_label03-expected.png:
  • platform/gtk/fast/forms/HTMLOptionElement_label03-expected.txt:
  • platform/gtk/fast/forms/HTMLOptionElement_label04-expected.checksum:
  • platform/gtk/fast/forms/HTMLOptionElement_label04-expected.png:
  • platform/gtk/fast/forms/HTMLOptionElement_label04-expected.txt:
  • platform/gtk/fast/forms/HTMLOptionElement_label06-expected.checksum:
  • platform/gtk/fast/forms/HTMLOptionElement_label06-expected.png:
  • platform/gtk/fast/forms/HTMLOptionElement_label06-expected.txt:
  • platform/gtk/fast/forms/HTMLOptionElement_label07-expected.checksum:
  • platform/gtk/fast/forms/HTMLOptionElement_label07-expected.png:
  • platform/gtk/fast/forms/HTMLOptionElement_label07-expected.txt:
  • platform/gtk/fast/forms/control-clip-overflow-expected.checksum:
  • platform/gtk/fast/forms/control-clip-overflow-expected.png:
  • platform/gtk/fast/forms/control-clip-overflow-expected.txt:
  • platform/gtk/fast/forms/control-restrict-line-height-expected.checksum:
  • platform/gtk/fast/forms/control-restrict-line-height-expected.png:
  • platform/gtk/fast/forms/control-restrict-line-height-expected.txt:
  • platform/gtk/fast/forms/disabled-select-change-index-expected.checksum:
  • platform/gtk/fast/forms/disabled-select-change-index-expected.png:
  • platform/gtk/fast/forms/disabled-select-change-index-expected.txt:
  • platform/gtk/fast/forms/form-element-geometry-expected.checksum:
  • platform/gtk/fast/forms/form-element-geometry-expected.png:
  • platform/gtk/fast/forms/form-element-geometry-expected.txt:
  • platform/gtk/fast/forms/input-file-re-render-expected.checksum: Added.
  • platform/gtk/fast/forms/input-file-re-render-expected.png: Added.
  • platform/gtk/fast/forms/menulist-deselect-update-expected.checksum:
  • platform/gtk/fast/forms/menulist-deselect-update-expected.png:
  • platform/gtk/fast/forms/menulist-deselect-update-expected.txt:
  • platform/gtk/fast/forms/menulist-narrow-width-expected.checksum:
  • platform/gtk/fast/forms/menulist-narrow-width-expected.png:
  • platform/gtk/fast/forms/menulist-narrow-width-expected.txt:
  • platform/gtk/fast/forms/menulist-no-overflow-expected.checksum:
  • platform/gtk/fast/forms/menulist-no-overflow-expected.png:
  • platform/gtk/fast/forms/menulist-no-overflow-expected.txt:
  • platform/gtk/fast/forms/menulist-restrict-line-height-expected.checksum:
  • platform/gtk/fast/forms/menulist-restrict-line-height-expected.png:
  • platform/gtk/fast/forms/menulist-restrict-line-height-expected.txt:
  • platform/gtk/fast/forms/menulist-separator-painting-expected.checksum:
  • platform/gtk/fast/forms/menulist-separator-painting-expected.png:
  • platform/gtk/fast/forms/menulist-separator-painting-expected.txt:
  • platform/gtk/fast/forms/menulist-style-color-expected.checksum:
  • platform/gtk/fast/forms/menulist-style-color-expected.png:
  • platform/gtk/fast/forms/menulist-style-color-expected.txt:
  • platform/gtk/fast/forms/menulist-width-change-expected.checksum:
  • platform/gtk/fast/forms/menulist-width-change-expected.png:
  • platform/gtk/fast/forms/menulist-width-change-expected.txt:
  • platform/gtk/fast/forms/option-script-expected.checksum:
  • platform/gtk/fast/forms/option-script-expected.png:
  • platform/gtk/fast/forms/option-script-expected.txt:
  • platform/gtk/fast/forms/option-strip-whitespace-expected.checksum:
  • platform/gtk/fast/forms/option-strip-whitespace-expected.png:
  • platform/gtk/fast/forms/option-strip-whitespace-expected.txt:
  • platform/gtk/fast/forms/option-text-clip-expected.checksum:
  • platform/gtk/fast/forms/option-text-clip-expected.png:
  • platform/gtk/fast/forms/option-text-clip-expected.txt:
  • platform/gtk/fast/forms/select-align-expected.checksum:
  • platform/gtk/fast/forms/select-align-expected.png:
  • platform/gtk/fast/forms/select-align-expected.txt:
  • platform/gtk/fast/forms/select-baseline-expected.checksum:
  • platform/gtk/fast/forms/select-baseline-expected.png:
  • platform/gtk/fast/forms/select-baseline-expected.txt:
  • platform/gtk/fast/forms/select-change-listbox-to-popup-expected.checksum:
  • platform/gtk/fast/forms/select-change-listbox-to-popup-expected.png:
  • platform/gtk/fast/forms/select-change-listbox-to-popup-expected.txt:
  • platform/gtk/fast/forms/select-dirty-parent-pref-widths-expected.checksum:
  • platform/gtk/fast/forms/select-dirty-parent-pref-widths-expected.png:
  • platform/gtk/fast/forms/select-dirty-parent-pref-widths-expected.txt:
  • platform/gtk/fast/forms/select-disabled-appearance-expected.checksum:
  • platform/gtk/fast/forms/select-disabled-appearance-expected.png:
  • platform/gtk/fast/forms/select-disabled-appearance-expected.txt:
  • platform/gtk/fast/forms/select-initial-position-expected.checksum:
  • platform/gtk/fast/forms/select-initial-position-expected.png:
  • platform/gtk/fast/forms/select-initial-position-expected.txt:
  • platform/gtk/fast/forms/select-selected-expected.checksum:
  • platform/gtk/fast/forms/select-selected-expected.png:
  • platform/gtk/fast/forms/select-selected-expected.txt:
  • platform/gtk/fast/forms/select-size-expected.checksum:
  • platform/gtk/fast/forms/select-size-expected.png:
  • platform/gtk/fast/forms/select-size-expected.txt:
  • platform/gtk/fast/forms/select-style-expected.checksum:
  • platform/gtk/fast/forms/select-style-expected.png:
  • platform/gtk/fast/forms/select-style-expected.txt:
  • platform/gtk/fast/forms/select-visual-hebrew-expected.checksum:
  • platform/gtk/fast/forms/select-visual-hebrew-expected.png:
  • platform/gtk/fast/forms/select-visual-hebrew-expected.txt:
  • platform/gtk/fast/forms/select-writing-direction-natural-expected.checksum:
  • platform/gtk/fast/forms/select-writing-direction-natural-expected.png:
  • platform/gtk/fast/forms/select-writing-direction-natural-expected.txt:
  • platform/gtk/fast/forms/stuff-on-my-optgroup-expected.checksum:
  • platform/gtk/fast/forms/stuff-on-my-optgroup-expected.png:
  • platform/gtk/fast/forms/stuff-on-my-optgroup-expected.txt:

2011-01-21 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Menulist text often collides with separator
https://bugs.webkit.org/show_bug.cgi?id=51155

Move menulist rendering to RenderThemeGtk and correct padding code
for separators in menulists.

  • platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::RenderThemeGtk): Initialize new widget members. (WebCore::RenderThemeGtk::getComboBoxSeparatorWidth): Added. (WebCore::RenderThemeGtk::comboBoxArrowSize): Added. (WebCore::getButtonInnerBorder): Added. (WebCore::RenderThemeGtk::getComboBoxPadding): Do this manually instead of using Mozilla code. (WebCore::RenderThemeGtk::paintMenuList): Ditto. (WebCore::setupWidget): Abstracted this part of the setupWidgetAndAddToContainer out to handle child widgets of comboboxes. (WebCore::RenderThemeGtk::setupWidgetAndAddToContainer): Abstracted out setupWidget. (WebCore::RenderThemeGtk::gtkContainer): Added. (WebCore::getGtkComboBoxButton): Added. (WebCore::getGtkComboBoxPieces): Added. (WebCore::RenderThemeGtk::gtkComboBox): Call setupWidget here. (WebCore::RenderThemeGtk::refreshComboBoxChildren): Added. (WebCore::RenderThemeGtk::gtkComboBoxButton): Added. (WebCore::RenderThemeGtk::gtkComboBoxArrow): Added. (WebCore::RenderThemeGtk::gtkComboBoxSeparator): Added.
  • platform/gtk/RenderThemeGtk.h: Added new members and methods.
  • platform/gtk/WidgetRenderingContext.h: Added new members and methods.
  • platform/gtk/WidgetRenderingContextGtk2.cpp: (WebCore::WidgetRenderingContext::gtkPaintArrow): (WebCore::WidgetRenderingContext::gtkPaintVLine):
  • platform/gtk/WidgetRenderingContextGtk3.cpp: (WebCore::WidgetRenderingContext::gtkPaintArrow): (WebCore::WidgetRenderingContext::gtkPaintVLine):
  • platform/gtk/gtk2drawing.c: Removed code for drawing menulists and buttons. (moz_gtk_init): (moz_gtk_get_widget_border): (moz_gtk_widget_paint):
  • platform/gtk/gtk3drawing.c: (moz_gtk_init): (moz_gtk_get_widget_border): (moz_gtk_widget_paint):
  • platform/gtk/gtkdrawing.h:
1:17 PM Changeset in webkit [76387] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

Fix chromium mac build.

  • platform/chromium/ScrollbarThemeChromiumMac.mm:

(WebCore::scrollbarStateToThemeState):
(WebCore::ScrollbarThemeChromiumMac::paint):

1:10 PM Changeset in webkit [76386] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed trivial fix.

FrameLoader::checkLoadCompleteForThisFrame uses wrong history item
https://bugs.webkit.org/show_bug.cgi?id=48812

  • platform/qt/http/tests/navigation/forward-and-cancel-expected.txt: Updated after r76357.
1:08 PM Changeset in webkit [76385] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

Fix the windows build.

  • platform/ScrollbarThemeComposite.cpp:

(WebCore::ScrollbarThemeComposite::paint):

1:02 PM Changeset in webkit [76384] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

Skip transitions/transition-end-event-destroy-iframe.html on Windows in order to get the
Windows 7 Release bots green. Unreviewed.
https://bugs.webkit.org/show_bug.cgi?id=52913

  • platform/win/Skipped:
12:54 PM Changeset in webkit [76383] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-01-21 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed; another Chromium build fix attempt for r76378.

  • src/WebScrollbarImpl.cpp: (WebKit::WebScrollbar::create): (WebKit::WebScrollbarImpl::WebScrollbarImpl): (WebKit::WebScrollbarImpl::setValue):
12:42 PM Changeset in webkit [76382] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-01-21 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed Chromium build fix attempt for r76378.

  • src/WebScrollbarImpl.cpp: (WebKit::WebScrollbar::create): (WebKit::WebScrollbarImpl::WebScrollbarImpl):
12:34 PM Changeset in webkit [76381] by mjs@apple.com
  • 2 edits in trunk/LayoutTests

2011-01-21 Maciej Stachowiak <mjs@apple.com>

Reviewed by Sam Weinig.

Skip another test that is failing sporadically on the buildbots
https://bugs.webkit.org/show_bug.cgi?id=52908

  • platform/mac-wk2/Skipped:
12:29 PM Changeset in webkit [76380] by crogers@google.com
  • 5 edits in trunk/Source

2011-01-21 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

Add chromium bundled audio spatialization resources to WebAudio.grd
https://bugs.webkit.org/show_bug.cgi?id=52651

  • WebKit.grd:

2011-01-21 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

Add chromium bundled audio spatialization resources to WebAudio.grd
https://bugs.webkit.org/show_bug.cgi?id=52651

No new tests since audio API is not yet implemented.

  • WebCore.gyp/WebCore.gyp:
  • platform/audio/chromium/AudioBusChromium.cpp: (WebCore::AudioBus::loadPlatformResource):
12:26 PM Changeset in webkit [76379] by commit-queue@webkit.org
  • 80 edits in trunk

2011-01-21 Xiyuan Xia <xiyuan@chromium.org>

Reviewed by Tony Chang.

Update chromium/linux baselines after drawing code moved into
WebThemeEngine.
https://bugs.webkit.org/show_bug.cgi?id=52826

  • platform/chromium-linux/css1/box_properties/acid_test-expected.checksum:
  • platform/chromium-linux/css1/box_properties/acid_test-expected.png:
  • platform/chromium-linux/css2.1/t09-c5526c-display-00-e-expected.checksum:
  • platform/chromium-linux/css2.1/t09-c5526c-display-00-e-expected.png:
  • platform/chromium-linux/fast/block/basic/011-expected.checksum:
  • platform/chromium-linux/fast/block/basic/011-expected.png:
  • platform/chromium-linux/fast/block/margin-collapse/103-expected.checksum:
  • platform/chromium-linux/fast/block/margin-collapse/103-expected.png:
  • platform/chromium-linux/fast/css/non-standard-checkbox-size-expected.checksum:
  • platform/chromium-linux/fast/css/non-standard-checkbox-size-expected.png:
  • platform/chromium-linux/fast/dom/HTMLProgressElement/progress-element-expected.checksum:
  • platform/chromium-linux/fast/dom/HTMLProgressElement/progress-element-expected.png:
  • platform/chromium-linux/fast/forms/basic-inputs-expected.checksum:
  • platform/chromium-linux/fast/forms/basic-inputs-expected.png:
  • platform/chromium-linux/fast/forms/basic-selects-expected.checksum:
  • platform/chromium-linux/fast/forms/basic-selects-expected.png:
  • platform/chromium-linux/fast/forms/box-shadow-override-expected.checksum:
  • platform/chromium-linux/fast/forms/box-shadow-override-expected.png:
  • platform/chromium-linux/fast/forms/checkbox-radio-onchange-expected.checksum:
  • platform/chromium-linux/fast/forms/checkbox-radio-onchange-expected.png:
  • platform/chromium-linux/fast/forms/file-input-disabled-expected.checksum:
  • platform/chromium-linux/fast/forms/file-input-disabled-expected.png:
  • platform/chromium-linux/fast/forms/form-element-geometry-expected.checksum:
  • platform/chromium-linux/fast/forms/form-element-geometry-expected.png:
  • platform/chromium-linux/fast/forms/formmove-expected.checksum:
  • platform/chromium-linux/fast/forms/formmove-expected.png:
  • platform/chromium-linux/fast/forms/formmove2-expected.checksum:
  • platform/chromium-linux/fast/forms/formmove2-expected.png:
  • platform/chromium-linux/fast/forms/indeterminate-expected.checksum:
  • platform/chromium-linux/fast/forms/indeterminate-expected.png:
  • platform/chromium-linux/fast/forms/input-appearance-height-expected.checksum:
  • platform/chromium-linux/fast/forms/input-appearance-height-expected.png:
  • platform/chromium-linux/fast/forms/input-value-expected.checksum:
  • platform/chromium-linux/fast/forms/input-value-expected.png:
  • platform/chromium-linux/fast/forms/menulist-restrict-line-height-expected.checksum:
  • platform/chromium-linux/fast/forms/menulist-restrict-line-height-expected.png:
  • platform/chromium-linux/fast/forms/menulist-style-color-expected.checksum:
  • platform/chromium-linux/fast/forms/menulist-style-color-expected.png:
  • platform/chromium-linux/fast/forms/placeholder-position-expected.checksum:
  • platform/chromium-linux/fast/forms/placeholder-position-expected.png: Added property svn:mime-type.
  • platform/chromium-linux/fast/forms/radio-attr-order-expected.checksum:
  • platform/chromium-linux/fast/forms/radio-attr-order-expected.png:
  • platform/chromium-linux/fast/forms/radio-nested-labels-expected.checksum:
  • platform/chromium-linux/fast/forms/radio-nested-labels-expected.png:
  • platform/chromium-linux/fast/forms/radio_checked-expected.checksum:
  • platform/chromium-linux/fast/forms/radio_checked-expected.png:
  • platform/chromium-linux/fast/forms/radio_checked_dynamic-expected.checksum:
  • platform/chromium-linux/fast/forms/radio_checked_dynamic-expected.png:
  • platform/chromium-linux/fast/forms/select-baseline-expected.checksum:
  • platform/chromium-linux/fast/forms/select-baseline-expected.png:
  • platform/chromium-linux/fast/inline/positionedLifetime-expected.checksum:
  • platform/chromium-linux/fast/inline/positionedLifetime-expected.png:
  • platform/chromium-linux/fast/parser/bad-xml-slash-expected.checksum:
  • platform/chromium-linux/fast/parser/bad-xml-slash-expected.png:
  • platform/chromium-linux/fast/replaced/replaced-breaking-expected.checksum:
  • platform/chromium-linux/fast/replaced/replaced-breaking-expected.png:
  • platform/chromium-linux/fast/replaced/width100percent-checkbox-expected.checksum:
  • platform/chromium-linux/fast/replaced/width100percent-checkbox-expected.png:
  • platform/chromium-linux/fast/text/textIteratorNilRenderer-expected.checksum:
  • platform/chromium-linux/fast/text/textIteratorNilRenderer-expected.png:
  • platform/chromium-linux/fast/text/whitespace/normal-after-nowrap-breaking-expected.checksum:
  • platform/chromium-linux/fast/text/whitespace/normal-after-nowrap-breaking-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug1318-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug1318-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug4527-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug4527-expected.png: Added property svn:mime-type.
  • platform/chromium-linux/tables/mozilla_expected_failures/core/captions1-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/core/captions1-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/core/captions2-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/core/captions2-expected.png:

2011-01-21 Xiyuan Xia <xiyuan@chromium.org>

Reviewed by Tony Chang.

Use WebThemeEngine for relevant RenderTheme parts for chromium/linux.
https://bugs.webkit.org/show_bug.cgi?id=52826

  • platform/chromium/ChromiumBridge.h:
  • rendering/RenderThemeChromiumLinux.cpp: (WebCore::getWebThemeState): (WebCore::RenderThemeChromiumLinux::adjustSliderThumbSize): (WebCore::RenderThemeChromiumLinux::paintCheckbox): (WebCore::RenderThemeChromiumLinux::setCheckboxSize): (WebCore::RenderThemeChromiumLinux::paintRadio): (WebCore::RenderThemeChromiumLinux::setRadioSize): (WebCore::RenderThemeChromiumLinux::paintButton): (WebCore::RenderThemeChromiumLinux::paintTextField): (WebCore::RenderThemeChromiumLinux::paintMenuList): (WebCore::RenderThemeChromiumLinux::paintSliderTrack): (WebCore::RenderThemeChromiumLinux::paintSliderThumb): (WebCore::RenderThemeChromiumLinux::adjustInnerSpinButtonStyle): (WebCore::RenderThemeChromiumLinux::paintInnerSpinButton): (WebCore::RenderThemeChromiumLinux::paintProgressBar):
  • rendering/RenderThemeChromiumLinux.h:
  • rendering/RenderThemeChromiumSkia.cpp: (WebCore::RenderThemeChromiumSkia::setCheckboxSize): (WebCore::RenderThemeChromiumSkia::setSizeIfAuto): (WebCore::RenderThemeChromiumSkia::indeterminateProgressValueRectFor):
  • rendering/RenderThemeChromiumSkia.h:

2011-01-21 Xiyuan Xia <xiyuan@chromium.org>

Reviewed by Tony Chang.

Use WebThemeEngine for relevant RenderTheme parts for chromium/linux.
https://bugs.webkit.org/show_bug.cgi?id=52826

  • WebKit.gyp:
  • src/ChromiumBridge.cpp: (WebCore::WebThemePart): (WebCore::GetWebThemeExtraParams):
12:15 PM Changeset in webkit [76378] by weinig@apple.com
  • 59 edits
    2 moves in trunk/Source

Part 2 of "Cleanup Scrollbar/ScrollbarClient relationship"
https://bugs.webkit.org/show_bug.cgi?id=52779

Reviewed by Anders Carlsson.

Rename ScrollbarClient -> ScrollableArea.

Source/WebCore:

  • Also replaces Scrollbar::setClient with Scrollbar::disconnectFromScrollableArea since that was its only use case.
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • accessibility/AccessibilityScrollbar.cpp:

(WebCore::AccessibilityScrollbar::setValue):

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):

  • page/FrameView.h:
  • platform/PopupMenuClient.h:
  • platform/ScrollAnimator.cpp:

(WebCore::ScrollAnimator::create):
(WebCore::ScrollAnimator::ScrollAnimator):
(WebCore::ScrollAnimator::scroll):
(WebCore::ScrollAnimator::notityPositionChanged):

  • platform/ScrollAnimator.h:
  • platform/ScrollAnimatorWin.cpp:

(WebCore::ScrollAnimator::create):
(WebCore::ScrollAnimatorWin::ScrollAnimatorWin):
(WebCore::ScrollAnimatorWin::scroll):

  • platform/ScrollAnimatorWin.h:
  • platform/ScrollView.cpp:

(WebCore::ScrollView::scroll):
(WebCore::ScrollView::updateScrollbars):
(WebCore::ScrollView::wheelEvent):

  • platform/ScrollView.h:
  • platform/ScrollableArea.cpp: Copied from WebCore/platform/ScrollbarClient.cpp.

(WebCore::ScrollableArea::ScrollableArea):
(WebCore::ScrollableArea::~ScrollableArea):
(WebCore::ScrollableArea::scroll):
(WebCore::ScrollableArea::scrollToOffsetWithoutAnimation):
(WebCore::ScrollableArea::scrollToXOffsetWithoutAnimation):
(WebCore::ScrollableArea::scrollToYOffsetWithoutAnimation):
(WebCore::ScrollableArea::setScrollOffsetFromAnimation):

  • platform/ScrollableArea.h: Copied from WebCore/platform/ScrollbarClient.h.
  • platform/Scrollbar.cpp:

(WebCore::Scrollbar::createNativeScrollbar):
(WebCore::Scrollbar::Scrollbar):
(WebCore::Scrollbar::offsetDidChange):
(WebCore::Scrollbar::autoscrollPressedPart):
(WebCore::Scrollbar::moveThumb):
(WebCore::Scrollbar::mouseMoved):
(WebCore::Scrollbar::isWindowActive):
(WebCore::Scrollbar::invalidateRect):
(WebCore::Scrollbar::convertToContainingView):
(WebCore::Scrollbar::convertFromContainingView):

  • platform/Scrollbar.h:

(WebCore::Scrollbar::disconnectFromScrollableArea):
(WebCore::Scrollbar::scrollableArea):

  • platform/ScrollbarClient.cpp: Removed.
  • platform/ScrollbarClient.h: Removed.
  • platform/ScrollbarThemeComposite.cpp:
  • platform/chromium/FramelessScrollView.h:
  • platform/chromium/ScrollbarThemeChromium.cpp:

(WebCore::ScrollbarThemeChromium::paintTickmarks):

  • platform/efl/ScrollbarEfl.cpp:

(Scrollbar::createNativeScrollbar):
(ScrollbarEfl::ScrollbarEfl):
(scrollbarEflEdjeMessage):

  • platform/efl/ScrollbarEfl.h:
  • platform/gtk/MainFrameScrollbarGtk.cpp:

(MainFrameScrollbarGtk::create):
(MainFrameScrollbarGtk::MainFrameScrollbarGtk):
(MainFrameScrollbarGtk::gtkValueChanged):

  • platform/gtk/MainFrameScrollbarGtk.h:
  • platform/mac/ScrollAnimatorMac.h:
  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimator::create):
(WebCore::ScrollAnimatorMac::ScrollAnimatorMac):
(WebCore::ScrollAnimatorMac::scroll):

  • platform/mac/ScrollbarThemeMac.mm:

(WebCore::ScrollbarThemeMac::paint):

  • platform/qt/ScrollbarQt.cpp:

(WebCore::Scrollbar::contextMenu):

  • platform/win/PopupMenuWin.cpp:

(WebCore::PopupMenuWin::scrollToRevealSelection):
(WebCore::PopupMenuWin::wndProc):

  • platform/win/PopupMenuWin.h:
  • platform/win/ScrollbarThemeSafari.cpp:

(WebCore::ScrollbarThemeSafari::paintTrackBackground):
(WebCore::ScrollbarThemeSafari::paintButton):
(WebCore::ScrollbarThemeSafari::paintThumb):

  • platform/wx/ScrollbarThemeWx.cpp:

(WebCore::ScrollbarThemeWx::paint):

  • rendering/RenderDataGrid.h:
  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::scrollToOffset):
(WebCore::RenderLayer::destroyScrollbar):
(WebCore::RenderLayer::scroll):

  • rendering/RenderLayer.h:
  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::scrollToRevealElementAtListIndex):
(WebCore::RenderListBox::scroll):
(WebCore::RenderListBox::logicalScroll):
(WebCore::RenderListBox::setScrollTop):
(WebCore::RenderListBox::destroyScrollbar):

  • rendering/RenderListBox.h:
  • rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::createScrollbar):

  • rendering/RenderMenuList.h:
  • rendering/RenderScrollbar.cpp:

(WebCore::RenderScrollbar::createCustomScrollbar):
(WebCore::RenderScrollbar::RenderScrollbar):

  • rendering/RenderScrollbar.h:
  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::createScrollbar):

  • rendering/RenderTextControlSingleLine.h:

Source/WebKit/chromium:

  • src/AutoFillPopupMenuClient.cpp:

(WebKit::AutoFillPopupMenuClient::createScrollbar):

  • src/AutoFillPopupMenuClient.h:
  • src/WebScrollbarImpl.cpp:

(WebKit::WebScrollbarImpl::WebScrollbarImpl):
(WebKit::WebScrollbarImpl::scroll):
(WebKit::WebScrollbarImpl::onMouseWheel):
(WebKit::WebScrollbarImpl::onKeyDown):

  • src/WebScrollbarImpl.h:
  • tests/PopupMenuTest.cpp:

(WebKit::TestPopupMenuClient::createScrollbar):

Source/WebKit/qt:

  • Api/qwebframe.cpp:

(QWebFrame::setScrollBarValue):

Source/WebKit/win:

  • WebScrollBar.cpp:

(WebScrollBar::scroll):

  • WebScrollBar.h:

Source/WebKit2:

  • UIProcess/win/WebPopupMenuProxyWin.cpp:

(WebKit::WebPopupMenuProxyWin::onMouseWheel):
(WebKit::WebPopupMenuProxyWin::scrollToRevealSelection):

  • UIProcess/win/WebPopupMenuProxyWin.h:
12:13 PM Changeset in webkit [76377] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/chromium

2011-01-21 Sailesh Agrawal <sail@chromium.org>

Reviewed by Ryosuke Niwa.

[chromium] Notify WebFrameClient when spellcheck state changes
https://bugs.webkit.org/show_bug.cgi?id=52680

  • public/WebFrameClient.h: (WebKit::WebFrameClient::continuousSpellCheckingEnabledStateChanged):
  • src/EditorClientImpl.cpp: (WebKit::EditorClientImpl::toggleContinuousSpellChecking):
  • src/WebFrameImpl.cpp:
12:01 PM Changeset in webkit [76376] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-01-21 Peter Gal <galpeter@inf.u-szeged.hu>

Reviewed by Darin Adler.

REGRESSION(r76177): All JavaScriptCore tests fail on ARM
https://bugs.webkit.org/show_bug.cgi?id=52814

Get the approximateByteSize value before releasing the OwnPtr.

  • parser/JSParser.cpp: (JSC::JSParser::parseFunctionInfo):
11:51 AM Changeset in webkit [76375] by darin@apple.com
  • 2 edits in trunk/Source/WebCore

Fix Leopard build.

  • rendering/mathml/RenderMathMLFraction.cpp:

(WebCore::RenderMathMLFraction::layout): Use ceilf instead of ceil.

11:44 AM Changeset in webkit [76374] by simon.fraser@apple.com
  • 2 edits in trunk/Source/WebCore

2011-01-21 Simon Fraser <simon.fraser@apple.com>

Reviewed by Sam Weinig.

GraphicsLayer should be non-copyable
https://bugs.webkit.org/show_bug.cgi?id=52909

Use WTF_MAKE_NONCOPYABLE on GraphicsLayer, and WTF_MAKE_FAST_ALLOCATED
on that and KeyframeValueList.

  • platform/graphics/GraphicsLayer.h:
11:40 AM Changeset in webkit [76373] by antonm@chromium.org
  • 3 edits
    2 adds in trunk

2011-01-21 Anton Muhin <antonm@chromium.org>

Reviewed by Nate Chapin.

[v8] Properly deal with the case when conversion to string throws an exception for HTMLCollection accessors
https://bugs.webkit.org/show_bug.cgi?id=52901

  • fast/dom/htmlcollection-conversion-throws-exception-expected.txt: Added.
  • fast/dom/htmlcollection-conversion-throws-exception.html: Added.

2011-01-21 Anton Muhin <antonm@chromium.org>

Reviewed by Nate Chapin.

[v8] Properly deal with the case when conversion to string throws an exception for HTMLCollection accessors
https://bugs.webkit.org/show_bug.cgi?id=52901

Test: fast/dom/htmlcollection-conversion-throws-exception.html

  • bindings/v8/custom/V8HTMLCollectionCustom.cpp: (WebCore::getItem):
11:35 AM Changeset in webkit [76372] by Adam Roben
  • 7 edits
    2 adds in trunk/Source

Separate flushing layer changes from rendering in CACFLayerTreeHost

Old model:

1) A change is made to a GraphicsLayer.
2) CACFLayerTreeHost::flushPendingGraphicsLayerChangesSoon is called, which schedules the

render timer.

3) The timer fires, which calls through to CACFLayerTreeHost::render, which performs the

flush and then renders.

New model:

1) A change is made to a GraphicsLayer.
2) CACFLayerTreeHost::flushPendingGraphicsLayerChangesSoon is called, which tells the new

LayerChangesFlusher singleton that this host has changes that need to be flushed.

3) LayerChangesFlusher sets up a Windows hook that will get called on the next iteration

of the message loop.

4) LayerChangesFlusher's hook is called, which calls through to

CACFLayerTreeHost::flushPendingLayerChangesNow.

5) CACFLayerTreeHost::flushPendingLayerChangesNow schedules the render timer so the changes

that were just flushed to the context will be rendered.

When a change is made to a PlatformCALayer that doesn't have a corresponding GraphicsLayer
(e.g., for rendering <video>), CACFLayerTreeHost::layerTreeDidChange takes care of
scheduling the flush.

This change has three advantages:

1) Whenever we flush layer changes, we first update layout. This can cause the page to

leave compositing mode, which in turn can cause all references to the CACFLayerTreeHost
to be dropped. By separating flushing (and thus updating layout) from rendering, we no
longer have to worry about this happen during rendering.

2) The new model is much more similar to how things work on the Mac, so will hopefully

reduce the number of platform-specific bugs.

3) CACFLayerTreeHost::shouldRender, which was used to make sure we didn't render while a

layout was pending, is no longer needed. It actually hasn't been needed since at least
r75987, but removing it before now would have resulted in a crash whenever a page came
out of compositing mode due to (1).

Fixes <http://webkit.org/b/52852> Flushing layer changes and rendering are intertwined in
CACFLayerTreeHost, but shouldn't be

Reviewed by Simon Fraser.

Source/WebCore:

  • WebCore.vcproj/WebCore.vcproj: Added LayerChangesFlusher.
  • platform/graphics/ca/win/CACFLayerTreeHost.cpp: Added new #include, sorted existing #includes.

(WebCore::CACFLayerTreeHost::CACFLayerTreeHost): Initialize new member.
(WebCore::CACFLayerTreeHost::layerTreeDidChange): If we aren't already flushing changes,
schedule a flush. Removed the call to renderSoon(), which now happens when the flush is
finished.
(WebCore::CACFLayerTreeHost::destroyRenderer): Cancel any pending flush we had scheduled. Also
fixed a bug where we'd fail to clear the context's layer.
(WebCore::CACFLayerTreeHost::render): Removed code to ask the client if we should render, which
is no longer needed. Moved code to flush layer changes from here to
flushPendingLayerChangesNow, which is called via the above-described mechanism.
(WebCore::CACFLayerTreeHost::flushPendingGraphicsLayerChangesSoon): Schedule a flush. Removed
code to schedule a render, which now happens after we've flushed.
(WebCore::CACFLayerTreeHost::flushPendingLayerChangesNow): Added. Some of this code came from
render(). First we flush GraphicsLayer changes from GraphicsLayers to their underlying
PlatformCALayers, then we flush changes from PlatformCALayers to the context, then we
schedule a render so that the changes will be rendered to the screen.

  • platform/graphics/ca/win/CACFLayerTreeHost.h: Removed

CACFLayerTreeHostClient::shouldRender. Added flushPendingLayerChangesNow and
m_isFlushingLayerChanges.

  • platform/graphics/ca/win/LayerChangesFlusher.cpp: Added.

(WebCore::LayerChangesFlusher::shared):
(WebCore::LayerChangesFlusher::LayerChangesFlusher):
(WebCore::LayerChangesFlusher::flushPendingLayerChangesSoon):
(WebCore::LayerChangesFlusher::cancelPendingFlush):
(WebCore::LayerChangesFlusher::hookCallback):
(WebCore::LayerChangesFlusher::hookFired):
(WebCore::LayerChangesFlusher::setHook):
(WebCore::LayerChangesFlusher::removeHook):

  • platform/graphics/ca/win/LayerChangesFlusher.cpp: Added.

(WebCore::LayerChangesFlusher::shared): Returns the singleton.
(WebCore::LayerChangesFlusher::LayerChangesFlusher): Initialize our members.
(WebCore::LayerChangesFlusher::flushPendingLayerChangesSoon): Add the host to the set of
hosts with changes that need to be flushed, and set up our hook if we haven't already.
(WebCore::LayerChangesFlusher::cancelPendingFlush): Remove the host from the set of hosts
with changes that need to be flushed. If we have no more such hosts, remove our hook, unless
we're currently in the process of calling out to our hosts, in which case we'll take care of
the hook once we're done calling out.
(WebCore::LayerChangesFlusher::hookCallback): This is the function that Windows calls when
our hook fires. Just calls through to hookFired on the singleton.
(WebCore::LayerChangesFlusher::hookFired): Tell all the hosts with changes that needed to be
flushed that it's time to flush. If no hosts re-added themselves to our set during this
process, remove our hook.
(WebCore::LayerChangesFlusher::setHook): Calls through to ::SetWindowsHookExW.
(WebCore::LayerChangesFlusher::removeHook): Calls through to ::UnhookWindowsHookEx.

  • platform/graphics/ca/win/LayerChangesFlusher.h: Added.

Source/WebKit/win:

Update for CACFLayerTreeHost changes

  • WebView.cpp:

(WebView::paint): Changed to flush layer changes via CACFLayerTreeHost, which will call back
to our own flushing function if needed.

  • WebView.h: Removed shouldRender, which is no longer used or needed.
11:33 AM Changeset in webkit [76371] by simon.fraser@apple.com
  • 19 edits in trunk/Source/WebCore

2011-01-21 Simon Fraser <simon.fraser@apple.com>

Reviewed by Sam Weinig.

Report the sized used by canvases and types arrays
https://bugs.webkit.org/show_bug.cgi?id=52856

Report the memory cost associated with canvas elements,
and typed arrays to JavaScript as extraCost, so that it
can figure this into its GC behavior.

  • bindings/js/JSArrayBufferViewHelper.h: (WebCore::toJSArrayBufferView): New templatized function, similar to getDOMObjectWrapper() but calls reportExtraMemoryCost() with the byteLength of the array.
  • bindings/js/JSFloat32ArrayCustom.cpp: (WebCore::toJS): Use toJSArrayBufferView.
  • bindings/js/JSInt16ArrayCustom.cpp: (WebCore::toJS): Use toJSArrayBufferView.
  • bindings/js/JSInt32ArrayCustom.cpp: (WebCore::toJS): Use toJSArrayBufferView.
  • bindings/js/JSInt8ArrayCustom.cpp: (WebCore::toJS): Use toJSArrayBufferView.
  • bindings/js/JSUint16ArrayCustom.cpp: (WebCore::toJS): Use toJSArrayBufferView.
  • bindings/js/JSUint32ArrayCustom.cpp: (WebCore::toJS): Use toJSArrayBufferView.
  • bindings/js/JSUint8ArrayCustom.cpp: (WebCore::toJS): Use toJSArrayBufferView.
  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::createImageBuffer): Call heap.reportExtraMemoryCost() with the size of the canvas backing store.
  • html/canvas/TypedArrayBase.h: (WebCore::TypedArrayBase::byteLength): byteLength needs to be public.
  • platform/graphics/ImageBuffer.h: Add dataSize() method.
  • platform/graphics/cairo/ImageBufferCairo.cpp: (WebCore::ImageBuffer::dataSize): Implement dataSize().
  • platform/graphics/cg/ImageBufferCG.cpp: (WebCore::ImageBuffer::dataSize): Implement dataSize().
  • platform/graphics/haiku/ImageBufferHaiku.cpp: (WebCore::ImageBuffer::dataSize): Implement dataSize().
  • platform/graphics/qt/ImageBufferQt.cpp: (WebCore::ImageBuffer::dataSize): Implement dataSize().
  • platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::ImageBuffer::dataSize): Implement dataSize().
  • platform/graphics/wince/ImageBufferWinCE.cpp: (WebCore::ImageBuffer::dataSize): Implement dataSize().
  • platform/graphics/wx/ImageBufferWx.cpp: (WebCore::ImageBuffer::dataSize): Implement dataSize().
11:32 AM Changeset in webkit [76370] by Adam Roben
  • 13 edits
    2 moves in trunk/Source

Rename WKCACFLayerRenderer[Client] to CACFLayerTreeHost[Client]

Also renamed a few functions and data members to match.

Fixes <http://webkit.org/b/52898> WKCACFLayerRenderer sounds like a render object, but isn't

Reviewed by Simon Fraser.

Source/WebCore:

  • WebCore.vcproj/WebCore.vcproj: Updated files' names and paths.
  • WebCore.vcproj/WebCoreQuartzCore.vsprops: Added platform/graphics/ca/win to the include

path.

  • WebCore.vcproj/copyForwardingHeaders.cmd: Copy headers from platform/graphics/ca/win, too.
  • platform/graphics/ca/win/CACFLayerTreeHost.cpp: Renamed from Source/WebCore/platform/graphics/win/WKCACFLayerRenderer.cpp.
  • platform/graphics/ca/win/CACFLayerTreeHost.h: Renamed from Source/WebCore/platform/graphics/win/WKCACFLayerRenderer.h.
  • platform/graphics/ca/win/PlatformCALayerWin.cpp:
  • platform/graphics/win/MediaPlayerPrivateFullscreenWindow.cpp:
  • platform/graphics/win/MediaPlayerPrivateFullscreenWindow.h:

Updated for renames.

Source/WebKit/win:

Update for WKCACFLayerRenderer -> CACFLayerTreeHost rename

Also renamed WebView::m_layerRenderer to WebView::m_layerTreeHost to match.

  • WebPreferences.cpp:
  • WebView.cpp:

(WebView::setAcceleratedCompositing): Also made sure to remove our HWND from the layer tree
host before we get rid of the layer tree host itself.

  • WebView.h:

Source/WebKit2:

Update for WKCACFLayerRenderer -> CACFLayerView rename

  • WebProcess/WebPage/win/LayerBackedDrawingAreaWin.cpp: Just removed all the unnecessary #includes.
11:32 AM Changeset in webkit [76369] by xan@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-01-21 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

Remove unnecessary <stdio.h> include
https://bugs.webkit.org/show_bug.cgi?id=52884

  • jit/JIT.cpp: remove unnecessary include.
11:27 AM Changeset in webkit [76368] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-01-21 Patrick Gansterer <paroga@paroga.com>

Original patch from François Sausset <François Sausset>

Reviewed by Darin Adler.

Code cleaning in rendering/mathml/RenderMathMLFraction.cpp
https://bugs.webkit.org/show_bug.cgi?id=52201

Replace unneeded doubles by floats and remove unneeded casts.

  • rendering/mathml/RenderMathMLFraction.cpp: (WebCore::RenderMathMLFraction::paint):
  • rendering/mathml/RenderMathMLFraction.h:
11:20 AM Changeset in webkit [76367] by levin@chromium.org
  • 2 edits in trunk/Websites/webkit.org

Proposal: Require cross-organizational seconds for reviewer nominations
https://bugs.webkit.org/show_bug.cgi?id=47597

Reviewed by Darin Adler.

This changes the committer/reviewer policy to require an additional
reviewer supporting a reviewer nomination to work for a different
company and different project affiliation from the nominee.

This means reviewer nominations would require four supporting reviewers,
one of which knows the reviewer through the community (irc, email, bugs)
ensuring that the nominee has the open-source collaboration skills
we so highly value here in WebKit.

  • coding/commit-review-policy.html:
11:20 AM Changeset in webkit [76366] by Dimitri Glazkov
  • 4 edits
    2 adds in trunk

2011-01-21 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

REGRESSION(r73618): Clicking on a search input causes a crash.
https://bugs.webkit.org/show_bug.cgi?id=52905

  • fast/dom/search-shadow-host-crash-expected.txt: Added.
  • fast/dom/search-shadow-host-crash.html: Added.

2011-01-21 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

REGRESSION(r73618): Clicking on a search input causes a crash.
https://bugs.webkit.org/show_bug.cgi?id=52905

The problem is caused by TextControlInnerElement being used both as
shadow root and an element in a shadow subtree. The code assumed it is
only used as a shadow root.

Since this code is all just workaround for in-progress conversion to
new shadow DOM, I am just adding a check. This code will disappear
completely once bug 52788 is fixed.

Test: fast/dom/search-shadow-host-crash.html

  • dom/Node.cpp: (WebCore::Node::setShadowHost): Added an ASSERT for early detection

of attempting to stomp on the parentNode.

  • rendering/TextControlInnerElements.cpp: (WebCore::TextControlInnerElement::detach): Added a check to only

clear shadow host if we have one.

11:05 AM Changeset in webkit [76365] by Dimitri Glazkov
  • 3 edits in trunk/LayoutTests

2011-01-21 Dimitri Glazkov <Dimitri Glazkov>

Updated slider expectations after r76147.

  • platform/chromium/test_expectations.txt: Removed test that will start passing.
  • platform/chromium-win/fast/forms/slider-mouse-events-expected.txt: Updated expectation.
11:00 AM Changeset in webkit [76364] by xji@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

2011-01-21 Xiaomei Ji <xji@chromium.org>

Unreviewed.

Rebaseline for leopard after r76319.

  • platform/mac-leopard/fast/dom/52776-expected.txt: Added.
10:50 AM Changeset in webkit [76363] by tony@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-01-21 Tony Chang <tony@chromium.org>

Unreviewed, updating chromium DEPS so we can pull in linux theme changes.

  • DEPS:
10:44 AM Changeset in webkit [76362] by darin@apple.com
  • 2 edits in trunk/Tools

Fix Mac build.

  • MiniBrowser/mac/BrowserWindowController.m:

(-[BrowserWindowController awakeFromNib]): Pass 0 for runModal function.

10:41 AM Changeset in webkit [76361] by darin@apple.com
  • 18 edits in trunk

WebKit2: Implement showModalDialog
https://bugs.webkit.org/show_bug.cgi?id=52855

Reviewed by Dan Bernstein.

Source/WebKit2:

  • Shared/WebPageCreationParameters.h: Added canRunModal.
  • UIProcess/API/C/WKPage.h: Added a runModal function pointer to

WKPageUIClient. Also removed a lot of redundant typedefs and added
a new one, WKPageCallback, for callbacks without arguments or return
values.

  • UIProcess/API/qt/qwkpage.cpp:

(QWKPage::QWKPage): Added a runModal function pointer of 0.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::creationParameters): Set canRunModal
based on return value of WebUIClient::canRunModal.

  • UIProcess/WebPageProxy.h: Added runModal.

Calls WebUIClient::runModal.

  • UIProcess/WebPageProxy.messages.in: Added RunModal message.

Also removed the periods from the phrases in the comments
as Maciej requested a while back.

  • UIProcess/WebUIClient.cpp:

(WebKit::WebUIClient::canRunModal): Added. Returns true or false
based on whether a runModal function was supplied in the
WKPageUIClient structure.
(WebKit::WebUIClient::runModal): Added. Calls the runModal
function from the WKPageUIClient structure.

  • UIProcess/WebUIClient.h: Declared the above functions.
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::canRunModal): Call through to WebPage.
(WebKit::WebChromeClient::runModal): Ditto.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage): Initialize m_canRunModal based on the
creation parameters. Initialize m_isRunningModal to false.
(WebKit::WebPage::close): Stop the nested run loop if we are running modal.
(WebKit::WebPage::runModal): Send a message to ask the UI process to run
modal and then start a nested run loop. It gets stopped when the page is closed.

  • WebProcess/WebPage/WebPage.h: Defined the canRunModal function

and declared the runModal function.

Tools:

This fixes WebKitTestRunner to compile, but more work is probably
needed to get it to pass the tests.

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::runModal): Added. Calls through to the
platform-specific version of runModal.
(WTR::TestController::createOtherPage): Changed to be a private
static member function so it can refer to runModal, which is
a private static member function.
(WTR::TestController::initialize): Pass 0 for the runModal
function since we don't need to run the main window modal.
I suspect this is wrong and will need to change.

  • WebKitTestRunner/TestController.h: Added declarations for

the functions added above.

  • WebKitTestRunner/mac/TestControllerMac.mm:

(WTR::TestController::runModal): Added. Untested implementation.

  • WebKitTestRunner/qt/TestControllerQt.cpp:

(WTR::TestController::runModal): Added.

  • WebKitTestRunner/win/TestControllerWin.cpp:

(WTR::TestController::runModal): Added.

10:41 AM Changeset in webkit [76360] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

2011-01-21 Kenji Imasaki <imasaki@chromium.org>

Reviewed by David Levin.

remove non-flaky tests from test expectation file
https://bugs.webkit.org/show_bug.cgi?id=52746

  • platform/chromium/test_expectations.txt:
10:31 AM Changeset in webkit [76359] by Adam Roben
  • 7 edits in trunk/Source

Replace some "sync compositing state" terminology with "flush pending GraphicsLayer changes"

This seems to be the direction in which our code is moving. I chose "GraphicsLayer" as
opposed to just "layer" because there are cases where we flush changes to CACFLayers that
don't have a corresponding GraphicsLayer.

Fixes <http://webkit.org/b/52894> "Sync compositing state" terminology in
WKCACFLayerRenderer and friends is confusing

Reviewed by Simon Fraser.

Source/WebCore:

  • platform/graphics/win/WKCACFLayerRenderer.cpp:

(WebCore::WKCACFLayerRenderer::WKCACFLayerRenderer):
(WebCore::WKCACFLayerRenderer::render):
Updated for renames.

(WebCore::WKCACFLayerRenderer::flushPendingGraphicsLayerChangesSoon): Renamed from
syncCompositingStateSoon, and updated for other renames.

  • platform/graphics/win/WKCACFLayerRenderer.h: Renamed m_syncLayerChanges to
  • m_shouldFlushPendingGraphicsLayerChanges.

(WebCore::WKCACFLayerRendererClient::flushPendingGraphicsLayerChanges): Renamed from
syncCompositingState.

Source/WebKit/win:

  • WebCoreSupport/WebChromeClient.cpp:

(WebChromeClient::scheduleCompositingLayerSync): Updated for WebView changes.

  • WebView.cpp:

(WebView::paint): Updated for rename.
(WebView::flushPendingGraphicsLayerChangesSoon): Renamed from scheduleCompositingLayerSync.
(WebView::notifySyncRequired): Updated for rename.
(WebView::flushPendingGraphicsLayerChanges): Renamed from syncCompositingState.

  • WebView.h: Did the renames.
10:31 AM Changeset in webkit [76358] by Adam Roben
  • 2 edits in trunk/Source/WebCore

Clean up PlatformCAAnimationWin

Fixes <http://webkit.org/b/52904> PlatformCAAnimationWin is leaky and inefficient

Reviewed by Simon Fraser.

  • platform/graphics/ca/win/PlatformCAAnimationWin.cpp:

(toCACFFillModeType):
(fromCACFFillModeType):
(toCACFValueFunctionType):
(fromCACFValueFunctionType):
Changed to take and return CFStringRefs. There's no need to convert to WebCore::String just
so we can later convert back to CFStringRef.

(toCACFTimingFunction): Fixed leaks by changing this to return a RetainPtr and adopting the
results of CACFTimingFunctionCreate.
(PlatformCAAnimation::PlatformCAAnimation): Changed not to needlessly roundtrip through
WebCore::String. Also changed an ASSERT(0) to ASSERT_NOT_REACHED().

(PlatformCAAnimation::setFillMode):
(PlatformCAAnimation::setTimingFunction):
(PlatformCAAnimation::setValueFunction):
(PlatformCAAnimation::setTimingFunctions):
Updated for changes to the above conversion functions.

10:26 AM Changeset in webkit [76357] by commit-queue@webkit.org
  • 9 edits
    4 adds in trunk

2011-01-21 Charlie Reis <creis@chromium.org>

Reviewed by Darin Fisher.

FrameLoader::checkLoadCompleteForThisFrame uses wrong history item
https://bugs.webkit.org/show_bug.cgi?id=48812

Test that we avoid updating back/forward list on a canceled navigation
if a new navigation is already in process. Also update forward-and-cancel
to go forward, ensuring back/forward state is reset if user clicks stop.

  • http/tests/navigation/back-twice-without-commit-expected.txt: Added.
  • http/tests/navigation/back-twice-without-commit.html: Added.
  • http/tests/navigation/forward-and-cancel-expected.txt:
  • http/tests/navigation/forward-and-cancel.html: Go forward after stop, not back.
  • http/tests/navigation/resources/back-twice-page-2.html: Added.
  • http/tests/navigation/resources/back-twice-page-3.html: Added.
  • http/tests/navigation/resources/forward-and-cancel-frames.html: Reduced delay.

2011-01-21 Charlie Reis <creis@chromium.org>

Reviewed by Darin Fisher.

FrameLoader::checkLoadCompleteForThisFrame uses wrong history item
https://bugs.webkit.org/show_bug.cgi?id=48812

Most calls to stopAllLoaders now clear the history's provisional item(s).
We can now avoid resetting the back/forward state if a new navigation
is in progress.

Test: http/tests/navigation/back-twice-without-commit.html
Test: http/tests/navigation/forward-and-cancel.html

  • loader/FrameLoader.cpp:
  • loader/FrameLoader.h:
  • loader/FrameLoaderTypes.h:
  • WebCore.exp.in: Update stopAllLoaders signature.
10:09 AM Changeset in webkit [76356] by mihaip@chromium.org
  • 2 edits
    2 moves
    2 adds
    2 deletes in trunk/LayoutTests

2011-01-20 Mihai Parparita <mihaip@chromium.org>

Reviewed by Eric Seidel.

[Chromium] Update expectations for compositing/geometry/limit-layer-bounds-overflow-repaint.html
https://bugs.webkit.org/show_bug.cgi?id=52860

The test hasn't had a timeout in a while, remove that expectation so
that we can more easily see if this re-occurs.

Also rebaseline for chromium-gpu-mac (it has the green as 0,128,0, just
like chromium-gpu-win and -linux, for some reason the mac expectation
has it as 17,128,4).

  • platform/chromium-gpu-win/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.checksum: Removed.
  • platform/chromium-gpu-win/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.png: Removed.
  • platform/chromium-gpu/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.checksum: Renamed from LayoutTests/platform/chromium-gpu-linux/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.checksum.
  • platform/chromium-gpu/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.png: Renamed from LayoutTests/platform/chromium-gpu-linux/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.png.
  • platform/chromium-gpu/test_expectations.txt:
9:51 AM Changeset in webkit [76355] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-01-21 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed; Reverted the last change to the text expectation.

  • platform/chromium/test_expectations.txt:
9:39 AM Changeset in webkit [76354] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-01-21 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed Chromium test expectation update.

  • platform/chromium/test_expectations.txt:
9:33 AM Changeset in webkit [76353] by rniwa@webkit.org
  • 2 edits
    9 adds in trunk/LayoutTests

2011-01-21 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed Chromium rebaselines for 76319.

  • platform/chromium-linux/fast/dom/52776-expected.checksum: Added.
  • platform/chromium-linux/fast/dom/52776-expected.png: Added.
  • platform/chromium-linux/fast/dom/52776-expected.txt: Added.
  • platform/chromium-mac/fast/dom/52776-expected.checksum: Added.
  • platform/chromium-mac/fast/dom/52776-expected.png: Added.
  • platform/chromium-mac/fast/dom/52776-expected.txt: Added.
  • platform/chromium-win/fast/dom/52776-expected.checksum: Added.
  • platform/chromium-win/fast/dom/52776-expected.png: Added.
  • platform/chromium-win/fast/dom/52776-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
9:26 AM Changeset in webkit [76352] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

2011-01-21 Tony Chang <tony@chromium.org>

Unreviewed, these tests were fixed in r76330. Still one unknown
failure.

  • platform/chromium/test_expectations.txt:
9:21 AM Changeset in webkit [76351] by Carlos Garcia Campos
  • 6 edits in trunk/Source

2011-01-21 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Show caps lock indicator in password fields
https://bugs.webkit.org/show_bug.cgi?id=52878

Test: manual-tests/password-caps-lock.html

  • platform/gtk/KeyEventGtk.cpp: (WebCore::PlatformKeyboardEvent::currentCapsLockState): Implement currentCapsLockState() using GDK API.
  • platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::paintCapsLockIndicator): Paint an icon in the password field when the caps lock modifier is locked.
  • platform/gtk/RenderThemeGtk.h:

2011-01-21 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Show caps lock indicator in password fields
https://bugs.webkit.org/show_bug.cgi?id=52878

Test: manual-tests/password-caps-lock.html

  • webkit/webkitwebview.cpp: (webkit_web_view_key_release_event): Call capsLockStateMayHaveChanged() when caps lock key is pressed.
8:36 AM Changeset in webkit [76350] by jberlin@webkit.org
  • 5 edits in trunk/LayoutTests

Modify the Windows-specific results after http://trac.webkit.org/changeset/76208 in order to
get the bots green. Unreviewed.
https://bugs.webkit.org/show_bug.cgi?id=52557

  • platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/win/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/win/fast/dom/prototype-inheritance-expected.txt:
  • platform/win/fast/js/global-constructors-expected.txt:
8:22 AM Changeset in webkit [76349] by jberlin@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

Add Windows-specific results for fast/dom/52776.html to get the bot green. Unreviewed.
https://bugs.webkit.org/show_bug.cgi?id=52776

  • platform/win/fast/dom/52776-expected.txt: Added.
8:08 AM Changeset in webkit [76348] by podivilov@chromium.org
  • 9 edits in trunk/Source/WebCore

2011-01-21 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: move sticky breakpoints management from InspectorController to InspectorBrowserDebuggerAgent.
https://bugs.webkit.org/show_bug.cgi?id=52874

This is the first step of debugger api refactoring (see bug 52879).
JavaScript breakpoints are still in the same list as native breakpoints and are restored by InspectorBrowserDebuggerAgent.
The second step will be to move sticky JavaScript breakpoints to InspectorDebuggerAgent.

  • inspector/Inspector.idl:
  • inspector/InspectorBrowserDebuggerAgent.cpp: (WebCore::InspectorBrowserDebuggerAgent::setAllBrowserBreakpoints): (WebCore::InspectorBrowserDebuggerAgent::inspectedURLChanged): (WebCore::InspectorBrowserDebuggerAgent::restoreStickyBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::discardBindings): (WebCore::InspectorBrowserDebuggerAgent::didInsertDOMNode): (WebCore::InspectorBrowserDebuggerAgent::didRemoveDOMNode): (WebCore::InspectorBrowserDebuggerAgent::setDOMBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::removeDOMBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::descriptionForDOMEvent): (WebCore::InspectorBrowserDebuggerAgent::hasBreakpoint): (WebCore::InspectorBrowserDebuggerAgent::updateSubtreeBreakpoints):
  • inspector/InspectorBrowserDebuggerAgent.h:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::restoreInspectorStateFromCookie): (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::didCommitLoad): (WebCore::InspectorController::enableDebugger): (WebCore::InspectorController::resume): (WebCore::InspectorController::inspectedURL):
  • inspector/InspectorController.h:
  • inspector/InspectorState.cpp: (WebCore::InspectorState::InspectorState):
  • inspector/InspectorState.h:
  • inspector/front-end/BreakpointManager.js: (WebInspector.BreakpointManager): (WebInspector.BreakpointManager.prototype._saveBreakpoints):
7:51 AM Changeset in webkit [76347] by jknotten@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-01-21 John Knottenbelt <jknotten@chromium.org>

Reviewed by Jeremy Orlow.

Turn off uninitialized errors for ARM linux build.
https://bugs.webkit.org/show_bug.cgi?id=52893

Fix ARM compiler breakage.

  • WebCore.gyp/WebCore.gyp:
7:00 AM Changeset in webkit [76346] by mnaganov@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-01-21 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Add layout test for the CPU profiler.

This test replaces DevToolsSanityTest.TestProfilerTab from
Chromium's interactive_ui_tests.

https://bugs.webkit.org/show_bug.cgi?id=52634

  • inspector/cpu-profiler-profiling-expected.txt: Added.
  • inspector/cpu-profiler-profiling.html: Added.

[Relanding, this time the test should work in Chromium]

6:41 AM Changeset in webkit [76345] by mnaganov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-01-21 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [Chromium] REGRESSION: Using the "Back" button
while profiling causes renderer crash.

https://bugs.webkit.org/show_bug.cgi?id=52808

  • inspector/InspectorProfilerAgent.cpp: (WebCore::InspectorProfilerAgent::addProfileFinishedMessageToConsole): (WebCore::InspectorProfilerAgent::addStartProfilingMessageToConsole):
4:30 AM Changeset in webkit [76344] by loislo@chromium.org
  • 6 edits in trunk/Source/WebCore

2011-01-20 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: switch page/Console implementation from InspectorController to InspectorInstrumentation.

There are some places in WebCore where we still using direct InspectorController calls.
The idea is to pass all the Inspector related calls via InspectorInstrumentaion which is the
Inspector facade for WebCore.

https://bugs.webkit.org/show_bug.cgi?id=52869

  • inspector/InspectorController.cpp:
  • inspector/InspectorController.h:
  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::addProfileImpl): (WebCore::InspectorInstrumentation::profilerEnabledImpl): (WebCore::InspectorInstrumentation::getCurrentUserInitiatedProfileNameImpl):
  • inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::addProfile): (WebCore::InspectorInstrumentation::profilerEnabled): (WebCore::InspectorInstrumentation::getCurrentUserInitiatedProfileName):
  • page/Console.cpp: (WebCore::Console::profile): (WebCore::Console::profileEnd):
4:16 AM Changeset in webkit [76343] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed.

[Qt] editing/selection/rtl-move-selection-right-left.html fails
https://bugs.webkit.org/show_bug.cgi?id=52883

  • platform/qt/Skipped: editing/selection/rtl-move-selection-right-left.html added until fix.
4:08 AM Changeset in webkit [76342] by sergio@webkit.org
  • 2 edits in trunk/LayoutTests

2011-01-21 Sergio Villar Senin <svillar@igalia.com>

Unreviewed.

[GTK] http/tests/security/drag-drop-same-unique-origin.html fails on bots.
https://bugs.webkit.org/show_bug.cgi?id=52882

Skipping http/tests/security/drag-drop-same-unique-origin.html for gtk.

  • platform/gtk/Skipped:
3:59 AM Changeset in webkit [76341] by podivilov@chromium.org
  • 8 edits in trunk/Source/WebCore

2011-01-12 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: breakpoints are restored incorrectly when reverting live edit.
https://bugs.webkit.org/show_bug.cgi?id=52300

Fix breakpoints restoring when reverting to old revision by using text diff.
Move live edit logic from ScriptsPanel to DebuggerModel.
Eliminate unnecessary editLine delegate in TextViewer.

3:31 AM Changeset in webkit [76340] by commit-queue@webkit.org
  • 55 edits
    1 move
    1 delete in trunk/Source

2011-01-21 Adam Klein <adamk@chromium.org>

Reviewed by Eric Seidel.

[chromium] Rename ChromiumBridge to PlatformBridge
https://bugs.webkit.org/show_bug.cgi?id=52471

No tests added as this is a rename; no change in behavior.

  • WebCore.gypi:
  • bindings/v8/V8DOMWindowShell.cpp: (WebCore::reportFatalErrorInV8):
  • page/PageGroup.cpp: (WebCore::PageGroup::isLinkVisited):
  • platform/android/PlatformBridge.h:
  • platform/audio/chromium/AudioBusChromium.cpp: (WebCore::createBusFromInMemoryAudioFile):
  • platform/chromium/ChromiumBridge.h: Removed.
  • platform/chromium/ChromiumDataObjectLegacy.cpp: (WebCore::ChromiumDataObjectLegacy::getData):
  • platform/chromium/DragDataChromium.cpp: (WebCore::DragData::asURL):
  • platform/chromium/FileSystemChromium.cpp: (WebCore::deleteFile): (WebCore::deleteEmptyDirectory): (WebCore::getFileSize): (WebCore::getFileModificationTime): (WebCore::revealFolderInOS): (WebCore::directoryName): (WebCore::pathByAppendingComponent): (WebCore::makeAllDirectories): (WebCore::fileExists): (WebCore::openFile): (WebCore::closeFile): (WebCore::seekFile): (WebCore::truncateFile): (WebCore::readFromFile): (WebCore::writeToFile):
  • platform/chromium/LanguageChromium.cpp: (WebCore::platformDefaultLanguage):
  • platform/chromium/LinkHashChromium.cpp: (WebCore::visitedLinkHash):
  • platform/chromium/MIMETypeRegistryChromium.cpp: (WebCore::MIMETypeRegistry::getMIMETypeForExtension): (WebCore::MIMETypeRegistry::getPreferredExtensionForMIMEType): (WebCore::MIMETypeRegistry::isSupportedImageMIMEType): (WebCore::MIMETypeRegistry::isSupportedJavaScriptMIMEType): (WebCore::MIMETypeRegistry::isSupportedNonImageMIMEType):
  • platform/chromium/PasteboardChromium.cpp: (WebCore::Pasteboard::writeSelection): (WebCore::Pasteboard::writePlainText): (WebCore::Pasteboard::writeURL): (WebCore::Pasteboard::writeImage): (WebCore::Pasteboard::canSmartReplace): (WebCore::Pasteboard::plainText): (WebCore::Pasteboard::documentFragment):
  • platform/chromium/PlatformBridge.h:
  • platform/chromium/PlatformScreenChromium.cpp: (WebCore::screenDepth): (WebCore::screenDepthPerComponent): (WebCore::screenIsMonochrome): (WebCore::screenRect): (WebCore::screenAvailableRect):
  • platform/chromium/ReadableDataObject.cpp: (WebCore::ReadableDataObject::getData): (WebCore::ReadableDataObject::urlTitle): (WebCore::ReadableDataObject::htmlBaseUrl): (WebCore::ReadableDataObject::filenames): (WebCore::ReadableDataObject::ensureTypeCacheInitialized):
  • platform/chromium/SSLKeyGeneratorChromium.cpp: (WebCore::signedPublicKeyAndChallengeString):
  • platform/chromium/ScrollbarThemeChromium.cpp:
  • platform/chromium/ScrollbarThemeChromiumLinux.cpp: (WebCore::ScrollbarThemeChromiumLinux::scrollbarThickness): (WebCore::ScrollbarThemeChromiumLinux::paintTrackPiece): (WebCore::ScrollbarThemeChromiumLinux::paintButton): (WebCore::ScrollbarThemeChromiumLinux::paintThumb): (WebCore::ScrollbarThemeChromiumLinux::buttonSize): (WebCore::ScrollbarThemeChromiumLinux::minimumThumbLength):
  • platform/chromium/ScrollbarThemeChromiumMac.mm: (WebCore::scrollbarStateToThemeState): (WebCore::ScrollbarThemeChromiumMac::paint):
  • platform/chromium/ScrollbarThemeChromiumWin.cpp: (WebCore::ScrollbarThemeChromiumWin::scrollbarThickness): (WebCore::ScrollbarThemeChromiumWin::paintTrackPiece): (WebCore::ScrollbarThemeChromiumWin::paintButton): (WebCore::ScrollbarThemeChromiumWin::paintThumb): (WebCore::ScrollbarThemeChromiumWin::buttonSize):
  • platform/chromium/SharedTimerChromium.cpp: (WebCore::setSharedTimerFiredFunction): (WebCore::setSharedTimerFireTime): (WebCore::stopSharedTimer):
  • platform/chromium/SuddenTerminationChromium.cpp: (WebCore::disableSuddenTermination): (WebCore::enableSuddenTermination):
  • platform/chromium/SystemTimeChromium.cpp: (WebCore::currentTime):
  • platform/chromium/WritableDataObject.cpp: (WebCore::WritableDataObject::setData):
  • platform/graphics/chromium/CrossProcessFontLoading.mm:
  • platform/graphics/chromium/FontCacheChromiumWin.cpp: (WebCore::fontContainsCharacter): (WebCore::FillLogFont):
  • platform/graphics/chromium/FontCacheLinux.cpp: (WebCore::FontCache::getFontDataForCharacters):
  • platform/graphics/chromium/FontChromiumWin.cpp: (WebCore::Font::drawGlyphs):
  • platform/graphics/chromium/FontPlatformDataChromiumWin.cpp: (WebCore::FontPlatformData::scriptFontProperties):
  • platform/graphics/chromium/FontPlatformDataLinux.cpp: (WebCore::FontPlatformData::querySystemForRenderStyle):
  • platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp: (WebCore::fillBMPGlyphs):
  • platform/graphics/chromium/ImageChromium.cpp: (WebCore::Image::loadPlatformResource):
  • platform/graphics/chromium/ImageChromiumMac.mm: (WebCore::Image::loadPlatformResource):
  • platform/graphics/chromium/SimpleFontDataChromiumWin.cpp: (WebCore::SimpleFontData::platformInit): (WebCore::SimpleFontData::determinePitch): (WebCore::SimpleFontData::platformWidthForGlyph):
  • platform/graphics/chromium/UniscribeHelperTextRun.cpp: (WebCore::UniscribeHelperTextRun::tryToPreloadFont):
  • platform/graphics/skia/FontCustomPlatformData.cpp: (WebCore::FontCustomPlatformData::fontPlatformData):
  • platform/network/chromium/CookieJarChromium.cpp: (WebCore::setCookies): (WebCore::cookies): (WebCore::cookieRequestHeaderFieldValue): (WebCore::cookiesEnabled): (WebCore::getRawCookies): (WebCore::deleteCookie):
  • platform/network/chromium/DNSChromium.cpp: (WebCore::prefetchDNS):
  • platform/qt/PlatformBridge.h:
  • platform/sql/chromium/SQLiteFileSystemChromium.cpp: (WebCore::SQLiteFileSystem::deleteDatabaseFile): (WebCore::SQLiteFileSystem::getDatabaseFileSize):
  • platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp: (chromiumOpen): (chromiumDelete): (chromiumAccess):
  • platform/sql/chromium/SQLiteFileSystemChromiumWin.cpp:
  • plugins/chromium/PluginDataChromium.cpp: (WebCore::PluginCache::plugins):
  • rendering/RenderThemeChromiumMac.mm: (WebCore::RenderThemeChromiumMac::usesTestModeFocusRingColor):
  • rendering/RenderThemeChromiumSkia.cpp: (WebCore::RenderThemeChromiumSkia::caretBlinkInterval):
  • rendering/RenderThemeChromiumWin.cpp: (WebCore::RenderThemeChromiumWin::platformActiveSelectionBackgroundColor): (WebCore::RenderThemeChromiumWin::platformInactiveSelectionBackgroundColor): (WebCore::RenderThemeChromiumWin::platformActiveSelectionForegroundColor): (WebCore::RenderThemeChromiumWin::systemColor): (WebCore::RenderThemeChromiumWin::paintButton): (WebCore::RenderThemeChromiumWin::paintSliderTrack): (WebCore::menuListButtonWidth): (WebCore::RenderThemeChromiumWin::paintMenuList): (WebCore::RenderThemeChromiumWin::paintTextFieldInternal): (WebCore::RenderThemeChromiumWin::paintInnerSpinButton): (WebCore::RenderThemeChromiumWin::paintProgressBar):
  • storage/chromium/IDBFactoryBackendInterface.cpp: (WebCore::IDBFactoryBackendInterface::create): (WebCore::IDBFactoryBackendInterface::~IDBFactoryBackendInterface):
  • storage/chromium/IDBKeyPathBackendImpl.cpp: (WebCore::IDBKeyPathBackendImpl::createIDBKeysFromSerializedValuesAndKeyPath):

2011-01-21 Adam Klein <adamk@chromium.org>

Reviewed by Eric Seidel.

[chromium] Rename ChromiumBridge to PlatformBridge
https://bugs.webkit.org/show_bug.cgi?id=52471

  • WebKit.gyp:
  • src/AssertMatchingEnums.cpp:
  • src/PlatformBridge.cpp: (WebCore::toChromeClientImpl): (WebCore::toWebWidgetClient): (WebCore::getCookieJar): (WebCore::PlatformBridge::cacheMetadata): (WebCore::PlatformBridge::clipboardIsFormatAvailable): (WebCore::PlatformBridge::clipboardReadPlainText): (WebCore::PlatformBridge::clipboardReadHTML): (WebCore::PlatformBridge::clipboardWriteSelection): (WebCore::PlatformBridge::clipboardWritePlainText): (WebCore::PlatformBridge::clipboardWriteURL): (WebCore::PlatformBridge::clipboardWriteImage): (WebCore::PlatformBridge::clipboardWriteData): (WebCore::PlatformBridge::clipboardReadAvailableTypes): (WebCore::PlatformBridge::clipboardReadData): (WebCore::PlatformBridge::clipboardReadFilenames): (WebCore::PlatformBridge::setCookies): (WebCore::PlatformBridge::cookies): (WebCore::PlatformBridge::cookieRequestHeaderFieldValue): (WebCore::PlatformBridge::rawCookies): (WebCore::PlatformBridge::deleteCookie): (WebCore::PlatformBridge::cookiesEnabled): (WebCore::PlatformBridge::prefetchDNS): (WebCore::PlatformBridge::fileExists): (WebCore::PlatformBridge::deleteFile): (WebCore::PlatformBridge::deleteEmptyDirectory): (WebCore::PlatformBridge::getFileSize): (WebCore::PlatformBridge::revealFolderInOS): (WebCore::PlatformBridge::getFileModificationTime): (WebCore::PlatformBridge::directoryName): (WebCore::PlatformBridge::pathByAppendingComponent): (WebCore::PlatformBridge::makeAllDirectories): (WebCore::PlatformBridge::getAbsolutePath): (WebCore::PlatformBridge::isDirectory): (WebCore::PlatformBridge::filePathToURL): (WebCore::PlatformBridge::openFile): (WebCore::PlatformBridge::closeFile): (WebCore::PlatformBridge::seekFile): (WebCore::PlatformBridge::truncateFile): (WebCore::PlatformBridge::readFromFile): (WebCore::PlatformBridge::writeToFile): (WebCore::PlatformBridge::ensureFontLoaded): (WebCore::PlatformBridge::getFontFamilyForCharacters): (WebCore::PlatformBridge::getRenderStyleForStrike): (WebCore::PlatformBridge::loadFont): (WebCore::PlatformBridge::databaseOpenFile): (WebCore::PlatformBridge::databaseDeleteFile): (WebCore::PlatformBridge::databaseGetFileAttributes): (WebCore::PlatformBridge::databaseGetFileSize): (WebCore::PlatformBridge::idbFactory): (WebCore::PlatformBridge::idbShutdown): (WebCore::PlatformBridge::createIDBKeysFromSerializedValuesAndKeyPath): (WebCore::PlatformBridge::signedPublicKeyAndChallengeString): (WebCore::PlatformBridge::computedDefaultLanguage): (WebCore::PlatformBridge::layoutTestMode): (WebCore::PlatformBridge::isSupportedImageMIMEType): (WebCore::PlatformBridge::isSupportedJavaScriptMIMEType): (WebCore::PlatformBridge::isSupportedNonImageMIMEType): (WebCore::PlatformBridge::mimeTypeForExtension): (WebCore::PlatformBridge::mimeTypeFromFile): (WebCore::PlatformBridge::preferredExtensionForMIMEType): (WebCore::PlatformBridge::plugins): (WebCore::PlatformBridge::pluginScriptableObject): (WebCore::PlatformBridge::loadPlatformImageResource): (WebCore::PlatformBridge::loadPlatformAudioResource): (WebCore::PlatformBridge::decodeAudioFileData): (WebCore::PlatformBridge::sandboxEnabled): (WebCore::PlatformBridge::setSharedTimerFiredFunction): (WebCore::PlatformBridge::setSharedTimerFireTime): (WebCore::PlatformBridge::stopSharedTimer): (WebCore::PlatformBridge::decrementStatsCounter): (WebCore::PlatformBridge::incrementStatsCounter): (WebCore::PlatformBridge::histogramCustomCounts): (WebCore::PlatformBridge::histogramEnumeration): (WebCore::PlatformBridge::suddenTerminationChanged): (WebCore::PlatformBridge::currentTime): (WebCore::PlatformBridge::paintButton): (WebCore::PlatformBridge::paintMenuList): (WebCore::PlatformBridge::paintScrollbarArrow): (WebCore::PlatformBridge::paintScrollbarThumb): (WebCore::PlatformBridge::paintScrollbarTrack): (WebCore::PlatformBridge::paintSpinButton): (WebCore::PlatformBridge::paintTextField): (WebCore::PlatformBridge::paintTrackbar): (WebCore::PlatformBridge::paintProgressBar): (WebCore::WebThemePart): (WebCore::WebThemeState): (WebCore::GetWebThemeExtraParams): (WebCore::PlatformBridge::getThemePartSize): (WebCore::PlatformBridge::paintThemePart): (WebCore::PlatformBridge::traceEventBegin): (WebCore::PlatformBridge::traceEventEnd): (WebCore::PlatformBridge::visitedLinkHash): (WebCore::PlatformBridge::isLinkVisited): (WebCore::PlatformBridge::notifyJSOutOfMemory): (WebCore::PlatformBridge::memoryUsageMB): (WebCore::PlatformBridge::actualMemoryUsageMB): (WebCore::PlatformBridge::screenDepth): (WebCore::PlatformBridge::screenDepthPerComponent): (WebCore::PlatformBridge::screenIsMonochrome): (WebCore::PlatformBridge::screenRect): (WebCore::PlatformBridge::screenAvailableRect): (WebCore::PlatformBridge::popupsAllowed): (WebCore::WorkerContextProxy::create):
  • src/ResourceHandle.cpp: (WebCore::ResourceHandle::cacheMetadata):
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::WebFrameImpl): (WebKit::WebFrameImpl::~WebFrameImpl):
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
3:23 AM Changeset in webkit [76339] by eric@webkit.org
  • 2 edits
    1 add in trunk/Tools

2011-01-21 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Split Host object off from WebKitPatch for easier re-use
https://bugs.webkit.org/show_bug.cgi?id=52284

new-run-webkit-tests and other tools are eventually going to want one of these.
Basically you need to inherit from this class if you want to pretend to be a
self.tool object for Steps/Commands.

  • Scripts/webkitpy/common/host.py: Added.
  • Scripts/webkitpy/tool/main.py:
3:14 AM Changeset in webkit [76338] by commit-queue@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

2011-01-21 Helder Correia <helder@sencha.com>

Reviewed by Andreas Kling.

[Qt] svg/css/text-gradient-shadow.svg needs expected results
https://bugs.webkit.org/show_bug.cgi?id=52724

  • platform/qt/svg/css/text-gradient-shadow-expected.checksum: Added.
  • platform/qt/svg/css/text-gradient-shadow-expected.png: Added.
  • platform/qt/svg/css/text-gradient-shadow-expected.txt: Added.
2:06 AM Changeset in webkit [76337] by loislo@chromium.org
  • 6 edits in trunk/Source/WebCore

2011-01-21 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r76335.
http://trac.webkit.org/changeset/76335
https://bugs.webkit.org/show_bug.cgi?id=52875

profiler tests were broken (Requested by loislo on #webkit).

  • inspector/InspectorController.cpp: (WebCore::InspectorController::addProfile): (WebCore::InspectorController::getCurrentUserInitiatedProfileName):
  • inspector/InspectorController.h:
  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::addStartProfilingMessageToConsoleImpl):
  • inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::addStartProfilingMessageToConsole): (WebCore::InspectorInstrumentation::inspectorControllerWithFrontendForPage):
  • page/Console.cpp: (WebCore::Console::profile): (WebCore::Console::profileEnd):
1:34 AM Changeset in webkit [76336] by yurys@chromium.org
  • 7 edits in trunk/LayoutTests

2011-01-21 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Make userscripts/window-onerror-for-isolated-world-*.html give consistent output
https://bugs.webkit.org/show_bug.cgi?id=52870

Call setTimeout from "load" event listener to make sure exception in the setTimeout
callback happens after the one in the listener.

  • platform/chromium/userscripts/window-onerror-for-isolated-world-1-expected.txt:
  • platform/chromium/userscripts/window-onerror-for-isolated-world-2-expected.txt:
  • userscripts/window-onerror-for-isolated-world-1-expected.txt:
  • userscripts/window-onerror-for-isolated-world-1.html:
  • userscripts/window-onerror-for-isolated-world-2-expected.txt:
  • userscripts/window-onerror-for-isolated-world-2.html:
1:24 AM Changeset in webkit [76335] by loislo@chromium.org
  • 6 edits in trunk/Source/WebCore

2011-01-21 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: switch page/Console implementation from InspectorController to InspectorInstrumentation.

There are some places in WebCore where we still using direct InspectorController calls.
The idea is to pass all the Inspector related calls via InspectorInstrumentaion which is the
Inspector facade for WebCore.

https://bugs.webkit.org/show_bug.cgi?id=52869

  • inspector/InspectorController.cpp:
  • inspector/InspectorController.h:
  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::addProfileImpl): (WebCore::InspectorInstrumentation::profilerEnabledImpl): (WebCore::InspectorInstrumentation::getCurrentUserInitiatedProfileNameImpl):
  • inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::addProfile): (WebCore::InspectorInstrumentation::profilerEnabled): (WebCore::InspectorInstrumentation::getCurrentUserInitiatedProfileName):
  • page/Console.cpp: (WebCore::Console::profile): (WebCore::Console::profileEnd):
Note: See TracTimeline for information about the timeline view.