Context Navigation

← Previous Period
Next Period →

Timeline

01/26/11:

23:42 Changeset [76766] by ossy@webkit.org

Unreviewed.

[Qt] Update test expectations after r76726.

platform/qt/fast/lists/002-vertical-expected.checksum:
platform/qt/fast/lists/002-vertical-expected.png:
platform/qt/fast/lists/002-vertical-expected.txt:
platform/qt/fast/lists/003-vertical-expected.checksum:
platform/qt/fast/lists/003-vertical-expected.png:
platform/qt/fast/lists/003-vertical-expected.txt:
platform/qt/fast/overflow/overflow-rtl-vertical-expected.checksum:
platform/qt/fast/overflow/overflow-rtl-vertical-expected.png:
platform/qt/fast/overflow/overflow-rtl-vertical-expected.txt:
platform/qt/fast/table/028-vertical-expected.checksum:
platform/qt/fast/table/028-vertical-expected.png:
platform/qt/fast/table/028-vertical-expected.txt:
platform/qt/fast/table/border-collapsing/003-vertical-expected.checksum:
platform/qt/fast/table/border-collapsing/003-vertical-expected.png:
platform/qt/fast/table/border-collapsing/003-vertical-expected.txt:
platform/qt/fast/table/height-percent-test-vertical-expected.txt:

23:14 Changeset [76765] by yuzo@google.com

2011-01-26 Yuzo Fujishima <yuzo@google.com>

Unreviewed Chromium test expectation change.

Update test expectations for r76743

platform/chromium-linux/css1/box_properties/clear_float-expected.checksum:
platform/chromium-linux/css1/box_properties/clear_float-expected.png:
platform/chromium-linux/css1/box_properties/float_elements_in_series-expected.checksum:
platform/chromium-linux/css1/box_properties/float_elements_in_series-expected.png:
platform/chromium-linux/css1/box_properties/float_on_text_elements-expected.checksum:
platform/chromium-linux/css1/box_properties/float_on_text_elements-expected.png:
platform/chromium-linux/css2.1/t0905-c5525-fltwidth-00-c-g-expected.checksum:
platform/chromium-linux/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png:
platform/chromium-linux/fast/multicol/shadow-breaking-expected.checksum:
platform/chromium-linux/fast/multicol/shadow-breaking-expected.png: Added.
platform/chromium-linux/fast/repaint/line-flow-with-floats-1-expected.checksum:
platform/chromium-linux/fast/repaint/line-flow-with-floats-1-expected.png:
platform/chromium-linux/fast/repaint/line-flow-with-floats-10-expected.checksum:
platform/chromium-linux/fast/repaint/line-flow-with-floats-10-expected.png:
platform/chromium-linux/fast/repaint/line-flow-with-floats-2-expected.checksum:
platform/chromium-linux/fast/repaint/line-flow-with-floats-2-expected.png:
platform/chromium-linux/fast/repaint/line-flow-with-floats-3-expected.checksum:
platform/chromium-linux/fast/repaint/line-flow-with-floats-3-expected.png:
platform/chromium-linux/fast/repaint/line-flow-with-floats-4-expected.checksum:
platform/chromium-linux/fast/repaint/line-flow-with-floats-4-expected.png:
platform/chromium-linux/fast/repaint/line-flow-with-floats-5-expected.checksum:
platform/chromium-linux/fast/repaint/line-flow-with-floats-5-expected.png:
platform/chromium-linux/fast/repaint/line-flow-with-floats-6-expected.checksum:
platform/chromium-linux/fast/repaint/line-flow-with-floats-6-expected.png:
platform/chromium-linux/fast/repaint/line-flow-with-floats-7-expected.checksum:
platform/chromium-linux/fast/repaint/line-flow-with-floats-7-expected.png:
platform/chromium-linux/fast/repaint/line-flow-with-floats-8-expected.checksum:
platform/chromium-linux/fast/repaint/line-flow-with-floats-8-expected.png:
platform/chromium-linux/svg/custom/svg-fonts-in-html-expected.checksum:
platform/chromium-linux/svg/custom/svg-fonts-in-html-expected.png:
platform/chromium-linux/tables/mozilla/marvin/x_tr_align_justify-expected.checksum:
platform/chromium-linux/tables/mozilla/marvin/x_tr_align_justify-expected.png:
platform/chromium-mac/css1/box_properties/clear_float-expected.checksum: Added.
platform/chromium-mac/css1/box_properties/clear_float-expected.png: Added.
platform/chromium-mac/css1/box_properties/float_on_text_elements-expected.checksum: Added.
platform/chromium-mac/css1/box_properties/float_on_text_elements-expected.png: Added.
platform/chromium-mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.checksum: Added.
platform/chromium-mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png: Added.
platform/chromium-mac/fast/multicol/shadow-breaking-expected.checksum: Added.
platform/chromium-mac/fast/multicol/shadow-breaking-expected.png: Added.
platform/chromium-mac/fast/repaint/line-flow-with-floats-1-expected.checksum:
platform/chromium-mac/fast/repaint/line-flow-with-floats-1-expected.png:
platform/chromium-mac/fast/repaint/line-flow-with-floats-10-expected.checksum:
platform/chromium-mac/fast/repaint/line-flow-with-floats-10-expected.png:
platform/chromium-mac/fast/repaint/line-flow-with-floats-2-expected.checksum:
platform/chromium-mac/fast/repaint/line-flow-with-floats-2-expected.png:
platform/chromium-mac/fast/repaint/line-flow-with-floats-3-expected.checksum:
platform/chromium-mac/fast/repaint/line-flow-with-floats-3-expected.png:
platform/chromium-mac/fast/repaint/line-flow-with-floats-4-expected.checksum:
platform/chromium-mac/fast/repaint/line-flow-with-floats-4-expected.png:
platform/chromium-mac/fast/repaint/line-flow-with-floats-5-expected.checksum:
platform/chromium-mac/fast/repaint/line-flow-with-floats-5-expected.png:
platform/chromium-mac/fast/repaint/line-flow-with-floats-6-expected.checksum:
platform/chromium-mac/fast/repaint/line-flow-with-floats-6-expected.png:
platform/chromium-mac/fast/repaint/line-flow-with-floats-7-expected.checksum:
platform/chromium-mac/fast/repaint/line-flow-with-floats-7-expected.png:
platform/chromium-mac/fast/repaint/line-flow-with-floats-8-expected.checksum:
platform/chromium-mac/fast/repaint/line-flow-with-floats-8-expected.png:
platform/chromium-mac/svg/custom/svg-fonts-in-html-expected.checksum:
platform/chromium-mac/svg/custom/svg-fonts-in-html-expected.png:
platform/chromium-win/css1/box_properties/clear_float-expected.checksum:
platform/chromium-win/css1/box_properties/clear_float-expected.png:
platform/chromium-win/css1/box_properties/float_elements_in_series-expected.checksum:
platform/chromium-win/css1/box_properties/float_elements_in_series-expected.png:
platform/chromium-win/css1/box_properties/float_on_text_elements-expected.checksum:
platform/chromium-win/css1/box_properties/float_on_text_elements-expected.png:
platform/chromium-win/css2.1/t0905-c5525-fltwidth-00-c-g-expected.checksum:
platform/chromium-win/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png:
platform/chromium-win/fast/multicol/shadow-breaking-expected.checksum:
platform/chromium-win/fast/multicol/shadow-breaking-expected.png:
platform/chromium-win/fast/repaint/line-flow-with-floats-1-expected.checksum:
platform/chromium-win/fast/repaint/line-flow-with-floats-1-expected.png:
platform/chromium-win/fast/repaint/line-flow-with-floats-10-expected.checksum:
platform/chromium-win/fast/repaint/line-flow-with-floats-10-expected.png:
platform/chromium-win/fast/repaint/line-flow-with-floats-2-expected.checksum:
platform/chromium-win/fast/repaint/line-flow-with-floats-2-expected.png:
platform/chromium-win/fast/repaint/line-flow-with-floats-3-expected.checksum:
platform/chromium-win/fast/repaint/line-flow-with-floats-3-expected.png:
platform/chromium-win/fast/repaint/line-flow-with-floats-4-expected.checksum:
platform/chromium-win/fast/repaint/line-flow-with-floats-4-expected.png:
platform/chromium-win/fast/repaint/line-flow-with-floats-5-expected.checksum:
platform/chromium-win/fast/repaint/line-flow-with-floats-5-expected.png:
platform/chromium-win/fast/repaint/line-flow-with-floats-6-expected.checksum:
platform/chromium-win/fast/repaint/line-flow-with-floats-6-expected.png:
platform/chromium-win/fast/repaint/line-flow-with-floats-7-expected.checksum:
platform/chromium-win/fast/repaint/line-flow-with-floats-7-expected.png:
platform/chromium-win/fast/repaint/line-flow-with-floats-8-expected.checksum:
platform/chromium-win/fast/repaint/line-flow-with-floats-8-expected.png:
platform/chromium-win/svg/custom/svg-fonts-in-html-expected.checksum:
platform/chromium-win/svg/custom/svg-fonts-in-html-expected.png:
platform/chromium-win/tables/mozilla/marvin/x_tr_align_justify-expected.checksum:
platform/chromium-win/tables/mozilla/marvin/x_tr_align_justify-expected.png:

22:41 Changeset [76764] by aroben@apple.com

Don't create the Direct3D device before it's first needed

We only need the device once we decide to render. There's no point in creating it before
then.

Reviewed by Sam Weinig.

platform/graphics/ca/win/CACFLayerTreeHost.cpp:

(WebCore::CACFLayerTreeHost::setWindow): Removed the call to createRenderer() from here.
We already have code to create it when we first try to draw.
(WebCore::CACFLayerTreeHost::createRenderer): Flush the context after we set our layer's
bounds so that the bounds will take effect the next time we render (which could be just
after this function returns).

22:40 Changeset [76763] by aroben@apple.com

Add assertions that CACFLayerTreeHost gains and loses an HWND only once

CACFLayerTreeHost doesn't support any other use pattern.

Reviewed by Sam Weinig.

platform/graphics/ca/win/CACFLayerTreeHost.cpp:

(WebCore::CACFLayerTreeHost::CACFLayerTreeHost): Initialize new member.
(WebCore::CACFLayerTreeHost::setWindow): Assert that we transition from not having a window,
to having a window, to not having a window just once over the lifetime of this object.

platform/graphics/ca/win/CACFLayerTreeHost.h: Added m_state.

22:40 Changeset [76762] by aroben@apple.com

Notify layers that their animations have started when we flush the context, not when we render

r76372 separated context flushing from rendering, but this bit of code got left behind.

Reviewed by Sam Weinig.

platform/graphics/ca/win/CACFLayerTreeHost.cpp:

(WebCore::CACFLayerTreeHost::render): Moved code to notify the layers from here to
notifyAnimationsStarted.
(WebCore::CACFLayerTreeHost::flushPendingLayerChangesNow): Added a call to
notifyAnimationsStarted after we flush the context.
(WebCore::CACFLayerTreeHost::notifyAnimationsStarted): Added. Code came from render. Changed
to call PlatformCALayer::animationStarted rather than calling through to the client
directly.

platform/graphics/ca/win/CACFLayerTreeHost.h: Added notifyAniamtionsStarted.

22:39 Changeset [76761] by aroben@apple.com

Small cleanup in MediaPlayerPrivateFullscreenWindow

Reviewed by Sam Weinig.

platform/graphics/win/MediaPlayerPrivateFullscreenWindow.cpp:

(WebCore::MediaPlayerPrivateFullscreenWindow::~MediaPlayerPrivateFullscreenWindow): Moved
code here from close(), since this was the only place that called it after the following
change to createWindow.
(WebCore::MediaPlayerPrivateFullscreenWindow::createWindow): Replaced code that handled the
case where we had already created the window with an assertion that we have not already done
so. Our single caller (FullscreenVideoController) did not require this behavior.

platform/graphics/win/MediaPlayerPrivateFullscreenWindow.h: Removed layerView.

22:31 Changeset [76760] by mitz@apple.com

Updated results for the html.css changes in r76726. The old results were prepared before
r76726.

platform/mac/fast/text/justify-ideograph-vertical-expected.checksum:
platform/mac/fast/text/justify-ideograph-vertical-expected.png:
platform/mac/fast/text/justify-ideograph-vertical-expected.txt:

22:30 Changeset [76759] by yuzo@google.com

2011-01-26 Yuzo Fujishima <yuzo@google.com>

Unreviewed Chromium test expectation change.

fast/text/justify-ideograph-vertical.html crashes on LINUX.

platform/chromium/test_expectations.txt:

21:59 Changeset [76758] by yuzo@google.com

2011-01-26 Yuzo Fujishima <yuzo@google.com>

Unreviewed Chromium test expectation change.

Mark the tests started failing at http://trac.webkit.org/changeset/76726 as such.

platform/chromium/test_expectations.txt:

21:12 Changeset [76757] by weinig@apple.com

Move ScrollView scroll wheel code to ScrollAnimator.

Reviewed by Adam Roben.

platform/ScrollAnimator.cpp:

(WebCore::ScrollAnimator::handleWheelEvent):

platform/ScrollAnimator.h:

Moved implementation of handleWheelEvent from ScrollView::wheelEvent.

platform/ScrollView.cpp:

(WebCore::ScrollView::wheelEvent):
Call down to the ScrollableArea.

platform/ScrollableArea.cpp:

(WebCore::ScrollableArea::handleWheelEvent):
Call down to the ScrollAnimator.

platform/ScrollableArea.h:

(WebCore::ScrollableArea::scrollPosition):
(WebCore::ScrollableArea::minimumScrollPosition):
(WebCore::ScrollableArea::maximumScrollPosition):
(WebCore::ScrollableArea::visibleContentRect):
(WebCore::ScrollableArea::visibleHeight):
(WebCore::ScrollableArea::visibleWidth):
Add functions needed to implement wheel event in the animator.

20:57 Changeset [76756] by ddkilzer@apple.com

<http://webkit.org/b/53192> Add experimental support for HTTP pipelining in CFNetwork
<rdar://problem/8821760>

Reviewed by Antti Koivisto.

Source/WebCore:

This adds support for HTTP pipelining in CFNetwork, but does not
enable it. To enable it post-SnowLeopard, use this command:

defaults write BUNDLE.ID WebKitEnableHTTPPipelining -bool YES

Once enabled, it is possible to force the same load priority
(high) to be sent to CFNetwork to allow WebCore to handle the
scheduling:

defaults write BUNDLE.ID WebKitForceHTTPPipeliningPriorityHigh -bool YES

WebCore.exp.in: Export _wkGetHTTPPipeliningPriority and

_wkSetHTTPPipeliningPriority.

loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::makeCrossOriginAccessRequestWithPreflight):
Copy the priority to preflightRequest.

loader/ResourceLoadScheduler.cpp:

(WebCore::ResourceLoadScheduler::scheduleLoad): Refactored code
at the end of the method to use an early return.

loader/cache/CachedResourceRequest.cpp:

(WebCore::CachedResourceRequest::load): Set the priority on the
ResourceRequest object based on the priority of the
CachedResourceRequest before calling
ResourceLoadScheduler::scheduleSubresourceLoad().

loader/icon/IconLoader.cpp:

(WebCore::IconLoader::startLoading): Create a ResourceRequest
object and set its priority to ResourceLoadPriorityLow before
passing it to ResourceLoadScheduler::scheduleSubresourceLoad().

platform/mac/WebCoreSystemInterface.h:

(wkGetHTTPPipeliningPriority): Added.
(wkSetHTTPPipeliningPriority): Added.

platform/mac/WebCoreSystemInterface.mm:

(wkGetHTTPPipeliningPriority): Added.
(wkSetHTTPPipeliningPriority): Added.

platform/network/ResourceRequestBase.cpp:

(WebCore::ResourceRequestBase::adopt): Set m_priority when
adopting a CrossThreadResourceRequestData.
(WebCore::ResourceRequestBase::copyData): Set m_priority when
creating a CrossThreadResourceRequestData.
(WebCore::ResourceRequestBase::priority): Added.
(WebCore::ResourceRequestBase::setPriority): Added.
(WebCore::equalIgnoringHeaderFields): Priorities must match when
comparing two ResourceRequest objects.

platform/network/ResourceRequestBase.h:

(WebCore::ResourceRequestBase::ResourceRequestBase): Set default
priority of new objects to ResourceLoadPriorityLow.
(WebCore::ResourceRequestBase::priority): Added declaration.
(WebCore::ResourceRequestBase::setPriority): Added declaration.
(WebCore::isHTTPPipeliningEnabled): Added.
(WebCore::shouldUseHTTPPipeliningPriority): Added.

platform/network/cf/ResourceRequestCFNet.cpp: Updated so that

Mac OS X and Windows share code.
(WebCore::initializeMaximumHTTPConnectionCountPerHost): Always
set the HTTP connection count per host, but return an
'unlimited' value when using HTTP pipelining. This method used
to be defined in ResourceRequestMac.mm for Mac OS X.
(WebCore::readBooleanPreference): Added. Helper method for
reading boolean user defaults.
(WebCore::isHTTPPipeliningEnabled): Returns value of user
default key WebKitEnableHTTPPipelining, or false if not set.
(WebCore::shouldUseHTTPPipeliningPriority): Returns value of
user default key WebKitForceHTTPPipeliningPriorityHigh, or false
if not set.

platform/network/cf/ResourceRequestCFNet.h: Updated so that

Mac OS X and Windows share code. Fixed indentation.
(WebCore::mapHTTPPipeliningPriorityToResourceLoadPriority): Added.
(WebCore::mapResourceLoadPriorityToHTTPPipeliningPriority): Added.

platform/network/mac/ResourceRequestMac.mm:

(WebCore::ResourceRequest::doUpdatePlatformRequest): Update
HTTP pipelining priority on NSMutableFURLRequest object.
(WebCore::ResourceRequest::doUpdateResourceRequest): Update
m_priority from the NSURLRequest object.
(WebCore::initializeMaximumHTTPConnectionCountPerHost): Removed.
Code is now shared with Windows in ResourceRequestCFNet.cpp.

Source/WebKit/mac:

WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface): Added initialization for
GetHTTPPipeliningPriority and SetHTTPPipeliningPriority.

Source/WebKit2:

WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface): Added initialization for
GetHTTPPipeliningPriority and SetHTTPPipeliningPriority.

WebKitLibraries:

WebKitSystemInterface.h:

New methods added for HTTP pipelining support.

(WKGetHTTPPipeliningPriority): Added.
(WKSetHTTPPipeliningPriority): Added.

Unrelated methods added after updating the header.

(WKMakeScrollbarPainter): Added.
(WKScrollbarPainterPaint): Added.

libWebKitSystemInterfaceLeopard.a: Updated.
libWebKitSystemInterfaceSnowLeopard.a: Updated.

20:36 Changeset [76755] by rniwa@webkit.org

2011-01-26 Ryosuke Niwa <rniwa@webkit.org>

Reviewed Chromium Mac rebaselines for r76726.

platform/chromium-mac/fast/blockflow/vertical-baseline-alignment-expected.checksum: Added.
platform/chromium-mac/fast/blockflow/vertical-baseline-alignment-expected.png: Added.
platform/chromium-mac/fast/multicol/vertical-rl: Added.
platform/chromium-mac/fast/multicol/vertical-rl/column-break-with-balancing-expected.txt: Added.
platform/chromium-mac/fast/table/028-vertical-expected.checksum: Added.
platform/chromium-mac/fast/table/028-vertical-expected.png: Added.
platform/chromium-mac/fast/text/complex-text-opacity-expected.checksum: Added.
platform/chromium-mac/fast/text/complex-text-opacity-expected.png: Added.

20:08 Changeset [76754] by bdakin@apple.com

Fix for <rdar://problem/8895140> Adopt WKScrollbar metrics
when using WKScrollbars.

Reviewed by Darin Adler.

Source/WebCore:

New WebKitSystemInterface Functionality.

WebCore.exp.in:
platform/mac/WebCoreSystemInterface.h:
platform/mac/WebCoreSystemInterface.mm:

Some of the terrible static arrays are now only needed in the
old non-WK code, so they are if-def'd now.

platform/mac/ScrollbarThemeMac.mm:

Just patching this function in a better way than I did
before.
(WebCore::updateArrowPlacement):

Call into WK for the right values.
(WebCore::ScrollbarThemeMac::scrollbarThickness):
(WebCore::ScrollbarThemeMac::hasThumb):
(WebCore::ScrollbarThemeMac::minimumThumbLength):

Return false if there are no buttons.
(WebCore::ScrollbarThemeMac::hasButtons):

Return an empty IntRect if there are not buttons.
(WebCore::buttonRepaintRect):

Source/WebKit/mac:

WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

Source/WebKit2:

WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

20:07 Changeset [76753] by rniwa@webkit.org

2011-01-26 Ryosuke Niwa <rniwa@webkit.org>

Reviewed Chromium Windows/Linux rebaselines for r76726.

platform/chromium-linux/fast/multicol/vertical-rl/float-multicol-expected.checksum: Added.
platform/chromium-linux/fast/multicol/vertical-rl/float-multicol-expected.png: Added.
platform/chromium-linux/fast/multicol/vertical-rl/float-paginate-complex-expected.checksum: Added.
platform/chromium-linux/fast/multicol/vertical-rl/float-paginate-complex-expected.png: Added.
platform/chromium-linux/fast/multicol/vertical-rl/float-paginate-expected.checksum: Added.
platform/chromium-linux/fast/multicol/vertical-rl/float-paginate-expected.png: Added.
platform/chromium-linux/fast/multicol/vertical-rl/nested-columns-expected.checksum: Added.
platform/chromium-linux/fast/multicol/vertical-rl/nested-columns-expected.png: Added.
platform/chromium-linux/fast/multicol/vertical-rl/unsplittable-inline-block-expected.checksum: Added.
platform/chromium-linux/fast/multicol/vertical-rl/unsplittable-inline-block-expected.png: Added.
platform/chromium-linux/fast/table/028-vertical-expected.checksum:
platform/chromium-linux/fast/table/028-vertical-expected.png:
platform/chromium-linux/fast/table/border-collapsing/003-vertical-expected.checksum:
platform/chromium-linux/fast/table/border-collapsing/003-vertical-expected.png:
platform/chromium-win/fast/multicol/vertical-rl/float-multicol-expected.checksum: Added.
platform/chromium-win/fast/multicol/vertical-rl/float-multicol-expected.png: Added.
platform/chromium-win/fast/multicol/vertical-rl/float-multicol-expected.txt: Added.
platform/chromium-win/fast/multicol/vertical-rl/float-paginate-complex-expected.checksum: Added.
platform/chromium-win/fast/multicol/vertical-rl/float-paginate-complex-expected.png: Added.
platform/chromium-win/fast/multicol/vertical-rl/float-paginate-complex-expected.txt: Added.
platform/chromium-win/fast/multicol/vertical-rl/float-paginate-expected.checksum: Added.
platform/chromium-win/fast/multicol/vertical-rl/float-paginate-expected.png: Added.
platform/chromium-win/fast/multicol/vertical-rl/float-paginate-expected.txt: Added.
platform/chromium-win/fast/multicol/vertical-rl/nested-columns-expected.checksum: Added.
platform/chromium-win/fast/multicol/vertical-rl/nested-columns-expected.png: Added.
platform/chromium-win/fast/multicol/vertical-rl/nested-columns-expected.txt: Added.
platform/chromium-win/fast/multicol/vertical-rl/unsplittable-inline-block-expected.checksum: Added.
platform/chromium-win/fast/multicol/vertical-rl/unsplittable-inline-block-expected.png: Added.
platform/chromium-win/fast/multicol/vertical-rl/unsplittable-inline-block-expected.txt: Added.
platform/chromium-win/fast/table/028-vertical-expected.checksum:
platform/chromium-win/fast/table/028-vertical-expected.png:
platform/chromium-win/fast/table/028-vertical-expected.txt:
platform/chromium-win/fast/table/border-collapsing/003-vertical-expected.checksum:
platform/chromium-win/fast/table/border-collapsing/003-vertical-expected.png:
platform/chromium-win/fast/table/border-collapsing/003-vertical-expected.txt:

20:04 Changeset [76752] by rniwa@webkit.org

2011-01-26 Ryosuke Niwa <rniwa@webkit.org>

Reviewed Chromium Windows/Linux rebaselines for r76726.

platform/chromium-linux/fast/multicol/vertical-lr/float-paginate-complex-expected.checksum: Added.
platform/chromium-linux/fast/multicol/vertical-lr/float-paginate-complex-expected.png: Added.
platform/chromium-linux/fast/multicol/vertical-lr/float-paginate-expected.checksum: Added.
platform/chromium-linux/fast/multicol/vertical-lr/float-paginate-expected.png: Added.
platform/chromium-linux/fast/multicol/vertical-lr/nested-columns-expected.checksum: Added.
platform/chromium-linux/fast/multicol/vertical-lr/nested-columns-expected.png: Added.
platform/chromium-linux/fast/multicol/vertical-lr/unsplittable-inline-block-expected.checksum: Added.
platform/chromium-linux/fast/multicol/vertical-lr/unsplittable-inline-block-expected.png: Added.
platform/chromium-linux/fast/multicol/vertical-rl: Added.
platform/chromium-linux/fast/multicol/vertical-rl/border-padding-pagination-expected.checksum: Added.
platform/chromium-linux/fast/multicol/vertical-rl/border-padding-pagination-expected.png: Added.
platform/chromium-linux/fast/multicol/vertical-rl/column-break-with-balancing-expected.checksum: Added.
platform/chromium-linux/fast/multicol/vertical-rl/column-break-with-balancing-expected.png: Added.
platform/chromium-linux/fast/multicol/vertical-rl/column-count-with-rules-expected.checksum: Added.
platform/chromium-linux/fast/multicol/vertical-rl/column-count-with-rules-expected.png: Added.
platform/chromium-linux/fast/multicol/vertical-rl/column-rules-expected.checksum: Added.
platform/chromium-linux/fast/multicol/vertical-rl/column-rules-expected.png: Added.
platform/chromium-linux/fast/multicol/vertical-rl/float-avoidance-expected.checksum: Added.
platform/chromium-linux/fast/multicol/vertical-rl/float-avoidance-expected.png: Added.
platform/chromium-win/fast/multicol/vertical-lr/float-paginate-complex-expected.checksum: Added.
platform/chromium-win/fast/multicol/vertical-lr/float-paginate-complex-expected.png: Added.
platform/chromium-win/fast/multicol/vertical-lr/float-paginate-complex-expected.txt: Added.
platform/chromium-win/fast/multicol/vertical-lr/float-paginate-expected.checksum: Added.
platform/chromium-win/fast/multicol/vertical-lr/float-paginate-expected.png: Added.
platform/chromium-win/fast/multicol/vertical-lr/float-paginate-expected.txt: Added.
platform/chromium-win/fast/multicol/vertical-lr/nested-columns-expected.checksum: Added.
platform/chromium-win/fast/multicol/vertical-lr/nested-columns-expected.png: Added.
platform/chromium-win/fast/multicol/vertical-lr/nested-columns-expected.txt: Added.
platform/chromium-win/fast/multicol/vertical-lr/unsplittable-inline-block-expected.checksum: Added.
platform/chromium-win/fast/multicol/vertical-lr/unsplittable-inline-block-expected.png: Added.
platform/chromium-win/fast/multicol/vertical-lr/unsplittable-inline-block-expected.txt: Added.
platform/chromium-win/fast/multicol/vertical-rl: Added.
platform/chromium-win/fast/multicol/vertical-rl/border-padding-pagination-expected.checksum: Added.
platform/chromium-win/fast/multicol/vertical-rl/border-padding-pagination-expected.png: Added.
platform/chromium-win/fast/multicol/vertical-rl/border-padding-pagination-expected.txt: Added.
platform/chromium-win/fast/multicol/vertical-rl/column-break-with-balancing-expected.checksum: Added.
platform/chromium-win/fast/multicol/vertical-rl/column-break-with-balancing-expected.png: Added.
platform/chromium-win/fast/multicol/vertical-rl/column-break-with-balancing-expected.txt: Added.
platform/chromium-win/fast/multicol/vertical-rl/column-count-with-rules-expected.checksum: Added.
platform/chromium-win/fast/multicol/vertical-rl/column-count-with-rules-expected.png: Added.
platform/chromium-win/fast/multicol/vertical-rl/column-count-with-rules-expected.txt: Added.
platform/chromium-win/fast/multicol/vertical-rl/column-rules-expected.checksum: Added.
platform/chromium-win/fast/multicol/vertical-rl/column-rules-expected.png: Added.
platform/chromium-win/fast/multicol/vertical-rl/column-rules-expected.txt: Added.
platform/chromium-win/fast/multicol/vertical-rl/float-avoidance-expected.checksum: Added.
platform/chromium-win/fast/multicol/vertical-rl/float-avoidance-expected.png: Added.
platform/chromium-win/fast/multicol/vertical-rl/float-avoidance-expected.txt: Added.

19:59 Changeset [76751] by rniwa@webkit.org

2011-01-26 Ryosuke Niwa <rniwa@webkit.org>

Reviewed Chromium Windows/Linux rebaselines for r76726.

platform/chromium-linux/fast/blockflow/vertical-baseline-alignment-expected.checksum:
platform/chromium-linux/fast/blockflow/vertical-baseline-alignment-expected.png:
platform/chromium-linux/fast/lists/002-vertical-expected.checksum:
platform/chromium-linux/fast/lists/002-vertical-expected.png:
platform/chromium-linux/fast/lists/002-vertical-expected.txt: Removed.
platform/chromium-linux/fast/lists/003-vertical-expected.checksum:
platform/chromium-linux/fast/lists/003-vertical-expected.png:
platform/chromium-linux/fast/multicol/vertical-lr: Added.
platform/chromium-linux/fast/multicol/vertical-lr/border-padding-pagination-expected.checksum: Added.
platform/chromium-linux/fast/multicol/vertical-lr/border-padding-pagination-expected.png: Added.
platform/chromium-linux/fast/multicol/vertical-lr/column-break-with-balancing-expected.checksum: Added.
platform/chromium-linux/fast/multicol/vertical-lr/column-break-with-balancing-expected.png: Added.
platform/chromium-linux/fast/multicol/vertical-lr/column-count-with-rules-expected.checksum: Added.
platform/chromium-linux/fast/multicol/vertical-lr/column-count-with-rules-expected.png: Added.
platform/chromium-linux/fast/multicol/vertical-lr/column-rules-expected.checksum: Added.
platform/chromium-linux/fast/multicol/vertical-lr/column-rules-expected.png: Added.
platform/chromium-linux/fast/multicol/vertical-lr/float-avoidance-expected.checksum: Added.
platform/chromium-linux/fast/multicol/vertical-lr/float-avoidance-expected.png: Added.
platform/chromium-linux/fast/multicol/vertical-lr/float-multicol-expected.checksum: Added.
platform/chromium-linux/fast/multicol/vertical-lr/float-multicol-expected.png: Added.
platform/chromium-win/fast/blockflow/vertical-baseline-alignment-expected.checksum:
platform/chromium-win/fast/blockflow/vertical-baseline-alignment-expected.png:
platform/chromium-win/fast/blockflow/vertical-baseline-alignment-expected.txt:
platform/chromium-win/fast/lists/002-vertical-expected.checksum:
platform/chromium-win/fast/lists/002-vertical-expected.png:
platform/chromium-win/fast/lists/002-vertical-expected.txt:
platform/chromium-win/fast/lists/003-vertical-expected.checksum:
platform/chromium-win/fast/lists/003-vertical-expected.png:
platform/chromium-win/fast/lists/003-vertical-expected.txt:
platform/chromium-win/fast/multicol/vertical-lr: Added.
platform/chromium-win/fast/multicol/vertical-lr/border-padding-pagination-expected.checksum: Added.
platform/chromium-win/fast/multicol/vertical-lr/border-padding-pagination-expected.png: Added.
platform/chromium-win/fast/multicol/vertical-lr/border-padding-pagination-expected.txt: Added.
platform/chromium-win/fast/multicol/vertical-lr/column-break-with-balancing-expected.checksum: Added.
platform/chromium-win/fast/multicol/vertical-lr/column-break-with-balancing-expected.png: Added.
platform/chromium-win/fast/multicol/vertical-lr/column-break-with-balancing-expected.txt: Added.
platform/chromium-win/fast/multicol/vertical-lr/column-count-with-rules-expected.checksum: Added.
platform/chromium-win/fast/multicol/vertical-lr/column-count-with-rules-expected.png: Added.
platform/chromium-win/fast/multicol/vertical-lr/column-count-with-rules-expected.txt: Added.
platform/chromium-win/fast/multicol/vertical-lr/column-rules-expected.checksum: Added.
platform/chromium-win/fast/multicol/vertical-lr/column-rules-expected.png: Added.
platform/chromium-win/fast/multicol/vertical-lr/column-rules-expected.txt: Added.
platform/chromium-win/fast/multicol/vertical-lr/float-avoidance-expected.checksum: Added.
platform/chromium-win/fast/multicol/vertical-lr/float-avoidance-expected.png: Added.
platform/chromium-win/fast/multicol/vertical-lr/float-avoidance-expected.txt: Added.
platform/chromium-win/fast/multicol/vertical-lr/float-multicol-expected.checksum: Added.
platform/chromium-win/fast/multicol/vertical-lr/float-multicol-expected.png: Added.
platform/chromium-win/fast/multicol/vertical-lr/float-multicol-expected.txt: Added.

19:13 Changeset [76750] by bweinstein@apple.com

Rebaseline Windows fast/blockfow results after r76726.

platform/win/fast/blockflow/Kusa-Makura-background-canvas-expected.txt:
platform/win/fast/blockflow/vertical-baseline-alignment-expected.txt:

18:46 Changeset [76749] by mrobinson@webkit.org

2011-01-26 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Pixel dumps do not include scrollbars in output images
https://bugs.webkit.org/show_bug.cgi?id=53216

Update expected results which should show scrollbars.

platform/gtk/css2.1/t0803-c5502-mrgn-r-02-c-expected.checksum:
platform/gtk/css2.1/t0803-c5502-mrgn-r-02-c-expected.png:
platform/gtk/css2.1/t0803-c5505-mrgn-02-c-expected.checksum:
platform/gtk/css2.1/t0803-c5505-mrgn-02-c-expected.png:
platform/gtk/css2.1/t080301-c411-vt-mrgn-00-b-expected.checksum:
platform/gtk/css2.1/t080301-c411-vt-mrgn-00-b-expected.png:
platform/gtk/css2.1/t0905-c5525-fltclr-00-c-ag-expected.checksum:
platform/gtk/css2.1/t0905-c5525-fltclr-00-c-ag-expected.png:
platform/gtk/css2.1/t0905-c5525-fltmrgn-00-c-ag-expected.checksum:
platform/gtk/css2.1/t0905-c5525-fltmrgn-00-c-ag-expected.png:
platform/gtk/css2.1/t0905-c5525-fltwidth-00-c-g-expected.checksum:
platform/gtk/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png:
platform/gtk/css2.1/t0905-c5526-fltclr-00-c-ag-expected.checksum:
platform/gtk/css2.1/t0905-c5526-fltclr-00-c-ag-expected.png:
platform/gtk/css2.1/t1002-c5523-width-02-b-g-expected.checksum:
platform/gtk/css2.1/t1002-c5523-width-02-b-g-expected.png:
platform/gtk/css2.1/t1202-counters-08-b-expected.checksum:
platform/gtk/css2.1/t1202-counters-08-b-expected.png:
platform/gtk/css2.1/t1202-counters-09-b-expected.checksum:
platform/gtk/css2.1/t1202-counters-09-b-expected.png:
platform/gtk/css2.1/t140201-c535-bg-fixd-00-b-g-expected.checksum:
platform/gtk/css2.1/t140201-c535-bg-fixd-00-b-g-expected.png:
platform/gtk/css2.1/t140201-c537-bgfxps-00-c-ag-expected.checksum:
platform/gtk/css2.1/t140201-c537-bgfxps-00-c-ag-expected.png:
platform/gtk/css2.1/t1508-c527-font-07-b-expected.checksum:
platform/gtk/css2.1/t1508-c527-font-07-b-expected.png:

2011-01-26 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Pixel dumps do not include scrollbars in output images
https://bugs.webkit.org/show_bug.cgi?id=53216

Show scrollbars in pixel dumps. This will fix pixel dumps for tests
that have scrollbars.

DumpRenderTree/gtk/PixelDumpSupportGtk.cpp: (createBitmapContextFromWebView): Take the snapshot of the containing GtkScrolledWindow instead of the web view itself.

18:20 Changeset [76748] by mrobinson@webkit.org

2011-01-26 Martin Robinson <mrobinson@igalia.com>

[GTK] Text input controls do not react properly to CSS styling
https://bugs.webkit.org/show_bug.cgi?id=40855

Unskip tests which were previously skipped due to issue #40855.
The bug is closed now, so it's safe to rebaseline the tests and
unskip them.

platform/gtk/Skipped: Unskip tests.
platform/gtk/fast/forms/basic-selects-expected.checksum:
platform/gtk/fast/forms/basic-selects-expected.png:
platform/gtk/fast/forms/basic-selects-expected.txt:
platform/gtk/fast/forms/basic-textareas-quirks-expected.checksum:
platform/gtk/fast/forms/basic-textareas-quirks-expected.png:
platform/gtk/fast/forms/basic-textareas-quirks-expected.txt:

18:02 Changeset [76747] by mrobinson@webkit.org

2011-01-26 Martin Robinson <mrobinson@igalia.com>

[GTK] media/unsupported-rtsp.html fails after timing out
https://bugs.webkit.org/show_bug.cgi?id=53056

platform/gtk/Skipped: Update the skipped list to explain why this test is skipped and should remain skipped.

18:01 Changeset [76746] by dpranke@chromium.org

2011-01-26 Dirk Pranke <dpranke@chromium.org>

Reviewed by Mihai Parparita.

Fix regression introduced in r76322 ... new-run-webkit-tests
was attempting to save the image diff output as a UTF-8-encoded
file.

https://bugs.webkit.org/show_bug.cgi?id=53210

Scripts/webkitpy/layout_tests/port/webkit.py:

17:55 Changeset [76745] by weinig@apple.com

Add events to represent the start/end of a gesture scroll
https://bugs.webkit.org/show_bug.cgi?id=53215

Reviewed by Maciej Stachowiak.

Source/JavaScriptCore:

wtf/Platform.h: Add ENABLE for gesture events.

Source/WebCore:

WebCore.exp.in:

Add new file.

WebCore.xcodeproj/project.pbxproj:

Add new file.

page/EventHandler.cpp:

(WebCore::EventHandler::handleGestureEvent):

page/EventHandler.h:

Add entry point for handling gesture events.

platform/PlatformGestureEvent.h: Added.

(WebCore::PlatformGestureEvent::PlatformGestureEvent):
(WebCore::PlatformGestureEvent::type):
(WebCore::PlatformGestureEvent::position):
(WebCore::PlatformGestureEvent::globalPosition):
(WebCore::PlatformGestureEvent::timestamp):
Add platform agnostic representation of a gesture event.

Source/WebKit2:

Scripts/webkit2/messages.py:
Shared/WebEvent.h:

(WebKit::WebGestureEvent::WebGestureEvent):
(WebKit::WebGestureEvent::position):
(WebKit::WebGestureEvent::globalPosition):

Shared/WebEventConversion.cpp:

(WebKit::WebKit2PlatformGestureEvent::WebKit2PlatformGestureEvent):
(WebKit::platform):

Shared/WebEventConversion.h:
Shared/WebGestureEvent.cpp: Added.

(WebKit::WebGestureEvent::WebGestureEvent):
(WebKit::WebGestureEvent::encode):
(WebKit::WebGestureEvent::decode):
(WebKit::WebGestureEvent::isGestureEventType):

Shared/mac/WebEventFactory.h:
Shared/mac/WebEventFactory.mm:

(WebKit::gestureEventTypeForEvent):
(WebKit::WebEventFactory::createWebGestureEvent):

UIProcess/API/mac/WKView.mm:

(-[WKView shortCircuitedEndGestureWithEvent:]):
(-[WKView beginGestureWithEvent:]):
(-[WKView viewDidMoveToWindow]):

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::handleGestureEvent):
(WebKit::WebPageProxy::didReceiveEvent):

UIProcess/WebPageProxy.h:
WebKit2.xcodeproj/project.pbxproj:
WebProcess/WebPage/WebPage.cpp:

(WebKit::handleGestureEvent):
(WebKit::WebPage::gestureEvent):

WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.messages.in:

Pipe gesture events down to WebCore.

17:45 Changeset [76744] by tkent@chromium.org

2011-01-26 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[Chromium] WebFrame::forms() should not return empty WebFormElements
https://bugs.webkit.org/show_bug.cgi?id=53204

src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::forms):
- Should iterate by forms->length(), not the number of HTMLElements.
- Do not increment the index for "temp" if a node is not an HTMLElement.

17:39 Changeset [76743] by mitz@apple.com

<rdar://problem/8446709> Allow inter-ideograph justification for CJK
https://bugs.webkit.org/show_bug.cgi?id=53184

Reviewed by Dave Hyatt.

Source/WebCore:

Tests: fast/text/justify-ideograph-complex.html

fast/text/justify-ideograph-simple.html
fast/text/justify-ideograph-vertical.html

html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::drawTextInternal): Corrected the type of the third parameter
passed to the TextRun constructor and added the trailingExpansionBehavior parameter.

platform/graphics/Font.cpp:

(WebCore::Font::expansionOpportunityCount): Added. Returns the number of expansion opportunities
for text justification. On entry, isAfterExpansion says whether an expansion opportunity exists
before the first character. On return, isAfterExpansion says whether an expansion opportunity
exists after the last character.

platform/graphics/Font.h:
platform/graphics/GlyphBuffer.h:

(WebCore::GlyphBuffer::expandLastAdvance): Added.

platform/graphics/TextRun.h:

(WebCore::TextRun::TextRun): Added a TrailingExpansionBehavior parameter to the constructors.
Renamed padding to expansion.
(WebCore::TextRun::expansion): Renamed padding() to this.
(WebCore::TextRun::allowsTrailingExpansion): Added this accessor.

platform/graphics/WidthIterator.cpp:

(WebCore::WidthIterator::WidthIterator): Initialize m_isAfterExpansion. Use Font::expansionOpportunityCount()
and adjust the count if it includes a trailing expansion opportunity but the run disallows trailing
expansion.
(WebCore::WidthIterator::advance): Apply expansion before and after CJK ideographs.
(WebCore::WidthIterator::advanceOneCharacter): Changed to not clear the GlyphBuffer so that advance()
can expand the last advance if it is followed by a CJK ideograph.

platform/graphics/WidthIterator.h: Renamed m_padding to m_expansion and m_padPerSpace

to m_expansionPerOpportunity.

platform/graphics/chromium/FontChromiumWin.cpp: