Timeline


and

02/01/11:

23:06 Changeset [77365] by ossy@webkit.org
  • 3 edits in trunk/Source/WebKit2

Unreviewed.

Fix Qt build after r77339.

  • UIProcess/API/qt/qwkpage.cpp:

(QWKPagePrivate::enterAcceleratedCompositingMode):
(QWKPagePrivate::exitAcceleratedCompositingMode):

  • UIProcess/API/qt/qwkpage_p.h:
23:02 Changeset [77364] by commit-queue@webkit.org
  • 4 edits in trunk

2011-02-01 James Robinson <jamesr@chromium.org>

Reviewed by Adam Barth.

[v8] Increase V8 native->js recursion limit to match document.write() recursion limit
https://bugs.webkit.org/show_bug.cgi?id=53566

Unskip test that we now pass.

  • platform/chromium/test_expectations.txt:

2011-02-01 James Robinson <jamesr@chromium.org>

Reviewed by Adam Barth.

[v8] Increase V8 native->js recursion limit to match document.write() recursion limit
https://bugs.webkit.org/show_bug.cgi?id=53566

A recursion limit of 22 is necessary to pass fast/dom/Document/document-write-recursion.html.
Other than being large enough for this one test case, this limit is arbitrary.

  • bindings/v8/V8Proxy.h:
22:00 Changeset [77363] by ojan@chromium.org
  • 3 edits in trunk/Websites/bugs.webkit.org

2011-02-01 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

make draft comments focusable
https://bugs.webkit.org/show_bug.cgi?id=53554

Makes frozen draft comments focusable. The ones that are currently being edited are not.
I'm on the fence whether they should be, but this seems good enough for now.

  • code-review.js:
21:17 Changeset [77362] by ojan@chromium.org
  • 3 edits in trunk/Websites/bugs.webkit.org

2011-02-01 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

avoid jitter when loading the comments to a patch
https://bugs.webkit.org/show_bug.cgi?id=53570

  • code-review.js:
21:13 Changeset [77361] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-01 Adam Barth <abarth@webkit.org>

Reviewed by Andreas Kling.

Remove useless comment
https://bugs.webkit.org/show_bug.cgi?id=53549

The reason for this parameter is captured in
plugins/netscape-plugin-setwindow-size.html, which is a better place to
capture it than in this comment (which otherwise just re-iterates the
name of the parameter).

  • html/HTMLPlugInImageElement.cpp: (WebCore::HTMLPlugInImageElement::updateWidgetIfNecessary):
21:05 Changeset [77360] by ggaren@apple.com
  • 11 edits in trunk/Source/JavaScriptCore

2011-02-01 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r77297.
http://trac.webkit.org/changeset/77297
https://bugs.webkit.org/show_bug.cgi?id=53538

caused leopard crashes (Requested by paroga on #webkit).

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • wtf/text/AtomicString.cpp: (WTF::AtomicString::fromUTF8):
  • wtf/unicode/UTF8.cpp: (WTF::Unicode::calculateStringHashFromUTF8):
  • wtf/unicode/UTF8.h:
19:42 Changeset [77359] by mrowe@apple.com
  • 1 copy in tags/Safari-533.20.21

New tag.

19:28 EFLWebKit edited by gyuyoung.kim@samsung.com
Root CMakeLists.txt was moved to Source directory. (diff)
19:02 Changeset [77358] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2011-02-01 Dirk Pranke <dpranke@chromium.org>

Unreviewed, expectations change.

fast/css/box-shadow.html was removed in r77101 but there was
still a reference to it in the expectations file.

  • platform/chromium/test_expectations.txt:
18:57 Changeset [77357] by simonjam@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-02-01 James Simonsen <simonjam@chromium.org>

Reviewed by Tony Gentilcore.

[WebTiming] Remove asserts that verify timestamp order
https://bugs.webkit.org/show_bug.cgi?id=53548

Covered by existing tests.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::stopLoading): Remove assert.
  • page/DOMWindow.cpp: (WebCore::DOMWindow::dispatchTimedEvent): Ditto.
18:50 Changeset [77356] by dglazkov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-02-01 Dimitri Glazkov <dglazkov@chromium.org>

Add the 'default_targets' enclosure to the flags.

  • WebCore.gyp/WebCore.gyp: Did it.
18:39 Changeset [77355] by mihaip@chromium.org
  • 7 edits
    2 adds in trunk

2011-02-01 Mihai Parparita <mihaip@chromium.org>

Reviewed by James Robinson.

Async event handlers should not fire within a modal dialog
https://bugs.webkit.org/show_bug.cgi?id=53202

Add tests for a scroll event triggered right before a modal dialog is
shown.

  • fast/events/scroll-event-during-modal-dialog-expected.txt: Added.
  • fast/events/scroll-event-during-modal-dialog.html: Added.

2011-02-01 Mihai Parparita <mihaip@chromium.org>

Reviewed by James Robinson.

Async event handlers should not fire within a modal dialog
https://bugs.webkit.org/show_bug.cgi?id=53202

Asychronous events that use EventQueue would currently fire while a
modal dialog (e.g. window.alert()) was up. Change EventQueue to use a
SuspendableTimer (which automatically gets suspended while dialogs are
up and in other cases where JS execution is not allowed).

Test: fast/events/scroll-event-during-modal-dialog.html

  • dom/Document.cpp: (WebCore::Document::Document):
  • dom/EventQueue.cpp: (WebCore::EventQueueTimer::EventQueueTimer): (WebCore::EventQueueTimer::fired): (WebCore::EventQueue::EventQueue): (WebCore::EventQueue::enqueueEvent): (WebCore::EventQueue::pendingEventTimerFired):
  • dom/EventQueue.h: (WebCore::EventQueue::create):
  • page/SuspendableTimer.cpp: (WebCore::SuspendableTimer::SuspendableTimer): (WebCore::SuspendableTimer::suspend): (WebCore::SuspendableTimer::resume):
  • page/SuspendableTimer.h:
18:35 Changeset [77354] by jschuh@chromium.org
  • 1 edit in branches/chromium/597/WebCore/bindings/v8/V8NPUtils.cpp

Merge 76264
BUG=69970

18:32 Changeset [77353] by dpranke@chromium.org
  • 3 edits in trunk/Tools

2011-02-01 Dirk Pranke <dpranke@chromium.org>

Reviewed by Mihai Parparita.

new-run-webkit-tests: stop skipping so many tests

r77163 introduced a regression where we weren't resetting test
expectations properly and were skipping too many tests as a
result. This patch fixes that and adds a test for it.

https://bugs.webkit.org/show_bug.cgi?id=53551

  • Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
18:23 Changeset [77352] by jschuh@chromium.org
  • 2 edits in branches/chromium/597/WebCore/rendering

Merge 75810
BUG=69556

18:18 Changeset [77351] by paroga@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-01 Patrick Gansterer <paroga@webkit.org>

Reviewed by Andreas Kling.

Change wrong PLATFORM(WIN) to USE(WININET)
https://bugs.webkit.org/show_bug.cgi?id=53547

  • platform/network/ResourceHandle.h:
18:05 Changeset [77350] by bdakin@apple.com
  • 2 edits in trunk/Source/WebCore

32-bit build fix.

  • platform/mac/ScrollAnimatorMac.mm:

(-[ScrollbarPainterControllerDelegate contentAreaRectForScrollerImpPair:]):

18:04 Changeset [77349] by mrowe@apple.com
  • 7 edits in branches/safari-533.20-branch

Build fix.

18:04 Changeset [77348] by jschuh@chromium.org
  • 4 edits in branches/chromium/597/WebCore

Merge 76990
BUG=68120

17:53 Changeset [77347] by tkent@chromium.org
  • 4 edits in trunk

2011-02-01 Kent Tamura <tkent@chromium.org>

Reviewed by Tony Chang.

[Chromium] Roll Chromium revision for the WebKitWeightWatcher change
https://bugs.webkit.org/show_bug.cgi?id=53563

  • platform/chromium/test_expectations.txt: fast/css/font-weight-1.html is expected to fail.

2011-02-01 Kent Tamura <tkent@chromium.org>

Reviewed by Tony Chang.

[Chromium] Roll Chromium revision for the WebKitWeightWatcher change
https://bugs.webkit.org/show_bug.cgi?id=53563

  • DEPS: Roll to crrev.com/73378 to have the WebKitWeightWatcher change of webkit_support.
17:49 Changeset [77346] by dglazkov@chromium.org
  • 2 edits in trunk/LayoutTests

2011-02-01 Dimitri Glazkov <dglazkov@chromium.org>

Marking test, added in r77333 as skipped, because it is
reaching V8 recursion limits faster than those on Document.

  • platform/chromium/test_expectations.txt: See above.
17:45 Changeset [77345] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

2011-02-01 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Attach the layer tree in the UI process
https://bugs.webkit.org/show_bug.cgi?id=53560

  • UIProcess/API/mac/WKView.mm: (-[WKView _enterAcceleratedCompositingMode:]): Make a render layer and add it as a sublayer of our root layer.
  • WebProcess/WebPage/mac/LayerTreeHostMac.h: Make LayerTreeHostMac a GraphicsLayerClient.
  • WebProcess/WebPage/mac/LayerTreeHostMac.mm: (WebKit::LayerTreeHostMac::LayerTreeHostMac): Create a root layer, add the layer subtree as a child of the root layer.

(WebKit::LayerTreeHostMac::~LayerTreeHostMac):
Assert that m_rootLayer is null.

(WebKit::LayerTreeHostMac::invalidate):
Null out m_rootLayer.

(WebKit::LayerTreeHostMac::notifyAnimationStarted):
(WebKit::LayerTreeHostMac::notifySyncRequired):
(WebKit::LayerTreeHostMac::paintContents):
Add stubs.

(WebKit::LayerTreeHostMac::showDebugBorders):
(WebKit::LayerTreeHostMac::showRepaintCounter):
Return the correct settings.

(WebKit::LayerTreeHostMac::flushPendingLayerChanges):
Flush the root layer changes.

17:41 Changeset [77344] by jschuh@chromium.org
  • 1 edit in branches/chromium/597/WebCore/rendering/RenderBox.cpp

Merge 75823
BUG=67968

17:31 Changeset [77343] by mrobinson@webkit.org
  • 4 edits in trunk

2011-01-25 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] Two tests crash after r76555
https://bugs.webkit.org/show_bug.cgi?id=53057

  • platform/gtk/Skipped: Unskip tests which are no longer crashing.

2011-01-25 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] Two tests crash after r76555
https://bugs.webkit.org/show_bug.cgi?id=53057

Instead of creating synchronous ResourceHandles manually, use the ::create factory.
This ensures that ::start() is not called when there is a scheduled failure and also
reduces code duplication.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandle::loadResourceSynchronously): Use the ::create factory method.
17:25 Changeset [77342] by jschuh@chromium.org
  • 1 edit in branches/chromium/597/WebCore/page/animation/AnimationController.cpp

Merge 76708
BUG=67234

17:16 Changeset [77341] by dpranke@chromium.org
  • 3 edits
    1 add in trunk/Tools

2011-02-01 Dirk Pranke <dpranke@chromium.org>

Reviewed by Tony Chang.

new-run-webkit-tests: add first stub of test_runner2. This
will add support for the 'inline', 'threads', and 'processes'
flags to --worker-model, but for now the implementatios just
fall back on the old ones.

https://bugs.webkit.org/show_bug.cgi?id=53157

  • Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
17:12 Changeset [77340] by ojan@chromium.org
  • 2 edits in trunk/Websites/bugs.webkit.org

2011-02-01 Ojan Vafai <ojan@chromium.org>

Reviewed by Mihai Parparita.

[codereviewtool] extra space at the beginning of lines in side-by-side view
https://bugs.webkit.org/show_bug.cgi?id=53550

The newline between the spans turns into user-visible space in side-by-side mode.

  • PrettyPatch/PrettyPatch.rb:
17:11 Changeset [77339] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Fix Windows build.

  • UIProcess/win/WebView.cpp:

(WebKit::WebView::enterAcceleratedCompositingMode):
(WebKit::WebView::exitAcceleratedCompositingMode):

  • UIProcess/win/WebView.h:
17:09 Changeset [77338] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-02-01 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Add a layer backed NSView for accelerated content
https://bugs.webkit.org/show_bug.cgi?id=53555

Rename the current _layerHostingView to _oldLayerHostingView and
add a new _layerHostingView to be used with the new drawing area.

  • UIProcess/API/mac/WKView.mm: (-[WKView hitTest:]): (-[WKView _startAcceleratedCompositing:]): (-[WKView _stopAcceleratedCompositing]): (-[WKView _enterAcceleratedCompositingMode:]): (-[WKView _exitAcceleratedCompositingMode]):
17:04 Changeset [77337] by mrobinson@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-01 Martin Robinson <mrobinson@igalia.com>

Reviewed by Eric Seidel.

[GTK] GObject DOM bindings do no support the CallWith attribute
https://bugs.webkit.org/show_bug.cgi?id=53331

Disable building GObject DOM bindings for IndexedDB because we do not support
the CallWith attribute at this time.

  • bindings/gobject/GNUmakefile.am: Disable building bindings for the IndexedDB API.
17:01 Changeset [77336] by darin@apple.com
  • 3 edits in trunk/Source/WebCore

2011-02-01 Darin Adler <darin@apple.com>

Reviewed by Brady Eidson.

Fix a couple loose ends from the back/forward tree encode/decode work
https://bugs.webkit.org/show_bug.cgi?id=53537

  • history/HistoryItem.cpp: (WebCore::HistoryItem::encodeBackForwardTreeNode): Remove extra copy of original URL string; no need to encode it twice. (WebCore::HistoryItem::decodeBackForwardTree): Ditto.
  • history/HistoryItem.h: Removed declaration for function that is no longer defined nor used.
16:55 Changeset [77335] by tony@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-02-01 Tony Chang <tony@chromium.org>

Reviewed by Kent Tamura.

[chromium] disable arm uninitialized variable warnings
https://bugs.webkit.org/show_bug.cgi?id=53553

We just got another error:
third_party/WebKit/Source/WebCore/css/CSSPrimitiveValue.cpp:123:error:
'colorTransparent.unstatic.4879' may be used uninitialized in this
function

  • WebCore.gyp/WebCore.gyp:
16:48 Changeset [77334] by andersca@apple.com
  • 9 edits in trunk/Source/WebKit2

2011-02-01 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Pass enter/exit accelerated compositing mode to the WKView
https://bugs.webkit.org/show_bug.cgi?id=53552

  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm: (WebKit::PageClientImpl::enterAcceleratedCompositingMode): (WebKit::PageClientImpl::exitAcceleratedCompositingMode):
  • UIProcess/API/mac/WKView.mm: (-[WKView _enterAcceleratedCompositingMode:]): (-[WKView _exitAcceleratedCompositingMode]):
  • UIProcess/API/mac/WKViewInternal.h:
  • UIProcess/DrawingAreaProxyImpl.cpp: (WebKit::DrawingAreaProxyImpl::enterAcceleratedCompositingMode): (WebKit::DrawingAreaProxyImpl::exitAcceleratedCompositingMode):
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::enterAcceleratedCompositingMode): (WebKit::WebPageProxy::exitAcceleratedCompositingMode):
  • UIProcess/WebPageProxy.h:
16:22 Changeset [77333] by commit-queue@webkit.org
  • 4 edits
    6 adds in trunk

2011-02-01 chris reiss <christopher.reiss@nokia.com>

Reviewed by Adam Barth.

Self-replicating code makes Safari hang and eventually crash
https://bugs.webkit.org/show_bug.cgi?id=15123

  • fast/dom/Document/document-close-iframe-load-expected.txt: Added.
  • fast/dom/Document/document-close-iframe-load.html: Added.
  • fast/dom/Document/document-close-nested-iframe-load-expected.txt: Added.
  • fast/dom/Document/document-close-nested-iframe-load.html: Added.
  • fast/dom/Document/document-write-recursion-expected.txt: Added.
  • fast/dom/Document/document-write-recursion.html: Added.

2011-02-01 chris reiss <christopher.reiss@nokia.com>

Reviewed by Adam Barth.

Self-replicating code makes Safari hang and eventually crash
https://bugs.webkit.org/show_bug.cgi?id=15123

Here we are replicating the Firefox safeguard against
recursive document.write( ) 's.

See https://bug197052.bugzilla.mozilla.org/attachment.cgi?id=293907 in bug
https://bugzilla.mozilla.org/show_bug.cgi?id=197052 . Firefox does two things -

a) imposes a recursion limit of 20 on document.write( ) and
b) once that limit is passed, panics all the way the call stack (rather than just returning one level.)

To see why this is necessary, consider the script :

<script>

var t = document.body.innerHTML;
document.write(t);

</script>

This will create a tree both broad and deep as the script keeps appending itself to the text. If
we just return one level after the recursion limit is reached, we still allow millions of copies to
duplicate (and execute).

The recursion is fortunately depth-first, so as soon as we cross this limit, we panic up the callstack
to prevent this situation. (IE apparently does the same thing, with a lower recursion limit.)

Test: fast/dom/Document/document-write-recursion.html
Test: fast/dom/Document/document-close-iframe-load.html
Test: fast/dom/Document/document-close-nested-iframe-load.html

  • dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::write):
  • dom/Document.h:
16:12 Changeset [77332] by dglazkov@chromium.org
  • 2 edits in trunk/LayoutTests

2011-02-01 Dimitri Glazkov <dglazkov@chromium.org>

Updated text expectations to avoid conflict.

  • platform/chromium/test_expectations.txt: Tweaked.
16:05 Changeset [77331] by ojan@chromium.org
  • 2 edits in trunk/Websites/bugs.webkit.org

2011-02-01 Ojan Vafai <ojan@chromium.org>

Increment version number to cache-bust code-review.js.

  • PrettyPatch/PrettyPatch.rb:
16:00 Changeset [77330] by ojan@chromium.org
  • 2 edits
    1 add in trunk/Websites/bugs.webkit.org

2011-01-31 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

Store draft comments in localStorage
https://bugs.webkit.org/show_bug.cgi?id=52866

  • code-review.js:
  • code-review-test.html
15:52 Changeset [77329] by jnd@chromium.org
  • 3 edits
    2 adds in trunk

2011-02-01 Johnny Ding <jnd@chromium.org>

Reviewed by Darin Adler.

Don't set user gesture in HTMLAnchorElement's click handler because the click handler can be triggered by untrusted event.
https://bugs.webkit.org/show_bug.cgi?id=53424

  • fast/events/popup-blocked-from-untrusted-click-event-on-anchor-expected.txt: Added.
  • fast/events/popup-blocked-from-untrusted-click-event-on-anchor.html: Added.

2011-02-01 Johnny Ding <jnd@chromium.org>

Reviewed by Darin Adler.

Don't set user gesture in HTMLAnchorElement's click handler because the click handler can be triggered by untrusted event.
https://bugs.webkit.org/show_bug.cgi?id=53424

Test: fast/events/popup-blocked-from-untrusted-click-event-on-anchor.html

  • html/HTMLAnchorElement.cpp: (WebCore::handleLinkClick):
15:50 Changeset [77328] by ossy@webkit.org
  • 6 edits in trunk/Source

Unreviewed Qt buildfix after r77286.

https://bugs.webkit.org/show_bug.cgi?id=53520
Remove the physical terminology from IntRect and FloatRect.

Source/WebCore:

  • platform/graphics/TiledBackingStore.cpp:

(WebCore::TiledBackingStore::createTiles):

Source/WebKit/qt:

  • WebCoreSupport/PopupMenuQt.cpp:

(WebCore::PopupMenuQt::show):

Source/WebKit2:

  • UIProcess/qt/ChunkedUpdateDrawingAreaProxyQt.cpp:

(WebKit::ChunkedUpdateDrawingAreaProxy::drawUpdateChunkIntoBackingStore):

15:46 Changeset [77327] by zmo@google.com
  • 2 edits in trunk/LayoutTests

2011-02-01 Zhenyao Mo <zmo@google.com>

Unreviewed, test expectations update.

  • platform/chromium/test_expectations.txt:
15:41 Changeset [77326] by mrowe@apple.com
  • 2 edits in branches/safari-533.20-branch/WebCore

Merge r71769.

15:41 Changeset [77325] by mrowe@apple.com
  • 17 edits
    8 adds
    4 deletes in branches/safari-533.20-branch

Merge r71767.

15:32 Changeset [77324] by paroga@webkit.org
  • 5 edits in trunk/Source/JavaScriptCore

2011-02-01 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r77297.
http://trac.webkit.org/changeset/77297
https://bugs.webkit.org/show_bug.cgi?id=53538

caused leopard crashes (Requested by paroga on #webkit).

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • wtf/text/AtomicString.cpp: (WTF::AtomicString::fromUTF8):
  • wtf/unicode/UTF8.cpp: (WTF::Unicode::calculateStringHashFromUTF8):
  • wtf/unicode/UTF8.h:
15:26 Changeset [77323] by dglazkov@chromium.org
  • 10 edits in trunk/LayoutTests

2011-02-01 Dimitri Glazkov <dglazkov@chromium.org>

Updated baselines after switching input-derived parts of HTMLMediaElement
to use shadow DOM.
https://bugs.webkit.org/show_bug.cgi?id=53314

  • platform/chromium-linux/media/video-zoom-controls-expected.checksum: Updated.
  • platform/chromium-linux/media/video-zoom-controls-expected.png: Updated.
  • platform/chromium-mac/media/video-zoom-controls-expected.checksum: Updated.
  • platform/chromium-mac/media/video-zoom-controls-expected.png: Updated.
  • platform/chromium-mac/media/video-zoom-controls-expected.txt: Updated.
  • platform/chromium-win/media/video-zoom-controls-expected.checksum: Updated.
  • platform/chromium-win/media/video-zoom-controls-expected.png: Updated.
  • platform/chromium-win/media/video-zoom-controls-expected.txt: Updated.
  • platform/chromium/test_expectations.txt: Expectation of failure removed.
15:20 Changeset [77322] by weinig@apple.com
  • 7 edits in trunk/Source

Fix Mac production builds.

../JavaScriptCore:

../WebCore:

  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/mac/ScrollAnimatorMac.h:
  • platform/mac/ScrollbarThemeMac.h:
15:05 Changeset [77321] by inferno@chromium.org
  • 2 edits
    1 add in trunk/LayoutTests

2011-02-01 Abhishek Arya <inferno@chromium.org>

Unreviewed.

Test not crashing on chromium, was crashing earlier because of
some build issues. Also, rebaselining chromium mac since it matches
rest of chromium and is not same as mac leopard.
https://bugs.webkit.org/show_bug.cgi?id=53516

  • platform/chromium-mac/fast/css/stylesheet-candidate-nodes-crash-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
15:04 Changeset [77320] by darin@chromium.org
  • 4 edits in trunk/Source/WebKit/chromium

2011-02-01 Darin Fisher <darin@chromium.org>

Reviewed by David Levin.

[chromium] Remove unnecessary WebCore
prefixing in a few places and fix-up some indentation. https://bugs.webkit.org/show_bug.cgi?id=53523
  • src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::attach): (WebKit::WebDevToolsAgentImpl::inspectNode): (WebKit::WebDevToolsAgentImpl::inspectorController): (WebKit::WebDevToolsAgentImpl::mainFrame): (WebKit::WebDevToolsAgentImpl::identifierForInitialRequest): (WebKit::WebDevToolsAgentImpl::sendMessageToFrontend): (WebKit::WebDevToolsAgentImpl::updateInspectorStateCookie): (WebKit::WebDevToolsAgent::interruptAndDispatch): (WebKit::WebDevToolsAgent::processPendingMessages):
  • src/WebPopupMenuImpl.cpp: (WebKit::WebPopupMenuImpl::resize):
  • src/WebScrollbarImpl.cpp: (WebKit::WebScrollbarImpl::setLocation): (WebKit::WebScrollbarImpl::setValue): (WebKit::WebScrollbarImpl::onMouseWheel): (WebKit::WebScrollbarImpl::onKeyDown): (WebKit::WebScrollbarImpl::scrollPosition): (WebKit::WebScrollbarImpl::setScrollOffset): (WebKit::WebScrollbarImpl::invalidateScrollbarRect): (WebKit::WebScrollbarImpl::getTickmarks):
15:02 Changeset [77319] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533.20-branch

Merge r73620.

14:59 Changeset [77318] by mrowe@apple.com
  • 5 edits
    2 adds in branches/safari-533.20-branch

Merge r73559.

14:56 Changeset [77317] by hyatt@apple.com
  • 1 edit in trunk/Source/WebKit2/UIProcess/qt/TiledDrawingAreaTileQt.cpp

Fix Qt bustage.

14:52 Changeset [77316] by hyatt@apple.com
  • 1 edit in trunk/Source/WebKit/qt/Api/qwebframe.cpp

Fix Qt bustage.

14:51 Changeset [77315] by andersca@apple.com
  • 8 edits
    2 adds in trunk/Source/WebKit2

2011-02-01 Anders Carlsson <andersca@apple.com>

Reviewed by Adam Roben.

Send messages when entering/exiting accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=53534

  • Shared/LayerTreeContext.h: Added.
  • Shared/mac/LayerTreeContextMac.mm: Added. Add new LayerTreeContext which holds all information needed to enter accelerated compositing mode.
  • UIProcess/DrawingAreaProxy.h: (WebKit::DrawingAreaProxy::enterAcceleratedCompositingMode): (WebKit::DrawingAreaProxy::exitAcceleratedCompositingMode): Add empty stubs.
  • UIProcess/DrawingAreaProxy.messages.in: Add new messgaes.
  • UIProcess/DrawingAreaProxyImpl.cpp: (WebKit::DrawingAreaProxyImpl::enterAcceleratedCompositingMode): (WebKit::DrawingAreaProxyImpl::exitAcceleratedCompositingMode):
  • UIProcess/DrawingAreaProxyImpl.h: Add empty stubs.
  • WebKit2.xcodeproj/project.pbxproj: Add new files.
  • WebProcess/WebPage/mac/LayerTreeHostMac.h:
  • WebProcess/WebPage/mac/LayerTreeHostMac.mm: (WebKit::LayerTreeHostMac::LayerTreeHostMac): (WebKit::LayerTreeHostMac::invalidate): Send messages.
14:49 Changeset [77314] by mrowe@apple.com
  • 6 edits
    2 adds in branches/safari-533.20-branch

Merge r71431.

14:49 Changeset [77313] by darin@apple.com
  • 6 edits
    2 adds in trunk

2011-02-01 Darin Adler <darin@apple.com>

Reviewed by Chris Fleizach.

REGRESSION: Removing focus from area element causes unwanted scrolling
https://bugs.webkit.org/show_bug.cgi?id=50169

Test: fast/images/imagemap-scroll.html

  • html/HTMLAreaElement.cpp: (WebCore::HTMLAreaElement::setFocus): Added override. Calls the new RenderImage::areaElementFocusChanged function. (WebCore::HTMLAreaElement::updateFocusAppearance): Removed the code here that calls setNeedsLayout on the image's renderer. This was an attempt to cause repaint of the renderer, but this function does not need to do that. Also changed this to use the imageElement function to avoid repeating code.
  • html/HTMLAreaElement.h: Updated for above changes.
  • rendering/RenderImage.cpp: (WebCore::RenderImage::paint): Updated for name change. (WebCore::RenderImage::paintAreaElementFocusRing): Renamed this from paintFocusRing, because it only paints area focus rings, and should not be confused with paintFocusRing functions in other classes. Also removed the unused style argument. Removed the code that used an HTMLCollection to see if the focused area element is for this image and instead just call imageElement on the area element. (WebCore::RenderImage::areaElementFocusChanged): Added. Calls repaint.
  • rendering/RenderImage.h: Added a public areaElementFocusChanged function for HTMLAreaElement to call. Made the paintFocusRing function private, renamed it to paintAreaElementFocusRing, and removed its unused style argument.

2011-02-01 Darin Adler <darin@apple.com>

Reviewed by Chris Fleizach.

REGRESSION: Removing focus from area element causes unwanted scrolling
https://bugs.webkit.org/show_bug.cgi?id=50169

  • fast/images/imagemap-scroll-expected.txt: Added.
  • fast/images/imagemap-scroll.html: Added.
14:48 Changeset [77312] by hyatt@apple.com
  • 1 edit in trunk/Source/WebCore/platform/graphics/TiledBackingStore.cpp

Fix Qt bustage.

14:42 Changeset [77311] by zmo@google.com
  • 5 edits
    2 adds in trunk

2011-02-01 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

getUniform should support SAMPLER_2D or SAMPLER_CUBE
https://bugs.webkit.org/show_bug.cgi?id=52190

  • fast/canvas/webgl/gl-object-get-calls-expected.txt:
  • fast/canvas/webgl/gl-object-get-calls.html: Test getUniform with sampler2D and samplerCube uniforms.
  • fast/canvas/webgl/resources/noopUniformShader.vert: Added.
  • fast/canvas/webgl/resources/samplerUniformShader.frag: Added.

2011-02-01 Patrick Gansterer <paroga@webkit.org>

Unreviewed WinCE build fix for r77286.

  • platform/graphics/wince/GraphicsContextWinCE.cpp: (WebCore::TransparentLayerDC::TransparentLayerDC):
14:42 Changeset [77310] by mrowe@apple.com
  • 7 edits
    2 adds in branches/safari-533.20-branch

Merge r70792.

14:39 Changeset [77309] by paroga@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-01 Patrick Gansterer <paroga@webkit.org>

Unreviewed WinCE build fix for r77286.

  • platform/graphics/wince/GraphicsContextWinCE.cpp: (WebCore::TransparentLayerDC::TransparentLayerDC):
14:37 Changeset [77308] by cfleizach@apple.com
  • 6 edits
    2 adds in trunk

AX: AXPosition of AXScrollArea is wrong
https://bugs.webkit.org/show_bug.cgi?id=53511

Reviewed by Darin Adler.

Source/WebCore:

AccessibilityScrollView needed to return a valid documentFrameView() object.
At the same time, the code from document() should be consolidated in
AccessibilityObject, so all objects can use it.

Test: platform/mac/accessibility/webkit-scrollarea-position.html

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::document):

  • accessibility/AccessibilityObject.h:
  • accessibility/AccessibilityScrollView.cpp:

(WebCore::AccessibilityScrollView::accessibilityHitTest):
(WebCore::AccessibilityScrollView::documentFrameView):

  • accessibility/AccessibilityScrollView.h:

LayoutTests:

  • platform/mac/accessibility/webkit-scrollarea-position-expected.txt: Added.
  • platform/mac/accessibility/webkit-scrollarea-position.html: Added.
14:33 Changeset [77307] by mrowe@apple.com
  • 7 edits
    2 adds in branches/safari-533.20-branch

Merge r69033.

14:30 Changeset [77306] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

Reviewed by Dan Bernstein and Darin Adler.

<rdar://problem/8830594> Printed page is sometimes shifted down, making footer invisible

  • UIProcess/API/mac/WKPrintingView.mm: (-[WKPrintingView locationOfPrintRect:]): Instead of letting AppKit compute content position on page, make the view provide it. We can do this because WK(Printing)Views are always printed on their own, not as part of other views.
14:29 Changeset [77305] by zmo@google.com
  • 2 edits in trunk/Source/WebCore

2011-02-01 Zhenyao Mo <zmo@google.com>

Reviewed by Darin Adler.

Fix the incorrect usage of RetainPtr cases in GraphicsContext3DCG.cpp
https://bugs.webkit.org/show_bug.cgi?id=53531

With this fix, running WebGL conformance tests should no longer crash randomly.

  • platform/graphics/cg/GraphicsContext3DCG.cpp: (WebCore::GraphicsContext3D::getImageData):
14:23 Changeset [77304] by mrowe@apple.com
  • 15 edits
    5 adds in branches/safari-533.20-branch

Merge r70335.

14:21 Changeset [77303] by mrowe@apple.com
  • 8 edits
    2 adds in branches/safari-533.20-branch

Merge r68541.

14:14 Changeset [77302] by dglazkov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-02-01 Dimitri Glazkov <dglazkov@chromium.org>

One more Chromium build fix after r77286.

  • platform/chromium/ScrollbarThemeChromiumMac.mm: (WebCore::ScrollbarThemeChromiumMac::paint): Changed to not use topLeft().
14:12 Changeset [77301] by weinig@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Try to fix the windows build.

  • DerivedSources.make:
14:11 Changeset [77300] by hyatt@apple.com
  • 1 edit in trunk/Source/WebKit2/UIProcess/TiledDrawingAreaProxy.cpp

Fix Qt bustage.

14:07 Changeset [77299] by mrowe@apple.com
  • 14 edits
    1 add in branches/safari-533.20-branch

Merge r74524.

14:04 Changeset [77298] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

Fix the build for Beth.

  • platform/mac/ScrollAnimatorMac.mm:

(-[ScrollbarPainterControllerDelegate inLiveResizeForScrollerImpPair:]):

14:03 Changeset [77297] by paroga@webkit.org
  • 5 edits in trunk/Source/JavaScriptCore

2011-02-01 Patrick Gansterer <paroga@webkit.org>

Reviewed by Darin Adler.

Avoid strlen() in AtomicString::fromUTF8
https://bugs.webkit.org/show_bug.cgi?id=50516

Add an overload to calculateStringHashFromUTF8 to get
strlen() of the input data with only one call.

This change shows about 3% performance win on the xml-parser benchmark.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • wtf/text/AtomicString.cpp: (WTF::AtomicString::fromUTF8):
  • wtf/unicode/UTF8.cpp: (WTF::Unicode::calculateStringHashAndLengthFromUTF8Internal): (WTF::Unicode::calculateStringHashFromUTF8): (WTF::Unicode::calculateStringHashAndLengthFromUTF8):
  • wtf/unicode/UTF8.h:
14:02 Changeset [77296] by mrowe@apple.com
  • 2 edits
    2 copies in branches/safari-533.20-branch/LayoutTests

Merge r66796.

14:02 Changeset [77295] by mrowe@apple.com
  • 4 edits
    2 adds in branches/safari-533.20-branch

Merge r66795.

14:02 Changeset [77294] by mrowe@apple.com
  • 15 edits in branches/safari-533.20-branch/WebCore

Merge r66115.

13:57 Changeset [77293] by andersca@apple.com
  • 7 edits in trunk/Source/WebKit2

2011-02-01 Anders Carlsson <andersca@apple.com>

Reviewed by Adam Roben.

Make LayerTreeHost ref counted
https://bugs.webkit.org/show_bug.cgi?id=53530

LayerTreeHostMac will soon be able to trigger layout, which could cause
the page to leave accelerated compositing mode and free the LayerTreeHostMac object.

Making LayerTreeHost ref counted will let LayerTreeHostMac protect itself while triggering layout.

  • WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::setRootCompositingLayer):
  • WebProcess/WebPage/DrawingAreaImpl.h:
  • WebProcess/WebPage/LayerTreeHost.cpp: (WebKit::LayerTreeHost::create):
  • WebProcess/WebPage/LayerTreeHost.h:
  • WebProcess/WebPage/mac/LayerTreeHostMac.h:
  • WebProcess/WebPage/mac/LayerTreeHostMac.mm: (WebKit::LayerTreeHostMac::create): (WebKit::LayerTreeHostMac::LayerTreeHostMac): (WebKit::LayerTreeHostMac::~LayerTreeHostMac): (WebKit::LayerTreeHostMac::invalidate):
13:56 Changeset [77292] by hyatt@apple.com
  • 1 edit in trunk/Source/WebKit/chromium/src/WebFrameImpl.cpp

Fix chromium bustage.

13:51 Changeset [77291] by hyatt@apple.com
  • 1 edit in trunk/Source/WebCore/platform/qt/RenderThemeQt.cpp

Fix Qt build bustage.

13:50 Changeset [77290] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533.20-branch

Merge r75882.

13:50 Changeset [77289] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533.20-branch

Merge r73799, r73805 and r73818.

13:47 Changeset [77288] by dglazkov@chromium.org
  • 2 edits in trunk/LayoutTests

2011-02-01 Dimitri Glazkov <dglazkov@chromium.org>

Added yet another expectations of flakiness.
https://bugs.webkit.org/show_bug.cgi?id=53527

  • platform/chromium/test_expectations.txt: Flakiness abound.
13:45 Changeset [77287] by weinig@apple.com
  • 13 edits in trunk/Source

Part 2 for <rdar://problem/8492788>
Adopt WKScrollbarPainterController

Reviewed by Beth Dakin.

Use header detection to define scrollbar painting controller #define.

Source/JavaScriptCore:

Source/WebCore:

  • WebCore.exp.in:
  • platform/mac/ScrollAnimatorMac.h:
  • platform/mac/ScrollbarThemeMac.h:
  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:

Source/WebKit/mac:

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

Source/WebKit2:

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

13:39 Changeset [77286] by hyatt@apple.com
  • 67 edits in trunk/Source

https://bugs.webkit.org/show_bug.cgi?id=53520

Reviewed by Oliver Hunt.

Remove the physical terminology from IntRect and FloatRect.

Now that we have flipped RenderBlocks for vertical-rl and horizontal-bt writing modes,
we need to update our terminology to be more accurate.

I'm borrowing a page from AppKit here (which also supports flipped NSViews) and
renaming right() and bottom() to maxX() and maxY(). These terms remain accurate
even for flipped rectangles.

../WebCore:

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::boundsForVisiblePositionRange):

  • accessibility/mac/AccessibilityObjectWrapper.mm:

(-[AccessibilityObjectWrapper position]):

  • dom/ClientRect.h:

(WebCore::ClientRect::right):
(WebCore::ClientRect::bottom):

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::convertLogicalToDevice):

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::normalizeRect):

  • inspector/InspectorAgent.cpp:

(WebCore::InspectorAgent::drawElementTitle):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::adjustWindowRect):

  • page/DragController.cpp:

(WebCore::dragLocForSelectionDrag):

  • page/EventHandler.cpp:

(WebCore::EventHandler::sendContextMenuEventForKey):

  • page/PrintContext.cpp:

(WebCore::PrintContext::computePageRectsWithPageSizeInternal):
(WebCore::PrintContext::pageNumberForElement):

  • page/SpatialNavigation.cpp:

(WebCore::end):
(WebCore::areRectsFullyAligned):
(WebCore::areRectsMoreThanFullScreenApart):
(WebCore::below):
(WebCore::rightOf):
(WebCore::isRectInDirection):
(WebCore::entryAndExitPointsForDirection):
(WebCore::virtualRectForDirection):

  • page/WindowFeatures.cpp:

(WebCore::WindowFeatures::WindowFeatures):

  • platform/ScrollView.cpp:

(WebCore::ScrollView::wheelEvent):

  • platform/Scrollbar.cpp:

(WebCore::Scrollbar::setFrameRect):

  • platform/ScrollbarThemeComposite.cpp:

(WebCore::ScrollbarThemeComposite::splitTrack):

  • platform/chromium/ScrollbarThemeChromium.cpp:

(WebCore::ScrollbarThemeChromium::paintTickmarks):

  • platform/graphics/FloatQuad.h:

(WebCore::FloatQuad::FloatQuad):

  • platform/graphics/FloatRect.cpp:

(WebCore::FloatRect::intersects):
(WebCore::FloatRect::contains):
(WebCore::FloatRect::intersect):
(WebCore::FloatRect::unite):
(WebCore::enclosingIntRect):

  • platform/graphics/FloatRect.h:

(WebCore::FloatRect::maxX):
(WebCore::FloatRect::maxY):
(WebCore::FloatRect::contains):

  • platform/graphics/IntRect.cpp:

(WebCore::IntRect::intersects):
(WebCore::IntRect::contains):
(WebCore::IntRect::intersect):
(WebCore::IntRect::unite):

  • platform/graphics/IntRect.h:

(WebCore::IntRect::maxX):
(WebCore::IntRect::maxY):
(WebCore::IntRect::shiftXEdgeTo):
(WebCore::IntRect::shiftMaxXEdgeTo):
(WebCore::IntRect::shiftYEdgeTo):
(WebCore::IntRect::shiftMaxYEdgeTo):
(WebCore::IntRect::contains):

  • platform/graphics/WidthIterator.cpp:

(WebCore::WidthIterator::advance):

  • platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::drawRect):
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::fillRect):

  • platform/graphics/cg/ImageBufferCG.cpp:

(WebCore::getImageData):
(WebCore::putImageData):

  • platform/graphics/cg/ImageCG.cpp:

(WebCore::BitmapImage::draw):

  • platform/graphics/filters/FilterEffect.cpp:

(WebCore::FilterEffect::copyImageBytes):

  • platform/graphics/mac/ComplexTextController.cpp:

(WebCore::ComplexTextController::adjustGlyphsAndAdvances):

  • platform/graphics/mac/SimpleFontDataMac.mm:

(WebCore::SimpleFontData::platformBoundsForGlyph):

  • platform/graphics/transforms/AffineTransform.cpp:

(WebCore::AffineTransform::mapRect):

  • platform/graphics/win/FontCGWin.cpp:

(WebCore::drawGDIGlyphs):

  • platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:

(WebCore::MediaPlayerPrivate::paint):

  • platform/gtk/RenderThemeGtk.cpp:

(WebCore::centerRectVerticallyInParentInputElement):

  • platform/mac/WidgetMac.mm:

(WebCore::Widget::paint):

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::addBoxShadowVisualOverflow):
(WebCore::InlineFlowBox::addTextBoxVisualOverflow):

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::selectionRect):
(WebCore::InlineTextBox::paint):
(WebCore::InlineTextBox::positionForOffset):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::addOverflowFromChildren):
(WebCore::RenderBlock::paintChildren):
(WebCore::RenderBlock::paintEllipsisBoxes):
(WebCore::RenderBlock::inlineSelectionGaps):
(WebCore::RenderBlock::adjustPointToColumnContents):
(WebCore::RenderBlock::flipForWritingModeIncludingColumns):
(WebCore::RenderBlock::adjustForColumns):

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::FloatingObject::right):
(WebCore::RenderBlock::FloatingObject::bottom):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::reflectedRect):
(WebCore::RenderBox::localCaretRect):
(WebCore::RenderBox::addShadowOverflow):
(WebCore::RenderBox::addLayoutOverflow):
(WebCore::RenderBox::visualOverflowRectForPropagation):
(WebCore::RenderBox::layoutOverflowRectForPropagation):
(WebCore::RenderBox::flipForWritingMode):

  • rendering/RenderFrameSet.cpp:

(WebCore::RenderFrameSet::paintColumnBorder):
(WebCore::RenderFrameSet::paintRowBorder):

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::paintOutlineForLine):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::getRectToExpose):
(WebCore::cornerRect):
(WebCore::RenderLayer::positionOverflowControls):
(WebCore::RenderLayer::overflowBottom):
(WebCore::RenderLayer::overflowRight):
(WebCore::RenderLayer::paintResizer):

  • rendering/RenderLineBoxList.cpp:

(WebCore::RenderLineBoxList::rangeIntersectsRect):
(WebCore::RenderLineBoxList::paint):

  • rendering/RenderListItem.cpp:

(WebCore::RenderListItem::positionListMarker):

  • rendering/RenderListMarker.cpp:

(WebCore::RenderListMarker::paint):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::repaintAfterLayoutIfNeeded):

  • rendering/RenderOverflow.h:

(WebCore::RenderOverflow::RenderOverflow):
(WebCore::RenderOverflow::addLayoutOverflow):
(WebCore::RenderOverflow::addVisualOverflow):
(WebCore::RenderOverflow::setLayoutOverflow):
(WebCore::RenderOverflow::setVisualOverflow):
(WebCore::RenderOverflow::resetLayoutOverflow):

  • rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::shouldPaint):

  • rendering/RenderScrollbarTheme.cpp:

(WebCore::RenderScrollbarTheme::constrainTrackRectToTrackPieces):

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::paint):

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::paint):

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::paintObject):

  • rendering/RenderText.cpp:

(WebCore::RenderText::absoluteQuads):

  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::forwardEvent):

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::paintMenuListButtonGradients):
(WebCore::RenderThemeMac::paintMenuListButton):
(WebCore::RenderThemeMac::paintSliderTrack):

  • rendering/RenderView.cpp:

(WebCore::RenderView::computeRectForRepaint):
(WebCore::RenderView::docBottom):
(WebCore::RenderView::docRight):

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::paddedLayoutOverflowRect):

  • rendering/svg/RenderSVGInlineText.cpp:

(WebCore::RenderSVGInlineText::localCaretRect):

../WebKit/mac:

  • WebView/WebHTMLView.mm:

(setNeedsDisplayInRect):

../WebKit2:

  • Platform/Region.cpp:

(WebKit::Region::Shape::Shape):

  • UIProcess/API/mac/WKPrintingView.mm:

(pageDidComputePageRects):

  • UIProcess/FindIndicator.cpp:

(WebKit::FindIndicator::draw):

  • UIProcess/TiledDrawingAreaProxy.cpp:

(WebKit::TiledDrawingAreaProxy::invalidate):
(WebKit::TiledDrawingAreaProxy::paint):
(WebKit::TiledDrawingAreaProxy::createTiles):

  • UIProcess/mac/ChunkedUpdateDrawingAreaProxyMac.mm:

(WebKit::ChunkedUpdateDrawingAreaProxy::drawUpdateChunkIntoBackingStore):

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::callSetWindow):

13:38 Changeset [77285] by inferno@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-02-01 Abhishek Arya <inferno@chromium.org>

Unreviewed.

Rebaseline my test for QT, Leopard from r77262 due
to minor comment error differences.

  • platform/mac-leopard/fast/css/stylesheet-candidate-nodes-crash-expected.txt: Added.
  • platform/qt/fast/css/stylesheet-candidate-nodes-crash-expected.txt: Added.
13:36 Changeset [77284] by mrowe@apple.com
  • 16 edits
    2 adds in branches/safari-533.20-branch

Merge r72230.

13:36 Changeset [77283] by mrowe@apple.com
  • 3 edits in branches/safari-533.20-branch/WebCore

Merge r69125.

13:34 Changeset [77282] by andersca@apple.com
  • 5 edits in trunk/Source/WebKit2

2011-02-01 Anders Carlsson <andersca@apple.com>

Reviewed by Adam Roben.

Move flushPendingLayerChanges to LayerTreeHostMac
https://bugs.webkit.org/show_bug.cgi?id=53525

In preparation for adding more Mac specific code to flushPendingLayerChanges.

  • WebProcess/WebPage/LayerTreeHost.cpp:
  • WebProcess/WebPage/LayerTreeHost.h:
  • WebProcess/WebPage/mac/LayerTreeHostMac.h:
  • WebProcess/WebPage/mac/LayerTreeHostMac.mm: (WebKit::LayerTreeHostMac::flushPendingLayerChanges):
13:28 Changeset [77281] by xji@chromium.org
  • 1 edit
    8 adds in trunk/LayoutTests

2011-02-01 Xiaomei Ji <xji@chromium.org>

Unreviewed.

Rebaseline after r77267.

  • platform/chromium-linux/fast/dom/34176-expected.checksum: Added.
  • platform/chromium-linux/fast/dom/34176-expected.png: Added.
  • platform/chromium-mac/fast/dom/34176-expected.checksum: Added.
  • platform/chromium-mac/fast/dom/34176-expected.png: Added.
  • platform/chromium-win/fast/dom/34176-expected.checksum: Added.
  • platform/chromium-win/fast/dom/34176-expected.png: Added.
  • platform/chromium-win/fast/dom/34176-expected.txt: Added.
  • platform/win/fast/dom/34176-expected.txt: Added.
13:26 Changeset [77280] by mrowe@apple.com
  • 5 edits
    7 adds in branches/safari-533.20-branch

Merge r74854.

13:15 Changeset [77279] by mihaip@chromium.org
  • 2 edits in trunk/Tools

2011-02-01 Mihai Parparita <mihaip@chromium.org>

Reviewed by James Robinson.

[Chromium] run-chromium-webkit-unit-tests looks for binaries in the wrong place
https://bugs.webkit.org/show_bug.cgi?id=53522

  • Scripts/run-chromium-webkit-unit-tests:
12:50 Changeset [77278] by xji@chromium.org
  • 2 edits in trunk/LayoutTests

2011-02-01 Xiaomei Ji <xji@chromium.org>

Unreviewed.

  • fast/dom/34176.html: Removed properties svn:executable and svn:mime-type.
12:44 Changeset [77277] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2011-02-01 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

REGRESSION(77082): GC-related crashes seen: on WebKit2 bot; on GTK 32bit
bot; loading trac pages; typing in search field
https://bugs.webkit.org/show_bug.cgi?id=53519


The crashes were all caused by failure to run an object's destructor.

  • runtime/CollectorHeapIterator.h: (JSC::ObjectIterator::ObjectIterator): Don't skip forward upon construction. The iterator class used to do that when it was designed for prior-to-beginning initialization. I forgot to remove this line of code when I changed the iterator to normal initialization.


Skipping forward upon construction was causing the heap to skip running
the destructor for the very first object in a block when destroying the
block. This usually did not crash, since block destruction is rare and
most objects have pretty trivial destructors. However, in the rare case
when the heap would destroy a block whose first object was a global
object or a DOM node, BOOM.

12:39 Changeset [77276] by dglazkov@chromium.org
  • 2 edits in trunk/LayoutTests

2011-02-01 Dimitri Glazkov <dglazkov@chromium.org>

Remove expectations of failure for passing tests.

  • platform/chromium/test_expectations.txt: Fewer fails.
12:35 Changeset [77275] by abarth@webkit.org
  • 2 edits in trunk/Tools

2011-02-01 Adam Barth <abarth@webkit.org>

Reviewed by Mihai Parparita.

Using Control-C to cancel webkit-patch or other python tools causes
unpleasant traceback console spew
https://bugs.webkit.org/show_bug.cgi?id=53462

Catch the exception and don't print the stack trace.

  • Scripts/webkit-patch:
12:35 Changeset [77274] by bdakin@apple.com
  • 27 edits in trunk/Source

Fix for <rdar://problem/8492788> Adopt WKScrollbarPainterController

Reviewed by Sam Weinig.

Source/WebCore:

Lots of new WebCoreSystemInterface functions to export.

  • WebCore.exp.in:
  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:

Let the scrollAnimator know when the mouse has
moved anywhere inside the page, and when the mouse
has moved in or out of the window.

  • page/EventHandler.cpp:

(WebCore::EventHandler::mouseMoved):
(WebCore::EventHandler::updateMouseEventTargetNode):

Let the scrollAnimator know when the window has become
active or inactive.

  • page/FocusController.cpp:

(WebCore::FocusController::setActive):

Let the scrollAnimator know when all of these things
are happening.

  • page/FrameView.cpp:

(WebCore::FrameView::setContentsSize):
(WebCore::FrameView::didMoveOnscreen):
(WebCore::FrameView::willMoveOffscreen):
(WebCore::FrameView::currentMousePosition):
(WebCore::FrameView::contentsResized):

New functions called through WebKit2 that allow the
scrollAnimator to know when a live resize starts and ends.
(WebCore::FrameView::willStartLiveResize):
(WebCore::FrameView::willEndLiveResize):

  • page/FrameView.h:


New functions on ScrollAnimator that pass information
to the WKPainterController when we're using one.

  • platform/ScrollAnimator.h:

(WebCore::ScrollAnimator::scrollableArea):
(WebCore::ScrollAnimator::contentAreaWillPaint):
(WebCore::ScrollAnimator::mouseEnteredContentArea):
(WebCore::ScrollAnimator::mouseExitedContentArea):
(WebCore::ScrollAnimator::mouseMovedInContentArea):
(WebCore::ScrollAnimator::willStartLiveResize):
(WebCore::ScrollAnimator::contentsResized):
(WebCore::ScrollAnimator::willEndLiveResize):
(WebCore::ScrollAnimator::contentAreaDidShow):
(WebCore::ScrollAnimator::contentAreaDidHide):
(WebCore::ScrollAnimatorMac::ScrollAnimatorMac):
(WebCore::ScrollAnimatorMac::scrollbarPainterDelegate):
(WebCore::ScrollAnimatorMac::setPainterForPainterController):
(WebCore::ScrollAnimatorMac::removePainterFromPainterController):
(WebCore::ScrollAnimatorMac::notityPositionChanged):
(WebCore::ScrollAnimatorMac::contentAreaWillPaint):
(WebCore::ScrollAnimatorMac::mouseEnteredContentArea):
(WebCore::ScrollAnimatorMac::mouseExitedContentArea):
(WebCore::ScrollAnimatorMac::mouseMovedInContentArea):
(WebCore::ScrollAnimatorMac::willStartLiveResize):
(WebCore::ScrollAnimatorMac::contentsResized):
(WebCore::ScrollAnimatorMac::willEndLiveResize):
(WebCore::ScrollAnimatorMac::contentAreaDidShow):
(WebCore::ScrollAnimatorMac::contentAreaDidHide):

Let the scrollAnimator know when this is happening.

  • platform/ScrollView.cpp:

(WebCore::ScrollView::paint):

New function lets the scrollAnimator get the current
mouse position.

  • platform/ScrollView.h:

(WebCore::ScrollView::currentMousePosition):

New function that returns the scrollAnimator when needed.

  • platform/ScrollableArea.h:

(WebCore::ScrollableArea::scrollAnimator):

Keep track of if we're in a live resize using a new memeber
variable.

  • platform/mac/ScrollAnimatorMac.h:

(WebCore::ScrollAnimatorMac::inLiveResize):

  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::view):

New delegates for the WKPainter and WKPainterController
(-[ScrollbarPainterControllerDelegate initWithScrollAnimator:WebCore::]):
(-[ScrollbarPainterControllerDelegate contentAreaRectForScrollerImpPair:]):
(-[ScrollbarPainterControllerDelegate inLiveResizeForScrollerImpPair:]):
(-[ScrollbarPainterControllerDelegate mouseLocationInContentAreaForScrollerImpPair:]):
(-[ScrollbarPainterControllerDelegate scrollerImpPair:convertContentPoint:toScrollerImp:]):
(-[ScrollbarPainterControllerDelegate scrollerImpPair:setContentAreaNeedsDisplayInRect:]):
(-[ScrollbarPainterControllerDelegate scrollerImpPair:updateScrollerStyleForNewRecommendedScrollerStyle:]):
(-[ScrollKnobAnimation initWithScrollbarPainter:forScrollAnimator:WebCore::animateKnobAlphaTo:duration:]):
(-[ScrollKnobAnimation setCurrentProgress:]):
(-[ScrollbarPainterDelegate initWithScrollAnimator:WebCore::]):
(-[ScrollbarPainterDelegate convertRectToBacking:]):
(-[ScrollbarPainterDelegate convertRectFromBacking:]):
(-[ScrollbarPainterDelegate layer]):
(-[ScrollbarPainterDelegate setUpAnimation:scrollerPainter:animateKnobAlphaTo:duration:]):
(-[ScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:]):
(-[ScrollbarPainterDelegate scrollerImp:animateTrackAlphaTo:duration:]):
(-[ScrollbarPainterDelegate scrollerImp:overlayScrollerStateChangedTo:]):

Get the WKScrollbarPainterRefs to synch up with the
WKScrollbarPainterControllerRefs when appropriate

  • platform/mac/ScrollbarThemeMac.h:
  • platform/mac/ScrollbarThemeMac.mm:

(WebCore::ScrollbarThemeMac::registerScrollbar):
(WebCore::ScrollbarThemeMac::unregisterScrollbar):
(WebCore::ScrollbarThemeMac::setNewPainterForScrollbar):
(WebCore::ScrollbarThemeMac::usesOverlayScrollbars):

Implement ScrollableArea's virtual function contentsSize() for access
through the scrollAnimator.

  • rendering/RenderLayer.h:

(WebCore::RenderLayer::contentsSize):

Source/WebKit/mac:

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

Source/WebKit2:

Implement NSView's viewWillStartLiveResize and
viewDidEndLiveResize and propagate the messages down
to WebCore.

  • UIProcess/API/mac/WKView.mm:

(-[WKView viewWillStartLiveResize]):
(-[WKView viewDidEndLiveResize]):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::viewWillStartLiveResize):
(WebKit::WebPageProxy::viewWillEndLiveResize):

  • UIProcess/WebPageProxy.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::viewWillStartLiveResize):
(WebKit::WebPage::viewWillEndLiveResize):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:

A bunch of new WebKitSystemInterface functions.

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

12:28 Changeset [77273] by carol.szabo@nokia.com
  • 3 edits
    2 adds in trunk

2011-02-01 Carol Szabo <carol.szabo@nokia.com>

Reviewed by David Hyatt.

layoutTestController.counterValueForElementById does not return the correct value
https://bugs.webkit.org/show_bug.cgi?id=53037

  • fast/css/counters/deep-before-expected.txt: Added.
  • fast/css/counters/deep-before.html: Added. This tests whether DumpRenderTree properly retrieves counters and whether counters are properly set when the before pseudo element's renderer is not a direct child of the generating element's renderer.

2011-02-01 Carol Szabo <carol.szabo@nokia.com>

Reviewed by David Hyatt.

layoutTestController.counterValueForElementById does not return the correct value
https://bugs.webkit.org/show_bug.cgi?id=53037

Test: fast/css/counters/deep-before.html

  • rendering/RenderTreeAsText.cpp: (WebCore::counterValueForElement): Modified to use the newly available RenderObject::beforePseudoElement() and RenderObject::afterPseudoElement() instead of the old imperfect algorithm to find the before and after pseudo elements.
12:27 Changeset [77272] by antonm@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-02-01 Anton Muhin <antonm@chromium.org>

Reviewed by Adam Barth.

Allow access for security origin same as this.
https://bugs.webkit.org/show_bug.cgi?id=53440

Hard to test as newly added path currently is never hit.

  • page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::canAccess): allow access if this == other
12:25 Changeset [77271] by dglazkov@chromium.org
  • 2 edits in trunk/LayoutTests

2011-02-01 Dimitri Glazkov <dglazkov@chromium.org>

Added more flakiness expectations from bots.

  • platform/chromium/test_expectations.txt: Another one bites or doesn't bite the dust.
12:21 Changeset [77270] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533.20-branch

Merge r73801.

12:17 Changeset [77269] by oliver@apple.com
  • 31 edits in trunk/Source

2011-01-31 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

Update JSObject storage for new marking API
https://bugs.webkit.org/show_bug.cgi?id=53467

JSObject no longer uses EncodedJSValue for its property storage.
This produces a stream of mechanical changes to PropertySlot and
anonymous storage APIs.

  • JavaScriptCore.exp:
  • runtime/ArrayPrototype.cpp: (JSC::ArrayPrototype::ArrayPrototype):
  • runtime/BooleanConstructor.cpp: (JSC::constructBoolean): (JSC::constructBooleanFromImmediateBoolean):
  • runtime/BooleanObject.cpp: (JSC::BooleanObject::BooleanObject):
  • runtime/BooleanObject.h:
  • runtime/BooleanPrototype.cpp: (JSC::BooleanPrototype::BooleanPrototype):
  • runtime/DateInstance.cpp: (JSC::DateInstance::DateInstance):
  • runtime/DatePrototype.cpp: (JSC::DatePrototype::DatePrototype):
  • runtime/JSActivation.cpp: (JSC::JSActivation::getOwnPropertySlot):
  • runtime/JSArray.cpp: (JSC::JSArray::getOwnPropertySlot):
  • runtime/JSFunction.cpp: (JSC::JSFunction::getOwnPropertySlot):
  • runtime/JSGlobalObject.h: (JSC::JSGlobalObject::JSGlobalObject):
  • runtime/JSObject.cpp: (JSC::JSObject::fillGetterPropertySlot):
  • runtime/JSObject.h: (JSC::JSObject::getDirectLocation): (JSC::JSObject::offsetForLocation): (JSC::JSObject::putAnonymousValue): (JSC::JSObject::clearAnonymousValue): (JSC::JSObject::getAnonymousValue): (JSC::JSObject::putThisToAnonymousValue): (JSC::JSObject::locationForOffset): (JSC::JSObject::inlineGetOwnPropertySlot):
  • runtime/JSObjectWithGlobalObject.cpp: (JSC::JSObjectWithGlobalObject::JSObjectWithGlobalObject):
  • runtime/JSWrapperObject.h: (JSC::JSWrapperObject::JSWrapperObject): (JSC::JSWrapperObject::setInternalValue):
  • runtime/Lookup.cpp: (JSC::setUpStaticFunctionSlot):
  • runtime/NumberConstructor.cpp: (JSC::constructWithNumberConstructor):
  • runtime/NumberObject.cpp: (JSC::NumberObject::NumberObject): (JSC::constructNumber):
  • runtime/NumberObject.h:
  • runtime/NumberPrototype.cpp: (JSC::NumberPrototype::NumberPrototype):
  • runtime/PropertySlot.h: (JSC::PropertySlot::getValue): (JSC::PropertySlot::setValue): (JSC::PropertySlot::setRegisterSlot):
  • runtime/StringObject.cpp: (JSC::StringObject::StringObject):
  • runtime/StringPrototype.cpp: (JSC::StringPrototype::StringPrototype):
  • runtime/WriteBarrier.h: (JSC::WriteBarrierBase::setWithoutWriteBarrier):

2011-01-31 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

Update JSObject storage for new marking API
https://bugs.webkit.org/show_bug.cgi?id=53467

Update WebCore to handle new anonymous slot behaviour.

  • bindings/js/JSDOMWindowShell.cpp: (WebCore::JSDOMWindowShell::setWindow):
  • bindings/js/WorkerScriptController.cpp: (WebCore::WorkerScriptController::initScript):
  • bindings/scripts/CodeGeneratorJS.pm:
12:05 Changeset [77268] by dglazkov@chromium.org
  • 2 edits in trunk/LayoutTests

2011-02-01 Dimitri Glazkov <dglazkov@chromium.org>

https://bugs.webkit.org/show_bug.cgi?id=53516
Test introduced in r77262 is crashing.

  • platform/chromium/test_expectations.txt: Added expectation to crash

while the fix is worked on.

12:02 Changeset [77267] by xji@chromium.org
  • 3 edits
    4 adds in trunk

2011-02-01 Xiaomei Ji <xji@chromium.org>

Reviewed by David Hyatt.

Fix a text rendering problem when enclosing block is RTL and text runs
are in different directionality.
https://bugs.webkit.org/show_bug.cgi?id=34176

The problem happens in the following example scenario (ABC represents
Hebrew characters):
<div dir=rtl>this is a <span><span>test <span>ABC</span></span></span></div>

The line consists of 3 text runs -- TextRun1 TextRun2 TextRun3. In which
TextRun1 and TextRun2's bidi level are 2, and TextRun3's bidi level is 1.
TextRun2 and TextRun3's least common ancestor is not a sibling of TextRun1.

The visual bidi run order of the text runs is TextRun3 TextRun1 TextRun2.

Inside RenderBlock::constructLine(), when RenderBlock::createLineBoxes()
creates InlineFlowBox for TextRun2, it should check an InlineFlowBox for
the run's render object's ancestor (not only its parent) has already
been constructed or has something following it on the line, in which
case, create a new box for TextRun2 instead of sharing the same box with
TextRun3.

In other words, the following 2 div should render the same results
(ABC represents Hebrew characters).
<div dir=rtl>this is a <span><span>test <span>ABC</span></span></span></div>
<div dir=rtl>this is a <span>Test <span>ABC</span></span></div>

Test: fast/dom/34176.html

  • rendering/RenderBlockLineLayout.cpp: (WebCore::parentIsConstructedOrHaveNext): (WebCore::RenderBlock::createLineBoxes):

2011-02-01 Xiaomei Ji <xji@chromium.org>

Reviewed by David Hyatt.

Fix a text rendering problem when enclosing block is RTL and text runs
are in different directionality.
https://bugs.webkit.org/show_bug.cgi?id=34176

The problem happens in the following example scenario (ABC represents
Hebrew characters):
<div dir=rtl>this is a <span><span>test <span>ABC</span></span></span></div>

The line consists of 3 text runs -- TextRun1 TextRun2 TextRun3. In which
TextRun1 and TextRun2's bidi level are 2, and TextRun3's bidi level is 1.
TextRun2 and TextRun3's least common ancestor is not a sibling of TextRun1.

The visual bidi run order of the text runs is TextRun3 TextRun1 TextRun2.

Inside RenderBlock::constructLine(), when RenderBlock::createLineBoxes()
creates InlineFlowBox for TextRun2, it should check an InlineFlowBox for
the run's render object's ancestor (not only its parent) has already
been constructed or has something following it on the line, in which
case, create a new box for TextRun2 instead of sharing the same box with
TextRun3.

In other words, the following 2 div should render the same results
(ABC represents Hebrew characters).
<div dir=rtl>this is a <span><span>test <span>ABC</span></span></span></div>
<div dir=rtl>this is a <span>Test <span>ABC</span></span></div>

  • fast/dom/34176.html: Added.
  • platform/mac/fast/dom/34176-expected.checksum: Added.
  • platform/mac/fast/dom/34176-expected.png: Added.
  • platform/mac/fast/dom/34176-expected.txt: Added.
11:39 Changeset [77266] by hyatt@apple.com
  • 1 edit in trunk/LayoutTests/platform/mac/printing/setPrinting-expected.txt

Update printing layout test for the ceiling->floor change.

11:37 Changeset [77265] by pkasting@chromium.org
  • 5 edits in branches/chromium/648

Merge 76557 - 2011-01-24 Peter Kasting <pkasting@google.com>

Reviewed by Darin Adler.

Roll back r67261 ("Don't fire onclick on middle clicks") due to
regressions.
https://bugs.webkit.org/show_bug.cgi?id=46733

  • fast/events/mouse-click-events-expected.txt:
  • fast/events/script-tests/mouse-click-events.js:

2011-01-24 Peter Kasting <pkasting@google.com>

Reviewed by Darin Adler.

Roll back r67261 ("Don't fire onclick on middle clicks") due to
regressions.
https://bugs.webkit.org/show_bug.cgi?id=46733

  • html/HTMLAnchorElement.cpp: (WebCore::isLinkClick):
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::preDispatchEventHandler): (WebCore::HTMLInputElement::postDispatchEventHandler): (WebCore::HTMLInputElement::defaultEventHandler):
  • page/EventHandler.cpp: (WebCore::EventHandler::handleMouseDoubleClickEvent): (WebCore::EventHandler::handleMouseReleaseEvent):

TBR=commit-queue@webkit.org
Review URL: http://codereview.chromium.org/6250083

11:22 Changeset [77264] by dbates@webkit.org
  • 2 edits in trunk/Tools

2011-02-01 Scott Cameron <sccameron@rim.com>

Reviewed by Daniel Bates.

Use Windows format for MinGW HTTPD path.
https://bugs.webkit.org/show_bug.cgi?id=53503

  • Scripts/webkitperl/httpd.pm:
    • Use single-quotes around MySys value for $httpdPath in getHTTPDPath() so that we don't have to escape the space characters in the path. Also, changed path to Windows-style path and removed FIXME comment.
11:21 Changeset [77263] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2011-02-01 Mihai Parparita <mihaip@chromium.org>

Unreviewed. Include actual values in fast/canvas/webgl/gl-teximage.html
(removed by r77129) in the case of failure.

  • fast/canvas/webgl/gl-teximage.html:
11:16 Changeset [77262] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

2011-01-31 Abhishek Arya <inferno@chromium.org>

Reviewed by Dan Bernstein.

Tests that a removed svg style element is not accessed again in document's
style recalc code and does not result in crash.
https://bugs.webkit.org/show_bug.cgi?id=53441

  • fast/css/stylesheet-candidate-nodes-crash-expected.txt: Added.
  • fast/css/stylesheet-candidate-nodes-crash.xhtml: Added.

2011-02-01 Abhishek Arya <inferno@chromium.org>

Reviewed by Dan Bernstein.

Do not add a node in the document's stylesheet candidate node list if the
node is already removed from document.
https://bugs.webkit.org/show_bug.cgi?id=53441

Test: fast/css/stylesheet-candidate-nodes-crash.xhtml

  • dom/Document.cpp: (WebCore::Document::addStyleSheetCandidateNode):
11:09 Changeset [77261] by dglazkov@chromium.org
  • 2 edits in trunk/LayoutTests

2011-02-01 Dimitri Glazkov <dglazkov@chromium.org>

More flakiness updates.

  • platform/chromium/test_expectations.txt: Moar flakiness recorded.
10:50 Changeset [77260] by dbates@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-02-01 Daniel Bates <dbates@rim.com>

Reviewed by Antonio Gomes.

Modify RandomNumberSeed.h to use USE(MERSENNE_TWISTER_19937)
https://bugs.webkit.org/show_bug.cgi?id=53506

Currently, use of the Mersenne Twister pseudorandom number generator
is hardcoded to the Windows CE port. With the passing of bug #53253,
we can generalize support for this PRNG to all ports that use srand(3)
and rand(3), including Windows CE.

  • wtf/RandomNumberSeed.h: (WTF::initializeRandomNumberGenerator):
10:49 Changeset [77259] by hyatt@apple.com
  • 1 edit in trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp

Land Webpage.cpp for previous patch. Change was lost after conflict resolution from a merge.

10:46 Changeset [77258] by hyatt@apple.com
  • 1 edit in trunk/Source/WebKit2/Platform/CoreIPC/Connection.cpp

Back out accidental commit of Connection.cpp

10:44 Changeset [77257] by hyatt@apple.com
  • 17 edits in trunk/Source

https://bugs.webkit.org/show_bug.cgi?id=46422, make printing and pagination work
with vertical text.

Reviewed by Darin Adler.

../WebCore:

Change printing functions to check writing-mode and properly swap width and height
as needed.

Fix the setScrollOrigin function so that the origin doesn't cause
scroll spasming during printing (this is only partially successful, but it's better
than it was).

Rewrite computePageRects to handle both RTL documents properly as well as vertical
text documents properly.

  • WebCore.exp.in:
  • page/FrameView.cpp:

(WebCore::FrameView::adjustViewSize):
(WebCore::FrameView::forceLayoutForPagination):

  • page/PrintContext.cpp:

(WebCore::PrintContext::computePageRects):
(WebCore::PrintContext::computePageRectsWithPageSizeInternal):
(WebCore::PrintContext::computeAutomaticScaleFactor):
(WebCore::PrintContext::spoolPage):
(WebCore::PrintContext::spoolRect):

  • page/PrintContext.h:
  • page/mac/WebCoreFrameView.h:
  • platform/ScrollView.cpp:

(WebCore::ScrollView::wheelEvent):

  • platform/ScrollView.h:
  • platform/mac/ScrollViewMac.mm:

(WebCore::ScrollView::platformSetScrollOrigin):

  • rendering/RenderView.cpp:

(WebCore::RenderView::layout):

../WebKit/mac:

Change printing functions to check writing-mode and properly swap width and height
as needed.

  • WebView/WebDynamicScrollBarsView.mm:

(-[WebDynamicScrollBarsView setScrollOrigin:updatePositionAtAll:immediately:]):

  • WebView/WebFrame.mm:

(-[WebFrame _computePageRectsWithPrintScaleFactor:pageSize:]):

  • WebView/WebFrameInternal.h:
  • WebView/WebHTMLView.mm:

(-[WebHTMLView _web_setPrintingModeRecursive]):
(-[WebHTMLView _web_clearPrintingModeRecursive]):
(-[WebHTMLView _web_setPrintingModeRecursiveAndAdjustViewSize]):
(-[WebHTMLView _beginPrintModeWithMinimumPageWidth:height:maximumPageWidth:]):
(-[WebHTMLView _beginPrintModeWithPageWidth:height:shrinkToFit:]):
(-[WebHTMLView _endPrintMode]):
(-[WebHTMLView _beginScreenPaginationModeWithPageSize:shrinkToFit:]):
(-[WebHTMLView _endScreenPaginationMode]):
(-[WebHTMLView layoutToMinimumPageWidth:height:maximumPageWidth:adjustingViewSize:]):
(-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:maximumPageLogicalWidth:adjustViewSize:paginateScreenContent:]):
(-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]):
(-[WebHTMLView _scaleFactorForPrintOperation:]):
(-[WebHTMLView setPageWidthForPrinting:]):
(-[WebHTMLView knowsPageRange:]):

../WebKit2:

Change printing functions to check writing-mode and properly swap width and height
as needed.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::computePagesForPrinting):

10:29 Changeset [77256] by mihaip@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-02-01 Mihai Parparita <mihaip@chromium.org>

Unreviewed roll of Chromium deps to r73306. This picks up a fix to get
the WebKit root dir correctly after the move to Source/. This allows
tests like http/tests/security/frame-loading-via-document-write.html
(which use LayoutTestController.pathToLocalResource) to pass with the
Chromium DRT.

  • DEPS:
09:57 Changeset [77255] by dglazkov@chromium.org
  • 2 edits in trunk/LayoutTests

2011-02-01 Dimitri Glazkov <dglazkov@chromium.org>

Updated flaky test expectations according to build bot results.

  • platform/chromium/test_expectations.txt: Flakiness recorded.
09:22 Changeset [77254] by mnaganov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-02-01 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Fix profiles reset to avoid clearing heap profiles in Chromium.

https://bugs.webkit.org/show_bug.cgi?id=53500

  • inspector/InspectorProfilerAgent.cpp: (WebCore::InspectorProfilerAgent::resetFrontendProfiles):
09:09 Changeset [77253] by kbalazs@webkit.org
  • 6 edits in trunk/Tools

2011-02-01 Balazs Kelemen <kbalazs@webkit.org>

Reviewed by Andreas Kling.

[Qt][WK2] Add a way to use shared process model in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=53090

  • MiniBrowser/qt/BrowserView.cpp: (BrowserView::BrowserView): Removed the m_context member. From now the context is guaranteed to be non-null and we don't need to store that in the object.
  • MiniBrowser/qt/BrowserView.h:
  • MiniBrowser/qt/BrowserWindow.cpp: Added static bool to determine that new windows need to be created with their own context or not. Use the same context and web process by default to be inilne with the other ports. (BrowserWindow::BrowserWindow): (BrowserWindow::newWindow):
  • MiniBrowser/qt/BrowserWindow.h:
  • MiniBrowser/qt/main.cpp: (main): Added command line switch to be able to use the non-shared process model. Simplify the handling of the command line switches a little bit.
08:59 Changeset [77252] by mnaganov@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-02-01 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Chromium] Landing detailed heap snapshots, part 1.

https://bugs.webkit.org/show_bug.cgi?id=53173

Adding code for accessing heap snapshot data and
performing graph calculations.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/HeapSnapshot.js: (WebInspector.HeapSnapshotArraySlice): Helper class to avoid array contents copying. (WebInspector.HeapSnapshotEdge): Wrapper for accessing graph edge properties. (WebInspector.HeapSnapshotEdgeIterator): (WebInspector.HeapSnapshotNode): Wrapper for accessing graph node properties. (WebInspector.HeapSnapshotNodeIterator): (WebInspector.HeapSnapshot): Wrapper for the heap snapshot. (WebInspector.HeapSnapshotFilteredOrderedIterator): (WebInspector.HeapSnapshotEdgesProvider): (WebInspector.HeapSnapshotNodesProvider): (WebInspector.HeapSnapshotPathFinder):
  • inspector/front-end/HeapSnapshotView.js: (WebInspector.HeapSnapshotView.prototype._convertSnapshot):
07:46 Changeset [77251] by aroben@apple.com
  • 2 edits in trunk/Source/WebCore

Fix linker warnings in Release_LTCG builds

  • WebCore.vcproj/WebCore.vcproj: Exclude EventNames.cpp and EventTarget.cpp from all

configurations, since they get pulled in via DOMAllInOne.cpp.

06:57 Changeset [77250] by zoltan@webkit.org
  • 3 edits in trunk/Tools

[Qt] Add Window menu and Toggle FullScreen action to MiniBrowser.
https://bugs.webkit.org/show_bug.cgi?id=53491

Reviewed by Andreas Kling.

  • MiniBrowser/qt/BrowserWindow.cpp:

(BrowserWindow::BrowserWindow):
(BrowserWindow::toggleFullScreenMode):

  • MiniBrowser/qt/BrowserWindow.h:
06:53 Changeset [77249] by apavlov@chromium.org
  • 6 edits in trunk/Source

2011-02-01 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [Chromium] Wrongly labelled context-menu item for links in Web Inspector's side-pane
https://bugs.webkit.org/show_bug.cgi?id=53482

  • English.lproj/localizedStrings.js:
  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.populateHrefContextMenu):
  • inspector/front-end/inspector.js: (WebInspector.resourceForURL): (WebInspector.openLinkExternallyLabel):

2011-02-01 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [Chromium] Wrongly labelled context-menu item for links in Web Inspector's side-pane
https://bugs.webkit.org/show_bug.cgi?id=53482

  • src/js/DevTools.js: (WebInspector.openLinkExternallyLabel): Override to customize a context menu item label
06:40 Changeset [77248] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-02-01 Dave Tapuska <dtapuska@rim.com>

Reviewed by Gavin Barraclough.

MacroAssemblerARM would generate code that did 32bit loads
on addresses that were not aligned. More specifically it would
generate a ldr r8,[r1, #7] which isn't valid on ARMv5 and lower.
The intended instruction really is ldrb r8,[r1, #7]; ensure we
call load8 instead of load32.

https://bugs.webkit.org/show_bug.cgi?id=46095

  • assembler/MacroAssemblerARM.h: (JSC::MacroAssemblerARM::set32Test32): (JSC::MacroAssemblerARM::set32Test8):
06:38 Changeset [77247] by ossy@webkit.org
  • 1 edit
    1 copy in trunk/LayoutTests

Unreviewed.

fast/loader/onload-policy-ignore-for-frame.html fails on Qt bot
https://bugs.webkit.org/show_bug.cgi?id=53490

Add Qt specific expected result.

  • platform/qt/fast/loader/onload-policy-ignore-for-frame-expected.txt: Copied from LayoutTests/fast/loader/onload-policy-ignore-for-frame-expected.txt.
06:35 Changeset [77246] by antonm@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-02-01 Anton Muhin <antonm@chromium.org>

Reviewed by Adam Barth.

Propagate parent document security origin to newly create Document XML response
https://bugs.webkit.org/show_bug.cgi?id=53444

Covered by the existing tests.

  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::responseXML):
05:32 Changeset [77245] by zoltan@webkit.org
  • 3 edits in trunk/Tools

[Qt] Add Toggle Frame Flattening, Auto Load Images and Disable JavaScript actions to MiniBrowser.
https://bugs.webkit.org/show_bug.cgi?id=53489

Reviewed by Andreas Kling.

Add Toggle Frame Flattening action to Develop menu. Add Auto Load Images and Disable JavaScript actions
to Settings menu.

  • MiniBrowser/qt/BrowserWindow.cpp:

(BrowserWindow::BrowserWindow):
(BrowserWindow::toggleFrameFlattening):
(BrowserWindow::toggleDisableJavaScript):
(BrowserWindow::toggleAutoLoadImages):

  • MiniBrowser/qt/BrowserWindow.h:
05:07 Changeset [77244] by mnaganov@chromium.org
  • 3 edits in branches/chromium/648/Source/WebCore/inspector/front-end

Merge 77127 - 2011-01-30 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: speed up network panel rendering.
https://bugs.webkit.org/show_bug.cgi?id=53397

  • inspector/front-end/DataGrid.js: (WebInspector.DataGrid.prototype.get scrollContainer):
  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype.elementsToRestoreScrollPositionsFor): (WebInspector.NetworkPanel.prototype._positionSummaryBar): (WebInspector.NetworkPanel.prototype._createTable): (WebInspector.NetworkPanel.prototype._exportResource): (WebInspector.NetworkPanel.prototype._onScroll):
  • inspector/front-end/networkPanel.css: (.network-sidebar .data-grid.small tr.offscreen): (.network-sidebar .data-grid tr.offscreen): (.network-sidebar .data-grid tr.offscreen td):

TBR=pfeldman@chromium.org
Review URL: http://codereview.chromium.org/6409044

04:42 Changeset [77243] by gyuyoung.kim@samsung.com
  • 3 edits in trunk/Source/WebKit/efl

2011-02-01 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Antonio Gomes.

[EFL] Add an API to get proxy address.
https://bugs.webkit.org/show_bug.cgi?id=52990

Gets the proxy URI from network backend. This API returns a proxy URI
which is set up by ewk_settings_proxy_uri_set(). But, it only implements
this API for libsoup backend.

  • ewk/ewk_settings.cpp: (ewk_settings_proxy_uri_get):
  • ewk/ewk_settings.h:
04:42 Changeset [77242] by darin@chromium.org
  • 9 edits in trunk/Source

2011-02-01 Darin Fisher <darin@chromium.org>

Reviewed by Eric Seidel.

Fix some Visual Studio compiler warnings.
https://bugs.webkit.org/show_bug.cgi?id=53476

  • wtf/MathExtras.h: (clampToInteger): (clampToPositiveInteger):
  • wtf/ThreadingWin.cpp: (WTF::absoluteTimeToWaitTimeoutInterval):

2011-02-01 Darin Fisher <darin@chromium.org>

Reviewed by Eric Seidel.

Fix some Visual Studio compiler warnings.
https://bugs.webkit.org/show_bug.cgi?id=53476

  • src/GraphicsContext3DChromium.cpp: (WebCore::GraphicsContext3DInternal::paintRenderingResultsToCanvas):
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::forms):
  • src/WebMediaPlayerClientImpl.cpp: (WebKit::WebMediaPlayerClientImpl::repaint):
  • src/WebScrollbarImpl.cpp: (WebKit::WebScrollbarImpl::setValue):
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::doPixelReadbackToCanvas): (WebKit::WebViewImpl::setZoomLevel): (WebKit::WebViewImplScrollbarPaintInterface::paint):
04:16 Changeset [77241] by yurys@chromium.org
  • 5 edits
    2 deletes in trunk

2011-02-01 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Rollout r77230 which caused many layout tests
crashes on Chromium Debug bots.

Async event handlers should not fire within a modal dialog
https://bugs.webkit.org/show_bug.cgi?id=53202

  • dom/Document.cpp: (WebCore::Document::Document):
  • dom/EventQueue.cpp: (WebCore::EventQueue::EventQueue): (WebCore::EventQueue::enqueueEvent): (WebCore::EventQueue::pendingEventTimerFired):
  • dom/EventQueue.h:

2011-02-01 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Rollout r77230 which caused many layout tests
crashes on Chromium Debug bots.

Async event handlers should not fire within a modal dialog
https://bugs.webkit.org/show_bug.cgi?id=53202

  • fast/events/scroll-event-during-modal-dialog-expected.txt: Removed.
  • fast/events/scroll-event-during-modal-dialog.html: Removed.
02:48 Changeset [77240] by zherczeg@webkit.org
  • 15 edits in trunk/Source/WebCore

LightElement changes does not require relayout.
https://bugs.webkit.org/show_bug.cgi?id=53232

Reviewed by Dirk Schulze.

When an attribute of a LightElement changes, it
send an update message to the lighting filters
to update its corresponding LightSource objects,
and repaint the filters.

Duplicated 'id' attributes removed from svg-filter-animation.svg.

Existing dynamic-update tests covers this feature.

5x speedup on manual-tests/svg-filter-animation.svg

  • manual-tests/svg-filter-animation.svg:
  • platform/graphics/filters/DistantLightSource.h:
  • platform/graphics/filters/FEDiffuseLighting.cpp:

(WebCore::FEDiffuseLighting::setLightingColor):
(WebCore::FEDiffuseLighting::setSurfaceScale):
(WebCore::FEDiffuseLighting::setDiffuseConstant):
(WebCore::FEDiffuseLighting::setKernelUnitLengthX):
(WebCore::FEDiffuseLighting::setKernelUnitLengthY):

  • platform/graphics/filters/FEDiffuseLighting.h:
  • platform/graphics/filters/LightSource.cpp:

(WebCore::PointLightSource::setX):
(WebCore::PointLightSource::setY):
(WebCore::PointLightSource::setZ):
(WebCore::SpotLightSource::setX):
(WebCore::SpotLightSource::setY):
(WebCore::SpotLightSource::setZ):
(WebCore::SpotLightSource::setPointsAtX):
(WebCore::SpotLightSource::setPointsAtY):
(WebCore::SpotLightSource::setPointsAtZ):
(WebCore::SpotLightSource::setSpecularExponent):
(WebCore::SpotLightSource::setLimitingConeAngle):
(WebCore::DistantLightSource::setAzimuth):
(WebCore::DistantLightSource::setElevation):
(WebCore::LightSource::setAzimuth):
(WebCore::LightSource::setElevation):
(WebCore::LightSource::setX):
(WebCore::LightSource::setY):
(WebCore::LightSource::setZ):
(WebCore::LightSource::setPointsAtX):
(WebCore::LightSource::setPointsAtY):
(WebCore::LightSource::setPointsAtZ):
(WebCore::LightSource::setSpecularExponent):
(WebCore::LightSource::setLimitingConeAngle):

  • platform/graphics/filters/LightSource.h:
  • platform/graphics/filters/PointLightSource.h:
  • platform/graphics/filters/SpotLightSource.h:
  • rendering/svg/RenderSVGResourceFilter.cpp:

(WebCore::RenderSVGResourceFilter::primitiveAttributeChanged):

  • svg/SVGFEDiffuseLightingElement.cpp:

(WebCore::SVGFEDiffuseLightingElement::setFilterEffectAttribute):
(WebCore::SVGFEDiffuseLightingElement::lightElementAttributeChanged):
(WebCore::SVGFEDiffuseLightingElement::build):
(WebCore::SVGFEDiffuseLightingElement::findLightElement):
(WebCore::SVGFEDiffuseLightingElement::findLight):

  • svg/SVGFEDiffuseLightingElement.h:
  • svg/SVGFELightElement.cpp:

(WebCore::SVGFELightElement::svgAttributeChanged):

  • svg/SVGFilterPrimitiveStandardAttributes.cpp:

(WebCore::SVGFilterPrimitiveStandardAttributes::setFilterEffectAttribute):

  • svg/SVGFilterPrimitiveStandardAttributes.h:
02:41 Changeset [77239] by rolandsteiner@chromium.org
  • 11 edits
    2 adds in trunk/Source/WebCore

2011-02-01 Roland Steiner <rolandsteiner@chromium.org>

Reviewed by Dimitri Glazkov.

Bug 53289 - DOM: Move DocumentOrderedMap from Document into separate files
https://bugs.webkit.org/show_bug.cgi?id=53289

Moving the nested class DocumentOrderedMap from Document into separate files,
updating code where necessary.

No new tests. (refactoring)

  • Android.mk:
  • CMakeLists.txt:
  • GNUMakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/Document.cpp: (WebCore::Document::getElementById): (WebCore::Document::getImageMap):
  • dom/Document.h:
  • dom/DocumentOrderedMap.cpp: Added. (WebCore::keyMatchesId): (WebCore::keyMatchesMapName): (WebCore::keyMatchesLowercasedMapName): (WebCore::DocumentOrderedMap::clear): (WebCore::DocumentOrderedMap::add): (WebCore::DocumentOrderedMap::remove): (WebCore::DocumentOrderedMap::get): (WebCore::DocumentOrderedMap::getElementById): (WebCore::DocumentOrderedMap::getElementByMapName): (WebCore::DocumentOrderedMap::getElementByLowercasedMapName):
  • dom/DocumentOrderedMap.h: Added. (WebCore::DocumentOrderedMap::contains): (WebCore::DocumentOrderedMap::containsMultiple):
  • dom/DOMAllInOne.cpp:
02:32 Changeset [77238] by commit-queue@webkit.org
  • 1 edit in trunk/ChangeLog

2010-01-28 Commit Queue <commit-queue@webkit.org>

Unreviewed. Test commit for commit-queue@webkit.org.

02:27 Changeset [77237] by commit-queue@webkit.org
  • 1 edit in trunk/ChangeLog

2010-01-28 Commit Queue <commit-queue@webkit.org>

Unreviewed. Test commit for commit-queue@webkit.org.

02:18 Changeset [77236] by hans@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-02-01 Hans Wennborg <hans@chromium.org>

Reviewed by Jeremy Orlow.

Chromium: remove WebIDBCallbacks::onSucces()
https://bugs.webkit.org/show_bug.cgi?id=53415

Remove un-used function.

  • public/WebIDBCallbacks.h:
01:58 Changeset [77235] by mario@webkit.org
  • 4 edits in trunk/Source

2011-02-01 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Martin Robinson.

[Gtk] atk_text_set_caret_offset fails for list items
https://bugs.webkit.org/show_bug.cgi?id=53388

Allow using text ranges across list items.

  • accessibility/gtk/AccessibilityObjectAtk.cpp: (WebCore::AccessibilityObject::allowsTextRanges): Add list items to the list of accessibility objects supporting text ranges.

2011-02-01 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Martin Robinson.

[Gtk] atk_text_set_caret_offset fails for list items
https://bugs.webkit.org/show_bug.cgi?id=53388

Update unit test to check the fix for this bug.

  • tests/testatk.c: (testWebkitAtkCaretOffsets): Ensure setting the caret in a list item through the AtkText interface is possible.
01:54 Changeset [77234] by mario@webkit.org
  • 4 edits in trunk/Source

2011-02-01 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Martin Robinson.

[GTK] character range extents is off when the end of a wrapped line is included
https://bugs.webkit.org/show_bug.cgi?id=53323

Fixed wrong calculation getting the range extents.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_text_get_range_extents): Removed '+1' since the requested interval shouldn't include the last character.

2011-02-01 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Martin Robinson.

[GTK] character range extents is off when the end of a wrapped line is included
https://bugs.webkit.org/show_bug.cgi?id=53323

Update unit test to check the fix for this bug.

  • tests/testatk.c: (testWebkitAtkGetExtents): Check that the extent for a full line are the same height than for a partial section of the same line.
01:49 Changeset [77233] by mario@webkit.org
  • 4 edits in trunk/Source

2011-02-01 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Caret Offset is one off at the end of wrapped lines
https://bugs.webkit.org/show_bug.cgi?id=53300

Consider linebreaks as special cases.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (objectAndOffsetUnignored): In order to avoid getting wrong values when around linebreaks, we need to workaround this by explicitly avoiding those '\n' text nodes from affecting the result of calling to TextIterator:rangeLength().

2011-02-01 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Caret Offset is one off at the end of wrapped lines
https://bugs.webkit.org/show_bug.cgi?id=53300

Update unit test to check the fix for this bug.

  • tests/testatk.c: (testWebkitAtkCaretOffsetsAndExtranousWhiteSpaces): Set and get the caret offset at the edge of the line.
01:37 Changeset [77232] by yurys@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-02-01 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Fix Chromium Debug compilation broken by r77228.

[Chromium] Autofill should work with HTML5 form elements
https://bugs.webkit.org/show_bug.cgi?id=51809

  • src/WebInputElement.cpp: (WebKit::toWebInputElement):
01:32 Changeset [77231] by rolandsteiner@chromium.org
  • 11 edits
    2 deletes in trunk/Source/WebCore

2011-02-01 Roland Steiner <rolandsteiner@chromium.org>

Unreviewed, rolling out r77229.
http://trac.webkit.org/changeset/77229
https://bugs.webkit.org/show_bug.cgi?id=53289

revert mysterious build breakage

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/DOMAllInOne.cpp:
  • dom/Document.cpp: (WebCore::Document::DocumentOrderedMap::clear): (WebCore::Document::DocumentOrderedMap::add): (WebCore::Document::DocumentOrderedMap::remove): (WebCore::Document::DocumentOrderedMap::get): (WebCore::keyMatchesId): (WebCore::Document::getElementById): (WebCore::keyMatchesMapName): (WebCore::keyMatchesLowercasedMapName): (WebCore::Document::getImageMap):
  • dom/Document.h: (WebCore::Document::DocumentOrderedMap::contains): (WebCore::Document::DocumentOrderedMap::containsMultiple):
  • dom/DocumentOrderedMap.cpp: Removed.
  • dom/DocumentOrderedMap.h: Removed.
01:20 Changeset [77230] by mihaip@chromium.org
  • 5 edits
    2 adds in trunk

2011-02-01 Mihai Parparita <mihaip@chromium.org>

Reviewed by James Robinson.

Async event handlers should not fire within a modal dialog
https://bugs.webkit.org/show_bug.cgi?id=53202

Add tests for a scroll event triggered right before a modal dialog is
shown.

  • fast/events/scroll-event-during-modal-dialog-expected.txt: Added.
  • fast/events/scroll-event-during-modal-dialog.html: Added.

2011-02-01 Mihai Parparita <mihaip@chromium.org>

Reviewed by James Robinson.

Async event handlers should not fire within a modal dialog
https://bugs.webkit.org/show_bug.cgi?id=53202

Asychronous events that use EventQueue would currently fire while a
modal dialog (e.g. window.alert()) was up. Change EventQueue to use a
SuspendableTimer (which automatically gets suspended while dialogs are
up and in other cases where JS execution is not allowed).

Test: fast/events/scroll-event-during-modal-dialog.html

  • dom/Document.cpp: (WebCore::Document::Document):
  • dom/EventQueue.cpp: (WebCore::EventQueueTimer::EventQueueTimer): (WebCore::EventQueueTimer::fired): (WebCore::EventQueue::EventQueue): (WebCore::EventQueue::enqueueEvent): (WebCore::EventQueue::pendingEventTimerFired):
  • dom/EventQueue.h: (WebCore::EventQueue::create):
01:11 Changeset [77229] by rolandsteiner@chromium.org
  • 11 edits
    2 adds in trunk/Source/WebCore

2011-01-28 Roland Steiner <rolandsteiner@chromium.org>

Reviewed by NOBODY (OOPS!).

Bug 53289 - DOM: Move DocumentOrderedMap from Document into separate files
https://bugs.webkit.org/show_bug.cgi?id=53289

Moving the nested class DocumentOrderedMap from Document into separate files,
updating code where necessary.

No new tests. (refactoring)

  • Android.mk:
  • CMakeLists.txt:
  • GNUMakefile.am
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/Document.cpp: (WebCore::Document::getElementById): (WebCore::Document::getImageMap):
  • dom/Document.h:
  • dom/DocumentOrderedMap.cpp: Added. (WebCore::keyMatchesId): (WebCore::keyMatchesMapName): (WebCore::keyMatchesLowercasedMapName): (WebCore::DocumentOrderedMap::clear): (WebCore::DocumentOrderedMap::add): (WebCore::DocumentOrderedMap::remove): (WebCore::DocumentOrderedMap::get): (WebCore::DocumentOrderedMap::getElementById): (WebCore::DocumentOrderedMap::getElementByMapName): (WebCore::DocumentOrderedMap::getElementByLowercasedMapName):
  • dom/DocumentOrderedMap.h: Added. (WebCore::DocumentOrderedMap::contains): (WebCore::DocumentOrderedMap::containsMultiple):
  • dom/DOMAllInOne.cpp:
00:54 Changeset [77228] by commit-queue@webkit.org
  • 9 edits in trunk/Source

2011-02-01 Naoki Takano <takano.naoki@gmail.com>

Reviewed by Darin Fisher.

[Chromium] Autofill should work with HTML5 form elements
https://bugs.webkit.org/show_bug.cgi?id=51809
http://crbug.com/65654

No new tests, because this fix is for Chromium project and hard to test only in WebKit project.

  • html/InputType.h: Insert comment for canSetSuggestedValue().
  • html/TextFieldInputType.cpp: (WebCore::TextFieldInputType::canSetSuggestedValue): Implemented to return always true for that all text filed inputs can be completed.
  • html/TextFieldInputType.h: Declare canSetSuggestedValue().
  • html/TextInputType.cpp: Delete canSetSuggestedValue() not to return true anymore.
  • html/TextInputType.h: Delete canSetSuggestedValue() not to return true anymore.

2011-02-01 Naoki Takano <takano.naoki@gmail.com>

Reviewed by Darin Fisher.

[Chromium] Autofill should work with HTML5 form elements
https://bugs.webkit.org/show_bug.cgi?id=51809
http://crbug.com/65654

No new tests, because this fix is for Chromium project and hard to test only in WebKit project.

  • public/WebInputElement.h: Added toWebInputElement() declarations and implemented const version of toWebInputElement().
  • src/WebInputElement.cpp: (WebKit::WebInputElement::toWebInputElement): Implemented a convert function to cast no-const WebElement* to no-const WebInputElement*. Because Chrome needs safe cast for autofill completion.
00:32 Changeset [77227] by mrowe@apple.com
  • 5 edits in branches/safari-533.20-branch

Merge r74788.

00:32 Changeset [77226] by mrowe@apple.com
  • 3 edits
    3 adds in branches/safari-533.20-branch

Merge r68307.

00:22 Changeset [77225] by mrowe@apple.com
  • 6 edits
    4 adds in branches/safari-533.20-branch

Merge r72040 and r72135.

00:05 Changeset [77224] by tkent@chromium.org
  • 5 edits in trunk

REGRESSION (r65062): Safari loops forever under WebCore::plainTextToMallocAllocatedBuffer()
https://bugs.webkit.org/show_bug.cgi?id=53272

Reviewed by Dan Bernstein.

Source/WebCore:

  • editing/TextIterator.cpp:

(WebCore::TextIterator::handleTextBox): Pass the appropriate renderer to emitText().

LayoutTests:

  • fast/dom/inner-text-first-letter.html:
    • Add a new test case reproducing the bug.
    • Remove unnecessary text output.
  • fast/dom/inner-text-first-letter-expected.txt:

01/31/11:

23:54 Changeset [77223] by mrowe@apple.com
  • 5 edits
    3 adds in branches/safari-533.20-branch

Merge r71724.

23:44 Changeset [77222] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533.20-branch

Merge r71686.

23:41 Changeset [77221] by mrowe@apple.com
  • 11 edits in branches/safari-533.20-branch/WebCore

Merge r71641.

21:53 Changeset [77220] by ap@apple.com
  • 4 edits in trunk/Source

Reviewed by Maciej Stachowiak.

https://bugs.webkit.org/show_bug.cgi?id=53466
Move WebKit2 to printing via API methods

Also fixes <rdar://problem/8933724> REGRESSION: Wrong pages are printed when not printing from page 1

Also fixes horizontal tiling (no bug filed).

The main idea here is that we don't force AppKit to use a different scaling factor when
a Web view can't be resized to exact page size, and scale when drawing instead.

  • UIProcess/API/mac/WKPrintingView.mm: (-[WKPrintingView _firstPrintedPageNumber]): Factored out into a separate method. (-[WKPrintingView _lastPrintedPageNumber]): Ditto. (pageDidDrawToPDF): Avoid crashing if data is null. (-[WKPrintingView _preparePDFDataForPrintingOnSecondaryThread]): Use -_firstPrintedPageNumber and -_lastPrintedPageNumber. (pageDidComputePageRects): Set frame size to what it would have been for a normal NSView that's been asked to resize. (-[WKPrintingView _pageForRect:]): Check x(), because several pages can be at the same y() when tiling horizontally. (-[WKPrintingView _drawPDFDocument:page:atPoint:]): Point to draw at and frame size are now using different units, translate as appropriate. (-[WKPrintingView _drawPreview:]): Scale the rect to WebCore units. (-[WKPrintingView drawRect:]): Correctly calculate page number when the first page to print isn't page 1. (-[WKPrintingView rectForPage:]): Scale the rect to AppKit units.
21:51 Changeset [77219] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-01-31 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed Chromium test expectation updates.

Removed media/controls-strict.html and svg/custom/clip-path-referencing-use2.svg (Mac)
since it has been passing since r77171 and r77172-r77173 respectively.

Also removed http/tests/media/reload-after-dialog.html because it has been passing for a while.

  • platform/chromium/test_expectations.txt:
21:50 Changeset [77218] by mrowe@apple.com
  • 5 edits in branches/safari-533.20-branch

Versioning.

21:50 Changeset [77217] by mrowe@apple.com
  • 1 copy in tags/Safari-533.20.20

New tag.

21:40 Changeset [77216] by paroga@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-01-31 Patrick Gansterer <paroga@webkit.org>

Reviewed by Adam Barth.

Remove obsolete comment after r41871
https://bugs.webkit.org/show_bug.cgi?id=53406

  • dom/Document.h:
21:33 Changeset [77215] by simon.fraser@apple.com
  • 2 edits in trunk/Source/WebCore

2011-01-31 Simon Fraser <simon.fraser@apple.com>

Fix according to reviewer comments: can just use Color::black now.

  • platform/graphics/ShadowBlur.cpp: (WebCore::ShadowBlur::drawInsetShadow): (WebCore::ShadowBlur::drawRectShadowWithoutTiling):
21:31 Changeset [77214] by mrowe@apple.com
  • 3 edits in branches/safari-533.20-branch/WebCore

Build fix.

21:19 Changeset [77213] by simon.fraser@apple.com
  • 3 edits in trunk/Source/WebCore

2011-01-31 Simon Fraser <simon.fraser@apple.com>

Reviewed by Sam Weinig.

Clean up ShadowBlur
https://bugs.webkit.org/show_bug.cgi?id=53472

Some minor ShadowBlur cleanup.

  • platform/graphics/ShadowBlur.h:
  • platform/graphics/ShadowBlur.cpp: (WebCore::ShadowBlur::ShadowBlur): Use m_blurRadius rather than the radius paramter. (WebCore::ShadowBlur::adjustBlurRadius): Renamed from adjustBlurDistance. (WebCore::ShadowBlur::calculateLayerBoundingRect): Rename layerFloatRect to layerRect. Make frameSize a float. (WebCore::ShadowBlur::beginShadowLayer): This now takes a precomputed layerRect rather than calling calculateLayerBoundingRect() to compute it itself, since we were calling calculateLayerBoundingRect() twice. (WebCore::ShadowBlur::drawRectShadow): Optimize to call calculateLayerBoundingRect() only once. The shadowRect variable was unused, so two return paths could be collapsed into one. (WebCore::ShadowBlur::drawInsetShadow): Call calculateLayerBoundingRect() before beginShadowLayer() now. (WebCore::ShadowBlur::drawRectShadowWithoutTiling): The layerRect gets passed in. We always used alpha=1, so no need to pass that in. (WebCore::ShadowBlur::drawRectShadowWithTiling): We always used alpha=1, so no need to pass that in. Move shadowRect down to first use. ShadowBlur::clipBounds() was unused.
20:34 Changeset [77212] by noam.rosenthal@nokia.com
  • 4 edits in trunk/Source

2011-01-31 No'am Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] QWebElements example from QtWebKit Bridge documentation does not work at all
https://bugs.webkit.org/show_bug.cgi?id=46748

This problem disappears when we register QWebElement using qRegisterMetaType, which we now do in QtInstance.
Added a regression test to tst_QWebFrame.

  • bridge/qt/qt_instance.cpp: (JSC::Bindings::QtInstance::QtInstance):

2011-01-31 No'am Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] QWebElements example from QtWebKit Bridge documentation does not work at all
https://bugs.webkit.org/show_bug.cgi?id=46748

Problem was that we need to register QWebElement's variant-type to Qt's meta type system at some point.
This wasn't caught by previous tests inside tst_QWebFrame because it only appears when there's also a QWebElement property.
Added a regression test to tst_QWebFrame.

  • tests/qwebframe/tst_qwebframe.cpp: (MyWebElementSlotOnlyObject::doSomethingWithWebElement): (MyWebElementSlotOnlyObject::tagName):
20:05 Changeset [77211] by morrita@google.com
  • 8 edits in trunk/Source/WebCore

2011-01-27 MORITA Hajime <morrita@google.com>

Reviewed by Dimitri Glazkov.

Convert <progress> shadow DOM to a DOM-based shadow.
https://bugs.webkit.org/show_bug.cgi?id=50660

  • Removed RenderProgress::m_valuePart, moved the shadow node to the shadow root of HTMLProgressElement.
  • Removed hard-coded pseudo ID for -webkit-progress-bar-value. ProgressBarValueElement is defined only for overriding shadowPseudoId().

No new tests. No behavioral change.

  • css/CSSSelector.cpp: (WebCore::CSSSelector::pseudoId): (WebCore::nameToPseudoTypeMap): (WebCore::CSSSelector::extractPseudoType):
  • css/CSSSelector.h:
  • html/HTMLProgressElement.cpp: (WebCore::ProgressBarValueElement::ProgressBarValueElement): (WebCore::ProgressBarValueElement::shadowPseudoId): (WebCore::ProgressBarValueElement::create): (WebCore::ProgressBarValueElement::detach): (WebCore::HTMLProgressElement::parseMappedAttribute): (WebCore::HTMLProgressElement::attach): (WebCore::HTMLProgressElement::valuePart): (WebCore::HTMLProgressElement::didElementStateChange): (WebCore::HTMLProgressElement::createShadowSubtreeIfNeeded):
  • html/HTMLProgressElement.h:
  • rendering/RenderProgress.cpp: (WebCore::RenderProgress::~RenderProgress): (WebCore::RenderProgress::updateFromElement): (WebCore::RenderProgress::layoutParts): (WebCore::RenderProgress::shouldHaveParts): (WebCore::RenderProgress::valuePart):
  • rendering/RenderProgress.h:
  • rendering/style/RenderStyleConstants.h:
20:04 Changeset [77210] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-01-31 Charlie Reis <creis@chromium.org>

Reviewed by Mihai Parparita.

Add sanity check to help diagnose bug 52819
https://bugs.webkit.org/show_bug.cgi?id=53402

Crash early if the children of fromItem look invalid.

  • loader/HistoryController.cpp:
19:56 Changeset [77209] by rniwa@webkit.org
  • 1 edit in trunk/LayoutTests/ChangeLog

Fix the change log entry order.

19:54 Changeset [77208] by rniwa@webkit.org
  • 3 edits in trunk/LayoutTests

2011-01-31 Emil A Eklund <eae@chromium.org>

Reviewed by Darin Adler.

Setting "selected" attribute to false should have no effect in single line <select>
https://bugs.webkit.org/show_bug.cgi?id=52436

Add test for changing the selection in a one-line select element using\
the option.selected property.

  • fast/dom/HTMLSelectElement/selected-false-expected.txt: Added.
  • fast/dom/HTMLSelectElement/selected-false.html: Added.
19:46 Changeset [77207] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-01-31 Kalle Vahlman <kalle.vahlman@movial.com>

Reviewed by Andreas Kling.

[Qt] canvas.drawImage(HTMLVideoElement) doesn't work with Qt Multimedia backend
https://bugs.webkit.org/show_bug.cgi?id=53325

Reimplement paintCurrentFrameInContext() rather than delegate the
rendering to paint() to make sure we really do get the video frame
content into the GraphicsContext, regardless of accelerated
compositing and the video scene state.

  • platform/graphics/qt/MediaPlayerPrivateQt.cpp: (WebCore::MediaPlayerPrivateQt::paintCurrentFrameInContext):
  • platform/graphics/qt/MediaPlayerPrivateQt.h:
19:45 Changeset [77206] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

2011-01-31 Emil A Eklund <eae@chromium.org>

Reviewed by Darin Adler.

Setting "selected" attribute to false should have no effect in single line <select>
https://bugs.webkit.org/show_bug.cgi?id=52436

Add test for changing the selection in a one-line select element using\
the option.selected property.

  • fast/dom/HTMLSelectElement/selected-false-expected.txt: Added.
  • fast/dom/HTMLSelectElement/selected-false.html: Added.

2011-01-31 Emil A Eklund <eae@chromium.org>

Reviewed by Darin Adler.

Setting "selected" attribute to false should have no effect in single line <select>
https://bugs.webkit.org/show_bug.cgi?id=52436

Change SelectElement::setSelectedIndex to select the first selectable
option when the select state of all options is set to false as required
by the HTML5 specification.

Test: fast/dom/HTMLSelectElement/selected-false.html

  • dom/SelectElement.cpp: (WebCore::SelectElement::setSelectedIndex):
19:27 Changeset [77205] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-01-31 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Console source references need a left-margin
https://bugs.webkit.org/show_bug.cgi?id=53308

  • inspector/front-end/inspector.css: (.console-message-url): Added a 4px margin on the left.
19:19 Changeset [77204] by mrowe@apple.com
  • 2 edits in branches/safari-533.20-branch/WebCore

Merge r73937.

19:19 Changeset [77203] by mrowe@apple.com
  • 5 edits
    2 adds in branches/safari-533.20-branch

Merge r73927.

19:08 Changeset [77202] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533.20-branch

Merge r59357.

18:54 Changeset [77201] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533.20-branch

Merge r72833.

18:54 Changeset [77200] by mrowe@apple.com
  • 11 edits
    9 adds in branches/safari-533.20-branch

Merge r72590.

18:54 Changeset [77199] by mrowe@apple.com
  • 2 edits in branches/safari-533.20-branch/LayoutTests

Merge r72353.

18:54 Changeset [77198] by mrowe@apple.com
  • 2 edits in branches/safari-533.20-branch/WebCore

Merge r72348.

18:54 Changeset [77197] by mrowe@apple.com
  • 9 edits
    8 adds in branches/safari-533.20-branch

Merge r72344.

18:53 Changeset [77196] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533.20-branch

Merge r72301.

18:53 Changeset [77195] by mrowe@apple.com
  • 4 edits in branches/safari-533.20-branch/WebCore

Merge r71947.

18:53 Changeset [77194] by mrowe@apple.com
  • 2 edits in branches/safari-533.20-branch/WebCore

Merge r71684.

18:53 Changeset [77193] by mrowe@apple.com
  • 4 edits
    4 adds in branches/safari-533.20-branch

Merge r72924.

18:53 Changeset [77192] by mrowe@apple.com
  • 4 edits
    4 adds in branches/safari-533.20-branch

Merge r72819.

18:36 Changeset [77191] by carol.szabo@nokia.com
  • 4 edits in trunk/Source/WebCore

2011-01-31 Carol Szabo <carol.szabo@nokia.com>

Reviewed by David Hyatt.

Code Changes only.

It is needlessly expensive to find the generating node from an anonymous renderer of a pseudoelement.
https://bugs.webkit.org/show_bug.cgi?id=53024

No new tests. No change in functionality

  • rendering/RenderObject.h: (WebCore::RenderObject::before): (WebCore::RenderObject::after): (WebCore::RenderObject::generatingNode): Added new accessors for the use of the CSS 2.1 counters code (mainlyly)
  • rendering/RenderObjectChildList.cpp: (WebCore::beforeAfterContainer): (WebCore::RenderObjectChildList::invalidateCounters): (WebCore::RenderObjectChildList::before): (WebCore::RenderObjectChildList::after): Refactored the code to take advantage of the new accessors. (WebCore::RenderObjectChildList::updateBeforeAfterContent): Changed to store the generating node in the :before and :after renderers.
  • rendering/RenderObjectChildList.h:
18:09 Changeset [77190] by rniwa@webkit.org
  • 7 edits in trunk/LayoutTests

2011-01-31 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed Chromium rebaselines for r77173.

  • platform/chromium-mac/fast/text/justify-ideograph-complex-expected.checksum:
  • platform/chromium-mac/fast/text/justify-ideograph-complex-expected.png:
  • platform/chromium-mac/fast/text/justify-ideograph-simple-expected.checksum:
  • platform/chromium-mac/fast/text/justify-ideograph-simple-expected.png:
  • platform/chromium-mac/fast/text/justify-ideograph-vertical-expected.checksum:
  • platform/chromium-mac/fast/text/justify-ideograph-vertical-expected.png:
18:00 Changeset [77189] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533.20-branch

Merge r75548.

17:49 Changeset [77188] by mrowe@apple.com
  • 2 edits in branches/safari-533.20-branch/WebCore

Merge r67634.

17:46 Changeset [77187] by mrowe@apple.com
  • 4 edits
    2 adds in branches/safari-533.20-branch

Merge r70594.

17:45 Changeset [77186] by commit-queue@webkit.org
  • 7 edits in trunk

2011-01-31 Krithigassree Sambamurthy <krithigassree.sambamurthy@nokia.com>

Reviewed by David Hyatt.

Add background-clip to background shorthand
https://bugs.webkit.org/show_bug.cgi?id=52080

Added test cases to check whether webkitMaskClip is correctly set when
declared as a shorthand.

  • fast/backgrounds/multiple-backgrounds-computed-style-expected.txt:
  • fast/backgrounds/script-tests/multiple-backgrounds-computed-style.js:

Added test cases to check whether background-clip is set correctly when
declared as a shorthand.

  • fast/css/background-clip-text-expected.txt:
  • fast/css/script-tests/background-clip-text.js: (test):

2011-01-31 Krithigassree Sambamurthy <krithigassree.sambamurthy@nokia.com>

Reviewed by David Hyatt.

Add background-clip to background shorthand
https://bugs.webkit.org/show_bug.cgi?id=52080

Added background-clip to background-shorthand. Also made changes to
include webkitMaskClip to the mask shorthand to keep both in sync.

  • css/CSSParser.cpp: (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseFillShorthand):
17:43 Changeset [77185] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533.20-branch

Merge r74045.

17:40 Changeset [77184] by mrowe@apple.com
  • 7 edits
    3 adds in branches/safari-533.20-branch

Merge r67568.

17:27 Changeset [77183] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

2011-01-31 Srikumar Bonda <srikumar.b@gmail.com>

Reviewed by Andreas Kling.

[Qt] ContextMenuClientQt.cpp has coding-style errors
"RefCounted.h" header inclusion style changed to <wtf/RefCounted.h>
https://bugs.webkit.org/show_bug.cgi?id=40243

  • WebCoreSupport/ContextMenuClientQt.cpp:
17:20 Changeset [77182] by darin@apple.com
  • 4 edits in trunk/Source

2011-01-31 Darin Adler <darin@apple.com>

Reviewed by Adele Peterson.

WKView should support scrollPageDown:, scrollPageUp:, scrollToBeg and other similar selectors
https://bugs.webkit.org/show_bug.cgi?id=53460

  • editing/EditorCommand.cpp: (WebCore::executeScrollPageBackward): Added. (WebCore::executeScrollPageForward): Added. (WebCore::executeScrollToBeginningOfDocument): Added. (WebCore::executeScrollToEndOfDocument): Added. (WebCore::createCommandMap): Added the four commands above to the map.

2011-01-31 Darin Adler <darin@apple.com>

Reviewed by Adele Peterson.

WKView should support scrollPageDown:, scrollPageUp:, scrollToBeg and other similar selectors
https://bugs.webkit.org/show_bug.cgi?id=53460

  • UIProcess/API/mac/WKView.mm: Added WEBCORE_COMMAND macro for lots of editor commands that are implemented in WebCore so they will get forwarded. Many of these will probably work without any further changes required. Added comments about the methods that we do not yet forward. (createSelectorExceptionMap): Map scrollPageDown: to ScrollPageForward and scrollPageUp: to ScrollPageBackward because we want the page up and page down keys to follow the document logical order, not physical order. This is equivalent to what we do in WebPage::performDefaultBehaviorForKeyEvent.
17:19 Changeset [77181] by mrowe@apple.com
  • 2 edits in branches/safari-533.20-branch/WebCore

Merge r59477.

17:14 Changeset [77180] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533.20-branch

Merge r72639.

17:10 Changeset [77179] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533.20-branch

Merge r72685.

17:02 Changeset [77178] by mrowe@apple.com
  • 3 edits
    3 adds in branches/safari-533.20-branch

Merge r69051.

17:00 Changeset [77177] by mrowe@apple.com
  • 3 edits
    4 adds in branches/safari-533.20-branch

Merge r74155.

16:57 Changeset [77176] by commit-queue@webkit.org
  • 1 edit in trunk/ChangeLog

2010-01-28 Commit Queue <commit-queue@webkit.org>

Unreviewed. Test commit for commit-queue@webkit.org.

16:50 Changeset [77175] by mrowe@apple.com
  • 5 edits in branches/safari-533.20-branch/LayoutTests

Merge r72166.

16:50 Changeset [77174] by mrowe@apple.com
  • 2 edits in branches/safari-533.20-branch/WebCore

Merge r72163.

16:44 BuildingQtOnOSX edited by andreas.kling@nokia.com
(diff)
16:30 Changeset [77173] by mitz@apple.com
  • 11 edits in trunk

Inter-ideograph justification should apply to hiragana and katakana as well
https://bugs.webkit.org/show_bug.cgi?id=53464

Reviewed by Adele Peterson.

Source/WebCore:

Changed the test for expansion opportunities from isCJKIdeograph() to isCJKIdeographOrSymbol().

  • platform/graphics/Font.cpp:

(WebCore::Font::expansionOpportunityCount):

  • platform/graphics/WidthIterator.cpp:

(WebCore::WidthIterator::advance):

  • platform/graphics/mac/ComplexTextController.cpp:

(WebCore::ComplexTextController::adjustGlyphsAndAdvances):

LayoutTests:

  • platform/mac/fast/text/justify-ideograph-complex-expected.checksum:
  • platform/mac/fast/text/justify-ideograph-complex-expected.png:
  • platform/mac/fast/text/justify-ideograph-simple-expected.checksum:
  • platform/mac/fast/text/justify-ideograph-simple-expected.png:
  • platform/mac/fast/text/justify-ideograph-vertical-expected.checksum:
  • platform/mac/fast/text/justify-ideograph-vertical-expected.png:
16:20 Changeset [77172] by mihaip@chromium.org
  • 2 edits in trunk/Tools

2011-01-31 Mihai Parparita <mihaip@chromium.org>

Reviewed by Tony Chang.

[Chromium] Switch chromium-mac to use ChromiumDriver
https://bugs.webkit.org/show_bug.cgi?id=53461

For the sake of consistency with the other Chromium platforms (and so
that chromium-mac picks up special flags like --enable-hardware-gpu),
switch chromium-mac from the WebKitDriver to ChromiumDriver.

  • Scripts/webkitpy/layout_tests/port/chromium.py:
15:54 Changeset [77171] by dglazkov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-01-31 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by James Robinson.

REGRESSION(r76951): Appearance of media controls changed slightly on Qt/Chromium ports
https://bugs.webkit.org/show_bug.cgi?id=53314

Fixes media/controls-strict.html on Chromium.

  • css/mediaControlsChromium.css: (audio::-webkit-media-controls-timeline, video::-webkit-media-controls-timeline):

Added proper box-sizing to avoid differences between strict/quirks mode.

15:50 Changeset [77170] by tkent@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-01-31 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

Validation message bubble shouldn't inherit text-security style
https://bugs.webkit.org/show_bug.cgi?id=53457

No new tests because the validation message feature depends on timers
and is enabled only in Chromium port.

  • css/html.css: (::-webkit-validation-bubble): Reset -webkit-text-security.
15:44 Changeset [77169] by mrowe@apple.com
  • 5 edits in branches/safari-533.20-branch/WebCore

Merge r74759.

15:44 Changeset [77168] by mrowe@apple.com
  • 5 edits
    5 adds in branches/safari-533.20-branch

Merge r74716.

15:44 Changeset [77167] by mrowe@apple.com
  • 5 edits in branches/safari-533.20-branch/WebCore

Merge r62016.

15:42 Changeset [77166] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-01-31 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed Chromium test expectation update.

  • platform/chromium/test_expectations.txt:
15:11 Changeset [77165] by oliver@apple.com
  • 3 edits
    3 adds in trunk

2011-01-31 Oliver Hunt <oliver@apple.com>

Reviewed by Sam Weinig.

Bogus callframe during stack unwinding
https://bugs.webkit.org/show_bug.cgi?id=53454

Add test

  • fast/js/invalid-callframe-during-unwind-expected.txt: Added.
  • fast/js/invalid-callframe-during-unwind.html: Added.
  • fast/js/script-tests/invalid-callframe-during-unwind.js: Added. (testUnwind):

2011-01-31 Oliver Hunt <oliver@apple.com>

Reviewed by Sam Weinig.

Bogus callframe during stack unwinding
https://bugs.webkit.org/show_bug.cgi?id=53454

Trying to access a callframe's globalData after destroying its
ScopeChain is not a good thing. While we could access the
globalData directly through the (known valid) scopechain we're
holding on to, it feels fragile. Instead we push the valid
ScopeChain onto the callframe again to ensure that the callframe
itself remains valid.

  • interpreter/Interpreter.cpp: (JSC::Interpreter::unwindCallFrame):
14:59 BuildingQtOnOSX edited by dglazkov@chromium.org
(diff)
14:59 Changeset [77164] by beidson@apple.com
  • 2 edits in trunk/Source/WebKit/win

Fix the clean Windows build.

Reviewed by Adam Roben.

  • WebKitGraphics.cpp:

(WebDrawText):

14:59 Changeset [77163] by dpranke@chromium.org
  • 16 edits in trunk/Tools

2011-01-31 Dirk Pranke <dpranke@chromium.org>

Reviewed by Mihai Parparita.

The current modifier parsing code in test_expectations is
fragile and hard-coded, so it's not easy to understand the logic
or easily add new types of modifiers (like GPU vs. CPU testing
for graphics tests, or 32-bit vs. 64-bit differences).

This is the first of two patches that will add in more generic
support and then eliminate the GPU-specific test expectations
files for Chromium.

This patch adds two standalone objects for handling modifiers. The
rules for interpreting modifiers, precedence, and conflicts are
given in the docstring to the ModifierMatcher class, which
returns ModifierMatchResult objects.

This patch also adds routines to the Port interface and a
default set of values in the base object, in order to obtain the
values needed on a given test run. These values are then passed
to the expectation parser. This also allows us to clean up the
logic used to lint all of the different configurations in a
single test_expectations.txt file.

The next patch will merge in the separate GPU expectations file.

https://bugs.webkit.org/show_bug.cgi?id=51222

  • Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/base_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/port_testcase.py:
  • Scripts/webkitpy/layout_tests/port/test.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Tools/Scripts/webkitpy/style/checkers/test_expectations.py:
  • Tools/Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
14:56 Changeset [77162] by crogers@google.com
  • 2 edits in trunk/Source/WebKit/chromium

2011-01-31 Chris Rogers <crogers@google.com>

Reviewed by Jeremy Orlow.

Improve audio latency on Mac OS X for chromium port
https://bugs.webkit.org/show_bug.cgi?id=53452

  • src/AudioDestinationChromium.cpp:
14:32 Changeset [77161] by dbates@webkit.org
  • 4 edits
    1 add in trunk

2011-01-31 Scott Cameron <sccameron@rim.com>

Reviewed by Daniel Bates.

update run-webkit-httpd to be able to launch Apache2.2 in a MSYS environment
https://bugs.webkit.org/show_bug.cgi?id=50036

This will add an Apache2.2 configuration file and modifies scripts to allow
running an httpd server in an MSYS environment.

The default Apache2.2 installation path has been preserved and PHP5 modules disabled
in order to allow for simple installation/execution. Simply install the latest
Apache2.2 version with OpenSSL from http://httpd.apache.org/download.cgi#apache22 to
be able to execute run-webkit-httpd.


  • http/conf/apache2-msys-httpd.conf: Added.

2011-01-31 Scott Cameron <sccameron@rim.com>

Reviewed by Daniel Bates.

update run-webkit-httpd to be able to launch Apache2.2 in a MSYS environment
https://bugs.webkit.org/show_bug.cgi?id=50036

This will add an Apache2.2 configuration file and modifies scripts to allow
running an httpd server in an MSYS environment.

The default Apache2.2 installation path has been preserved and PHP5 modules disabled
in order to allow for simple installation/execution. Simply install the latest
Apache2.2 version with OpenSSL from http://httpd.apache.org/download.cgi#apache22 to
be able to execute run-webkit-httpd.


  • Scripts/run-webkit-httpd:
  • Scripts/webkitperl/httpd.pm:
14:27 Changeset [77160] by rniwa@webkit.org
  • 2 edits
    4 adds in trunk/LayoutTests

2011-01-31 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed Chromium Mac rebaselines for r77153; also rebaseline Kusa-Makura-background-canvas.html

  • platform/chromium-mac/fast/blockflow/Kusa-Makura-background-canvas-expected.checksum: Added.
  • platform/chromium-mac/fast/blockflow/Kusa-Makura-background-canvas-expected.png: Added.
  • platform/chromium-mac/fast/text/international/text-combine-image-test-expected.checksum: Added.
  • platform/chromium-mac/fast/text/international/text-combine-image-test-expected.png: Added.
  • platform/chromium/test_expectations.txt:
14:24 Changeset [77159] by msaboff@apple.com
  • 5 edits in trunk/Source

Rolling back in the changes for https://bugs.webkit.org/show_bug.cgi?id=53271.

13:39 Changeset [77158] by hyatt@apple.com
  • 1 edit in trunk/Source/WebCore/rendering/RenderCombineText.cpp

Fix 32-bit build bustage.

13:29 Changeset [77157] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-01-31 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed Chromium test expectation update.

  • platform/chromium/test_expectations.txt:
13:05 Changeset [77156] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebCore

2011-01-31 Andreas Kling <kling@webkit.org>

Unbreak Qt build after r77151.

  • bridge/qt/qt_instance.cpp: (JSC::Bindings::QtInstance::removeCachedMethod): (JSC::Bindings::QtInstance::markAggregate):
12:51 Changeset [77155] by alex@webkit.org
  • 1 edit
    6 adds in trunk/LayoutTests

2011-01-31 Alejandro G. Castro <alex@igalia.com>

Unreviewed added new expected results for GTK+.

  • platform/gtk/fast/box-shadow/box-shadow-radius-expected.txt: Added.
  • platform/gtk/fast/box-shadow/box-shadow-transformed-expected.txt: Added.
  • platform/gtk/fast/box-shadow/inset-box-shadow-radius-expected.txt: Added.
  • platform/gtk/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.txt: Added.
  • platform/gtk/fast/repaint/gradients-em-stops-repaint-expected.txt: Added.
  • platform/gtk/fast/repaint/select-option-background-color-expected.txt: Added.
12:48 Changeset [77154] by chang.shu@nokia.com
  • 2 edits
    1 add
    13 deletes in trunk/LayoutTests

2011-01-31 Chang Shu <chang.shu@nokia.com>

Reviewed by Ryosuke Niwa.

Convert the test case to dumpAsText test so the expected result is cross-platform.
https://bugs.webkit.org/show_bug.cgi?id=53437

  • editing/deleting/5168598-expected.txt: Added.
  • editing/deleting/5168598.html:
  • platform/chromium-linux/editing/deleting/5168598-expected.checksum: Removed.
  • platform/chromium-linux/editing/deleting/5168598-expected.png: Removed.
  • platform/chromium-win/editing/deleting/5168598-expected.checksum: Removed.
  • platform/chromium-win/editing/deleting/5168598-expected.png: Removed.
  • platform/chromium-win/editing/deleting/5168598-expected.txt: Removed.
  • platform/mac-leopard/editing/deleting/5168598-expected.checksum: Removed.
  • platform/mac-leopard/editing/deleting/5168598-expected.png: Removed.
  • platform/mac/editing/deleting/5168598-expected.checksum: Removed.
  • platform/mac/editing/deleting/5168598-expected.png: Removed.
  • platform/mac/editing/deleting/5168598-expected.txt: Removed.
  • platform/qt/editing/deleting/5168598-expected.checksum: Removed.
  • platform/qt/editing/deleting/5168598-expected.png: Removed.
  • platform/qt/editing/deleting/5168598-expected.txt: Removed.
12:39 Changeset [77153] by hyatt@apple.com
  • 47 edits
    7 adds in trunk

Implement text-combine rendering code
https://bugs.webkit.org/show_bug.cgi?id=50621

Patch by takano takumi <takano@apple.com> on 2011-01-31
Reviewed by Dave Hyatt.

Source/WebCore:

Test: fast/text/international/text-combine-image-test.html

  • Android.mk: Added RenderCombineText.cpp/h
  • CMakeLists.txt: Added RenderCombineText.cpp/h
  • GNUmakefile.am: Added RenderCombineText.cpp/h
  • WebCore.exp.in:
  • WebCore.gypi: Added RenderCombineText.cpp/h
  • WebCore.pro: Added RenderCombineText.cpp/h
  • WebCore.vcproj/WebCore.vcproj: Added RenderCombineText.cpp/h
  • WebCore.xcodeproj/project.pbxproj: Added RenderCombineText.cpp/h
  • css/CSSFontFaceSource.cpp:

(WebCore::CSSFontFaceSource::getFontData):

  • Added fontDescription.widthVariant to SimpleFontData creation.
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

  • Changed to set "Unique" flag to RenderStyle in case of TextCombine.
  • dom/Text.cpp:

(WebCore::Text::createRenderer):

  • Changed to create RenderCombineText in case of TextCombine.
  • loader/cache/CachedFont.cpp:

(WebCore::CachedFont::platformDataFromCustomData):

  • Added FontWidthVariant as an argument for FontPlatformData creation.
  • loader/cache/CachedFont.h:
  • Ditto.
  • platform/graphics/Font.h:

(WebCore::Font::widthVariant):

  • The accessor to FontWidthVariant member variable.
  • platform/graphics/FontCache.cpp:
  • Made cache to incorporate FontWidthVariant value.

(WebCore::FontPlatformDataCacheKey::FontPlatformDataCacheKey):
(WebCore::FontPlatformDataCacheKey::operator==):
(WebCore::computeHash):
(WebCore::FontCache::getCachedFontPlatformData):

  • platform/graphics/FontDescription.h:
  • Add a member variable that holds a width variant - none, half-width, third-width, and quarter-width.

(WebCore::FontDescription::FontDescription):
(WebCore::FontDescription::widthVariant):
(WebCore::FontDescription::setWidthVariant):
(WebCore::FontDescription::operator==):

  • platform/graphics/FontWidthVariant.h: Added.
  • platform/graphics/cairo/FontCustomPlatformData.h:
  • Changed to carry FontWidthVariant value.
  • platform/graphics/cocoa/FontPlatformData.h:
  • Changed to carry FontWidthVariant value.

(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::widthVariant):
(WebCore::FontPlatformData::hash):
(WebCore::FontPlatformData::operator==):

  • platform/graphics/cocoa/FontPlatformDataCocoa.mm:

(WebCore::FontPlatformData::FontPlatformData):

  • Changed to carry FontWidthVariant value.

(WebCore::FontPlatformData::operator=):

  • Ditto.

(WebCore::mapFontWidthVariantToCTFeatureSelector):

  • A function to map a FontWidthVariant value to a CoreText's text spacing feature selector.

(WebCore::FontPlatformData::ctFont):

  • Changed to create CTFont with text spacing variant based on FontWidthVariant.
  • platform/graphics/freetype/FontCustomPlatformDataFreeType.cpp:

(WebCore::FontCustomPlatformData::fontPlatformData):

  • Changed to carry FontWidthVariant value.
  • platform/graphics/haiku/FontCustomPlatformData.cpp:

(WebCore::FontCustomPlatformData::fontPlatformData):

  • Changed to carry FontWidthVariant value.
  • platform/graphics/haiku/FontCustomPlatformData.h:
  • platform/graphics/mac/FontCacheMac.mm:

(WebCore::FontCache::createFontPlatformData):

  • Changed to carry FontWidthVariant value.
  • platform/graphics/mac/FontCustomPlatformData.cpp:

(WebCore::FontCustomPlatformData::fontPlatformData):

  • Changed to carry FontWidthVariant value.
  • platform/graphics/mac/FontCustomPlatformData.h:
  • Ditto.
  • platform/graphics/mac/GlyphPageTreeNodeMac.cpp:

(WebCore::shouldUseCoreText):

  • Changed to skip CT path when width variant is specified.
  • platform/graphics/pango/FontCustomPlatformDataPango.cpp:

(WebCore::FontCustomPlatformData::fontPlatformData):

  • Ditto.
  • platform/graphics/qt/FontCustomPlatformData.h:
  • Ditto.
  • platform/graphics/qt/FontCustomPlatformDataQt.cpp:

(WebCore::FontCustomPlatformData::fontPlatformData):

  • Ditto.
  • platform/graphics/skia/FontCustomPlatformData.cpp:

(WebCore::FontCustomPlatformData::fontPlatformData):

  • Ditto.
  • platform/graphics/skia/FontCustomPlatformData.h:
  • Ditto.
  • platform/graphics/win/FontCustomPlatformData.cpp:

(WebCore::FontCustomPlatformData::fontPlatformData):

  • Ditto.
  • platform/graphics/win/FontCustomPlatformData.h:
  • Ditto.
  • platform/graphics/win/FontCustomPlatformDataCairo.cpp:
  • Ditto.

(WebCore::FontCustomPlatformData::fontPlatformData):

  • Ditto.
  • platform/graphics/win/FontCustomPlatformDataCairo.h:
  • Ditto.
  • platform/graphics/wince/FontCustomPlatformData.cpp:

(WebCore::FontCustomPlatformData::fontPlatformData):

  • Ditto.
  • platform/graphics/wince/FontCustomPlatformData.h:
  • Ditto.
  • platform/graphics/wx/FontCustomPlatformData.cpp:

(WebCore::FontCustomPlatformData::fontPlatformData):

  • Ditto.
  • platform/graphics/wx/FontCustomPlatformData.h:
  • Ditto.
  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paint):

  • In case of RenderCombineText, we don't rotate text even in vertical writing. Also, we render original text

instead of text returned from text().

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::computeInlinePreferredLogicalWidths):

  • Made to call RenderCombinedText's prepareTextCombine() here.
  • rendering/RenderBlockLineLayout.cpp:

(WebCore::textWidth):

  • Made to always use the render object's width() in case of TextCombine.

(WebCore::RenderBlock::findNextLineBreak):

  • Made to call RenderCombinedText's prepareTextCombine() here.
  • rendering/RenderCombineText.cpp: Added. A subclass of RenderText.

(WebCore::RenderCombineText::RenderCombineText):
(WebCore::RenderCombineText::styleDidChange):

  • Clear the flag that indicated the font has been prepared for combining. The font will be reinitialized in

the next call of RenderBlock::findNextLineBreak().
(WebCore::RenderCombineText::setTextInternal):

  • Ditto.

(WebCore::RenderCombineText::width):

  • Returns 1-em width in case of font combine.

(WebCore::RenderCombineText::adjustTextOrigin):

  • Adjust drawing origin point in case of font combine.

(WebCore::RenderCombineText::charactersToRender):

  • Return original text instead of current text in case of font combine.

(WebCore::RenderCombineText::combineText):

  • This function tries to pack passed text with; 1) the current font as is, 2) the font created

from the descriptor with half-width variant specified, 3) the font with third-width variant, 4) the font
with quarter-width variant.

  • If a suitable font successfully found, replace the current font with the new font. If no appropriate font found,

we give up text-combine as the CSS spec describes.

  • If a new font found, we replace the text with 0xFFFC. This is needed for a combined text block to be able to

behave like a single character against text decorations.

  • rendering/RenderCombineText.h: Added.

(WebCore::RenderCombineText::isCombined):
(WebCore::RenderCombineText::combinedTextWidth):

  • Returns 1-em width in case of font combine.

(WebCore::RenderCombineText::renderName):
(WebCore::toRenderCombineText):

  • rendering/RenderText.cpp:

(WebCore::RenderText::widthFromCache):

  • Made to call RenderCombineText's combinedTextWidth when the text is combined.
  • rendering/RenderingAllInOne.cpp: Added RenderCombineText.cpp
  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::hasTextCombine):

  • Added for a quick test of TextCombine.

LayoutTests:

  • fast/text/international/text-combine-image-test.html: Added.
  • platform/mac/fast/text/international/text-combine-image-test-expected.checksum: Added.
  • platform/mac/fast/text/international/text-combine-image-test-expected.png: Added.
  • platform/mac/fast/text/international/text-combine-image-test-expected.txt: Added.
12:15 Changeset [77152] by jberlin@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

[Windows 7 Release Tests] fast/forms/select-writing-direction-natural.html failing since r77046
https://bugs.webkit.org/show_bug.cgi?id=53443

Checking in failing expected results for Windows to get the bots green. Ureviewed.

  • platform/win/fast/forms/select-writing-direction-natural-expected.txt: Added.
12:07 Changeset [77151] by oliver@apple.com
  • 126 edits
    2 adds in trunk/Source

2011-01-31 Oliver Hunt <oliver@apple.com>

Convert markstack to a slot visitor API
https://bugs.webkit.org/show_bug.cgi?id=53219

rolling r77098, r77099, r77100, r77109, and
r77111 back in, along with a few more Qt fix attempts.

12:04 Changeset [77150] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-01-31 Ryosuke Niwa <rniwa@webkit.org>

Another unreviewed Chromium test expectation update.

  • platform/chromium/test_expectations.txt:
11:57 Changeset [77149] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-01-31 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed Chromium test expectation update.

  • platform/chromium/test_expectations.txt:
11:37 Changeset [77148] by kov@webkit.org
  • 5 edits in trunk/Source

2011-01-31 Dan Winship <danw@gnome.org>

Reviewed by Gustavo Noronha Silva.

wss (websockets ssl) support for gtk via new gio TLS support
https://bugs.webkit.org/show_bug.cgi?id=50344

Add a GPollableOutputStream typedef for TLS WebSockets support

  • wtf/gobject/GTypedefs.h:

2011-01-31 Dan Winship <danw@gnome.org>

Reviewed by Gustavo Noronha Silva.

wss (websockets ssl) support for gtk via new gio TLS support
https://bugs.webkit.org/show_bug.cgi?id=50344

Update to use GPollableOutputStream and GTlsConnection to
implement wss URLs

  • platform/network/soup/SocketStreamHandle.h:
  • platform/network/soup/SocketStreamHandleSoup.cpp: (WebCore::SocketStreamHandle::SocketStreamHandle): (WebCore::SocketStreamHandle::connected): (WebCore::SocketStreamHandle::platformSend): (WebCore::SocketStreamHandle::beginWaitingForSocketWritability): (WebCore::writeReadyCallback):
11:25 Changeset [77147] by jberlin@webkit.org
  • 3 edits
    2 adds in trunk/Source/WebKit2

WebKit2: the cookies used by the WebKit2 Web Process should not go in a top-level
directory.
https://bugs.webkit.org/show_bug.cgi?id=53278

Reviewed by Steve Falkenburg.

Use the name WebKit2WebProcess since the default location for the cookies is determined
based on the process name (which is WebKit2WebProcess.exe on Windows).

  • win/WebKit2.make:

Copy the WebKit2WebProcess.resources directory into the AppleInternal bin.

  • win/WebKit2WebProcess.resources: Added.
  • win/WebKit2WebProcess.resources/Info.plist: Added.

Copied from the WebKit version of Info.plist.

  • win/WebKit2WebProcessPostBuild.cmd:

Copy the WebKit2WebProcess.resources directory into the WebKitOutPutDir's bin.

11:08 Changeset [77146] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

2011-01-31 Tony Chang <tony@chromium.org>

Unreviewed, update chromium mac layout test results after r77138.
fast/blockflow/Kusa-Makura-background-canvas.html and fast/multicol/vertical-rl/float-paginate-complex.html
match upstream text results now.

  • platform/chromium/test_expectations.txt:
11:02 Changeset [77145] by barraclough@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

https://bugs.webkit.org/show_bug.cgi?id=53352
Heavy external fragmentation in FixedVMPoolAllocator can lead to a CRASH().

Reviewed by Geoff Garen.

The FixedVMPoolAllocator currently uses a best fix policy -
switch to first fit, this is less prone to external fragmentation.

  • jit/ExecutableAllocatorFixedVMPool.cpp:

(JSC::AllocationTableSizeClass::AllocationTableSizeClass):
(JSC::AllocationTableSizeClass::blockSize):
(JSC::AllocationTableSizeClass::blockCount):
(JSC::AllocationTableSizeClass::blockAlignment):
(JSC::AllocationTableSizeClass::size):
(JSC::AllocationTableLeaf::AllocationTableLeaf):
(JSC::AllocationTableLeaf::~AllocationTableLeaf):
(JSC::AllocationTableLeaf::allocate):
(JSC::AllocationTableLeaf::free):
(JSC::AllocationTableLeaf::isEmpty):
(JSC::AllocationTableLeaf::isFull):
(JSC::AllocationTableLeaf::size):
(JSC::AllocationTableLeaf::classForSize):
(JSC::AllocationTableLeaf::dump):
(JSC::LazyAllocationTable::LazyAllocationTable):
(JSC::LazyAllocationTable::~LazyAllocationTable):
(JSC::LazyAllocationTable::allocate):
(JSC::LazyAllocationTable::free):
(JSC::LazyAllocationTable::isEmpty):
(JSC::LazyAllocationTable::isFull):
(JSC::LazyAllocationTable::size):
(JSC::LazyAllocationTable::dump):
(JSC::LazyAllocationTable::classForSize):
(JSC::AllocationTableDirectory::AllocationTableDirectory):
(JSC::AllocationTableDirectory::~AllocationTableDirectory):
(JSC::AllocationTableDirectory::allocate):
(JSC::AllocationTableDirectory::free):
(JSC::AllocationTableDirectory::isEmpty):
(JSC::AllocationTableDirectory::isFull):
(JSC::AllocationTableDirectory::size):
(JSC::AllocationTableDirectory::classForSize):
(JSC::AllocationTableDirectory::dump):
(JSC::FixedVMPoolAllocator::FixedVMPoolAllocator):
(JSC::FixedVMPoolAllocator::alloc):
(JSC::FixedVMPoolAllocator::free):
(JSC::FixedVMPoolAllocator::allocated):
(JSC::FixedVMPoolAllocator::isValid):
(JSC::FixedVMPoolAllocator::classForSize):
(JSC::FixedVMPoolAllocator::offsetToPointer):
(JSC::FixedVMPoolAllocator::pointerToOffset):
(JSC::ExecutableAllocator::committedByteCount):
(JSC::ExecutableAllocator::isValid):
(JSC::ExecutableAllocator::underMemoryPressure):
(JSC::ExecutablePool::systemAlloc):
(JSC::ExecutablePool::systemRelease):

  • wtf/PageReservation.h:

(WTF::PageReservation::PageReservation):
(WTF::PageReservation::commit):
(WTF::PageReservation::decommit):
(WTF::PageReservation::committed):

11:00 Changeset [77144] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

2011-01-31 Abhishek Arya <inferno@chromium.org>

Reviewed by Dimitri Glazkov.

Check the textarea node still exists in document before casting
it to HTMLTextAreaElement.
https://bugs.webkit.org/show_bug.cgi?id=53429

Test: fast/forms/textarea-node-removed-from-document-crash.html

  • rendering/RenderTextControlMultiLine.cpp: (WebCore::RenderTextControlMultiLine::~RenderTextControlMultiLine):

2011-01-31 Abhishek Arya <inferno@chromium.org>

Reviewed by Dimitri Glazkov.

Tests that we do not crash when destructing textarea renderer when its
node is already removed from document.
https://bugs.webkit.org/show_bug.cgi?id=53429

  • fast/forms/textarea-node-removed-from-document-crash-expected.txt: Added.
  • fast/forms/textarea-node-removed-from-document-crash.html: Added.
10:56 Changeset [77143] by mitz@apple.com
  • 1 edit
    6 deletes in trunk/LayoutTests

Remove expected results in mac-wk2 and win that are equal to the mac results after r77138.

  • platform/mac-wk2/fast/blockflow/Kusa-Makura-background-canvas-expected.txt: Removed.
  • platform/mac-wk2/fast/multicol/vertical-rl/column-break-with-balancing-expected.txt: Removed.
  • platform/mac-wk2/fast/multicol/vertical-rl/float-paginate-complex-expected.txt: Removed.
  • platform/win/fast/block/basic/truncation-rtl-expected.txt: Removed.
  • platform/win/fast/multicol/vertical-rl/column-break-with-balancing-expected.txt: Removed.
  • platform/win/fast/multicol/vertical-rl/float-paginate-complex-expected.txt: Removed.
10:28 Changeset [77142] by inferno@chromium.org
  • 1 edit
    3 adds in trunk/LayoutTests

2011-01-31 Cris Neckar <cdn@chromium.org>

Reviewed by Eric Seidel.

Tests for crash when cloning elements that reference counter nodes.
https://bugs.webkit.org/show_bug.cgi?id=53344

  • http/tests/css/counter-crash-expected.txt: Added.
  • http/tests/css/counter-crash.html: Added.
  • http/tests/css/resources/counter-crash-frame-src.html: Added.
10:23 Changeset [77141] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

2011-01-27 Abhishek Arya <inferno@chromium.org>

Reviewed by Dave Hyatt.

Tests that we do not crash when adding a child in a table
where the before child is not a table section.
https://bugs.webkit.org/show_bug.cgi?id=53276

  • fast/table/before-child-non-table-section-add-table-crash-expected.txt: Added.
  • fast/table/before-child-non-table-section-add-table-crash.html: Added.

2011-01-27 Abhishek Arya <inferno@chromium.org>

Reviewed by Dave Hyatt.

If beforeChild is wrapped in an anonymous table section, we need to
go the parent to find it and use it before adding childs to table.
https://bugs.webkit.org/show_bug.cgi?id=53276

We need to make sure that beforeChild's parent is "this" before calling
RenderBox::addChild. The previous condition in while is too restrictive
and fails to calculate the right beforeChild value when its display
style is table caption.
Test: fast/table/before-child-non-table-section-add-table-crash.html

  • rendering/RenderTable.cpp: (WebCore::RenderTable::addChild):
10:11 Changeset [77140] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebCore

2011-01-31 Shane Stephens <shanestephens@google.com>

Reviewed by Simon Fraser.

AffineTransform::translateRight incorrectly computes a translateLeft.
https://bugs.webkit.org/show_bug.cgi?id=52551

Removed translateRight and converted all uses to perform standard
matrix multiplication.

No new tests because patch doesn't modify functionality.

  • platform/graphics/transforms/AffineTransform.cpp:
  • platform/graphics/transforms/AffineTransform.h: (WebCore::AffineTransform::translation):
  • rendering/svg/RenderSVGResourceMarker.cpp: (WebCore::RenderSVGResourceMarker::localToParentTransform):
  • rendering/svg/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::localToRepaintContainerTransform): (WebCore::RenderSVGRoot::localToParentTransform):
  • rendering/svg/RenderSVGViewportContainer.cpp: (WebCore::RenderSVGViewportContainer::localToParentTransform):
  • rendering/svg/SVGTextLayoutEngine.cpp: (WebCore::SVGTextLayoutEngine::finalizeTransformMatrices):
10:08 Changeset [77139] by andersca@apple.com
  • 7 edits
    1 add in trunk/Source/WebKit2

2011-01-31 Anders Carlsson <andersca@apple.com>

Reviewed by Adam Roben.

Make LayerTreeHost an abstract base class and make LayerTreeHostMac inherit from it
https://bugs.webkit.org/show_bug.cgi?id=53432

  • WebKit2.xcodeproj/project.pbxproj: Add LayerTreeHostMac.h.
  • WebProcess/WebPage/DrawingAreaImpl.cpp:
  • WebProcess/WebPage/DrawingAreaImpl.h: Make m_layerTreeHost an OwnPtr and initialize/destroy it appropriately.
  • WebProcess/WebPage/LayerTreeHost.cpp: (WebKit::LayerTreeHost::create): On Mac, create a LayerTreeHostMac instance.

(WebKit::LayerTreeHost::~LayerTreeHost):
No need to call platformInvalidate anymore.

  • WebProcess/WebPage/LayerTreeHost.h:
  • WebProcess/WebPage/mac/LayerTreeHostMac.h: Added.
  • WebProcess/WebPage/mac/LayerTreeHostMac.mm: (WebKit::LayerTreeHostMac::~LayerTreeHostMac): Invalidate the run loop observer here instead of in platformInvalidate.

(WebKit::LayerTreeHostMac::scheduleLayerFlush):
(WebKit::LayerTreeHostMac::flushPendingLayerChangesRunLoopObserverCallback):
These are now members of LayerTreeHostMac.

10:06 Changeset [77138] by tony@chromium.org
  • 7 edits in trunk

2011-01-31 Tony Chang <tony@chromium.org>

Reviewed by Eric Seidel.

mac DRT should report RTL scroll offset relative to top right corner
https://bugs.webkit.org/show_bug.cgi?id=53324

Remove scroll offsets since these are at the origin.

  • platform/mac/fast/block/basic/truncation-rtl-expected.txt:
  • platform/mac/fast/blockflow/Kusa-Makura-background-canvas-expected.txt:
  • platform/mac/fast/multicol/vertical-rl/column-break-with-balancing-expected.txt:
  • platform/mac/fast/multicol/vertical-rl/float-paginate-complex-expected.txt:

2011-01-31 Tony Chang <tony@chromium.org>

Reviewed by Eric Seidel.

mac DRT should report RTL scroll offset relative to top right corner
https://bugs.webkit.org/show_bug.cgi?id=53324

  • DumpRenderTree/mac/DumpRenderTree.mm: (dumpFrameScrollPosition):
09:57 Changeset [77137] by mario@webkit.org
  • 4 edits in trunk/Source

2011-01-31 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Martin Robinson.

[Gtk] atk_text_set_caret_offset returns True even when it is unsuccessful
https://bugs.webkit.org/show_bug.cgi?id=53389

Return FALSE when not able to set the caret at the specified offset.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_text_set_caret_offset): Return FALSE when the range created is NULL and adjust offset to account for list markers.

2011-01-31 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Martin Robinson.

[Gtk] atk_text_set_caret_offset returns True even when it is unsuccessful
https://bugs.webkit.org/show_bug.cgi?id=53389

New unit test to check the fix for this bug.

  • tests/testatk.c: (testWebkitAtkCaretOffsets): New. (main): Add new test.
09:37 Changeset [77136] by yurys@chromium.org
  • 2 edits in trunk/LayoutTests

2011-01-31 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Mark some tests as having wrong image results on Mac.

  • platform/chromium/test_expectations.txt:
09:18 Changeset [77135] by ager@chromium.org
  • 11 edits in trunk/LayoutTests

2011-01-31 Mads Ager <ager@chromium.org>

Reviewed by Pavel Feldman.

[V8] Update V8 specific layout test expectations
https://bugs.webkit.org/show_bug.cgi?id=53423

Error formatting has changed in V8. Updating chromium specific
layout test expectations accordingly.

  • platform/chromium-mac/fast/js/array-every-expected.txt:
  • platform/chromium-mac/fast/js/instance-of-immediates-expected.txt:
  • platform/chromium-mac/fast/js/property-getters-and-setters-expected.txt:
  • platform/chromium-mac/storage/transaction-error-callback-expected.txt:
  • platform/chromium-mac/svg/dom/svgpath-out-of-bounds-getPathSeg-expected.txt:
  • platform/chromium-win/fast/js/array-every-expected.txt:
  • platform/chromium-win/fast/js/instance-of-immediates-expected.txt:
  • platform/chromium-win/fast/js/property-getters-and-setters-expected.txt:
  • platform/chromium-win/storage/transaction-error-callback-expected.txt:
  • platform/chromium-win/svg/dom/svgpath-out-of-bounds-getPathSeg-expected.txt:
09:14 Changeset [77134] by alex@webkit.org
  • 2 edits in trunk/LayoutTests

2011-01-31 Alejandro G. Castro <alex@igalia.com>

Unreviewed skipped favicon-as-image.html test, it is flaky and it
was unskipped after r76555.

  • platform/gtk/Skipped:
09:05 Changeset [77133] by mnaganov@chromium.org
  • 1 edit in branches/chromium/648/Source/WebCore/inspector/front-end/NetworkPanel.js

Merge 77128 - 2011-01-28 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: copy HAR to clipboard instead of saving blob on export.
https://bugs.webkit.org/show_bug.cgi?id=53328

  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype._exportAll): (WebInspector.NetworkPanel.prototype._exportResource):

TBR=pfeldman@chromium.org
Review URL: http://codereview.chromium.org/6312032

08:35 Changeset [77132] by simon.fraser@apple.com
  • 3 edits in trunk/LayoutTests

2011-01-31 Simon Fraser <simon.fraser@apple.com>

Update a pixel resuls after r77101.

  • platform/mac/fast/css/color-correction-on-box-shadow-expected.checksum:
  • platform/mac/fast/css/color-correction-on-box-shadow-expected.png:
08:03 Changeset [77131] by yurys@chromium.org
  • 3 edits
    2 adds in trunk/LayoutTests

2011-01-31 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Update Chromium test expectations.

  • platform/chromium-mac/fast/css/color-correction-on-box-shadow-expected.checksum: Added.
  • platform/chromium-mac/fast/css/color-correction-on-box-shadow-expected.png: Added.
  • platform/chromium-mac/fast/transforms/shadows-expected.checksum:
  • platform/chromium-mac/fast/transforms/shadows-expected.png:
07:39 Changeset [77130] by zoltan@webkit.org
  • 3 edits in trunk/Tools

[Qt] Add Take Screen Shot action to MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=53422

Reviewed by Andreas Kling.

Add Take Screen Shot action to MiniBrowser's view menu.

  • MiniBrowser/qt/BrowserWindow.cpp:

(BrowserWindow::BrowserWindow):
(BrowserWindow::screenshot):

  • MiniBrowser/qt/BrowserWindow.h:
07:29 Changeset [77129] by kbr@google.com
  • 3 edits
    3 deletes in trunk/LayoutTests

2011-01-31 Kenneth Russell <kbr@google.com>

Unreviewed, test and expectations update. Stop reporting the precise
pixel value for tests that are supposed to be within a certain range.
Remove now-unneeded Chromium expectations.

  • fast/canvas/webgl/gl-teximage-expected.txt:
  • fast/canvas/webgl/gl-teximage.html:
  • platform/chromium-linux/fast/canvas/webgl/gl-teximage-expected.txt: Removed.
  • platform/chromium-mac/fast/canvas/webgl/gl-teximage-expected.txt: Removed.
  • platform/chromium-win/fast/canvas/webgl/gl-teximage-expected.txt: Removed.
07:18 Changeset [77128] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-01-28 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: copy HAR to clipboard instead of saving blob on export.
https://bugs.webkit.org/show_bug.cgi?id=53328

  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype._exportAll): (WebInspector.NetworkPanel.prototype._exportResource):
06:43 Changeset [77127] by pfeldman@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-01-30 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: speed up network panel rendering.
https://bugs.webkit.org/show_bug.cgi?id=53397

  • inspector/front-end/DataGrid.js: (WebInspector.DataGrid.prototype.get scrollContainer):
  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype.elementsToRestoreScrollPositionsFor): (WebInspector.NetworkPanel.prototype._positionSummaryBar): (WebInspector.NetworkPanel.prototype._createTable): (WebInspector.NetworkPanel.prototype._exportResource): (WebInspector.NetworkPanel.prototype._onScroll):
  • inspector/front-end/networkPanel.css: (.network-sidebar .data-grid.small tr.offscreen): (.network-sidebar .data-grid tr.offscreen): (.network-sidebar .data-grid tr.offscreen td):
06:34 Changeset [77126] by pvarga@webkit.org
  • 4 edits
    1 delete in trunk/Source/WebCore

2011-01-31 Peter Varga <pvarga@webkit.org>

Reviewed by Andreas Kling.

Remove wrec from WebCore
https://bugs.webkit.org/show_bug.cgi?id=53298

No new tests needed.

  • Android.jscbindings.mk:
  • ForwardingHeaders/wrec/WREC.h: Removed.
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcproj/copyForwardingHeaders.cmd:
06:26 Changeset [77125] by commit-queue@webkit.org
  • 5 edits in trunk/Source

2011-01-31 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r76969.
http://trac.webkit.org/changeset/76969
https://bugs.webkit.org/show_bug.cgi?id=53418

"It is causing crashes in GTK+ and Leopard bots" (Requested by
alexg on #webkit).

  • runtime/WeakGCMap.h:

2011-01-31 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r76969.
http://trac.webkit.org/changeset/76969
https://bugs.webkit.org/show_bug.cgi?id=53418

"It is causing crashes in GTK+ and Leopard bots" (Requested by
alexg on #webkit).

  • bridge/runtime_root.cpp: (JSC::Bindings::RootObject::invalidate): (JSC::Bindings::RootObject::addRuntimeObject): (JSC::Bindings::RootObject::removeRuntimeObject):
  • bridge/runtime_root.h:
06:23 Changeset [77124] by yurys@chromium.org
  • 3 edits
    17 adds
    4 deletes in trunk/LayoutTests

2011-01-31 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Update Chromium test expectations.

  • platform/chromium-mac/fast/blockflow/box-shadow-horizontal-bt-expected.checksum: Added.
  • platform/chromium-mac/fast/blockflow/box-shadow-horizontal-bt-expected.png: Added.
  • platform/chromium-mac/fast/blockflow/box-shadow-vertical-lr-expected.checksum: Added.
  • platform/chromium-mac/fast/blockflow/box-shadow-vertical-lr-expected.png: Added.
  • platform/chromium-mac/fast/blockflow/box-shadow-vertical-rl-expected.checksum: Added.
  • platform/chromium-mac/fast/blockflow/box-shadow-vertical-rl-expected.png: Added.
  • platform/chromium-mac/fast/borders/border-radius-split-inline-expected.checksum: Added.
  • platform/chromium-mac/fast/borders/border-radius-split-inline-expected.png: Added.
  • platform/chromium-mac/fast/box-shadow/box-shadow-transformed-expected.checksum: Added.
  • platform/chromium-mac/fast/box-shadow/box-shadow-transformed-expected.png: Added.
  • platform/chromium-mac/fast/repaint/box-shadow-h-expected.checksum:
  • platform/chromium-mac/fast/repaint/box-shadow-h-expected.png:
  • platform/chromium-mac/fast/repaint/box-shadow-v-expected.checksum: Added.
  • platform/chromium-mac/fast/repaint/box-shadow-v-expected.png: Added.
  • platform/chromium-mac/fast/repaint/gradients-em-stops-repaint-expected.checksum: Added.
  • platform/chromium-mac/fast/repaint/gradients-em-stops-repaint-expected.png: Added.
  • platform/chromium-mac/fast/repaint/shadow-multiple-strict-horizontal-expected.checksum: Removed.
  • platform/chromium-mac/fast/repaint/shadow-multiple-strict-horizontal-expected.png: Removed.
  • platform/chromium-mac/fast/repaint/shadow-multiple-strict-vertical-expected.checksum: Removed.
  • platform/chromium-mac/fast/repaint/shadow-multiple-strict-vertical-expected.png: Removed.
  • platform/chromium-mac/fast/transforms/shadows-expected.checksum: Added.
  • platform/chromium-mac/fast/transforms/shadows-expected.png: Added.
05:59 Changeset [77123] by kov@webkit.org
  • 7 edits in trunk

2011-01-31 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

[GTK] REGRESSION: http/tests/media/video-{cookie,referer}.html failing
https://bugs.webkit.org/show_bug.cgi?id=53379

Remove left over mentions of HAVE_SOUP_2_29_90, and apply the
dependency on newer soup to efl as well.

  • Source/cmake/OptionsEfl.cmake:

2011-01-31 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

[GTK] REGRESSION: http/tests/media/video-{cookie,referer}.html failing
https://bugs.webkit.org/show_bug.cgi?id=53379

Unskip tests that pass again.

  • platform/gtk/Skipped:

2011-01-31 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

[GTK] REGRESSION: http/tests/media/video-{cookie,referer}.html failing
https://bugs.webkit.org/show_bug.cgi?id=53379

Remove left over #ifdef's. I thought all of the conditional code
had been freed from the condition, but I forgot to check DRT.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setAlwaysAcceptCookies):
05:36 Changeset [77122] by mnaganov@chromium.org
  • 3 edits
    5 copies in branches/chromium/648

Merge 76429 - 2011-01-21 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Adam Barth.

Regression: new window.onerror() implementation leaks cross-origin Javascript errors
https://bugs.webkit.org/show_bug.cgi?id=52903

In case of an exception in a script from different domain only generic message
will be passed to window.onerror hander.

Tests: http/tests/security/cross-origin-script-window-onerror-redirected.html

http/tests/security/cross-origin-script-window-onerror.html

  • bindings/js/CachedScriptSourceProvider.h: use URL from the resource response to make sure we do all cross origin checks agains real script URL, not the original URL which may have resulted in a sequence of redirects to different domains. (WebCore::CachedScriptSourceProvider::CachedScriptSourceProvider):
  • bindings/v8/ScriptSourceCode.h: same for v8. (WebCore::ScriptSourceCode::url):
  • dom/ScriptExecutionContext.cpp: (WebCore::ScriptExecutionContext::dispatchErrorEvent): in case the error occurred in a script we cannot access provide concise "Script error." message without any information about the error source. This is what Firefox does in this case.

2011-01-21 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Adam Barth.

Regression: new window.onerror() implementation leaks cross-origin Javascript errors
https://bugs.webkit.org/show_bug.cgi?id=52903

A couple of tests to check that window.onerror won't reveal any content of the resource
from a different domain if the latter is referenced via <script src=...>

  • http/tests/security/cross-origin-script-window-onerror-expected.txt: Added.
  • http/tests/security/cross-origin-script-window-onerror-redirected-expected.txt: Added.
  • http/tests/security/cross-origin-script-window-onerror-redirected.html: Added.
  • http/tests/security/cross-origin-script-window-onerror.html: Added.
  • http/tests/security/resources/cross-origin-script.txt: Added.

TBR=abarth@webkit.org
Review URL: http://codereview.chromium.org/6409009

03:56 Changeset [77121] by antti@apple.com
  • 2 edits in trunk/Source/WebCore

Not reviewed.

Spelling.

  • css/CSSSelectorList.h:

(WebCore::CSSSelectorList::next):

03:45 Changeset [77120] by yurys@chromium.org
  • 1 edit
    5 adds in trunk/LayoutTests

2011-01-31 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Update Chromium test expectations after r77108

  • platform/chromium-linux/fast/canvas/webgl/gl-teximage-expected.txt: Added.
  • platform/chromium-mac/fast/canvas/webgl/gl-teximage-expected.txt: Added.
  • platform/chromium-win/fast/canvas/webgl/gl-teximage-expected.txt: Added.
03:10 Changeset [77119] by yurys@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-01-31 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Fix Chromium compilation on Linux.

  • platform/graphics/ShadowBlur.cpp: added PLATFORM(CHROMIUM) guard
  • platform/graphics/ShadowBlur.h: added missing ColorSpace.h header include
02:55 Changeset [77118] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-01-31 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Fix Chromium compilation on Mac broken by r77101.

  • WebCore.gypi: add ShadowBlur.{h,cpp} to the gypi file.
02:51 Changeset [77117] by yurys@chromium.org
  • 1 edit
    16 adds in trunk/LayoutTests

2011-01-31 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Update Chromium test expectations after r77101

  • platform/chromium-linux/fast/box-shadow/box-shadow-transformed-expected.checksum: Added.
  • platform/chromium-linux/fast/box-shadow/box-shadow-transformed-expected.png: Added.
  • platform/chromium-linux/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.checksum: Added.
  • platform/chromium-linux/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.png: Added.
  • platform/chromium-win/fast/box-shadow/box-shadow-radius-expected.checksum: Added.
  • platform/chromium-win/fast/box-shadow/box-shadow-radius-expected.png: Added.
  • platform/chromium-win/fast/box-shadow/box-shadow-radius-expected.txt: Added.
  • platform/chromium-win/fast/box-shadow/box-shadow-transformed-expected.checksum: Added.
  • platform/chromium-win/fast/box-shadow/box-shadow-transformed-expected.png: Added.
  • platform/chromium-win/fast/box-shadow/box-shadow-transformed-expected.txt: Added.
  • platform/chromium-win/fast/box-shadow/inset-box-shadow-radius-expected.checksum: Added.
  • platform/chromium-win/fast/box-shadow/inset-box-shadow-radius-expected.png: Added.
  • platform/chromium-win/fast/box-shadow/inset-box-shadow-radius-expected.txt: Added.
  • platform/chromium-win/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.checksum: Added.
  • platform/chromium-win/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.png: Added.
  • platform/chromium-win/fast/repaint/gradients-em-stops-repaint-expected.txt: Added.
02:44 Changeset [77116] by mnaganov@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-01-31 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Yury Semikhatsky.

WebInspector: Change button title from "Clear CPU profiles" to "Clear all profiles".

https://bugs.webkit.org/show_bug.cgi?id=53309

  • English.lproj/localizedStrings.js:
  • inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel):
02:35 Changeset [77115] by carlosgc@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-01-31 Carlos Garcia Campos <cgarcia@igalia.com>

Unreviewed, fix the build with current GTK+ 3.x.

  • plugins/gtk/gtk2xtbin.c:
  • plugins/gtk/gtk2xtbin.h:

01/30/11:

23:18 Changeset [77114] by tkent@chromium.org
  • 7 edits
    2 adds in trunk

2011-01-30 Kenichi Ishibashi <bashi@google.com>

Reviewed by Kent Tamura.

Dangling form associated elements should not be registered on the document
https://bugs.webkit.org/show_bug.cgi?id=53223

Adds insertedIntoDocument() and remvoedFromDocument() to
FormAssociatedElement class to register the element on the document
if and only if it actually inserted into (removed from) the document.

Test: fast/forms/dangling-form-element-crash.html

  • html/FormAssociatedElement.cpp: (WebCore::FormAssociatedElement::insertedIntoDocument): Added. (WebCore::FormAssociatedElement::removedFromDocument): Ditto. (WebCore::FormAssociatedElement::insertedIntoTree): Don't register the element to a document. (WebCore::FormAssociatedElement::removedFromTree): Don't unregister the element from a document.
  • html/FormAssociatedElement.h:
  • html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::insertedIntoDocument): Added. (WebCore::HTMLFormControlElement::removedFromDocument): Ditto.
  • html/HTMLFormControlElement.h:
  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::insertedIntoDocument): Calls FormAssociatedElement::insertedIntoDocument(). (WebCore::HTMLObjectElement::removedFromDocument): Calls FormAssociatedElement::removedFromDocument().

2011-01-30 Kenichi Ishibashi <bashi@google.com>

Reviewed by Kent Tamura.

Dangling form associated elements should not be registered on the document
https://bugs.webkit.org/show_bug.cgi?id=53223

Adds a test that ensures dangling form associated elements are not
registered on the document.

  • fast/forms/dangling-form-element-crash-expected.txt: Added.
  • fast/forms/dangling-form-element-crash.html: Added.
22:56 Changeset [77113] by ossy@webkit.org
  • 127 edits
    2 deletes in trunk/Source

2011-01-30 Csaba Osztrogonác <ossy@webkit.org>

Unreviewed, rolling out r77098, r77099, r77100, r77109, and
r77111.
http://trac.webkit.org/changeset/77098
http://trac.webkit.org/changeset/77099
http://trac.webkit.org/changeset/77100
http://trac.webkit.org/changeset/77109
http://trac.webkit.org/changeset/77111
https://bugs.webkit.org/show_bug.cgi?id=53219

Qt build is broken

  • API/JSCallbackObject.h: (JSC::JSCallbackObjectData::setPrivateProperty): (JSC::JSCallbackObjectData::JSPrivatePropertyMap::getPrivateProperty): (JSC::JSCallbackObjectData::JSPrivatePropertyMap::setPrivateProperty): (JSC::JSCallbackObjectData::JSPrivatePropertyMap::markChildren): (JSC::JSCallbackObject::setPrivateProperty):
  • API/JSCallbackObjectFunctions.h: (JSC::::put): (JSC::::staticFunctionGetter):
  • API/JSObjectRef.cpp: (JSObjectMakeConstructor): (JSObjectSetPrivateProperty):
  • API/JSWeakObjectMapRefInternal.h:
  • JavaScriptCore.exp:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::markAggregate):
  • bytecode/CodeBlock.h: (JSC::CodeBlock::globalObject):
  • bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::BytecodeGenerator): (JSC::BytecodeGenerator::emitJumpIfNotFunctionCall): (JSC::BytecodeGenerator::emitJumpIfNotFunctionApply): (JSC::BytecodeGenerator::findScopedProperty):
  • debugger/Debugger.cpp: (JSC::evaluateInGlobalCallFrame):
  • debugger/DebuggerActivation.cpp: (JSC::DebuggerActivation::DebuggerActivation): (JSC::DebuggerActivation::markChildren):
  • debugger/DebuggerActivation.h:
  • debugger/DebuggerCallFrame.cpp: (JSC::DebuggerCallFrame::evaluate):
  • interpreter/CallFrame.h: (JSC::ExecState::exception):
  • interpreter/Interpreter.cpp: (JSC::Interpreter::resolve): (JSC::Interpreter::resolveSkip): (JSC::Interpreter::resolveGlobal): (JSC::Interpreter::resolveGlobalDynamic): (JSC::Interpreter::resolveBaseAndProperty): (JSC::Interpreter::unwindCallFrame): (JSC::appendSourceToError): (JSC::Interpreter::execute): (JSC::Interpreter::tryCacheGetByID): (JSC::Interpreter::privateExecute):
  • jit/JITStubs.cpp: (JSC::JITThunks::tryCacheGetByID): (JSC::DEFINE_STUB_FUNCTION):
  • jsc.cpp: (GlobalObject::GlobalObject):
  • runtime/ArgList.cpp: (JSC::MarkedArgumentBuffer::markLists):
  • runtime/Arguments.cpp: (JSC::Arguments::markChildren): (JSC::Arguments::getOwnPropertySlot): (JSC::Arguments::getOwnPropertyDescriptor): (JSC::Arguments::put):
  • runtime/Arguments.h: (JSC::Arguments::setActivation): (JSC::Arguments::Arguments):
  • runtime/ArrayConstructor.cpp: (JSC::ArrayConstructor::ArrayConstructor): (JSC::constructArrayWithSizeQuirk):
  • runtime/ArrayPrototype.cpp: (JSC::arrayProtoFuncSplice):
  • runtime/BatchedTransitionOptimizer.h: (JSC::BatchedTransitionOptimizer::BatchedTransitionOptimizer): (JSC::BatchedTransitionOptimizer::~BatchedTransitionOptimizer):
  • runtime/BooleanConstructor.cpp: (JSC::BooleanConstructor::BooleanConstructor): (JSC::constructBoolean): (JSC::constructBooleanFromImmediateBoolean):
  • runtime/BooleanPrototype.cpp: (JSC::BooleanPrototype::BooleanPrototype):
  • runtime/ConservativeSet.cpp: (JSC::ConservativeSet::grow):
  • runtime/ConservativeSet.h: (JSC::ConservativeSet::~ConservativeSet): (JSC::ConservativeSet::mark):
  • runtime/DateConstructor.cpp: (JSC::DateConstructor::DateConstructor):
  • runtime/DateInstance.cpp: (JSC::DateInstance::DateInstance):
  • runtime/DatePrototype.cpp: (JSC::dateProtoFuncSetTime): (JSC::setNewValueFromTimeArgs): (JSC::setNewValueFromDateArgs): (JSC::dateProtoFuncSetYear):
  • runtime/ErrorConstructor.cpp: (JSC::ErrorConstructor::ErrorConstructor):
  • runtime/ErrorInstance.cpp: (JSC::ErrorInstance::ErrorInstance):
  • runtime/ErrorPrototype.cpp: (JSC::ErrorPrototype::ErrorPrototype):
  • runtime/FunctionConstructor.cpp: (JSC::FunctionConstructor::FunctionConstructor):
  • runtime/FunctionPrototype.cpp: (JSC::FunctionPrototype::FunctionPrototype):
  • runtime/GetterSetter.cpp: (JSC::GetterSetter::markChildren):
  • runtime/GetterSetter.h: (JSC::GetterSetter::GetterSetter): (JSC::GetterSetter::getter): (JSC::GetterSetter::setGetter): (JSC::GetterSetter::setter): (JSC::GetterSetter::setSetter):
  • runtime/GlobalEvalFunction.cpp: (JSC::GlobalEvalFunction::GlobalEvalFunction): (JSC::GlobalEvalFunction::markChildren):
  • runtime/GlobalEvalFunction.h: (JSC::GlobalEvalFunction::cachedGlobalObject):
  • runtime/Heap.cpp: (JSC::Heap::markProtectedObjects): (JSC::Heap::markTempSortVectors): (JSC::Heap::markRoots):
  • runtime/InternalFunction.cpp: (JSC::InternalFunction::InternalFunction):
  • runtime/JSAPIValueWrapper.h: (JSC::JSAPIValueWrapper::value): (JSC::JSAPIValueWrapper::JSAPIValueWrapper):
  • runtime/JSActivation.cpp: (JSC::JSActivation::markChildren): (JSC::JSActivation::put):
  • runtime/JSArray.cpp: (JSC::JSArray::JSArray): (JSC::JSArray::getOwnPropertySlot): (JSC::JSArray::getOwnPropertyDescriptor): (JSC::JSArray::put): (JSC::JSArray::putSlowCase): (JSC::JSArray::deleteProperty): (JSC::JSArray::increaseVectorLength): (JSC::JSArray::setLength): (JSC::JSArray::pop): (JSC::JSArray::push): (JSC::JSArray::unshiftCount): (JSC::JSArray::sort): (JSC::JSArray::fillArgList): (JSC::JSArray::copyToRegisters): (JSC::JSArray::compactForSorting):
  • runtime/JSArray.h: (JSC::JSArray::getIndex): (JSC::JSArray::setIndex): (JSC::JSArray::uncheckedSetIndex): (JSC::JSArray::markChildrenDirect):
  • runtime/JSByteArray.cpp: (JSC::JSByteArray::JSByteArray):
  • runtime/JSCell.h: (JSC::JSCell::JSValue::toThisObject): (JSC::JSCell::MarkStack::append):
  • runtime/JSFunction.cpp: (JSC::JSFunction::JSFunction): (JSC::JSFunction::getOwnPropertySlot):
  • runtime/JSGlobalData.h:
  • runtime/JSGlobalObject.cpp: (JSC::markIfNeeded): (JSC::JSGlobalObject::reset): (JSC::JSGlobalObject::resetPrototype): (JSC::JSGlobalObject::markChildren):
  • runtime/JSGlobalObject.h: (JSC::JSGlobalObject::JSGlobalObjectData::JSGlobalObjectData): (JSC::JSGlobalObject::regExpConstructor): (JSC::JSGlobalObject::errorConstructor): (JSC::JSGlobalObject::evalErrorConstructor): (JSC::JSGlobalObject::rangeErrorConstructor): (JSC::JSGlobalObject::referenceErrorConstructor): (JSC::JSGlobalObject::syntaxErrorConstructor): (JSC::JSGlobalObject::typeErrorConstructor): (JSC::JSGlobalObject::URIErrorConstructor): (JSC::JSGlobalObject::evalFunction): (JSC::JSGlobalObject::objectPrototype): (JSC::JSGlobalObject::functionPrototype): (JSC::JSGlobalObject::arrayPrototype): (JSC::JSGlobalObject::booleanPrototype): (JSC::JSGlobalObject::stringPrototype): (JSC::JSGlobalObject::numberPrototype): (JSC::JSGlobalObject::datePrototype): (JSC::JSGlobalObject::regExpPrototype): (JSC::JSGlobalObject::methodCallDummy): (JSC::Structure::prototypeForLookup): (JSC::constructArray):
  • runtime/JSONObject.cpp: (JSC::Stringifier::Holder::object): (JSC::Stringifier::markAggregate): (JSC::Stringifier::stringify): (JSC::Stringifier::Holder::appendNextProperty): (JSC::Walker::callReviver): (JSC::Walker::walk):
  • runtime/JSObject.cpp: (JSC::JSObject::defineGetter): (JSC::JSObject::defineSetter): (JSC::JSObject::removeDirect): (JSC::JSObject::putDirectFunction): (JSC::JSObject::putDirectFunctionWithoutTransition): (JSC::putDescriptor): (JSC::JSObject::defineOwnProperty):
  • runtime/JSObject.h: (JSC::JSObject::getDirectOffset): (JSC::JSObject::putDirectOffset): (JSC::JSObject::flattenDictionaryObject): (JSC::JSObject::putDirectInternal): (JSC::JSObject::putDirect): (JSC::JSObject::putDirectFunction): (JSC::JSObject::putDirectWithoutTransition): (JSC::JSObject::putDirectFunctionWithoutTransition): (JSC::JSValue::putDirect): (JSC::JSObject::allocatePropertyStorageInline): (JSC::JSObject::markChildrenDirect):
  • runtime/JSPropertyNameIterator.cpp: (JSC::JSPropertyNameIterator::JSPropertyNameIterator): (JSC::JSPropertyNameIterator::get):
  • runtime/JSPropertyNameIterator.h:
  • runtime/JSStaticScopeObject.cpp: (JSC::JSStaticScopeObject::markChildren):
  • runtime/JSString.cpp: (JSC::StringObject::create):
  • runtime/JSValue.h:
  • runtime/JSWrapperObject.cpp: (JSC::JSWrapperObject::markChildren):
  • runtime/JSWrapperObject.h: (JSC::JSWrapperObject::internalValue): (JSC::JSWrapperObject::setInternalValue):
  • runtime/LiteralParser.cpp: (JSC::LiteralParser::parse):
  • runtime/Lookup.cpp: (JSC::setUpStaticFunctionSlot):
  • runtime/Lookup.h: (JSC::lookupPut):
  • runtime/MarkStack.h: (JSC::MarkStack::appendValues):
  • runtime/MathObject.cpp: (JSC::MathObject::MathObject):
  • runtime/NativeErrorConstructor.cpp: (JSC::NativeErrorConstructor::NativeErrorConstructor):
  • runtime/NativeErrorPrototype.cpp: (JSC::NativeErrorPrototype::NativeErrorPrototype):
  • runtime/NumberConstructor.cpp: (JSC::NumberConstructor::NumberConstructor): (JSC::constructWithNumberConstructor):
  • runtime/NumberObject.cpp: (JSC::constructNumber):
  • runtime/NumberPrototype.cpp: (JSC::NumberPrototype::NumberPrototype):
  • runtime/ObjectConstructor.cpp: (JSC::ObjectConstructor::ObjectConstructor): (JSC::objectConstructorGetOwnPropertyDescriptor):
  • runtime/Operations.h: (JSC::normalizePrototypeChain): (JSC::resolveBase):
  • runtime/PrototypeFunction.cpp: (JSC::PrototypeFunction::PrototypeFunction):
  • runtime/PutPropertySlot.h: (JSC::PutPropertySlot::setExistingProperty): (JSC::PutPropertySlot::setNewProperty): (JSC::PutPropertySlot::base):
  • runtime/RegExpConstructor.cpp: (JSC::RegExpConstructor::RegExpConstructor):
  • runtime/ScopeChain.cpp: (JSC::ScopeChainNode::print):
  • runtime/ScopeChain.h: (JSC::ScopeChainNode::~ScopeChainNode): (JSC::ScopeChainIterator::operator*): (JSC::ScopeChainIterator::operator->): (JSC::ScopeChain::top):
  • runtime/ScopeChainMark.h: (JSC::ScopeChain::markAggregate):
  • runtime/SmallStrings.cpp: (JSC::isMarked): (JSC::SmallStrings::markChildren):
  • runtime/SmallStrings.h: (JSC::SmallStrings::emptyString): (JSC::SmallStrings::singleCharacterString): (JSC::SmallStrings::singleCharacterStrings):
  • runtime/StringConstructor.cpp: (JSC::StringConstructor::StringConstructor):
  • runtime/StringObject.cpp: (JSC::StringObject::StringObject):
  • runtime/StringObject.h:
  • runtime/StringPrototype.cpp: (JSC::StringPrototype::StringPrototype):
  • runtime/Structure.cpp: (JSC::Structure::Structure): (JSC::Structure::addPropertyTransition): (JSC::Structure::toDictionaryTransition): (JSC::Structure::flattenDictionaryStructure):
  • runtime/Structure.h: (JSC::Structure::storedPrototype):
  • runtime/WeakGCMap.h: (JSC::WeakGCMap::uncheckedGet): (JSC::WeakGCMap::isValid): (JSC::::get): (JSC::::take): (JSC::::set): (JSC::::uncheckedRemove):
  • runtime/WriteBarrier.h: Removed.

2011-01-30 Csaba Osztrogonác <ossy@webkit.org>

Unreviewed, rolling out r77098, r77099, r77100, r77109, and
r77111.
http://trac.webkit.org/changeset/77098
http://trac.webkit.org/changeset/77099
http://trac.webkit.org/changeset/77100
http://trac.webkit.org/changeset/77109
http://trac.webkit.org/changeset/77111
https://bugs.webkit.org/show_bug.cgi?id=53219

Qt build is broken

  • JSValueWrapper.cpp: (JSValueWrapper::JSObjectMark):

2011-01-30 Csaba Osztrogonác <ossy@webkit.org>

Unreviewed, rolling out r77098, r77099, r77100, r77109, and
r77111.
http://trac.webkit.org/changeset/77098
http://trac.webkit.org/changeset/77099
http://trac.webkit.org/changeset/77100
http://trac.webkit.org/changeset/77109
http://trac.webkit.org/changeset/77111
https://bugs.webkit.org/show_bug.cgi?id=53219

Qt build is broken

  • ForwardingHeaders/runtime/WriteBarrier.h: Removed.
  • WebCore.exp.in:
  • bindings/js/DOMWrapperWorld.h:
  • bindings/js/JSAudioConstructor.cpp: (WebCore::JSAudioConstructor::JSAudioConstructor):
  • bindings/js/JSDOMBinding.cpp: (WebCore::markDOMNodesForDocument): (WebCore::markDOMObjectWrapper): (WebCore::markDOMNodeWrapper):
  • bindings/js/JSDOMGlobalObject.cpp: (WebCore::JSDOMGlobalObject::markChildren): (WebCore::JSDOMGlobalObject::setInjectedScript): (WebCore::JSDOMGlobalObject::injectedScript):
  • bindings/js/JSDOMGlobalObject.h: (WebCore::JSDOMGlobalObject::JSDOMGlobalObjectData::JSDOMGlobalObjectData): (WebCore::getDOMConstructor):
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::setLocation): (WebCore::DialogHandler::dialogCreated):
  • bindings/js/JSDOMWindowShell.cpp: (WebCore::JSDOMWindowShell::JSDOMWindowShell): (WebCore::JSDOMWindowShell::setWindow): (WebCore::JSDOMWindowShell::markChildren): (WebCore::JSDOMWindowShell::unwrappedObject):
  • bindings/js/JSDOMWindowShell.h: (WebCore::JSDOMWindowShell::window): (WebCore::JSDOMWindowShell::setWindow):
  • bindings/js/JSDeviceMotionEventCustom.cpp: (WebCore::createAccelerationObject): (WebCore::createRotationRateObject):
  • bindings/js/JSEventListener.cpp: (WebCore::JSEventListener::JSEventListener): (WebCore::JSEventListener::markJSFunction):
  • bindings/js/JSEventListener.h: (WebCore::JSEventListener::jsFunction):
  • bindings/js/JSHTMLDocumentCustom.cpp: (WebCore::JSHTMLDocument::setAll):
  • bindings/js/JSImageConstructor.cpp: (WebCore::JSImageConstructor::JSImageConstructor):
  • bindings/js/JSImageDataCustom.cpp: (WebCore::toJS):
  • bindings/js/JSJavaScriptCallFrameCustom.cpp: (WebCore::JSJavaScriptCallFrame::scopeChain): (WebCore::JSJavaScriptCallFrame::scopeType):
  • bindings/js/JSNodeFilterCondition.cpp: (WebCore::JSNodeFilterCondition::markAggregate): (WebCore::JSNodeFilterCondition::acceptNode):
  • bindings/js/JSNodeFilterCondition.h:
  • bindings/js/JSNodeFilterCustom.cpp:
  • bindings/js/JSOptionConstructor.cpp: (WebCore::JSOptionConstructor::JSOptionConstructor):
  • bindings/js/JSSQLResultSetRowListCustom.cpp: (WebCore::JSSQLResultSetRowList::item):
  • bindings/js/ScriptCachedFrameData.cpp: (WebCore::ScriptCachedFrameData::restore):
  • bindings/js/ScriptObject.cpp: (WebCore::ScriptGlobalObject::set):
  • bindings/js/SerializedScriptValue.cpp: (WebCore::CloneDeserializer::putProperty):
  • bindings/scripts/CodeGeneratorJS.pm:
  • bridge/qt/qt_instance.cpp: (JSC::Bindings::QtInstance::QtInstance): (JSC::Bindings::QtInstance::removeCachedMethod): (JSC::Bindings::QtInstance::markAggregate):
  • bridge/qt/qt_instance.h:
  • bridge/qt/qt_runtime.cpp: (JSC::Bindings::QtRuntimeMetaMethod::QtRuntimeMetaMethod): (JSC::Bindings::QtRuntimeMetaMethod::markChildren): (JSC::Bindings::QtRuntimeMetaMethod::connectGetter): (JSC::Bindings::QtRuntimeMetaMethod::disconnectGetter):
  • bridge/qt/qt_runtime.h:
  • bridge/runtime_root.cpp: (JSC::Bindings::RootObject::invalidate):
  • bridge/runtime_root.h:
  • dom/Document.h:

2011-01-30 Csaba Osztrogonác <ossy@webkit.org>

Unreviewed, rolling out r77098, r77099, r77100, r77109, and
r77111.
http://trac.webkit.org/changeset/77098
http://trac.webkit.org/changeset/77099
http://trac.webkit.org/changeset/77100
http://trac.webkit.org/changeset/77109
http://trac.webkit.org/changeset/77111
https://bugs.webkit.org/show_bug.cgi?id=53219

Qt build is broken

  • WebView/WebScriptDebugDelegate.mm: (-[WebScriptCallFrame scopeChain]):
22:18 Changeset [77112] by simon.fraser@apple.com
  • 8 edits in trunk/Source/WebCore

2011-01-30 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r77107.
http://trac.webkit.org/changeset/77107
https://bugs.webkit.org/show_bug.cgi?id=53412

Caused 5 new form-related test crashes (Requested by smfr on
#webkit).

  • css/CSSSelector.cpp: (WebCore::CSSSelector::pseudoId): (WebCore::nameToPseudoTypeMap): (WebCore::CSSSelector::extractPseudoType):
  • css/CSSSelector.h:
  • html/HTMLProgressElement.cpp: (WebCore::HTMLProgressElement::parseMappedAttribute): (WebCore::HTMLProgressElement::attach):
  • html/HTMLProgressElement.h:
  • rendering/RenderProgress.cpp: (WebCore::RenderProgress::~RenderProgress): (WebCore::RenderProgress::updateFromElement): (WebCore::RenderProgress::layoutParts): (WebCore::RenderProgress::shouldHaveParts):
  • rendering/RenderProgress.h:
  • rendering/style/RenderStyleConstants.h:
22:05 Changeset [77111] by simon.fraser@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2011-01-30 Simon Fraser <simon.fraser@apple.com>

Build fix the build fix. I assume Oliver meant m_cell, not m_value.

  • runtime/WriteBarrier.h: (JSC::WriteBarrierBase::clear):
22:02 Changeset [77110] by simon.fraser@apple.com
  • 10 edits
    4 adds in trunk

2011-01-30 Simon Fraser <simon.fraser@apple.com>

Reviewed by Sam Weinig.

Enhance ShadowBlur to render inset box shadows
https://bugs.webkit.org/show_bug.cgi?id=51567

Use ShadowBlur for inset box-shadows with CG. It
currently lacks a tiled version, but is still much
faster than CG shadows.

Test: fast/box-shadow/inset-box-shadow-radius.html

  • platform/graphics/ShadowBlur.cpp:
  • platform/graphics/ShadowBlur.h: New method for inset shadows. (WebCore::ShadowBlur::drawInsetShadow):
  • platform/graphics/GraphicsContext.cpp: #ifdef out fillRectWithRoundedHole() for CG.
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::fillRectWithRoundedHole): If there's a shadow with a radius > 0, use ShadowBlur.
21:54 Changeset [77109] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

More Qt build fixes

21:11 Changeset [77108] by kbr@google.com
  • 5 edits
    1 add in trunk

2011-01-28 Kenneth Russell <kbr@google.com>

Reviewed by Chris Marrin.

WebGL shows PNG Textures with indexed colors too dark
https://bugs.webkit.org/show_bug.cgi?id=47477

Added test case for upload of indexed PNG images to
gl-teximage.html in the Khronos WebGL conformance tests.
Synchronized this test with the Khronos repository.

  • fast/canvas/webgl/gl-teximage-expected.txt:
  • fast/canvas/webgl/gl-teximage.html:
  • fast/canvas/webgl/resources/red-indexed.png: Added.

2011-01-28 Kenneth Russell <kbr@google.com>

Reviewed by Chris Marrin.

WebGL shows PNG Textures with indexed colors too dark
https://bugs.webkit.org/show_bug.cgi?id=47477

Properly handle indexed PNG images by re-rendering them as RGBA
images before upload. Verified with this layout test and the test
cases from bugs 47477 and 53269.

  • platform/graphics/cg/GraphicsContext3DCG.cpp: (WebCore::GraphicsContext3D::getImageData):
20:39 Changeset [77107] by morrita@google.com
  • 8 edits in trunk/Source/WebCore

2011-01-27 MORITA Hajime <morrita@google.com>

Reviewed by Dimitri Glazkov.

Convert <progress> shadow DOM to a DOM-based shadow.
https://bugs.webkit.org/show_bug.cgi?id=50660

  • Removed RenderProgress::m_valuePart, moved the shadow node to the shadow root of HTMLProgressElement.
  • Removed hard-coded pseudo ID for -webkit-progress-bar-value. ProgressBarValueElement is defined only for overriding shadowPseudoId().

No new tests. No behavioral change.

  • css/CSSSelector.cpp: (WebCore::CSSSelector::pseudoId): (WebCore::nameToPseudoTypeMap): (WebCore::CSSSelector::extractPseudoType):
  • css/CSSSelector.h:
  • html/HTMLProgressElement.cpp: (WebCore::ProgressBarValueElement::ProgressBarValueElement): (WebCore::ProgressBarValueElement::shadowPseudoId): (WebCore::ProgressBarValueElement::create): (WebCore::HTMLProgressElement::parseMappedAttribute): (WebCore::HTMLProgressElement::attach): (WebCore::HTMLProgressElement::valuePart): (WebCore::HTMLProgressElement::didElementStateChange): (WebCore::HTMLProgressElement::createShadowSubtreeIfNeeded):
  • html/HTMLProgressElement.h:
  • rendering/RenderProgress.cpp: (WebCore::RenderProgress::~RenderProgress): (WebCore::RenderProgress::updateFromElement): (WebCore::RenderProgress::layoutParts): (WebCore::RenderProgress::shouldHaveParts): (WebCore::RenderProgress::valuePart):
  • rendering/RenderProgress.h:
  • rendering/style/RenderStyleConstants.h:
20:26 Changeset [77106] by simon.fraser@apple.com
  • 4 edits in trunk/Source/WebCore

2011-01-30 Simon Fraser <simon.fraser@apple.com>

Reviewed by Ariya Hidayat.

Enhance ShadowBlur to render inset box shadows; Part 1.
https://bugs.webkit.org/show_bug.cgi?id=51567

Add a new method to GraphicsContext to render a rect with a rounded hole,
for use by inset box-shadow code. Knowledge that we're rendering a rounded
hole will enable ShadowBlur to be used here in future.

  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::fillRectWithRoundedHole):
  • platform/graphics/GraphicsContext.h:
  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintBoxShadow):
20:23 Changeset [77105] by morrita@google.com
  • 3 edits
    4 adds in trunk

2011-01-23 MORITA Hajime <morrita@google.com>

Reviewed by Eric Seidel.

REGRESSION: Inset shadow with too large border radius misses rounded corner.
https://bugs.webkit.org/show_bug.cgi?id=52800

  • fast/box-shadow/inset-with-extraordinary-radii-and-border.html: Added.
  • platform/mac/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.checksum: Added.
  • platform/mac/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.png: Added.
  • platform/mac/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.txt: Added.

2011-01-23 MORITA Hajime <morrita@google.com>

Reviewed by Eric Seidel.

REGRESSION: Inset shadow with too large border radius misses rounded corner.
https://bugs.webkit.org/show_bug.cgi?id=52800

The refactoring on r76083 broke the invariant between border
IntRect and its radii because RoundedIntRect::setRect() is called
after getRoundedInnerBorderWithBorderWidths(), which enforces the
invariant. Th rounded-rect clipping code verifies the invariant,
and discard the invalid radii, that results broken paintings.

This change moved setRect() before
getRoundedInnerBorderWithBorderWidths() not to modify the valid
RoundedIntRect value.

Test: fast/box-shadow/inset-with-extraordinary-radii-and-border.html

  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintBoxShadow):
20:06 Changeset [77104] by ggaren@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-01-30 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

[Take 2!]
Fixed crash on window close (maybe crash on launch?) due to missing frame null checks
https://bugs.webkit.org/show_bug.cgi?id=53408

  • UIProcess/WebContext.cpp: (WebKit::WebContext::didNavigateWithNavigationData): (WebKit::WebContext::didPerformClientRedirect): (WebKit::WebContext::didPerformServerRedirect): (WebKit::WebContext::didUpdateHistoryTitle): Use MESSAGE_CHECK because we don't think we should be able to reach this state under normal conditions.
20:05 Changeset [77103] by simon.fraser@apple.com
  • 2 edits in trunk/Source/WebCore

2011-01-30 Simon Fraser <simon.fraser@apple.com>

Attempt to fix Windows build by adding ShadowBlur.cpp/h to the
vcproj.

  • WebCore.vcproj/WebCore.vcproj:
19:36 Changeset [77102] by ggaren@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-01-30 Geoffrey Garen <ggaren@apple.com>

Reviewed by Maciej Stachowiak.

Fixed crash on window close (maybe crash on launch?) due to missing
frame null checks
https://bugs.webkit.org/show_bug.cgi?id=53408

  • UIProcess/WebContext.cpp: (WebKit::WebContext::didNavigateWithNavigationData): (WebKit::WebContext::didPerformClientRedirect): (WebKit::WebContext::didPerformServerRedirect): (WebKit::WebContext::didUpdateHistoryTitle): Check for NULL, since we're calling a function that can return it.
19:36 Changeset [77101] by simon.fraser@apple.com
  • 32 edits
    1 move
    7 adds
    6 deletes in trunk

2011-01-30 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

-webkit-box-shadow causes awful scroll/resize/redraw performance
https://bugs.webkit.org/show_bug.cgi?id=22102

Use ShadowBlur for CG, whe rendering shadows on rects and
rounded rects outside of canvas.

CG shadows with a radius of more than 8px do not render
correctly. We preserve this incorrect rendering by compensating
for it when rending -webkit-box-shadow. Calls that should use
this deprecated radius behavior now use setLegacyShadow().

Test: fast/box-shadow/box-shadow-transformed.html

  • html/canvas/CanvasRenderingContext2D.cpp: Use setLegacyShadow() for canvas, to indicate that it should use the deprecated radius behavior. (WebCore::CanvasRenderingContext2D::setAllAttributesToDefault): Ditto. (WebCore::CanvasRenderingContext2D::setShadow): Ditto. (WebCore::CanvasRenderingContext2D::applyShadow): Ditto.
  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::setLegacyShadow): Set the m_state.shadowsUseLegacyRadius bit.
  • platform/graphics/GraphicsContext.h: (WebCore::GraphicsContextState::GraphicsContextState): Add a shadowsUseLegacyRadius bit to the state.
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::radiusToLegacyRadius): Map from the actual radius to one that approximates CG behavior. (WebCore::hasBlurredShadow): Helper that returns true if we have a shadow with a non-zero blur radius. (WebCore::GraphicsContext::fillRect): Use ShadowBlur if not canvas. (WebCore::GraphicsContext::fillRoundedRect): Ditto. (WebCore::GraphicsContext::setPlatformShadow): Comment.
  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintBoxShadow): Call setLegacyShadow() for -webkit-box-shadow.
  • platform/graphics/ShadowBlur.cpp: (WebCore::ShadowBlur::calculateLayerBoundingRect): Fix some pixel crack issues by rounding up the blur radius. (WebCore::ShadowBlur::drawRectShadow): Ditto (WebCore::ShadowBlur::drawRectShadowWithTiling): Ditto.
19:11 Changeset [77100] by oliver@apple.com
  • 2 edits in trunk/Source/WebCore

Try to fix Qt build (again).

17:35 Changeset [77099] by oliver@apple.com
  • 3 edits in trunk/Source/WebCore

Try to fix Qt build.

17:13 Changeset [77098] by oliver@apple.com
  • 125 edits
    2 adds in trunk/Source

Convert markstack to a slot visitor API
https://bugs.webkit.org/show_bug.cgi?id=53219

rolling r77006 and r77020 back in.

16:44 Changeset [77097] by simon.fraser@apple.com
  • 6 edits
    2 adds in trunk/Source/WebCore

2011-01-30 Simon Fraser <simon.fraser@apple.com>

Reviewed by Sam Weinig.

Make ContextShadow code cross-platform
https://bugs.webkit.org/show_bug.cgi?id=51312

Add a new class, ShadowBlur, that contains most of the
code from ContextShadow, but is fully cross-platform.
It depends on one new method, GraphicsContext::clipBounds(),
which platforms will have to implement.

Add ShadowBlur to the Mac Xcode project, but don't use it
anywhere yet.

  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::clipBounds):
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/ShadowBlur.cpp: Added. (WebCore::roundUpToMultipleOf32): (WebCore::ScratchBuffer::ScratchBuffer): (WebCore::ScratchBuffer::getScratchBuffer): (WebCore::ScratchBuffer::scheduleScratchBufferPurge): (WebCore::ScratchBuffer::timerFired): (WebCore::ScratchBuffer::clearScratchBuffer): (WebCore::ScratchBuffer::shared): (WebCore::ShadowBlur::ShadowBlur): (WebCore::ShadowBlur::blurLayerImage): (WebCore::ShadowBlur::adjustBlurDistance): (WebCore::ShadowBlur::calculateLayerBoundingRect): (WebCore::ShadowBlur::beginShadowLayer): (WebCore::ShadowBlur::endShadowLayer): (WebCore::ShadowBlur::drawRectShadow): (WebCore::ShadowBlur::drawRectShadowWithoutTiling): (WebCore::ShadowBlur::drawRectShadowWithTiling): (WebCore::ShadowBlur::clipBounds):
  • platform/graphics/ShadowBlur.h: Added. (WebCore::ShadowBlur::setShadowsIgnoreTransforms): (WebCore::ShadowBlur::shadowsIgnoreTransforms):
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::clipBounds):
15:32 Changeset [77096] by dpranke@chromium.org
  • 2 edits in trunk/Tools

2011-01-30 Dirk Pranke <dpranke@chromium.org>

Unreviewed, build fix.

Fix regression introduced in r77093 - path.rsplit() doesn't
take keyword arguments.

https://bugs.webkit.org/show_bug.cgi?id=53326

  • Scripts/webkitpy/common/system/filesystem_mock.py:
15:16 Changeset [77095] by dpranke@chromium.org
  • 5 edits
    3 copies in trunk/Tools

2011-01-30 Dirk Pranke <dpranke@chromium.org>

Reviewed by Mihai Parparita.

Add more unit tests for rebaseline-chromium-webkit-tests. This
change involves restructuring a bunch of r-c-w-t code to make it
more testable as well. We also add wrapper classes for handling
testing zip files and fetching URLs.

https://bugs.webkit.org/show_bug.cgi?id=53040

  • Scripts/webkitpy/common/system/urlfetcher.py:
  • Scripts/webkitpy/common/system/urlfetcher_mock.py:
  • Scripts/webkitpy/common/system/zipfileset_mock.py:
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
  • Scripts/webkitpy/tool/mocktool.py:
15:07 Changeset [77094] by ggaren@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

2011-01-30 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Filter all Heap collection through a common reset function, in
preparation for adding features triggered by collection.
https://bugs.webkit.org/show_bug.cgi?id=53396


SunSpider reports no change.

  • runtime/Heap.cpp: (JSC::Heap::reportExtraMemoryCostSlowCase): When we're over the extraCost limit, just call collectAllGarbage() instead of rolling our own special way of resetting the heap. In theory, this may be slower in some cases, but it also fixes cases of pathological heap growth that we've seen, where the only objects being allocated are temporary and huge (<rdar://problem/8885843>).

(JSC::Heap::allocate):
(JSC::Heap::collectAllGarbage): Use the shared reset function.

(JSC::Heap::reset):

  • runtime/Heap.h: Carved a new shared reset function out of the old collectAllGarbage.
15:07 Changeset [77093] by dpranke@chromium.org
  • 9 edits in trunk/Tools

2011-01-30 Dirk Pranke <dpranke@chromium.org>

Reviewed by Eric Seidel.

Clean up of the filesystem-related modules used in webkitpy.
I've added relpath() to the filesystem interface, modified
ospath.relpath() so that it could work with the filesystem
interface, and modified the fileset* routines to use the
filesystem interface consistently.

This patch also adds a close() routine to the fileset routines
to indicate that the caller is done with the fileset. This
allows zipfileset to clean up after itself when it creates
tempfiles to store downloads.

https://bugs.webkit.org/show_bug.cgi?id=53326

  • Scripts/webkitpy/common/system/directoryfileset.py:
  • Scripts/webkitpy/common/system/fileset.py:
  • Scripts/webkitpy/common/system/filesystem.py:
  • Scripts/webkitpy/common/system/filesystem_mock.py:
  • Scripts/webkitpy/common/system/filesystem_unittest.py:
  • Scripts/webkitpy/common/system/ospath.py:
  • Scripts/webkitpy/common/system/zipfileset.py:
  • Scripts/webkitpy/common/system/zipfileset_unittest.py:
12:25 Changeset [77092] by kbalazs@webkit.org
  • 6 edits in trunk

2011-01-30 Balazs Kelemen <kbalazs@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt][WK2]REGRESSION (r76991): Fix build errors
https://bugs.webkit.org/show_bug.cgi?id=53400

Revert the temporary build fix (http://trac.webkit.org/changeset/77088)
and remove WebKit2Prefix.h from the build.

  • UIProcess/API/qt/qwkhistory.h:
  • UIProcess/API/qt/qwkpage.h:
  • WebKit2.pro:

2011-01-30 Balazs Kelemen <kbalazs@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt][WK2]REGRESSION (r76991): Fix build errors
https://bugs.webkit.org/show_bug.cgi?id=53400

Revert the temporary build fix (http://trac.webkit.org/changeset/77088)
and remove WebKit2Prefix.h from the build.

  • MiniBrowser/qt/MiniBrowser.pro:
12:04 Changeset [77091] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

2011-01-30 Jeff Miller <jeffm@apple.com>

Reviewed by Dan Bernstein.

FindController::updateFindIndicator() crashes if selection isn't visible
https://bugs.webkit.org/show_bug.cgi?id=53399

  • WebProcess/WebPage/FindController.cpp: (WebKit::FindController::updateFindIndicator): Return false if ShareableBitmap::createShareable() returns null (typically because the selection rect is empty).
11:54 Changeset [77090] by ossy@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r77025.
http://trac.webkit.org/changeset/77025
https://bugs.webkit.org/show_bug.cgi?id=53401

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-01-30
It made js1_5/Regress/regress-159334.js fail on 64 bit Linux
(Requested by Ossy on #webkit).

  • jit/ExecutableAllocatorFixedVMPool.cpp:

(JSC::FreeListEntry::FreeListEntry):
(JSC::AVLTreeAbstractorForFreeList::get_less):
(JSC::AVLTreeAbstractorForFreeList::set_less):
(JSC::AVLTreeAbstractorForFreeList::get_greater):
(JSC::AVLTreeAbstractorForFreeList::set_greater):
(JSC::AVLTreeAbstractorForFreeList::get_balance_factor):
(JSC::AVLTreeAbstractorForFreeList::set_balance_factor):
(JSC::AVLTreeAbstractorForFreeList::null):
(JSC::AVLTreeAbstractorForFreeList::compare_key_key):
(JSC::AVLTreeAbstractorForFreeList::compare_key_node):
(JSC::AVLTreeAbstractorForFreeList::compare_node_node):
(JSC::reverseSortFreeListEntriesByPointer):
(JSC::reverseSortCommonSizedAllocations):
(JSC::FixedVMPoolAllocator::release):
(JSC::FixedVMPoolAllocator::reuse):
(JSC::FixedVMPoolAllocator::addToFreeList):
(JSC::FixedVMPoolAllocator::coalesceFreeSpace):
(JSC::FixedVMPoolAllocator::FixedVMPoolAllocator):
(JSC::FixedVMPoolAllocator::alloc):
(JSC::FixedVMPoolAllocator::free):
(JSC::FixedVMPoolAllocator::isValid):
(JSC::FixedVMPoolAllocator::allocInternal):
(JSC::FixedVMPoolAllocator::isWithinVMPool):
(JSC::FixedVMPoolAllocator::addToCommittedByteCount):
(JSC::ExecutableAllocator::committedByteCount):
(JSC::maybeModifyVMPoolSize):
(JSC::ExecutableAllocator::isValid):
(JSC::ExecutableAllocator::underMemoryPressure):
(JSC::ExecutablePool::systemAlloc):
(JSC::ExecutablePool::systemRelease):

  • wtf/PageReservation.h:

(WTF::PageReservation::PageReservation):
(WTF::PageReservation::commit):
(WTF::PageReservation::decommit):

10:19 Changeset [77089] by simon.fraser@apple.com
  • 4 edits
    4 adds in trunk

2011-01-29 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

CSS3 gradients with em-based stops fail to repaint when font size changes
https://bugs.webkit.org/show_bug.cgi?id=51845

Mark as uncacheable gradidients whose color stops depend on font size,
and don't attempt to put these into CSSImageGeneratorValue's image cache.
This means we return a new gradient each time, which is fairly cheap, and
fixes repaint issues under changing font size.

Test: fast/repaint/gradients-em-stops-repaint.html

  • css/CSSGradientValue.cpp: (WebCore::CSSGradientValue::image): (WebCore::CSSGradientValue::isCacheable):
  • css/CSSGradientValue.h:
05:21 Changeset [77088] by ossy@webkit.org
  • 5 edits in trunk

Unreviewed.

[Qt][WK2] Buildfix.

Source/WebKit2:

  • UIProcess/API/qt/qwkhistory.h:
  • UIProcess/API/qt/qwkpage.h:

Tools:

  • MiniBrowser/qt/MiniBrowser.pro:
03:54 Changeset [77087] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-01-30 Leo Yang <leo.yang@torchmobile.com.cn>

Reviewed by Daniel Bates.

Code style issue in JavaScriptCore/wtf/CurrentTime.h
https://bugs.webkit.org/show_bug.cgi?id=53394

According to rule #3 at http://webkit.org/coding/coding-style.html,
This patch fix style issue in CurrentTime.h.

No functionality change, no new tests.

  • wtf/CurrentTime.h: (WTF::currentTimeMS): (WTF::getLocalTime):
02:40 Changeset [77086] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-01-30 Benjamin Poulain <ikipou@gmail.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] JavaScriptCore does not link on Mac if building WebKit 2
https://bugs.webkit.org/show_bug.cgi?id=53377

The option "-whole-archive" is not availabe with the libtool of Mac OS X,
instead, we can use "-all_load" on Mac.

00:30 Changeset [77085] by mjs@apple.com
  • 5 edits in trunk/Source/WebKit2

2011-01-29 Maciej Stachowiak <mjs@apple.com>

Reviewed by Geoffrey Garen.

Add WKPageCopyPendingAPIRequestURL API
https://bugs.webkit.org/show_bug.cgi?id=53383

This API returns the last URL requested for load via API, if neither that load nor any
other load subsequently reaches the provisional state.


This is useful to be able to track loads initiated via the API


  • UIProcess/API/C/WKPage.cpp: (WKPageCopyPendingAPIRequestURL): Retrieve the pending URL.
  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::loadURL): Set pending URL. (WebKit::WebPageProxy::loadURLRequest): ditto (WebKit::WebPageProxy::reload): ditto (WebKit::WebPageProxy::goForward): ditto (WebKit::WebPageProxy::goBack): ditto (WebKit::WebPageProxy::estimatedProgress): Assume the initial progress value when there is a pending URL. (WebKit::WebPageProxy::didStartProvisionalLoadForFrame): Clear pending URL; clients should look at the provisional URL now. (WebKit::WebPageProxy::decidePolicyForNavigationAction): Clear pending URL if it doesn't match the policy URL; this means we were interrupted by another load.
  • UIProcess/WebPageProxy.h: (WebKit::WebPageProxy::pendingAPIRequestURL): Helper function. (WebKit::WebPageProxy::clearPendingAPIRequestURL): ditto (WebKit::WebPageProxy::setPendingAPIRequestURL): ditto

01/29/11:

22:48 Changeset [77084] by mitz@apple.com
  • 2312 edits in trunk/LayoutTests/platform

Set the svn:mime-type property of some PNG files to image/png

22:43 Changeset [77083] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Sorry Leopard bot -- I committed a change by accident.

22:23 Changeset [77082] by ggaren@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

2011-01-29 Geoffrey Garen <ggaren@apple.com>

Reviewed by Cameron Zwarich.

Simplified Heap iteration
https://bugs.webkit.org/show_bug.cgi?id=53393

  • runtime/CollectorHeapIterator.h: (JSC::CollectorHeapIterator::isValid): (JSC::CollectorHeapIterator::isLive): (JSC::CollectorHeapIterator::advance): Removed "max" argument to advance because it's a constant. (JSC::LiveObjectIterator::LiveObjectIterator): (JSC::LiveObjectIterator::operator++): (JSC::DeadObjectIterator::DeadObjectIterator): (JSC::DeadObjectIterator::operator++): (JSC::ObjectIterator::ObjectIterator): (JSC::ObjectIterator::operator++): Factored out common checks into two helper functions -- isValid() for "Am I past the end?" and isLive() for "Is the cell I'm pointing to live?".
  • runtime/MarkedSpace.cpp: (JSC::MarkedSpace::freeBlock): (JSC::MarkedSpace::sweep): Always sweep from the beginning of the heap to the end, to avoid making sweep subtly reliant on internal Heap state. (JSC::MarkedSpace::primaryHeapBegin): (JSC::MarkedSpace::primaryHeapEnd): Always be explicit about where iteration begins.
22:11 Changeset [77081] by ggaren@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

2011-01-29 Geoffrey Garen <ggaren@apple.com>

Reviewed by Cameron Zwarich.

Simplified heap destruction
https://bugs.webkit.org/show_bug.cgi?id=53392

  • JavaScriptCore.exp:
  • runtime/Heap.cpp: (JSC::Heap::destroy):
  • runtime/Heap.h:
  • runtime/MarkedSpace.cpp: (JSC::MarkedSpace::destroy):
  • runtime/MarkedSpace.h: Don't go out of our way to destroy GC-protected cells last -- the difficult contortions required to do so just don't seem justified. We make no guarantees about GC protection after the client throws away JSGlobalData, and it doesn't seem like any meaningful guarantee is even possible.
21:58 Changeset [77080] by ggaren@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

2011-01-29 Geoffrey Garen <ggaren@apple.com>

Reviewed by Maciej Stachowiak.

Switched heap to use the Bitmap class and removed CollectorBitmap
https://bugs.webkit.org/show_bug.cgi?id=53391


SunSpider says 1.005x as fast. Seems like a fluke.

  • runtime/MarkedSpace.cpp: (JSC::MarkedSpace::allocate): Updated for rename and returning a value rather than taking a value by reference.
  • runtime/MarkedSpace.h: Code reuse is good.
  • wtf/Bitmap.h: (WTF::::testAndSet): Added, since this is the one thing Bitmap was missing which CollectorBitmap had. (Renamed from the less conventional "getset".)

(WTF::::nextPossiblyUnset): Renamed and changed to return a value for
clarity. It's all the same with inlining.

20:17 Changeset [77079] by ggaren@apple.com
  • 2 edits in trunk/Source/WebCore

Undo try to fix the Qt build.

My guess didn't work.

  • WebCore.pro:
20:04 Changeset [77078] by ggaren@apple.com
  • 2 edits in trunk/Source/WebCore

Try to fix the Qt build.

  • WebCore.pro: Added platform/text/CharacterNames.h.
19:32 Changeset [77077] by ggaren@apple.com
  • 14 edits in trunk/Source

2011-01-28 Geoffrey Garen <ggaren@apple.com>

Reviewed by Maciej Stachowiak.

Some more Heap cleanup.
https://bugs.webkit.org/show_bug.cgi?id=53357


  • runtime/Heap.cpp: (JSC::Heap::reportExtraMemoryCostSlowCase): Renamed recordExtraCost to reportExtraMemoryCostSlowCase to match our naming conventions.

(JSC::Heap::capacity): Renamed size to capacity because this function
returns the capacity of the heap, including unused portions.

  • runtime/Heap.h: (JSC::Heap::globalData): (JSC::Heap::markedSpace): (JSC::Heap::machineStackMarker): (JSC::Heap::reportExtraMemoryCost): Moved statics to the top of the file. Moved ctor and dtor to the beginning of the class definition. Grouped functions by purpose.
  • runtime/MarkedSpace.cpp: (JSC::MarkedSpace::capacity): Renamed size to capacity because this function returns the capacity of the heap, including unused portions.
  • runtime/MarkedSpace.h: Removed statistics and the Statistics class because the same information can be gotten just by calling size() and capacity().
  • runtime/MemoryStatistics.cpp:
  • runtime/MemoryStatistics.h: Ditto.

2011-01-28 Geoffrey Garen <ggaren@apple.com>

Reviewed by Maciej Stachowiak.

Some more Heap cleanup.
https://bugs.webkit.org/show_bug.cgi?id=53357

Updated for JavaScriptCore changes.

  • Misc/WebCoreStatistics.mm: (+[WebCoreStatistics memoryStatistics]):

2011-01-28 Geoffrey Garen <ggaren@apple.com>

Reviewed by Maciej Stachowiak.

Some more Heap cleanup.
https://bugs.webkit.org/show_bug.cgi?id=53357


Updated for JavaScriptCore changes.

  • bindings/js/ScriptGCEvent.cpp: (WebCore::ScriptGCEvent::getHeapSize):
18:39 Changeset [77076] by abarth@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-01-29 Adam Barth <abarth@webkit.org>

Reviewed by Daniel Bates.

Fix XSSFilter crash when extracting the source for a token twice
https://bugs.webkit.org/show_bug.cgi?id=53368

Previously, it was unsafe to extract the source for the same token
twice because the HTMLSourceTracker would advance its internal
representation of the SegmentedString. This patch introduces a cache
to make calling HTMLSourceTracker::sourceForToken multiple times safe.

  • html/parser/HTMLSourceTracker.cpp: (WebCore::HTMLSourceTracker::end): (WebCore::HTMLSourceTracker::sourceForToken):
  • html/parser/HTMLSourceTracker.h:
16:22 Changeset [77075] by mjs@apple.com
  • 2 edits in trunk/Source/WebCore

2011-01-29 Maciej Stachowiak <mjs@apple.com>

Reviewed by Dan Bernstein.

Fix fat build for both 32-bit and 64-bit under llvm-gcc 4.2
https://bugs.webkit.org/show_bug.cgi?id=53386

  • platform/mac/ScrollAnimatorMac.mm: (WebCore::elasticDeltaForReboundDelta): (WebCore::scrollWheelMultiplier): (WebCore::ScrollAnimatorMac::smoothScrollWithEvent): (WebCore::ScrollAnimatorMac::beginScrollGesture): (WebCore::roundTowardZero): (WebCore::ScrollAnimatorMac::snapRubberBandTimerFired):
15:21 Changeset [77074] by mjs@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed fix for last commit.

Remove stray slash in previous commit.

  • platform/mac-wk2/Skipped:
15:14 Changeset [77073] by dbates@webkit.org
  • 4 edits in trunk

2011-01-29 Daniel Bates <dbates@rim.com>

Reviewed by Maciej Stachowiak.

Remove reference to ${CMAKE_SOURCE_DIR}/Source in CMake files
https://bugs.webkit.org/show_bug.cgi?id=53382

Our file system hierarchy ensures that CMAKE_SOURCE_DIR is defined to be /Source.
So, ${CMAKE_SOURCE_DIR}/Source evaluates to the non-existent directory /Source/Source.
Therefore, we should remove such references.

  • Source/cmake/OptionsCommon.cmake:

2011-01-29 Daniel Bates <dbates@rim.com>

Reviewed by Maciej Stachowiak.

Remove reference to ${CMAKE_SOURCE_DIR}/Source in CMake files
https://bugs.webkit.org/show_bug.cgi?id=53382

Our file system hierarchy ensures that CMAKE_SOURCE_DIR is defined to be /Source.
So, ${CMAKE_SOURCE_DIR}/Source evaluates to the non-existent directory /Source/Source.
Therefore, we should remove such references.

  • CMakeLists.txt:
15:10 Changeset [77072] by mjs@apple.com
  • 2 edits in trunk/LayoutTests

2011-01-29 Maciej Stachowiak <mjs@apple.com>

Reviewed by Daniel Bates.

Skip a test that uses unimplemented DRT API
https://bugs.webkit.org/show_bug.cgi?id=53381

  • platform/mac-wk2/Skipped:
14:19 Changeset [77071] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

Fix 32-bit build on the Mac.

Reviewed by Jon Honeycutt.

  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::roundTowardZero):
(WebCore::roundToDevicePixelTowardZero):
Use floats instead of doubles to avoid double-to-float conversion
issues.

14:17 Changeset [77070] by dbates@webkit.org
  • 6 edits
    1 add
    1 delete in trunk

2011-01-29 Daniel Bates <dbates@rim.com>

Reviewed by Eric Seidel.

Move wince/mt19937ar.c to ThirdParty and make it a policy choice
https://bugs.webkit.org/show_bug.cgi?id=53253

Move implementation of Mersenne Twister pseudorandom number generator to
ThirdParty since it is a third party library.

  • Source/ThirdParty/mt19937ar.c: Copied from Source/JavaScriptCore/wtf/wince/mt19937ar.c.

2011-01-29 Daniel Bates <dbates@rim.com>

Reviewed by Eric Seidel.

Move wince/mt19937ar.c to ThirdParty and make it a policy choice
https://bugs.webkit.org/show_bug.cgi?id=53253

Make inclusion of MT19937 a policy decision.

Currently, we hardcoded to use MT19937 when building for
Windows CE. Instead, we should make this a policy decision
with the Windows CE port using this by default.

  • JavaScriptCore.pri: Append Source/ThirdParty to the end of the list include directories.
  • wtf/CMakeLists.txt: Ditto.
  • wtf/Platform.h: Defined WTF_USE_MERSENNE_TWISTER_19937 when building for Windows CE.
  • wtf/RandomNumber.cpp: (WTF::randomNumber): Substituted USE(MERSENNE_TWISTER_19937) for OS(WINCE).
14:00 Changeset [77069] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

2011-01-29 Gustavo Noronha Silva <gns@gnome.org>

[GTK] REGRESSION: http/tests/media/video-{cookie,referer}.html failing
https://bugs.webkit.org/show_bug.cgi?id=53379

Skip tests failing likely by the usage of a newer version of soup.

  • platform/gtk/Skipped:
12:47 Changeset [77068] by rniwa@webkit.org
  • 3 edits
    10 adds in trunk/LayoutTests

2011-01-29 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed Chromium rebaselines.

  • platform/chromium-linux/fast/block/positioning/001-expected.checksum: Added.
  • platform/chromium-linux/fast/block/positioning/001-expected.png: Added.
  • platform/chromium-linux/svg/clip-path/clip-in-mask-objectBoundingBox-expected.checksum: Added.
  • platform/chromium-linux/svg/clip-path/clip-in-mask-objectBoundingBox-expected.png: Added.
  • platform/chromium-linux/svg/clip-path/clip-in-mask-userSpaceOnUse-expected.checksum: Added.
  • platform/chromium-linux/svg/clip-path/clip-in-mask-userSpaceOnUse-expected.png: Added.
  • platform/chromium-win/svg/clip-path/clip-in-mask-objectBoundingBox-expected.checksum: Added.
  • platform/chromium-win/svg/clip-path/clip-in-mask-objectBoundingBox-expected.png: Added.
  • platform/chromium-win/svg/clip-path/clip-in-mask-userSpaceOnUse-expected.checksum: Added.
  • platform/chromium-win/svg/clip-path/clip-in-mask-userSpaceOnUse-expected.png: Added.
  • platform/chromium-win/svg/custom/missing-xlink-expected.txt:
  • platform/chromium/test_expectations.txt:
12:31 Changeset [77067] by cwzwarich@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Bug 53374 - Remove uses of unsafe string functions in debugging code
https://bugs.webkit.org/show_bug.cgi?id=53374

Reviewed by David Kilzer.

  • runtime/RegExp.cpp:

(JSC::RegExp::printTraceData):

12:27 Changeset [77066] by cwzwarich@webkit.org
  • 1 edit in trunk/Source/JavaScriptCore/ChangeLog

Fix ChangeLog date.

12:18 Changeset [77065] by cwzwarich@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

JavaScriptCoreUseJIT environment variable broken
https://bugs.webkit.org/show_bug.cgi?id=53372

Reviewed by Oliver Hunt.

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData): Check the actual value in the string returned
by getenv() rather than just doing a NULL check on the return value.

11:43 Changeset [77064] by simon.fraser@apple.com
  • 3 edits in trunk/Source/WebCore

2011-01-28 Simon Fraser <simon.fraser@apple.com>

Reviewed by Adam Barth.

Use clampToInteger() functions in a few places
https://bugs.webkit.org/show_bug.cgi?id=53363

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): Use clampToInteger() for z-index. (WebCore::CSSStyleSelector::createTransformOperations): Use clampToPositiveInteger().
  • platform/graphics/transforms/PerspectiveTransformOperation.cpp: Ditto. (WebCore::PerspectiveTransformOperation::blend): Ditto.
10:50 Changeset [77063] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-01-29 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed Chromium test expectation update; removed http/tests/appcache/online-whitelist.html
from the test expectation, because it has been passing on Chromium Windows.

  • platform/chromium/test_expectations.txt:
09:04 Changeset [77062] by paroga@webkit.org
  • 56 edits
    2 adds
    1 delete in trunk/Source

2011-01-29 Patrick Gansterer <paroga@webkit.org>

Reviewed by David Kilzer.

Move CharacterNames.h into WTF directory
https://bugs.webkit.org/show_bug.cgi?id=49618

  • GNUmakefile.am:
  • JavaScriptCore.gypi:
  • JavaScriptCore.vcproj/WTF/WTF.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • wtf/CMakeLists.txt:
  • wtf/unicode/CharacterNames.h: Renamed from WebCore/platform/text/CharacterNames.h.
  • wtf/unicode/UTF8.cpp:

2011-01-29 Patrick Gansterer <paroga@webkit.org>

Reviewed by David Kilzer.

Move CharacterNames.h into WTF directory
https://bugs.webkit.org/show_bug.cgi?id=49618

  • ForwardingHeaders/wtf/unicode/CharacterNames.h: Added.
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • accessibility/AccessibilityObject.cpp:
  • accessibility/AccessibilityRenderObject.cpp:
  • bindings/cpp/WebDOMHTMLDocumentCustom.cpp:
  • bindings/js/JSHTMLDocumentCustom.cpp:
  • dom/Position.cpp:
  • dom/SelectElement.cpp:
  • editing/CompositeEditCommand.cpp:
  • editing/Editor.cpp:
  • editing/HTMLInterchange.cpp:
  • editing/InsertTextCommand.cpp:
  • editing/MarkupAccumulator.cpp:
  • editing/TextIterator.cpp:
  • editing/VisibleSelection.cpp:
  • editing/htmlediting.cpp:
  • editing/htmlediting.h:
  • editing/markup.cpp:
  • html/FTPDirectoryDocument.cpp:
  • html/HTMLFormControlElement.cpp:
  • html/parser/HTMLTreeBuilder.cpp:
  • loader/appcache/ManifestParser.cpp:
  • platform/chromium/PopupMenuChromium.cpp:
  • platform/graphics/Font.h:
  • platform/graphics/FontFastPath.cpp:
  • platform/graphics/GlyphPageTreeNode.cpp:
  • platform/graphics/StringTruncator.cpp:
  • platform/graphics/mac/ComplexTextController.cpp:
  • platform/graphics/mac/ComplexTextControllerATSUI.cpp:
  • platform/graphics/wince/GraphicsContextWinCE.cpp:
  • platform/mac/PasteboardMac.mm:
  • platform/text/TextCodecICU.cpp:
  • platform/text/mac/TextCodecMac.cpp:
  • platform/text/transcoder/FontTranscoder.cpp:
  • rendering/RenderBlockLineLayout.cpp:
  • rendering/RenderFlexibleBox.cpp:
  • rendering/RenderListMarker.cpp:
  • rendering/RenderText.cpp:
  • rendering/RenderTextControl.cpp:
  • rendering/RenderTreeAsText.cpp:
  • rendering/break_lines.cpp:
  • rendering/mathml/RenderMathMLOperator.h:
  • websockets/WebSocketHandshake.cpp:
  • wml/WMLTableElement.cpp:

2011-01-29 Patrick Gansterer <paroga@webkit.org>

Reviewed by David Kilzer.

Move CharacterNames.h into WTF directory
https://bugs.webkit.org/show_bug.cgi?id=49618

  • src/ChromeClientImpl.cpp:
03:39 Changeset [77061] by commit-queue@webkit.org
  • 11 edits in trunk

2011-01-29 Dan Winship <danw@gnome.org>

Reviewed by Xan Lopez.

[GTK] Require the latest glib and libsoup, and remove conditional
support for older versions
https://bugs.webkit.org/show_bug.cgi?id=50675

  • autotools/webkit.m4: use AM_PATH_GLIB_2_0 rather than doing basically the same work by hand
  • configure.ac:

2011-01-29 Dan Winship <danw@gnome.org>

Reviewed by Xan Lopez.

[GTK] Remove HAVE_LIBSOUP_2_29_90 conditionals; we depend on
libsoup 2.33.1 now.
https://bugs.webkit.org/show_bug.cgi?id=50675

  • platform/network/soup/CookieJarSoup.cpp: (WebCore::defaultCookieJar): (WebCore::setCookies):
  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandle::prepareForURL): (WebCore::restartedCallback): (WebCore::startHttp):
  • platform/network/soup/ResourceRequestSoup.cpp: (WebCore::ResourceRequest::updateSoupMessage): (WebCore::ResourceRequest::toSoupMessage): (WebCore::ResourceRequest::updateFromSoupMessage):

2011-01-29 Dan Winship <danw@gnome.org>

Reviewed by Xan Lopez.

[GTK] Remove HAVE_LIBSOUP_2_29_90 conditionals; we depend on
libsoup 2.33.1 now.
https://bugs.webkit.org/show_bug.cgi?id=50675

  • ewk/ewk_cookies.cpp: (ewk_cookies_file_set): (ewk_cookies_policy_set): (ewk_cookies_policy_get):

2011-01-29 Dan Winship <danw@gnome.org>

Reviewed by Xan Lopez.

[GTK] Remove HAVE_LIBSOUP_2_29_90 and HAVE_GSETTINGS conditionals;
we depend on glib 2.27.4 and libsoup 2.33.1 now.
https://bugs.webkit.org/show_bug.cgi?id=50675

  • GNUmakefile.am:
  • WebCoreSupport/InspectorClientGtk.cpp: (WebKit::InspectorClient::storeSetting):
  • webkit/webkitprivate.cpp: (inspectorGSettings):
  • webkit/webkitprivate.h:
01:22 Changeset [77060] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-01-29 Adam Barth <abarth@webkit.org>

Reviewed by Daniel Bates.

XSSFilter should replace URLs with about:blank instead of the empty string
https://bugs.webkit.org/show_bug.cgi?id=53370

Using the empty string will make the URL complete to the current
document's URL, which isn't really what we want. Instead, we want to
use about:blank, which is safe.

  • html/parser/XSSFilter.cpp: (WebCore::XSSFilter::filterObjectToken): (WebCore::XSSFilter::filterEmbedToken):
01:20 Changeset [77059] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-01-29 Adam Barth <abarth@webkit.org>

Reviewed by Daniel Bates.

XSSFilter should pass xssAuditor/script-tag-addslashes*
https://bugs.webkit.org/show_bug.cgi?id=53365

We need to canonicalize strings to avoid being tricked by addslashes.

  • html/parser/XSSFilter.cpp: (WebCore::HTMLNames::isNonCanonicalCharacter):
    • This function is copied from the XSSAuditor (with some tweaks). We'll eventually remove the XSSAuditor once we've got XSSFilter working properly.

(WebCore::HTMLNames::canonicalize):
(WebCore::HTMLNames::decodeURL):
(WebCore::XSSFilter::isContainedInRequest):

01:19 Changeset [77058] by abarth@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-01-29 Adam Barth <abarth@webkit.org>

Reviewed by Daniel Bates.

XSSFilter should pass xssAuditor/script-tag-with-source-same-host.html
and xssAuditor/script-tag-post-*
https://bugs.webkit.org/show_bug.cgi?id=53364

We're supposed to allow loading same-origin resources even if they
appear as part of the request.

Also, we're supposed to look at the POST data too. :)

  • html/parser/XSSFilter.cpp: (WebCore::XSSFilter::eraseAttributeIfInjected): (WebCore::XSSFilter::isSameOriginResource):
    • Copy/paste from XSSAuditor::isSameOriginResource. We'll eventually remove the XSSAuditor version when XSSFilter is done.
  • html/parser/XSSFilter.h:
01:17 Changeset [77057] by abarth@webkit.org
  • 4 edits in trunk/Source/WebCore

2011-01-29 Adam Barth <abarth@webkit.org>

Reviewed by Daniel Bates.

XSSFilter should pass 16 of the xssAuditor/script-tag* tests
https://bugs.webkit.org/show_bug.cgi?id=53362

Turns out we need to replace the src attribute of script tags with
about:blank to avoid loading the main document URL as a script. Also,
move misplaced return statement that was triggering the console message
too often.

  • html/parser/HTMLToken.h: (WebCore::HTMLToken::appendToAttributeValue):
  • html/parser/XSSFilter.cpp: (WebCore::XSSFilter::filterScriptToken): (WebCore::XSSFilter::eraseAttributeIfInjected):
  • html/parser/XSSFilter.h:
01:11 Changeset [77056] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-01-29 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed Chromium test expectation update.

  • platform/chromium/test_expectations.txt:
00:34 Changeset [77055] by jhoneycutt@apple.com
  • 13 edits
    2 adds in trunk/Source

Downloads in WK2 on Windows should write resume data to bundle
https://bugs.webkit.org/show_bug.cgi?id=53282
<rdar://problem/8753077>

Reviewed by Alice Liu.

Source/WebCore:

  • WebCore.vcproj/WebCore.vcproj:

Added new files to project.

  • platform/network/cf/DownloadBundle.h: Added.
  • platform/network/win/DownloadBundleWin.cpp: Added.

(WebCore::DownloadBundle::magicNumber):
Moved from WebKit's WebDownload so that WebKit and WebKit2 can share
it.
(WebCore::DownloadBundle::fileExtension):
Ditto.
(WebCore::DownloadBundle::appendResumeData):
Ditto - but modified to return bool rather than HRESULT and to clean up
whitespace.
(WebCore::DownloadBundle::extractResumeData):
Ditto - modified to clean up whitespace.

Source/WebKit/win:

  • WebDownload.cpp:

(WebDownload::bundlePathForTargetPath):
Use the new WebCore::DownloadBundle function.
(WebDownload::request):

  • WebDownload.h:

Removed declarations for functions that were moved to a new location.

  • WebDownloadCFNet.cpp:

(WebDownload::initToResumeWithBundle):
Use the new WebCore::DownloadBundle function.
(WebDownload::cancelForResume):
Fix a leak of the resume data CFDataRef by using adoptCF(). Use the new
WebCore::DownloadBundle function.

Source/WebKit2:

  • WebProcess/Downloads/Download.cpp:

(WebKit::Download::decideDestinationWithSuggestedFilename):
Call didDecideDestination(), now that the destination is decided.

  • WebProcess/Downloads/Download.h:

Declare didDecideDestination(). Added member variables to hold the
destination file path and the download bundle path.
(WebKit::Download::destination):
Return the path to the final destination for this download.

  • WebProcess/Downloads/cf/DownloadCFNet.cpp:

(WebKit::Download::start):
Remove the name of an unused param.
(WebKit::Download::startWithHandle):
Ditto.
(WebKit::Download::cancel):
Tell CFNetwork not to delete the file upon failure, and tell it to
cancel the download. Copy the resume data for the download, and append
it to the download bundle. Call didCancel() with an empty
DataReference, since we have written our own resume data.
(WebKit::decideDestinationWithSuggestedObjectNameCallback):
Remove some unused param names. Removed the call to
CFURLDownloadSetDestination() - this is now handled in
Download::didDecideDestination().
(WebKit::didCreateDestinationCallback):
Report that the final destination was created, rather than the download
bundle, matching old WebKit.
(WebKit::Download::didDecideDestination):
Store the final destination and the download bundle paths, and call
CFURLDownloadSetDestination(), passing the path to the download bundle.

  • WebProcess/Downloads/curl/DownloadCurl.cpp:

(WebKit::Download::didDecideDestination):
Stubbed.

  • WebProcess/Downloads/mac/DownloadMac.mm:

(WebKit::Download::didDecideDestination):
Stubbed - unneeded on the Mac.

  • WebProcess/Downloads/qt/DownloadQt.cpp:

(WebKit::Download::didDecideDestination):
Stubbed.

00:27 Changeset [77054] by commit-queue@webkit.org
  • 9 edits in trunk/Source/WebKit2

2011-01-29 Jeff Miller <jeffm@apple.com>

Reviewed by Anders Carlsson.

Support find bouncy in WebKit2 on Windows
https://bugs.webkit.org/show_bug.cgi?id=53329
<rdar://problem/8565843>
The Mac implements the find bouncy inside of WebKit in the UI process for WebKit2, but we need to do this inside Safari for WebKit2 on Windows.
Add infrastructure to call back into the app when the find indicator changes.

  • UIProcess/API/C/win/WKView.cpp: Cleanup some code style violations. (WKViewSetFindIndicatorCallback): Added. (WKViewGetFindIndicatorCallback): Added.
  • UIProcess/API/C/win/WKView.h: Cleanup some code style violations.
  • UIProcess/FindIndicator.cpp: (WebKit::FindIndicator::create): (WebKit::FindIndicator::FindIndicator): (WebKit::FindIndicator::frameRect): (WebKit::FindIndicator::draw): Rename m_selectionRect to m_selectionRectInWindowCoordinates and m_textRects to m_textRectsInSelectionRectCoordinates (along with similarly named local variables) to be more explict about the coordinate system.
  • UIProcess/FindIndicator.h: (WebKit::FindIndicator::selectionRectInWindowCoordinates): Added. (WebKit::FindIndicator::textRects): Rename m_textRects to m_textRectsInSelectionRectCoordinates.
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::setFindIndicator): Rename selectionRect to selectionRectInWindowCoordinates and textRects to textRectsInSelectionRectCoordinates to be more explict about the coordinate system.
  • UIProcess/WebPageProxy.h: Ditto.
  • UIProcess/win/WebView.cpp: (WebKit::WebView::WebView): (WebKit::WebView::setFindIndicator): Added. (WebKit::WebView::setFindIndicatorCallback): Added. (WebKit::WebView::getFindIndicatorCallback): Added.
  • UIProcess/win/WebView.h:
00:23 Changeset [77053] by rniwa@webkit.org
  • 4 edits
    2 deletes in trunk

2011-01-29 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r77050.
http://trac.webkit.org/changeset/77050
https://bugs.webkit.org/show_bug.cgi?id=53371

Caused a crash in Chromium's test_shell_tests (Requested by
rniwa on #webkit).

  • resources/performance-test.js: Removed.
  • tiny-innerHTML.html: Removed.

2011-01-29 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r77050.
http://trac.webkit.org/changeset/77050
https://bugs.webkit.org/show_bug.cgi?id=53371

Caused a crash in Chromium's test_shell_tests (Requested by
rniwa on #webkit).

  • html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::FragmentParsingContext::FragmentParsingContext): (WebCore::HTMLTreeBuilder::FragmentParsingContext::document): (WebCore::HTMLTreeBuilder::FragmentParsingContext::finished):
  • html/parser/HTMLTreeBuilder.h:
00:13 Changeset [77052] by rniwa@webkit.org
  • 2 edits
    3 adds in trunk/LayoutTests

2011-01-29 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed rebaselines and test expectation updates for Chromium Linux.

  • platform/chromium-linux/fast/forms/select-dirty-parent-pref-widths-expected.checksum: Added.
  • platform/chromium-linux/fast/forms/select-dirty-parent-pref-widths-expected.png: Added.
  • platform/chromium-linux/fast/forms/select-dirty-parent-pref-widths-expected.txt: Added.
  • platform/chromium/test_expectations.txt:

01/28/11:

23:56 Changeset [77051] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-01-28 Alexey Proskuryakov <ap@apple.com>

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=53367
<rdar://problem/8926460> Remove dysfunctional code from -[WKPrintingView _isPrintingPreview].

  • UIProcess/API/mac/WKPrintingView.mm: (-[WKPrintingView _isPrintingPreview]): The common branch works fine for now, no need to make platforms different.
23:37 Changeset [77050] by eric@webkit.org
  • 4 edits
    2 adds in trunk

2011-01-28 Eric Seidel <eric@webkit.org>

Reviewed by Darin Adler.

HTML5 TreeBuilder regressed a Peacekeeper DOM test by 40%
https://bugs.webkit.org/show_bug.cgi?id=48719

It's unclear exactly what the Peacekeeper benchmark is testing,
because I haven't found a way to run it myself.

However, I constructed a benchmark which shows at least one possible slow point.
The HTML5 spec talks about creating a new document for every time we use
the fragment parsing algorithm. Document() it turns out, it a huge bloated
mess, and the constructor and destructor do a huge amount of work.
To avoid constructing (or destructing) documents for each innerHTML call,
this patch adds a shared dummy document used by all innerHTML calls.

  • benchmarks/parser/tiny-innerHTML.html: Added.

2011-01-28 Eric Seidel <eric@webkit.org>

Reviewed by Darin Adler.

HTML5 TreeBuilder regressed a Peacekeeper DOM test by 40%
https://bugs.webkit.org/show_bug.cgi?id=48719

It's unclear exactly what the Peacekeeper benchmark is testing,
because I haven't found a way to run it myself.

However, I constructed a benchmark which shows at least one possible slow point.
The HTML5 spec talks about creating a new document for every time we use
the fragment parsing algorithm. Document() it turns out, it a huge bloated
mess, and the constructor and destructor do a huge amount of work.
To avoid constructing (or destructing) documents for each innerHTML call,
this patch adds a shared dummy document used by all innerHTML calls.

This patch brings us from 7x slower than Safari 5 on tiny-innerHTML
to only 1.5x slower than Safari 5. I'm sure there is more work to do here.

Saving a shared Document like this is error prone. Currently
DummyDocumentFactory::releaseDocument() calls removeAllChildren()
in an attempt to clear the Document's state. However it's possible
that that call is not sufficient and we'll have future bugs here.

  • html/parser/HTMLTreeBuilder.cpp: (WebCore::DummyDocumentFactory::createDummyDocument): (WebCore::DummyDocumentFactory::releaseDocument): (WebCore::HTMLTreeBuilder::FragmentParsingContext::FragmentParsingContext): (WebCore::HTMLTreeBuilder::FragmentParsingContext::document): (WebCore::HTMLTreeBuilder::FragmentParsingContext::finished):
  • html/parser/HTMLTreeBuilder.h:
23:06 Changeset [77049] by jnd@chromium.org
  • 3 edits
    2 adds in trunk

2011-01-28 Johnny Ding <jnd@chromium.org>

Reviewed by Adam Barth.

Gesture API, disallow popup bypass with using iframe src.
https://bugs.webkit.org/show_bug.cgi?id=53244

  • fast/events/popup-blocked-from-iframe-src-expected.txt: Added.
  • fast/events/popup-blocked-from-iframe-src.html: Added.

2011-01-28 Johnny Ding <jnd@chromium.org>

Reviewed by Adam Barth.

Gesture API: Don't use current gesture status to set "forceUserGesture" parameter when calling ScriptController::executeScript.
The "forceUserGesture" parameter should be only set when you are definitely sure that the running script is from a hyper-link.
https://bugs.webkit.org/show_bug.cgi?id=53244

Test: fast/events/popup-blocked-from-iframe-src.html

  • bindings/ScriptControllerBase.cpp: (WebCore::ScriptController::executeIfJavaScriptURL):
23:00 Changeset [77048] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-01-28 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed; removed Chromium test expectations for tests that have been steadily passing.

In particular, many ietestcenter tests have been passing since V8 is updated to
version 3.0.12 in Chromium r72940.

  • platform/chromium/test_expectations.txt:
22:25 Changeset [77047] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-01-28 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed; roll WebKit Chromium revision from 72894 to 73048.

  • DEPS:
21:56 Changeset [77046] by mitz@apple.com
  • 7 edits
    2 copies in trunk/LayoutTests

Updated test results after r76983.

Rubber-stamped by Maciej Stachowiak.

  • platform/mac-leopard/fast/forms/select-writing-direction-natural-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/select-writing-direction-natural-expected.txt.
  • platform/mac-leopard/fast/text/international/bidi-menulist-expected.txt: Copied from LayoutTests/platform/mac/fast/text/international/bidi-menulist-expected.txt.
  • platform/mac/fast/forms/select-writing-direction-natural-expected.checksum:
  • platform/mac/fast/forms/select-writing-direction-natural-expected.png:
  • platform/mac/fast/forms/select-writing-direction-natural-expected.txt:
  • platform/mac/fast/text/international/bidi-menulist-expected.checksum:
  • platform/mac/fast/text/international/bidi-menulist-expected.png:
  • platform/mac/fast/text/international/bidi-menulist-expected.txt:
21:02 Changeset [77045] by simon.fraser@apple.com
  • 6 edits in trunk

2011-01-28 Simon Fraser <simon.fraser@apple.com>

Reviewed by Gavin Barraclough.

Add various clampToInt() methods to MathExtras.h
https://bugs.webkit.org/show_bug.cgi?id=52910

Use clampToInteger() from MathExtras.h

  • css/CSSParser.cpp: (WebCore::CSSParser::parseCounter):
20:06 Changeset [77044] by rniwa@webkit.org
  • 125 edits
    2 deletes in trunk/Source

2011-01-28 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r77006 and r77020.
http://trac.webkit.org/changeset/77006
http://trac.webkit.org/changeset/77020
https://bugs.webkit.org/show_bug.cgi?id=53360

"Broke Windows tests" (Requested by rniwa on #webkit).

  • API/JSCallbackObject.h: (JSC::JSCallbackObjectData::setPrivateProperty): (JSC::JSCallbackObjectData::JSPrivatePropertyMap::getPrivateProperty): (JSC::JSCallbackObjectData::JSPrivatePropertyMap::setPrivateProperty): (JSC::JSCallbackObjectData::JSPrivatePropertyMap::markChildren): (JSC::JSCallbackObject::setPrivateProperty):
  • API/JSCallbackObjectFunctions.h: (JSC::::put): (JSC::::staticFunctionGetter):
  • API/JSObjectRef.cpp: (JSObjectMakeConstructor): (JSObjectSetPrivateProperty):
  • API/JSWeakObjectMapRefInternal.h:
  • JavaScriptCore.exp:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::markAggregate):
  • bytecode/CodeBlock.h: (JSC::CodeBlock::globalObject):
  • bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::BytecodeGenerator): (JSC::BytecodeGenerator::emitJumpIfNotFunctionCall): (JSC::BytecodeGenerator::emitJumpIfNotFunctionApply): (JSC::BytecodeGenerator::findScopedProperty):
  • debugger/Debugger.cpp: (JSC::evaluateInGlobalCallFrame):
  • debugger/DebuggerActivation.cpp: (JSC::DebuggerActivation::DebuggerActivation): (JSC::DebuggerActivation::markChildren):
  • debugger/DebuggerActivation.h:
  • debugger/DebuggerCallFrame.cpp: (JSC::DebuggerCallFrame::evaluate):
  • interpreter/CallFrame.h: (JSC::ExecState::exception):
  • interpreter/Interpreter.cpp: (JSC::Interpreter::resolve): (JSC::Interpreter::resolveSkip): (JSC::Interpreter::resolveGlobal): (JSC::Interpreter::resolveGlobalDynamic): (JSC::Interpreter::resolveBaseAndProperty): (JSC::Interpreter::unwindCallFrame): (JSC::appendSourceToError): (JSC::Interpreter::execute): (JSC::Interpreter::tryCacheGetByID): (JSC::Interpreter::privateExecute):
  • jit/JITStubs.cpp: (JSC::JITThunks::tryCacheGetByID): (JSC::DEFINE_STUB_FUNCTION):
  • jsc.cpp: (GlobalObject::GlobalObject):
  • runtime/ArgList.cpp: (JSC::MarkedArgumentBuffer::markLists):
  • runtime/Arguments.cpp: (JSC::Arguments::markChildren): (JSC::Arguments::getOwnPropertySlot): (JSC::Arguments::getOwnPropertyDescriptor): (JSC::Arguments::put):
  • runtime/Arguments.h: (JSC::Arguments::setActivation): (JSC::Arguments::Arguments):
  • runtime/ArrayConstructor.cpp: (JSC::ArrayConstructor::ArrayConstructor): (JSC::constructArrayWithSizeQuirk):
  • runtime/ArrayPrototype.cpp: (JSC::arrayProtoFuncSplice):
  • runtime/BatchedTransitionOptimizer.h: (JSC::BatchedTransitionOptimizer::BatchedTransitionOptimizer): (JSC::BatchedTransitionOptimizer::~BatchedTransitionOptimizer):
  • runtime/BooleanConstructor.cpp: (JSC::BooleanConstructor::BooleanConstructor): (JSC::constructBoolean): (JSC::constructBooleanFromImmediateBoolean):
  • runtime/BooleanPrototype.cpp: (JSC::BooleanPrototype::BooleanPrototype):
  • runtime/ConservativeSet.cpp: (JSC::ConservativeSet::grow):
  • runtime/ConservativeSet.h: (JSC::ConservativeSet::~ConservativeSet): (JSC::ConservativeSet::mark):
  • runtime/DateConstructor.cpp: (JSC::DateConstructor::DateConstructor):
  • runtime/DateInstance.cpp: (JSC::DateInstance::DateInstance):
  • runtime/DatePrototype.cpp: (JSC::dateProtoFuncSetTime): (JSC::setNewValueFromTimeArgs): (JSC::setNewValueFromDateArgs): (JSC::dateProtoFuncSetYear):
  • runtime/ErrorConstructor.cpp: (JSC::ErrorConstructor::ErrorConstructor):
  • runtime/ErrorInstance.cpp: (JSC::ErrorInstance::ErrorInstance):
  • runtime/ErrorPrototype.cpp: (JSC::ErrorPrototype::ErrorPrototype):
  • runtime/FunctionConstructor.cpp: (JSC::FunctionConstructor::FunctionConstructor):
  • runtime/FunctionPrototype.cpp: (JSC::FunctionPrototype::FunctionPrototype):
  • runtime/GetterSetter.cpp: (JSC::GetterSetter::markChildren):
  • runtime/GetterSetter.h: (JSC::GetterSetter::GetterSetter): (JSC::GetterSetter::getter): (JSC::GetterSetter::setGetter): (JSC::GetterSetter::setter): (JSC::GetterSetter::setSetter):
  • runtime/GlobalEvalFunction.cpp: (JSC::GlobalEvalFunction::GlobalEvalFunction): (JSC::GlobalEvalFunction::markChildren):
  • runtime/GlobalEvalFunction.h: (JSC::GlobalEvalFunction::cachedGlobalObject):
  • runtime/Heap.cpp: (JSC::Heap::markProtectedObjects): (JSC::Heap::markTempSortVectors): (JSC::Heap::markRoots):
  • runtime/InternalFunction.cpp: (JSC::InternalFunction::InternalFunction):
  • runtime/JSAPIValueWrapper.h: (JSC::JSAPIValueWrapper::value): (JSC::JSAPIValueWrapper::JSAPIValueWrapper):
  • runtime/JSActivation.cpp: (JSC::JSActivation::markChildren): (JSC::JSActivation::put):
  • runtime/JSArray.cpp: (JSC::JSArray::JSArray): (JSC::JSArray::getOwnPropertySlot): (JSC::JSArray::getOwnPropertyDescriptor): (JSC::JSArray::put): (JSC::JSArray::putSlowCase): (JSC::JSArray::deleteProperty): (JSC::JSArray::increaseVectorLength): (JSC::JSArray::setLength): (JSC::JSArray::pop): (JSC::JSArray::push): (JSC::JSArray::unshiftCount): (JSC::JSArray::sort): (JSC::JSArray::fillArgList): (JSC::JSArray::copyToRegisters): (JSC::JSArray::compactForSorting):
  • runtime/JSArray.h: (JSC::JSArray::getIndex): (JSC::JSArray::setIndex): (JSC::JSArray::uncheckedSetIndex): (JSC::JSArray::markChildrenDirect):
  • runtime/JSByteArray.cpp: (JSC::JSByteArray::JSByteArray):
  • runtime/JSCell.h: (JSC::JSCell::JSValue::toThisObject): (JSC::JSCell::MarkStack::append):
  • runtime/JSFunction.cpp: (JSC::JSFunction::JSFunction): (JSC::JSFunction::getOwnPropertySlot):
  • runtime/JSGlobalData.h:
  • runtime/JSGlobalObject.cpp: (JSC::markIfNeeded): (JSC::JSGlobalObject::reset): (JSC::JSGlobalObject::resetPrototype): (JSC::JSGlobalObject::markChildren):
  • runtime/JSGlobalObject.h: (JSC::JSGlobalObject::JSGlobalObjectData::JSGlobalObjectData): (JSC::JSGlobalObject::regExpConstructor): (JSC::JSGlobalObject::errorConstructor): (JSC::JSGlobalObject::evalErrorConstructor): (JSC::JSGlobalObject::rangeErrorConstructor): (JSC::JSGlobalObject::referenceErrorConstructor): (JSC::JSGlobalObject::syntaxErrorConstructor): (JSC::JSGlobalObject::typeErrorConstructor): (JSC::JSGlobalObject::URIErrorConstructor): (JSC::JSGlobalObject::evalFunction): (JSC::JSGlobalObject::objectPrototype): (JSC::JSGlobalObject::functionPrototype): (JSC::JSGlobalObject::arrayPrototype): (JSC::JSGlobalObject::booleanPrototype): (JSC::JSGlobalObject::stringPrototype): (JSC::JSGlobalObject::numberPrototype): (JSC::JSGlobalObject::datePrototype): (JSC::JSGlobalObject::regExpPrototype): (JSC::JSGlobalObject::methodCallDummy): (JSC::Structure::prototypeForLookup): (JSC::constructArray):
  • runtime/JSONObject.cpp: (JSC::Stringifier::Holder::object): (JSC::Stringifier::markAggregate): (JSC::Stringifier::stringify): (JSC::Stringifier::Holder::appendNextProperty): (JSC::Walker::callReviver): (JSC::Walker::walk):
  • runtime/JSObject.cpp: (JSC::JSObject::defineGetter): (JSC::JSObject::defineSetter): (JSC::JSObject::removeDirect): (JSC::JSObject::putDirectFunction): (JSC::JSObject::putDirectFunctionWithoutTransition): (JSC::putDescriptor): (JSC::JSObject::defineOwnProperty):
  • runtime/JSObject.h: (JSC::JSObject::getDirectOffset): (JSC::JSObject::putDirectOffset): (JSC::JSObject::flattenDictionaryObject): (JSC::JSObject::putDirectInternal): (JSC::JSObject::putDirect): (JSC::JSObject::putDirectFunction): (JSC::JSObject::putDirectWithoutTransition): (JSC::JSObject::putDirectFunctionWithoutTransition): (JSC::JSValue::putDirect): (JSC::JSObject::allocatePropertyStorageInline): (JSC::JSObject::markChildrenDirect):
  • runtime/JSPropertyNameIterator.cpp: (JSC::JSPropertyNameIterator::JSPropertyNameIterator): (JSC::JSPropertyNameIterator::get):
  • runtime/JSPropertyNameIterator.h:
  • runtime/JSStaticScopeObject.cpp: (JSC::JSStaticScopeObject::markChildren):
  • runtime/JSString.cpp: (JSC::StringObject::create):
  • runtime/JSValue.h:
  • runtime/JSWrapperObject.cpp: (JSC::JSWrapperObject::markChildren):
  • runtime/JSWrapperObject.h: (JSC::JSWrapperObject::internalValue): (JSC::JSWrapperObject::setInternalValue):
  • runtime/LiteralParser.cpp: (JSC::LiteralParser::parse):
  • runtime/Lookup.cpp: (JSC::setUpStaticFunctionSlot):
  • runtime/Lookup.h: (JSC::lookupPut):
  • runtime/MarkStack.h: (JSC::MarkStack::appendValues):
  • runtime/MathObject.cpp: (JSC::MathObject::MathObject):
  • runtime/NativeErrorConstructor.cpp: (JSC::NativeErrorConstructor::NativeErrorConstructor):
  • runtime/NativeErrorPrototype.cpp: (JSC::NativeErrorPrototype::NativeErrorPrototype):
  • runtime/NumberConstructor.cpp: (JSC::NumberConstructor::NumberConstructor): (JSC::constructWithNumberConstructor):
  • runtime/NumberObject.cpp: (JSC::constructNumber):
  • runtime/NumberPrototype.cpp: (JSC::NumberPrototype::NumberPrototype):
  • runtime/ObjectConstructor.cpp: (JSC::ObjectConstructor::ObjectConstructor): (JSC::objectConstructorGetOwnPropertyDescriptor):
  • runtime/Operations.h: (JSC::normalizePrototypeChain): (JSC::resolveBase):
  • runtime/PrototypeFunction.cpp: (JSC::PrototypeFunction::PrototypeFunction):
  • runtime/PutPropertySlot.h: (JSC::PutPropertySlot::setExistingProperty): (JSC::PutPropertySlot::setNewProperty): (JSC::PutPropertySlot::base):
  • runtime/RegExpConstructor.cpp: (JSC::RegExpConstructor::RegExpConstructor):
  • runtime/ScopeChain.cpp: (JSC::ScopeChainNode::print):
  • runtime/ScopeChain.h: (JSC::ScopeChainNode::~ScopeChainNode): (JSC::ScopeChainIterator::operator*): (JSC::ScopeChainIterator::operator->): (JSC::ScopeChain::top):
  • runtime/ScopeChainMark.h: (JSC::ScopeChain::markAggregate):
  • runtime/SmallStrings.cpp: (JSC::isMarked): (JSC::SmallStrings::markChildren):
  • runtime/SmallStrings.h: (JSC::SmallStrings::emptyString): (JSC::SmallStrings::singleCharacterString): (JSC::SmallStrings::singleCharacterStrings):
  • runtime/StringConstructor.cpp: (JSC::StringConstructor::StringConstructor):
  • runtime/StringObject.cpp: (JSC::StringObject::StringObject):
  • runtime/StringObject.h:
  • runtime/StringPrototype.cpp: (JSC::StringPrototype::StringPrototype):
  • runtime/Structure.cpp: (JSC::Structure::Structure): (JSC::Structure::addPropertyTransition): (JSC::Structure::toDictionaryTransition): (JSC::Structure::flattenDictionaryStructure):
  • runtime/Structure.h: (JSC::Structure::storedPrototype):
  • runtime/WeakGCMap.h: (JSC::WeakGCMap::uncheckedGet): (JSC::WeakGCMap::isValid): (JSC::::get): (JSC::::take): (JSC::::set): (JSC::::uncheckedRemove):
  • runtime/WriteBarrier.h: Removed.

2011-01-28 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r77006 and r77020.
http://trac.webkit.org/changeset/77006
http://trac.webkit.org/changeset/77020
https://bugs.webkit.org/show_bug.cgi?id=53360

"Broke Windows tests" (Requested by rniwa on #webkit).

  • JSValueWrapper.cpp: (JSValueWrapper::JSObjectMark):

2011-01-28 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r77006 and r77020.
http://trac.webkit.org/changeset/77006
http://trac.webkit.org/changeset/77020
https://bugs.webkit.org/show_bug.cgi?id=53360

"Broke Windows tests" (Requested by rniwa on #webkit).

  • WebView/WebScriptDebugDelegate.mm: (-[WebScriptCallFrame scopeChain]):

2011-01-28 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r77006 and r77020.
http://trac.webkit.org/changeset/77006
http://trac.webkit.org/changeset/77020
https://bugs.webkit.org/show_bug.cgi?id=53360

"Broke Windows tests" (Requested by rniwa on #webkit).

  • ForwardingHeaders/runtime/WriteBarrier.h: Removed.
  • WebCore.exp.in:
  • bindings/js/DOMWrapperWorld.h:
  • bindings/js/JSAudioConstructor.cpp: (WebCore::JSAudioConstructor::JSAudioConstructor):
  • bindings/js/JSDOMBinding.cpp: (WebCore::markDOMNodesForDocument): (WebCore::markDOMObjectWrapper): (WebCore::markDOMNodeWrapper):
  • bindings/js/JSDOMGlobalObject.cpp: (WebCore::JSDOMGlobalObject::markChildren): (WebCore::JSDOMGlobalObject::setInjectedScript): (WebCore::JSDOMGlobalObject::injectedScript):
  • bindings/js/JSDOMGlobalObject.h: (WebCore::JSDOMGlobalObject::JSDOMGlobalObjectData::JSDOMGlobalObjectData): (WebCore::getDOMConstructor):
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::setLocation): (WebCore::DialogHandler::dialogCreated):
  • bindings/js/JSDOMWindowShell.cpp: (WebCore::JSDOMWindowShell::JSDOMWindowShell): (WebCore::JSDOMWindowShell::setWindow): (WebCore::JSDOMWindowShell::markChildren): (WebCore::JSDOMWindowShell::unwrappedObject):
  • bindings/js/JSDOMWindowShell.h: (WebCore::JSDOMWindowShell::window): (WebCore::JSDOMWindowShell::setWindow):
  • bindings/js/JSDeviceMotionEventCustom.cpp: (WebCore::createAccelerationObject): (WebCore::createRotationRateObject):
  • bindings/js/JSEventListener.cpp: (WebCore::JSEventListener::JSEventListener): (WebCore::JSEventListener::markJSFunction):
  • bindings/js/JSEventListener.h: (WebCore::JSEventListener::jsFunction):
  • bindings/js/JSHTMLDocumentCustom.cpp: (WebCore::JSHTMLDocument::setAll):
  • bindings/js/JSImageConstructor.cpp: (WebCore::JSImageConstructor::JSImageConstructor):
  • bindings/js/JSImageDataCustom.cpp: (WebCore::toJS):
  • bindings/js/JSJavaScriptCallFrameCustom.cpp: (WebCore::JSJavaScriptCallFrame::scopeChain): (WebCore::JSJavaScriptCallFrame::scopeType):
  • bindings/js/JSNodeFilterCondition.cpp: (WebCore::JSNodeFilterCondition::markAggregate): (WebCore::JSNodeFilterCondition::acceptNode):
  • bindings/js/JSNodeFilterCondition.h:
  • bindings/js/JSNodeFilterCustom.cpp:
  • bindings/js/JSOptionConstructor.cpp: (WebCore::JSOptionConstructor::JSOptionConstructor):
  • bindings/js/JSSQLResultSetRowListCustom.cpp: (WebCore::JSSQLResultSetRowList::item):
  • bindings/js/ScriptCachedFrameData.cpp: (WebCore::ScriptCachedFrameData::restore):
  • bindings/js/ScriptObject.cpp: (WebCore::ScriptGlobalObject::set):
  • bindings/js/SerializedScriptValue.cpp: (WebCore::CloneDeserializer::putProperty):
  • bindings/scripts/CodeGeneratorJS.pm:
  • bridge/qt/qt_runtime.cpp: (JSC::Bindings::QtRuntimeMetaMethod::QtRuntimeMetaMethod): (JSC::Bindings::QtRuntimeMetaMethod::markChildren): (JSC::Bindings::QtRuntimeMetaMethod::connectGetter): (JSC::Bindings::QtRuntimeMetaMethod::disconnectGetter):
  • bridge/qt/qt_runtime.h:
  • bridge/runtime_root.cpp: (JSC::Bindings::RootObject::invalidate):
  • bridge/runtime_root.h:
  • dom/Document.h:
19:45 Changeset [77043] by mjs@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-01-28 Maciej Stachowiak <mjs@apple.com>

Reviewed by Dan Bernstein.

WKPageGetEstimatedProgress returns wrong value after a mainframe provisional load has started
https://bugs.webkit.org/show_bug.cgi?id=53358

  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didStartProgress): Start progress at the magic initial value, not 0.
18:25 Changeset [77042] by mjs@apple.com
  • 8 edits in trunk

2011-01-28 Maciej Stachowiak <mjs@apple.com>

Reviewed by Darin Adler.

WebKitTestRunner needs layoutTestController.setPOSIXLocale
https://bugs.webkit.org/show_bug.cgi?id=42682

  • platform/mac-wk2/Skipped:

2011-01-28 Maciej Stachowiak <mjs@apple.com>

Reviewed by Darin Adler.

WebKitTestRunner needs layoutTestController.setPOSIXLocale
https://bugs.webkit.org/show_bug.cgi?id=42682

  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::resetLocalSettings): (WTR::InjectedBundle::didReceiveMessage):
  • WebKitTestRunner/InjectedBundle/InjectedBundle.h:
  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::setPOSIXLocale):
  • WebKitTestRunner/InjectedBundle/LayoutTestController.h:
18:08 Changeset [77041] by abarth@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-01-28 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

XSSFilter should log to the console when it blocks something
https://bugs.webkit.org/show_bug.cgi?id=53354

This patch refactors a bunch of methods in XSSFilter to return a bool
indicating whether they blocked anything. Using this bool, we decide
whether to log to the console. We're using the same log message as the
XSSAuditor, but it seems likely we can improve this message in the
future (especially by piping in the correct line number, which is now
accessible via the parser).

  • html/parser/XSSFilter.cpp: (WebCore::HTMLNames::isNameOfInlineEventHandler): (WebCore::XSSFilter::filterToken): (WebCore::XSSFilter::filterTokenInitial): (WebCore::XSSFilter::filterTokenAfterScriptStartTag): (WebCore::XSSFilter::filterScriptToken): (WebCore::XSSFilter::filterObjectToken): (WebCore::XSSFilter::filterEmbedToken): (WebCore::XSSFilter::filterAppletToken): (WebCore::XSSFilter::filterMetaToken): (WebCore::XSSFilter::filterBaseToken): (WebCore::XSSFilter::eraseInlineEventHandlersIfInjected):
  • html/parser/XSSFilter.h:
18:08 Changeset [77040] by mrowe@apple.com
  • 5 edits in branches/safari-533.20-branch

Merge r72046.

18:08 Changeset [77039] by dpranke@chromium.org
  • 2 edits in trunk/Tools

2011-01-28 Dirk Pranke <dpranke@chromium.org>

Reviewed by Mihai Parparita.

test-webkitpy: fix webkitpy.layout_tests.port.mac_unittest.MacTest.test_skipped_file_paths

This patch re-enables this test and changes it to
handle all of the mac platform versions, not just the one
it is running on.

https://bugs.webkit.org/show_bug.cgi?id=53356

  • Scripts/webkitpy/layout_tests/port/mac_unittest.py:
17:41 Changeset [77038] by dpranke@chromium.org
  • 2 edits in trunk/Tools

2011-01-28 Dirk Pranke <dpranke@chromium.org>

Unreviewed, build fix.

Take two. The fix in 77023 didn't work, because we were
still calling path.abspath_to_uri, which calls _cygpath under
the covers, and it appears the cygpath on the bots does
something different than it does on my machine. This patch
removes the calls to path.abspath_to_uri, so it should be safe.
If it doesn't work, I'll roll it out along with r76982 and 77023.

https://bugs.webkit.org/show_bug.cgi?id=53126

  • Scripts/webkitpy/layout_tests/port/test.py:
17:25 Changeset [77037] by mrowe@apple.com
  • 4 edits
    2 adds in branches/safari-533.20-branch

Merge r76828.

17:12 Changeset [77036] by mrowe@apple.com
  • 3 edits
    6 adds in branches/safari-533.20-branch

Merge r71182.

17:07 Changeset [77035] by mrowe@apple.com
  • 5 edits
    2 adds in branches/safari-533.20-branch

Merge r74574.

16:58 Changeset [77034] by abarth@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-01-28 Adam Barth <abarth@webkit.org>

Reviewed by Daniel Bates.

Wire up settings->xssAuditorEnabled to XSSFilter
https://bugs.webkit.org/show_bug.cgi?id=53345

  • html/parser/XSSFilter.cpp: (WebCore::XSSFilter::XSSFilter): (WebCore::XSSFilter::filterToken):
  • html/parser/XSSFilter.h:
16:57 Changeset [77033] by abarth@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-01-28 Adam Barth <abarth@webkit.org>

Reviewed by Daniel Bates.

Teach XSSFilter about <meta> and <base> tags
https://bugs.webkit.org/show_bug.cgi?id=53339

I'm not 100% sure we need to block <meta http-equiv>, but it seems
prudent given how powerful that attribute is. We definitely need to
block injection of <base href> because that can redirect script tags
that use relative URLs.

  • html/parser/XSSFilter.cpp: (WebCore::XSSFilter::filterToken): (WebCore::XSSFilter::filterMetaToken): (WebCore::XSSFilter::filterBaseToken):
  • html/parser/XSSFilter.h:
16:55 Changeset [77032] by abarth@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-01-28 Adam Barth <abarth@webkit.org>

Reviewed by Daniel Bates.

Teach XSSFilter about <applet>
https://bugs.webkit.org/show_bug.cgi?id=53338

HTML5 is pretty light on information about how the <applet> tag works.
According to this site:

http://download.oracle.com/javase/1.4.2/docs/guide/misc/applet.html

The "code" and "object" attributes are the essential attributes for
determining which piece of Java to run. We might need to expand to the
codebase and archive attributes at some point, but hopefully code and
object will be sufficient.

  • html/parser/XSSFilter.cpp: (WebCore::XSSFilter::filterToken): (WebCore::XSSFilter::filterAppletToken):
  • html/parser/XSSFilter.h:
16:53 Changeset [77031] by abarth@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-01-28 Adam Barth <abarth@webkit.org>

Reviewed by Daniel Bates.

Teach the XSSFilter about object and embed tags
https://bugs.webkit.org/show_bug.cgi?id=53336

For <object> and <embed>, we filter out attribute values that either
indicate which piece of media to load or which plugin to load. In a
perfect world, we'd only need to filter out the URLs of the media, but
some plug-ins (like Flash) have lots of fun places you can hide the
URL (e.g., the "movie" <param>).

  • html/parser/XSSFilter.cpp: (WebCore::XSSFilter::filterToken): (WebCore::XSSFilter::filterScriptToken): (WebCore::XSSFilter::filterObjectToken): (WebCore::XSSFilter::filterEmbedToken): (WebCore::XSSFilter::eraseAttributeIfInjected):
  • html/parser/XSSFilter.h:
16:53 Changeset [77030] by ddkilzer@apple.com
  • 1 edit in trunk/Tools/ChangeLog

Added link to bug in ChangeLog.

16:50 Changeset [77029] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Yet another build fix (What was I thinking?)

  • WebProcess/Downloads/Download.h:
  • WebProcess/Plugins/PluginProxy.h:
16:46 Changeset [77028] by ddkilzer@apple.com
  • 2 edits in trunk/Tools

<rdar://problem/8930699> build-webkit gives a bogus warning with newer versions of Xcode

Reviewed by Mark Rowe.

  • Scripts/webkitdirs.pm:

(checkRequiredSystemConfig): Check the Xcode marketing version
in addition to the DevCoreTools build version before complaining
about an old version of Xcode. Also make the Mac OS X version
check use Perl's built-in version string comparitor.

16:39 Changeset [77027] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-01-28 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed; Fixed Chromium test expectation.

  • platform/chromium/test_expectations.txt:
16:35 Changeset [77026] by andersca@apple.com
  • 4 edits in trunk/WebKitLibraries

Build fix.

Update WKSI.

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
16:35 Changeset [77025] by barraclough@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

https://bugs.webkit.org/show_bug.cgi?id=53352
Heavy external fragmentation in FixedVMPoolAllocator can lead to a CRASH().

Reviewed by Geoff Garen.

The FixedVMPoolAllocator currently uses a best fix policy -
switch to first fit, this is less prone to external fragmentation.

  • jit/ExecutableAllocatorFixedVMPool.cpp:

(JSC::AllocationTableSizeClass::AllocationTableSizeClass):
(JSC::AllocationTableSizeClass::blockSize):
(JSC::AllocationTableSizeClass::blockCount):
(JSC::AllocationTableSizeClass::blockAlignment):
(JSC::AllocationTableSizeClass::size):
(JSC::AllocationTableLeaf::AllocationTableLeaf):
(JSC::AllocationTableLeaf::~AllocationTableLeaf):
(JSC::AllocationTableLeaf::allocate):
(JSC::AllocationTableLeaf::free):
(JSC::AllocationTableLeaf::isEmpty):
(JSC::AllocationTableLeaf::isFull):
(JSC::AllocationTableLeaf::size):
(JSC::AllocationTableLeaf::classForSize):
(JSC::AllocationTableLeaf::dump):
(JSC::LazyAllocationTable::LazyAllocationTable):
(JSC::LazyAllocationTable::~LazyAllocationTable):
(JSC::LazyAllocationTable::allocate):
(JSC::LazyAllocationTable::free):
(JSC::LazyAllocationTable::isEmpty):
(JSC::LazyAllocationTable::isFull):
(JSC::LazyAllocationTable::size):
(JSC::LazyAllocationTable::dump):
(JSC::LazyAllocationTable::classForSize):
(JSC::AllocationTableDirectory::AllocationTableDirectory):
(JSC::AllocationTableDirectory::~AllocationTableDirectory):
(JSC::AllocationTableDirectory::allocate):
(JSC::AllocationTableDirectory::free):
(JSC::AllocationTableDirectory::isEmpty):
(JSC::AllocationTableDirectory::isFull):
(JSC::AllocationTableDirectory::size):
(JSC::AllocationTableDirectory::classForSize):
(JSC::AllocationTableDirectory::dump):
(JSC::FixedVMPoolAllocator::FixedVMPoolAllocator):
(JSC::FixedVMPoolAllocator::alloc):
(JSC::FixedVMPoolAllocator::free):
(JSC::FixedVMPoolAllocator::allocated):
(JSC::FixedVMPoolAllocator::isValid):
(JSC::FixedVMPoolAllocator::classForSize):
(JSC::FixedVMPoolAllocator::offsetToPointer):
(JSC::FixedVMPoolAllocator::pointerToOffset):
(JSC::ExecutableAllocator::committedByteCount):
(JSC::ExecutableAllocator::isValid):
(JSC::ExecutableAllocator::underMemoryPressure):
(JSC::ExecutablePool::systemAlloc):
(JSC::ExecutablePool::systemRelease):

  • wtf/PageReservation.h:

(WTF::PageReservation::PageReservation):
(WTF::PageReservation::commit):
(WTF::PageReservation::decommit):
(WTF::PageReservation::committed):

16:33 Changeset [77024] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix Windows build.

  • Shared/PrintInfo.h:
16:32 Changeset [77023] by dpranke@chromium.org
  • 2 edits in trunk/Tools

2011-01-28 Dirk Pranke <dpranke@chromium.org>

Unreviewed, build fix.

Work around breakage on Win 7 Release bot caused by r76982
and the fact that windows ports use "file:////" instead of
"file:///". Ideally the test code should be isolated from
this, but it isn't yet. Will fix properly in a bit.

  • Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
16:30 Changeset [77022] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533.20-branch

Merge r71642.

16:30 Changeset [77021] by jberlin@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

[Windows 7 Release Tests] fast/repaint/select-option-background-color.html failing since
introduction in r76826.
https://bugs.webkit.org/show_bug.cgi?id=53327

Add the pixel-test results missing from http://trac.webkit.org/changeset/76976. Unreviewed.

  • platform/win/fast/repaint/select-option-background-color-expected.checksum: Added.
  • platform/win/fast/repaint/select-option-background-color-expected.png: Added.
16:29 Changeset [77020] by oliver@apple.com
  • 3 edits in trunk/Source/WebCore

Fixed Qt build.

16:23 Changeset [77019] by antti@apple.com
  • 2 edits in trunk/Source/WebCore

CSS styles are shared based on uninitialized property values
https://bugs.webkit.org/show_bug.cgi?id=53285

Reviewed by Simon Fraser.

Null test.

  • dom/NamedNodeMap.cpp:

(WebCore::NamedNodeMap::mappedMapsEquivalent):

16:22 Changeset [77018] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533.20-branch

Merge r68860.

16:20 Changeset [77017] by mrowe@apple.com
  • 4 edits
    2 adds in branches/safari-533.20-branch

Merge r70681.

16:15 Changeset [77016] by mrowe@apple.com
  • 4 edits
    2 adds in branches/safari-533.20-branch

Merge r69345.

16:12 Changeset [77015] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533.20-branch

Merge r69735.

16:12 Changeset [77014] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-01-28 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed Chromium test expectation update.

  • platform/chromium/test_expectations.txt:
16:08 Changeset [77013] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix tyop.

  • Shared/mac/CoreAnimationRenderer.mm:
16:06 Changeset [77012] by andersca@apple.com
  • 2 edits
    2 adds in trunk/Source/WebKit2

2011-01-28 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Add CoreAnimationRenderer class
https://bugs.webkit.org/show_bug.cgi?id=53343

  • Shared/mac/CoreAnimationRenderer.h: Added.
  • Shared/mac/CoreAnimationRenderer.mm: Added.

(WebKit::CoreAnimationRenderer::CoreAnimationRenderer):
Initialize the underlying CARenderer object and hook up a notification observer.

(WebKit::CoreAnimationRenderer::~CoreAnimationRenderer):
Assert that the client is null. It has been set to null by the call to invalidate().

(WebKit::CoreAnimationRenderer::setBounds):
Update the bounds on the CARenderer and the root layer.

(WebKit::CoreAnimationRenderer::render):
Ask the renderer to render and return the next frame time.

(WebKit::CoreAnimationRenderer::invalidate):
Remove the change observer and reset the client.

(WebKit::CoreAnimationRenderer::rendererDidChange):
Call the client member function.

  • WebKit2.xcodeproj/project.pbxproj: Add new files.
16:02 Changeset [77011] by mrowe@apple.com
  • 3 edits
    4 adds in branches/safari-533.20-branch

Merge r69476.

15:59 Changeset [77010] by mrowe@apple.com
  • 5 edits
    2 adds in branches/safari-533.20-branch

Merge r68819.

15:52 Changeset [77009] by mrowe@apple.com
  • 8 edits
    4 adds in branches/safari-533.20-branch

Merge r70797.

15:44 Changeset [77008] by mrowe@apple.com
  • 7 edits
    2 adds in branches/safari-533.20-branch

Merge r73432.

15:42 Changeset [77007] by andersca@apple.com
  • 13 edits in trunk/Source/WebKit2

2011-01-28 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Add an OBJC_CLASS macro for forward declaring an Objective-C class
https://bugs.webkit.org/show_bug.cgi?id=53337

  • Shared/NativeWebKeyboardEvent.h:
  • Shared/PrintInfo.h:
  • UIProcess/ChunkedUpdateDrawingAreaProxy.h:
  • UIProcess/LayerBackedDrawingAreaProxy.h:
  • UIProcess/WebInspectorProxy.h:
  • UIProcess/mac/WebContextMenuProxyMac.h:
  • UIProcess/mac/WebPopupMenuProxyMac.h:
  • WebProcess/Downloads/Download.h:
  • WebProcess/Plugins/PluginProxy.h:
  • WebProcess/WebPage/LayerBackedDrawingArea.h:
  • WebProcess/WebPage/WebPage.h:
  • config.h:
15:39 Changeset [77006] by oliver@apple.com
  • 123 edits
    2 adds in trunk/Source

2011-01-27 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

Convert markstack to a slot visitor API
https://bugs.webkit.org/show_bug.cgi?id=53219

Move the MarkStack over to a slot based marking API.

In order to avoiding aliasing concerns there are two new types
that need to be used when holding on to JSValues and JSCell that
need to be marked: WriteBarrier and DeprecatedPtr. WriteBarrier
is expected to be used for any JSValue or Cell that's lifetime and
marking is controlled by another GC object. DeprecatedPtr is used
for any value that we need to rework ownership for.

The change over to this model has produced a large amount of
code changes, but they are mostly mechanical (forwarding JSGlobalData,
etc).

  • API/JSCallbackObject.h: (JSC::JSCallbackObjectData::setPrivateProperty): (JSC::JSCallbackObjectData::JSPrivatePropertyMap::getPrivateProperty): (JSC::JSCallbackObjectData::JSPrivatePropertyMap::setPrivateProperty): (JSC::JSCallbackObjectData::JSPrivatePropertyMap::markChildren): (JSC::JSCallbackObject::setPrivateProperty):
  • API/JSCallbackObjectFunctions.h: (JSC::::put): (JSC::::staticFunctionGetter):
  • API/JSObjectRef.cpp: (JSObjectMakeConstructor): (JSObjectSetPrivateProperty):
  • API/JSWeakObjectMapRefInternal.h:
  • JavaScriptCore.exp:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::markAggregate):
  • bytecode/CodeBlock.h: (JSC::CodeBlock::globalObject):
  • bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::BytecodeGenerator): (JSC::BytecodeGenerator::emitJumpIfNotFunctionCall): (JSC::BytecodeGenerator::emitJumpIfNotFunctionApply): (JSC::BytecodeGenerator::findScopedProperty):
  • debugger/DebuggerActivation.cpp: (JSC::DebuggerActivation::DebuggerActivation): (JSC::DebuggerActivation::markChildren):
  • debugger/DebuggerActivation.h:
  • interpreter/Interpreter.cpp: (JSC::Interpreter::resolve): (JSC::Interpreter::resolveSkip): (JSC::Interpreter::resolveGlobalDynamic): (JSC::Interpreter::resolveBaseAndProperty): (JSC::Interpreter::unwindCallFrame): (JSC::appendSourceToError): (JSC::Interpreter::execute): (JSC::Interpreter::privateExecute):
  • interpreter/Register.h: (JSC::Register::jsValueSlot):
  • jit/JITStubs.cpp: (JSC::JITThunks::tryCacheGetByID): (JSC::DEFINE_STUB_FUNCTION):
  • jsc.cpp: (GlobalObject::GlobalObject):
  • runtime/Arguments.cpp: (JSC::Arguments::markChildren): (JSC::Arguments::getOwnPropertySlot): (JSC::Arguments::getOwnPropertyDescriptor): (JSC::Arguments::put):
  • runtime/Arguments.h: (JSC::Arguments::setActivation): (JSC::Arguments::Arguments):
  • runtime/ArrayConstructor.cpp: (JSC::ArrayConstructor::ArrayConstructor): (JSC::constructArrayWithSizeQuirk):
  • runtime/ArrayPrototype.cpp: (JSC::arrayProtoFuncSplice):
  • runtime/BatchedTransitionOptimizer.h: (JSC::BatchedTransitionOptimizer::BatchedTransitionOptimizer): (JSC::BatchedTransitionOptimizer::~BatchedTransitionOptimizer):
  • runtime/BooleanConstructor.cpp: (JSC::BooleanConstructor::BooleanConstructor): (JSC::constructBoolean): (JSC::constructBooleanFromImmediateBoolean):
  • runtime/BooleanPrototype.cpp: (JSC::BooleanPrototype::BooleanPrototype):
  • runtime/ConservativeSet.h: (JSC::ConservativeSet::mark):
  • runtime/DateConstructor.cpp: (JSC::DateConstructor::DateConstructor):
  • runtime/DateInstance.cpp: (JSC::DateInstance::DateInstance):
  • runtime/DatePrototype.cpp: (JSC::dateProtoFuncSetTime): (JSC::setNewValueFromTimeArgs): (JSC::setNewValueFromDateArgs): (JSC::dateProtoFuncSetYear):
  • runtime/ErrorConstructor.cpp: (JSC::ErrorConstructor::ErrorConstructor):
  • runtime/ErrorInstance.cpp: (JSC::ErrorInstance::ErrorInstance):
  • runtime/ErrorPrototype.cpp: (JSC::ErrorPrototype::ErrorPrototype):
  • runtime/FunctionConstructor.cpp: (JSC::FunctionConstructor::FunctionConstructor):
  • runtime/FunctionPrototype.cpp: (JSC::FunctionPrototype::FunctionPrototype):
  • runtime/GetterSetter.cpp: (JSC::GetterSetter::markChildren):
  • runtime/GetterSetter.h: (JSC::GetterSetter::GetterSetter): (JSC::GetterSetter::getter): (JSC::GetterSetter::setGetter): (JSC::GetterSetter::setter): (JSC::GetterSetter::setSetter):
  • runtime/GlobalEvalFunction.cpp: (JSC::GlobalEvalFunction::GlobalEvalFunction): (JSC::GlobalEvalFunction::markChildren):
  • runtime/GlobalEvalFunction.h: (JSC::GlobalEvalFunction::cachedGlobalObject):
  • runtime/Heap.cpp: (JSC::Heap::markProtectedObjects): (JSC::Heap::markTempSortVectors): (JSC::Heap::markRoots):
  • runtime/InternalFunction.cpp: (JSC::InternalFunction::InternalFunction):
  • runtime/JSAPIValueWrapper.h: (JSC::JSAPIValueWrapper::value): (JSC::JSAPIValueWrapper::JSAPIValueWrapper):
  • runtime/JSActivation.cpp: (JSC::JSActivation::put):
  • runtime/JSArray.cpp: (JSC::JSArray::JSArray): (JSC::JSArray::getOwnPropertySlot): (JSC::JSArray::getOwnPropertyDescriptor): (JSC::JSArray::put): (JSC::JSArray::putSlowCase): (JSC::JSArray::deleteProperty): (JSC::JSArray::increaseVectorLength): (JSC::JSArray::setLength): (JSC::JSArray::pop): (JSC::JSArray::push): (JSC::JSArray::unshiftCount): (JSC::JSArray::sort): (JSC::JSArray::fillArgList): (JSC::JSArray::copyToRegisters): (JSC::JSArray::compactForSorting):
  • runtime/JSArray.h: (JSC::JSArray::getIndex): (JSC::JSArray::setIndex): (JSC::JSArray::uncheckedSetIndex): (JSC::JSArray::markChildrenDirect):
  • runtime/JSByteArray.cpp: (JSC::JSByteArray::JSByteArray):
  • runtime/JSCell.h: (JSC::JSCell::MarkStack::append): (JSC::JSCell::MarkStack::appendCell):
  • runtime/JSFunction.cpp: (JSC::JSFunction::JSFunction): (JSC::JSFunction::getOwnPropertySlot):
  • runtime/JSGlobalObject.cpp: (JSC::markIfNeeded): (JSC::JSGlobalObject::reset): (JSC::JSGlobalObject::resetPrototype): (JSC::JSGlobalObject::markChildren):
  • runtime/JSGlobalObject.h: (JSC::JSGlobalObject::JSGlobalObjectData::JSGlobalObjectData): (JSC::JSGlobalObject::regExpConstructor): (JSC::JSGlobalObject::errorConstructor): (JSC::JSGlobalObject::evalErrorConstructor): (JSC::JSGlobalObject::rangeErrorConstructor): (JSC::JSGlobalObject::referenceErrorConstructor): (JSC::JSGlobalObject::syntaxErrorConstructor): (JSC::JSGlobalObject::typeErrorConstructor): (JSC::JSGlobalObject::URIErrorConstructor): (JSC::JSGlobalObject::evalFunction): (JSC::JSGlobalObject::objectPrototype): (JSC::JSGlobalObject::functionPrototype): (JSC::JSGlobalObject::arrayPrototype): (JSC::JSGlobalObject::booleanPrototype): (JSC::JSGlobalObject::stringPrototype): (JSC::JSGlobalObject::numberPrototype): (JSC::JSGlobalObject::datePrototype): (JSC::JSGlobalObject::regExpPrototype): (JSC::JSGlobalObject::methodCallDummy): (JSC::constructArray):
  • runtime/JSONObject.cpp: (JSC::Stringifier::Holder::object): (JSC::Stringifier::Holder::objectSlot): (JSC::Stringifier::markAggregate): (JSC::Stringifier::stringify): (JSC::Stringifier::Holder::appendNextProperty): (JSC::Walker::callReviver): (JSC::Walker::walk):
  • runtime/JSObject.cpp: (JSC::JSObject::defineGetter): (JSC::JSObject::defineSetter): (JSC::JSObject::removeDirect): (JSC::JSObject::putDirectFunction): (JSC::JSObject::putDirectFunctionWithoutTransition): (JSC::putDescriptor): (JSC::JSObject::defineOwnProperty):
  • runtime/JSObject.h: (JSC::JSObject::putDirectOffset): (JSC::JSObject::putUndefinedAtDirectOffset): (JSC::JSObject::flattenDictionaryObject): (JSC::JSObject::putDirectInternal): (JSC::JSObject::putDirect): (JSC::JSObject::putDirectFunction): (JSC::JSObject::putDirectWithoutTransition): (JSC::JSObject::putDirectFunctionWithoutTransition): (JSC::JSValue::putDirect): (JSC::JSObject::allocatePropertyStorageInline): (JSC::JSObject::markChildrenDirect):
  • runtime/JSStaticScopeObject.cpp: (JSC::JSStaticScopeObject::markChildren):
  • runtime/JSString.cpp: (JSC::StringObject::create):
  • runtime/JSValue.h:
  • runtime/JSWrapperObject.cpp: (JSC::JSWrapperObject::markChildren):
  • runtime/JSWrapperObject.h: (JSC::JSWrapperObject::internalValue): (JSC::JSWrapperObject::setInternalValue):
  • runtime/LiteralParser.cpp: (JSC::LiteralParser::parse):
  • runtime/Lookup.cpp: (JSC::setUpStaticFunctionSlot):
  • runtime/Lookup.h: (JSC::lookupPut):
  • runtime/MarkStack.h:
  • runtime/MathObject.cpp: (JSC::MathObject::MathObject):
  • runtime/NativeErrorConstructor.cpp: (JSC::NativeErrorConstructor::NativeErrorConstructor):
  • runtime/NativeErrorPrototype.cpp: (JSC::NativeErrorPrototype::NativeErrorPrototype):
  • runtime/NumberConstructor.cpp: (JSC::NumberConstructor::NumberConstructor): (JSC::constructWithNumberConstructor):
  • runtime/NumberObject.cpp: (JSC::constructNumber):
  • runtime/NumberPrototype.cpp: (JSC::NumberPrototype::NumberPrototype):
  • runtime/ObjectConstructor.cpp: (JSC::ObjectConstructor::ObjectConstructor): (JSC::objectConstructorGetOwnPropertyDescriptor):
  • runtime/Operations.h: (JSC::normalizePrototypeChain): (JSC::resolveBase):
  • runtime/PrototypeFunction.cpp: (JSC::PrototypeFunction::PrototypeFunction):
  • runtime/PutPropertySlot.h: (JSC::PutPropertySlot::setExistingProperty): (JSC::PutPropertySlot::setNewProperty): (JSC::PutPropertySlot::base):
  • runtime/RegExpConstructor.cpp: (JSC::RegExpConstructor::RegExpConstructor):
  • runtime/ScopeChain.cpp: (JSC::ScopeChainNode::print):
  • runtime/ScopeChain.h: (JSC::ScopeChainNode::~ScopeChainNode): (JSC::ScopeChainIterator::operator*): (JSC::ScopeChainIterator::operator->): (JSC::ScopeChain::top):
  • runtime/ScopeChainMark.h: (JSC::ScopeChain::markAggregate):
  • runtime/SmallStrings.cpp: (JSC::isMarked): (JSC::SmallStrings::markChildren):
  • runtime/SmallStrings.h: (JSC::SmallStrings::emptyString): (JSC::SmallStrings::singleCharacterString): (JSC::SmallStrings::singleCharacterStrings):
  • runtime/StringConstructor.cpp: (JSC::StringConstructor::StringConstructor):
  • runtime/StringObject.cpp: (JSC::StringObject::StringObject):
  • runtime/StringObject.h:
  • runtime/StringPrototype.cpp: (JSC::StringPrototype::StringPrototype):
  • runtime/Structure.cpp: (JSC::Structure::flattenDictionaryStructure):
  • runtime/Structure.h: (JSC::Structure::storedPrototypeSlot):
  • runtime/WeakGCMap.h: (JSC::WeakGCMap::uncheckedGet): (JSC::WeakGCMap::uncheckedGetSlot): (JSC::::get): (JSC::::take): (JSC::::set): (JSC::::uncheckedRemove):
  • runtime/WriteBarrier.h: Added. (JSC::DeprecatedPtr::DeprecatedPtr): (JSC::DeprecatedPtr::get): (JSC::DeprecatedPtr::operator*): (JSC::DeprecatedPtr::operator->): (JSC::DeprecatedPtr::slot): (JSC::DeprecatedPtr::operator UnspecifiedBoolType*): (JSC::DeprecatedPtr::operator!): (JSC::WriteBarrierBase::set): (JSC::WriteBarrierBase::get): (JSC::WriteBarrierBase::operator*): (JSC::WriteBarrierBase::operator->): (JSC::WriteBarrierBase::slot): (JSC::WriteBarrierBase::operator UnspecifiedBoolType*): (JSC::WriteBarrierBase::operator!): (JSC::WriteBarrier::WriteBarrier): (JSC::operator==):

2011-01-27 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

Convert markstack to a slot visitor API
https://bugs.webkit.org/show_bug.cgi?id=53219

There's no reason to recurse here, the value we
were marking was protected.

  • JSValueWrapper.cpp: (JSValueWrapper::JSObjectMark):

2011-01-27 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

Convert markstack to a slot visitor API
https://bugs.webkit.org/show_bug.cgi?id=53219

Update WebCore to the new marking apis, correct bindings
codegen.

  • ForwardingHeaders/runtime/WriteBarrier.h: Added.
  • WebCore.exp.in:
  • bindings/js/DOMWrapperWorld.h: (WebCore::DOMWrapperWorld::globalData):
  • bindings/js/JSAudioConstructor.cpp: (WebCore::JSAudioConstructor::JSAudioConstructor):
  • bindings/js/JSDOMBinding.cpp: (WebCore::markDOMNodesForDocument): (WebCore::markDOMObjectWrapper): (WebCore::markDOMNodeWrapper):
  • bindings/js/JSDOMGlobalObject.cpp: (WebCore::JSDOMGlobalObject::markChildren): (WebCore::JSDOMGlobalObject::setInjectedScript): (WebCore::JSDOMGlobalObject::injectedScript):
  • bindings/js/JSDOMGlobalObject.h: (WebCore::JSDOMGlobalObject::JSDOMGlobalObjectData::JSDOMGlobalObjectData): (WebCore::getDOMConstructor):
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::setLocation): (WebCore::DialogHandler::dialogCreated):
  • bindings/js/JSDOMWindowShell.cpp: (WebCore::JSDOMWindowShell::JSDOMWindowShell): (WebCore::JSDOMWindowShell::setWindow): (WebCore::JSDOMWindowShell::markChildren): (WebCore::JSDOMWindowShell::unwrappedObject):
  • bindings/js/JSDOMWindowShell.h: (WebCore::JSDOMWindowShell::window): (WebCore::JSDOMWindowShell::setWindow):
  • bindings/js/JSEventListener.cpp: (WebCore::JSEventListener::JSEventListener): (WebCore::JSEventListener::markJSFunction):
  • bindings/js/JSEventListener.h: (WebCore::JSEventListener::jsFunction):
  • bindings/js/JSHTMLDocumentCustom.cpp: (WebCore::JSHTMLDocument::setAll):
  • bindings/js/JSImageConstructor.cpp: (WebCore::JSImageConstructor::JSImageConstructor):
  • bindings/js/JSImageDataCustom.cpp: (WebCore::toJS):
  • bindings/js/JSJavaScriptCallFrameCustom.cpp: (WebCore::JSJavaScriptCallFrame::scopeChain): (WebCore::JSJavaScriptCallFrame::scopeType):
  • bindings/js/JSNodeFilterCondition.cpp: (WebCore::JSNodeFilterCondition::markAggregate): (WebCore::JSNodeFilterCondition::acceptNode):
  • bindings/js/JSNodeFilterCondition.h:
  • bindings/js/JSNodeFilterCustom.cpp:
  • bindings/js/JSOptionConstructor.cpp: (WebCore::JSOptionConstructor::JSOptionConstructor):
  • bindings/js/JSSQLResultSetRowListCustom.cpp: (WebCore::JSSQLResultSetRowList::item):
  • bindings/js/ScriptCachedFrameData.cpp: (WebCore::ScriptCachedFrameData::restore):
  • bindings/js/ScriptObject.cpp: (WebCore::ScriptGlobalObject::set):
  • bindings/js/SerializedScriptValue.cpp: (WebCore::CloneDeserializer::putProperty):
  • bindings/scripts/CodeGeneratorJS.pm:
  • dom/Document.h:

2011-01-27 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

Convert markstack to a slot visitor API
https://bugs.webkit.org/show_bug.cgi?id=53219

Update to new marking api

  • WebView/WebScriptDebugDelegate.mm: (-[WebScriptCallFrame scopeChain]):
15:38 Changeset [77005] by mrowe@apple.com
  • 6 edits
    2 adds in branches/safari-533.20-branch

Merge r74636.

15:33 Changeset [77004] by dpranke@chromium.org
  • 6 edits in trunk/Tools

2011-01-28 Dirk Pranke <dpranke@chromium.org>

Reviewed by Tony Chang.

new-run-webkit-tests: change worker model values to
"old-inline", "old-threads" in preparation for test_runner2 /
multiprocessing changes.

https://bugs.webkit.org/show_bug.cgi?id=53156

  • Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
15:21 Changeset [77003] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

Keyboard scrolling doesn’t work in WebKit2
<rdar://problem/8909672>

Reviewed by Anders Carlsson.

  • platform/mac/ScrollAnimatorMac.mm:

(-[ScrollAnimationHelperDelegate convertSizeToBacking:]):
(-[ScrollAnimationHelperDelegate convertSizeFromBacking:]):
Add additional necessary delegate methods.

15:18 Changeset [77002] by mrowe@apple.com
  • 5 edits
    35 adds in branches/safari-533.20-branch

Merge r72802.

15:18 Changeset [77001] by mrowe@apple.com
  • 2 edits in branches/safari-533.20-branch/WebCore

Merge r68321.

15:12 Changeset [77000] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Don't put config.h in the message headers.

Reviewed by Sam Weinig.

  • Scripts/webkit2/messages.py:
  • Scripts/webkit2/messages_unittest.py:
15:12 Changeset [76999] by darin@apple.com
  • 4 edits in trunk/Source/WebCore

Re-land this patch with the missing null check that caused crashes in layout tests.

Reviewed by Dan Bernstein.

Changing cursor style has no effect until the mouse moves
https://bugs.webkit.org/show_bug.cgi?id=14344
rdar://problem/7563712

No tests added because we don't have infrastructure for testing actual cursor
changes (as opposed to cursor style computation) at this time. We might add it later.

  • page/EventHandler.cpp:

(WebCore::EventHandler::dispatchFakeMouseMoveEventSoon): Added.

  • page/EventHandler.h: Ditto.
  • rendering/RenderObject.cpp:

(WebCore::areNonIdenticalCursorListsEqual): Added.
(WebCore::areCursorsEqual): Added.
(WebCore::RenderObject::styleDidChange): Call dispatchFakeMouseMoveEventSoon if
cursor styles changed.

15:12 Changeset [76998] by dpranke@chromium.org
  • 2 edits in trunk/Tools

2011-01-28 Dirk Pranke <dpranke@chromium.org>

Reviewed by Tony Chang.

committers.py - add an IRC nickname for dpranke
https://bugs.webkit.org/show_bug.cgi?id=53335

  • Scripts/webkitpy/common/config/committers.py:
15:05 Changeset [76997] by mrowe@apple.com
  • 4 edits
    2 adds in branches/safari-533.20-branch

Merge r70740.

15:03 Changeset [76996] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix build.

  • Shared/mac/ShareableSurface.cpp:
14:55 Changeset [76995] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Try to unbreak the Windows build.

  • UIProcess/cf/WebPageProxyCF.cpp:
14:51 Changeset [76994] by tony@chromium.org
  • 7 edits in trunk/LayoutTests

2011-01-28 Tony Chang <tony@chromium.org>

Unreviewed, a chromium win/linux rebaseline. The mac result was
rebaselined in r76735.

  • platform/chromium-linux/fast/overflow/overflow-rtl-vertical-expected.checksum:
  • platform/chromium-linux/fast/overflow/overflow-rtl-vertical-expected.png:
  • platform/chromium-win/fast/overflow/overflow-rtl-vertical-expected.checksum:
  • platform/chromium-win/fast/overflow/overflow-rtl-vertical-expected.png:
  • platform/chromium-win/fast/overflow/overflow-rtl-vertical-expected.txt:
  • platform/chromium/test_expectations.txt:
14:48 Changeset [76993] by beidson@apple.com
  • 9 edits in trunk/Source/WebKit2

https://bugs.webkit.org/show_bug.cgi?id=53330
Need InjectedBundle API to get the response MIMEType for a URL

Reviewed by John Sullivan.

  • WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:

(WKBundleFrameCopyMIMETypeForResourceWithURL):

  • WebProcess/InjectedBundle/API/c/WKBundleFrame.h:

Get the MIMEType from the in-memory cache, or cachedResponseMIMETypeForURL() if not available:

  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::mimeTypeForResourceWithURL):

  • WebProcess/WebPage/WebFrame.h:

Get the MIMEType from the platform's disk cache if available:

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::cachedResponseMIMETypeForURL):

  • WebProcess/WebPage/qt/WebPageQt.cpp:

(WebKit::WebPage::cachedResponseMIMETypeForURL):

  • WebProcess/WebPage/win/WebPageWin.cpp:

(WebKit::WebPage::cachedResponseMIMETypeForURL):

14:41 Changeset [76992] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533.20-branch

Merge r74779.

14:31 Changeset [76991] by andersca@apple.com
  • 62 edits in trunk/Source/WebKit2

Clean up the mess introduced when config.h was added to the project:

Reviewed by Sam Weinig.

  • Remove the contents of WebKit2Prefix.h that is now in config.h, to avoid including everything twice in each file, probably slowing down compile time.
  • Add config.h to all the files that were forgotten in order to keep the build from breaking.
  • Added trap to ensure that config.h is included at the top of every implementation file. If this had been added it would have caught the previous issue.
14:26 Changeset [76990] by jschuh@chromium.org
  • 6 edits
    2 adds in trunk

2011-01-28 Justin Schuh <jschuh@chromium.org>

Reviewed by Eric Seidel.

We should hold RefPtrs to SVG font faces
https://bugs.webkit.org/show_bug.cgi?id=53270

  • svg/custom/use-multiple-on-nested-disallowed-font-expected.txt: Added.
  • svg/custom/use-multiple-on-nested-disallowed-font.html: Added.

2011-01-28 Justin Schuh <jschuh@chromium.org>

Reviewed by Eric Seidel.

We should hold RefPtrs to SVG font faces
https://bugs.webkit.org/show_bug.cgi?id=53270

Test: svg/custom/use-multiple-on-nested-disallowed-font.html

  • css/CSSFontFaceSource.cpp: (WebCore::CSSFontFaceSource::getFontData):
  • css/CSSFontFaceSource.h:
  • svg/SVGFontFaceElement.cpp: (WebCore::SVGFontFaceElement::associatedFontElement):
  • svg/SVGFontFaceElement.h:
14:26 Changeset [76989] by slewis@apple.com
  • 5 edits in trunk/Source/WebKit2

<rdar://problem/8857651> Implement unregisterWorld for WebKit2
Rename unregisterWorld to clearWrappers. Clearing the wrappers reduces the
memory use of isolated worlds.

Reviewed by Geoff Garen.

  • WebProcess/InjectedBundle/API/c/WKBundleScriptWorld.cpp:

(WKBundleScriptWorldClearWrappers):

  • WebProcess/InjectedBundle/API/c/WKBundleScriptWorld.h:
  • WebProcess/InjectedBundle/InjectedBundleScriptWorld.cpp:

(WebKit::InjectedBundleScriptWorld::clearWrappers):

  • WebProcess/InjectedBundle/InjectedBundleScriptWorld.h:
14:20 Changeset [76988] by zmo@google.com
  • 7 edits in trunk

2011-01-28 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

uniformN*v should generate INVALID_VALUE of the array size is not a multiple of N
https://bugs.webkit.org/show_bug.cgi?id=53306

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::validateUniformMatrixParameters):

2011-01-28 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

uniformN*v should generate INVALID_VALUE of the array size is not a multiple of N
https://bugs.webkit.org/show_bug.cgi?id=53306

  • fast/canvas/webgl/gl-uniform-arrays-expected.txt:
  • fast/canvas/webgl/gl-uniform-arrays.html:
  • fast/canvas/webgl/gl-uniformmatrix4fv-expected.txt:
  • fast/canvas/webgl/gl-uniformmatrix4fv.html:
14:17 Changeset [76987] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

2011-01-28 Tom Sepez <tsepez@chromium.org>

Reviewed by Eric Seidel.

NULL pointer crash in TextIterator::handleTextBox()
https://bugs.webkit.org/show_bug.cgi?id=53267

  • fast/css/rtl-nth-child-first-letter-crash-expected.txt: Added.
  • fast/css/rtl-nth-child-first-letter-crash.html: Added.

2011-01-28 Tom Sepez <tsepez@chromium.org>

Reviewed by Eric Seidel.

NULL pointer crash in TextIterator::handleTextBox()
https://bugs.webkit.org/show_bug.cgi?id=53267

Test: fast/css/rtl-nth-child-first-letter-crash.html

  • editing/TextIterator.cpp: (WebCore::TextIterator::handleTextBox):
14:08 Changeset [76986] by dglazkov@chromium.org
  • 2 edits in trunk/LayoutTests

2011-01-28 Dimitri Glazkov <dglazkov@chromium.org>

Skip webkitAudioPannerNode from the test. It's not yet implemented across
all ports/platforms.

  • fast/dom/script-tests/prototype-inheritance.js: Skipped webkitAudioPannerNode.
13:58 Changeset [76985] by mnaganov@chromium.org
  • 8 edits in branches/chromium/648

Merge 76683 - 2011-01-26 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: inspector tests fix.

  • http/tests/inspector/inspector-test2.js: (initialize_InspectorTest.InspectorTest.evaluateInPage):
  • inspector/console-format.html:

TBR=pfeldman@chromium.org
Review URL: http://codereview.chromium.org/6282016

13:55 Changeset [76984] by enne@google.com
  • 2 edits in trunk/Source/WebCore

2011-01-28 Adrienne Walker <enne@google.com>

Reviewed by Kenneth Russell.

[chromium] Remove a spurious diagnostic CRASH check.
https://bugs.webkit.org/show_bug.cgi?id=52379

  • platform/graphics/chromium/LayerTilerChromium.cpp: (WebCore::LayerTilerChromium::invalidateRect):
13:34 Changeset [76983] by mitz@apple.com
  • 55 edits
    1 add in trunk/Source

Source/WebCore: <rdar://problem/4761512> <select> can't display right-to-left (rtl) languages
https://bugs.webkit.org/show_bug.cgi?id=19785

Reviewed by Sam Weinig.

Changed <select> pop-up menus on Mac OS X Snow Leopard and later to have their items aligned in the
direction corresponding to the writing direction of the <select> element, with the checkmarks
on the "start" side, and use the <option>'s writing direction rather than "natural". Made the
pop-up button match the menu by adding a Chrome boolean function, selectItemAlignmentFollowsMenuWritingDirection(),
which returns true for this pop-up behavior.

  • loader/EmptyClients.h:

(WebCore::EmptyChromeClient::selectItemAlignmentFollowsMenuWritingDirection): Added.

  • manual-tests/pop-up-alignment-and-direction.html: Added.
  • page/Chrome.cpp:

(WebCore::Chrome::selectItemAlignmentFollowsMenuWritingDirection): Added. Calls through to the
client.

  • page/Chrome.h:
  • page/ChromeClient.h:
  • platform/PopupMenuStyle.h:

(WebCore::PopupMenuStyle::PopupMenuStyle): Added hasTextDirectionOverride parameter and member
variable initialization.
(WebCore::PopupMenuStyle::hasTextDirectionOverride): Added this accessor.

  • platform/mac/PopupMenuMac.mm:

(WebCore::PopupMenuMac::populate): Set the pop-up's layout direction and items' text alignment
to match the menu's writing direction. Set items' writing direction and direction override
according to their styles.

  • rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::RenderMenuList): Removed unncesaary initialization of a smart pointer.
(WebCore::RenderMenuList::adjustInnerStyle): If the alignment of items in the menu follows the
menu's writing direction, use that alignment for the button as well. Also in this mode, use the
item's writing direction and override setting.
(WebCore::RenderMenuList::setTextFromOption): Store the option element's style.
(WebCore::RenderMenuList::itemStyle): Pass the text direction override value.
(WebCore::RenderMenuList::menuStyle): Ditto. Also use the button's direction, not the inner text's.

  • rendering/RenderMenuList.h:
  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::menuStyle): Pass the text direction override value.

Source/WebKit/chromium: <select> can't display right-to-left (rtl) languages
https://bugs.webkit.org/show_bug.cgi?id=19785

Reviewed by Sam Weinig.

  • src/AutoFillPopupMenuClient.cpp:

(WebKit::AutoFillPopupMenuClient::initialize): Pass hasTextDirectionOverride to the PopupMenuStyle
constructor.

  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::selectItemAlignmentFollowsMenuWritingDirection): Added.

  • src/ChromeClientImpl.h:
  • tests/PopupMenuTest.cpp:

(WebKit::TestPopupMenuClient::itemStyle): Pass hasTextDirectionOverride to the PopupMenuStyle
constructor.

Source/WebKit/efl: <select> can't display right-to-left (rtl) languages
https://bugs.webkit.org/show_bug.cgi?id=19785

Reviewed by Sam Weinig.

  • WebCoreSupport/ChromeClientEfl.cpp:

(WebCore::ChromeClientEfl::selectItemAlignmentFollowsMenuWritingDirection): Added.

  • WebCoreSupport/ChromeClientEfl.h:

Source/WebKit/gtk: <select> can't display right-to-left (rtl) languages
https://bugs.webkit.org/show_bug.cgi?id=19785

Reviewed by Sam Weinig.

  • WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::ChromeClient::selectItemAlignmentFollowsMenuWritingDirection): Added.

  • WebCoreSupport/ChromeClientGtk.h:

Source/WebKit/haiku: <select> can't display right-to-left (rtl) languages
https://bugs.webkit.org/show_bug.cgi?id=19785

Reviewed by Sam Weinig.

  • WebCoreSupport/ChromeClientHaiku.cpp:

(WebCore::ChromeClientHaiku::selectItemAlignmentFollowsMenuWritingDirection): Added.

  • WebCoreSupport/ChromeClientHaiku.h:

Source/WebKit/mac: <select> can't display right-to-left (rtl) languages
https://bugs.webkit.org/show_bug.cgi?id=19785

Reviewed by Sam Weinig.

  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::selectItemWritingDirectionIsNatural): Changed to return false.
(WebChromeClient::selectItemAlignmentFollowsMenuWritingDirection): Added. Returns true.

Source/WebKit/qt: <select> can't display right-to-left (rtl) languages
https://bugs.webkit.org/show_bug.cgi?id=19785

Reviewed by Sam Weinig.

  • WebCoreSupport/ChromeClientQt.cpp:

(WebCore::ChromeClientQt::selectItemAlignmentFollowsMenuWritingDirection): Added.

  • WebCoreSupport/ChromeClientQt.h:

Source/WebKit/win: <select> can't display right-to-left (rtl) languages
https://bugs.webkit.org/show_bug.cgi?id=19785

Reviewed by Sam Weinig.

  • WebCoreSupport/WebChromeClient.cpp:

(WebChromeClient::selectItemAlignmentFollowsMenuWritingDirection): Added.

  • WebCoreSupport/WebChromeClient.h:

Source/WebKit/wince: <select> can't display right-to-left (rtl) languages
https://bugs.webkit.org/show_bug.cgi?id=19785

Reviewed by Sam Weinig.

  • WebCoreSupport/ChromeClientWinCE.cpp:

(WebKit::ChromeClientWinCE::selectItemAlignmentFollowsMenuWritingDirection): Added.

  • WebCoreSupport/ChromeClientWinCE.h:

Source/WebKit/wx: <select> can't display right-to-left (rtl) languages
https://bugs.webkit.org/show_bug.cgi?id=19785

Reviewed by Sam Weinig.

  • WebKitSupport/ChromeClientWx.cpp:

(WebCore::ChromeClientWx::selectItemAlignmentFollowsMenuWritingDirection): Added.

  • WebKitSupport/ChromeClientWx.h:

Source/WebKit2: <select> can't display right-to-left (rtl) languages
https://bugs.webkit.org/show_bug.cgi?id=19785

Reviewed by Sam Weinig.

  • Shared/WebPopupItem.cpp:

(WebKit::WebPopupItem::WebPopupItem): Added initializers for m_textDirection and m_hasTextDirectionOverride.
(WebKit::WebPopupItem::encode): Encode the item's writing direction and direction override values.
(WebKit::WebPopupItem::decode): Decode the item's writing direction and direction override values.

  • Shared/WebPopupItem.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::showPopupMenu): Added a parameter for the menu's text direction.

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in: Ditto.
  • UIProcess/WebPopupMenuProxy.h:
  • UIProcess/mac/WebPopupMenuProxyMac.h:
  • UIProcess/mac/WebPopupMenuProxyMac.mm:

(WebKit::WebPopupMenuProxyMac::populate): Added a parameter for the menu's text direction.
Set items' text alignment to match the menu's writing direction. Set items' writing direction
and direction override according to their styles.
(WebKit::WebPopupMenuProxyMac::showPopupMenu): Set the pop-up's layout direction.

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::selectItemWritingDirectionIsNatural): Changed to return false.
(WebKit::WebChromeClient::selectItemAlignmentFollowsMenuWritingDirection): Added.

  • WebProcess/WebCoreSupport/WebChromeClient.h:
  • WebProcess/WebCoreSupport/WebPopupMenu.cpp:

(WebKit::WebPopupMenu::populateItems): Initialize items' writing direction and direction override
values.
(WebKit::WebPopupMenu::show): Pass the menu's writing direction.

13:34 Changeset [76982] by dpranke@chromium.org
  • 5 edits
    2 adds in trunk/Tools

2011-01-28 Dirk Pranke <dpranke@chromium.org>

Reviewed by Tony Chang.

new-run-webkit-tests: add a "mock DRT" port implementation
and a separate class that emulates what we expect the
DumpRenderTree behavior to be.

This will eventually replace port/dryrun.py and allow us to get
better test coverage of the new-run-webkit-tests code as well as
a reference for what new-run-webkit-tests expects from DRT.

This is the first attempt at this, and it is pretty bare-boned. It
really only has been tested on the 'mac' port (and a little on
the 'chromium-mac' port.

https://bugs.webkit.org/show_bug.cgi?id=53126

  • Scripts/webkitpy/common/system/filesystem_mock.py:
  • Scripts/webkitpy/layout_tests/port/dryrun.py:
  • Scripts/webkitpy/layout_tests/port/factory.py:
  • Scripts/webkitpy/layout_tests/port/mock_drt.py: Added.
  • Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Added.
  • Scripts/webkitpy/layout_tests/port/test.py:
13:31 Changeset [76981] by abarth@webkit.org
  • 4 edits in trunk/Source/WebCore

2011-01-28 Adam Barth <abarth@webkit.org>

Reviewed by Daniel Bates.

Teach XSSFilter how to filter <script> elements
https://bugs.webkit.org/show_bug.cgi?id=53279

This patch adds the ability for the XSSFilter to block injected
<script> elements. Handling script elements is slightly subtle because
these elements act very differently depending on whether they have a
src attribute.


In the "src case", which check whether the src attribute was present in
the request. In the "non-src case", we check whether the start tag and
the body of the script element was included in the request. Checking
for the whole start tag means we miss out on some attribute splitting
attacks inside of script tags, but that doesn't seem like that big a
deal.

This patch also introduces some amount of state into the XSSFilter
because inline script elements span multiple tokens. There's a lot of
tuning and optimization left in these cases, some of which I've noted
with FIXMEs.

To test this patch, I played around with some of the existing
XSSAuditor tests. Hopefully I'll be able to run the test suite more
systematically in the future.

  • html/parser/HTMLToken.h: (WebCore::HTMLToken::eraseCharacters): (WebCore::HTMLToken::eraseValueOfAttribute):
  • html/parser/XSSFilter.cpp: (WebCore::HTMLNames::hasName): (WebCore::HTMLNames::findAttributeWithName): (WebCore::HTMLNames::isNameOfScriptCarryingAttribute): (WebCore::XSSFilter::XSSFilter): (WebCore::XSSFilter::filterToken): (WebCore::XSSFilter::filterTokenAfterScriptStartTag): (WebCore::XSSFilter::filterScriptToken): (WebCore::XSSFilter::snippetForRange): (WebCore::XSSFilter::snippetForAttribute):
  • html/parser/XSSFilter.h:
13:29 Changeset [76980] by abarth@webkit.org
  • 10 edits
    2 adds in trunk/Source/WebCore

2011-01-28 Adam Barth <abarth@webkit.org>

Reviewed by Daniel Bates.

Sketch out new XSS filter design (disabled by default)
https://bugs.webkit.org/show_bug.cgi?id=53205

This patch adds a basic sketch of the new XSS filter design. Rather
than watching scripts as they execute, in this design, we watch tokens
emitted by the tokenizer. We then map the tokens directly back into
input characters, which lets us skip all the complicated logic related
to HTML entities and double-decoding of JavaScript URLs.

This patch contains only the bare essentially machinery. I'll add more
in future patches and eventually remove the previous code once this
code is up and running correctly.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/parser/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::HTMLDocumentParser): (WebCore::HTMLDocumentParser::pumpTokenizer): (WebCore::HTMLDocumentParser::sourceForToken):
  • html/parser/HTMLDocumentParser.h:
  • html/parser/XSSFilter.cpp: Added.
  • html/parser/XSSFilter.h: Added.
13:29 Changeset [76979] by mrobinson@webkit.org
  • 2 edits in trunk

2011-01-28 Martin Robinson <mrobinson@igalia.com>

[GTK] Build failure with --enable-indexed-database
https://bugs.webkit.org/show_bug.cgi?id=50954

Build fix for IndexedDB support.

  • configure.ac: Change the autogen.sh option --enable-indexeddb to --enable-indexed-database to match the build-webkit option.
13:27 Changeset [76978] by dglazkov@chromium.org
  • 2 edits
    2 adds
    1 delete in trunk/LayoutTests

2011-01-28 Dimitri Glazkov <dglazkov@chromium.org>

[Chromium] Added expectations for a passing test.

  • platform/chromium-mac/fast/dom/isindex-002-expected.checksum: Added.
  • platform/chromium-mac/fast/dom/isindex-002-expected.png: Added.
  • platform/chromium-mac/fast/dom/isindex-002-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
13:22 Changeset [76977] by dglazkov@chromium.org
  • 6 edits
    2 adds in trunk/LayoutTests

2011-01-28 Dimitri Glazkov <dglazkov@chromium.org>

Updated Chromium baselines for a bug that was fixed.
https://bugs.webkit.org/show_bug.cgi?id=45527

  • platform/chromium-linux/fast/dom/replaceChild-expected.checksum:
  • platform/chromium-linux/fast/dom/replaceChild-expected.png:
  • platform/chromium-mac/fast/dom/replaceChild-expected.checksum: Added.
  • platform/chromium-mac/fast/dom/replaceChild-expected.png: Added.
  • platform/chromium-win/fast/dom/replaceChild-expected.checksum:
  • platform/chromium-win/fast/dom/replaceChild-expected.png:
  • platform/chromium/test_expectations.txt: Removed expectation of failure.
13:04 Changeset [76976] by jberlin@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

[Windows 7 Release Tests] fast/repaint/select-option-background-color.html failing since introduction in r76826
https://bugs.webkit.org/show_bug.cgi?id=53327

Unreviewed, adding Windows-specific results to get the Windows 7 Release Test bot green.

  • platform/win/fast/repaint/select-option-background-color-expected.txt: Added.
12:51 Changeset [76975] by aroben@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Chromium build fix after r76967

  • wtf/ThreadingPrimitives.h: Use OS(WINDOWS) instead of PLATFORM(WIN), to match other

similar macros in this file.

12:39 Changeset [76974] by andersca@apple.com
  • 2 edits
    2 adds in trunk/Source/WebKit2

2011-01-28 Anders Carlsson <andersca@apple.com>

Reviewed by Adam Roben.

Add ShareableSurface class
https://bugs.webkit.org/show_bug.cgi?id=53313

  • Shared/mac/ShareableSurface.cpp: Added. (WebKit::ShareableSurface::Handle::Handle): Initialize the mach port.

(WebKit::ShareableSurface::Handle::~Handle):
Deallocate our send right if needed.

(WebKit::ShareableSurface::Handle::encode):
Encode the send right, and then null it out.

(WebKit::ShareableSurface::Handle::decode):
Decode the send right.


(WebKit::createIOSurface):
Create an IOSurface with the given size.

(WebKit::ShareableSurface::create):
Create an IOSurface, either from a size or from a handle.

(WebKit::ShareableSurface::~ShareableSurface):
Delete the texture and framebuffer.

(WebKit::ShareableSurface::createHandle):
Create a mach port from the surface.

(WebKit::ShareableSurface::attach):
Create an FBO if needed and bind it.

(WebKit::ShareableSurface::detach):
Unbind the FBO.

(WebKit::ShareableSurface::textureID):
Generate a new texture and bind it to the IOSurface.

  • Shared/mac/ShareableSurface.h: Added.
  • WebKit2.xcodeproj/project.pbxproj: Add new files.
12:35 Changeset [76973] by psolanki@apple.com
  • 1 edit
    1 delete in trunk/Tools

Unreviewed. Removing .swp file checked in by mistake.

  • Scripts/.webkitdirs.pm.swp: Removed.
12:33 Changeset [76972] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-01-28 Adam Klein <adamk@chromium.org>

Reviewed by Kent Tamura.

[Chromium] Remove deprecated openFileSystem method signature
https://bugs.webkit.org/show_bug.cgi?id=53262

Chromium still builds after this patch.

  • public/WebFrameClient.h:
12:27 Changeset [76971] by psolanki@apple.com
  • 2 edits
    1 add in trunk/Tools

2011-01-28 Pratik Solanki <psolanki@apple.com>

Reviewed by David Kilzer.

Space not necessary for undefined feature
https://bugs.webkit.org/show_bug.cgi?id=53317

  • Scripts/build-webkit:
12:26 Changeset [76970] by rniwa@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

2011-01-28 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed Chromium rebaselines.

Check in the same result as fast/dom/window-domurl-crash-expected.txt because Windows port
intentionally added a failing result in http://trac.webkit.org/changeset/76953.

The Windows port's bug is tracked by https://bugs.webkit.org/show_bug.cgi?id=53310.

  • platform/chromium-win/fast/dom/window-domurl-crash-expected.txt: Added.
12:21 Changeset [76969] by msaboff@apple.com
  • 5 edits in trunk/Source

2011-01-28 Michael Saboff <msaboff@apple.com>

Potentially Unsafe HashSet of RuntimeObject* in RootObject definition
https://bugs.webkit.org/show_bug.cgi?id=53271

Reapplying this this change. No change from prior patch in
JavaScriptCore.

Added new isValid() methods to check if a contained object in
a WeakGCMap is valid when using an unchecked iterator.

  • runtime/WeakGCMap.h: (JSC::WeakGCMap::isValid):

2011-01-28 Michael Saboff <msaboff@apple.com>

Reviewed by Geoffrey Garen.

Potentially Unsafe HashSet of RuntimeObject* in RootObject definition
https://bugs.webkit.org/show_bug.cgi?id=53271

Reapplying this patch with the change that the second ASSERT in
RootObject::removeRuntimeObject was changed to use
.uncheckedGet() instead of the failing .get(). The object in question
could be in the process of being GC'ed. The get() call will not return
such an object while the uncheckedGet() call will return the (unsafe)
object. This is the behavior we want.

Precautionary change.
Changed RootObject to use WeakGCMap instead of HashSet.
Found will looking for another issue, but can't produce a test case
that is problematic. THerefore there aren't any new tests.

  • bridge/runtime_root.cpp: (JSC::Bindings::RootObject::invalidate): (JSC::Bindings::RootObject::addRuntimeObject): (JSC::Bindings::RootObject::removeRuntimeObject):
  • bridge/runtime_root.h:
12:16 Changeset [76968] by aroben@apple.com
  • 4 edits in trunk

Notify CACFLayerTreeHost when the context is flushed

LegacyCACFLayerTreeHost was keeping this a secret, which meant that WebCore's animation
timers were never starting.

Fixes <http://webkit.org/b/53302> [Windows 7 Release Tests] changesets 76853, 76856, and
76858 broke ~36 animations, compositing, and transitions tests

Reviewed by Sam Weinig.

Source/WebCore:

  • platform/graphics/ca/win/LegacyCACFLayerTreeHost.cpp:

(WebCore::LegacyCACFLayerTreeHost::contextDidChange): Call up to the base class after we
start our render timer.

LayoutTests:

Unskip compositing-related tests that are now fixed

  • platform/win/Skipped:
12:16 Changeset [76967] by aroben@apple.com
  • 8 edits
    1 copy in trunk/Source

Change BinarySemaphore to wrap an auto-reset Win32 event on Windows

Fixes <http://webkit.org/b/53208> <rdar://problem/8922490>.

Reviewed by Dave Hyatt.

Source/WebKit2:

  • Platform/CoreIPC/BinarySemaphore.cpp: Wrap this implementation in #if !PLATFORM(WIN).
  • Platform/CoreIPC/BinarySemaphore.h: Make the Windows implementation have a single HANDLE

member that holds the event.

  • Platform/CoreIPC/win/BinarySemaphoreWin.cpp: Copied from Source/WebKit2/Platform/CoreIPC/BinarySemaphore.cpp.

(CoreIPC::BinarySemaphore::BinarySemaphore): Create our event.
(CoreIPC::BinarySemaphore::~BinarySemaphore): Destory our event.
(CoreIPC::BinarySemaphore::signal): Signal the event.
(CoreIPC::BinarySemaphore::wait): Convert the absolute time to a wait interval, then wait
for the event to be signaled or for the interval to elapse.

  • win/WebKit2.vcproj: Added BinarySemaphoreWin.cpp. Also let VS have its way with the file.

Source/JavaScriptCore:

Extract code to convert a WTF absolute time to a Win32 wait interval into a separate
function

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Export the new function.
  • wtf/ThreadingPrimitives.h: Declare the new function.
  • wtf/ThreadingWin.cpp:

(WTF::ThreadCondition::timedWait): Moved code to convert the absolute time to a wait
interval from here...
(WTF::absoluteTimeToWaitTimeoutInterval): ...to here.

12:15 Changeset [76966] by antti@apple.com
  • 8 edits in trunk/Source/WebCore

Remove dead code that tried to map from CSS values to parser values
https://bugs.webkit.org/show_bug.cgi?id=53318

Reviewed by Dan Bernstein.

  • css/CSSFunctionValue.cpp:
  • css/CSSFunctionValue.h:
  • css/CSSPrimitiveValue.cpp:
  • css/CSSPrimitiveValue.h:
  • css/CSSValue.h:
  • css/CSSValueList.cpp:
  • css/CSSValueList.h:
12:14 Changeset [76965] by jberlin@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

[Windows 7 Release Tests] fast/text/justify-ideograph-complex/simple/vertical.html failing since introduction in r76743.
https://bugs.webkit.org/show_bug.cgi?id=53321

Unreviewed, checking in failing expected results to get the Windows 7 Release Tests bots green.

  • platform/win/fast/text/justify-ideograph-complex-expected.txt: Added.
  • platform/win/fast/text/justify-ideograph-simple-expected.txt: Added.
  • platform/win/fast/text/justify-ideograph-vertical-expected.txt: Added.
12:11 Changeset [76964] by dglazkov@chromium.org
  • 2 edits in trunk/LayoutTests

2011-01-28 Dimitri Glazkov <dglazkov@chromium.org>

Remove now-passing test from expectations.

  • platform/chromium/test_expectations.txt: Expectation of failure removed.
12:08 Changeset [76963] by dglazkov@chromium.org
  • 2 edits in trunk/LayoutTests

2011-01-28 Dimitri Glazkov <dglazkov@chromium.org>

Update expectations for prototype-inheritance to match platform/mac.

  • platform/chromium/fast/dom/prototype-inheritance-expected.txt: Updated.
11:48 Changeset [76962] by cmarrin@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-01-27 Chris Marrin <cmarrin@apple.com>

Reviewed by Anders Carlsson.

WebKit2: Page flashes just before accelerated compositing animation
https://bugs.webkit.org/show_bug.cgi?id=53274

When switching out of compositing mode, the new ChunkedUpdateDrawingAreaProxy
is getting created with the current page size. When the setSize() call is
subsequently made, the sizeDidChange() call is not made (which does the initial
render of the page) because the old size and new size are the same. The solution
is to skip the setting of the size in the ctor and let it go through a size
change sequence.

  • UIProcess/DrawingAreaProxy.cpp: (WebKit::DrawingAreaProxy::DrawingAreaProxy):
11:46 Changeset [76961] by enrica@apple.com
  • 3 edits
    4 deletes in trunk

Some drag and drop tests fail since r76824
https://bugs.webkit.org/show_bug.cgi?id=53304

Reviewed by Adam Roben.

Source/WebCore:

There were '
' instead of '&&' in the checks for valid

clipboard content.

  • platform/win/ClipboardWin.cpp:

(WebCore::ClipboardWin::getData):
(WebCore::ClipboardWin::types):
(WebCore::ClipboardWin::files):

LayoutTests:

Removing platform-specific tests after fixing the cause of the failure.

  • platform/win/editing/pasteboard/get-data-text-plain-paste-expected.txt: Removed.
  • platform/win/editing/pasteboard/onpaste-text-html-expected.txt: Removed.
  • platform/win/fast/events/drag-and-drop-dataTransfer-types-nocrash-expected.txt: Removed.
  • platform/win/fast/events/ondrop-text-html-expected.txt: Removed.
11:29 Changeset [76960] by mrobinson@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-01-28 Martin Robinson <mrobinson@igalia.com>

[GTK] AudioProcessingEvent.h and JSJavaScriptAudioNode.h: No such file or directory
https://bugs.webkit.org/show_bug.cgi?id=52889

Build fix for WebAudio. Include WebAudio source files on the source
list when WebAudio is enabled.

  • GNUmakefile.am: Include missing source files.
11:18 Changeset [76959] by jberlin@webkit.org
  • 1 edit
    1 delete in trunk/LayoutTests

Remove the Windows-specific failing results for media/audio-data-url.html, since it appears
to be passing on the bots now. Unreviewed.
https://bugs.webkit.org/show_bug.cgi?id=51518

  • platform/win/media/audio-data-url-expected.txt: Removed.
11:16 Changeset [76958] by chang.shu@nokia.com
  • 5 edits in trunk

2011-01-28 Chang Shu <chang.shu@nokia.com>

Reviewed by Andreas Kling.

Unskipp auth.html after fix.
https://bugs.webkit.org/show_bug.cgi?id=36688

  • platform/qt/Skipped:

2011-01-28 Chang Shu <chang.shu@nokia.com>

Reviewed by Andreas Kling.

Reset NetworkAccessManager to clean up credentials from previous tests.
This change causes no performance overhead either.
https://bugs.webkit.org/show_bug.cgi?id=36688

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): (WebCore::DumpRenderTree::open):
  • DumpRenderTree/qt/DumpRenderTreeQt.h:
11:11 BuildingQtOnSymbian edited by siddharth.mathur@nokia.com
fix typos, yuck (diff)
11:06 Changeset [76957] by dglazkov@chromium.org
  • 2 edits in trunk/LayoutTests

2011-01-28 Dimitri Glazkov <dglazkov@chromium.org>

Added newly-failing tests to expectations, will be fixing them shortly.
https://bugs.webkit.org/show_bug.cgi?id=53314

  • platform/chromium/test_expectations.txt: Added.
11:05 Changeset [76956] by weinig@apple.com
  • 12 edits in trunk/Source

Add basic rubber banding support
<rdar://problem/8219429>
https://bugs.webkit.org/show_bug.cgi?id=53277

Reviewed by Maciej Stachowiak.

Source/JavaScriptCore:

  • wtf/Platform.h: Add ENABLE for rubber banding.

Source/WebCore:

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleGestureEvent):
Pass gesture events to the FrameView.

  • platform/ScrollAnimator.cpp:

(WebCore::ScrollAnimator::handleGestureEvent):

  • platform/ScrollAnimator.h:

Add stubbed out implementation.

  • platform/ScrollView.cpp:

(WebCore::ScrollView::ScrollView):
(WebCore::ScrollView::overhangAmount):
(WebCore::ScrollView::wheelEvent):

  • platform/ScrollView.h:
  • platform/ScrollableArea.cpp:

(WebCore::ScrollableArea::ScrollableArea):
(WebCore::ScrollableArea::handleGestureEvent):

  • platform/ScrollableArea.h:

(WebCore::ScrollableArea::constrainsScrollingToContentEdge):
(WebCore::ScrollableArea::setConstrainsScrollingToContentEdge):
Move constrains scrolling bit to ScrollableArea from ScrollView.

(WebCore::ScrollableArea::contentsSize):
(WebCore::ScrollableArea::overhangAmount):
Add additional virtual functions for information needed by the animator.

  • platform/mac/ScrollAnimatorMac.h:
  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::ScrollAnimatorMac):
(WebCore::ScrollAnimatorMac::immediateScrollByDeltaX):
(WebCore::ScrollAnimatorMac::immediateScrollByDeltaY):
(WebCore::elasticDeltaForTimeDelta):
(WebCore::elasticDeltaForReboundDelta):
(WebCore::reboundDeltaForElasticDelta):
(WebCore::scrollWheelMultiplier):
(WebCore::ScrollAnimatorMac::handleWheelEvent):
(WebCore::ScrollAnimatorMac::handleGestureEvent):
(WebCore::ScrollAnimatorMac::pinnedInDirection):
(WebCore::ScrollAnimatorMac::allowsVerticalStretching):
(WebCore::ScrollAnimatorMac::allowsHorizontalStretching):
(WebCore::ScrollAnimatorMac::smoothScrollWithEvent):
(WebCore::ScrollAnimatorMac::beginScrollGesture):
(WebCore::ScrollAnimatorMac::endScrollGesture):
(WebCore::ScrollAnimatorMac::snapRubberBand):
(WebCore::roundTowardZero):
(WebCore::roundToDevicePixelTowardZero):
(WebCore::ScrollAnimatorMac::snapRubberBandTimerFired):
Implement basic rubber banding.

11:05 Changeset [76955] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

Adding tests broken on Windows 7 Release in 76853,76856,76858 to the Skipped list to get the
Windows 7 Release Bot green. Unreviewed.
https://bugs.webkit.org/show_bug.cgi?id=53302

  • platform/win/Skipped:
11:00 BuildingQtOnSymbian edited by siddharth.mathur@nokia.com
use --minimal only if you have to (test what you ship) (diff)
10:46 Changeset [76954] by mitz@apple.com
  • 3 edits
    4 adds in trunk

Changing unicode-bidi doesn’t force layout
https://bugs.webkit.org/show_bug.cgi?id=53311

Reviewed by Anders Carlsson.

Source/WebCore:

Test: fast/dynamic/unicode-bidi.html

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::diff): Return a layout difference if unicode-bidi values differ.

LayoutTests:

  • fast/dynamic/unicode-bidi-expected.checksum: Added.
  • fast/dynamic/unicode-bidi-expected.png: Added.
  • fast/dynamic/unicode-bidi-expected.txt: Added.
  • fast/dynamic/unicode-bidi.html: Added.
10:44 Changeset [76953] by jberlin@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

Add Windows expected (failing) results to get the bots green. Unreviewed.
https://bugs.webkit.org/show_bug.cgi?id=53310

  • platform/win/fast/dom/window-domurl-crash-expected.txt: Added.
10:16 Changeset [76952] by jberlin@webkit.org
  • 1 edit
    4 adds in trunk/LayoutTests

Check in Windows-specific expected results to get the bots green. Unreviewed.
https://bugs.webkit.org/show_bug.cgi?id=53307

  • platform/win/fast/multicol: Added.
  • platform/win/fast/multicol/vertical-rl: Added.
  • platform/win/fast/multicol/vertical-rl/column-break-with-balancing-expected.txt: Added.
  • platform/win/fast/multicol/vertical-rl/float-paginate-complex-expected.txt: Added.
09:52 Changeset [76951] by dglazkov@chromium.org
  • 9 edits in trunk/Source/WebCore

2011-01-27 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Kent Tamura.

Change HTMLInputElement-derived parts of media element shadow DOM to use shadowPseudoId.
https://bugs.webkit.org/show_bug.cgi?id=53122

This is the first step in converting HTMLMediaElement to the new shadow DOM.

Should not regress any existing tests. No observable change in behavior.

  • css/CSSSelector.cpp: (WebCore::CSSSelector::pseudoId): Removed now-unnecessary hard-coded pseudo-element selectors. (WebCore::nameToPseudoTypeMap): Ditto. (WebCore::CSSSelector::extractPseudoType): Ditto.
  • css/CSSSelector.h: Ditto.
  • css/mediaControls.css: Added proper initial values, now that elements use the proper selector pipeline.
  • rendering/MediaControlElements.cpp: (WebCore::MediaControlInputElement::MediaControlInputElement): Removed the switch statement,

which is now replaced with virtual shadowPseudoId on each corresponding class.

(WebCore::MediaControlInputElement::styleForElement): Changed to use element pipeline.
(WebCore::MediaControlMuteButtonElement::MediaControlMuteButtonElement): Changed to set

display type in constructor.

(WebCore::MediaControlMuteButtonElement::create): Changed to not take PseudoId as

constructor argument.

(WebCore::MediaControlMuteButtonElement::shadowPseudoId): Added.
(WebCore::MediaControlVolumeSliderMuteButtonElement::MediaControlVolumeSliderMuteButtonElement): Added

to disambiguate from the MediaControlMuteButtonElement.

(WebCore::MediaControlVolumeSliderMuteButtonElement::create): Added.
(WebCore::MediaControlVolumeSliderMuteButtonElement::shadowPseudoId): Added.
(WebCore::MediaControlPlayButtonElement::MediaControlPlayButtonElement): Changed to not take PseudoId as

constructor argument.

(WebCore::MediaControlPlayButtonElement::shadowPseudoId): Added.
(WebCore::MediaControlSeekButtonElement::MediaControlSeekButtonElement): Changed to not take PseudoId as

constructor argument.

(WebCore::MediaControlSeekForwardButtonElement::MediaControlSeekForwardButtonElement): Added.
(WebCore::MediaControlSeekForwardButtonElement::create): Added.
(WebCore::MediaControlSeekForwardButtonElement::shadowPseudoId): Added.
(WebCore::MediaControlSeekBackButtonElement::MediaControlSeekBackButtonElement): Added.
(WebCore::MediaControlSeekBackButtonElement::create): Added.
(WebCore::MediaControlSeekBackButtonElement::shadowPseudoId): Added.
(WebCore::MediaControlRewindButtonElement::MediaControlRewindButtonElement): Added.
(WebCore::MediaControlRewindButtonElement::shadowPseudoId): Added.
(WebCore::MediaControlReturnToRealtimeButtonElement::MediaControlReturnToRealtimeButtonElement): Changed to not take PseudoId as

constructor argument.

(WebCore::MediaControlReturnToRealtimeButtonElement::shadowPseudoId): Added.
(WebCore::MediaControlToggleClosedCaptionsButtonElement::MediaControlToggleClosedCaptionsButtonElement): Changed to not take PseudoId as

constructor argument.

(WebCore::MediaControlToggleClosedCaptionsButtonElement::shadowPseudoId): Added.
(WebCore::MediaControlTimelineElement::MediaControlTimelineElement): Changed to not take PseudoId as

constructor argument.

(WebCore::MediaControlTimelineElement::shadowPseudoId): Added.
(WebCore::MediaControlVolumeSliderElement::MediaControlVolumeSliderElement): Changed to not take PseudoId as

constructor argument.

(WebCore::MediaControlVolumeSliderElement::shadowPseudoId): Added.
(WebCore::MediaControlFullscreenButtonElement::MediaControlFullscreenButtonElement): Changed to not take PseudoId as

constructor argument.

(WebCore::MediaControlFullscreenButtonElement::shadowPseudoId): Added.

  • rendering/MediaControlElements.h: (WebCore::MediaControlSeekForwardButtonElement::isForwardButton): Added. (WebCore::MediaControlSeekBackButtonElement::isForwardButton): Added.
  • rendering/RenderMedia.cpp: (WebCore::RenderMedia::createMuteButton): Changed to use new constructor. (WebCore::RenderMedia::createSeekBackButton): Ditto. (WebCore::RenderMedia::createSeekForwardButton): Ditto. (WebCore::RenderMedia::createVolumeSliderMuteButton): Ditto.
  • rendering/style/RenderStyleConstants.h: Removed constants that are no longer used.
09:11 Changeset [76950] by dglazkov@chromium.org
  • 13 edits
    2 copies in trunk/Source/WebCore

2011-01-27 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Eric Carlson.

Split MediaControls out of RenderMedia.
https://bugs.webkit.org/show_bug.cgi?id=53252

Near-mechanical moving of stuff, no change in behavior, thus no new tests.

  • Android.mk: Added MediaControls to build system.
  • CMakeLists.txt: Ditto.
  • GNUmakefile.am: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::defaultEventHandler): Changed to forward events to MediaControls.
  • html/shadow/MediaControls.cpp: Copied all controls-related methods from

Source/WebCore/rendering/RenderMedia.cpp, pulled them into their own class called MediaControls.

  • html/shadow/MediaControls.h: Ditto from Source/WebCore/rendering/RenderMedia.h.
  • rendering/MediaControlElements.cpp: (WebCore::MediaControlTimelineElement::defaultEventHandler): Changed to use MediaControls.
  • rendering/RenderMedia.cpp: (WebCore::RenderMedia::RenderMedia): Moved relevant constructor initializers out to MediaControls. (WebCore::RenderMedia::destroy): Changed to use MediaControls. (WebCore::RenderMedia::styleDidChange): Ditto. (WebCore::RenderMedia::layout): Ditto. (WebCore::RenderMedia::updateFromElement): Ditto.
  • rendering/RenderMedia.h: Updated defs accordingly and removed player() accessor, which

is only used by sub-class RenderVideo.

(WebCore::RenderMedia::controls): Added.

  • rendering/RenderVideo.cpp: (WebCore::RenderVideo::~RenderVideo): Changed to access MediaPlayer* directly from mediaElement(). (WebCore::RenderVideo::calculateIntrinsicSize): Ditto. (WebCore::RenderVideo::paintReplaced): Ditto. (WebCore::RenderVideo::updatePlayer): Ditto. (WebCore::RenderVideo::supportsAcceleratedRendering): Ditto. (WebCore::RenderVideo::acceleratedRenderingStateChanged): Ditto.
09:05 Changeset [76949] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

2011-01-28 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r76942.
http://trac.webkit.org/changeset/76942
https://bugs.webkit.org/show_bug.cgi?id=53301

Unskipped tests keep failing on GTK release bots (Requested by
svillar on #webkit).

  • platform/gtk/Skipped:
09:01 Changeset [76948] by jberlin@webkit.org
  • 1 edit
    4 adds in trunk/LayoutTests

Add Windows expected (failing) results to get the bots green. Unreviewed.
https://bugs.webkit.org/show_bug.cgi?id=53304

  • platform/win/editing/pasteboard/get-data-text-plain-paste-expected.txt: Added.
  • platform/win/editing/pasteboard/onpaste-text-html-expected.txt: Added.
  • platform/win/fast/events/drag-and-drop-dataTransfer-types-nocrash-expected.txt: Added.
  • platform/win/fast/events/ondrop-text-html-expected.txt: Added.
08:56 Changeset [76947] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-01-28 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: allow remote debugging with front-end
served from the cloud.
https://bugs.webkit.org/show_bug.cgi?id=53303

  • inspector/front-end/inspector.js:
08:33 Changeset [76946] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-01-28 Aparna Nandyal <aparna.nand@wipro.com>

Reviewed by Andreas Kling.

Setting value of m_PressedPos to make scrolling smooth

Page scroll popup menu "Scroll here" option not working when cliking above scroll slider/handler.
https://bugs.webkit.org/show_bug.cgi?id=51349

The value of m_PressedPos was getting set before moveThumb() call
in all other scenarios except when "Scroll Here" option is used.
Hence scrolling with this option was not as expected even in cases
where scrolling was happening. The thumb would move in unexpected
direction. m_PressedPos is now set to pressed position so delta is
calculated.
Unable to write a test case as the test needs to click on "Scroll
Here" option of context sensitive menu and QTest is unable to do it.
Besides no new functionality introduced.

  • platform/qt/ScrollbarQt.cpp: (WebCore::Scrollbar::contextMenu):
08:28 BuildingQtOnSymbian edited by siddharth.mathur@nokia.com
(diff)
08:27 BuildingQtOnSymbian edited by siddharth.mathur@nokia.com
(diff)
08:24 BuildingQtOnSymbian edited by siddharth.mathur@nokia.com
--minimal now works on Symbian , added 64-bit linker notes for RVCT4.x, … (diff)
08:06 Changeset [76945] by caseq@chromium.org
  • 1 edit
    1 add in trunk/Source/WebCore

2011-01-28 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Extensions API] add JSON schema for extensions API
https://bugs.webkit.org/show_bug.cgi?id=53236

  • inspector/front-end/ExtensionAPISchema.json: Added.
07:56 WebKit Team edited by joone.hur@collabora.co.uk
Add myself to committer list (diff)
07:51 Changeset [76944] by zmo@google.com
  • 9 edits in trunk

2011-01-27 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Remove _LENGTH enumerants
https://bugs.webkit.org/show_bug.cgi?id=53259

  • html/canvas/WebGLRenderingContext.cpp: Remove queries for *LENGTH. (WebCore::WebGLRenderingContext::getProgramParameter): (WebCore::WebGLRenderingContext::getShaderParameter):
  • html/canvas/WebGLRenderingContext.idl: Remove *LENGTH.

2011-01-27 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Remove _LENGTH enumerants
https://bugs.webkit.org/show_bug.cgi?id=53259

  • fast/canvas/webgl/constants.html:
  • fast/canvas/webgl/gl-getshadersource-expected.txt:
  • fast/canvas/webgl/gl-getshadersource.html:
  • fast/canvas/webgl/gl-object-get-calls-expected.txt:
  • fast/canvas/webgl/gl-object-get-calls.html:
07:48 Changeset [76943] by apavlov@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-01-28 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: syntax highlight inline JS and CSS in HTML resources
https://bugs.webkit.org/show_bug.cgi?id=30831

  • inspector/front-end/SourceHTMLTokenizer.js: (WebInspector.SourceHTMLTokenizer): (WebInspector.SourceHTMLTokenizer.prototype.set line): (WebInspector.SourceHTMLTokenizer.prototype.nextToken):
  • inspector/front-end/SourceHTMLTokenizer.re2js:
07:12 Changeset [76942] by sergio@webkit.org
  • 2 edits in trunk/LayoutTests

2011-01-28 Sergio Villar Senin <svillar@igalia.com>

Unreviewed.

Unskipped some tests. They're not failing anymore.

  • platform/gtk/Skipped:
07:07 Changeset [76941] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-01-28 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [STYLES] Up/Down-suggestion breaks an existing keyword
https://bugs.webkit.org/show_bug.cgi?id=53295

Select the current word suffix before switching to the next suggestion.

  • inspector/front-end/StylesSidebarPane.js: ():
06:34 Changeset [76940] by alex@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

2011-01-28 Alejandro G. Castro <alex@igalia.com>

Reviewed by Xan Lopez.

[GTK] Fix compilation warning
https://bugs.webkit.org/show_bug.cgi?id=53292

  • webkit/webkitwebframe.cpp: (draw_page_callback): Cast the pageCount from size_t to int, it should be safe considering page_nr is the number of pages, 0-based.
06:27 Changeset [76939] by mnaganov@chromium.org
  • 3 edits in branches/chromium/648

Merge 76795 - 2011-01-27 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Closure and Global variable details automatically collapsing on each step through JavaScript code.
https://bugs.webkit.org/show_bug.cgi?id=53234

  • inspector/debugger-expand-scope.html:
  • inspector/debugger-proto-property.html:

2011-01-27 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Closure and Global variable details automatically collapsing on each step through JavaScript code.
https://bugs.webkit.org/show_bug.cgi?id=53234

  • inspector/front-end/ScopeChainSidebarPane.js: (WebInspector.ScopeChainSidebarPane): (WebInspector.ScopeChainSidebarPane.prototype.update):

TBR=podivilov@chromium.org
Review URL: http://codereview.chromium.org/6397012

06:24 Changeset [76938] by mnaganov@chromium.org
  • 3 edits in branches/chromium/648

Merge 76788 - 2011-01-27 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Elements panel] Tooltip for relative links incorrectly identifies current URL
https://bugs.webkit.org/show_bug.cgi?id=53171

WebCore:

  • inspector/front-end/inspector.js: (WebInspector.completeURL): Taught to understand partial href's that start with "?" (contain GET parameters only)

LayoutTests:

  • inspector/styles-url-linkify-expected.txt:
  • inspector/styles-url-linkify.html:

TBR=apavlov@chromium.org
Review URL: http://codereview.chromium.org/6327025

06:19 Changeset [76937] by mnaganov@chromium.org
  • 1 edit in branches/chromium/648/Source/WebCore/bindings/v8/V8Proxy.cpp

Merge 76786 - 2011-01-27 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

[V8] Crash in WebCore::addMessageToConsole
https://bugs.webkit.org/show_bug.cgi?id=53227

  • bindings/v8/V8Proxy.cpp: check that the Frame where the error occured still has a page before getting a console object from it. (WebCore::V8Proxy::reportUnsafeAccessTo):

TBR=yurys@chromium.org
Review URL: http://codereview.chromium.org/6324018

06:19 Changeset [76936] by alex@webkit.org
  • 4 edits in trunk/Source

2011-01-28 Alejandro G. Castro <alex@igalia.com>

Reviewed by Xan Lopez.

[GTK] Fix dist compilation for the release
https://bugs.webkit.org/show_bug.cgi?id=53290

  • GNUmakefile.am: Added inspector files to the extra dist.

2011-01-28 Alejandro G. Castro <alex@igalia.com>

Reviewed by Xan Lopez.

[GTK] Fix dist compilation for the release
https://bugs.webkit.org/show_bug.cgi?id=53290

  • GNUmakefile.am: Remove a file that is not in the repository anymore.
06:16 Changeset [76935] by mnaganov@chromium.org
  • 1 edit in branches/chromium/648/Source/WebCore/inspector/front-end/ObjectPropertiesSection.js

Merge 76692 - 2011-01-26 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: visualize \n in strings as unicode cr
symbol in stack variables sidebar.
https://bugs.webkit.org/show_bug.cgi?id=53162

  • inspector/front-end/ObjectPropertiesSection.js: (WebInspector.ObjectPropertyTreeElement.prototype.update):

TBR=pfeldman@chromium.org
Review URL: http://codereview.chromium.org/6390007

06:07 Changeset [76934] by mnaganov@chromium.org
  • 12 edits in branches/chromium/648/Source/WebCore/inspector

Merge 76680 - 2011-01-26 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Incorrect on-hover evaluation of a variable named 'profile'.
https://bugs.webkit.org/show_bug.cgi?id=53018

  • inspector/InjectedScript.cpp: (WebCore::InjectedScript::evaluate): (WebCore::InjectedScript::evaluateOnCallFrame): (WebCore::InjectedScript::getCompletions): (WebCore::InjectedScript::getCompletionsOnCallFrame):
  • inspector/InjectedScript.h:
  • inspector/InjectedScriptSource.js: (.):
  • inspector/Inspector.idl:
  • inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::evaluateOnCallFrame): (WebCore::InspectorDebuggerAgent::getCompletionsOnCallFrame):
  • inspector/InspectorDebuggerAgent.h:
  • inspector/InspectorRuntimeAgent.cpp: (WebCore::InspectorRuntimeAgent::evaluate): (WebCore::InspectorRuntimeAgent::getCompletions):
  • inspector/InspectorRuntimeAgent.h:
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.completions): (WebInspector.ConsoleView.prototype.evalInInspectedWindow): (WebInspector.ConsoleView.prototype._enterKeyPressed):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame.updatingCallbackWrapper): (WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._showPopup):
  • inspector/front-end/WatchExpressionsSidebarPane.js: (WebInspector.WatchExpressionsSection.prototype.update):

TBR=pfeldman@chromium.org
Review URL: http://codereview.chromium.org/6320021

06:02 Changeset [76933] by mnaganov@chromium.org
  • 1 edit in branches/chromium/648/Source/WebCore/inspector/front-end/HeapSnapshotView.js

Merge 76514 - 2011-01-21 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Chromium] Fix heap snapshot table sorting.

Fix table sorting to avoid qsort instability artefacts.

https://bugs.webkit.org/show_bug.cgi?id=52914

  • inspector/front-end/HeapSnapshotView.js: (WebInspector.HeapSnapshotView.prototype._sortData): (WebInspector.HeapSnapshotDataGridList.propertyComparator.comparator): (WebInspector.HeapSnapshotDataGridList.propertyComparator):

TBR=mnaganov@chromium.org
Review URL: http://codereview.chromium.org/6405002

05:54 Changeset [76932] by mnaganov@chromium.org
  • 1 edit in branches/chromium/648/Source/WebCore/inspector/front-end/NetworkPanel.js

Merge 76483 - 2011-01-23 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: summary bar is not resized properly with the rest of net
https://bugs.webkit.org/show_bug.cgi?id=52881

  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype.updateSidebarWidth): (WebInspector.NetworkPanel.prototype._positionSummaryBar): (WebInspector.NetworkPanel.prototype._toggleGridMode):

TBR=caseq@chromium.org
Review URL: http://codereview.chromium.org/6366026

05:16 Changeset [76931] by andreas.kling@nokia.com
  • 3 edits in trunk/Source/WebKit2

2011-01-28 Andreas Kling <kling@webkit.org>

Rubber-stamped by Simon Hausmann.

[Qt][WK2] Combine QWKPage::engine{Connected,Disconnected} into one signal.

Having two signals for this is redundant, combine them into
QWKPage::engineConnectionChanged(bool connected).

  • UIProcess/API/qt/qwkpage.cpp: (QWKPagePrivate::didRelaunchProcess): (QWKPagePrivate::processDidCrash):
  • UIProcess/API/qt/qwkpage.h:
05:06 Changeset [76930] by zoltan@webkit.org
  • 3 edits in trunk/Tools

[Qt] Add Zoom Text Only action to MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=53297

Reviewed by Andreas Kling.

Add Zoom Text Only action to MiniBrowser's view menu, change zoom levels to avoid unnecessary divides.

  • MiniBrowser/qt/BrowserWindow.cpp:

(BrowserWindow::BrowserWindow):
(BrowserWindow::zoomIn):
(BrowserWindow::zoomOut):
(BrowserWindow::resetZoom):
(BrowserWindow::toggleZoomTextOnly):
(BrowserWindow::applyZoom):

  • MiniBrowser/qt/BrowserWindow.h:
04:46 Changeset [76929] by commit-queue@webkit.org
  • 6 edits in trunk/Source

2011-01-28 Ilya Sherman <isherman@chromium.org>

Reviewed by Andreas Kling.

Const-correct HTMLSelectElement and WebSelectElement
https://bugs.webkit.org/show_bug.cgi?id=53293

  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::value): const.
  • html/HTMLSelectElement.h:

2011-01-28 Ilya Sherman <isherman@chromium.org>

Reviewed by Andreas Kling.

Const-correct HTMLSelectElement and WebSelectElement
https://bugs.webkit.org/show_bug.cgi?id=53293

  • public/WebSelectElement.h:
  • src/WebSelectElement.cpp: (WebKit::WebSelectElement::value): const. (WebKit::WebSelectElement::listItems): const.
04:45 Changeset [76928] by podivilov@chromium.org
  • 4 edits in trunk/LayoutTests

2011-01-27 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: fix debugger-scripts.html (broken by r76587).
https://bugs.webkit.org/show_bug.cgi?id=53112

  • inspector/debugger-scripts-expected.txt:
  • inspector/debugger-scripts.html:
  • platform/chromium/test_expectations.txt:
03:25 Changeset [76927] by sergio@webkit.org
  • 2 edits in trunk/LayoutTests

2011-01-28 Sergio Villar Senin <svillar@igalia.com>

Unreviewed.

Adding media/video-controls-rendering.html to the Skipped list of tests.

  • platform/gtk/Skipped:
02:14 Changeset [76926] by abarth@webkit.org
  • 14 edits
    6 adds in trunk/Tools

2011-01-28 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add webkit-patch roll-chromium-deps
https://bugs.webkit.org/show_bug.cgi?id=53288

This command updates the Source/WebKit/chromium/DEPS file with the
last-known good revision of Chromium (or a revision specified on the
command line). I'd eventually like to turn this into a SheriffBot
command, but this is the first step.

This patch somewhat sprawled because I needed to move a bunch of code
out of ChangeLog that should never have been there in the first place.
Also, I had to fix a bug in MockUser in order to test the new command.

  • Scripts/webkitpy/common/checkout/api.py:
  • Scripts/webkitpy/common/checkout/changelog.py:
  • Scripts/webkitpy/common/checkout/changelog_unittest.py:
  • Scripts/webkitpy/common/checkout/deps.py: Added.
  • Scripts/webkitpy/common/config/urls.py:
  • Scripts/webkitpy/tool/commands/init.py:
  • Scripts/webkitpy/tool/commands/download_unittest.py:
  • Scripts/webkitpy/tool/commands/roll.py: Added.
  • Scripts/webkitpy/tool/commands/roll_unittest.py: Added.
  • Scripts/webkitpy/tool/commands/upload_unittest.py:
  • Scripts/webkitpy/tool/mocktool.py:
  • Scripts/webkitpy/tool/steps/init.py:
  • Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py: Added.
  • Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
  • Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py: Added.
  • Scripts/webkitpy/tool/steps/suggestreviewers_unittest.py:
  • Scripts/webkitpy/tool/steps/updatechromiumdeps.py: Added.
  • Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
01:10 Changeset [76925] by ossy@webkit.org
  • 5 edits in trunk/Source

Unreviewed, rolling out r76893.
http://trac.webkit.org/changeset/76893
https://bugs.webkit.org/show_bug.cgi?id=53287

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-01-28
It made some tests crash on GTK and Qt debug bots (Requested
by Ossy on #webkit).

Source/JavaScriptCore:

  • runtime/WeakGCMap.h:

Source/WebCore:

  • bridge/runtime_root.cpp:

(JSC::Bindings::RootObject::invalidate):
(JSC::Bindings::RootObject::addRuntimeObject):
(JSC::Bindings::RootObject::removeRuntimeObject):

  • bridge/runtime_root.h:
00:33 Changeset [76924] by commit-queue@webkit.org
  • 1 edit in trunk/ChangeLog

2010-01-28 Commit Queue <commit-queue@webkit.org>

Unreviewed. Test commit for commit-queue@webkit.org.

00:05 Changeset [76923] by commit-queue@webkit.org
  • 1 edit in trunk/ChangeLog

2010-01-28 Commit Queue <commit-queue@webkit.org>

Unreviewed. Test commit for commit-queue@webkit.org.

Note: See TracTimeline for information about the timeline view.