Timeline


and

02/02/11:

22:21 Changeset [77468] by commit-queue@webkit.org

2011-02-02 Chris Evans <cevans@chromium.org>

Reviewed by Darin Fisher.

window.find() can fail when switching case sensitivity
https://bugs.webkit.org/show_bug.cgi?id=53654

The test coverage for this area is very poor, so I took the liberty
of adding a more general test than is needed.

  • fast/text/find-window.html: Added.
  • fast/text/find-window-expected.txt: Added.

2011-02-02 Chris Evans <cevans@chromium.org>

Reviewed by Darin Fisher.

window.find() can fail when switching case sensitivity
https://bugs.webkit.org/show_bug.cgi?id=53654

Reset the pattern to a safe one when done, to avoid usearch_reset()
indirectly touching the old, stale text pointer.

Test: fast/text/find-window.html

  • editing/TextIterator.cpp: (WebCore::SearchBuffer::~SearchBuffer): leave a safe pattern buffer when done.
21:45 Changeset [77467] by abarth@webkit.org

2011-02-02 Adam Barth <abarth@webkit.org>

Reviewed by Daniel Bates.

Teach XSSFilter that <param> elements can contain URLs
https://bugs.webkit.org/show_bug.cgi?id=53652

When loading plugins for the <object> tag, we're "smart" enough to
reach into the <param> elements and pull out the URL in some cases.
This patch teaches the XSSFilter how to block injections into those
sorts of param elements.

Fixes:

http/tests/security/xssAuditor/object-*

  • html/HTMLParamElement.cpp: (WebCore::HTMLParamElement::isURLParameter): (WebCore::HTMLParamElement::isURLAttribute): (WebCore::HTMLParamElement::addSubresourceAttributeURLs):
  • html/HTMLParamElement.h:
    • Add a helper function so that HTMLParamElement can share the ground truth for these names with the XSSFilter.
  • html/parser/XSSFilter.cpp: (WebCore::XSSFilter::filterTokenInitial): (WebCore::XSSFilter::filterParamToken):
  • html/parser/XSSFilter.h:
21:41 Changeset [77466] by weinig@apple.com

Fix license block issues pointed out by Daniel Bates.

  • Shared/API/c/WKGraphicsContext.cpp:
  • Shared/API/c/WKGraphicsContext.h:
  • Shared/API/c/cg/WKGraphicsContextCG.cpp:
  • Shared/API/c/cg/WKGraphicsContextCG.h:
  • Shared/WebGraphicsContext.cpp:
21:17 Changeset [77465] by mrobinson@webkit.org

2011-02-02 Martin Robinson <mrobinson@igalia.com>

Rebaseline two tests after import of editing test results for GTK+.
Also remove a platform-specific baseline for a test which is now passing.

  • platform/gtk/editing/pasteboard/emacs-ctrl-a-k-y-expected.txt:
  • platform/gtk/editing/selection/find-yensign-and-backslash-expected.txt: Removed.
  • platform/gtk/fast/dom/52776-expected.txt:
20:40 Changeset [77464] by dglazkov@chromium.org

2011-02-02 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by David Levin.

GCC compiler on ARM issues bogus warnings and fails to compile.
https://bugs.webkit.org/show_bug.cgi?id=53620

Despite warnings explicitly being disallowed (-Wno-uninitialized),
gcc (Ubuntu 4.4.3-4ubuntu5) 4.4.3 throws up the warnings like:

"error: 'colorTransparent.unstatic.4909' may be used uninitialized in this function"

The fix is to add an extra condition, which somehow pacifies the compiler.

  • css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::createColor): Added workaround conditions.
20:35 Changeset [77463] by abarth@webkit.org

2011-02-02 Adam Barth <abarth@webkit.org>

Reviewed by Daniel Bates.

Teach XSSFilter about X-XSS-Protection
https://bugs.webkit.org/show_bug.cgi?id=53640

This patch causes us to pass:

http/tests/security/xssAuditor/full-block-*
http/tests/security/xssAuditor/no-protection-script-tag.html

  • html/parser/XSSFilter.cpp: (WebCore::XSSFilter::XSSFilter): (WebCore::XSSFilter::init): (WebCore::XSSFilter::filterToken):
  • html/parser/XSSFilter.h:
20:23 Changeset [77462] by abarth@webkit.org

2011-02-02 Adam Barth <abarth@webkit.org>

Reviewed by Daniel Bates.

When XSSFilter blocks JavaScript URLs, use a safe JavaScript URL
instead of the empty string
https://bugs.webkit.org/show_bug.cgi?id=53643

In a URL context, the empty string completes to the URL of the current
page, which causes these tests to go into an infinite loop. Instead,
we should use a "safe" JavaScript URL that does nothing.

Fixes:

http/tests/security/xssAuditor/javascript-link*

  • html/parser/XSSFilter.cpp: (WebCore::XSSFilter::eraseDangerousAttributesIfInjected):
20:13 Changeset [77461] by mitz@apple.com

<rdar://problem/8380506> REGRESSION (r61921): RTL text in <b> tag doesn't display in WebKit under certain conditions
https://bugs.webkit.org/show_bug.cgi?id=44942

Reviewed by Sam Weinig.

Source/WebCore:

Test: fast/text/bidi-embedding-pop-and-push-same-2.html

  • platform/text/BidiResolver.h:

(WebCore::::commitExplicitEmbedding): Changed to return a boolean indicating whether there was
a change to embedding levels.
(WebCore::::createBidiRunsForLine): If embedding levels did not change as a result of committing
the explicit embedding sequence, then runs were not added, and we should continue normally.

LayoutTests:

  • fast/text/bidi-embedding-pop-and-push-same-2-expected.checksum: Added.
  • fast/text/bidi-embedding-pop-and-push-same-2-expected.png: Added.
  • fast/text/bidi-embedding-pop-and-push-same-2-expected.txt: Added.
  • fast/text/bidi-embedding-pop-and-push-same-2.html: Added.
19:46 Changeset [77460] by weinig@apple.com

Add WKBundleFrameGetVisibleContentBoundsExcludingScrollbars API for WebKit2.

Reviewed by Dan Bernstein.

  • WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:

(WKBundleFrameGetContentBounds):
(WKBundleFrameGetVisibleContentBounds):
(WKBundleFrameGetVisibleContentBoundsExcludingScrollbars):
(WKBundleFrameGetScrollOffset):

  • WebProcess/InjectedBundle/API/c/WKBundleFrame.h:
  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::contentBounds):
(WebKit::WebFrame::visibleContentBounds):
(WebKit::WebFrame::visibleContentBoundsExcludingScrollbars):
(WebKit::WebFrame::scrollOffset):

  • WebProcess/WebPage/WebFrame.h:

Move implementation of frame geometry to the implementation file
instead of keeping it in the API file.

19:45 Changeset [77459] by weinig@apple.com

Fix miscalculation of the overhang area used for painting. We were
not correctly accounting for scrollbars resulting in an non-negative
overhang even when we weren't over the edge.

Reviewed by Dan Bernstein.

  • platform/ScrollView.cpp:

(WebCore::ScrollView::calculateOverhangAreasForPainting):

19:01 Changeset [77458] by kbr@google.com

2011-02-02 Kenneth Russell <kbr@google.com>

Reviewed by Mihai Parparita.

gl-teximage.html failing on some WebKit bots
https://bugs.webkit.org/show_bug.cgi?id=53633

  • fast/canvas/webgl/gl-teximage.html:
    • Synced with upstream test; detect when running in DRT and avoid printing the specific pixel value when the test will pass.
  • fast/canvas/webgl/resources/red-indexed.png:
    • Stripped gamma and other colorspace information.
18:39 Changeset [77457] by aestes@apple.com

'update-webkit' should handle OpenSource and Internal using different
VCSs.

Reviewed by Mark Rowe.

  • Scripts/update-webkit: Re-check the VCS type when updating Apple's

Internal directory.

18:24 Changeset [77456] by jorlow@chromium.org

2011-02-02 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Nate Chapin.

IDBTransaction and IDBRequest can be deleted while ScriptExecutionContext is iterating....which is bad
https://bugs.webkit.org/show_bug.cgi?id=52722

The solution is to change ScriptExecutionContext's destructor to iterate over
the list in a way that handles the mutations. This new method is destructive,
but that's OK since the object is going away. I've also added a several asserts.

There should be no behavior change.

  • dom/ScriptExecutionContext.cpp: (WebCore::ScriptExecutionContext::ScriptExecutionContext): (WebCore::ScriptExecutionContext::~ScriptExecutionContext): (WebCore::ScriptExecutionContext::canSuspendActiveDOMObjects): (WebCore::ScriptExecutionContext::suspendActiveDOMObjects): (WebCore::ScriptExecutionContext::resumeActiveDOMObjects): (WebCore::ScriptExecutionContext::stopActiveDOMObjects): (WebCore::ScriptExecutionContext::createdActiveDOMObject): (WebCore::ScriptExecutionContext::destroyedActiveDOMObject):
  • dom/ScriptExecutionContext.h:
  • storage/IDBTransaction.cpp: (WebCore::IDBTransaction::contextDestroyed):
  • storage/IDBTransaction.h:
18:11 Changeset [77455] by mrowe@apple.com

Build fix.

  • WebCore.exp.in: Remove some bogus symbols from the .exp.in file.
  • platform/mac/ScrollbarThemeMac.mm:

(WebCore::ScrollbarThemeMac::unregisterScrollbar): Look the object
up in the HashMap rather than relying on a local variable that doesn't
exist.

18:04 Changeset [77454] by abarth@webkit.org

2011-02-02 Adam Barth <abarth@webkit.org>

Reviewed by Daniel Bates.

Teach XSSFilter about JavaScript URLs
https://bugs.webkit.org/show_bug.cgi?id=53635

This patch teaches the XSSFilter to check for JavaScript URLs in
attribute values. If this approach has too many false positives, we
can restrict which attribute names we examine.

Fixes these tests:

http/tests/security/xssAuditor/anchor-url-dom-write-location-javascript-URL.html
http/tests/security/xssAuditor/dom-write-location-javascript-URL.html
http/tests/security/xssAuditor/iframe-javascript-url*

  • html/parser/XSSFilter.cpp: (WebCore::HTMLNames::containsJavaScriptURL): (WebCore::XSSFilter::filterTokenInitial): (WebCore::XSSFilter::eraseDangerousAttributesIfInjected):
  • html/parser/XSSFilter.h:
18:00 Changeset [77453] by mrobinson@webkit.org

2011-02-02 Martin Robinson <mrobinson@igalia.com>

Unskip the last batch of editing tests needing GTK+ results.

  • platform/gtk/Skipped: Unskip last batch of tests.
17:58 Changeset [77452] by slewis@apple.com

https://bugs.webkit.org/show_bug.cgi?id=53361
<rdar://problem/8921729> REGRESSION: Membuster accumulates 1GB+ memory due to autorelease
pools not being drained.
Call into AppKit to add observers that push and pop autorelease pools on entry
and exit from the CFRunLoop. This will prevent memory from accumulating.

Reviewed by Geoff Garen.

  • WebProcess/mac/WebProcessMainMac.mm:

(WebKit::WebProcessMain):

17:55 Changeset [77451] by mitz@apple.com

Build fix.

  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::~ScrollAnimatorMac):

17:54 Changeset [77450] by mrobinson@webkit.org

2011-02-02 Martin Robinson <mrobinson@igalia.com>

Add one more set of missing editing layout test results for GTK.

  • platform/gtk/Skipped: Unskip more editing tests.
17:51 Changeset [77449] by darin@apple.com

Make null WTF::String objects turn into 0 pointers for WKStringRef and WKURLRef.
rdar://problem/8948688

Reviewed by Sam Weinig.

  • Shared/API/c/WKSharedAPICast.h:

(WebKit::toAPI): Return 0 if the passed in string is 0.
(WebKit::toCopiedAPI): Ditto.
(WebKit::toURLRef): Ditto. Old code was trying to do this but was missing a return.
(WebKit::toCopiedURLAPI): Ditto. Old code was trying to do this but had incorrect
nll check.

  • Shared/WebString.h: Removed isNull function. It can never return true.

Removed constructor code that turns the null string into the empty string.
Instead assert that the passed in string is not null.

17:48 Changeset [77448] by barraclough@apple.com

Windows build fix.

17:36 Changeset [77447] by mrowe@apple.com

<rdar://problem/8928367> Crash when loading canvas pages inside HTMLCanvasElement::createImageBuffer().

Reviewed by Beth Dakin.

Source/WebKit/mac:

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface): Add some missing initializers.

Source/WebKit2:

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface): Add some missing initializers.

17:36 Changeset [77446] by mrowe@apple.com

<rdar://problem/8952012> Crash on launch inside scrollbar code.

Reviewed by Beth Dakin.

We need to ensure that we remove ourselves as the delegates of objects when we're going
away as failing to do this can lead to crashes if the lifetime of the other objects
is longer than ours.

  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::~ScrollAnimatorMac):

  • platform/mac/ScrollbarThemeMac.mm:

(WebCore::ScrollbarThemeMac::unregisterScrollbar):

17:36 Changeset [77445] by barraclough@apple.com

oops, build fix!

  • wtf/Assertions.cpp:
17:35 Changeset [77444] by mrobinson@webkit.org

2011-02-02 Martin Robinson <mrobinson@igalia.com>

Continue importing new editing layout test results for GTK.

  • platform/gtk/Skipped: Unskip more editing tests.
17:31 Changeset [77443] by barraclough@apple.com

Bug 53650 - Add a BACKTRACE macro to Assertions.h

Reviewed by Sam Weinig.

Add a BACKTRACE macro to Assertions.h, which will print a backtrace on
debug Mac builds, make CRASH (and thus ASSERT) automatically call this.

17:29 Changeset [77442] by bdakin@apple.com

Build fix.

  • WebCore.exp.in:
17:22 Changeset [77441] by alex@webkit.org

Add 1.3.11 WebKitGTK+ release

17:20 Changeset [77440] by mrobinson@webkit.org

2011-02-02 Martin Robinson <mrobinson@igalia.com>

Begin importing missing editing directory test results.

  • platform/gtk/Skipped: Unskip tests with results and classify failures.
17:17 Changeset [77439] by msaboff@apple.com

2011-02-02 Michael Saboff <msaboff@apple.com>

Reviewed by Gavin Barraclough.

Improper backtrack of nested non-capturing greedy paren to prior paren
https://bugs.webkit.org/show_bug.cgi?id=53261

A paren that follows a non-capturing greedy paren nested within a
non-capturing fixed paren was back tracking to the last paren
processed instead of the immediately prior paren.
Refactored default backtracking of parens to prior paren to work for
both nested (within) and immediately prior (after) parens.

  • yarr/YarrJIT.cpp: (JSC::Yarr::YarrGenerator::GenerationState::addParenthesesTail): (JSC::Yarr::YarrGenerator::TermGenerationState::TermGenerationState): (JSC::Yarr::YarrGenerator::TermGenerationState::setJumpListToPriorParen): (JSC::Yarr::YarrGenerator::TermGenerationState::getJumpListToPriorParen): (JSC::Yarr::YarrGenerator::ParenthesesTail::ParenthesesTail): (JSC::Yarr::YarrGenerator::ParenthesesTail::generateCode): (JSC::Yarr::YarrGenerator::generateParenthesesDisjunction): (JSC::Yarr::YarrGenerator::generateParenthesesSingle): (JSC::Yarr::YarrGenerator::generateDisjunction):

2011-02-02 Michael Saboff <msaboff@apple.com>

Reviewed by Gavin Barraclough.

Improper backtrack of nested non-capturing greedy paren to prior paren
https://bugs.webkit.org/show_bug.cgi?id=53261

New tests to validate change.

  • fast/regex/parentheses-expected.txt:
  • fast/regex/script-tests/parentheses.js:
17:14 Changeset [77438] by paroga@webkit.org

2011-02-02 Patrick Gansterer <paroga@webkit.org>

Unreviewed WinCE build fix for r77397.

  • page/wince/FrameWinCE.cpp: (WebCore::computePageRectsForFrame):
17:04 Changeset [77437] by paroga@webkit.org

2011-02-02 Patrick Gansterer <paroga@webkit.org>

Unreviewed WinCE build fix for r77398.

  • platform/graphics/wince/PlatformPathWinCE.cpp: (WebCore::containsPoint): (WebCore::inflateRectToContainPoint): (WebCore::PlatformPath::addRect):
  • platform/graphics/wince/SharedBitmap.cpp: (WebCore::SharedBitmap::drawPattern):
  • rendering/RenderThemeWinCE.cpp: (WebCore::RenderThemeWinCE::paintMenuListButton): (WebCore::RenderThemeWinCE::paintSearchFieldCancelButton): (WebCore::RenderThemeWinCE::paintSliderTrack): (WebCore::RenderThemeWinCE::paintMediaMuteButton): (WebCore::RenderThemeWinCE::paintMediaPlayButton): (WebCore::RenderThemeWinCE::paintMediaSeekBackButton): (WebCore::RenderThemeWinCE::paintMediaSeekForwardButton):

2011-02-02 Patrick Gansterer <paroga@webkit.org>

Unreviewed WinCE build fix for r77398.

  • WebView.cpp: (WebView::paint):
16:55 Changeset [77436] by eric@webkit.org

2011-02-02 Eric Seidel <eric@webkit.org>

Unreviewed. Just fixing an exception seen in Firefox.

HTML5 TreeBuilder regressed a Peacekeeper DOM test by 40%
https://bugs.webkit.org/show_bug.cgi?id=48719

Make the benchmarks work in Firefox/Opera.

  • resources/runner.js: (log):
16:55 Changeset [77435] by evan@chromium.org

2011-02-02 Evan Martin <evan@chromium.org>

Unreviewed, DEPS change.

  • DEPS: update to pick up newer Skia.
16:52 Changeset [77434] by dpranke@chromium.org

2011-02-02 Dirk Pranke <dpranke@chromium.org>

Reviewed by Mihai Parparita.

new-run-webkit-tests: hardcode the directories to scan for tests
for GPU bots instead of SKIPping them. See bug 53562 for some
context, but we will now hard-code the list of directories to
use by default instead of skipping over directories in the
expectations file. We do this so that we will be able to merge
the expectations files without getting conflicting SKIP
directives. Note that this change will reduce the # of tests
being run on the Mac GPU bots, because we're accidentally
including some today.

https://bugs.webkit.org/show_bug.cgi?id=53631

  • platform/chromium-gpu/test_expectations.txt:

2011-02-02 Dirk Pranke <dpranke@chromium.org>

Reviewed by Mihai Parparita.

new-run-webkit-tests: hardcode the directories to scan for tests
for GPU bots instead of SKIPping them. See bug 53562 for some
context, but we will now hard-code the list of directories to
use by default instead of skipping over directories in the
expectations file. We do this so that we will be able to merge
the expectations files without getting conflicting SKIP
directives. Note that this change will reduce the # of tests
being run on the Mac GPU bots, because we're accidentally
including some today.

https://bugs.webkit.org/show_bug.cgi?id=53631

  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
  • Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
16:52 Changeset [77433] by jianli@chromium.org

[V8] Accessing DataView with index of -1 returns 0, doesn't throw
https://bugs.webkit.org/show_bug.cgi?id=53559

Reviewed by Kenneth Russell.

Source/WebCore:

Added test cases to cover this in fast/canvas/webgl/data-view-test.html.

  • html/canvas/DataView.h:

(WebCore::DataView::beyondRange):

LayoutTests:

  • fast/canvas/webgl/data-view-test-expected.txt:
  • fast/canvas/webgl/data-view-test.html:
16:44 Changeset [77432] by weinig@apple.com

Add ChromeClient function to paint custom overhang areas.
https://bugs.webkit.org/show_bug.cgi?id=53639

Reviewed by Beth Dakin.

Source/WebCore:

  • page/Chrome.cpp:

(WebCore::ChromeClient::paintCustomOverhangArea):

  • page/ChromeClient.h:

Add ChromeClient function.

  • page/FrameView.cpp:

(WebCore::FrameView::paintOverhangAreas):

  • page/FrameView.h:

Call out the the ChromeClient, call ScrollView base implementation
if the ChromeClient returns false.

  • platform/ScrollView.cpp:

(WebCore::ScrollView::paintOverhangAreas):

  • platform/ScrollView.h:

Add dirty rect for use when painting overhang areas.

Source/WebKit2:

  • Shared/API/c/WKBase.h:
  • Shared/API/c/WKGraphicsContext.cpp: Added.

(WKGraphicsContextGetTypeID):

  • Shared/API/c/WKGraphicsContext.h: Added.
  • Shared/API/c/WKSharedAPICast.h:
  • Shared/API/c/cg/WKGraphicsContextCG.cpp: Added.

(WKGraphicsContextGetCGContext):

  • Shared/API/c/cg/WKGraphicsContextCG.h: Added.
  • Shared/APIObject.h:
  • Shared/WebGraphicsContext.cpp: Added.

(WebKit::WebGraphicsContext::WebGraphicsContext):

  • Shared/WebGraphicsContext.h: Added.

(WebKit::WebGraphicsContext::create):
(WebKit::WebGraphicsContext::platformContext):
(WebKit::WebGraphicsContext::type):
Add WebGraphicsContext API type.

  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:

(WebKit::InjectedBundlePageUIClient::pageDidScroll):
(WebKit::InjectedBundlePageUIClient::shouldPaintCustomOverhangArea):
(WebKit::InjectedBundlePageUIClient::paintCustomOverhangArea):

  • WebProcess/InjectedBundle/InjectedBundlePageUIClient.h:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::paintCustomOverhangArea):

  • WebProcess/WebCoreSupport/WebChromeClient.h:

Pipe paintCustomOverhangArea to the InjectedBundlePageUIClient.

  • UIProcess/API/C/WebKit2.h:
  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:
  • win/WebKit2Generated.make:

Add new files.

Tools:

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::InjectedBundlePage):
Stub out new callback.

16:33 Changeset [77431] by dpranke@chromium.org

2011-02-02 Dirk Pranke <dpranke@chromium.org>

Reviewed by Tony Chang.

new-run-webkit-tests: support chromium code paths in mock_drt

https://bugs.webkit.org/show_bug.cgi?id=53471

  • Scripts/webkitpy/layout_tests/port/mock_drt.py:
  • Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
16:16 Changeset [77430] by andersca@apple.com

2011-02-02 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Work towards making the layer tree host be in charge of all painting
https://bugs.webkit.org/show_bug.cgi?id=53636

Make sure that DrawingAreaImpl::display is never called when in accelerated compositing mode,
since the layer tree host is supposed to handle all drawing in that case.

  • WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::scroll): (WebKit::DrawingAreaImpl::setRootCompositingLayer): (WebKit::DrawingAreaImpl::setSize): (WebKit::DrawingAreaImpl::didUpdate):
15:58 Changeset [77429] by pkasting@chromium.org

Not reviewed, build fix.

Fix compile after r77427.
https://bugs.webkit.org/show_bug.cgi?id=53455

  • platform/graphics/qt/ImageDecoderQt.cpp:

(WebCore::ImageDecoderQt::internalHandleCurrentImage):

  • platform/image-decoders/ImageDecoder.cpp:

(WebCore::ImageFrame::operator=):

  • platform/image-decoders/bmp/BMPImageReader.cpp:

(WebCore::BMPImageReader::decodeBMP):

  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp:

(WebCore::JPEGImageDecoder::outputScanlines):

  • platform/image-decoders/png/PNGImageDecoder.cpp:

(WebCore::PNGImageDecoder::rowAvailable):

  • platform/image-decoders/webp/WEBPImageDecoder.cpp:

(WebCore::WEBPImageDecoder::decode):

15:39 Changeset [77428] by mrowe@apple.com

Fix the 32-bit build.

  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:

(WebKit::computeFakeWindowBoundsRect):

15:34 Changeset [77427] by commit-queue@webkit.org

2011-02-02 Peter Kasting <pkasting@google.com>

Reviewed by David Levin.

Clean up ImageDecoder's comments (remove/trim/clarify).
https://bugs.webkit.org/show_bug.cgi?id=53455

This also renames or eliminates a couple of functions for clarity, and
switches a couple erroneous strncmp() calls to memcmp().

  • platform/image-decoders/ImageDecoder.cpp: (WebCore::ImageDecoder::create): (WebCore::ImageFrame::clearPixelData): (WebCore::ImageFrame::zeroFillPixelData): (WebCore::ImageFrame::setSize):
  • platform/image-decoders/ImageDecoder.h: (WebCore::ImageFrame::originalFrameRect): (WebCore::ImageFrame::setOriginalFrameRect): (WebCore::ImageDecoder::ImageDecoder): (WebCore::ImageDecoder::~ImageDecoder): (WebCore::ImageDecoder::isSizeAvailable): (WebCore::ImageDecoder::size): (WebCore::ImageDecoder::setIgnoreGammaAndColorProfile): (WebCore::ImageDecoder::clearFrameBufferCache): (WebCore::ImageDecoder::isOverSize):
  • platform/image-decoders/bmp/BMPImageReader.cpp: (WebCore::BMPImageReader::processNonRLEData):
  • platform/image-decoders/cg/ImageDecoderCG.cpp: (WebCore::ImageFrame::setSize):
  • platform/image-decoders/gif/GIFImageDecoder.cpp: (WebCore::GIFImageDecoder::clearFrameBufferCache): (WebCore::GIFImageDecoder::frameComplete): (WebCore::GIFImageDecoder::initFrameBuffer):
  • platform/image-decoders/jpeg/JPEGImageDecoder.h:
  • platform/image-decoders/qt/ImageFrameQt.cpp: (WebCore::ImageFrame::operator=): (WebCore::ImageFrame::clearPixelData): (WebCore::ImageFrame::zeroFillPixelData): (WebCore::ImageFrame::setSize):
  • platform/image-decoders/skia/ImageDecoderSkia.cpp: (WebCore::ImageFrame::operator=): (WebCore::ImageFrame::clearPixelData): (WebCore::ImageFrame::zeroFillPixelData): (WebCore::ImageFrame::setSize):
  • platform/image-decoders/webp/WEBPImageDecoder.h:
15:32 Changeset [77426] by eric@webkit.org

2011-01-27 Eric Seidel <eric@webkit.org>

Reviewed by Darin Adler.

HTML5 TreeBuilder regressed a Peacekeeper DOM test by 40%
https://bugs.webkit.org/show_bug.cgi?id=48719

It's unclear exactly what the Peacekeeper benchmark is testing,
because I haven't found a way to run it myself.

However, I constructed a benchmark which shows at least one possible slow point.
The HTML5 spec talks about creating a new document for every time we use
the fragment parsing algorithm. Document() it turns out, it a huge bloated
mess, and the constructor and destructor do a huge amount of work.

  • benchmarks/parser/tiny-innerHTML.html: Added.
15:08 Changeset [77425] by vangelis@chromium.org

2011-02-02 Vangelis Kokkevis <vangelis@chromium.org>

[chromium] Adding support for reflections to the accelerated
compositing path.
https://bugs.webkit.org/show_bug.cgi?id=53179

All layout tests in compositing/reflections generate correct
results with the exception of:

  1. nested-reflection-anchor-point.html : There appears to be some issue with the layer transform math that I haven't been able to track down yet.
  2. reflection-opacity.html : The current implementation applies opacity before doing the reflection which makes this test produce incorrect results. This will affect reflected layers with opacity that overlap their original layer. FIXME comment added in the code.

Tests: Covered by existing layout tests in compositing/reflections.

Please see above for exceptions.

  • platform/graphics/chromium/GraphicsLayerChromium.cpp: (WebCore::GraphicsLayerChromium::setReplicatedByLayer): (WebCore::GraphicsLayerChromium::updateAnchorPoint):
  • platform/graphics/chromium/GraphicsLayerChromium.h:
  • platform/graphics/chromium/LayerChromium.cpp: (WebCore::LayerChromium::LayerChromium):
  • platform/graphics/chromium/LayerChromium.h: (WebCore::LayerChromium::setReplicaLayer): (WebCore::LayerChromium::replicaLayer):
  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::updateLayersRecursive): (WebCore::LayerRendererChromium::drawLayer):
  • platform/graphics/chromium/RenderSurfaceChromium.cpp: (WebCore::RenderSurfaceChromium::drawableContentRect): (WebCore::RenderSurfaceChromium::drawSurface): (WebCore::RenderSurfaceChromium::draw):
  • platform/graphics/chromium/RenderSurfaceChromium.h: (WebCore::RenderSurfaceChromium::drawTransform):
14:45 Changeset [77424] by commit-queue@webkit.org

2011-02-02 Xiyuan Xia <xiyuan@chromium.org>

Reviewed by Tony Chang.

[Chromium] Select popup with padding has white strip on right
https://bugs.webkit.org/show_bug.cgi?id=53602

No new tests as this change restores old behavior.

  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupListBox::layout):
14:45 Changeset [77423] by andersca@apple.com

Make sure that we don't try to call display() when in accelerated compositing mode
https://bugs.webkit.org/show_bug.cgi?id=53629

Reviewed by Sam Weinig.

When in accelerated compositing mode, the layer tree host should handle all painting, so make sure that display() is never called.

  • WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::setNeedsDisplay):
(WebKit::DrawingAreaImpl::setRootCompositingLayer):
(WebKit::DrawingAreaImpl::display):

14:43 Changeset [77422] by bdakin@apple.com

Fix for <rdar://problem/8950343> CrashTracer: [USER]
1 crash in WebProcess at com.apple.WebCore:
WebCore::ScrollbarThemeMac::unregisterScrollbar + 22

Reviewed by Mark Rowe.

It is possible for a Scrollbar's ScrollableArea to be null,
so we must null check.

  • platform/mac/ScrollbarThemeMac.mm:

(WebCore::ScrollbarThemeMac::registerScrollbar):
(WebCore::ScrollbarThemeMac::unregisterScrollbar):

14:39 Changeset [77421] by zmo@google.com

2011-02-02 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

bufferData and bufferSubData should generate INVALID_VALUE with negative input
https://bugs.webkit.org/show_bug.cgi?id=53626

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::bufferData): (WebCore::WebGLRenderingContext::bufferSubData):

2011-02-02 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

bufferData and bufferSubData should generate INVALID_VALUE with negative input
https://bugs.webkit.org/show_bug.cgi?id=53626

  • fast/canvas/webgl/buffer-data-array-buffer-expected.txt:
  • fast/canvas/webgl/buffer-data-array-buffer.html:
14:34 Changeset [77420] by aroben@apple.com

Add DerivedSources.make to some Visual Studio projects

https://bugs.webkit.org/show_bug.cgi?id=53607

Patch by Jeff Miller <jeffm@apple.com> on 2011-02-02
Reviewed by Darin Adler and Steve Falkenburg.

Source/JavaScriptCore:

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.vcproj: Add DerivedSources.make.

Source/WebCore:

  • WebCore.vcproj/WebCoreGenerated.vcproj: Add DerivedSources.make.
14:33 Changeset [77419] by aroben@apple.com

Assert WebBackForwardList's current index is valid to help catch errors

Hopefully this will help catch a crash I saw once but haven't yet been able to reproduce.

Fixes <http://webkit.org/b/53622>.

Reviewed by Brady Eidson.

  • UIProcess/WebBackForwardList.cpp:

(WebKit::WebBackForwardList::WebBackForwardList):
(WebKit::WebBackForwardList::addItem):
(WebKit::WebBackForwardList::goToItem):
(WebKit::WebBackForwardList::currentItem):
(WebKit::WebBackForwardList::backItem):
(WebKit::WebBackForwardList::forwardItem):
(WebKit::WebBackForwardList::itemAtIndex):
(WebKit::WebBackForwardList::backListCount):
(WebKit::WebBackForwardList::forwardListCount):
(WebKit::WebBackForwardList::backListAsImmutableArrayWithLimit):
(WebKit::WebBackForwardList::forwardListAsImmutableArrayWithLimit):
(WebKit::WebBackForwardList::clear):

  • UIProcess/cf/WebBackForwardListCF.cpp:

(WebKit::WebBackForwardList::createCFDictionaryRepresentation):
(WebKit::WebBackForwardList::restoreFromCFDictionaryRepresentation):
Assert that m_current is valid.

  • UIProcess/WebBackForwardList.h: Moved the NoCurrentItemIndex to a static data member so

that it can be used from WebBackForwardListCF.cpp.

14:25 Changeset [77418] by inferno@chromium.org

2011-02-02 Cris Neckar <cdn@chromium.org>

Reviewed by James Robinson.

Tests for crash when a domwindow is removed within a device orientation event.
https://bugs.webkit.org/show_bug.cgi?id=53623

  • fast/events/device-orientation-crash-expected.txt: Added.
  • fast/events/device-orientation-crash.html: Added.

2011-02-02 Cris Neckar <cdn@chromium.org>

Reviewed by James Robinson.

Refcount domwindows when dispatching device orientation events.
https://bugs.webkit.org/show_bug.cgi?id=53623

Test: fast/events/device-orientation-crash.html

  • dom/DeviceMotionController.cpp: (WebCore::DeviceMotionController::timerFired): (WebCore::DeviceMotionController::didChangeDeviceMotion):
  • dom/DeviceMotionController.h:
  • dom/DeviceOrientationController.cpp: (WebCore::DeviceOrientationController::timerFired): (WebCore::DeviceOrientationController::didChangeDeviceOrientation):
  • dom/DeviceOrientationController.h:
14:13 Changeset [77417] by zmo@google.com

2011-02-02 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

A deleted object should never been bound again
https://bugs.webkit.org/show_bug.cgi?id=53604

  • fast/canvas/webgl/object-deletion-behaviour-expected.txt:
  • fast/canvas/webgl/object-deletion-behaviour.html: Add test cases for object binding and deletion.

2011-02-02 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

A deleted object should never been bound again
https://bugs.webkit.org/show_bug.cgi?id=53604

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::checkObjectToBeBound): Helper function to bind* and useProgram. (WebCore::WebGLRenderingContext::bindBuffer): Use checkObjectToBeBound. (WebCore::WebGLRenderingContext::bindFramebuffer): Ditto. (WebCore::WebGLRenderingContext::bindRenderbuffer): Ditto. (WebCore::WebGLRenderingContext::bindTexture): Ditto, also check the target matching. (WebCore::WebGLRenderingContext::deleteObject): Helper funtion to delete*. (WebCore::WebGLRenderingContext::deleteBuffer): Use deleteObject. (WebCore::WebGLRenderingContext::deleteFramebuffer): Ditto. (WebCore::WebGLRenderingContext::deleteProgram): Ditto. (WebCore::WebGLRenderingContext::deleteRenderbuffer): Ditto. (WebCore::WebGLRenderingContext::deleteShader): Ditto. (WebCore::WebGLRenderingContext::deleteTexture): Ditto. (WebCore::WebGLRenderingContext::useProgram): Use checkObjectToBeBound.
  • html/canvas/WebGLRenderingContext.h:
  • html/canvas/WebGLTexture.h: (WebCore::WebGLTexture::getTarget): Accessor to cached target.
14:06 Changeset [77416] by alex@webkit.org

2011-02-02 Alejandro G. Castro <alex@igalia.com>

Unreviewed Efl buildfix after r77399.

  • CMakeListsEfl.txt:
13:59 Changeset [77415] by commit-queue@webkit.org

2011-02-02 Adam Klein <adamk@chromium.org>

Reviewed by Tony Chang.

Update new-run-webkit-tests --chromium to put output under Source/...
https://bugs.webkit.org/show_bug.cgi?id=53612

  • BuildSlaveSupport/test-result-archive:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
13:49 Changeset [77414] by alex@webkit.org

2011-02-02 Alejandro G. Castro <alex@igalia.com>

Reviewed by Martin Robinson.

Update the NEWS file in preparation for the 1.3.11 release.

  • NEWS: Update the NEWS.

2011-02-02 Alejandro G. Castro <alex@igalia.com>

Reviewed by Martin Robinson.

Bump the WebKitGTK+ versions in preparation for development release.

  • configure.ac: Bump the library, libtool and user agent version.
13:49 Changeset [77413] by andersca@apple.com

2011-02-02 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

The drawing area proxy should keep track of the accelerated compositing state
https://bugs.webkit.org/show_bug.cgi?id=53624

  • UIProcess/DrawingAreaProxyImpl.cpp: (WebKit::DrawingAreaProxyImpl::DrawingAreaProxyImpl): Initialize m_isInAcceleratedCompositingMode to false.

(WebKit::DrawingAreaProxyImpl::paint):
Don't try to paint if we're in accelerated compositing mode.

(WebKit::DrawingAreaProxyImpl::didSetSize):
Bail if we're in accelerated compositing mode.

(WebKit::DrawingAreaProxyImpl::enterAcceleratedCompositingMode):
Set m_isInAcceleratedCompositingMode to true, null out the backing store.

(WebKit::DrawingAreaProxyImpl::exitAcceleratedCompositingMode):
Set m_isInAcceleratedCompositingMode back to false.

(WebKit::DrawingAreaProxyImpl::incorporateUpdate):
Assert that we're not in accelerated compositing mode.

  • UIProcess/DrawingAreaProxyImpl.h:
13:37 Changeset [77412] by kbr@google.com

2011-02-02 Kenneth Russell <kbr@google.com>

Reviewed by James Robinson.

Rename Typed Array subset to subarray
https://bugs.webkit.org/show_bug.cgi?id=53618

  • fast/canvas/webgl/array-setters.html:
  • fast/canvas/webgl/array-unit-tests-expected.txt:
  • fast/canvas/webgl/array-unit-tests.html:
  • fast/canvas/webgl/draw-elements-out-of-bounds-expected.txt:
  • fast/canvas/webgl/draw-elements-out-of-bounds.html:
  • fast/canvas/webgl/webgl-array-invalid-ranges-expected.txt:
  • fast/canvas/webgl/webgl-array-invalid-ranges.html:

2011-02-02 Kenneth Russell <kbr@google.com>

Reviewed by James Robinson.

Rename Typed Array subset to subarray
https://bugs.webkit.org/show_bug.cgi?id=53618

  • html/canvas/Float32Array.cpp: (WebCore::Float32Array::subarray):
  • html/canvas/Float32Array.h:
  • html/canvas/Float32Array.idl:
  • html/canvas/Int16Array.cpp: (WebCore::Int16Array::subarray):
  • html/canvas/Int16Array.h:
  • html/canvas/Int16Array.idl:
  • html/canvas/Int32Array.cpp: (WebCore::Int32Array::subarray):
  • html/canvas/Int32Array.h:
  • html/canvas/Int32Array.idl:
  • html/canvas/Int8Array.cpp: (WebCore::Int8Array::subarray):
  • html/canvas/Int8Array.h:
  • html/canvas/Int8Array.idl:
  • html/canvas/TypedArrayBase.h: (WebCore::TypedArrayBase::subarrayImpl):
  • html/canvas/Uint16Array.cpp: (WebCore::Uint16Array::subarray):
  • html/canvas/Uint16Array.h:
  • html/canvas/Uint16Array.idl:
  • html/canvas/Uint32Array.cpp: (WebCore::Uint32Array::subarray):
  • html/canvas/Uint32Array.h:
  • html/canvas/Uint32Array.idl:
  • html/canvas/Uint8Array.cpp: (WebCore::Uint8Array::subarray):
  • html/canvas/Uint8Array.h:
  • html/canvas/Uint8Array.idl:
13:30 Changeset [77411] by abarth@webkit.org

2011-02-02 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add an empty file for Content Security Policy
https://bugs.webkit.org/show_bug.cgi?id=53573

Posting this as a separate patch because editing the build files is so
painful.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
13:23 Changeset [77410] by tony@chromium.org

2011-01-28 Tony Chang <tony@chromium.org>

Reviewed by Eric Seidel.

[chromium] remove --use-test-shell from NRWT
https://bugs.webkit.org/show_bug.cgi?id=53346

I've already started removing some of the bindings like eventSender so
this already doesn't work isn't useful. Also updated some comments to
refer to DRT instead of test_shell.

  • Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/test_types/text_diff.py:
13:19 Changeset [77409] by timothy@apple.com

Give the Web Process access to the Safari RSS preferences.

<rdar://problem/8916870> Sandbox violation related to RSS during initial
page load with WebKit2 (prevents RSS from working)

Reviewed by Darin Adler.

  • WebProcess/com.apple.WebProcess.sb:
13:19 Changeset [77408] by mrobinson@webkit.org

2011-02-02 Dan Winship <danw@gnome.org>

Reviewed by Martin Robinson.

[GTK] remove old data: URI handler, fix the SoupRequest-based one
to pass tests
https://bugs.webkit.org/show_bug.cgi?id=50885

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::sendRequestCallback): Do content-type sniffing here for non-HTTP requests. (WebCore::startHTTPRequest): Rename to match WebKit style. (WebCore::ResourceHandle::start): Pass everything except HTTP to startNonHTTPRequest, letting the SoupRequester decide whether it's supported or not. (WebCore::startNonHTTPRequest): Remove some old pre-SoupRequester code that was a no-op for file: URIs, but would break some data: URIs.
13:18 Changeset [77407] by dglazkov@chromium.org

2011-02-02 Dimitri Glazkov <dglazkov@chromium.org>

Update even more references to right() and bottom() in Chromium. Sheesh.

  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::getFramebufferPixels): Replaced bottom/right with maxY/maxX.
13:12 Changeset [77406] by dglazkov@chromium.org

2011-02-02 Dimitri Glazkov <dglazkov@chromium.org>

Update more references to right() and bottom() in Chromium.

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::doPixelReadbackToCanvas): Replaced bottom/right with maxY/maxX.
13:03 Changeset [77405] by alex@webkit.org

2011-02-02 Alejandro G. Castro <alex@igalia.com>

Unreviewed Gtk3 buildfix after r77286.

https://bugs.webkit.org/show_bug.cgi?id=53520
Remove the physical terminology from IntRect and FloatRect.

  • platform/gtk/RenderThemeGtk3.cpp: (WebCore::RenderThemeGtk::paintMenuList):
13:01 Changeset [77404] by andersca@apple.com

Fix build.

  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::pinnedInDirection):

12:59 Changeset [77403] by hyatt@apple.com

https://bugs.webkit.org/show_bug.cgi?id=53619

Reviewed by Dan Bernstein.

Floats should not use physical terminology for their rects. Replace left/top with x/y and right/bottom
with maxX/maxY. This matches IntRect.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::addOverflowFromFloats):
(WebCore::RenderBlock::flipFloatForWritingMode):
(WebCore::RenderBlock::paintFloats):
(WebCore::RenderBlock::selectionGaps):
(WebCore::RenderBlock::addOverhangingFloats):
(WebCore::RenderBlock::addIntrudingFloats):
(WebCore::RenderBlock::hitTestFloats):
(WebCore::RenderBlock::adjustForBorderFit):

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::FloatingObject::x):
(WebCore::RenderBlock::FloatingObject::maxX):
(WebCore::RenderBlock::FloatingObject::y):
(WebCore::RenderBlock::FloatingObject::maxY):
(WebCore::RenderBlock::FloatingObject::setX):
(WebCore::RenderBlock::FloatingObject::setY):
(WebCore::RenderBlock::logicalTopForFloat):
(WebCore::RenderBlock::logicalBottomForFloat):
(WebCore::RenderBlock::logicalLeftForFloat):
(WebCore::RenderBlock::logicalRightForFloat):
(WebCore::RenderBlock::setLogicalTopForFloat):
(WebCore::RenderBlock::setLogicalLeftForFloat):
(WebCore::RenderBlock::xPositionForFloatIncludingMargin):
(WebCore::RenderBlock::yPositionForFloatIncludingMargin):

12:54 Changeset [77402] by dglazkov@chromium.org

2011-02-02 Dimitri Glazkov <dglazkov@chromium.org>

Update more references to right() and bottom() in Chromium Win.

  • platform/graphics/chromium/TransparencyWin.cpp: (WebCore::TransparencyWin::compositeOpaqueComposite): Replaced bottom/right with maxY/maxX. (WebCore::TransparencyWin::compositeTextComposite): Ditto.
  • rendering/RenderThemeChromiumWin.cpp: (WebCore::RenderThemeChromiumWin::paintMenuList): Ditto.

2011-02-02 Dimitri Glazkov <dglazkov@chromium.org>

Update more references to right() and bottom() in Chromium Win.

  • tests/TransparencyWinTest.cpp: (WebCore::TEST): Replaced bottom/right with maxY/maxX.
12:33 Changeset [77401] by aroben@apple.com

Encode/decode FormData and FormDataElement objects consistently

Fixes <http://webkit.org/b/53615> <rdar://problem/8943346> WebKit2: Restoring session state
that contains form data fails (asserts in Debug build)

To prevent this from interfering with WebKit2 testing, it's useful to get this into a build
now, even though we don't have an automated test for it yet. Writing a test is covered by
<http://webkit.org/b/53616>.

Reviewed by Darin Adler.

  • history/HistoryItem.cpp: Bump the encoding version, since this patch changes how we encode

FormData objects.

  • platform/network/FormData.cpp:

(WebCore::decode): Decode the type from the Decoder, rather than getting it from the
default-constructed FormDataElement. Failing to do this meant that all future uses of the
Decoder would be reading from an unexpected part of the buffer (i.e., the next decode would
start by reading the uint32_t that we forgot to decode here, and so on). We already had code
to correctly set the FormDataElement's type based on this decoded type later in the
function.
(WebCore::FormData::encodeForBackForward): Encode m_identifier as an int64_t, since that
matches its type and how we decode it.

12:25 Changeset [77400] by kbr@google.com

2011-02-02 Matthew Vosburgh <maf@chromium.org>

Reviewed by Kenneth Russell.

Some favicons not correctly decoded by Chromium/Mac
https://bugs.webkit.org/show_bug.cgi?id=53448

  • src/WebImageCG.cpp: (WebKit::WebImage::fromData):
12:24 Changeset [77399] by mrobinson@webkit.org

2011-02-02 Dan Winship <danw@gnome.org>

Reviewed by Martin Robinson.

[GTK] drop soup cache stuff, which has been moved to libsoup
https://bugs.webkit.org/show_bug.cgi?id=50747

Use libsoup-based cache/requester API and remove the WebCore version
of this functionality. This has been pushed upstream fully.

No new tests because this should not change functionality.

  • GNUmakefile.am: Update for removed files.
  • platform/network/ResourceHandleInternal.h: (WebCore::ResourceHandleInternal::ResourceHandleInternal): Update type names, drop m_requester.
  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ensureSessionIsInitialized): Add a SoupRequester to the session. (WebCore::parseDataUrl): (WebCore::startHttp): Get the requester from the session rather than using m_requester. (WebCore::sendRequestCallback): (WebCore::ResourceHandle::platformSetDefersLoading): (WebCore::readCallback): (WebCore::startGio): Update type names.
  • platform/network/soup/cache/soup-directory-input-stream.c: Removed.
  • platform/network/soup/cache/soup-directory-input-stream.h: Removed.
  • platform/network/soup/cache/soup-http-input-stream.c: Removed.
  • platform/network/soup/cache/soup-http-input-stream.h: Removed.
  • platform/network/soup/cache/soup-request-data.c: Removed.
  • platform/network/soup/cache/soup-request-data.h: Removed.
  • platform/network/soup/cache/soup-request-file.c: Removed.
  • platform/network/soup/cache/soup-request-file.h: Removed.
  • platform/network/soup/cache/soup-request-http.c: Removed.
  • platform/network/soup/cache/soup-request-http.h: Removed.
  • platform/network/soup/cache/soup-request.c: Removed.
  • platform/network/soup/cache/soup-request.h: Removed.
  • platform/network/soup/cache/soup-requester.c: Removed.
  • platform/network/soup/cache/soup-requester.h: Removed.
  • platform/network/soup/cache/webkit/soup-cache-private.h: Removed.
  • platform/network/soup/cache/webkit/soup-cache.c: Removed.
  • platform/network/soup/cache/webkit/soup-cache.h: Removed.

2011-02-02 Dan Winship <danw@gnome.org>

Reviewed by Martin Robinson.

[GTK] drop soup cache stuff, which has been moved to libsoup
https://bugs.webkit.org/show_bug.cgi?id=50747

  • GNUmakefile.am: Remove old cache files.
12:20 Changeset [77398] by hyatt@apple.com

https://bugs.webkit.org/show_bug.cgi?id=53520

Reviewed by Darin Adler.

Remove physical accessors from IntRect and FloatRect.

  • page/FrameView.cpp:

(WebCore::FrameView::adjustPageHeightDeprecated):

  • platform/graphics/FloatRect.h:
  • platform/graphics/IntRect.h:
12:19 Changeset [77397] by hyatt@apple.com

https://bugs.webkit.org/show_bug.cgi?id=53614

Reviewed by Dan Bernstein.

Remove physical terminology from overflow. Replace with minX/maxX/minY/maxY.

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::addBoxShadowVisualOverflow):
(WebCore::InlineFlowBox::addTextBoxVisualOverflow):

  • rendering/InlineFlowBox.h:

(WebCore::InlineFlowBox::minYLayoutOverflow):
(WebCore::InlineFlowBox::maxYLayoutOverflow):
(WebCore::InlineFlowBox::minXLayoutOverflow):
(WebCore::InlineFlowBox::maxXLayoutOverflow):
(WebCore::InlineFlowBox::logicalLeftLayoutOverflow):
(WebCore::InlineFlowBox::logicalRightLayoutOverflow):
(WebCore::InlineFlowBox::logicalTopLayoutOverflow):
(WebCore::InlineFlowBox::logicalBottomLayoutOverflow):
(WebCore::InlineFlowBox::minYVisualOverflow):
(WebCore::InlineFlowBox::maxYVisualOverflow):
(WebCore::InlineFlowBox::minXVisualOverflow):
(WebCore::InlineFlowBox::maxXVisualOverflow):
(WebCore::InlineFlowBox::logicalLeftVisualOverflow):
(WebCore::InlineFlowBox::logicalRightVisualOverflow):
(WebCore::InlineFlowBox::logicalminYVisualOverflow):
(WebCore::InlineFlowBox::logicalmaxYVisualOverflow):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::adjustLinePositionForPagination):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::beforeSideVisualOverflowForLine):
(WebCore::RenderBlock::afterSideVisualOverflowForLine):
(WebCore::RenderBlock::beforeSideLayoutOverflowForLine):
(WebCore::RenderBlock::afterSideLayoutOverflowForLine):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::scrollWidth):
(WebCore::RenderBox::scrollHeight):

  • rendering/RenderBox.h:

(WebCore::RenderBox::minYLayoutOverflow):
(WebCore::RenderBox::maxYLayoutOverflow):
(WebCore::RenderBox::minXLayoutOverflow):
(WebCore::RenderBox::maxXLayoutOverflow):
(WebCore::RenderBox::logicalLeftLayoutOverflow):
(WebCore::RenderBox::logicalRightLayoutOverflow):
(WebCore::RenderBox::minYVisualOverflow):
(WebCore::RenderBox::maxYVisualOverflow):
(WebCore::RenderBox::minXVisualOverflow):
(WebCore::RenderBox::maxXVisualOverflow):
(WebCore::RenderBox::logicalLeftVisualOverflow):
(WebCore::RenderBox::logicalRightVisualOverflow):

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::linesVisualOverflowBoundingBox):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::ensureRootPlatformLayer):

  • rendering/RenderLineBoxList.cpp:

(WebCore::RenderLineBoxList::anyLineIntersectsRect):
(WebCore::RenderLineBoxList::lineIntersectsDirtyRect):
(WebCore::RenderLineBoxList::paint):
(WebCore::RenderLineBoxList::hitTest):

  • rendering/RenderMarquee.cpp:

(WebCore::RenderMarquee::computePosition):

  • rendering/RenderOverflow.h:

(WebCore::RenderOverflow::RenderOverflow):
(WebCore::RenderOverflow::minYLayoutOverflow):
(WebCore::RenderOverflow::maxYLayoutOverflow):
(WebCore::RenderOverflow::minXLayoutOverflow):
(WebCore::RenderOverflow::maxXLayoutOverflow):
(WebCore::RenderOverflow::minYVisualOverflow):
(WebCore::RenderOverflow::maxYVisualOverflow):
(WebCore::RenderOverflow::minXVisualOverflow):
(WebCore::RenderOverflow::maxXVisualOverflow):
(WebCore::RenderOverflow::setminYVisualOverflow):
(WebCore::RenderOverflow::visualOverflowRect):
(WebCore::RenderOverflow::move):
(WebCore::RenderOverflow::addVisualOverflow):
(WebCore::RenderOverflow::setVisualOverflow):

  • rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::shouldPaint):

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::layout):
(WebCore::RenderTable::paint):

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::clippedOverflowRectForRepaint):

  • rendering/RenderTreeAsText.cpp:

(WebCore::writeLayers):

  • rendering/RenderView.cpp:

(WebCore::RenderView::docTop):

12:07 Changeset [77396] by dglazkov@chromium.org

2011-02-02 Dimitri Glazkov <dglazkov@chromium.org>

Added GPU fails from bots.

  • platform/chromium-gpu/test_expectations.txt: Added.
11:58 Changeset [77395] by dglazkov@chromium.org

2011-02-02 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Dave Hyatt.

Remove remaining references to right() and bottom() from Chromium build.
https://bugs.webkit.org/show_bug.cgi?id=53613

  • src/DragScrollTimer.cpp: (WebKit::distanceToRect): Replaced right/bottom with maxX/maxY.
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::doPixelReadbackToCanvas): Ditto.
11:56 Changeset [77394] by dbates@webkit.org

2011-02-02 Steve Lacey <sjl@chromium.org>

Reviewed by Eric Carlson.

Implement basic media statistics on media elements.
https://bugs.webkit.org/show_bug.cgi?id=53322

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:

2011-02-02 Steve Lacey <sjl@chromium.org>

Reviewed by Eric Carlson.

Implement basic media statistics on media elements.
https://bugs.webkit.org/show_bug.cgi?id=53322

  • configure.ac:

2011-02-02 Steve Lacey <sjl@chromium.org>

Reviewed by Eric Carlson.

Implement basic media statistics on media elements.
https://bugs.webkit.org/show_bug.cgi?id=53322

  • Scripts/build-webkit:

2011-02-02 Steve Lacey <sjl@chromium.org>

Reviewed by Eric Carlson.

Implement basic media statistics on media elements.
https://bugs.webkit.org/show_bug.cgi?id=53322

  • Configurations/FeatureDefines.xcconfig:

2011-02-02 Steve Lacey <sjl@chromium.org>

Reviewed by Eric Carlson.

Implement basic media statistics on media elements.
https://bugs.webkit.org/show_bug.cgi?id=53322

  • Configurations/FeatureDefines.xcconfig:

2011-02-02 Steve Lacey <sjl@chromium.org>

Reviewed by Eric Carlson.

Implement basic media statistics on media elements.
https://bugs.webkit.org/show_bug.cgi?id=53322

  • Configurations/FeatureDefines.xcconfig:
  • GNUmakefile.am:
  • features.pri:
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::webkitAudioBytesDecoded): (WebCore::HTMLMediaElement::webkitVideoBytesDecoded):
  • html/HTMLMediaElement.h:
  • html/HTMLMediaElement.idl:
  • html/HTMLVideoElement.cpp: (WebCore::HTMLVideoElement::webkitDecodedFrames): (WebCore::HTMLVideoElement::webkitDroppedFrames):
  • html/HTMLVideoElement.h:
  • html/HTMLVideoElement.idl:
  • platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::decodedFrames): (WebCore::MediaPlayer::droppedFrames): (WebCore::MediaPlayer::audioBytesDecoded): (WebCore::MediaPlayer::videoBytesDecoded):
  • platform/graphics/MediaPlayer.h:
  • platform/graphics/MediaPlayerPrivate.h: (WebCore::MediaPlayerPrivateInterface::decodedFrames): (WebCore::MediaPlayerPrivateInterface::droppedFrames): (WebCore::MediaPlayerPrivateInterface::audioBytesDecoded): (WebCore::MediaPlayerPrivateInterface::videoBytesDecoded):

2011-02-02 Steve Lacey <sjl@chromium.org>

Reviewed by Eric Carlson.

Implement basic media statistics on media elements.
https://bugs.webkit.org/show_bug.cgi?id=53322

  • Configurations/FeatureDefines.xcconfig:
11:40 Changeset [77393] by luiz@webkit.org

2011-02-02 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by David Hyatt.

More conversion from right()/bottom() to maxX()/maxY().

  • page/qt/FrameQt.cpp: (WebCore::Frame::dragImageForSelection):
  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::roundToDevicePixels):
11:34 Changeset [77392] by kevino@webkit.org

[wx] Build fixes for wxWebKit.

11:21 Changeset [77391] by ggaren@apple.com

2011-02-01 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

A little more Heap refactoring
https://bugs.webkit.org/show_bug.cgi?id=53577


SunSpider reports no change.


Split out MarkedBlock into its own file / class.


Did the following renames:

isCellMarked => isMarked
checkMarkCell => testAndSetMarked
markCell => setMarked
cellOffset => cellNumber
collectorBlock => blockFor

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • JavaScriptCore.gypi:
  • JavaScriptCore.pro:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • runtime/Heap.cpp: (JSC::WeakGCHandlePool::update):
  • runtime/Heap.h: (JSC::Heap::isMarked): (JSC::Heap::testAndSetMarked): (JSC::Heap::setMarked):
  • runtime/JSArray.h: (JSC::MarkStack::markChildren): (JSC::MarkStack::drain):
  • runtime/JSCell.h: (JSC::JSCell::MarkStack::internalAppend):
  • runtime/MarkedBlock.cpp: Added.
  • runtime/MarkedBlock.h: Added. (JSC::MarkedBlock::blockFor): (JSC::MarkedBlock::cellNumber): (JSC::MarkedBlock::isMarked): (JSC::MarkedBlock::testAndSetMarked): (JSC::MarkedBlock::setMarked): (JSC::MarkedBlock::isCellAligned): (JSC::MarkedBlock::isPossibleCell):
  • runtime/MarkedSpace.h: (JSC::MarkedSpace::isMarked): (JSC::MarkedSpace::testAndSetMarked): (JSC::MarkedSpace::setMarked):
  • runtime/SmallStrings.cpp: (JSC::isMarked):
  • runtime/WeakGCMap.h: (JSC::WeakGCMap::isValid): (JSC::::get): (JSC::::take): (JSC::::set):
11:13 Changeset [77390] by hyatt@apple.com

More right()/bottom() to maxX()/maxY() conversion.

Reviewed by Darin Adler.

  • page/chromium/FrameChromium.cpp:

(WebCore::Frame::nodeImage):
(WebCore::Frame::dragImageForSelection):

11:00 Changeset [77389] by weinig@apple.com

Fix windows clean build.

../JavaScriptCore:

  • DerivedSources.make:

../WebCore:

  • DerivedSources.make:
10:56 Changeset [77388] by mrobinson@webkit.org

2011-02-02 Martin Robinson <mrobinson@igalia.com>

Unskip a test that just needs platform-specific results. Re-classify
two other failures with more pertinent information.

  • platform/gtk/Skipped: Organize the skipped list a bit. Unskip a test. Remove obsolete comments.
  • platform/gtk/editing/inserting/5994480-2-expected.txt: Added.
10:55 Changeset [77387] by mnaganov@chromium.org

2011-02-02 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Chromium] Landing detailed heap snapshots, part 2.

https://bugs.webkit.org/show_bug.cgi?id=53606

Display progress while taking a snapshot, and hints while loading
and parsing. This is needed because taking detailed heap snapshots
takes time.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/DetailedHeapshotView.js: (WebInspector.DetailedHeapshotProfileType.prototype.buttonClicked):
  • inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype._reset): (WebInspector.ProfilesPanel.prototype._addProfileHeader): (WebInspector.ProfilesPanel.prototype.getProfiles): (WebInspector.ProfilesPanel.prototype.loadHeapSnapshot): (WebInspector.ProfilesPanel.prototype._finishHeapSnapshot.doParse): (WebInspector.ProfilesPanel.prototype._finishHeapSnapshot): (WebInspector.ProfilesPanel.prototype.takeHeapSnapshot): (WebInspector.ProfilesPanel.prototype._reportHeapSnapshotProgress):
  • inspector/front-end/SidebarTreeElement.js: (WebInspector.SidebarTreeElement.prototype.refreshTitles):
10:51 Changeset [77386] by ap@apple.com

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=53561
<rdar://problem/8900228> Stepping through print previews in WebKit2 mode steps in and out of
printing mode a lot

Disable NSView autodisplay, so that -[WKView drawRect:] isn't called (other than when
resizing the window), so that we don't have to switch modes all the time.

  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm: (WebKit::PageClientImpl::setAutodisplay):
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::setAutodisplay):
  • UIProcess/WebPageProxy.h: Pipe the call from WKPrintingView down to WKView.
  • UIProcess/API/mac/WKPrintingView.mm: (-[WKPrintingView beginDocument]): Added. We don't want to autodisplay WKView while printing, because layout is changed to print at the time, and drawing to screen requires relayout.


(-[WKPrintingView endDocument]): When not printing, turn autodisplay back on. Also, call
-[super endDocument] for unknown but definitive good (oops!).

10:35 Changeset [77385] by hyatt@apple.com

More conversion from right()/bottom() to maxX()/maxY().

Reviewed by Darin Adler.

  • platform/win/PopupMenuWin.cpp:

(WebCore::PopupMenuWin::calculatePositionAndSize):
(WebCore::PopupMenuWin::paint):

10:32 Changeset [77384] by hyatt@apple.com

Removal of right()/bottom(). Replace with maxX() and maxY(). Still converting. Haven't removed yet.

Reviewed by Darin Adler.

  • platform/chromium/PopupMenuChromium.cpp:

(WebCore::PopupContainer::layoutAndCalculateWidgetRect):
(WebCore::PopupListBox::scrollToRevealRow):
(WebCore::PopupListBox::layout):

  • platform/graphics/FloatRect.h:
  • platform/graphics/IntRect.h:
  • platform/graphics/cairo/ImageBufferCairo.cpp:

(WebCore::getImageData):
(WebCore::putImageData):

  • platform/graphics/chromium/GLES2Canvas.cpp:

(WebCore::GLES2Canvas::drawTexturedRect):

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::verticalScrollbarRect):
(WebCore::LayerRendererChromium::horizontalScrollbarRect):
(WebCore::LayerRendererChromium::setScissorToRect):
(WebCore::LayerRendererChromium::setDrawViewportRect):

  • platform/graphics/chromium/LayerTilerChromium.cpp:

(WebCore::LayerTilerChromium::contentRectToTileIndices):
(WebCore::LayerTilerChromium::growLayerToContain):

  • platform/graphics/gpu/TilingData.cpp:

(WebCore::TilingData::tileBoundsWithBorder):
(WebCore::TilingData::overlappedTileIndices):

  • platform/graphics/qt/ImageBufferQt.cpp:

(WebCore::getImageData):
(WebCore::putImageData):

  • platform/graphics/skia/FloatRectSkia.cpp:

(WebCore::FloatRect::operator SkRect):

  • platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::getImageData):
(WebCore::putImageData):

  • platform/graphics/skia/IntRectSkia.cpp:

(WebCore::IntRect::operator SkIRect):
(WebCore::IntRect::operator SkRect):

  • platform/graphics/skia/PlatformContextSkia.cpp:

(WebCore::PlatformContextSkia::beginLayerClippedToImage):

  • platform/graphics/win/GraphicsContextWin.cpp:

(WebCore::GraphicsContextPlatformPrivate::clip):

  • platform/graphics/win/IntRectWin.cpp:

(WebCore::IntRect::operator RECT):

  • platform/graphics/win/UniscribeController.cpp:

(WebCore::UniscribeController::shapeAndPlaceItem):

  • platform/graphics/wince/GraphicsContextWinCE.cpp:

(WebCore::roundRect):
(WebCore::mapRect):
(WebCore::TransparentLayerDC::TransparentLayerDC):
(WebCore::GraphicsContext::drawRect):
(WebCore::GraphicsContext::drawEllipse):
(WebCore::GraphicsContext::strokeArc):
(WebCore::GraphicsContext::clip):
(WebCore::GraphicsContext::clipOut):
(WebCore::GraphicsContext::strokeRect):

  • platform/image-decoders/gif/GIFImageDecoder.cpp:

(WebCore::GIFImageDecoder::initFrameBuffer):

  • platform/win/PopupMenuWin.cpp:

(WebCore::PopupMenuWin::calculatePositionAndSize):
(WebCore::PopupMenuWin::paint):

  • plugins/win/PluginViewWin.cpp:

(WebCore::PluginView::updatePluginWidget):
(WebCore::PluginView::invalidateRect):

  • rendering/RenderThemeSafari.cpp:

(WebCore::RenderThemeSafari::paintMenuListButtonGradients):
(WebCore::RenderThemeSafari::paintMenuListButton):
(WebCore::RenderThemeSafari::paintSliderTrack):

  • rendering/RenderThemeWin.cpp:

(WebCore::RenderThemeWin::paintInnerSpinButton):
(WebCore::RenderThemeWin::paintMenuListButton):

10:30 Changeset [77383] by darin@chromium.org

2011-02-01 Darin Fisher <darin@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Avoid #ifdefs in code that constructs a GraphicsContext by
adding a helper class.
https://bugs.webkit.org/show_bug.cgi?id=53575

  • WebKit.gyp:
  • src/WebFontImpl.cpp: (WebKit::WebFontImpl::drawText):
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::printPage): (WebKit::WebFrameImpl::paint):
  • src/WebPopupMenuImpl.cpp: (WebKit::WebPopupMenuImpl::paint):
  • src/WebScrollbarImpl.cpp: (WebKit::WebScrollbarImpl::paint):
  • src/painting: Added.
  • src/painting/GraphicsContextBuilder.h: Added. (WebKit::GraphicsContextBuilder::GraphicsContextBuilder): (WebKit::GraphicsContextBuilder::context):
10:30 Changeset [77382] by hyatt@apple.com

Removal of right()/bottom(), converting to maxX()/maxY().

Reviewed by Darin Adler.

../WebKit/gtk:

  • webkit/webkitwebview.cpp:

(webkit_web_view_popup_menu_handler):

../WebKit/win:

  • DOMHTMLClasses.cpp:

(DOMHTMLInputElement::rectOnScreen):

  • WebCoreSupport/EmbeddedWidget.cpp:

(EmbeddedWidget::frameRectsChanged):

  • WebFrame.cpp:

(WebFrame::computePageRects):

  • WebScrollBar.cpp:

(WebScrollBar::frameRect):

  • WebView.cpp:

(WebView::addToDirtyRegion):
(WebView::visibleContentRect):
(WebView::prepareCandidateWindow):

10:29 Changeset [77381] by hyatt@apple.com

Conversion of right()/bottom() to maxX()/maxY() as part of the removal of those accessors.

Reviewed by Darin Adler.

  • UIProcess/win/WebPopupMenuProxyWin.cpp:

(WebKit::WebPopupMenuProxyWin::calculatePositionAndSize):

  • UIProcess/win/WebView.cpp:

(WebKit::WebView::prepareCandidateWindow):

  • WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:

(WebKit::NetscapePlugin::platformGeometryDidChange):

10:06 Changeset [77380] by alex@webkit.org

2011-02-02 Alejandro G. Castro <alex@igalia.com>

Reviewed by Martin Robinson.

[GTK] po files path update after the code moved to Source
https://bugs.webkit.org/show_bug.cgi?id=53599

  • POTFILES: Add Source to the path of the files.
10:05 Changeset [77379] by caseq@chromium.org

2011-02-01 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: add test for OPTIONS requests caused by CORS preflight checking to appear in Network panel
https://bugs.webkit.org/show_bug.cgi?id=53501

  • http/tests/inspector/network-preflight-options-expected.txt: Added.
  • http/tests/inspector/network-preflight-options.html: Added.
  • http/tests/inspector/resources/cors-target.php: Added.
09:59 Changeset [77378] by darin@apple.com

2011-02-01 Darin Adler <darin@apple.com>

Reviewed by Anders Carlsson.

Overflow in WebKit2 argument decoder buffer checking
https://bugs.webkit.org/show_bug.cgi?id=53536

  • Platform/CoreIPC/ArgumentDecoder.cpp: (CoreIPC::roundUpToAlignment): Tweak code a bit for clarity and to replace C casts with C++ casts. (CoreIPC::ArgumentDecoder::alignBufferPosition): Rearrange buffer calculation so we don't do any math with the passed-in size, because that could overflow. (CoreIPC::ArgumentDecoder::bufferIsLargeEnoughToContain): Ditto.
09:00 Changeset [77377] by mrobinson@webkit.org

2011-02-02 Martin Robinson <mrobinson@igalia.com>

Skip another test that uses modal dialogs.

  • platform/gtk/Skipped: Skip modal dialog test and update bug in the skipped list.
07:00 Changeset [77376] by antti@apple.com

Use Vector instead of a linked list for rules in CSSStyleSelector
https://bugs.webkit.org/show_bug.cgi?id=53581

Reviewed by Maciej Stachowiak.

  • eliminate CSSRuleDataList, replace with Vector<RuleData>
  • rename CSSRuleData -> RuleData and CSSRuleSet -> RuleSet (these are selector internal classes, CSS prefix is better reserved for public ones).
  • constify a bit
  • shrink the vectors to fit after collecting the rules
  • css/CSSStyleSelector.cpp:

(WebCore::RuleData::RuleData):
(WebCore::RuleData::position):
(WebCore::RuleData::rule):
(WebCore::RuleData::selector):
(WebCore::RuleSet::disableAutoShrinkToFit):
(WebCore::RuleSet::getIDRules):
(WebCore::RuleSet::getClassRules):
(WebCore::RuleSet::getTagRules):
(WebCore::RuleSet::getPseudoRules):
(WebCore::RuleSet::getUniversalRules):
(WebCore::RuleSet::getPageRules):
(WebCore::collectSiblingRulesInDefaultStyle):
(WebCore::CSSStyleSelector::CSSStyleSelector):
(WebCore::loadFullDefaultStyle):
(WebCore::loadSimpleDefaultStyle):
(WebCore::loadViewSourceStyle):
(WebCore::CSSStyleSelector::matchRules):
(WebCore::CSSStyleSelector::matchRulesForList):
(WebCore::operator >):
(WebCore::operator <=):
(WebCore::CSSStyleSelector::sortMatchedRules):
(WebCore::CSSStyleSelector::matchUARules):
(WebCore::RuleSet::RuleSet):
(WebCore::RuleSet::~RuleSet):
(WebCore::RuleSet::addToRuleSet):
(WebCore::RuleSet::addRule):
(WebCore::RuleSet::addPageRule):
(WebCore::RuleSet::addRulesFromSheet):
(WebCore::RuleSet::addStyleRule):
(WebCore::collectIdsAndSiblingRulesFromList):
(WebCore::RuleSet::collectIdsAndSiblingRules):
(WebCore::shrinkMapVectorsToFit):
(WebCore::RuleSet::shrinkToFit):
(WebCore::CSSStyleSelector::matchPageRules):
(WebCore::CSSStyleSelector::matchPageRulesForList):

  • css/CSSStyleSelector.h:

(WebCore::CSSStyleSelector::addMatchedRule):

06:08 Changeset [77375] by podivilov@chromium.org

2011-02-02 Andrey Adaikin <aandrey@google.com>

Reviewed by Pavel Feldman.

Web Inspector: Use DIVs instead of TABLE in TextViewer
https://bugs.webkit.org/show_bug.cgi?id=53299

  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._createTextViewer): (WebInspector.SourceFrame.prototype._mouseDown):
  • inspector/front-end/TextViewer.js: (WebInspector.TextViewer): (WebInspector.TextViewer.prototype.set mimeType): (WebInspector.TextViewer.prototype.revealLine): (WebInspector.TextViewer.prototype.addDecoration): (WebInspector.TextViewer.prototype.removeDecoration): (WebInspector.TextViewer.prototype.markAndRevealRange): (WebInspector.TextViewer.prototype.highlightLine): (WebInspector.TextViewer.prototype.clearLineHighlight): (WebInspector.TextViewer.prototype.freeCachedElements): (WebInspector.TextViewer.prototype._handleKeyDown): (WebInspector.TextViewer.prototype.editLine.finishEditing): (WebInspector.TextViewer.prototype.editLine): (WebInspector.TextViewer.prototype.beginUpdates): (WebInspector.TextViewer.prototype.endUpdates): (WebInspector.TextViewer.prototype.resize): (WebInspector.TextViewer.prototype._textChanged): (WebInspector.TextViewer.prototype._updatePanelOffsets): (WebInspector.TextViewer.prototype._syncScroll): (WebInspector.TextViewer.prototype._syncDecorationsForLine): (WebInspector.TextEditorChunkedPanel): (WebInspector.TextEditorChunkedPanel.prototype.set syncScrollListener): (WebInspector.TextEditorChunkedPanel.prototype.get textModel): (WebInspector.TextEditorChunkedPanel.prototype.addDecoration): (WebInspector.TextEditorChunkedPanel.prototype.removeDecoration): (WebInspector.TextEditorChunkedPanel.prototype.revealLine): (WebInspector.TextEditorChunkedPanel.prototype.makeLineAChunk): (WebInspector.TextEditorChunkedPanel.prototype.textChanged): (WebInspector.TextEditorChunkedPanel.prototype.beginUpdates): (WebInspector.TextEditorChunkedPanel.prototype.endUpdates): (WebInspector.TextEditorChunkedPanel.prototype.resize): (WebInspector.TextEditorChunkedPanel.prototype._scroll): (WebInspector.TextEditorChunkedPanel.prototype._scheduleRepaintAll): (WebInspector.TextEditorChunkedPanel.prototype._buildChunks): (WebInspector.TextEditorChunkedPanel.prototype._repaintAll): (WebInspector.TextEditorChunkedPanel.prototype._chunkNumberForLine): (WebInspector.TextEditorChunkedPanel.prototype._chunkForLine): (WebInspector.TextEditorGutterPanel): (WebInspector.TextEditorGutterPanel.prototype.freeCachedElements): (WebInspector.TextEditorGutterPanel.prototype._createNewChunk): (WebInspector.TextEditorGutterPanel.prototype._expandChunks): (WebInspector.TextEditorGutterChunk): (WebInspector.TextEditorGutterChunk.prototype.get expanded): (WebInspector.TextEditorGutterChunk.prototype.set expanded): (WebInspector.TextEditorGutterChunk.prototype.get height): (WebInspector.TextEditorGutterChunk.prototype._createRow): (WebInspector.TextEditorMainPanel): (WebInspector.TextEditorMainPanel.prototype.set syncDecorationsForLine): (WebInspector.TextEditorMainPanel.prototype.set mimeType): (WebInspector.TextEditorMainPanel.prototype.markAndRevealRange): (WebInspector.TextEditorMainPanel.prototype.highlightLine): (WebInspector.TextEditorMainPanel.prototype.clearLineHighlight): (WebInspector.TextEditorMainPanel.prototype.freeCachedElements): (WebInspector.TextEditorMainPanel.prototype._buildChunks): (WebInspector.TextEditorMainPanel.prototype._createNewChunk): (WebInspector.TextEditorMainPanel.prototype._expandChunks): (WebInspector.TextEditorMainPanel.prototype._highlightDataReady): (WebInspector.TextEditorMainPanel.prototype._paintLines): (WebInspector.TextEditorMainPanel.prototype._paintLine): (WebInspector.TextEditorMainPanel.prototype._releaseLinesHighlight): (WebInspector.TextEditorMainPanel.prototype._getSelection): (WebInspector.TextEditorMainPanel.prototype._restoreSelection): (WebInspector.TextEditorMainPanel.prototype._selectionToPosition): (WebInspector.TextEditorMainPanel.prototype._positionToSelection): (WebInspector.TextEditorMainPanel.prototype._appendTextNode): (WebInspector.TextEditorMainPanel.prototype._handleDomUpdates): (WebInspector.TextEditorMainChunk): (WebInspector.TextEditorMainChunk.prototype.addDecoration): (WebInspector.TextEditorMainChunk.prototype.set expanded): (WebInspector.TextEditorMainChunk.prototype.get height): (WebInspector.TextEditorMainChunk.prototype.getExpandedLineRow): (WebInspector.TextEditorMainChunk.prototype._createRow): (WebInspector):
  • inspector/front-end/textViewer.css: (.text-editor-lines): (.text-editor-contents): (.text-editor-editable): (.webkit-line-decorations): (.webkit-line-number): (.webkit-execution-line.webkit-line-content): (.diff-container .webkit-added-line.webkit-line-content): (.diff-container .webkit-removed-line.webkit-line-content): (.diff-container .webkit-changed-line.webkit-line-content): (.webkit-highlighted-line.webkit-line-content):
06:07 Changeset [77374] by ager@chromium.org

Merge 77135 - 2011-01-31 Mads Ager <ager@chromium.org>

Reviewed by Pavel Feldman.

[V8] Update V8 specific layout test expectations
https://bugs.webkit.org/show_bug.cgi?id=53423

Error formatting has changed in V8. Updating chromium specific
layout test expectations accordingly.

  • platform/chromium-mac/fast/js/array-every-expected.txt:
  • platform/chromium-mac/fast/js/instance-of-immediates-expected.txt:
  • platform/chromium-mac/fast/js/property-getters-and-setters-expected.txt:
  • platform/chromium-mac/storage/transaction-error-callback-expected.txt:
  • platform/chromium-mac/svg/dom/svgpath-out-of-bounds-getPathSeg-expected.txt:
  • platform/chromium-win/fast/js/array-every-expected.txt:
  • platform/chromium-win/fast/js/instance-of-immediates-expected.txt:
  • platform/chromium-win/fast/js/property-getters-and-setters-expected.txt:
  • platform/chromium-win/storage/transaction-error-callback-expected.txt:
  • platform/chromium-win/svg/dom/svgpath-out-of-bounds-getPathSeg-expected.txt:

TBR=ager@chromium.org
Review URL: http://codereview.chromium.org/6349048

05:55 Changeset [77373] by yurys@chromium.org

2011-02-02 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Removed some custom Chromium test expectations.

  • platform/chromium/test_expectations.txt:
03:57 Changeset [77372] by mnaganov@chromium.org

Merge 77254 - 2011-02-01 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Fix profiles reset to avoid clearing heap profiles in Chromium.

https://bugs.webkit.org/show_bug.cgi?id=53500

  • inspector/InspectorProfilerAgent.cpp: (WebCore::InspectorProfilerAgent::resetFrontendProfiles):

TBR=mnaganov@chromium.org
Review URL: http://codereview.chromium.org/6246044

02:10 Changeset [77371] by hans@chromium.org

2011-02-02 Hans Wennborg <hans@chromium.org>

Reviewed by Jeremy Orlow.

IndexedDB: Implement support for cursor updates
https://bugs.webkit.org/show_bug.cgi?id=53421

Layout test for cursor updates.

  • storage/indexeddb/cursor-update-expected.txt: Added.
  • storage/indexeddb/cursor-update.html: Added.

2011-02-02 Hans Wennborg <hans@chromium.org>

Reviewed by Jeremy Orlow.

IndexedDB: Implement support for cursor updates
https://bugs.webkit.org/show_bug.cgi?id=53421

Implement support for cursor updates using the same pattern as cursor
deletes: forward the calls to the IDBObjectStoreBackend::put().
The put() function's signature needs to be changed to allow for a
"cursor update mode". This makes the signature more clear anyway,
since it replaces the boolean parameter.

Test: storage/indexeddb/cursor-update.html

  • storage/IDBCursor.idl:
  • storage/IDBCursorBackendImpl.cpp: (WebCore::IDBCursorBackendImpl::key): (WebCore::IDBCursorBackendImpl::update):
  • storage/IDBCursorBackendImpl.h:
  • storage/IDBObjectStore.cpp: (WebCore::IDBObjectStore::add): (WebCore::IDBObjectStore::put):
  • storage/IDBObjectStoreBackendImpl.cpp: (WebCore::IDBObjectStoreBackendImpl::put): (WebCore::IDBObjectStoreBackendImpl::putInternal):
  • storage/IDBObjectStoreBackendImpl.h:
  • storage/IDBObjectStoreBackendInterface.h:

2011-02-02 Hans Wennborg <hans@chromium.org>

Reviewed by Jeremy Orlow.

IndexedDB: Implement support for cursor updates
https://bugs.webkit.org/show_bug.cgi?id=53421

Mirror the update to the IDBObjectStoreInterface::put() signature in
the WebKit layer wrappers.

  • public/WebIDBObjectStore.h: (WebKit::WebIDBObjectStore::put):
  • src/IDBObjectStoreProxy.cpp: (WebCore::IDBObjectStoreProxy::put):
  • src/IDBObjectStoreProxy.h:
  • src/WebIDBObjectStoreImpl.cpp: (WebKit::WebIDBObjectStoreImpl::put):
  • src/WebIDBObjectStoreImpl.h:
00:50 Changeset [77370] by commit-queue@webkit.org

2011-02-02 Naoki Takano <takano.naoki@gmail.com>

Reviewed by Kent Tamura.

Fix popup menu RTL bug introduced by Changeset 75982.
https://bugs.webkit.org/show_bug.cgi?id=53567

PopupMenuChromium::layout() calculates X position according to RTL or not. So Change the X position calculation in layoutAndCalculateWidgetRect().

No new tests. However we can check manually with select_dropdown_box_alignment.html, autofill_alignment.html, select_alignment.html, select_dropdown_box_alignment.html, autofill-popup-width-and-item-direction.html

  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupContainer::layoutAndCalculateWidgetRect): Fix calculation of x position, because layout() considers RTL. And change the parameter from both X and Y positions to only Y position. (WebCore::PopupContainer::showPopup): Change the passing parameter. (WebCore::PopupContainer::refresh): Change the passing parameter.
  • platform/chromium/PopupMenuChromium.h: Change the parameter declaration.
00:49 Changeset [77369] by alex@webkit.org

2011-02-02 Alejandro G. Castro <alex@igalia.com>

Reviewed by Martin Robinson.

[GTK] Fix dist compilation
https://bugs.webkit.org/show_bug.cgi?id=53579

  • GNUmakefile.am: Added WriteBarrier.h to the sources, it was added in r77151

2011-02-02 Alejandro G. Castro <alex@igalia.com>

Reviewed by Martin Robinson.

[GTK] Fix dist compilation
https://bugs.webkit.org/show_bug.cgi?id=53579

  • GNUmakefile.am: Added FontWidthVariant.h to the sources, it was added in r77153.
00:24 Changeset [77368] by commit-queue@webkit.org

2011-02-02 Dai Mikurube <dmikurube@google.com>

Reviewed by David Levin.

Make mime type lookup in File::create(path) thread-safe
https://bugs.webkit.org/show_bug.cgi?id=47700

This patch introduces a new function MIMETypeRegistry::getMIMETypeForExtensionThreadSafe().
The function is to be called as a thread-safe version of getMIMETypeForExtension() when
both FILE_SYSTEM and WORKERS are enabled.

No tests for this patch. This patch itself doesn't change the behaviors.
For Chromium, it runs in the same way with getMIMETypeForExtensionThreadSafe().
For the other platforms, it causes compilation error in case of enabled FILE_SYSTEM and WORKERS.
The compilation error would be a signal to implement getMIMETypeForExtensionThreadSafe() in these
platforms. Currently it doesn't happen since FILE_SYSTEM is not available in the other platforms.

  • platform/MIMETypeRegistry.cpp: Defined generic getMIMETypeForExtension() calling getMIMETypeForExtensionThreadSafe() for enabled FILE_SYSTEM and WORKERS. (WebCore::MIMETypeRegistry::getMIMETypeForExtension):
  • platform/MIMETypeRegistry.h: Declared getMIMETypeForExtensionThreadSafe() which should be implemented for each platform.
  • platform/android/TemporaryLinkStubs.cpp: (WebCore::MIMETypeRegistry::getMIMETypeForExtension):
  • platform/brew/MIMETypeRegistryBrew.cpp: (WebCore::MIMETypeRegistry::getMIMETypeForExtension):
  • platform/chromium/MIMETypeRegistryChromium.cpp: Defined getMIMETypeForExtensionThreadSafe() for the case when FILE_SYSTEM and WORKERS are enabled. (WebCore::MIMETypeRegistry::getMIMETypeForExtensionThreadSafe):
  • platform/efl/MIMETypeRegistryEfl.cpp: (WebCore::MIMETypeRegistry::getMIMETypeForExtension):
  • platform/gtk/MIMETypeRegistryGtk.cpp: (WebCore::MIMETypeRegistry::getMIMETypeForExtension):
  • platform/haiku/MIMETypeRegistryHaiku.cpp: (WebCore::MIMETypeRegistry::getMIMETypeForExtension):
  • platform/mac/MIMETypeRegistryMac.mm: (WebCore::MIMETypeRegistry::getMIMETypeForExtension):
  • platform/qt/MIMETypeRegistryQt.cpp: (WebCore::MIMETypeRegistry::getMIMETypeForExtension):
  • platform/win/MIMETypeRegistryWin.cpp: (WebCore::MIMETypeRegistry::getMIMETypeForExtension):
  • platform/wince/MIMETypeRegistryWinCE.cpp: (WebCore::MIMETypeRegistry::getMIMETypeForExtension):
  • platform/wx/MimeTypeRegistryWx.cpp: (WebCore::MIMETypeRegistry::getMIMETypeForExtension):
00:13 Changeset [77367] by commit-queue@webkit.org

2011-02-02 Chris Evans <cevans@chromium.org>

Reviewed by Adam Barth.

[Chromium] Propagate the accurate gesture status when calling into FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=53571

  • src/WebPluginContainerImpl.cpp: (WebKit::WebPluginContainerImpl::loadFrameRequest): FrameLoader might decide the target is a new window, so make such the UserGestureIndicator is fully accurate before calling into it.
00:00 Changeset [77366] by abarth@webkit.org

2011-02-01 Adam Barth <abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

Improve readability of updateWidget by converting bool parameter to an enum
https://bugs.webkit.org/show_bug.cgi?id=53576

As requested on webkit-dev.

  • html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::updateWidget):
  • html/HTMLEmbedElement.h:
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::updateWidget):
  • html/HTMLMediaElement.h:
  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::updateWidget):
  • html/HTMLObjectElement.h:
  • html/HTMLPlugInImageElement.cpp: (WebCore::HTMLPlugInImageElement::updateWidgetIfNecessary):
  • html/HTMLPlugInImageElement.h:
  • page/FrameView.cpp: (WebCore::FrameView::updateWidget):

02/01/11:

23:06 Changeset [77365] by ossy@webkit.org

Unreviewed.

Fix Qt build after r77339.

  • UIProcess/API/qt/qwkpage.cpp:

(QWKPagePrivate::enterAcceleratedCompositingMode):
(QWKPagePrivate::exitAcceleratedCompositingMode):

  • UIProcess/API/qt/qwkpage_p.h:
23:02 Changeset [77364] by commit-queue@webkit.org

2011-02-01 James Robinson <jamesr@chromium.org>

Reviewed by Adam Barth.

[v8] Increase V8 native->js recursion limit to match document.write() recursion limit
https://bugs.webkit.org/show_bug.cgi?id=53566

Unskip test that we now pass.

  • platform/chromium/test_expectations.txt:

2011-02-01 James Robinson <jamesr@chromium.org>

Reviewed by Adam Barth.

[v8] Increase V8 native->js recursion limit to match document.write() recursion limit
https://bugs.webkit.org/show_bug.cgi?id=53566

A recursion limit of 22 is necessary to pass fast/dom/Document/document-write-recursion.html.
Other than being large enough for this one test case, this limit is arbitrary.

  • bindings/v8/V8Proxy.h:
22:00 Changeset [77363] by ojan@chromium.org

2011-02-01 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

make draft comments focusable
https://bugs.webkit.org/show_bug.cgi?id=53554

Makes frozen draft comments focusable. The ones that are currently being edited are not.
I'm on the fence whether they should be, but this seems good enough for now.

  • code-review.js:
21:17 Changeset [77362] by ojan@chromium.org

2011-02-01 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

avoid jitter when loading the comments to a patch
https://bugs.webkit.org/show_bug.cgi?id=53570

  • code-review.js:
21:13 Changeset [77361] by abarth@webkit.org

2011-02-01 Adam Barth <abarth@webkit.org>

Reviewed by Andreas Kling.

Remove useless comment
https://bugs.webkit.org/show_bug.cgi?id=53549

The reason for this parameter is captured in
plugins/netscape-plugin-setwindow-size.html, which is a better place to
capture it than in this comment (which otherwise just re-iterates the
name of the parameter).

  • html/HTMLPlugInImageElement.cpp: (WebCore::HTMLPlugInImageElement::updateWidgetIfNecessary):
21:05 Changeset [77360] by ggaren@apple.com

2011-02-01 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r77297.
http://trac.webkit.org/changeset/77297
https://bugs.webkit.org/show_bug.cgi?id=53538

caused leopard crashes (Requested by paroga on #webkit).

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • wtf/text/AtomicString.cpp: (WTF::AtomicString::fromUTF8):
  • wtf/unicode/UTF8.cpp: (WTF::Unicode::calculateStringHashFromUTF8):
  • wtf/unicode/UTF8.h:
19:42 Changeset [77359] by mrowe@apple.com

New tag.

19:28 EFLWebKit edited by gyuyoung.kim@samsung.com
Root CMakeLists.txt was moved to Source directory. (diff)
19:02 Changeset [77358] by dpranke@chromium.org

2011-02-01 Dirk Pranke <dpranke@chromium.org>

Unreviewed, expectations change.

fast/css/box-shadow.html was removed in r77101 but there was
still a reference to it in the expectations file.

  • platform/chromium/test_expectations.txt:
18:57 Changeset [77357] by simonjam@chromium.org

2011-02-01 James Simonsen <simonjam@chromium.org>

Reviewed by Tony Gentilcore.

[WebTiming] Remove asserts that verify timestamp order
https://bugs.webkit.org/show_bug.cgi?id=53548

Covered by existing tests.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::stopLoading): Remove assert.
  • page/DOMWindow.cpp: (WebCore::DOMWindow::dispatchTimedEvent): Ditto.
18:50 Changeset [77356] by dglazkov@chromium.org

2011-02-01 Dimitri Glazkov <dglazkov@chromium.org>

Add the 'default_targets' enclosure to the flags.

  • WebCore.gyp/WebCore.gyp: Did it.
18:39 Changeset [77355] by mihaip@chromium.org

2011-02-01 Mihai Parparita <mihaip@chromium.org>

Reviewed by James Robinson.

Async event handlers should not fire within a modal dialog
https://bugs.webkit.org/show_bug.cgi?id=53202

Add tests for a scroll event triggered right before a modal dialog is
shown.

  • fast/events/scroll-event-during-modal-dialog-expected.txt: Added.
  • fast/events/scroll-event-during-modal-dialog.html: Added.

2011-02-01 Mihai Parparita <mihaip@chromium.org>

Reviewed by James Robinson.

Async event handlers should not fire within a modal dialog
https://bugs.webkit.org/show_bug.cgi?id=53202

Asychronous events that use EventQueue would currently fire while a
modal dialog (e.g. window.alert()) was up. Change EventQueue to use a
SuspendableTimer (which automatically gets suspended while dialogs are
up and in other cases where JS execution is not allowed).

Test: fast/events/scroll-event-during-modal-dialog.html

  • dom/Document.cpp: (WebCore::Document::Document):
  • dom/EventQueue.cpp: (WebCore::EventQueueTimer::EventQueueTimer): (WebCore::EventQueueTimer::fired): (WebCore::EventQueue::EventQueue): (WebCore::EventQueue::enqueueEvent): (WebCore::EventQueue::pendingEventTimerFired):
  • dom/EventQueue.h: (WebCore::EventQueue::create):
  • page/SuspendableTimer.cpp: (WebCore::SuspendableTimer::SuspendableTimer): (WebCore::SuspendableTimer::suspend): (WebCore::SuspendableTimer::resume):
  • page/SuspendableTimer.h:
18:35 Changeset [77354] by jschuh@chromium.org

Merge 76264
BUG=69970

18:32 Changeset [77353] by dpranke@chromium.org

2011-02-01 Dirk Pranke <dpranke@chromium.org>

Reviewed by Mihai Parparita.

new-run-webkit-tests: stop skipping so many tests

r77163 introduced a regression where we weren't resetting test
expectations properly and were skipping too many tests as a
result. This patch fixes that and adds a test for it.

https://bugs.webkit.org/show_bug.cgi?id=53551

  • Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
18:23 Changeset [77352] by jschuh@chromium.org

Merge 75810
BUG=69556

18:18 Changeset [77351] by paroga@webkit.org

2011-02-01 Patrick Gansterer <paroga@webkit.org>

Reviewed by Andreas Kling.

Change wrong PLATFORM(WIN) to USE(WININET)
https://bugs.webkit.org/show_bug.cgi?id=53547

  • platform/network/ResourceHandle.h:
18:05 Changeset [77350] by bdakin@apple.com

32-bit build fix.

  • platform/mac/ScrollAnimatorMac.mm:

(-[ScrollbarPainterControllerDelegate contentAreaRectForScrollerImpPair:]):

18:04 Changeset [77349] by mrowe@apple.com

Build fix.

18:04 Changeset [77348] by jschuh@chromium.org

Merge 76990
BUG=68120

17:53 Changeset [77347] by tkent@chromium.org

2011-02-01 Kent Tamura <tkent@chromium.org>

Reviewed by Tony Chang.

[Chromium] Roll Chromium revision for the WebKitWeightWatcher change
https://bugs.webkit.org/show_bug.cgi?id=53563

  • platform/chromium/test_expectations.txt: fast/css/font-weight-1.html is expected to fail.

2011-02-01 Kent Tamura <tkent@chromium.org>

Reviewed by Tony Chang.

[Chromium] Roll Chromium revision for the WebKitWeightWatcher change
https://bugs.webkit.org/show_bug.cgi?id=53563

  • DEPS: Roll to crrev.com/73378 to have the WebKitWeightWatcher change of webkit_support.
17:49 Changeset [77346] by dglazkov@chromium.org

2011-02-01 Dimitri Glazkov <dglazkov@chromium.org>

Marking test, added in r77333 as skipped, because it is
reaching V8 recursion limits faster than those on Document.

  • platform/chromium/test_expectations.txt: See above.
17:45 Changeset [77345] by andersca@apple.com

2011-02-01 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Attach the layer tree in the UI process
https://bugs.webkit.org/show_bug.cgi?id=53560

  • UIProcess/API/mac/WKView.mm: (-[WKView _enterAcceleratedCompositingMode:]): Make a render layer and add it as a sublayer of our root layer.
  • WebProcess/WebPage/mac/LayerTreeHostMac.h: Make LayerTreeHostMac a GraphicsLayerClient.
  • WebProcess/WebPage/mac/LayerTreeHostMac.mm: (WebKit::LayerTreeHostMac::LayerTreeHostMac): Create a root layer, add the layer subtree as a child of the root layer.

(WebKit::LayerTreeHostMac::~LayerTreeHostMac):
Assert that m_rootLayer is null.

(WebKit::LayerTreeHostMac::invalidate):
Null out m_rootLayer.

(WebKit::LayerTreeHostMac::notifyAnimationStarted):
(WebKit::LayerTreeHostMac::notifySyncRequired):
(WebKit::LayerTreeHostMac::paintContents):
Add stubs.

(WebKit::LayerTreeHostMac::showDebugBorders):
(WebKit::LayerTreeHostMac::showRepaintCounter):
Return the correct settings.

(WebKit::LayerTreeHostMac::flushPendingLayerChanges):
Flush the root layer changes.

17:41 Changeset [77344] by jschuh@chromium.org

Merge 75823
BUG=67968

17:31 Changeset [77343] by mrobinson@webkit.org

2011-01-25 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] Two tests crash after r76555
https://bugs.webkit.org/show_bug.cgi?id=53057

  • platform/gtk/Skipped: Unskip tests which are no longer crashing.

2011-01-25 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] Two tests crash after r76555
https://bugs.webkit.org/show_bug.cgi?id=53057

Instead of creating synchronous ResourceHandles manually, use the ::create factory.
This ensures that ::start() is not called when there is a scheduled failure and also
reduces code duplication.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandle::loadResourceSynchronously): Use the ::create factory method.
17:25 Changeset [77342] by jschuh@chromium.org

Merge 76708
BUG=67234

17:16 Changeset [77341] by dpranke@chromium.org

2011-02-01 Dirk Pranke <dpranke@chromium.org>

Reviewed by Tony Chang.

new-run-webkit-tests: add first stub of test_runner2. This
will add support for the 'inline', 'threads', and 'processes'
flags to --worker-model, but for now the implementatios just
fall back on the old ones.

https://bugs.webkit.org/show_bug.cgi?id=53157

  • Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
17:12 Changeset [77340] by ojan@chromium.org

2011-02-01 Ojan Vafai <ojan@chromium.org>

Reviewed by Mihai Parparita.

[codereviewtool] extra space at the beginning of lines in side-by-side view
https://bugs.webkit.org/show_bug.cgi?id=53550

The newline between the spans turns into user-visible space in side-by-side mode.

  • PrettyPatch/PrettyPatch.rb:
17:11 Changeset [77339] by andersca@apple.com

Fix Windows build.

  • UIProcess/win/WebView.cpp:

(WebKit::WebView::enterAcceleratedCompositingMode):
(WebKit::WebView::exitAcceleratedCompositingMode):

  • UIProcess/win/WebView.h:
17:09 Changeset [77338] by andersca@apple.com

2011-02-01 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Add a layer backed NSView for accelerated content
https://bugs.webkit.org/show_bug.cgi?id=53555

Rename the current _layerHostingView to _oldLayerHostingView and
add a new _layerHostingView to be used with the new drawing area.

  • UIProcess/API/mac/WKView.mm: (-[WKView hitTest:]): (-[WKView _startAcceleratedCompositing:]): (-[WKView _stopAcceleratedCompositing]): (-[WKView _enterAcceleratedCompositingMode:]): (-[WKView _exitAcceleratedCompositingMode]):
17:04 Changeset [77337] by mrobinson@webkit.org

2011-02-01 Martin Robinson <mrobinson@igalia.com>

Reviewed by Eric Seidel.

[GTK] GObject DOM bindings do no support the CallWith attribute
https://bugs.webkit.org/show_bug.cgi?id=53331

Disable building GObject DOM bindings for IndexedDB because we do not support
the CallWith attribute at this time.

  • bindings/gobject/GNUmakefile.am: Disable building bindings for the IndexedDB API.
17:01 Changeset [77336] by darin@apple.com

2011-02-01 Darin Adler <darin@apple.com>

Reviewed by Brady Eidson.

Fix a couple loose ends from the back/forward tree encode/decode work
https://bugs.webkit.org/show_bug.cgi?id=53537

  • history/HistoryItem.cpp: (WebCore::HistoryItem::encodeBackForwardTreeNode): Remove extra copy of original URL string; no need to encode it twice. (WebCore::HistoryItem::decodeBackForwardTree): Ditto.
  • history/HistoryItem.h: Removed declaration for function that is no longer defined nor used.
16:55 Changeset [77335] by tony@chromium.org

2011-02-01 Tony Chang <tony@chromium.org>

Reviewed by Kent Tamura.

[chromium] disable arm uninitialized variable warnings
https://bugs.webkit.org/show_bug.cgi?id=53553

We just got another error:
third_party/WebKit/Source/WebCore/css/CSSPrimitiveValue.cpp:123:error:
'colorTransparent.unstatic.4879' may be used uninitialized in this
function

  • WebCore.gyp/WebCore.gyp:
16:48 Changeset [77334] by andersca@apple.com

2011-02-01 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Pass enter/exit accelerated compositing mode to the WKView
https://bugs.webkit.org/show_bug.cgi?id=53552

  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm: (WebKit::PageClientImpl::enterAcceleratedCompositingMode): (WebKit::PageClientImpl::exitAcceleratedCompositingMode):
  • UIProcess/API/mac/WKView.mm: (-[WKView _enterAcceleratedCompositingMode:]): (-[WKView _exitAcceleratedCompositingMode]):
  • UIProcess/API/mac/WKViewInternal.h:
  • UIProcess/DrawingAreaProxyImpl.cpp: (WebKit::DrawingAreaProxyImpl::enterAcceleratedCompositingMode): (WebKit::DrawingAreaProxyImpl::exitAcceleratedCompositingMode):
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::enterAcceleratedCompositingMode): (WebKit::WebPageProxy::exitAcceleratedCompositingMode):
  • UIProcess/WebPageProxy.h:
16:22 Changeset [77333] by commit-queue@webkit.org

2011-02-01 chris reiss <christopher.reiss@nokia.com>

Reviewed by Adam Barth.

Self-replicating code makes Safari hang and eventually crash
https://bugs.webkit.org/show_bug.cgi?id=15123

  • fast/dom/Document/document-close-iframe-load-expected.txt: Added.
  • fast/dom/Document/document-close-iframe-load.html: Added.
  • fast/dom/Document/document-close-nested-iframe-load-expected.txt: Added.
  • fast/dom/Document/document-close-nested-iframe-load.html: Added.
  • fast/dom/Document/document-write-recursion-expected.txt: Added.
  • fast/dom/Document/document-write-recursion.html: Added.

2011-02-01 chris reiss <christopher.reiss@nokia.com>

Reviewed by Adam Barth.

Self-replicating code makes Safari hang and eventually crash
https://bugs.webkit.org/show_bug.cgi?id=15123

Here we are replicating the Firefox safeguard against
recursive document.write( ) 's.

See https://bug197052.bugzilla.mozilla.org/attachment.cgi?id=293907 in bug
https://bugzilla.mozilla.org/show_bug.cgi?id=197052 . Firefox does two things -

a) imposes a recursion limit of 20 on document.write( ) and
b) once that limit is passed, panics all the way the call stack (rather than just returning one level.)

To see why this is necessary, consider the script :

<script>

var t = document.body.innerHTML;
document.write(t);

</script>

This will create a tree both broad and deep as the script keeps appending itself to the text. If
we just return one level after the recursion limit is reached, we still allow millions of copies to
duplicate (and execute).

The recursion is fortunately depth-first, so as soon as we cross this limit, we panic up the callstack
to prevent this situation. (IE apparently does the same thing, with a lower recursion limit.)

Test: fast/dom/Document/document-write-recursion.html
Test: fast/dom/Document/document-close-iframe-load.html
Test: fast/dom/Document/document-close-nested-iframe-load.html

  • dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::write):
  • dom/Document.h:
16:12 Changeset [77332] by dglazkov@chromium.org

2011-02-01 Dimitri Glazkov <dglazkov@chromium.org>

Updated text expectations to avoid conflict.

  • platform/chromium/test_expectations.txt: Tweaked.
16:05 Changeset [77331] by ojan@chromium.org

2011-02-01 Ojan Vafai <ojan@chromium.org>

Increment version number to cache-bust code-review.js.

  • PrettyPatch/PrettyPatch.rb:
16:00 Changeset [77330] by ojan@chromium.org

2011-01-31 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

Store draft comments in localStorage
https://bugs.webkit.org/show_bug.cgi?id=52866

  • code-review.js:
  • code-review-test.html
15:52 Changeset [77329] by jnd@chromium.org

2011-02-01 Johnny Ding <jnd@chromium.org>

Reviewed by Darin Adler.

Don't set user gesture in HTMLAnchorElement's click handler because the click handler can be triggered by untrusted event.
https://bugs.webkit.org/show_bug.cgi?id=53424

  • fast/events/popup-blocked-from-untrusted-click-event-on-anchor-expected.txt: Added.
  • fast/events/popup-blocked-from-untrusted-click-event-on-anchor.html: Added.

2011-02-01 Johnny Ding <jnd@chromium.org>

Reviewed by Darin Adler.

Don't set user gesture in HTMLAnchorElement's click handler because the click handler can be triggered by untrusted event.
https://bugs.webkit.org/show_bug.cgi?id=53424

Test: fast/events/popup-blocked-from-untrusted-click-event-on-anchor.html

  • html/HTMLAnchorElement.cpp: (WebCore::handleLinkClick):
15:50 Changeset [77328] by ossy@webkit.org

Unreviewed Qt buildfix after r77286.

https://bugs.webkit.org/show_bug.cgi?id=53520
Remove the physical terminology from IntRect and FloatRect.

Source/WebCore:

  • platform/graphics/TiledBackingStore.cpp:

(WebCore::TiledBackingStore::createTiles):

Source/WebKit/qt:

  • WebCoreSupport/PopupMenuQt.cpp:

(WebCore::PopupMenuQt::show):

Source/WebKit2:

  • UIProcess/qt/ChunkedUpdateDrawingAreaProxyQt.cpp:

(WebKit::ChunkedUpdateDrawingAreaProxy::drawUpdateChunkIntoBackingStore):

15:46 Changeset [77327] by zmo@google.com

2011-02-01 Zhenyao Mo <zmo@google.com>

Unreviewed, test expectations update.

  • platform/chromium/test_expectations.txt:
15:41 Changeset [77326] by mrowe@apple.com

Merge r71769.

15:41 Changeset [77325] by mrowe@apple.com

Merge r71767.

15:32 Changeset [77324] by paroga@webkit.org

2011-02-01 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r77297.
http://trac.webkit.org/changeset/77297
https://bugs.webkit.org/show_bug.cgi?id=53538

caused leopard crashes (Requested by paroga on #webkit).

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • wtf/text/AtomicString.cpp: (WTF::AtomicString::fromUTF8):
  • wtf/unicode/UTF8.cpp: (WTF::Unicode::calculateStringHashFromUTF8):
  • wtf/unicode/UTF8.h:
15:26 Changeset [77323] by dglazkov@chromium.org

2011-02-01 Dimitri Glazkov <dglazkov@chromium.org>

Updated baselines after switching input-derived parts of HTMLMediaElement
to use shadow DOM.
https://bugs.webkit.org/show_bug.cgi?id=53314

  • platform/chromium-linux/media/video-zoom-controls-expected.checksum: Updated.
  • platform/chromium-linux/media/video-zoom-controls-expected.png: Updated.
  • platform/chromium-mac/media/video-zoom-controls-expected.checksum: Updated.
  • platform/chromium-mac/media/video-zoom-controls-expected.png: Updated.
  • platform/chromium-mac/media/video-zoom-controls-expected.txt: Updated.
  • platform/chromium-win/media/video-zoom-controls-expected.checksum: Updated.
  • platform/chromium-win/media/video-zoom-controls-expected.png: Updated.
  • platform/chromium-win/media/video-zoom-controls-expected.txt: Updated.
  • platform/chromium/test_expectations.txt: Expectation of failure removed.
15:20 Changeset [77322] by weinig@apple.com

Fix Mac production builds.

../JavaScriptCore:

../WebCore:

  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/mac/ScrollAnimatorMac.h:
  • platform/mac/ScrollbarThemeMac.h:
15:05 Changeset [77321] by inferno@chromium.org

2011-02-01 Abhishek Arya <inferno@chromium.org>

Unreviewed.

Test not crashing on chromium, was crashing earlier because of
some build issues. Also, rebaselining chromium mac since it matches
rest of chromium and is not same as mac leopard.
https://bugs.webkit.org/show_bug.cgi?id=53516

  • platform/chromium-mac/fast/css/stylesheet-candidate-nodes-crash-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
15:04 Changeset [77320] by darin@chromium.org

2011-02-01 Darin Fisher <darin@chromium.org>

Reviewed by David Levin.

[chromium] Remove unnecessary WebCore
prefixing in a few places and fix-up some indentation. https://bugs.webkit.org/show_bug.cgi?id=53523
  • src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::attach): (WebKit::WebDevToolsAgentImpl::inspectNode): (WebKit::WebDevToolsAgentImpl::inspectorController): (WebKit::WebDevToolsAgentImpl::mainFrame): (WebKit::WebDevToolsAgentImpl::identifierForInitialRequest): (WebKit::WebDevToolsAgentImpl::sendMessageToFrontend): (WebKit::WebDevToolsAgentImpl::updateInspectorStateCookie): (WebKit::WebDevToolsAgent::interruptAndDispatch): (WebKit::WebDevToolsAgent::processPendingMessages):
  • src/WebPopupMenuImpl.cpp: (WebKit::WebPopupMenuImpl::resize):
  • src/WebScrollbarImpl.cpp: (WebKit::WebScrollbarImpl::setLocation): (WebKit::WebScrollbarImpl::setValue): (WebKit::WebScrollbarImpl::onMouseWheel): (WebKit::WebScrollbarImpl::onKeyDown): (WebKit::WebScrollbarImpl::scrollPosition): (WebKit::WebScrollbarImpl::setScrollOffset): (WebKit::WebScrollbarImpl::invalidateScrollbarRect): (WebKit::WebScrollbarImpl::getTickmarks):
15:02 Changeset [77319] by mrowe@apple.com

Merge r73620.

14:59 Changeset [77318] by mrowe@apple.com

Merge r73559.

14:56 Changeset [77317] by hyatt@apple.com

Fix Qt bustage.

14:52 Changeset [77316] by hyatt@apple.com

Fix Qt bustage.

14:51 Changeset [77315] by andersca@apple.com

2011-02-01 Anders Carlsson <andersca@apple.com>

Reviewed by Adam Roben.

Send messages when entering/exiting accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=53534

  • Shared/LayerTreeContext.h: Added.
  • Shared/mac/LayerTreeContextMac.mm: Added. Add new LayerTreeContext which holds all information needed to enter accelerated compositing mode.
  • UIProcess/DrawingAreaProxy.h: (WebKit::DrawingAreaProxy::enterAcceleratedCompositingMode): (WebKit::DrawingAreaProxy::exitAcceleratedCompositingMode): Add empty stubs.
  • UIProcess/DrawingAreaProxy.messages.in: Add new messgaes.
  • UIProcess/DrawingAreaProxyImpl.cpp: (WebKit::DrawingAreaProxyImpl::enterAcceleratedCompositingMode): (WebKit::DrawingAreaProxyImpl::exitAcceleratedCompositingMode):
  • UIProcess/DrawingAreaProxyImpl.h: Add empty stubs.
  • WebKit2.xcodeproj/project.pbxproj: Add new files.
  • WebProcess/WebPage/mac/LayerTreeHostMac.h:
  • WebProcess/WebPage/mac/LayerTreeHostMac.mm: (WebKit::LayerTreeHostMac::LayerTreeHostMac): (WebKit::LayerTreeHostMac::invalidate): Send messages.
14:49 Changeset [77314] by mrowe@apple.com

Merge r71431.

14:49 Changeset [77313] by darin@apple.com

2011-02-01 Darin Adler <darin@apple.com>

Reviewed by Chris Fleizach.

REGRESSION: Removing focus from area element causes unwanted scrolling
https://bugs.webkit.org/show_bug.cgi?id=50169

Test: fast/images/imagemap-scroll.html

  • html/HTMLAreaElement.cpp: (WebCore::HTMLAreaElement::setFocus): Added override. Calls the new RenderImage::areaElementFocusChanged function. (WebCore::HTMLAreaElement::updateFocusAppearance): Removed the code here that calls setNeedsLayout on the image's renderer. This was an attempt to cause repaint of the renderer, but this function does not need to do that. Also changed this to use the imageElement function to avoid repeating code.
  • html/HTMLAreaElement.h: Updated for above changes.
  • rendering/RenderImage.cpp: (WebCore::RenderImage::paint): Updated for name change. (WebCore::RenderImage::paintAreaElementFocusRing): Renamed this from paintFocusRing, because it only paints area focus rings, and should not be confused with paintFocusRing functions in other classes. Also removed the unused style argument. Removed the code that used an HTMLCollection to see if the focused area element is for this image and instead just call imageElement on the area element. (WebCore::RenderImage::areaElementFocusChanged): Added. Calls repaint.
  • rendering/RenderImage.h: Added a public areaElementFocusChanged function for HTMLAreaElement to call. Made the paintFocusRing function private, renamed it to paintAreaElementFocusRing, and removed its unused style argument.

2011-02-01 Darin Adler <darin@apple.com>

Reviewed by Chris Fleizach.

REGRESSION: Removing focus from area element causes unwanted scrolling
https://bugs.webkit.org/show_bug.cgi?id=50169

  • fast/images/imagemap-scroll-expected.txt: Added.
  • fast/images/imagemap-scroll.html: Added.
14:48 Changeset [77312] by hyatt@apple.com

Fix Qt bustage.

14:42 Changeset [77311] by zmo@google.com

2011-02-01 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

getUniform should support SAMPLER_2D or SAMPLER_CUBE
https://bugs.webkit.org/show_bug.cgi?id=52190

  • fast/canvas/webgl/gl-object-get-calls-expected.txt:
  • fast/canvas/webgl/gl-object-get-calls.html: Test getUniform with sampler2D and samplerCube uniforms.
  • fast/canvas/webgl/resources/noopUniformShader.vert: Added.
  • fast/canvas/webgl/resources/samplerUniformShader.frag: Added.

2011-02-01 Patrick Gansterer <paroga@webkit.org>

Unreviewed WinCE build fix for r77286.

  • platform/graphics/wince/GraphicsContextWinCE.cpp: (WebCore::TransparentLayerDC::TransparentLayerDC):
14:42 Changeset [77310] by mrowe@apple.com

Merge r70792.

14:39 Changeset [77309] by paroga@webkit.org

2011-02-01 Patrick Gansterer <paroga@webkit.org>

Unreviewed WinCE build fix for r77286.

  • platform/graphics/wince/GraphicsContextWinCE.cpp: (WebCore::TransparentLayerDC::TransparentLayerDC):
14:37 Changeset [77308] by cfleizach@apple.com

AX: AXPosition of AXScrollArea is wrong
https://bugs.webkit.org/show_bug.cgi?id=53511

Reviewed by Darin Adler.

Source/WebCore:

AccessibilityScrollView needed to return a valid documentFrameView() object.
At the same time, the code from document() should be consolidated in
AccessibilityObject, so all objects can use it.

Test: platform/mac/accessibility/webkit-scrollarea-position.html

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::document):

  • accessibility/AccessibilityObject.h:
  • accessibility/AccessibilityScrollView.cpp:

(WebCore::AccessibilityScrollView::accessibilityHitTest):
(WebCore::AccessibilityScrollView::documentFrameView):

  • accessibility/AccessibilityScrollView.h:

LayoutTests:

  • platform/mac/accessibility/webkit-scrollarea-position-expected.txt: Added.
  • platform/mac/accessibility/webkit-scrollarea-position.html: Added.
14:33 Changeset [77307] by mrowe@apple.com

Merge r69033.

14:30 Changeset [77306] by ap@apple.com

Reviewed by Dan Bernstein and Darin Adler.

<rdar://problem/8830594> Printed page is sometimes shifted down, making footer invisible

  • UIProcess/API/mac/WKPrintingView.mm: (-[WKPrintingView locationOfPrintRect:]): Instead of letting AppKit compute content position on page, make the view provide it. We can do this because WK(Printing)Views are always printed on their own, not as part of other views.
14:29 Changeset [77305] by zmo@google.com

2011-02-01 Zhenyao Mo <zmo@google.com>

Reviewed by Darin Adler.

Fix the incorrect usage of RetainPtr cases in GraphicsContext3DCG.cpp
https://bugs.webkit.org/show_bug.cgi?id=53531

With this fix, running WebGL conformance tests should no longer crash randomly.

  • platform/graphics/cg/GraphicsContext3DCG.cpp: (WebCore::GraphicsContext3D::getImageData):
14:23 Changeset [77304] by mrowe@apple.com

Merge r70335.

14:21 Changeset [77303] by mrowe@apple.com

Merge r68541.

14:14 Changeset [77302] by dglazkov@chromium.org

2011-02-01 Dimitri Glazkov <dglazkov@chromium.org>

One more Chromium build fix after r77286.

  • platform/chromium/ScrollbarThemeChromiumMac.mm: (WebCore::ScrollbarThemeChromiumMac::paint): Changed to not use topLeft().
14:12 Changeset [77301] by weinig@apple.com

Try to fix the windows build.

  • DerivedSources.make:
14:11 Changeset [77300] by hyatt@apple.com

Fix Qt bustage.

14:07 Changeset [77299] by mrowe@apple.com

Merge r74524.

14:04 Changeset [77298] by weinig@apple.com

Fix the build for Beth.

  • platform/mac/ScrollAnimatorMac.mm:

(-[ScrollbarPainterControllerDelegate inLiveResizeForScrollerImpPair:]):

14:03 Changeset [77297] by paroga@webkit.org

2011-02-01 Patrick Gansterer <paroga@webkit.org>

Reviewed by Darin Adler.

Avoid strlen() in AtomicString::fromUTF8
https://bugs.webkit.org/show_bug.cgi?id=50516

Add an overload to calculateStringHashFromUTF8 to get
strlen() of the input data with only one call.

This change shows about 3% performance win on the xml-parser benchmark.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • wtf/text/AtomicString.cpp: (WTF::AtomicString::fromUTF8):
  • wtf/unicode/UTF8.cpp: (WTF::Unicode::calculateStringHashAndLengthFromUTF8Internal): (WTF::Unicode::calculateStringHashFromUTF8): (WTF::Unicode::calculateStringHashAndLengthFromUTF8):
  • wtf/unicode/UTF8.h:
14:02 Changeset [77296] by mrowe@apple.com

Merge r66796.

14:02 Changeset [77295] by mrowe@apple.com

Merge r66795.

14:02 Changeset [77294] by mrowe@apple.com

Merge r66115.

13:57 Changeset [77293] by andersca@apple.com

2011-02-01 Anders Carlsson <andersca@apple.com>

Reviewed by Adam Roben.

Make LayerTreeHost ref counted
https://bugs.webkit.org/show_bug.cgi?id=53530

LayerTreeHostMac will soon be able to trigger layout, which could cause
the page to leave accelerated compositing mode and free the LayerTreeHostMac object.

Making LayerTreeHost ref counted will let LayerTreeHostMac protect itself while triggering layout.

  • WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::setRootCompositingLayer):
  • WebProcess/WebPage/DrawingAreaImpl.h:
  • WebProcess/WebPage/LayerTreeHost.cpp: (WebKit::LayerTreeHost::create):
  • WebProcess/WebPage/LayerTreeHost.h:
  • WebProcess/WebPage/mac/LayerTreeHostMac.h:
  • WebProcess/WebPage/mac/LayerTreeHostMac.mm: (WebKit::LayerTreeHostMac::create): (WebKit::LayerTreeHostMac::LayerTreeHostMac): (WebKit::LayerTreeHostMac::~LayerTreeHostMac): (WebKit::LayerTreeHostMac::invalidate):
13:56 Changeset [77292] by hyatt@apple.com

Fix chromium bustage.

13:51 Changeset [77291] by hyatt@apple.com

Fix Qt build bustage.

13:50 Changeset [77290] by mrowe@apple.com

Merge r75882.

13:50 Changeset [77289] by mrowe@apple.com

Merge r73799, r73805 and r73818.

13:47 Changeset [77288] by dglazkov@chromium.org

2011-02-01 Dimitri Glazkov <dglazkov@chromium.org>

Added yet another expectations of flakiness.
https://bugs.webkit.org/show_bug.cgi?id=53527

  • platform/chromium/test_expectations.txt: Flakiness abound.
13:45 Changeset [77287] by weinig@apple.com

Part 2 for <rdar://problem/8492788>
Adopt WKScrollbarPainterController

Reviewed by Beth Dakin.

Use header detection to define scrollbar painting controller #define.

Source/JavaScriptCore:

Source/WebCore:

  • WebCore.exp.in:
  • platform/mac/ScrollAnimatorMac.h:
  • platform/mac/ScrollbarThemeMac.h:
  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:

Source/WebKit/mac:

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

Source/WebKit2:

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

13:39 Changeset [77286] by hyatt@apple.com

https://bugs.webkit.org/show_bug.cgi?id=53520

Reviewed by Oliver Hunt.

Remove the physical terminology from IntRect and FloatRect.

Now that we have flipped RenderBlocks for vertical-rl and horizontal-bt writing modes,
we need to update our terminology to be more accurate.

I'm borrowing a page from AppKit here (which also supports flipped NSViews) and
renaming right() and bottom() to maxX() and maxY(). These terms remain accurate
even for flipped rectangles.

../WebCore:

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::boundsForVisiblePositionRange):

  • accessibility/mac/AccessibilityObjectWrapper.mm:

(-[AccessibilityObjectWrapper position]):

  • dom/ClientRect.h:

(WebCore::ClientRect::right):
(WebCore::ClientRect::bottom):

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::convertLogicalToDevice):

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::normalizeRect):

  • inspector/InspectorAgent.cpp:

(WebCore::InspectorAgent::drawElementTitle):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::adjustWindowRect):

  • page/DragController.cpp:

(WebCore::dragLocForSelectionDrag):

  • page/EventHandler.cpp:

(WebCore::EventHandler::sendContextMenuEventForKey):

  • page/PrintContext.cpp:

(WebCore::PrintContext::computePageRectsWithPageSizeInternal):
(WebCore::PrintContext::pageNumberForElement):

  • page/SpatialNavigation.cpp:

(WebCore::end):
(WebCore::areRectsFullyAligned):
(WebCore::areRectsMoreThanFullScreenApart):
(WebCore::below):
(WebCore::rightOf):
(WebCore::isRectInDirection):
(WebCore::entryAndExitPointsForDirection):
(WebCore::virtualRectForDirection):

  • page/WindowFeatures.cpp:

(WebCore::WindowFeatures::WindowFeatures):

  • platform/ScrollView.cpp:

(WebCore::ScrollView::wheelEvent):

  • platform/Scrollbar.cpp:

(WebCore::Scrollbar::setFrameRect):

  • platform/ScrollbarThemeComposite.cpp:

(WebCore::ScrollbarThemeComposite::splitTrack):

  • platform/chromium/ScrollbarThemeChromium.cpp:

(WebCore::ScrollbarThemeChromium::paintTickmarks):

  • platform/graphics/FloatQuad.h:

(WebCore::FloatQuad::FloatQuad):

  • platform/graphics/FloatRect.cpp:

(WebCore::FloatRect::intersects):
(WebCore::FloatRect::contains):
(WebCore::FloatRect::intersect):
(WebCore::FloatRect::unite):
(WebCore::enclosingIntRect):

  • platform/graphics/FloatRect.h:

(WebCore::FloatRect::maxX):
(WebCore::FloatRect::maxY):
(WebCore::FloatRect::contains):

  • platform/graphics/IntRect.cpp:

(WebCore::IntRect::intersects):
(WebCore::IntRect::contains):
(WebCore::IntRect::intersect):
(WebCore::IntRect::unite):

  • platform/graphics/IntRect.h:

(WebCore::IntRect::maxX):
(WebCore::IntRect::maxY):
(WebCore::IntRect::shiftXEdgeTo):
(WebCore::IntRect::shiftMaxXEdgeTo):
(WebCore::IntRect::shiftYEdgeTo):
(WebCore::IntRect::shiftMaxYEdgeTo):
(WebCore::IntRect::contains):

  • platform/graphics/WidthIterator.cpp:

(WebCore::WidthIterator::advance):

  • platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::drawRect):
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::fillRect):

  • platform/graphics/cg/ImageBufferCG.cpp:

(WebCore::getImageData):
(WebCore::putImageData):

  • platform/graphics/cg/ImageCG.cpp:

(WebCore::BitmapImage::draw):

  • platform/graphics/filters/FilterEffect.cpp:

(WebCore::FilterEffect::copyImageBytes):

  • platform/graphics/mac/ComplexTextController.cpp:

(WebCore::ComplexTextController::adjustGlyphsAndAdvances):

  • platform/graphics/mac/SimpleFontDataMac.mm:

(WebCore::SimpleFontData::platformBoundsForGlyph):

  • platform/graphics/transforms/AffineTransform.cpp:

(WebCore::AffineTransform::mapRect):

  • platform/graphics/win/FontCGWin.cpp:

(WebCore::drawGDIGlyphs):

  • platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:

(WebCore::MediaPlayerPrivate::paint):

  • platform/gtk/RenderThemeGtk.cpp:

(WebCore::centerRectVerticallyInParentInputElement):

  • platform/mac/WidgetMac.mm:

(WebCore::Widget::paint):

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::addBoxShadowVisualOverflow):
(WebCore::InlineFlowBox::addTextBoxVisualOverflow):

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::selectionRect):
(WebCore::InlineTextBox::paint):
(WebCore::InlineTextBox::positionForOffset):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::addOverflowFromChildren):
(WebCore::RenderBlock::paintChildren):
(WebCore::RenderBlock::paintEllipsisBoxes):
(WebCore::RenderBlock::inlineSelectionGaps):
(WebCore::RenderBlock::adjustPointToColumnContents):
(WebCore::RenderBlock::flipForWritingModeIncludingColumns):
(WebCore::RenderBlock::adjustForColumns):

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::FloatingObject::right):
(WebCore::RenderBlock::FloatingObject::bottom):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::reflectedRect):
(WebCore::RenderBox::localCaretRect):
(WebCore::RenderBox::addShadowOverflow):
(WebCore::RenderBox::addLayoutOverflow):
(WebCore::RenderBox::visualOverflowRectForPropagation):
(WebCore::RenderBox::layoutOverflowRectForPropagation):
(WebCore::RenderBox::flipForWritingMode):

  • rendering/RenderFrameSet.cpp:

(WebCore::RenderFrameSet::paintColumnBorder):
(WebCore::RenderFrameSet::paintRowBorder):

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::paintOutlineForLine):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::getRectToExpose):
(WebCore::cornerRect):
(WebCore::RenderLayer::positionOverflowControls):
(WebCore::RenderLayer::overflowBottom):
(WebCore::RenderLayer::overflowRight):
(WebCore::RenderLayer::paintResizer):

  • rendering/RenderLineBoxList.cpp:

(WebCore::RenderLineBoxList::rangeIntersectsRect):
(WebCore::RenderLineBoxList::paint):

  • rendering/RenderListItem.cpp:

(WebCore::RenderListItem::positionListMarker):

  • rendering/RenderListMarker.cpp:

(WebCore::RenderListMarker::paint):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::repaintAfterLayoutIfNeeded):

  • rendering/RenderOverflow.h:

(WebCore::RenderOverflow::RenderOverflow):
(WebCore::RenderOverflow::addLayoutOverflow):
(WebCore::RenderOverflow::addVisualOverflow):
(WebCore::RenderOverflow::setLayoutOverflow):
(WebCore::RenderOverflow::setVisualOverflow):
(WebCore::RenderOverflow::resetLayoutOverflow):

  • rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::shouldPaint):

  • rendering/RenderScrollbarTheme.cpp:

(WebCore::RenderScrollbarTheme::constrainTrackRectToTrackPieces):

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::paint):

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::paint):

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::paintObject):

  • rendering/RenderText.cpp:

(WebCore::RenderText::absoluteQuads):

  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::forwardEvent):

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::paintMenuListButtonGradients):
(WebCore::RenderThemeMac::paintMenuListButton):
(WebCore::RenderThemeMac::paintSliderTrack):

  • rendering/RenderView.cpp:

(WebCore::RenderView::computeRectForRepaint):
(WebCore::RenderView::docBottom):
(WebCore::RenderView::docRight):

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::paddedLayoutOverflowRect):

  • rendering/svg/RenderSVGInlineText.cpp:

(WebCore::RenderSVGInlineText::localCaretRect):

../WebKit/mac:

  • WebView/WebHTMLView.mm:

(setNeedsDisplayInRect):

../WebKit2:

  • Platform/Region.cpp:

(WebKit::Region::Shape::Shape):

  • UIProcess/API/mac/WKPrintingView.mm:

(pageDidComputePageRects):

  • UIProcess/FindIndicator.cpp:

(WebKit::FindIndicator::draw):

  • UIProcess/TiledDrawingAreaProxy.cpp:

(WebKit::TiledDrawingAreaProxy::invalidate):
(WebKit::TiledDrawingAreaProxy::paint):
(WebKit::TiledDrawingAreaProxy::createTiles):

  • UIProcess/mac/ChunkedUpdateDrawingAreaProxyMac.mm:

(WebKit::ChunkedUpdateDrawingAreaProxy::drawUpdateChunkIntoBackingStore):

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::callSetWindow):

13:38 Changeset [77285] by inferno@chromium.org

2011-02-01 Abhishek Arya <inferno@chromium.org>

Unreviewed.

Rebaseline my test for QT, Leopard from r77262 due
to minor comment error differences.

  • platform/mac-leopard/fast/css/stylesheet-candidate-nodes-crash-expected.txt: Added.
  • platform/qt/fast/css/stylesheet-candidate-nodes-crash-expected.txt: Added.
13:36 Changeset [77284] by mrowe@apple.com

Merge r72230.

13:36 Changeset [77283] by mrowe@apple.com

Merge r69125.

13:34 Changeset [77282] by andersca@apple.com

2011-02-01 Anders Carlsson <andersca@apple.com>

Reviewed by Adam Roben.

Move flushPendingLayerChanges to LayerTreeHostMac
https://bugs.webkit.org/show_bug.cgi?id=53525

In preparation for adding more Mac specific code to flushPendingLayerChanges.

  • WebProcess/WebPage/LayerTreeHost.cpp:
  • WebProcess/WebPage/LayerTreeHost.h:
  • WebProcess/WebPage/mac/LayerTreeHostMac.h:
  • WebProcess/WebPage/mac/LayerTreeHostMac.mm: (WebKit::LayerTreeHostMac::flushPendingLayerChanges):
13:28 Changeset [77281] by xji@chromium.org

2011-02-01 Xiaomei Ji <xji@chromium.org>

Unreviewed.

Rebaseline after r77267.

  • platform/chromium-linux/fast/dom/34176-expected.checksum: Added.
  • platform/chromium-linux/fast/dom/34176-expected.png: Added.
  • platform/chromium-mac/fast/dom/34176-expected.checksum: Added.
  • platform/chromium-mac/fast/dom/34176-expected.png: Added.
  • platform/chromium-win/fast/dom/34176-expected.checksum: Added.
  • platform/chromium-win/fast/dom/34176-expected.png: Added.
  • platform/chromium-win/fast/dom/34176-expected.txt: Added.
  • platform/win/fast/dom/34176-expected.txt: Added.
13:26 Changeset [77280] by mrowe@apple.com

Merge r74854.

13:15 Changeset [77279] by mihaip@chromium.org

2011-02-01 Mihai Parparita <mihaip@chromium.org>

Reviewed by James Robinson.

[Chromium] run-chromium-webkit-unit-tests looks for binaries in the wrong place
https://bugs.webkit.org/show_bug.cgi?id=53522

  • Scripts/run-chromium-webkit-unit-tests:
12:50 Changeset [77278] by xji@chromium.org

2011-02-01 Xiaomei Ji <xji@chromium.org>

Unreviewed.

  • fast/dom/34176.html: Removed properties svn:executable and svn:mime-type.
12:44 Changeset [77277] by ggaren@apple.com

2011-02-01 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

REGRESSION(77082): GC-related crashes seen: on WebKit2 bot; on GTK 32bit
bot; loading trac pages; typing in search field
https://bugs.webkit.org/show_bug.cgi?id=53519


The crashes were all caused by failure to run an object's destructor.

  • runtime/CollectorHeapIterator.h: (JSC::ObjectIterator::ObjectIterator): Don't skip forward upon construction. The iterator class used to do that when it was designed for prior-to-beginning initialization. I forgot to remove this line of code when I changed the iterator to normal initialization.


Skipping forward upon construction was causing the heap to skip running
the destructor for the very first object in a block when destroying the
block. This usually did not crash, since block destruction is rare and
most objects have pretty trivial destructors. However, in the rare case
when the heap would destroy a block whose first object was a global
object or a DOM node, BOOM.

12:39 Changeset [77276] by dglazkov@chromium.org

2011-02-01 Dimitri Glazkov <dglazkov@chromium.org>

Remove expectations of failure for passing tests.

  • platform/chromium/test_expectations.txt: Fewer fails.
12:35 Changeset [77275] by abarth@webkit.org

2011-02-01 Adam Barth <abarth@webkit.org>

Reviewed by Mihai Parparita.

Using Control-C to cancel webkit-patch or other python tools causes
unpleasant traceback console spew
https://bugs.webkit.org/show_bug.cgi?id=53462

Catch the exception and don't print the stack trace.

  • Scripts/webkit-patch:
12:35 Changeset [77274] by bdakin@apple.com

Fix for <rdar://problem/8492788> Adopt WKScrollbarPainterController

Reviewed by Sam Weinig.

Source/WebCore:

Lots of new WebCoreSystemInterface functions to export.

  • WebCore.exp.in:
  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:

Let the scrollAnimator know when the mouse has
moved anywhere inside the page, and when the mouse
has moved in or out of the window.

  • page/EventHandler.cpp:

(WebCore::EventHandler::mouseMoved):
(WebCore::EventHandler::updateMouseEventTargetNode):

Let the scrollAnimator know when the window has become
active or inactive.

  • page/FocusController.cpp:

(WebCore::FocusController::setActive):

Let the scrollAnimator know when all of these things
are happening.

  • page/FrameView.cpp:

(WebCore::FrameView::setContentsSize):
(WebCore::FrameView::didMoveOnscreen):
(WebCore::FrameView::willMoveOffscreen):
(WebCore::FrameView::currentMousePosition):
(WebCore::FrameView::contentsResized):

New functions called through WebKit2 that allow the
scrollAnimator to know when a live resize starts and ends.
(WebCore::FrameView::willStartLiveResize):
(WebCore::FrameView::willEndLiveResize):

  • page/FrameView.h:


New functions on ScrollAnimator that pass information
to the WKPainterController when we're using one.

  • platform/ScrollAnimator.h:

(WebCore::ScrollAnimator::scrollableArea):
(WebCore::ScrollAnimator::contentAreaWillPaint):
(WebCore::ScrollAnimator::mouseEnteredContentArea):
(WebCore::ScrollAnimator::mouseExitedContentArea):
(WebCore::ScrollAnimator::mouseMovedInContentArea):
(WebCore::ScrollAnimator::willStartLiveResize):
(WebCore::ScrollAnimator::contentsResized):
(WebCore::ScrollAnimator::willEndLiveResize):
(WebCore::ScrollAnimator::contentAreaDidShow):
(WebCore::ScrollAnimator::contentAreaDidHide):
(WebCore::ScrollAnimatorMac::ScrollAnimatorMac):
(WebCore::ScrollAnimatorMac::scrollbarPainterDelegate):
(WebCore::ScrollAnimatorMac::setPainterForPainterController):
(WebCore::ScrollAnimatorMac::removePainterFromPainterController):
(WebCore::ScrollAnimatorMac::notityPositionChanged):
(WebCore::ScrollAnimatorMac::contentAreaWillPaint):
(WebCore::ScrollAnimatorMac::mouseEnteredContentArea):
(WebCore::ScrollAnimatorMac::mouseExitedContentArea):
(WebCore::ScrollAnimatorMac::mouseMovedInContentArea):
(WebCore::ScrollAnimatorMac::willStartLiveResize):
(WebCore::ScrollAnimatorMac::contentsResized):
(WebCore::ScrollAnimatorMac::willEndLiveResize):
(WebCore::ScrollAnimatorMac::contentAreaDidShow):
(WebCore::ScrollAnimatorMac::contentAreaDidHide):

Let the scrollAnimator know when this is happening.

  • platform/ScrollView.cpp:

(WebCore::ScrollView::paint):

New function lets the scrollAnimator get the current
mouse position.

  • platform/ScrollView.h:

(WebCore::ScrollView::currentMousePosition):

New function that returns the scrollAnimator when needed.

  • platform/ScrollableArea.h:

(WebCore::ScrollableArea::scrollAnimator):

Keep track of if we're in a live resize using a new memeber
variable.

  • platform/mac/ScrollAnimatorMac.h:

(WebCore::ScrollAnimatorMac::inLiveResize):

  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::view):

New delegates for the WKPainter and WKPainterController
(-[ScrollbarPainterControllerDelegate initWithScrollAnimator:WebCore::]):
(-[ScrollbarPainterControllerDelegate contentAreaRectForScrollerImpPair:]):
(-[ScrollbarPainterControllerDelegate inLiveResizeForScrollerImpPair:]):
(-[ScrollbarPainterControllerDelegate mouseLocationInContentAreaForScrollerImpPair:]):
(-[ScrollbarPainterControllerDelegate scrollerImpPair:convertContentPoint:toScrollerImp:]):
(-[ScrollbarPainterControllerDelegate scrollerImpPair:setContentAreaNeedsDisplayInRect:]):
(-[ScrollbarPainterControllerDelegate scrollerImpPair:updateScrollerStyleForNewRecommendedScrollerStyle:]):
(-[ScrollKnobAnimation initWithScrollbarPainter:forScrollAnimator:WebCore::animateKnobAlphaTo:duration:]):
(-[ScrollKnobAnimation setCurrentProgress:]):
(-[ScrollbarPainterDelegate initWithScrollAnimator:WebCore::]):
(-[ScrollbarPainterDelegate convertRectToBacking:]):
(-[ScrollbarPainterDelegate convertRectFromBacking:]):
(-[ScrollbarPainterDelegate layer]):
(-[ScrollbarPainterDelegate setUpAnimation:scrollerPainter:animateKnobAlphaTo:duration:]):
(-[ScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:]):
(-[ScrollbarPainterDelegate scrollerImp:animateTrackAlphaTo:duration:]):
(-[ScrollbarPainterDelegate scrollerImp:overlayScrollerStateChangedTo:]):

Get the WKScrollbarPainterRefs to synch up with the
WKScrollbarPainterControllerRefs when appropriate

  • platform/mac/ScrollbarThemeMac.h:
  • platform/mac/ScrollbarThemeMac.mm:

(WebCore::ScrollbarThemeMac::registerScrollbar):
(WebCore::ScrollbarThemeMac::unregisterScrollbar):
(WebCore::ScrollbarThemeMac::setNewPainterForScrollbar):
(WebCore::ScrollbarThemeMac::usesOverlayScrollbars):

Implement ScrollableArea's virtual function contentsSize() for access
through the scrollAnimator.

  • rendering/RenderLayer.h:

(WebCore::RenderLayer::contentsSize):

Source/WebKit/mac:

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

Source/WebKit2:

Implement NSView's viewWillStartLiveResize and
viewDidEndLiveResize and propagate the messages down
to WebCore.

  • UIProcess/API/mac/WKView.mm:

(-[WKView viewWillStartLiveResize]):
(-[WKView viewDidEndLiveResize]):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::viewWillStartLiveResize):
(WebKit::WebPageProxy::viewWillEndLiveResize):

  • UIProcess/WebPageProxy.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::viewWillStartLiveResize):
(WebKit::WebPage::viewWillEndLiveResize):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:

A bunch of new WebKitSystemInterface functions.

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

12:28 Changeset [77273] by carol.szabo@nokia.com

2011-02-01 Carol Szabo <carol.szabo@nokia.com>

Reviewed by David Hyatt.

layoutTestController.counterValueForElementById does not return the correct value
https://bugs.webkit.org/show_bug.cgi?id=53037

  • fast/css/counters/deep-before-expected.txt: Added.
  • fast/css/counters/deep-before.html: Added. This tests whether DumpRenderTree properly retrieves counters and whether counters are properly set when the before pseudo element's renderer is not a direct child of the generating element's renderer.

2011-02-01 Carol Szabo <carol.szabo@nokia.com>

Reviewed by David Hyatt.

layoutTestController.counterValueForElementById does not return the correct value
https://bugs.webkit.org/show_bug.cgi?id=53037

Test: fast/css/counters/deep-before.html

  • rendering/RenderTreeAsText.cpp: (WebCore::counterValueForElement): Modified to use the newly available RenderObject::beforePseudoElement() and RenderObject::afterPseudoElement() instead of the old imperfect algorithm to find the before and after pseudo elements.
12:27 Changeset [77272] by antonm@chromium.org

2011-02-01 Anton Muhin <antonm@chromium.org>

Reviewed by Adam Barth.

Allow access for security origin same as this.
https://bugs.webkit.org/show_bug.cgi?id=53440

Hard to test as newly added path currently is never hit.

  • page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::canAccess): allow access if this == other
12:25 Changeset [77271] by dglazkov@chromium.org

2011-02-01 Dimitri Glazkov <dglazkov@chromium.org>

Added more flakiness expectations from bots.

  • platform/chromium/test_expectations.txt: Another one bites or doesn't bite the dust.
12:21 Changeset [77270] by mrowe@apple.com

Merge r73801.

12:17 Changeset [77269] by oliver@apple.com

2011-01-31 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

Update JSObject storage for new marking API
https://bugs.webkit.org/show_bug.cgi?id=53467

JSObject no longer uses EncodedJSValue for its property storage.
This produces a stream of mechanical changes to PropertySlot and
anonymous storage APIs.

  • JavaScriptCore.exp:
  • runtime/ArrayPrototype.cpp: (JSC::ArrayPrototype::ArrayPrototype):
  • runtime/BooleanConstructor.cpp: (JSC::constructBoolean): (JSC::constructBooleanFromImmediateBoolean):
  • runtime/BooleanObject.cpp: (JSC::BooleanObject::BooleanObject):
  • runtime/BooleanObject.h:
  • runtime/BooleanPrototype.cpp: (JSC::BooleanPrototype::BooleanPrototype):
  • runtime/DateInstance.cpp: (JSC::DateInstance::DateInstance):
  • runtime/DatePrototype.cpp: (JSC::DatePrototype::DatePrototype):
  • runtime/JSActivation.cpp: (JSC::JSActivation::getOwnPropertySlot):
  • runtime/JSArray.cpp: (JSC::JSArray::getOwnPropertySlot):
  • runtime/JSFunction.cpp: (JSC::JSFunction::getOwnPropertySlot):
  • runtime/JSGlobalObject.h: (JSC::JSGlobalObject::JSGlobalObject):
  • runtime/JSObject.cpp: (JSC::JSObject::fillGetterPropertySlot):
  • runtime/JSObject.h: (JSC::JSObject::getDirectLocation): (JSC::JSObject::offsetForLocation): (JSC::JSObject::putAnonymousValue): (JSC::JSObject::clearAnonymousValue): (JSC::JSObject::getAnonymousValue): (JSC::JSObject::putThisToAnonymousValue): (JSC::JSObject::locationForOffset): (JSC::JSObject::inlineGetOwnPropertySlot):
  • runtime/JSObjectWithGlobalObject.cpp: (JSC::JSObjectWithGlobalObject::JSObjectWithGlobalObject):
  • runtime/JSWrapperObject.h: (JSC::JSWrapperObject::JSWrapperObject): (JSC::JSWrapperObject::setInternalValue):
  • runtime/Lookup.cpp: (JSC::setUpStaticFunctionSlot):
  • runtime/NumberConstructor.cpp: (JSC::constructWithNumberConstructor):
  • runtime/NumberObject.cpp: (JSC::NumberObject::NumberObject): (JSC::constructNumber):
  • runtime/NumberObject.h:
  • runtime/NumberPrototype.cpp: (JSC::NumberPrototype::NumberPrototype):
  • runtime/PropertySlot.h: (JSC::PropertySlot::getValue): (JSC::PropertySlot::setValue): (JSC::PropertySlot::setRegisterSlot):
  • runtime/StringObject.cpp: (JSC::StringObject::StringObject):
  • runtime/StringPrototype.cpp: (JSC::StringPrototype::StringPrototype):
  • runtime/WriteBarrier.h: (JSC::WriteBarrierBase::setWithoutWriteBarrier):

2011-01-31 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

Update JSObject storage for new marking API
https://bugs.webkit.org/show_bug.cgi?id=53467

Update WebCore to handle new anonymous slot behaviour.

  • bindings/js/JSDOMWindowShell.cpp: (WebCore::JSDOMWindowShell::setWindow):
  • bindings/js/WorkerScriptController.cpp: (WebCore::WorkerScriptController::initScript):
  • bindings/scripts/CodeGeneratorJS.pm:
12:05 Changeset [77268] by dglazkov@chromium.org

2011-02-01 Dimitri Glazkov <dglazkov@chromium.org>

https://bugs.webkit.org/show_bug.cgi?id=53516
Test introduced in r77262 is crashing.

  • platform/chromium/test_expectations.txt: Added expectation to crash

while the fix is worked on.

12:02 Changeset [77267] by xji@chromium.org

2011-02-01 Xiaomei Ji <xji@chromium.org>

Reviewed by David Hyatt.

Fix a text rendering problem when enclosing block is RTL and text runs
are in different directionality.
https://bugs.webkit.org/show_bug.cgi?id=34176

The problem happens in the following example scenario (ABC represents
Hebrew characters):
<div dir=rtl>this is a <span><span>test <span>ABC</span></span></span></div>

The line consists of 3 text runs -- TextRun1 TextRun2 TextRun3. In which
TextRun1 and TextRun2's bidi level are 2, and TextRun3's bidi level is 1.
TextRun2 and TextRun3's least common ancestor is not a sibling of TextRun1.

The visual bidi run order of the text runs is TextRun3 TextRun1 TextRun2.

Inside RenderBlock::constructLine(), when RenderBlock::createLineBoxes()
creates InlineFlowBox for TextRun2, it should check an InlineFlowBox for
the run's render object's ancestor (not only its parent) has already
been constructed or has something following it on the line, in which
case, create a new box for TextRun2 instead of sharing the same box with
TextRun3.

In other words, the following 2 div should render the same results
(ABC represents Hebrew characters).
<div dir=rtl>this is a <span><span>test <span>ABC</span></span></span></div>
<div dir=rtl>this is a <span>Test <span>ABC</span></span></div>

Test: fast/dom/34176.html

  • rendering/RenderBlockLineLayout.cpp: (WebCore::parentIsConstructedOrHaveNext): (WebCore::RenderBlock::createLineBoxes):

2011-02-01 Xiaomei Ji <xji@chromium.org>

Reviewed by David Hyatt.

Fix a text rendering problem when enclosing block is RTL and text runs
are in different directionality.
https://bugs.webkit.org/show_bug.cgi?id=34176

The problem happens in the following example scenario (ABC represents
Hebrew characters):
<div dir=rtl>this is a <span><span>test <span>ABC</span></span></span></div>

The line consists of 3 text runs -- TextRun1 TextRun2 TextRun3. In which
TextRun1 and TextRun2's bidi level are 2, and TextRun3's bidi level is 1.
TextRun2 and TextRun3's least common ancestor is not a sibling of TextRun1.

The visual bidi run order of the text runs is TextRun3 TextRun1 TextRun2.

Inside RenderBlock::constructLine(), when RenderBlock::createLineBoxes()
creates InlineFlowBox for TextRun2, it should check an InlineFlowBox for
the run's render object's ancestor (not only its parent) has already
been constructed or has something following it on the line, in which
case, create a new box for TextRun2 instead of sharing the same box with
TextRun3.

In other words, the following 2 div should render the same results
(ABC represents Hebrew characters).
<div dir=rtl>this is a <span><span>test <span>ABC</span></span></span></div>
<div dir=rtl>this is a <span>Test <span>ABC</span></span></div>

  • fast/dom/34176.html: Added.
  • platform/mac/fast/dom/34176-expected.checksum: Added.
  • platform/mac/fast/dom/34176-expected.png: Added.
  • platform/mac/fast/dom/34176-expected.txt: Added.
11:39 Changeset [77266] by hyatt@apple.com

Update printing layout test for the ceiling->floor change.

11:37 Changeset [77265] by pkasting@chromium.org

Merge 76557 - 2011-01-24 Peter Kasting <pkasting@google.com>

Reviewed by Darin Adler.

Roll back r67261 ("Don't fire onclick on middle clicks") due to
regressions.
https://bugs.webkit.org/show_bug.cgi?id=46733

  • fast/events/mouse-click-events-expected.txt:
  • fast/events/script-tests/mouse-click-events.js:

2011-01-24 Peter Kasting <pkasting@google.com>

Reviewed by Darin Adler.

Roll back r67261 ("Don't fire onclick on middle clicks") due to
regressions.
https://bugs.webkit.org/show_bug.cgi?id=46733

  • html/HTMLAnchorElement.cpp: (WebCore::isLinkClick):
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::preDispatchEventHandler): (WebCore::HTMLInputElement::postDispatchEventHandler): (WebCore::HTMLInputElement::defaultEventHandler):
  • page/EventHandler.cpp: (WebCore::EventHandler::handleMouseDoubleClickEvent): (WebCore::EventHandler::handleMouseReleaseEvent):

TBR=commit-queue@webkit.org
Review URL: http://codereview.chromium.org/6250083

11:22 Changeset [77264] by dbates@webkit.org

2011-02-01 Scott Cameron <sccameron@rim.com>

Reviewed by Daniel Bates.

Use Windows format for MinGW HTTPD path.
https://bugs.webkit.org/show_bug.cgi?id=53503

  • Scripts/webkitperl/httpd.pm:
    • Use single-quotes around MySys value for $httpdPath in getHTTPDPath() so that we don't have to escape the space characters in the path. Also, changed path to Windows-style path and removed FIXME comment.
11:21 Changeset [77263] by mihaip@chromium.org

2011-02-01 Mihai Parparita <mihaip@chromium.org>

Unreviewed. Include actual values in fast/canvas/webgl/gl-teximage.html
(removed by r77129) in the case of failure.

  • fast/canvas/webgl/gl-teximage.html:
11:16 Changeset [77262] by inferno@chromium.org

2011-01-31 Abhishek Arya <inferno@chromium.org>

Reviewed by Dan Bernstein.

Tests that a removed svg style element is not accessed again in document's
style recalc code and does not result in crash.
https://bugs.webkit.org/show_bug.cgi?id=53441

  • fast/css/stylesheet-candidate-nodes-crash-expected.txt: Added.
  • fast/css/stylesheet-candidate-nodes-crash.xhtml: Added.

2011-02-01 Abhishek Arya <inferno@chromium.org>

Reviewed by Dan Bernstein.

Do not add a node in the document's stylesheet candidate node list if the
node is already removed from document.
https://bugs.webkit.org/show_bug.cgi?id=53441

Test: fast/css/stylesheet-candidate-nodes-crash.xhtml

  • dom/Document.cpp: (WebCore::Document::addStyleSheetCandidateNode):
11:09 Changeset [77261] by dglazkov@chromium.org

2011-02-01 Dimitri Glazkov <dglazkov@chromium.org>

More flakiness updates.

  • platform/chromium/test_expectations.txt: Moar flakiness recorded.
10:50 Changeset [77260] by dbates@webkit.org

2011-02-01 Daniel Bates <dbates@rim.com>

Reviewed by Antonio Gomes.

Modify RandomNumberSeed.h to use USE(MERSENNE_TWISTER_19937)
https://bugs.webkit.org/show_bug.cgi?id=53506

Currently, use of the Mersenne Twister pseudorandom number generator
is hardcoded to the Windows CE port. With the passing of bug #53253,
we can generalize support for this PRNG to all ports that use srand(3)
and rand(3), including Windows CE.

  • wtf/RandomNumberSeed.h: (WTF::initializeRandomNumberGenerator):
10:49 Changeset [77259] by hyatt@apple.com

Land Webpage.cpp for previous patch. Change was lost after conflict resolution from a merge.

10:46 Changeset [77258] by hyatt@apple.com

Back out accidental commit of Connection.cpp

10:44 Changeset [77257] by hyatt@apple.com

https://bugs.webkit.org/show_bug.cgi?id=46422, make printing and pagination work
with vertical text.

Reviewed by Darin Adler.

../WebCore:

Change printing functions to check writing-mode and properly swap width and height
as needed.

Fix the setScrollOrigin function so that the origin doesn't cause
scroll spasming during printing (this is only partially successful, but it's better
than it was).

Rewrite computePageRects to handle both RTL documents properly as well as vertical
text documents properly.

  • WebCore.exp.in:
  • page/FrameView.cpp:

(WebCore::FrameView::adjustViewSize):
(WebCore::FrameView::forceLayoutForPagination):

  • page/PrintContext.cpp:

(WebCore::PrintContext::computePageRects):
(WebCore::PrintContext::computePageRectsWithPageSizeInternal):
(WebCore::PrintContext::computeAutomaticScaleFactor):
(WebCore::PrintContext::spoolPage):
(WebCore::PrintContext::spoolRect):

  • page/PrintContext.h:
  • page/mac/WebCoreFrameView.h:
  • platform/ScrollView.cpp:

(WebCore::ScrollView::wheelEvent):

  • platform/ScrollView.h:
  • platform/mac/ScrollViewMac.mm:

(WebCore::ScrollView::platformSetScrollOrigin):

  • rendering/RenderView.cpp:

(WebCore::RenderView::layout):

../WebKit/mac:

Change printing functions to check writing-mode and properly swap width and height
as needed.

  • WebView/WebDynamicScrollBarsView.mm:

(-[WebDynamicScrollBarsView setScrollOrigin:updatePositionAtAll:immediately:]):

  • WebView/WebFrame.mm:

(-[WebFrame _computePageRectsWithPrintScaleFactor:pageSize:]):

  • WebView/WebFrameInternal.h:
  • WebView/WebHTMLView.mm:

(-[WebHTMLView _web_setPrintingModeRecursive]):
(-[WebHTMLView _web_clearPrintingModeRecursive]):
(-[WebHTMLView _web_setPrintingModeRecursiveAndAdjustViewSize]):
(-[WebHTMLView _beginPrintModeWithMinimumPageWidth:height:maximumPageWidth:]):
(-[WebHTMLView _beginPrintModeWithPageWidth:height:shrinkToFit:]):
(-[WebHTMLView _endPrintMode]):
(-[WebHTMLView _beginScreenPaginationModeWithPageSize:shrinkToFit:]):
(-[WebHTMLView _endScreenPaginationMode]):
(-[WebHTMLView layoutToMinimumPageWidth:height:maximumPageWidth:adjustingViewSize:]):
(-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:maximumPageLogicalWidth:adjustViewSize:paginateScreenContent:]):
(-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]):
(-[WebHTMLView _scaleFactorForPrintOperation:]):
(-[WebHTMLView setPageWidthForPrinting:]):
(-[WebHTMLView knowsPageRange:]):

../WebKit2:

Change printing functions to check writing-mode and properly swap width and height
as needed.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::computePagesForPrinting):

10:29 Changeset [77256] by mihaip@chromium.org

2011-02-01 Mihai Parparita <mihaip@chromium.org>

Unreviewed roll of Chromium deps to r73306. This picks up a fix to get
the WebKit root dir correctly after the move to Source/. This allows
tests like http/tests/security/frame-loading-via-document-write.html
(which use LayoutTestController.pathToLocalResource) to pass with the
Chromium DRT.

  • DEPS:
09:57 Changeset [77255] by dglazkov@chromium.org

2011-02-01 Dimitri Glazkov <dglazkov@chromium.org>

Updated flaky test expectations according to build bot results.

  • platform/chromium/test_expectations.txt: Flakiness recorded.
09:22 Changeset [77254] by mnaganov@chromium.org

2011-02-01 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Fix profiles reset to avoid clearing heap profiles in Chromium.

https://bugs.webkit.org/show_bug.cgi?id=53500

  • inspector/InspectorProfilerAgent.cpp: (WebCore::InspectorProfilerAgent::resetFrontendProfiles):
09:09 Changeset [77253] by kbalazs@webkit.org

2011-02-01 Balazs Kelemen <kbalazs@webkit.org>

Reviewed by Andreas Kling.

[Qt][WK2] Add a way to use shared process model in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=53090

  • MiniBrowser/qt/BrowserView.cpp: (BrowserView::BrowserView): Removed the m_context member. From now the context is guaranteed to be non-null and we don't need to store that in the object.
  • MiniBrowser/qt/BrowserView.h:
  • MiniBrowser/qt/BrowserWindow.cpp: Added static bool to determine that new windows need to be created with their own context or not. Use the same context and web process by default to be inilne with the other ports. (BrowserWindow::BrowserWindow): (BrowserWindow::newWindow):
  • MiniBrowser/qt/BrowserWindow.h:
  • MiniBrowser/qt/main.cpp: (main): Added command line switch to be able to use the non-shared process model. Simplify the handling of the command line switches a little bit.
08:59 Changeset [77252] by mnaganov@chromium.org

2011-02-01 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Chromium] Landing detailed heap snapshots, part 1.

https://bugs.webkit.org/show_bug.cgi?id=53173

Adding code for accessing heap snapshot data and
performing graph calculations.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/HeapSnapshot.js: (WebInspector.HeapSnapshotArraySlice): Helper class to avoid array contents copying. (WebInspector.HeapSnapshotEdge): Wrapper for accessing graph edge properties. (WebInspector.HeapSnapshotEdgeIterator): (WebInspector.HeapSnapshotNode): Wrapper for accessing graph node properties. (WebInspector.HeapSnapshotNodeIterator): (WebInspector.HeapSnapshot): Wrapper for the heap snapshot. (WebInspector.HeapSnapshotFilteredOrderedIterator): (WebInspector.HeapSnapshotEdgesProvider): (WebInspector.HeapSnapshotNodesProvider): (WebInspector.HeapSnapshotPathFinder):
  • inspector/front-end/HeapSnapshotView.js: (WebInspector.HeapSnapshotView.prototype._convertSnapshot):
07:46 Changeset [77251] by aroben@apple.com

Fix linker warnings in Release_LTCG builds

  • WebCore.vcproj/WebCore.vcproj: Exclude EventNames.cpp and EventTarget.cpp from all

configurations, since they get pulled in via DOMAllInOne.cpp.

06:57 Changeset [77250] by zoltan@webkit.org

[Qt] Add Window menu and Toggle FullScreen action to MiniBrowser.
https://bugs.webkit.org/show_bug.cgi?id=53491

Reviewed by Andreas Kling.

  • MiniBrowser/qt/BrowserWindow.cpp:

(BrowserWindow::BrowserWindow):
(BrowserWindow::toggleFullScreenMode):

  • MiniBrowser/qt/BrowserWindow.h:
06:53 Changeset [77249] by apavlov@chromium.org

2011-02-01 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [Chromium] Wrongly labelled context-menu item for links in Web Inspector's side-pane
https://bugs.webkit.org/show_bug.cgi?id=53482

  • English.lproj/localizedStrings.js:
  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.populateHrefContextMenu):
  • inspector/front-end/inspector.js: (WebInspector.resourceForURL): (WebInspector.openLinkExternallyLabel):

2011-02-01 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [Chromium] Wrongly labelled context-menu item for links in Web Inspector's side-pane
https://bugs.webkit.org/show_bug.cgi?id=53482

  • src/js/DevTools.js: (WebInspector.openLinkExternallyLabel): Override to customize a context menu item label
06:40 Changeset [77248] by commit-queue@webkit.org

2011-02-01 Dave Tapuska <dtapuska@rim.com>

Reviewed by Gavin Barraclough.

MacroAssemblerARM would generate code that did 32bit loads
on addresses that were not aligned. More specifically it would
generate a ldr r8,[r1, #7] which isn't valid on ARMv5 and lower.
The intended instruction really is ldrb r8,[r1, #7]; ensure we
call load8 instead of load32.

https://bugs.webkit.org/show_bug.cgi?id=46095

  • assembler/MacroAssemblerARM.h: (JSC::MacroAssemblerARM::set32Test32): (JSC::MacroAssemblerARM::set32Test8):
06:38 Changeset [77247] by ossy@webkit.org

Unreviewed.

fast/loader/onload-policy-ignore-for-frame.html fails on Qt bot
https://bugs.webkit.org/show_bug.cgi?id=53490

Add Qt specific expected result.

  • platform/qt/fast/loader/onload-policy-ignore-for-frame-expected.txt: Copied from LayoutTests/fast/loader/onload-policy-ignore-for-frame-expected.txt.
06:35 Changeset [77246] by antonm@chromium.org

2011-02-01 Anton Muhin <antonm@chromium.org>

Reviewed by Adam Barth.

Propagate parent document security origin to newly create Document XML response
https://bugs.webkit.org/show_bug.cgi?id=53444

Covered by the existing tests.

  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::responseXML):
05:32 Changeset [77245] by zoltan@webkit.org

[Qt] Add Toggle Frame Flattening, Auto Load Images and Disable JavaScript actions to MiniBrowser.
https://bugs.webkit.org/show_bug.cgi?id=53489

Reviewed by Andreas Kling.

Add Toggle Frame Flattening action to Develop menu. Add Auto Load Images and Disable JavaScript actions
to Settings menu.

  • MiniBrowser/qt/BrowserWindow.cpp:

(BrowserWindow::BrowserWindow):
(BrowserWindow::toggleFrameFlattening):
(BrowserWindow::toggleDisableJavaScript):
(BrowserWindow::toggleAutoLoadImages):

  • MiniBrowser/qt/BrowserWindow.h:
05:07 Changeset [77244] by mnaganov@chromium.org

Merge 77127 - 2011-01-30 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: speed up network panel rendering.
https://bugs.webkit.org/show_bug.cgi?id=53397

  • inspector/front-end/DataGrid.js: (WebInspector.DataGrid.prototype.get scrollContainer):
  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype.elementsToRestoreScrollPositionsFor): (WebInspector.NetworkPanel.prototype._positionSummaryBar): (WebInspector.NetworkPanel.prototype._createTable): (WebInspector.NetworkPanel.prototype._exportResource): (WebInspector.NetworkPanel.prototype._onScroll):
  • inspector/front-end/networkPanel.css: (.network-sidebar .data-grid.small tr.offscreen): (.network-sidebar .data-grid tr.offscreen): (.network-sidebar .data-grid tr.offscreen td):

TBR=pfeldman@chromium.org
Review URL: http://codereview.chromium.org/6409044

04:42 Changeset [77243] by gyuyoung.kim@samsung.com

2011-02-01 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Antonio Gomes.

[EFL] Add an API to get proxy address.
https://bugs.webkit.org/show_bug.cgi?id=52990

Gets the proxy URI from network backend. This API returns a proxy URI
which is set up by ewk_settings_proxy_uri_set(). But, it only implements
this API for libsoup backend.

  • ewk/ewk_settings.cpp: (ewk_settings_proxy_uri_get):
  • ewk/ewk_settings.h:
04:42 Changeset [77242] by darin@chromium.org

2011-02-01 Darin Fisher <darin@chromium.org>

Reviewed by Eric Seidel.

Fix some Visual Studio compiler warnings.
https://bugs.webkit.org/show_bug.cgi?id=53476

  • wtf/MathExtras.h: (clampToInteger): (clampToPositiveInteger):
  • wtf/ThreadingWin.cpp: (WTF::absoluteTimeToWaitTimeoutInterval):

2011-02-01 Darin Fisher <darin@chromium.org>

Reviewed by Eric Seidel.

Fix some Visual Studio compiler warnings.
https://bugs.webkit.org/show_bug.cgi?id=53476

  • src/GraphicsContext3DChromium.cpp: (WebCore::GraphicsContext3DInternal::paintRenderingResultsToCanvas):
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::forms):
  • src/WebMediaPlayerClientImpl.cpp: (WebKit::WebMediaPlayerClientImpl::repaint):
  • src/WebScrollbarImpl.cpp: (WebKit::WebScrollbarImpl::setValue):
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::doPixelReadbackToCanvas): (WebKit::WebViewImpl::setZoomLevel): (WebKit::WebViewImplScrollbarPaintInterface::paint):
04:16 Changeset [77241] by yurys@chromium.org

2011-02-01 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Rollout r77230 which caused many layout tests
crashes on Chromium Debug bots.

Async event handlers should not fire within a modal dialog
https://bugs.webkit.org/show_bug.cgi?id=53202

  • dom/Document.cpp: (WebCore::Document::Document):
  • dom/EventQueue.cpp: (WebCore::EventQueue::EventQueue): (WebCore::EventQueue::enqueueEvent): (WebCore::EventQueue::pendingEventTimerFired):
  • dom/EventQueue.h:

2011-02-01 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Rollout r77230 which caused many layout tests
crashes on Chromium Debug bots.

Async event handlers should not fire within a modal dialog
https://bugs.webkit.org/show_bug.cgi?id=53202

  • fast/events/scroll-event-during-modal-dialog-expected.txt: Removed.
  • fast/events/scroll-event-during-modal-dialog.html: Removed.
02:48 Changeset [77240] by zherczeg@webkit.org

LightElement changes does not require relayout.
https://bugs.webkit.org/show_bug.cgi?id=53232

Reviewed by Dirk Schulze.

When an attribute of a LightElement changes, it
send an update message to the lighting filters
to update its corresponding LightSource objects,
and repaint the filters.

Duplicated 'id' attributes removed from svg-filter-animation.svg.

Existing dynamic-update tests covers this feature.

5x speedup on manual-tests/svg-filter-animation.svg

  • manual-tests/svg-filter-animation.svg:
  • platform/graphics/filters/DistantLightSource.h:
  • platform/graphics/filters/FEDiffuseLighting.cpp:

(WebCore::FEDiffuseLighting::setLightingColor):
(WebCore::FEDiffuseLighting::setSurfaceScale):
(WebCore::FEDiffuseLighting::setDiffuseConstant):
(WebCore::FEDiffuseLighting::setKernelUnitLengthX):
(WebCore::FEDiffuseLighting::setKernelUnitLengthY):

  • platform/graphics/filters/FEDiffuseLighting.h:
  • platform/graphics/filters/LightSource.cpp:

(WebCore::PointLightSource::setX):
(WebCore::PointLightSource::setY):
(WebCore::PointLightSource::setZ):
(WebCore::SpotLightSource::setX):
(WebCore::SpotLightSource::setY):
(WebCore::SpotLightSource::setZ):
(WebCore::SpotLightSource::setPointsAtX):
(WebCore::SpotLightSource::setPointsAtY):
(WebCore::SpotLightSource::setPointsAtZ):
(WebCore::SpotLightSource::setSpecularExponent):
(WebCore::SpotLightSource::setLimitingConeAngle):
(WebCore::DistantLightSource::setAzimuth):
(WebCore::DistantLightSource::setElevation):
(WebCore::LightSource::setAzimuth):
(WebCore::LightSource::setElevation):
(WebCore::LightSource::setX):
(WebCore::LightSource::setY):
(WebCore::LightSource::setZ):
(WebCore::LightSource::setPointsAtX):
(WebCore::LightSource::setPointsAtY):
(WebCore::LightSource::setPointsAtZ):
(WebCore::LightSource::setSpecularExponent):
(WebCore::LightSource::setLimitingConeAngle):

  • platform/graphics/filters/LightSource.h:
  • platform/graphics/filters/PointLightSource.h:
  • platform/graphics/filters/SpotLightSource.h:
  • rendering/svg/RenderSVGResourceFilter.cpp:

(WebCore::RenderSVGResourceFilter::primitiveAttributeChanged):

  • svg/SVGFEDiffuseLightingElement.cpp:

(WebCore::SVGFEDiffuseLightingElement::setFilterEffectAttribute):
(WebCore::SVGFEDiffuseLightingElement::lightElementAttributeChanged):
(WebCore::SVGFEDiffuseLightingElement::build):
(WebCore::SVGFEDiffuseLightingElement::findLightElement):
(WebCore::SVGFEDiffuseLightingElement::findLight):

  • svg/SVGFEDiffuseLightingElement.h:
  • svg/SVGFELightElement.cpp:

(WebCore::SVGFELightElement::svgAttributeChanged):

  • svg/SVGFilterPrimitiveStandardAttributes.cpp:

(WebCore::SVGFilterPrimitiveStandardAttributes::setFilterEffectAttribute):

  • svg/SVGFilterPrimitiveStandardAttributes.h:
02:41 Changeset [77239] by rolandsteiner@chromium.org

2011-02-01 Roland Steiner <rolandsteiner@chromium.org>

Reviewed by Dimitri Glazkov.

Bug 53289 - DOM: Move DocumentOrderedMap from Document into separate files
https://bugs.webkit.org/show_bug.cgi?id=53289

Moving the nested class DocumentOrderedMap from Document into separate files,
updating code where necessary.

No new tests. (refactoring)

  • Android.mk:
  • CMakeLists.txt:
  • GNUMakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/Document.cpp: (WebCore::Document::getElementById): (WebCore::Document::getImageMap):
  • dom/Document.h:
  • dom/DocumentOrderedMap.cpp: Added. (WebCore::keyMatchesId): (WebCore::keyMatchesMapName): (WebCore::keyMatchesLowercasedMapName): (WebCore::DocumentOrderedMap::clear): (WebCore::DocumentOrderedMap::add): (WebCore::DocumentOrderedMap::remove): (WebCore::DocumentOrderedMap::get): (WebCore::DocumentOrderedMap::getElementById): (WebCore::DocumentOrderedMap::getElementByMapName): (WebCore::DocumentOrderedMap::getElementByLowercasedMapName):
  • dom/DocumentOrderedMap.h: Added. (WebCore::DocumentOrderedMap::contains): (WebCore::DocumentOrderedMap::containsMultiple):
  • dom/DOMAllInOne.cpp:
02:32 Changeset [77238] by commit-queue@webkit.org

2010-01-28 Commit Queue <commit-queue@webkit.org>

Unreviewed. Test commit for commit-queue@webkit.org.

02:27 Changeset [77237] by commit-queue@webkit.org

2010-01-28 Commit Queue <commit-queue@webkit.org>

Unreviewed. Test commit for commit-queue@webkit.org.

02:18 Changeset [77236] by hans@chromium.org

2011-02-01 Hans Wennborg <hans@chromium.org>

Reviewed by Jeremy Orlow.

Chromium: remove WebIDBCallbacks::onSucces()
https://bugs.webkit.org/show_bug.cgi?id=53415

Remove un-used function.

  • public/WebIDBCallbacks.h:
01:58 Changeset [77235] by mario@webkit.org

2011-02-01 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Martin Robinson.

[Gtk] atk_text_set_caret_offset fails for list items
https://bugs.webkit.org/show_bug.cgi?id=53388

Allow using text ranges across list items.

  • accessibility/gtk/AccessibilityObjectAtk.cpp: (WebCore::AccessibilityObject::allowsTextRanges): Add list items to the list of accessibility objects supporting text ranges.

2011-02-01 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Martin Robinson.

[Gtk] atk_text_set_caret_offset fails for list items
https://bugs.webkit.org/show_bug.cgi?id=53388

Update unit test to check the fix for this bug.

  • tests/testatk.c: (testWebkitAtkCaretOffsets): Ensure setting the caret in a list item through the AtkText interface is possible.
01:54 Changeset [77234] by mario@webkit.org

2011-02-01 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Martin Robinson.

[GTK] character range extents is off when the end of a wrapped line is included
https://bugs.webkit.org/show_bug.cgi?id=53323

Fixed wrong calculation getting the range extents.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_text_get_range_extents): Removed '+1' since the requested interval shouldn't include the last character.

2011-02-01 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Martin Robinson.

[GTK] character range extents is off when the end of a wrapped line is included
https://bugs.webkit.org/show_bug.cgi?id=53323

Update unit test to check the fix for this bug.

  • tests/testatk.c: (testWebkitAtkGetExtents): Check that the extent for a full line are the same height than for a partial section of the same line.
01:49 Changeset [77233] by mario@webkit.org

2011-02-01 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Caret Offset is one off at the end of wrapped lines
https://bugs.webkit.org/show_bug.cgi?id=53300

Consider linebreaks as special cases.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (objectAndOffsetUnignored): In order to avoid getting wrong values when around linebreaks, we need to workaround this by explicitly avoiding those '\n' text nodes from affecting the result of calling to TextIterator:rangeLength().

2011-02-01 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Caret Offset is one off at the end of wrapped lines
https://bugs.webkit.org/show_bug.cgi?id=53300

Update unit test to check the fix for this bug.

  • tests/testatk.c: (testWebkitAtkCaretOffsetsAndExtranousWhiteSpaces): Set and get the caret offset at the edge of the line.
01:37 Changeset [77232] by yurys@chromium.org

2011-02-01 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Fix Chromium Debug compilation broken by r77228.

[Chromium] Autofill should work with HTML5 form elements
https://bugs.webkit.org/show_bug.cgi?id=51809

  • src/WebInputElement.cpp: (WebKit::toWebInputElement):
01:32 Changeset [77231] by rolandsteiner@chromium.org

2011-02-01 Roland Steiner <rolandsteiner@chromium.org>

Unreviewed, rolling out r77229.
http://trac.webkit.org/changeset/77229
https://bugs.webkit.org/show_bug.cgi?id=53289

revert mysterious build breakage

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/DOMAllInOne.cpp:
  • dom/Document.cpp: (WebCore::Document::DocumentOrderedMap::clear): (WebCore::Document::DocumentOrderedMap::add): (WebCore::Document::DocumentOrderedMap::remove): (WebCore::Document::DocumentOrderedMap::get): (WebCore::keyMatchesId): (WebCore::Document::getElementById): (WebCore::keyMatchesMapName): (WebCore::keyMatchesLowercasedMapName): (WebCore::Document::getImageMap):
  • dom/Document.h: (WebCore::Document::DocumentOrderedMap::contains): (WebCore::Document::DocumentOrderedMap::containsMultiple):
  • dom/DocumentOrderedMap.cpp: Removed.
  • dom/DocumentOrderedMap.h: Removed.
01:20 Changeset [77230] by mihaip@chromium.org

2011-02-01 Mihai Parparita <mihaip@chromium.org>

Reviewed by James Robinson.

Async event handlers should not fire within a modal dialog
https://bugs.webkit.org/show_bug.cgi?id=53202

Add tests for a scroll event triggered right before a modal dialog is
shown.

  • fast/events/scroll-event-during-modal-dialog-expected.txt: Added.
  • fast/events/scroll-event-during-modal-dialog.html: Added.

2011-02-01 Mihai Parparita <mihaip@chromium.org>

Reviewed by James Robinson.

Async event handlers should not fire within a modal dialog
https://bugs.webkit.org/show_bug.cgi?id=53202

Asychronous events that use EventQueue would currently fire while a
modal dialog (e.g. window.alert()) was up. Change EventQueue to use a
SuspendableTimer (which automatically gets suspended while dialogs are
up and in other cases where JS execution is not allowed).

Test: fast/events/scroll-event-during-modal-dialog.html

  • dom/Document.cpp: (WebCore::Document::Document):
  • dom/EventQueue.cpp: (WebCore::EventQueueTimer::EventQueueTimer): (WebCore::EventQueueTimer::fired): (WebCore::EventQueue::EventQueue): (WebCore::EventQueue::enqueueEvent): (WebCore::EventQueue::pendingEventTimerFired):
  • dom/EventQueue.h: (WebCore::EventQueue::create):
01:11 Changeset [77229] by rolandsteiner@chromium.org

2011-01-28 Roland Steiner <rolandsteiner@chromium.org>

Reviewed by NOBODY (OOPS!).

Bug 53289 - DOM: Move DocumentOrderedMap from Document into separate files
https://bugs.webkit.org/show_bug.cgi?id=53289

Moving the nested class DocumentOrderedMap from Document into separate files,
updating code where necessary.

No new tests. (refactoring)

  • Android.mk:
  • CMakeLists.txt:
  • GNUMakefile.am
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/Document.cpp: (WebCore::Document::getElementById): (WebCore::Document::getImageMap):
  • dom/Document.h:
  • dom/DocumentOrderedMap.cpp: Added. (WebCore::keyMatchesId): (WebCore::keyMatchesMapName): (WebCore::keyMatchesLowercasedMapName): (WebCore::DocumentOrderedMap::clear): (WebCore::DocumentOrderedMap::add): (WebCore::DocumentOrderedMap::remove): (WebCore::DocumentOrderedMap::get): (WebCore::DocumentOrderedMap::getElementById): (WebCore::DocumentOrderedMap::getElementByMapName): (WebCore::DocumentOrderedMap::getElementByLowercasedMapName):
  • dom/DocumentOrderedMap.h: Added. (WebCore::DocumentOrderedMap::contains): (WebCore::DocumentOrderedMap::containsMultiple):
  • dom/DOMAllInOne.cpp:
00:54 Changeset [77228] by commit-queue@webkit.org

2011-02-01 Naoki Takano <takano.naoki@gmail.com>

Reviewed by Darin Fisher.

[Chromium] Autofill should work with HTML5 form elements
https://bugs.webkit.org/show_bug.cgi?id=51809
http://crbug.com/65654

No new tests, because this fix is for Chromium project and hard to test only in WebKit project.

  • html/InputType.h: Insert comment for canSetSuggestedValue().
  • html/TextFieldInputType.cpp: (WebCore::TextFieldInputType::canSetSuggestedValue): Implemented to return always true for that all text filed inputs can be completed.
  • html/TextFieldInputType.h: Declare canSetSuggestedValue().
  • html/TextInputType.cpp: Delete canSetSuggestedValue() not to return true anymore.
  • html/TextInputType.h: Delete canSetSuggestedValue() not to return true anymore.

2011-02-01 Naoki Takano <takano.naoki@gmail.com>

Reviewed by Darin Fisher.

[Chromium] Autofill should work with HTML5 form elements
https://bugs.webkit.org/show_bug.cgi?id=51809
http://crbug.com/65654

No new tests, because this fix is for Chromium project and hard to test only in WebKit project.

  • public/WebInputElement.h: Added toWebInputElement() declarations and implemented const version of toWebInputElement().
  • src/WebInputElement.cpp: (WebKit::WebInputElement::toWebInputElement): Implemented a convert function to cast no-const WebElement* to no-const WebInputElement*. Because Chrome needs safe cast for autofill completion.
00:32 Changeset [77227] by mrowe@apple.com

Merge r74788.

00:32 Changeset [77226] by mrowe@apple.com

Merge r68307.

00:22 Changeset [77225] by mrowe@apple.com

Merge r72040 and r72135.

00:05 Changeset [77224] by tkent@chromium.org

REGRESSION (r65062): Safari loops forever under WebCore::plainTextToMallocAllocatedBuffer()
https://bugs.webkit.org/show_bug.cgi?id=53272

Reviewed by Dan Bernstein.

Source/WebCore:

  • editing/TextIterator.cpp:

(WebCore::TextIterator::handleTextBox): Pass the appropriate renderer to emitText().

LayoutTests:

  • fast/dom/inner-text-first-letter.html:
    • Add a new test case reproducing the bug.
    • Remove unnecessary text output.
  • fast/dom/inner-text-first-letter-expected.txt:

01/31/11:

23:54 Changeset [77223] by mrowe@apple.com

Merge r71724.

23:44 Changeset [77222] by mrowe@apple.com

Merge r71686.

23:41 Changeset [77221] by mrowe@apple.com

Merge r71641.

21:53 Changeset [77220] by ap@apple.com

Reviewed by Maciej Stachowiak.

https://bugs.webkit.org/show_bug.cgi?id=53466
Move WebKit2 to printing via API methods

Also fixes <rdar://problem/8933724> REGRESSION: Wrong pages are printed when not printing from page 1

Also fixes horizontal tiling (no bug filed).

The main idea here is that we don't force AppKit to use a different scaling factor when
a Web view can't be resized to exact page size, and scale when drawing instead.

  • UIProcess/API/mac/WKPrintingView.mm: (-[WKPrintingView _firstPrintedPageNumber]): Factored out into a separate method. (-[WKPrintingView _lastPrintedPageNumber]): Ditto. (pageDidDrawToPDF): Avoid crashing if data is null. (-[WKPrintingView _preparePDFDataForPrintingOnSecondaryThread]): Use -_firstPrintedPageNumber and -_lastPrintedPageNumber. (pageDidComputePageRects): Set frame size to what it would have been for a normal NSView that's been asked to resize. (-[WKPrintingView _pageForRect:]): Check x(), because several pages can be at the same y() when tiling horizontally. (-[WKPrintingView _drawPDFDocument:page:atPoint:]): Point to draw at and frame size are now using different units, translate as appropriate. (-[WKPrintingView _drawPreview:]): Scale the rect to WebCore units. (-[WKPrintingView drawRect:]): Correctly calculate page number when the first page to print isn't page 1. (-[WKPrintingView rectForPage:]): Scale the rect to AppKit units.
21:51 Changeset [77219] by rniwa@webkit.org

2011-01-31 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed Chromium test expectation updates.

Removed media/controls-strict.html and svg/custom/clip-path-referencing-use2.svg (Mac)
since it has been passing since r77171 and r77172-r77173 respectively.

Also removed http/tests/media/reload-after-dialog.html because it has been passing for a while.

  • platform/chromium/test_expectations.txt:
21:50 Changeset [77218] by mrowe@apple.com

Versioning.

21:50 Changeset [77217] by mrowe@apple.com

New tag.

21:40 Changeset [77216] by paroga@webkit.org

2011-01-31 Patrick Gansterer <paroga@webkit.org>

Reviewed by Adam Barth.

Remove obsolete comment after r41871
https://bugs.webkit.org/show_bug.cgi?id=53406

  • dom/Document.h:
21:33 Changeset [77215] by simon.fraser@apple.com

2011-01-31 Simon Fraser <simon.fraser@apple.com>

Fix according to reviewer comments: can just use Color::black now.

  • platform/graphics/ShadowBlur.cpp: (WebCore::ShadowBlur::drawInsetShadow): (WebCore::ShadowBlur::drawRectShadowWithoutTiling):
21:31 Changeset [77214] by mrowe@apple.com

Build fix.

21:19 Changeset [77213] by simon.fraser@apple.com

2011-01-31 Simon Fraser <simon.fraser@apple.com>

Reviewed by Sam Weinig.

Clean up ShadowBlur
https://bugs.webkit.org/show_bug.cgi?id=53472

Some minor ShadowBlur cleanup.

  • platform/graphics/ShadowBlur.h:
  • platform/graphics/ShadowBlur.cpp: (WebCore::ShadowBlur::ShadowBlur): Use m_blurRadius rather than the radius paramter. (WebCore::ShadowBlur::adjustBlurRadius): Renamed from adjustBlurDistance. (WebCore::ShadowBlur::calculateLayerBoundingRect): Rename layerFloatRect to layerRect. Make frameSize a float. (WebCore::ShadowBlur::beginShadowLayer): This now takes a precomputed layerRect rather than calling calculateLayerBoundingRect() to compute it itself, since we were calling calculateLayerBoundingRect() twice. (WebCore::ShadowBlur::drawRectShadow): Optimize to call calculateLayerBoundingRect() only once. The shadowRect variable was unused, so two return paths could be collapsed into one. (WebCore::ShadowBlur::drawInsetShadow): Call calculateLayerBoundingRect() before beginShadowLayer() now. (WebCore::ShadowBlur::drawRectShadowWithoutTiling): The layerRect gets passed in. We always used alpha=1, so no need to pass that in. (WebCore::ShadowBlur::drawRectShadowWithTiling): We always used alpha=1, so no need to pass that in. Move shadowRect down to first use. ShadowBlur::clipBounds() was unused.
20:34 Changeset [77212] by noam.rosenthal@nokia.com

2011-01-31 No'am Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] QWebElements example from QtWebKit Bridge documentation does not work at all
https://bugs.webkit.org/show_bug.cgi?id=46748

This problem disappears when we register QWebElement using qRegisterMetaType, which we now do in QtInstance.
Added a regression test to tst_QWebFrame.

  • bridge/qt/qt_instance.cpp: (JSC::Bindings::QtInstance::QtInstance):

2011-01-31 No'am Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] QWebElements example from QtWebKit Bridge documentation does not work at all
https://bugs.webkit.org/show_bug.cgi?id=46748

Problem was that we need to register QWebElement's variant-type to Qt's meta type system at some point.
This wasn't caught by previous tests inside tst_QWebFrame because it only appears when there's also a QWebElement property.
Added a regression test to tst_QWebFrame.

  • tests/qwebframe/tst_qwebframe.cpp: (MyWebElementSlotOnlyObject::doSomethingWithWebElement): (MyWebElementSlotOnlyObject::tagName):
20:05 Changeset [77211] by morrita@google.com

2011-01-27 MORITA Hajime <morrita@google.com>

Reviewed by Dimitri Glazkov.

Convert <progress> shadow DOM to a DOM-based shadow.
https://bugs.webkit.org/show_bug.cgi?id=50660

  • Removed RenderProgress::m_valuePart, moved the shadow node to the shadow root of HTMLProgressElement.
  • Removed hard-coded pseudo ID for -webkit-progress-bar-value. ProgressBarValueElement is defined only for overriding shadowPseudoId().

No new tests. No behavioral change.

  • css/CSSSelector.cpp: (WebCore::CSSSelector::pseudoId): (WebCore::nameToPseudoTypeMap): (WebCore::CSSSelector::extractPseudoType):
  • css/CSSSelector.h:
  • html/HTMLProgressElement.cpp: (WebCore::ProgressBarValueElement::ProgressBarValueElement): (WebCore::ProgressBarValueElement::shadowPseudoId): (WebCore::ProgressBarValueElement::create): (WebCore::ProgressBarValueElement::detach): (WebCore::HTMLProgressElement::parseMappedAttribute): (WebCore::HTMLProgressElement::attach): (WebCore::HTMLProgressElement::valuePart): (WebCore::HTMLProgressElement::didElementStateChange): (WebCore::HTMLProgressElement::createShadowSubtreeIfNeeded):
  • html/HTMLProgressElement.h:
  • rendering/RenderProgress.cpp: (WebCore::RenderProgress::~RenderProgress): (WebCore::RenderProgress::updateFromElement): (WebCore::RenderProgress::layoutParts): (WebCore::RenderProgress::shouldHaveParts): (WebCore::RenderProgress::valuePart):
  • rendering/RenderProgress.h:
  • rendering/style/RenderStyleConstants.h:
20:04 Changeset [77210] by commit-queue@webkit.org

2011-01-31 Charlie Reis <creis@chromium.org>

Reviewed by Mihai Parparita.

Add sanity check to help diagnose bug 52819
https://bugs.webkit.org/show_bug.cgi?id=53402

Crash early if the children of fromItem look invalid.

  • loader/HistoryController.cpp:
19:56 Changeset [77209] by rniwa@webkit.org

Fix the change log entry order.

19:54 Changeset [77208] by rniwa@webkit.org

2011-01-31 Emil A Eklund <eae@chromium.org>

Reviewed by Darin Adler.

Setting "selected" attribute to false should have no effect in single line <select>
https://bugs.webkit.org/show_bug.cgi?id=52436

Add test for changing the selection in a one-line select element using\
the option.selected property.

  • fast/dom/HTMLSelectElement/selected-false-expected.txt: Added.
  • fast/dom/HTMLSelectElement/selected-false.html: Added.
19:46 Changeset [77207] by commit-queue@webkit.org

2011-01-31 Kalle Vahlman <kalle.vahlman@movial.com>

Reviewed by Andreas Kling.

[Qt] canvas.drawImage(HTMLVideoElement) doesn't work with Qt Multimedia backend
https://bugs.webkit.org/show_bug.cgi?id=53325

Reimplement paintCurrentFrameInContext() rather than delegate the
rendering to paint() to make sure we really do get the video frame
content into the GraphicsContext, regardless of accelerated
compositing and the video scene state.

  • platform/graphics/qt/MediaPlayerPrivateQt.cpp: (WebCore::MediaPlayerPrivateQt::paintCurrentFrameInContext):
  • platform/graphics/qt/MediaPlayerPrivateQt.h:
19:45 Changeset [77206] by commit-queue@webkit.org

2011-01-31 Emil A Eklund <eae@chromium.org>

Reviewed by Darin Adler.

Setting "selected" attribute to false should have no effect in single line <select>
https://bugs.webkit.org/show_bug.cgi?id=52436

Add test for changing the selection in a one-line select element using\
the option.selected property.

  • fast/dom/HTMLSelectElement/selected-false-expected.txt: Added.
  • fast/dom/HTMLSelectElement/selected-false.html: Added.

2011-01-31 Emil A Eklund <eae@chromium.org>

Reviewed by Darin Adler.

Setting "selected" attribute to false should have no effect in single line <select>
https://bugs.webkit.org/show_bug.cgi?id=52436

Change SelectElement::setSelectedIndex to select the first selectable
option when the select state of all options is set to false as required
by the HTML5 specification.

Test: fast/dom/HTMLSelectElement/selected-false.html

  • dom/SelectElement.cpp: (WebCore::SelectElement::setSelectedIndex):
19:27 Changeset [77205] by apavlov@chromium.org

2011-01-31 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Console source references need a left-margin
https://bugs.webkit.org/show_bug.cgi?id=53308

  • inspector/front-end/inspector.css: (.console-message-url): Added a 4px margin on the left.
19:19 Changeset [77204] by mrowe@apple.com

Merge r73937.

19:19 Changeset [77203] by mrowe@apple.com

Merge r73927.

19:08 Changeset [77202] by mrowe@apple.com

Merge r59357.

18:54 Changeset [77201] by mrowe@apple.com

Merge r72833.

18:54 Changeset [77200] by mrowe@apple.com

Merge r72590.

18:54 Changeset [77199] by mrowe@apple.com

Merge r72353.

18:54 Changeset [77198] by mrowe@apple.com

Merge r72348.

18:54 Changeset [77197] by mrowe@apple.com

Merge r72344.

18:53 Changeset [77196] by mrowe@apple.com

Merge r72301.

18:53 Changeset [77195] by mrowe@apple.com

Merge r71947.

18:53 Changeset [77194] by mrowe@apple.com

Merge r71684.

18:53 Changeset [77193] by mrowe@apple.com

Merge r72924.

18:53 Changeset [77192] by mrowe@apple.com

Merge r72819.

18:36 Changeset [77191] by carol.szabo@nokia.com

2011-01-31 Carol Szabo <carol.szabo@nokia.com>

Reviewed by David Hyatt.

Code Changes only.

It is needlessly expensive to find the generating node from an anonymous renderer of a pseudoelement.
https://bugs.webkit.org/show_bug.cgi?id=53024

No new tests. No change in functionality

  • rendering/RenderObject.h: (WebCore::RenderObject::before): (WebCore::RenderObject::after): (WebCore::RenderObject::generatingNode): Added new accessors for the use of the CSS 2.1 counters code (mainlyly)
  • rendering/RenderObjectChildList.cpp: (WebCore::beforeAfterContainer): (WebCore::RenderObjectChildList::invalidateCounters): (WebCore::RenderObjectChildList::before): (WebCore::RenderObjectChildList::after): Refactored the code to take advantage of the new accessors. (WebCore::RenderObjectChildList::updateBeforeAfterContent): Changed to store the generating node in the :before and :after renderers.
  • rendering/RenderObjectChildList.h:
18:09 Changeset [77190] by rniwa@webkit.org

2011-01-31 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed Chromium rebaselines for r77173.

  • platform/chromium-mac/fast/text/justify-ideograph-complex-expected.checksum:
  • platform/chromium-mac/fast/text/justify-ideograph-complex-expected.png:
  • platform/chromium-mac/fast/text/justify-ideograph-simple-expected.checksum:
  • platform/chromium-mac/fast/text/justify-ideograph-simple-expected.png:
  • platform/chromium-mac/fast/text/justify-ideograph-vertical-expected.checksum:
  • platform/chromium-mac/fast/text/justify-ideograph-vertical-expected.png:
18:00 Changeset [77189] by mrowe@apple.com

Merge r75548.

17:49 Changeset [77188] by mrowe@apple.com

Merge r67634.

17:46 Changeset [77187] by mrowe@apple.com

Merge r70594.

17:45 Changeset [77186] by commit-queue@webkit.org

2011-01-31 Krithigassree Sambamurthy <krithigassree.sambamurthy@nokia.com>

Reviewed by David Hyatt.

Add background-clip to background shorthand
https://bugs.webkit.org/show_bug.cgi?id=52080

Added test cases to check whether webkitMaskClip is correctly set when
declared as a shorthand.

  • fast/backgrounds/multiple-backgrounds-computed-style-expected.txt:
  • fast/backgrounds/script-tests/multiple-backgrounds-computed-style.js:

Added test cases to check whether background-clip is set correctly when
declared as a shorthand.

  • fast/css/background-clip-text-expected.txt:
  • fast/css/script-tests/background-clip-text.js: (test):

2011-01-31 Krithigassree Sambamurthy <krithigassree.sambamurthy@nokia.com>

Reviewed by David Hyatt.

Add background-clip to background shorthand
https://bugs.webkit.org/show_bug.cgi?id=52080

Added background-clip to background-shorthand. Also made changes to
include webkitMaskClip to the mask shorthand to keep both in sync.

  • css/CSSParser.cpp: (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseFillShorthand):
17:43 Changeset [77185] by mrowe@apple.com

Merge r74045.

17:40 Changeset [77184] by mrowe@apple.com

Merge r67568.

17:27 Changeset [77183] by commit-queue@webkit.org

2011-01-31 Srikumar Bonda <srikumar.b@gmail.com>

Reviewed by Andreas Kling.

[Qt] ContextMenuClientQt.cpp has coding-style errors
"RefCounted.h" header inclusion style changed to <wtf/RefCounted.h>
https://bugs.webkit.org/show_bug.cgi?id=40243

  • WebCoreSupport/ContextMenuClientQt.cpp:
17:20 Changeset [77182] by darin@apple.com

2011-01-31 Darin Adler <darin@apple.com>

Reviewed by Adele Peterson.

WKView should support scrollPageDown:, scrollPageUp:, scrollToBeg and other similar selectors
https://bugs.webkit.org/show_bug.cgi?id=53460

  • editing/EditorCommand.cpp: (WebCore::executeScrollPageBackward): Added. (WebCore::executeScrollPageForward): Added. (WebCore::executeScrollToBeginningOfDocument): Added. (WebCore::executeScrollToEndOfDocument): Added. (WebCore::createCommandMap): Added the four commands above to the map.

2011-01-31 Darin Adler <darin@apple.com>

Reviewed by Adele Peterson.

WKView should support scrollPageDown:, scrollPageUp:, scrollToBeg and other similar selectors
https://bugs.webkit.org/show_bug.cgi?id=53460

  • UIProcess/API/mac/WKView.mm: Added WEBCORE_COMMAND macro for lots of editor commands that are implemented in WebCore so they will get forwarded. Many of these will probably work without any further changes required. Added comments about the methods that we do not yet forward. (createSelectorExceptionMap): Map scrollPageDown: to ScrollPageForward and scrollPageUp: to ScrollPageBackward because we want the page up and page down keys to follow the document logical order, not physical order. This is equivalent to what we do in WebPage::performDefaultBehaviorForKeyEvent.
17:19 Changeset [77181] by mrowe@apple.com

Merge r59477.

17:14 Changeset [77180] by mrowe@apple.com

Merge r72639.

17:10 Changeset [77179] by mrowe@apple.com

Merge r72685.

17:02 Changeset [77178] by mrowe@apple.com

Merge r69051.

17:00 Changeset [77177] by mrowe@apple.com

Merge r74155.

16:57 Changeset [77176] by commit-queue@webkit.org

2010-01-28 Commit Queue <commit-queue@webkit.org>

Unreviewed. Test commit for commit-queue@webkit.org.

16:50 Changeset [77175] by mrowe@apple.com

Merge r72166.

16:50 Changeset [77174] by mrowe@apple.com

Merge r72163.

16:44 BuildingQtOnOSX edited by andreas.kling@nokia.com
(diff)
16:30 Changeset [77173] by mitz@apple.com

Inter-ideograph justification should apply to hiragana and katakana as well
https://bugs.webkit.org/show_bug.cgi?id=53464

Reviewed by Adele Peterson.

Source/WebCore:

Changed the test for expansion opportunities from isCJKIdeograph() to isCJKIdeographOrSymbol().

  • platform/graphics/Font.cpp:

(WebCore::Font::expansionOpportunityCount):

  • platform/graphics/WidthIterator.cpp:

(WebCore::WidthIterator::advance):

  • platform/graphics/mac/ComplexTextController.cpp:

(WebCore::ComplexTextController::adjustGlyphsAndAdvances):

LayoutTests:

  • platform/mac/fast/text/justify-ideograph-complex-expected.checksum:
  • platform/mac/fast/text/justify-ideograph-complex-expected.png:
  • platform/mac/fast/text/justify-ideograph-simple-expected.checksum:
  • platform/mac/fast/text/justify-ideograph-simple-expected.png:
  • platform/mac/fast/text/justify-ideograph-vertical-expected.checksum:
  • platform/mac/fast/text/justify-ideograph-vertical-expected.png:
16:20 Changeset [77172] by mihaip@chromium.org

2011-01-31 Mihai Parparita <mihaip@chromium.org>

Reviewed by Tony Chang.

[Chromium] Switch chromium-mac to use ChromiumDriver
https://bugs.webkit.org/show_bug.cgi?id=53461

For the sake of consistency with the other Chromium platforms (and so
that chromium-mac picks up special flags like --enable-hardware-gpu),
switch chromium-mac from the WebKitDriver to ChromiumDriver.

  • Scripts/webkitpy/layout_tests/port/chromium.py:
15:54 Changeset [77171] by dglazkov@chromium.org

2011-01-31 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by James Robinson.

REGRESSION(r76951): Appearance of media controls changed slightly on Qt/Chromium ports
https://bugs.webkit.org/show_bug.cgi?id=53314

Fixes media/controls-strict.html on Chromium.

  • css/mediaControlsChromium.css: (audio::-webkit-media-controls-timeline, video::-webkit-media-controls-timeline):

Added proper box-sizing to avoid differences between strict/quirks mode.

15:50 Changeset [77170] by tkent@chromium.org

2011-01-31 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

Validation message bubble shouldn't inherit text-security style
https://bugs.webkit.org/show_bug.cgi?id=53457

No new tests because the validation message feature depends on timers
and is enabled only in Chromium port.

  • css/html.css: (::-webkit-validation-bubble): Reset -webkit-text-security.
15:44 Changeset [77169] by mrowe@apple.com

Merge r74759.

15:44 Changeset [77168] by mrowe@apple.com

Merge r74716.

15:44 Changeset [77167] by mrowe@apple.com

Merge r62016.

15:42 Changeset [77166] by rniwa@webkit.org

2011-01-31 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed Chromium test expectation update.

  • platform/chromium/test_expectations.txt:
15:11 Changeset [77165] by oliver@apple.com

2011-01-31 Oliver Hunt <oliver@apple.com>

Reviewed by Sam Weinig.

Bogus callframe during stack unwinding
https://bugs.webkit.org/show_bug.cgi?id=53454

Add test

  • fast/js/invalid-callframe-during-unwind-expected.txt: Added.
  • fast/js/invalid-callframe-during-unwind.html: Added.
  • fast/js/script-tests/invalid-callframe-during-unwind.js: Added. (testUnwind):

2011-01-31 Oliver Hunt <oliver@apple.com>

Reviewed by Sam Weinig.

Bogus callframe during stack unwinding
https://bugs.webkit.org/show_bug.cgi?id=53454

Trying to access a callframe's globalData after destroying its
ScopeChain is not a good thing. While we could access the
globalData directly through the (known valid) scopechain we're
holding on to, it feels fragile. Instead we push the valid
ScopeChain onto the callframe again to ensure that the callframe
itself remains valid.

  • interpreter/Interpreter.cpp: (JSC::Interpreter::unwindCallFrame):
14:59 BuildingQtOnOSX edited by dglazkov@chromium.org
(diff)
14:59 Changeset [77164] by beidson@apple.com

Fix the clean Windows build.

Reviewed by Adam Roben.

  • WebKitGraphics.cpp:

(WebDrawText):

14:59 Changeset [77163] by dpranke@chromium.org

2011-01-31 Dirk Pranke <dpranke@chromium.org>

Reviewed by Mihai Parparita.

The current modifier parsing code in test_expectations is
fragile and hard-coded, so it's not easy to understand the logic
or easily add new types of modifiers (like GPU vs. CPU testing
for graphics tests, or 32-bit vs. 64-bit differences).

This is the first of two patches that will add in more generic
support and then eliminate the GPU-specific test expectations
files for Chromium.

This patch adds two standalone objects for handling modifiers. The
rules for interpreting modifiers, precedence, and conflicts are
given in the docstring to the ModifierMatcher class, which
returns ModifierMatchResult objects.

This patch also adds routines to the Port interface and a
default set of values in the base object, in order to obtain the
values needed on a given test run. These values are then passed
to the expectation parser. This also allows us to clean up the
logic used to lint all of the different configurations in a
single test_expectations.txt file.

The next patch will merge in the separate GPU expectations file.

https://bugs.webkit.org/show_bug.cgi?id=51222

  • Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/base_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/port_testcase.py:
  • Scripts/webkitpy/layout_tests/port/test.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Tools/Scripts/webkitpy/style/checkers/test_expectations.py:
  • Tools/Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
14:56 Changeset [77162] by crogers@google.com

2011-01-31 Chris Rogers <crogers@google.com>

Reviewed by Jeremy Orlow.

Improve audio latency on Mac OS X for chromium port
https://bugs.webkit.org/show_bug.cgi?id=53452

  • src/AudioDestinationChromium.cpp:
14:32 Changeset [77161] by dbates@webkit.org

2011-01-31 Scott Cameron <sccameron@rim.com>

Reviewed by Daniel Bates.

update run-webkit-httpd to be able to launch Apache2.2 in a MSYS environment
https://bugs.webkit.org/show_bug.cgi?id=50036

This will add an Apache2.2 configuration file and modifies scripts to allow
running an httpd server in an MSYS environment.

The default Apache2.2 installation path has been preserved and PHP5 modules disabled
in order to allow for simple installation/execution. Simply install the latest
Apache2.2 version with OpenSSL from http://httpd.apache.org/download.cgi#apache22 to
be able to execute run-webkit-httpd.


  • http/conf/apache2-msys-httpd.conf: Added.

2011-01-31 Scott Cameron <sccameron@rim.com>

Reviewed by Daniel Bates.

update run-webkit-httpd to be able to launch Apache2.2 in a MSYS environment
https://bugs.webkit.org/show_bug.cgi?id=50036

This will add an Apache2.2 configuration file and modifies scripts to allow
running an httpd server in an MSYS environment.

The default Apache2.2 installation path has been preserved and PHP5 modules disabled
in order to allow for simple installation/execution. Simply install the latest
Apache2.2 version with OpenSSL from http://httpd.apache.org/download.cgi#apache22 to
be able to execute run-webkit-httpd.


  • Scripts/run-webkit-httpd:
  • Scripts/webkitperl/httpd.pm:
14:27 Changeset [77160] by rniwa@webkit.org

2011-01-31 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed Chromium Mac rebaselines for r77153; also rebaseline Kusa-Makura-background-canvas.html

  • platform/chromium-mac/fast/blockflow/Kusa-Makura-background-canvas-expected.checksum: Added.
  • platform/chromium-mac/fast/blockflow/Kusa-Makura-background-canvas-expected.png: Added.
  • platform/chromium-mac/fast/text/international/text-combine-image-test-expected.checksum: Added.
  • platform/chromium-mac/fast/text/international/text-combine-image-test-expected.png: Added.
  • platform/chromium/test_expectations.txt:
14:24 Changeset [77159] by msaboff@apple.com

Rolling back in the changes for https://bugs.webkit.org/show_bug.cgi?id=53271.

13:39 Changeset [77158] by hyatt@apple.com

Fix 32-bit build bustage.

13:29 Changeset [77157] by rniwa@webkit.org

2011-01-31 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed Chromium test expectation update.

  • platform/chromium/test_expectations.txt:
13:05 Changeset [77156] by andreas.kling@nokia.com

2011-01-31 Andreas Kling <kling@webkit.org>

Unbreak Qt build after r77151.

  • bridge/qt/qt_instance.cpp: (JSC::Bindings::QtInstance::removeCachedMethod): (JSC::Bindings::QtInstance::markAggregate):
12:51 Changeset [77155] by alex@webkit.org

2011-01-31 Alejandro G. Castro <alex@igalia.com>

Unreviewed added new expected results for GTK+.

  • platform/gtk/fast/box-shadow/box-shadow-radius-expected.txt: Added.
  • platform/gtk/fast/box-shadow/box-shadow-transformed-expected.txt: Added.
  • platform/gtk/fast/box-shadow/inset-box-shadow-radius-expected.txt: Added.
  • platform/gtk/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.txt: Added.
  • platform/gtk/fast/repaint/gradients-em-stops-repaint-expected.txt: Added.
  • platform/gtk/fast/repaint/select-option-background-color-expected.txt: Added.
12:48 Changeset [77154] by chang.shu@nokia.com

2011-01-31 Chang Shu <chang.shu@nokia.com>

Reviewed by Ryosuke Niwa.

Convert the test case to dumpAsText test so the expected result is cross-platform.
https://bugs.webkit.org/show_bug.cgi?id=53437

  • editing/deleting/5168598-expected.txt: Added.
  • editing/deleting/5168598.html:
  • platform/chromium-linux/editing/deleting/5168598-expected.checksum: Removed.
  • platform/chromium-linux/editing/deleting/5168598-expected.png: Removed.
  • platform/chromium-win/editing/deleting/5168598-expected.checksum: Removed.
  • platform/chromium-win/editing/deleting/5168598-expected.png: Removed.
  • platform/chromium-win/editing/deleting/5168598-expected.txt: Removed.
  • platform/mac-leopard/editing/deleting/5168598-expected.checksum: Removed.
  • platform/mac-leopard/editing/deleting/5168598-expected.png: Removed.
  • platform/mac/editing/deleting/5168598-expected.checksum: Removed.
  • platform/mac/editing/deleting/5168598-expected.png: Removed.
  • platform/mac/editing/deleting/5168598-expected.txt: Removed.
  • platform/qt/editing/deleting/5168598-expected.checksum: Removed.
  • platform/qt/editing/deleting/5168598-expected.png: Removed.
  • platform/qt/editing/deleting/5168598-expected.txt: Removed.
12:39 Changeset [77153] by hyatt@apple.com

Implement text-combine rendering code
https://bugs.webkit.org/show_bug.cgi?id=50621

Patch by takano takumi <takano@apple.com> on 2011-01-31
Reviewed by Dave Hyatt.

Source/WebCore:

Test: fast/text/international/text-combine-image-test.html

  • Android.mk: Added RenderCombineText.cpp/h
  • CMakeLists.txt: Added RenderCombineText.cpp/h
  • GNUmakefile.am: Added RenderCombineText.cpp/h
  • WebCore.exp.in:
  • WebCore.gypi: Added RenderCombineText.cpp/h
  • WebCore.pro: Added RenderCombineText.cpp/h
  • WebCore.vcproj/WebCore.vcproj: Added RenderCombineText.cpp/h
  • WebCore.xcodeproj/project.pbxproj: Added RenderCombineText.cpp/h
  • css/CSSFontFaceSource.cpp:

(WebCore::CSSFontFaceSource::getFontData):

  • Added fontDescription.widthVariant to SimpleFontData creation.
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

  • Changed to set "Unique" flag to RenderStyle in case of TextCombine.
  • dom/Text.cpp:

(WebCore::Text::createRenderer):

  • Changed to create RenderCombineText in case of TextCombine.
  • loader/cache/CachedFont.cpp:

(WebCore::CachedFont::platformDataFromCustomData):

  • Added FontWidthVariant as an argument for FontPlatformData creation.
  • loader/cache/CachedFont.h:
  • Ditto.
  • platform/graphics/Font.h:

(WebCore::Font::widthVariant):

  • The accessor to FontWidthVariant member variable.
  • platform/graphics/FontCache.cpp:
  • Made cache to incorporate FontWidthVariant value.

(WebCore::FontPlatformDataCacheKey::FontPlatformDataCacheKey):
(WebCore::FontPlatformDataCacheKey::operator==):
(WebCore::computeHash):
(WebCore::FontCache::getCachedFontPlatformData):

  • platform/graphics/FontDescription.h:
  • Add a member variable that holds a width variant - none, half-width, third-width, and quarter-width.

(WebCore::FontDescription::FontDescription):
(WebCore::FontDescription::widthVariant):
(WebCore::FontDescription::setWidthVariant):
(WebCore::FontDescription::operator==):

  • platform/graphics/FontWidthVariant.h: Added.
  • platform/graphics/cairo/FontCustomPlatformData.h:
  • Changed to carry FontWidthVariant value.
  • platform/graphics/cocoa/FontPlatformData.h:
  • Changed to carry FontWidthVariant value.

(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::widthVariant):
(WebCore::FontPlatformData::hash):
(WebCore::FontPlatformData::operator==):

  • platform/graphics/cocoa/FontPlatformDataCocoa.mm:

(WebCore::FontPlatformData::FontPlatformData):

  • Changed to carry FontWidthVariant value.

(WebCore::FontPlatformData::operator=):

  • Ditto.

(WebCore::mapFontWidthVariantToCTFeatureSelector):

  • A function to map a FontWidthVariant value to a CoreText's text spacing feature selector.

(WebCore::FontPlatformData::ctFont):

  • Changed to create CTFont with text spacing variant based on FontWidthVariant.
  • platform/graphics/freetype/FontCustomPlatformDataFreeType.cpp:

(WebCore::FontCustomPlatformData::fontPlatformData):

  • Changed to carry FontWidthVariant value.
  • platform/graphics/haiku/FontCustomPlatformData.cpp:

(WebCore::FontCustomPlatformData::fontPlatformData):

  • Changed to carry FontWidthVariant value.
  • platform/graphics/haiku/FontCustomPlatformData.h:
  • platform/graphics/mac/FontCacheMac.mm:

(WebCore::FontCache::createFontPlatformData):

  • Changed to carry FontWidthVariant value.
  • platform/graphics/mac/FontCustomPlatformData.cpp:

(WebCore::FontCustomPlatformData::fontPlatformData):

  • Changed to carry FontWidthVariant value.
  • platform/graphics/mac/FontCustomPlatformData.h:
  • Ditto.
  • platform/graphics/mac/GlyphPageTreeNodeMac.cpp:

(WebCore::shouldUseCoreText):

  • Changed to skip CT path when width variant is specified.
  • platform/graphics/pango/FontCustomPlatformDataPango.cpp:

(WebCore::FontCustomPlatformData::fontPlatformData):

  • Ditto.
  • platform/graphics/qt/FontCustomPlatformData.h:
  • Ditto.
  • platform/graphics/qt/FontCustomPlatformDataQt.cpp:

(WebCore::FontCustomPlatformData::fontPlatformData):

  • Ditto.
  • platform/graphics/skia/FontCustomPlatformData.cpp:

(WebCore::FontCustomPlatformData::fontPlatformData):

  • Ditto.
  • platform/graphics/skia/FontCustomPlatformData.h:
  • Ditto.
  • platform/graphics/win/FontCustomPlatformData.cpp:

(WebCore::FontCustomPlatformData::fontPlatformData):

  • Ditto.
  • platform/graphics/win/FontCustomPlatformData.h:
  • Ditto.
  • platform/graphics/win/FontCustomPlatformDataCairo.cpp:
  • Ditto.

(WebCore::FontCustomPlatformData::fontPlatformData):

  • Ditto.
  • platform/graphics/win/FontCustomPlatformDataCairo.h:
  • Ditto.
  • platform/graphics/wince/FontCustomPlatformData.cpp:

(WebCore::FontCustomPlatformData::fontPlatformData):

  • Ditto.
  • platform/graphics/wince/FontCustomPlatformData.h:
  • Ditto.
  • platform/graphics/wx/FontCustomPlatformData.cpp:

(WebCore::FontCustomPlatformData::fontPlatformData):

  • Ditto.
  • platform/graphics/wx/FontCustomPlatformData.h:
  • Ditto.
  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paint):

  • In case of RenderCombineText, we don't rotate text even in vertical writing. Also, we render original text

instead of text returned from text().

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::computeInlinePreferredLogicalWidths):

  • Made to call RenderCombinedText's prepareTextCombine() here.
  • rendering/RenderBlockLineLayout.cpp:

(WebCore::textWidth):

  • Made to always use the render object's width() in case of TextCombine.

(WebCore::RenderBlock::findNextLineBreak):

  • Made to call RenderCombinedText's prepareTextCombine() here.
  • rendering/RenderCombineText.cpp: Added. A subclass of RenderText.

(WebCore::RenderCombineText::RenderCombineText):
(WebCore::RenderCombineText::styleDidChange):

  • Clear the flag that indicated the font has been prepared for combining. The font will be reinitialized in

the next call of RenderBlock::findNextLineBreak().
(WebCore::RenderCombineText::setTextInternal):

  • Ditto.

(WebCore::RenderCombineText::width):

  • Returns 1-em width in case of font combine.

(WebCore::RenderCombineText::adjustTextOrigin):

  • Adjust drawing origin point in case of font combine.

(WebCore::RenderCombineText::charactersToRender):

  • Return original text instead of current text in case of font combine.

(WebCore::RenderCombineText::combineText):

  • This function tries to pack passed text with; 1) the current font as is, 2) the font created

from the descriptor with half-width variant specified, 3) the font with third-width variant, 4) the font
with quarter-width variant.

  • If a suitable font successfully found, replace the current font with the new font. If no appropriate font found,

we give up text-combine as the CSS spec describes.

  • If a new font found, we replace the text with 0xFFFC. This is needed for a combined text block to be able to

behave like a single character against text decorations.

  • rendering/RenderCombineText.h: Added.

(WebCore::RenderCombineText::isCombined):
(WebCore::RenderCombineText::combinedTextWidth):

  • Returns 1-em width in case of font combine.

(WebCore::RenderCombineText::renderName):
(WebCore::toRenderCombineText):

  • rendering/RenderText.cpp:

(WebCore::RenderText::widthFromCache):

  • Made to call RenderCombineText's combinedTextWidth when the text is combined.
  • rendering/RenderingAllInOne.cpp: Added RenderCombineText.cpp
  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::hasTextCombine):

  • Added for a quick test of TextCombine.

LayoutTests:

  • fast/text/international/text-combine-image-test.html: Added.
  • platform/mac/fast/text/international/text-combine-image-test-expected.checksum: Added.
  • platform/mac/fast/text/international/text-combine-image-test-expected.png: Added.
  • platform/mac/fast/text/international/text-combine-image-test-expected.txt: Added.
12:15 Changeset [77152] by jberlin@webkit.org

[Windows 7 Release Tests] fast/forms/select-writing-direction-natural.html failing since r77046
https://bugs.webkit.org/show_bug.cgi?id=53443

Checking in failing expected results for Windows to get the bots green. Ureviewed.

  • platform/win/fast/forms/select-writing-direction-natural-expected.txt: Added.
12:07 Changeset [77151] by oliver@apple.com

2011-01-31 Oliver Hunt <oliver@apple.com>

Convert markstack to a slot visitor API
https://bugs.webkit.org/show_bug.cgi?id=53219

rolling r77098, r77099, r77100, r77109, and
r77111 back in, along with a few more Qt fix attempts.

12:04 Changeset [77150] by rniwa@webkit.org

2011-01-31 Ryosuke Niwa <rniwa@webkit.org>

Another unreviewed Chromium test expectation update.

  • platform/chromium/test_expectations.txt:
11:57 Changeset [77149] by rniwa@webkit.org

2011-01-31 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed Chromium test expectation update.

  • platform/chromium/test_expectations.txt:
11:37 Changeset [77148] by kov@webkit.org

2011-01-31 Dan Winship <danw@gnome.org>

Reviewed by Gustavo Noronha Silva.

wss (websockets ssl) support for gtk via new gio TLS support
https://bugs.webkit.org/show_bug.cgi?id=50344

Add a GPollableOutputStream typedef for TLS WebSockets support

  • wtf/gobject/GTypedefs.h:

2011-01-31 Dan Winship <danw@gnome.org>

Reviewed by Gustavo Noronha Silva.

wss (websockets ssl) support for gtk via new gio TLS support
https://bugs.webkit.org/show_bug.cgi?id=50344

Update to use GPollableOutputStream and GTlsConnection to
implement wss URLs

  • platform/network/soup/SocketStreamHandle.h:
  • platform/network/soup/SocketStreamHandleSoup.cpp: (WebCore::SocketStreamHandle::SocketStreamHandle): (WebCore::SocketStreamHandle::connected): (WebCore::SocketStreamHandle::platformSend): (WebCore::SocketStreamHandle::beginWaitingForSocketWritability): (WebCore::writeReadyCallback):
11:25 Changeset [77147] by jberlin@webkit.org

WebKit2: the cookies used by the WebKit2 Web Process should not go in a top-level
directory.
https://bugs.webkit.org/show_bug.cgi?id=53278

Reviewed by Steve Falkenburg.

Use the name WebKit2WebProcess since the default location for the cookies is determined
based on the process name (which is WebKit2WebProcess.exe on Windows).

  • win/WebKit2.make:

Copy the WebKit2WebProcess.resources directory into the AppleInternal bin.

  • win/WebKit2WebProcess.resources: Added.
  • win/WebKit2WebProcess.resources/Info.plist: Added.

Copied from the WebKit version of Info.plist.

  • win/WebKit2WebProcessPostBuild.cmd:

Copy the WebKit2WebProcess.resources directory into the WebKitOutPutDir's bin.

11:08 Changeset [77146] by tony@chromium.org

2011-01-31 Tony Chang <tony@chromium.org>

Unreviewed, update chromium mac layout test results after r77138.
fast/blockflow/Kusa-Makura-background-canvas.html and fast/multicol/vertical-rl/float-paginate-complex.html
match upstream text results now.

  • platform/chromium/test_expectations.txt:
11:02 Changeset [77145] by barraclough@apple.com

https://bugs.webkit.org/show_bug.cgi?id=53352
Heavy external fragmentation in FixedVMPoolAllocator can lead to a CRASH().

Reviewed by Geoff Garen.

The FixedVMPoolAllocator currently uses a best fix policy -
switch to first fit, this is less prone to external fragmentation.

  • jit/ExecutableAllocatorFixedVMPool.cpp:

(JSC::AllocationTableSizeClass::AllocationTableSizeClass):
(JSC::AllocationTableSizeClass::blockSize):
(JSC::AllocationTableSizeClass::blockCount):
(JSC::AllocationTableSizeClass::blockAlignment):
(JSC::AllocationTableSizeClass::size):
(JSC::AllocationTableLeaf::AllocationTableLeaf):
(JSC::AllocationTableLeaf::~AllocationTableLeaf):
(JSC::AllocationTableLeaf::allocate):
(JSC::AllocationTableLeaf::free):
(JSC::AllocationTableLeaf::isEmpty):
(JSC::AllocationTableLeaf::isFull):
(JSC::AllocationTableLeaf::size):
(JSC::AllocationTableLeaf::classForSize):
(JSC::AllocationTableLeaf::dump):
(JSC::LazyAllocationTable::LazyAllocationTable):
(JSC::LazyAllocationTable::~LazyAllocationTable):
(JSC::LazyAllocationTable::allocate):
(JSC::LazyAllocationTable::free):
(JSC::LazyAllocationTable::isEmpty):
(JSC::LazyAllocationTable::isFull):
(JSC::LazyAllocationTable::size):
(JSC::LazyAllocationTable::dump):
(JSC::LazyAllocationTable::classForSize):
(JSC::AllocationTableDirectory::AllocationTableDirectory):
(JSC::AllocationTableDirectory::~AllocationTableDirectory):
(JSC::AllocationTableDirectory::allocate):
(JSC::AllocationTableDirectory::free):
(JSC::AllocationTableDirectory::isEmpty):
(JSC::AllocationTableDirectory::isFull):
(JSC::AllocationTableDirectory::size):
(JSC::AllocationTableDirectory::classForSize):
(JSC::AllocationTableDirectory::dump):
(JSC::FixedVMPoolAllocator::FixedVMPoolAllocator):
(JSC::FixedVMPoolAllocator::alloc):
(JSC::FixedVMPoolAllocator::free):
(JSC::FixedVMPoolAllocator::allocated):
(JSC::FixedVMPoolAllocator::isValid):
(JSC::FixedVMPoolAllocator::classForSize):
(JSC::FixedVMPoolAllocator::offsetToPointer):
(JSC::FixedVMPoolAllocator::pointerToOffset):
(JSC::ExecutableAllocator::committedByteCount):
(JSC::ExecutableAllocator::isValid):
(JSC::ExecutableAllocator::underMemoryPressure):
(JSC::ExecutablePool::systemAlloc):
(JSC::ExecutablePool::systemRelease):

  • wtf/PageReservation.h:

(WTF::PageReservation::PageReservation):
(WTF::PageReservation::commit):
(WTF::PageReservation::decommit):
(WTF::PageReservation::committed):

11:00 Changeset [77144] by inferno@chromium.org

2011-01-31 Abhishek Arya <inferno@chromium.org>

Reviewed by Dimitri Glazkov.

Check the textarea node still exists in document before casting
it to HTMLTextAreaElement.
https://bugs.webkit.org/show_bug.cgi?id=53429

Test: fast/forms/textarea-node-removed-from-document-crash.html

  • rendering/RenderTextControlMultiLine.cpp: (WebCore::RenderTextControlMultiLine::~RenderTextControlMultiLine):

2011-01-31 Abhishek Arya <inferno@chromium.org>

Reviewed by Dimitri Glazkov.

Tests that we do not crash when destructing textarea renderer when its
node is already removed from document.
https://bugs.webkit.org/show_bug.cgi?id=53429

  • fast/forms/textarea-node-removed-from-document-crash-expected.txt: Added.
  • fast/forms/textarea-node-removed-from-document-crash.html: Added.
10:56 Changeset [77143] by mitz@apple.com

Remove expected results in mac-wk2 and win that are equal to the mac results after r77138.

  • platform/mac-wk2/fast/blockflow/Kusa-Makura-background-canvas-expected.txt: Removed.
  • platform/mac-wk2/fast/multicol/vertical-rl/column-break-with-balancing-expected.txt: Removed.
  • platform/mac-wk2/fast/multicol/vertical-rl/float-paginate-complex-expected.txt: Removed.
  • platform/win/fast/block/basic/truncation-rtl-expected.txt: Removed.
  • platform/win/fast/multicol/vertical-rl/column-break-with-balancing-expected.txt: Removed.
  • platform/win/fast/multicol/vertical-rl/float-paginate-complex-expected.txt: Removed.
10:28 Changeset [77142] by inferno@chromium.org

2011-01-31 Cris Neckar <cdn@chromium.org>

Reviewed by Eric Seidel.

Tests for crash when cloning elements that reference counter nodes.
https://bugs.webkit.org/show_bug.cgi?id=53344

  • http/tests/css/counter-crash-expected.txt: Added.
  • http/tests/css/counter-crash.html: Added.
  • http/tests/css/resources/counter-crash-frame-src.html: Added.
10:23 Changeset [77141] by inferno@chromium.org

2011-01-27 Abhishek Arya <inferno@chromium.org>

Reviewed by Dave Hyatt.

Tests that we do not crash when adding a child in a table
where the before child is not a table section.
https://bugs.webkit.org/show_bug.cgi?id=53276

  • fast/table/before-child-non-table-section-add-table-crash-expected.txt: Added.
  • fast/table/before-child-non-table-section-add-table-crash.html: Added.

2011-01-27 Abhishek Arya <inferno@chromium.org>

Reviewed by Dave Hyatt.

If beforeChild is wrapped in an anonymous table section, we need to
go the parent to find it and use it before adding childs to table.
https://bugs.webkit.org/show_bug.cgi?id=53276

We need to make sure that beforeChild's parent is "this" before calling
RenderBox::addChild. The previous condition in while is too restrictive
and fails to calculate the right beforeChild value when its display
style is table caption.
Test: fast/table/before-child-non-table-section-add-table-crash.html

  • rendering/RenderTable.cpp: (WebCore::RenderTable::addChild):
10:11 Changeset [77140] by commit-queue@webkit.org

2011-01-31 Shane Stephens <shanestephens@google.com>

Reviewed by Simon Fraser.

AffineTransform::translateRight incorrectly computes a translateLeft.
https://bugs.webkit.org/show_bug.cgi?id=52551

Removed translateRight and converted all uses to perform standard
matrix multiplication.

No new tests because patch doesn't modify functionality.

  • platform/graphics/transforms/AffineTransform.cpp:
  • platform/graphics/transforms/AffineTransform.h: (WebCore::AffineTransform::translation):
  • rendering/svg/RenderSVGResourceMarker.cpp: (WebCore::RenderSVGResourceMarker::localToParentTransform):
  • rendering/svg/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::localToRepaintContainerTransform): (WebCore::RenderSVGRoot::localToParentTransform):
  • rendering/svg/RenderSVGViewportContainer.cpp: (WebCore::RenderSVGViewportContainer::localToParentTransform):
  • rendering/svg/SVGTextLayoutEngine.cpp: (WebCore::SVGTextLayoutEngine::finalizeTransformMatrices):
10:08 Changeset [77139] by andersca@apple.com

2011-01-31 Anders Carlsson <andersca@apple.com>

Reviewed by Adam Roben.

Make LayerTreeHost an abstract base class and make LayerTreeHostMac inherit from it
https://bugs.webkit.org/show_bug.cgi?id=53432

  • WebKit2.xcodeproj/project.pbxproj: Add LayerTreeHostMac.h.
  • WebProcess/WebPage/DrawingAreaImpl.cpp:
  • WebProcess/WebPage/DrawingAreaImpl.h: Make m_layerTreeHost an OwnPtr and initialize/destroy it appropriately.
  • WebProcess/WebPage/LayerTreeHost.cpp: (WebKit::LayerTreeHost::create): On Mac, create a LayerTreeHostMac instance.

(WebKit::LayerTreeHost::~LayerTreeHost):
No need to call platformInvalidate anymore.

  • WebProcess/WebPage/LayerTreeHost.h:
  • WebProcess/WebPage/mac/LayerTreeHostMac.h: Added.
  • WebProcess/WebPage/mac/LayerTreeHostMac.mm: (WebKit::LayerTreeHostMac::~LayerTreeHostMac): Invalidate the run loop observer here instead of in platformInvalidate.

(WebKit::LayerTreeHostMac::scheduleLayerFlush):
(WebKit::LayerTreeHostMac::flushPendingLayerChangesRunLoopObserverCallback):
These are now members of LayerTreeHostMac.

10:06 Changeset [77138] by tony@chromium.org

2011-01-31 Tony Chang <tony@chromium.org>

Reviewed by Eric Seidel.

mac DRT should report RTL scroll offset relative to top right corner
https://bugs.webkit.org/show_bug.cgi?id=53324

Remove scroll offsets since these are at the origin.

  • platform/mac/fast/block/basic/truncation-rtl-expected.txt:
  • platform/mac/fast/blockflow/Kusa-Makura-background-canvas-expected.txt:
  • platform/mac/fast/multicol/vertical-rl/column-break-with-balancing-expected.txt:
  • platform/mac/fast/multicol/vertical-rl/float-paginate-complex-expected.txt:

2011-01-31 Tony Chang <tony@chromium.org>

Reviewed by Eric Seidel.

mac DRT should report RTL scroll offset relative to top right corner
https://bugs.webkit.org/show_bug.cgi?id=53324

  • DumpRenderTree/mac/DumpRenderTree.mm: (dumpFrameScrollPosition):
09:57 Changeset [77137] by mario@webkit.org

2011-01-31 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Martin Robinson.

[Gtk] atk_text_set_caret_offset returns True even when it is unsuccessful
https://bugs.webkit.org/show_bug.cgi?id=53389

Return FALSE when not able to set the caret at the specified offset.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_text_set_caret_offset): Return FALSE when the range created is NULL and adjust offset to account for list markers.

2011-01-31 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Martin Robinson.

[Gtk] atk_text_set_caret_offset returns True even when it is unsuccessful
https://bugs.webkit.org/show_bug.cgi?id=53389

New unit test to check the fix for this bug.

  • tests/testatk.c: (testWebkitAtkCaretOffsets): New. (main): Add new test.
09:37 Changeset [77136] by yurys@chromium.org

2011-01-31 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Mark some tests as having wrong image results on Mac.

  • platform/chromium/test_expectations.txt:
09:18 Changeset [77135] by ager@chromium.org

2011-01-31 Mads Ager <ager@chromium.org>

Reviewed by Pavel Feldman.

[V8] Update V8 specific layout test expectations
https://bugs.webkit.org/show_bug.cgi?id=53423

Error formatting has changed in V8. Updating chromium specific
layout test expectations accordingly.

  • platform/chromium-mac/fast/js/array-every-expected.txt:
  • platform/chromium-mac/fast/js/instance-of-immediates-expected.txt:
  • platform/chromium-mac/fast/js/property-getters-and-setters-expected.txt:
  • platform/chromium-mac/storage/transaction-error-callback-expected.txt:
  • platform/chromium-mac/svg/dom/svgpath-out-of-bounds-getPathSeg-expected.txt:
  • platform/chromium-win/fast/js/array-every-expected.txt:
  • platform/chromium-win/fast/js/instance-of-immediates-expected.txt:
  • platform/chromium-win/fast/js/property-getters-and-setters-expected.txt:
  • platform/chromium-win/storage/transaction-error-callback-expected.txt:
  • platform/chromium-win/svg/dom/svgpath-out-of-bounds-getPathSeg-expected.txt:
09:14 Changeset [77134] by alex@webkit.org

2011-01-31 Alejandro G. Castro <alex@igalia.com>

Unreviewed skipped favicon-as-image.html test, it is flaky and it
was unskipped after r76555.

  • platform/gtk/Skipped:
09:05 Changeset [77133] by mnaganov@chromium.org

Merge 77128 - 2011-01-28 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: copy HAR to clipboard instead of saving blob on export.
https://bugs.webkit.org/show_bug.cgi?id=53328

  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype._exportAll): (WebInspector.NetworkPanel.prototype._exportResource):

TBR=pfeldman@chromium.org
Review URL: http://codereview.chromium.org/6312032

08:35 Changeset [77132] by simon.fraser@apple.com

2011-01-31 Simon Fraser <simon.fraser@apple.com>

Update a pixel resuls after r77101.

  • platform/mac/fast/css/color-correction-on-box-shadow-expected.checksum:
  • platform/mac/fast/css/color-correction-on-box-shadow-expected.png:
08:03 Changeset [77131] by yurys@chromium.org

2011-01-31 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Update Chromium test expectations.

  • platform/chromium-mac/fast/css/color-correction-on-box-shadow-expected.checksum: Added.
  • platform/chromium-mac/fast/css/color-correction-on-box-shadow-expected.png: Added.
  • platform/chromium-mac/fast/transforms/shadows-expected.checksum:
  • platform/chromium-mac/fast/transforms/shadows-expected.png:
07:39 Changeset [77130] by zoltan@webkit.org

[Qt] Add Take Screen Shot action to MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=53422

Reviewed by Andreas Kling.

Add Take Screen Shot action to MiniBrowser's view menu.

  • MiniBrowser/qt/BrowserWindow.cpp:

(BrowserWindow::BrowserWindow):
(BrowserWindow::screenshot):

  • MiniBrowser/qt/BrowserWindow.h:
07:29 Changeset [77129] by kbr@google.com

2011-01-31 Kenneth Russell <kbr@google.com>

Unreviewed, test and expectations update. Stop reporting the precise
pixel value for tests that are supposed to be within a certain range.
Remove now-unneeded Chromium expectations.

  • fast/canvas/webgl/gl-teximage-expected.txt:
  • fast/canvas/webgl/gl-teximage.html:
  • platform/chromium-linux/fast/canvas/webgl/gl-teximage-expected.txt: Removed.
  • platform/chromium-mac/fast/canvas/webgl/gl-teximage-expected.txt: Removed.
  • platform/chromium-win/fast/canvas/webgl/gl-teximage-expected.txt: Removed.
07:18 Changeset [77128] by pfeldman@chromium.org

2011-01-28 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: copy HAR to clipboard instead of saving blob on export.
https://bugs.webkit.org/show_bug.cgi?id=53328

  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype._exportAll): (WebInspector.NetworkPanel.prototype._exportResource):
06:43 Changeset [77127] by pfeldman@chromium.org

2011-01-30 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: speed up network panel rendering.
https://bugs.webkit.org/show_bug.cgi?id=53397

  • inspector/front-end/DataGrid.js: (WebInspector.DataGrid.prototype.get scrollContainer):
  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype.elementsToRestoreScrollPositionsFor): (WebInspector.NetworkPanel.prototype._positionSummaryBar): (WebInspector.NetworkPanel.prototype._createTable): (WebInspector.NetworkPanel.prototype._exportResource): (WebInspector.NetworkPanel.prototype._onScroll):
  • inspector/front-end/networkPanel.css: (.network-sidebar .data-grid.small tr.offscreen): (.network-sidebar .data-grid tr.offscreen): (.network-sidebar .data-grid tr.offscreen td):
06:34 Changeset [77126] by pvarga@webkit.org

2011-01-31 Peter Varga <pvarga@webkit.org>

Reviewed by Andreas Kling.

Remove wrec from WebCore
https://bugs.webkit.org/show_bug.cgi?id=53298

No new tests needed.

  • Android.jscbindings.mk:
  • ForwardingHeaders/wrec/WREC.h: Removed.
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcproj/copyForwardingHeaders.cmd:
06:26 Changeset [77125] by commit-queue@webkit.org

2011-01-31 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r76969.
http://trac.webkit.org/changeset/76969
https://bugs.webkit.org/show_bug.cgi?id=53418

"It is causing crashes in GTK+ and Leopard bots" (Requested by
alexg on #webkit).

  • runtime/WeakGCMap.h:

2011-01-31 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r76969.
http://trac.webkit.org/changeset/76969
https://bugs.webkit.org/show_bug.cgi?id=53418

"It is causing crashes in GTK+ and Leopard bots" (Requested by
alexg on #webkit).

  • bridge/runtime_root.cpp: (JSC::Bindings::RootObject::invalidate): (JSC::Bindings::RootObject::addRuntimeObject): (JSC::Bindings::RootObject::removeRuntimeObject):
  • bridge/runtime_root.h:
06:23 Changeset [77124] by yurys@chromium.org

2011-01-31 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Update Chromium test expectations.

  • platform/chromium-mac/fast/blockflow/box-shadow-horizontal-bt-expected.checksum: Added.
  • platform/chromium-mac/fast/blockflow/box-shadow-horizontal-bt-expected.png: Added.
  • platform/chromium-mac/fast/blockflow/box-shadow-vertical-lr-expected.checksum: Added.
  • platform/chromium-mac/fast/blockflow/box-shadow-vertical-lr-expected.png: Added.
  • platform/chromium-mac/fast/blockflow/box-shadow-vertical-rl-expected.checksum: Added.
  • platform/chromium-mac/fast/blockflow/box-shadow-vertical-rl-expected.png: Added.
  • platform/chromium-mac/fast/borders/border-radius-split-inline-expected.checksum: Added.
  • platform/chromium-mac/fast/borders/border-radius-split-inline-expected.png: Added.
  • platform/chromium-mac/fast/box-shadow/box-shadow-transformed-expected.checksum: Added.
  • platform/chromium-mac/fast/box-shadow/box-shadow-transformed-expected.png: Added.
  • platform/chromium-mac/fast/repaint/box-shadow-h-expected.checksum:
  • platform/chromium-mac/fast/repaint/box-shadow-h-expected.png:
  • platform/chromium-mac/fast/repaint/box-shadow-v-expected.checksum: Added.
  • platform/chromium-mac/fast/repaint/box-shadow-v-expected.png: Added.
  • platform/chromium-mac/fast/repaint/gradients-em-stops-repaint-expected.checksum: Added.
  • platform/chromium-mac/fast/repaint/gradients-em-stops-repaint-expected.png: Added.
  • platform/chromium-mac/fast/repaint/shadow-multiple-strict-horizontal-expected.checksum: Removed.
  • platform/chromium-mac/fast/repaint/shadow-multiple-strict-horizontal-expected.png: Removed.
  • platform/chromium-mac/fast/repaint/shadow-multiple-strict-vertical-expected.checksum: Removed.
  • platform/chromium-mac/fast/repaint/shadow-multiple-strict-vertical-expected.png: Removed.
  • platform/chromium-mac/fast/transforms/shadows-expected.checksum: Added.
  • platform/chromium-mac/fast/transforms/shadows-expected.png: Added.
05:59 Changeset [77123] by kov@webkit.org

2011-01-31 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

[GTK] REGRESSION: http/tests/media/video-{cookie,referer}.html failing
https://bugs.webkit.org/show_bug.cgi?id=53379

Remove left over mentions of HAVE_SOUP_2_29_90, and apply the
dependency on newer soup to efl as well.

  • Source/cmake/OptionsEfl.cmake:

2011-01-31 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

[GTK] REGRESSION: http/tests/media/video-{cookie,referer}.html failing
https://bugs.webkit.org/show_bug.cgi?id=53379

Unskip tests that pass again.

  • platform/gtk/Skipped:

2011-01-31 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

[GTK] REGRESSION: http/tests/media/video-{cookie,referer}.html failing
https://bugs.webkit.org/show_bug.cgi?id=53379

Remove left over #ifdef's. I thought all of the conditional code
had been freed from the condition, but I forgot to check DRT.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setAlwaysAcceptCookies):
05:36 Changeset [77122] by mnaganov@chromium.org

Merge 76429 - 2011-01-21 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Adam Barth.

Regression: new window.onerror() implementation leaks cross-origin Javascript errors
https://bugs.webkit.org/show_bug.cgi?id=52903

In case of an exception in a script from different domain only generic message
will be passed to window.onerror hander.

Tests: http/tests/security/cross-origin-script-window-onerror-redirected.html

http/tests/security/cross-origin-script-window-onerror.html

  • bindings/js/CachedScriptSourceProvider.h: use URL from the resource response to make sure we do all cross origin checks agains real script URL, not the original URL which may have resulted in a sequence of redirects to different domains. (WebCore::CachedScriptSourceProvider::CachedScriptSourceProvider):
  • bindings/v8/ScriptSourceCode.h: same for v8. (WebCore::ScriptSourceCode::url):
  • dom/ScriptExecutionContext.cpp: (WebCore::ScriptExecutionContext::dispatchErrorEvent): in case the error occurred in a script we cannot access provide concise "Script error." message without any information about the error source. This is what Firefox does in this case.

2011-01-21 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Adam Barth.

Regression: new window.onerror() implementation leaks cross-origin Javascript errors
https://bugs.webkit.org/show_bug.cgi?id=52903

A couple of tests to check that window.onerror won't reveal any content of the resource
from a different domain if the latter is referenced via <script src=...>

  • http/tests/security/cross-origin-script-window-onerror-expected.txt: Added.
  • http/tests/security/cross-origin-script-window-onerror-redirected-expected.txt: Added.
  • http/tests/security/cross-origin-script-window-onerror-redirected.html: Added.
  • http/tests/security/cross-origin-script-window-onerror.html: Added.
  • http/tests/security/resources/cross-origin-script.txt: Added.

TBR=abarth@webkit.org
Review URL: http://codereview.chromium.org/6409009

03:56 Changeset [77121] by antti@apple.com

Not reviewed.

Spelling.

  • css/CSSSelectorList.h:

(WebCore::CSSSelectorList::next):

03:45 Changeset [77120] by yurys@chromium.org

2011-01-31 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Update Chromium test expectations after r77108

  • platform/chromium-linux/fast/canvas/webgl/gl-teximage-expected.txt: Added.
  • platform/chromium-mac/fast/canvas/webgl/gl-teximage-expected.txt: Added.
  • platform/chromium-win/fast/canvas/webgl/gl-teximage-expected.txt: Added.
03:10 Changeset [77119] by yurys@chromium.org

2011-01-31 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Fix Chromium compilation on Linux.

  • platform/graphics/ShadowBlur.cpp: added PLATFORM(CHROMIUM) guard
  • platform/graphics/ShadowBlur.h: added missing ColorSpace.h header include
02:55 Changeset [77118] by yurys@chromium.org

2011-01-31 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Fix Chromium compilation on Mac broken by r77101.

  • WebCore.gypi: add ShadowBlur.{h,cpp} to the gypi file.
02:51 Changeset [77117] by yurys@chromium.org

2011-01-31 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Update Chromium test expectations after r77101

  • platform/chromium-linux/fast/box-shadow/box-shadow-transformed-expected.checksum: Added.
  • platform/chromium-linux/fast/box-shadow/box-shadow-transformed-expected.png: Added.
  • platform/chromium-linux/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.checksum: Added.
  • platform/chromium-linux/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.png: Added.
  • platform/chromium-win/fast/box-shadow/box-shadow-radius-expected.checksum: Added.
  • platform/chromium-win/fast/box-shadow/box-shadow-radius-expected.png: Added.
  • platform/chromium-win/fast/box-shadow/box-shadow-radius-expected.txt: Added.
  • platform/chromium-win/fast/box-shadow/box-shadow-transformed-expected.checksum: Added.
  • platform/chromium-win/fast/box-shadow/box-shadow-transformed-expected.png: Added.
  • platform/chromium-win/fast/box-shadow/box-shadow-transformed-expected.txt: Added.
  • platform/chromium-win/fast/box-shadow/inset-box-shadow-radius-expected.checksum: Added.
  • platform/chromium-win/fast/box-shadow/inset-box-shadow-radius-expected.png: Added.
  • platform/chromium-win/fast/box-shadow/inset-box-shadow-radius-expected.txt: Added.
  • platform/chromium-win/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.checksum: Added.
  • platform/chromium-win/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.png: Added.
  • platform/chromium-win/fast/repaint/gradients-em-stops-repaint-expected.txt: Added.
02:44 Changeset [77116] by mnaganov@chromium.org

2011-01-31 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Yury Semikhatsky.

WebInspector: Change button title from "Clear CPU profiles" to "Clear all profiles".

https://bugs.webkit.org/show_bug.cgi?id=53309

  • English.lproj/localizedStrings.js:
  • inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel):
02:35 Changeset [77115] by carlosgc@webkit.org

2011-01-31 Carlos Garcia Campos <cgarcia@igalia.com>

Unreviewed, fix the build with current GTK+ 3.x.

  • plugins/gtk/gtk2xtbin.c:
  • plugins/gtk/gtk2xtbin.h:

01/30/11:

23:18 Changeset [77114] by tkent@chromium.org

2011-01-30 Kenichi Ishibashi <bashi@google.com>

Reviewed by Kent Tamura.

Dangling form associated elements should not be registered on the document
https://bugs.webkit.org/show_bug.cgi?id=53223

Adds insertedIntoDocument() and remvoedFromDocument() to
FormAssociatedElement class to register the element on the document
if and only if it actually inserted into (removed from) the document.

Test: fast/forms/dangling-form-element-crash.html

  • html/FormAssociatedElement.cpp: (WebCore::FormAssociatedElement::insertedIntoDocument): Added. (WebCore::FormAssociatedElement::removedFromDocument): Ditto. (WebCore::FormAssociatedElement::insertedIntoTree): Don't register the element to a document. (WebCore::FormAssociatedElement::removedFromTree): Don't unregister the element from a document.
  • html/FormAssociatedElement.h:
  • html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::insertedIntoDocument): Added. (WebCore::HTMLFormControlElement::removedFromDocument): Ditto.
  • html/HTMLFormControlElement.h:
  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::insertedIntoDocument): Calls FormAssociatedElement::insertedIntoDocument(). (WebCore::HTMLObjectElement::removedFromDocument): Calls FormAssociatedElement::removedFromDocument().

2011-01-30 Kenichi Ishibashi <bashi@google.com>

Reviewed by Kent Tamura.

Dangling form associated elements should not be registered on the document
https://bugs.webkit.org/show_bug.cgi?id=53223

Adds a test that ensures dangling form associated elements are not
registered on the document.

  • fast/forms/dangling-form-element-crash-expected.txt: Added.
  • fast/forms/dangling-form-element-crash.html: Added.
22:56 Changeset [77113] by ossy@webkit.org

2011-01-30 Csaba Osztrogonác <ossy@webkit.org>

Unreviewed, rolling out r77098, r77099, r77100, r77109, and
r77111.
http://trac.webkit.org/changeset/77098
http://trac.webkit.org/changeset/77099
http://trac.webkit.org/changeset/77100
http://trac.webkit.org/changeset/77109
http://trac.webkit.org/changeset/77111
https://bugs.webkit.org/show_bug.cgi?id=53219

Qt build is broken

  • API/JSCallbackObject.h: (JSC::JSCallbackObjectData::setPrivateProperty): (JSC::JSCallbackObjectData::JSPrivatePropertyMap::getPrivateProperty): (JSC::JSCallbackObjectData::JSPrivatePropertyMap::setPrivateProperty): (JSC::JSCallbackObjectData::JSPrivatePropertyMap::markChildren): (JSC::JSCallbackObject::setPrivateProperty):
  • API/JSCallbackObjectFunctions.h: (JSC::::put): (JSC::::staticFunctionGetter):
  • API/JSObjectRef.cpp: (JSObjectMakeConstructor): (JSObjectSetPrivateProperty):
  • API/JSWeakObjectMapRefInternal.h:
  • JavaScriptCore.exp:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::markAggregate):
  • bytecode/CodeBlock.h: (JSC::CodeBlock::globalObject):
  • bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::BytecodeGenerator): (JSC::BytecodeGenerator::emitJumpIfNotFunctionCall): (JSC::BytecodeGenerator::emitJumpIfNotFunctionApply): (JSC::BytecodeGenerator::findScopedProperty):
  • debugger/Debugger.cpp: (JSC::evaluateInGlobalCallFrame):
  • debugger/DebuggerActivation.cpp: (JSC::DebuggerActivation::DebuggerActivation): (JSC::DebuggerActivation::markChildren):
  • debugger/DebuggerActivation.h:
  • debugger/DebuggerCallFrame.cpp: (JSC::DebuggerCallFrame::evaluate):
  • interpreter/CallFrame.h: (JSC::ExecState::exception):
  • interpreter/Interpreter.cpp: (JSC::Interpreter::resolve): (JSC::Interpreter::resolveSkip): (JSC::Interpreter::resolveGlobal): (JSC::Interpreter::resolveGlobalDynamic): (JSC::Interpreter::resolveBaseAndProperty): (JSC::Interpreter::unwindCallFrame): (JSC::appendSourceToError): (JSC::Interpreter::execute): (JSC::Interpreter::tryCacheGetByID): (JSC::Interpreter::privateExecute):
  • jit/JITStubs.cpp: (JSC::JITThunks::tryCacheGetByID): (JSC::DEFINE_STUB_FUNCTION):
  • jsc.cpp: (GlobalObject::GlobalObject):
  • runtime/ArgList.cpp: (JSC::MarkedArgumentBuffer::markLists):
  • runtime/Arguments.cpp: (JSC::Arguments::markChildren): (JSC::Arguments::getOwnPropertySlot): (JSC::Arguments::getOwnPropertyDescriptor): (JSC::Arguments::put):
  • runtime/Arguments.h: (JSC::Arguments::setActivation): (JSC::Arguments::Arguments):
  • runtime/ArrayConstructor.cpp: (JSC::ArrayConstructor::ArrayConstructor): (JSC::constructArrayWithSizeQuirk):
  • runtime/ArrayPrototype.cpp: (JSC::arrayProtoFuncSplice):
  • runtime/BatchedTransitionOptimizer.h: (JSC::BatchedTransitionOptimizer::BatchedTransitionOptimizer): (JSC::BatchedTransitionOptimizer::~BatchedTransitionOptimizer):
  • runtime/BooleanConstructor.cpp: (JSC::BooleanConstructor::BooleanConstructor): (JSC::constructBoolean): (JSC::constructBooleanFromImmediateBoolean):
  • runtime/BooleanPrototype.cpp: (JSC::BooleanPrototype::BooleanPrototype):
  • runtime/ConservativeSet.cpp: (JSC::ConservativeSet::grow):
  • runtime/ConservativeSet.h: (JSC::ConservativeSet::~ConservativeSet): (JSC::ConservativeSet::mark):
  • runtime/DateConstructor.cpp: (JSC::DateConstructor::DateConstructor):
  • runtime/DateInstance.cpp: (JSC::DateInstance::DateInstance):
  • runtime/DatePrototype.cpp: (JSC::dateProtoFuncSetTime): (JSC::setNewValueFromTimeArgs): (JSC::setNewValueFromDateArgs): (JSC::dateProtoFuncSetYear):
  • runtime/ErrorConstructor.cpp: (JSC::ErrorConstructor::ErrorConstructor):
  • runtime/ErrorInstance.cpp: (JSC::ErrorInstance::ErrorInstance):
  • runtime/ErrorPrototype.cpp: (JSC::ErrorPrototype::ErrorPrototype):
  • runtime/FunctionConstructor.cpp: (JSC::FunctionConstructor::FunctionConstructor):
  • runtime/FunctionPrototype.cpp: (JSC::FunctionPrototype::FunctionPrototype):
  • runtime/GetterSetter.cpp: (JSC::GetterSetter::markChildren):
  • runtime/GetterSetter.h: (JSC::GetterSetter::GetterSetter): (JSC::GetterSetter::getter): (JSC::GetterSetter::setGetter): (JSC::GetterSetter::setter): (JSC::GetterSetter::setSetter):
  • runtime/GlobalEvalFunction.cpp: (JSC::GlobalEvalFunction::GlobalEvalFunction): (JSC::GlobalEvalFunction::markChildren):
  • runtime/GlobalEvalFunction.h: (JSC::GlobalEvalFunction::cachedGlobalObject):
  • runtime/Heap.cpp: (JSC::Heap::markProtectedObjects): (JSC::Heap::markTempSortVectors): (JSC::Heap::markRoots):
  • runtime/InternalFunction.cpp: (JSC::InternalFunction::InternalFunction):
  • runtime/JSAPIValueWrapper.h: (JSC::JSAPIValueWrapper::value): (JSC::JSAPIValueWrapper::JSAPIValueWrapper):
  • runtime/JSActivation.cpp: (JSC::JSActivation::markChildren): (JSC::JSActivation::put):
  • runtime/JSArray.cpp: (JSC::JSArray::JSArray): (JSC::JSArray::getOwnPropertySlot): (JSC::JSArray::getOwnPropertyDescriptor): (JSC::JSArray::put): (JSC::JSArray::putSlowCase): (JSC::JSArray::deleteProperty): (JSC::JSArray::increaseVectorLength): (JSC::JSArray::setLength): (JSC::JSArray::pop): (JSC::JSArray::push): (JSC::JSArray::unshiftCount): (JSC::JSArray::sort): (JSC::JSArray::fillArgList): (JSC::JSArray::copyToRegisters): (JSC::JSArray::compactForSorting):
  • runtime/JSArray.h: (JSC::JSArray::getIndex): (JSC::JSArray::setIndex): (JSC::JSArray::uncheckedSetIndex): (JSC::JSArray::markChildrenDirect):
  • runtime/JSByteArray.cpp: (JSC::JSByteArray::JSByteArray):
  • runtime/JSCell.h: (JSC::JSCell::JSValue::toThisObject): (JSC::JSCell::MarkStack::append):
  • runtime/JSFunction.cpp: (JSC::JSFunction::JSFunction): (JSC::JSFunction::getOwnPropertySlot):
  • runtime/JSGlobalData.h:
  • runtime/JSGlobalObject.cpp: (JSC::markIfNeeded): (JSC::JSGlobalObject::reset): (JSC::JSGlobalObject::resetPrototype): (JSC::JSGlobalObject::markChildren):
  • runtime/JSGlobalObject.h: (JSC::JSGlobalObject::JSGlobalObjectData::JSGlobalObjectData): (JSC::JSGlobalObject::regExpConstructor): (JSC::JSGlobalObject::errorConstructor): (JSC::JSGlobalObject::evalErrorConstructor): (JSC::JSGlobalObject::rangeErrorConstructor): (JSC::JSGlobalObject::referenceErrorConstructor): (JSC::JSGlobalObject::syntaxErrorConstructor): (JSC::JSGlobalObject::typeErrorConstructor): (JSC::JSGlobalObject::URIErrorConstructor): (JSC::JSGlobalObject::evalFunction): (JSC::JSGlobalObject::objectPrototype): (JSC::JSGlobalObject::functionPrototype): (JSC::JSGlobalObject::arrayPrototype): (JSC::JSGlobalObject::booleanPrototype): (JSC::JSGlobalObject::stringPrototype): (JSC::JSGlobalObject::numberPrototype): (JSC::JSGlobalObject::datePrototype): (JSC::JSGlobalObject::regExpPrototype): (JSC::JSGlobalObject::methodCallDummy): (JSC::Structure::prototypeForLookup): (JSC::constructArray):
  • runtime/JSONObject.cpp: (JSC::Stringifier::Holder::object): (JSC::Stringifier::markAggregate): (JSC::Stringifier::stringify): (JSC::Stringifier::Holder::appendNextProperty): (JSC::Walker::callReviver): (JSC::Walker::walk):
  • runtime/JSObject.cpp: (JSC::JSObject::defineGetter): (JSC::JSObject::defineSetter): (JSC::JSObject::removeDirect): (JSC::JSObject::putDirectFunction): (JSC::JSObject::putDirectFunctionWithoutTransition): (JSC::putDescriptor): (JSC::JSObject::defineOwnProperty):
  • runtime/JSObject.h: (JSC::JSObject::getDirectOffset): (JSC::JSObject::putDirectOffset): (JSC::JSObject::flattenDictionaryObject): (JSC::JSObject::putDirectInternal): (JSC::JSObject::putDirect): (JSC::JSObject::putDirectFunction): (JSC::JSObject::putDirectWithoutTransition): (JSC::JSObject::putDirectFunctionWithoutTransition): (JSC::JSValue::putDirect): (JSC::JSObject::allocatePropertyStorageInline): (JSC::JSObject::markChildrenDirect):
  • runtime/JSPropertyNameIterator.cpp: (JSC::JSPropertyNameIterator::JSPropertyNameIterator): (JSC::JSPropertyNameIterator::get):
  • runtime/JSPropertyNameIterator.h:
  • runtime/JSStaticScopeObject.cpp: (JSC::JSStaticScopeObject::markChildren):
  • runtime/JSString.cpp: (JSC::StringObject::create):
  • runtime/JSValue.h:
  • runtime/JSWrapperObject.cpp: (JSC::JSWrapperObject::markChildren):
  • runtime/JSWrapperObject.h: (JSC::JSWrapperObject::internalValue): (JSC::JSWrapperObject::setInternalValue):
  • runtime/LiteralParser.cpp: (JSC::LiteralParser::parse):
  • runtime/Lookup.cpp: (JSC::setUpStaticFunctionSlot):
  • runtime/Lookup.h: (JSC::lookupPut):
  • runtime/MarkStack.h: (JSC::MarkStack::appendValues):
  • runtime/MathObject.cpp: (JSC::MathObject::MathObject):
  • runtime/NativeErrorConstructor.cpp: (JSC::NativeErrorConstructor::NativeErrorConstructor):
  • runtime/NativeErrorPrototype.cpp: (JSC::NativeErrorPrototype::NativeErrorPrototype):
  • runtime/NumberConstructor.cpp: (JSC::NumberConstructor::NumberConstructor): (JSC::constructWithNumberConstructor):
  • runtime/NumberObject.cpp: (JSC::constructNumber):
  • runtime/NumberPrototype.cpp: (JSC::NumberPrototype::NumberPrototype):
  • runtime/ObjectConstructor.cpp: (JSC::ObjectConstructor::ObjectConstructor): (JSC::objectConstructorGetOwnPropertyDescriptor):
  • runtime/Operations.h: (JSC::normalizePrototypeChain): (JSC::resolveBase):
  • runtime/PrototypeFunction.cpp: (JSC::PrototypeFunction::PrototypeFunction):
  • runtime/PutPropertySlot.h: (JSC::PutPropertySlot::setExistingProperty): (JSC::PutPropertySlot::setNewProperty): (JSC::PutPropertySlot::base):
  • runtime/RegExpConstructor.cpp: (JSC::RegExpConstructor::RegExpConstructor):
  • runtime/ScopeChain.cpp: (JSC::ScopeChainNode::print):
  • runtime/ScopeChain.h: (JSC::ScopeChainNode::~ScopeChainNode): (JSC::ScopeChainIterator::operator*): (JSC::ScopeChainIterator::operator->): (JSC::ScopeChain::top):
  • runtime/ScopeChainMark.h: (JSC::ScopeChain::markAggregate):
  • runtime/SmallStrings.cpp: (JSC::isMarked): (JSC::SmallStrings::markChildren):
  • runtime/SmallStrings.h: (JSC::SmallStrings::emptyString): (JSC::SmallStrings::singleCharacterString): (JSC::SmallStrings::singleCharacterStrings):
  • runtime/StringConstructor.cpp: (JSC::StringConstructor::StringConstructor):
  • runtime/StringObject.cpp: (JSC::StringObject::StringObject):
  • runtime/StringObject.h:
  • runtime/StringPrototype.cpp: (JSC::StringPrototype::StringPrototype):
  • runtime/Structure.cpp: (JSC::Structure::Structure): (JSC::Structure::addPropertyTransition): (JSC::Structure::toDictionaryTransition): (JSC::Structure::flattenDictionaryStructure):
  • runtime/Structure.h: (JSC::Structure::storedPrototype):
  • runtime/WeakGCMap.h: (JSC::WeakGCMap::uncheckedGet): (JSC::WeakGCMap::isValid): (JSC::::get): (JSC::::take): (JSC::::set): (JSC::::uncheckedRemove):
  • runtime/WriteBarrier.h: Removed.

2011-01-30 Csaba Osztrogonác <ossy@webkit.org>

Unreviewed, rolling out r77098, r77099, r77100, r77109, and
r77111.
http://trac.webkit.org/changeset/77098
http://trac.webkit.org/changeset/77099
http://trac.webkit.org/changeset/77100
http://trac.webkit.org/changeset/77109
http://trac.webkit.org/changeset/77111
https://bugs.webkit.org/show_bug.cgi?id=53219

Qt build is broken

  • JSValueWrapper.cpp: (JSValueWrapper::JSObjectMark):

2011-01-30 Csaba Osztrogonác <ossy@webkit.org>

Unreviewed, rolling out r77098, r77099, r77100, r77109, and
r77111.
http://trac.webkit.org/changeset/77098
http://trac.webkit.org/changeset/77099
http://trac.webkit.org/changeset/77100
http://trac.webkit.org/changeset/77109
http://trac.webkit.org/changeset/77111
https://bugs.webkit.org/show_bug.cgi?id=53219

Qt build is broken

  • ForwardingHeaders/runtime/WriteBarrier.h: Removed.
  • WebCore.exp.in:
  • bindings/js/DOMWrapperWorld.h:
  • bindings/js/JSAudioConstructor.cpp: (WebCore::JSAudioConstructor::JSAudioConstructor):
  • bindings/js/JSDOMBinding.cpp: (WebCore::markDOMNodesForDocument): (WebCore::markDOMObjectWrapper): (WebCore::markDOMNodeWrapper):
  • bindings/js/JSDOMGlobalObject.cpp: (WebCore::JSDOMGlobalObject::markChildren): (WebCore::JSDOMGlobalObject::setInjectedScript): (WebCore::JSDOMGlobalObject::injectedScript):
  • bindings/js/JSDOMGlobalObject.h: (WebCore::JSDOMGlobalObject::JSDOMGlobalObjectData::JSDOMGlobalObjectData): (WebCore::getDOMConstructor):
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::setLocation): (WebCore::DialogHandler::dialogCreated):
  • bindings/js/JSDOMWindowShell.cpp: (WebCore::JSDOMWindowShell::JSDOMWindowShell): (WebCore::JSDOMWindowShell::setWindow): (WebCore::JSDOMWindowShell::markChildren): (WebCore::JSDOMWindowShell::unwrappedObject):
  • bindings/js/JSDOMWindowShell.h: (WebCore::JSDOMWindowShell::window): (WebCore::JSDOMWindowShell::setWindow):
  • bindings/js/JSDeviceMotionEventCustom.cpp: (WebCore::createAccelerationObject): (WebCore::createRotationRateObject):
  • bindings/js/JSEventListener.cpp: (WebCore::JSEventListener::JSEventListener): (WebCore::JSEventListener::markJSFunction):
  • bindings/js/JSEventListener.h: (WebCore::JSEventListener::jsFunction):
  • bindings/js/JSHTMLDocumentCustom.cpp: (WebCore::JSHTMLDocument::setAll):
  • bindings/js/JSImageConstructor.cpp: (WebCore::JSImageConstructor::JSImageConstructor):
  • bindings/js/JSImageDataCustom.cpp: (WebCore::toJS):
  • bindings/js/JSJavaScriptCallFrameCustom.cpp: (WebCore::JSJavaScriptCallFrame::scopeChain): (WebCore::JSJavaScriptCallFrame::scopeType):
  • bindings/js/JSNodeFilterCondition.cpp: (WebCore::JSNodeFilterCondition::markAggregate): (WebCore::JSNodeFilterCondition::acceptNode):
  • bindings/js/JSNodeFilterCondition.h:
  • bindings/js/JSNodeFilterCustom.cpp:
  • bindings/js/JSOptionConstructor.cpp: (WebCore::JSOptionConstructor::JSOptionConstructor):
  • bindings/js/JSSQLResultSetRowListCustom.cpp: (WebCore::JSSQLResultSetRowList::item):
  • bindings/js/ScriptCachedFrameData.cpp: (WebCore::ScriptCachedFrameData::restore):
  • bindings/js/ScriptObject.cpp: (WebCore::ScriptGlobalObject::set):
  • bindings/js/SerializedScriptValue.cpp: (WebCore::CloneDeserializer::putProperty):
  • bindings/scripts/CodeGeneratorJS.pm:
  • bridge/qt/qt_instance.cpp: (JSC::Bindings::QtInstance::QtInstance): (JSC::Bindings::QtInstance::removeCachedMethod): (JSC::Bindings::QtInstance::markAggregate):
  • bridge/qt/qt_instance.h:
  • bridge/qt/qt_runtime.cpp: (JSC::Bindings::QtRuntimeMetaMethod::QtRuntimeMetaMethod): (JSC::Bindings::QtRuntimeMetaMethod::markChildren): (JSC::Bindings::QtRuntimeMetaMethod::connectGetter): (JSC::Bindings::QtRuntimeMetaMethod::disconnectGetter):
  • bridge/qt/qt_runtime.h:
  • bridge/runtime_root.cpp: (JSC::Bindings::RootObject::invalidate):
  • bridge/runtime_root.h:
  • dom/Document.h:

2011-01-30 Csaba Osztrogonác <ossy@webkit.org>

Unreviewed, rolling out r77098, r77099, r77100, r77109, and
r77111.
http://trac.webkit.org/changeset/77098
http://trac.webkit.org/changeset/77099
http://trac.webkit.org/changeset/77100
http://trac.webkit.org/changeset/77109
http://trac.webkit.org/changeset/77111
https://bugs.webkit.org/show_bug.cgi?id=53219

Qt build is broken

  • WebView/WebScriptDebugDelegate.mm: (-[WebScriptCallFrame scopeChain]):
22:18 Changeset [77112] by simon.fraser@apple.com

2011-01-30 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r77107.
http://trac.webkit.org/changeset/77107
https://bugs.webkit.org/show_bug.cgi?id=53412

Caused 5 new form-related test crashes (Requested by smfr on
#webkit).

  • css/CSSSelector.cpp: (WebCore::CSSSelector::pseudoId): (WebCore::nameToPseudoTypeMap): (WebCore::CSSSelector::extractPseudoType):
  • css/CSSSelector.h:
  • html/HTMLProgressElement.cpp: (WebCore::HTMLProgressElement::parseMappedAttribute): (WebCore::HTMLProgressElement::attach):
  • html/HTMLProgressElement.h:
  • rendering/RenderProgress.cpp: (WebCore::RenderProgress::~RenderProgress): (WebCore::RenderProgress::updateFromElement): (WebCore::RenderProgress::layoutParts): (WebCore::RenderProgress::shouldHaveParts):
  • rendering/RenderProgress.h:
  • rendering/style/RenderStyleConstants.h:
22:05 Changeset [77111] by simon.fraser@apple.com

2011-01-30 Simon Fraser <simon.fraser@apple.com>

Build fix the build fix. I assume Oliver meant m_cell, not m_value.

  • runtime/WriteBarrier.h: (JSC::WriteBarrierBase::clear):
22:02 Changeset [77110] by simon.fraser@apple.com

2011-01-30 Simon Fraser <simon.fraser@apple.com>

Reviewed by Sam Weinig.

Enhance ShadowBlur to render inset box shadows
https://bugs.webkit.org/show_bug.cgi?id=51567

Use ShadowBlur for inset box-shadows with CG. It
currently lacks a tiled version, but is still much
faster than CG shadows.

Test: fast/box-shadow/inset-box-shadow-radius.html

  • platform/graphics/ShadowBlur.cpp:
  • platform/graphics/ShadowBlur.h: New method for inset shadows. (WebCore::ShadowBlur::drawInsetShadow):
  • platform/graphics/GraphicsContext.cpp: #ifdef out fillRectWithRoundedHole() for CG.
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::fillRectWithRoundedHole): If there's a shadow with a radius > 0, use ShadowBlur.
21:54 Changeset [77109] by oliver@apple.com

More Qt build fixes

21:11 Changeset [77108] by kbr@google.com

2011-01-28 Kenneth Russell <kbr@google.com>

Reviewed by Chris Marrin.

WebGL shows PNG Textures with indexed colors too dark
https://bugs.webkit.org/show_bug.cgi?id=47477

Added test case for upload of indexed PNG images to
gl-teximage.html in the Khronos WebGL conformance tests.
Synchronized this test with the Khronos repository.

  • fast/canvas/webgl/gl-teximage-expected.txt:
  • fast/canvas/webgl/gl-teximage.html:
  • fast/canvas/webgl/resources/red-indexed.png: Added.

2011-01-28 Kenneth Russell <kbr@google.com>

Reviewed by Chris Marrin.

WebGL shows PNG Textures with indexed colors too dark
https://bugs.webkit.org/show_bug.cgi?id=47477

Properly handle indexed PNG images by re-rendering them as RGBA
images before upload. Verified with this layout test and the test
cases from bugs 47477 and 53269.

  • platform/graphics/cg/GraphicsContext3DCG.cpp: (WebCore::GraphicsContext3D::getImageData):
20:39 Changeset [77107] by morrita@google.com

2011-01-27 MORITA Hajime <morrita@google.com>

Reviewed by Dimitri Glazkov.

Convert <progress> shadow DOM to a DOM-based shadow.
https://bugs.webkit.org/show_bug.cgi?id=50660

  • Removed RenderProgress::m_valuePart, moved the shadow node to the shadow root of HTMLProgressElement.
  • Removed hard-coded pseudo ID for -webkit-progress-bar-value. ProgressBarValueElement is defined only for overriding shadowPseudoId().

No new tests. No behavioral change.

  • css/CSSSelector.cpp: (WebCore::CSSSelector::pseudoId): (WebCore::nameToPseudoTypeMap): (WebCore::CSSSelector::extractPseudoType):
  • css/CSSSelector.h:
  • html/HTMLProgressElement.cpp: (WebCore::ProgressBarValueElement::ProgressBarValueElement): (WebCore::ProgressBarValueElement::shadowPseudoId): (WebCore::ProgressBarValueElement::create): (WebCore::HTMLProgressElement::parseMappedAttribute): (WebCore::HTMLProgressElement::attach): (WebCore::HTMLProgressElement::valuePart): (WebCore::HTMLProgressElement::didElementStateChange): (WebCore::HTMLProgressElement::createShadowSubtreeIfNeeded):
  • html/HTMLProgressElement.h:
  • rendering/RenderProgress.cpp: (WebCore::RenderProgress::~RenderProgress): (WebCore::RenderProgress::updateFromElement): (WebCore::RenderProgress::layoutParts): (WebCore::RenderProgress::shouldHaveParts): (WebCore::RenderProgress::valuePart):
  • rendering/RenderProgress.h:
  • rendering/style/RenderStyleConstants.h:
20:26 Changeset [77106] by simon.fraser@apple.com

2011-01-30 Simon Fraser <simon.fraser@apple.com>

Reviewed by Ariya Hidayat.

Enhance ShadowBlur to render inset box shadows; Part 1.
https://bugs.webkit.org/show_bug.cgi?id=51567

Add a new method to GraphicsContext to render a rect with a rounded hole,
for use by inset box-shadow code. Knowledge that we're rendering a rounded
hole will enable ShadowBlur to be used here in future.

  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::fillRectWithRoundedHole):
  • platform/graphics/GraphicsContext.h:
  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintBoxShadow):
20:23 Changeset [77105] by morrita@google.com

2011-01-23 MORITA Hajime <morrita@google.com>

Reviewed by Eric Seidel.

REGRESSION: Inset shadow with too large border radius misses rounded corner.
https://bugs.webkit.org/show_bug.cgi?id=52800

  • fast/box-shadow/inset-with-extraordinary-radii-and-border.html: Added.
  • platform/mac/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.checksum: Added.
  • platform/mac/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.png: Added.
  • platform/mac/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.txt: Added.

2011-01-23 MORITA Hajime <morrita@google.com>

Reviewed by Eric Seidel.

REGRESSION: Inset shadow with too large border radius misses rounded corner.
https://bugs.webkit.org/show_bug.cgi?id=52800

The refactoring on r76083 broke the invariant between border
IntRect and its radii because RoundedIntRect::setRect() is called
after getRoundedInnerBorderWithBorderWidths(), which enforces the
invariant. Th rounded-rect clipping code verifies the invariant,
and discard the invalid radii, that results broken paintings.

This change moved setRect() before
getRoundedInnerBorderWithBorderWidths() not to modify the valid
RoundedIntRect value.

Test: fast/box-shadow/inset-with-extraordinary-radii-and-border.html

  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintBoxShadow):
20:06 Changeset [77104] by ggaren@apple.com

2011-01-30 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

[Take 2!]
Fixed crash on window close (maybe crash on launch?) due to missing frame null checks
https://bugs.webkit.org/show_bug.cgi?id=53408

  • UIProcess/WebContext.cpp: (WebKit::WebContext::didNavigateWithNavigationData): (WebKit::WebContext::didPerformClientRedirect): (WebKit::WebContext::didPerformServerRedirect): (WebKit::WebContext::didUpdateHistoryTitle): Use MESSAGE_CHECK because we don't think we should be able to reach this state under normal conditions.
20:05 Changeset [77103] by simon.fraser@apple.com

2011-01-30 Simon Fraser <simon.fraser@apple.com>

Attempt to fix Windows build by adding ShadowBlur.cpp/h to the
vcproj.

  • WebCore.vcproj/WebCore.vcproj:
19:36 Changeset [77102] by ggaren@apple.com

2011-01-30 Geoffrey Garen <ggaren@apple.com>

Reviewed by Maciej Stachowiak.

Fixed crash on window close (maybe crash on launch?) due to missing
frame null checks
https://bugs.webkit.org/show_bug.cgi?id=53408

  • UIProcess/WebContext.cpp: (WebKit::WebContext::didNavigateWithNavigationData): (WebKit::WebContext::didPerformClientRedirect): (WebKit::WebContext::didPerformServerRedirect): (WebKit::WebContext::didUpdateHistoryTitle): Check for NULL, since we're calling a function that can return it.
19:36 Changeset [77101] by simon.fraser@apple.com

2011-01-30 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

-webkit-box-shadow causes awful scroll/resize/redraw performance
https://bugs.webkit.org/show_bug.cgi?id=22102

Use ShadowBlur for CG, whe rendering shadows on rects and
rounded rects outside of canvas.

CG shadows with a radius of more than 8px do not render
correctly. We preserve this incorrect rendering by compensating
for it when rending -webkit-box-shadow. Calls that should use
this deprecated radius behavior now use setLegacyShadow().

Test: fast/box-shadow/box-shadow-transformed.html

  • html/canvas/CanvasRenderingContext2D.cpp: Use setLegacyShadow() for canvas, to indicate that it should use the deprecated radius behavior. (WebCore::CanvasRenderingContext2D::setAllAttributesToDefault): Ditto. (WebCore::CanvasRenderingContext2D::setShadow): Ditto. (WebCore::CanvasRenderingContext2D::applyShadow): Ditto.
  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::setLegacyShadow): Set the m_state.shadowsUseLegacyRadius bit.
  • platform/graphics/GraphicsContext.h: (WebCore::GraphicsContextState::GraphicsContextState): Add a shadowsUseLegacyRadius bit to the state.
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::radiusToLegacyRadius): Map from the actual radius to one that approximates CG behavior. (WebCore::hasBlurredShadow): Helper that returns true if we have a shadow with a non-zero blur radius. (WebCore::GraphicsContext::fillRect): Use ShadowBlur if not canvas. (WebCore::GraphicsContext::fillRoundedRect): Ditto. (WebCore::GraphicsContext::setPlatformShadow): Comment.
  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintBoxShadow): Call setLegacyShadow() for -webkit-box-shadow.
  • platform/graphics/ShadowBlur.cpp: (WebCore::ShadowBlur::calculateLayerBoundingRect): Fix some pixel crack issues by rounding up the blur radius. (WebCore::ShadowBlur::drawRectShadow): Ditto (WebCore::ShadowBlur::drawRectShadowWithTiling): Ditto.
19:11 Changeset [77100] by oliver@apple.com

Try to fix Qt build (again).

17:35 Changeset [77099] by oliver@apple.com

Try to fix Qt build.

17:13 Changeset [77098] by oliver@apple.com

Convert markstack to a slot visitor API
https://bugs.webkit.org/show_bug.cgi?id=53219

rolling r77006 and r77020 back in.

16:44 Changeset [77097] by simon.fraser@apple.com

2011-01-30 Simon Fraser <simon.fraser@apple.com>

Reviewed by Sam Weinig.

Make ContextShadow code cross-platform
https://bugs.webkit.org/show_bug.cgi?id=51312

Add a new class, ShadowBlur, that contains most of the
code from ContextShadow, but is fully cross-platform.
It depends on one new method, GraphicsContext::clipBounds(),
which platforms will have to implement.

Add ShadowBlur to the Mac Xcode project, but don't use it
anywhere yet.

  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::clipBounds):
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/ShadowBlur.cpp: Added. (WebCore::roundUpToMultipleOf32): (WebCore::ScratchBuffer::ScratchBuffer): (WebCore::ScratchBuffer::getScratchBuffer): (WebCore::ScratchBuffer::scheduleScratchBufferPurge): (WebCore::ScratchBuffer::timerFired): (WebCore::ScratchBuffer::clearScratchBuffer): (WebCore::ScratchBuffer::shared): (WebCore::ShadowBlur::ShadowBlur): (WebCore::ShadowBlur::blurLayerImage): (WebCore::ShadowBlur::adjustBlurDistance): (WebCore::ShadowBlur::calculateLayerBoundingRect): (WebCore::ShadowBlur::beginShadowLayer): (WebCore::ShadowBlur::endShadowLayer): (WebCore::ShadowBlur::drawRectShadow): (WebCore::ShadowBlur::drawRectShadowWithoutTiling): (WebCore::ShadowBlur::drawRectShadowWithTiling): (WebCore::ShadowBlur::clipBounds):
  • platform/graphics/ShadowBlur.h: Added. (WebCore::ShadowBlur::setShadowsIgnoreTransforms): (WebCore::ShadowBlur::shadowsIgnoreTransforms):
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::clipBounds):
15:32 Changeset [77096] by dpranke@chromium.org

2011-01-30 Dirk Pranke <dpranke@chromium.org>

Unreviewed, build fix.

Fix regression introduced in r77093 - path.rsplit() doesn't
take keyword arguments.

https://bugs.webkit.org/show_bug.cgi?id=53326

  • Scripts/webkitpy/common/system/filesystem_mock.py:
15:16 Changeset [77095] by dpranke@chromium.org

2011-01-30 Dirk Pranke <dpranke@chromium.org>

Reviewed by Mihai Parparita.

Add more unit tests for rebaseline-chromium-webkit-tests. This
change involves restructuring a bunch of r-c-w-t code to make it
more testable as well. We also add wrapper classes for handling
testing zip files and fetching URLs.

https://bugs.webkit.org/show_bug.cgi?id=53040

  • Scripts/webkitpy/common/system/urlfetcher.py:
  • Scripts/webkitpy/common/system/urlfetcher_mock.py:
  • Scripts/webkitpy/common/system/zipfileset_mock.py:
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
  • Scripts/webkitpy/tool/mocktool.py:
15:07 Changeset [77094] by ggaren@apple.com

2011-01-30 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Filter all Heap collection through a common reset function, in
preparation for adding features triggered by collection.
https://bugs.webkit.org/show_bug.cgi?id=53396


SunSpider reports no change.

  • runtime/Heap.cpp: (JSC::Heap::reportExtraMemoryCostSlowCase): When we're over the extraCost limit, just call collectAllGarbage() instead of rolling our own special way of resetting the heap. In theory, this may be slower in some cases, but it also fixes cases of pathological heap growth that we've seen, where the only objects being allocated are temporary and huge (<rdar://problem/8885843>).

(JSC::Heap::allocate):
(JSC::Heap::collectAllGarbage): Use the shared reset function.

(JSC::Heap::reset):

  • runtime/Heap.h: Carved a new shared reset function out of the old collectAllGarbage.
15:07 Changeset [77093] by dpranke@chromium.org

2011-01-30 Dirk Pranke <dpranke@chromium.org>

Reviewed by Eric Seidel.

Clean up of the filesystem-related modules used in webkitpy.
I've added relpath() to the filesystem interface, modified
ospath.relpath() so that it could work with the filesystem
interface, and modified the fileset* routines to use the
filesystem interface consistently.

This patch also adds a close() routine to the fileset routines
to indicate that the caller is done with the fileset. This
allows zipfileset to clean up after itself when it creates
tempfiles to store downloads.

https://bugs.webkit.org/show_bug.cgi?id=53326

  • Scripts/webkitpy/common/system/directoryfileset.py:
  • Scripts/webkitpy/common/system/fileset.py:
  • Scripts/webkitpy/common/system/filesystem.py:
  • Scripts/webkitpy/common/system/filesystem_mock.py:
  • Scripts/webkitpy/common/system/filesystem_unittest.py:
  • Scripts/webkitpy/common/system/ospath.py:
  • Scripts/webkitpy/common/system/zipfileset.py:
  • Scripts/webkitpy/common/system/zipfileset_unittest.py:
12:25 Changeset [77092] by kbalazs@webkit.org

2011-01-30 Balazs Kelemen <kbalazs@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt][WK2]REGRESSION (r76991): Fix build errors
https://bugs.webkit.org/show_bug.cgi?id=53400

Revert the temporary build fix (http://trac.webkit.org/changeset/77088)
and remove WebKit2Prefix.h from the build.

  • UIProcess/API/qt/qwkhistory.h:
  • UIProcess/API/qt/qwkpage.h:
  • WebKit2.pro:

2011-01-30 Balazs Kelemen <kbalazs@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt][WK2]REGRESSION (r76991): Fix build errors
https://bugs.webkit.org/show_bug.cgi?id=53400

Revert the temporary build fix (http://trac.webkit.org/changeset/77088)
and remove WebKit2Prefix.h from the build.

  • MiniBrowser/qt/MiniBrowser.pro:
12:04 Changeset [77091] by commit-queue@webkit.org

2011-01-30 Jeff Miller <jeffm@apple.com>

Reviewed by Dan Bernstein.

FindController::updateFindIndicator() crashes if selection isn't visible
https://bugs.webkit.org/show_bug.cgi?id=53399

  • WebProcess/WebPage/FindController.cpp: (WebKit::FindController::updateFindIndicator): Return false if ShareableBitmap::createShareable() returns null (typically because the selection rect is empty).
11:54 Changeset [77090] by ossy@webkit.org

Unreviewed, rolling out r77025.
http://trac.webkit.org/changeset/77025
https://bugs.webkit.org/show_bug.cgi?id=53401

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-01-30
It made js1_5/Regress/regress-159334.js fail on 64 bit Linux
(Requested by Ossy on #webkit).

  • jit/ExecutableAllocatorFixedVMPool.cpp:

(JSC::FreeListEntry::FreeListEntry):
(JSC::AVLTreeAbstractorForFreeList::get_less):
(JSC::AVLTreeAbstractorForFreeList::set_less):
(JSC::AVLTreeAbstractorForFreeList::get_greater):
(JSC::AVLTreeAbstractorForFreeList::set_greater):
(JSC::AVLTreeAbstractorForFreeList::get_balance_factor):
(JSC::AVLTreeAbstractorForFreeList::set_balance_factor):
(JSC::AVLTreeAbstractorForFreeList::null):
(JSC::AVLTreeAbstractorForFreeList::compare_key_key):
(JSC::AVLTreeAbstractorForFreeList::compare_key_node):
(JSC::AVLTreeAbstractorForFreeList::compare_node_node):
(JSC::reverseSortFreeListEntriesByPointer):
(JSC::reverseSortCommonSizedAllocations):
(JSC::FixedVMPoolAllocator::release):
(JSC::FixedVMPoolAllocator::reuse):
(JSC::FixedVMPoolAllocator::addToFreeList):
(JSC::FixedVMPoolAllocator::coalesceFreeSpace):
(JSC::FixedVMPoolAllocator::FixedVMPoolAllocator):
(JSC::FixedVMPoolAllocator::alloc):
(JSC::FixedVMPoolAllocator::free):
(JSC::FixedVMPoolAllocator::isValid):
(JSC::FixedVMPoolAllocator::allocInternal):
(JSC::FixedVMPoolAllocator::isWithinVMPool):
(JSC::FixedVMPoolAllocator::addToCommittedByteCount):
(JSC::ExecutableAllocator::committedByteCount):
(JSC::maybeModifyVMPoolSize):
(JSC::ExecutableAllocator::isValid):
(JSC::ExecutableAllocator::underMemoryPressure):
(JSC::ExecutablePool::systemAlloc):
(JSC::ExecutablePool::systemRelease):

  • wtf/PageReservation.h:

(WTF::PageReservation::PageReservation):
(WTF::PageReservation::commit):
(WTF::PageReservation::decommit):

10:19 Changeset [77089] by simon.fraser@apple.com

2011-01-29 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

CSS3 gradients with em-based stops fail to repaint when font size changes
https://bugs.webkit.org/show_bug.cgi?id=51845

Mark as uncacheable gradidients whose color stops depend on font size,
and don't attempt to put these into CSSImageGeneratorValue's image cache.
This means we return a new gradient each time, which is fairly cheap, and
fixes repaint issues under changing font size.

Test: fast/repaint/gradients-em-stops-repaint.html

  • css/CSSGradientValue.cpp: (WebCore::CSSGradientValue::image): (WebCore::CSSGradientValue::isCacheable):
  • css/CSSGradientValue.h:
05:21 Changeset [77088] by ossy@webkit.org

Unreviewed.

[Qt][WK2] Buildfix.

Source/WebKit2:

  • UIProcess/API/qt/qwkhistory.h:
  • UIProcess/API/qt/qwkpage.h:

Tools:

  • MiniBrowser/qt/MiniBrowser.pro:
03:54 Changeset [77087] by commit-queue@webkit.org

2011-01-30 Leo Yang <leo.yang@torchmobile.com.cn>

Reviewed by Daniel Bates.

Code style issue in JavaScriptCore/wtf/CurrentTime.h
https://bugs.webkit.org/show_bug.cgi?id=53394

According to rule #3 at http://webkit.org/coding/coding-style.html,
This patch fix style issue in CurrentTime.h.

No functionality change, no new tests.

  • wtf/CurrentTime.h: (WTF::currentTimeMS): (WTF::getLocalTime):
02:40 Changeset [77086] by commit-queue@webkit.org

2011-01-30 Benjamin Poulain <ikipou@gmail.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] JavaScriptCore does not link on Mac if building WebKit 2
https://bugs.webkit.org/show_bug.cgi?id=53377

The option "-whole-archive" is not availabe with the libtool of Mac OS X,
instead, we can use "-all_load" on Mac.

00:30 Changeset [77085] by mjs@apple.com

2011-01-29 Maciej Stachowiak <mjs@apple.com>

Reviewed by Geoffrey Garen.

Add WKPageCopyPendingAPIRequestURL API
https://bugs.webkit.org/show_bug.cgi?id=53383

This API returns the last URL requested for load via API, if neither that load nor any
other load subsequently reaches the provisional state.


This is useful to be able to track loads initiated via the API


  • UIProcess/API/C/WKPage.cpp: (WKPageCopyPendingAPIRequestURL): Retrieve the pending URL.
  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::loadURL): Set pending URL. (WebKit::WebPageProxy::loadURLRequest): ditto (WebKit::WebPageProxy::reload): ditto (WebKit::WebPageProxy::goForward): ditto (WebKit::WebPageProxy::goBack): ditto (WebKit::WebPageProxy::estimatedProgress): Assume the initial progress value when there is a pending URL. (WebKit::WebPageProxy::didStartProvisionalLoadForFrame): Clear pending URL; clients should look at the provisional URL now. (WebKit::WebPageProxy::decidePolicyForNavigationAction): Clear pending URL if it doesn't match the policy URL; this means we were interrupted by another load.
  • UIProcess/WebPageProxy.h: (WebKit::WebPageProxy::pendingAPIRequestURL): Helper function. (WebKit::WebPageProxy::clearPendingAPIRequestURL): ditto (WebKit::WebPageProxy::setPendingAPIRequestURL): ditto

01/29/11:

22:48 Changeset [77084] by mitz@apple.com

Set the svn:mime-type property of some PNG files to image/png

22:43 Changeset [77083] by ggaren@apple.com

Sorry Leopard bot -- I committed a change by accident.

22:23 Changeset [77082] by ggaren@apple.com

2011-01-29 Geoffrey Garen <ggaren@apple.com>

Reviewed by Cameron Zwarich.

Simplified Heap iteration
https://bugs.webkit.org/show_bug.cgi?id=53393

  • runtime/CollectorHeapIterator.h: (JSC::CollectorHeapIterator::isValid): (JSC::CollectorHeapIterator::isLive): (JSC::CollectorHeapIterator::advance): Removed "max" argument to advance because it's a constant. (JSC::LiveObjectIterator::LiveObjectIterator): (JSC::LiveObjectIterator::operator++): (JSC::DeadObjectIterator::DeadObjectIterator): (JSC::DeadObjectIterator::operator++): (JSC::ObjectIterator::ObjectIterator): (JSC::ObjectIterator::operator++): Factored out common checks into two helper functions -- isValid() for "Am I past the end?" and isLive() for "Is the cell I'm pointing to live?".
  • runtime/MarkedSpace.cpp: (JSC::MarkedSpace::freeBlock): (JSC::MarkedSpace::sweep): Always sweep from the beginning of the heap to the end, to avoid making sweep subtly reliant on internal Heap state. (JSC::MarkedSpace::primaryHeapBegin): (JSC::MarkedSpace::primaryHeapEnd): Always be explicit about where iteration begins.
22:11 Changeset [77081] by ggaren@apple.com

2011-01-29 Geoffrey Garen <ggaren@apple.com>

Reviewed by Cameron Zwarich.

Simplified heap destruction
https://bugs.webkit.org/show_bug.cgi?id=53392

  • JavaScriptCore.exp:
  • runtime/Heap.cpp: (JSC::Heap::destroy):
  • runtime/Heap.h:
  • runtime/MarkedSpace.cpp: (JSC::MarkedSpace::destroy):
  • runtime/MarkedSpace.h: Don't go out of our way to destroy GC-protected cells last -- the difficult contortions required to do so just don't seem justified. We make no guarantees about GC protection after the client throws away JSGlobalData, and it doesn't seem like any meaningful guarantee is even possible.
21:58 Changeset [77080] by ggaren@apple.com

2011-01-29 Geoffrey Garen <ggaren@apple.com>

Reviewed by Maciej Stachowiak.

Switched heap to use the Bitmap class and removed CollectorBitmap
https://bugs.webkit.org/show_bug.cgi?id=53391


SunSpider says 1.005x as fast. Seems like a fluke.

  • runtime/MarkedSpace.cpp: (JSC::MarkedSpace::allocate): Updated for rename and returning a value rather than taking a value by reference.
  • runtime/MarkedSpace.h: Code reuse is good.
  • wtf/Bitmap.h: (WTF::::testAndSet): Added, since this is the one thing Bitmap was missing which CollectorBitmap had. (Renamed from the less conventional "getset".)

(WTF::::nextPossiblyUnset): Renamed and changed to return a value for
clarity. It's all the same with inlining.

20:17 Changeset [77079] by ggaren@apple.com

Undo try to fix the Qt build.

My guess didn't work.

  • WebCore.pro:
20:04 Changeset [77078] by ggaren@apple.com

Try to fix the Qt build.

  • WebCore.pro: Added platform/text/CharacterNames.h.
19:32 Changeset [77077] by ggaren@apple.com

2011-01-28 Geoffrey Garen <ggaren@apple.com>

Reviewed by Maciej Stachowiak.

Some more Heap cleanup.
https://bugs.webkit.org/show_bug.cgi?id=53357


  • runtime/Heap.cpp: (JSC::Heap::reportExtraMemoryCostSlowCase): Renamed recordExtraCost to reportExtraMemoryCostSlowCase to match our naming conventions.

(JSC::Heap::capacity): Renamed size to capacity because this function
returns the capacity of the heap, including unused portions.

  • runtime/Heap.h: (JSC::Heap::globalData): (JSC::Heap::markedSpace): (JSC::Heap::machineStackMarker): (JSC::Heap::reportExtraMemoryCost): Moved statics to the top of the file. Moved ctor and dtor to the beginning of the class definition. Grouped functions by purpose.
  • runtime/MarkedSpace.cpp: (JSC::MarkedSpace::capacity): Renamed size to capacity because this function returns the capacity of the heap, including unused portions.
  • runtime/MarkedSpace.h: Removed statistics and the Statistics class because the same information can be gotten just by calling size() and capacity().
  • runtime/MemoryStatistics.cpp:
  • runtime/MemoryStatistics.h: Ditto.

2011-01-28 Geoffrey Garen <ggaren@apple.com>

Reviewed by Maciej Stachowiak.

Some more Heap cleanup.
https://bugs.webkit.org/show_bug.cgi?id=53357

Updated for JavaScriptCore changes.

  • Misc/WebCoreStatistics.mm: (+[WebCoreStatistics memoryStatistics]):

2011-01-28 Geoffrey Garen <ggaren@apple.com>

Reviewed by Maciej Stachowiak.

Some more Heap cleanup.
https://bugs.webkit.org/show_bug.cgi?id=53357


Updated for JavaScriptCore changes.

  • bindings/js/ScriptGCEvent.cpp: (WebCore::ScriptGCEvent::getHeapSize):
18:39 Changeset [77076] by abarth@webkit.org

2011-01-29 Adam Barth <abarth@webkit.org>

Reviewed by Daniel Bates.

Fix XSSFilter crash when extracting the source for a token twice
https://bugs.webkit.org/show_bug.cgi?id=53368

Previously, it was unsafe to extract the source for the same token
twice because the HTMLSourceTracker would advance its internal
representation of the SegmentedString. This patch introduces a cache
to make calling HTMLSourceTracker::sourceForToken multiple times safe.

  • html/parser/HTMLSourceTracker.cpp: (WebCore::HTMLSourceTracker::end): (WebCore::HTMLSourceTracker::sourceForToken):
  • html/parser/HTMLSourceTracker.h:
16:22 Changeset [77075] by mjs@apple.com

2011-01-29 Maciej Stachowiak <mjs@apple.com>

Reviewed by Dan Bernstein.

Fix fat build for both 32-bit and 64-bit under llvm-gcc 4.2
https://bugs.webkit.org/show_bug.cgi?id=53386

  • platform/mac/ScrollAnimatorMac.mm: (WebCore::elasticDeltaForReboundDelta): (WebCore::scrollWheelMultiplier): (WebCore::ScrollAnimatorMac::smoothScrollWithEvent): (WebCore::ScrollAnimatorMac::beginScrollGesture): (WebCore::roundTowardZero): (WebCore::ScrollAnimatorMac::snapRubberBandTimerFired):
15:21 Changeset [77074] by mjs@apple.com

Unreviewed fix for last commit.

Remove stray slash in previous commit.

  • platform/mac-wk2/Skipped:
15:14 Changeset [77073] by dbates@webkit.org

2011-01-29 Daniel Bates <dbates@rim.com>

Reviewed by Maciej Stachowiak.

Remove reference to ${CMAKE_SOURCE_DIR}/Source in CMake files
https://bugs.webkit.org/show_bug.cgi?id=53382

Our file system hierarchy ensures that CMAKE_SOURCE_DIR is defined to be /Source.
So, ${CMAKE_SOURCE_DIR}/Source evaluates to the non-existent directory /Source/Source.
Therefore, we should remove such references.

  • Source/cmake/OptionsCommon.cmake:

2011-01-29 Daniel Bates <dbates@rim.com>

Reviewed by Maciej Stachowiak.

Remove reference to ${CMAKE_SOURCE_DIR}/Source in CMake files
https://bugs.webkit.org/show_bug.cgi?id=53382

Our file system hierarchy ensures that CMAKE_SOURCE_DIR is defined to be /Source.
So, ${CMAKE_SOURCE_DIR}/Source evaluates to the non-existent directory /Source/Source.
Therefore, we should remove such references.

  • CMakeLists.txt:
15:10 Changeset [77072] by mjs@apple.com

2011-01-29 Maciej Stachowiak <mjs@apple.com>

Reviewed by Daniel Bates.

Skip a test that uses unimplemented DRT API
https://bugs.webkit.org/show_bug.cgi?id=53381

  • platform/mac-wk2/Skipped:
14:19 Changeset [77071] by weinig@apple.com

Fix 32-bit build on the Mac.

Reviewed by Jon Honeycutt.

  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::roundTowardZero):
(WebCore::roundToDevicePixelTowardZero):
Use floats instead of doubles to avoid double-to-float conversion
issues.

14:17 Changeset [77070] by dbates@webkit.org

2011-01-29 Daniel Bates <dbates@rim.com>

Reviewed by Eric Seidel.

Move wince/mt19937ar.c to ThirdParty and make it a policy choice
https://bugs.webkit.org/show_bug.cgi?id=53253

Move implementation of Mersenne Twister pseudorandom number generator to
ThirdParty since it is a third party library.

  • Source/ThirdParty/mt19937ar.c: Copied from Source/JavaScriptCore/wtf/wince/mt19937ar.c.

2011-01-29 Daniel Bates <dbates@rim.com>

Reviewed by Eric Seidel.

Move wince/mt19937ar.c to ThirdParty and make it a policy choice
https://bugs.webkit.org/show_bug.cgi?id=53253

Make inclusion of MT19937 a policy decision.

Currently, we hardcoded to use MT19937 when building for
Windows CE. Instead, we should make this a policy decision
with the Windows CE port using this by default.

  • JavaScriptCore.pri: Append Source/ThirdParty to the end of the list include directories.
  • wtf/CMakeLists.txt: Ditto.
  • wtf/Platform.h: Defined WTF_USE_MERSENNE_TWISTER_19937 when building for Windows CE.
  • wtf/RandomNumber.cpp: (WTF::randomNumber): Substituted USE(MERSENNE_TWISTER_19937) for OS(WINCE).
14:00 Changeset [77069] by kov@webkit.org

2011-01-29 Gustavo Noronha Silva <gns@gnome.org>

[GTK] REGRESSION: http/tests/media/video-{cookie,referer}.html failing
https://bugs.webkit.org/show_bug.cgi?id=53379

Skip tests failing likely by the usage of a newer version of soup.

  • platform/gtk/Skipped:
12:47 Changeset [77068] by rniwa@webkit.org

2011-01-29 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed Chromium rebaselines.

  • platform/chromium-linux/fast/block/positioning/001-expected.checksum: Added.
  • platform/chromium-linux/fast/block/positioning/001-expected.png: Added.
  • platform/chromium-linux/svg/clip-path/clip-in-mask-objectBoundingBox-expected.checksum: Added.
  • platform/chromium-linux/svg/clip-path/clip-in-mask-objectBoundingBox-expected.png: Added.
  • platform/chromium-linux/svg/clip-path/clip-in-mask-userSpaceOnUse-expected.checksum: Added.
  • platform/chromium-linux/svg/clip-path/clip-in-mask-userSpaceOnUse-expected.png: Added.
  • platform/chromium-win/svg/clip-path/clip-in-mask-objectBoundingBox-expected.checksum: Added.
  • platform/chromium-win/svg/clip-path/clip-in-mask-objectBoundingBox-expected.png: Added.
  • platform/chromium-win/svg/clip-path/clip-in-mask-userSpaceOnUse-expected.checksum: Added.
  • platform/chromium-win/svg/clip-path/clip-in-mask-userSpaceOnUse-expected.png: Added.
  • platform/chromium-win/svg/custom/missing-xlink-expected.txt:
  • platform/chromium/test_expectations.txt:
12:31 Changeset [77067] by cwzwarich@webkit.org

Bug 53374 - Remove uses of unsafe string functions in debugging code
https://bugs.webkit.org/show_bug.cgi?id=53374

Reviewed by David Kilzer.

  • runtime/RegExp.cpp:

(JSC::RegExp::printTraceData):

12:27 Changeset [77066] by cwzwarich@webkit.org

Fix ChangeLog date.

12:18 Changeset [77065] by cwzwarich@webkit.org

JavaScriptCoreUseJIT environment variable broken
https://bugs.webkit.org/show_bug.cgi?id=53372

Reviewed by Oliver Hunt.

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData): Check the actual value in the string returned
by getenv() rather than just doing a NULL check on the return value.

11:43 Changeset [77064] by simon.fraser@apple.com

2011-01-28 Simon Fraser <simon.fraser@apple.com>

Reviewed by Adam Barth.

Use clampToInteger() functions in a few places
https://bugs.webkit.org/show_bug.cgi?id=53363

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): Use clampToInteger() for z-index. (WebCore::CSSStyleSelector::createTransformOperations): Use clampToPositiveInteger().
  • platform/graphics/transforms/PerspectiveTransformOperation.cpp: Ditto. (WebCore::PerspectiveTransformOperation::blend): Ditto.
10:50 Changeset [77063] by rniwa@webkit.org

2011-01-29 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed Chromium test expectation update; removed http/tests/appcache/online-whitelist.html
from the test expectation, because it has been passing on Chromium Windows.

  • platform/chromium/test_expectations.txt:
09:04 Changeset [77062] by paroga@webkit.org

2011-01-29 Patrick Gansterer <paroga@webkit.org>

Reviewed by David Kilzer.

Move CharacterNames.h into WTF directory
https://bugs.webkit.org/show_bug.cgi?id=49618

  • GNUmakefile.am:
  • JavaScriptCore.gypi:
  • JavaScriptCore.vcproj/WTF/WTF.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • wtf/CMakeLists.txt:
  • wtf/unicode/CharacterNames.h: Renamed from WebCore/platform/text/CharacterNames.h.
  • wtf/unicode/UTF8.cpp:

2011-01-29 Patrick Gansterer <paroga@webkit.org>

Reviewed by David Kilzer.

Move CharacterNames.h into WTF directory
https://bugs.webkit.org/show_bug.cgi?id=49618

  • ForwardingHeaders/wtf/unicode/CharacterNames.h: Added.
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • accessibility/AccessibilityObject.cpp:
  • accessibility/AccessibilityRenderObject.cpp:
  • bindings/cpp/WebDOMHTMLDocumentCustom.cpp:
  • bindings/js/JSHTMLDocumentCustom.cpp:
  • dom/Position.cpp:
  • dom/SelectElement.cpp:
  • editing/CompositeEditCommand.cpp:
  • editing/Editor.cpp:
  • editing/HTMLInterchange.cpp:
  • editing/InsertTextCommand.cpp:
  • editing/MarkupAccumulator.cpp:
  • editing/TextIterator.cpp:
  • editing/VisibleSelection.cpp:
  • editing/htmlediting.cpp:
  • editing/htmlediting.h:
  • editing/markup.cpp:
  • html/FTPDirectoryDocument.cpp:
  • html/HTMLFormControlElement.cpp:
  • html/parser/HTMLTreeBuilder.cpp:
  • loader/appcache/ManifestParser.cpp:
  • platform/chromium/PopupMenuChromium.cpp:
  • platform/graphics/Font.h:
  • platform/graphics/FontFastPath.cpp:
  • platform/graphics/GlyphPageTreeNode.cpp:
  • platform/graphics/StringTruncator.cpp:
  • platform/graphics/mac/ComplexTextController.cpp:
  • platform/graphics/mac/ComplexTextControllerATSUI.cpp:
  • platform/graphics/wince/GraphicsContextWinCE.cpp:
  • platform/mac/PasteboardMac.mm:
  • platform/text/TextCodecICU.cpp:
  • platform/text/mac/TextCodecMac.cpp:
  • platform/text/transcoder/FontTranscoder.cpp:
  • rendering/RenderBlockLineLayout.cpp:
  • rendering/RenderFlexibleBox.cpp:
  • rendering/RenderListMarker.cpp:
  • rendering/RenderText.cpp:
  • rendering/RenderTextControl.cpp:
  • rendering/RenderTreeAsText.cpp:
  • rendering/break_lines.cpp:
  • rendering/mathml/RenderMathMLOperator.h:
  • websockets/WebSocketHandshake.cpp:
  • wml/WMLTableElement.cpp:

2011-01-29 Patrick Gansterer <paroga@webkit.org>

Reviewed by David Kilzer.

Move CharacterNames.h into WTF directory
https://bugs.webkit.org/show_bug.cgi?id=49618

  • src/ChromeClientImpl.cpp:
03:39 Changeset [77061] by commit-queue@webkit.org

2011-01-29 Dan Winship <danw@gnome.org>

Reviewed by Xan Lopez.

[GTK] Require the latest glib and libsoup, and remove conditional
support for older versions
https://bugs.webkit.org/show_bug.cgi?id=50675

  • autotools/webkit.m4: use AM_PATH_GLIB_2_0 rather than doing basically the same work by hand
  • configure.ac:

2011-01-29 Dan Winship <danw@gnome.org>

Reviewed by Xan Lopez.

[GTK] Remove HAVE_LIBSOUP_2_29_90 conditionals; we depend on
libsoup 2.33.1 now.
https://bugs.webkit.org/show_bug.cgi?id=50675

  • platform/network/soup/CookieJarSoup.cpp: (WebCore::defaultCookieJar): (WebCore::setCookies):
  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandle::prepareForURL): (WebCore::restartedCallback): (WebCore::startHttp):
  • platform/network/soup/ResourceRequestSoup.cpp: (WebCore::ResourceRequest::updateSoupMessage): (WebCore::ResourceRequest::toSoupMessage): (WebCore::ResourceRequest::updateFromSoupMessage):

2011-01-29 Dan Winship <danw@gnome.org>

Reviewed by Xan Lopez.

[GTK] Remove HAVE_LIBSOUP_2_29_90 conditionals; we depend on
libsoup 2.33.1 now.
https://bugs.webkit.org/show_bug.cgi?id=50675

  • ewk/ewk_cookies.cpp: (ewk_cookies_file_set): (ewk_cookies_policy_set): (ewk_cookies_policy_get):

2011-01-29 Dan Winship <danw@gnome.org>

Reviewed by Xan Lopez.

[GTK] Remove HAVE_LIBSOUP_2_29_90 and HAVE_GSETTINGS conditionals;
we depend on glib 2.27.4 and libsoup 2.33.1 now.
https://bugs.webkit.org/show_bug.cgi?id=50675

  • GNUmakefile.am:
  • WebCoreSupport/InspectorClientGtk.cpp: (WebKit::InspectorClient::storeSetting):
  • webkit/webkitprivate.cpp: (inspectorGSettings):
  • webkit/webkitprivate.h:
01:22 Changeset [77060] by abarth@webkit.org

2011-01-29 Adam Barth <abarth@webkit.org>

Reviewed by Daniel Bates.

XSSFilter should replace URLs with about:blank instead of the empty string
https://bugs.webkit.org/show_bug.cgi?id=53370

Using the empty string will make the URL complete to the current
document's URL, which isn't really what we want. Instead, we want to
use about:blank, which is safe.

  • html/parser/XSSFilter.cpp: (WebCore::XSSFilter::filterObjectToken): (WebCore::XSSFilter::filterEmbedToken):
01:20 Changeset [77059] by abarth@webkit.org

2011-01-29 Adam Barth <abarth@webkit.org>

Reviewed by Daniel Bates.

XSSFilter should pass xssAuditor/script-tag-addslashes*
https://bugs.webkit.org/show_bug.cgi?id=53365

We need to canonicalize strings to avoid being tricked by addslashes.

  • html/parser/XSSFilter.cpp: (WebCore::HTMLNames::isNonCanonicalCharacter):
    • This function is copied from the XSSAuditor (with some tweaks). We'll eventually remove the XSSAuditor once we've got XSSFilter working properly.

(WebCore::HTMLNames::canonicalize):
(WebCore::HTMLNames::decodeURL):
(WebCore::XSSFilter::isContainedInRequest):

01:19 Changeset [77058] by abarth@webkit.org

2011-01-29 Adam Barth <abarth@webkit.org>

Reviewed by Daniel Bates.

XSSFilter should pass xssAuditor/script-tag-with-source-same-host.html
and xssAuditor/script-tag-post-*
https://bugs.webkit.org/show_bug.cgi?id=53364

We're supposed to allow loading same-origin resources even if they
appear as part of the request.

Also, we're supposed to look at the POST data too. :)

  • html/parser/XSSFilter.cpp: (WebCore::XSSFilter::eraseAttributeIfInjected): (WebCore::XSSFilter::isSameOriginResource):
    • Copy/paste from XSSAuditor::isSameOriginResource. We'll eventually remove the XSSAuditor version when XSSFilter is done.
  • html/parser/XSSFilter.h:
01:17 Changeset [77057] by abarth@webkit.org

2011-01-29 Adam Barth <abarth@webkit.org>

Reviewed by Daniel Bates.

XSSFilter should pass 16 of the xssAuditor/script-tag* tests
https://bugs.webkit.org/show_bug.cgi?id=53362

Turns out we need to replace the src attribute of script tags with
about:blank to avoid loading the main document URL as a script. Also,
move misplaced return statement that was triggering the console message
too often.

  • html/parser/HTMLToken.h: (WebCore::HTMLToken::appendToAttributeValue):
  • html/parser/XSSFilter.cpp: (WebCore::XSSFilter::filterScriptToken): (WebCore::XSSFilter::eraseAttributeIfInjected):
  • html/parser/XSSFilter.h:
01:11 Changeset [77056] by rniwa@webkit.org

2011-01-29 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed Chromium test expectation update.

  • platform/chromium/test_expectations.txt:
00:34 Changeset [77055] by jhoneycutt@apple.com

Downloads in WK2 on Windows should write resume data to bundle
https://bugs.webkit.org/show_bug.cgi?id=53282
<rdar://problem/8753077>

Reviewed by Alice Liu.

Source/WebCore:

  • WebCore.vcproj/WebCore.vcproj:

Added new files to project.

  • platform/network/cf/DownloadBundle.h: Added.
  • platform/network/win/DownloadBundleWin.cpp: Added.

(WebCore::DownloadBundle::magicNumber):
Moved from WebKit's WebDownload so that WebKit and WebKit2 can share
it.
(WebCore::DownloadBundle::fileExtension):
Ditto.
(WebCore::DownloadBundle::appendResumeData):
Ditto - but modified to return bool rather than HRESULT and to clean up
whitespace.
(WebCore::DownloadBundle::extractResumeData):
Ditto - modified to clean up whitespace.

Source/WebKit/win:

  • WebDownload.cpp:

(WebDownload::bundlePathForTargetPath):
Use the new WebCore::DownloadBundle function.
(WebDownload::request):

  • WebDownload.h:

Removed declarations for functions that were moved to a new location.

  • WebDownloadCFNet.cpp:

(WebDownload::initToResumeWithBundle):
Use the new WebCore::DownloadBundle function.
(WebDownload::cancelForResume):
Fix a leak of the resume data CFDataRef by using adoptCF(). Use the new
WebCore::DownloadBundle function.

Source/WebKit2:

  • WebProcess/Downloads/Download.cpp:

(WebKit::Download::decideDestinationWithSuggestedFilename):
Call didDecideDestination(), now that the destination is decided.

  • WebProcess/Downloads/Download.h:

Declare didDecideDestination(). Added member variables to hold the
destination file path and the download bundle path.
(WebKit::Download::destination):
Return the path to the final destination for this download.

  • WebProcess/Downloads/cf/DownloadCFNet.cpp:

(WebKit::Download::start):
Remove the name of an unused param.
(WebKit::Download::startWithHandle):
Ditto.
(WebKit::Download::cancel):
Tell CFNetwork not to delete the file upon failure, and tell it to
cancel the download. Copy the resume data for the download, and append
it to the download bundle. Call didCancel() with an empty
DataReference, since we have written our own resume data.
(WebKit::decideDestinationWithSuggestedObjectNameCallback):
Remove some unused param names. Removed the call to
CFURLDownloadSetDestination() - this is now handled in
Download::didDecideDestination().
(WebKit::didCreateDestinationCallback):
Report that the final destination was created, rather than the download
bundle, matching old WebKit.
(WebKit::Download::didDecideDestination):
Store the final destination and the download bundle paths, and call
CFURLDownloadSetDestination(), passing the path to the download bundle.

  • WebProcess/Downloads/curl/DownloadCurl.cpp:

(WebKit::Download::didDecideDestination):
Stubbed.

  • WebProcess/Downloads/mac/DownloadMac.mm:

(WebKit::Download::didDecideDestination):
Stubbed - unneeded on the Mac.

  • WebProcess/Downloads/qt/DownloadQt.cpp:

(WebKit::Download::didDecideDestination):
Stubbed.

00:27 Changeset [77054] by commit-queue@webkit.org

2011-01-29 Jeff Miller <jeffm@apple.com>

Reviewed by Anders Carlsson.

Support find bouncy in WebKit2 on Windows
https://bugs.webkit.org/show_bug.cgi?id=53329
<rdar://problem/8565843>
The Mac implements the find bouncy inside of WebKit in the UI process for WebKit2, but we need to do this inside Safari for WebKit2 on Windows.
Add infrastructure to call back into the app when the find indicator changes.

  • UIProcess/API/C/win/WKView.cpp: Cleanup some code style violations. (WKViewSetFindIndicatorCallback): Added. (WKViewGetFindIndicatorCallback): Added.
  • UIProcess/API/C/win/WKView.h: Cleanup some code style violations.
  • UIProcess/FindIndicator.cpp: (WebKit::FindIndicator::create): (WebKit::FindIndicator::FindIndicator): (WebKit::FindIndicator::frameRect): (WebKit::FindIndicator::draw): Rename m_selectionRect to m_selectionRectInWindowCoordinates and m_textRects to m_textRectsInSelectionRectCoordinates (along with similarly named local variables) to be more explict about the coordinate system.
  • UIProcess/FindIndicator.h: (WebKit::FindIndicator::selectionRectInWindowCoordinates): Added. (WebKit::FindIndicator::textRects): Rename m_textRects to m_textRectsInSelectionRectCoordinates.
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::setFindIndicator): Rename selectionRect to selectionRectInWindowCoordinates and textRects to textRectsInSelectionRectCoordinates to be more explict about the coordinate system.
  • UIProcess/WebPageProxy.h: Ditto.
  • UIProcess/win/WebView.cpp: (WebKit::WebView::WebView): (WebKit::WebView::setFindIndicator): Added. (WebKit::WebView::setFindIndicatorCallback): Added. (WebKit::WebView::getFindIndicatorCallback): Added.
  • UIProcess/win/WebView.h:
00:23 Changeset [77053] by rniwa@webkit.org

2011-01-29 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r77050.
http://trac.webkit.org/changeset/77050
https://bugs.webkit.org/show_bug.cgi?id=53371

Caused a crash in Chromium's test_shell_tests (Requested by
rniwa on #webkit).

  • resources/performance-test.js: Removed.
  • tiny-innerHTML.html: Removed.

2011-01-29 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r77050.
http://trac.webkit.org/changeset/77050
https://bugs.webkit.org/show_bug.cgi?id=53371

Caused a crash in Chromium's test_shell_tests (Requested by
rniwa on #webkit).

  • html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::FragmentParsingContext::FragmentParsingContext): (WebCore::HTMLTreeBuilder::FragmentParsingContext::document): (WebCore::HTMLTreeBuilder::FragmentParsingContext::finished):
  • html/parser/HTMLTreeBuilder.h:
00:13 Changeset [77052] by rniwa@webkit.org

2011-01-29 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed rebaselines and test expectation updates for Chromium Linux.

  • platform/chromium-linux/fast/forms/select-dirty-parent-pref-widths-expected.checksum: Added.
  • platform/chromium-linux/fast/forms/select-dirty-parent-pref-widths-expected.png: Added.
  • platform/chromium-linux/fast/forms/select-dirty-parent-pref-widths-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
Note: See TracTimeline for information about the timeline view.