Timeline


and

02/09/11:

23:13 Changeset [78176] by mrowe@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

<rdar://problem/8805364> Malloc zone enumeration code should be safe in the face of errors from the memory reader.

Reviewed by Sam Weinig.

  • wtf/FastMalloc.cpp:

(WTF::PageHeapAllocator::recordAdministrativeRegions): Use the new helper function to walk the linked list safely.
(WTF::TCMalloc_ThreadCache_FreeList::enumerateFreeObjects): Ditto.
(WTF::TCMalloc_Central_FreeList::enumerateFreeObjects): Ditto.
(WTF::TCMallocStats::PageMapFreeObjectFinder::visit): Bail out if the span could not be read.
(WTF::TCMallocStats::PageMapMemoryUsageRecorder::visit): Ditto.

  • wtf/MallocZoneSupport.h:

(WTF::RemoteMemoryReader::operator()): Remove an assert that is not valid.
(WTF::RemoteMemoryReader::nextEntryInLinkedList): Add a helper function for retrieving the next entry in
a linked list. It maps a failed read of the remote memory in to a null pointer, which all callers can
handle gracefully.

21:31 Changeset [78175] by hayato@chromium.org
  • 3 edits in trunk/Tools

2011-02-09 Hayato Ito <hayato@chromium.org>

Reviewed by Tony Chang.

[NRWT] Remove encoding parameters where we can assume data can be
written in binary mode.

https://bugs.webkit.org/show_bug.cgi?id=54066

  • Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
21:21 Changeset [78174] by barraclough@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Bug 54164 - Optimize global_var accesses on JSVALUE64

Reviewed by Sam Weinig.

Directly embed the pointer to d->registers, optimize out the load
from the variable object, as we do already in JSVALUE32_64.

This is a ~1.5% win on sunspidey.

  • jit/JIT.cpp:
  • jit/JIT.h:
  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_get_global_var):
(JSC::JIT::emit_op_put_global_var):
(JSC::JIT::emit_op_get_scoped_var):
(JSC::JIT::emit_op_put_scoped_var):

21:15 Changeset [78173] by simon.fraser@apple.com
  • 3 edits
    4 adds in trunk

2011-02-09 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

REGRESSION (r77101) box-shadow sometimes renders incorrectly
https://bugs.webkit.org/show_bug.cgi?id=54160

Fix an issue when ShadowBlur had a cached image buffer
that was larger than that of the current shadow being drawn,
and the current shadow was partially clipped out.

In that situation endShadowLayer() would clip to the image
buffer, using the size of the buffer (as it must), but failed
to take into account the fact that we'd only cleared and painted
into a smaller section of the buffer. So we need to additionally
constrain the clip to cover only the valid part of the buffer.

Test: fast/box-shadow/shadow-buffer-partial.html

  • platform/graphics/ShadowBlur.cpp: (WebCore::ShadowBlur::endShadowLayer):
19:37 Changeset [78172] by rniwa@webkit.org
  • 1 edit
    1 delete in trunk/LayoutTests

2011-02-09 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed; removed Windows port's expected result for r78104.

  • platform/win/editing/undo/undo-paste-when-caret-is-not-in-range-expected.txt: Removed.
19:07 Changeset [78171] by bdakin@apple.com
  • 2 edits in trunk/Source/WebCore

Fix for <rdar://problem/8977051> CrashTracer: 8 crashes
in WebProcess at com.apple.WebCore:
-[ScrollbarPartAnimation setCurrentProgress:] + 364

Reviewed by Maciej Stachowiak.

The ScrollbarPartAnimation must be sent by reference!

  • platform/mac/ScrollAnimatorMac.mm:

(-[ScrollbarPainterDelegate setUpAnimation:scrollerPainter:part:WebCore::animateAlphaTo:duration:]):

18:21 Changeset [78170] by ggaren@apple.com
  • 1 edit in trunk/Source/JavaScriptCore/ChangeLog

Fixed up ChangeLog after my last commit

18:20 Changeset [78169] by ggaren@apple.com
  • 7 edits in trunk/Source/JavaScriptCore

2011-02-09 Adam Barth <abarth@webkit.org>

Another attempt to fix the Qt Windows build.

  • config.h:
  • wtf/OSRandomSource.cpp: (WTF::randomValuesFromOS):
18:14 Changeset [78168] by rniwa@webkit.org
  • 5 edits
    2 adds in trunk

2011-02-09 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

REGRESSION(r76107): Crash in VisibleSelection::toNormalizedRange
https://bugs.webkit.org/show_bug.cgi?id=54053

The bug was caused by RenderBlock::positionForPoint's improperly returning a shadow node inside
RenderFileUploadControl for hit testing and VisibleSelection::toNormalizedRange's always assuming
the position variable "s" is not null.

Fixed the bug by always returning a null position from RenderFileUploadControl::positionForPoint,
and also exiting early when either "s" or "e" is null in VisibleSelection::toNormalizedRange.

Test: fast/forms/file-input-hit-test.html

  • editing/VisibleSelection.cpp: (WebCore::VisibleSelection::toNormalizedRange):
  • rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::positionForPoint):
  • rendering/RenderFileUploadControl.h:

2011-02-09 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

REGRESSION(r76107): Crash in VisibleSelection::toNormalizedRange
https://bugs.webkit.org/show_bug.cgi?id=54053

Added a test to ensure WebKit does not crash when a user clicks on a region immediately after a file
upload control.

  • fast/forms/file-input-hit-test-expected.txt: Added.
  • fast/forms/file-input-hit-test.html: Added.
17:55 Changeset [78167] by weinig@apple.com
  • 3 edits in trunk/Source/WebCore

Overlay scrollbars crash used with a RenderListBox.

Reviewed by Beth Dakin.

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::layout):
(WebCore::RenderListBox::contentsSize):
(WebCore::RenderListBox::currentMousePosition):
(WebCore::RenderListBox::setHasVerticalScrollbar):

  • rendering/RenderListBox.h:

Implement enough of the ScrollableArea interface to get things generally
working.

17:30 Changeset [78166] by tkent@chromium.org
  • 4 edits
    2 adds in branches/chromium/597

Merge r77114

2011-01-30 Kenichi Ishibashi <bashi@google.com>

Reviewed by Kent Tamura.

Dangling form associated elements should not be registered on the document
https://bugs.webkit.org/show_bug.cgi?id=53223

Adds insertedIntoDocument() and remvoedFromDocument() to
FormAssociatedElement class to register the element on the document
if and only if it actually inserted into (removed from) the document.

Test: fast/forms/dangling-form-element-crash.html

  • html/FormAssociatedElement.cpp: (WebCore::FormAssociatedElement::insertedIntoDocument): Added. (WebCore::FormAssociatedElement::removedFromDocument): Ditto. (WebCore::FormAssociatedElement::insertedIntoTree): Don't register the element to a document. (WebCore::FormAssociatedElement::removedFromTree): Don't unregister the element from a document.
  • html/FormAssociatedElement.h:
  • html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::insertedIntoDocument): Added. (WebCore::HTMLFormControlElement::removedFromDocument): Ditto.
  • html/HTMLFormControlElement.h:
  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::insertedIntoDocument): Calls FormAssociatedElement::insertedIntoDocument(). (WebCore::HTMLObjectElement::removedFromDocument): Calls FormAssociatedElement::removedFromDocument().

2011-01-30 Kenichi Ishibashi <bashi@google.com>

Reviewed by Kent Tamura.

Dangling form associated elements should not be registered on the document
https://bugs.webkit.org/show_bug.cgi?id=53223

Adds a test that ensures dangling form associated elements are not
registered on the document.

  • fast/forms/dangling-form-element-crash-expected.txt: Added.
  • fast/forms/dangling-form-element-crash.html: Added.

BUG=crbug.com/70078
TBR=inferno@chromium.org

17:28 Changeset [78165] by bweinstein@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix a typo in WebSecurityOrigin::protocol.

Rubber-stamped by Sam Weinig.

  • Shared/WebSecurityOrigin.h:

(WebKit::WebSecurityOrigin::protocol): This should return the protocol, not the domain.

17:26 Changeset [78164] by zmo@google.com
  • 2 edits in trunk/LayoutTests

2011-02-09 Zhenyao Mo <zmo@google.com>

Unreviewed, test expectations update.

  • platform/chromium/test_expectations.txt:
17:17 Changeset [78163] by weinig@apple.com
  • 5 edits in trunk/Source/WebKit2

File uploads do not work within the sandbox
<rdar://problem/8950518>
https://bugs.webkit.org/show_bug.cgi?id=54154

Reviewed by Darin Adler.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didChooseFilesForOpenPanel):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::extendSandboxForFileFromOpenPanel):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
16:28 Changeset [78162] by bdakin@apple.com
  • 8 edits in trunk/Source/WebCore

Fix for <rdar://problem/8966868> ScrollbarPainterDelegate
must return a layer if layer-backed to avoid crashing

Reviewed by Simon Fraser.

New virtual function scrollbarWillRenderIntoCompositingLayer()
on ScrollableArea.

  • page/FrameView.h:
  • platform/ScrollableArea.h:

(WebCore::ScrollableArea::scrollbarWillRenderIntoCompositingLayer):

  • rendering/RenderLayer.h:

(WebCore::RenderLayer::scrollbarWillRenderIntoCompositingLayer):

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::scrollbarWillRenderIntoCompositingLayer):

  • rendering/RenderListBox.h:

Clean up unnecessary method declarations and call
scrollbarWillRenderIntoCompositingLayer() to deterine if
we need to return a layer.

  • platform/mac/ScrollAnimatorMac.mm:

(-[ScrollbarPainterDelegate layer]):

16:24 Changeset [78161] by ap@apple.com
  • 3 edits in trunk/Source/WebKit2

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=54148
<rdar://problem/8973887> REGRESSION (WebKit2): Opening two print dialogs causes havoc

  • UIProcess/API/mac/WKPrintingView.h: Moved _isForcingPreviewUpdate into a static variable, because dispatching a notification affects all WKPrintingViews at once.
  • UIProcess/API/mac/WKPrintingView.mm: (-[WKPrintingView _updatePreview]): Updated for new variable name. (-[WKPrintingView knowsPageRange:]): Don't break if the method is called twice in a row (we already had this logic when printing from separate thread, but not for preview). (-[WKPrintingView drawRect:]): Changed all LOG messages to have view object address for easier matching. (-[WKPrintingView rectForPage:]): Ditto. (-[WKPrintingView beginDocument]): Ditto. (-[WKPrintingView endDocument]): Ditto.
16:24 Changeset [78160] by mrobinson@webkit.org
  • 5 edits in trunk/LayoutTests

2011-02-09 Martin Robinson <mrobinson@igalia.com>

Rebaseline a few tests which differ on the bots. Skip a test which is
timing out intermittently.

  • platform/gtk/Skipped: Skip a test timing out.
  • platform/gtk/fast/block/float/marquee-shrink-to-avoid-floats-expected.txt:
  • platform/gtk/fast/dom/52776-expected.txt:
  • platform/gtk/fast/text/stroking-decorations-expected.txt:
16:09 Changeset [78159] by dpranke@chromium.org
  • 3 edits in trunk/Tools

2011-02-09 Dirk Pranke <dpranke@chromium.org>

Reviewed by Tony Chang.

nrwt multiprocessing: minor cleanup prior to implementing the new worker

This patch renames AbstractManager to ManagerConnection and
changes some argument names to be more consistent between
manager_worker_broker and message_broker. It also fixes a couple
of typos in message_broker. These changes will be tested by code
introduced in the next patch.

https://bugs.webkit.org/show_bug.cgi?id=54067

  • Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
  • Scripts/webkitpy/layout_tests/layout_package/message_broker2.py:
15:53 Changeset [78158] by abarth@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

2011-02-09 Adam Barth <abarth@webkit.org>

Another attempt to fix the Qt Windows build.

  • config.h:
  • wtf/OSRandomSource.cpp: (WTF::randomValuesFromOS):
15:47 Changeset [78157] by andersca@apple.com
  • 7 edits
    3 adds in trunk

2011-02-09 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Repro crash with Sony Google TV ad at Gizmodo
https://bugs.webkit.org/show_bug.cgi?id=54150

Since PluginView::evaluate can cause the plug-in element to go away, we need to protect it.

  • WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::~PluginView): Null out m_pluginElement here so we'll catch crashes earlier.

(WebKit::PluginView::evaluate):
Add a plug-in protector.

2011-02-09 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Repro crash with Sony Google TV ad at Gizmodo
https://bugs.webkit.org/show_bug.cgi?id=54150
<rdar://problem/8782346>

Add test.

  • plugins/npruntime/evaluate-js-destroying-plugin-from-destroy-stream-expected.txt: Added.
  • plugins/npruntime/evaluate-js-destroying-plugin-from-destroy-stream.html: Added.

2011-02-09 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Repro crash with Sony Google TV ad at Gizmodo
https://bugs.webkit.org/show_bug.cgi?id=54150
<rdar://problem/8782346>

Add a new plug-in test that runs JavaScript that destroys the plug-in from within its NPN_DestroyStream callback.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/TestNetscapePlugIn/Tests/EvaluateJSDestroyingPluginFromDestroyStream.cpp: Added. (EvaluateJSDestroyingPluginFromDestroyStream::EvaluateJSDestroyingPluginFromDestroyStream): (EvaluateJSDestroyingPluginFromDestroyStream::NPP_Destroy): (EvaluateJSDestroyingPluginFromDestroyStream::NPP_DestroyStream):
  • DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
  • DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
15:35 Changeset [78156] by abarth@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-02-09 Adam Barth <abarth@webkit.org>

Attempt to fix the Qt Windows build.

  • wtf/OSRandomSource.cpp: (WTF::randomValuesFromOS):
15:33 Changeset [78155] by inferno@chromium.org
  • 5 edits
    2 copies in branches/chromium/648

Merge 77114

BUG=70078
Review URL: http://codereview.chromium.org/6476015

15:25 Changeset [78154] by mrobinson@webkit.org
  • 2 edits
    2 deletes in trunk/LayoutTests

2011-02-09 Martin Robinson <mrobinson@igalia.com>

Clean up the skipped list a bit and unskip a few tests which are passing.

  • platform/gtk/Skipped: Clean up the skipped list.
  • platform/gtk/editing/selection/extend-after-mouse-selection-expected.txt: Removed.
  • platform/gtk/fast/dom/Window/window-properties-expected.txt: Removed.
15:23 Changeset [78153] by inferno@chromium.org
  • 2 edits
    2 copies in branches/chromium/648

Merge 76732

BUG=70779
Review URL: http://codereview.chromium.org/6471009

15:17 Changeset [78152] by inferno@chromium.org
  • 3 edits
    2 adds in branches/chromium/597

Merge 77468, crbug 69640

15:14 Changeset [78151] by inferno@chromium.org
  • 1 edit
    2 copies in branches/chromium/648

Merge 77468

BUG=69640
Review URL: http://codereview.chromium.org/6483007

15:13 Changeset [78150] by yael.aharon@nokia.com
  • 31 edits in trunk/Source/WebCore

2011-02-09 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Darin Adler.

Replace static_cast<HTMLElement*> with toHTMLElement
https://bugs.webkit.org/show_bug.cgi?id=54117

No new tests since no new functionality was introduced.

  • accessibility/AccessibilityListBox.cpp: (WebCore::AccessibilityListBox::addChildren):
  • accessibility/AccessibilityMenuListPopup.cpp: (WebCore::AccessibilityMenuListPopup::addChildren):
  • accessibility/AccessibilityRenderObject.cpp: (WebCore::accessibleNameForNode): (WebCore::AccessibilityRenderObject::accessibilityDescription):
  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_get_name): (webkit_accessible_get_description):
  • bindings/gobject/WebKitDOMBinding.cpp: (WebKit::createWrapper): (WebKit::kit):
  • bindings/js/JSElementCustom.cpp: (WebCore::toJSNewlyCreated):
  • bindings/js/JSHTMLFrameSetElementCustom.cpp: (WebCore::JSHTMLFrameSetElement::nameGetter):
  • bindings/js/JSNodeCustom.cpp: (WebCore::createWrapperInline):
  • bindings/v8/custom/V8ElementCustom.cpp: (WebCore::toV8):
  • dom/Document.cpp: (WebCore::Document::body):
  • dom/Element.cpp: (WebCore::Element::deprecatedCreateContextualFragment):
  • dom/Range.cpp: (WebCore::Range::createContextualFragment):
  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyBlockStyle): (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange): (WebCore::ApplyStyleCommand::splitAncestorsWithUnicodeBidi): (WebCore::ApplyStyleCommand::applyInlineStyleToNodeRange): (WebCore::ApplyStyleCommand::removeStyleFromRunBeforeApplyingStyle): (WebCore::ApplyStyleCommand::highestAncestorWithConflictingInlineStyle): (WebCore::ApplyStyleCommand::applyInlineStyleToPushDown): (WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode): (WebCore::ApplyStyleCommand::removeInlineStyle): (WebCore::ApplyStyleCommand::shouldSplitTextElement): (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded):
  • editing/DeleteButtonController.cpp: (WebCore::enclosingDeletableElement): (WebCore::DeleteButtonController::show):
  • editing/Editor.cpp: (WebCore::Editor::setBaseWritingDirection):
  • editing/InsertListCommand.cpp: (WebCore::InsertListCommand::mergeWithNeighboringLists):
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::negateStyleRulesThatAffectAppearance): (WebCore::ReplaceSelectionCommand::handleStyleSpans): (WebCore::ReplaceSelectionCommand::copyStyleToChildren):
  • editing/SelectionController.cpp: (WebCore::scanForForm): (WebCore::SelectionController::currentForm):
  • editing/htmlediting.cpp: (WebCore::enclosingList): (WebCore::enclosingListChild): (WebCore::embeddedSublist): (WebCore::appendedSublist):
  • editing/markup.cpp: (WebCore::StyledMarkupAccumulator::appendElement):
  • html/HTMLCollection.cpp: (WebCore::HTMLCollection::checkForNameMatch): (WebCore::HTMLCollection::updateNameCache):
  • html/HTMLElement.cpp: (WebCore::HTMLElement::setOuterHTML): (WebCore::HTMLElement::shadowAncestorOwnerForm):
  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::formElementIndex):
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::setOption): (WebCore::HTMLSelectElement::setLength):
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::getOuterHTML): (WebCore::InspectorDOMAgent::setOuterHTML):
  • page/EventHandler.cpp: (WebCore::EventHandler::handleMouseMoveEvent):
  • rendering/RenderMeter.cpp: (WebCore::RenderMeter::createPart):
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::createSubtreeIfNeeded):
  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::createSubtreeIfNeeded):
15:11 Changeset [78149] by abarth@webkit.org
  • 10 edits
    4 adds in trunk/Source/JavaScriptCore

2011-02-09 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add WTF::cryptographicallyRandomNumber
https://bugs.webkit.org/show_bug.cgi?id=54083

Introduce a cryptographically strong random number generator to WTF.
The random number generator is based on arc4random as found in:

http://www.openbsd.org/cgi-bin/cvsweb/src/lib/libc/crypt/arc4random.c?rev=1.22

I've changed to source to WebKit style and abstracted the operating
system interaction to OSRandomSource. We'll use this functionality to
expose a cryptographically strong random number generator to
JavaScript.

  • Android.mk:
  • Android.v8.wtf.mk:
  • GNUmakefile.am:
  • JavaScriptCore.gypi:
  • JavaScriptCore.vcproj/WTF/WTF.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • config.h:
  • wtf/CMakeLists.txt:
  • wtf/CryptographicallyRandomNumber.cpp: Added. (WTF::initMutexIfNeeded): (WTF::init): (WTF::addRandomData): (WTF::stir): (WTF::stirIfNeeded): (WTF::getByte): (WTF::getWord): (WTF::cryptographicallyRandomNumber): (WTF::cryptographicallyRandomValues):
  • wtf/CryptographicallyRandomNumber.h: Added.
  • wtf/OSRandomSource.cpp: Added. (WTF::randomValuesFromOS):
  • wtf/OSRandomSource.h: Added.
  • wtf/wtf.pri:
15:10 Changeset [78148] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-09 Mike Reed <reed@google.com>

Reviewed by Kenneth Russell.

Use Skia's device->readPixels() when its bitmap claims to have no pixels, as this
handles the case when the device is backed by the GPU.
Patch developed by bsalomon@google.com

No new tests. Existing canvas tests suffice
e.g. LayoutTests/canvas/philip/...

  • platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::getImageData): (WebCore::ImageBuffer::getUnmultipliedImageData): (WebCore::ImageBuffer::getPremultipliedImageData): (WebCore::putImageData): (WebCore::ImageBuffer::putUnmultipliedImageData): (WebCore::ImageBuffer::putPremultipliedImageData):
15:07 Changeset [78147] by abarth@webkit.org
  • 8 edits
    10 adds in trunk

2011-02-09 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

document.close shouldn't affect non-script-created parsers
https://bugs.webkit.org/show_bug.cgi?id=53689

Tests for various cases involving document.open/write/close. Not all
of them are related to this patch, but they were helpful to me in
working through this patch, so I've added them in case they're useful
in the future.

  • fast/frames/document-write-in-iframe-onload-3-expected.txt: Added.
  • fast/frames/document-write-in-iframe-onload-3.html: Added.
  • fast/parser/iframe-onload-document-close-with-external-script-2-expected.txt: Added.
  • fast/parser/iframe-onload-document-close-with-external-script-2.html: Added.
  • fast/parser/iframe-onload-document-close-with-external-script-3-expected.txt: Added.
  • fast/parser/iframe-onload-document-close-with-external-script-3.html: Added.
  • fast/parser/iframe-onload-document-close-with-external-script-expected.txt: Added.
  • fast/parser/iframe-onload-document-close-with-external-script.html: Added.
  • fast/parser/setTimeout-open-expected.txt: Added.
  • fast/parser/setTimeout-open.html: Added.

2011-02-09 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

document.close shouldn't affect non-script-created parsers
https://bugs.webkit.org/show_bug.cgi?id=53689

Tests: fast/frames/document-write-in-iframe-onload-3.html

fast/parser/iframe-onload-document-close-with-external-script-2.html
fast/parser/iframe-onload-document-close-with-external-script-3.html
fast/parser/iframe-onload-document-close-with-external-script.html
fast/parser/setTimeout-open.html

Move our implementation of document.close closer to the spec by
introducing the notion of a script-created parser. This area of our
code is somewhat hairy. It might take a few more iterations before we
fully come up to spec.

  • dom/Document.cpp: (WebCore::Document::setContent): (WebCore::Document::open): (WebCore::Document::cancelParsing): (WebCore::Document::close):
    • Over time, this method should converge to the spec.

(WebCore::Document::explicitClose):

  • I'm not in love with this name. Somehow we want to differentiate between Document closing itself and the document.close DOM method.

(WebCore::Document::removePendingSheet):

  • dom/Document.h:
  • dom/ScriptableDocumentParser.cpp: (WebCore::ScriptableDocumentParser::ScriptableDocumentParser):
  • dom/ScriptableDocumentParser.h: (WebCore::ScriptableDocumentParser::setWasCreatedByScript): (WebCore::ScriptableDocumentParser::wasCreatedByScript):
    • General nonsense to keep track of whether the parser was created by script.
  • html/parser/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::hasInsertionPoint):
    • I'm not sure whether this part of the change is 100% correct. I think our notion of the EOF character might be subtly different from the notion in the spec.
  • html/parser/HTMLInputStream.h: (WebCore::HTMLInputStream::hasInsertionPoint):
    • Remove FIXME because we're fixing that!
15:03 Changeset [78146] by mrobinson@webkit.org
  • 2 edits
    339 adds in trunk/LayoutTests

2011-02-09 Martin Robinson <mrobinson@igalia.com>

Import the last set of GTK+ baselines in the fast directory.

  • platform/gtk/Skipped: Unskip test which now have results.
15:02 Changeset [78145] by weinig@apple.com
  • 3 edits in trunk/Source/WebKit2

Google Maps says it has horizontal scrollbars when it doesn't
<rdar://problem/8978005>

Reviewed by Maciej Stachowiak.

We were updating the main frame's scrollbar state for changes to
frames other than the main frame.

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::contentsSizeChanged):

  • WebProcess/WebCoreSupport/WebChromeClient.h:

(WebKit::WebChromeClient::WebChromeClient):
Change to bail out early if we are not looking at the main frame. Also
fix some silly typos and rename the variables to be more specific.

14:53 Changeset [78144] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/chromium

2011-02-09 David Holloway <dhollowa@chromium.org>

Reviewed by Darin Fisher.

Removes deprecated interface WebAutoFillClient::didAcceptAutocompleteSuggestion(). This interface has been replaced by the more general WebAutoFillClient::didAcceptAutoFillSuggestion() method.
https://bugs.webkit.org/show_bug.cgi?id=54125

  • public/WebAutoFillClient.h:
  • src/EditorClientImpl.cpp:
  • src/EditorClientImpl.h:
14:41 Changeset [78143] by inferno@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-02-09 Abhishek Arya <inferno@chromium.org>

Reviewed by James Robinson.

[Chromium] Issue 72387: Integer bounds crash in LayerTilerChromium::resizeLayer
https://bugs.webkit.org/show_bug.cgi?id=54132


  • platform/graphics/chromium/LayerTilerChromium.cpp: (WebCore::LayerTilerChromium::resizeLayer):
14:40 Changeset [78142] by mrobinson@webkit.org
  • 2 edits
    996 adds in trunk/LayoutTests

2011-02-09 Martin Robinson <mrobinson@igalia.com>

Continue importing new GTK+ results for tests in the fast directory.

  • platform/gtk/Skipped: Unskip test which now have results.
14:39 Changeset [78141] by inferno@chromium.org
  • 1 edit
    2 copies in branches/chromium/648

Merge 77914

BUG=70442
Review URL: http://codereview.chromium.org/6480008

14:37 Changeset [78140] by inferno@chromium.org
  • 4 edits
    2 copies in branches/chromium/648

Merge 76652

BUG=70442
Review URL: http://codereview.chromium.org/6482007

14:36 Changeset [78139] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

2011-02-09 Ilya Sherman <isherman@chromium.org>

Reviewed by Darin Fisher.

Export WebInputElement::defaultMaxLength as a function rather than a constant.
Needed because the order of initialization of static constants
is not guaranteed across compilation units.
https://bugs.webkit.org/show_bug.cgi?id=54056

  • public/WebInputElement.h:
  • src/WebInputElement.cpp: (WebKit::WebInputElement::defaultMaxLength): Now a static function.
14:25 Changeset [78138] by ossy@webkit.org
  • 1 edit
    3 deletes in trunk/LayoutTests

Unreviewed.

Remove unnecessary Qt specific expected results after r78104.

  • platform/qt/editing/undo/undo-paste-when-caret-is-not-in-range-expected.checksum: Removed.
  • platform/qt/editing/undo/undo-paste-when-caret-is-not-in-range-expected.png: Removed.
  • platform/qt/editing/undo/undo-paste-when-caret-is-not-in-range-expected.txt: Removed.
14:23 Changeset [78137] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-09 Xiyuan Xia <xiyuan@chromium.org>

Reviewed by Tony Chang.

[Chromium] Use #f7f7f7 for select popup background on chromium/linux
https://bugs.webkit.org/show_bug.cgi?id=54115

No new tests since no behavior change.

  • css/themeChromiumLinux.css: (select[size="1"] option):
14:18 Changeset [78136] by inferno@chromium.org
  • 3 edits
    2 adds in branches/chromium/597

Merge r77548, crbug 71296

14:16 Changeset [78135] by robert@webkit.org
  • 3 edits in trunk/Source/WebKit/qt

2011-02-09 Robert Hogan <robert@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt] REGRESSION (r73535): tst_QWebPage fails
https://bugs.webkit.org/show_bug.cgi?id=51331

Since r73535 a ContextMenu is only created when a context menu
event is received, so QWebPage::updatePositionDependentActions()
can't depend on one being there if it is called directly by
the client. QtWebKit itself only ever calls updatePositionDependentActions()
when a context menu event has been received.

Update tst_QWebPage:contextMenuCrash to create a context menu.
Add tst_QWebPage:updatePositionDependentActionsCrash to test for this crash.

There doesn't seem to be a good reason for creating a context menu if
clients call QWebPage::updatePositionDependentActions() when no
context menu event has ever been received.

  • Api/qwebpage.cpp: (QWebPagePrivate::createContextMenu):
  • tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::contextMenuCrash):
14:16 Changeset [78134] by inferno@chromium.org
  • 1 edit
    2 copies in branches/chromium/648

Merge 77548

BUG=71296
Review URL: http://codereview.chromium.org/6483004

14:13 Changeset [78133] by inferno@chromium.org
  • 3 edits
    2 adds in branches/chromium/597

Merge r77565, r77573, crbug 71855

14:13 Changeset [78132] by zmo@google.com
  • 2 edits
    1 delete in trunk/LayoutTests

2011-02-09 Zhenyao Mo <zmo@google.com>

Unreviewed, test expectations update.

  • platform/chromium-win/editing/undo/undo-paste-when-caret-is-not-in-range-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
14:10 Changeset [78131] by inferno@chromium.org
  • 1 edit in branches/chromium/648/Source/WebCore/rendering/RenderBlock.cpp

Merge 77573

BUG=71855
Review URL: http://codereview.chromium.org/6482006

14:09 Changeset [78130] by inferno@chromium.org
  • 1 edit
    2 copies in branches/chromium/648

Merge 77565

BUG=71855
Review URL: http://codereview.chromium.org/6480006

14:04 Changeset [78129] by zmo@google.com
  • 2 edits
    1 add in trunk/LayoutTests

2011-02-09 Zhenyao Mo <zmo@google.com>

Unreviewed, rebaseline.

  • platform/chromium-win/editing/undo/undo-paste-when-caret-is-not-in-range-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
14:02 Changeset [78128] by mrobinson@webkit.org
  • 2 edits
    876 adds in trunk/LayoutTests

2011-02-09 Martin Robinson <mrobinson@igalia.com>

Continue importing new GTK+ results for tests in the fast directory.

  • platform/gtk/Skipped: Unskip test which now have results.
13:53 Changeset [78127] by abarth@webkit.org
  • 4 edits in trunk/Source/WebCore

2011-02-09 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

REGRESSION(HTML 5): HTMLDocumentParser does not report html parse errors to the console
https://bugs.webkit.org/show_bug.cgi?id=41187

Wire up a basic HTML parse error message. There's a lot of room for
improvement in this area, but this is a start.

No tests! See https://bugs.webkit.org/show_bug.cgi?id=54134

  • html/parser/HTMLDocumentParser.h:
  • html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::parseError):
  • html/parser/HTMLTreeBuilder.h:
13:36 Changeset [78126] by ike@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-02-09 Ivan Krstić <ike@apple.com>

Reviewed by Sam Weinig.

Allow read-only access to mouse preferences from sandboxed WebProcess.
<rdar://problem/8975279>

  • WebProcess/com.apple.WebProcess.sb:
13:36 Changeset [78125] by inferno@chromium.org
  • 1 edit
    2 copies in branches/chromium/648

Merge 77141

BUG=71114
Review URL: http://codereview.chromium.org/6478004

13:23 Changeset [78124] by zmo@google.com
  • 2 edits in trunk/LayoutTests

2011-02-09 Zhenyao Mo <zmo@google.com>

Unreviewed, test expectations update.

  • platform/chromium/test_expectations.txt:
13:17 Changeset [78123] by inferno@chromium.org
  • 1 edit
    2 copies in branches/chromium/648

Merge 77262

BUG=71386
Review URL: http://codereview.chromium.org/6476009

13:15 Changeset [78122] by mrobinson@webkit.org
  • 2 edits
    595 adds in trunk/LayoutTests

2011-02-09 Martin Robinson <mrobinson@igalia.com>

Continue importing new GTK+ results for tests in the fast directory.
Skip some tests that are obvious failures.

  • platform/gtk/Skipped: Unskip test with results. Classify failures.
13:15 Changeset [78121] by inferno@chromium.org
  • 1 edit
    2 copies in branches/chromium/648

Merge 77144

BUG=71388
Review URL: http://codereview.chromium.org/6480004

13:09 Changeset [78120] by inferno@chromium.org
  • 3 edits in branches/chromium/648

Merge 77433

BUG=71734
Review URL: http://codereview.chromium.org/6469012

13:06 Changeset [78119] by sfalken@apple.com
  • 3 edits in tags/Safari-534.18.1/Source/WebKit2

Merge r78116.

13:05 Changeset [78118] by inferno@chromium.org
  • 4 edits
    2 copies in branches/chromium/648

Merge 77418

BUG=71595
Review URL: http://codereview.chromium.org/6476007

13:02 Changeset [78117] by inferno@chromium.org
  • 4 edits
    2 copies in branches/chromium/648

Merge 76990

BUG=68120
Review URL: http://codereview.chromium.org/6469011

12:59 Changeset [78116] by sfalken@apple.com
  • 2 edits in trunk/Source/WebKit2

Build fix.

  • win/MainWin.cpp:

(wWinMain):

12:59 Changeset [78115] by inferno@chromium.org
  • 1 edit
    2 copies in branches/chromium/648

Merge 76708

BUG=67234
Review URL: http://codereview.chromium.org/6483002

12:57 Changeset [78114] by dglazkov@chromium.org
  • 5 edits in branches/chromium/648

Merge 78077 - 2011-02-08 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Darin Adler.

REGRESSION(r71934): Shadow DOM nodes leak via relatedTarget
https://bugs.webkit.org/show_bug.cgi?id=52065

  • fast/events/shadow-boundary-crossing.html: Added relatedTarget retargeting test.

2011-02-08 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Darin Adler.

REGRESSION(r71934): Shadow DOM nodes leak via relatedTarget
https://bugs.webkit.org/show_bug.cgi?id=52065

  • dom/Node.cpp: (WebCore::pullOutOfShadow): Added a helper to move a node to the outermost

boundary of shadow DOM.

(WebCore::Node::dispatchMouseEvent): Changed to use pullOutOfShadow.

TBR=dglazkov@chromium.org
Review URL: http://codereview.chromium.org/6469009

12:56 Changeset [78113] by inferno@chromium.org
  • 1 edit
    3 copies in branches/chromium/648

Merge 76915

BUG=71115
Review URL: http://codereview.chromium.org/6471003

12:52 Changeset [78112] by inferno@chromium.org
  • 2 edits
    2 copies in branches/chromium/648

Merge 76828

BUG=68741
Review URL: http://codereview.chromium.org/6469008

12:50 Changeset [78111] by zmo@google.com
  • 2 edits
    5 adds in trunk/LayoutTests

2011-02-09 Zhenyao Mo <zmo@google.com>

Unreviewed, rebaseline.

  • platform/chromium-linux/fast/box-shadow/inset-box-shadows-expected.checksum: Added.
  • platform/chromium-linux/fast/box-shadow/inset-box-shadows-expected.png: Added.
  • platform/chromium-win/fast/box-shadow/inset-box-shadows-expected.checksum: Added.
  • platform/chromium-win/fast/box-shadow/inset-box-shadows-expected.png: Added.
  • platform/chromium-win/fast/box-shadow/inset-box-shadows-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
12:50 Changeset [78110] by inferno@chromium.org
  • 6 edits
    2 copies in branches/chromium/648

Merge 76728

BUG=68263
Review URL: http://codereview.chromium.org/6483001

12:46 Changeset [78109] by inferno@chromium.org
  • 1 edit in branches/chromium/648/Source/WebCore/svg/SVGFont.cpp

Merge 77766

BUG=72134
Review URL: http://codereview.chromium.org/6471002

12:22 Changeset [78108] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Try to fix the build.

  • wtf/Bitmap.h: Include string.h for memset. Not sure why this started

failing now.

12:15 Changeset [78107] by abarth@webkit.org
  • 1 edit
    1 move in trunk

2011-02-09 Adam Barth <abarth@webkit.org>

Reviewed by Steve Block.

Move Android.mk into Source
https://bugs.webkit.org/show_bug.cgi?id=53751

A somewhat blind attempt to move Android.mk into the Source directory.
I'm sure I've goofed this up in some way. The Android folks have
kindly volunteered to fix this up once they merge past this revision.

  • Android.mk: Removed.
  • Source/Android.mk: Copied from Android.mk.
12:15 Changeset [78106] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/chromium

2011-02-09 Sailesh Agrawal <sail@chromium.org>

Reviewed by Tony Chang.

Search/replace references to gfx/* with ui/gfx/*

  • public/WebPoint.h:
  • public/WebRect.h:
  • public/WebSize.h:
12:09 Changeset [78105] by ggaren@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

2011-02-09 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

A tiny bit of encapsulation for MarkedBlock: made its heap data member private
https://bugs.webkit.org/show_bug.cgi?id=54129

  • runtime/MarkedBlock.h: (JSC::MarkedBlock::isCellAligned): (JSC::MarkedBlock::MarkedBlock): (JSC::MarkedBlock::heap): Made the heap data member private, and provided a constructor and an accessor.
  • runtime/MarkedSpace.cpp: (JSC::MarkedSpace::allocateBlock):
  • runtime/MarkedSpace.h: (JSC::MarkedSpace::heap): Use the constructor and accessor.
12:08 Changeset [78104] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

2011-02-09 Jia Pu <jpu@apple.com>

Reviewed by Darin Adler.

VisibleSelection::setWithoutValidation() should allow caret selection.
https://bugs.webkit.org/show_bug.cgi?id=53943

Fixed the new test introduced in the previous patch for the same bug. Previous test isn't platform independent, and fails on all platforms other than Mac OS X with WebKit 1.

  • editing/undo/undo-paste-when-caret-is-not-in-range-expected.txt:
  • editing/undo/undo-paste-when-caret-is-not-in-range.html:
12:06 Changeset [78103] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-09 Naoki Takano <takano.naoki@gmail.com>

Reviewed by Kenneth Russell.

[Chromium] Issue 58536: Fix Layout Test canvas/philip/tests/2d.imageData.put.alpha.html with --accelerated-2d-canvas.
https://bugs.webkit.org/show_bug.cgi?id=53757

This fix is for 2d.imageData.put.alpha.html with --accelerated-2d-canvas. No new tests.

  • platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::ImageBuffer::putUnmultipliedImageData): needs to call syncSoftwareCanvas() to sync between hardware and software. (WebCore::ImageBuffer::putPremultipliedImageData): needs to call syncSoftwareCanvas() to sync between hardware and software.
12:03 Changeset [78102] by crogers@google.com
  • 6 edits in trunk/Source/WebCore

2011-02-09 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

Fix scaling and thread safety of FFTFrameFFTW
https://bugs.webkit.org/show_bug.cgi?id=54045

No new tests since audio API is not yet implemented.

  • platform/audio/FFTFrame.h:
  • platform/audio/fftw/FFTFrameFFTW.cpp: (WebCore::FFTFrame::FFTFrame): (WebCore::FFTFrame::doFFT): (WebCore::FFTFrame::doInverseFFT): (WebCore::FFTFrame::initialize): (WebCore::FFTFrame::cleanup): (WebCore::FFTFrame::realData): (WebCore::FFTFrame::imagData): (WebCore::FFTFrame::fftwPlanForSize):
  • platform/audio/mac/FFTFrameMac.cpp: (WebCore::FFTFrame::initialize):
  • platform/audio/mkl/FFTFrameMKL.cpp: (WebCore::FFTFrame::initialize):
  • webaudio/AudioContext.cpp: (WebCore::AudioContext::AudioContext):
11:57 Changeset [78101] by inferno@chromium.org
  • 8 edits
    2 adds in branches/chromium/597

Merge r76728, crbug 68263

11:54 Changeset [78100] by levin@chromium.org
  • 3 edits in trunk/Tools

2011-02-09 David Levin <levin@chromium.org>

Reviewed by Eric Seidel.

check-webkit-style: The error message about NULL should be more clear for comments.
https://bugs.webkit.org/show_bug.cgi?id=53786

  • Scripts/webkitpy/style/checkers/cpp.py: Clarified the error message.
  • Scripts/webkitpy/style/checkers/cpp_unittest.py: Fixed the corresponding test.
11:52 Changeset [78099] by inferno@chromium.org
  • 3 edits
    2 adds in branches/chromium/597

Merge 77141, crbug 71114

11:49 Changeset [78098] by cfleizach@apple.com
  • 3 edits in trunk/Source/WebCore

AX: accessibilityShouldUseUniqueId doesn't need to be in the core AX object
https://bugs.webkit.org/show_bug.cgi?id=54126

Reviewed by Darin Adler.

This is a Mac-only accessibility API concept and doesn't belong in the core AX object.

  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::node):

  • accessibility/mac/AccessibilityObjectWrapper.mm:

(-[AccessibilityObjectWrapper accessibilityShouldUseUniqueId]):

11:48 Changeset [78097] by mrobinson@webkit.org
  • 2 edits
    589 adds in trunk/LayoutTests

2011-02-09 Martin Robinson <mrobinson@igalia.com>

Continue importing new GTK+ results for tests in the fast directory.
Skip some tests that are obvious failures.

  • platform/gtk/Skipped: Unskip some tests that now have results.
11:46 Changeset [78096] by inferno@chromium.org
  • 3 edits
    2 adds in branches/chromium/597

Merge r77262, crbug 71386

11:43 Changeset [78095] by commit-queue@webkit.org
  • 16 edits
    3 adds in trunk

2011-02-09 Nebojsa Ciric <cira@chromium.org>

Reviewed by Darin Fisher.

Implements Locale object of JavaScript internationalization API proposal, as an
v8 extension. Extension code is hosted in v8 project (src/extensions/experimental/i18n-extension.{cc,h})
and in this patch we just provide flags, tests and build rules for chromium port.
https://bugs.webkit.org/show_bug.cgi?id=49414

  • fast/js/i18n-bindings-locale-expected.txt: Added.
  • fast/js/i18n-bindings-locale.html: Added.
  • fast/js/script-tests/i18n-bindings-locale.js: Added. (reportResult): (localeTests.this.defaultLocale): (localeTests.this.baseLocale): (localeTests.this.languageScriptLocale): (localeTests.this.languageScriptRegionLocale): (localeTests.this.languageScriptRegionExtensionLocale): (localeTests.this.languageScriptRegionDashUExtensionLocale): (localeTests.this.availableLocales): (localeTests.this.maximizedLocale): (localeTests.this.maximizedLocaleWithExtension): (localeTests.this.minimizedLocale): (localeTests.this.minimizedLocaleWithExtension): (localeTests.this.displayForBaseLocale): (localeTests.this.displayInSameLocale): (localeTests.this.displayInDifferentLocale): (localeTests.this.displayInCyrillicScript): (localeTests.this.displayInHebrewScript): (localeTests):
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:

2011-02-09 Nebojsa Ciric <cira@chromium.org>

Reviewed by Darin Fisher.

Implements Locale object of JavaScript internationalization API proposal, as an
v8 extension. Extension code is hosted in v8 project (src/extensions/experimental/i18n-extension.{cc,h})
and in this patch we just provide flags, tests and build rules for chromium port.
https://bugs.webkit.org/show_bug.cgi?id=49414

Test: fast/js/i18n-bindings-locale.html

  • WebCore.gyp/WebCore.gyp:
  • bindings/generic/RuntimeEnabledFeatures.cpp: (WebCore::RuntimeEnabledFeatures::experimentalI18NAPIEnabled):
  • bindings/generic/RuntimeEnabledFeatures.h: (WebCore::RuntimeEnabledFeatures::setExperimentalI18NAPIEnabled):
  • bindings/v8/V8DOMWindowShell.cpp: (WebCore::V8DOMWindowShell::createNewContext):

2011-02-09 Nebojsa Ciric <cira@chromium.org>

Reviewed by Darin Fisher.

Implements Locale object of JavaScript internationalization API proposal, as an
v8 extension. Extension code is hosted in v8 project (src/extensions/experimental/i18n-extension.{cc,h})
and in this patch we just provide flags, tests and build rules for chromium port.
https://bugs.webkit.org/show_bug.cgi?id=49414

  • features.gypi:
  • public/WebRuntimeFeatures.h:
  • src/WebRuntimeFeatures.cpp: (WebKit::WebRuntimeFeatures::enableExperimentalI18NAPI): (WebKit::WebRuntimeFeatures::isExperimentalI18NAPIEnabled):

2011-02-09 Nebojsa Ciric <cira@chromium.org>

Reviewed by Darin Fisher.

Implements Locale object of JavaScript internationalization API proposal, as an
v8 extension. Extension code is hosted in v8 project (src/extensions/experimental/i18n-extension.{cc,h})
and in this patch we just provide flags, tests and build rules for chromium port.
https://bugs.webkit.org/show_bug.cgi?id=49414

  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::TestShell):
11:42 Changeset [78094] by inferno@chromium.org
  • 3 edits
    2 adds in branches/chromium/597

Merge r77144, crbug 71388

11:38 Changeset [78093] by inferno@chromium.org
  • 5 edits in branches/chromium/597

Merge r77433, crbug 71734

11:35 Changeset [78092] by zmo@google.com
  • 2 edits in trunk/LayoutTests

2011-02-09 Zhenyao Mo <zmo@google.com>

Unreviewed, fix a bug in test_expectations.txt.

  • platform/chromium/test_expectations.txt:
11:32 Changeset [78091] by inferno@chromium.org
  • 2 edits in branches/chromium/597/WebCore

Merge r77766, crbug 72134

11:27 Changeset [78090] by inferno@chromium.org
  • 6 edits
    2 adds in branches/chromium/597

Merge r77418, crbug 71595

11:23 Changeset [78089] by xji@chromium.org
  • 2 edits
    1 add in trunk/LayoutTests

2011-02-09 Xiaomei Ji <xji@chromium.org>

Unreviewed.

Rebaseline for chromium-mac after r77952.
Added chromium-mac baseline due to fallback sequence.

  • platform/chromium-mac/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
11:19 Changeset [78088] by zmo@google.com
  • 2 edits in trunk/LayoutTests

2011-02-09 Zhenyao Mo <zmo@google.com>

Unreviewed, test expectations update.

  • platform/chromium/test_expectations.txt:
11:15 Changeset [78087] by inferno@chromium.org
  • 3 edits
    2 adds in branches/chromium/597

Merge r76915, crbug 71115

11:09 Changeset [78086] by inferno@chromium.org
  • 2 adds in branches/chromium/597/LayoutTests/fast/css

Merge r76828, bug 68741, layouttests

11:06 Changeset [78085] by yael.aharon@nokia.com
  • 3 edits
    1 delete in trunk/LayoutTests

2011-02-09 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Martin Robinson.

frames/flattening/iframe-flattening-crash.html fails on GTK.
https://bugs.webkit.org/show_bug.cgi?id=54106

Modify the test to be more consistent with other frame flattening tests.

  • fast/frames/flattening/iframe-flattening-crash.html:
  • fast/frames/flattening/resources/iframe-flattening-crash.html: Removed.
  • platform/gtk/Skipped:
11:05 Changeset [78084] by inferno@chromium.org
  • 4 edits in branches/chromium/597

Merge r76828, bug 68741

10:54 Changeset [78083] by sfalken@apple.com
  • 2 edits in tags/Safari-534.18.1/Source/WebCore

Merge r78045.

10:50 Changeset [78082] by bweinstein@apple.com
  • 1 edit
    3 adds in trunk/LayoutTests

Add failing Windows expected results for tests that were added recently and have failed since
they were added.

https://bugs.webkit.org/show_bug.cgi?id=54120 tracks editing/undo/undo-paste-when-caret-is-not-in-range.html
https://bugs.webkit.org/show_bug.cgi?id=54122 tracks plugins/invalidate_rect.html

  • platform/win/editing/undo: Added.
  • platform/win/editing/undo/undo-paste-when-caret-is-not-in-range-expected.txt: Added.
  • platform/win/plugins/invalidate_rect-expected.txt: Added.
10:48 Changeset [78081] by sfalken@apple.com
  • 5 edits in tags/Safari-534.18.1/Source

Versioning.

10:41 Changeset [78080] by zmo@google.com
  • 2 edits in trunk/LayoutTests

2011-02-09 Zhenyao Mo <zmo@google.com>

Unreviewed, test expectations.

  • platform/chromium/test_expectations.txt:
10:38 Changeset [78079] by mrobinson@webkit.org
  • 3 edits
    445 adds in trunk

2011-02-09 Martin Robinson <mrobinson@igalia.com>

Add more results for many tests in the fast directory missing results.

  • platform/gtk/Skipped: Unskip more tests.
10:04 Changeset [78078] by sfalken@apple.com
  • 1 copy in tags/Safari-534.18.1

New tag.

10:03 Changeset [78077] by dglazkov@chromium.org
  • 5 edits in trunk

2011-02-08 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Darin Adler.

REGRESSION(r71934): Shadow DOM nodes leak via relatedTarget
https://bugs.webkit.org/show_bug.cgi?id=52065

  • fast/events/shadow-boundary-crossing.html: Added relatedTarget retargeting test.

2011-02-08 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Darin Adler.

REGRESSION(r71934): Shadow DOM nodes leak via relatedTarget
https://bugs.webkit.org/show_bug.cgi?id=52065

  • dom/Node.cpp: (WebCore::pullOutOfShadow): Added a helper to move a node to the outermost

boundary of shadow DOM.

(WebCore::Node::dispatchMouseEvent): Changed to use pullOutOfShadow.

10:03 Changeset [78076] by mrobinson@webkit.org
  • 2 edits
    448 adds in trunk/LayoutTests

2011-02-09 Martin Robinson <mrobinson@igalia.com>

Add more results for many tests in the fast directory missing results.

  • platform/gtk/Skipped: Unskip tests that now have results.
10:00 Changeset [78075] by zmo@google.com
  • 2 edits in trunk/LayoutTests

2011-02-09 Zhenyao Mo <zmo@google.com>

Unreviewed, test expectations update.

  • platform/chromium/test_expectations.txt
09:52 Changeset [78074] by alex@webkit.org
  • 3 edits
    1 copy in trunk/Source/WebKit2

2011-02-09 Amruth Raj <amruthraj@motorola.com> and Ravi Phaneendra Kasibhatla <ravi.kasibhatla@motorola.com>

Reviewed by Martin Robinson.

[GTK] Implement Module class for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=48510

  • GNUmakefile.am:
  • Platform/Module.h: Added GModule handle for GTK port.
  • Platform/gtk/ModuleGtk.cpp: Initial code using GModule calls. (WebKit::Module::load): (WebKit::Module::unload): (WebKit::Module::platformFunctionPointer):
09:46 Changeset [78073] by yael.aharon@nokia.com
  • 2 edits in trunk/Source/WebCore

2011-02-09 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Darin Adler.

Add convenience method toHTMLElement(Node*)
https://bugs.webkit.org/show_bug.cgi?id=54105

No new tests since no new functionality introduced.

  • html/HTMLElement.h: (WebCore::toHTMLElement):
09:45 Changeset [78072] by alex@webkit.org
  • 4 edits
    5 adds in trunk/Source/WebKit2

2011-02-09 Chandra Vallala <chandra.vallala@motorola.com> and Alejandro G. Castro <alex@igalia.com>

Reviewed by Martin Robinson.

[GTK] Implement WKBaseGtk API for Webkit2
https://bugs.webkit.org/show_bug.cgi?id=54081

  • GNUmakefile.am: Added new files to compilation.
  • Shared/API/c/WKBase.h: Included WKBaseGtk.h in this file.
  • Shared/API/c/gtk: Added.
  • Shared/API/c/gtk/WKBaseGtk.h: Added. Declaration of WKViewRef for GTK port.
  • UIProcess/API/C/WKAPICast.h: Included WKAPICastGtk.h in this file.
  • UIProcess/API/C/gtk: Added.
  • UIProcess/API/C/gtk/WKAPICastGtk.h: Added. Type definition template for WKViewRef to WebView and vice-versa.
  • UIProcess/API/C/gtk/WKView.cpp: Added. Implementation of WKView API interface. (WKViewCreate): (WKViewGetWindow): (WKViewGetPage): (WKURLCreateWithURL):
  • UIProcess/API/C/gtk/WKView.h: Added. Declaration of WKView API interface.
09:41 Changeset [78071] by mrobinson@webkit.org
  • 2 edits
    300 adds in trunk/LayoutTests

2011-02-09 Martin Robinson <mrobinson@igalia.com>

Add test results for many tests in the fast directory missing results.

  • platform/gtk/Skipped: Unskip tests with results.
09:35 Changeset [78070] by christian@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk/po

Unreviewed translation file.

Update Simplified Chinese (zh_CN) translation of WebKitGtk
https://bugs.webkit.org/show_bug.cgi?id=42496

  • zh_CN.po: Updated.
09:33 Changeset [78069] by alex@webkit.org
  • 4 edits
    2 copies
    1 add in trunk/Source/WebKit2

2011-02-09 Alejandro G. Castro <alex@igalia.com>

Reviewed by Martin Robinson.

[GTK] Add WebGraphicsContext stub to the compilation
https://bugs.webkit.org/show_bug.cgi?id=54078

  • GNUmakefile.am:
  • Shared/API/c/gtk/WKGraphicsContextGtk.cpp: Added stub just for compilation. (WKGraphicsContextGetGtkContext):
  • Shared/API/c/gtk/WKGraphicsContextGtk.h: Added stub just for compilation.
  • Shared/WebGraphicsContext.cpp: (WebKit::WebGraphicsContext::WebGraphicsContext):
  • Shared/WebGraphicsContext.h: (WebKit::WebGraphicsContext::platformContext):
09:30 Changeset [78068] by christian@webkit.org
  • 1 edit
    1 add in trunk/Source/WebKit/gtk/po

Please add Greek translation of WebkitGTK+
https://bugs.webkit.org/show_bug.cgi?id=34482

  • gr.po: Added.
09:27 Changeset [78067] by christian@webkit.org
  • 1 edit
    1 add in trunk/Source/WebKit/gtk/po

Unreviewed translation file.

Arabic translation
https://bugs.webkit.org/show_bug.cgi?id=36340

  • ar.po: Added.
09:25 Changeset [78066] by weinig@apple.com
  • 4 edits in trunk/Source/WebCore

Fixed positioned elements at very top or bottom of page remain fixed but clip during rubber-banding
<rdar://problem/7615997>
https://bugs.webkit.org/show_bug.cgi?id=54054

Reviewed by Dan Bernstein.

Take the overhang into account when calculating position for elements with position: fixed.

  • platform/ScrollView.cpp:

(WebCore::ScrollView::scrollXForFixedPosition):
(WebCore::ScrollView::scrollYForFixedPosition):
(WebCore::ScrollView::scrollOffsetForFixedPosition):

  • platform/ScrollView.h:
  • rendering/RenderView.cpp:

(WebCore::RenderView::mapLocalToContainer):
(WebCore::RenderView::mapAbsoluteToLocalPoint):
(WebCore::RenderView::computeRectForRepaint):

09:24 Changeset [78065] by alex@webkit.org
  • 2 edits in trunk/Source/WebKit2

2011-02-09 Alejandro G. Castro <alex@igalia.com>

Reviewed by Martin Robinson.

[GTK] Add geolocation support to the webkit2 compilation
https://bugs.webkit.org/show_bug.cgi?id=54077

Add Geolocation files to the GTK compilation.

  • GNUmakefile.am:
09:21 Changeset [78064] by christian@webkit.org
  • 1 edit
    1 add in trunk/Source/WebKit/gtk/po

Unreviewed translation file.

Attached is the Bulgarian translation of WebKit Gtk
https://bugs.webkit.org/show_bug.cgi?id=44400

  • bg.po: Added.
09:17 Changeset [78063] by christian@webkit.org
  • 1 edit
    1 add in trunk/Source/WebKit/gtk/po

Unreviewed translation file.

[l10n] Indonesian translation
https://bugs.webkit.org/show_bug.cgi?id=46455

  • id.po: Added.
09:13 Changeset [78062] by simon.fraser@apple.com
  • 8 edits
    4 adds in trunk

2011-02-09 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dirk Schulze.

Enhance ShadowBlur to tile inset box shadows
https://bugs.webkit.org/show_bug.cgi?id=51567

Add a tiling code path to ShadowBlur for rendering inset
box-shadows.

Test: fast/box-shadow/inset-box-shadows.html

  • platform/graphics/ShadowBlur.cpp: (WebCore::computeSliceSizesFromRadii): Compute the slice sizes for the eight-piece shadow template. (WebCore::ShadowBlur::templateSize): Compute the size of the template, given the slice sizes. (WebCore::ShadowBlur::drawRectShadow): Bail early if layerRect is empty (which probably means we're clipped out). Call templateSize() and use the result to decide whether to tile. (WebCore::ShadowBlur::drawInsetShadow): New method for inset shadows. (WebCore::ShadowBlur::drawRectShadowWithoutTiling): Code moved. (WebCore::ShadowBlur::drawInsetShadowWithoutTiling): The non-tiling code path for inset shadows. (WebCore::ShadowBlur::drawInsetShadowWithTiling): Fill the shadow template buffer, paint the non-blurred area of the destination, and then call drawLayerPieces() to paint the eight-piece template image. (WebCore::ShadowBlur::drawRectShadowWithTiling): Refactored code, now shares the blurring code via blurAndColorShadowBuffer(), and the tiled template drawing via drawLayerPieces(). (WebCore::ShadowBlur::drawLayerPieces): Draw an eight-piece image from the shadow template to the destination. (WebCore::ShadowBlur::blurAndColorShadowBuffer): Blur the pixels in the image buffer, and colorize them using the CompositeSourceIn operation.
  • platform/graphics/ShadowBlur.h:
09:13 Changeset [78061] by laszlo.1.gombos@nokia.com
  • 2 edits in trunk/Tools

2011-02-09 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Remove UiTools dependency from MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=54096

  • MiniBrowser/qt/MiniBrowser.pro:
09:12 Changeset [78060] by christian@webkit.org
  • 1 edit
    1 add in trunk/Source/WebKit/gtk/po

Unreviewed translation file.

[l10n] Polish translation of WebKitGTK+
https://bugs.webkit.org/show_bug.cgi?id=46567

  • pl.po: Added.
09:06 Changeset [78059] by christian@webkit.org
  • 1 edit
    1 add in trunk/Source/WebKit/gtk/po

Unreviewed translation file.

[Gtk] Please add Hungarian translation
https://bugs.webkit.org/show_bug.cgi?id=34543

  • hu.po: Added.
09:03 Changeset [78058] by jochen@chromium.org
  • 8 edits
    15 adds in trunk

2011-02-09 Jochen Eisinger <jochen@chromium.org>

Reviewed by Adam Barth.

Disable script elements when a CSP header is present
https://bugs.webkit.org/show_bug.cgi?id=53867

  • http/tests/security/contentSecurityPolicy/no-policy-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/no-policy.html: Added.
  • http/tests/security/contentSecurityPolicy/resources/echo-iframe.pl: Added.
  • http/tests/security/contentSecurityPolicy/resources/echo-script-src.pl: Added.
  • http/tests/security/contentSecurityPolicy/resources/redir.php: Added.
  • http/tests/security/contentSecurityPolicy/resources/script-src.html: Added.
  • http/tests/security/contentSecurityPolicy/resources/script.js: Added.
  • http/tests/security/contentSecurityPolicy/script-src-in-iframe-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/script-src-in-iframe.html: Added.
  • http/tests/security/contentSecurityPolicy/script-src-none-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/script-src-none.html: Added.
  • http/tests/security/contentSecurityPolicy/script-src-redirect-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/script-src-redirect.html: Added.

2011-02-09 Jochen Eisinger <jochen@chromium.org>

Reviewed by Adam Barth.

Disable script elements when a CSP header is present
https://bugs.webkit.org/show_bug.cgi?id=53867

Tests: http/tests/security/contentSecurityPolicy/no-policy.html

http/tests/security/contentSecurityPolicy/script-src-in-iframe.html
http/tests/security/contentSecurityPolicy/script-src-none.html
http/tests/security/contentSecurityPolicy/script-src-redirect.html

  • html/parser/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::shouldLoadExternalScriptFromSrc):
  • html/parser/HTMLScriptRunner.cpp: (WebCore::HTMLScriptRunner::requestPendingScript):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::didBeginDocument):
  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::didReceiveResponse):
  • page/ContentSecurityPolicy.cpp: (WebCore::ContentSecurityPolicy::ContentSecurityPolicy): (WebCore::ContentSecurityPolicy::didReceiveHeader): (WebCore::ContentSecurityPolicy::canLoadExternalScriptFromSrc):
  • page/ContentSecurityPolicy.h:
08:56 Changeset [78057] by paroga@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-09 Patrick Gansterer <paroga@webkit.org>

Unreviewed WinCE build fix for r78047.

ContextMenu.cpp and ContextMenuItem.cpp have a USE(CROSS_PLATFORM_CONTEXT_MENUS),
so they shouldn't cause problems with correct preprocessor defines.

  • CMakeLists.txt:
08:32 Changeset [78056] by loislo@chromium.org
  • 5 edits in trunk/Source/WebCore

2011-02-09 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: InspectorAgent should know nothing about InspectorController instance.

https://bugs.webkit.org/show_bug.cgi?id=54100

  • inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::InspectorAgent): (WebCore::InspectorAgent::restoreInspectorStateFromCookie): (WebCore::InspectorAgent::disconnectFrontend):
  • inspector/InspectorAgent.h:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::disconnectFrontend): (WebCore::InspectorController::restoreInspectorStateFromCookie):
07:48 Changeset [78055] by abecsi@webkit.org
  • 2 edits in trunk/Source/WebKit2

2011-02-09 Andras Becsi <abecsi@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt][WK2] Don't generate superfluous forwarding header for config.h.

  • Scripts/generate-forwarding-headers.pl:
07:45 Changeset [78054] by aroben@apple.com
  • 2 edits in trunk/Source/WebKit2

Hide the ugly details of WebView::m_window initialization from WebPageProxy, and make it less ugly

WebView::WebView was initially creating a hidden window, then showing it. It would tell
WebPageProxy about the window while it was still hidden, and then have to inform
WebPageProxy that the window had become shown. This resulted in WebPageProxy sending
unnecessary messages to the web process, and confused code that assumed that the window
would be in the same state after WebView's constructor exited as it was when WebPageProxy
first found out about the window.

We now don't hide the window when creating it, which simplifies the code, and only tell
WebPageProxy about the window after we're done modifying it, which fixes the bug.

Fixes <http://webkit.org/b/53878> <rdar://problem/8977306> Assertion failure in
DrawingAreaImpl::resumePainting after window.open or when opening Web Inspector

Reviewed by Anders Carlsson.

  • UIProcess/win/WebView.cpp:

(WebKit::WebView::WebView): Changed ::CreateWindowEx to ::CreateWindowExW, to match other
Win32 API calls in WebKit2. Pass WS_VISIBLE to ::CreateWindowExW rather than waiting until
later to show the window. Added an assertion that m_isVisible matches the window's visible
state. Don't even create our WebPageProxy, or tell it about our window, until we're done
initializing our window, so that it doesn't get informed about our window's internal state
changes that happen beneath ::CreateWindowExW.
(WebKit::WebView::onSizeEvent): Null-check m_page since we can receive this message beneath
::CreateWindowExW.
(WebKit::WebView::onShowWindowEvent): Ditto. Replaced one FIXME with another. Always set
handled to false so that ::DefWindowProcW can do its thing. (MSDN says this is when it
actually shows/hides the window, though I couldn't find any consequences of not calling
::DefWindowProcW here.)

07:28 Changeset [78053] by podivilov@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-02-09 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: source frame scroll position is not restored.
https://bugs.webkit.org/show_bug.cgi?id=54101

  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._scriptSourceChanged):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype.show): (WebInspector.SourceFrame.prototype.hide): (WebInspector.SourceFrame.prototype.get scrollTop): (WebInspector.SourceFrame.prototype.set scrollTop):
  • inspector/front-end/TextViewer.js: (WebInspector.TextViewer.prototype.get scrollTop): (WebInspector.TextViewer.prototype.set scrollTop): (WebInspector.TextViewer.prototype.get scrollLeft): (WebInspector.TextViewer.prototype.set scrollLeft):
06:48 Changeset [78052] by pfeldman@chromium.org
  • 13 edits in trunk/Source

2011-02-09 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: follow up on InspectorAgent split -
removing unnecessary methods from InspectorController.
https://bugs.webkit.org/show_bug.cgi?id=54093

  • WebCore.exp.in:
  • inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::stopUserInitiatedProfiling): (WebCore::InspectorAgent::showAndEnableDebugger): (WebCore::InspectorAgent::enabled): (WebCore::InspectorAgent::showConsole):
  • inspector/InspectorAgent.h:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::didClearWindowObjectInWorld): (WebCore::InspectorController::showConsole): (WebCore::InspectorController::enabled): (WebCore::InspectorController::inspectedPage):
  • inspector/InspectorController.h:
  • inspector/InspectorFrontendClientLocal.cpp:

2011-02-09 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: follow up on InspectorAgent split -
removing unnecessary methods from InspectorController.
https://bugs.webkit.org/show_bug.cgi?id=54093

2011-02-09 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: follow up on InspectorAgent split -
removing unnecessary methods from InspectorController.
https://bugs.webkit.org/show_bug.cgi?id=54093

  • WebInspector.cpp: (WebInspector::showConsole): (WebInspector::toggleProfilingJavaScript):

2011-02-09 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: follow up on InspectorAgent split -
removing unnecessary methods from InspectorController.
https://bugs.webkit.org/show_bug.cgi?id=54093

  • WebProcess/WebPage/WebInspector.cpp: (WebKit::WebInspector::showConsole): (WebKit::WebInspector::stopJavaScriptProfiling):
06:09 Changeset [78051] by cmarrin@apple.com
  • 5 edits in trunk/Source/WebCore

2011-02-07 Chris Marrin <cmarrin@apple.com>

Reviewed by Simon Fraser.

LayoutTests/animations/play-state.html has wrong behavior with accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=53513

The PlatformCAAnimation::create() function which took a pointer to another
PlatformCAAnimation was supposed to make a copy of that passed object.
But it was doing completely the wrong thing on Mac and was leaking an object
to boot. And the notion of copying an object using a static creation function
is wrong in the first place. So I changed it to a member copy() function
which would create a new PlatformCAAnimation which was a copy of 'this' and
return it. I changed the implementation on both Mac and Win to match.

This problem was not caught by DRT, even there is a specific test for it.
That test just verifies that the higher level logic is working
properly, which it is. There's no practical way to find out if the
layer is currently animating. There is no logic which probes that
deeply into the layer mechanics.


  • platform/graphics/ca/GraphicsLayerCA.cpp:
  • platform/graphics/ca/PlatformCAAnimation.h:
  • platform/graphics/ca/mac/PlatformCAAnimationMac.mm:
  • platform/graphics/ca/win/PlatformCAAnimationWin.cpp:
06:07 Changeset [78050] by hamaji@chromium.org
  • 2 edits in trunk/LayoutTests

2011-02-09 Shinichiro Hamaji <hamaji@chromium.org>

Chromium expectations update.

fast/dom/HTMLAnchorElement/set-href-attribute-hash.html is failing.

  • platform/chromium/test_expectations.txt:
05:59 Changeset [78049] by pfeldman@chromium.org
  • 1 edit in branches/chromium/648/Source/WebCore/inspector/InspectorController.cpp

DevTools: fix poor merge that resulted in calling into setDocument twice.
I am not doing it using drover since InspectorController has been renamed since the branch point.

BUG=72422
TBR=yurys

05:55 Changeset [78048] by hamaji@chromium.org
  • 2 edits in trunk/LayoutTests

2011-02-09 Shinichiro Hamaji <hamaji@chromium.org>

Chromium: update expectations

plugins/invalidate_rect is failing on linux and win, too.

plugins/invalidate_rect.html fails on chromium-mac
https://bugs.webkit.org/show_bug.cgi?id=54051

  • platform/chromium/test_expectations.txt:
05:51 Changeset [78047] by demarchi@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-09 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Unreviewed build fix.

[EFL] Remove double definition of ContextMenu.
https://bugs.webkit.org/show_bug.cgi?id=50762

When building with SHARED_CORE enabled, the symbols of ContextMenu
were both in webkit and webcore. This removes them from webcore and
shall be put back once the CROSS_PLATFORM_CONTEXT_MENUS is implemented
in EFL port.

No new tests because no new functionality.

  • CMakeLists.txt:
04:40 Changeset [78046] by loislo@chromium.org
  • 4 edits in trunk/LayoutTests

2011-02-09 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed.

Chromium: Create expectations for residual-style.html see r77781.

  • platform/chromium-linux/fast/invalid/residual-style-expected.txt:
  • platform/chromium-win/fast/invalid/residual-style-expected.txt:
  • platform/chromium/test_expectations.txt:
04:27 Changeset [78045] by aroben@apple.com
  • 2 edits in trunk/Source/WebCore

Windows Production build fix

  • WebCore.vcproj/QTMovieWinCommon.vsprops: Link against

WebKitSystemInterface$(WebKitConfigSuffix).lib, not just WebKitSystemInterface.lib, so we
pick up the _debug variant when appropriate.

04:13 Changeset [78044] by eric@webkit.org
  • 9 edits in trunk

2011-02-09 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Hostnames should cannonicalize to lowercase (to match every other browser)
https://bugs.webkit.org/show_bug.cgi?id=54084

Pretty obvious change. KURL is the odd man out here.

  • fast/url/host-expected.txt:
  • fast/url/ipv4-expected.txt:
  • fast/url/ipv6-expected.txt:
  • fast/url/relative-expected.txt:
  • fast/url/relative-unix-expected.txt:
  • fast/url/standard-url-expected.txt:

2011-02-09 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Hostnames should cannonicalize to lowercase (to match every other browser)
https://bugs.webkit.org/show_bug.cgi?id=54084

  • platform/KURL.cpp: (WebCore::KURL::parse):
04:04 Changeset [78043] by sergio@webkit.org
  • 2 edits
    7 adds in trunk/LayoutTests

2011-02-09 Sergio Villar Senin <svillar@igalia.com>

Unreviewed.

Added new text expectations for GTK port. They should be actually
valid for any port using the libsoup backend. We need different
results because as stated here
https://bugs.webkit.org/show_bug.cgi?id=3812#c6, the original test
results were designed for NSURLConnection which adds the
"Content-Length: 0" header for null message bodies. That does not
happen in libsoup, so instead of artificially add that header we
better generate different results.

Also take into account that for HEAD and GET requests the body is
not included so we should expect always a null for them.

  • platform/gtk/Skipped:
  • platform/gtk/http/tests/xmlhttprequest/methods-async-expected.txt: Added.
  • platform/gtk/http/tests/xmlhttprequest/methods-expected.txt: Added.
  • platform/gtk/http/tests/xmlhttprequest/workers/methods-async-expected.txt: Added.
  • platform/gtk/http/tests/xmlhttprequest/workers/methods-expected.txt: Added.
  • platform/gtk/http/tests/xmlhttprequest/workers/shared-worker-methods-async-expected.txt: Added.
  • platform/gtk/http/tests/xmlhttprequest/workers/shared-worker-methods-expected.txt: Added.
04:00 Changeset [78042] by pvarga@webkit.org
  • 24 edits
    4 adds
    1 delete in trunk/Source

Replace PCRE with Yarr in WebCore
https://bugs.webkit.org/show_bug.cgi?id=53496

Reviewed by Gavin Barraclough.

Rollback r77626 with windows build fix.

Source/JavaScriptCore:

Source/WebCore:

No new tests needed.

  • Android.jscbindings.mk:
  • CMakeLists.txt:
  • ForwardingHeaders/pcre/pcre.h: Removed.
  • ForwardingHeaders/yarr/Yarr.h: Added.
  • ForwardingHeaders/yarr/YarrInterpreter.h: Added.
  • ForwardingHeaders/yarr/YarrPattern.h: Added.
  • WebCore.gyp/WebCore.gyp:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcproj/copyForwardingHeaders.cmd:
  • platform/text/RegularExpression.cpp:

(WebCore::RegularExpression::Private::create):
(WebCore::RegularExpression::Private::Private):
(WebCore::RegularExpression::Private::compile):
(WebCore::RegularExpression::match):

03:54 Changeset [78041] by gyuyoung.kim@samsung.com
  • 3 edits in trunk/Source/WebCore

2011-02-09 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Eric Seidel.

[EFL] Add dummy functions for HTML5 Video's control UI
https://bugs.webkit.org/show_bug.cgi?id=53906

In WebKit EFL, there are no implementations for HTML5 control UI.
First, dummy functions are added.

  • platform/efl/RenderThemeEfl.cpp: (WebCore::RenderThemeEfl::extraMediaControlsStyleSheet): (WebCore::RenderThemeEfl::formatMediaControlsCurrentTime): (WebCore::RenderThemeEfl::paintMediaFullscreenButton): (WebCore::RenderThemeEfl::paintMediaMuteButton): (WebCore::RenderThemeEfl::paintMediaPlayButton): (WebCore::RenderThemeEfl::paintMediaSeekBackButton): (WebCore::RenderThemeEfl::paintMediaSeekForwardButton): (WebCore::RenderThemeEfl::paintMediaSliderTrack): (WebCore::RenderThemeEfl::paintMediaSliderThumb): (WebCore::RenderThemeEfl::paintMediaVolumeSliderContainer): (WebCore::RenderThemeEfl::paintMediaVolumeSliderTrack): (WebCore::RenderThemeEfl::paintMediaVolumeSliderThumb): (WebCore::RenderThemeEfl::paintMediaCurrentTime):
  • platform/efl/RenderThemeEfl.h:
03:53 Changeset [78040] by eric@webkit.org
  • 10 edits in trunk

2011-02-09 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Make WebKit's fragment cannonicalization match other browsers
https://bugs.webkit.org/show_bug.cgi?id=53850

  • fast/dom/HTMLAnchorElement/set-href-attribute-hash.html: Updated to match IE/Chrome
  • fast/dom/HTMLAnchorElement/set-href-attribute-hash-expected.txt: Updated to match IE/Chrome.
  • fast/url/anchor-expected.txt:
    • "hello world": Our new behavior here matches IE and Chrome, but diverges from FF.
    • The last two tests involving #, we were the odd man out. Now match all browsers.
  • fast/url/segments-expected.txt:
    • Don't percent encode spaces in fragments (to match other browsers)
    • WebKit was the only engine encoding # in fragments.
  • fast/url/segments-from-data-url-expected.txt:

2011-02-09 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Make WebKit's fragment cannonicalization match other browsers
https://bugs.webkit.org/show_bug.cgi?id=53850

This doesn't make us match perfectly, but it brings us closer.

  • platform/KURL.cpp: (WebCore::appendEscapingBadChars): (WebCore::escapeAndAppendFragment): (WebCore::KURL::parse):
03:37 Changeset [78039] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed.

[Qt] Fix crashes in QMetaObject::metacall
https://bugs.webkit.org/show_bug.cgi?id=53912

One more attempt to make Qt buildbot happier and make sheriffbot
not to spam innocent people because of this flakey crash.

  • platform/qt/Skipped: Add websocket directory instead of individual tests until fix.
03:20 Changeset [78038] by ossy@webkit.org
  • 3 edits in trunk/Source/WebKit/qt

[Qt] fast/dom/nodesFromRect-links-and-text.html crashes in debug mode
https://bugs.webkit.org/show_bug.cgi?id=53921

Patch by Robert Hogan <robert@webkit.org> on 2011-02-09
Reviewed by Antonio Gomes.

QDRTNode needs a copy constructor and an operator= in order to keep
proper refcounts.

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(:m_node):
(QDRTNode::operator=):
(DumpRenderTreeSupportQt::nodesFromRect):

  • WebCoreSupport/DumpRenderTreeSupportQt.h:
02:58 Changeset [78037] by loislo@chromium.org
  • 3 edits in trunk/LayoutTests

2011-02-09 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed.

Chromium: Rebaseline html5lib/runner.html expectations after r77781.

  • platform/chromium/html5lib/runner-expected.txt:
  • platform/chromium/test_expectations.txt:
02:37 Changeset [78036] by apavlov@chromium.org
  • 1 edit
    1 add in trunk/Websites/webkit.org

2011-02-09 Alexander Pavlov <apavlov@chromium.org>

Unreviewed. Add Web Inspector stylesheet resource diff screenshot.

  • blog-files/inspector/css_rule_diff.png: Added.
02:33 Changeset [78035] by hans@chromium.org
  • 4 edits
    2 adds in trunk

2011-02-09 Hans Wennborg <hans@chromium.org>

Reviewed by Jeremy Orlow.

IndexedDB: Cursors should skip deleted entries
https://bugs.webkit.org/show_bug.cgi?id=53690

Cursors should skip over entries that have been deleted
since the cursor was opened.

  • storage/indexeddb/cursor-skip-deleted-expected.txt: Added.
  • storage/indexeddb/cursor-skip-deleted.html: Added.

2011-02-09 Hans Wennborg <hans@chromium.org>

Reviewed by Jeremy Orlow.

IndexedDB: Cursors should skip deleted entries
https://bugs.webkit.org/show_bug.cgi?id=53690

Add test to check that the cursor skips deleted entries.

Test: storage/indexeddb/cursor-skip-deleted.html

  • storage/IDBCursorBackendImpl.cpp: (WebCore::IDBCursorBackendImpl::currentRowExists): (WebCore::IDBCursorBackendImpl::continueFunctionInternal):
  • storage/IDBCursorBackendImpl.h:
02:12 Changeset [78034] by podivilov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-02-08 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: script formatter should not create a worker for each script.
https://bugs.webkit.org/show_bug.cgi?id=54010

  • inspector/front-end/ScriptFormatter.js: (WebInspector.ScriptFormatter): (WebInspector.ScriptFormatter.prototype._formatScript): (WebInspector.ScriptFormatter.prototype._handleMessage): (WebInspector.ScriptFormatter.prototype._handleError):
02:05 Changeset [78033] by morrita@google.com
  • 2 edits in trunk/Source/WebKit/chromium

2011-02-09 MORITA Hajime <morrita@google.com>

Reviewed by Shinichiro Hamaji.

[Chromium] WebTextCheckingResult should have a default constructor.
https://bugs.webkit.org/show_bug.cgi?id=54075

Gave default parameters to WebTextCheckingResult constructor.

  • public/WebTextCheckingResult.h: (WebKit::WebTextCheckingResult::WebTextCheckingResult):
02:00 Changeset [78032] by podivilov@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-02-08 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: sync uglifyjs parser files.
https://bugs.webkit.org/show_bug.cgi?id=54003

  • inspector/front-end/UglifyJS/parse-js.js:
  • inspector/front-end/UglifyJS/process.js:
01:53 Changeset [78031] by loislo@chromium.org
  • 2 edits in trunk/LayoutTests

2011-02-09 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed.

Chromium: update expectations for some canvas/philip tests which are failing on MAC.

  • platform/chromium/test_expectations.txt:
00:23 Changeset [78030] by mrobinson@webkit.org
  • 2 edits in trunk/LayoutTests

2011-02-09 Martin Robinson <mrobinson@igalia.com>

Skip some failing tests.

  • platform/gtk/Skipped: Skip plugins/invalidate_rect.html and fast/frames/flattening/iframe-flattening-crash.html
00:09 Changeset [78029] by ossy@webkit.org
  • 1 edit
    1 copy
    2 adds in trunk/LayoutTests

Unreviewed.

[Qt] Qt platform has a different editing delegates for several tests
https://bugs.webkit.org/show_bug.cgi?id=43082

editing/undo/undo-paste-when-caret-is-not-in-range.html introduced in r77995, but fails on Qt.
Add platform specific expected result until fix.

  • platform/qt/editing/undo/undo-paste-when-caret-is-not-in-range-expected.checksum: Added.
  • platform/qt/editing/undo/undo-paste-when-caret-is-not-in-range-expected.png: Added.
  • platform/qt/editing/undo/undo-paste-when-caret-is-not-in-range-expected.txt: Copied from LayoutTests/editing/undo/undo-paste-when-caret-is-not-in-range-expected.txt.
00:03 Changeset [78028] by alex@webkit.org
  • 3 edits in trunk/Source/WebKit2

2011-02-09 Alejandro G. Castro <alex@igalia.com>

Reviewed by Martin Robinson.

[GTK] Avoid WebProcessMain compilation, we are used a gtk specific main
https://bugs.webkit.org/show_bug.cgi?id=54015

Avoided the compilation of the general WebProcessMain, and added
soup initialization to WebProcessMainGtk.cpp.

  • GNUmakefile.am:
  • WebProcess/gtk/WebProcessMainGtk.cpp: (WebKit::WebProcessMainGtk):

02/08/11:

23:59 WebKitGTK/KeepingTheTreeGreen edited by alex@webkit.org
(diff)
23:58 Changeset [78027] by alex@webkit.org
  • 2 edits in trunk/Source/WebKit2

2011-02-08 Alejandro G. Castro <alex@igalia.com>

Reviewed by Martin Robinson.

[GTK] Incorrect assertion in WorkQueueGtk, we need to register
more than one handle
https://bugs.webkit.org/show_bug.cgi?id=54014

Fixed assertion condition we need to register more than one
handler for the same file descriptor.

  • Platform/gtk/WorkQueueGtk.cpp: (WorkQueue::registerEventSourceHandler):
23:58 Changeset [78026] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed.

[Qt]Missing layoutTestController.displayInvalidatedRegion()

plugins/invalidate_rect.html introduced in r78010, but unfortunately
Qt DRT doesn't have layoutTestController.displayInvalidatedRegion().

  • platform/qt/Skipped: Add plugins/invalidate_rect.html.
23:43 Changeset [78025] by alex@webkit.org
  • 2 edits in trunk/Source/WebKit2

2011-02-08 Alejandro G. Castro <alex@igalia.com>

Reviewed by Martin Robinson.

Fix typo in the include guards name in ChunkedUpdateDrawingAreaProxy.h
https://bugs.webkit.org/show_bug.cgi?id=54013

  • UIProcess/ChunkedUpdateDrawingAreaProxy.h:
23:42 Changeset [78024] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit/mac

<rdar://problem/8959420> Find in Mail no longer cycles around

Reviewed by Jon Honeycutt and Maciej Stachowiak.

  • WebView/WebHTMLView.mm:

(-[WebHTMLView searchFor:direction:caseSensitive:wrap:startInSelection:]): Set
the wrap option according to the flag.

23:30 Changeset [78023] by mjs@apple.com
  • 2 edits in trunk/LayoutTests

2011-02-08 Maciej Stachowiak <mjs@apple.com>

Reviewed by Kent Tamura.

Skip a freshly added test that depends on newly added DRT functionality
https://bugs.webkit.org/show_bug.cgi?id=54069

  • platform/mac-wk2/Skipped:
23:25 Changeset [78022] by alex@webkit.org
  • 2 edits in trunk/Source/WebKit2

2011-02-08 Alejandro G. Castro <alex@igalia.com>

Reviewed by Martin Robinson.

[GTK] Fix after r77874, m_isConnected is initialized before the
socket is opened
https://bugs.webkit.org/show_bug.cgi?id=54011

Fixed connection breakage after r77874, we have to wait until open
the socket to open the connection.

  • Platform/CoreIPC/gtk/ConnectionGtk.cpp: (CoreIPC::Connection::platformInitialize): (CoreIPC::Connection::open):
23:21 Changeset [78021] by alex@webkit.org
  • 2 edits in trunk/Source/WebKit2

2011-02-08 Alejandro G. Castro <alex@igalia.com>

Reviewed by Martin Robinson.

[WK2] LayerTreeContext is used outside the ACCELERATED_COMPOSITING
guards but not defined in DrawingAreaProxy.h
https://bugs.webkit.org/show_bug.cgi?id=54009

Removed the guards in the forward declaration, this will fail if
the class is finally used in the function, but it works for the
moment.

  • UIProcess/DrawingAreaProxy.h:
23:16 Changeset [78020] by alex@webkit.org
  • 5 edits in trunk

2011-02-08 Alejandro G. Castro <alex@igalia.com>

Reviewed by Martin Robinson.

WebKit2 GTK Fails to Build #include nested too deeply
https://bugs.webkit.org/show_bug.cgi?id=52219

  • GNUmakefile.am: Removed the commands to create the directories for the forwarding headers, the script already does it for us.
  • config.h: Removed the config.h inclusion and added the autotoolsconfig.h directly, also added a condition to share the defines with QT.

2011-02-08 Alejandro G. Castro <alex@igalia.com>

Reviewed by Martin Robinson.

WebKit2 GTK Fails to Build #include nested too deeply
https://bugs.webkit.org/show_bug.cgi?id=52219

Removed the STDC_FORMAT_MACROS definition, it is already defined
in the file where PRIxx64 is used before the inclusion so we are
safe.

  • configure.ac:
22:42 Changeset [78019] by ojan@chromium.org
  • 3 edits in trunk/Websites/bugs.webkit.org

2011-02-08 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

fix toolbar anchoring in the code review tool
https://bugs.webkit.org/show_bug.cgi?id=54058

Avoid the anchoring cycle of doom when on the cusp
of whether the toolbar needs to be anchored and
speculatively avoid the Firefox crash when resizing.

  • PrettyPatch/PrettyPatch.rb:
  • code-review.js:
22:09 Changeset [78018] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2011-02-08 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Removed some dead code from Heap
https://bugs.webkit.org/show_bug.cgi?id=54064

  • runtime/MarkedSpace.cpp: Removed some now-unused constants and declarations.

(JSC::MarkedSpace::allocate): Removed some ASSERTs that are also ASSERTed
by our caller. Removed redundant typedefs.

21:59 Changeset [78017] by ggaren@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

2011-02-08 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Use a vector to track blocks in the Heap, instead of hand-rolled vector-like code
https://bugs.webkit.org/show_bug.cgi?id=54062


SunSpider reports no change.

  • runtime/CollectorHeapIterator.h: (JSC::CollectorHeapIterator::isValid): (JSC::CollectorHeapIterator::isLive): Updated for new mark invariant: To know if an object is live, you just need to test its mark bit.
  • runtime/MarkedSpace.cpp: (JSC::MarkedSpace::MarkedSpace): Moved waterMark and highWaterMark from CollectorHeap into MarkedSpace, since they're global state. Removed call to memset since CollectorHeap is a true class with its own constructor now.

(JSC::MarkedSpace::destroy): Change uses of m_heap.usedBlocks to
m_heap.blocks.size(), and m_heap.numBlocks to m_heap.blocks.capacity().

(JSC::MarkedSpace::allocateBlock):
(JSC::MarkedSpace::freeBlock): No need to manage our vector manually anymore.

(JSC::MarkedSpace::allocate):
(JSC::MarkedSpace::shrink):
(JSC::MarkedSpace::clearMarkBits):
(JSC::MarkedSpace::markedCells):
(JSC::MarkedSpace::sweep):
(JSC::MarkedSpace::objectCount):
(JSC::MarkedSpace::capacity):
(JSC::MarkedSpace::reset):
(JSC::MarkedSpace::primaryHeapEnd):

  • runtime/MarkedSpace.h: (JSC::CollectorHeap::CollectorHeap): (JSC::MarkedSpace::highWaterMark): (JSC::MarkedSpace::setHighWaterMark): (JSC::MarkedSpace::contains): Same as above.
21:46 Changeset [78016] by mjs@apple.com
  • 2 edits in trunk/LayoutTests

2011-02-08 Maciej Stachowiak <mjs@apple.com>

Reviewed by Mark Rowe.

Skip some tests that fail in WebKit2 for obvious reasons
https://bugs.webkit.org/show_bug.cgi?id=54055

  • platform/mac-wk2/Skipped:
21:40 Changeset [78015] by mjs@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-02-08 Maciej Stachowiak <mjs@apple.com>

Reviewed by Mark Rowe.

Crash when going back/forward when back/forward list is in a bad state.
https://bugs.webkit.org/show_bug.cgi?id=54059
<rdar://problem/8975244>


  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::goForward): Add a null check. (WebKit::WebPageProxy::goBack): ditto
21:33 Changeset [78014] by hayato@chromium.org
  • 5 edits in trunk/Tools

2011-02-08 Hayato Ito <hayato@chromium.org>

Reviewed by Tony Chang.

[NRWT] Pull up rebaseline code from compare_output() function defined
in text_diff.py and image_diff.py into a SingleTestRunner.

This patch is a first step for eliminating test_type/* classes.

https://bugs.webkit.org/show_bug.cgi?id=53071

  • Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
  • Scripts/webkitpy/layout_tests/test_types/image_diff.py:
  • Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
  • Scripts/webkitpy/layout_tests/test_types/text_diff.py:
20:34 Changeset [78013] by commit-queue@webkit.org
  • 2 edits in trunk

2011-02-08 Kristian Amlie <kristian.amlie@nokia.com>

Reviewed by Eric Seidel.

Added include paths for QtScript.

WebKit patches required to work with a modularized version of Qt
https://bugs.webkit.org/show_bug.cgi?id=53916

  • Source/WebKit.pri:
20:32 Changeset [78012] by ojan@chromium.org
  • 6 edits in trunk/Tools

2011-02-07 Ojan Vafai <ojan@chromium.org>

Reviewed by Mihai Parparita.

stop generating results.json files
https://bugs.webkit.org/show_bug.cgi?id=53977

We've only used incremental_results.json for a while now
and there are plans to start generating a results.json file that matches
the format of unexpected_results.json.

  • Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
20:17 Changeset [78011] by rniwa@webkit.org
  • 5 edits
    2 adds in trunk

2011-02-08 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

REGRESSION(71556,68059): queryCommandValue screws up background color at collapsed cursor
https://bugs.webkit.org/show_bug.cgi?id=53196

The bug was caused by Editor::selectionComputedStyle's modifying typing style without making a copy,
and its removing non-inheritable properties from the typing style. Fixed the bug by making a copy
before making the modification and not removing non-inheritable properties.

Also fixed a bug in selectionStartCSSPropertyValue that it doesn't handle xx-small to -webkit-xxx-large
by extracting a function from StyleChange::extractTextStyles and calling it in both extractTextStyles
and selectionStartCSSPropertyValue.

Test: editing/style/query-typing-style.html

  • editing/ApplyStyleCommand.cpp: (WebCore::legacyFontSizeFromCSSValue): Extracted from StyleChange::extractTextStyles. (WebCore::StyleChange::extractTextStyles): Calls legacyFontSizeFromCSSValue; this fixes the bug that CSS values from xx-small through -webkit-xxx-large are not accounted.
  • editing/ApplyStyleCommand.h:
  • editing/Editor.cpp: (WebCore::Editor::selectionStartCSSPropertyValue): Calls legacyFontSizeFromCSSValue. (WebCore::Editor::selectionComputedStyle): Makes a copy before modifying typing style. No longer calls removeNonEditingProperties on the copied typing style so that background-color property is included when merged into the style.

2011-02-08 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

REGRESSION(71556,68059): queryCommandValue screws up background color at collapsed cursor
https://bugs.webkit.org/show_bug.cgi?id=53196

Added a test to ensure calling queryCommandValue returns the correct value for backColor
and fontSize from typing style.

  • editing/style/query-typing-style-expected.txt: Added.
  • editing/style/query-typing-style.html: Added.
19:30 Changeset [78010] by commit-queue@webkit.org
  • 11 edits
    2 adds in trunk

2011-02-08 Sailesh Agrawal <sail@chromium.org>

Reviewed by Kenneth Russell.

Invalidate rect doesn't work for windowless plugins on Chromium
https://bugs.webkit.org/show_bug.cgi?id=53117

Added a test to make sure that NPN_InvalidateRect() works correctly for windowless plugins.

  • plugins/invalidate_rect-expected.txt: Added.
  • plugins/invalidate_rect.html: Added.

2011-02-08 Sailesh Agrawal <sail@chromium.org>

Reviewed by Kenneth Russell.

Invalidate rect doesn't work for windowless plugins on Chromium
https://bugs.webkit.org/show_bug.cgi?id=53117

Invalidate rect for windowless plugins wasn't working if the web page was composited.

The problem was that the invalidate call was causing simply dirtying the LayerChromium layers. Since the plugin was windowless this didn't cause the plugin to be repainted.

Fix was to copy the invalidate code from WebCore/plugins/PluginView.cpp/PluginView::invalidateWindowlessPluginRect() which does the correct thing.

Tested my fix on Windows and Mac and verified that the movie on http://apple.com/appltv correctly plays. Verified that windowed plugins still correctly draw as well.

  • src/WebPluginContainerImpl.cpp: (WebKit::WebPluginContainerImpl::invalidateRect):

2011-02-08 Sailesh Agrawal <sail@chromium.org>

Reviewed by Kenneth Russell.

Invalidate rect doesn't work for windowless plugins on Chromium
https://bugs.webkit.org/show_bug.cgi?id=53117

Added two new utility methods.

  • layoutTestController.displayInvalidatedRegion() does a paint of any area that has been invalidated. This is different from layoutTestController.display() which explicitly invalidates the entire page then paints.
  • plugin.invalidateRect(left, top, right, bottom) - invalidates the given rect This is used to test that invalidating a rect correctly causes a repaint of the plugin.
  • DumpRenderTree/LayoutTestController.cpp: (displayInvalidatedRegionCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp: (invalidateRect): (pluginInvoke):
  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::displayInvalidatedRegion):
  • DumpRenderTree/chromium/LayoutTestController.h:
  • Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
18:59 Changeset [78009] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

REGRESSION (r76831): Subframes are printed blank
<rdar://problem/8945867>

Reviewed by Maciej Stachowiak.

  • page/FrameView.cpp:

(WebCore::FrameView::paintOverhangAreas):
Don't paint overhangs when printing.

18:43 Changeset [78008] by mihaip@chromium.org
  • 1 edit
    1 delete in trunk/LayoutTests

2011-02-08 Mihai Parparita <mihaip@chromium.org>

Unreviewed. Remove chromium-gpu-win baseline that has a failing result,
since we now pass the test.

  • platform/chromium-gpu-win/compositing/animation/animated-composited-inside-hidden-expected.txt: Removed.
18:39 Changeset [78007] by mihaip@chromium.org
  • 20 edits
    1 copy
    99 adds in trunk/LayoutTests

2011-02-08 Mihai Parparita <mihaip@chromium.org>

Unreviewed chromium-gpu-win rebaseline.

  • platform/chromium-gpu-win/compositing/direct-image-compositing-expected.txt:
  • platform/chromium-gpu-win/compositing/geometry/composited-html-size-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/geometry/composited-html-size-expected.png: Copied from LayoutTests/platform/chromium-gpu-win/fast/canvas/canvas-transform-skewed-expected.png.
  • platform/chromium-gpu-win/compositing/geometry/composited-html-size-expected.txt: Added.
  • platform/chromium-gpu-win/compositing/geometry/fixed-position-expected.checksum:
  • platform/chromium-gpu-win/compositing/geometry/fixed-position-expected.png:
  • platform/chromium-gpu-win/compositing/geometry/fixed-position-expected.txt:
  • platform/chromium-gpu-win/compositing/geometry/horizontal-scroll-composited-expected.checksum:
  • platform/chromium-gpu-win/compositing/geometry/horizontal-scroll-composited-expected.png:
  • platform/chromium-gpu-win/compositing/geometry/layer-due-to-layer-children-deep-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/geometry/layer-due-to-layer-children-deep-expected.png: Added.
  • platform/chromium-gpu-win/compositing/geometry/layer-due-to-layer-children-deep-expected.txt: Added.
  • platform/chromium-gpu-win/compositing/geometry/layer-due-to-layer-children-deep-switch-expected.txt: Added.
  • platform/chromium-gpu-win/compositing/geometry/layer-due-to-layer-children-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/geometry/layer-due-to-layer-children-expected.png: Added.
  • platform/chromium-gpu-win/compositing/geometry/layer-due-to-layer-children-expected.txt: Added.
  • platform/chromium-gpu-win/compositing/geometry/layer-due-to-layer-children-switch-expected.txt: Added.
  • platform/chromium-gpu-win/compositing/geometry/limit-layer-bounds-clipping-ancestor-expected.txt: Added.
  • platform/chromium-gpu-win/compositing/geometry/limit-layer-bounds-overflow-root-expected.txt: Added.
  • platform/chromium-gpu-win/compositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt: Added.
  • platform/chromium-gpu-win/compositing/geometry/tall-page-composited-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/geometry/tall-page-composited-expected.png: Added.
  • platform/chromium-gpu-win/compositing/geometry/vertical-scroll-composited-expected.checksum:
  • platform/chromium-gpu-win/compositing/geometry/vertical-scroll-composited-expected.png:
  • platform/chromium-gpu-win/compositing/geometry/vertical-scroll-composited-expected.txt:
  • platform/chromium-gpu-win/compositing/iframes/composited-iframe-scroll-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/iframes/composited-iframe-scroll-expected.png: Added.
  • platform/chromium-gpu-win/compositing/iframes/composited-iframe-scroll-expected.txt: Added.
  • platform/chromium-gpu-win/compositing/iframes/composited-parent-iframe-expected.txt:
  • platform/chromium-gpu-win/compositing/images/direct-svg-image-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/images/direct-svg-image-expected.png: Added.
  • platform/chromium-gpu-win/compositing/masks/masked-ancestor-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/masks/masked-ancestor-expected.png: Added.
  • platform/chromium-gpu-win/compositing/masks/masked-ancestor-expected.txt: Added.
  • platform/chromium-gpu-win/compositing/masks/simple-composited-mask-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/masks/simple-composited-mask-expected.png: Added.
  • platform/chromium-gpu-win/compositing/masks/simple-composited-mask-expected.txt: Added.
  • platform/chromium-gpu-win/compositing/overflow/fixed-position-ancestor-clip-expected.checksum:
  • platform/chromium-gpu-win/compositing/overflow/fixed-position-ancestor-clip-expected.png:
  • platform/chromium-gpu-win/compositing/overflow/fixed-position-ancestor-clip-expected.txt:
  • platform/chromium-gpu-win/compositing/reflections/animation-inside-reflection-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/reflections/animation-inside-reflection-expected.png: Added.
  • platform/chromium-gpu-win/compositing/reflections/animation-inside-reflection-expected.txt: Added.
  • platform/chromium-gpu-win/compositing/reflections/compositing-change-inside-reflection-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/reflections/compositing-change-inside-reflection-expected.png: Added.
  • platform/chromium-gpu-win/compositing/reflections/compositing-change-inside-reflection-expected.txt: Added.
  • platform/chromium-gpu-win/compositing/reflections/deeply-nested-reflections-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/reflections/deeply-nested-reflections-expected.png: Added.
  • platform/chromium-gpu-win/compositing/reflections/deeply-nested-reflections-expected.txt: Added.
  • platform/chromium-gpu-win/compositing/reflections/masked-reflection-on-composited-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/reflections/masked-reflection-on-composited-expected.png: Added.
  • platform/chromium-gpu-win/compositing/reflections/masked-reflection-on-composited-expected.txt: Added.
  • platform/chromium-gpu-win/compositing/reflections/nested-reflection-animated-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/reflections/nested-reflection-animated-expected.png: Added.
  • platform/chromium-gpu-win/compositing/reflections/nested-reflection-animated-expected.txt: Added.
  • platform/chromium-gpu-win/compositing/reflections/nested-reflection-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/reflections/nested-reflection-expected.png: Added.
  • platform/chromium-gpu-win/compositing/reflections/nested-reflection-expected.txt: Added.
  • platform/chromium-gpu-win/compositing/reflections/nested-reflection-mask-change-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/reflections/nested-reflection-mask-change-expected.png: Added.
  • platform/chromium-gpu-win/compositing/reflections/nested-reflection-mask-change-expected.txt: Added.
  • platform/chromium-gpu-win/compositing/reflections/nested-reflection-on-overflow-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/reflections/nested-reflection-on-overflow-expected.png: Added.
  • platform/chromium-gpu-win/compositing/reflections/nested-reflection-on-overflow-expected.txt: Added.
  • platform/chromium-gpu-win/compositing/reflections/nested-reflection-opacity-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/reflections/nested-reflection-opacity-expected.png: Added.
  • platform/chromium-gpu-win/compositing/reflections/nested-reflection-opacity-expected.txt: Added.
  • platform/chromium-gpu-win/compositing/reflections/nested-reflection-size-change-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/reflections/nested-reflection-size-change-expected.png: Added.
  • platform/chromium-gpu-win/compositing/reflections/nested-reflection-size-change-expected.txt: Added.
  • platform/chromium-gpu-win/compositing/reflections/nested-reflection-transformed-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/reflections/nested-reflection-transformed-expected.png: Added.
  • platform/chromium-gpu-win/compositing/reflections/nested-reflection-transformed-expected.txt: Added.
  • platform/chromium-gpu-win/compositing/reflections/nested-reflection-transformed2-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/reflections/nested-reflection-transformed2-expected.png: Added.
  • platform/chromium-gpu-win/compositing/reflections/nested-reflection-transformed2-expected.txt: Added.
  • platform/chromium-gpu-win/compositing/reflections/nested-reflection-transition-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/reflections/nested-reflection-transition-expected.png: Added.
  • platform/chromium-gpu-win/compositing/reflections/nested-reflection-transition-expected.txt: Added.
  • platform/chromium-gpu-win/compositing/reflections/reflection-on-composited-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/reflections/reflection-on-composited-expected.png: Added.
  • platform/chromium-gpu-win/compositing/reflections/reflection-on-composited-expected.txt: Added.
  • platform/chromium-gpu-win/compositing/reflections/reflection-ordering-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/reflections/reflection-ordering-expected.png: Added.
  • platform/chromium-gpu-win/compositing/reflections/reflection-ordering-expected.txt: Added.
  • platform/chromium-gpu-win/compositing/reflections/reflection-positioning-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/reflections/reflection-positioning-expected.png: Added.
  • platform/chromium-gpu-win/compositing/reflections/reflection-positioning-expected.txt: Added.
  • platform/chromium-gpu-win/compositing/reflections/reflection-positioning2-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/reflections/reflection-positioning2-expected.png: Added.
  • platform/chromium-gpu-win/compositing/reflections/reflection-positioning2-expected.txt: Added.
  • platform/chromium-gpu-win/compositing/reflections/remove-add-reflection-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/reflections/remove-add-reflection-expected.png: Added.
  • platform/chromium-gpu-win/compositing/reflections/simple-composited-reflections-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/reflections/simple-composited-reflections-expected.png: Added.
  • platform/chromium-gpu-win/compositing/reflections/simple-composited-reflections-expected.txt: Added.
  • platform/chromium-gpu-win/compositing/reflections/transform-inside-reflection-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/reflections/transform-inside-reflection-expected.png: Added.
  • platform/chromium-gpu-win/compositing/reflections/transform-inside-reflection-expected.txt: Added.
  • platform/chromium-gpu-win/compositing/repaint/content-into-overflow-expected.txt:
  • platform/chromium-gpu-win/compositing/repaint/overflow-into-content-expected.txt:
  • platform/chromium-gpu-win/compositing/text-on-large-layer-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/text-on-large-layer-expected.png: Added.
  • platform/chromium-gpu-win/compositing/text-on-large-layer-expected.txt: Added.
  • platform/chromium-gpu-win/compositing/tiling/huge-layer-add-remove-child-expected.txt: Added.
  • platform/chromium-gpu-win/compositing/tiling/huge-layer-expected.txt: Added.
  • platform/chromium-gpu-win/compositing/tiling/huge-layer-with-layer-children-expected.txt: Added.
  • platform/chromium-gpu-win/compositing/transitions/scale-transition-no-start-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/transitions/scale-transition-no-start-expected.png: Added.
  • platform/chromium-gpu-win/compositing/transitions/scale-transition-no-start-expected.txt: Added.
  • platform/chromium-gpu-win/compositing/webgl/webgl-reflection-expected.checksum: Added.
  • platform/chromium-gpu-win/compositing/webgl/webgl-reflection-expected.png: Added.
  • platform/chromium-gpu-win/compositing/webgl/webgl-reflection-expected.txt: Added.
  • platform/chromium-gpu-win/fast/canvas/canvas-composite-expected.checksum:
  • platform/chromium-gpu-win/fast/canvas/canvas-composite-expected.png:
  • platform/chromium-gpu-win/fast/canvas/canvas-transform-skewed-expected.checksum:
  • platform/chromium-gpu-win/fast/canvas/canvas-transform-skewed-expected.png:
18:27 Changeset [78006] by zmo@google.com
  • 2 edits in trunk/LayoutTests

2011-02-08 Zhenyao Mo <zmo@google.com>

Unreviewed, test expectations update.

  • platform/chromium/test_expectations.txt
18:14 Changeset [78005] by jorlow@chromium.org
  • 19 edits
    2 adds in trunk

2011-02-07 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Nate Chapin.

Events should propagate through IDBDatabase (for IDBRequest and IDBTransaction)
https://bugs.webkit.org/show_bug.cgi?id=53975

  • storage/indexeddb/objectstore-basics.html:
  • storage/indexeddb/request-event-propagation-expected.txt:
  • storage/indexeddb/request-event-propagation.html:
  • storage/indexeddb/transaction-and-objectstore-calls-expected.txt:
  • storage/indexeddb/transaction-and-objectstore-calls.html:
  • storage/indexeddb/transaction-basics.html:
  • storage/indexeddb/transaction-event-propagation-expected.txt: Added.
  • storage/indexeddb/transaction-event-propagation.html: Added.

2011-02-07 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Nate Chapin.

Events should propagate through IDBDatabase (for IDBRequest and IDBTransaction)
https://bugs.webkit.org/show_bug.cgi?id=53975

The third change in the series of overhauling IndexedDB's event model to match
the spec (at least the version in our heads and bugs).

Test: storage/indexeddb/transaction-event-propagation.html

  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::convertEventTargetToV8Object):
  • dom/Event.cpp: (WebCore::Event::isIDBAbortEvent): (WebCore::Event::isIDBCompleteEvent):
  • dom/Event.h:
  • dom/EventTarget.cpp: (WebCore::EventTarget::toIDBDatabase):
  • dom/EventTarget.h:
  • storage/IDBDatabase.cpp: (WebCore::IDBDatabase::create): (WebCore::IDBDatabase::IDBDatabase): (WebCore::IDBDatabase::scriptExecutionContext): (WebCore::IDBDatabase::eventTargetData): (WebCore::IDBDatabase::ensureEventTargetData):
  • storage/IDBDatabase.h: (WebCore::IDBDatabase::toIDBDatabase): (WebCore::IDBDatabase::refEventTarget): (WebCore::IDBDatabase::derefEventTarget):
  • storage/IDBDatabase.idl:
  • storage/IDBRequest.cpp: (WebCore::IDBRequest::onSuccess): (WebCore::IDBRequest::dispatchEvent):
  • storage/IDBTransaction.cpp: (WebCore::IDBTransaction::backend): (WebCore::IDBTransaction::db): (WebCore::IDBTransaction::objectStore): (WebCore::IDBTransaction::scriptExecutionContext): (WebCore::IDBTransaction::dispatchEvent): (WebCore::IDBTransaction::enqueueEvent):
  • storage/IDBTransaction.h: (WebCore::IDBTransaction::dispatchEvent):
18:10 Changeset [78004] by scherkus@chromium.org
  • 3 edits in branches/chromium/648/Source/WebCore

Merge 77608 - 2011-02-03 Victoria Kirst <vrk@google.com>

Reviewed by James Robinson.

Replaces float literals with uniform values in shader code
so that buggy drivers unable to parse float values in different
locales will not produce a pink video.

[chromium] Fix pink video bug with gpu-acceleration enabled
https://bugs.webkit.org/show_bug.cgi?id=53568

  • platform/graphics/chromium/VideoLayerChromium.cpp: (WebCore::VideoLayerChromium::SharedValues::SharedValues): (WebCore::VideoLayerChromium::drawYUV):
  • platform/graphics/chromium/VideoLayerChromium.h: (WebCore::VideoLayerChromium::SharedValues::signAdjLocation):

TBR=commit-queue@webkit.org
Review URL: http://codereview.chromium.org/6460020

18:08 Changeset [78003] by scherkus@chromium.org
  • 3 edits in branches/chromium/648/Source/WebKit/chromium

Merge 77599 - 2011-02-03 Victoria Kirst <vrk@google.com>

Reviewed by James Robinson.

[chromium] Fix redundant video frame paint on CSS LayerChromium for <video>
https://bugs.webkit.org/show_bug.cgi?id=52868

  • src/WebMediaPlayerClientImpl.cpp: (WebKit::WebMediaPlayerClientImpl::paint): (WebKit::WebMediaPlayerClientImpl::paintCurrentFrameInContext): (WebKit::WebMediaPlayerClientImpl::acceleratedRenderingInUse):
  • src/WebMediaPlayerClientImpl.h:

TBR=commit-queue@webkit.org
Review URL: http://codereview.chromium.org/6465012

18:02 Changeset [78002] by kbr@google.com
  • 1 edit
    2 adds in trunk/Source/WebCore

2011-02-08 Kenneth Russell <kbr@google.com>

Reviewed by James Robinson.

Add cache for GPU-accelerated path processing results
https://bugs.webkit.org/show_bug.cgi?id=45519

Adding a cache which holds the results of processing a path into
interior and exterior triangle meshes, according to the path
rendering algorithm from GPU Gems 3. No tests yet; will be tested
in conjunction with later code.

  • platform/graphics/gpu/LoopBlinnPathCache.cpp: Added. (WebCore::LoopBlinnPathCache::LoopBlinnPathCache): (WebCore::LoopBlinnPathCache::~LoopBlinnPathCache): (WebCore::LoopBlinnPathCache::addVertex): (WebCore::LoopBlinnPathCache::clear): (WebCore::LoopBlinnPathCache::addInteriorVertex): (WebCore::LoopBlinnPathCache::numberOfInteriorEdgeVertices): (WebCore::LoopBlinnPathCache::interiorEdgeVertices): (WebCore::LoopBlinnPathCache::addInteriorEdgeVertex):
  • platform/graphics/gpu/LoopBlinnPathCache.h: Added. (WebCore::LoopBlinnPathCache::numberOfVertices): (WebCore::LoopBlinnPathCache::vertices): (WebCore::LoopBlinnPathCache::texcoords): (WebCore::LoopBlinnPathCache::numberOfInteriorVertices): (WebCore::LoopBlinnPathCache::interiorVertices):
17:55 Changeset [78001] by beidson@apple.com
  • 1 edit in trunk/Source/WebCore/ChangeLog

Nevermind

17:54 Changeset [78000] by beidson@apple.com
  • 1 edit in trunk/Source/WebCore/ChangeLog

80,000

17:46 Changeset [77999] by zmo@google.com
  • 4 edits in trunk/Source/WebCore

2011-02-08 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Rename GraphicsContext3D::WebGLEnumType
https://bugs.webkit.org/show_bug.cgi?id=45708

  • html/canvas/WebGLProgram.cpp: (WebCore::WebGLProgram::getAttachedShader):
  • html/canvas/WebGLProgram.h:
  • platform/graphics/GraphicsContext3D.h:
17:17 Changeset [77998] by dpranke@chromium.org
  • 3 edits in trunk/Tools

2011-02-08 Dirk Pranke <dpranke@chromium.org>

Reviewed by Tony Chang.

new-run-webkit-tests: move the logic that starts and stops the
servers from dump_render_tree_thread into single_test_runner
so that we can reuse it in the new multiprocessing worker class
as well.

https://bugs.webkit.org/show_bug.cgi?id=53840

  • Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
  • Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
17:04 Changeset [77997] by leviw@chromium.org
  • 26 edits in trunk/Source

2011-02-08 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r77980.
http://trac.webkit.org/changeset/77980
https://bugs.webkit.org/show_bug.cgi?id=54043

"Crashes on Windows and Linux..." (Requested by leviw on
#webkit).

  • WebView/WebFrame.mm: (-[WebFrame _caretRectAtNode:offset:affinity:]):
  • WebView/WebFrameInternal.h:
  • WebView/WebTextCompletionController.mm: (-[WebTextCompletionController doCompletion]):

2011-02-08 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r77980.
http://trac.webkit.org/changeset/77980
https://bugs.webkit.org/show_bug.cgi?id=54043

"Crashes on Windows and Linux..." (Requested by leviw on
#webkit).

  • WebCore.exp.in:
  • accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::visiblePositionForTextMarkerData):
  • accessibility/AccessibilityObject.cpp: (WebCore::startOfStyleRange): (WebCore::endOfStyleRange):
  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::visiblePositionForIndex):
  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (objectAndOffsetUnignored):
  • dom/Position.cpp: (WebCore::Position::upstream): (WebCore::Position::downstream):
  • dom/Range.cpp: (WebCore::Range::editingStartPosition):
  • editing/Editor.cpp: (WebCore::Editor::canDeleteRange):
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply):
  • editing/SelectionController.cpp: (WebCore::SelectionController::selectFrameElementInParentIfFullySelected): (WebCore::SelectionController::setSelectedRange):
  • editing/TextIterator.cpp: (WebCore::TextIterator::shouldRepresentNodeOffsetZero):
  • editing/TypingCommand.cpp: (WebCore::TypingCommand::deleteKeyPressed):
  • editing/VisiblePosition.cpp: (WebCore::VisiblePosition::VisiblePosition): (WebCore::VisiblePosition::leftVisuallyDistinctCandidate): (WebCore::VisiblePosition::rightVisuallyDistinctCandidate): (WebCore::VisiblePosition::canonicalPosition): (WebCore::VisiblePosition::characterAfter): (WebCore::VisiblePosition::localCaretRect): (WebCore::makeRange): (WebCore::startVisiblePosition): (WebCore::endVisiblePosition): (WebCore::setStart): (WebCore::setEnd): (WebCore::isFirstVisiblePositionInNode): (WebCore::isLastVisiblePositionInNode):
  • editing/VisiblePosition.h:
  • editing/htmlediting.cpp: (WebCore::firstInSpecialElement): (WebCore::lastInSpecialElement): (WebCore::visiblePositionBeforeNode): (WebCore::visiblePositionAfterNode):
  • editing/visible_units.cpp: (WebCore::startPositionForLine): (WebCore::endPositionForLine): (WebCore::previousLinePosition): (WebCore::nextLinePosition): (WebCore::startOfParagraph): (WebCore::endOfParagraph): (WebCore::endOfBlock): (WebCore::startOfDocument): (WebCore::endOfDocument): (WebCore::logicalStartPositionForLine): (WebCore::logicalEndPositionForLine):
  • page/DOMSelection.cpp: (WebCore::DOMSelection::collapse): (WebCore::DOMSelection::setBaseAndExtent): (WebCore::DOMSelection::setPosition): (WebCore::DOMSelection::extend):
  • page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEventSingleClick):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::createVisiblePosition):
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::visiblePositionForIndex):
  • svg/SVGTextContentElement.cpp: (WebCore::SVGTextContentElement::selectSubString):
17:00 Changeset [77996] by andersca@apple.com
  • 6 edits in trunk/Source/WebKit2

2011-02-08 Anders Carlsson <andersca@apple.com>

Reviewed by Beth Dakin.

Assertion failure !isInAcceleratedCompositingMode() in DrawingAreaProxyImpl::incorporateUpdate()
https://bugs.webkit.org/show_bug.cgi?id=54046
<rdar://problem/8973960>

DrawingAreaImpl::setRootCompositingLayer can be called with a new layer even when already
in accelerated compositing mode. Similarly, it can be called with a null layer even when not
in accelerated compositing mode. Make the drawing area and layer tree host handle both these cases.

  • WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::setRootCompositingLayer): Only call enterAcceleratedCompositingMode if there is no layer tree host, otherwise just call LayerTreeHost::setRootCompositingLayer.

(WebKit::DrawingAreaImpl::setSize):
Add an assert.

(WebKit::DrawingAreaImpl::enterAcceleratedCompositingMode):
Assert that we don't have a layer tree host.

(WebKit::DrawingAreaImpl::exitAcceleratedCompositingMode):
Assert that we do have a layer tree host.

(WebKit::DrawingAreaImpl::display):
If the call to display caused the page to enter accelerated compositing mode, we don't
want to send back an Update message.

  • WebProcess/WebPage/LayerTreeHost.cpp: (WebKit::LayerTreeHost::create):
  • WebProcess/WebPage/LayerTreeHost.h: Create no longer takes a graphics layer.
  • WebProcess/WebPage/mac/LayerTreeHostMac.mm: (WebKit::LayerTreeHostMac::create): (WebKit::LayerTreeHostMac::LayerTreeHostMac): Create no longer takes a graphics layer.


(WebKit::LayerTreeHostMac::setRootCompositingLayer):
Set the new root compositing layer.

16:55 Changeset [77995] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

2011-02-08 Jia Pu <jpu@apple.com>

Reviewed by Darin Adler.

VisibleSelection::setWithoutValidation() should allow caret selection.
https://bugs.webkit.org/show_bug.cgi?id=53943

  • editing/undo/undo-paste-when-caret-is-not-in-range-expected.txt: Added.
  • editing/undo/undo-paste-when-caret-is-not-in-range.html: Added.

2011-02-08 Jia Pu <jpu@apple.com>

Reviewed by Darin Adler.

VisibleSelection::setWithoutValidation() should allow caret selection.
https://bugs.webkit.org/show_bug.cgi?id=53943

Test: editing/undo/undo-paste-when-caret-is-not-in-range.html

  • editing/VisibleSelection.cpp: (WebCore::VisibleSelection::setWithoutValidation):
16:48 Changeset [77994] by dpranke@chromium.org
  • 3 edits
    2 adds in trunk/Tools

2011-02-08 Dirk Pranke <dpranke@chromium.org>

Reviewed by Mihai Parparita.

new-run-webkit-tests: split out thread stack logging code into a sharable module

This patch splits out the code used to find and log thread
stacks from NRWT-specific packages to something generic and
shareable by other python modules. It will be shared in the near
future by the manager_worker_broker module, for example.

https://bugs.webkit.org/show_bug.cgi?id=53656

  • Scripts/webkitpy/common/system/stack_utils.py: Added.
  • Scripts/webkitpy/common/system/stack_utils_unittest.py: Added.
  • Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
  • Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
16:45 Changeset [77993] by mrobinson@webkit.org
  • 7 edits
    2 deletes in trunk/Source/WebCore

2011-02-08 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Remove the last remnants of the Mozilla theme drawing code
https://bugs.webkit.org/show_bug.cgi?id=54035

Remove all Mozilla theme drawing code.

No new tests. This change only removes dead code.

  • GNUmakefile.am: Remove Mozilla files from the source list.
  • platform/gtk/RenderThemeGtk.h: Remove Mozilla-theme-drawing-related methods and add m_colormap to hold the current colormap of the widgets.
  • platform/gtk/RenderThemeGtk2.cpp: Remove Mozilla code. (WebCore::RenderThemeGtk::platformInit): Ditto. (WebCore::RenderThemeGtk::~RenderThemeGtk): Ditto. (WebCore::RenderThemeGtk::gtkContainer): Ditto.
  • platform/gtk/ScrollbarThemeGtk2.cpp: Ditto.
  • platform/gtk/WidgetRenderingContext.cpp: Ditto. (WebCore::WidgetRenderingContext::WidgetRenderingContext): Ditto.
  • platform/gtk/WidgetRenderingContext.h: Ditto.
  • platform/gtk/gtk2drawing.c: Removed.
  • platform/gtk/gtkdrawing.h: Removed.
16:40 Changeset [77992] by dpranke@chromium.org
  • 4 edits in trunk/Tools

2011-02-08 Dirk Pranke <dpranke@chromium.org>

Reviewed by Tony Chang.

new-run-webkit-tests: move a bunch of testing logic out of
dump_render_tree_thread and into single_test_runner so that we
will be able to reuse it in the new multiprocessing worker class as well.

https://bugs.webkit.org/show_bug.cgi?id=53838

  • Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
  • Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
16:37 Changeset [77991] by dpranke@chromium.org
  • 2 edits in trunk/Tools

2011-02-08 Dirk Pranke <dpranke@chromium.org>

Reviewed by Ojan Vafai.

new-run-webkit-tests: remove no longer needed WatchableThread
class.

https://bugs.webkit.org/show_bug.cgi?id=53839

  • Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
16:33 Changeset [77990] by dpranke@chromium.org
  • 1 edit
    2 adds in trunk/Tools

2011-02-08 Dirk Pranke <dpranke@chromium.org>

Reviewed by Tony Chang.

new-run-webkit-tests: add stubs for the Manager objects that
will abstract the concurrency implementation (inline / threads /
processes). These classes do nothing yet and are not wired up to
anything.

https://bugs.webkit.org/show_bug.cgi?id=53477

  • Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py: Added.
  • Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py: Added.
16:31 Changeset [77989] by dpranke@chromium.org
  • 1 edit
    2 adds in trunk/Tools

2011-02-08 Dirk Pranke <dpranke@chromium.org>

Reviewed by Tony Chang.

new-run-webkit-tests: add simplified message broker for new-style
messaging. This change adds a very simple message broker that
will be used to shuttle messages between the TestRunner2 manager
thread and the Worker threads. For now the class is not used by
anything, but the eventual usage can be seen in the patches
attached to bug 49566.

https://bugs.webkit.org/show_bug.cgi?id=53158

  • Scripts/webkitpy/layout_tests/layout_package/message_broker2.py: Added.
  • Scripts/webkitpy/layout_tests/layout_package/message_broker2_unittest.py: Added.
16:25 Changeset [77988] by yael.aharon@nokia.com
  • 3 edits
    5 adds in trunk

2011-02-08 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Antti Koivisto.

Crash when logging into gmail.com with frame flattening turned on.
https://bugs.webkit.org/show_bug.cgi?id=52449

  • fast/frames/flattening/iframe-flattening-crash-expected.txt: Added.
  • fast/frames/flattening/iframe-flattening-crash.html: Added.
  • fast/frames/flattening/iframe-flattening-selection-crash-expected.txt: Added.
  • fast/frames/flattening/iframe-flattening-selection-crash.html: Added.
  • fast/frames/flattening/resources/iframe-flattening-crash.html: Added.

2011-02-08 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Antti Koivisto.

Crash when logging into gmail.com with frame flattening turned on.
https://bugs.webkit.org/show_bug.cgi?id=52449

Frame flattening algorithm requires that layout always starts from the main frame, since layout of
subframes impacts the layout of their parents.
There are places in the code that call view->layout() not on the main frame.
Instead of changing all the callsites, I changed FrameView::layout()
to force layout from the main frame if frame flattening is enabled.
In addition, postLayoutTasks can trigger relayout, so make it use the timer even more.
Move the call to SelectionController::updateAppearance() to performPostLayoutTasks(),
because calling the from layout() leads to a crash in pages that have a selection in an iframe.

Tests: fast/frames/flattening/iframe-flattening-crash.html

fast/frames/flattening/iframe-flattening-selection-crash.html

  • page/FrameView.cpp: (WebCore::FrameView::layout): (WebCore::FrameView::performPostLayoutTasks):
16:25 Changeset [77987] by abarth@webkit.org
  • 2 edits in trunk/Tools

2011-02-08 Adam Barth <abarth@webkit.org>

Reviewed by Dimitri Glazkov.

chromium-win builder shouldn't run python or perl tests
https://bugs.webkit.org/show_bug.cgi?id=54032

These tests don't pass on this builder because the builder isn't
running in cygwin. There isn't really any point in running them and
making the bot red forever.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:
16:07 Changeset [77986] by aestes@apple.com
  • 2 edits in trunk

Add Radar URLs to a recent ChangeLog entry.

15:59 Changeset [77985] by aestes@apple.com
  • 5 edits in trunk

2011-02-08 Andy Estes <aestes@apple.com>

Reviewed by Darin Adler.

REGRESSION (r76301): 'plaintext-only' must be a supported contentEditable mode.
https://bugs.webkit.org/show_bug.cgi?id=54041

  • html/HTMLElement.cpp: (WebCore::HTMLElement::setContentEditable): Setting the contentEditable attribute to 'plaintext-only' should not throw an exception.

2011-02-08 Andy Estes <aestes@apple.com>

Reviewed by Darin Adler.

REGRESSION (r76301): 'plaintext-only' must be a supported contentEditable mode.
https://bugs.webkit.org/show_bug.cgi?id=54041

  • fast/dom/HTMLElement/set-value-caseinsensitive-expected.txt:
  • fast/dom/HTMLElement/set-value-caseinsensitive.html:
15:51 Changeset [77984] by mitz@apple.com
  • 3 edits in trunk/Source/WebCore

RenderRubyRun::m_beingDestroyed is redundant
https://bugs.webkit.org/show_bug.cgi?id=54042

Reviewed by Simon Fraser.

  • rendering/RenderRubyRun.cpp:

(WebCore::RenderRubyRun::RenderRubyRun): Removed intialization of m_beingDestroyed.
(WebCore::RenderRubyRun::removeChild): Use the base class beingDestroyed().

  • rendering/RenderRubyRun.h:
15:34 Changeset [77983] by aroben@apple.com
  • 3 edits in trunk/Source/WebKit2

Implement WorkQueue::scheduleWorkAfterDelay on Windows

Each WorkQueue now owns its own timer queue. When scheduleWorkAfterDelay is called, we
create a timer-queue timer with the given delay. When the timer fires, we schedule the work
on the queue and clean up the timer.

Fixes <http://webkit.org/b/54040> <rdar://problem/8974230> Web process sticks around forever
if it's hung when UI process goes away

Reviewed by Anders Carlsson.

  • Platform/WorkQueue.h: Added timerCallback and m_timerQueue.
  • Platform/win/WorkQueueWin.cpp:

(WorkQueue::platformInitialize): Initialize m_timerQueue.
(WorkQueue::platformInvalidate): Clean up m_timerQueue.
(TimerContext::TimerContext): Added this helper object to hold the context needed by the
timer callback.
(WorkQueue::timerCallback): Added. Schedules the WorkItem on the WorkQueue and cleans up the
timer.
(WorkQueue::scheduleWorkAfterDelay): Create a timer-queue timer on our timer queue that will
fire after the given delay. Pass a new TimerContext object to the timer callback that
contains the information it needs.

15:15 Changeset [77982] by mrobinson@webkit.org
  • 4 edits in trunk/LayoutTests

2011-02-08 Martin Robinson <mrobinson@igalia.com>

Unskip a series of tests that seem to be passing locally. Also unskip
a test that was mistakenly reskipped in r77979 due to what looks like a
merge issue. Rebaseline two of these test which have results originating
from long ago.

  • platform/gtk/Skipped: Unskip some tests.
  • platform/gtk/editing/selection/14971-expected.txt:
  • platform/gtk/editing/selection/inline-closest-leaf-child-expected.txt:
15:14 Changeset [77981] by andersca@apple.com
  • 5 edits in trunk/Source/WebKit2

2011-02-08 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Rename PluginProcess::initializeConnection to PluginProcess::initialize
https://bugs.webkit.org/show_bug.cgi?id=54039

  • PluginProcess/PluginProcess.cpp: (WebKit::PluginProcess::initialize):
  • PluginProcess/PluginProcess.h:
  • PluginProcess/mac/PluginProcessMainMac.mm: (WebKit::PluginProcessMain):
  • WebProcess/WebProcess.h:
15:13 Changeset [77980] by leviw@chromium.org
  • 26 edits in trunk/Source

2011-02-08 Levi Weintraub <leviw@chromium.org>

Reviewed by Ryosuke Niwa.

Stop instantiating legacy editing Positions in VisiblePosition
https://bugs.webkit.org/show_bug.cgi?id=52919

Changing usage of legacy VisiblePosition constructor. Since we were dealing
with positions from DOM Ranges, we're guaranteed a parent-anchored position.

  • WebView/WebFrame.mm: (-[WebFrame _caretRectAtPosition:affinity:]):
  • WebView/WebFrameInternal.h:
  • WebView/WebTextCompletionController.mm: (-[WebTextCompletionController doCompletion]):

2011-02-08 Levi Weintraub <leviw@chromium.org>

Reviewed by Ryosuke Niwa.

Stop instantiating legacy editing Positions in VisiblePosition
https://bugs.webkit.org/show_bug.cgi?id=52919

Changing VisiblePosition completely away from legacy positions.

No new tests since this is functionaly equivalent.

  • WebCore.exp.in: Removing the legacy VisiblePosition constructor and adding the PositionIsOffsetInAnchor symbol. If we must create VisiblePositions outside of WebCore, they should be parent anchored.
  • accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::visiblePositionForTextMarkerData):
  • accessibility/AccessibilityObject.cpp: (WebCore::startOfStyleRange): (WebCore::endOfStyleRange):
  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::visiblePositionForIndex):
  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (objectAndOffsetUnignored):
  • dom/Position.cpp: (WebCore::Position::upstream): Fixed to correctly respect PositionIsAfterAnchor (WebCore::Position::downstream): ditto
  • dom/Range.cpp: (WebCore::Range::editingStartPosition):
  • editing/Editor.cpp: (WebCore::Editor::canDeleteRange):
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply):
  • editing/SelectionController.cpp: (WebCore::SelectionController::selectFrameElementInParentIfFullySelected): (WebCore::SelectionController::setSelectedRange):
  • editing/TextIterator.cpp: (WebCore::TextIterator::shouldRepresentNodeOffsetZero):
  • editing/TypingCommand.cpp: (WebCore::TypingCommand::deleteKeyPressed):
  • editing/VisiblePosition.cpp: (WebCore::VisiblePosition::leftVisuallyDistinctCandidate): (WebCore::VisiblePosition::rightVisuallyDistinctCandidate): (WebCore::VisiblePosition::canonicalPosition): (WebCore::VisiblePosition::characterAfter): (WebCore::VisiblePosition::localCaretRect): (WebCore::makeRange): (WebCore::startVisiblePosition): (WebCore::endVisiblePosition): (WebCore::setStart): (WebCore::setEnd): (WebCore::isFirstVisiblePositionInNode): (WebCore::isLastVisiblePositionInNode):
  • editing/VisiblePosition.h: (WebCore::VisiblePosition::VisiblePosition):
  • editing/htmlediting.cpp: (WebCore::firstInSpecialElement): (WebCore::lastInSpecialElement): (WebCore::visiblePositionBeforeNode): (WebCore::visiblePositionAfterNode):
  • editing/visible_units.cpp: (WebCore::startPositionForLine): (WebCore::endPositionForLine): (WebCore::previousLinePosition): (WebCore::nextLinePosition): (WebCore::startOfParagraph): (WebCore::endOfParagraph): (WebCore::endOfBlock): (WebCore::startOfDocument): (WebCore::endOfDocument): (WebCore::logicalStartPositionForLine): (WebCore::logicalEndPositionForLine):
  • page/DOMSelection.cpp: (WebCore::DOMSelection::collapse): (WebCore::DOMSelection::setBaseAndExtent): (WebCore::DOMSelection::setPosition): (WebCore::DOMSelection::extend):
  • page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEventSingleClick):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::createVisiblePosition):
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::visiblePositionForIndex):
  • svg/SVGTextContentElement.cpp: (WebCore::SVGTextContentElement::selectSubString):
15:09 Changeset [77979] by msaboff@apple.com
  • 5 edits in trunk

2011-02-08 Michael Saboff <msaboff@apple.com>

JSC::Bindings m_rootObject->isValid() assert fails when running layout tests
https://bugs.webkit.org/show_bug.cgi?id=53716

Changed ASSERT to be an if for the case where the RuntimeObject was
GC'ed before RootObject::invalidate is called. In that case there is
no need to remove the RuntimeObject from the RootObject. The isValid()
call will be false in this case, but the RuntimeObject has already
been removed from the RootObject. Added similar defensive code
in RootObject::removeRuntimeObject().

  • bridge/jsc/BridgeJSC.cpp: (JSC::Bindings::Instance::willDestroyRuntimeObject):
  • bridge/runtime_root.cpp: (JSC::Bindings::RootObject::removeRuntimeObject):

2011-02-08 Michael Saboff <msaboff@apple.com>

Reviewed by Darin Adler.

JSC::Bindings m_rootObject->isValid() assert fails when running layout tests
https://bugs.webkit.org/show_bug.cgi?id=53716

Re-enabled tests that are fixed with the corresponding change in
WebCore.

  • platform/gtk/Skipped:
15:07 Changeset [77978] by beidson@apple.com
  • 9 edits in trunk

<rdar://problem/8972913> and https://bugs.webkit.org/show_bug.cgi?id=54036
didChangeBackForwardList should include some context about what changed

Reviewed by Darin Adler.

Source/WebKit2:

Update the implementation of this API to include the new item (if any) and removed items (if any):

  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebLoaderClient.cpp:

(WebKit::WebLoaderClient::didChangeBackForwardList):

  • UIProcess/WebLoaderClient.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didChangeBackForwardList):

  • UIProcess/WebPageProxy.h:

Have WebBackForwardList pass the new items and/or removed items when calling the notifier:

  • UIProcess/WebBackForwardList.cpp:

(WebKit::WebBackForwardList::addItem):
(WebKit::WebBackForwardList::goToItem):
(WebKit::WebBackForwardList::clear):

Tools:

  • MiniBrowser/mac/BrowserWindowController.m:

(didChangeBackForwardList):

15:03 Changeset [77977] by ggaren@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

2011-02-08 Geoffrey Garen <ggaren@apple.com>

Reviewed by Darin Adler.

Give each MarkedBlock enough mark bits to cover the whole block
https://bugs.webkit.org/show_bug.cgi?id=54029


SunSpider reports no change.

This simplifies access to mark bits, since any cell-aligned pointer
into a block now has a valid mark bit to test.


  • runtime/MarkedBlock.h: Changed CELLS_PER_BLOCK to account for the extra mark bits. This happens not to change its actual value. (JSC::MarkedBlock::cellNumber): (JSC::MarkedBlock::isMarked): (JSC::MarkedBlock::testAndSetMarked): (JSC::MarkedBlock::setMarked): Changed const JSCell* to const void* to remove a cast from our caller, and to more accurately reflect the fact that MarkedBlock is agnostic about the types pointed to by the pointers you pass to it.

(JSC::MarkedBlock::isPossibleCell): Removed a null check. We now consider
the null pointer to be a possible cell with a 0 (impossible) block. This
removes a null check from marking.

  • runtime/MarkedSpace.cpp:
  • runtime/MarkedSpace.h: (JSC::MarkedSpace::contains): Simplified the contains check, and inlined the whole thing, now that it's so simple.
15:02 Changeset [77976] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Sandbox violations visiting MobileMe.
<rdar://problem/8961330>

Reviewed by Anders Carlsson.

  • WebProcess/com.apple.WebProcess.sb:
14:52 Changeset [77975] by andersca@apple.com
  • 5 edits in trunk/Source/WebKit2

2011-02-08 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Rename PluginProcess::initialize to PluginProcess::initializePluginProcess
https://bugs.webkit.org/show_bug.cgi?id=54037

Rename PluginProcess::initialize to PluginProcess::initializePluginProcess to better
match the WebProcess initialization code, in preparation of sharing more code.

  • PluginProcess/PluginProcess.cpp: (WebKit::PluginProcess::initializePluginProcess):
  • PluginProcess/PluginProcess.h:
  • PluginProcess/PluginProcess.messages.in:
  • UIProcess/Plugins/PluginProcessProxy.cpp: (WebKit::PluginProcessProxy::didFinishLaunching):
14:48 Changeset [77974] by weinig@apple.com
  • 26 edits
    6 adds in trunk

WK2: Add ability to pass context to policy delegate methods
https://bugs.webkit.org/show_bug.cgi?id=54031

Reviewed by Anders Carlsson.

Source/WebKit2:

  • Platform/CoreIPC/HandleMessage.h:

(CoreIPC::callMemberFunction):
(CoreIPC::handleMessageVariadic):

  • Scripts/webkit2/messages.py:

Add ability to pass variadic messages to sync messages.

  • Shared/API/c/WKBase.h:
  • Shared/APIObject.h:

Add WKBundleNavigation type.

  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::decidePolicyForNavigationAction):
(WebKit::WebPageProxy::decidePolicyForNewWindowAction):
(WebKit::WebPageProxy::decidePolicyForMIMEType):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/WebPolicyClient.cpp:

(WebKit::WebPolicyClient::decidePolicyForNavigationAction):
(WebKit::WebPolicyClient::decidePolicyForNewWindowAction):
(WebKit::WebPolicyClient::decidePolicyForMIMEType):

  • UIProcess/WebPolicyClient.h:

Update policy client for new data.

  • WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:
  • WebProcess/InjectedBundle/API/c/WKBundleNavigationAction.cpp: Added.

(WKBundleNavigationActionGetTypeID):
(WKBundleNavigationActionGetNavigationType):
(WKBundleNavigationActionGetEventModifiers):
(WKBundleNavigationActionGetEventMouseButton):
(WKBundleNavigationActionCopyHitTestResult):
(WKBundleNavigationActionCopyFormElement):

  • WebProcess/InjectedBundle/API/c/WKBundleNavigationAction.h: Added.
  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageSetPolicyClient):

  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/InjectedBundle/InjectedBundleNavigationAction.cpp: Added.

(WebKit::mouseEventForNavigationAction):
(WebKit::mouseButtonForMouseEvent):
(WebKit::InjectedBundleNavigationAction::modifiersForNavigationAction):
(WebKit::InjectedBundleNavigationAction::mouseButtonForNavigationAction):
(WebKit::InjectedBundleNavigationAction::create):
(WebKit::InjectedBundleNavigationAction::InjectedBundleNavigationAction):

  • WebProcess/InjectedBundle/InjectedBundleNavigationAction.h: Added.

(WebKit::InjectedBundleNavigationAction::navigationType):
(WebKit::InjectedBundleNavigationAction::modifiers):
(WebKit::InjectedBundleNavigationAction::mouseButton):
(WebKit::InjectedBundleNavigationAction::hitTestResult):
(WebKit::InjectedBundleNavigationAction::formElement):
(WebKit::InjectedBundleNavigationAction::type):

  • WebProcess/InjectedBundle/InjectedBundlePagePolicyClient.cpp: Added.

(WebKit::InjectedBundlePagePolicyClient::decidePolicyForNavigationAction):
(WebKit::InjectedBundlePagePolicyClient::decidePolicyForNewWindowAction):
(WebKit::InjectedBundlePagePolicyClient::decidePolicyForMIMEType):

  • WebProcess/InjectedBundle/InjectedBundlePagePolicyClient.h: Added.
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::createWindow):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForMIMEType):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::initializeInjectedBundlePolicyClient):

  • WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::injectedBundlePolicyClient):
Pipe the policy client through the bundle to allow setting user data.

  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:
  • win/WebKit2Generated.make:

Add new files.

Tools:

  • MiniBrowser/mac/BrowserWindowController.m:

(decidePolicyForNavigationAction):
(decidePolicyForNewWindowAction):
(decidePolicyForMIMEType):

  • TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:

(TestWebKitAPI::decidePolicyForNavigationAction):
(TestWebKitAPI::decidePolicyForNewWindowAction):
(TestWebKitAPI::decidePolicyForMIMEType):
Update policy client for new API.

14:33 Changeset [77973] by xji@chromium.org
  • 4 edits
    1 delete in trunk/LayoutTests

2011-02-08 Xiaomei Ji <xji@chromium.org>

Unreviewed.

Rebaseline for chromium-mac after r77952.
Not sure why the previous rebase did not get the right results.
https://bugs.webkit.org/show_bug.cgi?id=54026

  • platform/chromium-mac/fast/text/international/pop-up-button-text-alignment-and-direction-expected.checksum:
  • platform/chromium-mac/fast/text/international/pop-up-button-text-alignment-and-direction-expected.png:
  • platform/chromium-mac/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
14:31 Changeset [77972] by dbates@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

2011-02-08 Daniel Bates <dbates@rim.com>

Rubber-stamped by Martin Robinson.

Rename enum ProtectionSeting [sic] to ProtectionSetting.

  • jit/ExecutableAllocator.cpp: (JSC::ExecutableAllocator::reprotectRegion):
  • jit/ExecutableAllocator.h:
14:25 Changeset [77971] by mrobinson@webkit.org
  • 10 edits in trunk

2011-02-08 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] DRT needs an implementation of LayoutTestController.setIconDatabaseEnabled
https://bugs.webkit.org/show_bug.cgi?id=54033

  • platform/gtk/Skipped: Unskip a test that is now passing.

2011-02-08 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] DRT needs an implementation of LayoutTestController.setIconDatabaseEnabled
https://bugs.webkit.org/show_bug.cgi?id=54033

Add a DumpRenderTreeSupportGtk method for turning the icon database on and off.
This is a likely candidate for a new API point.

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp: (DumpRenderTreeSupportGtk::setIconDatabaseEnabled): Added.
  • WebCoreSupport/DumpRenderTreeSupportGtk.h:
  • webkit/webkitglobals.cpp: (webkitInit): Call setIconDatabaseEnabled(true) on startup, instead of initializing the database manually. (WebKit::setIconDatabaseEnabled): Added.
  • webkit/webkitglobalsprivate.h: Added declarations.

2011-02-08 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] DRT needs an implementation of LayoutTestController.setIconDatabaseEnabled
https://bugs.webkit.org/show_bug.cgi?id=54033

Add an implementation of LayoutTestController.setIconDatabaseEnabled that just
call DumpRenderTreeSupportGtk. Turn off the icon database between tests.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues): Turn off the icon database.
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setIconDatabaseEnabled): Call the appropriate DumpRenderTreeSupportGtk method.
14:11 Changeset [77970] by bdakin@apple.com
  • 3 edits in trunk/Source/WebCore

Fix for <rdar://problem/8953365> CrashTracer: 14
crashes in WebProcess at com.apple.WebCore:
-[ScrollKnobAnimation setCurrentProgress:] + 258

Reviewed by Darin Adler.

This crash seems to happen when the animation is running
and a window is closed. If the ScrollAnimator is destroyed,
delegate calls for the animation can still run, so we have
to make sure we inform the delegates when the ScrollAnimator
is gone, and then we have to null-check it before we do
anything with it.

Remove scrollbarPainterDelegate() since it's not used anymore.

  • platform/mac/ScrollAnimatorMac.h:
  • platform/mac/ScrollAnimatorMac.mm:


Add null-checks for _animator
(-[ScrollbarPartAnimation setCurrentProgress:]):
(-[ScrollbarPartAnimation scrollAnimatorDestroyed]):
(-[ScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:]):
(-[ScrollbarPainterDelegate scrollerImp:animateTrackAlphaTo:duration:]):
(-[ScrollbarPainterDelegate scrollerImp:overlayScrollerStateChangedTo:]):

New function to inform the delegates that the ScrollAnimator
is being destroyed.
(-[ScrollbarPainterDelegate scrollAnimatorDestroyed]):
(WebCore::ScrollAnimatorMac::~ScrollAnimatorMac):

14:00 Changeset [77969] by zmo@google.com
  • 2 edits in trunk/LayoutTests

2011-02-08 Zhenyao Mo <zmo@google.com>

Unreviewed, typo fix.

  • platform/chromium/test_expectations.txt
13:51 Changeset [77968] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-02-08 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Crash calling -setFrame:andScrollBy: in windowDidResize
https://bugs.webkit.org/show_bug.cgi?id=54030
<rdar://problem/8969760>

  • Platform/mac/SharedMemoryMac.cpp: (WebKit::SharedMemory::create): Assert that size is not zero here; we never want to try to create shared memory with a zero size.


  • WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::setSize): Always invalidate the entire visible page when resizing.
13:09 Changeset [77967] by mrobinson@webkit.org
  • 2 edits in trunk/LayoutTests

2011-02-08 Martin Robinson <mrobinson@igalia.com>

Unskip some inspector tests that are passing locally. The bugs are
missing test diffs, so we can either reskip them and get more information
or have passing tests. Classify another failure.

  • platform/gtk/Skipped: Clean up the skipped list.
13:06 Changeset [77966] by zmo@google.com
  • 2 edits in trunk/LayoutTests

2011-02-08 Zhenyao Mo <zmo@google.com>

Unreviewed, test expectations update.

  • platform/chromium/test_expectations.txt
12:54 Changeset [77965] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

2011-02-08 Kenji Imasaki <imasaki@chromium.org>

Reviewed by Jian Li.

[Chromium] Remove non-Flaky media tests from test expectation file
https://bugs.webkit.org/show_bug.cgi?id=54021

  • platform/chromium/test_expectations.txt:
12:19 Changeset [77964] by xji@chromium.org
  • 2 edits in trunk/LayoutTests

2011-02-08 Xiaomei Ji <xji@chromium.org>

Unreviewed. Fix typo in rebaseline in r77961.

  • platform/mac-leopard/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt:
12:17 Changeset [77963] by abarth@webkit.org
  • 29 edits in trunk/Source

2011-02-08 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Remove orphan code from old parser
https://bugs.webkit.org/show_bug.cgi?id=53984

This code appears to be unused.

  • html/HTMLParserErrorCodes.cpp:
  • html/HTMLParserErrorCodes.h:
  • html/HTMLParserQuirks.h:
  • loader/EmptyClients.h:
  • page/ChromeClient.h:

2011-02-08 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Remove orphan code from old parser
https://bugs.webkit.org/show_bug.cgi?id=53984

  • src/ChromeClientImpl.h:

2011-02-08 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Remove orphan code from old parser
https://bugs.webkit.org/show_bug.cgi?id=53984

  • WebCoreSupport/ChromeClientEfl.h:

2011-02-08 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Remove orphan code from old parser
https://bugs.webkit.org/show_bug.cgi?id=53984

  • WebCoreSupport/ChromeClientGtk.h:

2011-02-08 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Remove orphan code from old parser
https://bugs.webkit.org/show_bug.cgi?id=53984

  • WebCoreSupport/ChromeClientHaiku.cpp:
  • WebCoreSupport/ChromeClientHaiku.h:

2011-02-08 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Remove orphan code from old parser
https://bugs.webkit.org/show_bug.cgi?id=53984

  • WebCoreSupport/WebChromeClient.h:

2011-02-08 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Remove orphan code from old parser
https://bugs.webkit.org/show_bug.cgi?id=53984

  • WebCoreSupport/ChromeClientQt.h:

2011-02-08 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Remove orphan code from old parser
https://bugs.webkit.org/show_bug.cgi?id=53984

  • WebCoreSupport/WebChromeClient.h:

2011-02-08 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Remove orphan code from old parser
https://bugs.webkit.org/show_bug.cgi?id=53984

  • WebCoreSupport/ChromeClientWinCE.cpp:
  • WebCoreSupport/ChromeClientWinCE.h:

2011-02-08 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Remove orphan code from old parser
https://bugs.webkit.org/show_bug.cgi?id=53984

  • WebKitSupport/ChromeClientWx.h:

2011-02-08 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Remove orphan code from old parser
https://bugs.webkit.org/show_bug.cgi?id=53984

  • WebProcess/WebCoreSupport/WebChromeClient.cpp
  • WebProcess/WebCoreSupport/WebChromeClient.h
11:36 Changeset [77962] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-02-08 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

UI process crashes if web process crashes while web inspector is focused
https://bugs.webkit.org/show_bug.cgi?id=53965
<rdar://problem/8961633>

Make sure to close the web inspector web page proxy before calling platformClose, since
platformClose can cause the web page proxy to try to send messages (such as SetActive)
to the web process while it's in a bad state.

The original fix, http://trac.webkit.org/changeset/77866, put the call to m_page->close() in
WebInspectorProxy::didClose, which was wrong and lead to crashes. The right place to close the page
is in WebInspectorProxy::invalidate.

  • UIProcess/WebInspectorProxy.cpp: (WebKit::WebInspectorProxy::invalidate):
11:25 Changeset [77961] by xji@chromium.org
  • 2 edits
    11 adds in trunk/LayoutTests

2011-02-08 Xiaomei Ji <xji@chromium.org>

Unreviewed.

Rebaseline after r77952.

  • platform/chromium-linux/fast/text/international/pop-up-button-text-alignment-and-direction-expected.checksum: Added.
  • platform/chromium-linux/fast/text/international/pop-up-button-text-alignment-and-direction-expected.png: Added.
  • platform/chromium-linux/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt: Added.
  • platform/chromium-mac/fast/text/international/pop-up-button-text-alignment-and-direction-expected.checksum: Added.
  • platform/chromium-mac/fast/text/international/pop-up-button-text-alignment-and-direction-expected.png: Added.
  • platform/chromium-mac/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt: Added.
  • platform/chromium-win/fast/text/international/pop-up-button-text-alignment-and-direction-expected.checksum: Added.
  • platform/chromium-win/fast/text/international/pop-up-button-text-alignment-and-direction-expected.png: Added.
  • platform/chromium-win/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
  • platform/mac-leopard/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt: Added.
  • platform/win/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt: Added.
11:15 Changeset [77960] by mrobinson@webkit.org
  • 7 edits in trunk/Source/WebCore

2011-02-08 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] Move scrollbar rendering out of gtk2drawing.c
https://bugs.webkit.org/show_bug.cgi?id=52836

Replace gtk2drawing.c scrollbar rendering with our own version. This
is the last use of the Mozilla theme drawing code.

No new tests. This should not change the rendering of the default
theme.

  • platform/gtk/GtkVersioning.h: Add some more backported allocation setters.
  • platform/gtk/RenderThemeGtk.h: Add a getter for the scrollbar widgets.
  • platform/gtk/RenderThemeGtk2.cpp: Initialize and add getters for scrollbar widgets. (WebCore::RenderThemeGtk::platformInit): Ditto. (WebCore::RenderThemeGtk::gtkHScrollbar): Ditto. (WebCore::RenderThemeGtk::gtkVScrollbar): Ditto.
  • platform/gtk/ScrollbarThemeGtk.cpp: (WebCore::ScrollbarThemeGtk::paint): We only repaint the scrolled window background if we are repainting a button or the thumb. In that case also repaint the track rect.
  • platform/gtk/ScrollbarThemeGtk2.cpp: Port to WidgetRenderingContext. (WebCore::ScrollbarThemeGtk::ScrollbarThemeGtk): Ditto. (WebCore::ScrollbarThemeGtk::updateThemeProperties): Ditto. (WebCore::getWidgetForScrollbar): Ditto. (WebCore::ScrollbarThemeGtk::paintTrackBackground): Ditto. (WebCore::ScrollbarThemeGtk::paintScrollbarBackground): Ditto. (WebCore::ScrollbarThemeGtk::paintThumb): Ditto. (WebCore::ScrollbarThemeGtk::paintButton): Ditto.
  • platform/gtk/WidgetRenderingContext.cpp: Ditto. (WebCore::WidgetRenderingContext::gtkPaintBox): Added an option which also adjusts a widget allocation according to the paint rect. This is necessary to properly draw scrollbar buttons.
  • platform/gtk/WidgetRenderingContext.h: Ditto.
11:12 Changeset [77959] by zmo@google.com
  • 2 edits in trunk/LayoutTests

2011-02-08 Zhenyao Mo < zmo@google.com>

Unreviewed, test expectations update.

  • LauoutTests/platform/chromium/test_expectations.txt
10:57 Changeset [77958] by simon.fraser@apple.com
  • 3 edits
    4 adds in trunk

2011-02-08 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

Inset shadow with large offset renders incorrectly
https://bugs.webkit.org/show_bug.cgi?id=53882

Fix an issue with inset shadows, when the shadow offset
was larger than the box size. In this case we'd fail to
fill the box with the shadow color.

Test: fast/box-shadow/inset-shadow-large-offset.html

  • rendering/RenderBoxModelObject.cpp: (WebCore::areaCastingShadowInHole): Return a rect that covers the area which contributes to the inset shadow.

(WebCore::RenderBoxModelObject::paintBoxShadow): Use areaCastingShadowInHole()
to compute the outerRect.

10:56 Changeset [77957] by tony@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-02-08 Tony Chang <tony@chromium.org>

Unreviewed, build fix for clobber builds of DRT on mac/linux.

This file moved in chromium r73530 and this path wasn't changed.

  • WebKit.gyp:
10:47 Changeset [77956] by zmo@google.com
  • 5 edits in trunk

2011-02-08 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

drawElements should check if a buffer is bound to ELEMENT_ARRAY_BUFFER
https://bugs.webkit.org/show_bug.cgi?id=54017

  • fast/canvas/webgl/draw-elements-out-of-bounds-expected.txt:
  • fast/canvas/webgl/draw-elements-out-of-bounds.html:

2011-02-08 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

drawElements should check if a buffer is bound to ELEMENT_ARRAY_BUFFER
https://bugs.webkit.org/show_bug.cgi?id=54017

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::drawElements):
10:37 Changeset [77955] by xji@chromium.org
  • 4 edits in trunk/LayoutTests

2011-02-08 Xiaomei Ji <xji@chromium.org>

Unreviewed. after r77952,
skip pop-up-button-text-alignment-and-direction.html in qt and gtk as bidi-menulist.html.
set it as expect to fail in chromium.

  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/qt/Skipped:
10:35 Changeset [77954] by dglazkov@chromium.org
  • 12 edits in trunk/Source/WebCore

2011-01-28 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed by Darin Adler.

Change the rest of HTMLMediaElement shadow DOM parts to use shadowPseudoId.
https://bugs.webkit.org/show_bug.cgi?id=53190

This is the second part of refactoring the HTMLMediaElement to use new
shadow DOM. The changes are mainly mechanical, except for needing to
add a new method to RenderTheme, which indicates whether or not status
display is being used by it. Previously, we relied on existence of a cached
pseudo style.

Refactoring, covered by existing tests.

  • css/CSSSelector.cpp: (WebCore::CSSSelector::pseudoId): Removed now-unused enum values. (WebCore::nameToPseudoTypeMap): Ditto. (WebCore::CSSSelector::extractPseudoType): Ditto.
  • css/CSSSelector.h: Ditto.
  • html/shadow/MediaControls.cpp: (WebCore::MediaControls::createPanel): Changed to use the newly-added MediaControlPanelElement. (WebCore::MediaControls::createCurrentTimeDisplay): Changed to use the newly-added

MediaControlCurrentTimeDisplayElement.

(WebCore::MediaControls::createTimeRemainingDisplay): Changed to use the newly-added

MediaControlTimeRemainingDisplayElement.

  • rendering/MediaControlElements.cpp: (WebCore::MediaControlShadowRootElement::updateStyle): Changed to use the

standard style resolution.

(WebCore::MediaControlShadowRootElement::shadowPseudoId): Added.
(WebCore::MediaControlElement::MediaControlElement): Removed the switch statement

that is no longer necessary.

(WebCore::MediaControlElement::styleForElement): Changed to use the standard

style resolution.

(WebCore::MediaControlPanelElement::MediaControlPanelElement): Added.
(WebCore::MediaControlPanelElement::create): Added.
(WebCore::MediaControlPanelElement::displayType): Added.
(WebCore::MediaControlPanelElement::shadowPseudoId): Added.
(WebCore::MediaControlTimelineContainerElement::MediaControlTimelineContainerElement):

Removed PseudoId constructor arg.

(WebCore::MediaControlTimelineContainerElement::rendererIsNeeded):

Changed to use the newly-plumbed usesMediaControlStatusDisplay helper.

(WebCore::MediaControlTimelineContainerElement::displayType): Added.
(WebCore::MediaControlTimelineContainerElement::shadowPseudoId): Added.
(WebCore::MediaControlVolumeSliderContainerElement::MediaControlVolumeSliderContainerElement):

Removed PseudoId constructor arg.

(WebCore::MediaControlVolumeSliderContainerElement::displayType): Added.
(WebCore::MediaControlVolumeSliderContainerElement::shadowPseudoId): Added.
(WebCore::MediaControlStatusDisplayElement::MediaControlStatusDisplayElement):

Removed PseudoId constructor arg.

(WebCore::MediaControlStatusDisplayElement::rendererIsNeeded): Changed to

use the newly-plumbed usesMediaControlStatusDisplay helper.

(WebCore::MediaControlStatusDisplayElement::displayType): Added.
(WebCore::MediaControlStatusDisplayElement::shadowPseudoId): Added.
(WebCore::MediaControlTimeDisplayElement::MediaControlTimeDisplayElement):

Removed PseudoId constructor arg.

(WebCore::MediaControlTimeRemainingDisplayElement::create): Added.
(WebCore::MediaControlTimeRemainingDisplayElement::MediaControlTimeRemainingDisplayElement): Added.
(WebCore::MediaControlTimeRemainingDisplayElement::displayType): Added.
(WebCore::MediaControlTimeRemainingDisplayElement::shadowPseudoId): Added.
(WebCore::MediaControlCurrentTimeDisplayElement::create): Added.
(WebCore::MediaControlCurrentTimeDisplayElement::MediaControlCurrentTimeDisplayElement): Added.
(WebCore::MediaControlCurrentTimeDisplayElement::displayType): Added.
(WebCore::MediaControlCurrentTimeDisplayElement::shadowPseudoId): Added.

  • rendering/MediaControlElements.h: Added/changed defs accordingly.
  • rendering/RenderTheme.h: (WebCore::RenderTheme::usesMediaControlStatusDisplay): Added.
  • rendering/RenderThemeMac.h: Added def.
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::usesMediaControlStatusDisplay): Added.
  • rendering/style/RenderStyleConstants.h: Removed now-unused enum values.
10:32 Changeset [77953] by hyatt@apple.com
  • 3 edits in trunk/Source/WebKit/win

<rdar://problem/8932077> REGRESSION (5.0.3-ToT): United boarding pass has wrong layout when printed

Reviewed by Adam Roben.

Windows never got patched to pass in the page height to WebCore, so when WebCore's pagination got re-written to depend on this
value, Windows got broken. Patch setPrinting to be identical to WebKit1 on OS X and to have it take an extra minimum page height
argument.

  • WebFrame.cpp:

(WebFrame::setPrinting):
(WebFrame::setInPrintingMode):

  • WebFrame.h:
10:22 Changeset [77952] by xji@chromium.org
  • 3 edits
    4 adds in trunk

2011-02-08 Xiaomei Ji <xji@chromium.org>

Reviewed by Dan Bernstein.

Fix pop-up button text not rendered correctly according to its direction
in <option>.
https://bugs.webkit.org/show_bug.cgi?id=53642


In adjustInnerStyle(), if m_innerBlock's direction or unicode-bidi
changes, set it needs layout.

  • fast/text/international/pop-up-button-text-alignment-and-direction.html: Added.
  • platform/mac/fast/text/international/pop-up-button-text-alignment-and-direction-expected.checksum: Added.
  • platform/mac/fast/text/international/pop-up-button-text-alignment-and-direction-expected.png: Added.
  • platform/mac/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt: Added.

2011-02-08 Xiaomei Ji <xji@chromium.org>

Reviewed by Dan Bernstein.

Fix pop-up button text not rendered correctly according to its direction
in <option>.
https://bugs.webkit.org/show_bug.cgi?id=53642


In adjustInnerStyle(), if m_innerBlock's direction or unicode-bidi
changes, set it needs layout.

Test: fast/text/international/pop-up-button-text-alignment-and-direction.html

  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::adjustInnerStyle):
10:01 Changeset [77951] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-02-08 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed build fix for Qt-minimal.

  • inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::hasFrontend):
09:32 Changeset [77950] by loislo@chromium.org
  • 25 edits in trunk/Source

2011-02-02 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: move InspectorController's methods from InspectorAgent to InspectorController.

https://bugs.webkit.org/show_bug.cgi?id=53169

All the Inspector API for WebCore has two parts.
The first one is InspectorInstrumentation for WebCore.
The second is InspectorController for WebKit.
InspectorAgent was produced by renaming original InspectorController.
This patch extracts WebKit related methods from InspectorAgent to InspectorController.

  • WebCore.exp.in:
  • bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:
  • html/HTMLDocument.cpp: (WebCore::HTMLDocument::createParser):
  • inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::InspectorAgent): (WebCore::InspectorAgent::~InspectorAgent): (WebCore::InspectorAgent::restoreInspectorStateFromCookie): (WebCore::InspectorAgent::inspect): (WebCore::InspectorAgent::handleMousePress): (WebCore::InspectorAgent::didClearWindowObjectInWorld): (WebCore::InspectorAgent::setFrontend): (WebCore::InspectorAgent::disconnectFrontend): (WebCore::InspectorAgent::resourceAgent): (WebCore::InspectorAgent::createFrontendLifetimeAgents): (WebCore::InspectorAgent::releaseFrontendLifetimeAgents): (WebCore::InspectorAgent::populateScriptObjects): (WebCore::InspectorAgent::pushDataCollectedOffline): (WebCore::InspectorAgent::restoreProfiler): (WebCore::InspectorAgent::startTimelineProfiler): (WebCore::PostWorkerNotificationToFrontendTask::performTask): (WebCore::InspectorAgent::didOpenDatabase): (WebCore::InspectorAgent::didUseDOMStorage): (WebCore::InspectorAgent::showAndEnableDebugger): (WebCore::InspectorAgent::enableDebugger): (WebCore::InspectorAgent::enabled):
  • inspector/InspectorAgent.h: (WebCore::InspectorAgent::frontend):
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::~InspectorController): (WebCore::InspectorController::setInspectorFrontendClient): (WebCore::InspectorController::hasInspectorFrontendClient): (WebCore::InspectorController::didClearWindowObjectInWorld): (WebCore::InspectorController::startTimelineProfiler): (WebCore::InspectorController::stopTimelineProfiler): (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::disconnectFrontend): (WebCore::InspectorController::disconnectFrontendImpl): (WebCore::InspectorController::show): (WebCore::InspectorController::close): (WebCore::InspectorController::restoreInspectorStateFromCookie): (WebCore::InspectorController::evaluateForTestInFrontend): (WebCore::InspectorController::drawNodeHighlight): (WebCore::InspectorController::inspect): (WebCore::InspectorController::enabled): (WebCore::InspectorController::showPanel): (WebCore::InspectorController::frontendLoaded): (WebCore::InspectorController::timelineProfilerEnabled): (WebCore::InspectorController::enableProfiler): (WebCore::InspectorController::disableProfiler): (WebCore::InspectorController::profilerEnabled): (WebCore::InspectorController::debuggerEnabled): (WebCore::InspectorController::showAndEnableDebugger): (WebCore::InspectorController::disableDebugger): (WebCore::InspectorController::startUserInitiatedProfiling): (WebCore::InspectorController::stopUserInitiatedProfiling): (WebCore::InspectorController::isRecordingUserInitiatedProfile): (WebCore::InspectorController::setInspectorExtensionAPI): (WebCore::InspectorController::resume): (WebCore::InspectorController::hideHighlight): (WebCore::InspectorController::dispatchMessageFromFrontend):
  • inspector/InspectorController.h: (WebCore::InspectorController::inspectorClient): (WebCore::InspectorController::inspectedPage): (WebCore::InspectorController::hasFrontend):
  • inspector/InspectorFrontendClientLocal.cpp: (WebCore::InspectorFrontendClientLocal::sendMessageToBackend):
  • inspector/InspectorFrontendHost.cpp: (WebCore::InspectorFrontendHost::setExtensionAPI):
  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::didClearWindowObjectInWorldImpl): (WebCore::InspectorInstrumentation::profilerEnabledImpl):
  • inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::hasFrontend):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::continueLoadAfterNavigationPolicy):

2011-02-02 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: move InspectorController's methods from InspectorAgent to InspectorController.

https://bugs.webkit.org/show_bug.cgi?id=53169

Minor change enforced by major changes in WebCore/inspector/InspectorController.

  • src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::dispatchOnInspectorBackend):
  • src/WebViewImpl.h:

2011-02-02 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: move InspectorController's methods from InspectorAgent to InspectorController.

https://bugs.webkit.org/show_bug.cgi?id=53169

Minor change enforced by major changes in WebCore/inspector/InspectorController.

  • WebCoreSupport/InspectorClientGtk.cpp:
  • webkit/webkitwebinspector.cpp: (webkit_web_inspector_get_property):

2011-02-02 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: move InspectorController's methods from InspectorAgent to InspectorController.

https://bugs.webkit.org/show_bug.cgi?id=53169

Minor change enforced by major changes in WebCore/inspector/InspectorController.

2011-02-02 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: move InspectorController's methods from InspectorAgent to InspectorController.

https://bugs.webkit.org/show_bug.cgi?id=53169

Minor change enforced by major changes in WebCore/inspector/InspectorController.

  • WebInspector.cpp: (WebInspector::isTimelineProfilingEnabled):
09:30 Changeset [77949] by mario@webkit.org
  • 2 edits in trunk/LayoutTests

2011-02-08 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Martin Robinson.

editing/selection/end-of-document.html is failing in the GTK 64-bit debug bot
https://bugs.webkit.org/show_bug.cgi?id=53995

Ensure to wait for the body to be loaded before running the test.

  • editing/selection/end-of-document.html: Call runEditingTest() on the body.onload event.
09:27 Changeset [77948] by kbalazs@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-02-08 Balazs Kelemen <kbalazs@webkit.org>

Reviewed by Andreas Kling.

[Qt] Should not always define USE_SYSTEM_MALLOC
https://bugs.webkit.org/show_bug.cgi?id=54007

  • wtf/Platform.h:
09:21 Changeset [77947] by commit-queue@webkit.org
  • 4 edits in trunk/Tools

2011-02-08 Kundu Suchismita <suchi.kundu@nokia.com>

Reviewed by Laszlo Gombos.

Local Storage settings can be enable/disable from "Develop" menu
https://bugs.webkit.org/show_bug.cgi?id=52296

  • QtTestBrowser/launcherwindow.cpp: (LauncherWindow::createChrome): (LauncherWindow::toggleLocalStorage): (LauncherWindow::toggleOfflineStorageDatabase): (LauncherWindow::toggleOfflineWebApplicationCache): (LauncherWindow::setOfflineStorageDefaultQuota):
  • QtTestBrowser/launcherwindow.h: (WindowOptions::WindowOptions):
  • QtTestBrowser/main.cpp: (LauncherApplication::handleUserOptions):
09:16 Changeset [77946] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-08 George Wright <gwright@rim.com>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=53949

Ensure that we pack the colour byte order correctly for Skia using
Skia's SkPackARGB32 function.

  • platform/image-decoders/ImageDecoder.h: (WebCore::ImageFrame::setRGBA):
09:05 Changeset [77945] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-08 George Wright <gwright@rim.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=53951

Ensure we do not pass (-1, -1) sized rects to ImageBuffer but instead
pass the full image dimensions.

  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::drawImageBuffer):
08:50 Changeset [77944] by paroga@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-02-08 Patrick Gansterer <paroga@webkit.org>

Reviewed by Adam Roben.

[WIN] Add missing includes and forward declarations for DownloadBundle
https://bugs.webkit.org/show_bug.cgi?id=53881

  • platform/network/cf/DownloadBundle.h:
  • platform/network/win/DownloadBundleWin.cpp: (WebCore::DownloadBundle::appendResumeData):
08:47 Changeset [77943] by paroga@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-08 Patrick Gansterer <paroga@webkit.org>

Reviewed by Adam Roben.

[WIN] Add missing include in WKCAImageQueue
https://bugs.webkit.org/show_bug.cgi?id=53890

  • platform/graphics/win/WKCAImageQueue.cpp:
08:28 Changeset [77942] by jberlin@webkit.org
  • 2 edits in trunk/Source/WebKit2

ASSERTION FAILURE: ASSERT_NOT_REACHED() in Connection::writeEventHandler() after the Web
Process crashes.
https://bugs.webkit.org/show_bug.cgi?id=54005

Reviewed by Adam Roben.

  • Platform/CoreIPC/win/ConnectionWin.cpp:

(CoreIPC::Connection::writeEventHandler):
Handle ERROR_BROKEN_PIPE by calling connectionDidClose() and returning early.

08:17 Changeset [77941] by paroga@webkit.org
  • 2 edits in trunk/WebKitLibraries

2011-02-08 Patrick Gansterer <paroga@webkit.org>

Reviewed by Adam Roben.

[WIN] Add missing forward declarations in WebKitSystemInterface.h
https://bugs.webkit.org/show_bug.cgi?id=53889

  • win/include/WebKitSystemInterface/WebKitSystemInterface.h:
08:08 Changeset [77940] by mrobinson@webkit.org
  • 2 edits in trunk/LayoutTests

2011-02-08 Martin Robinson <mrobinson@igalia.com>

Unskip a bunch of tests that are passing locally and move one
timeout with the other timeouts.

  • platform/gtk/Skipped: Unskip some passing tests.
08:03 Changeset [77939] by aroben@apple.com
  • 2 edits in trunk/Source/WebKit2

Handle WM_TIMER messages for stopped timers

Whenever we stop a timer, we call ::KillTimer to cancel any future firings of the timer. But
::KillTimer doesn't do anything about WM_TIMER messages that have already been posted to the
message queue. We need to handle those, too.

Fixes <http://webkit.org/b/53999> Occasional assertion failures in
RunLoop::TimerBase::timerFired

Reviewed by Darin Adler.

  • Platform/win/RunLoopWin.cpp:

(RunLoop::TimerBase::timerFired): Just bail if the timer has already been stopped.

08:01 Changeset [77938] by aroben@apple.com
  • 2 edits in trunk/Source/WebKit2

Don't mark a Connection as connected until open() is called on Windows

This matches Mac. Even though the Connection's pipe is connected before open() is called,
the Connection itself isn't really connected to the pipe until then, and we won't actually
read any data from before that point.

Fixes <http://webkit.org/b/53998> <rdar://problem/8971207> REGRESSION (r77874): Assertion
failure on launch in Connection::setDidCloseOnConnectionWorkQueueCallback on Windows

Reviewed by Darin Adler.

  • Platform/CoreIPC/win/ConnectionWin.cpp:

(CoreIPC::Connection::platformInitialize): Moved code to set m_isConnected from here to
open.
(CoreIPC::Connection::platformInvalidate): Unset m_isConnected, to match Mac. (This isn't
part of the bug fix, but seemed worthwhile.)
(CoreIPC::Connection::open): Set m_isConnected now that we're going to listen on the pipe.

07:58 Changeset [77937] by paroga@webkit.org
  • 7 edits in trunk/Source/WebCore

2011-02-08 Patrick Gansterer <paroga@webkit.org>

Reviewed by Adam Roben.

[WIN] Add missing includes and forward declarations for CFNetwork
https://bugs.webkit.org/show_bug.cgi?id=53883

  • platform/network/cf/DNSCFNet.cpp:
  • platform/network/cf/LoaderRunLoopCF.cpp:
  • platform/network/cf/LoaderRunLoopCF.h:
  • platform/network/cf/ProxyServerCFNet.cpp:
  • platform/network/cf/SocketStreamHandle.h:
  • platform/network/cf/SocketStreamHandleCFNet.cpp:
07:57 Changeset [77936] by mrobinson@webkit.org
  • 4 edits in trunk

2011-02-08 Martin Robinson <mrobinson@igalia.com>

Reviewed by Eric Seidel.

[GTK] EventSender.keyDown does not support non-array modifier arguments
https://bugs.webkit.org/show_bug.cgi?id=53962

  • platform/gtk/Skipped: Unskip a test which is now passing.

2011-02-08 Martin Robinson <mrobinson@igalia.com>

Reviewed by Eric Seidel.

[GTK] EventSender.keyDown does not support non-array modifier arguments
https://bugs.webkit.org/show_bug.cgi?id=53962

Support handling either an array or a string for the modifier argument
to EventSender.keyDown.

  • DumpRenderTree/gtk/EventSender.cpp: (gdkModifierFromJSValue): Added this helper which factors out the string comparison bits. (gdkModifersFromJSValue): Test up front whether the value is a string, to handle it specially.
07:51 Changeset [77935] by paroga@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-08 Patrick Gansterer <paroga@webkit.org>

Unreviewed WinCE build fix for r77870.

  • platform/DragImage.cpp: Compile createDragImageForLink on WinCE.
07:48 Changeset [77934] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

2011-02-08 Pavel Feldman <pfeldman@chromium.org>

Not reviewed. Removing inspector tests from Skipped on [win].
Resource tracking has been removed since then, maybe it'll help.

  • platform/win/Skipped:
07:46 Changeset [77933] by mrobinson@webkit.org
  • 2 edits in trunk/LayoutTests

2011-02-08 Martin Robinson <mrobinson@igalia.com>

Clean up the skipped list slightly and unskip a test which should now be passing.

  • platform/gtk/Skipped: Clean up.
07:40 Changeset [77932] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-02-08 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: open network resource url in new tab upon double click.
https://bugs.webkit.org/show_bug.cgi?id=53930

  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkDataGridNode.prototype.createCells): (WebInspector.NetworkDataGridNode.prototype._openInNewTab):
07:34 Changeset [77931] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-02-08 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: $x: any node should work in optional context parameter.
https://bugs.webkit.org/show_bug.cgi?id=50138

  • inspector/InjectedScriptSource.js:
07:30 Changeset [77930] by paroga@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-08 Patrick Gansterer <paroga@webkit.org>

Unreviewed WinCE build fix for r77870.

Remove the global namespace prefix from GlobalLock/GlobalUnlock.

  • platform/win/ClipboardUtilitiesWin.cpp:
07:27 Changeset [77929] by pfeldman@chromium.org
  • 5 edits
    2 adds in trunk

2011-02-08 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: re-apply r77924.

Test: inspector/console-api-on-call-frame.html

  • inspector/InjectedScriptSource.js:
  • inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer.prototype._onEvaluateOnInspectedPage):
07:08 Changeset [77928] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebCore

2011-02-08 Andreas Kling <kling@webkit.org>

Reviewed by Tor Arne Vestbø.

REGRESSION(r77312): Unbreak TiledBackingStore.

Due to an off-by-one error, we were no longer rendering the
rightmost column and bottom row of tiles.

Covered by tst_QGraphicsWebView::widgetsRenderingThroughCache().

  • platform/graphics/TiledBackingStore.cpp: (WebCore::TiledBackingStore::invalidate): (WebCore::TiledBackingStore::updateTileBuffers): (WebCore::TiledBackingStore::paint): (WebCore::TiledBackingStore::createTiles):
06:26 Changeset [77927] by commit-queue@webkit.org
  • 3 edits
    2 deletes in trunk

2011-02-08 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r77924.
http://trac.webkit.org/changeset/77924
https://bugs.webkit.org/show_bug.cgi?id=53997

Breaks inspector tests. (Requested by pfeldman on #webkit).

  • inspector/console-api-on-call-frame-expected.txt: Removed.
  • inspector/console-api-on-call-frame.html: Removed.

2011-02-08 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r77924.
http://trac.webkit.org/changeset/77924
https://bugs.webkit.org/show_bug.cgi?id=53997

Breaks inspector tests. (Requested by pfeldman on #webkit).

  • inspector/InjectedScriptSource.js: (.): ():
06:04 Changeset [77926] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

2011-02-08 Benjamin Poulain <ikipou@gmail.com>

Reviewed by Csaba Osztrogonác.

openDatabaseSync() stop responding after too many call
https://bugs.webkit.org/show_bug.cgi?id=53945

Reset the database quota to a known state between each test.

Define a quota for the known origins at each test run and delete
all the databases.
This way, the database related test do not depend on previous
allocations.

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): (WebCore::DumpRenderTree::dumpDatabaseQuota):
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::reset):
05:42 Changeset [77925] by caseq@chromium.org
  • 16 edits in trunk/Source/WebCore

2011-02-04 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [refacotring] merge InspectorAgent::willSendRequest() into InspectorResourceAgent
https://bugs.webkit.org/show_bug.cgi?id=53789

  • perform UserAgent override via InspectorInstrumentation
  • move adding extra request headers to InspectorResourceAgent
  • simplified things in InspectorState
  • inspector/Inspector.idl:
  • inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::disconnectFrontend): (WebCore::InspectorAgent::applyUserAgentOverride):
  • inspector/InspectorAgent.h:
  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::applyUserAgentOverrideImpl): (WebCore::InspectorInstrumentation::willSendRequestImpl):
  • inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::applyUserAgentOverride):
  • inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::setExtraHeaders): (WebCore::InspectorResourceAgent::willSendRequest):
  • inspector/InspectorResourceAgent.h:
  • inspector/InspectorState.cpp: (WebCore::InspectorState::InspectorState): (WebCore::InspectorState::restoreFromInspectorCookie): (WebCore::InspectorState::updateCookie): (WebCore::InspectorState::setValue): (WebCore::InspectorState::getBoolean): (WebCore::InspectorState::getString): (WebCore::InspectorState::getLong): (WebCore::InspectorState::getObject):
  • inspector/InspectorState.h: (WebCore::InspectorState::setObject):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::userAgent):
05:29 Changeset [77924] by pfeldman@chromium.org
  • 3 edits
    2 adds in trunk

2011-02-08 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: do not hide scope variables with command line api.
https://bugs.webkit.org/show_bug.cgi?id=53497

  • inspector/console-api-on-call-frame-expected.txt: Added.
  • inspector/console-api-on-call-frame.html: Added.

2011-02-08 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: do not hide scope variables with command line api.
https://bugs.webkit.org/show_bug.cgi?id=53497

Test: inspector/console-api-on-call-frame.html

  • inspector/InjectedScriptSource.js:
05:03 Changeset [77923] by demarchi@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

2011-02-08 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Unreviewed build fix.

[EFL] Fix when building with curl backend.

  • ewk/ewk_settings.cpp: (ewk_settings_proxy_uri_get):
04:57 Changeset [77922] by pfeldman@chromium.org
  • 11 edits
    1 delete in trunk

2011-02-07 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: ignore cache upon reload via Ctrl(Cmd)+Shift+R.
https://bugs.webkit.org/show_bug.cgi?id=53914

  • http/tests/inspector/inspector-test2.js: (initialize_InspectorTest.InspectorTest.reloadPage):
  • inspector/audits-panel-functional.html:

2011-02-07 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: ignore cache upon reload via Ctrl(Cmd)+Shift+R.
https://bugs.webkit.org/show_bug.cgi?id=53914

  • inspector/Inspector.idl:
  • inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::reloadPage):
  • inspector/InspectorAgent.h:
  • inspector/front-end/AuditsPanel.js: (WebInspector.AuditsPanel.prototype._reloadResources):
  • inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer.prototype._onReload):
  • inspector/front-end/inspector.js: (WebInspector.documentKeyDown):
04:45 Changeset [77921] by mario@webkit.org
  • 2 edits in trunk/LayoutTests

2011-02-08 Mario Sanchez Prada <msanchez@igalia.com>

Unreviewed, skipping test timing out on GTK 32-bit debug bot.

fast/loader/onload-willSendRequest-null-for-frame.html times out in GTK 32-bit debug bot
https://bugs.webkit.org/show_bug.cgi?id=53992

  • platform/gtk/Skipped: Skipped test.
03:26 Changeset [77920] by mario@webkit.org
  • 2 edits in trunk/LayoutTests

2011-02-08 Mario Sanchez Prada <msanchez@igalia.com>

Unreviewed, skipping flaky test on GTK debug bots.

fast/frames/sandboxed-iframe-storage.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=53991

  • platform/gtk/Skipped: Skipped test.
02:52 Changeset [77919] by antti@apple.com
  • 3 edits in trunk/Source/WebCore

Skip over sibling selectors when collecting descendant selector hashes
https://bugs.webkit.org/show_bug.cgi?id=53987

Reviewed by Cameron Zwarich.

Skip instead of bailing out. This will allow optimizing some sibling selector cases.

  • css/CSSStyleSelector.cpp:

(WebCore::RuleData::RuleData):
(WebCore::RuleData::collectIdentifierHashes):
(WebCore::RuleData::collectDescendantSelectorIdentifierHashes):

  • css/CSSStyleSelector.h:
02:50 Changeset [77918] by mario@webkit.org
  • 2 edits in trunk/LayoutTests

2011-02-08 Mario Sanchez Prada <msanchez@igalia.com>

Unreviewed, skipping flaky test on GTK debug bots.

svg/custom/use-multiple-on-nested-disallowed-font.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=53989

  • platform/gtk/Skipped: Skipped test.
02:20 Changeset [77917] by carlosgc@webkit.org
  • 8 edits
    2 adds in trunk

2011-02-08 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] DRT's TextInputController is unimplemented on GTK
https://bugs.webkit.org/show_bug.cgi?id=52997

  • platform/gtk/Skipped: Unskip several tests that pass now that we have TextInputController.

2011-02-08 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] DRT's TextInputController is unimplemented on GTK
https://bugs.webkit.org/show_bug.cgi?id=52997

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp: (DumpRenderTreeSupportGtk::setComposition): (DumpRenderTreeSupportGtk::confirmComposition): (DumpRenderTreeSupportGtk::firstRectForCharacterRange): (DumpRenderTreeSupportGtk::selectedRange): New methods needed by TextInputController.
  • WebCoreSupport/DumpRenderTreeSupportGtk.h:

2011-02-08 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] DRT's TextInputController is unimplemented on GTK
https://bugs.webkit.org/show_bug.cgi?id=52997

Initial implementation of TextInputController for GTK port.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (webViewWindowObjectCleared):
  • DumpRenderTree/gtk/TextInputController.cpp: Added. (setMarkedTextCallback): (insertTextCallback): (unmarkTextCallback): (firstRectForCharacterRangeCallback): (selectedRangeCallback): (getClass): (makeTextInputController):
  • DumpRenderTree/gtk/TextInputController.h: Added.
  • GNUmakefile.am:
01:18 Changeset [77916] by mitz@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

LLVM Compiler build fix.

Reviewed by Maciej Stachowiak.

  • runtime/WriteBarrier.h:

(JSC::WriteBarrier::WriteBarrier):

00:49 Changeset [77915] by mjs@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-02-08 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r77866.
http://trac.webkit.org/changeset/77866
https://bugs.webkit.org/show_bug.cgi?id=53981

caused all WebKit2 inspector tests to crash (Requested by
othermaciej on #webkit).

  • UIProcess/WebInspectorProxy.cpp: (WebKit::WebInspectorProxy::didClose):

02/07/11:

23:44 Changeset [77914] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

2011-02-07 Cris Neckar <cdn@chromium.org>

Reviewed by Jian Li.

Test for null deref in DOMURL
https://bugs.webkit.org/show_bug.cgi?id=53811

  • fast/files/domurl-script-execution-context-crash-expected.txt: Added.
  • fast/files/domurl-script-execution-context-crash.html: Added.

2011-02-07 Cris Neckar <cdn@chromium.org>

Reviewed by Jian Li.

Fix null deref in DOMURL
https://bugs.webkit.org/show_bug.cgi?id=53811

Test: fast/files/domurl-script-execution-context-crash.html

  • html/DOMURL.cpp: (WebCore::DOMURL::DOMURL):
23:30 Changeset [77913] by tony@chromium.org
  • 19 edits in trunk/Tools

2011-02-07 Tony Chang <tony@chromium.org>

Reviewed by Adam Barth.

clean up python imports
https://bugs.webkit.org/show_bug.cgi?id=53966

Convert "import A.B.C.D as D" to "from A.B.C import D" and
make some imports absolute as required by PEP-8

  • Scripts/webkitpy/common/checkout/scm.py:
  • Scripts/webkitpy/common/net/irc/ircbot.py:
  • Scripts/webkitpy/common/system/logutils.py:
  • Scripts/webkitpy/common/system/logutils_unittest.py:
  • Scripts/webkitpy/layout_tests/deduplicate_tests.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/mac.py: Remove some unused imports
  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/update_webgl_conformance_tests.py:
  • Scripts/webkitpy/tool/bot/irc_command.py:
  • Scripts/webkitpy/tool/bot/sheriffircbot.py:
  • Scripts/webkitpy/tool/commands/download.py:
  • Scripts/webkitpy/tool/commands/prettydiff.py:
  • Scripts/webkitpy/tool/commands/queries.py:
  • Scripts/webkitpy/tool/commands/roll.py:
  • Scripts/webkitpy/tool/commands/stepsequence.py:
  • Scripts/webkitpy/tool/commands/upload.py:
  • Scripts/webkitpy/tool/main.py:
23:29 Changeset [77912] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

2011-02-07 James Robinson <jamesr@chromium.org>

Reviewed by Adam Barth.

Teach do-webcore-rename about the WebKit move to Source/
https://bugs.webkit.org/show_bug.cgi?id=53967

  • Scripts/do-webcore-rename:
23:24 Changeset [77911] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed.

[Qt] Fix crashes in QMetaObject::metacall
https://bugs.webkit.org/show_bug.cgi?id=53912

  • platform/qt/Skipped: http/tests/websocket/tests/websocket-protocol-ignored.html added until fix.
23:13 Changeset [77910] by mrowe@apple.com
  • 2 edits in trunk/Source/WebCore

Fix the 32-bit build.

  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::didAddVerticalScrollbar): Remove some extraneous characters.
(WebCore::ScrollAnimatorMac::didAddHorizontalScrollbar): Ditto.

23:07 Changeset [77909] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

2011-02-07 Kenji Imasaki <imasaki@chromium.org>

Reviewed by David Levin.

[Chromium] Remove non-Flaky media layout tests and update bugs that
are associated with media layout tests
https://bugs.webkit.org/show_bug.cgi?id=53948

  • platform/chromium/test_expectations.txt:
23:07 Changeset [77908] by mjs@apple.com
  • 16 edits
    2 adds in trunk

2011-02-07 Maciej Stachowiak <mjs@apple.com>

Reviewed by Dan Bernstein.

Add resource load client for injected bundle and move willSendRequest there
https://bugs.webkit.org/show_bug.cgi?id=53972

  • GNUmakefile.am:
  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp: (WKBundlePageSetPageLoaderClient): (WKBundlePageSetResourceLoadClient):
  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:
  • WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
  • WebProcess/InjectedBundle/InjectedBundlePageResourceLoadClient.cpp: Added. (WebKit::InjectedBundlePageResourceLoadClient::didInitiateLoadForResource): (WebKit::InjectedBundlePageResourceLoadClient::willSendRequestForFrame): (WebKit::InjectedBundlePageResourceLoadClient::didReceiveResponseForResource): (WebKit::InjectedBundlePageResourceLoadClient::didReceiveContentLengthForResource): (WebKit::InjectedBundlePageResourceLoadClient::didFinishLoadForResource): (WebKit::InjectedBundlePageResourceLoadClient::didFailLoadForResource):
  • WebProcess/InjectedBundle/InjectedBundlePageResourceLoadClient.h: Added.
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::assignIdentifierToInitialRequest): (WebKit::WebFrameLoaderClient::dispatchWillSendRequest): (WebKit::WebFrameLoaderClient::dispatchDidReceiveResponse): (WebKit::WebFrameLoaderClient::dispatchDidReceiveContentLength): (WebKit::WebFrameLoaderClient::dispatchDidFinishLoading): (WebKit::WebFrameLoaderClient::dispatchDidFailLoading):
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::initializeInjectedBundleResourceLoadClient):
  • WebProcess/WebPage/WebPage.h: (WebKit::WebPage::injectedBundleResourceLoadClient):
  • win/WebKit2.vcproj:

2011-02-07 Maciej Stachowiak <mjs@apple.com>

Reviewed by Dan Bernstein.

Add resource load client for injected bundle and move willSendRequest there
https://bugs.webkit.org/show_bug.cgi?id=53972

  • MiniBrowser/mac/WebBundle/WebBundleMain.m: (didCreatePage):
  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::InjectedBundlePage): (WTR::InjectedBundlePage::didInitiateLoadForResource): (WTR::InjectedBundlePage::didReceiveResponseForResource): (WTR::InjectedBundlePage::didReceiveContentLengthForResource): (WTR::InjectedBundlePage::didFinishLoadForResource): (WTR::InjectedBundlePage::didFailLoadForResource): (WTR::InjectedBundlePage::willSendRequestForFrame):
  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
23:07 Changeset [77907] by commit-queue@webkit.org
  • 2 edits
    1 add in trunk/Source/WebCore

2011-02-07 Xiyuan Xia <xiyuan@chromium.org>

Reviewed by Tony Chang.

[Chromium] Select popup box does not align with select button when appearance is not "menulist".
https://bugs.webkit.org/show_bug.cgi?id=53942

Added manual test select_webkit_appearance_off_popup_alignment.html.

  • manual-tests/select_webkit_appearance_off_popup_alignment.html: Added.
  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupListBox::layout):
22:59 Changeset [77906] by commit-queue@webkit.org
  • 4 edits in trunk/Source

2011-02-07 Aparna Nandyal <aparna.nand@wipro.com>

Reviewed by Andreas Kling.

[Qt] - Context menu needs "Copy" as well when the selected text is a link.
https://bugs.webkit.org/show_bug.cgi?id=40983

Added copy option for Qt platform if selection is a link.
Added a test in tst_qwebpage.cpp.

  • page/ContextMenuController.cpp: (WebCore::ContextMenuController::populate):

2011-02-07 Aparna Nandyal <aparna.nand@wipro.com>

Reviewed by Andreas Kling.

[Qt] - Context menu needs "Copy" as well when the selected text is a link.
https://bugs.webkit.org/show_bug.cgi?id=40983

Added a test case to create a context sensitive menu.
A check is made if it has Copy menu item when user
selects a link and opens context menu.

  • tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::contextMenuCopy):
22:48 Changeset [77905] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-02-07 Mike Reed <reed@google.com>

Reviewed by Kenneth Russell.

Add compile-time flag ENABLE(SKIA_GPU) to use Skia's gpu backend
when drawing <canvas>. Disabled by default.

No new tests. existing canvas layouttests apply

  • platform/graphics/chromium/DrawingBufferChromium.cpp: (WebCore::DrawingBuffer::publishToPlatformLayer):
  • platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::GetGlobalGrContext): (WebCore::PlatformContextSkia::isPrinting): (WebCore::PlatformContextSkia::setSharedGraphicsContext3D): (WebCore::PlatformContextSkia::syncSoftwareCanvas):
22:45 Changeset [77904] by jcivelli@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-02-07 Jay Civelli <jcivelli@chromium.org>

Reviewed by Darin Fisher.

Removing unused code from PopupMenuChromium.
https://bugs.webkit.org/show_bug.cgi?id=53866

  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupListBox::layout): (WebCore::PopupMenuChromium::show):
    • platform/chromium/PopupMenuChromium.h:
22:39 Changeset [77903] by ojan@chromium.org
  • 2 edits in trunk/Websites/bugs.webkit.org

2011-02-07 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Barth.

bring back diff context lines into the review tool
https://bugs.webkit.org/show_bug.cgi?id=53974

  • code-review.js:
22:30 Changeset [77902] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

2011-02-07 Kenichi Ishibashi <bashi@google.com>

Reviewed by Andreas Kling.

HTMLOutputElement::childrenChanged() should call its base class childrenChanged()
https://bugs.webkit.org/show_bug.cgi?id=53791

Test that a live list is updated after the child of an HTMLOutputElement was removed.

  • fast/dom/HTMLOutputElement/htmloutputelement-children-removed-expected.txt: Added.
  • fast/dom/HTMLOutputElement/htmloutputelement-children-removed.html: Added.

2011-02-07 Kenichi Ishibashi <bashi@chromium.org>

Reviewed by Andreas Kling.

HTMLOutputElement::childrenChanged() should call its base class childrenChanged()
https://bugs.webkit.org/show_bug.cgi?id=53791

Calls HTMLFormControlElement::childrenChanged() in HTMLOutputElement::childrenChanged().

Test: fast/dom/HTMLOutputElement/htmloutputelement-children-removed.html

  • html/HTMLOutputElement.cpp: (WebCore::HTMLOutputElement::childrenChanged): Calls super class's childrenChanged().
22:27 Changeset [77901] by commit-queue@webkit.org
  • 6 edits in trunk/Source

2011-02-07 Benjamin Poulain <ikipou@gmail.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] cookiesEnabled could create the cookieJar on the wrong thread.
https://bugs.webkit.org/show_bug.cgi?id=52289

Use the QtNAMThreadSafeProxy to make sure the cookie jar is created
in the same thread as the QNetworkAccessManager.

  • platform/network/qt/QtNAMThreadSafeProxy.cpp: (WebCore::QtNAMThreadSafeProxy::QtNAMThreadSafeProxy): (WebCore::QtNAMThreadSafeProxy::hasCookieJar):
  • platform/network/qt/QtNAMThreadSafeProxy.h:
  • platform/qt/CookieJarQt.cpp: (WebCore::cookiesEnabled):

2011-02-07 Benjamin Poulain <ikipou@gmail.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] cookiesEnabled could create the cookieJar on the wrong thread.
https://bugs.webkit.org/show_bug.cgi?id=52289

Test if the cookie jar is created in the right thread when accessed from
the navigator object.

  • tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::navigatorCookieEnabledForNetworkAccessManagerOnDifferentThread):
22:25 Changeset [77900] by commit-queue@webkit.org
  • 9 edits in trunk/Source

2011-02-07 Alexey Marinichev <amarinichev@chromium.org>

Reviewed by Kenneth Russell.

Hook up WebGraphicsContext3D::setContextLostCallback.
https://bugs.webkit.org/show_bug.cgi?id=53722

Test: fast/canvas/webgl/context-lost.html, comment out the line with
extension.loseContext() and kill the GPU process "Lose context"
message shows up.

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContextLostCallback::WebGLRenderingContextLostCallback): (WebCore::WebGLRenderingContextLostCallback::onContextLost): (WebCore::WebGLRenderingContextLostCallback::~WebGLRenderingContextLostCallback): (WebCore::WebGLRenderingContext::initializeNewContext): (WebCore::WebGLRenderingContext::~WebGLRenderingContext):
  • platform/graphics/GraphicsContext3D.h: (WebCore::GraphicsContext3D::ContextLostCallback::~ContextLostCallback):
  • platform/graphics/mac/GraphicsContext3DMac.mm: (WebCore::GraphicsContext3D::setContextLostCallback): stub
  • platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3D::setContextLostCallback): stub

2011-02-07 Alexey Marinichev <amarinichev@chromium.org>

Reviewed by Kenneth Russell.

Hook up WebGraphicsContext3D::setContextLostCallback.
https://bugs.webkit.org/show_bug.cgi?id=53722

Test: fast/canvas/webgl/context-lost.html, comment out the line with
extension.loseContext() and kill the GPU process "Lose context"
message shows up.

  • public/WebGraphicsContext3D.h: (WebKit::WebGraphicsContext3D::WebGraphicsContextLostCallback::~WebGraphicsContextLostCallback):
  • src/GraphicsContext3DChromium.cpp: (WebCore::GraphicsContextLostCallbackAdapter::~GraphicsContextLostCallbackAdapter): (WebCore::GraphicsContextLostCallbackAdapter::GraphicsContextLostCallbackAdapter): (WebCore::GraphicsContextLostCallbackAdapter::onContextLost): (WebCore::GraphicsContextLostCallbackAdapter::create): (WebCore::GraphicsContext3DInternal::setContextLostCallback):
  • src/GraphicsContext3DInternal.h:
22:24 Changeset [77899] by mrowe@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix the 32-bit build.

  • UIProcess/cf/WebBackForwardListCF.cpp:

(WebKit::WebBackForwardList::restoreFromCFDictionaryRepresentation): Add some casts
to prevent warnings about mixing signed and unsigned comparisons.

22:11 Changeset [77898] by abarth@webkit.org
  • 3 edits in trunk/Tools

2011-02-07 Adam Barth <abarth@webkit.org>

Add Leopard Debug back to the core builders.

  • Scripts/webkitpy/common/net/buildbot/buildbot.py:
  • Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
22:08 Changeset [77897] by commit-queue@webkit.org
  • 4 edits in trunk/LayoutTests

2011-02-07 Ami Fischman <fischman@google.com>

Reviewed by Eric Seidel.

Re-baseline media/video-zoom.html for http://crbug.com/70252 aka
https://bugs.webkit.org/show_bug.cgi?id=53737 to account for (very)
slightly different scrollbar shading.
This test isn't flaky on LINUX or MAC according to
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&showAllRuns=true&master=ChromiumWebkit&tests=media%2Fvideo-zoom.html
so take it out of test_expectations.txt; it passes 100% on LINUX and
fails 100% on MAC, and should pass 100% on MAC with this new
baseline.

  • platform/chromium-mac/media/video-zoom-expected.checksum:
  • platform/chromium-mac/media/video-zoom-expected.png:
  • platform/chromium/test_expectations.txt:
22:05 Changeset [77896] by commit-queue@webkit.org
  • 5 edits in trunk

2011-02-07 Adam Klein <adamk@chromium.org>

Reviewed by Jian Li.

[chromium] Remove deprecated method WebNotification::dir
https://bugs.webkit.org/show_bug.cgi?id=53735

  • public/WebNotification.h:
  • src/WebNotification.cpp:

2011-02-07 Adam Klein <adamk@chromium.org>

Reviewed by Jian Li.

[chromium] Remove deprecated method WebNotification::dir
https://bugs.webkit.org/show_bug.cgi?id=53735

  • DumpRenderTree/chromium/NotificationPresenter.cpp: (NotificationPresenter::show):
22:02 Changeset [77895] by paroga@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-07 Patrick Gansterer <paroga@webkit.org>

Reviewed by Eric Seidel.

Add missing PaintInfo include in RenderThemeWin.cpp
https://bugs.webkit.org/show_bug.cgi?id=53885

  • rendering/RenderThemeWin.cpp:
21:39 Changeset [77894] by jamesr@google.com
  • 1 edit
    3 moves in trunk/LayoutTests

2011-02-07 James Robinson <jamesr@chromium.org>

Move sputnik expectations to match test movement.

  • platform/gtk/fast/js/sputnik: Removed.
  • platform/gtk/fast/js/sputnik/Unicode: Removed.
  • platform/gtk/fast/js/sputnik/Unicode/Unicode_510: Removed.
  • platform/gtk/fast/js/sputnik/Unicode/Unicode_510/S7.6_A3.2-expected.txt: Removed.
  • platform/gtk/fast/js/sputnik/Unicode/Unicode_510/S7.6_A5.3_T1-expected.txt: Removed.
  • platform/gtk/fast/js/sputnik/Unicode/Unicode_510/S7.6_A5.3_T2-expected.txt: Removed.
  • platform/gtk/sputnik: Copied from LayoutTests/platform/gtk/fast/js/sputnik.
  • platform/mac-leopard/fast/js/sputnik: Removed.
  • platform/mac-leopard/fast/js/sputnik/Unicode: Removed.
  • platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_500: Removed.
  • platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_500/S7.6_A3.1-expected.txt: Removed.
  • platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_500/S7.6_A3.2-expected.txt: Removed.
  • platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_500/S7.6_A5.3_T1-expected.txt: Removed.
  • platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_500/S7.6_A5.3_T2-expected.txt: Removed.
  • platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510: Removed.
  • platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S15.5.4.16_A1-expected.txt: Removed.
  • platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S15.5.4.18_A1-expected.txt: Removed.
  • platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A1.1_T1-expected.txt: Removed.
  • platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A1.1_T2-expected.txt: Removed.
  • platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A1.1_T4-expected.txt: Removed.
  • platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A2.2_T1-expected.txt: Removed.
  • platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A2.2_T2-expected.txt: Removed.
  • platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A2.3-expected.txt: Removed.
  • platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A5.2_T1-expected.txt: Removed.
  • platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A5.2_T2-expected.txt: Removed.
  • platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A5.2_T4-expected.txt: Removed.
  • platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A5.2_T7-expected.txt: Removed.
  • platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A5.2_T8-expected.txt: Removed.
  • platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A5.2_T9-expected.txt: Removed.
  • platform/mac-leopard/sputnik: Copied from LayoutTests/platform/mac-leopard/fast/js/sputnik.
  • platform/win/fast/js/sputnik: Removed.
  • platform/win/fast/js/sputnik/Conformance: Removed.
  • platform/win/fast/js/sputnik/Conformance/11_Expressions: Removed.
  • platform/win/fast/js/sputnik/Conformance/11_Expressions/11.5_Multiplicative_Operators: Removed.
  • platform/win/fast/js/sputnik/Conformance/11_Expressions/11.5_Multiplicative_Operators/11.5.3_Percent: Removed.
  • platform/win/fast/js/sputnik/Conformance/11_Expressions/11.5_Multiplicative_Operators/11.5.3_Percent/S11.5.3_A4_T6-expected.txt: Removed.
  • platform/win/fast/js/sputnik/Unicode: Removed.
  • platform/win/fast/js/sputnik/Unicode/Unicode_510: Removed.
  • platform/win/fast/js/sputnik/Unicode/Unicode_510/S7.6_A3.1-expected.txt: Removed.
  • platform/win/fast/js/sputnik/Unicode/Unicode_510/S7.6_A3.2-expected.txt: Removed.
  • platform/win/fast/js/sputnik/Unicode/Unicode_510/S7.6_A5.3_T1-expected.txt: Removed.
  • platform/win/fast/js/sputnik/Unicode/Unicode_510/S7.6_A5.3_T2-expected.txt: Removed.
  • platform/win/sputnik: Copied from LayoutTests/platform/win/fast/js/sputnik.
21:37 Changeset [77893] by commit-queue@webkit.org
  • 37 edits
    38 deletes in trunk/LayoutTests

2011-02-07 Ami Fischman <fischman@google.com>

Reviewed by Eric Carlson.

Removed two of the three almost-duplicate test expectations
between {media,platform/chromium-{mac,win}} by excluding file
extensions from the emitted output.
Removed outdated test_expectation for deleted test.
http://crbug.com/28993

  • media/controls-right-click-on-timebar-expected.txt:
  • media/controls-right-click-on-timebar.html:
  • media/media-file.js: (stripExtension):
  • media/media-startTime-expected.txt:
  • media/media-startTime.html:
  • media/video-append-source-expected.txt:
  • media/video-append-source.html:
  • media/video-canvas-source-expected.txt:
  • media/video-canvas-source.html:
  • media/video-dom-src-expected.txt:
  • media/video-dom-src.html:
  • media/video-load-networkState-expected.txt:
  • media/video-load-networkState.html:
  • media/video-played-reset-expected.txt:
  • media/video-played-reset.html:
  • media/video-seek-past-end-paused-expected.txt:
  • media/video-seek-past-end-paused.html:
  • media/video-seek-past-end-playing-expected.txt:
  • media/video-seek-past-end-playing.html:
  • media/video-source-expected.txt:
  • media/video-source-type-expected.txt:
  • media/video-source-type-params-expected.txt:
  • media/video-source-type-params.html:
  • media/video-source-type.html:
  • media/video-source.html:
  • media/video-src-change-expected.txt:
  • media/video-src-change.html:
  • media/video-src-expected.txt:
  • media/video-src-remove-expected.txt:
  • media/video-src-remove.html:
  • media/video-src-set-expected.txt:
  • media/video-src-set.html:
  • media/video-src-source-expected.txt:
  • media/video-src-source.html:
  • media/video-src.html:
  • media/video-test.js: (enableFullTestDetailsPrinting): (test): (testExpected): (waitForEvent._eventCallback): (waitForEvent): (waitForEventAndTest._eventCallback): (waitForEventAndTest): (testException): (endTest):
  • platform/chromium-mac/media/controls-right-click-on-timebar-expected.txt: Removed.
  • platform/chromium-mac/media/media-startTime-expected.txt: Removed.
  • platform/chromium-mac/media/video-append-source-expected.txt: Removed.
  • platform/chromium-mac/media/video-canvas-source-expected.txt: Removed.
  • platform/chromium-mac/media/video-dom-src-expected.txt: Removed.
  • platform/chromium-mac/media/video-load-networkState-expected.txt: Removed.
  • platform/chromium-mac/media/video-played-reset-expected.txt: Removed.
  • platform/chromium-mac/media/video-seek-past-end-paused-expected.txt: Removed.
  • platform/chromium-mac/media/video-seek-past-end-playing-expected.txt: Removed.
  • platform/chromium-mac/media/video-source-add-src-expected.txt: Removed.
  • platform/chromium-mac/media/video-source-error-expected.txt: Removed.
  • platform/chromium-mac/media/video-source-expected.txt: Removed.
  • platform/chromium-mac/media/video-source-type-expected.txt: Removed.
  • platform/chromium-mac/media/video-source-type-params-expected.txt: Removed.
  • platform/chromium-mac/media/video-src-change-expected.txt: Removed.
  • platform/chromium-mac/media/video-src-expected.txt: Removed.
  • platform/chromium-mac/media/video-src-remove-expected.txt: Removed.
  • platform/chromium-mac/media/video-src-set-expected.txt: Removed.
  • platform/chromium-mac/media/video-src-source-expected.txt: Removed.
  • platform/chromium-win/media/controls-right-click-on-timebar-expected.txt: Removed.
  • platform/chromium-win/media/media-startTime-expected.txt: Removed.
  • platform/chromium-win/media/video-append-source-expected.txt: Removed.
  • platform/chromium-win/media/video-canvas-source-expected.txt: Removed.
  • platform/chromium-win/media/video-dom-src-expected.txt: Removed.
  • platform/chromium-win/media/video-load-networkState-expected.txt: Removed.
  • platform/chromium-win/media/video-played-reset-expected.txt: Removed.
  • platform/chromium-win/media/video-seek-past-end-paused-expected.txt: Removed.
  • platform/chromium-win/media/video-seek-past-end-playing-expected.txt: Removed.
  • platform/chromium-win/media/video-source-add-src-expected.txt: Removed.
  • platform/chromium-win/media/video-source-error-expected.txt: Removed.
  • platform/chromium-win/media/video-source-expected.txt: Removed.
  • platform/chromium-win/media/video-source-type-expected.txt: Removed.
  • platform/chromium-win/media/video-source-type-params-expected.txt: Removed.
  • platform/chromium-win/media/video-src-change-expected.txt: Removed.
  • platform/chromium-win/media/video-src-expected.txt: Removed.
  • platform/chromium-win/media/video-src-remove-expected.txt: Removed.
  • platform/chromium-win/media/video-src-set-expected.txt: Removed.
  • platform/chromium-win/media/video-src-source-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
21:37 Changeset [77892] by commit-queue@webkit.org
  • 14 edits in trunk/Source

2011-02-07 Qi Zhang <qi.2.zhang@nokia.com>

Reviewed by Andreas Kling.

[Qt] enum QWebPage::WebAction doesn't have value QWebPage::CopyImageUrl
https://bugs.webkit.org/show_bug.cgi?id=52974

Add ContextMenuItemTagCopyImageUrlToClipboard into standard action but Qt platform specific.

  • page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected): (WebCore::ContextMenuController::populate): (WebCore::ContextMenuController::checkOrEnableIfNeeded):
  • platform/ContextMenuItem.h:
  • platform/LocalizationStrategy.h:
  • platform/LocalizedStrings.cpp: (WebCore::contextMenuItemTagCopyImageUrlToClipboard):
  • platform/LocalizedStrings.h:

2011-02-07 Qi Zhang <qi.2.zhang@nokia.com>

Reviewed by Andreas Kling.

[Qt] enum QWebPage::WebAction doesn't have value QWebPage::CopyImageUrl
https://bugs.webkit.org/show_bug.cgi?id=52974

Add QWebPage::CopyImageUrlToClipboard into QWebPage::WebAction.

  • Api/qwebpage.cpp: (webActionForContextMenuAction): (QWebPage::triggerAction): (QWebPage::action):
  • Api/qwebpage.h:
  • WebCoreSupport/WebPlatformStrategies.cpp: (WebPlatformStrategies::contextMenuItemTagCopyImageUrlToClipboard):
  • WebCoreSupport/WebPlatformStrategies.h:

2011-02-07 Qi Zhang <qi.2.zhang@nokia.com>

Reviewed by Andreas Kling.

[Qt] enum QWebPage::WebAction doesn't have value QWebPage::CopyImageUrl
https://bugs.webkit.org/show_bug.cgi?id=52974

Add ContextMenuItemTagCopyImageUrlToClipboard into standard action but Qt platform specific.

  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp: (WebKit::WebPlatformStrategies::contextMenuItemTagCopyImageUrlToClipboard):
  • WebProcess/WebCoreSupport/WebPlatformStrategies.h:
21:28 Changeset [77891] by tkent@chromium.org
  • 4 edits
    2 adds in trunk

2011-02-07 Kenichi Ishibashi <bashi@chromium.org>

Reviewed by Kent Tamura.

HTMLFormElement::formElementIndex() returns a bad index into a vector of form associated elements
https://bugs.webkit.org/show_bug.cgi?id=53970

Adds HTMLObjectElement::virtualForm() to make HTMLObjectElement::form()
return the right value.

Test: fast/dom/HTMLObjectElement/form/nested-form-element.html

  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::virtualForm): Added.
  • html/HTMLObjectElement.h: Added virtualForm().

2011-02-07 Kenichi Ishibashi <bashi@chromium.org>

Reviewed by Kent Tamura.

HTMLFormElement::formElementIndex() returns a bad index into a vector of form associated elements
https://bugs.webkit.org/show_bug.cgi?id=53970

Adds a test that ensures WebKit parses successfully a page that
contains object elements which are in nested and defective form
elements.

  • fast/dom/HTMLObjectElement/form/nested-form-element-expected.txt: Added.
  • fast/dom/HTMLObjectElement/form/nested-form-element.html: Added.
20:39 Changeset [77890] by abarth@webkit.org
  • 3 edits in trunk/Tools

2011-02-07 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Remove Leopard Debug as a core builder
https://bugs.webkit.org/show_bug.cgi?id=53971

The Leopard Debug builder has been failing to compile for several days.
My understanding is that folks are working on fixing the build, but for
the time being we should probably remove it from the list of core
builders so that the core waterfall can be green. We can certainly add
it back once the build is fixed.

Also, I've removed the Tiger builders because those no longer appear to
be attached to the buildbot master.

  • Scripts/webkitpy/common/net/buildbot/buildbot.py:
  • Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
20:29 Changeset [77889] by ojan@chromium.org
  • 5 edits in trunk

2011-02-01 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Roben.

include svn revisions in git diffs for the code review tool to use
https://bugs.webkit.org/show_bug.cgi?id=53569

  • Scripts/webkitpy/common/checkout/scm.py:
  • Scripts/webkitpy/common/checkout/scm_unittest.py:

2011-02-01 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Roben.

include svn revisions in git diffs for the code review tool to use
https://bugs.webkit.org/show_bug.cgi?id=53569

  • PrettyPatch/PrettyPatch.rb:
20:27 Changeset [77888] by rniwa@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-02-07 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed Leopard build fix.

  • WebCore.xcodeproj/project.pbxproj: let XCode have developmentRegion.
  • platform/mac/DragImageMac.mm: (WebCore::webkit_CGCeiling): Cast the return value of ceil to CGFloat.
20:21 Changeset [77887] by yuzo@google.com
  • 2 edits in trunk/LayoutTests

2011-02-07 Yuzo Fujishima <yuzo@google.com>

Unreviewed attempt to fix a flaky test.
https://bugs.webkit.org/show_bug.cgi?id=51757

  • fast/css/font-face-download-error.html:
20:07 Changeset [77886] by zmo@google.com
  • 2 edits in trunk/LayoutTests

2011-02-07 Zhenyao Mo <zmo@google.com>

Unreviewed, test expectations update.

  • platform/chromium/test_expectations.txt:
19:55 Changeset [77885] by jamesr@google.com
  • 8 edits
    1 move in trunk/LayoutTests

2011-02-07 James Robinson <jamesr@chromium.org>

Reviewed by Dan Bernstein.

Move the sputnik test suite out of fast/js/
https://bugs.webkit.org/show_bug.cgi?id=53954

The sputnik suite shouldn't go in fast/js/ because it is not fast and
it is an imported test suite. This moves it to LayoutTests/sputnik
and updates references in skipped lists / expectations.

  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/mac-tiger/Skipped:
  • platform/mac-wk2/Skipped:
  • platform/qt-wk2/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
19:37 Changeset [77884] by rniwa@webkit.org
  • 1 edit in trunk/Source/JavaScriptCore/ChangeLog

Fixing the change log entry.

19:34 Changeset [77883] by rniwa@webkit.org
  • 5 edits in trunk/Source/JavaScriptCore

2011-02-07 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Removed some dead code from Heap
https://bugs.webkit.org/show_bug.cgi?id=53969


SunSpider reports no change.

  • runtime/MarkedSpace.cpp: (JSC::MarkedSpace::shrink): (JSC::MarkedSpace::sweep):
  • runtime/MarkedSpace.h: Removed resizeBlocks and growBlocks, and renamed shrinkBlocks to shrink, making it unconditionally shrink as much as possible.
19:13 Changeset [77882] by enrica@apple.com
  • 4 edits in trunk/Source

Source/WebCore: Fixing a build break on Mac caused by http://trac.webkit.org/changeset/77874

Reviewed by Sam Weinig.

When moving code from WebKit to WebCore we needed to move some additional
functions previously in NSStringExtras.

  • WebCore.xcodeproj/project.pbxproj:
  • platform/mac/DragImageMac.mm:

(WebCore::fontFromNSFont):
(WebCore::canUseFastRenderer):
(WebCore::widthWithFont):
(WebCore::webkit_CGCeiling):
(WebCore::drawAtPoint):
(WebCore::drawDoubledAtPoint):
(WebCore::createDragImageForLink):

Source/WebKit2: Fixing a build break on Mac caused by http://trac.webkit.org/changeset/77874

Reviewed by Sam Weinig.

Removed unused static function.

  • WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:
19:08 Changeset [77881] by ggaren@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

2011-02-07 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Removed some dead code from Heap
https://bugs.webkit.org/show_bug.cgi?id=53969


SunSpider reports no change.

  • runtime/MarkedSpace.cpp: (JSC::MarkedSpace::shrink): (JSC::MarkedSpace::sweep):
  • runtime/MarkedSpace.h: Removed resizeBlocks and growBlocks, and renamed shrinkBlocks to shrink, making it unconditionally shrink as much as possible.
18:21 Changeset [77880] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

<rdar://problem/8969888>
The WebProcess should set LSFileQuarantineEnabled to true

Reviewed by Sam Weinig.

  • WebProcess/Info.plist:
18:13 Changeset [77879] by zmo@google.com
  • 2 edits in trunk/LayoutTests

2011-02-07 Zhenyao Mo <zmo@google.com>

Unreviewed, test expectations update.

  • platform/chromium/test_expectations.txt:
18:04 Changeset [77878] by lforschler@apple.com
  • 3 edits in trunk/Source/WebCore

2011-02-07 Lucas Forschler <lforschler@apple.com>

Reviewed by Geoff Garen.

Tr #2, Fix the Leopard 32bit debug build.


No new tests required.

  • WebCore.xcodeproj/project.pbxproj:
  • accessibility/AccessibilityAllInOne.cpp:
17:58 Changeset [77877] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2011-02-07 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Simplified the marked space's mark invariant
https://bugs.webkit.org/show_bug.cgi?id=53968


SunSpider reports no change.


  • runtime/MarkedSpace.cpp: (JSC::MarkedSpace::allocate): Mark objects when allocating them. This means that, at all times other than the mark phase, an object is live if and only if it is marked.

(JSC::MarkedSpace::containsSlowCase): Use the new mark invariant to
simplify testing whether an object is live.

17:53 Changeset [77876] by bdakin@apple.com
  • 3 edits in trunk/Source/WebCore

Fix for <rdar://problem/8946961> Fix repaint problems
with WKScrollbarPainter scrollers while resizing the window

Reviewed by Sam Weinig.

Remove setPainterForPainterController() and
removePainterFromPainterController() since they aren't
used anymore.

  • platform/mac/ScrollAnimatorMac.h:


Return early if they alpha hasn't changed.

  • platform/mac/ScrollAnimatorMac.mm:

(-[ScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:]):
(-[ScrollbarPainterDelegate scrollerImp:animateTrackAlphaTo:duration:]):

If we're in a live resize, restore alpha to 1.
(WebCore::ScrollAnimatorMac::didAddVerticalScrollbar):
(WebCore::ScrollAnimatorMac::didAddHorizontalScrollbar):

17:47 Changeset [77875] by morrita@google.com
  • 15 edits
    4 adds in trunk

2011-02-03 MORITA Hajime <morrita@google.com>

Reviewed by Darin Fisher.

[Chromium] Should implement EditorClientImpl::requestCheckingOfString()
https://bugs.webkit.org/show_bug.cgi?id=51013

Unskipped passed test.

  • platform/chromium/test_expectations.txt:

2011-02-03 MORITA Hajime <morrita@google.com>

Reviewed by Darin Fisher.

[Chromium] Should implement EditorClientImpl::requestCheckingOfString()
https://bugs.webkit.org/show_bug.cgi?id=51013

  • Added WebTextCheckingCompletion to receive the checked result asynchronously.
  • Added WebViewClient::requestCheckingOfText() and related classes.
  • Implemented EditorClientImpl::requestCheckingOfString().
  • WebKit.gyp:
  • public/WebSettings.h:
  • public/WebTextCheckingCompletion.h: Added. (WebKit::WebTextCheckingCompletion::~WebTextCheckingCompletion):
  • public/WebTextCheckingResult.h: Added. (WebKit::WebTextCheckingResult::error): (WebKit::WebTextCheckingResult::position): (WebKit::WebTextCheckingResult::length): (WebKit::WebTextCheckingResult::WebTextCheckingResult):
  • public/WebViewClient.h: (WebKit::WebViewClient::requestCheckingOfText): Gave an implementation
  • src/AssertMatchingEnums.cpp:
  • src/EditorClientImpl.cpp: (WebKit::EditorClientImpl::requestCheckingOfString):
  • src/EditorClientImpl.h:
  • src/WebSettingsImpl.cpp: (WebKit::WebSettingsImpl::setAsynchronousSpellCheckingEnabled):
  • src/WebSettingsImpl.h:
  • src/WebTextCheckingCompletionImpl.cpp: Added. (WebKit::toCoreResults): (WebKit::WebTextCheckingCompletionImpl::didFinishCheckingText):
  • src/WebTextCheckingCompletionImpl.h: Added. (WebKit::WebTextCheckingCompletionImpl::WebTextCheckingCompletionImpl):

2011-02-03 MORITA Hajime <morrita@google.com>

Reviewed by Darin Fisher.

[Chromium] Should implement EditorClientImpl::requestCheckingOfString()
https://bugs.webkit.org/show_bug.cgi?id=51013

Gave DRT implementation for requestTextCheck().

  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::setAsynchronousSpellCheckingEnabled): Implemented.
  • DumpRenderTree/chromium/WebViewHost.cpp: (invokeFinishLastTextCheck): Added. (WebViewHost::requestTextCheck): Added. (WebViewHost::finishLastTextCheck): Added.
  • DumpRenderTree/chromium/WebViewHost.h:
17:44 Changeset [77874] by andersca@apple.com
  • 8 edits in trunk/Source/WebKit2

2011-02-07 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Crash in web process after the connection had been closed
https://bugs.webkit.org/show_bug.cgi?id=51115
<rdar://problem/8964255>

Remove didCloseOnConnectionWorkQueue from Connection::Client and add
Connection::setDidCloseOnConnectionWorkQueueCallback which takes a static
function, eliminating the race condition in connectionDidClose where m_client could be
nulled out in the client thread right before we try to dereference it.

  • Platform/CoreIPC/Connection.cpp: (CoreIPC::Connection::Connection): Initialize m_didCloseOnConnectionWorkQueueCallback.

(CoreIPC::Connection::setDidCloseOnConnectionWorkQueueCallback):
Update m_didCloseOnConnectionWorkQueueCallback.

(CoreIPC::Connection::connectionDidClose):
Call m_didCloseOnConnectionWorkQueueCallback.

  • Platform/WorkQueue.h: Make WorkQueue noncopyable.
  • PluginProcess/PluginProcess.cpp: (WebKit::PluginProcess::initializeConnection): Call setDidCloseOnConnectionWorkQueueCallback.
  • Shared/ChildProcess.cpp: (WebKit::ChildProcess::didCloseOnConnectionWorkQueue):
  • Shared/ChildProcess.h: didCloseOnConnectionWorkQueue is now a static member function.
  • WebProcess/WebProcess.cpp: (WebKit::WebProcess::initialize): Call setDidCloseOnConnectionWorkQueueCallback.
17:39 Changeset [77873] by mrobinson@webkit.org
  • 2 edits
    59 adds in trunk/LayoutTests

2011-02-07 Martin Robinson <mrobinson@igalia.com>

Classify tests failing in the fast directory on GTK+. Add results for
tests that just need platform expectations.

  • platform/gtk/Skipped: Update the skipped list.
  • platform/gtk/fast/backgrounds/background-clip-text-expected.checksum: Added.
  • platform/gtk/fast/backgrounds/background-clip-text-expected.png: Added.
  • platform/gtk/fast/backgrounds/background-clip-text-expected.txt: Added.
  • platform/gtk/fast/canvas/canvas-zoom-expected.txt: Added.
  • platform/gtk/fast/css/css1_forward_compatible_parsing-expected.checksum: Added.
  • platform/gtk/fast/css/css1_forward_compatible_parsing-expected.png: Added.
  • platform/gtk/fast/css/css1_forward_compatible_parsing-expected.txt: Added.
  • platform/gtk/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Added.
  • platform/gtk/fast/css/invalid-percentage-property-expected.checksum: Added.
  • platform/gtk/fast/css/invalid-percentage-property-expected.png: Added.
  • platform/gtk/fast/css/invalid-percentage-property-expected.txt: Added.
  • platform/gtk/fast/css/text-align-expected.checksum: Added.
  • platform/gtk/fast/css/text-align-expected.png: Added.
  • platform/gtk/fast/css/text-align-expected.txt: Added.
  • platform/gtk/fast/dom/Element/getBoundingClientRect-expected.txt: Added.
  • platform/gtk/fast/dom/Range/getBoundingClientRect-expected.txt: Added.
  • platform/gtk/fast/dom/Range/getClientRects-expected.txt: Added.
  • platform/gtk/fast/dom/Window/webkitConvertPoint-expected.txt: Added.
  • platform/gtk/fast/dom/null-document-location-put-crash-expected.txt: Added.
  • platform/gtk/fast/dom/tabindex-clamp-expected.txt: Added.
  • platform/gtk/fast/events/js-keyboard-event-creation-expected.txt: Added.
  • platform/gtk/fast/events/offsetX-offsetY-expected.txt: Added.
  • platform/gtk/fast/events/pointer-events-2-expected.checksum: Added.
  • platform/gtk/fast/events/pointer-events-2-expected.png: Added.
  • platform/gtk/fast/events/pointer-events-2-expected.txt: Added.
  • platform/gtk/fast/fast-mobile-scrolling/fixed-position-element-expected.checksum: Added.
  • platform/gtk/fast/fast-mobile-scrolling/fixed-position-element-expected.png: Added.
  • platform/gtk/fast/fast-mobile-scrolling/fixed-position-element-expected.txt: Added.
  • platform/gtk/fast/fast-mobile-scrolling/no-fixed-position-elements-expected.checksum: Added.
  • platform/gtk/fast/fast-mobile-scrolling/no-fixed-position-elements-expected.png: Added.
  • platform/gtk/fast/fast-mobile-scrolling/no-fixed-position-elements-expected.txt: Added.
  • platform/gtk/fast/forms/listbox-hit-test-zoomed-expected.checksum: Added.
  • platform/gtk/fast/forms/listbox-hit-test-zoomed-expected.png: Added.
  • platform/gtk/fast/forms/listbox-hit-test-zoomed-expected.txt: Added.
  • platform/gtk/fast/html/tab-order-expected.txt: Added.
  • platform/gtk/fast/replaced/table-percent-height-expected.txt: Added.
  • platform/gtk/fast/selectors/lang-inheritance-expected.checksum: Added.
  • platform/gtk/fast/selectors/lang-inheritance-expected.png: Added.
  • platform/gtk/fast/selectors/lang-inheritance-expected.txt: Added.
  • platform/gtk/fast/selectors/lang-inheritance2-expected.checksum: Added.
  • platform/gtk/fast/selectors/lang-inheritance2-expected.png: Added.
  • platform/gtk/fast/selectors/lang-inheritance2-expected.txt: Added.
  • platform/gtk/fast/selectors/lang-vs-xml-lang-expected.checksum: Added.
  • platform/gtk/fast/selectors/lang-vs-xml-lang-expected.png: Added.
  • platform/gtk/fast/selectors/lang-vs-xml-lang-expected.txt: Added.
  • platform/gtk/fast/selectors/lang-vs-xml-lang-xhtml-expected.checksum: Added.
  • platform/gtk/fast/selectors/lang-vs-xml-lang-xhtml-expected.png: Added.
  • platform/gtk/fast/selectors/lang-vs-xml-lang-xhtml-expected.txt: Added.
  • platform/gtk/fast/text/international/danda-space-expected.checksum: Added.
  • platform/gtk/fast/text/international/danda-space-expected.png: Added.
  • platform/gtk/fast/text/international/danda-space-expected.txt: Added.
  • platform/gtk/fast/text/international/thai-baht-space-expected.checksum: Added.
  • platform/gtk/fast/text/international/thai-baht-space-expected.png: Added.
  • platform/gtk/fast/text/international/thai-baht-space-expected.txt: Added.
17:38 Changeset [77872] by zmo@google.com
  • 2 edits in trunk/LayoutTests

2011-02-07 Zhenyao Mo <zmo@google.com>

Unreviewed, test expectations update.

  • platform/chromium/test_expectations.txt:
17:35 Changeset [77871] by bdakin@apple.com
  • 4 edits in trunk/Source

Fix for https://bugs.webkit.org/show_bug.cgi?id=53950
USE_WK_SCROLLBAR_PAINTER in ScrollbarThemeMac should be in
Platform.h instead

Reviewed by Eric Seidel.

../JavaScriptCore:

  • wtf/Platform.h:

../WebCore:

Use hot new USE(WK_SCROLLBAR_PAINTER) from Platform.h rather
than the silly, old in-file #define.

  • platform/mac/ScrollbarThemeMac.mm:

(+[ScrollbarPrefsObserver appearancePrefsChanged:]):
(WebCore::updateArrowPlacement):
(WebCore::ScrollbarThemeMac::registerScrollbar):
(WebCore::ScrollbarThemeMac::scrollbarThickness):
(WebCore::ScrollbarThemeMac::usesOverlayScrollbars):
(WebCore::ScrollbarThemeMac::hasThumb):
(WebCore::ScrollbarThemeMac::minimumThumbLength):
(WebCore::ScrollbarThemeMac::paint):

17:34 Changeset [77870] by enrica@apple.com
  • 47 edits
    3 adds in trunk/Source

Reviewed Adam Roben and Darin Adler.

Source/WebCore:

WebKit2: drag and drop support on Windows.
https://bugs.webkit.org/show_bug.cgi?id=52775
<rdar://problem/8514409>

  • loader/EmptyClients.h: Removed createDragImageFromLink.
  • page/DragClient.h: Ditto.
  • page/DragController.cpp:

(WebCore::DragController::startDrag): changed call to createDragImageFromLink.

  • platform/DragImage.h:
  • platform/mac/DragImageMac.mm:

(WebCore::createDragImageForLink): Moved from DragClient.

  • platform/win/ClipboardUtilitiesWin.cpp: Added a series of functions

to de-serialize the drag data from the map into an IDataObject.
(WebCore::getWebLocData):
(WebCore::texthtmlFormat):
(WebCore::createGlobalData):
(WebCore::getFullCFHTML):
(WebCore::urlWFormat):
(WebCore::urlFormat):
(WebCore::filenameWFormat):
(WebCore::filenameFormat):
(WebCore::htmlFormat):
(WebCore::smartPasteFormat):
(WebCore::getURL):
(WebCore::getPlainText):
(WebCore::getTextHTML):
(WebCore::ClipboardDataItem::ClipboardDataItem):
(WebCore::getStringData):
(WebCore::getUtf8Data):
(WebCore::getCFData):
(WebCore::setUCharData):
(WebCore::setCharData):
(WebCore::setCFData):
(WebCore::getClipboardMap):
(WebCore::getClipboardData):
(WebCore::setClipboardData):

  • platform/win/ClipboardUtilitiesWin.h:
  • platform/win/DragImageWin.cpp: Moved createDragImageForLink from DragClient

to a platform specific file in WebCore. It makes a lot more sense here, since
the drag image is always created in WebCore for all the other content types
except for links.
(WebCore::dragLabelFont):
(WebCore::createDragImageForLink):

  • platform/win/WCDataObject.cpp: Added new way to

construct a WCDataObject from a DragDataMap.
(WebCore::WCDataObject::createInstance):
(WebCore::WCDataObject::clearData):

  • platform/win/WCDataObject.h:

Source/WebKit/chromium:

WebKit2: drag and drop support on Windows.
https://bugs.webkit.org/show_bug.cgi?id=52775

Removed createDragImageForLink from DragClient.

  • src/DragClientImpl.cpp:
  • src/DragClientImpl.h:

Source/WebKit/efl:

WebKit2: drag and drop support on Windows.
https://bugs.webkit.org/show_bug.cgi?id=52775

Removed createDragImageForLink from DragClient.

  • WebCoreSupport/DragClientEfl.cpp:
  • WebCoreSupport/DragClientEfl.h:

Source/WebKit/gtk:

WebKit2: drag and drop support on Windows.
https://bugs.webkit.org/show_bug.cgi?id=52775

Removed createDragImageForLink from DragClient.

  • WebCoreSupport/DragClientGtk.cpp:
  • WebCoreSupport/DragClientGtk.h:

Source/WebKit/haiku:

WebKit2: drag and drop support on Windows.
https://bugs.webkit.org/show_bug.cgi?id=52775

Removed createDragImageForLink from DragClient.

  • WebCoreSupport/DragClientHaiku.cpp:
  • WebCoreSupport/DragClientHaiku.h:

Source/WebKit/mac:

WebKit2: drag and drop support on Windows.
https://bugs.webkit.org/show_bug.cgi?id=52775

Removed createDragImageForLink from DragClient.

  • WebCoreSupport/WebDragClient.h:
  • WebCoreSupport/WebDragClient.mm:

(WebDragClient::startDrag):

Source/WebKit/qt:

WebKit2: drag and drop support on Windows.
https://bugs.webkit.org/show_bug.cgi?id=52775

Removed createDragImageForLink from DragClient.

  • WebCoreSupport/DragClientQt.cpp:
  • WebCoreSupport/DragClientQt.h:

Source/WebKit/win:

WebKit2: drag and drop support on Windows.
https://bugs.webkit.org/show_bug.cgi?id=52775

Removed createDragImageForLink from DragClient.

  • WebCoreSupport/WebDragClient.cpp:

(WebDragClient::startDrag):

  • WebCoreSupport/WebDragClient.h:

Source/WebKit/wince:

WebKit2: drag and drop support on Windows.
https://bugs.webkit.org/show_bug.cgi?id=52775

Removed createDragImageForLink from DragClient.

  • WebCoreSupport/DragClientWinCE.cpp:
  • WebCoreSupport/DragClientWinCE.h:

Source/WebKit/wx:

WebKit2: drag and drop support on Windows.
https://bugs.webkit.org/show_bug.cgi?id=52775

Removed createDragImageForLink from DragClient.

  • WebKitSupport/DragClientWx.cpp:
  • WebKitSupport/DragClientWx.h:

Source/WebKit2:

WebKit2: drag and drop support on Windows.
https://bugs.webkit.org/show_bug.cgi?id=52775
<rdar://problem/8514409>

This patch contains the remaining work to support
a WebKit window as drag source on Windows.
I've added the code to generate the image for dragging a link as
well as the steps necessary to package the HBITMAP into a SharedMemory
object and send it over to the UI process where DoDragDrop is performed.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::setDragImage):
(WebKit::WebPageProxy::startDragDrop):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/WebCoreSupport/WebDragClient.cpp:

(WebKit::WebDragClient::startDrag): Made startDrag for
platforms other than Windows and Mac.

  • WebProcess/WebCoreSupport/WebDragClient.h:
  • WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:

(WebKit::WebDragClient::startDrag):

  • WebProcess/WebCoreSupport/win/WebDragClientWin.cpp: Added.

(WebKit::draggingSourceOperationMaskToDragCursors):
(WebKit::WebDragClient::startDrag):

  • WebProcess/WebCoreSupport/win/WebDragSource.cpp: Added.

This object implements the IDropSource interface.
(WebDragSource::createInstance):
(WebDragSource::WebDragSource):
(WebDragSource::QueryInterface):
(WebDragSource::AddRef):
(WebDragSource::Release):
(WebDragSource::QueryContinueDrag):
(WebDragSource::GiveFeedback):

  • WebProcess/WebCoreSupport/win/WebDragSource.h: Added.
  • win/WebKit2.vcproj:
17:32 Changeset [77869] by zmo@google.com
  • 2 edits in trunk/LayoutTests

2011-02-07 Zhenyao Mo <zmo@google.com>

Unreviewed, test expectations update.

  • platform/chromium/test_expectations.txt:
17:23 Changeset [77868] by joone.hur@collabora.co.uk
  • 8 edits
    1 add in trunk

2011-02-07 Joone Hur <joone.hur@collabora.co.uk>

Reviewed by Martin Robinson.

[Gtk] Implement layoutTestController.findString
https://bugs.webkit.org/show_bug.cgi?id=50237

Unskip editing/text-iterator/findString.html.

  • platform/gtk/Skipped: Unskip findString test.

2011-02-07 Joone Hur <joone.hur@collabora.co.uk>

Reviewed by Martin Robinson.

[Gtk] Implement layoutTestController.findString
https://bugs.webkit.org/show_bug.cgi?id=50237

  • GNUmakefile.am: Add AssertMatchingEnums.cpp.
  • WebCoreSupport/AssertMatchingEnums.cpp: Add this file to assert that various WebKit API enum values continue matching WebCore defined enum values.
  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp: (DumpRenderTreeSupportGtk::findString):
  • WebCoreSupport/DumpRenderTreeSupportGtk.h:

2011-02-07 Joone Hur <joone.hur@collabora.co.uk>

Reviewed by Martin Robinson.

[Gtk] Implement layoutTestController.findString
https://bugs.webkit.org/show_bug.cgi?id=50237

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::findString):
17:02 Changeset [77867] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-07 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r77848.
http://trac.webkit.org/changeset/77848
https://bugs.webkit.org/show_bug.cgi?id=53963

caused 6 test failures (Requested by othermaciej on #webkit).

  • rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::computeInlineDirectionPositionsForLine):
17:00 Changeset [77866] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-02-07 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

UI process crashes if web process crashes while web inspector is focused
https://bugs.webkit.org/show_bug.cgi?id=53965
<rdar://problem/8961633>

Make sure to close the web inspector web page proxy before calling platformClose, since
platformClose can cause the web page proxy to try to send messages (such as SetActive)
to the web process while it's in a bad state.

  • UIProcess/WebInspectorProxy.cpp: (WebKit::WebInspectorProxy::didClose):
16:57 Changeset [77865] by kbr@google.com
  • 5 edits
    4 adds in trunk/Source/WebCore

2011-02-04 Kenneth Russell <kbr@google.com>

Reviewed by James Robinson.

Add shaders for GPU accelerated path rendering
https://bugs.webkit.org/show_bug.cgi?id=45520

Refactored SolidFillShader and TexShader to call new
generateVertex() and generateFragment() methods on base Shader
class, and added support for the Loop/Blinn shaders. Refactored
Loop/Blinn shader classes to derive from Shader.

Tested these changes with several of the IE9 Testdrive demos with
accelerated 2D canvas enabled, as well as a full layout test run
with --platform chromium-gpu.

  • platform/graphics/gpu/LoopBlinnShader.cpp: Added. (WebCore::LoopBlinnShader::LoopBlinnShader): (WebCore::LoopBlinnShader::use):
  • platform/graphics/gpu/LoopBlinnShader.h: Added.
  • platform/graphics/gpu/LoopBlinnSolidFillShader.cpp: Added. (WebCore::LoopBlinnSolidFillShader::create): (WebCore::LoopBlinnSolidFillShader::LoopBlinnSolidFillShader): (WebCore::LoopBlinnSolidFillShader::use):
  • platform/graphics/gpu/LoopBlinnSolidFillShader.h: Added.
  • platform/graphics/gpu/Shader.cpp: (WebCore::Shader::affineTo4x4): (WebCore::Shader::loadShader): (WebCore::Shader::loadProgram): (WebCore::Shader::generateVertex): (WebCore::Shader::generateFragment):
  • platform/graphics/gpu/Shader.h:
  • platform/graphics/gpu/SolidFillShader.cpp: (WebCore::SolidFillShader::create):
  • platform/graphics/gpu/TexShader.cpp: (WebCore::TexShader::TexShader): (WebCore::TexShader::create):
16:51 Changeset [77864] by mjs@apple.com
  • 2 edits in trunk/LayoutTests

2011-02-07 Maciej Stachowiak <mjs@apple.com>

Reviewed by Sam Weinig.

Skip a newly added test that uses unimplemented DRT functionality
https://bugs.webkit.org/show_bug.cgi?id=53938

  • platform/mac-wk2/Skipped:
16:30 Changeset [77863] by zmo@google.com
  • 5 edits
    1 add in trunk/LayoutTests

2011-02-07 Zhenyao Mo <zmo@google.com>

Unreviewed, rebaseline.

  • platform/chromium-linux/fast/html/keygen-expected.checksum:
  • platform/chromium-linux/fast/html/keygen-expected.png:
  • platform/chromium-linux/fast/html/keygen-expected.txt: Added.
  • platform/chromium-win/fast/html/keygen-expected.txt:
  • platform/chromium/test_expectations.txt:
16:29 Changeset [77862] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-02-07 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler.

Find bouncy is missing content on pages with framesets
https://bugs.webkit.org/show_bug.cgi?id=53958
<rdar://problem/8904447>

Fix paint rect computation; FrameView::paint expects the paint rect to be in the
parent widget's coordinate system.

  • WebProcess/WebPage/FindController.cpp: (WebKit::FindController::updateFindIndicator):
16:22 Changeset [77861] by beidson@apple.com
  • 2 edits in trunk/Source/WebKit2

<rdar://problem/8960434> and https://bugs.webkit.org/show_bug.cgi?id=53957
Crash after incorrectly restoring bogus session state.

Reviewed by Anders Carlsson.

In some cases we're writing an invalid session state for a back/forward list where the current entry is 0
but the number of entries is also 0.
In such cases the current entry should be "NoCurrentEntryIndex."

When we later read this state in, we set ourselves up to crash later.

Amusingly an ASSERT caught this, but we should've rejected it before the ASSERT fired.

  • UIProcess/cf/WebBackForwardListCF.cpp:

(WebKit::WebBackForwardList::restoreFromCFDictionaryRepresentation): Fail the restore if the "current index past the end

of the list" case occurs, and speculatively bail out of the case where we have no current index but do have a list.
Also remove the unhelpful ASSERT.

16:22 Changeset [77860] by zmo@google.com
  • 2 edits in trunk/LayoutTests

2011-02-07 Zhenyao Mo <zmo@google.com>

Unreviewed, test expectations update.

  • platform/chromium/test_expectations.txt:
16:11 Changeset [77859] by zmo@google.com
  • 2 edits in trunk/LayoutTests

2011-02-07 Zhenyao Mo <zmo@google.com>

Unreviewed, test expectations update.

  • platform/chromium/test_expectations.txt:
16:07 Changeset [77858] by mitz@apple.com
  • 3 edits in trunk/Source/WebCore

<rdar://problem/8946023> REGRESSION (r76674): SVG + BiDi text broken (text-intro-05-t.svg)
https://bugs.webkit.org/show_bug.cgi?id=53480

Reviewed by Oliver Hunt.

  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/mac/ComplexTextController.cpp:

(WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun): m_indexEnd should be an
offset into m_characters, not into the run’s characters.

  • platform/graphics/mac/ComplexTextControllerATSUI.cpp:

(WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun): Ditto.

16:01 Changeset [77857] by zmo@google.com
  • 2 edits in trunk/LayoutTests

2011-02-07 Zhenyao Mo <zmo@google.com>

Unreviewed, test expectations update.

  • platform/chromium/test_expectations.txt:
15:46 Changeset [77856] by weinig@apple.com
  • 7 edits in trunk/Source

Add bundle API to get the background color of a frame
<rdar://problem/8962670>
https://bugs.webkit.org/show_bug.cgi?id=53952

Reviewed by Anders Carlsson.

../WebCore:

  • WebCore.exp.in: Add export.

../WebKit2:

  • WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:

(WKBundleFrameGetBodyBackgroundColor):

  • WebProcess/InjectedBundle/API/c/WKBundleFrame.h:

Add API function.

  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::getDocumentBackgroundColor):

  • WebProcess/WebPage/WebFrame.h:

Call down into the document to get either the body's, or if there is no body,
the root element's, background color.

15:45 Changeset [77855] by ossy@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed.

[Qt] Fix crashes in QMetaObject::metacall
https://bugs.webkit.org/show_bug.cgi?id=53912

  • platform/qt/Skipped: http/tests/websocket/tests/websocket-pending-activity.html added until fix.
15:41 Changeset [77854] by zmo@google.com
  • 3 edits in trunk/LayoutTests

2011-02-07 Zhenyao Mo <zmo@google.com>

Unreviewed, rebaseline.

  • platform/chromium-mac/fast/url/path-expected.txt:
  • platform/chromium-win/fast/url/path-expected.txt:
15:37 Changeset [77853] by ggaren@apple.com
  • 4 edits in trunk/Source/WebCore

2011-02-07 Geoffrey Garen <ggaren@apple.com>

Reviewed by Darin Adler.

Assertion failure in ~JSGlobalObject when loading apple.com HTML5
transitions demo page
https://bugs.webkit.org/show_bug.cgi?id=53853

This was a long-standing bookkeeping bug uncovered by some heap refactoring.

  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::createImageBuffer):
  • html/HTMLImageLoader.cpp: (WebCore::HTMLImageLoader::notifyFinished):
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::dropProtection): Take the JSLock before reporting extra cost to the JavaScriptCore heap, since all use of JavaScriptCore is supposed to be guarded by JSLock.
15:28 Changeset [77852] by jianli@chromium.org
  • 8 edits in trunk

Intermittent crash in fast/files/read-blob-async.html on the GTK+ debug
bots
https://bugs.webkit.org/show_bug.cgi?id=53104

Reviewed by David Levin.

Source/WebCore:

Covered by the existing tests.

  • fileapi/FileStreamProxy.cpp:

(WebCore::FileStreamProxy::startOnFileThread):

  • platform/network/BlobRegistryImpl.cpp:

(WebCore::BlobRegistryImpl::createResourceHandle):

  • platform/network/BlobResourceHandle.cpp:

(WebCore::BlobResourceHandle::BlobResourceHandle):
(WebCore::BlobResourceHandle::cancel):
(WebCore::delayedStartBlobResourceHandle):
(WebCore::BlobResourceHandle::start): Keep BlobResourceHandle alive
till the delay function is called.
(WebCore::BlobResourceHandle::doStart):
(WebCore::doNotifyFinish):
(WebCore::BlobResourceHandle::notifyFinish): Notify the client via the
standalone function to prevent the handle from being disposed immediately
by the client which will make the calls in the stack that're still bound
to the handle suffer.

  • platform/network/BlobResourceHandle.h:
  • platform/network/ResourceHandle.h: Change cancel() to virtual so that

BlobResourceHandle::cancel will be called when we abort a FileReader.

LayoutTests:

  • platform/gtk/Skipped: Enable the flakey test that has been fixed.
15:27 Changeset [77851] by abarth@webkit.org
  • 1 edit
    1 delete in trunk/LayoutTests

2011-02-07 Adam Barth <abarth@webkit.org>

Remove wrong platform-specific expectation.

  • platform/win/plugins/plugin-document-back-forward-expected.txt: Removed.
15:09 Changeset [77850] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-02-07 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r77845.
http://trac.webkit.org/changeset/77845
https://bugs.webkit.org/show_bug.cgi?id=53946

build failure (Requested by lforschler_ on #webkit).

  • WebCore.xcodeproj/project.pbxproj:
  • accessibility/AccessibilityAllInOne.cpp:
15:05 Changeset [77849] by darin@apple.com
  • 2 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=53939
fast/css/text-overflow-ellipsis.html failure after r77818/77819

  • platform/text/TextCodecICU.cpp:

(WebCore::TextCodecICU::registerExtendedEncodingNames):
Add back the "utf8" synonym for "UTF-8".

14:58 Changeset [77848] by hyatt@apple.com
  • 2 edits in trunk/Source/WebCore

Remove an unnecessary extra computeLogicalWidth() from line layout.

Reviewed by Dan Bernstein.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::computeInlineDirectionPositionsForLine):

14:34 Changeset [77847] by weinig@apple.com
  • 3 edits in trunk/Source/WebKit2

Fix typo. vectical -> vertical.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didChangeScrollbarsForMainFrame):

14:32 Changeset [77846] by weinig@apple.com
  • 8 edits in trunk/Source/WebKit2

Inform the UIProcess when main frame scrollbars change
<rdar://problem/8967496>
https://bugs.webkit.org/show_bug.cgi?id=53941

Reviewed by Anders Carlsson.

  • UIProcess/API/C/WKPage.cpp:

(WKPageHasHorizontalScrollbar):
(WKPageHasVerticalScrollbar):

  • UIProcess/API/C/WKPage.h:

Add API to query whether the main frame has scrollbars.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::close):
(WebKit::WebPageProxy::processDidCrash):
(WebKit::WebPageProxy::didChangeScrollbarsForMainFrame):

  • UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::hasHorizontalScrollbar):
(WebKit::WebPageProxy::hasVerticalScrollbar):
Store/update main frame scrollbar state.

  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::contentsSizeChanged):

  • WebProcess/WebCoreSupport/WebChromeClient.h:

(WebKit::WebChromeClient::WebChromeClient):
Post message when main frame scrollbar state changes.

14:28 Changeset [77845] by lforschler@apple.com
  • 3 edits in trunk/Source/WebCore

2011-02-07 Lucas Forschler <lforschler@apple.com>

Reviewed by Geoffrey Garen.

Fix Leopard Intel Debug Build.
<rdar://problem/8953606> REGRESSION: Can't link WebCore on 32-bit Leopard (53681)
This could potentially break windows, since I had to change #include <filename> to #include "filename"


  • WebCore.xcodeproj/project.pbxproj:
  • accessibility/AccessibilityAllInOne.cpp:
13:54 Changeset [77844] by zmo@google.com
  • 2 edits in trunk/LayoutTests

2011-02-07 Zhenyao Mo <zmo@google.com>

Unreviewed, test expectations update.

  • platform/chromium/test_expectations.txt:
13:48 Changeset [77843] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

Fix build.

  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::didAddVerticalScrollbar):
(WebCore::ScrollAnimatorMac::willRemoveVerticalScrollbar):
(WebCore::ScrollAnimatorMac::didAddHorizontalScrollbar):
(WebCore::ScrollAnimatorMac::willRemoveHorizontalScrollbar):

13:42 Changeset [77842] by andersca@apple.com
  • 8 edits in trunk/Source/WebKit2

2011-02-07 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Some content is not covered by Find-on-page overlay
https://bugs.webkit.org/show_bug.cgi?id=53937
<rdar://problem/8711353>

  • WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::didInstallPageOverlay): Call LayerTreeHost::didInstallPageOverlay.

(WebKit::DrawingAreaImpl::didUninstallPageOverlay):
Call LayerTreeHost::didUninstallPageOverlay.

(WebKit::DrawingAreaImpl::setPageOverlayNeedsDisplay):
Call LayerTreeHost::setPageOverlayNeedsDisplay.

  • WebProcess/WebPage/FindController.cpp: (WebKit::FindController::drawRect): Remove a bogus assertion.
  • WebProcess/WebPage/LayerTreeHost.h: Add new pure virtual member functions.
  • WebProcess/WebPage/PageOverlay.cpp: (WebKit::PageOverlay::setNeedsDisplay): Call DrawingArea::setPageOverlayNeedsDisplay.
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::installPageOverlay): Make sure to call PageOverlay::setNeedsDisplay after the page overlay has been installed.


  • WebProcess/WebPage/mac/LayerTreeHostMac.mm: (WebKit::LayerTreeHostMac::LayerTreeHostMac): Create the page overlay layer if needed.

(WebKit::LayerTreeHostMac::setNonCompositedContentsNeedDisplay):
Invalidate the page overlay layer as well.

(WebKit::LayerTreeHostMac::sizeDidChange):
Resize the page overlay layer.

(WebKit::LayerTreeHostMac::didInstallPageOverlay):
Create the page overlay layer.

(WebKit::LayerTreeHostMac::didUninstallPageOverlay):
Destroy the page overlay layer.

(WebKit::LayerTreeHostMac::setPageOverlayNeedsDisplay):
Call setNeedsDisplay on the page overlay layer.

(WebKit::LayerTreeHostMac::paintContents):
Handle painting the page overlay layer.

(WebKit::LayerTreeHostMac::flushPendingLayerChanges):
Flush the page overlay layer changes as well.

(WebKit::LayerTreeHostMac::createPageOverlayLayer):
Create a layer and add it as a sublayer of the root layer.

(WebKit::LayerTreeHostMac::destroyPageOverlayLayer):
Destroy the page overlay layer.

13:29 Changeset [77841] by weinig@apple.com
  • 9 edits in trunk/Source/WebCore

Add mechanism to inform the ScrollAnimator when Scrollbars are added
and removed.

Reviewed by Beth Dakin.

  • platform/ScrollAnimator.h:

(WebCore::ScrollAnimator::didAddVerticalScrollbar):
(WebCore::ScrollAnimator::willRemoveVerticalScrollbar):
(WebCore::ScrollAnimator::didAddHorizontalScrollbar):
(WebCore::ScrollAnimator::willRemoveHorizontalScrollbar):
Make virtual to allow platform specific overrides.

  • platform/ScrollView.cpp:

(WebCore::ScrollView::setHasHorizontalScrollbar):
(WebCore::ScrollView::setHasVerticalScrollbar):
Call new ScrollableArea functions.

  • platform/ScrollableArea.cpp:

(WebCore::ScrollableArea::didAddVerticalScrollbar):
(WebCore::ScrollableArea::willRemoveVerticalScrollbar):
(WebCore::ScrollableArea::didAddHorizontalScrollbar):
(WebCore::ScrollableArea::willRemoveHorizontalScrollbar):

  • platform/ScrollableArea.h:

Pipe to ScrollAnimator.

  • platform/mac/ScrollAnimatorMac.h:
  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::didAddVerticalScrollbar):
(WebCore::ScrollAnimatorMac::willRemoveVerticalScrollbar):
(WebCore::ScrollAnimatorMac::didAddHorizontalScrollbar):
(WebCore::ScrollAnimatorMac::willRemoveHorizontalScrollbar):

  • platform/mac/ScrollbarThemeMac.h:
  • platform/mac/ScrollbarThemeMac.mm:

(WebCore::ScrollbarThemeMac::registerScrollbar):
(WebCore::ScrollbarThemeMac::unregisterScrollbar):
(WebCore::ScrollbarThemeMac::painterForScrollbar):
Move painter delegate registration to the new didAdd/willRemove functions.

13:25 Changeset [77840] by zmo@google.com
  • 2 edits in trunk/LayoutTests

2011-02-07 Zhenyao Mo <zmo@google.com>

Unreviewed, test expectations update.

  • platform/chromium/test_expectations.txt:
13:19 Changeset [77839] by aroben@apple.com
  • 4 edits in trunk/Source/WebKit2

Make it possible to use DrawingAreaProxyImpl on Windows

It can be optionally turned on by setting the WEBKIT2_USE_NEW_DRAWING_AREA environment
variable. Turning it on by default is covered by <http://webkit.org/b/53805>.

Fixes <http://webkit.org/b/53879>.

Reviewed by Anders Carlsson.

  • UIProcess/BackingStore.h: Add an m_bitmap member on Windows.
  • UIProcess/win/BackingStoreWin.cpp:

(WebKit::BitmapDC::operator HDC):
(WebKit::BitmapDC::BitmapDC):
(WebKit::BitmapDC::~BitmapDC):
Added this helper class, which uses RAII to select a bitmap into a new memory DC.
(WebKit::BackingStore::paint): Wrap our bitmap in a BitmapDC and use ::BitBlt to copy the
specified rect into the destination DC.
(WebKit::createBitmap): New helper function, just creates a DIB section with the specified
size.
(WebKit::BackingStore::incorporateUpdate): Ported from BackingStoreMac.mm. It seems like
this code could be shared at some point.
(WebKit::BackingStore::scroll): Wrap our bitmap in a BitmapDC and use ::ScrollDC to scroll
the specified rect.

  • UIProcess/win/WebView.cpp:

(WebKit::useNewDrawingArea): Added. Returns true if the WEBKIT2_USE_NEW_DRAWING_AREA
environment variable is set.
(WebKit::drawPageBackground): New helper function. Code came from onPaintEvent.
(WebKit::WebView::onPaintEvent): Ported from -[WKView drawRect:].
(WebKit::WebView::createDrawingAreaProxy): Create a DrawingAreaProxyImpl if we're using the
new drawing area.

(WebKit::WebView::enterAcceleratedCompositingMode):
(WebKit::WebView::exitAcceleratedCompositingMode):
(WebKit::WebView::pageDidEnterAcceleratedCompositing):
(WebKit::WebView::pageDidLeaveAcceleratedCompositing):
Added some assertions to make sure these are only called when expected. We don't expect
enter/exitAcceleratedCompositingMode to be called at all right now, because accelerated
compositing is turned off in WebKit2 on Windows.

(WebKit::WebView::switchToDrawingAreaTypeIfNecessary): Ditto, and added a case for the
DrawingAreaInfo::Impl constant.

13:19 Changeset [77838] by aroben@apple.com
  • 13 edits
    2 copies in trunk/Source/WebKit2

Start compiling DrawingArea[Proxy]Impl and dependencies on Windows

Fixes <http://webkit.org/b/53875> WebKit2 on Windows should build DrawingArea[Proxy]Impl

Reviewed by Sam Weinig and Darin Adler.

  • Platform/Region.cpp:

(WebKit::Region::Shape::shapeOperation): Initialize variable to avoid a bogus "potentially
uninitialized variable" warning.

  • UIProcess/BackingStore.cpp: Removed #error for non-Mac platforms.
  • UIProcess/BackingStore.h: Added a PlatformGraphicsContext typedef for Windows.
  • UIProcess/DrawingAreaProxy.h:
  • UIProcess/DrawingAreaProxyImpl.cpp:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didReceiveMessage):
Allow Windows to compile the new drawing area code.

  • WebProcess/WebPage/DrawingArea.cpp:

(WebKit::DrawingArea::create): Allow creating a DrawingAreaImpl on Windows, too.

  • WebProcess/WebPage/DrawingArea.h:
  • WebProcess/WebPage/DrawingAreaImpl.cpp:
  • WebProcess/WebPage/LayerTreeHost.cpp:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::didReceiveMessage):
Allow Windows to compile the new drawing area code.

  • Shared/win/LayerTreeContextWin.cpp: Added.
  • UIProcess/win/BackingStoreWin.cpp: Added.

Stubbed out these files.

  • win/WebKit2.vcproj: Added new files.
12:57 Changeset [77837] by andersca@apple.com
  • 7 edits in trunk/Source/WebKit2

2011-02-07 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Rename some drawing area related member functions
https://bugs.webkit.org/show_bug.cgi?id=53935

  • WebProcess/WebPage/DrawingArea.h: (WebKit::DrawingArea::setPageOverlayNeedsDisplay):
  • WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::setNeedsDisplay): (WebKit::DrawingAreaImpl::setPageOverlayNeedsDisplay):
  • WebProcess/WebPage/DrawingAreaImpl.h:
  • WebProcess/WebPage/LayerTreeHost.h:
  • WebProcess/WebPage/mac/LayerTreeHostMac.h:
  • WebProcess/WebPage/mac/LayerTreeHostMac.mm: (WebKit::LayerTreeHostMac::setNonCompositedContentsNeedDisplay): (WebKit::LayerTreeHostMac::scrollNonCompositedContents):
12:49 Changeset [77836] by chang.shu@nokia.com
  • 2 edits in trunk/Tools

2011-02-07 Chang Shu <chang.shu@nokia.com>

Reviewed by Darin Adler.

We should disable spatial navigation explicitly during the initialization
of DumpRenderTree.
https://bugs.webkit.org/show_bug.cgi?id=53928

  • DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues):
12:43 Changeset [77835] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

2011-02-07 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Missing text match markers with accelerated content
https://bugs.webkit.org/show_bug.cgi?id=53934

When doing the fake paint that recomputes the text match rects, we need to
flatten compositing layers, otherwise the rects won't be updated until the next paint call.

(This worked by accident in WebKit1 because Safari calls -[NSWindow displayIfNeeded] on the containing
window before asking for the text match rects).

  • editing/Editor.cpp: (WebCore::Editor::countMatchesForText):
12:08 Changeset [77834] by antti@apple.com
  • 4 edits in trunk/Source/WebCore

REGRESSION(r77740): CSSStyleSelector accessing deleted memory for svg/dom/use-transform.svg
https://bugs.webkit.org/show_bug.cgi?id=53900

Reviewed by Andreas Kling.

Ignore link elements in shadow trees.

  • dom/Element.cpp:

(WebCore::StyleSelectorParentPusher::StyleSelectorParentPusher):
(WebCore::StyleSelectorParentPusher::~StyleSelectorParentPusher):

Some asserts to catch cases like this.

(WebCore::Element::attach):
(WebCore::Element::recalcStyle):

  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::HTMLLinkElement):
(WebCore::HTMLLinkElement::process):
(WebCore::HTMLLinkElement::insertedIntoDocument):
(WebCore::HTMLLinkElement::removedFromDocument):

  • html/HTMLLinkElement.h:
11:39 BuildingQtOnSymbian edited by siddharth.mathur@nokia.com
add .slimdebug (diff)
11:18 Changeset [77833] by dglazkov@chromium.org
  • 2 edits in trunk/LayoutTests

2011-02-07 Dimitri Glazkov <dglazkov@chromium.org>

Mark test as flaky per dashboard.
https://bugs.webkit.org/show_bug.cgi?id=53824

  • platform/chromium/test_expectations.txt: Marked.
11:10 Changeset [77832] by jam@chromium.org
  • 7 edits
    2 copies in branches/chromium/648

Merge 77706 - 2011-02-04 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

PluginDocuments don't create widgets for plugins on back/forward
https://bugs.webkit.org/show_bug.cgi?id=53474

Test that plugin loads when in a plugin document on back-forward.

  • plugins/plugin-document-back-forward-expected.txt: Added.
  • plugins/plugin-document-back-forward.html: Added.

2011-02-04 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

PluginDocuments don't create widgets for plugins on back/forward
https://bugs.webkit.org/show_bug.cgi?id=53474

Long ago, PluginDocument always caused the HTMLEmbedElement to create
its widget synchronously during a post-layout task. Recently, however,
some changes to the HistroyController caused layout on back/forward to
become slightly more complicated (and added an extra level of recursion
to layout). This extra level of recursion triggered the "I've recursed
too many times" condition in the post-layout task queue, causing the
FrameView to run the remainder of the tasks asynchronously.
Unfortunately, that broke PluginDocument because it needs its the
HTMLEmbedElement's updateWidget task to run synchronously.

This patch adds a mechanism for "kicking off" the pending post-layout
tasks synchronously (instead of waiting for the timer to fire).
PluginDocument then uses that facility to ensure that the
HTMLEmbedElement's updateWidget task happens.

Test: plugins/plugin-document-back-forward.html

  • html/PluginDocument.cpp: (WebCore::PluginDocumentParser::appendBytes):
  • page/FrameView.cpp: (WebCore::FrameView::flushAnyPendingPostLayoutTasks):
  • page/FrameView.h:

2011-02-04 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

PluginDocuments don't create widgets for plugins on back/forward
https://bugs.webkit.org/show_bug.cgi?id=53474

Teach the test plugin how to call alert on load.

  • DumpRenderTree/TestNetscapePlugIn/main.cpp: (NPP_New):

TBR=abarth@webkit.org
Review URL: http://codereview.chromium.org/6286151

10:47 BuildingQtOnSymbian edited by siddharth.mathur@nokia.com
add -b syntax for compiling both Source and Tools project files (diff)
10:46 Changeset [77831] by darin@apple.com
  • 9 edits in trunk/Source/WebCore

Turn UTF-8 decoder off for now so we can look into failing tests
without leaving the tree red.

  • platform/text/TextCodecICU.cpp:

(WebCore::TextCodecICU::registerBaseEncodingNames): Reverting
earlier change so this can handle UTF-8.
(WebCore::TextCodecICU::registerBaseCodecs): Ditto.
(WebCore::TextCodecICU::registerExtendedEncodingNames): Ditto.
(WebCore::TextCodecICU::registerExtendedCodecs): Ditto.

  • platform/text/TextCodecICU.h: Ditto.
  • platform/text/TextEncodingRegistry.cpp:

(WebCore::buildBaseTextCodecMaps): Ditto.
(WebCore::extendTextCodecMaps): Ditto.

  • platform/text/brew/TextCodecBrew.cpp:

(WebCore::TextCodecBrew::registerBaseEncodingNames): Ditto.
(WebCore::TextCodecBrew::registerBaseCodecs): Ditto.
(WebCore::TextCodecBrew::registerExtendedEncodingNames): Ditto.
(WebCore::TextCodecBrew::registerExtendedCodecs): Ditto.

  • platform/text/brew/TextCodecBrew.h: Ditto.
  • platform/text/gtk/TextCodecGtk.cpp:

(WebCore::TextCodecGtk::registerBaseEncodingNames): Ditto.
(WebCore::TextCodecGtk::registerBaseCodecs): Ditto.

  • platform/text/wince/TextCodecWinCE.cpp:

(WebCore::TextCodecWinCE::registerBaseEncodingNames): Ditto.
(WebCore::TextCodecWinCE::registerBaseCodecs): Ditto.
(WebCore::TextCodecWinCE::registerExtendedEncodingNames): Ditto.
(WebCore::TextCodecWinCE::registerExtendedCodecs): Ditto.

  • platform/text/wince/TextCodecWinCE.h: Ditto.
10:45 Changeset [77830] by aroben@apple.com
  • 2 edits in trunk/Source/WebKit2

Use the right calling convention when calling WebKitMain

Fixes <http://webkit.org/b/53923> REGRESSION (r77678): Crash on quit in web process in
wWinMain

Reviewed by Steve Falkenburg.

  • win/MainWin.cpp:

(wWinMain): Use cdecl instead of WINAPI (stdcall) when calling WebKitMain, since that is
how that function is declared.

10:39 Changeset [77829] by andersca@apple.com
  • 6 edits in trunk/Source/WebKit2

2011-02-07 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

The drawing area should be in charge of drawing the page overlay
https://bugs.webkit.org/show_bug.cgi?id=53927

  • WebProcess/WebPage/DrawingArea.h: (WebKit::DrawingArea::didInstallPageOverlay): (WebKit::DrawingArea::didUninstallPageOverlay): (WebKit::DrawingArea::setOverlayNeedsDisplay): Add empty stubs.
  • WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::didInstallPageOverlay): Add empty function. This will eventually ask the layer tree host to create a GraphicsLayer for the page overlay.

(WebKit::DrawingAreaImpl::didUninstallPageOverlay):
Tell the page that it needs to be repainted.

(WebKit::DrawingAreaImpl::setOverlayNeedsDisplay):
Just call setNeedsDisplay for now.

(WebKit::DrawingAreaImpl::display):
Paint the page overlay too.

  • WebProcess/WebPage/DrawingAreaImpl.h:
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::drawRect): Only call drawPageOverlay if we have an old drawing area.

(WebKit::WebPage::drawPageOverlay):
Draw the page overlay. Code moved here from WebPage::drawRect.

(WebKit::WebPage::installPageOverlay):
Call DrawingArea::installPageOverlay.

(WebKit::WebPage::uninstallPageOverlay):
Call DrawingArea::uninstallPageOverlay.

  • WebProcess/WebPage/WebPage.h: (WebKit::WebPage::hasPageOverlay): Add getter.
10:31 Changeset [77828] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Don't exclude overlay scrollers from the page overlay bounds
https://bugs.webkit.org/show_bug.cgi?id=53924

Reviewed by Maciej Stachowiak.

Export ScrollbarTheme::nativeTheme.

  • WebCore.exp.in:
10:31 Changeset [77827] by antonm@chromium.org
  • 3 edits in branches/chromium/648/Source/WebCore

Merge 77597 - 2011-02-03 Anton Muhin <antonm@chromium.org>

Reviewed by Adam Barth.

[v8] Bail out if to string conversion returned empty handle
https://bugs.webkit.org/show_bug.cgi?id=53687

This a temporary measure: actually one probably should never get empty handle
if there was no exception. The root cause is under investigation.
The bailout though allows Chromium not to crash---attempt to convert an empty
v8 hande into WebCore string crashes with invalid memory access.

See http://code.google.com/p/chromium/issues/detail?id=71544

There is no known reduction expressible as a layout test so far. The crash found with automated testing tools.

  • bindings/v8/V8Binding.cpp: (WebCore::v8NonStringValueToWebCoreString): Bail out on empty handle
  • bindings/v8/V8Binding.h: (WebCore::V8ParameterBase::prepareBase): Ditto

TBR=antonm@chromium.org
Review URL: http://codereview.chromium.org/6368135

10:26 Changeset [77826] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

2011-02-07 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Add WebPage::bounds and use it
https://bugs.webkit.org/show_bug.cgi?id=53926

  • WebProcess/WebPage/ChunkedUpdateDrawingArea.cpp: (WebKit::ChunkedUpdateDrawingArea::resumePainting):
  • WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::resumePainting): (WebKit::DrawingAreaImpl::exitAcceleratedCompositingMode):
  • WebProcess/WebPage/WebPage.h: (WebKit::WebPage::bounds):
10:21 Changeset [77825] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-02-07 Anders Carlsson <andersca@apple.com>

Reviewed by Maciej Stachowiak.

Don't exclude overlay scrollers from the page overlay bounds
https://bugs.webkit.org/show_bug.cgi?id=53924

Don't subtract the scrollbars from the page overlay bounds if
overlay scrollers are enabled.

  • WebProcess/WebPage/PageOverlay.cpp: (WebKit::PageOverlay::bounds):
10:18 Changeset [77824] by mrobinson@webkit.org
  • 2 edits
    1 add in trunk/LayoutTests

2011-02-07 Martin Robinson <mrobinson@igalia.com>

Unskip a passing accessibility test and organize the rest of the tests missing
results as failing.

  • platform/gtk/Skipped: Unskip passing test and organize remaining failures.
  • platform/gtk/accessibility/aria-describedby-on-input-expected.txt: Added.
10:02 Changeset [77823] by darin@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Add built-in decoder for UTF-8 for improved performance
https://bugs.webkit.org/show_bug.cgi?id=53898

Reviewed by Antti Koivisto.

  • wtf/unicode/UnicodeMacrosFromICU.h: Added U8_MAX_LENGTH and

U8_APPEND_UNSAFE. Also fixed header.

09:57 Changeset [77822] by mjs@apple.com
  • 2 edits in trunk/Tools

Not reviewed.

Fix WebKitTestRunner build on the SL bot.

  • WebKitTestRunner/Configurations/Base.xcconfig: Look for the JSC copy

of ICU headers.

09:29 Changeset [77821] by zmo@google.com
  • 4 edits
    2 adds in trunk

2011-02-03 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Crash in glDrawArrays with NaCl crystal model
https://bugs.webkit.org/show_bug.cgi?id=52831

  • html/canvas/WebGLRenderingContext.cpp: Allocate large enough buffer for atttrib0 if it's enabled and not used. (WebCore::WebGLRenderingContext::initVertexAttrib0): (WebCore::WebGLRenderingContext::simulateVertexAttrib0):
  • html/canvas/WebGLRenderingContext.h:

2011-02-03 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Crash in glDrawArrays with NaCl crystal model
https://bugs.webkit.org/show_bug.cgi?id=52831

  • fast/canvas/webgl/gl-vertex-attrib-zero-issues-expected.txt: Added.
  • fast/canvas/webgl/gl-vertex-attrib-zero-issues.html: Added.
09:24 Changeset [77820] by cfleizach@apple.com
  • 6 edits
    2 adds in trunk

Source/WebCore: WAI-ARIA @aria-sort not exposed on rowheader and columnheader roles.
https://bugs.webkit.org/show_bug.cgi?id=53842

Reviewed by Darin Adler.

Test: platform/mac/accessibility/aria-sort.html

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::sortDirection):

  • accessibility/AccessibilityObject.h:
  • accessibility/mac/AccessibilityObjectWrapper.mm:

(-[AccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
(-[AccessibilityObjectWrapper accessibilityAttributeValue:]):

  • html/HTMLAttributeNames.in:

LayoutTests: WAI-ARIA @aria-sort not exposed on rowheader and columnheader roles
https://bugs.webkit.org/show_bug.cgi?id=53842

Reviewed by Darin Adler.

  • platform/mac/accessibility/aria-sort-expected.txt: Added.
  • platform/mac/accessibility/aria-sort.html: Added.
08:35 Changeset [77819] by darin@apple.com
  • 17 edits
    2 adds in trunk/Source/WebCore

2011-02-06 Darin Adler <darin@apple.com>

Reviewed by Antti Koivisto.

Add built-in decoder for UTF-8 for improved performance
https://bugs.webkit.org/show_bug.cgi?id=53898

Correct behavior is covered by existing tests.

  • Android.mk: Added TextCodecUTF8.
  • CMakeLists.txt: Ditto.
  • GNUmakefile.am: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • platform/text/TextCodecICU.cpp: Removed registration of UTF-8 since that's now handled by the built-in UTF-8 codec. (WebCore::TextCodecICU::registerEncodingNames): Renamed to remove the word "extended" since all codecs from ICU are now extended. (WebCore::TextCodecICU::registerCodecs): Ditto.
  • platform/text/TextCodecICU.h: Ditto.
  • platform/text/TextCodecUTF16.cpp: (WebCore::TextCodecUTF16::decode): Added a FIXME about missing error handling.
  • platform/text/TextCodecUTF8.cpp: Added.
  • platform/text/TextCodecUTF8.h: Added.
  • platform/text/TextEncodingRegistry.cpp: (WebCore::buildBaseTextCodecMaps): Added TextCodecUTF8, and removed TextCodecICU, TextCodecBrew, and TextCodecWinCE. (WebCore::extendTextCodecMaps): Updated names for TextCodecICU and TextCodecWinCE.
  • platform/text/brew/TextCodecBrew.cpp: (WebCore::TextCodecBrew::registerEncodingNames): Renamed to remove the word "extended" since all codecs from Brew are now extended. (WebCore::TextCodecBrew::registerCodecs): Ditto.
  • platform/text/brew/TextCodecBrew.h: Ditto.
  • platform/text/gtk/TextCodecGtk.cpp: (WebCore::TextCodecGtk::registerBaseEncodingNames): Removed registration of UTF-8. It's questionable whether the other codecs here are really basic. If we think they qualify, then we should register them on other platforms, not just GTK. (WebCore::TextCodecGtk::registerBaseCodecs): Ditto.
  • platform/text/wince/TextCodecWinCE.cpp: (WebCore::getCodePage): Removed special case for UTF-8 since we no longer use this codec for UTF-8. (WebCore::TextCodecWinCE::registerEncodingNames): Renamed to remove the word "extended" since all codecs from WinCE are now extended. (WebCore::TextCodecWinCE::registerCodecs): Ditto.
  • platform/text/wince/TextCodecWinCE.h: Ditto.
08:35 Changeset [77818] by mrobinson@webkit.org
  • 4 edits in trunk

2011-02-07 Martin Robinson <mrobinson@igalia.com>

Reviewed by Daniel Bates.

[GTK] fast/history/history-subframe-with-name.html fails with GTK DRT
https://bugs.webkit.org/show_bug.cgi?id=44784

  • platform/gtk/Skipped: Unskip tests which are now passing.

2011-02-07 Martin Robinson <mrobinson@igalia.com>

Reviewed by Daniel Bates.

[GTK] fast/history/history-subframe-with-name.html fails with GTK DRT
https://bugs.webkit.org/show_bug.cgi?id=44784

Call FrameLoader::loadURLIntoChildFrame on the parent frame's loader, not the child's.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::createFrame): Fix the call to FrameLoader::loadURLIntoChildFrame.
08:23 Changeset [77817] by mario@webkit.org
  • 4 edits in trunk/Source

2011-02-07 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Xan Lopez.

[Gtk] atk_text_get_caret_offset fails for list items
https://bugs.webkit.org/show_bug.cgi?id=53436

Consider list item markers when calculating the offset.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_text_get_caret_offset): Adjust the offset with the item marker's length for list items. (webkit_accessible_text_set_caret_offset): Replace usage of g_utf8_strlen() by calling to markerText.length().

2011-02-07 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Xan Lopez.

[Gtk] atk_text_get_caret_offset fails for list items
https://bugs.webkit.org/show_bug.cgi?id=53436

Update unit test to check the fix for this bug.

  • tests/testatk.c: (testWebkitAtkCaretOffsets): Check that the caret offset returned match the value previously set.
08:03 Changeset [77816] by aroben@apple.com
  • 2 edits in trunk/Source/WebKit2

Windows build fix after r77794

  • win/WebKit2.def: Export WebCore symbols used by WebKitTestRunner.
08:02 Changeset [77815] by aroben@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Delete precompiled headers whenever any .vsprops file changes

Precompiled headers need to be rebuilt if, e.g., an ENABLE_* macro is changed in one of our
.vsprops files. Unfortunately, Visual Studio isn't smart enough to figure this out, so we
give it some assistance by deleting the precompiled headers whenever any .vsprops file
changes.

I also made some drive-by fixes while I was in the area.

Fixes <http://webkit.org/b/53826> react-to-vsprops-changes.py doesn't force precompiled
headers to be rebuilt, but should

Reviewed by David Kilzer.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make: Stop ignoring the

return code from react-to-vsprops-changes.py so we will notice when errors are introduced.
But skip the script entirely in production builds, where it is both unnecessary and can't
function correctly (due to not having the entire source tree available to it).

(main): Removed an extra '*' in the glob for finding manifest files. The extra '*' was
leftover from before we rearranged WebKitBuild in r75138. Moved code to delete an old file
to the new delete_if_older_than function. Added code to delete any precompiled headers older
than the newest .vsprops file.
(delete_if_older_than): Added. Code came from main.

07:57 Changeset [77814] by yi.4.shen@nokia.com
  • 4 edits in trunk

2011-02-07 Yi Shen <yi.4.shen@nokia.com>

Reviewed by Tor Arne Vestbø.

[Qt] Fix LayoutTests/media/restore-from-page-cache.html
https://bugs.webkit.org/show_bug.cgi?id=53621

Unskip media/restore-from-page-cache.html for Qt.

  • platform/qt/Skipped:

2011-02-07 Yi Shen <yi.4.shen@nokia.com>

Reviewed by Tor Arne Vestbø.

[Qt] Fix LayoutTests/media/restore-from-page-cache.html
https://bugs.webkit.org/show_bug.cgi?id=53621

Changed the networkState to MediaPlayer::Loaded when
MediaPlayerPrivateQt has enough data.

Test: media/restore-from-page-cache.html

  • platform/graphics/qt/MediaPlayerPrivateQt.cpp: (WebCore::MediaPlayerPrivateQt::updateStates):
07:56 Changeset [77813] by paroga@webkit.org
  • 2 edits in trunk/Source/WebKit/haiku

2011-02-07 Patrick Gansterer <paroga@webkit.org>

Reviewed by Andreas Kling.

[Haiku] FrameLoaderClient calls loadURLInChildFrame on the child's frame loader
https://bugs.webkit.org/show_bug.cgi?id=53893

  • WebCoreSupport/FrameLoaderClientHaiku.cpp: (WebCore::FrameLoaderClientHaiku::createFrame): Use m_frame instead of childFrame.
07:31 Changeset [77812] by loislo@chromium.org
  • 2 edits in trunk/LayoutTests

2011-02-07 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed.

Chromium: three tests temporary disabled for rebaseline after r77781

  • platform/chromium/test_expectations.txt:
07:18 Changeset [77811] by paroga@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

2011-02-07 Patrick Gansterer <paroga@webkit.org>

Reviewed by Andreas Kling.

[EFL] FrameLoaderClient calls loadURLInChildFrame on the child's frame loader
https://bugs.webkit.org/show_bug.cgi?id=53892

  • ewk/ewk_frame.cpp: (ewk_frame_child_add): Use the loader of the core frame instead.
07:15 Changeset [77810] by podivilov@chromium.org
  • 12 edits
    1 add in trunk

2011-02-04 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: implement beautification of scripts inlined in html documents.
https://bugs.webkit.org/show_bug.cgi?id=52706

  • http/tests/inspector/debugger-test2.js: (initialize_DebuggerTest.InspectorTest.setBreakpointInVisibleView):
  • inspector/debugger-breakpoints-not-activated-on-reload.html:
  • inspector/debugger-pause-on-breakpoint.html:

2011-01-31 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: implement beautification of scripts inlined in html documents.
https://bugs.webkit.org/show_bug.cgi?id=52706

To beautify scripts inlined in html, we need to cut individual scripts, beautify them using UglifyJS library, and
finally paste them back to html.

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/ScriptFormatter.js: (WebInspector.ScriptFormatter): Implement formatting of scripts inlined in html. (WebInspector.ScriptFormatter.prototype.formatContent.didFormatChunks): (WebInspector.ScriptFormatter.prototype.formatContent): (WebInspector.ScriptFormatter.prototype._splitContentIntoChunks): (WebInspector.ScriptFormatter.prototype._formatChunks.didFormat): (WebInspector.ScriptFormatter.prototype._formatChunks): (WebInspector.ScriptFormatter.prototype._buildContentFromChunks): (WebInspector.ScriptFormatter.prototype._formatScript.messageHandler): (WebInspector.ScriptFormatter.prototype._formatScript):
  • inspector/front-end/ScriptFormatterWorker.js: (onmessage): (buildMapping):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrameContent): Use SourceFrameContent and FormattedSourceFrameContent to perform operations with line numbers.
  • inspector/front-end/SourceFrameContent.js: Added. (WebInspector.SourceFrameContent): Helper class, holds resource text and scripts layout (WebInspector.SourceFrameContent.prototype.get scriptRanges): (WebInspector.SourceFrameContent.prototype.locationToPosition): (WebInspector.SourceFrameContent.prototype.positionToLocation): (WebInspector.SourceFrameContent.prototype.scriptLocationForLineNumber): (WebInspector.SourceFrameContent.prototype.scriptLocationForRange): (WebInspector.SourceFrameContent.prototype.lineNumberToRange): (WebInspector.SourceFrameContent.prototype._intersectingScriptRange): (WebInspector): (WebInspector.FormattedSourceFrameContent): Helper class, holds original and formatted versions of resource and mapping between them. (WebInspector.FormattedSourceFrameContent.prototype.get text): (WebInspector.FormattedSourceFrameContent.prototype.originalLocationToFormattedLocation): (WebInspector.FormattedSourceFrameContent.prototype.scriptLocationForFormattedLineNumber): (WebInspector.FormattedSourceFrameContent.prototype._convertPosition):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
06:55 Changeset [77809] by paroga@webkit.org
  • 2 edits in trunk/Source/WebKit/wx

2011-02-07 Patrick Gansterer <paroga@webkit.org>

Reviewed by Andreas Kling.

[wx] FrameLoaderClient calls loadURLInChildFrame on the child's frame loader
https://bugs.webkit.org/show_bug.cgi?id=53895

  • WebKitSupport/FrameLoaderClientWx.cpp: (WebCore::FrameLoaderClientWx::createFrame): Use m_frame instead of childFrame.
06:49 Changeset [77808] by loislo@chromium.org
  • 1 edit
    41 adds in trunk/LayoutTests

2011-02-07 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed.

Chromium: add explicit "Passed" expectations for the tests which have "failed" expectations in platfrom/mac
The problem was introduced at r77719.
I have to do that because platform/mac is in the list of baseline folders.
See 'Tools/Scripts/webkitpy/layout_tests/port/chromium_linux.py'.

  • platform/chromium/canvas/philip/tests/2d.drawImage.broken-expected.txt: Added.
  • platform/chromium/canvas/philip/tests/2d.drawImage.image.incomplete.omitted-expected.txt: Added.
  • platform/chromium/canvas/philip/tests/2d.fillStyle.parse.invalid.rgba-6-expected.txt: Added.
  • platform/chromium/canvas/philip/tests/2d.fillStyle.parse.rgb-eof-expected.txt: Added.
  • platform/chromium/canvas/philip/tests/2d.fillStyle.parse.rgba-eof-expected.txt: Added.
  • platform/chromium/canvas/philip/tests/2d.fillStyle.parse.system-expected.txt: Added.
  • platform/chromium/canvas/philip/tests/2d.gradient.radial.cone.front-expected.txt: Added.
  • platform/chromium/canvas/philip/tests/2d.gradient.radial.inside2-expected.txt: Added.
  • platform/chromium/canvas/philip/tests/2d.gradient.radial.inside3-expected.txt: Added.
  • platform/chromium/canvas/philip/tests/2d.gradient.radial.outside1-expected.txt: Added.
  • platform/chromium/canvas/philip/tests/2d.imageData.put.wrongtype-expected.txt: Added.
  • platform/chromium/canvas/philip/tests/2d.line.cap.closed-expected.txt: Added.
  • platform/chromium/canvas/philip/tests/2d.line.join.parallel-expected.txt: Added.
  • platform/chromium/canvas/philip/tests/2d.line.miter.lineedge-expected.txt: Added.
  • platform/chromium/canvas/philip/tests/2d.path.rect.winding-expected.txt: Added.
  • platform/chromium/canvas/philip/tests/2d.pattern.image.broken-expected.txt: Added.
  • platform/chromium/canvas/philip/tests/2d.pattern.image.incomplete.empty-expected.txt: Added.
  • platform/chromium/canvas/philip/tests/2d.pattern.image.incomplete.omitted-expected.txt: Added.
  • platform/chromium/canvas/philip/tests/2d.shadow.enable.x-expected.txt: Added.
  • platform/chromium/canvas/philip/tests/2d.shadow.enable.y-expected.txt: Added.
  • platform/chromium/canvas/philip/tests/2d.strokeRect.zero.4-expected.txt: Added.
  • platform/chromium/canvas/philip/tests/2d.text.draw.baseline.bottom-expected.txt: Added.
  • platform/chromium/canvas/philip/tests/2d.text.draw.baseline.hanging-expected.txt: Added.
  • platform/chromium/canvas/philip/tests/2d.text.draw.baseline.middle-expected.txt: Added.
  • platform/chromium/canvas/philip/tests/2d.text.draw.baseline.top-expected.txt: Added.
  • platform/chromium/canvas/philip/tests/2d.text.draw.fill.maxWidth.fontface-expected.txt: Added.
  • platform/chromium/canvas/philip/tests/2d.text.draw.space.collapse.end-expected.txt: Added.
  • platform/chromium/canvas/philip/tests/2d.text.draw.space.collapse.nonspace-expected.txt: Added.
  • platform/chromium/canvas/philip/tests/2d.text.draw.space.collapse.other-expected.txt: Added.
  • platform/chromium/canvas/philip/tests/2d.text.draw.space.collapse.space-expected.txt: Added.
  • platform/chromium/canvas/philip/tests/2d.text.draw.space.collapse.start-expected.txt: Added.
  • platform/chromium/canvas/philip/tests/2d.text.font.parse.basic-expected.txt: Added.
  • platform/chromium/canvas/philip/tests/2d.text.font.parse.complex-expected.txt: Added.
  • platform/chromium/canvas/philip/tests/2d.text.font.parse.invalid-expected.txt: Added.
  • platform/chromium/canvas/philip/tests/2d.text.font.parse.size.percentage-expected.txt: Added.
  • platform/chromium/canvas/philip/tests/2d.text.font.parse.size.percentage.default-expected.txt: Added.
  • platform/chromium/canvas/philip/tests/2d.text.font.parse.system-expected.txt: Added.
  • platform/chromium/canvas/philip/tests/2d.text.measure.width.space-expected.txt: Added.
05:21 Changeset [77807] by zimmermann@webkit.org
  • 208 edits in trunk/LayoutTests

2011-02-07 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed.

small text which is scaled to be large renders pixelated
https://bugs.webkit.org/show_bug.cgi?id=12448

Update Snow Leopard SVG pixel test baseline after r77485.

  • platform/mac/svg/dom/SVGRectElement/rect-modify-rx-expected.png:
  • platform/mac/svg/dynamic-updates/SVGAElement-dom-href-attr-expected.png:

...

05:10 Changeset [77806] by zimmermann@webkit.org
  • 131 edits in trunk/LayoutTests

2011-02-07 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed.

small text which is scaled to be large renders pixelated
https://bugs.webkit.org/show_bug.cgi?id=12448

Update Snow Leopard SVG pixel test baseline after r77485.

  • platform/mac/svg/custom/js-update-polygon-removal-expected.png:
  • platform/mac/svg/custom/js-update-style-expected.png:

...

05:05 Changeset [77805] by zimmermann@webkit.org
  • 73 edits in trunk/LayoutTests

2011-02-07 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed.

small text which is scaled to be large renders pixelated
https://bugs.webkit.org/show_bug.cgi?id=12448

Update Snow Leopard SVG pixel test baseline after r77485.

  • platform/mac/svg/custom/class-baseValue-expected.png:
  • platform/mac/svg/custom/class-selector-expected.png:

...

04:59 Changeset [77804] by zimmermann@webkit.org
  • 91 edits in trunk/LayoutTests

2011-02-07 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed.

small text which is scaled to be large renders pixelated
https://bugs.webkit.org/show_bug.cgi?id=12448

Update Snow Leopard SVG pixel test baseline after r77485.

  • platform/mac/svg/batik/paints/gradientLimit-expected.png:
  • platform/mac/svg/batik/paints/patternRegionA-expected.png:

...

03:56 Changeset [77803] by alex@webkit.org
  • 2 edits
    3 adds in trunk/LayoutTests

2011-02-07 Alejandro G. Castro <alex@igalia.com>

Unreviewed, added new results for the slider-thumb-drag-release
test and removed use-infinite-recursion.svg from skipped, required
after r77778.

  • platform/gtk/Skipped:
  • platform/gtk/fast/repaint/slider-thumb-drag-release-expected.checksum: Added.
  • platform/gtk/fast/repaint/slider-thumb-drag-release-expected.png: Added.
  • platform/gtk/fast/repaint/slider-thumb-drag-release-expected.txt: Added.
03:46 Changeset [77802] by apavlov@chromium.org
  • 1 edit
    3 moves
    1 add in trunk/Websites/webkit.org

2011-02-07 Alexander Pavlov <apavlov@chromium.org>

Unreviewed. Add Web Inspector warning 10x10 PNG, move files from r77801 into the inspector/ directory.

  • blog-files/inspector/css_as_authored.png: Renamed from Websites/webkit.org/blog-files/inspector-css-as-authored.png.
  • blog-files/inspector/css_autocomplete.png: Renamed from Websites/webkit.org/blog-files/inspector-css-autocomplete.png.
  • blog-files/inspector/css_unknown_properties.png: Renamed from Websites/webkit.org/blog-files/inspector-unknown-css-properties.png.
  • blog-files/inspector/warning_10x10.png: Added.
03:27 Changeset [77801] by apavlov@chromium.org
  • 1 edit
    3 adds in trunk/Websites/webkit.org

2011-02-07 Alexander Pavlov <apavlov@chromium.org>

Unreviewed. Add Web Inspector style editing screenshots.

  • blog-files/inspector-css-as-authored.png: Added.
  • blog-files/inspector-css-autocomplete.png: Added.
  • blog-files/inspector-unknown-css-properties.png: Added.
03:26 Changeset [77800] by pfeldman@chromium.org
  • 7 edits in trunk/Source/WebCore

2011-02-07 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: "Reveal in elements panel" does not always work.
https://bugs.webkit.org/show_bug.cgi?id=53775

  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView):
  • inspector/front-end/ContextMenu.js: (WebInspector.ContextMenu.prototype.show):
  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.switchToAndFocus):
  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeOutline.prototype._contextMenuEventFired.focusElement): (WebInspector.ElementsTreeOutline.prototype._contextMenuEventFired):
  • inspector/front-end/ObjectPropertiesSection.js: (WebInspector.ObjectPropertyTreeElement.prototype.update): (WebInspector.ObjectPropertyTreeElement.prototype._contextMenuEventFired):
  • inspector/front-end/inspector.js: (WebInspector.cancelSearch):
03:24 Changeset [77799] by abarth@webkit.org
  • 5 edits in trunk

2011-02-07 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Relative .. in URL paths shouldn't skip adjacent / characters
https://bugs.webkit.org/show_bug.cgi?id=53907

Add some more test cases.

  • fast/url/path-expected.txt:
  • fast/url/script-tests/path.js:

2011-02-07 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Relative .. in URL paths shouldn't skip adjacent / characters
https://bugs.webkit.org/show_bug.cgi?id=53907

Our new behavior matches Firefox, Chrome, and IE.

  • platform/KURL.cpp: (WebCore::copyPathRemovingDots):
03:16 Changeset [77798] by ossy@webkit.org
  • 2 edits in trunk/Tools

Unreviewed.

[Qt][WK2] Buildfix after r77794.

WebKitTestRunner does not block remote resources or complain about them
https://bugs.webkit.org/show_bug.cgi?id=42139
<rdar://problem/8183942>

  • WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: Add missing includepaths.
03:01 Changeset [77797] by mjs@apple.com
  • 2 edits in trunk/Tools

Not reviewed.

More bot appeasement.

  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
02:47 Changeset [77796] by mjs@apple.com
  • 2 edits in trunk/Tools

Not reviewed.

Remove accidental references to directories on my laptop.

  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
01:59 Changeset [77795] by pfeldman@chromium.org
  • 2 edits in branches/chromium/648/Source/WebCore/inspector/front-end

Merge 76517 - 2011-01-24 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [REGRESSION] AppCache view on resources panel is broken.
https://bugs.webkit.org/show_bug.cgi?id=53002

  • inspector/front-end/ApplicationCacheItemsView.js: (WebInspector.ApplicationCacheItemsView.prototype._update):
  • inspector/front-end/DOMAgent.js: (WebInspector.ApplicationCacheDispatcher.getApplicationCachesAsync):

TBR=podivilov@chromium.org
Review URL: http://codereview.chromium.org/6368125

01:47 Changeset [77794] by mjs@apple.com
  • 8 edits in trunk

2011-02-07 Maciej Stachowiak <mjs@apple.com>

Reviewed by Antti Koivisto.

WebKitTestRunner does not block remote resources or complain about them
https://bugs.webkit.org/show_bug.cgi?id=42139
<rdar://problem/8183942>

  • Configurations/WebCore.xcconfig: Allow WebKitTestRunner to link WebCore.
  • WebCore.exp.in: Export a handful of KURL symbols.

2011-02-07 Maciej Stachowiak <mjs@apple.com>

Reviewed by Antti Koivisto.

WebKitTestRunner does not block remote resources or complain about them
https://bugs.webkit.org/show_bug.cgi?id=42139
<rdar://problem/8183942>

  • platform/mac-wk2/Skipped: Unskip formerly skipped tests.

2011-02-07 Maciej Stachowiak <mjs@apple.com>

Reviewed by Antti Koivisto.

WebKitTestRunner does not block remote resources or complain about them
https://bugs.webkit.org/show_bug.cgi?id=42139
<rdar://problem/8183942>

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::willSendRequestForFrame): Implement the required checks (using KURL, to avoid need to invent a whole URL API).
  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Link WebCore directly to get at KURL symbols.
01:31 Changeset [77793] by mjs@apple.com
  • 4 edits in trunk/Source/WebKit2

2011-02-07 Maciej Stachowiak <mjs@apple.com>

Reviewed by Antti Koivisto.

Add WKURLRequestCopyURL API (needed for tests and also generally useful)
https://bugs.webkit.org/show_bug.cgi?id=53909

  • Shared/API/c/WKURLRequest.cpp: (WKURLRequestCopyURL):
  • Shared/API/c/WKURLRequest.h:
  • Shared/WebURLRequest.h: (WebKit::WebURLRequest::url):
00:54 Changeset [77792] by antti@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Not reviewed.

ASSERTS_DISABLED -> ASSERT_DISABLED

  • wtf/BloomFilter.h:

02/06/11:

23:20 Changeset [77791] by mjs@apple.com
  • 2 edits in trunk/Tools

2011-02-06 Maciej Stachowiak <mjs@apple.com>

Reviewed by Daniel Bates.

Add WebKit2 bot to list of expected builders in Python regression test results.
https://bugs.webkit.org/show_bug.cgi?id=53905

  • Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
22:49 Changeset [77790] by mjs@apple.com
  • 2 edits in trunk/Tools

2011-02-06 Maciej Stachowiak <mjs@apple.com>

Reviewed by Ryosuke Niwa.

Update test expectations for new core builder
https://bugs.webkit.org/show_bug.cgi?id=53904

  • Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
22:20 Changeset [77789] by mjs@apple.com
  • 2 edits in trunk/Tools

2011-02-06 Maciej Stachowiak <mjs@apple.com>

Reviewed by David Levin.

Add WebKit2 test bot to core builders
https://bugs.webkit.org/show_bug.cgi?id=53901

  • Scripts/webkitpy/common/net/buildbot/buildbot.py:
21:47 Changeset [77788] by rniwa@webkit.org
  • 2 edits in trunk/Tools

2011-02-06 Ryosuke Niwa <rniwa@webkit.org>

Another unreviewed Chromium build fix.

  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::pathToLocalResource):
21:29 Changeset [77787] by rniwa@webkit.org
  • 4 edits in trunk

2011-02-06 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed Chromium build fix.

  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::pathToLocalResource):

2011-02-06 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed; speculative Qt build fix.

  • WebKit2.pro:
21:19 Changeset [77786] by rniwa@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-02-06 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed; speculative Qt build fix.

21:01 Changeset [77785] by rniwa@webkit.org
  • 44 edits
    3 deletes in trunk

2011-02-06 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

OwnArraryPtr.h uses deleteOwnedPtr but doesn’t include OwnPtrCommon.h
https://bugs.webkit.org/show_bug.cgi?id=52867

  • DumpRenderTree/chromium/ImageDiff.cpp: (Image::craeteFromStdin): Call adoptArrayPtr.

2011-02-06 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

OwnArraryPtr.h uses deleteOwnedPtr but doesn’t include OwnPtrCommon.h
https://bugs.webkit.org/show_bug.cgi?id=52867

Removed LOOSE_OWN_ARRAY_PTR and OwnArrayPtr<T>::set. Replaced all calls to OwnArrayPtr::set
and loose instantiation of OwnArrayPtr by calls to operator= and adoptArrayPtr. Also removed
OwnArrayPtrCommon.h since PassOwnArrayPtr.h needs to include OwnArrayPtr.h and there is
no point in putting deleteOwnedArrayPtr into a separate header.


Note: if this patch breaks build, the code is either instiantiating OwnArrayPtr
without calling adoptArrayPtr or calling set on ArrayOwnPtr instead of operator=.

No tests are added since this is a refactoring.

  • API/JSStringRefCF.cpp: (JSStringCreateWithCFString): Calls adoptArrayPtr.
  • GNUmakefile.am: Removed OwnArrayPtrCommon.h
  • JavaScriptCore.vcproj/WTF/WTF.vcproj: Ditto.
  • JavaScriptCore.xcodeproj/project.pbxproj: Ditto.
  • runtime/Arguments.cpp: (JSC::Arguments::deleteProperty): Calls adoptArrayPtr.
  • runtime/Arguments.h: (JSC::Arguments::copyRegisters): Ditto.
  • runtime/JSPropertyNameIterator.cpp: (JSC::JSPropertyNameIterator::JSPropertyNameIterator): Ditto.
  • runtime/JSVariableObject.h: (JSC::JSVariableObject::setRegisters): Calls operator= instead of set.
  • runtime/StructureChain.cpp: (JSC::StructureChain::StructureChain): Ditto.
  • wtf/CMakeLists.txt:
  • wtf/DateMath.h: (JSC::GregorianDateTime::GregorianDateTime): No longer instnatiates OwnArrayPtr with a null pointer.
  • wtf/OwnArrayPtr.h:
  • wtf/OwnArrayPtrCommon.h: Removed.
  • wtf/PassOwnArrayPtr.h: No longer includes OwnArrayCommon.h (WTF::deleteOwnedArrayPtr): Moved from OwnArrayPtrCommon.h

2011-02-06 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

OwnArraryPtr.h uses deleteOwnedPtr but doesn’t include OwnPtrCommon.h
https://bugs.webkit.org/show_bug.cgi?id=52867

  • ForwardingHeaders/wtf/OwnArrayPtrCommon.h: Removed.

2011-02-06 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

OwnArraryPtr.h uses deleteOwnedPtr but doesn’t include OwnPtrCommon.h
https://bugs.webkit.org/show_bug.cgi?id=52867

  • WebHistory.cpp: (WebHistory::orderedLastVisitedDays): Calls adoptArrayPtr.
  • WebPreferences.cpp: (WebPreferences::copyWebKitPreferencesToCFPreferences): Ditto.

2011-02-06 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

OwnArraryPtr.h uses deleteOwnedPtr but doesn’t include OwnPtrCommon.h
https://bugs.webkit.org/show_bug.cgi?id=52867

  • ForwardingHeaders/wtf/OwnArrayPtrCommon.h: Removed.
  • bindings/v8/NPV8Object.cpp: (WebCore::createValueListFromVariantArgs): Returns PassOwnArrayPtr<v8::Handle<v8::Value>> instead of v8::Handle<v8::Value>*. (_NPN_Invoke): Calls createValueListFromVariantArgs. (_NPN_InvokeDefault): createValueListFromVariantArgs. (_NPN_Construct): createValueListFromVariantArgs.
  • bindings/v8/ScriptFunctionCall.cpp: (WebCore::ScriptFunctionCall::call): Calls adoptArrayPtr. (WebCore::ScriptFunctionCall::construct): Ditto. (WebCore::ScriptCallback::call):
  • bindings/v8/V8DOMWindowShell.cpp: (WebCore::V8DOMWindowShell::createNewContext): Ditto.
  • bindings/v8/V8NPObject.cpp: (WebCore::npObjectInvokeImpl): Ditto
  • bindings/v8/V8NodeFilterCondition.cpp: (WebCore::V8NodeFilterCondition::acceptNode): Ditto,
  • html/HTMLAreaElement.cpp: (WebCore::HTMLAreaElement::parseMappedAttribute): Calls newCoordsArray.
  • html/HTMLFrameSetElement.cpp: (WebCore::HTMLFrameSetElement::parseMappedAttribute): Calls newLengthArray.
  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::getAttachedShaders): Calls adoptArraYptr. (WebCore::WebGLRenderingContext::simulateVertexAttrib0): Ditto. (WebCore::WebGLRenderingContext::LRUImageBufferCache::LRUImageBufferCache): Dito.
  • platform/Length.cpp: (WebCore::newCoordsArray): Returns PassOwnArrayPtr<Length> instead of Length*. (WebCore::newLengthArray): Returns PassOwnArrayPtr<Length> instead of Length*.
  • platform/Length.h: Prototype changes.
  • platform/graphics/ANGLEWebKitBridge.cpp: (WebCore::ANGLEWebKitBridge::validateShaderSource): Calls adoptArrayPtr.
  • platform/graphics/ca/win/CACFLayerTreeHost.cpp: (WebCore::getDirtyRects): Ditto.
  • platform/graphics/chromium/ComplexTextControllerLinux.cpp: (WebCore::ComplexTextController::getNormalizedTextRun): Ditto.
  • platform/graphics/chromium/HarfbuzzSkia.cpp: (WebCore::glyphsToAdvances): Ditto. (WebCore::canRender): Ditto.
  • platform/graphics/gpu/Texture.cpp: (WebCore::Texture::updateSubRect): Ditto.
  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp: (WebCore::GraphicsContext3D::paintRenderingResultsToCanvas): Ditto.
  • platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::readbackHardwareToSoftware): Ditto.
  • platform/graphics/wince/SharedBitmap.cpp: (WebCore::SharedBitmap::to16bit): Ditto.
  • platform/win/ContextMenuWin.cpp: (WebCore::ContextMenu::getContextMenuItems): Ditto.
  • platform/win/LoggingWin.cpp: (WebCore::initializeWithUserDefault): Ditto.
  • plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackage::fetchInfo): Ditto.

2011-02-06 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

OwnArraryPtr.h uses deleteOwnedPtr but doesn’t include OwnPtrCommon.h
https://bugs.webkit.org/show_bug.cgi?id=52867

  • Shared/Plugins/Netscape/win/NetscapePluginModuleWin.cpp: (WebKit::NetscapePluginModule::getPluginInfo): Calls adoptArrayPtr.
20:54 Changeset [77784] by tkent@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-02-06 Kent Tamura <tkent@chromium.org>

Unreviewed.

  • WebCore.xcodeproj/project.pbxproj: Run sort-xcode-project-file.
20:08 Changeset [77783] by paroga@webkit.org
  • 2 edits in trunk/Source/WebKit/wince

2011-02-06 Patrick Gansterer <paroga@webkit.org>

Reviewed by Martin Robinson.

[WINCE] FrameLoaderClient calls loadURLInChildFrame on the child's frame loader
https://bugs.webkit.org/show_bug.cgi?id=53896

  • WebView.cpp: (WebView::createFrame): Use coreFrame instead of childFrame.
18:20 Changeset [77782] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-02-06 MORITA Hajime <morrita@google.com>

Unreviewed, unskip the html5lib test again which fails for another reason. (See Bug 53030)

  • platform/qt/Skipped:
17:40 Changeset [77781] by morrita@google.com
  • 13 edits in trunk

2011-02-06 Dominic Cooney <dominicc@google.com>

Reviewed by Dimitri Glazkov.

Convert <keygen> option elements to a shadow DOM
https://bugs.webkit.org/show_bug.cgi?id=51379

  • html5lib/runner-expected.txt: Two more tests pass.
  • platform/mac/fast/html/keygen-expected.txt: Shadow render tree.
  • platform/mac/fast/invalid/residual-style-expected.txt:

2011-02-03 Dominic Cooney <dominicc@google.com>

Reviewed by Dimitri Glazkov.

Convert <keygen> option elements to a shadow DOM
https://bugs.webkit.org/show_bug.cgi?id=51379

Covered by existing tests e.g. fast/html/keygen.html,
html5lib/runner.html, etc.

  • css/html.css: (form): Cleanup. (keygen, select): Border radii should match so focus ring looks good. (keygen::-webkit-keygen-select): No margin on the shadow element. (select): Hoisting border radius to keygen, select rule.
  • dom/SelectElement.cpp: (WebCore::toSelectElement): keygen is no longer a select element.
  • html/HTMLKeygenElement.cpp: Implements keygen shadow. (WebCore::KeygenSelectElement::create): (WebCore::KeygenSelectElement::shadowPseudoId): (WebCore::KeygenSelectElement::KeygenSelectElement): (WebCore::HTMLKeygenElement::HTMLKeygenElement): (WebCore::HTMLKeygenElement::parseMappedAttribute): (WebCore::HTMLKeygenElement::appendFormData): (WebCore::HTMLKeygenElement::formControlType): (WebCore::HTMLKeygenElement::reset): (WebCore::HTMLKeygenElement::selectShadow):
  • html/HTMLKeygenElement.h: keygen is no longer a select on C++ side. (WebCore::HTMLKeygenElement::canStartSelection): (WebCore::HTMLKeygenElement::isEnumeratable): (WebCore::HTMLKeygenElement::isResettable):
  • html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::ownerSelectElement): Only owned by selects.
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::HTMLSelectElement): Only 'select' tag name.
17:00 Changeset [77780] by commit-queue@webkit.org
  • 1 edit
    5 adds in trunk/Tools

2011-02-06 James Kozianski <koz@chromium.org>

Reviewed by Ojan Vafai.

Add classes for representing test outputs.
https://bugs.webkit.org/show_bug.cgi?id=52136

These classes will make it easier to write scripts that deal with test
outputs such as rebaselining and deduping scripts. The intent is that
eventually we will be have buildbot return TestOutputs for a
particular build which can be compared with TestOutputs derived from a
local LayoutTests directory.

  • Scripts/webkitpy/common/net/testoutput.py: Added.
  • Scripts/webkitpy/common/net/testoutput_unittest.py: Added.
  • Scripts/webkitpy/common/net/testoutputset.py: Added.
  • Scripts/webkitpy/common/net/testoutputset_unittest.py: Added.
  • Scripts/webkitpy/common/system/zip_mock.py: Added.
15:48 Changeset [77779] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-06 Benjamin Poulain <ikipou@gmail.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Fix coding style errors in ClipboardQt.h
https://bugs.webkit.org/show_bug.cgi?id=43520

Fix coding style: order of header and indentation.

  • platform/qt/ClipboardQt.h: (WebCore::ClipboardQt::create): (WebCore::ClipboardQt::clipboardData): (WebCore::ClipboardQt::invalidateWritableData):
14:16 Changeset [77778] by paroga@webkit.org
  • 1 edit
    6 deletes in trunk/LayoutTests

2011-02-06 Patrick Gansterer <paroga@webkit.org>

Reviewed by Oliver Hunt.

Remove empty svg test
https://bugs.webkit.org/show_bug.cgi?id=53887

This files are empty. Empty tests are pretty useless.

  • platform/chromium-win/svg/custom/use-infinite-recursion-expected.png: Removed.
  • platform/mac/svg/custom/use-infinite-recursion-expected.checksum: Removed.
  • platform/mac/svg/custom/use-infinite-recursion-expected.png: Removed.
  • platform/mac/svg/custom/use-infinite-recursion-expected.txt: Removed.
  • platform/qt/svg/custom/use-infinite-recursion-expected.txt: Removed.
  • svg/custom/use-infinite-recursion.svg: Removed.
12:43 Changeset [77777] by antti@apple.com
  • 8 edits
    2 adds in trunk/Source

Use bloom filter for descendant selector filtering
https://bugs.webkit.org/show_bug.cgi?id=53880

Reviewed by Maciej Stachowiak.

Source/JavaScriptCore:

Implement a bloom filter with k=2 and 8 bit counting.

(WTF::BloomFilter::maximumCount):
(WTF::BloomFilter::BloomFilter):
(WTF::BloomFilter::mayContain):
(WTF::BloomFilter::add):
(WTF::BloomFilter::remove):
(WTF::BloomFilter::firstSlot):
(WTF::BloomFilter::secondSlot):
(WTF::::add):
(WTF::::remove):
(WTF::::clear):
(WTF::::likelyEmpty):
(WTF::::isClear):

Source/WebCore:

Bloom filter is faster than a hash set in this kind of use.

Shark thinks this speeds up style matching by ~30% on sites
with lots of descendant selectors.

  • ForwardingHeaders/wtf/BloomFilter.h: Added.
  • css/CSSStyleSelector.cpp:

(WebCore::collectElementIdentifierHashes):
(WebCore::CSSStyleSelector::pushParent):
(WebCore::CSSStyleSelector::popParent):
(WebCore::CSSStyleSelector::fastRejectSelector):
(WebCore::RuleData::collectDescendantSelectorIdentifierHashes):

  • css/CSSStyleSelector.h:
12:05 Changeset [77776] by mjs@apple.com
  • 2 edits in trunk/Source/WebCore

2011-02-06 Maciej Stachowiak <mjs@apple.com>

Reviewed by Antti Koivisto.

media/video-document-types.html sometimes crashes the WebProcess
https://bugs.webkit.org/show_bug.cgi?id=53884

No new tests. Already covered by media/video-document-types.html

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::userCancelledLoad): Stop the load timer when cancelling the load.
10:52 Changeset [77775] by paroga@webkit.org
  • 15 edits in trunk/Source/WebCore

2011-02-06 Patrick Gansterer <paroga@webkit.org>

Reviewed by Adam Roben.

[WIN] Use WCHAR instead of TCHAR
https://bugs.webkit.org/show_bug.cgi?id=53863

We always use the UNICODE versions of windows functions, so
the usage of TCHAR makes no sense and mixing them is bad style.

  • platform/graphics/win/IconWin.cpp: (WebCore::Icon::createIconForFiles):
  • platform/graphics/win/QTMovie.cpp:
  • platform/graphics/win/QTMovieGWorld.cpp: (QTMovieGWorld::fullscreenWndProc): (QTMovieGWorld::enterFullscreen):
  • platform/graphics/win/SimpleFontDataCGWin.cpp: (WebCore::SimpleFontData::platformInit):
  • platform/graphics/win/SimpleFontDataCairoWin.cpp:
  • platform/graphics/win/SimpleFontDataWin.cpp:
  • platform/graphics/wince/SimpleFontDataWinCE.cpp:
  • platform/win/BString.cpp:
  • platform/win/ClipboardWin.cpp: (WebCore::filesystemPathFromUrlOrTitle): (WebCore::createGlobalHDropContent): (WebCore::createGlobalImageFileDescriptor):
  • platform/win/ContextMenuWin.cpp:
  • platform/win/CursorWin.cpp: (WebCore::loadSharedCursor):
  • platform/win/FileChooserWin.cpp: (WebCore::FileChooser::basenameForWidth):
  • platform/win/PopupMenuWin.cpp: (WebCore::PopupMenuWin::popupClassName): (WebCore::PopupMenuWin::show):
  • platform/win/PopupMenuWin.h:
10:44 Changeset [77774] by paroga@webkit.org
  • 9 edits in trunk/Source/WebCore

2011-02-06 Patrick Gansterer <paroga@webkit.org>

Reviewed by Andreas Kling.

Replace FLT_MAX with std::numeric_limits
https://bugs.webkit.org/show_bug.cgi?id=53861

Also move EFL's userIdleTime from TemporaryLinkStubs into SystemTimeEfl.

  • html/NumberInputType.cpp:
  • html/parser/HTMLParserIdioms.cpp: (WebCore::parseToDoubleForNumberType):
  • platform/brew/SystemTimeBrew.cpp: (WebCore::userIdleTime):
  • platform/efl/SystemTimeEfl.cpp: (WebCore::userIdleTime):
  • platform/efl/TemporaryLinkStubs.cpp:
  • platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::setupAnimation):
  • platform/win/SystemTimeWin.cpp: (WebCore::userIdleTime):
  • platform/wx/SystemTimeWx.cpp: (WebCore::userIdleTime):
10:39 Notes on Content Security Policies edited by abarth@webkit.org
(diff)
10:38 Notes on Content Security Policies created by abarth@webkit.org
10:31 Changeset [77773] by robert@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

2011-02-06 Robert Hogan <robert@webkit.org>

Reviewed by Andreas Kling.

[Qt] Remove unnecessary QRect assignment
https://bugs.webkit.org/show_bug.cgi?id=53873

  • Api/qwebframe.cpp: (QWebFramePrivate::renderRelativeCoords):
10:18 Changeset [77772] by robert@webkit.org
  • 4 edits in trunk

2011-02-06 Robert Hogan <robert@webkit.org>

Reviewed by Andreas Kling.

[Qt] Clear page's groupName even when not in DRT
https://bugs.webkit.org/show_bug.cgi?id=53874

Matches behaviour of other ports.

  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::closeWindowSoon):

2011-02-06 Robert Hogan <robert@webkit.org>

Reviewed by Andreas Kling.

[Qt] Clear page's groupName even when not in DRT
https://bugs.webkit.org/show_bug.cgi?id=53874

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::windowCloseRequested):
09:47 Changeset [77771] by paroga@webkit.org
  • 6 edits in trunk

2011-02-06 Patrick Gansterer <paroga@webkit.org>

Reviewed by Andreas Kling.

[CMake] Add dependencies for Visual Studio projects
https://bugs.webkit.org/show_bug.cgi?id=53773

Add a JavaScriptCore dependecy to WebCore, so CMake can
generate the correct build order for the solution.

  • CMakeLists.txt:

2011-02-06 Patrick Gansterer <paroga@webkit.org>

Reviewed by Andreas Kling.

[CMake] Add dependencies for Visual Studio projects
https://bugs.webkit.org/show_bug.cgi?id=53773

Add a WebCore dependecy to WebKit, so CMake can
generate the correct build order for the solution.

Remove JavaScriptCore dependecy, since WebCore already depends on it.

  • CMakeLists.txt:

2011-02-06 Patrick Gansterer <paroga@webkit.org>

Reviewed by Andreas Kling.

[CMake] Add dependencies for Visual Studio projects
https://bugs.webkit.org/show_bug.cgi?id=53773

Add a WebKit dependecy to WinCELauncher, so CMake can
generate the correct build order for the solution.

  • CMakeListsWinCE.txt:
09:14 Changeset [77770] by paroga@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-06 Patrick Gansterer <paroga@webkit.org>

Reviewed by Andreas Kling.

[CMake] Unify ENABLE_SVG sections
https://bugs.webkit.org/show_bug.cgi?id=53778

  • CMakeLists.txt:
09:08 Changeset [77769] by mrobinson@webkit.org
  • 2 edits in trunk/LayoutTests

2011-02-06 Martin Robinson <mrobinson@igalia.com>

Reclassify a failing test and unskip another which should be passing now.

  • platform/gtk/Skipped: Update the skipped list.
08:22 Changeset [77768] by andreas.kling@nokia.com
  • 5 edits in trunk/Source/WebCore

2011-02-06 Andreas Kling <kling@webkit.org>

Reviewed by Dirk Schulze.

Refactor Font::normalizeSpaces() to avoid an extra String copy.
https://bugs.webkit.org/show_bug.cgi?id=53871

Have normalizeSpaces() take UChar*,length arguments instead of a
String, since all call sites were creating temporaries from these
components anyway.

Font::normalizeSpaces() now always makes 1 String copy,
instead of 1 in the best case and 2 in the worst case.

  • platform/graphics/Font.cpp: (WebCore::Font::normalizeSpaces):
  • platform/graphics/Font.h:
  • platform/graphics/qt/FontQt.cpp: (WebCore::drawTextCommon): (WebCore::Font::floatWidthForSimpleText): (WebCore::Font::floatWidthForComplexText): (WebCore::Font::offsetForPositionForSimpleText): (WebCore::Font::offsetForPositionForComplexText): (WebCore::Font::selectionRectForSimpleText): (WebCore::Font::selectionRectForComplexText):
  • svg/SVGFont.cpp: (WebCore::SVGTextRunWalker::walk):
07:19 Changeset [77767] by andreas.kling@nokia.com
  • 4 edits in trunk/Tools

2011-02-06 Andreas Kling <kling@webkit.org>

Reviewed by Antonio Gomes.

[Qt] MiniBrowser: Clean up handling of titleChanged() signal
https://bugs.webkit.org/show_bug.cgi?id=53869

  • MiniBrowser/qt/BrowserView.cpp: (BrowserView::BrowserView): Remove unnecessary titleChanged() handling.
  • MiniBrowser/qt/BrowserWindow.cpp: (BrowserWindow::BrowserWindow): Connect titleChanged() directly to setWindowTitle().
  • MiniBrowser/qt/BrowserWindow.h:
06:35 Changeset [77766] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebCore

2011-02-06 Andreas Kling <kling@webkit.org>

Reviewed by Dirk Schulze.

Fix potential buffer overrun in SVGTextRunWalker::walk()
https://bugs.webkit.org/show_bug.cgi?id=53870

A new String was created from a UChar* with a 'length' argument
that could be greater than the number of UChars available.

  • svg/SVGFont.cpp: (WebCore::SVGTextRunWalker::walk):
05:23 Changeset [77765] by commit-queue@webkit.org
  • 11 edits in trunk/Source/WebKit2

2011-02-06 Benjamin Poulain <ikipou@gmail.com>

Reviewed by Andreas Kling.

[Qt] WebKit does not build on Mac with WebKit 2
https://bugs.webkit.org/show_bug.cgi?id=53380

  • Platform/CoreIPC/qt/ConnectionQt.cpp: Use fcntl() to set close on exec so we do not rely on recent kernel. (CoreIPC::Connection::readyReadHandler):
  • Platform/qt/SharedMemoryQt.cpp: ditto (WebKit::SharedMemory::create): (WebKit::SharedMemory::createHandle):
  • UIProcess/Launcher/qt/ProcessLauncherQt.cpp: Guard prctl() since it is a Linux specific function. (WebKit::QtWebProcess::setupChildProcess):
  • UIProcess/DrawingAreaProxy.h: Differentiate between building on Mac and the Mac port.
  • UIProcess/DrawingAreaProxyImpl.cpp: ditto
  • UIProcess/WebPageProxy.cpp: ditto (WebKit::WebPageProxy::didReceiveMessage):
  • WebProcess/WebPage/DrawingArea.cpp: ditto (WebKit::DrawingArea::create):
  • WebProcess/WebPage/DrawingArea.h:
  • WebProcess/WebPage/DrawingAreaImpl.cpp: ditto
  • WebProcess/WebPage/WebPage.cpp: ditto (WebKit::WebPage::didReceiveMessage):
02:46 Changeset [77764] by robert@webkit.org
  • 2 edits in trunk/LayoutTests

2011-02-06 Robert Hogan <robert@webkit.org>

Unreviewed, skip failing test on Qt bot.

[Qt] fast/notifications/notifications-document-close-crash.html fails after r77738
https://bugs.webkit.org/show_bug.cgi?id=53868

  • platform/qt/Skipped: Skip fast/notifications/notifications-document-close-crash.html
02:35 Changeset [77763] by mjs@apple.com
  • 8 edits in trunk

2011-02-06 Maciej Stachowiak <mjs@apple.com>

Reviewed by Dan Bernstein.

WebKitTestRunner needs layoutTestController.setWillSendRequestReturnsNull
https://bugs.webkit.org/show_bug.cgi?id=42690
<rdar://problem/8213851>

  • platform/mac-wk2/Skipped: Unskip tests that now pass, except for the ones that mysteriously fail.

2011-02-06 Maciej Stachowiak <mjs@apple.com>

Reviewed by Dan Bernstein.

WebKitTestRunner needs layoutTestController.setWillSendRequestReturnsNull
https://bugs.webkit.org/show_bug.cgi?id=42690
<rdar://problem/8213851>

  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::willSendRequestForFrame):
  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::LayoutTestController):
  • WebKitTestRunner/InjectedBundle/LayoutTestController.h: (WTR::LayoutTestController::willSendRequestReturnsNull): (WTR::LayoutTestController::setWillSendRequestReturnsNull):

02/05/11:

22:05 Changeset [77762] by mrowe@apple.com
  • 5 edits in branches/safari-533.20-branch

Versioning.

22:05 Changeset [77761] by mrowe@apple.com
  • 1 copy in tags/Safari-533.20.25

New tag.

22:00 Changeset [77760] by mrowe@apple.com
  • 1 edit in branches/safari-533.20-branch/WebKit/win/WebCoreSupport/WebContextMenuClient.cpp

Build fix.

21:24 Changeset [77759] by mjs@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-02-05 Maciej Stachowiak <mjs@apple.com>

Reviewed by Dan Bernstein.

REGRESSION: New drawing area is causing some WebProcess crashes in layout tests
https://bugs.webkit.org/show_bug.cgi?id=53865
<rdar://problem/8963148>


  • WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::enterAcceleratedCompositingMode): Handle the case where this is called repeatedly without exiting accelerated composting mode first. (WebKit::DrawingAreaImpl::exitAcceleratedCompositingMode): Handle the case of being called more than once.
21:05 Changeset [77758] by dglazkov@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-02-05 Dimitri Glazkov <dglazkov@chromium.org>

[Chromium] Add baselines for the test added in r77690.

  • platform/chromium-mac/media/video-frame-accurate-seek-expected.checksum: Added.
  • platform/chromium-mac/media/video-frame-accurate-seek-expected.png: Added.
18:58 Changeset [77757] by dglazkov@chromium.org
  • 2 edits in trunk/LayoutTests

2011-02-05 Dimitri Glazkov <dglazkov@chromium.org>

Remove passing canvas tests from expectations.

  • platform/chromium/test_expectations.txt: Removed passing tests.
18:44 Changeset [77756] by dglazkov@chromium.org
  • 2 edits in trunk/LayoutTests

2011-02-05 Dimitri Glazkov <dglazkov@chromium.org>

Remove passing tests whose results match mac/ and mac-leopard.

  • platform/chromium/test_expectations.txt: Removed passing tests.
18:07 Changeset [77755] by abarth@webkit.org
  • 8 edits in trunk/Source/WebCore

2011-02-05 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Remove unused parameter related to XSSAuditor
https://bugs.webkit.org/show_bug.cgi?id=53862

  • WebCore.exp.in:
  • bindings/ScriptControllerBase.cpp: (WebCore::ScriptController::executeScript): (WebCore::ScriptController::executeIfJavaScriptURL):
  • bindings/ScriptControllerBase.h:
  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::evaluateInWorld): (WebCore::ScriptController::evaluate): (WebCore::ScriptController::executeScriptInWorld):
  • bindings/js/ScriptController.h:
  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::evaluate):
  • bindings/v8/ScriptController.h:
16:54 Changeset [77754] by dglazkov@chromium.org
  • 1 edit
    125 deletes in trunk/LayoutTests

2011-02-05 Dimitri Glazkov <dglazkov@chromium.org>

Remove results for failing SVG tests. I will add the new ones after the
bots tell me which ones aren't matching mac/ or mac-leopard/.

15:02 Changeset [77753] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-02-05 Adam Barth <abarth@webkit.org>

Fix Qt build.

  • WebCore.pro:
14:55 Changeset [77752] by abarth@webkit.org
  • 20 edits
    2 deletes in trunk/Source/WebCore

2011-02-05 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Delete XSSAuditor
https://bugs.webkit.org/show_bug.cgi?id=53859

The job of the XSSAuditor is now done by the XSSFilter. In the future,
we might rename XSSFilter to XSSAuditor.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/ScriptControllerBase.cpp: (WebCore::ScriptController::executeIfJavaScriptURL):
  • bindings/ScriptControllerBase.h:
  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::ScriptController): (WebCore::ScriptController::evaluateInWorld):
  • bindings/js/ScriptController.h:
  • bindings/js/ScriptEventListener.cpp: (WebCore::createAttributeEventListener):
  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::ScriptController): (WebCore::ScriptController::evaluate):
  • bindings/v8/ScriptController.h:
  • bindings/v8/ScriptEventListener.cpp: (WebCore::createAttributeEventListener):
  • dom/Document.cpp: (WebCore::Document::implicitOpen): (WebCore::Document::processBaseElement):
  • dom/ScriptableDocumentParser.cpp: (WebCore::ScriptableDocumentParser::ScriptableDocumentParser):
  • dom/ScriptableDocumentParser.h:
  • html/parser/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::shouldLoadExternalScriptFromSrc):
  • loader/SubframeLoader.cpp: (WebCore::SubframeLoader::requestObject): (WebCore::SubframeLoader::loadMediaPlayerProxyPlugin):
  • page/XSSAuditor.cpp: Removed.
  • page/XSSAuditor.h: Removed.
14:28 Changeset [77751] by andersca@apple.com
  • 18 edits in trunk/Source

2011-02-05 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler.

Need a way to resize and scroll the page at the same time
https://bugs.webkit.org/show_bug.cgi?id=53814
<rdar://problem/8498008>

Export a function needed by WebKit2.

  • WebCore.exp.in:

2011-02-05 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler.

Need a way to resize and scroll the page at the same time
https://bugs.webkit.org/show_bug.cgi?id=53814
<rdar://problem/8498008>

Add -[WKView setFrame:andScrollBy:].

  • UIProcess/API/mac/WKView.h:
  • UIProcess/API/mac/WKView.mm: (-[WKView setFrame:andScrollBy:]): Stash away the scroll offset and call setFrame:.

(-[WKView _switchToDrawingAreaTypeIfNecessary:DrawingAreaInfo::]):
(-[WKView _setDrawingAreaSize:]):

  • UIProcess/API/qt/qwkpage.cpp: (QWKPage::setViewportSize): DrawingAreaProxy::setSize now takes a scroll offset.
  • UIProcess/DrawingAreaProxy.cpp: (WebKit::DrawingAreaProxy::setSize): This now takes a scroll offset and stores it in m_scrollOffset.
  • UIProcess/DrawingAreaProxy.h:
  • UIProcess/DrawingAreaProxyImpl.cpp: (WebKit::DrawingAreaProxyImpl::sendSetSize): Send along the scroll offset and set it back to zero.
  • UIProcess/LayerBackedDrawingAreaProxy.cpp: (WebKit::LayerBackedDrawingAreaProxy::didSetSize):
  • UIProcess/TiledDrawingAreaProxy.cpp: (WebKit::TiledDrawingAreaProxy::didSetSize):
  • UIProcess/win/WebView.cpp: (WebKit::WebView::onSizeEvent): (WebKit::WebView::switchToDrawingAreaTypeIfNecessary): DrawingAreaProxy::setSize now takes a scroll offset.


  • WebProcess/WebPage/DrawingArea.h: (WebKit::DrawingArea::setSize): Add a scrollOffset parameter.
  • WebProcess/WebPage/DrawingArea.messages.in: Add a scroll offset parameter to the SetSize message.
  • WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::setSize): Call WebPage::scrollMainFrameIfNotAtMaxScrollPosition.
  • WebProcess/WebPage/DrawingAreaImpl.h:
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::scrollMainFrameIfNotAtMaxScrollPosition): Compute a scroll offset and call setScrollPosition on the main frame view.
12:34 Changeset [77750] by paroga@webkit.org
  • 6 edits in trunk/Source/WebCore

2011-02-05 Patrick Gansterer <paroga@webkit.org>

Reviewed by Alexey Proskuryakov.

Use Document::encoding() instead of DocumentWriter::encoding()
https://bugs.webkit.org/show_bug.cgi?id=53398

This change makes the code more readable, when a subresource
inherits the character encoding of the document.

  • dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::checkStyleSheet):
  • dom/ScriptElement.cpp: (WebCore::ScriptElement::scriptCharset):
  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::process):
  • loader/cache/CachedResourceLoader.cpp: (WebCore::CachedResourceLoader::requestPreload):
  • platform/network/FormDataBuilder.cpp: (WebCore::FormDataBuilder::encodingFromAcceptCharset):
12:30 Changeset [77749] by paroga@webkit.org
  • 7 edits
    1 add in trunk/LayoutTests

2011-02-05 Patrick Gansterer <paroga@webkit.org>

Reviewed by Alexey Proskuryakov.

Add addition test for inherited encoding
https://bugs.webkit.org/show_bug.cgi?id=53398

Check if the right encoding is used, after document.charset was set.

  • fast/dom/Document/document-charset.html: Added doctype to make it pass in IE9 out of the box.
  • fast/encoding/css-charset-default-expected.txt:
  • fast/encoding/css-charset-default.xhtml:
  • fast/encoding/external-script-charset-expected.txt:
  • fast/encoding/external-script-charset-koi-8.js: Added.
  • fast/encoding/external-script-charset.js:
  • fast/encoding/external-script-charset.xhtml:
12:21 Changeset [77748] by abarth@webkit.org
  • 6 edits
    1 add in trunk/Source/WebCore

2011-02-05 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Introduce URLString to represent a canonicalized URL represented by a string
https://bugs.webkit.org/show_bug.cgi?id=53847

Instead of using String all over the codebase to represent a URL,
instead we should have a type to represent a canonicalized URL in the
form of a string. This patch introduces that type.

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/KURL.cpp: (WebCore::KURL::KURL):
  • platform/KURL.h: (WebCore::KURL::urlString):
10:26 Changeset [77747] by mrobinson@webkit.org
  • 2 edits in trunk/LayoutTests

2011-02-05 Martin Robinson <mrobinson@igalia.com>

JSC::Bindings m_rootObject->isValid() assert fails when running layout tests
https://bugs.webkit.org/show_bug.cgi?id=53716

  • platform/gtk/Skipped: Skip a test hitting this assertion.
09:55 Changeset [77746] by robert@webkit.org
  • 4 edits in trunk

2011-02-05 Robert Hogan <robert@webkit.org>

Reviewed by Antonio Gomes.

[Qt] Style widgets not rendering
https://bugs.webkit.org/show_bug.cgi?id=53849

  • platform/qt/Skipped: Unskip plugins/application-plugins-plugins-disabled.html

2011-02-05 Robert Hogan <robert@webkit.org>

Reviewed by Antonio Gomes.

[Qt] Style widgets not rendering
https://bugs.webkit.org/show_bug.cgi?id=53849

  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::hasValidClassId): x-qt-styled-widget is a valid class id too
09:19 Changeset [77745] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

2011-02-05 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r77720.
http://trac.webkit.org/changeset/77720
https://bugs.webkit.org/show_bug.cgi?id=53854

"Broke nrwt on Chromium win." (Requested by dglazkov|away on
#webkit).

  • Scripts/webkitpy/common/system/executive.py:
05:00 Changeset [77744] by zimmermann@webkit.org
  • 168 edits in trunk/LayoutTests

2011-02-04 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed.

small text which is scaled to be large renders pixelated
https://bugs.webkit.org/show_bug.cgi?id=12448

Update Snow Leopard SVG pixel test baseline after r77485.

  • platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.png:
  • platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.png:

...

04:48 Changeset [77743] by eric@webkit.org
  • 3 edits in trunk/LayoutTests

2011-02-05 Eric Seidel <eric@webkit.org>

Unreviewed.

Safari should lowercase schemes in cannonicalized urls to match every other browser
https://bugs.webkit.org/show_bug.cgi?id=53848

Checkin results I forgot to update in my previous commit. All progressions.

  • fast/dom/anchor-origin-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-uppercase-expected.txt:
03:52 Changeset [77742] by jochen@chromium.org
  • 6 edits in trunk/Source/WebCore

2011-02-05 Jochen Eisinger <jochen@chromium.org>

Reviewed by Adam Barth.

Add ContentSecurityPolicy object to Document and pass the X-WebKit-CSP header from the MainResourceLoader.
https://bugs.webkit.org/show_bug.cgi?id=53685

  • WebCore.xcodeproj/project.pbxproj:
  • dom/Document.h: (WebCore::Document::contentSecurityPolicy):
  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::didReceiveResponse):
  • page/ContentSecurityPolicy.cpp: (WebCore::ContentSecurityPolicy::didReceiveHeader):
  • page/ContentSecurityPolicy.h:
03:43 Changeset [77741] by eric@webkit.org
  • 8 edits in trunk

2011-02-05 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Safari should lowercase schemes in cannonicalized urls to match every other browser
https://bugs.webkit.org/show_bug.cgi?id=53848

Update our results now that we pass more tests.

  • fast/url/file-expected.txt:
  • fast/url/file-http-base-expected.txt:
  • fast/url/path-url-expected.txt:
  • fast/url/relative-expected.txt:
  • fast/url/scheme-expected.txt:

2011-02-05 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Safari should lowercase schemes in cannonicalized urls to match every other browser
https://bugs.webkit.org/show_bug.cgi?id=53848

We're clearly the odd man out here. See results from every browser at:
https://github.com/abarth/url-spec/blob/master/tests/gurl-results/by-browser.txt

  • platform/KURL.cpp: (WebCore::KURL::parse):
    • Just lowercase the scheme when copying.
03:23 Changeset [77740] by antti@apple.com
  • 4 edits in trunk/Source/WebCore

Optimize matching of descendant selectors
https://bugs.webkit.org/show_bug.cgi?id=49876
<rdar://problem/8772822>

Reviewed by Dave Hyatt.

During style recalculation, maintain a filter of tags, ids and classes seen in ancestor elements.
Use the filter to quickly reject descendant and child selectors when doing style matching.

This speeds up style recalculations 3-6x on many major web sites.

  • css/CSSStyleSelector.cpp:

(WebCore::RuleData::RuleData):
(WebCore::RuleData::descendantSelectorIdentifierHashes):
(WebCore::collectElementIdentifiers):
(WebCore::CSSStyleSelector::pushParent):
(WebCore::CSSStyleSelector::popParent):
(WebCore::CSSStyleSelector::fastRejectSelector):
(WebCore::CSSStyleSelector::matchRulesForList):
(WebCore::RuleData::collectDescendantSelectorIdentifierHashes):

  • css/CSSStyleSelector.h:

(WebCore::CSSStyleSelector::ParentStackFrame::ParentStackFrame):

  • dom/Element.cpp:

(WebCore::StyleSelectorParentPusher::StyleSelectorParentPusher):
(WebCore::StyleSelectorParentPusher::push):
(WebCore::StyleSelectorParentPusher::~StyleSelectorParentPusher):
(WebCore::Element::attach):
(WebCore::Element::recalcStyle):

03:12 Changeset [77739] by eric@webkit.org
  • 1 edit
    3 adds in trunk/PerformanceTests

2011-02-05 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Add performance tests for URL parsing
https://bugs.webkit.org/show_bug.cgi?id=53845

The final-url-en URL corpus is from:
http://corpus.leeds.ac.uk/internet.html

There are also other language corpuses which we may want to use in the future.

The usage instructions were as follows:
"URL lists and other resources: you can freely use them in your research
provided that you supply a link to this website: http://corpus.leeds.ac.uk/."
Done.

  • Parser/simple-url.html: Added. On my machine: Firefox: 255ms TOT WebKit: 378ms Chrome: 286ms Opera: 2830ms (no, that is not a typo)
  • Parser/url-parser.html: Added. Firefox: 381ms TOT WebKit: 216ms Chrome: 131ms Opera: 1383ms (again, not a typo)
  • Parser/resources/final-url-en: Added.
02:37 Changeset [77738] by japhet@chromium.org
  • 5 edits in trunk/Source/WebCore

2011-02-05 Nate Chapin <japhet@chromium.org>

Reviewed by Adam Barth.

Refactor: NotificationCenter shouldn't hold its own copy of the ScriptExecutionContext*
when it inherits one from ActiveDOMObject.
https://bugs.webkit.org/show_bug.cgi?id=53815

  • bindings/js/JSDesktopNotificationsCustom.cpp: (WebCore::JSNotificationCenter::requestPermission):
  • bindings/v8/custom/V8NotificationCenterCustom.cpp: (WebCore::V8NotificationCenter::requestPermissionCallback):
  • notifications/NotificationCenter.cpp: (WebCore::NotificationCenter::NotificationCenter): (WebCore::NotificationCenter::checkPermission): (WebCore::NotificationCenter::requestPermission): (WebCore::NotificationCenter::disconnectFrame):
  • notifications/NotificationCenter.h: (WebCore::NotificationCenter::createHTMLNotification): (WebCore::NotificationCenter::createNotification):
00:02 Changeset [77737] by commit-queue@webkit.org
  • 4 edits in trunk/Tools

2011-02-05 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r77725.
http://trac.webkit.org/changeset/77725
https://bugs.webkit.org/show_bug.cgi?id=53844

It broke Qt minimal build (Requested by Ossy_ on #webkit).

  • QtTestBrowser/launcherwindow.cpp: (LauncherWindow::createChrome):
  • QtTestBrowser/launcherwindow.h: (WindowOptions::WindowOptions):
  • QtTestBrowser/main.cpp: (LauncherApplication::handleUserOptions):
Note: See TracTimeline for information about the timeline view.