Timeline
02/10/11:
- 23:36 Changeset [78318] by
-
2011-02-10 Maciej Stachowiak <mjs@apple.com>
Reviewed by Dan Bernstein.
Temporarily skip a test that fails in WebKit2 due to a recent regression
https://bugs.webkit.org/show_bug.cgi?id=54276
- platform/mac-wk2/Skipped:
- 23:21 Changeset [78317] by
-
2011-02-10 Andy Estes <aestes@apple.com>
Reviewed by Eric Seidel.
Convert ContainerNode::firstElementChild() to a free function.
https://bugs.webkit.org/show_bug.cgi?id=54269
No new tests. No change in behavior.
It seemed incorrect to have a method on ContainerNode that had the
concept of an Element but couldn't return an Element*, but a method on
Element could not be called by holders of ContainerNodes or other
non-Element ContainerNode subclasses. A free function can both return
an Element* and be called by anyone with a ContainerNode*.
- dom/ContainerNode.h: (WebCore::ContainerNode::lastChild): (WebCore::Node::lastChild):
- dom/Document.cpp: (WebCore::Document::cacheDocumentElement):
- dom/Element.cpp: (WebCore::Element::firstElementChild):
- dom/Element.h: (WebCore::firstElementChild):
- html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::FragmentParsingContext::finished):
- 22:50 Changeset [78316] by
-
2011-02-10 Mads Ager <ager@chromium.org>
Reviewed by Nate Chapin.
[V8] Don't crash on exception getting event handler function
https://bugs.webkit.org/show_bug.cgi?id=54216
Check for exceptions when attempting to get the handleEvent property
of an event-handler object.
Test: fast/dom/exception-getting-event-handler.html
- bindings/v8/V8EventListener.cpp: (WebCore::V8EventListener::getListenerFunction):
2011-02-10 Mads Ager <ager@chromium.org>
Reviewed by Nate Chapin.
[V8] Don't crash on exception getting event handler function
https://bugs.webkit.org/show_bug.cgi?id=54216
Add crash regression test with custom chromium expectations.
- fast/dom/exception-getting-event-handler-expected.txt: Added.
- fast/dom/exception-getting-event-handler.html: Added.
- platform/chromium/fast/dom/exception-getting-event-handler-expected.txt: Added.
- 22:38 Changeset [78315] by
-
2011-02-10 Naoki Takano <takano.naoki@gmail.com>
Reviewed by James Robinson.
[Chromium] Layout Test canvas/philip/tests/2d.composite.globalAlpha.fill.html with --accelerated-2d-canvas.
https://bugs.webkit.org/show_bug.cgi?id=53857
This fix is for 2d.composite.globalAlpha.fill.html with --accelerated-2d-canvas. Add 2d.composite.globalAlpha.fillPath.html as a new test for the combination with globalAlpha and fillPath().
- fast/canvas/2d.composite.globalAlpha.fillPath-expected.txt: Added.
- fast/canvas/2d.composite.globalAlpha.fillPath.html: Added.
2011-02-10 Naoki Takano <takano.naoki@gmail.com>
Reviewed by James Robinson.
[Chromium] Layout Test canvas/philip/tests/2d.composite.globalAlpha.fill.html with --accelerated-2d-canvas.
https://bugs.webkit.org/show_bug.cgi?id=53857
globalAlpha is not applied to fillPath() and fillRect().
Test: fast/canvas/2d.composite.globalAlpha.fillPath.html and canvas/philip/tests/2d.composite.globalAlpha.fill.html with --accelerated-2d-canvas.
- platform/graphics/chromium/GLES2Canvas.cpp: (WebCore::GLES2Canvas::State::applyAlpha): Append a new function to apply global alpha when fillRect() and fillPath() are called. (WebCore::GLES2Canvas::fillRect): Global alpha is applied to m_fillColor. (WebCore::GLES2Canvas::fillPath): Global alpha is applied to m_fillColor.
- 22:35 Changeset [78314] by
-
2011-02-10 Andy Estes <aestes@apple.com>
Reviewed by Adam Barth.
Remove an unneeded argument from HTMLDocument::create().
https://bugs.webkit.org/show_bug.cgi?id=54268
Now that HTMLTreeBuilder no longer uses a dummy HTMLDocument for
fragment parsing, there isn't a need to explicitly specify a baseURL
when constructing an HTMLDocument. We can remove the unneeded argument.
Also fix some style issues in Document.h and HTMLDocument.h caught by
check-webkit-style.
No new tests. No change in behavior.
- dom/Document.cpp: (WebCore::Document::Document):
- dom/Document.h:
- html/HTMLDocument.cpp: (WebCore::HTMLDocument::HTMLDocument):
- html/HTMLDocument.h: (WebCore::HTMLDocument::create):
- 22:17 Changeset [78313] by
-
2011-02-10 Martin Robinson <mrobinson@igalia.com>
Clean up the skipped list and skip some tests that show differences
between the bots. Rebaseline Acid2 tests results.
- platform/gtk/Skipped: Clean up the skipped list. Skip failing test.
- platform/gtk/http/tests/misc/acid2-expected.txt:
- platform/gtk/http/tests/misc/acid2-pixel-expected.txt:
- 21:34 Changeset [78312] by
-
2011-02-10 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
A little more encapsulation for MarkedBlock: Made all constants private
so clients don't know whether allocations are fixed-sized or not
https://bugs.webkit.org/show_bug.cgi?id=54270
SunSpider reports no change.
- runtime/CollectorHeapIterator.h: (JSC::CollectorHeapIterator::advance): Updated for removal of HeapConstants.
- runtime/Error.cpp: Switched to using ASSERT_CLASS_FITS_IN_CELL, like all other classes.
- runtime/Heap.cpp: (JSC::Heap::allocate): Updated for removal of HeapConstants. (JSC::Heap::reset): Updated to use size(), instead of calculating size on our own.
- runtime/Heap.h: Moved the ASSERT here to MarkedBlock, since it enforces on special knowledge of fixed-sizery, which only MarkedBlock is supposed to know about.
- runtime/JSCell.h: (JSC::JSCell::MarkedBlock::allocate): Updated for removal of HeapConstants. Also changed to reset nextCell to 0 at the end of a block, since that seems more consistent.
- runtime/JSGlobalData.cpp: (JSC::JSGlobalData::storeVPtrs): Changed to use a fixed array of char. This hard-coded size is a little wonky, but the compiler will tell us if it's ever wrong, so I think it's OK.
- runtime/MarkedBlock.cpp: (JSC::MarkedBlock::destroy): (JSC::MarkedBlock::MarkedBlock): (JSC::MarkedBlock::sweep): Updated for removal of HeapConstants.
- runtime/MarkedBlock.h: (JSC::MarkedBlock::isEmpty): (JSC::MarkedBlock::clearMarks): (JSC::MarkedBlock::size): (JSC::MarkedBlock::capacity): Made constants private to this class. Removed HeapConstants. Added size() and capacity() functions.
- runtime/MarkedSpace.cpp: (JSC::MarkedSpace::allocate): (JSC::MarkedSpace::objectCount): (JSC::MarkedSpace::size): (JSC::MarkedSpace::capacity):
- runtime/MarkedSpace.h: Use MarkedBlock helper functions instead of direct knowledge of MarkedBlock internals.
- 21:14 Changeset [78311] by
-
2011-02-10 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Barth.
remove extra space from expansion lines
https://bugs.webkit.org/show_bug.cgi?id=54266
- code-review.js:
- 21:12 Changeset [78310] by
-
2011-02-09 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Barth.
only erase draft comments after publish is successful
https://bugs.webkit.org/show_bug.cgi?id=54163
If there is a conflict or 500, then draft comments will survive.
One drawback here is that the form post is now to the iframe,
so to break out of the iframe we redirect to the bug page, which
loses the information of who the email was sent to.
Once WebKit supports seamless iframes we should be able to avoid
the redirect.
- code-review.js:
- 21:07 Changeset [78309] by
-
2011-02-10 Zhenyao Mo <zmo@google.com>
Unreviewed, fix a typo.
- platform/chromium/test_expectations.txt:
- 20:41 Changeset [78308] by
-
2011-02-10 Zhenyao Mo <zmo@google.com>
Unreviewed, test expectations update.
- platform/chromium/test_expectations.txt:
- 20:24 Changeset [78307] by
-
2011-02-10 Zhenyao Mo <zmo@google.com>
Unreviewed, test expectation update.
- platform/chromium/test_expectations.txt:
- 20:19 Changeset [78306] by
-
2011-02-10 Zhenyao Mo <zmo@google.com>
Unreviewed, test expectations update.
- platform/chromium/test_expectations.txt:
- 19:55 Changeset [78305] by
-
2011-02-10 Zhenyao Mo <zmo@google.com>
Unreviewed, test expectations update.
- platform/chromium/test_expectations.txt:
- 19:32 Changeset [78304] by
-
2011-02-10 Zhenyao Mo <zmo@google.com>
Unreviewed, build fix.
- DumpRenderTree/DumpRenderTree.gypi:
- 19:23 Changeset [78303] by
-
2011-02-10 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
A little more encapsulation for MarkedBlock: Made mark bits private
https://bugs.webkit.org/show_bug.cgi?id=54264
SunSpider reports no change.
- runtime/Heap.cpp: (JSC::Heap::markRoots): (JSC::Heap::reset): Renamed clearMarkBits => clearMarks, since clients don't need to know that marks are represented as bits. Renamed markedCells => markCount, since clients don't need to know that blocks are split into cells.
- runtime/MarkedBlock.h: (JSC::MarkedBlock::isEmpty): (JSC::MarkedBlock::clearMarks): (JSC::MarkedBlock::markCount): New helper functions for encapsulating the information clients actually need.
- runtime/MarkedSpace.cpp: (JSC::MarkedSpace::destroy): (JSC::MarkedSpace::shrink): (JSC::MarkedSpace::clearMarks): (JSC::MarkedSpace::markCount): (JSC::MarkedSpace::objectCount):
- runtime/MarkedSpace.h: Use new helper functions instead of accessing MarkedBlock data directly.
- 19:18 Changeset [78302] by
-
2011-02-10 Dirk Pranke <dpranke@chromium.org>
Reviewed by Tony Chang.
This patch adds the bulk of the remaining functionality for
the NRWT message-passing implementation. The patch adds a new
Worker class that will eventually replace the TestShellThread
class in dump_render_tree_thread.py, and implements enough of
TestRunner2 and the inline version of the manager_worker_broker
to actually be able to send a full set of messages back and
forth. The Worker stubs do not actually run tests, and there's
lots of error handling and stats needed, but this is the core
logic.
- Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
- Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py:
- Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
- Scripts/webkitpy/layout_tests/layout_package/worker.py: Added.
- Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
- 19:04 Changeset [78301] by
-
Versioning.
- 19:03 Changeset [78300] by
-
New tag.
- 18:57 Changeset [78299] by
-
2011-02-10 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
Repro crash with Sony Google TV ad at Gizmodo
https://bugs.webkit.org/show_bug.cgi?id=54150
<rdar://problem/8782346>
Re-landing this fix, bug without the test case, since it causes hangs on the bots.
https://bugs.webkit.org/show_bug.cgi?id=54171 tracks adding back the test.
Since PluginView::evaluate can cause the plug-in element to go away, we need to protect it.
- WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::~PluginView): Null out m_pluginElement here so we'll catch crashes earlier.
(WebKit::PluginView::evaluate):
Add a plug-in protector.
- 18:24 Changeset [78298] by
-
2011-02-10 Zhenyao Mo <zmo@google.com>
Unreviewed, build fix.
- DumpRenderTree/DumpRenderTree.gypi:
- 18:10 Changeset [78297] by
-
2011-02-10 Michael Saboff <msaboff@apple.com>
Reviewed by Geoffrey Garen.
Cached JavaScript Parser Data Being Left in Memory Cache
https://bugs.webkit.org/show_bug.cgi?id=54245
Added clear method which removes SourceProviderCache items.
Cleaned up extraneous whitespace.
- JavaScriptCore.exp:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- parser/SourceProviderCache.cpp: (JSC::SourceProviderCache::~SourceProviderCache): (JSC::SourceProviderCache::clear): (JSC::SourceProviderCache::byteSize): (JSC::SourceProviderCache::add):
- parser/SourceProviderCache.h:
2011-02-10 Michael Saboff <msaboff@apple.com>
Reviewed by Geoffrey Garen.
Cached JavaScript Parser Data Being Left in Memory Cache
https://bugs.webkit.org/show_bug.cgi?id=54245
Added logic in CachedScript to clear SourceProviderCache data in
destroyDecodedData(). Added and changed CachedScript timeout to
act similar to CachedImage. Changed didAddClient to call super
class method instead of duplicating the logic in the derived
classes.
- loader/cache/CachedImage.cpp: (WebCore::CachedImage::didAddClient):
- loader/cache/CachedScript.cpp: (WebCore::CachedScript::didAddClient): (WebCore::CachedScript::allClientsRemoved): (WebCore::CachedScript::script): (WebCore::CachedScript::destroyDecodedData):
- loader/cache/CachedScript.h:
- 18:06 Changeset [78296] by
-
2011-02-10 Zhenyao Mo <zmo@google.com>
Unreviewed, build fix.
- DumpRenderTree/DumpRenderTree.gypi:
- 17:45 Changeset [78295] by
-
2011-02-10 Zhenyao Mo <zmo@google.com>
Unreviewed, attempt to fix crashing plugin tests.
- DumpRenderTree/DumpRenderTree.gypi:
- 17:26 Changeset [78294] by
-
2011-02-10 Zhenyao Mo <zmo@google.com>
Unreviewed, build fix.
- DumpRenderTree/DumpRenderTree.gypi:
- 17:23 Changeset [78293] by
-
Fix style in KURLGooglePrivate
https://bugs.webkit.org/show_bug.cgi?id=54228
Patch by Cosmin Truta <ctruta@chromium.org> on 2011-02-10
Reviewed by David Levin.
Replace occurrences of NULL with 0, '\0' or null (as applicable),
to appease check-webkit-style.
No new tests. This is a style fix.
- platform/KURLGoogle.cpp:
- platform/KURLGooglePrivate.h:
- 17:16 Changeset [78292] by
-
2011-02-10 Joseph Pecoraro <joepeck@webkit.org>
Follow-up fix to r78291. I should pass (int) 0, not '0' to memset.
- runtime/GCActivityCallbackCF.cpp: (JSC::DefaultGCActivityCallback::commonConstructor): fix mistaken post-review change.
- 17:09 Changeset [78291] by
-
2011-02-10 Joseph Pecoraro <joepeck@webkit.org>
Reviewed by Geoffrey Garen.
Make DefaultGCActivityCallback for PLATFORM(CF) Easier to Subclass
https://bugs.webkit.org/show_bug.cgi?id=54257
A subclass may want to specify the CFRunLoop that the Garbage Collection
will happen on. It was difficult to manipulate this in a subclass because
the current DefaultGCActivityCallback class does this in its constructor.
This patch generalizes things a bit more so that a specific run loop can
be passed in to the constructor. This makes it so all run loop management
can stay in DefaultGCActivityCallback and a subclass can specify any runloop.
- runtime/GCActivityCallback.h: expose a PLATFORM(CF) constructor that can specify the runloop GC can be scheduled on.
- runtime/GCActivityCallbackCF.cpp: (JSC::DefaultGCActivityCallback::DefaultGCActivityCallback): two constructors, one that specifies the run loop and passes that on to commonConstructor and the old constructor defaults to the current run loop. (JSC::DefaultGCActivityCallback::commonConstructor): do normal construction, adding the timer to the given runloop.
- 17:03 Changeset [78290] by
-
2011-02-10 Martin Robinson <mrobinson@igalia.com>
Generate GTK+ results for many SVG tests missing them.
- platform/gtk/Skipped: Unskip tests which now have results.
- 17:01 Changeset [78289] by
-
2011-02-10 Cosmin Truta <ctruta@chromium.org>
Reviewed by David Levin.
Fix style in KURLGooglePrivate
https://bugs.webkit.org/show_bug.cgi?id=54228
Replace occurrences of NULL with 0, '\0' or null (as applicable),
to appease check-webkit-style.
No new tests. This is a style fix.
- platform/KURLGoogle.cpp:
- platform/KURLGooglePrivate.h:
- 16:56 Changeset [78288] by
-
WebKit2 pages gobble up cmd-I as an editing command in some cases where it shouldn't
https://bugs.webkit.org/show_bug.cgi?id=54254
Reviewed by Enrica Casucci and Adele Peterson.
- UIProcess/API/mac/WKView.mm:
(-[WKView _handleStyleKeyEquivalent:]):
Return early if we're not in an editable region.
- 16:50 Changeset [78287] by
-
Try and fix some crashing tests on the chromium build bot.
- DumpRenderTree/DumpRenderTree.gypi:
- 16:45 Changeset [78286] by
-
2011-02-10 Andy Estes <aestes@apple.com>
Reviewed by Darin Adler.
HTML5 TreeBuilder regressed a Peacekeeper DOM test by 40%
https://bugs.webkit.org/show_bug.cgi?id=48719
The HTML5 fragment parsing algorithm specifies that a new Document
should be created to serve as the temporary parent of fragment nodes
during parsing. Document creation is expensive and accounts for ~38% of
the Peacekeeper DOM performance regression. Avoid the cost of creating
a dummy document by using the already-created DocumentFragment as the
root node during fragment parsing.
With this patch, the regression in Peacekeeper from Safari 5.0.3 to ToT
is ~24%.
Test: fast/parser/fragment-parser-doctype.html
- dom/ContainerNode.h: (WebCore::ContainerNode::firstElementChild): Add a method that returns the first element-typed child from a ContainerNode.
- dom/Document.cpp: (WebCore::Document::cacheDocumentElement): Call ContainerNode::firstElementChild() to retrieve and cache the document element.
- html/parser/HTMLConstructionSite.cpp: (WebCore::HTMLConstructionSite::HTMLConstructionSite): Initialize the root ContainerNode. (WebCore::HTMLConstructionSite::detach): Clear the reference to the root ContainerNode. (WebCore::HTMLConstructionSite::insertHTMLHtmlStartTagBeforeHTML): Attach the new element to the root ContainerNode. (WebCore::HTMLConstructionSite::insertDoctype): Ditto. (WebCore::HTMLConstructionSite::insertCommentOnDocument): Ditto.
- html/parser/HTMLConstructionSite.h: Store a pointer to a ContainerNode that will be used as the root node for document parsing. This node might or might not be the same as m_document.
- html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::HTMLTreeBuilder): Initialize the HTMLConstructionSite with the correct root ContainerNode based on whether or not we're parsing a fragment. (WebCore::HTMLTreeBuilder::FragmentParsingContext::FragmentParsingContext): Remove m_dummyDocumentForFragmentParsing. (WebCore::HTMLTreeBuilder::FragmentParsingContext::finished): If the fragment has a context element, store only the children of the root element (HTML5 Section 10.4, Step 7).
- html/parser/HTMLTreeBuilder.h:
2011-02-09 Andy Estes <aestes@apple.com>
Reviewed by Darin Adler.
HTML5 TreeBuilder regressed a Peacekeeper DOM test by 40%
https://bugs.webkit.org/show_bug.cgi?id=48719
- fast/parser/fragment-parser-doctype-expected.txt: Added.
- fast/parser/fragment-parser-doctype.html: Added.
- 16:32 Changeset [78285] by
-
Speculative fix for <rdar://problem/8985232> Overlay
scrollers can appear on the sliding page during
back/forward fluid gesture
Reviewed by Oliver Hunt.
- platform/mac/ScrollAnimatorMac.mm:
(-[ScrollbarPartAnimation scrollAnimatorDestroyed]):
- 16:20 Changeset [78284] by
-
2011-02-10 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
A little more encapsulation for MarkedBlock: Moved allocate() and sweep() into MarkedBlock
https://bugs.webkit.org/show_bug.cgi?id=54253
SunSpider reports no change.
- runtime/CollectorHeapIterator.h: Removed DeadObjectIterator, since it is now unused.
- runtime/Heap.cpp: (JSC::Heap::reset): Moved the call to shrink() here, since it seems a little more clear for MarkedSpace's client to tell it explicitly when to shrink.
- runtime/JSCell.h: (JSC::JSCell::MarkedBlock::allocate): Split out from MarkedSpace::allocate.
- runtime/MarkedBlock.cpp: (JSC::MarkedBlock::sweep): Split out from MarkedSpace::sweep, and converted to more directly iterate a MarkedBlock based on knowing its internal structure.
- runtime/MarkedBlock.h:
- runtime/MarkedSpace.cpp: (JSC::MarkedSpace::allocate): (JSC::MarkedSpace::sweep):
- runtime/MarkedSpace.h: Split out the code mentioned above.
- 16:14 Changeset [78283] by
-
2011-02-09 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Barth.
save overall comments when saving drafts in the review tool
https://bugs.webkit.org/show_bug.cgi?id=54165
-save overall comments in localstorage as well
-save all draft comments as you type
-give a *subtle* indicator of saved state
The latter should also make it super easy if someone wanted to do
the work to store draft comments in appengine/s3/bugzilla/etc.
- PrettyPatch/PrettyPatch.rb:
- code-review-test.html:
- code-review.js:
- 15:58 Changeset [78282] by
-
2011-02-10 Zhenyao Mo <zmo@google.com>
Unreviewed, test expectations update.
- platform/chromium/test_expectations.txt:
- 15:51 Changeset [78281] by
-
2011-02-10 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Log an error if a plug-in test can't be found
https://bugs.webkit.org/show_bug.cgi?id=54252
- DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp: (PluginTest::create): Return null if the test wasn't found.
- DumpRenderTree/TestNetscapePlugIn/main.cpp: (NPP_New): Report an error if PluginTest::create returns null.
- 15:49 Changeset [78280] by
-
2011-02-09 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Nate Chapin.
IndexedDB event targets need to ensure their wrappers aren't garbage collected
https://bugs.webkit.org/show_bug.cgi?id=54144
hasActivityPending should return true as long as it's possible that we'll
fire more event listeners on our event targets. It is still possible for
user generated events to run into problems, but I'm not sure how to address
that yet (or how big of a deal it is).
There's really no way to test this deterministically. Testing by hand makes
it seem like this patch works as expected though.
- storage/IDBCursorBackendImpl.cpp:
- storage/IDBDatabase.cpp: (WebCore::IDBDatabase::IDBDatabase): (WebCore::IDBDatabase::~IDBDatabase): (WebCore::IDBDatabase::hasPendingActivity): (WebCore::IDBDatabase::stop):
- storage/IDBDatabase.h:
- storage/IDBRequest.cpp: (WebCore::IDBRequest::IDBRequest): (WebCore::IDBRequest::hasPendingActivity): (WebCore::IDBRequest::dispatchEvent): (WebCore::IDBRequest::enqueueEvent):
- storage/IDBRequest.h:
- storage/IDBTransaction.cpp: (WebCore::IDBTransaction::finished): (WebCore::IDBTransaction::hasPendingActivity): (WebCore::IDBTransaction::dispatchEvent): (WebCore::IDBTransaction::canSuspend): (WebCore::IDBTransaction::contextDestroyed): (WebCore::IDBTransaction::enqueueEvent):
- storage/IDBTransaction.h:
- 15:29 Changeset [78279] by
-
2011-02-10 Martin Robinson <mrobinson@igalia.com>
Add results for HTTP tests missing GTK+ results.
- platform/gtk/Skipped: Unskip HTTP tests that now have results.
- 15:26 Changeset [78278] by
-
2011-02-10 Patrick Gansterer <paroga@webkit.org>
Reviewed by Andreas Kling.
Fix compilation error on OpenBSD
https://bugs.webkit.org/show_bug.cgi?id=53766
Add a HAVE_STRNSTR in Platform.h and define it only on Darwin and FreeBSD.
- wtf/Platform.h:
- wtf/StringExtras.h: Use HAVE(STRNSTR) now.
- 15:23 Changeset [78277] by
-
2011-02-10 Zhenyao Mo <zmo@google.com>
Unreviewed, tiny test fix from cira.
Excluding v8Locale from property-inheritance test
https://bugs.webkit.org/show_bug.cgi?id=54250
- fast/dom/script-tests/prototype-inheritance.js:
- 15:03 Changeset [78276] by
-
2011-02-10 Martin Robinson <mrobinson@igalia.com>
Unskip some GTK+ HTTP tests that are passing locally. All the bots
should have the same libsoup version now.
- platform/gtk/Skipped: Unskip some passing tests.
- 14:58 Changeset [78275] by
-
2011-02-10 Zhenyao Mo <zmo@google.com>
Unreviewed, test expectations update.
- platform/chromium/test_expectations.txt:
- 14:57 Changeset [78274] by
-
2011-02-10 Andreas Kling <kling@webkit.org>
Unreviewed Qt build fix.
waitFor() -> deprecatedWaitFor()
- UIProcess/TiledDrawingAreaProxy.cpp: (WebKit::TiledDrawingAreaProxy::waitUntilUpdatesComplete):
- 14:54 Changeset [78273] by
-
2011-02-10 Ademar de Souza Reis Jr <ademar.reis@openbossa.org>
Reviewed by Andreas Kling.
[Qt] create pkg-config files for mingw
https://bugs.webkit.org/show_bug.cgi?id=54238
(mingw is mostly the same as unix)
This change was applied in the Qt repository (qt/src/3rdparty/webkit),
so we should do the same here in QtWebKit.
Patch by Mark Brand <mabrand@mabrand.nl>, reviewed (there) by
Oswald Buddenhagen <oswald.buddenhagen@nokia.com>
45fe2dddc3a0677b9ec9fce09f07cd4129e37afa
- WebCore.pro:
- 14:52 Changeset [78272] by
-
2011-02-10 Andreas Kling <kling@webkit.org>
Reviewed by Antti Koivisto.
RenderStyle: Remove duplicate comparison of InheritedFlags::_text_transform
https://bugs.webkit.org/show_bug.cgi?id=54246
- rendering/style/RenderStyle.h:
- 14:45 Changeset [78271] by
-
2011-02-10 Dirk Schulze <krit@webkit.org>
Reviewed by Andreas Kling.
SVG animation avoid unnecessary adjust for currentColor
https://bugs.webkit.org/show_bug.cgi?id=54243
At the moment we try to adjust every animation value for currentColor - independent of the animation type.
Since the value is a string and the target element may needs to get called by getElementById, this could
be an expensive and unnecessary operation. Also after we adjust for currentColor, we save the result back
as a string and parse it to Color afterwards again.
With the patch we just adjust an animation value, if we use color animation. The color won't get saved and
parsed as a string again.
No change of functionality, no new tests.
- svg/SVGAnimateElement.cpp: (WebCore::adjustForCurrentColor): (WebCore::SVGAnimateElement::calculateFromAndToValues): (WebCore::SVGAnimateElement::calculateFromAndByValues):
- svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::currentValuesForValuesAnimation): (WebCore::SVGAnimationElement::startedActiveInterval):
- 14:32 Changeset [78270] by
-
2011-02-10 Ademar de Souza Reis Jr <ademar.reis@openbossa.org>
Reviewed by Andreas Kling.
[Qt] Ensure WebView press delay timer is cancelled when grab is taken
https://bugs.webkit.org/show_bug.cgi?id=54242
As reported in:
http://bugreports.qt.nokia.com/browse/QTBUG-15529
Flickable steals the grab, but the timer was not stopped and the
keepGrab flag is set and the mouse grabbed. This means that the WebView
now has the grab and subsequent clicks on another element are ignored.
Original patch from Martin Jones <martin.jones@nokia.com>
reviewed (there) by Joona Petrell
52068f57f9c32098a90cc217730a530f85590f65
- declarative/qdeclarativewebview.cpp: (GraphicsWebView::sceneEvent):
- declarative/qdeclarativewebview_p.h:
- 14:17 Changeset [78269] by
-
2011-02-10 Ademar de Souza Reis Jr <ademar.reis@openbossa.org>
Reviewed by Andreas Kling.
[Qt] Fix assert in QDeclarativeWebView
https://bugs.webkit.org/show_bug.cgi?id=54240
As reported in:
http://bugreports.qt.nokia.com/browse/QTBUG-14278
Instantiating a QDeclarativeWebView twice will trigger an assertion
when in debug mode.
Original patch from Thomas Hartmann <Thomas.Hartmann@nokia.com>,
reviewed (there) by Aaron Kennedy
f532679ca11914b453e22342f2ae5e9f790ce47a
- declarative/qdeclarativewebview.cpp: (QDeclarativeWebView::init):
- 14:15 Changeset [78268] by
-
2011-02-10 Ademar de Souza Reis Jr <ademar.reis@openbossa.org>
Reviewed by Andreas Kling.
[Qt] Remove the use of deprecated qFindChildren()
https://bugs.webkit.org/show_bug.cgi?id=54232
This was applied on the Qt repository and affects QtWebKit there.
(13833beb641289c45faed337848d37280195aadc)
The side effect of this change is that we won't be able to build
QtWebKit with MSVC 6, as it doesn't support member template functions
(not sure if that's possible today anyway).
Original patch from Olivier Goffart <olivier.goffart@nokia.com>, with
review reported as being from the mailing list.
The changes are result of the following commands:
git grep -O"sed -i 's/qF\(indChildr*e*n*<[>]*>\)(this,* */f
1(/'" qFindChild
git grep -O"sed -i 's/qF\(indChildr*e*n*<[>]*>\)(&\([\(),]*\),* */
2.f
1(/'" qFindChild
git grep -O"sed -i 's/qF\(indChildr*e*n*<[>]*>\)(\([\(),]*()\),* */
2->f
1(/'" qFindChild
git grep -O"sed -i 's/qF\(indChildr*e*n*<[>]*>\)(\([\(),]*\):\([\(),]*\),* */(
2:
3)->f
1(/'" qFindChild
git grep -O"sed -i 's/qF\(indChildr*e*n*<[>]*>\)(\([\(),]*\),* */
2->f
1(/'" qFindChild
- platform/graphics/qt/MediaPlayerPrivatePhonon.cpp: (WebCore::MediaPlayerPrivatePhonon::MediaPlayerPrivatePhonon):
- 14:03 Changeset [78267] by
-
Merge 77956
BUG=71717
Review URL: http://codereview.chromium.org/6486014
- 13:59 Changeset [78266] by
-
2011-02-10 Ademar de Souza Reis Jr <ademar.reis@openbossa.org>
Reviewed by Andreas Kling.
[Qt] Misc documentation fixes/updates
https://bugs.webkit.org/show_bug.cgi?id=54236
There are a few commits in the Qt repository (master and 4.7 branches)
with QtWebKit documentation fixes:
84d278501a19eaccf9a77cccd95ca5d17a2dcd2b
Clarified documentation of loadFinished() signal
eebe205b306daaa3674d9746de11a73bef4bd0de
Doc: Fixed QML, unindented snippet
b0d64717d2c541976dc5524e4100c62f060e206f
doc: Changed a table into 3 tables to eliminate a \raw.
As these are all minor doc changes, I decided to group them
into one single patch.
- Api/qwebpage.cpp:
- declarative/qdeclarativewebview.cpp:
- docs/qtwebkit.qdoc:
- 13:58 Changeset [78265] by
-
2011-02-10 Ademar de Souza Reis Jr <ademar.reis@openbossa.org>
Reviewed by Andreas Kling.
[Qt] Rename build target from "embedded" to "qpa"
https://bugs.webkit.org/show_bug.cgi?id=54233
This flag is used by Qt's configure script to enable a QPA build
("QPA is a window system agnostic implementation of Qt" --
previously known as lighthouse).
On the Qt repository, this was changed by two commits:
13a0b4935900093607f2b3b7688e1452d22770fd
(from embedded to embedded_lite)
9716e12e0f5590ebc23ad9fb7ba75c6a3c5aadab
(from embedded_lite to qpa)
- WebCore.pro:
- 13:49 Changeset [78264] by
-
2011-02-10 Kenneth Russell <kbr@google.com>
Reviewed by James Robinson.
Incorporate algorithm for processing paths into GPU-renderable triangle meshes
https://bugs.webkit.org/show_bug.cgi?id=45521
Adding an implementation of Loop and Blinn's GPU accelerated path
rendering algorithm from GPU Gems 3. This implementation pays
particular attention to the efficiency of the curve subdivision
phase needed for correct rendering. It utilizes the OpenGL utility
library tessellator for triangulation of the interior of the
shape. The regions handled by Loop and Blinn's algorithm are
handled by the local triangulator previously incorporated.
No tests yet; pixel tests will eventually be used to verify this
algorithm and prevent regressions.
- platform/graphics/gpu/LoopBlinnPathProcessor.cpp: Added. (WebCore::LoopBlinnPathProcessorImplementation::Segment::Segment): (WebCore::LoopBlinnPathProcessorImplementation::Segment::setup): (WebCore::LoopBlinnPathProcessorImplementation::Segment::kind): (WebCore::LoopBlinnPathProcessorImplementation::Segment::getPoint): (WebCore::LoopBlinnPathProcessorImplementation::Segment::next): (WebCore::LoopBlinnPathProcessorImplementation::Segment::prev): (WebCore::LoopBlinnPathProcessorImplementation::Segment::setNext): (WebCore::LoopBlinnPathProcessorImplementation::Segment::setPrev): (WebCore::LoopBlinnPathProcessorImplementation::Segment::contour): (WebCore::LoopBlinnPathProcessorImplementation::Segment::subdivide): (WebCore::LoopBlinnPathProcessorImplementation::Segment::boundingBox): (WebCore::LoopBlinnPathProcessorImplementation::Segment::numCrossingsForXRay): (WebCore::LoopBlinnPathProcessorImplementation::Segment::numberOfTriangles): (WebCore::LoopBlinnPathProcessorImplementation::Segment::getTriangle): (WebCore::LoopBlinnPathProcessorImplementation::Segment::numberOfInteriorVertices): (WebCore::LoopBlinnPathProcessorImplementation::Segment::getInteriorVertex): (WebCore::LoopBlinnPathProcessorImplementation::Segment::markedForSubdivision): (WebCore::LoopBlinnPathProcessorImplementation::Segment::setMarkedForSubdivision): (WebCore::LoopBlinnPathProcessorImplementation::Segment::toString): (WebCore::LoopBlinnPathProcessorImplementation::Segment::computeBoundingBox): (WebCore::LoopBlinnPathProcessorImplementation::Contour::Contour): (WebCore::LoopBlinnPathProcessorImplementation::Contour::add): (WebCore::LoopBlinnPathProcessorImplementation::Contour::subdivide): (WebCore::LoopBlinnPathProcessorImplementation::Contour::begin): (WebCore::LoopBlinnPathProcessorImplementation::Contour::end): (WebCore::LoopBlinnPathProcessorImplementation::Contour::isOrientedCounterClockwise): (WebCore::LoopBlinnPathProcessorImplementation::Contour::setIsOrientedCounterClockwise): (WebCore::LoopBlinnPathProcessorImplementation::Contour::boundingBox): (WebCore::LoopBlinnPathProcessorImplementation::Contour::fillSide): (WebCore::LoopBlinnPathProcessorImplementation::Contour::setFillSide): (WebCore::LoopBlinnPathProcessorImplementation::Segment::triangulate): (WebCore::LoopBlinnPathProcessor::LoopBlinnPathProcessor): (WebCore::LoopBlinnPathProcessor::~LoopBlinnPathProcessor): (WebCore::LoopBlinnPathProcessor::process): (WebCore::LoopBlinnPathProcessor::buildContours): (WebCore::LoopBlinnPathProcessor::allSegmentsOverlappingY): (WebCore::LoopBlinnPathProcessor::determineSidesToFill): (WebCore::LoopBlinnPathProcessor::determineOrientation): (WebCore::SweepData::SweepEvent::SweepEvent): (WebCore::SweepData::SweepEvent::setup): (WebCore::SweepData::SweepEvent::x): (WebCore::SweepData::SweepEvent::entry): (WebCore::SweepData::SweepEvent::interval): (WebCore::SweepData::SweepEvent::operator<): (WebCore::SweepData::trianglesOverlap): (WebCore::LoopBlinnPathProcessor::subdivideCurves): (WebCore::LoopBlinnPathProcessor::conditionallySubdivide): (WebCore::LoopBlinnPathProcessor::subdivideCurvesSlow): (WebCore::TessellationState::vertexCallback): (WebCore::TessellationState::combineCallback): (WebCore::TessellationState::edgeFlagCallback): (WebCore::LoopBlinnPathProcessor::tessellateInterior):
- platform/graphics/gpu/LoopBlinnPathProcessor.h: Added.
- 13:18 Changeset [78263] by
-
2011-02-10 Ademar de Souza Reis Jr <ademar.reis@openbossa.org>
Reviewed by Andreas Kling.
[Qt] Remove the use of deprecated qVariant*
https://bugs.webkit.org/show_bug.cgi?id=54229
This was applied on the Qt repository and affects QtWebKit there.
(633f3f45e5420663cf4ceadea79e62fea44cd2eb)
The side effect of this change is that we won't be able to build
QtWebKit with MSVC 6, as it doesn't support member template functions
(not sure if it's possible today anyway).
Original patch from Olivier Goffart <olivier.goffart@nokia.com>, with
review reported as being from the mailing list.
The changes are result of the following commands:
git grep -O"sed -i 's/qVariantValue</qvariant_cast</'" qVariantValue
git grep -O"sed -i 's/qVariantSetValue(\([&*\(),]*\), */
1.setValue(/'" qVariantSetValue
git grep -O"sed -i 's/qVariantSetValue *<\([>]*\)> *(\([&*\(),]*\), */
2.setValue<
1>(/'" qVariantSetValue
git grep -O"sed -i 's/qVariantCanConvert *<\([>]*\)> *(\([&*\(),]*\))/
2.canConvert<
1>()/g'" qVariantCanConvert
git grep -O"sed -i 's/qVariantCanConvert *<\([>]*\)> *(\([&*\(),]*([&*\(),]*)\))/
2.canConvert<
1>()/g'" qVariantCanConvert
git grep -O"sed -i 's/qVariantFromValue\( *[(<]\)/QVariant::fromValue
1/'" qVariantFromValue
- bridge/qt/qt_runtime.cpp: (JSC::Bindings::convertValueToQVariant):
- platform/graphics/qt/MediaPlayerPrivateQt.cpp: (WebCore::MediaPlayerPrivateQt::commitLoad):
2011-02-10 Ademar de Souza Reis Jr <ademar.reis@openbossa.org>
Reviewed by Andreas Kling.
[Qt] Remove the use of deprecated qVariant*
https://bugs.webkit.org/show_bug.cgi?id=54229
This was applied on the Qt repository and affects QtWebKit there.
(633f3f45e5420663cf4ceadea79e62fea44cd2eb)
The side effect of this change is that we won't be able to build
QtWebKit with MSVC 6, as it doesn't support member template functions
(not sure if it's possible today anyway).
Original patch from Olivier Goffart <olivier.goffart@nokia.com>, with
review reported as being from the mailing list.
The changes are result of the following commands:
git grep -O"sed -i 's/qVariantValue</qvariant_cast</'" qVariantValue
git grep -O"sed -i 's/qVariantSetValue(\([&*\(),]*\), */
1.setValue(/'" qVariantSetValue
git grep -O"sed -i 's/qVariantSetValue *<\([>]*\)> *(\([&*\(),]*\), */
2.setValue<
1>(/'" qVariantSetValue
git grep -O"sed -i 's/qVariantCanConvert *<\([>]*\)> *(\([&*\(),]*\))/
2.canConvert<
1>()/g'" qVariantCanConvert
git grep -O"sed -i 's/qVariantCanConvert *<\([>]*\)> *(\([&*\(),]*([&*\(),]*)\))/
2.canConvert<
1>()/g'" qVariantCanConvert
git grep -O"sed -i 's/qVariantFromValue\( *[(<]\)/QVariant::fromValue
1/'" qVariantFromValue
- WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::nodesFromRect):
- tests/qwebframe/tst_qwebframe.cpp: (MyQObject::myInvokableWithQObjectListArg): (MyQObject::myInvokableWithListOfIntArg): (MyQObject::myInvokableWithQObjectStarArg): (MyQObject::myInvokableWithQBrushArg): (MyQObject::myInvokableWithBrushStyleArg): (MyQObject::myInvokableWithVoidStarArg): (MyQObject::myInvokableWithAmbiguousArg): (MyQObject::myInvokableWithDefaultArgs): (MyQObject::myInvokableWithPointArg): (MyQObject::myOverloadedSlot):
- 13:10 Changeset [78262] by
-
2011-02-10 Zhenyao Mo <zmo@google.com>
Unreviewed, rebaseline.
- platform/chromium-mac/fast/text/international/text-combine-image-test-expected.checksum: Removed.
- platform/chromium-mac/fast/text/international/text-combine-image-test-expected.png: Removed.
- platform/mac-leopard/fast/text/international/text-combine-image-test-expected.checksum: Added.
- platform/mac-leopard/fast/text/international/text-combine-image-test-expected.png: Added.
- 13:04 Changeset [78261] by
-
2011-02-10 Nico Weber <thakis@chromium.org>
Reviewed by Darin Adler.
Fix clang warning "WebCore::HTMLAreaElement::getRect' hides overloaded virtual function [-Woverloaded-virtual]"
https://bugs.webkit.org/show_bug.cgi?id=54221
The method name conflicts with ContainerNode::getRect() so rename it to
computeRect(). Rename getPath() to computePath() for consistency as
well.
No intended functionality change, covered by existing tests.
- accessibility/AccessibilityImageMapLink.cpp: (WebCore::AccessibilityImageMapLink::elementRect):
- html/HTMLAreaElement.cpp: (WebCore::HTMLAreaElement::computePath): (WebCore::HTMLAreaElement::computeRect):
- html/HTMLAreaElement.h:
- page/SpatialNavigation.cpp: (WebCore::virtualRectForAreaElementAndDirection):
- rendering/RenderImage.cpp: (WebCore::RenderImage::paintFocusRing):
- 13:04 Changeset [78260] by
-
2011-02-10 Anders Carlsson <andersca@apple.com>
Reviewed by Adam Roben.
Move code to dispatch an incoming message out into a new function
https://bugs.webkit.org/show_bug.cgi?id=54239
This also fixes a leak where we wouldn't free ArgumentDecoder objects
after a connection has been invalidated.
- Platform/CoreIPC/Connection.cpp: (CoreIPC::Connection::dispatchMessage): (CoreIPC::Connection::dispatchMessages):
- Platform/CoreIPC/Connection.h:
- 12:44 Changeset [78259] by
-
2011-02-10 Alexis Menard <alexis.menard@nokia.com>
Reviewed by Andreas Kling.
[Qt] Default focus ring is too wide
https://bugs.webkit.org/show_bug.cgi?id=51854
We now respect the outline property and html.css defines the outline of the focus
ring to be 5px. This is propagated until GraphicsContext::drawFocusRing which uses
it as the pen size. We should ignore the size and keep a default one. I also
reverted the SolidLine to DotLine so that the selection looks nicer. Chromium Skia,
CG Win, Haiku, WinCE ports also ignore the width.
- platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::drawFocusRingForPath): (WebCore::GraphicsContext::drawFocusRing):
- 12:36 Changeset [78258] by
-
2011-02-10 Maciej Stachowiak <mjs@apple.com>
Reviewed by Anders Carlsson.
Skip newly added tests that use eventSender
https://bugs.webkit.org/show_bug.cgi?id=54235
- platform/mac-wk2/Skipped:
- 12:26 Changeset [78257] by
-
2011-02-10 Martin Robinson <mrobinson@igalia.com>
Reviewed by Gustavo Noronha Silva.
[Soup] ResourceHandleSoup does not ever call didSendData for file uploads
https://bugs.webkit.org/show_bug.cgi?id=52090
- platform/gtk/Skipped: Unskip tests which should now be passing.
2011-02-10 Martin Robinson <mrobinson@igalia.com>
Reviewed by Gustavo Noronha Silva.
[Soup] ResourceHandleSoup does not ever call didSendData for file uploads
https://bugs.webkit.org/show_bug.cgi?id=52090
Call didSendData as body data is uploaded to the server. This is necessary
for XHR upload events to function properly.
- platform/network/ResourceHandleInternal.h: (WebCore::ResourceHandleInternal::ResourceHandleInternal): Add two new members. One to track the total amount of body data and one to track the total amount of body data sent so far.
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::wroteBodyDataCallback): Added. (WebCore::addFormElementsToSoupMessage): Split this out into a helper function. Will now now sum the total amount of body data. (WebCore::startHttp): Attach a wrote-body-data signal handler.
- 12:18 Changeset [78256] by
-
2011-02-10 Robert Hogan <robert@webkit.org>
Reviewed by Laszlo Gombos.
[Qt] Return menu items from eventSender.contextMenu()
https://bugs.webkit.org/show_bug.cgi?id=53039
- platform/qt/Skipped: unskip editing/selection/context-menu-on-text.html
2011-02-10 Robert Hogan <robert@webkit.org>
Reviewed by Laszlo Gombos.
[Qt] Return menu items from eventSender.contextMenu()
https://bugs.webkit.org/show_bug.cgi?id=53039
- WebCoreSupport/DumpRenderTreeSupportQt.cpp: (iterateContextMenu): (DumpRenderTreeSupportQt::contextMenu):
- WebCoreSupport/DumpRenderTreeSupportQt.h:
2011-02-10 Robert Hogan <robert@webkit.org>
Reviewed by Laszlo Gombos.
[Qt] Return menu items from eventSender.contextMenu()
https://bugs.webkit.org/show_bug.cgi?id=53039
- DumpRenderTree/qt/EventSenderQt.cpp: (EventSender::contextClick):
- DumpRenderTree/qt/EventSenderQt.h:
- 12:12 Changeset [78255] by
-
Try again to fix the Qt build.
- UIProcess/TiledDrawingAreaProxy.cpp:
(WebKit::TiledDrawingAreaProxy::sizeDidChange):
(WebKit::TiledDrawingAreaProxy::setPageIsVisible):
(WebKit::TiledDrawingAreaProxy::takeSnapshot):
(WebKit::TiledDrawingAreaProxy::removeTile):
- 11:58 Changeset [78254] by
-
2011-02-10 Zhenyao Mo <zmo@google.com>
Unreviewed, rebaseline.
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-light-04-f-expected.checksum:
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-light-04-f-expected.png:
- platform/chromium-linux/svg/transforms/animated-path-inside-transformed-html-expected.checksum:
- platform/chromium-linux/svg/transforms/animated-path-inside-transformed-html-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-light-04-f-expected.checksum:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-light-04-f-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-light-04-f-expected.txt:
- platform/chromium-win/svg/transforms/animated-path-inside-transformed-html-expected.checksum:
- platform/chromium-win/svg/transforms/animated-path-inside-transformed-html-expected.png:
- 11:50 Changeset [78253] by
-
2011-02-10 Bill Budge <bbudge@chromium.org>
Reviewed by David Levin.
Add fields to ResourceRequest and ResourceResponse in preparation for adding CORS support to AssociatedURLLoader.
https://bugs.webkit.org/show_bug.cgi?id=53925
- platform/network/chromium/ResourceRequest.cpp: (WebCore::ResourceRequest::doPlatformCopyData): (WebCore::ResourceRequest::doPlatformAdopt):
- platform/network/chromium/ResourceRequest.h: (WebCore::ResourceRequest::ResourceRequest): (WebCore::ResourceRequest::downloadToFile): (WebCore::ResourceRequest::setDownloadToFile):
- platform/network/chromium/ResourceResponse.cpp: (WebCore::ResourceResponse::doPlatformCopyData): (WebCore::ResourceResponse::doPlatformAdopt):
- platform/network/chromium/ResourceResponse.h: (WebCore::ResourceResponse::downloadFilePath): (WebCore::ResourceResponse::setDownloadFilePath):
- 11:37 Changeset [78252] by
-
Attempt to fix the Qt build.
- UIProcess/TiledDrawingAreaProxy.cpp:
(WebKit::TiledDrawingAreaProxy::sizeDidChange):
(WebKit::TiledDrawingAreaProxy::setPageIsVisible):
(WebKit::TiledDrawingAreaProxy::requestTileUpdate):
(WebKit::TiledDrawingAreaProxy::takeSnapshot):
(WebKit::TiledDrawingAreaProxy::removeTile):
- WebProcess/WebPage/TiledDrawingArea.cpp:
(WebKit::TiledDrawingArea::display):
(WebKit::TiledDrawingArea::setSize):
(WebKit::TiledDrawingArea::updateTile):
(WebKit::TiledDrawingArea::tileUpdateTimerFired):
(WebKit::TiledDrawingArea::didReceiveMessage):
- 11:28 UsingGitWithWebKit edited by
- (diff)
- 11:27 UsingGitWithWebKit edited by
- (diff)
- 11:26 Changeset [78251] by
-
Handle a null FindIndicator correctly
We are passed a null FindIndicator when the find indicator becomes hidden.
Fixes <http://webkit.org/b/54213> <rdar://problem/8983261> REGRESSION (r78198): Crash in
FindIndicator::contentImage when scrolling page
Reviewed by Steve Falkenburg.
Source/WebKit2:
- Platform/win/SharedMemoryWin.cpp:
(WebKit::SharedMemory::Handle::isNull): Implemented.
(WebKit::SharedMemory::create): Bail out if the handle is null, just like Mac does.
Otherwise assert that ::MapViewOfFile succeeded. This doesn't fix the bug, but should help
catch other errors.
- UIProcess/win/WebView.cpp:
(WebKit::WebView::setFindIndicator): Null-check the FindIndicator before dereferencing it.
Also changed the function to store the FindIndicator in a RefPtr.
Tools:
Test showing and hiding the find indicator on Windows
- TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp: Added.
(TestWebKitAPI::didFinishLoadForFrame): Record that the load finished.
(TestWebKitAPI::findIndicatorCallback): Record that the callback was called, and save the
bitmap.
(TestWebKitAPI::initialize): Hook up our callbacks.
(TestWebKitAPI::TEST): Test showing then hiding the find indicator to see if we crash.
- TestWebKitAPI/PlatformWebView.h:
- TestWebKitAPI/mac/PlatformWebViewMac.mm:
(TestWebKitAPI::PlatformWebView::page):
- TestWebKitAPI/win/PlatformWebViewWin.cpp:
(TestWebKitAPI::PlatformWebView::page):
Made page a const member function.
- TestWebKitAPI/win/TestWebKitAPI.vcproj: Added the new test.
- 11:25 Changeset [78250] by
-
Print locations of assertions and logs in a way that Visual Studio understands
With this change, double-clicking one of these locations in Visual Studio's Output Window
will focus that line of code in the editor.
Fixes <http://webkit.org/b/54208> Double-clicking locations of assertions/logs in Visual
Studio's Output Window does nothing
Reviewed by Alexey Proskuryakov.
- wtf/Assertions.cpp:
(printCallSite): Use OS(WINDOWS) instead of the meaningless OS(WIN). When we aren't using
the debug CRT (and thus can't call _CrtDbgReport), print the file and line number using the
same format that cl.exe uses when it prints compiler errors.
- 11:16 Changeset [78249] by
-
2011-02-10 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
SVGAnimateElement needs information about the animated attribute type
https://bugs.webkit.org/show_bug.cgi?id=53442
For animations, we need to know the SVG property type for a XML attribute. A global static mapping between
attribute name and a type is not possible, since one attribute name can be bound to different property types:
x can be a SVGNumberList, a SVGNumber or a SVGLength. So we have to ask every target element, if it supports
the animated attribute and of which type it is. Just for CSS properties we can share an explicit mapping between
the name and the type. This is done in a static map in SVGStyledElement. All other mappings are stored in local static
HashMaps for all SVG elements with animated properties. These maps get filled once with the fillAttributeToPropertyTypeMap function
that needs to be included in every SVG element. The function is not virtual in base classes for performance reasons.
No change of functionality, so no new test cases.
- svg/SVGAElement.cpp: (WebCore::SVGAElement::attributeToPropertyTypeMap): (WebCore::SVGAElement::fillAttributeToPropertyTypeMap):
- svg/SVGAElement.h:
- svg/SVGAltGlyphElement.cpp: (WebCore::SVGAltGlyphElement::attributeToPropertyTypeMap): (WebCore::SVGAltGlyphElement::fillAttributeToPropertyTypeMap):
- svg/SVGAltGlyphElement.h:
- svg/SVGAnimateElement.cpp: (WebCore::SVGAnimateElement::determinePropertyType):
- svg/SVGCircleElement.cpp: (WebCore::SVGCircleElement::attributeToPropertyTypeMap): (WebCore::SVGCircleElement::fillAttributeToPropertyTypeMap):
- svg/SVGCircleElement.h:
- svg/SVGClipPathElement.cpp: (WebCore::SVGClipPathElement::attributeToPropertyTypeMap): (WebCore::SVGClipPathElement::fillAttributeToPropertyTypeMap):
- svg/SVGClipPathElement.h:
- svg/SVGComponentTransferFunctionElement.cpp: (WebCore::SVGComponentTransferFunctionElement::attributeToPropertyTypeMap): (WebCore::SVGComponentTransferFunctionElement::fillAttributeToPropertyTypeMap):
- svg/SVGComponentTransferFunctionElement.h:
- svg/SVGCursorElement.cpp: (WebCore::SVGCursorElement::attributeToPropertyTypeMap): (WebCore::SVGCursorElement::fillAttributeToPropertyTypeMap):
- svg/SVGCursorElement.h:
- svg/SVGElement.cpp: (WebCore::SVGElement::attributeToPropertyTypeMap): (WebCore::SVGElement::animatedPropertyTypeForAttribute):
- svg/SVGElement.h: (WebCore::SVGElement::fillAttributeToPropertyTypeMap):
- svg/SVGEllipseElement.cpp: (WebCore::SVGEllipseElement::attributeToPropertyTypeMap): (WebCore::SVGEllipseElement::fillAttributeToPropertyTypeMap):
- svg/SVGEllipseElement.h:
- svg/SVGFEBlendElement.cpp: (WebCore::SVGFEBlendElement::attributeToPropertyTypeMap): (WebCore::SVGFEBlendElement::fillAttributeToPropertyTypeMap):
- svg/SVGFEBlendElement.h:
- svg/SVGFEColorMatrixElement.cpp: (WebCore::SVGFEColorMatrixElement::attributeToPropertyTypeMap): (WebCore::SVGFEColorMatrixElement::fillAttributeToPropertyTypeMap):
- svg/SVGFEColorMatrixElement.h:
- svg/SVGFEComponentTransferElement.cpp: (WebCore::SVGFEComponentTransferElement::attributeToPropertyTypeMap): (WebCore::SVGFEComponentTransferElement::fillAttributeToPropertyTypeMap):
- svg/SVGFEComponentTransferElement.h:
- svg/SVGFECompositeElement.cpp: (WebCore::SVGFECompositeElement::attributeToPropertyTypeMap): (WebCore::SVGFECompositeElement::fillAttributeToPropertyTypeMap):
- svg/SVGFECompositeElement.h:
- svg/SVGFEConvolveMatrixElement.cpp: (WebCore::SVGFEConvolveMatrixElement::attributeToPropertyTypeMap): (WebCore::SVGFEConvolveMatrixElement::fillAttributeToPropertyTypeMap):
- svg/SVGFEConvolveMatrixElement.h:
- svg/SVGFEDiffuseLightingElement.cpp: (WebCore::SVGFEDiffuseLightingElement::attributeToPropertyTypeMap): (WebCore::SVGFEDiffuseLightingElement::fillAttributeToPropertyTypeMap):
- svg/SVGFEDiffuseLightingElement.h:
- svg/SVGFEDisplacementMapElement.cpp: (WebCore::SVGFEDisplacementMapElement::attributeToPropertyTypeMap): (WebCore::SVGFEDisplacementMapElement::fillAttributeToPropertyTypeMap):
- svg/SVGFEDisplacementMapElement.h:
- svg/SVGFEFloodElement.cpp: (WebCore::SVGFEFloodElement::attributeToPropertyTypeMap): (WebCore::SVGFEFloodElement::fillAttributeToPropertyTypeMap):
- svg/SVGFEFloodElement.h:
- svg/SVGFEGaussianBlurElement.cpp: (WebCore::SVGFEGaussianBlurElement::attributeToPropertyTypeMap): (WebCore::SVGFEGaussianBlurElement::fillAttributeToPropertyTypeMap):
- svg/SVGFEGaussianBlurElement.h:
- svg/SVGFEImageElement.cpp: (WebCore::SVGFEImageElement::attributeToPropertyTypeMap): (WebCore::SVGFEImageElement::fillAttributeToPropertyTypeMap):
- svg/SVGFEImageElement.h:
- svg/SVGFELightElement.cpp: (WebCore::SVGFELightElement::attributeToPropertyTypeMap): (WebCore::SVGFELightElement::fillAttributeToPropertyTypeMap):
- svg/SVGFELightElement.h:
- svg/SVGFEMergeElement.cpp: (WebCore::SVGFEMergeElement::attributeToPropertyTypeMap): (WebCore::SVGFEMergeElement::fillAttributeToPropertyTypeMap):
- svg/SVGFEMergeElement.h:
- svg/SVGFEMergeNodeElement.cpp: (WebCore::SVGFEMergeNodeElement::attributeToPropertyTypeMap): (WebCore::SVGFEMergeNodeElement::fillAttributeToPropertyTypeMap):
- svg/SVGFEMergeNodeElement.h:
- svg/SVGFEMorphologyElement.cpp: (WebCore::SVGFEMorphologyElement::attributeToPropertyTypeMap): (WebCore::SVGFEMorphologyElement::fillAttributeToPropertyTypeMap):
- svg/SVGFEMorphologyElement.h:
- svg/SVGFEOffsetElement.cpp: (WebCore::SVGFEOffsetElement::attributeToPropertyTypeMap): (WebCore::SVGFEOffsetElement::fillAttributeToPropertyTypeMap):
- svg/SVGFEOffsetElement.h:
- svg/SVGFESpecularLightingElement.cpp: (WebCore::SVGFESpecularLightingElement::attributeToPropertyTypeMap): (WebCore::SVGFESpecularLightingElement::fillAttributeToPropertyTypeMap):
- svg/SVGFESpecularLightingElement.h:
- svg/SVGFETileElement.cpp: (WebCore::SVGFETileElement::attributeToPropertyTypeMap): (WebCore::SVGFETileElement::fillAttributeToPropertyTypeMap):
- svg/SVGFETileElement.h:
- svg/SVGFETurbulenceElement.cpp: (WebCore::SVGFETurbulenceElement::attributeToPropertyTypeMap): (WebCore::SVGFETurbulenceElement::fillAttributeToPropertyTypeMap):
- svg/SVGFETurbulenceElement.h:
- svg/SVGFilterElement.cpp: (WebCore::SVGFilterElement::attributeToPropertyTypeMap): (WebCore::SVGFilterElement::fillAttributeToPropertyTypeMap):
- svg/SVGFilterElement.h:
- svg/SVGFilterPrimitiveStandardAttributes.cpp: (WebCore::SVGFilterPrimitiveStandardAttributes::fillAttributeToPropertyTypeMap):
- svg/SVGFilterPrimitiveStandardAttributes.h:
- svg/SVGFontElement.cpp: (WebCore::SVGFontElement::attributeToPropertyTypeMap): (WebCore::SVGFontElement::fillAttributeToPropertyTypeMap):
- svg/SVGFontElement.h: (WebCore::SVGFontElement::rendererIsNeeded):
- svg/SVGForeignObjectElement.cpp: (WebCore::SVGForeignObjectElement::attributeToPropertyTypeMap): (WebCore::SVGForeignObjectElement::fillAttributeToPropertyTypeMap):
- svg/SVGForeignObjectElement.h:
- svg/SVGGlyphElement.cpp: (WebCore::SVGGlyphElement::attributeToPropertyTypeMap): (WebCore::SVGGlyphElement::fillAttributeToPropertyTypeMap):
- svg/SVGGlyphElement.h:
- svg/SVGGradientElement.cpp: (WebCore::SVGGradientElement::fillAttributeToPropertyTypeMap):
- svg/SVGGradientElement.h:
- svg/SVGImageElement.cpp: (WebCore::SVGImageElement::attributeToPropertyTypeMap): (WebCore::SVGImageElement::fillAttributeToPropertyTypeMap):
- svg/SVGImageElement.h:
- svg/SVGLineElement.cpp: (WebCore::SVGLineElement::attributeToPropertyTypeMap): (WebCore::SVGLineElement::fillAttributeToPropertyTypeMap):
- svg/SVGLineElement.h:
- svg/SVGLinearGradientElement.cpp: (WebCore::SVGLinearGradientElement::attributeToPropertyTypeMap): (WebCore::SVGLinearGradientElement::fillAttributeToPropertyTypeMap):
- svg/SVGLinearGradientElement.h:
- svg/SVGMPathElement.cpp: (WebCore::SVGMPathElement::attributeToPropertyTypeMap): (WebCore::SVGMPathElement::fillAttributeToPropertyTypeMap):
- svg/SVGMPathElement.h:
- svg/SVGMarkerElement.cpp: (WebCore::SVGMarkerElement::attributeToPropertyTypeMap): (WebCore::SVGMarkerElement::fillAttributeToPropertyTypeMap):
- svg/SVGMarkerElement.h:
- svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::attributeToPropertyTypeMap): (WebCore::SVGMaskElement::fillAttributeToPropertyTypeMap):
- svg/SVGMaskElement.h:
- svg/SVGMissingGlyphElement.cpp: (WebCore::SVGMissingGlyphElement::attributeToPropertyTypeMap): (WebCore::SVGMissingGlyphElement::fillAttributeToPropertyTypeMap):
- svg/SVGMissingGlyphElement.h:
- svg/SVGPathElement.cpp: (WebCore::SVGPathElement::attributeToPropertyTypeMap): (WebCore::SVGPathElement::fillAttributeToPropertyTypeMap):
- svg/SVGPathElement.h:
- svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::attributeToPropertyTypeMap): (WebCore::SVGPatternElement::fillAttributeToPropertyTypeMap):
- svg/SVGPatternElement.h:
- svg/SVGPolyElement.cpp: (WebCore::SVGPolyElement::attributeToPropertyTypeMap): (WebCore::SVGPolyElement::fillAttributeToPropertyTypeMap):
- svg/SVGPolyElement.h:
- svg/SVGRadialGradientElement.cpp: (WebCore::SVGRadialGradientElement::attributeToPropertyTypeMap): (WebCore::SVGRadialGradientElement::fillAttributeToPropertyTypeMap):
- svg/SVGRadialGradientElement.h:
- svg/SVGRectElement.cpp: (WebCore::SVGRectElement::attributeToPropertyTypeMap): (WebCore::SVGRectElement::fillAttributeToPropertyTypeMap):
- svg/SVGRectElement.h:
- svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::attributeToPropertyTypeMap): (WebCore::SVGSVGElement::fillAttributeToPropertyTypeMap):
- svg/SVGSVGElement.h:
- svg/SVGScriptElement.cpp: (WebCore::SVGScriptElement::attributeToPropertyTypeMap): (WebCore::SVGScriptElement::fillAttributeToPropertyTypeMap):
- svg/SVGScriptElement.h:
- svg/SVGStopElement.cpp: (WebCore::SVGStopElement::attributeToPropertyTypeMap): (WebCore::SVGStopElement::fillAttributeToPropertyTypeMap):
- svg/SVGStopElement.h:
- svg/SVGStyledElement.cpp: (WebCore::cssPropertyToTypeMap): (WebCore::SVGStyledElement::animatedPropertyTypeForCSSProperty): (WebCore::SVGStyledElement::fillAttributeToPropertyTypeMap):
- svg/SVGStyledElement.h:
- svg/SVGStyledTransformableElement.cpp: (WebCore::SVGStyledTransformableElement::fillAttributeToPropertyTypeMap):
- svg/SVGStyledTransformableElement.h:
- svg/SVGSwitchElement.cpp: (WebCore::SVGSwitchElement::attributeToPropertyTypeMap): (WebCore::SVGSwitchElement::fillAttributeToPropertyTypeMap):
- svg/SVGSwitchElement.h:
- svg/SVGSymbolElement.cpp: (WebCore::SVGSymbolElement::attributeToPropertyTypeMap): (WebCore::SVGSymbolElement::fillAttributeToPropertyTypeMap):
- svg/SVGSymbolElement.h:
- svg/SVGTRefElement.cpp: (WebCore::SVGTRefElement::attributeToPropertyTypeMap): (WebCore::SVGTRefElement::fillAttributeToPropertyTypeMap):
- svg/SVGTRefElement.h:
- svg/SVGTSpanElement.cpp: (WebCore::SVGTSpanElement::attributeToPropertyTypeMap): (WebCore::SVGTSpanElement::fillAttributeToPropertyTypeMap):
- svg/SVGTSpanElement.h:
- svg/SVGTextContentElement.cpp: (WebCore::SVGTextContentElement::fillAttributeToPropertyTypeMap):
- svg/SVGTextContentElement.h:
- svg/SVGTextElement.cpp: (WebCore::SVGTextElement::attributeToPropertyTypeMap): (WebCore::SVGTextElement::fillAttributeToPropertyTypeMap):
- svg/SVGTextElement.h:
- svg/SVGTextPathElement.cpp: (WebCore::SVGTextPathElement::attributeToPropertyTypeMap): (WebCore::SVGTextPathElement::fillAttributeToPropertyTypeMap):
- svg/SVGTextPathElement.h:
- svg/SVGTextPositioningElement.cpp: (WebCore::SVGTextPositioningElement::fillAttributeToPropertyTypeMap):
- svg/SVGTextPositioningElement.h:
- svg/SVGTitleElement.cpp: (WebCore::SVGTitleElement::attributeToPropertyTypeMap): (WebCore::SVGTitleElement::fillAttributeToPropertyTypeMap):
- svg/SVGTitleElement.h:
- svg/SVGUseElement.cpp: (WebCore::SVGUseElement::attributeToPropertyTypeMap): (WebCore::SVGUseElement::fillAttributeToPropertyTypeMap):
- svg/SVGUseElement.h:
- svg/SVGViewElement.cpp: (WebCore::SVGViewElement::attributeToPropertyTypeMap): (WebCore::SVGViewElement::fillAttributeToPropertyTypeMap):
- svg/SVGViewElement.h:
- 11:05 Changeset [78248] by
-
2011-02-10 Alexis Menard <alexis.menard@nokia.com>
Reviewed by Andreas Kling.
Fix a Warning after removing FileSystem support for the inspector.
- WebCore.pro:
- 10:55 Changeset [78247] by
-
2011-02-10 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Add 'deprecated' to the deprecated CoreIPC functions
https://bugs.webkit.org/show_bug.cgi?id=54223
- Platform/CoreIPC/Connection.cpp: (CoreIPC::Connection::sendMessage):
- Platform/CoreIPC/Connection.h: (CoreIPC::Connection::send): (CoreIPC::Connection::deprecatedSendSync): (CoreIPC::Connection::deprecatedSend): (CoreIPC::Connection::deprecatedWaitFor):
- Platform/CoreIPC/mac/ConnectionMac.cpp: (CoreIPC::Connection::open):
- PluginProcess/PluginProcess.cpp:
- UIProcess/ChunkedUpdateDrawingAreaProxy.cpp: (WebKit::ChunkedUpdateDrawingAreaProxy::paint):
- UIProcess/Plugins/PluginProcessProxy.cpp: (WebKit::PluginProcessProxy::createWebProcessConnection):
- WebProcess/InjectedBundle/InjectedBundle.cpp: (WebKit::InjectedBundle::postMessage): (WebKit::InjectedBundle::postSynchronousMessage):
- WebProcess/Plugins/PluginProcessConnectionManager.cpp: (WebKit::PluginProcessConnectionManager::getPluginProcessConnection):
- WebProcess/WebPage/ChunkedUpdateDrawingArea.cpp: (WebKit::ChunkedUpdateDrawingArea::display): (WebKit::ChunkedUpdateDrawingArea::setSize):
- WebProcess/WebPage/LayerBackedDrawingArea.cpp: (WebKit::LayerBackedDrawingArea::setSize):
- WebProcess/WebPage/mac/LayerBackedDrawingAreaMac.mm: (WebKit::LayerBackedDrawingArea::attachCompositingContext):
- 10:50 Changeset [78246] by
-
2011-02-10 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Window resizer does not have a border when there are scrollbars in WebKit2 windows
<rdar://problem/8488476>
https://bugs.webkit.org/show_bug.cgi?id=54222
- UIProcess/API/mac/PageClientImpl.h:
- UIProcess/API/mac/PageClientImpl.mm: (WebKit::PageClientImpl::didChangeScrollbarsForMainFrame):
- UIProcess/API/mac/WKView.mm: (-[WKView _updateGrowBoxForWindowFrameChange]): (-[WKView _didChangeScrollbarsForMainFrame]):
- UIProcess/API/mac/WKViewInternal.h:
- UIProcess/API/qt/qwkpage_p.h: (QWKPagePrivate::didChangeScrollbarsForMainFrame):
- UIProcess/PageClient.h:
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didChangeScrollbarsForMainFrame):
- UIProcess/win/WebView.cpp: (WebKit::WebView::didChangeScrollbarsForMainFrame):
- UIProcess/win/WebView.h:
- 10:44 Changeset [78245] by
-
2011-02-10 Ivan Krstić <ike@apple.com>
Reviewed by Adam Roben.
Rename remaining instances of _HOME sandbox parameter.
<rdar://problem/8983428>
- WebProcess/com.apple.WebProcess.sb:
- 10:42 Changeset [78244] by
-
2011-02-10 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Martin Robinson.
[GTK] Log signals from AtkDocument interface also in AccessibilityController
https://bugs.webkit.org/show_bug.cgi?id=54198
Trace AtkDocument's signals emission through AccessibilityController.
Also, taken the code related to adding and removing global
listeners for ATK signals out to a separate file, for the sake of
clarity and to ease future additions.
- DumpRenderTree/gtk/AccessibilityCallbacks.h: Added.
- DumpRenderTree/gtk/AccessibilityCallbacks.cpp: Added (printAccessibilityEvent): Print information about an event. (axObjectEventListener): Global listener for AtkObject's signals. (axDocumentEventListener): Global listener for AtkDocument's signals. (connectAccessibilityCallbacks): Connect all global listeners. (disconnectAccessibilityCallbacks): Disconnect all global listeners.
- DumpRenderTree/gtk/AccessibilityControllerGtk.cpp: (AccessibilityController::setLogAccessibilityEvents): Call to connectAccessibilityCallbacks and disconnectAccessibilityCallbacks.
- GNUmakefile.am: Added new files.
- 10:40 Changeset [78243] by
-
2011-02-10 Zhenyao Mo <zmo@google.com>
Unreviewed, rebaseline.
- platform/mac-leopard/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.checksum:
- platform/mac-leopard/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.png:
- platform/mac-leopard/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.checksum:
- platform/mac-leopard/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.png:
- platform/mac-leopard/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.checksum:
- platform/mac-leopard/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.png:
- platform/mac-leopard/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.checksum:
- platform/mac-leopard/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.png:
- platform/mac-leopard/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.checksum:
- platform/mac-leopard/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.png:
- platform/mac-leopard/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.checksum:
- platform/mac-leopard/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.png:
- platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.checksum:
- platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.png:
- platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.checksum:
- platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.png:
- platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.checksum:
- platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.png:
- platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.checksum:
- platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.png:
- platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.checksum:
- platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.png:
- platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.checksum:
- platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.png:
- platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.checksum:
- platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.png:
- platform/mac-leopard/svg/W3C-SVG-1.1/filters-turb-02-f-expected.checksum:
- platform/mac-leopard/svg/W3C-SVG-1.1/filters-turb-02-f-expected.png:
- platform/mac-leopard/svg/batik/filters/feTile-expected.checksum:
- platform/mac-leopard/svg/batik/filters/feTile-expected.png:
- platform/mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.checksum: Added.
- platform/mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png: Added.
- platform/mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.checksum: Added.
- platform/mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png: Added.
- platform/mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.checksum: Added.
- platform/mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png: Added.
- platform/mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.checksum: Added.
- platform/mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png: Added.
- platform/mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.checksum: Added.
- platform/mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png: Added.
- platform/mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.checksum: Added.
- platform/mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png: Added.
- platform/mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.checksum: Added.
- platform/mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png: Added.
- platform/mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.checksum: Added.
- platform/mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png: Added.
- platform/mac-leopard/svg/foreignObject/text-tref-02-b-expected.checksum:
- platform/mac-leopard/svg/foreignObject/text-tref-02-b-expected.png:
- 10:38 Changeset [78242] by
-
Merge 77549 - Scroll thumb jumps to top when resizing horizontally.
Reviewed by Beth Dakin.
- platform/ScrollView.cpp:
(WebCore::ScrollView::updateScrollbars): Add call to update
the scrollbar's offset in the case where we may have created
a new scrollbar but have not changed the current position.
TBR=kerz@chromium.org
Review URL: http://codereview.chromium.org/6490004
- 10:25 Changeset [78241] by
-
AX: AX needs to stop using WebCoreViewFactory
https://bugs.webkit.org/show_bug.cgi?id=54153
Reviewed by Anders Carlsson.
../WebCore:
WebKit2 no longer uses WebCoreViewFactory, which means that accessibility code needs
to get off of it and use WebCoreSystemInterface, like other clients.
- WebCore.exp.in:
- accessibility/AXObjectCache.h:
- accessibility/mac/AXObjectCacheMac.mm:
(WebCore::AXObjectCache::handleFocusedUIElementChanged):
- accessibility/mac/AccessibilityObjectWrapper.h:
- accessibility/mac/AccessibilityObjectWrapper.mm:
(-[AccessibilityObjectWrapper unregisterUniqueIdForUIElement]):
(CFAutoreleaseHelper):
(AXObjectIsTextMarker):
(AXObjectIsTextMarkerRange):
(AXTextMarkerRange):
(AXTextMarkerRangeStart):
(AXTextMarkerRangeEnd):
(textMarkerForVisiblePosition):
(-[AccessibilityObjectWrapper textMarkerForVisiblePosition:]):
(visiblePositionForTextMarker):
(-[AccessibilityObjectWrapper visiblePositionForTextMarker:]):
(visiblePositionForStartOfTextMarkerRange):
(visiblePositionForEndOfTextMarkerRange):
(textMarkerRangeFromMarkers):
(AXAttributeStringSetElement):
(-[AccessibilityObjectWrapper doAXAttributedStringForTextMarkerRange:]):
(textMarkerRangeFromVisiblePositions):
(-[AccessibilityObjectWrapper textMarkerRangeFromVisiblePositions:endPosition:]):
(-[AccessibilityObjectWrapper visiblePositionRangeForTextMarkerRange:]):
(-[AccessibilityObjectWrapper textMarkerRangeForSelection]):
(-[AccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):
(-[AccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):
- editing/mac/SelectionControllerMac.mm:
(WebCore::accessibilityConvertScreenRect):
(WebCore::SelectionController::notifyAccessibilityForSelectionChange):
- platform/mac/WebCoreSystemInterface.h:
- platform/mac/WebCoreSystemInterface.mm:
../WebKit/mac:
- WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface):
../WebKit2:
- WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface):
- 10:15 Changeset [78240] by
-
2011-02-10 Alexis Menard <alexis.menard@nokia.com>
Reviewed by Andreas Kling.
[Qt] In trunk with Qt Multimedia the full screen mode doesn't work.
https://bugs.webkit.org/show_bug.cgi?id=54201
Add files for the fullscreen video playback handling. It also fix
a missing header.
- WebCore.pro:
2011-02-10 Alexis Menard <alexis.menard@nokia.com>
Reviewed by Andreas Kling.
[Qt] In trunk with Qt Multimedia the full screen mode doesn't work.
https://bugs.webkit.org/show_bug.cgi?id=54201
Add a default fullscreen handler when there is no plaftform plugin
installed. This handler creates a fullscreen QVideoWidget and plays
the video. Space pause/resume the video playback and esc quit the
fullscreen mode.
- WebCoreSupport/FullScreenVideoQt.cpp: (WebCore::DefaultFullScreenVideoHandler::DefaultFullScreenVideoHandler): (WebCore::DefaultFullScreenVideoHandler::~DefaultFullScreenVideoHandler): (WebCore::DefaultFullScreenVideoHandler::requiresFullScreenForVideoPlayback): (WebCore::DefaultFullScreenVideoHandler::enterFullScreen): (WebCore::DefaultFullScreenVideoHandler::exitFullScreen): (WebCore::FullScreenVideoQt::FullScreenVideoQt):
- WebCoreSupport/FullScreenVideoQt.h:
- WebCoreSupport/FullScreenVideoWidget.cpp: Added. (WebCore::FullScreenVideoWidget::FullScreenVideoWidget): (WebCore::FullScreenVideoWidget::~FullScreenVideoWidget): (WebCore::FullScreenVideoWidget::show): (WebCore::FullScreenVideoWidget::closeEvent): (WebCore::FullScreenVideoWidget::event): (WebCore::FullScreenVideoWidget::keyPressEvent): (WebCore::FullScreenVideoWidget::hideCursor): (WebCore::FullScreenVideoWidget::showCursor):
- WebCoreSupport/FullScreenVideoWidget.h: Added.
- 10:11 Changeset [78239] by
-
Sandbox violations trying to read crypto preferences.
<rdar://problem/8981151>
Reviewed by Anders Carlsson.
- WebProcess/com.apple.WebProcess.sb:
- 10:07 Changeset [78238] by
-
2011-02-10 Martin Robinson <mrobinson@igalia.com>
Clump the tests failing only on the GTK+ 32-bit bot together with the
other tests that have this kind of failure.
- platform/gtk/Skipped: Clean up the skipped list slightly.
- 09:49 Changeset [78237] by
-
LLVM Compiler build fix.
- runtime/MarkedBlock.cpp:
(JSC::MarkedBlock::create):
- 09:47 Changeset [78236] by
-
Merge r76205, crbug 54262
- 09:47 Changeset [78235] by
-
2011-02-10 Zhenyao Mo <zmo@google.com>
Unreviewed, rebaseline.
- platform/chromium-linux/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.checksum:
- platform/chromium-linux/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.png:
- platform/chromium-linux/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.checksum:
- platform/chromium-linux/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.png:
- platform/chromium-linux/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.checksum:
- platform/chromium-linux/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.png:
- platform/chromium-linux/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.txt: Removed.
- platform/chromium-linux/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.checksum:
- platform/chromium-linux/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.png:
- platform/chromium-linux/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.checksum:
- platform/chromium-linux/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.png:
- platform/chromium-linux/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.checksum:
- platform/chromium-linux/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.png:
- platform/chromium-linux/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.checksum:
- platform/chromium-linux/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.png:
- platform/chromium-linux/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.checksum:
- platform/chromium-linux/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.png:
- platform/chromium-linux/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.txt: Added.
- platform/chromium-linux/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.checksum:
- platform/chromium-linux/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.png:
- platform/chromium-linux/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.checksum:
- platform/chromium-linux/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.png:
- platform/chromium-linux/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.checksum:
- platform/chromium-linux/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.png:
- platform/chromium-linux/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt: Added.
- platform/chromium-linux/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.checksum:
- platform/chromium-linux/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.png:
- platform/chromium-linux/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.checksum:
- platform/chromium-linux/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.png:
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-turb-02-f-expected.checksum:
- platform/chromium-linux/svg/W3C-SVG-1.1/filters-turb-02-f-expected.png:
- platform/chromium-linux/svg/batik/filters/feTile-expected.checksum:
- platform/chromium-linux/svg/batik/filters/feTile-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.checksum: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.checksum: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.checksum: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.checksum: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.checksum: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.checksum: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.checksum: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.checksum: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png: Added.
- platform/chromium-linux/svg/foreignObject/text-tref-02-b-expected.checksum:
- platform/chromium-linux/svg/foreignObject/text-tref-02-b-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.checksum:
- platform/chromium-win/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.txt: Removed.
- platform/chromium-win/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.checksum:
- platform/chromium-win/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.txt: Removed.
- platform/chromium-win/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.checksum:
- platform/chromium-win/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.txt: Removed.
- platform/chromium-win/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.checksum:
- platform/chromium-win/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.txt: Removed.
- platform/chromium-win/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.checksum:
- platform/chromium-win/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt: Removed.
- platform/chromium-win/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.checksum:
- platform/chromium-win/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.txt: Removed.
- platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.checksum:
- platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt:
- platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.checksum:
- platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.txt: Removed.
- platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.checksum:
- platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.txt: Removed.
- platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.checksum:
- platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt: Removed.
- platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.checksum:
- platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt: Removed.
- platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.checksum:
- platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt: Removed.
- platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.checksum:
- platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.txt: Removed.
- platform/chromium-win/svg/W3C-SVG-1.1/filters-turb-02-f-expected.checksum:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-turb-02-f-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/filters-turb-02-f-expected.txt: Removed.
- platform/chromium-win/svg/batik/filters/feTile-expected.checksum:
- platform/chromium-win/svg/batik/filters/feTile-expected.png:
- platform/chromium-win/svg/batik/filters/feTile-expected.txt:
- platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.checksum: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.checksum: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.checksum: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.checksum: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.checksum: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.checksum: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.checksum: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.checksum: Added.
- platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png: Added.
- platform/chromium-win/svg/foreignObject/text-tref-02-b-expected.checksum:
- platform/chromium-win/svg/foreignObject/text-tref-02-b-expected.png:
- platform/chromium-win/svg/foreignObject/text-tref-02-b-expected.txt: Removed.
- 09:43 Changeset [78234] by
-
2011-02-09 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Remove FileSystem support from the inspector.
https://bugs.webkit.org/show_bug.cgi?id=50695
- CMakeLists.txt:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- inspector/Inspector.idl:
- inspector/InspectorApplicationCacheAgent.cpp: (WebCore::InspectorApplicationCacheAgent::InspectorApplicationCacheAgent): (WebCore::InspectorApplicationCacheAgent::getApplicationCaches):
- inspector/InspectorApplicationCacheAgent.h:
- inspector/InspectorFileSystemAgent.cpp: Removed.
- inspector/InspectorFileSystemAgent.h: Removed.
- inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::identifierForInitialRequestImpl): (WebCore::InspectorInstrumentation::willSendRequestImpl): (WebCore::InspectorInstrumentation::markResourceAsCachedImpl): (WebCore::InspectorInstrumentation::didLoadResourceFromMemoryCacheImpl): (WebCore::InspectorInstrumentation::didReceiveResourceResponseImpl): (WebCore::InspectorInstrumentation::didReceiveContentLengthImpl): (WebCore::InspectorInstrumentation::didFinishLoadingImpl): (WebCore::InspectorInstrumentation::didFailLoadingImpl): (WebCore::InspectorInstrumentation::resourceRetrievedByXMLHttpRequestImpl): (WebCore::InspectorInstrumentation::scriptImportedImpl): (WebCore::InspectorInstrumentation::networkStateChangedImpl): (WebCore::InspectorInstrumentation::updateApplicationCacheStatusImpl): (WebCore::InspectorInstrumentation::retrieveResourceAgent):
- inspector/front-end/FileSystemView.js: Removed.
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.html:
- 09:29 Changeset [78233] by
-
Merge 77891
BUG=72217
Review URL: http://codereview.chromium.org/6488001
- 09:13 Changeset [78232] by
-
2011-02-10 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r78219.
http://trac.webkit.org/changeset/78219
https://bugs.webkit.org/show_bug.cgi?id=54215
breaks editing/style/iframe-onload-crash.html on GTK 64-bit
Debug (Requested by philn-tp on #webkit).
- dom/Document.h:
- dom/DocumentFragment.h:
- dom/Element.h:
- dom/Node.h:
- dom/Text.h:
- editing/htmlediting.cpp: (WebCore::editingIgnoresContent): (WebCore::canHaveChildrenForEditing):
- editing/htmlediting.h:
- html/HTMLBRElement.h:
- html/HTMLButtonElement.h:
- html/HTMLDataGridElement.h:
- html/HTMLFormControlElement.h:
- html/HTMLFrameElementBase.h:
- html/HTMLHRElement.h:
- html/HTMLImageElement.h:
- html/HTMLMeterElement.h:
- html/HTMLOutputElement.h:
- html/HTMLPlugInElement.h:
- html/HTMLProgressElement.h:
- wml/WMLBRElement.h:
- wml/WMLDoElement.h:
- wml/WMLImageElement.h:
- wml/WMLInputElement.h:
- wml/WMLSelectElement.h:
- 09:07 Changeset [78231] by
-
Merge 77049
BUG=70885
Review URL: http://codereview.chromium.org/6482031
- 09:04 Changeset [78230] by
-
Merge 77329
BUG=71167
Review URL: http://codereview.chromium.org/6478032
- 08:58 Changeset [78229] by
-
Merge 78143
BUG=72387
Review URL: http://codereview.chromium.org/6478030
- 08:46 Changeset [78228] by
-
2011-02-09 Martin Robinson <mrobinson@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GTK] Default error page is interfering with tests which require failed loads
https://bugs.webkit.org/show_bug.cgi?id=54157
Unskip passing tests and remove some bogus expected results.
- platform/gtk/Skipped: Unskip some tests which are now passing.
- platform/gtk/fast/dom/null-document-location-put-crash-expected.txt: Removed.
2011-02-09 Martin Robinson <mrobinson@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GTK] Default error page is interfering with tests which require failed loads
https://bugs.webkit.org/show_bug.cgi?id=54157
Disable the default error page during DRT runs. This prevents unexpected loads
from interfering with tests that have planned failed loads.
- DumpRenderTree/gtk/DumpRenderTree.cpp: (webViewLoadError): Added, disable default handler. (createWebView): Connect the new load-error handler.
- 08:21 Changeset [78227] by
-
Unreviewed translation file.
French translation for Webkit/GTK
https://bugs.webkit.org/show_bug.cgi?id=26108
- fr.po: Added.
- 08:16 Changeset [78226] by
-
2011-02-10 Andras Becsi <abecsi@webkit.org>
Rubber-stamped by Csaba Osztrogonác.
[Qt][V8] Fix the build.
No new tests needed.
- bindings/v8/WorkerContextExecutionProxy.cpp: add missing CString header.
- loader/cache/CachedScript.h: do not use extra qualification for base class enum.
- 08:03 Changeset [78225] by
-
2011-02-10 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: [STYLES] Suggest CSS property values once Up/Down is pressed with an empty input
https://bugs.webkit.org/show_bug.cgi?id=54205
- inspector/front-end/CSSCompletions.js: (WebInspector.CSSCompletions): (WebInspector.CSSCompletions.prototype._firstIndexOfPrefix):
- inspector/front-end/CSSKeywordCompletions.js: (WebInspector.CSSKeywordCompletions.forProperty):
- inspector/front-end/StylesSidebarPane.js: ():
- inspector/front-end/TextPrompt.js: (WebInspector.TextPrompt.prototype.complete):
- 08:01 Changeset [78224] by
-
2011-02-10 Philippe Normand <pnormand@igalia.com>
Unreviewed skip failing fast/text/international/hindi-whitespace.html test on GTK
https://bugs.webkit.org/show_bug.cgi?id=54212
- platform/gtk/Skipped:
- 07:50 Changeset [78223] by
-
2011-02-10 Philippe Normand <pnormand@igalia.com>
Unreviewed skip failing fast/text/atsui* tests on GTK
https://bugs.webkit.org/show_bug.cgi?id=54210
- platform/gtk/Skipped:
- 07:47 Changeset [78222] by
-
2011-02-10 Renata Hodovan <reni@webkit.org>
Reviewed by Dirk Schulze.
SVGFESpecularLightingElement doesn't support dynamic invalidation, when attributes change.
https://bugs.webkit.org/show_bug.cgi?id=54186
Adding layout tests for feSpecularLighting dynamic changes.
- platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png: Added.
- svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.txt: Added.
- svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr.html: Added.
- svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.txt: Added.
- svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr.html: Added.
- svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.txt: Added.
- svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr.html: Added.
- svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.txt: Added.
- svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr.html: Added.
- svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.txt: Added.
- svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop.html: Added.
- svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.txt: Added.
- svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop.html: Added.
- svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.txt: Added.
- svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop.html: Added.
- svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.txt: Added.
- svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop.html: Added.
- svg/dynamic-updates/script-tests/SVGFESpecularLightingElement-dom-in-attr.js: Added. (executeTest):
- svg/dynamic-updates/script-tests/SVGFESpecularLightingElement-dom-specularConstant-attr.js: Added. (executeTest):
- svg/dynamic-updates/script-tests/SVGFESpecularLightingElement-dom-specularExponent-attr.js: Added. (executeTest):
- svg/dynamic-updates/script-tests/SVGFESpecularLightingElement-dom-surfaceScale-attr.js: Added. (executeTest):
- svg/dynamic-updates/script-tests/SVGFESpecularLightingElement-svgdom-in-prop.js: Added. (executeTest):
- svg/dynamic-updates/script-tests/SVGFESpecularLightingElement-svgdom-specularConstant-prop.js: Added. (executeTest):
- svg/dynamic-updates/script-tests/SVGFESpecularLightingElement-svgdom-specularExponent-prop.js: Added. (executeTest):
- svg/dynamic-updates/script-tests/SVGFESpecularLightingElement-svgdom-surfaceScale-prop.js: Added. (executeTest):
2011-02-10 Renata Hodovan <reni@webkit.org>
Reviewed by Dirk Schulze.
SVGFESpecularLightingElement doesn't support dynamic invalidation, when attributes change.
https://bugs.webkit.org/show_bug.cgi?id=54186
The dynamic changes are captured by the svgAttributeChange function, and invalidate the filter primitive if necessary.
Tests: svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr.html
svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr.html
svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr.html
svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr.html
svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop.html
svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop.html
svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop.html
svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop.html
- svg/SVGFESpecularLightingElement.cpp: (WebCore::SVGFESpecularLightingElement::svgAttributeChanged):
- svg/SVGFESpecularLightingElement.h:
- 06:59 Changeset [78221] by
-
2011-02-10 Philippe Normand <pnormand@igalia.com>
Unreviewed skipping websocket tests on GTK
https://bugs.webkit.org/show_bug.cgi?id=53683
- platform/gtk/Skipped:
- 06:54 Changeset [78220] by
-
2011-02-10 Andrey Adaikin <aandrey@google.com>
Reviewed by Pavel Feldman.
Web Inspector: Error messages are not displayed for the last line in a script
https://bugs.webkit.org/show_bug.cgi?id=54204
- inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype.addMessage): (WebInspector.SourceFrame.prototype._addMessageToSource): (WebInspector.SourceFrame.prototype._createConditionElement):
- 06:47 Changeset [78219] by
-
2011-02-10 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Eric Seidel.
Make canHaveChildrenForEditing more efficient
https://bugs.webkit.org/show_bug.cgi?id=53564
Improved the performance (1-2% in release and 20% in debug) by adding virtual member function
canContainRangeEndPoint to Node. It returns true whenever the associated node can have be a container
node for a position.
As of this revision, canContainRangeEndPoint returns true on Document, DocumentFragment, Text nodes
and any elements except:
HTML: applet, br, button, datagrid, embed, frame, frameset, hr, img, input,
meter, object, output, progress, and select.
WML: br, do, img, input, and select.
No new tests are added since this change cannot be tested directly.
- dom/Document.h: (WebCore::Document::canContainRangeEndPoint): Added; returns false.
- dom/DocumentFragment.h: (WebCore::DocumentFragment::canContainRangeEndPoint): Added; returns true.
- dom/Element.h: (WebCore::Element::canContainRangeEndPoint): Ditto.
- dom/Node.h: (WebCore::Node::canContainRangeEndPoint): Added; returns false.
- dom/Text.h: (WebCore::Text::canContainRangeEndPoint): Added; returns true.
- editing/htmlediting.cpp: Removed editingIgnoresContent and canHaveChildrenForEditing.
- editing/htmlediting.h: (WebCore::editingIgnoresContent): Moved from htmlediting.cpp; made it inline. (WebCore::canHaveChildrenForEditing): Ditto.
- html/HTMLBRElement.h: (WebCore::HTMLBRElement::canContainRangeEndPoint): Added; returns false.
- html/HTMLButtonElement.h: (WebCore::HTMLButtonElement::canContainRangeEndPoint): Ditto.
- html/HTMLDataGridElement.h: (WebCore::HTMLDataGridElement::canContainRangeEndPoint): Ditto.
- html/HTMLFormControlElement.h: (WebCore::HTMLFormControlElementWithState::canContainRangeEndPoint): Ditto.
- html/HTMLFrameElementBase.h: (WebCore::HTMLFrameElementBase::canContainRangeEndPoint): Ditto.
- html/HTMLHRElement.h: (WebCore::HTMLHRElement::canContainRangeEndPoint): Ditto.
- html/HTMLImageElement.h: (WebCore::HTMLImageElement::canContainRangeEndPoint): Ditto.
- html/HTMLMeterElement.h: (WebCore::HTMLMeterElement::canContainRangeEndPoint): Ditto.
- html/HTMLOutputElement.h: (WebCore::HTMLOutputElement::canContainRangeEndPoint): Ditto.
- html/HTMLPlugInElement.h: (WebCore::HTMLPlugInElement::canContainRangeEndPoint): Ditto.
- html/HTMLProgressElement.h: (WebCore::HTMLProgressElement::canContainRangeEndPoint): Ditto.
- wml/WMLBRElement.h: (WebCore::WMLBRElement::canContainRangeEndPoint): Ditto.
- wml/WMLDoElement.h: (WebCore::WMLDoElement::canContainRangeEndPoint): Ditto.
- wml/WMLImageElement.h: (WebCore::WMLImageElement::canContainRangeEndPoint): Ditto.
- wml/WMLInputElement.h: (WebCore::WMLInputElement::canContainRangeEndPoint): Ditto.
- wml/WMLSelectElement.h: (WebCore::WMLSelectElement::canContainRangeEndPoint): Ditto.
- 06:32 Changeset [78218] by
-
2011-02-10 Philippe Normand <pnormand@igalia.com>
Update GTK results after r78204
- platform/gtk/fast/text/international/text-combine-image-test-expected.txt:
- 06:20 Changeset [78217] by
-
[Qt] Add UrlLoader and command line argument handling to MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=54192
Reviewed by Andreas Kling.
Copy and modify files from QtTestBrowser's implementation.
- MiniBrowser/qt/BrowserWindow.cpp:
(BrowserWindow::BrowserWindow):
(BrowserWindow::newWindow):
- MiniBrowser/qt/BrowserWindow.h:
- MiniBrowser/qt/MiniBrowser.pro:
- MiniBrowser/qt/MiniBrowserApplication.cpp: Copied from QtTestBrowser/launcherwindow.cpp
(MiniBrowserApplication::MiniBrowserApplication):
(MiniBrowserApplication::handleUserOptions):
- MiniBrowser/qt/MiniBrowserApplication.h: Copied from QtTestBrowser/launcherwindow.h
(WindowOptions::WindowOptions):
(MiniBrowserApplication::urls):
(MiniBrowserApplication::isRobotized):
(MiniBrowserApplication::robotTimeout):
(MiniBrowserApplication::robotExtraTime):
- MiniBrowser/qt/UrlLoader.cpp: Copied from QtTestBrowser/urlloader.cpp
(UrlLoader::UrlLoader):
(UrlLoader::loadNext):
(UrlLoader::checkIfFinished):
(UrlLoader::frameLoadStarted):
(UrlLoader::frameLoadFinished):
(UrlLoader::loadUrlList):
(UrlLoader::getUrl):
- MiniBrowser/qt/UrlLoader.h: Copied from QtTestBrowser/urlloader.h
- MiniBrowser/qt/main.cpp:
(main):
- MiniBrowser/qt/utils.cpp: Copied from QtTestBrowser/utils.cpp
(takeOptionValue):
(formatKeys):
(enumToKeys):
(appQuit):
(urlFromUserInput):
- MiniBrowser/qt/utils.h: Copied from QtTestBrowser/utils.h
- 06:18 Changeset [78216] by
-
2011-02-10 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: chromium build fix.
- src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgent::shouldInterruptForMessage):
- 06:14 Changeset [78215] by
-
check-webkit-style: Add -build/include exemption for Tools/MiniBrowser/qt
https://bugs.webkit.org/show_bug.cgi?id=54200
Reviewed by Andreas Kling.
- Scripts/webkitpy/style/checker.py:
- Scripts/webkitpy/style/checker_unittest.py:
- 06:05 Changeset [78214] by
-
Update Windows results after r78204
- platform/win/fast/text/international/text-combine-image-test-expected.checksum:
- platform/win/fast/text/international/text-combine-image-test-expected.png:
- platform/win/fast/text/international/text-combine-image-test-expected.txt:
- 06:04 Changeset [78213] by
-
Update Windows results after r78182
Nikolas Zimmermann says he thinks we're not matching the Mac results anymore due to rounding
differences.
- platform/win/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.txt: Added.
- platform/win/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt: Added.
- 06:03 Changeset [78212] by
-
2011-02-10 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: define interface per domain in Inspector.idl.
https://bugs.webkit.org/show_bug.cgi?id=54135
- inspector/CodeGeneratorInspector.pm:
- inspector/Inspector.idl:
- 05:39 Changeset [78211] by
-
2011-02-10 Peter Varga <pvarga@webkit.org>
Reviewed by Csaba Osztrogonác.
Remove PCRE source from trunk
https://bugs.webkit.org/show_bug.cgi?id=54188
- Source/cmake/WebKitFS.cmake:
2011-02-10 Peter Varga <pvarga@webkit.org>
Reviewed by Csaba Osztrogonác.
Remove PCRE source from trunk
https://bugs.webkit.org/show_bug.cgi?id=54188
- Android.mk:
- Android.v8.wtf.mk:
- CMakeLists.txt:
- DerivedSources.make:
- DerivedSources.pro:
- GNUmakefile.am:
- JavaScriptCore.gypi:
- JavaScriptCore.order:
- JavaScriptCore.pri:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make:
- JavaScriptCore.vcproj/WTF/WTFCommon.vsprops:
- JavaScriptCore.vcproj/jsc/jscCommon.vsprops:
- JavaScriptCore.xcodeproj/project.pbxproj:
- pcre/AUTHORS: Removed.
- pcre/COPYING: Removed.
- pcre/dftables: Removed.
- pcre/pcre.h: Removed.
- pcre/pcre.pri: Removed.
- pcre/pcre_compile.cpp: Removed.
- pcre/pcre_exec.cpp: Removed.
- pcre/pcre_internal.h: Removed.
- pcre/pcre_tables.cpp: Removed.
- pcre/pcre_ucp_searchfuncs.cpp: Removed.
- pcre/pcre_xclass.cpp: Removed.
- pcre/ucpinternal.h: Removed.
- pcre/ucptable.cpp: Removed.
- wscript:
2011-02-10 Peter Varga <pvarga@webkit.org>
Reviewed by Csaba Osztrogonác.
Remove PCRE source from trunk
https://bugs.webkit.org/show_bug.cgi?id=54188
- ForwardingHeaders/pcre/pcre.h: Removed.
2011-02-10 Peter Varga <pvarga@webkit.org>
Reviewed by Csaba Osztrogonác.
Remove PCRE source from trunk
https://bugs.webkit.org/show_bug.cgi?id=54188
- WebKit2.pro:
2011-02-10 Peter Varga <pvarga@webkit.org>
Reviewed by Csaba Osztrogonác.
Remove PCRE source from trunk
https://bugs.webkit.org/show_bug.cgi?id=54188
- wx/build/settings.py:
- 05:37 Changeset [78210] by
-
2011-02-10 Andrey Adaikin <aandrey@google.com>
Reviewed by Pavel Feldman.
Web Inspector: [regression] Fix syncing heights of the gutter and main panel lines, and add 2px padding-left
https://bugs.webkit.org/show_bug.cgi?id=54098
- inspector/front-end/TextViewer.js: (WebInspector.TextViewer): (WebInspector.TextViewer.prototype._updatePanelOffsets): (WebInspector.TextViewer.prototype._syncScroll): (WebInspector.TextViewer.prototype._syncDecorationsForLine): (WebInspector.TextEditorChunkedPanel.prototype._totalHeight): (WebInspector.TextEditorChunkedPanel.prototype.resize): (WebInspector.TextEditorGutterPanel): (WebInspector.TextEditorGutterChunk.prototype.set expanded): (WebInspector.TextEditorGutterChunk.prototype.get height): (WebInspector.TextEditorMainChunk.prototype.get height):
- inspector/front-end/textViewer.css: (.webkit-line-content):
- 05:24 Changeset [78209] by
-
2011-02-10 Philippe Normand <pnormand@igalia.com>
Unreviewed, skip failing fast/text/midword-break-after-breakable-char.html on
GTK
- platform/gtk/Skipped:
- 05:15 Changeset [78208] by
-
2011-02-10 Patrick Gansterer <paroga@webkit.org>
Reviewed by Adam Barth.
Add randomValuesFromOS for OS(WINDOWS)
https://bugs.webkit.org/show_bug.cgi?id=54155
Use CryptGenRandom for generating cryptographically secure random numbers.
This will work on WinCE and MinGW too.
- config.h:
- wtf/OSRandomSource.cpp: (WTF::randomValuesFromOS):
- 05:06 Changeset [78207] by
-
2011-02-10 Jochen Eisinger <jochen@chromium.org>
Reviewed by Jeremy Orlow.
[chromium] add WebIDBObjectStore::clear method
- public/WebIDBObjectStore.h: (WebKit::WebIDBObjectStore::put): (WebKit::WebIDBObjectStore::deleteFunction): (WebKit::WebIDBObjectStore::clear):
- 04:59 Changeset [78206] by
-
2011-02-10 Philippe Normand <pnormand@igalia.com>
Unreviewed, skip failing fast/text/capitalize-boundaries.html on
GTK
- platform/gtk/Skipped:
- 04:52 Changeset [78205] by
-
2011-02-10 David Levin <levin@chromium.org>
Reviewed by Shinichiro Hamaji.
check-webkit-style should be able to figure out function modifiers and return type.
https://bugs.webkit.org/show_bug.cgi?id=54124
- Scripts/webkitpy/style/checkers/cpp.py: (_rfind_in_lines): A way to search backwards in lines. (_FunctionState.modifiers_and_return_type):
- Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests for the new functionality.
- 04:48 Changeset [78204] by
-
2011-02-10 takano takumi <takano@apple.com>
Reviewed by Dan Bernstein.
A full-width character rotated leftward 90 degrees in text-combine
https://bugs.webkit.org/show_bug.cgi?id=54169
Added a test for this bug to existing text-combine test.
- fast/text/international/text-combine-image-test.html:
- platform/mac/fast/text/international/text-combine-image-test-expected.checksum:
- platform/mac/fast/text/international/text-combine-image-test-expected.png:
- platform/mac/fast/text/international/text-combine-image-test-expected.txt:
2011-02-10 takano takumi <takano@apple.com>
Reviewed by Dan Bernstein.
A full-width character rotated leftward 90 degrees in text-combine
https://bugs.webkit.org/show_bug.cgi?id=54169
- rendering/RenderCombineText.cpp: (WebCore::RenderCombineText::combineText):
- Fixed by resetting font's orientation to horizontal when we decided to make combined text. Otherwise the text will be unexpectedly rotated in showGlyphsWithAdvances() in FontMac.mm.
- 04:46 Changeset [78203] by
-
2011-02-10 Jarred Nicholls <jarred@sencha.com>
Reviewed by Adam Barth.
REGRESSION(r78149): Return value of read() shouldn't be ignored.
https://bugs.webkit.org/show_bug.cgi?id=54167
stdio read should have its return value handled. Build error in gcc 4.4.5.
- wtf/OSRandomSource.cpp: (WTF::randomValuesFromOS):
- 04:42 Changeset [78202] by
-
2011-02-10 Alexey Proskuryakov <ap@apple.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=50306
<rdar://problem/8976152> REGRESSION: WebChromeClient::shouldReplaceWithGeneratedFileForUpload()
uses an initialized result value (breaks form submission with clang-built WebKit)
No new test, because I can't reproduce the observable effect with my gcc build.
- platform/network/FormData.cpp: (WebCore::FormData::appendKeyValuePairItems): Restore an empty path check - an empty path was causing an exception in Foundation.
- 04:41 Changeset [78201] by
-
Turn on the new drawing area on Windows
Fixes <http://webkit.org/b/53805> <rdar://problem/8960666> WebKit2 on Windows should use
DrawingAreaProxyImpl
Reviewed by Darin Adler.
- UIProcess/win/WebView.cpp:
(WebKit::useNewDrawingArea): Return true!
- 04:40 Changeset [78200] by
-
Hook up WM_PRINT to the new drawing area
Fixes <http://webkit.org/b/54145> <rdar://problem/8979559> WM_PRINT doesn't work with new
drawing area (assertion failure in DrawingAreaProxyImpl in Debug builds)
Reviewed by Darin Adler.
Source/WebKit2:
- UIProcess/win/WebView.cpp:
(WebKit::WebView::paint): Added. Code came from onPaintEvent.
(WebKit::WebView::onPaintEvent):
(WebKit::WebView::onPrintClientEvent):
Changed to call paint.
- UIProcess/win/WebView.h: Added paint. Also separated message handler functions into their
own paragraph.
Tools:
Test that WM_PRINT doesn't trigger an assertion
- TestWebKitAPI/Tests/WebKit2/win/WMPrint.cpp: Added.
(TestWebKitAPI::TEST): Send a WM_PRINT message to a WKView.
- 04:40 Changeset [78199] by
-
Notice when the backing store goes away after DidSetSize
Fixes <http://webkit.org/b/54142> <rdar://problem/8979365> Crash in
DrawingAreaProxyImpl::paint when WKView paints after being resized while hidden
Reviewed by Darin Adler.
Source/WebKit2:
- UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::paint): Null-check m_backingStore after waiting for
DidSetSize, as m_backingStore can go away when we receive that message. This is the bug fix.
Also moved the accelerated compositing check inside the block where we wait for DidSetSize.
If we didn't wait for DidSetSize, we already know that we're not in accelerated compositing
mode (and asserted so earlier in this function).
Tools:
Test that having a WKView paint after being resized while hidden doesn't cause a crash
- TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp:
(TestWebKitAPI::TEST): Force the WKView to paint after resizing it while hidden.
- 04:39 Changeset [78198] by
-
Decode a null SharedMemory::Handle correctly on Windows
Fixes <http://webkit.org/b/54141> <rdar://problem/8979195> WKView draws at wrong size,
performs badly if is resized while hidden (assertion fails in
BackingStore::incorporateUpdate in Debug builds)
Reviewed by Darin Adler.
Source/WebKit2:
- Platform/win/SharedMemoryWin.cpp:
(WebKit::getDuplicatedHandle): Added. Code came from decode. The only changes were to
null-check sourceHandle (this is the bug fix) and to assert when ::DuplicateHandle fails
(which would have caught the bug earlier).
(WebKit::SharedMemory::Handle::decode): Changed to use getDuplicatedHandle.
Tools:
Add a test that resizes a WKView while it's hidden
- TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp: Added.
(TestWebKitAPI::didFinishLoadForFrame): Record that the load finished.
(TestWebKitAPI::setPageLoaderClient): Hook up our didFinishLoadForFrame callback.
(TestWebKitAPI::flushMessages): Load a URL and wait for the load to complete. This ensures
that all pending messages have been handled by the UI and web process.
(TestWebKitAPI::timerCallback): Kill the timer and record that it fired.
(TestWebKitAPI::runForDuration): Set a timer and run the run loop until it fires.
(TestWebKitAPI::waitForBackingStoreUpdate): Wait for half a second to give the web process a
chance to display, then flush all pending messages.
(TestWebKitAPI::TEST): Resize the WKView while it's hidden, then show it again and wait for
the backing store to update. This triggers the assertion from bug 54141.
- TestWebKitAPI/win/PlatformWebViewWin.cpp:
(TestWebKitAPI::PlatformWebView::resizeTo): Implemented.
- TestWebKitAPI/win/TestWebKitAPI.vcproj: Added new test.
- 04:38 Changeset [78197] by
-
Don't invalidate outside of the WebPage's bounds
Fixes <http://webkit.org/b/54123> <rdar://problem/8978383> Assertion failure in
BackingStore::BackingStore if a new WebPage becomes active before receiving a size
Reviewed by Darin Adler.
- WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::setNeedsDisplay): Intersect the dirty rect with our bounds before
doing anything else.
(WebKit::DrawingAreaImpl::display): Added an assertion to help catch the bad case a little
earlier.
- 04:36 Changeset [78196] by
-
2011-02-09 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Network & Resource panels make multiple requests for images with no content
https://bugs.webkit.org/show_bug.cgi?id=54085
- Added success parameter to resourceContent
- NetworkManager.requestContent() now returns empty for zero-length resources, null for errors
- inspector/Inspector.idl:
- inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::resourceData): (WebCore::InspectorResourceAgent::resourceContent):
- inspector/InspectorResourceAgent.h:
- inspector/front-end/NetworkManager.js: (WebInspector.NetworkManager.prototype.requestContent):
- inspector/front-end/Resource.js: (WebInspector.Resource.prototype.requestContent): (WebInspector.Resource.prototype._contentURL):
- 04:26 Changeset [78195] by
-
2011-02-10 Patrick Gansterer <paroga@webkit.org>
Reviewed by Adam Barth.
Rename randomValuesFromOS to cryptographicallyRandomValuesFromOS
https://bugs.webkit.org/show_bug.cgi?id=54156
randomValuesFromOS generates random numbers of cryptographic quality.
Make this clear by adding "cryptographically" to the function name.
- wtf/CryptographicallyRandomNumber.cpp: (WTF::ARC4Stream::ARC4RandomNumberGenerator::stir):
- wtf/OSRandomSource.cpp: (WTF::cryptographicallyRandomValuesFromOS):
- wtf/OSRandomSource.h:
- 04:23 Changeset [78194] by
-
2011-02-10 Renata Hodovan <reni@webkit.org>
Reviewed by Dirk Schulze.
Move the light source implementations into their own files.
https://bugs.webkit.org/show_bug.cgi?id=53996
Splitting LightSource.cpp into 3 files.
No new tests are added since this is a refactoring.
- Android.mk:
- CMakeLists.txt:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- platform/graphics/filters/DistantLightSource.cpp: Added. (WebCore::DistantLightSource::initPaintingData): (WebCore::DistantLightSource::updatePaintingData): (WebCore::DistantLightSource::setAzimuth): (WebCore::DistantLightSource::setElevation): (WebCore::DistantLightSource::externalRepresentation):
- platform/graphics/filters/LightSource.cpp:
- platform/graphics/filters/PointLightSource.cpp: Added. (WebCore::PointLightSource::initPaintingData): (WebCore::PointLightSource::updatePaintingData): (WebCore::PointLightSource::setX): (WebCore::PointLightSource::setY): (WebCore::PointLightSource::setZ): (WebCore::operator<<): (WebCore::PointLightSource::externalRepresentation):
- platform/graphics/filters/SpotLightSource.cpp: Added. (WebCore::SpotLightSource::initPaintingData): (WebCore::SpotLightSource::updatePaintingData): (WebCore::SpotLightSource::setX): (WebCore::SpotLightSource::setY): (WebCore::SpotLightSource::setZ): (WebCore::SpotLightSource::setPointsAtX): (WebCore::SpotLightSource::setPointsAtY): (WebCore::SpotLightSource::setPointsAtZ): (WebCore::SpotLightSource::setSpecularExponent): (WebCore::SpotLightSource::setLimitingConeAngle): (WebCore::operator<<): (WebCore::SpotLightSource::externalRepresentation):
- 04:07 Changeset [78193] by
-
2011-02-10 Avi Drissman <avi@google.com>
Reviewed by Darin Fisher.
<option> should implement the dir attribute. Mac Chromium version, followup to r76983, r77654.
https://bugs.webkit.org/show_bug.cgi?id=50969
Use manual test Source/WebCore/manual-tests/pop-up-alignment-and-direction.html added in r76983.
- platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupListBox::updateFromElement):
- platform/chromium/PopupMenuChromium.h:
2011-02-10 Avi Drissman <avi@google.com>
Reviewed by Darin Fisher.
<option> should implement the dir attribute. Mac Chromium version, followup to r76983, r77654.
https://bugs.webkit.org/show_bug.cgi?id=50969
Use manual test Source/WebCore/manual-tests/pop-up-alignment-and-direction.html added in r76983.
- public/WebMenuItemInfo.h:
- public/WebPopupMenuInfo.h:
- src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::getPopupMenuInfo):
- src/ExternalPopupMenu.cpp: (WebKit::ExternalPopupMenu::getPopupMenuInfo):
- 03:58 Changeset [78192] by
-
2011-02-10 kasthuri <kasthuri.n-s@nokia.com>
Reviewed by Antonio Gomes.
[Qt] QWebFrame::setHtml doesn't emit loadFinished signal
https://bugs.webkit.org/show_bug.cgi?id=38634
QWebView->page()->mainFrame()->setHtml(html) is always emitting
the loadFinished() signal for all types of html files.
But the proposed test content was trying to catch the signal after
calling setHtml() api and becuase of this the emitted signal for a
simple html page is never caught as its emitted before even the connect
call was successful.
updated the tst_QWebFrame::setHtml() in tst_qwebframe.cpp to check for
signal using the QSignalSpy.
- tests/qwebframe/tst_qwebframe.cpp:
- 03:54 Changeset [78191] by
-
2011-02-10 Philippe Normand <pnormand@igalia.com>
Unreviewed, skip failing fast/replaced/border-radius-clip.html on GTK
- platform/gtk/Skipped:
- 03:39 Changeset [78190] by
-
2011-02-10 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed.
LayoutTests/svg cleanup
https://bugs.webkit.org/show_bug.cgi?id=54184
Regenerate result with a 64bit SL machine.. a pity that we have diffs there.
- platform/mac/svg/zoom/page/zoom-mask-with-percentages-expected.txt:
- 03:11 Changeset [78189] by
-
2011-02-10 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed.
LayoutTests/svg cleanup
https://bugs.webkit.org/show_bug.cgi?id=54184
Update mac-leopard/qt baselines after r78182.
- platform/mac-leopard/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.txt:
- platform/mac-leopard/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.txt:
- platform/mac-leopard/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.txt:
- platform/mac-leopard/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.txt:
- platform/mac-leopard/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt:
- platform/mac-leopard/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.txt:
- platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt:
- platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.txt:
- platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.txt:
- platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt:
- platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt:
- platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt:
- platform/mac-leopard/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.txt:
- platform/mac-leopard/svg/foreignObject/text-tref-02-b-expected.txt:
- platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.txt:
- platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.txt:
- platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.txt:
- platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.txt:
- platform/qt/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt:
- platform/qt/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt:
- platform/qt/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.txt:
- platform/qt/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.txt:
- platform/qt/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt:
- platform/qt/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt:
- platform/qt/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt:
- platform/qt/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/filters-turb-02-f-expected.txt:
- platform/qt/svg/foreignObject/text-tref-02-b-expected.txt:
- 03:06 Changeset [78188] by
-
2011-02-10 Philippe Normand <pnormand@igalia.com>
Unreviewed, updated svg GTK baselines after r78182.
- platform/gtk/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.txt:
- platform/gtk/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.txt:
- platform/gtk/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.txt:
- platform/gtk/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.txt:
- platform/gtk/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt:
- platform/gtk/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.txt:
- platform/gtk/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt:
- platform/gtk/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.txt:
- platform/gtk/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.txt:
- platform/gtk/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt:
- platform/gtk/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt:
- platform/gtk/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt:
- platform/gtk/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.txt:
- platform/gtk/svg/foreignObject/text-tref-02-b-expected.txt:
- 03:02 Changeset [78187] by
-
2011-02-10 Hans Wennborg <hans@chromium.org>
Reviewed by Jeremy Orlow.
IndexedDB: Update the semantics of put()
https://bugs.webkit.org/show_bug.cgi?id=54102
Update test to reflect the new semantics.
- storage/indexeddb/objectstore-autoincrement-expected.txt:
- storage/indexeddb/objectstore-autoincrement.html:
2011-02-10 Hans Wennborg <hans@chromium.org>
Reviewed by Jeremy Orlow.
IndexedDB: Update the semantics of put()
https://bugs.webkit.org/show_bug.cgi?id=54102
Update the semantics of put: For object stores with auto increment,
it should be allowed to provide an explicit key, or an in-line key,
overriding the key generator mechanism.
This reflects the spec changes suggested here:
http://www.w3.org/Bugs/Public/show_bug.cgi?id=11976
Extracting key-selection logic into its own function
to make it a bit easier on the eyes.
- storage/IDBObjectStoreBackendImpl.cpp: (WebCore::IDBObjectStoreBackendImpl::selectKeyForPut): (WebCore::IDBObjectStoreBackendImpl::putInternal):
- storage/IDBObjectStoreBackendImpl.h: (WebCore::IDBObjectStoreBackendImpl::resetAutoIncrementKeyCache):
- 02:51 Changeset [78186] by
-
2011-02-10 Philippe Normand <pnormand@igalia.com>
Unreviewed, GTK build fix after roll out of r78157...
- GNUmakefile.am:
- 02:49 Changeset [78185] by
-
2011-02-10 Eric Seidel <eric@webkit.org>
Unreviewed, rolling out r78157.
http://trac.webkit.org/changeset/78157
https://bugs.webkit.org/show_bug.cgi?id=54150
Fails on a bunch of bots
- plugins/npruntime/evaluate-js-destroying-plugin-from-destroy-stream-expected.txt: Removed.
- plugins/npruntime/evaluate-js-destroying-plugin-from-destroy-stream.html: Removed.
2011-02-10 Eric Seidel <eric@webkit.org>
Unreviewed, rolling out r78157.
http://trac.webkit.org/changeset/78157
https://bugs.webkit.org/show_bug.cgi?id=54150
Fails on a bunch of bots
- WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::~PluginView): (WebKit::PluginView::evaluate):
2011-02-10 Eric Seidel <eric@webkit.org>
Unreviewed, rolling out r78157.
http://trac.webkit.org/changeset/78157
https://bugs.webkit.org/show_bug.cgi?id=54150
Fails on a bunch of bots
- DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
- DumpRenderTree/TestNetscapePlugIn/Tests/EvaluateJSDestroyingPluginFromDestroyStream.cpp: Removed.
- DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
- DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
- 02:44 Changeset [78184] by
-
2011-02-10 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Xan Lopez.
[GTK] Reset GTK' DRT's AccessibilityController to consistent value before every test
https://bugs.webkit.org/show_bug.cgi?id=54185
- DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
- 02:43 Changeset [78183] by
-
https://bugs.webkit.org/show_bug.cgi?id=54103
Implement fast path for matching simple selectors
Reviewed by Darin Adler.
Implement a fast path for single and descendant selectors consisting
of id, class and tag selectors only.
Selectors like this are marked on style selector initialization. When
encountered during style matching they are resolved using a fast path.
Since selectors like this are very common this speeds up style matching
quite a bit (up to 50% on some sites according to Shark).
- css/CSSStyleSelector.cpp:
(WebCore::RuleData::hasFastCheckableSelector):
(WebCore::RuleData::hasMultipartSelector):
(WebCore::RuleData::hasTopSelectorMatchingHTMLBasedOnRuleHash):
(WebCore::CSSStyleSelector::matchRulesForList):
(WebCore::CSSStyleSelector::checkSelector):
(WebCore::selectorTagMatches):
(WebCore::isFastCheckableSelector):
(WebCore::CSSStyleSelector::SelectorChecker::fastCheckSelector):
(WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
(WebCore::isSelectorMatchingHTMLBasedOnRuleHash):
(WebCore::RuleData::RuleData):
- css/CSSStyleSelector.h:
- 02:25 Changeset [78182] by
-
2011-02-10 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Maciej Stachowiak.
LayoutTests/svg cleanup
https://bugs.webkit.org/show_bug.cgi?id=54184
Fix wrong xlink:hrefs in dozens of SVG testcases. SVGFreeSans.svg is now used in more places.
Remove unnecessary xml-stylesheet declarations, and unneeded text css attributes in some places.
Updated pixel test results for the affected testcases.
- platform/mac-snowleopard/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.checksum:
- platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.png:
- platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.checksum:
- platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.png:
- platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.checksum:
- platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.png:
- platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.checksum:
- platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.png:
- platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.checksum:
- platform/mac/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.png:
- platform/mac/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.checksum:
- platform/mac/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.png:
- platform/mac/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.checksum:
- platform/mac/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.png:
- platform/mac/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.checksum:
- platform/mac/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.png:
- platform/mac/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.checksum:
- platform/mac/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.png:
- platform/mac/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.checksum:
- platform/mac/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.png:
- platform/mac/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.checksum:
- platform/mac/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.png:
- platform/mac/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.checksum:
- platform/mac/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.png:
- platform/mac/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.checksum:
- platform/mac/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.png:
- platform/mac/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-light-04-f-expected.checksum:
- platform/mac/svg/W3C-SVG-1.1/filters-light-04-f-expected.png:
- platform/mac/svg/W3C-SVG-1.1/filters-light-04-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-turb-02-f-expected.checksum:
- platform/mac/svg/W3C-SVG-1.1/filters-turb-02-f-expected.png:
- platform/mac/svg/W3C-SVG-1.1/filters-turb-02-f-expected.txt:
- platform/mac/svg/batik/filters/feTile-expected.checksum:
- platform/mac/svg/batik/filters/feTile-expected.png:
- platform/mac/svg/batik/filters/feTile-expected.txt:
- platform/mac/svg/css/circle-in-mask-with-shadow-expected.checksum:
- platform/mac/svg/css/circle-in-mask-with-shadow-expected.png:
- platform/mac/svg/css/mask-with-shadow-expected.checksum:
- platform/mac/svg/css/mask-with-shadow-expected.png:
- platform/mac/svg/foreignObject/text-tref-02-b-expected.checksum:
- platform/mac/svg/foreignObject/text-tref-02-b-expected.png:
- platform/mac/svg/foreignObject/text-tref-02-b-expected.txt:
- platform/mac/svg/text/text-tref-01-b-expected.checksum:
- platform/mac/svg/text/text-tref-01-b-expected.png:
- platform/mac/svg/transforms/animated-path-inside-transformed-html-expected.checksum:
- platform/mac/svg/transforms/animated-path-inside-transformed-html-expected.png:
- platform/mac/svg/zoom/page/zoom-mask-with-percentages-expected.checksum:
- platform/mac/svg/zoom/page/zoom-mask-with-percentages-expected.png:
- platform/mac/svg/zoom/page/zoom-mask-with-percentages-expected.txt:
- svg/W3C-SVG-1.1-SE/coords-dom-01-f.svg:
- svg/W3C-SVG-1.1-SE/coords-dom-02-f.svg:
- svg/W3C-SVG-1.1-SE/coords-dom-03-f.svg:
- svg/W3C-SVG-1.1-SE/coords-dom-04-f.svg:
- svg/W3C-SVG-1.1-SE/paths-dom-02-f.svg:
- svg/W3C-SVG-1.1-SE/pservers-pattern-04-f.svg:
- svg/W3C-SVG-1.1-SE/types-dom-01-b.svg:
- svg/W3C-SVG-1.1-SE/types-dom-02-f.svg:
- svg/W3C-SVG-1.1-SE/types-dom-03-b.svg:
- svg/W3C-SVG-1.1-SE/types-dom-04-b.svg:
- svg/W3C-SVG-1.1-SE/types-dom-05-b.svg:
- svg/W3C-SVG-1.1-SE/types-dom-06-f.svg:
- svg/W3C-SVG-1.1-SE/types-dom-07-f.svg:
- svg/W3C-SVG-1.1/filters-light-04-f.svg:
- svg/W3C-SVG-1.1/filters-turb-02-f.svg:
- svg/W3C-SVG-1.1/resources/interact-order-02-b-targ.svg:
- svg/W3C-SVG-1.1/resources/interact-order-03-b-targ.svg:
- svg/W3C-SVG-1.1/resources/linkingToc-t.svg:
- svg/batik/filters/feTile.svg:
- svg/css/circle-in-mask-with-shadow.svg:
- svg/css/mask-with-shadow.svg:
- svg/custom/image-clipped-hit.svg:
- svg/foreignObject/text-tref-02-b.svg:
- svg/hixie/cascade/002.css: Removed.
- svg/text/text-tref-01-b.svg:
- svg/transforms/animated-path-inside-transformed-html.xhtml:
- svg/zoom/page/zoom-mask-with-percentages.svg:
- svg/zoom/page/zoom-zoom-coords.xhtml:
- 02:04 Changeset [78181] by
-
2011-02-10 Philippe Normand <pnormand@igalia.com>
Unreviewed GTK build fix.
Adding
Tools/DumpRenderTree/TestNetscapePlugIn/Tests/EvaluateJSDestroyingPluginFromDestroyStream.cpp
in the build, fixing the
plugins/npruntime/evaluate-js-destroying-plugin-from-destroy-stream.html
test.
- GNUmakefile.am:
2011-02-10 Philippe Normand <pnormand@igalia.com>
Unreviewed, typo fix.
- platform/gtk/Skipped:
- 01:29 Changeset [78180] by
-
2011-02-10 Philippe Normand <pnormand@igalia.com>
Unreviewed, skip failing test.
- platform/gtk/Skipped: Skip fast/events/focusingUnloadedFrame.html
- 01:03 Changeset [78179] by
-
2011-02-10 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Chris Fleizach.
[GTK] Add support in DRT to log "accessibility events"
https://bugs.webkit.org/show_bug.cgi?id=54116
Added a way to log accessibility related events, in a
platform-dependant way.
Add new function to AccessibilityController.
- DumpRenderTree/AccessibilityController.h:
- DumpRenderTree/AccessibilityController.cpp: (logAccessibilityEventsCallback): New callback. (AccessibilityController::getJSClass): Added new function. (AccessibilityController::resetToConsistentState): Initialized calling setLogAccessibilityEvents(false).
Provided implementation for the GTK port.
- DumpRenderTree/gtk/AccessibilityControllerGtk.cpp: (accessibility_event_listener): Common listener for logging information about all the signals emitted by any AtkObject. (AccessibilityController::setLogAccessibilityEvents): Add or remove listeners for signals, as specified by the parameter.
Provide dummy implementations for mac and win ports.
- DumpRenderTree/mac/AccessibilityControllerMac.mm: (AccessibilityController::setLogAccessibilityEvents):
- DumpRenderTree/win/AccessibilityControllerWin.cpp: (AccessibilityController::setLogAccessibilityEvents):
- 01:00 Changeset [78178] by
-
2011-02-10 Shinichiro Hamaji <hamaji@chromium.org>
Chromium expectations update.
fast/box-shadow/shadow-buffer-partial.html is failing.
- platform/chromium/test_expectations.txt:
- 00:09 Changeset [78177] by
-
2011-02-09 Maciej Stachowiak <mjs@apple.com>
Reviewed by Kent Tamura.
Skip newly added test that depends on unimplemented DRT functionality
https://bugs.webkit.org/show_bug.cgi?id=54172
- platform/mac-wk2/Skipped:
02/09/11:
- 23:13 Changeset [78176] by
-
<rdar://problem/8805364> Malloc zone enumeration code should be safe in the face of errors from the memory reader.
Reviewed by Sam Weinig.
- wtf/FastMalloc.cpp:
(WTF::PageHeapAllocator::recordAdministrativeRegions): Use the new helper function to walk the linked list safely.
(WTF::TCMalloc_ThreadCache_FreeList::enumerateFreeObjects): Ditto.
(WTF::TCMalloc_Central_FreeList::enumerateFreeObjects): Ditto.
(WTF::TCMallocStats::PageMapFreeObjectFinder::visit): Bail out if the span could not be read.
(WTF::TCMallocStats::PageMapMemoryUsageRecorder::visit): Ditto.
- wtf/MallocZoneSupport.h:
(WTF::RemoteMemoryReader::operator()): Remove an assert that is not valid.
(WTF::RemoteMemoryReader::nextEntryInLinkedList): Add a helper function for retrieving the next entry in
a linked list. It maps a failed read of the remote memory in to a null pointer, which all callers can
handle gracefully.
- 21:31 Changeset [78175] by
-
2011-02-09 Hayato Ito <hayato@chromium.org>
Reviewed by Tony Chang.
[NRWT] Remove encoding parameters where we can assume data can be
written in binary mode.
- Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
- Scripts/webkitpy/layout_tests/port/base.py:
- 21:21 Changeset [78174] by
-
Bug 54164 - Optimize global_var accesses on JSVALUE64
Reviewed by Sam Weinig.
Directly embed the pointer to d->registers, optimize out the load
from the variable object, as we do already in JSVALUE32_64.
This is a ~1.5% win on sunspidey.
- jit/JIT.cpp:
- jit/JIT.h:
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_get_global_var):
(JSC::JIT::emit_op_put_global_var):
(JSC::JIT::emit_op_get_scoped_var):
(JSC::JIT::emit_op_put_scoped_var):
- 21:15 Changeset [78173] by
-
2011-02-09 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dan Bernstein.
REGRESSION (r77101) box-shadow sometimes renders incorrectly
https://bugs.webkit.org/show_bug.cgi?id=54160
Fix an issue when ShadowBlur had a cached image buffer
that was larger than that of the current shadow being drawn,
and the current shadow was partially clipped out.
In that situation endShadowLayer() would clip to the image
buffer, using the size of the buffer (as it must), but failed
to take into account the fact that we'd only cleared and painted
into a smaller section of the buffer. So we need to additionally
constrain the clip to cover only the valid part of the buffer.
Test: fast/box-shadow/shadow-buffer-partial.html
- platform/graphics/ShadowBlur.cpp: (WebCore::ShadowBlur::endShadowLayer):
- 19:37 Changeset [78172] by
-
2011-02-09 Ryosuke Niwa <rniwa@webkit.org>
Unreviewed; removed Windows port's expected result for r78104.
- platform/win/editing/undo/undo-paste-when-caret-is-not-in-range-expected.txt: Removed.
- 19:07 Changeset [78171] by
-
Fix for <rdar://problem/8977051> CrashTracer: 8 crashes
in WebProcess at com.apple.WebCore:
-[ScrollbarPartAnimation setCurrentProgress:] + 364
Reviewed by Maciej Stachowiak.
The ScrollbarPartAnimation must be sent by reference!
- platform/mac/ScrollAnimatorMac.mm:
(-[ScrollbarPainterDelegate setUpAnimation:scrollerPainter:part:WebCore::animateAlphaTo:duration:]):
- 18:21 Changeset [78170] by
-
Fixed up ChangeLog after my last commit
- 18:20 Changeset [78169] by
-
2011-02-09 Adam Barth <abarth@webkit.org>
Another attempt to fix the Qt Windows build.
- config.h:
- wtf/OSRandomSource.cpp: (WTF::randomValuesFromOS):
- 18:14 Changeset [78168] by
-
2011-02-09 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
REGRESSION(r76107): Crash in VisibleSelection::toNormalizedRange
https://bugs.webkit.org/show_bug.cgi?id=54053
The bug was caused by RenderBlock::positionForPoint's improperly returning a shadow node inside
RenderFileUploadControl for hit testing and VisibleSelection::toNormalizedRange's always assuming
the position variable "s" is not null.
Fixed the bug by always returning a null position from RenderFileUploadControl::positionForPoint,
and also exiting early when either "s" or "e" is null in VisibleSelection::toNormalizedRange.
Test: fast/forms/file-input-hit-test.html
- editing/VisibleSelection.cpp: (WebCore::VisibleSelection::toNormalizedRange):
- rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::positionForPoint):
- rendering/RenderFileUploadControl.h:
2011-02-09 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
REGRESSION(r76107): Crash in VisibleSelection::toNormalizedRange
https://bugs.webkit.org/show_bug.cgi?id=54053
Added a test to ensure WebKit does not crash when a user clicks on a region immediately after a file
upload control.
- fast/forms/file-input-hit-test-expected.txt: Added.
- fast/forms/file-input-hit-test.html: Added.
- 17:55 Changeset [78167] by
-
Overlay scrollbars crash used with a RenderListBox.
Reviewed by Beth Dakin.
- rendering/RenderListBox.cpp:
(WebCore::RenderListBox::layout):
(WebCore::RenderListBox::contentsSize):
(WebCore::RenderListBox::currentMousePosition):
(WebCore::RenderListBox::setHasVerticalScrollbar):
- rendering/RenderListBox.h:
Implement enough of the ScrollableArea interface to get things generally
working.
- 17:30 Changeset [78166] by
-
Merge r77114
2011-01-30 Kenichi Ishibashi <bashi@google.com>
Reviewed by Kent Tamura.
Dangling form associated elements should not be registered on the document
https://bugs.webkit.org/show_bug.cgi?id=53223
Adds insertedIntoDocument() and remvoedFromDocument() to
FormAssociatedElement class to register the element on the document
if and only if it actually inserted into (removed from) the document.
Test: fast/forms/dangling-form-element-crash.html
- html/FormAssociatedElement.cpp: (WebCore::FormAssociatedElement::insertedIntoDocument): Added. (WebCore::FormAssociatedElement::removedFromDocument): Ditto. (WebCore::FormAssociatedElement::insertedIntoTree): Don't register the element to a document. (WebCore::FormAssociatedElement::removedFromTree): Don't unregister the element from a document.
- html/FormAssociatedElement.h:
- html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::insertedIntoDocument): Added. (WebCore::HTMLFormControlElement::removedFromDocument): Ditto.
- html/HTMLFormControlElement.h:
- html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::insertedIntoDocument): Calls FormAssociatedElement::insertedIntoDocument(). (WebCore::HTMLObjectElement::removedFromDocument): Calls FormAssociatedElement::removedFromDocument().
2011-01-30 Kenichi Ishibashi <bashi@google.com>
Reviewed by Kent Tamura.
Dangling form associated elements should not be registered on the document
https://bugs.webkit.org/show_bug.cgi?id=53223
Adds a test that ensures dangling form associated elements are not
registered on the document.
- fast/forms/dangling-form-element-crash-expected.txt: Added.
- fast/forms/dangling-form-element-crash.html: Added.
BUG=crbug.com/70078
TBR=inferno@chromium.org
- 17:28 Changeset [78165] by
-
Fix a typo in WebSecurityOrigin::protocol.
Rubber-stamped by Sam Weinig.
- Shared/WebSecurityOrigin.h:
(WebKit::WebSecurityOrigin::protocol): This should return the protocol, not the domain.
- 17:26 Changeset [78164] by
-
2011-02-09 Zhenyao Mo <zmo@google.com>
Unreviewed, test expectations update.
- platform/chromium/test_expectations.txt:
- 17:17 Changeset [78163] by
-
File uploads do not work within the sandbox
<rdar://problem/8950518>
https://bugs.webkit.org/show_bug.cgi?id=54154
Reviewed by Darin Adler.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didChooseFilesForOpenPanel):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::extendSandboxForFileFromOpenPanel):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
- 16:28 Changeset [78162] by
-
Fix for <rdar://problem/8966868> ScrollbarPainterDelegate
must return a layer if layer-backed to avoid crashing
Reviewed by Simon Fraser.
New virtual function scrollbarWillRenderIntoCompositingLayer()
on ScrollableArea.
- page/FrameView.h:
- platform/ScrollableArea.h:
(WebCore::ScrollableArea::scrollbarWillRenderIntoCompositingLayer):
- rendering/RenderLayer.h:
(WebCore::RenderLayer::scrollbarWillRenderIntoCompositingLayer):
- rendering/RenderListBox.cpp:
(WebCore::RenderListBox::scrollbarWillRenderIntoCompositingLayer):
- rendering/RenderListBox.h:
Clean up unnecessary method declarations and call
scrollbarWillRenderIntoCompositingLayer() to deterine if
we need to return a layer.
- platform/mac/ScrollAnimatorMac.mm:
(-[ScrollbarPainterDelegate layer]):
- 16:24 Changeset [78161] by
-
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=54148
<rdar://problem/8973887> REGRESSION (WebKit2): Opening two print dialogs causes havoc
- UIProcess/API/mac/WKPrintingView.h: Moved _isForcingPreviewUpdate into a static variable, because dispatching a notification affects all WKPrintingViews at once.
- UIProcess/API/mac/WKPrintingView.mm: (-[WKPrintingView _updatePreview]): Updated for new variable name. (-[WKPrintingView knowsPageRange:]): Don't break if the method is called twice in a row (we already had this logic when printing from separate thread, but not for preview). (-[WKPrintingView drawRect:]): Changed all LOG messages to have view object address for easier matching. (-[WKPrintingView rectForPage:]): Ditto. (-[WKPrintingView beginDocument]): Ditto. (-[WKPrintingView endDocument]): Ditto.
- 16:24 Changeset [78160] by
-
2011-02-09 Martin Robinson <mrobinson@igalia.com>
Rebaseline a few tests which differ on the bots. Skip a test which is
timing out intermittently.
- platform/gtk/Skipped: Skip a test timing out.
- platform/gtk/fast/block/float/marquee-shrink-to-avoid-floats-expected.txt:
- platform/gtk/fast/dom/52776-expected.txt:
- platform/gtk/fast/text/stroking-decorations-expected.txt:
- 16:09 Changeset [78159] by
-
2011-02-09 Dirk Pranke <dpranke@chromium.org>
Reviewed by Tony Chang.
nrwt multiprocessing: minor cleanup prior to implementing the new worker
This patch renames AbstractManager to ManagerConnection and
changes some argument names to be more consistent between
manager_worker_broker and message_broker. It also fixes a couple
of typos in message_broker. These changes will be tested by code
introduced in the next patch.
- Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
- Scripts/webkitpy/layout_tests/layout_package/message_broker2.py:
- 15:53 Changeset [78158] by
-
2011-02-09 Adam Barth <abarth@webkit.org>
Another attempt to fix the Qt Windows build.
- config.h:
- wtf/OSRandomSource.cpp: (WTF::randomValuesFromOS):
- 15:47 Changeset [78157] by
-
2011-02-09 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Repro crash with Sony Google TV ad at Gizmodo
https://bugs.webkit.org/show_bug.cgi?id=54150
Since PluginView::evaluate can cause the plug-in element to go away, we need to protect it.
- WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::~PluginView): Null out m_pluginElement here so we'll catch crashes earlier.
(WebKit::PluginView::evaluate):
Add a plug-in protector.
2011-02-09 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Repro crash with Sony Google TV ad at Gizmodo
https://bugs.webkit.org/show_bug.cgi?id=54150
<rdar://problem/8782346>
Add test.
- plugins/npruntime/evaluate-js-destroying-plugin-from-destroy-stream-expected.txt: Added.
- plugins/npruntime/evaluate-js-destroying-plugin-from-destroy-stream.html: Added.
2011-02-09 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Repro crash with Sony Google TV ad at Gizmodo
https://bugs.webkit.org/show_bug.cgi?id=54150
<rdar://problem/8782346>
Add a new plug-in test that runs JavaScript that destroys the plug-in from within its NPN_DestroyStream callback.
- DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
- DumpRenderTree/TestNetscapePlugIn/Tests/EvaluateJSDestroyingPluginFromDestroyStream.cpp: Added. (EvaluateJSDestroyingPluginFromDestroyStream::EvaluateJSDestroyingPluginFromDestroyStream): (EvaluateJSDestroyingPluginFromDestroyStream::NPP_Destroy): (EvaluateJSDestroyingPluginFromDestroyStream::NPP_DestroyStream):
- DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
- DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
- 15:35 Changeset [78156] by
-
2011-02-09 Adam Barth <abarth@webkit.org>
Attempt to fix the Qt Windows build.
- wtf/OSRandomSource.cpp: (WTF::randomValuesFromOS):
- 15:33 Changeset [78155] by
-
Merge 77114
BUG=70078
Review URL: http://codereview.chromium.org/6476015
- 15:25 Changeset [78154] by
-
2011-02-09 Martin Robinson <mrobinson@igalia.com>
Clean up the skipped list a bit and unskip a few tests which are passing.
- platform/gtk/Skipped: Clean up the skipped list.
- platform/gtk/editing/selection/extend-after-mouse-selection-expected.txt: Removed.
- platform/gtk/fast/dom/Window/window-properties-expected.txt: Removed.
- 15:23 Changeset [78153] by
-
Merge 76732
BUG=70779
Review URL: http://codereview.chromium.org/6471009
- 15:17 Changeset [78152] by
-
Merge 77468, crbug 69640
- 15:14 Changeset [78151] by
-
Merge 77468
BUG=69640
Review URL: http://codereview.chromium.org/6483007
- 15:13 Changeset [78150] by
-
2011-02-09 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Darin Adler.
Replace static_cast<HTMLElement*> with toHTMLElement
https://bugs.webkit.org/show_bug.cgi?id=54117
No new tests since no new functionality was introduced.
- accessibility/AccessibilityListBox.cpp: (WebCore::AccessibilityListBox::addChildren):
- accessibility/AccessibilityMenuListPopup.cpp: (WebCore::AccessibilityMenuListPopup::addChildren):
- accessibility/AccessibilityRenderObject.cpp: (WebCore::accessibleNameForNode): (WebCore::AccessibilityRenderObject::accessibilityDescription):
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_get_name): (webkit_accessible_get_description):
- bindings/gobject/WebKitDOMBinding.cpp: (WebKit::createWrapper): (WebKit::kit):
- bindings/js/JSElementCustom.cpp: (WebCore::toJSNewlyCreated):
- bindings/js/JSHTMLFrameSetElementCustom.cpp: (WebCore::JSHTMLFrameSetElement::nameGetter):
- bindings/js/JSNodeCustom.cpp: (WebCore::createWrapperInline):
- bindings/v8/custom/V8ElementCustom.cpp: (WebCore::toV8):
- dom/Document.cpp: (WebCore::Document::body):
- dom/Element.cpp: (WebCore::Element::deprecatedCreateContextualFragment):
- dom/Range.cpp: (WebCore::Range::createContextualFragment):
- editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyBlockStyle): (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange): (WebCore::ApplyStyleCommand::splitAncestorsWithUnicodeBidi): (WebCore::ApplyStyleCommand::applyInlineStyleToNodeRange): (WebCore::ApplyStyleCommand::removeStyleFromRunBeforeApplyingStyle): (WebCore::ApplyStyleCommand::highestAncestorWithConflictingInlineStyle): (WebCore::ApplyStyleCommand::applyInlineStyleToPushDown): (WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode): (WebCore::ApplyStyleCommand::removeInlineStyle): (WebCore::ApplyStyleCommand::shouldSplitTextElement): (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded):
- editing/DeleteButtonController.cpp: (WebCore::enclosingDeletableElement): (WebCore::DeleteButtonController::show):
- editing/Editor.cpp: (WebCore::Editor::setBaseWritingDirection):
- editing/InsertListCommand.cpp: (WebCore::InsertListCommand::mergeWithNeighboringLists):
- editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::negateStyleRulesThatAffectAppearance): (WebCore::ReplaceSelectionCommand::handleStyleSpans): (WebCore::ReplaceSelectionCommand::copyStyleToChildren):
- editing/SelectionController.cpp: (WebCore::scanForForm): (WebCore::SelectionController::currentForm):
- editing/htmlediting.cpp: (WebCore::enclosingList): (WebCore::enclosingListChild): (WebCore::embeddedSublist): (WebCore::appendedSublist):
- editing/markup.cpp: (WebCore::StyledMarkupAccumulator::appendElement):
- html/HTMLCollection.cpp: (WebCore::HTMLCollection::checkForNameMatch): (WebCore::HTMLCollection::updateNameCache):
- html/HTMLElement.cpp: (WebCore::HTMLElement::setOuterHTML): (WebCore::HTMLElement::shadowAncestorOwnerForm):
- html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::formElementIndex):
- html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::setOption): (WebCore::HTMLSelectElement::setLength):
- inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::getOuterHTML): (WebCore::InspectorDOMAgent::setOuterHTML):
- page/EventHandler.cpp: (WebCore::EventHandler::handleMouseMoveEvent):
- rendering/RenderMeter.cpp: (WebCore::RenderMeter::createPart):
- rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::createSubtreeIfNeeded):
- rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::createSubtreeIfNeeded):
- 15:11 Changeset [78149] by
-
2011-02-09 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Add WTF::cryptographicallyRandomNumber
https://bugs.webkit.org/show_bug.cgi?id=54083
Introduce a cryptographically strong random number generator to WTF.
The random number generator is based on arc4random as found in:
http://www.openbsd.org/cgi-bin/cvsweb/src/lib/libc/crypt/arc4random.c?rev=1.22
I've changed to source to WebKit style and abstracted the operating
system interaction to OSRandomSource. We'll use this functionality to
expose a cryptographically strong random number generator to
JavaScript.
- Android.mk:
- Android.v8.wtf.mk:
- GNUmakefile.am:
- JavaScriptCore.gypi:
- JavaScriptCore.vcproj/WTF/WTF.vcproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- config.h:
- wtf/CMakeLists.txt:
- wtf/CryptographicallyRandomNumber.cpp: Added. (WTF::initMutexIfNeeded): (WTF::init): (WTF::addRandomData): (WTF::stir): (WTF::stirIfNeeded): (WTF::getByte): (WTF::getWord): (WTF::cryptographicallyRandomNumber): (WTF::cryptographicallyRandomValues):
- wtf/CryptographicallyRandomNumber.h: Added.
- wtf/OSRandomSource.cpp: Added. (WTF::randomValuesFromOS):
- wtf/OSRandomSource.h: Added.
- wtf/wtf.pri:
- 15:10 Changeset [78148] by
-
2011-02-09 Mike Reed <reed@google.com>
Reviewed by Kenneth Russell.
Use Skia's device->readPixels() when its bitmap claims to have no pixels, as this
handles the case when the device is backed by the GPU.
Patch developed by bsalomon@google.com
No new tests. Existing canvas tests suffice
e.g. LayoutTests/canvas/philip/...
- platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::getImageData): (WebCore::ImageBuffer::getUnmultipliedImageData): (WebCore::ImageBuffer::getPremultipliedImageData): (WebCore::putImageData): (WebCore::ImageBuffer::putUnmultipliedImageData): (WebCore::ImageBuffer::putPremultipliedImageData):
- 15:07 Changeset [78147] by
-
2011-02-09 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
document.close shouldn't affect non-script-created parsers
https://bugs.webkit.org/show_bug.cgi?id=53689
Tests for various cases involving document.open/write/close. Not all
of them are related to this patch, but they were helpful to me in
working through this patch, so I've added them in case they're useful
in the future.
- fast/frames/document-write-in-iframe-onload-3-expected.txt: Added.
- fast/frames/document-write-in-iframe-onload-3.html: Added.
- fast/parser/iframe-onload-document-close-with-external-script-2-expected.txt: Added.
- fast/parser/iframe-onload-document-close-with-external-script-2.html: Added.
- fast/parser/iframe-onload-document-close-with-external-script-3-expected.txt: Added.
- fast/parser/iframe-onload-document-close-with-external-script-3.html: Added.
- fast/parser/iframe-onload-document-close-with-external-script-expected.txt: Added.
- fast/parser/iframe-onload-document-close-with-external-script.html: Added.
- fast/parser/setTimeout-open-expected.txt: Added.
- fast/parser/setTimeout-open.html: Added.
2011-02-09 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
document.close shouldn't affect non-script-created parsers
https://bugs.webkit.org/show_bug.cgi?id=53689
Tests: fast/frames/document-write-in-iframe-onload-3.html
fast/parser/iframe-onload-document-close-with-external-script-2.html
fast/parser/iframe-onload-document-close-with-external-script-3.html
fast/parser/iframe-onload-document-close-with-external-script.html
fast/parser/setTimeout-open.html
Move our implementation of document.close closer to the spec by
introducing the notion of a script-created parser. This area of our
code is somewhat hairy. It might take a few more iterations before we
fully come up to spec.
- dom/Document.cpp:
(WebCore::Document::setContent):
(WebCore::Document::open):
(WebCore::Document::cancelParsing):
(WebCore::Document::close):
- Over time, this method should converge to the spec.
(WebCore::Document::explicitClose):
- I'm not in love with this name. Somehow we want to differentiate between Document closing itself and the document.close DOM method.
(WebCore::Document::removePendingSheet):
- dom/Document.h:
- dom/ScriptableDocumentParser.cpp: (WebCore::ScriptableDocumentParser::ScriptableDocumentParser):
- dom/ScriptableDocumentParser.h:
(WebCore::ScriptableDocumentParser::setWasCreatedByScript):
(WebCore::ScriptableDocumentParser::wasCreatedByScript):
- General nonsense to keep track of whether the parser was created by script.
- html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::hasInsertionPoint):
- I'm not sure whether this part of the change is 100% correct. I think our notion of the EOF character might be subtly different from the notion in the spec.
- html/parser/HTMLInputStream.h:
(WebCore::HTMLInputStream::hasInsertionPoint):
- Remove FIXME because we're fixing that!
- 15:03 Changeset [78146] by
-
2011-02-09 Martin Robinson <mrobinson@igalia.com>
Import the last set of GTK+ baselines in the fast directory.
- platform/gtk/Skipped: Unskip test which now have results.
- 15:02 Changeset [78145] by
-
Google Maps says it has horizontal scrollbars when it doesn't
<rdar://problem/8978005>
Reviewed by Maciej Stachowiak.
We were updating the main frame's scrollbar state for changes to
frames other than the main frame.
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::contentsSizeChanged):
- WebProcess/WebCoreSupport/WebChromeClient.h:
(WebKit::WebChromeClient::WebChromeClient):
Change to bail out early if we are not looking at the main frame. Also
fix some silly typos and rename the variables to be more specific.
- 14:53 Changeset [78144] by
-
2011-02-09 David Holloway <dhollowa@chromium.org>
Reviewed by Darin Fisher.
Removes deprecated interface WebAutoFillClient::didAcceptAutocompleteSuggestion(). This interface has been replaced by the more general WebAutoFillClient::didAcceptAutoFillSuggestion() method.
https://bugs.webkit.org/show_bug.cgi?id=54125
- public/WebAutoFillClient.h:
- src/EditorClientImpl.cpp:
- src/EditorClientImpl.h:
- 14:41 Changeset [78143] by
-
2011-02-09 Abhishek Arya <inferno@chromium.org>
Reviewed by James Robinson.
[Chromium] Issue 72387: Integer bounds crash in LayerTilerChromium::resizeLayer
https://bugs.webkit.org/show_bug.cgi?id=54132
- platform/graphics/chromium/LayerTilerChromium.cpp: (WebCore::LayerTilerChromium::resizeLayer):
- 14:40 Changeset [78142] by
-
2011-02-09 Martin Robinson <mrobinson@igalia.com>
Continue importing new GTK+ results for tests in the fast directory.
- platform/gtk/Skipped: Unskip test which now have results.
- 14:39 Changeset [78141] by
-
Merge 77914
BUG=70442
Review URL: http://codereview.chromium.org/6480008
- 14:37 Changeset [78140] by
-
Merge 76652
BUG=70442
Review URL: http://codereview.chromium.org/6482007
- 14:36 Changeset [78139] by
-
2011-02-09 Ilya Sherman <isherman@chromium.org>
Reviewed by Darin Fisher.
Export WebInputElement::defaultMaxLength as a function rather than a constant.
Needed because the order of initialization of static constants
is not guaranteed across compilation units.
https://bugs.webkit.org/show_bug.cgi?id=54056
- public/WebInputElement.h:
- src/WebInputElement.cpp: (WebKit::WebInputElement::defaultMaxLength): Now a static function.
- 14:25 Changeset [78138] by
-
Unreviewed.
Remove unnecessary Qt specific expected results after r78104.
- platform/qt/editing/undo/undo-paste-when-caret-is-not-in-range-expected.checksum: Removed.
- platform/qt/editing/undo/undo-paste-when-caret-is-not-in-range-expected.png: Removed.
- platform/qt/editing/undo/undo-paste-when-caret-is-not-in-range-expected.txt: Removed.
- 14:23 Changeset [78137] by
-
2011-02-09 Xiyuan Xia <xiyuan@chromium.org>
Reviewed by Tony Chang.
[Chromium] Use #f7f7f7 for select popup background on chromium/linux
https://bugs.webkit.org/show_bug.cgi?id=54115
No new tests since no behavior change.
- css/themeChromiumLinux.css: (select[size="1"] option):
- 14:18 Changeset [78136] by
-
Merge r77548, crbug 71296
- 14:16 Changeset [78135] by
-
2011-02-09 Robert Hogan <robert@webkit.org>
Reviewed by Csaba Osztrogonác.
[Qt] REGRESSION (r73535): tst_QWebPage fails
https://bugs.webkit.org/show_bug.cgi?id=51331
Since r73535 a ContextMenu is only created when a context menu
event is received, so QWebPage::updatePositionDependentActions()
can't depend on one being there if it is called directly by
the client. QtWebKit itself only ever calls updatePositionDependentActions()
when a context menu event has been received.
Update tst_QWebPage:contextMenuCrash to create a context menu.
Add tst_QWebPage:updatePositionDependentActionsCrash to test for this crash.
There doesn't seem to be a good reason for creating a context menu if
clients call QWebPage::updatePositionDependentActions() when no
context menu event has ever been received.
- Api/qwebpage.cpp: (QWebPagePrivate::createContextMenu):
- tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::contextMenuCrash):
- 14:16 Changeset [78134] by
-
Merge 77548
BUG=71296
Review URL: http://codereview.chromium.org/6483004
- 14:13 Changeset [78133] by
- 14:13 Changeset [78132] by
-
2011-02-09 Zhenyao Mo <zmo@google.com>
Unreviewed, test expectations update.
- platform/chromium-win/editing/undo/undo-paste-when-caret-is-not-in-range-expected.txt: Removed.
- platform/chromium/test_expectations.txt:
- 14:10 Changeset [78131] by
-
Merge 77573
BUG=71855
Review URL: http://codereview.chromium.org/6482006
- 14:09 Changeset [78130] by
-
Merge 77565
BUG=71855
Review URL: http://codereview.chromium.org/6480006
- 14:04 Changeset [78129] by
-
2011-02-09 Zhenyao Mo <zmo@google.com>
Unreviewed, rebaseline.
- platform/chromium-win/editing/undo/undo-paste-when-caret-is-not-in-range-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- 14:02 Changeset [78128] by
-
2011-02-09 Martin Robinson <mrobinson@igalia.com>
Continue importing new GTK+ results for tests in the fast directory.
- platform/gtk/Skipped: Unskip test which now have results.
- 13:53 Changeset [78127] by
-
2011-02-09 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
REGRESSION(HTML 5): HTMLDocumentParser does not report html parse errors to the console
https://bugs.webkit.org/show_bug.cgi?id=41187
Wire up a basic HTML parse error message. There's a lot of room for
improvement in this area, but this is a start.
No tests! See https://bugs.webkit.org/show_bug.cgi?id=54134
- html/parser/HTMLDocumentParser.h:
- html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::parseError):
- html/parser/HTMLTreeBuilder.h:
- 13:36 Changeset [78126] by
-
2011-02-09 Ivan Krstić <ike@apple.com>
Reviewed by Sam Weinig.
Allow read-only access to mouse preferences from sandboxed WebProcess.
<rdar://problem/8975279>
- WebProcess/com.apple.WebProcess.sb:
- 13:36 Changeset [78125] by
-
Merge 77141
BUG=71114
Review URL: http://codereview.chromium.org/6478004
- 13:23 Changeset [78124] by
-
2011-02-09 Zhenyao Mo <zmo@google.com>
Unreviewed, test expectations update.
- platform/chromium/test_expectations.txt:
- 13:17 Changeset [78123] by
-
Merge 77262
BUG=71386
Review URL: http://codereview.chromium.org/6476009
- 13:15 Changeset [78122] by
-
2011-02-09 Martin Robinson <mrobinson@igalia.com>
Continue importing new GTK+ results for tests in the fast directory.
Skip some tests that are obvious failures.
- platform/gtk/Skipped: Unskip test with results. Classify failures.
- 13:15 Changeset [78121] by
-
Merge 77144
BUG=71388
Review URL: http://codereview.chromium.org/6480004
- 13:09 Changeset [78120] by
-
Merge 77433
BUG=71734
Review URL: http://codereview.chromium.org/6469012
- 13:06 Changeset [78119] by
-
Merge r78116.
- 13:05 Changeset [78118] by
-
Merge 77418
BUG=71595
Review URL: http://codereview.chromium.org/6476007
- 13:02 Changeset [78117] by
-
Merge 76990
BUG=68120
Review URL: http://codereview.chromium.org/6469011
- 12:59 Changeset [78116] by
-
Build fix.
- win/MainWin.cpp:
(wWinMain):
- 12:59 Changeset [78115] by
-
Merge 76708
BUG=67234
Review URL: http://codereview.chromium.org/6483002
- 12:57 Changeset [78114] by
-
Merge 78077 - 2011-02-08 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Darin Adler.
REGRESSION(r71934): Shadow DOM nodes leak via relatedTarget
https://bugs.webkit.org/show_bug.cgi?id=52065
- fast/events/shadow-boundary-crossing.html: Added relatedTarget retargeting test.
2011-02-08 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Darin Adler.
REGRESSION(r71934): Shadow DOM nodes leak via relatedTarget
https://bugs.webkit.org/show_bug.cgi?id=52065
- dom/Node.cpp: (WebCore::pullOutOfShadow): Added a helper to move a node to the outermost
boundary of shadow DOM.
(WebCore::Node::dispatchMouseEvent): Changed to use pullOutOfShadow.
TBR=dglazkov@chromium.org
Review URL: http://codereview.chromium.org/6469009
- 12:56 Changeset [78113] by
-
Merge 76915
BUG=71115
Review URL: http://codereview.chromium.org/6471003
- 12:52 Changeset [78112] by
-
Merge 76828
BUG=68741
Review URL: http://codereview.chromium.org/6469008
- 12:50 Changeset [78111] by
-
2011-02-09 Zhenyao Mo <zmo@google.com>
Unreviewed, rebaseline.
- platform/chromium-linux/fast/box-shadow/inset-box-shadows-expected.checksum: Added.
- platform/chromium-linux/fast/box-shadow/inset-box-shadows-expected.png: Added.
- platform/chromium-win/fast/box-shadow/inset-box-shadows-expected.checksum: Added.
- platform/chromium-win/fast/box-shadow/inset-box-shadows-expected.png: Added.
- platform/chromium-win/fast/box-shadow/inset-box-shadows-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- 12:50 Changeset [78110] by
-
Merge 76728
BUG=68263
Review URL: http://codereview.chromium.org/6483001
- 12:46 Changeset [78109] by
-
Merge 77766
BUG=72134
Review URL: http://codereview.chromium.org/6471002
- 12:22 Changeset [78108] by
-
Try to fix the build.
- wtf/Bitmap.h: Include string.h for memset. Not sure why this started
failing now.
- 12:15 Changeset [78107] by
-
2011-02-09 Adam Barth <abarth@webkit.org>
Reviewed by Steve Block.
Move Android.mk into Source
https://bugs.webkit.org/show_bug.cgi?id=53751
A somewhat blind attempt to move Android.mk into the Source directory.
I'm sure I've goofed this up in some way. The Android folks have
kindly volunteered to fix this up once they merge past this revision.
- Android.mk: Removed.
- Source/Android.mk: Copied from Android.mk.
- 12:15 Changeset [78106] by
-
2011-02-09 Sailesh Agrawal <sail@chromium.org>
Reviewed by Tony Chang.
Search/replace references to gfx/* with ui/gfx/*
- public/WebPoint.h:
- public/WebRect.h:
- public/WebSize.h:
- 12:09 Changeset [78105] by
-
2011-02-09 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
A tiny bit of encapsulation for MarkedBlock: made its heap data member private
https://bugs.webkit.org/show_bug.cgi?id=54129
- runtime/MarkedBlock.h: (JSC::MarkedBlock::isCellAligned): (JSC::MarkedBlock::MarkedBlock): (JSC::MarkedBlock::heap): Made the heap data member private, and provided a constructor and an accessor.
- runtime/MarkedSpace.cpp: (JSC::MarkedSpace::allocateBlock):
- runtime/MarkedSpace.h: (JSC::MarkedSpace::heap): Use the constructor and accessor.
- 12:08 Changeset [78104] by
-
2011-02-09 Jia Pu <jpu@apple.com>
Reviewed by Darin Adler.
VisibleSelection::setWithoutValidation() should allow caret selection.
https://bugs.webkit.org/show_bug.cgi?id=53943
Fixed the new test introduced in the previous patch for the same bug. Previous test isn't platform independent, and fails on all platforms other than Mac OS X with WebKit 1.
- editing/undo/undo-paste-when-caret-is-not-in-range-expected.txt:
- editing/undo/undo-paste-when-caret-is-not-in-range.html:
- 12:06 Changeset [78103] by
-
2011-02-09 Naoki Takano <takano.naoki@gmail.com>
Reviewed by Kenneth Russell.
[Chromium] Issue 58536: Fix Layout Test canvas/philip/tests/2d.imageData.put.alpha.html with --accelerated-2d-canvas.
https://bugs.webkit.org/show_bug.cgi?id=53757
This fix is for 2d.imageData.put.alpha.html with --accelerated-2d-canvas. No new tests.
- platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::ImageBuffer::putUnmultipliedImageData): needs to call syncSoftwareCanvas() to sync between hardware and software. (WebCore::ImageBuffer::putPremultipliedImageData): needs to call syncSoftwareCanvas() to sync between hardware and software.
- 12:03 Changeset [78102] by
-
2011-02-09 Chris Rogers <crogers@google.com>
Reviewed by Kenneth Russell.
Fix scaling and thread safety of FFTFrameFFTW
https://bugs.webkit.org/show_bug.cgi?id=54045
No new tests since audio API is not yet implemented.
- platform/audio/FFTFrame.h:
- platform/audio/fftw/FFTFrameFFTW.cpp: (WebCore::FFTFrame::FFTFrame): (WebCore::FFTFrame::doFFT): (WebCore::FFTFrame::doInverseFFT): (WebCore::FFTFrame::initialize): (WebCore::FFTFrame::cleanup): (WebCore::FFTFrame::realData): (WebCore::FFTFrame::imagData): (WebCore::FFTFrame::fftwPlanForSize):
- platform/audio/mac/FFTFrameMac.cpp: (WebCore::FFTFrame::initialize):
- platform/audio/mkl/FFTFrameMKL.cpp: (WebCore::FFTFrame::initialize):
- webaudio/AudioContext.cpp: (WebCore::AudioContext::AudioContext):
- 11:57 Changeset [78101] by
-
Merge r76728, crbug 68263
- 11:54 Changeset [78100] by
-
2011-02-09 David Levin <levin@chromium.org>
Reviewed by Eric Seidel.
check-webkit-style: The error message about NULL should be more clear for comments.
https://bugs.webkit.org/show_bug.cgi?id=53786
- Scripts/webkitpy/style/checkers/cpp.py: Clarified the error message.
- Scripts/webkitpy/style/checkers/cpp_unittest.py: Fixed the corresponding test.
- 11:52 Changeset [78099] by
-
Merge 77141, crbug 71114
- 11:49 Changeset [78098] by
-
AX: accessibilityShouldUseUniqueId doesn't need to be in the core AX object
https://bugs.webkit.org/show_bug.cgi?id=54126
Reviewed by Darin Adler.
This is a Mac-only accessibility API concept and doesn't belong in the core AX object.
- accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::node):
- accessibility/mac/AccessibilityObjectWrapper.mm:
(-[AccessibilityObjectWrapper accessibilityShouldUseUniqueId]):
- 11:48 Changeset [78097] by
-
2011-02-09 Martin Robinson <mrobinson@igalia.com>
Continue importing new GTK+ results for tests in the fast directory.
Skip some tests that are obvious failures.
- platform/gtk/Skipped: Unskip some tests that now have results.
- 11:46 Changeset [78096] by
-
Merge r77262, crbug 71386
- 11:43 Changeset [78095] by
-
2011-02-09 Nebojsa Ciric <cira@chromium.org>
Reviewed by Darin Fisher.
Implements Locale object of JavaScript internationalization API proposal, as an
v8 extension. Extension code is hosted in v8 project (src/extensions/experimental/i18n-extension.{cc,h})
and in this patch we just provide flags, tests and build rules for chromium port.
https://bugs.webkit.org/show_bug.cgi?id=49414
- fast/js/i18n-bindings-locale-expected.txt: Added.
- fast/js/i18n-bindings-locale.html: Added.
- fast/js/script-tests/i18n-bindings-locale.js: Added. (reportResult): (localeTests.this.defaultLocale): (localeTests.this.baseLocale): (localeTests.this.languageScriptLocale): (localeTests.this.languageScriptRegionLocale): (localeTests.this.languageScriptRegionExtensionLocale): (localeTests.this.languageScriptRegionDashUExtensionLocale): (localeTests.this.availableLocales): (localeTests.this.maximizedLocale): (localeTests.this.maximizedLocaleWithExtension): (localeTests.this.minimizedLocale): (localeTests.this.minimizedLocaleWithExtension): (localeTests.this.displayForBaseLocale): (localeTests.this.displayInSameLocale): (localeTests.this.displayInDifferentLocale): (localeTests.this.displayInCyrillicScript): (localeTests.this.displayInHebrewScript): (localeTests):
- platform/gtk/Skipped:
- platform/mac/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
2011-02-09 Nebojsa Ciric <cira@chromium.org>
Reviewed by Darin Fisher.
Implements Locale object of JavaScript internationalization API proposal, as an
v8 extension. Extension code is hosted in v8 project (src/extensions/experimental/i18n-extension.{cc,h})
and in this patch we just provide flags, tests and build rules for chromium port.
https://bugs.webkit.org/show_bug.cgi?id=49414
Test: fast/js/i18n-bindings-locale.html
- WebCore.gyp/WebCore.gyp:
- bindings/generic/RuntimeEnabledFeatures.cpp: (WebCore::RuntimeEnabledFeatures::experimentalI18NAPIEnabled):
- bindings/generic/RuntimeEnabledFeatures.h: (WebCore::RuntimeEnabledFeatures::setExperimentalI18NAPIEnabled):
- bindings/v8/V8DOMWindowShell.cpp: (WebCore::V8DOMWindowShell::createNewContext):
2011-02-09 Nebojsa Ciric <cira@chromium.org>
Reviewed by Darin Fisher.
Implements Locale object of JavaScript internationalization API proposal, as an
v8 extension. Extension code is hosted in v8 project (src/extensions/experimental/i18n-extension.{cc,h})
and in this patch we just provide flags, tests and build rules for chromium port.
https://bugs.webkit.org/show_bug.cgi?id=49414
- features.gypi:
- public/WebRuntimeFeatures.h:
- src/WebRuntimeFeatures.cpp: (WebKit::WebRuntimeFeatures::enableExperimentalI18NAPI): (WebKit::WebRuntimeFeatures::isExperimentalI18NAPIEnabled):
2011-02-09 Nebojsa Ciric <cira@chromium.org>
Reviewed by Darin Fisher.
Implements Locale object of JavaScript internationalization API proposal, as an
v8 extension. Extension code is hosted in v8 project (src/extensions/experimental/i18n-extension.{cc,h})
and in this patch we just provide flags, tests and build rules for chromium port.
https://bugs.webkit.org/show_bug.cgi?id=49414
- DumpRenderTree/chromium/TestShell.cpp: (TestShell::TestShell):
- 11:42 Changeset [78094] by
-
Merge r77144, crbug 71388
- 11:38 Changeset [78093] by
-
Merge r77433, crbug 71734
- 11:35 Changeset [78092] by
-
2011-02-09 Zhenyao Mo <zmo@google.com>
Unreviewed, fix a bug in test_expectations.txt.
- platform/chromium/test_expectations.txt:
- 11:32 Changeset [78091] by
-
Merge r77766, crbug 72134
- 11:27 Changeset [78090] by
-
Merge r77418, crbug 71595
- 11:23 Changeset [78089] by
-
2011-02-09 Xiaomei Ji <xji@chromium.org>
Unreviewed.
Rebaseline for chromium-mac after r77952.
Added chromium-mac baseline due to fallback sequence.
- platform/chromium-mac/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- 11:19 Changeset [78088] by
-
2011-02-09 Zhenyao Mo <zmo@google.com>
Unreviewed, test expectations update.
- platform/chromium/test_expectations.txt:
- 11:15 Changeset [78087] by
-
Merge r76915, crbug 71115
- 11:09 Changeset [78086] by
-
Merge r76828, bug 68741, layouttests
- 11:06 Changeset [78085] by
-
2011-02-09 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Martin Robinson.
frames/flattening/iframe-flattening-crash.html fails on GTK.
https://bugs.webkit.org/show_bug.cgi?id=54106
Modify the test to be more consistent with other frame flattening tests.
- fast/frames/flattening/iframe-flattening-crash.html:
- fast/frames/flattening/resources/iframe-flattening-crash.html: Removed.
- platform/gtk/Skipped:
- 11:05 Changeset [78084] by
-
Merge r76828, bug 68741
- 10:54 Changeset [78083] by
-
Merge r78045.
- 10:50 Changeset [78082] by
-
Add failing Windows expected results for tests that were added recently and have failed since
they were added.
https://bugs.webkit.org/show_bug.cgi?id=54120 tracks editing/undo/undo-paste-when-caret-is-not-in-range.html
https://bugs.webkit.org/show_bug.cgi?id=54122 tracks plugins/invalidate_rect.html
- platform/win/editing/undo: Added.
- platform/win/editing/undo/undo-paste-when-caret-is-not-in-range-expected.txt: Added.
- platform/win/plugins/invalidate_rect-expected.txt: Added.
- 10:48 Changeset [78081] by
-
Versioning.
- 10:41 Changeset [78080] by
-
2011-02-09 Zhenyao Mo <zmo@google.com>
Unreviewed, test expectations.
- platform/chromium/test_expectations.txt:
- 10:38 Changeset [78079] by
-
2011-02-09 Martin Robinson <mrobinson@igalia.com>
Add more results for many tests in the fast directory missing results.
- platform/gtk/Skipped: Unskip more tests.
- 10:04 Changeset [78078] by
-
New tag.
- 10:03 Changeset [78077] by
-
2011-02-08 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Darin Adler.
REGRESSION(r71934): Shadow DOM nodes leak via relatedTarget
https://bugs.webkit.org/show_bug.cgi?id=52065
- fast/events/shadow-boundary-crossing.html: Added relatedTarget retargeting test.
2011-02-08 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Darin Adler.
REGRESSION(r71934): Shadow DOM nodes leak via relatedTarget
https://bugs.webkit.org/show_bug.cgi?id=52065
- dom/Node.cpp: (WebCore::pullOutOfShadow): Added a helper to move a node to the outermost
boundary of shadow DOM.
(WebCore::Node::dispatchMouseEvent): Changed to use pullOutOfShadow.
- 10:03 Changeset [78076] by
-
2011-02-09 Martin Robinson <mrobinson@igalia.com>
Add more results for many tests in the fast directory missing results.
- platform/gtk/Skipped: Unskip tests that now have results.
- 10:00 Changeset [78075] by
-
2011-02-09 Zhenyao Mo <zmo@google.com>
Unreviewed, test expectations update.
- platform/chromium/test_expectations.txt
- 09:52 Changeset [78074] by
-
2011-02-09 Amruth Raj <amruthraj@motorola.com> and Ravi Phaneendra Kasibhatla <ravi.kasibhatla@motorola.com>
Reviewed by Martin Robinson.
[GTK] Implement Module class for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=48510
- GNUmakefile.am:
- Platform/Module.h: Added GModule handle for GTK port.
- Platform/gtk/ModuleGtk.cpp: Initial code using GModule calls. (WebKit::Module::load): (WebKit::Module::unload): (WebKit::Module::platformFunctionPointer):
- 09:46 Changeset [78073] by
-
2011-02-09 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Darin Adler.
Add convenience method toHTMLElement(Node*)
https://bugs.webkit.org/show_bug.cgi?id=54105
No new tests since no new functionality introduced.
- html/HTMLElement.h: (WebCore::toHTMLElement):
- 09:45 Changeset [78072] by
-
2011-02-09 Chandra Vallala <chandra.vallala@motorola.com> and Alejandro G. Castro <alex@igalia.com>
Reviewed by Martin Robinson.
[GTK] Implement WKBaseGtk API for Webkit2
https://bugs.webkit.org/show_bug.cgi?id=54081
- GNUmakefile.am: Added new files to compilation.
- Shared/API/c/WKBase.h: Included WKBaseGtk.h in this file.
- Shared/API/c/gtk: Added.
- Shared/API/c/gtk/WKBaseGtk.h: Added. Declaration of WKViewRef for GTK port.
- UIProcess/API/C/WKAPICast.h: Included WKAPICastGtk.h in this file.
- UIProcess/API/C/gtk: Added.
- UIProcess/API/C/gtk/WKAPICastGtk.h: Added. Type definition template for WKViewRef to WebView and vice-versa.
- UIProcess/API/C/gtk/WKView.cpp: Added. Implementation of WKView API interface. (WKViewCreate): (WKViewGetWindow): (WKViewGetPage): (WKURLCreateWithURL):
- UIProcess/API/C/gtk/WKView.h: Added. Declaration of WKView API interface.
- 09:41 Changeset [78071] by
-
2011-02-09 Martin Robinson <mrobinson@igalia.com>
Add test results for many tests in the fast directory missing results.
- platform/gtk/Skipped: Unskip tests with results.
- 09:35 Changeset [78070] by
-
Unreviewed translation file.
Update Simplified Chinese (zh_CN) translation of WebKitGtk
https://bugs.webkit.org/show_bug.cgi?id=42496
- zh_CN.po: Updated.
- 09:33 Changeset [78069] by
-
2011-02-09 Alejandro G. Castro <alex@igalia.com>
Reviewed by Martin Robinson.
[GTK] Add WebGraphicsContext stub to the compilation
https://bugs.webkit.org/show_bug.cgi?id=54078
- GNUmakefile.am:
- Shared/API/c/gtk/WKGraphicsContextGtk.cpp: Added stub just for compilation. (WKGraphicsContextGetGtkContext):
- Shared/API/c/gtk/WKGraphicsContextGtk.h: Added stub just for compilation.
- Shared/WebGraphicsContext.cpp: (WebKit::WebGraphicsContext::WebGraphicsContext):
- Shared/WebGraphicsContext.h: (WebKit::WebGraphicsContext::platformContext):
- 09:30 Changeset [78068] by
-
Please add Greek translation of WebkitGTK+
https://bugs.webkit.org/show_bug.cgi?id=34482
- gr.po: Added.
- 09:27 Changeset [78067] by
-
Unreviewed translation file.
Arabic translation
https://bugs.webkit.org/show_bug.cgi?id=36340
- ar.po: Added.
- 09:25 Changeset [78066] by
-
Fixed positioned elements at very top or bottom of page remain fixed but clip during rubber-banding
<rdar://problem/7615997>
https://bugs.webkit.org/show_bug.cgi?id=54054
Reviewed by Dan Bernstein.
Take the overhang into account when calculating position for elements with position: fixed.
- platform/ScrollView.cpp:
(WebCore::ScrollView::scrollXForFixedPosition):
(WebCore::ScrollView::scrollYForFixedPosition):
(WebCore::ScrollView::scrollOffsetForFixedPosition):
- platform/ScrollView.h:
- rendering/RenderView.cpp:
(WebCore::RenderView::mapLocalToContainer):
(WebCore::RenderView::mapAbsoluteToLocalPoint):
(WebCore::RenderView::computeRectForRepaint):
- 09:24 Changeset [78065] by
-
2011-02-09 Alejandro G. Castro <alex@igalia.com>
Reviewed by Martin Robinson.
[GTK] Add geolocation support to the webkit2 compilation
https://bugs.webkit.org/show_bug.cgi?id=54077
Add Geolocation files to the GTK compilation.
- GNUmakefile.am:
- 09:21 Changeset [78064] by
-
Unreviewed translation file.
Attached is the Bulgarian translation of WebKit Gtk
https://bugs.webkit.org/show_bug.cgi?id=44400
- bg.po: Added.
- 09:17 Changeset [78063] by
-
Unreviewed translation file.
[l10n] Indonesian translation
https://bugs.webkit.org/show_bug.cgi?id=46455
- id.po: Added.
- 09:13 Changeset [78062] by
-
2011-02-09 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dirk Schulze.
Enhance ShadowBlur to tile inset box shadows
https://bugs.webkit.org/show_bug.cgi?id=51567
Add a tiling code path to ShadowBlur for rendering inset
box-shadows.
Test: fast/box-shadow/inset-box-shadows.html
- platform/graphics/ShadowBlur.cpp: (WebCore::computeSliceSizesFromRadii): Compute the slice sizes for the eight-piece shadow template. (WebCore::ShadowBlur::templateSize): Compute the size of the template, given the slice sizes. (WebCore::ShadowBlur::drawRectShadow): Bail early if layerRect is empty (which probably means we're clipped out). Call templateSize() and use the result to decide whether to tile. (WebCore::ShadowBlur::drawInsetShadow): New method for inset shadows. (WebCore::ShadowBlur::drawRectShadowWithoutTiling): Code moved. (WebCore::ShadowBlur::drawInsetShadowWithoutTiling): The non-tiling code path for inset shadows. (WebCore::ShadowBlur::drawInsetShadowWithTiling): Fill the shadow template buffer, paint the non-blurred area of the destination, and then call drawLayerPieces() to paint the eight-piece template image. (WebCore::ShadowBlur::drawRectShadowWithTiling): Refactored code, now shares the blurring code via blurAndColorShadowBuffer(), and the tiled template drawing via drawLayerPieces(). (WebCore::ShadowBlur::drawLayerPieces): Draw an eight-piece image from the shadow template to the destination. (WebCore::ShadowBlur::blurAndColorShadowBuffer): Blur the pixels in the image buffer, and colorize them using the CompositeSourceIn operation.
- platform/graphics/ShadowBlur.h:
- 09:13 Changeset [78061] by
-
2011-02-09 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Remove UiTools dependency from MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=54096
- MiniBrowser/qt/MiniBrowser.pro:
- 09:12 Changeset [78060] by
-
Unreviewed translation file.
[l10n] Polish translation of WebKitGTK+
https://bugs.webkit.org/show_bug.cgi?id=46567
- pl.po: Added.
- 09:06 Changeset [78059] by
-
Unreviewed translation file.
[Gtk] Please add Hungarian translation
https://bugs.webkit.org/show_bug.cgi?id=34543
- hu.po: Added.
- 09:03 Changeset [78058] by
-
2011-02-09 Jochen Eisinger <jochen@chromium.org>
Reviewed by Adam Barth.
Disable script elements when a CSP header is present
https://bugs.webkit.org/show_bug.cgi?id=53867
- http/tests/security/contentSecurityPolicy/no-policy-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/no-policy.html: Added.
- http/tests/security/contentSecurityPolicy/resources/echo-iframe.pl: Added.
- http/tests/security/contentSecurityPolicy/resources/echo-script-src.pl: Added.
- http/tests/security/contentSecurityPolicy/resources/redir.php: Added.
- http/tests/security/contentSecurityPolicy/resources/script-src.html: Added.
- http/tests/security/contentSecurityPolicy/resources/script.js: Added.
- http/tests/security/contentSecurityPolicy/script-src-in-iframe-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/script-src-in-iframe.html: Added.
- http/tests/security/contentSecurityPolicy/script-src-none-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/script-src-none.html: Added.
- http/tests/security/contentSecurityPolicy/script-src-redirect-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/script-src-redirect.html: Added.
2011-02-09 Jochen Eisinger <jochen@chromium.org>
Reviewed by Adam Barth.
Disable script elements when a CSP header is present
https://bugs.webkit.org/show_bug.cgi?id=53867
Tests: http/tests/security/contentSecurityPolicy/no-policy.html
http/tests/security/contentSecurityPolicy/script-src-in-iframe.html
http/tests/security/contentSecurityPolicy/script-src-none.html
http/tests/security/contentSecurityPolicy/script-src-redirect.html
- html/parser/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::shouldLoadExternalScriptFromSrc):
- html/parser/HTMLScriptRunner.cpp: (WebCore::HTMLScriptRunner::requestPendingScript):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::didBeginDocument):
- loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::didReceiveResponse):
- page/ContentSecurityPolicy.cpp: (WebCore::ContentSecurityPolicy::ContentSecurityPolicy): (WebCore::ContentSecurityPolicy::didReceiveHeader): (WebCore::ContentSecurityPolicy::canLoadExternalScriptFromSrc):
- page/ContentSecurityPolicy.h:
- 08:56 Changeset [78057] by
-
2011-02-09 Patrick Gansterer <paroga@webkit.org>
Unreviewed WinCE build fix for r78047.
ContextMenu.cpp and ContextMenuItem.cpp have a USE(CROSS_PLATFORM_CONTEXT_MENUS),
so they shouldn't cause problems with correct preprocessor defines.
- CMakeLists.txt:
- 08:32 Changeset [78056] by
-
2011-02-09 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: InspectorAgent should know nothing about InspectorController instance.
- inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::InspectorAgent): (WebCore::InspectorAgent::restoreInspectorStateFromCookie): (WebCore::InspectorAgent::disconnectFrontend):
- inspector/InspectorAgent.h:
- inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::disconnectFrontend): (WebCore::InspectorController::restoreInspectorStateFromCookie):
- 07:48 Changeset [78055] by
-
2011-02-09 Andras Becsi <abecsi@webkit.org>
Reviewed by Csaba Osztrogonác.
[Qt][WK2] Don't generate superfluous forwarding header for config.h.
- Scripts/generate-forwarding-headers.pl:
- 07:45 Changeset [78054] by
-
Hide the ugly details of WebView::m_window initialization from WebPageProxy, and make it less ugly
WebView::WebView was initially creating a hidden window, then showing it. It would tell
WebPageProxy about the window while it was still hidden, and then have to inform
WebPageProxy that the window had become shown. This resulted in WebPageProxy sending
unnecessary messages to the web process, and confused code that assumed that the window
would be in the same state after WebView's constructor exited as it was when WebPageProxy
first found out about the window.
We now don't hide the window when creating it, which simplifies the code, and only tell
WebPageProxy about the window after we're done modifying it, which fixes the bug.
Fixes <http://webkit.org/b/53878> <rdar://problem/8977306> Assertion failure in
DrawingAreaImpl::resumePainting after window.open or when opening Web Inspector
Reviewed by Anders Carlsson.
- UIProcess/win/WebView.cpp:
(WebKit::WebView::WebView): Changed ::CreateWindowEx to ::CreateWindowExW, to match other
Win32 API calls in WebKit2. Pass WS_VISIBLE to ::CreateWindowExW rather than waiting until
later to show the window. Added an assertion that m_isVisible matches the window's visible
state. Don't even create our WebPageProxy, or tell it about our window, until we're done
initializing our window, so that it doesn't get informed about our window's internal state
changes that happen beneath ::CreateWindowExW.
(WebKit::WebView::onSizeEvent): Null-check m_page since we can receive this message beneath
::CreateWindowExW.
(WebKit::WebView::onShowWindowEvent): Ditto. Replaced one FIXME with another. Always set
handled to false so that ::DefWindowProcW can do its thing. (MSDN says this is when it
actually shows/hides the window, though I couldn't find any consequences of not calling
::DefWindowProcW here.)
- 07:28 Changeset [78053] by
-
2011-02-09 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: source frame scroll position is not restored.
https://bugs.webkit.org/show_bug.cgi?id=54101
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._scriptSourceChanged):
- inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype.show): (WebInspector.SourceFrame.prototype.hide): (WebInspector.SourceFrame.prototype.get scrollTop): (WebInspector.SourceFrame.prototype.set scrollTop):
- inspector/front-end/TextViewer.js: (WebInspector.TextViewer.prototype.get scrollTop): (WebInspector.TextViewer.prototype.set scrollTop): (WebInspector.TextViewer.prototype.get scrollLeft): (WebInspector.TextViewer.prototype.set scrollLeft):
- 06:48 Changeset [78052] by
-
2011-02-09 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: follow up on InspectorAgent split -
removing unnecessary methods from InspectorController.
https://bugs.webkit.org/show_bug.cgi?id=54093
- WebCore.exp.in:
- inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::stopUserInitiatedProfiling): (WebCore::InspectorAgent::showAndEnableDebugger): (WebCore::InspectorAgent::enabled): (WebCore::InspectorAgent::showConsole):
- inspector/InspectorAgent.h:
- inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::didClearWindowObjectInWorld): (WebCore::InspectorController::showConsole): (WebCore::InspectorController::enabled): (WebCore::InspectorController::inspectedPage):
- inspector/InspectorController.h:
- inspector/InspectorFrontendClientLocal.cpp:
2011-02-09 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: follow up on InspectorAgent split -
removing unnecessary methods from InspectorController.
https://bugs.webkit.org/show_bug.cgi?id=54093
- WebInspector/WebInspector.mm: (-showConsole:): (-stopProfilingJavaScript:):
2011-02-09 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: follow up on InspectorAgent split -
removing unnecessary methods from InspectorController.
https://bugs.webkit.org/show_bug.cgi?id=54093
- WebInspector.cpp: (WebInspector::showConsole): (WebInspector::toggleProfilingJavaScript):
2011-02-09 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: follow up on InspectorAgent split -
removing unnecessary methods from InspectorController.
https://bugs.webkit.org/show_bug.cgi?id=54093
- WebProcess/WebPage/WebInspector.cpp: (WebKit::WebInspector::showConsole): (WebKit::WebInspector::stopJavaScriptProfiling):
- 06:09 Changeset [78051] by
-
2011-02-07 Chris Marrin <cmarrin@apple.com>
Reviewed by Simon Fraser.
LayoutTests/animations/play-state.html has wrong behavior with accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=53513
The PlatformCAAnimation::create() function which took a pointer to another
PlatformCAAnimation was supposed to make a copy of that passed object.
But it was doing completely the wrong thing on Mac and was leaking an object
to boot. And the notion of copying an object using a static creation function
is wrong in the first place. So I changed it to a member copy() function
which would create a new PlatformCAAnimation which was a copy of 'this' and
return it. I changed the implementation on both Mac and Win to match.
This problem was not caught by DRT, even there is a specific test for it.
That test just verifies that the higher level logic is working
properly, which it is. There's no practical way to find out if the
layer is currently animating. There is no logic which probes that
deeply into the layer mechanics.
- platform/graphics/ca/GraphicsLayerCA.cpp:
- platform/graphics/ca/PlatformCAAnimation.h:
- platform/graphics/ca/mac/PlatformCAAnimationMac.mm:
- platform/graphics/ca/win/PlatformCAAnimationWin.cpp:
- 06:07 Changeset [78050] by
-
2011-02-09 Shinichiro Hamaji <hamaji@chromium.org>
Chromium expectations update.
fast/dom/HTMLAnchorElement/set-href-attribute-hash.html is failing.
- platform/chromium/test_expectations.txt:
- 05:59 Changeset [78049] by
-
DevTools: fix poor merge that resulted in calling into setDocument twice.
I am not doing it using drover since InspectorController has been renamed since the branch point.
BUG=72422
TBR=yurys
- 05:55 Changeset [78048] by
-
2011-02-09 Shinichiro Hamaji <hamaji@chromium.org>
Chromium: update expectations
plugins/invalidate_rect is failing on linux and win, too.
plugins/invalidate_rect.html fails on chromium-mac
https://bugs.webkit.org/show_bug.cgi?id=54051
- platform/chromium/test_expectations.txt:
- 05:51 Changeset [78047] by
-
2011-02-09 Lucas De Marchi <lucas.demarchi@profusion.mobi>
Unreviewed build fix.
[EFL] Remove double definition of ContextMenu.
https://bugs.webkit.org/show_bug.cgi?id=50762
When building with SHARED_CORE enabled, the symbols of ContextMenu
were both in webkit and webcore. This removes them from webcore and
shall be put back once the CROSS_PLATFORM_CONTEXT_MENUS is implemented
in EFL port.
No new tests because no new functionality.
- CMakeLists.txt:
- 04:40 Changeset [78046] by
-
2011-02-09 Ilya Tikhonovsky <loislo@chromium.org>
Unreviewed.
Chromium: Create expectations for residual-style.html see r77781.
- platform/chromium-linux/fast/invalid/residual-style-expected.txt:
- platform/chromium-win/fast/invalid/residual-style-expected.txt:
- platform/chromium/test_expectations.txt:
- 04:27 Changeset [78045] by
-
Windows Production build fix
- WebCore.vcproj/QTMovieWinCommon.vsprops: Link against
WebKitSystemInterface$(WebKitConfigSuffix).lib, not just WebKitSystemInterface.lib, so we
pick up the _debug variant when appropriate.
- 04:13 Changeset [78044] by
-
2011-02-09 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Hostnames should cannonicalize to lowercase (to match every other browser)
https://bugs.webkit.org/show_bug.cgi?id=54084
Pretty obvious change. KURL is the odd man out here.
- fast/url/host-expected.txt:
- fast/url/ipv4-expected.txt:
- fast/url/ipv6-expected.txt:
- fast/url/relative-expected.txt:
- fast/url/relative-unix-expected.txt:
- fast/url/standard-url-expected.txt:
2011-02-09 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Hostnames should cannonicalize to lowercase (to match every other browser)
https://bugs.webkit.org/show_bug.cgi?id=54084
- platform/KURL.cpp: (WebCore::KURL::parse):
- 04:04 Changeset [78043] by
-
2011-02-09 Sergio Villar Senin <svillar@igalia.com>
Unreviewed.
Added new text expectations for GTK port. They should be actually
valid for any port using the libsoup backend. We need different
results because as stated here
https://bugs.webkit.org/show_bug.cgi?id=3812#c6, the original test
results were designed for NSURLConnection which adds the
"Content-Length: 0" header for null message bodies. That does not
happen in libsoup, so instead of artificially add that header we
better generate different results.
Also take into account that for HEAD and GET requests the body is
not included so we should expect always a null for them.
- platform/gtk/Skipped:
- platform/gtk/http/tests/xmlhttprequest/methods-async-expected.txt: Added.
- platform/gtk/http/tests/xmlhttprequest/methods-expected.txt: Added.
- platform/gtk/http/tests/xmlhttprequest/workers/methods-async-expected.txt: Added.
- platform/gtk/http/tests/xmlhttprequest/workers/methods-expected.txt: Added.
- platform/gtk/http/tests/xmlhttprequest/workers/shared-worker-methods-async-expected.txt: Added.
- platform/gtk/http/tests/xmlhttprequest/workers/shared-worker-methods-expected.txt: Added.
- 04:00 Changeset [78042] by
-
Replace PCRE with Yarr in WebCore
https://bugs.webkit.org/show_bug.cgi?id=53496
Reviewed by Gavin Barraclough.
Rollback r77626 with windows build fix.
Source/JavaScriptCore:
- JavaScriptCore.exp:
- JavaScriptCore.gyp/JavaScriptCore.gyp:
- JavaScriptCore.gypi:
- JavaScriptCore.pro:
- JavaScriptCore.xcodeproj/project.pbxproj:
- create_regex_tables:
- runtime/RegExp.cpp:
- wtf/Platform.h:
- yarr/Yarr.h:
- yarr/YarrJIT.cpp:
- yarr/YarrJIT.h:
- yarr/YarrParser.h:
- yarr/YarrPattern.h:
- yarr/YarrSyntaxChecker.h:
- yarr/yarr.pri: Added.
Source/WebCore:
No new tests needed.
- Android.jscbindings.mk:
- CMakeLists.txt:
- ForwardingHeaders/pcre/pcre.h: Removed.
- ForwardingHeaders/yarr/Yarr.h: Added.
- ForwardingHeaders/yarr/YarrInterpreter.h: Added.
- ForwardingHeaders/yarr/YarrPattern.h: Added.
- WebCore.gyp/WebCore.gyp:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcproj/copyForwardingHeaders.cmd:
- platform/text/RegularExpression.cpp:
(WebCore::RegularExpression::Private::create):
(WebCore::RegularExpression::Private::Private):
(WebCore::RegularExpression::Private::compile):
(WebCore::RegularExpression::match):
- 03:54 Changeset [78041] by
-
2011-02-09 Gyuyoung Kim <gyuyoung.kim@samsung.com>
Reviewed by Eric Seidel.
[EFL] Add dummy functions for HTML5 Video's control UI
https://bugs.webkit.org/show_bug.cgi?id=53906
In WebKit EFL, there are no implementations for HTML5 control UI.
First, dummy functions are added.
- platform/efl/RenderThemeEfl.cpp: (WebCore::RenderThemeEfl::extraMediaControlsStyleSheet): (WebCore::RenderThemeEfl::formatMediaControlsCurrentTime): (WebCore::RenderThemeEfl::paintMediaFullscreenButton): (WebCore::RenderThemeEfl::paintMediaMuteButton): (WebCore::RenderThemeEfl::paintMediaPlayButton): (WebCore::RenderThemeEfl::paintMediaSeekBackButton): (WebCore::RenderThemeEfl::paintMediaSeekForwardButton): (WebCore::RenderThemeEfl::paintMediaSliderTrack): (WebCore::RenderThemeEfl::paintMediaSliderThumb): (WebCore::RenderThemeEfl::paintMediaVolumeSliderContainer): (WebCore::RenderThemeEfl::paintMediaVolumeSliderTrack): (WebCore::RenderThemeEfl::paintMediaVolumeSliderThumb): (WebCore::RenderThemeEfl::paintMediaCurrentTime):
- platform/efl/RenderThemeEfl.h:
- 03:53 Changeset [78040] by
-
2011-02-09 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Make WebKit's fragment cannonicalization match other browsers
https://bugs.webkit.org/show_bug.cgi?id=53850
- fast/dom/HTMLAnchorElement/set-href-attribute-hash.html: Updated to match IE/Chrome
- fast/dom/HTMLAnchorElement/set-href-attribute-hash-expected.txt: Updated to match IE/Chrome.
- fast/url/anchor-expected.txt:
- "hello world": Our new behavior here matches IE and Chrome, but diverges from FF.
- The last two tests involving #, we were the odd man out. Now match all browsers.
- fast/url/segments-expected.txt:
- Don't percent encode spaces in fragments (to match other browsers)
- WebKit was the only engine encoding # in fragments.
- fast/url/segments-from-data-url-expected.txt:
2011-02-09 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Make WebKit's fragment cannonicalization match other browsers
https://bugs.webkit.org/show_bug.cgi?id=53850
This doesn't make us match perfectly, but it brings us closer.
- platform/KURL.cpp: (WebCore::appendEscapingBadChars): (WebCore::escapeAndAppendFragment): (WebCore::KURL::parse):
- 03:37 Changeset [78039] by
-
Unreviewed.
[Qt] Fix crashes in QMetaObject::metacall
https://bugs.webkit.org/show_bug.cgi?id=53912
One more attempt to make Qt buildbot happier and make sheriffbot
not to spam innocent people because of this flakey crash.
- platform/qt/Skipped: Add websocket directory instead of individual tests until fix.
- 03:20 Changeset [78038] by
-
[Qt] fast/dom/nodesFromRect-links-and-text.html crashes in debug mode
https://bugs.webkit.org/show_bug.cgi?id=53921
Patch by Robert Hogan <robert@webkit.org> on 2011-02-09
Reviewed by Antonio Gomes.
QDRTNode needs a copy constructor and an operator= in order to keep
proper refcounts.
- WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(:m_node):
(QDRTNode::operator=):
(DumpRenderTreeSupportQt::nodesFromRect):
- WebCoreSupport/DumpRenderTreeSupportQt.h:
- 02:58 Changeset [78037] by
-
2011-02-09 Ilya Tikhonovsky <loislo@chromium.org>
Unreviewed.
Chromium: Rebaseline html5lib/runner.html expectations after r77781.
- platform/chromium/html5lib/runner-expected.txt:
- platform/chromium/test_expectations.txt:
- 02:37 Changeset [78036] by
-
2011-02-09 Alexander Pavlov <apavlov@chromium.org>
Unreviewed. Add Web Inspector stylesheet resource diff screenshot.
- blog-files/inspector/css_rule_diff.png: Added.
- 02:33 Changeset [78035] by
-
2011-02-09 Hans Wennborg <hans@chromium.org>
Reviewed by Jeremy Orlow.
IndexedDB: Cursors should skip deleted entries
https://bugs.webkit.org/show_bug.cgi?id=53690
Cursors should skip over entries that have been deleted
since the cursor was opened.
- storage/indexeddb/cursor-skip-deleted-expected.txt: Added.
- storage/indexeddb/cursor-skip-deleted.html: Added.
2011-02-09 Hans Wennborg <hans@chromium.org>
Reviewed by Jeremy Orlow.
IndexedDB: Cursors should skip deleted entries
https://bugs.webkit.org/show_bug.cgi?id=53690
Add test to check that the cursor skips deleted entries.
Test: storage/indexeddb/cursor-skip-deleted.html
- storage/IDBCursorBackendImpl.cpp: (WebCore::IDBCursorBackendImpl::currentRowExists): (WebCore::IDBCursorBackendImpl::continueFunctionInternal):
- storage/IDBCursorBackendImpl.h:
- 02:12 Changeset [78034] by
-
2011-02-08 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: script formatter should not create a worker for each script.
https://bugs.webkit.org/show_bug.cgi?id=54010
- inspector/front-end/ScriptFormatter.js: (WebInspector.ScriptFormatter): (WebInspector.ScriptFormatter.prototype._formatScript): (WebInspector.ScriptFormatter.prototype._handleMessage): (WebInspector.ScriptFormatter.prototype._handleError):
- 02:05 Changeset [78033] by
-
2011-02-09 MORITA Hajime <morrita@google.com>
Reviewed by Shinichiro Hamaji.
[Chromium] WebTextCheckingResult should have a default constructor.
https://bugs.webkit.org/show_bug.cgi?id=54075
Gave default parameters to WebTextCheckingResult constructor.
- public/WebTextCheckingResult.h: (WebKit::WebTextCheckingResult::WebTextCheckingResult):
- 02:00 Changeset [78032] by
-
2011-02-08 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: sync uglifyjs parser files.
https://bugs.webkit.org/show_bug.cgi?id=54003
- inspector/front-end/UglifyJS/parse-js.js:
- inspector/front-end/UglifyJS/process.js:
- 01:53 Changeset [78031] by
-
2011-02-09 Ilya Tikhonovsky <loislo@chromium.org>
Unreviewed.
Chromium: update expectations for some canvas/philip tests which are failing on MAC.
- platform/chromium/test_expectations.txt:
- 00:23 Changeset [78030] by
-
2011-02-09 Martin Robinson <mrobinson@igalia.com>
Skip some failing tests.
- platform/gtk/Skipped: Skip plugins/invalidate_rect.html and fast/frames/flattening/iframe-flattening-crash.html
- 00:09 Changeset [78029] by
-
Unreviewed.
[Qt] Qt platform has a different editing delegates for several tests
https://bugs.webkit.org/show_bug.cgi?id=43082
editing/undo/undo-paste-when-caret-is-not-in-range.html introduced in r77995, but fails on Qt.
Add platform specific expected result until fix.
- platform/qt/editing/undo/undo-paste-when-caret-is-not-in-range-expected.checksum: Added.
- platform/qt/editing/undo/undo-paste-when-caret-is-not-in-range-expected.png: Added.
- platform/qt/editing/undo/undo-paste-when-caret-is-not-in-range-expected.txt: Copied from LayoutTests/editing/undo/undo-paste-when-caret-is-not-in-range-expected.txt.
- 00:03 Changeset [78028] by
-
2011-02-09 Alejandro G. Castro <alex@igalia.com>
Reviewed by Martin Robinson.
[GTK] Avoid WebProcessMain compilation, we are used a gtk specific main
https://bugs.webkit.org/show_bug.cgi?id=54015
Avoided the compilation of the general WebProcessMain, and added
soup initialization to WebProcessMainGtk.cpp.
- GNUmakefile.am:
- WebProcess/gtk/WebProcessMainGtk.cpp: (WebKit::WebProcessMainGtk):
02/08/11:
- 23:59 WebKitGTK/KeepingTheTreeGreen edited by
- (diff)
- 23:58 Changeset [78027] by
-
2011-02-08 Alejandro G. Castro <alex@igalia.com>
Reviewed by Martin Robinson.
[GTK] Incorrect assertion in WorkQueueGtk, we need to register
more than one handle
https://bugs.webkit.org/show_bug.cgi?id=54014
Fixed assertion condition we need to register more than one
handler for the same file descriptor.
- Platform/gtk/WorkQueueGtk.cpp: (WorkQueue::registerEventSourceHandler):
- 23:58 Changeset [78026] by
-
Unreviewed.
[Qt]Missing layoutTestController.displayInvalidatedRegion()
plugins/invalidate_rect.html introduced in r78010, but unfortunately
Qt DRT doesn't have layoutTestController.displayInvalidatedRegion().
- platform/qt/Skipped: Add plugins/invalidate_rect.html.
- 23:43 Changeset [78025] by
-
2011-02-08 Alejandro G. Castro <alex@igalia.com>
Reviewed by Martin Robinson.
Fix typo in the include guards name in ChunkedUpdateDrawingAreaProxy.h
https://bugs.webkit.org/show_bug.cgi?id=54013
- UIProcess/ChunkedUpdateDrawingAreaProxy.h:
- 23:42 Changeset [78024] by
-
<rdar://problem/8959420> Find in Mail no longer cycles around
Reviewed by Jon Honeycutt and Maciej Stachowiak.
- WebView/WebHTMLView.mm:
(-[WebHTMLView searchFor:direction:caseSensitive:wrap:startInSelection:]): Set
the wrap option according to the flag.
- 23:30 Changeset [78023] by
-
2011-02-08 Maciej Stachowiak <mjs@apple.com>
Reviewed by Kent Tamura.
Skip a freshly added test that depends on newly added DRT functionality
https://bugs.webkit.org/show_bug.cgi?id=54069
- platform/mac-wk2/Skipped:
- 23:25 Changeset [78022] by
-
2011-02-08 Alejandro G. Castro <alex@igalia.com>
Reviewed by Martin Robinson.
[GTK] Fix after r77874, m_isConnected is initialized before the
socket is opened
https://bugs.webkit.org/show_bug.cgi?id=54011
Fixed connection breakage after r77874, we have to wait until open
the socket to open the connection.
- Platform/CoreIPC/gtk/ConnectionGtk.cpp: (CoreIPC::Connection::platformInitialize): (CoreIPC::Connection::open):
- 23:21 Changeset [78021] by
-
2011-02-08 Alejandro G. Castro <alex@igalia.com>
Reviewed by Martin Robinson.
[WK2] LayerTreeContext is used outside the ACCELERATED_COMPOSITING
guards but not defined in DrawingAreaProxy.h
https://bugs.webkit.org/show_bug.cgi?id=54009
Removed the guards in the forward declaration, this will fail if
the class is finally used in the function, but it works for the
moment.
- UIProcess/DrawingAreaProxy.h:
- 23:16 Changeset [78020] by
-
2011-02-08 Alejandro G. Castro <alex@igalia.com>
Reviewed by Martin Robinson.
WebKit2 GTK Fails to Build #include nested too deeply
https://bugs.webkit.org/show_bug.cgi?id=52219
- GNUmakefile.am: Removed the commands to create the directories for the forwarding headers, the script already does it for us.
- config.h: Removed the config.h inclusion and added the autotoolsconfig.h directly, also added a condition to share the defines with QT.
2011-02-08 Alejandro G. Castro <alex@igalia.com>
Reviewed by Martin Robinson.
WebKit2 GTK Fails to Build #include nested too deeply
https://bugs.webkit.org/show_bug.cgi?id=52219
Removed the STDC_FORMAT_MACROS definition, it is already defined
in the file where PRIxx64 is used before the inclusion so we are
safe.
- configure.ac:
- 22:42 Changeset [78019] by
-
2011-02-08 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Barth.
fix toolbar anchoring in the code review tool
https://bugs.webkit.org/show_bug.cgi?id=54058
Avoid the anchoring cycle of doom when on the cusp
of whether the toolbar needs to be anchored and
speculatively avoid the Firefox crash when resizing.
- PrettyPatch/PrettyPatch.rb:
- code-review.js:
- 22:09 Changeset [78018] by
-
2011-02-08 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Removed some dead code from Heap
https://bugs.webkit.org/show_bug.cgi?id=54064
- runtime/MarkedSpace.cpp: Removed some now-unused constants and declarations.
(JSC::MarkedSpace::allocate): Removed some ASSERTs that are also ASSERTed
by our caller. Removed redundant typedefs.
- 21:59 Changeset [78017] by
-
2011-02-08 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Use a vector to track blocks in the Heap, instead of hand-rolled vector-like code
https://bugs.webkit.org/show_bug.cgi?id=54062
SunSpider reports no change.
- runtime/CollectorHeapIterator.h: (JSC::CollectorHeapIterator::isValid): (JSC::CollectorHeapIterator::isLive): Updated for new mark invariant: To know if an object is live, you just need to test its mark bit.
- runtime/MarkedSpace.cpp: (JSC::MarkedSpace::MarkedSpace): Moved waterMark and highWaterMark from CollectorHeap into MarkedSpace, since they're global state. Removed call to memset since CollectorHeap is a true class with its own constructor now.
(JSC::MarkedSpace::destroy): Change uses of m_heap.usedBlocks to
m_heap.blocks.size(), and m_heap.numBlocks to m_heap.blocks.capacity().
(JSC::MarkedSpace::allocateBlock):
(JSC::MarkedSpace::freeBlock): No need to manage our vector manually anymore.
(JSC::MarkedSpace::allocate):
(JSC::MarkedSpace::shrink):
(JSC::MarkedSpace::clearMarkBits):
(JSC::MarkedSpace::markedCells):
(JSC::MarkedSpace::sweep):
(JSC::MarkedSpace::objectCount):
(JSC::MarkedSpace::capacity):
(JSC::MarkedSpace::reset):
(JSC::MarkedSpace::primaryHeapEnd):
- runtime/MarkedSpace.h: (JSC::CollectorHeap::CollectorHeap): (JSC::MarkedSpace::highWaterMark): (JSC::MarkedSpace::setHighWaterMark): (JSC::MarkedSpace::contains): Same as above.
- 21:46 Changeset [78016] by
-
2011-02-08 Maciej Stachowiak <mjs@apple.com>
Reviewed by Mark Rowe.
Skip some tests that fail in WebKit2 for obvious reasons
https://bugs.webkit.org/show_bug.cgi?id=54055
- platform/mac-wk2/Skipped:
- 21:40 Changeset [78015] by
-
2011-02-08 Maciej Stachowiak <mjs@apple.com>
Reviewed by Mark Rowe.
Crash when going back/forward when back/forward list is in a bad state.
https://bugs.webkit.org/show_bug.cgi?id=54059
<rdar://problem/8975244>
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::goForward): Add a null check. (WebKit::WebPageProxy::goBack): ditto
- 21:33 Changeset [78014] by
-
2011-02-08 Hayato Ito <hayato@chromium.org>
Reviewed by Tony Chang.
[NRWT] Pull up rebaseline code from compare_output() function defined
in text_diff.py and image_diff.py into a SingleTestRunner.
This patch is a first step for eliminating test_type/* classes.
- Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
- Scripts/webkitpy/layout_tests/test_types/image_diff.py:
- Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
- Scripts/webkitpy/layout_tests/test_types/text_diff.py:
- 20:34 Changeset [78013] by
-
2011-02-08 Kristian Amlie <kristian.amlie@nokia.com>
Reviewed by Eric Seidel.
Added include paths for QtScript.
WebKit patches required to work with a modularized version of Qt
https://bugs.webkit.org/show_bug.cgi?id=53916
- Source/WebKit.pri:
- 20:32 Changeset [78012] by
-
2011-02-07 Ojan Vafai <ojan@chromium.org>
Reviewed by Mihai Parparita.
stop generating results.json files
https://bugs.webkit.org/show_bug.cgi?id=53977
We've only used incremental_results.json for a while now
and there are plans to start generating a results.json file that matches
the format of unexpected_results.json.
- Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
- Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
- Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
- Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- 20:17 Changeset [78011] by
-
2011-02-08 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
REGRESSION(71556,68059): queryCommandValue screws up background color at collapsed cursor
https://bugs.webkit.org/show_bug.cgi?id=53196
The bug was caused by Editor::selectionComputedStyle's modifying typing style without making a copy,
and its removing non-inheritable properties from the typing style. Fixed the bug by making a copy
before making the modification and not removing non-inheritable properties.
Also fixed a bug in selectionStartCSSPropertyValue that it doesn't handle xx-small to -webkit-xxx-large
by extracting a function from StyleChange::extractTextStyles and calling it in both extractTextStyles
and selectionStartCSSPropertyValue.
Test: editing/style/query-typing-style.html
- editing/ApplyStyleCommand.cpp: (WebCore::legacyFontSizeFromCSSValue): Extracted from StyleChange::extractTextStyles. (WebCore::StyleChange::extractTextStyles): Calls legacyFontSizeFromCSSValue; this fixes the bug that CSS values from xx-small through -webkit-xxx-large are not accounted.
- editing/ApplyStyleCommand.h:
- editing/Editor.cpp: (WebCore::Editor::selectionStartCSSPropertyValue): Calls legacyFontSizeFromCSSValue. (WebCore::Editor::selectionComputedStyle): Makes a copy before modifying typing style. No longer calls removeNonEditingProperties on the copied typing style so that background-color property is included when merged into the style.
2011-02-08 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
REGRESSION(71556,68059): queryCommandValue screws up background color at collapsed cursor
https://bugs.webkit.org/show_bug.cgi?id=53196
Added a test to ensure calling queryCommandValue returns the correct value for backColor
and fontSize from typing style.
- editing/style/query-typing-style-expected.txt: Added.
- editing/style/query-typing-style.html: Added.
- 19:30 Changeset [78010] by
-
2011-02-08 Sailesh Agrawal <sail@chromium.org>
Reviewed by Kenneth Russell.
Invalidate rect doesn't work for windowless plugins on Chromium
https://bugs.webkit.org/show_bug.cgi?id=53117
Added a test to make sure that NPN_InvalidateRect() works correctly for windowless plugins.
- plugins/invalidate_rect-expected.txt: Added.
- plugins/invalidate_rect.html: Added.
2011-02-08 Sailesh Agrawal <sail@chromium.org>
Reviewed by Kenneth Russell.
Invalidate rect doesn't work for windowless plugins on Chromium
https://bugs.webkit.org/show_bug.cgi?id=53117
Invalidate rect for windowless plugins wasn't working if the web page was composited.
The problem was that the invalidate call was causing simply dirtying the LayerChromium layers. Since the plugin was windowless this didn't cause the plugin to be repainted.
Fix was to copy the invalidate code from WebCore/plugins/PluginView.cpp/PluginView::invalidateWindowlessPluginRect() which does the correct thing.
Tested my fix on Windows and Mac and verified that the movie on http://apple.com/appltv correctly plays. Verified that windowed plugins still correctly draw as well.
- src/WebPluginContainerImpl.cpp: (WebKit::WebPluginContainerImpl::invalidateRect):
2011-02-08 Sailesh Agrawal <sail@chromium.org>
Reviewed by Kenneth Russell.
Invalidate rect doesn't work for windowless plugins on Chromium
https://bugs.webkit.org/show_bug.cgi?id=53117
Added two new utility methods.
- layoutTestController.displayInvalidatedRegion() does a paint of any area that has been invalidated. This is different from layoutTestController.display() which explicitly invalidates the entire page then paints.
- plugin.invalidateRect(left, top, right, bottom) - invalidates the given rect This is used to test that invalidating a rect correctly causes a repaint of the plugin.
- DumpRenderTree/LayoutTestController.cpp: (displayInvalidatedRegionCallback): (LayoutTestController::staticFunctions):
- DumpRenderTree/LayoutTestController.h:
- DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp: (invalidateRect): (pluginInvoke):
- DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::displayInvalidatedRegion):
- DumpRenderTree/chromium/LayoutTestController.h:
- Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
- 18:59 Changeset [78009] by
-
REGRESSION (r76831): Subframes are printed blank
<rdar://problem/8945867>
Reviewed by Maciej Stachowiak.
- page/FrameView.cpp:
(WebCore::FrameView::paintOverhangAreas):
Don't paint overhangs when printing.
- 18:43 Changeset [78008] by
-
2011-02-08 Mihai Parparita <mihaip@chromium.org>
Unreviewed. Remove chromium-gpu-win baseline that has a failing result,
since we now pass the test.
- platform/chromium-gpu-win/compositing/animation/animated-composited-inside-hidden-expected.txt: Removed.
- 18:39 Changeset [78007] by
-
2011-02-08 Mihai Parparita <mihaip@chromium.org>
Unreviewed chromium-gpu-win rebaseline.
- platform/chromium-gpu-win/compositing/direct-image-compositing-expected.txt:
- platform/chromium-gpu-win/compositing/geometry/composited-html-size-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/geometry/composited-html-size-expected.png: Copied from LayoutTests/platform/chromium-gpu-win/fast/canvas/canvas-transform-skewed-expected.png.
- platform/chromium-gpu-win/compositing/geometry/composited-html-size-expected.txt: Added.
- platform/chromium-gpu-win/compositing/geometry/fixed-position-expected.checksum:
- platform/chromium-gpu-win/compositing/geometry/fixed-position-expected.png:
- platform/chromium-gpu-win/compositing/geometry/fixed-position-expected.txt:
- platform/chromium-gpu-win/compositing/geometry/horizontal-scroll-composited-expected.checksum:
- platform/chromium-gpu-win/compositing/geometry/horizontal-scroll-composited-expected.png:
- platform/chromium-gpu-win/compositing/geometry/layer-due-to-layer-children-deep-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/geometry/layer-due-to-layer-children-deep-expected.png: Added.
- platform/chromium-gpu-win/compositing/geometry/layer-due-to-layer-children-deep-expected.txt: Added.
- platform/chromium-gpu-win/compositing/geometry/layer-due-to-layer-children-deep-switch-expected.txt: Added.
- platform/chromium-gpu-win/compositing/geometry/layer-due-to-layer-children-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/geometry/layer-due-to-layer-children-expected.png: Added.
- platform/chromium-gpu-win/compositing/geometry/layer-due-to-layer-children-expected.txt: Added.
- platform/chromium-gpu-win/compositing/geometry/layer-due-to-layer-children-switch-expected.txt: Added.
- platform/chromium-gpu-win/compositing/geometry/limit-layer-bounds-clipping-ancestor-expected.txt: Added.
- platform/chromium-gpu-win/compositing/geometry/limit-layer-bounds-overflow-root-expected.txt: Added.
- platform/chromium-gpu-win/compositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt: Added.
- platform/chromium-gpu-win/compositing/geometry/tall-page-composited-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/geometry/tall-page-composited-expected.png: Added.
- platform/chromium-gpu-win/compositing/geometry/vertical-scroll-composited-expected.checksum:
- platform/chromium-gpu-win/compositing/geometry/vertical-scroll-composited-expected.png:
- platform/chromium-gpu-win/compositing/geometry/vertical-scroll-composited-expected.txt:
- platform/chromium-gpu-win/compositing/iframes/composited-iframe-scroll-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/iframes/composited-iframe-scroll-expected.png: Added.
- platform/chromium-gpu-win/compositing/iframes/composited-iframe-scroll-expected.txt: Added.
- platform/chromium-gpu-win/compositing/iframes/composited-parent-iframe-expected.txt:
- platform/chromium-gpu-win/compositing/images/direct-svg-image-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/images/direct-svg-image-expected.png: Added.
- platform/chromium-gpu-win/compositing/masks/masked-ancestor-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/masks/masked-ancestor-expected.png: Added.
- platform/chromium-gpu-win/compositing/masks/masked-ancestor-expected.txt: Added.
- platform/chromium-gpu-win/compositing/masks/simple-composited-mask-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/masks/simple-composited-mask-expected.png: Added.
- platform/chromium-gpu-win/compositing/masks/simple-composited-mask-expected.txt: Added.
- platform/chromium-gpu-win/compositing/overflow/fixed-position-ancestor-clip-expected.checksum:
- platform/chromium-gpu-win/compositing/overflow/fixed-position-ancestor-clip-expected.png:
- platform/chromium-gpu-win/compositing/overflow/fixed-position-ancestor-clip-expected.txt:
- platform/chromium-gpu-win/compositing/reflections/animation-inside-reflection-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/reflections/animation-inside-reflection-expected.png: Added.
- platform/chromium-gpu-win/compositing/reflections/animation-inside-reflection-expected.txt: Added.
- platform/chromium-gpu-win/compositing/reflections/compositing-change-inside-reflection-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/reflections/compositing-change-inside-reflection-expected.png: Added.
- platform/chromium-gpu-win/compositing/reflections/compositing-change-inside-reflection-expected.txt: Added.
- platform/chromium-gpu-win/compositing/reflections/deeply-nested-reflections-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/reflections/deeply-nested-reflections-expected.png: Added.
- platform/chromium-gpu-win/compositing/reflections/deeply-nested-reflections-expected.txt: Added.
- platform/chromium-gpu-win/compositing/reflections/masked-reflection-on-composited-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/reflections/masked-reflection-on-composited-expected.png: Added.
- platform/chromium-gpu-win/compositing/reflections/masked-reflection-on-composited-expected.txt: Added.
- platform/chromium-gpu-win/compositing/reflections/nested-reflection-animated-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/reflections/nested-reflection-animated-expected.png: Added.
- platform/chromium-gpu-win/compositing/reflections/nested-reflection-animated-expected.txt: Added.
- platform/chromium-gpu-win/compositing/reflections/nested-reflection-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/reflections/nested-reflection-expected.png: Added.
- platform/chromium-gpu-win/compositing/reflections/nested-reflection-expected.txt: Added.
- platform/chromium-gpu-win/compositing/reflections/nested-reflection-mask-change-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/reflections/nested-reflection-mask-change-expected.png: Added.
- platform/chromium-gpu-win/compositing/reflections/nested-reflection-mask-change-expected.txt: Added.
- platform/chromium-gpu-win/compositing/reflections/nested-reflection-on-overflow-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/reflections/nested-reflection-on-overflow-expected.png: Added.
- platform/chromium-gpu-win/compositing/reflections/nested-reflection-on-overflow-expected.txt: Added.
- platform/chromium-gpu-win/compositing/reflections/nested-reflection-opacity-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/reflections/nested-reflection-opacity-expected.png: Added.
- platform/chromium-gpu-win/compositing/reflections/nested-reflection-opacity-expected.txt: Added.
- platform/chromium-gpu-win/compositing/reflections/nested-reflection-size-change-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/reflections/nested-reflection-size-change-expected.png: Added.
- platform/chromium-gpu-win/compositing/reflections/nested-reflection-size-change-expected.txt: Added.
- platform/chromium-gpu-win/compositing/reflections/nested-reflection-transformed-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/reflections/nested-reflection-transformed-expected.png: Added.
- platform/chromium-gpu-win/compositing/reflections/nested-reflection-transformed-expected.txt: Added.
- platform/chromium-gpu-win/compositing/reflections/nested-reflection-transformed2-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/reflections/nested-reflection-transformed2-expected.png: Added.
- platform/chromium-gpu-win/compositing/reflections/nested-reflection-transformed2-expected.txt: Added.
- platform/chromium-gpu-win/compositing/reflections/nested-reflection-transition-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/reflections/nested-reflection-transition-expected.png: Added.
- platform/chromium-gpu-win/compositing/reflections/nested-reflection-transition-expected.txt: Added.
- platform/chromium-gpu-win/compositing/reflections/reflection-on-composited-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/reflections/reflection-on-composited-expected.png: Added.
- platform/chromium-gpu-win/compositing/reflections/reflection-on-composited-expected.txt: Added.
- platform/chromium-gpu-win/compositing/reflections/reflection-ordering-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/reflections/reflection-ordering-expected.png: Added.
- platform/chromium-gpu-win/compositing/reflections/reflection-ordering-expected.txt: Added.
- platform/chromium-gpu-win/compositing/reflections/reflection-positioning-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/reflections/reflection-positioning-expected.png: Added.
- platform/chromium-gpu-win/compositing/reflections/reflection-positioning-expected.txt: Added.
- platform/chromium-gpu-win/compositing/reflections/reflection-positioning2-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/reflections/reflection-positioning2-expected.png: Added.
- platform/chromium-gpu-win/compositing/reflections/reflection-positioning2-expected.txt: Added.
- platform/chromium-gpu-win/compositing/reflections/remove-add-reflection-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/reflections/remove-add-reflection-expected.png: Added.
- platform/chromium-gpu-win/compositing/reflections/simple-composited-reflections-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/reflections/simple-composited-reflections-expected.png: Added.
- platform/chromium-gpu-win/compositing/reflections/simple-composited-reflections-expected.txt: Added.
- platform/chromium-gpu-win/compositing/reflections/transform-inside-reflection-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/reflections/transform-inside-reflection-expected.png: Added.
- platform/chromium-gpu-win/compositing/reflections/transform-inside-reflection-expected.txt: Added.
- platform/chromium-gpu-win/compositing/repaint/content-into-overflow-expected.txt:
- platform/chromium-gpu-win/compositing/repaint/overflow-into-content-expected.txt:
- platform/chromium-gpu-win/compositing/text-on-large-layer-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/text-on-large-layer-expected.png: Added.
- platform/chromium-gpu-win/compositing/text-on-large-layer-expected.txt: Added.
- platform/chromium-gpu-win/compositing/tiling/huge-layer-add-remove-child-expected.txt: Added.
- platform/chromium-gpu-win/compositing/tiling/huge-layer-expected.txt: Added.
- platform/chromium-gpu-win/compositing/tiling/huge-layer-with-layer-children-expected.txt: Added.
- platform/chromium-gpu-win/compositing/transitions/scale-transition-no-start-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/transitions/scale-transition-no-start-expected.png: Added.
- platform/chromium-gpu-win/compositing/transitions/scale-transition-no-start-expected.txt: Added.
- platform/chromium-gpu-win/compositing/webgl/webgl-reflection-expected.checksum: Added.
- platform/chromium-gpu-win/compositing/webgl/webgl-reflection-expected.png: Added.
- platform/chromium-gpu-win/compositing/webgl/webgl-reflection-expected.txt: Added.
- platform/chromium-gpu-win/fast/canvas/canvas-composite-expected.checksum:
- platform/chromium-gpu-win/fast/canvas/canvas-composite-expected.png:
- platform/chromium-gpu-win/fast/canvas/canvas-transform-skewed-expected.checksum:
- platform/chromium-gpu-win/fast/canvas/canvas-transform-skewed-expected.png:
- 18:27 Changeset [78006] by
-
2011-02-08 Zhenyao Mo <zmo@google.com>
Unreviewed, test expectations update.
- platform/chromium/test_expectations.txt
- 18:14 Changeset [78005] by
-
2011-02-07 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Nate Chapin.
Events should propagate through IDBDatabase (for IDBRequest and IDBTransaction)
https://bugs.webkit.org/show_bug.cgi?id=53975
- storage/indexeddb/objectstore-basics.html:
- storage/indexeddb/request-event-propagation-expected.txt:
- storage/indexeddb/request-event-propagation.html:
- storage/indexeddb/transaction-and-objectstore-calls-expected.txt:
- storage/indexeddb/transaction-and-objectstore-calls.html:
- storage/indexeddb/transaction-basics.html:
- storage/indexeddb/transaction-event-propagation-expected.txt: Added.
- storage/indexeddb/transaction-event-propagation.html: Added.
2011-02-07 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Nate Chapin.
Events should propagate through IDBDatabase (for IDBRequest and IDBTransaction)
https://bugs.webkit.org/show_bug.cgi?id=53975
The third change in the series of overhauling IndexedDB's event model to match
the spec (at least the version in our heads and bugs).
Test: storage/indexeddb/transaction-event-propagation.html
- bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::convertEventTargetToV8Object):
- dom/Event.cpp: (WebCore::Event::isIDBAbortEvent): (WebCore::Event::isIDBCompleteEvent):
- dom/Event.h:
- dom/EventTarget.cpp: (WebCore::EventTarget::toIDBDatabase):
- dom/EventTarget.h:
- storage/IDBDatabase.cpp: (WebCore::IDBDatabase::create): (WebCore::IDBDatabase::IDBDatabase): (WebCore::IDBDatabase::scriptExecutionContext): (WebCore::IDBDatabase::eventTargetData): (WebCore::IDBDatabase::ensureEventTargetData):
- storage/IDBDatabase.h: (WebCore::IDBDatabase::toIDBDatabase): (WebCore::IDBDatabase::refEventTarget): (WebCore::IDBDatabase::derefEventTarget):
- storage/IDBDatabase.idl:
- storage/IDBRequest.cpp: (WebCore::IDBRequest::onSuccess): (WebCore::IDBRequest::dispatchEvent):
- storage/IDBTransaction.cpp: (WebCore::IDBTransaction::backend): (WebCore::IDBTransaction::db): (WebCore::IDBTransaction::objectStore): (WebCore::IDBTransaction::scriptExecutionContext): (WebCore::IDBTransaction::dispatchEvent): (WebCore::IDBTransaction::enqueueEvent):
- storage/IDBTransaction.h: (WebCore::IDBTransaction::dispatchEvent):
- 18:10 Changeset [78004] by
-
Merge 77608 - 2011-02-03 Victoria Kirst <vrk@google.com>
Reviewed by James Robinson.
Replaces float literals with uniform values in shader code
so that buggy drivers unable to parse float values in different
locales will not produce a pink video.
[chromium] Fix pink video bug with gpu-acceleration enabled
https://bugs.webkit.org/show_bug.cgi?id=53568
- platform/graphics/chromium/VideoLayerChromium.cpp: (WebCore::VideoLayerChromium::SharedValues::SharedValues): (WebCore::VideoLayerChromium::drawYUV):
- platform/graphics/chromium/VideoLayerChromium.h: (WebCore::VideoLayerChromium::SharedValues::signAdjLocation):
TBR=commit-queue@webkit.org
Review URL: http://codereview.chromium.org/6460020
- 18:08 Changeset [78003] by
-
Merge 77599 - 2011-02-03 Victoria Kirst <vrk@google.com>
Reviewed by James Robinson.
[chromium] Fix redundant video frame paint on CSS LayerChromium for <video>
https://bugs.webkit.org/show_bug.cgi?id=52868
- src/WebMediaPlayerClientImpl.cpp: (WebKit::WebMediaPlayerClientImpl::paint): (WebKit::WebMediaPlayerClientImpl::paintCurrentFrameInContext): (WebKit::WebMediaPlayerClientImpl::acceleratedRenderingInUse):
- src/WebMediaPlayerClientImpl.h:
TBR=commit-queue@webkit.org
Review URL: http://codereview.chromium.org/6465012
- 18:02 Changeset [78002] by
-
2011-02-08 Kenneth Russell <kbr@google.com>
Reviewed by James Robinson.
Add cache for GPU-accelerated path processing results
https://bugs.webkit.org/show_bug.cgi?id=45519
Adding a cache which holds the results of processing a path into
interior and exterior triangle meshes, according to the path
rendering algorithm from GPU Gems 3. No tests yet; will be tested
in conjunction with later code.
- platform/graphics/gpu/LoopBlinnPathCache.cpp: Added. (WebCore::LoopBlinnPathCache::LoopBlinnPathCache): (WebCore::LoopBlinnPathCache::~LoopBlinnPathCache): (WebCore::LoopBlinnPathCache::addVertex): (WebCore::LoopBlinnPathCache::clear): (WebCore::LoopBlinnPathCache::addInteriorVertex): (WebCore::LoopBlinnPathCache::numberOfInteriorEdgeVertices): (WebCore::LoopBlinnPathCache::interiorEdgeVertices): (WebCore::LoopBlinnPathCache::addInteriorEdgeVertex):
- platform/graphics/gpu/LoopBlinnPathCache.h: Added. (WebCore::LoopBlinnPathCache::numberOfVertices): (WebCore::LoopBlinnPathCache::vertices): (WebCore::LoopBlinnPathCache::texcoords): (WebCore::LoopBlinnPathCache::numberOfInteriorVertices): (WebCore::LoopBlinnPathCache::interiorVertices):
- 17:55 Changeset [78001] by
-
Nevermind
- 17:54 Changeset [78000] by
-
80,000
- 17:46 Changeset [77999] by
-
2011-02-08 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
Rename GraphicsContext3D::WebGLEnumType
https://bugs.webkit.org/show_bug.cgi?id=45708
- html/canvas/WebGLProgram.cpp: (WebCore::WebGLProgram::getAttachedShader):
- html/canvas/WebGLProgram.h:
- platform/graphics/GraphicsContext3D.h:
- 17:17 Changeset [77998] by
-
2011-02-08 Dirk Pranke <dpranke@chromium.org>
Reviewed by Tony Chang.
new-run-webkit-tests: move the logic that starts and stops the
servers from dump_render_tree_thread into single_test_runner
so that we can reuse it in the new multiprocessing worker class
as well.
- Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
- Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
- 17:04 Changeset [77997] by
-
2011-02-08 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r77980.
http://trac.webkit.org/changeset/77980
https://bugs.webkit.org/show_bug.cgi?id=54043
"Crashes on Windows and Linux..." (Requested by leviw on
#webkit).
- WebView/WebFrame.mm: (-[WebFrame _caretRectAtNode:offset:affinity:]):
- WebView/WebFrameInternal.h:
- WebView/WebTextCompletionController.mm: (-[WebTextCompletionController doCompletion]):
2011-02-08 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r77980.
http://trac.webkit.org/changeset/77980
https://bugs.webkit.org/show_bug.cgi?id=54043
"Crashes on Windows and Linux..." (Requested by leviw on
#webkit).
- WebCore.exp.in:
- accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::visiblePositionForTextMarkerData):
- accessibility/AccessibilityObject.cpp: (WebCore::startOfStyleRange): (WebCore::endOfStyleRange):
- accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::visiblePositionForIndex):
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (objectAndOffsetUnignored):
- dom/Position.cpp: (WebCore::Position::upstream): (WebCore::Position::downstream):
- dom/Range.cpp: (WebCore::Range::editingStartPosition):
- editing/Editor.cpp: (WebCore::Editor::canDeleteRange):
- editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply):
- editing/SelectionController.cpp: (WebCore::SelectionController::selectFrameElementInParentIfFullySelected): (WebCore::SelectionController::setSelectedRange):
- editing/TextIterator.cpp: (WebCore::TextIterator::shouldRepresentNodeOffsetZero):
- editing/TypingCommand.cpp: (WebCore::TypingCommand::deleteKeyPressed):
- editing/VisiblePosition.cpp: (WebCore::VisiblePosition::VisiblePosition): (WebCore::VisiblePosition::leftVisuallyDistinctCandidate): (WebCore::VisiblePosition::rightVisuallyDistinctCandidate): (WebCore::VisiblePosition::canonicalPosition): (WebCore::VisiblePosition::characterAfter): (WebCore::VisiblePosition::localCaretRect): (WebCore::makeRange): (WebCore::startVisiblePosition): (WebCore::endVisiblePosition): (WebCore::setStart): (WebCore::setEnd): (WebCore::isFirstVisiblePositionInNode): (WebCore::isLastVisiblePositionInNode):
- editing/VisiblePosition.h:
- editing/htmlediting.cpp: (WebCore::firstInSpecialElement): (WebCore::lastInSpecialElement): (WebCore::visiblePositionBeforeNode): (WebCore::visiblePositionAfterNode):
- editing/visible_units.cpp: (WebCore::startPositionForLine): (WebCore::endPositionForLine): (WebCore::previousLinePosition): (WebCore::nextLinePosition): (WebCore::startOfParagraph): (WebCore::endOfParagraph): (WebCore::endOfBlock): (WebCore::startOfDocument): (WebCore::endOfDocument): (WebCore::logicalStartPositionForLine): (WebCore::logicalEndPositionForLine):
- page/DOMSelection.cpp: (WebCore::DOMSelection::collapse): (WebCore::DOMSelection::setBaseAndExtent): (WebCore::DOMSelection::setPosition): (WebCore::DOMSelection::extend):
- page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEventSingleClick):
- rendering/RenderObject.cpp: (WebCore::RenderObject::createVisiblePosition):
- rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::visiblePositionForIndex):
- svg/SVGTextContentElement.cpp: (WebCore::SVGTextContentElement::selectSubString):
- 17:00 Changeset [77996] by
-
2011-02-08 Anders Carlsson <andersca@apple.com>
Reviewed by Beth Dakin.
Assertion failure !isInAcceleratedCompositingMode() in DrawingAreaProxyImpl::incorporateUpdate()
https://bugs.webkit.org/show_bug.cgi?id=54046
<rdar://problem/8973960>
DrawingAreaImpl::setRootCompositingLayer can be called with a new layer even when already
in accelerated compositing mode. Similarly, it can be called with a null layer even when not
in accelerated compositing mode. Make the drawing area and layer tree host handle both these cases.
- WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::setRootCompositingLayer): Only call enterAcceleratedCompositingMode if there is no layer tree host, otherwise just call LayerTreeHost::setRootCompositingLayer.
(WebKit::DrawingAreaImpl::setSize):
Add an assert.
(WebKit::DrawingAreaImpl::enterAcceleratedCompositingMode):
Assert that we don't have a layer tree host.
(WebKit::DrawingAreaImpl::exitAcceleratedCompositingMode):
Assert that we do have a layer tree host.
(WebKit::DrawingAreaImpl::display):
If the call to display caused the page to enter accelerated compositing mode, we don't
want to send back an Update message.
- WebProcess/WebPage/LayerTreeHost.cpp: (WebKit::LayerTreeHost::create):
- WebProcess/WebPage/LayerTreeHost.h: Create no longer takes a graphics layer.
- WebProcess/WebPage/mac/LayerTreeHostMac.mm: (WebKit::LayerTreeHostMac::create): (WebKit::LayerTreeHostMac::LayerTreeHostMac): Create no longer takes a graphics layer.
(WebKit::LayerTreeHostMac::setRootCompositingLayer):
Set the new root compositing layer.
- 16:55 Changeset [77995] by
-
2011-02-08 Jia Pu <jpu@apple.com>
Reviewed by Darin Adler.
VisibleSelection::setWithoutValidation() should allow caret selection.
https://bugs.webkit.org/show_bug.cgi?id=53943
- editing/undo/undo-paste-when-caret-is-not-in-range-expected.txt: Added.
- editing/undo/undo-paste-when-caret-is-not-in-range.html: Added.
2011-02-08 Jia Pu <jpu@apple.com>
Reviewed by Darin Adler.
VisibleSelection::setWithoutValidation() should allow caret selection.
https://bugs.webkit.org/show_bug.cgi?id=53943
Test: editing/undo/undo-paste-when-caret-is-not-in-range.html
- editing/VisibleSelection.cpp: (WebCore::VisibleSelection::setWithoutValidation):
- 16:48 Changeset [77994] by
-
2011-02-08 Dirk Pranke <dpranke@chromium.org>
Reviewed by Mihai Parparita.
new-run-webkit-tests: split out thread stack logging code into a sharable module
This patch splits out the code used to find and log thread
stacks from NRWT-specific packages to something generic and
shareable by other python modules. It will be shared in the near
future by the manager_worker_broker module, for example.
- Scripts/webkitpy/common/system/stack_utils.py: Added.
- Scripts/webkitpy/common/system/stack_utils_unittest.py: Added.
- Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
- Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
- 16:45 Changeset [77993] by
-
2011-02-08 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] Remove the last remnants of the Mozilla theme drawing code
https://bugs.webkit.org/show_bug.cgi?id=54035
Remove all Mozilla theme drawing code.
No new tests. This change only removes dead code.
- GNUmakefile.am: Remove Mozilla files from the source list.
- platform/gtk/RenderThemeGtk.h: Remove Mozilla-theme-drawing-related methods and add m_colormap to hold the current colormap of the widgets.
- platform/gtk/RenderThemeGtk2.cpp: Remove Mozilla code. (WebCore::RenderThemeGtk::platformInit): Ditto. (WebCore::RenderThemeGtk::~RenderThemeGtk): Ditto. (WebCore::RenderThemeGtk::gtkContainer): Ditto.
- platform/gtk/ScrollbarThemeGtk2.cpp: Ditto.
- platform/gtk/WidgetRenderingContext.cpp: Ditto. (WebCore::WidgetRenderingContext::WidgetRenderingContext): Ditto.
- platform/gtk/WidgetRenderingContext.h: Ditto.
- platform/gtk/gtk2drawing.c: Removed.
- platform/gtk/gtkdrawing.h: Removed.
- 16:40 Changeset [77992] by
-
2011-02-08 Dirk Pranke <dpranke@chromium.org>
Reviewed by Tony Chang.
new-run-webkit-tests: move a bunch of testing logic out of
dump_render_tree_thread and into single_test_runner so that we
will be able to reuse it in the new multiprocessing worker class as well.
- Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
- Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
- 16:37 Changeset [77991] by
-
2011-02-08 Dirk Pranke <dpranke@chromium.org>
Reviewed by Ojan Vafai.
new-run-webkit-tests: remove no longer needed WatchableThread
class.
- Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
- 16:33 Changeset [77990] by
-
2011-02-08 Dirk Pranke <dpranke@chromium.org>
Reviewed by Tony Chang.
new-run-webkit-tests: add stubs for the Manager objects that
will abstract the concurrency implementation (inline / threads /
processes). These classes do nothing yet and are not wired up to
anything.
- Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py: Added.
- Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py: Added.
- 16:31 Changeset [77989] by
-
2011-02-08 Dirk Pranke <dpranke@chromium.org>
Reviewed by Tony Chang.
new-run-webkit-tests: add simplified message broker for new-style
messaging. This change adds a very simple message broker that
will be used to shuttle messages between the TestRunner2 manager
thread and the Worker threads. For now the class is not used by
anything, but the eventual usage can be seen in the patches
attached to bug 49566.
- Scripts/webkitpy/layout_tests/layout_package/message_broker2.py: Added.
- Scripts/webkitpy/layout_tests/layout_package/message_broker2_unittest.py: Added.
- 16:25 Changeset [77988] by
-
2011-02-08 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Antti Koivisto.
Crash when logging into gmail.com with frame flattening turned on.
https://bugs.webkit.org/show_bug.cgi?id=52449
- fast/frames/flattening/iframe-flattening-crash-expected.txt: Added.
- fast/frames/flattening/iframe-flattening-crash.html: Added.
- fast/frames/flattening/iframe-flattening-selection-crash-expected.txt: Added.
- fast/frames/flattening/iframe-flattening-selection-crash.html: Added.
- fast/frames/flattening/resources/iframe-flattening-crash.html: Added.
2011-02-08 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Antti Koivisto.
Crash when logging into gmail.com with frame flattening turned on.
https://bugs.webkit.org/show_bug.cgi?id=52449
Frame flattening algorithm requires that layout always starts from the main frame, since layout of
subframes impacts the layout of their parents.
There are places in the code that call view->layout() not on the main frame.
Instead of changing all the callsites, I changed FrameView::layout()
to force layout from the main frame if frame flattening is enabled.
In addition, postLayoutTasks can trigger relayout, so make it use the timer even more.
Move the call to SelectionController::updateAppearance() to performPostLayoutTasks(),
because calling the from layout() leads to a crash in pages that have a selection in an iframe.
Tests: fast/frames/flattening/iframe-flattening-crash.html
fast/frames/flattening/iframe-flattening-selection-crash.html
- page/FrameView.cpp: (WebCore::FrameView::layout): (WebCore::FrameView::performPostLayoutTasks):
- 16:25 Changeset [77987] by
-
2011-02-08 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
chromium-win builder shouldn't run python or perl tests
https://bugs.webkit.org/show_bug.cgi?id=54032
These tests don't pass on this builder because the builder isn't
running in cygwin. There isn't really any point in running them and
making the bot red forever.
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
- 16:07 Changeset [77986] by
-
Add Radar URLs to a recent ChangeLog entry.
- 15:59 Changeset [77985] by
-
2011-02-08 Andy Estes <aestes@apple.com>
Reviewed by Darin Adler.
REGRESSION (r76301): 'plaintext-only' must be a supported contentEditable mode.
https://bugs.webkit.org/show_bug.cgi?id=54041
- html/HTMLElement.cpp: (WebCore::HTMLElement::setContentEditable): Setting the contentEditable attribute to 'plaintext-only' should not throw an exception.
2011-02-08 Andy Estes <aestes@apple.com>
Reviewed by Darin Adler.
REGRESSION (r76301): 'plaintext-only' must be a supported contentEditable mode.
https://bugs.webkit.org/show_bug.cgi?id=54041
- fast/dom/HTMLElement/set-value-caseinsensitive-expected.txt:
- fast/dom/HTMLElement/set-value-caseinsensitive.html:
- 15:51 Changeset [77984] by
-
RenderRubyRun::m_beingDestroyed is redundant
https://bugs.webkit.org/show_bug.cgi?id=54042
Reviewed by Simon Fraser.
- rendering/RenderRubyRun.cpp:
(WebCore::RenderRubyRun::RenderRubyRun): Removed intialization of m_beingDestroyed.
(WebCore::RenderRubyRun::removeChild): Use the base class beingDestroyed().
- rendering/RenderRubyRun.h:
- 15:34 Changeset [77983] by
-
Implement WorkQueue::scheduleWorkAfterDelay on Windows
Each WorkQueue now owns its own timer queue. When scheduleWorkAfterDelay is called, we
create a timer-queue timer with the given delay. When the timer fires, we schedule the work
on the queue and clean up the timer.
Fixes <http://webkit.org/b/54040> <rdar://problem/8974230> Web process sticks around forever
if it's hung when UI process goes away
Reviewed by Anders Carlsson.
- Platform/WorkQueue.h: Added timerCallback and m_timerQueue.
- Platform/win/WorkQueueWin.cpp:
(WorkQueue::platformInitialize): Initialize m_timerQueue.
(WorkQueue::platformInvalidate): Clean up m_timerQueue.
(TimerContext::TimerContext): Added this helper object to hold the context needed by the
timer callback.
(WorkQueue::timerCallback): Added. Schedules the WorkItem on the WorkQueue and cleans up the
timer.
(WorkQueue::scheduleWorkAfterDelay): Create a timer-queue timer on our timer queue that will
fire after the given delay. Pass a new TimerContext object to the timer callback that
contains the information it needs.
- 15:15 Changeset [77982] by
-
2011-02-08 Martin Robinson <mrobinson@igalia.com>
Unskip a series of tests that seem to be passing locally. Also unskip
a test that was mistakenly reskipped in r77979 due to what looks like a
merge issue. Rebaseline two of these test which have results originating
from long ago.
- platform/gtk/Skipped: Unskip some tests.
- platform/gtk/editing/selection/14971-expected.txt:
- platform/gtk/editing/selection/inline-closest-leaf-child-expected.txt:
- 15:14 Changeset [77981] by
-
2011-02-08 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Rename PluginProcess::initializeConnection to PluginProcess::initialize
https://bugs.webkit.org/show_bug.cgi?id=54039
- PluginProcess/PluginProcess.cpp: (WebKit::PluginProcess::initialize):
- PluginProcess/PluginProcess.h:
- PluginProcess/mac/PluginProcessMainMac.mm: (WebKit::PluginProcessMain):
- WebProcess/WebProcess.h:
- 15:13 Changeset [77980] by
-
2011-02-08 Levi Weintraub <leviw@chromium.org>
Reviewed by Ryosuke Niwa.
Stop instantiating legacy editing Positions in VisiblePosition
https://bugs.webkit.org/show_bug.cgi?id=52919
Changing usage of legacy VisiblePosition constructor. Since we were dealing
with positions from DOM Ranges, we're guaranteed a parent-anchored position.
- WebView/WebFrame.mm: (-[WebFrame _caretRectAtPosition:affinity:]):
- WebView/WebFrameInternal.h:
- WebView/WebTextCompletionController.mm: (-[WebTextCompletionController doCompletion]):
2011-02-08 Levi Weintraub <leviw@chromium.org>
Reviewed by Ryosuke Niwa.
Stop instantiating legacy editing Positions in VisiblePosition
https://bugs.webkit.org/show_bug.cgi?id=52919
Changing VisiblePosition completely away from legacy positions.
No new tests since this is functionaly equivalent.
- WebCore.exp.in: Removing the legacy VisiblePosition constructor and adding the PositionIsOffsetInAnchor symbol. If we must create VisiblePositions outside of WebCore, they should be parent anchored.
- accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::visiblePositionForTextMarkerData):
- accessibility/AccessibilityObject.cpp: (WebCore::startOfStyleRange): (WebCore::endOfStyleRange):
- accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::visiblePositionForIndex):
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (objectAndOffsetUnignored):
- dom/Position.cpp: (WebCore::Position::upstream): Fixed to correctly respect PositionIsAfterAnchor (WebCore::Position::downstream): ditto
- dom/Range.cpp: (WebCore::Range::editingStartPosition):
- editing/Editor.cpp: (WebCore::Editor::canDeleteRange):
- editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply):
- editing/SelectionController.cpp: (WebCore::SelectionController::selectFrameElementInParentIfFullySelected): (WebCore::SelectionController::setSelectedRange):
- editing/TextIterator.cpp: (WebCore::TextIterator::shouldRepresentNodeOffsetZero):
- editing/TypingCommand.cpp: (WebCore::TypingCommand::deleteKeyPressed):
- editing/VisiblePosition.cpp: (WebCore::VisiblePosition::leftVisuallyDistinctCandidate): (WebCore::VisiblePosition::rightVisuallyDistinctCandidate): (WebCore::VisiblePosition::canonicalPosition): (WebCore::VisiblePosition::characterAfter): (WebCore::VisiblePosition::localCaretRect): (WebCore::makeRange): (WebCore::startVisiblePosition): (WebCore::endVisiblePosition): (WebCore::setStart): (WebCore::setEnd): (WebCore::isFirstVisiblePositionInNode): (WebCore::isLastVisiblePositionInNode):
- editing/VisiblePosition.h: (WebCore::VisiblePosition::VisiblePosition):
- editing/htmlediting.cpp: (WebCore::firstInSpecialElement): (WebCore::lastInSpecialElement): (WebCore::visiblePositionBeforeNode): (WebCore::visiblePositionAfterNode):
- editing/visible_units.cpp: (WebCore::startPositionForLine): (WebCore::endPositionForLine): (WebCore::previousLinePosition): (WebCore::nextLinePosition): (WebCore::startOfParagraph): (WebCore::endOfParagraph): (WebCore::endOfBlock): (WebCore::startOfDocument): (WebCore::endOfDocument): (WebCore::logicalStartPositionForLine): (WebCore::logicalEndPositionForLine):
- page/DOMSelection.cpp: (WebCore::DOMSelection::collapse): (WebCore::DOMSelection::setBaseAndExtent): (WebCore::DOMSelection::setPosition): (WebCore::DOMSelection::extend):
- page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEventSingleClick):
- rendering/RenderObject.cpp: (WebCore::RenderObject::createVisiblePosition):
- rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::visiblePositionForIndex):
- svg/SVGTextContentElement.cpp: (WebCore::SVGTextContentElement::selectSubString):
- 15:09 Changeset [77979] by
-
2011-02-08 Michael Saboff <msaboff@apple.com>
JSC::Bindings m_rootObject->isValid() assert fails when running layout tests
https://bugs.webkit.org/show_bug.cgi?id=53716
Changed ASSERT to be an if for the case where the RuntimeObject was
GC'ed before RootObject::invalidate is called. In that case there is
no need to remove the RuntimeObject from the RootObject. The isValid()
call will be false in this case, but the RuntimeObject has already
been removed from the RootObject. Added similar defensive code
in RootObject::removeRuntimeObject().
- bridge/jsc/BridgeJSC.cpp: (JSC::Bindings::Instance::willDestroyRuntimeObject):
- bridge/runtime_root.cpp: (JSC::Bindings::RootObject::removeRuntimeObject):
2011-02-08 Michael Saboff <msaboff@apple.com>
Reviewed by Darin Adler.
JSC::Bindings m_rootObject->isValid() assert fails when running layout tests
https://bugs.webkit.org/show_bug.cgi?id=53716
Re-enabled tests that are fixed with the corresponding change in
WebCore.
- platform/gtk/Skipped:
- 15:07 Changeset [77978] by
-
<rdar://problem/8972913> and https://bugs.webkit.org/show_bug.cgi?id=54036
didChangeBackForwardList should include some context about what changed
Reviewed by Darin Adler.
Source/WebKit2:
Update the implementation of this API to include the new item (if any) and removed items (if any):
- UIProcess/API/C/WKPage.h:
- UIProcess/WebLoaderClient.cpp:
(WebKit::WebLoaderClient::didChangeBackForwardList):
- UIProcess/WebLoaderClient.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didChangeBackForwardList):
- UIProcess/WebPageProxy.h:
Have WebBackForwardList pass the new items and/or removed items when calling the notifier:
- UIProcess/WebBackForwardList.cpp:
(WebKit::WebBackForwardList::addItem):
(WebKit::WebBackForwardList::goToItem):
(WebKit::WebBackForwardList::clear):
Tools:
- MiniBrowser/mac/BrowserWindowController.m:
(didChangeBackForwardList):
- 15:03 Changeset [77977] by
-
2011-02-08 Geoffrey Garen <ggaren@apple.com>
Reviewed by Darin Adler.
Give each MarkedBlock enough mark bits to cover the whole block
https://bugs.webkit.org/show_bug.cgi?id=54029
SunSpider reports no change.
This simplifies access to mark bits, since any cell-aligned pointer
into a block now has a valid mark bit to test.
- runtime/MarkedBlock.h: Changed CELLS_PER_BLOCK to account for the extra mark bits. This happens not to change its actual value. (JSC::MarkedBlock::cellNumber): (JSC::MarkedBlock::isMarked): (JSC::MarkedBlock::testAndSetMarked): (JSC::MarkedBlock::setMarked): Changed const JSCell* to const void* to remove a cast from our caller, and to more accurately reflect the fact that MarkedBlock is agnostic about the types pointed to by the pointers you pass to it.
(JSC::MarkedBlock::isPossibleCell): Removed a null check. We now consider
the null pointer to be a possible cell with a 0 (impossible) block. This
removes a null check from marking.
- runtime/MarkedSpace.cpp:
- runtime/MarkedSpace.h: (JSC::MarkedSpace::contains): Simplified the contains check, and inlined the whole thing, now that it's so simple.
- 15:02 Changeset [77976] by
-
Sandbox violations visiting MobileMe.
<rdar://problem/8961330>
Reviewed by Anders Carlsson.
- WebProcess/com.apple.WebProcess.sb:
- 14:52 Changeset [77975] by
-
2011-02-08 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Rename PluginProcess::initialize to PluginProcess::initializePluginProcess
https://bugs.webkit.org/show_bug.cgi?id=54037
Rename PluginProcess::initialize to PluginProcess::initializePluginProcess to better
match the WebProcess initialization code, in preparation of sharing more code.
- PluginProcess/PluginProcess.cpp: (WebKit::PluginProcess::initializePluginProcess):
- PluginProcess/PluginProcess.h:
- PluginProcess/PluginProcess.messages.in:
- UIProcess/Plugins/PluginProcessProxy.cpp: (WebKit::PluginProcessProxy::didFinishLaunching):
- 14:48 Changeset [77974] by
-
WK2: Add ability to pass context to policy delegate methods
https://bugs.webkit.org/show_bug.cgi?id=54031
Reviewed by Anders Carlsson.
Source/WebKit2:
- Platform/CoreIPC/HandleMessage.h:
(CoreIPC::callMemberFunction):
(CoreIPC::handleMessageVariadic):
- Scripts/webkit2/messages.py:
Add ability to pass variadic messages to sync messages.
- Shared/API/c/WKBase.h:
- Shared/APIObject.h:
Add WKBundleNavigation type.
- UIProcess/API/C/WKPage.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::decidePolicyForNavigationAction):
(WebKit::WebPageProxy::decidePolicyForNewWindowAction):
(WebKit::WebPageProxy::decidePolicyForMIMEType):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- UIProcess/WebPolicyClient.cpp:
(WebKit::WebPolicyClient::decidePolicyForNavigationAction):
(WebKit::WebPolicyClient::decidePolicyForNewWindowAction):
(WebKit::WebPolicyClient::decidePolicyForMIMEType):
- UIProcess/WebPolicyClient.h:
Update policy client for new data.
- WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:
- WebProcess/InjectedBundle/API/c/WKBundleNavigationAction.cpp: Added.
(WKBundleNavigationActionGetTypeID):
(WKBundleNavigationActionGetNavigationType):
(WKBundleNavigationActionGetEventModifiers):
(WKBundleNavigationActionGetEventMouseButton):
(WKBundleNavigationActionCopyHitTestResult):
(WKBundleNavigationActionCopyFormElement):
- WebProcess/InjectedBundle/API/c/WKBundleNavigationAction.h: Added.
- WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageSetPolicyClient):
- WebProcess/InjectedBundle/API/c/WKBundlePage.h:
- WebProcess/InjectedBundle/InjectedBundleNavigationAction.cpp: Added.
(WebKit::mouseEventForNavigationAction):
(WebKit::mouseButtonForMouseEvent):
(WebKit::InjectedBundleNavigationAction::modifiersForNavigationAction):
(WebKit::InjectedBundleNavigationAction::mouseButtonForNavigationAction):
(WebKit::InjectedBundleNavigationAction::create):
(WebKit::InjectedBundleNavigationAction::InjectedBundleNavigationAction):
- WebProcess/InjectedBundle/InjectedBundleNavigationAction.h: Added.
(WebKit::InjectedBundleNavigationAction::navigationType):
(WebKit::InjectedBundleNavigationAction::modifiers):
(WebKit::InjectedBundleNavigationAction::mouseButton):
(WebKit::InjectedBundleNavigationAction::hitTestResult):
(WebKit::InjectedBundleNavigationAction::formElement):
(WebKit::InjectedBundleNavigationAction::type):
- WebProcess/InjectedBundle/InjectedBundlePagePolicyClient.cpp: Added.
(WebKit::InjectedBundlePagePolicyClient::decidePolicyForNavigationAction):
(WebKit::InjectedBundlePagePolicyClient::decidePolicyForNewWindowAction):
(WebKit::InjectedBundlePagePolicyClient::decidePolicyForMIMEType):
- WebProcess/InjectedBundle/InjectedBundlePagePolicyClient.h: Added.
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::createWindow):
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForMIMEType):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
- WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::initializeInjectedBundlePolicyClient):
- WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::injectedBundlePolicyClient):
Pipe the policy client through the bundle to allow setting user data.
- WebKit2.pro:
- WebKit2.xcodeproj/project.pbxproj:
- win/WebKit2.vcproj:
- win/WebKit2Generated.make:
Add new files.
Tools:
- MiniBrowser/mac/BrowserWindowController.m:
(decidePolicyForNavigationAction):
(decidePolicyForNewWindowAction):
(decidePolicyForMIMEType):
- TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
(TestWebKitAPI::decidePolicyForNavigationAction):
(TestWebKitAPI::decidePolicyForNewWindowAction):
(TestWebKitAPI::decidePolicyForMIMEType):
Update policy client for new API.
- 14:33 Changeset [77973] by
-
2011-02-08 Xiaomei Ji <xji@chromium.org>
Unreviewed.
Rebaseline for chromium-mac after r77952.
Not sure why the previous rebase did not get the right results.
https://bugs.webkit.org/show_bug.cgi?id=54026
- platform/chromium-mac/fast/text/international/pop-up-button-text-alignment-and-direction-expected.checksum:
- platform/chromium-mac/fast/text/international/pop-up-button-text-alignment-and-direction-expected.png:
- platform/chromium-mac/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt: Removed.
- platform/chromium/test_expectations.txt:
- 14:31 Changeset [77972] by
-
2011-02-08 Daniel Bates <dbates@rim.com>
Rubber-stamped by Martin Robinson.
Rename enum ProtectionSeting [sic] to ProtectionSetting.
- jit/ExecutableAllocator.cpp: (JSC::ExecutableAllocator::reprotectRegion):
- jit/ExecutableAllocator.h:
- 14:25 Changeset [77971] by
-
2011-02-08 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] DRT needs an implementation of LayoutTestController.setIconDatabaseEnabled
https://bugs.webkit.org/show_bug.cgi?id=54033
- platform/gtk/Skipped: Unskip a test that is now passing.
2011-02-08 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] DRT needs an implementation of LayoutTestController.setIconDatabaseEnabled
https://bugs.webkit.org/show_bug.cgi?id=54033
Add a DumpRenderTreeSupportGtk method for turning the icon database on and off.
This is a likely candidate for a new API point.
- WebCoreSupport/DumpRenderTreeSupportGtk.cpp: (DumpRenderTreeSupportGtk::setIconDatabaseEnabled): Added.
- WebCoreSupport/DumpRenderTreeSupportGtk.h:
- webkit/webkitglobals.cpp: (webkitInit): Call setIconDatabaseEnabled(true) on startup, instead of initializing the database manually. (WebKit::setIconDatabaseEnabled): Added.
- webkit/webkitglobalsprivate.h: Added declarations.
2011-02-08 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] DRT needs an implementation of LayoutTestController.setIconDatabaseEnabled
https://bugs.webkit.org/show_bug.cgi?id=54033
Add an implementation of LayoutTestController.setIconDatabaseEnabled that just
call DumpRenderTreeSupportGtk. Turn off the icon database between tests.
- DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues): Turn off the icon database.
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setIconDatabaseEnabled): Call the appropriate DumpRenderTreeSupportGtk method.
- 14:11 Changeset [77970] by
-
Fix for <rdar://problem/8953365> CrashTracer: 14
crashes in WebProcess at com.apple.WebCore:
-[ScrollKnobAnimation setCurrentProgress:] + 258
Reviewed by Darin Adler.
This crash seems to happen when the animation is running
and a window is closed. If the ScrollAnimator is destroyed,
delegate calls for the animation can still run, so we have
to make sure we inform the delegates when the ScrollAnimator
is gone, and then we have to null-check it before we do
anything with it.
Remove scrollbarPainterDelegate() since it's not used anymore.
- platform/mac/ScrollAnimatorMac.h:
- platform/mac/ScrollAnimatorMac.mm:
Add null-checks for _animator
(-[ScrollbarPartAnimation setCurrentProgress:]):
(-[ScrollbarPartAnimation scrollAnimatorDestroyed]):
(-[ScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:]):
(-[ScrollbarPainterDelegate scrollerImp:animateTrackAlphaTo:duration:]):
(-[ScrollbarPainterDelegate scrollerImp:overlayScrollerStateChangedTo:]):
New function to inform the delegates that the ScrollAnimator
is being destroyed.
(-[ScrollbarPainterDelegate scrollAnimatorDestroyed]):
(WebCore::ScrollAnimatorMac::~ScrollAnimatorMac):
- 14:00 Changeset [77969] by
-
2011-02-08 Zhenyao Mo <zmo@google.com>
Unreviewed, typo fix.
- platform/chromium/test_expectations.txt
- 13:51 Changeset [77968] by
-
2011-02-08 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Crash calling -setFrame:andScrollBy: in windowDidResize
https://bugs.webkit.org/show_bug.cgi?id=54030
<rdar://problem/8969760>
- Platform/mac/SharedMemoryMac.cpp: (WebKit::SharedMemory::create): Assert that size is not zero here; we never want to try to create shared memory with a zero size.
- WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::setSize): Always invalidate the entire visible page when resizing.
- 13:09 Changeset [77967] by
-
2011-02-08 Martin Robinson <mrobinson@igalia.com>
Unskip some inspector tests that are passing locally. The bugs are
missing test diffs, so we can either reskip them and get more information
or have passing tests. Classify another failure.
- platform/gtk/Skipped: Clean up the skipped list.
- 13:06 Changeset [77966] by
-
2011-02-08 Zhenyao Mo <zmo@google.com>
Unreviewed, test expectations update.
- platform/chromium/test_expectations.txt
- 12:54 Changeset [77965] by
-
2011-02-08 Kenji Imasaki <imasaki@chromium.org>
Reviewed by Jian Li.
[Chromium] Remove non-Flaky media tests from test expectation file
https://bugs.webkit.org/show_bug.cgi?id=54021
- platform/chromium/test_expectations.txt:
- 12:19 Changeset [77964] by
-
2011-02-08 Xiaomei Ji <xji@chromium.org>
Unreviewed. Fix typo in rebaseline in r77961.
- platform/mac-leopard/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt:
- 12:17 Changeset [77963] by
-
2011-02-08 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Remove orphan code from old parser
https://bugs.webkit.org/show_bug.cgi?id=53984
This code appears to be unused.
- html/HTMLParserErrorCodes.cpp:
- html/HTMLParserErrorCodes.h:
- html/HTMLParserQuirks.h:
- loader/EmptyClients.h:
- page/ChromeClient.h:
2011-02-08 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Remove orphan code from old parser
https://bugs.webkit.org/show_bug.cgi?id=53984
- src/ChromeClientImpl.h:
2011-02-08 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Remove orphan code from old parser
https://bugs.webkit.org/show_bug.cgi?id=53984
- WebCoreSupport/ChromeClientEfl.h:
2011-02-08 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Remove orphan code from old parser
https://bugs.webkit.org/show_bug.cgi?id=53984
- WebCoreSupport/ChromeClientGtk.h:
2011-02-08 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Remove orphan code from old parser
https://bugs.webkit.org/show_bug.cgi?id=53984
- WebCoreSupport/ChromeClientHaiku.cpp:
- WebCoreSupport/ChromeClientHaiku.h:
2011-02-08 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Remove orphan code from old parser
https://bugs.webkit.org/show_bug.cgi?id=53984
- WebCoreSupport/WebChromeClient.h:
2011-02-08 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Remove orphan code from old parser
https://bugs.webkit.org/show_bug.cgi?id=53984
- WebCoreSupport/ChromeClientQt.h:
2011-02-08 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Remove orphan code from old parser
https://bugs.webkit.org/show_bug.cgi?id=53984
- WebCoreSupport/WebChromeClient.h:
2011-02-08 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Remove orphan code from old parser
https://bugs.webkit.org/show_bug.cgi?id=53984
- WebCoreSupport/ChromeClientWinCE.cpp:
- WebCoreSupport/ChromeClientWinCE.h:
2011-02-08 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Remove orphan code from old parser
https://bugs.webkit.org/show_bug.cgi?id=53984
- WebKitSupport/ChromeClientWx.h:
2011-02-08 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Remove orphan code from old parser
https://bugs.webkit.org/show_bug.cgi?id=53984
- WebProcess/WebCoreSupport/WebChromeClient.cpp
- WebProcess/WebCoreSupport/WebChromeClient.h
- 11:36 Changeset [77962] by
-
2011-02-08 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
UI process crashes if web process crashes while web inspector is focused
https://bugs.webkit.org/show_bug.cgi?id=53965
<rdar://problem/8961633>
Make sure to close the web inspector web page proxy before calling platformClose, since
platformClose can cause the web page proxy to try to send messages (such as SetActive)
to the web process while it's in a bad state.
The original fix, http://trac.webkit.org/changeset/77866, put the call to m_page->close() in
WebInspectorProxy::didClose, which was wrong and lead to crashes. The right place to close the page
is in WebInspectorProxy::invalidate.
- UIProcess/WebInspectorProxy.cpp: (WebKit::WebInspectorProxy::invalidate):
- 11:25 Changeset [77961] by
-
2011-02-08 Xiaomei Ji <xji@chromium.org>
Unreviewed.
Rebaseline after r77952.
- platform/chromium-linux/fast/text/international/pop-up-button-text-alignment-and-direction-expected.checksum: Added.
- platform/chromium-linux/fast/text/international/pop-up-button-text-alignment-and-direction-expected.png: Added.
- platform/chromium-linux/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt: Added.
- platform/chromium-mac/fast/text/international/pop-up-button-text-alignment-and-direction-expected.checksum: Added.
- platform/chromium-mac/fast/text/international/pop-up-button-text-alignment-and-direction-expected.png: Added.
- platform/chromium-mac/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt: Added.
- platform/chromium-win/fast/text/international/pop-up-button-text-alignment-and-direction-expected.checksum: Added.
- platform/chromium-win/fast/text/international/pop-up-button-text-alignment-and-direction-expected.png: Added.
- platform/chromium-win/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- platform/mac-leopard/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt: Added.
- platform/win/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt: Added.
- 11:15 Changeset [77960] by
-
2011-02-08 Martin Robinson <mrobinson@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GTK] Move scrollbar rendering out of gtk2drawing.c
https://bugs.webkit.org/show_bug.cgi?id=52836
Replace gtk2drawing.c scrollbar rendering with our own version. This
is the last use of the Mozilla theme drawing code.
No new tests. This should not change the rendering of the default
theme.
- platform/gtk/GtkVersioning.h: Add some more backported allocation setters.
- platform/gtk/RenderThemeGtk.h: Add a getter for the scrollbar widgets.
- platform/gtk/RenderThemeGtk2.cpp: Initialize and add getters for scrollbar widgets. (WebCore::RenderThemeGtk::platformInit): Ditto. (WebCore::RenderThemeGtk::gtkHScrollbar): Ditto. (WebCore::RenderThemeGtk::gtkVScrollbar): Ditto.
- platform/gtk/ScrollbarThemeGtk.cpp: (WebCore::ScrollbarThemeGtk::paint): We only repaint the scrolled window background if we are repainting a button or the thumb. In that case also repaint the track rect.
- platform/gtk/ScrollbarThemeGtk2.cpp: Port to WidgetRenderingContext. (WebCore::ScrollbarThemeGtk::ScrollbarThemeGtk): Ditto. (WebCore::ScrollbarThemeGtk::updateThemeProperties): Ditto. (WebCore::getWidgetForScrollbar): Ditto. (WebCore::ScrollbarThemeGtk::paintTrackBackground): Ditto. (WebCore::ScrollbarThemeGtk::paintScrollbarBackground): Ditto. (WebCore::ScrollbarThemeGtk::paintThumb): Ditto. (WebCore::ScrollbarThemeGtk::paintButton): Ditto.
- platform/gtk/WidgetRenderingContext.cpp: Ditto. (WebCore::WidgetRenderingContext::gtkPaintBox): Added an option which also adjusts a widget allocation according to the paint rect. This is necessary to properly draw scrollbar buttons.
- platform/gtk/WidgetRenderingContext.h: Ditto.
- 11:12 Changeset [77959] by
-
2011-02-08 Zhenyao Mo < zmo@google.com>
Unreviewed, test expectations update.
- LauoutTests/platform/chromium/test_expectations.txt
- 10:57 Changeset [77958] by
-
2011-02-08 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dan Bernstein.
Inset shadow with large offset renders incorrectly
https://bugs.webkit.org/show_bug.cgi?id=53882
Fix an issue with inset shadows, when the shadow offset
was larger than the box size. In this case we'd fail to
fill the box with the shadow color.
Test: fast/box-shadow/inset-shadow-large-offset.html
- rendering/RenderBoxModelObject.cpp: (WebCore::areaCastingShadowInHole): Return a rect that covers the area which contributes to the inset shadow.
(WebCore::RenderBoxModelObject::paintBoxShadow): Use areaCastingShadowInHole()
to compute the outerRect.
- 10:56 Changeset [77957] by
-
2011-02-08 Tony Chang <tony@chromium.org>
Unreviewed, build fix for clobber builds of DRT on mac/linux.
This file moved in chromium r73530 and this path wasn't changed.
- WebKit.gyp:
- 10:47 Changeset [77956] by
-
2011-02-08 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
drawElements should check if a buffer is bound to ELEMENT_ARRAY_BUFFER
https://bugs.webkit.org/show_bug.cgi?id=54017
- fast/canvas/webgl/draw-elements-out-of-bounds-expected.txt:
- fast/canvas/webgl/draw-elements-out-of-bounds.html:
2011-02-08 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
drawElements should check if a buffer is bound to ELEMENT_ARRAY_BUFFER
https://bugs.webkit.org/show_bug.cgi?id=54017
- html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::drawElements):
- 10:37 Changeset [77955] by
-
2011-02-08 Xiaomei Ji <xji@chromium.org>
Unreviewed. after r77952,
skip pop-up-button-text-alignment-and-direction.html in qt and gtk as bidi-menulist.html.
set it as expect to fail in chromium.
- platform/chromium/test_expectations.txt:
- platform/gtk/Skipped:
- platform/qt/Skipped:
- 10:35 Changeset [77954] by
-
2011-01-28 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Darin Adler.
Change the rest of HTMLMediaElement shadow DOM parts to use shadowPseudoId.
https://bugs.webkit.org/show_bug.cgi?id=53190
This is the second part of refactoring the HTMLMediaElement to use new
shadow DOM. The changes are mainly mechanical, except for needing to
add a new method to RenderTheme, which indicates whether or not status
display is being used by it. Previously, we relied on existence of a cached
pseudo style.
Refactoring, covered by existing tests.
- css/CSSSelector.cpp: (WebCore::CSSSelector::pseudoId): Removed now-unused enum values. (WebCore::nameToPseudoTypeMap): Ditto. (WebCore::CSSSelector::extractPseudoType): Ditto.
- css/CSSSelector.h: Ditto.
- html/shadow/MediaControls.cpp: (WebCore::MediaControls::createPanel): Changed to use the newly-added MediaControlPanelElement. (WebCore::MediaControls::createCurrentTimeDisplay): Changed to use the newly-added
MediaControlCurrentTimeDisplayElement.
(WebCore::MediaControls::createTimeRemainingDisplay): Changed to use the newly-added
MediaControlTimeRemainingDisplayElement.
- rendering/MediaControlElements.cpp: (WebCore::MediaControlShadowRootElement::updateStyle): Changed to use the
standard style resolution.
(WebCore::MediaControlShadowRootElement::shadowPseudoId): Added.
(WebCore::MediaControlElement::MediaControlElement): Removed the switch statement
that is no longer necessary.
(WebCore::MediaControlElement::styleForElement): Changed to use the standard
style resolution.
(WebCore::MediaControlPanelElement::MediaControlPanelElement): Added.
(WebCore::MediaControlPanelElement::create): Added.
(WebCore::MediaControlPanelElement::displayType): Added.
(WebCore::MediaControlPanelElement::shadowPseudoId): Added.
(WebCore::MediaControlTimelineContainerElement::MediaControlTimelineContainerElement):
Removed PseudoId constructor arg.
(WebCore::MediaControlTimelineContainerElement::rendererIsNeeded):
Changed to use the newly-plumbed usesMediaControlStatusDisplay helper.
(WebCore::MediaControlTimelineContainerElement::displayType): Added.
(WebCore::MediaControlTimelineContainerElement::shadowPseudoId): Added.
(WebCore::MediaControlVolumeSliderContainerElement::MediaControlVolumeSliderContainerElement):
Removed PseudoId constructor arg.
(WebCore::MediaControlVolumeSliderContainerElement::displayType): Added.
(WebCore::MediaControlVolumeSliderContainerElement::shadowPseudoId): Added.
(WebCore::MediaControlStatusDisplayElement::MediaControlStatusDisplayElement):
Removed PseudoId constructor arg.
(WebCore::MediaControlStatusDisplayElement::rendererIsNeeded): Changed to
use the newly-plumbed usesMediaControlStatusDisplay helper.
(WebCore::MediaControlStatusDisplayElement::displayType): Added.
(WebCore::MediaControlStatusDisplayElement::shadowPseudoId): Added.
(WebCore::MediaControlTimeDisplayElement::MediaControlTimeDisplayElement):
Removed PseudoId constructor arg.
(WebCore::MediaControlTimeRemainingDisplayElement::create): Added.
(WebCore::MediaControlTimeRemainingDisplayElement::MediaControlTimeRemainingDisplayElement): Added.
(WebCore::MediaControlTimeRemainingDisplayElement::displayType): Added.
(WebCore::MediaControlTimeRemainingDisplayElement::shadowPseudoId): Added.
(WebCore::MediaControlCurrentTimeDisplayElement::create): Added.
(WebCore::MediaControlCurrentTimeDisplayElement::MediaControlCurrentTimeDisplayElement): Added.
(WebCore::MediaControlCurrentTimeDisplayElement::displayType): Added.
(WebCore::MediaControlCurrentTimeDisplayElement::shadowPseudoId): Added.
- rendering/MediaControlElements.h: Added/changed defs accordingly.
- rendering/RenderTheme.h: (WebCore::RenderTheme::usesMediaControlStatusDisplay): Added.
- rendering/RenderThemeMac.h: Added def.
- rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::usesMediaControlStatusDisplay): Added.
- rendering/style/RenderStyleConstants.h: Removed now-unused enum values.
- 10:32 Changeset [77953] by
-
<rdar://problem/8932077> REGRESSION (5.0.3-ToT): United boarding pass has wrong layout when printed
Reviewed by Adam Roben.
Windows never got patched to pass in the page height to WebCore, so when WebCore's pagination got re-written to depend on this
value, Windows got broken. Patch setPrinting to be identical to WebKit1 on OS X and to have it take an extra minimum page height
argument.
- WebFrame.cpp:
(WebFrame::setPrinting):
(WebFrame::setInPrintingMode):
- WebFrame.h:
- 10:22 Changeset [77952] by
-
2011-02-08 Xiaomei Ji <xji@chromium.org>
Reviewed by Dan Bernstein.
Fix pop-up button text not rendered correctly according to its direction
in <option>.
https://bugs.webkit.org/show_bug.cgi?id=53642
In adjustInnerStyle(), if m_innerBlock's direction or unicode-bidi
changes, set it needs layout.
- fast/text/international/pop-up-button-text-alignment-and-direction.html: Added.
- platform/mac/fast/text/international/pop-up-button-text-alignment-and-direction-expected.checksum: Added.
- platform/mac/fast/text/international/pop-up-button-text-alignment-and-direction-expected.png: Added.
- platform/mac/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt: Added.
2011-02-08 Xiaomei Ji <xji@chromium.org>
Reviewed by Dan Bernstein.
Fix pop-up button text not rendered correctly according to its direction
in <option>.
https://bugs.webkit.org/show_bug.cgi?id=53642
In adjustInnerStyle(), if m_innerBlock's direction or unicode-bidi
changes, set it needs layout.
Test: fast/text/international/pop-up-button-text-alignment-and-direction.html
- rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::adjustInnerStyle):
- 10:01 Changeset [77951] by
-
2011-02-08 Ilya Tikhonovsky <loislo@chromium.org>
Unreviewed build fix for Qt-minimal.
- inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::hasFrontend):
- 09:32 Changeset [77950] by
-
2011-02-02 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: move InspectorController's methods from InspectorAgent to InspectorController.
All the Inspector API for WebCore has two parts.
The first one is InspectorInstrumentation for WebCore.
The second is InspectorController for WebKit.
InspectorAgent was produced by renaming original InspectorController.
This patch extracts WebKit related methods from InspectorAgent to InspectorController.
- WebCore.exp.in:
- bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:
- html/HTMLDocument.cpp: (WebCore::HTMLDocument::createParser):
- inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::InspectorAgent): (WebCore::InspectorAgent::~InspectorAgent): (WebCore::InspectorAgent::restoreInspectorStateFromCookie): (WebCore::InspectorAgent::inspect): (WebCore::InspectorAgent::handleMousePress): (WebCore::InspectorAgent::didClearWindowObjectInWorld): (WebCore::InspectorAgent::setFrontend): (WebCore::InspectorAgent::disconnectFrontend): (WebCore::InspectorAgent::resourceAgent): (WebCore::InspectorAgent::createFrontendLifetimeAgents): (WebCore::InspectorAgent::releaseFrontendLifetimeAgents): (WebCore::InspectorAgent::populateScriptObjects): (WebCore::InspectorAgent::pushDataCollectedOffline): (WebCore::InspectorAgent::restoreProfiler): (WebCore::InspectorAgent::startTimelineProfiler): (WebCore::PostWorkerNotificationToFrontendTask::performTask): (WebCore::InspectorAgent::didOpenDatabase): (WebCore::InspectorAgent::didUseDOMStorage): (WebCore::InspectorAgent::showAndEnableDebugger): (WebCore::InspectorAgent::enableDebugger): (WebCore::InspectorAgent::enabled):
- inspector/InspectorAgent.h: (WebCore::InspectorAgent::frontend):
- inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::~InspectorController): (WebCore::InspectorController::setInspectorFrontendClient): (WebCore::InspectorController::hasInspectorFrontendClient): (WebCore::InspectorController::didClearWindowObjectInWorld): (WebCore::InspectorController::startTimelineProfiler): (WebCore::InspectorController::stopTimelineProfiler): (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::disconnectFrontend): (WebCore::InspectorController::disconnectFrontendImpl): (WebCore::InspectorController::show): (WebCore::InspectorController::close): (WebCore::InspectorController::restoreInspectorStateFromCookie): (WebCore::InspectorController::evaluateForTestInFrontend): (WebCore::InspectorController::drawNodeHighlight): (WebCore::InspectorController::inspect): (WebCore::InspectorController::enabled): (WebCore::InspectorController::showPanel): (WebCore::InspectorController::frontendLoaded): (WebCore::InspectorController::timelineProfilerEnabled): (WebCore::InspectorController::enableProfiler): (WebCore::InspectorController::disableProfiler): (WebCore::InspectorController::profilerEnabled): (WebCore::InspectorController::debuggerEnabled): (WebCore::InspectorController::showAndEnableDebugger): (WebCore::InspectorController::disableDebugger): (WebCore::InspectorController::startUserInitiatedProfiling): (WebCore::InspectorController::stopUserInitiatedProfiling): (WebCore::InspectorController::isRecordingUserInitiatedProfile): (WebCore::InspectorController::setInspectorExtensionAPI): (WebCore::InspectorController::resume): (WebCore::InspectorController::hideHighlight): (WebCore::InspectorController::dispatchMessageFromFrontend):
- inspector/InspectorController.h: (WebCore::InspectorController::inspectorClient): (WebCore::InspectorController::inspectedPage): (WebCore::InspectorController::hasFrontend):
- inspector/InspectorFrontendClientLocal.cpp: (WebCore::InspectorFrontendClientLocal::sendMessageToBackend):
- inspector/InspectorFrontendHost.cpp: (WebCore::InspectorFrontendHost::setExtensionAPI):
- inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::didClearWindowObjectInWorldImpl): (WebCore::InspectorInstrumentation::profilerEnabledImpl):
- inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::hasFrontend):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
2011-02-02 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: move InspectorController's methods from InspectorAgent to InspectorController.
Minor change enforced by major changes in WebCore/inspector/InspectorController.
- src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::dispatchOnInspectorBackend):
- src/WebViewImpl.h:
2011-02-02 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: move InspectorController's methods from InspectorAgent to InspectorController.
Minor change enforced by major changes in WebCore/inspector/InspectorController.
- WebCoreSupport/InspectorClientGtk.cpp:
- webkit/webkitwebinspector.cpp: (webkit_web_inspector_get_property):
2011-02-02 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: move InspectorController's methods from InspectorAgent to InspectorController.
Minor change enforced by major changes in WebCore/inspector/InspectorController.
- WebInspector/WebInspector.mm: (-isTimelineProfilingEnabled):
2011-02-02 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: move InspectorController's methods from InspectorAgent to InspectorController.
Minor change enforced by major changes in WebCore/inspector/InspectorController.
- WebInspector.cpp: (WebInspector::isTimelineProfilingEnabled):
- 09:30 Changeset [77949] by
-
2011-02-08 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Martin Robinson.
editing/selection/end-of-document.html is failing in the GTK 64-bit debug bot
https://bugs.webkit.org/show_bug.cgi?id=53995
Ensure to wait for the body to be loaded before running the test.
- editing/selection/end-of-document.html: Call runEditingTest() on the body.onload event.
- 09:27 Changeset [77948] by
-
2011-02-08 Balazs Kelemen <kbalazs@webkit.org>
Reviewed by Andreas Kling.
[Qt] Should not always define USE_SYSTEM_MALLOC
https://bugs.webkit.org/show_bug.cgi?id=54007
- wtf/Platform.h:
- 09:21 Changeset [77947] by
-
2011-02-08 Kundu Suchismita <suchi.kundu@nokia.com>
Reviewed by Laszlo Gombos.
Local Storage settings can be enable/disable from "Develop" menu
https://bugs.webkit.org/show_bug.cgi?id=52296
- QtTestBrowser/launcherwindow.cpp: (LauncherWindow::createChrome): (LauncherWindow::toggleLocalStorage): (LauncherWindow::toggleOfflineStorageDatabase): (LauncherWindow::toggleOfflineWebApplicationCache): (LauncherWindow::setOfflineStorageDefaultQuota):
- QtTestBrowser/launcherwindow.h: (WindowOptions::WindowOptions):
- QtTestBrowser/main.cpp: (LauncherApplication::handleUserOptions):
- 09:16 Changeset [77946] by
-
2011-02-08 George Wright <gwright@rim.com>
Reviewed by Adam Barth.
Ensure that we pack the colour byte order correctly for Skia using
Skia's SkPackARGB32 function.
- platform/image-decoders/ImageDecoder.h: (WebCore::ImageFrame::setRGBA):
- 09:05 Changeset [77945] by
-
2011-02-08 George Wright <gwright@rim.com>
Reviewed by Darin Adler.
Ensure we do not pass (-1, -1) sized rects to ImageBuffer but instead
pass the full image dimensions.
- platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::drawImageBuffer):
- 08:50 Changeset [77944] by
-
2011-02-08 Patrick Gansterer <paroga@webkit.org>
Reviewed by Adam Roben.
[WIN] Add missing includes and forward declarations for DownloadBundle
https://bugs.webkit.org/show_bug.cgi?id=53881
- platform/network/cf/DownloadBundle.h:
- platform/network/win/DownloadBundleWin.cpp: (WebCore::DownloadBundle::appendResumeData):
- 08:47 Changeset [77943] by
-
2011-02-08 Patrick Gansterer <paroga@webkit.org>
Reviewed by Adam Roben.
[WIN] Add missing include in WKCAImageQueue
https://bugs.webkit.org/show_bug.cgi?id=53890
- platform/graphics/win/WKCAImageQueue.cpp:
- 08:28 Changeset [77942] by
-
ASSERTION FAILURE: ASSERT_NOT_REACHED() in Connection::writeEventHandler() after the Web
Process crashes.
https://bugs.webkit.org/show_bug.cgi?id=54005
Reviewed by Adam Roben.
- Platform/CoreIPC/win/ConnectionWin.cpp:
(CoreIPC::Connection::writeEventHandler):
Handle ERROR_BROKEN_PIPE by calling connectionDidClose() and returning early.
- 08:17 Changeset [77941] by
-
2011-02-08 Patrick Gansterer <paroga@webkit.org>
Reviewed by Adam Roben.
[WIN] Add missing forward declarations in WebKitSystemInterface.h
https://bugs.webkit.org/show_bug.cgi?id=53889
- win/include/WebKitSystemInterface/WebKitSystemInterface.h:
- 08:08 Changeset [77940] by
-
2011-02-08 Martin Robinson <mrobinson@igalia.com>
Unskip a bunch of tests that are passing locally and move one
timeout with the other timeouts.
- platform/gtk/Skipped: Unskip some passing tests.
- 08:03 Changeset [77939] by
-
Handle WM_TIMER messages for stopped timers
Whenever we stop a timer, we call ::KillTimer to cancel any future firings of the timer. But
::KillTimer doesn't do anything about WM_TIMER messages that have already been posted to the
message queue. We need to handle those, too.
Fixes <http://webkit.org/b/53999> Occasional assertion failures in
RunLoop::TimerBase::timerFired
Reviewed by Darin Adler.
- Platform/win/RunLoopWin.cpp:
(RunLoop::TimerBase::timerFired): Just bail if the timer has already been stopped.
- 08:01 Changeset [77938] by
-
Don't mark a Connection as connected until open() is called on Windows
This matches Mac. Even though the Connection's pipe is connected before open() is called,
the Connection itself isn't really connected to the pipe until then, and we won't actually
read any data from before that point.
Fixes <http://webkit.org/b/53998> <rdar://problem/8971207> REGRESSION (r77874): Assertion
failure on launch in Connection::setDidCloseOnConnectionWorkQueueCallback on Windows
Reviewed by Darin Adler.
- Platform/CoreIPC/win/ConnectionWin.cpp:
(CoreIPC::Connection::platformInitialize): Moved code to set m_isConnected from here to
open.
(CoreIPC::Connection::platformInvalidate): Unset m_isConnected, to match Mac. (This isn't
part of the bug fix, but seemed worthwhile.)
(CoreIPC::Connection::open): Set m_isConnected now that we're going to listen on the pipe.
- 07:58 Changeset [77937] by
-
2011-02-08 Patrick Gansterer <paroga@webkit.org>
Reviewed by Adam Roben.
[WIN] Add missing includes and forward declarations for CFNetwork
https://bugs.webkit.org/show_bug.cgi?id=53883
- platform/network/cf/DNSCFNet.cpp:
- platform/network/cf/LoaderRunLoopCF.cpp:
- platform/network/cf/LoaderRunLoopCF.h:
- platform/network/cf/ProxyServerCFNet.cpp:
- platform/network/cf/SocketStreamHandle.h:
- platform/network/cf/SocketStreamHandleCFNet.cpp:
- 07:57 Changeset [77936] by
-
2011-02-08 Martin Robinson <mrobinson@igalia.com>
Reviewed by Eric Seidel.
[GTK] EventSender.keyDown does not support non-array modifier arguments
https://bugs.webkit.org/show_bug.cgi?id=53962
- platform/gtk/Skipped: Unskip a test which is now passing.
2011-02-08 Martin Robinson <mrobinson@igalia.com>
Reviewed by Eric Seidel.
[GTK] EventSender.keyDown does not support non-array modifier arguments
https://bugs.webkit.org/show_bug.cgi?id=53962
Support handling either an array or a string for the modifier argument
to EventSender.keyDown.
- DumpRenderTree/gtk/EventSender.cpp: (gdkModifierFromJSValue): Added this helper which factors out the string comparison bits. (gdkModifersFromJSValue): Test up front whether the value is a string, to handle it specially.
- 07:51 Changeset [77935] by
-
2011-02-08 Patrick Gansterer <paroga@webkit.org>
Unreviewed WinCE build fix for r77870.
- platform/DragImage.cpp: Compile createDragImageForLink on WinCE.
- 07:48 Changeset [77934] by
-
2011-02-08 Pavel Feldman <pfeldman@chromium.org>
Not reviewed. Removing inspector tests from Skipped on [win].
Resource tracking has been removed since then, maybe it'll help.
- platform/win/Skipped:
- 07:46 Changeset [77933] by
-
2011-02-08 Martin Robinson <mrobinson@igalia.com>
Clean up the skipped list slightly and unskip a test which should now be passing.
- platform/gtk/Skipped: Clean up.
- 07:40 Changeset [77932] by
-
2011-02-08 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: open network resource url in new tab upon double click.
https://bugs.webkit.org/show_bug.cgi?id=53930
- inspector/front-end/NetworkPanel.js: (WebInspector.NetworkDataGridNode.prototype.createCells): (WebInspector.NetworkDataGridNode.prototype._openInNewTab):
- 07:34 Changeset [77931] by
-
2011-02-08 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: $x: any node should work in optional context parameter.
https://bugs.webkit.org/show_bug.cgi?id=50138
- inspector/InjectedScriptSource.js:
- 07:30 Changeset [77930] by
-
2011-02-08 Patrick Gansterer <paroga@webkit.org>
Unreviewed WinCE build fix for r77870.
Remove the global namespace prefix from GlobalLock/GlobalUnlock.
- platform/win/ClipboardUtilitiesWin.cpp:
- 07:27 Changeset [77929] by
-
2011-02-08 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: re-apply r77924.
Test: inspector/console-api-on-call-frame.html
- inspector/InjectedScriptSource.js:
- inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer.prototype._onEvaluateOnInspectedPage):
- 07:08 Changeset [77928] by
-
2011-02-08 Andreas Kling <kling@webkit.org>
Reviewed by Tor Arne Vestbø.
REGRESSION(r77312): Unbreak TiledBackingStore.
Due to an off-by-one error, we were no longer rendering the
rightmost column and bottom row of tiles.
Covered by tst_QGraphicsWebView::widgetsRenderingThroughCache().
- platform/graphics/TiledBackingStore.cpp: (WebCore::TiledBackingStore::invalidate): (WebCore::TiledBackingStore::updateTileBuffers): (WebCore::TiledBackingStore::paint): (WebCore::TiledBackingStore::createTiles):
- 06:26 Changeset [77927] by
-
2011-02-08 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r77924.
http://trac.webkit.org/changeset/77924
https://bugs.webkit.org/show_bug.cgi?id=53997
Breaks inspector tests. (Requested by pfeldman on #webkit).
- inspector/console-api-on-call-frame-expected.txt: Removed.
- inspector/console-api-on-call-frame.html: Removed.
2011-02-08 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r77924.
http://trac.webkit.org/changeset/77924
https://bugs.webkit.org/show_bug.cgi?id=53997
Breaks inspector tests. (Requested by pfeldman on #webkit).
- inspector/InjectedScriptSource.js: (.): ():
- 06:04 Changeset [77926] by
-
2011-02-08 Benjamin Poulain <ikipou@gmail.com>
Reviewed by Csaba Osztrogonác.
openDatabaseSync() stop responding after too many call
https://bugs.webkit.org/show_bug.cgi?id=53945
Reset the database quota to a known state between each test.
Define a quota for the known origins at each test run and delete
all the databases.
This way, the database related test do not depend on previous
allocations.
- DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): (WebCore::DumpRenderTree::dumpDatabaseQuota):
- DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::reset):
- 05:42 Changeset [77925] by
-
2011-02-04 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [refacotring] merge InspectorAgent::willSendRequest() into InspectorResourceAgent
https://bugs.webkit.org/show_bug.cgi?id=53789
- perform UserAgent override via InspectorInstrumentation
- move adding extra request headers to InspectorResourceAgent
- simplified things in InspectorState
- inspector/Inspector.idl:
- inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::disconnectFrontend): (WebCore::InspectorAgent::applyUserAgentOverride):
- inspector/InspectorAgent.h:
- inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::applyUserAgentOverrideImpl): (WebCore::InspectorInstrumentation::willSendRequestImpl):
- inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::applyUserAgentOverride):
- inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::setExtraHeaders): (WebCore::InspectorResourceAgent::willSendRequest):
- inspector/InspectorResourceAgent.h:
- inspector/InspectorState.cpp: (WebCore::InspectorState::InspectorState): (WebCore::InspectorState::restoreFromInspectorCookie): (WebCore::InspectorState::updateCookie): (WebCore::InspectorState::setValue): (WebCore::InspectorState::getBoolean): (WebCore::InspectorState::getString): (WebCore::InspectorState::getLong): (WebCore::InspectorState::getObject):
- inspector/InspectorState.h: (WebCore::InspectorState::setObject):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::userAgent):
- 05:29 Changeset [77924] by
-
2011-02-08 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: do not hide scope variables with command line api.
https://bugs.webkit.org/show_bug.cgi?id=53497
- inspector/console-api-on-call-frame-expected.txt: Added.
- inspector/console-api-on-call-frame.html: Added.
2011-02-08 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: do not hide scope variables with command line api.
https://bugs.webkit.org/show_bug.cgi?id=53497
Test: inspector/console-api-on-call-frame.html
- inspector/InjectedScriptSource.js:
- 05:03 Changeset [77923] by
-
2011-02-08 Lucas De Marchi <lucas.demarchi@profusion.mobi>
Unreviewed build fix.
[EFL] Fix when building with curl backend.
- ewk/ewk_settings.cpp: (ewk_settings_proxy_uri_get):
- 04:57 Changeset [77922] by
-
2011-02-07 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: ignore cache upon reload via Ctrl(Cmd)+Shift+R.
https://bugs.webkit.org/show_bug.cgi?id=53914
- http/tests/inspector/inspector-test2.js: (initialize_InspectorTest.InspectorTest.reloadPage):
- inspector/audits-panel-functional.html:
2011-02-07 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: ignore cache upon reload via Ctrl(Cmd)+Shift+R.
https://bugs.webkit.org/show_bug.cgi?id=53914
- inspector/Inspector.idl:
- inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::reloadPage):
- inspector/InspectorAgent.h:
- inspector/front-end/AuditsPanel.js: (WebInspector.AuditsPanel.prototype._reloadResources):
- inspector/front-end/ExtensionServer.js: (WebInspector.ExtensionServer.prototype._onReload):
- inspector/front-end/inspector.js: (WebInspector.documentKeyDown):
- 04:45 Changeset [77921] by
-
2011-02-08 Mario Sanchez Prada <msanchez@igalia.com>
Unreviewed, skipping test timing out on GTK 32-bit debug bot.
fast/loader/onload-willSendRequest-null-for-frame.html times out in GTK 32-bit debug bot
https://bugs.webkit.org/show_bug.cgi?id=53992
- platform/gtk/Skipped: Skipped test.
- 03:26 Changeset [77920] by
-
2011-02-08 Mario Sanchez Prada <msanchez@igalia.com>
Unreviewed, skipping flaky test on GTK debug bots.
fast/frames/sandboxed-iframe-storage.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=53991
- platform/gtk/Skipped: Skipped test.
- 02:52 Changeset [77919] by
-
Skip over sibling selectors when collecting descendant selector hashes
https://bugs.webkit.org/show_bug.cgi?id=53987
Reviewed by Cameron Zwarich.
Skip instead of bailing out. This will allow optimizing some sibling selector cases.
- css/CSSStyleSelector.cpp:
(WebCore::RuleData::RuleData):
(WebCore::RuleData::collectIdentifierHashes):
(WebCore::RuleData::collectDescendantSelectorIdentifierHashes):
- css/CSSStyleSelector.h:
- 02:50 Changeset [77918] by
-
2011-02-08 Mario Sanchez Prada <msanchez@igalia.com>
Unreviewed, skipping flaky test on GTK debug bots.
svg/custom/use-multiple-on-nested-disallowed-font.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=53989
- platform/gtk/Skipped: Skipped test.
- 02:20 Changeset [77917] by
-
2011-02-08 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] DRT's TextInputController is unimplemented on GTK
https://bugs.webkit.org/show_bug.cgi?id=52997
- platform/gtk/Skipped: Unskip several tests that pass now that we have TextInputController.
2011-02-08 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] DRT's TextInputController is unimplemented on GTK
https://bugs.webkit.org/show_bug.cgi?id=52997
- WebCoreSupport/DumpRenderTreeSupportGtk.cpp: (DumpRenderTreeSupportGtk::setComposition): (DumpRenderTreeSupportGtk::confirmComposition): (DumpRenderTreeSupportGtk::firstRectForCharacterRange): (DumpRenderTreeSupportGtk::selectedRange): New methods needed by TextInputController.
- WebCoreSupport/DumpRenderTreeSupportGtk.h:
2011-02-08 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] DRT's TextInputController is unimplemented on GTK
https://bugs.webkit.org/show_bug.cgi?id=52997
Initial implementation of TextInputController for GTK port.
- DumpRenderTree/gtk/DumpRenderTree.cpp: (webViewWindowObjectCleared):
- DumpRenderTree/gtk/TextInputController.cpp: Added. (setMarkedTextCallback): (insertTextCallback): (unmarkTextCallback): (firstRectForCharacterRangeCallback): (selectedRangeCallback): (getClass): (makeTextInputController):
- DumpRenderTree/gtk/TextInputController.h: Added.
- GNUmakefile.am:
- 01:18 Changeset [77916] by
-
LLVM Compiler build fix.
Reviewed by Maciej Stachowiak.
- runtime/WriteBarrier.h:
(JSC::WriteBarrier::WriteBarrier):
- 00:49 Changeset [77915] by
-
2011-02-08 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r77866.
http://trac.webkit.org/changeset/77866
https://bugs.webkit.org/show_bug.cgi?id=53981
caused all WebKit2 inspector tests to crash (Requested by
othermaciej on #webkit).
- UIProcess/WebInspectorProxy.cpp: (WebKit::WebInspectorProxy::didClose):
02/07/11:
- 23:44 Changeset [77914] by
-
2011-02-07 Cris Neckar <cdn@chromium.org>
Reviewed by Jian Li.
Test for null deref in DOMURL
https://bugs.webkit.org/show_bug.cgi?id=53811
- fast/files/domurl-script-execution-context-crash-expected.txt: Added.
- fast/files/domurl-script-execution-context-crash.html: Added.
2011-02-07 Cris Neckar <cdn@chromium.org>
Reviewed by Jian Li.
Fix null deref in DOMURL
https://bugs.webkit.org/show_bug.cgi?id=53811
Test: fast/files/domurl-script-execution-context-crash.html
- html/DOMURL.cpp: (WebCore::DOMURL::DOMURL):
- 23:30 Changeset [77913] by
-
2011-02-07 Tony Chang <tony@chromium.org>
Reviewed by Adam Barth.
clean up python imports
https://bugs.webkit.org/show_bug.cgi?id=53966
Convert "import A.B.C.D as D" to "from A.B.C import D" and
make some imports absolute as required by PEP-8
- Scripts/webkitpy/common/checkout/scm.py:
- Scripts/webkitpy/common/net/irc/ircbot.py:
- Scripts/webkitpy/common/system/logutils.py:
- Scripts/webkitpy/common/system/logutils_unittest.py:
- Scripts/webkitpy/layout_tests/deduplicate_tests.py:
- Scripts/webkitpy/layout_tests/port/chromium.py:
- Scripts/webkitpy/layout_tests/port/mac.py: Remove some unused imports
- Scripts/webkitpy/layout_tests/port/webkit.py:
- Scripts/webkitpy/layout_tests/update_webgl_conformance_tests.py:
- Scripts/webkitpy/tool/bot/irc_command.py:
- Scripts/webkitpy/tool/bot/sheriffircbot.py:
- Scripts/webkitpy/tool/commands/download.py:
- Scripts/webkitpy/tool/commands/prettydiff.py:
- Scripts/webkitpy/tool/commands/queries.py:
- Scripts/webkitpy/tool/commands/roll.py:
- Scripts/webkitpy/tool/commands/stepsequence.py:
- Scripts/webkitpy/tool/commands/upload.py:
- Scripts/webkitpy/tool/main.py:
- 23:29 Changeset [77912] by
-
2011-02-07 James Robinson <jamesr@chromium.org>
Reviewed by Adam Barth.
Teach do-webcore-rename about the WebKit move to Source/
https://bugs.webkit.org/show_bug.cgi?id=53967
- Scripts/do-webcore-rename:
- 23:24 Changeset [77911] by
-
Unreviewed.
[Qt] Fix crashes in QMetaObject::metacall
https://bugs.webkit.org/show_bug.cgi?id=53912
- platform/qt/Skipped: http/tests/websocket/tests/websocket-protocol-ignored.html added until fix.
- 23:13 Changeset [77910] by
-
Fix the 32-bit build.
- platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::didAddVerticalScrollbar): Remove some extraneous characters.
(WebCore::ScrollAnimatorMac::didAddHorizontalScrollbar): Ditto.
- 23:07 Changeset [77909] by
-
2011-02-07 Kenji Imasaki <imasaki@chromium.org>
Reviewed by David Levin.
[Chromium] Remove non-Flaky media layout tests and update bugs that
are associated with media layout tests
https://bugs.webkit.org/show_bug.cgi?id=53948
- platform/chromium/test_expectations.txt:
- 23:07 Changeset [77908] by
-
2011-02-07 Maciej Stachowiak <mjs@apple.com>
Reviewed by Dan Bernstein.
Add resource load client for injected bundle and move willSendRequest there
https://bugs.webkit.org/show_bug.cgi?id=53972
- GNUmakefile.am:
- WebKit2.pro:
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/InjectedBundle/API/c/WKBundlePage.cpp: (WKBundlePageSetPageLoaderClient): (WKBundlePageSetResourceLoadClient):
- WebProcess/InjectedBundle/API/c/WKBundlePage.h:
- WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:
- WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
- WebProcess/InjectedBundle/InjectedBundlePageResourceLoadClient.cpp: Added. (WebKit::InjectedBundlePageResourceLoadClient::didInitiateLoadForResource): (WebKit::InjectedBundlePageResourceLoadClient::willSendRequestForFrame): (WebKit::InjectedBundlePageResourceLoadClient::didReceiveResponseForResource): (WebKit::InjectedBundlePageResourceLoadClient::didReceiveContentLengthForResource): (WebKit::InjectedBundlePageResourceLoadClient::didFinishLoadForResource): (WebKit::InjectedBundlePageResourceLoadClient::didFailLoadForResource):
- WebProcess/InjectedBundle/InjectedBundlePageResourceLoadClient.h: Added.
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::assignIdentifierToInitialRequest): (WebKit::WebFrameLoaderClient::dispatchWillSendRequest): (WebKit::WebFrameLoaderClient::dispatchDidReceiveResponse): (WebKit::WebFrameLoaderClient::dispatchDidReceiveContentLength): (WebKit::WebFrameLoaderClient::dispatchDidFinishLoading): (WebKit::WebFrameLoaderClient::dispatchDidFailLoading):
- WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::initializeInjectedBundleResourceLoadClient):
- WebProcess/WebPage/WebPage.h: (WebKit::WebPage::injectedBundleResourceLoadClient):
- win/WebKit2.vcproj:
2011-02-07 Maciej Stachowiak <mjs@apple.com>
Reviewed by Dan Bernstein.
Add resource load client for injected bundle and move willSendRequest there
https://bugs.webkit.org/show_bug.cgi?id=53972
- MiniBrowser/mac/WebBundle/WebBundleMain.m: (didCreatePage):
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::InjectedBundlePage): (WTR::InjectedBundlePage::didInitiateLoadForResource): (WTR::InjectedBundlePage::didReceiveResponseForResource): (WTR::InjectedBundlePage::didReceiveContentLengthForResource): (WTR::InjectedBundlePage::didFinishLoadForResource): (WTR::InjectedBundlePage::didFailLoadForResource): (WTR::InjectedBundlePage::willSendRequestForFrame):
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
- 23:07 Changeset [77907] by
-
2011-02-07 Xiyuan Xia <xiyuan@chromium.org>
Reviewed by Tony Chang.
[Chromium] Select popup box does not align with select button when appearance is not "menulist".
https://bugs.webkit.org/show_bug.cgi?id=53942
Added manual test select_webkit_appearance_off_popup_alignment.html.
- manual-tests/select_webkit_appearance_off_popup_alignment.html: Added.
- platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupListBox::layout):
- 22:59 Changeset [77906] by
-
2011-02-07 Aparna Nandyal <aparna.nand@wipro.com>
Reviewed by Andreas Kling.
[Qt] - Context menu needs "Copy" as well when the selected text is a link.
https://bugs.webkit.org/show_bug.cgi?id=40983
Added copy option for Qt platform if selection is a link.
Added a test in tst_qwebpage.cpp.
- page/ContextMenuController.cpp: (WebCore::ContextMenuController::populate):
2011-02-07 Aparna Nandyal <aparna.nand@wipro.com>
Reviewed by Andreas Kling.
[Qt] - Context menu needs "Copy" as well when the selected text is a link.
https://bugs.webkit.org/show_bug.cgi?id=40983
Added a test case to create a context sensitive menu.
A check is made if it has Copy menu item when user
selects a link and opens context menu.
- tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::contextMenuCopy):
- 22:48 Changeset [77905] by
-
2011-02-07 Mike Reed <reed@google.com>
Reviewed by Kenneth Russell.
Add compile-time flag ENABLE(SKIA_GPU) to use Skia's gpu backend
when drawing <canvas>. Disabled by default.
No new tests. existing canvas layouttests apply
- platform/graphics/chromium/DrawingBufferChromium.cpp: (WebCore::DrawingBuffer::publishToPlatformLayer):
- platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::GetGlobalGrContext): (WebCore::PlatformContextSkia::isPrinting): (WebCore::PlatformContextSkia::setSharedGraphicsContext3D): (WebCore::PlatformContextSkia::syncSoftwareCanvas):
- 22:45 Changeset [77904] by
-
2011-02-07 Jay Civelli <jcivelli@chromium.org>
Reviewed by Darin Fisher.
Removing unused code from PopupMenuChromium.
https://bugs.webkit.org/show_bug.cgi?id=53866
- platform/chromium/PopupMenuChromium.cpp:
(WebCore::PopupListBox::layout):
(WebCore::PopupMenuChromium::show):
- platform/chromium/PopupMenuChromium.h:
- platform/chromium/PopupMenuChromium.cpp:
(WebCore::PopupListBox::layout):
(WebCore::PopupMenuChromium::show):
- 22:39 Changeset [77903] by
-
2011-02-07 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Barth.
bring back diff context lines into the review tool
https://bugs.webkit.org/show_bug.cgi?id=53974
- code-review.js:
- 22:30 Changeset [77902] by
-
2011-02-07 Kenichi Ishibashi <bashi@google.com>
Reviewed by Andreas Kling.
HTMLOutputElement::childrenChanged() should call its base class childrenChanged()
https://bugs.webkit.org/show_bug.cgi?id=53791
Test that a live list is updated after the child of an HTMLOutputElement was removed.
- fast/dom/HTMLOutputElement/htmloutputelement-children-removed-expected.txt: Added.
- fast/dom/HTMLOutputElement/htmloutputelement-children-removed.html: Added.
2011-02-07 Kenichi Ishibashi <bashi@chromium.org>
Reviewed by Andreas Kling.
HTMLOutputElement::childrenChanged() should call its base class childrenChanged()
https://bugs.webkit.org/show_bug.cgi?id=53791
Calls HTMLFormControlElement::childrenChanged() in HTMLOutputElement::childrenChanged().
Test: fast/dom/HTMLOutputElement/htmloutputelement-children-removed.html
- html/HTMLOutputElement.cpp: (WebCore::HTMLOutputElement::childrenChanged): Calls super class's childrenChanged().
- 22:27 Changeset [77901] by
-
2011-02-07 Benjamin Poulain <ikipou@gmail.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] cookiesEnabled could create the cookieJar on the wrong thread.
https://bugs.webkit.org/show_bug.cgi?id=52289
Use the QtNAMThreadSafeProxy to make sure the cookie jar is created
in the same thread as the QNetworkAccessManager.
- platform/network/qt/QtNAMThreadSafeProxy.cpp: (WebCore::QtNAMThreadSafeProxy::QtNAMThreadSafeProxy): (WebCore::QtNAMThreadSafeProxy::hasCookieJar):
- platform/network/qt/QtNAMThreadSafeProxy.h:
- platform/qt/CookieJarQt.cpp: (WebCore::cookiesEnabled):
2011-02-07 Benjamin Poulain <ikipou@gmail.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] cookiesEnabled could create the cookieJar on the wrong thread.
https://bugs.webkit.org/show_bug.cgi?id=52289
Test if the cookie jar is created in the right thread when accessed from
the navigator object.
- tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::navigatorCookieEnabledForNetworkAccessManagerOnDifferentThread):
- 22:25 Changeset [77900] by
-
2011-02-07 Alexey Marinichev <amarinichev@chromium.org>
Reviewed by Kenneth Russell.
Hook up WebGraphicsContext3D::setContextLostCallback.
https://bugs.webkit.org/show_bug.cgi?id=53722
Test: fast/canvas/webgl/context-lost.html, comment out the line with
extension.loseContext() and kill the GPU process "Lose context"
message shows up.
- html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContextLostCallback::WebGLRenderingContextLostCallback): (WebCore::WebGLRenderingContextLostCallback::onContextLost): (WebCore::WebGLRenderingContextLostCallback::~WebGLRenderingContextLostCallback): (WebCore::WebGLRenderingContext::initializeNewContext): (WebCore::WebGLRenderingContext::~WebGLRenderingContext):
- platform/graphics/GraphicsContext3D.h: (WebCore::GraphicsContext3D::ContextLostCallback::~ContextLostCallback):
- platform/graphics/mac/GraphicsContext3DMac.mm: (WebCore::GraphicsContext3D::setContextLostCallback): stub
- platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3D::setContextLostCallback): stub
2011-02-07 Alexey Marinichev <amarinichev@chromium.org>
Reviewed by Kenneth Russell.
Hook up WebGraphicsContext3D::setContextLostCallback.
https://bugs.webkit.org/show_bug.cgi?id=53722
Test: fast/canvas/webgl/context-lost.html, comment out the line with
extension.loseContext() and kill the GPU process "Lose context"
message shows up.
- public/WebGraphicsContext3D.h: (WebKit::WebGraphicsContext3D::WebGraphicsContextLostCallback::~WebGraphicsContextLostCallback):
- src/GraphicsContext3DChromium.cpp: (WebCore::GraphicsContextLostCallbackAdapter::~GraphicsContextLostCallbackAdapter): (WebCore::GraphicsContextLostCallbackAdapter::GraphicsContextLostCallbackAdapter): (WebCore::GraphicsContextLostCallbackAdapter::onContextLost): (WebCore::GraphicsContextLostCallbackAdapter::create): (WebCore::GraphicsContext3DInternal::setContextLostCallback):
- src/GraphicsContext3DInternal.h:
- 22:24 Changeset [77899] by
-
Fix the 32-bit build.
- UIProcess/cf/WebBackForwardListCF.cpp:
(WebKit::WebBackForwardList::restoreFromCFDictionaryRepresentation): Add some casts
to prevent warnings about mixing signed and unsigned comparisons.
- 22:11 Changeset [77898] by
-
2011-02-07 Adam Barth <abarth@webkit.org>
Add Leopard Debug back to the core builders.
- Scripts/webkitpy/common/net/buildbot/buildbot.py:
- Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
- 22:08 Changeset [77897] by
-
2011-02-07 Ami Fischman <fischman@google.com>
Reviewed by Eric Seidel.
Re-baseline media/video-zoom.html for http://crbug.com/70252 aka
https://bugs.webkit.org/show_bug.cgi?id=53737 to account for (very)
slightly different scrollbar shading.
This test isn't flaky on LINUX or MAC according to
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&showAllRuns=true&master=ChromiumWebkit&tests=media%2Fvideo-zoom.html
so take it out of test_expectations.txt; it passes 100% on LINUX and
fails 100% on MAC, and should pass 100% on MAC with this new
baseline.
- platform/chromium-mac/media/video-zoom-expected.checksum:
- platform/chromium-mac/media/video-zoom-expected.png:
- platform/chromium/test_expectations.txt:
- 22:05 Changeset [77896] by
-
2011-02-07 Adam Klein <adamk@chromium.org>
Reviewed by Jian Li.
[chromium] Remove deprecated method WebNotification::dir
https://bugs.webkit.org/show_bug.cgi?id=53735
- public/WebNotification.h:
- src/WebNotification.cpp:
2011-02-07 Adam Klein <adamk@chromium.org>
Reviewed by Jian Li.
[chromium] Remove deprecated method WebNotification::dir
https://bugs.webkit.org/show_bug.cgi?id=53735
- DumpRenderTree/chromium/NotificationPresenter.cpp: (NotificationPresenter::show):
- 22:02 Changeset [77895] by
-
2011-02-07 Patrick Gansterer <paroga@webkit.org>
Reviewed by Eric Seidel.
Add missing PaintInfo include in RenderThemeWin.cpp
https://bugs.webkit.org/show_bug.cgi?id=53885
- rendering/RenderThemeWin.cpp:
- 21:39 Changeset [77894] by
-
2011-02-07 James Robinson <jamesr@chromium.org>
Move sputnik expectations to match test movement.
- platform/gtk/fast/js/sputnik: Removed.
- platform/gtk/fast/js/sputnik/Unicode: Removed.
- platform/gtk/fast/js/sputnik/Unicode/Unicode_510: Removed.
- platform/gtk/fast/js/sputnik/Unicode/Unicode_510/S7.6_A3.2-expected.txt: Removed.
- platform/gtk/fast/js/sputnik/Unicode/Unicode_510/S7.6_A5.3_T1-expected.txt: Removed.
- platform/gtk/fast/js/sputnik/Unicode/Unicode_510/S7.6_A5.3_T2-expected.txt: Removed.
- platform/gtk/sputnik: Copied from LayoutTests/platform/gtk/fast/js/sputnik.
- platform/mac-leopard/fast/js/sputnik: Removed.
- platform/mac-leopard/fast/js/sputnik/Unicode: Removed.
- platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_500: Removed.
- platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_500/S7.6_A3.1-expected.txt: Removed.
- platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_500/S7.6_A3.2-expected.txt: Removed.
- platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_500/S7.6_A5.3_T1-expected.txt: Removed.
- platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_500/S7.6_A5.3_T2-expected.txt: Removed.
- platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510: Removed.
- platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S15.5.4.16_A1-expected.txt: Removed.
- platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S15.5.4.18_A1-expected.txt: Removed.
- platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A1.1_T1-expected.txt: Removed.
- platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A1.1_T2-expected.txt: Removed.
- platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A1.1_T4-expected.txt: Removed.
- platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A2.2_T1-expected.txt: Removed.
- platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A2.2_T2-expected.txt: Removed.
- platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A2.3-expected.txt: Removed.
- platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A5.2_T1-expected.txt: Removed.
- platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A5.2_T2-expected.txt: Removed.
- platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A5.2_T4-expected.txt: Removed.
- platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A5.2_T7-expected.txt: Removed.
- platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A5.2_T8-expected.txt: Removed.
- platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A5.2_T9-expected.txt: Removed.
- platform/mac-leopard/sputnik: Copied from LayoutTests/platform/mac-leopard/fast/js/sputnik.
- platform/win/fast/js/sputnik: Removed.
- platform/win/fast/js/sputnik/Conformance: Removed.
- platform/win/fast/js/sputnik/Conformance/11_Expressions: Removed.
- platform/win/fast/js/sputnik/Conformance/11_Expressions/11.5_Multiplicative_Operators: Removed.
- platform/win/fast/js/sputnik/Conformance/11_Expressions/11.5_Multiplicative_Operators/11.5.3_Percent: Removed.
- platform/win/fast/js/sputnik/Conformance/11_Expressions/11.5_Multiplicative_Operators/11.5.3_Percent/S11.5.3_A4_T6-expected.txt: Removed.
- platform/win/fast/js/sputnik/Unicode: Removed.
- platform/win/fast/js/sputnik/Unicode/Unicode_510: Removed.
- platform/win/fast/js/sputnik/Unicode/Unicode_510/S7.6_A3.1-expected.txt: Removed.
- platform/win/fast/js/sputnik/Unicode/Unicode_510/S7.6_A3.2-expected.txt: Removed.
- platform/win/fast/js/sputnik/Unicode/Unicode_510/S7.6_A5.3_T1-expected.txt: Removed.
- platform/win/fast/js/sputnik/Unicode/Unicode_510/S7.6_A5.3_T2-expected.txt: Removed.
- platform/win/sputnik: Copied from LayoutTests/platform/win/fast/js/sputnik.
- 21:37 Changeset [77893] by
-
2011-02-07 Ami Fischman <fischman@google.com>
Reviewed by Eric Carlson.
Removed two of the three almost-duplicate test expectations
between {media,platform/chromium-{mac,win}} by excluding file
extensions from the emitted output.
Removed outdated test_expectation for deleted test.
http://crbug.com/28993
- media/controls-right-click-on-timebar-expected.txt:
- media/controls-right-click-on-timebar.html:
- media/media-file.js: (stripExtension):
- media/media-startTime-expected.txt:
- media/media-startTime.html:
- media/video-append-source-expected.txt:
- media/video-append-source.html:
- media/video-canvas-source-expected.txt:
- media/video-canvas-source.html:
- media/video-dom-src-expected.txt:
- media/video-dom-src.html:
- media/video-load-networkState-expected.txt:
- media/video-load-networkState.html:
- media/video-played-reset-expected.txt:
- media/video-played-reset.html:
- media/video-seek-past-end-paused-expected.txt:
- media/video-seek-past-end-paused.html:
- media/video-seek-past-end-playing-expected.txt:
- media/video-seek-past-end-playing.html:
- media/video-source-expected.txt:
- media/video-source-type-expected.txt:
- media/video-source-type-params-expected.txt:
- media/video-source-type-params.html:
- media/video-source-type.html:
- media/video-source.html:
- media/video-src-change-expected.txt:
- media/video-src-change.html:
- media/video-src-expected.txt:
- media/video-src-remove-expected.txt:
- media/video-src-remove.html:
- media/video-src-set-expected.txt:
- media/video-src-set.html:
- media/video-src-source-expected.txt:
- media/video-src-source.html:
- media/video-src.html:
- media/video-test.js: (enableFullTestDetailsPrinting): (test): (testExpected): (waitForEvent._eventCallback): (waitForEvent): (waitForEventAndTest._eventCallback): (waitForEventAndTest): (testException): (endTest):
- platform/chromium-mac/media/controls-right-click-on-timebar-expected.txt: Removed.
- platform/chromium-mac/media/media-startTime-expected.txt: Removed.
- platform/chromium-mac/media/video-append-source-expected.txt: Removed.
- platform/chromium-mac/media/video-canvas-source-expected.txt: Removed.
- platform/chromium-mac/media/video-dom-src-expected.txt: Removed.
- platform/chromium-mac/media/video-load-networkState-expected.txt: Removed.
- platform/chromium-mac/media/video-played-reset-expected.txt: Removed.
- platform/chromium-mac/media/video-seek-past-end-paused-expected.txt: Removed.
- platform/chromium-mac/media/video-seek-past-end-playing-expected.txt: Removed.
- platform/chromium-mac/media/video-source-add-src-expected.txt: Removed.
- platform/chromium-mac/media/video-source-error-expected.txt: Removed.
- platform/chromium-mac/media/video-source-expected.txt: Removed.
- platform/chromium-mac/media/video-source-type-expected.txt: Removed.
- platform/chromium-mac/media/video-source-type-params-expected.txt: Removed.
- platform/chromium-mac/media/video-src-change-expected.txt: Removed.
- platform/chromium-mac/media/video-src-expected.txt: Removed.
- platform/chromium-mac/media/video-src-remove-expected.txt: Removed.
- platform/chromium-mac/media/video-src-set-expected.txt: Removed.
- platform/chromium-mac/media/video-src-source-expected.txt: Removed.
- platform/chromium-win/media/controls-right-click-on-timebar-expected.txt: Removed.
- platform/chromium-win/media/media-startTime-expected.txt: Removed.
- platform/chromium-win/media/video-append-source-expected.txt: Removed.
- platform/chromium-win/media/video-canvas-source-expected.txt: Removed.
- platform/chromium-win/media/video-dom-src-expected.txt: Removed.
- platform/chromium-win/media/video-load-networkState-expected.txt: Removed.
- platform/chromium-win/media/video-played-reset-expected.txt: Removed.
- platform/chromium-win/media/video-seek-past-end-paused-expected.txt: Removed.
- platform/chromium-win/media/video-seek-past-end-playing-expected.txt: Removed.
- platform/chromium-win/media/video-source-add-src-expected.txt: Removed.
- platform/chromium-win/media/video-source-error-expected.txt: Removed.
- platform/chromium-win/media/video-source-expected.txt: Removed.
- platform/chromium-win/media/video-source-type-expected.txt: Removed.
- platform/chromium-win/media/video-source-type-params-expected.txt: Removed.
- platform/chromium-win/media/video-src-change-expected.txt: Removed.
- platform/chromium-win/media/video-src-expected.txt: Removed.
- platform/chromium-win/media/video-src-remove-expected.txt: Removed.
- platform/chromium-win/media/video-src-set-expected.txt: Removed.
- platform/chromium-win/media/video-src-source-expected.txt: Removed.
- platform/chromium/test_expectations.txt:
- 21:37 Changeset [77892] by
-
2011-02-07 Qi Zhang <qi.2.zhang@nokia.com>
Reviewed by Andreas Kling.
[Qt] enum QWebPage::WebAction doesn't have value QWebPage::CopyImageUrl
https://bugs.webkit.org/show_bug.cgi?id=52974
Add ContextMenuItemTagCopyImageUrlToClipboard into standard action but Qt platform specific.
- page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected): (WebCore::ContextMenuController::populate): (WebCore::ContextMenuController::checkOrEnableIfNeeded):
- platform/ContextMenuItem.h:
- platform/LocalizationStrategy.h:
- platform/LocalizedStrings.cpp: (WebCore::contextMenuItemTagCopyImageUrlToClipboard):
- platform/LocalizedStrings.h:
2011-02-07 Qi Zhang <qi.2.zhang@nokia.com>
Reviewed by Andreas Kling.
[Qt] enum QWebPage::WebAction doesn't have value QWebPage::CopyImageUrl
https://bugs.webkit.org/show_bug.cgi?id=52974
Add QWebPage::CopyImageUrlToClipboard into QWebPage::WebAction.
- Api/qwebpage.cpp: (webActionForContextMenuAction): (QWebPage::triggerAction): (QWebPage::action):
- Api/qwebpage.h:
- WebCoreSupport/WebPlatformStrategies.cpp: (WebPlatformStrategies::contextMenuItemTagCopyImageUrlToClipboard):
- WebCoreSupport/WebPlatformStrategies.h:
2011-02-07 Qi Zhang <qi.2.zhang@nokia.com>
Reviewed by Andreas Kling.
[Qt] enum QWebPage::WebAction doesn't have value QWebPage::CopyImageUrl
https://bugs.webkit.org/show_bug.cgi?id=52974
Add ContextMenuItemTagCopyImageUrlToClipboard into standard action but Qt platform specific.
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp: (WebKit::WebPlatformStrategies::contextMenuItemTagCopyImageUrlToClipboard):
- WebProcess/WebCoreSupport/WebPlatformStrategies.h:
- 21:28 Changeset [77891] by
-
2011-02-07 Kenichi Ishibashi <bashi@chromium.org>
Reviewed by Kent Tamura.
HTMLFormElement::formElementIndex() returns a bad index into a vector of form associated elements
https://bugs.webkit.org/show_bug.cgi?id=53970
Adds HTMLObjectElement::virtualForm() to make HTMLObjectElement::form()
return the right value.
Test: fast/dom/HTMLObjectElement/form/nested-form-element.html
- html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::virtualForm): Added.
- html/HTMLObjectElement.h: Added virtualForm().
2011-02-07 Kenichi Ishibashi <bashi@chromium.org>
Reviewed by Kent Tamura.
HTMLFormElement::formElementIndex() returns a bad index into a vector of form associated elements
https://bugs.webkit.org/show_bug.cgi?id=53970
Adds a test that ensures WebKit parses successfully a page that
contains object elements which are in nested and defective form
elements.
- fast/dom/HTMLObjectElement/form/nested-form-element-expected.txt: Added.
- fast/dom/HTMLObjectElement/form/nested-form-element.html: Added.
- 20:39 Changeset [77890] by
-
2011-02-07 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Remove Leopard Debug as a core builder
https://bugs.webkit.org/show_bug.cgi?id=53971
The Leopard Debug builder has been failing to compile for several days.
My understanding is that folks are working on fixing the build, but for
the time being we should probably remove it from the list of core
builders so that the core waterfall can be green. We can certainly add
it back once the build is fixed.
Also, I've removed the Tiger builders because those no longer appear to
be attached to the buildbot master.
- Scripts/webkitpy/common/net/buildbot/buildbot.py:
- Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
- 20:29 Changeset [77889] by
-
2011-02-01 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Roben.
include svn revisions in git diffs for the code review tool to use
https://bugs.webkit.org/show_bug.cgi?id=53569
- Scripts/webkitpy/common/checkout/scm.py:
- Scripts/webkitpy/common/checkout/scm_unittest.py:
2011-02-01 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Roben.
include svn revisions in git diffs for the code review tool to use
https://bugs.webkit.org/show_bug.cgi?id=53569
- PrettyPatch/PrettyPatch.rb:
- 20:27 Changeset [77888] by
-
2011-02-07 Ryosuke Niwa <rniwa@webkit.org>
Unreviewed Leopard build fix.
- WebCore.xcodeproj/project.pbxproj: let XCode have developmentRegion.
- platform/mac/DragImageMac.mm: (WebCore::webkit_CGCeiling): Cast the return value of ceil to CGFloat.
- 20:21 Changeset [77887] by
-
2011-02-07 Yuzo Fujishima <yuzo@google.com>
Unreviewed attempt to fix a flaky test.
https://bugs.webkit.org/show_bug.cgi?id=51757
- fast/css/font-face-download-error.html:
- 20:07 Changeset [77886] by
-
2011-02-07 Zhenyao Mo <zmo@google.com>
Unreviewed, test expectations update.
- platform/chromium/test_expectations.txt:
- 19:55 Changeset [77885] by
-
2011-02-07 James Robinson <jamesr@chromium.org>
Reviewed by Dan Bernstein.
Move the sputnik test suite out of fast/js/
https://bugs.webkit.org/show_bug.cgi?id=53954
The sputnik suite shouldn't go in fast/js/ because it is not fast and
it is an imported test suite. This moves it to LayoutTests/sputnik
and updates references in skipped lists / expectations.
- platform/chromium/test_expectations.txt:
- platform/gtk/Skipped:
- platform/mac-tiger/Skipped:
- platform/mac-wk2/Skipped:
- platform/qt-wk2/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- 19:37 Changeset [77884] by
-
Fixing the change log entry.
- 19:34 Changeset [77883] by
-
2011-02-07 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Removed some dead code from Heap
https://bugs.webkit.org/show_bug.cgi?id=53969
SunSpider reports no change.
- runtime/MarkedSpace.cpp: (JSC::MarkedSpace::shrink): (JSC::MarkedSpace::sweep):
- runtime/MarkedSpace.h: Removed resizeBlocks and growBlocks, and renamed shrinkBlocks to shrink, making it unconditionally shrink as much as possible.
- 19:13 Changeset [77882] by
-
Source/WebCore: Fixing a build break on Mac caused by http://trac.webkit.org/changeset/77874
Reviewed by Sam Weinig.
When moving code from WebKit to WebCore we needed to move some additional
functions previously in NSStringExtras.
- WebCore.xcodeproj/project.pbxproj:
- platform/mac/DragImageMac.mm:
(WebCore::fontFromNSFont):
(WebCore::canUseFastRenderer):
(WebCore::widthWithFont):
(WebCore::webkit_CGCeiling):
(WebCore::drawAtPoint):
(WebCore::drawDoubledAtPoint):
(WebCore::createDragImageForLink):
Source/WebKit2: Fixing a build break on Mac caused by http://trac.webkit.org/changeset/77874
Reviewed by Sam Weinig.
Removed unused static function.
- WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:
- 19:08 Changeset [77881] by
-
2011-02-07 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Removed some dead code from Heap
https://bugs.webkit.org/show_bug.cgi?id=53969
SunSpider reports no change.
- runtime/MarkedSpace.cpp: (JSC::MarkedSpace::shrink): (JSC::MarkedSpace::sweep):
- runtime/MarkedSpace.h: Removed resizeBlocks and growBlocks, and renamed shrinkBlocks to shrink, making it unconditionally shrink as much as possible.
- 18:21 Changeset [77880] by
-
<rdar://problem/8969888>
The WebProcess should set LSFileQuarantineEnabled to true
Reviewed by Sam Weinig.
- WebProcess/Info.plist:
- 18:13 Changeset [77879] by
-
2011-02-07 Zhenyao Mo <zmo@google.com>
Unreviewed, test expectations update.
- platform/chromium/test_expectations.txt:
- 18:04 Changeset [77878] by
-
2011-02-07 Lucas Forschler <lforschler@apple.com>
Reviewed by Geoff Garen.
Tr #2, Fix the Leopard 32bit debug build.
No new tests required.
- WebCore.xcodeproj/project.pbxproj:
- accessibility/AccessibilityAllInOne.cpp:
- 17:58 Changeset [77877] by
-
2011-02-07 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Simplified the marked space's mark invariant
https://bugs.webkit.org/show_bug.cgi?id=53968
SunSpider reports no change.
- runtime/MarkedSpace.cpp: (JSC::MarkedSpace::allocate): Mark objects when allocating them. This means that, at all times other than the mark phase, an object is live if and only if it is marked.
(JSC::MarkedSpace::containsSlowCase): Use the new mark invariant to
simplify testing whether an object is live.
- 17:53 Changeset [77876] by
-
Fix for <rdar://problem/8946961> Fix repaint problems
with WKScrollbarPainter scrollers while resizing the window
Reviewed by Sam Weinig.
Remove setPainterForPainterController() and
removePainterFromPainterController() since they aren't
used anymore.
- platform/mac/ScrollAnimatorMac.h:
Return early if they alpha hasn't changed.
- platform/mac/ScrollAnimatorMac.mm:
(-[ScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:]):
(-[ScrollbarPainterDelegate scrollerImp:animateTrackAlphaTo:duration:]):
If we're in a live resize, restore alpha to 1.
(WebCore::ScrollAnimatorMac::didAddVerticalScrollbar):
(WebCore::ScrollAnimatorMac::didAddHorizontalScrollbar):
- 17:47 Changeset [77875] by
-
2011-02-03 MORITA Hajime <morrita@google.com>
Reviewed by Darin Fisher.
[Chromium] Should implement EditorClientImpl::requestCheckingOfString()
https://bugs.webkit.org/show_bug.cgi?id=51013
Unskipped passed test.
- platform/chromium/test_expectations.txt:
2011-02-03 MORITA Hajime <morrita@google.com>
Reviewed by Darin Fisher.
[Chromium] Should implement EditorClientImpl::requestCheckingOfString()
https://bugs.webkit.org/show_bug.cgi?id=51013
- Added WebTextCheckingCompletion to receive the checked result asynchronously.
- Added WebViewClient::requestCheckingOfText() and related classes.
- Implemented EditorClientImpl::requestCheckingOfString().
- WebKit.gyp:
- public/WebSettings.h:
- public/WebTextCheckingCompletion.h: Added. (WebKit::WebTextCheckingCompletion::~WebTextCheckingCompletion):
- public/WebTextCheckingResult.h: Added. (WebKit::WebTextCheckingResult::error): (WebKit::WebTextCheckingResult::position): (WebKit::WebTextCheckingResult::length): (WebKit::WebTextCheckingResult::WebTextCheckingResult):
- public/WebViewClient.h: (WebKit::WebViewClient::requestCheckingOfText): Gave an implementation
- src/AssertMatchingEnums.cpp:
- src/EditorClientImpl.cpp: (WebKit::EditorClientImpl::requestCheckingOfString):
- src/EditorClientImpl.h:
- src/WebSettingsImpl.cpp: (WebKit::WebSettingsImpl::setAsynchronousSpellCheckingEnabled):
- src/WebSettingsImpl.h:
- src/WebTextCheckingCompletionImpl.cpp: Added. (WebKit::toCoreResults): (WebKit::WebTextCheckingCompletionImpl::didFinishCheckingText):
- src/WebTextCheckingCompletionImpl.h: Added. (WebKit::WebTextCheckingCompletionImpl::WebTextCheckingCompletionImpl):
2011-02-03 MORITA Hajime <morrita@google.com>
Reviewed by Darin Fisher.
[Chromium] Should implement EditorClientImpl::requestCheckingOfString()
https://bugs.webkit.org/show_bug.cgi?id=51013
Gave DRT implementation for requestTextCheck().
- DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::setAsynchronousSpellCheckingEnabled): Implemented.
- DumpRenderTree/chromium/WebViewHost.cpp: (invokeFinishLastTextCheck): Added. (WebViewHost::requestTextCheck): Added. (WebViewHost::finishLastTextCheck): Added.
- DumpRenderTree/chromium/WebViewHost.h:
- 17:44 Changeset [77874] by
-
2011-02-07 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Crash in web process after the connection had been closed
https://bugs.webkit.org/show_bug.cgi?id=51115
<rdar://problem/8964255>
Remove didCloseOnConnectionWorkQueue from Connection::Client and add
Connection::setDidCloseOnConnectionWorkQueueCallback which takes a static
function, eliminating the race condition in connectionDidClose where m_client could be
nulled out in the client thread right before we try to dereference it.
- Platform/CoreIPC/Connection.cpp: (CoreIPC::Connection::Connection): Initialize m_didCloseOnConnectionWorkQueueCallback.
(CoreIPC::Connection::setDidCloseOnConnectionWorkQueueCallback):
Update m_didCloseOnConnectionWorkQueueCallback.
(CoreIPC::Connection::connectionDidClose):
Call m_didCloseOnConnectionWorkQueueCallback.
- Platform/WorkQueue.h: Make WorkQueue noncopyable.
- PluginProcess/PluginProcess.cpp: (WebKit::PluginProcess::initializeConnection): Call setDidCloseOnConnectionWorkQueueCallback.
- Shared/ChildProcess.cpp: (WebKit::ChildProcess::didCloseOnConnectionWorkQueue):
- Shared/ChildProcess.h: didCloseOnConnectionWorkQueue is now a static member function.
- WebProcess/WebProcess.cpp: (WebKit::WebProcess::initialize): Call setDidCloseOnConnectionWorkQueueCallback.
- 17:39 Changeset [77873] by
-
2011-02-07 Martin Robinson <mrobinson@igalia.com>
Classify tests failing in the fast directory on GTK+. Add results for
tests that just need platform expectations.
- platform/gtk/Skipped: Update the skipped list.
- platform/gtk/fast/backgrounds/background-clip-text-expected.checksum: Added.
- platform/gtk/fast/backgrounds/background-clip-text-expected.png: Added.
- platform/gtk/fast/backgrounds/background-clip-text-expected.txt: Added.
- platform/gtk/fast/canvas/canvas-zoom-expected.txt: Added.
- platform/gtk/fast/css/css1_forward_compatible_parsing-expected.checksum: Added.
- platform/gtk/fast/css/css1_forward_compatible_parsing-expected.png: Added.
- platform/gtk/fast/css/css1_forward_compatible_parsing-expected.txt: Added.
- platform/gtk/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Added.
- platform/gtk/fast/css/invalid-percentage-property-expected.checksum: Added.
- platform/gtk/fast/css/invalid-percentage-property-expected.png: Added.
- platform/gtk/fast/css/invalid-percentage-property-expected.txt: Added.
- platform/gtk/fast/css/text-align-expected.checksum: Added.
- platform/gtk/fast/css/text-align-expected.png: Added.
- platform/gtk/fast/css/text-align-expected.txt: Added.
- platform/gtk/fast/dom/Element/getBoundingClientRect-expected.txt: Added.
- platform/gtk/fast/dom/Range/getBoundingClientRect-expected.txt: Added.
- platform/gtk/fast/dom/Range/getClientRects-expected.txt: Added.
- platform/gtk/fast/dom/Window/webkitConvertPoint-expected.txt: Added.
- platform/gtk/fast/dom/null-document-location-put-crash-expected.txt: Added.
- platform/gtk/fast/dom/tabindex-clamp-expected.txt: Added.
- platform/gtk/fast/events/js-keyboard-event-creation-expected.txt: Added.
- platform/gtk/fast/events/offsetX-offsetY-expected.txt: Added.
- platform/gtk/fast/events/pointer-events-2-expected.checksum: Added.
- platform/gtk/fast/events/pointer-events-2-expected.png: Added.
- platform/gtk/fast/events/pointer-events-2-expected.txt: Added.
- platform/gtk/fast/fast-mobile-scrolling/fixed-position-element-expected.checksum: Added.
- platform/gtk/fast/fast-mobile-scrolling/fixed-position-element-expected.png: Added.
- platform/gtk/fast/fast-mobile-scrolling/fixed-position-element-expected.txt: Added.
- platform/gtk/fast/fast-mobile-scrolling/no-fixed-position-elements-expected.checksum: Added.
- platform/gtk/fast/fast-mobile-scrolling/no-fixed-position-elements-expected.png: Added.
- platform/gtk/fast/fast-mobile-scrolling/no-fixed-position-elements-expected.txt: Added.
- platform/gtk/fast/forms/listbox-hit-test-zoomed-expected.checksum: Added.
- platform/gtk/fast/forms/listbox-hit-test-zoomed-expected.png: Added.
- platform/gtk/fast/forms/listbox-hit-test-zoomed-expected.txt: Added.
- platform/gtk/fast/html/tab-order-expected.txt: Added.
- platform/gtk/fast/replaced/table-percent-height-expected.txt: Added.
- platform/gtk/fast/selectors/lang-inheritance-expected.checksum: Added.
- platform/gtk/fast/selectors/lang-inheritance-expected.png: Added.
- platform/gtk/fast/selectors/lang-inheritance-expected.txt: Added.
- platform/gtk/fast/selectors/lang-inheritance2-expected.checksum: Added.
- platform/gtk/fast/selectors/lang-inheritance2-expected.png: Added.
- platform/gtk/fast/selectors/lang-inheritance2-expected.txt: Added.
- platform/gtk/fast/selectors/lang-vs-xml-lang-expected.checksum: Added.
- platform/gtk/fast/selectors/lang-vs-xml-lang-expected.png: Added.
- platform/gtk/fast/selectors/lang-vs-xml-lang-expected.txt: Added.
- platform/gtk/fast/selectors/lang-vs-xml-lang-xhtml-expected.checksum: Added.
- platform/gtk/fast/selectors/lang-vs-xml-lang-xhtml-expected.png: Added.
- platform/gtk/fast/selectors/lang-vs-xml-lang-xhtml-expected.txt: Added.
- platform/gtk/fast/text/international/danda-space-expected.checksum: Added.
- platform/gtk/fast/text/international/danda-space-expected.png: Added.
- platform/gtk/fast/text/international/danda-space-expected.txt: Added.
- platform/gtk/fast/text/international/thai-baht-space-expected.checksum: Added.
- platform/gtk/fast/text/international/thai-baht-space-expected.png: Added.
- platform/gtk/fast/text/international/thai-baht-space-expected.txt: Added.
- 17:38 Changeset [77872] by
-
2011-02-07 Zhenyao Mo <zmo@google.com>
Unreviewed, test expectations update.
- platform/chromium/test_expectations.txt:
- 17:35 Changeset [77871] by
-
Fix for https://bugs.webkit.org/show_bug.cgi?id=53950
USE_WK_SCROLLBAR_PAINTER in ScrollbarThemeMac should be in
Platform.h instead
Reviewed by Eric Seidel.
- wtf/Platform.h:
../WebCore:
Use hot new USE(WK_SCROLLBAR_PAINTER) from Platform.h rather
than the silly, old in-file #define.
- platform/mac/ScrollbarThemeMac.mm:
(+[ScrollbarPrefsObserver appearancePrefsChanged:]):
(WebCore::updateArrowPlacement):
(WebCore::ScrollbarThemeMac::registerScrollbar):
(WebCore::ScrollbarThemeMac::scrollbarThickness):
(WebCore::ScrollbarThemeMac::usesOverlayScrollbars):
(WebCore::ScrollbarThemeMac::hasThumb):
(WebCore::ScrollbarThemeMac::minimumThumbLength):
(WebCore::ScrollbarThemeMac::paint):
- 17:34 Changeset [77870] by
-
Reviewed Adam Roben and Darin Adler.
Source/WebCore:
WebKit2: drag and drop support on Windows.
https://bugs.webkit.org/show_bug.cgi?id=52775
<rdar://problem/8514409>
- loader/EmptyClients.h: Removed createDragImageFromLink.
- page/DragClient.h: Ditto.
- page/DragController.cpp:
(WebCore::DragController::startDrag): changed call to createDragImageFromLink.
- platform/DragImage.h:
- platform/mac/DragImageMac.mm:
(WebCore::createDragImageForLink): Moved from DragClient.
- platform/win/ClipboardUtilitiesWin.cpp: Added a series of functions
to de-serialize the drag data from the map into an IDataObject.
(WebCore::getWebLocData):
(WebCore::texthtmlFormat):
(WebCore::createGlobalData):
(WebCore::getFullCFHTML):
(WebCore::urlWFormat):
(WebCore::urlFormat):
(WebCore::filenameWFormat):
(WebCore::filenameFormat):
(WebCore::htmlFormat):
(WebCore::smartPasteFormat):
(WebCore::getURL):
(WebCore::getPlainText):
(WebCore::getTextHTML):
(WebCore::ClipboardDataItem::ClipboardDataItem):
(WebCore::getStringData):
(WebCore::getUtf8Data):
(WebCore::getCFData):
(WebCore::setUCharData):
(WebCore::setCharData):
(WebCore::setCFData):
(WebCore::getClipboardMap):
(WebCore::getClipboardData):
(WebCore::setClipboardData):
- platform/win/ClipboardUtilitiesWin.h:
- platform/win/DragImageWin.cpp: Moved createDragImageForLink from DragClient
to a platform specific file in WebCore. It makes a lot more sense here, since
the drag image is always created in WebCore for all the other content types
except for links.
(WebCore::dragLabelFont):
(WebCore::createDragImageForLink):
- platform/win/WCDataObject.cpp: Added new way to
construct a WCDataObject from a DragDataMap.
(WebCore::WCDataObject::createInstance):
(WebCore::WCDataObject::clearData):
- platform/win/WCDataObject.h:
Source/WebKit/chromium:
WebKit2: drag and drop support on Windows.
https://bugs.webkit.org/show_bug.cgi?id=52775
Removed createDragImageForLink from DragClient.
- src/DragClientImpl.cpp:
- src/DragClientImpl.h:
Source/WebKit/efl:
WebKit2: drag and drop support on Windows.
https://bugs.webkit.org/show_bug.cgi?id=52775
Removed createDragImageForLink from DragClient.
- WebCoreSupport/DragClientEfl.cpp:
- WebCoreSupport/DragClientEfl.h:
Source/WebKit/gtk:
WebKit2: drag and drop support on Windows.
https://bugs.webkit.org/show_bug.cgi?id=52775
Removed createDragImageForLink from DragClient.
- WebCoreSupport/DragClientGtk.cpp:
- WebCoreSupport/DragClientGtk.h:
Source/WebKit/haiku:
WebKit2: drag and drop support on Windows.
https://bugs.webkit.org/show_bug.cgi?id=52775
Removed createDragImageForLink from DragClient.
- WebCoreSupport/DragClientHaiku.cpp:
- WebCoreSupport/DragClientHaiku.h:
Source/WebKit/mac:
WebKit2: drag and drop support on Windows.
https://bugs.webkit.org/show_bug.cgi?id=52775
Removed createDragImageForLink from DragClient.
- WebCoreSupport/WebDragClient.h:
- WebCoreSupport/WebDragClient.mm:
(WebDragClient::startDrag):
Source/WebKit/qt:
WebKit2: drag and drop support on Windows.
https://bugs.webkit.org/show_bug.cgi?id=52775
Removed createDragImageForLink from DragClient.
- WebCoreSupport/DragClientQt.cpp:
- WebCoreSupport/DragClientQt.h:
Source/WebKit/win:
WebKit2: drag and drop support on Windows.
https://bugs.webkit.org/show_bug.cgi?id=52775
Removed createDragImageForLink from DragClient.
- WebCoreSupport/WebDragClient.cpp:
(WebDragClient::startDrag):
- WebCoreSupport/WebDragClient.h:
Source/WebKit/wince:
WebKit2: drag and drop support on Windows.
https://bugs.webkit.org/show_bug.cgi?id=52775
Removed createDragImageForLink from DragClient.
- WebCoreSupport/DragClientWinCE.cpp:
- WebCoreSupport/DragClientWinCE.h:
Source/WebKit/wx:
WebKit2: drag and drop support on Windows.
https://bugs.webkit.org/show_bug.cgi?id=52775
Removed createDragImageForLink from DragClient.
- WebKitSupport/DragClientWx.cpp:
- WebKitSupport/DragClientWx.h:
Source/WebKit2:
WebKit2: drag and drop support on Windows.
https://bugs.webkit.org/show_bug.cgi?id=52775
<rdar://problem/8514409>
This patch contains the remaining work to support
a WebKit window as drag source on Windows.
I've added the code to generate the image for dragging a link as
well as the steps necessary to package the HBITMAP into a SharedMemory
object and send it over to the UI process where DoDragDrop is performed.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::setDragImage):
(WebKit::WebPageProxy::startDragDrop):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- WebProcess/WebCoreSupport/WebDragClient.cpp:
(WebKit::WebDragClient::startDrag): Made startDrag for
platforms other than Windows and Mac.
- WebProcess/WebCoreSupport/WebDragClient.h:
- WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:
(WebKit::WebDragClient::startDrag):
- WebProcess/WebCoreSupport/win/WebDragClientWin.cpp: Added.
(WebKit::draggingSourceOperationMaskToDragCursors):
(WebKit::WebDragClient::startDrag):
- WebProcess/WebCoreSupport/win/WebDragSource.cpp: Added.
This object implements the IDropSource interface.
(WebDragSource::createInstance):
(WebDragSource::WebDragSource):
(WebDragSource::QueryInterface):
(WebDragSource::AddRef):
(WebDragSource::Release):
(WebDragSource::QueryContinueDrag):
(WebDragSource::GiveFeedback):
- WebProcess/WebCoreSupport/win/WebDragSource.h: Added.
- win/WebKit2.vcproj:
- 17:32 Changeset [77869] by
-
2011-02-07 Zhenyao Mo <zmo@google.com>
Unreviewed, test expectations update.
- platform/chromium/test_expectations.txt:
- 17:23 Changeset [77868] by
-
2011-02-07 Joone Hur <joone.hur@collabora.co.uk>
Reviewed by Martin Robinson.
[Gtk] Implement layoutTestController.findString
https://bugs.webkit.org/show_bug.cgi?id=50237
Unskip editing/text-iterator/findString.html.
- platform/gtk/Skipped: Unskip findString test.
2011-02-07 Joone Hur <joone.hur@collabora.co.uk>
Reviewed by Martin Robinson.
[Gtk] Implement layoutTestController.findString
https://bugs.webkit.org/show_bug.cgi?id=50237
- GNUmakefile.am: Add AssertMatchingEnums.cpp.
- WebCoreSupport/AssertMatchingEnums.cpp: Add this file to assert that various WebKit API enum values continue matching WebCore defined enum values.
- WebCoreSupport/DumpRenderTreeSupportGtk.cpp: (DumpRenderTreeSupportGtk::findString):
- WebCoreSupport/DumpRenderTreeSupportGtk.h:
2011-02-07 Joone Hur <joone.hur@collabora.co.uk>
Reviewed by Martin Robinson.
[Gtk] Implement layoutTestController.findString
https://bugs.webkit.org/show_bug.cgi?id=50237
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::findString):
- 17:02 Changeset [77867] by
-
2011-02-07 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r77848.
http://trac.webkit.org/changeset/77848
https://bugs.webkit.org/show_bug.cgi?id=53963
caused 6 test failures (Requested by othermaciej on #webkit).
- rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::computeInlineDirectionPositionsForLine):
- 17:00 Changeset [77866] by
-
2011-02-07 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
UI process crashes if web process crashes while web inspector is focused
https://bugs.webkit.org/show_bug.cgi?id=53965
<rdar://problem/8961633>
Make sure to close the web inspector web page proxy before calling platformClose, since
platformClose can cause the web page proxy to try to send messages (such as SetActive)
to the web process while it's in a bad state.
- UIProcess/WebInspectorProxy.cpp: (WebKit::WebInspectorProxy::didClose):
- 16:57 Changeset [77865] by
-
2011-02-04 Kenneth Russell <kbr@google.com>
Reviewed by James Robinson.
Add shaders for GPU accelerated path rendering
https://bugs.webkit.org/show_bug.cgi?id=45520
Refactored SolidFillShader and TexShader to call new
generateVertex() and generateFragment() methods on base Shader
class, and added support for the Loop/Blinn shaders. Refactored
Loop/Blinn shader classes to derive from Shader.
Tested these changes with several of the IE9 Testdrive demos with
accelerated 2D canvas enabled, as well as a full layout test run
with --platform chromium-gpu.
- platform/graphics/gpu/LoopBlinnShader.cpp: Added. (WebCore::LoopBlinnShader::LoopBlinnShader): (WebCore::LoopBlinnShader::use):
- platform/graphics/gpu/LoopBlinnShader.h: Added.
- platform/graphics/gpu/LoopBlinnSolidFillShader.cpp: Added. (WebCore::LoopBlinnSolidFillShader::create): (WebCore::LoopBlinnSolidFillShader::LoopBlinnSolidFillShader): (WebCore::LoopBlinnSolidFillShader::use):
- platform/graphics/gpu/LoopBlinnSolidFillShader.h: Added.
- platform/graphics/gpu/Shader.cpp: (WebCore::Shader::affineTo4x4): (WebCore::Shader::loadShader): (WebCore::Shader::loadProgram): (WebCore::Shader::generateVertex): (WebCore::Shader::generateFragment):
- platform/graphics/gpu/Shader.h:
- platform/graphics/gpu/SolidFillShader.cpp: (WebCore::SolidFillShader::create):
- platform/graphics/gpu/TexShader.cpp: (WebCore::TexShader::TexShader): (WebCore::TexShader::create):
- 16:51 Changeset [77864] by
-
2011-02-07 Maciej Stachowiak <mjs@apple.com>
Reviewed by Sam Weinig.
Skip a newly added test that uses unimplemented DRT functionality
https://bugs.webkit.org/show_bug.cgi?id=53938
- platform/mac-wk2/Skipped:
- 16:30 Changeset [77863] by
-
2011-02-07 Zhenyao Mo <zmo@google.com>
Unreviewed, rebaseline.
- platform/chromium-linux/fast/html/keygen-expected.checksum:
- platform/chromium-linux/fast/html/keygen-expected.png:
- platform/chromium-linux/fast/html/keygen-expected.txt: Added.
- platform/chromium-win/fast/html/keygen-expected.txt:
- platform/chromium/test_expectations.txt:
- 16:29 Changeset [77862] by
-
2011-02-07 Anders Carlsson <andersca@apple.com>
Reviewed by Darin Adler.
Find bouncy is missing content on pages with framesets
https://bugs.webkit.org/show_bug.cgi?id=53958
<rdar://problem/8904447>
Fix paint rect computation; FrameView::paint expects the paint rect to be in the
parent widget's coordinate system.
- WebProcess/WebPage/FindController.cpp: (WebKit::FindController::updateFindIndicator):
- 16:22 Changeset [77861] by
-
<rdar://problem/8960434> and https://bugs.webkit.org/show_bug.cgi?id=53957
Crash after incorrectly restoring bogus session state.
Reviewed by Anders Carlsson.
In some cases we're writing an invalid session state for a back/forward list where the current entry is 0
but the number of entries is also 0.
In such cases the current entry should be "NoCurrentEntryIndex."
When we later read this state in, we set ourselves up to crash later.
Amusingly an ASSERT caught this, but we should've rejected it before the ASSERT fired.
- UIProcess/cf/WebBackForwardListCF.cpp:
(WebKit::WebBackForwardList::restoreFromCFDictionaryRepresentation): Fail the restore if the "current index past the end
of the list" case occurs, and speculatively bail out of the case where we have no current index but do have a list.
Also remove the unhelpful ASSERT.
- 16:22 Changeset [77860] by
-
2011-02-07 Zhenyao Mo <zmo@google.com>
Unreviewed, test expectations update.
- platform/chromium/test_expectations.txt:
- 16:11 Changeset [77859] by
-
2011-02-07 Zhenyao Mo <zmo@google.com>
Unreviewed, test expectations update.
- platform/chromium/test_expectations.txt:
- 16:07 Changeset [77858] by
-
<rdar://problem/8946023> REGRESSION (r76674): SVG + BiDi text broken (text-intro-05-t.svg)
https://bugs.webkit.org/show_bug.cgi?id=53480
Reviewed by Oliver Hunt.
- WebCore.xcodeproj/project.pbxproj:
- platform/graphics/mac/ComplexTextController.cpp:
(WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun): m_indexEnd should be an
offset into m_characters, not into the run’s characters.
- platform/graphics/mac/ComplexTextControllerATSUI.cpp:
(WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun): Ditto.
- 16:01 Changeset [77857] by
-
2011-02-07 Zhenyao Mo <zmo@google.com>
Unreviewed, test expectations update.
- platform/chromium/test_expectations.txt:
- 15:46 Changeset [77856] by
-
Add bundle API to get the background color of a frame
<rdar://problem/8962670>
https://bugs.webkit.org/show_bug.cgi?id=53952
Reviewed by Anders Carlsson.
../WebCore:
- WebCore.exp.in: Add export.
../WebKit2:
- WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
(WKBundleFrameGetBodyBackgroundColor):
- WebProcess/InjectedBundle/API/c/WKBundleFrame.h:
Add API function.
- WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::getDocumentBackgroundColor):
- WebProcess/WebPage/WebFrame.h:
Call down into the document to get either the body's, or if there is no body,
the root element's, background color.
- 15:45 Changeset [77855] by
-
Unreviewed.
[Qt] Fix crashes in QMetaObject::metacall
https://bugs.webkit.org/show_bug.cgi?id=53912
- platform/qt/Skipped: http/tests/websocket/tests/websocket-pending-activity.html added until fix.
- 15:41 Changeset [77854] by
-
2011-02-07 Zhenyao Mo <zmo@google.com>
Unreviewed, rebaseline.
- platform/chromium-mac/fast/url/path-expected.txt:
- platform/chromium-win/fast/url/path-expected.txt:
- 15:37 Changeset [77853] by
-
2011-02-07 Geoffrey Garen <ggaren@apple.com>
Reviewed by Darin Adler.
Assertion failure in ~JSGlobalObject when loading apple.com HTML5
transitions demo page
https://bugs.webkit.org/show_bug.cgi?id=53853
This was a long-standing bookkeeping bug uncovered by some heap refactoring.
- html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::createImageBuffer):
- html/HTMLImageLoader.cpp: (WebCore::HTMLImageLoader::notifyFinished):
- xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::dropProtection): Take the JSLock before reporting extra cost to the JavaScriptCore heap, since all use of JavaScriptCore is supposed to be guarded by JSLock.
- 15:28 Changeset [77852] by
-
Intermittent crash in fast/files/read-blob-async.html on the GTK+ debug
bots
https://bugs.webkit.org/show_bug.cgi?id=53104
Reviewed by David Levin.
Source/WebCore:
Covered by the existing tests.
- fileapi/FileStreamProxy.cpp:
(WebCore::FileStreamProxy::startOnFileThread):
- platform/network/BlobRegistryImpl.cpp:
(WebCore::BlobRegistryImpl::createResourceHandle):
- platform/network/BlobResourceHandle.cpp:
(WebCore::BlobResourceHandle::BlobResourceHandle):
(WebCore::BlobResourceHandle::cancel):
(WebCore::delayedStartBlobResourceHandle):
(WebCore::BlobResourceHandle::start): Keep BlobResourceHandle alive
till the delay function is called.
(WebCore::BlobResourceHandle::doStart):
(WebCore::doNotifyFinish):
(WebCore::BlobResourceHandle::notifyFinish): Notify the client via the
standalone function to prevent the handle from being disposed immediately
by the client which will make the calls in the stack that're still bound
to the handle suffer.
- platform/network/BlobResourceHandle.h:
- platform/network/ResourceHandle.h: Change cancel() to virtual so that
BlobResourceHandle::cancel will be called when we abort a FileReader.
LayoutTests:
- platform/gtk/Skipped: Enable the flakey test that has been fixed.
- 15:27 Changeset [77851] by
-
2011-02-07 Adam Barth <abarth@webkit.org>
Remove wrong platform-specific expectation.
- platform/win/plugins/plugin-document-back-forward-expected.txt: Removed.
- 15:09 Changeset [77850] by
-
2011-02-07 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r77845.
http://trac.webkit.org/changeset/77845
https://bugs.webkit.org/show_bug.cgi?id=53946
build failure (Requested by lforschler_ on #webkit).
- WebCore.xcodeproj/project.pbxproj:
- accessibility/AccessibilityAllInOne.cpp:
- 15:05 Changeset [77849] by
-
https://bugs.webkit.org/show_bug.cgi?id=53939
fast/css/text-overflow-ellipsis.html failure after r77818/77819
- platform/text/TextCodecICU.cpp:
(WebCore::TextCodecICU::registerExtendedEncodingNames):
Add back the "utf8" synonym for "UTF-8".
- 14:58 Changeset [77848] by
-
Remove an unnecessary extra computeLogicalWidth() from line layout.
Reviewed by Dan Bernstein.
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::computeInlineDirectionPositionsForLine):
- 14:34 Changeset [77847] by
-
Fix typo. vectical -> vertical.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didChangeScrollbarsForMainFrame):
- 14:32 Changeset [77846] by
-
Inform the UIProcess when main frame scrollbars change
<rdar://problem/8967496>
https://bugs.webkit.org/show_bug.cgi?id=53941
Reviewed by Anders Carlsson.
- UIProcess/API/C/WKPage.cpp:
(WKPageHasHorizontalScrollbar):
(WKPageHasVerticalScrollbar):
- UIProcess/API/C/WKPage.h:
Add API to query whether the main frame has scrollbars.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::close):
(WebKit::WebPageProxy::processDidCrash):
(WebKit::WebPageProxy::didChangeScrollbarsForMainFrame):
- UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::hasHorizontalScrollbar):
(WebKit::WebPageProxy::hasVerticalScrollbar):
Store/update main frame scrollbar state.
- UIProcess/WebPageProxy.messages.in:
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::contentsSizeChanged):
- WebProcess/WebCoreSupport/WebChromeClient.h:
(WebKit::WebChromeClient::WebChromeClient):
Post message when main frame scrollbar state changes.
- 14:28 Changeset [77845] by
-
2011-02-07 Lucas Forschler <lforschler@apple.com>
Reviewed by Geoffrey Garen.
Fix Leopard Intel Debug Build.
<rdar://problem/8953606> REGRESSION: Can't link WebCore on 32-bit Leopard (53681)
This could potentially break windows, since I had to change #include <filename> to #include "filename"
- WebCore.xcodeproj/project.pbxproj:
- accessibility/AccessibilityAllInOne.cpp:
- 13:54 Changeset [77844] by
-
2011-02-07 Zhenyao Mo <zmo@google.com>
Unreviewed, test expectations update.
- platform/chromium/test_expectations.txt:
- 13:48 Changeset [77843] by
-
Fix build.
- platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::didAddVerticalScrollbar):
(WebCore::ScrollAnimatorMac::willRemoveVerticalScrollbar):
(WebCore::ScrollAnimatorMac::didAddHorizontalScrollbar):
(WebCore::ScrollAnimatorMac::willRemoveHorizontalScrollbar):
- 13:42 Changeset [77842] by
-
2011-02-07 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Some content is not covered by Find-on-page overlay
https://bugs.webkit.org/show_bug.cgi?id=53937
<rdar://problem/8711353>
- WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::didInstallPageOverlay): Call LayerTreeHost::didInstallPageOverlay.
(WebKit::DrawingAreaImpl::didUninstallPageOverlay):
Call LayerTreeHost::didUninstallPageOverlay.
(WebKit::DrawingAreaImpl::setPageOverlayNeedsDisplay):
Call LayerTreeHost::setPageOverlayNeedsDisplay.
- WebProcess/WebPage/FindController.cpp: (WebKit::FindController::drawRect): Remove a bogus assertion.
- WebProcess/WebPage/LayerTreeHost.h: Add new pure virtual member functions.
- WebProcess/WebPage/PageOverlay.cpp: (WebKit::PageOverlay::setNeedsDisplay): Call DrawingArea::setPageOverlayNeedsDisplay.
- WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::installPageOverlay): Make sure to call PageOverlay::setNeedsDisplay after the page overlay has been installed.
- WebProcess/WebPage/mac/LayerTreeHostMac.mm: (WebKit::LayerTreeHostMac::LayerTreeHostMac): Create the page overlay layer if needed.
(WebKit::LayerTreeHostMac::setNonCompositedContentsNeedDisplay):
Invalidate the page overlay layer as well.
(WebKit::LayerTreeHostMac::sizeDidChange):
Resize the page overlay layer.
(WebKit::LayerTreeHostMac::didInstallPageOverlay):
Create the page overlay layer.
(WebKit::LayerTreeHostMac::didUninstallPageOverlay):
Destroy the page overlay layer.
(WebKit::LayerTreeHostMac::setPageOverlayNeedsDisplay):
Call setNeedsDisplay on the page overlay layer.
(WebKit::LayerTreeHostMac::paintContents):
Handle painting the page overlay layer.
(WebKit::LayerTreeHostMac::flushPendingLayerChanges):
Flush the page overlay layer changes as well.
(WebKit::LayerTreeHostMac::createPageOverlayLayer):
Create a layer and add it as a sublayer of the root layer.
(WebKit::LayerTreeHostMac::destroyPageOverlayLayer):
Destroy the page overlay layer.
- 13:29 Changeset [77841] by
-
Add mechanism to inform the ScrollAnimator when Scrollbars are added
and removed.
Reviewed by Beth Dakin.
- platform/ScrollAnimator.h:
(WebCore::ScrollAnimator::didAddVerticalScrollbar):
(WebCore::ScrollAnimator::willRemoveVerticalScrollbar):
(WebCore::ScrollAnimator::didAddHorizontalScrollbar):
(WebCore::ScrollAnimator::willRemoveHorizontalScrollbar):
Make virtual to allow platform specific overrides.
- platform/ScrollView.cpp:
(WebCore::ScrollView::setHasHorizontalScrollbar):
(WebCore::ScrollView::setHasVerticalScrollbar):
Call new ScrollableArea functions.
- platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::didAddVerticalScrollbar):
(WebCore::ScrollableArea::willRemoveVerticalScrollbar):
(WebCore::ScrollableArea::didAddHorizontalScrollbar):
(WebCore::ScrollableArea::willRemoveHorizontalScrollbar):
- platform/ScrollableArea.h:
Pipe to ScrollAnimator.
- platform/mac/ScrollAnimatorMac.h:
- platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::didAddVerticalScrollbar):
(WebCore::ScrollAnimatorMac::willRemoveVerticalScrollbar):
(WebCore::ScrollAnimatorMac::didAddHorizontalScrollbar):
(WebCore::ScrollAnimatorMac::willRemoveHorizontalScrollbar):
- platform/mac/ScrollbarThemeMac.h:
- platform/mac/ScrollbarThemeMac.mm:
(WebCore::ScrollbarThemeMac::registerScrollbar):
(WebCore::ScrollbarThemeMac::unregisterScrollbar):
(WebCore::ScrollbarThemeMac::painterForScrollbar):
Move painter delegate registration to the new didAdd/willRemove functions.
- 13:25 Changeset [77840] by
-
2011-02-07 Zhenyao Mo <zmo@google.com>
Unreviewed, test expectations update.
- platform/chromium/test_expectations.txt:
- 13:19 Changeset [77839] by
-
Make it possible to use DrawingAreaProxyImpl on Windows
It can be optionally turned on by setting the WEBKIT2_USE_NEW_DRAWING_AREA environment
variable. Turning it on by default is covered by <http://webkit.org/b/53805>.
Fixes <http://webkit.org/b/53879>.
Reviewed by Anders Carlsson.
- UIProcess/BackingStore.h: Add an m_bitmap member on Windows.
- UIProcess/win/BackingStoreWin.cpp:
(WebKit::BitmapDC::operator HDC):
(WebKit::BitmapDC::BitmapDC):
(WebKit::BitmapDC::~BitmapDC):
Added this helper class, which uses RAII to select a bitmap into a new memory DC.
(WebKit::BackingStore::paint): Wrap our bitmap in a BitmapDC and use ::BitBlt to copy the
specified rect into the destination DC.
(WebKit::createBitmap): New helper function, just creates a DIB section with the specified
size.
(WebKit::BackingStore::incorporateUpdate): Ported from BackingStoreMac.mm. It seems like
this code could be shared at some point.
(WebKit::BackingStore::scroll): Wrap our bitmap in a BitmapDC and use ::ScrollDC to scroll
the specified rect.
- UIProcess/win/WebView.cpp:
(WebKit::useNewDrawingArea): Added. Returns true if the WEBKIT2_USE_NEW_DRAWING_AREA
environment variable is set.
(WebKit::drawPageBackground): New helper function. Code came from onPaintEvent.
(WebKit::WebView::onPaintEvent): Ported from -[WKView drawRect:].
(WebKit::WebView::createDrawingAreaProxy): Create a DrawingAreaProxyImpl if we're using the
new drawing area.
(WebKit::WebView::enterAcceleratedCompositingMode):
(WebKit::WebView::exitAcceleratedCompositingMode):
(WebKit::WebView::pageDidEnterAcceleratedCompositing):
(WebKit::WebView::pageDidLeaveAcceleratedCompositing):
Added some assertions to make sure these are only called when expected. We don't expect
enter/exitAcceleratedCompositingMode to be called at all right now, because accelerated
compositing is turned off in WebKit2 on Windows.
(WebKit::WebView::switchToDrawingAreaTypeIfNecessary): Ditto, and added a case for the
DrawingAreaInfo::Impl constant.
- 13:19 Changeset [77838] by
-
Start compiling DrawingArea[Proxy]Impl and dependencies on Windows
Fixes <http://webkit.org/b/53875> WebKit2 on Windows should build DrawingArea[Proxy]Impl
Reviewed by Sam Weinig and Darin Adler.
- Platform/Region.cpp:
(WebKit::Region::Shape::shapeOperation): Initialize variable to avoid a bogus "potentially
uninitialized variable" warning.
- UIProcess/BackingStore.cpp: Removed #error for non-Mac platforms.
- UIProcess/BackingStore.h: Added a PlatformGraphicsContext typedef for Windows.
- UIProcess/DrawingAreaProxy.h:
- UIProcess/DrawingAreaProxyImpl.cpp:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didReceiveMessage):
Allow Windows to compile the new drawing area code.
- WebProcess/WebPage/DrawingArea.cpp:
(WebKit::DrawingArea::create): Allow creating a DrawingAreaImpl on Windows, too.
- WebProcess/WebPage/DrawingArea.h:
- WebProcess/WebPage/DrawingAreaImpl.cpp:
- WebProcess/WebPage/LayerTreeHost.cpp:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::didReceiveMessage):
Allow Windows to compile the new drawing area code.
- Shared/win/LayerTreeContextWin.cpp: Added.
- UIProcess/win/BackingStoreWin.cpp: Added.
Stubbed out these files.
- win/WebKit2.vcproj: Added new files.
- 12:57 Changeset [77837] by
-
2011-02-07 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
Rename some drawing area related member functions
https://bugs.webkit.org/show_bug.cgi?id=53935
- WebProcess/WebPage/DrawingArea.h: (WebKit::DrawingArea::setPageOverlayNeedsDisplay):
- WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::setNeedsDisplay): (WebKit::DrawingAreaImpl::setPageOverlayNeedsDisplay):
- WebProcess/WebPage/DrawingAreaImpl.h:
- WebProcess/WebPage/LayerTreeHost.h:
- WebProcess/WebPage/mac/LayerTreeHostMac.h:
- WebProcess/WebPage/mac/LayerTreeHostMac.mm: (WebKit::LayerTreeHostMac::setNonCompositedContentsNeedDisplay): (WebKit::LayerTreeHostMac::scrollNonCompositedContents):
- 12:49 Changeset [77836] by
-
2011-02-07 Chang Shu <chang.shu@nokia.com>
Reviewed by Darin Adler.
We should disable spatial navigation explicitly during the initialization
of DumpRenderTree.
https://bugs.webkit.org/show_bug.cgi?id=53928
- DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues):
- 12:43 Changeset [77835] by
-
2011-02-07 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
Missing text match markers with accelerated content
https://bugs.webkit.org/show_bug.cgi?id=53934
When doing the fake paint that recomputes the text match rects, we need to
flatten compositing layers, otherwise the rects won't be updated until the next paint call.
(This worked by accident in WebKit1 because Safari calls -[NSWindow displayIfNeeded] on the containing
window before asking for the text match rects).
- editing/Editor.cpp: (WebCore::Editor::countMatchesForText):
- 12:08 Changeset [77834] by
-
REGRESSION(r77740): CSSStyleSelector accessing deleted memory for svg/dom/use-transform.svg
https://bugs.webkit.org/show_bug.cgi?id=53900
Reviewed by Andreas Kling.
Ignore link elements in shadow trees.
- dom/Element.cpp:
(WebCore::StyleSelectorParentPusher::StyleSelectorParentPusher):
(WebCore::StyleSelectorParentPusher::~StyleSelectorParentPusher):
Some asserts to catch cases like this.
(WebCore::Element::attach):
(WebCore::Element::recalcStyle):
- html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::HTMLLinkElement):
(WebCore::HTMLLinkElement::process):
(WebCore::HTMLLinkElement::insertedIntoDocument):
(WebCore::HTMLLinkElement::removedFromDocument):
- html/HTMLLinkElement.h:
- 11:39 BuildingQtOnSymbian edited by
- add .slimdebug (diff)
- 11:18 Changeset [77833] by
-
2011-02-07 Dimitri Glazkov <dglazkov@chromium.org>
Mark test as flaky per dashboard.
https://bugs.webkit.org/show_bug.cgi?id=53824
- platform/chromium/test_expectations.txt: Marked.
- 11:10 Changeset [77832] by
-
Merge 77706 - 2011-02-04 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
PluginDocuments don't create widgets for plugins on back/forward
https://bugs.webkit.org/show_bug.cgi?id=53474
Test that plugin loads when in a plugin document on back-forward.
- plugins/plugin-document-back-forward-expected.txt: Added.
- plugins/plugin-document-back-forward.html: Added.
2011-02-04 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
PluginDocuments don't create widgets for plugins on back/forward
https://bugs.webkit.org/show_bug.cgi?id=53474
Long ago, PluginDocument always caused the HTMLEmbedElement to create
its widget synchronously during a post-layout task. Recently, however,
some changes to the HistroyController caused layout on back/forward to
become slightly more complicated (and added an extra level of recursion
to layout). This extra level of recursion triggered the "I've recursed
too many times" condition in the post-layout task queue, causing the
FrameView to run the remainder of the tasks asynchronously.
Unfortunately, that broke PluginDocument because it needs its the
HTMLEmbedElement's updateWidget task to run synchronously.
This patch adds a mechanism for "kicking off" the pending post-layout
tasks synchronously (instead of waiting for the timer to fire).
PluginDocument then uses that facility to ensure that the
HTMLEmbedElement's updateWidget task happens.
Test: plugins/plugin-document-back-forward.html
- html/PluginDocument.cpp: (WebCore::PluginDocumentParser::appendBytes):
- page/FrameView.cpp: (WebCore::FrameView::flushAnyPendingPostLayoutTasks):
- page/FrameView.h:
2011-02-04 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
PluginDocuments don't create widgets for plugins on back/forward
https://bugs.webkit.org/show_bug.cgi?id=53474
Teach the test plugin how to call alert on load.
- DumpRenderTree/TestNetscapePlugIn/main.cpp: (NPP_New):
TBR=abarth@webkit.org
Review URL: http://codereview.chromium.org/6286151
- 10:47 BuildingQtOnSymbian edited by
- add -b syntax for compiling both Source and Tools project files (diff)
- 10:46 Changeset [77831] by
-
Turn UTF-8 decoder off for now so we can look into failing tests
without leaving the tree red.
- platform/text/TextCodecICU.cpp:
(WebCore::TextCodecICU::registerBaseEncodingNames): Reverting
earlier change so this can handle UTF-8.
(WebCore::TextCodecICU::registerBaseCodecs): Ditto.
(WebCore::TextCodecICU::registerExtendedEncodingNames): Ditto.
(WebCore::TextCodecICU::registerExtendedCodecs): Ditto.
- platform/text/TextCodecICU.h: Ditto.
- platform/text/TextEncodingRegistry.cpp:
(WebCore::buildBaseTextCodecMaps): Ditto.
(WebCore::extendTextCodecMaps): Ditto.
- platform/text/brew/TextCodecBrew.cpp:
(WebCore::TextCodecBrew::registerBaseEncodingNames): Ditto.
(WebCore::TextCodecBrew::registerBaseCodecs): Ditto.
(WebCore::TextCodecBrew::registerExtendedEncodingNames): Ditto.
(WebCore::TextCodecBrew::registerExtendedCodecs): Ditto.
- platform/text/brew/TextCodecBrew.h: Ditto.
- platform/text/gtk/TextCodecGtk.cpp:
(WebCore::TextCodecGtk::registerBaseEncodingNames): Ditto.
(WebCore::TextCodecGtk::registerBaseCodecs): Ditto.
- platform/text/wince/TextCodecWinCE.cpp:
(WebCore::TextCodecWinCE::registerBaseEncodingNames): Ditto.
(WebCore::TextCodecWinCE::registerBaseCodecs): Ditto.
(WebCore::TextCodecWinCE::registerExtendedEncodingNames): Ditto.
(WebCore::TextCodecWinCE::registerExtendedCodecs): Ditto.
- platform/text/wince/TextCodecWinCE.h: Ditto.
- 10:45 Changeset [77830] by
-
Use the right calling convention when calling WebKitMain
Fixes <http://webkit.org/b/53923> REGRESSION (r77678): Crash on quit in web process in
wWinMain
Reviewed by Steve Falkenburg.
- win/MainWin.cpp:
(wWinMain): Use cdecl instead of WINAPI (stdcall) when calling WebKitMain, since that is
how that function is declared.
- 10:39 Changeset [77829] by
-
2011-02-07 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
The drawing area should be in charge of drawing the page overlay
https://bugs.webkit.org/show_bug.cgi?id=53927
- WebProcess/WebPage/DrawingArea.h: (WebKit::DrawingArea::didInstallPageOverlay): (WebKit::DrawingArea::didUninstallPageOverlay): (WebKit::DrawingArea::setOverlayNeedsDisplay): Add empty stubs.
- WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::didInstallPageOverlay): Add empty function. This will eventually ask the layer tree host to create a GraphicsLayer for the page overlay.
(WebKit::DrawingAreaImpl::didUninstallPageOverlay):
Tell the page that it needs to be repainted.
(WebKit::DrawingAreaImpl::setOverlayNeedsDisplay):
Just call setNeedsDisplay for now.
(WebKit::DrawingAreaImpl::display):
Paint the page overlay too.
- WebProcess/WebPage/DrawingAreaImpl.h:
- WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::drawRect): Only call drawPageOverlay if we have an old drawing area.
(WebKit::WebPage::drawPageOverlay):
Draw the page overlay. Code moved here from WebPage::drawRect.
(WebKit::WebPage::installPageOverlay):
Call DrawingArea::installPageOverlay.
(WebKit::WebPage::uninstallPageOverlay):
Call DrawingArea::uninstallPageOverlay.
- WebProcess/WebPage/WebPage.h: (WebKit::WebPage::hasPageOverlay): Add getter.
- 10:31 Changeset [77828] by
-
Don't exclude overlay scrollers from the page overlay bounds
https://bugs.webkit.org/show_bug.cgi?id=53924
Reviewed by Maciej Stachowiak.
Export ScrollbarTheme::nativeTheme.
- WebCore.exp.in:
- 10:31 Changeset [77827] by
-
Merge 77597 - 2011-02-03 Anton Muhin <antonm@chromium.org>
Reviewed by Adam Barth.
[v8] Bail out if to string conversion returned empty handle
https://bugs.webkit.org/show_bug.cgi?id=53687
This a temporary measure: actually one probably should never get empty handle
if there was no exception. The root cause is under investigation.
The bailout though allows Chromium not to crash---attempt to convert an empty
v8 hande into WebCore string crashes with invalid memory access.
See http://code.google.com/p/chromium/issues/detail?id=71544
There is no known reduction expressible as a layout test so far. The crash found with automated testing tools.
- bindings/v8/V8Binding.cpp: (WebCore::v8NonStringValueToWebCoreString): Bail out on empty handle
- bindings/v8/V8Binding.h: (WebCore::V8ParameterBase::prepareBase): Ditto
TBR=antonm@chromium.org
Review URL: http://codereview.chromium.org/6368135
- 10:26 Changeset [77826] by
-
2011-02-07 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Add WebPage::bounds and use it
https://bugs.webkit.org/show_bug.cgi?id=53926
- WebProcess/WebPage/ChunkedUpdateDrawingArea.cpp: (WebKit::ChunkedUpdateDrawingArea::resumePainting):
- WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::resumePainting): (WebKit::DrawingAreaImpl::exitAcceleratedCompositingMode):
- WebProcess/WebPage/WebPage.h: (WebKit::WebPage::bounds):
- 10:21 Changeset [77825] by
-
2011-02-07 Anders Carlsson <andersca@apple.com>
Reviewed by Maciej Stachowiak.
Don't exclude overlay scrollers from the page overlay bounds
https://bugs.webkit.org/show_bug.cgi?id=53924
Don't subtract the scrollbars from the page overlay bounds if
overlay scrollers are enabled.
- WebProcess/WebPage/PageOverlay.cpp: (WebKit::PageOverlay::bounds):
- 10:18 Changeset [77824] by
-
2011-02-07 Martin Robinson <mrobinson@igalia.com>
Unskip a passing accessibility test and organize the rest of the tests missing
results as failing.
- platform/gtk/Skipped: Unskip passing test and organize remaining failures.
- platform/gtk/accessibility/aria-describedby-on-input-expected.txt: Added.
- 10:02 Changeset [77823] by
-
Add built-in decoder for UTF-8 for improved performance
https://bugs.webkit.org/show_bug.cgi?id=53898
Reviewed by Antti Koivisto.
- wtf/unicode/UnicodeMacrosFromICU.h: Added U8_MAX_LENGTH and
U8_APPEND_UNSAFE. Also fixed header.
- 09:57 Changeset [77822] by
-
Not reviewed.
Fix WebKitTestRunner build on the SL bot.
- WebKitTestRunner/Configurations/Base.xcconfig: Look for the JSC copy
of ICU headers.
- 09:29 Changeset [77821] by
-
2011-02-03 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
Crash in glDrawArrays with NaCl crystal model
https://bugs.webkit.org/show_bug.cgi?id=52831
- html/canvas/WebGLRenderingContext.cpp: Allocate large enough buffer for atttrib0 if it's enabled and not used. (WebCore::WebGLRenderingContext::initVertexAttrib0): (WebCore::WebGLRenderingContext::simulateVertexAttrib0):
- html/canvas/WebGLRenderingContext.h:
2011-02-03 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
Crash in glDrawArrays with NaCl crystal model
https://bugs.webkit.org/show_bug.cgi?id=52831
- fast/canvas/webgl/gl-vertex-attrib-zero-issues-expected.txt: Added.
- fast/canvas/webgl/gl-vertex-attrib-zero-issues.html: Added.
- 09:24 Changeset [77820] by
-
Source/WebCore: WAI-ARIA @aria-sort not exposed on rowheader and columnheader roles.
https://bugs.webkit.org/show_bug.cgi?id=53842
Reviewed by Darin Adler.
Test: platform/mac/accessibility/aria-sort.html
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::sortDirection):
- accessibility/AccessibilityObject.h:
- accessibility/mac/AccessibilityObjectWrapper.mm:
(-[AccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
(-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
- html/HTMLAttributeNames.in:
LayoutTests: WAI-ARIA @aria-sort not exposed on rowheader and columnheader roles
https://bugs.webkit.org/show_bug.cgi?id=53842
Reviewed by Darin Adler.
- platform/mac/accessibility/aria-sort-expected.txt: Added.
- platform/mac/accessibility/aria-sort.html: Added.
- 08:35 Changeset [77819] by
-
2011-02-06 Darin Adler <darin@apple.com>
Reviewed by Antti Koivisto.
Add built-in decoder for UTF-8 for improved performance
https://bugs.webkit.org/show_bug.cgi?id=53898
Correct behavior is covered by existing tests.
- Android.mk: Added TextCodecUTF8.
- CMakeLists.txt: Ditto.
- GNUmakefile.am: Ditto.
- WebCore.gypi: Ditto.
- WebCore.pro: Ditto.
- WebCore.vcproj/WebCore.vcproj: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- platform/text/TextCodecICU.cpp: Removed registration of UTF-8 since that's now handled by the built-in UTF-8 codec. (WebCore::TextCodecICU::registerEncodingNames): Renamed to remove the word "extended" since all codecs from ICU are now extended. (WebCore::TextCodecICU::registerCodecs): Ditto.
- platform/text/TextCodecICU.h: Ditto.
- platform/text/TextCodecUTF16.cpp: (WebCore::TextCodecUTF16::decode): Added a FIXME about missing error handling.
- platform/text/TextCodecUTF8.cpp: Added.
- platform/text/TextCodecUTF8.h: Added.
- platform/text/TextEncodingRegistry.cpp: (WebCore::buildBaseTextCodecMaps): Added TextCodecUTF8, and removed TextCodecICU, TextCodecBrew, and TextCodecWinCE. (WebCore::extendTextCodecMaps): Updated names for TextCodecICU and TextCodecWinCE.
- platform/text/brew/TextCodecBrew.cpp: (WebCore::TextCodecBrew::registerEncodingNames): Renamed to remove the word "extended" since all codecs from Brew are now extended. (WebCore::TextCodecBrew::registerCodecs): Ditto.
- platform/text/brew/TextCodecBrew.h: Ditto.
- platform/text/gtk/TextCodecGtk.cpp: (WebCore::TextCodecGtk::registerBaseEncodingNames): Removed registration of UTF-8. It's questionable whether the other codecs here are really basic. If we think they qualify, then we should register them on other platforms, not just GTK. (WebCore::TextCodecGtk::registerBaseCodecs): Ditto.
- platform/text/wince/TextCodecWinCE.cpp: (WebCore::getCodePage): Removed special case for UTF-8 since we no longer use this codec for UTF-8. (WebCore::TextCodecWinCE::registerEncodingNames): Renamed to remove the word "extended" since all codecs from WinCE are now extended. (WebCore::TextCodecWinCE::registerCodecs): Ditto.
- platform/text/wince/TextCodecWinCE.h: Ditto.
- 08:35 Changeset [77818] by
-
2011-02-07 Martin Robinson <mrobinson@igalia.com>
Reviewed by Daniel Bates.
[GTK] fast/history/history-subframe-with-name.html fails with GTK DRT
https://bugs.webkit.org/show_bug.cgi?id=44784
- platform/gtk/Skipped: Unskip tests which are now passing.
2011-02-07 Martin Robinson <mrobinson@igalia.com>
Reviewed by Daniel Bates.
[GTK] fast/history/history-subframe-with-name.html fails with GTK DRT
https://bugs.webkit.org/show_bug.cgi?id=44784
Call FrameLoader::loadURLIntoChildFrame on the parent frame's loader, not the child's.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::createFrame): Fix the call to FrameLoader::loadURLIntoChildFrame.
- 08:23 Changeset [77817] by
-
2011-02-07 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Xan Lopez.
[Gtk] atk_text_get_caret_offset fails for list items
https://bugs.webkit.org/show_bug.cgi?id=53436
Consider list item markers when calculating the offset.
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_text_get_caret_offset): Adjust the offset with the item marker's length for list items. (webkit_accessible_text_set_caret_offset): Replace usage of g_utf8_strlen() by calling to markerText.length().
2011-02-07 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Xan Lopez.
[Gtk] atk_text_get_caret_offset fails for list items
https://bugs.webkit.org/show_bug.cgi?id=53436
Update unit test to check the fix for this bug.
- tests/testatk.c: (testWebkitAtkCaretOffsets): Check that the caret offset returned match the value previously set.
- 08:03 Changeset [77816] by
-
Windows build fix after r77794
- win/WebKit2.def: Export WebCore symbols used by WebKitTestRunner.
- 08:02 Changeset [77815] by
-
Delete precompiled headers whenever any .vsprops file changes
Precompiled headers need to be rebuilt if, e.g., an ENABLE_* macro is changed in one of our
.vsprops files. Unfortunately, Visual Studio isn't smart enough to figure this out, so we
give it some assistance by deleting the precompiled headers whenever any .vsprops file
changes.
I also made some drive-by fixes while I was in the area.
Fixes <http://webkit.org/b/53826> react-to-vsprops-changes.py doesn't force precompiled
headers to be rebuilt, but should
Reviewed by David Kilzer.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make: Stop ignoring the
return code from react-to-vsprops-changes.py so we will notice when errors are introduced.
But skip the script entirely in production builds, where it is both unnecessary and can't
function correctly (due to not having the entire source tree available to it).
- JavaScriptCore.vcproj/JavaScriptCore/react-to-vsprops-changes.py:
(main): Removed an extra '*' in the glob for finding manifest files. The extra '*' was
leftover from before we rearranged WebKitBuild in r75138. Moved code to delete an old file
to the new delete_if_older_than function. Added code to delete any precompiled headers older
than the newest .vsprops file.
(delete_if_older_than): Added. Code came from main.
- 07:57 Changeset [77814] by
-
2011-02-07 Yi Shen <yi.4.shen@nokia.com>
Reviewed by Tor Arne Vestbø.
[Qt] Fix LayoutTests/media/restore-from-page-cache.html
https://bugs.webkit.org/show_bug.cgi?id=53621
Unskip media/restore-from-page-cache.html for Qt.
- platform/qt/Skipped:
2011-02-07 Yi Shen <yi.4.shen@nokia.com>
Reviewed by Tor Arne Vestbø.
[Qt] Fix LayoutTests/media/restore-from-page-cache.html
https://bugs.webkit.org/show_bug.cgi?id=53621
Changed the networkState to MediaPlayer::Loaded when
MediaPlayerPrivateQt has enough data.
Test: media/restore-from-page-cache.html
- platform/graphics/qt/MediaPlayerPrivateQt.cpp: (WebCore::MediaPlayerPrivateQt::updateStates):
- 07:56 Changeset [77813] by
-
2011-02-07 Patrick Gansterer <paroga@webkit.org>
Reviewed by Andreas Kling.
[Haiku] FrameLoaderClient calls loadURLInChildFrame on the child's frame loader
https://bugs.webkit.org/show_bug.cgi?id=53893
- WebCoreSupport/FrameLoaderClientHaiku.cpp: (WebCore::FrameLoaderClientHaiku::createFrame): Use m_frame instead of childFrame.
- 07:31 Changeset [77812] by
-
2011-02-07 Ilya Tikhonovsky <loislo@chromium.org>
Unreviewed.
Chromium: three tests temporary disabled for rebaseline after r77781
- platform/chromium/test_expectations.txt:
- 07:18 Changeset [77811] by
-
2011-02-07 Patrick Gansterer <paroga@webkit.org>
Reviewed by Andreas Kling.
[EFL] FrameLoaderClient calls loadURLInChildFrame on the child's frame loader
https://bugs.webkit.org/show_bug.cgi?id=53892
- ewk/ewk_frame.cpp: (ewk_frame_child_add): Use the loader of the core frame instead.
- 07:15 Changeset [77810] by
-
2011-02-04 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: implement beautification of scripts inlined in html documents.
https://bugs.webkit.org/show_bug.cgi?id=52706
- http/tests/inspector/debugger-test2.js: (initialize_DebuggerTest.InspectorTest.setBreakpointInVisibleView):
- inspector/debugger-breakpoints-not-activated-on-reload.html:
- inspector/debugger-pause-on-breakpoint.html:
2011-01-31 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: implement beautification of scripts inlined in html documents.
https://bugs.webkit.org/show_bug.cgi?id=52706
To beautify scripts inlined in html, we need to cut individual scripts, beautify them using UglifyJS library, and
finally paste them back to html.
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/front-end/ScriptFormatter.js: (WebInspector.ScriptFormatter): Implement formatting of scripts inlined in html. (WebInspector.ScriptFormatter.prototype.formatContent.didFormatChunks): (WebInspector.ScriptFormatter.prototype.formatContent): (WebInspector.ScriptFormatter.prototype._splitContentIntoChunks): (WebInspector.ScriptFormatter.prototype._formatChunks.didFormat): (WebInspector.ScriptFormatter.prototype._formatChunks): (WebInspector.ScriptFormatter.prototype._buildContentFromChunks): (WebInspector.ScriptFormatter.prototype._formatScript.messageHandler): (WebInspector.ScriptFormatter.prototype._formatScript):
- inspector/front-end/ScriptFormatterWorker.js: (onmessage): (buildMapping):
- inspector/front-end/SourceFrame.js: (WebInspector.SourceFrameContent): Use SourceFrameContent and FormattedSourceFrameContent to perform operations with line numbers.
- inspector/front-end/SourceFrameContent.js: Added. (WebInspector.SourceFrameContent): Helper class, holds resource text and scripts layout (WebInspector.SourceFrameContent.prototype.get scriptRanges): (WebInspector.SourceFrameContent.prototype.locationToPosition): (WebInspector.SourceFrameContent.prototype.positionToLocation): (WebInspector.SourceFrameContent.prototype.scriptLocationForLineNumber): (WebInspector.SourceFrameContent.prototype.scriptLocationForRange): (WebInspector.SourceFrameContent.prototype.lineNumberToRange): (WebInspector.SourceFrameContent.prototype._intersectingScriptRange): (WebInspector): (WebInspector.FormattedSourceFrameContent): Helper class, holds original and formatted versions of resource and mapping between them. (WebInspector.FormattedSourceFrameContent.prototype.get text): (WebInspector.FormattedSourceFrameContent.prototype.originalLocationToFormattedLocation): (WebInspector.FormattedSourceFrameContent.prototype.scriptLocationForFormattedLineNumber): (WebInspector.FormattedSourceFrameContent.prototype._convertPosition):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.html:
- 06:55 Changeset [77809] by
-
2011-02-07 Patrick Gansterer <paroga@webkit.org>
Reviewed by Andreas Kling.
[wx] FrameLoaderClient calls loadURLInChildFrame on the child's frame loader
https://bugs.webkit.org/show_bug.cgi?id=53895
- WebKitSupport/FrameLoaderClientWx.cpp: (WebCore::FrameLoaderClientWx::createFrame): Use m_frame instead of childFrame.
- 06:49 Changeset [77808] by
-
2011-02-07 Ilya Tikhonovsky <loislo@chromium.org>
Unreviewed.
Chromium: add explicit "Passed" expectations for the tests which have "failed" expectations in platfrom/mac
The problem was introduced at r77719.
I have to do that because platform/mac is in the list of baseline folders.
See 'Tools/Scripts/webkitpy/layout_tests/port/chromium_linux.py'.
- platform/chromium/canvas/philip/tests/2d.drawImage.broken-expected.txt: Added.
- platform/chromium/canvas/philip/tests/2d.drawImage.image.incomplete.omitted-expected.txt: Added.
- platform/chromium/canvas/philip/tests/2d.fillStyle.parse.invalid.rgba-6-expected.txt: Added.
- platform/chromium/canvas/philip/tests/2d.fillStyle.parse.rgb-eof-expected.txt: Added.
- platform/chromium/canvas/philip/tests/2d.fillStyle.parse.rgba-eof-expected.txt: Added.
- platform/chromium/canvas/philip/tests/2d.fillStyle.parse.system-expected.txt: Added.
- platform/chromium/canvas/philip/tests/2d.gradient.radial.cone.front-expected.txt: Added.
- platform/chromium/canvas/philip/tests/2d.gradient.radial.inside2-expected.txt: Added.
- platform/chromium/canvas/philip/tests/2d.gradient.radial.inside3-expected.txt: Added.
- platform/chromium/canvas/philip/tests/2d.gradient.radial.outside1-expected.txt: Added.
- platform/chromium/canvas/philip/tests/2d.imageData.put.wrongtype-expected.txt: Added.
- platform/chromium/canvas/philip/tests/2d.line.cap.closed-expected.txt: Added.
- platform/chromium/canvas/philip/tests/2d.line.join.parallel-expected.txt: Added.
- platform/chromium/canvas/philip/tests/2d.line.miter.lineedge-expected.txt: Added.
- platform/chromium/canvas/philip/tests/2d.path.rect.winding-expected.txt: Added.
- platform/chromium/canvas/philip/tests/2d.pattern.image.broken-expected.txt: Added.
- platform/chromium/canvas/philip/tests/2d.pattern.image.incomplete.empty-expected.txt: Added.
- platform/chromium/canvas/philip/tests/2d.pattern.image.incomplete.omitted-expected.txt: Added.
- platform/chromium/canvas/philip/tests/2d.shadow.enable.x-expected.txt: Added.
- platform/chromium/canvas/philip/tests/2d.shadow.enable.y-expected.txt: Added.
- platform/chromium/canvas/philip/tests/2d.strokeRect.zero.4-expected.txt: Added.
- platform/chromium/canvas/philip/tests/2d.text.draw.baseline.bottom-expected.txt: Added.
- platform/chromium/canvas/philip/tests/2d.text.draw.baseline.hanging-expected.txt: Added.
- platform/chromium/canvas/philip/tests/2d.text.draw.baseline.middle-expected.txt: Added.
- platform/chromium/canvas/philip/tests/2d.text.draw.baseline.top-expected.txt: Added.
- platform/chromium/canvas/philip/tests/2d.text.draw.fill.maxWidth.fontface-expected.txt: Added.
- platform/chromium/canvas/philip/tests/2d.text.draw.space.collapse.end-expected.txt: Added.
- platform/chromium/canvas/philip/tests/2d.text.draw.space.collapse.nonspace-expected.txt: Added.
- platform/chromium/canvas/philip/tests/2d.text.draw.space.collapse.other-expected.txt: Added.
- platform/chromium/canvas/philip/tests/2d.text.draw.space.collapse.space-expected.txt: Added.
- platform/chromium/canvas/philip/tests/2d.text.draw.space.collapse.start-expected.txt: Added.
- platform/chromium/canvas/philip/tests/2d.text.font.parse.basic-expected.txt: Added.
- platform/chromium/canvas/philip/tests/2d.text.font.parse.complex-expected.txt: Added.
- platform/chromium/canvas/philip/tests/2d.text.font.parse.invalid-expected.txt: Added.
- platform/chromium/canvas/philip/tests/2d.text.font.parse.size.percentage-expected.txt: Added.
- platform/chromium/canvas/philip/tests/2d.text.font.parse.size.percentage.default-expected.txt: Added.
- platform/chromium/canvas/philip/tests/2d.text.font.parse.system-expected.txt: Added.
- platform/chromium/canvas/philip/tests/2d.text.measure.width.space-expected.txt: Added.
- 05:21 Changeset [77807] by
-
2011-02-07 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed.
small text which is scaled to be large renders pixelated
https://bugs.webkit.org/show_bug.cgi?id=12448
Update Snow Leopard SVG pixel test baseline after r77485.
- platform/mac/svg/dom/SVGRectElement/rect-modify-rx-expected.png:
- platform/mac/svg/dynamic-updates/SVGAElement-dom-href-attr-expected.png:
...
- 05:10 Changeset [77806] by
-
2011-02-07 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed.
small text which is scaled to be large renders pixelated
https://bugs.webkit.org/show_bug.cgi?id=12448
Update Snow Leopard SVG pixel test baseline after r77485.
- platform/mac/svg/custom/js-update-polygon-removal-expected.png:
- platform/mac/svg/custom/js-update-style-expected.png:
...
- 05:05 Changeset [77805] by
-
2011-02-07 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed.
small text which is scaled to be large renders pixelated
https://bugs.webkit.org/show_bug.cgi?id=12448
Update Snow Leopard SVG pixel test baseline after r77485.
- platform/mac/svg/custom/class-baseValue-expected.png:
- platform/mac/svg/custom/class-selector-expected.png:
...
- 04:59 Changeset [77804] by
-
2011-02-07 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed.
small text which is scaled to be large renders pixelated
https://bugs.webkit.org/show_bug.cgi?id=12448
Update Snow Leopard SVG pixel test baseline after r77485.
- platform/mac/svg/batik/paints/gradientLimit-expected.png:
- platform/mac/svg/batik/paints/patternRegionA-expected.png:
...
- 03:56 Changeset [77803] by
-
2011-02-07 Alejandro G. Castro <alex@igalia.com>
Unreviewed, added new results for the slider-thumb-drag-release
test and removed use-infinite-recursion.svg from skipped, required
after r77778.
- platform/gtk/Skipped:
- platform/gtk/fast/repaint/slider-thumb-drag-release-expected.checksum: Added.
- platform/gtk/fast/repaint/slider-thumb-drag-release-expected.png: Added.
- platform/gtk/fast/repaint/slider-thumb-drag-release-expected.txt: Added.
- 03:46 Changeset [77802] by
-
2011-02-07 Alexander Pavlov <apavlov@chromium.org>
Unreviewed. Add Web Inspector warning 10x10 PNG, move files from r77801 into the inspector/ directory.
- blog-files/inspector/css_as_authored.png: Renamed from Websites/webkit.org/blog-files/inspector-css-as-authored.png.
- blog-files/inspector/css_autocomplete.png: Renamed from Websites/webkit.org/blog-files/inspector-css-autocomplete.png.
- blog-files/inspector/css_unknown_properties.png: Renamed from Websites/webkit.org/blog-files/inspector-unknown-css-properties.png.
- blog-files/inspector/warning_10x10.png: Added.
- 03:27 Changeset [77801] by
-
2011-02-07 Alexander Pavlov <apavlov@chromium.org>
Unreviewed. Add Web Inspector style editing screenshots.
- blog-files/inspector-css-as-authored.png: Added.
- blog-files/inspector-css-autocomplete.png: Added.
- blog-files/inspector-unknown-css-properties.png: Added.
- 03:26 Changeset [77800] by
-
2011-02-07 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: "Reveal in elements panel" does not always work.
https://bugs.webkit.org/show_bug.cgi?id=53775
- inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView):
- inspector/front-end/ContextMenu.js: (WebInspector.ContextMenu.prototype.show):
- inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.switchToAndFocus):
- inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeOutline.prototype._contextMenuEventFired.focusElement): (WebInspector.ElementsTreeOutline.prototype._contextMenuEventFired):
- inspector/front-end/ObjectPropertiesSection.js: (WebInspector.ObjectPropertyTreeElement.prototype.update): (WebInspector.ObjectPropertyTreeElement.prototype._contextMenuEventFired):
- inspector/front-end/inspector.js: (WebInspector.cancelSearch):
- 03:24 Changeset [77799] by
-
2011-02-07 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Relative .. in URL paths shouldn't skip adjacent / characters
https://bugs.webkit.org/show_bug.cgi?id=53907
Add some more test cases.
- fast/url/path-expected.txt:
- fast/url/script-tests/path.js:
2011-02-07 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Relative .. in URL paths shouldn't skip adjacent / characters
https://bugs.webkit.org/show_bug.cgi?id=53907
Our new behavior matches Firefox, Chrome, and IE.
- platform/KURL.cpp: (WebCore::copyPathRemovingDots):
- 03:16 Changeset [77798] by
-
Unreviewed.
[Qt][WK2] Buildfix after r77794.
WebKitTestRunner does not block remote resources or complain about them
https://bugs.webkit.org/show_bug.cgi?id=42139
<rdar://problem/8183942>
- WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: Add missing includepaths.
- 03:01 Changeset [77797] by
-
Not reviewed.
More bot appeasement.
- WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
- 02:47 Changeset [77796] by
-
Not reviewed.
Remove accidental references to directories on my laptop.
- WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
- 01:59 Changeset [77795] by
-
Merge 76517 - 2011-01-24 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [REGRESSION] AppCache view on resources panel is broken.
https://bugs.webkit.org/show_bug.cgi?id=53002
- inspector/front-end/ApplicationCacheItemsView.js: (WebInspector.ApplicationCacheItemsView.prototype._update):
- inspector/front-end/DOMAgent.js: (WebInspector.ApplicationCacheDispatcher.getApplicationCachesAsync):
TBR=podivilov@chromium.org
Review URL: http://codereview.chromium.org/6368125
- 01:47 Changeset [77794] by
-
2011-02-07 Maciej Stachowiak <mjs@apple.com>
Reviewed by Antti Koivisto.
WebKitTestRunner does not block remote resources or complain about them
https://bugs.webkit.org/show_bug.cgi?id=42139
<rdar://problem/8183942>
- Configurations/WebCore.xcconfig: Allow WebKitTestRunner to link WebCore.
- WebCore.exp.in: Export a handful of KURL symbols.
2011-02-07 Maciej Stachowiak <mjs@apple.com>
Reviewed by Antti Koivisto.
WebKitTestRunner does not block remote resources or complain about them
https://bugs.webkit.org/show_bug.cgi?id=42139
<rdar://problem/8183942>
- platform/mac-wk2/Skipped: Unskip formerly skipped tests.
2011-02-07 Maciej Stachowiak <mjs@apple.com>
Reviewed by Antti Koivisto.
WebKitTestRunner does not block remote resources or complain about them
https://bugs.webkit.org/show_bug.cgi?id=42139
<rdar://problem/8183942>
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::willSendRequestForFrame): Implement the required checks (using KURL, to avoid need to invent a whole URL API).
- WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Link WebCore directly to get at KURL symbols.
- 01:31 Changeset [77793] by
-
2011-02-07 Maciej Stachowiak <mjs@apple.com>
Reviewed by Antti Koivisto.
Add WKURLRequestCopyURL API (needed for tests and also generally useful)
https://bugs.webkit.org/show_bug.cgi?id=53909
- Shared/API/c/WKURLRequest.cpp: (WKURLRequestCopyURL):
- Shared/API/c/WKURLRequest.h:
- Shared/WebURLRequest.h: (WebKit::WebURLRequest::url):
- 00:54 Changeset [77792] by
-
Not reviewed.
ASSERTS_DISABLED -> ASSERT_DISABLED
- wtf/BloomFilter.h:
02/06/11:
- 23:20 Changeset [77791] by
-
2011-02-06 Maciej Stachowiak <mjs@apple.com>
Reviewed by Daniel Bates.
Add WebKit2 bot to list of expected builders in Python regression test results.
https://bugs.webkit.org/show_bug.cgi?id=53905
- Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
- 22:49 Changeset [77790] by
-
2011-02-06 Maciej Stachowiak <mjs@apple.com>
Reviewed by Ryosuke Niwa.
Update test expectations for new core builder
https://bugs.webkit.org/show_bug.cgi?id=53904
- Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
- 22:20 Changeset [77789] by
-
2011-02-06 Maciej Stachowiak <mjs@apple.com>
Reviewed by David Levin.
Add WebKit2 test bot to core builders
https://bugs.webkit.org/show_bug.cgi?id=53901
- Scripts/webkitpy/common/net/buildbot/buildbot.py:
- 21:47 Changeset [77788] by
-
2011-02-06 Ryosuke Niwa <rniwa@webkit.org>
Another unreviewed Chromium build fix.
- DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::pathToLocalResource):
- 21:29 Changeset [77787] by
-
2011-02-06 Ryosuke Niwa <rniwa@webkit.org>
Unreviewed Chromium build fix.
- DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::pathToLocalResource):
2011-02-06 Ryosuke Niwa <rniwa@webkit.org>
Unreviewed; speculative Qt build fix.
- WebKit2.pro:
- 21:19 Changeset [77786] by
-
2011-02-06 Ryosuke Niwa <rniwa@webkit.org>
Unreviewed; speculative Qt build fix.
- JavaScriptCore.pro:
- 21:01 Changeset [77785] by
-
2011-02-06 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
OwnArraryPtr.h uses deleteOwnedPtr but doesn’t include OwnPtrCommon.h
https://bugs.webkit.org/show_bug.cgi?id=52867
- DumpRenderTree/chromium/ImageDiff.cpp: (Image::craeteFromStdin): Call adoptArrayPtr.
2011-02-06 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
OwnArraryPtr.h uses deleteOwnedPtr but doesn’t include OwnPtrCommon.h
https://bugs.webkit.org/show_bug.cgi?id=52867
Removed LOOSE_OWN_ARRAY_PTR and OwnArrayPtr<T>::set. Replaced all calls to OwnArrayPtr::set
and loose instantiation of OwnArrayPtr by calls to operator= and adoptArrayPtr. Also removed
OwnArrayPtrCommon.h since PassOwnArrayPtr.h needs to include OwnArrayPtr.h and there is
no point in putting deleteOwnedArrayPtr into a separate header.
Note: if this patch breaks build, the code is either instiantiating OwnArrayPtr
without calling adoptArrayPtr or calling set on ArrayOwnPtr instead of operator=.
No tests are added since this is a refactoring.
- API/JSStringRefCF.cpp: (JSStringCreateWithCFString): Calls adoptArrayPtr.
- GNUmakefile.am: Removed OwnArrayPtrCommon.h
- JavaScriptCore.vcproj/WTF/WTF.vcproj: Ditto.
- JavaScriptCore.xcodeproj/project.pbxproj: Ditto.
- runtime/Arguments.cpp: (JSC::Arguments::deleteProperty): Calls adoptArrayPtr.
- runtime/Arguments.h: (JSC::Arguments::copyRegisters): Ditto.
- runtime/JSPropertyNameIterator.cpp: (JSC::JSPropertyNameIterator::JSPropertyNameIterator): Ditto.
- runtime/JSVariableObject.h: (JSC::JSVariableObject::setRegisters): Calls operator= instead of set.
- runtime/StructureChain.cpp: (JSC::StructureChain::StructureChain): Ditto.
- wtf/CMakeLists.txt:
- wtf/DateMath.h: (JSC::GregorianDateTime::GregorianDateTime): No longer instnatiates OwnArrayPtr with a null pointer.
- wtf/OwnArrayPtr.h:
- wtf/OwnArrayPtrCommon.h: Removed.
- wtf/PassOwnArrayPtr.h: No longer includes OwnArrayCommon.h (WTF::deleteOwnedArrayPtr): Moved from OwnArrayPtrCommon.h
2011-02-06 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
OwnArraryPtr.h uses deleteOwnedPtr but doesn’t include OwnPtrCommon.h
https://bugs.webkit.org/show_bug.cgi?id=52867
- ForwardingHeaders/wtf/OwnArrayPtrCommon.h: Removed.
2011-02-06 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
OwnArraryPtr.h uses deleteOwnedPtr but doesn’t include OwnPtrCommon.h
https://bugs.webkit.org/show_bug.cgi?id=52867
- WebHistory.cpp: (WebHistory::orderedLastVisitedDays): Calls adoptArrayPtr.
- WebPreferences.cpp: (WebPreferences::copyWebKitPreferencesToCFPreferences): Ditto.
2011-02-06 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
OwnArraryPtr.h uses deleteOwnedPtr but doesn’t include OwnPtrCommon.h
https://bugs.webkit.org/show_bug.cgi?id=52867
- ForwardingHeaders/wtf/OwnArrayPtrCommon.h: Removed.
- bindings/v8/NPV8Object.cpp: (WebCore::createValueListFromVariantArgs): Returns PassOwnArrayPtr<v8::Handle<v8::Value>> instead of v8::Handle<v8::Value>*. (_NPN_Invoke): Calls createValueListFromVariantArgs. (_NPN_InvokeDefault): createValueListFromVariantArgs. (_NPN_Construct): createValueListFromVariantArgs.
- bindings/v8/ScriptFunctionCall.cpp: (WebCore::ScriptFunctionCall::call): Calls adoptArrayPtr. (WebCore::ScriptFunctionCall::construct): Ditto. (WebCore::ScriptCallback::call):
- bindings/v8/V8DOMWindowShell.cpp: (WebCore::V8DOMWindowShell::createNewContext): Ditto.
- bindings/v8/V8NPObject.cpp: (WebCore::npObjectInvokeImpl): Ditto
- bindings/v8/V8NodeFilterCondition.cpp: (WebCore::V8NodeFilterCondition::acceptNode): Ditto,
- html/HTMLAreaElement.cpp: (WebCore::HTMLAreaElement::parseMappedAttribute): Calls newCoordsArray.
- html/HTMLFrameSetElement.cpp: (WebCore::HTMLFrameSetElement::parseMappedAttribute): Calls newLengthArray.
- html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::getAttachedShaders): Calls adoptArraYptr. (WebCore::WebGLRenderingContext::simulateVertexAttrib0): Ditto. (WebCore::WebGLRenderingContext::LRUImageBufferCache::LRUImageBufferCache): Dito.
- platform/Length.cpp: (WebCore::newCoordsArray): Returns PassOwnArrayPtr<Length> instead of Length*. (WebCore::newLengthArray): Returns PassOwnArrayPtr<Length> instead of Length*.
- platform/Length.h: Prototype changes.
- platform/graphics/ANGLEWebKitBridge.cpp: (WebCore::ANGLEWebKitBridge::validateShaderSource): Calls adoptArrayPtr.
- platform/graphics/ca/win/CACFLayerTreeHost.cpp: (WebCore::getDirtyRects): Ditto.
- platform/graphics/chromium/ComplexTextControllerLinux.cpp: (WebCore::ComplexTextController::getNormalizedTextRun): Ditto.
- platform/graphics/chromium/HarfbuzzSkia.cpp: (WebCore::glyphsToAdvances): Ditto. (WebCore::canRender): Ditto.
- platform/graphics/gpu/Texture.cpp: (WebCore::Texture::updateSubRect): Ditto.
- platform/graphics/opengl/GraphicsContext3DOpenGL.cpp: (WebCore::GraphicsContext3D::paintRenderingResultsToCanvas): Ditto.
- platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::readbackHardwareToSoftware): Ditto.
- platform/graphics/wince/SharedBitmap.cpp: (WebCore::SharedBitmap::to16bit): Ditto.
- platform/win/ContextMenuWin.cpp: (WebCore::ContextMenu::getContextMenuItems): Ditto.
- platform/win/LoggingWin.cpp: (WebCore::initializeWithUserDefault): Ditto.
- plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackage::fetchInfo): Ditto.
2011-02-06 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
OwnArraryPtr.h uses deleteOwnedPtr but doesn’t include OwnPtrCommon.h
https://bugs.webkit.org/show_bug.cgi?id=52867
- Shared/Plugins/Netscape/win/NetscapePluginModuleWin.cpp: (WebKit::NetscapePluginModule::getPluginInfo): Calls adoptArrayPtr.
- 20:54 Changeset [77784] by
-
2011-02-06 Kent Tamura <tkent@chromium.org>
Unreviewed.
- WebCore.xcodeproj/project.pbxproj: Run sort-xcode-project-file.
- 20:08 Changeset [77783] by
-
2011-02-06 Patrick Gansterer <paroga@webkit.org>
Reviewed by Martin Robinson.
[WINCE] FrameLoaderClient calls loadURLInChildFrame on the child's frame loader
https://bugs.webkit.org/show_bug.cgi?id=53896
- WebView.cpp: (WebView::createFrame): Use coreFrame instead of childFrame.
- 18:20 Changeset [77782] by
-
2011-02-06 MORITA Hajime <morrita@google.com>
Unreviewed, unskip the html5lib test again which fails for another reason. (See Bug 53030)
- platform/qt/Skipped:
- 17:40 Changeset [77781] by
-
2011-02-06 Dominic Cooney <dominicc@google.com>
Reviewed by Dimitri Glazkov.
Convert <keygen> option elements to a shadow DOM
https://bugs.webkit.org/show_bug.cgi?id=51379
- html5lib/runner-expected.txt: Two more tests pass.
- platform/mac/fast/html/keygen-expected.txt: Shadow render tree.
- platform/mac/fast/invalid/residual-style-expected.txt:
2011-02-03 Dominic Cooney <dominicc@google.com>
Reviewed by Dimitri Glazkov.
Convert <keygen> option elements to a shadow DOM
https://bugs.webkit.org/show_bug.cgi?id=51379
Covered by existing tests e.g. fast/html/keygen.html,
html5lib/runner.html, etc.
- css/html.css: (form): Cleanup. (keygen, select): Border radii should match so focus ring looks good. (keygen::-webkit-keygen-select): No margin on the shadow element. (select): Hoisting border radius to keygen, select rule.
- dom/SelectElement.cpp: (WebCore::toSelectElement): keygen is no longer a select element.
- html/HTMLKeygenElement.cpp: Implements keygen shadow. (WebCore::KeygenSelectElement::create): (WebCore::KeygenSelectElement::shadowPseudoId): (WebCore::KeygenSelectElement::KeygenSelectElement): (WebCore::HTMLKeygenElement::HTMLKeygenElement): (WebCore::HTMLKeygenElement::parseMappedAttribute): (WebCore::HTMLKeygenElement::appendFormData): (WebCore::HTMLKeygenElement::formControlType): (WebCore::HTMLKeygenElement::reset): (WebCore::HTMLKeygenElement::selectShadow):
- html/HTMLKeygenElement.h: keygen is no longer a select on C++ side. (WebCore::HTMLKeygenElement::canStartSelection): (WebCore::HTMLKeygenElement::isEnumeratable): (WebCore::HTMLKeygenElement::isResettable):
- html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::ownerSelectElement): Only owned by selects.
- html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::HTMLSelectElement): Only 'select' tag name.
- 17:00 Changeset [77780] by
-
2011-02-06 James Kozianski <koz@chromium.org>
Reviewed by Ojan Vafai.
Add classes for representing test outputs.
https://bugs.webkit.org/show_bug.cgi?id=52136
These classes will make it easier to write scripts that deal with test
outputs such as rebaselining and deduping scripts. The intent is that
eventually we will be have buildbot return TestOutputs for a
particular build which can be compared with TestOutputs derived from a
local LayoutTests directory.
- Scripts/webkitpy/common/net/testoutput.py: Added.
- Scripts/webkitpy/common/net/testoutput_unittest.py: Added.
- Scripts/webkitpy/common/net/testoutputset.py: Added.
- Scripts/webkitpy/common/net/testoutputset_unittest.py: Added.
- Scripts/webkitpy/common/system/zip_mock.py: Added.
- 15:48 Changeset [77779] by
-
2011-02-06 Benjamin Poulain <ikipou@gmail.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Fix coding style errors in ClipboardQt.h
https://bugs.webkit.org/show_bug.cgi?id=43520
Fix coding style: order of header and indentation.
- platform/qt/ClipboardQt.h: (WebCore::ClipboardQt::create): (WebCore::ClipboardQt::clipboardData): (WebCore::ClipboardQt::invalidateWritableData):
- 14:16 Changeset [77778] by
-
2011-02-06 Patrick Gansterer <paroga@webkit.org>
Reviewed by Oliver Hunt.
Remove empty svg test
https://bugs.webkit.org/show_bug.cgi?id=53887
This files are empty. Empty tests are pretty useless.
- platform/chromium-win/svg/custom/use-infinite-recursion-expected.png: Removed.
- platform/mac/svg/custom/use-infinite-recursion-expected.checksum: Removed.
- platform/mac/svg/custom/use-infinite-recursion-expected.png: Removed.
- platform/mac/svg/custom/use-infinite-recursion-expected.txt: Removed.
- platform/qt/svg/custom/use-infinite-recursion-expected.txt: Removed.
- svg/custom/use-infinite-recursion.svg: Removed.
- 12:43 Changeset [77777] by
-
Use bloom filter for descendant selector filtering
https://bugs.webkit.org/show_bug.cgi?id=53880
Reviewed by Maciej Stachowiak.
Source/JavaScriptCore:
Implement a bloom filter with k=2 and 8 bit counting.
- GNUmakefile.am:
- JavaScriptCore.gypi:
- JavaScriptCore.vcproj/WTF/WTF.vcproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- wtf/BloomFilter.h: Added.
(WTF::BloomFilter::maximumCount):
(WTF::BloomFilter::BloomFilter):
(WTF::BloomFilter::mayContain):
(WTF::BloomFilter::add):
(WTF::BloomFilter::remove):
(WTF::BloomFilter::firstSlot):
(WTF::BloomFilter::secondSlot):
(WTF::::add):
(WTF::::remove):
(WTF::::clear):
(WTF::::likelyEmpty):
(WTF::::isClear):
Source/WebCore:
Bloom filter is faster than a hash set in this kind of use.
Shark thinks this speeds up style matching by ~30% on sites
with lots of descendant selectors.
- ForwardingHeaders/wtf/BloomFilter.h: Added.
- css/CSSStyleSelector.cpp:
(WebCore::collectElementIdentifierHashes):
(WebCore::CSSStyleSelector::pushParent):
(WebCore::CSSStyleSelector::popParent):
(WebCore::CSSStyleSelector::fastRejectSelector):
(WebCore::RuleData::collectDescendantSelectorIdentifierHashes):
- css/CSSStyleSelector.h:
- 12:05 Changeset [77776] by
-
2011-02-06 Maciej Stachowiak <mjs@apple.com>
Reviewed by Antti Koivisto.
media/video-document-types.html sometimes crashes the WebProcess
https://bugs.webkit.org/show_bug.cgi?id=53884
No new tests. Already covered by media/video-document-types.html
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::userCancelledLoad): Stop the load timer when cancelling the load.
- 10:52 Changeset [77775] by
-
2011-02-06 Patrick Gansterer <paroga@webkit.org>
Reviewed by Adam Roben.
[WIN] Use WCHAR instead of TCHAR
https://bugs.webkit.org/show_bug.cgi?id=53863
We always use the UNICODE versions of windows functions, so
the usage of TCHAR makes no sense and mixing them is bad style.
- platform/graphics/win/IconWin.cpp: (WebCore::Icon::createIconForFiles):
- platform/graphics/win/QTMovie.cpp:
- platform/graphics/win/QTMovieGWorld.cpp: (QTMovieGWorld::fullscreenWndProc): (QTMovieGWorld::enterFullscreen):
- platform/graphics/win/SimpleFontDataCGWin.cpp: (WebCore::SimpleFontData::platformInit):
- platform/graphics/win/SimpleFontDataCairoWin.cpp:
- platform/graphics/win/SimpleFontDataWin.cpp:
- platform/graphics/wince/SimpleFontDataWinCE.cpp:
- platform/win/BString.cpp:
- platform/win/ClipboardWin.cpp: (WebCore::filesystemPathFromUrlOrTitle): (WebCore::createGlobalHDropContent): (WebCore::createGlobalImageFileDescriptor):
- platform/win/ContextMenuWin.cpp:
- platform/win/CursorWin.cpp: (WebCore::loadSharedCursor):
- platform/win/FileChooserWin.cpp: (WebCore::FileChooser::basenameForWidth):
- platform/win/PopupMenuWin.cpp: (WebCore::PopupMenuWin::popupClassName): (WebCore::PopupMenuWin::show):
- platform/win/PopupMenuWin.h:
- 10:44 Changeset [77774] by
-
2011-02-06 Patrick Gansterer <paroga@webkit.org>
Reviewed by Andreas Kling.
Replace FLT_MAX with std::numeric_limits
https://bugs.webkit.org/show_bug.cgi?id=53861
Also move EFL's userIdleTime from TemporaryLinkStubs into SystemTimeEfl.
- html/NumberInputType.cpp:
- html/parser/HTMLParserIdioms.cpp: (WebCore::parseToDoubleForNumberType):
- platform/brew/SystemTimeBrew.cpp: (WebCore::userIdleTime):
- platform/efl/SystemTimeEfl.cpp: (WebCore::userIdleTime):
- platform/efl/TemporaryLinkStubs.cpp:
- platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::setupAnimation):
- platform/win/SystemTimeWin.cpp: (WebCore::userIdleTime):
- platform/wx/SystemTimeWx.cpp: (WebCore::userIdleTime):
- 10:39 Notes on Content Security Policies edited by
- (diff)
- 10:38 Notes on Content Security Policies created by
- 10:31 Changeset [77773] by
-
2011-02-06 Robert Hogan <robert@webkit.org>
Reviewed by Andreas Kling.
[Qt] Remove unnecessary QRect assignment
https://bugs.webkit.org/show_bug.cgi?id=53873
- Api/qwebframe.cpp: (QWebFramePrivate::renderRelativeCoords):
- 10:18 Changeset [77772] by
-
2011-02-06 Robert Hogan <robert@webkit.org>
Reviewed by Andreas Kling.
[Qt] Clear page's groupName even when not in DRT
https://bugs.webkit.org/show_bug.cgi?id=53874
Matches behaviour of other ports.
- WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::closeWindowSoon):
2011-02-06 Robert Hogan <robert@webkit.org>
Reviewed by Andreas Kling.
[Qt] Clear page's groupName even when not in DRT
https://bugs.webkit.org/show_bug.cgi?id=53874
- DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::windowCloseRequested):
- 09:47 Changeset [77771] by
-
2011-02-06 Patrick Gansterer <paroga@webkit.org>
Reviewed by Andreas Kling.
[CMake] Add dependencies for Visual Studio projects
https://bugs.webkit.org/show_bug.cgi?id=53773
Add a JavaScriptCore dependecy to WebCore, so CMake can
generate the correct build order for the solution.
- CMakeLists.txt:
2011-02-06 Patrick Gansterer <paroga@webkit.org>
Reviewed by Andreas Kling.
[CMake] Add dependencies for Visual Studio projects
https://bugs.webkit.org/show_bug.cgi?id=53773
Add a WebCore dependecy to WebKit, so CMake can
generate the correct build order for the solution.
Remove JavaScriptCore dependecy, since WebCore already depends on it.
- CMakeLists.txt:
2011-02-06 Patrick Gansterer <paroga@webkit.org>
Reviewed by Andreas Kling.
[CMake] Add dependencies for Visual Studio projects
https://bugs.webkit.org/show_bug.cgi?id=53773
Add a WebKit dependecy to WinCELauncher, so CMake can
generate the correct build order for the solution.
- CMakeListsWinCE.txt:
- 09:14 Changeset [77770] by
-
2011-02-06 Patrick Gansterer <paroga@webkit.org>
Reviewed by Andreas Kling.
[CMake] Unify ENABLE_SVG sections
https://bugs.webkit.org/show_bug.cgi?id=53778
- CMakeLists.txt:
- 09:08 Changeset [77769] by
-
2011-02-06 Martin Robinson <mrobinson@igalia.com>
Reclassify a failing test and unskip another which should be passing now.
- platform/gtk/Skipped: Update the skipped list.
- 08:22 Changeset [77768] by
-
2011-02-06 Andreas Kling <kling@webkit.org>
Reviewed by Dirk Schulze.
Refactor Font::normalizeSpaces() to avoid an extra String copy.
https://bugs.webkit.org/show_bug.cgi?id=53871
Have normalizeSpaces() take UChar*,length arguments instead of a
String, since all call sites were creating temporaries from these
components anyway.
Font::normalizeSpaces() now always makes 1 String copy,
instead of 1 in the best case and 2 in the worst case.
- platform/graphics/Font.cpp: (WebCore::Font::normalizeSpaces):
- platform/graphics/Font.h:
- platform/graphics/qt/FontQt.cpp: (WebCore::drawTextCommon): (WebCore::Font::floatWidthForSimpleText): (WebCore::Font::floatWidthForComplexText): (WebCore::Font::offsetForPositionForSimpleText): (WebCore::Font::offsetForPositionForComplexText): (WebCore::Font::selectionRectForSimpleText): (WebCore::Font::selectionRectForComplexText):
- svg/SVGFont.cpp: (WebCore::SVGTextRunWalker::walk):
- 07:19 Changeset [77767] by
-
2011-02-06 Andreas Kling <kling@webkit.org>
Reviewed by Antonio Gomes.
[Qt] MiniBrowser: Clean up handling of titleChanged() signal
https://bugs.webkit.org/show_bug.cgi?id=53869
- MiniBrowser/qt/BrowserView.cpp: (BrowserView::BrowserView): Remove unnecessary titleChanged() handling.
- MiniBrowser/qt/BrowserWindow.cpp: (BrowserWindow::BrowserWindow): Connect titleChanged() directly to setWindowTitle().
- MiniBrowser/qt/BrowserWindow.h:
- 06:35 Changeset [77766] by
-
2011-02-06 Andreas Kling <kling@webkit.org>
Reviewed by Dirk Schulze.
Fix potential buffer overrun in SVGTextRunWalker::walk()
https://bugs.webkit.org/show_bug.cgi?id=53870
A new String was created from a UChar* with a 'length' argument
that could be greater than the number of UChars available.
- svg/SVGFont.cpp: (WebCore::SVGTextRunWalker::walk):
- 05:23 Changeset [77765] by
-
2011-02-06 Benjamin Poulain <ikipou@gmail.com>
Reviewed by Andreas Kling.
[Qt] WebKit does not build on Mac with WebKit 2
https://bugs.webkit.org/show_bug.cgi?id=53380
- Platform/CoreIPC/qt/ConnectionQt.cpp: Use fcntl() to set close on exec so we do not rely on recent kernel. (CoreIPC::Connection::readyReadHandler):
- Platform/qt/SharedMemoryQt.cpp: ditto (WebKit::SharedMemory::create): (WebKit::SharedMemory::createHandle):
- UIProcess/Launcher/qt/ProcessLauncherQt.cpp: Guard prctl() since it is a Linux specific function. (WebKit::QtWebProcess::setupChildProcess):
- UIProcess/DrawingAreaProxy.h: Differentiate between building on Mac and the Mac port.
- UIProcess/DrawingAreaProxyImpl.cpp: ditto
- UIProcess/WebPageProxy.cpp: ditto (WebKit::WebPageProxy::didReceiveMessage):
- WebProcess/WebPage/DrawingArea.cpp: ditto (WebKit::DrawingArea::create):
- WebProcess/WebPage/DrawingArea.h:
- WebProcess/WebPage/DrawingAreaImpl.cpp: ditto
- WebProcess/WebPage/WebPage.cpp: ditto (WebKit::WebPage::didReceiveMessage):
- 02:46 Changeset [77764] by
-
2011-02-06 Robert Hogan <robert@webkit.org>
Unreviewed, skip failing test on Qt bot.
[Qt] fast/notifications/notifications-document-close-crash.html fails after r77738
https://bugs.webkit.org/show_bug.cgi?id=53868
- platform/qt/Skipped: Skip fast/notifications/notifications-document-close-crash.html
- 02:35 Changeset [77763] by
-
2011-02-06 Maciej Stachowiak <mjs@apple.com>
Reviewed by Dan Bernstein.
WebKitTestRunner needs layoutTestController.setWillSendRequestReturnsNull
https://bugs.webkit.org/show_bug.cgi?id=42690
<rdar://problem/8213851>
- platform/mac-wk2/Skipped: Unskip tests that now pass, except for the ones that mysteriously fail.
2011-02-06 Maciej Stachowiak <mjs@apple.com>
Reviewed by Dan Bernstein.
WebKitTestRunner needs layoutTestController.setWillSendRequestReturnsNull
https://bugs.webkit.org/show_bug.cgi?id=42690
<rdar://problem/8213851>
- WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::willSendRequestForFrame):
- WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::LayoutTestController):
- WebKitTestRunner/InjectedBundle/LayoutTestController.h: (WTR::LayoutTestController::willSendRequestReturnsNull): (WTR::LayoutTestController::setWillSendRequestReturnsNull):
